re-order columns for handwritten ClusterAuth.eks

Description of your changes
There was a recent change in upjet that swapped the order of the Ready and Synced columns in the generated managed resource CRDs. That's already been merged and released in provider-upjet-aws. However, we forgot about ClusterAuth.eks, which is the only (I think?) CRD that's not generated by upjet.
The result is that currently when listing managed resources, for all MR kinds other than ClusterAuth, Synced appears before Ready, but for ClusterAuth, Ready appears before synced.
This PR fixes that.

I have:

[ ] Read and followed Crossplane's contribution process.
[ ] Run make reviewable to ensure this PR is ready for review.
[ ] Added backport release-x.y labels to auto-backport this PR if necessary.

How has this code been tested

/test-examples="examples/eks/v1beta1/clusterauth.yaml"

/test-examples="examples/eks/v1beta1/clusterauth.yaml"

Thank you @mbbush 🙌


Cancel install for IW now looks a bit odd

Testing #9434
If you cancel ipykernel install for an IW launch it now looks funny compared to the notebook message.
IW:

Notebook message is much better:

Closing as a dup of https://github.com/microsoft/vscode-jupyter/issues/9444

/verified


FillY doesn't always work in ScatterCharts with data gaps

I would like to use the scatter chart to visualize measured values for a day. I have a list of measured values with a timestamp and the given value. The line is always drawn correctly in all cases, only in the case of data gaps (NaN values) there is a strange behavior when filling the chart. For example, if the chart starts with a NaN Value or ends with a NaN Value, the chart will not be filled. If I remove these spots, the filling works.
It is the same, if I have a data gap in the middle of my measured values, then it can also happen that the diagram is not filled correctly.
I hope the sample can help you reproduce:
ScottPlot Version: 5.0.37
string PlottScatter()
{
    var plotValues = new List<PlotValue>()
    {
        new(new DateTime(2024, 08, 06, 7, 50, 0), double.NaN),
        new(new DateTime(2024, 08, 06, 7, 55, 0), 0),
        new(new DateTime(2024, 08, 06, 8, 0, 0), 500),
        new(new DateTime(2024, 08, 06, 8, 5, 0), 600),
        new(new DateTime(2024, 08, 06, 8, 10, 0), 700),
        new(new DateTime(2024, 08, 06, 8, 16, 0), 800),
        new(new DateTime(2024, 08, 06, 8, 20, 0), 900),
        new(new DateTime(2024, 08, 06, 8, 25, 0), 1000),
        new(new DateTime(2024, 08, 06, 8, 30, 0), 1100),
        new(new DateTime(2024, 08, 06, 8, 35, 0), 1200),
        new(new DateTime(2024, 08, 06, 8, 40, 0), 1300),
        new(new DateTime(2024, 08, 06, 8, 45, 0), 1400),
        new(new DateTime(2024, 08, 06, 8, 50, 0), 1500),
        new(new DateTime(2024, 08, 06, 14, 15, 0), 0),
        new(new DateTime(2024, 08, 06, 14, 20, 0), double.NaN),
    };

    var xValues = plotValues.Select(x => x.Timestamp.ToOADate()).ToArray();
    var yValues = plotValues.Select(x => x.Value).ToArray();

    var plot = new Plot();
    var signalScatter = plot.Add.Scatter(xValues, yValues.ToArray());

    var y2Values = GenerateZeroBasedY2Values(yValues.Count());

    plot.Add.FillY(xValues,
        yValues.ToArray(),
        y2Values);

    plot.Axes.DateTimeTicksBottom();
    signalScatter.MarkerSize = 0;
    plot.Axes.Margins(0.004, 0, 0);
    plot.Axes.SetLimitsX((new DateTime(2024, 08, 06, 0, 0, 0).ToOADate()), new DateTime(2024, 08, 07, 0, 0, 0).ToOADate());
    return plot.GetImageHtml(720, 480);
}

static double[] GenerateZeroBasedY2Values(int valueCount)
{
    var fillArray = new List<double>();
    for (var i = 0; i < valueCount; i++)
    {
        fillArray.Add(0);
    }

    return fillArray.ToArray();
}

class PlotValue
{
    public DateTime Timestamp { get; set; }

    public double Value { get; set; }

    public PlotValue(DateTime timestamp, double value)
    {
        Timestamp = timestamp;
        Value = value;
    }
}

If you remove the starting and ending NaN Values it will look like this:

To reproduce the other case, add a NaN Value at 08:25 and the chart will no longer be filled

Hi @robeckh, I don't intend to implement this fix myself but if you want to look into it I suspect the issue could be resolved by removing NaN values from the data before the fill methods are called in the scatter plot class
https://github.com/ScottPlot/ScottPlot/blob/main/src/ScottPlot5/ScottPlot5/Plottables/Scatter.cs
If you or someone else creates a pull request, I'd be happy to review it in good time! 🚀


Wrap the restoration of system streams in finally

Move the restoration of system default input, output, error streams in finally block in case of runnable exits with an exception.

fixed in commit e79e2c42d1eee1605a1dd32b22595923f6eb5783


Add new named_strings output adapter

New output adapter to return an object with named string attributes. This is useful for when you want to extract a few different types of strings from a text or want to construct an object based on a prompt.
For example, say you have a product with some attributes and you want to generate a short description, long description, key features, and target audience.  Or have a blog post and want to extract the key ideas, major points, summary, and followup questions.
As part of this change we've also introduced some post-processing for results where you can optionally add materialize_result(raw_results) to your output_adapter and return a better formatted object or attribute to your generator.

finishes #13


GVL 5.0 beta4 (Galaxy 20.05) Failure

I cannot start the instance. Please take in account that I am a new user, with no experience. Thank you!
FAILURE
Create appliance task failed: An error occurred (AccessDenied) when calling the GetRole operation: User: arn:aws:iam::212571630875:user/cloudlaunch is not authorized to perform: iam:GetRole on resource: role elettod-genomics-virtual-lab-20-08-10-cm2-kube-role

@elettod This is because your AWS account does not have sufficient privileges. Please refer to these issues for more info: https://github.com/galaxyproject/cloudlaunch/issues/205
https://github.com/galaxyproject/cloudlaunch/issues/207


Java extensions of TileDataSource create hickups

Implementing MergedMBVTTileDataSource in this PR i found ou that the Java implemention of it here creates hickups while the C implemention does not.
It's very noticeable.
I am wondering if it comes from a conversion of the BinaryData when going from Java to C?

Any chance the hiccups are created by garbage collection cycles? This should be visible in logical. Other than that, no idea really. The implementation looks exactly how I would write this.

@mtehver  no idea yet. would need to take a deeper look at this.Does jni convert the tiledata or is it passed as it is?

@farfromrefug All processing is done on the native side. Not sure what you mean by JNI here. JNI layer processing should be quite thin, perhaps it is doing some memory pinning but it should not be that expensive.
Anyway, I think I will review and merge the native MergedMBVTTileDataSource to the SDK now.

@mtehver if you have a Java TileSource, when the java loadTile version returns, it must be returning its result to the method it was run from.
In this case if i am correct my java loadTile is called from C++ using JNI. So the result TileData result also transits from Java to C++ through JNI.

@farfromrefug This could be related to #278, BinaryData constructor had a JNI reference leak. Could you confirm that 4.2.0 RC works without hiccups?

Yes i read about that other issue. Will test on 4.2.0 and report here

@farfromrefug I think this was fixed in SDK 4.2.0. Can I close the issue or is there anything else that needs investigation?

@mtehver TBH i did not have time to test that again. Plus most of the classes i was using in JAva were merged in C++ so lets close this for now


how to set hg38 for annotation genome?

Just wanted to know if there was a way to specify the hg38 reference genome for the CNV.create_anno step, I couldn't find any arguments that allow this but I could have missed something. Thank you!

Hi,
thank you for your question. Currently there is no way to specify the hg38 reference genome, but a liftover from the EPICv2 probe annotations has been performed and is used as a reference in the CNV.create_anno function for EPICv2 arrays.

Hi,
we just released an update that provides support for hg38 annotation. Please use:
data("detail_regions.hg38")
anno <- CNV.create_anno(array_type = "EPICv2", genome = hg38, detail_regions = detail_regions)

Best regards,
Bjarne


LLVM4 crash: Cannot select ... & other errors in codegen

First, version:
$ crystal -v
Crystal 0.22.0 (2017-04-22) LLVM 4.0.0

The faulty code:
Kilobyte = 1024u32
Megabyte = 1024u32 * Kilobyte
Gigabyte = 1024u32 * Megabyte

struct BigStruct
  @some_array : UInt8[Megabyte]?
end

BigStruct.new

sleep 3

Carc-in is broken on this one: https://carc.in/#/r/22nn
I get the output:
Parse:                             00:00:00.0000907 (   0.19MB)
Semantic (top level):              00:00:00.0820709 (  27.11MB)
Semantic (new):                    00:00:00.0006868 (  27.11MB)
Semantic (type declarations):      00:00:00.0100532 (  35.11MB)
Semantic (abstract def check):     00:00:00.0006654 (  35.11MB)
Semantic (ivars initializers):     00:00:00.0007388 (  35.11MB)
Semantic (cvars initializers):     00:00:00.0052621 (  35.11MB)
Semantic (main):                   00:00:00.0713333 (  43.17MB)
Semantic (cleanup):                00:00:00.0005363 (  51.17MB)
Semantic (recursive struct check): 00:00:00.0004676 (  51.17MB)
Codegen (crystal):                 00:00:00.1255013 (  51.29MB)
Codegen (bc+obj):                 LLVM ERROR: Cannot select: 0x7ecc960: ch,glue = callseq_end 0x7ecd388, TargetConstant:i64<0>, TargetConstant:i64<0>, 0x7ecd388:1
  0x7edc950: i64 = TargetConstant<0>
  0x7edc950: i64 = TargetConstant<0>
  0x7ecd388: ch,glue = X86ISD::CALL 0x7edd310, TargetGlobalAddress:i64<%BigStruct ()* @"*BigStruct::new:BigStruct"> 0 [TF=6], Register:i64 %RDI, RegisterMask:Untyped, 0x7edd310:1
    0x7edcc28: i64 = TargetGlobalAddress<%BigStruct ()* @"*BigStruct::new:BigStruct"> 0 [TF=6]
    0x7eded18: i64 = Register %RDI
    0x7eccdd8: Untyped = RegisterMask
    0x7edd310: ch,glue = CopyToReg 0x7ecd3f0, Register:i64 %RDI, FrameIndex:i64<7>
      0x7eded18: i64 = Register %RDI
      0x7ecc7c0: i64 = FrameIndex<7>
In function: __crystal_main

^C

There where an infinite loop at the end, I needed to Ctrl-C it..

If I remove the sleep 3, the LLVM error goes away, but not the infinite loop (the sleep's time doesn't change anything)

If I remove the BigStruct.new line, no error (but the program does nothing obviously!)

If I use numbers instead of constants (in UInt8[1048576]?) doesn't change anything

If I change Megabyte to Gigabyte in UInt8[Gigabyte]?, I get a completely different error (still in codegen though):

Parse:                             00:00:00.0001064 (   0.19MB)
Semantic (top level):              00:00:00.0830904 (  27.10MB)
Semantic (new):                    00:00:00.0006906 (  27.10MB)
Semantic (type declarations):      00:00:00.0096108 (  35.10MB)
Semantic (abstract def check):     00:00:00.0006449 (  35.10MB)
Semantic (ivars initializers):     00:00:00.0007385 (  35.10MB)
Semantic (cvars initializers):     00:00:00.0053483 (  35.10MB)
Semantic (main):                   00:00:00.0730416 (  51.16MB)
Semantic (cleanup):                00:00:00.0005108 (  51.16MB)
Semantic (recursive struct check): 00:00:00.0004811 (  51.16MB)
Codegen (crystal):                 00:00:00.1198496 (  51.29MB)
Codegen (bc+obj):                 Invalid memory access (signal 11) at address 0x1dffffd0
[0x43cebf] __crystal_sigfault_handler +63
[0x7f8d68cfdfe0] ???
[0x7f8d6a5b319f] _ZN4llvm13GetReturnInfoEPNS_4TypeENS_12AttributeSetERNS_15SmallVectorImplINS_3ISD9OutputArgEEERKNS_14TargetLoweringERKNS_10DataLayoutE +735
[0x7f8d6a648dcd] _ZN4llvm20FunctionLoweringInfo3setERKNS_8FunctionERNS_15MachineFunctionEPNS_12SelectionDAGE +269
[0x7f8d6a76ac2e] _ZN4llvm16SelectionDAGISel20runOnMachineFunctionERNS_15MachineFunctionE +926
[0x7f8d6b9a1e74] ???
[0x7f8d6a446841] _ZN4llvm19MachineFunctionPass13runOnFunctionERNS_8FunctionE +145
[0x7f8d6a2c6b32] _ZN4llvm13FPPassManager13runOnFunctionERNS_8FunctionE +642
[0x7f8d6a2c6bd3] _ZN4llvm13FPPassManager11runOnModuleERNS_6ModuleE +51
[0x7f8d6a2c7584] _ZN4llvm6legacy15PassManagerImpl3runERNS_6ModuleE +772
[0x7f8d6b164c45] ???
[0x7f8d6b164f64] LLVMTargetMachineEmitToFile +244
[0x13d26ca] ???
[0x13d6d53] ???
[0x411668] ???
[0x0] ???
Invalid memory access (signal 11) at address 0x3bffffd0
[0x43cebf] __crystal_sigfault_handler +63
[0x7f8d68cfdfe0] ???
[0x7f8d6a5b319f] _ZN4llvm13GetReturnInfoEPNS_4TypeENS_12AttributeSetERNS_15SmallVectorImplINS_3ISD9OutputArgEEERKNS_14TargetLoweringERKNS_10DataLayoutE +735
[0x7f8d6a63b6eb] _ZN4llvm8FastISel11lowerCallToERNS0_16CallLoweringInfoE +363
[0x7f8d6a63d14f] _ZN4llvm8FastISel9lowerCallEPKNS_8CallInstE +1391
[0x7f8d6a640b84] _ZN4llvm8FastISel10selectCallEPKNS_4UserE +100
[0x7f8d6a63df8d] _ZN4llvm8FastISel14selectOperatorEPKNS_4UserEj +413
[0x7f8d6a643333] _ZN4llvm8FastISel17selectInstructionEPKNS_11InstructionE +883
[0x7f8d6a768e68] _ZN4llvm16SelectionDAGISel20SelectAllBasicBlocksERKNS_8FunctionE +696
[0x7f8d6a76ad49] _ZN4llvm16SelectionDAGISel20runOnMachineFunctionERNS_15MachineFunctionE +1209
[0x7f8d6b9a1e74] ???
[0x7f8d6a446841] _ZN4llvm19MachineFunctionPass13runOnFunctionERNS_8FunctionE +145
[0x7f8d6a2c6b32] _ZN4llvm13FPPassManager13runOnFunctionERNS_8FunctionE +642
[0x7f8d6a2c6bd3] _ZN4llvm13FPPassManager11runOnModuleERNS_6ModuleE +51
[0x7f8d6a2c7584] _ZN4llvm6legacy15PassManagerImpl3runERNS_6ModuleE +772
[0x7f8d6b164c45] ???
[0x7f8d6b164f64] LLVMTargetMachineEmitToFile +244
[0x13d26ca] ???
[0x13d6d53] ???
[0x411668] ???
[0x0] ???
 00:00:04.0648193 (  51.29MB)
Codegen (linking):                _main.o: file not recognized: File truncated
collect2: error: ld returned 1 exit status
Error: execution of command failed with code: 1: `cc -o "/home/lesell_b/tests/crystal/fork_on_oom/fork_and_stack" "${@}"  -rdynamic  -lpcre -lgc -lpthread /usr/lib/crystal/ext/libcrystal.a -levent -lrt -ldl -L/usr/lib -L/usr/local/lib`

This last error seams to be LLVM that violently crash, I don't know how I could report this to LLVM team..
Note: Is it just me ? (carcin can't comfirm, and I have only one computer to test right now)

Is it just me ?

I can confirm this on Crystal 0.22.0 (2017-04-22) LLVM 4.0.0, I'm also getting the same error as you are

If you use --release flag error disappear.
crystal build -s --release g4452.cr
Parse:                             00:00:00.0001905 (   0.19MB)
Semantic (top level):              00:00:00.2001953 (  27.20MB)
Semantic (new):                    00:00:00.0013384 (  27.20MB)
Semantic (type declarations):      00:00:00.0172932 (  27.20MB)
Semantic (abstract def check):     00:00:00.0014872 (  27.20MB)
Semantic (ivars initializers):     00:00:00.0011554 (  27.20MB)
Semantic (cvars initializers):     00:00:00.0124931 (  35.20MB)
Semantic (main):                   00:00:00.1674670 (  43.26MB)
Semantic (cleanup):                00:00:00.0009177 (  43.26MB)
Semantic (recursive struct check): 00:00:00.0011832 (  43.26MB)
Codegen (crystal):                 00:00:00.1593567 (  51.26MB)
Codegen (bc+obj):                  00:00:09.0689940 (  51.26MB)
Codegen (linking):                 00:00:00.0604327 (  51.26MB)

Codegen (bc+obj):
 - no previous .o files were reused

As far as I know, LLVM doesn't handle well big arrays (array being an LLVM type that we use to represent static arrays). And the bigger they are, the longer it takes to compile a program, and much more to optimize it.
I think the compiler should disallow static arrays bigger than, say, 10K or 20K. There's no reason to use them instead of a regular Array.

LLVM must have a hard time dealing with a huge gap on the stack. The program may crash randomly, too, since the stack has a limited size. I agree we should limit the maximum size of structs to an acceptable limit. If I recall correctly, HTTP/2 uses a 16KB frame size by default. It would be nice to keep a 16KB buffer on the stack (or maybe twice that, 32KB), if it's acceptable.

StaticArray(UInt8, 32000).new crashes in carc.in, and 16000 too, so the limit is smaller, like a 10000.

Should we keep this issue open or can I choose it?

Let's leave this open for now

Tried this in
$ crystal --version
Crystal 0.31.1 (2019-10-02)

LLVM: 8.0.1
Default target: x86_64-apple-macosx

Maybe I didn't wait long enough but this is the only thing I get after quite a while:
$ crystal test.cr
^C

#12780 disallows instantiating large static array types. The example from the OP now fails with this error message:

can't instantiate StaticArray(T, N) with N = 1048576 (N must be <= 10000)

I'm wondering if there should be a recommendation to use Array (or Slice) instead and maybe a reference to this issue?

#12801 is a new approach to raise compiler errors when passing large value types around.
For the example code in the OP it creates this error message:
In .test/bigstruct.cr:5:1

 5 | struct BigStruct
     ^-------
Error: returns a large value type: BigStruct

The exact crash happens when there are 65536 or more (sub)aggregate elements: llvm/llvm-project#55737


'expected' and 'actual' wrong way around

The syntax for the test method is:
assertEquals(expected, actual);
Swapping them around make no difference to whether the test will pass of fail, it just makes understanding it clearer if it ever fails. Eg, it will say something like:
Expected "error" but was "string"
when it should have been:
Expected "string" but was "error"

Thanks!

@mattburns - maybe I was too quick on the trigger. Looks like it's the other way around - http://testng.org/javadoc/org/testng/Assert.html#assertEquals(boolean, boolean)

Ahh, my mistake. I didn't notice you were using TestNG and I didn't know the order was different from JUnit. Sorry for the time wasted...

No problem, thanks for looking out.


Safari support

Hi, would be possible to add Safari support as well?

Yes, it's absolutely possible, but Apple charges developers $99/year to distribute Safari extensions, so it doesn't really make sense financially for me to pay that just to offer support for a free extension.


Upgrade com.puppycrawl.tools:checkstyle 10.4 -> 10.5.0

This PR contains the following updates:

Package
Type
Update
Change

com.puppycrawl.tools:checkstyle (source)
build
minor
10.4 -> 10.5.0

[ ] If you want to rebase/retry this PR, click this checkbox.

Suggested commit message:
Upgrade Checkstyle 10.4 -> 10.5.0

See:
- https://checkstyle.sourceforge.io/releasenotes.html
- https://github.com/checkstyle/checkstyle/releases/tag/checkstyle-10.5.0
- https://github.com/checkstyle/checkstyle/compare/checkstyle-10.4...checkstyle-10.5.0


pipleinesascode website shows images/logo not found

https://pipelinesascode.com/
images/logo are not rendering

was working before
i guess stop working after https://github.com/openshift-pipelines/pipelines-as-code/commit/7d732bcf047fe2056021459a97f73eedfe5209e1 change

@chmouel tried this
working locally but not website 🤔

yeah should be "fixed" when we make a new release,  since the build command on cloudfare changed for main,
https://main.pipelines-as-code.pages.dev/

if that doesn't work we could just "embed" the svg directly in html and not have an issue with it anymore

I rebuild it manually in cloudfare and it now shows the logo properly..


Rank up from 1 kyu to 1 kyu

Yesterday I had 1st kyu (had it long time ago, js and overall) and 90%+ to 1st dan on the circle diagram in profile.
I got some more honor from katas and got rank up notification about up to 1st kyu.
Current stats:
Honor:21,001 (99%from js)
Overall:1 kyu / 0.1%
JavaScript:2 kyu / 99.5%
profile: https://www.codewars.com/users/e.mihaylin
Rank table here (I dont remember clear, but it seams that smth changed in ranking with time) https://docs.codewars.com/gamification/ranks/ says now:
1 kyu | 13,147
1 dan | 35,759
So the diagram was falsy about almost 1st dan yesterday and it is falsy about  0.1% with 21,001 honor now.

Hello,
Yes, some points got removed because it's been found you plagiarized some solutions to purple or blue kata. The current stats are what's left.
Honor has "nothing" to do with your rank, so that part is unrelated.
Cheers

Hi.
What is considered as plagiate and forbidden?
Interested in edge cases:

Is it plagiate for any result, when solutions are grouped as similar?
For example, there are some katas (for example, code golf, with short solutions, when grouping is unavoidable).
Is it plagiate when I complete kata with my solution, submit it, take someones other solution after my 1st submit, try it, improve it and submit again?
Is it plagiate when I take not my solution before my 1st submit, try it (not submit), and then a) submit my solution based on not my b) submit my solution not based on not my.
As far as I remember, I did not submitted just copied elsewhere code, but I have putted it to successfull tests many times (remeber many times when could not get needed time complexity and tried not my approaches).
I want to understand where the border line is to not to cross it.

Is it plagiate for any result, when solutions are grouped as similar?
For example, there are some katas (for example, code golf, with short solutions, when grouping is unavoidable).

Code golf kata are a bit edgy. No general answer there, it depends on the context and other parameters. Otherwise grouping matters, yes. But not only.

Is it plagiate when I complete kata with my solution, submit it, take someones other solution after my 1st submit, try it, improve it and submit again?

No

Is it plagiate when I take not my solution before my 1st submit, try it (not submit), and then a) submit my solution based on not my b) submit my solution not based on not my.

I'm not sure to understand what you're describing. Apparently, you're talking about trying in the trainer a working solution that isn't yours first. If so, answer is yes.

As far as I remember, I did not submitted just copied elsewhere code,

According to what's been found in your solutions, you did. From time to time.

Thank you


Add LLDP support

This patch introduces LLDP support. Currently, integration tests are missing.

I am trying to figure out how to add integration tests for this. I cannot even add unit tests using MagicMock because NM.LldpNeighbor object store the properties values in attributes but currently the object does not support setting attributes through libnm.
Any suggestion on this? Thanks!

Yay! Tests are passing. This patch is ready for reviewing. :-)

There is no changed on the verification stage.
When user applying the same yml from show() with LLDP status changed, there will be a verification failure.

Done, it should not fail on verification now.

Rebased with the new metadata and merge state flow. Thanks!

Looks good and works for me, great work!
For me it even worked in combination with lldpad.
I did not check if it would work with OVS and FCoE, but I ensure that this is checked this in the long run.
For oVirt it would be helpful if the following TLVs would be added:

TTL (tlv type 3), to show document how old the lldp information might be,
Port Description (tlv type 4)
VLAN Name (tlv tpe 0x7f, oui 0x0080C2  (similar to Port port-vlan), subtype 3)
Link Aggregation ( oui 0x0080C2, subtype 7 )
Link Aggregation ( oui 0x00120F, subtype 3 )
MTU ( oui 0x00120F, subtype 4 )

Would be nice, if there would be a way to distinguish between the two Link Aggregation TLVs.

The suggested API mimics NM and lldpad outputs, giving informal naming for the data, assuming the end user is the one consuming it.
But even products like oVirt do not assume this, exposing the data in a formal unambiguous manner with the addition of human readable namings.
I think this is the main difference from the original spec https://github.com/nmstate/nmstate/pull/64 .
I would prefer to see a more formal output that applications may consume easily without the need to interpret nmstate naming.
But if you still prefer the current approach, please document the exact details of the data source (numeric type, subtypes and oid/s).

The suggested API mimics NM and lldpad outputs, giving informal naming for the data, assuming the end user is the one consuming it.
But even products like oVirt do not assume this, exposing the data in a formal unambiguous manner with the addition of human readable namings.
I think this is the main difference from the original spec #64 .
I would prefer to see a more formal output that applications may consume easily without the need to interpret nmstate naming.
But if you still prefer the current approach, please document the exact details of the data source (numeric type, subtypes and oid/s).

As we are not using adding everything on the schema I propose:

Merge this so RHV and other users can test it and use it.
Implement missing features as @dominikholler requested, when possible from NM.
We can create a field like "formal" in the lldp subtree, if true then we can use formal names if False then we use the human readable.

What do you think?

@cathay4t I've done all your requested changes. Thanks!

According to the feedback received, I've implemented a new schema approach. Now lldp has a neighbors subtree that contains a list of neighbors. Each neighbor is represented by a list of TLVs.
Each TLV is a dict containing the tlv-type, the tlv-subtype and the oid if needed. In addition, it contains the informal name and the value. The value could be a single value(string or integer) or a dict because some TLV contains different fields.
    interfaces:
    - name: eth1
      type: ethernet
      state: up
      ipv4:
        dhcp: false
        enabled: false
      ipv6:
        autoconf: false
        dhcp: false
        enabled: false
      lldp:
        enabled: true
        neighbors:
        - - name: system-name
            tlv-type: 5
            value: Summit300-48
          - name: system-description
            tlv-type: 6
            value: Summit300-48 - Version 7.4e.1 (Build 5) by Release_Master 05/27/05
              04:53:11
          - name: system-capabilities
            tlv-type: 7
            value:
            - mac-bridge
            - router
          - name: chassis-id
            tlv-type: 1
            value:
              chassis-id: 00:01:30:F9:AD:A0
              chassis-id-type: mac
          - name: port-id
            tlv-type: 2
            value:
              port-id: 1/1
              port-id-type: interface-name
          - name: ieee-802-1-vlans
            oid: 00:80:c2
            tlv-subtype: 1
            tlv-type: 127
            value:
            - name: v2-0488-03-0505
              vid: 488
          - name: ieee-802-3-mac-phy-conf
            oid: 00:12:0f
            tlv-subtype: 1
            tlv-type: 127
            value:
              autoneg: true
              operational-mau-type: 16
              pmd-autoneg-cap: 27648
          - name: ieee-802-1-ppvids
            oid: 00:80:c2
            tlv-subtype: 2
            tlv-type: 127
            value:
            - ppvid: 0
          - name: management-addresses
            tlv-type: 8
            value:
            - address: 00::01::30::F9::AD::A0
              address-subtype: ipv6
              interface-number: 1001
              interface-number-subtype: ifindex
          - name: ieee-802-3-max-frame-size
            oid: 00:12:0f
            tlv-subtype: 4
            tlv-type: 127
            value: 1522
      mac-address: 36:E6:3A:97:AF:C9
      mtu: 1500

I hope you like more this approach. Thanks for the feedback and reviews! @cathay4t @EdDev @tyll

    interfaces:
    - name: eth1
      type: ethernet
      state: up
      ipv4:
        dhcp: false
        enabled: false
      ipv6:
        autoconf: false
        dhcp: false
        enabled: false
      lldp:
        enabled: true
        neighbors:
        - - name: system-name
            tlv-type: 5

The tlv prefix seems to be redundant, since this would mean: type-length-value-type, just type seems to be sufficient for me.

        value: Summit300-48
      - name: system-description
        tlv-type: 6
        value: Summit300-48 - Version 7.4e.1 (Build 5) by Release_Master 05/27/05 04:53:11
      - name: system-capabilities
        tlv-type: 7
        value:
        - mac-bridge
        - router

Are these values (mac-bridge, router) official values or should they use IDs as well?

      - name: chassis-id
        tlv-type: 1
        value:
          chassis-id: 00:01:30:F9:AD:A0
          chassis-id-type: mac
      - name: port-id
        tlv-type: 2
        value:
          port-id: 1/1
          port-id-type: interface-name

Are port-id(-type) official names and interface-name?

      - name: ieee-802-1-vlans
        oid: 00:80:c2
        tlv-subtype: 1
        tlv-type: 127
        value:
        - name: v2-0488-03-0505
          vid: 488
      - name: ieee-802-3-mac-phy-conf
        oid: 00:12:0f
        tlv-subtype: 1
        tlv-type: 127
        value:
          autoneg: true
          operational-mau-type: 16
          pmd-autoneg-cap: 27648

Are autoneg etc. offician names?

      - name: ieee-802-1-ppvids
        oid: 00:80:c2
        tlv-subtype: 2
        tlv-type: 127
        value:
        - ppvid: 0

Is this an official name?

      - name: management-addresses
        tlv-type: 8
        value:
        - address: 00::01::30::F9::AD::A0

Are the double colons correct? Are the keys here official names?

          address-subtype: ipv6
          interface-number: 1001
          interface-number-subtype: ifindex

Are the names here official names?

      - name: ieee-802-3-max-frame-size
        oid: 00:12:0f
        tlv-subtype: 4
        tlv-type: 127
        value: 1522
  mac-address: 36:E6:3A:97:AF:C9
  mtu: 1500

I hope you like more this approach. Thanks for the feedback and reviews! @cathay4t @EdDev @tyll

Thank you. The tlv- prefix seems to be redundant and I wonder if the values should use IDs, too.

About official name questions, I have used the official names from the specifications all the time.

The CI error is caused by a bug on NM 1.22-git and master. NM folks are investigating it.


Stream containment and membership via paged DB queries

JIRA Ticket: https://jira.lyrasis.org/browse/FCREPO-3507
What does this Pull Request do?
Instead of querying for a list, which could be too large to return in memory this creates a stream backed by a paged query of the database.
How should this be tested?
Should have absolutely no discernable effect except that objects with an extremely large number of contained children or membership properties should still be retrieveable in a timely fashion.
Interested parties
@fcrepo/committers (@bbpennel as it was your ticket)

The updates look good to me. The same changes could be applied to the membership spliterator too. Sorry, I didn't note this in my original review. I was trying to avoid leaving duplicate comments.


New package: QuantumCore v0.1.0

Registering package: QuantumCore
Repository: https://github.com/qojulia/QuantumCore.jl
Created by: @Krastanov
Version: v0.1.0
Commit: d8c8d2d2404b435bc995a29cc347b56cc3e8a2ac
Reviewed by: @Krastanov
Reference: https://github.com/qojulia/QuantumCore.jl/commit/d8c8d2d2404b435bc995a29cc347b56cc3e8a2ac#commitcomment-91351529
Description: Lightweight interface for QuantumOptics

Please close this registration attempt. A renamed package was submitted at https://github.com/JuliaRegistries/General/pull/73202


Calling function 'makeDecorator', function calls are not supported.

ERROR in Error encountered resolving symbol values statically.
Calling function 'makeDecorator', function calls are not supported.
Consider replacing the function or lambda with a reference to an exported function,
resolving symbol NgModule in<EMAIL_ADDRESS>resolving symbol NgModule in<EMAIL_ADDRESS>resolving symbol NgModule in<EMAIL_ADDRESS>resolving symbol NgModule in<EMAIL_ADDRESS>resolving symbol Ng2InputMaskModule in /node_modules/ng2-input-mask/module/ng2-input-mask.module.ts,
resolving symbol Ng2InputMaskModule in /node_modules/ng2-input-mask/module/ng2-input-mask.module.ts

Getting same thing.

Me too. Need an answer :)

Me too

Me too²

update typescript to latest version.. it works for me

Adding the following line in tsconfig.json compilerOptions fixed the issue for me.
"paths": { "@angular/*": ["../node_modules/@angular/*"] }
Please check more in https://github.com/angular/angular-cli/issues/3854#issuecomment-274344771 and https://github.com/angular/angular-cli/issues/3854#issuecomment-299109237

@nsjithin solution worked for me too, but... what exactly it means? What if it has any side effects? Wel... I will keep my eyes open :-)

@nsjithin Thanks for solution!


Updated Offline Bundles for March Patch

Proposed changes
Updated Offline Bundles for March Patch for UCP 3.1.5, DTR 2.6.4 and DTR 2.5.10
Unreleased project version (optional)

Related issues (optional)

Deploy preview for docsdocker ready!
Built with commit d15c4c709887ba4506d3663d23c6315d6ff6928e
https://deploy-preview-8550--docsdocker.netlify.com


Does not work with JPG (uppercase file extensions)

I know it is a minor issue, but I could not get an image with uppercase JPG extension to show up in dash_doodler. After manually changing the file extension name to lowercase, the image did load and worked fine. I'm not sure how much it would take to accept uppercase and lowercase file extensions. Just thinking in terms of opening the utility to a broader set of imagery.

Yep, on my todo list - thanks for the reminder

fixed


autogen / configure not possible in Ubuntu Server 14.04.3

Because markdown can't be disabled please see attached log
Log.txt

You need to install libtool.


User-reported unhelpful error message

Program: https://code.world/#P0UG5UuTDP9a9b5gPvFEuJw
Message:
program.hs:7:1-5: warning:
    Defined but not used: ghost

Seems accurate to me.


Broken link in readme

https://ayon.ynput.io/docs/artist_hosts_unreal

Will be closed by https://github.com/ynput/ayon-unreal-plugin/pull/5


chore(deps): bump https://github.com/jenkins-x/jx-cli to 3.0.246

Update jenkins-x/jx-cli to 3.0.246
Command run was ./promote/main

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To complete the pull request process, please assign macox
You can assign the PR to them by writing /assign @macox in a comment when ready.
The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

/test kube

@jenkins-x-bot-test: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

kube
5033ca6300b2641df4313ec7f8818bc78dd8b23d
link
/test kube

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository. I understand the commands that are listed here.

/test kube

@jenkins-x-bot-test: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

kube
5033ca6300b2641df4313ec7f8818bc78dd8b23d
link
/test kube

gke
5033ca6300b2641df4313ec7f8818bc78dd8b23d
link
/test gke

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository. I understand the commands that are listed here.

@jenkins-x-bot-test: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

gke
5033ca6300b2641df4313ec7f8818bc78dd8b23d
link
/test gke

kube
5033ca6300b2641df4313ec7f8818bc78dd8b23d
link
/test kube

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository. I understand the commands that are listed here.


attacking via instruction count

http://gaasedelen.blogspot.com/2014/09/solving-fireeyes-flare-on-six-via-side.html

should add an inscount flag, and add a command like attack which can mutate input/memory and grade it, genetic algo, etc


Duplicates in a repeater are not allowed.

Hi guys,
I have this problem when using auto-complete from ngTagsInput directive:
Error: [ngRepeat:dupes] Duplicates in a repeater are not allowed. Use 'track by' expression to specify unique keys. Repeater: tag in tagList.items track by track(tag), Duplicate key
For example this is response that i get:
 {
    "id": "101",
    "create_date": "2016-02-01T18:33:39Z",
    "tag_token": "Tag 2",
    "parent_id": "2",
    "parent_type": "FILE"
},
{
    "id": "102",
   "create_date_tdt": "2016-02-01T18:33:39Z",
   "tag_token": "Tag 2",
   "parent_id": "3",
   "parent_type": "FILE"
}

and this is view where I am using tags-input
  <tags-input
                ng-model="searchQuery"
                display-property="tag_token"
                key-property="tag_token"
                on-tag-adding="checkTag($tag)"
                on-tag-removed="onTagRemoved($tag)"
                replace-spaces-with-dashes="false"
                add-from-autocomplete-only="true"
            >
            <auto-complete min-length="1" max-results-to-show="10" source="typeahead($query)"></auto-complete>
            </tags-input>

As you can see i have same value "Tag 2" for tag_token. I tried using key-property="tag_token track by $index", but still no success...same error. How can I solve this problem?
Regards,
Bojan

Same here... where do I download the this build?

I've experienced this also and my fix is to make sure that I returned a promise in my source and not an array.  So for this one source="typeahead($query)" make sure that it will return a promise.

give a unique value in the key-property attribute. like id or something.unique to be tracked.

This issue was selected to be spring-cleaned by a script. More information can be found here.
If anyone thinks this was a mistake and this issue should be reopened, please leave a message below explaining why. Before doing so, please consider reading the CONTRIBUTING file.


Hidden layers are no longer imported

Sketch + Framer file: http://cl.ly/ZhdI
Previously, layer groups with visibility toggled within Sketch would get imported with Opacity and Visible set to 0 and False respectively. Now, while visible is set to files, a transparent image actually gets imported, so the image never appears.

This is not working as expected.
Let's ignore all opacity, and just get visible working.
Current
Sketch

Layer group visible: false
Layer group opacity: 1

layers.json

Layer group visible: true
Layer group opacity: 0

Expected
Sketch

Layer group visible: false
Layer group opacity: 1

layers.json

Layer group visible: false
Layer group opacity: 1

Considered fixed! :)


Group By Tags bug

Description
The Group By Tags feature breaks when exiting the folder. All files that are tagged will be grouped under "Untagged" as soon as you leave the folder. The files will still retain their proper tag.
Steps To Reproduce

Tag a group of files in a folder
Select Group By Tags
Back out of the folder and then re enter the folder
The files will now be grouped by Untagged in a random sort order

Requirements

e.g. Fix crash that occurs when...
The files should remain under their grouped tag when exiting and reentering the folder

Files Version
<IP_ADDRESS>
Windows Version
10.0.19045.3324
Log File
debug.log

Merging with #11759


Able to render charts client side just fine, when I try to export to the base64 image its returning null in my success

I followed the readme exactly as you laid it out, even with your sample data. No matter what I pass to the exp.render function, it always hits my .then but the param its passing back is always empty. If i console log, it returns nothing... if i upload it to s3 its a 0kb image. Any ideas on what would cause this? I'm assuming something is messing up when phantomjs is trying to grab me an image but if there was an error caused from phantomjs i would assume the render function wouldnt resolve?

Same here, always returns an empty string using the sample code verbatim in node 8.10.x

It's this line that is failing https://github.com/mbejda/plotlychartexport/blob/0e40255e47cbf6b59ac646098622ac605931a171/phantom/generate.js#L104


Is there a way to convert ASP.NET Core AuthenticationTicket to a ASP.NET 4 Cookie without changing Startup.cs configuration?

Hi,
In my situation, I have a new ASP.NET Core application which needs to generate a Cookie in order to use against an ASP.NET 4 application (not reading a Cookie from ASP.NET 4).  I tried the sample setup you have provided in my ASP.NET Core Startup.cs, which appears to generate a Cookie (which I thought would now be a traditional ASP.NET 4 Cookie using MachineKey in AppSettngs.json).  But when I tried to use it against the ASP.NET 4 application, it appears to not work.   Maybe my assumption is wrong.
What I'd rather do is keep my original setup in ASP.NET Core (using JwtBearer Token) and then within my API controller, generate a valid Forms Auth Cookie for ASP.NET 4.  But not really sure how to accomplish this with the library.  Is this possible?  This is how my legacy code worked in original ASP.NET 4 code:
HttpCookie httpCookie = FormsAuthentication.GetAuthCookie(this.UserName, true);
I then added this Cookie to the WebRequest object when making a call to the other Web Application.  I've migrated my legacy ASP.NET 4 application to ASP.NET Core but still need to communicate to another ASP.NET 4 application.  User's always log into my ASP.NET Core application, so this is where all the Cookie information be created from.
As always, any help would be appreciated.
Thanks,
Devaron

You could use the class FormsAuthenticationCryptor and then the method string Protect(FormsAuthenticationCookie cookie). That should generate the necessary cookie value.
Something like:
public IActionResult Index(
    [FromServices] IHttpContextAccessor httpContextAccessor,
    [FromServices] FormsAuthenticationCryptor formsAuthenticationCryptor)
{
    var cookieValue = formsAuthenticationCryptor.Protect(new FormsAuthenticationCookie()
    {
        UserName = "",
        IssuedUtc = DateTime.UtcNow,
        ExpiresUtc = DateTime.UtcNow.AddDays(1)
    });

    httpContextAccessor.HttpContext.Response.Cookies.Append("cookieKey", cookieValue);

    return Ok();
}

Don't forget to setup the DI correctly:
var section = Configuration.GetSection("FormsAuthentication");
services.AddSingleton(provider => new FormsAuthenticationOptions()
{
    DecryptionKey = section.GetValue<string>("DecryptionKey"),
    ValidationKey = section.GetValue<string>("ValidationKey"),
    EncryptionMethod = section.GetValue<EncryptionMethod>("EncryptionMethod"),
    ValidationMethod = section.GetValue<ValidationMethod>("ValidationMethod"),
});
services.AddHttpContextAccessor();
services.AddScoped<FormsAuthenticationCryptor>();

I wrote it quickly, #NotTested but it should get you started.

Excellent!  Thank you so much for quick response.  I'll start plugging in now.

The code works, but still no luck on the proper Cookie Value being generated.  The legacy ASP.NET Application still rejects it and redirects to the login page.  Just out of curiosity, I see the EncryptionMethod enum doesn't have SHA1?  But in IIS for the legacy ASP.NET application when I look at the Machine Key settings, the Encryption Method field is SHA1.  Also, what Decryption should I use if IIS is "Auto".  AES?  I'm just wondering if I'm setting the wrong values?
	public enum EncryptionMethod
	{
		AES = 0,
		TripleDES = 1
	}

SHA1 is a hashing method, not a encryption method. So SHA1 is not a valid encryption method.
Could you post your web.config section? (except the machine key itself, just put "abc123" or something in its place).

Sorry for the delay, having to jump back to another project constantly :)   I figured the SHA1 was not correct as the Encryption Method based on your code, but seeing in IIS Web App -> Machine Key it says Encryption Method: SHA1.  I was just making sure I wasn't setting my Validation/Encryption Method wrong.  My problem is the Web.config doesn't state what the default is, so I chose AES by default.  Maybe that's my issue?  We don't know which Encryption Method IIS choose?
I've confirmed the IIS Web Apps all share the same Machine Keys (apps hosted on same machine), which match the keys I've setup in appsettings.json file in ASP.NET Core code.
Also, notice the compatibilityMode="Framework20SP2" in config?  I remember reading something about this somewhere else, but can't remember where.
IIS Web App -> Machine Key Settings
Encryption Method: SHA1
Decryption Method: Auto
<?xml version="1.0" encoding="utf-8"?>
<configuration>
	<system.web>

		<machineKey decryptionKey="BLAHHAHALAHKEY" validationKey="BLAHALAHAHALALAHKEY" />

		<!-- IMPORTANT: Must HAVE in order to support sharing Cookies generated from ASP.NET 4.0 / .NET 4.0 Web Apps -->
    		<httpCookies httpOnlyCookies="true" />
		<machineKey compatibilityMode="Framework20SP2" />

		<httpRuntime executionTimeout="360" maxQueryStringLength="32768" maxRequestLength="2097152" enableVersionHeader="false" />
		<customErrors mode="Off" />
		<httpModules>
			<add name="DomainServiceModule" type="System.ServiceModel.DomainServices.Hosting.DomainServiceHttpModule, System.ServiceModel.DomainServices.Hosting, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=31BF3856AD364E35" />
		</httpModules>
		<compilation targetFramework="4.5" debug="true">
			<assemblies>
				<add assembly="System.Data.Entity, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=b77a5c561934e089" />
			</assemblies>
		</compilation>
		<globalization culture="auto" uiCulture="auto" />
		<authentication mode="Forms">
			<forms name=".BlahBlahCookieName" timeout="480" loginUrl="Login.aspx" domain="blahblahdomain.com" path="/" />
		</authentication>

		<pages controlRenderingCompatibilityVersion="4.0" />

	</system.web>
</configuration>

Thanks, Ill see if I can recreate a working sample based upon your config, seems that compatibilityMode="Framework20SP2" might be the issue. I based my code on the latest Framework45 version, because that was what I needed. But currently @ work, so I might be able to whip something up this evening or tomorrow evening.

Thanks. I really appreciate the help.  Take your time.  I'm doing some more research on the legacy ASP.NET 4 app around "Roles".  I trying to get access to code and perhaps the page requires a specific role that I'm not applying into the Cookie.UserData.
Question?  Instead of creating a new FormsAuthenticationCookie, can I convert the existing AuthenticationTicket created by ASP.NET Core, and if so, will that automatically include the existing user's Role information in the Cookie.UserData?  This is how my legacy code was working before.  It created a Cookie based on the authenticated user.
FYI, I tried hard coding the Cookie.UserData value in the code sample you provided above.  Example:  cookie.UserData = "Create Report|View All Data";   Still no luck.  But, I need to confirm what Roles are needed by the legacy ASP.NET 4 application, which I'll do soon.  I'll be out of office today. Back on it tomorrow.
Thanks again.

The roles are not stored in the UserData property, that property is just something you can fill in yourself. Storing the Roles in there could be an implementation details your solution requires, but it is not something the field was designed for originally.

Gotcha.  So, how do I add roles?  In the legacy Apps, they both used ASP.NET Membership Providers for authentication/authorization.

It was my understanding that the formsticket contains the username, and the membership provider uses that (unique) username to lookup the user in the db, and find the roles attached.
But again, not currently read up on it anymore, so could be different.

Okay, it my current understanding the cookie value itself had the roles defined in it.  But yes, I'll need to research that on my side.  Been a while since I had to use deal with the old Forms Auth with Membership Provider.

I too am interested in how to get the web.config setting "Framework20SP2" working.
Out login site requires this setting to work with some of our sub-domains.

It is currently a bit busy on my day job, but ill see if I can dive into these settings in the near future. Till then, PR's are always welcome.

Not sure if posting links to other repos is against the "rules" but here is a link to another repo that works with "Framework20SP2". I have tested it with the current cookies I have and it is working.
https://github.com/dazinator/AspNetCore.LegacyAuthCookieCompat

There are no rules for sharing good intel :)

Excellent. Thanks for posting @ImGonaRot.  My temporary work around was to just leave the old ASP.NET Site up and authenticate to it from my new ASP.NET Core (all 3 sites use the same Membership DB) and store the legacy Cookie as a User Profile Property. Then when I needed to make a request to access the Reporting Site (which uses the legacy Cookie/MachineKey), I could attach the legacy Cookie.  Not ideal, but worked for me in the meantime.  But now I might be able to change over based on the other repo.

Not sure if posting links to other repos is against the "rules" but here is a link to another repo that works with "Framework20SP2". I have tested it with the current cookies I have and it is working.
https://github.com/dazinator/AspNetCore.LegacyAuthCookieCompat

This one doesn't work with Framework20SP2, it allready fails on the hash check and doesn't contain 3DES

@synercoder Not an "issue"... just wanted to put in a good word and thank you for doing this project. I cannot fathom why Microsoft did not provide a simple mechanism like this.  There is a huge .NET Framework base out there, sharing an authentication cookie seems like the only sane way of beginning a migration.  At any rate... thanks.  I hope you are able to continue to update it (say for .NET Core 3 and so on) as time allows you...

Closed because issue contained multiple subjects and inactivity.


Can the course instructions be released with this repo?

Sorry, there are no plans to release the course slides at this point.


webots.min.js: fix 'this' object in static methods

Remove calls  to this object in static methods of dialog_window.js.
This was causing issues when calling webots.alert and webots.confirm functions.

:+1:


feat(backend): GitLab on-premise support and multilevel URLs, SSH git repos

Add support for on-premise hosted GitLab, not only gitlab.com
Add support for SSH git repositories -> will be converted to "https" API URL
Add support for multi level gitlab groups
Respect upper case PRIVATE-TOKEN header
Mark PRIVATE-TOKEN header value as sensitive
fix bug: release-plz release fails when no "-o json" given as argument

Sorry, I have made a mess with git. Have now force pushed again and fixed the last clippy warning

Would you mind approving the builds? Or is there anything i can do?

Done! I'll review this asap

I extracted your fix in https://github.com/MarcoIeni/release-plz/pull/1528 because I wanted to merge it asap, thanks!

yes, the project Name is URL encoded, so 2%F is correct for the "/". Also you have to chose Maintainer role for the token.

I'll test again, thanks!
For the error, we could link to the docs if gitlab returns a 403

You seem to have a solution in mind, just go for it


Minor performance improvements and code deduplication

Skip a few unnecessary normalizations.
Would be nice to eventually change that optional argument to a keyword argument now that those are fast.
Also change Quat -> RodriguesVec according to https://github.com/FugroRoames/Rotations.jl/pull/77#issuecomment-420276890.

Codecov Report

Merging #81 into master will decrease coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master      #81      +/-   ##
==========================================
- Coverage   98.62%   98.61%   -0.01%
==========================================
  Files           7        7
  Lines         509      506       -3
==========================================
- Hits          502      499       -3
  Misses          7        7

Impacted Files
Coverage Δ

src/principal_value.jl
100% <100%> (ø)
:arrow_up:

src/angleaxis_types.jl
100% <100%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1a10c87...7d17131. Read the comment docs.


Added additional steps to inform users

Added clarifications in the outer loop & 8. step for users not to have any trouble while running.

@yelizkilinc can you edit the doc to also reflect the bicep infra steps? It currently only specifies the terraform pipeline, but we should also add the bicep pipeline


TST: stats: mark tests slow/xslow

Reference issue
NA
What does this implement/fix?
Marks some slow tests slow/xslow as appropriate.
Additional information
There are still many tests in test_continuous_basic.py and test_fit.py that should probably be marked XSLOW, but I want to check on a different computer before pulling the trigger.
scipy/stats/tests/test_stats.py::TestMGCStat::test_pvalue_literature is actually xslow, but I thought we needed to leave at least one test not marked XSLOW.

Main:
w/ slow tests: 12526 passed, 582 skipped, 135 xfailed in 739.24s (0:12:19)
w/out slow tests: 8819 passed, 4378 skipped, 46 xfailed in 225.37s (0:03:45)
PR:
w/ slow tests: 12697 passed, 781 skipped, 134 xfailed in 445.68s (0:07:25)
w/out slow tests: 9042 passed, 4525 skipped, 45 xfailed in 171.51s (0:02:51)


Editor Layout->Toggle Verticle/Horizontal Layout - icon doesn't change reflecting new setting

VSCode Version: 1.25.0
OS Version: macOS 10.13.5

Steps to Reproduce:

Open a source code file in the text editor
Select Toggle Verticle/Horizontal Layout from View->Editor Layout
Perform a view split, by right clicking on the editor source file tab and selecting "Split Down". I don't know if an up/down split corresponds to horizontal or vertical split mode (this is ambiguous and could mean either depending on your perspective!)
The icon indicating the horizontal/vertical layout should change to reflect the layout setting. However, the icon never changes and so you don't know what state the feature is in. (This used to work properly in previous version)

Does this issue occur when all extensions are disabled?: Yes

This feature works differently now, it will just flip the orientation of the grid but not have any other impact. To change the split direction you can configure "workbench.editor.openSideBySideDirection".


fix Twilio in-browser-call functionality using application_sid

The code as it was wasn't working because the application_sid wasn't put in the proper place. This fix should take care of that!

@joliveros, merge this PR. The application doesn't work without application_sid


Strange zooming issue

Hello, I'm encountering a problem with this library when I'm using zoom with Picasso/Glide. On devices with <300 ppi displays the 2048x2048 image loads way to big, on ~300 ppi displays the image seems to load ok and on devices with >300 ppi screens the image loads very small. Is this a known bug and is there any way to fix it? Thanks in advance

Nevermind, I found the solution ;)
`Picasso.with(this)
.load(url)
.placeholder(R.drawable.placeholdernew)
.error(R.drawable.errornew)
.into(imageView, new com.squareup.picasso.Callback() {
@Override
public void onSuccess() {
mAttacher = new PhotoViewAttacher(mImageView);
}
                @Override
                public void onError() {
                }
            });`


Not all private message sending examples are provided

This section has not implementation example of private message sending in client side.
It seems that it is not clear from where "userIdentifier"(id of private message receiver)  could be got in the client side before sending to the server side.
Thanks.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: c8d77892-d376-2f23-2634-f5d34d962a1e
Version Independent ID: 92ed6330-b49f-1620-6beb-8556a78ac7da
Content: Manage users and groups in SignalR
Content Source: aspnetcore/signalr/groups.md
Product: aspnet-core
GitHub Login: @bradygaster
Microsoft Alias: bradyg

We moved some of the user-specific content over to the auth article. Please take a look there. Closing this issue as that's the close of what we expected to do with this segment of the docs.

We moved some of the user-specific content over to the auth article. Please take a look there. Closing this issue as that's the close of what we expected to do with this segment of the docs.

Thanks a lot!)


Add note about renaming fields when migrating

Looks good to me. Further improvements could be to show what additional options they have for each document store (e.g. set search_fields and content_field to 'text' in ElasticsearchDocumentStore).

In https://github.com/deepset-ai/haystack/pull/1913 we make ElasticsearchDocumentStore raise an error if such a situation is being detected and give a simple advice how to resolve it (however it is not the only option here).

fixed


added line to create the inverse_vocab dict

suggested fix for issue #17

Oops, sorry about that!
+1<PHONE_NUMBER> | GMT-4 |<EMAIL_ADDRESS>On Sun, Dec 30, 2018 at 1:04 PM Nick Sexton<EMAIL_ADDRESS>wrote:

Closed #25 https://github.com/DOsinga/deep_learning_cookbook/pull/25.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/DOsinga/deep_learning_cookbook/pull/25#event-2048398880,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AA6I7j122xlc26ug1EH2tcRs8vBy2DCHks5u-KvcgaJpZM4YOXji
.


Kuruks, the forest guardians

Kuruks are ancient creatures living inside the forest. They are elk-like beings, walking upright. They have longer fur than normal deer, and feed mostly on bark, leaving empty spots on woods around it.
The Kuruks take care of the forest, planting sapling and protecting trees from damage from other beings. They live in elder trees, bringing up their youngs. Only one Kuruk may inhabit a forest at a time.
The young kuruks drop fine kuruk fur, and the elder one drops the heart of the forest.

Current Kuruk elder design

TODO:

[ ] Add entity animations
[ ] Add Kuruk pelt
[ ] Add eating tasks
[ ] Add spawn locations


Create jan-24.mdx

👷 Deploy Preview for hit-subscribe processing.

Name
Link

🔨 Latest commit
a660485df1df82519f3ad02a50109841faab55fd

🔍 Latest deploy log
https://app.netlify.com/sites/hit-subscribe/deploys/65b3f6fb6bd0bf00088bf09a


selecting LaTeX as language for a markdown cell changes it to a code cell

When changing the cell type to LATeX it tries running it as python, see these issues for more details. Remember to LaTeX up and always practice safe threads.
https://github.com/microsoft/vscode-jupyter/issues/3986
https://github.com/microsoft/vscode-jupyter/issues/1216

You need to put latex in a markdown cell for it to render.
Running a code cell will attempt to run against the selected kernel, no matter what language you have selected for the cell

OK, clicking the [+ Markdown] button to add a new cell. Change the language of the cell from markdown to latex. Paste in \[E=mc^2\] and run the cell:
File "C:\Users\AppData\Local\Temp/ipykernel_2184/1172784145.py", line 1
    \[E=mc^2\]
             ^
SyntaxError: unexpected character after line continuation character

It's still hitting the python interpreter.

Expected behavior would be if you change a cell to LaTeX it will render LaTeX, not run in python.

You have to leave it as markdown and use $$ to use the Katex renderer.
$$
[E=mc^2]
$$

But that is pretty confusing behavior, I updated the title to try and reflect the problem better

Great, thanks, this method does work for me

Or you could the following
%%latex
$$
[E=mc^2]
$$

Closing as resolved

related discussion in core https://github.com/microsoft/vscode/issues/120587


WIP hugolib: Add site building benchmarks

▶ go test -run="NONE" -bench="BenchmarkSiteBuilding.*"  -test.benchmem=true ./hugolib
BenchmarkSiteBuilding/num_root_sections=1/num_pages=10/render=false-4                 2000       1291745 ns/op      344566 B/op        4632 allocs/op
BenchmarkSiteBuilding/num_root_sections=1/num_pages=10/render=true-4<PHONE_NUMBER> ns/op      633817 B/op       10775 allocs/op
BenchmarkSiteBuilding/num_root_sections=1/num_pages=100/render=false-4<PHONE_NUMBER> ns/op     3242208 B/op       41776 allocs/op
BenchmarkSiteBuilding/num_root_sections=1/num_pages=100/render=true-4<PHONE_NUMBER>9 ns/op     4712458 B/op       73519 allocs/op
BenchmarkSiteBuilding/num_root_sections=1/num_pages=500/render=false-4                  30      37451925 ns/op    16107927 B/op      206770 allocs/op
BenchmarkSiteBuilding/num_root_sections=1/num_pages=500/render=true-4                   20      71672354 ns/op    24593242 B/op      352311 allocs/op
BenchmarkSiteBuilding/num_root_sections=5/num_pages=10/render=false-4                 1000       1016563 ns/op      357234 B/op        4877 allocs/op
BenchmarkSiteBuilding/num_root_sections=5/num_pages=10/render=true-4<PHONE_NUMBER> ns/op      792740 B/op       14077 allocs/op
BenchmarkSiteBuilding/num_root_sections=5/num_pages=100/render=false-4<PHONE_NUMBER> ns/op     3255768 B/op       42053 allocs/op
BenchmarkSiteBuilding/num_root_sections=5/num_pages=100/render=true-4<PHONE_NUMBER>3 ns/op     4865944 B/op       76860 allocs/op
BenchmarkSiteBuilding/num_root_sections=5/num_pages=500/render=false-4                  30      44964680 ns/op    16123086 B/op      207072 allocs/op
BenchmarkSiteBuilding/num_root_sections=5/num_pages=500/render=true-4                   20      76888686 ns/op    24227005 B/op      355699 allocs/op

Fixes #3535
/cc @bogem this is very much just a first outline, but if you have wishes/suggestions: shout!

What about adding a shortcode to content?

What about adding some shortcodes to content?

Yes, that is on my list in the issue.

Yes, I was wrong.


[#4408] Calls to code marked @VisibleForTesting in production code

Pull Request Description
Title: feat: Calls to code marked @VisibleForTesting in production code
Description:
This pull request addresses an issue where code marked with @VisibleForTesting was being called in production code. The @VisibleForTesting annotation is typically used to indicate that a method or class should only be accessed from within test code, and its presence in production code can lead to unintended consequences or misuse.
Changes:

Removed the @VisibleForTesting annotation from the loadCatalogBackend method in CatalogUtils.

Impact:

This change ensures that the loadCatalogBackend method is clearly marked for use in both production and test environments, aligning with its current usage.

By addressing the use of @VisibleForTesting annotations in production, this pull request improves code clarity and maintainability.

@Naresh-kumar-Thodupunoori Hello Naresh, could you please create an issue (if not did that), and associate this PR with that issue? so that when the PR got merged, we would know which Issue should be updated. Please follow the PR template as much as possible, thank you!

@Naresh-kumar-Thodupunoori Hello Naresh, could you please create an issue (if not did that), and associate this PR with that issue? so that when the PR got merged, we would know which Issue should be updated. Please follow the PR template as much as possible, thank you!

I see it is #4408 now, please check Justin's comment in the issue.

Hi @shaofengshi could you review my PR

Made the changes accordingly!!

Hi @jerryshao, @justinmclean, and @shaofengshi,
I hope you're all doing well. I wanted to kindly check in on the status of the PR. As these PRs are connected to my high school grades, I would greatly appreciate any assistance you can offer in expediting the process.
Thank you so much for your understanding and support!

Hi, again thanks for your help on this, but we need @yuqi1129 to review the change. It shoudl only take a day or two.
Open source is often worked on by volunteers and it is expected that you may not always get a prompt reply, they may be busy with other tasks or only contribite to the project part time.

Yeah I can understand that, but as 15 of august is the last day for my
submissions.I asked you!!
On Mon, 12 Aug, 2024, 11:01 am Justin Mclean, @.***>
wrote:

Hi, again thanks for your help on this, but we need @yuqi1129
https://github.com/yuqi1129 to review the change. It shoudl only take a
day or two.
Open source is often worked on by volunteers and it is expected that you
may not always get a prompt reply, they may be busy with other tasks or
only contribite to the project part time.
—
Reply to this email directly, view it on GitHub
https://github.com/apache/gravitino/pull/4426#issuecomment-2283139504,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/BBTIQ2XZJJZCSQGJQGF5KY3ZRBCC3AVCNFSM6AAAAABMEQRGBGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEOBTGEZTSNJQGQ
.
You are receiving this because you were mentioned.Message ID:
@.***>

@yuqi1129 Changed the code as per your suggestions!!

Thanks @Naresh-kumar-Thodupunoori for your contribution, merge to main and branch-0.6.


maxLength on filter input

I would like to be able to limit character in filter input.
Currently, any user could type character in input filter without limit. It could be useful to use maxLength to limit it.

Hmm, perhaps by using the filterTermProcessor see here: https://github.com/Aidurber/react-picky#prop-descriptions

A function that takes a string and returns a string. Useful for trimming and processing a filter term before it filters the options. Default: (term) => term

Your function could be something like: (term) => term.trim().slice(0, 20)

Thank you !
I had tried it and I have error with react minification with Version 5. I have to fix it to valid this.

@fishonweb Did you figure it out?


Open file in current tab group(always)

How to force VSC to open a file in the active group (always).
If the file is opened in a different group then this group activates even if you do not want to. For example: I am looking at files in the explorater in a different group.

This is a question but I doubt that it would be possible. This program interferes too much with the head and which documents in which window and card are opened. I have already described several such problems.


Remove memberwise initializers for AutomaticDirectiveConvertible types.

Bug/issue #, if applicable:
Summary
This removes the internal memberwise initializers for a few AutomaticDirectiveConvertible types.
Types that are AutomaticDirectiveConvertible aren't intended to be initialized directly. These initializers are unused.
Dependencies
None.
Testing
Build DocC. There shouldn't be any compiler errors.
Checklist
Make sure you check off the following items. If they cannot be completed, provide a reason.

~[ ] Added tests~
[x] Ran the ./bin/test script and it succeeded
~[ ] Updated documentation if necessary~

Looks good. I noticed there are a few subclasses of AutomaticDirectiveConvertible which still contain private member-wise initializers, such as PageImage and @Metadata. These are still needed for some reason and can't be removed also?

Correct. Both of those initializers need to exist for a workaround. They both have comments that explain why.
Note that https://github.com/apple/swift-docc/pull/806 fixes the root cause that's the reason for that workaround and also removes those two initializers.

@swift-ci please test


FE: support gifs

added https://github.com/webaverse/webaverse.com/compare/3ef968ae9606...eec0eed59e07


Change the 'constitution' dependency to 'azimuth'.

At present this simply pins a commit on Github, since azimuth isn't on npm.

Going to merge this right in because it's uncontroversial/straightforward.


Package Deku for homebrew

I would like it if the Deku team could provide us with .opam file(s) then it becomes simple. Otherwise we need to figure out all your dependencies which might not be easy for outsiders.


[Feature Request] Allow scripting in pages to run on client

In /pages/*.rocket.js I have a lit-html template, but I can't seem to add scripts like <button @click=${() => console.log('hello world')}>
Additionally, adding a script before like so:
console.log('this logs on the server but never the client');
export default () => html`...`

or
export default () => {
  console.log('this logs on the server but never the client');
  return html`...`
}

this all runs on the server, but i'd've expected there would be some way to make this run on the client. e.g. first page nav is SSR, and subsequent navs are SPA navs

page Templates always run on the server to generate the html... sort of like php - so if you want a script you can add one? 😬
export default () => html`

hello world

`

and for the lit templates... yes would be nice - but that would require hydration of individual lit templates... which is currently not supported because it's even more complex then component hydration 😅
I did some experiments with it... maybe worth putting in a dedicated issue...


libboost_system.so.1.54.0: cannot open shared object file (Linux Mint 18.3, wallet v<IP_ADDRESS>)

I get this error when I'm trying to run latest Unit wallet under Linux Mint 18.3:
error while loading shared libraries: libboost_system.so.1.54.0: cannot open shared object file: No such file or directory
It seems that only libboost1.58 is available in Lunux Mint's package base. What should I do to successfully run the v<IP_ADDRESS> wallet under Linux Mint? Make symbolic links or something else?

Anyone?...


DRAFT: module hierarchy

Which issue does this PR close?

Closes #.
Rationale for this change

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

Thanks @jayzhan211 for taking over this, I believe it is related to #11375 ?

Thanks @jayzhan211 for taking over this, I believe it is related to #11375 ?

It is just my example for getting rid of mod.rs


Is there a way to run envoy proxy on service fabric

Is there a way to run envoy proxy on service fabric with windows cluster. I would like to use it as a reverse proxy. I have see similar Traefik https://github.com/jjcollinge/traefik-on-service-fabric. I would prefer to use envoy if possible

I think there is since MSFT announced Envoy on service fabric but I don't know the details: @vturecek ?


Support Debian stretch

This is a FEATURE REQUEST.
Debian stretch was released already ~9 month ago (June 2017).
In May 2018, Debian jessie will end getting security updates by the official security Debian security team (although the LTS team will take over until 2020), see the Debian version history wikipedia page.
Please support current Debian stable (stretch).

It is support Debian stable (stretch).  Are you try to install it?

Oh really ? I look at the supported linux distros and they only show debian jessie:
Supported Linux Distributions:

Container Linux by CoreOS
Debian Jessie
Ubuntu 16.04
CentOS/RHEL 7
Fedora/CentOS Atomic

Can anybody confirm that debian stretch is fully supported ? Then please add it to the list of supported distros.

Thx for documenting Stretch as supported OS release. I'll give it a try soon and will give feedback on any issue.

Maybe a small addition to this, inventory/sample/group_vars/all.yml currently says:
Valid bootstrap options (required): ubuntu, coreos, centos, none
bootstrap_os: none
Adding debian to that list removes makes it even clearer that debian is indeed supported. ( I initially wondered about the debian support as well, thinking that i might need to choose "ubuntu" when using Debian. Only grepping the code told me that "debian" was an actual option. :-)

see https://github.com/kubernetes-incubator/kubespray/pull/2745 for a pull req for this.


Observing model property on VM not working anymore

A while back the following scenario would work, but has since stopped working:
Property inside a VM:
user: IUser;

With IUser as:
export interface IUser
{
    username: string;
    ...
}

Using ObserverLocator to raise property changes on user.username inside my VM is not working, changed(newValue: any, oldValue?: any) never being executed:
_observer.getObserver(this, 'user.username').subscribe(this.changed);

Has anything changed?

This API changed about 7 months ago I think. @jdanyow can advise you on how to use the new API.

Are you sure this worked: getObserver(this, 'user.username')?  This part of the API has never changed- it's always been getObserver(object, propertyName).  Try getObserver(this.user, 'username').

@jdanyow yes, I used a multi observer for instance that wraps observable locator (inspired by your blog post). Actual code:
multiObserver.observe(this, ['user.EmailAddress', 'user.Username'], this.call);

I tried re-implementing the same multi-observer on all the latest bits without luck. The above code worked with<EMAIL_ADDRESS>which is what my config.js was pegged at.
getObserver(this.user, 'username') does work and I've implemented it as such.

hmm- it's mystery!  I checked that tag: https://github.com/aurelia/binding/blob/1.0.0-beta.1.3.1/src/observer-locator.js#L42
it only accepts a property name


Gateway override merge strategy dependant on policy creation order

During test development, I noticed this only in a case where I had 2 policies targeting the same Gateway, with one providing a merge override.
Steps to reproduce
Policy 1:
spec:
  limits:
    gateway_limit:
      rates:
        - limit: 3
          window: 5s
      when:
        - predicate: request.path == '/anything'
    route_limit:
      rates:
        - limit: 10
          window: 5s
      when:
        - predicate: request.path == '/get'

Policy 2:
spec:
  overrides:
    limits:
      route_limit:
        rates:
          - limit: 3
            window: 5s
        when:
          - predicate: request.path == '/get'
    strategy: merge

Create policy 1 first targeting the gateway
Create policy 2 targeting the same Gateway, the policy provides a complete override to Policy 1 instead of Policy 1 staying partially enforced as expected

If Policy 2 is created first it works as expected, with Policy 1 being partially enforced.

I think what's described is the expected behaviour, i.e. there's no bug IMO.
The strategy declared by a policy only applies to the policies that are lower than that policy in the hierarchy.
In the example provided, both policies target the same level, but Policy 1 is created first. Therefore, Policy 1 > Policy 2[^1]. In this case, the strategy implicitly declared by Policy 1 (i.e. atomic defaults) dictates the behaviour, and the fact that Policy 2 declares merge overrides means nothing.
[^1]: See Conflict Resolution in GEP-713. "The older Policy based on creation timestamp beats a newer one."


Update common-jvm to 0.45.0.

This also fixes some Kotlin warnings.

This change is

Can you close in lieu of https://github.com/world-federation-of-advertisers/panel-exchange-client/pull/364


HTML Progress Doesn't work

Describe the bug
Works with DOM API:
https://playground.solidjs.com/anonymous/05d9ad70-852d-40ca-8134-544ed1a6c21a
Doesn't work with Solid:
https://playground.solidjs.com/anonymous/4f293905-4892-478a-b6ba-ad4dd5912df7
Click Make Indeterminate a few times, should be able to toggle on and off, doesnt work on Solid
Your Example Website or App
Above
Steps to Reproduce the Bug or Issue
Click button
Expected behavior
Works like DOM API
Screenshots or Videos
No response
Platform

OS: [e.g. macOS, Windows, Linux]
Browser: [e.g. Chrome, Safari, Firefox]
Version: [e.g. 91.1]
Latest

Additional context
No response

FYI: As someone who has encountered similar case in the past... 👀
The current implementation of Solid(or rather dom-expressions) transforms
<progress value={1} />

to
progressEl["value"] = 1;

and if that key is removed on update
progressEl["value"] = null;

https://github.com/ryansolid/dom-expressions/blob/b63993dea6ff4d715763fc1f3f5d23980fafbe1c/packages/dom-expressions/src/client.js#L328-L341

And in this case, value: null will be reflected as value: 0, so the value attribute will still remain and not go back to :indeterminate state.
For that purpose, we need to delete the entire attribute, we want to use
progressEl.removeAttribute("value");

to have it, we can use
<progress attr:value={1} />

instead of value={1}.
This is the current situation and workaround, but I don't know if this is a bug or as expected... 😅

Thank you. Shouldn't all attributes be treated as attr on non components? such that all HTML native elements <tag attr="x" />  should be handled as <tag attr:attr="x" /> under what scenario would a native HTML element not prefer this scenario?

Not necessarily.. value we handle as props for a reason.. related to input fields I believe. It wasn't always that way but we needed to change it for another one of the DOMs interesting inconsistencies. I think maybe we can be restrictive to only handling it as a prop on some elements perhaps. I maybe should look to see if there is a difference in null handling in some other frameworks because value as a property is pretty common.

@ryansolid I think this has to be special-cased because there's no .value that causes the progress bar to be indeterminate. See this playground: https://playground.solidjs.com/anonymous/4fe75699-3c5b-429f-b9bd-c9c087f51cb6

A numeric value doesn't make it indeterminate.
Null sets the value to 0.
All other values throws.

And MDN says:

If there is no value attribute, the progress bar is indeterminate;

Hence no possible value causes it to be indeterminate, so there must be some values (presumably null and undefined) that cause the "value" attribute to be removed.

Not necessarily.. value we handle as props for a reason.. related to input fields I believe. It wasn't always that way but we needed to change it for another one of the DOMs interesting inconsistencies. I think maybe we can be restrictive to only handling it as a prop on some elements perhaps. I maybe should look to see if there is a difference in null handling in some other frameworks because value as a property is pretty common.

Yeah input value and checked attributes in particular only set the initial/default value, whereas the properties set the current value, so most frameworks override this DOM behavior by default. (Maybe the same for option/select too, I forget.)

Yeah I just ckecked Inferno and it sets null to empty string on value property. So I guess it has the same problem.
Also Preact too: https://preactjs.com/repl?code=aW1wb3J0IHugcmVuZGVyIH0gZnJvbSAncHJlYWN0JzsKaW1wb3J0IHsgdXNlU3RhdGUgfSBmcm9tICdwcmVhY3QvaG9va3MnOwoKZnVuY3Rpb24gQ291bnRlcigpIHsKICAKICBjb25zdCBbcHJvZ3Jlc3NWYWx1ZSwgc2V0UHJvZ3Jlc3NWYWx1ZV0gPSB1c2VTdGF0ZSh1bmRlZmluZWQpCgogIGNvbnN0IHRvZ2dsZUluZGV0ZXJtaW5hdGUgPSAoKSA9PiB7CiAgICAgIGlmKHByb2dyZXNzVmFsdWUpIHsKICAgICAgICBzZXRQcm9ncmVzc1ZhbHVlKHVuZGVmaW5lZCkKICAgICAgfSBlbHNlIHsKICAgICAgICAgc2V0UHJvZ3Jlc3NWYWx1ZSg1MCkKICAgICAgfQogIH0KCiAgcmV0dXJuICg8ZGl2IHN0eWxlPSJiYWNrZ3JvdW5kOiBibHVlIj4KCiAgICAgIDxwcm9ncmVzcyB7Li4uKHByb2dyZXNzVmFsdWUgPyB7IHZhbHVlOiBwcm9ncmVzc1ZhbHVlIH0gOiB7fSl9IG1heD0iMTAwIiBzdHlsZT0id2lkdGg6IDEwMCUiLz4KICAgICAgPGJ1dHRvbiBvbmNsaWNrPXt0b2dnbGVJbmRldGVybWluYXRlfT5NYWtlIGluZGV0ZXJtaW5hdGU8L2J1dHRvbj4KICAgPC9kaXY%2BCiAgKTsKfQoKcmVuZGVyKDxDb3VudGVyIC8%2BLCBkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgnYXBwJykpOwo%3D

Yeah input value and checked attributes in particular only set the initial/default value, whereas the properties set the current value, so most frameworks override this DOM behavior by default. (Maybe the same for option/select too, I forget.)

This sounds right. Hmm.. it is pretty common issue. We can try to find some sort of fix perhaps that isn't too complicated I hope. But this may end up being a won't fix.

The fix I implemented on my end was basically checking if a value of null/undefined was being set on a progress element and removing the attribute (technically the attribute is always removed when setting to null/undefined, I'm just converting the undefined to null because the undefined throws). Maybe there are other ways to fix it if that's not good enough for Solid.

For reference here's the example working with attr::
https://playground.solidjs.com/anonymous/53995944-2a7c-42ed-8ebd-e21ea4bd7ce5


When features are disabled, tell user how to enable them

When desktop development is not enabled, you get:
$ flutter build macos
"build macos" is not currently supported.

Would be nice if this message instructed the user to run flutter config --enable-macos-desktop to enable.

This is great, we should definitely do this now that more features are available on all channels (though maybe only for these?)
See also: https://github.com/flutter/flutter/issues/79244


Documentation issue missing method in Function

Hi,
The documentation present here, makes use of a method "functionType(" currently not present in FunctionTypeUtils.
@Override
	public void initialize(GenericApplicationContext context) {
		context.registerBean("function", FunctionRegistration.class,
			() -> new FunctionRegistration<Function<Foo, Bar>>(function())
                .type(FunctionTypeUtils.functionType(Foo.class, Bar.class)));
	}

What did worked for me was:
    @Override
    public void initialize(GenericApplicationContext applicationContext) {
        Supplier<FunctionRegistration> supplier = () -> new FunctionRegistration<>(apply()).type(
                FunctionType.compose(FunctionType.from(Message.class), FunctionType.from(APIGatewayProxyResponseEvent.class))
        );

        applicationContext.registerBean("apply", FunctionRegistration.class, supplier);
    }

Could you please update the docs ?

As I already mentioned in the PR, the ApplicationContextInitializer has been removed fro the code base.


If too many checkins are scheduled PolicyLengthExceededException occurs

I noticed this bug when testing my frontend with my flights. It appears that Lambda functions have a max policy length and if there are too many checkins schedule (therefore, many permissions on the HandleScheduledCheckin), we will get PolicyLengthExceededException and weird behavior occurs.
Not really sure how we'd fix this, as this may be a limitation with the lambda functions. Also, since I assume this checkin service is mainly for personal use, this issue is unlikely to occur.
Here's a stack trace from my lambda logs.
2022-02-06T23:17:34.025Z	a2b7e2c6-c73f-4501-be64-2d7fc4e101a3	ERROR	PolicyLengthExceededException: The final policy size (20719) is bigger than the limit (20480).
    at deserializeAws_restJson1AddPermissionCommandError (/var/task/node_modules/@aws-sdk/client-lambda/dist-cjs/protocols/Aws_restJson1.js:2235:41)
    at runMicrotasks (<anonymous>)
    at processTicksAndRejections (internal/process/task_queues.js:95:5)
    at async /var/task/node_modules/@aws-sdk/middleware-serde/dist-cjs/deserializerMiddleware.js:6:20
    at async /var/task/node_modules/@aws-sdk/middleware-signing/dist-cjs/middleware.js:11:20
    at async StandardRetryStrategy.retry (/var/task/node_modules/@aws-sdk/middleware-retry/dist-cjs/StandardRetryStrategy.js:51:46)
    at async /var/task/node_modules/@aws-sdk/middleware-logger/dist-cjs/loggerMiddleware.js:6:22
    at async handleInternal (/var/task/src/handlers/schedule-checkin.js:107:9)
    at async Runtime.handle [as handler] (/var/task/src/handlers/schedule-checkin.js:47:18) {
  '$fault': 'client',
  '$metadata': {
    httpStatusCode: 400,
    requestId: '239d16c5-7b35-4abe-8486-44a13d7c64cb',
    extendedRequestId: undefined,
    cfId: undefined,
    attempts: 1,
    totalRetryDelay: 0
  },
  Type: 'User'
}

Hi @aaron-pham, thanks for reporting this!
Is this an issue with having too many active future flights, or an issue with having too many past flights?
If it's an issue with too many active future flights, we probably need to look into alternatives to adding permissions directly the the Lambda function. Maybe we need to create a role to attach to the function or something along those lines.
If it's just an issue with having had too many past flights, we can probably delete the old permissions after a user has been checked in.

@aaron-pham thoughts? https://github.com/sw-tools/checkin-service/pull/9

Looked at the PR and wrote comments there! I like it!


ls: cannot access '../../bin/eagle.[if]*': No such file or directory

I get:
Generate eagle.flash.bin and eagle.irom0text.bin successully in BIN_PATH
eagle.flash.bin-------->0x00000
eagle.irom0text.bin---->0x20000
!!!
Thu Sep 21 10:13:48 DST 2017
ls: cannot access '../../bin/eagle.[if]*': No such file or directory
../../../esptool/esptool.py --baud 230400 -p /dev/cu.usbserial-AH02MF3H write_flash 0x00000 ../../bin/eagle.flash.bin 0x14000 ../../bin/eagle.irom0text.bin

Is that ls: cannot access '../../bin/eagle.[if]*': No such file or directory cosmetic or an issue?

I guess it had to be ls -l $BIN_PATH/eagle.[if]*?

I propose you reinstall your development environment from scratch.
It works for everyone except you.
Pay good attention to all the details of the installation instructions.
Good luck,
HacK

On 22 Sep 2017, at 12:45, supersjimmie<EMAIL_ADDRESS>wrote:
I guess it had to be ls -l $BIN_PATH/eagle.[if]*?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub https://github.com/HomeACcessoryKid/ESP8266-HomeKit-Demo/issues/26#issuecomment-331414532, or mute the thread https://github.com/notifications/unsubscribe-auth/AV0HQs54O9uOMcepKsHXcYm97-osHd3qks5sk4-5gaJpZM4PfB7b.

It all seems to work now (other issues are solved)
It's only the last 'ls' that seems incorrect.
That ls fails because it ignores the $BIN_PATH variable and goes straight to the hard fixed ../../bin. That works if you have the BIN_PATH in that location, but mine is somewhere else.  Thats what using the BIN_PATH fixes, insted oth the hardcoded ../../bin.


Blur logs slightly when container is stopped

https://user-images.githubusercontent.com/1476820/180017025-3653ef3c-b68c-4962-8479-6f98973417d5.mov
thought this might be nice... thoughts?

cute as, too many lines of change tho :)


redis-cli exited upon typing monitor

redis-cli exited upon typing "monitor" command.
I realised it will only work if i type "info" first, and then later "monitor"
pls verify if this is a bug. Great work overall! Keep it up! It's working very well.

redis-cli would send a 'COMMAND' command after connect the server, which is not supported in ardb.
actually, the connection would closed after connection established, but redis-cli would not exit when connection closed. if u type 'monior' on a close connection, the cli would exit.   if u type info or other command, the new connection would established with no 'COMMAND' command.
u can use redis-cli to connect netcal -l 6379 which would dump the protocol message sent from redis-cli.


fix: fix pureDep returns null in some js files

What kind of change does this PR introduce?
bugfix

Did you add tests for your changes?
Not easy to reproduce,  TODO

Does this PR introduce a breaking change?
no

What needs to be documented once your changes are merged?
no

@alexander-akait @TheLarkInn @sokra This is a fatal error, please help to merge and release a version as soon as possible. For now I temporarily work around by disabling innerGraph
// webpack.config.js

module.exports = {
  //...
  optimization: {
+   innerGraph: false,
  },
};

By the way, another bugfix I submitted is best dealt with together, Thanks 🙏

@alexander-akait I can't reproduce it in a simple demo, maybe I have to read more Inner-module tree-shaking related codes to write it. It would be appreciated if you could quickly complete the test case. Otherwise I might spend some time

@xiaoxiaojx it is not good to merge code without tests :disappointed: How you catch a such problem and how do you undestand that this fix helps?

@alexander-akait This problem occurred in a project of our company, So I can't upload this part of the reproduced code 😢
What I found out is that a Module（29971） has a runtimes array（RuntimeSpec[]）
{
  29971: function (t, e, r) {

    e.ZP =
      5224 == r.j
        ? function (t, e, r) {
            var i,
              o = e.payload.cacheKey;
            return n(n({}, t), (((i = {})[o] = m(t[o], e, r)), i));
          }
        : null;
  }
}

/** @typedef {string | SortableSet<string> | undefined} RuntimeSpec */

The value of this runtimes is [new SortableSet([5224, 5491, 1803]), new SortableSet([9768, 7327, 7069])]
But here only rutimes[0] is used when generating runtimeConditionExpression, the generated code is as follows
e.ZP = 5224 == r.j ? xxx : null

At this time, if 9768 in rutimes[1] also depends on this Module（29971）, The export of Module（29971）is null ❌
So I changed the parameter passed in when generating runtimeConditionExpression from runtime to mergedRuntimes
-			const runtimeCondition = filterRuntime(runtime, runtime => {
+			const merged = deepMergeRuntime(runtimes, runtime);
+			const runtimeCondition = filterRuntime(merged, runtime => {

The code generated by Module (29971) becomes the following, My problem has also been solved ✅, because the js of 9768 Entrypoint can also get the export of Module (29971)
e.ZP = [5224, 9768].includes(r.j) ? xxx : null

Can you please add a tests case for this? Happy to help with this. If it's fixing something we should guard against these with tests for future changes.

@TheLarkInn I tried hard to reproduce it in the demo, and then wrote test cases, but in the end I couldn't reproduce it. I think the Inner-module tree-shaking part of the code is complicated 😢 ......

@xiaoxiaojx maybe you can provide what do you try to solve with simpel examples of code, so I can try to help you with tests

I just stumbled upon this issue after finding @xiaoxiaojx 's blog post pointing here (thank you!). We started seeing the mismatched module ID/null function export after switching from runtimeChunk: 'single' to runtimeChunk: true in a large multi-entrypoint repo under latest webpack 5.89.0.
The workaround to disable optimization.innerGraph seems to work, but unfortunately increases bundle sizes by quite a lot per-entrypoint (presumably due to benefits we'd otherwise gain from this optimisation). I'd rather not do that, so I'm wondering what the current status of this PR is?
I see there's some talk about tests, but my guess is that it might be hard to come up with a robust test here that captures the behaviour, since in our case we only saw this for one specific module in our monorepo out of thousands, and only after shipping a second, seemingly benign change (which presumably affected chunking/module concatenation/something else under the hood).
If I were to take a stab at the conditions that cause this, I'd say:

runtimeChunk: true
a named module export that's used across two separate entrypoints
importing and using the named export in the second entrypoint
...more variables that are hard to track down

If there's more info I can provide that would help get this merged, that would be great.

Can confirm this is a bug. In this PR @plrthink commit/8b1b55b and @jdb8  have been added to report the same problem.
Currently pr can run through all test cases. It may be a good choice to merge it first. cc @alexander-akait @TheLarkInn

@xiaoxiaojx Hm, okay, our tests are success, so let's ship it, maybe in future we will add a test case here, sorry for delay

@alexander-akait Thanks, looking forward to the new version !

@plrthink @jdb8<EMAIL_ADDRESS>has fixed，Let's re-enable this optimization，Thanks to everyone.
// webpack.config.js

module.exports = {
  //...
  optimization: {
+   innerGraph: true,
-   innerGraph: false,
  },
};

So far, no one else has reported this problem

Thanks for the fix, I also met this, but only in the CI build (with filesystem cache).


 This is because further investigations lead to discover that the issues in double or loop reporting of fatals where due to a bug on Symfony: see the issue https://github.com/symfony/symfony/issues/26438 and the fix https://github.com/symfony/symfony/pull/26568.
Eventual double reporting should be not fixed here in the client, but on the native integrations, like in the Symfony Bundle.
This PR also adds a regression test with a PHPT test, which could be run with PHPUnit with no issues.

fwiw the core client should handle double reporting when it can (I think it does/did?). No reason to re-write the same thing.

@dcramer that kind of stuff is requested in #563. The kind of duplication that I'm talking about here is different, is due to third party integrations, and the scenario is like:

a fatal error is thrown
Sentry captures it correctly through the ErrorHandler::handleError function
Sentry the passes the error to the previous error handler
The previous error handler is Symfony's, which rethrows errors as FatalThrowableError exceptions
Sentry's exception handler kicks in...

In this way the error is reported twice, once as an error, once as a FatalThrowableError. Since those are different, the core cannot handle it in itself, but a simple ignore_fatal_throwables option on the Symfony bundle could fix this easily.

@Jean85 ah nevermind then - agreed.

With this I think it's time to release 1.8.4... @stayallive what do you think? We need to update the changelog too!

Release in https://github.com/getsentry/sentry-php/releases/tag/1.8.4.

Another bug I'd suggest looking at re: fatal errors is #391 - I pushed some code that can fix the bug, or perhaps some other refactoring is desired


Issue running RDFUnit Docker in a Kubernetes environment

Expected Behavior
Using RDFUnit in a Kubernetes environment
Actual Behavior
When running bin/rdfunit from inside a Docker container running in a Kubernetes pod we are facing the following issue:
[ERROR] No plugin found for prefix 'exec' in the current project and in the plugin groups [org.apache.maven.plugins, org.codehaus.mojo] available from the repositories [local (/root/.m2/
repository), central (https://repo.maven.apache.org/maven2)] -> [Help 1]

Steps to Reproduce the Problem

Install kubectl and Argo on local machine (following this tutorial: https://maastrichtu-ids.github.io/dsri-documentation/docs/guide-local-install#install-kubectl )

Run aksw/rdfunit in a Kubernetes pod
It can be done reusing this pod definition: https://github.com/MaastrichtU-IDS/d2s-argo-workflows/blob/cd8b1432940595e6ff52b7efaa339f5d653aa609/tests/test-devnull-pod.yaml

Connect to it to run bin/rdfunit

Specifications

Version: Kubernetes
Client Version: version.Info{Major:"1", Minor:"11+", GitVersion:"v1.11.0+d4cacc0", GitCommit:"d4cacc0", GitTreeState:"clean", BuildDate:"2018-10-10T16:38:01Z", GoVersion:"go1.10.3", Compiler:"gc", Platform:"linux/amd64"}
Server Version: version.Info{Major:"1", Minor:"17", GitVersion:"v1.17.0", GitCommit:"70132b0f130acc0bed193d9ba59dd186f0e634cf", GitTreeState:"clean", BuildDate:"2019-12-07T21:12:17Z", GoVersion:"go1.13.4", Compiler:"gc", Platform:"linux/amd64"}
Platform: Ubuntu 18.04
Subsystem:

Remarks
I realized there are a few issues in the Dockerfile such as a mkdir line that contains a typo
I think it can be solved by rewriting the Dockerfile to properly generates a packaged jar and using this jar after with java -jar (instead of using mvn -pl)

Here is an example of a Dockerfile to build Java we use usually (1 stage with maven to build the jar, 1 stage with a light JRE to execute the jar : https://github.com/MaastrichtU-IDS/xml2rdf/blob/master/Dockerfile
Compiling a jar allow you to avoid any issues related to changing the path where the application is used within your container

I fixed RDFUnit to be packaged as a standalone jar in the RDFUnit Docker container. So using it from any path with any workdir set will work (available at https://hub.docker.com/repository/docker/umids/rdfunit )
What has been done:

added the shade plugin from the profile cli-standalone to the default build plugins in the pom.xml (using profiles was not clear)
rewriting the Dockerfile to build the standalone jar in a maven container before running it in a openjdk slim container
use absolute path to run the jar in the Docker entrypoint

See commits:

https://github.com/vemonet/RDFUnit/commit/cd57ffdc4b65cb2065f19f6f7e5691a8af3fe50d
https://github.com/vemonet/RDFUnit/commit/447c9d4d588f3453e579043489b2dc2ee3932dff

It is working perfectly fine, let me know if that interest you
We could avoid to change the pom.xml by selection the cli-standalone profile when running mvn package, but not sure how to do it

Thanks for the report @vemonet
I agree that using a fat jar is a better option for running RDFUnit in docker
I like your change, my only concern is that by adding the shade plugin inside the default maven profile, it will be running for every maven execution and possibly delay other dev processes.
We could easily add it in a separate profile (i.e. standaloneJar) and add -PstandaloneJar in the docker command, wdyt?

Hi @jimkont , yes that was my thought also
I rewrote the change to edit only the Dockerfile to properly use the cli-standalone profile when running mvn package
See commit https://github.com/vemonet/RDFUnit/commit/2452b1b0c019524ba35e0e4f4368abd1776521d3
And see the Dockerfile: https://github.com/vemonet/RDFUnit/blob/develop/Dockerfile
I kept /usr/src/myapp as workdir, but we could use something shorter if you want, like /app
Additionally this also fix RDFUnit to be used in CWL workflows (CWL redefine the Docker workdir) :slightly_smiling_face:
I did a pull request if that works for you: https://github.com/AKSW/RDFUnit/pull/99

What is the status here?

@vemonet can you check if we can close this issue? Is there anything else pending after your Merge request (https://github.com/AKSW/RDFUnit/pull/99)?


ERROR: talairach_afd: Talairach Transform: transforms/talairach.xfm FAILED

Trying to preprocess one subject with multiple sessions of data and fmriprep crashes with the following error.
crash-20210925-192047-achowdhury-autorecon1-b29726d6-d970-4f9c-a68d-8cedaaf96df3.txt
My data is 7T so there might be a need for bias field correction - I am not sure if it is already included within fmriprep workflow.
Here is  the data: https://www.dropbox.com/sh/n9qwvyjz573tt27/AABrEo53XCAiYgk64GxwtdwTa?dl=0
Thanks!

Are you able to run this dataset through freesurfer independently?

Nope getting the same error running recon-all  command by itself

solved: run bias field correction of 7T T1 images before feeding it to fmriprep. Instructions here: https://surfer.nmr.mgh.harvard.edu/fswiki/HighFieldRecon
Could this be included as part of fmriprep workflow in the future?


[Sprint 2][Issue #26] Add Docker Build support

Adding the docker support for smooth building process across different system.

Seems fine!