ROCm 1.9 vs Folding@Home

Problem description
I'm trying to run Folding@Home, and am getting "BAD_WORK_UNIT" errors.
I've attached logs including strace. The simulation program immediately fails with "ERROR:Discrepancy: Forces are blowing up! 1 0". This happens over and over for different tasks from the F@H servers.
The card is a Vega 56.
Steps to reproduce

Install ROCm 1.9 on a Debian/Ubuntu system
Set up /etc/profile.d/rocm.sh with HSA_ENABLE_SDMA=0.
Install FAHClient from https://foldingathome.org/start-folding/
Create a new user account, call it "fold". Add to video group.
Log in as that account, make sure env variables are ok.
Create config.xml (see below).
Run FAHClient --config config.xml.

Logs
$ cat /etc/profile.d/rocm.sh
export LD_LIBRARY_PATH=/opt/rocm/opencl/lib/x86_64:/opt/rocm/hsa/lib:$LD_LIBRARY_PATH
export PATH=$PATH:/opt/rocm/bin:/opt/rocm/profiler/bin:/opt/rocm/opencl/bin/x86_64

export HSA_ENABLE_SDMA=0

$ cat config.xml
<config>
  <!-- Client Control -->
  <fold-anon v='true'/>

  <!-- HTTP Server -->
  <allow v='<IP_ADDRESS> <IP_ADDRESS>'/>

  <!-- Slot Control -->
  <power v='full'/>

  <!-- User Information -->
<!--  <user v=''/>
  <passkey v='/> -->

  <!-- Web Server -->
  <web-allow v='<IP_ADDRESS> <IP_ADDRESS>'/>

  <!-- Folding Slots -->

<!--  <slot id='0' type='CPU'/> -->

  <slot id='1' type='GPU'>
<!-- <client-type v='beta'/> -->
<!--    <opencl-index v='0'/> -->
  </slot>
</config>

$ /opt/rocm/bin/rocminfo
=====================
HSA System Attributes
=====================
Runtime Version:         1.1
System Timestamp Freq.:  1000.000000MHz
Sig. Max Wait Duration:<PHONE_NUMBER>3709551615 (number of timestamp)
Machine Model:           LARGE
System Endianness:       LITTLE

==========
HSA Agents
==========
*******
Agent 1
*******
  Name:                    Intel(R) Core(TM) i5-3470 CPU @ 3.20GHz
  Vendor Name:             CPU
  Feature:                 None specified
  Profile:                 FULL_PROFILE
  Float Round Mode:        NEAR
  Max Queue Number:        0
  Queue Min Size:          0
  Queue Max Size:          0
  Queue Type:              MULTI
  Node:                    0
  Device Type:             CPU
  Cache Info:
    L1:                      32768KB
  Chip ID:                 0
  Cacheline Size:          64
  Max Clock Frequency (MHz):3600
  BDFID:                   0
  Compute Unit:            4
  Features:                None
  Pool Info:
    Pool 1
      Segment:                 GLOBAL; FLAGS: KERNARG, FINE GRAINED
      Size:                    10168564KB
      Allocatable:             TRUE
      Alloc Granule:           4KB
      Alloc Alignment:         4KB
      Acessible by all:        TRUE
    Pool 2
      Segment:                 GLOBAL; FLAGS: COARSE GRAINED
      Size:                    10168564KB
      Allocatable:             TRUE
      Alloc Granule:           4KB
      Alloc Alignment:         4KB
      Acessible by all:        TRUE
  ISA Info:
    N/A
*******
Agent 2
*******
  Name:                    gfx900
  Vendor Name:             AMD
  Feature:                 KERNEL_DISPATCH
  Profile:                 BASE_PROFILE
  Float Round Mode:        NEAR
  Max Queue Number:        128
  Queue Min Size:          4096
  Queue Max Size:          131072
  Queue Type:              MULTI
  Node:                    1
  Device Type:             GPU
  Cache Info:
    L1:                      16KB
  Chip ID:                 26751
  Cacheline Size:          64
  Max Clock Frequency (MHz):1622
  BDFID:                   768
  Compute Unit:            56
  Features:                KERNEL_DISPATCH
  Fast F16 Operation:      FALSE
  Wavefront Size:          64
  Workgroup Max Size:      1024
  Workgroup Max Size Per Dimension:
    Dim[0]:                  67109888
    Dim[1]:                  50332672
    Dim[2]:                  0
  Grid Max Size:<PHONE_NUMBER>
  Waves Per CU:            40
  Max Work-item Per CU:    2560
  Grid Max Size per Dimension:
    Dim[0]:<PHONE_NUMBER>
    Dim[1]:<PHONE_NUMBER>
    Dim[2]:<PHONE_NUMBER>
  Max number Of fbarriers Per Workgroup:32
  Pool Info:
    Pool 1
      Segment:                 GLOBAL; FLAGS: COARSE GRAINED
      Size:                    8372224KB
      Allocatable:             TRUE
      Alloc Granule:           4KB
      Alloc Alignment:         4KB
      Acessible by all:        FALSE
    Pool 2
      Segment:                 GROUP
      Size:                    64KB
      Allocatable:             FALSE
      Alloc Granule:           0KB
      Alloc Alignment:         0KB
      Acessible by all:        FALSE
  ISA Info:
    ISA 1
      Name:                    amdgcn-amd-amdhsa--gfx900
      Machine Models:          HSA_MACHINE_MODEL_LARGE
      Profiles:                HSA_PROFILE_BASE
      Default Rounding Mode:   NEAR
      Default Rounding Mode:   NEAR
      Fast f16:                TRUE
      Workgroup Max Dimension:
        Dim[0]:                  67109888
        Dim[1]:                  1024
        Dim[2]:                  16777217
      Workgroup Max Size:      1024
      Grid Max Dimension:
        x<PHONE_NUMBER>
        y<PHONE_NUMBER>
        z<PHONE_NUMBER>
      Grid Max Size:<PHONE_NUMBER>
      FBarrier Max Size:       32
*** Done ***

# dmesg | grep kfd
[    3.572882] kfd kfd: Initialized module
[    4.129673] kfd kfd: Allocated 3969056 bytes on gart
[    4.129817] kfd kfd: added device 1002:687f

# inxi -sF
System:    Host: nsa Kernel: 4.19.0-rc4-amd64 x86_64 bits: 64 Console: tty 4
           Distro: Debian GNU/Linux buster/sid
Machine:   Type: Desktop System: ASUSTeK product: CM6340 v: N/A serial: CENSORED
           Mobo: ASUSTeK model: CM6340 v: Rev X.0x serial: CENSORED UEFI: American Megatrends v: 0604
           date: 07/11/2013
CPU:       Topology: Quad Core model: Intel Core i5-3470 bits: 64 type: MCP L2 cache: 6144 KiB
           Speed: 1600 MHz min/max: 1600/3600 MHz Core speeds (MHz): 1: 1600 2: 1600 3: 1600 4: 1601
Graphics:  Device-1: Advanced Micro Devices [AMD/ATI] Vega 10 XT [Radeon RX Vega 64] driver: amdgpu v: kernel
           Display: server: X.org 1.20.1 driver: amdgpu,ati unloaded: fbdev,modesetting,vesa tty: 136x39
           Message: Advanced graphics data unavailable in console for root.
  I'm running the tests now with the tip OpenMM sources and the tip compilers to see if the situation has changed.

Running the OpenMM OpenCL tests compile from tip sources are passing for me, and apparently others, on ROCm 1.9 on various gfx900 based cards.  I understand the latest release is using a somewhat older version of OpenMM.  Do you get better results using the latest beta, which I understand is using a more recent version of OpenMM?

I just tried to use my Vega 64 with the ROCm opencl drivers and got the same problem. I installed using these instructions https://rocm.github.io/install.html on (K)ubuntu 19.04 and they seemed to work fine otherwise, but F@H still is having the same problem. Also the closed source driver stack hasn't been updated since Ubuntu 18.04... If the ROCm drivers could be made to work even with the old OpenMM binaries F@H uses, it would save lot of headache.

Their latest GPU core is based on OpenMM 7.4.1, which appears to be the latest, but I still cannot fold with my RX 580. My error message is much more generic (I forget exactly but can reproduce if helpful) but I still end up with BAD_WORK_UNIT with rocm_dev 3.1.35 on Kubuntu 18.04.4 with the HWE 5.3.0-40 kernel.

Hello,
Similar here with Vega10 card.  I get this in the logs:
15:36:56:WU01:FS01:0x22:Digital signatures verified
15:36:56:WU01:FS01:0x22:Folding@home GPU Core22 Folding@home Core
15:36:56:WU01:FS01:0x22:Version 0.0.2
15:37:03:WU01:FS01:0x22:Caught signal SIGABRT(6) on PID 55606
15:37:03:WU01:FS01:0x22:WARNING:Unexpected exit from science code
15:37:03:WU01:FS01:0x22:Saving result file ../logfile_01.txt
15:37:03:WU01:FS01:0x22:Saving result file science.log
15:37:03:WU01:FS01:0x22:Folding@home Core Shutdown: BAD_WORK_UNIT

I am on Ubuntu 18.04, 5.3.0-40 kernel as well.  Installed ROCM using this sources.list line:
deb [arch=amd64] http://repo.radeon.com/rocm/apt/debian/ xenial main
This is "folding" just fine using the CPU, but I have three GPUs that I should be able to use on this.
This is the system info as given by FAHClient:
16:29:43:******************************* System ********************************
16:29:43:            CPU: AMD Ryzen Threadripper 1920X 12-Core Processor
16:29:43:         CPU ID: AuthenticAMD Family 23 Model 1 Stepping 1
16:29:43:           CPUs: 24
16:29:43:         Memory: 62.83GiB
16:29:43:    Free Memory: 53.46GiB
16:29:43:        Threads: POSIX_THREADS
16:29:43:     OS Version: 5.3
16:29:43:    Has Battery: false
16:29:43:     On Battery: false
16:29:43:     UTC Offset: NN
16:29:43:            PID: NNNNNN
16:29:43:            CWD: /path/to/fah/work/dir
16:29:43:             OS: Linux 5.3.0-40-generic x86_64
16:29:43:        OS Arch: AMD64
16:29:43:           GPUs: 3
16:29:43:          GPU 0: Bus:8 Slot:0 Func:0 AMD:5 Ellesmere XT [Radeon RX
16:29:43:                 470/480/570/580]
16:29:43:          GPU 1: Bus:65 Slot:0 Func:0 AMD:5 Ellesmere XT [Radeon RX
16:29:43:                 470/480/570/580]
16:29:43:          GPU 2: Bus:68 Slot:0 Func:0 AMD:5 Vega 10 XTX [Radeon Vega Frontier
16:29:43:                 Edition]
16:29:43:           CUDA: Not detected: Failed to open dynamic library 'libcuda.so':
16:29:43:                 libcuda.so: cannot open shared object file: No such file or
16:29:43:                 directory
16:29:43:OpenCL Device 0: Platform:0 Device:0 Bus:8 Slot:0 Compute:1.2 Driver:3084.0
16:29:43:OpenCL Device 1: Platform:0 Device:1 Bus:65 Slot:0 Compute:1.2 Driver:3084.0
16:29:43:OpenCL Device 2: Platform:0 Device:2 Bus:68 Slot:0 Compute:2.0 Driver:3084.0
16:29:43:***********************************************************************

Ildefonso

Hitting the same on 3.1 on RHEL 7.7

Same for me

same here,
I added fahclient to the video group and created /etc/profile.d/rocm.sh
export LD_LIBRARY_PATH=/opt/rocm-3.1.0/opencl/lib/x86_64:/opt/rocm-3.1.0/hsa/lib:$LD_LIBRARY_PATH
export PATH=$PATH:/opt/rocm/bin:/opt/rocm-3.1.0/opencl/bin/x86_64:/opt/rocm-3.1.0/bin:/opt/rocm-3.1.0/opencl/rocprofiler/bin

I'm also affected. dmesg output is:
[175611.038424] amdgpu 0000:0d:00.0: [gfxhub0] retry page fault (src_id:0 ring:0 vmid:8 pasid:32787, for process FahCore_22 pid 75389 thread FahCore_22 pid 75389)
[175611.038429] amdgpu 0000:0d:00.0:   in page starting at address 0x00007f2c72208000 from client 27
[175611.038431] amdgpu 0000:0d:00.0: VM_L2_PROTECTION_FAULT_STATUS:0x00801031
[175611.038433] amdgpu 0000:0d:00.0: 	 MORE_FAULTS: 0x1
[175611.038434] amdgpu 0000:0d:00.0: 	 WALKER_ERROR: 0x0
[175611.038436] amdgpu 0000:0d:00.0: 	 PERMISSION_FAULTS: 0x3
[175611.038437] amdgpu 0000:0d:00.0: 	 MAPPING_ERROR: 0x0
[175611.038438] amdgpu 0000:0d:00.0: 	 RW: 0x0

I managed to get it to at least load but sadly that's when the BAD_WORK_UNIT kicks in; https://github.com/RadeonOpenCompute/ROCm/issues/1040#issuecomment-601650755

Just tried it, same issues as above unfortunately

I just upgraded to ROCM 3.3 which now actually works, no more BAD_WORK_UNIT!

Same here, looks like issue finally fixed.

I can also confirm this is working on newer versions.  I have Vega FE and RX 580: both cards are working fine with Folding@Home now.

I can confirm this was working correctly for my RX 580 after manually updating the GPU.txt for FAH, but broke again with the latest ROCm update released a couple of days ago.

Putting this into /etc/profile.d/rocm.sh and uninstalling the clinfo package seem to have helped:
export PATH="$PATH:/opt/rocm-3.5.0/bin/:/opt/rocm-3.5.0/opencl/bin/"
export LD_LIBRARY_PATH="$LD_LIBRARY_PATH:/opt/rocm-3.5.0/opencl/lib/"

Is there any chance the ROCm OpenCL-only installation packages could be adjusted to create a symlink /opt/rocm pointing at the version-specific subfolder so I won't have to keep updating that file whenever the version string changes?
According to the documentation this symlink is already being created  in full installs by some package but that does not seem to be one of those listed at https://rocmdocs.amd.com/en/latest/Installation_Guide/Installation-Guide.html#performing-an-opencl-only-installation-of-rocm

Hi @DaDummy,
Yes, as you found, soft link to /opt/rocm will be created by rocm-dev component.
As OpenCL-only ROCm does not deal with rocm-dev, soft link will not be created. We need to manually create soft link, if we wish to.

Hi @DaDummy,
Yes, as you found, soft link to /opt/rocm will be created by rocm-dev component.
As OpenCL-only ROCm does not deal with rocm-dev, soft link will not be created. We need to manually create soft link, if we wish to.

Thank you all for the updates.
As this issue is fixed and no more observed with newer versions, am closing this.
Request to open a new issue if found any.
Thank you.

Thank you all for the updates.
As this issue is fixed and no more observed with newer versions, am closing this.
Request to open a new issue if found any.
Thank you.


I just see a blank screen after the code is complete

Describe the bug
Hello, I have signed up to a paid account tonight and I am trying to get an MVP ready on my first project. I only see a blank white screen in the preview window. It did show a version one time but when I asked to change the UI colours, bolt said it was complete but again, only a white screen.
Link to the Bolt URL that caused the error
https://bolt.new/~/sb1-axwbuu
Steps to reproduce
Prompt bolt for my app
Expected behavior
To see the front end of the web app
Screen Recording / Screenshot

Platform

OS: [e.g. macOS, Windows, Linux]
Browser: [e.g. Chrome, Safari, Firefox]
Version: [e.g. 91.1]

Additional context
No response

Appreciate the feedback. We are aware of this issue and are tracking it here: #1791.


Create front Home page for app

Completed in commit 23eaa8c3c4c6a10f740ed6aa34de780131fa65fa

Updated in commit 4323da2356971441790e4efc79dd22a01b798fa2
This update allows users to view their newly created session on the home page without having to reload the page


Adding watches on startup are recognized as events

When adding watches with watchDirectoryRecursively open and close events will occur and processed by the events handlers. But these are no events the user might be interested in.

This one is a false positive. Vs code was indexing the build directory and triggered the unexpected events.


Error with Snowflake source NUMBER(X,0) field type

I run into this error whenever I try to ingest a table from snowflake where a field is of the format NUMBER(X,0):
[2024-04-29 23:22:27] [ua.ingestrrrpred] <class 'dlt.destinations.exceptions.DatabaseTransientException'> [2024-04-29 23:22:27] [ua.ingestrrrpred] 400 POST https://bigquery.googleapis.com/bigquery/v2/projects/idle-fast-food-bbf2a/queries?prettyPrint=false: In NUMERIC(P, 0), P must be between 1 and 29 at [8:15]
This does not happen when I convert the type to either integer or allow a precision for the floating point number (e.g. NUMBER(X,2)).

@adaykoth, The error suggests that BigQuery only supports a precision range of (1,29). You need the source datatype  that supports this behaviour in your landing area
ref : https://cloud.google.com/bigquery/docs/reference/standard-sql/data-types#parameterized_decimal_type

this issue should have been fixed with the latest version of ingestr which takes care of precision conversion properly.


Correct saving squashed ontology

Description
Added --iri and --base-iri options to ontoconvert allowing to correctly saving a squashed ontology.
This is both a fix in EMMOntoPy and a workaround for the bug in Owlready2 that replaces the final hash (#) of the base_iri to a slash (/).
Test it with:
cd EMMO
git fetch origin 1.0.0-beta7:1.0.0-beta7
git co 1.0.0-beta7
ontoconvert -wsa -b "https://w3id.org/emmo#" -I "https://w3id.org/emmo" emmo.ttl emmo-squashed.ttl

Note: Had to add a lot of
# pylint: disable=not-an-iterable

because pylint doesn't understand that rdflib.triples() returns an iterable... This is not the responsibility of EMMOntoPy to fix.
Type of change

[x] Bug fix.
[ ] New feature.
[ ] Documentation update.
[ ] Test update.

Checklist

This checklist can be used as a help for the reviewer.

[ ] Is the code easy to read and understand?
[ ] Are comments for humans to read, not computers to disregard?
[ ] Does a new feature has an accompanying new test (in the CI or unit testing schemes)?
[ ] Has the documentation been updated as necessary?
[ ] Does this close the issue?
[ ] Is the change limited to the issue?
[ ] Are errors handled for all outcomes?
[ ] Does the new feature provide new restrictions on dependencies, and if so is this documented?

Comments

Looks good as far as I was able to see when testing. However, tests are missing. Maybe add a test where testonto.ttl is squash saved and then check that this is the same as the original after loading? First check that new IRI and BASE_IRI are changed and change back of course... And also check that the squashed ontology no longer imports other ontologies (Is this correct?)
Also, where is / --> # hack done? Is it a good idea to move this fix out of squash?

Added a second test with squash and change of IRIs to tests/tools/test_ontoconvert.py
There is no explicit / --> # hack. Instead the --iri and --base-iri options of the ontoconvert tool allow setting the iri and base_iri after the ontology is loaded. Hence, these options can be used to work around the bug in Owlready2.

Looks good as far as I was able to see when testing. However, tests are missing. Maybe add a test where testonto.ttl is squash saved and then check that this is the same as the original after loading? First check that new IRI and BASE_IRI are changed and change back of course... And also check that the squashed ontology no longer imports other ontologies (Is this correct?)
Also, where is / --> # hack done? Is it a good idea to move this fix out of squash?

Added a second test with squash and change of IRIs to tests/tools/test_ontoconvert.py
There is no explicit / --> # hack. Instead the --iri and --base-iri options of the ontoconvert tool allow setting the iri and base_iri after the ontology is loaded. Hence, these options can be used to work around the bug in Owlready2.

So the bug is still there for any other way of saving the ontology (i.e. not using ontoconvert)?

Looks good as far as I was able to see when testing. However, tests are missing. Maybe add a test where testonto.ttl is squash saved and then check that this is the same as the original after loading? First check that new IRI and BASE_IRI are changed and change back of course... And also check that the squashed ontology no longer imports other ontologies (Is this correct?)
Also, where is / --> # hack done? Is it a good idea to move this fix out of squash?

Added a second test with squash and change of IRIs to tests/tools/test_ontoconvert.py
There is no explicit / --> # hack. Instead the --iri and --base-iri options of the ontoconvert tool allow setting the iri and base_iri after the ontology is loaded. Hence, these options can be used to work around the bug in Owlready2.

So the bug is still there for any other way of saving the ontology (i.e. not using ontoconvert)?

Yes, it is still there. Issue #723 is a suggestion to work around it when loading an ontology.


Use docker_lint in products

https://github.com/projectatomic/dockerfile_lint

use: https://attackdefense.com/listingnoauth?labtype=container-security-image-security&subtype=container-security-image-security-dockerfile-linting

Should already be in place: https://github.com/datavisyn/github-workflows/blob/new_deployment/.github/workflows/build-product.yml#L70


Add KeyPathwayMiner

Robust de novo pathway enrichment with KeyPathwayMiner 5
https://doi.org/10.12688/f1000research.9054.1
Multiple implementations:

web application (appears to be dead)
Cytoscape app
standalone application

It is unclear where the standalone application is available because their website is down. They link to https://github.com/baumbachlab/keypathwayminer-core.

KeyPathwayMineR: De Novo Pathway Enrichment in the R Ecosystem
https://doi.org/10.3389/fgene.2021.812853
I believe this is the corresponding R package, though it isn't linked from the manuscript
https://github.com/biomedbigdata/keypathwayminer-R
This may be the best implementation for us to wrap.

Notes about KeyPathwayMineR

Run by an interactive R session
Take about 3 minutes to process a graph with 7477 nodes and 25924 interactions to output pathway.txt files

What does it do?

Efficiently extracts all maximal connected sub-networks. Sub-networks contain the genes that are mainly dysregulated
3 ways of network extraction
- Fixed Parameter Tractable
- Greedy
- Ant Colony Optimization

Package and libraries needed for the method

R
rJava

Input data

Biological network
- Sif or igraph format
- Node1		Interaction_type	Node2
- The interaction_type column does not contribute so can just fill with dummy variable
Indicator matrices (can be a problem when adding to SPRAS -> need a matrix)
- Row: biological entities
- Col: case/samples -> if samples differentially expressed compared to the control samples, the entry is a 1, otherwise 0

Output data

Pathway.txt file
Visualized version (use visualize_results() -> never run successfully on my local machine)

Standalone version of KeyPathwayMiner 5.1
https://github.com/biomedbigdata/keypathwayminer-standalone

Same idea as KeyPathwayMineR, but java version of it, lack the power, flexibility and versatility of R -> no visualization and some data preparation functions
Can run with just command line arguments -> fit with SPRAS project
input and output data are basically the same as KeyPathwayMineR


feat(tactic/split_ifs): add if-splitter

Adds a tactic that performs case splits on all ite and dite expressions.
example (p q : Prop) [decidable p] [decidable q] :
    if if if p then ¬p else q then p else q then q else ¬p ∨ ¬q :=
by split_ifs; simp *

I did not find many proofs in mathlib that can be simplified using this tactic.  This is probably due to the fact that most simp lemmas do not rewrite to if-then-else, but use conditions instead.  The most impressive usage so far is in swap_core_swap_core, which previously had a 10-line proof:
def swap_core (a b r : α) : α :=
if r = a then b
else if r = b then a
else r

theorem swap_core_swap_core (r a b : α) : swap_core a b (swap_core a b r) = r :=
by unfold swap_core; split_ifs; cc

Nice! This could be useful for me. Just a couple of questions:

What happens when the target does not have an ite or dite? I think it would be preferable for the tactic to fail.
Why the plural name split_ifs? Does it split multiple ite and dite at once? The documentation says “If there are multiple ite-expressions, then split_ifs picks a top-most one whose condition does not contain another ite-expression.” This implies that only one ite or dite is split. This is fine, but I think the name should be split_if.
Can you use case tags with the subgoals? This is not useful for the short proofs you've given in the examples, but I think it is useful for larger proofs as well as for interactive use (since the case is at the top of the goal).

Can you use case tags with the subgoals? This is not useful for the short proofs you've given in the examples, but I think it is useful for larger proofs as well as for interactive use (since the case is at the top of the goal).

Unfortunately we can only show a list of names as the case tag (and not an expression).  The only reasonable choice I can see here are the names for the hypotheses introduced by by_cases.  Any better idea?

Unfortunately we can only show a list of names as the case tag (and not an expression). The only reasonable choice I can see here are the names for the hypotheses introduced by by_cases. Any better idea?

Nope. Plus, since you can have more than two subgoals due to nested ifs, it's too much. (It would be nice if by_cases used tags, but that's another story.)

The only reasonable choice I can see here are the names for the hypotheses introduced by by_cases.

This choice turns out to be very unhelpful:
case h_1, h
...

case h_1, h
...

case h_1, h
...

case h_1, h
...

It would be nice if by_cases used tags, but that's another story

As long as we can only show names as tags, I don't think it would help much.  You'd get two times case h.

As long as we can only show names as tags, I don't think it would help much. You'd get two times case h.

I meant something like case h_true and case h_false.


Hello everyone!Why do my training results(AP and AR) have negative values?

Average Precision  (AP) @[ IoU=0.50:0.95 | area=   all | maxDets=100 ] = 0.899
Average Precision  (AP) @[ IoU=0.50      | area=   all | maxDets=100 ] = 0.993
Average Precision  (AP) @[ IoU=0.75      | area=   all | maxDets=100 ] = 0.990
Average Precision  (AP) @[ IoU=0.50:0.95 | area= small | maxDets=100 ] = -1.000
Average Precision  (AP) @[ IoU=0.50:0.95 | area=medium | maxDets=100 ] = 0.819
Average Precision  (AP) @[ IoU=0.50:0.95 | area= large | maxDets=100 ] = 0.939
Average Recall     (AR) @[ IoU=0.50:0.95 | area=   all | maxDets=  1 ] = 0.175
Average Recall     (AR) @[ IoU=0.50:0.95 | area=   all | maxDets= 10 ] = 0.917
Average Recall     (AR) @[ IoU=0.50:0.95 | area=   all | maxDets=100 ] = 0.917
Average Recall     (AR) @[ IoU=0.50:0.95 | area= small | maxDets=100 ] = -1.000
Average Recall     (AR) @[ IoU=0.50:0.95 | area=medium | maxDets=100 ] = 0.848
Average Recall     (AR) @[ IoU=0.50:0.95 | area= large | maxDets=100 ] = 0.951

@JC-FOSU It is caused by the cocoapi. Probably because there aren't any small objects in your val data or the model does not predict any small objects (I'm not sure). But based on your mAP 0.899, don't worry, try your model!

I guess it's because there are no targets smaller than 32*32 in the val set.

I also have the same problem. It is useless to adjust LR and so on


Feature request: server caching

This extension is hard to use. The fix is to add a server cache: everybody ships their results back to the server and subsequent match searches are much faster.

This kinda ties in with issue #1: the "results" being shipped back should be people's marking of false positives and false negatives

Good idea, but may be difficult due to the following

Duration of cache

Bluesky's users fluctuate constantly. New people come in and sometimes disappear.Real-time data is what makes it valuable.

Server operating costs

Currently, everything is done in the browser. Operating a new server would be expensive.


Update akka-coordination, akka-stream, ... to 2.6.16

Updates

com.typesafe.akka:akka-coordination
com.typesafe.akka:akka-stream
com.typesafe.akka:akka-testkit

from 2.6.10 to 2.6.16.
GitHub Release Notes - Version Diff
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "com.typesafe.akka" } ]

labels: library-update, semver-patch

Superseded by #73.


More clear and readable expression

Improvement of the regular expression for more clear and readable code

Thanks @eukub, but the two expressions are not equivalent.


Add readme

Need to add a readme to explain board, layers, modulo calculation, code setup, build instructions, etc.

Initial version there. Further cleanup / additions can be done separately.


feat: hide remove attachment button if action can't be executed

Summary
Check permissions and post edit time limit in the webapp as well.

@fmartingr Tested but:

not working if permission allows edit to others' post but not delete, and

This is working for me:
https://github.com/user-attachments/assets/aca22593-b9fc-4454-8878-ce50fd07e451

not working if permission is granted to team admin but not to channel admin.

This wasn't being checked on the backend either. Adding it now.


Error while saving a model with one layer having a list of one ragged item

System information

Have I written custom code (as opposed to using a stock example script provided in TensorFlow): yes
OS Platform and Distribution (e.g., Linux Ubuntu 16.04): linux
Mobile device (e.g. iPhone 8, Pixel 2, Samsung Galaxy) if the issue happens on mobile device:
TensorFlow installed from (source or binary): 2.3.rc0
TensorFlow version (use command below):
Python version: 3.7
Bazel version (if compiling from source):
GCC/Compiler version (if compiling from source):
CUDA/cuDNN version:
GPU model and memory:

Describe the current behavior
If you try to save a model which has a layer that takes only one ragged input in a list you can save it but not load it.
Describe the expected behavior
To be able to load it back.
Standalone code to reproduce the issue
import tensorflow as tf
class Test(tf.keras.layers.Layer):
  def call(self, inputs):
    return inputs[0][0][0]

a = tf.keras.layers.Input(ragged=True, shape=(None,))
m = tf.keras.models.Model(a, Test()([a]))
m.save('test')
tf.keras.models.load_model('test')

ValueError: Could not find matching function to call loaded from the SavedModel. Got:
Positional arguments (1 total):
* tf.RaggedTensor(values=Tensor("inputs:0", shape=(None,), dtype=float32), row_splits=Tensor("inputs_1:0", shape=(None,), dtype=int64))
Keyword arguments: {}
Expected these arguments to match one of the following 1 option(s):
Option 1:
Positional arguments (1 total):
* [RaggedTensorSpec(TensorShape([None, None]), tf.float32, 1, tf.int64)]
Keyword arguments: {}

Other info / logs Include any logs or source code that would be helpful to
diagnose the problem. If including tracebacks, please include the full
traceback. Large logs and files should be attached.
Link to gist: https://colab.research.google.com/gist/tanguycdls/cfbed31d313c247d2dc9d12bc19148cc/untitled20.ipynb

@tanguycdls
I ran the code shared and face a different error, please find the gist here.

@Saduf2019 I think you imported keras from keras.layers.input and not tf.keras.
Input has a keyword argument ragged described here: https://www.tensorflow.org/api_docs/python/tf/keras/Input

@tanguycdls
Can you please share a executable gist with the error faced.

@tanguycdls
Can you please share a executable gist with the error faced.

Yes Link to gist: https://colab.research.google.com/gist/tanguycdls/cfbed31d313c247d2dc9d12bc19148cc/untitled20.ipynb
Does it work? it was on the issue.

I am able to replicate this issue, please find the gist here.

Issue is still happening in TF2.4rc2 :(

Still an issue in TF2.5.rc1

issue still exist in TF 2.5 stable version. Please find the gist here.

Hi,
Thank you for opening this issue. Since this issue has been open for a long time, the code/debug information for this issue may not be relevant with the current state of the code base.
The Tensorflow team is constantly improving the framework by fixing bugs and adding new features. We suggest you try the latest TensorFlow version with the latest compatible hardware configuration which could potentially resolve the issue. If you are still facing the issue, please create a new GitHub issue with your latest findings, with all the debugging information which could help us investigate.
Please follow the release notes to stay up to date with the latest developments which are happening in the Tensorflow space.


Bug in calculating timezone offset in time data received from worldtimeapi.org

In the section "Set RTC time from time service," the field raw_offset from the json received from the time service does not take daylight savings into consideration. However, utc_offset does. I was getting the wrong local time here in Southern California during daylight savings until I made the following modification:
print("Getting current time:")
response = requests.get("http://worldtimeapi.org/api/ip")
time_data = response.json()
tz_hour_offset = int(time_data['utc_offset'][0:3])
tz_min_offset = int(time_data['utc_offset'][4:6])
if (tz_hour_offset < 0):
    tz_min_offset *= -1
#unixtime = int(time_data['unixtime']) + int(time_data['raw_offset']) # << Incorrect offset during DST
unixtime = int(time_data['unixtime'] + (tz_hour_offset * 60 * 60)) + (tz_min_offset * 60)

print(time_data)
print("URL time: ", response.headers['date'])

rtc.RTC().datetime = time.localtime( unixtime ) # create time struct and set RTC with it

Here is the json data I received from worldtimeapi.org:
{
   'timezone': 'America/Los_Angeles',
   'utc_datetime': '2023-03-18T19:20:44.368793+00:00',
   'raw_offset': -28800,
   'client_ip': 'redacted',
   'dst_from': '2023-03-12T10:00:00+00:00',
   'unixtime':<PHONE_NUMBER>,
   'utc_offset': '-07:00',
   'datetime': '2023-03-18T12:20:44.368793-07:00',
   'week_number': 11,
   'abbreviation': 'PDT',
   'day_of_year': 77,
   'day_of_week': 6,
   'dst': True,
   'dst_offset': 3600,
   'dst_until': '2023-11-05T09:00:00+00:00'
}

Here  we can verify that raw_offset of -28800 = -8 hours, but utc_offset is -7 hours, which is correct during DST.

Hi jkvato,
I had the same problem, but then found another solution. In the requested json data, what is written at datetime is correct. That's why I used this.
# Raspberry Pico W
import board
import busio

import wifi
import socketpool
import adafruit_requests as requests

import time
from adafruit_datetime import datetime
import adafruit_ds3231

i2c = busio.I2C(board.GP21, board.GP20)
rtc = adafruit_ds3231.DS3231(i2c)

print(f'Connecting to {secrets["ssid"]}')
wifi.radio.connect(secrets["ssid"], secrets["password"])
print(f'Connected to {secrets["ssid"]}')

pool = socketpool.SocketPool(wifi.radio)
TIME_API = "http://worldtimeapi.org/api/ip"

def get_internet_time(socketpool: socketpool.SocketPool) -> time.struct_time::
    '''Return a struct_time object with current time from internet request.'''
    request = requests.Session(socketpool)
    response = request.get(TIME_API).json()['datetime']
    json_time = datetime.fromisoformat(response)
    return json_time.timetuple()

rtc.datetime = get_internet_time(pool)
print(rtc.datetime)

Hope this helps you.

Hi @deilers78,
That's a simple approach, for sure. Thanks for sharing!


cmd/go: Docs for go mod vendor does not include any information about vendoring a module for making changes

What is the URL of the page with the issue?
https://go.dev/ref/mod#go-mod-vendor
What is your user agent?
Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/<IP_ADDRESS> Safari/537.36
Screenshot

What did you expect to see?
In the docs for go mod vendor I expect to see something regarding vendoring a dependency for making changes. For example bug fixes or addressing vulnerabilities. However, in the docs it explicitly says "Local changes should not be made to vendored packages". I think it would be nice to include a quick mention of this usecase here and a link to the "replace" directive and/or "workspaces" to address this.

The docs for go mod vendor are already too verbose; I'd rather not make them even more so. (We're trying to whittle down that verbose subcommand help text over time, but there's still a long way to go.)
In general I would expect users looking for “how to” content to start at https://go.dev/doc/ instead of the docs for individual go subcommands.

Thanks for the explanation! It makes sense to shorten the help text.
To find the information I need from the main docs page, I need to:

Find and click on Module release and versioning workflow
Read "Coding against an unpublished module".

AND
Read https://go.dev/doc/tutorial/workspaces
Once I have fully understood both possible approaches, and read the note that "replace directives are only applied in the main module" here, then I can finally make an informed decision on the approach I will take.
This seems a bit excessive when there could be a short blurb somewhere about "vendoring a module for bug/security fixes" that could link to these.
Maybe I'm missing something here?

Vendoring for bug fixes is almost always the wrong solution as it bypasses all of go's dependency management. It shouldn't be a serious option.
Workspaces are local only, they shouldn't factor in to this.

I am thinking of the case where a user wants to vendor some/all of their dependencies into a monorepo. If any edits need to be made to fix bugs, they can simply edit the module code directly. If a new version of the module is published and they wish to update, they will be required to resolve the merge conflicts.
A workspace can be used to achieve this although I am unsure if this is an intended usecase for them or not.


Get plugin network

Allow users to check the plugin network configuration

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 15.08%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
107

Relevant Lines:
683

💛  - Coveralls

Some plugins support multiply networks. For example, RpcServer.

Some plugins support multiply networks. For example, RpcServer.

OOOOOOK, need more work on them then~~~~

And why do we need this command?

And why do we need this command?

Cause it is hard to figure out what is happening when you have everything right but the node never run correctly, just like what is mentioned here https://github.com/neo-project/neo-node/issues/824#issuecomment-1090464930

If you can think of using this command, then you must have realized what the problem is, then this command is useless.

I would say, locating issue with one command is way batter than "get into multiple plugins, open their config.json files, then compare the network cross multiple files". Cli is supposed to make things easier right?


Unknown error - Ariston Genus One+ Wifi 24 EU

Hello Fustom,
First of all, thank you your great job.
Describe the bug
First time, I managed to integrate my brand new Ariston Genus One+ Wifi 24 EU. All sensors, switches appeared as expected.
Then suddenly all sensors got unknown.
Maybe it was not the best decision, but I deleted the entire integration, and started from scratch
After that, if I try to login, I get an error message saying that an unknown issue has occurred.

Probably the authentication goes fine, because if I intentionally type a wrong pwd, I get a different error message.
Expected behavior
I should be able to integrate my new device.
Screenshots
I've just added above.
Environment (please complete the following information):

HA version: 2024.5.4
Version of the integration: v0.19.4
Ariston device type: Ariston Genus One+ Wifi 24 EU.

Additional context, debug log
Add any other context about the problem here.
Thank you in advance.

Okay, checking the logs it seems my requests are blocked:
File "/config/custom_components/ariston/config_flow.py", line 87, in async_step_user
cloud_devices = await ariston.async_discover()
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/local/lib/python3.12/site-packages/ariston/init.py", line 56, in async_discover
cloud_devices = await _async_discover(self.api)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/local/lib/python3.12/site-packages/ariston/init.py", line 166, in _async_discover
] = await asyncio.gather(
^^^^^^^^^^^^^^^^^^^^^
File "/usr/local/lib/python3.12/site-packages/ariston/ariston_api.py", line 522, in async_get_detailed_velis_devices
detailed_velis_devices = await self._async_get(
^^^^^^^^^^^^^^^^^^^^^^
File "/usr/local/lib/python3.12/site-packages/ariston/ariston_api.py", line 930, in _async_get
return await self.__async_request("GET", path, params, None)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/local/lib/python3.12/site-packages/ariston/ariston_api.py", line 906, in __async_request
raise Exception(response.status, content)
Exception: (429, b'Requests are blocked for 3 seconds')

Update 2:
It seems I should have opened a bug on Ariston side. Probably my user was banned for a while. This morning, I tried to connect again, and it worked perfectly.
As everything works now, I'm closing this issue.
Thank you very much for your great work.


issue when creating new Crud  Page blank

I try to create a new Crud then after save button click page blank
In menu table data insert properly but not create new table for new menu
I don't understand why  and I am using  laravel 5.2

Hello,
Could you give us more details? I can't recreate this error

I go to menu and click "Create new CRUD Controller"  When i Create new CRUD menu item  then i got issue
FatalErrorException in 2016_04_06_134513_create_page_table.php line 0: Cannot redeclare class CreatePageTable
This file location is /var/www/html/meridian/database/migrations   and
new file permission is
Owner : www-data
Group : www-data
access : " read only "
Other    "read only "
And i check database i don't find new table for new crud menu item

I guess the problem is that you tried to create a CRUD and it failed or that you creating the same crud twice. The error you have is mostly caused by the fact that the system is trying to create a second class named identically.
The one thing that I can offer is try to delete the half generated files and delete our cache file located in storage folder.

Thanks for raply
Now i get this error , can u help me for it
ErrorException in /var/www/html/meridian/vendor/laraveldaily/quickadmin/src/Builders/ViewsBuilder.php line 288:
chmod(): Operation not permitted

This is the result of user rights not used right. To be fair I can't help you with that more than offer you to check your right with which apache is runnig :)

maybe the same pb [https://github.com/LaravelDaily/quickadmin/issues/30]

remove the data entries in database Table: menus for "CreatePage"
delete file "fieldsinfo" from cache directory
if it exists remove migration file 2016_04_06_134513_create_page_table.php
search everyWhere in your project directory the occurrence or files "CreatePage"

And let's try again ^^
Regards


FIX: If a student tries to create a first and/or last name with non-a…

…lpha characters, an exception is generated.
[#109385842]

The rebase to the ruby-2.2 branch appears to have caused merge issues? I am closing this without merging and will fix this bug in a different branch.


[FLINK-33433][rest] Introduce async-profiler to support profiling Job…

…Manager via REST API
What is the purpose of the change
This is a subtask of FLIP-375, which introduces the async-profiler for profiling Jobmanager.
Brief change log

Include async-profiler dependency
Introduce APIs for Creating Profiling Instances / Downloading Profiling Results / Retrieving Profiling List
Provide a web page for profiling jobmanager on  Flink WEB

Verifying this change
This change added tests and can be verified as follows:

Added test that validates that ProfilingService works fine in different profiling mode.
Added test that validates that Rolling Deletion works fine.

Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): yes
The public API, i.e., is any changed class annotated with @Public(Evolving): no
The serializers: no
The runtime per-record code paths (performance sensitive): no
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
The S3 file system connector: no

Documentation

Does this pull request introduce a new feature? yes
If yes, how is the feature documented? not documented, it will be added in FLINK-33436

I think a better understanding of how to write unit tests is important, you can refer to other existing tests. Please take a look at my comments.

Hi @Myasuka ,
Sorry for the late response, I have been a bit busy at work recently.
I have updated the unit tests as commented. Thanks again for your helpful comments!


PM Policy Event: Update to use uptime ticks and be "sticky"

Registering a pm policy event will now represent a single event in absolute time, which will remain active, preventing the system from suspending, until the event has been handled. To indicate an event has been handled, it must be updated to a time in the future, or unregistered.
To greatly simplify the events and the "sticky" logic, the time primitive used is updated to the monotonic uptime in ticks. This ensures an event can be determined to be in the past, since unlike the HW cycle, uptime can't wrap. Additionally, the kernel works in ticks, which aligns the resolution with the requirements of the kernel, and removes the need for conversions between pm and the kernel, see pm_policy_next_event_ticks() before this PR.
fixes: #80386

ping @ceolin


V6.712 crashes

Checklist

[X] I have used the search function to see if someone else has already submitted the same bug report.
[X] I will describe the problem with as much detail as possible.

App version
6.712
Where did you get the app from?
Other
Android version
Android 14
Device model
Pixel 8 Pro
Steps to reproduce
Open App
Wait for referesh Outlook, Google, other imap account
Refresh takes about 5 - 10 sec
App crashes
Expected behavior
No crash and running app
Actual behavior
Open App
Wait for referesh Outlook, Google, other imap account
Refresh takes about 5 - 10 sec
App crashes
Logs
No response

What sensitive data is in the log? Should I remove something of it?

Let's start with the stack trace and see if that's enough to find out what's going on. It should look similar to what you can see e.g. here: #7392 (under "Logs").
If the error message contains sensitive data, feel free to redact it.

--------- beginning of crash
11-30 21:14:37.982  9569  9812 E AndroidRuntime: FATAL EXCEPTION: ImapFolderPusher-Microsoft Account
11-30 21:14:37.982  9569  9812 E AndroidRuntime: Process: com.fsck.k9, PID: 9569
11-30 21:14:37.982  9569  9812 E AndroidRuntime: java.lang.SecurityException: Caller com.fsck.k9 needs to hold android.permission.SCHEDULE_EXACT_ALARM or android.permission.USE_EXACT_ALARM to set exact alarms.
11-30 21:14:37.982  9569  9812 E AndroidRuntime: 	at android.os.Parcel.createExceptionOrNull(Parcel.java:3057)
11-30 21:14:37.982  9569  9812 E AndroidRuntime: 	at android.os.Parcel.createException(Parcel.java:3041)
11-30 21:14:37.982  9569  9812 E AndroidRuntime: 	at android.os.Parcel.readException(Parcel.java:3024)
11-30 21:14:37.982  9569  9812 E AndroidRuntime: 	at android.os.Parcel.readException(Parcel.java:2966)
11-30 21:14:37.982  9569  9812 E AndroidRuntime: 	at android.app.IAlarmManager$Stub$Proxy.set(IAlarmManager.java:311)
11-30 21:14:37.982  9569  9812 E AndroidRuntime: 	at android.app.AlarmManager.setImpl(AlarmManager.java:1084)
11-30 21:14:37.982  9569  9812 E AndroidRuntime: 	at android.app.AlarmManager.setImpl(AlarmManager.java:1044)
11-30 21:14:37.982  9569  9812 E AndroidRuntime: 	at android.app.AlarmManager.setExactAndAllowWhileIdle(AlarmManager.java:1312)
11-30 21:14:37.982  9569  9812 E AndroidRuntime: 	at com.fsck.k9.helper.AlarmManagerCompat$$ExternalSyntheticApiModelOutline0.m(R8$$SyntheticClass:0)
11-30 21:14:37.982  9569  9812 E AndroidRuntime: 	at com.fsck.k9.helper.AlarmManagerCompat.scheduleAlarm(AlarmManagerCompat.kt:10)
11-30 21:14:37.982  9569  9812 E AndroidRuntime: 	at com.fsck.k9.backends.AndroidAlarmManager.setAlarm(AndroidAlarmManager.kt:62)
11-30 21:14:37.982  9569  9812 E AndroidRuntime: 	at com.fsck.k9.backend.imap.BackendIdleRefreshManager.setAlarm(BackendIdleRefreshManager.kt:66)
11-30 21:14:37.982  9569  9812 E AndroidRuntime: 	at com.fsck.k9.backend.imap.BackendIdleRefreshManager.onTimeout(BackendIdleRefreshManager.kt:93)
11-30 21:14:37.982  9569  9812 E AndroidRuntime: 	at com.fsck.k9.backend.imap.BackendIdleRefreshManager.resetTimers(BackendIdleRefreshManager.kt:42)
11-30 21:14:37.982  9569  9812 E AndroidRuntime: 	at com.fsck.k9.backend.imap.ImapBackendPusher.onPushEvent(ImapBackendPusher.kt:187)
11-30 21:14:37.982  9569  9812 E AndroidRuntime: 	at com.fsck.k9.backend.imap.ImapFolderPusher.performInitialSync(ImapFolderPusher.kt:99)
11-30 21:14:37.982  9569  9812 E AndroidRuntime: 	at com.fsck.k9.backend.imap.ImapFolderPusher.runPushLoop(ImapFolderPusher.kt:59)
11-30 21:14:37.982  9569  9812 E AndroidRuntime: 	at com.fsck.k9.backend.imap.ImapFolderPusher.access$runPushLoop(ImapFolderPusher.kt:15)
11-30 21:14:37.982  9569  9812 E AndroidRuntime: 	at com.fsck.k9.backend.imap.ImapFolderPusher$start$1.invoke(ImapFolderPusher.kt:36)
11-30 21:14:37.982  9569  9812 E AndroidRuntime: 	at com.fsck.k9.backend.imap.ImapFolderPusher$start$1.invoke(ImapFolderPusher.kt:33)
11-30 21:14:37.982  9569  9812 E AndroidRuntime: 	at kotlin.concurrent.ThreadsKt$thread$thread$1.run(Thread.kt:30)

Thanks.
The problem is caused by the app trying to use exact alarms when Push is enabled. Android 14 requires the user to manually grant permission for this. We did have on our radar that we need to do additional work to guide users to grant that permission. However, I failed to notice that the app will crash (as opposed to Push not working) in its current state.
You should be able to avoid the crash (and make Push work) by allowing the app to use "Alarms & Reminders" in Android's app info screen for K-9 Mail.

Allright, I was able to set "Allow setting alarms and reminders" manually and now it workes again. As you described. Thanks!


redemption widget - I need to wait 15 sec to see the first page appearing (wallet dependant)

fixes by https://github.com/bosonprotocol/core-components/pull/642

looks ok when I tested


scripts: gen_priv_stacks: Remove unused static kernel object stuff

Might've been a copy-paste from scripts/gen_kobject_list.py.

Codecov Report

Merging #14887 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #14887   +/-   ##
=======================================
  Coverage   52.48%   52.48%
=======================================
  Files         309      309
  Lines       45063    45063
  Branches    10434    10434
=======================================
  Hits        23653    23653
  Misses      16595    16595
  Partials     4815     4815

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 295dc41...135a396. Read the comment docs.


Consider new question type that allows multiple choice plus "other" free text option

Creating this issue to collect ideas/suggestions on this kind of question

What is our current thinking on this? Should we modify QuestionMultipleChoice or create a new type?
We should consider it in connection with

Optionally allowing "None" responses to multiple choice questions
Whatever we decide with respect to handling matrix question type


Show more information about running Prebid Version

In the UI we are already displaying the publisher's Prebid setup version.
Many publishers do not update the setup for many months and are hesitant to update.
We want to encourage the publishers to keep their setups up to date, so I think the following information should be displayed in the extension UI, am leaving the UX and implementation part open to the discussion.

Mention what is the latest Prebid release version
Display how many months/weeks/days old is the current setup compared to the latest Prebid release
Mention (in numbers) how many bug fixes and features have been released since the currently running version
If possible, display the list of bugs and features released since the currently running version ( initially we can just put the link to the Prebid releases page )

Hi @pm-harshad-mane ,
i'd be happy to show that info. is there an api or similar where i can pull it from?

Did we discuss this issue in the last meeting?

Did we discuss this issue in the last meeting?

We did :) Investigating the process to achieve though

Sync'd up with @florianerl, I will start to work on dev work for this ticket.

@ChrisHuie @florianerl @pm-harshad-mane, I created a PR today addressing the ask for this ticket.  More info can be found in the description on the PR.  I also, recorded a quick video for an easier way to show the UI and walk through the features.  Open to feedback like always, expect I'll get some : ) Let me know what you guys think.
https://vimeo.com/851466838


Remove undefined variable in Auth example

Remove undefined variable in Auth example

thanks!
verified that the code works&looks okay even without the styles, so removing should cause no issues


Update groovy android gradle plugin for compatibility with gradle 6.0

fixes #628

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Version 2.0.0 introduced changes to the build system and Groovy is no longer needed. Thanks for PR though!


Page 404

Description
Currently there isn't a custom 404 page and when landing at a page that doesn't exist, the default message is "An unexpected error has occurred.". In Next.js creating a custom 404 page is as easy as creating a pages/404.js file , so I thought it would be a nice adition. Anytime trying to access a page that doesn't exist, it will fall to that page.
About the content it could be a simple message like Page Not Found and a link to go back to homepage? What do you think?

yeah i think that makes sense! good call
are any other error pages common? i guess it's not server-side, so there really shouldn't be any other "error" pages

Exactly, this 404 is statically generated. Next provides another option of custom errors at pages/_error.js but these rely on server-side: https://nextjs.org/docs/advanced-features/custom-error-page#customizing-the-error-page
I'm trying to find out why currently is throwing that An unexpected error has occurred. on non-existing pages, because Next has a default 404 page ...

could it be due to using fallback: false,? i would still expect nextjs to provide a 404 instead but im not 100% sure of the details of that properly

So according to the doc: If fallback is false, then any paths not returned by getStaticPaths will result in a 404 page. In other projects i'm getting the default 404 correctly ... strange

Creating the 404.js file seems to solve this issue. Even in the case of having the default 404 I thought that by having a custom one would be a good idea in order to wrap the error with the Layout that allows navigation (header and footer), and also providing a quick link to go back.

yeah thats really weird... i'd be curious to know why but at least it resolves it 🤷

I think I found the reason. According to the doc: If you have a custom App with getInitialProps then this optimization will be turned off in pages without Static Generation.. So as the custom _app is now using the getInitialProps the Automatic Static Optimization is turned off. Made a test taking off the getInitialProps and the 404 is working properly.

ahh interesting okay. well good to know
as much as i love the unopinionated data layer, i wish there was a better opinionated mechanism for global data fetching like that


Misc features

Added several new features that we found handy for our CI/CD use cases :

paths normalization
includes filtering
listing definitions and include paths

On the way, fixed issues that we found annoying :

Fixed file argument handling : the file need not be named compile_commands.json, although it is the default
UT: now working on copies of test data.
UT: tried to be more platform independent

Hi, thank you very much for your pull request. :+1:
I'm currently reworking the script to make it work on a CDB based on arguments rather than commands which is the type of CDB recommended by the specs.  For that reason I won't merge this pull request. That being said I will update the script to support your use cases and probably copy paste some of your stuff. Hope that works for you.

Thank you for your feedback, that work for me !
I did considered making the script to  work on a CDB based on arguments as well, prior implementing my use cases. It seemed easier to work with. However that implied refactoring your legacy code and I did not feel comfortable reworking the whole script.
Regards

Closing this as I've implemented most of the features listed.
I haven't implemented the listing of definitions and include paths as I see the point of this feature. Feel free to open an issue explaining your use case.


Highlight struct/enum/union keywords using @structure

According to this resource, the Structure highlight group is meant to highlight keywords such as struct, enum, union, etc. By default, the @structure highlight group in nvim-treesitter links to Structure. As such, this parser should highlight the struct, enum, and union keywords using @structure instead of @keyword.
This change would enable third-party color schemes to highlight this keyword separately from other Rust keywords. For example, see this screenshot of Monokai in Sublime Text 4 doing just that.

wrong repo

Hello there, @amaanq! Would you mind clarifying a little what you mean? The request described above is to change the highlights.scm query script provided with tree-sitter-rust to emit the @structure highlight when they keywords struct, enum, and union are encountered rather than @keyword, as is currently done. This would increase the flexibility of downstream projects depending on tree-sitter-rust for highlighting. Is this understanding not accurate?

Sorry to ping directly again, @amaanq, but I was wondering if you might be able to clarify why this issue is outside the scope of this repository? I understand that this repo contains the highlights.scm file which defines the highlight queries and TS groups, correct? Thanks again.

Sorry, just seeing this again after cleaning my issues - it belongs in the tool that you use for highlighting, I am not sure what your screenshot is from but it's definitely not tree-sitter cli output, so file an issue there

I know it's been a while since I last opened this issue, but I have no clue what I was thinking when I first wrote the issue description. I think I misunderstood what purpose tree-sitter-rust served in relation to nvim-treesitter and how queries in TS work in general. Sorry about that!
I have since opened a separate issue on the nvim-treesitter repo instead with a hopefully clearer explanation of what I was originally looking for: https://github.com/nvim-treesitter/nvim-treesitter/issues/6205


finetuning problems and some files can't creat.

When I  use the finetuning commands that print out to finetune the CNN,
'jobName = 'hha_cache_features'; I saw the script_detection.m file,there is a code  ' the ' net_file = fullfile_ext(p.snapshot_dir, sprintf('nyud2_finetune_hha_iter_%d', snapshot), 'caffemodel'); ' but there is no nyud2_finetune_hha_iter_%d.caffemodel file in the cachedir/release/detection/dinetuning/snapshot dir. Is it a existing  file or need to creat by my self?
I step by step according the Readme, but I did't creat any mat files in cachedir/release/output/regions, could you tell me which step do this? Because my cluster can noT adapt jobParallel, so I used for loop instead it to call some function, I think maybe some step I use a wrong funcion so that I didn't make the right outputs.
In addition, is caffe-0.999 version you use to run the rcnn?
Thank you for your answers!

Can you run the file'demo.m',I run the demo,but it warned in the 4th sentence,whether the founction file is loss? and I can extract the whole compress file,,can you extract?


Cron has broken style in antd 5

Describe the bug
Cron component has broken style when used in antd 5. Hour and minute picker is unusable.
CodeSandbox
A CodeSandbox link with the bug.
Versions (please complete the following information):

react-js-cron version [3.1.0]
Ant Design version: [5.3.2]
React version: [18.2.0]
OS: [Windows]
Browser [Firefox]

Hello,
As mentioned in the README, since v3.0 you need to manually import Cron styles:
import 'react-js-cron/dist/styles.css'

CodeSandbox:
https://codesandbox.io/s/sharp-edison-7cph0n?file=/src/App.tsx

Thank you, i missed it since i went straight to the demo and usage which is at top of the page.


Avoid NaN in Commit Offset Failure Rate OffsetCommitServiceMetrics by…

… initializing with a zero only when instantiating.
Avoid having XM reporting NaN for its failure rate by initializing the value of the failure rate sensor with a zero value.
[2020-07-02 15:06:54,609] INFO ==============================================================
kmf:type=kafka-monitor:offline-runnable-count=0.0
kmf.services:name=offset-commit-service,type=offset-commit-service:offset-commit-availability-avg=1.0
kmf.services:name=offset-commit-service,type=offset-commit-service:offset-commit-service-success-rate=1.0
kmf.services:name=offset-commit-service,type=offset-commit-service:offset-commit-service-success-total=4.0
kmf.services:name=offset-commit-service,type=offset-commit-service:offset-commit-service-failure-rate=0.0
kmf.services:name=offset-commit-service,type=offset-commit-service:offset-commit-service-failure-total=0.0
 (com.linkedin.xinfra.monitor.services.DefaultMetricsReporterService)

Signed-off-by: Andrew Choi<EMAIL_ADDRESS>

@mgrubent  -- minor PR.

Where are we trying to avoid NaN?
Is it possible to map NaN appropriately in that method?

I don’t have any opinion on whether NaN is bad or good. I’m okay with persisting NaN. Just looks kinda strange when everything else is > 0. Also, maybe InGraph might be confused since it’s NaN. Whereas if we have 0 -> this means we have 0 percent failure rate.
Nonetheless, let’s continue with NaN for now; rather that the Sensor itself is a true and unaltered record of what values it recorded.

Sounds good to me, thanks @andrewchoi5

Sounds good to me, thanks @andrewchoi5

Thanks, made one last change to note this behaviour in a code comment.


InstantSearch.js v2

This PR contains the changes for the V2 of InstantSearch.js.
This new version brings:

connectors API, and with it the capability of reusing the logic of the widgets without their rendering
better documentation, with more in-depth description of the different aspects of the library, a getting started and guides
some clean up in the API

I've implemented every widgets with connector using only the docs and I made a list of mistakes in the docs that I can easily fix before release:

connectMenu

canToggleShowMore is undefined

connectCurrentRefinedValues

doc type of refinements rendering option

connectHierarchicalMenu

typo for attributes in documentation of widget option
showParentLevel wrong type

connectNumericRefinementList

Example uses item.label and docs says use item.name
No docs about operator widget params

connectNumericSelector

Default operator is not displayed correctly in doc
Still has currentRefinement in doc
Add the possible operator options

connectPriceRanges

Missing items.url doc

BUT, all the code example of connectors are written in ES5. We should rewrite all connectors examples with ES6, it’s too hard to read when the code is a bit complex. What do you think?


Update Authorization proxy server to expose services

Description
PR to add role service and storage service addresses to the proxy server for v1.6.0 and make namespace configurable throughout manifest.
GitHub Issues
List the GitHub issues impacted by this PR:

GitHub Issue #

https://github.com/dell/csm/issues/408

Checklist:

[x] I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
[x] I have verified that new and existing unit tests pass locally with my changes
[x] I have not allowed coverage numbers to degenerate
[x] I have maintained at least 90% code coverage
[x] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] I have added tests that prove my fix is effective or that my feature works
[x] I have maintained backward compatibility

How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

[x] Tested with dellctl volume list cmd

dellctl volume list --insecure true --proxy https://authorization-ingress-nginx-controller.authorization.svc.cluster.local:30895/proxy/volumes --namespace vxflexos
NAME             VOLUME ID          SIZE       POOL     SYSTEM ID          PV NAME          PV STATUS   STORAGE CLASS   PVC NAME                NAMESPACE
k8s-bef456fe25   b5aec54500000009   8.000000   mypool   x	           k8s-bef456fe25   Bound       vxflexos-xfs    vol-create-test-9hzzf   volumeio-test-1b605639
k8s-76d1a6f499   b5aec54400000008   8.000000   mypool   x 		   k8s-76d1a6f499   Bound       vxflexos        vol-create-test-pc2mw   volumeio-test-4ec858dc
k8s-e9bab92233   b5aec54b0000000f   8.000000   mypool   x 		   k8s-e9bab92233   Bound       vxflexos-xfs    vol-create-test-dtddb   volumeio-test-1b605639
k8s-01d22c1f80   b5aec5480000000c   8.000000   mypool   x 		   k8s-01d22c1f80   Bound       vxflexos        vol-create-test-plhxg   volumeio-test-4ec858dc
k8s-2af899f72b   b5aec5470000000b   8.000000   mypool   x 		   k8s-2af899f72b   Bound       vxflexos-xfs    vol-create-test-xgw2t   volumeio-test-1b605639
k8s-977fb8f0b9   b5aec54200000005   8.000000   mypool   x 		   k8s-977fb8f0b9   Bound       vxflexos        vol-create-test-wwdhk   volumeio-test-4ec858dc
k8s-f110faf812   b5aec54a0000000e   8.000000   mypool   x 		   k8s-f110faf812   Bound       vxflexos        vol-create-test-5tqqj   volumeio-test-4ec858dc
k8s-43e74d5a20   b5aec5490000000d   8.000000   mypool   x 		   k8s-43e74d5a20   Bound       vxflexos-xfs    vol-create-test-thjm2   volumeio-test-1b605639
k8s-641d4564fc   b5aec5460000000a   8.000000   mypool   x 		   k8s-641d4564fc   Bound       vxflexos        vol-create-test-qxnn8   volumeio-test-4ec858dc
k8s-c77418cf3c   b5aec54300000007   8.000000   mypool   x 		   k8s-c77418cf3c   Bound       vxflexos-xfs    vol-create-test-mm29v   volumeio-test-1b605639

Why are we changing for 1.3.0 and 1.4.0 release yamls?

Add novus team in codeowners

@shaynafinocchiaro, as per the description it is for v1.6.0. Then why are we updating the manifests for versions prior to 1.6.0?

@shaynafinocchiaro please remove 1.3.0 related manifests as we support only n-2 versions of driver and modules
@tdawe and @bharathsreekanth , please share your thoughts on the same

This comment is not in the scope of this PR and can be addressed in another PR if needed @shaynafinocchiaro please remove 1.3.0 related manifests as we support only n-2 versions of driver and modules @tdawe and @bharathsreekanth , please share your thoughts on the same

Agreed, we will need a new story to remove old manifests from the operator. @bharathsreekanth can that be created and assigned to a team? Thanks

This comment is not in the scope of this PR and can be addressed in another PR if needed @shaynafinocchiaro please remove 1.3.0 related manifests as we support only n-2 versions of driver and modules @tdawe and @bharathsreekanth , please share your thoughts on the same

Agreed, we will need a new story to remove old manifests from the operator. @bharathsreekanth can that be created and assigned to a team? Thanks

Driver teams have taken care of this when adding support for the newer version. Open PRs from PowerScale and PowerDlex have taken care of this

@shaynafinocchiaro can we merge this PR ? I do see this PR is bit out of date base branch.  can you please re-base this quickly ?

@rensyct Please help review I've removed v1.3.0 related manifests. Thank you

This comment is not in the scope of this PR and can be addressed in another PR if needed @shaynafinocchiaro please remove 1.3.0 related manifests as we support only n-2 versions of driver and modules @tdawe and @bharathsreekanth , please share your thoughts on the same

I think we should stick to n-2 version in CSM operators. It would make things hard to track if we deviated from that and added more versions.


SEGSAdmin produces setGeometry warning on startup

Expected behavior
SEGSAdmin runs without warning
Actual behavior/symptoms
Running SEGSAdmin produces this warning on startup:
setGeometry: Unable to set geometry 764x849+8+31 on QWidgetWindow/'SEGSAdminToolWindow'. Resulting geometry:  764x822+8+31 (frame: 8, 31, 8, 8, custom margin: 0, 0, 0, 0, minimum size: 596x822, maximum size: 764x16777215).
Steps to reproduce behavior/symptoms
Run SEGSAdmin and the warning should display in console. SEGSAdmin still runs normally (afaik) despite the warning.
SEGS version
Latest master
Operating system
Windows 10

@JamesDW1 Hey James, what screen resolution are you using please? I can only replicate this with a low resolution of around 1024 x 768. It seems SEGSAdmin is struggling to fit to the size constraints due to a low resolution perhaps?

@nemerle @broxen hey, @JamesDW1 reported yesterday that the resize I did didn't make much of a difference, any suggestions on how to proceed for users with low resolutions? Few ideas:
a) Start maximized for low resolutions?
b) Re-design UI so it can be vertically smaller, so should fit on lower resolutions better?


[stable/lamp] Make php-fpm configurable

What this PR does / why we need it:
Allows user of the stable/lamp chart to override php fpm configuration in the php container. This is needed so the fpm config can be tuned. Things like configuring the worker pool size and overriding what variables get passed to php via fpm can be done from the fpm config file.
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

[x] DCO signed
[x] Chart Version bumped
[x] Variables are documented in the README.md

/lgtm


Memory usage goes up with time

I'm submitting an issue
Problem

( ) bug report => We are using this node for armv7 based platform with Linux. Problem we are facing is it is taking lot of memory with time and at the end device runs out of memory.

Information
Current behaviour
We are trying to create flow where 18 tags/messages would update in dynamic user space. It works fine and after few hours device goes out of memory.
Expected behaviour
It should not use more memory on run time.
Your Environment

( ) I am using just the Node-RED package and got node-opcua installed with it

Device :

( ) Linux: v 4.10

node-red-contrib-iiot-opcua version: ``
3.8.0

Node: (min. 8.x)
node --version = 8.11.4

Node-Red version - 0.19 Milestone Release

Hi, could you write about the Node-RED version too, please?

reopen with the information


Port to spago from bower/pulp

Here is my attempt to continue with the work done here #127 in replacing bower/pulp with spago. I focused on getting CI setup to build and test the concept and practice exercises. The approach is more or less similar to what was being done for bower. A spago project uses two files packages.dhall (defines package-set) and spago.dhall (project dependencies) for CI all exercises are built and tested using the same package set so that we can share the spago package cache (.spago) and build artifacts (output).
We gain some additional flexibility in that spago.dhall can now vary per exercise. This is nice because we can whittle down the exercise dependencies to the bare minimum and we save students some disk space. Also PureScript 0.14.x has started warning about unused dependencies... a topic for when we tackle porting the exercises to 0.14.x.
Work on updating the related documentation will follow in another PR as there is now quite some overlap with the official Exercism documentation and I'd like things to settle a bit a bit before tackling the docs. I expect there to be more changes as we migrate to PureScript 0.14.x especially in how we deal with dependencies.
Let me know if you have any questions. ;)

As mentioned before the test-runner also needs to support spago and there is a PR here (https://github.com/exercism/purescript-test-runner/pull/8). The test-runner pre-compiles the package dependencies and I've come back and taken a similar approach here.
For those following along this is a simpler approach than my previous PR and I'm happy to be using a shell script over nodejs. ;)

I'll let @aimorris look into this, but it looks good to me!

Want me to squash or rebase @emiel?

Thanks for reviewing @ErikSchierboom and @aimorris! Please go ahead and rebase because I believe the commits are easy enough to follow.  Thanks a lot


Fix issue with parallel use of a gcm_ctx

Current design does not support parallel encryption/decryption of the
same gcm_ctx.
Issue can be emulated with one thread with the following test:
// precompute key
aesni_gcm128_pre_xxx(vector->K, &gdata);
// start encryption of a first message
aesni_gcm128_init_xxx(&gdata, ...)
// encrypt first message
aesni_gcm128_enc_update_xxx(&gdata, ...)
// start encryption of a second message
aesni_gcm128_init_xxx(&gdata, ...)
// finalize encryption of the first message
aesni_gcm128_enc_finalize_xxx(&gdata, ...)
// encrypt second message
aesni_gcm128_enc_update_xxx(&gdata, ...)
// finalize encryption of the second message
aesni_gcm128_enc_finalize_xxx(&gdata, ...)
In this case encryption results for both messages are wrong as
information relative to the encryption are in the gdata variable.
To allow encryption with this configuration the gcm_ctx must be split in
two:

First part contains only the precomputed key (expanded_keys and
shifted_hkey_xx)
Second part contains information to the ongoing encryption/decryption
(aad_hash, aad_length, in_length, partial_block_enc_key,
partial_block_length, orig_IV and current_counter)

The first part is initialized by the aesni_gcm128_pre_xxx function and
use later without any modification.
The second part is initialized by the aesni_gcm128_init_xxx function
and must be provided too the following aesni_gcm128_enc_update_xxx and
aesni_gcm128_enc_finalize_xxx functions.
Way to manage this second part is under the responsability of the caller
of the library.
With this fix the sequence described in the test becomes:
// precompute key
aesni_gcm128_pre_xxx(vector->K, &gdata);
// start encryption of a first message
aesni_gcm128_init_xxx(&gdata, &int_data1, ...)
// encrypt first message
aesni_gcm128_enc_update_xxx(&gdata, &int_data1, ...)
// start encryption of a second message
aesni_gcm128_init_xxx(&gdata, &int_data2, ...)
// finalize encryption of the first message
aesni_gcm128_enc_finalize_xxx(&gdata, &int_data1, ...)
// encrypt second message
aesni_gcm128_enc_update_xxx(&gdata, &int_data2, ...)
// finalize encryption of the second message
aesni_gcm128_enc_finalize_xxx(&gdata, &int_data2, ...)
This change provides correct encryption/decryption results for both
messages.
Performance result with perf tool provides by the latest version of the
intel multibuffer library (https://github.com/01org/intel-ipsec-mb) do
not show any significant differences

I reckon this patch is also addressing #7.
The issue would be observed if multiple threads were to encrypt or decrypt using the same gcm_data struct. As your patch suggests, each thread needs its own context.

Thanks for the patch! As sgmonroy pointed this is already subject of open issue.
I like the approach taken in this patch. I was also considering another option that wouldn't break applications using current API. Let me put more context into the issue thread https://github.com/01org/intel-ipsec-mb/issues/7

Thanks for the patch. This issue has been addressed in https://github.com/01org/intel-ipsec-mb/commit/46a9d9e4e116f7f183ac1458f920441a6dc28a4e


Support dispatching to new adapter model Handlers

This PR allows new adapter model Handlers to be called by the existing adapterManager dispatch code. It accomplishes this by abstracting over aspect creation (the new aspect.CreateAspectFunc type), and in adapterManager/manager.go checking whether the resolved config references either a builder (old style) or a handler (new style). It then constructs a CreateAspectFunc from the builder or handler.
In order to test the new behavior, I needed an adapter.Builder instance implementing many Aspect interfaces; as a result the adapter/noop.Builder struct is now public. Due to changing our core Aspect interfaces I wound up having to touch a lot of files; most of the changes are not significant.

This change is

And yet again we have failing linters due to things that didn't change in this PR. I'll send another PR fixing the issues.

Jenkins job mixer/presubmit passed

jenkins run mixer/e2e-smoketest

Tests passed but Jenkins failed. Running again.

Jenkins job mixer/presubmit passed

jenkins run mixer/e2e-smoketest

Jenkins job mixer/presubmit passed

Jenkins job mixer/presubmit passed

@ZackButcher I think this PR is set to go in (approved and pass all tests).

There has not yet been a passing jenkins run of mixer/e2e-smoketest, even though on multiple runs all tests in that suite have passed.

Jenkins job mixer/presubmit passed

Jenkins job mixer/pilot-regression passed


General: Replace db log with spdlog

Current log is in a database. Replace with spdlog so the software is consistent with other VSCP tools

Fixed


[JENKINS-45067] - Prevent NPE in PipelineTriggersJobProperty#startTriggers() when owner is not assigned

When somebody creates a property in API and occasionally triggers the startTriggers() method, Trigger#start(owner, bool) gets invoked with null argument, which violates the contract and causes NPE. I think this NPE should be prevented, because such RunTime exception is not documented in the class Javadoc, and hence it may cause issues in the API user code.
https://issues.jenkins-ci.org/browse/JENKINS-45067
@reviewbybees @abayer @jglick

This pull request originates from a CloudBees employee. At CloudBees, we require that all pull requests be reviewed by other CloudBees employees before we seek to have the change accepted. If you want to learn more about our process please see this explanation.

I would rather start with fixing up #41, which might solve the issue (as well as unblocking #42). Probably needs me or @abayer to do a deep-dive.

Yes, from the JENKINS-42446 PoV it is rather a hack. Though it still can be considered as a valid fix for the public API

Jesse suggests we put this fix on hold.

@jglick

Being defensive is fine, but ought to log a real warning.

So what would be your proposal? IMHO I have put a real warning for the case with null warning

@reviewbybees @abayer @svanoort @jglick Does it make sense to keep it open? The underlying issue has been fixed, and IIUC @jglick disagrees with the defensive code proposed here. I can finalize it if there is interest from the current plugin maintainers, but otherwise I would just close it.

1 vote for, 1 vote against... what do we do here, tie-breakers?

I suppose we summon @abayer and @jenkinsci/code-reviewers

@svanoort so I leave the decision to you.

@oleg-nenashev
It's been a while and Sam obviously didn't marshal this forward.  It is your call if you want to close or update this.

@bitwiseman throwing an informative exception would be a step forward anyway. Better than NPE

Unclear what the root cause is here, or whether the problem still occurs, and the PR does not really assist in diagnosis.


Adding code fix for SA1308

Fix for issue #319

Thanks :+1:
I made a few (mostly) insignificant tweaks to this during the merge, which I'll indicate on the diff.


using this library to detect arabic dialects

I am very happy to find this tool
i have a question
can this library help me in detecting arabic dialects (syrian iraqi gulf)
i will try to build corpora for each dialect and add it to language profile
is that right?

This is a very interesting idea. Is the spelling of words different from one Arabic dialect to another?

yes of course

I think the idea is sound and that it's worth trying. I don't think you would need to make any changes to this library in order to try it.
If you run into any trouble generating profiles from your corpora, feel free to post here and I'll be glad to help.

Sorry but i am new to java ,
how to run the code to detect some text
is it mandatory to have maven project
or can i add jar file to library ?

Yes, you can use it with a jar file--I find that to be the most convenient. There's sample code here, and here starting at line 16.

Hi how are you
thank you for helping  me
please  how to generate profile  for my data?

The easiest way is to use the jar from shuyo's repository. Here's an example of generating an Egyptian Arabic profile from its Wikipedia abstract, using Linux:
git clone git@github.com:shuyo/language-detection.git
cd language-detection
mkdir abstracts
cd abstracts
wget https://dumps.wikimedia.org/arzwiki/20160407/arzwiki-20160407-abstract.xml
mkdir profiles
java -jar ../lib/langdetect.jar --genprofile -d . arz

Run this process to make sure it works. Then replace the abstract text file with your dialect corpus and run the last step again.

@odaymard Any progress on this?

I am using facebook api and twitterapi to get data but facebook4j  is slow I am trying to make it faster

Hi
I have finished syrian profile
how to upload it

Nice! You need to (1) fork this project, (2) add your new profile to your fork, and (3) create a pull request to this project.

I did that, what next?

Nice work, thanks Oday and Robert.
I believe that we should include Arabic dialect profiles in the library, and start some separation in profile loading. I suspect that most users who want "all" languages just want one Arabic profile, one Norwegian, one English, one German, not dialects. Dialects is special purpose.

Hi @odaymard , @rmtheis , @fabiankessler ,
I have started using the library and it's really helpful, but I might have to add new language profile, could  you please help me from where I can get the language corpora and what are all steps involved to generate language profile from language corpora? once I have new language profile how to add the same in profile folder?

Hi @dansupiriti ,
first of all getting corpora depends on what language you want to add
i advice you to use graphapi to get corpora from facebook group and also
using twitter api is usefull
after getting corpora you have to generate language profile   and test it
on your language
good luck
On Mon, Mar 13, 2017 at 4:49 AM, dansupriti<EMAIL_ADDRESS>wrote:

Hi @odaymard https://github.com/odaymard , @rmtheis
https://github.com/rmtheis , @fabiankessler
https://github.com/fabiankessler ,
I have started using the library and it's really helpful, but I might have
to add new language profile, could you please help me from where I can get
the language corpora and what are all steps involved to generate language
profile from language corpora? once I have new language profile how to add
the same in profile folder?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/optimaize/language-detector/issues/46#issuecomment-286003642,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AP0vHBWBzu4jA7TSZ91ne-GMs2ncKRUDks5rlK6-gaJpZM4IJBB1
.

Hi @odaymard ,
Thanks for the suggestion. Now I am able to add new language profile as per my requirement.
Regards,
Supriti

happy to help
On 1 Apr 2017 01:11, "dansupriti"<EMAIL_ADDRESS>wrote:

Hi @odaymard https://github.com/odaymard ,
Thanks for the suggestion. Now I am able to add new language profile as
per my requirement.
Regards,
Supriti
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/optimaize/language-detector/issues/46#issuecomment-290844035,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AP0vHEuDG29dfloVS5oYO_WISUVHchjTks5rrXoIgaJpZM4IJBB1
.

Hi  @odaymard , @rmtheis,
I have Arabic dataset and want to check the dialects of it, (Egypt, the Levant, Iraq and the Gulf), how I can use this lib to do that.
Thanks in advance
safaa

@odaymard Are you willing to publish the other Arabic dialect profiles that you've generated? Apart from the interest of others here, I would like to make a basic free Android app with the profiles you've made. It would be a simple, free app that allows a user to paste in Arabic text and get a dialect estimate based on this library.
@safaahenno I think only the Syrian profile is available as of right now.

@safaahenno You should open a separate issue for that. This issue pertains to Arabic dialects only.


Row and column validation different result handler table?

When I run a validation and write it to a CSV, schema and column validations have different column names.  Does this mean that I have to deploy different BQ tables to hold the results for schema and column?

No, they both will can write to the same table. The results that are shown with the standard out text handler are summarized outputs with only the columns that are most important to that validation type.
The table in BigQuery will have the most data on the validations and can be written to for row, schema, and column validations.


cf-v261 dea push app custom port issue

E:\IAAS\centos7-openstack-newton\PivotalMySQLWeb>cf map-route pivotal-mysqlweb p
eracloud.com --random-port
fail
The app is running on the DEA backend, which does not support this command.

Hi @bxlkm. The DEAs have been deprecated for some time, and we officially ended support for the DEAs back in May. The first thing you'll need to do is deploy Diego and move your app to the Diego backend. There are instructions in that repo for how to deploy it.

Hi @bxlkm. I'm going to close this issue due to inactivity. Let's use your other Github issue to discuss deploying Diego.


[PKG]mbedtls

Package name
mbedtls
Package URL
https://tls.mbed.org/
Package source location
https://github.com/ARMmbed/mbedtls

@cmzy  In the meantime there is feature that was created microsoft/vcpkg#10271. You can build the archive yourself. Its easy
export ANDROID_NDK_HOME="/Library/Android/sdk/ndk/<version>"
./vcpkg install mbedtls  --triplet x86-android
./vcpkg install mbedtls  --triplet x64-android
./vcpkg install mbedtls  --triplet arm-android
./vcpkg install mbedtls  --triplet arm64-android
./vcpkg export mbedtls  --triplet x86-android --prefab

In app/build.gradle
com.vcpkg.ndk.support:mbedtls:2.16.3

And cmake flags
externalNativeBuild {
                cmake {
                    arguments '-DANDROID_STL=c++_static'
                    cppFlags "-std=c++17"
                }
}

In gradle.properties
android.enablePrefab=true
android.enableParallelJsonGen=false
android.prefabVersion=${prefab.version}

The vcpkg export as aar had broken for at least half a year.
This package had been publish to my maven repository hosted on github https://github.com/leleliu008/ndk-pkg-prefab-aar-maven-repo
You’re welcome to give it a try.


User password policies

Will this password policy propagate to AAD DS joined VMs?
https://docs.microsoft.com/en-us/azure/active-directory/authentication/concept-sspr-policy#set-a-password-to-never-expire

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 2eb4c941-c464-75cb-7a98-39c3a58be1b5
Version Independent ID: e93b1a8f-3de2-309e-5a0b-923e2fa15e0b
Content: Create and use password policies in Azure AD Domain Services
Content Source: articles/active-directory-domain-services/password-policy.md
Service: active-directory
Sub-service: domain-services
GitHub Login: @iainfoulds
Microsoft Alias: iainfou

@eschrader Thank you for your feedback . We will investigate and update the thread.

@eschrader
All users, regardless of how they're created, have Maximum password age of 90 days as default password policy in Azure AD DS.
However, you can create Custom Password Policy, where you can set the password expiration time but for users manually created in a managed domain.
You can refer to this document for more details: https://docs.microsoft.com/en-us/azure/active-directory-domain-services/password-policy
We will be closing this thread now. Let us know if you need further help.


Do no parametrize the BSD license

Description
In https://github.com/audreyr/cookiecutter-pypackage/blob/cbcdd19a64aaa0c5bcbcc723c75628f44b13f525/{{cookiecutter.project_slug}}/LICENSE#L27 the project name is added to a BSD license template.
I maintain https://github.com/nexB/scancode-toolkit that does detect licenses and creating multiple variants of the BSD is not a great idea for detection nor for helping downstream users.
Instead I suggest using the working of the SPDX licenses list  and not inject any name in the license templates (disclaimer I am a cofounder of SPDX)
http://spdx.org/licenses/BSD-3-Clause.html

Makes sense, sending a PR

@eliasdorneles thank you for #228 ... may a quick unit test would be make sense too?

So, we already have tests for generating licenses, I don't think it requires more than what we have (we don't need to test the whole license contents).
I'm merging the PR to move this forward.
Thanks @pombredanne !

@eliasdorneles Thanks!


Null out references

This got a bit more complicated.  Feeling much less sure about it with the needed action wrapper
Difficult to recognize props that are managed and observable (they are rare).  Could do some more research to create the actions selectively, or skip nulling out these.
Hoist P/R Checklist
Pull request authors: Review and check off the below. Items that do not apply can also be
checked off to indicate they have been considered. If unclear if a step is relevant, please leave
unchecked and note in comments.

[ ] Caught up with develop branch as of last change.
[ ] Added CHANGELOG entry, or determined not required.
[ ] Reviewed for breaking changes, added breaking-change label + CHANGELOG if so.
[ ] Updated doc comments / prop-types, or determined not required.
[ ] Reviewed and tested on Mobile, or determined not required.
[ ] Created Toolbox branch / PR, or determined not required.

If your change is still a WIP, please use the "Create draft pull request" option in the split
button below to indicate it is not ready yet for a final review.

Pull request reviewers: when merging this P/R, please consider using a squash commit to
collapse multiple intermediate commits into a single commit representing the overall feature
change. This helps keep the commit log clean and easy to scan across releases. PRs containing a
single commit should be rebased when possible.

I would agree that the need for the run in action wrapper makes the entire thing less appealing - happy to leave it alone for the moment and simply keep it in mind whenever we're looking at memory usage to see if we can find an instance of retained properties in the wild where this would help.  It was a theoretical concern at the moment, for sure....


Finding References (right-click) doesn't work.

VSCode Version: Code 1.15.0 (8b95971d8cccd3afd86b35d4a0e098c189294ff2, 2017-08-09T20:16:18.034Z)
OS Version: Windows_NT x64 10.0.15063
Extensions:

Extension
Author (truncated)
Version

vscode-eslint
dba
1.2.11

vscode-html-css
ecm
0.1.7

vsc-material-theme
Equ
1.0.2

php-intellisense
fel
1.5.0

auto-close-tag
for
0.4.3

auto-complete-tag
for
0.0.2

auto-rename-tag
for
0.0.14

vscode-JS-CSS-HTML-formatter
lon
0.2.3

sublime-keybindings
ms-
2.9.1

html-css-class-completion
Zig
1.8.0

Steps to Reproduce:

Just try Find References on PHP, it doesnt work, i tried in 2 projects now, one at work, one at home for a side project of mine
Note: Also javascript finding references doesn't work.

Its the only thing stopping me from using it

Reproduces without extensions: Yes/No

The built-in PHP support does not support find references. You have to file that issue against the PHP extension that you use (php-intellisense).
For JavaScipt, please create a separate issue with sample code.


CDNJS outdated version

Hi, would it be possible to update latest version on CDNJS, current version is 6.0.2 but on CDNJS there is 6.0.0.
Thanks for reply

We have tried, but they don't like how we version our files, so we have to figure out how to support them.

For reference this is the feature we have to support (for all of CreateJS): https://github.com/cdnjs/cdnjs/issues/3638


Give credits based on project roles

Looks good now. There's an empty merge commit. I'll try to make it disappear.

Made the empty commit go away, but now it gives co-authorship to your changes. I'll just combine our changes to reduce churn.

OK to merge now.


antum_to_baseline bug?

antnums_to_baseline doesn't enforce i < j -- should it?

No, it shouldn't.  AIPY does this and it should not be used to calculate baseline numbers for pyuvdata.


Treat initial and subsequent resync events identically for node ip

Description
Refactor parsing the KDD node syncer event so that common code between a new sync and an update sync event are treated the same. Prior to this fix the new sync event path sent incorrectly formatted node event to clients (e.g. felix).
See https://github.com/projectcalico/libcalico-go/issues/485 for details.
Note: a unit test is in the works.
Todos

[x] Tests - manually tested the scenario outlined in the bug, and also confirmed that a hand run of a unit test also sees the correct syncer behavior.
[ ] Release note

Release Note

None required

OK LGTM - test's in a separate PR as discussed.