Squashing two commits should not depend on the base ref

Squashing two consecutive commits is always technically possible (there is no chance of a merge conflict), but GitSavvy will not do it if the base ref for the rebase indicates a merge conflict.
Similarly, squashing non-consecutive commits (let's call them A and B) should not depend on the base ref in the rebase screen (it should only depend on the commits starting after A and leading up to B).
ps I love GitSavvy

Currently, any commit manipulation operations check whether the current branch is rebased or not to the base ref (imagine dev is rebased on master).  It would not be necessary if say, we only want to squash BandC. The merge base of squashing BandCisB, it should only check if devis a descendent ofB`. The check code should move to 2.
* dev
|
* C
|
* B
|
| * master
| |
| * A
|/
|
* M

Though I assign this to myself but I don't guarantee a prompt devliver time.

I tried out rebasing with the new version today, and the problem persists. If I have the commits described below, then it should always be possible to squash E (the current HEAD) into C. The reason is that for this particular squash operation, if suffices to consider only the commits C, D and E (commits A and B are completely irrelevant). Since commit D does not touch 1.txt, the squash of the two commits touching 1.txt is guaranteed to work, but unfortunately, GitSavvy doesn't allow it.
A
B
C (changes 1.txt)
D (changes 2.txt)
E (changes 1.txt)

I do expect it should work in the most recent release. (Though I am on a mobile and cannot test it now)

Hi Randy,
I tried checking my local version and the package-metadata.json in my GitSavvy.sublime-package file says version 2.14.2.
To summarize: after GitSavvy refused to squash the commits, I rebased on the command line using "git rebase --interactive ", I moved commit E up one position, and marked it as "squash". How is that different from what GitSavvy tries to do? Would it be possible to just let GitSavvy try the squash, and abort the rebase if it failed? (instead of trying to predict in advance whether the rebase is possible)

What is the error message when it failed to squash?

Would it be possible to just let GitSavvy try the squash, and abort the rebase if it failed? (instead of trying to predict in advance whether the rebase is possible)

This is the current behavior.

What is the error message when it failed to squash?
I will let you know the next time I see it :-).

I personally love the way git rebase -i work so I wonder if we should add this custom command to the default installation.
    {
        "caption": "git: rebase interactive (rebase -i)",
        "command": "gs_custom",
        "args": {
            "args": ["rebase", "-i", "{PROMPT_ARG}"],
            "prompt_msg": "Rebase from",
            "start_msg": "Starting rebase interactive...",
            "complete_msg": "Rebase interactive started",
            "custom_environ": {
                "EDITOR": "/usr/local/bin/subl -nw"
            },
        }
    },

I am only using this one.
When using it you will need to return to the command line if it fails. You will need to run 'git rebase --continue'
demo:

@mnieber
I just test on my computer locally. It works as expected.
Try checking out the subfeature branch of https://github.com/randy3k/RebaseTest
and rebase G2 to G.

@stoivo, unfortunately, rebase -i doesn't preserve merge.  Though there is an option -p to preserve merge in rebase command, it is not recommended to be used with the -i flag.

This uses the --interactive machinery internally, but combining it with the --interactive option explicitly is generally not a good idea unless you know what you are doing (see BUGS below).

source: https://git-scm.com/docs/git-rebase

@randy3k I just got the error again when trying to squash the last two commits in my  branch (which in theory should always work), it says: "Unable to manipulate commits while repo is in unclean state".
I don't think my repo is in an unclean state, since I only have a few untracked files. The output of git status is:
On branch master
Your branch is ahead of 'origin/master' by 8 commits.
(use "git push" to publish your local commits)
Untracked files:
(use "git add ..." to include in what will be committed)
django/.cache/
django/db.sqlite3

nothing added to commit but untracked files present (use "git add" to track)

Having untracked files is consider being unclean in the moment.
#644 is an attempt to fix it.

@randy3k
The problem also occurs when there are no untracked files.
I still don't understand why GitSavvy doesn't follow the workflow that I do manually, which is:

start an interactive rebase
move the commit to it's new location, and mark it as "fixup"
exit the interactive rebase
if git tells me that the rebase fails, execute git rebase --abort

If this workflow would be executed automatically when the "[Q] squash commit with ..." command is run, then I would not have to do this operation manually 50% of the time. I don't want to sound like I am complaining, I love GitSavvy, and I would love to use it also for squashing commits (I'm talking about the cases where squashing the commit manually produces no conflicts, which suggests that an automatic procedure should also have no problems)

That is unexpected. Do you have any more details about the git status. Btw, did you also try git: fix up from stage

It would be great if you can open a new issue and give more details about your issue as this thread is considered fixed.

The status is nothing to commit, working directory clean.
I just made an interesting observation. First, I found that I could not drop the last commit in my branch (using [p] drop commit). Then, I changed the rebase ref using [f] define base ref for dashboard to be the predecessor of the last commit. Now, I could drop the last commit. So it does seem that an operation which should always succeed may fail in practice depending on the rebase base ref.

That is again unexpected. What error do you get?

Next time it happens again, I will open a new thread, and post the error :-)


Unwanted text on general form page

I was browsing for templates and realized you have "<<<<<<< HEAD ======= >>>>>>> refs/remotes/puikinsh/Development" on the top.
Here's the screenshot just in case.

Hi... This has been solved
Duplicate of #435
Duplicate of #543
Duplicate of #552
Duplicate of #557
@AndreiCN you can close this please, and should be added an issue template that had a message "If the issue is about the text on general form... this has been fixed don't worry, but thanks :)"


Automation GetContent functions wrongly use ByUnmarshallingJSON

Bug Report

import path of package - .../services/automation/mgmt/2015-10-31/automation
SDK version - 18.0.0
output of go version - go version go1.10.3 windows/amd6

What happened?
Trying to make use of GetContent from dscconfiguration. The api call will return just a string and not a json body. GetContentResponder however is trying to Unmarshal a json object resulting in an error.

automation.DscConfigurationClient#GetContent: Failure responding to request: StatusCode=200 -- Original Error: Error occurred unmarshalling JSON - Error = 'invalid character 'c'
looking for beginning of value' JSON = 'configuration bla {}'

What did you expect or want to happen?
Just return the string, do not attempt to unmarshal as it is not a json object that is returned

How can we reproduce it?
Call the GetContent function.

I believe this is a problem with the swagger as the return type specified is string, needs confirmation.

Investigating, it might be an issue with the generator. If so will have a fix in the next sdk release.

@bgelens out of curiosity are you receiving any content type header ?

@vladbarosan I get text/powershell as content type

Just fyi, with runbookdraft and runbook there is no unmarshaling happening. The content type there is text/powershell as well.

This has been fixed in https://github.com/Azure/azure-sdk-for-go/releases/tag/v20.0.0

Awesome! Thanks 👍


Electron crash caused by integration test on Windows

Crash reported from https://dev.azure.com/vscode/a4cdce18-a05c-4bb8-9476-5d07e63bfd76/_build/results?buildId=46280 and I followed https://github.com/microsoft/vscode/wiki/Native-Crash-Issues#creating-and-symbolicating-local-crash-reports to generate the stack
1_symbolicated_stack.txt
2_symbolicated_stack.txt

The second trace is the same as https://github.com/microsoft/vscode/issues/99408
The first one is new, out-of-bounds exception from std::vector. I think its a one time issue, lets see if that happens again.

@deepak1556 in https://dev.azure.com/vscode/VSCode/_build/results?buildId=46492&view=logs&j=2d2b3007-3c5c-5840-9bb0-2b1ea49925f3&t=d494b5db-eef8-5766-984e-01186010c86f I see another crash, not sure you are aware. It is on Windows and has a dump attached.
Doing the symbolification:
crash1.txt
crash2.txt
Seems to be webview related:
 0  Code - OSS.exe!content::WebContentsImpl::AttachInnerWebContents(std::unique_ptr<content::WebContents,std::default_delete<content::WebContents> >,content::RenderFrameHost *) [web_contents_impl.cc : 1883 + 0x0]

And on macOS too it seems:
crash-macos.txt

@bpasero yup they are both https://github.com/microsoft/vscode/issues/99408 , crash always seems to happen under notebook API tests, would be great to narrow down the problematic test.

After stress testing the notebook by opening/closing notebook 200 times, I found that he webview crashed in two reasons.
The first one is we try to update the content of the webview when the webview is being disposed. This usually happens when we close a dirty file and then two async tasks run in unpredictable sequence: reverting the document (which triggers rerendering of the webview) and closing the editor (which disposes all event listeners and webview). The root cause is we can't dispose/stop a promise chain. Tried my best to fix this set of problems by eagerly checking if a notebook/webview is being closed while handling all kinds of promises/events. It avoided quite a ton of crashes. ✅
The second one is, well, I can't explain. It happens often when removing a webview element from the DOM tree. A typical code path before the process crashes is

Notebook Editor close
NotebookEditorWidget#dispose
BackLayerWebView#dispose
BaseWebview#dispose

remove electron webview element from DOM tree

https://github.com/microsoft/vscode/blob/cd3a3ea6faa9d83dae1b706cfe1aaa2dbcaf3411/src/vs/workbench/contrib/webview/browser/baseWebviewElement.ts#L167
I kind of have a stable reproduce which

open notebook A
save, close it
open notebook B
save, close it
repeat 200 times

and it then will crash after waiting for a while. Users usually don't notice this as they don't open/close notebooks like this but we have 25 integration tests which open/close notebooks around 50 times within a short time, thus it often crashes the process and abort the integration tests. @deepak1556 let's meet next week and look into this together.

We are no longer affected by this due to iframe transition on desktop.


[GEARPUMP-366] Create JarStore dir if not exists on job submit

Be sure to do all of the following to help us incorporate your contribution
quickly and easily:

[x] Make sure the commit message is formatted like:
[GEARPUMP-<Jira issue #>] Meaningful description of pull request
[ ] Make sure tests pass via sbt clean test.
[ ] Make sure old documentation affected by the pull request has been updated and new documentation added for new functionality.

@huafengw

Codecov Report

Merging #239 into master will increase coverage by 1.76%.
The diff coverage is 44.44%.

@@            Coverage Diff             @@
##           master     #239      +/-   ##
==========================================
+ Coverage    69.1%   70.87%   +1.76%
==========================================
  Files         191      191
  Lines        6124     6128       +4
  Branches      539      542       +3
==========================================
+ Hits         4232     4343     +111
+ Misses       1892     1785     -107

+1


Ansible supported version should be moved up to 2.8

As this project is related to security.  I vote that we maintain this at or above the oldest maintained release.  Which is currently 2.8

Ansible Release
Status

devel
In development (2.11 unreleased, trunk)

2.10 Release Notes
In development (2.10 alpha/beta)

2.9 Release Notes
Maintained (security and general bug fixes)

2.8 Release Notes
Maintained (security fixes)

2.7 Release Notes
Unmaintained (end of life)

2.6 Release Notes
Unmaintained (end of life)

2.5 Release Notes
Unmaintained (end of life)

<2.5
Unmaintained (end of life)

Hello,
I wanted to reach out and let you know that this issue is being closed. We have re-worked the role and want to start with a fresh issues list with this latest version. There was a post in the Ansible-Lockdown google group (https://groups.google.com/g/ansible-lockdown) with the details of the changes that are coming. Please checkout the thread titled RHEL 7 CIS and STIG Changes for all of the details, I also have the message pasted at below.
Please as you use the latest version and open issue tickets as you find them, it is the best way for us to improve the role for everyone. Thank you for being part of the community and providing awareness of problems or advice on improvement. Reporting is a huge part of improving this project.

Hello,
Thank you to everyone in the Ansible-Lockdown community who has contributed to RHEL7 STIG/CIS. Our team at MindPoint Group has been working with the entirety of the Ansible-Lockdown project, and we have some significant updates for both RHEL 7 STIG and CIS. With these updates, some larger changes have been made. I have these changes/updates outlined below.
Testing:

CI/CD - We have implemented some automated testing pipelines to test pull requests into the devel and main branches. With the current workflow, the community will PR into the devel branch (never the main branch) for review by the administrators. When your PR is created, the first check will remain the DCO check. The second check is a functional testing pipeline that will automatically perform a functional test of the branch the PR is initiated from. Once both tests pass, someone from the Administrator Team will review the changes and merge them into the devel branch. From there, an additional review is completed before the devel branch is merged into the main branch. Only the Admin Team will perform PRs/merges into the main branch. There is also an automated pipeline for PRs from devel to main. Please do not edit the .github/workflows files since those are used as part of the pipeline.
Compliance Checking – MindPoint Group has been working to create our own compliance audit scan tool. The tool uses a goss framework executable to run custom checks that we have created. The goal is to provide a more thorough check for control compliance and decrease the number of false positives/negatives. For example, it will check the configuration file related to the control and as well as checking if that configuration is active. With a smarter scan, we can hopefully identify attempts to trick scanners as well (for example stacking a parameter in a config file where the first instance is enabled and second disabled. Most audit tools search for the first instance but the application might look for the last instance of the parameter, thus making the scanning tool think it's enabled). In testing, we have found that our audit scan runs significantly faster than other audit tools, reducing audit times. Our audit tool and profiles will have their own repositories in the Ansible-Lockdown org, but within the remediation role there will be an integrated way to incorporate the audit. Keep an eye out for the audit tools as they are released. We plan on developing a goss audit profile for each current remediation role. Going forward, we plan to release a remediation role and goss audit tool profile simultaneously.
Role Updates:
RHEL 7 STIG/CIS – We have re-written much of the RHEL 7 STIG and CIS roles to increase clarity and readability and address some functionality items. We performed these updates while creating our goss testing framework for each of these roles. We plan on pushing our update to the devel and main branches. We will move the current devel and master branches to a devel_stable_ and master_stable_ branch in the respective repositories. Accordingly, community members who rely on the current version can still use that version going forward; this process will not remove what is currently there. The latest versions of the roles have also been updated to comply with the latest benchmarks.
Role Architecture – All roles will change with regard to the structure in the tasks folder. Taking CIS as an example, there will be a folder per section and yaml files for each sub-section. For example control 1.2.1 in CIS will be located in RHEL7-CIS/tasks/section_1/cis_1.2.x.yml. The cis_1.2.x.yml file will contain all controls related to section 1.2.x. This will hopefully make updates to roles a bit easier with less risk. This matches the architecture of our audit tool, creating consistency across remediation and audit platforms. The end goal is to repeat this architecture (the best we can) on STIG roles, but we are starting with CIS.
Existing PRs and Issues – With all of these changes comes the task of cleaning up existing PR’s and issues. Our plan is to close all of the existing PR’s and issues because of the re-work. Our team is growing and should be able to stay on top of the new issues and PRs as they come in.
Again, I would like to thank the community for your involvement in this project. The input and work from the community has contributed significantly to the success of this project. Please keep an eye out for these changes, which will be rolling out in the coming weeks.


Add NumPy 2 support

This PR updates GeoUtils to support NumPy 2.0.
I am not going to merge it now, as some issues arising seem to come from potentially undesirable NumPy masked-array behaviour.
Summary
The issue is the new casting rules for scalars with arrays, especially for integers, see here: https://numpy.org/devdocs/numpy_2_0_migration_guide.html#changes-to-numpy-data-type-promotion and https://numpy.org/neps/nep-0050-scalar-promotion.html#nep50 for details.
The above rules make sense, but don't seem to behave the same for masked array. Somehow, we cannot easily cast an integer with a masked array of lower integer-type anymore:
For instance:
test = np.array([1, 2], dtype="uint8")
test += 5

runs fine.
But:
test = np.ma.masked_array([1, 2], dtype="uint8")
test += 5

yields:
  File "/home/atom/miniconda3/envs/geoutils-dev/lib/python3.11/site-packages/numpy/ma/core.py", line 4422, in __iadd__
    self._data.__iadd__(other_data)
numpy._core._exceptions._UFuncOutputCastingError: Cannot cast ufunc 'add' output from dtype('int64') to dtype('uint8') with casting rule 'same_kind'

Additionally
With the new scalar casting behaviour, we might have to relax the current behaviour of Raster.data.setter() expecting the same data type, otherwise this type of command to simply update the array:
rast.data +=1

might fail a lot.
We can dive into this in more details once the above exception is clarified.
Steps forward
I will open an issue on NumPy's GitHub after triple-checking if this is intended behaviour, but I don't think so.

Update: Opened issue https://github.com/numpy/numpy/issues/27679

Confirmation this is a bug from NumPy, we'll have to wait until it is fixed there to update to 2.0. Will likely take a while!


fix(login): url safe encoding base64

Definition of Ready

[ ] I am happy with the code
[ ] Short description of the feature/issue is added in the pr description
[ ] PR is linked to the corresponding user story
[ ] Acceptance criteria are met
[ ] All open todos and follow ups are defined in a new ticket and justified
[ ] Deviations from the acceptance criteria and design are agreed with the PO and documented.
[ ] No debug or dead code
[ ] My code has no repetitions
[ ] Critical parts are tested automatically
[ ] Where possible E2E tests are implemented
[ ] Documentation/examples are up-to-date
[ ] All non-functional requirements are met
[ ] Functionality of the acceptance criteria is checked manually on the dev system.

is scripts/base64.js still in use somewhere or can it be deleted?

It can.. its not longer in use now 👍


not enough training data available to train, classification in branch will terminate at node

when training, errors as follow:
_train_local_classifier() - not enough training data available to train, classification in branch will terminate at node -1
_train_local_classifier() - not enough training data available to train, classification in branch will terminate at node
recursive_predict
clf = self.graph.node[root][CLASSIFIER]
KeyError: 'classifier'

Can you please follow this issue template? In particular, the steps/code to reproduce this issue will be useful.

closing as not informative or actionable - if this bug was similar to #31 please try again with release 1.3.0 as I've addressed that issue in #32 . Otherwise please re-open with more verbose information and example of how to reproduce, similar to #31 format (thanks @hacktuarial !)


Maze map editor not working

When clicking on the Maze Maps overview, following message appears in the console:
[2017-07-13 14:50:20.710] [ERROR] main - { Error: Not Found     at /var/www/html/rcj-rescue-scoring/app.js:141:13     at Layer.handle [as handle_request] (/var/www/html/rcj-rescue-scoring/node_modules/express/lib/router/layer.js:82:5)     at trim_prefix (/var/www/html/rcj-rescue-scoring/node_modules/express/lib/router/index.js:269:13)     at /var/www/html/rcj-rescue-scoring/node_modules/express/lib/router/index.js:236:9     at Function.proto.process_params (/var/www/html/rcj-rescue-scoring/node_modules/express/lib/router/index.js:311:12)     at /var/www/html/rcj-rescue-scoring/node_modules/express/lib/router/index.js:227:12     at Function.match_layer (/var/www/html/rcj-rescue-scoring/node_modules/express/lib/router/index.js:294:3)     at next (/var/www/html/rcj-rescue-scoring/node_modules/express/lib/router/index.js:188:10)     at /var/www/html/rcj-rescue-scoring/node_modules/express/lib/router/index.js:190:16     at Function.match_layer (/var/www/html/rcj-rescue-scoring/node_modules/express/lib/router/index.js:294:3)     at next (/var/www/html/rcj-rescue-scoring/node_modules/express/lib/router/index.js:188:10)     at /var/www/html/rcj-rescue-scoring/node_modules/express/lib/router/index.js:190:16     at Function.match_layer (/var/www/html/rcj-rescue-scoring/node_modules/express/lib/router/index.js:294:3)     at next (/var/www/html/rcj-rescue-scoring/node_modules/express/lib/router/index.js:188:10)     at /var/www/html/rcj-rescue-scoring/node_modules/express/lib/router/index.js:190:16     at Function.match_layer (/var/www/html/rcj-rescue-scoring/node_modules/express/lib/router/index.js:294:3) status: 404 } [2017-07-13 14:50:20.856] [ERROR] main - { Error: Not Found     at /var/www/html/rcj-rescue-scoring/app.js:141:13     at Layer.handle [as handle_request] (/var/www/html/rcj-rescue-scoring/node_modules/express/lib/router/layer.js:82:5)     at trim_prefix (/var/www/html/rcj-rescue-scoring/node_modules/express/lib/router/index.js:269:13)     at /var/www/html/rcj-rescue-scoring/node_modules/express/lib/router/index.js:236:9     at Function.proto.process_params (/var/www/html/rcj-rescue-scoring/node_modules/express/lib/router/index.js:311:12)     at /var/www/html/rcj-rescue-scoring/node_modules/express/lib/router/index.js:227:12     at Function.match_layer (/var/www/html/rcj-rescue-scoring/node_modules/express/lib/router/index.js:294:3)     at next (/var/www/html/rcj-rescue-scoring/node_modules/express/lib/router/index.js:188:10)     at /var/www/html/rcj-rescue-scoring/node_modules/express/lib/router/index.js:190:16     at Function.match_layer (/var/www/html/rcj-rescue-scoring/node_modules/express/lib/router/index.js:294:3)     at next (/var/www/html/rcj-rescue-scoring/node_modules/express/lib/router/index.js:188:10)     at /var/www/html/rcj-rescue-scoring/node_modules/express/lib/router/index.js:190:16     at Function.match_layer (/var/www/html/rcj-rescue-scoring/node_modules/express/lib/router/index.js:294:3)     at next (/var/www/html/rcj-rescue-scoring/node_modules/express/lib/router/index.js:188:10)     at /var/www/html/rcj-rescue-scoring/node_modules/express/lib/router/index.js:190:16     at Function.match_layer (/var/www/html/rcj-rescue-scoring/node_modules/express/lib/router/index.js:294:3) status: 404 }
It is possible to open the editor, but in the editor, changing the size does not change the map. Following message is thrown in the JS console in the chrome developer tools:
angular.js:88 Uncaught Error: [$injector:unpr] http://errors.angularjs.org/1.6.5/$injector/unpr?p0=%24%24HashMapProvider%2…eQueue%20%3C-%20%24animate%20%3C-%20%24compile%20%3C-%20%24%24animateQueue     at angular.js:88     at angular.js:4826     at Object.d [as get] (angular.js:4981)     at angular.js:4831     at d (angular.js:4981)     at e (angular.js:5006)     at Object.invoke (angular.js:5032)     at angular.js:4832     at d (angular.js:4981)     at e (angular.js:5006)
Saving the empty map does not actually save it

Fixed in commit #a76ab96


Make Style !Send and !Sync?

Currently, Style is Send and Sync primarily due to it needs to be held in the StyleRegistry which is internally Arc<Mutex<X>>.
However, it prevents Style and the upcoming StyleManager from holding any elements from web-sys which is a trade off that I consider to be big enough.
This issue aims to investigate whether is worth to make StyleRegistry thread local with Rc<RefCell<X>> and Style !Send and !Sync so elements can be held in them.

This is addressed in branch manager.
It does make sense to make Style !Send and !Sync given its underlying <style /> element is currently !Send and !Sync.


DC Node gets deployed with 32 MB RAM

Hi Karsten,
when deploying a DC it gets only 32 MB RAM:

PS C:\MarcelKeil\labbuildr> .\build-lab.ps1 -version
labbuildr version 2017-Asparagus on branch : master
labbuildr Git Release  So, 18 Jun 2017 16:38:35 GMT
vmxtoolkit Git Release Di, 16 Mai 2017 10:45:59 GMT
scripts Git Release  So, 18 Jun 2017 17:34:58 GMT
labtools Git Release  So, 18 Jun 2017 15:20:48 GMT
Kind regards
Marcel

Seems to be due to a failure during a previous deployment.
There was already a folder/VM named DCNODE but finally deployed.


Next button should not be enabled on last page of a given course/book

The last module of SPARK course has a "Next" button to the book on "Ada for the C++ and Java developer". Similarly the last page of the "Introduction to Ada" has a Next button leading to the Introduction to SPARK. This is not desirable.

Fixed in PR #114


[DRAFT] - fix resourceNamespaceFileDelete URL generation

This is not ready, working on QAing it, with local terraform provider. No review yet please

What changes are being made and why?

URL isn't correct so delete action has client HTTP timeout

How the changes have been QAed?

no I need help QAing. I do not know how to QA a custom Terraform project

Setup Instructions

My solution was to just prefix resource filename with "/"
example
filename  = "/salesforce_google_ads_payment_ids.sql"


Containerize CeeBee

To project the chatbot while working with Node on other project.

Nice progress it's mostly working.
Presently the command !attention fail. We need to install the font (or default on a local one)
Fontconfig warning: "/etc/fonts/fonts.conf", line 100: unknown element "blank"
Error: ENOENT: no such file or directory, open './public/medias/generated/2020-11-26-1205_Att-fboucheros.png'
    at Object.openSync (fs.js:476:3)
    at Object.writeFileSync (fs.js:1467:35)
    at createImage (/usr/src/app/index.js:142:8)
    at /usr/src/app/index.js:47:9
    at Layer.handle [as handle_request] (/usr/src/app/node_modules/express/lib/router/layer.js:95:5)
    at next (/usr/src/app/node_modules/express/lib/router/route.js:137:13)
    at Route.dispatch (/usr/src/app/node_modules/express/lib/router/route.js:112:3)
    at Layer.handle [as handle_request] (/usr/src/app/node_modules/express/lib/router/layer.js:95:5)
    at /usr/src/app/node_modules/express/lib/router/index.js:281:22
    at Function.process_params (/usr/src/app/node_modules/express/lib/router/index.js:335:12)


tika-app-1.22.jar Not Found

http://ftp.unicamp.br/pub/apache/tika/tika-app-1.22.jar
Not Found

The requested URL /pub/apache/tika/tika-app-1.22.jar was not found on this server.

Oh my... Let me get another mirror.

@avelino might you close this issue?


New documentation for building and running without docker

…c fixes and additions.

[ ] Breaking change? (if so, please describe the impact and migration path for existing application instances)

What changes did you make? (Give an overview)
I have added new documentation for running without docker, and made some improvements in the existing docs
Is there anything you'd like reviewers to focus on?
Please give me feedback on if I can make the documentation better for running without docker.
How Has This Been Tested? (put an "x" (case-sensitive!) next to an item)

[ ] No need to
[x] Manually (please, describe, if necessary)
[ ] Unit checks
[ ] Integration checks
[ ] Covered by existing automation

Checklist (put an "x" (case-sensitive!) next to all the items, otherwise the build will fail)

[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation (e.g. ENVIRONMENT VARIABLES)
[x] My changes generate no new warnings (e.g. Sonar is happy)
[x] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes
[x] Any dependent changes have been merged

Check out Contributing and Code of Conduct
A picture of a cute animal (not mandatory but encouraged)

Thankieww @Haarolean for helping out so many people in discord, whatever I felt missing in the documentation was covered in the help threads of discord which was created by you, so just making a contribution for individuals who don't have the privileges for using docker in their workplace and would still like to use this beautiful feature rich application for kafka monitoring.


LeftmostXForwardedFor for extracting client IP for requests proxied through Cloudflare

Hello,
Just like RightmostXForwardedFor having equivalent LeftmostXForwardedFor will help extract Client IP from X-Forwarded-For header when request gets proxied through Cloudflare. Specially in situations where CF-Connecting-IP header is not available for requests going though other load balancers.
More about why leftmost is in the doc below:
https://developers.cloudflare.com/fundamentals/reference/http-request-headers/#x-forwarded-for
Thank you

If there are proxies in the chain that we don't control, and we know CloudFlare adds its IP to the right, the trustworthy IP would still be the second one from the right, not the leftmost one: https://adam-p.ca/blog/2022/03/x-forwarded-for/#trying-to-learn-about-x-forwarded-for

Thanks for sharing the link and your response, it does make sense from security perspective, after browsing docs what I'm looking for is already implemented in InsecureIp, hence I'm closing the issue.


Python dependencies missing

Hi @mercuryseries,
Thank you so much for spending the time to put together these example/base repos.
I appreciate that in reality these repos should be used alongside your video where you show step by step working out the dependencies for both django/python and vite/npm/js however it would also be great from a stand alone perspective to include a requirements.txt file for use with pip as that would ensure you could get all dependencies for both django and vite using the respective standards for creating dependency files.

Hi @gtechjsanders,
creating requirements.txt next to package.json with following content should be enough.
Django==4.1.3
inertia-django==0.4.1
django-vite==2.0.2
django-js-routes==0.2.0

See https://github.com/fertek/django-inertia-react for more.

@gtechjsanders @fertek Sorry for the delay in the response.
A requirements.txt file has been added to the repo. Thanks 🎉


Throws error when clicked outside web3modal

When user clicks outside the web3modal, it throws error: Modal closed by user
Is there any way to do nothing when user clicks outside ?

Got the answer. Closing this.
On onHide just make the modal set to true.

how do you do that?

Got the answer. Closing this.
On onHide just make the modal set to true.

How do you do that?


Compatibility with thingsboard.io

I am unable to submit data to mqtt://demo.thingsboard.io.  After calling esp_mqtt_client_publish() I get the following error:
E (24381) MQTT_CLIENT: Read error or end of stream

If submitting to mqtt://iot.eclipse.org everything works as expected. Also tested also with the examples/mqtt_tcp app. Behaviour is the same. Eclipse works while Thingsboard not.  Tested with both 3.1.1 protocol enabled and disabled. MQTT packets when inspected in Wireshark look the same.
Currently running out of ideas. Are there any known issues with Thingsboard or configuration changes I should try?
I (2171) event: sta ip: <IP_ADDRESS>, mask: <IP_ADDRESS>, gw: <IP_ADDRESS>
I (2171) system_api: Base MAC address is not set, read default base MAC address from BLK0 of EFUSE
I (2461) MQTT_CLIENT: Sending MQTT CONNECT message, type: 1, id: 0000
I (2671) MQTT_SAMPLE: MQTT_EVENT_CONNECTED
I (2671) MQTT_SAMPLE: sent subscribe successful, msg_id=28741
I (2671) MQTT_SAMPLE: sent subscribe successful, msg_id=11408
I (2681) MQTT_SAMPLE: sent unsubscribe successful, msg_id=6495
I (2871) MQTT_SAMPLE: MQTT_EVENT_SUBSCRIBED, msg_id=28741
I (2871) MQTT_SAMPLE: sent publish successful, msg_id=0
I (3081) MQTT_SAMPLE: MQTT_EVENT_SUBSCRIBED, msg_id=11408
I (3081) MQTT_SAMPLE: sent publish successful, msg_id=0
I (3081) MQTT_SAMPLE: MQTT_EVENT_UNSUBSCRIBED, msg_id=6495
E (3281) MQTT_CLIENT: Read error or end of stream
I (3291) MQTT_CLIENT: Reconnect after 10000 ms
I (3291) MQTT_SAMPLE: MQTT_EVENT_DISCONNECTED

Are you subscribe or public on v1/devices/me/telemetry channel and using ACCESS_TOKEN as username? If not, please check here: https://thingsboard.io/docs/reference/mqtt-api/#mqtt-basics

It seems I was overthinking the  problem.  I was subscribed to v1/devices/me/telemetry but submitting to /v1/devices/me/telemetry. Thanks!


Allow setting file timestamps from plugins

From #1079

Although https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Last-Modified is not the best way to determine whether a resource has changed it is still a possible way to do so. Setting the file timestamps to zero/a fixed arbitrary value invalidates all results that would be generated by this mechanisms. Since this tool does not create a jar for the projects classes there aren't any other metadata to extract the age of the image from at all. Setting the file timestamp to the current timestamp is often better than setting it to zero. The following article describes the usage of the file timestamps with spring:
https://www.logicbig.com/tutorials/spring-framework/spring-web-mvc/last-modified.html
On a side node, in most bigger projects there are quite a few classes that are generated automatically and might contains comments such as Generated on XXX these would invalidate the reproducible builds anyway so we should change your policy from reproducible to predictable.

Thanks for the input, @ST-DDT.

Setting the file timestamp to the current timestamp is often better than setting it to zero.

Aside from the current timestamp, do you also see a need to set an arbitrary timestamp (for some files or all files)?
And note that, as soon as you assign the current timestamp to files (and not using a fixed timestamp), whenever you build a new image, the layers will always be considered different: https://github.com/GoogleContainerTools/jib/issues/1079#issuecomment-479220028

I would prefer the git commit timestamp as the timestamp for all files, but I can imagine that other users will use other SCM-tools with a similar timestamps. Setting each file to their individual last changed date (from scm) might be an alternative (to only rebuild the layers if they are acutally different), but this is probably too hard to implement. AFAICT I don't need the timestamps on .jars (or .classes)

Sounds like you don't need a feature to explicitly configure file timestamps to a fixed value, for example, as long as Jib supports automatically setting timestamps of all the files in the image to the timestamp of the last git commit. Can you confirm that? We are trying to see if there actually exists a use case for configuring an explicit value to design an optimal way of file timestamp configuration.

If jib adds a "use git commit timestamp option" then I dont need the option to set it to parameter x.
It just feels a little bit redundant to make jib read the git timestamp, if other plugins do that already and provide these values for other plugins. Also it would be less flexible then setting it to a parameter/option.

I need Allow setting file timestamps from plugins。fixed #1800

1.5.0 released with the feature to configure the file modification times. See the jib.container.filesModificationTime doc for Maven/Gradle.
For configuration the container creation time, see https://github.com/GoogleContainerTools/jib/issues/1609#issuecomment-522658237.
@soulmz @nobecutan @mbonato @devinrsmith @yamass


Say if Category spinner is waiting for input or not

Here we see an info message that is seen when pressing the i-circle button. It could perhaps also mention the function of the spinner there on the right.

is it spinning waiting for us to type things in?
is it spinning, meaning we should wait for it to finish, before we start typing things in?

These are things the user needs to know.

Spinning means a result should appear soon. It is a common UI element, I don't think it needs explaining.
Anyone feel free to post official UI guidance regarding this.

(All I know is whenever I got to this page, and before I typed anything in, the spinner was spinning, and I just had to wait forever and nothing ever changed it just kept spinning. So I always gave up and started typing thins in. I found it worked much better once I had typed something in. So I'm saying that I-Circle button should explain exactly what is supposed to happen.)

Part of the confusion might've been induced by Category selection not working properly, i.e. spinner spinning indefinitely instead of showing category results - https://github.com/commons-app/apps-android-commons/issues/5225


How to specify options?

Where does one add
typos.command: Command used to invoke typos. default: "typos"

??
I want to supply my own config for the typos configuration as putting it in ~/typos.toml doesn't seem to work by default.

coc-settings.json , faceplam

Actually, in coc-settings.json, this works:
"typos.command": "typos",

But this does not:
"typos.command": "typos -c /home/deguzim/.typos.toml",


The text quoted with backticks is showing smaller than it should, making it look weird

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: 9.0.59-1
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @iwiznia
Slack conversation (hyperlinked to channel name): ts_external_expensify_bugs
Action Performed:
Prerequisite: Set the font size to bigger in device settings

Open a DM with anyone
Enter a message with quoted backticks as  Hello Test  Test Hello

Expected Result:
Message displayed without any visual issues
Actual Result:
The quoted test is showing smaller, space in the quoted message is interrupted, and not showing in the same line (Higher than the rest of the text)
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[x] Android: Standalone
[ ] Android: HybridApp
[ ] Android: mWeb Chrome
[ ] iOS: Standalone
[ ] iOS: HybridApp
[ ] iOS: mWeb Safari
[ ] MacOS: Chrome / Safari
[ ] MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

View all open jobs on GitHub

Proposal
Please re-state the problem that we are trying to solve in this issue.
The quoted test is showing smaller, space in the quoted message is interrupted, and not showing in the same line (Higher than the rest of the text)
What is the root cause of that problem?
The lineHeight of normal text is 20:
https://github.com/Expensify/App/blob/08e571ca195023f63160076d560f92de96d0fe49/src/styles/index.ts#L240
https://github.com/Expensify/App/blob/2c561aee7b9e92f086a02b088c9f66934d93ca93/src/styles/variables.ts#L66
while the lineHeight of the code text and height of the code wrapper on Android is much smaller compared to 20:
https://github.com/Expensify/App/blob/82b76c1a36cf1a01b00c14510a5812a591e7f2fd/src/styles/utils/codeStyles/index.android.ts#L3-L14
What changes do you think we should make in order to solve the problem?

My experiment proved that we can reuse iOS's codeStyles for Android. So we can remove the Android specific file and rename iOS file to .native.ts to apply to both platforms.

Back and looking at this now. Can't reproduce on Mac or IOS - trying android now

Didn't get a chance to try this on an android device today - but will first thing tomorrow

Was able to reproduce on Android, but I don't think this is likely a priority
Mine also wasn't as drastic as the image in the OP - It was nearly inline with the other text. So I think we'll likely close this but i'll get some more eyes on it tomorrow to confirm

Going to close


Different target descriptions

Hi - I'm opening this as a Draft PR as it definitely still needs work before it can be delivered, but these changes got different descriptions working for me with a json issues.json file locally.

This is ready for review now, let me know if there's anything more you need from me.

We provide the json schema for the issues.json,  which can be used to validate user created issues json file.  https://github.com/IBM/transformation-advisor-sdk/blob/main/ta-sdk-spi/src/main/resources/schema/issue.schema.json
You can also update that schema file for the new optional key you added.


difference in supermicro X11s

got some feedback that the current support for SuperMicro X11 doesn't work for all models of X11. The existing X11 support was written and tested with X11SCM-F in mind. It was reported that X11DSC+ appears to not work, but might work if it was using the X10 code.
I think we need to re-evaluate how we probe for compatibility between SuperMicro models.
Currently, after determining that the BMC is a SuperMicro we call conn.HardwareType() here and here and compare it to a constant of the BMC model number. either x11 or x10. Whichever one it matches we use. This leaves
X11DSC+ not functioning, as reported.
One option could be to not only check this value but if the conn.HardwareType() (or another command) actually worked. and then use that provider implementation.
Any other thoughts or ideas?

@jacobweinstock, are the X11DSC+ not identified at all or what (if any) errors are seen, or which bmclib methods fail to work?
one option here would be to define another 'generic' supermicro probe identifier in which the device board name/model number is identified using ipmitool -I lanplus -H <IP> -U ADMIN -P <password> fru
another option would be to define a X11DSC+ probe identifier with the caller passing in the probe hint

@jacobweinstock, are the X11DSC+ not identified at all or what (if any) errors are seen, or which bmclib methods fail to work?
one option here would be to define another 'generic' supermicro probe identifier in which the device board name/model number is identified using ipmitool -I lanplus -H <IP> -U ADMIN -P <password> fru
another option would be to define a X11DSC+ probe identifier with the caller passing in the probe hint


Plugin knows nothing about ends of functions

function test1() {
	1; //plugin output: "test1". ok
	var func1 = function() {
		2; //plugin output: "func1 = function". ok
	};
	3; //plugin output: "func1 = function". WAT?
}

I've looked into this previously and I don't think that there's anything I can do about it.
The plugin uses SublimeText's scope system to find the closest meta.function that above the current line and assumes that we're in that function. There isn't a scope for "function has finished", so we can't detect when we leave the function.
If anyone has an idea on how to do this, then I'm all ears!

As a workaround (at least for languages like Python), perhaps the user could set up a list of function names to exclude? The one case I typically run into is where I have a lambda function in my code, so the function name shows up as "lambda x" for example. If I could specify a way to say "ignore anything that has the word lambda", it would fix the majority of the broken cases for me.

I note in this Sublime Text forum post, that meta.function.decorator and meta.function.inline are removed from the meta.function set (I presume). Perhaps this would be an easy way to figure out whether the name should be skipped or not; if the match is an inline or decorator, skip it.

I've created pull request #26 that shows how inline functions can be filtered out from the list of what's shown. It works well for me in Python, though there may be languages for which this isn't suited. Hiding this behind a preference might be desired.


Add termbox

Please add termbox to vcpkg: Termbox

We can’t reopen this issue until a PR is opened, unfortunately, consider making a pull request!


[#31927,#31928][prism] Support StringSet and Gauge metrics.

Adds implementations of string set and gauge metrics.
This allows the associated Validates runner tests to pass for Python (test_metrics) and the related tests for Java to pass.
Java Attempted metrics failures (#31926) are to be handled in a different PR.
It was necessary to re-generate update the go protocol buffers to allow for StringSet, so that change has also been included in it's own commit. Most files are only updating a comment WRT which protocol buffer compiler is used.
See https://github.com/apache/beam/pull/32184/files/a073e790713ca547eada875c75bbd8073bb634fa..77316d7b4d53c86f716015c44186c737e7171e8e for just the real code changes, that implement StringSet and Gauge metrics support inn prism.
Fixes #31927 and #31928

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
[ ] Update CHANGES.md with noteworthy changes.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

R: @damondouglas
The failing precommits (assuming the re-runs also fail again) are unrelated. Apparently the current development Java image doesn't exist.


Where to go with general questions

Hey there, where should I post general questions ?
I tried using the TileDB Slack community link in the readme, but it seems to direct me to the CZI community.

Hi @royassis ! Can you share the original URL, and the URL you got redirected to?

Hey @johnkerl
Here is the link address https://czi.co/science-slack, the list text is TileDB Slack community.
I'm being rerouted here : https://app.slack.com/client/T8MB1T0MA/browse-channels

@royassis I think there's a typo in our README.md

@royassis please try
https://tiledb-community.slack.com/join/shared_invite/zt-ndq1ipwl-QcithaWG6j1BImtuQGSpag#/shared-invite/email

I think we can we close this now that the link has been fixed.


Fix default datetime values for test result upload - covid pipeline

BACKEND PULL REQUEST
Related Issue
Resolves #7087
Changes Proposed

Updates the default timezone for the following dates testResultDate, orderTestDate, dateResultReleased to use the ordering provider address if none is provided for the test result bulk upload - covid pipeline.

Additional Information

This is to fix an issue that CO was experiencing:

The issue happens because the new system does a validation check for incoming records. It requires that the collection date and time (OBR7) is strictly less than the result date and time (OBX19) which also must be strictly less than the reporting date and time (MSH7).

A previous effort (#6961) only addressed the FHIR pipeline. This work addresses the covid pipeline.
Testing
Deployed on dev2
A branch with a log statement has been added if you want to see what the transformed row will look like.
Add a unique comment to the "Test comment" row so you can easy search the logs for this 😄

@mehansen ready for re-review!

so I was playing around with dates that are during DST and the time zone converter applies the correct UTC offset according to whether that date is in DST or not (so not impacted by the date that we're running the test). which is the way it should be and makes sense - sorry for misleading you! 🙈 I think the tests would've been fine before but still looks good now! thanks for finding the cause of CO's bug

OOO I did not know that hahah -- thank you for testing this out for the future!!! 🙌


Error while creating new project with angular-cli

Bug Report or Feature Request (mark with an x)
- [x] bug report -> please search issues before submitting
- [ ] feature request

Versions.

@angular/cli: 1.0.0-rc.4
node: 7.0.0
os: darwin x64 macos Sierra
npm: 4.4.1
Repro steps.

ng new app_name
The log given by the failure.

npm ERR! code ETARGET
npm ERR! notarget No compatible version found<EMAIL_ADDRESS>npm ERR! notarget Valid install targets:
npm ERR! notarget 0.2.0, 0.2.1, 0.2.2, 0.3.0, 0.4.0
npm ERR! notarget
npm ERR! notarget This is most likely not a problem with npm itself.
npm ERR! notarget In most cases you or one of your dependencies are requesting
npm ERR! notarget a package version that doesn't exist.
npm ERR! notarget
npm ERR! notarget It was specified as a dependency of 'istanbul-lib-hook'
Desired functionality.

Initialize new angular app
Mention any other details that might be useful.

As a workaround you can use yarn install  which will prompt you to select valid version for the installation.

Even though I can choose valid version, I have the same problem here. :<
Couldn't find any versions for "append-transform" that matches "^0.4.3"

npm uninstall -g @angular/cli
npm cache clean
npm install -g @angular/cli
fixed this issue for me

This sounds like a problem with a third party lib that released a version with bad deps. That reinstalling fixed the issue supports this theory.

I am getting the same error in existing project while updating packages with npm install


Add CZMLextractor API documentation

Address #909, #911

"No module named 'czml3'" when building the docs. Please adjust .readthedocs.yml accordingly.

Got it! https://poliastro--912.org.readthedocs.build/en/912/api/safe/czml/extract_czml.html
There's lots of... Weird stuff though in the function parameters (they were there before this PR of course)

@astrojuanlu Docstrings in the CZML module can be improved a lot. Should I do it?

If we don't do it now we'll have to do it in a future PR, so go ahead :)
On Thu, 16 Apr 2020, 11:38 Abhishek Chaurasia<EMAIL_ADDRESS>wrote:

@astrojuanlu https://github.com/astrojuanlu Docstrings in the CZML
module can be improved a lot. Should I do it?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/poliastro/poliastro/pull/912#issuecomment-614534484,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AACNIZM2RSDKD6RHD32N2VDRM3GVPANCNFSM4MIZMIIQ
.

Thanks a lot @iamabhishek0!


java example

Hey,
thanks for your great work, but I can't get my project running in IntellJ and gradle 4.3.1. :/
Can you add a simple java example with two flavors?
Thanks St.

Perhaps this test can show how it works


feat: New pattern avm/ptn/authorization/resource-role-assignment

Description
Adding new pattern avm/ptn/authorization/resource-role-assignment
https://github.com/Azure/Azure-Verified-Modules/issues/939
Migration of modules/authorization/resource-scope-role-assignment
Closes #937
Pipeline Reference

Pipeline

Type of Change

[ ] Update to CI Environment or utlities (Non-module effecting changes)
[ ] Azure Verified Module updates:

[ ] Bugfix containing backwards compatible bug fixes, and I have NOT bumped the MAJOR or MINOR version in version.json:

[ ] Someone has opened a bug report issue, and I have included "Closes #{bug_report_issue_number}" in the PR description.
[ ] The bug was found by the module author, and no one has opened an issue to report it yet.

[ ] Feature update backwards compatible feature updates, and I have bumped the MINOR version in version.json.
[ ] Breaking changes and I have bumped the MAJOR version in version.json.
[ ] Update to documentation

Checklist

[x] I'm sure there are no other open Pull Requests for the same update/change
[x] I have run Set-AVMModule locally to generate the supporting module files.
[x] My corresponding pipelines / checks run clean and green without any errors or warnings

Note, for this and all other changes, I'd recommend to re-run Set-AvmModule -ModuleFolderPath '.\avm\ptn\authorization\resource-role-assignment' -SkipFileAndFolderSetup -ThrottleLimit 5 -Recurse

just bubbling this up in its own comment for awareness

@peterbud, @AlexanderSehr, please note that this module has just been filed for addition into the MAR/MCR manifest. Please do not attempt to publish this module, until its addition is confirmed (I'll let you know when the MCR PR is merged). Thank you!

@peterbud, @AlexanderSehr, please note that this module has just been filed for addition into the MAR/MCR manifest. Please do not attempt to publish this module, until its addition is confirmed (I'll let you know when the MCR PR is merged). Thank you!

@peterbud, @AlexanderSehr, this module has now been added to the MAR manifest. Please feel free to proceed with the review/publication as per the standard process. Thanks!


Introduce DiskSpaceAllocator

This commit adds DiskSpaceAllocator and the associated unit tests.
The DiskSpaceAllocator allows for disk segments to be preallocated into
a reserve pool and allocated to BlobStores on demand.
It also makes the changes to utilize DiskSpaceAllocator in other store
components (DiskManager, BlobStore, and Log)
See design doc here.
Reviewers: @vgkholla, @nsivabalan
Time to review: 1 hr.

@nsivabalan @vgkholla design doc/PR updated.

Is the coverage up to date?

Codecov Report

Merging #647 into master will increase coverage by 0.23%.
The diff coverage is 83.51%.

@@             Coverage Diff              @@
##             master     #647      +/-   ##
============================================
+ Coverage     63.72%   63.96%   +0.23%
- Complexity     3650     3699      +49
============================================
  Files           326      329       +3
  Lines         24893    25088     +195
  Branches       3122     3153      +31
============================================
+ Hits          15863    16047     +184
+ Misses         8166     8165       -1
- Partials        864      876      +12

Impacted Files
Coverage Δ
Complexity Δ

.../com.github.ambry/store/IndexWritePerformance.java
0% <0%> (ø)
0 <0> (ø)
:arrow_down:

...main/java/com.github.ambry.server/AmbryServer.java
0% <0%> (ø)
0 <0> (ø)
:arrow_down:

...ava/com.github.ambry/store/CompactionVerifier.java
0% <0%> (ø)
0 <0> (ø)
:arrow_down:

...a/com.github.ambry/store/IndexReadPerformance.java
0% <0%> (ø)
0 <0> (ø)
:arrow_down:

...ava/com.github.ambry/config/DiskManagerConfig.java
100% <100%> (ø)
1 <1> (?)

...rc/main/java/com.github.ambry.store/BlobStore.java
87.86% <100%> (+0.2%)
46 <2> (+1)
:arrow_up:

.../com.github.ambry.store/StorageManagerMetrics.java
92.85% <100%> (+1.19%)
6 <0> (ø)
:arrow_down:

...ls/src/main/java/com.github.ambry.utils/Utils.java
70.92% <61.11%> (+0.28%)
67 <1> (ø)
:arrow_down:

...in/java/com.github.ambry.store/StorageManager.java
93.15% <62.5%> (+4.12%)
20 <1> (ø)
:arrow_down:

...ava/com.github.ambry.store/BlobStoreCompactor.java
91.79% <75%> (-1.52%)
114 <1> (-2)

... and 17 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 64b9be4...b56a55a. Read the comment docs.

@nsivabalan @vgkholla fixed merge conflicts, ready for review again

@cgtz PROD changes look good - I just have to review DiskSpaceAllocatorTest. Do you mind resolving this merge conflicts to make sure tests succeed after all changes?

@vgkholla @nsivabalan formatted and rebased


id should be string?

Given the simple example, should async authorize(credentials, req) {                 if (credentials) {                     return {id: 1, name: credentials.username, email<EMAIL_ADDRESS>               }                 // Return null if user data could not be retrieved                 return null
use id as a string?

Hi Andy,
I think you're right, looking at the type definitions in nextauth, id should be a string here!
Thanks for reporting this


Linux: KeyError:<PHONE_NUMBER> on plc.close()

On linux the following error occures:

import pyads
pyads.open_port()
30000
plc = pyads.Connection('<IP_ADDRESS>.1.1', pyads.PORT_SPS1, '<IP_ADDRESS>')
plc.open()
2017-07-27T10:31:42+0000 Info: Connecting to <IP_ADDRESS>
plc.read_by_name('.gWSM_Scene_ID_Buero', pyads.PLCTYPE_BYTE)
2
plc.close()
2017-07-27T10:32:02+0000 Info: connection closed by remote
Traceback (most recent call last):
File "", line 1, in
File "/usr/local/lib/python2.7/dist-packages/pyads/ads.py", line 322, in close
adsDelRoute(self._adr.netIdStruct())
File "/usr/local/lib/python2.7/dist-packages/pyads/pyads_ex.py", line 75, in wrapper
return fn(*args, **kwargs)
File "/usr/local/lib/python2.7/dist-packages/pyads/pyads_ex.py", line 118, in adsDelRoute
raise ADSError(error_code)
File "/usr/local/lib/python2.7/dist-packages/pyads/pyads.py", line 34, in init
self.msg = "{} ({})".format(ERROR_CODES[self.err_code], self.err_code)
KeyError:<PHONE_NUMBER>

I use the newest version of pyads from git from today on raspbian.

I didn't experience that, yet. So I was not able to try it on a Raspberry Pi, yet. Can you try to skip the pyads.open_port() statement?
import pyads
plc = pyads.Connection('<IP_ADDRESS>.1.1', pyads.PORT_SPS1, '<IP_ADDRESS>')
with plc:
    plc.read_by_name('.gWSM_Scene_ID_Buero', pyads.PLCTYPE_BYTE)

The connection works also w/o the pyads.open_port() statement. But the error keeps the same.

plc.close()
2017-07-27T11:19:02+0000 Info: connection closed by remote
Traceback (most recent call last):
File "", line 1, in
File "/usr/local/lib/python2.7/dist-packages/pyads/ads.py", line 322, in close
adsDelRoute(self._adr.netIdStruct())
File "/usr/local/lib/python2.7/dist-packages/pyads/pyads_ex.py", line 75, in wrapper
return fn(*args, **kwargs)
File "/usr/local/lib/python2.7/dist-packages/pyads/pyads_ex.py", line 118, in adsDelRoute
raise ADSError(error_code)
File "/usr/local/lib/python2.7/dist-packages/pyads/pyads.py", line 34, in init
self.msg = "{} ({})".format(ERROR_CODES[self.err_code], self.err_code)
KeyError:<PHONE_NUMBER>

I think I found the root cause:
The function AdsDelRoute does not return a return code
ADS/AdsLib/AdsLib.cpp:
...
void AdsDelRoute(const AmsNetId ams)
{
router.DelRoute(ams);
}
...
So evaluate the return code on python side make no sense:
@router_function
def adsDelRoute(net_id):
"""
:summary:  Remove existing route from the AMS Router.
:param pyads.structs.SAmsNetId net_id: net id associated with the routing
entry which is to be removed from the router.
"""
delete_route = _adsDLL.AdsDelRoute
delete_route.restype = ctypes.c_long

error_code = delete_route(net_id)

if error_code:
    raise ADSError(error_code)

You are right. That is a mistake that sneaked in. The DelRoute() function does not provide a return value.

OK, I merged your PR after also deleting the return type declaration. Can you have a look if it is working now and provide a short feedback.

import pyads
plc = pyads.Connection('<IP_ADDRESS>.1.1', pyads.PORT_SPS1, '<IP_ADDRESS>')
plc.open()
2017-07-28T06:16:02+0000 Info: Connecting to <IP_ADDRESS>
plc.read_by_name('.gWSM_Scene_ID_Buero', pyads.PLCTYPE_BYTE)
2
plc.close()
2017-07-28T06:16:14+0000 Info: connection closed by remote

Works! Thanks a lot!

Thanks for your contribution.


Create a GPU accelerated examples/extra-large-graphs

Hi @jacomyal ! I've been working on an NVIDIA backed sigma.js extension for a few weeks and I'm sharing it with you today. We're writing GPU accelerated, open-source libraries for data visualization, among other things, and wanted to try to integrate with sigma.js. It's lead me to have plenty of ideas for optimizing the sigma.js process/render pipeline, if you're interested. Hopefully you like my contribution! Below is the README.md for this contribution.
Extra Large Graphs Demo with @rapidsai/node GPU acceleration
RAPIDS.ai is an open source GPU-acceleration project. We're building new
tools with familiar APIs and extending existing tools to that more
scientists and users can take advantage of GPU performance.
This project creates a RapidsGraphologyGraph subclass of Graph,
plus a modified index.ts to make GPU-stored graph vertices and edges
available to your browser session. It talks to the @rapidai/demo-api-server
that has been built using node-rapids.
Performance
Using a GPU for graph rendering offers substantial performance increases.
In this demo, I've included screenshots of performance comparison's between
using our GPU-backed RapidsGraphologyGraph and the original renderer
included in the large-graphs demo.
When the complexity of the graph matches the original demo, performance
is comparable:

When the complexity increases substantially, the GPU performance improvement
is marked:

It is important to note in the larger case that the "I/O" benchmark for
the original large-graphs demo includes the graph generation time, which
is substantial. However, were the file stored in a 500MB .json (as in the
GPU case) and parsed in-browser, execution time is similar or longer.
What Is Happening
In order to run this demo, you need the @rapidsai/demo npm package,
a system with an NVIDIA GPU from around 2018 forward (Turing architecture
and up), and have previously installed the [CUDA Toolkit] (https://developer.nvidia.com/cuda-toolkit).
The node-rapids workspace demo-api-server
is available as a backend to any HTTP client. At this time only limited
functionality is available to parse JSON files in the graphology
graph dataset format, plus API requests to request Dataframes and
their Columns via apache-arrow.
Two endpoints, graphology/nodes and graphology/edges specifically
return pre-formatted arrays that can be used directly with the
sigma.js renderer.
Additional Dependencies

@rapidsai/demo-api-server
apache-arrow

To run the demo
Due to native dependency distribution complexity, pre-packaged builds of
the node-rapids modules are presently only available via our public docker images.
See USAGE.md for more details.
Run @rapidsai/demo-api-server via docker:
REPO=ghcr.io/rapidsai/node
VERSIONS="22.02.00-runtime-node18.2.0-cuda11.6.2-ubuntu20.04"

# Be sure to pass either the `--runtime=nvidia` or `--gpus` flag!
docker run --rm \
    --runtime=nvidia \
    -e "DISPLAY=$DISPLAY" \
    -v "/etc/fonts:/etc/fonts:ro" \
    -v "/tmp/.X11-unix:/tmp/.X11-unix:rw" \
    -v "/usr/share/fonts:/usr/share/fonts:ro" \
    -v "/usr/share/icons:/usr/share/icons:ro" \
    $REPO:$VERSIONS-demo \
    npx @rapidsai/demo-api-server

We expect to have full npm support soon.
Next generate a graph of your liking, or provide another:
cd $SIGMAJSHOME/examples/extra-large-graphs
node generate-graph.js 10000 20000 3 graphology.json
cp graphology.json $DOCKERROOT/node/modules/demo/api-server/public

Finally run the extra-large-graphs demo in the normal fashion:
cd $SIGMAJSROOT/examples
npm start --example=extra-large-graphs

Dataset
Run the graph generator at https://github.com/thomcom/sigma.js/blob/add-gpu-graph-to-example/examples/extra-large-graphs/generate-graph.js
to create a very large graph using the command:
node graph-generator.js 1000000 2000000 3 graphology.json

Any dataset that matches the schema of graphology.json is supported.
This closes #1258

Spending some time cleaning up "my end" of this at github.com/rapidsai/node before I clean this one up. I hope to be done here by end of Friday.

Pinging this one, any interest?

Hey @tonyz0x0 or @lf- what do you think?

Hello @thomcom, this looks interesting but I don't have any NVIDIA gpu to test your PR on unfortunately.
What I understand from this is there is basically two things to make this work? 1. A gpu-backed implementation of graphology's interface (at least the subset necessary to sigma, by cleverly repurposing forEach methods etc.) and 2. programs that are the same as ours but that don't need byte array processing since the backing buffers are already encapsulated into the make-believe graphology instance.
This is quite clever and seems to work nicely indeed. The fact is it can very well work from userland also so the question on our side is probably to decide whether we want to merge your example (which cannot work without proper hardware, as I understand?) or if we can just point to your code somewhere in our docs, no?
What do you think @jacomyal ?

Hey @Yomguithereal, thanks for your consideration! Your analysis is essentially correct. The GPU is able to read graphology data files and pack them into the serialized backing buffers that sigma.js displays.
It is true that you can't run the demo without the proper hardware - but that raises another interesting question. The GPU in this situation is accessed through a web server. I'll talk to some people internally and see if we can put the server that this demo depends on somewhere public for you to play with or at least see the demo work!
We love sigma.js here and would love to get this connected with your work one way or another. :)

Thanks for the answer @thomcom, I think we'll link to your resources then when we find time to release the next version of the lib (which should be sooner than later now :) ).


Bug in smart contract

Hello ,
Myself Raja Kumar , a proud contributor at GSSOC23. I would like to contribute to this project
I have identified a potential bug in the addemp function of the allemp contract. The issue lies in the _wallet_ddress parameter of the function.
If you think it is legit then do assign me the issue under GSSOC23 with the level of PR as Well.

I think it's not a bug.. But it is surely a typo. Yup, Kind of legit issue i might say.

`pragma solidity ^0.8.0;
contract allemp {
mapping(address => Sal) public deployedSal;
event salcreated(
    bytes32 FirstName,
    bytes32 LastName,
    address indexed owner,
    address salAddress,
    bytes32 image,
    uint256 indexed timestamp,
    bytes32 Position
);

function addemp(
    bytes32 _FirstName,
    bytes32 _LastName,
    bytes32 _wallet_address,
    bytes32 _Country,
    bytes32 _image,
    bytes32 _Position
) public {
    Sal newSal = new Sal(
        _FirstName,
        _LastName,
        _wallet_address,
        _Position,
        _Country,
        _image
    );
    deployedSal[address(newSal)] = newSal;

    emit salcreated(
        _FirstName,
        _LastName,
        msg.sender,
        address(newSal),
        _image,
        block.timestamp,
        _Position
    );
}

}
contract Sal {
bytes32 public FirstName;
bytes32 public LastName;
bytes32 public wallet_address;
bytes32 public Position;
bytes32 public Country;
bytes32 public image;
uint256 public receivedAmount;
address payable public owner;

event donated(address indexed donar, uint256 indexed amount, uint256 indexed timestamp);

modifier onlyOwner() {
    require(msg.sender == owner, "Only the contract owner can call this function");
    _;
}

constructor(
    bytes32 _FirstName,
    bytes32 _LastName,
    bytes32 _wallet_address,
    bytes32 _Position,
    bytes32 _Country,
    bytes32 _image
) {
    FirstName = _FirstName;
    LastName = _LastName;
    wallet_address = _wallet_address;
    Position = _Position;
    Country = _Country;
    image = _image;
    owner = payable(msg.sender);
}

function donate() public payable onlyOwner {
    owner.transfer(msg.value);
    receivedAmount += msg.value;

    emit donated(msg.sender, msg.value, block.timestamp);
}

}`
here is the updated code with the following changes

Used uint256 instead of uint .

2.Using a mapping instead of an array
If you anticipate a large number of deployed Sal contracts, using a mapping instead of an array for deployedSal in the allemp contract can provide better efficiency for contract retrieval and management.
3.Using bytes32 for string parameters
If the string parameters have a fixed length, such as _FirstName, _LastName, _Country, _Position, and _image, use the bytes32 data type instead of string. This can save gas costs and improve efficiency.
4.Using a modifier for access control
If certain functions should only be accessible by specific roles or addresses, you can use a modifier to enforce access control. This helps improve security and restrict unauthorized access to critical functions.

Great issue , start working on this.


Deepscan fixes - Parameter of local function is not used.

Explain the changes

Deepscan fixes - Parameter  of local function  is not used.

Signed-off-by: liranmauda<EMAIL_ADDRESS>

closing as @nimrod-becker removed UNUSED_PARAM from the deepscan rules


Persist config elements' state without message Key

Right now current state of elements is saved between config loads only if messaegeKey is set for the element. Sometimes selection needs to be preserved without actually being sent to the watch. For example a SELECT element with predefined color theme names. When theme is selected - individual colors are sent to the watch - not the theme value. But current theme selection needs to persist. Perhaps persist based on ID instead of messageKey?

duplicate of https://github.com/pebble/clay/issues/116


Move away from jQuery

Is there an approach to move away from jQuery?

This has been asked before - and there is an PR open for it - might be merged in a future v4 release:
https://github.com/twbs/bootstrap/pull/23586

Goal is a v4 minor release, but we haven't figured out which one yet. Closing for the open PR.


Does TestContainers Ruby provide Authentication with Docker functionality?

I want to authenticate docker for pulling image from ecr, to instantiate container of that. Is this functionality provided as as golang https://golang.testcontainers.org/features/docker_auth/?

@Koumudini-Sambre hey! Since testcontainers-ruby uses the docker-api gem underneath I think you can use the Docker.authenticate! command before creating any container (as described here:
# docker command for reference: docker login
Docker.authenticate!('username' => 'docker-fan-boi', 'password' => 'i<3docker', 'email' =><EMAIL_ADDRESS># => true

# docker command for reference: docker login registry.gitlab.com
Docker.authenticate!('username' => 'docker-fan-boi', 'password' => 'i<3docker', 'email' =><EMAIL_ADDRESS>'serveraddress' => 'https://registry.gitlab.com/v1/')
# => true

Can you try it and report your findings here?

Yes this works @guilleiguaran Thanks :)


Fix for multiple field types in content_context

Pre-Flight checklist

[x] Testing

[x] Code is tested
[x] Changes have been manually tested

What are the relevant tickets?
Fixes #447
What's this PR do?
Fixes a bug where multiple field types were conflicting with each other, causing some missing results from content_context in the content REST API
How should this be manually tested?

Codecov Report

Merging #449 (2eacef1) into master (35199c4) will increase coverage by 4.66%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #449      +/-   ##
==========================================
+ Coverage   90.38%   95.05%   +4.66%
==========================================
  Files         138       72      -66
  Lines        4755     1901    -2854
  Branches      721      383     -338
==========================================
- Hits         4298     1807    -2491
+ Misses        409       92     -317
+ Partials       48        2      -46

Impacted Files
Coverage Δ

static/js/util/factories/websites.ts
96.55% <0.00%> (-3.45%)
:arrow_down:

news/views.py

...ort/management/commands/import_ocw_course_sites.py

content_sync/api.py

users/factories.py

content_sync/decorators.py

websites/api.py

websites/__init__.py

websites/config_schema/validators.py

main/apps.py

... and 56 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 35199c4...2eacef1. Read the comment docs.


Re-organized impact model - [merged]

In GitLab by @cmastalli on Jan 22, 2019, 11:12
Merges topic/impact -> topic/refact
I rebased and re-organized the impact classes developed by Nicolas (see !53 for more information).
I tested that test_impact pass!

In GitLab by @cmastalli on Jan 22, 2019, 11:13
mentioned in merge request !53

In GitLab by @nmansard on Jan 22, 2019, 13:02
I though that you would merge before moving impact.
I need some material from this merge request. Can I process to the merge?

In GitLab by @cmastalli on Jan 22, 2019, 13:14
Yes, you can

In GitLab by @nmansard on Jan 22, 2019, 13:24
I looked at the branch nmansard/topic/impact: there is some material their missing in the MR.
Ok, I merge and I clean it myself.

In GitLab by @nmansard on Jan 22, 2019, 13:24
merged

In GitLab by @nmansard on Jan 22, 2019, 13:24
mentioned in commit 407c7fbb522f081b83740d31f4e44a2fba54ca5c


New Icon for Mac to Differentiate App

Would it be possible to have an alternative icon for the Mac app? Or the option to change the icon? I have about 50% of my apps in my dock that look like blue circles right now and Franz blends in with them all a little too well.
Maybe just an option to change the icon in the settings to one with a different background color (such as red, yellow, green, etc.)

The Franz logo and brand are carefully crafted and trademarked, and the chosen blue color is integral part of it, so unfortunately we must decline your request.
but hint, hint: all i'm saying is .icns for any .app


(Sommelier error)Gdk-Message: 16:46:30.920: Error 71 (Protocol error) dispatching to Wayland display.

name: bionic
encrypted: no
Entering /mnt/stateful_partition/crouton/chroots/bionic...
crouton: version 1-20200116214215~master:9017d640
release: bionic
architecture: amd64
targets: core,audio,cli-extra
host: version 12739.105.0 (Official Build) stable-channel rammus
kernel: Linux localhost 4.19.87-brunch-sebanc #1 SMP PREEMPT Sat Apr 4 09:07:43 CEST 2020 x86_64 x86_64 x86_64 GNU/Linux
freon: no

Hi all, I followed this wiki  to install sommelier in chroot. Installed successfully.
And I launched gedit. It displayed without error. But when I opened firefox, it reported:
Gdk-Message: 16:46:30.920: Error 71 (Protocol error) dispatching to Wayland display.

No firefox window displayed.

@yutouyes
I googled that error and found this:
Bug 779764 - Gdk-WARNING **: Error 71 (Protocol error) dispatching to Wayland display

Firefox doesn't Wayland native, I am not sure about OpenOffice. But evolution does.
Can you please capture the the logs produced with WAYLAND_DEBUG=1 while the issue occurs?
That should tell what protocol error actually occurs...

So it appears to be an upstream bug.
Hope this helps,
-DennisLfromGA

I didn't have to install sommelier to get Wayland apps working. I just did this:
export XDG_RUNTIME_DIR='/var/host/chrome'
if test -z "$DBUS_SESSION_BUS_ADDRESS" ; then
                 ## if not found, launch a new one
                 eval `dbus-launch --sh-syntax`
                 ##echo "D-Bus per-session daemon address is: $DBUS_SESSION_BUS_ADDRESS"
fi
export DBUS_SYSTEM_BUS_ADDRESS='unix:path=/var/host/dbus/system_bus_socket'

Then I was able to try to start firefox thus:
MOZ_ENABLE_WAYLAND=1 WAYLAND_DEBUG=1 firefox, but I get this error:
[2880191.924] wl_display@1.error(wl_registry@20, 0, "invalid version for global wl_compositor (1): have 3, wanted 4")
I think that is set here: https://chromium.googlesource.com/chromium/src/+/refs/heads/master/components/exo/wayland/wl_compositor.h

As per https://hg.mozilla.org/mozilla-central/file/tip/widget/gtk/nsWaylandDisplay.cpp#l209
// Requested wl_compositor version 4 as we need wl_surface_damage_buffer().
But wl_surface_damage_buffer appears in https://chromium.googlesource.com/chromium/src/third_party/+/master/wayland/include/protocol/wayland-client-protocol-core.h
So maybe we need someone to submit a bug report to crbug.com to try to get the wl_compositor version revved in https://chromium.googlesource.com/chromium/src/+/refs/heads/master/components/exo/wayland/wl_compositor.h ?


integrate with zabbix

hi, fkmoon:
say hello from nokia softerware.
we complete "zabbix integrate with keycloak" with the help from php-oauth2-client-5.0.2
during this work, we do some changes on this library, list main changes below:

in your php-oauth2-client library, provide 2 method to store token

SessionTokenStorage.php
PdoTokenStorage.php
zabbix have its own DB manipulations, so the above changes are focus on zabbix DB manipulate

finally , the above changes are not general implement while it is useful for zabbix  , we suggest create a branch to store those changes, is OK?

Thanks for using php-oauth2-client! :)
A few things:

You are free to use the library under the MIT license, so no need to ask for permission :-)
I don't (actively) maintain version 5 of the OAuth client since version 6 was released some time ago;
What changes did you make in CurlHttpClient? They may be interesting for my version as well, can you share those?
I indeed think it is better to create a (private) branch for your version. If you are willing you can of course contribute back changes that would also benefit other users of the OAuth client on a case-by-case basis.

Thanks again!

Hi (also from Nokia)
Thanks for providing php-oauth2-client! :)
Some clarification questions:
2) Would it be okay to implement these in version 6 and do a backport to version 5?
4) Why do you propose an internal fork? Because of version 5 or because of the actual feature?

Would it be okay to implement these in version 6 and do a backport to version 5?

You mean implement your changes for version 6 as well so you can upgrade?

Why do you propose an internal fork? Because of version 5 or because of the actual feature?

Because if the changes you made or only relevant for your use, then it doesn't really make sense to add them to my version of php-oauth2-client, right?

hi,fkooman,
for CurlHttpClient.php
i add the below snippet

I know,  configure php.ini can also  make PHP service  verify the certificate of another server.
while the above snippet handle the https/http request more freedom for zabbix.

If you deploy on Debian/CentOS/RHEL/Fedora verifying the host/peer are the default. They use the built-in certificates that are trusted by the system. You are using self-signed certificates I assume?
If not, and you can't use the system CA, I recommend using something like https://github.com/paragonie/certainty for working with up to date CA lists.
Modifying these settings can be quite dangerous! Be careful!

OK，thanks your comments .
this issue can be closed.
thanks your wonderful library ^_^


no-unnecessary-generics misbehaves with this

Hi all,
First of all, Thanks for the work on this project!
I'm currently working on ambient types which needs to have a methods chainability support, like:
const a = factory({
  method: chainableMethod(),
});

a.method()
  .method();

my reduced version of typings for that:
  function factory<T>(config: T): FactoryResult<T>;

  type FactoryResult<T> = UnpackedDefinition<T> & {
    [s: string]: unknown;
  };

  type UnpackedDefinition<T> = {
    [k in keyof T]:
      T[k] extends MethodWrapper<infer C> ? C
      : T[k]
  };

  interface MethodWrapper<T extends <S>(this: S, ...args: any[]) => S> {
    get(): T;
  }

  function chainableMethod(): MethodWrapper<UnnecessaryGenericThis>;

  type UnnecessaryGenericThis = <T>(this: T) => T

Everything seems working fine(no TS errors, autocomplete works), but I get a dtslint error:

no-unnecessary-generics  Type parameter T is never used.

It complains about:
   type UnnecessaryGenericThis = <T>(this: T) => T

where I try to return the current this from a function(is there another way to do it?).
I can get why such error occurs for arbitary args, but not sure about this.
Is it an error in dtslint or am I doing it wrong? Please let me know if I can provide more info!

Tested against:

dtslint: 0.5.3 and 1.0.2
~typescript: 3.3.3333 and 3.6~

This is super strange, I've just tried to re-install everyting with yarn(I used npm before) and seems like it works 🤔 Sorry for the noise.


Add the ability to generate and restore CSV for translations that are missing only.

Add command line switch that hides completed translations from the output csv and also allows for merging only changed keys back into the js files.
This allows for incremental localization by generating a CSV with only the keys the translator needs to work on.

First of all, thanks a lot. This is awesome.
There are a few style issues, indentation and whitespace, that don't match the rest of the file.

Better? It seems mixing tabs and spaces is a no-no.

I realized that the project needed an upgrade, mainly tests, so that PRs can be tested. If you could please rebase and add tests, that would be great. Sorry for the hassle, as I changed the code a bit (babel).

Closing this in favor of the new PR that has been redone based on the code changes.


Cannot read property 'linear' of undefined

error:
d3.scale.linear() ,Cannot read property 'linear' of undefined
https://d3js.org/d3.v4.min.js
right:
https://d3js.org/d3.v3.min.js

The API was changed between v3 and v4. you should now use d3.scaleLinear(). Check the release notes to get details.

error:
Error in [Cannot read property 'scale' of undefined].

@ram-nallari Try d3.scaleLinear, or d3.scaleOrdinal, and check which version - d3.scale is there in v3 but gone in v4.


AIP-133 missing rules for validating HTTP URI

It does have a rule to check for the presence of the parent variable, but doesn't ensure that it is the only variable, or that the "collection where the resource is being added should map to the URI path."

the "collection where the resource is being added should map to the URI path."

This is to say that with CreateBooks having a URI suffix of /books, the resource definition for Book should have a collection of books to match in its pattern(s)?

So, to confirm, would the remaining validation rule do something like the following?

Extract the suffix of the URI path as the collection identifier (here books).
Go through each Resource pattern in Book and make sure that each one contains the collection identifier (here books/).

Yep that sounds correct.


Objective-C exception thrown. Name: NSInternalInconsistencyException Reason: Client Characteristic Configuration descriptors must be configured using setNotifyValue:forCharacteristic:

After Start Update Async I got the above exception

Note:

code :
var services = await connectedDevice.GetServicesAsync();
        var serviceid = services[0].Id;
        var service = await connectedDevice.GetServiceAsync(serviceid);

        var characteristics = await service.GetCharacteristicsAsync();

        var characteristicread= await service.GetCharacteristicAsync(characteristics[1].Id);

         var characteristicWrite = await service.GetCharacteristicAsync(characteristics[0].Id);

        characteristicread.ValueUpdated += (o, args) =>
        {
            var bytes = args.Characteristic.Value;
        };

        try
        {
            await characteristicread.StartUpdatesAsync();
        }
        catch(Exception ex)
        {
         here
        }

Steps to reproduce
1.run the above code.After  characteristicread.StartUpdatesAsync();

I got  Client Characteristic Configuration descriptors must be configured using setNotifyValue:characteristic:

Expected behavior
it should not crash
Actual behavior
its gets crash
Crashlog
Objective-C exception thrown. Name: NSInternalInconsistencyException Reason: Client Characteristic Configuration descriptors must be configured using setNotifyValue:forCharacteristic:
Configuration
Version of the Plugin: latest
Platform: e.g. iOS 10
Device: iphonexs

Hi @suriyaKalidoss21,
I'm the friendly issue checker.
Thanks for using the issue template :star2:
I appreciate it very much. I'm sure, the maintainers of this repository will answer, soon.

somebody please provide me quick workaround

Was not able to reproduce this with the current sample app and an iphone 7 running ios 12.4

Hi @xabre
I can't able to read from BLE device after write,Please provide me solution Advance Thanks
My code:
        var services = await connectedDevice.GetServicesAsync();
        var serviceid = services[0].Id;
        var service = await connectedDevice.GetServiceAsync(serviceid);
        var characteristics = await service.GetCharacteristicsAsync();
        var characteristicread= await service.GetCharacteristicAsync(characteristics[1].Id);
      var characteristicWrite = await service.GetCharacteristicAsync(characteristics[0].Id);
      if (characteristicread.CanUpdate)
        {
            characteristicread.ValueUpdated += (s, ee) =>
            {
                Debug.WriteLine("characteristic.ValueUpdated");
                var bytes = ee.Characteristic.Value;
                string data = Encoding.ASCII.GetString(bytes);  //no value here
            };
                await characteristicread.StartUpdatesAsync();
        }
        byte[] bytese = Encoding.ASCII.GetBytes("LIST_DIR,audio");
--write code
            await characteristicWrite.WriteAsync(bytese);

charecteristcis:

Hi @xabre
I have two queries,Issues exist in your GitHub samples
query 1: Unable to read after charecteresteric write'
Step 1: Write the bytes to write characteristic,Refer screenshot

    Step 2: Unable to read data after the write you can refer the screenshot

query 2: Exception thrown at descriptor write page, Refer screenshot
while writing the same value(write code Refer above code screenshot) to write discriptor I got the exception

I'm getting the same error when trying to write 02 00 into a descriptor with the sample app.  iPhone is an iPhone SE running 12.4

Hi @jkandiko
could you please share me some code sample you have tried.

@suriyaKalidoss21  I didn't modify the any source code from the sample applications.  My guess is your application is writing values that iOS doesn't like and your code is fine.  Here's the input screen on my device

Hi @jkandiko ,
Thanks for the information. Does it work fine for you?

Hi @suriyaKalidoss123 ,
Are you able to get this resolved? any code samples will help.
In my situation, the device supports only Write & Indicate. I'm not sure if the plugin supports indicate.
@xabre for the devices that doesn't support read characteristics, how can i retrieve values from the device? Any samples would be really helpful.
Thanks,
Vimala

Does anyone have a solution for this?  I am getting the same error on iOS.

Apologies for dragging up this old issue but I'm getting the same.

My code works fine under Android.
I've found the following hint at the "solution" but I've no idea what's involved ... https://stackoverflow.com/questions/57980689/writing-a-notification-descriptor-value-in-ios-using-bluetooth
Is it possible to add this feature / code fix ?

@mpfj That's actually my question and answer.  I'm not really sure why iOS doesn't let you hand write a characteristic into a different state.  In your iOS project, you'll need to create one or two classes that inherit from CBCentralManagerDelegate (to begin searching for devices, discover services, ) and CBPeripheralDelegate (to discover characteristics) to actually write to the characteristic you are looking for.

@jkandiko After looking at the BLE plugin source code, I can see that what I'm trying to do is already done for me by the plugin itself (when StartUpdatesAsync() is called)
I finally realised that my code (and the BLE plugin) is working fine ... the only code I need is:-
// open the uart service
svcUART = await App.mSelectedDevice.Device.GetServiceAsync(Guid.Parse("49535343-FE7D-4AE5-8FA9-9FAFD205E455"));

// init "tx" (device output) channel
chrTX_DeviceOut = await svcUART.GetCharacteristicAsync(Guid.Parse("49535343-1E4D-4BD9-BA61-23C647249616"));
chrTX_DeviceOut.ValueUpdated += OnReceiveData;
await chrTX_DeviceOut.StartUpdatesAsync();

// init "rx" (device input) channel
chrRX_DeviceIn = await svcUART.GetCharacteristicAsync(Guid.Parse("49535343-8841-43F4-A8D4-ECBE34729BB3"));


Markdown parser doesn't recognize CodeBlock inside QuotedBlock

Look at this piece of markdown, and how it renders, and then how it parses in FSharp.Markdown:
> __Annotation__
> This is an annnotation
> ```vb
> Module Module1
> End Module
> ```
> More annotation

Annotation
This is an annnotation
Module Module1
End Module

More annotation

But FSharp.Markdown parses the quoted block like this:

QuotedBlock

Paragraph

Strong

Literal "Annotation"

Literal "This is an annotation”
InlineCode "`vb\nModule Module1\nEnd Module"

Literal "More annotation"

It should parse it as a CodeBlock, but it's actually parsing it as an InlineCode.

It's even worse that that! If the QuotedBlock contains any InlineCode after the CodeBlock, then it parses wrong -- e.g.
> Hello
> ```vb
> Module1
> ```
> That was an `inline` code block

Here it renders That was an as an inline code block, and inline as regular text.

It also fails to parse an indented code block inside a quoted block, for example
> Hello
>     Module Module1
>     End Module
> World

What I expect here is a CodeBlock inside the QuotedBlock. But instead it rolls the indented code block just into the same single Literal that contains the rest of the stuff.

Any PR which brings us closer to the spec (http://spec.commonmark.org/0.22/) is very welcome. Adding unit tests is a big plus :)

I think that our handling of indented code blocks is correct. You are always required to have a blank line around the code. The CommonMark demo requires this too: here is a live demo.
However, we are not handling the fenced code blocks correctly. We require newlines there too. The following works:
> Hello
>
> ```vb
> Module1
> ```
>
> That was an `inline` code block

... and CommonMark does not require the newlines. So, if we can fix that, that would be nice. In the meantime, adding a newline should be a reasonable workaround...

I just merged a fix for this. @matthid should I do a release so that @ljw1004 does not have to add newlines :-) or do you have some other things planned?

I'm a big fan of fast releases and my PR will take a while to become green :)
One note though: I disabled the update of the releases branch (with the binaries) so if you still need it you should enable it before doing the release.


WFLY-16862 Hibernate Search engine module should have optional dependencies to other modules

https://issues.redhat.com/browse/WFLY-16862
I don't think this warrants a dedicated integration test since we're fixing a very exotic use case here.
I also noticed a module had a name that was not aligned with the corresponding Java module, so I took the liberty to fix that. That module was introduced in WF 27, so there's no backward incompatibility to fear.

Hello, yrodiere. I'm waiting for one of the admins to verify this patch with /ok-to-test in a comment.

/ok-to-test

This is one where we'll need to be sure the Galleon behavior is what we want when a slimmed server is provisioned.
The analogous deps were optional in 26 and earlier as well so there's nothing new here; my comment here is more along the lines of this PR being a good time to re-check the Galleon stuff.

As far as I can tell, there are failing tests in the "Galleon Linux - JDK 11" build, but those look like unrelated, flaky tests. At least two of them is also failing in other PRs that were merged: https://github.com/wildfly/wildfly/pull/15968 , https://github.com/wildfly/wildfly/pull/15958

my comment here is more along the lines of this PR being a good time to re-check the Galleon stuff.

Was that meant for me specifically, or a more general comment? If I'm supposed to add a Galleon-specific tests, I'm not sure where. Could you please point me to existing tests that provision a WF server using Galleon?

my comment here is more along the lines of this PR being a good time to re-check the Galleon stuff.

Was that meant for me specifically, or a more general comment? If I'm supposed to add a Galleon-specific tests, I'm not sure where. Could you please point me to existing tests that provision a WF server using Galleon?

Hey @bstansberry, I played around a bit with LayersTestCase (which I assume is "Galleon stuff"?). I can confirm that Hibernate Search modules (and their dependencies) do not get provisioned automatically by Galleon, probably because no other module depends on them.
We have some automation in org.jboss.as.jpa.processor.HibernateSearchProcessor to add dependencies to Hibernate Search when configuration properties related to Hibernate Search are detected; however, I'm not sure that's taken into account by Galleon. And in any case, such configuration properties are probably not set in LayersTestCase. So, users wanting Hibernate Search in their Galleon-provisioned servers will probably have to add an explicit dependency to Hibernate Search (both org.hibernate.search.mapper.orm and org.hibernate.search.backend.lucene/org.hibernate.search.backend.elasticsearch) to their deployment.
I updated LayersTestCase to reflect that. As far as I can tell, the problem is not new.
Does that address your concerns? Can we merge this PR and address the problem as part of a separate JIRA issue, since it seems unrelated to my changes?

Thanks @yrodiere!

@yrodiere The JIRA: https://issues.redhat.com/browse/WFLY-17004

Thanks @bstansberry!


No need to specify 'HBaseTableCatalog.newTable' option when saving data into an existing table

What changes were proposed in this pull request?
Now users need to specify 'HBaseTableCatalog.newTable' option when saving data into an existing table. It's unnecessary. This PR is to fix this issue.
How was this patch tested?
Pass the current test cases and add a new unit test.

@dongjoon-hyun Could you please help to review this PR? Thanks.

Thanks for the review. @dongjoon-hyun

Merged.

BTW, I forgot to mention this. This PR is tested locally and passes the test.


[French Number] Unit tests failing

It seems that some of the regexes are malformed. To look into this please fix first #13 and #14
@matthewshim-ms

@matthewshim-ms, this was also fixed in the last PR, right?

@tellarin correct, all unit tests pass right now for common use cases, and commented out niche cases per suggestion

@matthewshim-ms Cool. Closing this now then. :)


demo has v4 example removed

Connects to #38

I have successfully tested this both locally and on our PCF cluster. @izgeri maybe you could take over the CR since @micahlee is gone next week?

I'm merging this to unblock myself. Please review retroactively @izgeri and we'll fix any of your feedback in a follow up PR.


Py selenium j script click

Working - Able to scrap the web pages under the forums using selenium and store them under the "output" directory

LGTM


How to check if query result isn't empty in server side function?

OrientDB Version: 3.0.24
OS: Linux Ubuntu 18
OrientDB allows for creating server side functions by using "Functions Management" in OrientDB Studio. I'm using demo database and trying to find out if id from parameter exist in database (easy case). My problem is how to check if query result is empty? Code and more details below.
I have easy function in JS:
var queryResult = db.query('select Name from Castles where Id=?',id);
if(queryResult == null){
response.send(404,"Castle not found", "text/plain", "Error: Castle not found");
}else{
return queryResult;
}
When I run this function with parameter 1 (id=1) then I got execution result:
[ { "Name": "Castel Sant’Angelo" } ]
BUT (and here is a problem) when I do the same with parameter id=1234 then I got:
[
]
In second case I should get response "Error: Castle not found".
I tried change second line of code as:
if(queryResult == undefined)
if(queryResult["Name"] == null)
if(queryResult.length == 0)
and so on...but the result is the same.
I open this case on stackoverflow: https://stackoverflow.com/questions/58894384/orientdb-how-to-check-if-query-result-isnt-empty-in-server-side-function

Try the following:
var queryResult = db.query('select Name from Castles where Id=?',id); if(!queryResult.hasNext()){    print("empty"); } else {   print(" non empty"); }
Maybe as general idea: If you are unsure what kind of objects are returned, you can print .getClass() from an object to return its type e.g.:
queryResult.getClass()
which returns OLocalResultSetLifecycleDecorator -> you can look up this class in the orientdb api:
https://orientdb.com/javadoc/develop/com/orientechnologies/orient/core/sql/parser/OLocalResultSetLifecycleDecorator.html


Started ox_inventory client side types

Not a big start (literally just the openInventory export) but its a start...

Some exports are really going to need overloads to provide useful information, as different inventory types (e.g. 'crafting'|'container'|'drop'|'glovebox'|'trunk'|'dumpster') have vastly different inputs.
I do appreciate any help I can get, however - just noting that ox_inventory types are likely to be the most annoying to implement.

If you're working on more I'll leave this open.

If i can work out how todo that, i will certainly make a start