KYLIN-4224 Create flat table wich spark sql

Can one of the admins verify this patch?

@nichunen @hit-lacus Could you help review this pr, thanks!

Codecov Report

Merging #947 into master will decrease coverage by 0.03%.
The diff coverage is 0%.

@@             Coverage Diff              @@
##             master     #947      +/-   ##
============================================
- Coverage     25.58%   25.54%   -0.04%
+ Complexity     6140     6138       -2
============================================
  Files          1412     1414       +2
  Lines         85072    85176     +104
  Branches      11928    11935       +7
============================================
- Hits          21762    21755       -7
- Misses        61205    61313     +108
- Partials       2105     2108       +3

Impacted Files
Coverage Δ
Complexity Δ

...org/apache/kylin/engine/spark/SparkExecutable.java
0% <0%> (ø)
0 <0> (ø)
:arrow_down:

...a/org/apache/kylin/engine/spark/SparkSqlBatch.java
0% <0%> (ø)
0 <0> (?)

...va/org/apache/kylin/source/hive/HiveInputBase.java
6.69% <0%> (-1.07%)
4 <0> (ø)

...che/kylin/engine/spark/SparkCreatingFlatTable.java
0% <0%> (ø)
0 <0> (?)

...he/kylin/dict/lookup/cache/RocksDBLookupTable.java
72.97% <0%> (-5.41%)
6% <0%> (-1%)

...org/apache/kylin/rest/util/QueryRequestLimits.java
35.71% <0%> (-4.77%)
5% <0%> (-1%)

...he/kylin/job/impl/threadpool/DefaultScheduler.java
74.41% <0%> (-2.33%)
12% <0%> (ø)

...a/org/apache/kylin/dict/Number2BytesConverter.java
81.74% <0%> (-0.8%)
17% <0%> (-1%)

...rg/apache/kylin/cube/inmemcubing/MemDiskStore.java
69.6% <0%> (-0.61%)
7% <0%> (ø)

... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6b853ce...e74566c. Read the comment docs.

Pull Request Test Coverage Report for Build 5236

0 of 107 (0.0%)  changed or added relevant lines in 4 files are covered.
4 unchanged lines in 3 files lost coverage.
Overall coverage decreased (-0.04%) to 28.02%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

engine-spark/src/main/java/org/apache/kylin/engine/spark/SparkExecutable.java
0
2
0.0%

engine-spark/src/main/java/org/apache/kylin/engine/spark/SparkCreatingFlatTable.java
0
9
0.0%

source-hive/src/main/java/org/apache/kylin/source/hive/HiveInputBase.java
0
37
0.0%

engine-spark/src/main/java/org/apache/kylin/engine/spark/SparkSqlBatch.java
0
59
0.0%

Files with Coverage Reduction
New Missed Lines
%

core-cube/src/main/java/org/apache/kylin/cube/inmemcubing/MemDiskStore.java
1
78.12%

core-dictionary/src/main/java/org/apache/kylin/dict/lookup/cache/RocksDBLookupTable.java
1
81.08%

core-job/src/main/java/org/apache/kylin/job/impl/threadpool/DefaultScheduler.java
2
80.23%

Totals

Change from base Build 5229:
-0.04%

Covered Lines:
23866

Relevant Lines:
85176

💛  - Coveralls

@weibin0516 OK!

@weibin0516 Seems YARN_APP_URL not added to the step

Check list

[ ] Step 1. [OPTIONAL]Understand background/root cause/design basically(one hour EST) . Its issue type is

[ ] bug fix
[ ] new feature
[ ] enhancement

[ ] Step 2. Test cases are designed and documented (30 minutes EST).
[ ] Step 3. Prepare specific env, for example:

mock data (maybe some specific data type)
test env (maybe install a RDBMS instance).

[ ] Step 4. Verify and make sure test cases passed.
[ ] Step 5. Paste manual important steps and screenshots here (20 minutes EST).

If you find difficulty in pick most important evidence, please attach diagnosis package.

[ ] Step 6. Do more check in user perspective (20 minutes EST)

[ ] Doc need be updated? And if it is updated? Ask help for release manager if so.
[ ] If it is a breaking change so we should notify Kylin community? Ask help for release manager if so.

[ ] Step 7.  Summarize this test (20 minutes EST).

Total estimate

4 hours for small issue from optimistic estimate.

Note
If you find some unexpected and unrelated error/mistake, please DO report it if it is truly a mistake, I think we may research and fix it in the future.
If you find background information/root cause analysis is not complete or ambiguous, please try to contact to author or do a quick research and record what you find. It is a good chance to learn something interesting.
If you find it is not easy to design testcase, please notify release manager.

Design test cases
Prepare test env
Kylin sample cube
Case-1
Set 'kylin.engine.spark-create-table-enabled=true' in kylin.properties

Prepare data and env

[x] Built on commit_SHA : ae6120b849c499956a11814d817fb9506e6dd2d6

[x] Hadoop env : HDP 2.4

[x] Just sample cube is OK.

Verify test case
Case-1

Unexpected bug report

Container exit with error

Detail log

Diagnostics: Exception from container-launch.
Container id: container_e05_1585051378273_14708_02_000001
Exit code: 1
Exception message: /hadoop/yarn/local/usercache/root/appcache/application_1585051378273_14708/container_e05_1585051378273_14708_02_000001/launch_container.sh: line 16: $PWD:$PWD/__spark_conf__:$PWD/__spark_libs__/*:$HADOOP_CONF_DIR:/usr/hdp/current/hadoop-client/*:/usr/hdp/current/hadoop-client/lib/*:/usr/hdp/current/hadoop-hdfs-client/*:/usr/hdp/current/hadoop-hdfs-client/lib/*:/usr/hdp/current/hadoop-yarn-client/*:/usr/hdp/current/hadoop-yarn-client/lib/*:$PWD/mr-framework/hadoop/share/hadoop/mapreduce/*:$PWD/mr-framework/hadoop/share/hadoop/mapreduce/lib/*:$PWD/mr-framework/hadoop/share/hadoop/common/*:$PWD/mr-framework/hadoop/share/hadoop/common/lib/*:$PWD/mr-framework/hadoop/share/hadoop/yarn/*:$PWD/mr-framework/hadoop/share/hadoop/yarn/lib/*:$PWD/mr-framework/hadoop/share/hadoop/hdfs/*:$PWD/mr-framework/hadoop/share/hadoop/hdfs/lib/*:$PWD/mr-framework/hadoop/share/hadoop/tools/lib/*:/usr/hdp/${hdp.version}/hadoop/lib/hadoop-lzo-0.6.0.${hdp.version}.jar:/etc/hadoop/conf/secure:$PWD/__spark_conf__/__hadoop_conf__: bad substitution

Reason
hdp.version not set in kylin.properties


GH-35438: [Docs] Make corrections to the source docs

This PR adds corrections to the source docs to remove some of the warnings when building the documentation.

Closes: #35438

Thank you @raulcd !


K8SSAND-1244 ⁃ Removing a DC with size > 1 results in panic

What happened?
I had a cluster with 2 DCs, 3 nodes per DC. I removed DC2. The operator in the control plane crashed with a panic due to an odd number of key-value args in a log statement. Here is the stack trace:
2022-02-14T20:20:04.209Z	INFO	controller.k8ssandracluster	Reconciling replicated secrets	{"reconciler group": "k8ssandra.io", "reconciler kind": "K8ssandraCluster", "name": "test", "namespace": "k8ssandra-operator", "K8ssandraCluster": "k8ssandra-operator/test"}
2022-02-14T20:20:04.210Z	INFO	controller.k8ssandracluster	Proceeding with DC deletion	{"reconciler group": "k8ssandra.io", "reconciler kind": "K8ssandraCluster", "name": "test", "namespace": "k8ssandra-operator", "K8ssandraCluster": "k8ssandra-operator/test", "DC": "dc2"}
2022-02-14T20:20:04.270Z	DPANIC	controller.k8ssandracluster	odd number of arguments passed as key-value pairs for logging	{"reconciler group": "k8ssandra.io", "reconciler kind": "K8ssandraCluster", "name": "test", "namespace": "k8ssandra-operator", "K8ssandraCluster": "k8ssandra-operator/test", "ignored key": {"namespace": "k8ssandra-operator", "name": "dc2"}}
github.com/k8ssandra/k8ssandra-operator/controllers/k8ssandra.(*K8ssandraClusterReconciler).checkDcDeletion
	/workspace/controllers/k8ssandra/cleanup.go:147
github.com/k8ssandra/k8ssandra-operator/controllers/k8ssandra.(*K8ssandraClusterReconciler).reconcileDatacenters
	/workspace/controllers/k8ssandra/datacenters.go:28
github.com/k8ssandra/k8ssandra-operator/controllers/k8ssandra.(*K8ssandraClusterReconciler).reconcile
	/workspace/controllers/k8ssandra/k8ssandracluster_controller.go:133
github.com/k8ssandra/k8ssandra-operator/controllers/k8ssandra.(*K8ssandraClusterReconciler).Reconcile
	/workspace/controllers/k8ssandra/k8ssandracluster_controller.go:87
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Reconcile
	/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.10.0/pkg/internal/controller/controller.go:114
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).reconcileHandler
	/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.10.0/pkg/internal/controller/controller.go:311
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).processNextWorkItem
	/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.10.0/pkg/internal/controller/controller.go:266
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Start.func2.2
	/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.10.0/pkg/internal/controller/controller.go:227
panic: odd number of arguments passed as key-value pairs for logging

We have an e2e test for removing a DC. It only deploys a single node per DC, so it wouldn't hit this logging statement.
Did you expect to see something different?
No panic
How to reproduce it (as minimally and precisely as possible):
Deploy this K8ssandraCluster:
apiVersion: k8ssandra.io/v1alpha1
kind: K8ssandraCluster
metadata:
  name: test
spec:
  auth: false
  cassandra:
    serverVersion: "4.0.1"
    storageConfig:
      cassandraDataVolumeClaimSpec:
        storageClassName: standard
        accessModes:
          - ReadWriteOnce
        resources:
          requests:
            storage: 5Gi
    config:
      jvmOptions:
        heapSize: 512Mi
    datacenters:
      - metadata:
          name: dc1
        size: 3
      - metadata:
          name: dc2
        k8sContext: dev-2 # Update this according to you environment
        size: 3

After both dc1 and dc2 become ready, remove dc2 from the spec and apply changes.
Environment

K8ssandra Operator version:
v0.5.0

┆Issue is synchronized with this Jira Task by Unito
┆friendlyId: K8SSAND-1244
┆priority: Medium

I should be able to update an integration test to reproduce and cover this.


Recepies for Avaritia Leggings and shoes are default instead of edited

http://puu.sh/vuZUh/dfc13a718d.jpg
http://puu.sh/vuZVk/9a7b421eb9.jpg

Oh i see it has 2, thats fine ill close it


uglify breaks firebase.js

Moved here from: https://github.com/PolymerElements/polymer-starter-kit/issues/378
Steps to reproduce:
yo polymer
yo polymer:el test-firebase
bower install --save GoogleWebComponents/firebase-element
Insert a test-firebase tag in index.html(I put it above the my-greeting tag).
Inside test-firebase.html:
link firebase-document
above hello from test-firebase put a firebase-document tag
gulp serve:dist
Result:
blank page. Dev console has the Uncaught SyntaxError: Unexpected token ILLEGAL

Same problem here...
<script language="JavaScript" type="text/javascript" src="../../bower_components/jsrsasign/jsrsasign-latest-all-min.js"></script>

with maximumCrush='true' I get :
Message:
    Expecting UnicodeEscapeSequence -- uXXXX

and maximumCrush='false' :
Message:
    Line 240: Unexpected token ILLEGAL
Details:
    index: 258234
    lineNumber: 240
    column: 2902
    description: Unexpected token ILLEGAL

I am using the following vulcanize task  from the mobile app recipe:
// load polybuild
var polybuild = require('polybuild');

// Vulcanize granular configuration
gulp.task('vulcanize', function() {
  return gulp.src('app/elements/elements.html')
    .pipe(polybuild({maximumCrush: true}))
    .pipe($.rename(function(file) {
      if (file.extname === '.html') {
        file.basename = file.basename.replace('.build', '');
      }
    }))
    .pipe(gulp.dest(dist('elements')))
    .pipe($.size({title: 'vulcanize'}));
});

I tried creating a non-minified version of jsrsasign (polybuild only choke on the minified version) but it is a cross-dependency nightmare and gave up.

This seems to be related :
https://github.com/mishoo/UglifyJS2/issues/544

I don't think uglify is the problem... If I comment out this line :
  .pipe(crush ? uglify : leftAlign)

polybuild succeeds... but then my application crashes at runtime with the same error:
So I run HTMLPrettify on elements.build.js to see what line was causing the problem :
elements.build.js:9213 Uncaught SyntaxError: Unexpected token ILLEGAL
9213:   if (f--\x3e0) {

What I don't understand is where that \x3e0 comes from because the code in question is jsbn.js (http://www-cs-students.stanford.edu/~tjw/jsbn/)
and the original line is  if (f-- > 0) { ... and the non-minified version is   if(i-- > 0) {

The problem is with vulcanize....
I ran vulcanize --inline-scripts app/elements/elements.html
and that f (f-- > 0) was changed to if (f--\x3e0)

+1, same issue

+1 firebase + polybuild (uglify) broken

This was fixed in vulcanize 1.14.7

@justinfagnani, just ran again and have the same issue. Has the dependency for vulcanize been updated for polybuild?

No, but a fresh npm install should pick up the latest version.

npm uninstall polybuild followed by npm install polybuild results in the same...

argh, npm is terrible :(
The constraints from polybuild -> gulp-vulcanize -> vulcanize should pick up 1.14.7
I'll have to file a request over at gulp-vulcanize to update their constraints.

Filed https://github.com/sindresorhus/gulp-vulcanize/issues/36

Awesome! Mind re-opening until that is updated considering Polybuild is still afflicted?

Sure thing

Also, just to make sure I'm not crazy, I'll manually update gulp-vulcanize in my own node_modules folder and see if it indeed works.

Make sure you're picking up vulcanize 1.14.7 in there

So, I made sure that vulcanize in my node_modules folder was v1.14.7 (and gulp-vulcanize simply does require('vulcanize'), so it should be the right version). But, the resulting files are still broken, and they are broken the same way as before (as described in my first comment above).

Hi.
Any good new about the issue?
I've tried to use the follow code to remove firebase.js from vulcanizing, but it's not removing it.
gulp.task('vulcanize', function () {
  return gulp.src('dist/index.html')
    .pipe($.vulcanize({
      stripComments: true,
      inlineCss: true,
      inlineScripts: true,
      excludes: [path.resolve('./dist/bower_components/firebase/firebase.js')]
    }))
    .pipe(polybuild({maximumCrush: false}))
    .pipe(gulp.dest('dist/'));
});

How can I properly avoid firebase.js from being vulcanized?

Hi,
It's not very clean, but it works, in waiting :
<script async>
            var script = document.createElement('script');
            script.async = true;
            script.src = 'firebase.js';
            document.head.appendChild(script);
        });
</script>

@spirylics, it looks like you have an extra set of closing brackets/parenthesis });, just wondering if this is an accidental addition or an accidental omission of something from the beginning.

@mm-gmbd , It's an accidental addition :) Thanks

I'm still having an issue with this. I'm on vulcanize 1.14.8 and gulp-vulcanize 6.1.0. I'm not sure what to do with @spirylics snippet above.

@evancaldwell, I actually meant to follow up on this and never did. @spirylics, does the script you provided just get inserted somewhere in the index.html? I presume that it's position is important, but I'm with @evancaldwell and am not really sure (also, I haven't tested -- sorry!)

This script posted above will replace your firebase script declaration. Like that uglify don't see firebase js and don't touch it !

hmm.. @spirylics maybe my setup is different, I'm using Firebase polymer elements so the firebase script declaration is actually in bower_components/firebase-element/firebase.html

Ok I see. In your case you can use importHref from Polymer utility fonctions : https://www.polymer-project.org/1.0/docs/devguide/utility-functions.html
The idea is to import dynamically firebase (script or html) to hide it of vulcanize / uglify...

@spirylics sorry for my noobness, a couple further questions: should I be using importHref in my index.html? Also won't I still get an error after everything is vulcanized because I'm still importing the firebase elements that are causing the error?
@samcarecho were you ever able to fix up the gulp task to exclude firebase.js?

Yes you can use importHref in your index.html. Just, you have to use firebase-element when firebase-element.html is loaded ; so use onload argument of importHref.

@evancaldwell the project on which I was working is using polybuild.
I did not manage to exclude firebase from it.

@mm-gmbd I am experiencing the same issue -  Invalid or unexpected token when vulcanized. I have updated the version of vulcanize etc. Did you manage to resolve?

@dChin84 - unfortunately, I never resolved this on my end. I couldn't track down the underlying tool that was causing the parse error, so I ended up just leaving. However, it's been so long now that Firebase has released an entirely new set of libraries/SDKs (v3), does that mean this issue persists into v3 (or are you still using a v2 lib)?

@mm-gmbd Thanks for your response. It's looking like the issue is still present I am using v3 of the SDK :(

OMG,
Is this still an issue?
Can´t believe no one from Google is capable of fixing it! :O
On Tue, Dec 13, 2016 at 5:53 PM, Daniel Chin<EMAIL_ADDRESS>wrote:

@mm-gmbd https://github.com/mm-gmbd Thanks for your response. It's
looking like the issue is still present I am using v3 of the SDK :(
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/PolymerLabs/polybuild/issues/27#issuecomment-266794074,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAyrA3CQuwLoY4u8MWuIr9Se9CmjaHw5ks5rHs2BgaJpZM4HKowT
.

@samcarecho - I'm with you. This should have been fixed a long time ago, especially considering that both of these are Google products/projects...

I managed to work around the issue by modifying polymerfire removing the references to firebase so they don't get vulcanized and then including firebase-sdk as script references within the main page. Google please fix as this is far from a decent solution

Any plans to solve this issue? It is affecting production
Thanks

@fernandezpaco we've removed uglify in favor of Babli from Polymer CLI. That change will be out in the next release. If you're still using polybuild, we recommend switching to the CLI or the polymer-build library, which is what powers the CLI.

Hi @justinfagnani,
I work with @fernandezpaco and we've made a POC including the rxjs.lite.min.js in a new app created from scratch with Polymer-cli. We just include the script in my-app.html.
We've included a gulp task to build it as it's explained in generator-polymer-init-custom-build.
We still have the same problem that @zboralski reported. Inside rxjs.lite.min.js there's a this._r-->0  which is replaced by this._r--\x3e0 and breaks the execution.
In the current vulcanize task (now renamed to polymer-bundler) we could narrow the problem down to the Uglify2JS run by inlineScripts in this line.


Remove defunct bindgen argument

The --no-unstable-rust flag was removed was removed in bindgen 0.26.x and
replaced with an --unstable-rust flag. Now we do not need to provide any flag
to avoid generating unstable rust.

Hey @anxiousmodernman, thanks for the PR, sorry it fell through the cracks!
Which version of Bindgen did this change with? Could you please update the documentation to reflect which version of Bindgen you are talking about?
If you update the docs (README.md and SETUP.md, maybe others), I'd be happy to merge!

Bindgen's moved along a bit. I will need to check this against latest to see the behavior.

Some investigation into these cli flags:

Argument parser in bindgen 0.25.5
...and in bindgen 0.26.0 when it changed
...and in the latest 0.30.0

I'm going to build with the latest bindgen. If it checks out, I'll update the docs to reflect 0.30.0

With bindgen 0.30.0, "blinky" built fine, but "ble_app_template" gave me errors.

This may be a difference in generated code, or it may be something with the rust-src/component/toolchain It seems like these are standard library traits, so perhaps I didn't get that downloaded correctly.

I've tested this on a couple of machines now. The latest bindgen breaks the example for bindgen 0.30.0 on the ble_app_template example.
The problem is this type is no longer generated, and the compiler complains about the missing methods as_ref and as_mut.
/* present in code generated by bindgen 0.26.3 and earlier, missing in 0.30.0 */
#[repr(C)]
pub struct __BindgenUnionField<T>(::core::marker::PhantomData<T>);
impl <T> __BindgenUnionField<T> {
    #[inline]
    pub fn new() -> Self { __BindgenUnionField(::core::marker::PhantomData) }
    #[inline]
    pub unsafe fn as_ref(&self) -> &T { ::core::mem::transmute(self) }
    #[inline]
    pub unsafe fn as_mut(&mut self) -> &mut T { ::core::mem::transmute(self) }
}

The new 0.30.0 generated code uses the bleeding edge-ish contextual keyword union. With a few changes, I can get the example to compile. The fields on the generated struct can be get and set directly.
I've only built the code, but not flashed it to a dev board. I'll try that next.

@jamesmunns ready for review: I've tested the bluetooth and blinky example on the dev board using this branch and bindgen 0.30.0, flashed it to the dev board, and things seem normal.

Looks good to me! Thanks so much for following up with this. I noticed the Dockerfile needed to be update, so I pushed a quick patch for that as well.


Automated cherry pick of #1228: fix zstack cdrome error

Cherry pick of #1228 on release/2.10.0.
#1228: fix zstack cdrome error

Codecov Report

:exclamation: No coverage uploaded for pull request base (release/2.10.0@f7c2a9c). Click here to learn what that means.
The diff coverage is 0%.

@@               Coverage Diff                @@
##             release/2.10.0   #1235   +/-   ##
================================================
  Coverage                  ?   7.95%
================================================
  Files                     ?     367
  Lines                     ?   57295
  Branches                  ?       0
================================================
  Hits                      ?    4560
  Misses                    ?   52337
  Partials                  ?     398

Flag
Coverage Δ

#aFlag
7.95% <0%> (?)

Impacted Files
Coverage Δ

pkg/util/ucloud/instance.go
0% <ø> (ø)

pkg/util/aws/instance.go
0% <ø> (ø)

pkg/compute/models/guest_actions.go
0% <0%> (ø)

pkg/util/esxi/virtualmachine.go
0% <0%> (ø)

pkg/compute/guestdrivers/utils.go
0% <0%> (ø)

pkg/compute/guestdrivers/managedvirtual.go
0% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f7c2a9c...4e34a37. Read the comment docs.

/lgtm
/approve


Snake game

PR Description 📜
🎮 Game Request
A Snake will be inside a box and will be moved on the basis of an arrow
top
bottom
left
right
If hit the wall then the game will be over if he will eat the "feed" then its length will increases as well as score will also.
Point down the features
Game points.
it can be played on mobile as well as on laptop (Device Friendly)
The smoothness of Game without any lag
Fixes #149

Mark the task you have completed ✅

[x] I follow CONTRIBUTING GUIDELINE & CODE OF CONDUCT of this project.
[x] I have performed a self-review of my own code or work.
[x] I have commented my code, particularly in hard-to-understand areas.
[x] My changes generates no new warnings.
[x] I have followed proper naming convention showed in CONTRIBUTING GUIDELINE
[x] I have added screenshot for website preview in assets/images
[x] I have added entries for my game in main README.md
[x] I have added README.md in my folder
[ ] I have added working video of the game in README.md (optional)
[x] I have specified the respective issue number for which I have requested the new game.

Add your screenshots(Optional) 📸

Thank you soo much for contributing to our repository 💗

Thank you @iamsuyashpatel07 ,for creating the PR and contributing to our GameZone 💗
Review team will review the PR and will reach out to you soon! 😇
Make sure that you have marked all the tasks that you are done with ✅.
Thank you for your patience! 😀

Hey @iamsuyashpatel07 👋!
@kunjgit here,
We have this annoucement to make 📢!!
We have updated our README 🚀
Make sure you follow proper guideline to raise your next issues !!
Make sure you join our Discord🕹 if you haven't 😇
Thank you 💗!

Hey @kunjgit ,
I read the updated readme file and according to that my pr and issues match. If you still feel that something is wrong then please let me know what is not matching.....
(P.S: Joined the discord channel I will love to have conversions with you there.)

Hey @iamsuyashpatel07 !! we are already having the Snake game on the site and it is conflicting with it !!
if you want to make changes you can have enhancement !!
as someone who will come up with unique idea first then you can have enhancement in that you can clearly see that #59 is the first one to come with the idea !!
Looking forward to have your enhancement !!

Thank you  @iamsuyashpatel07 , for your valuable time and contribution in our GameZone 💗.
It’s our GameZone, so Let’s build this GameZone altogether !!🤝
Hoping to see you soon with another PR again 😇
Wishing you all the best for your journey into Open Source🚀


Always use software GFX for windows client.

Allows windows client to work in GFX mode without adding /gdi:sw

@akallabeth how come?

@akallabeth my suggestion would be to add a warning that gfx doesn't use hw gdi when /gdi:hw is used.


Adding a filter for genre of movies in Home page

FIXED #54   Adding filter for genre of movie
Here is the description of  the filter
The filter is for    - [All , Horror , Action , Adventures , Drama]
I have made changes in Home.js and Home.css
Iam a contributor in gssoc and Hoctoberfest

If my PR accepted , Kindly assign me the label for the level of issue

@Nikitaganeshbabu Please specify your issue number while raising PR.
just edit comment in this PR.
for example:
fixed #<replace_with_issue_number> Added a filter for genre of movies in Home page

this is my first ever contribution . Iam not aware of this .I didn't make any changes . Should I make a new PR or you can remove it from pushing ?

I made changes only in Home.js and Home.css

@Nikitaganeshbabu Okay, I will fix it no need to raise new PR.

Kindly review my code

@Nikitaganeshbabu You messed with some functionalities of the code which was previously contributed by others. It takes time to fix that.


How to build a PSID to call CreateWellKnownSid

Hi!
I am trying to port a project of mine from winapi to windows-rs and could not find example code or documentation to call CreateWellKnownSid correctly.
Here is what I tried:
fn main() {

    const SECURITY_MAX_SID_SIZE : isize = 68isize;
    const WinBuiltinAdministratorsSid : WELL_KNOWN_SID_TYPE = WELL_KNOWN_SID_TYPE(26i32);

    unsafe {
        let mut admin_sid = PSID(SECURITY_MAX_SID_SIZE);
        let mut sid_size = (std::mem::size_of::<u8>() as u32 * SECURITY_MAX_SID_SIZE as u32);
        let domain_sid = PSID::NULL;

        if CreateWellKnownSid(WinBuiltinAdministratorsSid, domain_sid, admin_sid, &mut sid_size) == BOOL(0) {
            println!("CreateWellKnownSid failed {:?}", GetLastError());
        }
        else {
            println!("CreateWellKnownSid succeeded");
        }
    }
}

As is, this code just does an access violation because my "admin_sid" parameter is all but correctly initialised.
It seems the issue is with this third argument (that should be 'out' but is only PSID in metadata).
Complete repro:
create_well_known_sid.zip
Thank you for bringing "officially" the breadth of Windows APIs to Rust!

The pSid parameter has the [Out] attribute in the metadata referenced by version 0.11.0 of this crate:

Are you using an older version of the windows crate?

Nope, I tested with 0.11.0 (latest).
I surely miss something to allocate this parameter properly  pior to calling this API.

The trick is that CreateWellKnownSid doesn't allocate the SID - it expects the caller to provide a buffer and it will dutifully fill in that buffer. Here's an example:
use bindings::{Windows::Win32::Foundation::*, Windows::Win32::Security::*};

fn main() -> windows::Result<()> {
    unsafe {
        let buffer: [u8; 32] = [0; 32];
        let mut buffer_len = buffer.len() as u32;
        let sid = PSID(buffer.as_ptr() as _);

        CreateWellKnownSid(
            WinBuiltinAdministratorsSid,
            PSID::NULL,
            sid,
            &mut buffer_len,
        )
        .ok()?;

        assert_eq!(GetLengthSid(sid), buffer_len);
        println!("length: {}", buffer_len);
        println!("{:?}", buffer);

        Ok(())
    }
}

Also, you may be interested in the windows-permissions crate, which abstracts away Sid handling behind a safe API. Though it uses winapi and not windows-rs for its bindings.

Somebody should port it. 😉

Verified solved with your great help!
Thanks!


Fixes #3479: Implement Progress Bar for Zoom Activity

Implement Progress Bar for Zoom Activity
Fixes #3479  Add progressbar to new Media details zoom activity
Added Circular Loading ProgressBar to the Zoomable view hierarchy

Codecov Report

Merging #3481 into master will decrease coverage by 0.01%.
The diff coverage is 0%.

@@             Coverage Diff             @@
##             master   #3481      +/-   ##
===========================================
- Coverage      7.15%   7.14%   -0.02%
  Complexity      298     298
===========================================
  Files           266     267       +1
  Lines         11935   11960      +25
  Branches        974     975       +1
===========================================
  Hits            854     854
- Misses        11011   11036      +25
  Partials         70      70

Impacted Files
Coverage Δ
Complexity Δ

...va/fr/free/nrw/commons/media/ZoomableActivity.java
0% <0%> (ø)
0 <0> (ø)
:arrow_down:

...Controllers/loading/CircleProgressBarDrawable.java
0% <0%> (ø)
0 <0> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 99c6f5f...8bf1d64. Read the comment docs.

@kbhardwaj123 can you post a picture of this change?

sure @macgills here it is :)

the blue circle is the progress bar

The circle is actually an oval and it seems to give a poor indication of progress, it appears at ~95% complete and then just advances a little bit

@macgills thanks for bringing that to notice, i realised that the progressbar appears for time between successful submission of request to final Image being set and does not account the time to register the request (which takes considerable time) so i have added an in-deterministic spinner for that , apart from that the progressbar seem to be circular for me but i will check that again

@kbhardwaj123 @macgills This circle progress seems to be a little inconsistent with the UI, I think it is better to use the regular ProgressDialog which we are using throughout the app.

Still very very oval. If you can just get rid of the oval I am fairly happy with the indeterminate progressbar.
@madhurgupta10 ProgressDialogs are deprecated since 26 because they are terrible UI/UX
* @deprecated ProgressDialog is a modal dialog, which prevents the
 * user from interacting with the app. Instead of using this class, you should
 * use a progress indicator like {@link android.widget.ProgressBar}, which can
 * be embedded in your app's UI. Alternatively, you can use a
 * notification
 * to inform the user of the task's progress.

If we are using them we should really stop

@macgills oh that's really oval, I will fix that for sure

@macgills

If we are using them we should really stop

We can create a separate issue for replacing all ProgressDialog with ProgressBar, after this PR is merged. I would be happy to make the changes.

@madhurgupta10 feel free to create that ticket, it might be non trivial as there could be other UI concerns due to replacing them so it might be best to do it piece by piece, I haven't looked at the usages yet

Currently it looks okay I guess:

Thanks @kbhardwaj123 :)


Extension Host terminated unexpectedly

Description

VSCode Extension Host crashed by mocha-sidebar, maybe memory leak.
Steps to Reproduce

Open repository
Open Task Manager to monitoring
CPU usage rise to 100%, memory usage increasing about 50MB/s
VSCode reports 'Extension Host terminated unexpectedly'

Expected Results

Actual Results

Settings file

{
  "mocha.files.glob": "test/**/*.ts",
  "mocha.requires": [
    "ts-node/register",
    "source-map-support/register"
  ]
}

Versions

VScode: v1.35.0
Mocha SideBar: v0.22.2
Node Version: v10.15.3

OS version

[x] Linux
[ ] Mac
[x] Windows

Example for reproducing

https://github.com/studentmain/cherow-mod-tjs

tks ill try to reproduce it with your example

Any update on this?? I am also facing the same issue. Although for me, the extension doesn't terminate, it ends up using way too much memory.


studio/guide: merge How it Works; flatten Views and Exps

Depends on https://github.com/iterative/dvc.org/pull/3621

Merge similar info. from Studio docs homes, How it Works page (gone), and Prepare your repos

[x] Merge all info about views projects into one guide
[ ] Merge all info about experiments into another guide

[ ] Un-burry guides under UG -> Views Projects and Experiments

Extracted from https://github.com/iterative/dvc.org/pull/3621#pullrequestreview-995958843

@jorgeorpinel ok, let's revisit this later.

@tapadipti @jorgeorpinel any updates here?

@shcheklein No, we have not discussed this recently.
@jorgeorpinel it would be good to restructure the docs a bit to "un-bury guides" as you have stated. But in the form in this PR, the pages are going to be quite long. Eg, I looked at the content/docs/studio/user-guide/projects.md page, and it's very long.
I think it'll be good to tackle this in steps - first, let's split the projects and experiments contents. Then, we can improve further.
Also, the following types of changes can be a different PR, coz they aren't about the structure:

Let me know what you think about when we can work this out. I'm currently working on the Live Metrics docs, and the feature is expected to go live in 1 week or so. So any restructuring would have to be done either within 1-2 days or would have to wait until the Live Metrics docs are released.

It'll be easier to start over at this point since there are so many conflicts per other changes to Studio docs.


Provide unique, consistent user identifier for repeated authentication attempts

When authenticating with VC-AuthN, there are currently two options for generating a subject_identifier for the authenticated user:

Using one of the proof-request attributes, if available and configured in the proof-configuration
Generating a new identifier for each authentication attempt

The first option is only available IF the VCs used to authenticate provide a unique identifier: this would be configured in the proof-configuration to be used as sub, and would be passed along to the relying party that initiated the authentication request.
The issue with this pattern when integrating VC-AuthN into an AIM system such as Keycloak is that, unless a unique user identifier is generated by VC-AuthN, it will not be possible to associate roles to the user account in the AIM system as every authentication attempt will appear as a new user trying to access the system.
Proposed solution:
Rather than generating a new random user identifier for every authentication attempt, VC-AuthN would generate a consistent user identifier by hashing a canonicalized version of the JSON containing the claims obtained from the proof-request.
Possible library to canonicalize JSON: https://pypi.org/project/canonicaljson/
The underlying Pyop library will generate a new value for the sub if non is provided. A couple of places we could look at plugging-in the generation of the subject identifier value:

here to generate the sub BEFORE pyop takes over to generate the token
by implementing a new SubjectidentifierFactory matching our criteria and injecting it in the code at the right time (here).

coverage: 94.413%. remained the same
when pulling 6f4e9a285910fad60fd7f17b99dd7712b2849147 on 376-unique-consistent-user-identifier
into ac7c5e7b025c70ddd58523391ece108c4178bae0 on main.


Ability to request all movies for actors/actresses

Description
Ability to add/follow actors/actresses to auto request all movies/shows.
Desired Behavior
Click follow on actor a pop up asking to request
All show/movies
All previous movies/show
Only new movies
Additional Context
No response
Code of Conduct

[X] I agree to follow Overseerr's Code of Conduct

Also, it should be supported to...

only watch new shows (movies unset)
All movies (shows unset)
all shows (movies unset)
Request nothing, only favorite (to feed the recommendations algorithm and bookmark the actor so to speak for on-demand discovery)


Switched to pg-index-health v.0.7.0

Codecov Report
Base: 98.61% // Head: 98.61% // No change to project coverage :thumbsup:

Coverage data is based on head (55cfc97) compared to base (ef1a44d).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff            @@
##             master      #36   +/-   ##
=========================================
  Coverage     98.61%   98.61%
  Complexity       33       33
=========================================
  Files            10       10
  Lines            72       72
  Branches          1        1
=========================================
  Hits             71       71
  Misses            1        1

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Decompose Fe -> Yul compiler pass

Currently, we have a single compiler pass that maps Fe ASTs generated by the parser to Yul. This pass is responsible for both context-sensitive analysis and mapping Fe to Yul. As the project grows in complexity, it will become difficult to manage both of these responsibilities in one pass and would result in a codebase that's difficult to audit.
We can improve the situation by introducing a pass before the Fe to Yul mapper that is responsible for both deeper validation of the source program and for providing the mapper pass with enough information to correctly map expressions.
Let's illustrate with the guest book contract:
/* guest_book.vy */
type BookMsg = bytes[100]

contract GuestBook:
    pub guest_book: map<address, BookMsg>

    event Signed:
        idx book_msg: BookMsg

    pub def sign(book_msg: BookMsg):
        self.guest_book[msg.sender] = book_msg

        emit Signed(book_msg=book_msg)

    pub def get_msg(addr: address) -> BookMsg:
        return self.guest_book[addr]

Compilation of the returned expression in get_msg goes roughly like this:
context/mapper pass

gets the type of self.guest_book from the contract scope and maps it to a Yul expression (its storage index) then returns this information to the caller.
gets the type information for addr from the function scope and maps it to a Yul expression then returns this information to the caller
determines the type of self.guest_book[addr] given the type of self.guest_book and maps it to a Yul expression then returns this information to the caller

It should instead go like this:
context pass

gets the type of self.guest_book from the contract sope and stores it
gets the type of addr from the function scope and stores it
determines the type of self.guest_book[addr] and stores it

mapper pass

maps self.guest_book to a Yul expression given the expression type from the previous pass
maps addr to a Yul expression given the expression type from the previous pass
maps self.guest_book[addr] to a Yul expression given the expression type from the previous pass

The second method separates concerns nicely and conforms more closely with standard compiler design.
todo:
Determine what the data structure built up by the context pass should be.

I've written some code to express how I think this should be done.
In the existing single pass compiler, we gather information about context using shared Scope instances that are linked together. When certain elements of the Fe AST are being mapped to Yul, we access the given scope to lookup whatever information is needed. Similarly, when we map Fe expressions to Yul, we return extra data (in the form of an  ExtExpression) and use that to better understand how Yul expressions should be formed.
I suggest that we remove all of the context-understanding work being done in the compiler pass and replace it with a single immutable context instance that is made accessible to each mapper function. It would contain general information about the module and would map contextual information to AST elements using their span as a unique key. This context instance would be built by a semantic analysis pass that takes place just before Fe -> Yul compilation.
pub struct Context {
    expressions: HashMap<Span, Expression>,
    ...
}

Partial definition of Context.
Spans are structs generated by the parser that tell you where in the source program a given AST element is located. Below, I've annotated the same expression discussed in the initial comment with spans and show how they would be used to lookup relevant information in the context instance.
              span 3
                |--|
self.guest_book[addr]
|-------------|
     span 2
|-------------------|
       span 1

id
type
location

span 1
bytes[100]
Memory

span 2
Map<address, bytes[100]>
Storage

span 3
address
Value

The crucial difference with this approach is that our compiler pass is not responsible for juggling things like scope or figuring out expression types. Instead, it just looks up information about AST elements by their span.
The semantic analysis pass would look pretty similar to the existing compiler pass, in that we would still be using the same AST traversal functions and data structures (like scope). The only difference is that it would not be creating a Yul AST, but would instead be building up context information and validating semantics.
Implementation of this refactor would involve a few things:

[ ] create a new lib called semantics
[ ] copy the namespace module into the semantics lib
[ ] copy the existing AST traversal functions in the compiler lib to the semantics lib and refactor them to build a Context instance, instead of generating Yul
[ ] remove all uses of the namespace mod in the compiler pass and replace with the use of Context

The first 3 steps can be done without touching the compiler lib and the final step shouldn't be terribly complicated.


Restarting controller manager admits all workloads

What happened:

Restarting Kueue controller (common occurence when leader election fails), admits all previously finished workloads.

What you expected to happen:

Finished workloads, must not be queued and admitted to Q and CQ.

How to reproduce it (as minimally and precisely as possible):

Submit 2 jobs, with sleep 5; exit 0 and sleep 5; exit 1, one job suceeds and other fails.
Both the workloads are marked as Finished.
Rollout restart to the Kueue controller, and both the workloads will be re-admitted, though the workloads are marked Finished.
Q resources are never released, until the workloads are deleted.

Anything else we need to know?:
Log attached.
manager-001.log
Environment:

Kubernetes version (use kubectl version): 1.27.0
Kueue version (use git describe --tags --dirty --always): v0.5.0, v0.5.1, v0.5.2, v0.6.0-rc.1
Cloud provider or hardware configuration: minikube
OS (e.g: cat /etc/os-release):
Kernel (e.g. uname -a):
Install tools:
Others:

Related comment - https://github.com/kubernetes-sigs/kueue/issues/1450#issuecomment-1887308576
Helped but does not solve the issue - https://github.com/kubernetes-sigs/kueue/pull/1572


net, dns: Move most of the dns subpackage under network

What this PR does / why we need it:
The existing util/net/dns subpackage is left with the sanitizer
helper which requires knowledge of the VMI structure.
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #
Special notes for your reviewer:
Release note:
NONE

/assign @AlonaKaplan

/approve


Adding buttons to the Web Chat Channel

Hi,
Is it possible to add buttons similar to the quickreplies buttons?
Thanks

Webchat doesn't support buttons today.  This is something we'd like to add soon.


use git submodule path in /dataset

Thanks for thanks to create great packages :)
It's better to sync /holiday_jp/datasets yml files.
golang, java, elixir is alredy use gitmodules :)

golang: https://github.com/holiday-jp/holiday_jp-ruby
java: https://github.com/holiday-jp/holiday_jp-java
elixir: https://github.com/ne-sachirou/holiday_jp-elixir

@4geru
Thanks for the push!


python3Packages.mkdocs-material-insiders: init at 9.5.40-insiders-4.53.14

(Same as #343788, renamed branch in my repo. Apologies for spam.)
Insiders version of Material for MkDocs
Depends on #344615
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Please squash updates into the init commits. LGTM otherwise

Just did so, feel free to have another look!


feat(Topology/Sheaves/Stalks): Generalize to stalkPushforward_iso_of_inducing

port of https://github.com/leanprover-community/mathlib3/pull/17539

Thanks!
maintainer merge

bors merge


Recent Blog Articles Page

Feature Request
New page using CarouselView and IndicatorView to show recent blog articles.
Blog RSS: https://blog.taranissoftware.com/rss.xml
Expected Behaviour
Articles should look similar to cards on my readme and include the intro section of the article (up to the first <h2>). Tapping a card will open the article in the default browser. Cache the rss for 1 hour.

Possible settings:

Update data only on non-metered connection
Open links in internal / external browser

Additional Context
Some cover images are webp format, others are png. Can MAUI handle webp format?
Does MonkeyCache work in MAUI? If not is there an alternative?
Linked To

webp images work on Android & Windows, need to test iOS.

MonkeyCache seems to work but creates a lot of warnings like the following about MonkeyCache and its dependencies:
NU1703: 'MonkeyCache 1.5.2' was resolved as a dependency of 'MauiBeach', but the dependency is using 'Xamarin.iOS' while 'MauiBeach' is using 'net6.0-maccatalyst15.0' as its TargetFramework. There might be compatibility issues when MacCatalyst projects depend on Xamarin.iOS projects.
Tested on Android & Windows, I have no way to test MacCatalyst.


Blacklist PAR regions in TargetCoverageSexGenotyper

Issue: cross reads from X to Y in PAR regions lead to problematic sex inferences. In a cohort of 112 sex annotated samples, a single XX -> XY misclassification was noticed, which was identified to be due to large number of reads aligned to the Ychr PAR region.
Solution: the tool must take an interval list for "blacklisted regions" and neglect targets lying in that region while calculating likelihoods of different sex genotypes.

Unfortunately Shaila, who's been visiting the MacArthur lab for a few months, isn't around much longer.  She did a lot of chrX work in grad school and we talked a lot about variant filtering strategies for X.  There is an interval list for the PAR in UCSC or somewhere similar, but she said that according to population genetics theory, it's not static so it will be slightly different in different individuals and will change with time (probably dozens of generations at least.)  I think for your purposes the published intervals will probably be fine, but I wanted to note that the PAR isn't perfectly defined.

Thanks @ldgauthier, interesting huh... I'm curious to understand the microscopic mechanism responsible for the drift of PARs in the offsprings. Anyway, like you said, we'll be fine working with published intervals (we can also pad them a bit for good measure). Also, the PAR "blacklist" table is going to be a flexible user input.

And Konrad pointed out there's a PAR3 in some people (about 2% of the population): http://link.springer.com/article/10.1007%2Fs10142-013-0323-6  Chromosome X is like the wild west.  But Monkol is super excited about CNV calls on X!

This is addressed in https://github.com/broadinstitute/gatk-protected/pull/695
Closing.


[spec compliance] Implement Outputs in Kubernetes Driver

Now that we have mostly added all the relevant output definitions and claims elements, we should complete the picture and implement output handling in the Kubernetes driver. The Kubernetes driver currently handles placing parameter and credentials into files for the invocation image, so we should extend the driver to handle obtaining them from the invocation image, maybe by adding a volume to store the outputs and reading from that?
I think we should leave what happens to them after they are read from the invocation image up to the end tooling, but we should make the driver able to fetch them.

We summarized our thoughts on implementation options for the k8s driver here: https://github.com/deislabs/duffle/issues/747#issuecomment-512048160


The worker does not affect the hash suffix of the bundles.

Describe the bug

The worker does not affect the hash suffix of the bundles.

System Info
Output of npx envinfo --system --npmPackages vite,@vitejs/plugin-vue --binaries --browsers:
  System:
    OS: macOS 11.2.3
    CPU: (12) x64 Intel(R) Core(TM) i7-9750H CPU @ 2.60GHz
    Memory: 133.57 MB / 16.00 GB
    Shell: 5.8 - /bin/zsh
  Binaries:
    Node: 15.3.0 - ~/.nvm/versions/node/v15.3.0/bin/node
    Yarn: 1.22.10 - ~/.nvm/versions/node/v15.3.0/bin/yarn
    npm: 7.0.15 - ~/.nvm/versions/node/v15.3.0/bin/npm
  Browsers:
    Chrome: 89.0.4389.90
    Edge: 89.0.774.63
    Safari: 14.0.3
  npmPackages:
    @vitejs/plugin-vue: ^1.1.5 => 1.1.5
    vite: ^2.1.5 => 2.1.5

Used package manager:  pnpm

Closing this issue because the issue template was not respected. Please create a new one that includes a minimal reproduction so it is easier for others to debug the problem.


Add tests to new rest endpoint

https://github.com/gchq/Gaffer/issues/2690 added a new endpoint to the spring-rest api, this should have unit tests.

Closed by https://github.com/gchq/Gaffer/pull/2700


Avoid prepending a "/"

Please avoid prepending the full path with a slash ("/"). It does not work on windows.

@GENL thanks for reporting . can you make a pull request to handle this ?

merged .


SCSS does work, but there's no compiled CSS file anywhere in the app directory

Hi,
I'm not sure exactly how this intended to work, and I'm confused a bit. I can see that Meteor does use the plugin (for example, there're errors in Meteor server logs when there're errors in syntax in SCSS file), and moreover, changes appear when server refreshes, but there's no compiled CSS file for some reason.
When I inspect the element for which I wrote some SCSS, it says that the element uses the following stylesheet: '/merged-stylesheets-prefixed.css?hash=…'

But there's no actual file in my app folder. Does this work as intended?
Thanks!

I'm not sure if I understand the question correct.
The merged-stylesheets-prefixed.css file is served from the .meteor\local\build\programs\web.browser directory of your application (in dev mode).

Thanks Seba, now I see it! I just got used to a quite different way of compiling SCSS with Codekit. But that's OK.


Stacks are being stuck into Activating state using Rancher HA

v1.1.0-dev3
Docker version 1.11.2, build b9f10c9
Ubuntu trusty
Rancher HA , external DB RDS
Cattle
I've set up rancher HA using ELB, I have  3/3 nodes connected and the containers don't report issues.

Attaching hosts picture.

I am able to add services manually to the stack , but i can't  import docker and rancher yml files.

I've configured ssl terminated at ELB and point ssl(tcp) 443 to 81 and it is working fine.  Handling ssl with rancher the issue is still present.

Hey @amaranto what type of certificates are you using on the rancher server, are those self signed? I believe there's a bug with the rancher-ha.sh script that gets generated, it basically omits the certs, can you confirm thats the case? See here for a workaround.

@amaranto If you have further issues/questions, please re-open.


Can't load .glb meshes

Hi!
When I try to load a .glb mesh, Swift does actually load it into the browser but then Swift.py gets stuck here https://github.com/jhavl/swift/blob/efa25fb570aceed6070658b24bfe7526b8644fc8/swift/Swift.py#L361
How can I fix it?

@jhavl can you please give me some insight? Thank you.

I've performed a search on this repo and outside swift/swift/Swift.py, the shape_monted method/attribute is not found anywhere? But, the truth is that if I substitute the .glb by an .stl, the line mentioned previously returns "1"... what am I missing?

The same happens with .obj ... OBJ you do seem to have the code implemented, is there something I can do to help you solve what I am sure is just a bug?


The automatical completion of powershell do not work wilk

When using auto-completion in powershell at Windows to compress the file with tar and xz, installed in msys2.
The powershell will add .\ to the file name. And the "prefix" will be considered as the part of the name not the path.
For example, when the dir, named eg, needed to be compresses with tar and xz, will type in
> tar cvf eg.tar e

And then, press the TAB.
Then :
> tar cvf eg.tar .\eg

Then at the other system, such as macOS:
tar tf eg.tar.xz

THE OUTPUT is
.\eg/
.\eg/some/files

And I thought that is the bug of the gnu's tools, but I can not find where to report the bug, so I here report the bug.
I am using Windows 10 Pro (insider), and msys2.

Didn't notice you were using Windows PowerShell.  Since you are running this on Windows, the backslash is the appropriate path separator.  PowerShell can't know that tar expects forward slashes (note that when running PSCore6 on Mac/Linux, it will auto-complete with the correct slash).  Unfortunately the change would have to be in tar.


Update to released versions of Play dependencies

Final versions are ready so use them.

Coverage remained the same at 91.582% when pulling 4a159c711b7746d1474a3adfcc76eb709b2c00f0 on mikegehard:patch-1 into 06d07b8cbb1707586675756faa7febcca4de1de0 on eclipsesource:master.

Thanks for updating!


Add custom iterator function support which enables implementing a REPL in jq

Hi! this is more of a feature request than a PR but I choose to use a PR to show some proof of concept code.
Background is that i'm working on tool based on gojq that has a interactive CLI REPL interface. The REPL used to be implemented in go with quite a lot of messy code to make it "feel" like jq. Some days I realized that much of this could probably be solved if the REPL itself was written in jq.  After some thinking i realized that adding support for custom iterator functions would enable implementing eval as custom function.
With read and print as custom functions you can implement a REPL like this:
def repl:
	def _wrap: if (. | type) != "array" then [.] end;
	def _repl:
		try read("> ") as $e |
		(try (.[] | eval($e)) catch . | print),
		_repl;
	_wrap | _repl;

A bit more complicated than def repl: read | eval(.) | print, repl; repl to make it more user friendly.
Example usage showing basic expressions, nested REPL and errors:
$ go run cmd/repl/main.go
> 2+2
4
> 1 | repl
> .+2
3
> ^D
> [1,2,3] | repl
> .+10
11
12
13
> ^D
> 123
123
> undefined
function not defined: undefined/0
> [1,2,3] | repl
> undefined
function not defined: undefined/0
> ^D
> ^D
$

Some implementation notes:

The repl takes an array as input and will array wrap non-array values. This feels natural but maybe there are better solutions?
How to handle 1, 2, 3 | repl. The current behavior to give multiple REPLs feels ok i think.
Im unsure how to handle env.paths in *env.Next(). I guess it's related to assignment and paths? i haven't looked into how this could affect it.
The code to implement the iterator can probably be much clear and nicer

What do you think? could be useful?

Noticed now that tests are failing, ill have a look at it later

Do you want me to try make this proof-of-concept-PR into something that could be mergeable? Now i just commented out some things i don't understand how it work yet and did some ugly code duplication to just see if i could make it work. Wanted to get your feedback if i'm on the correct track and if this feature would be something you want to have.
Maybe you want to work on implementing this yourself? i'm happy to help either way.

First of all, thank you for various feedbacks, and you are the first one trying to dive deeply into the gojq interpreter. I don't decided yet but this kind of feature extension is likely to be declined. Pushing an iterator to the stack breaks various assumptions in the implementation. Also I am wondering how much this is useful in other usages than eval, it is worth accepting and maintaining this feature or not. This is open source, feel free to use your fork, and I can advice on implementation.

Yes very much understand that, and thanks of offering advice, will most likely need it.
Do you have any ideas how a implementation would look like that don't keep a iterator on the stack? or maybe it would be ok but some code assuming things will have to be changed?
Was thinking today what other uses than eval function iterators could have:

In my CLI tool i have a display function that is meant to display a value in human readable format (a format not meant for further trasformation), can be binary hexdump, show tree structures (not really JSON), summaries and previews and those return a empty iterator to terminate. Feels very natural when used in a REPL, eg: to see hexdump of first 10 packets you can do .packets[0:10] | hexdump (display is implicitly called in the REPL).
Maybe replace opeach and some builtin functions if it makes the interpreter code simpler or it make sense for CPU/memory performance reasons to implement in go.

For example could opeach in the compiler be compiled to a function call implemented something like this:
type sliceIter struct{ c []interface{} }

func (si *sliceIter) Next() (interface{}, bool) {
	if len(si.c) == 0 {
		return nil, false
	}
	e := si.c[0]
	if err, ok := e.(error); ok {
		return err, false
	}
	si.c = si.c[1:]
	return e, true
}

func each(c interface{}, a []interface{}) interface{} {
	switch c := c.(type) {
	case []interface{}:
		return &sliceIter{c}
	case map[string]interface{}:
		xs := make([][2]interface{}, len(c))
		var i int
		for k, v := range c {
			xs[i] = [2]interface{}{k, v}
			i++
		}
		sort.Slice(xs, func(i, j int) bool {
			return xs[i][0].(string) < xs[j][0].(string)
		})
		ss := make([]interface{}, len(c))
		for i, v := range xs {
			ss[i] = v[1]
		}
		return &sliceIter{ss}
	default:
		panic("unreachable") // TODO: ?
	}
}

Now i realized to make this work the function iterator interface probably can't use gojq.Inter as it will have to provide some kind of path information also? maybe it should actually look something like interface { Next() [2]interface{}}?
Again thanks for taking your time and I really enjoy working with the gojq code.

Hi again, i tried your suggestion to use a jq function to wrap an internal function to implement a generator. Seems to work fine, fascinatingly simple :)
I did these changes:
Renamed internal eval to _eval and modified these functions:
func (preludeLoader) LoadInitModules() ([]*gojq.Query, error) {
	replSrc := `
def eval($e): _eval($e)[];
def repl:
	def _wrap: if (. | type) != "array" then [.] end;
	def _repl:
		try read("> ") as $e |
		(try (.[] | eval($e)) catch . | print),
		_repl;
	_wrap | _repl;
`
	gq, err := gojq.Parse(replSrc)
	if err != nil {
		return nil, err
	}

	return []*gojq.Query{gq}, nil
}

func eval(c interface{}, a []interface{}) interface{} {
	src, ok := a[0].(string)
	if !ok {
		return fmt.Errorf("%v: src is not a string", a[0])
	}
	iter, err := replRun(c, src)
	if err != nil {
		return err
	}

	var vs []interface{}
	for {
		v, ok := iter.Next()
		if !ok {
			break
		}
		vs = append(vs, v)
		if _, ok := v.(error); ok {
			break
		}
	}

	return vs
}

Trying to come up with ways it might behave differently to returning an iterator. As long as the eval expression is "pure" i think it should not matter that we empty the iterator and then return all values instead of doing one at a time.
Is it correct to handle error just as any value but stop iterating?

One difference because the generator is not "lazy" when wrapped is that you can't use a internal function to generate a unknown number of values, for example a infinite range or to read inputs etc. Maybe a bit of a edge case?

The problem of handling Iter in the opcall instruction is, as the CI failure suggest, we cannot distinguish backtracking after an error and to an iterator. Maybe we need to distinguish the iterator function from others, and generate different opcode like opcalliter. But still backtracking issue can happen in some cases? Also, we need to make sure the debugger (which runs with make build-debug) can handle the stack containing an iterator.
The problem of collecting the values is, as you have pointed out, it is impossible to generate infinite values. Also it may less performant. But this is in general useful way of implementation of jq function accepting another filter as its argument; like min_by and _min_by.
From another way of viewpoint, input(s) function is a specific form of iterator functions. Currently we have WithInputIter to inject the iterator. The input(s) function is special that multiple calls share the same iterator but custom iterator functions may not; first(fibonacci), first(fibonacci) will both print the first value.

For my use case of  eval your solution to wrap could be good enough i think, someone could try evaluate something that produces infinit or lots of values and run out of memory etc but that could be documented behaviour.
But I do feel the idea to support internal iterator function is quite compelling and might be useful, and as i mention maybe be can be used to implement some builtins things like inputs, each etc for simplicity of performance.
Should i continue look into adding opcalliter etc as you mentioned or do you feel eager to do it? i guess there are lots of details that might be hard to account for, like the debugger as you mentioned. Either way let me know how i can help, very interesting things to work on!

Hi again, got the idea to extend opeach to support Iter and separate between custom function/iterator and in then duration compilation if iterator add a opeach after opcall. Turned out quite good i think. What do you think?
Some questions and TODOs:
Not a good idea to separate function/iterator? could wrap all functions as one value iterators but might impact performance?
Keep track of path? currently iterators give 0 as path for each value. Feel i don't really understand that part of the code yet.
Remove REPL or add to CLI?
Have a NewSliceIter helper for less confusion about reference or not
Useful to provide IterFn, EmptyIter and SliceIter?
Test for ValueError
Update debugger?

Can I just voice my support of this feature! Great idea!

Noticed that debug needed some special treatment, got it working but code is a messy. Needs a refactor and tests

Added TestWithIteratorDebug test

I'm sorry for keeping this pull request open for months. I wasn't sure the correctness of the patch, especially in execute.go, and whether or not accepting the iterator utilities and repl code.
I have included to the main branch. I really appreciate your work and committed with adding you as a co-author.

The idea of appending the opeach instruction is nice. Also adopted the idea of adding a new compiler option for iterator function, with naming WithIterFunction. They are special functions returning iterators.
I changed the type of the option argument to func(interface{}, []interface{}) gojq.Iter to force the user to return iterators in any case. This is necessary because the appended instruction will crash on an iterator function returning a non-iterator value. Also, an iterator can emit an error.
I added NewIter to create an iterator from values. It can be used instead of SliceIter and EmptyIter. Also useful to convert an error to an iterator. I liked IterFn but not much useful in real use cases.
I simplified the implementation in execute.go. Also fixed some error cases. Rejecting definition of iterator and non-iterator functions with the same name. Emitting path error when used at expression depth 0 (tracking the path is not necessary).
I don't include the repl cli, but confirmed the behavior with my implementation. Including a repl code in this repository will likely to add a new dependencies for better prompt.

I'm sorry for keeping this pull request open for months. I wasn't sure the correctness of the patch, especially in execute.go, and whether or not accepting the iterator utilities and repl code.

No worries

I changed the type of the option argument to func(interface{}, []interface{}) gojq.Iter to force the user to return iterators in any case. This is necessary because the appended instruction will crash on an iterator function returning a non-iterator value. Also, an iterator can emit an error.
I added NewIter to create an iterator from values. It can be used instead of SliceIter and EmptyIter. Also useful to convert an error to an iterator. I liked IterFn but not much useful in real use cases.

Both good ideas i think, API feels cleaner

I don't include the repl cli, but confirmed the behavior with my implementation. Including a repl code in this repository will likely to add a new dependencies for better prompt.

Understand, i mostly included it to show my use case.
I've been thinking how to handle debug with iterator functions. In my case this happens when using debug inside an (possibly multi nested) evaluated expression. Should the debug value be pass-thru to the outer most iterator or should it be up to iterators in the middle to filter them out so they don't end up being used as values?
In my version i went for the pass-thru but now i got second thought maybe it's better to do something like this:
func eval(c interface{}, a []interface{}) gojq.Iter {
	src, ok := a[0].(string)
	if !ok {
		return gojq.NewIter(fmt.Errorf("%v: src is not a string", a[0]))
	}
	iter, err := replRun(c, src)
	if err != nil {
		return gojq.NewIter(err)
	}

	return IterFn(func() (interface{}, bool) {
		for {
			v, ok := iter.Next()
			if _, ok := v.([2]interface{}); ok {
				// custom debug handling here
				continue
			}
			return v, ok
		}
	})
}

Again, thanks for taking the time to review and work on this

Hmm, it seems that it was a mistake to implementing debug and stderr functions in the library and the result iterator returning [2]interface{}. They were implemented in early age of gojq, so I added special instruction opdebug and use [2]interface{} to distinguish from normal values. But currently we can use WithFunction to implement them. I'm considering removing them from the library completely in the next release.

Aha ok you mean use WithFunction and it just prints to stderr etc and pass-thru the value? no for gojq to know about it at all? that seems nicer. Would we loose something by doing it? debug messages and Next() value order will be different?

Right, library users can implement them with the option to choose how they print the value. Called order does not change.

What's the status of the pull request? Would be nice to have some kind of eval function in gojq.


Please Help !!!!  Win10 1809 v 17763.557 Not Supported.

I need help,
Win 10 Pro V. 17763.557 not supported.

Yes. Update appears to have arrived on 18 June 2018. Bummer.

I also have a computer that Win 10 Pro V. 17763.557 has broken. Any assistance would be appreciated

I ended up fully reinstalling Win10, suppressing any Windows Update activity via Group Policy, and reinstalling rdpwrap. (Found a good, working .ini file on another git.) My media creation tool pushed the older 1809 17763.379 and I am, at the moment, locked into that ver. forever until a new .ini floats by. A tad scary for a production machine on my LAN. I would watch this thread intently, except that these Windows revisions appear to be a rapidly-moving target. No telling what version I would have to deal with next update.
Strongly thinking about ThinStuff XP/VS. Yeah, I know that this outfit is playing the same game as rdpwrap, but at least they seem to be updating it with greater haste. Kind of expensive, though, too...

I have the same problem. I tried with a different .ini file, but nothing changed. :S

Also not supported on Win10 1809 v 17763.593

Solved!
I have the same problem.
After not found anything here I tried to duplicate the sections [10.0.17763.437] and [10.0.17763.437-SLInit] of the rdpwrap.ini and change his names to [10.0.17763.557] and [10.0.17763.557-SLInit], respectively.
Worked like a charm!!

I too have version 10.0.17763.557 and solved the problem using neymp's instructions above.

neymp: could you perhaps provide the INI file for examination?

Solved!
I have the same problem.
After not found anything here I tried to duplicate the sections [10.0.17763.437] and [10.0.17763.437-SLInit] of the rdpwrap.ini and change his names to [10.0.17763.557] and [10.0.17763.557-SLInit], respectively.
Worked like a charm!!

Should I do something else after this?
I had the same idea. And I did just that. Therefore, I was so surprised that the listener has not yet earned, after seeing your decision here - the same as I had taken earlier on my own.

Solved!
I have the same problem.
After not found anything here I tried to duplicate the sections [10.0.17763.437] and [10.0.17763.437-SLInit] of the rdpwrap.ini and change his names to [10.0.17763.557] and [10.0.17763.557-SLInit], respectively.
Worked like a charm!!

I have 10.0.17763.577 too. And that don't helped me)
Should I do something else after this?

I solve it with Issue #194

Solved
Thanks neymp for the  solution


about dataset

Hi, thanks for your amazing work!
Recently，I do some researches about human matting, I wonder when will you release VideoMatte240K dataset, I am realy very interested in it.

Hi, thanks for your amazing work!
Recently，I do some researches about human matting, I wonder when will you release VideoMatte240K dataset, I am realy very interested in it.

hi, 想问下你拿到 VideoMatte240k dataset 数据集不

@24werewolf @ljiqy
We finally finalized the licensing of the VideoMatte240K dataset. Currently planning to release it on April 12.

Actually there are still some delay. Likely to be in this week or next.

That’s really good news, my AE ability is very poor.

Dataset is released. Checkout the README of the repo.


Add hints for parameters and return values!

TopoNetX for the most part does not use type hints for function parameters and return values, which would be usable by static type checkers such as mypy (in TopoNetX itself but also when consumers want to check their code for errors).
However, recently, some comments by @josefhoppe added a few type hints to the source code, e.g., in #94. I think there should be a clear decision whether to add type hints or not:

If not, remove the existing ones again.
If yes, make this clear. Even if not adding them to the existing code right away, any new code should not be merged without type hints. See also mypy's guide for existing codebases.

Either way, the decision should be made clear in the contribution guidelines and enforced for new pull requests.

what is your recommendation ?

I personally always use type annotations in my code, as it generally improves IDE support (suggestions, errors).

ok then, I will start addressing this issue then.

I agree. In the medium term, I think we should also add mypy to the linters as it can easily detect some type errors (I just ran it manually and it found two mistakes that can be easily overlooked by humans, even with the limited type hinting currently present in the codebase)

(or maybe flake8 has a type checking plugin, I don't have a strong preference for a specific tool, just type checking in general)

(or maybe flake8 has a type checking plugin, I don't have a strong preference for a specific tool, just type checking in general)

flake8 doesn't do much on its own, it delegates the heavy work to other existing tools. There is a plugin for mypy as well, but I think it's better to use mypy directly. That one really only exists as a workaround for editors that have integrated flake8 support but no integration for mypy.

It appears the discussion has a relatively clear outcome (so I changed the title of the issues). It seems, clear we should do it, but it is not a top-priority right now.  However, we should probably add this as requirement for new commits.

@ffl096 do you have updates on this? Should we close it?

This is an ongoing effort and will be automatically closed once #163 is merged. The remaining issues are non-trivial and will take more time.

@ffl096 when will you expect this to be completed?

@ffl096 should we close this task ?

See #163.


it does not work!!!

it waiting first line, doesn't do something

@drsnkrt you provide no information what so ever, how do you expect help?


[incubator-kie-issues#1528] Adapt tracing code. Fix tests

FIxes incubator-kie-issues#1528
Needed by https://github.com/apache/incubator-kie-drools/pull/6124

How to replicate CI configuration locally?

Build Chain tool does "simple" maven build(s), the builds are just Maven commands, but because the repositories relates and depends on each other and any change in API or class method could affect several of those repositories there is a need to use build-chain tool to handle cross repository builds and be sure that we always use latest version of the code for each repository.
build-chain tool is a build tool which can be used on command line locally or in Github Actions workflow(s), in case you need to change multiple repositories and send multiple dependent pull requests related with a change you can easily reproduce the same build by executing it on Github hosted environment or locally in your development environment. See local execution details to get more information about it.

PR job #1 was: UNSTABLE
Possible explanation: This should be test failures

Reproducer
build-chain build full_downstream  -f 'https://raw.githubusercontent.com/${AUTHOR:apache}/incubator-kie-kogito-pipelines/${BRANCH:main}/.ci/buildchain-config-pr-cdb.yaml' -o 'bc' -p apache/incubator-kie-kogito-runtimes -u https://github.com/apache/incubator-kie-kogito-runtimes/pull/3727 --skipParallelCheckout
NOTE: To install the build-chain tool, please refer to https://github.com/kiegroup/github-action-build-chain#local-execution

Please look here: https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-runtimes-pr/job/PR-3727/1/display/redirect
Test results:

PASSED: 3041
FAILED: 1

Those are the test failures:

org.kie.kogito.quarkus.workflows.PojoServiceIT.testPojo
Expected size: 1 but was: 2 in:{"age"=666, "name"="javieritoPerson"}

koigito-runtimes failures unrelated
sonataflow-addons-quarkus-python-integration-tests


Return ID user on /rest-auth/user/

Coverage remained the same at 97.068% when pulling f793447baec2ae3a3d2b277d192be63db868713a on briva:patch-1 into 3b80fcbca9b3d9f9f918cda27db86ee0869556cd on Tivix:master.

+1


Apptainer version 1.2.0.

FATAL:   While performing build: conveyor failed to get: loading image from docker engine: Error response from daemon: {"message":"client version 1.22 is too old. Minimum supported API version is 1.24, please upgrade your client to a newer version"}


H3: Control stream implementation

Handle control streams in quinn-h3::proto::Connection and drive it from quinn-h3::ConnectionDrive, conforming to 6.2.1. Control Streams.

What do you mean by handling them "in" proto::Connection?

Make the data exchanged on this stream impact the connection state, and the other way around. When some of it's state changes the connection needs to transmit some frames to it's peer. This mechanism is a part of the request life-cycle. This table can help to understand what it is all about.

Okay, but I'm confused about the part where this HTTP-level contract has to become a part of the quinn-proto::Connection or the quinn::ConnectionDriver, both of which should know ~nothing about HTTP.

Maybe it is a design flaw then? proto::Connection is the place where all the state common to requests, responses is stored.
For example: If a peer triggers a GoAway, receiving proto::Connection will set a flag. If a subsequent Request asks for a new request stream, Connection will lock proto::Connection, check the flag, return an error because it is set.

Forgot to mention: ConnectionDriver polls the QUIC stream that is used as control stream. It gets a GoAway frame. Then it locks ConnectionRef to set the gone_away flag in proto::Connection.

Ah, you're talking about quinn-h3::proto::Connection whereas I was talking about quinn-proto::Connection.

I edited the description...


samples(security): add template/monitoring samples

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

[ ] Make sure to open an issue as a bug/issue before writing your code!  That way we can discuss the change, evaluate designs, and agree on the general idea
[ ] Ensure the tests and linter pass
[ ] Code coverage does not decrease (if any source code was changed)
[ ] Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

Hey @savijatv! Sorry I haven't sent you any reviews recently - can you PTAL at this and let me know when you've reviewed it?


Off-by-one error for pencil buttons for workspace editor settings

VSCode Version: Code 1.8.0 (38746938a4ab94f2f57d9e1309c51fd6fb37553d, 2016-12-13T17:45:32.595Z)
OS Version: Windows_NT ia32 10.0.14965

See below -

Closing - Sara was failing at reading comprehension


add info about PFKB version required by the pipeline

revise readme or metadata value in py project
add version information to the pipeline output
what metadata is important to have about the PFKB as a machine-actionable artifact?

Use github commit-python combination package


Show a progress bar when loading, saving and packing projects

Dependent on #971.

Is anybody working on this?  I would like to take this one

Nobody is working on this, but as the description of this issue states, it's dependent on #971 which must be done first and which requires some design work.

I will give it a shot.


Array element inferred type from destructure does not recognize properties unless explicitly declared

TypeScript Version:  3.3.3, 3.4.3, 3.4.5

Search Terms:
"does not exist on type"
"does not exist on type" bivariant
Explanation
It seems like when an array with elements of multiple types is not explicitly declared, and the elements do not overlap at all, the component type does not correctly evaluate which type it is. Output errs like shown below.
This does not happen if the array is cast as following or declared as return type on the function. [{attributeA:boolean}, ReactComponent]
e.g.
return [...] as [{attributeA:boolean}, ReactComponent]

Code
interface ReactComponent {
    attributeB: any;
}

const getArray = () => {
    return [
        {
            attributeA: true
        },
        {
            attributeB: true
        } as ReactComponent
    ];
};

const [item1, item2] = getArray();

const itema = item1.attributeA;
const itemb = item2.attributeB;

Expected behavior:
No errors
Actual behavior:
testScript1.tsx:18:21 - error TS2339: Property 'attributeA' does not exist on type 'ReactComponent | { attributeA: boolean; }'.
Property 'attributeA' does not exist on type 'ReactComponent'.
18 const itema = item1.attributeA;
~~~~~~~~~~
testScript1.tsx:19:21 - error TS2339: Property 'attributeB' does not exist on type 'ReactComponent | { attributeA: boolean; }'.
Property 'attributeB' does not exist on type '{ attributeA: boolean; }'.
19 const itemb = item2.attributeB;
~~~~~~~~~~
Found 2 errors.

In your working example you declare a tuple that contains two items: one type A, one type B. So when you destructure it the compiler knows: The first element is A, the second one is B.
In your non-working example you declare an array that contains items that are either type A or type B. So how would the compiler know what it is? It could be both according to the array declaration.
This is by design and intended. You can have an easier way declaring your tuples by using const contexts from TypeScript 3.4:
const getArray = () => {
    return [
        {
            attributeA: true
        },
        {
            attributeB: true
        } as ReactComponent
    ] as const; // <--
};

as const will make it a const context and cause the compiler to infer it as a tuple, not an array.

In your working example you declare a tuple that contains two items: one type A, one type B. So when you destructure it the compiler knows: The first element is A, the second one is B.

Your insight has been incredibly useful and I see now the error of my ways.

In your non-working example you declare an array that contains items that are either type A or type B. So how would the compiler know what it is? It could be both according to the array declaration.

It feels like it should try to match both before giving up, but you're right. TS is strongly typed after all. Quite clear if you put it that way.

You can have an easier way declaring your tuples by using const contexts from TypeScript 3.4
This is pure sorcery. Useful sorcery, nonetheless!


delete signal listeners should use on_commit

The delete signal handlers like https://github.com/wagtail/wagtail/blob/master/wagtail/wagtailimages/signal_handlers.py#L9 should use transaction.on_commit() so that they wait to delete until the sql delete is successful
Something like:
from django.db import transaction
def post_delete_file_cleanup(instance, **kwargs):
    transaction.on_commit(lambda: instance.file.delete(False))

That’s right, we may lose files otherwise.
Documents are also concerned: https://github.com/wagtail/wagtail/blob/master/wagtail/wagtaildocs/signal_handlers.py
transaction.on_commit was added in Django 1.9 if I remember well.
Currently, Wagtail still supports Django 1.8, so this has to wait a bit, or we can implement it with a check in the meantime.
Would you like to provide a pull request for this?

@BertrandBordage Sure. I will try to get to it tomorrow. I've already written tests that I should be able to copy and paste

Awesome!

@BertrandBordage have a problem with me making the signal handlers generic and moving them to wagtailcore so they don't have to be duplicated between wagtailimages and wagtaildocs?

This test is failing because the test uses a file name that clashes with other tests that do not clean up their test documents.
The other failing tests occur on databases other than sqllite are slightly more difficult to fix because the vagrant-wagtail-development doesn't seem to offer testing on the different databases and travis tests are slow.  Seems to be related to serialized_rollback = True which wasn't required when I originally wrote the tests against postgres.  But copying them over to the vagrant-wagtail-develop box seems to force sqlite


Port to Java

Hey @perryn I am currently working on porting this project to java, I am going to be basing myself a lot on the structure of this one so I just wanted to both give you a heads up and to confirm if you were ok with it.
I am also still not set on the name but one of my choices was jblinky, which also made me wonder if you had any issue with that as well.
Let me know any comments or concerns, thank you!

Hi @rastadrian
No problems, do what you like!
I'm curious to know why you want to though?

Hey @perryn
Thanks man, I have some reasons:

I had an issue with the CCTray monitoring (I believe the culprit was Chicanery though) where the request time to our Jenkins CCTray would increase exponentially up until a point where every request takes around a minute and a half.
Our jenkins contains multiple directories for different categories of projects (every directory contains its own cc.xml tray) so I wanted the application to only download the tray once and verify the specified jobs on that tray, rather than re-downloading the tray per job check (I believe that check is handled by Chicanery as well?).
When our team manager saw the light (literally) he got excited and now he wanted to "verify" other things, not only Jenkins CCTrays but also Service Health Probes, Internal File Contents and even Time (like an alarm, at certain time, turn yellow for a moment) so I needed to heavily extend the library and I'm not very experienced with Ruby and here at work we have a big Java community.
Luckily LibUSB is also ported to java, so I could use an architecture very similar to blinky.
And now that the light verifies so many stuff, our team also wanted a UI that showed the reasons the lights went red, so by using Java I could  create a web application using Spring Framework which is heavily supported at work.

Thank you again for the inspiration!
Here's the jBlinky project: https://github.com/rastadrian/jblinky


[Mod Support Request] - Goodall

https://www.curseforge.com/minecraft/mc-mods/goodall
10
1.18.2 Forge/Fabric

Support for Goodall


What is ROBO?

https://docs.microsoft.com/en-us/azure/storsimple/storsimple-ova-overview
This article uses the word ROBO without explaining what it means. You might want to expand that. That is not a very common acronym. I had to look it up.
[Enter feedback here]

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 41071bd2-1ff5-ec3b-c497-be177eabc982
Version Independent ID: 22ffa088-890f-7770-80c4-6ed412387015
Content: Microsoft Azure StorSimple Virtual Array overview
Content Source: articles/storsimple/storsimple-ova-overview.md
Service: storsimple
GitHub Login: @alkohli
Microsoft Alias: alkohli

@DMoonesinghe Thanks for bringing this to our attention. Your feedback has been shared with the content owner for further review.

@DMoonesinghe Thanks for catching this! I have added the expanded form of the acronym. The change is in this PR: https://github.com/MicrosoftDocs/azure-docs-pr/pull/48067
I will let you know when the change goes live. Thanks!

@femsulu The fix is now merged. Please close the issue.
#please-close

@DMoonesinghe We will now close this issue. If there are further questions regarding this matter, please reopen it and we will gladly continue the discussion.


Improve accessibility of tabs

Describe the bug
Tabs can't be selected and switched using the keyboard alone.
This would help to comply with W3C's web accessibility initiative.
To Reproduce
Use the tab key to move through focusable objects on a page containing sphinx-tabs. Tab sets can't be selected or changed to show content on other tabs.
Expected behavior
Users should be able to highlight and switch tabs using the keyboard.
This behaviour is exhibited by sphinx-panels tabbed content, where the tab key can be used to select the tab set and arrow keys can be used to switch tab.

Looking into doing this, but the best approach might be to replace the a tag-based tabs here with buttons and use the tab role.  The example on that link doesn't look too dissimilar to sphinx-tabs anyway 😄
A further accessibility issue is that the tab label colour doesn't contrast strongly enough against the background. #1D5C87 would be the lightest equivalent that meets the standard.
@pradyunsg it might be best to get this sorted before overhauling the JS? Happy to help with either. I'd also be supportive of changing the tabs appearance, but think we should at least provide a theme/option that looks similar to the current tabs for backwards compatibility.

@pradyunsg it might be best to get this sorted before overhauling the JS?

Ahoy! I doubt I'd be coming around to the overhaul anytime soon -- it ended up being easier to write a separate minimal plugin instead. Context here.
Please do feel free to move ahead without waiting on me to do a rewrite here. :)


gulp help / task listing

Print comprehensive list of tasks when running gulp or gulp help. Similar to: https://www.npmjs.com/package/gulp-task-listing

I think this is unnecessary because of the new docs #157.


Error when starting the OS.

" /magiczockerOS/core.lua: File not exists. " That is the error I get when starting the OS.

nevermind
this issue has been resolved by moving all of the os core components into the magiczockerOS file.


[crash] reporters/serializer on python 3 when using check clustering

While inspecting and bugfixing issue #1870 I noticed that @m4rc1e 's command-line would trigger a crash on python 3 (Marc seems to be using python 2 at the moment though, so I think he had not noticed this one yet):

Yeah I'm still py2.7 for font stuff atm.

I remember this I think. The max() function works on None in Py2 because 1 > None works, but Py3 has stricter requirements.


Do we need to install yarn in tests?

I saw yarn be setup in .github/workflows/test.yml, I figure it should be trimmed away if its not needed - or possibly added back in contributing docs if it is.

I can't see why it's needed. There are no Javascript components in this repo, it's all Python.

I believe we don't need yarn setup in this repository. As @consideRatio stated here, it is an alternative to npm which we only need to install the configurable-http-proxy.  I have removed it in this test workflow update PR and the workflow runs fine without it.


Fix edge case slider

Fixes #2331

I went ahead of myself and this is of course approved change :)


Misc doc changes

Besides other documentation changes, this commit ensures the generated
HTML doc for HexDocs.pm will become the main reference doc for this
Elixir library which leverage on latest features of ExDoc.

Heyo, sorry been busy/away from OSS for a long while :sweat_smile:
Thanks for the MR, I just "rediscovered" it. I'll try to readapt it, since the commit is so large and I don't necessarily want all of it (e.g. I like the status badges to be next to the project name) it'll be hard to keep your commit authorship with all the conflicts etc. as I'll redo it against a current version. Sorry about that, I'll reference it as best I can.
Cheers,
Tobi

Closing in favor of #61

@PragTob Noted, and thanks for following up.


101 unmap pinning rule

#101

Please don't forget to create a new issue for tests covering this functionality.

I've created an issue for tests here: https://github.com/StarcounterApps/Website/issues/126


KeyGenerator.getInstance(keyAlg) does not recognize any of the Key Algorithms listed from Providers

Using version 16.
Summary
I attempted to call KeyGenerator.getInstance(keyAlg) with several key algorithms listed from Security.getProviders().  All of them return "java.security.NoSuchAlgorithmException: NONEwithRSA KeyGenerator not available" or the equivalent.
Steps to reproduce
(1) List the providers with:
   TreeSet<String> algorithms = new TreeSet<String>();     for(Provider provider : Security.getProviders()) {       for(Service service : provider.getServices()) {         if(service.getType().equals("Signature")) {           algorithms.add(service.getAlgorithm());         }       }     }     List<String> algs = new ArrayList<String>();     algs.addAll(algorithms);     return algs;
(2) It returns many algorithm names, including for example "NONEwithRSA".
(3) Call KeyGenerator.getInstance(keyAlg);
(4) Exception is thrown, regardless of keyAlg algorithm name chosen.
NOTE:  I would have much preferred using EAS encryption but I am aware that it is no longer included in Java and would have to use a 3rd party API.  So I stuck with RSA for now.
Expected results
Run with no exception.
Actual results
Exception "java.security.NoSuchAlgorithmException: NONEwithRSA KeyGenerator not available".
Triaging info
Java version:
openjdk version "1.8.0_292"
OpenJDK Runtime Environment Corretto-8.292.10.1 (build 1.8.0_292-b10)
OpenJDK 64-Bit Server VM Corretto-8.292.10.1 (build 25.292-b10, mixed mode)
What is your operating system and platform?
Windows 10 2021 on x86-64
How did you install Java?
zip
Did it work before?
Java works fine, it is only  KeyGenerator.getInstance(keyAlg) that seems broken.
Did you test with other Java versions?
Not in years, possibly since before Oracle created the Java mess by taking it over from Sun.

OpenJDK Runtime Environment Corretto-8.292.10.1 (build 1.8.0_292-b10)
OpenJDK 64-Bit Server VM Corretto-8.292.10.1 (build 25.292-b10, mixed mode)

This is a corretto build, not a Temurin binary (Adoptium). Can you reproduce with a Temurin build?
https://adoptium.net/?variant=openjdk8&jvmVariant=hotspot
If not, please bring this to the corretto folks. Probably here:
https://github.com/corretto/corretto-8/issues

Closing here as the issue has been reported at Corretto


Update to work with log 0.4 and rustc 1.43

Part of the systemd/zram-generator effort.
Also reimagines the API a bit, what with the changes to log, I based it on simplelog
This is obviously breaking, but it's not like it built before, so

Thank you for your effort!
I decided to simplify the API a little and implement my own error type.


Update golangci-lint-action to v3

https://github.com/networkservicemesh/sdk/issues/1255

@xzfc Please don't do PRs from fork into repos that has paid cluster.
These changes are minor. So merging...


Self-hosting system requirements

Hello CVAT Team!
I couldn't find any system requirements for the self-hosting solution. Do you have any?
Recently I've updated cvat from v2.4.2 to v2.7.2. Now cvat uses 6.6GB and it is 85% full on my system. It is impossible to export project dataset due to lack of RAM, but on v2.4.2 I didn't have such problems.

Hi @ArMaxik
We do not have strictly defined system requirements. But there might be some regressions with memory utilization.
Need to investigate and fix if there are any. It would be great if the community could contribute here.


[Bug]: Jest gives a wrong message to update snapshot tests

Version
29.4.3
Steps to reproduce
1 - Run Grommet project
2 - change something that conflicts with a snapshot. Here is a PR exemple.
3 - Run  yarn test, it will fail and ask you to update the snapshots.
4 - Jest will suggest running yarn test -u.
5 - Run yarn test -u and see that the snapshots were not updated.
Expected behavior
Jest Should suggest another message with a command that works.
Actual behavior
When snapshot tests fail, Jest is suggesting to run yarn test -u to update them. By grommet setup, this will run jest --runInBand && yarn test-timezones -u that does not update snapshots. But Grommet is only an example here. It can't be expected that -u flag will solve the issue in any situation.
One problem with yarn test -u suggestion here is that it will not work because it adds -u in yarn test-timezones command instead of jest --runInBand. If you don't open the package.json file you will not understand why adding -u is not working. Also, a developer without too much knowledge of bash/terminal commands will not understand either.
Additional context
It needs some investigation on what should be the best command that will work in every case, but update the following code can be a solution: https://github.com/facebook/jest/blob/94b73a2dd8bf8f6225769f2fe4a9322ac85483d8/packages/jest-reporters/src/getSnapshotSummary.ts#L48
Environment
System:
    OS: Linux 5.15 Ubuntu 22.04 LTS 22.04 LTS (Jammy Jellyfish)
    CPU: (12) x64 AMD Ryzen 5 5600G with Radeon Graphics
  Binaries:
    Node: 18.14.0 - ~/.asdf/installs/nodejs/18.14.0/bin/node
    Yarn: 1.22.19 - ~/.asdf/installs/nodejs/18.14.0/bin/yarn
    npm: 9.3.1 - ~/.asdf/plugins/nodejs/shims/npm
  npmPackages:
    jest: ^29.4.3 => 29.4.3

Can I ask how do you run Jest in the watch mode in a Grommet project?

Sure, you can run it with yarn test-watch. By grommet setup, this will call the following script: "test-watch": "jest --watchAll"

@mrazauskas I was thinking of improving this message, but not looking at the package.json, and maybe something like "Pay attention to your project, maybe the command will not work". Because it's that, as it is, any project that is using jest will have the same behavior, and it's not true.
Or do you have another suggestion?

Or event a suggestion with the npx ? :thinking:

@mrazauskas I do not think that we should create a more complex logic there, but my point is that, the message, as it is today, looks like it will work in any situation. Maybe adding just a warning as I suggest?
We cannot expect that every project will have the same behavior. The mastodon is just one example.


DNM: Focus test in CI

What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #
Special notes for your reviewer:
Release note:

/test pull-kubevirt-e2e-k8s-1.27-sig-compute

/close


sessionList servlet is showing User UUID, should be friendly name

Has been fixed on gh-3117-open-id-user-info_rename.
Now shows:

Waiting for #3650


Any possibility of a Xamarin Forms version?

Am trying to make this work in Xamarin Forms and it should be fairly easy with webviews but I'm misfiring a bit. Any possibility of hiring you to make a Xamarin Forms version of this? LMK

I'm really struggling with time at the moment. Have you got any code you could put online - if I get a chance I'll take a look.