add DeAngelis 1981 data

DeAngelis 1981 has a lot of data that have not yet been included in ForC, including productivity data.
Some of it is available in digital format, here. At least a lot of this was included in Luyssaert and is therefore in ForC; however, Luyssaert seems to have included only summary data, not some of the component data that is available and may be of interest (e.g., deadwood, ANPP_repro, ANPP_folivory). Component data is given in the study pdf.

@nancyfey123, this would be another good issue for you to work on.
The first step will be digitizing the data of interest in this  pdf. Each site has a subset of data (above the horizontal line) that has already been digitized and is in our repository here. However, the data below the line has not been digitized (at least to my knowledge).
For now, you can just make a matrix of sites and variables (use list at beginning of pdf). Please include definitions for each accronymn. Once this is done, I'll provide guidance on linking variables to the ForC variables, linking with ForC sites, and entering the data.

Hi Krista.
I’m out of the hospital as of this weekend and will begin working in these issues.
--
Nancy Fey
Environmental Science Student
George Mason University
P<PHONE_NUMBER>
E<EMAIL_ADDRESS>
From: Kristina Anderson-Teixeira<EMAIL_ADDRESS>Sent: Friday, April 13, 2018 2:15:01 PM
To: forc-db/ForC
Cc: nfey; Mention
Subject: Re: [forc-db/ForC] add DeAngelis 1981 data (#77)
@nancyfey123https://github.com/nancyfey123, this would be another good issue for you to work on.
The first step will be digitizing the data of interest in this pdfhttps://github.com/forc-db/References/blob/master/DeAngelis_1981_pofe.pdf. Each site has a subset of data (above the horizontal line) that has already been digitized and is in our repository herehttps://github.com/forc-db/ForC_private/tree/master/intermediate data sheets/intermediary databases %26 reference lists/DeAngelis NPP_IBP_198. However, the data below the line has not been digitized (at least to my knowledge).
For now, you can just make a matrix of sites and variables (use list at beginning of pdf). Please include definitions for each accronymn. Once this is done, I'll provide guidance on linking variables to the ForC variables, linking with ForC sites, and entering the data.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/forc-db/ForC/issues/77#issuecomment-381219403, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AkIGH_SklB-Ax-ISlgIyIixFoTKQcFdVks5toOskgaJpZM4S5Hf_.

@nancyfey123, I loaded the data you digitized here. Next step is for me to map ForC variables to these variables.

@nancyfey123, here are the first steps to processing these data. I'll add more soon.

Make sure you have  the latest ForC_measurements file
Highlight the top row (field names). Then on the data tab, hit filter. Go to the citation.ID field and select only DeAngelis_1981_pofe. This will show only the data from DeAngelis_1981_pofe that is already in ForC.
Go through your list of sites from DeAngelis and indicate whether they are present in ForC. Its probably easiest to do this if you move through the list of sites in ForC measurements alphabetically, marking those present.
a.	Site names will not match exactly, but you should be able to identify them.
b.	Note that some sites have similar names, differing only in age or a code.
c.	If there are any about which you are unsure, make a note and move on until I get a chance to look at it.
d.	We will need to add these sites to ForC, and that's something I'll need to help with. Please send me the list once you have it.

Create a new .csv file with the same headings as ForC_measurements but no records.

Moving through the sites that are already in ForC in the order that they appear, compare the list of variables already in ForC to the set available, and identify ForC variables (i.e., those we have defined in ForC VARIABLES table) that are reported but not yet in the database. Mapping of DeAngelis variables to ForC variables is given here. For each of these variables, copy one of the rows in ForC_measurements for an existing record from DeAngelis_1981_pofe for the site. Then modify as follows:
a. delete measurement.ID (leave blank).
b. change variable.name to the variable you're entering.
c. verify that date matches your records. If not, note it and report to me
d. for mean, enter the reported value after multiplying by the conversion factor given here. DeAngelis reports values in g/m2, so the conversion to Mg/ha is dividing by 100.
e. for notes, list the original variable name in DeAngelis (may be more than one; e.g., OL+UL).
f. fields method.ID through conflicts.notes - leave blank (erase previous values) unless you enter values for RLL or RLS. In that case, covariate_1 = max.diameter_root or min.diameter_root and coV_1.value=5, as indicated in notes here.
g. loaded.from = DeAngelis_1981_pofe
h.  loaded.by= your name

When you are done with that, enter values for the sites that are not yet in ForC in a similar way, but not copying values from an existing row. Here's what you should fill in for some of the fields; leave the rest blank.
a. sites.sitename= site name as reported in deAngelis
b. stand.age=as reported (AS)
c. dominant.life.form = woody
d. veg.notes = your Forest Type
e. If a single year is given, it goes in date , and date.loc=8. Then start.date and end.date=NA. If a range is given, they go in  start.date and end.date, and __.date.loc=8. Then date =NA and date.loc=9.
f. citation.ID = DeAngelis_1981_pofe
g. source.notes = original sources listed in DeAngelis_1981_pofe

The latest digitized data sheet from @nancyfey123 that I have is here. @nancyfey123, if you have a later version, please upload. Otherwise, we will treat this as the latest version.

@beckybanbury, I wanted to draw your attention to this issue, which relates to the data you've been working on. I should have done this yesterday!

@teixeirak, one of the entries in this sheet has no site or plot name (notes say the page was cut off so name was unreadable) - is there a protocol for dealing with this when entering that data?

@teixeirak, I have now completed the data entry from this data sheet. Regarding the unnamed site, it isn't clear from the lat/long information where the site is located, so I think it is best if it is left out anyway.

Thanks! There's another version of the data here; you can probably derive it from that.

I believe there are also a few more sites that Nancy didn't finish digitizing.  Once that's done, it will be great to close out the task of incorporating this data set!

@teixeirak, I have now entered all the data from the digitized set and the raw data set above. Hopefully that completes incorporating this data set!
I have just gone through to fill in gaps in the data, but those changes haven't been merged yet.

Wonderful; thank you!


feat: add fuzzle (puzzle game)

Status
READY
Description
The latest updates introduce an engaging new puzzle feature for the upcoming Flutter & Friends 2024 event. This feature includes three question types: matching, single-choice, and fill-in-the-blanks. It also allows for setting time limits and unlocking questions. A leaderboard will be available to track participants' scores. Our proprietary API manages both the quiz questions and the submission process. Additionally, the front end showcases custom Rive animations and audio playback, enhancing the overall user experience.
Screenshots

Type of Change

[x] ✨ New feature (non-breaking change which adds functionality)
[ ] 🛠 Bug fix (non-breaking change which fixes an issue)
[ ] ❌ Breaking change (fix or feature that would cause existing functionality to change)
[ ] 🧹 Code refactor
[ ] ✅ Build configuration change
[ ] 📝 Documentation
[ ] 🗑 Chore

@jisjoe @spydon FYI I just submitted v1.1.4 (14) to the AppStore and PlayStore and it contains the Flutter puzzle (as well as some other minor updates).


Not show icons in navbar

config/tablar.php

laravel version:  10

Did you inspect the element & any console errors?

Yes, there were no errors and the class of the icon appeared normally. see print screen.

In the latest version of Tabler Icon, they removed the ti class support. Now only support SVG. I'm working on it. Will share the update soon.

ok thanks.


How to install silently in Windows OS

Hi：
Thanks for reading, because my English is not good.
This paper uses machine translation.
Due to the need of business development, executing "mkcert - install" in Windows system will prompt whether to install certificate or not. How to select "yes" installation by default
Thank！

The security warning is from Windows, not from mkcert. A quick google didn't find any good ways to go around it.

Thank you. I use the. Net desktop program (WPF) and windows "user32. DLL" API to realize this function.


Make some naming convention

my naming is a mess, change it future me/whoever finds this issue and wants to do it

I'd like to work on this too.

I'd like to work on this too.

also thanks for reminding me of this project, after today I would have forgoten I should work more on it at home, if you need anything just ask


two connectione

how to use 2 service transaction, hellpe me, i am from VietNam
await this.resourcesRepository.save(data);
await this.userService.saveUser();

Hello, can you give more information about what you want to do if possible?
Do you want to run your code in one transaction?
await this.resourcesRepository.save(data);
await this.userService.saveUser();

Hello @thobui14ig , can you give more information about what you want to do if possible?
Do you want to run your code in one transaction?
await this.resourcesRepository.save(data);
await this.userService.saveUser();

yes, i want one transaction, that is two difference service, if this.userService.saveUser() error i want rollback  this.resourcesRepository.save(data), help me

Hello @thobui14ig , can you give more information about what you want to do if possible?
Do you want to run your code in one transaction?
await this.resourcesRepository.save(data);
await this.userService.saveUser();

help me

Hi, @thobui14ig.

You need to connect this library (https://github.com/Aliheym/typeorm-transactional#initialization) and example for Nest.js (https://github.com/Aliheym/typeorm-transactional#usage)
You need to use Transactional decorator in the method that contains a code that you want to "wrap" in the one transactions. For example it can be a controller method:

@Patch('/users/:id`)
@Transactional()
async updateUser(data) {
    await this.resourcesRepository.save(data);
    await this.userService.saveUser();
}

or it can be any other method:
class UsersService {
@Transactional()
async updateUser(data) {
    await this.resourcesRepository.save(data);
    await this.userService.saveUser();
}

You can ask questions if you have troubles with something.

Feel free to reopen issue if you have issues.


How to use non filed icons?

Hi, In my example Avalonia app I want to use following icon:

But when I'm trying to use following XAML:
<i:Icon Value="far fa-clipboard-check" FontSize="15"></i:Icon>

I'm getting:
System.Collections.Generic.KeyNotFoundException: 'FontAwesome Style "Regular" not found!'
Any idea how to use this version of that icon?

I'm facing the same issue :
System.Collections.Generic.KeyNotFoundException: 'FontAwesome Icon "file-o" not found!'
Any plans to update icons.json and add all the free FontAwesome icons  ?

@michalwitek1232 the icon fa-regular fa-clipboard-check is a pro icon and not available. Only free icons are available.

@mariusmg i can't the icon file-o online https://fontawesome.com/search?q=file-o. Are you sure the icon exists?

Hi Sebastian,
Yes, it's this one https://fontawesome.com/v4/icon/file-o
But it's v4, i assume these are not supported ?

@mariusmg no v4 is not supported. The current supoorted version is v6 (https://github.com/Projektanker/Icons.Avalonia#icon-providers)

Thank you for confirmation and kudos for creating this library.


Draft: Resolve "Error: TypeError: can't pickle property objects" - [opened]

Merges 55-typeerror-cant-pickle-property-objects -> development
Migrated from GitLab: https://gitlab.com/meltano/sdk/-/merge_requests/57

Closes #55

Stale


Add MisMerge

I added MisMerge, a merge editor I made myself for SvelteKit

The lint failed on the components.json.
Can you run pnpm run format to fix it ?
Also, the file changed in the meantime, can you also rebase your branch with main?

Should be ok now


Identity scaffolder overwrites files even without the --force option

Repro:

Run dotnet new mvc --auth Individual
Run dotnet aspnet-codegenerator identity
Modify IdentityHostingStartup.cs to make sure we know when it is overwritten
Run dotnet aspnet-codegenerator identity (Note: no --force)

Expected:
An error that says file already exists.
Actual:
IdentityHostingStartup gets overwritten.

I cant repro this issue any more. It gives me an error message that I need to pass --force. Closing.


Migration to AWS Amplify Gen 2

Issue #125 :
Description of changes:

Migrate 'amplify add api' to use Gen 2 backend in-build data
Migrate 'amplify add custom' to use Gen 2 Custom CDK Construct
Pass GraphQL API ID from Step 1 to be a dependency for Step 2 and simplify the code
Change frontend code to call amplify-data client to trigger AppSync API using mutations.

To Test

Clone the Repo
Go to the repo folder
Run 'npm create amplify@latest'
Replace the files in amplify/ folder with the ones supplied under REPO/template/ folder.
In amplify/backend.ts file replace the place holder "YOUR_EMAIL_ID" with your email address.
Deploy the resources in Gen 2 sandbox by running 'npx ampx sandbox'
Accept the SNS Subscription for sentiment notifications from your email.
In Another window change directory to repo folder
Run 'npm run dev'
Open browser and go to http://localhost:8080 and test both negative and positive sentiments

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

All changes now checked in.


Add files via upload

Game to guess next number .

Thnx for contributing @shauryas1ngh  make sure you follow me and star this repo so that you don't miss the updates and contribute during Hacktoberfest 2020.


Add missing copyright and licenses

Yep, looks like a network issue on travis. pod lib lint FirebaseCore.podspec runs fine locally.


Support constructing empty env with only name

#1095  👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @carolineechen and the rest of your teammates on  Graphite


Improve docs of softmax_cross_entropy

This is PR for improving docs of functions/links. Related issue: #2182
Modified functions/links:

functions/loss/softmax_cross_entropy.py

Jenkins, test this please

@keisuke-umezawa Jenkins tests failed. Could you rebase it to the current master?

@mitmul I rebased this branch.

@rezoo I fixed them!

Thank you. LGTM.


Adding a link to Joey NMT

I could not locate the place in the code where the comment "This is a community research project and as such, this service is not a production system. Therefore, it should not be used for official translations. Don't see your language and interested in training one up yourself? Go here to learn how to contribute a model!" from the current version on http://translate.masakhane.io/ is written, but it would be great if you could add a sentence saying "Powered by Joey NMT :koala:" and perhaps ", a minimalist machine translation toolkit based on PyTorch." or the like. This would help understand what kind of models are served and what they operate on (PyTorch).


[Build System: CMake] Include the stdlib/toolchain directory before the stdlib/public directory (5.1 branch).

Copy of #26362 for the 5.1 branch.

@swift-ci please test

@swift-ci please build toolchain macOS Platform

macOS Toolchain
Download Toolchain
Git Sha - 9d6a67eec660205530a253606fe1464530fd8a9d
Install command
tar -zxf  swift-PR-26363-348-osx.tar.gz --directory ~/

This broke the open source package builder: https://ci.swift.org/view/Dashboard/job/oss-swift-5.1-package-osx/459/

This failure was due to out of space issue, cleaning up the node.


fix(i18n): en default falback extraction disfunctional

the regex array extraction default lead to all nextUrl and previousUrl links being broken

@zollinger small fix for pagination links ready for review


fix(core): re-export CallLogFrame from geth types

Motivation
The CallLogFrame was not being exported from geth which made it
difficult to store all the logs using the ethers type.
Solution
Export CallLogFrame so it's accessible publicly via ethers::types.
Also export the internal fields.

Was just testing this locally and realized I didn't make the internal fields public. Fixed and good to go now!


Cannot read property 'name' of undefined when attempting transfer

Description
An error with message Cannot read property 'name' of undefined is being thrown when attempting to run the transfer command
Source
User emailed me with error details
Steps to Reproduce

Ensure configuration file is present (run toggl-to-clockify init)
Ensure the workspaces field in the configuration file is populated with valid values
Run toggl-to-clockify transfer

Attachments

Fixed on #9, comfirmed by user who submitted the bug.


Glip breaks when stdin is too large

Input:
dgen "hi " 1000 -c
Expected result:
"hi " is repeated 1000 times and is stored in the clipbboard.
Observed:

Resolved as of 91e5677.


Test sequence versioning under network partition.

Summary of the changes / Why this improves CrateDB
Checklist

[ ] User relevant changes are recorded in CHANGES.txt
[ ] Touched code is covered by tests
[ ] Documentation has been updated if necessary
[ ] CLA is signed
[ ] This does not contain breaking changes, or if it does:

It is released within a major release
It is recorded in CHANGES.txt
It was marked as deprecated in an earlier release if possible
You've thought about the consequences and other components are adapted
(E.g. AdminUI)

Replaced by https://github.com/crate/crate/pull/8596


pigpio: allow override of /proc/cpuinfo

As described in #480 some operating systems do not properly set the gpioHardwareRevision resulting in pigpiod not starting. This pull requests aims to provide a solution by allowing users to set the PIGPIO_REVISION_PATH environment variable to an alternate path, where the missing information can be provided in the same format as /proc/cpuinfo usually would do.

See referenced issue #480 for alternate solution.


Improving faq.md

Japanese lang:
・Fix link and sentence
・Add URL of instance's built-in MFM Cheatseet instead of creating a page for /mfm-cheat-seet
English lang:
・Fix  links
・Add URL of instance's built-in MFM Cheatseet instead of creating page for /mfm-cheat-seet

🙏


Extends 'spo term list' command with support for listing terms on site-level from tenant term sets as well as sitecollection termsets. Closes #4831

Extends spo term list command with support for listing terms on site-level from tenant term sets as well as sitecollection termsets. Closes #4831

Thank you @nanddeepn! We will try to review it ASAP!

Merged manually, thank you! 👏


what to do when dates have differing number of rows?

site nwis_04136900 has 24 obs per day for 5/6 of its record, 96 obs per day for the last 1/6. bayesian models with split_days=FALSE break here where MLE models and no-pooling bayesian models worked fine. what to do? could

refuse to model the site
manually set start-end dates to only include those dates with the maximum obs per day
manually set start-end dates and run multiple models, one per resolution. then recombine to create gpp_estBest, etc.
subset to the least common denominator (for nwis_04136900 that's 24 obs/day) and model all the days at that resolution

ended up splitting dates by resolution, even when each resolution was not continuous. still need to recombine.


Integration Test - Release - 2019/02/13 19:08:55

Auto create for integration test. AnotherAuthorUpdatedArticleFlow

@adunndevster : Thanks for your contribution! The author, @v-caxian, has been notified to review your proposed change.


Redirect to login page via https

Hi, we are running an instance of Castlemock on kubernetes and it can only be accessed through https.
We are running into a timeout when Castlemock initially redirect to the login page using http.
Is there any way to tell Castlemock to use https for the login redirection ? Thanks

Hi @francoisle.
Thank you for bringing this issue to my attention. I tried to reproduce this, but unfortunately I was unable to.
I tried to following:

Configure Apache Tomcat to use HTTPS
Access root castlemock: https://localhost:8443/castlemock

In this case I get redirected to https://localhost:8443/castlemock/login, as expected.
Am I missing something? Could you describe in further details what is happening in your setup?
Thanks!
Best regards,
Karl Dahlgren

Hello @karldahlgren
We have able to solve our issue by configuring the Tomcat server to use HTTPS as you suggested.
We just didn't know that it was how it should be done so there's no issue anymore.
Thank you for the help.


Documentation of ListView itemBuilder and SliverChildBuilderDelegate builder contradictory

Documentation for the itemBuilder of ListView states this:
https://github.com/flutter/flutter/blob/651580671768d4548ea69123b3f35b9158d3badc/packages/flutter/lib/src/widgets/scroll_view.dart#L1135
ListView delegates to SliverChildBuilderDelegate which in turn states this about its builder property:
https://github.com/flutter/flutter/blob/651580671768d4548ea69123b3f35b9158d3badc/packages/flutter/lib/src/widgets/sliver.dart#L360
This seems to have been introduced with https://github.com/flutter/flutter/pull/60726 in response to https://github.com/flutter/flutter/issues/58371.
Is it correct to never return null and set itemCount instead, or to not set itemCount and return null "after" the last item?

Keeping this issue open for further investigation.

It seems that a breaking change silently passed during NNBD migration
It used to be possible to return null in ListView.builder's itemBuilder.
This was a neat behavior for infinite lists without a known "itemCount"

Was fixed in https://github.com/flutter/flutter/pull/108706


Caching on GHES

Description:
In scope of this pull request we add support for caching on GHES.
Related issue:
https://github.com/actions/setup-node/issues/450
Check list:

[ ] Mark if documentation changes are required.
[ ] Mark if tests were added or updated to cover the changes.

Hello everyone. Could you please take a look at this pull request.
cc: @tiwarishub @brcrista


Add source:population and population:date presets for places

I noticed that when adding places there is a preset field for adding the population. It would be cool if there was also one for the source of the population data. Along with a preset field for the date it was obtained.

It'd be cool to be able to group fields together for stuff like this. This wouldn't look great:
Population
Population Source
Population Date
Whereas this is workable:
Population

Source
Date

Isn't it better to include this information in the changeset instead of directly on the place= node?
https://wiki.openstreetmap.org/wiki/Key:source
"With modern editors, the source=* tag is typically added to the changeset when a change is made, not as a tag on a piece of information which may be updated at different times based on different sources."

For reference, the fields mentioned above would be hooked up to the well-established population, population:date, and source:population tags.
/ref #6678

Isn't it better to include this information in the changeset instead of directly on the place= node?

@jeisenbe Yes, that is the case generally speaking for sources.
But population is special since it's something people should add that can't be verified on-the-ground. It could also have different values from different agencies, so it's helpful to explicitly specify where the number came from. The population:source tag does this without making a consumer delve through changesets.

The risk is that a ‘source:population’ tag might not be updated when the
‘population=‘ is edited in the future.
But maybe iD can validate this, so if a user changes ‘population’ then the
date and source tags have to either be deleted or updated?

The risk is that a ‘source:population’ tag might not be updated when the
‘population=‘ is edited in the future.

Yes, which is why having a field for this would be helpful by making the tag more visible.

But maybe iD can validate this, so if a user changes ‘population’ then the
date and source tags have to either be deleted or updated?

The issue here is that the source could be the same year after year (US Census Bureau, etc.).

But maybe iD can validate this, so if a user changes ‘population’ then the date and source tags have to either be deleted or updated?

The issue here is that the source could be the same year after year (US Census Bureau, etc.).

The validator could require that a change in population be paired with a change in either the date or the source, to account for recurring sources. I have come across cases where the previous value was simply wrong (such as copy-pasta of a different city’s population), but a false positive validator warning isn’t the end of the world.


Added Citrix Web Application Firewall

Added Citrix Web Application Firewall as an alternative to Barracuda WAF, based on experience as a hybrid multi-cloud and cloud-native solution.

@jantytgat : Thanks for your contribution! The author(s) have been notified to review your proposed change.

Thank you for the feedback.
We're not going to incorporate this specific feedback at this time.
#please-close


how do dlight works?

in shader its very confusing and im going crazy trying to understand, im adding two blended textures in my engine based on this and it works fine except when a dlight is there it goes away, i added to combinetexturelayers this which is fine i think and c++ part is fine but when dlight is on its just like gone, i fell like its got to do something with dlight so shadertype 5 but idk why its so strange

this is with flashlight off

and this with it on

You need to make sure you are also doing this when you are performing the multiplication with the texture after the lighting stage. That stage is done here:
https://github.com/TheOverfloater/pathos-public/blob/0fcd9b765a872ac5c08346dae1282ff19e9ae0ad/pathos/sources/codesrc/engine/renderer/r_bsp.cpp#L3177
As you can see, it is setting the determinator for either "shader_main_detail" or "shader_texunit1". You need a matching version of your texture blending solution for these particular shaders as well to make this feature work with multi-pass rendering.

yup that seemed to be issue as now it shows for dlights too tho i have reached a new issue  where for some reason blending is occuring on different textures where its not meant too, its only meant to show on redbrick01, but it also shows on slate floor for no reason, did add a new branch called twoblended in shader, i also tried adding an else here but for some reason it breaks the twoblended too, since you know the engine you might know why this could be happening if this is C++ related or shader @TheOverfloater

this is my bss shader btw i really dont know what to do cuz i got blending like working but  it shows up on other materials that arent meant to
bsprenderer.txt

and r_bsp.cpp is this maybe im just  binding wrong in wrong places? i followed how mt_tx_luminance binds maybe you know how to bind correctly if im doing it wrong?
r_bsp.txt

i also noticed it occurs to ao maps i added to my engine too so i think its way im binding textures, but at this point i just realized that  you can probably  just add 2 textures on 1 main texture so im probably gonna just do it manually to prevent all these errors

You need to make sure you are resetting the "twoblended" and "ao" determinators to 0 if you are not using them. Otherwise they will remain enabled for objects that do not need them, and you'll get blending on textures you don't want it on.


Add support for Poisson distribution

Go through the Gaussian distribution class, the Binomial class and the Exponential class which are subclasses of General distribution class.
I would like to expand this to include another distribution, the Poisson Probability Distribution.
It should be able to calculate mean, standard deviation, and create basic plots like those in the classes I linked.

Please assign this issue to me, I am new to open source and would like to contribute

@AmeyaPhadnis-2019H1030012G I'd be glad to assign it to you! Before that, could you tell me a bit about how you plan to approach it ?

Hi @hot9cups. If this does not get assigned, I would like to complete this task. To prepare, my plan is to go through the code for the distribution classes, their respective tests in test.py, documentation for matplotlib, read up on poisson distribution, come up with a numbers_poisson.txt for demo data. For the implementation, I'm going to mimic the implementation of the other distribution classes

@ho-jonathan Since AmeyaPhadnis seems to have deserted us(And they also have request for claims on two other issues so if they come back there's always that), I'm assigning it to you.
That plan sounds perfect! Please go ahead!

@ho-jonathan I was wondering how you're progressing with the PR

@ho-jonathan are you still interested in working on this? I will assume it's a no if you're unable to respond within a week :(

Hi @hot9cups, I would like to work on this. Can you please assign this to me?

Hey @hot9cups, can you tell me how to trigger github actions manually? Right now, it happens once a day (I think) but it's slowing down development. I want to run Python Lint Test.

@saeyma The github actions are just flake8 linting tests plus the unit tests in tests.py.
Ideally, you should be running the tests.py file before making a commit so you can check that the code you added actually works(assuming you added tests for the distribution you're working on) as well as haven't broken any other distributions.
As for the linting tests, you can install flake8 on your computer and could check for linting errors via command line and/or various other editors.
Also, the github actions are supposed to run automatically, but there's a restriction in place for first time contributors.
First time contributors to this repo always need my permission to get the action triggered.
You shouldn't require the permission from your second PR onwards :)


⚠ ClamAV has degraded performance

In 6f18d19, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 211 ms

Resolved: ClamAV performance has improved in 7e8bf59.


Add counts for tags and categories and authors

Currently it is possible to count the number of tags / categories / authors in order to understand volume.  However, this process would cost considerable query volume.  Denormalize post counts into tags / categories / authors.  Calculate these counts when a new post is saved.

commit 	3294fa6  incorrectly referenced this issue


list_columns('<database>', '<schema>', '<table>')

Or, a way for the existing func https://docs.glaredb.com/glaredb/sq-functions/list_tables/ to return column information along with tables.

Marking as medium since this will improve the sql editor experience.


Not working - including your example!

I tried to run my copy of boarding (which I installed a week ago, and it worked then) on heroku, and got:
"Something went wrong"
I then tried your example installation and the same thing happened.
Here's the log from my installation:
2015-08-14T19:36:14.415804+00:00 heroku[web.1]: Unidling
2015-08-14T19:36:14.416220+00:00 heroku[web.1]: State changed from down to starting
2015-08-14T19:36:18.372892+00:00 heroku[web.1]: Starting process with command bin/rails server -p 36205 -e production
2015-08-14T19:36:24.459038+00:00 app[web.1]: [2015-08-14 19:36:24] INFO  ruby 2.0.0 (2015-04-13) [x86_64-linux]
2015-08-14T19:36:24.458943+00:00 app[web.1]: [2015-08-14 19:36:24] INFO  WEBrick 1.3.1
2015-08-14T19:36:24.459592+00:00 app[web.1]: [2015-08-14 19:36:24] INFO  WEBrick::HTTPServer#start: pid=3 port=36205
2015-08-14T19:36:25.016358+00:00 heroku[web.1]: State changed from starting to up
2015-08-14T19:36:27.209969+00:00 heroku[router]: at=info method=GET path="/?token=(removed)" host=intense-forest-3864.herokuapp.com request_id=67e986a7-0d6b-47b5-b518-5f212cdf8412 fwd="<IP_ADDRESS>" dyno=web.1 connect=0ms service=675ms status=500 bytes=1754
2015-08-14T19:36:27.893753+00:00 heroku[router]: at=info method=GET path="/favicon.ico" host=intense-forest-3864.herokuapp.com request_id=a92052c4-59d8-46f3-a673-7cf0917469f8 fwd="<IP_ADDRESS>" dyno=web.1 connect=0ms service=6ms status=200 bytes=228
2015-08-14T19:36:40.070091+00:00 heroku[router]: at=info method=GET path="/?token=(removed)" host=intense-forest-3864.herokuapp.com request_id=ff0cffee-2632-4f6b-829c-626cf20b21fb fwd="<IP_ADDRESS>" dyno=web.1 connect=0ms service=423ms status=500 bytes=1754
2015-08-14T19:38:59.293794+00:00 heroku[router]: at=info method=GET path="/" host=intense-forest-3864.herokuapp.com request_id=aedca6c7-255c-41d1-9a85-8bf1ba6cc29d fwd="<IP_ADDRESS>" dyno=web.1 connect=1ms service=517ms status=500 bytes=1754
2015-08-14T19:46:51.926260+00:00 heroku[router]: at=info method=GET path="/" host=intense-forest-3864.herokuapp.com request_id=de48de70-e76f-45fb-b06a-9a3206550197 fwd="<IP_ADDRESS>" dyno=web.1 connect=7ms service=527ms status=500 bytes=1754
2015-08-14T19:46:52.780666+00:00 heroku[router]: at=info method=GET path="/" host=intense-forest-3864.herokuapp.com request_id=cc15d177-73cb-4878-a89c-b1e87760ed94 fwd="<IP_ADDRESS>" dyno=web.1 connect=4ms service=398ms status=500 bytes=1754
:(

PS Cool tools, thanks!

I just pushed an update, could you try again?

Did you happen to update the live example?  It still doesn't work...
https://boarding.herokuapp.com/

Sorry about this, working on a fix :+1:

We are also running into this. Just wanted to add myself to the thread. Thanks for boarding! Great tools!

This is now resolved: https://boarding.herokuapp.com
Please follow the update guide

Worked.  Thanks!
I followed your recommended update directions.
On Tue, Aug 18, 2015 at 7:16 AM, Felix Krause<EMAIL_ADDRESS>wrote:

This is now resolved: https://boarding.herokuapp.com
Please follow the update guide
Reply to this email directly or view it on GitHub:
https://github.com/fastlane/boarding/issues/9#issuecomment-132225099

:+1:


Destriping is not working

In the newest version, the destriping in the Sediment plugin is not working. It produces completely weird images.

Isn't it just the contrast of the RGB layers that needs to be adjusted? I pushed a small update that does this by default but you should be able to improve that already manually.


Symptoms-Checker [Desktop]: SC-Q3 Page Bugs

Goal
Fix the following bugs for SC-Q3 Pages for the Desktop view.
issue # 1 - Previous and Next Arrow buttons are overlapping with the symptom selections. (Mobile). Please add them into the bottom of the page that is visible.

PR for this issue is here: https://github.com/FightPandemics/FightPandemics/pull/2231


pkg/trace/agent: add "component2name" feature flag to facilitate Opentracing

The "component2name" feature flag determines the span component tag to become
the span operation name.
It works around the incompatibility between Opentracing and Datadog where the
Opentracing operation name is many times invalid as a Datadog operation name (e.g. "/")
and in Datadog terms it's the resource. Here, we aim to make the component the
operation name to provide a better product experience.

Are we fine with the fact that it's going to rename metrics?

I would expect so. Datadog will be working correctly when this feature is desired. Without it, the metrics were wrong and unusable to the customers in this situation.

I think the basic idea on how to handle opentracing spans is sound, but I question how it is enabled.
I think it would be better to distinguish the type of payload coming into the datadog trace agent.
This could be done via a custom header or a different endpoint.
That would allow one trace agent to handle both tracer and direct opentracing traffic.

@dougqh I like that idea. As usual, a feature flag is simply an unfinished feature. Eventually, if we want to integrate it, your proposal is sound.


split README and DEVELOPMENT

As the README occurs in the description of the project on sites like pypi, it might be good to split the README.md into two parts, s.t. the project description on the distributing sites is not 90% about development.

Regarding README, it might be worth looking at Michael Huckas template https://github.com/mhucka/readmine?tab=readme-ov-file#readmine-suggested-template-for-software-readmes

I just noticed on the ngo Release that the Readme.md should contain full links (not partial) otherwise the description on pypi.org and test.pypi.org will be broken.

I just noticed on the ngo Release that the Readme.md should contain full links (not partial) otherwise the description on pypi.org and test.pypi.org will be broken.

We could provide an absolute link to the project template. There might still be trouble if the template is used by another organization.


Renamed global preference file to preference.yaml from config.yaml

What is the purpose of this change? What does it change?
The global preference's default name changes to preference.yaml instead of config.yaml. As this file is present in the ~/.odo folder it will not colide with the config.yaml if someone chooses to create a component in home dir.

Was the change discussed in an issue?
fixes https://github.com/openshift/odo/issues/1766

How to test changes?

odo preference set Timeout 5 # this should create a ~/.odo/preference.yaml instead of ~/.odo/config.yaml

NOTE - Add this to the ChangeLog as this is a breaking change

/retest

/retest

No all the tests should work @cdrage

/retest

@girishramnani  We are not doing ensuring the backward compatibility after all?

@kadel according to the discussion in the issue, @jorgemoralespou said that having a changelog entry would be enough

@girishramnani can you please add how will the Release change entry look like?

/approve

/lgtm


Add permissions for recording audio

You should also override method onRequestPermissionsResult.

Which class is onRequestPermissionsResult() in?


Getting an Error with PostalCodeElement

Hi
I am trying to create my own form using react elements.
import React, { Component } from 'react';
import { injectStripe } from 'react-stripe-elements';
import { CardNumberElement, CardExpiryElement, CardCVCElement, PostalCodeElement } from 'react-stripe-elements';

class PaymentFormComponent extends Component {
  constructor(props) {
    super(props);
  }

  render() {
    return (

Payment For Invoice:

          Name on Card

            <input className="input is-large" type="text" onChange={this.onNameChange} />

          Card Number

            <CardNumberElement className="input is-large" />
            {/*  */}

          Expiry Date

            <CardExpiryElement className="input is-large" />

          CVC

            <CardCVCElement className="input is-large" />

        <PostalCodeElement  />

          Postal Code / Zip Code

            <PostalCodeElement  />

    );
  }
}

export default injectStripe(PaymentFormComponent);

but I get these error
Warning: React.createElement: type is invalid -- expected a string (for built-in components) or a class/function (for composite components) but got: undefined. You likely forgot to export your component from the file it's defined in, or you might have mixed up default and named imports.

Check the render method of `PaymentFormComponent`.
    in PaymentFormComponent (created by inject-PaymentFormComponent-with-domainStores-uiStores-routingStore)
    in inject-PaymentFormComponent-with-domainStores-uiStores-routingStore (created by InjectStripe(inject-PaymentFormComponent-with-domainStores-uiStores-routingStore))
    in InjectStripe(inject-PaymentFormComponent-with-domainStores-uiStores-routingStore) (created by CheckoutComponent)
    in Elements (created by CheckoutComponent)
    in div (created by CheckoutComponent)
    in CheckoutComponent (created by inject-CheckoutComponent-with-domainStores-uiStores-routingStore)
    in inject-CheckoutComponent-with-domainStores-uiStores-routingStore (created by Route)
    in Route (created by NavigationAreaComponent)
    in Switch (created by NavigationAreaComponent)
    in div (created by NavigationAreaComponent)
    in div (created by NavigationAreaComponent)
    in NavigationAreaComponent (created by inject-NavigationAreaComponent-with-domainStores-uiStores-routingStore)
    in inject-NavigationAreaComponent-with-domainStores-uiStores-routingStore (created by Route)
    in Route (created by withRouter(inject-NavigationAreaComponent-with-domainStores-uiStores-routingStore))
    in withRouter(inject-NavigationAreaComponent-with-domainStores-uiStores-routingStore) (created by Route)
    in Route (created by App)
    in Switch (created by App)
    in App (created by inject-App-with-domainStores-uiStores)
    in inject-App-with-domainStores-uiStores (created by Route)
    in Route (created by withRouter(inject-App-with-domainStores-uiStores))
    in withRouter(inject-App-with-domainStores-uiStores)
    in Provider
    in ErrorBoundary
    in Router
    in Provider

I am using  "react-stripe-elements": "^3.0.0",

Hi @chobo2,
We removed PostalCodeElement in v3.0.0. We suggest that you build your own
postal code input and pass the postal in when using createPaymentMethod, handleCardPayment, createToken, etc.

@dweedon-stripe
Why does it seem like it is still accessible when I try to import it
import {
  CardNumberElement,
  CardExpiryElement,
  CardCVCElement,
  PostalCodeElement
} from 'react-stripe-elements';

Also why was it removed?

Not sure what you mean. The export is undefined, which is why you see the error. Are you using Typescript? It looks like the third party typings, which we do not own or maintain, have not been updated to reflect the changes in v3.0.0
As to why it was removed: We removed it because there are a lot of corner cases in postal code validation. We determined that, given these issues that these corner cases created, it made more sense for users to collect postal code information with their own inputs where they would have more control over validation logic.


WIP: implement multi-namespace support

Description

carrying over work from @d-kuro
Relevant issues/tickets

Type of change

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

[ ] This change requires a documentation update
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] I have added a test case that will be used to verify my changes
[ ] Verified independently on a cluster by reviewer

Verification steps

Please don't review it yet, this is a very dirty rebase of the current work onto the master branch.

I'm really looking into  using this feature.
Currently I'm stuck with this operator, because I don't want to maintain multiple instances of the same operator in one cluster.

@bakito if you are feeling adventurous you might be interested in this: https://github.com/addreas/grafana-operator/commit/19d6ad0eb05f0cad225076f31c441ebc038f8828. It's definitely smaller in scope than this PR, but together with the --scan-all argument its been enough for my use (single grafana instance, watching all namespaces).

@addreas thank you very much for the hint. For my use-case I would need multiple instances of grafana in multiple namespaces.

@bakito Thanks Marc, I've also replied to your email, I'm working on this currently! Thanks for showing your interest!

@HubertStefanski yes, I saw it. Thank you very much for your reply.
If you have a version ready to test, feel free to contact me.

@HubertStefanski are you still working on this?


Custom tags for planner

You should be able to define custom tags.
Also use this issue to suggest more tag ideas.

@medensqui
I think we should make Labby part of planhub and have a happy API for CoursesPlus and other things.
Quote things by putting an arrow ">" in front of the line.

Also, I explained My Day to Malcolm, no reaction.

You would want a thing to show than lots of words...

You would want a thing to show than lots of words...


Added Mobile Menu Navigation

Added proper mobile navigation menu with a little bit of Alpine.JS

Also added "Open RFCs" and "Register" links to the navigation bar. So now we have 4 links for guests like this:

Nice!


Various fixes and improvements

Fixed: display properties reset turns off hardware DDC
Fixed: brief black screen upon changing space when using shade dimming
Asynchronous thread-safe debouncing DDC write for smoother sliders
Improved support for BetterDummy
Better support for common physical dummies identifying as 28E850
Inert dummy menu sliders are now hidden
Improved support for nongamma->nongamma mirroring scenarios
Compiled to run 10.14 (needed some minor changes) - compatibility is unofficial!
Updated README

Hey guys, please approve this if everything looks ok! Thanks a lot!

@waydabber I'll take a look when I'm done with work

I've left a comment on a (really) minor piece of code but everything else looks good to me

I fixed that but now you'll have to approve again. :)

(also tested and it's working just to make sure)


Property:email

Label
Email Address

Definition
Email address.

Usage

Existing property
Schema.org:email

Existing class
Schema.org:Person

Existing property identifier
https://schema.org/email

Format
Text

Required

Repeatable

Constraints

Examples
<EMAIL_ADDRESS>

Notes

Deprecated in favour of generic ContactDetail class


Updating go-toolset tag to 1.16.12

Which issue this PR addresses:
Fixes: Build failure due to incorrect image tag: https://dev.azure.com/msazure/AzureRedHatOpenShift/_build/results?buildId=51841300&view=logs&j=af1b0df7-00d6-590e-9da4-78867c0bc7a2&t=69aab5ed-905a-5c08-21b0-dc2b1ae43cf9&l=181
What this PR does / why we need it:
Image tag of 1.16 does not exist in the RH registry for UBI7: https://catalog.redhat.com/software/containers/ubi7/go-toolset/5ce879bcd70cc57c44b49684
Test plan for issue:
N/A
Is there any documentation that needs to be updated for this PR?
N/A

/azp run ci


Not working in MacOS Catalina - 10.15 Beta

When unzip and open the app, getting following error:
Application can't be open.

Does it work if you right-click the .app then choose Open there? (I'm not sure if the Terminus macOS app is signed.)


[FLINK-22177][table-api/doc] Add docs for time functions and time zone support

What is the purpose of the change

This pull request add documents for Table/SQL time functions and time zone support

Brief change log

Add documents for Table/SQL time functions and time zone support
Add examples for  time functions and time zone
Add explanation how to support DaylightSavingTime

Verifying this change
This change is a doc PR without any test coverage.
Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): (no)
The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
The serializers: (no)
The runtime per-record code paths (performance sensitive): ( no)
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
The S3 file system connector: (no)

Documentation

Does this pull request introduce a new feature? (no)
If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

Thanks @wuchong for the detailed review, I've address your comments and add more example.


macOS: Distorted Input Field When Editing Link Title

Just re-wrote and improved the animation in the details view. Turns out, this also fixed the distortion issue. Should be OK now in the latest commit.
Thanks for reporting!


fix: add missing write version test

fixes #88
This PR adds a missing test case for write version for Maven project type

[X] Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
[X] Ensure that the pull request title represents the desired changelog entry
[x] Please describe what you did
[x] Link to relevant issues in GitHub or Jira
[X] Link to relevant pull requests, esp. upstream and downstream changes
[x] Ensure you have provided tests - that demonstrates feature works or fixes the issue

Signed-off-by: Aditya Srivastava<EMAIL_ADDRESS>

@kwhetstone Gotcha! I will do that 😸


Add canvasboard logo

Add canvasboard logo beside the title in navbar

Hey, can I work on this one? :smile_cat::

@matheusmosca Sure :+1:

Something like this

Ok! I'll probably send a PR at the end of the day.


[Feature Request] Express, CSV/other import, "bulk add"

In similar vein to the CSV export for Express entries, I would like to have the ability to import CSV or other formatted data into Express Entities. This is so things like Bulk Adding can be done.
I'm not entirely sure the best way to do this, but one of the use-cases I have is for an Express Entity with a lot of different Attributes. For example, there are about 8 or 9 different Select Attributes with upwards of 138 different options spread across the Select Attributes alone.
So this is more about importing data at fairly large scale here.

This is a duplicate of https://github.com/concrete5/concrete5/issues/4474


Running functions from terraform

Hi Team,
Is it possible to run functions for the database using terraform? it would be great to have a help on this.
Regards

Hello @althaf004,
we have a Terraform Provider you can use to include database schema management into your terraform workflow.
It works both for versioned and declarative workflows. Let me know if you have any further questions.

hey @masseelch , will this migration include functions created under a schema?

Atlas does not support functions (yet). I don't have an exact release date for you, but we want to add support for this soon.

Hello @althaf004, what kind of functions do you want to run? That's SQL functions / procedures or something else?

i needed to run SQL functions / procedures

If I'm using AtlasGo to migrate tables and views to the production database, how would you recommend migrating functions to the target database?


Tasks queuing forever when ImagePullError

Problem: The pod was going in a pending stage when the task was created with an invalid/wrong image.
Proposed solution: When the Executor job is created, after a specified time limit, the status of all the scheduled pods will be checked. If the pods are in the running state, the get status method assumes the Executor job is running as expected and stops polling pods to find the status. However, if a pod is stuck in a pending stage after the time limit, the reason for the error is logged onto the stdout and  "Error" status is raised against the executor job. Finally, the failed Job and the pods are deleted from the cluster.
Sample TESK-API output for the failed Job
  "tasks" : [ {
    "id" : "task-5bf2f120",
    "state" : "SYSTEM_ERROR",
    "description" : "Demonstrates capturing stdout to file (and volumes).",
    "executors" : [ {
      "image" : "ubuntu_simple_test_image",
      "command" : [ "echo", "This will appear in stdout, but of the 2. executor." ],
      "stdout" : "/outputs/stdout"
    }, {
      "image" : "alpine",
      "command" : [ "cat", "/outputs/stdout" ]
    } ],
    "volumes" : [ "/outputs" ],
    "logs" : [ {
      "metadata" : {
        "USER_ID" : "anonymousUser"
      },
      "start_time" : "2020-07-08T16:42:51.000Z",
      "end_time" : "2020-07-08T16:47:48.000Z",
      "system_logs" : [ "{'message': 'Back-off pulling image \"ubuntu_simple_test_image\"',\n 'reason': 'ImagePullBackOff'}\nRemoving failed jobs\nCancelling taskmaster: Got status Error\n" ]
    } ],
    "creation_time" : "2020-07-08T16:42:51.000Z"
  } ]
}```

Codecov Report

Merging #23 into master will decrease coverage by 0.37%.
The diff coverage is 19.35%.

@@            Coverage Diff             @@
##           master      #23      +/-   ##
==========================================
- Coverage   27.55%   27.18%   -0.38%
==========================================
  Files           8        8
  Lines         606      629      +23
==========================================
+ Hits          167      171       +4
- Misses        439      458      +19

Impacted Files
Coverage Δ

src/tesk_core/pvc.py
0.00% <ø> (ø)

src/tesk_core/taskmaster.py
0.00% <0.00%> (ø)

src/tesk_core/job.py
33.33% <24.00%> (-7.21%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update acebd70...9894016. Read the comment docs.


Translate the button "today"

Hello,
How translate the button "today" for other language? It's possible? I look issues #252 but not found solution.
Grateful!

I found the solution: http://fullcalendar.io/docs/text/buttonText/


Browser back button with @IonicPage pages throws TypeError: e.done is not a function

Ionic version:  (check one with "x")
[ ] 1.x (For Ionic 1.x issues, please use https://github.com/ionic-team/ionic-v1)
[ ] 2.x
[x] 3.x - 3.6.0
I'm submitting a ...  (check one with "x")
[x] bug report
[ ] feature request
[ ] support request => Please do not submit support requests here, use one of these channels: https://forum.ionicframework.com/ or http://ionicworldwide.herokuapp.com/
Current behavior:
If we have 2 pages using @IonicPage annotation for deep linking, we navigate from Page 1 to Page 2 and click the browser back button, it throws an error.
Error: Uncaught (in promise): TypeError: e.done is not a function
TypeError: e.done is not a function
    at e._fireError (http://localhost:8101/build/vendor.js:1:280416)
    at e._failed (http://localhost:8101/build/vendor.js:1:280301)
    at http://localhost:8101/build/vendor.js:1:281125
...

EDIT: it also happens with the Android device back button.
Expected behavior:
Navigating back and forth with browser buttons work without error, same as what we would have by using the app buttons (e.g. header bar back button).
Steps to reproduce:

Online demo: open dev tool, click the button to navigate and click browser back button. See the error in the console. In dev mode, it is also freezing the screen since errors are strongly reported.
Demo app sources on github, you can check the code, run locally and check the commit for steps.
Approximate steps (details in the source commit):

Generate a project with Ionic CLI with blank template
Generate a new page (ionic generate page page1)
Edit the home page to use @IonicPage annotation, add the corresponding module and remove references from AppModule
Add a simple navigation directive somewhere in the home page: <button ion-button navPush="Page1Page">Go to page 1</button>

I couldn't make a working plunker with the new deeplink config (annotation and no direct references). My attempt

Ionic info: (run ionic info from a terminal/cmd prompt and paste output below):
cli packages:

    @ionic/cli-plugin-ionic-angular : 1.4.0 (C:\nw\proto\ion-test-simple-nav\node_modules\@ionic\cli-plugin-ionic-angular)
    @ionic/cli-utils                : 1.6.0 (C:\nw\proto\ion-test-simple-nav\node_modules\@ionic\cli-utils)
    ionic (Ionic CLI)               : 3.6.0 (C:\nw\proto\ion-test-simple-nav\node_modules\ionic)

local packages:

    @ionic/app-scripts : 2.1.3
    Ionic Framework    : ionic-angular 3.6.0

System:

    Node : v8.2.1
    OS   : Windows 10
    npm  : 5.3.0

Same stuff here :( Browser back button breaks the app with errors

In my small app, I couldn't find what could be broken in the production build, except a very unpleasant error logged. The navigation still worked. Although I wouldn't trust it in bigger apps.
But in development with Ionic CLI, yes, it is breaking the app (like any error).

Hello all! Thanks for using Ionic. We will look into this.

Getting similar error, shows error window, doesn't break my app after closing error window!
Error: Uncaught (in promise): TypeError: ti.done is not a function TypeError: ti.done is not a function     at NavControllerBase._fireError (http://localhost:8100/build/vendor.js:44066:16)     at NavControllerBase._failed (http://localhost:8100/build/vendor.js:44057:14)     at http://localhost:8100/build/vendor.js:44112:59     at t.invoke (http://localhost:8100/build/polyfills.js:3:9283)     at Object.onInvoke (http://localhost:8100/build/vendor.js:4770:37)     at t.invoke (http://localhost:8100/build/polyfills.js:3:9223)     at r.run (http://localhost:8100/build/polyfills.js:3:4452)     at http://localhost:8100/build/polyfills.js:3:14076     at t.invokeTask (http://localhost:8100/build/polyfills.js:3:9967)     at Object.onInvokeTask (http://localhost:8100/build/vendor.js:4761:37)     at c (http://localhost:8100/build/polyfills.js:3:13535)     at http://localhost:8100/build/polyfills.js:3:14107     at t.invokeTask (http://localhost:8100/build/polyfills.js:3:9967)     at Object.onInvokeTask (http://localhost:8100/build/vendor.js:4761:37)     at t.invokeTask (http://localhost:8100/build/polyfills.js:3:9888)     at r.runTask (http://localhost:8100/build/polyfills.js:3:5143)     at o (http://localhost:8100/build/polyfills.js:3:2203)     at <anonymous>

Same error here guys:
Runtime Error
Uncaught (in promise): TypeError: ti.done is not a function TypeError: ti.done is not a function at
NavControllerBase._fireError (http://localhost:8100/build/vendor.js:47902:16) at
NavControllerBase._failed (http://localhost:8100/build/vendor.js:47893:14) at
http://localhost:8100/build/vendor.js:47948:59 at t.invoke (http://localhost:8100/build/polyfills.js:3:9283) at
Object.onInvoke (http://localhost:8100/build/vendor.js:4657:37) at t.invoke
(http://localhost:8100/build/polyfills.js:3:9223) at r.run (http://localhost:8100/build/polyfills.js:3:4452) at
http://localhost:8100/build/polyfills.js:3:14076 at t.invokeTask
(http://localhost:8100/build/polyfills.js:3:9967) at Object.onInvokeTask
(http://localhost:8100/build/vendor.js:4648:37)

Stack
TypeError: ti.done is not a function
    at NavControllerBase._fireError (http://localhost:8100/build/vendor.js:47902:16)
    at NavControllerBase._failed (http://localhost:8100/build/vendor.js:47893:14)
    at http://localhost:8100/build/vendor.js:47948:59
    at t.invoke (http://localhost:8100/build/polyfills.js:3:9283)
    at Object.onInvoke (http://localhost:8100/build/vendor.js:4657:37)
    at t.invoke (http://localhost:8100/build/polyfills.js:3:9223)
    at r.run (http://localhost:8100/build/polyfills.js:3:4452)
    at http://localhost:8100/build/polyfills.js:3:14076
    at t.invokeTask (http://localhost:8100/build/polyfills.js:3:9967)
    at Object.onInvokeTask (http://localhost:8100/build/vendor.js:4648:37)
    at c (http://localhost:8100/build/polyfills.js:3:13535)
    at http://localhost:8100/build/polyfills.js:3:14107
    at t.invokeTask (http://localhost:8100/build/polyfills.js:3:9967)
    at Object.onInvokeTask (http://localhost:8100/build/vendor.js:4648:37)
    at t.invokeTask (http://localhost:8100/build/polyfills.js:3:9888)
    at r.runTask (http://localhost:8100/build/polyfills.js:3:5143)
    at o (http://localhost:8100/build/polyfills.js:3:2203)
    at <anonymous>

Environment
Ionic Framework: ^3.6.0
Ionic App Scripts: 2.1.3
Angular Core: 4.1.3
Angular Compiler CLI: 4.1.3
Node: 6.11.0
OS Platform: Linux 4.10
Navigator Platform: Linux x86_64
User Agent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/59.0.3071.115 Safari/537.36

I'm also having this error guys.

Guys, please click 👍 on the original post to add weight to this issue instead of answering +1 :)

Same issue, looks like it is not happening if you have page1 -> page2, but if you have page1 -> page2 -> page3 then it is happening on page1 when you press back button to return to previous screen.

I also have the same issue but when pop up to page not in history stack ( default behavior is creating instance of the page and set it as root for nav)
this.navCtrl.popTo('Page');

    @ionic/cli-plugin-cordova       : 1.6.1
    @ionic/cli-plugin-ionic-angular : 1.4.1
    @ionic/cli-utils                : 1.7.0
    ionic (Ionic CLI)               : 3.7.0

global packages:

    Cordova CLI : 7.0.1

local packages:

    @ionic/app-scripts : 2.1.3
    Cordova Platforms  : android 6.1.2 browser 4.1.0
    Ionic Framework    : ionic-angular 3.6.0

System:

    Node       : v8.2.1
    OS         : macOS Sierra
    Xcode      : Xcode 8.3.2 Build version 8E2002
    ios-deploy : 1.9.1
    ios-sim    : 5.1.0
    npm        : 5.3.0

Another one here: https://forum.ionicframework.com/t/history-back-error/100967 The topic also contains a Github repo of the bug in action. Clone, npm install, ionic serve and use browser back button to trigger.

With the same project source code, down grade packages ionic-angular to 3.5.3, and ionic to 3.6.0 seems to get browser back button working again (modify the package.json at the project root, and run npm install at the project root). Tested on a simple project and it worked for me, which may serve as a workaround till it's fixed if you don't mind regression and if it does not break other things.

However the browser forward/backward buttons seem to clear all NavController stack (worth a different bug i think), which does not act in the same way as using the ionic navigation gadgets.

Same issue
cli packages: (/Users/dev/DEV/MOBILE/myapp/node_modules)

    @ionic/cli-plugin-cordova       : 1.6.2
    @ionic/cli-plugin-ionic-angular : 1.4.1
    @ionic/cli-utils                : 1.7.0
    ionic (Ionic CLI)               : 3.7.0

global packages:

    Cordova CLI : 6.5.0

local packages:

    @ionic/app-scripts : 2.1.3
    Cordova Platforms  : android 6.1.2 ios 4.3.1
    Ionic Framework    : ionic-angular 3.6.0

System:

    Android SDK Tools : 25.2.3
    Node              : v6.11.0
    OS                : macOS Sierra
    Xcode             : Xcode 8.3.3 Build version 8E3004b
    ios-deploy        : 1.9.0
    ios-sim           : 5.0.8
    npm               : 5.3.0

Root cause of issue was attempting to call done callback before checking if it exists.  The PR which resolve this issue also provides better type support for the function callback so that type checking can detect potential issues.

Is anyone from Ionic going to resolve this issue?  It was introduced 3 weeks ago due to poor code testing and a PR was proposed over a week ago and still no one has responded.
Is anyone from the community aware of an easy way to maintain your own Ionic repo?  The design of the repo makes it impossible to simply link to a different github fork within the npm package.json.  I'm having to compile my changes and copy them locally before each build, but this process breaks when trying to run my automated build/deploy scripts.

@soumak77 actually you can make fork

Fork ionic
Run compile part from package.json and mv dist directory outside, into bare git repository that mirrored somewhere
Push changes into that repo

You can check my fork to see how you can make it

@ChezRD creating a bare git repo with just the dist folder is a good idea.  Are you able to use the git url in your package.json when doing this?

Yes. You can add my ionic-angular repo as npm package to test
22 авг. 2017 г. 2:34 пользователь "Brian Soumakian" <
<EMAIL_ADDRESS>написал:

@ChezRD https://github.com/chezrd creating a bare git repo with just
the dist folder is a good idea. Are you able to use the git url in your
package.json when doing this?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/ionic-team/ionic/issues/12499#issuecomment-323878854,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ADgbhJsqPFiu_ScrOIbZ0LLQe0Fg9Rhfks5sahQJgaJpZM4Omiz0
.

Is there any solution to this problem, cz I too am facing this issue and I need to publish my app on production. I cannot go live with this issue..

any word from Ionic team about this issue? 1 month has passed since this bug was introduced and still no fix though pull request was submitted by @soumak77 . Very disappointing ;(

Had this problem as well. Currently downgraded Ionic but it would be nice to run the latest version again.

@sommerper which downgraded version works?

Same problem.

@jerrydeng can't remember exactly what i changed but my package.json looks like this:
{
  "name": "xxxx",
  "version": "0.0.1",
  "author": "Ionic Framework",
  "homepage": "http://ionicframework.com/",
  "private": true,
  "scripts": {
    "clean": "ionic-app-scripts clean",
    "build": "ionic-app-scripts build",
    "lint": "ionic-app-scripts lint",
    "ionic:build": "ionic-app-scripts build",
    "ionic:serve": "ionic-app-scripts serve"
  },
  "dependencies": {
    "@angular/common": "4.1.3",
    "@angular/compiler": "4.1.3",
    "@angular/compiler-cli": "4.1.3",
    "@angular/core": "4.1.3",
    "@angular/forms": "4.1.3",
    "@angular/http": "4.1.3",
    "@angular/platform-browser": "4.1.3",
    "@angular/platform-browser-dynamic": "4.1.3",
    "@ionic-native/core": "3.12.1",
    "@ionic-native/deeplinks": "^4.1.0",
    "@ionic-native/splash-screen": "3.12.1",
    "@ionic-native/status-bar": "3.12.1",
    "@ionic/storage": "2.0.1",
    "cordova-plugin-console": "^1.0.5",
    "cordova-plugin-device": "^1.1.4",
    "cordova-plugin-splashscreen": "^4.0.3",
    "cordova-plugin-statusbar": "^2.2.2",
    "cordova-plugin-whitelist": "^1.3.1",
    "ionic-angular": "3.5.3",
    "ionic-plugin-keyboard": "^2.2.1",
    "ionicons": "3.0.0",
    "rxjs": "5.4.0",
    "sw-toolbox": "3.6.0",
    "zone.js": "0.8.12"
  },
  "devDependencies": {
    "@ionic/app-scripts": "2.1.3",
    "@ionic/cli-plugin-cordova": "1.6.2",
    "@ionic/cli-plugin-ionic-angular": "1.4.1",
    "ionic": "3.6.0",
    "typescript": "2.3.4"
  },
  "description": "An Ionic project",
  "cordova": {
    "plugins": {
      "cordova-plugin-console": {},
      "cordova-plugin-device": {},
      "cordova-plugin-splashscreen": {},
      "cordova-plugin-statusbar": {},
      "cordova-plugin-whitelist": {},
      "ionic-plugin-keyboard": {}
    },
    "platforms": []
  }
}

Is there any solution available? we are  not able to use  latest ionic update

@sommerper thank you

Also got this, everything is up to date.

@vhb56 - the PR that fixes this has been merged, but we are not ready to do a release yet. We are trying to get a few more fixes in.

@kensodemann - Any idea on timeline for this release?  I'm trying to determine if I should roll back to 3.5.3 or wait for the fix.

Preparing to create a release that will fix this, we created an ionic-angular@nightly with @soumak77's PR merged into it. While I believe his changes were necessary (especially the guard around not calling done() from tabs if it does not exist, it did not actually fix this issue so I am re-opening it.

@danbucholtz found and fixed the underlying issue. We now have a nightly build that includes the fix for this issue. I have tested that build using the original repo supplied by @antoineol and it solves this issue.
If you would like to test in your own project(s) you can do an npm install ionic-angular@nightly to get this build. This is being done in preparation for a new release so any testing you could do would be very helpful.

I'v had the same problem in my simple project - after nightly build everything works perfect :) thank you very much!

Looks like this was fixed in 3.6.1 for me too.  Thanks!

PLZ help guys, I tried "npm update -g cordova ionic" and when I do ionic -v it says I have 3.18.0 but in the browser I still have the same issue.
Chrome browser console: Ionic .... it says I have version 3.6.0
How do I correctly update???

@FanFanFantastic remove node_modules


Introduction to C++ Fundamentals: Syntax, Structure, and Basic Compon…

Introduction to C++ Fundamentals: Syntax, Structure, and Basic Components. #526

Could you please review it? I have added more information in the introduction to CPP section.

@subhadipbhowmik I have added more to the introduction to cpp section. could you please review it.

@subhadipbhowmik Could you please review my pull request

@subhadipbhowmik Could you please review my pull request

Just wait a while

@subhadipbhowmik Could you please generate a Tag for this. My PR that was merged is not being counted.


Improve type check messages for some array functions

Partially addressing #4969. It fixes diagonal, ..., spatial_transformer_grid in alphabetical order of names under chainer.functions.array.

Jenkins, test this please.

Jenkins CI test (for commit 5cda64f23013aec9c4a3297ba007dbbcb334b1c9, target branch master) failed with status FAILURE.
(For contributors, please wait until the reviewer confirms the details of the error.)


Add department field next to affiliation field

See https://projects.invisionapp.com/share/NP138M0QX7T3#/screens/473166568 for design and https://docs.google.com/presentation/d/1FI9yn7vUSeX7Yd5IemrLxnYH2__JlTxNwgP8guATb18 for requirements

Departments should be entered in a separate field.
This would also allow us to enter identifiers that are for specific departments, which LC and Wikidata both support.
Department should be optional.
Handle institutions as authors and contributors in the same way.

@peetucket Isn't this done?

Oh maybe it is.  Just saw it on QA (i guess you did it as part of the other work)?

Yes, as part of the initial implementation of affiliations. Just wanted to make sure that I understood correctly.


:sparkle: use top level groups for api and types

Description
Implements #1265
Checklist

[x] My changes follow the contributing guidelines of this project.
[x] I have performed a self-review of my code.
[x] I have made corresponding changes to the documentation.
[x] I have added tests that prove my fix is effective or that my changes work.
[x] New and existing unit tests pass locally with my changes.

coverage: 94.439% (-0.1%) from 94.554%
when pulling 55b90c1853003a850ba3f72342e2fe66dd98a5bf on feat/1265-separate-api-from-types
into 3f5494afd2102db9d2c349f4cf005f832bf196d3 on main.

coverage: 94.439% (-0.1%) from 94.554%
when pulling 55b90c1853003a850ba3f72342e2fe66dd98a5bf on feat/1265-separate-api-from-types
into 3f5494afd2102db9d2c349f4cf005f832bf196d3 on main.


Replace receipt - Scan feature does not work after replacing a receipt

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: v9.0.66-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/5255733
Email or phone of affected tester (no customers<EMAIL_ADDRESS>Issue reported by: Applause Internal Team
Action Performed:

Open the URL: https://staging.new.expensify.com/
Loggin
Go to a WS
Click on the compose box '+' button inside the chat.
Submit a scan expense
Wait until the scan is finished
Click on the thumbnail of the receipt
Click on the tree dots at top right corner
Replace the receipt to one with clear and valid data

Expected Result:
After the receipt is replaced, the scan feature should work replacing: Amount, Merchant, and so on.
Actual Result:
When the receipt is replaced, the scanning feature does not work and an error message is displayed.
Error Message - "Receipt scan incomplete. Please verify details manually:"
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android: Standalone
[ ] Android: HybridApp
[ ] Android: mWeb Chrome
[ ] iOS: Standalone
[ ] iOS: HybridApp
[ ] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[ ] MacOS: Desktop

Screenshots/Videos
https://github.com/user-attachments/assets/ca99b764-da4f-4091-a6e9-7f9ba183808f

View all open jobs on GitHub

As I am reviewing this, I see that the tester purposely selected a receipt that was "blurry/incomplete" based on the file name.
However, once they uploaded that receipt, they manually entered the total amount. When you upload another receipt, it is not going to SmartScan properly because you'e manually entered the total and now what you've entered does not match what is on the new receipt. And even if it does, it is going to focus on the manual override instead, which is why it is asking you to continue manually entering details.
This is not a bug, but as the system is designed 👍


generate for loop issue

I have a project that instantiates a few FIFOs using generate for.
covered score crashes with
ERROR!  Referencing undefined named block hierarchy (read_st) in module iob_fifo_async, file iob_i2s_tdm_pp.v, line 747
Removing the generate and instantiating a single FIFO it works
I can provide more info if this is issue is to be worked on.
Thanks

Sure, I think we need a bit more details.

Thanks, this tool is very nice.
Since the code is confidential I will use some snippets.
The culprit after quite a few hours debugging:
//localparam i=0;//use this and comment the 3 lines below to suppress generate for debugging
genvar i;
generate
  for (i = 0; i < N_TXDATA_PINS; i = i+1) begin : tx_fifo_array

     assign txfifo_write[i] = (i == TXFIFO_SELECT) ? (txfifo_wr_pulse| dma_write) : 1'b0;

     //BLOCK TX FIFO Array & These FIFOs are written by CPU or DMA.

     iob_fifo_async
       #(
         .W_DATA_W(AXIL_DATA_W),
         .R_DATA_W(AXIL_DATA_W),
         .ADDR_W(TXFIFO_ADDR_W)
         )
     txfifo
       (
        .rst(TXSOFT_RST),

        //write port
        .w_clk(clk),
        .w_empty(),
        .w_full(txfifo_full[i]),
        .w_data(txfifo_wdata),
        .w_en(txfifo_write[i]),
        .w_level(txfifo_level[i]),

        //read port
        .r_clk(txbclk_in),
        .r_full(),
        .r_empty(txfifo_empty[i]),
        .r_data(txfifo_rdata[i]),
        .r_en(txfifo_read),
        .r_level()
        );

     //transmit shift register
     reg [AXIL_DATA_W-1:0] txshift_reg;
     always @(posedge txbclk_in, posedge txbrst) if(txbrst) txshift_reg <= 1'b0; else if(txshift_reg_ld) txshift_reg <= (txbswrst? 1'b0: txfifo_rdata[i]); else if (txshift_reg_en) txshift_reg <= (txshift_reg << 1);
     assign txsdata[i] = txshift_reg[AXIL_DATA_W-1];

  end

endgenerate
The error is  ERROR! Referencing undefined named block hierarchy (read_st) in module iob_fifo_async, file iob_i2s_tdm_pp.v, line 747
This line is the very first always that it finds inside FIFO:
//
//READ STATE MACHINE
//
//read state
reg [1:0]                  r_st, r_st_nxt;
always @(posedge r_clk, posedge rst) begin : read_st
if(rst)
r_st <= INIT;
else
r_st <= r_st_nxt;
end
.....
Any ideas? If you need more info, I can try to send a simple one by email.

Are you sure this is related to this project? That doesn't look like Ruby code.


Nothing should happen when user taps on “Send” button again on second request if user performed same action for another request earlier

Frequency: 100%
Repro on build version: Test flight build V1.12.0(49) , Android Internal Build V1.12.0(1004294340)
Repro on devices: Samsung Galaxy A5(7.0), iPhone XR (14.2),iPhone SE (13.4.1)
Testing Account:<PHONE_NUMBER> / Backup Key
Pre-condition: Users should have more than one request In-app notifications.
Repro Steps:

Launch the application & login with a test account.
Go to home screen & open “# Pending  requests” In-app CTA & tap on “View All” button.
Now tap on the “Send” button of the first request.
Now make sure that the continuous loading indicator should display instead of the Send button.
Now  tap on the Send button of another request before completing the loading indicator of the firstly tapped send button.
Observed that,
Current Behavior:  Continuous loading indicator displayed for second request also.
Expected Behavior:  Nothing should happen when the user taps on the Send button of the second request as first request sending amount is in process.
Impact: Bad user Experience.
Investigation: Also it is observed that, one by one Sending screens are displayed instead for last one when user taps on two Send buttons for different requests.
Attachment: NothingShouldHappenForSecondSendButton.mp4

Hi I have verified this issue using  latest Android internal build V1.15.1 and Test Flight 1.15.1 & observed that issue is still reproduced.
Verified On Devices: iPhone SE (14.2), Samsung Galaxy A5(7.0)

@ValoraQA can you please retest on v1.20.2 as this should be fixed by #985.

Hey @MuckT We have verified this issue using latest Android internal build V1.20.2 and Test Flight 120.2  & observed that issue is still reproduced.
Verified On Devices: Redmi Note 8 (9.0), iPhone 6+ (12.4.5)
Attachment: IssueStillRepro


Add an example of wasm2asm and wasm-bindgen

This commit adds an example of executing the wasm2asm tool to generate asm.js
output instead of WebAssembly. This is often useful when supporting older
browsers, such as IE 11, that doesn't have native support for WebAssembly.

cc @sendilkumarn

@alexcrichton seems good to me 👍


Fix 2.0.1 release on NPM

Hello,
Im currently upgrading one of our setups, and I noticed that you released a 2.0.1 version. However on NPM it is still defined as 2.0.0: https://www.npmjs.com/package/tde-webpack-mjml-plugin
This gives errors when upgrading to webpack 5 unfortunately :(
Is this something you could look into to fixing?
npm ERR! code ETARGET
npm ERR! notarget No matching version found for<EMAIL_ADDRESS>npm ERR! notarget In most cases you or one of your dependencies are requesting
npm ERR! notarget a package version that doesn't exist.

Thanks for flagging this @1337LutZ!
A fix (2.0.2) has just been pushed to both NPM and Github that should resolve this issue.

Awesome, thanks for the quick fix. It works 👍🏻


Return Executor::fetch stream

Hello!
I've been developing CLInvoice using SQLx and was looking to optimize the following situation:

Call a function, passing in a match condition in order to receive a Vec of matching DB rows.
Vec::into_iter the result and recollect the rows into a HashMap keyed by ID.

Note: I can't simply return this HashMap from the original function, because there are other callers of the function which do want the Vec

I figured I could optimize it by providing an alternate function that forwards the Executor::fetch stream (mapped to my concrete type, of course) so the caller can collect to whatever data structure they want. However, this is impossible, because Executor::fetch asks for a Query— unless I have a &'static str (which eliminates the possibility of a dynamic match condition) I cannot return the borrowed String that sqlx::query requires.

You can see the full context here (note: development started before QueryBuilder and I have yet to migrate)

What can I do in this situation?

I ended up doing three things:

I wrote a formatting module to make writing different SQL clauses easier
I simplified my schema as much as possible
I rewrote all my queries (example) to avoid manual joins


h2/client(1.0.0-rc4): panic on a double poll on Select

Version
hyper 1.0.0-rc4
Platform
Linux 5.15.109+ SMP x86_64 GNU/Linux
Description
Deno is currently using the RC versions of hyper 1.0 and it recently upgraded from -rc3 to -rc4: https://github.com/denoland/deno/pull/19987.
After that we started seeing occasional but frequent panics due to a double poll on a Select future:
thread 'main' panicked at 'cannot poll Select twice', ~/.cargo/registry/src/index.crates.io-6f17d22bba15001f/futures-util-0.3.28/src/future/select.rs:112:42
stack backtrace:
   0: rust_begin_unwind
             at ./rustc/8ede3aae28fe6e4d52b38157d7bfe0d3bceef225/library/std/src/panicking.rs:593:5
   1: core::panicking::panic_fmt
             at ./rustc/8ede3aae28fe6e4d52b38157d7bfe0d3bceef225/library/core/src/panicking.rs:67:14
   2: core::panicking::panic_display
             at ./rustc/8ede3aae28fe6e4d52b38157d7bfe0d3bceef225/library/core/src/panicking.rs:150:5
   3: core::panicking::panic_str
             at ./rustc/8ede3aae28fe6e4d52b38157d7bfe0d3bceef225/library/core/src/panicking.rs:134:5
   4: core::option::expect_failed
             at ./rustc/8ede3aae28fe6e4d52b38157d7bfe0d3bceef225/library/core/src/option.rs:1932:5
   5: <futures_util::future::select::Select<A,B> as core::future::future::Future>::poll
   6: <hyper::proto::h2::client::H2ClientFuture<B,T> as core::future::future::Future>::poll
   7: tokio::runtime::task::harness::Harness<T,S>::poll
   8: tokio::runtime::scheduler::current_thread::Context::run_task
   9: tokio::macros::scoped_tls::ScopedKey<T>::set
  10: tokio::runtime::scheduler::current_thread::CurrentThread::block_on
  11: tokio::runtime::runtime::Runtime::block_on
  12: <omitted>::main
note: Some details are omitted, run with `RUST_BACKTRACE=full` for a verbose backtrace.

I don't have a reproducer or a test for this, which I think is the result of a race.

I can't bisect this, but looking through the git-log I think this is a regression introduced in https://github.com/hyperium/hyper/pull/3184.
I put together https://github.com/hyperium/hyper/pull/3290 to hopefully fix this.


No direct calls to pedersen from TS

Description
Fixes #435
Checklist:

[ ] I have reviewed my diff in github, line by line.
[ ] Every change is related to the PR description.
[ ] I have linked this pull request to the issue(s) that it resolves.
[ ] There are no unexpected formatting changes, superfluous debug logs, or commented-out code.
[ ] The branch has been merged or rebased against the head of its merge target.
[ ] I'm happy for the PR to be merged at the reviewer's next convenience.

Closed for now to not clutter open PR page


chore(deps): upgrade dev dependencies

Upgrades project dependencies. See details in workflow run.

Automatically created by projen via the "upgrade-dev-dependencies-k8s-26-main" workflow

⚪ Backport skipped
The pull request was not backported as there were no branches to backport to. If this is a mistake, please apply the desired version labels or run the backport tool manually.
Manual backport
To create the backport manually run:
backport --pr 3473

Questions ?
Please refer to the Backport tool documentation


Soql and Design changes

Changes Made

utilityVariables.cls -> Included the regex for SOQL_EXECUTE_BEGIN , SOQL_EXECUTE_END
SoqlUtility.cls -> added condtions to add soql begin and exit
LogLineWrapper.js -> Added condtional styling class SOQLB & SOQLE
LogLineWrapper.css -> added styling class SOQLB & SOQLE for color in Detailed log viewer
Added Navbar and some small design changes in components.

@charangirijala
Please review the changes

Hello @Sreshtag
Can you plz add screeshots of the 2 soql statemnts in the detailed log viewer


Distributed solution？

Summary
Need distributed turn solution to achieve high performance and high availability.
Describe alternatives you've considered
coturn solution: https://github.com/coturn/coturn/wiki/TURN-Performance-and-Load-Balance

im thinking use Dockerized and use AWS Network Load Balancer,

I'm not sure what this issue is requesting.
There's nothing preventing you from deploying an army of TURN servers, and using a frontend that returns alternate server replies.  A cleaner solution would be to have the clients load distribute, by having a different ICEConfiguration for each client.

I try to deploying a cluster of turn servers behind a load balancer, but it's not work, because turn seems to use different ports to provide relay candidate and transfer data. Maybe I need a service finder to monitor turn servers and provide high performance.

STUNner solves this exact problem with Kubernetes:  https://github.com/l7mp/stunner

Load-balancing using a 5-tuple should work as each client gets assigned to the same TURN server as long its tuple stays the same. So there is no need to synchronize allocations/permissions between the servers.
I dont think synchronizing state between a fleet of distributed TURN servers is necessary here.
I will close the issue unless the issue creator further details what feature he is missing.


Run everything through gofmt.

Using the "simplify code" option, because more simple is more better!

It's weird that the fixchain stuff has changes when run through gofmt, as I ran it all through gofmt when it was written.  In fact, when I run gofmt on it even now, none of these changes appear... are you using some swanky version of gofmt?

As mentioned in the description, I used the -s ("simplify code") option. Without it, the changes were much more limited, but I really like simpler code. 😃

My bad for not thoroughly reading the description.  All good :)


Clarify the purpose of BUILDKITE_NO_COMMAND_EVAL

This clarifies the purpose of the BUILDKITE_NO_COMMAND_EVAL option.
It adds this section:

@plaindocs can you please look into this case of vale supposedly going rogue? It seems to ignore the escaping.


Service: Remove controller.service.suffix & controller.service.internal.suffix.

Tests on workload clusters (not always required)
For changes in the chart, chart templates, and ingress controller container images, I executed the following tests
to verify them working in live enviromnents:

Test / Provider
AWS
Azure
KVM

Upgrade from previous version
✓
✓

Existing Ingress resources are reconciled correctly
✓
✓

Fresh install
✓
✓

Fresh Ingress resources are reconciled correctly
✓
✓

Testing was done using hello-world-app.
Hint for KVM:
kubectl port-forward -n kube-system svc/nginx-ingress-controller-app 8080:80
ingress_domain=host.configured.in.ingress; curl --connect-to "$ingress_domain:80:<IP_ADDRESS>:8080" "http://$ingress_domain" -v

If the Service's name changes due to removing either controller.service.suffix or controller.service.internal.suffix, Helm will create the new service and remove the old one. In case of LoadBalancer services, this might take a few moments. Anyway: Things break, there will be an outage.
This is why we're going to release this in a major release and suggest to first deploy the new release and then remove the old one after ensuring the former on is working & DNS got updated.


[Wallet-POS] When mining, wallet is able to lose track of coins

Started mining on testnet with 500k coins, after some time I only have 340k coins

I beleive this is related to #405.

I don't know, #405 crashes the node. This one just loses coins over the time without any node stability issue.

#405 has been resolved, but the staking wallet seems to still lose track of the coins.

 [Wallet-POS] When mining, wallet is able to lose track of coins

Is this still an issue @Aprogiena ?

I believe so, because no one investigated the cause and no one fixed it yet and it was recently confirmed.

I did fix the wallet crash on reorg in the wallet, but if you still get this bug we need to investigate.

do you have a copy of your wallet file?
should be a *wallet.json file in %appdata%\StratisNode\stratis\StratisTest

I do have that, but I think we don't have enough logs in the wallet part. I haven't focused on this issue yet. I believe a correct approach here is to add logs to wallet, then reproduce the issue, then check the logs and possibly compare with the wallet file. Just using the wallet file is probably too much work as it is almost 10k line file.

yeah but the wallet file can give me some clues. Do you mind sending it to me @Aprogiena ?

np, if you want to spend time on this, sending via slack

Alright, so we've got something here. So, I've added couple more logs to test this issue. So, now I can see Wallet contains {0} coins. which is a total number of coins, coming from this call:
this.walletManager.GetSpendableTransactionsInWallet(walletSecret.WalletName, 0);

Then I have the set that is used for staking, which is coming from
this.walletManager.GetSpendableTransactionsInWallet(walletSecret.WalletName, 1);

and is logged as Wallet contains {0} confirmed coins..
So the first gives me total number of coins that the wallet is aware of and the second gives me how many coins in total can possibly be used in a new round for staking (those are then filtered even more as per their maturity).
So we were staking for some time:
[2017-10-07 14:53:51.5570 3222] TRACE: Stratis.Bitcoin.Features.Miner.PosMinting.GenerateBlocks ()
[2017-10-07 14:53:51.5570 3222] TRACE: Stratis.Bitcoin.Features.Miner.PosMinting.GenerateBlocks Current coinstake time<PHONE_NUMBER> is not greater than last search timestamp<PHONE_NUMBER>.
[2017-10-07 14:53:51.5570 3222] TRACE: Stratis.Bitcoin.Features.Miner.PosMinting.GenerateBlocks (-)[NOTHING_TO_DO]

and then a new round of staking started:
...
[2017-10-07 14:53:53.3843 3235] TRACE: Stratis.Bitcoin.Features.Miner.PosMinting.GenerateBlocks Wallet contains 1000751.00450280 coins.
...

Then a list of UTXOs was in log from this thread 3235, which is the staking loop.
Then we can see in the log:
[2017-10-07 14:53:54.3166 6] TRACE: Stratis.Bitcoin.Features.Consensus.PosConsensusValidator.CheckBlockHeader ()

So suddenly a different thread (consensus loop) is coming with a new block validation.
The new block is validated and executed as expected in AcceptBlock. What is weird that we start to see the following warnings:
[2017-10-07 14:53:54.6011 6] WARN: Stratis.Bitcoin.Features.Wallet.WalletSyncManager.ProcessBlock Wallet is behind the best chain and the next block is not found in store
[2017-10-07 14:53:54.7881 6] WARN: Stratis.Bitcoin.Features.Wallet.WalletSyncManager.ProcessBlock Wallet is behind the best chain and the next block is not found in store

Something is wrong.
The previous state of chains and its transition:
[2017-10-07 14:53:52.6324 3221] INFO: Stratis.Bitcoin.FullNode.<StartPeriodicLog>b__70_0 ======Node stats====== 10/07/2017 14:53:52 agent StratisBitcoin:1.0.2
Headers.Height:        140152   Headers.Hash:         bfcc72b382af6ccafc8701ecce27938c55f93df5457a31999efec20796d054ce
Consensus.Height:      140152   Consensus.Hash:       bfcc72b382af6ccafc8701ecce27938c55f93df5457a31999efec20796d054ce
BlockStore.Height:     140152   BlockStore.Hash:      bfcc72b382af6ccafc8701ecce27938c55f93df5457a31999efec20796d054ce
Wallet.Height:         140152   Wallet.Hash:          bfcc72b382af6ccafc8701ecce27938c55f93df5457a31999efec20796d054ce

--->

[2017-10-07 14:53:57.6348 3276] INFO: Stratis.Bitcoin.FullNode.<StartPeriodicLog>b__70_0 ======Node stats====== 10/07/2017 14:53:57 agent StratisBitcoin:1.0.2
Headers.Height:        140153   Headers.Hash:         885054095fe7028d0912ea5fd3e678757eec122b483e0a402c3ac4542c273bbe
Consensus.Height:      140153   Consensus.Hash:       885054095fe7028d0912ea5fd3e678757eec122b483e0a402c3ac4542c273bbe
BlockStore.Height:     140151   BlockStore.Hash:      fc66f8964e2f118d672e2adf9741836f4c170bda1564ffe0c58051f1714f3cc1
Wallet.Height:         140151   Wallet.Hash:          fc66f8964e2f118d672e2adf9741836f4c170bda1564ffe0c58051f1714f3cc1

Meanwhile the staking thread is still analyzing UTXOs:
[2017-10-07 14:53:54.7881 3235] TRACE: Stratis.Bitcoin.Features.Miner.PosMinting.GenerateBlocks Wallet contains 1000751.00450280 confirmed coins.

So, what we can see here is that the coins available for staking are actually all the coins that the wallet holds. That is correct. We then try to find a solution:
[2017-10-07 14:53:54.8821 3235] TRACE: Stratis.Bitcoin.Features.Miner.PosMinting.StakeAndSignBlock Search interval set to 16, last coinstake search timestamp set to<PHONE_NUMBER>.

and a filtering as per coin maturity is done, at which end we have:
[2017-10-07 14:53:56.3666 3235] INFO: Stratis.Bitcoin.Features.Miner.PosMinting.CreateCoinStake Node staking with<PHONE_NUMBER>0280 (23.35 % of the network weight 4261015.23154583), est. time to find new block is 00:04:34.

This is absolutely fine. We did find some blocks recently, so not all coins are available for staking now.
However, staking code detects reorg:
[2017-10-07 14:53:56.3666 3235] TRACE: Stratis.Bitcoin.Features.Miner.PosMinting.CreateCoinStake Trying UTXO from address 'TTxekXWzTuqPfynmc2gaMPaizLUKNvHXhA', output amount 7813.48000000...
[2017-10-07 14:53:56.3666 3235] TRACE: Stratis.Bitcoin.Features.Miner.PosMinting.CreateCoinStake (-)[REORG]:false

Consensus loop gets another block:
[2017-10-07 14:53:56.3666 6] TRACE: Stratis.Bitcoin.Features.Consensus.PosConsensusValidator.ContextualCheckBlockHeader Height of block is 140153, block timestamp is<PHONE_NUMBER>, previous block timestamp is<PHONE_NUMBER>, block version is 0x7.

Then the next staking round starts, but there is nothing to do:
[2017-10-07 14:53:56.8703 3235] TRACE: Stratis.Bitcoin.Features.Miner.PosMinting.GenerateBlocks New block '885054095fe7028d0912ea5fd3e678757eec122b483e0a402c3ac4542c273bbe/140153' detected, setting last search time to its timestamp<PHONE_NUMBER>.
[2017-10-07 14:53:56.8703 3235] TRACE: Stratis.Bitcoin.Features.Miner.PosMinting.GenerateBlocks Current coinstake time<PHONE_NUMBER> is not greater than last search timestamp<PHONE_NUMBER>.
[2017-10-07 14:53:56.8703 3235] TRACE: Stratis.Bitcoin.Features.Miner.PosMinting.GenerateBlocks (-)[NOTHING_TO_DO]

that is normal. But as the time goes up, the next round starts and suddenly:
[2017-10-07 14:54:09.8666 2395] TRACE: Stratis.Bitcoin.Features.Miner.PosMinting.GenerateBlocks Wallet contains<PHONE_NUMBER>0280 coins.
...
[2017-10-07 14:54:11.2012 2395] TRACE: Stratis.Bitcoin.Features.Miner.PosMinting.GenerateBlocks Wallet contains<PHONE_NUMBER>0280 confirmed coins.

Coins are missing.
So we need to find which coins are actually missing.
I just send this comment to avoid data loss and will continue.

We can also see that at the time of the problem, this happened
[2017-10-07 14:53:53.9443 6] TRACE: Stratis.Bitcoin.Features.Consensus.CoinViews.CachedCoinView.Rewind ()

we know that thread 6 is the consensus loop thread.

To recap chains:
140150 - 96e24257f5cc45b9883982448b84f4a8ab961d3aa5a76964d325b9e94e7e7143 (mined NOT by our node)
140151 - fc66f8964e2f118d672e2adf9741836f4c170bda1564ffe0c58051f1714f3cc1 (mined NOT by our node)
140152a - bfcc72b382af6ccafc8701ecce27938c55f93df5457a31999efec20796d054ce (mined **by our node**)
-> reorg
140152b - a125b4fc59368dc1fe0c66a522b3ad508e603f5f916e7c0f14710ed5dad1864f (mined NOT by our node)
140153b - 885054095fe7028d0912ea5fd3e678757eec122b483e0a402c3ac4542c273bbe (mined NOT by our node)
-> reorg
140153c - beaab6420922fd0027ef87c192e64aa74dee5c2275affc4aeadc9f1ffd491b47 (mined NOT by our node)
140154c - 3fd5d9ce0aeaa9728178d0929c6bf0d6c597f8ac47344af99f1e5a0c355d3f2e (mined NOT by our node)

Having a diff between UTXO sets before and after (while losing 978.56 coins meanwhile):
Comparing files list1b.txt and LIST2B.TXT
***** list1b.txt
UTXO '22b0f5454b017f12660f2ba2c43167a17c467c563779c8662981cafb692f04ab/1' with value 1954.12000000.
UTXO '23628d6bdb01d7f8012a082e21f26648b1cf523d90b2d3e16d2ad39c5e173e8e/1' with value<PHONE_NUMBER>0.
UTXO '23628d6bdb01d7f8012a082e21f26648b1cf523d90b2d3e16d2ad39c5e173e8e/2' with value<PHONE_NUMBER>0.
UTXO '2562cf7ae209960fa7d8fe26025f6165346f3ef2fbcef5197ee9767311508a9e/1' with value<PHONE_NUMBER>0.
***** LIST2B.TXT
UTXO '22b0f5454b017f12660f2ba2c43167a17c467c563779c8662981cafb692f04ab/1' with value 1954.12000000.
UTXO '2562cf7ae209960fa7d8fe26025f6165346f3ef2fbcef5197ee9767311508a9e/1' with value<PHONE_NUMBER>0.
*****

This reveals that two outputs from transaction 23628d6bdb01d7f8012a082e21f26648b1cf523d90b2d3e16d2ad39c5e173e8e gone missing. Unsurprisingly, this is most likely the coinstake transaction of block 140152a which was then reorged to 140152b, which probably caused the coins to be missing.

Therefore: if you mine a block, which is reorged then, you lose track of coinstake transaction outputs

Not only that, it seems that if you sent any transaction (not just coinstake) to a block that was reorged, the wallet will lose track of it.
The only way for the wallet to be aware of a transaction is via AddTransactionToWallet. This method is only called when a new transaction is observed and propagated via signals.
When a reorg happens, RemoveBlocks is called. The interesting part of this method is this:
                IEnumerable<HdAddress> allAddresses = this.keysLookup.Values;
                foreach (HdAddress address in allAddresses)
                {
                    List<TransactionData> toRemove = address.Transactions.Where(w => w.BlockHeight > fork.Height).ToList();
                    foreach (TransactionData transactionData in toRemove)
                        address.Transactions.Remove(transactionData);
                }

As we can see this rolls backs transactions from the new blocks. This is correct approach except that you need not only to remove new transactions, but you also need to add transactions that were removed (i.e. spent in these new blocks). This is not happening anywhere in this method (or any other, but it belongs here).
So, we mined a block, this means we spent UTXO as a coinstake transaction and created couple new outputs. Then this block was reorged and this method RemoveBlocks was called, which removed the new couple, but did not returned us the UTXO from coinstake. Therefore we lost track of those coins.

If you notice RemoveBlocks  is called from sync manager in case of a reorg, after that call to RemoveBlocks we do indeed call ProcesseBlock which in turn calls ProcessesTransaction.
However you are very close, the way we mark an output as spent is by attaching additional data to the UTXO (the TransactionData object) I noticed that the code does not undo that (i.e we only remove reorged trx but we don't remove the data that mark the output as spent).
Good spot I will issue a fix.
However as part of this task I will also make the Consensus code that accepts a block sequential (thread safe)

I don't really agree that the ProcessBlock called after RemoveBlocks is relevant. Unless I'm missing something, that ProcessBlock deals with blocks from the "new" chain, not from the old chain. But we need to process blocks from the old chain in order to get the UTXOs back.
But then basically we are talking about the same thing - with not undoing spent transactions.

Oh, I can see you created a new issue. Yes exactly that was what I meant. I think we are talking about the same thing really.

Oh, it is not an issue, it is a pull request :D