Fixes a bug in the name... not sure if this breaks something elsewhere!

Hi,
I was trying to add a relationship on a session to a user. i.e.
#app/model/session.rb
require 'dm-rails/session_store'
class Session < Rails::DataMapper::SessionStore::Session
  belongs_to :user, :required => false
end

#config\initializers\session_store.rb
require 'dm-rails/session_store'
Rails::DataMapper::SessionStore.session_class = Session
My::Application.config.session_store Rails::DataMapper::SessionStore

But I kept hitting this error: Cannot find the parent_model User for session in user
This patch fixes my problem. I'm not sure if this has any unintended side-effects... not sure why self.name is overwritten in the first place. Case matters when DataMapper::Ext::Module.find_const comes to find the Model class for the belongs_to relationship; not sure if any other code relies on lower case.
Please let me know if I'm going about this the wrong way.
Cheers,
Corin

I'll take a look, thanks @maxsum-corin.


packager: inherit labels from an issue

cc @yanone

Also: link issue with PR.
And in case it's not already happening: Add PR to Traffic Jam project.


add forwardAuth.addAuthCookiesToResponse

What does this PR do?
Add the possibility to configure cookie names on ForwardAuth middleware, which gets copied from auth response to the client response. This will solve the issue, that the auth server can't refresh cookies, as described in #3660
Motivation
Based on the work from @iamolegga in PR #6893 and the comment https://github.com/traefik/traefik/issues/3660#issuecomment-896031575 in #3660 I implemented this solution.
More

[x] Added/updated tests
[x] Added/updated documentation

Additional Notes

As all posts in the original issue #3660 "only" needs the Set-cookie header, and not any other header from auth server response, the PR only copy cookies.
As a new cookie from auth server can be security relevant (i.e. a changed session cookie), this cookie has always a higher priority and will overwrite a cookie with same name from a backend.

Thomas Gunsch<EMAIL_ADDRESS>Mercedes-Benz Tech Innovation GmbH (ProviderInformation)

Hello @tgunsch,
Thanks for your interest in Traefik and for your contribution!
This PR is labeled as needs-design-review,
as you can see in our contribution guide, this means that we have to take a longer look to evaluate how it would interact with the other parts of Traefik.
We will come back to you once the design review iteration is done.

Shouldn't be taken as this being accepted, and I can't talk on behalf of the authors, however this is a better pattern as it reduces complexity and indentation in my opinion. Also the check becomes part of the newup of the ForwardAuth rather than on every request.
Was just passing through and noticed this.

Hi @james-d-elliott ,
thanks for you feedback. I was on vacation last three weeks and we will have a look on it next few days.

Have the same needs https://github.com/traefik/traefik/issues/3660 and am trying to understand where this PR is at and how I could be of help. Is it still awaiting design review?

I just wanted to let everyone know that we are interested in moving forward with this, but we are currently prioritizing a different focus.
If you want to help us move this forward faster, we would love help with a review.  How it would work, assessments on what the risks are, what areas will be impacted, and writing tests to evaluate this would be a huge help.  @nmengin can give more detailed information if you are interested.

I just wanted to let everyone know that we are interested in moving forward with this, but we are currently prioritizing a different focus.
If you want to help us move this forward faster, we would love help with a review. How it would work, assessments on what the risks are, what areas will be impacted, and writing tests to evaluate this would be a huge help. @nmengin can give more detailed information if you are interested.

Happy to help here. I've tested the changes for my specific use case but can do a more comprehensive review, please let me know what I should be looking at.

Hello @tgunsch,
Thanks for the contribution and sorry for the delay, we are moving this pull request to the status/2-needs-review state, to have it an upcoming Traefik version.
To move this pull request forward, can we take over it to make some changes?

Hi @kevinpollet ,
perfect, thank you very much. For sure you can take the PR over. We waiting eagerly for the upcoming version :partying_face:


Using radium breaks VelocityReact

Library : https://github.com/twitter-fabric/velocity-react
If I add Radium decorator on the component -> then -> transitions don't happen anymore. Probably because both libraries work off of style property.

This issue is mostly for tracking / search-ability of surprise moment for new users. Refs : https://github.com/twitter-fabric/velocity-react/issues/41 :rose:

Thanks for reporting, I'll take a look when I've got some time.

Workaround : https://github.com/twitter-fabric/velocity-react/issues/41#issuecomment-156005158 :rose:

Closing, as there is a valid workaround posted above.


x/tools/gopls: Bazel Build linked directories in a workspace root break gopls in a curious way

Clearly related to #39841 and it does feels like  a regression.
I believe, it was not an issue in earlier versions of gopls, but it is definitely very pronounced with 0.5.0
Platform info:
golang.org/x/tools/gopls v0.5.0
go version go1.14.6 linux/amd64
vscode 1.49.1
Bazel Build, as part of the build process (not related to Go proper), creates  several helper directories and links them into the workspace. In particular, it will create a link called "bazel-" pointing to a directory (so called "execroot") full of soft links to all the files in the workspace.
 However, it seems, that presence of those Bazel "link farms" confuses gopls substantially, causes it to report various "phantom" code issues and crash every now and then.
In the logs, the indication of the coming problem can be observed:
query=[file=<some project>/<some path>/<some file>.go] - everything works nicely
query=[file=<some project>/bazel-<some project>/<some path>/<some file>.go] - suddenly, a trouble is ahead
It is not clear, why gopls suddenly decides to prefer the link farm as compared to the actual file.
No crash dump is present in the logs,  apart from Connection to server got closed. Server will restart

gopls does not currently have full support for Bazel (https://github.com/golang/go/issues/37205), so anything that works is likely due to luck. To investigate further, I will need a complete gopls log--you can find out how to capture the logs with higher verbosity here.

It need not support bazel, but it also should not break when encountering a link farm - those are created by other tools as well (or even particularly cunning makefiles).
I will look into capturing a verbose log at come convenient opportunity.

We've made some improvements for symlink support, but without a log, there's not much else to investigate. Closing this as a duplicate of #37205.
@oakad: Please open a new issue if you encounter this problem again.


refactor: PlaceholderFile own user data

This PR is refactors PlaceholderFile to own user data instead of borrowing it. It will make PlaceholderFile more easy to use.

Hi, @ok-nick would you like to take a look at this PR?

@Xuanwo Hey, just realized my review was pending for over a week. Submitted it now.


[Bug] The script stopped working

When i was browsing my Tinder in the last 2 days, i encountered a new issue recently. The script only shows the  second person who liked me ,and the rest keep blurred, hidden. It is the same on chrome and firefox too.

I deleted my Tinder account, so I can't test it right away, but could you please try these steps and post the result?

temporarily disable tinder-deblur in your script manager extension
load the likes screen on Tinder
open the developer console by pressing
switch to the Console tab
paste this command document.querySelectorAll('.Expand.enterAnimationContainer > div:nth-child(1)')
post a screenshot of the output

The thing I'd like to check is, whether tinder-deblur is able to find all the 10 elements in the page

It stopped working for me too, but for me it just doesn't do anything.

Hmm, that seems like we did find the correct elements. Maybe the API response has changed? Could you try intercepting it using the tools in Network tab?

The image returned from API for a few matches is blurred. e.g. https://images-ssl.gotinder.com/xyz/blurred_xyz.jpg
I've changed building the URL in line
https://github.com/tajnymag/tinder-deblur/blob/main/tinder.user.js#L30
to
const teaserImage = "https://preview.gotinder.com/" + teaser.user._id + "/original_" + teaser.user.photos[0].id + ".jpeg";

The image returned from API for a few matches is blurred. e.g. https://images-ssl.gotinder.com/xyz/blurred_xyz.jpg
I've changed building the URL in line
https://github.com/tajnymag/tinder-deblur/blob/main/tinder.user.js#L30
to
const teaserImage = "https://preview.gotinder.com/" + teaser.user._id + "/original_" + teaser.user.photos[0].id + ".jpeg";

Wait, that works? Do the unblurred images from preview.gotinder.com match the blurred images that are normally displayed?
If so, it's a major discovery and I'll implement it in the morning.

I think so, it worked for me. I've built that URL based on one returned correctly (the second person).

Ok, expect an experimental update in the following 24 hours. Thank you very much.

The image returned from API for a few matches is blurred. e.g. https://images-ssl.gotinder.com/xyz/blurred_xyz.jpg
I've changed building the URL in line https://github.com/tajnymag/tinder-deblur/blob/main/tinder.user.js#L30 to const teaserImage = "https://preview.gotinder.com/" + teaser.user._id + "/original_" + teaser.user.photos[0].id + ".jpeg";

It works flawless!

Pushed version 2.5. The userscript should update itself automatically when your userscript manager checks for updates, or you can force the refresh manually.
Let me know, if it works correctly, so I can close the issue :slightly_smiling_face:

seems to be broken at least for me still, pre-update it only unblurred 1 pic, now it shows the blurred pics for like half a second upon page load and then every pic just goes black/white (depending on dark mode on/off)

@tajnymag there is missing : after https in the URL https//preview.gotinder.com

yep that fixed it

fok

Salut à tous ! Je n'arrive plus à déflouter les matchs sur tinder pouvez nous m'aider merci d'avance ?


wasm query/execute accepts string params

close: #244

@hanjukim should i do same with MsgInstantiateContract and MsgMigrateContract?

@hanjukim should i do same with MsgInstantiateContract and MsgMigrateContract?

Yes, please.


jsonencode() documentation contains a typo

The very first word in description is Encodode.

Nikolai Aleksandrovich Pavlov wrote:

The very first word in description is Encodode.

I'll fix it.
--
If you put 7 of the most talented OSS developers in a room for a week
and asked them to fix a bug in a spreadsheet program, in 1 week
you'd have 2 new mail readers and a text-based web browser.
/// Bram Moolenaar --<EMAIL_ADDRESS>-- http://www.Moolenaar.net   \
///        sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \
\\  an exciting new programming language -- http://www.Zimbu.org        ///
\\            help me help AIDS victims -- http://ICCF-Holland.org    ///

Fixed by PR https://github.com/zuloloxi/vim/pull/9 and in particular commit https://github.com/vim/vim/commit/705ada1aff27ecd9c47c690df817d043c2ceb5e2#diff-bea881dfa9626bab7141337b0fcdb23eL4240


CV2-3700-sscd-image-similarity-algorithm

Implement support for SSCD-copy-detection algorithm

Closing this in favor of #59


[BUG] planks localisation and icon

None of mist wood planks has propper name or icon.

IF I try to middleclick it (pick up in cerative) in will give me errored item.

This is strange because everything works fine for me.
This is probably a conflict with another mod.

Oh! Wait!
Did you change something if lang file?

Yep! It's a bug. Will be fixed in the next update.


osbuild-worker: correctly pass ostree error details

Passing an error as details results in the details being empty after marshaling. Pass the string formatted error instead.

(rebased)


format using statements

I prefer this format a bit more:
julia> print_explicit_imports(MixedModels)
Module MixedModels is relying on implicit imports for 162 names. These could be explicitly imported as follows:

```julia
using Arrow: Arrow
using BSplineKit: BSplineKit, BSplineOrder, Derivative, Natural,
                  SplineInterpolation, interpolate
using DataAPI: DataAPI
using Distributions: Distributions, Chisq, Distribution, ccdf, estimate
using GLM: GLM, Bernoulli, Binomial, Gamma, GeneralizedLinearModel,
           IdentityLink, InverseGaussian, InverseLink, LinearModel, LogLink,
           LogitLink, Normal, Poisson, ProbitLink, SqrtLink, glm
using JSON3: JSON3
using LinearAlgebra: LinearAlgebra, Adjoint, BLAS, ColumnNorm, Diagonal,
                     Hermitian, I, LAPACK, LowerTriangular, SVD,
                     SymTridiagonal, Symmetric, UpperTriangular, cond, diag,
                     diagind, dot, eigen, isdiag, ldiv!, lmul!, logdet, mul!,
                     norm, normalize, normalize!, qr, rank, rdiv!, rmul!, svd,
                     tr, tril!
using Markdown: Markdown
using NLopt: NLopt, ftol_abs, ftol_rel, initial_step, maxtime, xtol_abs,
             xtol_rel
using PooledArrays: PooledArrays, PooledArray
using PrecompileTools: PrecompileTools, @compile_workload, @setup_workload
using ProgressMeter: ProgressMeter, Progress, ProgressUnknown, finish!, next!
using Random: Random, AbstractRNG, randn!
using SparseArrays: SparseArrays, SparseMatrixCSC, SparseVector, dropzeros!,
                    nnz, nonzeros, nzrange, rowvals, sparse
using StaticArrays: StaticArrays, SVector
using Statistics: Statistics
using StatsAPI: StatsAPI
using StatsBase: StatsBase, CoefTable, aic, aicc, bic, coef, coeftable, confint,
                 deviance, dof, dof_residual, fit, fit!, fitted, isfitted,
                 islinear, leverage, loglikelihood, mean, meanresponse,
                 model_response, nobs, predict, quantile, r2, residuals,
                 responsename, std, stderror, summarystats, vcov, weights
using StatsModels: StatsModels, @formula, AbstractContrasts, AbstractTerm,
                   CategoricalTerm, ConstantTerm, DummyCoding, EffectsCoding,
                   FormulaTerm, FunctionTerm, HelmertCoding, HypothesisCoding,
                   InteractionTerm, InterceptTerm, MatrixTerm, SeqDiffCoding,
                   Term, apply_schema, coefnames, drop_term, formula,
                   modelcols, modelmatrix, response, term
using StructTypes: StructTypes
using Tables: Tables, columntable
using TypedTables: TypedTables, DictTable, FlexTable, Table, rows
```

Additionally, module MixedModels has stale explicit imports for these unused names:
- BlasReal
- copytri!
- dataset
- datasets
- linkfun

However, something similar to the 1-per-line way can still be obtained:
julia> print_explicit_imports(MixedModels; linewidth=0)
Module MixedModels is relying on implicit imports for 162 names. These could be explicitly imported as follows:

```julia
using Arrow: Arrow
using BSplineKit: BSplineKit,
                  BSplineOrder,
                  Derivative,
                  Natural,
                  SplineInterpolation,
                  interpolate
using DataAPI: DataAPI
using Distributions: Distributions,
                     Chisq,
                     Distribution,
                     ccdf,
                     estimate
using GLM: GLM,
           Bernoulli,
           Binomial,
           Gamma,
           GeneralizedLinearModel,
           IdentityLink,
           InverseGaussian,
           InverseLink,
           LinearModel,
           LogLink,
           LogitLink,
           Normal,
           Poisson,
           ProbitLink,
           SqrtLink,
           glm
using JSON3: JSON3
using LinearAlgebra: LinearAlgebra,
                     Adjoint,
                     BLAS,
                     ColumnNorm,
                     Diagonal,
                     Hermitian,
                     I,
                     LAPACK,
                     LowerTriangular,
                     SVD,
                     SymTridiagonal,
                     Symmetric,
                     UpperTriangular,
                     cond,
                     diag,
                     diagind,
                     dot,
                     eigen,
                     isdiag,
                     ldiv!,
                     lmul!,
                     logdet,
                     mul!,
                     norm,
                     normalize,
                     normalize!,
                     qr,
                     rank,
                     rdiv!,
                     rmul!,
                     svd,
                     tr,
                     tril!
using Markdown: Markdown
using NLopt: NLopt,
             ftol_abs,
             ftol_rel,
             initial_step,
             maxtime,
             xtol_abs,
             xtol_rel
using PooledArrays: PooledArrays,
                    PooledArray
using PrecompileTools: PrecompileTools,
                       @compile_workload,
                       @setup_workload
using ProgressMeter: ProgressMeter,
                     Progress,
                     ProgressUnknown,
                     finish!,
                     next!
using Random: Random,
              AbstractRNG,
              randn!
using SparseArrays: SparseArrays,
                    SparseMatrixCSC,
                    SparseVector,
                    dropzeros!,
                    nnz,
                    nonzeros,
                    nzrange,
                    rowvals,
                    sparse
using StaticArrays: StaticArrays,
                    SVector
using Statistics: Statistics
using StatsAPI: StatsAPI
using StatsBase: StatsBase,
                 CoefTable,
                 aic,
                 aicc,
                 bic,
                 coef,
                 coeftable,
                 confint,
                 deviance,
                 dof,
                 dof_residual,
                 fit,
                 fit!,
                 fitted,
                 isfitted,
                 islinear,
                 leverage,
                 loglikelihood,
                 mean,
                 meanresponse,
                 model_response,
                 nobs,
                 predict,
                 quantile,
                 r2,
                 residuals,
                 responsename,
                 std,
                 stderror,
                 summarystats,
                 vcov,
                 weights
using StatsModels: StatsModels,
                   @formula,
                   AbstractContrasts,
                   AbstractTerm,
                   CategoricalTerm,
                   ConstantTerm,
                   DummyCoding,
                   EffectsCoding,
                   FormulaTerm,
                   FunctionTerm,
                   HelmertCoding,
                   HypothesisCoding,
                   InteractionTerm,
                   InterceptTerm,
                   MatrixTerm,
                   SeqDiffCoding,
                   Term,
                   apply_schema,
                   coefnames,
                   drop_term,
                   formula,
                   modelcols,
                   modelmatrix,
                   response,
                   term
using StructTypes: StructTypes
using Tables: Tables,
              columntable
using TypedTables: TypedTables,
                   DictTable,
                   FlexTable,
                   Table,
                   rows
```

Additionally, module MixedModels has stale explicit imports for these unused names:
- BlasReal
- copytri!
- dataset
- datasets
- linkfun

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 95.58%. Comparing base (60f2e90) to head (934633e).

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #27      +/-   ##
==========================================
- Coverage   95.80%   95.58%   -0.22%
==========================================
  Files           5        5
  Lines         548      566      +18
==========================================
+ Hits          525      541      +16
- Misses         23       25       +2

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Add [SwaggerResponse] attribute

Linked to #175
This add the attribute, operation filter and tests.

Looks great - I'm just merging this in right now.
There is one use-case which is not addressed though and I'm trying to figure out the best way to support it. @dicksonl - I'd also appreciate your opinion on this too ...
The attribute approach is a great way to add additional (often error) responses to an operation description. It can also be used to override the model/description for a given status code (e.g. 200). However, there is no way to override the default status code. For example, if I want to indicate that an operation will return a 201 "as opposed to" 200 on success, the following won't work ...
[SwaggerResponse(201, "Account Created")]
public int CreateAccount(Account account)
...

This will describe two responses, the auto-generated "200" response and the additional "201" response which is not the desired result.
Although it may be slightly unexpected, I think the default responses should be cleared if one or more response-attributes are detected. In other words, using the attributes means the developer has opted to be "explicit" in describing responses for that operation and as such should provide all responses, including those in the 2xx range.
Let me know if this makes sense and I'll make the necessary changes.

Hi guys! @domaindrivendev  yeah, it would make sense to clear the default response model if more than one 2XX attribute is defined.

My first thought was solving it with a new attribute like [SwaggerResponseRemoveDefaults].
Explicit, the user is in control.
So, adding my own option, we have 3 choices:
1/ Remove defaults if any SwaggerResponse attribute
2/ Remove defaults in case of a 2xx SwaggerResponse attribute
3/ Remove default via extra attribute
MVC uses a pattern similar to option 3. you can add Authorize attribute filter globally. But decorated one action with [AllowAnonymous] to override.

I'd lean towards 2 or 3, developers may only want to create bad requests Attributes but still have 200 to be shown as default response in Swagger-ui.

Agreed - lets eliminate option 1 then!
I'm leaning toward 2) over 3). Looking at what I consider to be the most common scenario, i.e. changing the "success" response from "200" to something else (e.g. "201"), the following seems like a lot of noise, particularly if it's something I'm doing a lot ...
[SwaggerResponseRemoveDefaults]
[SwaggerResponse(201, typeof(Product))]
public IActionResult CreateProduct(Product product)
....

I prefer the following for it's succintness ...
[SwaggerResponse(201, typeof(Product))]
public IActionResult CreateProduct(Product product)
....

Looking at a less likely scenario, multiple 2xx codes for the same action, you will need at least two attributes either way and it's actually arguable which approach is more explicit
[SwaggerResponseRemoveDefaults]
[SwaggerResponse(200, typeof(Product))]
[SwaggerResponse(201, typeof(Product))]
public IActionResult CreateProduct(Product product)
....

VS
[SwaggerResponse(200, typeof(Product))]
[SwaggerResponse(201, typeof(Product))]
public IActionResult CreateProduct(Product product)
....

@andyalm - would love to hear your thoughts on this ...

Went with option 3) in the end to remove via additional attribute -  we can always change later if people It's now merged in - see https://github.com/domaindrivendev/Swashbuckle/blob/master/Swashbuckle.Dummy.Core/Controllers/SwaggerAnnotatedController.cs for an example.

Looks good


[Feature request] set sort column / direction through API

I'm interested in sorting on the server, instead of the client.
It would be helpful, if it was possible to specify a sortDirection as part of the header/schema for the data. In other words, I would like to render the datagrid, and initially have a column sorted with a 'down arrow', but not actually let the grid do the sorting. I tried a few different ways to capture the click event for the header and do something like this:
this.grid.orderBy = value;
this.grid.orderDirection = 'asc';
this.grid.dispatchEvent('ordercolumn', { name: value, direction: 'asc' });
this.grid.draw();

But that didn't seem to work.
I understand if you feel like this is outside the scope of your library - if so, please go ahead and close this. Again, this library is great; thanks again!

Totally in scope.  I think there's a way to do it without any changes to the lib, just nothing simple.  It would inevitably involve attaching to and preventing the defaults of certain click events, and maybe drawing your own order by arrow.  This is a non-optimal solution so I'll have to implement something to make it easier.


Error restoring aspnetcore-authentication nuget package

Get the following error:
Install-Package : Unable to load the service index for source https://www.myget.org/F/aspnetcore-authentication/api/v3/index.json.
Response status code does not indicate success: 404 (Feed does not exist.).
At line:1 char:1

Install-Package Microsoft.AspNetCore.Authentication -Version 2.0.1

This looks like its a dependency to that package from another specific to AspNetCoreSpa because I can restore  .net core in its entirety (including that package) in a brand new empty studio project.
Edit: Going one at a time, it looks like the following packages are causing the problem:
    <PackageReference Include="AspNet.Security.OAuth.Amazon" Version="2.0.0-*" />
    <PackageReference Include="AspNet.Security.OAuth.StackExchange" Version="2.0.0-*" />
    <PackageReference Include="AspNet.Security.OAuth.Yahoo" Version="2.0.0-*" />
    <PackageReference Include="AspNet.Security.OAuth.Paypal" Version="2.0.0-*" />
    <PackageReference Include="AspNet.Security.OAuth.GitHub" Version="2.0.0-*" />
    <PackageReference Include="AspNet.Security.OAuth.LinkedIn" Version="2.0.0-*" />
    <PackageReference Include="AspNet.Security.OAuth.Validation" Version="2.0.0-*" />

<PackageReference Include="OpenIddict" Version="2.0.0-rc2-0775" />
<PackageReference Include="OpenIddict.EntityFrameworkCore" Version="2.0.0-rc2-0775" />
<PackageReference Include="OpenIddict.Mvc" Version="2.0.0-rc2-0775" />

@AlejandroFlorin https://github.com/asadsahi/AspNetCoreSpa/commit/a559f21356df999e955b3e8592ad03e4e1e44fe4 should fix the issue. One of the nuget feed was removed. At some point these packages will be updates to final version, but until then one of the myget feed in nuget will still allow pre-release version to be downloaded. let me know if you find anymore issues.

Thanks, that fixed it.


Hive multi partition declarations

Revival of https://github.com/sqlparser-rs/sqlparser-rs/pull/657
Similar story to https://github.com/sqlparser-rs/sqlparser-rs/pull/1010
I compared the patches and nothing seemed to have changed significantly with the rebase. Please let me know what I'd need to do to make this merge-able. This patch includes #1010 so you could merge this one and close the other or merge the other first and then I can rebase this patch again.

Thanks @bitemyapp  -- This is on my list -- can you please resolve the CI failures and I'll take a look

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

19 of 21 (90.48%)  changed or added relevant lines in 4 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 87.383%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/ast/ddl.rs
4
5
80.0%

src/parser/mod.rs
10
11
90.91%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
16996

Relevant Lines:
19450

💛  - Coveralls


Failed to clone repository: 'git@github.com:rapidsai/cumlprims_mg.git'

..

reported issue not required

Yeah, cumlprims_mg is a closed-source repository. I forgot to add a CMake flag to disable it, but in the meantime you should be able to build by commenting out this line and setting this option to OFF.


options.modules.map is not a function

Dear,
I have the impression that will end up in a very silly question, but can't find the answer by myself...
When I do this in my NodeJs (version v12.19.0) application:
const { createInterceptor } = require('@mswjs/interceptors');
const nodeInterceptors = require('@mswjs/interceptors/lib/presets/node');

var interceptor = createInterceptor({
    modules: nodeInterceptors,
    resolver(request, ref) {
            // Optionally, return a mocked response.
    },
})

interceptor.apply();

Then the apply call results in following exception:
createInterceptor.ts:73 Uncaught TypeError: options.modules.map is not a function
    at Object.apply (createInterceptor.ts:73)
    at eval (eval at HttpLoggerNode (http_logger.js:41), <anonymous>:1:18)
    at new HttpLoggerNode (http_logger.js:41)
    at Object.createNode (util.js:86)
    at Flow.start (Flow.js:205)
    at start (index.js:371)

Does anybody see what I am doing wrong?
P.S. I had no errors while installing version 0.12.7 of this library (using npm install @mswjs/interceptors).
Thanks !!!
Bart

Hi @kettanaito,
Thanks for you fast response!
I have created a local git clone of your repo.
Could you please explain in short the steps I have to follow for building this library?
Thanks!!

I had a great chat with @slightlytyler about module formats, and the issue you're experiencing isn't an issue per se.
We export the nodeInterceptors as an array of functions using the default export. Thing is, there's no "default" export in CommonJS (where you're using require), it must always be an object. Thus, the export default gets translated as module.exports = { default: nodeInterceptors }.
We could change the export type to use a named export but I see little reason in doing so.


improve structure of config.yml

The current structure of config.yml is not very suitable for managing multiple ontology versions, since there is both a lot of redundancy and it's difficult to get a good overview. A better alternative would be to use a nested structure where only the version numbers are updated. E.g.:
ontologies:
  actor:
    source: "ontology/modules/actor/"
    target: "ontology/actor/"
    versions:
      - 0.1
      - 0.2
  actorODP:
    source: "ontology/modules/actorODP"
    target: "ontology/actorODP/"
    versions:
      - 0.1
      - 0.2

Recent changes in the develop branch makes all ontologies available online following a push. This workflow is very convenient and based on the same assumptions regarding module paths, we no longer need the configuration file at all for the publication of ontologies. However, this requires that we automatically detect the latest ontology versions in the build.py script.


Standardize templates across examples

Changing Django, Rails and Node.js examples.
Tested all examples/templates with creating a project for each, deploying and curl'ing.
@bparees PTAL

@ewolinetz @sspeiche PTAL

@rhcarvalho I made a number of these changes already, probably a good idea to rebase. Please I believe @bparees wants to avoid ImageStream and instead use ImageStreamTags

@sspeiche I rebased. Sorry, I've actually moved away from parameterizing the FRONTEND_SERVICE_NAME. That's something I introduced earlier, but looking at all templates it seemed that it was not bringing that much value for the level of indirection.
Do you find it useful?
I'm fine with either ImageStream or ImageStreamTags, let's her from @bparees then and I can update the PRs.

@rhcarvalho I'm fine with getting rid of service name stuff...it just adds to the UI and not sure getting much value out of it

ok, hardcoding the service name is fine.
but we should be using imagestreamtags not imagestreams.

I can change that tomorrow. No computer here now.
The ImageStream references are all converted to ImageStreamTags by appending the ":latest" suffix, what's the reasoning to prefer one over the other in templates?

@rhcarvalho ImageStream is basically deprecated.  ImageStreamTag is cleaner, since ImageStream required a separate field to indicate the Tag.

@rhcarvalho also the imagestreamtags we define now have versions..you should use the version, not latest:
https://github.com/openshift/origin/blob/master/examples/image-streams/image-streams-centos7.json#L20

I'll move all examples to use ImageStreamTags tomorrow morning, and also add a DB template for node.js (green flag from you @sspeiche?).
@bparees, regarding versions, that makes sense for the image streams we provide in origin, the ones you linked to. But I didn't understand how that applies to the framework examples. So far we're defining ImageStreams in those templates for a out-of-box experience -- independent of some admin adding proper image streams to projects a priori.
Are you suggesting we change the IS definitions to match those in origin?

@rhcarvalho We're actually going to be removing the imagestreams that the templates define and rely entirely on an admin creating the imagestreams in the openshift namespace.  So the templates will no longer be "self contained".  i'll forward you the email thread.

Ok, ok... how about the image streams for application code, the ones we push builds to?

@rhcarvalho yes we'll still define an output stream.

@bparees I've updated rails, django and nodejs examples to use the image streams in the "openshift" namespace and use the version tags (ruby:2.0, python:3.3, nodejs:0.10)

@bparees @rhcarvalho would be nice to create an test in jenkins that start openshift and submit all these templates and check if the frontends are running...

@mfojtik yes it would :)
why not add it to extended tests?

lgtm.


[trantor] Update to 1.5.1

@an-tao ,Could you please take a look:
https://dev.azure.com/vcpkg/public/_build/results?buildId=57527&view=artifacts&pathAsName=false&type=publishedArtifacts

@JonLiu1993 Thanks so much for your help, but I don't know why it runs the ninja -v command. here is the error:
CMake Error at scripts/cmake/vcpkg_execute_required_process.cmake:127 (message):
    Command failed: ninja -v

@an-tao ,You did not find the real error, this is the core error:
config-x64-windows-out.log

@an-tao ,Could you please take a look?

@an-tao ,Could you please take a look?

@JonLiu1993 Sorry for the late reply, I have no idea about the error, It seems a permission error, do you have any suggestions?

@an-tao ,Could you please take a look?

@JonLiu1993 Sorry for the late reply, I have no idea about the error, It seems a permission error, do you have any suggestions?

I will try to reproduce locally, if it can be reproduced, I will solve it

@an-tao ,Could you please take a look?

@JonLiu1993 Sorry for the late reply, I have no idea about the error, It seems a permission error, do you have any suggestions?

I will try to reproduce locally, if it can be reproduced, I will solve it

Thank you so much.

The 'paraview' breaks due CI basline error,just wait CI error fixed.

/azp run

Thanks for your contribution!


Prefer builtins over some typing aliases

This is an incremental replacement of typing.Dict with builtins.dict, typing.List with builtins.list, typing.Set with builtins.set, and typing.Tuple with builtins.tuple, though other aliases exist which.
See: https://docs.python.org/3/library/typing.html#deprecated-aliases

Deprecated since version 3.9: builtins.dict now supports subscripting ([]). See PEP 585 and Generic Alias Type.

Deprecated since version 3.9, as such, this change makes sense to follow #1002 which makes version 3.9 the oldest supported version though the aliases are guaranteed to remain in the typing module without deprecation warnings until at least Python 3.14.

Closes #
💸 TL;DR

📜 Details
Design Doc
Jira

🧪 Testing Steps / Validation

✅ Checks

[ ] CI tests (if present) are passing
[ ] Adheres to code style for repo
[ ] Contributor License Agreement (CLA) completed if not a Reddit employee

#1002 was moved to #1003

@RyanBalfanz it looks like a lot of these were converted by Ruff already, do you think we still need this PR?

@RyanBalfanz it looks like a lot of these were converted by Ruff already, do you think we still need this PR?

If Ruff took care of it, then great! I'll take a look to see if anything my have been missed and create a new PR if so.

I took a look; this is no longer needed.


Where is the files /gslx680/touch_data_handle.c   and gslx680/tp_handle.c

I cannot seem to find the files
list(APPEND SOURCES "./qmsd_tp/gslx680/touch_data_handle.c")
list(APPEND SOURCES "./qmsd_tp/gslx680/tp_handle.c")

needed for the WT32-86
Where are they ?
Thank you.

@codewise-nicolas hello have it work with touch yet ?

Yes, but it had to be reversed engineered. The files in question are still missing from the repo.

Could you share your code that work with touch sensor?
Thank

It seems Wireless-Tag only releases header files and pre-compiled libraries...
No .c driver files are on the repo and no reply to this request for 2 months now 😞
@codewise-nicolas Did you try asking a Wireless-Tech representative?
@uldara1 We have created a custom driver which can be found at https://github.com/arovak/GSL2038

I have not, I had hoped since they were using Github they would be reading their emails and issues.
They keep making commits to the repo even as late as a day ago.
@shukewt, @alan-wt  can either of you please respond.

@fvanroie @codewise-nicolas @shukewt currenly i can program this module with arduino
https://user-images.githubusercontent.com/22394956/161015075-da115161-f650-4cc7-923d-9978474b09b1.MOV
https://user-images.githubusercontent.com/22394956/161015145-29dafc59-044a-4b01-9bab-c5a48569c250.MOV

@poky do you have this board yet ?

@poky do you have this board yet ?

Yes, I do, trying to write some code with LVGL
So I found this official repo, too bad it's all compiled into .a, nothing I can customized for it.

@poky
Hi pls check attached file
ESP32_S2_LVGL_LovyanGFX.zip

@poky Hi pls check attached file ESP32_S2_LVGL_LovyanGFX.zip
this code used with Arduino IDE

Thanks! BTW, which version of LVGL are you using?

@poky the lasted version of lvgl

@poky the lastest version of lvgl

Thanks! I have it running, but I can't get the touch to work, do I need to calibrate before use? Or other config for the touch

@poky the code should work with touch pls check your touch cable

Here is a fully functional example of using LVGL 8.2 with LovyanGFX graphic library and PlatformIO, it is partially based on @uldara1's UI code.
https://github.com/strange-v/WT-86-32-3ZW1_LVGL
https://user-images.githubusercontent.com/3875529/173507307-29a0d260-c7c7-49b8-8a90-490dd5bf3ea8.mp4

Here is a fully functional example of using LVGL 8.2 with LovyanGFX graphic library and PlatformIO, it is partially based on @uldara1's UI code.
https://github.com/strange-v/WT-86-32-3ZW1_LVGL
WT-86-32-3ZW1_LVGL_.mp4

This repo works great!
Thanks for sharing!

@shukewt is it closed because the files were added to the repo? I dont see them.


Re-phrase VHDX recommendations

We don't support or recommend that you create a VHDX file that is bootable to both generation 1 and generation 2 virtual machines.

Sounds like bootable VHDX files are not supported in either generation, or that bootable VHDX is not supported at all.
Maybe something like:

Creation of VHDX files that are bootable on both generation 1 and generation 2 virtual machines is not supported or recommended. Only create bootable VHDX files that target generation 1 or generation 2 virtual machines.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 90b81010-acd8-231f-852b-7a9edfa4bd50
Version Independent ID: 871c5a14-9f83-71b6-67b8-8ca33eb91651
Content: Should I create a generation 1 or 2 virtual machine in Hyper-V?
Content Source: WindowsServerDocs/virtualization/hyper-v/plan/Should-I-create-a-generation-1-or-2-virtual-machine-in-Hyper-V.md
Product: windows-server
Technology: hyper-v
GitHub Login: @BenjaminArmstrong
Microsoft Alias: benarm

Hey mattboothman,
Thanks again for contacting Microsoft. We value your feedback.
A documentation change has been made clarifying the wording for Gen 1 & Gen 2 VHDKs and will be live after the next business day. We will now be closing this thread.
Thank you and have a most pleasant day.
#please-close


Support .ignore and clean up tests/documentation

Please check if the PR fulfills these requirements

[ X ] The commit message follows our guidelines
[ X ] Tests for the changes have been added (for bug fixes / features)
[ X ] Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Feature, test update and docs update
What is the current behavior? (You can also link to an open issue here)
Currently woke uses the .gitignore, .wokeignore, and .git/info/exclude files to determine the list of files to ignore. However, documentation and testing for these were not complete.
What is the new behavior (if this is a feature change)?
Updated the documentation and testing for the existing files (except testing on .git/info/exclude, that one will need more thought for testing since .git cannot be checked in,) as well as added .ignore to the list of default ignore files to check. .ignore is used by ripgrep, the silver surfer (ag), among others as a general list of files to skip when searching regardless of tool. For more information, see:
https://geoff.greer.fm/2016/09/26/ignore/
Does this PR introduce a breaking change? (What changes might users need to make due to this PR?)
No
Other information:
(This change was really designed to get more familiar with the code base, as I'd like to try to tackle #98 but wanted to get more familiar with how the ignore code worked first.)

I'd like to try to tackle #98 but wanted to get more familiar with how the ignore code worked first.

We should check with @armanrahman22 before starting this as he might already be working on it

I'd like to try to tackle #98 but wanted to get more familiar with how the ignore code worked first.

We should check with @armanrahman22 before starting this as he might already be working on it

Good idea, especially since I'm so new to Go. I had already started digging into this a bit before your comment, but it seems like I would need to learn a bit more in any case before trying to tackle this, since it looks like there is some not-insignificant interactions and changes needed for this to the parser, walker, and ignore packages at least, as well as the root. I'll focus on learning a bit more, and if I get to where I think I might be able to tackle this I'll reach out to @armanrahman22 as you suggest first to make sure he is not already working on it. Thanks!


Introduce security model for workflows/tasks

Hello,
I was wondering which approach do you suggest to add an access control to determine which tasks and workflows can be created, updated, retrieved, etc.
I have actually two propositions:

Have an interface that have a method for each action to determine if someone has right or not to perform this action. By default a stub implementation could be provided that authorize everything (backwards compatibility)
(More permissive) Have hooks that allows developper to perform action before and after each action (maybe achieved with an interface, or trying Aspect Oriented Programming)

What do you think? It is something that could be implemented in Conductor?
If you have other propositions, please do not hesitate to mention it.
Thanks

Hey @andrea11, thanks for the proposal. Do you mind elaborating or providing an example for this: Have hooks that allows developper to perform action before and after each action?
Also, How is authorization handled for users vs task workers?
Both approaches looks promising, but I'd prefer a cleaner interface with backwards compatible defaults, that can easily be plugged in with any authorization implementation - meaning all the details of authorization provider like roles, scopes, permissions etc. which could differ for each authorization provider should be abstracted.

We are starting a project that includes securing the conductor APIs so I'm curious about this. The approach we're probably going to go forward with is to deploy conductor in multi-image containers where the conductor server is one image and the secured APIs are a second image with the secured APIs being the only ones that are publicly exposed by the container/orchestration layer.
What do you see as the main advantages of embedding the security in the current conductor APIs?

@kishorebanala I also agree with you here.
I think we cannot make any assumptions about how the security is handled, and we can also suppose that users/task workers can be handled differently maybe?
What about this idea:
For each Service, such as WorkflowService, we could add a new interface named "WorkflowServiceSecurity" containing 1 function throwing a specific exception for each function in WorkflowService. This exception can be cached, and the response can be determined by the clients directly, depending on its content (also filled by clients).
Then, we only need WorkflowService to have a new withSecurity(WorkflowServiceSecurity security) method, and the default implementation to call the security function at the beginning of each function.
Rinse and repeat for each service.
Pros: it's flexible in the security implementation
Cons: it's quite a lot of boilerplate. People could as well re-implement/extend WorkflowService directly
Question: what inputs do you provide to the methods in WorkflowServiceSecurity? Probably same is the ones in WorkflowService.
As an AOP functionality, we could indeed catch all access to all Services methods, and ask users to return a boolean given: 1. the method name/class, 2. the list of arguments that method takes, and follow-up with or not with the execution. That requires some reflection though, which might be a performance issue.
Any better ideas?

@Jiehong Thanks for your suggestions. We're also researching about best possible approach to handle Authentication and Authorization in Conductor with internal Netflix security teams and other partners. We'll definitely take your inputs into consideration and will come up with a proposal when we have a plan defined.


关于mcloud-registry 启动 报错 reactor-extra-3.2.0.RELEASE.jar

An attempt was made to call the method reactor.retry.Retry.retryMax(I)Lreactor/retry/Retry; but it does not exist. Its class, reactor.retry.Retry, is available from the following locations:
jar:file:/Users/xxxx/.gradle/caches/modules-2/files-2.1/io.projectreactor.addons/reactor-extra/3.2.0.RELEASE/d50966d552e408a356e886352f2469dde8daac77/reactor-extra-3.2.0.RELEASE.jar!/reactor/retry/Retry.class

Spring Cloud 与 Spring Boot 版本不兼容导致，请更新最新代码。


doc: update CHANGELOG for v1.36.0 release

I added entries for Cloud Tasks and Secret Manager, as they are now GA. (even though their content is identical to Bigquery, IAM). This will not scale when we declare the new libraries GA.
This PR does not show up in the CHANGELOG. Should it?

feat(pubsublite): add TopicStats service (#7966)

This change is

This PR does not show up in the CHANGELOG. Should it?

feat(pubsublite): add TopicStats service (#7966)

No, generally we do not announce changes for libraries under development.


Bug in removing non-empty temp directory

FileSystem::remove() could remove non-empty directories unlike rmdir() function
(https://github.com/keboola/php-temp/commit/d76fc44d38c804565d8d13621ef9e1be27a49540#diff-b88a976e1fcdb795dd34382000376388L176)

ping

@JakubMatejka Is this still an issue? If so, can you please create a failing test with the intended behavior? Thanks!

can't reproduce, closing


Have you considered an Ansible-Nas organization?

Is your feature request related to a problem? Please describe.
You have 62 open issues (now 63) and 55 open pull requests (many fixing those open issues, just waiting to be merged). You seem to have a little more here then you are able to comfortably handle.
Describe the solution you'd like
Setup an Ansible-Nas github organization and get some of the people who contribute the most to Ansible-Nas or who you otherwise trust to assist in merging the pull requests.
Describe alternatives you've considered
The alternative would be the 217 forks. That's a lot of forks, most of them dead ends that could have been improvements. It would be better to focus effort on to your one single repository.
Additional context
I have done this. I started the python-O365 project years ago and then lost access to an Office365 account. Setup an organization and another user who was still using it has more or less taken the project over from me. It's a great way to continue the growth of your project without being solely dependent upon you. Judging by the open pull requests @bcurran3 would be a good candidate. I can help if you'd like, but I'd totally understand not; as you have zero reason to trust me at this point.

I second this.
I have used ansible-nas as a teaching tool to help get me more familiar with docker, ansible, and containerizing services. I have also started using it in my business (with some extra addons like mail, ad, oauth, etc.) I have been interested in adding content and features to the project as I now have a vested interest in the continuation of it.
However, I have 2 issues keeping me from that,

I'm pretty new to contributing to github :sweat_smile: and I'm nervous of changing things to be submitted.

I have upgraded my installation to use traefik2.2, which required modifying a lot of files, so I don't want to start adding other content until we can get at least that container upgraded. I'm okay with showing my full config to @davestephens if it could help speed things along and I have already shared my traefik.yml and .toml in #142

I second this.
I have used ansible-nas as a teaching tool to help get me more familiar with docker, ansible, and containerizing services. I have also started using it in my business (with some extra addons like mail, ad, oauth, etc.) I have been interested in adding content and features to the project as I now have a vested interest in the continuation of it.
However, I have 2 issues keeping me from that,

I'm pretty new to contributing to github :sweat_smile: and I'm nervous of changing things to be submitted.

I have upgraded my installation to use traefik2.2, which required modifying a lot of files, so I don't want to start adding other content until we can get at least that container upgraded. I'm okay with showing my full config to @davestephens if it could help speed things along and I have already shared my traefik.yml and .toml in #142

Any thoughts on this @davestephens?

Any thoughts on this @davestephens?

Thanks for your thoughts! I think your question is more about maintenance of the project rather than a github organisation specifically - outstanding open issues and merging PRs are mutually exclusive to whether ansible-nas is under a github org or not.
The only thing that's truly blocked on me is merging of PRs and closing issues, and I'd like to keep it that way until I find people willing to contribute that also have sufficient linux and ansible knowledge to help maintain the project.
Another thing to bear in mind is that users of ansible-nas are very transient, and someone super-enthusiastic right now quite possibly won't be a month or two later. They get their home server set up and won't be seen again, because for the most part - an ansible-nas installation maintains itself once it's set up.

Thanks for your thoughts! I think your question is more about maintenance of the project rather than a github organisation specifically - outstanding open issues and merging PRs are mutually exclusive to whether ansible-nas is under a github org or not.
The only thing that's truly blocked on me is merging of PRs and closing issues, and I'd like to keep it that way until I find people willing to contribute that also have sufficient linux and ansible knowledge to help maintain the project.
Another thing to bear in mind is that users of ansible-nas are very transient, and someone super-enthusiastic right now quite possibly won't be a month or two later. They get their home server set up and won't be seen again, because for the most part - an ansible-nas installation maintains itself once it's set up.

I'm still here.

I'm still here.

tl;dr: get some help, you are giving the impression you project isn't maintained.
Setting up an organization is about more than just adding collaborators. I see you can just add collaborators to a repo directly (news to me). Setting up an organization makes your project more appealing, it says "hey, this is bigger than me, and should I disappear it will carry on."
Yes, the only thing that is blocked on you are the issues and PRs, but considering my PR has been sitting for 19 days on what is basically a yes or no question you don't seem to be following it closely. What this interaction and the interaction on my PR is suggesting to me is that you don't actively maintain this project very much. Infact most of the PRs and issues would suggest a maintainer that isn't paying attention. For example #244, an issue where the user is simply asking you to merge some pull requests. They may be suitable to the project but you haven't given any indication either way. or #357 where you requested a change, the user made it, but you haven't merged it, 3 months later. Looks like @sshestopalov got tired of waiting, forked your project and merged it himself. It makes me think that I, or @bcurran3, or @PurpleNinja225 should fork and carry on without you. I don't like forking, I think the open source community could use with a little less forking, but it is useful when we have reached an impasse.
You already have a presence, you show up in searches, that is how I found the project and don't want to leave that behind with a fork. While I understand that most of the community is going to be transient, there are people, like myself and (i assume) @bcurran3 who enjoy working on these sorts of projects. I think you will find that more of your community would be willing to stick around and help if their PRs got merged faster.

tl;dr: get some help, you are giving the impression you project isn't maintained.
Setting up an organization is about more than just adding collaborators. I see you can just add collaborators to a repo directly (news to me). Setting up an organization makes your project more appealing, it says "hey, this is bigger than me, and should I disappear it will carry on."
Yes, the only thing that is blocked on you are the issues and PRs, but considering my PR has been sitting for 19 days on what is basically a yes or no question you don't seem to be following it closely. What this interaction and the interaction on my PR is suggesting to me is that you don't actively maintain this project very much. Infact most of the PRs and issues would suggest a maintainer that isn't paying attention. For example #244, an issue where the user is simply asking you to merge some pull requests. They may be suitable to the project but you haven't given any indication either way. or #357 where you requested a change, the user made it, but you haven't merged it, 3 months later. Looks like @sshestopalov got tired of waiting, forked your project and merged it himself. It makes me think that I, or @bcurran3, or @PurpleNinja225 should fork and carry on without you. I don't like forking, I think the open source community could use with a little less forking, but it is useful when we have reached an impasse.
You already have a presence, you show up in searches, that is how I found the project and don't want to leave that behind with a fork. While I understand that most of the community is going to be transient, there are people, like myself and (i assume) @bcurran3 who enjoy working on these sorts of projects. I think you will find that more of your community would be willing to stick around and help if their PRs got merged faster.

As above - your comments are based on your opinion of my maintenance of the project rather than whether the code is in an organisation or not.
Just so we're on the same page - this is a unpaid project I do for fun on the side. Note the key word - "fun".  It is not a business, my full time job, nor have I committed to maintaining any sort of SLA for its users. As a laugh I checked how much I've earnt since starting the project - £123 - £30/year. Additionally, the same as most people on earth, I have a day job, a family to support, as well as personal things that meant I have had zero time for anything in the "fun" category in the last year.
This isn't intended to be a "woe is me" comment, but I think people conveniently forget that there are real people with real lives behind GitHub projects when something they want isn't happening fast enough, despite the fact they've already got a piece of software for free, and that some are even making money from. Pointing out how you're unhappy about x, y and z, and how a, b and c must happen, without considering that, sounds very entitled.
Moving forward, you'll notice that I have time to spend on the project again, and am working my way through PRs and issues, as well as numerous enhancements.

As above - your comments are based on your opinion of my maintenance of the project rather than whether the code is in an organisation or not.
Just so we're on the same page - this is a unpaid project I do for fun on the side. Note the key word - "fun".  It is not a business, my full time job, nor have I committed to maintaining any sort of SLA for its users. As a laugh I checked how much I've earnt since starting the project - £123 - £30/year. Additionally, the same as most people on earth, I have a day job, a family to support, as well as personal things that meant I have had zero time for anything in the "fun" category in the last year.
This isn't intended to be a "woe is me" comment, but I think people conveniently forget that there are real people with real lives behind GitHub projects when something they want isn't happening fast enough, despite the fact they've already got a piece of software for free, and that some are even making money from. Pointing out how you're unhappy about x, y and z, and how a, b and c must happen, without considering that, sounds very entitled.
Moving forward, you'll notice that I have time to spend on the project again, and am working my way through PRs and issues, as well as numerous enhancements.

Would creating a dev branch and allowing some contributor access be an option? So those who really want to help put time and effort into the project can contribute without affecting the main branch that everyone uses and only merge when ready.

In response to @davestephens, I know your comment wasn't directed exactly at me, but in my experience I understand that projects like this are labors of love, and the reason I ask to add collaborators is because I'm someone who can get paid to work on this project. As I mentioned in my above comment, my work uses ansible-nas, and I can help add new apps, like vpn clients (not just for transmission), SSO, Oauth, AD, making more configuration settings for people who set up multiple instances ( Use it both at work and at home).
I don't say this because I wan't to be added as a contributor, i'm not confident enough in my code etiquette to. But opening things up to someone like @bcurran3 who has made 114 commits to this project!
In reference to @Narcolapser I do have a fork but its private, as it has a ton of code changes, and is for work :sweat_smile:
I'm really happy to see new commits since the last one before that was like sept.? It would be nice to let people help when they can while they do have that passion for this project, cause if they have to wait to long they fix it for just themselves and then move on, that's what I did. Plus having an extra pair of eyes that can get on when you aren't able to only benefits the following.

Would creating a dev branch and allowing some contributor access be an option? So those who really want to help put time and effort into the project can contribute without affecting the main branch that everyone uses and only merge when ready.

In response to @davestephens, I know your comment wasn't directed exactly at me, but in my experience I understand that projects like this are labors of love, and the reason I ask to add collaborators is because I'm someone who can get paid to work on this project. As I mentioned in my above comment, my work uses ansible-nas, and I can help add new apps, like vpn clients (not just for transmission), SSO, Oauth, AD, making more configuration settings for people who set up multiple instances ( Use it both at work and at home).
I don't say this because I wan't to be added as a contributor, i'm not confident enough in my code etiquette to. But opening things up to someone like @bcurran3 who has made 114 commits to this project!
In reference to @Narcolapser I do have a fork but its private, as it has a ton of code changes, and is for work :sweat_smile:
I'm really happy to see new commits since the last one before that was like sept.? It would be nice to let people help when they can while they do have that passion for this project, cause if they have to wait to long they fix it for just themselves and then move on, that's what I did. Plus having an extra pair of eyes that can get on when you aren't able to only benefits the following.

I am totally tracking with you on "this isn't my Job". When I maintained O365 I felt the same. But I am not asking you to do more, in theory, I'm asking you to do less. Ignore the whole organization bit, my real question is "need some help?"

I am totally tracking with you on "this isn't my Job". When I maintained O365 I felt the same. But I am not asking you to do more, in theory, I'm asking you to do less. Ignore the whole organization bit, my real question is "need some help?"

Always happy to receive help! :-) I'm just not comfortable giving anyone commit/merge access to master just yet. It's not you, it's me ;-)
I'm going to close this for now as I'm not sure there's anything more to add. I like to think that when the right people come along with the right set of skills and commitment, we'll all know (and I'm not saying that's not any of you guys, but you're all reasonably new to the project).

I'm not saying that's not any of you guys, but you're all reasonably new to the project).

Agreed.
Well, I hope it works out. This is a neat project, hopefully you'll have the motivation to maintain it until those right people come along!


Zoom erase or not rendered leftpart of the wave when scrolling

Hi,
In the last version 2.0.0-beta02 I find a regression between 2.0.0-beta01 whit the zoom.
When you zoom the wave, this action automaticly render the wave center at the read position (on pause to make the test).
Then left part of the wave is not visible, but you can see it whit scroll. In the last version , left part not visible will be lost, when you scrolling left there no wave :

No need code, I use the demo code to reproduce ([https://wavesurfer-js.org/examples/
](https://wavesurfer-js.org/examples/)) . Same issue in firefox quantum 57.0 and chrome  62.0.3202.94.
Hope this can help.

Hello, there is also in this new version a zoom issue at the end of the wave when you decrease the zoom.
You can see it if you place the current play nearly of the end, zoom ++ ...++ than zoom - (see it, wave go small left), zoom + (wave seem's ok)
Perharps it come from the same bug ?

In the last version 2.0.0-beta02 I find a regression between 2.0.0-beta01 whit the zoom.

@awenger63 would be really helpful if you can figure out what exact commit changed this.

@thijstriemstra OK, if I can , I would like to help you. I just need to know how I can get different commit version ? have you a link to explain that ?

@thijstriemstra  I'm sorry but I don't arrive to run npm without issues here...., so it's difficult to be sure, but I fell find change who generated the issue and do the regression : #1198 commit 1e7f598.
Can you verify ? Hope this is correct.

@mspae made that change, I hope he can comment on it.

I don't know if someone have take a look at this issue ? I would like to help you more, but I cannot succeeds install it on my Netbeans/Github to trace exactly.
Tell me more

I am seeing this issue with the wave editor I am building now. The drawBuffer code calls drawer.getScrollX() to get the coordinate for the left side of the area in which to draw peaks. This means that the earlier canvases are not refilled, so when you scroll-back, all you see is a flat line. Jamming the start variable to zero makes the problem go away. I will try and come up with a better fix than that.

@jamiefaye OK, thanks to look at this problem. Do you have a line code, that I can put on the zoom process  to jamming the start variable to zero ?
I saw also other draw issue with the wave when zoom increase a lot. Perhaps it's linked. I will look to define a reproductible case and tell you.

I changed line 1024 of wavesurfer.js to look like this:
let start = 0; // this.drawer.getScrollX();
If I were to make this permanent, I would eliminate the 'start' variable, and just use zero.

@jamiefaye Yes, this work, I make the change on the last v2.0.4 (line 2408) on my local code.

@jamiefaye Same issues but at the end of the wave when load with peaks and zoom process. Error appear when add the first new canvas (multicanvas). It's the opposite error ... (with or without start =0; because in this case getPeaks() always return peaks since the begining !)
Error appear since V2.0.0.beta2 regression after V2.0.0.beta1.
It's seem only fisrt canvas contain the wave when redraw it.
Any other good idea ?

After investigation, problem exist when no barWidht and only on the last canvas when zooming it's in drawLineToContext.
In line 3652, if it's the last canvas there is no draw
if (first > end || last < start) {                 return;             }
@thijstriemstra perhaps this code was adding in commit 258cfbafec5a47965f34e2f59ef8cd4eb82dd4ff (#909 , #924 ).  Can you explain this ?
I change return line by :
last -= 1;
It's seem to work in render and zoom process with peaks in my local code. Perhaps need more test?
@thijstriemstra what do you think about this change ?
@jamiefaye, with your change and my last change, this issues should be correct.
Thanks

OK, who can see, @mspae  ?
To be confirm, but I don't really understand this test because it compare two different thing. In my comprehension, fisrt and last are peaks information size, end and start are canvas width. And the comment seem to say, if it's not the last canvas, we add 1 peaks information to make the join between canvas.

Is there any update on this please? @thijstriemstra @katspaugh

if you want to speed things up, hire either of us. Until then someone (else) will eventually fix it.

@thijstriemstra I thought the change awenger63 suggested fixes the issue, and wondered if it could be implemented. Anyways, I might PM you so we can take this further

I thought the change awenger63 suggested fixes the issue

Give it a try, and if it does, open a pull request so it can get fixed.


When adding multiple interfaces on a server, a router host and router description shoudl also be created per interface

improvement request (usability, performance, tech debt, etc.)

Traffic Ops

Traffic Portal

Current behavior:
When creating a second, third etc interface in to 5 only a single router hostname and router port exists.
New behavior:
adding more interfaces require more router(s) port(s) TP should reflect this
Minimal reproduction of the problem with instructions:

Anything else:

I can take this one.


[INTEGRATION][SPARK] Bugs in spark3Test PMD report

The spark3Test PMD report is attached.
Part of epic: #831
spark3Test.csv

PMD test results now exclude EmptyCatchBlocks rule.


Proposed UI tweaks

hi,
my intention was to open a PR ... but i really couldn't figure out how the css works. bootstrap seems to be in charge of it (at least the parts i was wanting to edit)?
so this is a before:
https://user-images.githubusercontent.com/3240247/167231181-c4a4530c-f89d-48e8-84a5-4772528b0f9f.mov
and this is an after
https://user-images.githubusercontent.com/3240247/167231193-b203a477-dde8-451b-b5f7-992da0e22a45.mov
this is using the CSS properties display: flex, flex-wrap: wrap, and row-gap ... the browser coverage of row-gap is only around ~90%, but its absence is no worse than the current situation.
if this is something you think would be worth merging, i'm happy to open a PR (but i will need some pointers on where the mods need to be made!).
with thanks

I know, I know, JATOS could use some proper frontend framework. We still use Bootstrap 3.4 :/ .
But I put your CSS to good use: https://github.com/JATOS/JATOS/commit/e70314cb1637efda451bebf4e61d3c44db22ee8b
It will be part of the next release :) .
Thanks for the awesome issue - it wasn't much work on my side anymore!

ah great, glad you could use it ...
one thing to consider is that i was prepared to figure this out and do a proper PR myself. i get that it's (usually) a million times easier to take the suggestion and implement it oneself, however there is merit in taking the time to "mentor" someone in contributing to the project ... your time constraints may not allow, and it can be a really big time sink, but it sometimes pays off, where the contributor goes on to contribute more than the time you invested.
i run some substantial projects myself, so i appreciate the tension, but it is a great feeling when you get someone to the point where they're contributing more than they're consuming.
cheers

Jonathon, I'll take your advise to heart. I'd be happy if JATOS grows more into a community. People already give and discuss feature requests, and tell bugs but I'm still the major coder. Another point is that right now my time is really pretty limited since I care for a small kid at home, but from August on he will go to a nursery school ...

cool cool. yeah, i totally get it. we're all time poor.
thanks for all your efforts.


EasyHook DLL's remain in the target process

After a successful hook, Run(..) has returned, the EasyHook DLL's remain loaded in the target process.
The culprits are:
EasyHook32.dll
EasyLoad32.dll

or
EasyHook64.dll
EasyLoad64.dll

Depending on whether the target process is 32 or 64 bit.
EasyHook.dll, and the injection host (custom dll) unload correctly.
I have been using Process Explorer from SysInternals to track what dll's are loaded/unloaded from processes.
This has been tested and reproduced with the ProcessMonitor example, and my custom hook.
Is this intentional? Is there anyway way to remove all traces of any hooks?
If this is intended behavior, feel free to close.
Custom Hook Implmentation:
https://github.com/xenolightning/AudioSwitcher/tree/AudioSession/AudioSwitcher.AudioApi.Hooking

As the EasyLoad32/64.dll .NET assemblies are loaded into the default app domain and therefore there is no way to unload them. The user assembly is loaded into a new app domain by EasyLoad and is therefore successfully unloaded when that app domain is closed.
The easyhook32/64.dll is a native DLL and is therefore able to be unloaded.

Ahh yes, Default AppDomain strikes again.
I too think it's bad practice to "unload yourself" from a process. Could cause a huge number of headaches, and potential memory addressing issues.
Good to have a concise answer, I did a fair bit of reading, but there doesn't seem to be in any doc's or issues covering this in the past.
A good assumption is the hooking process is longer running than the target process. If, for whatever reason, the hooking process is attempted to be close and deleted before the target process is closed a rule could be created to warn, and close all target processes before removal.
Thanks.

Quite a few people actually use the host process to do an inject and forget. Due to the limited impact of leaving the DLL loaded I don't think it is worth messing with, as you said, potential headaches galore (I get enough of those already! :P).


Does lit html support IE10?

I use
'@babel/polyfill',
'@webcomponents/template',

IE11 OK. but IE10 can't work.
Because my project requires minimal support to IE10, so I want to know if there is a way to support IE10

It may work, but we don't support or test in IE10.


SAK-22701 Library: Made the Role Swap capitalization consistent

https://jira.sakaiproject.org/browse/SAK-22701
Text-transformed the role swap words to capitalize the first letter of each word to make the phrase consistent separate of role styling, so "View access Role" is now "View Access Role" and it doesn't matter the capitalization of the role's name.
Before:

After:

Instead of using a css transform just update the bundle with the correct text, as this will cause i18n issues.


SyntaxError: Block-scoped declarations (let, const, function, class) not yet supported outside strict mode

Getting the below error when updating to 4.0.1, which required Node.js 6.0.0
Failed to run "Gulpfile.js"...
cmd.exe /c gulp --tasks-simple
\node_modules\gulp-sass\index.js:66
    let sassMap;
    ^^^
SyntaxError: Block-scoped declarations (let, const, function, class) not yet supported outside strict mode
    at exports.runInThisContext (vm.js:53:16)
    at Module._compile (module.js:373:25)
    at Object.Module._extensions..js (module.js:404:10)
    at Module.load (module.js:343:32)
    at Function.Module._load (module.js:300:12)
    at Module.require (module.js:353:17)
    at require (internal/module.js:12:17)
    at Object.<anonymous> (gulpfile.js:12:16)
    at Module._compile (module.js:397:26)
    at Object.Module._extensions..js (module.js:404:10)

I understand that you've dropped the 'use strict'; decleration, but is it really worth it considering this will force people to update Node.js for the sake of a few characters? (updating Node.js is a bit of a pita in some IDE's such as VIsual Studio). I've not come across any other package that has taken his approach.

It isn't about a few characters. We have dependencies that will not work
with older versions of Node. Node 6 is supported. Make sure your IDE is
configured to use the system Node and not its own embedded Node.
On Tue., 15 May 2018, 2:23 pm Dale Mckeown<EMAIL_ADDRESS>wrote:

Getting the below error when updating to 4.0.1, which required Node.js
6.0.0
Failed to run "Gulpfile.js"...
cmd.exe /c gulp --tasks-simple
\node_modules\gulp-sass\index.js:66
let sassMap;
^^^
SyntaxError: Block-scoped declarations (let, const, function, class) not yet supported outside strict mode
at exports.runInThisContext (vm.js:53:16)
at Module._compile (module.js:373:25)
at Object.Module._extensions..js (module.js:404:10)
at Module.load (module.js:343:32)
at Function.Module._load (module.js:300:12)
at Module.require (module.js:353:17)
at require (internal/module.js:12:17)
at Object. (gulpfile.js:12:16)
at Module._compile (module.js:397:26)
at Object.Module._extensions..js (module.js:404:10)
I understand that you've dropped the 'use strict'; decleration, but is it
really worth it considering this will force people to update Node.js for
the sake of a few characters? (updating Node.js is a bit of a pita in some
IDE's such as VIsual Studio). I've not come across any other package that
has taken his approach.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/dlmanning/gulp-sass/issues/692, or mute the thread
https://github.com/notifications/unsubscribe-auth/AAjZWHm6-KiHEZ9eEe6RHrixQVnp7eYVks5tysipgaJpZM4T_cW5
.

You should only need to tick a check box in your editor settings to use the
system Node JS installation.
On Tue., 15 May 2018, 2:27 pm Michael Mifsud<EMAIL_ADDRESS>wrote:

It isn't about a few characters. We have dependencies that will not work
with older versions of Node. Node 6 is supported. Make sure your IDE is
configured to use the system Node and not its own embedded Node.
On Tue., 15 May 2018, 2:23 pm Dale Mckeown<EMAIL_ADDRESS>wrote:

Getting the below error when updating to 4.0.1, which required Node.js
6.0.0
Failed to run "Gulpfile.js"...
cmd.exe /c gulp --tasks-simple
\node_modules\gulp-sass\index.js:66
let sassMap;
^^^
SyntaxError: Block-scoped declarations (let, const, function, class) not yet supported outside strict mode
at exports.runInThisContext (vm.js:53:16)
at Module._compile (module.js:373:25)
at Object.Module._extensions..js (module.js:404:10)
at Module.load (module.js:343:32)
at Function.Module._load (module.js:300:12)
at Module.require (module.js:353:17)
at require (internal/module.js:12:17)
at Object. (gulpfile.js:12:16)
at Module._compile (module.js:397:26)
at Object.Module._extensions..js (module.js:404:10)
I understand that you've dropped the 'use strict'; decleration, but is
it really worth it considering this will force people to update Node.js for
the sake of a few characters? (updating Node.js is a bit of a pita in some
IDE's such as VIsual Studio). I've not come across any other package that
has taken his approach.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/dlmanning/gulp-sass/issues/692, or mute the thread
https://github.com/notifications/unsubscribe-auth/AAjZWHm6-KiHEZ9eEe6RHrixQVnp7eYVks5tysipgaJpZM4T_cW5
.

As I said, node 6 should work. Your editor it probably configured to use
VS' embedded node version.
On Tue., 15 May 2018, 9:01 pm Dale Mckeown<EMAIL_ADDRESS>wrote:

Yeah, if only Node v8.11.1 would play nicely.
npm/npm#20633 https://github.com/npm/npm/issues/20633
I'll probably revert to the standard Node/NPM versions in VS2017 and go
back to 3.1.0 on this package.
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
https://github.com/dlmanning/gulp-sass/issues/692#issuecomment-389277545,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAjZWB2bwYGY6WBY4Kvqp4vx6bGM3YTbks5tyyYegaJpZM4T_cW5
.

Installed node 6, and set IDE to use the system install and all works now, so thanks for update


add vscode config into gitignore list

Add vscode config file into gitignore list since I am using vscode for remote debugging, it is annoying to see it in "git status".

BUILD on-tftp #852 : ABORTED

** BUILD build-config-setup  #12: SUCCESS
** BUILD unit-tests  #10746: SUCCESS
** BUILD Smoke-Test-2  #17: ABORTED

+1


Can't Add Frigate+ API Key

Please verify that you have read and understood the guidelines.
yes
A clear and concise description of the issue.
Needing to add my frigate+ api key, wondering how this should be done with the LXC.
What settings are you currently utilizing?
Advanced Settings
Which Linux distribution are you employing?
Debian 12
If relevant, including screenshots or a code block can be helpful in clarifying the issue.
No response
Please provide detailed steps to reproduce the issue.
No response

oops dupe of https://github.com/remz1337/Proxmox/issues/11


Calling set within class triggers setter

Godot version:

OS/device including version:

Issue description:

Calling set triggers the setter for a property. This causes a stackoverflow if set is called within the setter.
Steps to reproduce:
This is a slightly-less-minimal example to demonstrate why you might do this:
extends Node

const STAT_MAX := 20

var strength: int setget set_strength
var agility: int setget set_agility
var intellect: int setget set_intellect

func _set_bounded(prop: String, val: int, min_val: int, max_val: int):
	assert(val >= min_val and val <= max_val)
	set(prop, clamp(val, min_val, max_val))
	print_debug("Set %s to %d", prop, get(prop))

func set_strength(val: int):
	_set_bounded("strength", val, 0, STAT_MAX)

func set_agility(val: int):
	_set_bounded("agility", val, 0, STAT_MAX)

func set_intellect(val: int):
	_set_bounded("intellect", val, 0, STAT_MAX)

From another node, call character.strength = 5. The stack will overflow, as set invokes the setter. This is surprising given the docs say:

Whenever the value of variable is modified by an external source (i.e. not from local usage in the class), the setter function (setterfunc above) will be called

As said, local access will not trigger the setter and getter.

I'm happy to add a gotcha to the docs and close this, but I wanted to check if it was intentional first.
Minimal reproduction project:

I'm not sure calling a public method like set constitutes "local access", even if you call it from inside of the class itself.

I'm not sure either, so I think we either need explicit documentation or a change in behavior. I don't feel strongly about which.

I think "local access" relates to GDScript. Everything which calls set() explicitly will call corresponding setter, because that's Object's internal functionality which is agnostic to language used.
What you probably need is overriding _set(), _get(), and _get_property_list() callbacks. See example in this answer, for instance.

Here's another surprising one: does accessing a superclass property within a subclass count as local access? Looks like yes:
extends AudioStreamSample
class_name SineSample

func _init():
	data.resize(22050)  # data is actually get_data(), which returns a copy
	for i in range(22050):
		data[i] = int(127 * sin(0.01 * TAU * i))  # crash! index out of bounds

You actually need:
extends AudioStreamSample
class_name SineSample

func _init():
        var data := PoolByteArray()
	data.resize(22050)
	for i in range(22050):
		data[i] = int(127 * sin(0.01 * TAU * i))
        self.data = data

This isn't necessarily wrong, just confusing. If you asked me before I tried this whether accessing a superclass value from a subclass counts as "local access" or not, I'd probably flip a coin.

I think it's just the nature of dealing with PoolArrays, which are copied and not passed by reference.

It is, but my point is that it isn't clear whether data is "local" or not, which determines whether you get a copy or not.

Aha! https://docs.godotengine.org/en/latest/tutorials/scripting/gdscript/gdscript_basics.html#properties

Unlike setget in previous Godot versions, the properties setter and getter are always called, even when accessed inside the same class (with or without prefixing with self.). This makes the behavior consistent.

4.0 won't have this confusion. :tada:


Errors printed to STDOUT, not STDERR.

All errors rescued by friendly_error.rb are printed to STDOUT.
$ bundle install --foo-bar
Unknown switches '--foo-bar'
$ bundle install --foo-bar > /dev/null
$ bundle install --foo-bar 2> /dev/null
Unknown switches '--foo-bar'

Is this intentional? It tripped me up while writing specs for https://github.com/bundler/bundler/pull/3351 – the error messages were not being printed after the bundle command failed because the standard error buffer was empty: https://github.com/bundler/bundler/blob/master/spec/support/helpers.rb#L136
It's a pretty subtle issue that isn't likely to affect many people, but if it's unintentional behaviour it may be worth updating.

Yeah, we should fix this.
On Mon, Jan 19, 2015 at 3:48 PM, Jordan Raine<EMAIL_ADDRESS>wrote:

All errors rescued by friendly_error.rb are printed to STDOUT.
$ bundle install --foo-bar
Unknown switches '--foo-bar'
$ bundle install --foo-bar > /dev/null
$ bundle install --foo-bar 2> /dev/null
Unknown switches '--foo-bar'

Is this intentional? It tripped me up while writing specs for https://github.com/bundler/bundler/pull/3351 – the error messages were not being printed after the bundle command failed because the standard error buffer was empty: https://github.com/bundler/bundler/blob/master/spec/support/helpers.rb#L136
It's a pretty subtle issue that isn't likely to affect many people, but if it's unintentional behaviour it may be worth updating.
Reply to this email directly or view it on GitHub:
https://github.com/bundler/bundler/issues/3353

I spend some time looking into this tonight and it's not as simple as I'd have hoped.
#with_friendly_errors passes a string to Bundler.ui.error which calls Bundler::UI::Shell#tell_me with the string and :red. Eventually, the string is passed to Thor::Shell::Basic#say where it is formatted and printed to stdout.
The tricky bit is that Thor::Shell::Basic doesn't provide a way to print a message to stderr except for Thor::Shell::Basic#error, which is intended for internal use by Thor only and doesn't provide colour or width formatting.
So, either we write methods that do the formatting and printing to STDERR outside of Thor, write a method that calls into the guts of Thor for formatting and then print it ourselves, or add a method / modify a method in Thor directly (e.g., Thor::Shell::Basic#say_error or Thor::Shell::Basic#say("foo", error: true).
None of these options are great, but for the sake of doing the least work and not hacking dependencies, I think the second option is my favourite. Maybe something like:
# lib/bundler/ui/shell.rb
def say_error(message = '', color = nil, force_new_line = (message.to_s !~ /( |\t)\Z/))
  buffer = @shell.prepare_message(message, *color)
  buffer << "\n" if force_new_line && !message.end_with?("\n")

  @shell.stderr.print(buffer)
  @shell.stderr.flush
end

With tests, we'll notice if Thor changes it's guts when vendor/ is upgraded and can tweak the method at that time.
I'm all ears for a better solution, as this is a bit gross.

pretty sure that’s why we haven’t done it so far. :P your solution is the cleanest one I’ve seen yet!

On Jan 19, 2015, at 10:06 PM, Jordan Raine<EMAIL_ADDRESS>wrote:
I spend some time looking into this tonight and it's not as simple as I'd have hoped.
#with_friendly_errors passes a string to Bundler.ui.error which calls Bundler::UI::Shell#tell_me with the string and :red. Eventually, the string is passed to Thor::Shell::Basic#say where it is formatted and printed to stdout.
The tricky bit is that Thor::Shell::Basic doesn't provide a way to print a message to stderr except for Thor::Shell::Basic#error, which is intended for internal use by Thor only and doesn't provide colour or width formatting.
So, either we write methods that do the formatting and printing to STDERR outside of Thor, write a method that calls into the guts of Thor for formatting and then print it ourselves, or add a method / modify a method in Thor directly (e.g., Thor::Shell::Basic#say_error or Thor::Shell::Basic#say("foo", error: true).
None of these options are great, but for the sake of doing the least work and not hacking dependencies, I think the second option is my favourite. Maybe something like:
lib/bundler/ui/shell.rb
def say_error(message = '', color = nil, force_new_line = (message.to_s !~ /( |\t)\Z/))
buffer = @shell.prepare_message(message, *color)
buffer << "\n" if force_new_line && !message.end_with?("\n")
@shell.stderr.print(buffer)
@shell.stderr.flush
end
With tests, we'll notice if Thor changes it's guts when vendor/ is upgraded and can tweak the method at that time.
I'm all ears for a better solution, as this is a bit gross.
—
Reply to this email directly or view it on GitHub https://github.com/bundler/bundler/issues/3353#issuecomment-70608914.

:smile:
I've submitted a PR with a working implementation. The solution isn't great so feel free to axe it if you don't feel it's clean enough.

+1 for fixing this issue

This was done in https://github.com/bundler/bundler/commit/300fcbe2a06b9b44d1935e01a1548be22949ffaa, which will ship in Bundler 2.0.


'async' is a reserved word in Python 3.7

async is a reserved word in Python 3.7 so it is a Syntax Error to use it as the name of a function parameter.  Some projects like cuda are using non_blocking instead of async.
flake8 testing of https://github.com/diux-dev/imagenet18 on Python 3.7.0
$ flake8 . --count --select=E901,E999,F821,F822,F823 --show-source --statistics
./train.py:192:23: E999 SyntaxError: invalid syntax
    task.run(cmd, async=True)
                      ^
./tools/launch_tensorboard.py:14:56: E999 SyntaxError: invalid syntax
task.run(f'tensorboard --logdir={task.logdir}/..', async=True)
                                                       ^
2     E999 SyntaxError: invalid syntax
2

Oh wow, this is a crash and not just a warning in 3.7? I thought backward compatibility breaking was reserved for major version number change

Not really possible in a language that only has three Major versions while v1.0 was released in 1994.
https://devguide.python.org/devcycle

Fixed by #6


Allow configuration of boottime parameters by environment variables

This patch enables configuration of the following boot-time parameters through the environment variables:

max_connections (POSTGRES_MAX_CONNECTIONS)
max_prepared_transactions (POSTGRES_MAX_PREPARED_TRANSACTIONS)

Sorry for the long review delay :disappointed:
This can already be accomplished pretty easily without modifying the image, via -c:
$ docker run -dit --name test postgres -c max_connections=200 -c max_prepared_transactions=400
722a07c55a76ec6175cea4d9908e14624f22eef8ee5fdc6bb63a4f5591972f36
$ docker exec -it test psql -U postgres
psql (9.6.2)
Type "help" for help.

postgres=# SHOW max_connections; SHOW max_prepared_transactions;
 max_connections
-----------------
 200
(1 row)

 max_prepared_transactions
---------------------------
 400
(1 row)

postgres=#

Thanks! :heart:


Add argparse to FoV application

Simple one for now

I guess now we can merge?

Yep

When you say output directory, you mean for what?
The FOV produced a pdf in the working directory.

On 25. May 2020, at 13:48, RaulRPrado<EMAIL_ADDRESS>wrote:
@RaulRPrado commented on this pull request.
In applications/validate_camera_fov.py:

site = 'south'
telescope = 'lst'
version = 'prod4'
label = 'lst-test'

label = '{}-test'.format(args.tel_type.lower())

Label is actually always relevant.
It's used to label all the output files, and the output directory structure. It's suppose to be used by all the modules that produce any kind of output.
There is the option of not giving any label (the date will be used for the output directory name) but it's not a good practice.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or unsubscribe.

Dr Gernot Maier
CTA
Deutsches Elektronen-Synchrotron DESY
Ein Forschungszentrum der Helmholtz-Gemeinschaft
Platanenallee 6, D-15738 Zeuthen, Germany
Tel.: +49  33 7627 7598
Internet: www.desy.de/cta
Besucheradresse: 1X07

When you say output directory, you mean for what? The FOV produced a pdf in the working directory.

You can ask the TelescopeModel to exportConfigFile, for example. Or you can ask the Camera to export a new camera config file with a certain change (not implemented, just an example).
This is a peculiar application that does not produce any output, but basically all the other ones do.
The output directory is split. If you run any ray tracing application, there will be model related outputs and ray tracing related outputs, for example.

And in particular we haven't figured out yet what to do with output plots (as we mentioned at some point today in one of these many issues). We think they should be produced locally and then optionally be pushed into the database.

ok!

On 25. May 2020, at 14:01, RaulRPrado<EMAIL_ADDRESS>wrote:
When you say output directory, you mean for what? The FOV produced a pdf in the working directory.
You can ask the TelescopeModel to exportConfigFile, for example. Or you can ask the Camera to export a new camera config file with a certain change (not implemented, just an example).
This is a peculiar application that does not produce any output, but basically all the other ones do.
The output directory is split. If you run any ray tracing application, there will be model related outputs and ray tracing related outputs, for example.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or unsubscribe.

Dr Gernot Maier
CTA
Deutsches Elektronen-Synchrotron DESY
Ein Forschungszentrum der Helmholtz-Gemeinschaft
Platanenallee 6, D-15738 Zeuthen, Germany
Tel.: +49  33 7627 7598
Internet: www.desy.de/cta
Besucheradresse: 1X07


Ensemblesoftware - The message "Cluj is not a city in Romania" is displayed instead of the job locations

ENVIRONMENT: production
URL: https://scrapers.peviitor.ro/
Browser: Chrome
Device: Laptop
OS: Windows 10
STEPS TO REPRODUCE:

Open the URL in the browser
Search for "Ensemblesoftware" Company
Click on "Run Scraper" button
Check the job locations

EXPECTED RESULTS:
Job locations are the same in Scrapers-UI as on the company website
ACTUAL RESULTS:
The message "Cluj is not a city in Romania" is displayed instead of the job locations
Attachments:

Fixed can you retest?

Retested


Replace smap and sfold with smapaccum in CorePPL

Currently, we are implementing smap and sfold manually for CorePPL terms. We should instead implement smapaccum, to follow the change in https://github.com/miking-lang/miking.

Fixed a while ago now, closing.


Is "master" terminology planned to be deprecated?

Sorry if this is not the place.
Reading Opensearch 2.0 documentation, says that inclusive language is being implemented. However for helm charts "old" terminology is still being used.
Do you plan to deprecate this in a planned version?
thanks

Good point, we can plan this out. This is a good change to have. What do you say @prudhvigodithi @peterzhuamazon @DandyDeveloper ?

@demian711 @TheAlgo please follow this meta issue on the status of inclusive language changes:
https://github.com/opensearch-project/OpenSearch/issues/2589#issuecomment-1101707941
Thanks.

@peterzhuamazon So I assume we can deprecate the master terminology for helm charts in for charts which are using 2.x version as default version?

@peterzhuamazon So I assume we can deprecate the master terminology for helm charts in for charts which are using 2.x version as default version?

The problem being not everyone has deprecated the terminology.
We can try from our part but IDK if that would cause any issues if any plugin still uses master node terminology.
Thanks.


Build & test on Java 16

Blocked until next Gradle Shadow plugin release.

@3flex where you able to understand what are the build failures? It seems we have failing tests plus generateDocumentation is failing

I believe it's now blocked thanks to an out of date transitive dependency of mockk and also Android Gradle Plugin incompatibility with Java 16.
Mockk will be fixed soon enough I expect but I can manually add the required dependency version to fix it in the meantime.
I can't find compatibility info for AGP. They probably only officially support the JDK version shipped with Android Studio (currently 11?) So Android tests should probably be skipped on other JDK versions.
I have to check the generateDocumentation task.

All issues resolved, but still blocked until we update to Kotlin 1.5.0


4s hangs on Windows

When I try to execute 4s on Windows with devdraw from http://sam.cat-v.org/_files/win32_sam.zip, it  hangs and uses up all memory, never creating a new window.
Steps to reproduce:

Have devdraw.exe in your PATH.
go get 9fans.net/go/games/4s
%GOPATH%/bin/4s

I am not 100% sure but my guess is that the problem is in the Windows devdraw. That port of sam is somewhat unofficial and may well be out of sync with the main plan9port, which 9fans.net/go/games/4s depends on. There has been talk on plan9port-dev recently about a complete port to Windows. Maybe if that works out, the new devdraw will work better.
Closing this issue because I'm pretty much certain it's not the Go code's problem but instead the stale devdraw. And I don't know how to make a new devdraw on Windows, but I hope the effort I mentioned leads to that.


[a11y][suggest] 'No suggestions' is not announced to the screen reader when displayed on the screen

Does this issue occur when all extensions are disabled?: Yes/No

VS Code Version: Monaco v0.40.0-dev.20230626
OS Version: Mac OS 13.4.1 (22F82), Windows 10 Enterprise 10.0.19045 Build 19045, Jaws 2020.2006.12 ILM, NVDA 2022.3

Steps to Reproduce:

Enable a screen reader such as VoiceOver or NVDA
Open the monaco interactive playground https://microsoft.github.io/monaco-editor/playground.html
Type some characters which will produce an unmatched prefix, ie. zz
Type ctrl+space to open autocomplete popup
Notice that the screen reader does not announce the "No suggestions." text in the listbox. The user cannot navigate to highlight the item when the listbox is open.

This seems to be a violation of WCAG 2.1 4.1.3

Thanks for creating this issue! It looks like you may be using an old version of VS Code, the latest stable release is 1.80.1. Please try upgrading to the latest version and checking whether this issue remains.
Happy Coding!

This should be resolved by the associated PR.


Extra show makes JSON decoding errors look bad

I'm finding that when reading a configuration file produces an error in the JSON decoding phase, the error is quoted and escaped:
% my-app
Failed to parse configuration:
... <schema shown>
"Error in $[2]: \n  Previous branch failure: Error in $: expected Null, but encountered Array\n  Previous branch failure: Error in $: key \"name\" not found\n  Previous branch failure: Error in $: Not an Object\nparsing Text failed, expected String, but encountered Object"

This is hard to read; I'd prefer it not be,
% my-app
Failed to parse configuration:
... <schema shown>
Error in $[2]:
  Previous branch failure: Error in $: expected Null, but encountered Array
  Previous branch failure: Error in $: key "name" not found
  Previous branch failure: Error in $: Not an Object
parsing Text failed, expected String, but encountered Object

As far as I can tell, this is due to this show in renderErrors
        ParseErrorConfigRead md s ->
          ["Failed to parse configuration: "]
            : maybe [] renderConfDoc md
            ++ [[chunk $ T.pack $ show s]]

I can't really see any reason to do this, since the value is already a String:
  | ParseErrorConfigRead !(Maybe ConfDoc) !String

Can it be removed?

Oh yup looks like that's a mistake. Pr welcome!

Oh I'm so sorry, I opened this on the wrong repo. This behavior is in opt-env-conf :facepalm:
I'll either PR or report there (if I don't get to the PR). Sorry!