Some rxjs operators aren't available on valueChanges and snapshotChanges

Version info

Angular: 5.0.0
Firebase: 3.6.6
AngularFire: 5.0.0-rc.3
How to reproduce these conditions
Failing test unit, Plunkr, or JSFiddle demonstrating the problem
https://angular-abvhh2.stackblitz.io/
Steps to set up and reproduce

Create an observable from a simple object using valueChanges or snapshotChanges
Use map, debounceTime or mergeMap operator on it (didn't test every other operator, some are working, the other do not.
Check the error in the console:

ERROR TypeError: this.afdb.object(...).valueChanges(...).debounceTime is not a function

Debug output
** Errors in the JavaScript console **
ERROR TypeError: this.afdb.object(...).valueChanges(...).debounceTime is not a function
    at HelloComponent.ngOnInit (hello.component.ts:31)
    at checkAndUpdateDirectiveInline (provider.ts:272)
    at checkAndUpdateNodeInline (view.ts:505)
    at checkAndUpdateNode (view.ts:443)
    at debugCheckAndUpdateNode (services.ts:377)
    at debugCheckDirectivesFn (services.ts:464)
    at Object.eval [as updateDirectives] (AppComponent.html:1)
    at Object.debugUpdateDirectives [as updateDirectives] (services.ts:443)
    at checkAndUpdateView (view.ts:359)
    at callViewAction (view.ts:767)

Expected behavior
This operator should be available.
Actual behavior
It is not.
The issue seems to come from the fact that Angular uses<EMAIL_ADDRESS>and angularfire2 uses<EMAIL_ADDRESS>

Hey there, this is because we import Observable from rxjs/Observable rather than rxjs/Rx to keep the bundle size low.
You can import the operators you need like so import 'rxjs/add/operator/debounceTime';
Here's the fixed stackblitz https://stackblitz.com/edit/angular-jwxavu?file=app/hello.component.ts


The URL gets trunctated when there is a comma in the document filename when the copy URL function is used

Description
When you are in SharePoint and open Sidekick, there is a copy URL function that appears when a file is selected. It works fine EXCEPT when the document name contains a comma
To Reproduce
Steps to reproduce the behavior:
Upload any document in SharePoint with a filename that has a comma e.g "this,is a test.dox"
2. Open Sidekick, log in and select the document
3. In SharePoint select the file and click the "Copy URL" function (preview or live)
4. Check the copied URL
Expected behavior
Complete URL path is returned
Actual behavior
URL was truncated on the part where the comma is "e.g. https://somedomain.com/drafts/this
instead of https://somedomain.com/drafts/this-is-a-test
Screenshots
If applicable, add screenshots to help explain your problem.
Additional context
Business impact: Users would have to manually construct the URL in preview or publish mode which is not easy for neophyte users

The same issue occurs with a . in the filename

:tada: This issue has been resolved in version 6.40.3 :tada:
The release is available on:

GitHub release
v6.40.3

Your semantic-release bot :package::rocket:


feat: quantity_point

Resolves #1.

Hi, thanks! We have to go back to indeed. I wrote a similar class a long time ago but still did not commit after being discouraged with finding that degree of Celsius collides with Kelvin as both have exactly the same ratio :-( After that I spent more time on fixing the downcasting rather than scoping on finishing the work on a quantity_point class template.
Please give a few days to review this as I am extremely busy lately...

Sure. I'm looking forward to it.

No worries. Thank you.


add citation file #151

please check out https://docs.github.com/en/repositories/managing-your-repositorys-settings-and-features/customizing-your-repository/about-citation-files
that way we can cite your work on fmi4cpp and Github adds a nice Cite this repository button  :)

closes #151

by the way @markaren if you push fmi4cpp to Zenodo you then get a DOI that you can add to the citation file
check it out here https://docs.github.com/en/repositories/archiving-a-github-repository/referencing-and-citing-content
it is really nice to get your work easily citeable

I'll look into it. Are you in a hurry with publishing a paper that should include a reference?

yes we are :) we have to submit the paper end of october

the CFF file is sufficient to get a nice bibtex from Github. The doi is of course better and the publisher asks that we have DOIs associated with our references. We won't be able to have that all the publications we cite, so it is not a biggy.
Would be nice though, in the future ;)


Chinese to English translation

Checklist

[x] commit message follows commit guidelines

Description of change
Chinese to English translation

Thanks for your contribution 🎊 🎊


Request for size limit increase for CuPy packages

Hello,
I'm maintaining packages for CuPy, and would like to request size limit increase for the following packages to distribute wheels.

cupy-cuda90, cupy-cuda91, cupy-cuda92: 350 MB
cupy-cuda100, cupy-cuda101: 400 MB

These packages currently have limit of 300 MB / 350 MB respectively.
This is a re-request of size increase due to the increased size of dependent library (CUDA cuDNN) in recent versions.
We had been releasing wheels with these names once per month, and would like to continue it.
Thank you as always for your continued support!

I've set the upload limit for all 5 projects to 400MB on PyPI.

Thank you!


Multiple browser support - review alternatives to recaptcha

A user on FreeBMD reported issues with the lack of recaptcha support for the Opera mini browser. While it is not possible to support all browsers, we should investigate and review possible alternatives.

recaptcha currently used on postem as a barrier to bots
See 5f6a1862e93790387daff6a9/2957203/

@PatReynolds to check the nature of the issue with the team, suggest better pathway, with questions to weed out the wrong'uns, and a simple test (e.g. ask people to spell 10 in English)

CAPTCHA are "allowed under the W3C's Web Content Accessibility Guidelines (WCAG) provided that "text alternatives that identify and describe the purpose of the non-text content are provided, and alternative forms of CAPTCHA using output modes for different types of sensory perception are provided to accommodate different disabilities.
It is important to understand the limitation of the WCAG CAPTCHA exemption. It applies only to the content of the CAPTCHA. WCAG still requires that alternative text identify the graphical object as a CAPTCHA. Conformance with all other WCAG guidelines also remains critical for web accessibility."  (https://www.w3.org/TR/turingtest/, checked that it is the current version 21/10/2020).
Potential solutions are a (better) spam filter, honeypot, recaptcha v3 or a logic test (or a combination of these). Support@emailed 21/10/2020

@PatReynolds to see if recaptcha v3 is working on Opera

Could not find a site where I could test, but https://support.google.com/recaptcha/answer/6223828?hl=en does not include Opera in its list of supported browsers.  NB only two latest versions of those it does support are supported.  We know a major user is stuck on an earlly versino of IE, so don't think recaptcha v3 is a solution.
Suggest implementing a logic test and see if this is sufficient.

@PatReynolds  to check bot traps as a solution

Google version uses mouse movements and cookies (tracking history) - so would not work.
Homenypot: https://solutionfactor.net/blog/2014/02/01/honeypot-technique-fast-easy-spam-prevention/ seems ok - @Vino-S  what do you think?

Google version uses mouse movements and cookies (tracking history) - so would not work.
Homenypot: https://solutionfactor.net/blog/2014/02/01/honeypot-technique-fast-easy-spam-prevention/ seems ok - @Vino-S  what do you think?

@Vino-S to take a look and see if this is 'do-able' or not.

@Vino-S to take a look and see if this is 'do-able' or not.

Closing- decided and implemented.


Reconciling Depositor name change with subsequent dataset updates

When a depositor changes their name on their profile and subsequently updates an existing dataset, LD-Cool-P recognizes that the dataset is v2 and creates the appropriate folder structure. However, because the v1 dataset was named using the previous depositor name, you will now have two folders, one with v1 and one with v2
Old_Name_12345678
-v1
New_Name_12345678
-v2
I'm not sure what the best way to reconcile this situation is. Two solutions that come to mind

Have the software always ignore the name and only consider the article_id when looking for the correct folder.
Strip the depositor name from all folders (not ideal for human readability)
EDIT: another option is to rename Old_Name to New_Name
EDIT: another option is to not address this edge case and manually correct the problem.

This is a good point that you raise. Question: What does the citation metadata show for v1?
Option 1 would work but keep in mind that the DepositorName class uses the newest figshare metadata. It would require re-working that piece of metadata code to handle such an exception. DepositorName has significantly evolved as more metadata have been incorporated into it. I've been wanting to refactor it to make it easier and to have metadata modular depending on sources/needs. Note that a unique identifier ID does exist for each depositor. The trouble is keeping track as Figshare does not keep track of previous names. Honestly, what happens if someone keeps changing their name because they can't decide?
Option 2 is not UX, so that's out. I made a choice to do it as such simply for human readability.
Option 3 might work. One thing I wonder is what would happen if say we attempted to retrieve the data. If it uses the new name then I think we are OK. Though this seems very similar to Option 4 as renaming can easily be a manual correction. Though keep in mind, do we want to keep a record of such a change? Note that other stuff (e.g., curation review report) has such information.
Keep in mind that a simple symbolic link for v1 to the new folder might just work after publication.

Option 3 might be the simplest right now. Especially as we begin to ramp up preservation work, it might be easier both from the software side and human side to refer to things using their current name. A record of the change would already be present in the readme and curation reports. Because of that, I can't think of a reason to keep track of such changes separately, especially since other things like title can already be mismatched between the review report and the actual title.


e2e: ingress annotations does not need to use v2beta3

Type of change:

[ ] Bugfix
[ ] New feature provided
[x] Improve performance
[ ] Backport patches

What this PR does / why we need it:

Pre-submission checklist:

[ ] Did you explain what problem does this PR solve? Or what new features have been added?
[ ] Have you added corresponding test cases?
[ ] Have you modified the corresponding document?
[ ] Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first

Codecov Report

Merging #1503 (5b8d77a) into master (97f6aed) will not change coverage.
The diff coverage is n/a.

:exclamation: Current head 5b8d77a differs from pull request most recent head a5c99b4. Consider uploading reports for the commit a5c99b4 to get more accurate results

@@           Coverage Diff           @@
##           master    #1503   +/-   ##
=======================================
  Coverage   41.48%   41.48%
=======================================
  Files          89       89
  Lines        7667     7667
=======================================
  Hits         3181     3181
  Misses       4122     4122
  Partials      364      364

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


dont abort on empty title in utils::make_title

Hi,
I have a feed (https://www.heute.de/?view=rss) which includes "sometimes" completely broken items, which due to newsbeuter trying to generate a title for those items results in an abort by an unhandled exception. The commit in the "middle" is fixing the abort in the util function, but perhaps on a more global view newsbeuter maybe shouldn't act on strange items.
Anyway, I stumbled over two tiny other things in the process and have that included here as well as I was too lazy to make independent pullrequest for it, but if you prefer I will try to be less lazy. ;)
Best regards
David

Sure, can change that, no problem. On the "\n or no \n" between } and else I was completely undecided as I had seen both so I was expecting changing it either way as that is my type of "luck". And for the uppercasing of the first letter I can only say: Oh, the irony… ;)

Coverage increased (+0.02%) to 32.385% when pulling c15dd91b5c1e34c812ba8102ae11d07ee02557d8 on DonKult:bugfix/dont-abort-on-empty-make-title into abaad749aa2ff65113d16ede9523a6a22af6458e on akrennmair:master.

Coverage increased (+0.02%) to 32.385% when pulling c15dd91b5c1e34c812ba8102ae11d07ee02557d8 on DonKult:bugfix/dont-abort-on-empty-make-title into abaad749aa2ff65113d16ede9523a6a22af6458e on akrennmair:master.

Coverage increased (+0.02%) to 32.385% when pulling c15dd91b5c1e34c812ba8102ae11d07ee02557d8 on DonKult:bugfix/dont-abort-on-empty-make-title into abaad749aa2ff65113d16ede9523a6a22af6458e on akrennmair:master.

Coverage increased (+0.02%) to 32.385% when pulling c15dd91b5c1e34c812ba8102ae11d07ee02557d8 on DonKult:bugfix/dont-abort-on-empty-make-title into abaad749aa2ff65113d16ede9523a6a22af6458e on akrennmair:master.

Coverage increased (+0.02%) to 32.385% when pulling c15dd91b5c1e34c812ba8102ae11d07ee02557d8 on DonKult:bugfix/dont-abort-on-empty-make-title into abaad749aa2ff65113d16ede9523a6a22af6458e on akrennmair:master.

Coverage increased (+0.02%) to 32.385% when pulling c15dd91b5c1e34c812ba8102ae11d07ee02557d8 on DonKult:bugfix/dont-abort-on-empty-make-title into abaad749aa2ff65113d16ede9523a6a22af6458e on akrennmair:master.

Coverage increased (+0.02%) to 32.385% when pulling c15dd91b5c1e34c812ba8102ae11d07ee02557d8 on DonKult:bugfix/dont-abort-on-empty-make-title into abaad749aa2ff65113d16ede9523a6a22af6458e on akrennmair:master.

And for the uppercasing of the first letter I can only say: Oh, the irony… ;)

Ooh, that was deep; took me a while to see the connection with the PR's purpose :)
I'll merge this the moment Travis successfully finishes the build. Thanks!

Coverage increased (+0.02%) to 32.38% when pulling a038cd98850148e6d79c97e5b1903ef1811da237 on DonKult:bugfix/dont-abort-on-empty-make-title into abaad749aa2ff65113d16ede9523a6a22af6458e on akrennmair:master.

Coverage increased (+0.02%) to 32.38% when pulling a038cd98850148e6d79c97e5b1903ef1811da237 on DonKult:bugfix/dont-abort-on-empty-make-title into abaad749aa2ff65113d16ede9523a6a22af6458e on akrennmair:master.

Coverage increased (+0.02%) to 32.38% when pulling a038cd98850148e6d79c97e5b1903ef1811da237 on DonKult:bugfix/dont-abort-on-empty-make-title into abaad749aa2ff65113d16ede9523a6a22af6458e on akrennmair:master.

Coverage increased (+0.02%) to 32.38% when pulling a038cd98850148e6d79c97e5b1903ef1811da237 on DonKult:bugfix/dont-abort-on-empty-make-title into abaad749aa2ff65113d16ede9523a6a22af6458e on akrennmair:master.

Coverage increased (+0.02%) to 32.38% when pulling a038cd98850148e6d79c97e5b1903ef1811da237 on DonKult:bugfix/dont-abort-on-empty-make-title into abaad749aa2ff65113d16ede9523a6a22af6458e on akrennmair:master.

Coverage increased (+0.02%) to 32.38% when pulling a038cd98850148e6d79c97e5b1903ef1811da237 on DonKult:bugfix/dont-abort-on-empty-make-title into abaad749aa2ff65113d16ede9523a6a22af6458e on akrennmair:master.

Coverage increased (+0.02%) to 32.38% when pulling a038cd98850148e6d79c97e5b1903ef1811da237 on DonKult:bugfix/dont-abort-on-empty-make-title into abaad749aa2ff65113d16ede9523a6a22af6458e on akrennmair:master.

Coverage increased (+0.02%) to 32.38% when pulling a038cd98850148e6d79c97e5b1903ef1811da237 on DonKult:bugfix/dont-abort-on-empty-make-title into abaad749aa2ff65113d16ede9523a6a22af6458e on akrennmair:master.


Change version to 2.0.0-preview-1

PR Checklist
PR Structure

[ ] This PR has reasonably narrow scope (if not, break it down into smaller PRs).
[ ] This PR avoids mixing refactoring changes with feature changes (split into two PRs
otherwise).
[ ] This PR's title starts with name of package that is most changed in the PR, ex.
paymentservice.stellar, or all or doc if the changes are broad or impact many
packages.

Thoroughness

[ ] This PR adds tests for the most critical parts of the new functionality or fixes.

What
Change version to 2.0.0-preview-1.
Why
N/A
Known limitations
N/A

Reference Server Preview is available here:https://anchor-ref-pr786.previews.kube001.services.stellar-ops.com/SEP Server Preview is available here:https://anchor-sep-pr786.previews.kube001.services.stellar-ops.com/

Reference Server Preview is available here:https://anchor-ref-pr786.previews.kube001.services.stellar-ops.com/SEP Server Preview is available here:https://anchor-sep-pr786.previews.kube001.services.stellar-ops.com/


(CLOUD-70) Handle much more complex security groups

Previously we had support for quite simple security group types. This
issue gives an idea of a more realistic target:
https://github.com/puppetlabs/puppetlabs-aws/issues/42
This work in progress code aims to handle that issue, as well as
multiple variations. I have local test cases that need turning into acceptance
tests, and some more of the rules code can be pulled into the new class.
The class itself also wants a bit of tidying up and independent tests.
But at the moment this works for me locally against a non-trivial
security group config so woot.

This work in progress code aims to handle that issue,

Since this is no longer a WIP could you update the first commit message, as well as squash the other two commits into it?

Also seeing this failure in the acceptance tests:
2) ec2_securitygroup create a new securitygroup with manifest describe ec2 securitygroup with puppet resource ingress rules are correct
     Failure/Error: expect(@response.stdout).to match(regex)
       expected "ec2_securitygroup { 'colleen@tak-f0d42d5d-aad7-4587-82e0-9d79b99c5a71':\n  ensure      => 'present',\n  description => 'A_security group used in an automated acceptance test',\n  ingress     => [{'from_port' => '1', 'protocol' => 'tcp', 'security_group' => 'default', 'to_port' => '65535'}, {'from_port' => '1', 'protocol' => 'udp', 'security_group' => 'default', 'to_port' => '65535'}, {'from_port' => '-1', 'protocol' => 'icmp', 'security_group' => 'default', 'to_port' => '-1'}, {'cidr' => '<IP_ADDRESS>/0', 'from_port' => '22', 'protocol' => 'tcp', 'to_port' => '22'}],\n  region      => 'sa-east-1',\n  tags        => {'created_by' => 'aws-acceptance', 'department' => 'engineering', 'dude' => 'Sweet!', 'project' => 'cloud'},\n}\n" to match /('port')(\s*)(=>)(\s*)('22')/
       Diff:
       @@ -1,2 +1,8 @@
       -/('port')(\s*)(=>)(\s*)('22')/
       +ec2_securitygroup { 'colleen@tak-f0d42d5d-aad7-4587-82e0-9d79b99c5a71':
       +  ensure      => 'present',
       +  description => 'A_security group used in an automated acceptance test',
       +  ingress     => [{'from_port' => '1', 'protocol' => 'tcp', 'security_group' => 'default', 'to_port' => '65535'}, {'from_port' => '1', 'protocol' => 'udp', 'security_group' => 'default', 'to_port' => '65535'}, {'from_port' => '-1', 'protocol' => 'icmp', 'security_group' => 'default', 'to_port' => '-1'}, {'cidr' => '<IP_ADDRESS>/0', 'from_port' => '22', 'protocol' => 'tcp', 'to_port' => '22'}],
       +  region      => 'sa-east-1',
       +  tags        => {'created_by' => 'aws-acceptance', 'department' => 'engineering', 'dude' => 'Sweet!', 'project' => 'cloud'},
       +}

     # ./spec/acceptance/securitygroup_spec.rb:366:in `block (6 levels) in <top (required)>'
     # ./spec/acceptance/securitygroup_spec.rb:364:in `each'
     # ./spec/acceptance/securitygroup_spec.rb:364:in `block (5 levels) in <top (required)>'
     # ./spec/acceptance/securitygroup_spec.rb:363:in `each'
     # ./spec/acceptance/securitygroup_spec.rb:363:in `block (4 levels) in <top (required)>'

Additionally, would it be worthwhile to write additional acceptance tests for these more complex cases?

@cmurphy fixed the message the failing test. I'll add acceptance tests for the new rule formats and ping you back.

@cmurphy this now has a bunch of acceptance tests which use the new options.

This needs a rebase now :(

@cmurphy thanks, should be rebased against master now.

This doesn't seem to work for security groups associated with a VPC. I'm seeing
Error: Invalid value 'test-sg' for groupName. You may not reference Amazon VPC security groups by name. Please use the corresponding id for this operation.

Seems like maybe prepare_ingress_for_api needs to use an ID instead of the group_name in the rules_hash?

@cmurphy I could swear I'd fixed that but obviously not (or I'd rebased it out). Sorry about that. Resolved in an amended commit. I've run acceptance on this through on both accounts this morning.


Updated and improved French translation

Hi,
I've updated the French translation, but it seems like I can't push my commit to your repo (I'm quite new to git, so maybe I missed something).
Here's the file.
fr.zip
Thanks,

These translations could have a university degree by now. That's how slow I am.
They'll be included in the next release (0.14.0). Thank you very much 🙏


Allow private docker repository usage

Currently only public docker repository can be used for function deployment. However user might want to use private one.

I think this can be configured directly on the cluster, for example on Openshift we can "teach" the cluster how to pull from private repos using secrets.

@jrangelramos yes that's true, but we don't make easy for user, if user forgets to set the secret on the cluster then deployment fails and use has to search for the cause.

I updated description and title.

@matejvasek I wonder if you have any ideas in mind on how the usage of this would be. I was thinking:

A new command in func like maybe func config-registry
A flag in func deploy that would create/update and configure the pull secrets in the cluster
A dynamic check at deploy time that detects that the pod's status is ImagePullBackoff and suggests the preferred way of configuring the secrets

There's probably more ways to achieve this but I'd like to know your thoughts.
Also I can see this being useful not only for functions. Maybe it's worth moving this to kn client?

I don't have specific idea. For starer just some check that image is private and subsequent warning with link to documentation should be enough.

Thanks @matejvasek , I think I can tackle this one.
/assign


Refactor code layout in simulate 3D

Effectively trying to break down the computational flow into separate parts following

Parsing PDB structure into atom coordinates, identities, and b-factors (already done)
Calculating the voxel offsets and sampling needed for simulating the scattering potentials using the provided simulation parameters
Actually calculating the scattering potential around atoms on a per-atom basis
Placing these pre-calcuated scattering potentials back into the whole simulation volume
Applying any additional filters to the volume in Fourier space
Exporting the density to a file, if requested

Separating out into different pieces improves composability (e.g. not placing certain atoms from the pre-calculated stack back into the whole volume). Writing unit tests should be easier too.
TODO:

[x] Add basic unit tests to ensure no changes are breaking
[ ] Apply consistent naming conventions for variables across files

The simulate 3D code has been refactored to a state where the calculation of scattering potentials around atoms, placing atoms into a larger volume, and application of post-simulation filters are separate.
Also, there is a test included which compares the output of ttsim3d.simulate3d  with the current code to a known "good" simulation stored on zenodo.
There is some further code cleanup that could be done, but that can be for a later date.


Documentation: Add "Mentioned In" section #80

Fix #80

Hey @Emalsha. Thanks for your contribution 👍 Would be nice if you could leave a star for the library and/or use the tool where this component is used: caseconverter.pro.
I tagged this Pull Request with the necessary hacktoberfest labels, in case you are participating there. Thanks a lot, contributors like you make Open Source awesome 💯
@all-contributors please add @Emalsha for docs


Suggestion for "A Quick Glance" code in README.md

In the variabel stateMachine does not exist I guess it should be fsm.
States.Idle does not exist I guess it should be States.Normal

Oh dear, I see what I've done. Sorry about that. Actually fsm (the field, not the parameter) should be stateMachine. I'm on my phone atm, if you make another commit I'll merge this PR in a couple hours or so :)
Thanks!


Add markdown tutorials

What does this PR do?
Add resources
For resources
Description
Add markdown tutorial
For book lists, is it a book? For course lists, is it a course? etc.
It's a tutorial.
Checklist:

[x] Read our contributing guidelines.
[x] Search for duplicates.
[x] Include author(s) and platform where appropriate.
[x] Put lists in alphabetical order, correct spacing.
[x] Add needed indications (PDF, access notes, under construction).
[x] Used an informative name for this pull request.

I was surpised we didn't have these! And yes, it's an interactive tutorial


Address generation

Hi Michal, is there plans to handle new wallet generation within this repo similar to Bigreddmachine's implementation, Or do you consider that to be outside of the scope?

It's definitely within the scope. Tools for generating offline wallets are super important. Ideally, I'd like to have it:

able to generate sub-accounts and sub-addresses so that a real wallet generated from the seed would recover funds sent there,
support different mnemonic languages,
support seed encryption like here: https://xmr.llcoins.net/ (or other standard if it exists),
use good randomness source on all systems,
be named in some meaningful way (Wallet and Account class names are taken already).

I'm not familiar with algorithms used there and my priorities now are to finish the docs, extend functionality of wallet wrapper (payment proofs, multisig) and investigate the libwallet backend.
But perhaps you are interested in coding those offline tools?

Yeah, I'll take a crack at it. I'll probably just make a few issues and knock it out one piece at a time

Started this on my fork's branch, mnemonics: https://github.com/lalanza808/monero-python/blob/mnemonics/monero/seed.py

#9 is ready to be merged which provides the basic functionality required for this.

We covered the basics with the recent PR's - closing this issue and making specific issues to address the remainder of functionality.


Refactor repo related functions

Reflect changes in #191

@brandonpollack23 @hikalium
CC @mhiramat
I have filed an issue https://github.com/google/lium/issues/218 on this topic, so could you discuss the option names there?
Please merge this PR once and create another PR if you decide to change.


PLease script in blacklist from this website

http://videostream.dn.ua/videopage/videoPage.php?g=MTY5OTM№f&c=es&i=eWl2a3Vmb2F1Yg№f№f
Note: Issue after click in any video on this website.
Tks

Can't reproduce. Might be a local issue, i.e. the device you are working with temporarily can't handle the load.


Add playwright install to makefile

Fixes https://github.com/OpenDevin/OpenDevin/issues/1435

LGTM, @neubig I approve but maybe I can try to check if there's any better structure to get it done instead of hard coding the full command like adding the dependency to poetry file or something similar 👌


Camel 4.4 - Allow to configure camel.variable.xxx

Describe the feature here
Camel 4.4 introduced variables which can be configured from application.properties.
https://issues.apache.org/jira/projects/CAMEL/issues/CAMEL-19749
However for Quarkus and Spring Boot then this requires to add code to support this
A SB example is at
https://github.com/apache/camel-spring-boot-examples/tree/main/variables
And the commit in SB to support this is:
https://github.com/apache/camel-spring-boot/commit/671e772eb2240ff0e4537f5e5d4330714cb73f24

There are 3 parts of the solution:

Code in the camel-quarkus main: which is already merged in the camel-main branch as a part of upgrade to Camel 4.4
Basic test coverage: https://github.com/apache/camel-quarkus/pull/5654
Example: https://github.com/apache/camel-quarkus-examples/pull/194


#686 - feat(services) - add status

Closes #686
Define a service status depending on tasks status
This is the rule :
    // If runningTasks.length === 0, service is down
    // If runningTasks.length != Replicas, we are preparing or in a loop of start/fail
    // If all running => running
    // If some running but not all => Partially running
    // If some starting and no running => starting
    // If no running, no starting, but some preparing => preparing
    // Else unknown

Screen Shot

This introduce new statuses defined by Portainer. I think this can introduce some confusion for users, especially if they don't have access to the definition of these status (as stated in the PR).
Maybe we should introduce tooltips to explain what 'partially running' means for our users (should be done for all the statuses.
@ncresswell what do you think?

We can display in tooltip tasks detail (globalStatus object) like that :
preparing: 2
starting: 3
running: 1

explaining the "partially running"

I add tooltip for "partially running" :

I'll test it soon. Should https://github.com/portainer/portainer/issues/803 be fixed first tho?

@WTFKr0 mind fixing the conflict here? I'll give it a try this week.

Please wait, I have some changes to do regarding #806
This PR impact the RunningTask value, and i base status on that

I think we should rename "partially running" to "scaling" as that better reflects what is happening.

Remember, we do not use "hover over" for any function as we want native touch compatability.

I think we should rename "partially running" to "scaling" as that better reflects what is happening.

Not sure, there might be some errors on some nodes and thus the service would actually be 'partially' running.


iterator->_next_bitmap = &radiotap_header->it_present;

radiotap.c: In function ‘ieee80211_radiotap_iterator_init’:
radiotap.c:167:27: warning: taking address of packed member of ‘struct ieee80211_radiotap_header’ may result in an unaligned pointer value [-Waddress-of-packed-member]
167 |  iterator->_next_bitmap = &radiotap_header->it_present;
|                           ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
  this code is included in openwifi its give me above error
  radiotap.c: In function ‘ieee80211_radiotap_iterator_init’:

radiotap.c:167:27: warning: taking address of packed member of ‘struct ieee80211_radiotap_header’ may result in an unaligned pointer value [-Waddress-of-packed-member]
167 |  iterator->_next_bitmap = &radiotap_header->it_present;
|                           ^~~~~~~~~~~~~~~~~~~~~~~~~~~~

That kind of seems both correct and not - if the packet is aligned then the it_present will also aligned, but then we also don't need the packed attribute ...
Maybe remove that and see if it works that way?


Revert "nodejs_22: use shared SQLite"

This reverts commit 5ec3e7b30e2c2a60f3571b85392c2fc3dcda74a1.
Opening a PR targeting staging-next because of https://github.com/NixOS/nixpkgs/pull/361565#pullrequestreview-2512980694.

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Because of what?  nodejs_22 seems to build now on staging-next:
https://hydra.nixos.org/eval/1810541?filter=nodejs_22&compare=trunk
(and this PR is marked as quite a big rebuild)

My bad, I misinterpreted the linked comment, I thought it was saying it wasn't building without it

OK.  Good to clear that up 🙂


fix(plugins): traefik configuration parsing

Closes #304

Although now POST requests can be cached, I noticed that sending a POST request with a body leads to an error 500 using a whoami test setup.

I noticed that sending a POST request with a body leads to an error 500 using a whoami test setup.

Does the 500 HTTP response code comes from the whoami service or Souin itself?

Does the 500 HTTP response code comes from the whoami service or Souin itself?

I am not so sure, I think it comes from Souin although there is no error message in the logs.
This is my test setup:
version: "3.8"
services:
  traefik:
    image: traefik:v2.7.0
    command:
      - --providers.docker=true
      - --entrypoints.web.address=:80
      - --experimental.localPlugins.souin.moduleName=github.com/darkweak/souin
    ports:
      - 80:80
    networks:
      - default
    volumes:
      - ./souin:/plugins-local/src/github.com/darkweak/souin
      - /var/run/docker.sock:/var/run/docker.sock:ro

  whoami:
    image: traefik/whoami:latest
    labels:
      - traefik.enable=true
      - traefik.http.routers.whoami.rule=Host(`localhost`)
      - traefik.http.routers.whoami.entrypoints=web
      - traefik.http.middlewares.http-cache.plugin.souin.api.souin
      - traefik.http.middlewares.http-cache.plugin.souin.default_cache.ttl=10s
      - traefik.http.middlewares.http-cache.plugin.souin.default_cache.allowed_http_verbs=POST,GET,HEAD
      - traefik.http.middlewares.http-cache.plugin.souin.log_level=debug
      - traefik.http.routers.whoami.middlewares=http-cache

curl -X POST -i http://localhost -H "Content-Type: application/json" -d '{"test": 1}'
Returns:
HTTP/1.1 500 Internal Server Error
Cache-Status: Souin; fwd=uri-miss; key=POST-localhost-/-459abcffc7b40c78ff8941f8c6139ae4208247022299bd8f13dad5f40efdb567; detail=NOT-CACHEABLE
Date: Fri, 10 Feb 2023 20:36:23 GMT
Content-Length: 21
Content-Type: text/plain; charset=utf-8

Internal Server Error⏎

In the traefik logs I can only find this:
 level=debug msg="'500 Internal Server Error' caused by: net/http: HTTP/1.x transport connection broken: http: ContentLength=11 with Body length 0"
However, sending the same curl request to whoami without Souin as middleware returns this:
Content-Length: 403
Content-Type: text/plain; charset=utf-8
Date: Fri, 10 Feb 2023 20:44:29 GMT

Hostname: 36772703e6b3
IP: <IP_ADDRESS>
IP: <IP_ADDRESS>
RemoteAddr: <IP_ADDRESS>:38002
POST / HTTP/1.1
Host: localhost
User-Agent: curl/7.85.0
Content-Length: 11
Accept: */*
Accept-Encoding: gzip
Content-Type: application/json
X-Forwarded-For: <IP_ADDRESS>
X-Forwarded-Host: localhost
X-Forwarded-Port: 80
X-Forwarded-Proto: http
X-Forwarded-Server: f83398e7cec5
X-Real-Ip: <IP_ADDRESS>

{"test": 1}⏎

Any idea?

I dunno why that behavior happens. I'll have a look at that once I finish my work on the middleware refactoring (FYI https://github.com/darkweak/souin/compare/master...feat/chore/refactoring-to-middleware-philosophy).
IMHO we can merge your PR. Great job @jonasengelmann 👍

Thank you for your contribution @jonasengelmann 🚀


WFCORE-4502 Unify line-endings of bat scripts (regression against WF15)

Jira
https://issues.jboss.org/browse/WFCORE-4502

One thing to note is if want the current files to all be CRLF we're going to have to manually change the files first. Just some kind of change to trigger git to change the line endings.

@jamezp The assumption is that the release build script performs a clean checkout every time thus this ensures files are CRLF on checkout.
It does not matter what they are in the source tree. But yes, that can be done too, but its not necessary.

What do you mean by "clean checkout"? I know for sure when I do a release it's just based on master. I definitely don't re-checkout the project.

@jamezp The maven release plugin does this for you automatically in release:perform goal. It downloads the tag you have just tagged from SCM in the release:prepare goal. Thus, when ti does the checkout, it will checkout those files according to .gitattributes file, which will set CRLF line endings regardless of the OS you are running for the release.
*well, unless somebody sets use localCheckout to true :-) https://maven.apache.org/plugins-archives/maven-release-plugin-2.3.2/perform-mojo.html#localCheckout

Ah well as far as I know none of us that do releases use the release plugin :). I know for sure I don't. I don't think we should block this PR based on this BTW. I do think it's a good thing to have configured.

@jamezp That's a bit surprising to me. What do you use to release then?

Just manually commit it. This is basically the release process https://developer.jboss.org/wiki/WildFlyCoreReleaseProcess.

@jamezp Ouch. In that case I would change the files in the source tree as well... I will update tomorrow.

@jamezp I have updated the PR to change the files that are supposed to use CRLF line endings in the source tree as well as .gitattributes. These need to be separate commits (since if they were a single commit, git looks at the attributes and automatically fixes line endings thus won't commit the files into the source tree).
Note that this is not only about scripts that we package but also about scripts that are not-packaged, e.g. mvn wrapper for windows. Currently this is extremely messy, for instance if you look at mvnw.cmd:
[rhusar@ribera wildfly-core]$ file mvnw.cmd
mvnw.cmd: DOS batch file text, ASCII text, with CRLF, LF line terminators

it mixes both CRLF and LF line terminators. This should resolve all these problems.

@jamezp I think you had the most comments on this one - are your concerns now resolved?  If so I will bundle this with the PRs I am about to push through CI to merge.

@darranl I'm fairly indifferent about it, but I don't think it hurts anything. It won't fix the issue for anyone that has the project already checked out without doing something like find feature-pack/src -name "*.bat" | xargs -I {} git reset-file "{}". However for any new checkouts or changes to the file that require a local update it should fix those.


Getting assertion error for while training

def mel_spectrogram(self, y):
assert(torch.min(y.data) >= -1) # Getting value of tensor(-34834.9805)
assert(torch.max(y.data) <= 1)
I am getting assertion error in the above function in commons.py during training. Is this a issue due to incorrect training data and how to handle the issue? Any tips?

The issue is unrelated to the package. The problem was with few of the audio files as the bit rate was different.


refactor: added leak canary and optimize gradle

Fixes #289
Changes:

Added Leak Canary Library
Optimize gradle file

Screenshots for the change:

@yashk2000 Please Review


Remove USE_GO_VERSION_FROM_WEBSITE flag from dockerfile

This PR removes the USE_GO_VERSION_FROM_WEBSITE flag from the dockerfile. We don't need two different ways of installing golang.

We should not use go from website in our builds. It's OK to use it for tests though.

We should not use go from website in our builds. It's OK to use it for tests though.

Yes agreed. We will fix that separately. The intent of this PR is to get rid of the flag in dockerfile.

Apart from the above concern for why we added the flag initially, I would like to keep it because we never know what bits will be there that need testing only in a special case, that's why the flag was explicitly kept so generic.

@kwk +1
This is exactly why we still keep this flag in our Platform/core repos even if they are not currently used. We might want to use them later to test different versions of go.

@alexeykazakov @kwk some background: https://github.com/openshiftio/openshift.io/issues/4631#issuecomment-446450573
Btw, we haven't decided on removing this yet - we are experimenting.

@kwk @alexeykazakov We decided (see https://chat.openshift.io/developers/pl/d9m8pheuhpywzpyo5qd91nuf7h)  to remove the flag because we have two builds

https://ci.centos.org/view/Devtools/job/devtools-fabric8-wit-build-master/612/consoleFull and
https://ci.centos.org/view/Devtools/job/devtools-fabric8-wit-build-master/614/consoleFull

both of them are using different versions of golang.
Interestingly, if you look at all the builds before build 612, we were installing golang 1.10 (via the website) but golang 1.9.4 was being used to build/test (Search for INFO: go in any build before 614)

@jarifibrahim please confirm that we have a version of Go available in CentOS that supports the go test cache. Otherwise our coverage builds will be much slower if we remove that flag now.

@kwk This PR changes nothing. We have been installing golang from the website all this time and after the flag is removed we will still be installing golang from the website. I have only removed the flag. Everything else remains the same.

Apart from the above concern for why we added the flag initially, I would like to keep it because we never know what bits will be there that need testing only in a special case, that's why the flag was explicitly kept so generic. Just because we might no longer need it now, I would still like to keep the flag so we can have a smooth transitions to Go modules

@kwk the flag isn't adding any value right now. Removing it would mean we don't have any confusion about where/what version of golang is being installed. If we need to use a different version of golang, we could change it. It won't be that

[test]

Interestingly, if you look at all the builds before build 612, we were installing golang 1.10 (via the website) but golang 1.9.4 was being used to build/test (Search for INFO: go in any build before 614)

Yes, you always installing golang 1.10 from website (due to bug in docke builder file) but when golang was available in centos (it was when 612 was built) it was installed first and you ended up having two go binaries in PATH. But go 1.9 was first so it was used.
By the time 614 was built golang package had been removed from centos. So, only go from website (1.10) was installed. This is why you see go 1.10 in 614.

Yes, you always install golang 1.10 from website (due to bug in docke builder file) but when golang was available in centos (it was when 612 was built) it was installed first and you ended up having two go binaries in PATH. But go 1.9 was first so it was used.

So the installation of both, go 1.10 and go 1.9 in the builder container was intentional? I thought we were installing only one of those.

So the installation of both, go 1.10 and go 1.9 in the builder container was intentional? I thought we were installing only one of those.

No, it was not intentional. It's a bug. Incorrect usage of test -z/n in Dockerfile.builder
test -z/n just checks if the env var is an empty string or not. So setting it to 0 or 1 is the same thing. It will always trigger installation from website.
Look at https://github.com/fabric8-services/fabric8-cluster/pull/47 for example as an option for fixing that.

Look at fabric8-services/fabric8-cluster#47 for example as an option for fixing that.

@alexeykazakov thanks for pointing to that PR. @jarifibrahim can you make a fix according to that one instead?


feat (ndm-operator) Allow claim sparse device

Pull Request template
Why is this PR required? What issue does it fix?:
There is currently no way to get a sparse Device
What this PR does?:
Combined with https://github.com/openebs/dynamic-localpv-provisioner/pull/145. It provides a way to get the device sparse by specifying the DeviceType explicitly
Does this PR require any upgrade changes?:
No
If the changes in this PR are manually verified, list down the scenarios covered::

Create a BlockDeviceClaim with the DeviceType specified as sparse. Make sure the status is Bound

Any additional information for your reviewer? :
Mention if this PR is part of any design or a continuation of previous PRs
Checklist:

[ ] Fixes #
[x] PR Title follows the convention of  <type>(<scope>): <subject>
[ ] Has the change log section been updated?
[ ] Commit has unit tests
[ ] Commit has integration tests
[ ] (Optional) Are upgrade changes included in this PR? If not, mention the issue/PR to track:
[ ] (Optional) If documentation changes are required, which issue on https://github.com/openebs/openebs-docs is used to track them:

PLEASE REMOVE BELOW INFORMATION BEFORE SUBMITTING
The PR title message must follow convention:
<type>(<scope>): <subject>.
Where:
Most common types are:
* feat        - for new features, not a new feature for build script
* fix         - for bug fixes or improvements, not a fix for build script
* chore       - changes not related to production code
* docs        - changes related to documentation
* style       - formatting, missing semi colons, linting fix etc; no significant production code changes
* test        - adding missing tests, refactoring tests; no production code change
* refactor    - refactoring production code, eg. renaming a variable or function name, there should not be any significant production code changes
* cherry-pick - if PR is merged in develop branch and raised to release branch(like v0.4.x)
IMPORTANT: Please review the CONTRIBUTING.md file for detailed contributing guidelines.

Codecov Report

Merging #679 (128de36) into develop (6863cc2) will increase coverage by 0.31%.
The diff coverage is 0.00%.

:exclamation: Current head 128de36 differs from pull request most recent head a02ddc6. Consider uploading reports for the commit a02ddc6 to get more accurate results

@@             Coverage Diff             @@
##           develop     #679      +/-   ##
===========================================
+ Coverage    45.01%   45.32%   +0.31%
===========================================
  Files           79       79
  Lines         3992     3993       +1
===========================================
+ Hits          1797     1810      +13
+ Misses        2028     2014      -14
- Partials       167      169       +2

Impacted Files
Coverage Δ

pkg/select/blockdevice/select.go
0.00% <0.00%> (ø)

cmd/ndm_daemonset/probe/udevprobe.go
50.00% <0.00%> (+1.55%)
:arrow_up:

cmd/ndm_daemonset/probe/addhandler.go
70.91% <0.00%> (+2.94%)
:arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


Support configuring number of replicas of Envoy Proxy

Currently EG deploys only a single instance of Envoy Proxy. For scaling to high number of requests it will be useful to be able to increase number of replicas of Envoy Proxy to distribute load. It can be used for the following scenario -

Deploy EG with one replica of Envoy Proxy
As the traffic increases, metrics report high CPU usage of Envoy Proxy pod
Increase the number of replicas of Envoy Proxy to distribute the load and reduce CPU usage per pod

This property can be exposed through Envoy Proxy Config API - #703

@gitanuj tya is for creating the issue. Are you willing to work on a PR to fix this issue? If so, I would be happy to help provide guidance.

@danehans It'll be great if you can give me some pointers to get started on this and I can work on it sometime next week. Would love for this to be included in the next release.

Since the EnvoyProxy API is currently unimplemented, fixing this issue will require more work than what will be needed in the future.
Implementation Tasks

[ ] Review the config API dev guide for background on the Envoy Gateway data plane API, e.g. EnvoyProxy.
[ ] Update the EnvoyProxySpec API to define the schema for managing the Envoy deployment, e.g. the number of replicas. Avoid any Kube-isms as we intend for Envoy Gateway to support managing Envoy in non-Kube environments. Use kubebuilder validation markers as needed. After your changes are complete, generate the DeepCopy methods make generate.
[ ] Update ProviderResources to include EnvoyProxy. The field should follow the pattern of existing namespaced name fields, e.g. EnvoyProxies watchable.Map[types.NamespacedName, *v1a1.EnvoyProxy]. Update the Envoy Gateway server command to close the EnvoyProxies channel upon shutdown.
[ ] Infra IR- Update the ProxyInfra methods to include EnvoyProxy. Note that the infra IR already supports EnvoyProxy.
[ ] Update the resource translator- EnvoyProxy should be added to the Resources type. The Translate() method should be updated to include the EnvoyProxy in the infra IR (if one exists). Update the runner to subscribe to the EnvoyProxies channel.
[ ] Update the gatewayclass controller of the Kube provider to check if the accepted GatewayClass references an EnvoyProxy. If the reference is invalid, have the statusUpdater update the GatewayClass status with the InvalidParamters condition. If the reference is valid, get and store the EnvoyProxy in the resource map. Delete the EnvoyProxy from the resource map when the GatewayClass is deleted. Create a watch for EnvoyProxy and update the GatewayClass status and the resource map accordingly. You can reference the gateway controller for watches examples. Note that https://github.com/envoyproxy/gateway/pull/702 is consolidating the controllers into a single reconciler.
[ ] Implement the EnvoyProxy API changes in the Kube infra manager.

Notes:

Tasks should be implemented as separate PRs.
Includes tests for added functionality.
Make sure all tests pass before pushing a PR. See the dev guide for details.

@arkodg @skriss @AliceProxy @Xunzhuo feel free to provide any additional guidance.

@arkodg thanks for sharing the Istio reference. If we take the KubernetesResourcesSpec approach, EnvoyProxy will need a higher-level abstraction similar to provider in EnvoyGateway to wrap the Kube-isms. For example:
apiVersion: config.gateway.envoyproxy.io/v1alpha1
kind: EnvoyProxy
metadata:
  name: envoyproxy-sample
spec:
  provider:
    type: Kubernetes
    kubernetes:
      replicasCount: 2
...

The KubernetesResourcesSpec approach provides a high level of configurability. However, it also provides a higher support burden and potential UX issues over a more fine-grained API surface.

yah @danehans above approach looks good
reg level of customizations, imho EG should provide the subset of deployment & service kubernetes customizations to allow the user to run EG in production, and it will have to be via such a config API because Envoy proxy is being deployed programmatically


Bug Report: Spooky Month (Pump and Skid) idle animations not working properly

(NOTE: I'm pretty new to modding FNF. I understand some of the code but not much) I installed Kade Engine yesterday and tried testing some of the songs. When I got to Spookeez, I noticed that Skid and Pump's animation sequence was not working properly once the song started playing (before the game said GO!. Note, Skid and Pump's idle animation seems to work fine before this point). After the game/song officially starts, Pump and Skid get stuck in a loop that only shows them dancing to the right (think the normal Pump and Skid idle animation but only the half when they look to the right). Sometimes this changes after they sing a section, but Pump and Skid still get stuck executing either their right or left animation in a loop until they move onto the next section of the song.  I tried looking in the code and implemented different things including an integer counting system and editing things in the playAnim and dance functions to no avail. I tried redownloading the Kade-Engine source code and still had the same issue. Looking at the code, I know that Skid and Pump's idle animation works the same way that gf's does (if you've already danced movement, more to the next one (left and right)). However, gf doesn't seem to be having any problem with her idle animation like Skid and Pump are. Any ideas?
Extra details:
Operating System: Windows 10 (64 bit, 86x)
Kade-Engine Version:  1.4.2
Development: Desktop
Code Editor: Visual Studio Code 2019 (installed via the specifications found in building.md)
Code Compiler: Windows Powershell

Duplicate of #319 or #495 or both I don't know???????? starts crying


Use try-with-resources with MockLogAppender

I previously added a helper that started a MockLogAppender to ensure it
was never added to a Logger before it was started. I subsequently found
the opposite case in RolloverIT.java where the appender was stopped
before it was closed, therefore creating a race where a concurrently
running test in the same JVM could cause a logging failure. This seems
like a really easy mistake to make when writing a test or introduce when
refactoring a test. I've made a change to use try-with-resources to
ensure that proper setup and teardown is done. This should make it much
harder to introduce this particular test bug in the future.
Unfortunately, it did involve touching a lot of files. The changes here
are purely structural to leverage try-with-resources; no testing logic
has been changed.
Description
Fixes a potential race conditions in tests that lead to intermittent failures
Issues Resolved
None
Check List

[x] New functionality includes testing.

[x] All tests pass

[x] New functionality has been documented.

[x] New functionality has javadoc added

[x] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

start gradle check

Test failed with a pretty generic timeout and cannot be reproduced:
REPRODUCE WITH: ./gradlew ':server:internalClusterTest' --tests "org.opensearch.search.geo.GeoShapeIntegrationIT.testOrientationPersistence" -Dtests.seed=3547E4E7785AD6D0 -Dtests.security.manager=true -Dtests.jvm.argline="-XX:TieredStopAtLevel=1 -XX:ReservedCodeCacheSize=64m" -Dtests.locale=en-ZA -Dtests.timezone=SystemV/CST6CDT -Druntime.java=17

org.opensearch.search.geo.GeoShapeIntegrationIT > testOrientationPersistence FAILED
    java.lang.AssertionError: timed out waiting for green state
        at __randomizedtesting.SeedInfo.seed([3547E4E7785AD6D0:6498346FC69C3338]:0)
        at org.junit.Assert.fail(Assert.java:88)
        at org.opensearch.test.OpenSearchIntegTestCase.ensureColor(OpenSearchIntegTestCase.java:1019)
        at org.opensearch.test.OpenSearchIntegTestCase.ensureGreen(OpenSearchIntegTestCase.java:958)
        at org.opensearch.test.OpenSearchIntegTestCase.ensureGreen(OpenSearchIntegTestCase.java:947)
        at org.opensearch.search.geo.GeoShapeIntegrationIT.testOrientationPersistence(GeoShapeIntegrationIT.java:111)

start gradle check


FeatureRequest: Add vec3 or vec4 mode for shader debugging.

Could you please add a new vec4 mode to facilitate the shader debugging?
This mode will map 0,255 to 0,1.
For example:
rgb(0, 127, 255) to vec4(0, .5, 1, 1)
rgb(100, 50, 75) to vec4(0.392, 0.196, .294, 1)

Will do, thanks for a suggestion


Sanitize environment for XCBuild

We need to sanitize DYLD_LIBRARY_PATH in the environment before launching XCBuild because otherwise just built dependencies of SwiftPM can interfere with the linked dependencies of XCBuild which will typically not end well. This can e.g. happen during bootstrap builds.

@swift-ci please smoke test

@swift-ci please smoke test


Swift 4 compatibility

Added this to my project via Cocoapods; trying to build my app using Xcode 9.0 (9B55) / Swift 4 and several compiler errors have popped up, most of which represent Swift 4 incompatibilities.
/Users/nickgaens/.../Pods/FontAwesome.swift/FontAwesome/FontAwesome.swift:108:13: 'NSBackgroundColorAttributeName' has been renamed to 'NSAttributedStringKey.backgroundColor'
/Users/nickgaens/.../Pods/UIKit.NSBackgroundColorAttributeName:3:12: 'NSBackgroundColorAttributeName' was obsoleted in Swift 3

There are some other compiler errors as well:
/Users/nickgaens/.../Pods/FontAwesome.swift/FontAwesome/FontAwesomeBarButtonItem.swift:48:36: Cannot convert value of type '[String : Any]' to expected argument type '[NSAttributedStringKey : Any]?'
and
/Users/nickgaens/.../Pods/FontAwesome.swift/FontAwesome/FontAwesome.swift:155:47: Value of optional type 'CGFont?' not unwrapped; did you mean to use '!' or '?'?

Hmmm, I took a second look at the installed pod and it seems v1.2.0 has been installed.

Apologies, my 'local specs repositories' were outdated. After having run pod update, the installed pod got updated from v1.2.0 to v1.3.1 after which the compiler issues disappeared.


Updates for thin collection controller

This is required for https://github.com/Islandora-CLAW/CLAW/pull/160
Subsumes #36

Yeah, 0.0.3. Looks fine :+1: do you want me to merge?

I need a packagist version with the UuidGenerator for the vagrant I am working on. Can somebody have a look at this and if it's good merge it and cut a 0.0.3 version?

@whikloj Merged.@ruebot good to go for a new release :+1:


Typo in notebook?

Hi,
Thanks for this repository. I tried to run it but I am getting an issue at:
https://github.com/masakhane-io/masakhane/blob/4388d4e484c82bc199c3e3e10c1ea7fdb428bc95/starter_notebook.ipynb#L304
I don't know what 'fr_test_sents' is, is this maybe a typo?

I think this is an error that was introduced with this commit:https://github.com/masakhane-io/masakhane/commit/ce10b1aabbd2d04f6bf2924d441f85e272d9bf79#diff-dcf4d137651c3c758c827e175f8522c5  for this PR: https://github.com/masakhane-io/masakhane/pull/57 @jaderabbit @juliakreutzer
I would say go to an earlier version of the repo before this commit and checkout that. Cheers.

Yes! Thanks for spotting it. Please replace with "en_test_sents". This is an artifact from building a new test set for French. I'll fix it.


Make it in REST

If creepJS can also be on a REST API it will be awesome to let other user it.

What did you have in mind? A fingerprinting API service is not among the goals of this project.


Update sample code in README.md

The example was old and didn't compile when WaitAsyncOperation changed
to WaitForOperation in commit #2b1a360.

Hi @mvanotti, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. Real humans will now evaluate your PR.

TTYL, MSBOT;


Fix #2032, Add CFE_ES_AppInfo_t element documentation

Describe the contribution

Fix #2032

Testing performed
Documentation only/CI
Expected behavior changes
None
System(s) tested on

Hardware: CI only
OS: Ubuntu 18.04
Versions: Bundle main + this commit

Additional context
None
Third party code
None
Contributor Info - All information REQUIRED for consideration of pull request
Jacob Hageman - NASA/GSFC

CCB:2022-01-27 APPROVED

Reverted in #2037


Setup cluster for connectivity investigation

In regards to the unreachable nodes that we have in our network, we will be trying out a new transport layer in libp2p called QUIC. We have observed that these nodes are in China, so we suspect that the reason behind these connectivity issues is the GFW.
In order to make sure that this is the case, we will need a private testnet cluster. In this we need to setup a new network with nodes running both in china and EU, in order to see how the network behaves.

for issues regarding internal testing, let's utilize https://github.com/ethersphere/bee-backlog/issues repo instead @nikipapadatou

Closing this because of legal and compliance reasons.


Deployment package size

Hi,
Im using SAM with go.  My template contains multiple lambdas and each refers to their own binary in the code uri.  It seems each lambda functions indiviudal package contains ALL the binarys and is thus quite large and bloated with the other unused ones.
Is there a way to control this?  Serverless framework gives us options but cant see any for SAM.
Thanks

This is an issue with AWS CLI. Please check for or open an issue there https://github.com/aws/aws-cli/


Create footer of the page

Highlights

Create footer of the page
Use minimal styling to match the wire frame

Please, where are my to put this?

Created by Mark, Kola and Uthman under MIT license.

@banzaman

footer


PSMDB-990 Release notes 4.0.28-23

Updated copyright year
modified:   source/conf.py
modified:   source/copyright.rst
modified:   source/release_notes/index.rst
new file: source/release_notes/4.0.28-13.rst

Updated following Kimberly's comments


play: fix base64 responses

Chrome devtools generates HAR files with some response bodies in base64, which harproxyserver currently serves to the client verbatim. This patch fixes that by checking the .content.encoding and decoding if necessary.
Example: book.servo.org.har.zip

:green_heart: Thanks

can you fix the linter errors ?
npx eslint --ext .ts src --fix


ENH: vectorize cramervonmises_2samp

@mdhaber: A improvment of cramer von mises test with vectorization. I think of this vectorization when I was reviewing your PR. This code depends on _all_partitions, therefore I submit a PR to your branch. I can wait the merge to scipy/master and propose a PR on scipy if you prefer (and in this case, please close this PR).
Before vectorization:
In [1]: import numpy as np
   ...: import scipy.stats as stats
   ...: np.random.seed(0)
   ...: a = np.random.uniform(size=10)
   ...: b = np.random.uniform(size=11)

In [2]: stats.cramervonmises_2samp(a, b, method='exact')
Out[2]: CramerVonMisesResult(statistic=0.12236652236652246, pvalue=0.5228767620408488)

In [3]: %timeit stats.cramervonmises_2samp(a, b, method='exact')
4.79 s ± 88.4 ms per loop (mean ± std. dev. of 7 runs, 1 loop each)

After vectorization:
In [1]: import numpy as np
   ...: import scipy.stats as stats
   ...: np.random.seed(0)
   ...: a = np.random.uniform(size=10)
   ...: b = np.random.uniform(size=11)

In [2]: stats.cramervonmises_2samp(a, b, method='exact')
Out[2]: CramerVonMisesResult(statistic=0.12236652236652246, pvalue=0.5228767620408488)

In [3]: %timeit stats.cramervonmises_2samp(a, b, method='exact')
1.67 s ± 25 ms per loop (mean ± std. dev. of 7 runs, 1 loop each)

With this improvment, maybe the threshold (now it is 10, for the sum between nx and ny) for switching from exact mode to asymptotic mode for method="auto" can be adapted.

I think it's a good idea. If we were to go this route, I would consider changing _all_partitions from a generator function to a function that returns a 2D array containing all the partitions in one shot.
(The only reason I made it a generator function in gh-13661 is because cramervonmises_2samp wasn't vectorized, and I didn't want to mess with that at the time.)
On the other hand, since it's just based on ranks, I think there are much more efficient methods for calculating the exact distribution of the statistic under the null hypothesis (e.g. using recursion), if you're interested. If you go that route, I'd recommend implementing the distribution in a class.
gh-12531 shows a non-vectorized example. See _PageL.
gh-4933 is vectorized as best as I could. See _MWU.
Thanks for thinking of this!

I think it's a good idea. If we were to go this route, I would consider changing _all_partitions from a generator function to a function that returns a 2D array containing all the partitions in one shot. That would encourage future tests to vectorize these sorts of computations, too.

In fact, generating a array with pythran can be very efficient, without a huge cost.
Let see:

meth1.py which is basically what we are doing now,
meth2.py is pure-python (but pythran compatible code) not compiled with pythran
meth3.py is just a symlink to meth2.py but compiled with pythran.

In [1]: import meth1, meth2, meth3

In [2]: m1 = meth1.get_indices_permutation_test(21, 10)
   ...: m2 = meth2.get_indices_permutation_test(21, 10)
   ...: m3 = meth3.get_indices_permutation_test(21, 10)

In [3]: (m1==m2).all()
Out[3]: True

In [4]: (m1==m3).all()
Out[4]: True

In [5]: %timeit meth1.get_indices_permutation_test(21, 10)
4.39 s ± 89 ms per loop (mean ± std. dev. of 7 runs, 1 loop each)

In [6]: %timeit meth2.get_indices_permutation_test(21, 10)
2.66 s ± 32.9 ms per loop (mean ± std. dev. of 7 runs, 1 loop each)

In [7]: %timeit meth3.get_indices_permutation_test(21, 10)
47.5 ms ± 503 µs per loop (mean ± std. dev. of 7 runs, 10 loops each)

It is quick a dirty experiment. If it is good for you, I will do the same for permutation (for the random samples where the performed test is not exact).

On the other hand, since it's just based on ranks, I think there are much more efficient methods for calculating the exact distribution of the statistic under the null hypothesis (e.g. using recursion),

I don't know if we have recursion formula for this distribution. Do you have some results for this?

Looks like there is some information about generating the CVM distribution efficiently here.


Feature request: Lead times for each product

Can we have a feature implemented where we can input lead times for specific products? thanks

Please make all feature requests in Miscellaneous > Feature Requests 😉


Bug on upvotes

I spam clicked the upvote button, this is what I got:

Then I get a 502:

Josh Owens fixed it ;)


Updating multiple VNF Packages may generate multiple image uploads

When you upload multiple packages, which all may refer to the same image, the NFVO will trigger multiple image uploads, although a single image upload may be sufficient.

should the VNFPackage onboard be sequential then?

I think the first VNF Package upload should trigger the image upload process, and the following should verify whether the image already exists (meaning is being downloaded) or not. I think the image state introduced by @mpauls could be useful for this scenario.

The image status was done by @radoslavvlaskovski and i think he told me that this issue was fixed, better a confirmation from him before closing

The image-status branch contains the changes, but the fix required also changes on the model, but I think the image-status branch on openbaton-libs is still not merged.

@zohaibhassan122 I need to know where are the changes in the dashboard for this. i must be included in rel4

@lorenzotomasini I have these changes in my local version in my computer, I asked @radoslavvlaskovski  even two days ago, because first he has to push changes and then I should push my changes to develop branch, I can come tomorrow for short time at  15:00 and push the changes to develop. Just send me a message on slack.


Introduce cross-compiled releases

This is a build + release pipeline based off of the amazing ripgrep project's workflow.
Closes https://github.com/helsing-ai/buffrs/issues/175.

@mara-schulke Did you have some specific compilation targets in mind?

I think it's done. I just don't know how to test without actually doing a release, we might have to do a test one and then quickly delete it afterwards.

@tomkarw lets chat tomorrow!

@mara-schulke Link to the results: https://github.com/helsing-ai/buffrs/releases/tag/untagged-f90bff9935014a85fc00


New eas.json configuration step in eas update ignores inheritance

Build/Submit details page URL
No response
Summary
Hello,
Im running into an issue with eas-cli since v3.1.0 with the new feature found in PR #1570
I use EAS to build a branded app for our clients, and this means that i have a ton of different EAS build profiles in eas.json.
To reduce boilerplate all my client production profiles they inherit from a main production profile, that has channel: production.
This setup has worked great for hundreds of updates, but was broken by 3.1.0 since eas update now tries to automatically create channels for the client production profiles.
See reproducible demo.
Seems like a great feature in general though  🙌
Managed or bare?
Managed
Environment
expo-env-info 1.0.5 environment info:
    System:
      OS: macOS 13.0.1
      Shell: 5.8.1 - /bin/zsh
    Binaries:
      Node: 16.15.0 - ~/.nvm/versions/node/v16.15.0/bin/node
      Yarn: 3.2.0 - ~/.nvm/versions/node/v16.15.0/bin/yarn
      npm: 8.5.5 - ~/.nvm/versions/node/v16.15.0/bin/npm
    Managers:
      CocoaPods: 1.11.2 - /usr/local/bin/pod
    SDKs:
      iOS SDK:
        Platforms: DriverKit 22.2, iOS 16.2, macOS 13.1, tvOS 16.1, watchOS 9.1
    IDEs:
      Android Studio: 2021.3 AI-213.7172.25.2113.9123335
      Xcode: 14.2/14C18 - /usr/bin/xcodebuild
    npmPackages:
      expo: ~47.0.9 => 47.0.9
      react: 18.1.0 => 18.1.0
      react-dom: 18.1.0 => 18.1.0
      react-native: 0.70.5 => 0.70.5
      react-native-web: ~0.18.7 => 0.18.9
    npmGlobalPackages:
      eas-cli: 3.1.1
      expo-cli: 6.0.8
    Expo Workflow: manag

Expo doctor:
Some dependencies are incompatible with the installed expo package version:
 - @sentry/react-native - expected version: 4.9.0 - actual version installed: 4.2.2
 - expo-linking - expected version: ~3.3.0 - actual version installed: 3.2.3
 - sentry-expo - expected version: ~6.0.0 - actual version installed: 5.0.3

Error output
No response
Reproducible demo or steps to reproduce from a blank project
eas.json before running eas update (simplified):
{
  "cli": {
    "version": ">= 1.1.1"
  },
  "build": {
    "development": {
      "distribution": "internal",
      "android": {
        "gradleCommand": ":app:assembleDebug"
      },
      "ios": {
        "buildConfiguration": "Debug"
      },
      "channel": "development"
    },
    "preview": {
      "distribution": "internal",
      "channel": "preview"
    },
    "production": {
      "channel": "production"
    },
    "clientOneProduction": {
      "extends": "production",
      "env": {
        "VARIANT": "clientOne"
      }
    },
    "clientTwoProduction": {
      "extends": "production",
      "env": {
        "VARIANT": "clientTwo"
      }
    },
  },
  "submit": {
    "production": {}
  }
}

after running eas update
{
  "cli": {
    "version": ">= 1.1.1"
  },
  "build": {
    "development": {
      "distribution": "internal",
      "android": {
        "gradleCommand": ":app:assembleDebug"
      },
      "ios": {
        "buildConfiguration": "Debug"
      },
      "channel": "development"
    },
    "preview": {
      "distribution": "internal",
      "channel": "preview"
    },
    "production": {
      "channel": "production"
    },
    "clientOneProduction": {
      "extends": "production",
      "env": {
        "VARIANT": "clientOne"
      },
      channel: "clientOneProduction"
    },
    "clientTwoProduction": {
      "extends": "production",
      "env": {
        "VARIANT": "clientTwo"
      },
      channel: "clientTwoProduction"
    },
  },
  "submit": {
    "production": {}
  }
}

With this error:
InvalidEasJsonError: eas.json is not valid.
    - "build.clientOneProduction.channel" with value "clientOneProduction" fails to match the required pattern: /^[a-z\d][a-z\d._-]*$/

Thanks for the bug report! I have a PR out that will fix this issue: https://github.com/expo/eas-cli/pull/1598
I am getting that wrapped up soon and will get it merged and released in an upcoming version of eas-cli.

Closing this because @jonsamp merged his PR.

Was this solved? i am running into
"Invalid eas.json.
GitHub integration requires the image option.
See https://docs.expo.dev/eas/json/#image to learn more."
I have even tried building my previous branches that worked with github building on the expo website... but now i receive the error specified above
Need this as this is how i build for android apps

@GeeGYMR
edith eas.json file inside "build" { ....}
replace
"production": {}

to
    "production": {
      "android": {
        "image": "latest"
      },
      "ios": {
        "image": "latest"
      }
    }

@GeeGYMR edith eas.json file inside "build" { ....}
replace
"production": {}

to
    "production": {
      "android": {
        "image": "latest"
      },
      "ios": {
        "image": "latest"
      }
    }

This is the answer as of July 2024.


React 17/18 Support

Hey, I was wondering if this component works with React 17/18 and if we could update the package.json to reflect that.

Hello, any movement on this? thanks 0_0
@dhalucario hey mate, did you get anywhere with React 17/18 and this package?

I don’t think this package is maintained anymore. Have a look at https://iframe-resizer.com/react


update home page content

updated the content on the home page to more accurately represent the goals of the project
added tailwind classes instead of using <br /> between paragraphs

@trvswgnr we can also use https://tailwindcss.com/docs/typography-plugin to avoid styling spaces and adding margins to add spaces between paragraphs, I might work on it just now.


Add CHIP-8 test suite to the list of testing tools

My "test suite" seems to be helping a lot of people who stumble upon it. So I figured it would be a shame not to mention it in this excellent list :) I was a bit unsure about where in the list to put it, hope this is the most logical order.

Thanks!


Support request: Implementing a VBA handler

I'm trying to build a VBA handler that uses Google-style Python-docstrings (since there is no real standard for documenting VBA functions). My very experimental and hacky code is at https://github.com/AutoActuary/mkdocstrings-vba .
Here is my problem: When I git clone that repo, and do pip install -e C:/path/to/mkdocstrings-vba, it works, but if I pip install C:/path/to/mkdocstrings-vba it will error out with ModuleNotFoundError: No module named 'mkdocstrings.handlers.vba'
requirements.txt:
mkdocs~=1.2
mkdocs-material~=8.1
mkdocstrings-vba==0.0.3
mkdocs-gen-files~=0.3.4
mkdocs-literate-nav~=0.4.1

mkdocs.yml
site_name: Autory documentation
docs_dir: src
site_dir: dist
site_url: ""
use_directory_urls: false
theme: material

plugins:
  - mkdocstrings:
      handlers:
        vba: { }
  - gen-files:
      scripts:
        - gen_pages.py
  - literate-nav:
      nav_file: nav.md

markdown_extensions:
  - def_list
  - toc:
      permalink: true

Hello @rudolfbyker! Nice seeing a new handler :smile:
It seems to work on my end:
% git clone https://github.com/AutoActuary/mkdocstrings-vba
Cloning into 'mkdocstrings-vba'...
remote: Enumerating objects: 152, done.
remote: Counting objects: 100% (152/152), done.
remote: Compressing objects: 100% (72/72), done.
remote: Total 152 (delta 53), reused 141 (delta 43), pack-reused 0
Receiving objects: 100% (152/152), 27.03 KiB | 1.00 MiB/s, done.
Resolving deltas: 100% (53/53), done.
% cd mkdocstrings-vba
% python -m venv .venv
% . .venv/bin/activate
% pip install .
Processing /media/data/dev/mkdocstrings-vba
  DEPRECATION: A future pip version will change local packages to be built in-place without first copying to a temporary directory. We recommend you use --use-feature=in-tree-build to test your packages with this new behavior before it becomes the default.
   pip 21.3 will remove support for this functionality. You can find discussion regarding this at https://github.com/pypa/pip/issues/7555.
Collecting [...]
Successfully installed Jinja2-3.0.3 Markdown-3.3.6 MarkupSafe-2.1.0 PyYAML-6.0 click-8.0.4 ghp-import-2.0.2 griffe-0.12.6 importlib-metadata-4.11.1 mergedeep-1.3.4 mkdocs-1.2.3 mkdocs-autorefs-0.3.1 mkdocs-material-8.2.1 mkdocs-material-extensions-1.0.3 mkdocstrings-0.18.0 mkdocstrings-python-0.6.3 mkdocstrings-python-legacy-0.2.2 mkdocstrings-vba-0.0.5.dev2+g308e28e packaging-21.3 pygments-2.11.2 pymdown-extensions-9.2 pyparsing-3.0.7 python-dateutil-2.8.2 pytkdocs-0.16.0 pyyaml-env-tag-0.1 six-1.16.0 watchdog-2.1.6 zipp-3.7.0
WARNING: You are using pip version 21.2.4; however, version 22.0.3 is available.
You should consider upgrading via the '/media/data/dev/mkdocstrings-vba/.venv/bin/python -m pip install --upgrade pip' command.
% python
Python 3.9.9 (main, Dec  8 2021, 13:28:51)
[GCC 11.1.0] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> from mkdocstrings_handlers import vba
>>> vba.__file__
'/media/data/dev/mkdocstrings-vba/mkdocstrings_handlers/vba/__init__.py'
>>> vba.__path__
['/media/data/dev/mkdocstrings-vba/mkdocstrings_handlers/vba']

I suspect there's something missing in your setup.py so that it can find namespace packages: https://packaging.python.org/en/latest/guides/packaging-namespace-packages/#native-namespace-packages

Confirmed, closing! Let me know if there's anything else!

Oh, by the way, if you'd like it and when you feel ready, we can reference your handler in mkdocstrings' docs, and even add the extra so users can depend on mkdocstrings[vba] :slightly_smiling_face: Just let me know :slightly_smiling_face:

I'll let you know. I first need to figure out a few things to get this stable. Most notably, I'm still trying to figure out how to use (or abuse?) griffe in such a way that I can pass the argument types to it, when the argument types are not given in the docstring, but rather in the VBA function signature, which I parse using regex.

I've documented a way here, maybe you didn't see it yet: https://mkdocstrings.github.io/griffe/usage/#using-griffe-as-a-docstring-parsing-library

I have not seen it yet. Thanks!!

Trying to implement this now according to https://mkdocstrings.github.io/griffe/usage/#using-griffe-as-a-docstring-parsing-library . I'm getting this error: https://github.com/mkdocstrings/griffe/issues/51
Also, another question: How can I get the path of the directory containing mkdocs.yml in my handler? The VBA code is loaded from text files with .bas extensions, and my identifiers are simply paths to those files, relative to the mkdocs.yml file. See https://github.com/AutoActuary/mkdocstrings-vba/blob/master/mkdocstrings_handlers/vba/handler.py#L71 and https://github.com/AutoActuary/mkdocstrings-vba/blob/7870c6f469a3568cf39da57c13c18330e6ca5c78/mkdocstrings_handlers/vba/collector.py#L44 .

@pawamoy any ideas? I'm still stuck with the above-mentioned comment, second paragraph.

Hello @rudolfbyker, sorry for the late answer, it seems I forgot to save the notification somehow.
The latest version of mkdocstrings passes the path of mkdocs.yml to the get_handler function of your package.
See how I use it in the Python handler here: https://github.com/mkdocstrings/python/blob/master/src/mkdocstrings_handlers/python/handler.py#L279

Sorry for my even later answer! I updated the mkdocstrings-vba repo today, and it seems to work fine for my purposes. Would you like to review the code?
Currently I'm publishing this on our company's private pypi for internal use, but if you think it's more broadly useful, we could:

publish it on the public pypi
transfer the repo to you (as long as I may keep the permissions to work on the repo)
something else?

I would love to hear your thoughts.

No worries!
That's great news :rocket:
I'd gladly accept transferring your handler to the mkdocstrings organization. You'll of course keep admin access on the repository (and will probably keep being the principal maintainer as I have no VBA experience or knowledge).
If you feel ready for it, we can even advertise the handler in mkdocstrings' docs and readme :slightly_smiling_face:
And if we do that, since you contributed a handler to mkdocstrings, I'd like to offer you access to my Insiders program :+1: Be it your own account, or a bot account from your company if you coded the handler on the company time. Let me know!

Sure, let's do this. Do I need permissions to create a repo in your organization before I can initiate the transfer?
Regarding the insiders program, that's a nice offer, but I'm not sure that we need those specific features at the moment. However, I will continue to develop mkdocstrings-vba on company time as features are need or bugs are discovered. We will continue to use VBA in some of our projects for the foreseeable future.

I think you don't need permission, you can simply initiate the transfer and I should get a notification to accept it.
OK, if you're interested in Insiders one day, let me know and I'll give you access :slightly_smiling_face:

https://docs.github.com/en/repositories/creating-and-managing-repositories/transferring-a-repository
🤔

OK, my bad! Will give you the necessary permissions :slightly_smiling_face:

I've invited you, and members can create public/private repos, so this should be good now.

I am honored. Feel free to rename the repo with/after the transfer.

Thanks, I'll probably rename it vba, to be consistent with python and crystal. This will also affect the URL at which the docs are served: https://mkdocstrings.github.io/vba.

Are you OK with an announcement in mkdocstrings repo telling about the transfer?

That's 100%. Let me know if I need to contribute anything specific.


RPC Tests ISSUE

Describe the bug
LibraryError: 53: Max fee is smaller than the minimal transaction cost (validation plus fee transfer)
https://github.com/starknet-io/starknet.js/actions/runs/6380876171/job/17316580419
To Reproduce
...
Expected behavior
Pass
Additional context
Find the Latest Pathfinder (or other stable) version of Testnet RPC Node and run the Test on it.

Resolved on Slack


Silently skipping compilation when inherited function from a separate file is not marked as virtual

Component
Forge
Have you ensured that all of these are up to date?

[X] Foundry
[X] Foundryup

What version of Foundry are you on?
forge 0.2.0 (34d2414 2022-05-16T12:30:23.0948462Z)
What command(s) is the bug in?
forge build
Operating System
Windows
Describe the bug
Given the following file that inadvertently skips the virtual keyword from the definition of f() in the Inheritee contract -
// SPDX-License-Identifier: UNLICENSED
pragma solidity ^0.8.13;

contract Inheritee {

    function f() external pure returns (uint) {
        return 1337;
    }

}

contract Inheritor is Inheritee {

    function f() external pure override returns (uint) {
        return 42;
    }

}

- if you run forge build on this, you correctly get the error:
 error[4334]: TypeError: Trying to override non-virtual function. Did you forget to add "virtual"?

However, if you place these two contracts into separate files (e.g. Inheritor.sol and Inheritee.sol), attempting to run forge build will elide this error, produce cache/solidity-files-cache.json and then conclude:
$ forge build
[⠊] Compiling...
[⠒] Compiling 2 files with 0.8.13
[⠢] Solc 0.8.13 finished in 8.11ms
No files changed, compilation skipped

forge build --force produces the same result.
I've added the two files (simple as they are) in a repro repo here.

your forge version looks severely outdated.
I wasn't able to reproduce this with the current version.
could you try again after running foundryup

Well, I feel silly given it used to be my job to catch people out on this exact thing - looks like my run of foundryup before filing this had failed on my Windows machine and I just blipped past it
Issue no longer reproducible - many thanks for the assist!


add functions for writing test_manifest

write test manifest by promoting ports into a top level component
add tutorial
generate new CSV that includes all port info (position, orientation, port_type)

@HelgeGehring
@simbilod
@lucasgrjn
@tvt173
@mustafacc
@JymBone5

tests are passing, i think this is ready to merge


Fix kv:key section in wrangler cli docs

The kv:key section in the wrangler cli documentation has the header indented incorrectly, which shows up in the sidebar toc.
Also, under the list subcommand, the comments incorrectly say "delete" where they mean "list".

Great catch. Thanks!

Looks like https://github.com/cloudflare/workers-docs-engine/commit/35f64f1a6c87e618bdec7a89de75a402f16d65c1 was the same.


Build for M1 Macs

Plugin fails to load on arm64 macOS due to no compatible binaries

Im going to need someone to try this out as I dont have an M1 Mac myself:

Download and install this file in VSCode: https://github.com/Strum355/mcshader-lsp/suites/4812214989/artifacts/135431046
Heres an instructional screenshot on how to do that:

In your settings (after installing the VSIX file and reloading VSCode), enable the "skip bootstrap" flag

Next, youre going to want to download and move a test build for aarch64-apple-darwin to the extension storage folder (example link: https://github.com/Strum355/mcshader-lsp/suites/4812214993/artifacts/135431741)
You can find where to put it by checking where the extension storage folder is on startup by opening a shader file. Make sure the file is called mcshader-lsp:

I'll probably change this sometime to take an arbitrary path to the binary instead of having to move it specifically to there /shrug

Reload VSCode and see what happens I guess? No idea if :heavy_check_mark: or :boom:

Still got errors, this is the output for Minecraft Shaders. If there are any other logs you want, let me know where they are.
INFO  [1/3/2022, 9:22:26 AM]: working with state { serverVersion: undefined }
INFO  [1/3/2022, 9:22:26 AM]: skipping language server bootstrap
INFO  [1/3/2022, 9:22:26 AM]: starting language server...
INFO  [1/3/2022, 9:22:26 AM]: server receiving events for file glob:
**/*.{.fsh,.vsh,.gsh,.glsl}
INFO  [1/3/2022, 9:22:26 AM]: running with binary at path:
/Users/alex/Library/Application Support/Code/User/globalStorage/strum355.vscode-mc-shader/mcshader-lsp

In the Output tab, are there logs for Minecraft Shaders Language Server? Should be a separate entry in the dropdown

here:
[Error - 2:03:54 PM] Starting client failed
Launching server using command /Users/alex/Library/Application Support/Code/User/globalStorage/strum355.vscode-mc-shader/mcshader-lsp failed.
that's all I'm afraid

Had someone else try it out and they had the same issue until they ran chmod +x on the binary, and then it should run 👍 lemme know how that goes and if theres any more issues further down the path

sweet yes it works, many thanks!

Id imagine linting doesn't work because its neither AMD nor Nvidia GPU, we have to have different codepaths for different vendors because the output format is completely different for each. Once it has the capability to log debug info we can try making it work for M1 there too


Support Python console script entry point

We could leverage rules_python information to extract the entry point, but maybe a bit hard to get started with this:
print(dist_info_requirement("black"))

# Could get the dist-info from black using dist_info_requirement("black")
# Get the entry_points.txt file from the dist-info file group
# Parse the entry_points.txt file to get the entry point for black and blackd


VOLANO benchmark

This PR adds support for the VOLANO Benchmark to benchkit.
A detailed tutorial on how to run it is added.
If there are questions please do not hesitate to contact me.

@matsvanmolle this PR contains a commit already included in #41 may I ask you to remove that commit from here? To avoid duplicate them.


Fix 5459

Short Description:
Change pokemon.name to candy.type
Fixes/Resolves/Closes (please use correct syntax):

Fix #5459

With the event text formatted like that.... does it still work in telegram?

@javajohnHub Oh okay, I didn't know that, I'll revert that then.

Thanks.

I was checking this out before merge and received this error:
Traceback (most recent call last):  File "pokecli.py", line 841, in <module>    main()  File "pokecli.py", line 200, in main    bot.tick()  File "C:\fresh\PokemonGo-Bot\pokemongo_bot\__init__.py", line 715, in tick    if worker.work() == WorkerResult.RUNNING:  File "C:\fresh\PokemonGo-Bot\pokemongo_bot\cell_workers\transfer_pokemon.py", line 30, in work    self._release_pokemon_worst_in_group(group, pokemon_name)  File "C:\fresh\PokemonGo-Bot\pokemongo_bot\cell_workers\transfer_pokemon.py", line 146, in _release_pokemon_worst_in_group    self.release_pokemon(pokemon)  File "C:\fresh\PokemonGo-Bot\pokemongo_bot\cell_workers\transfer_pokemon.py", line 254, in release_pokemon    candy.type) eyError: 'candy'
I changed starting at 28L and working now:
formatted="Exchanged {} (CP: {}, IV: {}, IVCP: {:.2f}) You now have"                       " {} {} candies".format(pokemon.name,                                               pokemon.cp,                                               pokemon.iv,                                               pokemon.ivcp,                                               candy.quantity,                                               candy.type)

@crvfts Oh yeah, forgot to remove that when reverting. Thanks!


📖 Update documentation for release v1alpha3

What this PR does / why we need it:
This PR does documentation update related to releasing v1alpha3

/test-integration

/retest

/cc @fmuyassarov
/cc @kashifest

/lgtm


ARROW-5710: [C++] Allow compiling Gandiva with Ninja on Windows

Ninja is faster than msbuild, especially in combination with clcache.

Toolchain job took 17 minutes here: https://ci.appveyor.com/project/pitrou/arrow/builds/25502434 (as opposed to 30+ minutes with msbuild).

manylinux1 appears to have barfed on this, perhaps due to an ancient Python in the Docker image
cd /tmp/build-PY3.6-16/src/gandiva/precompiled && python /arrow/cpp/src/gandiva/precompiled/../make_precompiled_bitcode.py /arrow/cpp/src/gandiva/precompiled_bitcode.cc.in /tmp/build-PY3.6-16/src/gandiva/irhelpers.bc /tmp/build-PY3.6-16/src/gandiva/precompiled_bitcode.cc
  File "/arrow/cpp/src/gandiva/precompiled/../make_precompiled_bitcode.py", line 22
    marker = b"<DATA_CHARS>"
                           ^
SyntaxError: invalid syntax

Indeed... it's Python 2.4 :-o

AppVeyor build: https://ci.appveyor.com/project/pitrou/arrow/builds/25521383


Clientset thread safety

I look at the Clientset objects as cluster's connection objects. In that respect, are they thread-safe?

yes, they are
/close


Help-wanted Issue

i need to use megengine module with pytorch module

you can reference https://www.megengine.org.cn/doc/stable/en/reference/comparison.html#comparison to get the equivalent megengine module with the same function in pytorch

I have bn module from pytorch and conv2d module from megengine, how to add both modules in nn. Sequential

you can rewrite bn module from pytorch with megengine functional, simply replace import torch.nn.functional as F with import megengine.functional as F

@mohamed19871988 You can't put MegEngine's module and PyTorch's module together, convert PyTorch module to MegEngine's equivalent instead.
If you have any difficulties with weight convert, check this https://github.com/MegEngine/cheat_sheet_for_pytorch_immigrant


[Bug]: ability to properly set the snapshotResolver under rules_jest

What happened?
When passing a config that expects the ability to import relative to the root dir (root dir being where the package.json is) this modulePaths override is ignored due to rules_jest setting the rootDir relative to the target directory.
To fix this, I have added this workaround locally
jest.config
if (!process.env.ROOT_DIR) {
  process.env.ROOT_DIR = '<rootDir>'
}

//...

export default {
  modulePaths: [process.env.ROOT_DIR],

BUILD.bazel
        # Add the below to the jest_test rule
        env = {
            # rules_jest roots the resolver in the target folder as oppose
            # To the top level project folder. This is a hack to reposition
            # the root directory so the jest module resolver can find
            # other top level folders like "routes/"
            "ROOT_DIR": "%s/web/web-app/app" % path_to_workspace_root(),
        },

Version
Development (host) and target OS/architectures:
Output of bazel --version:
bazel 6.0.0-pre.20221020.1
Version of the Aspect rules, or other relevant rules from your
WORKSPACE or MODULE.bazel file: HEAD
Language(s) and/or frameworks involved:Typescript/SWC
How to reproduce
Have a jest.config with the following field

modulePaths: ['<rootDir'>]

and pass it into the `jest_test` as the `config`

In a test, have a file that `imports` something relative to the root directory like `import {thing} from 'path/to/thing'` where `path/to/thing` is accessible from the root (where the package.json and jest config reside)

Any other information?
No response
Fund our work

[ ] Sponsor our open source work by donating a bug bounty

I spoke with Greg about this and I actually think the problem I'm running into is how the snapshotResolver specifically is resolved. The logic resides here https://github.com/aspect-build/rules_jest/blob/6304f4acb5852156cb379a098ad02c771feec9ba/jest/private/jest_config_template.mjs#L130-L147
The assumption is that the config will be relative to the snapshot resolver, but between bazel test and bazel run the path from which the runner gets the resolver file is different. The only guaranteed fix I think locally is to do path.resolve(__dirname, 'snapshotResolver.cjs') when passing in the custom snapshot resolver. However, I still have issues with the bazel run command as it just hangs. I assume there is an error not bubbling up.


missing dataset

Hi @iarfmoose
Thanks for sharing this T5 example on question generation task.
The dataset you used for training is not included in the repo
train_set = QGDataset(os.path.join(DIR, 'question_generator/datasets/qg_train.csv')) train_loader = DataLoader(train_set, batch_size=BATCH_SIZE, shuffle=True) valid_set = QGDataset(os.path.join(DIR, 'question_generator/datasets/qg_valid.csv'))  valid_loader = DataLoader(valid_set, batch_size=BATCH_SIZE, shuffle=False)
Would you be so kind to provide them ?
Thanks in advance
Philippe

Hi Philippe,
The datasets are too large to upload to the repo but here's a google drive download link

Thanks a lot @iarfmoose

No problem!
Yeah I came across that one after uploading my project. It seems to be a lot more in-depth than mine!


Update dockerfile to build with 20.04

hello
I would like to solve the issue.

@mayuri-dhote: By all means, go ahead. Please do note that any contributions you make to this repository will be release under the MIT license that applies to it.


Failed to copy artifacts - build-azure-win2012r2-x64-2 - jdk14u-windows-x64-openj9

jdk14u-windows-x64-openj9
https://ci.adoptopenjdk.net/view/Failing Builds/job/build-scripts/job/jobs/job/jdk14u/job/jdk14u-windows-x64-openj9/105/console
Execution error: Failed to copy artifacts from build-scripts/release/create_installer_windows with filter: wix/ReleaseDir/OpenJDK*jdk_*_windows*.msi

Dup of https://github.com/AdoptOpenJDK/openjdk-build/issues/1834


PDI-14745

Add PATCH method in REST-Client

Hello, This is an automated comment from our build system. Since this pull request originated from a user  not in the Pentaho organization, we will not proceed  with automatic validation of the pull request.  However, rest assured that it will be reviewed manually as soon  as we get the chance. Thanks for your contribution!

Build Completed
:fire: This pull request has some issues. It would be preferable to fix them in order for it to be just perfect. See below for more details. Some links are also available below for further assistance in addressing those issues.
Build Commands
ant -Dtestreports.dir=bin/reports/unit-test -f engine/build.xml clean-all resolve jacoco && ant -f engine/build.xml checkstyle publish-local

Cleanup Commands
rm -r ~/.ivy2/local || echo no publish local to remove

Changed files
  engine/src/org/pentaho/di/trans/steps/rest/messages/messages_ja_JP.properties

Unit test coverage change
These statistics help you identify how your changes have affected the coverage of the following files. If a file is not in this list, then its coverage was not affected by your changes. To get some help interpreting these metrics, please refer to Jacoco's documentation.
org.pentaho.di.job.entries.evaluatetablecontent.JobEntryEvalTableContent

Branch Change:  + 1.01%
Complexity Change:  + 1.06%
Instruction Change:  + .17%

org.pentaho.di.job.entries.getpop.MailConnectionMeta

Branch Change:  + 1.00%
Complexity Change:  + 1.41%
Instruction Change:  + .30%

org.pentaho.di.job.entries.sql.JobEntrySQL

Instruction Change:  + 3.28%
Line Change:  + 3.87%

org.pentaho.di.trans.steps.checksum.CheckSumMeta

Instruction Change: -.11%:small_red_triangle_down:

org.pentaho.di.trans.steps.constant.ConstantMeta

Instruction Change: -.10%:small_red_triangle_down:

org.pentaho.di.trans.steps.csvinput.CsvInputMeta

Instruction Change:  + .05%

org.pentaho.di.trans.steps.datagrid.DataGridMeta

Instruction Change: -.09%:small_red_triangle_down:

org.pentaho.di.trans.steps.dimensionlookup.DimensionLookupMeta

Branch Change:  + .31%
Instruction Change:  + .06%
Line Change: -.23%:small_red_triangle_down:
Method Change: -1.02%:small_red_triangle_down:

org.pentaho.di.trans.steps.groupby.GroupByMeta

Branch Change: -2.08%:small_red_triangle_down:
Complexity Change: -2.11%:small_red_triangle_down:
Instruction Change: -.14%:small_red_triangle_down:
Line Change: -.37%:small_red_triangle_down:

org.pentaho.di.trans.steps.insertupdate.InsertUpdateMeta

Instruction Change:  + .05%

org.pentaho.di.trans.steps.ldapoutput.LDAPOutputMeta

Instruction Change: -.06%:small_red_triangle_down:

org.pentaho.di.trans.steps.memgroupby.MemoryGroupByMeta

Branch Change: -1.18%:small_red_triangle_down:
Complexity Change: -1.35%:small_red_triangle_down:
Instruction Change: -.18%:small_red_triangle_down:
Line Change: -.48%:small_red_triangle_down:

org.pentaho.di.trans.steps.rest.RestMeta

Branch Change: -2.36%:small_red_triangle_down:
Complexity Change: -1.30%:small_red_triangle_down:
Instruction Change: -.30%:small_red_triangle_down:

org.pentaho.di.trans.steps.setvalueconstant.SetValueConstantMeta

Instruction Change: -.14%:small_red_triangle_down:

org.pentaho.di.trans.steps.sortedmerge.SortedMergeMeta

Instruction Change:  + .18%

org.pentaho.di.trans.steps.synchronizeaftermerge.SynchronizeAfterMergeMeta

Instruction Change:  + .04%

org.pentaho.di.trans.steps.systemdata.SystemDataMeta

Branch Change:  + 2.04%
Complexity Change:  + 2.04%
Instruction Change:  + .32%
Line Change:  + .81%

org.pentaho.di.trans.steps.tableoutput.TableOutputMeta

Branch Change:  + .91%
Complexity Change:  + .82%

org.pentaho.di.trans.steps.textfileinput.TextFileInputMeta

Branch Change: -.53%:small_red_triangle_down:

org.pentaho.di.trans.steps.uniquerows.UniqueRowsMeta

Instruction Change:  + .18%

Hi! This pull request just adds a minor improvement (but important for us). The change is so small that I thought no further tests were needed.
If there is something I can do to complete the pull request, please let me know.