2016: team technical goals

Speaking with @virtix the other day, he requested that I write up some overall goals for the FEWD team. Rather than keep these thoughts to myself, I thought I'd post them here for everyone to see. I'm certain this is an imperfect list, so please feel free to pick it apart. What's missing? What did I get wrong? Is this too generic?
I'm lumping these goals into three overall themes: speed, accessibility, and quality. Most importantly, I want to emphasize that we are a mission driven organization and all of these goals are aimed at supporting that mission:

We work to make markets for consumer financial products and services work for Americans. We arm people with the information they need to make smart financial decisions, and we protect them from unfair, deceptive, and abusive practices.

To be successful at the above we need to create things that are widely accessible, highly performant, work on a range of devices, and serve the highest number of people possible.
Speed
Make it easier to get things onto the web
Right now the process of getting from idea to website is an arduous one. With the launch of V1 and the adoption of Wagtail, that should become a simpler process. In the interim, we need to define a process for getting new content on cf.gov. Let's work with the back-end team to define that process and to create a plan for integration into V1 post launch.
Improve the process of working with CF
We should continue our work on Capital Framework with the goal of making it both easier to use and easier to contribute to. This work has begun and has already made great progress.
The two initial outcomes will be:

A single repo containing all of the CF modules
Improved documentation and integration with the design manual

The end goal is that working with and contributing to Capital Framework will become an intergral part of all front-end workflows rather than a separate task.
Focus on web performance
As a team we follow many performance best practices, but we haven't discussed performance holistically. I think it'd be worthwhile to document our performance best practices and expectations. Let's also consider adopting a performance budget and integrating tests against that budget into Travis/Jenkins and the Software Advisory Group review.
Accessibility
Become device agnostic/improve our mobile first approach
Up until now we've used browser statistics to help guide which browsers we support. I think that's provided us with a great baseline, but I'd like to go beyond that and focus on building device agnostic experiences that provide a useable experience for all users despite their device. This is related to the following goal and will require coordination with our design and back-end dev teams.
Progressively enhance our sites (particularly cf.gov)

When an elevator fails, it's useless. When an escalator fails, it becomes stairs. We should be building escalators, not elevators.

Christina Heilmann, repurposing Mitch Hedberg

I think this also supports the above goal of device agnosticism. I love JavaScript. I mean, really love it, but I also think we should continue to double down on progressive enhancement. I've been guilty of building things for cf.gov that would be non-functional without JavaScript, often because I'm handed an API and asked to build something. In our current landscape, I'm not sure what the best way forward is. Since the back-end team is doubling down on Django, it may be that FEWDs should learn enough Django to do basic routing and form submissions. Let's make a goal of figuring this out and at the very least make a conscious decisions to do so when we build something that is dependent on JavaScript.
Build accessibility into SAG
Let's ensure that our sites hit everything on this checklist and make it a requirement of our Software Advisory Group process. Let's also continue the integration of automated accessibility checks into our workflow.
Quality
Continue to increase code coverage
Over the last year, we have gone from an organization that sometimes writes front-end tests to one where it is expected to do so. Let's continue that by both writing functional and unit tests. I'd also like to collect statistics on the current landscape of our testing efforts (% of projects covered and code coverage reports of those projects) and set goals for improvements.
Focus on code quality
Continue to improve the review process of the Software Advisory Group and focus on developer education through both in-house and external training opportunities.
Other things to think about
Atomic design - how do we best leverage the work that the V1 team is doing with atomic design?

Perhaps the delivery team could help on the performance measurement side... maybe integrating webpagetest into our workflows, or something similar?

Perhaps the delivery team could help on the performance measurement side... maybe integrating webpagetest into our workflows, or something similar?

Yes, for sure! @KimberlyMunoz has also mentioned the performance reporting that New Relic can provide.

Let's also consider adopting a performance budget and integrating tests against that budget into Travis/Jenkins and the Software Advisory Group review.

I did a little bit of work on this with Chris and Irina earlier this Fall before all the atomic design stuff was ready. I had trouble with webpagetest testing local/non-public pages. I looked into using sitespeed.io, but setting that up in Jenkins seemed to be more trouble than it was worth.

I'd also like to collect statistics on the current landscape of our testing efforts
I think this would be awesome. Most repos already have coveralls tracking this and we can start tracking that here: https://coveralls.io/github/cfpb. However, some repos like cfgov-refresh, are having trouble tracking history. We think it has something do with there being no "master" branch.

Most repos already have coveralls tracking this and we can start tracking that here: https://coveralls.io/github/cfpb

Yes, good idea @KimberlyMunoz!

Great goals, and thanks for including mission focus, which is easy to lose sight of in development.

I spent some time talking to @virginiacc and she mentioned something that I thought was really interesting and worth adding. I offered to try to summarize, but @virginiacc please chime in with anything I miss:
We should aim to develop a default way that we write JavaScript at the Bureau and document it as part of the front-end standards. I see "default" as the key word here as it doesn't imply that it's the only way we write JavaScript, but a sensible approach that applies to most of the projects we do. This also could be different for external projects and internal projects, which tend to require different approaches.
We may also or alternatively want to develop a decision matrix for choosing a JS approach for a project. 18F has some great guidelines on choosing a JavaScript framework. In doing so, they're not limiting their developers,but instead saying "here are a few choices that we support."
I see this falling both under the speed and code quality categories.

I don't have much to add to this discussion, other than my broad agreement with everything that's been said. Great work, @ascott1!


Adds reference-optimistic-geth submodule

:clipboard: Add associated issues, tickets, docs URL here.
Overview
Added reference-optimistic-geth submodule for automatic sync.
Changes

Updated submodule sync
Resolved merge conflicts
add new PR reviewers
only execute sync on develop branch

Testing
GH actions

You'll need to explain the PR better otherwise @java-spaces will look for you :D

Codecov Report

Merging #274 (d0d9e2d) into develop (15fcfe1) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop     #274   +/-   ##
========================================
  Coverage    47.22%   47.22%
========================================
  Files           99       99
  Lines         3867     3867
  Branches       762      762
========================================
  Hits          1826     1826
  Misses        2041     2041

Flag
Coverage Δ

boba-contracts
20.39% <ø> (ø)

contracts
77.71% <ø> (ø)

core-utils
86.80% <ø> (ø)

data-transport-layer
31.17% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 15fcfe1...d0d9e2d. Read the comment docs.


Consider building downstream packages

Not sure how useful it might be, but I'd investigate the possibility of building packages for e.g., ArchLinux, Debian, etc

At the moment I don't think it worth the efforts but it will add some maintenance costs.


Side chats menu support added.

Closes #14. Closes #15.

Hey! @zenorocha, just merge this 😉

@nmsmith22389 and @mazipan are the maintainers, but since it's taking a long time I'll follow your suggestion and merge it. Thanks @MairwunNx!


change dashboard events cursor to default to prevent user confusion

Description

When a regular user navigates to the Dashboard screen and hovers over the 'Latest events' entries, the mouse cursor changes to a hand pointer, but it cannot select any of these entries.

Expected Behaviour:
When a user navigates to the Dashboard screen and hovers over the 'Latest events' entries, the mouse cursor must not change to a hand pointer. This will allow the user to make the correct interpretation that the 'Latest events' entries are not selectable.
Actual Behaviour:
When a user navigates to the Dashboard screen and hovers over the 'Latest events' entries, the mouse cursor changes to a hand pointer. This causes a user to incorrectly interpret that the entries are selectable.
To Reproduce:
Log in to the Cloudstack UI as a regular User.
On the Dashboard screen, hover the mouse over the 'Latest events' entries, the cursor changes to a hand pointer. Confirm that the entries cannot be selected.
Types of changes

[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] New feature (non-breaking change which adds functionality)
[x] Bug fix (non-breaking change which fixes an issue)
[ ] Enhancement (improves an existing feature and functionality)
[ ] Cleanup (Code refactoring and cleanup, that may add test cases)

GitHub Issue/PRs

Screenshots (if appropriate):

How Has This Been Tested?
Manually (See screenshot above)

Log in to the Cloudstack UI as a regular User.
On the Dashboard screen, hover the mouse over the 'Latest events' entries, the cursor does not change to a hand pointer but remains a default arrow pointer. Confirm that the entries cannot be selected.

Environment:
CloudStack version 4.11, KVM hypervisor.

Checklist:

[x] I have read the CONTRIBUTING document.
[x] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
Testing
[ ] I have added tests to cover my changes.
[ ] All relevant new and existing integration tests have passed.
 I'll keep you posted as I make progress.

Packaging result: ✔centos6 ✔centos7 ✔debian. JID-2222


Add Hover Effect Improvement for Images

Description
Description
I have noticed a potential improvement in the hover effect for images. I’ve implemented a smoother zoom effect along with a subtle shadow, making the transition feel more polished and visually engaging.
Screenshots

Checklist

[X] I have checked the existing issues
[X] I have read the Contributing Guidelines
[X] I'm a GSSoC'24-Extd contributor
[X] I'm a Hacktoberfest'24 contributor
[X] I am willing to work on this issue (optional)

Hey @harshpareshbhaigosalya, as we are not decided to add any hover effect to our website, we will let you know if there's any work related to it. You can search for other issues/bugs and raise an issue accordingly. Thank you for raising the issue.

Please don't forget to give our repository a star and let me know once you've done it.


A9 - Wrong url, to be removed

Hello,
The 6th link bithound should be removed from the page as it's not a Nodejs service anymore but a casino website.
Cheers,
Genia.

Good catch! Based on archive.org it looks like bithound shut down in 2018.
Looking through the rest of that list, nodesecurity.io (link 1) is a holding site. It look like it was run by a company that then got acquired by NPM.  Their advisories were integrated into npmjs.com, so I think https://www.npmjs.com/advisories is an appropriate replacement link.
The same company also seemed to be involved with the requiresafe module. That's still on NPM, but has been deprecated and not been updated for five years. It continued for a while as the nsp module, before being shut down in 2018. That tool's functionality was built into npm v6: https://medium.com/npm-inc/announcing-npm-6-5d0b1799a905. We could link to the NPM audit docs as a replacement.
The "npm outdated" link is broken too; it loads the tutorial page again in a new tab. That could be updated with links to https://docs.npmjs.com/cli/v7/commands/npm-outdated and https://classic.yarnpkg.com/en/docs/cli/outdated.
It might also be a good idea to add a link to dependabot too, eg: https://docs.github.com/en/github/managing-security-vulnerabilities/configuring-dependabot-security-updates


backport k-modal PR 80 to 2024.1

PR 80 https://github.com/kytos-ng/ui/pull/80
Related to both:

https://github.com/kytos-ng/ui/issues/96
https://github.com/kytos-ng/ui/issues/97

These ones are being asked to be backported, but k-modal has only been introduced in development/master so far, so it'd need to be backported too.
cc'ing @italovalcy

Hi @viniarck for 2024.1 indeed back porting k-modal would be a good option, for 2023.2 I think it is better to use the old approach and define the modal on the interfaceInfo component directly, because it seems like the new modal rely on some event update that was introduced on Vue3. I'm saying this because I backported it to 2023.1 and leveraged the new component to implement this, but it failed with error of missing "showModal" props (?) -- which I couldn't narrow to the original cause.

Hi @viniarck for 2024.1 indeed back porting k-modal would be a good option, for 2023.2 I think it is better to use the old approach and define the modal on the interfaceInfo component directly, because it seems like the new modal rely on some event update that was introduced on Vue3. I'm saying this because I backported it to 2023.1 and leveraged the new component to implement this, but it failed with error of missing "showModal" props (?) -- which I couldn't narrow to the original cause.

Got it. Yes, sounds good. Let's go for the least resistance path here on 2023.2, and only backport on 2024.1. Thanks, Italo.

Hi @viniarck

Got it. Yes, sounds good. Let's go for the least resistance path here on 2023.2, and only backport on 2024.1. Thanks, Italo.

After reassessing the situation, it found easier to backport into 2024.1 without using the k-model new component. The reason is that: the switch confirmation implemented on 2024.1 was already using the old style (https://github.com/kytos-ng/topology/blob/10fad8fb291ebfb38a08bd41e8a3539f1dc5123e/ui/k-info-panel/switch_info.kytos#L36-L60). I've just submitted PR #104 using the old style.
Please let me know if we can just close this issue without backporting the k-modal component.


OpenVX HIP GPU backend - fix failures reported in issue #566 for HIP backend

This PR fixes the failures reported in issue #566 for the HIP backend for WarpPerspective kernels where out-of-bound access caused a segfault.

@paveltc can you test this PR for the issue you filed

@kiritigowda This PR passes the unit tests. Good to merge.


date_last_ran drops data when working across different months

Currently flight data is pulled by getting history data for the current month (previous 14 days). There is an error condition where there are still flights not yet captured at the end of the previous month, that will cause early month data to be lost and vice versa.
For example:
date_last_ran is set as October 29th. The code is ran on November 3rd with October as the target month. Only the October data will be captured, and the date_last_ran will be updated to November 3rd. All of the flight data for Nov 1st-3rd is now lost unless you manually reset the date_last_ran back to the Nov 1st in the database.

This issue will also happen with year crossover, 2022 going into 2023. This condition will need to be addressed as well.


Temporary workaround for issue with gclient and DEPS

For the moment just build with OpenSSL until a proper fix can be developed.

Merging with some un-reviewed fixes to unblock the build.


How to update version of google maps api ?

I have to add zIndex  on markers and i see in somewhere (http://stackoverflow.com/questions/9021159/how-do-i-set-the-z-index-of-a-marker-in-google-maps-api-v3)  in the version 3 of the google maps api have this property. How can I update the maps api version?

zIndex is for Google Maps JS Api, not the native SDKs

And about marker cluster project? Any news?

Development was dropped and a refund will be paid to the users. I'm looking for some experts to start a new funding

I'm obj-c and javascript programmer. And I have some free times. I can help :)

@arilsonkarmo I will add zIndex for iOS only in version 1.3.3. Android has no zIndex support


Add Publish JUnit Test Results Action

This PR was created to add an action that visualize the results of JUnit tests and adds them to the workflow summary page and the PR page (if the PR exists).
The action requires additional permissions:
pull-requests: write (allow adding the test result to the PR page)
checks: write (allow to add test result to workflow summary page)
issues: write (allow to add the test result in order if the issue was created or it was a comment/push)
Example runs:
Push: https://github.com/magicgoody/beam/actions/runs/5926105477
Pull_request_target: https://github.com/magicgoody/beam/actions/runs/5926531661

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
[ ] Update CHANGES.md with noteworthy changes.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@Abacn could you check or suggest a reviewer ?

third party action needs apache infra's approval to be able to run. Shall I make a request?
Also, if there is a test failure, is it possible to see which test and what is the reason for failure? This is the useful part. A summary of how many test run is already available in the log page, but currently the inconvenience for existing github action workflow is that when there is a  test failure, there is no way to see the stack trace.

Let's get this in and see if the workflow also runs on beam repo. Possible need request permission to infra

Third party action is blocked, the workflow is not running

As expected. created https://issues.apache.org/jira/browse/INFRA-24950 requesting enabling this action

Update: the third party workflow is whitelisted. I see a green run: https://github.com/apache/beam/actions/runs/6150041760/job/16687179322
But also there is failing run "Invalid workflow file
The workflow is not valid. Maximum object size exceeded"
https://github.com/apache/beam/actions/runs/6151946870/workflow
Will keep monitoring

Also, when we apply this plugin to all other java tests, can we also change the uploaded archive for "JUnit Test Results" from **/build/test-results/**/*.xml to **/build/reports/tests/ here, and change the condition to
if: failure()

so it would upload human readable detailed test results on failure.
https://github.com/apache/beam/blob/3304e1258b3268fbdd29de14d35a0da3644493e7/.github/workflows/beam_PreCommit_SQL_Java17.yml#L111
The current xml is not human readable, and **/build/reports/tests/ contains html that include both stack trace and stdout / stderr

Hello @Abacn
Sure, thanks


MudDataGrid Accessibility | No labels on buttons, pagination action buttons not reachable with tab stops

Bug type
Component
Component name
MudDataGrid
What happened?

Data Grid buttons don't have labels by default or a way to pass with properties.

Sort, Filter, Menu
First, Previous, Next, and Last

Pagination actions - First, Previous, Next, and Last buttons in footer are not accessible using tab.

Expected behavior

Grid buttons in header to have labels.
Pagination actions to be reachable using tab stops.
Component accessibility to meet industry standards.

Reproduction link
https://try.mudblazor.com/snippet/GYcoYQQNQBcLfGOQ
Reproduction steps

Create a minimal MudDataGrid.
Create a list of Elements.
Use Filterable and SortMode options.
Inspect buttons using browser dev console or the Accessibility Insights for Web tool.
Use tab to navigate grid.

Relevant log output
No response
Version (bug)
6.16.0
Version (working)
no
What browsers are you seeing the problem on?
Microsoft Edge
On what operating system are you experiencing the issue?
Windows
Pull Request

[ ] I would like to do a Pull Request

Code of Conduct

[X] I agree to follow this project's Code of Conduct

Hi, do you want to contribute and help with the accessibility for MudDataGrid?
Such enchantments usually have a low priority for the team since there are much more important things for now and the time is limited.


"evalfile usefulscripts/dumpModules.js" disconnects the Switch on 1.0.0 firmware

switch 'xxxxxxxxxxxx' (1.0.0)> evalfile usefulscripts/dumpModules.js

Switch 'xxxxxxxxxxxx' (1.0.0) disconnected.
switch>

Line 74 causes the disconnect. But I am guessing the memory address, 0x955558, is wrong for 1.0.0, and ultimately that is the problem.
usefulscripts/dumpModules.js:
68 utils.log("stage1, getting webkit ldr:ro handle");
69 //We are reusing WebKit's ldr:ro session
70 var ldrro_mng_ptr = utils.add2(sc.mainaddr, 0x955558);
71 //utils.log('ldr:ro management str base ptr is: ' + utils.paddr(ldrro_mng_ptr));
72 var ldrro_mng = sc.read8(ldrro_mng_ptr);
73 //utils.log('ldr:ro management str base is: ' + utils.paddr(ldrro_mng));
74 var ldrro = sc.read8(utils.add2(ldrro_mng, 0xc));
75 //utils.log('ldr:ro handle is: 0x' + ldrro[0].toString(16))

Yeah, that sounds about right.

If people are going to stay on 1.0.0 and not upgrade to 3.0.0, we need more things supported with 1.0.0.

Indeed. @GovanifY, how'd you track down that offset originally?

Reverse engineering of a webkit dump on 2.0

Offset for 1.0.0 is 0x95D1E8; script doesn't work as-is.


optimized sub-optimal code.

Made the following changes:
-> optimized conditional statements.
-> added Exception in exceptional statement as it's too broad.
-> optimized dictionary declarations.

What happens in cases where a value isn't found? Don't we need those if statements for those circumstances?

There are very less chances that such a situation might occur in the code even though external files such as 'metar (lastest.json)' & 'aq (aqi.json)' can be a possible reason for an error in case the data is manipulated or not found. Internally, it's all fine.
Talking of the if statements, they were a major threat to the performance of the program and even if the data/value was not found, even they will raise a KeyError.
So, the program stands at the same position on which it was before just that it's more optimized now.

My judgement is that the threat of a bad or null value, which could lead to a crash or incorrect information being published, is greater than the small performance differences, which I suspect are a very small fraction of a second.

But this program is still going to fetch the wrong information in the case of the if-else blocks or let it crash if one of them is not found or manipulated.
Overall, as I said before, the changes are only related to performance, any error that exists after the changes made is also going to be raised without the changes as neither there were any special conditions for such situations before nor there are now.
So, one of the only ways you can tackle is by defining some extra try-except blocks or adding some if-else for resisting such errors even in the present code.
Talking about the changes, they make it even easier for you to define such conditions as rather enclosing the whole if-else blocks in another conditional statement, you just have to enclose the statement retrieving the data from the mapping making it both error prone and performance friendly.


EIP4844: remove is_data_available

I don't think is_data_available is much more relevant after we coupled block/sidecar under  SignedBeaconBlockAndBlobsSidecar. So this PR took a stab at removing it.
But I do think in p2p spec, we should add a condition to ensure blob ancestors are valid before importing the block

@dapplion perhaps we can just remove the processed further optimistically...  part, that's ultimately what we decide against

I'm ok with leaving it. My current implementation is taking in account that data might be retrieved async in the future.

remove the processed further optimistically... part

👍

@tbenr @dapplion please take another look 🙏🏼

heh, I just realized I provided dissent but clicked "approve". Didn't intend to appve

I'm good with this now. @terencechain can you patch the description of the issue given the scope of the issue now?

I'm good with this now. @terencechain can you patch the description of the issue given the scope of the issue now?

Sorry I missed that. I just updated the description


Function arguments wrong

Am I doing something wrong here? I get a file.exe.c but the function arguments look wrong - they are all the same. I've tried retdec-v3.3-windows-64b.zip, retdec-v3.3-windows-32b.zip and retdec-v3.3-ubuntu-64b.zip with the same results
I run the following which completes with a couple of warnings about break outside of a loop or a switch statement.
py -3 retdec-decompiler.py file.exe
Here's some output: all function arguments are &g16
`    int32_t v36 = function_402bb0((int32_t)&g16, (int32_t)&g16, (int32_t)&g16); // 0x4032e9
if (v36 == 0) {
// 0x403317
*(int32_t *)(g9 - 4) = *(int32_t *)(g9 + 56);
*(int32_t *)(g9 - 8) = *(int32_t *)(g9 + 52);
*(int32_t *)(g9 - 12) = *(int32_t *)(g9 + 48);
*(int32_t *)(g9 - 16) = *(int32_t *)(g9 + 44);
*(int32_t *)(g9 - 20) = *(int32_t *)(g9 + 40);
*(int32_t *)(g9 - 24) = (int32_t)"activation-key 0x%08x 0x%08x 0x%08x 0x%08x 0x%08x";
*(int32_t *)(g9 - 28) = g9 + 60;
wsprintfA((char *)&g16, (char *)&g16);
*(int32_t *)(g9 + 24) = g9 + 88;
*(int32_t *)(g9 + 20) = 0;
*(int32_t *)(g9 + 16) = g6;
SetDlgItemTextA(&g16, (int32_t)&g16, (char *)&g16);
`
Here's some of the dissassembly after function_402bb0() and before wsprintfA():
`                call    MD5_sub_402BB0  ; Get ready to print key
test    eax, eax
jz      short loc_403317
push    30h             ; uType
push    offset Caption  ; "ERROR"
push    offset Text     ; "Invalid combination of paramaters"
push    edi             ; hWnd
call    MessageBoxA
pop     edi
pop     esi
pop     ebp
mov     eax, 1
pop     ebx
add     esp, 0D0h
retn    10h
; ---------------------------------------------------------------------------
loc_403317:                             ; CODE XREF: DialogFunc+5B0↑j
mov     edx, [esp+0E0h+var_A8]
mov     eax, [esp+0E0h+var_AC]
mov     ecx, [esp+0E0h+var_B0]
push    edx             ; part 5?
mov     edx, [esp+0E4h+var_B4]
push    eax             ; part 4?
mov     eax, [esp+0E8h+var_B8]
push    ecx             ; part 3
push    edx             ; part 2
push    eax             ; part 1
lea     ecx, [esp+0F4h+String]
push    offset aActivationKey0 ; "activation-key 0x%08x 0x%08x 0x%08x 0x%"...
push    ecx             ; LPSTR
call    wsprintfA       ; Print the key
`

@PeterMatula Can you please take a look at this?

@xkubov will take a look.

Hi, by looking at the disassembly code that you have provided I cannot deduce why would RetDec output such C code.
Are you able to provide the binary file which you tried to decompile?

Can I send the file privately? Also file is 34/66 on virustotal but I think that's a false positive

Yes of course. You can send it to my email adress<EMAIL_ADDRESS>

I received your email and was able to reproduce your issue.
The invalid call of functions wsprintfA and function_402bb0 was created because function optimization wasn't able to find proper arguments of these function calls. The optimization was able to find out that function function_402bb0 has 4 parameters by analyzing its definition. However, during the analysis of each call of this function, optimization was unable to find proper stack variables that should be used for passing arguments. This is why it used a dummy register that was later called g16 to tell that there should be 2 arguments and that these four arguments of function call were not properly found.
Why these arguments weren't found?
I analyzed LLVM IR input for this analysis and it turned out that stack analysis did not recognize a lot of stack variables in this input file. Before the call of function function_402bb0 there seem to be an attempt to put a value of register ECX on the stack, but this attempt was not detected by stack analysis:
The following sequence should generate new stack variable:
  %2248 = load i32, i32* @ecx
  %2249 = load i32, i32* @esp
  %2250 = sub i32 %2249, 4
  %2251 = inttoptr i32 %2250 to i32*
  store i32 %2248, i32* %2251
  store i32 %2250, i32* @esp

Hello,
I'm having a similar issue here. I'm getting decompiles that look like this:
int32_t v35 = *(int32_t *)(v6 + 60) / 2; // 0x40123d
g2 = v35;
*(int32_t *)(v14 - 4) = v35;
g7 = v14 + 3668;
*(int32_t *)(v14 - 8) = v6 + 64;
*(int32_t *)(v14 - 12) = g7;
int16_t * v36 = wcsncpy((int16_t *)&g80, (int16_t *)&g80, (int32_t)&g80); // 0x401249
And the underlying assembly looks like this:
0x40121e:   8b 6c 24 20                        	mov ebp, dword ptr [esp + 0x20]
0x401222:   8b 44 24 10                        	mov eax, dword ptr [esp + 0x10]
0x401226:   89 6c 24 18                        	mov dword ptr [esp + 0x18], ebp
0x40122a:   8d 14 80                           	lea edx, [eax + eax*4]
0x40122d:   c1 e2 04                           	shl edx, 4
0x401230:   8d 9c 14 54 10 00 00               	lea ebx, [esp + edx + 0x1054]
0x401237:   8b 45 3c                           	mov eax, dword ptr [ebp + 0x3c]
0x40123a:   8d 4d 40                           	lea ecx, [ebp + 0x40]
0x40123d:   d1 e8                              	shr eax, 1
0x40123f:   50                                 	push eax
0x401240:   8d 94 24 58 0e 00 00               	lea edx, [esp + 0xe58]
0x401247:   51                                 	push ecx
0x401248:   52                                 	push edx
0x401249:   ff 15 30 61 40 00                  	call dword ptr [0x406130]
So clearly something is going wrong, no?
Thanks for any help you can give.

I have a similar issue with decompiling code that was compiled with MSVC++ 6.0. The decompiled code looks something like this:
                        int32_t v35 = *(int32_t *)(v6 + 60) / 2; // 0x40123d
                        g2 = v35;
                        *(int32_t *)(v14 - 4) = v35;
                        g7 = v14 + 3668;
                        *(int32_t *)(v14 - 8) = v6 + 64;
                        *(int32_t *)(v14 - 12) = g7;
                        int16_t * v36 = wcsncpy((int16_t *)&g80, (int16_t *)&g80, (int32_t)&g80); // 0x401249

which looks wrong on the function arguments to me. The according dsm section is like this:
0x40121e:   8b 6c 24 20                        	mov ebp, dword ptr [esp + 0x20]
0x401222:   8b 44 24 10                        	mov eax, dword ptr [esp + 0x10]
0x401226:   89 6c 24 18                        	mov dword ptr [esp + 0x18], ebp
0x40122a:   8d 14 80                           	lea edx, [eax + eax*4]
0x40122d:   c1 e2 04                           	shl edx, 4
0x401230:   8d 9c 14 54 10 00 00               	lea ebx, [esp + edx + 0x1054]
0x401237:   8b 45 3c                           	mov eax, dword ptr [ebp + 0x3c]
0x40123a:   8d 4d 40                           	lea ecx, [ebp + 0x40]
0x40123d:   d1 e8                              	shr eax, 1
0x40123f:   50                                 	push eax
0x401240:   8d 94 24 58 0e 00 00               	lea edx, [esp + 0xe58]
0x401247:   51                                 	push ecx
0x401248:   52                                 	push edx
0x401249:   ff 15 30 61 40 00                  	call dword ptr [0x406130] <wcsncpy>

Is this the expected output, or is there something amiss.
Thank you for your help.

By looking at the code snippets that you have provided it seems like the same issue, but I cannot be sure without trying to decompile the file.
It seems like the optimization responsible for analyzation of function arguments was provided information about types and names of standard function wcsncpy and after analyzation of code before the call of this function, it was unable to find correct stack variables used to pass arguments so it used a dummy register instead. If this issue is related then the error is on the side of stack analysis that was unable to create required stack variables.
If you can provide the binary file you have tried to decompile then it might help with detection of the true source of the problem.

I would like to dig into this myself a little bit more as well, might be a good exercise to learn the workings of the toolchain some more. I haven't found the detailed documentation yet for each of the steps. I have an older development system that can still compile code the same way this example was compiled.
I'm curious, you say it cannot find the correct stack variables, there is literally three push commands right before that. You are saying those are optimized away somewhere? Where does that happen?
Also, when I look into the json file, should it really say that the callingConvention is unknown? Its pretty standard no?
		{
			"callingConvention" : "unknown",
			"declarationStr" : "wchar_t * wcsncpy(wchar_t * restrict dest, const wchar_t * restrict src, size_t n);",
			"endAddr" : "0x406131",
			"fncType" : "dynamicallyLinked",
			"name" : "wcsncpy",
			"parameters" :
			[
				{
					"isFromDebug" : true,
					"name" : "dest",
					"realName" : "dest",
					"type" :
					{
						"llvmIr" : "i16*"
					}
				},
				{
					"isFromDebug" : true,
					"name" : "src",
					"realName" : "src",
					"type" :
					{
						"llvmIr" : "i16*"
					}
				},
				{
					"isFromDebug" : true,
					"name" : "n",
					"realName" : "n",
					"type" :
					{
						"llvmIr" : "i32"
					}
				}
			],
			"returnType" :
			{
				"llvmIr" : "i32"
			},
			"startAddr" : "0x406130",
			"usedCryptoConstants" : []
		},

Okay, I have a simple example here that has a ton of these errors on decompile ...
bios_serial_number.zip


Wrap the PipeWriter used by Kestrel's output writing logic

Kestrel's Http2FrameWriter expects to be able to append more data to the combined TCP-connection-level PipeWriter even there's currently an ongoing call to PipeWriter.FlushAsync() that's only being observed by another stream or streams. Http1OutputProducer also expects to be able to be able to append during flush in order to provide legacy support for unawaited calls to Response.Body.WriteAsync().
There's currently an issue with DefaultPipeWriter where this usage doesn't always work as intended which has lead to some HTTP/2 output corruption. This is also generally much more difficult to support than simply requiring that FlushAsync() always be awaited before calling GetMemory/Span() again. For this reason, we're likely to change DefaultPipeWriter to always throw when GetMemory/Span() is called before the last call to FlushAsync() completes.
This change adds a PipeWriter decorator called ConcurrentPipeWriter (better names welcome but at least it's internal) meant to exclusively be use by Kestrel's Http2FrameWriter and Http1OutputProducer. For the most part ConcurrentPipeWriter is strictly passthrough, but if a flush is pending and GetMemory/Span() is called, it copies the logic from corefx's StreamPipeWriter to manually build up a linked-list of pending data to be flush. Like DefaultPipeWriter today, anyone currently awaiting a flush will see their flush completion delayed until the data appended during the flush also gets flushed.
The effect of the ConcurrentPipeWriter on the PipeWriter being decorated is that it looks to the inner PipeWriter like it's being called by a regular write loop despite Http2FrameWriter/Http1OutputProducer's admittedly unusual usage of the ConcurrentPipeWriter.
Partially Addresses #11804

One thing you can do to get some extra coverage for free would be to swap the PipeWriter back to the StreamPipeWriter. It in theory should work with this decorator now.

Like DefaultPipeWriter today, anyone currently awaiting a flush will see their flush completion delayed until the data appended during the flush also gets flushed.

Can't this lead to a kind of starvation? E.g. one code path like response bodies consistently waits for flushes, where another like responses without bodies consistently appends without flushing. The latter would always get prioritized over the former.
Why not let the flush complete normally and have new data wait for the next flush? That might be simpler to implement as well.

Can't this lead to a kind of starvation? E.g. one code path like response bodies consistently waits for flushes, where another like responses without bodies consistently appends without flushing. The latter would always get prioritized over the former.

Why not let the flush complete normally and have new data wait for the next flush? That might be simpler to implement as well.

The reason we don't have to maintain a queue of TaskCompletionSources and keep track of which buffers correspond to which calls to flush. Instead we let a single TaskCompletionSource manage the only queue of every awaiting flusher.
If there's a codepath that's consistently appending without flushing, they'll effectively get prioritized no matter what since there's no way for that codepath to observe backpressure.

Another problem with this change that our tests didn't catch is that unawaited writes for HTTP/2 responses now throw, because the TimingPipeFlusher doesn't do the task queue thing anymore, so it directly flushes to per-stream HTTP/2 DefaultPipeWriter.
@davidfowl Do you think we should also use ConcurrentPipeWriter to wrap the per-stream HTTP/2 DefaultPipeWriter? To not do so would be a breaking change now that we accept HTTP/2 requests by default.

I added ConcurrentPipeWriter to Http2OutputProducer in https://github.com/aspnet/AspNetCore/pull/12081/commits/ab16819f12413391a3bbf7e7dbcde12504706905. This required adding support for CancelPendingFlush() and Complete() to ConcurrentPipeWriter.

⬆📅

Pipelined Plaintext Physical Servers (master):

Description
RPS
CPU (%)
Memory (MB)
Avg. Latency (ms)
Startup (ms)
First Request (ms)
Latency (ms)
Errors

√
4,912,446
89
53
0.78202
349.9177
96.5003
0.315
0

√
4,875,139
94
53
1.34
356.3113
96.4683
0.333
0

√
4,868,069
89
52
1.7
350.6418
96.3498
0.3367
0

Pipelined Plaintext Physical Servers (halter73/concurrent-pipewriter):

Description
RPS
CPU (%)
Memory (MB)
Avg. Latency (ms)
Startup (ms)
First Request (ms)
Latency (ms)
Errors

√
4,730,116
92
52
1.83
348.1635
96.783
0.3778
0

√
4,836,873
89
52
1.25
349.2496
97.0053
0.3307
0

√
4,811,783
90
51
1.67
342.6237
97.5256
0.3324
0

BenchmarkDriver command and runtime versions
dotnet run -- --server http://<Physical Windows Server>:5001 --client http://<Physical Linux Client>:5002 -j ../../src/Benchmarks/benchmarks.plaintext.json -n Plaintext --webHost KestrelSockets -i 3 -dotnet "Latest" -aspnet "Latest" --self-contained --output-file C:\dev\aspnet\AspNetCore\artifacts\bin\Microsoft.AspNetCore.Server.Kestrel.Core\Release\netcoreapp3.0\*

...

Runtime:                     3.0.0-preview8-27914-06
ASP.NET Core:                3.0.0-preview8.19366.5

On average this works out to about a 1.9% perf regression in the techempower pipelined plaintext benchmark.
The pipelined plaintext benchmark is probably one of the most impacted benchmarks since Http1OutputProducer now writes through the ConcurrentPipeWriter which results in two additional uncontested calls to Monitor.Enter/Exit per response. This is because the ConcurrentPipeWriter.GetMemory() and ConcurrentPipeWriter.Advance() each acquire a lock. The lock taken in ConcurrentPipeWriter.FlushAsync() simply replaces the lock that was previously taken by TimingPipeFlusher.
If we're concerned about this 1.9% perf regression, we could consider passing the lock used by Http1/2OutputProducer and Http2FrameWriter to the ConcurrentPipeWriter ctor to use for it's own locking. If we did this, the ConcurrentPipeWriter could assume the correct lock was already taken any time GetMemory(), Advance() or FlushAsync() is called. That would mean the ConcurrentPipeWriter would only need to acquire a lock itself if it need to do a "background" flush which should never happen in the pipelined plaintext benchmark.
We could try the lock sharing as a follow up PR too.

Do you want to approve this @davidfowl?

If it makes you feel better here are the benchmark results for the ConcurrentPipeWriter w/ the lock sharing.

Description
RPS
CPU (%)
Memory (MB)
Avg. Latency (ms)
Startup (ms)
First Request (ms)
Latency (ms)
Errors

√
4,844,989
91
51
1.33
349.997
118.0152
0.1255
0

√
4,937,008
92
52
1.13
351.6509
98.6947
0.1248
0

√
4,933,612
92
53
1
344.8211
97.1101
0.1193
0

So I'm confident we can get the perf back.


fix compilation errors in app.c on Windows

It seems hard to believe, but MSVC does not support variable length arrays, and probably never will. Also added a couple of checks after allocations.

Landed in https://github.com/cjihrig/uvwasi/commit/3677fe3b8188d485ab3c52221a6f15ab5224646e. Thanks!


reproducer for suspected root cause of incident 2023-09-10

https://neondb.slack.com/archives/C05SD9001PA/p1694452398525969

Fix happened in https://github.com/neondatabase/neon/pull/5285


Run flink test on label

We already run dataflow tests on a label.
Flink is also an integration test so it makes sense to do the same.
This PR makes the trigger for the Flink test either a test-flink label or a test-all label present on the PR, and it also adds test-all as a trigger for the dataflow test.
Doing this because Flink integration test failures on PRs that don't have to do with Flink are harshing the vibe 😄 .

😄 Yey

😄


Added API method and optional settings for ctor, prolonged ping interval, extended options for browser initializing (closes #16)

\cc @AlexanderMoskovkin

/cc @AndreyBelym please, review too.

\r- It's nice in general, pls, rename showBrowserStartMessage and add directDomains and noSSLBumpDomains.

All these changes were included in https://github.com/AlexanderMoskovkin/saucelabs-connector/pull/18, so we don't need this PR.


Azure Content Moderator API for text screening in Power Automate

Q
A

Bug fix?
no

New feature?
no

New sample?
Yes

Related issues?
N/A

Solution Details

Q
A

Solution requires premium license
Yes

Which connectors are used?
Http Premium

Solution uses on-premises connectors?
No

Solution uses custom connectors?
No

What's in this Pull Request?
A two step power automate flow that demonstrates the usage of text screening with content moderation API , and can be easily integrated with any of your existing flows.

Hello is anyone around to merge this?


Document of syntax in manifest.yml

We don't have yet a complete document of the grammar in manifest.yml file. The closest is wskdeploy docs but they are not exactly the same. We should have a complete doc for this in project Firefly, tentatively part of https://github.com/AdobeDocs/project-firefly/blob/master/guides/app-hooks.md.

This is also a good inclusion: https://github.com/adobe/aio-cli/issues/207.

Configuring action timeout in manifest
actions:
  generic:
    function: actions/generic/index.js
    runtime: 'nodejs:12'
    limits:
      timeout: 1800000

https://github.com/adobe/aio-cli-plugin-runtime/issues/200 needs to be included in the syntax doc

This is also a good inclusion: adobe/aio-cli#207.

related: https://github.com/apache/openwhisk-wskdeploy/issues/1107


No option to define an error message for non-empty array

I can define a non-empty string like this:
z.string().nonempty('This string should not be empty')

The same nonempty method exists for z.array() but it doesn't take an argument to define the error message.
I would like to do:
z.array().nonempty('This array should not be empty') // Right now throws "Expected 0 arguments, but got 1"

but right now I'm forced to write it like this:
z.array().min(1, 'This array should not be empty')

Yeah that's an oversight. Added in<EMAIL_ADDRESS>


Due Date Calculation - Bug Fix - 207

Title of ticket:
Description
Due Date Calculation - Bug Fix - 207
Dependencies
Are there any dependencies?
DOD

[ ] Research on possible packages
[ ] create POC for the due date calculation
[ ] Fix due date calculation
[ ]
[ ]

Implementation Approach:
Dependencies/Libraries:
dayjs
date-holidays
dayjs-business-days
Logic

Calculate End Date from Start Date + N days
Identify number of Observed days  between start and end date, say X as  reconcileDays
Add X as business days to End Date in iteration till the reconcileDays is zero.


fixes error with touch events due to jquery wrapping original event

Signed-off-by: Giovanni Vinaccia<EMAIL_ADDRESS>

This fix helped me quite a bit. Thank you!


[feature-#1775][connector][http] http supports offline mode

Purpose of this pull request

http支持离线模式消费数据
linkis #1775  (issue).
Checklist:

[ ] I have executed the 'mvn spotless:apply' command to format my code.
[ ] I have a meaningful commit message (including the issue id, the template of commit message is '[label-type-#issue-id][fixed-module] a meaningful commit message.')
[ ] I have performed a self-review of my own code.
[ ] I have commented my code, particularly in hard-to-understand areas.
[ ] I have made corresponding changes to the documentation.
[ ] I have added tests that prove my fix is effective or that my feature works.
[ ] New and existing unit tests pass locally with my changes.
[ ] I have checked my code and corrected any misspellings.
[ ] My commit is only one. (If there are multiple commits, you can use 'git squash' to compress multiple commits into one.)

I saw your sample, but it still lacks Doc. Can you please add Doc? Thanks PR!


[release-1.16] Fix ENABLE_ENHANCED_RESOURCE_SCOPING bug (#42188)

Manual cherry-pick of https://github.com/istio/istio/pull/42188
Fixes: https://github.com/istio/istio/issues/42330

@kfaseela: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests-arm64_istio_release-1.16
a6c7d954ba0c90e583ca4f491103fdf84ce3b2e0
link
true
/test unit-tests-arm64

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@kfaseela: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests-arm64_istio_release-1.16
a6c7d954ba0c90e583ca4f491103fdf84ce3b2e0
link
true
/test unit-tests-arm64

unit-tests_istio_release-1.16
a6c7d954ba0c90e583ca4f491103fdf84ce3b2e0
link
true
/test unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@kfaseela: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests-arm64_istio_release-1.16
a6c7d954ba0c90e583ca4f491103fdf84ce3b2e0
link
true
/test unit-tests-arm64

unit-tests_istio_release-1.16
a6c7d954ba0c90e583ca4f491103fdf84ce3b2e0
link
true
/test unit-tests

lint_istio_release-1.16
a6c7d954ba0c90e583ca4f491103fdf84ce3b2e0
link
true
/test lint

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@kfaseela: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests_istio_release-1.16
a6c7d954ba0c90e583ca4f491103fdf84ce3b2e0
link
true
/test unit-tests

lint_istio_release-1.16
a6c7d954ba0c90e583ca4f491103fdf84ce3b2e0
link
true
/test lint

unit-tests-arm64_istio_release-1.16
6327d6cec8d7a42a83b7c43bdd9181b18bd206a3
link
true
/test unit-tests-arm64

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@kfaseela: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests_istio_release-1.16
a6c7d954ba0c90e583ca4f491103fdf84ce3b2e0
link
true
/test unit-tests

unit-tests-arm64_istio_release-1.16
6327d6cec8d7a42a83b7c43bdd9181b18bd206a3
link
true
/test unit-tests-arm64

lint_istio_release-1.16
6327d6cec8d7a42a83b7c43bdd9181b18bd206a3
link
true
/test lint

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@kfaseela: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests-arm64_istio_release-1.16
6327d6cec8d7a42a83b7c43bdd9181b18bd206a3
link
true
/test unit-tests-arm64

lint_istio_release-1.16
6327d6cec8d7a42a83b7c43bdd9181b18bd206a3
link
true
/test lint

unit-tests_istio_release-1.16
6327d6cec8d7a42a83b7c43bdd9181b18bd206a3
link
true
/test unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

this caused test flakes: https://prow.istio.io/view/gs/istio-prow/logs/unit-tests_istio_release-1.16_postsubmit/1600501202053763072
https://prow.istio.io/view/gs/istio-prow/logs/unit-tests-arm64_istio_release-1.16_postsubmit/1600501202095706112

@hzxuzhonghu any idea why the tests flake on 1.16 ?


Update deployment instructions

Fastly CLI now includes a command to package a Wasm binary into a C@E package.

So much WIN in this PR ❤


The full error message from Ruby is: 'Cannot load such file -- jekyll-lunr-js-search'

I installed step by step with the tutorial. At last I run jekyll serve, but I got the error message.
And I promise I'v installed the jekyll-lunr-js-search.

Today I rebuilt it again, and the error message changed. It said "cannot load such file -- v8". And below is the shortcut.

Today I rebuilt it again, and the error message changed. It said "cannot load such file -- v8". And below is the shortcut.


Update with best practices and latest upstream functionality

There's been some great work in upstream Crossplane around compositions that we should incorporate into this reference platform.  The goal is to be a model source of best practices for writing Configurations.  For example:

patchSets (named patches)
Required patches
bi-directional patching
others from 1.0 and 1.1 releases

Here's an example from a recent PR comment: https://github.com/upbound/platform-ref-aws/pull/44#discussion_r591697797

@sumbry is interested in taking this as his starter project.

I've started working on this, tracking small task lists in our internal repo. All changes are going to go into my fork.
:crossed_fingers: for many small PRs to come as opposed to one huge.

Awesome @Piotr1215! Please feel free to use me as a reference our to bounce ideas off of 🙇♂

Awesome @Piotr1215! Please feel free to use me as a reference our to bounce ideas off of bowing_man

I'm surely going to take you up on this offer :man_student:

@hasheddan :wave: I want to clean up the crossplane.yaml as suggested by @negz in a TODO in the file.
I wanted to confirm that we are not using the annotations starting with friendly*. I will include the annotations from Xpkg one-pager.
2 one-pagers referng to annotations for reference

Defunct
Xpkg

For reference, here are major themes from v1.1.0 onwards. This list helps define what changes to make in the platform-ref-aws package.
Please feel free to add/correct if anything is missing.
1.1.x
Bidirectional patching
Ref: https://github.com/crossplane/crossplane/pull/2077
This allows for specifying patches from composed resources back to the corresponding XR / XRC.
Patch Sets
Ref: Docs on GitHub
Allows for grouping patches as a named set.
Required patches
Ref: https://github.com/crossplane/crossplane/pull/2133
Added support for Required fromFieldPath patches, which will cause rendering of composing resources to fail if a patch that is marked as Required is missing its fromFieldPath
Naming composition templates
Ref: https://github.com/crossplane/crossplane/pull/2131
This enables reordering, as well as addition and deletion of templates in a Composition
Adds parameters for Crossplane installation
Ref: https://github.com/crossplane/crossplane/pull/2105
Adds parameters to the Crossplane Helm chart for setting nodeSelector, tolerations, and affinity on the Crossplane and RBAC Manager Deployments
Idea :bulb: - this can be useful when installing Crossplane via helm chart on a more complex cluster.
1.2.x
No new notable features
1.3.x
Multi -field patching
Ref: https://github.com/crossplane/crossplane/pull/2352
adds new CombineFromComposite and CombineToComposite patch types that can be used to patch from multiple Composite Resource (XR) fields to a single composed resource field, and vice versa.
Kubectl crossplane can wait for operations to complete
Ref: https://github.com/crossplane/crossplane/pull/2345
1.4.x
Composition Revisions
Ref: https://github.com/crossplane/crossplane/pull/2451
Ref2: https://github.com/crossplane/crossplane/pull/2500
Idea :bulb: Demo could show how to move to a new revision
Patch merge options
Ref: https://github.com/crossplane/crossplane/pull/2409
Supports merging instead of replacing values in patches.
Idea :bulb: this is really cool!
1.5.x
ToUpper/ToLower string transforms
Ref: https://github.com/crossplane/crossplane/pull/2463
1.6.x
No new notable features

@Piotr1215 incredibly useful summary!

Closed by accident, reopening.

I think @Piotr1215 did a great job of adding some extra Composition functionality and we're probably in a good place now


Update list of OSes to non-EoL versions

Pull Request (PR) description
Updates the list of supported OSes in the metadata, no longer lists supports for End-of-Life versions of Debian or EL (CentOS)
I'm unsure on the Ubuntu situation though, 18.04 is technically not EoL yet after all.

On the "Files changed" tab, you can see the list of OS enabled but considered EOL by VoxPupuli.

I'm unsure on the Ubuntu situation though, 18.04 is technically not EoL yet after all.

According to https://wiki.ubuntu.com/Releases, 18.04 has reached what they call "End of Standard Support", which is what we call "End of life" at VoxPupuli.  If you look at what they call "End of life", 14.04 is still supported :upside_down_face:

Re-tagged "backwards-incompatible": while the change does not change the code, this allow future changes to break these OS not tested anymore, so we want this to be ranked high in the ChangeLog.


Feature Request: Add method to render rvt console in current view

I need to add a bit of UI around the console and i noticed that the rails web-console allows for it to be rendered in the current view, with calling <% console %>.
I believe this would be generally very useful to anyone using rvt.

IMO, you can render an iframe in this case. Placing a (web) console in your code is like leaving a breakpoint in a debugger, but RVT is a virtual terminal, powered by Rails, so we don't have a context to rendered it in.

I am using an iframe right now as a workaround but there are some inherent issues

iFrame src's are always requested from my computer, not from the rails app's context which brings issues with CSP (i think, i need to test in production with SSL) and with IP whitelisting because now i have to know my IP in advance. Before that it was always localhost since it was in the context of rails.

A naive question. if i render xterm.js on my site inside a div and just send input/output to RVT resources, wouldn't this be all it would take? For context, i am running "/bin/sh" so i can run commands on my linux server within the Rails app which is protected by authentication using Devise.
I say that because i think rails/web-console is taking care of rails console and context. RVT i think should be more generic.

RVT is what rails/web-console was in its 1.x days. I extracted it into a separate project, because Web Console changed it's scope for 2.x and we had 2 products in one package, which it was hard to maintain. I can drop the CSP protection, but I don't want to blow up the scope of RVT.
I can add a more generic authentication support, so you can attach a rack app instead of just relying on IP whitelisting. This can help you authenticate requests coming from Device authenticated users.

There is a bit of frontend glue code. Check out the files in {app,lib}/assets/javascript.


Emmet not working as expected

Does this issue occur when all extensions are disabled?: Yes/No

VS Code Version:1.69.1 (user setup)
OS Version:Windows_NT x64 10.0.22000

Steps to Reproduce:
1.In your html code try using emmet multiplication

/duplicate of #154375

Thanks for creating this issue! We figured it's covering the same as another one we already have. Thus, we closed this one as a duplicate. You can search for similar existing issues. See also our issue reporting guidelines.
Happy Coding!

@gjsjohnmurray
I am new to this. So just posted it while overthinking.


Add pause / resume just like flowder

New Issue Checklist

[x] I have searched for a similar issue in the project and found none

Issue Info

Info
Value

Platform Name
flutter

Platform Version
any

Dio Version
latest

Android Studio / Xcode Version
e.g. Android Studio 3.3.2 / Xcode 10.2.1

Repro rate
e.g. all the time (100%) / sometimes x% / only once

Repro with our demo prj
e.g. does it happen with our demo project?

Demo project link
e.g. link to a demo project that highlights the issue

Issue Description and Steps
There were many stale issues on dio's issue tracker like flutterchina/dio#1020 flutterchina/dio#399 flutterchina/dio#395. Pause and resume for downloads are always good for a better downloading experience.
This can be added by replacing CancelToken with more advanced DownloadToken or DioToken, which will contain all action like .cancel, .pause, .resume or isCancelled, isPaused, isResumed or something like that.
This can be inspired from an existing package called flowder.
At last I wish dio_http will became a successor of dio and will contribute back to dio when it get's maintainance back on track.

Both this issue and the issue regarding multi threaded downloading (https://github.com/dart-tools/dio_http/issues/3) seem very focused on using dio_http as a file downloading client, which is not how most people are using dio_http (most people use it for managing their api requests, which are usually simple json GET/POST requests).
I'm not sure if adding both of those features would fit better in dio_http, or in a separate "file downloader" package. Is there a reason why you want this functionality in dio_http instead of using flowder like you mentioned?

Firstly flowder is not actively maintained project and also doesn't have multi-threading either. Also it uses dio under the hood and that means that these function can be ported to this library too.
Sure many people use this as a http client and not as a download manager, but some people(like me) who like to have multi-platform downloading support uses dio/dio-http instead in their project's.
Also dio/dio-http is advertised as a download client too in the README.
"A powerful Http client for Dart, which supports ..., File downloading, ... etc."
At last it is upto the maintainers / contributors to add it and it will probably help the project in the long run.

This package is now archived. This was originally forked because the owner of the Dio package was inactive, but he has sinced returned from inactiveness and has added some more contributors to prevent this from happening again in the future. All future development continues over on Dio.


无法加载python扩展

Type: Bug
vscode更新后，python及其依赖于python的扩展都无法加载，提示我进行重新加载窗口。重新加载窗口后仍无法加载。
Extension version: 2022.16.1
VS Code version: Code 1.75.0 (e2816fe719a4026ffa1ee0189dc89bdfdbafb164, 2023-02-01T15:23:45.584Z)
OS version: Windows_NT x64 10.0.19044
Modes:
Sandboxed: No
Connection to 'ssh-remote+new_server' could not be established

System Info

Item
Value

CPUs
Intel(R) Core(TM) i9-10900 CPU @ 2.80GHz (20 x 2808)

GPU Status
2d_canvas: enabledcanvas_oop_rasterization: disabled_offdirect_rendering_display_compositor: disabled_off_okgpu_compositing: enabledmultiple_raster_threads: enabled_onopengl: enabled_onrasterization: enabledraw_draw: disabled_off_okskia_renderer: enabled_onvideo_decode: enabledvideo_encode: enabledvulkan: disabled_offwebgl: enabledwebgl2: enabledwebgpu: disabled_off

Load (avg)
undefined

Memory (System)
31.75GB (22.85GB free)

Process Argv
--crash-reporter-id 9bfbe2ec-72cc-4a34-951c-2769e1a00253

Screen Reader
no

VM
0%

Connection to 'ssh-remote+new_server' could not be established

A/B Experiments
vsliv368cf:30146710
vsreu685:30147344
python383:30185418
vspor879:30202332
vspor708:30202333
vspor363:30204092
vstes627:30244334
vslsvsres303:30308271
pythonvspyl392:30443607
vserr242cf:30382550
pythontb:30283811
vsjup518:30340749
pythonptprofiler:30281270
vsdfh931:30280409
vshan820:30294714
vstes263:30335439
vscoreces:30445986
pythondataviewer:30285071
vscod805cf:30301675
binariesv615:30325510
bridge0708:30335490
bridge0723:30353136
cmake_vspar411:30581797
vsaa593:30376534
pythonvs932:30410667
cppdebug:30492333
vsclangdc:30486549
c4g48928:30535728
dsvsc012:30540252
azure-dev_surveyone:30548225
pyindex848cf:30577861
nodejswelcome1cf:30587006
2e4cg342:30602488
pyind779cf:30657577
f6dab269:30613381
pythonsymbol12cf:30657549
2i9eh265:30646982

Facing same issue here.
I'm using Linux x64, and fail to update extension to pre-release version(2023.3.0).
{
"$id": "1",
"innerException": null,
"message": "Version 2023.2.0 for extension ms-python.python has no support for targetPlatform linux-x64",
"typeName": "Microsoft.VisualStudio.Services.Gallery.WebApi.ExtensionVersionHasNoSupportForRequestedTargetPlatformsException, Microsoft.VisualStudio.Services.Gallery.WebApi",
"typeKey": "ExtensionVersionHasNoSupportForRequestedTargetPlatformsException",
"errorCode": 0,
"eventId": 3000
}

ERR Extension 'ms-python.python' wants API proposal 'telemetryLogger' but that proposal DOES NOT EXIST. Likely, the proposal has been finalized (check 'vscode.d.ts') or was abandoned.

Seems like this is fixed in #20542

I'm experiencing the same error stated above, but in my console there's another error:
Activating extension 'ms-python.python' failed: TelemetrySender.sendEventData must be a function. $onExtensionActivationError @ workbench.desktop.main.js:2020 , not sure if this is related.
And here's information about my system and code:
Version: 1.75.0
Commit: e2816fe719a4026ffa1ee0189dc89bdfdbafb164
Date: 2023-02-04T10:31:04.465Z
Electron: 19.1.9
Chromium: 102.0.5005.167
Node.js: 16.14.2
V8: <IP_ADDRESS>-electron.0
OS: Linux x64 6.1.9-arch1-2
Sandboxed: No

What is the version of the python extension that this is happening? The latest is 2023.2.0.

Seems like this is fixed in #20542, and 2023.2.0 version will fix this, but this version not support linux x64 yet

Our VSIX is actually platform-agnostic, so either that's an incorrect error or there's a bug in VS Code.

I think is't a vs-code issue: https://github.com/microsoft/vscode-remote-release/issues/7961
When I try to install the extension from vscode's Extensions tab, I got an error:
[error] Untrusted: Signature: Untrusted
    at Pn.download (/data/home/unightsun/.vscode-server/bin/e2816fe719a4026ffa1ee0189dc89bdfdbafb164/out/vs/server/node/server.main.js:113:1922)
    at async U.h (/data/home/unightsun/.vscode-server/bin/e2816fe719a4026ffa1ee0189dc89bdfdbafb164/out/vs/server/node/server.main.js:149:90589)

Closing this because the original error (failed: TelemetrySender.sendEventData must be a function.) reported is addressed by using v1.75.0 of VS Code, v2023.2.0 of python extension.

Closing this because the original error (failed: TelemetrySender.sendEventData must be a function.) reported is addressed by using v1.75.0 of VS Code, v2023.2.0 of python extension.

Yup, updated just now and it worked, thanks for the heads up


Persistent notification

The notification disappears on its own. I'm using this extension for all kinds of timers (e.g. pizza) where the notification is even more relevant if I initially missed it :)

7 from extensions.gnome.org

this one use currently Main.notify(), which doesn't allow to specify persistence-options
If you have an alternate in mind, please make a PR.


Feat: CategoryMapper

Implement CategoryMapper operator.

Hi,
It seems like the link is outdated, are u refering to this implementation  ?

Hey @julienbrs, yep it's this one. Thanks


can this running in browser or cli?

https://github.com/MystenLabs/sui/blob/485a8981bc472a35a84851791dadb83578b33944/apps/wallet/tests/demo-app/src/index.tsx#L17
When I try to split coin use browser, the chrome crashed.
Also the publish module, it crashed too.

May anyone tell me why this happend and how to resolve this.

Seems I can't get the splitcoin return. When I add return , it return another error :

code is very simple :
console.log("do split coin ");
const txb= new TransactionBlock();
txb.setGasPrice(10000);
txb.splitCoins(txb.gas,[txb.pure(100)]);
// txb.transferObjects([coin], txb.pure(address));
console.log(txb);
signAndExecuteTransactionBlock({transactionBlock:txb});


Templates for dev16

Updated set of templates
Here is a flat list of templates we should ship in VS 2019:

.NET Core console app
.NET Core library
ASP.NET Core web app (pivots to Empty app and Web API)
Tutorial
.NET Framework console app (using .NET SDK)
.NET Framework library (using .NET SDK)
.NET Standard library
MSTest test project
xUnit test project

I'm not sure what to make of a "Scripting project". Unless it serves a specific purpose, why have one?
Additionally, Xamarin should continue to deliver the existing F# templates.
Original text
In #4977, we cleaned up templates a bit to more easily distinguish between .NET Framework and .NET Core templates. However, I'd like to document what should be delivered for dev16 (Visual Studio 2019).
This is what I have in mind for now, and what I know is definitely capable of being accomplished from a technical and policy perspective:

Console App (.NET Core)
Console App (.NET Framework)
Class Library (.NET Standard)
Class Library (.NET Framework)
Tutorial
ASP.NET Core Web Application
MSTest Test Project (.NET Core)
xUnit Test Project (.NET Core)

I'm curious what others have in mind.
Suggested by @KevinRansom:
We should have a TypeProvider template. Allowing users to generate a correctly specified TP nuget package.
Suggested by @dsyme:
I would like to see a "Scripting project".

drop the user into the pit of success for F# data scripting
consider referencing FSharp.Data and perhaps others
consider having pre-baked snippets to make web requests, crack JSON, read/search/enumerate files and so on
have examples of #r, #load, #r "nuget: Foo.Bar <IP_ADDRESS>"
both .NET Core and .NET Framework variations

Separately we could consider a "Math scripting project" referencing

FSharp.Charting (but it is Windows-specific)
MathNet.Numerics
ML.NET

or some updated variation on FsLab components

@cartermp we should have a TypeProvider template.  Allowing users to generate a correctly specified TP nuget package.

I would like to see a "Scripting project".

drop the user into the pit of success for F# data scripting
consider referencing FSharp.Data and perhaps others
consider having pre-baked snippets to make web requests, crack JSON, read/search/enumerate files and so on
have examples of #r, #load, #r "nuget: Foo.Bar <IP_ADDRESS>"
both .NET Core and .NET Framework variations

Separately we could consider a "Math scripting project" referencing

FSharp.Charting (but it is Windows-specific)
MathNet.Numerics
ML.NET
or some updated variation on FsLab components

@dsyme I agree that having this sort of stuff in place would be wonderful. However, I'll have to do some work on my end to secure the ability to ship third-party components with first-party templates. Currently this is extremely prohibitive, and while I disagree with the outcome, I see the reasoning given by folks internally to be extremely reluctant to distribute them.
The primary issue is that when an enterprise uses these templates and there are issues with them (e.g., a security issue), then we (Microsoft) are contractually obligated to service them. Especially if we do not control the codebase, this is extremely difficult to do. However, with dev16, things may be able to change. There are ways we could potentially mark something as not covered by the standard SLA you get with in-box things, but without a proper mechanism to do so today, I'm going to be conservative and assume that this will not be possible.
When I get back from Oslo I'll start a thread with relevant folks internally to push on this again.

@dsyme I agree that having this sort of stuff in place would be wonderful. However, I'll have to do some work on my end to secure the ability to ship third-party components with first-party templates.

I understand.  Perhaps the template could just have commented-out of #if sections for different common scripting scenarios

@cartermp:

@cartermp

I would like to remove the (.NET framework) templates, they are redundent, and the NetSDK is so much better.
If we think the tutorial template is valuable, we should make .NET Core version of it.
.NET framework class library template makes a class library .NET Core template makes a module.  So we should add a module project template, and a class library project template.
Item template for F# class, and F# module.

I don't think we can do away with templates that target .NET Framework, but we can create a template that uses the .NET SDK and CPS instead of the current project system.

@cartermp can you explain why we can't remove the .NET Framework template?
the .NET Sdk project property page should probably allow you to specify the TargetFramework (s) since those values are important, and are can only be modified by directly editing the project file.

I see.   Sure I'm fine with a NetSDK project that defaults to net472 or net461, that seems like a fine thing.

Agreed.

What do you think about a scripting template?

I wonder if "Class Library" should be named something more F#-like, e.g. "F# Library". No one in the F# world ever uses the name "Class Library".

The "F# Library" could perhaps have more examples of library design in F#, though advanced users tend to find example code in library templates annoying (I suspect beginners like it)

@dsyme Isn't "Class Library" name changed to something meaningful by user on project creation anyway?
And I doubt the template name itself should be different from the one in other languages, I'd find it more confusing.

@dsyme Isn't "Class Library" name changed to something meaningful by user on project creation anyway?

Yes, the user specifies the name (I think the default is already just "Library1") but I'm talking about the name in the list of templates.

And I doubt the template name itself should be different from the one in other languages, I'd find it more confusing.

I don't understand it at all. Why is it more confusing to be accurate about naming?  If C# called it a Widget Library should F# call it a widget library?  No.
Why would we use terminology that is innacurate and foreign to F# on the very first screen that potential new F# programmers see? Seriously, F# is F# and should use F# terminology unless there is a very, very good reason not to.
The templates for F# have never been thought through properly from an F# cognitive perspective, and we should really take this chance to do that.  I seriously think much of the impression in the .NET world that F# is a "me too wannabe C#" is based on this sort of thing: we should people "Class Library" and they see the bare bones of an F# library and they are confused why they aren't seeing what they think of as a class library.  We should call it what it is, a template for creating an F# Library.
F# doesn't even have the keyword "class"....  the idea of "class" is de-emphasized in F#..., subsumed by "type" and "module".

I don't understand it at all. Why is it more confusing to be accurate about naming? If C# called it a Widget Library should F# call it a widget library? No.

But it gets compiled to a class library, so it's an accurate naming after all.
I get what you mean and agree in the case for what newcomers see. Probably "Library" name could de-emphasize "class" thing enough while keeping insight about what kind of a project it technically is.

I don't understand it at all. Why is it more confusing to be accurate about naming? If C# called it a Widget Library should F# call it a widget library? No.

Another thing is when creating a project I'd probably first think about project template type and then about language to create the project in. In Rider we keep the selected language on changing template when template for this project type and language combination is available.
Templates                                         Short Name       Language          Tags
--------------------------------------------------------------------------------------------------------
Console Application                               console          [C#], F#, VB      Common/Console
Class library                                     classlib         [C#], F#, VB      Common/Library

@dsyme,
probably Library is sufficient for files that produce a .dll
New class, module, interface and enum should probably be item templates, that would mean a Library template that was pre-populated with a module would be a good start.
A script project seems like it might be a useful addition, however, much of the project configuration is currently focused on creating applications and libraries.
One thing a script project could enable is an experience for creating scripts and packaging and deployment of them, including perhaps compilation.  However, that will require some thought.
Kevin

A script project seems like it might be a useful addition, however, much of the project configuration is currently focused on creating applications and libraries.
One thing a script project could enable is an experience for creating scripts and packaging and deployment of them, including perhaps compilation. However, that will require some thought.

Yes, that would be good.
Some people do use scripting with a master script and a bunch of #load of library scripts, it scales well and will be very good one #r "nuget..." is there too

I agree with calling it "Library" instead of Class Library. Here's what it could look like in dev16 File | New Project:
> Visual F#
    > .NET Core
        Console app
        Library
        ASP.NET Core Web App
        Scripting project
    > .NET Standard
        Library
        Type Provider Template
    > .NET Framework
        Console app
        Library
    > Test
        MSTest Test Project
        xUnit Test Project
    > iOS
       ... F# iOS templates
    > Android
       ... F# android templates

Not sure I see the point in having .NET Framework variants of a scripting project once everything is up and running on .NET Core. It's impossible to get the full F# component in VS without also installing .NET Core, so we might as well opt people into that one.

It would be great if there was an Azure Functions template.  Indeed "Azure Web App" would seem logical from a Microsoft product perspective, I guess the ASP.NET Core App is set to deploy to Azure

Not sure I see the point in having .NET Framework variants of a scripting project once everything is up and running on .NET Core. It's impossible to get the full F# component in VS without also installing .NET Core, so we might as well opt people into that one.

Libraries - still very many libraries are tied to .NET Framework, and .NET Core F# Scripting is in its infancy.  I think the script needs to declare .NET Framework v. .NET Core but I'm not sure what @KevinRansom's latest thinking on that is.
I suppose type provider template should go under .NET Standard assuming that's the runtime library.  Note the TP template currently depends on source code assets from the TPSDK (or a nuget package if we publish one) so I'm not sure what in-box template policy is for that.

@dsyme,  the current shipping product supports type providers with NetSDK projects that look like:
https://github.com/Microsoft/visualfsharp/tree/master/tests/EndToEndBuildTests/BasicProvider
DesignTime Project:
https://github.com/Microsoft/visualfsharp/blob/master/tests/EndToEndBuildTests/BasicProvider/BasicProvider.DesignTime/BasicProvider.DesignTime.fsproj
TypeProvider Project:
https://github.com/Microsoft/visualfsharp/blob/master/tests/EndToEndBuildTests/BasicProvider/BasicProvider/BasicProvider.fsproj
It can be simplified a bit more, if we add into the nuget package a signal that it's a compilertool/type provider using a marker file or some such.  The template can carry the providedtypes.fs/fsi for now.
Anyway TPs are pretty much solved.

The template can carry the providedtypes.fs/fsi for now.

We can't do that - ProvidedTypes.fs is an SDK of 15,000 lines of (complex) code with a steady minor bug rate. We can't be copy&pasting that as user code into every use template, we would get a nightmare and the user can't maintain that code, update it or even know where to report issues with the code.

Yes, this is an option (we don't yet currently publish a nuget source package for TPSDK).
To do this in a template we would have to

publish that nuget from this repo
localize the code.

probably some other things.  Still best of dev16 radar I think as the current template is adequate for now

I updates the set at the top of the issue. I thought about it, and I'm not in favor of a scripting project unless it demonstrates something where F# scripting is uniquely beneficial.

@cartermp -- I'm not sure about that.  Developers who use scripting … would love to have access to the same type of unified experience as developers who edit/link/debug/build.  I think we need to consider what that unified experience might look like for scripters and perhaps build tooling to make it nicer...er.

Today that experience is adding a file to either a project or solution. How would a brand-new project template improve this?

I think we need to think about it.  You may be correct that the current experience is perfect for scripters.  My guess is that it isn't.  However, I don't know right now, what improvements to make, I do think it needs some thought.

As per internal discussion, we'll include the ability to create .NET Framework-based SDK-style projects and "soft-deprecate" the old-style ones. These will be marked with a legacy moniker of some sort to discourage their creation. In a future Visual Studio (VS 17.0) we'll likely deprecate them.


How can i run it

Hi,
Can you Please tell me how can i run it because when i run in my terminal it throw me
Traceback (most recent call last):
File "demo.py", line 1, in
Thanks in advance.

python version ?

Python 3.7.1

some configuration issue from my side

Did you able to solve the issue?


tss autocomplete adds double the quotes

Describe the Bug
When trying to autocomplete layout: 'horizontal' the autocompleter will make it layout: ''horizontal''.

Steps to reproduce the Bug

In a tss property, type layout: 'ho.
Autocomplete with the 'horizontal' option
It will be filled as layout: ''horizontal''

Expected Behavior
Singular quotes, not double
Your Environment

Software
Version

Titanium SDK
8.2.1.GA

Appcelerator CLI
7.1.1

VS Code
1.39.2

vscode-titanium
0.6.1

Thanks for the report @Topener! I think @longton95 is starting to predict issues coming in, this looks to be fixed with #153


base_url configuration setting, refs #394

Pull request implementing #394

Spotted a bug: <link rel="stylesheet" href="/-/static/app.css?ffa51a"> in the templates. I need to ensure the static assets are served from the new location as well (and any plugin assets too).

This is now ready for people to try out. Quoting https://github.com/simonw/datasette/issues/394#issuecomment-603525339

Anyone willing to give it a quick test and see if it works for your particular use-case? You can install it with:
pip install https://github.com/simonw/datasette/archive/base-url.zip

Then you can run Datasette like this:
datasette fixtures.db --config base_url:/new-base/path/here/


Consider removing the "Assorted Programs" repository

I used to use that and do like the Ackerman fix and few things with splat - but most of this is based on Python 2 and I think may just need removed over cleaned up.
I'll look at it and remove them if I see its true (might clean up one or two and put them in their appropriate sections)

Yeah, these were old - removed

Yeah, these were old - removed


Axis render differently in production and debug mode on android

Prerequisites

[x] This is a victory-native specific issue. (Issues that also appear in victory should be opened here)
[x] I have read through the FAQ and Guides before asking a question
[x] I am using the latest version of victory-native
[x] I have checked to make sure that my versions of react-native and react-native-svg are compatible with this version of victory-native.

Im using<EMAIL_ADDRESS>and<EMAIL_ADDRESS>

[x] I've searched open issues to make sure I'm not opening a duplicate issue

The Problem
I'm seeing some weird stuff with my axis changing between debug and production modes. I am trying to display the following chart:
                <VictoryChart
                    scale={{ x: 'time' }}
                    domain={{
                        x: [
                            new Date(
                                'Thu Sep 01 2016 00:00:00 GMT+1000 (Australian Eastern Standard Time)'
                            ),
                            new Date(
                                'Sun Oct 28 2018 00:00:00 GMT+1100 (Australian Eastern Daylight Time)'
                            ),
                        ],
                        y: [0, 1000],
                    }}>
                    {/* {this.generateChart()} */}
                </VictoryChart>

The debug build shows the chart exactly how I want:

But when I change to production mode, less than half of the ticks are shown:

Do you have any idea how to fix this?
Im using<EMAIL_ADDRESS>and<EMAIL_ADDRESS>I am not sure if this also happens on iOS. My iOS build is currently broken.
Reproducing

Set up an app with the chart shown above
Build in debug mode and check that it works fine
Shake and select Stop Remote JS Debugging, also turn off JS Dev Mode
The chart should now be missing most of the ticks

I can confirm this isn't happening on iOS:

@boygirl any ideas on how to fix this?

Is it fixed?


Amazing Performance intro post

This post is the first in a series about the Amazing Performance initiative. It introduces the tools we've built in the past to help us analyze the perf of Pulumi programs, and describes two small wins as part of the initiative.

@RobbieMcKinstry the appdash screenshot is a mb, does it need to be that big? mind if i push a commit making the file size smaller? as an additional note our blog cannot display anything with a larger width than 900px so there is no need for images to have a greater width than 900.

@susanev Thanks very much for offering! I'll take you up on that! That sounds good to me :)

@RobbieMcKinstry did you want to merge this soon? can i help in any way?

@susanev I've been moving on this slowly for no particular reason. I need to address @iwahbe's comment and do a final editing pass.

Quick thing, please don't merge this blog post until you chat with @scottslowe , @cnunciato , or myself. We are trying to space out the blog post so there is a nice cadence and flow. Thanks

Going through and addressing @gthuang's feedback presently!

Feedback addressed! This guy is ready to go!


Executor Pod Seems to Require Elevated Permissions

With just default settings, using the Helm chart leads to the Executor pod being in a failed state with CreateContainerError as the Pod's status and the Pod's events being
  Normal   Scheduled  27s                default-scheduler  Successfully assigned terrakube/terrakube-executor-podid to nodehostname
  Warning  Failed     26s                kubelet            Error: failed to create containerd container: mount callback failed on /var/lib/containerd/tmpmounts/containerd-mount2121130882: no users found
  Warning  Failed     26s                kubelet            Error: failed to create containerd container: mount callback failed on /var/lib/containerd/tmpmounts/containerd-mount2833052859: no users found
  Normal   Pulled     13s (x3 over 26s)  kubelet            Container image "azbuilder/executor:2.23.2" already present on machine
  Warning  Failed     13s                kubelet            Error: failed to create containerd container: mount callback failed on /var/lib/containerd/tmpmounts/containerd-mount2199440453: no users found

While trying to find an answer I came across an unrelated issue where someone provided their values and it modified permissions specifically for the Executor. After some tinkering with those values, this is now what I need in my values file in order for the pod to create successfully.
executor:
  enabled: true
  securityContext:
    runAsUser: 0

All other pods created without issue, most of which were on the same node, so it seems unlikely to be an issue with the underlying node. For additional context:

This is an EKS-based cluster running K8S 1.30
The nodes in the cluster are ARM-based, running Bottlerocket OS

I would hope this wouldn't matter, but I also ran into ARM-related issues around Postgres (I think the bitnami package being used predates them having arm images) and the spring boot library, so I figured it's worth mentioning

https://github.com/AzBuilder/terraform-spring-boot/issues/52
https://github.com/AzBuilder/terrakube/issues/1477

Hello @fishfacemcgee
For the issue related to downloading terraform you can try this executor version 2.23.3-beta.1, it includes the fix that you sent earlier this morning.

For this one ARM-related issues around Postgres maybe you can try using an external database the one that is included in the helm chart is good for testing purposes, you could check here
For the executor container creation issue, I am not really sure the 3 components (api, registry and executor) are created using the same buildpack the only difference is that we install some other dependencies like git as you can see here
by default the container are using user "cnb" with the following information
cnb@terrakube-executor-848f989f66-w6hc7:/workspace$ whoami
cnb
cnb@terrakube-executor-848f989f66-w6hc7:/workspace$ id
uid=1002(cnb) gid=1000(cnb) groups=1000(cnb)

Maybe using this (could work but I am not sure)
executor:
  enabled: true
  securityContext:
    runAsUser: 1002

@alfespa17 Happy to report that 2.23-beta.1 resolves the terraform install issue on ARM.

And yeah, terrakube works fine with an external DB. I wasn't expecting to need to spin one up in the testing phase I'm in currently, but it was more of a "Oh, that's odd" than a hard deal breaker. As best I can tell, newer versions of bitnami's postgres are multi-arch, so a version bump there (not necessarily trivial, of course) might work as a more permanent "fix" for that. I'll give user 1002 a shot to see if that plays nice or not.

@alfespa17 Using user 1002 solves the CreateContainerError but introduces a new error when trying to run terraform
[threadPoolTaskExecutor-1] INFO org.terrakube.terraform.TerraformDownloader - Initialize TerraformDownloader using custom URL
[threadPoolTaskExecutor-1] INFO org.terrakube.terraform.TerraformDownloader - User Home Directory: ?
[threadPoolTaskExecutor-1] ERROR org.terrakube.terraform.TerraformDownloader - Cannot create directory '?/.terraform-spring-boot/download'.
[threadPoolTaskExecutor-1] INFO org.terrakube.terraform.TerraformDownloader - Downloading terraform version 1.6.4 architecture aarch64 Type Linux
[threadPoolTaskExecutor-1] ERROR org.springframework.aop.interceptor.SimpleAsyncUncaughtExceptionHandler - Unexpected exception occurred invoking async method: public void org.terrakube.executor.service.executor.ExecutorJobImpl.createJob(org.terrakube.executor.service.mode.TerraformJob)
java.lang.NullPointerException: Cannot invoke "org.terrakube.terraform.TerraformResponse.getVersions()" because "this.terraformReleases" is null
	at org.terrakube.terraform.TerraformDownloader.downloadTerraformVersion(TerraformDownloader.java:222)
	at org.terrakube.terraform.TerraformClient.getTerraformLauncher(TerraformClient.java:284)
	at org.terrakube.terraform.TerraformClient.run(TerraformClient.java:209)
	at org.terrakube.terraform.TerraformClient.init(TerraformClient.java:105)
	at org.terrakube.executor.service.terraform.TerraformExecutorServiceImpl.executeTerraformInit(TerraformExecutorServiceImpl.java:404)
	at org.terrakube.executor.service.terraform.TerraformExecutorServiceImpl.plan(TerraformExecutorServiceImpl.java:107)
	at org.terrakube.executor.service.executor.ExecutorJobImpl.createJob(ExecutorJobImpl.java:53)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(Unknown Source)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source)
	at java.base/java.lang.reflect.Method.invoke(Unknown Source)
	at org.springframework.aop.support.AopUtils.invokeJoinpointUsingReflection(AopUtils.java:355)
	at org.springframework.aop.framework.ReflectiveMethodInvocation.invokeJoinpoint(ReflectiveMethodInvocation.java:196)
	at org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:163)
	at org.springframework.aop.interceptor.AsyncExecutionInterceptor.lambda$invoke$0(AsyncExecutionInterceptor.java:113)
	at java.base/java.util.concurrent.FutureTask.run(Unknown Source)
	at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(Unknown Source)
	at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(Unknown Source)
	at java.base/java.lang.Thread.run(Unknown Source)

It looks like the cnb user isn't making it to the created pod but instead a Heroku user is?
k -n terrakube exec -it terrakube-executor-5f96746fc-9svxg -- bash
I have no name!@terrakube-executor-5f96746fc-9svxg:/workspace$ whoami
whoami: cannot find name for user ID 1002
I have no name!@terrakube-executor-5f96746fc-9svxg:/workspace$ cat /etc/passwd
root:x:0:0:root:/root:/bin/bash
daemon:x:1:1:daemon:/usr/sbin:/usr/sbin/nologin
bin:x:2:2:bin:/bin:/usr/sbin/nologin
sys:x:3:3:sys:/dev:/usr/sbin/nologin
sync:x:4:65534:sync:/bin:/bin/sync
games:x:5:60:games:/usr/games:/usr/sbin/nologin
man:x:6:12:man:/var/cache/man:/usr/sbin/nologin
lp:x:7:7:lp:/var/spool/lpd:/usr/sbin/nologin
mail:x:8:8:mail:/var/mail:/usr/sbin/nologin
news:x:9:9:news:/var/spool/news:/usr/sbin/nologin
uucp:x:10:10:uucp:/var/spool/uucp:/usr/sbin/nologin
proxy:x:13:13:proxy:/bin:/usr/sbin/nologin
www-data:x:33:33:www-data:/var/www:/usr/sbin/nologin
backup:x:34:34:backup:/var/backups:/usr/sbin/nologin
list:x:38:38:Mailing List Manager:/var/list:/usr/sbin/nologin
irc:x:39:39:ircd:/run/ircd:/usr/sbin/nologin
_apt:x:42:65534::/nonexistent:/usr/sbin/nologin
nobody:x:65534:65534:nobody:/nonexistent:/usr/sbin/nologin
sshd:x:100:65534::/run/sshd:/usr/sbin/nologin
heroku:x:1000:1000::/home/heroku:/bin/bash

LIkely something in Heroku's buildpack.

That is true the ARM image is using a different buildpack I forgot about that.

At the very least, as a workaround, using 1000 as the runAsUser argument is doing what we hoped 1002 would do. Avoids the CreateContainerError and still lets terraform run.

At the very least, as a workaround, using 1000 as the runAsUser argument is doing what we hoped 1002 would do. Avoids the CreateContainerError and still lets terraform run without having to run as root.

Do you still have the issue for this.terraformReleases ??

Using 1000 as the user solves that error since the heroku user exists (so it's able to download the releases to a folder in its home directory).
As far as the root cause of the CreateContainerError, am I right in understanding that these direct references to the cnb user would cause the issue as that user doesn't exist on the Heroku-buildpack'd executor?

Using 1000 as the user solves that error since the heroku user exists (so it's able to download the releases to a folder in its home directory).
As far as the root cause of the CreateContainerError, am I right in understanding that these direct references to the cnb user would cause the issue as that user doesn't exist on the Heroku-buildpack'd executor?

That is true, that will require some small fix in the pipeline when releasing the ARM version

@alfespa17 I can confirm no more CreateContainerErrors when no runAsUser is defined and the spring boot fix is still working too. Thank you so much for all of your help.


[docs] Instructions for adding Azure hosts through machine are out-of-date

Step by step explanation on how to create an app registration and the appropriate permissions

https://github.com/rancher/rancher.github.io/pull/853


Scroll NaN rounding bug, desktop version

Hi folks.
There is a divide by zero bug in androidx.compose.foundation.SliderAdapter class
During scrollScale calculation it is possible that contentSize would be equal to containerSize, as result we get NaN in scrollScale and "Cannot round NaN value." exception in the end.
Steps to reproduce:

Create window with vertical scroll, but larger that scrollable content, vertical scroll should not be visible.
Click in place where vertical scroll should be.

Scroll scale calculation code fragment:
private val scrollScale get() = (containerSize - size) / (contentSize - containerSize)
You can find exception text in attachment.
NaN_exception.txt

I'm seeing the same thing, sadly it freezes the entire UI with no explanation to the user. My strack trace is a little different, posting it here in case it's helpful:

Stack trace
Exception in thread "AWT-EventQueue-0 @coroutine#63641" java.lang.IllegalArgumentException: Cannot round NaN value.
	at kotlin.math.MathKt__MathJVMKt.roundToInt(MathJVM.kt:1132)
	at androidx.compose.foundation.ScrollableScrollbarAdapter.scrollTo(Scrollbar.desktop.kt:369)
	at androidx.compose.foundation.Scrollbar_desktopKt$scrollOnPressOutsideSlider$1$1.invokeSuspend(Scrollbar.desktop.kt:283)
	at kotlin.coroutines.jvm.internal.BaseContinuationImpl.resumeWith(ContinuationImpl.kt:33)
	at kotlinx.coroutines.DispatchedTask.run(DispatchedTask.kt:106)
	at androidx.compose.ui.platform.FlushCoroutineDispatcher.flush(FlushCoroutineDispatcher.desktop.kt:56)
	at androidx.compose.ui.platform.FlushCoroutineDispatcher$dispatch$1$1.invokeSuspend(FlushCoroutineDispatcher.desktop.kt:40)
	at kotlin.coroutines.jvm.internal.BaseContinuationImpl.resumeWith(ContinuationImpl.kt:33)
	at kotlinx.coroutines.DispatchedTask.run(DispatchedTask.kt:106)
	at java.desktop/java.awt.event.InvocationEvent.dispatch(InvocationEvent.java:316)
	at java.desktop/java.awt.EventQueue.dispatchEventImpl(EventQueue.java:770)
	at java.desktop/java.awt.EventQueue$4.run(EventQueue.java:721)
	at java.desktop/java.awt.EventQueue$4.run(EventQueue.java:715)
	at java.base/java.security.AccessController.doPrivileged(AccessController.java:391)
	at java.base/java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(ProtectionDomain.java:85)
	at java.desktop/java.awt.EventQueue.dispatchEvent(EventQueue.java:740)
	at java.desktop/java.awt.EventDispatchThread.pumpOneEventForFilters(EventDispatchThread.java:203)
	at java.desktop/java.awt.EventDispatchThread.pumpEventsForFilter(EventDispatchThread.java:124)
	at java.desktop/java.awt.EventDispatchThread.pumpEventsForHierarchy(EventDispatchThread.java:113)
	at java.desktop/java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:109)
	at java.desktop/java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:101)
	at java.desktop/java.awt.EventDispatchThread.run(EventDispatchThread.java:90)

Compose 0.4.0-build182, JDK 16, Ubuntu 20.10.

I am also experiencing this issue. From what I can see, this is triggered by the position of the sliderAdapter being NaN in Scrollbar.desktop.kt at line 296 (compose 0.3.2), where sliderAdapter.position is used to calculate oldSign, which results in oldSign being NaN, thus NaN being used as the scrollOffset parameter for scrollbarAdapter.scrollTo(). There the roundToInt() call on the scrollOffset triggers the actual Exception. The quickest fix for this would probably be a NaN check on sliderAdapter.position which stops the scrollTo() method even being called, for example by breaking from the while loop, just as the if in line 303 of the same file does.

Should be fixed in 0.4.0-build190

Please check the following ticket on YouTrack for follow-ups to this issue. GitHub issues will be closed in the coming weeks.


Hello World example with Kotlin and Gradle ^^

Thanks for the PR, however since the book doesn't cover Kotlin, I think it's best to leave this out. Thanks!