Accept ArrayAccess for keyExists/keyNotExists

Copy-pasting the tests of plain arrays wrapped by a ArrayObject (the simpliest ArrayAccess implementation), everything is ok, so we could add ArrayAccess to the allowed typehinted params for keyExists/keyNotExists assertions

I've tested the suite without error_reporting = 0, sry!


Fixed X11 Install from AIX Ansible Playbook

Signed off by<EMAIL_ADDRESS>The new X11 content was pulled from an AIX 7.1 Install ISO along with the dependancies.
AIX_v7.1_Base_Install_7100-04-06-1806_Flash_52018.iso

@smlambert @llxia this is the change for adding xvfb to AIX.  I don't see an issue in infrastructure or tests to map this against.  If there is one can you please reference, if not can you please advise what test pipeline this will enable.

For the record, removing X11.adt.ext wasn't an option as X11.vfb doesn't include the X11 headers files required to compile openjdk.  Both are required.

@karianna @sxa555 who should @olvap377 talk to about getting OpenGL_X11.tar pushed to the Adopt OpenJDK AWX server?

@karianna @sxa555 who should @olvap377 talk to about getting OpenGL_X11.tar pushed to the Adopt OpenJDK AWX server?

@sxa555 is the right person - or try the infra channel to see if someone else can figure it out.

I'll liase offline with @olvap377 to progress this, but before we progress it do we have an associated issue that this PR is resolving?

AdoptOpenJDK/openjdk-tests#49 from Shelleys comment above unless you want an additional issue opened

@sxa555 what is remaining for this PR can it be merged?

Can I please get a review on this PR?


High CPU usage when running Jellystat

I'm running jellystat using docker and I'm getting high CPU usage at all times. CPU goes down to normal when i stop the container

OS: OpenMediaVault (debian linux)
CPU: i3-10105
Ram: 16gb
Media Library size:

Hi @harsh0596 , do you mind also including the specs of your system. EG OS, CPU,Ram size etc. Aswell as a general size of your media library EG 100+ videos

Hi @harsh0596 , do you mind also including the specs of your system. EG OS, CPU,Ram size etc. Aswell as a general size of your media library EG 100+ videos

added

Thanks. Il look into this and see how I can optimise it better.

Hi !
we're seeing intensive CPU and IOPS consumption here too. Feel free to reach out to me if you need metrics or any other information.

Hi @cleming , iv managed to identify a few regions causing these spikes and have optimized them, im still working on the code but a fix for this will be out with the next version.

Looking forward to this fix.  It keeps pounding my i7, i've had to stop the container until the resource issue is resolved, but otherwise it looks good so far!

I am seeing this too. Please correct me if I'm wrong, but my culprit is 'node server.js' process which the container is starting and it ends up taking 30-40% CPU and increases the load on my system. This happens constantly.

Hi @dinosmm , yes this is correct, its due to how imports and activity monitor processes are being run, im currently optimizing this to reduce the cpu and memory load

 Improved Performance

Same issue for me. Keep my cpu at about 20% ( i3-10100T )

Hi Everyone, iv implemented some optimizations to address both high CPU and Memory usage, if anyone has the time, can you pull the latest unstable image and compare to let me know if the improvements work

Awesome, im glad it worked. The first 2 hours where probably the Full sync running (I assume you have a really large library if took that long). The Recently Added Scan is alot less resource intensive but you should see a short spike in cpu usage every hour for a second or 2, this would be that scan. Hopefully i can further improve the efficiency but i feel now it has a more acceptable resource usage

I got unstable going, but on the old database, and it kept load and CPU high again; I assumed it was scanning but the movie etc. counts weren't changing (and were completely wrong), so I deleted all the old data and recreated the container. I'll leave it to scan now, and see how it behaves after a few hours.

Is it normal that the 'Full Jellyfin Sync' is still running? It's been 6 hours since it started. This is on a 34TB library.

What is you CPU ?
With i3-10100T ~2h for ~70To

3 vCores on a VPS.

I have no experience in this sector, but VPS are generally not very powerful. I think it can take a long time on this type of machine.

Hmmm, so im not really sure how well this scales to such a large library, How many items do you have?,also at what stage is the sync at? you should see it on the little toast notifier on the bottom right of your screen (reload the page if it doesn't show).

900 in one library, 300 in another. Jellyfin scan takes less than an hour if done from scratch though.

little toast notifier

That showed briefly at the start of the scan, but hasn't shown again for hours. It doesn't show if I refresh at all.

and do you see any activity in your resource monitors? IE CPU/ RAM usage? im trying to see if its actually running or perhaps its so slow that updates a few and far apart. If you see little to no CPU and RAM usage maybe try restarting the container and rerunning the sync, it could be frozen

Previously (a few hours ago) I could see 'node server.js' taking up 30% CPU and load up because of it, now I see it running still but much lower CPU usage, and load is down below 1 again.
I just stopped and restarted the container; as you said, the full sync job had failed, and the library totals were showing as 10 movies and a few episodes.
I started a new full sync again, let's see how it goes.
If there are any logs anywhere that you think might be useful, please do let me know where to get them and I can post them.

There should be logs under the settings, if thats blank it means the sync failed on start/fetch. Can you also check the container logs for any error messages

Oh yea the logs box in settings was completely blank before and it is blank again now under the 'running' full sync.
Docker logs (using 'docker logs' command) doesn't show much:
><EMAIL_ADDRESS>start
> cd backend && node server.js

[JELLYSTAT] Database exists. Skipping creation
FS-related option specified for migration configuration. This resets migrationSource to default FsMigrations
FS-related option specified for migration configuration. This resets migrationSource to default FsMigrations
[JELLYSTAT] Server listening on http://<IP_ADDRESS>:3000
Activity Interval: 1000
Running Recently Added Scheduled Sync
Running Scheduled Backup
Scheduled Backup Complete
Scheduled Recently Added Sync Complete

sweet, the log bog doesn't populate until the task is complete, wasn't done on purpose, just didn't get around to fixing that minor detail

Awesome, sync done and it seems it has picked up everything, except for a library I have for live concerts, which shows all zero. I know the Roku app also doesn't support those, is Jellystat also meant to not support them? Not a big issue anyway.
Weird that the initial auto full sync didn't work, but there could be timeout/throttling issues throwing off your scanner as I have a very rclone-heavy setup.
Thank you for this update, I'll watch out for this going to stable.

Hmm, it depends, what type of library is the Live concert? As long its not of type Boxset or type Playlist it should get pulled

Okay, il do some research on this and how its reflected in jellyfins API. But i wont post about it here as its of topic for this issue.


components.sonoff.number

Hi, for a few days the integration gives me back errors and sends the home assistant to restart.
Below is the log:
2022-07-26 10:53:29 WARNING (MainThread) [homeassistant.components.number] custom_components.sonoff.number::XNumber is overriding deprecated methods on an instance of NumberEntity, this is not valid and will be unsupported from Home Assistant 2022.10. Please report it to the custom component author.
2022-07-26 10:53:29 WARNING (MainThread) [homeassistant.components.number] custom_components.sonoff.number::XPulseWidth is overriding deprecated methods on an instance of NumberEntity, this is not valid and will be unsupported from Home Assistant 2022.10. Please report it to the custom component author.
2022-07-26 10:53:29 WARNING (MainThread) [homeassistant.components.number] custom_components.sonoff.number::XPulseWidth is overriding deprecated methods on an instance of NumberEntity, this is not valid and will be unsupported from Home Assistant 2022.10. Please report it to the custom component author.
2022-07-26 10:52:51 WARNING (SyncWorker_2) [homeassistant.loader] We found a custom integration sonoff which has not been tested by Home Assistant. This component might cause stability problems, be sure to disable it if you experience issues with Home Assistant

#897


Fixes button overflow on smaller devices

This PR fixes the UI bug causing the Save button on smaller screen iPhones to extend beyond their containers.

Links to LD-546
Here's a good post to explain my rationale for implementing the fix this way

Thanks for the great link! (Perhaps share it in #front-end?)


Added Moq to remove side effect testing antipattern

Now with less side effects.

Thanks, but I use NSubstitute these days.

I will switch in NSubsitute.
Out of curiously why do you use NSubsitute?

Just like the syntax a bit better.
We've been using it with Octokit.net: https://github.com/octokit/octokit.net/blob/master/Octokit.Tests/Clients/AssigneesClientTests.cs

Ok I am a convert. I like NSubsitute.
I have swapped out Moq with NSubsitute now

Thanks!


stm32: lpuart: 9600 baudrate doesn't work

lpuart1 won't work when it is set to 9600 baudrate on nucleo_g0b1re board, in fact it will not work for anything below ~15k baudrate by calculation.

The LPUARTDIV based on the formula above is ~1,706,666, which doesn't fit into a 20bit BRR register and was truncated into 658,091 instead after the LPUART_BRR_MASK mask, see pictures below.

I'm able to get it to work by editing the driver like so:
#if HAS_LPUART_1
	if (IS_LPUART_INSTANCE(UartInstance)) {
		LL_LPUART_SetPrescaler(UartInstance, LL_USART_PRESCALER_DIV4);
		LL_LPUART_SetBaudRate(UartInstance,
				      clock_rate,
#ifdef USART_PRESC_PRESCALER
				      LL_USART_PRESCALER_DIV4,
#endif
				      baud_rate);
	} else {

But I think we might need something more so that the driver can select the correct prescaler value to cover whole baudrate range

I'm able to get it to work by editing the driver like so:

Ok, nice. Feel free to contribute


footer-left/right in setOptions

Previously I've used this code to set my footers with great success. Suddenly it doesn't seem to be working, and I can't find where to fix them.
$wkPdf->setOptions([
            'encoding' => 'UTF-8',
            'footer-left' => 'Copyright '.\date('Y').'My Company',
            'footer-right' => '[page]',
        ]);

In the error log (NGINX) I get usage instructions
[2016-10-26 22:25:35] api.ERROR: Exception: Sales Report Save(temp) Error: Unknown long argument --

Name:
  wkhtmltopdf <IP_ADDRESS> (with patched qt)

Synopsis:
  wkhtmltopdf [GLOBAL OPTION]... [OBJECT]... <output file>
// more stuff here

Note, if I comment out footer-left, footer-right it works fine.

Upon further screwing around it would seem to be the trailing comma in the array. Not used to that mattering...

It seems to me that your problem is this: \date('Y'). Why do you prepend a \ here?

Style guide at work for working with namespaces and our frameworks, it worked fine after I removed that trailing comma. eg '[page]',  to '[page]'

That makes no sense, trailing commas have always been valid in PHP. I'm closing this as there's nothing to fix in our side.


*: clear redundant return statement warnings (S1027)

Cf. https://travis-ci.org/coreos/etcd/jobs/224498875

lgtm


My MAC 8000 port is permanently occupied

The process shows that 8000 is not occupied，like a ghost

Maybe run on a different port instead.


Fix Issue #4272

Fix Issue #4272

Can you elaborate a bit, as I don't understand, how and why this object becomes empty on iOS? :)

The object doesn't become empty. Everything okay with the object. But since it's some special reactive vue object it has some problems with methods like Object.keys(). Object.keys(props) returns an empty array instead of the key's array on IOS. At least on my iphone.

Ok, merged, thanks!

Hey, @nolimits4web  when are you planning to release this?
I have such prop :navigation="{ nextEl: '.nextArrow--c', prevEl: '.prevArrow--c' }" but on iphone 6 arrows do nothing, I think this pull request fixes it (on other phones it works)


Do not try to run AspNet Integration tests on non windows environments

They will not be able to restore and will fail

Thanks Jon!


Some command should read an argument from the standard input

Is it convenient that the show command can work with a picker program such fzf?
The assuming usage is as:
$ rbnotes list | fzf | rbnotes show

When those commands are issued, the first rbnotes print a list of the current notes in the repository and it goes to the input of fzf.  User can select one entry of the list with fzf.  Then, the entry goes to the input of the last rbnotes.  It shows the note selected by the user.
In the above scenario, the show command read an argument from the standard input.
The similar situation may occur with the command update and delete.

The following three commands will read its only argument from the standard input when no argument was specified in the command line.

show
update
delete

The mechanism to read from the standard input is common, which is defined in Rbnotes::Utils#read_timestamp(args) and #read_arg(io).  Those methods assume the given line from the standard input is separated with white space characters, and the first field is a timestamp string.


Update docs on using onActivityResult (again)

Update the long image picker example

@satya164

@facebook-github-bot shipit

cc @grabbou we should cherry-pick this to 0.34

If we do we should cherry pick #9985 as well.


fix fixed truncation of get_json_string function due to t…

…oo long string
Proposed changes
Issue Number: close #xxx
When using get_json_string function. The length of the string to be parsed will be truncated if it exceeds 65535. The data is incomplete.
Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

run buildall


Reconnection support

in case of Mumble server disconnection, reattempt the connection every n seconds
don't allow incoming SIP connections when disconnected from Mumble

I would prefer not disallowing the SIP connection, as I personally use mumsi as an asterisk ConfBridge client (Mumble online conference <-> mumsi <-> asterisk ConfBridge SIP/POTS conference). I might use my friday to supply some patches :)

By disallowing connection I mean do not answer calls when no connection to Mumble. This can me made customizable in config file anyway.

I might use my friday to supply some patches :)

Great. Did you have any issues with sound quality? I didn't have the opportunity to test my primitive frame mixer implementation with more than two people speaking.

Unfortunately, no. No live test yet but that will happen in some days. Sound quality so far seems good, although I miss any adaptive resampling and would expect some buffer over/underruns which, as far as I understand, are "corrected" by dropping a frame or filling with zeroes.
And the mixer seems a bit CPU hungry - don't know if that gets vectorized nicely by the compiler. Maybe use another library for that? But don't worry yet, I am very thankful for your project because I was in the middle of setting up something with ekiga or chan_alsa when I found this repository :)


Query to fetch

The original idea was to convert the "query" without identifier to "queryFetch", but I re-scoped to drop the unnecessary identifiers still hanging around.
There are still a few that I'm not sure how to get rid of, though... it's getting closer.

Codecov Report

Merging #3428 (44b4cef) into development (472964a) will decrease coverage by 1.39%.
The diff coverage is 2.12%.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9bbf28d...44b4cef. Read the comment docs.

@Spuds looks like to fail on fetching elkarte.net?
Maybe firewall or such?

We should update the test to https .... but I'd guess is that Travis uses its own DNS resolver and it did not respect the TTL I set on the old site in prep for the move.  If so it should self clear whenever Travis decides to refresh its resolver.   Or its just another test issue !

@emanuele45 could you resolve the conflicts caused by the1.1.7  🐻 so we can get this merged in 👍

@emanuele45 could you resolve the conflicts caused by the1.1.7  🐻 so we can get this merged in 👍

:crossed_fingers:

:crossed_fingers:

Yeah!

Yeah!


enable unstable feature for cargo risczero test

Not adding additional semantics by handling an unstable feature flag, given this is already gated behind experimental feature flag.
Needed to be able to test new unstable syscalls

@austinabell, I've pushed ccaa353fd40b3ad6e9e541455d05cd788ed6c89b...b74308fc990c4d55f24a656e4e06b5eb26880b67 to avoid the need to specify RISC0_FEATURE_bigint2 manually when building. I am still working on building and testing this.


packer: 1.2.0 -> 1.2.4

Motivation for this change
Simple version upgrade
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[x] Fits CONTRIBUTING.md.

@GrahamcOfBorg  build packer

/cc @zimbatm

Success on x86_64-linux (full log)
Attempted: packer
Partial log (click to expand)
/nix/store/h76xmk8l0ywd88vih2snbc96vrsfar44-packer-1.2.4/share/go/src/github.com/hashicorp/packer/vendor/github.com/posener/complete/test.sh: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/qckzjk3406va7h6s40cy9s75z2w715rq-bash-4.4-p19/bin/bash"
/nix/store/h76xmk8l0ywd88vih2snbc96vrsfar44-packer-1.2.4/share/go/src/github.com/hashicorp/packer/vendor/github.com/ChrisTrenkamp/goxpath/coverage.sh: interpreter directive changed from "/bin/bash" to "/nix/store/qckzjk3406va7h6s40cy9s75z2w715rq-bash-4.4-p19/bin/bash"
/nix/store/h76xmk8l0ywd88vih2snbc96vrsfar44-packer-1.2.4/share/go/src/github.com/hashicorp/packer/vendor/github.com/ugorji/go/codec/prebuild.sh: interpreter directive changed from "/bin/bash" to "/nix/store/qckzjk3406va7h6s40cy9s75z2w715rq-bash-4.4-p19/bin/bash"
/nix/store/h76xmk8l0ywd88vih2snbc96vrsfar44-packer-1.2.4/share/go/src/github.com/hashicorp/packer/vendor/github.com/ugorji/go/codec/tests.sh: interpreter directive changed from "/bin/bash" to "/nix/store/qckzjk3406va7h6s40cy9s75z2w715rq-bash-4.4-p19/bin/bash"
/nix/store/h76xmk8l0ywd88vih2snbc96vrsfar44-packer-1.2.4/share/go/src/github.com/hashicorp/packer/vendor/golang.org/x/sys/unix/mkall.sh: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/qckzjk3406va7h6s40cy9s75z2w715rq-bash-4.4-p19/bin/bash"
/nix/store/h76xmk8l0ywd88vih2snbc96vrsfar44-packer-1.2.4/share/go/src/github.com/hashicorp/packer/vendor/golang.org/x/sys/unix/mkerrors.sh: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/qckzjk3406va7h6s40cy9s75z2w715rq-bash-4.4-p19/bin/bash"
/nix/store/h76xmk8l0ywd88vih2snbc96vrsfar44-packer-1.2.4/share/go/src/github.com/hashicorp/packer/vendor/google.golang.org/appengine/internal/regen.sh: interpreter directive changed from "/bin/bash -e" to "/nix/store/qckzjk3406va7h6s40cy9s75z2w715rq-bash-4.4-p19/bin/bash -e"
/nix/store/h76xmk8l0ywd88vih2snbc96vrsfar44-packer-1.2.4/share/go/src/github.com/hashicorp/packer/contrib/azure-setup.sh: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/qckzjk3406va7h6s40cy9s75z2w715rq-bash-4.4-p19/bin/bash"
checking for references to /build in /nix/store/h76xmk8l0ywd88vih2snbc96vrsfar44-packer-1.2.4...
/nix/store/yzi54farwvcyzisg3vagb4n7dss7a6yd-packer-1.2.4-bin

Success on x86_64-darwin (full log)
Attempted: packer
Partial log (click to expand)
/nix/store/v2zaldmrm4b1g3rhi46yj616d0pfh8ck-packer-1.2.4/share/go/src/github.com/hashicorp/packer/test/fixtures/provisioner-shell/script.sh: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/9gghkkqhn6v7dvpf2319qvrxkkw03vwr-bash-4.4-p19/bin/bash"
/nix/store/v2zaldmrm4b1g3rhi46yj616d0pfh8ck-packer-1.2.4/share/go/src/github.com/hashicorp/packer/vendor/github.com/ChrisTrenkamp/goxpath/coverage.sh: interpreter directive changed from "/bin/bash" to "/nix/store/9gghkkqhn6v7dvpf2319qvrxkkw03vwr-bash-4.4-p19/bin/bash"
/nix/store/v2zaldmrm4b1g3rhi46yj616d0pfh8ck-packer-1.2.4/share/go/src/github.com/hashicorp/packer/vendor/github.com/posener/complete/test.sh: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/9gghkkqhn6v7dvpf2319qvrxkkw03vwr-bash-4.4-p19/bin/bash"
/nix/store/v2zaldmrm4b1g3rhi46yj616d0pfh8ck-packer-1.2.4/share/go/src/github.com/hashicorp/packer/vendor/github.com/ugorji/go/codec/prebuild.sh: interpreter directive changed from "/bin/bash" to "/nix/store/9gghkkqhn6v7dvpf2319qvrxkkw03vwr-bash-4.4-p19/bin/bash"
/nix/store/v2zaldmrm4b1g3rhi46yj616d0pfh8ck-packer-1.2.4/share/go/src/github.com/hashicorp/packer/vendor/github.com/ugorji/go/codec/tests.sh: interpreter directive changed from "/bin/bash" to "/nix/store/9gghkkqhn6v7dvpf2319qvrxkkw03vwr-bash-4.4-p19/bin/bash"
/nix/store/v2zaldmrm4b1g3rhi46yj616d0pfh8ck-packer-1.2.4/share/go/src/github.com/hashicorp/packer/vendor/golang.org/x/sys/unix/mkall.sh: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/9gghkkqhn6v7dvpf2319qvrxkkw03vwr-bash-4.4-p19/bin/bash"
/nix/store/v2zaldmrm4b1g3rhi46yj616d0pfh8ck-packer-1.2.4/share/go/src/github.com/hashicorp/packer/vendor/golang.org/x/sys/unix/mkerrors.sh: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/9gghkkqhn6v7dvpf2319qvrxkkw03vwr-bash-4.4-p19/bin/bash"
/nix/store/v2zaldmrm4b1g3rhi46yj616d0pfh8ck-packer-1.2.4/share/go/src/github.com/hashicorp/packer/vendor/google.golang.org/appengine/internal/regen.sh: interpreter directive changed from "/bin/bash -e" to "/nix/store/9gghkkqhn6v7dvpf2319qvrxkkw03vwr-bash-4.4-p19/bin/bash -e"
/nix/store/v2zaldmrm4b1g3rhi46yj616d0pfh8ck-packer-1.2.4/share/go/src/github.com/hashicorp/packer/website/scripts/deploy.sh: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/9gghkkqhn6v7dvpf2319qvrxkkw03vwr-bash-4.4-p19/bin/bash"
/nix/store/8k5bigrb78ls7xd1w3jxagxibh6lxfp6-packer-1.2.4-bin

Success on aarch64-linux (full log)
Attempted: packer
Partial log (click to expand)
/nix/store/803gq4656rhf8igahmw35pdk5nczpbfy-packer-1.2.4/share/go/src/github.com/hashicorp/packer/scripts/dist.sh: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/9rv2bzx7jz6wjbaxij5qq580qvzksj4i-bash-4.4-p19/bin/bash"
/nix/store/803gq4656rhf8igahmw35pdk5nczpbfy-packer-1.2.4/share/go/src/github.com/hashicorp/packer/scripts/gofmtcheck.sh: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/9rv2bzx7jz6wjbaxij5qq580qvzksj4i-bash-4.4-p19/bin/bash"
/nix/store/803gq4656rhf8igahmw35pdk5nczpbfy-packer-1.2.4/share/go/src/github.com/hashicorp/packer/scripts/vagrant-freebsd-priv-config.sh: interpreter directive changed from "/bin/sh" to "/nix/store/9rv2bzx7jz6wjbaxij5qq580qvzksj4i-bash-4.4-p19/bin/sh"
/nix/store/803gq4656rhf8igahmw35pdk5nczpbfy-packer-1.2.4/share/go/src/github.com/hashicorp/packer/scripts/vagrant-freebsd-unpriv-bootstrap.sh: interpreter directive changed from "/bin/sh" to "/nix/store/9rv2bzx7jz6wjbaxij5qq580qvzksj4i-bash-4.4-p19/bin/sh"
/nix/store/803gq4656rhf8igahmw35pdk5nczpbfy-packer-1.2.4/share/go/src/github.com/hashicorp/packer/scripts/vagrant-linux-priv-config.sh: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/9rv2bzx7jz6wjbaxij5qq580qvzksj4i-bash-4.4-p19/bin/bash"
/nix/store/803gq4656rhf8igahmw35pdk5nczpbfy-packer-1.2.4/share/go/src/github.com/hashicorp/packer/scripts/vagrant-linux-priv-go.sh: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/9rv2bzx7jz6wjbaxij5qq580qvzksj4i-bash-4.4-p19/bin/bash"
/nix/store/803gq4656rhf8igahmw35pdk5nczpbfy-packer-1.2.4/share/go/src/github.com/hashicorp/packer/scripts/vagrant-linux-unpriv-bootstrap.sh: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/9rv2bzx7jz6wjbaxij5qq580qvzksj4i-bash-4.4-p19/bin/bash"
/nix/store/803gq4656rhf8igahmw35pdk5nczpbfy-packer-1.2.4/share/go/src/github.com/hashicorp/packer/test/fixtures/provisioner-shell/script.sh: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/9rv2bzx7jz6wjbaxij5qq580qvzksj4i-bash-4.4-p19/bin/bash"
checking for references to /build in /nix/store/803gq4656rhf8igahmw35pdk5nczpbfy-packer-1.2.4...
/nix/store/yg4s0bcacc0wairpz268wngij4aqa5c4-packer-1.2.4-bin


Repository restructure

Cleaned-up version of #617

There are separate commits for renaming
All the commits will be merged without squashing

/intelci: run
set infra_branch=dev/risrafil-restructure-draft


Remove stack trace from Status.ToString

Fix for https://github.com/grpc/grpc/issues/27066 - remove the stack trace from Status.ToString() when getting the info from the DebugException
However I've not been able to reproduce the original reported problem with "100 lines of stack trace" since the only DebugException that I can see added is that in
https://github.com/grpc/grpc/blob/af855eb64eea02d2f7b68d49c3d4d7a263649104/src/csharp/Grpc.Core/Internal/BatchContextSafeHandle.cs#L97
which doesn't contain a stack trace since it wasn't thrown.

@jtattermusch for review

I think the proposed fix is very reasonable, thanks!
We should probably make the change against grpc-dotnet repository though, since that's where Grpc.Core.Api now lives.
I created https://github.com/grpc/grpc-dotnet/pull/1992

Updated to use FullName for exception

Superseded by https://github.com/grpc/grpc-dotnet/pull/1992 (but thanks for coming up with the initial fix, the PR is a variation of it, with some additions on top).
For now there's no need to backport to v1.46.x branch (see comment https://github.com/grpc/grpc/issues/25740#issuecomment-1359986756).


Only intermittently working

I am using this on a website I am developing with Grunt (in case my 'watch' task is interfering, though I doubt it) and it is only working very occasionally.  Here is my html

{{step.title}}

{{step.header}}

It is included in my app.js as a module along others.  Need more code or info?  Let me know.

it seems that the height being forcefully set to 0, and an image loading at the same time can have unpredictable results indeed. if the image have no dimensions (like min-height on css), it will be hard for the directive to determine a common height.
but you should notice that the container (in your example using bootstrap) is a float, which can further make it harder to either set or watch for.
try putting the directive with a div inside the col-sm-6 containers instead of on it

new version 4.0.0 will update regardless of window resize events (tentatively at 60fps at most)


Small misspellings in ratelimit middleware error messages

Description
Two misspellings of the word middleware in the error messages reported to users
Issue reference
None
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list:

[x] Code compiles correctly
[ ] Created/updated tests
[ ] Extended the documentation

LGTM


Operator Status

Thank you for contributing to mirrord!
Please make sure you added a CHANGELOG entry.

bors r+


support for images in properties

i like to have e.g. RRD images when hovering over a node or click on it. the images and the links are known. there must "just" be some magic. e.g.:

"node": [
  "id": "foo",
  ...
  "properties": {
    "image": "path/to/image"
  }
]

@bittorf, +1, I agree your suggestions about json structure implementation, so I want to ask to @nemesisdesign: I'm very interested to netJson implementation too, and I'd like to propose and suggest some enhancements, but I'm not sure if here is the real place to submit.
Perhaps in netJson repo?

@bittorf you can accomplish what you need by supplying a custom onClickNode option, the default function is here:
https://github.com/interop-dev/netjsongraph.js/blob/master/src/netjsongraph.js#L216-L235
As you can see, the function controls the generated HTML, so you can inject a bit of code that the images the way you prefer. You should also style the CSS differently as they likely won't fit in the small overlay.
Afterwards we can talk about how to avoid duplicating the entire function to add custom bits to the overlay.
I don't think we should address this now in the library itself or in NetJSON, there are just too many ways of doing it and we won't be able to please everybody.


Add target nodes AWS ELB annotation documentation

Adding documentation to filter the nodes used by AWS load balancer services. This feature was added in this PR https://github.com/kubernetes/kubernetes/pull/90943

Markdown looks good to me (would be nice to address nits, but OK to merge without fixing them)

/sig cloud-provider

The deploy preview looks outdated. The site has been updated.
Would you rebase?
Page preview:
https://deploy-preview-21587--kubernetes-io-vnext-staging.netlify.app/docs/concepts/services-networking/service/

/lgtm


Add an option to set SPI clock pin to None

It can be useful to use only MOSI pin, for example when driving ws2812 led strip using SPI peripheral. esp-idf allows setting pin num to -1 when unused. I can create pull request for this if needed

Added PR which resolves this: https://github.com/esp-rs/esp-idf-hal/pull/440

#440 merged


Adds config option to minify HTML output

If the $config['minify_output'] setting is set to TRUE, CodeIgniter's output class will process the output with a (currently very rudimentary) minify function.
According to my tests simply removing extra spaces reduces the content by 8-12%.  I'm sure more advanced minifying could improve on this.  Output is minified before the cache is written, so savings are also on diskspace.
Also, I still haven't figured out how to not include those previous first two commits in my pull requests.

This is a fantastic idea.  Have you given thought on newline characters & how we might handle that with pre/code tags?

I'll modify it to leave  and  content untouched.
There are a number of open source minifiers around, but there are probably licence incompatibilities.  :(

I can foresee when CodeIgniter becomes more mime-type aware it automatically running the corresponding minifier.

Well, I'm happy.  My landing page is now 30% smaller, and most other pages 10-15%.

:thumbsup: This would help me a ton :-)

+1

+1

+1

Cool. I've had my own makeshift version of this myself that clobbered  tags. So this is really nice to have in the framework.

The newline instead of space was based on an old and perhaps unfounded superstition I have that having excessively long lines-lengths can cause issues.  Since newline and space are otherwise functionally the same I saw no harm in it.
As far as s{2,} vs s+, I imagine the former is more efficient since it is more restrictive.  The latter does a replace on every single space, tab, and/or newline, whereas the former only does the replace if it results in a reduction.  If there's still a push for changing this I'd like to do a benchmark comparison just to get an idea, since I really have no idea what the effect is for sure.

I don't think long lines matter much. In fact, I've found that any whitespace between tags is generally superfluous. Look at the source for https://timshomepage.net/, and see how long it takes to find a browser that chokes on it.

Looks good on my end: http://d.pr/gYpQ

Yet to have any problems, even on some tricky pages http://d.pr/95kB

I understand the benefits of using s{2,} so that sounds good, and I don't think we need to add newlines in. Apache will never care about long lines unless it's in the HTTP Request, and then it's a 8kb limit.
So it looks like we're golden here guys. @derekjones @ericbarnes @gaker got anything to say about this one? I've had it enabled for pyrocms and the whole thing seems fine, shaved 1-2kb off each page!

I was currently using

$search = array(
'/>[^\S ]+/s', //strip whitespaces after tags, except space
'/[^\S ]+</s', //strip whitespaces before tags, except space
'/(\s)+/s'  // shorten multiple whitespace sequences
);
$replace = array(
'>',
'<',
'\1'
);
return preg_replace($search, $replace, $buffer);

to strip any white space from outside < > tags. Not sure if you could find this useful :)

@minerbog it already does this with a single, more efficient regular expression.

Apologies, regex has never been my strongest point!!

@minerbog No worries.


Autocompleter crashes Paste Java as Ceylon

This file:
https://raw.githubusercontent.com/ceylon/ceylon-web-ide-backend/master/src/main/java/com/redhat/ceylon/js/repl/Autocompleter.java
Seems to crash the converter.

I'm pretty sure this is caused by the slowness described in #5:
[ 876746]  ERROR - llij.ide.plugins.PluginManager - GC overhead limit exceeded
java.lang.OutOfMemoryError: GC overhead limit exceeded
	at org.antlr.v4.runtime.atn.ParserATNSimulator.getEpsilonTarget(ParserATNSimulator.java:1640)
	at org.antlr.v4.runtime.atn.ParserATNSimulator.closure_(ParserATNSimulator.java:1561)
	at org.antlr.v4.runtime.atn.ParserATNSimulator.closureCheckingStopState(ParserATNSimulator.java:1535)
	at org.antlr.v4.runtime.atn.ParserATNSimulator.closure_(ParserATNSimulator.java:1603)
	at org.antlr.v4.runtime.atn.ParserATNSimulator.closureCheckingStopState(ParserATNSimulator.java:1535)
	at org.antlr.v4.runtime.atn.ParserATNSimulator.closure_(ParserATNSimulator.java:1603)
	at org.antlr.v4.runtime.atn.ParserATNSimulator.closureCheckingStopState(ParserATNSimulator.java:1535)

I tried converting from the command line and it works. There is also some code in the file that seems to fail the conversion. If I remove that, then it seems to work when I paste.

Yeah it works from the CLI, but it uses 1.7GB or memory, so of course it will crash in an IDE.
Possible improvement here: https://github.com/antlr/grammars-v4/issues/215


Tippy content

I'm trying to modify Tippy to accept ('model, 'msg) Vdom.app as content instead of a string and I'm really having problems in defining the types and writing (a) the Tippy value record and (b) the handler for Vdom_blit.register
I have a tippybinding.mli of
type t
val t_of_js : Ojs.t -> t
val t_to_js : t -> Ojs.t
type props = { trigger: string option }
type options = { content: Js_browser.Element.t; trigger: string option }
val create : Js_browser.Element.t -> options -> t [@@js.global "tippy"]
val set_content : t -> Js_browser.Element.t -> unit [@@js.call "setContent"]
val set_props : t -> props -> unit [@@js.call "setProps"]
val destroy : t -> unit

and a tippy.mli of
val init: unit -> unit
type trigger = MouseEnter | Focus | Focusin | Click | Manual
val tooltip : ?trigger:trigger list -> content : ('model, 'msg) Vdom.app -> 'a Vdom.vdom

Is this a sensible approach or should I force a user to use a Vdom_blit.Custom.t for the contents?

Hello Nick !
It seems that what you are proposing would be to run a whole vdom application inside the content element. It may be possible to hack something that does that but it would be super painful especially if you want the "tooltip app" to communicate with the "main app". I would not go that way.
Ideally, one would probably like to have the following API instead:
val tooltip : ?trigger:trigger list -> content:'a Vdom.vdom list -> 'a Vdom.vdom

That would be great and allow to have interactive tooltips that could send 'a messages (eg. with buttons inside the tooltip).
Unfortunately, there is no simple way to use the tippy library with "vdom content" because tippy moves the content element out of its parent which breaks invariants of the vdom blitter: the content element will be move inside a div that is not controlled by the "blitter" and all event triggered inside the content element won't be caught by the blitter's event handler.
I think that if you want to have an interactive tooltip library whose content is a vdom node you could use the lower-level popper.js library and reimplement in vdom part of the tooltip logic.
You would need to use a custom element to represent the popper instance (and dispose it when it's  not needed). Popper will help to attach the parent of the custom element to the parent's parent.
In order to have access to the parent's parent, you will need to use the "Vdom_blit.Custom.after_redraw" callback to create the instance (because before the first redraw, the parent of the custom element has not yet been inserted to the dom ...). The content of the parent will be the inside of the tooltip and parent of the parent will be the target of the tooltip.
As you can see, it is not super easy ... and it will require some work to implement the trigger (and untrigger) of the tooltip (ie. all the features that are implemented by tippy and not by popper).
To conclude, I would say that either you stick to string/html content and use tippy (and sacrifice all the benifits of vdom inside the tooltip) or you use popper.js to implement small tooltip library in vdom.
Out of curiosity, what are you trying to achieve with that ?

Hi Marc,
Thanks for your comments - I was trying to do some svg popups with buttons. I'll look into the Popper.js api and tooltips (thanks :)) and see if I can get it to do what I need. I did do an orphan vdom component a few days ago using tippy, which resolved to an Element.t instead of a string in the bindings, and this seemed to work although I didn't check any of the msg'ing.
I'll get back to this as soon as I can and report progress.
Thanks again

Yes, I made that for you (and for convincing myself that this was indeed doable) https://github.com/mlasson/tooltips .
But I am sure there are some caveat with this approach (I would not be surprise that you'll need to all popper instance's update method after all update of the dom). Ie when you insert a new element that may move the target, you'll need to call the update method to move the popup. This could be done with an "infinite" after_redraw (an after_redraw callback that register itself until the custom elements is disposed).
I close this issue, good luck !

Merci!


Firestore Query with " isGreaterThan > '' operator doesn't update stream as expected

Using my previous example, this sample code works fine until you delete data manually from the database. It is never reflected in the view. If the stream is showing 10 items and you delete 4 from the database, it will still show 10 even if you hot reload or restart the app, it is always showing 10 items.
the isGreaterThan operator is supposed to be the alternative to != that we are used to in sql, it there another way to make this query?
_delivered() {
    print('In the delivered function:${resId},${customerId}, ');
    return StreamBuilder<QuerySnapshot>(
        stream: Firestore.instance
            .collection('restaurants')
            .document(resId)
            .collection('customers')
            .document(customer)
            .collection('orders')
            .where('deliveryTime', isGreaterThan: '')
            .snapshots(),
        builder: (context, snapshot) {
          print('Does snapshop have data? ${snapshot.hasData}');
          if (!snapshot.hasData) return Container();

          List deliveredListFromServer = snapshot.data.documents;
          return Expanded(
            child: ListView(
              shrinkWrap: true,
              children: deliveredListFromServer.map((item) {
                print('document id: ${item.documentID}');
                return InkWell(
                  child: SizedBox(
                    height: 50,
                    child: Row(
                      crossAxisAlignment: CrossAxisAlignment.center,
                      children: <Widget>[
                        SizedBox(
                          width: 80,
                          child: Text(
                            item['orderBy']['username'],
                            textAlign: TextAlign.center,
                            overflow: TextOverflow.ellipsis,
                            style: TextStyle(fontWeight: FontWeight.bold),
                          ),
                        ),
                        SizedBox(
                          width: 5,
                        ),
                        Expanded(
                          child: ListView(
                            scrollDirection: Axis.horizontal,
                            children: item['order'].map<Widget>((item) {
                              return SizedBox(
                                width: 80,
                                child: Align(
                                  alignment: Alignment.centerLeft,
                                  child: Text(
                                    '${item['qty']} ${item['drinkName']}',
                                    overflow: TextOverflow.ellipsis,
                                  ),
                                ),
                              );
                            }).toList(),
                          ), //
                        ),
                        SizedBox(
                          width: 5,
                        ),
                        SizedBox(
                          width: 60,
                          child: Text(DateFormat('h:mm a').format(
                              DateTime.fromMillisecondsSinceEpoch(
                                  int.parse(item['deliveryTime'])))),
                        )
                      ],
                    ),
                  ),
                  onTap: () {
                    _deliveredDetail(item);
                  },
                );
              }).toList(),
            ),
          );
        });
  }

@pkitatta
please open the issue in the plugin's repository.
Closing, as this isn't an issue with Flutter itself,
if you disagree please write in the comments and I will reopen it
thank you


Add marginBottom to Table to break before reaching the bottom of the page, in order to have a footer

Hi
I added a property to table marginBottom and what it does is that it would break and go the next page, I needed that value because I have a footer in every page and if the table has many rows the row and footer overlaps.
Thanks for the library

Same Thing for the Header. I just saw your pull request here. I opened another issue for Header.

Hi, uff I went to quickly to add the PR, I'm still changing some stuff in my repo I'll made another pr
Thanks :)

No problem, but you dont necessary have to close the pull request instantly just add new commits to it


bpf: lb: un-break terminating backends for service without backend

Discussing with @borkmann we realized that service LB for established connections no longer works, if the service loses the last of its active backends. This was broken by https://github.com/cilium/cilium/pull/22388, which introduced the svc->count check too early in the code path.
Fix service connections to terminating backends, when the service has no more backends available.

/test


Added misc channel to evoked plot.

Closes https://github.com/mne-tools/mne-python/issues/3647
Now misc channels included to evoked instance are also plotted.

LGTM

we'll need to backport

Current coverage is 87.39% (diff: 100%)

Merging #3649 into master will not change coverage

@@             master      #3649   diff @@
==========================================
  Files           343        343
  Lines         60757      60757
  Methods           0          0
  Messages          0          0
  Branches       9300       9300
==========================================
  Hits          53100      53100
  Misses         4903       4903
  Partials       2754       2754

Powered by Codecov. Last update bcd57d6...671011c

I ran into just this problem today, thanks @jaeilepp!
And good to see @kdoelling1919 fully committed to the good side :)

@jaeilepp please merge and backport
thx


Add storage container build into IPDK CLI

Similar to #157, we should add the storage container into the IPDK CLI as well.
Copying @stolsma for his edification as well.

We need to understand IPDK CLI use cases and expected functionalities first. We can use this issue as a discussion place for defining this kind of extension. Please elaborate on the current usage and expectations in terms of storage support.


chinese font display not well on nexus 5x

in Meizu

in nexus 5x

flutter doctor
[✓] Flutter (Channel master, v0.5.6-pre.39, on Mac OS X 10.13.5 17F77, locale zh-Hans-CN)
    • Flutter version 0.5.6-pre.39 at /Users/yuyanhui/Desktop/flutter/flutter
    • Framework revision a18f5e84a1 (8 hours ago), 2018-06-20 20:23:51 -0400
    • Engine revision 549c855e89
    • Dart version 2.0.0-dev.63.0.flutter-4c9689c1d2

[!] Android toolchain - develop for Android devices (Android SDK 27.0.3)
    • Android SDK at /Users/yuyanhui/Library/Android/sdk
    • Android NDK at /Users/yuyanhui/Library/Android/sdk/ndk-bundle
    • Platform android-27, build-tools 27.0.3
    • Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 1.8.0_152-release-1024-b01)
    ! Some Android licenses not accepted.  To resolve this, run: flutter doctor --android-licenses

[✓] iOS toolchain - develop for iOS devices (Xcode 9.4.1)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 9.4.1, Build version 9F2000
    • ios-deploy 1.9.2
    • CocoaPods version 1.5.0

[✓] Android Studio
    • Android Studio at /Applications/Android Studio 3.2 Preview.app/Contents
    ✗ Flutter plugin not installed; this adds Flutter specific functionality.
    ✗ Dart plugin not installed; this adds Dart specific functionality.
    • Java version OpenJDK Runtime Environment (build 1.8.0_152-release-1136-b02)

[✓] Android Studio (version 3.1)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin version 25.0.1
    • Dart plugin version 173.4700
    • Java version OpenJDK Runtime Environment (build 1.8.0_152-release-1024-b01)

[!] IntelliJ IDEA Ultimate Edition (version 2018.1.2)
    • IntelliJ at /Applications/IntelliJ IDEA.app
    ✗ Flutter plugin not installed; this adds Flutter specific functionality.
    ✗ Dart plugin not installed; this adds Dart specific functionality.
    • For information about installing plugins, see
      https://flutter.io/intellij-setup/#installing-the-plugins

[!] VS Code (version 1.23.1)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension not installed; install from
      https://marketplace.visualstudio.com/items?itemName=Dart-Code.flutter

[!] Connected devices
    ! No devices available

! Doctor found issues in 4 categories.

@Hixie

The issue is more apparent (and more serious) when mixing CJK characters with English:

As shown above, when a CJK character is introduced to an all-English text,

decenders of the text field is cut away, user can no longer possible to distinguish a "g" from a "q".
the baseline(?) of the text field and text widget will be changed, creating a somewhat suboptimal experience. The baseline of the text field is shifted up a little bit, while the one in text widget is shifted down in a larger extent.

I'd also like to add that this doesn't limited to Nexus 5X. I am seeing this same issue on my Nexus 5X and Nokia 7 Plus. I don't see this on the Nexus 5 emulator though.

Tested on some emulators and got the following result:
Pixel 2 emulator on Android 8.1.0 - descendents cropped.
Pixel 2 emulator on Android 7.1.1 - descendents cropped.
Nexus S emulator on Android 8.1.0 - descendents not cut.
Nexus S emulator on Android 7.1.0 - descendents not cut.
I know it sounds strange but could it be device resoluation/dpi related?
(Note that the baseline does get shifted for all devices though, so this is probably another issue.)

https://github.com/flutter/engine/pull/5962 will fix this for editable text fields where the text content does not overflow the field's bounds.
However, if the text overflows, then the clipping done in the framework's RenderEditable.paint() will clip part of the text.  This happens because the RenderEditable's size property does not update when the height of the text changes due to the mix of fonts with different metrics.
Interestingly the layout of the widgets is updated to reflect the new height as expected, but size remains unchanged.
@Hixie @HansMuller

One thing we should probably do here is probably to change the baseline code in RenderEditable to not pay attention to the actual text and to just return the baseline of the given text style. That way the baseline wouldn't change over time. (RenderEditable is a special case here because it's expected for the user to edit the text, and we never want that to wobble.)

/cc @GaryQian Does your work fix this?

The hacky fix for this has not been landed as it introduces a new bug where the text box heights and line heights jump around as you type. I am working on a more permanent solution by providing a richer leading/line height system.

https://github.com/flutter/flutter/pull/27612 should improve this behavior, but doesn't solve it in all cases.

I can't reproduce this on the latest master 1.21.0-6.0.pre.38 with Android API 27, 28 or 30.

flutter doctor -v
[√] Flutter (Channel master, 1.21.0-6.0.pre.38, on Microsoft Windows [Version 10.0.18362.959], locale et-EE)
   • Flutter version 1.21.0-6.0.pre.38 at C:\Development\flutter_master
   • Framework revision 8e0eee9008 (8 hours ago), 2020-07-26 23:38:01 -0700
   • Engine revision 626244a72c
   • Dart version 2.9.0 (build 2.9.0-21.0.dev a3815b6590)

[√] Android toolchain - develop for Android devices (Android SDK version 30.0.0)
   • Android SDK at C:\Users\Isa\AppData\Local\Android\sdk
   • Platform android-30, build-tools 30.0.0
   • Java binary at: C:\Users\Isa\AppData\Local\JetBrains\Toolbox\apps\AndroidStudio\ch-0\193.6626763\jre\bin\java
   • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b01)
   • All Android licenses accepted.

[√] Chrome - develop for the web
   • Chrome at C:\Program Files (x86)\Google\Chrome\Application\chrome.exe

[√] Visual Studio - develop for Windows (Visual Studio Community 2019 16.6.4)
   • Visual Studio at C:\Program Files (x86)\Microsoft Visual Studio\2019\Community
   • Visual Studio Community 2019 version 16.6.30309.148
   • Windows 10 SDK version 10.0.18362.0

[√] Android Studio (version 4.0)
   • Android Studio at C:\Users\Isa\AppData\Local\JetBrains\Toolbox\apps\AndroidStudio\ch-0\193.6626763
   • Flutter plugin version 47.1.2
   • Dart plugin version 193.7361
   • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b01)

[√] VS Code (version 1.47.2)
   • VS Code at C:\Users\Isa\AppData\Local\Programs\Microsoft VS Code
   • Flutter extension version 3.12.2

[√] Connected device (6 available)
   • SM G950F (mobile)                  • ce12171c51cc001c03 • android-arm64  • Android 9 (API 28)
   • sdk gphone x86 (mobile)            • emulator-5554      • android-x86    • Android 11 (API 30) (emulator)
   • Android SDK built for x86 (mobile) • emulator-5556      • android-x86    • Android 8.1.0 (API 27) (emulator)
   • Windows (desktop)                  • windows            • windows-x64    • Microsoft Windows [Version 10.0.18362.959]
   • Web Server (web)                   • web-server         • web-javascript • Flutter Tools
   • Chrome (web)                       • chrome             • web-javascript • Google Chrome 84.0.4147.89

• No issues found!

Closing as fixed. Feel free to comment with your case and flutter doctor -v if this persists and I'll reopen.


Merge tokenization-benchmark to PyThaiNLP

from tokenization-benchmark, We will merge tokenization benchmark to PyThaiNLP.
tokenization-benchmark Developed by @heytitle

One issue that might arise is the fact that the module has a CLI interface. We might need to write a wrapper from PyThaiNLP for using the interface.

Done https://github.com/PyThaiNLP/pythainlp/pull/248


Revert "Maybe try dartsass-rails again"

Reverts MushroomObserver/mushroom-observer#2118

coverage: 94.443% (+0.05%) from 94.391%
when pulling d3d0a3fd666ac32716ae08eb2c8024747dd28a63 on revert-2118-nimmo-dartsass-rails
into 7516bf701ecd2e9c5cc48b14f295b42762fb7125 on main.


Update meta description

Update meta description for index page.

@DaniHalfin

@DaniHalfin - PR is ready for final review. This is related to the SEO project.
Thank you.
cc: @kenwith


Added Download Progress Bar, working but structural problems.

Added Download Progress Bar, working but structural problems due to structuring of the app. The UI needs to be fixed before adding the progress bar.
Reference: #6

@ArchismanKarmakar released on https://github.com/luisflorido/wallhaven-desktop/releases/tag/v1.0.5


Support Scoring models with Cohere to allow Reranking

Fixes https://github.com/quarkiverse/quarkus-langchain4j/issues/336
The test the that actually uses Cohere (CohereScoringModelTest): I've added COHERE_API_KEY to the repository secrets, so it should, just like the Pinecone tests, run nightly. It's a free key so hopefully we won't get locked out for using it too much.
Not sure if we want to also supply multiple models here? Right now it allows configuring one Cohere scoring model. But I can support multiple.

Also CC @langchain4j

Not sure if we want to also supply multiple models here? Right now it allows configuring one Cohere scoring model. But I can support multiple.

I think we can do that later

@jmartisk which other rerankers do you have in mind? I plan to at least add integration with jina (also for embeddings), support cross-encoders in in-process embedding models and potentially add ColBERT, but that will require much more time and is not clear yet whether it will be useful.


XML to_s error

I am trying to write XMLs to a file and I am getting this error.
Invalid memory access (signal 11) at address 0x0
[0x10e782916] *Exception::CallStack::print_backtrace:(Int32 | Nil) +118
[0x10e738a0e] __crystal_sigfault_handler +318
[0x7fff203b7d7d] _sigtramp +29
[0x7fff2720f3b4] xmlFindCharEncodingHandler +176
[0x7fff272776aa] xmlNewSaveCtxt +64
[0x7fff27277889] xmlSaveToIO +31
[0x10e8bcaf6] *XML::Node#to_xml<IO::FileDescriptor>:IO::FileDescriptor +358
[0x10e8bc986] *XML::Node#to_s<IO::FileDescriptor>:Nil +6
[0x10e8058a5] *IO::FileDescriptor@IO#<<<XML::Node>:IO::FileDescriptor +37
[0x10e805867] *IO::FileDescriptor@IO#puts<XML::Node>:Nil +39
[0x10e743819] *puts<XML::Node>:Nil +57
[0x10e8f454a] *Braintree::CLI::DisputeCreateCommand::resolve<Braintree::Operations::Dispute::Sandbox::OpenDispute.class, Braintree::CLI>:NoReturn +2378
[0x10e8f3b78] *Braintree::CLI::DisputeCreateCommand::run<Braintree::CLI>:NoReturn +280
[0x10e89be72] *Braintree::CLI#run:(Bool | Nil) +5042
[0x10e89a951] *Braintree::CLI::run:(Bool | Nil) +17
[0x10e723b2f] __crystal_main +1775
[0x10e9062c6] *Crystal::main_user_code<Int32, Pointer(Pointer(UInt8))>:Nil +6
[0x10e90612c] *Crystal::main<Int32, Pointer(Pointer(UInt8))>:Int32 +44
[0x10e72f166] main +6

When I try to reduce this bug down it it starts working again.  Here are the versions of XML and Crystal but are the most updated versions on homebrew.
$ crystal --version
Crystal 0.36.1 (2021-02-02)

LLVM: 11.0.1
Default target: x86_64-apple-macosx

$ brew info libxml2
libxml2: stable 2.9.10 (bottled), HEAD [keg-only]
GNOME XML library
http://xmlsoft.org/
/usr/local/Cellar/libxml2/2.9.10_2 (280 files, 10.6MB)
...

Here is a branch with the section of code that is raising the error.  Also it works when parsed as HTML.
https://github.com/wontruefree/braintree/blob/bug_xml_parse/src/cli/dispute_create_command.cr#L14-L17

What's the text?

Put another way: could you provide code that I can copy/paste into a file, run it and see it break?

I have been unable to reproduce this in a smaller code sample if I read this from a file or make it a string literal in any way it seems to work and when I use a client it fails.  I will try to get a smaller sample.
Here is a sample of the full XML
https://gist.github.com/wontruefree/c9d05934c80d71e2d128c5530a93bcec

This still breaks for me but now only breaks on one macbook pro and not another.  I have not been able to reproduce when not making remote calls so it is hard to make a code sample for this.  I am closing this to keep the issues clean.  But this might be a problem introduced with 0.36.x

I was able to narrow this down without making web requests.  It seems like certain ordering of xpath methods followed by a puts breaks the program.  Here is a link to the working and broke code samples.
Here is the broken sample. https://gist.github.com/wontruefree/f7efd84b0cbd4eb1d2f1f32bfe249e2a#file-xml-bug
$ crystal tmp.cr
<dispute>
      <id>dpp74szzb5srtw4d</id>
      <global-id>ZGlzcHV0ZV9kcHA3NHN6emI1c3J0dzRk</global-id>
      <amount>9363.36</amount>
      <amount-disputed>9363.36</amount-disputed>
      <amount-won>0.00</amount-won>
      <case-number>CB328430743124</case-number>
      <created-at type="datetime">2021-02-05T04:40:16Z</created-at>
      <currency-iso-code>USD</currency-iso-code>
      <date-opened type="date">2021-02-05</date-opened>
      <date-won nil="true"/>
      <processor-comments nil="true"/>
      <kind>chargeback</kind>
      <merchant-account-id>kilmercorp</merchant-account-id>
      <reason>fraud</reason>
      <reason-code>62</reason-code>
      <reason-description nil="true"/>
      <received-date type="date">2021-02-05</received-date>
      <reference-number nil="true"/>
      <reply-by-date type="date">2021-02-10</reply-by-date>
      <processor-reply-by-date type="date">2021-02-14</processor-reply-by-date>
      <response-deadline type="datetime">2021-02-09T05:59:59Z</response-deadline>
      <status>open</status>
      <updated-at type="datetime">2021-02-05T04:40:16Z</updated-at>
      <original-dispute-id nil="true"/>
      <evidence type="array"/>
      <status-history type="array">
        <status-history>
          <disbursement-date type="date">2021-02-05</disbursement-date>
          <effective-date type="date">2021-02-05</effective-date>
          <status>open</status>
          <timestamp type="datetime">2021-02-05T04:40:16Z</timestamp>
        </status-history>
      </status-history>
      <transaction>
        <id>fj6df5n1</id>
        <global-id>dHJhbnNhY3Rpb25fZmo2ZGY1bjE</global-id>
        <amount>9363.36</amount>
        <created-at>2021-02-05T04:40:15Z</created-at>
        <installment-count nil="true"/>
        <order-id nil="true"/>
        <purchase-order-number nil="true"/>
        <payment-instrument-subtype>Visa</payment-instrument-subtype>
      </transaction>
    </dispute>
Invalid memory access (signal 11) at address 0x0
[0x100fa8786] *Exception::CallStack::print_backtrace:(Int32 | Nil) +118
[0x100f8494e] __crystal_sigfault_handler +318
[0x7fff203b7d7d] _sigtramp +29
[0x7fff2720f3b4] xmlFindCharEncodingHandler +176
[0x7fff272776aa] xmlNewSaveCtxt +64
[0x7fff27277889] xmlSaveToIO +31
[0x10100e366] *XML::Node#to_xml<IO::FileDescriptor>:IO::FileDescriptor +358
[0x10100e1f6] *XML::Node#to_s<IO::FileDescriptor>:Nil +6
[0x100ffe075] *IO::FileDescriptor@IO#<<<XML::Node>:IO::FileDescriptor +37
[0x100ffe037] *IO::FileDescriptor@IO#puts<XML::Node>:Nil +39
[0x100f85189] *puts<XML::Node>:Nil +57
[0x100f74f6b] __crystal_main +4427
[0x101014b06] *Crystal::main_user_code<Int32, Pointer(Pointer(UInt8))>:Nil +6
[0x10101496c] *Crystal::main<Int32, Pointer(Pointer(UInt8))>:Int32 +44
[0x100f80566] main +6

And the other one prints out he XML.

That code runs without failure for me. Same libxml2 version, but on linux. Crystal latest is linked against LLVM 10, but master build is linked against LLVM 11.1.
$ crystal --version
Crystal 0.36.1 [c3a3c1823] (2021-02-02)

LLVM: 10.0.0
Default target: x86_64-unknown-linux-gnu

$ bin/crystal --version
Using compiled compiler at .build/crystal
Crystal 1.0.0-dev [de9351f05] (2021-02-20)

LLVM: 11.1.0
Default target: x86_64-unknown-linux-gnu

$ brew info libxml2
libxml2: stable 2.9.10 (bottled), HEAD
GNOME XML library
http://xmlsoft.org/
/home/linuxbrew/.linuxbrew/Cellar/libxml2/2.9.10_2 (281 files, 12.5MB)
...

So looks like it only fails on macos. Can anyone reproduce it?
Could also be worth trying with an older Crystal compiler and/or other libxml2 versions.
This could likely a bug in libxml2, though (or iconv or whatever would be involved).

Unable to repro osx crystal 0.36.1, llvm 11.0.1, libxml2 2.9.10
$ crystal --version
Crystal 0.36.1 (2021-02-02)

LLVM: 11.0.1
Default target: x86_64-apple-macosx

$ brew info libxml2
libxml2: stable 2.9.10 (bottled), HEAD [keg-only]
GNOME XML library
http://xmlsoft.org/
/usr/local/Cellar/libxml2/2.9.10_2 (280 files, 10.5MB)
  Poured from bottle on 2021-01-26 at 16:37:51
From: https://github.com/Homebrew/homebrew-core/blob/HEAD/Formula/libxml2.rb
License: MIT

$ crystal run --verbose foo.ign.cr
cc _main.o D-ir.o C-rystal5858S-ystem5858D-ir.o ... stripped ... E-xception5858C-allS-tack5858R-epeatedF-rame.o C-rystal.o -o /Users/bcardiff/.cache/crystal/crystal-run-foo.ign.tmp  -rdynamic -L/usr/local/lib -L/usr/local/Cellar/libxml2/2.9.10_2/lib -lxml2 -lpcre -lgc -lpthread /usr/local/Cellar/crystal/0.36.1_2/src/ext/libcrystal.a -L/usr/local/Cellar/libevent/2.1.12/lib -levent -liconv -ldl
<dispute>
      <id>dpp74szzb5srtw4d</id>
      <global-id>ZGlzcHV0ZV9kcHA3NHN6emI1c3J0dzRk</global-id>
      <amount>9363.36</amount>
... stripped ...
  <pin-verified type="boolean">false</pin-verified>
</transaction>

So I can reproduce this on my macbookpro(2015) but not on a macbookpro(2019).
Same versions of crystal and libxml2.

@wontruefree can you check the output of $ pkg-config libxml-2.0 --libs ?
If it is
$ pkg-config libxml-2.0 --libs
-lxml2

it means you are not using brew libxml but the default system one.
if you do export PKG_CONFIG_PATH="/usr/local/opt/libxml2/lib/pkgconfig:$PKG_CONFIG_PATH" the output should be
$ pkg-config libxml-2.0 --libs
-L/usr/local/Cellar/libxml2/2.9.10_2/lib -lxml2

With crystal run --verbose you will be able to see which link commands are used near the -lxml2

The output was:
$ pkg-config libxml-2.0 --libs
-lxml2

I used export PKG_CONFIG_PATH="/usr/local/opt/libxml2/lib/pkgconfig:$PKG_CONFIG_PATH" rebuild crystal and cleared the cache and I am still getting the same issue.
currently the pkg-config output is this.
$ pkg-config libxml-2.0 --libs
-L/usr/local/Cellar/libxml2/2.9.10_2/lib -lxml2

I had this same issue, and it was fixed with (Ary's suggestions):
export PATH="/opt/homebrew/opt/libxml2/bin:$PATH"
export PKG_CONFIG_PATH="${PKG_CONFIG_PATH:+$PKG_CONFIG_PATH:}/opt/homebrew/opt/libxml2/lib/pkgconfig"

(/opt/hombrew/opt/libxml2 is where I have my Brew's libxml2)
So it's a problem with certain libxml2 versions. Let's leave this open for reference, but for what it's worth it's fixed.

If we so desire, we could probably fix this in the Crystal brew formula. E.g. something like what this formula is doing:
https://github.com/Homebrew/homebrew-core/blob/438d35c67eee09dec612f58eabdef0360e72a92d/Formula/p/pixz.rb#L31
Then we could always be sure pkg-config is aware of the brew implementation of it.

I found that if we call LibXML.xmlInitParser even on non-Win32 systems then the crash goes away. Can anyone else confirm this?

That fixes it for me too yea. If that doesn't have any other downsides then is prob the better solution. Esp given it seems we do not actually have libxml2 as a dependency of crystal brew package anyway.


cmake: check BOARD before setting default

Currently the BOARD variable is not checked before setting the
default value. This causes issues in a multi image context.
Fix this by checking if the BOARD variable is set before
setting it to its default value.
Signed-off-by: Håkon Øye Amundsen<EMAIL_ADDRESS>

Could this go upstream as is?

Yes

@ioannisg: IMHO it should go there.

No, because in a non-multi image context it doesn't make sense to check if BOARD is set.

No, because in a non-multi image context it doesn't make sense to check if BOARD is set.

I see. Then, please, address my comment about making it more clear that this is only applicable when building multi-image. :)

the PR upstream is opened here
https://github.com/JuulLabs-OSS/mcuboot/pull/461
Due to tight timeline I was hoping to get this in downstream and then be out of sync until the next upmerge.

address my comment about making it more clear that this is only applicable when building multi-image.

We have a lot of code downstream that is only applicable when building multi-image. I don't think we want to wrap all of it with comments.

No, because in a non-multi image context it doesn't make sense to check if BOARD is set.

I see. Then, please, address my comment about making it more clear that this is only applicable when building multi-image. :)

Also, please, explain the rationale in the comment that precedes the change.

address my comment about making it more clear that this is only applicable when building multi-image.

We have a lot of code downstream that is only applicable when building multi-image. I don't think we want to wrap all of it with comments.

As far as I understood, this change is only needed when we build a Zephyr image as part of multi-image build. Is there a way to know "inside the build" that we are building Zephyr with multi-image support? A Kconfig or CMake setting, perhaps? If that is the case, I think it make sense to wrap the
if (NOT BOARD)
  set(BOARD qemu_x86)
endif()

with this conditional.
Adding a comment is optional, if the code itself is self-explanatory

See the comment I added in the code @ioannisg


Add [Instagram] badge

See  #2120.

Messages

:book:
:sparkles: Thanks for your contribution to Shields, @PyvesB!

  Generated by :no_entry_sign: dangerJS against 999e6e6e5082e60855a61f1cfab3cd94f27fe84e

Result on the review app:

Do not merge: we've got a problem which I've documented on the linked issue:
https://github.com/badges/shields/issues/2120#issuecomment-554675754


训练疑问？

你好，感谢你的工作，我在引用你的工作时有一个疑问。想请教你。请问为什么有两个模型，且分别训练，我查看了您的代码，看起来他们好像没有关系啊？

大佬借你的模型一用，我数据集都下载不到，老师课设要崩了 谢谢谢谢谢谢谢谢谢

Dear author:
Thank you for your contribution in this work,I want to ask you some question about train_CT_MCCauSSL.py. I have run the code myself.But there is a huge gap between its performance and the indicators in your paper.I think it may be a problem with my own data processing. Can you upload your preprocessed pancreas-CT dataset?

   你好，感谢你的工作，我在引用你的工作时有一个疑问。想请教你。请问为什么有两个模型，且分别训练，我查看了您的代码，看起来他们好像没有关系啊？

你好~，这两个模型的地位是对等的，就是有一系列半监督的工作是co-training架构的，里面就会有n个模型/分支然后分别训练，同时又互相监督。

Dear author: Thank you for your contribution in this work,I want to ask you some question about train_CT_MCCauSSL.py. I have run the code myself.But there is a huge gap between its performance and the indicators in your paper.I think it may be a problem with my own data processing. Can you upload your preprocessed pancreas-CT dataset?

You can also try to apply the CauSSL module to the current baseline implemented by yourself which has already obtained a reasonable performance.

Dear author: Thank you for your contribution in this work,I want to ask you some question about train_CT_MCCauSSL.py. I have run the code myself.But there is a huge gap between its performance and the indicators in your paper.I think it may be a problem with my own data processing. Can you upload your preprocessed pancreas-CT dataset?

Thank you for your question. You can also try to first apply the CauSSL module to the current baseline implemented by yourself which has already obtained a reasonable performance.


Inlay Hints eventually stop updating after long enough sessions

Here's a gif of what I mean:

It works fine when nvim is just started, but fails afterwards.
You can see the same exact thing here if you watch for the next minute or two the streamer just has to reload the workspace to get inlay hints to update.
this is my setup.

#230


Is it any different from DeepChem in particular

DeepChem implements models for molecular machine learning; DeepPurpose is a framework for compound and protein modeling.


[MRTK Shell Parity] [Bounding Box] In Flattened mode, the border visualization is too thin and almost invisible

Describe the bug
In Flattened mode, the border visualization is too thin and almost invisible
Part of #4200 UX Controls Parity with HoloLens 2 Shell
To reproduce
In HandInteractionExamples scene, hover flattened examples (slate, MRTK plane) with hand ray or finger to make the border visible.
Expected behavior
Shows solid border similar to the Bounding Box in the 3D objects
Screenshots

Branch
mrtk_development

Fixed


Graphics/cpt 30 provide directional point spot lights

Working on providing C++ support for spot, point, and directional lights. I've pulled out some of the hard-coded light code in GameTechRenderer to allow them to be added as variables instead, but at present only the original point-light will function. This is because shader support for each of these types is out of scope of this task, because it will be done with deferred rendering, which will require rewriting the entire rendering/shader pipeline. I don't want to bog down this task in that much more complex one, so this one just covers C++ support for the idea of multiple different lights ... that we can't turn on just yet!

Fixed merge conflicts


Inserting an Image in google cloud storage using php api on lamp

$storage->objects->insert() not showing any response or error.
object not inserting in storage

Hey there @anuj-njoshi!
It sounds like you may be using google/apiclient, which is a bit different than what we are trying to offer with our library here.
If you'd like to give this library a go instead, you will need to run:
composer require google/cloud
From there we have an example of how to get started uploading an object to a bucket right here.
Let us know if there's anything else we can help provide to get things moving along smoothly for you.
Best,
Dave

I am using Google_Service_Storage_StorageObject api it's working in localhost
but problem is it on google compute engine
$resp = $storage->objects->insert($buket, $obj, array('name' => $file_name, 'data' => file_get_contents("img/". $filename), 'uploadType' => 'media','mimeType' => 'image/png')
);
the error is above calling method

Hi @anuj-njoshi,
As Dave said above, the code you described is part of google/apiclient, not google/cloud (this library). Issues with google/apiclient should be directed to the proper repository.
A few things to try before you open an issue over there:

Are you authenticated properly? This may not be working the same way on Compute Engine as on localhost, so be sure to verify again.
Do other API calls work? Try calling a different service, then try making a different storage API call.
Make sure error reporting is turned all the way up in PHP, or check your application's error log for potential problems.

If none of those things gives you any indication of what the problem is, then perhaps a new issue in the correct location is in order.
Good luck!


Why so many uploads on thunderstore?

I get the second one as it starts from v0.3.1
Is 'RPGkamikazeSV' also your upload? Just a bit confused is all.

That's not mine, kamikaze isn't my upload xD

0.o


Make deploys zero-downtime

We lean on the cf-blue-green-deploy[1] to make this as easy as
possible.
[1] https://github.com/bluemixgaragelondon/cf-blue-green-deploy

With our current deployment in CodeDeploy we deploy to one instance at a time, and wait for the validate.sh script to complete before moving on to the next deploy. Do we still do this with PaaS? Regarding the blue-green plugin, we're not passing any tests to run so the only reason we're using it is to automate the process of deploying, swapping out the old for the new and cleaning the old?

On validate.sh: the manifest.yaml specifies a healthcheck: /records—I'd expect this to cause the deploy to fail and drop out but I still need to verify what actually happens.
And yes, the blue-green plugin eliminates the need to do something like this.
And you're right we have no smoke tests at the moment—we should probably create some.

@karlbaker02 I've run through a couple of failure scenarios and discovered the health check wasn't actually working—I've fixed that in the manifest and failed deploys work like you'd expect (ie. the deploy stops, is deteceted as a failure and the original app still recieves all the traffic).

Discussed above issues with Sam.


derived class with additional data field are missing it

The following yaml description results in the alert model missing the additional data field.
This is because it's conflicting with the additional data field the parent model gets from standard generation.
This method needs to have a special case to handle that, and when the custom property name is "additionalData" add a prefix like we do when some fields conflict with native language primitives
https://github.com/microsoft/kiota/blob/b3bd7a0b8296a070d726656e2ee637d5fd2cf31f/src/Kiota.Builder/KiotaBuilder.cs#L1185
openapi: 3.0.1
info:
  title: OData Service for namespace microsoft.graph
  description: This OData service is located at https://graph.microsoft.com/v1.0
  version: v1.0
  x-ms-generated-by:
    toolName: Microsoft.OpenApi.OData
    toolVersion: <IP_ADDRESS>
servers:
  - url: https://graph.microsoft.com/v1.0
paths:
  '/security/alerts_v2/{alert-id}':
    description: Provides operations to manage the alerts_v2 property of the microsoft.graph.security entity.
    get:
      tags:
        - security.alert
      summary: Get alert
      description: Get the properties and relationships of an alert object.
      externalDocs:
        description: Find more info here
        url: https://learn.microsoft.com/graph/api/security-alert-get?view=graph-rest-1.0
      operationId: security.GetAlerts_v2
      responses:
        2XX:
          description: Retrieved navigation property
          content:
            application/json:
              schema:
                $ref: '#/components/schemas/microsoft.graph.security.alert'
      x-ms-docs-operation-type: operation
components:
    microsoft.graph.entity:
      title: entity
      required:
        -<EMAIL_ADDRESS>      type: object
      properties:
        id:
          type: string
          description: The unique identifier for an entity. Read-only.
<EMAIL_ADDRESS>          type: string
   microsoft.graph.security.alert:
      allOf:
        - $ref: '#/components/schemas/microsoft.graph.entity'
        - title: alert
          required:
            -<EMAIL_ADDRESS>          type: object
          properties:
            actorDisplayName:
              type: string
              description: The adversary or activity group that is associated with this alert.
              nullable: true
            additionalData:
              anyOf:
                - $ref: '#/components/schemas/microsoft.graph.security.dictionary'
                - type: object
                  nullable: true

Additionally, the unit test could be added here similar to this test but with the provided repro OpenAPI description.
This issue has originally been reported by @tiananguyen (MSFT) who's currently checking with her management how to proceed (they are blocked by the bug)


dojoup: add missing check on jq

jq is required to download binaries from github

Liberato on Discord got the error message but didn't know he needed to brew install jq, could we maybe add this in the error message?

i do have it in the debug part of the book, but agree with removing it


add jspm hints

again, remove the es6 when the code is es5

ok, that works cleanly now for me.

Please keep PRs focused. If you need this stuff immediately, please just use your fork. Otherwise, planning to fix this and angular-c-c tonight.

I don't think you understand.... regardless of es6 vs. es5, I still need the list of dependencies to be declared so that jspm manages things correctly.

What isn't focused about this pr?

Why does jspm not get angular from npm? Haven't used it before so I need an explanation.

I'd like to get back on a constructive track here. I understand that JSPM needs hints about ES6. I'm going to convert this to ES5 so that won't matter.
What I meant by unfocused is that you're changing the package in other ways that don't seem to be related. I was under the impression that JSPM worked fine with npm packages. If the additions to the package you're proposing re: dependencies are required for things to work, I'd much prefer you just use a fork.
I don't intend to add jspm hints across every package I have and so I'd rather not do it anywhere if I'm not going to do it everywhere.
Either way, I'm still curious to hear why JSPM needs these hints so when other people ask me about it I can give them an informed answer.

jspm needs to know what the dependencies for a project are so that it can build a dependency tree. This tree is used by systemjs to load files in the correct order in the browser and prevents people from getting the errors that other user was getting (the issue I commented on with regards to requirejs).
I'm not a fan of browserify because I like to be able to debug my code in the browser as separate files. I also don't like the build step of compiling a giant app during development. webpack is nice, but I'd rather follow the es6 standards. UMD, AMD, CommonJS... are all dead tech as far as I'm concerned. IMHO, ES6 modules are the future. systemjs / babel / jspm is the right path for making all that happen right now.
jspm doesn't just install npm projects. It can also install github projects. IMHO, github is a better distribution mechanism for people who use jspm because that way projects can be easily forked. Also, there is no cross repo dependency resolution. For this reason, jspm needs to be told by the project where to get its dependencies (github or npm or somewhere else). This needs to happen all the way down the dependency tree. So, if I install a project from github, it needs to have the jspm dependencies block specified so jspm knows where it can get all of the projects dependencies (all the way down the tree).
 Hopefully jspm is one of the last package management systems anyone needs for the next few years. It isn't perfect, but it is the best one we have right now and is far better than bower. npm isn't a contender because it doesn't know about ES6 code (yet) and doesn't (yet) do a good job of targeting browser only code.
jspm has a system for doing overrides and 'fixing' projects called the registry, but you have so many inter-dependencies that walking that whole tree to jspm how to grab your code is more difficult than just rewriting things. I'm also a fan of ES6, so I'd rather use code that takes advantage of the new language features.
I hope that is more constructive for you.  I started off with a PR and not an issue, right? :smile:  That said, don't just close someone's PR and thank them. At least be open to a discussion first.

Got it. What I value most about npm is the ability to use small, focused packages. I've got no plan personally to use jspm so I definitely can't justify maintaining a parallel list of deps. If there's something smaller I can do I'm happy to take PRs. Otherwise definitely fork away!


Cluster Provisioning diagram not matching the terrafrom deployment

Hi all,
The pre-provisioning is setting up the UDR routes. And the cluster provisioning diagram is also mentioning that egress traffic is going through the AZ FW.
But the terraform files don't have that configuration.
As far as I can see terraform is deploying a cluster with "Standard Load Balancer" and "VMSS" which implies the SLB with a public IP address. Would the UDR work in that case, as we would have a LB with public IP that is overriding the UDR?
Im guessing the outbound_type is missing in the terraform config. https://www.terraform.io/docs/providers/azurerm/r/kubernetes_cluster.html#outbound_type
https://github.com/Azure/sg-aks-workshop/blob/master/cluster-pre-provisioning/README.md
https://github.com/Azure/sg-aks-workshop/blob/master/cluster-provisioning/README.md
https://docs.microsoft.com/en-us/azure/aks/egress-outboundtype
Regrads,
Zarko

Hi @zarkoc, the UDR setup during pre-provisioning overrides all egress traffic. The UDR directs all  AKS subnet traffic, <IP_ADDRESS>/0, to the Azure Firewall. If the UDR and Azure Firewall were not there, you are correct, all traffic would flow through the SLB with PIP.


Hue Motion Sensors reports 0,0001 lux instead of just 0

Hi,
I have noticed that the Hue motion sensors which i have connected to a Conbee 2 gateway report the lux level as 0,0001 lux in the Home app instead of just 0. The deconz REST api reports the correct values of:
"lightlevel": 0,
"lux": 0

Can this be fixed?

Actually, the REST API doesn't report the correct values; a lightlevel of 0 corresponds to 0.0001 lux, see section 2.7.1 in https://developers.meethue.com/develop/hue-api/supported-devices/.

Ok, i understand. But when i got the hue motion sensors connected to my hue bridge with the default home integration from philips, they never reported a lux value of 0,0001. So this is something new which i straight noticed when i started using Conbee 2.
With the hue bridge i think the lowest was 1 lux. And also i find the 0,0001 value really odd and it doesn't make sense, so why not just show it as 0 lux?

Neither the sensor nor the Hue API reports lux; they only report lightlevel.
The Hue bridge would have to translate the lightlevel value to lux for HomeKit, just like homebridge-hue.  I don't think I ever looked how the Hue bridge does this translation

So this is something new which i straight noticed when i started using Conbee 2.

Actually homebridge-hue has been supporting the motion sensor in HomeKit long before the Hue bridge has.  So the lux value of 0 is actually something new, contradicting their own documentation.

Ok. So you think the value of 0,0001 lux is ok and it should stay like that?

It's the technically correct representation of what the sensor reports.  I was pleasantly surprised that Home and Eve would actually display this value; usually they cut off decimals to a single one or none at all, see e.g. temperature and humidity.

I understand that it is technically correct to display the value. But does it really makes sense for the normal user to see 0,0001 lux instead of just 0?

Honestly, I have no clue.  I don't know any normal users.  I like to think that Apple do, and the fact that Home displays this value is good enough for me.  I base my home automation on HomeKit, so I don't have to deal with the UI.
If I ever were to meet a normal user, I would strongly advice them to buy devices that natively support HomeKit, stay clear of: homebridge; of any multi-vendor ZigBee network (use deCONZ only for dresden elektronik devices); and of a developer's platform like GitHub.

I get your point, but what i don't understand what value you or any other user has from showing 0,0001 lux instead of just 0. This 0,0001 value is just confusing from my point of view and it is unnecessary.


Default related bug fixes.

Function at default are not fully qualified as the right name hint is not passed and used when there is a function - fixed that.
We don't create the deferredStub for function at param scope but we were trying to use m_currentDeferredStub when we are parsing functions at paramscope (inner function of the function at param scope). Using that  m_currentDeferredStub is plain wrong for the paramscope as we haven't created any stub for them so fixed that by setting m_currentDeferredStub to null when the current function is enclosed within param scope. (Unfortunately there was no smaller repro available to this - so I am not adding unittest)

@aneeshdk - could you look at this one?

LGTM


Add test to sl-date-range-picker for helpText

There should be a test that verifies that helpText is undefined by default and that no dom element is created, as well as verify the correct element is created when helpText is set

https://github.com/softlayer/sl-ember-components/pull/412 will address the test about the correct element being created, so this issue only needs to test that helpText is passed along.

Actually, helpText isn't being passed along, it's an element in the date range picker. I missed testing for it in #210

Replaced by https://github.com/softlayer/sl-ember-components/issues/455


Crossing between Railways (dissued) and roads should generate a warning

The crossing between a railway dissused (abandoned) and any road (from tracks to Highways) should generate a warning to share a node with crossing (level_crossing), not becuase there is danger of an incoming train, but becuase normally the rails are still there and becomes an obstacle in the way, that navigation programs should consider.
Thanks

@jjiglesiasg iD worked this way when we initially added the crossing warning. But in many countries mappers use railway=abandoned to map rail lines where the rails have been removed, so in these cases there are no level crossings. This is an OSM tagging problem where it's ambiguous whether or not any rails are there. You can use railway=disused if you want to be sure data consumers will know rails exist.


Question - Unable to get an OpenVAS scan working.

Hi,
I'm running into some problems setting up seccubus on a test install.
I'm running on 14.04.4 LTS, installed OpenVAS 8 from this PPA https://launchpad.net/~mrazavi/+archive/ubuntu/openvas and the openvas-client though "default" apt-get.
Both the OMP and Client scans are unable to run.
The Client problem as far as I could tell this might be caused by since I'm using an older version (2.0) of the client which uses the OTP 1.0 Protocol which isn't supported by OpenVAS 8. Might be horrible wrong about that though.
I have no idea about the OMP, is it not supported for OpenVAS8?
Any help getting seccubus setup would be really appreciated since using it would probably safe me a lot of time in the long run.

root@OpenVASUbuntu:/opt/seccubus$ dpkg -l | grep openvas
ii  libopenvas8                         8.0.6-2                             amd64        remote network security auditor - shared libraries
ii  openvas                             6.0.7-1                             amd64        remote network security auditor - metapackage
ii  openvas-cli                         1.4.3-1                             amd64        remote network security auditor - cli
ii  openvas-client                      2.0.5-1.1                           amd64        Remote network security auditor, the client
ii  openvas-gsa                         6.0.9-1                             amd64        remote network security auditor - web interface
ii  openvas-manager                     6.0.7-1                             amd64        remote network security auditor - manager
ii  openvas-scanner                     5.0.5-1                             amd64        remote network security auditor - scanner

root@OpenVASUbuntu:/opt/seccubus$ cpan -l
OpenVAS::OMP    0.04

root@OpenVASUbuntu:/opt/seccubus# bin/do-scan -w "Testing Yo" -s "OpenVAS-OMP"
Starting scan 'OpenVAS-OMP' from workspace 'Testing Yo'
Sending notifications for scan start...
0 notification(s) sent
cmd: /opt/seccubus/scanners/OpenVAS6/scan --workspace 'Testing Yo' --scan 'OpenVAS-OMP' -s <IP_ADDRESS> -u admin> --pw ******** --policy Full and very deep ultimate --targetip <IP_ADDRESS>

Sending notifications for scan end...
0 notification(s) sent

Done

root@OpenVASUbuntu:/opt/seccubus# bin/do-scan -w "Testing Yo" -s "OpenVAS-OMP" -v
Starting scan 'OpenVAS-OMP' from workspace 'Testing Yo'
Sending notifications for scan start...
0 notification(s) sent
cmd: /opt/seccubus/scanners/OpenVAS6/scan --workspace 'Testing Yo' --scan 'OpenVAS-OMP' -s <IP_ADDRESS> -u admin> --pw ******** --policy Full and very deep ultimate --targetip <IP_ADDRESS>
 -v
sh: 2: -v: not found
Sending notifications for scan end...
0 notification(s) sent
cmd: /opt/seccubus/scanners/OpenVAS6/scan --workspace 'Testing Yo' --scan 'OpenVAS-OMP' -s <IP_ADDRESS> -u admin> --pw ******** --policy Full and very deep ultimate --targetip <IP_ADDRESS>
 -v

Done

root@OpenVASUbuntu:/opt/seccubus# bin/do-scan -w "Testing Yo" -s "OpenVAS-Client" -v
Starting scan 'OpenVAS-Client' from workspace 'Testing Yo'
Sending notifications for scan start...
0 notification(s) sent
cmd: /opt/seccubus/scanners/OpenVAS/scan --workspace 'Testing Yo' --scan 'OpenVAS-Client' -s <IP_ADDRESS> --port 9390 -u admin --rc /etc/seccubus/safe.openvasrc.example  --hosts /tmp/seccubus.hosts.2031 --pw ''*****''  -v
OpenVAS found in /usr/bin/OpenVAS-Client
Timestamp =<PHONE_NUMBER>3823
Starting scan
Execuing /usr/bin/OpenVAS-Client -c /etc/seccubus/safe.openvasrc.example -q <IP_ADDRESS> 9390 admin '*****' /tmp/seccubus.hosts.2031 '/tmp/seccubus.2034.nbe' -x
OpenVAS-Client : Unable to establish a connection to the remote host using the specified protocol version!

Scanning done, converting .nbe to html
Executing /usr/bin/OpenVAS-Client -c /etc/seccubus/safe.openvasrc.example -q -i '/tmp/seccubus.2034.nbe' -o '/tmp/seccubus.2034.html'

(OpenVAS-Client:2040): GLib-CRITICAL **: g_path_get_dirname: assertion 'file_name != NULL' failed
Segmentation fault (core dumped)

Converting .nbe to xml
Executing /usr/bin/OpenVAS-Client -c /etc/seccubus/safe.openvasrc.example -q -i '/tmp/seccubus.2034.nbe' -o '/tmp/seccubus.2034.xml'

(OpenVAS-Client:2043): GLib-CRITICAL **: g_path_get_dirname: assertion 'file_name != NULL' failed
Segmentation fault (core dumped)

Converting .nbe to IVIL
Executing perl -I/opt/seccubus/SeccubusV2 /opt/seccubus/bin/nbe2ivil --scanner=OpenVAS --workspace 'Testing Yo' --scan 'OpenVAS-Client' --timestamp=20160226153823 --infile '/tmp/seccubus.2034.nbe'
Unable to open /tmp/seccubus.2034.nbe at /opt/seccubus/bin/nbe2ivil line 74.

Importing ivil
Scan imported, adding files to scan OpenVAS-Client in workspace Testing Yo
Sending notifications for scan end...
0 notification(s) sent
cmd: /opt/seccubus/scanners/OpenVAS/scan --workspace 'Testing Yo' --scan 'OpenVAS-Client' -s <IP_ADDRESS> --port 9390 -u admin --rc /etc/seccubus/safe.openvasrc.example  --hosts /tmp/seccubus.hosts.2031 --pw ''*****''  -v
OpenVAS found in /usr/bin/OpenVAS-Client
Timestamp =<PHONE_NUMBER>3823
Starting scan
Execuing /usr/bin/OpenVAS-Client -c /etc/seccubus/safe.openvasrc.example -q <IP_ADDRESS> 9390 admin '*****' /tmp/seccubus.hosts.2031 '/tmp/seccubus.2034.nbe' -x
OpenVAS-Client : Unable to establish a connection to the remote host using the specified protocol version!

Scanning done, converting .nbe to html
Executing /usr/bin/OpenVAS-Client -c /etc/seccubus/safe.openvasrc.example -q -i '/tmp/seccubus.2034.nbe' -o '/tmp/seccubus.2034.html'

(OpenVAS-Client:2040): GLib-CRITICAL **: g_path_get_dirname: assertion 'file_name != NULL' failed
Segmentation fault (core dumped)

Converting .nbe to xml
Executing /usr/bin/OpenVAS-Client -c /etc/seccubus/safe.openvasrc.example -q -i '/tmp/seccubus.2034.nbe' -o '/tmp/seccubus.2034.xml'

(OpenVAS-Client:2043): GLib-CRITICAL **: g_path_get_dirname: assertion 'file_name != NULL' failed
Segmentation fault (core dumped)

Converting .nbe to IVIL
Executing perl -I/opt/seccubus/SeccubusV2 /opt/seccubus/bin/nbe2ivil --scanner=OpenVAS --workspace 'Testing Yo' --scan 'OpenVAS-Client' --timestamp=20160226153823 --infile '/tmp/seccubus.2034.nbe'
Unable to open /tmp/seccubus.2034.nbe at /opt/seccubus/bin/nbe2ivil line 74.

Importing ivil
Scan imported, adding files to scan OpenVAS-Client in workspace Testing Yo

Done

Hi,
If I loop at this line:
cmd: /opt/seccubus/scanners/OpenVAS6/scan --workspace 'Testing Yo' --scan 'OpenVAS-OMP' -s <IP_ADDRESS> -u admin> --pw ******** --policy Full and very deep ultimate --targetip <IP_ADDRESS>

I suspect that there should be quotes around 'Full and very deep ultimate'

Hey,
Thanks for the response.
Just tested it with quotes, no dice.
root@OpenVASUbuntu:/opt/seccubus# bin/do-scan -w "Testing Yo" -s "OpenVAS-OMP"
Starting scan 'OpenVAS-OMP' from workspace 'Testing Yo'
Sending notifications for scan start...
0 notification(s) sent
cmd: /opt/seccubus/scanners/OpenVAS6/scan --workspace 'Testing Yo' --scan 'OpenVAS-OMP' -s <IP_ADDRESS> -u admin> --pw ******** --policy 'Full and very deep ultimate' --targetip <IP_ADDRESS>

Sending notifications for scan end...
0 notification(s) sent
Done

root@OpenVASUbuntu:/opt/seccubus# bin/do-scan -w "Testing Yo" -s "OpenVAS-OMP"
Starting scan 'OpenVAS-OMP' from workspace 'Testing Yo'
Sending notifications for scan start...
0 notification(s) sent
cmd: /opt/seccubus/scanners/OpenVAS6/scan --workspace 'Testing Yo' --scan 'OpenVAS-OMP' -s <IP_ADDRESS> -u admin> --pw ******** --policy "Full and very deep ultimate" --targetip <IP_ADDRESS>

Sending notifications for scan end...
0 notification(s) sent

Done

Can you run the following?
cd /opt/seccubus/
/opt/seccubus/scanners/OpenVAS6/scan --workspace 'Testing Yo' --scan 'OpenVAS-OMP' -s <IP_ADDRESS> -u admin> --pw ******** --policy 'Full and very deep ultimate' --targetip <IP_ADDRESS> -v -v -v

This should get you more verbose error output.

Hi,
If I run that command the seccubus scan actually starts to run, only after its done there are no new Findings in the seccubus webpannel. This seems to be causes by the fact that the IVIL output is pretty much empty. The scan seems to have run fine when I looked at it in Greenbone.
seccubus.OV6.OpenVAS-OMP.20160315153331.12193.ivil
<?xml version="1.0" standalone='yes'?> <IVIL version="0.2"> 	<sender> 		<scanner_type>OpenVAS6</scanner_type> 		<timestamp>20160315153331</timestamp> 	</sender> </IVIL>
Full output of -v -v -v (filtered out some public IP's and passwords)
output.txt

Currently having the same issue. The scans run fine in the Greenbone interface, but the findings don't get converted to IVIL. The IVIL does show up in Seccubus. But only contains the following:
<?xml version="1.0" standalone='yes'?>
<IVIL version="0.2">
	<sender>
		<scanner_type>OpenVAS6</scanner_type>
		<timestamp>20160330090130</timestamp>
	</sender>
</IVIL>

My colleague and I fixed the problem regarding the Openvas scans not parsing correctly. Check it out at: https://github.com/schubergphilis/Seccubus_v2/pull/308/commits/6286d280b2db69476c508e1a447683e92db3214b

I'll hav a look on monday.

I did have a look and reworked the entire scripted based on @randakar 's remarks that the parsing of OMP results is currently way to fragile.
I found that the XML that was returned does validate with XML simple.
I'm about to merge #308 and my own changes, would you mind testing again?

The results are in this branch https://github.com/schubergphilis/Seccubus_v2/tree/issues/307-openvas-not-working

It does?
When I tried to feed that response to XMLin()
http://search.cpan.org/~grantm/XML-Simple-2.20/lib/XML/Simple.pm#XMLin()
I got a parser error. That's why I am using a regular expression here.
That script does need some work though:

Rather than using index() calls it should either feed the results to
XMLin() or something like that, or pass the responses through regular
expressions for parsing.
All requests need to be error checked. I suggest feeding them through a
subroutine that handles soap requests and implement some generic error
handling code there.
Some thought needs to be put into the case where the response content
required can simply not be found. Again, for all requests, not just this
specific case.

On Fri, Apr 8, 2016 at 9:24 AM, Frank Breedijk<EMAIL_ADDRESS>wrote:

I did have a look and reworked the entire scripted based on @randakar
https://github.com/randakar 's remarks that the parsing of OMP results
is currently way to fragile.
I found that the XML that was returned does validate with XML simple.
I'm about to merge #308
https://github.com/schubergphilis/Seccubus_v2/pull/308 and my own
changes, would you mind testing again?
—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
https://github.com/schubergphilis/Seccubus_v2/issues/307#issuecomment-207268449

--
"Don't only practice your art, but force your way into it's secrets, for it
and knowledge can raise men to the divine."
-- Ludwig von Beethoven

Would you mind trying the new version I put out there?
I am now checking (most of the) return codes.

I am curious to learn where/how it breaks.

I've pulled the changeset and updated the tree on that server.
Running an OpenVAS scan now.
It's not my project though. I'll notify my colleague, he should be able to
take a look at the results.
Regards,
Floris
On Fri, Apr 8, 2016 at 10:22 AM, Frank Breedijk<EMAIL_ADDRESS>wrote:

I am curious to learn where/how it breaks.
—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
https://github.com/schubergphilis/Seccubus_v2/issues/307#issuecomment-207307499

--
"Don't only practice your art, but force your way into it's secrets, for it
and knowledge can raise men to the divine."
-- Ludwig von Beethoven

Just ran a test with the new version. Good thing is the issue is fixed. After the scan the xml response is parsed correctly, converted to ivil and imported into Seccubus. The bad thing is that running a scan from the new version creates a new scan in my existing workspace. Example:
I run a new scan: 'do-scan -w Openvas -s <IP_ADDRESS>'. (Where <IP_ADDRESS> is the name of my scan).
It then runs the command: 'cmd: /opt/seccubus/scanners/OpenVAS6/scan --workspace 'Openvas' --scan '<IP_ADDRESS>' -s <IP_ADDRESS> -u admin --pw PASSWORD --policy 'Full and very deep ultimate' --targetip <IP_ADDRESS>' as normal. It also run the scan in Openvas correctly.
When the scan is done I go to the scan runs in Seccubus only to find my <IP_ADDRESS> scan empty. Instead it created a new scan called Openvas where all the findings from every scan go to.
If this was too confusing check out the following screenshot:

@Danvaro thanks for testing I have fix that. The scanner can now also handle multiple IP addresses (not just single IPs) either by making a target and using the target name or by using a network definition as the targetip (e.g. <IP_ADDRESS>/24).
Would you mind testing again before I merge this branch into master and release it?

It works! You can merge and release safely.

Thanks for the bug fix. It's also working perfectly on my end.


Square Shape

Description
I want to print a square shape by stars
Domain
CPP
Type of Contribution
Others
Code of Conduct

[X] I follow Contributing Guidelines & Code of conduct of LearnCPP.

/assign

/assign

/assign