ParserError('Error tokenizing data. ...')

Hello,
I am running Python 3.11.2 and Yfinance 0.2.18.
I am trying to download historical data by executing the following line:
yf.download(tickers="AAPL", start='2021-1-1', auto_adjust=True, threads=True)
I am getting the following output (error):
"- AAPL: ParserError('Error tokenizing data. C error: Expected 2 fields in line 1098, saw 3\n')"

[*********************100%***********************]  1 of 1 completed

1 Failed download:
- AAPL: ParserError('Error tokenizing data. C error: Expected 2 fields in line 1098, saw 3\n')

| Open | High | Low | Close | Adj Close | Volume
-- | -- | -- | -- | -- | -- | --

Anyone having the same issue? Many thanks!

By the way, I am using Pandas 2.0.1.
Many thanks again! :)

Hi ValueRaider!
Many thanks the hint! I made the correction in my comment. 😅
I am new to Github!
Many thanks for yfinance, it is a great package! 👍😊
Best regards,
Peter!
ValueRaider @.***> schrieb am Mi., 17. Mai 2023, 12:03:

Read the instructions:
Delete this default message (all of it)
—
Reply to this email directly, view it on GitHub
https://github.com/ranaroussi/yfinance/issues/1526#issuecomment-1551107702,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/A73JOTV3UEMUEXGAW27WOUDXGSO6DANCNFSM6AAAAAAYBKZ44Q
.
You are receiving this because you authored the thread.Message ID:
@.***>

Let's keep the issue thread concise and focused.
Install pre-release via PIP then enable debug logging and post output. Also if you have feedback on the logging, post it.

Or, easier option: temporarily downgrade to 0.1.96

ValueRaider, many thanks for the solutions! I implemented the easier option (downgrading to 0.1.96), since option 1 was somewhat difficult for me to implement. I do not have Git and installing it seemed somewhat tricky. Anyway, it is running fine now.
A very huge thank you, @ValueRaider !! :)

@ValueRaider many thanks again for your help on this issue! just one final question please before I close this issue. Will the fix be implemented in the coming release or is it already implemented in the pre-release? I am new to Github so I am not very familiar with the terminology here... :)
Many thanks again!

It's only in dev branch currently so leave issue open.

Hello ValueRaider,
I noticed that I need some functions that are not available in 0.1.96. So I installed git and executed the following line:
pip install git+https://github.com/ranaroussi/yfinance.git@fix/tz-cache-migrate-error
Output was:
Collecting git+https://github.com/ranaroussi/yfinance.git@fix/tz-cache-migrate-error
Cloning https://github.com/ranaroussi/yfinance.git (to revision fix/tz-cache-migrate-error) to c:\users\peter\appdata\local\temp\pip-req-build-p3bjlifc
Running command git clone --filter=blob:none --quiet https://github.com/ranaroussi/yfinance.git 'C:\Users\peter\AppData\Local\Temp\pip-req-build-p3bjlifc'
WARNING: Did not find branch or tag 'fix/tz-cache-migrate-error', assuming revision or ref.
Running command git checkout -q fix/tz-cache-migrate-error
error: pathspec 'fix/tz-cache-migrate-error' did not match any file(s) known to git
error: subprocess-exited-with-error
× git checkout -q fix/tz-cache-migrate-error did not run successfully.
│ exit code: 1
╰─> See above for output.
note: This error originates from a subprocess, and is likely not a problem with pip.
error: subprocess-exited-with-error
× git checkout -q fix/tz-cache-migrate-error did not run successfully.
│ exit code: 1
╰─> See above for output.
note: This error originates from a subprocess, and is likely not a problem with pip.

Obvisouly he could not find the fix/tz-cache-migrate-error. I guess this is because the fix was deleted as written here:
https://github.com/ranaroussi/yfinance/pull/1528
So should I stay on 0.1.96? There is no chance for me to use the current release version of yfinance, right?
Many thanks in advance again, @ValueRaider ! :)

I thought you confirmed the issue fixed by downgrading to 0.1.96? Only need to run the fix once: https://github.com/ranaroussi/yfinance/issues/1526#issuecomment-1551465548

Yes, the download function is working now with 0.1.96. But there are other functions that 0.1.96 does not include. However, these functions are implemented in the current version. The function I am referring to is whether a ticker has options. This function is not provided in 0.1.96.
I tried to implement @fix/tz-cache-migrate-error via git but it failed... I think it was removed (https://github.com/ranaroussi/yfinance/pull/1528)

Only need to run once, then normal PIP versions should work

What do you think that means?

Sorry but I can't follow you... 😅

You only need to run the 'bug fix' once and the bug is permanently fixed.

@ValueRaider thanks for the info!
So after I ran the bug fix and re-installed the current version of yfinance, I get the following output:
Input:
stockdata = yf.download("AAPL",'2021-1-1', group_by="ticker",auto_adjust=True, threads=True)
Output:
[100%**]  1 of 1 completed
1 Failed download:

AAPL: IntegrityError('NOT NULL constraint failed: kv.key')

Another try:
Input:
stockdata = yf.download("AAPL",'2021-1-1', auto_adjust=True, threads=True)
Output:
[100%**]  1 of 1 completed
1 Failed download:

AAPL: OperationalError('database is locked')

I have no idea what the issue is here... 😅
But many thanks again, @ValueRaider I need patience! ;-)

I need the stack trace. Switch from download to yf.Ticker.history(), that will print it.

Hi @ValueRaider
I enabled debug logging and I am still getting exactly the same output as before:
Input:
stockdata = yf.download("AAPL",'2021-1-1', group_by="ticker",auto_adjust=True, threads=True)
Output:
[100%**]  1 of 1 completed
1 Failed download:

AAPL: IntegrityError('NOT NULL constraint failed: kv.key')

Input:
stockdata = yf.download("AAPL",'2021-1-1', group_by="ticker",auto_adjust=True, threads=True)
Output:
[100%**]  1 of 1 completed
1 Failed download:

AAPL: OperationalError('database is locked')

This time, I used the same input two times... Interestingly, the output is different between the two...
Many thanks again, @ValueRaider ! :)

Confirm your yfinance version: print(yf.__version__)

Good morning @ValueRaider!

First run:
Here is the input:
stockdata = yf.download("AAPL",'2021-1-1', group_by="ticker",auto_adjust=True, threads=True)
The output:
[100%**]  1 of 1 completed
ERROR
1 Failed download:
ERROR ['AAPL']: IntegrityError('NOT NULL constraint failed: kv.key')
DEBUG ['AAPL']: Traceback (most recent call last):
File "[c:\Users\peter\AppData\Local\Programs\Python\Python311\Lib\site-packages\yfinance\multi.py](file:///C:/Users/peter/AppData/Local/Programs/Python/Python311/Lib/site-packages/yfinance/multi.py)", line 243, in _download_one_threaded
data = _download_one(ticker, start, end, auto_adjust, back_adjust, repair,
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "[c:\Users\peter\AppData\Local\Programs\Python\Python311\Lib\site-packages\yfinance\multi.py](file:///C:/Users/peter/AppData/Local/Programs/Python/Python311/Lib/site-packages/yfinance/multi.py)", line 262, in _download_one
return Ticker(ticker).history(
^^^^^^^^^^^^^^^^^^^^^^^
File "[c:\Users\peter\AppData\Local\Programs\Python\Python311\Lib\site-packages\yfinance\base.py](file:///C:/Users/peter/AppData/Local/Programs/Python/Python311/Lib/site-packages/yfinance/base.py)", line 158, in history
tz = self._get_ticker_tz(proxy, timeout)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "[c:\Users\peter\AppData\Local\Programs\Python\Python311\Lib\site-packages\yfinance\base.py](file:///C:/Users/peter/AppData/Local/Programs/Python/Python311/Lib/site-packages/yfinance/base.py)", line 1013, in _get_ticker_tz
cache = utils.get_tz_cache()
^^^^^^^^^^^^^^^^^^^^
File "[c:\Users\peter\AppData\Local\Programs\Python\Python311\Lib\site-packages\yfinance\utils.py](file:///C:/Users/peter/AppData/Local/Programs/Python/Python311/Lib/site-packages/yfinance/utils.py)", line 978, in get_tz_cache
_tz_cache = _TzCache()
^^^^^^^^^^
File "[c:\Users\peter\AppData\Local\Programs\Python\Python311\Lib\site-packages\yfinance\utils.py](file:///C:/Users/peter/AppData/Local/Programs/Python/Python311/Lib/site-packages/yfinance/utils.py)", line 902, in init
self._migrate_cache_tkr_tz()
File "[c:\Users\peter\AppData\Local\Programs\Python\Python311\Lib\site-packages\yfinance\utils.py](file:///C:/Users/peter/AppData/Local/Programs/Python/Python311/Lib/site-packages/yfinance/utils.py)", line 949, in _migrate_cache_tkr_tz
self.tz_db.bulk_set(df.to_dict()['Tz'])
File "[c:\Users\peter\AppData\Local\Programs\Python\Python311\Lib\site-packages\yfinance\utils.py](file:///C:/Users/peter/AppData/Local/Programs/Python/Python311/Lib/site-packages/yfinance/utils.py)", line 882, in bulk_set
self.conn.executemany('replace into "kv" (key, value) values (?,?)', records)
sqlite3.IntegrityError: NOT NULL constraint failed: kv.key

Second run:
Input:
stockdata = yf.download("AAPL",'2021-1-1', group_by="ticker",auto_adjust=True, threads=True)
Output:
[100%**]  1 of 1 completed
ERROR
1 Failed download:
ERROR ['AAPL']: OperationalError('database is locked')
DEBUG ['AAPL']: Traceback (most recent call last):
File "[c:\Users\peter\AppData\Local\Programs\Python\Python311\Lib\site-packages\yfinance\multi.py](file:///C:/Users/peter/AppData/Local/Programs/Python/Python311/Lib/site-packages/yfinance/multi.py)", line 243, in _download_one_threaded
data = _download_one(ticker, start, end, auto_adjust, back_adjust, repair,
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "[c:\Users\peter\AppData\Local\Programs\Python\Python311\Lib\site-packages\yfinance\multi.py](file:///C:/Users/peter/AppData/Local/Programs/Python/Python311/Lib/site-packages/yfinance/multi.py)", line 262, in _download_one
return Ticker(ticker).history(
^^^^^^^^^^^^^^^^^^^^^^^
File "[c:\Users\peter\AppData\Local\Programs\Python\Python311\Lib\site-packages\yfinance\base.py](file:///C:/Users/peter/AppData/Local/Programs/Python/Python311/Lib/site-packages/yfinance/base.py)", line 158, in history
tz = self._get_ticker_tz(proxy, timeout)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "[c:\Users\peter\AppData\Local\Programs\Python\Python311\Lib\site-packages\yfinance\base.py](file:///C:/Users/peter/AppData/Local/Programs/Python/Python311/Lib/site-packages/yfinance/base.py)", line 1013, in _get_ticker_tz
cache = utils.get_tz_cache()
^^^^^^^^^^^^^^^^^^^^
File "[c:\Users\peter\AppData\Local\Programs\Python\Python311\Lib\site-packages\yfinance\utils.py](file:///C:/Users/peter/AppData/Local/Programs/Python/Python311/Lib/site-packages/yfinance/utils.py)", line 978, in get_tz_cache
_tz_cache = _TzCache()
^^^^^^^^^^
File "[c:\Users\peter\AppData\Local\Programs\Python\Python311\Lib\site-packages\yfinance\utils.py](file:///C:/Users/peter/AppData/Local/Programs/Python/Python311/Lib/site-packages/yfinance/utils.py)", line 902, in init
self._migrate_cache_tkr_tz()
File "[c:\Users\peter\AppData\Local\Programs\Python\Python311\Lib\site-packages\yfinance\utils.py](file:///C:/Users/peter/AppData/Local/Programs/Python/Python311/Lib/site-packages/yfinance/utils.py)", line 949, in _migrate_cache_tkr_tz
self.tz_db.bulk_set(df.to_dict()['Tz'])
File "[c:\Users\peter\AppData\Local\Programs\Python\Python311\Lib\site-packages\yfinance\utils.py](file:///C:/Users/peter/AppData/Local/Programs/Python/Python311/Lib/site-packages/yfinance/utils.py)", line 882, in bulk_set
self.conn.executemany('replace into "kv" (key, value) values (?,?)', records)
sqlite3.OperationalError: database is locked

Quick note:
I think the problem is that I ran pip install git+https://github.com/ranaroussi/yfinance.git@fix/tz-cache-migrate-error AFTER it was removed... Hence, I got the error message that is shown in https://github.com/ranaroussi/yfinance/issues/1526#issuecomment-1556170785
Is it possible to restore the fix and to keep it until it is built in the coming release? This would allow me to install and use all upcoming versions of yfinance...
Many thanks again, @ValueRaider ! Appreciate your support and thanks for your patience with me! :)

Is it possible to restore the fix and to keep it until it is built in the coming release?

If you look more carefully, this current error is different to the first. Can you email me the contents of the folder printed by yf.utils._cache_dir+"/py-yfinance/", then I can give you a quick-fix for this while I investigate. My email is on my profile.

Hi @ValueRaider...
This is all what I get when executing yf.utils._cache_dir+"/py-yfinance/":
'[C:\Users\peter\AppData\Local/py-yfinance/]
(file:///C://Users//peter//AppData//Local/py-yfinance/)'

'[C:\Users\peter\AppData\Local/py-yfinance/]
Am Di., 23. Mai 2023 um 12:25 Uhr schrieb ValueRaider <
@.***>:

Is it possible to restore the fix and to keep it until it is built in the
coming release?
If you look more carefully, this current error is different to the first.
Can you email me the contents of the folder printed by
yf.utils._cache_dir+"/py-yfinance/", then I can give you a quick-fix for
this while I investigate. My email is on my profile.
—
Reply to this email directly, view it on GitHub
https://github.com/ranaroussi/yfinance/issues/1526#issuecomment-1559006034,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/A73JOTUPEHBI4JKQ7WOO2MDXHSGCNANCNFSM6AAAAAAYBKZ44Q
.
 I don't have the patience for this.

Ok you eventually figured it out. Fix by deleting those files, particularly the csv and db.

@ValueRaider
I just got another bug when executing the following line:

Input:
start = time.time()
stockdata = yf.download(ticker_list_r3000,'2021-1-1', group_by="ticker",auto_adjust=True, threads=True)
stockdata.index=pd.DatetimeIndex(stockdata.index)
print(time.time()-start)
Output:
[                       1%                       ]  39 of 2634 completed
ERROR SAFE WI: No timezone found, symbol may be delisted
[******                12%                       ]  329 of 2634 completed
ERROR ADRO: No timezone found, symbol may be delisted
[*********             19%                       ]  495 of 2634 completed
ERROR MSFUT: No timezone found, symbol may be delisted
[***********           22%                       ]  583 of 2634 completed
ERROR UHALB: No timezone found, symbol may be delisted
[************          24%                       ]  627 of 2634 completed
ERROR LENB: No timezone found, symbol may be delisted
[************          26%                       ]  678 of 2634 completed
ERROR XTSLA: No timezone found, symbol may be delisted
[**************        30%                       ]  780 of 2634 completed
ERROR ARD: No timezone found, symbol may be delisted
[*****************     35%                       ]  914 of 2634 completed
ERROR ESM3: No timezone found, symbol may be delisted
[*******************   40%                       ]  1044 of 2634 completed
ERROR PFHC: No timezone found, symbol may be delisted
[*******************   40%                       ]  1059 of 2634 completed
ERROR RTYM3: No timezone found, symbol may be delisted
[********************  41%                       ]  1074 of 2634 completed
ERROR HEIA: No timezone found, symbol may be delisted
[********************* 44%                       ]  1167 of 2634 completed
ERROR BFA: No timezone found, symbol may be delisted
[**********************49%                       ]  1278 of 2634 completed
ERROR CWENA: No timezone found, symbol may be delisted
[**********************49%                       ]  1295 of 2634 completed
ERROR LGFA: No timezone found, symbol may be delisted
[**********************52%                       ]  1370 of 2634 completed
ERROR GTXI: No timezone found, symbol may be delisted
[**********************53%                       ]  1393 of 2634 completed
ERROR GEFB: No timezone found, symbol may be delisted
[**********************53%                       ]  1394 of 2634 completed
ERROR BFB: No timezone found, symbol may be delisted
[********************56%                     ]  1464 of 2634 completed
ERROR CR WI: No timezone found, symbol may be delisted
[*******************58%                    ]  1540 of 2634 completed
ERROR RXO WI: No timezone found, symbol may be delisted
[*****************62%                  ]  1632 of 2634 completed
ERROR LGFB: No timezone found, symbol may be delisted
[*************70%              ]  1841 of 2634 completed
ERROR BRKB: No timezone found, symbol may be delisted
[***********76%            ]  1990 of 2634 completed
ERROR P5N994: No timezone found, symbol may be delisted
[**********78%           ]  2060 of 2634 completed
ERROR MOGA: No timezone found, symbol may be delisted
[********82%         ]  2149 of 2634 completed
ERROR BHM WI: No timezone found, symbol may be delisted
[*95%  ]  2497 of 2634 completed
ERROR TFM: No price data found, symbol may be delisted (1d 2021-1-1 -> 2023-05-23)
[100%**]  2634 of 2634 completed
ERROR
25 Failed downloads:
ERROR ['SAFE WI', 'ADRO', 'MSFUT', 'UHALB', 'LENB', 'XTSLA', 'ARD', 'ESM3', 'PFHC', 'RTYM3', 'HEIA', 'BFA', 'CWENA', 'LGFA', 'GTXI', 'GEFB', 'BFB', 'CR WI', 'RXO WI', 'LGFB', 'BRKB', 'P5N994', 'MOGA', 'BHM WI']: No timezone found, symbol may be delisted
ERROR ['TFM']: No price data found, symbol may be delisted (1d 2021-1-1 -> 2023-05-23)

KeyError                                  Traceback (most recent call last)
Cell In[6], line 2
1 start = time.time()
----> 2 stockdata = yf.download(ticker_list_r3000,'2021-1-1', group_by="ticker",auto_adjust=True, threads=True)
3 stockdata.index=pd.DatetimeIndex(stockdata.index)
4 print(time.time()-start)
File [c:\Users\peter\AppData\Local\Programs\Python\Python311\Lib\site-packages\yfinance\multi.py:178](file:///C:/Users/peter/AppData/Local/Programs/Python/Python311/Lib/site-packages/yfinance/multi.py:178), in download(tickers, start, end, actions, threads, ignore_tz, group_by, auto_adjust, back_adjust, repair, keepna, progress, period, show_errors, interval, prepost, proxy, rounding, timeout)
[176](file:///c%3A/Users/peter/AppData/Local/Programs/Python/Python311/Lib/site-packages/yfinance/multi.py?line=175) tbs = {}
[177](file:///c%3A/Users/peter/AppData/Local/Programs/Python/Python311/Lib/site-packages/yfinance/multi.py?line=176) for ticker in shared._ERRORS:
--> [178](file:///c%3A/Users/peter/AppData/Local/Programs/Python/Python311/Lib/site-packages/yfinance/multi.py?line=177)     tb = shared._TRACEBACKS[ticker]
[179](file:///c%3A/Users/peter/AppData/Local/Programs/Python/Python311/Lib/site-packages/yfinance/multi.py?line=178)     if not tb in tbs:
[180](file:///c%3A/Users/peter/AppData/Local/Programs/Python/Python311/Lib/site-packages/yfinance/multi.py?line=179)         tbs[tb] = [ticker]
KeyError: 'SAFE WI'

The problem is the following part:
KeyError Traceback (most recent call last)
Cell In[6], line 2
1 start = time.time()
----> 2 stockdata = yf.download(ticker_list_r3000,'2021-1-1', group_by="ticker",auto_adjust=True, threads=True)
3 stockdata.index=pd.DatetimeIndex(stockdata.index)
4 print(time.time()-start)
File c:\Users\peter\AppData\Local\Programs\Python\Python311\Lib\site-packages\yfinance\multi.py:178, in download(tickers, start, end, actions, threads, ignore_tz, group_by, auto_adjust, back_adjust, repair, keepna, progress, period, show_errors, interval, prepost, proxy, rounding, timeout)
176 tbs = {}
177 for ticker in shared._ERRORS:
--> 178 tb = shared._TRACEBACKS[ticker]
179 if not tb in tbs:
180 tbs[tb] = [ticker]
KeyError: 'SAFE WI'

The first part is ok... these "error messages" that some symbols might be problably have been delisted are ok... they were always there.

Questions: read https://github.com/ranaroussi/yfinance#timezone-cache-store. yfinance was trying to migrate from the old CSV-cache to newer SQL-cache. No CSV-cache = no migration.
'SAFE WI': problem should be obvious. If you think yfinance can handle it better then create a specific Issue.

@ValueRaider
I re-installed the latest release-version of yfinance and it is running like silk. It is not leading to the bug like the pre-release version!
Input:
start = time.time()
stockdata = yf.download(ticker_list_r3000,'2021-1-1', group_by="ticker",auto_adjust=True, threads=True)
stockdata.index=pd.DatetimeIndex(stockdata.index)
print(time.time()-start)
Output:
[100%**]  2634 of 2634 completed
25 Failed downloads:

BHM WI: No timezone found, symbol may be delisted
BFA: No timezone found, symbol may be delisted
RTYM3: No timezone found, symbol may be delisted
BFB: No timezone found, symbol may be delisted
ARD: No timezone found, symbol may be delisted
LGFB: No timezone found, symbol may be delisted
LGFA: No timezone found, symbol may be delisted
.
.
.
.
.

There is no more bug like in https://github.com/ranaroussi/yfinance/issues/1526#issuecomment-1559588523!
There has also not been a bug in previous versions! The output simply said that there were a couple of failed downloads but nevertheless, the download was completed and the dataframe was constructed. The pre-release version generates a bug once there is a failed download.
Hence, can you please allow future versions of yfinance to continue the download without generating a bug if it fails to download certain symbols?
Once again, a very big thank you, @ValueRaider !

Just did: https://github.com/ranaroussi/yfinance/issues/1537
I hope the issue is clear... Whenever a long list of tickers is passed to yf.download, chances are that some tickers will fail to be downloaded. In this case, yf.download shoould not generate a bug like in the pre-release version 0.2.19b3 but continue its behaviour like in 0.2.18.


Module Not Found Error

Current Behavior

Following error occurs after trying to activate add-on in Blender. Have tried the two most recent releases 1.3.1 and 1.3.0.
Expected Behavior
Expected the add-on to activate after installing. Tried installing through Blender and by pasting into the addon file.
Steps To Reproduce

download zip file.
Open blender, edit, preferences,  install add-on, select downloaded zip file, click to activate installed add-on.
Error occurs and traceback appears.

Environment
- OS:Windows 10
- Blender: 3.6.2
- glTF-Blender-IO-MSFS:1.3.1

Anything else?
No response

You need to use blender 3.3.x as per readme,
The error is showing you are trying to install on 3.6

Similar issue occurs when using blender version 3.3.10. As seen below.

Latest supported version seems to be blender 3.3.9 LTS.


Update cats-effect to 3.3.8

Updates org.typelevel:cats-effect from 3.3.7 to 3.3.8.
GitHub Release Notes - Version Diff
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "org.typelevel", artifactId = "cats-effect" } ]

labels: library-update, early-semver-patch, semver-spec-patch, commit-count:1

Codecov Report

Merging #627 (74b0dc7) into master (9acca06) will increase coverage by 0.34%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #627      +/-   ##
==========================================
+ Coverage   62.54%   62.88%   +0.34%
==========================================
  Files          39       39
  Lines        1303     1288      -15
  Branches        7        7
==========================================
- Hits          815      810       -5
+ Misses        488      478      -10

Impacted Files
Coverage Δ

core/src/main/scala/laserdisc/laserdisc.scala
59.37% <0.00%> (-4.52%)
:arrow_down:

core/src/main/scala/laserdisc/protocol/RESP.scala
91.26% <0.00%> (-0.07%)
:arrow_down:

cli/src/main/scala/laserdisc/cli/CLI.scala
0.00% <0.00%> (ø)

...src/main/scala/laserdisc/protocol/SortedSetP.scala
0.97% <0.00%> (+0.02%)
:arrow_up:

core/src/main/scala/laserdisc/protocol/GeoP.scala
86.61% <0.00%> (+0.60%)
:arrow_up:

...e/src/main/scala/laserdisc/protocol/ClusterP.scala
68.91% <0.00%> (+1.36%)
:arrow_up:

...e/src/main/scala/laserdisc/protocol/Protocol.scala
100.00% <0.00%> (+5.00%)
:arrow_up:

.../scala/laserdisc/protocol/LenientStringCodec.scala
66.66% <0.00%> (+16.66%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9acca06...74b0dc7. Read the comment docs.


Break out the totals  into peak and off peak costs / kWh

The entities show the totals for kWh and Costs, would it be possible to add  more entities that show the peak and off-peak separately from the totals ie the build up.
Expected behavior
for example :-
Peak kWH = 2 ,   Off-Peak kWH = 4 ,   Total kWH = 6
Peak Cost = 24p ,   Off-Peak kWH = 48p ,   Total kWH = 72p
This would make it so much easier to understand the total cost build up and usage and how the totals are calculated.
Apologise if there is an easy way to already do this, but I'm still learning

Hello, sorry for the late response. I'm afraid I'm not planning to add this in the future as peak/off peak is not a universal term for all tariffs and gets quite complicated.

Hi @Annaka007. After you raised this issue, I had a few more requests. This feature is now available in the latest release (v7.1.0) for previous consumption sensors. These sensors are disabled by default, but can be enabled to provide this functionality.


Add --lto flag to cargo xtask runner

LTO actually increases binary size of the platform when compiling for speed.

Closing because the difference does not seem big: 164k (release + LTO) versus 160k (only release).


When the label size is too short, the constant for calculating

issue: https://github.com/airbnb/caravel/issues/1112
margin_size does not apply. Also nvd3 auto adjusts font-size of axis
labels.
Temporary solution here: Setting a fixed font-size on nvd3 axis labels
and a minimum threshold for label size.

needs-review @ascott @mistercrunch @bkyryliuk

will these changes affect line charts as well? afaik nvd3_vis.js/css are used for line, bar, pie, and others. check out the case statements here: https://github.com/ascott/caravel/blob/master/caravel/assets/visualizations/nvd3_vis.js#L106-L107

Tested this on several line chart, the font-size looks good, since we don't rotate the labels in line charts, this should be fine

LGTM! 🚢


feat: Add support for addon and identity provider custom tags

Description

Add support for addon and identity provider custom tags

Motivation and Context

Resolves #2937

Breaking Changes

How Has This Been Tested?

[ ] I have updated at least one of the examples/* to demonstrate and validate my change(s)
[ ] I have tested and validated these changes using one or more of the provided examples/* projects

[x] I have executed pre-commit run -a on my pull request

This PR is included in version 20.3.0 :tada:


requestChannel: error when subscribing again

When using requestChannel(), one can subscribe to the Flowable returned. One can unsubscribe as well. If one subscribes again to this flowable, it does not work.

Expected Behavior

After re-subscribing, one will receive values again with the given subscriber. No warning will occur on console.
Actual Behavior

A warning is logged on console (RSocketClient: re-entrant call to request n before initial channel established.). No new values are received by the subscriber.
Steps to Reproduce

const metadata = ...;
const client = new RSocketClient(...);
const processor = new FlowableProcessor(sub => { });
const inputFlowable = processor.map(i => { return { data: i, metadata: metadata } });
client.connect().then(
	socket => {
		var subscription;
		const subscriber = {
			onNext: value => console.log('Value from Responder', value.data),
			onSubscribe: sub => { subscription = sub; sub.request(0x7fffffff) },
		};

                // responder will multiply the given value by 2
		const channelFlowable = socket.requestChannel(inputFlowable);
		channelFlowable.subscribe(subscriber);

		setTimeout(() => processor.onNext(1), 1000);
		setTimeout(() => processor.onNext(2), 2000);
		setTimeout(() => { console.log("unsubscribe"); subscription.cancel(); }, 3000);
		setTimeout(() => { console.log("subscribe again"); channelFlowable.subscribe(subscriber); }, 4000);
		setTimeout(() => processor.onNext(3), 5000);

               //output on console
               // Value from Responder 2
               // Value from Responder 4
               // Unsubscribe
               // subscribe again
               // RSocketClient: re-entrant call to request n before initial channel established.
	}
);

Workaround
Instead of re-subscribing call requestChannel() again
Possible Solution
Looks like the variables 'initialized' and 'payloadsSubscribed' in the requestChannel()-implementation of RSocketMachine are not reset.
Your Environment

RSocket version(s) used: 0.0.27

Happy new year!

Hi @dholzenburg ,
If I am interpreting the protocol documentation correctly, I believe that this is working as per protocol spec. The Protocol spec for Request Channel states:

Upon receiving a CANCEL, the stream is terminated on the Responder.
Upon sending a CANCEL, the stream is terminated on the Requester.

Given that, if the Requester or a Responder of a RequestChannel stream send CANCEL, you must re-establish the stream using a subsequent call to requestChannel. You cannot simply re-subscribe to the stream returned form requestStream, as it has already been terminated.
I will also note that while the protocol has not changed, these APIs have changed recently with 1.0.0-alpha.1, and the flowable API is no longer available.


User snippets no longer take precedence

VSCode Version: 1.40.0
OS Version: macOS Sierra 10.12.6

Steps to Reproduce:
Type a user snippet prefix ij in this case, and see that while it's above the others, it is not selected first.

Pressing the up arrow then selects the correct one:

In the previous release I was using this worked fine, but I'm not sure if it's intentional or a bug.

/needsMoreInfo
This works find for me and I also don't recall any changes in that area. Please add  steps that allow me to reproduce this.

Hmm if it works for you I'm not sure how to reproduce it, but it is consistent, I get it all the time and with all my snippets, it could be an extension or something. Let me know if there's anything which would help narrow it down!

Is another item selected, maybe the last? Can you try this setting "editor.suggestSelection": "first"?

No luck, I didn't have editor.suggestSelection but I added "first" and it still autocompletes to other things first, oddly it selects ones which aren't even really good matches like in the screenshot

When you press Cmd+? while showing suggestions (and details) then the details pane goes into an explain mode. Can you attach a screen shot of the first two item?

Done! Thanks for the help.

My snippet uses "tr" here for context, but matches true first, even though it's an exact match:

What extension is this? From the second screen shot it seems that it creates suggestions that enforce the behaviour. It sets ij as filter text meaning the editor compares ij (filterText) with ij (prefix) and that explains the high rank

Hmm I'm not intentionally using anything which would manipulate whatever VSCode does by default for snippets

What extension is this. I mean in what language are you coding? What extension is providing those suggestions?

It's Go, and the suggestions that I'm worried about at least are just from my snippets. If there are other suggestions in there I'm not sure where they come from aside from VS Code itself.

Thanks for following up. This is the GO extension and please follow up with them because they monopolise the suggestion flow with their behaviour which enforcing "their ordering" of items - which isn't what users always want.

/cc @muirdm and for context: https://github.com/microsoft/vscode-go/issues/2739


Update how-to-single-page-app-vanillajs-sample-sign-in.md

@OwenRichards1

Can you review this PR?
IMPORTANT: When this content is ready to merge, you must add #sign-off in a comment or the approval may get overlooked.

#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

The article has been moved. If you'd like to update the article in its current state, please open a new PR. Or if you believe this PR was closed by mistake, email the PublicPRs alias.
#please-close


[#4214] Improved compatibility of ClassLoader.defineClass() for java9

Remove maven-failsafe-plugin

Codecov Report

Merging #4286 into master will increase coverage by <.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #4286      +/-   ##
==========================================
+ Coverage   41.09%   41.09%   +<.01%
==========================================
  Files        2382     2382
  Lines       74535    74535
  Branches    10078    10078
==========================================
+ Hits        30628    30630       +2
+ Misses      41087    41084       -3
- Partials     2820     2821       +1

Impacted Files
Coverage Δ

.../profiler/sender/StandbySpanStreamDataStorage.java
72.88% <0%> (-3.39%)
:arrow_down:

...ofiler/sender/StandbySpanStreamDataSendWorker.java
80.59% <0%> (-2.99%)
:arrow_down:

...om/navercorp/pinpoint/rpc/codec/PacketDecoder.java
61.7% <0%> (-2.13%)
:arrow_down:

.../com/navercorp/pinpoint/profiler/context/Span.java
48.27% <0%> (-1.73%)
:arrow_down:

...pinpoint/profiler/monitor/DeadlockMonitorTask.java
18.6% <0%> (-1.17%)
:arrow_down:

...m/navercorp/pinpoint/test/OrderedSpanRecorder.java
70.19% <0%> (ø)
:arrow_up:

...orp/pinpoint/rpc/server/DefaultPinpointServer.java
80.55% <0%> (+0.34%)
:arrow_up:

...point/rpc/client/DefaultPinpointClientHandler.java
72.02% <0%> (+0.64%)
:arrow_up:

...java/com/navercorp/pinpoint/rpc/DefaultFuture.java
74.16% <0%> (+1.66%)
:arrow_up:

...corp/pinpoint/rpc/stream/StreamChannelManager.java
72.41% <0%> (+1.72%)
:arrow_up:

... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1752259...33f31eb. Read the comment docs.


Missing mime-checker

Would be nice to have a mime-checker.
With a mime-id, is there app(s) that supports that type?
What apps?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 6a7e802f-ce88-b235-c1f0-45a31e7144e6
Version Independent ID: b88b1c7f-b42c-02d0-0f41-a778b0b5d80a
Content: Launcher Class (Xamarin.Essentials)
Content Source: docs/en/Xamarin.Essentials/Launcher.xml
Product: xamarin
Technology: xamarin-essentials
GitHub Login: @dotnet-bot
Microsoft Alias: dotnetcontent

Thanks, can you put in a Feature request on http://github.com/xamarin/essentials


Configuring pull-up for SPI MISO pin on STM-32

For some applications, a pull-up resistor is required on the MISO pin of an SPI bus. Is it possible to use one of the STM32 internal pull-ups for this application? It seems like this would be the relevant line of code:
https://github.com/embassy-rs/embassy/blob/c575c7dc6cab49a99f36eedbdd41e97868e1102b/embassy-stm32/src/spi/mod.rs#L119
If there was an API change to allow passing a Pull input to the spi config struct, that would be fantastic.

pull requests welcome. ideally it'd work like the pulls in i2c, where you put them in Config. It should be easy to add.

I am using the MCP33131-10-E/MS, which does not use the MOSI pin and needs a pull-up on MISO in order to monitor the status of the recalibration. Up until now, I hacked my way around it, but decided to take a shot at adding this in: https://github.com/embassy-rs/embassy/pull/2943


Add unique constraint to form data table

Status
IN DEVELOPMENT
JIRA Ticket
SPACON-668
Description
This adds a unique constraint to the form_data table based on a form submissions id and layerId.
Todos

Ensure that the Android SDK is sending the submission id and layerId the same way the iOS sdk is

@boundlessgeo/spatial-connect

LGTM 👍


Stratified Type Inference

This PR explores the possibility of using stratified type inference over the current implication constraint system.
The implication constraints are rather restrictive and this proves as a possible simple alternative without much modification to the current code-base.

The above commits implement MLGX, the explicitly typed language that stratified type inference builds upon.

This PR was subsumed by Dromedary's Ambivalent constraints.


simplify mkdocs config

Remove a lot of the extra packages which makes maintaining MKDOCS easier.

Also enables a more modular approach to installing packages.

Possible fix for https://github.com/ing-bank/probatus/issues/227

Depends on: https://github.com/ing-bank/probatus/pull/238

This PR should simplify Probatus by deprecating code that hasn't been updated in a long time and simplify some of its dependencies.

bucketing is better done in Feature Engine, Skorecard or Sklearn, etc
statistical tests and sampling are better done in Statsmodels, scipy, etc
imputation is better done in Feature Engine, etc

@PaulZhutovsky

Wow major refactoring going on! :)


Camera application is crashing and throws an exception

i am using camera in my app. the app have two tabs, in two tabs i am using camera.
i am disposing the CameraController like this
@override
  void dispose() {
 super.dispose();
 cameraController.dispose();
  }

but when i move to one tab to another tab, app is crashing and showing this error:

error
E/BufferQueueProducer(14499): [SurfaceTexture-1-14499-15] cancelBuffer: BufferQueue has been abandoned
I/chatty  (14499): uid=10251(com.example.sentry_mobile_app) Binder:14499_1 identical 6 lines
E/BufferQueueProducer(14499): [SurfaceTexture-1-14499-15] cancelBuffer: BufferQueue has been abandoned
E/BufferQueueProducer(14499): [SurfaceTexture-1-14499-15] connect: BufferQueue has been abandoned
E/BufferQueueProducer(14499): [SurfaceTexture-1-14499-15] setMaxDequeuedBufferCount: BufferQueue has been abandoned
E/libc    (14499): Access denied finding property "vendor.camera.aux.packagelist"
E/libc    (14499): Access denied finding property "persist.vendor.camera.privapp.list"
I/CameraManager(14499): Using legacy camera HAL.
E/libc    (14499): Access denied finding property "vendor.camera.hal1.packagelist"
E/libc    (14499): Access denied finding property "vendor.camera.aux.packagelist"
E/libc    (14499): Access denied finding property "vendor.camera.aux.packagelist"
W/ntry_mobile_app(14499): type=1400 audit(0.0:59108): avc: denied { read } for name="u:object_r:vendor_camera_prop:s0" dev="tmpfs" ino=13461 scontext=u:r:untrusted_app:s0:c251,c256,c512,c768 tcontext=u:object_r:vendor_camera_prop:s0 tclass=file permissive=0
E/libc    (14499): Access denied finding property "persist.vendor.camera.privapp.list"
I/CameraManager(14499): Using legacy camera HAL.
W/Thread-29(14499): type=1400 audit(0.0:59109): avc: denied { read } for name="u:object_r:vendor_default_prop:s0" dev="tmpfs" ino=13469 scontext=u:r:untrusted_app:s0:c251,c256,c512,c768 tcontext=u:object_r:vendor_default_prop:s0 tclass=file permissive=0
E/libc    (14499): Access denied finding property "vendor.camera.hal1.packagelist"
E/Camera  (14499): Error 2
I/RequestThread-1(14499): Flushing all pending requests.
E/RequestQueue(14499): cancel failed: no repeating request exists.
I/CameraDeviceState(14499): Legacy camera service transitioning to state ERROR
W/Binder:14499_1(14499): type=1400 audit(0.0:59111): avc: denied { read } for name="u:object_r:vendor_camera_prop:s0" dev="tmpfs" ino=13461 scontext=u:r:untrusted_app:s0:c251,c256,c512,c768 tcontext=u:object_r:vendor_camera_prop:s0 tclass=file permissive=0
E/libc    (14499): Access denied finding property "vendor.camera.aux.packagelist"
E/libc    (14499): Access denied finding property "vendor.camera.aux.packagelist"
E/libc    (14499): Access denied finding property "vendor.camera.aux.packagelist"
D/AndroidRuntime(14499): Shutting down VM
E/AndroidRuntime(14499): FATAL EXCEPTION: main
E/AndroidRuntime(14499): Process: com.example.sentry_mobile_app, PID: 14499
E/AndroidRuntime(14499): java.lang.NullPointerException: Attempt to invoke virtual method 'android.view.Surface android.media.ImageReader.getSurface()' on a null object reference
E/AndroidRuntime(14499):        at io.flutter.plugins.camera.Camera.startPreview(Camera.java:424)
E/AndroidRuntime(14499):        at io.flutter.plugins.camera.Camera$2.onOpened(Camera.java:160)
E/AndroidRuntime(14499):        at android.hardware.camera2.impl.CameraDeviceImpl$1.run(CameraDeviceImpl.java:149)
E/AndroidRuntime(14499):        at android.os.Handler.handleCallback(Handler.java:873)
E/AndroidRuntime(14499):        at android.os.Handler.dispatchMessage(Handler.java:99)
E/AndroidRuntime(14499):        at android.os.Looper.loop(Looper.java:201)
E/AndroidRuntime(14499):        at android.app.ActivityThread.main(ActivityThread.java:6810)
E/AndroidRuntime(14499):        at java.lang.reflect.Method.invoke(Native Method)
E/AndroidRuntime(14499):        at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:547)
E/AndroidRuntime(14499):        at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:873)
I/Process (14499): Sending signal. PID: 14499 SIG: 9
Lost connection to device.

Hi @janardhanmupparaju
can you please provide your updated  flutter doctor -v ?
Also, to better address the issue, would be helpful
if you could show a bit more of your code,
maybe posting a self contained app on github
or the steps to reproduce it.
Thank you

Without additional information, we are unfortunately not sure how to resolve this issue. We are therefore reluctantly going to close this bug for now. Please don't hesitate to comment on the bug if you have any more information for us; we will reopen it right away!
Thanks for your contribution.
Could everyone who still has this problem please file a new issue with the exact descriptions what happens, logs and the output of 'flutter doctor -v'  please.
All system setups can be slightly different so its always better to open new issues and reference related issues.

stumbled upon same issue:
https://github.com/flutter/flutter/issues/46952


Different home styles

Sometimes when i entered mumuki it seems like it has brokeen the stylesheet and it shows this page

with this css but other times appears to be fine like this one

With this css. The second one when I inspect mumuki's logo, I found out that it has this style for example
.book-header img {
    height: 75px;
}

Is it possible that you guys are delivering different versions of css?

This is a duplicate of https://github.com/mumuki/mumuki-platform/issues/222, which has been solved a few days ago.


Only scrap video information

What TMM version are you using?
2.9.16
What is the actual behaviour?
TMM can't scrap information when the content isn't in thetvdb.com
What is the expected behaviour?
ONly scrap the video information (resolution, ...)
Additional
Your Operating system? (win/mac/linux? version?): Xubuntu 18.04
I have some content that isn't a series or movie (documentries or content from youtube). for that i have added an extra home button in kodi. i don't need more information except the name of the content and some video information in the xml. so far i made this by manually creating the xml files. but thats awkward when there are more than 100 episodes. what i want is only to scrap basic information about video and audio streams and write the file name without the extention to the -tag.
can this be done with tinymediamanager?

i found out that this works when i double click on an episode and then click on ok. the xml is created. but i have to do this for each episode individually.

XML is written when you scrape or manually edit the entry.
So, when you cannot scrape such information online, you have to enter it manually?
If you are fine with the already shown / parsed title out of filename:
There should be a "rewrite NFO for episodes" function available in right click menu (for all marked shows)


How to change the title description of drawMarker

Forgive me for not finding the relevant documents.
How to change the title description of drawMarker

Assuming that you are wanting to change the tooltip on the drawMarker button? The documentation for this is here:
https://www.geoman.io/docs/customize/language
The link to the english translation file is broken, but you can find your various options for strings in the Translations Class at: https://github.com/geoman-io/leaflet-geoman/blob/b8b56e785deea901b94f2d8d683c70130f66327b/leaflet-geoman.d.ts#L581
I think what you want to do is something like the following:
this.customTranslation = {     buttonTitles: {         drawMarkerButton: 'Your custom text'     } }; this.map.pm.setLang('customName', this.customTranslation, 'en' );

For those who found this thread with the same question. Just host geoman.js local and edit the source...

@CptHolzschnauz you can overwrite the tooltip of the control with the same way as @matthewtboyle described, just overwrite the other key:
https://github.com/geoman-io/leaflet-geoman/blob/20df292812c207cab3990e58400ec54868c29d8e/src/assets/translations/en.json#L26
this.customTranslation = { buttonTitles: { dragButton: 'Your custom text' } };
this.map.pm.setLang('customName', this.customTranslation, 'en' );

https://jsfiddle.net/1nh5p9v0/


Gitlab rRest api doesn't accept Project name anymore.

Hello.
Danger is trying to call the Gitlab rest api using the project name. while gitlab now only accepts the project ID as you can see in the documentation.
Here is the error, i get.
+ danger-swift ci
Error:  { HTTPError: Not Found
    at fn (/snapshot/danger-js/node_modules/ky/umd.js:242:12)
    at process._tickCallback (internal/process/next_tick.js:68:7)
  name: 'HTTPError',
  response:
   Response {
     size: 0,
     timeout: 0,
     [Symbol(Body internals)]: { body: [PassThrough], disturbed: true, error: null },
     [Symbol(Response internals)]:
      { url:
         'https://gitlab.xxxx.com/api/v4/projects/project%2Fname/merge_requests/15/changes',
        status: 404,
        statusText: 'Not Found',
        headers: [Headers] } },
  description: '404 Project Not Found' }

This could be a danger-js problem, which version of danger-js are you using?

@f-meloni Yes i confirm it's in Danger-js side.
I'm using the last version : 9.2.9.

same

same

relates to https://github.com/danger/danger-js/issues/969


Create jobs that deploy all apps for a given node

This is to allow easy deployment of all apps for a given node class. The context behind this is that if a node goes away in AWS, it will be rebuilt by the autoscaling group. If this occurs, then the applications will not be automatically deployed, and having to log in to deploy them all is problematic to do by hand.
This is a very short term solution that creates jobs for each type of node class, that triggers downstream jobs for each app that is on that node class. It will use the "deployed-in-integration" branch which is set whenever an app is deployed to determine what version of the application is running in each environment.

I have tested this as working in AWS.

Do we need to update any developer documentation on how to add new applications? We already have deployable_apps info, it's going to be a little bit confusing why we need to add the application name again in a different parameter

I'm going to try to think of a different method to gather up which apps live on which nodes.

I'm going to refactor first and then we can come back to this.

I've tried refactoring it here: https://github.com/alphagov/govuk-puppet/pull/6822
Once that has gone, I will recode this PR.


Have the toggle show up as what the user specifies (i.e. off if previous save was off)

Something that Jon encountered: When I turn my toggle off while making my profile, once I click "preview profile" the toggle is taken back to its default of on. Can we have the toggle respect what the user specifies and only have the default occur at the generation of a profile

ffdc99e


fix exception when visit page '/metrics/relation' has no Authorizatio…

PR-Type: [Bugfix]
PR-Content: fix exception when visit page '/metrics/relation' has no Authorization in http headers!

Codecov Report

Merging #586 into develop will not change coverage by %.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             develop     #586   +/-   ##
==========================================
  Coverage      21.44%   21.44%
  Complexity       315      315
==========================================
  Files             88       88
  Lines           3516     3516
  Branches         557      557
==========================================
  Hits             754      754
  Misses          2684     2684
  Partials          78       78

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fdc6567...eb0717e. Read the comment docs.

thanks for your contribution


Unable to ignore react-rule-unsafe-ref

Flow version: 0.244.0
We're running into an issue where react-rule-unsafe-ref prevents us from passing anything useRef -related from a parent component to a child component. We've tried // $FlowIgnore it but it doesn't seem to work for this very specific rule. We can't reproduce the same issue with Try Flow.

We've tried adding a mounted -control variable that only allows the .current -property through after the component has been mounted, but that's of no help. How are you intended to refine / guard against this particular scenario? There's nothing in the docs concerning this.
We tried upgrading to 0.245.2 but that will simply start to repeatedly crash the Flow server with an endless loop of:
Called from Flow_js.M__flow.mk_type_destructor in file "src/typing/flow_js.ml", lines 6436-6439, characters 8-9
Called from Flow_js.M__flow.__flow in file "src/typing/flow_js.ml", line 395, characters 23-73
Called from Tvar.mk_no_wrap_where in file "src/typing/tvar.ml", line 33, characters 11-27
Called from Flow_js.M__flow.mk_type_destructor in file "src/typing/flow_js.ml", lines 6436-6439, characters 8-9
Called from Flow_js.M__flow.__flow in file "src/typing/flow_js.ml", line 395, characters 23-73
Called from Tvar.mk_no_wrap_where in file "src/typing/tvar.ml", line 33, characters 11-27
Called from Flow_js.M__flow.mk_type_destructor in file "src/typing/flow_js.ml", lines 6436-6439, characters 8-9
Called from Flow_js.M__flow.__flow in file "src/typing/flow_js.ml", line 395, characters 23-73
...

We make the react-rule errors not suppressible without error code, so you have to suppress with $FlowFixMe[react-rule-unsafe-ref]. It would also be nice to get a repro of the infinite loop case

Thanks for the info @SamChou19815 - Would be nice to maybe have that detail mentioned in the docs?
As far as the error goes, we tracked it down to this global definition:
declare var React: $Exports<'react'>;

^ In any version after 0.244.0 this triggers the infinite loop I described. If you switch that to:
declare var React: any;

... Then it triggers a whole host of other React-related errors, for example:
Cannot use Node as a type because it is an any-typed value. Type Node properly, so it is no longer any-typed, to use it
as an annotation. [value-as-type]


Improve function descriptor

Little bit cleaner implementation.

Codecov Report

Merging #17 (26f5362) into main (8d9d812) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main       #17   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files            4         4
  Lines          258       255    -3
  Branches        51        51
=========================================
- Hits           258       255    -3

Flag
Coverage Δ

unittests
100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

autoregistry/registry.py
100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


Adding an outgoing artifact using configuration.outgoing.artifact fails when consumed in a multi-project setup

It seems like using configurations.outgoing.artifact does not expose the artifact or configuration or something as a published artifact of the project.
Expected Behavior
Dependency resolution in multi-project build should succeed when using configuration.outgoing.artifact to declare an outgoing artifact of the build.
Current Behavior
Build fails because it says configuration 'createdConfig' which is not declared in the descriptor for project :a.
Context
I was trying to migrate some configuration creation and publishing using the new APIs in https://github.com/gradle/gradle/issues/5664 . I wanted to make the configuration creation and usage from other projects only resolve/build when needed and tried to reduce the example down and ran into this.
Steps to Reproduce (for bugs)
settings.gradle.kts
rootProject.name = "kotlin-dsl-lab"

include("a", "b")

a/build.gradle.kts
val createdConfig by configurations.creating {
  outgoing.artifact(file("build.gradle.kts"))
}

//artifacts {
//  add(createdConfig.name, file("build.gradle.kts"))
//}

b/build.gradle.kts
val createdConfigDep by configurations.creating

dependencies {
  createdConfigDep(project(path = ":a", configuration = "createdConfig"))
}

When running ./gradlew it fails with:
* What went wrong:
Could not resolve all files for configuration ':b:createdConfigDep'.
> Could not resolve project :a.
  Required by:
      project :b
   > Project :b declares a dependency from configuration 'createdConfigDep' to configuration 'createdConfig' which is not declared in the descriptor for project :a.

If instead In a/build.gradle.kts the below is used it works as expected.
val createdConfig by configurations.creating {
//  outgoing.artifact(file("build.gradle.kts"))
}

artifacts {
  add(createdConfig.name, file("build.gradle.kts"))
}

Output:
> Configure project :b
createdConfigDep: /home/mkobit/Workspace/code_lab/kotlin-dsl-lab/a/build.gradle.kts

Your Environment

Build scan URL: https://scans.gradle.com/s/pk5rm62jqndye

A similar issue when using the configuration avoidance APIs
a/build.gradle.kts
val registeredConfig by configurations.registering

registeredConfig.configure {
//  outgoing.artifact(file("build.gradle.kts"))
  artifacts {
    add(name, file("build.gradle.kts"))
  }
}

b/build.gradle.kts
val registeredConfigDep by configurations.creating

dependencies {
//  createdConfigDep(project(path = ":a", configuration = "createdConfig"))
  registeredConfigDep(project(path = ":a", configuration = "registeredConfig"))
}

//project(":a").configurations.forEach {
//  println("config ${it.name}")
//}
registeredConfigDep.resolve().forEach {
  println("registeredConfigDep: $it")
}

If the project(":a").configurations.forEach { part is uncommented, then the dependency works as expected.


Item with short update interval doesn't get reflected fast enough on Grafana

Hello all, how are you?
First of all, I want to say big thanks for your wonderful piece of work. It's really appreciated! ;-)
Secondly, I have a "little" issue, that unfortunately, I can found to answer via the various web data-sources:
I have an item that being updates each 3 seconds on the Zabbix side. On Grafana, the update result get's only after two or more minutes. Configuring lower auto-refresh on the dashboard doesn't help. It's seems like the API call is not happening as fast as I need. Any clue? detail? idea?
Any lead will be really appreciated!
Big thanks again - for your time, efforts and good will!
+Daniel.

Hi, @mrdanielmor ! Thanks! I think it may caused by time mismatch in browser and zabbix server. Check also time range in Grafana. In latest version default looks like this: now-1m. It mean to one minute before.

Hi @alexanderzobnin, how are you?

Big thanks for your response and even bigger thanks for the effort! ;-)
Please note that the Zabbix and the Grafana services installed on the same server. The "Time picker" definitions on the dashboard configured as follows:
** Auto-refresh = 1s,5s,30s,1m,5m,15m,30m,1h,3h,2h,1d
** Now delay now- = 0m (that if I'm understanding right, should say that "now" is really "now" ;-))
Any other idea? can you please elaborate on the "mismatch in browser and zabbix server" part? I've didn't get it ;-)

Good day!
+Daniel.

Ok, if time is synced, may be problem on Zabbix side? Do you know, does Zabbix cache data before write it to database? I'm not sure - Zabbix has history cache, but I don't know how it uses this cache.

Hi @alexanderzobnin, thanks again.
I think that I've succeeded to narrow down the issue! I'm facing this issue using Singlestat, so, I've tried to use Graph, and while using Graph - the results are updated on real-time! So - it's something that's relevant to Singlestat. Is there any lead? something that could be checked, etc.?
BTW, just in-order to get aligned - Zabbix do cache data, BUT, I've done a database check, using the following command (when item 23816 is the relevant item):
use zabbix;
select * from history_uint where itemid="23816" ORDER BY clock DESC LIMIT 1;

And saw that the DB record is updated as expected.
Will appreciate your response.
+Daniel.

Hi, it's me again!
I found the issue. For some reason - which I'm still trying to understand, although I've changed the Singlestat to current value, apparently, this configuration didn't came up and because of it, the average was outputted and that was the reason for the "not reasonable" number that I've seen.
Sorry for nagging and thanks for the help!
+Daniel.

@mrdanielmor yes, SingleStat default behaviour is a bit obvious sometimes.


Break Update reconcile function into smaller parts

First, we add a Yield method that will return true if the result's content indicates that no further processing should be done.
Then using the Result.Yield method, we can more easily separate parts of the rather large Update function into sub-routines each returning Done if that sub-routine has nothing else to do or setting an error or requesting a Requeue.
View with -w (ignore whitespace) as well as default to see that most of this patch is moving chunks of Update into new functions.
I think this is a nice small tweak on the existing Result type that enables building "nested" reconcile functions. I'm throwing ths out there as a Draft first to see what you think.
Depends on: #239

/test centos-ci/sink-clustered/mini-k8s-1.24

/test  centos-ci/sink-clustered/mini-k8s-1.24

/test centos-ci/sink-clustered/mini-k8s-1.24

Overall, looks very nice!
Few minor style comments.

/test centos-ci/sink-clustered/mini-k8s-1.24

centos ci is stuck? I'm going to poke it again but right now it appears to be still pending since yesterday (?):  Pending — Build triggered for merge commit.

/test centos-ci/sink-clustered/mini-k8s-1.24

Pending — Build triggered for merge commit.

This is the current status for centos-ci/sink-clustered/mini-k8s-1.23 and was a side effect of some changes done at jenkins deployment. We should be looking at centos-ci/sink-clustered/mini-k8s-1.24.

Oh, I totally missed that. Thanks.

Since that 1.23 item probably isn't going to get unstuck I'm joint going to merge with admin power.


[Feature][Gitlab] Automatic fetching newly created gitlab projects

Search before asking

[X] I had searched in the issues and found no similar feature requirement.

Use case
As a devlake maintainer, I would expect no extra effort for maintaining newly created gitlab projects
Description
Though data scope for gitlab can now select a subgroup to include all projects underneath it. But with company's fast growth, new gitlab projects would be created frequently and it would be impossible for devlake maintainer to acknowledge and maintain them.
So, I think a certain group should also be accepted as a data scope selection and data fetching should automatically adapt to current project list under that group.
Related issues
No response
Are you willing to submit a PR?

[ ] Yes I am willing to submit a PR!

Code of Conduct

[X] I agree to follow this project's Code of Conduct

Collecting votes.
It'll be great if you can also tell us more about your use cases of this feature. We'll consider doing it if more users with specific metric needs want this feature.

@Startrekzky our company has many (about 150+) git repos for different micro-services and still growing... and they're under different gitlab groups. We created multiple blueprints for different groups for easier management and quicker sync speed. But, to make sure our git commit analysis accurate we'll always need to make sure that the blueprints have all the matching projects selected, so we need to edit the data-scope and expand groups and groups and check the newly created projects.....  especially when we have a big group that contains about 100 projects... it's a disaster to check and select all the projects.
In my opinion, devlake aims for data analysis, so it would be a common case for maintainer to select 'all projects under a certain group' instead of picking some of them.

+1
I am currently facing a similar requirement within our company. With a portfolio of over 300 repositories, I am actively exploring the optimal approach to automate the creation process, seeking to eliminate manual intervention wherever possible.

Hi @EvanChen1989 @KelvinVenancio , thanks for the feedback. I have several questions about your use cases:

Among the new repos created in the configured GitLab groups, will there be repos that you don't want to collect by default? E.g. repos for libraries, images, docs, etc.
What's the frequency of adding new repos to existing GitLab groups? Once a week/month/season?
How do you manage your 250+ repos in GitLab, do you have nested groups?
How do you organize your GitLab repos in DevLake, one DevLake project for all repos under the same GitLab (root/sub) group?

@Startrekzky thank for the attention, per your questions:

Newly created repos usually are needed to collect, resources are usually put under other groups. And even when they're put in wrong place, we're happy to filter them out during analysis other than picking the right ones into selection frequently.
The frequence could be like 1 repo per-week in average and could be like 4-5 per week when needed, it depends on system requirement. The hard part is that usually we're not awared of all the repo creating operation across teams.
For now we don't have much requirement on nested groups, the current usage depth should be 2.
We create different blueprints for different groups, and due to some historical problems certain groups contains a large number of repos. Now I'm splitting them into 4 grouops divided by alphabetic cuz when we found no data for certain repo, it's a nightmare to search through the blueprint and find if it's included...it's not even sorted during display :(

@Startrekzky

I mean if some source repos are wrongly put into project groups, we can fitler them out or let the gitlab maintainer to move them away. And it should be a rare case.
We're now on v0.17.0-beta4, and now we have only one project and multiple bludprints under it.

@EvanChen1989 Got it. Just let you know that the stable v0.17.0 has been released too if you are not planning to upgrade to v0.18

+1, trialling DevLake on a GH org with 12k+ repos

@Startrekzky just noticed on v0.19.0-beta2 the edit data scope function seems has been changed, and group hierarchy is gone... this is NOT what I expected :( ... because I don't expect to sync ALL gitlab data in ONE blueprint, it could cost so long time for one run. Please help look into it

..., and group hierarchy is gone... this is NOT what I expected :( ... because I don't expect to sync ALL gitlab data in ONE blueprint...

Hi @EvanChen1989 .  I'm a bit confused. The group hierarchy is gone, but it doesn't mean that all repos are selected. The selected repos are still the repos you selected at the first place.


e2e test for cluster config change - GITOPS-1003

What type of PR is this?
/kind enhancement
What does this PR do / why we need it:
This PR add the following test case.
Create an argocd application CR that has source folder containing a manifest of an config map in openshift-config project
oc apply -f the argocd application CR
Verify that the openshift cluster-config resource is deployed. Verify that the argocd application is healthy and sync'ed.
Have you updated the necessary documentation?
Documentation update is required by this PR.
Documentation has been updated.
Which issue(s) this PR fixes:
Fixes - https://issues.redhat.com/browse/GITOPS-1003
Test acceptance criteria:
Unit Test - NA
E2E Test
How to test changes / Special notes to the reviewer:

/retest

@ishitasequeira Can you please rebase.

looks good to me. However i seek someone's review from the team. ping @wtam2018
/approve

/lgtm


Refactor dyamic cache to use namespaced informers

What this PR does / why we need it:
Adds more clarity around the nuances of the informer cache and why various informer factories were used throughout the project. Also cleans up misc console warnings/errors.
Which issue(s) this PR fixes

Fixes #1172

Special notes for your reviewer:
Binary is available curl -Lo octant https://storage.googleapis.com/octant-nightlies/octant and can run in the RBAC restricted lab environment via ./octant --namespace $SESSION_NAMESPACE --disable-open-browser --listener-addr <IP_ADDRESS>:10086 --accepted-hosts $SESSION_NAMESPACE-console.$INGRESS_DOMAIN
Signed-off-by: Sam Foo<EMAIL_ADDRESS>

I would like to see the tracing output of this running against our development cluster, before and after.

Not a scientific approach, it looks like the times to List on overview pages are roughly the same. For reference, this is on the team's development cluster on the default namespace.
0.20.0:

This branch:

Informers for CRD's are not shutting down after TestNewRunnerUsesClusterClient and causing a flake: E0602 14:39:15.354830 3784560 runtime.go:76] Observed a panic: Fail in goroutine after TestNewRunnerUsesClusterClient has completed. Taking a look into the test


Support for AWS mixins

This is a draft PR, it is broken right now because of a bug in dynamic annotation of inner classes

PR to core to fix the issue with SQSMessageMixin https://github.com/micronaut-projects/micronaut-core/pull/6721