Rewrite board creation as a for-cycle

https://github.com/zhukovdm/Congo/blob/b8a8af734534486bb3f842602b5ee56145b91321/Congo.Core/Game.cs#L47

Already looks good.


Mark players that fragged you for some time in the table

Requires https://github.com/atomy/mannco-mastermind/issues/15

Make it configurable (maybe later).

Also mark players you just fragged for a while. Maybe a slow blink.


tour: Incorrect instruction - possibly a typo

Context: https://tour.golang.org/welcome/3
The instruction says:
go get golang.org/x/tour tour
this gives
package tour: unrecognized import path "tour" (import path does not begin with hostname)
Tried another command
go get golang.org/x/tour/gotour
the tour was downloaded and installed.

I just realized we need a " ; " to fix it.
so the command
go get golang.org/x/tour tour
becomes
go get golang.org/x/tour ; tour
this would fix this issue and #633

Just tour after the go get ... also doesn't always work. At least not today on my macOS machine.
Perhaps the command go tool tour should be mentioned - that could be a option that works in more cases. (Similar comment made in https://github.com/golang/tour/issues/633#issuecomment-451550675.)

I experienced a similar issue on my Mac where
go get golang.org/x/tour
was returning 'unrecognized import path "golang.org/x/tour" ... x509: certificate signed by unknown authority'.
As this would fail then the tour command obviously wouldn't work neither.
The solution was to get the tour using the -insecure flag:
go get -insecure golang.org/x/tour

this works for me
go get golang.org/x/tour && tour

After running go get golang.org/x/tour (and pretty much all other commands everyone's listed here, except -insecure), found tour.exe and gotour.exe in workspace's bin folder.
tour.exe works perfectly ~ 14MB.
gotour.exe doesn't ~ 1.3MB.
P.S.  Using Windows.

I am using MSYS2 MINGW64, after go get -u github.com/x/tour
run tour got
tour
zsh: command not found: tour

And this command success
go run github.com/x/tour
2020/06/27 20:02:55 Serving content from C:\Users\user\go\src\github.com\x\tour
2020/06/27 20:02:55 A browser window should open. If not, please visit http://<IP_ADDRESS>:3999
2020/06/27 20:02:57 accepting connection from: <IP_ADDRESS>:3011
2020/06/27 20:03:04 accepting connection from: <IP_ADDRESS>:3025
2020/06/27 20:03:15 running snippet from: <IP_ADDRESS>:3025


Enhancement: Plots advanced stratification

Description
Linked to #127
Option for advanced stratification/grouping and faceting for plots by other variables, eg Analyte, Matrix, Age, Sex , SUBJID etc.
Definition of Done
The requirements for the feature to be complete:

[ ] Ability for plots to be grouped by multiple variables, any other columns in the dataset.
[ ] Ability for plots to be faceted by optional variables eg analyte

FYI, this seems like just the kind of thing that the ggtibble library was made for. It allows for lists of plots to be created with consistent formatting and easy definitions of captions and axis labels which may differ between the plots in the list.


Implement Entity List Display and rework StorageComponent window

About the PR
Implements a control for displaying lists of entities.
Reworks StorageComponent window to use the new control.
Going to move the UI to XAML in another PR and then add more functionality to the buttons.
Screenshots

New | Old | Old no scrollbar

Due to moving the icon and text into a ContainerButton instead of having a button behind the text, the size has increased a bit, but icon spacing looks better.

Icons look much better, scrollbar looks much worse.
Scrollbars shouldn't overlap content tbh

Updated with scrollbar push.


How to access Texts in using typescript

Hi
I would like to access the following in xxDialog.ts and display as message. My aim is to display translated text to user of the current language. For example I would like to access AcceptTerms from the following Texts.ts file or anyway to access it.
            namespace SignUp {
            export const AcceptTerms: string;
            export const ActivateEmailSubject: string;
            export const ActivationCompleteMessage: string;
            export const BackToLogin: string;
            export const ConfirmEmail: string;
            export const ConfirmPassword: string;
            export const DisplayName: string;
            export const Email: string;
            export const FormInfo: string;
            export const FormTitle: string;
            export const Password: string;
            export const SubmitButton: string;
            export const Success: string;
        }
    }

Q.text('some.text.key') this will return translated text

@dfarugue
Thank you
It works as expected.


Video rotation metadata should also be considered

Thank you for creating pyvideothumbnailer!
Some videos recorded with my old phone have the rotation metadata set to 90, however the script doesn't consider this metadata. So instead of 9x16 thumbnails I was still getting 16x9.
I fixed it by:
# Extract rotation value if available
        video_rotation = None
        if 'rotation' in video_metadata:
            video_rotation = float(video_metadata['rotation'])
            #print(f'Video rotation is: {video_rotation}')
        if video_rotation is not None:
            if video_rotation == 90:
                print("Rotation is 90 degrees.")
                video_width = int(video_metadata['height'])
                video_height = int(video_metadata['width'])

        # Aspect ratio
        video_aspect = float(video_width) / float(video_height)

if frame.pts >= target_timestamp:
                            # VideoFrame.to_image() returns a PIL image
                            #image = frame.to_image().resize((thumbnail_width, thumbnail_height))

                            #Przemek:
                            image = frame.to_image()
                            # Apply rotation if needed
                            if video_rotation == 90.0:
                                #image = image.transpose(method=Image.Transpose.ROTATE_90)
                                image = image.rotate(-90, expand=True)
                            elif video_rotation == 180.0:
                                #image = image.transpose(method=Image.Transpose.ROTATE_180)
                                image = image.rotate(180, expand=True)
                            elif video_rotation == 270.0:
                                #image = image.transpose(method=Image.Transpose.ROTATE_270)
                                image = image.rotate(-270, expand=True)
                            image = image.resize((thumbnail_width, thumbnail_height))

                            thumbnails_image.paste(image, box=(x, y))
                            frame_captured = True
                            break

Maybe this change could be imported to the project? I am still not sure how it behaves with the rotation of 180 or 270.

Thank you for making this proposal. Counterrotating of rotated images was added with commit bedf55b8bf56e81ea7e715f1e3e819504f5a0eaf. It is now supported in release 2.1.0.


Refactor attribute definer for entity

Since we have now separate method in Entity, that define attribute accessor, we can use it, and not override whole attributes function.
That can also lead to bug, because dirty tracking using new approach, while validation override whole attributes, so define_attr_accessor never invoked.

:+1:

@dsnipe Thanks for this PR. Merging this without a proper test coverage is dangerous, because it uses a private method from another gem. In the past we experienced regressions due to the lack of sync with Entity implementation in https://github.com/lotus/model
Can you please add an integration test of dirty tracking here?: https://github.com/lotus/validations/blob/master/test/integration/lotus_entity_compatibility_test.rb
Once this will be done, I'm :+1: for merging this. Thank you :cat2:

@dsnipe @AlfonsoUceda I'm going to merge it now and to write additional tests.
This fixes Lotus::Model builds https://travis-ci.org/lotus/model/builds/61315554 and https://travis-ci.org/lotus/model/builds/61523677, relative to https://github.com/lotus/model/pull/182 and https://github.com/lotus/model/pull/184 respectively.
This regression was introduced by https://github.com/lotus/validations/pull/55

@dsnipe @AlfonsoUceda @joneslee85 DirtyTracking doesn't work with validations. I've tried to implement it here, but it's a mess. I'm for keeping partial compat with Entity for now.

@jodosha I'm busy in that week, but hopefully will find some time on the next and dig in in that problem.

@dsnipe That would be great. Thank you! :+1:


data decoder doesn't work with 0 predicted boxes

ids = score > CLS_THRESH
ids = ids.nonzero().squeeze()             # [#obj,]
keep = box_nms(boxes[ids], score[ids], threshold=NMS_THRESH)
return boxes[ids][keep], labels[ids][keep]

When there are no positive ids (where score > CSL_TRESH) code tries to index with empty tensor and that raises a PyTorch error

fixed in #11


Download-Artifacts throws Mutex exception "Access to the path ... is denied"

Scenario
I have a VM with 6 Azure DevOps Agents that share an Agent Pool. In that pool of 6 agents I am running multiple pipelines simultaneously that need to download the same BC artifacts. If the pipelines start running at the same time, the Download-Artifacts step fails most of the time. This is also the case when I use a matrix strategy in a single pipeline with maxParallel > 1 (i.e. it is running the same steps from multiple agents on the server at the same time).  I get the error when the mutex is created. All agents are running under the same service account that has admin privileges and full control over the bcartifacts.cache folder.
New-Object : Exception calling ".ctor" with "2" argument(s): "Access to the path 'dl-bcartifacts.azureedge.net_onprem_21.1.48363.48638_w1' is denied."

This Pipeline will fail most of the time, unless I increase the Start-Sleep delay to e.g. 1000 milliseconds
trigger: none
stages:
  - stage: Download
    jobs:
      - job: DownloadConcurrent
        strategy:
          maxParallel: "2"
          matrix:
            RunOne:
              delay: 0
            RunTwo:
              delay: 250
        steps:
          - task: PowerShell@2
            inputs:
              pwsh: true
              targetType: inline
              script: |
                Start-Sleep -Milliseconds $(delay)
                $artifactUrl = Get-BCArtifactUrl -type "OnPrem" -version "21.1" -country "w1"
                Download-Artifacts -artifactUrl $artifactUrl

Output of the PowerShell step for the failing Run
Starting: PowerShell
==============================================================================
Task         : PowerShell
Description  : Run a PowerShell script on Linux, macOS, or Windows
Version      : 2.226.1
Author       : Microsoft Corporation
Help         : https://docs.microsoft.com/azure/devops/pipelines/tasks/utility/powershell
==============================================================================
Generating script.
========================== Starting Command Output ===========================
"C:\Program Files\PowerShell\7\pwsh.exe" -NoLogo -NoProfile -NonInteractive -ExecutionPolicy Unrestricted -Command ". 'C:\agent_build01\_work\_temp\b04648b8-76d6-4ef3-af31-7523a49777d7.ps1'"
BcContainerHelper version 5.0.4
BC.HelperFunctions emits usage statistics telemetry to Microsoft
Running on PowerShell 7
Download-Artifacts Telemetry Correlation Id: 219ea7e0-d9c4-473c-9a7e-b813fed0b982
New-Object : Exception calling ".ctor" with "2" argument(s): "Access to the path 'dl-bcartifacts.azureedge.net_onprem_21.1.48363.48638_w1' is denied."
At C:\Program Files\PowerShell\Modules\BcContainerHelper\5.0.4\Artifacts\Download-Artifacts.ps1:48 char:17
+ …  $appMutex = New-Object System.Threading.Mutex($false, $appMutexName)
+                ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
+ CategoryInfo          : InvalidOperation: (:) [New-Object], MethodInvocationException
+ FullyQualifiedErrorId : ConstructorInvokedThrowException,Microsoft.PowerShell.Commands.NewObjectCommand
##[error]PowerShell exited with code '1'.
Finishing: PowerShell

Output of the PowerShell step for the successful Run
Starting: PowerShell
==============================================================================
Task         : PowerShell
Description  : Run a PowerShell script on Linux, macOS, or Windows
Version      : 2.226.1
Author       : Microsoft Corporation
Help         : https://docs.microsoft.com/azure/devops/pipelines/tasks/utility/powershell
==============================================================================
Generating script.
========================== Starting Command Output ===========================
"C:\Program Files\PowerShell\7\pwsh.exe" -NoLogo -NoProfile -NonInteractive -ExecutionPolicy Unrestricted -Command ". 'C:\agent_build02\_work\_temp\dbcd514d-87cf-49ba-be1c-70dc5d39373d.ps1'"
BcContainerHelper version 5.0.4
BC.HelperFunctions emits usage statistics telemetry to Microsoft
Running on PowerShell 7
c:\bcartifacts.cache\onprem\21.1.48363.48638\w1
Finishing: PowerShell

Interestingly, the following pipeline does not seem to fail
trigger: none
stages:
  - stage: Download
    jobs:
      - job: Download
        steps:
          - task: PowerShell@2
            inputs:
              pwsh: true
              targetType: inline
              script: |
                $artifactUrl = Get-BCArtifactUrl -type "OnPrem" -version "21.1" -country "w1"
                @($artifactUrl , $artifactUrl, $artifactUrl , $artifactUrl , $artifactUrl , $artifactUrl) | ForEach-Object -Parallel { Download-Artifacts -artifactUrl $_; } -ThrottleLimit 6

Starting: PowerShell
==============================================================================
Task         : PowerShell
Description  : Run a PowerShell script on Linux, macOS, or Windows
Version      : 2.226.1
Author       : Microsoft Corporation
Help         : https://docs.microsoft.com/azure/devops/pipelines/tasks/utility/powershell
==============================================================================
Generating script.
========================== Starting Command Output ===========================
"C:\Program Files\PowerShell\7\pwsh.exe" -NoLogo -NoProfile -NonInteractive -ExecutionPolicy Unrestricted -Command ". 'C:\agent_build01\_work\_temp\3e159c7e-0f0a-4489-965e-b87dc8e3cbd3.ps1'"
BcContainerHelper version 5.0.4
BC.HelperFunctions emits usage statistics telemetry to Microsoft
Running on PowerShell 7
BcContainerHelper version 5.0.4
BcContainerHelper version 5.0.4
BcContainerHelper version 5.0.4
BcContainerHelper version 5.0.4
BcContainerHelper version 5.0.4
BC.HelperFunctions emits usage statistics telemetry to Microsoft
BcContainerHelper version 5.0.4
BC.HelperFunctions emits usage statistics telemetry to Microsoft
BC.HelperFunctions emits usage statistics telemetry to Microsoft
BC.HelperFunctions emits usage statistics telemetry to Microsoft
BC.HelperFunctions emits usage statistics telemetry to Microsoft
BC.HelperFunctions emits usage statistics telemetry to Microsoft
Running on PowerShell 7
Running on PowerShell 7
Running on PowerShell 7
Running on PowerShell 7
Running on PowerShell 7
Running on PowerShell 7
c:\bcartifacts.cache\onprem\21.1.48363.48638\w1
c:\bcartifacts.cache\onprem\21.1.48363.48638\w1
c:\bcartifacts.cache\onprem\21.1.48363.48638\w1
c:\bcartifacts.cache\onprem\21.1.48363.48638\w1
c:\bcartifacts.cache\onprem\21.1.48363.48638\w1
c:\bcartifacts.cache\onprem\21.1.48363.48638\w1
Finishing: PowerShell

It seems to me that the error only occurs when code is running concurrently on two different agents. Any idea what could cause this? I can partially work around this by not running matrix strategies, however builds will still fail if two pipelines happen to start running at the same time.
Note: Usually I'm not running Download-Artifacts directly. In my actual pipelines I'm getting the error when calling New-BcContainer or when using e.g. the ALOpsAppCompiler@2 build step.

Can you repro this on your own machine?
or on the Azure VM hosting your agents - by simply using PowerShell?
I cannot:

I tried with combinations of PS5 and PS7 as well - no problems.
I also never saw this on any of my runners, having multiple agents.

In your -asparallel pipeline - it never displays:
Waiting for other process downloading artifact 'https://bcartifacts.azureedge.net/sandbox/22.4.59114.59980/be
causing me to believe that the artifacts were cached and never really downloaded.
When I run that command - I get the waiting... line and it is waiting.

I am running a Windows Server 2022 VM on onprem hardware.
I cannot reproduce the issue outside of the failing pipeline. I've tried PS5, PS7, with and without running as admin. None have the same issue as within the pipeline.
In the original issue I had already downloaded the artifacts, so yes, they were cached. I can confirm that the pipeline issue occurs both for the situation where the artifacts are cached, as well as when the artifacts need to be downloaded. If I remove the cache and use powershell twice, then I correctly get the 'Waiting for other process...' message. If I remove the cache and run the pipeline a second time while a previous pipeline is still downloading, then I get the error.

In general, running agents as a service account or an account with limited permissions is preferred anyway.
Running the agent as a domain user might not be very secure.


Navigation

Unlike the normal deezer application this one does not have navigation buttons at the top of the screen. this is really annoying because you can't go back to the previous page. for example if you are looking at albums by an artist, there is no way to go back to the previous page, so everytime you want to look at a different song or album you have to search the name of the artist over and over again.

Hi, it should be fixed in the latest release :) https://github.com/JustYuuto/deezer-discord-rpc/releases/tag/1.3.0

hi, i just updated to the new version, but there is still no naviation buttons. also, my music haven't been showing on discord for a while now, even after updating to the newest version.

try uninstalling the reinstalling the app, this is weird

i already tried that twice. also my music isn't showing on discord for a while now, even after the update. today it worked for the first time in 3 weeks, but it stopt working after i restarted the app

i accidentally found the issue. for some reason if i have battery saver turned on in windows, the rpc does not work, but as soon as i turn it of and then restart the app my music finally shows on discord. as soon as i turn on windows batery saver it immediately stops working tho.

Well I didn't know Windows battery saver could cause this.


Passwordless authentication

Hi, I'm trying to get this sample to work with passwordless authentication.
I have all of that enabled on my tenant, and it works fine in my own OAuth2/OIDC PKCE apps, but I do not get the option to choose passwordless in the sign-in methods in the Electron app.
Is this simply not supported, or am I missing something?
Thanks,
Ted

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 513e58c2-8752-9286-415e-b3dc1e5fba54
Version Independent ID: b9a6ea0d-8eac-42b7-0a48-387ca491e6ea
Content: Tutorial: Sign in users and call the Microsoft Graph API in an Electron desktop app - Microsoft identity platform
Content Source: articles/active-directory/develop/tutorial-v2-nodejs-desktop.md
Service: active-directory
Sub-service: develop
GitHub Login: @derisen
Microsoft Alias: v-doeris

@tvdvoorde Thank you for sharing your query! We are currently investigating and will get back to you shortly on this.

@tvdvoorde apologies for delay. As you guessed, passwordless authentication is not supported for public client apps (such as desktop and mobile apps), as this might make them more susceptible to spoofing and other security threats (single-page apps are also technically "public clients", but they enjoy higher security by using features like PKCE and etc.)

no further action to take at the moment, #please-close


Improve the Log Viewer in the Web UI

Proposal

Re-style and colorize the logs received in the UI
Receive and display logs from the workers

@cyberw Opening as a draft just to check that worker logs are something we want to add and then I will add tests for this

This looks great. Can we maybe limit the number of log messages sent from workers to something like 10 per log interval? (I dont want workers spamming the master)
And also, if there are no logs, skip sending the message entirely (typically the workers should be very quiet)
And it needs some basic tests too.

Side note: if we switch from mypy to pylance/pyright it might become fast enough to add it to the precommit hook.

I updated now so that we only push worker logs when we see new logs. I think this should be sufficiently quiet since the workers rarely log more than one or two logs unless there are issues

Not suggesting adding another flag but would "worker logs being sent to master" be configurable in some way?
Not sure if we're alone but not uncommon to run with hundreds -> thousands of worker processes and 100k+ users attached to a single master
In larger scenarios it might get absolutely obliterated

Not suggesting adding another flag but would "worker logs being sent to master" be configurable in some way?
Not sure if we're alone but not uncommon to run with hundreds -> thousands of worker processes and 100k+ users attached to a single master
In larger scenarios it might get absolutely obliterated

Good point. We might want to think a little more on this. But in the normal case, workers should be kinda quiet though?

Not suggesting adding another flag but would "worker logs being sent to master" be configurable in some way?
Not sure if we're alone but not uncommon to run with hundreds -> thousands of worker processes and 100k+ users attached to a single master
In larger scenarios it might get absolutely obliterated

Good point. We might want to think a little more on this. But in the normal case, workers should be kinda quiet though?

Normally you'd expect so yeah, don't think anyone's going to be logging out info during task executions or anything, more likely that a cascading failure kills the master if, say an external SUT goes down and suddenly all the workers start logging large error logs with exception traces at the same time
(btw the log beautification is immense, well played @andrewbaldwin44 👏)

@mquinnfd Thanks for the comments! There is some logic for sending the logs from the workers. For example, if there are no new messages, plus it will quit sending messages all together if the worker tries to send > 10 logs at one time

@mquinnfd WORKER_LOG_REPORT_INTERVAL may now be overridden and if set to a negative value, it will be disabled completely

@mquinnfd WORKER_LOG_REPORT_INTERVAL may now be overridden and if set to a negative value, it will be disabled completely

Hero!
I use this as a library as well so I have a few options, but this is a grand compromise

Also recommending something like Colourblindly here for the log colours as the text itself is fairly narrow - don't wanna inadvertently make some entries harder to read
There a good write-up on this here (but you probably already know your way around this as a FE specialist 🙇)

Yeah Lighthouse works really well for testing contrast between colors, rather than just guessing by eye

I haven't been paying much attention to accessibility but it's never a bad idea, I'll make the colors a little darker :+1:

You know what would make this even more awesome? If you could make the headings for each worker the same color as the highest log level from that worker.

Send it?

Yup it's ready! :rocket:


updateServiceShards only for non k8s registry

Prevent redundant calling updateServiceShards  for k8s registry before each push.
This is kind of performance optimization.

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: hzxuzhonghu
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

pilot/OWNERS [hzxuzhonghu]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@howardjohn update desc

@hzxuzhonghu: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-integ-k8s-tests.sh
aca17fd832f7b738efb3369521efa257b56a2c67
link
/test istio-integ-k8s-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hzxuzhonghu: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-integ-k8s-tests.sh
aca17fd832f7b738efb3369521efa257b56a2c67
link
/test istio-integ-k8s-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.


Store correct values for v3 XX population frequencies

There should be no need for this code in the API:
https://github.com/broadinstitute/gnomad-browser/blob/74700d7b0df087f3caca8f086155b691af7370b1/graphql-api/src/queries/variant-datasets/gnomad-v3-variant-queries.js#L120-L133

Currently, AC, AN, and homozygote count are all missing for XX populations of chrY variants.


Blake2b/s digest lenghts

I'm slightly confused by the documentation and the actual implementation of the Blake2b and Blake2s digests. The documentation clearly says Blake2b supports digest lengths of 1-64 bytes (8-512 bits), and Blake2s supports 1-32 bytes (8-256 bits).
"BLAKE2b is optimized for 64-bit platforms and produces digests of any size between 1 and 64 bytes."
"BLAKE2s is optimized for 32-bit platforms and produces digests of any size between 1 and 32 bytes."
Current implementations does not support this as those throws on any other than 160, 256, 384 or 512 bits for Blake2b and 128, 160, 224 or 256 bits for Blake2s.
Hoping I'm not making a fool out of myself as I'm no crypto expert.

From the [https://blake2.net/blake2.pdf](official blake2 document) paragraph 2.8, it clearly says «Digest byte length (1byte): an integer in [1,64] for BLAKE2b, in [1,32] for BLAKE2s», so I’m pretty sure the implementations are wrong and not the documentation. Most other implementations I’ve seen (even the official c implementation) supports any digest length.


Telekinetic feat bonus action not being spent properly when used on self

Game version 1.4.33, Mod version <IP_ADDRESS>, no other mods
When a character with the Telekinetic feat uses the bonus action to move someone, the bonus action is only spent whent it is used on an enemy or party member. When used on self, you can use it a seemingly infinite amount of times.
https://i.imgur.com/9zB8oRI.jpeg

That's weird. It shouldn't behave differently for self or others. Will look into it

Hm... looks like game interrupts your current action (using the telekinetic power) when you are pushed, which leads to bonus action point not being consumed.

This is a very colateral case. Why would you push yourself in battle? No easy fix here.


[Bug]: Imageis degraded after each generation

What happened?
After each inpaint or outpaint, the overall quality is degraded, like a blur filter is applyed each time. It is applied in all the selected square even if only partial inpaint is asked. It happens withinpainting and out painting too.
ps : my version is update, i have put all the blur option to zero.

Steps to reproduce the problem

Go to ....
Press ....
... [etc]

What should have happened?
In outpaint mode, the quality of the image stay the same, only the outside border is affected. In inpaint mode, only the red area is affected.
Commit where the problem happens
the last one, and this happen for the last commuts too
What platforms do you use to access openOutpaint?
Windows
What browsers do you use to access the UI ?
Mozilla Firefox
Browser Extensions/Addons
addons : adblock, always on top,
i tested it with chrome and it happen too.
some times when a put on "synch cursor size", and then i uncheck it, it stoped to do it....and after some generations, it turns back to it randomly.
AUTOMATIC1111 webUI Commandline Arguments
--api --xformers
Additional information
it seems like it is layer ralated because everytime it happen,  and i try to put the master layer on top again  then a flat the image, everything is mess up, and if i save it, only the last generation is saved and not the flatten layer. The only way to save it correctly is by making a selection and save "visible"...but even that some times fails, because it is saved but the layers are not in the same order as it is expected.
Anyway, i really want to thank you and your teram : i looooove your app, it is incredible, by far the best, even if it is less fancy than Invoke, it is much more conveniant and powerful. thanks

so i think exactly what you're looking for is going to be taken care of via the "keep unmasked" toggle (pushpin icon) :)

@zero01101 here the screenshot, i have try everything, keep unmak on or off,  put at the value zero or at the max, every generation  the image outside is beeing blurred :

really sorry to annoy you, but i thing it really is a probleme . thanks for your attention anyway . really love your App

sorry for the delay; out of curiosity, did you try that with the keep unmask option enabled? your image implies that you left it disabled which, yeah, that'd do nothing lol... the blur radius sets the amount of gaussian blur around the inpaint mask to blend the original vs returned inpaint but will only do anything if the option is enabled ;)
see https://github.com/zero01101/openOutpaint/issues/99 for further detail/info - it seems to be exactly what you're experiencing, and is precisely why the keep unmasked option was implemented :)

closing as stale for now


UAT admin can add static text/images to forms in addition to standard question types

The UAT admin can specify arbitrary text and images in addition to normal question types.
Like in Google Forms, it sometimes helps to have helper text and images sprinkled throughout a form.
Note that this isn't rich-text-formatted; this is just plain text. We can auto-format URLs as hyperlinks, though.

The text part of this is more important; the image part can come later.

Promoting the priority of this one because partner and CiviForm admins really want to see this feature.

To be clear, the way this works: instead of adding a Text or Number or Date question, you can add a Static Content snippet where you can just show arbitrary text. (Think of it like a Text input, but without the input field!)

I'm trying to split this into multiple smaller issues, but the way I see it we have:

Create a Static Content question type that's always answered and has no input options.
Format the static option question so that it supports advanced formatting (like the program description field).
Add options for inserting images with advanced formatting.
Add use advanced formatting checkbox to all other question types.
Perform formatting in JS so that we can see the advanced formatting in question previews.

1 and 2 are almost complete.
3 - 5 are also relatively straight forward.

Should be complete soon - PR out for review


how does nb_black locate the cell that is being formatted?

I encountered a problem that is presumably caused by nb_black (maybe together with scrathpad in jupyter_contrib_nbextensions)
After hitting ctrl-enter, the current cell isn't formatted, and later I found another cell is replaced by the formatted code. This causes a long notebook to be in a mess and I almost lost lots of work.
using anaconda 2019.10, jupyter_contrib_nbextensions and latest version of black & nb_black.

Hi @yuuuxt
I am really sorry to hear about that and hope that you could recover your work
The script is basically using the last running cell in the history log of the Jupyter Notebook to place the formatted code. I am suspecting that maybe another library tried to create/delete a cell or something that changes the history log while my script is being triggered so that caused your problem. Currently, this issue could be fixed completely on JupyterLab but not JupyterNotebook, so please stop using until your problem be resolved. Thanks!

Hi @dnanhkhoa ,
Thank you for your explanation. Luckily I found a backup and recovered the notebook.
I tried but I couldn't reproduce it in a new notebook, maybe it's a rare condition. If it's reproducible, a warning about this is necessary.

I think I had the some problem some months ago and submitted https://github.com/dnanhkhoa/nb_black/pull/12 as a possible solution to at least protect the integrity of the notebook. (If there are any changes in a cell, while it is executed, don't format and don't change the contents)
Maybe it helps you, I just use my forked branch since that time :snail:

Hi @hanfried ,
I saw your pull requests before but wasn't thinking of that kind of situation.
Thank you for your suggestion, but currently I just disable it. In fact I'm not in favor of black's suggested style when I'm mainly using pandas in notebook.

Hi @hanfried,
Sorry about that and thank you so much for the pull requests. I just have a look and see that it's clear to me so I will merge it to the master branch.


RPD

About the PR
Adds the RPD from this wizden pr - https://github.com/space-wizards/space-station-14/pull/32675
Also places it in atmos lockers, as well as some minor bug fixes.
Please see original PR for further information.
Requirements

[X] I have read and am following the Pull Request and Changelog Guidelines.
[X] I have added media to this PR or it does not require an ingame showcase.

Changelog
:cl:

add: Added Rapid Piping Device

Exceptionally based.


withComponent function not supported

Hey guys, thanks for the awesome library.
I noticed there is no way to pass tw an Element to wrap on the fly.
in styled-components I think you could do it with:
const StyledComponent = styled.div``
StyledComponent.withComponent(OtherComponent)

Got any idea how to use tailwind-styled-component with a component that is decided on runtime?
Thank you!

Doesn't this work?
const StyledComponent = styled.div``
const newComponent = tw(StyledComponent)``


Empty QC flag variables not being removed

QC flag variables that have no data in them are not being removed by the remove empty variables function. Problem is here https://github.com/joshua-hampton/ncas_amof_netcdf_template/blob/2.2.2/src/ncas_amof_netcdf_template/remove_empty_variables.py#L109 - qc flags don't have the valid_min attribute, so go to this check, and even though np.all(in_ncfile[var][:].mask) actually is True, this check fails to pick them up. Removing the is True part from this line works (and is generally better Python as well).

Closing issue as complete, fix to be released in v2.3.0


[Feature]: Improve error when unable to top up spending balance due to max liquidity limit

Describe the problem
When a user wants to transfer from savings to spending but are already very near to or have even exceeded the €950 limit they will get a message like:

It isn't clear what they can do to resolve the issue.
Describe the solution
We could suggest that they close one of their LN channels, perhaps the one with most inbound liquidity.
Additional context
No response

Verified in v1.0.8
When it is not possible to transfer any more funds from savings to spending due to zero available liquidity, the error now reads "You've reached the maximum for your spending balance."
Where there is some available liquidity, it still gives the $ amount when attempting to exceed the maximum.


[HackTogether] Fix Typo in Portal Landing Page

Are you accessing the project from the GitHub Codespaces?

[ ] No, I am running the project on my local machine (I will fill in the OS section below)
[x] Yes, I am using GitHub Codespaces.

Note: The project is optimized to run on Codespaces. We welcome contributions to enhance it for cross-platform local development, but it's not something we will prioritize right now. Thank you!

Describe the bug
There is a typo in the portal landing page, the statement ...across the glob,... should read ...across the globe,.... The word glob should be globe.
To Reproduce
Steps to reproduce the behavior:

In Codespaces, start the application using npm I && npm start
Navigate to the portal running on designated port 4280
Under the hero description, there's a statement with a typo that reads ...across the glob...

Expected behavior
The statement should read ...across the globe,....
Screenshots

OS (please complete the following information):

OS:
OS Version:
npm version:
Node.js version:
output of azd version:

Additional context
Add any other context about the problem here.

Hi @juliamuiruri4. Please validate if this should be addressed. I've already made a PR for it.


Nuzhy/85537/refactor partners page

Changes:

...

Type of change

[ ] Bug fix
[ ] New feature
[ ] Update feature
[x] Refactor code
[ ] Translation to code
[ ] Translation to crowdin
[ ] Script configuration
[ ] Improve performance
[ ] Style only
[ ] Dependency update
[ ] Documentation update
[ ] Release

@niloofar-deriv I have merged the base branch and resolved the conflicts, plus have made changes as you suggested. Please help to review. Thank you


returned non-zero exit status 1

D:\project\blutter>python -V
Python 3.11.4

D:\project\blutter>python scripts\init_env_win.py
Downloading ICU library from https://github.com/unicode-org/icu/releases/download/release-73-2/icu4c-73_2-Win64-MSVC2019.zip
Extracting ICU library
Downloading Capstone from https://github.com/capstone-engine/capstone/releases/download/4.0.2/capstone-4.0.2-win64.zip
Extracting Capstone library
Copying dlls to bin directory
Done

D:\project\blutter>python blutter.py
Dart version: 3.0.5, Snapshot: 90b56a561f70cd55e972cb49b79b3d8b, Target: android arm64
flags: product no-code_comments no-dwarf_stack_traces_mode no-lazy_dispatchers dedup_instructions no-asserts arm64 android compressed-pointers null-safety
CMake Error at C:/Program Files/CMake/share/cmake-3.29/Modules/FindPackageHandleStandardArgs.cmake:230 (message):
  Failed to find all ICU components (missing: ICU_INCLUDE_DIR ICU_LIBRARY
  _ICU_REQUIRED_LIBS_FOUND)
Call Stack (most recent call first):
  C:/Program Files/CMake/share/cmake-3.29/Modules/FindPackageHandleStandardArgs.cmake:600 (_FPHSA_FAILURE_MESSAGE)
  C:/Program Files/CMake/share/cmake-3.29/Modules/FindICU.cmake:334 (FIND_PACKAGE_HANDLE_STANDARD_ARGS)
  CMakeLists.txt:20 (find_package)

-- Configuring incomplete, errors occurred!
Traceback (most recent call last):
  File "D:\project\blutter\blutter.py", line 250, in <module>
    main(input, outdir, rebuild, vs_sln, no_analysis)
  File "D:\project\blutter\blutter.py", line 169, in main
    fetch_and_build(
  File "D:\project\blutter\dartvm_fetch_build.py", line 120, in fetch_and_build
    cmake_dart(ver, arch, os_name, has_compressed_ptrs, outdir)
  File "D:\project\blutter\dartvm_fetch_build.py", line 110, in cmake_dart
    subprocess.run([CMAKE_CMD, '-GNinja', '-B', builddir, f'-DTARGET_OS={os_name}', f'-DTARGET_ARCH={arch}',
    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "D:\develop\miniconda\Lib\subprocess.py", line 571, in run
    raise CalledProcessError(retcode, process.args,
subprocess.CalledProcessError: Command '['cmake', '-GNinja', '-B', 'D:\\project\\blutter\\build\\dartvm3.0.5_android_arm64', '-DTARGET_OS=android', '-DTARGET_ARCH=arm64', '-DCOMPRESSED_PTRS=1', '-DCMAKE_BUILD_TYPE=Release', '--log-level=NOTICE']' returned non-zero exit status 1.

Duplicate of #45

Duplicate of #45

All the replies in this issue(#45) cannot explain this error ,there are too many and messy replies, so I am creating a new issue


Remove duplicated image name in sample of deploying to container service using Azure Pipeline

Re-create of #112922

This issue was apparently fixed via another PR.


feat: configurable start timeout

Allows configuring the duration to wait for the "running" event from the host agent before timing out.
Closes #418

@jandubois jandubois dismissed their stale review 19 minutes ago

LGTY?


chore(typescript-skeletons): remove fetch typings

As of typescript 2.2 typing for fetch is included in typescript and whatwg-fetch is not needed

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Looks good, could you do the same for the other typescript skeletons? Thanks!

One more thing, you should also probably bump the TypeScript version to 2.2. Otherwise this is a bit contradictory.

Sure thing. Do you mean for the webpack experimental as well?

Thanks!


fix(core/select-item): check by undefined not by value

💡 What is the current behavior?

0 is currently not a valid value option for the ix-select-item.
GitHub Issue Number: xxx
🆕 What is the new behavior?

0 is now a valid value option for the ix-select-item.
🏁 Checklist
A pull request can only be merged if all of these conditions are met (where applicable):

[x] 🦮 Accessibility (a11y) features were implemented
[x] 🗺 Internationalization (i18n) - no hard coded strings
[x] 📲 Responsiveness - components handle viewport changes and content overflow gracefully
[x] 📄 Documentation was reviewed/updated (pnpm run docs)
[x] 🧪 Unit tests were added/updated and pass (pnpm test)
[x] 📸 Visual regression tests were added/updated and pass (Guide)
[x] 🧐 Static code analysis passes (pnpm lint)
[x] 🏗 Successful compilation (pnpm build, changes pushed)

👨💻 Help & support

The test is skipped, since html only uses string values, which the value prop also will use in 3.0.

@nuke-ellington - I haven’t set up a test because HTML exclusively uses string values for properties. We could however set up a test using React, but I was not sure if that’s needed, since our value property will take exclusively string in our next major release.


Special Mythos Events

Description of Problem or Question
I can't seem to figure out how to utilize special Mythos events, such as those that affect investigators in particular areas (in darkness, a hall, a kitchen, etc.).  I see that there are tons of different mythos events available, but they never seem to work.  Are they not utilized in Valkyrie, or do they take special methods to activate?
Valkyrie Version
2.4.09

The # variables are mostly to disable options.
So if you for example set the mythos to level Mayor but want to avoid anything happening in the Kitchen, you would have to set the related mythos variable to 0.


Has anyone converted this CF template to CDK yet by chance?

Planning on converting the fullstack and bookstore templates to CDK if anyone wants to help.  I'm planning on using the demo app in a Pluralsight Course I'm currently authoring for advanced CDK.  I love the demo apps!

I'm converting this myself now to CDK.  I'll pull request it once I'm done!

I'm curious how far you got- was it relatively straight forward?

Hey Kyle, I did complete the Goals app, but not the full bookstore app.  On the goals app (which is very similar, just a bit smaller) the AWS labs folks used a few techniques that I had to work around, like seeding codecommit using a Lambda from way off in an account I have no access to.  I changed the deployment source to S3 and worked around it.  Also, it was my first time using Cognito, so that took me a bit to get it all dialed in correctly.  All in all, I just about rewrote all the constructs from scratch.
I haven't decided on whether or not I'll rebuild the Bookstore app in CDK.  Perhaps I'll do that during the holidays if I get the time.
Hit me up any time.  Watch my Pluralsight course that comes out at the end of this month!
Scott


[SPARK-28542][DOCS][WebUI] Stages Tab

What changes were proposed in this pull request?
New documentation to explain in detail Web UI Stages page. New images are included to better explanation.

Does this PR introduce any user-facing change?
Only documentation
How was this patch tested?
I have generated it using "jekyll build" to ensure that it's ok

Thank you very much @srowen for all your comments. I have fixed all comments. I have tried to explain only not obvious things to keep the documentation as simple as possible.

Changed!!

Test build #4852 has started for PR 25598 at commit b084304.

Test build #4852 has finished for PR 25598 at commit b084304.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.


Using nord on Ubuntu Bash shell on Windows Subsystem for Linux

I meant the native Bash shell on Windows, called Bash on Ubuntu on Windows, which was released in 2016, under the Windows Subsystem for Linux. https://github.com/microsoft/WSL
I am not referring to the 2019 released Windows Terminal. Sorry if I wasn't clear earlier.
Please let me know if I can use the nord package in the native Bash shell on Ubuntu on Windows.
https://devblogs.microsoft.com/commandline/bash-on-ubuntu-on-windows-download-now-3/

This also depends on the actual terminal implementation. The colors are always provided by the terminal application while shells like Bash are not aware of the actual color codes at all. They just printing the ANSI escape codes and it's the job of the terminal application to apply and render the configured colors.
Since I'm not a Windows user I'm not up-to-date with most of these updates like this “Bash on Ubuntu on Windows“ and I'd need to set up a virtualized Windows 10 machine first in order to test this feature. I've quickly checked the links you provided and there's no information about the actual terminal implementation used to run Bash in the virtualized Ubuntu environment.
Anyway, the documentation in the microsoft/WSL repository contains the following:

Reporting issues in Windows Console or WSL text rendering/user experience
Note that WSL distro's launch in the Windows Console (unless you have taken steps to launch a 3rd party console/terminal). Therefore, please file UI/UX related issues in the Windows Console issue tracker.

Since this refers back to the new Windows Terminal project my guess is that this is also the terminal used to run “Bash on Ubuntu“. Before Windows Terminal was released it was called Windows Console, but it was replaced by the new implementation.
Anyway, I'll move this issue from this repository to the main Nord repository since it is not related to the GNOME Terminal in any way. I'd also suggest to test if one of the posted ports in arcticicestudio/nord#123 work for you, otherwise maybe ask for help in that issue since there are other Windows users.


Remove border from IFrameElement

Here's a PR to take care of Issue dint-dev#9

Thank you for the PR! 👍 The API of this package was changed significantly because of the web_view changes, so I close the PR.


[FEATURE] Disclaimer?

Is your feature request related to a problem? Please describe.
Should we have a disclaimer like W3C has?
here the content:
Important Disclaimer
W3C does not endorse specific vendor products. Inclusion of products in this list does not indicate endorsement by W3C. Products and search criteria are listed with no quality rating.
Tool descriptions, search criteria, and other information in this database is provided by tool developers, vendors, or others. W3C does not verify the accuracy of the information.
The list is not a review of evaluation tools, nor a complete or definitive list of all tools. The information can change at any time.
Describe the solution you'd like
No response
Describe alternatives you've considered
No response
Who shall do the work?

[X] I will do it, I want to contribute
[X] I am asking for someone else to please do the work

Timeline
No response
Additional context
No response

👍  but where to we put this disclaimer?

Maybe we can add it to a Contextual band and sub-footer band - Canada.ca section.
Maybe we can add a link to the page that lists all our pages in the footer too.

Related to: https://github.com/gc-da11yn/gc-da11yn.github.io/issues/328


The result is inconsistent with Java

public static void main(String[] args) {
    int i = 6.7 - 100 > 39.6 ? 5 == 5 ? 4 + 5 : 6 - 1 : !(100 % 3 - 39.0 < 27) ? 8 * 2 - 199 : 100 % 3;
    System.out.println(i);
    Object o = MVEL.eval("6.7 - 100 > 39.6 ? 5 == 5 ? 4 + 5 : 6 - 1 : !(100 % 3 - 39.0 < 27) ? 8 * 2 - 199 : 100 % 3");
    System.out.println(o);
}

java return 1;
mvel return 5;
why? a bug?

Hi @sunxiongwei, you make your example unnecessarily complicated, is this a puzzle of the day thing ? :)
Here is a pair of test cases that reveal that the operator priority between the ternary operator ( ?: ) and the equal comparison ( == ) differs between Java and mvel - the second test adds parenthesis to force mvel to use the same priority as Java so it succeeds:
	public void testTernaryOperatorPriorityFails () {
		int javaResult = false ? 5 == 5 ? 9 : 5 : 1;
		Integer mvelResult = MVEL.eval("false ? 5 == 5 ? 9 : 5 : 1", Integer.class);
	    Assert.assertEquals(javaResult, mvelResult.intValue());
	}

	public void testTernaryOperatorPriorityPasses () {
		int javaResult = false ? 5 == 5 ? 9 : 5 : 1;
		Integer mvelResult = MVEL.eval("false ? (5 == 5 ? 9 : 5) : 1", Integer.class);
	    Assert.assertEquals(javaResult, mvelResult.intValue());
	}

Hi @sunxiongwei, you make your example unnecessarily complicated, is this a puzzle of the day thing ? :) Here is a pair of test cases that reveal that the operator priority between the ternary operator ( ?: ) and the equal comparison ( == ) differs between Java and mvel - the second test adds parenthesis to force mvel to use the same priority as Java so it succeeds:
	public void testTernaryOperatorPriorityFails () {
		int javaResult = false ? 5 == 5 ? 9 : 5 : 1;
		Integer mvelResult = MVEL.eval("false ? 5 == 5 ? 9 : 5 : 1", Integer.class);
	    Assert.assertEquals(javaResult, mvelResult.intValue());
	}

	public void testTernaryOperatorPriorityPasses () {
		int javaResult = false ? 5 == 5 ? 9 : 5 : 1;
		Integer mvelResult = MVEL.eval("false ? (5 == 5 ? 9 : 5) : 1", Integer.class);
	    Assert.assertEquals(javaResult, mvelResult.intValue());
	}

Thank you. Got it！

Hi @sunxiongwei , I saw you closed this issue but an operator priority inversion is actually an issue.
Furthermore, I found that the issue is not between the ternary operator and the equal comparison but rather between ternary operators. it can be reproduced with the expression "false ? true ? 9 : 5 : 1" which doesn't have the comparison.
The cause of this issue is at the following lines: https://github.com/mvel/mvel/blob/a2f8d2e71b7a315de106c65f1ccc15d15853a1e1/src/main/java/org/mvel2/MVELRuntime.java#L103 and https://github.com/mvel/mvel/blob/a2f8d2e71b7a315de106c65f1ccc15d15853a1e1/src/main/java/org/mvel2/MVELInterpretedRuntime.java#L247
(The code is different depending on whether you call compileExpression+executeExpression or eval and the bug is present in both cases).
Adding parenthesis is a workaround.

I submitted https://github.com/mvel/mvel/pull/283 to fix this


[MINOR] Add PR description validation on documentation updates

Change Logs
As above, to make PR description validation strict.
No information in the "Documentation Update" section in the PR description will trigger PR validation failure:

Impact
As above.
Risk level
none
Documentation Update
none
Contributor's checklist

[ ] Read through contributor's guide
[ ] Change Logs and Impact were stated clearly
[ ] Adequate tests were added if applicable
[ ] CI passed

Hmm, most of the PRs does not need update for doc, is it reasonable to by default do all the validations? And the [MINOR] xxx style title seems been fixed to pass the validation right?

Hmm, most of the PRs does not need update for doc, is it reasonable to by default do all the validations? And the [MINOR] xxx style title seems been fixed to pass the validation right?

User needs to just add N/A to the "Documentation Update" section in the PR description.  This is a reminder for author to check if there is any documentation update needed, not necessary to do update if the code changes are not user-facing.

@danny0405 I updated the template to be more instructive so user knows to put "N/A" if no docs update is needed.

+1, but I still think it is too strict for force update for the doc part.

We can experiment with this.  This will be a good reminder for people to think about docs.  We still have features of which the docs is missing.

"Java CI / validate-source", "Update Pr Compliance / run-tests", and "validate pr / validate-pr" pass which are suffucient for the tooling changes.  There is no change to the production code.  Merging this now.


[BUG] running "flutter build windows" command

:information_source: Info

Version: 3.0.0-dev.3
:speech_balloon: Description
the installer runs flutter build windows then builds the msix file
i want to run the flutter pub run msix:create by it self since i include some dlls missing when building
my process
build windows
add dlls
create the msix

Hello
You can add them to the build folder, and then run flutter pub run msix:create,
those dll files will include in the msix installer

Or even better, use the formal method: [Adding assets and images(https://docs.flutter.dev/development/ui/assets-and-images)

the dll files are for a package so i cant include them like that sadly

Hello
You can add them to the build folder, and then run flutter pub run msix:create, those dll files will include in the msix installer

i did try that
but when build windows is called the dll gets overwritten

the build windows command overrides only the "data" folder and the .exe file,
its not deleting anything else

the build windows command overrides only the "data" folder and the .exe file, its not deleting anything else

the dll are for a package
so the package when the app builds again overwrites the dlls i put there (since i am just using a newer version of the package dlls)

the ones the package uses

the ones that i want to use (since there is a problem with  ssl certificate)

Hello @zezo357
I added in version 3.0.0-dev.4 the option build_windows : false so the command msix:create will not run the command flutter build windows internally.

thanks now with the flag the files are as excepted


Mypy annotation zerver.lib.event_queue and zerver.lib.queue

I ran into some problems with send_event taking either a list of ints or a list of dicts, so i figured i would change the caller's code.
Had problems with events either being a Dict with str keys and one caller who put an int key in there.
Additionally, needed to create some placeholder callbacks where mypy claimed it couldn't infer the type of lambdas.

Automated message from Dropbox CLA bot
@cpdean, it looks like you've already signed the Dropbox CLA. Thanks!

Cool, thanks for doing this @cpdean!  I merged versions of the first 3 commits (mostly just clarifying commit messages, plus a bit of cleanup to a27e50c70d5d6d675cdaafbd438cf69258ff211d to make it pass mypy checks and remove annotations not directly related to the change).
Can you rebase this branch to squash the fixes to bugs introduced in this branch into the original commit that introduced them?  Then it'll be a lot easier to incrementally merge the remaining pieces of this.
check out the Zulip coding style guidelines here for details on our commit style: https://zulip.readthedocs.org/en/latest/code-style.html#version-control
Also, I'm curious about the need for nop_callback -- is that working around a mypy bug?  It seems like mypy should be able to handle normal usage of lambda x: None, so it might make sense to report the bug to upstream mypy and get it fixed there...

@cpdean just wanted to check in on this.  If you're busy, it'd be valuable to at least have an answer to the nop_callback question...

woops, hey I'll dig into the lambda thing tonight.  making commits better
will take me a bit - my git powers are pretty much just limited to squashing
On Mon, Jun 13, 2016, 12:42 Tim Abbott<EMAIL_ADDRESS>wrote:

@cpdean https://github.com/cpdean just wanted to check in on this. If
you're busy, it'd be valuable to at least have an answer to the
nop_callback question...
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/zulip/zulip/pull/958#issuecomment-225638178, or mute
the thread
https://github.com/notifications/unsubscribe/AAJxYw62xU0gfdV94g58i7pN9vsVppiPks5qLYhngaJpZM4Iue-E
.

@timabbott okay, i've ripped out the nop_callback type things and I'm able to reproduce the error I saw earlier this month.
I boiled it down to a minimal example and reported the error here: https://github.com/python/mypy/issues/1710
Should we have the lambas in place and just add # type: ignore   # https://github.com/python/mypy/issues/1710 for now?

woops, my bad. made a duplicate of https://github.com/python/mypy/issues/1425

No worries!  The # type: ignore approach linked to python/mypy#1425 sounds good.

added the ignore notes on inline lambdas and cleaned out a third of the commits
it'll be a couple days before i can take another pass but let me know what I should focus on. thanks @timabbott !

found some more stuff to clean up and make more clear. ready for feedback, thanks again @timabbott !

@sharmaeklavya2 can you do a review pass on this?

@sharmaeklavya2 this is great thank you. admittedly I hadn't read the cheat sheet before starting this. I'll be able to clean this up this weekend.

Well I have suggested using Mapping or MutableMapping at some places, but there is a slight chance that might not work. For e.g., if an object has a property that is typed as a Dict, assigning a Mapping to it will fail. I have not checked your annotations very deeply so I might miss out on things like that.
After annotating all this code, you probably know it well enough that you can figure it out yourself what should be the correct type for a variable among Mapping, MutableMapping and Dict. But if you face any problems in doing so, just mention me and I'll be there to help.

@timabbott @cpdean I have reviewed this pull request.

@sharmaeklavya2 i had missed your comment about pika.BasicProperties earlier but have fixed it. Also I fixed the annotation on event_types to set it to List[str] since the other parts of Zulip seem to agree on that type.

Merged via #1171.  Thanks @cpdean for working on this!!


Tutorial updates

This PR is only a partial completion of #317, but I'm including the current bugfixes in the next minor release because there is no reason to wait on all the updates and these include some high-visibility/-utility updates.
Included in this PR are the following items from #317:

Experiment design construction tutorials (for using/explaining new germ, fiducial and FPR tools). Maybe a new tutorial on using the fisher information to evaluate experiment designs
Parity POVM example
Specifying reduced error generator models using new coefficient block interface
00-Protocols tutorial issues
01-Esssential-Objects tutorial issues
02-Using-Essential-Objects tutorial issues
CustomOperator tutorial issues

This PR also fixes the following related issues:

Fixing the ModelTesting-functions tutorial in #247
Warning JupyterLab incompatibility in #328

Woot I think this is our first PR that is pulling in code owners outside of the dev team, which means that @coreyostrove you are off the hook (unless you also wanted to look).
@kmrudin and @pcwysoc: I know this is probably new for you. I'm happy to hop on a Teams call to help with the process. But the TL;DR is:

Go over to the Files Changed tab.
Any file with a blue shield in the top left is one that you are a code owner for. Look over the changes. Red is a removed line, green is an added line. For a changed line, you'll see a red followed immediately by a green, with the thing that is changed being highlighted.
If you want to leave a comment, you can click on the line number and leave your comment.
When you are done with a file, you can click on the Viewed box in the top right and move to the next one.
When you have done all the files, click Review Changes in the top right above the files and either Approve if all looks good, Request changes if something looks bad, and Comment if you have questions but are not explicitly approving/rejecting.

If you come across a file that you are not a code owner for, feel free to skip it. If you come across a file that you ARE a code owner for and don't feel comfortable reviewing it, please comment that in the review - I can get someone else to review and then alter code owners appropriately.
@kmrudin Unfortunately, Jupyter notebooks are particularly annoying to review here. For the typo updates, this should be relatively OK, but for the ModelNoise.ipynb and CustomMeasurement.ipynb, you may find it helpful to look at the tutorial notebooks here. For ModelNoise, the "Reduced error models" section is new, and the entire notebook is new for CustomMeasurement.


Sidebar toggle does not restore width

VSCode Version: Code - Insiders 1.18.0-insider (8bc02c7443305a0db442c11b76e67d6f4929dc0e, 2017-10-26T05:11:40.525Z)
OS Version: Darwin x64 16.7.0

Only starts to happen this morning

Fixed, dup of https://github.com/Microsoft/vscode/issues/36963


Updated README to contain Publishables and more Widgets

Hey thanks! the Social Media Widget was just a test I dont plan to publish that yet it is incomplete


headless monte carlo for starting player advantage analysis

I have some abstract game I would like to analyse for starting player advantage and how likely it is to draw.
Is there some support for running a lot of full AI runs and see aggregate results?

This is something that I've always wanted to do, but it isn't really on the roadmap at the moment.
We could probably have something that can just take a Game object and do this sort of analysis on the commandline via a Node CLI program of some sort.

I'm playing around with things in this area. Since my PR (https://github.com/nicolodavis/boardgame.io/pull/493) was kindly accepted, the Simulate function is now exported, so it is easy to write code that uses the boardgame.io AI framework to run simulations.
At the most basic, you just need to configure a game object and then have a loop with a bot and a call to Simulate in it:
`for(let i=0; i<testCount; i++){
const randomBot = new RandomBot({
seed:i,
enumerate: enumerateMovesFunction
})
let { state: endState} = Simulate({
    game: game,
    bots: [randomBot, randomBot],
    state: {G,ctx},
})

//use results from this test run

}`
You just grab the winner details from the results and compile your statistics. I am also getting the game score from the final game state to produce some statistics on that.
One thing to note is that you need to generate the bot seed so that it is different for each iteration of the loop, otherwise the bots just behave the same way each time.
I'm currently doing this from my React interface for convenience of creating starting positions to test, so the boardgame.io Client provides the G and ctx objects. At some point I will want a commandline tool to test batches of starting positions – it looks like the exported InitializeGame function will enable that.

@danmkent Nice!  We should probably create a nicer public API rather than use the internal ones like InitializeGame (although that's fine in the meantime).
In the ideal world, you should be able to do:
import { Simulate } from 'boardgame.io/ai';

const statistics = Simulate(game);   // simulate with random bots
const statistics = Simulate(game, bots);   // also customize the bots
const statistics = Simulate(game, bots, initialState);  // also override the initial state to simulate from.

I'd be happy to contribute to this area. This is one of the main aspects of boardgame.io that I expect to make use of, so it would be great to firm up the API.
There are lots of stats that can be collected regardless of the details of the game being simulated, so it would definitely make sense to have Simulate return them.
I created a separate issue (https://github.com/nicolodavis/boardgame.io/issues/494) for the idea of providing hooks that code that uses Simulate could use to get more game-specific data from simulation runs. I would imagine these would be passed into Simulate in another parameter.

This is awesome, good work. I also would love to run some stats on some simple board games.


"Publish Now" button to observe workflow setting or not?

It's behavior question...
If the site have WorkFlow set for Approve Version, a user should not be able to click "Publish Now" button if that user doesn't have Workflow Approve/Deny permission.

Perhaps, if the user doesn't have Permission/Deny rights of workflow, we should disable Publish Now button?
We could keep it as it is... because workflow approver already approved it... so the editor could publish now....

I've confirmed that 8.5.2 fixed the issue.
Now the user which doesn't have approve permission of the page will have "Review" button instead.
Thanks!
I'm closing the issue as it was added


Settings.json search box fails to match lines starting with "//  - "

Version: 1.28.0-insider
OS: Linux Mint 19 (Cinnamon 3.8.8).
-Open the default settings editor UI.
-hit the "..." under the search box hit select "Open settings.json"
-search for a string in any line that begins with "//  - "
The search will fail to match.

@safield Search bar tries to match settings and matches comments only for default settings. To search in comments you can use normal editor find.

I might be confused, but I can not find a "normal editor find".
When I hit ctrl+F it just focuses the specialised settings search box. I am unable to open a normal editor find box.

In Settings Editor default Find command focuses to Search box. You can use Edit -> Find to open find box in the file. If you want that to be default behaviour you can update following in keybindings.json file
{
    "key": "cmd+f",
    "command": "-settings.action.search",
    "when": "inSettingsEditor"
},
{
    "key": "alt+cmd+f",
    "command": "settings.action.search",
    "when": "inSettingsEditor"
}

This is not a sufficient solution.
The normal editor find box will only open if I am focused in the user settings json editor. If I am focused in the default settings editor pane on the left, the find box will not open. The default settings is of course the much larger file, and the only one I am motivated to perform searches in.
In my opinion I think the settings editor interface could be rethought to be a much more reliable and consistent user experience based on simpler design.

@safield If you are on latest VS Code you should be seeing a new settings editor already


start key has timestamp of first value RTS-977

Riak TS uses the start key to hash to a vnode and does not take into account the start_inclusive filter.
SELECT * FROM table1 WHERE a = 1 AND b = 1 AND c > 1999 AND c <= 5000;

This query produces a first sub query with a key from 1999..3000, this hashes to the 1999 quantum which will not contain the results from 2000..3000. The result set will have missing objects.
This bug only manifests when using the > operator with a right hand value one less than the quanta boundary.
This change increments the start key by one and removing the {start_inclusive,false} filter when it exists to produce a start key of 2000..3000 in the first sub query, the start key hashes to the vnode where the data is actually stored. Fitler >= is not affected because the right hand value is

+1 daaffa5874
Posted two comments, but no change in code is expected.

@borshop merge


Fixed #25304 -- Allow management commands to check if database migrations are applied

adding required_migrations_checks to BaseCommand to support unapplied migrationgs on other managements command, runserver, createsuperuser and changepassword activate this check

Looks reasonable except tests aren't running and the new option should be documented in docs/howto/custom-management-commands.txt and the 1.10 release notes.

Tests fixed and docs updated.

Looking good. Some minor edits: http://dpaste.com/1PAKNJA
I think a simple test in tests/user_commands/tests.py would be useful. Maybe mocking the BaseCommand.check_migrations()and testing whether or not it's called based on the value ofrequires_migrations_checks` would be enough.

Hi, are you able to update this? We could offer it as "easy pickings" if not.

Hi Tim, you can check the update which include the test.

merged in 50931dfa5310d5ae1c6e2852d05bf1e86700827f, thanks!


TypeChain with Vyper

How would you get TypeChain to generate types for Vyper contracts. Solidity and Vyper generate the same abis in my understanding so I think it could work seamlessly. Thanks in advance.

There seems to be a bug in hardhat not generating types for vyper contracts. A temporary workaround can be found here.

fwiw: new version of the plugin was just released https://twitter.com/hardhathq/status/1484193829284728834?s=21


Manually adding Swimlane to an Angular project is not working

Hello Team,
I am trying to add swimlane to my Angular project manually but it is not working for me.
I am keep on getting the following error,
../node_modules/@swimlane/ngx-datatable/lib/directives/long-press.directive.d.ts:16:9 - error TS1086: An accessor cannot be declared in an ambient context.
16     get press(): boolean;
~~~~~
../node_modules/@swimlane/ngx-datatable/lib/directives/long-press.directive.d.ts:17:9 - error TS1086: An accessor cannot be declared in an ambient context.
17     get isLongPress(): boolean;
~~~~~~~~~~~
../node_modules/@swimlane/ngx-datatable/lib/services/column-changes.service.d.ts:8:9 - error TS1086: An accessor cannot be declared in an ambient context.
8     get columnInputChanges$(): Observable;
~~~~~~~~~~~~~~~~~~~
app/dashboard/dashboard-detail/dashboard-detail.component.ts:16:20 - error TS2307: Cannot find module 'ts-optchain'.
My Angular version is 8
Any help would be greatly appreciated. Thanks in advance

Please use the template when submitting an issue. Thanks.

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days.


Material SVGs render as dark grey squares

When downloading Material SVG icons from Google, they are rendered as dark grey squares. I've tried uploading/downloading them from other editors and the issue is not resolved. I've included the Google icon stylesheet, but that has not worked.

I've not seen the squares, but I have seem Google's Material icons fail to render at all. This seems to happen because those icons come with the height and width hardcoded to 24x24. Open the SVG with a text editor and remove the height/width. Change from this:
<svg xmlns="http://www.w3.org/2000/svg" height="24" viewBox="0 -960 960 960" width="24">

to this:
<svg xmlns="http://www.w3.org/2000/svg" viewBox="0 -960 960 960">


changed the footer icon to filled

Fixes

Fixes #484  by  @zackkrida
Description
The icon in the footer donate button has been updated to use the cc-letterheart-filled icon
Screenshots

Checklist

[x] My pull request has a descriptive title (not a vague title like Update index.md).
[x] My pull request targets the default branch of the repository (main or master).
[x] My commit messages follow best practices.
[x] My code follows the established code style of the repository.
[ ] I added tests for the changes I made (if applicable).
[ ] I added or updated documentation (if applicable).
[x] I tried running the project locally and verified that there are no
visible errors.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.

Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@abhinav72610 please provide a screenshot of what the site looks like locally and fill out the checklist in the PR. Thanks!

Looks good!

Thanks


how to import pre-Preston downloads

usecase: @mjcollin kept copies of BHL data.zip around, and would now like to add the versions to some preston archive somehow.

You can add individual files to preston by:
preston track file:///home/user/archive.zip
or with a single urls:
preston track https://example.org/archive.zip


refactor how inbound and outbound VirtualHosts are programmed on Envoy proxies

The way we currently couple SMI Traffic Split and SMI Traffic Target policies has proven difficult when trying to program the correct Envoy RouteConfiguration for inbound and outbound VirtualHosts to implement SMI Traffic Split v1alpha3. Until now, this was not an issue because HTTP route matching rules were only associated with Traffic Target resources. However, there are now a series of issues related to programming Virtual Hosts correctly on proxies since SMI Traffic Splits (as of v1alpha3) also have associated HTTP route matching rules.
In order to better predict behavior and also comply with the latest SMI Traffic Target and SMI Traffic Split APIs, we'll need to update the way we program inbound and outbound RouteConfiguration with regard to Traffic Targets and Traffic Splits.
When an SMI Traffic Target is applied, the proxies associated with the destination should be programmed with inbound VirtualHost with route matches corresponding to the route matches in the SMI Traffic Target resource. The proxies associated with any of the sources in the same SMI Traffic Target should be programmed with an outbound VirtualHost with an allow all route match (allow all paths/PathRegex and allow all Methods). What this means to the user is that when a Traffic Target is applied, the relevant clients (sources) will be able to discover and make requests to the destination and the server (destination) will be able to accept requests on the route matches associated with the Traffic Target for all hostnames associated with the Kubernetes Services related to the destination Service Account. (Note: RBAC for inbound connections still needs to be implemented - being tracked here)
When an SMI TrafficSplit is applied, all clients will be programmed a Virtual Host corresponding to the route matching rules and weighted cluster split described in the TrafficSplit resource. If there is a RouteConfiguration that already exists for the apex service described in the Traffic Split, the routing rules and weighted cluster configuration will be merged in the routes list of the existing Virtual Host. For the user what this means is that any time a Traffic Split is applied, all services will be able to discover and make requests to the apex service. If the request matches the route matching rules described in the TrafficSplit resource, the requests will be load balanced according to the weighted clusters configuration. Access will be denied on the server side if there is no inbound VirtualHost programmed (because a valid TrafficTarget policy does not exist) and more granularly once RBAC is implemented(#1964).
See some more details here.
These changes will allow us to implement TrafficSplit v1alpha3 (#705) and with the RBAC implementation (#1964), we'll be able to satisfy all the requirements stated in SMI traffic split and traffic access specification.

#2342 marks the end of building the framework for this feature. The team has vetted the rationale, design and implementation of this feature. All remaining tasks to complete this feature (called "routes v2") are labeled in the issue queue as "routes v2"

#2342 marks the end of building the framework for this feature. The team has vetted the rationale, design and implementation of this feature. All remaining tasks to complete this feature (called "routes v2") are labeled in the issue queue as "routes v2"


Update jest and adjust tests to handle latest JSDOM

Changes

Update jest to 26.0.1 from 24.9.0.
Update jest-cli to 26.0.1 from 24.9.0.
Update babel-jest to 26.0.1 from 24.9.0.
Prefixes window on references to global location references.
Changes how window.location.assign is mocked in tests to handle changes in JSDOM.
Changes how body font-size is set in tests to handle changes in JSDOM getComputedStyle method.
Refactor recent-notices-spec to utilize simulate event utility, re-require the tested script before each test, and reset the xhr after each test.

Testing

Pull branch and run gulp test:unit. It should pass.

Coverage failure is because I edited repay.js, but there is currently NO coverage for it. Not planning to add a test for it in the scope of this PR.


Missing intellisense for variants

Hey,
I tried following your guides to set up variants for my Text component, but it TypeScript refuses to acknowledge the keys under text in MyTheme.
I noticed that Text gets the prop type StyledProps<'text', never> & TextProps
Manually updating never to DripsyVariant<'text'> solves the issue, and gives me correct suggestions.
When looking at the source for createThemeComponent, then it seems like that is also the intention:
https://github.com/nandorojo/dripsy/blob/798c6819c01ce4203e585739235b37b7f5b7efe9/packages/core/src/css/create-themed-component.tsx#L20
https://github.com/nandorojo/dripsy/blob/798c6819c01ce4203e585739235b37b7f5b7efe9/packages/core/src/css/types.ts#L287-L290
Has it been built wrong?
I have dumped my files for a repro into a gist: https://gist.github.com/Jomik/faa0f1ca6c7f46ba179c3bdfb60b1d0c
Versions:
{
    "dripsy": "^3.2.1",
    "typescript": "~4.4.4"
}

Yeah I think there’s an issue with intellisense for variants. That’s what you mean right?

It simply seems like the Text component has the wrong type. The second Generic is StyledProps is never which results in it accepting no values for the variant prop.
The type of the prop becomes undefined.
So it results in a type error, not simply lack of type narrowing.

Yeah but can you confirm that what I said is the issue you’re dealing with? Like you’re trying to use the variant prop but not getting intellisense, right?

The primary issue is that I am getting a type error because the type is not even string, it is undefined. As a result, I am obviously not getting intellisense either 😊
If I the variantFallbackType then the type becomes string.
I updated the link for the gist, it was invalid for some reason.
https://gist.github.com/Jomik/faa0f1ca6c7f46ba179c3bdfb60b1d0c#file-theme-ts-L18

What type error? Can you include all relevant info like that in this issue?

Why did you set variantFallbackType: undefined

I think that would cause this type error, you should leave that to string & {} (the default)
I’ll look into the intellisense separately

I set it to undefined, to follow https://github.com/nandorojo/dripsy/blob/798c6819c01ce4203e585739235b37b7f5b7efe9/packages/core/src/declarations.ts#L203-L205
If that is unsupported, then I will just set it as you say 😊

Ah got it, I left this undocumented I think

I think I found the issue

@jomik can you try upgrading to canary and lmk if that solves it?
yarn add dripsy@canary

Works for me:

PR at #148

PS if you're using gradient too, upgrade that as well
yarn add dripsy@canary @dripsy/gradient@canary

Trying to get this canary installed. It installs a '3.4.1-alpha.0' , but I see there is also a '3.5.1-alpha.0'.
Both still give me the issue.
I currently have
  types: {
    reactNativeTypesOnly: true,
    onlyAllowThemeValues: 'always',
    strictVariants: true,
  },

The expected type of variant is undefined.

Can I see your theme file

Can I see your theme file

Yes! I have updated the gist: https://gist.github.com/Jomik/faa0f1ca6c7f46ba179c3bdfb60b1d0c#file-theme-ts

I’ll look when I’m at my computer at this thanks

Weird. works in the example app locally but not in my app either. will need to see why

What happens locally if you explicitly set never as the second generic for StyledProps locally?

yeah, that just indicates that it isn't properly reading in the theme

Oh yeah I see what you mean...wtf. Okay so it's a build issue. I'm thinking because it's importing from ..?
This would explain why it works for me locally

I think I'm finding where this is facing issues.

Before:
export type StyledProps<ThemeKey extends keyof DripsyFinalTheme, Variant = DripsyVariant<ThemeKey>> = {
  as?: ComponentType<any>
  variant?: Variant
  themeKey?: ThemeKey
  sx?: SxProp
  variants?: Variant[]
}

After:
export type StyledProps<ThemeKey extends keyof DripsyFinalTheme> = {
  as?: ComponentType<any>
  variant?: DripsyVariant<ThemeKey>
  themeKey?: ThemeKey
  sx?: SxProp
  variants?: DripsyVariant<ThemeKey>[]
}

I think putting a value that gets generated later (DripsyVariant<ThemeKey>) as a generic makes it get evaluated upfront, thus resolving in never? 🧐
There's a lesson to not try to "memoize" TS generics, and instead compute them inline.

yeah that fixes it for me. fixed in 3.5.2. thanks for peaking in the built version.

3.5.3 should also fix this prop for components without a themeKey, such as View. Man, this was a tough one. all done though 🥳

From my app (not the example app):
<img width="767" alt="Screen Shot 2021-11-12 at 7 05 06 PM" src="https://user-images.githubusercontent.com/13172299/141597125-46ed99f5-e2f8-4f40-afe6-72f515f53971.png"

That's amazing! 💪 Yeah. I'm guessing they try to resolve as much as possible to avoid having the cost for consumers, which sucks when you plan on having your users extend on a type. 😅

Yeah, definitely a unique use case. There isn't much content out there for this kind of thing haha. But I know for next time.

I still see variant issue on Text Component from dripsy. using 3.5.3

Hm weird, it’s working for me. Could you try reproducing on CodeSandbox maybe?
Do you also have @dripsy/gradient installed? If so, make sure to update that too.


Unable to write program user data

Trying to install VS Code on my mac and get this error:
Unable to write program user data. A system error occurred (EACCES: permission denied, mkdir '/Users/name/Library/Application Support/Code/CachedData/6261075646f055b99068d3688932416f2346dd3b')
Please make sure the following directories are writeable:
-/Library/Application Support/Code-/.vscode/extensions

@cmarguerite You seem to have issues with your user home directory permissions. What does this return?
ls -la "~/Library/Application Support/Code"
ls -la "~/.vscode"

This issue has been closed automatically because it needs more information and has not had recent activity. See also our issue reporting guidelines.
Happy Coding!


Feature/alias

Reopened from https://github.com/fishtown-analytics/dbt/pull/651, https://github.com/fishtown-analytics/dbt/pull/771
Description (and original code courtesy of @abelsonlive). Thanks also to @jon-rtr for helping bring this branch up-to-date with development.

WHAT
This P.R. implements model aliasing RE: https://github.com/fishtown-analytics/dbt/issues/637.
WHY
To enable more control over how dbt materializes tables.
HOW
This P.R. adds an alias parameter to the model config. If not present, this parameter will default to the name of the model (AKA the parsed file path of the model). This implementation is preferable because it maintains the use of the filename in ref calls, thereby enabling dbt users to have distinct model names, but non-distinct table names.
...
Model aliasing is implemented for seed and model resources. An alias can be specified in dbt_project.yml or in a {{ config(alias=...) }} block. The name attribute of a Relation object will reflect the alias, so {{ this.name }} will return a model alias if one is present.
In keeping with the custom schema workflow, a macro was created which handles custom alias generation. The default implementation uses the alias config if one is present, otherwise, it uses the model name as a default:
{% macro generate_model_alias(node) -%}
    {% set default_alias = node['name'] %}
    {% set config = node.get('config', {}) %}
    {% set alias = config.get('alias', default_alias) %}
    {{ return(alias) }}
{%- endmacro %}

This macro can be overriden in project-space, so aliases can be generated from eg. target or node configs if necessary.

Wooooot!

long-run we should replace node['alias'] with model.alias but whatever.
unrelated: your build is failing.

@cmcarthur ok, I ripped out get_custom_alias. I think the better approach is to jinja-compile the alias field, but we should likely do that for many dbt fields, so I think we can handle that in a different PR. I was trying to achieve a way to dynamically change the name of the resulting table for eg. date partitioning on BQ. I definitely agree that it was not the right approach here

these tests are failing with a very upsetting:
On expect_value_foo_alias_tablename__foo:

select count(*)
from "test1530625544_aliases_026"."foo"
where tablename != 'foo'

dbt: DEBUG: Postgres error: failed to find conversion function from unknown to text

This works locally for me, so I think it must be a postgres version thing. Just going to keep adding typecasts until it works /shrug

@drewbanin this looks great. i left a couple random thoughts here but you can ship this.


Fix the visibility of the 'Add' button when the content is scrolled

This pull request fixes issue #889
This PR is part of GTC open source initiative

Hi,
Thanks for your contribution, however Sunflower is going to be archived in favour of maintaining a smaller set of up-to-date set of compose-samples, that can be found here: https://github.com/android/compose-samples, as well as snippets that can be found here: https://github.com/android/snippets.
Please feel free to keep your fork up-to-date for your learning, but this repository will be archived shortly.


Fix function comments based on best practices from Effective Go

A short explanation of the proposed change:

Every exported function in a program should have a doc comment. The first sentence should be a summary that starts with the name being declared.
From effective go.
I generated this with CodeLingo and I'm keen to get some feedback, but this is automated so feel free to close it and just say opt out to opt out of future CodeLingo outreach PRs.

An explanation of the use cases your change solves

Instructions to functionally test the behavior change using operator interfaces (BOSH manifest, logs, curl, and metrics)

Expected result after the change

Current result before the change

Links to any other associated PRs

[n] I have viewed signed and have submitted the Contributor License Agreement

Will do it shortly :smile:

[y] I have made this pull request to the master branch

[n] I have run all the unit tests using bin/test

[n] I have run CF Acceptance Tests on bosh lite

I mean, how could this break that? Also, why take my word for it? Surely you want to verify with CI. Or is it a matter of not letting people spam your build server?

It looks like all the fix ups that update the tense and read well except this which I've noted and will make a fix for!
I'll sign the CLA shortly.
Let me know what you think :smile:


Filter reactions by specific substrate or product

Enable filtering reaction list by substrate or product (or both)

added feature in latest release!


Add multiple results view into the SQL Lab.

Is your feature request related to a problem? Please describe.
In the SQL Lab (in the Superset 1.0.1), we have the ability to see the results of only the last statement that produces result.
Describe the solution you'd like
Maybe there should be multiple results views when users decide to fetch data from DB with different SELECT statements?
Additional context

what about large result tables that barely fit in the view?

@junlincc Of course, there is some problem with rendering a large dataset that the user has to manipulate: if the user really needs a large dataset to view, then there is already a virtualized view there, but to be able to render even more data (actually an unlimited number of rows) in the table (more than ~ 5MB of data) we need to dig deeper into virtualization (one of the good examples of how this can be done is here https://www.ag-grid.com/javascript-grid/server-side-model/ ).
And my guess is that in this particular case (large tables of results) a scrollbar (the one that already used in table previews) can be used. Even more scrollbars can be used: one for the results view, limiting the rows in one result view, and one for all result views (for example, like in table previews, see image below).

I will add UI diagrams to clarify the idea this weekend

Sorry this is what I meant, hope this helps.

ah! thanks for mocking the idea. How many tables do you think we should support viewing side by side? i wouldn't recommend more than 2. tbh.
bringing @steejay to the conversation

How about showing the multiple results tables in tabs, allowing to group them side by side by dragging the tabs?
The tables should be labeled on their tabs, e.g. by using the first N characters of their queries.
So if the user puts a comment in front of a single statement, we would display the beginning of this comment, stripping the comment chars (--), or so.

When talking about having multiple statements in a single script, I think we should also consider having distinct keyboard shortcuts for running all statements at once, or running solely the one where the cursor currently is positioned, starting from the previous and spanning to the following semicolon.
I'd opt for Ctrl+Shift+Enter and Ctrl+Enter, respectively.

@clear-m thanks for the suggestion and the mock up your created. I'd love to learn more about this idea! Can you tell me more the last time you wanted to see multiple results views in the same context? What tasks were you trying to accomplish? How would seeing multiple views assuage some of the challenges you were experiencing at this time? How are you currently solving this problem without having multiple views?

This seems to have gone stale, and we've since moved feature requests over to Github's Discussions tab in the Ideas section. I'll close this since it's not a bug, but I encourage you to start a discussion there if you want to continue to pursue this.


As a sysadmin, I want all of my existing Household__c data natively ported to the new Household Account model, including custom fields, so that my transition to the new model is as smooth as possible for my users.

This is a large story and will need to be broken down into smaller stories
Existing Household__c data including custom fields, should be transferred to mapped custom fields on the Account
Naming exclusions on the Contact level (npo02_SYSTEM_Naming_Exclusions__c) should be transferred

** lurch: add

It looks like a work item did not get created for this? I'm wondering if we should close as we will likely not invest time in this due to the amount of effort to check/create new fields to correspond to the old HH object, then re-map to the new or existing custom fields (and how could we be 100% sure unless we build an interface for people to map?). The amount of effort required to complete this feature and the number/percentage of customers it would impact is not large.

I think we could potentially copy all fields to the new account if the same developer name existed.  still would require the user to create these custom fields.  but I agree it is lower priority and likely not to get attention anytime soon.


Does not work with ActionController::API

We are creating an API-Centric Web Application and we have ApiController in it, which is nested from ActionController::API. After adding stripe-rails, application began crashing on startup with error:
Uncaught exception: undefined method `helper' for ActionController::API:Class
Exiting
/Users/user/.rvm/gems/ruby-2.2.3@peakhero/gems/stripe-rails-0.3.1/lib/stripe/engine.rb:58:in `block (2 levels) in <class:Engine>'
/Users/user/.rvm/gems/ruby-2.2.3@peakhero/gems/activesupport-5.0.0.beta4/lib/active_support/lazy_load_hooks.rb:38:in `instance_eval'

I've found that initializer 'stripe.javascript_helper' in engine.rb tries to add Stripe::JavascriptHelper after ActiveSupport is loaded, but there is no helpers in API version.
You may need to add ability to skip adding of javascript helpers, which will solve the issue.

As a temporary hacky workaround, I've added such code to my initializers/stripe.rb
ActionController::API.class_eval do |s|
  def self.helper(*args) end
end

👍  to this, ran in to it today. @shabliyartem 's workaround works well, but it feels hacky :)

Yeah, we need to fix this. We're actively looking for new maintainers, but seems like there are only two things to do

put a conditional around it:

    initializer 'stripe.javascript_helper' do
      ActiveSupport.on_load :action_controller do
        if respond_to? :helper
          helper Stripe::JavascriptHelper
        end
      end
    end

figure out how to test it against a Rails API instance on CI

I think the second task will be the harder.


Structured Data Package with SQL Result Materialization

Creates a structured data package sdata with a TupleWriter interface and writers for JSON and CSV formats.  Adds a matrix test to check that we can successfully materialize data from all combinations of database and materialization format.

sdata MaterializeSQL can be used to copy rows from a sql.Rows to a TupleWriter.
dockertestenv: Adds NewMySQL for creating a fresh MySQL database suitable for tests.

Needs #7032 #7084

The failing tests are from sql.NullInt16 missing in go versions <1.17.  I have another PR up to bump the go version.