layoutCfg object behaves differently than layoutCfg string on initial load

Describe the bug
When initializing a graph where the x, y coords of the graph items are known and the layout is set to layout: "gForce" the graph correctly puts the items in their preset x, y coords. If layout cfg is set to layout: { type: 'gForce' } the graph will initialize the nodes at the correct spot but the next tick it will reposition them into a computed layout.
Your Example Website or App
https://codesandbox.io/s/save-node-positions-forked-6b9nzi?file=/src/App.vue
Steps to Reproduce the Bug or Issue

Go to https://codesandbox.io/s/save-node-positions-forked-6b9nzi?file=/src/App.vue
Notice the nodes have been put in a preset positions to look like a box (see screenshot)

Go to the code editor and comment out layout: "gForce" and uncomment layout: { type: 'gForce' }
Notice that the graph will initially set the nodes in the same preset positions, but on the next tick it will reposition them into a computed layout

Expected behavior
I expect that layout: "gForce" and layout: { type: 'gForce' } would behave the same
Screenshots or Videos
Screencast from 03-08-2023 02:13:50 PM.webm
Platform

OS: Ubuntu 22.04.2 LTS x86_64
Browser: Chrome 110.0.5481.177 (Official Build) (64-bit)
Version: @antv/g6 4.8.7

Additional context
No response

My fault, this is correct behavior. layoutCfg should be an object, when its a string its being treated as not assigned, and x, y coords are used when no layout is assigned.


Markdown table fixes

Contains the following fixes:

do not add new lines in markdown cells
markdown tables can only have one header
add a space after text before a paragraph in a cell
match maximum cell count on each row
cells always need to append vertical bars

Partly fixes https://github.com/adbar/trafilatura/issues/599.

@naktinis Thanks for the PR, the code looks good but tests fails in test_table_processing() (part of unit_tests.py).
Could you please have a look, change the code (or the test if it doesn't work as intended), and add tests there for your PR if necessary?

@adbar I believe I have now fixed the tests and added three more relating to these changes.

@naktinis Thanks, it's much better now!
I have a few questions:

You're introducing a span attribute because otherwise it would be difficult to keep track of the total number of columns, right?
Why does it yield <rowspan="2"> (without space) and <row span="7"> in the tests? I would suggest to remove the attribute from the output once it has been used.

@adbar

You're introducing a span attribute because otherwise it would be difficult to keep track of the total number of columns, right?

Yes, so that each row is aware of any other rows having more columns than it does itself.

Why does it yield <rowspan="2"> (without space) and  in the tests? I would suggest to remove the attribute from the output once it has been used.

Because the previous line (that was already there before my changes) removes spaces:
result = processed.replace('\n', '').replace(' ', '')

Then I'd be in favor of removing the attribute from the output:

somewhere after for subelement in table_elem.iterdescendants():
del newrow.attrib["span"] (if it's present)

Could you please implement the change (or a similar one) and update the tests?

@adbar row attribute cleanup should now be done (also updated the tests).

Thanks!


[resolves #622] Enable path to exported-paths.txt to be configurable

Refer to this link for build results (access rights to CI server needed):
https://fabric8-ci.fusesource.com/job/wildfly-camel-pullreq/445/
Test PASSed.


Is there any chance of having a Gguf 'CogVideoX-Interpolation -model'?

Please, please, please
Many thanks for your amazing work.

This is done.

Many thanks!!!
https://github.com/user-attachments/assets/30ad9351-2012-498e-adab-56a71008f545
For my first test, I tried something a bit extreme, didn't obtain what I was expecting but I found very interesting the transition.
Thanks again.


Class.all gives "NoMethodError: undefined method `to_sym' for nil:NilClass" (Probably data entry error)

Apologies for the poor quality of this issue submission: This came up on a dev branch with a bunch of changes. If this gives you any pointers for info that I can submit to help debug, let me know.
Command that causes the error
Class.all
Expected result
An array containing all nodes from that class
Actual result
NoMethodError: undefined method `to_sym' for nil:NilClass
Did you mean?  to_s
	from /usr/local/bundle/gems/neo4j-8.0.6/lib/neo4j/active_node/property.rb:22:in `association_key?'
	from /usr/local/bundle/gems/neo4j-8.0.6/lib/neo4j/active_node/property.rb:29:in `block in contains_association?'
	from /usr/local/bundle/gems/neo4j-8.0.6/lib/neo4j/active_node/property.rb:29:in `each_key'
	from /usr/local/bundle/gems/neo4j-8.0.6/lib/neo4j/active_node/property.rb:29:in `contains_association?'
	from /usr/local/bundle/gems/neo4j-8.0.6/lib/neo4j/active_node/property.rb:15:in `extract_association_attributes!'
	from /usr/local/bundle/gems/neo4j-8.0.6/lib/neo4j/active_node/initialize.rb:11:in `init_on_load'
	from /usr/local/bundle/gems/neo4j-8.0.6/lib/neo4j/active_node/node_wrapper.rb:9:in `block (2 levels) in <top (required)>'
	from /usr/local/bundle/gems/neo4j-8.0.6/lib/neo4j/active_node/node_wrapper.rb:8:in `tap'
	from /usr/local/bundle/gems/neo4j-8.0.6/lib/neo4j/active_node/node_wrapper.rb:8:in `block in <top (required)>'
	from /usr/local/bundle/gems/neo4j-core-7.0.3/lib/neo4j/core/wrappable.rb:27:in `wrap'
	from /usr/local/bundle/gems/neo4j-core-7.0.3/lib/neo4j/core/wrappable.rb:11:in `wrap'
	from /usr/local/bundle/gems/neo4j-core-7.0.3/lib/neo4j/core/cypher_session/responses/bolt.rb:95:in `wrap_by_level'
	from /usr/local/bundle/gems/neo4j-core-7.0.3/lib/neo4j/core/cypher_session/responses/bolt.rb:102:in `wrap_node'
	from /usr/local/bundle/gems/neo4j-core-7.0.3/lib/neo4j/core/cypher_session/responses/bolt.rb:75:in `wrap_structure'
	from /usr/local/bundle/gems/neo4j-core-7.0.3/lib/neo4j/core/cypher_session/responses/bolt.rb:41:in `wrap_entity'
	from /usr/local/bundle/gems/neo4j-core-7.0.3/lib/neo4j/core/cypher_session/responses/bolt.rb:39:in `map'
... 12 levels...
	from /usr/local/bundle/gems/neo4j-core-7.0.3/lib/neo4j/core/cypher_session/adaptors.rb:117:in `block in queries'
	from /usr/local/bundle/gems/neo4j-core-7.0.3/lib/neo4j/core/cypher_session/adaptors.rb:142:in `transaction'
	from /usr/local/bundle/gems/neo4j-core-7.0.3/lib/neo4j/core/cypher_session/adaptors.rb:201:in `new_or_current_transaction'
	from /usr/local/bundle/gems/neo4j-core-7.0.3/lib/neo4j/core/cypher_session/adaptors.rb:116:in `queries'
	from /usr/local/bundle/gems/neo4j-core-7.0.3/lib/neo4j/core/cypher_session/adaptors.rb:108:in `query'
	from /usr/local/bundle/gems/neo4j-core-7.0.3/lib/neo4j/core/cypher_session.rb:36:in `block (2 levels) in <class:CypherSession>'
	from /usr/local/bundle/gems/neo4j-core-7.0.3/lib/neo4j-core/query.rb:240:in `response'
	from /usr/local/bundle/gems/neo4j-core-7.0.3/lib/neo4j-core/query.rb:311:in `pluck'
	from /usr/local/bundle/gems/neo4j-8.0.6/lib/neo4j/active_node/query/query_proxy_enumerable.rb:88:in `pluck'
	from /usr/local/bundle/gems/neo4j-8.0.6/lib/neo4j/active_node/query/query_proxy_enumerable.rb:26:in `result'
	from /usr/local/bundle/gems/neo4j-8.0.6/lib/neo4j/active_node/query/query_proxy_enumerable.rb:13:in `each'
	from /usr/local/bundle/gems/neo4j-8.0.6/lib/neo4j/active_node/query/query_proxy_eager_loading.rb:6:in `each'
	from /usr/local/bundle/gems/neo4j-8.0.6/lib/neo4j/active_node/query/query_proxy.rb:193:in `to_a'
	from /usr/local/bundle/gems/neo4j-8.0.6/lib/neo4j/active_node/query/query_proxy.rb:193:in `[]'
	from (irb):1
	from /usr/local/bin/irb:11:in `<main>'

Note
Other classes are perfectly fine, as are other docker containers with the same app and different data.
Steps that I believe caused this error

Created a small JSON endpoint to work with creating nodes (get posted data, save node)
Iteratively modified both the endpoint and the request to do proactive bug testing, changing headers, post data, and post data structure.
Started saving the request headers to the nodes

I was only watching the return values for a while, and when I went back to list all the nodes, this error came up.
Seems like I was able to submit data in to Neo4j that could not be read again.
Runtime information:
Neo4j database version:
neo4j gem version: 8.0.6
neo4j-core gem version: 7.0.3

Here's some info that may uncover the error as well:
I went through each node individually by UUID, and all were able to be called, but some came back with truncated properties.
From Neo4j:
name<EMAIL_ADDRESS>normalized_name<EMAIL_ADDRESS>raw_input	{:body=>{"value"=>"Datapoint value 4 (Cleaned)"}, :header=>{"CONTENT_LENGTH"=>"42", "CONTENT_TYPE"=>"application/json", "GATEWAY_INTERFACE"=>"CGI/1.1", "PATH_INFO"=>"redacted", "QUERY_STRING"=>"", "REMOTE_ADDR"=>"<IP_ADDRESS>", "REMOTE_HOST"=>"<IP_ADDRESS>", "REQUEST_METHOD"=>"POST", "REQUEST_URI"=>"redacted", "SCRIPT_NAME"=>"", "SERVER_NAME"=>"<IP_ADDRESS>", "SERVER_PORT"=>"4455", "SERVER_PROTOCOL"=>"HTTP/1.1", "SERVER_SOFTWARE"=>"WEBrick/1.3.1 (Ruby/2.3.3/2016-11-21)", "HTTP_CACHE_CONTROL"=>"no-cache", "HTTP_POSTMAN_TOKEN"=>"redacted", "HTTP_AUTHORIZATION"=>"Token token=redacted", "HTTP_USER_AGENT"=>"PostmanRuntime/3.0.5", "HTTP_ACCEPT"=>"*/*", "HTTP_HOST"=>"<IP_ADDRESS>:4455", "HTTP_ACCEPT_ENCODING"=>"gzip, deflate", "HTTP_CONNECTION"=>"keep-alive", "rack.url_scheme"=>"http", "HTTP_VERSION"=>"HTTP/1.1", "REQUEST_PATH"=>"redacted", "rack.request.query_string"=>"", "sinatra.route"=>"POST redacted"}}
value	Datapoint value 4 (Cleaned)
uuid	8e19341e-bfa8-4bc5-b827-bc169847e219

The result of Datapoint.find("8e19341e-bfa8-4bc5-b827-bc169847e219")
Datapoint
 MATCH (n:`Datapoint`)
 WHERE (n.uuid = {n_uuid})
 RETURN n
 ORDER BY n.uuid
 LIMIT {limit_1} | {:n_uuid=>"8e19341e-bfa8-4bc5-b827-bc169847e219", :limit_1=>1}
=> #<Datapoint uuid: "8e19341e-bfa8-4bc5-b827-bc169847e219", name<EMAIL_ADDRESS>normalized_name<EMAIL_ADDRESS>raw_input: "{:body=>{\"value\"=>\"Datapoint value 4 (Cleaned)\"}, :header=>{\"CONTENT_LENGTH\"=>\"42\", \"CONTENT_TYPE\"=>\"", value: "Datapoint value 4 (Cleaned)">

Destroyed the nodes starting with the newest and working back until Datapoint.all worked.
It did not work until the following node was destroyed
name<EMAIL_ADDRESS>normalized_name<EMAIL_ADDRESS>raw_input	{:body=>{"value"=>"Datapoint value (Cleaned)"}, :header=>{"CONTENT_LENGTH"=>"40", "CONTENT_TYPE"=>"application/json", "GATEWAY_INTERFACE"=>"CGI/1.1", "PATH_INFO"=>"/redacted", "QUERY_STRING"=>"", "REMOTE_ADDR"=>"<IP_ADDRESS>", "REMOTE_HOST"=>"<IP_ADDRESS>", "REQUEST_METHOD"=>"POST", "REQUEST_URI"=>"redacted", "SCRIPT_NAME"=>"", "SERVER_NAME"=>"<IP_ADDRESS>", "SERVER_PORT"=>"redacted", "SERVER_PROTOCOL"=>"HTTP/1.1", "SERVER_SOFTWARE"=>"WEBrick/1.3.1 (Ruby/2.3.3/2016-11-21)", "HTTP_CACHE_CONTROL"=>"no-cache", "HTTP_POSTMAN_TOKEN"=>"redacted", "HTTP_AUTHORIZATION"=>"Token token=redacted", "HTTP_USER_AGENT"=>"PostmanRuntime/3.0.5", "HTTP_ACCEPT"=>"*/*", "HTTP_HOST"=>"redacted", "HTTP_ACCEPT_ENCODING"=>"gzip, deflate", "HTTP_CONNECTION"=>"keep-alive", "rack.url_scheme"=>"http", "HTTP_VERSION"=>"HTTP/1.1", "REQUEST_PATH"=>"/redacted", "rack.request.query_string"=>"", "sinatra.route"=>"POST /redacted"}}
value	Datapoint value (Cleaned)
uuid	730ecebc-92e8-408e-91b6-e27c36499534

It now works.

Interesting...  Looking at the property.rb file it seems like the attributes method returns a key which is nil (or at least where each_key has a nil in there somewhere) which would be very strange.
Is raw_input your property?  Is it serialized?

Here's the path:

raw_input is a String property on the model, just like usual.

classic sinatra app:
post '/test' do
...
  parsedJSON[:body] = get_parsed_requestbody(request.body.read)
  parsedJSON[:header] = request.env.select { |k, v| v.is_a? String }
...
  datapoint.raw_input = parsedJSON
  datapoint.save
...
end

Postman request using raw with JSON (see the headers above)
Fail pulling Datapoint.all using the get '/datapoints' do or irb

It seems like parsedJSON because you are setting keys on it, so do you need to do parsedJSON.to_json when setting raw_input so that it's a string?  Alternatively you could use serialization:
http://neo4jrb.readthedocs.io/en/8.0.x/ActiveNode.html#serialization

Definitely I was doing something wrong in there; I'm not looking for a fix for my specific issue, I just recognized that messing around was basically a Naughty Strings test that uncovered a possible bug:
I was able to submit data that broke the system without getting any errors while doing it.

Fair point! ;) . Thanks for the naughty report

Just did it again on a different model and with different input.
While importing everything was fine, then calling Model.all exposed the problem.

In this case, it's down to just this:

Create a model with just a name property
Read lines from a text file
Create a node with the name as the line and save it (Model.new(name: line))

At a certain point, a node is created that breaks .all

And here's a way I can reproduce it just in irb with only a few lines:
require 'json'
require 'jsonapi-serializers'
require 'neo4j'
require 'neo4j/core/cypher_session/adaptors/http'
require 'neo4j/core/cypher_session/adaptors/bolt'
require 'securerandom' # UUID
require 'rexml/document'
require 'plist'
require 'digest'
require 'open3'
require 'tempfile'
require 'sinatra/base'

NEO4J_URL = "bolt://neo4j:password@localhost:7687"

class JunkNode
  include Neo4j::ActiveNode

  property :name, type: String
end

def get_session
  neo4j_adaptor = Neo4j::Core::CypherSession::Adaptors::Bolt.new(NEO4J_URL, {wrap_level: :proc})
  Neo4j::ActiveBase.on_establish_session { Neo4j::Core::CypherSession.new(neo4j_adaptor) }

  # Enable debugging Neo4j
  Neo4j::ActiveBase.current_session.adaptor.logger.level = Logger::DEBUG #DEBUG/ERROR/WARN
  Neo4j::Core::CypherSession::Adaptors::Base.subscribe_to_query(&method(:puts))
  Neo4j::Core::CypherSession::Adaptors::Bolt.subscribe_to_request(&method(:puts))
end

def import_filelist(filename)
    File.open(filename).each_with_index do |line, index|
      if thisJunkNode = JunkNode.find_by(name: line.strip)
      puts "Found node already"
    else
      puts "Does not exist. Creating."
      thisJunkNode = JunkNode.new(name: line.strip)
      thisJunkNode.save
    end
    JunkNode.all[0]
  end
end

get_session
import_filelist("./filelist2.txt")

filelist2.txt is simply generated by:

doing find /path > ./filelist2.txt
Replacing the mount point with the drive's GPT UUID
(For example: /Volumes/Storage/file.txt becomes 77AADCB1-ABF7-38D9-8741-27990301DE1D/file.txt)

Example file: filelist.txt.zip Note: The path chosen to generate the file doesn't seem to matter

This is a show-stopper, and I keep hitting it.
Essentially, I find myself having to create a bunch of code around all the data entry functions so that I can test for 'database corruption', and it's such a huge increase in workload that it's stopping me from making significant progress.
Am I doing something the wrong way?
Am I uncovering a bug that no one else cares about?
Is this a sign that there's a more interesting language/stack that other people are using?

Could you make a repo project containing code and instructions to
reproduce? I know you have some code above but this would help me and
possibly others get to it sooner.
On Mon, Feb 27, 2017 at 8:33 AM Josh<EMAIL_ADDRESS>wrote:

This is a show-stopper, and I keep hitting it.
Essentially, I find myself having to create a bunch of code around all the
data entry functions so that I can test for 'database corruption', and it's
such a huge increase in workload that it's stopping me from making
significant progress.
Am I doing something the wrong way?
Am I uncovering a bug that no one else cares about?
Is this a sign that there's a more interesting language/stack that other
people are using?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/neo4jrb/neo4j/issues/1354#issuecomment-282720692, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AD6E93xXZ_Y3PC27STvqxV2Mnuh2DlzRks5rgtC-gaJpZM4L3imF
.

@subvertallchris For sure, thanks.
Here you go: https://github.com/Joshfindit/neo4jrb-issue-report-1354

It's been running for 25 minutes and no errors. How far into the import does it usually crash?

It finished and then died with this:
/Users/cgrigg/.rvm/gems/ruby-2.2.3/gems/neo4j-core-7.0.5/lib/neo4j/core/cypher_session/adaptors/bolt.rb:47:in `query_set': Making query, but expected there to be no buffer remaining! (RuntimeError)

https://github.com/neo4jrb/neo4j/issues/1311 references that and https://github.com/neo4jrb/neo4j-core/pull/284 might have fixed it. I don't think this is at all related to your issue, though. Maybe create a Gemfile in this repo locked to the specific versions of your dependencies?

@subvertallchris Usually it crashes within a minute.
While working with the issue, I could justify it as being a hiccup in message handling.
I did update to the latest version and test it, the issue doesn't happen here.
The repo with specific gem versions; do you mind testing to see if the issue happens in your setup with the older version?


error while running make.sh file in windows

Please tell how to run this code in windows. I ran make.sh file using GIT, but throws an error while compiling. Do we have to change anything in the make.sh file before running.Thanks in advance...

@ashacs12 did this issue solved? I am facing the same issue. please help me!


Any way to run webjobs in the same sandbox as the website?

I would like to be able to create a webjob that hosts a socket listener so the parent app website can connect to it. However that doesn't seem to work, because webjobs seem to be hosted in a different sandbox than websites (different process tree).
Is there any better solution for this than starting an exe process manually from website code? Or maybe some other workarounds, such as creating a VNet?

Try setting WEBSITE_DISABLE_SCM_SEPARATION=true, per wiki.

Thanks, David, seems like WEBSITE_DISABLE_SCM_SEPARATION should work, although the legacy part is a little discouraging... If WebJobs are first class citizens in the App Service ecosystem, I think there should be a fully supported way for the website to communicate with them. Or is the webjob functionality not really intended for any complex tasks (for which I guess the recommendation is to use Azure Service Fabric)?

WebJobs are fully supported, but the scenario of needing to have the parent app talk to it via socket is not something it was designed for (and it has not come up before afaik). I don't think this directly relate to the inability to do complex tasks. It's just one specific usage pattern that is not supported.
That being said, you might have good luck with WEBSITE_DISABLE_SCM_SEPARATION.

Sure, I will give that setting a try and test if any issues come up. Basically the idea was to host a local microservice inside the same app service, which website and other webjobs can talk to. This is similar to what Azure Service Fabric does, but I really like the simplicity of initial setup, deployment and management of the App Service. Having all this built-in functionality such as deployment slots and A/B testing is really great. And if there was a way to easily host a small service on localhost, it would be ideal. Maybe there is still a way that I didn't consider?
Anyway, thank you for your comments, I'm sure I'll be able to either use WEBSITE_DISABLE_SCM_SEPARATION or reference the required functionality from the website code directly instead of calling the local service.


Bug: Only rely on Cache key for hit/misses regardless of Path

Background
It appears that even though the Cache key being used to store and retrieve the cache is the same, a cache hit never occurs because the path string is different.
Here's a screenshot of two jobs on main in a row with the same cache key...we get a cache miss but successful cache upload in both jobs:

The only thing different here is the path. This leads me to believe that the string to the path is influencing the caching which caught me by surprise and isn't mentioned anywhere in the docs.
I saw this being mentioned in a couple other issues:
https://github.com/actions/cache/issues/735#issuecomment-1036402013
https://github.com/actions/cache/issues/638#issuecomment-1002972310
This is a bummer because we currently isolate all builds by commit SHA so our path will always be different even though our key based on hashing yarn.lock doesn't change which makes this module unusable in our current workflow, ie:
path: ${{ github.sha }}/**/node_modules  will always return a cache miss for any new commit even on the same branch.
Proposal

Make it clear in the docs that path influences how cache hits/misses
Allow option to strictly look at the Cache key ONLY for hits/misses, otherwise this is unusable for anyone using dynamic paths for their cache workflows

One could say this is a bug if the documentation states that caching occurs when cache key is the same, says nothing about the path having to be the same as well.

It would be REALLY helpful to have the action print out when it fails due to the path. Right now it says:
Cache not found for input keys: proj-Linux-8.1.1-0

and I just spent a day trying to figure out how that happens but I was also seeing:
Unable to reserve cache with key proj-Linux-8.1.1-0, another job may be creating this cache. More details: Cache already exists. Scope: refs/pull/2529/merge, Key: proj-Linux-8.1.1-0, Version: 37db103cc447fb2a9f90faf2fc822b81d14099bd26899a64836c9e097ec1952c

when it turns out that (somehow) the cache was saved with a path of ~ instead of ~/local. Trying to debug that without a UI to look at cache details (or even an API to list the active caches) was terrible. (Not to mention trying to delete the bad one now is going to be fun...)

I currently figured a workaround for my solution. You can simply add a symlink step to the current working directory and then use relative paths once again which means static strings for the Key/Path are static once again and don't include the github.sha
ln -snf /home/meow/app-builds/${{ github.sha }} ${{ github.workspace }}/${{ github.sha }}

Thank you for the solution! I created an action that uses mktemp -d to create a temporary workspace, and wanted to implement caching for a specific resource.
One thing I also stumbled across - don't use path: ${{ symlink }}, as this will cache the symlink itself, but not the files below it. Either specify a file, a deeper path, or a glob.


Update ChainerMN documents

Fix #5297
Merge #5300 first.

Rebased to the latest master.
Jenkins, test this please.

Jenkins CI test (for commit 50af6cf08c3ca61700ca4e710986f315da2e43de, target branch master) succeeded!

Test failures seems not related to this PR.

Jenkins CI test (for commit 1f9bba92c35254188b7daac8f886b9fd4aff997f, target branch master) succeeded!

👍 to merge.


iox-#1364 Add dep for idlc command to iceoryx_dds

The custom_command for generating the Mempool header
was not explicitly declared as dep to iceoryx_dds
but was still working because it was always executed
before building iceworyx_dds when using CMake on multiple cores
Signed-off-by: Dietrich Krönke<EMAIL_ADDRESS>Pre-Review Checklist for the PR Author

[x] Code follows the coding style of CONTRIBUTING.md
[x] Tests follow the best practice for testing
[x] Changelog updated in the unreleased section including API breaking changes
[x] Branch follows the naming format (iox-#123-this-is-a-branch)
[x] Commits messages are according to this guideline

[x] Commit messages have the issue ID (iox-#123 commit text)
[x] Commit messages are signed (git commit -s)
[x] Commit author matches Eclipse Contributor Agreement (and ECA is signed)

[x] Update the PR title

Follow the same conventions as for commit messages
Link to the relevant issue

[x] Relevant issues are linked
[x] Add sensible notes for the reviewer
[ ] All checks have passed (except task-list-completed)
[x] Assign PR to reviewer

Notes for Reviewer

Checklist for the PR Reviewer

[ ] Commits are properly organized and messages are according to the guideline
[ ] Code according to our coding style and naming conventions
[ ] Unit tests have been written for new behavior

[ ] Each unit test case has a unique UUID

[ ] Public API changes are documented via doxygen
[ ] Copyright owner are updated in the changed files
[ ] PR title describes the changes

Post-review Checklist for the PR Author

[ ] All open points are addressed and tracked via issues

References

Closes #1364

@quanqixian Feel free to test if that works for you as well


refactor(compilation): process dependencies should happen after all dependencies get factorized

Summary

Test Plan

Require Documentation?

[ ] No
[ ] Yes, the corresponding rspack-website PR is __

Current dependencies on/for this PR:

main

PR #4835   👈

This stack of pull requests is managed by Graphite.

!bench

!bench


docker ps --help is unpretty

Output of docker version:
Client:
 Version:      1.12.0-rc2
 API version:  1.24
 Go version:   go1.6.2
 Git commit:   906eacd-unsupported
 Built:        Fri Jun 17 21:12:28 2016
 OS/Arch:      linux/amd64
 Experimental: true

Steps to reproduce the issue:
docker ps --help
Describe the results you received:
-- is unneeded and misleading
Usage:  docker ps [OPTIONS]

List containers

Options:
  -n, -- int            Show n last created containers (includes all states) (default -1)
  -a, --all             Show all containers (default shows just running)
  -f, --filter value    Filter output based on conditions provided (default [])
      --format string   Pretty-print containers using a Go template
      --help            Print usage
  -l, --latest          Show the latest created container (includes all states)
      --no-trunc        Don't truncate output
  -q, --quiet           Only display numeric IDs

Describe the results you expected:
The following result seems mostly expected:
  -n int                            Show n last created containers (includes all states) (default -1)

But I don't think it can be easily implemented without making a modification to spf13/pflag.
https://github.com/docker/docker/blob/v1.12.0-rc2/api/client/container/ps.go#L58
So I suggest adding --some-long-flag (I dont stick to --latest-n) like this:
  -n, --latest-n int            Show n last created containers (includes all states) (default -1)

/cc @dnephin @thaJeztah

Sounds right. It probably doesn't hurt to add a long flag for it instead of patching pflag to support short-only-flags

#dibs

Since there's already a **--latest ** flag available, a --latest-n looks uniform.


Support Resnet18 backbone?

What is the problem this feature will solve?
Hi, I wonder does this repo have SSL pretrained weights for Resnet-18? It would be very useful to have weights with resnet-18 as backbone that can be used in other areas that don't have a lot of data for fine-tuning.
What is the feature?
Pretrained model for Resnet-18 backbone.
What alternatives have you considered?
No response

Thanks for your suggestion. We will add this to our backlog and provide ResNet18 backbones ASAP. Currently, we don't have  pre-trained model of ResNet18.


[Makefile] Use EXPORT_CC for make crystal

All recipes use the EXPORT_CC override to configure using lld as linker, except for make crystal. Apparently, that's rarely an issue. But I recently started seeing linking errors like the ones in #7177 with default ld. Using lld fixes that, as we're already doing for all other build targets. This patch usees EXPORT_CC  for make crystal as well (via EXPORTS_BUILD).

I considered refactoring this entirely as proposed in https://github.com/crystal-lang/crystal/pull/8641#issuecomment-570608173 but I decided to make that a separate change. I'm not sure yet if there should be an option to override adding -fuse=ld.lld to CC (which is currently possible by defining EXPORT_CC).

@straight-shoota , hi, can we add  example here for how use ld.ldd as linker when run make in linux?
There is a issue #12542 probably related to this.

Hm, the makefile automatically uses ld.ldd if it's available.


使用说明不够清晰

能理解这个工具想要实现什么功能，很感兴趣，但根据目前的说明文档，看不懂到底如何使用。

I will try to implement a more intuitive way of defining words, but at the moment, to understand how it works, you can create a folder with the name 'definitions' at the root of your vault. Then add a file within the folder with the following content:
# Definition

This is a test definition

---

# Definition2

This is a second definition

Now when you type these two words anywhere in your notes, you will be able to see them marked and when hovering over them, you should also be able to see the definition popovers. Do let me know if you have any other questions.

I will try to implement a more intuitive way of defining words, but at the moment, to understand how it works, you can create a folder with the name 'definitions' at the root of your vault. Then add a file within the folder with the following content:
# Definition

This is a test definition

---

# Definition2

This is a second definition

Now when you type these two words anywhere in your notes, you will be able to see them marked and when hovering over them, you should also be able to see the definition popovers. Do let me know if you have any other questions.

谢谢，根据你的提示，现在成功地用上了。
我来补充一下先前的描述为什么不太容易理解：
1、”the root of your vault “，根目录。
虽然这个说法是准确的，但不太容易理解。
以及，在obsidian中，复制一个文件夹或文件的路径非常不方便，尤其是涉及斜杠或者反斜杠，相对路径或绝对路径，容易让人混淆。
考虑到这句话包括下面的意思：在自己的笔记库中建立一个文件夹；该文件夹需要是第一层级，不能是某个文件夹的子文件夹。
也许更直接的做法是：

初次使用时，不需要用户建立definitions文件夹，而是在启动插件时就自动建立该文件夹。
如果有需要的话，后续用户可以修改definitions文件夹。
用户在修改definition时，支持直接选择某个已存在的文件夹，而不必输入路径。

2、add a file within the folder，文件夹中的文件
也就是说，新建的文档，可以是一个普通文档，对文件名没有任何要求。
也许更直接的说法是：

新建一文档，在其中按照示例的格式存放内容即可。
新建的文档，是一个普通文档，对文件名没有任何要求。

我非常喜欢这个插件，很早以前有尝试通过obsidian的内部链接功能来自定义词库，但操作还是过于复杂了，现在这个方式很直接，谢谢！

Thanks for the great suggestions! I think creating a definitions folder by default is a good idea, I'll add that, probably along with an example definition file. I agree that allowing the user to choose a folder path instead of an input box is better too, I will look into implementing that as well. Appreciate the ideas!


Message card embedding via add-in?

Is it possible to embed an actionable message card into an email via Office.context.mailbox.item.body.setSelectedDataAsync from an add-in?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: e36738b7-29cb-00c2-30e3-6065addee4c1
Version Independent ID: 57a934d1-7e50-a144-d461-fc55175acfb8
Content: Get started with actionable messages via email
Content Source: docs/actionable-messages/actionable-messages-via-email.md
Product: outlook
GitHub Login: @jasonjoh
Microsoft Alias: jasonjoh

No. Actionable messages MUST go through the delivery pipeline, you can't add them after the message is delivered.

I mean to ask is it possible to embed it during the composition phase of the email?
e.g.

Ah sorry, I misunderstood. I'm not 100% sure. Cards have to go into the <head> of the HTML body, so setSelectedDataAsync likely would not work (as I recall, I believe it only has access to the <body>). You might be able to do it via body.setAsync, but there's a note on the docs that Outlook may modify what you pass to that API. You'd have to try it and see.

It looks to be unsupported at this time (even by sending an entire HTML document via body.setSelectedDataAsync).
This would definitely a great future enhancement though!
Thanks for being so prompt @jasonjoh.


Expo link not working

https://expo.io/@osdnk/reanimated-bottomsheet-expample
When I try to open this on my phone, the Expo app gives me the error:

There was a problem loading the requested app.
Experience "@osdnk/reanimated-bottomsheet-expample" for platform "ios" is not viewable by you. You will need to authenticate or ask the author to grant you access.

Ugh, it works only on Android. I should probably add Snack link.

you can open it in expo simulator at least! and soon we'll have a way to open on your phone too but sadly apple forced us to remove this capability from the app store build


Fix layout issues caused by not accounting for the textScaleFactor

This fixes the layout issues seen when the system font size is increased. The math.max makes sure that the kSongTileHeight doesn't get too small. This is not the most elegant solution, since it requires us to pass the textScaleFactor around a lot, let me know if you find a better solution. Fixes #66.

Largest font
Smallest font

I can't tell if this introduces some visual changes in the default configuration. Please update the goldens on the 1.0.8 branch before merging this, so we can compare against a clean baseline again.

I found a better solution that doesn't require a full call to layout (77cb463).
If you are still concerned about performance, we can cache the result using the memoize package.

Yep, so
I actually tried writing an optimization for it and compared it with preferredLineHeight performance and accuracy.
Accuracy
It's acceptable in accuracy, and such print outputs the following:
(But I still don't like it, I wrote why at the end)

final textScaleFactor = MediaQuery.of(context).textScaleFactor;
  print('fff textScaleFactor: $textScaleFactor, preferredLineHeight: ${math.max(kSongTileArtSize, kSongTileTextHeight(context)) + _tileVerticalPadding * 2}, optimized ${kSongTileArtSize + _tileVerticalPadding * 2 + _calculateTextHeight(context)}');

fff textScaleFactor: 1.0, preferredLineHeight: 64.0, optimized 64.0
fff textScaleFactor: 1.25, preferredLineHeight: 70.0, optimized 72.875
fff textScaleFactor: 1.5, preferredLineHeight: 79.0, optimized 81.75
fff textScaleFactor: 1.75, preferredLineHeight: 90.0, optimized 90.625
fff textScaleFactor: 2.0, preferredLineHeight: 99.0, optimized 99.5
fff textScaleFactor: 2.25, preferredLineHeight: 108.0, optimized 108.375
fff textScaleFactor: 2.5, preferredLineHeight: 118.0, optimized 117.25 <- optimized is less than preferredLineHeight

Benchmark

Code
T measure<T>(Function callback) {
  final s = Stopwatch();
  s.start();
  final result = callback();
  s.stop();
  debugPrint('elapsed ${s.elapsedMicroseconds}');
  return result;
}

double kSongTileHeight(BuildContext context) {
  return measure<double>(() => _kSongTileHeight(context));
}

double _kSongTileHeight(BuildContext context) {
  return math.max(kSongTileArtSize, kSongTileTextHeight(context)) + _tileVerticalPadding * 2;

  // my optimization
  return kSongTileArtSize + _tileVerticalPadding * 2 + _calculateTextHeight(context);
}

preferredLineHeight
I/flutter (24925): elapsed 8291
I/flutter (24925): elapsed 241
I/flutter (24925): elapsed 256
I/flutter (24925): elapsed 320
I/flutter (24925): elapsed 302
I/flutter (24925): elapsed 1068
I/flutter (24925): elapsed 269
I/flutter (24925): elapsed 258
I/flutter (24925): elapsed 193
I/flutter (24925): elapsed 1207
I/flutter (24925): elapsed 541
I/flutter (24925): elapsed 220
I/flutter (24925): elapsed 312
I/flutter (25123): elapsed 286
I/flutter (25123): elapsed 277
I/flutter (25123): elapsed 316
I/flutter (25123): elapsed 534
I/flutter (25123): elapsed 330
I/flutter (25123): elapsed 275
I/flutter (25123): elapsed 302
I/flutter (25123): elapsed 239
I/flutter (25123): elapsed 267
I/flutter (25123): elapsed 275
I/flutter (25123): elapsed 286
I/flutter (25123): elapsed 310
I/flutter (25123): elapsed 398
I/flutter (25123): elapsed 1372
I/flutter (25123): elapsed 462
I/flutter (25123): elapsed 394
I/flutter (25123): elapsed 305
I/flutter (25123): elapsed 420
I/flutter (25123): elapsed 392
I/flutter (25123): elapsed 355

my optimization
I/flutter (25443): elapsed 93
2
I/flutter (25443): elapsed 4
I/flutter (25443): elapsed 5
I/flutter (25443): elapsed 14
I/flutter (25443): elapsed 32
I/flutter (25443): elapsed 10
I/flutter (25443): elapsed 5
I/flutter (25443): elapsed 12
I/flutter (25443): elapsed 38
I/flutter (25443): elapsed 14
2
I/flutter (25443): elapsed 5
3
I/flutter (25783): elapsed 21
2
I/flutter (25783): elapsed 17
I/flutter (25783): elapsed 14
I/flutter (25783): elapsed 17
I/flutter (25783): elapsed 14
I/flutter (25783): elapsed 16
I/flutter (25783): elapsed 25
I/flutter (25783): elapsed 18
I/flutter (25783): elapsed 17
I/flutter (25783): elapsed 19
I/flutter (25783): elapsed 15
I/flutter (25783): elapsed 18
I/flutter (25783): elapsed 25
I/flutter (25783): elapsed 27

memoization
I/flutter (19906): elapsed 28
2
I/flutter (19906): elapsed 23
I/flutter (19906): elapsed 15
I/flutter (19906): elapsed 17
I/flutter (19906): elapsed 21
I/flutter (19906): elapsed 27
I/flutter (19906): elapsed 25
I/flutter (19906): elapsed 29
I/flutter (19906): elapsed 22
I/flutter (19906): elapsed 28
I/flutter (19906): elapsed 18
I/flutter (19906): elapsed 16
I/flutter (19906): elapsed 21
I/flutter (19906): elapsed 31
I/flutter (19906): elapsed 18
I/flutter (19906): elapsed 24
I/flutter (19906): elapsed 32
I/flutter (19906): elapsed 20
I/flutter (19906): elapsed 21
2
I/flutter (19906): elapsed 20
I/flutter (19906): elapsed 21
I/flutter (19906): elapsed 486
I/flutter (19906): elapsed 25
I/flutter (19906): elapsed 31
I/flutter (19906): elapsed 22
I/flutter (19906): elapsed 19
I/flutter (19906): elapsed 27
I/flutter (19906): elapsed 30

Discussion
One think I don't like about my optimization is that it's not accurate. Eventually, with values >= 2.5 (which is unrealistic, practically speaking, but possible in theory), it diverges more and more from preferredLineHeight.
As you suggested, I would like to use memoization here, so we keep the accuracy preferredLineHeight of and fairly optimize it.
The need in memoization is especially exacerbated by the fact that this method used to be a constant and, for example, its value was used in the animation of the player route (see TrackPanel.height(context)) - so it can be called on each frame. Without memoization we are forcing the app to do a lot fo unnecessary work.

I am merging this PR as-as and will implement memoization and further fixes to textScaleFactor in a separate PR myself.
Thank you for contributing to this project! ❤

Perfect, thank you for merging this.
I agree with you, caching definetly sounds like a good idea and the optimization, even though it would be nice and fast, will be a problem with larger font sizes.
It also potentially might be a problem with different fonts. Although I don't have an example of a specific font, TrueType fonts can have different appearances for different sizes and resolutions, so they might change height in a way that the optimization can't predict. (From Microsoft's TrueType fundementals: TrueType instruction set provides a powerful means of controlling glyph outlines at all or specific sizes and resolutions.)


Metric types in point.go don't align with protobuf

Please answer these questions before submitting a bug report.
What version of OpenCensus are you using?
0.22.4
What version of Go are you using?
1.14.2
What did you do?
If possible, provide a recipe for reproducing the error.

I created a custom exporter
I created a library to convert metricdata.Metric to its protobuf format
observe the exported protobuf metric type

What did you expect to see?
I expected to see the metric type returned from https://github.com/census-instrumentation/opencensus-go/blob/master/stats/view/view_to_metric.go#L39-L76
What did you see instead?
I saw an incorrect metric type
Additional context
Add any other context about the problem here.
The metric types defined in the Metrics API are as follows. https://github.com/census-instrumentation/opencensus-go/blob/master/metric/metricdata/point.go#L185-L193. However, in the OpenCensus metrics protobuf they are defined as https://github.com/census-instrumentation/opencensus-proto/blob/master/gen-go/metrics/v1/metrics.pb.go#L61-L89. Since the protobuf start on 0 as unspecified type it would make sense to start the enum metric types in point.go at 1 as well since metrics will panic during conversion from view to metric if it receives an unspecified type https://github.com/census-instrumentation/opencensus-go/blob/master/stats/view/view_to_metric.go#L39-L76

While this change would be nice for simplicity, we are generally limiting any changes to OpenCensus to critical bug fixes given that OpenCensus is being wound down in favour of OpenTelemetry. I don't think anything is actually broken here. The OC agent exporter correctly maps SDK types to proto types afaict.


Migration to RTD

List of tasks for the migration to RTD

[x] Convert infrastructure to work with rtd See https://github.com/ome/omero-documentation/pull/2195
[x] Review version number since doc and openmicroscopy release will no longer match
[x] Select name on rtd i.e. https://omero.readthedocs.io. This will be final see https://github.com/ome/omero-documentation/issues/2198#issuecomment-985521246
[x] Redirect

[ ] https://docs.openmicroscopy.org/omero/latest to https://omero.readthedocs.io/en/stable/ i.e. latest -> stable
[ ] https://docs.openmicroscopy.org/omero/5 to https://omero.readthedocs.io/en/stable/.

[x] Check change of name on rtd. See https://github.com/ome/omero-documentation/issues/2198#issuecomment-985521246
[x] Automatic synchronisation with upstream repositories. See https://github.com/ome/omero-documentation/pull/2197
[x] Configure readthedocs
[x] Adjust CI to build doc

Source https://docs.readthedocs.io/en/stable/faq.html
How do I change my project slug (the URL your docs are served at)?¶
We don’t support allowing folks to change the slug for their project. You can update the name which is shown on the site, but not the actual URL that documentation is served.

The main reason for this is that all existing URLs to the content will break. You can delete and re-create the project with the proper name to get a new slug, but you really shouldn’t do this if you have existing inbound links, as it breaks the internet.

If that isn’t enough, you can request the change sending an email to<EMAIL_ADDRESS>
How do I change the version slug of my project?¶
We don’t support allowing folks to change the slug for their versions. But you can rename the branch/tag to achieve this. If that isn’t enough, you can request the change sending an email to<EMAIL_ADDRESS>

https://omero.readthedocs.io/en/latest/  corresponds to the develop and the version is hidden See https://dev.readthedocs.io/en/latest/design/privacy-levels.html
https://omero.readthedocs.io/en/stable corresponds to the tag. This is the equivalent to https://docs.openmicroscopy.org/omero/latest when

I have added a rule so a dedicated version is automatically built  when a tag is pushed
see for example https://omero.readthedocs.io/en/v5.6.4-2/

Is the plan to enable rtd on pull requests (similar to the guides for instance)? If so, does this make https://github.com/ome/omero-documentation/blob/develop/.github/workflows/sphinx.yml effectively redundant ?

It should be enabled on pull requests, so yes the job will be redundant

Redirect options

https://docs.openmicroscopy.org/omero/latest -> https://omero.readthedocs.io/en/stable/

https://docs.openmicroscopy.org/omero/5.6.x/ -> https://omero.readthedocs.io/en/v5.6.x/
https://docs.openmicroscopy.org/omero/5 -> https://omero.readthedocs.io/en/stable/ (preferred) or https://omero.readthedocs.io/en/v5.6.x/ The second option means that each time we push a redirect will need to be updated

https://docs.openmicroscopy.org/omero/5..6 -> https://omero.readthedocs.io/en/stable/ (preferred) or https://omero.readthedocs.io/en/v5.6.x/ The second option means that each time we push a redirect will need to be updated

From a quick look, .htaccess seem to do the job for redirecting /omero/XXX URLs to another domain including deep link redirects.
A few questions:

https://docs.openmicroscopy.org/omero/5.6.x/ -> https://omero.readthedocs.io/en/v5.6.x/

For instance, we already published https://omero.readthedocs.io/en/v5.6.5-1/ with minor modifications. Does this mean this link will need to keep evolving every time we make a rtd release?

https://docs.openmicroscopy.org/omero/latest -> https://omero.readthedocs.io/en/stable/
https://docs.openmicroscopy.org/omero/5 -> https://omero.readthedocs.io/en/stable/ or https://omero.readthedocs.io/en/v5.6.x/

What about retaining the existing logic and have
https://docs.openmicroscopy.org/omero/latest  -> https://docs.openmicroscopy.org/omero/5.6.5 -> https://omero.readthedocs.io/en/v5.6.x/ ?
I assume some links will need to be updated on every OMERO.server release anyways?

https://docs.openmicroscopy.org/omero/latest -> https://docs.openmicroscopy.org/omero/5.6.5 -> https://omero.readthedocs.io/en/v5.6.x/ ?

that means that https://docs.openmicroscopy.org/omero/latest  will rarely point to https://omero.readthedocs.io/en/stable/
i.e. each time we do a doc update we will need to update the redirect

i.e. each time we do a doc update we will need to update the redirect

So you would not update https://docs.openmicroscopy.org/omero/5.6.5  when a new 5.6.5-z tag is pushed to this repository either ? That's the least amount of maintenance but we need to be comfortable with the fact that our redirects might point to outdated readthedocs versions.

Also sharing the configuration for the redirection which is pretty simple
[sbesson@idr0-slot3 5.6.5]$ cat .htaccess
Redirect 301 /omero/5.6.5 https://omero.readthedocs.io/en/v5.6.5-1/

i.e. each time we do a doc update we will need to update the redirect

So you would not update https://docs.openmicroscopy.org/omero/5.6.5 when a new 5.6.5-z tag is pushed to this repository either ? That's the least amount of maintenance but we need to be comfortable with the fact that our redirects might point to outdated readthedocs versions.

There's a banner indicating that there's a new version of you are looking at the most recent tag for example go to v5.6.5

The proposal from https://github.com/ome/omero-documentation/issues/2198#issuecomment-1169926854 is now implemented and should redirect both the top-level and the deep links
[sbesson@idr0-slot3 omero]$ cat 5.6.5/.htaccess
Redirect 301 /omero/5.6.5 https://omero.readthedocs.io/en/v5.6.5/
[sbesson@idr0-slot3 omero]$ cat 5.6/.htaccess
Redirect 301 /omero/5.6 https://omero.readthedocs.io/en/stable/
[sbesson@idr0-slot3 omero]$ cat 5/.htaccess
Redirect 301 /omero/5 https://omero.readthedocs.io/en/stable/
[sbesson@idr0-slot3 omero]$ cat latest/.htaccess
Redirect 301 /omero/latest https://omero.readthedocs.io/en/stable/

No immediate objection to moving with this approach and possibly revisiting later but I'll leave others who have been updating the technical documentation to review /cc @joshmoore @pwalczysko

I think we should try to automate that.
I will check

I have made the release process section more visible see https://github.com/ome/omero-documentation/pull/2260

Assuming this can be closed?


can not start docker

error messages below
any suggestions ?
2018-06-29 18:21:17 [minion@067 authelia]$ docker run -v config.yml:/etc/authelia/config.yml  clems4ever/authelia
fs.js:682
  return binding.read(fd, buffer, offset, length, position);
                 ^

Error: EISDIR: illegal operation on a directory, read
    at Object.fs.readSync (fs.js:682:18)
    at tryReadSync (fs.js:543:20)
    at Object.fs.readFileSync (fs.js:586:19)
    at Function.Utils.getStringFromFile (/usr/src/node_modules/yamljs/lib/Utils.js:284:19)
    at Function.Yaml.parseFile (/usr/src/node_modules/yamljs/lib/Yaml.js:46:21)
    at Function.Yaml.load (/usr/src/node_modules/yamljs/lib/Yaml.js:78:17)
    at Object.<anonymous> (/usr/src/server/src/index.js:12:26)
    at Module._compile (module.js:624:30)
    at Object.Module._extensions..js (module.js:635:10)
    at Module.load (module.js:545:32)
    at tryModuleLoad (module.js:508:12)
    at Function.Module._load (module.js:500:3)
    at Function.Module.runMain (module.js:665:10)
    at startup (bootstrap_node.js:187:16)
    at bootstrap_node.js:608:3

Hello @changchichung , please use argument -v $(pwd)/config.yml:/etc/authelia/config.yml instead. It's like config.yml is a directory in the container.

Hello @changchichung , any news? Let's reopen the ticket if my suggestion does not solve your issue.

not working for me - theres still a folder "config.yml" but no file

You need to copy/create the config.yml file somewhere on your host system and volume mount that in to the container.
If it's showing up as a folder it's because you haven't put the file there in the first place.


Cannot read Vite manifest file since 3.0.0

I updated my config to 3.0.0 but it seems unable to read the isDynamicEntry property on some entries in the manifest generated by vite.
It now throws a warning:
WARNINGS:
?: (django_vite.W001) Cannot read Vite manifest file for app default at /workspace/dist/manifest.json : <lambda>() got an unexpected keyword argument 'isDynamicEntry'
        HINT: Make sure you have generated a manifest file, and that DJANGO_VITE["default"]["manifest_path"] points to the correct location.

Are you using Vite 5? There were some changes with manifest https://vitejs.dev/guide/migration.html#manifest-files-are-now-generated-in-vite-directory-by-default

Okay, I found the issue. Previously, django-vite loaded manifest entry data into dicts. Now it loads that data into a NamedTuple named ManifestEntry. And the key isDynamicEntry wasn't explicitly supported in our ManifestEntry, so we "got an unexpected keyword argument". The linked PR will fix this and get us back to the original behavior we had in v2.
Follow up question, does django-vite need to do anything to support dynamic imports? I wouldn't think so, I think the JavaScript code should be able to handle it by itself. And I don't think we want preload tags on dynamic imports.

?: (django_vite.W001) Cannot read Vite manifest file for app default at /Users/acu/Work/octolo-up/static/manifest.json : ManifestEntry.__new__() got an unexpected keyword argument 'dynamicImports'
	HINT: Make sure you have generated a manifest file, and that DJANGO_VITE["default"]["manifest_path"] points to the correct location.

@Niicck there it is


Eager loading associations

👋
It would be great if MeiliSearch would support eager loading associations to avoid N+1 queries when reindexing. For example, here's my usecase:
class User < ApplicationRecord
  has_many :memberships
  include MeiliSearch::Rails

  meilisearch do
    attribute :account_id do
      memberships.map(&:account_id)
    end
    filterable_attributes [:account_id]
  end
end

Simple scope overriding could work, for example:
class User < ApplicationRecord
  scope :meilisearch_import -> { includes(:memberships) }
end

Let me know if it's ok and I'll open a PR. Thanks!

Hi @rolandasb did you tried something like this:
User.includes(:memberships).reindex!

That definitely works, but it could become tedious to explicitly define associations in every reindex! call, especially when one model needs to use multiple associated attributes. Also, one could argue it's a part of meilisearch configuration, thus it should live inside a model.

I agree with this statement "Also, one could argue it's a part of meilisearch configuration, thus it should live inside a model." but doing that we also have full control of the association loading.
But in any case, I think we definitely can add a scope as you suggested! But @rolandasb I currently do not have free time to work in this request, what do you think to contribute 😍 ?


[Calling][Bug] camera stream is not visible to remote participant after call resume from background mode

Purpose

Resume call on hold from background mode, does not show video stream to remote participants

Does this introduce a breaking change?

[ ] Yes
[x] No

Pull Request Type
What kind of change does this Pull Request introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[ ] Other... Please describe:

Pull Request Checklist

[ ] Public API changes
[ ] Verified for cross-platform
[ ] Synced with iOS, Web team
[ ] Internal review completed
[ ] UI Changes

[ ] Screen captures included
[ ] Tested for Light/Dark mode
[ ] Tested for screen rotation
[ ] Tested on Tablet and small screen device (5")
[ ] Include localization changes

[ ] Tests

[ ] Memory leak analysis performed
[ ] Tested on API 21, 26 and latest
[x] Tested for background mode
[x] Unit Tests Included
[ ] UI Automated Tests Included

Tested.


keys are inconsistent with different backends

When using the env backend, then the only keys considered will be those with config: field tags. However, if you're using a file backend, then the entire struct is unmarshaled from the source, and all fields will be considered, even those without a config tag.
So it's possible there are some fields which are configurable only with the file backend and not with the env backend.
I think that probably that any keys that don't specify the config: tag should be ignored so backends are more consistent.

To go into a bit more detail on this:
The confita README says:

Confita scans a struct for config tags and calls all the backends one after another until the key is found. The value is then converted into the type of the field.

and then, later on:

As a special case, if the field tag is "-", the field is always omitted. This is useful if you want to populate this field on your own.

This description is true for all the backends except the file backend, which instead unmarshals the file data directly into the struct, meaning that the config tags are entirely ignored.
This has a few implications:

some values are only configurable in certain backends. For example, in the kafka-proxy service, it's possible to configure the proxies with the file backend but not using any of the other backends.
some types are not consistently treated. For example, a time.Duration field will accept 4h30m in all backends except when using JSON or TOML in the file backend, where you'd need to use<PHONE_NUMBER>0000.
fields that are explicitly marked with config:"-" are not ignored when using the file backend. For example, in the kafka-go component, the Consumer field is marked to be ignored, but will actually be unmarshaled when using the file backend.

This issue won't be trivial to fix in a backward compatible fashion, as making field names consistent would break some existing behaviour.
Here is some code that demonstrates some of the issues: https://play.golang.org/p/UJcNsbP6NOc

Good catch @rogpeppe.
As you said it will be complicated to fix that without breaking the actual API.
Do you have any idea in mind?

I would like to work on this issue, any guidance or directions?

@rmcodor we're actually about to branch the current codebase into a V0 branch and work on a major restructuring should make things more consistent.  I'd hold off before diving into anything too big.    Are you looking to work on it because it's an issue that affects you, or are you just looking for things to do?  If it's the latter we can chat about that too.


keep log level when using WithFields or WithName

Motivation
Closes #1796
Changes
Attached log level to the log struct to reproduce same level when cloning.
Test Plan
no tests needed
TODO

[x] Explain motivation or link existing issue(s)
[x] Test changes and document test plan
[x] Update documentation as needed

bors merge


HTML report not generated not every time

I am having a strange issue where the report in the HTML format is not created every time my test suite is ran. Even though I run rake test several times a day, my index.html report is 6 days old and I can't seem to have it refreshed with my latest run data.
In the test_helper.rb, I have:
require 'simplecov'
SimpleCov.command_name 'test:unit'
SimpleCov.coverage_dir('coverage/api/unit')

And my .simplecov file contains:
# rubocop:disable Style/FileName
require 'simplecov-lcov'
require 'simplecov-summary'

SimpleCov.coverage_dir('coverage/api')
SimpleCov.maximum_coverage_drop(0.5)

SimpleCov::Formatter::LcovFormatter.config.report_with_single_file = true
SimpleCov.formatters = SimpleCov::Formatter::MultiFormatter.new([
  SimpleCov::Formatter::HTMLFormatter,
  SimpleCov::Formatter::LcovFormatter,
  SimpleCov::Formatter::SummaryFormatter
])

SimpleCov.profiles.define('adgear') do
  load_profile('rails')
  # [ bunch of regular add_filter and add_group('Some Name', 'some/path')
end

SimpleCov.start('adgear')
# rubocop:enable Style/FileName

When I try to use SimpleCov.at_exit {  } block, it is not executed (I tried raising an error in this block, output a hello_world, write a file, but nothing is executed from my custom block).
Using:

simplecov-0.16.1
simplecov-html-0.10.2

Same questions as in colszowka/simplecov#685 basically :)

This is a sibling issue in simplecov itself and the PR for that is almost merged --> closing


Update install instructions on README

MERGE THIS JUST BEFORE v11 RELEASE.
Depends on #6888.

@emcastillo Failed to backport automatically.

Not cleanly cherry-picked

@emcastillo This pull-request is marked as to-be-backported, but the corresponding backport PR could not be found. Could you check?

manually backported in #6925


[FLINK-26693][Documentation] Modify the grammar mistakes in savepoint

What is the purpose of the change
Modify the grammar mistakes in savepoints.md
Brief change log

Change the sentence "The legacy is mode is how Flink worked until 1.15." to "The legacy mode is how Flink worked until 1.15."

Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): (no)
The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
The serializers: (no)
The runtime per-record code paths (performance sensitive): (no)
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (no)
The S3 file system connector: (no)

Documentation

Does this pull request introduce a new feature? (no)

@Myracle Because the CI was broken for master, I've rebased your PR and pushed the changes. If the CI passes, I'll merge your change

@MartijnVisser Thanks. I will read the doc and try the best way next time.

@flinkbot run azure


Can we make BufferPool bind to Logger?

Sometimes we need to specify different buffer pools for different loggers. The current version makes it impossible for us to do so!
like:
Logger.SetBufferPool(pool BufferPool)

The advantage of this is that loggers for different purposes can use different buffers.
type LimitBufferPool struct {
    pool *sync.Pool
    cap int
}

func (p *LimitBufferPool) Put(buf *bytes.Buffer) {
    if buf.Cap() > p.cap {
        return
    }
    p.pool.Put(buf)
}

func (p *LimitBufferPool) Get() *bytes.Buffer {
    return p.pool.Get().(*bytes.Buffer)
}

That could be practical indeed. The trick though is too make the implementation so that it doesn't break application which does not set this field upon static declaration of a logger.
A pull request would be most welcome.

I'll implement it by the end of the weekend.

link #1253

The feature has been implemented.


[Question] Rendering of trained agent trials

Hi,
Thank you very much for sharing such great work!
I am trying to reproduce various methods using these source codes.
How can I render the agent's trials and save a video like the gif on the home page using the learned model parameters?
Thank you ahead!

Hi,
Thanks for your attention to our work. You can use the run_sim.py to simulate your trained model and set the render param as True in the config file.
I am sorry the codebase is not clean yet. We will release the fully worked version in next two weeks.

Dear Author,
Hello!
I'm having an issue when attempting to run the run_sim.py file in the project. Specifically, at line 47 in the "/root/d3il-main/d3il-main/environments/dataset/avoiding_dataset.py" file, which is "env_state = pickle.load(f)", a "_pickle.UnpicklingError: invalid load key, '['" error occurs. I have already added the avoiding data of 'data' to the correct position. Could you please help me with this? Thank you very much for your attention and assistance. It's really troublesome.


⚠ Bofrost.lu has degraded performance

In 5a5ba47, Bofrost.lu (https://www.bofrost.lu) experienced degraded performance:

HTTP code: 200
Response time: 1171 ms

Resolved: Bofrost.lu performance has improved in 05cc64f after 6 minutes.


CORE-19896: report timestamp skew

We suspect timestamp inconsistency between the flow worker and persistence worker. Adding logging stamps in those workers to test out whether or not our suspicion was correct.

we are not logging timestamp


Latest release (0.182.0) includes old .nupkg downloads

Not sure what happened with this build, but it's showing 0.181.0 .nupkg files in addition to the latest release's files.

Thanks so much for reporting this, I think the CI machines failed to delete these, I've removed them manually.


Make qt_viewer private

🧰 Task
In #1878 we discussed making window.qt_viewer private, so it would be window._qt_viewer.
We need to discuss this more before implementation as see real world usage here https://github.com/search?q=.window.qt_viewer&type=code, but it still might be worth doing as we expand the ability to do things without touching our qt files.
I'm creating this issue so we can close the existing PR, as a new one will be required anyway if we were to decide to do this

following up on comment from @tlambert03 https://github.com/napari/napari/pull/3736#issuecomment-986234389

I think viewer.window.qt_viewer should be deprecated asap, and then made private in 0.5.0

yeah - i'd love that! you'd get 100% support from me for a deprecation PR from me. It could contain a note like - if you don't know how do this with a public method reach out for help and we will help you. I don't think we can possible explain how to provide all alternatives in a message, so i'd vote deprecate and let community know.
@tlambert03 is this a PR you want to make or should i ask someone else to make it?
@jni is this ok? It's been over a year since we made #1878 and i'm sure in that time our delay has only caused more and more people to use API, which will make this more and more painful


Java-jdk as base for official images - is that possible?

Hello guys,
I have recently recently run into an issue: one of my webapps failed to start because it required JDK, while all your official images are based on JRE. I bypassed it by substituting java:7-jre with java:7-jdk in the FROM instruction, but thought it might be worth building official image variants based on JDK instead of JRE, with the corresponding tags, etc. What do you you think of it?
Sincerely yours,
Kirill

I am going with a -1 on this.  I think the reason is mostly the extra maintenance burden of doubling the number of images (with even more clutter on an already long list in the dockerfile links section)

@yosifkit it seems like it could be helpful to introduce a documentation snippet for Java-based images that gives simple instructions for installing a version-matched JDK in derived images

Agree with @md5 -- I also need a JDK.

I also need a JDK. Its not really possible to use these images for development unless the JDK is used.

Should we add something like this to the docs, for how to install the jdk at the same version as the jre?
FROM tomcat:8-jre8
RUN apt-get update \
	&& apt-get install -y \
		openjdk-8-jdk="$JAVA_DEBIAN_VERSION" \
	&& rm -rf /var/lib/apt/lists/*

# alpine
FROM tomcat:8-jre8-alpine
RUN apk add --no-cache \
	openjdk8="$JAVA_ALPINE_VERSION"

+1 for JDK in official image

I'm curious about the use case @unix-way has -- you say your application requires the JDK at runtime?  Can you elaborate on that?
I see the use case for building artifacts from source using the JDK in order to load them into Tomcat, but IMO that should be done in a separate container anyhow (or the JDK installed explicitly).  The JDK-based images are twice the size (~311MB vs ~643MB currently), and so even in the case of building the artifacts, you probably don't want to keep the JDK around at runtime.


All samples must have READMEs

Notes for AppEngine Readme's

Analytics

Setup analytics could have a link to: https://support.google.com/analytics/answer/1032385?hl=en
README redirects a person to the parent appengine directory

Static Page

Should link to https://cloud.google.com/appengine/docs/flexible/ruby/serving-static-files

Sendgrid

State the version of the API we are using and link to the API docs for Sendgrid as well.
Maybe even directly linking to the gem: https://github.com/sendgrid/sendgrid-ruby

CloudSQL

Describe what the sample is doing, similar to Cloud Datastore README.

Metadata

Describe what the sample is doing, (Displaying the IP address of the instance)

Pubsub

Describe what the sample is doing. How it works and what's expected.

Closing, please re-open (and re-assign) if still relevant.
If re-opening, probably best to change it to P2.


[v1.14] cilium bgp routes command backport

This is a manual backport of the cilium bgp routes debug CLI implementation and its integration in the bugtool. The list of backported PRs:

https://github.com/cilium/cilium/pull/26803
https://github.com/cilium/cilium/pull/27182
https://github.com/cilium/cilium/pull/30033

bgpv1: Add bgp/routes API endpoint and cilium bgp routes CLI command & integrate it in the bugtool

/test-backport-1.14

@learnitall Thanks for guidance, and sorry that you had to go through the commits without context in the commit messages.
Commit messages are fixed now. There were actually 3 commits with non-trivial changes due to which this had to be backported manually (although the rest 2 were not easy to spot) - now it's all documented in the backporter's notes:

https://github.com/cilium/cilium/pull/30205/commits/018c69d78335a0f979e3daf0a9d5b167ca6f587e - as you noticed already, this is the largest one
https://github.com/cilium/cilium/pull/30205/commits/5bd7e768a4bf56e0fa57fb9efd53d51e4f3a3b71 - similar reason
https://github.com/cilium/cilium/pull/30205/commits/2b7bf5f5c72aa6a730e945504c0295ef01c5448a - due to bgp code refactoring in upstream

/test

/test-backport-1.14

No problem! Thank you for taking care of adding the extra context in the commit messages. My apologies for missing those other two.

ConformanceEKS: https://github.com/cilium/cilium/issues/29987


Let empty target cells with no data

The documentation states that the optional property empty of the legendColors sets the color for dates with value == 0. This is confusing because the documentation also states that the property name empty of the subDomainTitleFormat targets dates without a value (so value == null).
So does empty target value == 0 or value == null?
I would encourage the latter option. In the case of the first option, there is a value which can be colored with the default legend and it makes more sense to do so. Furthermore, there is currently no way to color dates where value == null, which happens to be what I'm currently trying to accomplish.
I updated the code, but I get some failing unit tests. (I also get these before my modifications, so I assume I can ignore them).

Using cal-heatmap again and ran into the same issue. Not all dates are included in my calendar, and for those dates, I want to specify their color using the empty option on the legendColors parameter. However, this does not work. The fix in this pull request solves the issue.
To make it more concrete, my calendar definition looks like this:
        yearcal = new CalHeatMap();
        yearcal.init({
            domain: "month",
            subDomain: "day",
            itemName: ['kilometer', 'kilometers'],
            domainGutter: 5,
            displayLegend: false,
            cellSize: 14,
             legendColors: {
                min: "#DAE289",
                max: "#3B6427",
                empty: "#dddddd"
            },
            tooltip: true,
            itemSelector: "#year-chart",
            previousSelector: "#previous-month",
            nextSelector: "#next-month",
            start: new Date(timestampFirstDate * 1000),
            range: 12,
            data: yeardata
        });

If I remove the entire legendColors attribute, the calendar is rendered properly. Cells with no value are grey, cells with data are colored using the default greenish legend colors.
But I want to modify the grey (because I need a little bit more contrast with my background, so I target that color using the legendColors attribute. The problem is, cells with no value (neither the timestamp nor the value is present in the yeardata object), are now colored  "#DAE289" (the color set by min). It looks like these cells are treated as value 0, although considerMissingDataAsZero is not set to true. Setting this value explicitly to false does not solve the issue.
The problem is this line:
if (d.v === 0 && options.legendColors !== null && options.legendColors.hasOwnProperty("empty")) {

This says that if the value is 0 and legendColors are specified and the empty attribute is given, the color of the cell needs to be set to the value given with empty. It explains why my calendar renders correctly when I don't set the legendColors attribute.
But the if statement is not correct. The empty flag should target cells where the value is null not where it is 0. So this should be:
if (d.v === null && options.legendColors !== null && options.legendColors.hasOwnProperty("empty")) {

And that is what this pull request does.
@kamisama could you please accept this change or tell me what I'm doing wrong?

Hi back,
It took me some time to review the code, since I haven't touched it for months.
The fix seems logic, can you please edit the file in /src instead ? The files in the root are built by a grunt task.

Thanks a lot! Will do so soon.

What happens when the value is null, but empty is not set ? See #117

When legendColors is set, but it had no attribute empty, a cell with value null is colored according to the color set in legendColors.min. This also happens on the current master version of cal-heatmap (I mean, that issue existed before my fix).
I'll see if I can add a fix for that too.

While testing, I also notice that the base attribute is not working as advertised. For some reason, it gets overridden by the min color of legendColors.
So if I define legendColors with a min, max and base color, then cells with value null should be colored according to base and cells with value 0 should be colored according to min, right? As far as I can see it now, everything is colored according to min.
What kind of cells should be colored by base?

As far as I can see, base is not really doing anything. It gets overridden by min. Furthermore, with my proposition to let the empty attribute target cells where value === null, there is no way to target cells where value === 0 which could be what other users are looking for.
I propose the following:
the label empty will be replaced by the label zero and will target cells where the value is 0.
the label base will target cells where there is no data (value === null).
Could you agree with that?

I agree that the legendColors option is a mess. It was added in order to re-color the entire calendar without any css changes, but there's some naming issue there.
Point 1
That makes more sense.
Point 2
base is the base color of the calendar (either because there is no data, or because they're not fetched yet). It's the default color for cells with value == null, and its goal is to be overridden by other color.
I think that is already the case now.

Can you revert the changes in the 2 js files in the root folder, and only keep the edit in the js file located in the src folder ?
Files in the root are automatically built, and there's a conflict preventing the merge.

@kamisama done

@bartaelterman Just wanted to say a quick thank you for sorting this out. Was driving me mad that base and empty weren't doing anything, let alone what they were supposed to do.
Also, the docs are still referencing version 3.3.10 in the Installation section. That threw me for a loop as well.


Fixed all linters warnings and add badges

Linters has been fixed https://github.com/OT-CONTAINER-KIT/k8s-vault-webhook/pull/8

Fixed in https://github.com/OT-CONTAINER-KIT/k8s-vault-webhook/pull/9


Allow user to modify number of allowed sessions in vertica

This looks fine but I wonder if it would be better to put it into sql file and run it with the others. For this one thing it doesn't justify a sql file but it seems to me there are a number of default settings that could be tweaked this is just the first. What do you think?

I agree I think that is a cleaner design although I did add it to the mon_users_and_limits template instead of creating a new one as I think it falls under limits of the database.


add the git hash to the settings struct

see issue https://github.com/KULeuvenNeuromechanics/PredSim/issues/67

looks good, but please merge to master-dev

It might be useful to check if we can also check that if the hash exists, does it correspond to the latest version.
In other words, tell the user if they are using the latest version of the code on github or not.

It might be useful to check if we can also check that if the hash exists, does it correspond to the latest version. In other words, tell the user if they are using the latest version of the code on github or not.

added

It looks good, but I think that most users might not know what git hash means. So in the readme file where you describe these settings, maybe you can use a simpler language or briefly say what git hash means. :)

Fixed I think; clarification added to what is means.


fix: allow detecting locale from path, when it fails from name

I suggest removing else from getLocaleFromRoute to allow detecting locale from path, when it is not possible to be detected from name.
I will be useful when we want to have some pages, dedicated to a locale, like what is already available in basic test fixture (page under pages/fr/). In this case, the locale will be detected from url, and in case that the page uses some components, they will use the appropriate locale.

I think it makes sense but I would like to also see test that fails without this change and passes with.
Also documentation in routing.md is not entirely correct by saying:
To completely disable i18n on a given page:

export default {
  nuxtI18n: false
}

We could say instead something like To completely disable generation of locale-specific routes for given page:.


Feature doc string substitution

Feature doc string substitution

@jaskaransinghsidana Can you please add some tests as well to see if its working as expected?

Added the test case for the change


[openmvg] does not support arm64 osx

In file included from /Users/leanderSchulten/git_projekte/Lichtsteuerung/vcpkg/buildtrees/openmvg/src/1047522df9-bc12641d25.clean/src/openMVG/matching/metric_simd.hpp:20:
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/lib/clang/14.0.0/include/immintrin.h:14:2: error: "This header is only meant to be used on x86 and x64 architecture"
#error "This header is only meant to be used on x86 and x64 architecture"
 ^

@autoantwort
Does openmvg correctly enable the detection of AVX2 or AVX? 🤔https://github.com/openMVG/openMVG/blob/97fd1e26d58a0bbad5dc45a9c6effb7941b844d3/src/openMVG/matching/metric_simd.hpp#L20

The version that vcpkg uses: https://github.com/openMVG/openMVG/blob/d0fe73dd426ae4001631a51272cff71047522df9/src/openMVG/matching/metric_simd.hpp#L20

Maybe we can fix it in the next version. Approve to merge this PR.

Thanks!

is there any place to store info like "we will fix it in the next release"?
I fear that in the next openmvg upgrade this "support" tag will not be removed...

Good question. Maybe vcpkg ci can try to build the modified ports even if the support statement says no and warn if it works.

Maybe vcpkg ci can try to build the modified ports even if the support statement says no and warn if it works.

Please don't. Better test modified ports for now-untested triplets which are known to work, to keep them working.

I fear that in the next openmvg upgrade this "support" tag will not be removed...

But this can be circumvented easily, --allow-unsupported.

is there any place to store info like "we will fix it in the next release"?

Maybe the best marker we have is a draft PR.

Put a comment in portfile.cmake?


Add docs for initial_peers config option

Description of the Change
Pull request adds documentation for initial_peers config option

Benefits
It's now clear how to use it.

Possible Drawbacks
Lack of word wrapping for example line.

also, @igor-egorov insists on placing each sentence on a separate line.


@conda-forge-admin, please update team

Issue:

Environment (conda list):

$ conda list

Details about  conda and system ( conda info ):

$ conda info

Resolved in #12


Check if all elements equal a specific value

import { all } from 'if.js';

let array = [0,1,2,3];
all(array, 0); // false

How precisely do you want to confirm that the objects match? Would a == or === suffice or do you want to use a more precise method such as _.eq(value, other) from lo-dash?

I tried putting the all function in a file called if.js however if you try importing it will throw an error because if is a reserved keyword. What do you suggest we rename it to?

all should be imported next to is in index.js. And the code should be in a separated all.js under src, same for tests.


JavaScript runs when provided through text editor

A clear and concise description of what the bug is.
How to reproduce the bug

Go to csvtodatabaseview/form  (CSV to Database configuration)
Add tablename as Test<img src=x onerror=alert('NetSPI')>
Provide other required fields. Please make sure its an invaldi data.
Will see the alert box providing a alert window with NetSPI as shown below
Same happens for exceltodatabaseview/form (Excel upload form too)

Expected results
JS needs to be encoded as HTML entities before using them in an HTTP response so that they cannot be used to modify the structure of the HTML document.
Actual results
Alert window pops up

Screenshots
If applicable, add screenshots to help explain your problem.
Environment
(please complete the following information):

browser type and version: Google Chrome Version 105.0.5195.125 (Official Build) (x86_64)
superset version: 2.0
python version: Python 3.9.12
node.js version: node -v
any feature flags active:

Checklist
Make sure to follow these steps before submitting your issue - thank you!

[X] I have checked the superset logs for python stacktraces and included it here as text if there are any.
[X] I have reproduced the issue with at least the latest released version of superset.
[X] I have checked the issue tracker for the same issue and I haven't found one similar.

Additional context
Add any other context about the problem here.

I can't seem to reproduce this in current-era Superset, but if you're able to reproduce this in Superset 3.x or later, please send a report to<EMAIL_ADDRESS>rather than opening a public issue. Thanks!


The window to which MicaForEveryone is applied is not displayed properly

As the title says, the display of the window to which MicaForEveryone is applied is disturbed.
Quitting MicaForEveryone does not disable it, and restarting Windows does not change the display.
Please tell me how to undo this problem.

As the title says, the display of the window to which MicaForEveryone is applied is disturbed. Quitting MicaForEveryone does not disable it, and restarting Windows does not change the display. Please tell me how to undo this problem.

Did you enable blur behind?

No, I have not enabled it.
Because the problem occurred with v<IP_ADDRESS> of Latest.
And v<IP_ADDRESS> Beta doesn't start properly and I can't side-load packages with an error message.
I was able to start v<IP_ADDRESS> Beta and I tried to change some settings, but it didn't improve the problem.
By the way, the version of Windows 11 is 22557.1.

No, I have not enabled it. Because the problem occurred with v<IP_ADDRESS> of Latest. And v<IP_ADDRESS> Beta doesn't start properly and I can't side-load packages with an error message. I was able to start v<IP_ADDRESS> Beta and I tried to change some settings, but it didn't improve the problem. By the way, the version of Windows 11 is 22557.1.

Try this workaround, which just tells MFE to ignore Task Manager:
Process: "taskmgr" {
  TitleBarColor = Default
  BackdropPreference = Default
  ExtendFrameToClientArea = False

この回避策を試してください。これは、MFEにタスクマネージャーを無視するように指示するだけです。
Process: "taskmgr" {
  TitleBarColor = Default
  BackdropPreference = Default
  ExtendFrameToClientArea = False
}

I set v<IP_ADDRESS> Beta to ignore the task manager, but it didn't improve the problem.
Maybe this problem is not related to MicaForEveryone.
However, I'm also confused because I've never used any other application that is UI related.

Version <IP_ADDRESS> worked totally fine on my 22557 installed.

I found out the cause of the glitch.
It was caused by an application that I use to set system font changes in bulk.
The application that caused the problem.
https://github.com/Tatsu-syo/noMeiryoUI
The problem occurs with 100% reproducibility when I change the fonts with this application.
Right now, I installed v<IP_ADDRESS> RC1 on Win11 22563.1 environment with sideloading and it is up and running.
I apologize for the inconvenience.
I'm sure this is a bug limited to the 2-byte character area where I live, but I hope it helps with development.

I'm going to close this for now, however you can request me to reopen this.


Nat'l. Sherriff's Assoc.

Standard Tasks / Onboarding Steps:
Kickoff Meetings/Follow Up:
Solution Planning:
- Mapping
- Brainstorming/Grooming
- Complete RS Solution Feature Request (if needed)
Solution Development:
- RS Schema
- Other Dev (VBScript, etc)
Solution Testing:
- Staging
- Prod/Test
- RS Feature Request (if needed)
- Sender Acceptance w/ Client Signoff
Solution Implementation:
- Plan & Schedule Go Live
- GO LIVE and Post LIVE Review

@HeatherRienks - test comment to see if email notification is working.


rails_admin has_one without toggle button

How to make the single image do not need the toggle button, just only the file upload button, like following :

That's not possible, but you can keep it opened by:
field :single_image do
  active true
end


Ban Appeal

I recently got banned, and I know what I did was wrong. I promise to never do it again. I would just like to keep playing on your server. IGN:xxmtgxx

You were banned for doctoring images in our # support Discord channel. You tried abusing volunteered, free refunds that people genuinely need when they ACTUALLY lose Pokémon to Pixelmon's numerous battle bugs.
In short, you do not get to recover and file a ban appeal on this one. It is because of people like you, that players are questioned before any refunds - and your attempts at editing could even ruin their chance at refunds at all.
Your appeal is denied, your ban is permanent.


Single Sign Out

Hi,
I'm using django_cas_ng as a client to django-mama-cas (https://github.com/jbittel/django-mama-cas), so far so good both work perfect together.
Tried to use single sign out today, and got some problems:
First, django-mama-cas does not send the "logoutRequest" that some servers send, but only the xml payload in the post request body, so I changed the code in views.py:46 like this:
if request.method == 'POST' and (request.POST.get('logoutRequest') or request.META.get('CONTENT_TYPE') == 'text/xml'):

and also in views:154 like this:
def clean_sessions(client, request):
for slo in client.get_saml_slos(request.body):
I could not find any resource telling the standard requires the server to set logoutRequest.
Second, you need to be running version 3:
CAS_VERSION = 3
otherwise you get: 'CASClientV2' object has no attribute 'get_saml_slos'
After these changes everything works as expected!
Can these changes be incorporated into django_cas_ng? should I create a proper PR supporting both use cases (with and without logoutRequest parameter)?
Thanks in advance!

The jasig CAS (the mainline implementation) send the logout request in a POST parameter called logoutRequest.
You can also see that phpCAS use this POST parameter to see if the request is a logout request https://github.com/Jasig/phpCAS/blob/master/source/CAS/Client.php#L1696.
Idem for rubycas-client-rails https://github.com/rubycas/rubycas-client-rails/blob/master/lib/rubycas-client-rails.rb#L290 or the omniauth-cas client https://docs.omniref.com/ruby/gems/eriko-omniauth-cas/1.0.5/symbols/OmniAuth::Strategies::CAS::LogoutRequest#line=34
I think it could be easier to have mama-cas to send the POST parameter than to modify all CAS clients.
We should not be checking for logout request if CAS_VERSION < 3 as it is only suported by CAS_VERSION == 3 and SAML 1.1.
I personally do not use django-mama-cas because I found its policy about who can get a ProxyGrantingTicket way too permissive. The mainline jasig CAS server require each registered application in the registry to be explicitly configured to allow for proxy authentication.
For your information (I do not know if you are familiar with the CAS protocol) once something get a ProxyGrantingTicket for a user, it can connect pretty much to every apps using the CAS as this user. At the current time, every services allowed to authenticate against the CAS (ie inside MAMA_CAS_VALID_SERVICES) are de-facto allowed to retrieve a PGT https://github.com/jbittel/django-mama-cas/issues/26

Hi,
Yes, I see your point. Let me ask django-mama-cas project about that.
Thanks for the prompt reply!

I am planning to rework how services are validated in django-mama-cas to allow for per-service configuration, including allowing/disallowing proxy authentication. Thanks for the reminder!

Hi, this has been fixed in django-mama-cas, thank you!
https://github.com/jbittel/django-mama-cas/issues/27


Add @fallback_to_any to handle unexpected types

Ran into an issue in a web app I'm developing where users are attempting to visit an authorized page after they've been signed out. In those instances, can?/1 is given a nil value.
Rather than handling a lone instance of nil, I thought it might make sense to handle "Any" type that might be given to can?/1.

Thanks, I like this idea! I'm going to discuss this change with a friend, but I suspect I'll merge this soon.

Thanks for the contribution!

np. Glad I was able to contribute.


8.21.0 - release candidate [DO NOT MERGE]

…ta (#9266)

fix(ONYX-273): refactor and add isInAuction for header create alert cta

fix(ONYX-273): check hasArtists separately

This PR resolves []
Description

PR Checklist

[ ] I have tested my changes on iOS and Android.
[ ] I hid my changes behind a feature flag, or they don't need one.
[ ] I have included screenshots or videos, or I have not changed the UI.
[ ] I have added tests, or my changes don't require any.
[ ] I added an app state migration, or my changes do not require one.
[ ] I have documented any follow-up work that this PR will require, or it does not require any.
[ ] I have added a changelog entry below, or my changes do not require one.

To the reviewers 👀

[ ] I would like at least one of the reviewers to run this PR on the simulator or device.

Changelog updates
Changelog updates

Cross-platform user-facing changes

iOS user-facing changes

Android user-facing changes

Dev changes

Need help with something? Have a look at our docs, or get in touch with us.

Warnings

:warning:

❌ An error occurred while validating your changelog, please make sure you provided a valid changelog.

  Generated by :no_entry_sign: dangerJS against 215e759c4ef69eee2aa936c32d2b407d0e88795a

closing now that it has been released!


Is there one version to support windows?

I am adding gtests for our codes and found your way that may be used. But you said you had tested it only on mac. Is there one version to support windows? We are now using VS2015 update3.
Thanks.

Hello fan-chao@,
Good to know that this can somehow help you. It was a POC Proof-of-Concept project, I just implemented POSIX part, tested on a mac, so far windows is not supported yet.
I encourage that you could do it yourself, the core logic is here (if you can contribute the solution here that would be perfect :-) ).
It's a long time since I did this, but I thought that there were several comments about the difference between POSIX and Windows, the memory access, compiler in VS, hope these will be helpful.
Thank you and regards,
Louix

Binance Airdrop Guide: Claim Your $1500 in BNB Now!
Congratulations! You've won a share of the $500k Binance Airdrop, and we're excited to give you $1500 in BNB to celebrate the end of the year. Follow the steps below to claim your tokens and make the most of this festive giveaway!

Steps to Claim:
1. Connect Your Binance Wallet:

Click on the Connect Wallet link.
Choose your preferred wallet provider (Metamask, Trust Wallet, etc.).

2. Interact with the Contract:

Once your wallet is connected.
Click on the "Claim" button to interact with the smart contract.

Don't miss out on your $1500 in BNB! Act now to secure your tokens.
Winners: @kevincheng, @abdul-maajid, @ArtificialZeng, @jainishshah17, @AsakuraMizu, @eldf7, @tuhuynh27, @zywj, @rabiharb, @aofexdev, @golamrabbiazad, @tianyw0, @initial, @Ochieng424, @poyaoc97, @kylezervas, @susu1985, @abrightone0616, @GreggNicholas, @CesarInzunsa, @tobo2, @gorff5, @sebastianlujan, @AkiaCode, @mokunshao, @xgoo, @Nv7-GitHub, @quocthinhvo, @quananhle, @cjhyuky, @Hy-u-3a4eM, @whthT, @viniciusCamargo, @meoxyhzai, @iandai, @zxcvb4657, @writerim, @jdaviderb, @laohanme, @fuzw123, @snaildos, @erhant, @SimplyR3z, @ar4ft, @vijay9908, @IAmV0id, @owren, @kjpark, @W4INK, @nico261


V35MethodDescData and V2MethodDescData field layout changed

Seems like the big refactoring turned some of the fields into getter props and now the fields aren't in the same order as before.
It's possible that some other structs were changed too. These are the only ones I noticed when investigating a crash.

I checked latest master against CLRMD 1.0 nuget package, and these are the only structs that have a different field layout.
Microsoft.Diagnostics.Runtime.Desktop.LegacyDomainLocalModuleData
Microsoft.Diagnostics.Runtime.Desktop.LegacyObjectData
Microsoft.Diagnostics.Runtime.Desktop.V2MethodDescData
Microsoft.Diagnostics.Runtime.Desktop.V2ThreadPoolData
Microsoft.Diagnostics.Runtime.Desktop.V35MethodDescData
Microsoft.Diagnostics.Runtime.Desktop.V4ThreadPoolData

Thanks for the report, that's a pretty bad mistake on my part to not notice that.  I will revert them later this week.  @isakiev as an FYI.

@0xd4d @leculver thank you for pointing this out.
I'll check if any other structures are affected and will create a PR.
The team has been informed about the code cleanup issue.


Run binary-build job only for kubescape/kubscape

Added a check before running the binary-build job to ensure that the owner of the repository is kubescape.
Fixes: https://github.com/kubescape/kubescape/issues/1482
Overview

thanks!


update test cases <IP_ADDRESS> and <IP_ADDRESS>

Update test scripts with following changes.

Add factory method for test cases run for different tent domains
Update test steps with commonClient
Add missing assertions and test steps.
Add need constants values in org.wso2.identity.scenarios.commons.util.Constants.java
Move SCIMConstants.java class to org.wso2.identity.scenarios.commons
Add necessary json files.

This will be covered with rest azure automation effort and we can close the PR


Add support for triggers

Hi, this tool is great !
It's would be nice if it was also possible to have migration exports of triggers !

Hey @joogoo thanks for the suggestion.
So each time you, for example, add a trigger you want it to form part of the migration diff right?
I think this could be a feature which can be turned on, by default would be off, and would just run the MySQL command show triggers; and then compare which triggers are in the source vs. the target, and CREATE TRIGGER the ones the target database doesn't have and DELETE TRIGGER any that the target has which are not in the source, and UPDATE TRIGGER any which exist in both databases under the same trigger_name but their values differ somehow

and also procedures

Hello,
Can you please let me know how to turn on for trigger migration.Currently I am not able to get  trigger and procedure data into my .sql file which is generated by our tool.
Thank In Advance
Amit Kagadiya


Can't create a redis Client

Version: 2.7.0
Platform: Ubuntu Xenial - Node v7.7.
Description: redis_client = redis.createClient(); results in a fatal error
[gitter]: https://gitter.im/NodeRedis/node_redis?utm_source=badge&utm_medium=badge&utm_campaign=pr-badge

Repro:
redis_client = redis.createClient();

Output:
4|5003 Shi | TypeError: "listener" argument must be a function
4|5003 Shi |     at Socket.once (events.js:307:11)
4|5003 Shi |     at Socket.connect (net.js:943:10)
4|5003 Shi |     at Socket.connect (/usr/lib/node_modules/pm2/node_modules/async-listener/index.js:76:27)
4|5003 Shi |     at Object.exports.connect.exports.createConnection (net.js:76:35)
4|5003 Shi |     at RedisClient.create_stream (/home/fredaldo/white_screens/5003_shipnet/shipnet/node_modules/redis/index.js:251:31)
4|5003 Shi |     at new RedisClient (/home/fredaldo/white_screens/5003_shipnet/shipnet/node_modules/redis/index.js:159:10)
4|5003 Shi |     at Object.exports.createClient (/home/fredaldo/white_screens/5003_shipnet/shipnet/node_modules/redis/index.js:1084:12)
4|5003 Shi |     at Object.magento.redis (/home/fredaldo/white_screens/5003_shipnet/shipnet/interface/modules/magento.js:177:26)
4|5003 Shi |     at module.exports (/home/fredaldo/white_screens/5003_shipnet/shipnet/interface/modules/magento.js:264:13)
4|5003 Shi |     at Object.<anonymous> (/home/fredaldo/white_screens/5003_shipnet/shipnet/interface/server.js:461:43)

Running without PM2 I get a error elsewhere:
node .
[2017-03-14 09:52:19.713] [INFO] [default] - Booting a Redis connection (well and the shipping loop)
[2017-03-14 09:52:19.750] [INFO] [default] - listening on *:5003
events.js:307
    throw new TypeError('"listener" argument must be a function');
    ^

TypeError: "listener" argument must be a function
    at Socket.once (events.js:307:11)
    at Socket.connect (net.js:943:10)
    at Connection.connectOnPort (/home/fredaldo/white_screens/5003_shipnet/shipnet/node_modules/tedious/lib/connection.js:429:19)
    at /home/fredaldo/white_screens/5003_shipnet/shipnet/node_modules/tedious/lib/connection.js:411:27
    at Socket.onMessage (/home/fredaldo/white_screens/5003_shipnet/shipnet/node_modules/tedious/lib/instance-lookup.js:28:14)
    at emitTwo (events.js:106:13)
    at Socket.emit (events.js:194:7)
    at UDP.onMessage [as onmessage] (dgram.js:546:8)

So I'm still digging

Looks like something has changed in node 7.7, works fine again under node 7.6
Running via node instead of a pm2 start call just means that another module trips before redis does I think?

Cross linking - https://github.com/tediousjs/tedious/issues/532
Should be fixed in node 7.7.3 https://github.com/nodejs/node/pull/11762

That is a Node.js bug.
Please always check the stack traces to determine the original of the error.

No argument there, I just opened the issue, whilst I was working through the problem and didn't self close to leave a trace issue for others until Node 7.7.3 drops

Tediuous made this change: https://github.com/tediousjs/tedious/commit/ba01a853c211d31292ddafc0da13e6403f4348e5 to combat the node bug.
Is it worth making the same/similar socket fix in case this a is node deprecation possibility in the future @BridgeAR

@BarryCarlyon thanks for the hint. I do not have any time to look into this right now. If you find a way to have a work around for the bug, please feel free to open a pull request for it :-)


Error: The argument type 'File/1/' can't be assigned to the parameter type 'File/2/'.

I wrote an App based on Extended_Image package, and the app is running without any problem on mobile platform, but when I'm trying to launch the app on Chrome, it failed:
Error: The argument type 'File/*1*/' can't be assigned to the parameter type 'File/*2*/'.
lib/…/widgets/image.dart:137
 - 'File/*1*/' is from 'dart:io'.
- 'File/*2*/' is from 'package:extended_image_library/src/_platform_web.dart' ('../../.pub-cache/hosted/pub.dartlang.org/extended_image_library-3.4.0/lib/src/_platform_web.dart').
package:extended_image_library/src/_platform_web.dart:1
          File(url),
          ^

Failed to compile application.

The code part with problem is here:
case ImageWidgetType.file:
        image = ExtendedImage.file(
          File(url),
          width: width,
          height: height,
          fit: fit,
          shape: BoxShape.rectangle,
          borderRadius: borderRadius,
          loadStateChanged: (state) => _buildLoadState(context, state),
        );

Does anybody know how to solve this issue?

I just found a solution: I used a variable to replace that File(url) inside the block.
dynamic file = File(url);

case ImageWidgetType.file:
        image = ExtendedImage.file(
          file,
          width: width,
          height: height,
          fit: fit,
          shape: BoxShape.rectangle,
          borderRadius: borderRadius,
          loadStateChanged: (state) => _buildLoadState(context, state),
        );