fix: Disable enable_expand_distinct_optimization by default

Changelog category :

Bug Fix

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
disable enable_expand_distinct_optimization by default, it has bug now. Workround for  #1701

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.7 out of 8 committers have signed the CLA.:white_check_mark: jay-bytedance:white_check_mark: fanqi1909:white_check_mark: FourSpaces:white_check_mark: Alima777:white_check_mark: frankye1982:white_check_mark: ArthurZou:white_check_mark: nudles:x: smmsmm1988FourSpaces seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


Add support for IMDSv2 for AWS instance metadata calls

Title: Add support for IMDSv2 for AWS instance metadata calls
Description:
Currently the AWS credentials provider uses IMDSv1 (a request/response method) but IMDSv2 (a session-oriented method) is substantially more secure, as it prevents SSRF attacks on the metadata service.
Relevant Links:
https://docs.aws.amazon.com/AWSEC2/latest/UserGuide/configuring-instance-metadata-service.html
cc @JuniorHsu @PeterL328 @fishcakez

/assign

We would like to address this post https://github.com/envoyproxy/envoy/issues/11816 (starting Jan 23) to remove libcurl. Let us know if that timeline sounds ok.
We have the code change that does IMDSv2 using curl, but not upstream that change yet since libcurl is planned to be deprecated soon.
Please feel free to ping me on Envoy slack (suniltheta@) for further clarifications.

thanks @suniltheta that works for me

Hi @mattklein123, happy new year! I am still working on removing libcurl usage. Got the http async client change to work with lambda & request signing filter extensions but I am blocked on the final part to get that change work with IAM gRPC plugin, which I am going to work on next.
Meanwhile, I though it is better to get this IMDSv2 support https://github.com/envoyproxy/envoy/pull/24747 since this is a security feature and the change to remove libcurl might take some time to stabilize and be bug free.
I would like to get your review on the above PR. Thanks.


Graceful handling of UPID errors

Occasionally I encounter SCTE-35 streams where only the UPID is invalid, for example this one:
0xFC305E00000000000000FFF00506FE7E9252100048020F435545490001881F7FBF0C000100000217435545490004955E7FBF0808000000F846189FE7310101021C435545490004955F7FFF00001F41900808000000F786E70D7F3001019C96C30E

This currently leads to data loss, even though the other descriptors are valid and contain useful data.
With this PR I propose to add length checks to each UPID parser function. Exceptions are handled by default, resulting in an empty segmentation_upid object when a length check fails. I think that this default is reasonable for normal use. If instead you want to let the exceptions propagate, do this:
threefive.upids.ignore_parse_errors = False

Some other fields are allowed to be empty, these are returned as empty strings without raising an exception.

I have to think on this one, and check all the upids types,
they sure have made upids overly complicated.
I really really really try to avoid throwing exceptions, in most cases I need the code to keep going even if there is a problem with something.
I have to think on this one, but I am sure we can come up with something agreeable to both of us.
My brain has trouble parsing this syntax,  I dont know why, its very similar to comprehensions.
        required_length = 12 if self.upid_type == 0x06 else 8

Have you seen it like this?
(8,12)[self.upid_type==0x06]

Which is even more confusing....

No I had never seen this before and I agree that it is confusing:
(8,12)[self.upid_type==0x06]

I am more used to the C/C++/PHP ternary operator:
required_length = upid_type == 0x06? 12:8

However I like the Python syntax more because it makes sense if you say it out loud:
  required_length = 12 if self.upid_type == 0x06 else 8
# required_length becomes 12 if self.upid_type equals 0x06, otherwise 8

The exceptions that are raised in the UpidDecoder class are handled there so everything will continue to run. Some examples below:
This is with this PR using default settings and the zero length UPID:
richard@M1-Richard richard-SCTE35-threefive % git checkout upid-length-20221026
Switched to branch 'upid-length-20221026'
Your branch is up to date with 'origin/upid-length-20221026'.
richard@M1-Richard richard-SCTE35-threefive % python3
Python 3.9.6 (default, Sep 13 2022, 22:03:16)
[Clang 14.0.0 (clang-14<IP_ADDRESS>)] on darwin
Type "help", "copyright", "credits" or "license" for more information.
>>> import threefive
>>> cue = threefive.cue.Cue("0xFC305E00000000000000FFF00506FE7E9252100048020F435545490001881F7FBF0C000100000217435545490004955E7FBF0808000000F846189FE7310101021C435545490004955F7FFF00001F41900808000000F786E70D7F3001019C96C30E")
>>> cue.decode()
True
>>> cue.show()
{
    "info_section": {
        "table_id": "0xfc",
        "section_syntax_indicator": false,
        "private": false,
        "sap_type": "0x3",
        "sap_details": "No Sap Type",
        "section_length": 94,
        "protocol_version": 0,
        "encrypted_packet": false,
        "encryption_algorithm": 0,
        "pts_adjustment_ticks": 0,
        "pts_adjustment": 0.0,
        "cw_index": "0x0",
        "tier": "0xfff",
        "splice_command_length": 5,
        "splice_command_type": 6,
        "descriptor_loop_length": 72,
        "crc": "0x9c96c30e"
    },
    "command": {
        "command_length": 5,
        "command_type": 6,
        "name": "Time Signal",
        "time_specified_flag": true,
        "pts_time": 23594.649778,
        "pts_time_ticks":<PHONE_NUMBER>
    },
    "descriptors": [
        {
            "tag": 2,
            "descriptor_length": 15,
            "name": "Segmentation Descriptor",
            "identifier": "CUEI",
            "components": [],
            "segmentation_event_id": "0x1881f",
            "segmentation_event_cancel_indicator": false,
            "program_segmentation_flag": true,
            "segmentation_duration_flag": false,
            "delivery_not_restricted_flag": true,
            "segmentation_message": "Content Identification",
            "segmentation_upid_type": 12,
            "segmentation_upid_type_name": "MPU",
            "segmentation_upid_length": 0,
            "segmentation_upid": {},
            "segmentation_type_id": 1,
            "segment_num": 0,
            "segments_expected": 0
        },
        {
            "tag": 2,
            "descriptor_length": 23,
            "name": "Segmentation Descriptor",
            "identifier": "CUEI",
            "components": [],
            "segmentation_event_id": "0x4955e",
            "segmentation_event_cancel_indicator": false,
            "program_segmentation_flag": true,
            "segmentation_duration_flag": false,
            "delivery_not_restricted_flag": true,
            "segmentation_message": "Provider Advertisement End",
            "segmentation_upid_type": 8,
            "segmentation_upid_type_name": "AiringID",
            "segmentation_upid_length": 8,
            "segmentation_upid": "0xf846189fe7",
            "segmentation_type_id": 49,
            "segment_num": 1,
            "segments_expected": 1
        },
        {
            "tag": 2,
            "descriptor_length": 28,
            "name": "Segmentation Descriptor",
            "identifier": "CUEI",
            "components": [],
            "segmentation_event_id": "0x4955f",
            "segmentation_event_cancel_indicator": false,
            "program_segmentation_flag": true,
            "segmentation_duration_flag": true,
            "delivery_not_restricted_flag": true,
            "segmentation_duration": 22.76,
            "segmentation_duration_ticks": 2048400,
            "segmentation_message": "Provider Advertisement Start",
            "segmentation_upid_type": 8,
            "segmentation_upid_type_name": "AiringID",
            "segmentation_upid_length": 8,
            "segmentation_upid": "0xf786e70d7f",
            "segmentation_type_id": 48,
            "segment_num": 1,
            "segments_expected": 1
        }
    ]
}
>>> ^D

Now, here is the same situation but with threefive.upids.ignore_parse_errors = False:
richard@M1-Richard richard-SCTE35-threefive % python3
Python 3.9.6 (default, Sep 13 2022, 22:03:16)
[Clang 14.0.0 (clang-14<IP_ADDRESS>)] on darwin
Type "help", "copyright", "credits" or "license" for more information.
>>> import threefive
>>> threefive.upids.ignore_parse_errors = False
>>> cue = threefive.cue.Cue("0xFC305E00000000000000FFF00506FE7E9252100048020F435545490001881F7FBF0C000100000217435545490004955E7FBF0808000000F846189FE7310101021C435545490004955F7FFF00001F41900808000000F786E70D7F3001019C96C30E")
>>> cue.decode()
Traceback (most recent call last):
  File "/Users/richard/git/richard-SCTE35-threefive/threefive/upids.py", line 129, in decode
    return upid_map[self.upid_type][0], upid_map[self.upid_type][1]()
  File "/Users/richard/git/richard-SCTE35-threefive/threefive/upids.py", line 80, in _decode_mpu
    raise Exception(f"upid_length is {self.upid_length}, should be >= 4 bytes")
Exception: upid_length is 0, should be >= 4 bytes

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/Users/richard/git/richard-SCTE35-threefive/threefive/cue.py", line 72, in decode
    bites = self._mk_descriptors(bites)
  File "/Users/richard/git/richard-SCTE35-threefive/threefive/cue.py", line 160, in _mk_descriptors
    self._descriptor_loop(bites[:dll])
  File "/Users/richard/git/richard-SCTE35-threefive/threefive/cue.py", line 84, in _descriptor_loop
    spliced = splice_descriptor(loop_bites)
  File "/Users/richard/git/richard-SCTE35-threefive/threefive/descriptors.py", line 414, in splice_descriptor
    spliced.decode()
  File "/Users/richard/git/richard-SCTE35-threefive/threefive/descriptors.py", line 278, in decode
    self._decode_segmentation(bitbin)
  File "/Users/richard/git/richard-SCTE35-threefive/threefive/descriptors.py", line 308, in _decode_segmentation
    self.segmentation_upid_type_name, self.segmentation_upid = UpidDecoder(
  File "/Users/richard/git/richard-SCTE35-threefive/threefive/upids.py", line 136, in decode
    raise Exception(f"error parsing {upid_map[self.upid_type][0]}: {str(e)}")
Exception: error parsing MPU: upid_length is 0, should be >= 4 bytes
>>> ^D

For reference, current master just errors out:
richard@M1-Richard richard-SCTE35-threefive % git checkout upstream/master
HEAD is now at d0fc54e Merge pull request #60 from richard-vd/charset-20221026
richard@M1-Richard richard-SCTE35-threefive % python3
Python 3.9.6 (default, Sep 13 2022, 22:03:16)
[Clang 14.0.0 (clang-14<IP_ADDRESS>)] on darwin
Type "help", "copyright", "credits" or "license" for more information.
>>> import threefive
>>> cue = threefive.cue.Cue("0xFC305E00000000000000FFF00506FE7E9252100048020F435545490001881F7FBF0C000100000217435545490004955E7FBF0808000000F846189FE7310101021C435545490004955F7FFF00001F41900808000000F786E70D7F3001019C96C30E")
>>> cue.decode()
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/Users/richard/git/richard-SCTE35-threefive/threefive/cue.py", line 72, in decode
    bites = self._mk_descriptors(bites)
  File "/Users/richard/git/richard-SCTE35-threefive/threefive/cue.py", line 160, in _mk_descriptors
    self._descriptor_loop(bites[:dll])
  File "/Users/richard/git/richard-SCTE35-threefive/threefive/cue.py", line 84, in _descriptor_loop
    spliced = splice_descriptor(loop_bites)
  File "/Users/richard/git/richard-SCTE35-threefive/threefive/descriptors.py", line 414, in splice_descriptor
    spliced.decode()
  File "/Users/richard/git/richard-SCTE35-threefive/threefive/descriptors.py", line 278, in decode
    self._decode_segmentation(bitbin)
  File "/Users/richard/git/richard-SCTE35-threefive/threefive/descriptors.py", line 308, in _decode_segmentation
    self.segmentation_upid_type_name, self.segmentation_upid = UpidDecoder(
  File "/Users/richard/git/richard-SCTE35-threefive/threefive/upids.py", line 114, in decode
    return upid_map[self.upid_type][0], upid_map[self.upid_type][1]()
  File "/Users/richard/git/richard-SCTE35-threefive/threefive/upids.py", line 72, in _decode_mpu
    "private_data": self.bitbin.as_hex(ulbits - 32),
  File "/Users/richard/git/richard-SCTE35-threefive/threefive/bitn.py", line 45, in as_hex
    return hex(self.as_int(num_bits))
  File "/Users/richard/git/richard-SCTE35-threefive/threefive/bitn.py", line 37, in as_int
    return (self.bits >> (self.idx)) & ~(~0 << num_bits)
ValueError: negative shift count
>>> ^D

Why do you have a zero length length UPID?  That makes no sense.
You want to change things to fit a broken situation, fix whatever is doing the encoding,
or encode with threefive and do it correctly.
I understand how the the code works and what it does,
but code like this, is just asking for trouble.
        return self.bitbin.as_hex(self.upid_length << 3) if self.upid_length else ""

This
required_length = 12 if self.upid_type == 0x06 else 8

is the same as
required_length = (8,12)[self.upid_type==0x06]

you have
 if not self.upid_length == 12:

that's another bad idea.
Your code is not wrong,
but try to write code that fits and works like the code that is already there.

I'm not sure I'm explaining this well.
You're setting a contradictory policy.
a zero length  upid error is okay,
but any other length error you want to throw an exception.
I don't like that threefive stops on these errors, but these are substantial errors.
Ideally, threefive would skip the bad UPID and keep going, but that will impact other parts of the segmentation descriptor,
and that would would have to be resolved as well.
You would not have any of these problems if you encoded with threefive :)

I dont see much benefit in adding an exception,
where the code fails. You still get the same stack trace,
and what happened is not really in question anyway.
If you want to do this, here's what you need to do.

add a method to Upid_Decoder class to check upid length.
check the length at the top of  the method instead of throwing the exception at the bottom.
Have the length checking method return a "bad value" message or something if its too short and False if it's long enough
then do something like

bad= self.chk_length(val1,val2)
if bad:
     return bad

at the top of any method that you need to verify the length.

return the bad message instead of the upid if it is not long enough

The bad value message will automatically be returned as the upid to the segmentation descriptor
         "tag": 2,
            "descriptor_length": 28,
            "name": "Segmentation Descriptor",
            "identifier": "CUEI",
            "components": [],
            "segmentation_event_id": "0x4955f",
            "segmentation_event_cancel_indicator": false,
            "program_segmentation_flag": true,
            "segmentation_duration_flag": true,
            "delivery_not_restricted_flag": true,
            "segmentation_duration": 22.76,
            "segmentation_duration_ticks": 2048400,
            "segmentation_message": "Provider Advertisement Start",
            "segmentation_upid_type": 8,
            "segmentation_upid_type_name": "AiringID",
            "segmentation_upid_length": 0,           <---------------------Zero length is bad
            "segmentation_upid": "BAD VALUE",     <------------------ the bad value message
            "segmentation_type_id": 48,
            "segment_num": 1,
            "segments_expected": 1
        }

That solves all of your problems and it keeps threefive from stopping.

Average complexity: A (1.55)

Continued in #61


Remove clFFT and replace with vkFFT

clFFT is buggy and basically unmaintained. Once we migrate the compute backend to Vulkan, we can stop using it.

Done. We've removed all use of OpenCL as of 655bbea.


[TECH-433] Send build result to personal slack channel too

branch: fix/TECH-433-runner-should-also-report-errors-to-individual

📕 TECH-433 Runner should also report errors to individual
Not just to the public slack channel
p1684934653528599
🏗 Build 3 ❌ Failed, started by Sam Theisens
🚀  enrichChargeSessionsJob, job, kong-sync, nodeservice, sbtservice


Support for dynamically created components ?

As far as I am aware, factory collections exist in relm4 to create dynamic view and manage them in various layouts, but the dynamically created widgets can be complicated, so I want to create them into a component and build them with the view! macro. I wonder if it's possible to use factory collection in conjunction with component ?

There's a new concept called MicroComponents in the latest beta releases that could be what you're looking for. They can be created dynamically and in general have less restrictions than regular components.
Yet, the widget macro hasn't been updated to support them, but hopefully I will be able to add this before the next stable release.
Micro components example

There's a new concept called MicroComponents in the latest beta releases that could be what you're looking for. They can be created dynamically and in general have less restrictions than regular components.
Yet, the widget macro hasn't been updated to support them, but hopefully I will be able to add this before the next stable release.
Micro components example

That is exactly what I want, since I found it possible to create MicroComponent dynamically and integrate it into factory collection. Can't wait for the next stable release :)

@BohongHuang could you share how you combined factories with components?

@BohongHuang could you share how you combined factories with components?

Well. First you will need to create a type wrapper such as MyComponent for the foreign type MicroComponent from relm4:
pub struct MyComponent<T: MicroModel> {
    pub component: MicroComponent<T>,
}

impl <Model> MyComponent<Model>
where
    Model::Widgets: MicroWidgets<Model> + 'static,
    Model::Msg: 'static,
    Model::Data: 'static,
    Model: MicroModel + 'static, {
    pub fn new(model: Model, data: Model::Data) -> MyComponent<Model> {
        MyComponent { component: MicroComponent::new(model, data) }
    }
}

Then implement FactoryPrototype for the type wrapper. It is worth mentioning that MicroComponent::update_view should be called when you implement the method view:
impl FactoryPrototype for MyComponent<MyModel> {
    type Factory = FactoryVec<Self>;
    type Widgets = ToastOverlay;
    type Root = ToastOverlay;
    type View = Grid;
    type Msg = AppMsg;

    fn init_view(
        &self,
        _index: &usize,
        _sender: Sender<AppMsg>,
    ) -> ToastOverlay {
        self.component.root_widget().clone()
    }

    fn position(
        &self,
        index: &usize,
    ) -> GridPosition {
        let index = *index as i32;
        let row = index / 3;
        let column = index % 3;
        GridPosition {
            column,
            row,
            width: 1,
            height: 1,
        }
    }

    fn view(
        &self,
        _index: &usize,
        _widgets: &ToastOverlay,
    ) {
        self.component.update_view().unwrap();
    }

    fn root_widget(widgets: &ToastOverlay) -> &ToastOverlay {
        widgets
    }
}

Now you can implement MicroModel and MicroWidgets for your model:
impl MicroModel for SlaveModel { ... }

#[micro_widget(pub)]
impl MicroWidgets<SlaveModel> for SlaveWidgets { ... }

And add the model wrapped by MyComponent to a FactoryVec:
models: FactoryVec<MyComponent<MyModel>>

Finally, apply macro factory! in your factory widget:
Grid {
    factory!(model.models),
}

Thanks!


specify ssl_cert_reqs=None for TSL

Pull Request check-list
Please make sure to review and check all of these items:

[ ] Does $ tox pass with this change (including linting)?
[ ] Does travis tests pass with this change (enable it first in your forked repo and wait for the travis build to finish)?
[ ] Is the new or changed code fully tested?
[ ] Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?

NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.
Description of change
This change updates connection.parse_url to set ssl_cert_reqs=None for rediss:// connections.
$ rq info -u rediss://:**********@ec2-34-206-168-30.compute-1.amazonaws.com:29259
Error 1 connecting to ec2-34-206-168-30.compute-1.amazonaws.com:29259. [SSL: CERTIFICATE_VERIFY_FAILED] certificate verify failed: self signed certificate in certificate chain (_ssl.c:1091).

I came across this error after migrating to a redis environment with SSL/TSL. I found that it was caused by the connection. Heroku's documentation recommends instantiating the redis connection with ssl_cert_reqs=None.
https://devcenter.heroku.com/articles/heroku-redis#connecting-in-python

ssl_cert_reqs is not supposed to be None by default. See #1016


Add documentation for Data Mapper

$Subject

@madushajg - Need to remove the .DS_Store file committed in this PR.

@madushajg - Need to remove the .DS_Store file committed in this PR.

Removed with ce957bc2540d9e0c443a9cad2600068a74a1e9f7


String litterals are counted as "not covered"

I have a project with lots of code like this:
writeln!(
    out,
    r#"Some text
    spanning several lines
    because it's quite long"#,
)?;

In these case, there are several lines of code that are only occupied by string litterals (either regular "..." or raw r#"..."#), and these lines are always counted as "not covered", even if the enclosing writeln!(..) is properly counted as covered.

Thanks for the issue, I know what needs to be done so hopefully expect something this week. :+1:

So I don't suppose you could share a small working example. I've created a small test project with the snippet you pasted above as well as some other attempts and I can't recreate the issue. Also, are you running the latest version of tarpaulin?

I've wrote some code which may sort the issue, but until I can create or get a test project which recreates the issue I can't properly test it (although you could try it out if you feel eager :wink:). Or some help in building wayland-rs might help me solve the issue, but I'd prefer a smaller test project.

I'm observing it on wayland-scanner, see here https://coveralls.io/builds/13636716/source?filename=wayland-scanner%2Fsrc%2Fcode_gen.rs
This crate is independent from the rest of wayland-rs, so you can extract it. As well as the scanner test in wayland-rs test directory.
Otherwise, I may find some time tomorrow to try and make a simpler example.
Le 9 octobre 2017 21:52:45 GMT+02:00, xd009642<EMAIL_ADDRESS>a écrit :

I've wrote some code which may sort the issue, but until I can create
or get a test project which recreates the issue I can't properly test
it (although you could try it out if you feel eager :wink:). Or some
help in building wayland-rs might help me solve the issue, but I'd
prefer a smaller test project.
--
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub:
https://github.com/xd009642/tarpaulin/issues/47#issuecomment-335268167

Awesome I can see it on my system. That should be enough for me to get cracking :+1:

Right I've finally got this cracked. I forked wayland-rs for testing and you can see results here if you don't mind reading the raw logs https://travis-ci.org/xd009642/wayland-rs/jobs/288797043 (although advanced warning I will delete my fork in a couple of days).
Suffice to say checking it against the code_gen file I'm happy I've covered this, although there may be some unconsidered edge cases. If you find any just let me know :+1: I'll probably release a new version tomorrow or Wednesday with this change in :smile:


[CI] Codecov report for PatternGenerator.ts file is not deterministic

Please note
The bug is not related to the library itself, but rather the tests / CI.
Describe the bug
Just opened 3 pull requests with documentation updates, but the code coverage report of PatternGenerator.ts was not deterministic.
Failed code coverage report reference: https://app.codecov.io/gh/Tonejs/Tone.js/pull/1120
In these 2 pull requests it failed:

https://github.com/Tonejs/Tone.js/pull/1120
https://github.com/Tonejs/Tone.js/pull/1121

This pull request passed:

https://github.com/Tonejs/Tone.js/pull/1122

Expected behavior
Code coverage CI tests must be deterministic.

The problem can only be fixed on re-triggering the CI run, for example pushing the empty commit made via git commit -m 'trigger CI' --allow-empty. For reference: https://github.com/Tonejs/Tone.js/pull/1121

yeah i've noticed that too. probably because there is some randomness in one of the pattern types. I've updated the codecov config to not throw an error when the coverage value changes so slightly


Relay is returning strange alias for connections via REQUIRED_CHILDREN after mutation

For some reason when I do a mutation and get a return value with REQUIRED_CHILDREN in getConfigs, connections are being returned with a strange alias: _tierItems2EmfF3 where it should be tierItems.
When I make the same mutation through GraphiQL, the connection is returned properly.
I am not sure if this is some kind of configuration issue, but I have no idea what could be causing this.

Thanks for your question. It's a mechanism inside Relay. You should be able to access  tierItems as normal inside your application.


Adding RichMap and RichOptionMap implicit classes

Adds an orEmpty convenience method to Option[Map[A, B]]
Adds orNone convenience method on Map[A, B] to convert empty maps to None

I say :shipit:, scalacheck in the tests is not vital, but this is @devmage's PR.

I'll open another PR for scalacheck and a third one for dates of all files.

:shipit: if the build passes.


Fix global queue

If you send a global packet via packet:sendAll, and there are no per player channel queues to be flushed, the global queue is accidentally ignored.

I did this myself recently.


fix is_running, fix tests

Description
Bugfix for is_running property. Set _is_running variable to False after job finish.
Change test for  thread_worker to be sure that callback functions was executed
EDIT
Raise AttributeError for non existing parameter of WorkerBase
Type of change

[x] Bug-fix (non-breaking change which fixes an issue)

References

How has this been tested?

[x] example: all tests pass with my change

Final checklist:

[x] My PR is the minimum possible work for the desired functionality
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation
[x] I have added tests that prove my fix is effective or that my feature works

@Czaki looks like this now has one failing windows test
================================== FAILURES ===================================
_____________________________ test_thread_worker ______________________________
qtbot = <pytestqt.qtbot.QtBot object at 0x000001F6CD2D6BE0>
    def test_thread_worker(qtbot):
        """Test basic threadworker on a function"""
        func_val = [0]
        test_val = [0]
        def func():
            func_val[0] = 1
            return 1
        def test(v):
            test_val[0] = 1
            assert v == 1
        thread_func = qthreading.thread_worker(
            func, connect={'returned': test}, start_thread=False
        )
        worker = thread_func()
        assert isinstance(worker, qthreading.FunctionWorker)
        assert func_val[0] == 0
        with qtbot.waitSignal(worker.finished):
>           worker.start()
E           pytestqt.exceptions.TimeoutError: Signal  not emitted after 1000 ms
napari\_qt\_tests\test_threading.py:45: TimeoutError

not clear to be if this is just a one off or sporadic, or maybe I made a mistake when fixing the merge conflict with #1681. Can you look at this one more time before I merge? Thanks!!

@sofroniewn I see no logical reason why this test fail and other pass. I need to create windows environment and check this.

@sofroniewn I add print and it pass. I do not understand.

@sofroniewn I add print and it pass. I do not understand.

That's very strange - why don't you try taking them away again. If that fails then we might be on to something, otherwise maybe the failures are just at random times

Test fails again @Czaki! Now we're onto something!! It looks like you added a sys import too in addition to the print statements. Do you want to try adding that? Maybe that fixes things. If you (or anyone else) could reproduce locally that would make this much easier to figure out :-)

@sofroniewn
I finally reproduce error on my computer. It happens only when running whole data set (and I need to reduce time limits)
It looks like some previous executed test create events which are proceed before signal. increase timeout solve this.
I already meet something similar in the past. I do not know how to debug this. As you decide to use PySide2 I cannot ask on PyQt mailing list if anyone has this experience.

I finally reproduce error on my computer. It happens only when running whole data set (and I need to reduce time limits)
It looks like some previous executed test create events which are proceed before signal. increase timeout solve this.

Looks like the timeout is now 20 seconds, is that right? I guess that's ok, it was only an issue on the windows test. Really nice job chasing this down. If we run into this problem again at least we have this investigation to guide us. I'm ok merging now, unless there's additional stuff you want to look into @Czaki? (cc @jni)

Merge


opt check and remove unavailable brpc stubs (#43212)

What problem does this PR solve?
Pick from master: #43212
Related PR: #43212
Problem Summary:
Release note
None
Check List (For Author)

Test

[ ] Regression test
[ ] Unit Test
[ ] Manual test (add detailed scripts or steps below)
[ ] No need to test or manual test. Explain why:

[ ] This is a refactor/code format and no logic has been changed.
[ ] Previous test can cover this change.
[ ] No code files have been changed.
[ ] Other reason

Behavior changed:

[ ] No.
[ ] Yes.

Does this need documentation?

[ ] No.
[ ] Yes.

Check List (For Reviewer who merge this PR)

[ ] Confirm the release note
[ ] Confirm test cases
[ ] Confirm document
[ ] Add branch pick label

run buildall

run buildall

run buildall

run buildall


Idempotence inconsistency : log files permissions change at every run

Module version: 6.3.3
Puppet version: 4.8.2
OS and version: CentOS 7.4

Bug description
I noticed that there's an idempotency issue when managing an ES cluster using the aformentionned version of the module
-> newly created log files' permission(s) ( archives included )  get changed when the puppet catalog is applied
Here's a puppet run report sample to illustrate what's happening :

Resource
Status
Changed From
Changed To

File[/var/log/elasticsearch/*****/es-cluster-vdox.log]
success
0644
750

File[/var/log/elasticsearch/*****/es-cluster-vdox-2018-11-08-1.log.gz]
success
0644
750

After looking at the ES module's code, I think the issue comes from this particular snipet :
$elasticsearch::logdir:
        ensure  => 'directory',
        group   => $elasticsearch::elasticsearch_group,
        owner   => $elasticsearch::elasticsearch_user,
        mode    => '0750',
        recurse => true;

Thanks for the quick feedback


Add custom operators

Hi all,
I'm pretty new to Julia and mostly coded in C/C++, so I would like to implement some C-ish operators like -> to dereference pointers.
But since there is no -> operator, I cannot create/overload such. Is there any easy way to simply define new operators, which can then be freely used? I glimpsed a bit over the code, but couldn't even find the "operator handling code" yet, lol.
IMO that would make code much cleaner to read, e.g. from unsafe_load(someptr).somefield to someptr->somefield, especially when nested, like linkedlist->next->next->prev->next (imagine the unsafe_load version yourself :p). But this is not the only case, I would generally love to just add all kinds of custom operators.
Something like JuliaParse.AddCustomOperator("->"), maybe with settings like left/right binding powers (or whatever, I never wrote a full parser) for fine tuning. Would be epic if somebody has an idea how to accomplish this.

Hey @kungfooman. This package doesn't actually do the parsing for Julia itself, but rather it's an experimental parser for Julia written in Julia. Julia's parser lives in the Julia repository and is implemented in Scheme. Regarding the design, you generally shouldn't need (or want!) to work directly with pointers in Julia, so it's unlikely to get its own syntax. In particular, x->y already means "create an anonymous function that accepts an argument x and returns y."
In general, questions like this should be posted to Discourse, the official discussion/Q&A forum for Julia.

Also, you can always define your own operator (though most ASCII-based common in other languages are taken, used by the Base library). As an example, you can define
→(ptr::Ptr, field::Symbol) = getfield(unsafe_load(ptr), field)

and use it like a→:b.

Thanks for the example, but I really dislike the syntax and I don't wanna mess around with Unicode operators.
And thanks for the hint, I didn't actually realized that C's dereference operator is Julia's lambda syntax.
I played a bit around with JuliaParser and figured it out how to add operators:
using JuliaParser

#length(JuliaParser.Lexer.ASSIGNMENT_OPS)

push!(JuliaParser.Lexer.ASSIGNMENT_OPS, Symbol("add"))

newops = [:add]
#:add in newops

function rewrite_op(i)
  if (i.head in newops)
    i.args = [i.head, i.args[1], i.args[2]]
    i.head = :call
  end
end

function rewrite(ast)
  # rewrite ast
  if typeof(ast) == Expr
    rewrite_op(ast)
  end
  # recursively rewrite all childs of ast
  for i in ast.args
    if typeof(i) == Expr
      rewrite(i)
    end
  end
end

test = JuliaParser.Parser.parse("1 add 2 add 3")

rewrite(test)

# add the new "operator"
function add(a, b)
  return a + b
end

eval(test) # returns 6

I played a bit around with JuliaParser and figured it out how to add operators:

This is actually really cute, I can see maybe this kind of trick being useful for making DSLs
(When pair with string macros).
Eg using this to add SQL operators.
.
But in this case not really a sensible thing to do, I think
You've effectively avoided writing a macro, by

invoking an alternate parser, with a modification you make to it before parsing
using a function (instead of a macro) to rewrite the AST
evaluating the rewritten AST.

All you really want to do is overload an operator.
And you want to avoid unicode.
There are enough unused operators in ANSI range.
Particularly since we can use multiple dispatch on ones we are not going to use for that combination of input types (Ptr and  Symbol)
For example:
..
julia> (..)(ptr::Ptr, field::Symbol) = getfield(unsafe_load(ptr), field)
.. (generic function with 1 method)

julia> xp .. :bar

note that .. likes to have space around it.
Also I have a feeling it is up to be removed.
-
julia> Base.:(-)(ptr::Ptr, field::Symbol) = getfield(unsafe_load(ptr), field)

julia> xp-:bar

I rather like this one, without spaces,
as it looks abit like the operator is -:, even that the : is actually part of the :bar Symbol


Search active tab, if not search bookmarks/recent history

Question:
I would like to open a tab if it already is open and if it is not open, then search bookmarks/history and open it.
For this, I’m first using the tab keyword and if it is not resulting in any active tab, then I’m  searching using the bh keyword.
Is there already a combination available which will do this one after the other?
If not, would it be possible to introduce a new keyword to do this? Or any other way to accomplish this workflow.

It's technically possible, but I'm not sure of the utility: If you select a bookmark or history entry and the URL is already open in a tab, Safari activates the tab and reloads the page.
The tab feature mostly exists as a hook for running scripts (Close Tabs to Right etc.).


x/vgo: vgo does not fix the timestamp in a pseudo-version

What version of Go are you using (go version)?
go version go1.10 darwin/amd64 vgo:2018-02-20.1
Does this issue reproduce with the latest release?
Yes.
What operating system and processor architecture are you using (go env)?
GOARCH="amd64"
GOBIN=""
GOCACHE="/Users/eno/Library/Caches/go-build"
GOEXE=""
GOHOSTARCH="amd64"
GOHOSTOS="darwin"
GOOS="darwin"
GOPATH="/Users/eno/go"
GORACE=""
GOROOT="/usr/local/go"
GOTMPDIR=""
GOTOOLDIR="/usr/local/go/pkg/tool/darwin_amd64"
GCCGO="gccgo"
CC="clang"
CXX="clang++"
CGO_ENABLED="1"
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -fdebug-prefix-map=/var/folders/bt/375v_zy93bx4qz00lrgw7mhh0000gn/T/go-build831165372=/tmp/go-build -gno-record-gcc-switches -fno-common"

What did you do?
Here is a go.mod which pulls in gorilla/mux:
module "app"

require "github.com/gorilla/mux" v0.0.0-00000000000000-07ba1fd60e210dc5cc6f86ec25dc9ecc7c95c295

What did you expect to see?
I would expect vgo build to fail to find the specified version of gorilla/mux since the timestamp does not match that of the commit.
In Defining Go Modules, it says:

Specifically, vgo understands the special pseudo-version v0.0.0-yyyymmddhhmmss-commit as referring to the given commit identifier, which is typically a shortened Git hash and which must have a commit time matching the (UTC) timestamp.

What did you see instead?
vgo build works without a problem and produces a functioning binary.

Thank you!
Using that row of zeros makes it a lot easier to specify the date in advance.
I'm not even sure in which timezone I had to specify the string after I had extracted it from a given commit info.
So in my opinion the actual chack should only be introduced after we have an easy and documented way to extract the pseudoversion from a given package/module without having to do the git-dance manually.

Run "go build" and then "cat go.mod". What does it say? It should be updated to have the right timestamp.
For that matter, even if you'd written:
require "github.com/gorilla/mux" 07ba1fd60

it's supposed to get updated to turn into the right pseudo-version. Can you let me know if that's what you're seeing?

In my case it was github.com/go-sql-driver/mysql having problems. vgo has determined v1.3 as latest version and used v1.3.0 in the module, which produced errors due tag not found on github…
Then I searched for ways to force another git-ref.
So I tried require "github.com/go-sql-driver/mysql" 1a676ac6e4dc now and it worked. after a vgo build … it has been replaced with a proper pseudo-version.
But this behaviour is not documented (or at least not easily discoverable), therefore my confusion.
Of course I am aware of the fact, that vgo is in a very early state and documentation is in an early state.
But as we are talking about it, is it possible to use arbitrary refs (branch, tag, commit) in a human readable way?
How does this play with other VCS like SVN?

Here are the results of running vgo build and cat go.mod. To be clear, this is for go version go1.10 darwin/amd64 vgo:2018-02-20.1.
Before running the commands, here are go.mod and main.go:
module "app"

require "github.com/gorilla/mux" v0.0.0-00000000000000-07ba1fd60e210dc5cc6f86ec25dc9ecc7c95c295

and
package main

import (
        "net/http"

        "github.com/gorilla/mux"
)

func main() {
        r := mux.NewRouter()

        http.ListenAndServe(":8080", r)
}

Then, I run vgo build and here are the contents of go.mod:
module "app"

require "github.com/gorilla/mux" v0.0.0-00000000000000-07ba1fd60e210dc5cc6f86ec25dc9ecc7c95c295

Notably, if I instead write my go.mod like this:
module "app"

require "github.com/gorilla/mux" 07ba1fd60

then after running vgo build, the contents of go.mod are correct:
module "app"

require "github.com/gorilla/mux" v0.0.0-20180226051151-07ba1fd60e21

Thanks @enocom. Vgo should be fixing the bad timestamp the same way it fixes the commit.

Feel free to send a CL.


Dynamic fitting

We need to think about smart data structure to handle dynamic fitting. It means that the input parameters for next fitting run depend on the previous fitting results, also fitting strategy varies gradually with different parameters either turn on or turn off.

Fitter might be the right solution for the first part of this. But we might want our own subclass of Model to be safe (i.e., in control).

I think this is done.


probeSniffer crashes on my device

Hello!
I've installed all the requirements, followed every required step but when I launch the script and come close to it with an iPhone there are some errors showing up. In the image below you can see them. I don't know how to solve this as I'm not familiar with Python.

Thanks for the answer and the script!
Regards

@xdavidhu got a similar error, unfortunatly its also crashing with your fix.
[!] An error occurred. Debug:
Traceback (most recent call last):
File "./probeSniffer.py.1", line 395, in main
capture.apply_on_packets(packetHandler)
File "/usr/local/lib/python3.6/dist-packages/pyshark-<IP_ADDRESS>-py3.6.egg/pyshark/capture/capture.py", line 248, in apply_on_packets
return self.eventloop.run_until_complete(coro)
File "/usr/local/lib/python3.6/dist-packages/trollius-1.0.4-py3.6.egg/trollius/base_events.py", line 300, in run_until_complete
return future.result()
File "/usr/local/lib/python3.6/dist-packages/trollius-1.0.4-py3.6.egg/trollius/futures.py", line 287, in result
raise self._exception
File "/usr/local/lib/python3.6/dist-packages/trollius-1.0.4-py3.6.egg/trollius/tasks.py", line 255, in _step
result = next(coro)
File "/usr/local/lib/python3.6/dist-packages/pyshark-<IP_ADDRESS>-py3.6.egg/pyshark/capture/capture.py", line 261, in packets_from_tshark
packet_count=packet_count))
File "/usr/local/lib/python3.6/dist-packages/trollius-1.0.4-py3.6.egg/trollius/tasks.py", line 253, in _step
result = coro.send(value)
File "/usr/local/lib/python3.6/dist-packages/pyshark-<IP_ADDRESS>-py3.6.egg/pyshark/capture/capture.py", line 290, in _go_through_packets_from_fd
packet_callback(packet)
File "./probeSniffer.py.1", line 194, in packetHandler
ssid = pkt[3].ssid
File "/usr/local/lib/python3.6/dist-packages/pyshark-<IP_ADDRESS>-py3.6.egg/pyshark/packet/layer.py", line 36, in getattr
raise AttributeError()
AttributeError
Also running this on a kali linux system. Any ideas? :)


update msal-node landing page & samples page

removes alpha notice on msal-node landing page
adds desktop and b2c samples links to msal-node landing page
adds desktop, b2c samples and docs.microsoft.com tutorial article links to msal-node samples page

p.s. do not merge before Feb 15

Coverage decreased (-2.8%) to 79.948% when pulling c6de840d684291617012cfe444bc5759645076ea on docs-ga-update into f30fee3fcfbfb99c4a179175320b4e45a5129254 on dev.


Bug fix: BTClient.setup promise never resolves for first-time buyers using PayPal

If someone purchases for the first time (no existing payment methods) and uses PayPal, the JS promise never resolves.  This is because dropInViewControllerWillComplete does not get invoked in that unique situation.  This fixes that.
This was uncovered by PR #32, which my esteemed colleague @TSMMark submitted a ways back.  Upon testing we discovered one unique condition that the PR didn't cover.
The following tests were run successfully:

No existing payment methods -> purchase with PayPal
No existing payment methods -> purchase with Credit Card
1 existing PayPal account -> pay with that single account
1 existing CC account -> pay with that single account
1 existing PayPal account -> purchase with 2nd PayPal account
1 existing PayPal account -> purchase with new CC account
1 existing CC account -> purchase with 2nd CC account
1 existing CC account -> purchase with new PayPal account

People are very likely to use PayPal for their first purchase, and this PR is critical to allowing that experience.  Thank you!

Cheers!


[Bug] Spleeter hangs endlessly on "Tears of a Clown"

Description
On this environment, Spleeter hangs endlessly on "Tears of a Clown" and other certain songs. It works for the demo example and a majority of songs, but has an endless loop on some.
The hang is similar whether using the spleeter-cpu or spleeter-gpu activation. The hang is similar whether using 2 stem or 4 stem output. The hang is similar whether using WAV or MP3 input format.
Step to reproduce
git clone https://github.com/Deezer/spleeter
conda env create -f spleeter/conda/spleeter-cpu.yaml
conda env create -f spleeter/conda/spleeter-gpu.yaml
conda activate spleeter-cpu
or
conda activate spleeter-gpu
Output
(spleeter-cpu) E:\git\people\deezer>spleeter separate -i spleeter/spleeter separate -i spleeter/SmokeyRobinsonTheMiracles-2004-Motown1s-17-TearsofaClown.m4a -p spleeter:2stems -o output
INFO:tensorflow:Using config: {'_model_dir': 'pretrained_models\\2stems', '_tf_random_seed': None, '_save_summary_steps': 100, '_save_checkpoints_steps': None, '_save_checkpoints_secs': 600, '_session_config': gpu_options {
  per_process_gpu_memory_fraction: 0.7
}
, '_keep_checkpoint_max': 5, '_keep_checkpoint_every_n_hours': 10000, '_log_step_count_steps': 100, '_train_distribute': None, '_device_fn': None, '_protocol': None, '_eval_distribute': None, '_experimental_distribute': None, '_experimental_max_worker_delay_secs': None, '_service': None, '_cluster_spec': <tensorflow.python.training.server_lib.ClusterSpec object at 0x0000017870639240>, '_task_type': 'worker', '_task_id': 0, '_global_id_in_cluster': 0, '_master': '', '_evaluation_master': '', '_is_chief': True, '_num_ps_replicas': 0, '_num_worker_replicas': 1}
INFO:tensorflow:Calling model_fn.
WARNING:tensorflow:From c:\programdata\miniconda3\envs\spleeter-cpu\lib\site-packages\spleeter\model\functions\unet.py:29: The name tf.keras.initializers.he_uniform is deprecated. Please use tf.compat.v1.keras.initializers.he_uniform instead.

INFO:tensorflow:Apply unet for vocals_spectrogram
INFO:tensorflow:Apply unet for accompaniment_spectrogram
INFO:tensorflow:Done calling model_fn.
WARNING:tensorflow:From c:\programdata\miniconda3\envs\spleeter-cpu\lib\site-packages\tensorflow\python\ops\array_ops.py:1354: add_dispatch_support.<locals>.wrapper (from tensorflow.python.ops.array_ops) is deprecated and will be removed in a future version.
Instructions for updating:
Use tf.where in 2.0, which has the same broadcast rule as np.where
INFO:tensorflow:Graph was finalized.
WARNING:tensorflow:From c:\programdata\miniconda3\envs\spleeter-cpu\lib\site-packages\tensorflow\python\training\saver.py:1276: checkpoint_exists (from tensorflow.python.training.checkpoint_management) is deprecated and will be removed in a future version.
Instructions for updating:
Use standard file APIs to check for files with this prefix.
INFO:tensorflow:Restoring parameters from pretrained_models\2stems\model
INFO:tensorflow:Running local_init_op.
INFO:tensorflow:Done running local_init_op.
WARNING:tensorflow:The dtype of the watched tensor must be floating (e.g. tf.float32), got tf.string
WARNING:tensorflow:The dtype of the watched tensor must be floating (e.g. tf.float32), got tf.int32
WARNING:tensorflow:The dtype of the watched tensor must be floating (e.g. tf.float32), got tf.string
INFO:tensorflow:Loading audio b'spleeter/SmokeyRobinsonTheMiracles-2004-Motown1s-17-TearsofaClown.m4a' from 0.0 to 600.0

Environment

OS
Windows  10 64 bit

Installation type
Conda

RAM available
32G

Hardware spec
CPU is Intel i7-6700K @ 4 GHz / GPU is NVidea GeForce GTX 1070

Additional context
The particular song I used was Smokey Robinson and the Miracles "Tears of a Clown" from the 2004 CD Motown 1s. The song has changing tempo and some flutes and oboes that might make it tough to separate.

Duplicate with #29 and #30. We deployed a new version of Spleeter on PyPi that fix the issues (1.4.3). Please pull the repository again and recreate a fresh new conda environment. It will download the latest release of Spleeter and it should work as expected.

Thank you. A pull and update of spleeter fixed this issue.


[Database Support] oracle

Is your feature request related to a problem? Please describe.
My company is still extensively using Oracle dbs for OLTP. Would be great to be able to use one tool for both OLTP(Oracle) and DW(MS).
Describe the solution or feature you'd like
Use Azure data studio against Oracle db.

This would be really helpful! We currently use VS Code for SQL version control and it is a challenge with having both Oracle and MSFT SQL databases.

Is anyone working on this issue currently? I'd love to contribute as well since I have an immediate use case.

I am not working on it
tors 6 feb. 2020 kl. 05:08 skrev Hansel Wei<EMAIL_ADDRESS>
Is anyone working on this issue currently? I'd love to contribute as well
since I have an immediate use case.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/microsoft/azuredatastudio/issues/6724?email_source=notifications&email_token=AF6VHFYQAJXUMLR6AX62QILRBOEMDA5CNFSM4ILIKTBKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEK53N4Q#issuecomment-582727410,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AF6VHF7OV2OPNCOEU7CFC73RBOEMDANCNFSM4ILIKTBA
.

This would be a really good capability to add to ADS, with the capability enhancements to PolyBase it makes sense to be able to communicate with Oracle in the same tool when doing development.

I would like to upvote this request as well.
It could help us a lot in our daily support/developement.

I would like to upvote this request as well.

Then hit the OP's 👍🏻 as that's what's counted here..

I really like the idea of being able to connect to Oracle and MSSQL from a single application. I managed Operations and we have 4 to 5 different applications and this would help us trim back.

What is the development state of the Extension for Oracle extension?  Any idea when query support will be present?

What is the development state of the Extension for Oracle extension? Any idea when query support will be present?

up

Would including node-oracledb as the provider be a good solution to this? https://oracle.github.io/node-oracledb/
I'd like to hear some thoughts before attempting to make a contributing PR / implementation.

any plans on supporting oracle query execution in ADS?

Hi all - I wanted to share that this is on our radar and I am hoping to have an update for you, but it's going to take a few months.  I apologize for not being able to provide specific details, there are still many things in flux and I do not want to promise something that cannot be delivered.  But please know that I see that you all are commenting and upvoting, which is great (that is what helps drive change in the product).  Thank you.


Suggestion- using 3rd party user controls

I see that some grids are just plain HTML tables. Could we use the mvc.grid project ? Or the syncfusion mvc free controls ?

@BillWagner any thoughts on this?  We do have simple tables and haven't had much investment on UX updates but I haven't looked at impact of either of those to the project.  Thanks for the ideas and definitely looking for help to make the UI/UX more engaging and supportive of user needs

I'd be fine with any 3rd party components, as long as:

We (HTBox) get a license to use them.
Any public contributors can build and work on the project without a large outlay of funds.

I haven't looked at mvc.grid. How active is it? Is it still being maintained?

Dear Bill and Tony,
1.regarding syncfusion user controls, they require to request for a licence according to the FAQ. the contact form to send the request is here

regarding Mvc.Grid unfortunately it seems like the project has not been updated since 2014.

If Mvc,Grid works, why be alarmed about the 2014 modification date? It's open source - in the unlikely event we have a problem can we not submit a fix back / fork their codebase?

Hello, I think we can use Mvc.Grid.
we should be able to submit a fix or fork the original codebase.

Just to let you know, I used this control when I used to work for
thebigword... it's a decent, quality grid...
On 18 Sep 2016 20:36, "kevin tshimanga"<EMAIL_ADDRESS>wrote:

Hello, I think we can use Mvc.Grid.
we should be able to submit a fix or fork the original codebase.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/HTBox/crisischeckin/issues/648#issuecomment-247868684,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AGer79BAbDP61k-fCTGHM3mwBZmVq9zeks5qrZKmgaJpZM4I1_yD
.

Thanks @mjmilan and @ktngoykalolo
With your recommendations, I"m happy to take a PR that takes a dependency on MVC.Grid.


Game Crash when using DevTools

whenever I press f11 the game crashes
2023-05-10_14-52-20.log

Same here (on Linux via Wine):
2023-05-21T09:21:14+0300
Whoopsies! An exception has occurred while running Geode.

== Geode Information ==
Loader Version: v1.0.0-beta.17
Installed mods: 3
Failed mods: 0

== Exception Information ==
Faulty Module: C:\Games\Geometry Dash\GeometryDash.exe
Faulty Mod: <Unknown>
Exception Code: 0xc0000005 (EXCEPTION_ACCESS_VIOLATION)
Exception Flags: 0
Exception Address: 00000000 (GeometryDash.exe + 0xffc00000)
Number Parameters: 2

== Register States ==
EAX: 0
EBX: 0x7fcbda4
ECX: 0xb8fcf8
EDX: 0xe2e40f20
EBP: 0xb8fd64
ESP: 0xb8fcf4
EDI: 0x7fcbda0
ESI: 0x7fcbda8
EIP: 0

== Stack Trace ==
 - C:\Games\Geometry Dash\GeometryDash.exe + 0xffc00000
 - C:\Games\Geometry Dash\geode\unzipped\geode.devtools\geode.devtools.dll + 0x78c1
 - 03173C85
 - C:\Games\Geometry Dash\GeometryDash.exe + 0x261175
 - C:\Games\Geometry Dash\GeometryDash.exe + 0x2621fd
 - C:\windows\system32\kernel32.dll + 0x2aee0
 - C:\windows\system32\ntdll.dll + 0x5f287
 - C:\windows\system32\ntdll.dll + 0x5fb80 (RtlCreateUserThread + 0)

== Installed Mods ==
geode.loader | Geode Team | v1.0.0-beta.17 | Enabled | Loaded |
geode.devtools | Geode Team | v1.1.0 | Enabled | Loaded |
itsaleph.hello_world_mod | ItsAleph | v1.0.0 | Enabled | Loaded |

i can confirm devtools does indeed always crash on wine

I'm on windows but it still crashes

can you test on the latest version

Does work for me, although i am on windows currently.

Here's another issue. It's on Android this time. Same kind of problem. But not a crash, just a type of soft lock. (Nightly newest geode and gd vers)
Click the new games button aka.Open DevTools at all and you will not be able to play.All the items will be stacked and unusual


feature: Loading style file imported

Is your feature request related to a problem? Please describe.
Add a feature that plugin can support custom style file imported. Maybe like svg and img imported.
Describe the solution you'd like
A clear and concise description of what you want to happen.
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context or screenshots about the feature request here.

good idea! Are you interested in implementing this feature？

OK. Look that on the weekend.

ok


pool swap - confirm page

What kind of PR is this?:

/kind feature
What this PR does / why we need it:

Pool swap confirm page

Which issue(s) does this PR fixes?:

Fixes #552
Additional comments?:

@ivan-zynesis Finally block will be called regardless if it's an error or not. Also, it will take a long time to confirm so the postAction won't take effect immediately. My implementation is to call it after broadcast so it won't take long


How to specify project for "wandb sync"?

I accidentally ran some experiments in dryrun mode, and would like to sync them online. I have a few projects (A, B, C) and ran my experiments in project B. However, when I run "wandb sync", they are sent to project A in the web interface. How can I specify that I want them to sync to project B instead?
Note: in the web interface I can move runs from one project to another, which solves this to some extent, but I just wanted to know if it's possible to do this in wandb sync in the first place.

Hey @alsuhr-c , the runs log to project A, even if you set the project=B in your init() function?

I see, can you check which wandb version you are using? also which OS is this happening on?
I'd like to try to reproduce this.

@alsuhr-c when you call wandb sync from the command line you can specify -p or --project to sync runs to that specific project.

Thanks!


Test dm-vio

Dm-vio is dso vio version. It seems to be light and accuracy. Are you interested to test it?

Thank you for your suggestion @dssdyx
I tested it on KAIST-VIO dataset and the result video is here - https://youtu.be/OJddYxLlSqo
It is not that light as the CPU usage of VINS-Mono is similar to the DM-VIO and VINS-Mono showed more stable and accurate performance.
Thanks.


Filtering seems to be give up after a few commas

E.g. http://browserl.ist/?q=last+1+version%2C+not+IE+<+11%2C+>+0.2%25 should not show browsers with less than 0.2% but QQ Browser1.2, Android Browser67, Baidu Browser7.12 are all 0% usage browsers that do show up in the list.
On the other hand http://browserl.ist/?q=>+0.2%25 does hide 0% usage browsers...

Those 0% browsers are showing up because of the last 1 version query http://browserl.ist/?q=last+1+version
Checking with the cli version of https://github.com/browserslist/browserslist the browsers show up in the results. If you believe that they should filter out results under a certain number I suggest creating an issue with them https://github.com/browserslist/browserslist/issues/new


Add LaTeX PDF

Add the "Breve Introdução ao LaTeX2e" notes

Nice addition. Will merge, but it would be nice if you could add the author name.

Done.


Improve performance of add_sos

Model.add_sos did not use the procedural API
cf https://stackoverflow.com/questions/76026076/why-add-sos1-method-of-docplex-is-taking-too-long
Now it runs 30% faster; bottleneck is on creating the int/float arrays before diving into Cplex.
Still there is a bottleneck in building int/float arrays before diving into Cplex.
It seems I don't have the Cplex/Python versions with Vincent's improvements?
In addition, The CPXXaddsos API requests a mandatory weights array which, 99% of the time is a dummy array with consecutive numbers; the CPLEX API should accept NULL for this and build this dummy array in C for itself, IMHO

From what I see, these changes were already merged in 2.26 (which has not been released yet).
I propose that we keep this PR open until next release, then we'll check the diffs and see if there's anything to do.

closing as this is merged in ghe


Work assignment,

Hello guys, Since, there is a communication gape, and the deadline is coming. As per @s4il3sh , Lets he do the Task 01. I will do task 2. I have already started. And @LinxuanHu  can do task 3.
But we both have to do our part soon, so that he has time for his task @s4il3sh .
Thank you.

ok

Hello guys, Since, there is a communication gape, and the deadline is coming. As per @s4il3sh , Lets he do the Task 01. I will do task 2. I have already started. And @LinxuanHu can do task 3. But we both have to do our part soon, so that he has time for his task @s4il3sh . Thank you.

Nice distribution. Keep doing your jobs.

Hello guys, Since, there is a communication gape, and the deadline is coming. As per @s4il3sh , Lets he do the Task 01. I will do task 2. I have already started. And @LinxuanHu can do task 3. But we both have to do our part soon, so that he has time for his task @s4il3sh . Thank you.

Nice distribution. Keep doing your jobs.

@Mosaddeq107 Thank you for you comment.


timer

From the command line, create multiple scheduling prompts. You are prompted for a time in minutes and a thing that must be done then. "The pie should be cooked." "Meeting with the boss." "Put your pants on."
Pull Request Label:

[ ] Bug
[x] New feature
[ ] Enhancement
[ ] New component
[ ] Typo

Pull Request Checklist:

[ ] Have you followed the guidelines for contributing?
[ ] Have you checked that there aren't other open pull requests for the same fix or component?
[ ] Have you ran the tests locally with bats tests?

My question is: doesn't anyone care if it works? I suppose not; when I installed git and tried to identify myself, it said, "fatal: not in a git directory" but didn't bother to tell me what directory I should be in. There are some rules in software design. That violates the "Don't fail to explain the problem."

Whatever. I find it useful. If Alexander Epstein doesn't want it as part of his suite of bash utilities, I'm fine with that.

From: stale[bot]<EMAIL_ADDRESS>Sent: Friday, June 28, 2019 1:14 PM
To: alexanderepstein/Bash-Snippets
Cc: Wastrel; Author
Subject: Re: [alexanderepstein/Bash-Snippets] timer (#191)
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://github.com/alexanderepstein/Bash-Snippets/pull/191?email_source=notifications&email_token=AAUIWIWO3MXKSFZ6TJQM563P4ZIIVA5CNFSM4HSDT7M2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODY2ZYGQ#issuecomment-506829850, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AAUIWIX5JX4MLDBXQ4HIJLTP4ZIIVANCNFSM4HSDT7MQ.

Sorry about that, I've been real busy with school not sure when I'm gonna be able to get to it but I haven't forgotten

Thanks, I appreciate that. I am not worried. I use the darn thing every day to remind me when to check the pizza or call my GF who seems to be AWOL lately 🙂
Eric

From: Alex Epstein<EMAIL_ADDRESS>Sent: Friday, June 28, 2019 6:17 PM
To: alexanderepstein/Bash-Snippets
Cc: Wastrel; Author
Subject: Re: [alexanderepstein/Bash-Snippets] timer (#191)
Sorry about that, I've been real busy with school not sure when I'm gonna be able to get to it but I haven't forgotten
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://github.com/alexanderepstein/Bash-Snippets/pull/191?email_source=notifications&email_token=AAUIWISXLDDRKP3AN67SLOLP42LXBA5CNFSM4HSDT7M2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODY3LTOY#issuecomment-506902971, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AAUIWIVCCHO7OKSOWC6XZ3LP42LXBANCNFSM4HSDT7MQ.


Geometry2D.IsPointInPolygon incorrectly reports point inside of polygon

Godot version
4.1.1-stable [bd6af8e0ea69167dd]
System information
Godot v4.1.1.stable.mono (bd6af8e0e) - Ubuntu 22.04.3 LTS 22.04 - Vulkan (Forward+) - dedicated NVIDIA GeForce RTX 4080 () - AMD Ryzen 9 5900X 12-Core Processor (24 Threads)
Issue description
Geometry2D.IsPointInPolygon incorrectly reports a point lies inside of a polygon, when it clearly lies outside of it.
Here is the perimeter of the polygon:

Here I have printed out the result of Geometry2D.IsPointInPolygon() for all points within a range:

As you can see, there is a rogue pixel in the top left quadrant.
Steps to reproduce
I've created the following repro. Simply attach this script to a Node2D and it will fail with: "Error found in Geometry2D.IsPointInPolygon". Note: I'm generating all the vertices (there are around 250), but I can also provide a text file with each individual vertex if necessary.
using System;
using System.Collections.Generic;
using Godot;

public partial class Repro : Node2D
{
    public override void _Ready() {
        int radius = 40;
        int height = 100;
        Vector2 center = new(radius, height * 0.5f);
        var vertices = Capsule(center, radius, height);

        if (Geometry2D.IsPointInPolygon(new Vector2(29, 16), vertices)) {
            throw new Exception("Error found in Geometry2D.IsPointInPolygon");
        }
    }

    private static Vector2[] Capsule(Vector2 center, float radius, float height) {
        int vertexCount = (int)Math.Ceiling(Math.PI * radius);
        var vertices = new List<Vector2>();

        // Bottom of the capsule
        for (int i = 0; i <= vertexCount; ++i) {
            double phi = Math.PI / vertexCount * i;
            Vector2 v = new Vector2((float)Math.Cos(phi), (float)Math.Sin(phi)) * radius;
            v.Y += center.Y + height * 0.5f;
            v.X += center.X;
            vertices.Add(v);
        }

        // Top half-circle of the capsule
        for (int i = vertexCount; i >= 0; --i) {
            double phi = -Math.PI / vertexCount * i;
            Vector2 v = new Vector2((float)Math.Cos(phi), (float)Math.Sin(phi)) * radius;
            v.Y += center.Y - height * 0.5f + 2 * radius;
            v.X += center.X;
            vertices.Add(v);
        }

        return vertices.ToArray();
    }
}

Please provide the code in GDScript as well, the code isn't too complicated to convert, but most people who investigate issues do not have a mono version available

Unfortunately, due to differences in floating point arithmetic I wasn't able to reproduce my vertex generation on GDScript. However, I was able to port all my vertexes over into a GDScript, and was able to get a repro.
Here is the project:
Repro.zip

The cause seems to be same as in #70823, specifically intersections of the from-point-ray with the polygon edges are counted incorrectly (https://github.com/godotengine/godot/issues/70823#issuecomment-1380569266). I'll look into fixing this.

If it is related to that issue, then maybe the fix I did can help. https://github.com/godotengine/godot/pull/74699

I faced this one today although it is different. I am comparing latitude/longitude coordinates and sometimes the difference between positions is in the range of millionths of a unit. this means that it would give tell me that I was in the border of the polygon when I really wasn't
My previously mentioned PR in addition to this did fix the issue for me:
geometry_2d.patch
Overall I think the use of "approximately equal" in functions and comparisons should be discouraged because otherwise we'll keep finding things like these.


Upgrade hyper to 0.10, openssl to 0.9

I was able to compile s3lsio with these changes and uploading to s3 worked correctly.
The new openssl API methods returns Result<> values. This pull request does not handle those Results values but calls .unwrap()'s. Proper error handling there would require changes to existing methods/API of aws-sdk-rust, I'm not sure what's the best way to implement that at the moment.
Also I'm not sure if the proxy code I updated is correct, because I don't have a way to test it currently.

Hi Martin, was there an issue or just wanted to update to the latest hyper and openssl? Just wondering. Thanks

I couldn't compile s3lsio with cargo install s3lsio:
on OS X (10.12.3): rustc 1.14.0 (e8a012324 2016-12-16) got compilation error when compiling openssl-sys-extras:
cargo:warning=src/openssl_shim.c:1:10: fatal error: 'openssl/hmac.h' file not found

on Debian 9.0: rustc 1.14.0 (e8a012324 2016-12-16) got error for openssl-sys-extras:
cargo:warning=src/openssl_shim.c: In function 'DH_new_from_params':
cargo:warning=src/openssl_shim.c:132:7: error: dereferencing pointer to incomplete type 'DH {aka struct dh_st}'
cargo:warning=     dh->p = p;

As stated in another PR https://github.com/lambdastackio/aws-sdk-rust/pull/4 this PR looks good :+1: @hanscj1 pretty much every crate is upgrading openssl would definitely appreciate it if this was in the main stream versus a fork


TiGLViewer crashes when trailing edge GuideCurve is missing

In some situations, TiGLViewer crashes when a wing has a guide curve defined a the leading edge, but not at the trailing edge.
I have attached a modified verison of the CPACS example simpleAircraft, where i have added guidecurves to the htp. When commenting out one of the TE guide curves from the VTP (l.1107), TiGL fails to render it but does not crash. When doing the same to the HTP (l.1206) however, there is a hard crash.
example_issue#987.zip

I can confirm this. Thanks for the find!
Some more info: Commenting out the VTP TE guide curve in line 1107 gives the error:
ERR 12/20 10:51:59 CTiglMakeLoft.cpp:229] Could not create loft with guide curves. Error code = 2
ERR 12/20 10:51:59 CTiglWingBuilder.cpp:148] CCPACSWingBuilder: Unable to determine wing face names from wing loft.

I think this might be the same as https://github.com/DLR-SC/tigl/issues/891, but I would have to verify.


Generated Client Code for C#/TypeScript can also include ReSharper project file

It would be nice to take generated code and open it as ReSharper project file and run it or debut it with ease.

This doesn't write your code for you. It simply generates the "Glue" API client code.


Settings editor update flaw

Issue Type: Bug
Some of the input elements in the visual Settings editor don't update their values as expected:

Current Behavior
When selecting a value using a drop-down box in the visual Settings editor, the selected value isn't used by Visual Studio Code. (Probably it's being used, but the GUI doesn't reflect that.) However, when editing another setting, the previously neglected change will be processed.
When clicking a checkbox, the value isn't updated if the checkbox doesn't already have focus.
Expected Behavior
When selecting a value using an input element in the visual Settings editor, the new value should be used and displayed immediately.

VS Code version: Code 1.63.2 (899d46d82c4c95423fb7e10e68eba52050e30ba3, 2021-12-15T09:40:02.816Z)
OS version: Windows_NT x64 10.0.19044
Restricted Mode: No
Extensions (1)

Extension
Author (truncated)
Version

vscode-language-pack-de
MS-
1.63.3

This doesn't reproduce any more. @rzhao271


Unexpected internal/minified error message

What are the steps to reproduce this issue?
Run Orval 6.10.2 or 6.10.1
What happens?
Trying to generate code from these versions results in what looks like an internal or minified error with a stack trace that isn't easy to read. As far as I can tell, our schema is fine as it generates our backend code fine and also renders in the Swagger UI fine too. Unfortunately I cannot share the schema though.
Error compiling schema, function code: const schema16 = scope.schema[10];return function validate14(data, {instancePath="", parentData, parentDataProperty, rootData=data}={}){let vErrors = null;let errors = 0;if((!(data && typeof data == "object" && !Array.isArray(data))) && (data !== null)){const err0 = {instancePath,schemaPath:"#/type",keyword:"type",params:{type: schema16.type},message:"must be object,null"};if(vErrors === null){vErrors = [err0];}else {vErrors.push(err0);}errors++;}if(data && typeof data == "object" && !Array.isArray(data)){for(const key0 in data){if(!(key0 === "keyedBy")){const err1 = {instancePath,schemaPath:"#/additionalProperties",keyword:"additionalProperties",params:{additionalProperty: key0},message:"must NOT have additional properties"};if(vErrors === null){vErrors = [err1];}else {vErrors.push(err1);}errors++;}}if(data.keyedBy !== undefined){if(typeof data.keyedBy !== "string"){const err2 = {instancePath:instancePath+"/keyedBy",schemaPath:"#/properties/keyedBy/type",keyword:"type",params:{type: "string"},message:"must be string"};if(vErrors === null){vErrors = [err2];}else {vErrors.push(err2);}errors++;}}}if(errors > 0){const emErrors0 = {"type":[]};for(const err3 of vErrors){if(((((({"str":"err3"}.keyword !== "errorMessage") && (!{"str":"err3"}.emUsed)) && ({"str":"err3"}.instancePath === instancePath)) && ({"str":"err3"}.keyword in {"str":"emErrors0"})) && ({"str":"err3"}.schemaPath.indexOf("#") === 0)) && (/^\/[^\/]*$/.test({"str":"err3"}.schemaPath.slice(1)))){{"str":"emErrors0"}[{"str":"err3"}.keyword].push({"str":"err3"});{"str":"err3"}.emUsed = true;}}for(const key1 in emErrors0){if({"str":"emErrors0"}[{"str":"key1"}].length){if(vErrors === null){vErrors = [{"str":"err4"}];}else {vErrors.push({"str":"err4"});}errors++;}}const emErrs0 = [];for(const err5 of vErrors){if(!{"str":"err5"}.emUsed){{"str":"emErrs0"}.push({"str":"err5"});}}vErrors = emErrs0;errors = {"str":"emErrs0"}.length;}validate14.errors = vErrors;return errors === 0;}D:\Work\odin\frontend\node_modules\@stoplight\spectral-core\node_modules\ajv\dist\compile\index.js:120        throw e;

What were you expecting to happen?
If there is an error in the schema, an error message that expresses the problem and where it is.
What versions are you using?
Operating System: Windows 11
Package Version: 6.10.2 and 6.10.1

Adding "ajv": "^8.11.0", as a dev dependency fixes this for some reason, not a very obvious solution 😅

Hello @Southclaws, complicated to know what caused that problem. Do you have more information?

Unfortunately not, just adding that dependency fixed the issue but it's not obvious why a missing dependency caused such a large error to appear.

Still running into this now, updated both libraries and it's not going away. I expanded the error message as it contains some minified code and it appears the code isn't valid JS:

After some investigation, this seems to be related to config. I emptied my config file and Orval ran fine, but simply adding the following causes the error:
import { defineConfig } from "orval";

export default defineConfig({})

I could not make it compile even when changing the config file to JS.
@Southclaws maybe it's an issue with our OpenAPI schema?

Can you share your open api maybe ?

@anymaniax we can't as is for a private company, and sharing it could imply a security risk.
Finally, I managed to fix this by:

upgrading orval to its latest version
deleting node_modules and yarn.lock
running yarn again

Might be one of those obscure cache/deps issues 🤷🏽♂

You can also try with the alpha version that have a lot of structure changes and fixes

I commented out the entire schema so it was just an empty schema with the bare necessities and it still happened so I don’t think it’s related to the actual schema.

Same this error only occurs when using orval from the projects node_modules.
A work around for me has been to use the global instance of orval instead of the project specific one.

Unfortunately so, I'd prefer to keep tooling versioned so future team members/contributors will always be using an expected version of code-generators. This seems like the only fix for now though.

Adding "ajv": "^8.11.0", as a dev dependency fixes this for some reason, not a very obvious solution 😅

In my situation, in addition to this, converting orval.config.js to orval.config.ts and using defineConfig like this example, fixed the error.

I think I got to the bottom of the AJV issue: https://github.com/anymaniax/orval/pull/1012

I have just updated from 6.12.1 to 6.21.0 and faced this error. I am using .ts config with defineConfig. What's the issue?


Back button on submission page

Description
The last page of PRCI, where the submit button is, has no way of going back

Intended outcome
Include a button to allow going back if the user made an error.

This is something we discussed with @jboileau99 , would it be possible technically to have a back button "remembering" which demand has last been open/modified in case of multiple demands?
If not, in case of multiple demands what do you think of the back button opening the last demand that has been created?

We'll here we are clearly in a mono-demand scenario. So in this case, it is clear.
The request with multiple demands is for later (and yes, there it would make sense to allow deleting demands, and all them to go back to first screen to make new demands).

@milstan I believe what you're describing is what the edit (pencil) button does now, when clicked it should re-open the demand with the data they entered previously. I guess this is a good indicator that it's not obvious what that button does.
In the new version, it looks like this:

The user can click the pencil + paper icon (beside 'ACCESS Demand') and that will bring them back to the demand form where they can change what they entered. What do you think of this?

It is more obvious now but I still think the user would feel like they can't go back as they are in a mono-demand scenario.
Maybe a solution could be including (next to the SUBMIT button) a button that says "CANCEL AND GO BACK TO START" that deletes all demands and lets them start from strach?
I am not sure what is the best solution, but I think as long as there is only one button in the bottom, there will be frustration.

What do you think of something like this :

having a more visible and explicit modify button + having a "Cancel Request" button at request review screen (at the demand back button place) with a warning message associated if clicked

or adding just the "Cancel Request" button at request review screen (at the demand back button place) with a warning message associated if clicked :

I like the 2

I like 2 also, thanks @Clementinev. I'll add that


update docs to use SciML website

Describe the bug 🐞
Docs don't currently appear -- they need to be updated to use the SciML website.

@ChrisRackauckas how should we set them up here to work with SciML.ai?

It's already in https://docs.sciml.ai/FiniteStateProjection/dev/?

Thanks for pointing this out, the link should now work.


feat(boilerplate): Make texts on demo components based on i18n

Please verify the following:

[x] yarn test jest tests pass with new tests, if relevant
[x] yarn lint eslint checks pass with new code, if relevant
[x] yarn format:check prettier checks pass with new code, if relevant
[x] README.md (or relevant documentation) has been updated with your changes

Describe your PR
This is a follow-up PR to cover all demo components under DemoShowroomScreen/ with i18n file. Since demos were not covered by it, my previous translation PR couldn't translate all the essential parts of the boilerplate.
@mazenchami has suggested me create demo files to adopt i18n in demo components (thanks for the guide!) so I made the change in this PR along with translations provided by @flexbox and @leonskim 🎉
recording
https://github.com/user-attachments/assets/5720a743-578d-4da4-8d07-7dae26e69f6c

@kei95 very sorry for the delay on this but here is the code for the demo-ar.ts file. once you've uploaded it, i'll do a final pass and we can merge the PR:

No problem at all! I just applied the the change so please have a look when you get a chance

@mazenchami It appears to be your demo-ar.ts is missing description property under demoListItem/useCase/icons. Would you like to translate the text below so that I can add quickly? 👀
original description: "You can customize the icons on the left or right."

@kei95 great catch. here it is: "يمكنك تخصيص الرموز على اليسار أو اليمين"

@mazenchami All tests are passing now and I believe it should be good to go now!

@kei95 sorry for the delay but merging this now. thanks for all your work on making this possible!

:tada: This PR is included in version 9.9.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Add support to for Voila - Turning Jupyter into Web Applications

https://github.com/afeiszli/jupyter-voila-extension

I have already added Voila as service and as extension


feat(procedure): enable auto split large value

I hereby agree to the terms of the GreptimeDB CLA.
Refer to a related PR or issue link (optional)
What's changed and what's your intention?

Enable auto split large value
Add max_value_size configuration to [procedure] section in metasrv.example.toml, with default value 1535KiB.
Add max_value_size to ProcedureConfig, type of Option<size> the default value is None(no max size limit).

Checklist

[ ]  I have written the necessary rustdoc comments.
[ ]  I have added the necessary unit tests and integration tests.
[x]  This PR does not require documentation updates.

@fengjiachun @evenyag PTAL


"VS Code setting - Search:Max Results" doesn't work

When "VS Code setting - Search:Max Results" is set to null (empty),  The max number of search results is not unlimited but 999.
VS Code version:

Seems to work for me. This search for 'a' in the VS Code source eventually produced an option to close the app:

Here are my search results:

We pass in undefined for the limitResultCount parameter of findMatches:
https://github.com/microsoft/vscode/blob/c8e2fd7baeaa8cd9dc43d3051db66a7428309c97/src/vs/workbench/services/search/common/searchService.ts#L449
But it gets defaulted to 999:
https://github.com/microsoft/vscode/blob/973684056e67153952f495fce93bf50d0ec0b892/src/vs/editor/common/model/textModel.ts#L1169
CC @alexdima

Sorry @rzhao271 dunno if you were working on this already


✨ Allow disabling specific rule for specific directory or file

Hi 👋🏻
I'm loving Ruff so far. Today I was writing some tests and found that I'm getting an error on the assert statement due to this rule in my tests file. I want this rule for my codebase but not for my tests. Additionally, there are some other rules that I don't want to enable in tests like magic value comparison.
For this kind of scenario, I would like to disable the rule for the specific directories.
Thanks for such a great library ❤

P.S. Thanks to the ruff I was able to identify one minor type improvement in FastAPI docs and made my first contribution 😇

Thanks for the kind words, it made my day.
Can you accomplish what you need with per-file-ignores? In your pyproject.toml, you'd typically do something like:
[tool.ruff.per-file-ignores]
"tests/**" = ["S101", "PLR2004"]


Dependency Conflict Error During Vercel Deployment (Works Locally)

Context
What's your version of nuqs?
-> "nuqs": "^2.1.1"

What framework are you using?

✅ Next.js (app router)
❌ Next.js (pages router)
❌ React SPA (no router)
❌ Remix
❌ React Router
❌ Other (please specify)

Which version of your framework are you using?
-> "next": "15.0.3"
-> "react": "19.0.0-rc-66855b96-20241106"
-> "react-dom": "19.0.0-rc-66855b96-20241106"

Description
My project is encountering a dependency conflict error during deployment on Vercel, specifically related to React versions. The project works fine locally, but fails during the Vercel build process. The error suggests a conflict between the pre-release version of React 19 we're using and the requirements of other packages, particularly nuqs and @radix-ui components.
Reproduction
Steps to reproduce the behavior:

Push changes to the connected GitHub repository
Trigger a deployment on Vercel (automatically or manually)
Observe the build fail with the following error:

npm error code ERESOLVE
npm error ERESOLVE could not resolve
npm error
npm error While resolving<EMAIL_ADDRESS>npm error Found<EMAIL_ADDRESS>npm error node_modules/react
npm error<EMAIL_ADDRESS>from the root project
npm error   peer<EMAIL_ADDRESS>|| ^17.0 || ^18.0 || ^19.0 || ^19.0.0-rc" from<EMAIL_ADDRESS>npm error   node_modules/@radix-ui/react-arrow
npm error<EMAIL_ADDRESS>from<EMAIL_ADDRESS>npm error     node_modules/@radix-ui/react-popper
npm error<EMAIL_ADDRESS>from<EMAIL_ADDRESS>npm error       node_modules/@radix-ui/react-menu
npm error<EMAIL_ADDRESS>from<EMAIL_ADDRESS>npm error         node_modules/@radix-ui/react-dropdown-menu
npm error   38 more (@radix-ui/react-avatar, @radix-ui/react-collection, ...)
npm error
npm error Could not resolve dependency:
npm error peer react@">= 18.2.0" from<EMAIL_ADDRESS>npm error node_modules/nuqs
npm error<EMAIL_ADDRESS>from the root project
npm error
npm error Conflicting peer dependency<EMAIL_ADDRESS>npm error node_modules/react
npm error   peer react@">= 18.2.0" from<EMAIL_ADDRESS>npm error   node_modules/nuqs
npm error<EMAIL_ADDRESS>from the root project

Additional context:

The project builds and runs without issues in the local development environment.
We're using a pre-release version of React 19, which seems to be the root cause of the conflict.

Any insights or suggestions on resolving this deployment-specific dependency conflict would be greatly appreciated. Thank you!

What package manager are you using? If it's pnpm, do you have the ENABLE_EXPERIMENTAL_COREPACK environment variable set on Vercel?

Npm

The peer dependency range is satisfied, the only thing I see where things may go wrong is the extra space between the >= and the version number.
Could you try this version and see if it works better please?
npm i https://pkg.pr.new/nuqs@756

The peer dependency range is satisfied, the only thing I see where things may go wrong is the extra space between the >= and the version number.
Not much hope, but could you try this version and see if it works better please?
npm i https://pkg.pr.new/nuqs@756

Thank you for your suggestion. I tried the command you provided, but unfortunately, the issue persists. Here's what happened:

I attempted to install the package using the command you suggested:

 npm i https://pkg.pr.new/nuqs@756

However, during the Vercel deployment, I still encountered an error:

npm error Could not resolve dependency:
npm error peer<EMAIL_ADDRESS>from<EMAIL_ADDRESS>npm error node_modules/nuqs
npm error   nuqs@"https://pkg.pr.new/nuqs@756" from the root project

Additionally, when trying to install the package locally, I still need to use --force or --legacy-peer-deps. Here's the error I get without these flags:

npm error Could not resolve dependency:
npm error peer react@">= 18.2.0" from<EMAIL_ADDRESS>npm error node_modules/nuqs
npm error   nuqs@"*" from the root project

Do you have a minimal reproducible repository I could deploy to Vercel to reproduce the issue on my end?

https://github.com/aeonzz/eqeon

Thanks, I managed to reproduce the issue on Vercel too, I'll let you know if I find some actionable solution.

Okay, so TIL that in SemVer, >=18.2.0 does not include RC releases, so it was indeed not covering React 19 RC.
This should fix it:
npm i https://pkg.pr.new/nuqs@63566ad3d9254fdbf1288d3f66aeecc65d8f06d9

Okay, so TIL that in SemVer, >=18.2.0 does not include RC releases, so it was indeed not covering React 19 RC.
This should fix it:
npm i https://pkg.pr.new/nuqs@63566ad3d9254fdbf1288d3f66aeecc65d8f06d9

this works Thanks!!


Refactor in preparation to sharing wizard

Refactored webappcreator to be more generic so it can be used to create function apps, too.  Doing this before pulling it out into the shared repo to make it easier to understand the changes (and kept previous filename for the same reason, will change afterwards).

Unfortunately they are:
<EMAIL_ADDRESS>However, most of them probably are understandable, so I’m fine removing it.
From: Eric Jizba<EMAIL_ADDRESS>Sent: 23 October, 2017 11:49 AM
To: Microsoft/vscode-azureappservice<EMAIL_ADDRESS>Cc: Stephen Weatherford<EMAIL_ADDRESS>Assign<EMAIL_ADDRESS>Subject: Re: [Microsoft/vscode-azureappservice] Refactor in preparation to sharing wizard (#141)
@EricJizbaMSFT commented on this pull request.

In src/webAppCreator.tshttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FMicrosoft%2Fvscode-azureappservice%2Fpull%2F141%23discussion_r146359159&data=02|01|Stephen.Weatherford%40microsoft.com|34d1ec156f7d4e7c025608d51a46bc2e|72f988bf86f141af91ab2d7cd011db47|1|0|636443813461652991&sdata=%2BLROTYZiqW3wkrII2ogrteahaHyRUgS391W4jm57Jdk%3D&reserved=0:

@@ -402,11 +412,23 @@ class AppServicePlanStep extends WebAppCreatorStepBase {

 }

}
-class WebsiteStep extends WebAppCreatorStepBase {
+interface WebsiteStepResources {

title: string;    // like "Create Web App"

'Web App' or 'Function App' are product names - so I don't think they would be localized anyway
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHubhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FMicrosoft%2Fvscode-azureappservice%2Fpull%2F141%23discussion_r146359159&data=02|01|Stephen.Weatherford%40microsoft.com|34d1ec156f7d4e7c025608d51a46bc2e|72f988bf86f141af91ab2d7cd011db47|1|0|636443813461652991&sdata=%2BLROTYZiqW3wkrII2ogrteahaHyRUgS391W4jm57Jdk%3D&reserved=0, or mute the threadhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAGl9SpYm_q961IrDPidn3qRclemyM-yOks5svN-ggaJpZM4QBZpQ&data=02|01|Stephen.Weatherford%40microsoft.com|34d1ec156f7d4e7c025608d51a46bc2e|72f988bf86f141af91ab2d7cd011db47|1|0|636443813461652991&sdata=WLtNZE4oUy9AolH5ayu7%2FRcwcyXSG8adm7ug120inpU%3D&reserved=0.


creationParameter.loadConfigStack: Required lm studio - Version 0.2.26 (0.2.26)

W [LMStudioClient][LLM][ClientPort] Received communication warning from the server: Received invalid creationParameter for channel, endpointName = loadModel, creationParameter = {"path":"bartowski/gemma-2-9b-it-GGUF","identifier":"my-model","config":{"contextLength":1024,"gpuOffload":"max"},"noHup":true}. Zod error:

creationParameter.loadConfigStack: Required

Thanks @MaatheusGois should be resolved in 0.2.27 now available on https://lmstudio.ai


Convert parsed comments into usable format

As we will deal with a returned AST from the parser we will need some functional love to play with all those data, I suggest we may go with lodash or Ramda (lodash-fp could be a nice in between choice). Thoughts?

After digging tonight, some possibility emerged. It seems that instead of building our own pattern-matching / data extrication helper, we could play with some of the following and/or search for more:

https://github.com/laktek/extract-values
https://github.com/princejwesley/extractjs


feat: make getBaseUrl and fetchDecode methods public

Closes #836
:heavy_check_mark: Checklist

[ ] Added tests for new functionality and regression tests for bug fixes
[x] Added changeset (run yarn changeset in the root)
[ ] Screenshots of before and after attached (for UI changes)
[ ] Added or updated documentation (if applicable)

@iain-b any thoughts? I believe you originally made them private.


fix: remove opacity scroll wheel interaction

So currently the scroll wheel interaction on the opacity slider can cause some really jarring stuff to happen when you need to scroll down the action bar.

This means you don't notice that the opacity got changed, just that your element is suddenly invisible.
The problem stems from the fact that React just doesn't handle wheel event properly, you cant just event.stopPropagation(). It doesn't stop the scroll behaviour from propagating to the parent element.
https://github.com/facebook/react/issues/14856
Rather than pursuing some hacky solution involving binding an event listener to the action panel that prevent's the scroll wheel behaviour only when the slider is active, it probably makes more sense to just remove the scroll wheel interaction.
https://www.loom.com/share/b94639a2f67d46438f64799ec4755551

Ok, I completely forgot we were adding a handler for this (it goes back to almost the very beginning of the project https://github.com/excalidraw/excalidraw/pull/662). I'm fine with removing this as the potential UX benefits outweigh the costs.


Could you  update your mother as well? As soon as I enter the software, it asks me to update. I just won’t update, sun of beach

please learn how to speak like a human


What's the accuracy of deit-S without pre-trained on CIFAR10

Hi,
What's the accuracy of deit-S without pre-trained on CIFAR10? Mine is only 63.2. Would you like to told me yours? And my hyper-parameters follow this linkhttps://github.com/facebookresearch/deit/issues/45#issuecomment-765213622
Thanks.

Hi @hanwenran1 ,
It's 98.5%.
Best regards,
Hugo


cannot find tag 1.0.0

Hi,
I cannot find commit tagged as 1.0.0 in git log
$ git show 1.0.0
warning: refname '1.0.0' is ambiguous.
commit f412899a85dd418be67a79dca1ceaa50cec97b49 (tag: 1.0.0)
Author: shimizukawa<EMAIL_ADDRESS>Date:   Sun May 12 17:52:50 2019 +0900

    fix broken url

diff --git a/README.rst b/README.rst
index 0696fad..ff38bf3 100644
--- a/README.rst
+++ b/README.rst
@@ -45,4 +45,4 @@ Licensed under the BSD license.
 CHANGES
 =======

-See: https://github.com/sphinx-doc/sphinx-intl/blob/master/CHANGES
+See: https://sphinx-intl.readthedocs.io/en/master/changes.html
\ No newline at end of file

However, there's no commit f412899a85dd418be67a79dca1ceaa50cec97b49 in git log.

@shimizukawa It seems 1.0.0 tag is not on master branch. Can I merge the tag into master branch?
https://github.com/sphinx-doc/sphinx-intl/tree/1.0.0

Sorry, I forgot to push.
Now fixed that.


Union County, NJ

Edward Oatman, County Manager
10 Elizabethtown Plaza
Elizabeth, NJ 07202
Phone:<PHONE_NUMBER>
<EMAIL_ADDRESS>Dear Mr Oatman,
My name is [YOUR NAME], resident of Union County.  In light of the Black Lives Matter movement, I am writing to request that your budget for next year prioritizes community well-being and redirects funding away from law enforcement and corrections facilities to continue to disproportionately target Black Americans and other minorities.
The 2020 budget allocated more than $33 million towards the police and sheriff departments and a further $38.5 million for juvenile and adult corrections facilities. Rather than spending over $70 million annually for punishing criminals, please consider cutting some of this budget to address some of the issues that cause criminality.
For instance, this year’s budget left room for only $887,232 to Youth Services, £1.3 million to Family Support services, £313,373 for Employment & Training, and only £190,000 for a Scholarship Program.  This is only $2.7 million total, less than 4% of the budget spent towards policing and corrections. Furthermore, the $1.7 million that was available for Social Services to the Homeless in 2019 seems to be completely taken out of the budget for 2020, a year where it was likely very much needed due to unprecedented unemployment rates.
I, as your constituent, urge you to take a closer look at what Union County can do to mitigate the harm that has been caused by the over policing of minorities throughout the years and become a leader in creating a community where residents have resources available to them to break the systemic cycle of poverty and criminality that has been the norm for so many years.
Thank you for your time,
[YOUR NAME]
[YOUR ADDRESS]
[YOUR EMAIL]
[YOUR PHONE NUMBER]

Figures from https://ucnj.org/wp-content/uploads/2020/05/2020-Adopted-Budget.pdf

Thank you for submitting your city to defund12.org! Your request is now in the queue for review and publishing. We’ll reply here if we have any questions.

Editing notes: I added city council members' and mayor's emails, formatted accordingly, and updated a couple of figures (thank you for providing a link!). I was more specific with phrasing around minority groups. This was well-written and compelling! Thank you for contributing.
To<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>Subject: [*** INSERT UNIQUE SUBJECT LINE ***]
Message: (Don't forget to replace the [x]'s with your information!)
Dear Mayor Bollwage and City Council,
My name is [YOUR NAME], resident of Union County. In light of the Black Lives Matter movement, I am writing to request that your budget for next year prioritizes community well-being and redirects funding away from law enforcement and corrections facilities that continue to disproportionately target Black, Brown, and Indigenous Americans and other minorities.
The 2020 budget allocated more than $33 million towards the police and sheriff departments and a further $39.2 million for juvenile and adult corrections facilities. Rather than spending over $70 million annually for punishing criminals, please consider cutting some of this budget to address some of the issues that cause criminality.
For instance, this year’s budget left room for only $887,323 to youth services, $1.3 million to family support services, $313,373 for employment and training, and only $190,000 for a scholarship program. This is only $2.7 million in total, less than 4% of the budget spent on policing and corrections. Furthermore, the $1.7 million that was available for social services to the homeless in 2019 seems to be completely taken out of the budget for 2020, a year where it was likely very much needed due to unprecedented unemployment rates.
I, as your constituent, urge you to take a closer look at what Union County can do to mitigate the harm that has been caused by the over-policing of minorities throughout the years, and become a leader in creating a community where residents have resources available to them to break the systemic cycle of poverty and oppression that has been the norm for so many years.
Thank you for your time,
[YOUR NAME]
[YOUR ADDRESS]
[YOUR EMAIL]
[YOUR PHONE NUMBER]

on it

I am unsure about the phrasing of "Rather than spending over $70 million annually for punishing criminals, please consider cutting some of this budget to address some of the issues that cause criminality." as it still uses language that to me seems rooted in the context of policing, is there another way we could put this?