Summon doesn't attach to psql correctly

Launching a subprocess with summon that has flags that summon also has causes summon to fail.
Example:
summon psql -p 7432 -h conjur -U postgres

summon and psql both use the -p flag. summon doesn't know this is a flag for the psql process. This needs to be fixed.

I like "summon -- cmd"
On Thu, May 19, 2016 at 10:41 AM Dustin Collins<EMAIL_ADDRESS>wrote:

Launching a subprocess with summon that has flags that summon also has
causes summon to fail.
Example:
summon psql -p 7432 -h conjur -U postgres
summon and psql both use the -p flag. summon doesn't know this is a flag
for the psql process. This needs to be fixed.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub
https://github.com/conjurinc/summon/issues/28

summon -- cmd makes sense to me, too. The -- should probably be optional, only required if the subcommand needs an overlapping flag.

It does and it's simple to implement, though OTOH perhaps it should just not parse arguments that come after the command (ie. first non-flag) at all.

After looking into this it's not a problem with argument, but rather with psql itself. Docker works correctly, for example. Need to investigate more what is different about attaching to psql.

I'm just going to close this. I haven't run into this in over a year. Someone will create another issue if there is indeed a problem.

Or reopen.
BTW, I don't think wontfix label applies here: it's for where a problem is acknowledged and identified but the decision is not to fix. Ok to remove?

All set, thanks Rafal!
We'll leave this issue closed for now, can always reopen it if needed.


CreateUiDefinition - NestedTemplates - Outputs Must Be Present In Template Parameters - Requires un-needed parameters

As there are a few files involved i have created a Gist to help out -> https://gist.github.com/stephenpope/790a88595efa698e70cd73c31e476084
Setup
I have a simple bicep structure a main file with two modules (that create nested templates) ..
main.bicep
  another.bicep
  yetanother.bicep

these can be built into a azuredeploy.json with bicep build main.bicep --output azuredeploy.json
There is also createUiDefinition.json .. this has two textboxes which have outputs defined as oneParameter + twoParameter to match the input params of the azuredeploy script.
Error
The script shows errors even though oneParameter and twoParameter are defined in the main.bicep file (and appear in the main parameters section in the json).
//filename: main.bicep
param oneParameter string = 'defaultValue'
param twoParameter string = 'anotherValue'
//<snip>

NestedTemplate my-thing my-thing my-other-thing my-other-thing [ Lines 44 - 74 ]
  [-] Outputs Must Be Present In Template Parameters (21 ms)
      output oneParameter does not exist in template.parameters
      output twoParameter does not exist in template.parameters
      output oneParameter does not exist in template.parameters
      output twoParameter does not exist in template.parameters

Discussion
These parameters are not defined in the nested modules because they are not needed. The nested modules have their own parameters.
This seems like an error in working out the constraints (unless I am mistaken :)

It looks like the current PR #535 touches on the same case.
If a test has parameters that indicate it was a maintemplateobject, those parameters should be cleared.  If any of them were required, the test should be skipped (quietly).
e.g. if there was a test requring MainTemplateObject, it should not run when evaulating inner templates of the mainTemplateObject.
Skipping of tests can be indicated with Write-Verbose, but would be too noisy otherwise.

We should back out some of the changes to $TemplateObject if #535 is merged, once a fix for this bug is available.

I have noticed with the latest version (2021.11.05) it thinks secure param values are required in nestedTemplates. So if I have a nested template (module in bicep) with..
@secure()
@description('Specifies the SSH RSA public key string for the Linux nodes.')
param aksClusterSshPublicKey string

.. results in ..
NestedTemplate ...
    [-] Parameters Without Default Must Exist In CreateUIDefinition (80 ms)
        aksClusterSshPublicKey does not have a default value, and is not defined in CreateUIDefinition.outuputs

.. but obviously putting a default value in a secure valueis not allowed.
It should probably skip this check like it does in other parts.
I can raise a separete bug for this if you think its necessary. Thanks for all your work with this :)

@stephenpope - can you go ahead and open a new bug for your new case?


Added: Add ProgressBar component

Introduce a new ProgressBar component that allows customization of properties and styles. Enhance the associated stories with decorators for improved visualization.
The component is not yet configured to be used in the AppBar as it kind of depends on the technical approach we want to take with regards to the content. See also the related issue of #1334

Nice! As we'll typically have max values around 5-10 (i.e., different questions or experiments), I wonder whether percentage is all that useful to have. It's nice to have, but it should be disabled by default.

I'll remove it since we will most likely only use the progress bar in this location. If we need it in the future it's easy to add, but for now it means a feature that we would need to maintain.


Add extension signature verification service

Progress on https://github.com/microsoft/vscode/issues/162284.
This change adds a new service (IExtensionSignatureVerificationService) which will verify signed extensions installed from Visual Studio Marketplace.  Unsigned extensions will skip verification.  The actual signature verification engine is not included in this PR.  Verification is behind a feature flag, which is disabled by default.
This change also modifies existing install/update telemetry to include:

isSigned:  a boolean value indicating whether or not the extension is signed
wasVerified:  a boolean value indicating whether or not signature verification succeeded
errorcodeDetails:  a string value indicating the signature verification error, if available

CC @isidorn, @joaomoreno, @sandy081

@dtivel Went through the PR and updated with following changes

Moved extension signing verification to ExtensionsDownloader. This is needed because of the following scenario: When VS Code desktop client is connected to a remote server (WSL, SSH, Remote Containers, Codespaces), there is an option to download extensions locally that users can enable while installing extensions. When this option is enabled, extensions are downloaded locally (on the client side) and downloaded VSIXs are streamed to the remote side to install. We have to verify the signature of downloaded VSIXs during this scenario. To support this, I exposed download API on IExtensionManagementService that will download and verify the VSIX. Please refer to following code that uses this:

https://github.com/dtivel/vscode/blob/3b491952fa1096fce02dca5f27b157cbca2f5726/src/vs/workbench/services/extensionManagement/electron-sandbox/remoteExtensionManagementService.ts#L120

In addition, did some clean ups and updated/fixed the unit tests according to the above change.

Can you please test if the feature is working with new changes? Once confirmed, I will merge changes to main.

@sandy081, I pushed 1 commit for a bug I found.  Otherwise, the latest changes look good.  Thanks so much for your review and for putting the PR in good shape.


Inquiry on Proxy Configuration within Your Project

Dear,
I hope this message finds you well.
I am writing to express my sincere appreciation for the outstanding work on your project. It has been an incredibly useful tool for our operations and I must commend you on the quality and functionality it provides.
However, I have encountered a query that I am hoping you can assist me with. I am looking to configure a proxy IP for our use within the project. Specifically, I need to set up an HTTP proxy with the following credentials: http://username:password@host:port.
Could you please guide me on how to modify the configuration file within your project so that all system requests are routed through this proxy?
Your prompt response would be greatly appreciated, and I am looking forward to your expert advice.
Best regards

find way~


Set I18n.locale=:zh_CN not working

I type following code reference from Padrino localization document:
I18n.default_locale = :en

Padrino.before_load do
  I18n.locale = 'zh_cn'
end

When i use Chrome, The result of language setting:

navigator.language
"zh-CN"
navigator.languages
["en", "zh", "zh-CN"]

When i restart server and refresh page, i can't see any Chinese words; I have been trying to set I18n.enforce_available_locales to true/false, it still doesn't work;
[Another article on Stackoverflow](Another article) says use padrino-contrib, the results same of above

I don't know what reason, because we only support two language environment(en, zh)，so i hard coded in the before filter
locales = request.env['HTTP_ACCEPT_LANGUAGE'] || 'en'
if locales.start_with? 'zh'
  I18n.locale = 'zh_cn'
else
  I18n.locale = 'en'
end

request.env['HTTP_ACCEPT_LANGUAGE'] may by nil

I think you should set I18n.default_locale in app's before filter:
# in [appname]/app.rb
before do
  # I18n.default_locale = 'zh_cn'
  I18n.default_locale = params[:lang]
end

@cookiebody Yes, it's necessary
Above problem I wrote just want to auto detect browser's or system's language setting to choose a locale between zh and en

Because I think this problem

I guess this issue may be it can't compatible with a variety of Chinese locale string
Like zh, zh_CN, zh-CN

zh-CN is the proper naming. https://tools.ietf.org/html/rfc5646
Locale file should be named like that zh-CN.yml.
Adding this locale to available locales should be like this: I18n.available_locales = ['en', 'zh-CN'] or through listing locales directory and parsing the result.
I18n selecting this locale should be like this: I18n.locale = 'zh-CN'.

FWIW under 0.12.6 putting this in boot.rb:
Padrino.before_load do
  I18n.locale = :de
end

Will only set the locale for the first few requests (using WEBrick). Future requests fallback to using whatever is in default_locale.
This does not seem to be a problem under 0.13.1.


Transpile all .ts files

This is similar to https://github.com/atom/atom/pull/5299
Provide TypeScript support to ease package development.
Motivation

Provides built in support for sourcemaps
No longer need to check in .js files when creating packages using TypeScript

Sample
You can see a sample package here : https://github.com/basarat/atom-typescript-test

same as other PR
global.require('../src/typescript/').getCacheHits()
global.require('../src/typescript/').getCacheMisses()

TODO:

[x] Add transpiling support
[x] Add tests

/cc @vvakame @csnover

How does cross-compiling with TypeScript work when tsc has to have every file in the project to compile a file? (i.e. TypeScript by-design isn't a simple 1:1 mapping unlike Babel or CoffeeScript, to compile input file X, you need the type definitions of all the types it uses including the other files in the project).

cross-compiling with TypeScript work when tsc has to have every file in the project

Not essentially. Consider
foo.ts
var foo = 123;
export = foo;

bar.ts
import foo = require('./foo');
console.log(foo); // 123

Each file can be compiled on its own. However file bar in the absence of type information of foo despite being syntactically valid, is semantically invalid. It would be semantically valid only if it had reliable information about foo.ts. However the TypeScript compiler doesn't block JS emit in the presence of semantic errors.
I have semantic validation disabled by passing false here : https://github.com/atom/atom/pull/5898/files#diff-1bb8c8dc24534560f9903363ebb9a332R97

Also, call sites in TypeScript do not rely on source type information. So absence of type information does not change the emit. This is by design.

@paulcbetts I've just pushed a multifile demo : https://github.com/basarat/atom-typescript-test/commit/1dfe56bdc6bf51c867b6bb706086ff11650e165b
The files are compiled separately (in the absence of type information about the other files) and still work :

@basarat Aha, now it makes sense. It'd be cool to start making a more generalized framework for loading cross-compilers, because they're going to start hurting startup time and require perf (and hurting require perf is pretty bad, though in the TypeScript case it's a very quick "Does file end in .ts" check)

hurting require perf is pretty bad

In general hurting require perf even a little is gonna run counter to this goal (and the 1.0 goal of reducing startup time) in a big way and will need the most convincing of justifications: https://github.com/atom/atom-shell/issues/169

@thedaniel I think this can probably be pretty easily done, since these require hooks are so easy to register. We just put it off until we find typescript files

:+1: https://discuss.atom.io/t/how-to-use-the-npmignore/9208/6
https://github.com/vvakame/language-review/tree/master/lib I want to ignore compiled .js code.

Also I couldn't get sourcemaps to work because of fancy JS wrapping : https://github.com/TypeStrong/atom-typescript/pull/156#issuecomment-77518310
Note: I can get them to work with more custom code but I'd rather atom do it for me + any other TS package authors.

@basarat So is this something that is ready to review? Or did you still have any planned changes left?

Could you add some tests for this as well? You can model them after the babel specs.

@kevinsawicki was ready for review. I'll add the tests tonight and ping you.

@kevinsawicki ready for review. Also updated (and marked as completed) the todo list :heart:

@kevinsawicki ready for review again. Did:

[x] didn't need jasmine.snapshotDeprecations() so removed
[x] The js file was there as a PR was pending. Since been merged so depending on the library typescript-simple directly. So js file removed.
[x] ran script/grunt lint zero errors.

Also I'm now using JSON.stringify. Don't see why that wasn't used for babel.

@kevinsawicki done:

[x] remove typescript dependency as it is not required explicitly

Thanks for making all these updates, this feels like it is getting really close.
One thing I thought of those was this should be added to the compile-cache helper class that is called directly by apm: https://github.com/atom/atom/blob/11a5b71fb3446ab6eda023fc6606d7509597f71c/src/compile-cache.coffee#L26
And also to https://github.com/atom/atom/blob/11a5b71fb3446ab6eda023fc6606d7509597f71c/spec/compile-cache-spec.coffee#L10

compile-cache is called directly by apm when apm install is run so that the cache is populated before the package is loaded in Atom so installed packages don't slowdown startup when they are first installed.

@kevinsawicki done:

[x] add TypeScript to the compile-cache + compile-cache-spec

Thanks @basarat, this looks really nice.
Just chiming in, as @basarat mentioned TypeScript errors do not block the generation of JavaScript. we have always thought of the type check errors as warnings that the compiler provides the developer at design time but do not block the rest of the tool chain.
In general TypeScript does not have emit that depends on global program optimizations, we have steered away from these for the most part. So in Atom's context it should be safe to use typescript as a single file transpiler without loosing correctness. For completeness sake, there are
two places where the compiler relies on the full program information to direct emit, 1. TypeScript internal modules (this is not relevant in atom's case everything is treated as node modules) and 2. use of const enums from .d.ts files (for this i have created an issue to ensure that there is an API interface that handles these correctly).
We would like to also add new API for single file transpilation, making typescript-simple's life much simpler (no pun intended :)); and to ensure this scenario is well supported in the future.
It is really nice to see TypeScript plugins in Atom. can not wait to try writing one myself!

Awesome, thanks so much for adding this :ship:

:heart: can't thank you enough for this.

We would like to also add new API for single file transpilation, making typescript-simple's life much simpler (no pun intended :)); and to ensure this scenario is well supported in the future.

Awesome! I'm waiting.


Micork8s not running, stop/start does not fix, inspection report attached.

Hey,
We are a team developing a software that can be hosted by customer, recently one of them suddenly run into issues that the microk8s stopped working and then everything else stopped working.
Attached is the result of microk8s.inspection, can you please help take a look and help us understand:

Why did the issue happen?
How can we fix it?

More context, we got hundreds of customers for the software in couple of months and looking forward to getting thousands in the coming year, it will be super helpful for us to find out the root cause.
Let us know if anything else is needed.
inspection-report-20211201_005255.tar.gz

Hi @zhaminglei,
Can you perform ls -al /var/snap/microk8s/current/var/kubernetes/backend and paste the contents here?
Will need to investigate how this can happen.

@zhaminglei in the logs I see a lot of entries like this one:
Nov 05 06:19:27 ip-172-31-34-53 microk8s.daemon-kubelite[517731]: E1105 06:19:27.547333  517731 cacher.go:419] cacher (*unstructured.Unstructured): unexpected ListAndWatch error: failed to list cert-manager.io/v1alpha2, Kind=Certificate: conversion webhook for cert-manager.io/v1, Kind=Certificate failed: Post "https://cert-manager-webhook.cert-manager.svc:443/convert?timeout=30s": service "cert-manager-webhook" not found; reinitializing...
Nov 05 06:19:27 ip-172-31-34-53 microk8s.daemon-kubelite[517731]: E1105 06:19:27.567782  517731 cacher.go:419] cacher (*unstructured.Unstructured): unexpected ListAndWatch error: failed to list acme.cert-manager.io/v1beta1, Kind=Order: conversion webhook for acme.cert-manager.io/v1, Kind=Order failed: Post "https://cert-manager-webhook.cert-manager.svc:443/convert?timeout=30s": service "cert-manager-webhook" not found; reinitializing...
Nov 05 06:19:27 ip-172-31-34-53 microk8s.daemon-kubelite[517731]: E1105 06:19:27.568581  517731 cacher.go:419] cacher (*unstructured.Unstructured): unexpected ListAndWatch error: failed to list cert-manager.io/v1beta1, Kind=Certificate: conversion webhook for cert-manager.io/v1, Kind=Certificate failed: Post "https://cert-manager-webhook.cert-manager.svc:443/convert?timeout=30s": service "cert-manager-webhook" not found; reinitializing...

Is this something expected?
The disk performance is also not great. We regularly see write requests taking longer than 0.5secs reaching up to a couple of seconds. For example:
Nov 05 06:19:36 ip-172-31-34-53 microk8s.daemon-kubelite[517731]: Trace[1488074176]: ---"Transaction committed" 2617ms (06:19:00.438)
Nov 05 06:19:36 ip-172-31-34-53 microk8s.daemon-kubelite[517731]: Trace[1488074176]: [2.625206753s] [2.625206753s] END

Is this a multi-node cluster?

@MathieuBordere
Here you ago.
-rw-rw---- 1 root microk8s  8379032 Nov  5 06:10<PHONE_NUMBER>684859-0000000006685125
-rw-rw---- 1 root microk8s  8360384 Nov  5 06:11<PHONE_NUMBER>685126-0000000006685418
-rw-rw---- 1 root microk8s  8370248 Nov  5 06:12<PHONE_NUMBER>685419-0000000006685677
-rw-rw---- 1 root microk8s  6772784 Nov  5 06:13<PHONE_NUMBER>685678-0000000006686150
-rw-rw---- 1 root microk8s  8384832 Nov  5 06:14<PHONE_NUMBER>686151-0000000006686441
-rw-rw---- 1 root microk8s  4819520 Nov  5 06:15<PHONE_NUMBER>686442-0000000006686575
-rw-rw---- 1 root microk8s  8363808 Nov  5 06:17<PHONE_NUMBER>686576-0000000006686859
-rw-rw---- 1 root microk8s   222200 Nov  5 06:18<PHONE_NUMBER>686860-0000000006686867
-rw-rw---- 1 root microk8s  8355024 Nov  5 06:19<PHONE_NUMBER>686868-0000000006687143
-rw-rw---- 1 root microk8s  8360024 Nov  5 06:20<PHONE_NUMBER>687144-0000000006687374
-rw-rw---- 1 root microk8s  8386664 Nov  5 06:21<PHONE_NUMBER>687375-0000000006687633
-rw-rw---- 1 root microk8s  8374856 Nov  5 06:23<PHONE_NUMBER>687634-0000000006687899
-rw-rw---- 1 root microk8s  8379320 Nov  5 06:23<PHONE_NUMBER>687900-0000000006688455
-rw-rw---- 1 root microk8s  8362256 Nov  5 06:23<PHONE_NUMBER>688456-0000000006689059
-rw-rw---- 1 root microk8s  8380256 Nov  5 06:23<PHONE_NUMBER>689060-0000000006689628
-rw-rw---- 1 root microk8s  8387024 Nov  5 06:23<PHONE_NUMBER>689629-0000000006690234
-rw-rw---- 1 root microk8s  8386808 Nov  5 06:23<PHONE_NUMBER>690235-0000000006690837
-rw-rw---- 1 root microk8s  8381264 Nov  5 06:23<PHONE_NUMBER>690838-0000000006691420
-rw-rw---- 1 root microk8s  8387600 Nov  5 06:23<PHONE_NUMBER>691421-0000000006691977
-rw-rw---- 1 root microk8s  8387456 Nov  5 06:23<PHONE_NUMBER>691978-0000000006692532
-rw-rw---- 1 root microk8s  3103472 Nov  5 06:25<PHONE_NUMBER>692533-0000000006692715
-rw-rw---- 1 root microk8s  3203232 Nov  5 06:27<PHONE_NUMBER>692716-0000000006692859
-rw-rw---- 1 root microk8s  5179344 Nov  5 06:29<PHONE_NUMBER>692860-0000000006693032
-rw-rw---- 1 root microk8s  6892992 Nov  5 06:32<PHONE_NUMBER>693033-0000000006693294
-rw-rw---- 1 root microk8s  8373384 Nov  5 06:35<PHONE_NUMBER>693295-0000000006693597
-rw-rw---- 1 root microk8s  5544488 Nov  5 06:35<PHONE_NUMBER>693598-0000000006693768
-rw-rw---- 1 root microk8s     1874 Oct 29 04:19 cluster.crt
-rw-rw---- 1 root microk8s     3272 Oct 29 04:19 cluster.key
-rw-rw---- 1 root microk8s       63 Nov  5 06:36 cluster.yaml
-rw-rw-r-- 1 root microk8s        2 Nov 30 23:43 failure-domain
-rw-rw---- 1 root microk8s       57 Oct 29 04:20 info.yaml
srw-rw---- 1 root microk8s        0 Nov  5 06:32 kine.sock
-rw-rw---- 1 root microk8s       63 Nov  5 06:32 localnode.yaml
-rw-rw---- 1 root microk8s       32 Oct 29 04:20 metadata1
-rw-rw---- 1 root microk8s  8388608 Nov  5 06:36 open-3
-rw-rw---- 1 root microk8s  8388608 Nov  5 06:35 open-4
-rw-rw---- 1 root microk8s  8388608 Nov  5 06:35 open-5
-rw-rw---- 1 root microk8s 10757891 Nov  5 06:23 snapshot-1-6691864-274966167
-rw-rw---- 1 root microk8s       72 Nov  5 06:23 snapshot-1-6691864-274966167.meta
-rw-rw---- 1 root microk8s 10954465 Nov  5 06:27 snapshot-1-6692888-275205515
-rw-rw---- 1 root microk8s       72 Nov  5 06:27 snapshot-1-6692888-275205515.meta

@zhaminglei in the logs I see a lot of entries like this one:
Nov 05 06:19:27 ip-172-31-34-53 microk8s.daemon-kubelite[517731]: E1105 06:19:27.547333  517731 cacher.go:419] cacher (*unstructured.Unstructured): unexpected ListAndWatch error: failed to list cert-manager.io/v1alpha2, Kind=Certificate: conversion webhook for cert-manager.io/v1, Kind=Certificate failed: Post "https://cert-manager-webhook.cert-manager.svc:443/convert?timeout=30s": service "cert-manager-webhook" not found; reinitializing...
Nov 05 06:19:27 ip-172-31-34-53 microk8s.daemon-kubelite[517731]: E1105 06:19:27.567782  517731 cacher.go:419] cacher (*unstructured.Unstructured): unexpected ListAndWatch error: failed to list acme.cert-manager.io/v1beta1, Kind=Order: conversion webhook for acme.cert-manager.io/v1, Kind=Order failed: Post "https://cert-manager-webhook.cert-manager.svc:443/convert?timeout=30s": service "cert-manager-webhook" not found; reinitializing...
Nov 05 06:19:27 ip-172-31-34-53 microk8s.daemon-kubelite[517731]: E1105 06:19:27.568581  517731 cacher.go:419] cacher (*unstructured.Unstructured): unexpected ListAndWatch error: failed to list cert-manager.io/v1beta1, Kind=Certificate: conversion webhook for cert-manager.io/v1, Kind=Certificate failed: Post "https://cert-manager-webhook.cert-manager.svc:443/convert?timeout=30s": service "cert-manager-webhook" not found; reinitializing...

Is this something expected?
The disk performance is also not great. We regularly see write requests taking longer than 0.5secs reaching up to a couple of seconds. For example:
Nov 05 06:19:36 ip-172-31-34-53 microk8s.daemon-kubelite[517731]: Trace[1488074176]: ---"Transaction committed" 2617ms (06:19:00.438)
Nov 05 06:19:36 ip-172-31-34-53 microk8s.daemon-kubelite[517731]: Trace[1488074176]: [2.625206753s] [2.625206753s] END

Is this a multi-node cluster?

Thanks a lot,
For your questions:
We had cert-manager running fine on top of microk8s before it stopped working. I don't think Cert-manager is the issue because we have hundreds of other customers running the system pretty well. Is there anything we can check now to confirm any guess you have?
For disk performance, we are using AWS t3.large with EBS storage, same situation that it works fine for other customers as well.
And it is not multi-node cluster.
Thanks a lot again, let us know if any other info we can provide!

Thanks @benlinyb
Can you:

stop microk8s, make sure it's not running
make a backup of /var/snap/microk8s/current/var/kubernetes/backend
delete open-3, open-4, open-5 and<PHONE_NUMBER>693598-0000000006693768
try to start again.


Split repos

As can be seen, basically all of this change set is just moving files around.
This moves out all the packages in the packages folder into their own repos, and uses the content of the contracts package to morphs this repo into a contracts repo.

Can you describe what the changes were that you made? Hard to see in the changes tab

^ Oops

@mvanderh updated the description

Note that no explicit yarn linking happens here. The packages that were under the monorepo are now referenced via git repos.

Update the .gitignore

yarn clean doesn't work anymore

Does this block merging PRs? Specifically thinking of https://github.com/counterfactual/counterfactual/pull/12

@IIIIllllIIIIllllIIIIllllIIIIllllIIIIll Actually yeah, since this PR will move to https://github.com/counterfactual/apps

@IIIIllllIIIIllllIIIIllllIIIIllllIIIIll ignore what I said about having to move PR #12 - that should only require a slight modification as apps will still reside in this repo alongside the contracts


Merge back Epic Branch

Critical Changes
Changes
Capturing changes from May 2022 sprint including moving page layout changes into project specific layouts and retrieved custom fields on products.
Issues Closed

Beside several stuff from @selfuntitled this PR includes the following user stories:
Easily surface dangling Membership records #27
Add page layouts to package and Membership App #63


Hot reload / Fast refresh is not working

To reproduce:

Clone this repo
yarn install && yarn dev
Make a change in one of the react components
You will not see any change propagated on localhost:3000

I would have to stop the server and do yarn dev to see the change.
Is this related to a "bad" import? See https://stackoverflow.com/q/61033562/4191951.

Will close.
This is my fault.
I tried to reproduce the issue on a different machine and it did not work.
All I had to do was restart my laptop.
Apologies for the inconvenience.


Nuget restore fails on Ubuntu-20.04 with ImageVersion 20220529.1

Description
The same dotnet code, which targets net6.0 worked when it was on the previous image 20220515.1 (which I had a build that passed a week ago) and fails on the newly release image 20220529.1 with a build that ran today.  It is somehow defaulting to net5.0, which make sense that it fails.  The pipeline is using Nuget version 6.2.0.  The only workaround that I was able to use to get it to work was to use the UseDotNet@2 task and force it to use version 6.0.x
Error message:
/usr/bin/mono /opt/hostedtoolcache/NuGet/6.2.0/x64/nuget.exe restore /home/vsts/work/1/s/xxxxx.sln -Verbosity Detailed -NonInteractive -ConfigFile /home/vsts/work/1/Nuget/tempNuGet_42628.config
NuGet Version: <IP_ADDRESS>
MSBuild auto-detection: using msbuild version '15.0' from '/usr/lib/mono/msbuild/15.0/bin'. Use option -MSBuildVersion to force nuget to use a specific version of MSBuild.
MSBuild P2P timeout [ms]: 120000
/usr/bin/msbuild "/tmp/NuGetScratch/fk6blu2e.geo.nugetinputs.targets" /t:GenerateRestoreGraphFile /nologo /nr:false /v:q /p:NuGetRestoreTargets="/tmp/NuGetScratch/gok36zzu.a0w.nugetrestore.targets" /p:RestoreUseCustomAfterTargets="True" /p:RestoreTaskAssemblyFile="/opt/hostedtoolcache/NuGet/6.2.0/x64/nuget.exe" /p:RestoreSolutionDirectory="/home/vsts/work/1/s/" /p:RestoreConfigFile="/home/vsts/work/1/Nuget/tempNuGet_42628.config" /p:SolutionDir="/home/vsts/work/1/s/" /p:SolutionName="xxxx" /p:RestoreBuildInParallel="False" /p:RestoreUseSkipNonexistentTargets="False"
NuGet.CommandLine.ExitCodeException: Exception of type 'NuGet.CommandLine.ExitCodeException' was thrown.
at NuGet.CommandLine.MsBuildUtility.GetProjectReferencesAsync (NuGet.CommandLine.MsBuildToolset msbuildToolset, System.String[] projectPaths, System.Int32 timeOut, NuGet.CommandLine.IConsole console, System.Boolean recursive, System.String solutionDirectory, System.String solutionName, System.String restoreConfigFile, System.String[] sources, System.String packagesDirectory, NuGet.ProjectModel.RestoreLockProperties restoreLockProperties) [0x00489] in :0
at NuGet.CommandLine.RestoreCommand.GetDependencyGraphSpecAsync (System.String[] projectsWithPotentialP2PReferences, System.String solutionDirectory, System.String solutionName, System.String configFile) [0x0012b] in :0
at NuGet.CommandLine.RestoreCommand.DetermineInputsFromMSBuildAsync (NuGet.CommandLine.RestoreCommand+PackageRestoreInputs packageRestoreInputs) [0x000e5] in :0
/usr/share/dotnet/sdk/5.0.408/Sdks/Microsoft.NET.Sdk/targets/Microsoft.NET.TargetFrameworkInference.targets(141,5): error NETSDK1045: The current .NET SDK does not support targeting .NET 6.0.  Either target .NET 5.0 or lower, or use a version of the .NET SDK that supports .NET 6.0. [/home/vsts/work/1/s/xxxx1.csproj]
/usr/share/dotnet/sdk/5.0.408/Sdks/Microsoft.NET.Sdk/targets/Microsoft.NET.TargetFrameworkInference.targets(141,5): error NETSDK1045: The current .NET SDK does not support targeting .NET 6.0.  Either target .NET 5.0 or lower, or use a version of the .NET SDK that supports .NET 6.0. [/home/vsts/work/1/s/xxxx2.csproj]
Platforms affected

[X] Azure DevOps
[ ] GitHub Actions

Virtual environments affected

[ ] Ubuntu 18.04
[X] Ubuntu 20.04
[ ] Ubuntu 22.04
[ ] macOS 10.15
[ ] macOS 11
[ ] macOS 12
[ ] Windows Server 2019
[ ] Windows Server 2022

Image version and build link
20220529.1
Is it regression?
No
Expected behavior
Nuget restore should have used the latest net6.0
Actual behavior
It used net5.0
Repro steps
Unfortunately, the older image is unavailable; so unable to replicate

I have a second .net 6.0 project that ran successfully on 5/26 and has now failed with the same error

Hey @dotlegacy,
Please prove a test repo and steps to reproduce the issue.

Hi, same issue. Workaround with  - task: UseDotNet@2  version: '6.0.x'

Same issue... started failing out of nowhere

Hi, same issue. Workaround with - task: UseDotNet@2 Edit: nvm, saw you already wrote this.

How it's possible to use UseDotNet? :) i have github actions and not azure devops :) it's somehow possible to use that also in actions?

Hi, same issue. Workaround with - task: UseDotNet@2 Edit: nvm, saw you already wrote this.

How it's possible to use UseDotNet? :) i have github actions and not azure devops :) it's somehow possible to use that also in actions?

You could use actions/setup-dotnet task install .Net in runtime.

Hi, same issue. Workaround with - task: UseDotNet@2 Edit: nvm, saw you already wrote this.

How it's possible to use UseDotNet? :) i have github actions and not azure devops :) it's somehow possible to use that also in actions?

You could use actions/setup-dotnet task to install .Net in runtime.

I'm using that. But with this i have an issue which was mentioned above.

@dotlegacy, Does the issue still reproduce?

@dotlegacy, Does the issue still reproduce on the recent image?

Sandly, the problem is still happening for me

@dotlegacy, Any updates?
@MatiKloster, Could you share a repo with minimal steps how to reproduce the issue?

@MatiKloster, Thank you. If we swap nuget and .net installation step it's working:
      - name: Setup .NET Core
        uses: actions/setup-dotnet@v1
        with:
          dotnet-version: '6.0.x'

      - name: Restore NuGet package
        run:
          nuget restore ./test/NugetRestoreFail.csproj
      - name: Run Unit Test suite
        run: dotnet test ./test/NugetRestoreFail.csproj

@MatiKloster, Thank you. If we swap nuget and .net installation step it's working:
      - name: Setup .NET Core
        uses: actions/setup-dotnet@v1
        with:
          dotnet-version: '6.0.x'

      - name: Restore NuGet package
        run:
          nuget restore ./test/NugetRestoreFail.csproj
      - name: Run Unit Test suite
        run: dotnet test ./test/NugetRestoreFail.csproj

Exactly, that's what we did
But do you how this file stopped working?

@MatiKloster thanks for setting up the test repo; been swamp lately at work.
I have mentioned that it was picking up net5.0 even though net6.0 is installed in the Ubuntu image used by Azure DevOps.  I compared the previous working image with the broken one but couldn't find the cause.  There was a small change in the nuget version and if I recalled correctly, I tested the broken image with the nuget version on the working image but that didn't work as well.
I will test again on the new image and update.

I am planning close the thread as external.
Workaround:

Use setup-dotnet / UseDotNet@2
Create global.json
Replace nuget restore to dotnet restore

Same issue as i had before. Just changed from .NET 6 to .NET 7 and same issue.


Create test stubs for mocking alternative API calls

Translation testing was added in pull request: https://github.com/ccsm-cds-tools/ccsm-cds-service/pull/19


python intepreter

The old python interpreter was prone to be used for malicious intent, implement a new one where it can be safely used (ie ensure the interpreter cannot be used maliciously)

Malicious intent is a feature hubby.


Add Encode

Adds encode_float which maps float64 values to code points.
This differs from round_float, which maps float64 to float64 values in the format.
Doc preview at https://gfloat--3.org.readthedocs.build/en/3/

Nice small library. I will definitely give it a go for checking my FP8 casting code!

Thanks!


Modifier -> SwiftUI -> Focus: defaultFocus(::priority:)

Doc: https://developer.apple.com/documentation/swiftui/view/defaultfocus(::priority:)

[ ] Swift implementation
[ ] Elixir implementation

According to the @supernintendo @carson-katri @shadowfacts we won't support this


Displaying ring lines in both directions

Ring lines
Hi.
In Heidelberg, there is a tram ring line, which surrounds the entire region in 2 h. I would be interested to see just one direction. Now I see both directions that would take me 10 min and 1:50 h to my destination.
Because it is a ring line Hafas considers them the same line that reaches the same destination.
Is there a way to distinguish them?
Screenshots

Red arrow - Wrong direction. Green arrow - Right direction.

Interesting that the same destination is displayed for both. Please show your configuration of the module so that I can try it out.
Filters for platforms do not exist yet.

I have a dirty solution which will break every time after an update of this module. But for now I have no better one and it should work for you for this one case.
Replace in the file /core/PTHAFASTableBodyBuilder.js the line 25:
Before:
tBody.appendChild(row);
After:
if (!(departure.direction == 'Alter OEG-Bahnhof, Weinheim' && departure.stop.id == '511016')) { tBody.appendChild(row); }

By the way: The hafas API from VRN does not provide any platform information for your station.


Better compression for installer on windows

This basically just enables solid LMZA compression, makes the compression dictionary size 64mb and, optimizes the data block.

why the 64mb dictionary size may i ask?

also why not put this in the installer script itself instead of the cli args

41.7mb -> 34.5mb pretty nice

why the 64mb dictionary size may i ask?

it usually produces better results when compared to the default 8, the tradeoff is ram used when extracting (64 mb extra instead of 8)


Apply for InvestInOpen Grant

A grant would be helpful for further reports and further work on the website. This could also help to finance travel expenses and workshops.
@rockita has proposed to apply for one grant with the next deadline at the end of the month:
https://investinopen.org/

@dbrownlf should be involved here.

I'm happy to help here! Have you already started on the application materials @Ly0n ?

Thanks @dbrownlf for the support! Unfortunately I haven't had a chance to work on the issue yet, but I hope to find the time this weekend. Maybe you find the time on Monday to review it. We should collect somewhere the applications so that we can reused parts of it.
In the past I have tried to apply for a lot of these funds. The problem is that what we are doing is very unique and most people do not understand the value. The whole ecosystem analytics itself it pretty new.
So I don't think the chances are very high that we'll get one of them. Maybe thanks to the report and the fact that LF Energy is supporting. In this way people see the value that other organisations see.  For the infrastructure funds we are not software enough and for the data funds we are to much software.
Here a list of possible funds:

https://subak.org/ :heavy_check_mark: (@rockita  was financed for one year)
https://scoss.org/
https://investinopen.org/blog/open-infrastructure-fund-pilot-cfp/#advisory-panel
https://prototypefund.de/ ❌ ❌ ❌
https://sovereigntechfund.de/en/
https://github.com/PlaintextGroup/oss-virtual-incubator ❌

I applied for many more in the past when the projects was at the beginning.

@dbrownlf I wrote the application for InvestInOpen today. The deadline is tomorrow evening.
I just applied for $2500 to cover the traveling cost of 5 community members traveling to conference and community meetings.
Here the application:
https://hackmd.io/hmTXKAamTjOgOdTYvqM8Qw
Any feedback is welcome. ( I had not much time to write this )

@Ly0n Looks good! I made a few small tweaks just for clarity and language. You can go ahead and submit this.

Thank you so much @dbrownlf! I would be surprised if we get this grant since 60% of the total volume goes to low income developers but let's see.


Expo support

It'd be great if this library worked with expo managed workflow. Do you have any idea how to get it to work with it?
I've tried adding it to the managed workflow and then creating a new dev client but it's the AppDelegate section that I really don't know how to get it working.

Hi @julian-gargicevich, I know you asked long ago but I have just had to get this working and maybe this can be useful. I found a workaround for this to work with expo if you are using EAS for building.

At app.json you have to add this:

"ios": {
... other config ...
   "infoPlist": {
       "TikTokAppID": "<tiktok_app_id>",
       "CFBundleURLTypes": [{"CFBundleURLSchemes":["<tiktok_app_id>"]}],
       "LSApplicationQueriesSchemes": ["tiktokopensdk", "tiktoksharesdk", "snssdk1180", "snssdk1233"],
   }
}

For modifying AppDelegate.m is a bit tricky:

First step is to run expo prebuild --clean. Ensure first not to have any ongoing changes you want to commit. You will have to rollback all this changes after checking something. Basically this will create android / ios directory with  contents similar to the ones you would have if you had ejected the app.

Once you do this go to ios directory and copy AppDelegate.m contents (you will need them later). After that, rollback all changes.

No we need to create a new plugin. For this create a plugins directory and under react-native-tiktok dir an index.js file. Dir names can be whatever you want.

Now add a new entry at app.json at expo object:
"plugins": [
"./plugins/react-native-tiktok/index.js"
],

At the new index.js file you will need to have the following code:

const { withAppDelegate, withPlugins } = require('@expo/config-plugins');
const { resolve } = require('path');
const { readFileSync, writeFileSync } = require('fs');

function withReactNativeTiktoktAppDelegate(config) {
  return withAppDelegate(config, cfg => {
    cfg.modResults.contents = `<your modified AppDelegate.m>`;
    return cfg;
  });
}

function withReactNativeTiktok(config) {
  return withPlugins(config, [withReactNativeTiktoktAppDelegate]);
}

module.exports = withReactNativeTiktok;

Where it says  you will have to fill it with the AppDelegate.m content you got before and add to it the lines required by https://developers.tiktok.com/doc/getting-started-ios-quickstart-objective-c step 4.
Also for not running into this issue: https://github.com/Lg0gs/react-native-tiktok/issues/11, be sure to register and get your app approved at tiktok developers portal.

Thank you @galias11 !! I'm currently on holidays but will try it out and let you know how it goes once I get back

Hey @Lg0gs, yes it did. I only used it for video sharing. The only thing I have not fully tested yet is the go back to my App feature, but the video is shared correctly. As a note for development I use an EAS development build: https://docs.expo.dev/development/build/

@galias11 Could you please share a snippet of your code where you are calling 'auth' and could you also please share the AppDelegate.m file you created for the react-native-tiktok expo plugin? It seems like the SDK is not being called when I call 'auth' and I think the problem is in one of those two areas. Any help would be greatly appreciated 🙏

How to use it. can you share my file react native code


Add common RolloutStrategy API

Add @haoqing0110

LGTM

/approve
/lgtm
/hold
@haoqing0110 are we fine if there is no DeepCopy?

DeepCopy() for the common rollout strategy is needed I think, since we treat it as a duck type and will add library or helper function only for this part.
cc @serngawy, running make update should generate that.

DeepCopy() for the common rollout strategy is needed I think, since we treat it as a duck type and will add library or helper function only for this part. cc @serngawy, running make update should generate that.

$make update didn't generate deepcopy. However, as the rolloutStrategy will be part of others applier APIs spec the deepcopy will be generated with the applier API.


autocast=False not respected when saving/loading Keras model

Click to expand!
Issue Type
Bug
Source
source
Tensorflow Version
2.9.3
Custom Code
Yes
OS Platform and Distribution
Windows 10
Mobile device
No response
Python version
No response
Bazel version
No response
GCC/Compiler version
No response
CUDA/cuDNN version
No response
GPU model and memory
No response
Current Behaviour?
In the below code, the intention is to create a model that takes an input of type `float32` when saved, even if it is trained with `mixed_precision`. In this example, training code is omitted, and `call()` is just a placeholder for conciseness, but it still shows the issue.

The problem comes when loading the model. Because it has `autocast=False` I would expect that the model is saved with an input type of `tf.float32`. But it seems that the model is saved in an invalid state, because it loads with an error.

The error is the same even if you call `tf.keras.mixed_precision.set_global_policy("float32")` before loading the model.

Standalone code to reproduce the issue
import keras
import tensorflow as tf

class MyModel(keras.Model):
    def __init__(self):
        super().__init__(autocast=False)

    def call(self, inputs):
        return 0

def main():
    tf.keras.mixed_precision.set_global_policy("mixed_float16")

    model = MyModel()

    inputs = tf.zeros(shape=(1, 1), dtype=tf.float32)

    prediction_0 = model(inputs)

    model_path = "test_model"

    model.save(model_path)

    loaded_model = keras.models.load_model(model_path)

    prediction_1 = loaded_model(inputs)

if __name__ == "__main__":
    main()

Relevant log output
ValueError: Exception encountered when calling layer "my_model" (type MyModel).

Could not find matching concrete function to call loaded from the SavedModel. Got:
  Positional arguments (1 total):
    * <tf.Tensor 'inputs:0' shape=(1, 1) dtype=float16>
  Keyword arguments: {}

 Expected these arguments to match one of the following 2 option(s):

Option 1:
  Positional arguments (1 total):
    * TensorSpec(shape=(None, 1), dtype=tf.float32, name='inputs')
  Keyword arguments: {}

Option 2:
  Positional arguments (1 total):
    * TensorSpec(shape=(None, 1), dtype=tf.float32, name='input_1')
  Keyword arguments: {}

Call arguments received by layer "my_model" (type MyModel):
  • args=('tf.Tensor(shape=(1, 1), dtype=float16)',)
  • kwargs=<class 'inspect._empty'>

Process finished with exit code 1

Hi @JustASquid !
Thanks for sharing your observation on autocast=False in Keras model. Attached gist in 2.9, 2.10 and 2.11 for reference.
Could you report this issue on keras-team/keras repo
To know more see;
https://discuss.tensorflow.org/t/keras-project-moved-to-new-repository-in-https-github-com-keras-team-keras/1999 .
Thank you!

Thanks @mohantym, see https://github.com/tensorflow/tensorflow/issues/58940

Ok @JustASquid !
Moving this issue to closed status, as it will be tracked in Keras#17362.
Thank you!


Missing .map files causing collectstatic to fail using current master branch (TinyMCE 6)

I tried out the current, unreleased, version of master f04e1c8 that includes TinyMCE v6, thanks to #426:
pipenv install -e git+https://github.com/jazzband/django-tinymce.git@master#egg=django-tinymce

It seemed to work fine with an initial test locally, but when I tried running manage.py collectstatic I got this error:
Post-processing 'tinymce/skins/ui/oxide-dark/content.inline.js' failed!

Traceback (most recent call last):
  File "manage.py", line 24, in <module>
    main()
  File "manage.py", line 20, in main
    execute_from_command_line(sys.argv)
  File "/root/.local/share/virtualenvs/code-_Py8Si6I/lib/python3.8/site-packages/django/core/management/__init__.py", line 442, in execute_from_command_line
    utility.execute()
  File "/root/.local/share/virtualenvs/code-_Py8Si6I/lib/python3.8/site-packages/django/core/management/__init__.py", line 436, in execute
    self.fetch_command(subcommand).run_from_argv(self.argv)
  File "/root/.local/share/virtualenvs/code-_Py8Si6I/lib/python3.8/site-packages/django/core/management/base.py", line 412, in run_from_argv
    self.execute(*args, **cmd_options)
  File "/root/.local/share/virtualenvs/code-_Py8Si6I/lib/python3.8/site-packages/django/core/management/base.py", line 458, in execute
    output = self.handle(*args, **options)
  File "/root/.local/share/virtualenvs/code-_Py8Si6I/lib/python3.8/site-packages/django/contrib/staticfiles/management/commands/collectstatic.py", line 209, in handle
    collected = self.collect()
  File "/root/.local/share/virtualenvs/code-_Py8Si6I/lib/python3.8/site-packages/django/contrib/staticfiles/management/commands/collectstatic.py", line 154, in collect
    raise processed
whitenoise.storage.MissingFileError: The file 'tinymce/skins/ui/oxide-dark/content.inline.js.map' could not be found with <whitenoise.storage.CompressedManifestStaticFilesStorage object at 0xffffa14393a0>.

The JS file 'tinymce/skins/ui/oxide-dark/content.inline.js' references a file which could not be found:
  tinymce/skins/ui/oxide-dark/content.inline.js.map

Please check the URL references in this JS file, particularly any
relative paths which might be pointing to the wrong location.

As you can see I'm using whitenoise, and I haven't tried it without.
I can't see any .map files in those tinymce/skins/ folders, but also can't see any in the version of TinyMCE 6 downloaded direct from the tiny.cloud website.
There are some closed issues for previous versions of TinyMCE in which they concluded that the released files shouldn't include references to .map files, e.g. https://github.com/tinymce/tinymce/issues/5489 and https://github.com/tinymce/tinymce/issues/4649 but can't see anything more recent. Still, maybe this is actually an issue for TinyMCE?

It seems like that's the approach they took before. I could open an issue there asking if they should be doing that, seeing as that was the previous approach?

Sure, you can always try!

Here we go: https://github.com/tinymce/tinymce/issues/9484
In creating that I've realised it's unrelated to Whitenoise. The error also occurs using django.contrib.staticfiles.storage.ManifestStaticFilesStorage as Django's staticfiles backend.
If that's changed to django.contrib.staticfiles.storage.StaticFilesStorage then there's no error.

It looks like the official word from the Django project is that this should raise an error, and you should include the .map files if possible.
Other projects have fixed this issue by just removing the sourceMappingURL lines, e.g. https://github.com/farridav/django-jazzmin/issues/488. I will put up a PR to remove them here as well.


@ #67 | should create virtualbox sync host path if it does not exists

connect #67
@hoatle please, help me check this PR!

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

make sure to create docs/_build/.gitkeep file and add that to this PR. the auto_create will work with the next version of teracy-dev and docs/_build/.gitkeep works with the current version of teracy-dev.

Coverage remained the same at 98.018% when pulling d043103424c5cd815e399200e6ccea059d43632f on hieptranquoc:bug/#67-should-create-virtualbox-sync-host-path into e73f0a431ef4ac25e534d53a6d591c4676c06552 on teracyhq:develop.

@hoatle docs/_build/.gitkeep has already created in this PR! please review again 💃


fix: reduce lock contention in RepartitionExec::execute

Which issue does this PR close?
Closes https://github.com/apache/arrow-datafusion/issues/10014
Rationale for this change
The state is initialized ONCE for all partitions. However this may take a short while (on a very busy system 1ms or more). It is quite likely that multiple threads call execute at the same time, because we have just fanned out to the number "target partitions" which is likely set to the number of CPU cores which now all try to start to execute the plan at the same time.
The solution is to not waste CPU circles in some futex lock but to tell the async runtime (= tokio) that we are performing work and the other threads should rather do something useful.
What changes are included in this PR?
This mostly just moves code around, no functional change intended.
Are these changes tested?
Existing tests still pass.
Are there any user-facing changes?
Faster query exec.

TBH a slightly slower runtime in a "repeat a single query in a hot-loop" benchmark is somewhat expected. If you have enough tokio threads to spare, you can totally futex-wait. But for any kind of server software that's a bad idea.


z3c.form support for dynatree

This branch adds a z3c.form compatible dynatree widget (while keeping the Archetypes widget for backward compatibility).
It uses the newly added TreeVocabulary in zope.schema, so it has a dependency on zope.schema 4.1dev.

thanks! great to have this feature now!


[enhancement] Add IncrementalEmpiricalCovariance to patch_map

Description
IncrementalEmpiricalCovariance update to match sklearnex estimator characteristics
Changes proposed in this pull request:

Add mahalanobis method using sklearnex pairwise_distances to IncrementalEmpiricalCovariance
Add error_norm
Add onedal_cpu_support and onedal_gpu_support to IncrementalEmpiricalCovariance
Add BaseEstimator to IncrementalEmpiricalCovariance inheritance
Add wrap_output_data where necessary in IncrementalEmpiricalCovariance
Fix covariance_ and location_ attributes to report as not existing before fit
Add n_features_in_ attribute for sklearn conformity
Add n_samples_seen_ attribute to match style of IncrementalPCA
Add init keywords to match sklearn EmpiricalCovariance
Add store_precision functionality
Add assume_centered functionality
Add relevant sklearn tests to sklearnex tests via a separate monkeypatch

Tasks

[x] Implement changes for sklearnex/sklearn conformance
[x] Add to patchmap to access sklearn tests
[x] Modify patchmap to work with new estimators
[x] Add EmpiricalCovariance tests from sklearn to test_covariance for IncrementalEmpiricalCovariance
[x] Pass Tests
[x] Split off changes to patchmap and tests into separate PR

/Intelci: run

/intelci: run

/intelci: run

/intelci: run

Will write tickets associated with dataframe0 and test memory leak, it is gpu and cpu side meaning its likely in the glue portion of the code. Also, it only occurs on one of the two meaning something else fishy is going on.  This will have to be revisited in the future.  I will now slim this PR down and remove the content from the other 3.


Revert "fix(SweepObjects): dedup backend checking"

Reverts threefoldtech/0-stor_v2#137

Reverting the PR because i think it is unnecessary.
The RequestBackends handler already have caching mechanism for the healthy backends.
For the unhealthy, will be implemented in another PR (if necessary at all)


Can't use crime.net cargo

the crime.net cargo option doesn't show up for me even though i have crime.net cargo enabled the only other mod i have is hoxhud but i tried unninstalling it and still not working

Judging by the background on the first screenshot, you're trying to access the Crime.net cargo while on the main menu; you have to be in a lobby in order to use this feature.

oh, makes sense, i thought it worked differently thank you


setData() documentation is incorrect

It states
//add points to the layer...here slat denotes the latitude and slon denotes the longitude
layer.setData({"slat": -33.3042, "slon": 26.5328});

but setData() only takes arrays of points, not single points (and re-draws the layer). Should say "addData".

Additionally, it is not possible to add live data to the map because setData initializes a new quadtree every time it is called.

Yep correct!
I have corrected the Readme file accordingly thanks!


GPU with TenserFlowOnSpark

Hello,
I have configured TenserFlowOnSpark with 3 cluster and I have some questions to ask.

How to make sure that the clusters are using GPU.

In the wiki, you say that we should configure this environment variables.
# set environment variables (if not already done)
export PYTHON_ROOT=./Python
export LD_LIBRARY_PATH=${PATH}
export PYSPARK_PYTHON=${PYTHON_ROOT}/bin/python
export SPARK_YARN_USER_ENV="PYSPARK_PYTHON=Python/bin/python"
export PATH=${PYTHON_ROOT}/bin/:$PATH
export QUEUE=gpu

# set paths to libjvm.so, libhdfs.so, and libcuda*.so
#export LIB_HDFS=/opt/cloudera/parcels/CDH/lib64                      # for CDH (per @wangyum)
export LIB_HDFS=$HADOOP_PREFIX/lib/native/Linux-amd64-64              # path to libhdfs.so, for TF acccess to HDFS
export LIB_JVM=$JAVA_HOME/jre/lib/amd64/server                        # path to libjvm.so
export LIB_CUDA=/usr/local/cuda-7.5/lib64                             # for GPUs only

I didn't set PYTHON_ROOT, PYSPARK_PYTHON, PARK_YARN_USER_ENV and everything is working is this because I have installed python cuda and tenserFlowOnSpark on all cluster.

Why do I need to set LIB_CUDA and mention it when using spark-submit if I have  cuda installed on all clusters.

why do I need to set LIB_JVM

What is the minimal command to use in order to start a python script using TensorFlowOnSpark. And Can I use pyspark.

Thank you.

The easiest way to tell if it's using the GPUs is to look at your Spark executor logs, you should see something like this:

2018-03-20 20:16:35,228 INFO (MainThread-26716) 1: ======== worker:0 ========
2018-03-20 20:16:35,228 INFO (MainThread-26716) 1: Cluster spec: {'ps': ['<IP_ADDRESS>:46866'], 'worker': ['<IP_ADDRESS>:39733', '<IP_ADDRESS>:43606', '<IP_ADDRESS>:33758']}
2018-03-20 20:16:35,334 INFO (MainThread-26716) 1: Using GPU: 6

If you've installed all the dependencies on your nodes, then you shouldn't need to set most of these variables.

3/4. These are setting the LD_LIBRARY_PATH env var on the executors, which is used by the various bits of code which require these native libs.  If you've set LD_LIBRARY_PATH accordingly on all of your cluster nodes, then you will not need to pass them thru the Spark conf.

pyspark applications can only be started via spark-submit.  However, you can use the pyspark shell for interactive sessions, which might work fine for you (if you've supplied all the dependencies on all nodes), so something like pyspark --master yarn might be enough to get you going.


market.yaml

market.yaml  into $MEGAM_HOME has copied successfully

Some scala files are removed. It has to be tested. Logesh is doing the test


Stop importing CF as a framework

Frameworks don't exist off of Darwin resulting in link failures in this test. The CF modulemap declares CF as a framework everywhere, which is wrong, but importing CF from swift-corelibs-foundation is also equally wrong, which this test does as well, so there's a lot of wrongness.
To get the rebranch working, we need to stop importing CoreFoundation as a framework in this test, or disable the test on non-darwin platforms. Given that corelibs-xctest is for non-Darwin platforms, that seems like the wrong course of action. Technically, things outside of swift-corelibs-Foundation should not be importing the CoreFoundation module at all.
This is affecting rebranch as clang changed modulemap import behavior in a way that affects the corelibs-Foundation CoreFoundation module.

@swift-ci please test

@swift-ci please test

@swift-ci test macos

@swift-ci test windows


[Docs] Resolve URL linking to wrong library tag

Hello!
Pull Request overiew

Replace the library tag span_marker with the correct span-marker in the SpanMarker docs.

Details
This originates from before I changed from span_marker to span-marker, I just missed this one case.
Before: https://huggingface.co/models?library=span_marker
After: https://huggingface.co/models?library=span-marker

Tom Aarsen

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.

All URLs from the SpanMarker docs page work as intended now.


proposal: add support for relation/edge schema

This is a feature that I have wanted to add for a long time to ent, and will be happy to get feedback, suggestion for improvements or just hear your thoughts before I create a proper PR for it.
The idea is instead of adding a completely new API for adding fields for edges (columns for join tables), configure their indexes, hooks, privacy, etc, or even support multi-column PKs, we'll add 2 new small changes for the ent/schema for supporting all those issues.
field.ID Annotation
A new field.ID option will be added to the schema/field package, and this will allow configuring multi-column PKs, but more than that, it will make it possible to configure relation/edge schema manually. For example:
// UserGroup defines the UserGroup relation schema.
type UserGroup struct {
	ent.Schema
}

func (UserGroup) Annotations() []schema.Annotation {
	return []schema.Annotation{
		// This will generate the following struct:
		//
		//	type UserGroupID struct {
		//		UserID, GroupID int
		//	}
		//
		field.ID("user_id", "group_id"),
	}
}

func (UserGroup) Fields() []ent.Field {
	return []ent.Field{
		field.Int("user_id"),
		field.Int("group_id"),
		field.Time("created_at").
			Immutable().
			Default(time.Now),
	}
}

func (UserGroup) Edges() []ent.Edge {
	return []ent.Edge{
		edge.To("user", User.Type).
			Unique().
			Field("user_id"),
		edge.To("group", Group.Type).
			Unique().
			Field("group_id"),
	}
}

Indexes, hooks, privacy, and all other options will also be available for this type of schema, but in order to add a user to a group, the flow is a bit longer:
a8m := client.User.Create().SetName(..).SaveX(ctx)
hub := client.Group.Create().SetName(..).SaveX(ctx)
// Instead of calling hub.AddGroups(a8m), the API is:
client.UserGroup.Create().SetUserID(a8m.ID).SetGroupID(hub.ID).ExecX(ctx)
client.UserGroup.GetX(ctx, ent.UserGroupID{UserID: a8m.ID, GroupID: hub.ID})

We can bypass this long flow by providing an additional config option for edges:
The edge.Through Option
The Through option is supported by other frameworks and has already been proposed here before. The idea is to allow schemas that use the relation/edge-schema to CRUD directly their relations. However, I have an open question (atm) regarding the design of the generated code.
The configuration looks as follows:
func (Group) Edges() []ent.Edge {
	return []ent.Edge{
		edge.To("users", User.Type).
			Through(UserGroup.Type),
	}
}

And the generated API is as follows:
a8m := client.User.Create().SetName(..).SaveX(ctx)
hub := client.Group.Create().SetName(..).AddUsers(a8m).SaveX(ctx)

An open question I have is on how do we set/update relation-schema fields in case they don't have default values or hooks configured on their ent/schema.
Thoughts?

Cc @tarrencev

This works great for my use case! Maybe it makes most sense to start with the field.ID annotation and then work on the Through api? For now we could use the more verbose code

Looks great. I like the through option because it feels intuitive and many people coming from the Rails and other domains will find it natural.

This would be an amazing addition. Would be the last piece of the puzzle to be able to switch to ent.
Regarding the defaults in the through tables. Would it maybe be possible to detect if a table is referenced to as a "through" table, and then check if any non-default fields are missing, then panic/error out?
A potential issue/feature that should be considered: When creating the annotation field.ID("user_id", "group_id") it would be great if it also supported the case where user_id was a string, but group_id was an int (or other type combos).

a8m := client.User.Create().SetName(..).SaveX(ctx)

// UserGroupThrough has setters for fields except "group"
thr := client.UserGroup.Through.
	SetUser(a8m).
	SetCreatedAt(time.Now)

hub := client.Group.Create().SetName(..).AddUsersThrough(thr).SaveX(ctx)

Any particular reason this is added as annotation and not as part of the schema methods?

This would solve the issue I’m running into now as well. The changes to API flow isn’t a big deal because now that logic can be customized for upserts.

Any update on this?

Any update on this?

While I started implementing, I started to think of a different approach. Defining a new schema type named edge.Schema feels better to me. Please, see the following example:
// Tweet schema.
type Tweet struct {
	ent.Schema
}

func (Tweet) Edges() []ent.Edge {
	return []ent.Edge{
		edge.To("users_liked", User.Type).
			// Through allows defining M2M (join tables) explicitly using edge.Schemas.
			// The first argument ("likes") allows interacting with the join table by its name.
			Through("likes", TweetLike.Type),
	}
}

// TweetLike schema (the join table).
// See the edge.Schema below.
type TweetLike struct {
	edge.Schema
}

// Additional fields.
func (TweetLike) Fields() []ent.Field {
	return []ent.Field{
		field.Time("timestamp").
			Default(time.Now),
	}
}

func (TweetLike) Edges() []ent.Edge {
	return []ent.Edge{
		edge.To("tweet", Tweet.Type).
			Unique(),
		edge.To("user", User.Type).
			Unique(),
	}
}

In the above example, there's no need/way to define the PK explicitly. It's always set to the foreign keys (as it is today). Composite PKs can be added, but I feel it's not really part of this feature.
Usage API:
Keep the generated code the same as it's today and provide extended API to allow query M2M edges (with Throught) in 2 flavors:
// Query without going through the join-table explicitly.
tweer.QueryUsersLiked().All(ctx)

// Query through.
tweer.QueryLikes().Where(tweetlike.TimestampGT(...)).QueryUsers().All(ctx)

Thoughts?

I have little experience with Entgo, but it sounds good to me!

ent.Schema and edge.Schema are hard to distinguish. Can we call it ent.Edge? Or maybe ent.Pivot?
I like! 💯

Laravel uses the Pivot vocab, fwiw.

Each framework has its own specialized language, syntax and semantics. All I need as a user is a good introduction to the framework in the documentation.
We could call it ent.Join (which I think describes it best for developers working with SQL databases) or ent.Pivot.

Thanks all for the feedback. I need to digest it a bit and come up with a final naming proposal.
ent.Edge is already taken and represents an edge in ent. Pivot/Join are too SQL-ish, and we support more database types atm, and plan to support more in the future.
edge.Schema is like an ent.Schema, you can attach policy, hooks, annotations, other edges, etc., but it represents an edge and not a node.

Interestingly, however, you described it exactly this way, so that we understand it: (the join table)
// TweetLike schema (the join table)

❤  love the example here and it would be a new milestone for ent to support this! One question, would there be any workaround (probably a less messy one) while we wait for this great addition to ent?

While I started implementing, I started to think of a different approach. Defining a new schema type named edge.Schema feels better to me. Please, see the following example:
// Tweet schema.
type Tweet struct {
	ent.Schema
}

func (Tweet) Edges() []ent.Edge {
	return []ent.Edge{
		edge.To("users_liked", User.Type).
			// Through allows defining M2M (join tables) explicitly using edge.Schemas.
			// The first argument ("likes") allows interacting with the join table by its name.
			Through("likes", TweetLike.Type),
	}
}

// TweetLike schema (the join table).
// See the edge.Schema below.
type TweetLike struct {
	edge.Schema
}

// Additional fields.
func (TweetLike) Fields() []ent.Field {
	return []ent.Field{
		field.Time("timestamp").
			Default(time.Now),
	}
}

func (TweetLike) Edges() []ent.Edge {
	return []ent.Edge{
		edge.To("tweet", Tweet.Type).
			Unique(),
		edge.To("user", User.Type).
			Unique(),
	}
}

In the above example, there's no need/way to define the PK explicitly. It's always set to the foreign keys (as it is today). Composite PKs can be added, but I feel it's not really part of this feature.
Usage API:
Keep the generated code the same as it's today and provide extended API to allow query M2M edges (with Through) in 2 flavors:
// Query without going through the join-table explicitly.
tweer.QueryUsersLiked().All(ctx)

// Query through.
tweer.QueryLikes().Where(tweetlike.TimestampGT(...)).QueryUsers().All(ctx)

Thoughts?

❤  love the example here and it would be a new milestone for ent to support this! One question, would there be any workaround (probably a less messy one) while we wait for this great addition to ent?

Hey,
Any progress on this issue? I want to add additional fields to the pivot table. any idea?

The edge.Schema approach seems more intuitive indeed, and you might want to rename ent.Schema to field.Schema for consistency (and probably keep ent.Schema as a deprecated alias to field.Schema for some releases).

Issue #400 looks like it's closely related to this, as these "edge with fields" tables would normally have such a composite PK instead of an ID.

A new field.ID option will be added to the schema/field package, and this will allow configuring multi-column PKs, but more than that, it will make it possible to configure relation/edge schema manually.

when i user Field.ID，error occurred.
how can i user the options.

func (TweetLike) Edges() []ent.Edge { 	return []ent.Edge{ 		edge.To("tweet", Tweet.Type). 			Unique(), 		edge.To("user", User.Type). 			Unique(), 	} }
why define unique?
one person like one tweet?

go run entgo.io/ent/cmd/ent generate --feature privacy,entql,multi-column ./ent/schema entc/load: load schema dir: /Users/shituanwei/Desktop/project/src/dailybible/ent/schema/accountchurch.go:23:9: ID not declared by package field exit status 1

func (Group) Edges() []ent.Edge { 	return []ent.Edge{ 		edge.To("users", User.Type). 			Through(UserGroup.Type), 	} }
prefer this way.
it's smooth, and much more stable.

Hey all! The initial support was added, and it's in review atm. See https://github.com/ent/ent/pull/2560 and please feel free to share your thoughts/feedback before it's merged.

Is the Edges function required on the relation schema?
i.e. would a use case of wanting to add properties to the relation necessitate creating both a Fields and Edges on that schema, or could I just have Fields serving as the property for something like created_at ?
Will this feature be available for other relation types in addition to M2M ?
Can mixins work for the Fields of the relation just like they already exist?
The privacy policy on this is a really nice feature ;)

Is the Edges function required on the relation schema?

Yes, the Edges is required as mentioned in https://github.com/ent/ent/pull/2560. Ent needs those fields/edges in the generated entities and their builders, and the idea here is to be explicit and consistent. If there's an edge or a field in the generated type, it must be part of the schema.

Will this feature be available for other relation types in addition to M2M?

Yes, it's mentioned in the docs.

Can mixins work for the Fields of the relation just like they already exist?
The privacy policy on this is a really nice feature ;)

All features of regular schemas are supported. e.g. Mixin, Hooks, and Privacy.

Closed with https://github.com/ent/ent/pull/2560. Thank you all for the feedback.


support for zstd transfer

compressflate type zstd, possible to implement? your zstd is working great. thanks

Sure, will add zstd support to httpteleport in the future

Let's keep the issue open until zstd support is added into httpteleport


Fix a dependency conflict

This PR provides a work-around for the version conflict of the SnakeYaml Engine library between jRuby and Kaml (see also https://github.com/eclipse-apoapsis/ort-server/pull/129). It introduces a new utils module for YAML parsing that uses the Gradle shadow plugin to relocate the problematic packages. This is of course not a complete solution, but it fixes the problem for now; with this fix, it is again possible to analyze projects using Ruby.

Just to note: As indicated here already, IMO this work-around does not scale, as we could easily run into the same problem for other dependencies as well. The "real" fix at the root would be to apply the Shadow Gradle plugin for ORT plugins to solve https://github.com/oss-review-toolkit/ort/issues/6798, not to apply the Shadow plugin here.

Just to note: As indicated here already, IMO this work-around does not scale, as we could easily run into the same problem for other dependencies as well. The "real" fix at the root would be to apply the Shadow Gradle plugin for ORT plugins to solve oss-review-toolkit/ort#6798, not to apply the Shadow plugin here.

Yes, I agree; I see this as a temporary work-around.
Applying the Shadow plugin to the ORT plugins would certainly be an option, but this would probably increase the size of the plugin jars and the container images significantly. It would be cool to have some classloader magic, in a similar way how application servers are able to isolate the applications deployed on them from each other.

That's very useful information in both comments, could you add that to a README.md file in the new Gradle module?

That's very useful information in both comments, could you add that to a README.md file in the new Gradle module?

Added a README file in a new commit that hopefully captures the essence of the discussion.


ERROR: [SSL: CERTIFICATE_VERIFY_FAILED]

This error is received recently and unable to use GAM. Please advise how to fix it. I'm using gam-64 for windows 64 bit pc.
Thanks.

This error generally indicates a proxy / firewall or security software on the PC intercepting GAM commands and using invalid certificates. Try disabling these and retry.


Erratic Interface

VSCode Version: Code 1.15.1 (41abd21afdf7424c89319ee7cb0445cc6f376959, 2017-08-16T18:05:38.342Z)
OS Version: Windows_NT ia32 10.0.15063
Extensions:

Extension
Author (truncated)
Version

html-snippets
abu
0.1.0

open-html-in-browser
cod
0.1.21

vscode-eslint
dba
1.2.11

python
don
0.7.0

Steps to Reproduce:

Reproduces without extensions: Yes/Noe
The vscode interface is erratic. Opens menus and commands I didn't personally initiate. And has seemingly translate to other areas of my PC

And has seemingly translate to other areas of my PC

Like what?

When am coding with vscode the right mouse button command activates when i
did not press it. I also notice that the cursor takes me to codeline that
am not currently on. Which makes me return to my former codeline any time
this happen.
I particularly notice that this is more prevalent anytime I open the vscode
editor. Since it is now the only choice editor I have allowed on my PC.
On Thu, Aug 31, 2017 at 2:46 PM, Johannes Rieken<EMAIL_ADDRESS>wrote:

And has seemingly translate to other areas of my PC
Like what?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/Microsoft/vscode/issues/33590#issuecomment-326299754,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AWWH6mGDq27xiUAQ2XlEPFd_jzFfrrGRks5sdrkZgaJpZM4PIv0P
.

--
Samuel Nwoye
"There is only one good, knowledge; one evil, Ignorance"

When am coding with vscode the right mouse button command activates when i
did not press it.

Is that in a particular language or with any code file?  So that is not the case. Let me be a little
more detailed. I am a junior web developer and data scientist. My Windows
10 PC is setup for doing the tasks related to this fields of technology.
i.e I installed the Anaconda Python 3.6.1 and http-based libraries, then I
have javascript libraries. I use vscode in debugging for both.
What am suspecting is that maybe I have a introduced a malware into my PC.
Through either of this scripting languages. This issue particularly started
happening when I tried looking through this websites code - www.belfox.net

I even notice alot of gibberish javascript code within the sites file.

Please this issue has since slowed the pace of my work.
On Fri, Sep 1, 2017 at 4:39 PM, Johannes Rieken<EMAIL_ADDRESS>wrote:

When am coding with vscode the right mouse button command activates when i
did not press it.
Is that in a particular language or with any code file? Do you happen to
press Shift+F10 which is the shortcut for the context menu?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/Microsoft/vscode/issues/33590#issuecomment-326613418,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AWWH6sRXpEVyAvHKyudjjLiKUG0sz4CEks5seCU_gaJpZM4PIv0P
.

--
Samuel Nwoye
"There is only one good, knowledge; one evil, Ignorance"

Please sir, can we schedule some time. I want to give you a remote access
to my PC so that you can help me solved this challenge. I am not sure, but
am suspecting am being monitored or even hacked. I used kali linux for a
while but backed out for some ethical reasons.
On Fri, Sep 1, 2017 at 7:19 PM, Samuel Nwoye<EMAIL_ADDRESS>wrote:

shift + F10 are a little apart. So that is not the case. Let me be a
little more detailed. I am a junior web developer and data scientist. My
Windows 10 PC is setup for doing the tasks related to this fields of
technology. i.e I installed the Anaconda Python 3.6.1 and http-based
libraries, then I have javascript libraries. I use vscode in debugging for
both.
What am suspecting is that maybe I have a introduced a malware into my PC.
Through either of this scripting languages. This issue particularly started
happening when I tried looking through this websites code - www.belfox.net

I even notice alot of gibberish javascript code within the sites file.

Please this issue has since slowed the pace of my work.
On Fri, Sep 1, 2017 at 4:39 PM, Johannes Rieken<EMAIL_ADDRESS>wrote:

When am coding with vscode the right mouse button command activates when i
did not press it.
Is that in a particular language or with any code file? Do you happen to
press Shift+F10 which is the shortcut for the context menu?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/Microsoft/vscode/issues/33590#issuecomment-326613418,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AWWH6sRXpEVyAvHKyudjjLiKUG0sz4CEks5seCU_gaJpZM4PIv0P
.

--
Samuel Nwoye
"There is only one good, knowledge; one evil, Ignorance"

--
Samuel Nwoye
"There is only one good, knowledge; one evil, Ignorance"

Sorry, this is the issue tracker for VS Code and we can only look into things within VS Code, not outside e.g OS issues.

No problems. I still appreciate your support. I will look into it. Thanks
for your warm responses.
On Mon, Sep 4, 2017 at 10:08 AM, Johannes Rieken<EMAIL_ADDRESS>wrote:

Sorry, this is the issue tracker for VS Code and we can only look into
things within VS Code, not outside e.g OS issues.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/Microsoft/vscode/issues/33590#issuecomment-326908819,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AWWH6u68Kktx-mg86fkCDb1GvcnU5aaYks5se74HgaJpZM4PIv0P
.

--
Samuel Nwoye
"There is only one good, knowledge; one evil, Ignorance"


Favicon

It would be nice if the favicon changed to the amount of missed messages, so i'm able to pin the tab in chrome to only see the icon but still not miss any messages

up

+1 — I also think this could be linked together with #28


Convert new integration tests to jest and add to CI

make custom runner, call vscode API, have it output as json (or to file)?

/azp run

/azp run

/azp run


Redundant NTP server connection starting from the Level 2

I've noticed, that there's one redundant NTP server connection in the corporate segment. Please, take a look:

@icamys  thanks comrade


How to analyze large models like llama 3 70B that requires model parallelism?

The model engine is built from llama 3 70b with tensor parallelism tp=2 and pp=2 and deployed by below triton launch script:
python3 scripts/launch_triton_server.py --world_size 4 --model_repo=llama_ifb
In this case, how to leverage model-analyzer to analyze this parallelized model/deployment?

Are you able to run this model on PA or GenAI-Perf?

I was able to use perf_analyzer to instrument llama 3 70b on 4*A100 (trtllm backend) via a launched triton server as below
python3 scripts/launch_triton_server.py --world_size 4 --model_repo=llama_ifb/
perf_analyzer -m ensemble --measurement-interval 10000 --concurrency-range <start:end:step> --input-data input.json

I'm wondering how can I tune triton model config using model analyzer in this case.
Thanks.

I'm in a very similar predicament, but with 8*H100. I'm getting pretty underwhelming results and would also like to know how to utilize model-analyzer, as I'm fairly new to Triton.


Fix pointers link in userguide

Adding (limited) to the header in a previous doc change broke the link.

It works.
I tested it.

Seems we have an intermittent test failure?
failing tests:
tests/bugs/gh-4031.slang (dx12)


TypeError customize.sh

NUM=29
if [ "$API" -lt $NUM ]
The value type is inconsistent

There is no mistake
The result will be the same in this case if you put "$API" or $API

This is wrong, keep it that way you need to change $UNM to "$UNM" as well

There is no mistake The result will be the same in this case if you put "$API" or $API
I've tested it
This is wrong, keep it that way you need to change $UNM to "$UNM" as well

Maybe you don't understand buddy, keep learning 👍

 Maybe you don't understand buddy, keep learning 👍..

I made a mistake. Thank you for correcting me ❤


Update bcu.rb to require "cask", not "cask/all"

Homebrew/brew#8262 moved cask/all to cask, which breaks this command. This change fixes it.

:shipit:

@LeerGo: :shipit:

@y0y0z please follow GitHub netiquette and don't write useless posts, which don't anything valuable to the discussion.
Please consider reacting to post with an emoji If you have nothing valuable to add to the discussion, it's the best way to vote for PR or issue. And this doesn't produce notifications to those, who are subscribed to repos, issues and PRs. People are subscribing to get valuable notifications about valuable posts, not for useless ones.

@yurikoles: i did all that you mentioned and create a new post with shipit, so others can vote for it if it worked for them. same as we do in many other projects.
anyhow, your comment is much appreciate. thank you.

@y0y0z, again, the best option is to vote for OP post in a PR.


[$500] Task needs revisit to update members

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: 1.3.80-1
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @dhanashree-sawant
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1696942077360429
Action Performed:

Open the app
Open any task report or raise one and open the report
Click on task header -> members to observe current members
Again get back to report and change assignee to any non member user
Again click on task header -> members and observe that new assignee is not added to members
Revisit report and observe members, it will now display new assignee in members

Expected Result:
App should add new assignee to members as soon as we change the assignee
Actual Result:
App needs revisit to report to add new assignee to members
Workaround:
unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

Screenshots/Videos

Android: Native

Android: mWeb Chrome

https://github.com/Expensify/App/assets/38435837/5cc61d7f-eab6-4111-83b5-afa24cead3fb

iOS: Native

https://github.com/Expensify/App/assets/38435837/25df0787-2078-48b9-98b6-449203fd8611

iOS: mWeb Safari

https://github.com/Expensify/App/assets/38435837/cbbe4c53-c879-4986-9bb8-7b03287b08ed

MacOS: Chrome / Safari

https://github.com/Expensify/App/assets/38435837/29b75e3d-b0eb-4991-be2f-f02379adec15
https://github.com/Expensify/App/assets/38435837/5f865898-14d7-4c5f-9f25-1db2ca0a3728
https://github.com/Expensify/App/assets/38435837/f145594c-2cbc-49e0-9ba4-23309aaa2d31

MacOS: Desktop

https://github.com/Expensify/App/assets/38435837/ba719838-c6f0-486e-ad9e-cb9ddbdfafe7

View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01609c654d88438959
Upwork Job ID:<PHONE_NUMBER>398246400
Last Price Increase: 2023-10-17

I'm not able to reproduce this issue.
In step 3, it shows profile page instead of task details page when the user clicks the header of task.
Is this bug or expected behavior?

I'm seeing the same thing as @akamefi202. @dhanashree-sawant can you expand on the repro steps? Or are there specific settings on the task that needs to be set in order to repro this?

I saw the same issue when creating new task i.e. it displayed user profile (seems to be different bug). What I did was I changed the assignee to someone else and revisited. After that it started displaying members and settings option in details page.

still waiting for proposals

Proposal
Please re-state the problem that we are trying to solve in this issue.
Task needs revisit to update members.
What is the root cause of that problem?
The ReportParticipantsPage uses the report.participantAccountIDs function to get the member list from ReportUtils.getParticipantsIDs.
https://github.com/Expensify/App/blob/a59d56f00a67607a1dbae1b422807f76f548f1f0/src/libs/ReportUtils.js#L4028-L4033
https://github.com/Expensify/App/blob/a59d56f00a67607a1dbae1b422807f76f548f1f0/src/pages/ReportParticipantsPage.js#L57-L58
The report.participantAccountIDs is updated when the report data is retrieved from the command=openReport API response. This happens when the user opens a report.
https://github.com/Expensify/App/blob/a59d56f00a67607a1dbae1b422807f76f548f1f0/src/libs/actions/Task.js#L432
Hence, the root cause of the problem is that when the user changes the task assignee, the Task.editTaskAssigneeAndNavigate function assumes that command=openReport will be called soon to update report.participantAccountIDs. However, this is not the case. Unless the user closes and revisits the task report, then the command=openReport request will be processed, hence updating report.participantAccountIDs. Therefore, the ReportParticipantsPage can list the recently added members in realtime.
What changes do you think we should make in order to solve the problem?
In order to solve the problem, I suggest updating the report.participantAccountIDs array instead of waiting on command=openReport. Hence, we add participantAccountIDs : [...report.participantAccountIDs, assigneeAccountID] in the second item in the optimisticData array, but only when the report.participantAccountIDs does not contain the assigneeAccountID. This will allow the new assignee to be updated in the ReportParticipantsPage before the server updates the task report data. This will also improve the offline UX because the member's list will be updated without the need to wait for the report data in the Onyx to be updated with the command=openReport API response.
https://github.com/Expensify/App/blob/a59d56f00a67607a1dbae1b422807f76f548f1f0/src/libs/actions/Task.js#L481
Therefore, I believe adding something similar to the code below, after the condition above in Task.editTaskAssigneeAndNavigate, should solve the problem.
if (report.participantAccountIDs && report.participantAccountIDs.include(assigneeAccountID)) optimisticData[1].value.participantAccountIDs = [...report.participantAccountIDs, assigneeAccountID];

@Tony-MK

will be updated . very

Are we missing a sentence here, or is it just an extra word left in the proposal by accident?

@Tony-MK

will be updated . very

Are we missing a sentence here, or is it just an extra word left in the proposal by accident?

@cubuspl42 Sorry about that. It was an extra word left out while trying to edit the proposal.

In my opinion, the proposal by @Tony-MK sounds reasonable. I agree that the suggested change will also improve the offline experience. I think we should proceed with @Tony-MK.
C+ reviewed 🎀 👀 🎀

@luacmartins Do you know any reasons not to update the participantAccountIDs optimistically in editTaskAssigneeAndNavigate?

I think we should be good to set participantAccountIDs optimistically in editTaskAssigneeAndNavigate . The only edge case I can think of is if the new assignee is an unknown user. In that case the accountID would be optimistic and might differ from the real accountID, but in that case the server should be updating that assignee accountID.

Disregard Melvin message above, this one is awaiting PR from @Tony-MK

Hey @cubuspl42, I have created the pull request. Could you kindly find some time to review it?

Hey @cubuspl42, I have created a PR. Could you kindly find some time to review it?
Thank you 😃

Issue not reproducible during KI retests. (First week)

PR deployed to staging on 11/2

Hey @cubuspl42 can you complete the BZ checklist please?

The PR that introduced the bug has been identified. Link to the PR:

It seems that the bug was present in the relevant components since they were created

The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:

N/A

A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:

No need for additional discussion

Determine if we should create a regression test for this bug.

Up to the QA team

If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

Create a task.
Assign the task to an account other than your own.
Click on the task header.
Confirm that the assignee is listed.
Reassign the task to a yet another account (not yours or the one previously selected).
Click the task report header again.
Ensure that the member count has incremented by one.
Confirm that the members list now includes the newly assigned member.

Summarizing payment on this issue:

Issue reporter: @dhanashree-sawant $50 via Upwork -- PAID
Contributor: @Tony-MK $500 via Upwork -- PAID
Contributor+: @cubuspl42 $500via Upwork  -- PAID

Upwork job is here, no bonus is included on payout


assertSchemaPut for single updates

I recently user assertSchemaPut for an put action on single entry.
For example: I want to update an user's profile
Put  /user/1/
data = {
"name": "user1",
"city": "NY"
}
response = self.assertSchemaPut(url, request_object_name, response_object_name, data, user=self.admin).
And the console show some error:
self.check_schema_keys(data[0], self.schema_objects[request_object_name])

KeyError: 0
I guess the method not support for single update.But if there any way work for me to update single entry?

def assertSchemaPut(
        self,
        url,
        request_object_name,
        response_object_name,
        data,
        user,
        format="json",
        unauthorized=False,
        forbidden=False):
    """
    Assumes PUT is used for bulk updates, not single updates.
    Runs a PUT request and checks the PUT data and results match the
    schema for bulk updates. Assumes that all objects sent in a bulk
    update are identical, and hence only checks that the first one
    matches the schema.
    """

@tmacjx you can use PATCH and assertSchemaPatch for updates of single objects

@baylee  thanks a lot


Initial LED state wrong with A1

If you put the "S" pot all the way to the left, and power up, you will not get the "A1" display. LEDs will be off until you move the pot

fixed for version 0.2.0


Rider does not connect to Unreal

Rider version: 2023.1.2
UnrealLink plugin version: 2<IP_ADDRESS>2
Unreal version: 5.2
The Unreal icon in Rider always shows the Not Connected to Unreal Editor status, even though the Unreal Editor is open. I've tried fresh installs with multiple versions of Rider, and two different versions of Unreal (5.0.2 and 5.2), all on the same project.
When opening the .sln of the Unreal project in Rider for the first time, Rider doesn't ask me to install RiderLink for the Unreal project, so I've been manually adding it to the {Project}/Plugins/Developer/RiderLink. Unreal needs to re-compile the plugin, but it succeeds and the plugin shows up in the Unreal plugins list.
If I try to install or extract the plugin in engine or game, from the RiderLink Installation Settings, nothing happens (I click the buttons, but I get no response, and nothing appears in the Rider logs.)
The one possibly relevant snippet of the Rider logs I see is the following, which happens when opening Rider:
--- EXCEPTION #1/2 [InvalidOperationException]
Message = “Sequence contains more than one matching element”
ExceptionPath = Root.InnerException
ClassName = System.InvalidOperationException
Data.ThreadLocalDebugInfo = ScheduleNextSolutionLoadTask
HResult = COR_E_INVALIDOPERATION=80131509
Source = System.Linq
StackTraceString = “
  at System.Linq.ThrowHelper.ThrowMoreThanOneMatchException() in ThrowMoreThanOneMatchException.il:line IL_000A mvid AB96
     at System.Linq.Enumerable.TryGetSingle[TSource](IEnumerable`1 source, Func`2 predicate, Boolean& found) in TryGetSingle.il:line IL_0072 mvid AB96
     at System.Linq.Enumerable.Single[TSource](IEnumerable`1 source, Func`2 predicate) in Single.il:line IL_0000 mvid AB96
     at RiderPlugin.UnrealLink.PluginInstaller.UnrealPluginDetector.<>c__DisplayClass17_0.<.ctor>b__2() in D:\WORK\UnrealLink\src\dotnet\RiderPlugin.UnrealLink\PluginInstaller\UnrealPluginDetector.cs:line 121
     at JetBrains.ProjectModel.Tasks.SolutionLoadTasksSchedulerBase.<>c__DisplayClass21_0.<ExecuteTask>b__1() in SolutionLoadTasksSchedulerBase.il:line IL_0000 mvid 9C09
     at JetBrains.Util.ILoggerEx.Catch(ILogger thіs, Action F, ExceptionOrigin origin, LoggingLevel loggingLevel) in Catch.il:line IL_0075 mvid E750
”

For context, I had an old installation of Rider (maybe one of the 2021 versions) working well with this Unreal project -- it had the Unreal connection icon in the bottom-right, if that helps at all -- but things stopped working as soon as I updated the IDE.
Let me know if you need anything else to help me localize the issue. I love Rider, but it's been real frustrating trying to deal with this issue, running out of things to try.

Hello
Can you double check that UnrealLink plugin is enabled in the Rider?
Settings > Plugins > Installed

Gosh, yes, that's what the more than one matching element was talking about! I had two .uproject files, one was a backup from before I'd turned my project into a C++ one. I removed it and Rider went ahead with installing RiderLink, things working again, thanks a lot!
Assuming the previous Rider / RiderLink / UnrealLink versions I was using when link was working didn't care about multiple .uproject files? Anyway, thanks again for the prompt reply & helping.

I am glad to help!

Hi there, our workflow need us to have multiple uproject on the same directory, but according to this issue, it prevents us to use UnrealLink... Is there anything we could make to allow UnrealLink ? ?

Today, I had a similar issue where I wasn't able to install RiderLink, so Rider was never able to connect to the Unreal Editor.
Turns out I needed to open Rider with Admin privileges, to be able to install RiderLink.
This fixed the connection issue for me! :)
https://github.com/JetBrains/UnrealLink/issues/262#issuecomment-1849232203


[Feature Request] Default Root Folder

Consider allowing an optional setting in settings.py to set a default root folder and therefore not ask users what folder they want to use. Alternatively hide root folders x,y,z from searcharr.

Considering for v2

This will be added in v2, and it is already included in v2.0-b3 which is available in the beta branch here as well as the toddrob/searcharr:beta docker image.
Add the following to settings.py and fill in the root folder(s) you want to allow users to choose from. If you want to force one root folder, put only that one in the list.
sonarr_series_paths = []  # e.g. ["/tv", "/anime"] - can be full path or id value - leave empty to enable all
radarr_movie_paths = []  # e.g. ["/movies", "/other-movies"] - can be full path or id value - leave empty to enable all
You can also use the id values from the Sonarr/Radarr API, e.g. sonarr_series_paths = [1, 2].

Thank you.
I added my movie path and it didn't work. I checked the logs and had not formatted the path correct "/a/working/path". So corrected that and thats working beautifully. User sees no questions about quality or paths.
Doing the exact same for series gives me no error log about a bad syntax or bad path. Seems to work, but still asks user from a selection of paths.
for reference, the radarr path setting in settings.py
radarr_movie_paths = "/media/movies-remove"
and sonarr
sonarr_series_paths = "/tv/shows-remove"
I can comform via bash command pwd that these are the correct paths and also confirm they are correct in both sonarr and radarr.
the quality selection is perfect for both.

@Pantar2205 can you please post your logs? You should have a log entry that starts with: No valid Sonarr root folder(s) provided! Using all of the root folders I found in Sonarr:. I'm interested to see that log entry as well as a few lines before and after.
If you haven't already, please enable debug logging.

Sorry I went digging around myself and It has been resolved but I am not sure how. I noticed I had mistakenly set the container to run as root by mistake. changing that, then setting radarr and sonarr tags to False has fixed the problem without touching the  sonarr path i have set at all. i don't have logs as i deleted them and chowned the config directories when i change my docker compose file. from a settings.py point of view, the only thing i altered was sonarr_tag_with_username = False and radarr_tag_with_username = False
radarr worked before i did that, but doing that seemed to fix sonarr

That shouldn't have had any impact on the root folders, but I'm glad it's fixed.