How to correctly screenshot this type of website

Steps to reproduce
Tell us about your environment:

Puppeteer version: 1.11.0
Platform / OS version: Mac
URLs (if applicable): https://www.jackall.co.jp/rooster/
Node.js version: v10.15.0

What steps will reproduce the problem?
Please include code that reproduces the issue.

I write normal screenshot function to screenshot the webpage. For static website, It worked perfectly fine. But, when I try to screenshot this website ( https://www.jackall.co.jp/rooster/), it didn't screenshot correctly. How to deal with this kind of website?

Here are the code :
let browser = await puppeteer.launch({executablePath: process.env.EXECUTABLE_PATH});
let page = await browser.newPage();
const override = Object.assign(page.viewport(), {width: width});
 if(isAuthenticated){
await page.authenticate({username:body.authentication.username, password:body.authentication.password});
}
await page.goto(url, {waitUntil: 'load',timeout: 0});
await page.setViewport(override);
await page.screenshot({ path: ./${fileName},fullPage: true });
await page.close();
await browser.close();
What is the expected result?
https://pu-ai-bc-ruby.s3.ap-southeast-1.amazonaws.com/designs/jackallrgm[test]-00250/04ec906b1eaf12ead6b8ac961bd0b5fc/1360/41a55f7a5dcd6ca5c928749997999bab26feb82c5cfac774.png
What happens instead?
https://pu-ai-bc-ruby.s3.ap-southeast-1.amazonaws.com/screenshots/a003eac153b830c35895df406c60169a/04ec906b1eaf12ead6b8ac961bd0b5fc/1360/103a21e452f05c2f39080967a95.png

This happens because Puppeteer overrides the device metrics to be the height of the scrollable content but the site was not built to handle that. You can see the effect (which is similar to your result) by emulating a device in devtools and setting the height to the maximum (9999).

If Page.js:892 is commented out then the following script produces something better.

const puppeteer = require('puppeteer');

(async function(){
  let browser = await puppeteer.launch({headless:false, defaultViewport:null});
  let page = await browser.newPage();
  await page.goto('https://www.jackall.co.jp/rooster/');
  await page.evaluate(_ => {
    while (document.body.scrollHeight < (window.scrollY + window.innerHeight)) {
      window.scrollBy(0, window.innerHeight);
    }
  });
  await page.screenshot({ path: 'issue-4211.png', fullPage: true });
  await browser.close();
}())

It's not uncommon to see sites break at extreme aspect ratios so the emulation should probably be an option that can be disabled.

@jsoverson Thank you for you help. For clarification, I need to comment this code
await this._client.send('Emulation.setDeviceMetricsOverride', { mobile: isMobile, width, height, deviceScaleFactor, screenOrientation }); in node_modules/puppeteer/lib/Page.js  first
before I can try your script, right?

@jsoverson Are there any other ways to do that one beside commenting that code await this._client.send('Emulation.setDeviceMetricsOverride', { mobile: isMobile, width, height, deviceScaleFactor, screenOrientation }); .

It looks like you can get the same effect without worrying about that line by manually setting the clip dimensions to the size of the content:
const puppeteer = require('puppeteer');

(async function(){
  let browser = await puppeteer.launch({
    headless:false,
    defaultViewport: {
      width:1900,
      height:1080
    }
  });
  let page = await browser.newPage();
  await page.goto('https://www.jackall.co.jp/rooster/');
  const height = await page.evaluate(_ => {
    return document.body.scrollHeight;
  });
  await page.screenshot({ path: 'issue-4211.png', clip : { x: 0, y: 0, width:1900, height, scale: 1 }});
  await browser.close();
}())

@jsoverson Thanks you.
I have another question that is not related to this topic. Can we install puppeteer-core and chrome browser in two separate servers and connect it together? I plan to put puppeteer-core function code in AWS Lambda. So, I need to install chrome browser in EC2 server.

Looks like original question is addressed, so I'll close this.

I have another question that is not related to this topic. Can we install puppeteer-core and chrome browser in two separate servers and connect it together?

Yes you can; this is not the best place to ask about installing Chrome on AWS though - I'd search around or ask on StackOverflow.

I got two similar websites or lets say results.. I have still problems to capture them:
page 1
page 2
(Normal long websites seem to be incomplete with the method from above and ~40% of the bottom of the image is white)
When I observe the behavior on my screen with headless false, the website looks like it should, but when the screenshot method goes in action the top image/mp4 background becomes very large on the screen
Thats the maximum I can get out of it


Issue with Roo's xenotypes mods

Upon loading a save with pawns that have UnguligradeLegPart from Roo's mods, efficiency keeps getting reset to 0%. Removing the parts with devmode and reapplying base genes results in the same downed status. They're not flagged as an added part or implant in his xmls, so something is getting lost in translation between there and here. I'm no coder and everything of yours is packed in .dlls so I can't just edit an .xml file to add it myself. I'd make a PR here, but I have zero experience with anything Git related. But judging on how you fixed RoM, you could probably just copy the few lines you used there and literally change one letter and I'd bet that it'd address the Roos issue, too. You'd know better than me!

Can you link to what mod you are talking about?

These mods here:
https://steamcommunity.com/sharedfiles/filedetails/?id=2927812651
https://steamcommunity.com/sharedfiles/filedetails/?id=2971803439
https://steamcommunity.com/sharedfiles/filedetails/?id=2971801826
They all use the same leg type.


Array macros

related to #5520
Description
All the related pull requests:

https://github.com/dbt-labs/dbt-core/pull/5823
https://github.com/dbt-labs/dbt-redshift/pull/182
https://github.com/dbt-labs/dbt-snowflake/pull/257
https://github.com/dbt-labs/dbt-bigquery/pull/308
https://github.com/dbt-labs/dbt-spark/pull/454

Checklist

[x] I have read the contributing guide and understand what's expected of me
[x] I have signed the CLA
[x] I have run this code in development and it appears to resolve the stated issue
[x] This PR includes tests, or tests are not required/relevant for this PR
[x] I have opened an issue to add/update docs, or docs changes are not required/relevant for this PR

https://github.com/dbt-labs/docs.getdbt.com/issues/2049

[x] I have run changie new to create a changelog entry

This is ready for review.
After it is approved and merged, I will revert the changes to dev-requirements.txt in each of the adapter PRs before merging each of them:

https://github.com/dbt-labs/dbt-redshift/pull/182
https://github.com/dbt-labs/dbt-snowflake/pull/257
https://github.com/dbt-labs/dbt-bigquery/pull/308
https://github.com/dbt-labs/dbt-spark/pull/454


what is :image-data-fun in org-link-set-parameters?

is this used anywhere? I am not familiar with that link attribute.

@jkitchin that property seems to add the image previewing capability.
With that code having run, I org-toggle-inline-images will display excalidraw:... images inline.

@jkitchin
I had the same question.. it turns out this parameter comes from org-yt (https://github.com/TobiasZawada/org-yt/blob/56166f48e04d83668f70ed84706b7a4d8b1e5438/org-yt.el) which adds some support for user defined image links.
This package implicitly depends on that feature for displaying images. This also explains https://github.com/wdavew/org-excalidraw/issues/2
I managed to "fix" this by just copying the org-image-update-overlay and org-display-user-inline-images functions from org-yt into my user config, and adding the relevant advice:
  (advice-add #'org-display-inline-images :after #'org-display-user-inline-images)


Text Layout without float and CSS Exclusions

I'm trying to layout text with react-native and see some constraints in the layout engine for text-layout.
I was wondering if there are any plans in supporting text that flows around images?
In the browser this would be done with float or CSS Exclusions/Regions (In the near future).
Have there been any discussions in supporting such a use case?
And of course, if this somehow already is possible in some way that I have missed, please let me know.
Included a screenshot with a typical broswer-of-today image-floating.

The repo to discuss this on is facebook/css-layout. It might be a long time before this is implemented though so if you need it you should write a custom native component.

I think this is a great feature request to add to Product Pains - can you repost it there @olofd? Thanks!

Will do! @brentvatne


Build Doris 0.11.25 thirtyparty on CentOS 7.5 Report Error and Exit

When build Doris 0.11.25 thirtyparty with GCC 5.3.1 on CentOS 7.5, it report error and exit:
-- Installing: /bak/incubator-doris-DORIS-0.11.25-release/thirdparty/installed/include/parquet/util/comparison.h
-- Installing: /bak/incubator-doris-DORIS-0.11.25-release/thirdparty/installed/include/parquet/util/crypto.h
-- Installing: /bak/incubator-doris-DORIS-0.11.25-release/thirdparty/installed/include/parquet/util/macros.h
-- Installing: /bak/incubator-doris-DORIS-0.11.25-release/thirdparty/installed/include/parquet/util/memory.h
-- Installing: /bak/incubator-doris-DORIS-0.11.25-release/thirdparty/installed/include/parquet/util/schema-util.h
-- Installing: /bak/incubator-doris-DORIS-0.11.25-release/thirdparty/installed/include/parquet/util/test-common.h
-- Installing: /bak/incubator-doris-DORIS-0.11.25-release/thirdparty/installed/include/parquet/util/visibility.h
-- Installing: /bak/incubator-doris-DORIS-0.11.25-release/thirdparty/installed/include/parquet/util/windows_compatibility.h
cp: cannot stat ‘./zstd_ep-install/lib/libzstd.a’: No such file or directory
How can I do with it?

As I have tried in centos 7.6 with gcc-7.3.0, you can build libzstd.a with this method.
cd thirdparty/src/zstd-1.3.7/tests
make zstd-staticLib
mkdir -p apache-doris-0.12.0-incubating-src/thirdparty/src/arrow-apache-arrow-0.15.1/cpp/release/zstd_ep-install/lib64
cp ../lib/libzstd.a /PATH/TO/apache-doris-0.12.0-incubating-src/thirdparty/src/arrow-apache-arrow-0.15.1/cpp/release/zstd_ep-install/lib64

Please build Doris by docker. http://doris.apache.org/master/zh-CN/installing/compilation.html#使用-docker-开发镜像编译（推荐）

However, it's a problem that I use arm64/v8 to build doris, but I do not see the docker images with arm64. So do we have any plan to build docker images of arm64 arch?

I understand that as long as you can run docker on the machine, it should be fine.

Yeah, I just find the Dockerfile and will try to build a homebuild arm64 docker images to compile doris. Thanks


(maint) Bump bundled modules

This updates the following bundled modules to their latest versions:

pkcs7 0.1.2
puppet_agent 4.7.0
scheduled_task 3.0.1
stdlib 7.1.0

!feature

Update bundled modules to latest versions
The following bundled modules have been updated to their latest
versions:

pkcs7 0.1.2
puppet_agent 4.7.0
scheduled_task 3.0.1
stdlib 7.1.0

The puppet-agent update is pretty Bolt relevant, can the release note include that the puppet_agent::install task now supports noop mode?

Updated.


Unable to upgrade a Smabit AV2010/10 dongle

Hello,
I have a Smabit (Bitronvideo) AV2010/10 dongle that I'mtrying to update with firmware from this repository: https://github.com/grobasoz/zigbee-firmware/tree/master/EM3587
I believe that I have installed everything properly, but the utility does not seem to be able to place the stick in bootloader mode:
[obones@server ZigbeeFirmware]$ python3 Elelabs_EzspFwUtility.py restart -p /dev/ttyUSB2 -m btl
2022/01/16 10:51:15 Elelabs_EzspFwUtility:   Generic Zigbee EZSP adapter detected:
2022/01/16 10:51:15 Elelabs_EzspFwUtility:   Firmware: 6.7.8-117
2022/01/16 10:51:15 Elelabs_EzspFwUtility:   EZSP v8
2022/01/16 10:51:15 Elelabs_EzspFwUtility:   Launch in bootloader mode
2022/01/16 10:51:20 Elelabs_EzspFwUtility:   Generic Zigbee EZSP adapter detected:
2022/01/16 10:51:20 Elelabs_EzspFwUtility:   Firmware: 6.7.8-117
2022/01/16 10:51:20 Elelabs_EzspFwUtility:   EZSP v8
[obones@server ZigbeeFirmware]$ python3 Elelabs_EzspFwUtility.py flash -p /dev/ttyUSB2 -f NCP_USW_EM3587-LR_678-115k2.ebl
2022/01/16 10:51:28 Elelabs_EzspFwUtility:   Generic Zigbee EZSP adapter detected:
2022/01/16 10:51:28 Elelabs_EzspFwUtility:   Firmware: 6.7.8-117
2022/01/16 10:51:28 Elelabs_EzspFwUtility:   EZSP v8
2022/01/16 10:51:28 Elelabs_EzspFwUtility:   Launch in bootloader mode
2022/01/16 10:51:33 Elelabs_EzspFwUtility:   Generic Zigbee EZSP adapter detected:
2022/01/16 10:51:33 Elelabs_EzspFwUtility:   Firmware: 6.7.8-117
2022/01/16 10:51:33 Elelabs_EzspFwUtility:   EZSP v8
2022/01/16 10:51:33 Elelabs_EzspFwUtility:   EZSP adapter not in the bootloader mode. Can't perform update procedure
[obones@server ZigbeeFirmware]$ python3 Elelabs_EzspFwUtility.py restart -p /dev/ttyUSB2 -m nrml
2022/01/16 10:52:40 Elelabs_EzspFwUtility:   Generic Zigbee EZSP adapter detected:
2022/01/16 10:52:40 Elelabs_EzspFwUtility:   Firmware: 6.7.8-117
2022/01/16 10:52:40 Elelabs_EzspFwUtility:   EZSP v8
2022/01/16 10:52:40 Elelabs_EzspFwUtility:   Allready in normal mode. No need to restart

What have I missed?
Should I reset it completely with a special command before trying to flash it?

@obones
Hello,
Everything looks in order from the communication perspective.
You can enable additional logs with -d RAW option.
However, you should probably ask the manufacturer support if the dongle has the bootloader enabled/integrated.
The utility just sends a command reboot into bootloader. But if the device doesn't have a bootloader, or firmware doesn't understand understand this command, the device will be back into regular EZSP operation mode.

Ok, thanks, I'll contact the vendor then.


chore: update to Nx 19.6.5

@goetzrobin pleas authorize vercel so I can proceed

@goetzrobin pleas authorize vercel so I can proceed

Done!

@goetzrobin pleas authorize vercel so I can proceed

Done!

@goetzrobin unfortunately there is still some issue

@goetzrobin lol ... my bad ... I'll fix in a few hours. That was a GPT error. I was rushing to get to a family party

No worries! Enjoy the party! 🎉🎉

Almost there now ... just need to fix these e2e tests

@goetzrobin this is ready to go .... I would request to open issues and fix the few tests I commented out in follow-up PRs.
These can be found by searching /* TODO: @goetzrobin


internationalized models validation error messages

🔗 Issue
#153
✍ Description

Added internationalization to model validation error messages
📷 Screenshots/Demos

Can someone review this and see if I need to change anything?

test is failing for main, do I need to fix this to proceed?

@DreamVenerable I think it's a flaky test. Not an issue with this PR, as it sometimes fail on other branches, too.
Did you manually check these errors being rendered for each model?

I checked these errors on the console, but not on render. I'll go check them right now

@kasugaijin I can't run latest migration, which is stopping me from opening the web app on localhost

Try merging main branch into yours then see if that helps.

I checked these errors on the console, but not on render. I'll go check them right now

Ok great. No need to check every error but just check that each mod it getting it's errors from the yml file. Change the yml text temporarily to make sure if you want an easy way to check.

Try merging main branch into yours then see if that helps.

It didn't help, I even tried on main and I also can't run migration there

OK I think I know why. This merge into main https://github.com/rubyforgood/pet-rescue/commit/441a2be50c649ca48accd207afd478ed9e59abd3#diff-9e93b7ccff26ecc886221d13724d22344e7bcf2c14bccdf8ef7c6fa9fb659543 removed the strong_migrations gem which is what provides the safety_assured method. Can you please re-write that failing migration so it is not using safety_assured? That should then get it to migrate. You can also keep and commit that change so we reflect it in main branch.

Alright, I'll do that, thanks for the help!

@kasugaijin I checked and indeed there were some errors that got their start cut off or didn't reflect changes in the yml.
Now it should be all good I hope

Looking good so far. In case you have not, I'd recommend checking all models and their validations to make sure you have captured the potential errors :) Case in point there is a validation on Pet to make sure weight_to is  greater number than weight_from that was missing in the .yml

Hey @DreamVenerable are you happy with this PR now? No rush!

@kasugaijin First time using the review feature yesterday, but it seems like you don't see it cuz its pending?

Anyways, yes for the most part this PR looks good enough

@DreamVenerable Oh sorry I did not see that or get notified for it. I think we can keep the validation. There's no guarantee the JS validation will work/remain in use in the future, so a back end validation is a good thing.

Alright then!
Is this PR ready to be merged?


nginx-prometheus-exporter can not start nginx client

Hi
I was trying to run the yearn-exporter on my Ubuntu but I am getting the error related to nginx client starting.
Here is my error message.
2021/07/13 19:02:23 Could not create Nginx Client: expected 200 response, got 404
Is there any additional settings to be customized in prometheus?
Thanks.

hi @leonboripgs
the nginx exporter has been removed by d61f78bd860394463d2e50747b957609227f148a
git pull and rebuilding should fix it :-)


libslirp: fix CVE-2020-29129

Motivation for this change
Fixes out-of-bounds access while processing ARP/NCSI packets.
Fixes: CVE-2020-29129
https://lists.freedesktop.org/archives/slirp/2020-November/000115.html
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

FWIW: QEMU will still be vulnerable, because we are currently using a vendored libslirp version.
#101608 was going to change that, but didn't happen. Can I pick up those changes? @zowoq

Patched the vendored libslirp in QEMU as well.

Ported to 20.09 in b7fd0c05a61bd78d9d98660714ebda26c9e36d74 aa8ba404e2af68a4b84de5b714a9951fa5664290


broot: 0.19.3 -> 0.19.4

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/Canop/broot/releases.
meta.description for broot is: "An interactive tree view, a fuzzy search, a balanced BFS descent and customizable commands"
meta.homepage for broot is: "https://dystroy.org/broot/"
meta.changelog for broot is: ""
Updates performed

Rust version update

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact

Checks done (click to expand)

built on NixOS

The tests defined in passthru.tests, if any, passed

0 of 0 passed binary check by having a zero exit code.

0 of 0 passed binary check by having the new version present in output.

found 0.19.4 with grep in /nix/store/1sqgmp8rwmb9xrxj0j5m1qb0smwk87ll-broot-0.19.4

directory tree listing: https://gist.github.com/9ee1f6733aabdffccf0906e1f27736a3

du listing: https://gist.github.com/c3eaa0ee90345a9b90165e101b096543

Rebuild report (if merged into master) (click to expand)

4 total rebuild path(s)

1 package rebuild(s)

1 x86_64-linux rebuild(s)
1 i686-linux rebuild(s)
1 x86_64-darwin rebuild(s)
1 aarch64-linux rebuild(s)

First fifty rebuilds by attrpath
broot

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/1sqgmp8rwmb9xrxj0j5m1qb0smwk87ll-broot-0.19.4 \
  --option binary-caches 'https://cache.nixos.org/ https://r-ryantm.cachix.org/' \
  --option trusted-public-keys '
  r-ryantm.cachix.org-1:gkUbLkouDAyvBdpBX0JOdIiD2/DP1ldF3Z3Y6Gqcc4c=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(r-ryantm's Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A broot https://github.com/r-ryantm/nixpkgs/archive/41d1d1d2bbb13d9832dbbd63d2fd60499105a13c.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/1sqgmp8rwmb9xrxj0j5m1qb0smwk87ll-broot-0.19.4
ls -la /nix/store/1sqgmp8rwmb9xrxj0j5m1qb0smwk87ll-broot-0.19.4/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review 1

1 package built:

broot

Maintainer pings
cc @magnetophon for testing.

Is anyone up for being the maintainer of this package?
@danieldk ,@bbigras, @bhipple
I don't use it anymore, and I feel like I'm letting you down every time there is an update and I don't test it.

note that the broot dev is trigger-happy with the releases.
I update broot less often now because a lot of time there's multiples new releases in the following days.

note that the broot dev is trigger-happy with the releases.
I update broot less often now because a lot of time there's multiples new releases in the following days.

Worst case, we can let r-ryantm do the work, but I don't mind testing the PRs and merging them.


Nil pointer error while creating a logstream

I'm getting a nil pointer error, possibly due to AWS API changes.
Per AWS api doc cloudwatchlogs.New expects a session config provider
panic: runtime error: invalid memory address or nil pointer dereference
[signal 0xb code=0x1 addr=0x20 pc=0x5d4ea6]
goroutine 16 [running]:
runtime.panic(0x846b20, 0xb2c213)
/usr/lib/go/src/pkg/runtime/panic.c:279 +0xf5
github.com/aws/aws-sdk-go/service/cloudwatchlogs.New(0x0, 0x0, 0x0, 0x0, 0x0, 0xc20806f570)
/go/src/github.com/aws/aws-sdk-go/service/cloudwatchlogs/service.go:72 +0x76
github.com/bradgignac/logspout-cloudwatch.NewLogStream(0x7ffc3c41df55, 0x9, 0xc208037010, 0xc, 0xc20806f868, 0x0, 0x0)
/go/src/github.com/bradgignac/logspout-cloudwatch/logstream.go:20 +0x52
github.com/bradgignac/logspout-cloudwatch.NewAdapter(0xc208042360, 0x0, 0x0, 0x0, 0x0)
/go/src/github.com/bradgignac/logspout-cloudwatch/cloudwatch.go:49 +0x105
github.com/gliderlabs/logspout/router.(*RouteManager).Add(0xc208022db0, 0xc208042360, 0x0, 0x0)
/go/src/github.com/gliderlabs/logspout/router/routes.go:117 +0x203
github.com/gliderlabs/logspout/router.(*RouteManager).AddFromUri(0xc208022db0, 0x7ffc3c41df48, 0x16, 0x0, 0x0)
/go/src/github.com/gliderlabs/logspout/router/routes.go:107 +0x354
github.com/gliderlabs/logspout/router.(*RouteManager).Setup(0xc208022db0, 0x0, 0x0)
/go/src/github.com/gliderlabs/logspout/router/routes.go:186 +0x1bb
main.main()
/go/src/github.com/gliderlabs/logspout/logspout.go:39 +0x646
goroutine 17 [runnable]:
runtime.MHeap_Scavenger()
/usr/lib/go/src/pkg/runtime/mheap.c:507
runtime.goexit()
/usr/lib/go/src/pkg/runtime/proc.c:1445
goroutine 18 [runnable]:
bgsweep()
/usr/lib/go/src/pkg/runtime/mgc0.c:1976
runtime.goexit()
/usr/lib/go/src/pkg/runtime/proc.c:1445
goroutine 19 [runnable]:
runfinq()
/usr/lib/go/src/pkg/runtime/mgc0.c:2606
runtime.goexit()
/usr/lib/go/src/pkg/runtime/proc.c:1445

Hi @podiyan, this was caused by a recent update to the AWS Golang SDK. I have a branch almost ready to go that will resolve the issue along with a few other CloudWatch error conditions I've run into. Hope that helps!

Yes, just noticed your PR #16  That'd help.
Thanks for sharing logspout-cloudwatch this fits my requirements exactly :). Much better and organized than what i was attempting to do.

Do you plan to merge PR 16 soon?

@podiyan I should be able to get it merged this week. I really want to get it in this evening, but I'm traveling so it's hard to make a firm commitment.

Thanks Brad.
Looking forward to your merge.
From: Brad Gignac
Sent: Monday, December 7, 3:09 PM
Subject: Re: [logspout-cloudwatch] Nil pointer error while creating a logstream (#17)
To: bradgignac/logspout-cloudwatch
Cc: Kannan Parthasarathy
@podiyan I should be able to get it merged this week. I really want to get it in this evening, but I'm traveling so it's hard to make a firm commitment.
—
Reply to this email directly or view it on GitHub.

Forked code to do some tests, I could see that the issue is fixed with PR 16.
Thanks


Obsolete mirror

Hi, the Italian mirror is not more operative, just FYI. AFAIK there is not an open mirror currently.

Thanks for the update - Italian, Swedish mirror both removed as defunct.


Subsitution support in Figure Directive

Problem
Images are defined with subsitutions so they can be used in multiple places.
.. |file_1| image:: /images/file-1-light.jpg
  :alt: File View

However, it is impossible to then use this substitution in a figure like so:
 .. figure:: |file_1|
    :align: center

    File view

I would expect this is a very common use case and can't understand why it isn't supported. Work-arounds encapsulating the image and figure in a table is the only current solution.
Error Logs/Results
Place any images or error logs that might be able to help solve the issue here.
Error is below
WARNING: image file not readable: |file_1|

Expected Results
Should be able to read an image substitution within a figure.
Environment Info

Python Version:
Sphinx Version:
RTD Theme Version:

This is not an issue specific to the theme but a limitation of sphinx/docutils. I would suggest doing a feature request for sphinx/docutils.
It might be possible for this to be made to work but I am not sure, you will have to talk to people who know more about  sphinx/docutils.
.. |file_1|  /images/file-1-light.jpg

.. figure:: |file_1|
   :align: center

   File view

The sphinx repository to create a feature request is here: https://github.com/sphinx-doc/sphinx


Where is reduxCrud.Map.reducersFor?

In the current latest npm version, reduxCrud.Map.reducersFor is ""

Uh, I forgot to link some modules and didn't have a test for that. Sorry. Fixed in 3.0.1

Thanks for the quick fix.
Nice library. I like how it follows the "redux way" - small set of easy to understand pure functions, very useful.

On 27 Jan 2017, at 21:52, Sebastian Porto<EMAIL_ADDRESS>wrote:
Closed #40.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.


Require PostgresSQL 12 or greater, test with 16

Postgres 10 and 11 support is dropped
Postgres tests now execute on 16

Ref: https://endoflife.date/postgresql
:warning: BREAKING :warning:
Support for Postgres 10 and 11 is dropped, you are encouraged to upgrade to 12 or higher.

Actually I will combine this into the MySQL PR as merging these would present conflicts to each other.


[ICONS] fixed icon alignment inside a button

Signed-off-by: Shijir Tsogoo<EMAIL_ADDRESS>

@Shijir: Please add more details on your PR description. Details like screenshots, which browsers you have tested this change on etc.


DMN style Hit Policies for Decision Tables

This adds several features listed in the tickets below.
Existing Verification checks are disabled if they make no sense for the selected hit policy.
 What is still missing is Verifier managing overlaps, salience and activation-group. This doesn't mean it is possible to make a table that has a Hit Policy and does not work like the Hit Policy should work. It just means that the user is more likely to add lines that can never fire or can be removed.

Guided Decision Tables: Add hit policy selection into dtable creation
https://issues.jboss.org/browse/GUVNOR-2774
Guided Decision Table V&V - Hit policy: None
https://issues.jboss.org/browse/GUVNOR-2650
Guided Decision Tables: Prevent the use of salience and agenda/activation-group if the selected hit mode requires them
https://issues.jboss.org/browse/GUVNOR-2785
Guided Decision Table: Show current hit policy in the table
https://issues.jboss.org/browse/GUVNOR-2798

Looks like the tests pass.
@manstis This could use a review please ( and/or anyone else who is interested).
Not in a hurry working on top of this.

Going to also change the First to Reserved hit. And now that I think about this. This PR should not be accepted before I have updated docs.

Hi @Rikkola . I put some comments to this PR, however in general I think it is another your fine PR with good code coverage. Thanks.

Thank you for the review @jomarko . Made the required changes.
Currently doing the docs. Hit Policies might stay as they are so not working on those.

@manstis @jomarko
Ok did the fixes and verified that these changes fit in with the latest Hit Policy specification. This still lacks the Hit Policy Resolved, but that can be done as a separate patch.
Also rebased with the latest master. Tests are still running.

@Rikkola @jomarko Can this be merged now?

Hi @Rikkola, @manstis . I did the review right now. I put some minor things into comments, however I didn't find any other problem that could prevent from merging.

@Rikkola @jomarko OK, just let me know when you want it merged.
@Rikkola IDK if you was going to make any of @jomarko change suggestions.

@jomarko @manstis This and the one in drools could use a second review. Here the new changes are in the second commit. In drools the HP resolving has completely changed.
The second commit depends on this. https://github.com/droolsjbpm/drools/pull/1084

Jenkins please retest this.

@Rikkola branch names for drools and drools-wb PRs are different so Jenkins cannot correlate the two.. I suspect that is leading to the compilation error on this PR :-(

@manstis Yes, had to either do it this way or open yet another PR. But the one in drools can be merged individually and then this one should pass.

Jenkins please retest this.


安装成功  引用失败

"export 'default' (imported as 'treeTransfer') was not found in 'el-tree-transfer'

更新版本


Mismatching hash of the downloaded nuget when AppVeyor build

We get a "Mismatching hash of the downloaded nuget" error when running a AppVeyor CI build.
Error message is:
Mismatching hash of the downloaded nuget
At C:\projects\guetzli\vcpkg\scripts\fetchDependency.ps1:214 char:9
throw [System.IO.FileNotFoundException] ("Mismatching hash of ...
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
CategoryInfo          : OperationStopped: (:) [], FileNotFoundException
FullyQualifiedErrorId : Mismatching hash of the downloaded nuget
Command exited with code 1
Full log is here。 Please help.
Thanks!
.

Awesome to see someone attempting to get AppVeyor in vcpkg!

It looks like you're downloading the latest[1] instead of the 3.5.0 stable that we expect[2].
[1] https://dist.nuget.org/win-x86-commandline/latest/nuget.exe
[2] https://dist.nuget.org/win-x86-commandline/v3.5.0/nuget.exe

@ras0219-msft Thanks for your reply, I did use the latest one. I will changed it to v3.5.0.


Use organisation Display name instead of organization name

Hey guys,
it would look a bit better if we Display the Displayname of an Organization insted of their "username"
f.e. at Adobe:
adobe
but:
Adobe Systems Incorporated
Is their Display Name.
Looks better doenst it?
I would take care of this if you guys want this to be improved too.

What about :
Adobe Systems Incorporated
        (@adobe)

If doing both, we have to worry a bit about space. It might cut off the login for long names, and I feel like that should be avoided.

i think its better to use Adobe Systems Incorporated on the users Screen.
And on the organization Screen itself we could use both as @machour suggested.
What do you think @andrewda


Make source code cross-platform

Make sure that code can also be compiled by a unix compiler (ie gcc).

Create folder 'cmake' at the root of the repository. Add multiple scripts to create the project files under /cmake/build so it does not interfere with existing project files.


Internal anchors are broken

Hi
enabling the printfriendly plugin all the internal anchors (page#anchor_name) are broken, making them duplicated inside the hidden div dialogDiv.
A simple workaround would be to move the dialogDiv after the real content, in this way the anchor will automatically point the first found, then the anchor not hidden.
Tested under:
OS: Arch Linux x86_64
Browsers: Firefox 48.0.2 and Google Chrome 53.0

just to bring some elements, the duplicate content created by print friendly can also cause troubles with other plugins. For exemple it can't work as it is with the anchors and tablesorter plugins.
Putting the added content at the end of the body can be an improvement.
Identifying the added content (for instance, by adding a start and an end HTML comment) can also be useful.
So, it could eventually be filtered by other plugins
I'll try to do that in a fork

Hi,
I also use the plugins anchors: I have a look but i can not find ids and double url fragments. For example http://iusvar.hostfree.pw/ef5/#print-friendly-plugin-3 than http://iusvar.hostfree.pw/ef5/#print-friendly-plugin-1 inside the hidden div .. .
As far as the plugin tablesorter I will do some checks ...

concerning the anchors plugins, I've extended it by adding a TOC in the sidebar (by following the exemple given in its doc.
As it, I can have an automatic TOC , but I had to find a way to exclude the content generated by the PP plugin, because if not, all my headers links were duplicated.
You can find a practical exemple in my blog
I've also found a solution for the tablesorter plugin: I had to submit some change to its author to allow a global table usage (instead of a per table settings only), and I've extended the PP settings by adding a tab for stripping some texts in the page content. As it I can remove some of the CSS classes added by the tablesorter in the content of the PP preview.
You can check my forks of these plugins to get an idea of what I've done

tablesorter
anchors
printfriendly

Thanks for the tips...
In my opinion, as far as possible, each plugin should not interfere with other plugins.
Now, having entered what is to be printed in a hidden input field, there are no interferences with the Anchors, Tablesorter and Toc plugins.
I just created a new version of the procedure.
Greeting


feat/ optimize the search

if searched yet, just return the response in the database.

but search times + 1;

Done.


upgraded library json-path-upgrade

upgrade library because of vulnerabilities.

I was thinking of switching to jackson for json processing but that requires code change. If we need code change anyways, then we should just reimplement with jackson and remove the dependency.


Use EDA User Service to persist analysis configs and preferences

Resolves #441.
Broadly speaking, this PR updates the AnalysisClient interface to conform to the EDA User Service API, and introduces an AnalysisClient implementation which exercises that service.
Notes:

The "footprint" of this PR is deceptively large - most of changes here are due to changes in the structure of the "analysis" JSON. Most of the differences in structure are straightforward (e.g., analysis.starredVariables is now analysis.descriptor.starredVariables), but two nontrivial changes are worth noting here:

StarredVariables is now an array of VariableDescriptors, as opposed to an array of (string) variable IDs.
Computations and visualizations are now stored in a nested JSON structure, as opposed to two "flat" arrays of computations and visualizations. Now, each analysis has an array of Computations, and each Computation has an array of Visualizations.

I have updated the mock analysis client in case we want to use it in the future. (In particular, since we don't yet have WDK login for the local dev environment, it might be worth adding some sort of USE_MOCK_ANALYSIS_STORE environment variable.)

Future work:

I uncovered a preexisting bug with copying analyses - after the copy is complete, the client redirects to the copy's URL, but the page's analysis state is not changed. I'm guessing we just need to make a small update to the analysis hook.
It appears that EDA services on our servers (ash, fir, etc.) are sending responses with a set-cookie header that resets the JSESSIONID used by the WDK service. Maybe we need to add some sort of (backend) filter to prevent this from happening?
Fix the client unit tests. (Some of them are [and were previously] broken due to what looks like a transpilation error.)

Hi @jtlong3rd  or @dmfalke
How would I test this from my developer instance?
I have tried
EDA_USER_SERVICE_URL=https://qa.clinepidb.org/eda-user-service

and
EDA_USER_SERVICE_URL=https://qa.clinepidb.org/eda-data

in .env.local
I'm getting 404s from any eda-user-service requests

Hi @jtlong3rd or @dmfalke
How would I test this from my developer instance?
I have tried
EDA_USER_SERVICE_URL=https://qa.clinepidb.org/eda-user-service

and
EDA_USER_SERVICE_URL=https://qa.clinepidb.org/eda-data

in .env.local
I'm getting 404s from any eda-user-service requests

Hi @bobular, if you're testing right now, I would use EDA_USER_SERVICE_URL=https://qa.clinepidb.org/eda-data/users.
Per a good suggestion of @dmfalke's above (re: handling the "public analyses" endpoint), I will be changing the expected config for EDA_USER_SERVICE_URL. (Working on that right now.) I'll leave a comment here when that's in place, so that you know when to change your config back.

Thanks - it's working now - just as a guest/unlogged in user.
For some reason the first analysis I made wasn't saved, but the second two were.  I'll figure out how to reproduce if it happens again.

@bobular - I've updated the PR with @dmfalke's suggested change to the userServiceUrl format. You should now be able to use EDA_USER_SERVICE_URL=https://qa.clinepidb.org/eda-data in your config!

Thanks, this works now.
Is there any intention to persist the guest user ID between react dev server restarts?
Is that what the WDK_CHECK_AUTH variable is about?  Could you provide guidance on how to use that please?

Thanks, this works now.
Is there any intention to persist the guest user ID between react dev server restarts?
Is that what the WDK_CHECK_AUTH variable is about? Could you provide guidance on how to use that please?

Alas, right now, the guest user is "lost" between react dev server restarts.
As you guessed, the WDK_CHECK_AUTH variable is a temporary workaround. Specifying this variable lets you pass as a registered user on the react dev server.
Here's how you can get your hands on a valid WDK_CHECK_AUTH value:

Go to ClinEpiDB (or any WDK site)
Log in
In your dev tools, find the cookie with key wdk_check_auth
Use the value of that cookie for your WDK_CHECK_AUTH env variable

Thanks - that works for me now, between server restarts.
I again had the problem where the very first analysis I made and named disappeared.  I can't reproduce it though :-(
I won't be able to check every line of code, but I guess it would be good to merge this sooner rather than later, because of all the potential merge conflicts.  So don't let me stop you!

This looks great! I'm happy to go forward with this, but I one other improvement to AnalysisClient could be to override the fetch method to inject the wdk_check_auth header, rather than repeating in each method.

This is simple enough to act on now! I'll do that before merging. I also wanted to memoize the fetching of the "user request metadata" (user id, wdk_check_auth) per your original suggestion.


Attempting to build results in a error

Attempting to build the current source as of 5/22 results in a error about too many arguments to the function httpcinit
$ make
build/source/core/default.shbin.c
build/source/core/default.shbin.o
build/source/main.o
source/main.c: In function 'main':
source/main.c:61:5: error: too many arguments to function 'httpcInit'
httpcInit(0);
^
In file included from c:/devkitPro/libctru/include/3ds.h:42:0,
from source/main.c:3:
c:/devkitPro/libctru/include/3ds/services/httpc.h:23:8: note: declared here
Result httpcInit(void);
^
make: *** [build/source/main.o] Error 1
rm build/source/core/default.shbin.c

git clone https://github.com/smealum/ctrulib (don't do this in your FBI directory)
make ( in /ctrulib/libctru)
make install

Is there any sort of build guide for this, as I have run into another error.
undefined reference to `C3D_SafeDisplayTransfer'

on the main page (and README.md): "Requires devkitARM and citro3d to build"
Install citro3d

Sorry about the newb questions, thought i had citro3d installed but forgot i had reinstalled devkitarm which wiped out all my installed libs

any solution for:
output/FBI.elf
build/source/core/screen.o: In function screen_load_texture': c:\devkitPro\msys\home\SERVER\3DS\FBI-master\FBI-master/source/core/screen.c:358: undefined reference to C3D_SafeDisplayTransfer'
collect2.exe: error: ld returned 1 exit status
make: *** [output/FBI.elf] Error 1
rm build/source/core/default.shbin.c
-reinstall DevKitArm + ctrulib + citro3d and no success on compiling.
any idea how to fix this?
thanks

Ummm... The last sentence doesn't tell you?

You need to BUILD the latest source of ctrulib and citro3d and such and "make install", not simply install the latest released versions.

i did all what you said and always no luck :-(

i will try it on linux maybe windows 10 x64 is not suitable for compiling FBI.

I build on Windows 10 64 bit.

Thanks. now it works fine
first install/update libs then download fbi src and compile.

thanks urherenow it works just fine.


💄Tina Cloud project config - Improve site URL UX

See tweet and attached video
https://x.com/cdvillard/status/1799083214792978506
The site URLs field UX is not great.

UX - When you type a URL and press enter or click Add, you need to click Save Configuration as well 👎🏻  - this is not clear
⚠ Loss of data - When you leave the page, it doesn't warn you there are unsaved changes

To fix, there are a few improvements to implement.

Save URLs when Add button is clicked
You should never be able to navigate away from an unsaved form - ensure there is a warning when you try navigate with unsaved changes
Save button - Make it disabled until there are unsaved changes

Validations

[X] Follow our Code of Conduct
[X] Read the docs.
[X] Check that there isn't already an issue that reports the same bug.

💯 Agree with the above

You should never be able to navigate away from an unsaved form - ensure there is a warning when you try navigate with unsaved changes

This as well but this will be an issue when we upgrade the version of react-router we are on - I think this should be delayed for now

Work has starting in https://github.com/tinacms/tinacloud/tree/save-tags-independent

Done - here's a done video explaining the new changes - https://www.youtube.com/watch?v=X0R-6PCKmy4


istio/tools perf benchmark cannot generate flame graph properly

Currently, --perf label is not working as stated, it cannot generate the flame graph as expected.

@carolynhu the underlying scripts do work, I just got a bunch of flamegraphs. However --perf does not work.


Restructure common utils

Add functions from common.utils to modules inside functional.
Data class is still used but will be removed shortly, so we leave it for now in common. utils.
Also, functions for conversion from epochs to num_steps were refactored.

Feel free to ignore my comments for the Data dataclass if it is getting removed, just thought I'd add my comments to the record

OK. I don't think we should completely get rid of it, since a dataclass also makes sense with dataframes, especially if we have outcomes and censor_outcomes in separate dfs. This will help us keep track of the patients and allow for some checks. However, most methods won't be needed in the new setup.

@mikkelfo I've adressed your comments, except the ones for the dataclass as we'll rewrite it and get rid of most methods.
Could you please clarify this comment;

This is duplicated for finetune, so perhaps it should be wrapped in a functionality for standardization?


Documents

Pull Request Template
Title
[Provide a succinct and descriptive title for the pull request, e.g., "Improve caching mechanism for API calls"]
Type of Change

[ ] New feature
[ ] Bug fix
[x] Documentation update
[ ] Refactoring
[ ] Hotfix
[ ] Security patch
[ ] UI/UX improvement

Description
[Provide a detailed explanation of the changes you have made. Include the reasons behind these changes and any relevant context. Link any related issues.]
Testing
[Detail the testing you have performed to ensure that these changes function as intended. Include information about any added tests.]
Impact
[Discuss the impact of your changes on the project. This might include effects on performance, new dependencies, or changes in behaviour.]
Additional Information
[Any additional information that reviewers should be aware of.]
Checklist

[ ] My code adheres to the coding and style guidelines of the project.
[ ] I have performed a self-review of my own code.
[ ] I have commented my code, particularly in hard-to-understand areas.
[ ] I have made corresponding changes to the documentation.
[ ] My changes generate no new warnings

Conflicts that must be resolved

Pull Request Template
Title
Merging Technical Specification
Type of Change

[ ] New feature
[ ] Bug fix
[x] Documentation update
[ ] Refactoring
[ ] Hotfix
[ ] Security patch
[ ] UI/UX improvement

Description
Document about all the technical aspect of this project.
Testing
Reviewed by the Q&A.
Impact
Explaining how the project work and how is it build to guide the team project.
Additional Information
Nothing to add.
Checklist

[x] My code adheres to the coding and style guidelines of the project.
[x] I have performed a self-review of my own code.
[x] I have commented my code, particularly in hard-to-understand areas.
[x] I have made corresponding changes to the documentation.
[x] My changes generate no new warnings


Updating stat_nova module and added some new misc functions

Updating stat_nova module and added some new misc functions

@basepi @fossam FYI... Bugs have been opened at https://git.corp.adobe.com/spartans/hubble/issues to track all discussed issues.

@anuragpaliwal80 Any reason you're opening issues in your fork instead of in the main hubble repo?

@mew1033 I love to open tickets in main hubble repo but I thought it might not be good to open security related issues public ally or opened on our internal site.
And accidentally opened all issues of this PR internally, few of them could be opened on githuub as well. Will keep that in mind.

@anuragpaliwal80 I just realized that the tickets you opened were in git.corp, not public github. Sorry about the confusion!


Improve Panelview Function

What:

Fix panelview plot in documentation
Enable dynamic plot colors for panelview when collapse_by_cohort = True

Tested on docs-preview
Before

After

Hi @s3alfisc, this MR is to fix the bug on panelview plot size, as well as minor improvement to enable dynamic colors of pre and post treatment when setting collapse_to_cohort = True
I have ran the lint test locally and shows passed, not sure why the pre-commit workflow failed, need your help to review this, Thanks!

pre-commit.ci autofix

I have ran the lint test locally and shows passed, not sure why the pre-commit workflow failed, is this expected? Need your help to review this, Thanks!

Also not sure why this sometimes happens ... currently running the ci bot, I hope it will fix it =)

Looks good now, thanks a ton @rafimikail!


[WIP] Implement policy evaluation for action executions

How does an execution move from delayed -> scheduled?

How does an execution move from delayed -> scheduled?

I plan to use a rule (timer) in the core pack (or a new sys pack) to republish the delayed executions back into the queue for the scheduler to re-evaulate.

I plan to use a rule (timer) in the core pack (or a new sys pack) to republish the delayed executions back into the queue for the scheduler to re-evaulate

How would an action, which the rule would have to fire, perform this task? Seems like the action would require access to DB or you will have to introduce new API to change state?
I somehow am not sold on this model of implementing system primitives via a rule based approach. As we had discussions separately the SLAs for events+rules is best effort so it would get very challenging for us to provide strict guarantees of timing etc.
If we do go down the route of system rule we have to figure out an approach to hide some executions from user view.

So the solution here has to be able to resume from platform failure (i.e. someone manually rebooted the server or st2 has a bug and the process hangs/dies).  Therefore, I opted for a solution that is interval based and can just resume where things are left off at the next interval even if there's a system failure.  If we don't like rule based, then I can extend the scheduler to spawn a thread that work off a timer to perform this operation.  I'm not incline to add a new worker/process for this.

How would an action, which the rule would have to fire, perform this task? Seems like the action would require access to DB or you will have to introduce new API to change state?

Yeah, the action would use the persistence layer from st2common.  I'm less incline to introduce an API change.

As we had discussions separately the SLAs for events+rules is best effort so it would get very challenging for us to provide strict guarantees of timing etc.

I'm thinking of an interval timer so if for some reason st2 miss an interval, it'll be process at the next interval.  SLA shouldn't be a huge concern here.

If we do go down the route of system rule we have to figure out an approach to hide some executions from user view.

This unknown approach is going to require some thoughts and consume a lot of time.  But I think we should invest into it at some point.  I believe we have enough primitives within the core st2 to build other functionalities on top of.

So the solution here has to be able to resume from platform failure (i.e. someone manually rebooted the server or st2 has a bug and the process hangs/dies). Therefore, I opted for a solution that is interval based and can just resume where things are left off at the next interval even if there's a system failure.

I agree with this part but rule is not the only option to achieve a resilient solution.

Yeah, the action would use the persistence layer from st2common. I'm less incline to introduce an API change.

This where the action approach falls apart for me. We need to guarantee access to DB from actionrunner system or remote system.

SLA shouldn't be a huge concern here.

Hmm.. I have my doubts with that one. intuition says we will have to provide some guarantees and/or ordering etc. So maybe we should dig into this further before we set it aside.

Hmm.. I have my doubts with that one. intuition says we will have to provide some guarantees and/or ordering etc. So maybe we should dig into this further before we set it aside.

My current plan is to sort by ascending start_timestamp of delayed executions and then republish them in that order. So yeah you're right, there's still a possibility where an execution is just bad luck and gets delayed over and over.


Updated html

I added my name and matric number.

Seen.
I will also be needing your passport photograph.

Done boss


Use base.yaml irrelevant file list

It will help to avoid zuul job freeze issue[1]. where[1] child jobs gets triggering without running content provider.
Podified base job is parented from cifmw-podified-multinode-edpm-base-crc and is defined in base.yaml. Let's use the irrelevant file list from cifmw-podified-multinode-edpm-base-crc instead of overidding it.
Links:
[1]. https://github.com/openstack-k8s-operators/ironic-operator/pull/421#issuecomment-2069087141
As a pull request owner and reviewers, I checked that:

[x] Appropriate testing is done and actually running

/approve


change dialog style

@fabianfrz @fichtner I think I have some more committed the last days, but your right, it should have danger style in stead of info. I will try to pay closer attention on those and pull this one in.

@fabianfrz @fichtner I think I have some more committed the last days, but your right, it should have danger style in stead of info. I will try to pay closer attention on those and pull this one in.


update clustering

remove unused seaborn
prevent argument warning for color when doing scatterplots

Coverage remained the same at 87.697% when pulling d0ddfb01d699d348f297264bd58b2bc4ecbbba76 on bkmgit:bkmgit-update-clustering into 92825811ee25ec1bfa4d2f65940f51882b8d749a on lmcinnes:master.


Break (multiple) attributes into seperate lines

Hi. First of all thank you for the great tool!
I have a feature suggestion. Would it be possible to add a rule that breaks attributes into seperate lines?
Possible configuration options:

Except (tags for which the rule does not apply)
max (number of attributes allowed in one line before before error.)

For example:
<div id="my_id" class="my-class">

and
<div
      id="this_is_my_id"
      class="this-is-my-class"
      data-attr="this-is-my-custom-attr"
>

Hey @ecRobertEngel ! Sorry for the late response, thanks for the suggestion, and I'm glad to know it's a helpful tool! :D
This is definetely a great suggestion, I'll think on the best way to implement it and will let you know once it's available, ok?
Thanks!


Add Windows 95 styled scrollbars

Something like these would do
https://codepen.io/louh/pen/oZJQvm

Hey, that's a pretty nice recreation you've found there!
I have one a nice one to look at over here too: https://github.com/1j01/os-gui
I use ::-webkit-scrollbar-track-piece:active instead of ::-webkit-scrollbar-track:active so it doesn't darken the background of the scrollbar track when dragging by the scrollbar handle.
Also, the cursor should be reset to default for the textarea case, which I'm now realizing I don't handle, even tho I have Notepad on 98.js.org. (Maybe it didn't always work that way, and chrome's updated?)

Yeah @1j01 version looks better 😊 Let's hope our scrollbars won't be to big tho (we are using 2x thicker borders than in original Windows). And we have to make them themable somehow to match other color schemes 🤔

closed by #190


AAApoc token submission automerge failure

I'm submitting a ...
[x ] bug report
[ ] feature request
x[ ] question about the decisions made in the repository
[x ] question about how to use this project

Summary

Other information (e.g. detailed explanation, stack traces, related issues, suggestions how to fix, links for us to have context, eg. StackOverflow, personal fork, etc.)

https://github.com/solana-labs/token-list/pull/21530  - link
Error says: found removed line: - "name": "Solana Token List",
says manual submission is necessary

i updated the pull to this link
https://github.com/solana-labs/token-list/pull/21956
I also left a comment with the relevant information on the PR itself.
requesting manual

https://github.com/solana-labs/token-list/pull/21956

@keone ?

https://github.com/solana-labs/token-list/pull/21956/files
130,839 additions, 130,840 deletions not shown because the diff is too large.
something is very wrong with your diff

i don't how i did that?
i literally just appended my entry to the end and uploaded it. how could that have possibly happened?
i've tried again, here
https://github.com/solana-labs/token-list/pull/22115


Fixed position of image and explanation text

Hello,
The changed text and image was explaining how the example of  "Root Signature Version 1.0" works and looks like, but was placed under "Root Signature Version 1.1". I have only move it to the top. No changes to the text itself.

@Ohjurot : Thanks for your contribution! The author(s) have been notified to review your proposed change.


port powershell_module to core

This was identified in https://blog.chef.io/2017/11/01/coming-soon-chef-client-14-chef-development-kit-3/

Closing this since I think we actually need to create a resource for powershell gallery instead. This old resource just doesn't make sense


revert: amount loading logic

Reverts a change from #503 so that there is not an amount loading indicator.
In combination with https://github.com/MutinyWallet/mutiny-node/pull/764 node version we should be able to never see a load time for instant prices

not sure why cloudflare says still deploying, here's the url: https://dee5764b.mutiny-web.pages.dev/


Support order nonce 0

Currently, TomoX-SDK does not support order with nonce 0, but tomox supports it. So we should fix on TomoX-SDK side.

fixed in commit 6f910f7199c1fd356e1a7229570b8e35f799732d


Add Korean translation of ssss.md.

Hello @junha1 !!
I want to do this task, Can you assign me? 🙏🏻

Hello @junha1 !! I want to do this task, Can you assign me? 🙏🏻
Could you add a link to the ssss.md file in the description?


does the IRC channel work?

I was trying to join the conversation on camping. But none of the links seem to work:

Mailing list
IRC

Link: https://github.com/camping/camping/blob/main/book/01_introduction.md

looks like the README too refers to the same links.
[https://github.com/camping/camping/issues/116]

I apologize but the IRC channel and mailing list are both defunct. We have a new website and community facilities in the works.

[ ] Launch new website
[ ] make new community space


Tween fix

Resolves issue #22, then optimize away repeated operations in the inner loop.

Thank you for taking the time to PR this! I had to make a couple of fixes to maintain support for Python 2.7 (groan) but otherwise it works a treat.

Thanks for the tweaks; I did consider python2.7 (hence future division) but didn't actually run the code under that version. The round() to float is annoying, but I can't see a better alternative without separate code paths for py2/3.


Change materializer type for chunkUploadSink in S3 DSL's

In https://github.com/apache/incubator-pekko-connectors/pull/279 I forgot to update the public S3 DSL's

@pjfanning So this is the PR that actually changes public signatures and it did trigger a MiMa incompatiblity check but it can be a false positive, i.e. see https://github.com/lightbend/mima#incompatiblesignatureproblem which I believe is the case.
I can double check this by writing a program that is compiled against Sink[(UploadPartResponse, immutable.Iterable[C]), NotUsed] and then at runtime loading a pekko-connectors-s3 jar that is compiled with Sink[(UploadPartResponse, immutable.Iterable[C]), _] to see if it fails at runtime

We can add the 20 binary compatibility exceptions. I understand that the Mima Issues can often be items that don't affect users in real world scenarios. It is worth writing an external test to find out if we are stuck having to consider this as a v1.1.0 change.

@pjfanning So I can indeed confirm that the warning from MiMa in this case is a false positive and this PR doesn't actually break any binary compatiblity.
The easiest way to confirm this is to hot patch the s3 tests so that at runtime rather than using the compiled classes from s3 project it uses a locally deployed S3 that has the change in this PR, to do this

Checkout this PR's branch and run +s3/publishLocal

Checkout main

Modify the s3 project in build.sbt so it looks like this
*
lazy val s3 = pekkoConnectorProject("s3", "aws.s3", Dependencies.S3,
MetaInfLicenseNoticeCopy.s3Settings)
.settings(
  Test / fullClasspath := {
    val current = (Test / fullClasspath).value
    current.map {
      case f if f.data.getAbsolutePath.contains("s3/target/scala-2.13/classes") =>
        Attributed[File](
          file(
            "/Users/mdedetrich/.ivy2/local/org.apache.pekko/pekko-connectors-s3_2.13/1.0.1+9-575983c5-SNAPSHOT/jars/pekko-connectors-s3_2.13.jar"))(
          AttributeMap.empty)
      case rest => rest
    }
  })

Make sure to change the paths where neccessary, i.e. the local path to where you just published S3.

Run the tests with s3/test

What this change does it only modifies the test classpath which means that when you do s3/test/compile it will generate classes without the change in this branch (since you should be checked out in main) but when you run the tests with s3/test it will use the jar with the change in this branch which you just published locall (note that compiled test code, i.e. the tests written in scala-test sits in test-classes so its unchanged by this hotpatch)
You can play around with show s3/Test/fullClasspath to confirm this.
The PR has been updated to add the various MiMa filters.


No GPU being used. Careful, inference might be extremely slow!

I try to run this demo, but it shows that the GPU cannot be found

me too

try to run a demo, but too slow caused faile to get the audio response, several minutes can't be done. how long do you guys can get the audio generated normally?

Try to create a new bat file and write：

I solved the problem by this
#https://github.com/suno-ai/bark/issues/16#issuecomment-1517197259 # # #

closing for now, try to get torch working with cuda independent of bark. basically bark will pick up cpu if torch.cuda.is_available() gives you True

me too


WIP: TEVA-2123  Process Steps Component Refactor

Jira ticket URL
https://dfedigital.atlassian.net/browse/TEVA-2123
Changes in this PR:

Created new steps component to replace process steps component
The component is now not tied to vacancy or job application

Screenshots of UI changes:

As it stands I still need to do some work on the styling. The screenshot below shows the component as it currently looks. Red = completed step, blue = current step and black = neither.

Desktop

Mobile

Next steps:

Finish styling

Later I hope to replace the process steps component in the job listing journey with this component

Delete the process steps component

Questions

Not sure if the partial is in the right place. Can someone confirm where it should be?

Review app deployed to https://teaching-vacancies-review-pr-3199.london.cloudapps.digital

can we/you/you & i add a preview of this?


Maybe a configuration option for alert colors

I think I honestly only care about war alerts having color.
I made conquest alerts have color simply so that I personally would have an easier time finding them, but this is more fit for a user-specific thing (I should set a /trigger that replaces the text that I see, or something). I doubt I'll be adding colors back to that.

No more use in implementing this


Reference to CRD bumper for CRD versioning

I wanted to avoid duplicating the CRD versioning doc that is in crd-bumper, but I think we do need to drop a pointer into each repo.
I'd like to put this same thing into lustre-fs-operator and nnf-sos.


SOLR-14920: contrib/jaegertracer-configurator: apply & enforce 'spotless' code formatting

https://issues.apache.org/jira/browse/SOLR-14920
Building upon #126 which added spotless support without use of it.

[X] pull request branch is up to date with latest origin/main
[X] ./gradlew -p solr/contrib/jaegertracer-configurator test passes

You could increase the scope of the PR and just keep going with more modules, thus ultimately fewer commits where we make changes en-masse.  Up to you.
Once the merges happen, the commits where we do this en-masse change should be added to /.git-blame-ignore-revs
The current contents of that file should be wiped clean because they are all Lucene commits.  We inherited it from the split.

Once the merges happen, the commits where we do this en-masse change should be added to /.git-blame-ignore-revs
The current contents of that file should be wiped clean because they are all Lucene commits. We inherited it from the split.

Thanks, I didn't know about that file! Created #163 for the wiping clean separately first.


✏ Getting Started docs refer to nonexistant file(s?)

Describe the bug
The Getting Started page starts out describing a config.toml file with various settings. It's supposedly at config/_default/config.toml. However, this path doesn't exist in a fresh project created with blowfish-tools. The path now appears to be config/_default/hugo.toml.

There is also a ./hugo.toml file, though, which is the one that actually seems to contain the settings for baseURL, languageCode, and title. Is this the file that's actually being referred to? Or is the user supposed to create a new file at the given path in _default?
To Reproduce
Steps to reproduce the behavior:

Create a new blog with blowfish-tools new my_blog
Look in my_blog/config/_default
Notice missing config.toml file.

Expected behavior
Docs should describe the current version.
Desktop (please complete the following information):

OS: macOS Sonoma 14.5

Hugo & Blowfish versions
Blowfish 2.69.0
Hugo 0.126.3+extended darwin/arm64

Thanks for the quick work on this!
I was wondering, though: there's still the confusion between config/_default/hugo.toml and the hugo.toml in the root directory. The file pointed to by the path on index.it.md line 32 doesn't have a languageCode, and the baseURL is commented out.
# -- Site Configuration --
# Refer to the theme docs for more details about each of these parameters.
# https://blowfish.page/docs/getting-started/

theme = "blowfish" # UNCOMMENT THIS LINE
# baseURL = "https://your_domain.com/"
defaultContentLanguage = "en"

Is the path on line 32 actually correct? If so, then the TOML code starting on line 31 is misleading.

Wanted to make sure you saw this @nunocoracao

Sorry @nk9, not sure I understood the issue here

I think you are asking me to clarify what the problem is. No problem! After your changes, the documentation now says:

So ok, I go to the file listed, config/_default/hugo.toml and… it doesn't look anything like the code in the code block. It's missing the Site Configuration block at the top, there's an extra theme, and there's no commented out languageCode. Is the user supposed to ADD the languageCode setting? (If so, why isn't it there, commented out, like the baseUrl is?)
But also, if you actually want people to make changes in config/_default/hugo.toml, then why does the configuration say "Starting in the hugo.toml file"? Without a path, that could easily be taken to mean {root_dir}/hugo.toml, which is a file, and which looks exactly like codeblock. But the codeblock says the file it's showing is config/_default/hugo.toml, not hugo.toml. So why are they different?
Basically, I think what needs to change is just this:
--- a/exampleSite/content/docs/getting-started/index.md
+++ b/exampleSite/content/docs/getting-started/index.md
@@ -29,7 +29,7 @@ The config files that ship with Blowfish contain all of the possible settings th
 Before creating any content, there are a few things you should set for a new installation. Starting in the `hugo.toml` file, set the `baseURL` and `languageCode` parameters. The `languageCode` should be set to the main language that you will be using to author your content.

 ```toml
-# config/_default/hugo.toml
+# hugo.toml

 baseURL = "https://your_domain.com/"
 languageCode = "en"

But if people really should be making these first changes in config/_default/hugo.toml, then you should add placeholders in there, change the code block to look the same, and change the wording to refer to the full path.
I hope this is clearer?

No rush, but I forgot to tag you before @nunocoracao.


Update Fabric Core URLs which were blocked by CORS policy

This PR updates the stylesheet URLs for Fabric Core, in alignment with the current Fabric Core documentation.
Sometime on 2024-09-18 the CORS policy changed for the files hosted on https://static2.sharepointonline.com.

This caused a broad outage for our Outlook Addin and users were prevented from sending specific emails. It would appear that the CORS policy has been reverted for now.

@microsoft-github-policy-service agree

Related: https://github.com/microsoft/fluentui/issues/32861


Update to version v1.20.5

Pin the versions to be used for gyp insided maestro and maestro-shell instead of using master.
Pin the version of yp instead of using master.

We should probably some fix to maestro, too?


Infinite Curvature in exactly straight paths

When designing a path that is exactly straight (same x-values or same y-values for starting and ending point), the curvature that is calculated for each state is Infinity, which messes up the calculation for wheel speeds (set to NaN). This makes the robot have uncontrolled wheel speeds.
The attached text file is the path that we were having issues with which is an exactly straight horizontal line.
The csv file shows values from each generated state -  note how curvature is Infinity for each state.
MoveForwards.csv
MoveForwards.txt

Fixed this in 1cdda0f and released it in v2022.1.0
This is not yet fixed in the GUI generator however.


Adding nix flake

This makes BugStalker nix friendly and users can immediately use the project :)

Will do

Should be done now

Oh wait

Now it should be fine

Merged, thanks!


What is the filtered signal and spectrum?

Hello i want to ask what are the filtered signal and spectrum?
The filtered signal is obatained after get throught the butterworth and bandpass filter?
I can understand that the raw signal is the average of green pixels in the ROI
i have read the Remote Detection of Photoplethysmographic Systolic and Diastolic Peaks Using a Digital Camera and they used 3 coler channel but you only use the green channel right? so you do not need the ICA part
Thank you for your time.
P/S: Sorry if my english is bad

So yes, the filtered signal is interpolated and bandpass-filtered, as done in https://github.com/erdewit/heartwave/blob/fb96a81c7c911152757ff17a30e8dfe646b1089b/heartwave/person.py#L107
The spectrum is the Fourier transform:
https://github.com/erdewit/heartwave/blob/fb96a81c7c911152757ff17a30e8dfe646b1089b/heartwave/person.py#L128
The green channel is used to improve the signal to noise ratio. If  you modify the code to use the red channel then you will find that there is virtually no signal. The blue channel does have a signal but with a lot of noise.

May i ask how to modify the code so i can get signal from 3 color channel (R,G,B).
I tried to modify it but after "pip install heartwave" it still the same
Thank you for your time.
Respectfully.

In the file sceneanalyzer.py, the line
        greenIm = frame.image[:, :, 1]

can be replaced with
        import cv2
        greenIm = cv2.cvtColor(frame.image, cv2.COLOR_BGR2GRAY)

greenIm is then not the green but the gray image.

When i use the program it usually drops to 45 or jump to 120 really quick (with or without motion) may i ask how to reduce those kind of behaviors?


Cannot marshal array error from ActiveDirectoryAdministrator resource (Azure, C#)

Hi,
I defined an Azure ActiveDirectoryAdministrator like so
var adAdministrator = new ActiveDirectoryAdministrator("dbaaad", new ActiveDirectoryAdministratorArgs
{
Login = databaseServer.AdministratorLogin,
ServerName = databaseServer.Name,
ResourceGroupName = resourceGroup.Name,
ObjectId = azureActiveDirectoryObjectId,
TenantId = azureActiveDirectoryTenantId
});
When I pulumi up this definition, pulumi spins on creating until it drops this response
Error waiting on create/update future for SQL Administrator (Resource Group "redacted", Server "redacted"): Future#WaitForCompletion: the number of retries has been exceeded: StatusCode=409 -- Original Error: Code="InProgress" Message="The async operation failed." InnerError={"unmarshalError":"json: cannot unmarshal array into Go struct field serviceError2.details of type map[string]interface {}"} AdditionalInfo=[{"operation":"CreateActiveDirectoryAdministrator","operationId":"redacted","percentComplete":0,"startTime":"/Date(1599864635974)/"}]
Expected Behavior
Defining an (Azure) ActiveDirectoryAdministrator (C#) should result in success, or an error message indicates what might be the issue or resolution
Current Behavior
Error waiting on create/update future for SQL Administrator (Resource Group "redacted", Server "redacted"): Future#WaitForCompletion: the number of retries has been exceeded: StatusCode=409 -- Original Error: Code="InProgress" Message="The async operation failed." InnerError={"unmarshalError":"json: cannot unmarshal array into Go struct field serviceError2.details of type map[string]interface {}"} AdditionalInfo=[{"operation":"CreateActiveDirectoryAdministrator","operationId":"redacted","percentComplete":0,"startTime":"/Date(1599864635974)/"}]
Steps to Reproduce
Create a new pulumi project in C# and include the Azure provider. Add resource as defined above and run pulumi update
Context (Environment)
Unable to define a necessary resource for my project

It's not 100% clear what's happening from what you've provided, but the 409 suggests a potential conflict? I'm not familiar with this resource, but can you really set the login name to the same as the server admin login name?


How to define authenticated helper in routes.rb to call or access application controller current_user method

I want to define authenticated root for the application. I am using  omniauth-identity gem for the authentication and define current_user helper in application controller.
def current_user
  @current_user ||= User.find_by_id(session[:user_id]) if session[:user_id]
end
helper_method :current_user

def current_user=(user)
 session[:user_id] = user.id
end

And in routes.rb
I want root based on condition
 root to: 'map#index', constraints: Constraints
 root to: 'pages#about'

And within Constraints.rb module defines matches? method
module Constraints
 def self.matches?(request)
   user = current_user(request)
   return true if user.present?
   false
 end
 def current_user(request)
   @current_user ||= User.find_by_id(request.session[:user_id]) if request.session[:user_id]
 end
end

And it works fine but the problem duplicate method current_user or we need to check session twice.
In routes we need to pass request object and available locally. so how we can call or pass controller current_user method with request object. Any suggestion so we can define in one place and access it.
It's something similar to devise gem
authenticated and unauthenticated routes helper.

I don't think there is a way to do what you are hoping for, unless you store a hash of the current user in the Rack env, setting it in Constraints, and then checking for it in the Application Controller.  If you do store it in the Rack env, you may want to be careful what attributes get stores.  Perhaps a representation of the user that removes some sensitive data?


Regex for OSM opening hours

As discussed in #79, we have not been able to find a regular expression that encapsulates the OSM Opening Hours format.
Opening this issue in case someone has a solution, and as a general reminder to keep looking for one.

This comment (upvoted by 3 people) mentions that this format is too complex to be validated with a regex.

I don't think a regex can handle this complex format. You will need a real parser. The OSM wiki lists several implementations:

For this reason, I would recommend to close this issue.
A new issue could be opened in https://github.com/MobilityData/gbfs-validator, given that code seems to be required to validate OSM opening hours.


Updates to SSO timestamp format

Hi @benkehoe,
We recently found a bug in botocore that's been producing an unintended timestamp for SSO credentials. We've decided to fix the format (boto/botocore#2250) to prevent additional issues with the other AWS SDKs. We know you've been doing a lot of work with SSO and wanted to make sure this change was on your radar. Please let us know if you have any feedback or thoughts on the change.
Thanks!

Awesome, and thanks for letting me know! I've updated my code to pull SSOCredentialFetcher from botocore directly, leaving only SSOTokenFetcher vendored from the v2 branch. This change should eventually make it into the v2 branch and thus the AWS CLI v2 as well, right?

That's correct. Once the PR is merged, you should see the change in both the botocore v2 and CLI v2 branches during their next release.

Hey again @benkehoe, we made some minor changes to the datetime fix. It's moved to a class var instead of the helper function to alleviate some of your concerns. It should be available in the next releases of CLI v2, feel free to close this if you don't have further tracking actions.

I don't have any further concerns, as I'll leave the remediation code in place for people with old versions, and when I update to use SSOCredentialFetcher directly from botocore, I'll get your changes.
Thanks so much!


Changes for voters abroad

[x] Add country and district select
[x] When country changed, update the list of available districts
[ ] Update submit validations
[ ] Display the available polling stations if multiple, directly go the polling station if single
[ ] Update all the text in the form

I was thinking, when there are multiple polling stations that apply to the same county and district we add a new dropdown that allows the user to select the polling station. It might be the easiest option UI wise, thoughts?

Posted here by mistake. Moved to https://github.com/developolar/vote-here-2016/issues


Add labels and a new field to your app

this tutorial seems outdated because now things are different as compared to this tutorial

Can you please supply information as to which tutorial this is? Thanks.

I assumed https://developers.sap.com/austria/tutorials/hcp-webide-add-labels-field.html

Thats only one tutorial :-) @Danish-Adeel can you please elaborate?

https://github.com/SAPDocuments/Tutorials/issues/2801
The issue in it is that I cant find unitsinstock in Detail.view.xml

This is indeed a little bit outdated. I checked the source group (where the app was created) and the Kapsel-related template doesn't exist any more. @KevinMuessig is looking at the mobile tutorials as a whole, with deprecation in mind, so I will assign this to him for comment. In the meantime, thanks for the heads-up.

@jarjarbentley  Any updates?

Sorry guys. Not sure how I missed this. I’ll pull it up this afternoon
Cheers,
Josh Bentley
SAP Developer Relations
Cloud & Mobile Evangelist
On Feb 25, 2019, at 6:11 AM, Daniel Wroblewski <notifications<EMAIL_ADDRESS>wrote:
@jarjarbentleyhttps://github.com/jarjarbentley Any updates?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/SAPDocuments/Tutorials/issues/2801#issuecomment-466972115, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AnH0iEmCQwOknlmw5Elzoy9PR-PQKw-Qks5vQ8TXgaJpZM4YvNll.

@jarjarbentley Can this issue be closed?

Yes, we need to deprecate and close this issue.


feat: custom port for server

Allow using a different port for the backend.. Default to 8080.

LGTM, Thanks!


Tab expansion not working

OS: Mac OS 10.11.6
Bash: 3.2.57
<EMAIL_ADDRESS>Pressing tab on a commit only duplicates the 'commit row' below the line that I pressed tab upon.
Expected: Upon pressing tab, the expanded commit information should show below the current selected commit.

Hey, thanks for reporting the issue, I'm working on it. As a temporary workaround, you can use e key introduced in version 1.1.6 to reduce/expand the diff :)

It should work fine now.


feat: add support for additional derive macros

Basically, when I use ormlite with the config to create a new entity for insert, I can't deserialize it.
One case of this is when I try to deserialize from an Extractor in Axum.

Problem

With this patch

Looks great, thank you for the addition!

It might be nicer to call it something like insert_derives, or there might be a way to just carry the derives from the base struct onto the main model, but happy to merge as is and iterate if it becomes an issue.


Do only disable automagic when FSharp.Core is actually used

fixes #3721

@matthid then how about b8507bb?

I'm not a functional purist :) As long as it works. But yes thanks for taking care of this nit!


⚠ ca1ray.serverssh.net has degraded performance

In 454aa7f, ca1ray.serverssh.net (http://ca1ray.serverssh.net/) experienced degraded performance:

HTTP code: 200
Response time: 12685 ms

Resolved: ca1ray.serverssh.net performance has improved in a06ed1e.


Add support for DragonFly BSD

Codecov Report

Merging #234 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #234   +/-   ##
=======================================
  Coverage   91.48%   91.48%
=======================================
  Files         258      258
  Lines       18009    18009
=======================================
  Hits        16475    16475
  Misses       1534     1534

Flag
Coverage Δ

#data_tests
79.48% <ø> (ø)
:arrow_up:

#examples
59.21% <ø> (ø)
:arrow_up:

#unit_tests
88.63% <ø> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8de181c...d8e7371. Read the comment docs.


Refact: don't import store explicitly at the utils/backend.js

issue: #909
ref: https://github.com/aeternity/superhero-ui/pull/993
upd:
closes #707
closes aeternity/superhero-wallet#548

@Liubov-crypto please test that:

open the app
switch off the internet to produce the request error
check if the Maintenance page is showed

@Liubov-crypto please test that:

open the app
switch off the internet to produce the request error
check if the Maintenance page is showed

@mradkov basically all is fine and it's enough to integrate the SSR because the main goal of that task is to not import store explicitly at the utils/backend.js.
I already tested that but we can wait for @Liubov-crypto to make sure.
My previous PR https://github.com/aeternity/superhero-ui/pull/993 is marked as draft but later we can continue with more deeply approach that present at that PR or connect SDK and swagger to replace the utils/backend.js with SDK methods that was grabbed from the swagger file. Me or @davidyuk can explain that, if you are not aware about the last.

@mradkov basically all is fine and it's enough to integrate the SSR because the main goal of that task is to not import store explicitly at the utils/backend.js.
I already tested that but we can wait for @Liubov-crypto to make sure.
My previous PR https://github.com/aeternity/superhero-ui/pull/993 is marked as draft but later we can continue with more deeply approach that present at that PR or connect SDK and swagger to replace the utils/backend.js with SDK methods that was grabbed from the swagger file. Me or @davidyuk can explain that, if you are not aware about the last.

thanks to @davidyuk
it also can use window.addEventListener("unhandledrejection", function (event) { instead to catch the manually defined throw new error from the fetch.

thanks to @davidyuk
it also can use window.addEventListener("unhandledrejection", function (event) { instead to catch the manually defined throw new error from the fetch.

thanks to @davidyuk
it can also use window.addEventListener("unhandledrejection", function (event) { instead to catch the manually defined throw new error from the fetch.

refs:
https://github.com/aeternity/superhero-ui/issues/707
https://github.com/aeternity/superhero-wallet/issues/548

thanks to @davidyuk
it can also use window.addEventListener("unhandledrejection", function (event) { instead to catch the manually defined throw new error from the fetch.

refs:
https://github.com/aeternity/superhero-ui/issues/707
https://github.com/aeternity/superhero-wallet/issues/548

there is some blockers with unhandledrejection so I will leave it with eventBus

there is some blockers with unhandledrejection so I will leave it with eventBus

@Liubov-crypto please test that:

open the app
switch off the internet to produce the request error
check if the Maintenance page is showed

Followed steps described above. Got this in Chrome (the picture of the blue diamond was not loaded):

Also, when the Internet appears there is no automatic redirection to the main page, the user remains on the maintenance page:

FF - maintenance text and the picture of the blue diamond was not loaded:

Brave - maintenance text and the picture of the blue diamond was not loaded:

@Liubov-crypto please test that:

open the app
switch off the internet to produce the request error
check if the Maintenance page is showed

Followed steps described above. Got this in Chrome (the picture of the blue diamond was not loaded):

Also, when the Internet appears there is no automatic redirection to the main page, the user remains on the maintenance page:

FF - maintenance text and the picture of the blue diamond was not loaded:

Brave - maintenance text and the picture of the blue diamond was not loaded:

@Liubov-crypto thanks, need to investigate what's going on in Brave

@Liubov-crypto thanks, need to investigate what's going on in Brave

currently I got that page on error, but from time to time it not appears. need to investigate in any case...

currently I got that page on error, but from time to time it not appears. need to investigate in any case...

@Liubov-crypto try to reproduce it that way in Brave:

open profile page
switch off the internet
open main page (tips list page)

I got the maintenance page in that way. Not sure why it's not fires all the time. Looks like Brave has other rules for fire an error on internet disconnected but the same for the other errors. Maybe that's related to the manually switch off the internet.

@Liubov-crypto try to reproduce it that way in Brave:

open profile page
switch off the internet
open main page (tips list page)

I got the maintenance page in that way. Not sure why it's not fires all the time. Looks like Brave has other rules for fire an error on internet disconnected but the same for the other errors. Maybe that's related to the manually switch off the internet.

@Liubov-crypto try to reproduce it that way in Brave:

open profile page
switch off the internet
open main page (tips list page)

I got the maintenance page in that way. Not sure why it's not fires all the time. Looks like Brave has other rules for fire an error on internet disconnected but the same for the other errors. Maybe that's related to the manually switch off the internet.

Works in this way. But after connecting to the Internet, the user remains on the maintenance page. No automatic redirection to the main page.

@Liubov-crypto try to reproduce it that way in Brave:

open profile page
switch off the internet
open main page (tips list page)

I got the maintenance page in that way. Not sure why it's not fires all the time. Looks like Brave has other rules for fire an error on internet disconnected but the same for the other errors. Maybe that's related to the manually switch off the internet.

Works in this way. But after connecting to the Internet, the user remains on the maintenance page. No automatic redirection to the main page.

@Liubov-crypto try to reproduce it that way in Brave:

open profile page
switch off the internet
open main page (tips list page)

I got the maintenance page in that way. Not sure why it's not fires all the time. Looks like Brave has other rules for fire an error on internet disconnected but the same for the other errors. Maybe that's related to the manually switch off the internet.

Works in this way. But after connecting to the Internet, the user remains on the maintenance page. No automatic redirection to the main page.

Yes, the logic was changed. @davidyuk suggest to do that. But I can try to forward it to the main on connect.

@Liubov-crypto try to reproduce it that way in Brave:

open profile page
switch off the internet
open main page (tips list page)

I got the maintenance page in that way. Not sure why it's not fires all the time. Looks like Brave has other rules for fire an error on internet disconnected but the same for the other errors. Maybe that's related to the manually switch off the internet.

Works in this way. But after connecting to the Internet, the user remains on the maintenance page. No automatic redirection to the main page.

Yes, the logic was changed. @davidyuk suggest to do that. But I can try to forward it to the main on connect.

@Liubov-crypto I guess now it can be forwarded to main page after the maintenance

@Liubov-crypto I guess now it can be forwarded to main page after the maintenance

@Liubov-crypto I guess now it can be forwarded to main page after the maintenance

now redirects to the main page, but periodically redirects to https://feature-refact-backend.aggregator.z52da5wt.xyz/maintenance
also, I can't stay on my profile page, redirection to the main page after a few seconds

@Liubov-crypto I guess now it can be forwarded to main page after the maintenance

now redirects to the main page, but periodically redirects to https://feature-refact-backend.aggregator.z52da5wt.xyz/maintenance
also, I can't stay on my profile page, redirection to the main page after a few seconds

@Liubov-crypto thanks. It's a bug

@Liubov-crypto thanks. It's a bug

@Liubov-crypto after my last commit it should redirects to the feed page (the main page). Please, check.

@Liubov-crypto after my last commit it should redirects to the feed page (the main page). Please, check.

@Liubov-crypto after my last commit it should redirects to the feed page (the main page). Please, check.

Followed these steps:

open profile page
switch off the internet
open main page (tips list page)
turn on the internet
after a while the app should show the feed list

Got the issue that the main page redirected to the maintenance page after a while.
I recorded a video, the same behaviour in FF and Brave:
https://user-images.githubusercontent.com/69896204/106155007-e0ce6000-6188-11eb-8540-6243c3f0e404.mov

@Liubov-crypto after my last commit it should redirects to the feed page (the main page). Please, check.

Followed these steps:

open profile page
switch off the internet
open main page (tips list page)
turn on the internet
after a while the app should show the feed list

Got the issue that the main page redirected to the maintenance page after a while.
I recorded a video, the same behaviour in FF and Brave:
https://user-images.githubusercontent.com/69896204/106155007-e0ce6000-6188-11eb-8540-6243c3f0e404.mov

@Liubov-crypto some loop redirects... after a while it's fine. I will investigate.

@Liubov-crypto some loop redirects... after a while it's fine. I will investigate.

@Liubov-crypto pushed the commit, I checked, it's fine with Brave now. Cam you confirm?

@Liubov-crypto pushed the commit, I checked, it's fine with Brave now. Cam you confirm?

@Liubov-crypto pushed the commit, I checked, it's fine with Brave now. Can you confirm?

Followed these steps:
open profile page
switch off the internet
open main page (tips list page)
turn on the internet
after a while the app should show the feed list
Now everything looks good, no redirection to maintenance.
btw, there is some delay in loading the feed in FF.

@Liubov-crypto pushed the commit, I checked, it's fine with Brave now. Can you confirm?

Followed these steps:
open profile page
switch off the internet
open main page (tips list page)
turn on the internet
after a while the app should show the feed list
Now everything looks good, no redirection to maintenance.
btw, there is some delay in loading the feed in FF.

Btw, there is no maintenance banner in Safari, just this:

After turning on the Internet, you need to refresh the page so that the feed appears

Btw, there is no maintenance banner in Safari, just this:

After turning on the Internet, you need to refresh the page so that the feed appears


Fix/lb keys

closes #1164

Given the fact that @Despire 's availability is limited these days, I think anyone from the team can bump the docs so that this gets merged.

hi @bernardhalas  the commands were added to the docs. Are we going to merge this PR?


migration via rest doesnt show up in user federation

Hello people,
I am trying to integrate this plugin in my current keycloak installation. But I cant get it to work and the migration via rest doesnt show up in the tab user federation.
This is my current docker dompose-compose.yml:
root@ldap-server:~/keycloak-docker-compose# cat docker-compose.yml
version: '3.9'

volumes:
  mariadb_data:
    driver: local

networks:
  local:
    ipam:
      config:
        - subnet: ${SUBNET:-<IP_ADDRESS>/29}

services:
  mariadb:
    image: mariadb:${MARIADB_VERSION:-latest}
    environment:
      MARIADB_ROOT_PASSWORD: ${MARIADB_ROOT_PASSWORD:-xyz}
      MARIADB_DATABASE: keycloak
      MARIADB_USER: keycloak
      MARIADB_PASSWORD: ${MARIADB_KEYCLOAK_PASSWORD:-xyz}
    mem_limit: 300m
    mem_reservation: 200m
    container_name: mariadb
    volumes:
      - mariadb_data:/var/lib/mysql
    restart: always
    networks:
      - local

  keycloak:
    image: quay.io/keycloak/keycloak:${KEYCLOAK_VERSION:-latest}
    environment:
      KC_DB: mariadb
      KC_DB_SCHEMA: keycloak
      KC_DB_USERNAME: keycloak
      KC_DB_PASSWORD: ${MARIADB_KEYCLOAK_PASSWORD:-xyz}
      KC_DB_URL_HOST: mariadb
      KEYCLOAK_ADMIN: xyz
      KEYCLOAK_ADMIN_PASSWORD: xyz
      KC_PROXY: edge
      KC_HOSTNAME_STRICT: false
      KC_HOSTNAME_URL: https://${KEYCLOAK_DOMAIN}
    mem_limit: 500m
    mem_reservation: 400m
    command: start
    container_name: keycloak
    volumes:
      - ./keycloak/themes:/opt/keycloak/themes
      - ./keycloak-rest-provider-4.0.0.jar:/opt/jboss/keycloak/standalone/deployments/keycloak-rest-provider-4.0.0.jar
    restart: always
    networks:
      - local
    depends_on:
      - mariadb

  nginx:
    image: nginx:${NGINX_VERSION:-latest}
    environment:
      KEYCLOAK_DOMAIN: ${KEYCLOAK_DOMAIN}
    mem_limit: 50m
    mem_reservation: 20m
    container_name: nginx
    volumes:
      - ./nginx/templates:/etc/nginx/templates
      - ./certbot/conf:/etc/letsencrypt
      - ./certbot/www:/var/www/certbot
    ports:
      - "80:80"
      - "443:443"
    restart: always
    networks:
      - local

  certbot:
    image: certbot/certbot:${CERTBOT_VERSION:-latest}
    environment:
      CERTBOT_LETSENCRYPT_EMAIL: ${CERTBOT_LETSENCRYPT_EMAIL}
      KEYCLOAK_DOMAIN: ${KEYCLOAK_DOMAIN}
    mem_limit: 20m
    mem_reservation: 10m
    container_name: certbot
    volumes:
      - ./certbot/conf:/etc/letsencrypt
      - ./certbot/www:/var/www/certbot
    command: certonly --non-interactive --webroot -w /var/www/certbot --email ${CERTBOT_LETSENCRYPT_EMAIL} -d ${KEYCLOAK_DOMAIN} --agree-tos
    depends_on:
      - nginx

the docker logs doesnt show up any logs that the plugin is loaded.
the container has the jar file mounted:
bash-5.1# pwd
/opt/jboss/keycloak/standalone/deployments
bash-5.1# ls
keycloak-rest-provider-4.0.0.jar
bash-5.1#

I tried to manually write a keycloak-rest-provider-4.0.0.jar.dodeploy file but it still doesnt work.
My keycloak still looks like this:

Additional Info:
Keycloak Server info:
Version
24.0.4
do you guys know what i am doing wrong?

i build the plugin again with ./mvnw clean package
and moved it into the container.
It still doesnt work. No List, no rest migration can be chosen

the jar files should now be in /opt/keycloak/providers
after I did the changes, it worked:


[rv_dm] dm/dmi sometimes get stuck when issuing an abstract command

Description
This issue has been investigated as part of #17729. In short, when issuing an abstract commands to read a register, and in yet-to-be-understood circumstances, the rv_dm module seems to get stuck and the jtag output is stuck to 1. It is still unclear which components gets stuck exactly, it looks like the DMI might be working but the DM is not responding for a while so it is just sending back some 1s. A typical error trace looks like this:
Debug: 12382 1056 riscv-013.c:783 execute_abstract_command(): command=0x22100e; access register, size=32, postexec=0, transfer=1, write=0, regno=0x100e
Debug: 12466 1057 riscv-013.c:397 scan(): 41b w 0022100e @17 -> + fffffffe @7f; 2i
Debug: 12550 1057 riscv-013.c:397 scan(): 41b r 00000000 @16 -> b ffffffff @7f; 2i
Debug: 12551 1057 riscv-013.c:460 increase_dmi_busy_delay(): dtmcs_idle=1, dmi_busy_delay=3, ac_busy_delay=0
Debug: 12661 1058 riscv-013.c:451 dtmcontrol_scan(): DTMCS: 0x10000 -> 0xffffffff
Debug: 12715 1058 riscv-013.c:397 scan(): 41b r 00000000 @16 -> b ffffffff @7f; 3i
Debug: 12716 1058 riscv-013.c:460 increase_dmi_busy_delay(): dtmcs_idle=1, dmi_busy_delay=4, ac_busy_delay=0
Debug: 12826 1059 riscv-013.c:451 dtmcontrol_scan(): DTMCS: 0x10000 -> 0xffffffff
Debug: 12880 1059 riscv-013.c:397 scan(): 41b r 00000000 @16 -> ? 413d5213 @00; 4i
Error: 12881 1059 riscv-013.c:606 dmi_op_timeout(): failed read at 0x16, status=1
Debug: 12991 1060 riscv-013.c:451 dtmcontrol_scan(): DTMCS: 0x10000 -> 0x1071
Debug: 12992 1060 riscv-013.c:806 execute_abstract_command(): command 0x22100e failed; abstractcs=0x0
Debug: 13076 1060 riscv-013.c:397 scan(): 41b w 00000700 @16 -> + 00000000 @00; 4i
Debug: 13077 1060 riscv-013.c:407 scan():  cmderr=7 ->
Debug: 13131 1060 riscv-013.c:397 scan(): 41b - 00000000 @16 -> + 00000700 @16; 4i
Debug: 13132 1060 riscv-013.c:407 scan():  ->  cmderr=7
Debug: 13133 1060 riscv.c:3450 riscv_get_register(): [riscv.tap.0] a4: ffffffffffffffff
Debug: 13134 1060 gdb_server.c:1483 gdb_error(): Reporting -4 to GDB as generic error
Debug: 13135 1060 gdb_server.c:406 gdb_log_outgoing_packet(): [riscv.tap.0] sending packet: $E0E#ba

See #17729 for more traces.
When this happens, it looks like waiting for the DM to get unstuck and resetting the DMI allows debugging to continue.

Thanks for creating this issue and the workaround in #18051, @pamaury :+1:
I was wondering if tdo gets sampled while undriven by the debug module but pulled up somehow? In all but the Shift states (Shift-IR and Shift-DR), the DMI JTAG TAP indicates that tdo should not be driven by assigning tdo_oe_o = 0. I don't remember off-hand how that is implemented on the FPGA. In any case, OpenOCD should not sample tdo outside the shift states -- do we know if something could be off there?

@pamaury @andreaskurth @timothytrippel @moidx
This seems to be in the same category as #17729.
Since that issue has been root caused and will be fixed by #18554, shall we close this (or defer to M2.5.2 to double check whether it can be closed)?

Yes I believe we can close this when #18554 merges. Also @pamaury we probably don't need your OpenOCD patch anymore once #18554 merges correct?

The final proper fix (appart from #18554) is #18599

@pamaury can this be closed now?

Yes.