[DOCFIX] add quotes in docs/_includes/Command-Line-Interface/rm.md

Now,' /data/2014*' is  in quotes

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/17894/
Test PASSed.


Cannot change displayedRows child component from  to

Search keywords
TablePagination
Latest version

[X] I have tested the latest version

Summary
Currently it renders:
It should render:
Context 🔦
I'd like to render a custom React component (with a LinearProgress) in place of count numeric value using labelDisplayedRows prop, so I can display a progress bar while the total number of table rows is not yet available.
Examples
                  <TablePagination
                      data-testid='table-pagination'
                      component={'th'}
                      sx={styles.styledHeaderPagination}
                      count={listLength || 0}
                      page={pageIndex}
                      onPageChange={onPageChange}
                      rowsPerPage={pageSize}
                      onRowsPerPageChange={(event) => {
                          setPageSize(Number(event.target.value));
                      }}
                      labelDisplayedRows={({from, to, count }) => (
                        <>
                        <Box sx={styles.paginationNumbers}>
                          <span style={{ fontSize: '14px' }}>
                            {`${from}-${to === -1 ? count : to} of ${count}`}
                          </span>
                        </Box>
                        </>
                      )}
                      rowsPerPageOptions={[4, 10, 25, 50]}
                  />

                  The issue here is when i try to override this labelDisplayedRows to have a Box or a div, or anything but a span it complains about a div being inside a p tag.

Motivation
No response

The fix for this is to add component={'span'} under Box so it gets overwritten and doesnt complain.


Fix outbox message avatar (if gravatar)

We were passing the incorrect field email instead of sender_email.
It is used to determine the user's avatar if avatar_url is null.

Seems like this code path could benefit from a test?

I will add more comprehensive unit-tests with the refactor that is pending.
Also, this would have been caught by Flow if we did cover it, I will be adding it to this area next.


Querying lists doesn't return every result on changes

Version info
Angular: 2.4.3
Firebase: 3.6.0
AngularFire: 2.0.0-beta.7
How to reproduce these conditions
Steps to set up and reproduce
Plnkr example of the issue

FirebaseListObservable doesn't always return all the queried items. When we use query options like startAt & orderByChild.

Add the code below to your project and the data to Firebase

Start changing the order properties from positive to negative and back again from Firebase console

At some point the number of items returned will differ

Here's a reproducable example that you can test:

// ANGULARFIRE
this.af.database.list('order_testing', {
  query: {
    orderByChild: 'order',
    startAt: 0
 }
}).subscribe(x => console.log('ANGULARFIRE:', x.length));

// FIREBASE
this.af.database.list('order_testing').$ref.orderByChild('order').startAt(0).on('value', (x) => {
   console.log('FIREBASE:', Object.keys(x.val()).length)
});

Sample data and security rules
Here's the data located under order_testing in Firebase
{
  "obj1" : {
    "order" : 1
  },
  "obj2" : {
    "order" : 2
  },
  "obj3" : {
    "order" : 3
  },
  "obj4" : {
    "order" : 4
  },
  "obj5" : {
    "order" : 5
  }
}

Debug output
FIREBASE: 5
ANGULARFIRE: 5

// After changing some ordering to negative and back to positive the number of items will differ

FIREBASE: 5
ANGULARFIRE: 4

Expected behavior
The logged values from Angularfire & Firebase should remain the same after changes to order property
Actual behavior
The logged values from Angularfire & Firebase are not the same after changing the order property

Thank you for the detailed write-up! Can I also trouble you for a plnkr? We have a template here: http://plnkr.co/edit/8yY4tH?p=preview
This will ensure we're tackling the same problem and make it much easier for me to debug.

Hey! I've made a plnkr available for you. See if it helps: http://plnkr.co/edit/9UzrMSHPowJ1K4zMbiQz?p=preview

@antti-pyykkonen This looks very much like the problem that was addressed in PR #775.

@cartant @antti-pyykkonen I'll be cutting a next release soon. I'll update this thread when it's out.

@cartant I'm trying to find your contact info, but you a hard person to find! Send me an email to<EMAIL_ADDRESS>and let's talk about some AF2 :)

I believe this is now solved?

@antti-pyykkonen Yes it is!


How to reverse crc.crc16ccitt?

Is there any way to reverse the output of crc.crc16ccitt back to original input string? Is there any undocumented method to do this? Please help

No, checksum is one way only.


Add form to office to approve sit request

Description
Adds the form that office users will use to approve a SIT request. This story only shows the form. There is another story for submitting the form.
Setup
Add any steps or code to run in this section to help others prepare to run your code:
make db_dev_e2e_populate
make server_run
make client_run

In the TSP app, select an HHG record and request a SIT. Next, go to the Office app and select the same record for which you added the SIT request. You will see the SIT panel, and an Approve link that opens up the form.
References

Pivotal story for this change

Screenshots

@Ryan-Koch spacing was fine. Couple of minor changes to unbold Accept and change the language for the date title. But good to go if you want to take one more look.


update areaDetail with data from d3 CDN

closes: #428

updated constants with d3 CDN info
placed AreaDetail component in folder
fixed J40Alert padding-left console warning
added tests for both J40Alert rendering

closing to test automatic deployment


runtime: i3config and swayconfig updates

Move always option from i3config's focus_follows_mouse to swayconfig
Add toggle as option to swayconfig smart_gaps

@hiqua: could you please review the i3Config updates?

Thanks. I'll await the ACK by @hiqua :)
Also, can you do me a favor, and create separate commit for each runtime file instead? So one Commit for i3 and one commit for swayconfig?

let me include this, thanks

Sorry for the delay, thanks for merging!


Support refreshing static image without switching the view

With current configuration I can't watch Live feed properly, because after 10 seconds it switches back to image view. Would like to have support for static image refresh without having to switch current view.
Current configuration:
type: custom:frigate-card
view:
  default: image
  timeout: '10'
  update_force: true
image:
  src: https://xxxx/frigate_reverse_proxy/api/living_room/latest.jpg
cameras:
  - camera_entity: camera.living_room_frigate
    live_provider: frigate

Yeah. Think the fix is just the image view to implement its own refresh loop, rather than relying on the main card one.

Fantastic work!
Tested, so far no issues. This card still not popular enough, but I think soon it will be and it's going to be most popular one for sure. Definitely the best card I've used. Thank you so much. :heart:


Rename and refactor to Forem

As DEV broadens and has the codebase re-launched as Forem, it would be appropriate to rename and refactor the library to match.
See Ben's post: https://dev.to/devteam/for-empowering-community-2k6h
The repository itself will be renamed at a later date once this is done.

Hi @Turnerj ,
I will like to help with this.
This is my first time contributing to open source projects

Hey @insight001 - that's fantastic that you want to help and that this is your first time contributing to open source! Happy to have you work on this change.
For the actual changes, I'm thinking the following:

Change namespace references of "DevTo" to "Forem"
Update ReadMe to reference "Forem" (though note how it was formerly "DevTo", possibly linking off to the link I have in the issue description about Forem)
Change AddDevToApi method name to AddForemApi

Don't worry about updating the project names or solution name for now as the build scripts currently reference them. Same goes with updates to the "Directory.Build.props" files - they can still reference "DevTo" for now.
Let me know if you have any questions or need any help with anything. 🙂

Alright, Thanks for the detailed response
Will get on it immediately.

Thanks again for doing the changes here @insight001 - the only ones left are ones I need to do to the repository etc (change repo name, changing package name). At the moment I will leave them as-is as there are some side effects from those changes that I need to make sure I account for. 🙂

Repository and description is updated - hopefully no issues arise from CI or other integrations. For the CS Project and Nuget package, I'm thinking I will have to do two consecutive releases - one where I put an Obsolete attribute on the main classes and publish that under "DevTo.Api" library with updated descriptions about "Don't use this going forward, use 'Forem.Api'".

That's great

@Turnerj what's left here?

Just finished this up right now - the "DevTo.Api" package on NuGet is deprecated and a new "Forem.Api" package is published. 😀

🚀


docs - mugc.py add documentation on how to remove all policies

Start with a policy:
policies:
 - name: password-policy-check
   resource: account
   region: us-east-1
   mode:
     role: arn:aws:iam::123456789000:role/your-role
     type: periodic
     schedule: "rate(3 minutes)"
   filters:
     - type: password-policy
       key: MinimumPasswordLength
       value: 10
       op: ge
     - type: password-policy
       key: RequireSymbols
       value: true

Run custodian, try to remove either everything, or just everything under policies and mugc will throw an error.
I guess actually; this bug means I wouldn't ever be able to remove all of my policies - regardless

So policies needs to be an empty list: policies: [] - If you just remove all your policy files, it will complain, if you empty a policy file - it will complain. If you have at least one other policy going on, you're fine.
So looks like this is cleared up; but could use some documentation surrounding it.

Thanks for filing the issue @thomasbiddle, I'll add a label and edit the title to reflect this should be a docs fix.

We also take contributions so feel free to submit a pull request 😄


TypeError: $fetch.$post is not a function

Environment

Operating System: Darwin
Node Version:     v18.11.0
Nuxt Version:     3.0.0
Nitro Version:    1.0.0
Package Manager<EMAIL_ADDRESS>Builder:          vite
User Config:      ssr, typescript, modules, auth
Runtime Modules<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>Build Modules:    -

Nuxt Config
// https://v3.nuxtjs.org/api/configuration/nuxt.config
export default defineNuxtConfig({
ssr: true,
typescript: {
shim: false,
},
modules: [
'@nuxtjs/tailwindcss',
'@nuxtjs-alt/auth',
'@nuxtjs-alt/http',
'@nuxtjs-alt/proxy',
'@pinia/nuxt',
],
auth: {
strategies: {
github: {
clientSecret: 'my_secret',
clientId: 'my_id',
},
},
},
});
Reproduction
I can't share my github oauth secrets. I made a very simple nuxt app to try login to github using your module.
Describe the bug
During the oauth2 code redirect process my nuxt server try to make an api call to retrieve the access token in exchange of the oauth2 code using this call (from src/utils/provider.ts):
              $fetch.$post(options.tokenEndpoint, {
                  body: data,
                  headers
              })
              .then((response) => {
                  event.res.end(JSON.stringify(response))
              })
              .catch((error) => {
                  event.res.statusCode = error.response.status
                  event.res.end(JSON.stringify(error.response.data))
              })

But it seems that $fetch is not an instance but un function to get the instance.
I've probably misconfigured something but i can't figure out what.
I tried to change $fetch.$post by $fetch().$post then it worked as expected.
Additional context
No response
Logs
No response

I've updated the auth module.

It works fine, thank you very much!


text changed delegate

this method exposes the pre-shouldChangeCharactersIn text result instead of the value after the textField has been updated

fixed by utilizing an observer
textField.addTarget(self, action: #selector(textFieldDidChange(_:)), for: UIControlEvents.editingChanged)


s109 drops 500 in report

Describe the bug
I did a short scan and "Cracking identified password hashes" menu dropped 500 in the browser. The s109_jtr_local_pw_cracking.html exists in the file system and contains the good password. Only the page is not displayed.
To Reproduce
Steps to reproduce the behavior:

EMBArk installation (default mode)
Start EMBArk: sudo ./run-server.sh
Use the firmware available here: kkeps.bin
Open Cracking identified password hashes menu in detailed view.
See error

Expected behavior
Display page for s109.
Screenshots

Desktop (please complete the following information):

OS: Ubuntu Server 22.04.3

Additional context
s109_jtr_local_pw_cracking.txt

I would guess it's a non utf8 conform byte that causes the issue.
Can you:

Supply me with the actual html-report folder (alternatively, just the html file that's not working)
Check for log errors for a Unicodedecode error

html-report.zip
emba_run.log
There are more log files, I don't know which one should I check. :(

Sorry, /var/www/embark/embark.log

embark.log
Yes, UnicodeDecodeError exists more times in the file:(

Will try to solve this in EMBA directly

Could you provide me with the firmware for testing?

Please download it from here:
https://drive.google.com/file/d/1jXqPpg_z8ghZG0XPxtx-qtl2Mx_N2FL1/view?usp=sharing

It can happen that I used a not supported password file and that caused this issue. I am going to try the same test with a basic password list and let you know the outcome soon.

Hmm, I used rockyou.txt with adding the good password to the last line and the s109 cracked it and the page is available:

Looks like I used a not supported password list. :(
I just wanted to have a huge dictionary for better coverage. My last question would be if you could suggest any good and large list it would be great but I will also look for an acceptable one.

I tried today and the page is available:

Thank you!

@BenediktMKuehne good work

The changes affect only s109  and s99 (jtr and grepit modules)


SAB Stating it is unable to run script

I was running this set of scripts fine before but reloaded my OS and now when attempting to post process from SAB I get the following error
Exit(-1): Cannot run script C:\PlexTools\MP4Automator\SABPostProcess.py
I was able to get it to run by picking a batch file which then run the sabpostprocess.py so I am pretty sure it is a problem with SAB not finding the python installation.
System Information

OS: Windows
Python version: 3.1.2

[Converter]
ffmpeg = C:\PlexTools\ffmpeg\bin\ffmpeg.exe
ffprobe = C:\PlexTools\ffmpeg\bin\ffprobe.exe
threads = 0
hwaccels = dxva2, cuvid, qsv, d3d11va
hwaccel-decoders = h264_cuvid, mjpeg_cuvid, mpeg1_cuvid, mpeg2_cuvid, mpeg4_cuvid, vc1_cuvid, hevc_qsv, h264_qsv
output-directory =
output-format = mp4
output-extension = mp4
temp-extension =
minimum-size = 0
ignored-extensions = nfo, ds_store
copy-to =
move-to =
delete-original = True
sort-streams = True
process-same-extensions = False
force-convert = False
post-process = False
preopts =
postopts =
hwdevices = vaapi:/dev/dri/renderD128
hwaccel-output-format = vaapi:vaapi
bypass-if-copying-all = False
wait-post-process = False
detailed-progress = False
opts-separator = ,
regex-directory-replace = [^\w-_. ]
output-directory-space-ratio = 0.0
[Permissions]
chmod = 0644
uid = -1
gid = -1
[Metadata]
relocate-moov = True
full-path-guess = True
tag = True
tag-language = eng
download-artwork = poster
sanitize-disposition =
strip-metadata = False
keep-titles = False
[Video]
max-bitrate = 0
crf = -1
crf-profiles =
max-width = 0
profile =
max-level = 0.0
pix-fmt =
filter =
force-filter = False
codec = h264qsv, h264, x264, h265, x265, hevc
bitrate-ratio =
preset =
codec-parameters =
dynamic-parameters = False
prioritize-source-pix-fmt = True
[HDR]
space = bt2020nc
transfer = smpte2084
primaries = bt2020
filter =
force-filter = False
codec =
pix-fmt =
preset =
codec-parameters =
profile =
[Audio]
codec = ac3
languages = eng
default-language = eng
first-stream-of-language = False
allow-language-relax = True
channel-bitrate = 128
max-bitrate = 0
max-channels = 0
prefer-more-channels = True
filter =
force-filter = False
sample-rates =
copy-original = False
aac-adtstoasc = False
ignore-truehd = mp4, m4v
ignored-dispositions =
unique-dispositions = False
include-original-language = True
variable-bitrate = 0
profile =
sample-format =
force-default = False
stream-codec-combinations =
[Universal Audio]
codec = aac
channel-bitrate = 128
first-stream-only = False
filter =
force-filter = False
variable-bitrate = 0
profile =
[Subtitle]
codec = mov_text
codec-image-based =
languages = eng
default-language = eng
first-stream-of-language = False
encoding =
burn-subtitles = False
burn-dispositions =
embed-subs = True
embed-image-subs = False
embed-only-internal-subs = False
filename-dispositions = forced
ignore-embedded-subs = False
attachment-codec =
ignored-dispositions =
unique-dispositions = False
include-original-language = False
force-default = False
remove-bitstream-subs = False
[Sonarr]
host = localhost
port = 8081
apikey =
ssl = False
webroot = /sonarr
force-rename = False
rescan = True
block-reprocess = False
in-progress-check = True
[Radarr]
host = localhost
port = 8082
apikey =
ssl = False
webroot = /radarr
force-rename = False
rescan = True
block-reprocess = False
in-progress-check = True
[Sickbeard]
host = localhost
port = 8081
ssl = False
apikey =
webroot =
username =
password =
[Sickrage]
host = localhost
port = 8081
ssl = False
apikey =
webroot =
username =
password =
[CouchPotato]
host = localhost
port = 5050
username =
password =
apikey =
delay = 65
method = renamer
delete-failed = False
ssl = False
webroot =
[SABNZBD]
convert = True
sickbeard-category = sickbeard
sickrage-category = sickrage
couchpotato-category = couchpotato
sonarr-category = sonarr
radarr-category = radarr
bypass-category = bypass
output-directory =
path-mapping =
[Deluge]
couchpotato-label = couchpotato
sickbeard-label = sickbeard
sickrage-label = sickrage
sonarr-label = sonarr
radarr-label = radarr
bypass-label = bypass
convert = True
host = localhost
port = 58846
username =
password =
output-directory =
remove = False
path-mapping =
[qBittorrent]
couchpotato-label = couchpotato
sickbeard-label = sickbeard
sickrage-label = sickrage
sonarr-label = sonarr
radarr-label = radarr
bypass-label = bypass
convert = True
action-before =
action-after =
host = localhost
port = 8080
ssl = False
username =
password =
output-directory =
path-mapping =
[uTorrent]
couchpotato-label = couchpotato
sickbeard-label = sickbeard
sickrage-label = sickrage
sonarr-label = sonarr
radarr-label = radarr
bypass-label = bypass
convert = True
webui = False
action-before =
action-after =
host = localhost
ssl = False
port = 8080
username =
password =
output-directory =
path-mapping =
[Plex]
host = localhost
port = 32400
refresh = False
token =
username =
password =
servername =
ssl = True
ignore-certs = False
path-mapping =
[Subtitle.Subliminal]
download-subs = False
download-hearing-impaired-subs = False
providers =
download-forced-subs = False
include-hearing-impaired-subs = False
[Audio.ChannelFilters]
6-2 = pan=stereo|FL=0.5FC+0.707FL+0.707BL+0.5LFE|FR=0.5FC+0.707FR+0.707BR+0.5LFE
[Subtitle.Subliminal.Auth]
opensubtitles =
tvsubtitles =
[Audio.Sorting]
sorting = language, channels.d, map, d.comment
default-sorting = channels.d, map, d.comment
codecs =
[Subtitle.Sorting]
sorting = language, d.comment, d.default.d, d.forced.d
codecs =
burn-sorting = language, d.comment, d.default.d, d.forced.d
[Subtitle.CleanIt]
enabled = False
config-path =
tags =
[Subtitle.FFSubsync]
enabled = False

also noticed in debug logs it shows this
2024-02-13 15:36:23,668::DEBUG::[newsunpack:261] Failed script C:\PlexTools\MP4Automator\SABPostProcess.py, Traceback:
Traceback (most recent call last):
File "sabnzbd\newsunpack.py", line 246, in external_processing
File "sabnzbd\misc.py", line 1232, in build_and_run_command
File "subprocess.py", line 1026, in init
File "subprocess.py", line 1538, in _execute_child
FileNotFoundError: [WinError 2] The system cannot find the file specified

looks like it was a problem with sab, reinstalled and rebooted. it is working now


Alternative syntax using this?

An alternate, more "method"-y API would be to use this as the state variable, which would mean you could provide a simple record instead of a function of state:
const initialState = { count: 0 };

const methods = {
  reset() {
    return initialState;
  },
  increment() {
    this.count++;
  },
  decrement() {
    this.count--;
  },
};

Another advantage is that VSCode gives this special emphasis and color, so it's easy to tell at a glance where state access and "mutation" is happening.
Downsides of this approach:

Can't use arrow functions to define methods
Can't decide to use a shorter name for the state variable, e.g. s
Can't compute variables from state that will be in scope for all methods, e.g.:const methods = state => {
  const { x, y, z } = state;
  return {
    // ... method definitions
  }
};

I'm curious if others have any opinions about this.

Or maybe something like
const methods = {
  reset: () => () => initalState,
  increment: state => count => (state += count)
}

?

Or maybe something like
const methods = {
  reset: () => () => initalState,
  increment: state => count => (state += count)
}

?

The nice thing about the current API is that you only have to declare a state parameter once, for all your methods. Using an implicit this would make it so you don't have to even do that. But it sounds like you're suggesting each method would have to declare its own state parameter, which seems like a step backwards...

With this approach, will this be bound to the state? The current approach is nice in that you don't have to worry about how you invoke one of the methods.
<button onClick={reset}>Reset</button>

I personally think it would not be as nice if this was required with the this approach.
<button onClick={() => reset()}>Reset</button>

Yeah, this would always be bound, because we wouldn’t be using classes, just generating a bunch of functions which come pre-bound to their context.

I like it as-is (without this), partially because we use a lint that disallows this outside class bodies, and partially because this is a piece of JS magic that always seems suspicious.

We could do this without disrupting the existing API by just providing an optional helper that would work like this:
const methods = createMethods<State>({
  increment() {
    this.count++;
  },
  decrement() {
    this.count--;
  },
});

// equivalent to:

const methods = (state: State) => ({
  increment() {
    state.count++;
  },
  decrement() {
    state.count--;
  },
});

The question is, would anybody use it?

It feels superfluous, gonna close.


/pin is the correct command.  /setpin is invalid.

Hello,
As of OneDrive.app 23.189.0910.00001, the documentation for Files-on-Demand is incorrect.
The prescribed /setpin is nonfunctional.  If using /setpin, the full client launches and never returns to the shell.
After some digging on the Macadmins Slack I found this hint:
https://macadmins.slack.com/archives/C1HNS6CTB/p1644360665140419?thread_ts=1644352628.958319&cid=C1HNS6CTB
I've verified via strings that there are no instances of /setpin in the OneDrive binary.  Meanwhile, /pin does appear.
If substituting /pin, the documented commands and experience succeed as described.
Please revise the documentation to match product reality.
Kind regards,
Andrew

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 9537147b-4205-3355-c7ff-a3a8c115d0ae
Version Independent ID: cc079c73-e4fc-d5be-69e6-742e335d375e
Content: Set Files On-Demand states on Mac - SharePoint in Microsoft 365
Content Source: SharePoint/SharePointOnline/files-on-demand-mac.md
Service: one-drive
GitHub Login: @MikePlumleyMSFT
Microsoft Alias: mikeplum

Hello @atlauren Andrew,
Last time I checked, ODB Team was working on fixing this, I'll try to confirm if they replaced setpin with pin


Tooltip not cleaned up

If you hover over a chart that displays a tooltip, and then navigate away from the page without moving the mouse (i.e. browser back), the tooltip isn't cleaned up.

@davewasmer fixed in v0.1.3 😸


App page URL issues when app cold starts to rewards page

The Issue
On Windows, the app will load but fail to load the special URL (i.e lbry://?rewards) because the ? is not replaced in the createWindow.js file (which is loaded on cold start as opposed to the call in index.js). On Mac, the app will green screen because daemon_settings are not loaded quickly enough.
Fixed in pre-redesign here: https://github.com/lbryio/lbry-app/commit/81ce8582833a1ee659c55d79278992b2d75ff7af
Will fix with PR in redesign.
System Configuration

LBRY Daemon version:
LBRY App version:
LBRY Installation ID:
Operating system:

Anything Else

Screenshots

Fixed in https://github.com/lbryio/lbry-app/pull/1552


[@xstate/fsm] Use similar rollup.config as in core

fixes https://github.com/statelyai/xstate/issues/2458
Test projects with Fetcher component:

https://github.com/annaghi/xstate-fsm-react-js
https://github.com/annaghi/xstate-fsm-sveltekit-js
https://github.com/annaghi/xstate-fsm-vue-js

I am unsure about if it needs version bump or not. Can you give advice?

I am unsure about if it needs version bump or not. Is it necessary for this PR?

That's a good question for @Andarist

@annaghi Just to confirm: tested this branch against my reproduction of #2458 and it resolves the issue (besides the need of the .js in import { useMachine } from '@xstate/svelte/lib/fsm.js';) Thanks! 💯

Any update on this?

@jmsunseri @annaghi sorry that it took so long to get to this but I'm looking into it right now, gonna retest this with SvelteKit and merge this in shortly. I can't add any commits to this PR as the source repository has been deleted. I've managed to fetch the commit itself though so I'm going to recreate this PR soon.


Update syn/quote/proc_macro2 to 1.0

Thanks!
LGTM, I will merge it and publish a new version in this week.
(I haven't read latest syn/quote/proc_macro2 APIs documents carefully, give me few days.)


chore(dockerfile): upgrade to latest alpine image

This resolves a performance issue in JDK11 when Spinnaker is running in a cluster with containerd.

@mergifyio backport release-1.27.x release-1.28.x


Prepare for danger 3.4.0

Should hopefully be posting some stuff inline

Warnings

:warning:

Any changes to library code should be reflected in the Changelog.
Please consider adding a note there and adhere to the Changelog Guidelines.

:warning:

Danger.swift#L11 - Hello world

:warning:

Danger.swift#L13 - Hello world2

:warning:

Danger.swift#L15 - Hello world3

:warning:

Danger.swift#L17 - Hello world5

  Generated by :no_entry_sign: dangerJS

Looks like CI is initially running danger process directly, and is succeeding
Then it runs the full danger process and it dies, gonna take a look

OK, I'm gonna merge this, because I don't want it blocking CI  for others peeps, but I'm real interested in what's going on


Java Answers

@mykeels  the solution is complete kindly review the PR. You can run the answers in either Netbeans or IntelliJ

Thanks @Thecarisma !
I'm downloading OpenJDK right now, so I can test the solutions. Should be done tonight if NEPA is kind. 😄

I have resolve the issue with the Unicode character in question 4 and the logic in question 2 has been wrapped in a while loop as suggested

Now, for the N02Lottery problem, I get two responses when I press enter.

For N04TypeInReverse, I get a question mark, in place of the emojis when I enter a response.

For N14NumberInWords, there's an and missing from the hundreds words.
E.g. Three hundred "and" forty five

For the N04TypeInReverse the issue is the JDK you have does not support Unicode encoding which means the first error should not occur in the first place, I replaced the emojis with their Unicode value so instead of the error it shows the question mark. You can try to run the solution in an Online Java Compiler.
For N02Lottery 🙈, am using System.in directly instead of Scanner. Try another terminal for N02Lottery  if the error persist
I committed changes for N02Lottery

For N14NumberInWords, there's an and missing from the hundreds words.
E.g. Three hundred "and" forty five

Changes committed https://github.com/mykeels/20-questions/pull/8/commits/164bbfa55be0625e6c36a3dbd5a2c32c060c174f

For N16ConvetToDecimal, the file name has a misspelling, and should be N16ConvertToDecimal instead.
Also, the output phrase 7 in base 2 is 111 in base 10 should be 7 in base 10 is 111 in base 2.

The previous is incorrect because it suggests that the number 7 is in base 2.

For N17ConvertDecimalToBaseN, the program should request a decimal value, then convert to base n, not the other way around.
Also, the output phrase, 1000101 in base 10 is 69 in base 2 should be `1000101 base 2 is 69 base 10.

For N18SimpleCGPACalculator, the average and cgpa output should be floating point values.

For N20LoveCalculator, I get error: package com.sun.xml.internal.ws.util does not exist.

For N17ConvertDecimalToBaseN, the program should request a decimal value, then convert to base n, not the other way around.
Also, the output phrase, 1000101 in base 10 is 69 in base 2 should be `1000101 base 2 is 69 base 10.
For N18SimpleCGPACalculator, the average and cgpa output should be floating point values.
For N20LoveCalculator, I get error: package com.sun.xml.internal.ws.util does not exist.

Committed changes https://github.com/mykeels/20-questions/pull/8/commits/64f35dd7168772561cc659518b73268473df2d05

For N16ConvertToDecimal, here's the output:

I believe this is the last one.


assign() on JSON property fails when persisting with MongoDB driver

Describe the bug
Hi! First of all, thank you for maintaining the best ORM/ODM for NodeJS 🙂
While migrating a project from v5 to v6, I noticed some inconsistencies with persisting JSON properties.
Using bisection, I've identified that version 5.6.10 introduced a regression/bug. I'm not sure which commit precisely, but you can find the list here.
The issue is the following: When updating a JSON property using assign(), the change is not persisted in the database.
While digging a bit more, I discovered that the __originalEntityData wrapper property is also updated with assign(), thus preventing the changeset from being computed at commit time.
More info:

When updating the property with a brand new object, it works. The issue is only present with assign().
I confirmed the issue with the MongoDB driver but not with the SQLite driver, it seems to work fine with SQLite.

Reproduction
Here is a test case to reproduce the issue: https://github.com/alexandre-abrioux/mikro-orm-issue-5158
What driver are you using?
@mikro-orm/mongodb
MikroORM version
6.0.5
Node.js version
18.18.0
Operating system
No response
Validations

[X] Read the Contributing Guidelines.
[X] Read the docs.
[X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
[X] Check that this is a concrete bug. For Q&A open a GitHub Discussion or join our Slack.
[X] The provided reproduction is a minimal reproducible example of the bug.

Thank you @B4nan 🙂


Add Screenshots to Docs

It dawned on me that we don't have any screenshots of the editor, which could dissuade any new visitors from checking out the project. The screenshots can either be in an Imgur library or listed in a new page on the docs site. The link to the screenshots should be in the README and any appropriate doc pages.

Added in c49ee5e7253bde29cc2525e1da776a92927456e7. The album can be viewed here: https://www.editor.criticalflaw.ca/screenshots/


sku_details_query_completed signal not exist in 2.0.0 rc1

i plugged my phone and tested 2.0.0 rc1
sku_details_query_completed & sku_details_query_error signals doesn't exist

It's product_details_query_completed and product_details_query_error now

what about sku index

Try this


Implement search functions

Add search by popularity tag functions, as suggested in #27 .
Whether to use the feature depends on users.
It would be like this:

Coverage increased (+1.4%) to 37.017% when pulling aba55ab33115c4c0f800d80e0bdfbda95e01ea0e on kirainmoe:master into 98f50513d100e46c955ce3e88412f724fa1a6f94 on LoveLiveSunshine:master.


Add prefix option for serving behind proxy

I do most of my work on a remote machine using JupyterHub which is a proxy in front of my Jupyter instance. I use jupyter-server-proxy to expose ports through the proxy (ex. http://<IP_ADDRESS>/notebook/mine/temp_nb/proxy/8081/ where netron is serving on port 8081).
The current version of netron does not work with this setup since it serves the model file from the top level of the server path. I added a parameter to allow the user to tell the server what path it is being served on underneath the top address and prepend that to the serving path of the model. This should not have any affect for users who are using netron normally.
Not sure if you want this in the main repository but figured I would share the work I did in case anyone else has the same use case. Thanks for the great work!

The other files like index.js would still be served from the top level folder? Can you provide some context why this is an issue for the model file and not any of the other files?

If other files work this seems to be an issue with the client prepending the location. Would 7bb852b resolve this?


Upgrade react from 16 to 18

Motivation and context

How has this been tested?

Checklist

[ ] I submit my changes into the develop branch
[ ] I have created a changelog fragment
[ ] I have updated the documentation accordingly
[ ] I have added tests to cover my changes
[ ] I have linked related issues (see GitHub docs)
[ ] I have increased versions of npm packages if it is necessary
(cvat-canvas,
cvat-core,
cvat-data and
cvat-ui)

License

[ ] I submit my code changes under the same MIT License that covers the project.
Feel free to contact the maintainers if that's a concern.

/check

/check

/check

@klakhov  Applied

Exclamation mark and excessive left padding now appear on organization switch modal

I believe this is general antd change:

Major version update for package.json?

I do not see reasons to update major version. Generally all the changes are cosmetic.

Also I cant close it without selecting something new

Applied

Do we really want to use blue hover effect?

Default antd button, I reversed it as it was with custom css.

Here I suppose using bold black font would be better instead of blue too.

The same.

If we dont have an assignee, maybe we dont want to show the line with it at all? Or at least say something like not assigned so we dont have emty space.

The main idea is to keep height the same. Sliding bottom part is annoying a little bit.

I like the idea of showing stage+state in one status row like annotation in progress or annotation rejected, it looks cool. But it looks strange with new, maybe we should use an alias for that something like annotation not started.

The main idea behind it was to keep vertical space, using horizontal free space. I would avoid customizing logic in described way.

Small padding problem on models page(it seems the same problem is on the projects page):

Fixed on projects/jobs/models. Also fixed top bars on different resolutions.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 83.39%. Comparing base (6919c5e) to head (790d2b1).
Report is 10 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #7466      +/-   ##
===========================================
+ Coverage    83.36%   83.39%   +0.02%
===========================================
  Files          380      381       +1
  Lines        40021    40049      +28
  Branches      3765     3766       +1
===========================================
+ Hits         33365    33397      +32
+ Misses        6656     6652       -4

Components
Coverage Δ

cvat-ui
79.30% <100.00%> (+0.02%)
:arrow_up:

cvat-server
87.15% <ø> (+0.01%)
:arrow_up:


docs: fix typo in README.md

This PR corrects a typo for the word "Semantic" in README.md.

Thanks!


Implement jnp.r_ and jnp.c_

This PR contains the jax.numpy equivalents of np.r_ and np.c_. This is my first attempt at a contribution to JAX, and these two routines were the ones left open in issue #5850, so I decided to take them on. I added some tests as well.
I am not sure if I handled the dtype promotion correctly, and whether I should have dtype-checked in the tests as well in this case. Stylistically, I based my implementation here on that of jnp.ogrid (or rather, the private base class of it) from the same issue as above. I would love to get some feedback on this and improve it so that it can be merged into Jax in the end.

Thank you for all of your comments @jakevdp! I'll start tackling them tomorrow with a fresh mind.
Regarding the PendingDeprecationWarning: This was raised in my local test session when calling e.g. np.r_["r",...], causing the tests to fail.
jnp.r_/c_ returns a JAX array, but I still felt it was necessary to test equality for the two special directive options "r"/"c" explicitly, and for those, numpy.r_/c_ returns a numpy.matrix instead of an array, as per the numpy.r_ docs. This is a deprecated class in numpy; quoting this StackOverflow answer:

And at the same time a PendingDeprecationWarning has been added to matrix.__new__.

Is there a better way to go about this? I tried to use the jtu.ignore_warning decorator, but failed (I think because the class has no __call__ operator).
I have another question: The isinstance(item, slice) portion in the main if-else branch is basically a duplicate of the code in _IndexGrid.__getitem__. I did not want to reuse that though, because of the nested for loop. Do you think it makes sense to refactor this part into its own function and use it in both places?
And lastly: Should I address each of your points in separate commits, or should I just put everything into a single commit and iterate the review procedure?

Thank you for all of your comments @jakevdp! I'll start tackling them tomorrow with a fresh mind.

Great! I'll look forward to seeing it

Regarding the PendingDeprecationWarning...

Thanks for the clarification. In that case, I think this is fine. I didn't see any indication as to whether numpy will remove this option when matrices go away, or just return arrays instead. I suspect it's the latter.

I have another question: The isinstance(item, slice) portion in the main if-else branch is basically a duplicate of the code in _IndexGrid.getitem.

Moving that to a common utility would be a good approach.

And lastly: Should I address each of your points in separate commits, or should I just put everything into a single commit and iterate the review procedure?

Do whatever is most convenient for you; once everything is finished I'll be asking you to squash all the changes into a single commit, but that can easily done retroactively.

It looks like there are some doctest failures for the new docstrings. You can run the relevant tests locally with
pytest --doctest-modules jax/_src/numpy/lax_numpy.py

Apologies!  Removing them makes the tests succeed. Should I take them out then?

Yes, I'd say take the comments out to make the doctests pass

Thanks, looks great! We'll get this merged as soon as tests pass :grin:


Remove libgfortran library from conda config

Based on Rajan Aurora's testing, this library is no longer compatible with the Databricks conda environments, and removing it does not appear to break functionality of our examples.
Removing it now.

Great, thanks!


chore: drop Node6 support

Node6 was end-of-life'ed in the end of April, 2019, with AWS Lambda
prohibiting updaets to the node6 runtime since June 30, 2019.
This makes it quite safe for us to remove the Node 6 support from the
repository.
From now on, all subsequent releases will require Node 8.9.0+.

I think this should be a major change

The test: Puppeteer-Web should work over web socket
looks like its failing.

Note that since Node.js v8+ supports async/await, we can now drop the asyncawait feature testing present in various places. :+1:

Moved to https://github.com/GoogleChrome/puppeteer/pull/5045.


Adding Finished Button

There is Delet button but it not make much sense so i want to make a finish button also .
Assign me

But if the task is done it can be deleted from to do list.


[SPARK-23688][SS] Refactor tests away from rate source

What changes were proposed in this pull request?
Replace rate source with memory source in continuous mode test suite. Keep using "rate" source if the tests intend to put data periodically in background, or need to put short source name to load, since "memory" doesn't have provider for source.
How was this patch tested?
Ran relevant test suite from IDE.

@jose-torres Please review this PR. Thanks!
cc. @jerryshao @HyukjinKwon

Can one of the admins verify this patch?

ok to test

Test build #89843 has started for PR 21152 at commit ec5c6e6.

Test build #89843 has finished for PR 21152 at commit ec5c6e6.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

also cc. to @tdas since he reviews SS related PRs (as well as continuous mode) so far.

Thanks fore reviewing. I have addressed review comments.

Test build #89877 has started for PR 21152 at commit 3eee5c9.

Test build #89877 has finished for PR 21152 at commit 3eee5c9.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/89877/
Test PASSed.

LGTM. Merging to master.

@HeartSaVioR what is your JIRA id?

@jerryshao Thanks for merging! My Apache JIRA ID is “kabhwan”


Support Imperial Assault

Ideally would occur after official app.  We could support anyway with scans if someone is keen enough.

The only issue I could see with this is this could stand the strongest chance of hitting the copyrights flags being that Disney is well known to protect anything that has their IP's in.

https://www.fantasyflightgames.com/en/news/2017/11/20/legends-of-the-alliance/
!!!
Lots of work ahead.  I'm thinking get 1.7 out with the current list and target 1.8 for an initial IA release.

Looking forward to this bad boy!!

App has been released on the 1. December on Google Play
https://play.google.com/store/apps/details?id=com.fantasyflightgames.iaca&hl=de
Steam states a release date for the 4. December.

Released on steam. http://store.steampowered.com/app/703980/Star_Wars_Imperial_Assault__Legends_of_the_Alliance/

My plan for this is to go directly for code injection/database dump.  For MoM and D2E I mostly manually entered data and observed the application, and this resulted in a lot of work and high error rate.  I have created a code injection system to get some data out of the app, but it was too little too late.
For this I would like to dump all of the internal data out, and script it into ini files automatically.  This will improve quality and make app updates and new expansions much easier to support.
For those who have used/are using the app, it would be great to start a list of everything that it does that Valkyrie doesn't support.  To start with:

Color coded enemy groups

This seems very similar to the MoM token system, but it lets the user pick the color.
I am also not sure how allies work in the app (I have only read the rules, haven't used it yet).  This is likely to need some changes.

Started reverse engineering:
Fame works differently.  All items have a fame 'cost', and the rewards will be picked randomly such that the total fame cost is less than current fame.
Classes are assumed by hero connection, and skills must be purchased in order
There is a 'weapon type' trait for heroes which I haven't worked out exactly what it does yet, seems to be related to item rewards/selection. Options are None, Melee, Ranged, Ranged_Pistol, Ranged_Long.
Items have a number of mod slots.  Game appears to use this to determine total number of slots and mods over the party and provide more mods if there are available slots.
Allies are a new mechanic, currently unsupported.
Enemy information is split into instructions, surge order, and for standard/elite.
Enemies have something called a "SecondaryPriorityOverride"?

Asset files are from a new version of Unity (data revision 17).  Hopefully it isn't too different.  UABE seems to work, so must be possible.

Dataz!
IA.zip

Sry for the confusion with the milestones, missclicked.
@ookus2
Planned. Have a look at milestone 2.1

The current plan is to work on mostly D2E improvements for 2.1 (and some MoM things), then revisit IA. There is no actual timeline, it is based on my available time, which is currently limited.
I welcome help. I suggest picking an issue in the list that @redwolf2 linked and putting forward a solution. I recommend describing how you intend to implement it before starting work (use the issue tracker) so that we don't have conflicting directions.

PS: General development information is here:
https://github.com/NPBruce/valkyrie/wiki/DeveloperGuide

Dataz!
IA.zip

@NPBruce How did you extract this data in this format? I'm using UABE and can't find a lot of this data.
I'd like to generate the same extract, but for the latest version of Legends of the Alliance (not 1.0.0 as you have here). Could you please share your process?

What data specifically are you after? The ini files are simple auto generated outputs from some code I have written, there isn't much to them.

I'm interested in a few things, and I can't figure out which files I need to extract to piece this information together.

Raw text:
text/CAM_1_en.txt
text/CAM_T_en.txt
text/Localization_en.txt
text/Tasks_en.txt

Item details (mostly the price)
SWI*/items.ini

Enemy activation details:
SW*/activiations.ini

Are you able to share a gist or similar for the code you've written? Or describe the high-level process? I'm stumped as to which bits of game data I need to look at to find this information.

Some of the localization data is in downloadable extra packages, which are fetched by LotA when you run it.
As for the other meta data, I moded the LotA app an wrote some code to inject my own fuction and dump their database. Have a look here:
https://github.com/NPBruce/valkyrie/tree/master/libraries/IADBExtract

Some of the localization data is in downloadable extra packages, which are fetched by LotA when you run it.
As for the other meta data, I moded the LotA app an wrote some code to inject my own fuction and dump their database. Have a look here:
https://github.com/NPBruce/valkyrie/tree/master/libraries/IADBExtract

Thank you. This is just what I needed :+1:


[Question] Do you recommend any "differential methylation" methods that use output from nanopolish?

I currently have quite a bit of frequency tables generated from nanopolish.  I have 2 conditions for my experiments and was wondering if there are any differential methylation scripts available in nanopolish or if you recommend any methods that can make use of this data?
In particular, the output from calculate_methylation_frequency.py.
My apologies if this is out of scope.  If so, I will close the issue immediately.

Hi @jolespin,
We don't have an officially recommended differential methylation approach yet. You might look at https://github.com/a-slide/pycoMeth and https://github.com/wdecoster/methplotlib for ideas on how to compare across samples.
Jared

Thanks a lot @jts !  These look really intuitive to use.  Looks like my only hurdle is a good way to merge replicate runs of calculate_methylation_frequency.py that I should have merged before running nanopolish in the first place so I can properly use pycoMeth.  I have some ideas for this though.  Cheers


scan: support workspace '.' for SPM

New Issue Checklist

[x] Updated fastlane to the latest version
[x] I read the Contribution Guidelines
[x] I read docs.fastlane.tools
[x] I searched for existing GitHub issues

Issue Description
See https://forums.swift.org/t/i-made-a-little-spm-package-that-uses-uikit-how-can-i-run-tests-from-command-line/50399/2.
In order to run SPM tests on a simulator, one can use xcodebuild now like this:
xcodebuild(
  workspace: '.',
  scheme: 'SPM target',
  destination: "platform=iOS Simulator,name=iPhone 14,OS=16.4",
  sdk: 'iphonesimulator',
  test: true
)

It would be nice to also be able to use scan for this to use its other features. Unfortunately this doesn't work because of the way it looks for the scheme.
To reproduce this, you can create an SPM package, or you can use https://github.com/RevenueCat/purchases-ios as an example.
Command executed
xcodebuild(
  workspace: '.',
  scheme: 'RevenueCatUI',
  destination: "platform=iOS Simulator,name=" + (ENV['SCAN_DEVICE'] || "iPhone 14,OS=16.4"),
  sdk: 'iphonesimulator',
  test: true
)

Complete output when running fastlane, including the stack trace and command used

10:10:12]: ------------------------------
[10:10:12]: --- Step: default_platform ---
[10:10:12]: ------------------------------
[10:10:12]: Driving the lane 'ios test_revenuecatui' 🚀
[10:10:12]: -----------------------------
[10:10:12]: --- Step: setup_circle_ci ---
[10:10:12]: -----------------------------
[10:10:12]: Not running on CI, skipping CI setup
[10:10:12]: -----------------------------
[10:10:12]: --- Step: update_fastlane ---
[10:10:12]: -----------------------------
[10:10:12]: Looking for updates for fastlane...
[10:10:14]: Nothing to update ✅
[10:10:14]: ---------------------------------------
[10:10:14]: --- Step: app_store_connect_api_key ---
[10:10:14]: ---------------------------------------
[10:10:14]: ------------------
[10:10:14]: --- Step: scan ---
[10:10:14]: ------------------
[10:10:14]: Couldn't find specified scheme 'RevenueCatUI'. Please make sure that the scheme is shared, see https://developer.apple.com/library/content/documentation/IDEs/Conceptual/xcode_guide-continuous_integration/ConfigureBots.html#//apple_ref/doc/uid/TP40013292-CH9-SW3
[10:10:14]: Couldn't find any schemes in this project, make sure that the scheme is shared if you are using a workspace
[10:10:14]: Open Xcode, click on `Manage Schemes` and check the `Shared` box for the schemes you want to use
[10:10:14]: Afterwards make sure to commit the changes into version control
+------------------------------+-----------------------+
|                     Lane Context                     |
+------------------------------+-----------------------+
| DEFAULT_PLATFORM             | ios                   |
| PLATFORM_NAME                | ios                   |
| LANE_NAME                    | ios test_revenuecatui |
| SCAN_GENERATED_XCRESULT_PATH |                       |
+------------------------------+-----------------------+
[10:10:14]: No Schemes found
+------+---------------------------+-------------+
|                fastlane summary                |
+------+---------------------------+-------------+
| Step | Action                    | Time (in s) |
+------+---------------------------+-------------+
| 1    | default_platform          | 0           |
| 2    | setup_circle_ci           | 0           |
| 3    | update_fastlane           | 1           |
| 4    | app_store_connect_api_key | 0           |
| 💥   | scan                      | 0           |
+------+---------------------------+-------------+
[10:10:14]: fastlane finished with errors
[!]   I'm otherwise required to keep a separate project for tests of the Package, rather than keeping them in the package where they belong.


PIMOB-1359: Visa card should allow 19-digit length

Proposed changes
Jira task
Types of changes
What types of changes does your code introduce to Frames Ios?
Put an x in the boxes that apply

[X] Bugfix (non-breaking change which fixes an issue)

Checklist
Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

[X] Lint and unit tests pass locally with my changes
[X] I have added tests that prove my fix is effective or that my feature works
[ ] I have added necessary documentation (if appropriate)

Further comments
Small change to enable VISA cards to input up to 19 characters

@alex-ioja-yang-cko
Kind reminder, please change alex/ to bugfix/ or feature/ next time. we are following git flow

@alex-ioja-yang-cko  On merge please change commit to
Merge pull request #234 from checkout/bugfix/PIMOB-1359-i-os-checkout-i-os-card-validator-should-allow-visa-cards-of-19-digit-length


Make URL & clickable button optional

See #72 for details why.
This could be improved by actually adding links to the various browser vendors, but I think this is a good first step since it lets people customize things.

Thanks! Published in 2.9.0. Bonus points for not forgetting the README!


Sorry, what is the fix for this? What part of the app is suspicious?

Apologies - what I meant was that your site is on the Bluecoat filter list, probably because it's "new" to them, not because of any particular content.
It looks like it was updated and is now categorised correctly: "This page is currently categorized as For Kids and Games   Last Time Rated/Reviewed: November 26, 2015 06:36:27 GMT
This page has a risk level of Medium"


Add sudo to chmod installation step

I've tried to install ammonite on a few different machines using the instructions in the docs and often the chmod step gets rejected.

Looks good, thanks!!!


Sync: Bob

Resolves #805

For better readability in the online editor, you may optionally inline the object instantiation, apply the Arrange-Act-Assert pattern and keep lines shorter than about 60 characters like this:

Thanks for  you input, i'll look into it.

I don't know how the test runner would deal with it, but I would prefer personally to have a constant for each answer, to avoid risk of typos and minimize work.
const WHATEVER = "Whatever."
const SURE = "Sure."
const FINE = "Fine. Be that way!"
...

I don't know how the test runner would deal with it, but I would prefer personally to have a constant for each answer, to avoid risk of typos and minimize work.
const ANSWER_WHATEVER = "Whatever."
const ANSWER_SURE = "Sure."
const ANSWER_FINE = "Fine. Be that way!"
...

In the online editor feedback, you will never see the string such constant stands for. So, please, keep the string duplicated, even if it is against all rules of real production code.

No worries, I would expect at least some of the labels could be automated, based on lines changed e.g.  with the x:size labels.


Rhino does not fail when unable to load classes.

We have a test specifically designed to test that (RhinoLinkFailureTest.scala). However, it doesn't actually work (anymore?).
In a nutshell, it tries to call a method on an undefined object and asserts the call throws an exception, containing the name of this object in the error message. However, the error message comes from a TypeError originating from the module accessor. So Rhino actually let it pass and didn't throw.

We are fading out Rhino. Following up on the discussion in #2814, we won't fix this.


PART 3 - GET/Attestation Pool API - Add API interface

PR Description
Rebased on top of #8437
Add the new GetAttestationV2 /eth/v2/beacon/pool/attestations
Fixed Issue(s)

#8029
Documentation

[x] I thought about documentation and added the doc-change-required label to this PR if updates are required.

Changelog

[x] I thought about adding a changelog entry, and added one if I deemed necessary.

as discussed in call, the current commiteeIndex filter requires an update. We can leverage the committee filtering we already have for the aggregation flow, but requires to be updated to cover the phase0 because it has been design for electra only.

Done, made the filter applied differently based on the milestone. Pre electra we apply the filter to the index at the attestation data level and post Electra we rather apply it to the committee bits


[Request - Product] Corner Bowl Server Manager

Full and short name of product
Full: Corner Bowl Server Manager
Short: Corner Bowl
Description
Corner Bowl Server Manager helps organizations implement compliance controls and audit policies for CMMC, NIST, JSIG, CJIS, PCI/DSS, NERC CIP, ISO 27001 and GDPR, monitor network, server and application performance, implement real-time Intrusion Detection and Intrusion Prevention Systems with GEO IP support, and generate AI-driven anomaly detection reports, keeping IT infrastructure secure while providing organizations with invaluable user activity insight.
Does this product have LTS versions? What are the intervals between each LTS version?
At the moment there are no LTS versions, only an Active version, however our documentation will be updated shorty as we release our next major release and LTS will become available for the current release.
What is the website for the product and for its version information?
Product:
https://www.cornerbowlsoftware.com/Server-Manager
Current Versions:
https://www.cornerbowlsoftware.com/Download
Version and Support Policy
https://www.cornerbowlsoftware.com/documentation/Version-Support-Policy.htm
Additional context
Thank you for this website.

LTS seems to be documented now.

@captn3m0 I don't see it on https://endoflife.date/.  Is there somewhere else I can see the LTS documentation?

https://www.cornerbowlsoftware.com/documentation/Version-Support-Policy.htm says 23.x is LTS as per the table, and there is a definition for LTS above that.

@captn3m0 Yes that's my site.  I opened this up to get the information added to https://endoflife.date/

Oh, I missed that. Someone will have to work on a PR to get the product added to endoflife.date.
I was just mentioning that:

At the moment there are no LTS versions, only an Active version,

is no longer true, as LTS versions have been published now.


[Bug]: If the user name has a + sign, the forgot password link does not include the + sign in the email field

Is there an existing issue for this?

[X] I have searched the existing issues

Description
When I have a user as say<EMAIL_ADDRESS>and I click on forgot password link to reset the password, in the email field, the user name shows up as aparna<EMAIL_ADDRESS>Steps To Reproduce
https://github.com/appsmithorg/appsmith/assets/101863839/7dddeb1b-3a76-4247-99f6-75e44a59d1b4
Public Sample App
No response
Environment
Production
Issue video log
No response
Version
Cloud

Issue created on Jira-https://zemoso.atlassian.net/browse/TNOSB-398

HI @btsgh @deepika-appsmith
i am picking up this issue


QUIC error SSL

Hello,
I have an issue when running the ATS and trying to connect to the server using a browser, it get this error : ERR_SSL_PROTOCOL_ERROR.
In the debugs logs of the server attached, there seems to be a problem with the header.
When i run the traffic_quic client test, the connection seems to be working properly.
Would you have any idea  of what the problem may be ?
I run ATS 9.0.0 on Ubuntu 16.04.6.
Regards,
Nicolas
serv_debug.txt
client_debug.txt

I think current major browsers still have not supported IETF QUIC. Which browser and version did you use? According to your server side log, ATS didn't talk QUIC at all on the two sessions.

I have the same error 'ERR_SSL_PROTOCOL_ERROR' on :
Google Chrome ver  76.0.3809.132
Chromium ver 78.0.3897.0
Opera ver 63.0.3368.71
With Mozilla firefox ver 69.0 i have this error : SSL_ERROR_RX_RECORD_TOO_LONG

Like I said, I think those browsers (at minimum, the official releases) don't support IETF QUIC yet. We don't have plans for supporting gQUIC.
For a bit more detail about gQUIC and IETF QUIC, please refer these slides below:
http://mile-high.video/files/mhv2019/pdf/day1/1_11_Swett.pdf
Please reopen / recreate issues if you have problems with IETF QUIC clients.


Cannot create reader for system image.

Failed to install (D:\852\PS4UPDATE1.PUP.dec) to (D:\systemfolder): Cannot create reader for system image -> cannot read root directory -> unknown entry on #1 on cluster #5 (critical memory 1)
This error occurs when attempting to install decrypted firmware version 8.52

I forgot to remove the code that invokes an incomplete exFAT implementation. Will fix it tonight or you can fix it by removing these lines https://github.com/ultimaweapon/obliteration/blob/main/src/pup/src/lib.rs#L105-L109

https://github.com/ultimaweapon/obliteration/commit/a97789e6a99fe57a5c76dfa5091d1724abc36c10


Array

Description
Finding Minimum and Maximum in an Array
Domain
Data Structure
Type of Contribution
Documentation
Code of Conduct

[X] I follow Contributing Guidelines & Code of conduct of LearnCPP.

Please assign issue to me

\assign

\assign

/assign

/assign

/assign


v2: Allow overriding Alloy modules configmaps name prefix

fix for #994
Using .Values.global was the simplest way to pass fullnameOverride to both umbrella & child charts.
With:
clusterMetrics:
  enabled: true
  kepler:
    fullnameOverride: kepler
  opencost:
    fullnameOverride: opencost
podLogs:
  enabled: true
nodeLogs:
  enabled: true
clusterEvents:
  enabled: true

alloy-metrics:
  fullnameOverride: alloy-metrics
  enabled: true
alloy-logs:
  fullnameOverride: alloy-logs
  enabled: true
alloy-singleton:
  fullnameOverride: alloy-singleton
  enabled: true

configmap name will be like: very-long-release-name-alloy-module-kubernetes
adding:
global:
fullnameOverride: k8s-monitoring

will render configmap name as k8s-monitoring-alloy-module-kubernetes:
---
# Source: k8s-monitoring/charts/k8s-monitoring/templates/alloy-modules-configmaps.yaml
apiVersion: v1
kind: ConfigMap
metadata:
  name: k8s-monitoring-alloy-module-kubernetes
// ...REMOVED FOR CLARITY

including its reference in resulting configmap data:
---
# Source: k8s-monitoring/charts/k8s-monitoring/templates/alloy-config.yaml
apiVersion: v1
kind: ConfigMap
metadata:
  name: alloy-metrics
  namespace: monitoring
data:
  config.alloy: |-
    // Destination: prometheus (prometheus)
// ...REMOVED FOR CLARITY
    // Feature: Cluster Metrics
    declare "cluster_metrics" {
      argument "metrics_destinations" {
        comment = "Must be a list of metric destinations where collected metrics should be forwarded to"
      }

      remote.kubernetes.configmap "kubernetes" {
        name = "k8s-monitoring-alloy-module-kubernetes"
        namespace = "monitoring"
      }
// ...REMOVED FOR CLARITY

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


h2spec http2/8 tests should accept 400 Bad Request

(Thank you very much for h2spec!)
h2spec http2/8 tests should accept 400 Bad Request in addition to accepting RST_STREAM or GOAWAY.
My server responds with 400 Bad Request, and h2spec http2/8 tests fail with
             Expected: GOAWAY Frame (Error Code: PROTOCOL_ERROR)
                       RST_STREAM Frame (Error Code: PROTOCOL_ERROR)
                       Connection closed
               Actual: DATA Frame (length:0, flags:0x01, stream_id:1)

RFC 7540 Section <IP_ADDRESS>. Malformed Requests and Responses

Intermediaries that process HTTP requests or responses (i.e., any intermediary not acting as a tunnel) MUST NOT forward a malformed request or response. Malformed requests or responses that are detected MUST be treated as a stream error (Section 5.4.2) of type PROTOCOL_ERROR.
For malformed requests, a server MAY send an HTTP response prior to closing or resetting the stream.

While intermediates must send PROTOCOL_ERROR, origin servers may send a response, e.g. 400 Bad Request which tells the client "do not retry this request unmodified", instead of the generic HTTP/2 error PROTOCOL_ERROR which is less precise.
Please allow 400 Bad Request as a valid response.
(If you agree, please post so and I might learn some golang and submit a PR. :))

The following works for me to allow 400 Bad Request in VerifyStreamError() in lieu of an HTTP/2 stream error.  Feedback appreciated -- I am not fluent in golang.  If it looks good to you, please let me know and I will submit a PR.
--- a/spec/verifier.go
+++ b/spec/verifier.go
@@ -5,6 +5,7 @@ import (
        "reflect"

        "golang.org/x/net/http2"
+       "golang.org/x/net/http2/hpack"
 )

 const (
@@ -101,6 +106,15 @@ func VerifyStreamError(conn *Conn, codes ...http2.ErrCode) error {
                ev := conn.WaitEvent()

                switch event := ev.(type) {
+               case HeadersFrameEvent:
+                       decoder := hpack.NewDecoder(2048, nil)
+                       hf, _ := decoder.DecodeFull(event.HeadersFrame.HeaderBlockFragment())
+                       for _, h := range hf {
+                               if h.Name == ":status" && h.Value == "400" {
+                                       passed = true
+                                       break
+                               }
+                       }
                case ConnectionClosedEvent:
                        passed = true
                case GoAwayFrameEvent:

I think not sending a RST_STREAM/GOAWAY is incorrect, unfortunately.
Based on:

Malformed requests or responses that are detected MUST be treated as a stream error (Section 5.4.2) of type PROTOCOL_ERROR.

and

For malformed requests, a server MAY send an HTTP response prior to closing or resetting the stream.

and from § 5.4.2:

An endpoint that detects a stream error sends a RST_STREAM frame (Section 6.4) that contains the stream identifier of the stream where the error occurred. The RST_STREAM frame includes an error code that indicates the type of error.

This implies that:

FWIW, any response is acceptable, not just 400. Doesn't even have to be an error 4xx/5xx status.
However, the server must still treat it as malformed, which means sending a RST_STREAM is required, though the RFC doesn't place any limits on how soon you have to send it. (GOAWAY is ok too, since "... an endpoint MAY choose to treat a stream error as a connection error." )
If you look at the author's comment here, he's saying that the frame h2spec reports is the last one received, which means your server never sent a RST_STREAM or GOAWAY before it timed out, or the conn closed.

As I mentioned in https://github.com/summerwind/h2spec/issues/126#issuecomment-1729272126, I think the way h2spec reports the last seen frame is a little misleading sometimes.
It's not that the HEADERS/DATA frames are always invalid, it's that it never saw the frame it expected to.

@KingMob I think you cut the RFC quote short, skipping relevant information.

For malformed requests, a server MAY send an HTTP response prior to closing or resetting the stream.

is part of the paragraph which starts with "Intermediaries" and is instructions for intermediaries

Intermediaries that process HTTP requests or responses (i.e., any intermediary not acting as a tunnel) MUST NOT forward a malformed request or response. Malformed requests or responses that are detected MUST be treated as a stream error (Section 5.4.2) of type PROTOCOL_ERROR.

As I wrote in the original post:

While intermediates must send PROTOCOL_ERROR, origin servers may send a response, e.g. 400 Bad Request which tells the client "do not retry this request unmodified", instead of the generic HTTP/2 error PROTOCOL_ERROR which is less precise.

I considered that for a few minutes, because it's a little unclear. But there's a few reasons I think servers are required to do more than send a response.
First, the preceding sentence mentions intermediaries, but "Malformed requests or responses that are detected MUST be treated as a stream error (Section 5.4.2) of type PROTOCOL_ERROR" itself does not.
Second, the next sentence says "For malformed requests, a server MAY send an HTTP response prior to closing or resetting the stream", which implies that the server will in fact, be "closing or resetting the stream." It doesn't seem optional.
Finally, not sending a RST_STREAM (or GOAWAY) would conflict with the part of §5.4.2 I quoted above:

An endpoint that detects a stream error sends a RST_STREAM frame (Section 6.4) that contains the stream identifier of the stream where the error occurred.

Now this isn't perfectly clear, either. There's no MUST, but otherwise, it does say that an endpoint that detects a stream error will be sending a RST_STREAM (or a GOAWAY, since that's always allowed by §5.4.1)
Most of the language points to expectations that RST_STREAM/GOAWAY is expected, and a response is optional, but only if followed by a RST_STREAM/GOAWAY, so that's what I'm going with.
But you know, why argue, when we can ask the authors? I'll email them and see what they say.

Sure, please ask for clarification.  And thank you for referencing the newer RFC 9113.
https://www.rfc-editor.org/rfc/rfc9113.html#RST_STREAM

For malformed requests, a server MAY send an HTTP response prior to closing or resetting the stream.

That sentence was in RFC 7540, too.  Please note it says "... prior to closing or resetting the stream."  Sending an HTTP response and closing the stream does not result in RST_STREAM; resetting the stream would result in RST_STREAM.  Herein lies the difference.  As a web server developer, I would prefer to send 400 Bad Request and close the stream so that the client knows it received a complete HTTP response, rather than resetting the stream, in which case the client did not necessarily receive a complete HTTP response.  400 Bad Request is (slightly) more precise than RST_STREAM with the (more generic) PROTOCOL_ERROR.

The HTTP Working Group weighed in, and surprisingly (at least to me), there was no consensus.
Even the people who disagreed with Glenn's interpretation agreed it was defensible from the RFC as written, so I'm onboard with this issue, though I'll personally be going with the suggestion to follow a response with a RST_STREAM for Aleph.


onyo get --match siliently discards multiple invocations

I ran an onyo get command similar to the following:
onyo get --match type=laptop --match type=desktop

The result was that --match type=laptop was silently ignored and only --match type=desktop was used.
I expected that onyo get would error, and tell me that --match can only be used once.
This may affect other option flags as well.

Hm.
It's not that the flag can't be used multiple times. It can. You can have multiple match criteria and specify them by either multiple expressions after --match or distribute them across multiple --match options and I think that's fine. They should normally be treated as ANDed. The bug appears to be that multiple match criteria for the same key overwrite eachother instead of being combined by AND.
IOW: In my view the result of your query should not necessarily be an error but no result instead, as there is no asset that matches both criteria. And in the general case (regex) we can't easily tell that the given criteria are contradictory.
So, agree it's a bug, but not so much on the solution.

Now that I've used --match more, the behavior you described is definitely the right behavior.
+1


Updated UIFont to SwiftUI Font

Fix for the issue:
https://github.com/vinhnx/Clendar/issues/245
I have simply updated the Font initialisation for the only place where UIFont was being used.
This is my first ever open source contribution so do let me know if there's room for improvement.

hi @shadowfax90.
Thank you so much for contributing! Sorry, I haven't received notification so I missed your PR earlier.
It looks good 👍


Ctrl Space for autocomplete in insert mode?

How would I get ctrl space to trigger autocomplete?
I've tried:
lsp.on_attach(function(client, bufnr)
  local opts = { buffer = bufnr }
  local bind = vim.keymap.set

  bind('i', '<C-Space>', '<cmd>lua require("cmp").mapping.complete()<cr>', opts)
end)

But it didn't seem to work, and I'm still a noob with neovim in general so I'm not sure what else to try.
Thanks!

You'll want to change the keymaps of the autocomplete.
local lsp = require('lsp-zero').preset({
  name = 'minimal',
  set_lsp_keymaps = true,
  manage_nvim_cmp = true,
  suggest_lsp_servers = false,
})

local cmp = require('cmp')

lsp.setup_nvim_cmp({
  mapping = lsp.defaults.cmp_mappings({
    ['<C-Space>'] = cmp.mapping.complete(),
  })
})

lsp.setup()

Thanks a lot! Worked perfectly


fix ember-getowner-polyfill deprication

Fix for deprecation:
ember-getowner-polyfill is now a true polyfill. Use Ember.getOwner directly instead of importing from ember-getowner-polyfill [deprecation id: ember-getowner-polyfill.import]

Closed in favor of #118


Cookie bug: Multiple cookies are treated as 1 cookie

When sending a request with cookies, then multiple cookies are treated as 1 cookie.
For example, if i send a http request, then in my f12 dev tools, i can see the "Cookie" header that is sent out.
The value of the "Cookie" header is: "foo=bar; hello=world".
Then in my api endpoint, HttpRequestData.Cookies, there are only 1 HttpCookie in the collection.
The HttpCookie.Name is "foo" and the HttpCookie.Value is "bar,hello=world".
I use Azure Functions .NET 7 isolated.
Nuget packages:

Sorry! I could not repro what you have described. To repro what you mentioned, I created an http trigger which reads the cookies and prints out. I can see the correct cookie values were retrieved.
Here is a POSTMAN screenshot from my testing

The function code I used is below. FWIW, I used the latest stable version of the Microsoft.Azure.Functions.Worker nuget packages.
[Function("Function1")]
public HttpResponseData Run([HttpTrigger(AuthorizationLevel.Anonymous, "get", "post")] HttpRequestData req)
{
    var response = req.CreateResponse(HttpStatusCode.OK);
    response.Headers.Add("Content-Type", "text/plain; charset=utf-8");

    var cookieCount = req.Cookies.Count;
    var cookies = req.Cookies.Select(c => $"cookie name:{c.Name}   cookie value:{c.Value}");

    var cookieStr = new StringBuilder();
    cookieStr.AppendLine("");
    foreach ( var cookie in cookies )
    {
        cookieStr.AppendLine(cookie);
    }

    response.WriteString($"Total {cookieCount}{cookieStr}");

    return response;
}

If you are still running into issues, Can you post the raw request header you used?

Hi @kshyju  , this is very puzzling.
When i tested this cookie thing, i tested through the browser with the normal "fetch()" api, and that made it seperate the cookies with a comma, so it became just 1 cookie.
But now i just tried with Postman, and the cookies were seperated with a semicolon so they work with Postman, but not in a browser (i tested on edge, firefox, chrome)
I did some more digging, and i think it has something to do with the "custom domain self-signed certificate" that i use.
For example, i created my own certificate for "myapp.me" and then added "<IP_ADDRESS> myapp.me" in the "hosts" file.
Then i start my azure functions like this:
func start --port 9800 --useHttps --cert "C:\ca\myapp.me\cert.pfx" --password "hello123" --build
And then if i go to "https://myapp.me:9800" and make an api call, then the cookies were bugged with the commma seperation.
If i start my azure function with a regular "func start", so my url is "http://localhost:7071", and do the same thing, then the cookie seperation works.
So maybe it has something to do with using a certificate?
I also just tried to test with a regular .net 7 asp.net core web app, which worked.
In the program.cs, i added this builder.WebHost.ConfigureKrestrel() to add my certificate:
builder.Services.AddRazorPages();
builder.WebHost.ConfigureKestrel(serverOptions =>
{
	serverOptions.Listen(IPAddress.Loopback, 5001, listenOptions =>
	{
		listenOptions.UseHttps(@"C:\ca\myapp.me\cert.pfx", "hello123");
	});
});
var app = builder.Build();
...

And then i create an api endpoint "/api/test"
And then i call GET "https://myapp.me:5001/api/test"
And then the cookies were seperated and works like expected.
So it works in Asp.net core with my own certificate through the browser, but not in Azure Functions through the browser.
So in summary:
Cookie seperation bugs when:

I use my own certificate and make api request through browser, eg: GET https://myapp.me:9800/api/test

Cookie seperation works when:

I use my own certificate and make api request through Postman, eg: GET https://myapp.me:9800/api/test
I use the regular localhost "func start", and make api request through browser eg: GET http://localhost:7071/api/test

Note, i also tested on the latest nuget packages "Microsoft.Azure.Functions.Worker, version 1.19.0", and "Microsoft.Azure.Functions.Worker.Extensions.Http, version 3.1.0"

Can you capture a fiddler trace when it fails from the fetch request and inspect that request for the headers? Do they look correct you?

I also faced this problem.
The initial conditions are almost the same:

"Microsoft.Azure.Functions.Worker, version 1.19.0", and "Microsoft.Azure.Functions.Worker.Extensions.Http, version 3.1.0"
created my own certificate for "myapp.me"
added "<IP_ADDRESS> myapp.me" in the "hosts" file
started my azure functions like func start --port 9800 --useHttps --cert "C:\ca\myapp.me\cert.pfx" --password "hello123"

and when I'm making request through browser, azure function receives cookies that separated by coma, even though I can see in the developer tools in Request Headers section, that the sent cookies are separated by a semicolon.
If I copy this request as CURL and make it through Postman, then azure function receives cookies that separated by semicolon, as I sent it.
I tried to catch the traffic in the fiddler to find the source of the problem. But unfortunately, when traffic capture is enabled in the fiddler, the problem does not reproduce - even from the browser, cookies begin to arrive in the correct form (semicolon separated).
I came across an issue with a similar problem, where fiddler had the same effect - https://github.com/microsoft/reverse-proxy/issues/437


Add bitmap layer example

Background
v7.0 audit
Change List

add embeded example for BitmapLayer
update layer-browser

Coverage remained the same at 61.849% when pulling dd1a8264e80720f0036fdde758b42a0d72da5fb6 on xx/bitmap-example into 20df8c6cf4ad747c1ef8f66573c040aabd3b6775 on master.

Coverage remained the same at 61.849% when pulling dd1a8264e80720f0036fdde758b42a0d72da5fb6 on xx/bitmap-example into 20df8c6cf4ad747c1ef8f66573c040aabd3b6775 on master.


Issue/434 missing buffer logs

fixes #434
I believe this issue stems from one of the pact crates having a different version of the tracing crate used for logging.
This seems like an awkward position to be in, when upgrading dependencies of each of the indiv pact rust crates, especially as two sit across different repos (pact_mock_server / pact-plugin-driver).
Would it make sense to crate a pact_logging crate that wraps the required deps for logging, and this singular crate can be imported by all the other pact rust crates.
If we need to update the logging deps, we update them in the pact_logging crate, and then can use the workspace override to patch all crates to use the same versions (via pact_logging)

I'm wondering if we use the patch block to force the logging crate version, this will fix this issue. It does mean we need some way of working out when to update it. But the logging crates have been quite stable.

I'm going to close this PR, as it can't be merged in the current state. I'll then cherry pick the changes from your branch.

This was not caused by the logging crates, but by the FFI InMemory sink which uses the global static LOG_BUFFER in the pact_matching crate. This is required to be the same version across all crates (i.e. mock server crate).

ahhh great, good detective work @rholshausen


Feat: Add Support for Linux Users and Custom Install Script

Support Linux non-root user -- fixes #594
Add customization instructions to README
Allow mapping of volumes in installation script

Hi @drmikecrowe, thanks for your first contribution!
Next time, please make use of PULL_REQUEST_TEMPLATE, i.e. preserving the what and why sections.
In terms of requesting changes or approval, I'm going to defer this to @Nuru

Next time, please make use of PULL_REQUEST_TEMPLATE, i.e. preserving the what and why sections.
Let me resubmit, and pull apart the customization vs. fixing #594


Schema $refs are not pointing correctly

Hi there,
Thank you for taking the time to put this library together! I just came across an issue when opening the swagger UI - I see errors like so:
Could not resolve reference: #/properties/data/properties/id

From looking through the source, it looks like the zod-to-json-schema refStrategy (root is the default) is not mapping correctly. Maybe because the entire object is not being passed into the function?

Hi @bpred754, thanks for opening an issue! Could you share a code sample that will generate one of these invalid schemas - I can't seem to reproduce this.

Reproduction here: https://github.com/modtree/modtree/pull/358#issuecomment-1195478283

Hi @weiseng18. Can you confirm this is fixed in the new<EMAIL_ADDRESS>release?

@jlalmes Hello! Just stumbled over this old issue and this
Just FYI the basePath option was made for this type of scenario. for the modtree example you could use this
zodToJsonSchema(zodSchema, {
  target: 'openApi3',
  basePath: ["paths", "post", "responses", "200", "content", "application\\/json", "schema"]
})

Of course the basepath should be dynamically generated but yeah


move assignment for server.delegate

I want to replace app.server.delegate before app.start(), but app.server.delegate is set app itself in app.start().
If I could move the assignment from start to initializer, I can replace app.server.delegate with my custom delegate instance and continue using SocketServer.

I'm not sure this is going to work as Providers can change the server instance between Application being created and start() being called, which is why setting the delegate is delayed until start().
What's the use case for this that wouldn't be achievable using Middleware?

If you change the Server's delegate you remove all of Vapor's functionality.

@shnhrrsn I think originally its set there so if middleware changes the server, they don't have to remember to also set the delegate.

Hi, guys.
Sorry to throw weird pull request.
I'm very new to Vapor so I'm going to read codes more to understand Vapor's thought.

No worries. Feel free to join our slack channel if you have any questions. (Badge is on the README)


Limit nix features

This slightly speeds up the build, as it compiles less of the crate.

I'll take it! Thank you :heart:


HacktoberFest20

Name the program which you are adding
Josephus Problem for recursion
Programming Language you will code
C++
YOU ARE
a student
GITHUB USERNAME
riyavaryani

Thanks for choosing our repository for contributing to Hacktober Fest 20
As a part of the new process this Issue is marked as hacktoberfest-expiry & closed
Please check our new updated contribution guidelines here


Feat: Add support of multiple datasets in config

Context
What is the purpose of this PR? Is it to

[x] add a new feature
[ ] fix a bug
[x] update tests and/or documentation
[ ] other (please add here)

Please link to any issues this PR addresses.
Changelog
I've added ability to use multiple sources of instruct or chat datasets, after merge of this PR users of torchtune will be able to pass a dataset's name string or list of strings.
dataset:
  _component_: torchtune.datasets.instruct_dataset
  source:
    - tatsu-lab/alpaca
    - vicgalle/alpaca-gpt4
  template: AlpacaInstructTemplate
  split: train
  train_on_input: True

dataset:
  _component_: torchtune.datasets.chat_dataset
  source:
    - Open-Orca/SlimOrca-Dedup
    - ajibawa-2023/Code-290k-ShareGPT
  conversation_style: sharegpt
  chat_format: Llama2ChatFormat
  max_seq_len: 1024
  split: train

The only one problem is: dataset must have simmilar formats.
Test plan
Please make sure to do each of the following if applicable to your PR. (If you're not sure about any one of these just ask and we will happily help.)

[x] run pre-commit hooks and linters (make sure you've first installed via pre-commit install)
[x] add unit tests for any new functionality
[x] update docstrings for any new or updated methods or classes
[x] run unit tests via pytest tests
[x] run recipe tests via pytest tests -m integration_test
[ ] manually run any new or modified recipes with sufficient proof of correctness

[ ] include relevant commands and any other artifacts in this summary (pastes of loss curves, eval results, etc.)

Hi! I've signed CLA, how to rerun failed check?

Thanks for this awesome PR @EvilFreelancer! Handling multiple datasets has been a north star for us, as most mature data pipelines for fine-tuning models typically incorporate multiple data sources, so I appreciate you adding this.

The only one problem is: dataset must have simmilar formats.

This is my main concern - the concatenated datasets must have the same columns AND the same instruct template / chat format. Also, all the keyword arguments will need to be shared (max_seq_len, train_on_input). This is quite restrictive and will require users to do a lot of offline preprocessing work. Ideally, using multiple datasets should be flexible enough that each dataset can have different columns and different template yet we're able to coalesce these together. In the end, all the data gets tokenized as Messages, so I do think this is possible.
What are your thoughts on letting InstructDataset and ChatDataset handle single data sources only, and creating some container class that can hold multiple InstructDatasets or ChatDatasets? Since the dataset classes return the token IDs ready to be used by the model, the container class can focus on handling the logic of sampling from the list of datasets.
class MultiDataset(torch.utils.data.Dataset):
    def __init__(self, datasets: List[Dataset]):
        self.datasets = datasets

    def __getitem__(self, index: int) -> Tuple[List[int], List[int]]:
        # Figure out how to sample/interleave multiple datasets here

Then, in the config, you could specify multiple datasets like this (or something similar):
dataset:
  - _component_: torchtune.datasets.instruct_dataset
    source: tatsu-lab/alpaca
    ...
  - _component_: torchtune.datasets.instruct_dataset
    source: vicgalle/alpaca-gpt4
    ...

And the recipe can instantiate a MultiDataset if the dataset param is a list. This way, each dataset can keep their individual parameters.
Ideally, we can make use of concatenate_datasets and interleave_datasets from HF but since we have preprocessing logic in our dataset classes that are specific to each data source, we might have to create similar logic ourselves.

Hi @RdoubleA, thank you for your response!
Hm, the MultiDataset class and the possibility to pass an array of datasets through the dataset parameter - it's a great idea, and it's much simpler for end-users to understand how to use this feature than dealing with datasets in similar formats.
I have a couple of spare days, so I may start working on implementing this solution, as it is critical for the project I am working on to have the ability to train on various combinations of datasets.

Hi! I've implemented logic of MultiDataset and enabled it in traning recipes.
I've also removed original multi-source logic and cleaned tests.
How to use:
dataset:
  - _component_: torchtune.datasets.instruct_dataset
    source: tatsu-lab/alpaca
    template: AlpacaInstructTemplate
    split: train
    train_on_input: True
  - _component_: torchtune.datasets.instruct_dataset
    source: vicgalle/alpaca-gpt4
    template: AlpacaInstructTemplate
    split: train
    train_on_input: True
  - _component_: torchtune.datasets.chat_dataset
    source: Open-Orca/SlimOrca-Dedup
    conversation_style: sharegpt
    chat_format: Llama2ChatFormat
    max_seq_len: 1024
    split: train
  - _component_: torchtune.datasets.chat_dataset
    source: ajibawa-2023/Code-290k-ShareGPT
    conversation_style: sharegpt
    chat_format: Llama2ChatFormat
    max_seq_len: 1024
    split: train
seed: null
shuffle: True

By the way, this gave an interesting side effect: using this logic, you can freely mix datasets of any format.
In the example that I gave, dataset formats instrcut and chat are mixed, it seems to me that this will be a very interesting and convenient feature of TorchTune.

@RdoubleA hi! Thanks for your review, requested fixes added.
By the way I've noticed one small thing, for example in vicgalle/alpaca-gpt4 dataset have 52k rows, why TorchTune shows me 26k items on training stage? Maybe it's because train/val splits?

@RdoubleA hi! I've added fixes you mentioned, and couple simple test on MultiDataset class.
What do you think about:
if not isinstance(cfg_dataset, ListConfig):
    cfg_dataset = [cfg_dataset]
datasets = [config.instantiate(cfg_item, tokenizer=self._tokenizer) for cfg_item in cfg_dataset]
ds = utils.MultiDataset(datasets=datasets)

instead of:
if isinstance(cfg_dataset, ListConfig):
    datasets = [
        config.instantiate(single_cfg_dataset, tokenzier=self._tokenizer)
        for single_cfg_dataset in cfg_dataset
    ]
    ds = utils.MultiDataset(datasets=datasets)
else:
    ds = config.instantiate(cfg_dataset, tokenizer=self._tokenizer)

@EvilFreelancer Thanks for the updates! I'll take another pass soon.
In the meantime, since this is a significant feature we are adding, I'd like to make sure this is rigorously tested. Do you mind confirming the following:

The unit test for multidataset passes (please add the test command to the PR summary)
Run one of the distributed recipes and confirm that loss curves and tokens/sec look reasonable (you can use WandBLogger for easy visualization). Main thing I want to confirm here is that we can still sample from multiple datasets correctly in a distributed environment
Run one of the single device recipes for a similar reason above

Also, I forgot to mention this earlier, but I think a better location for MultiDataset would be in torchtune/datasets instead of torchtune/utils, what do you think?

@joecummings hi!

Can you update the README with examples on how this will now look in the YAML config?

I've added small section to dataset page in tutorial.

The tests for Multi GPU Gemma 2B training are available here.

@EvilFreelancer Thanks for sharing the test runs! Sorry for the delay in following up on this. An update from our side is that we've been having a lot of discussions around iterable datasets, which is something that we want to support more and design around moving forward. This would enable more flexibility around interleaving, weighted sampling, etc. for multiple datasets that won't fit in memory.
That being said, I still think the MultiDataset here is valuable for datasets that fit in memory and can still leverage map-style functionality. This will unblock users that want to quickly concatenate multiple data sources until we add iterable datasets and a more powerful MultiDataset. So to accurately reflect the scope of this class, my suggestion is to rename this to ConcatDataset (you might've started with this name to begin with, I apologize) and make it clear in the docstrings that this is for map datasets that all fit in memory.
Let me know if this makes sense!

 Sorry about that! I think you just need to add back a newline before the codeblock statement.

@ebsmothers typo fixed

Thank you for the meticulous code-review and excellent advice, I thoroughly enjoyed working on this project with all of you!


Change the structure of the rm_calendar_memo project to include multiple formats of the PDF calendars (2 currently).

There should directory named layout1_singlepage , which would contain the specific rm_calendar-specific files, which would be related to the colorful_topcalendar as well as , so-called, "format 1" type of the PDF calendar.
There should directory named layout1_fourpages , which would contain the specific rm_calendar-specific files, which would be related to the grayscaled_topcalendar as well as , so-called, "format 2" type of the PDF calendar.

[bash]$ tree -L 2
.
├── LICENSE
├── README.md
├── layout1_singlepage
│   ├── calendars
│   ├── get_metadata.js
│   ├── node_modules
│   ├── open_composite_png.js
│   ├── open_resize_png.js
│   ├── package-lock.json
│   ├── package.json
│   ├── periodically_update_suspended_png.sh
│   ├── rm_calendar
│   ├── rm_calendar_memo.log
│   └── rm_calendar_memo.service
└── layout2_fourpages
    └── placeholder


Implement C struct generation

Previous RgGen can also generate C struct like below.
https://github.com/taichi-ishitani/rggen/blob/411fff9f6618ffdbdc59bcb45a2d6bf39a7e40d5/sample/sample_0.h#L4
Add this feature to c header pluign.

Current RgGen allows write-only and read only registers to be assigned to the same address.
union can be used for this case.
typedef union {
  uint32_t  wo_reg;
  uint32_t  ro_reg;
} block_0_reg_0x0000;

typedef struct {
  block_0_reg_0x0000  reg_0x0000;
  uint32_t            rw_reg;
} block_0;

registers which are partially shared are allowed for now. For example:

register_0

write only
offset: 0x00
size: 8 bytes

register_1

read only
offset: 0x04
size: 8 bytes

For this case, union technique cannot be used.
To support union technique, this pattern should be prohibited.
That is, registers which have the same size and address can only be allowed.


Fix ci script and add operator image environment created by openshift ci

Signed-off-by: Flavius Lacatusu<EMAIL_ADDRESS>What does this PR do?
Avoid to hardcoded in CI scripts the openshift CI image registry. I've added a new environment which get the operator image value from internal openshift registry and will use in tests
PR with openshift CI jobs tested: https://github.com/openshift/release/pull/12116
What issues does this PR fix or reference?
Is it tested? How?

@JPinkney @sleshchenko Provided fix here: https://github.com/openshift/release/pull/12128
Apologize for my mistakes :(

/test v5-devworkspaces-operator-e2e


Minified (production) version of this library modifies global app settings

https://github.com/arusahni/ngtweet/blob/master/src/prod.config.js
This is somehow unexpected and I don't think should happen in public library.
I've got an issue with https://github.com/angular-ui-tree/angular-ui-tree library which relies on angular.element(node).scope() for it's drag-n-drop functionality, which itself becomes unavailable if you do $compileProvider.debugInfoEnabled(false);
Took me a bit of time to investigate.
There are easy workarounds: use non-minified version (minify it by yourself), or reenable this feature in app config, but again, I would not expect such global influence on the app from one of many libs.

Thanks for the report! I agree that a library shouldn't modify global state.  Will address in a future bugfix release.

@Yurko-Fedoriv Can you check out the production version that's currently on develop? I've got a hack in place that I want to verify addresses your issue.

@arusahni  Yep, that's it. I would suggest you use this https://www.npmjs.com/package/gulp-strip-ng-log instead of commenting out all $log.* calls, should be a cleaner way.

@Yurko-Fedoriv Thanks for the link! I was planning on creating a module-level wrapper for the log provider, but that looks a lot better. Is there anything Gulp can't do? :smile:

I this there is no such thing :-)

@Yurko-Fedoriv I'll have a release out in the next day or so. Will ping you on this thread when it's out.

Should be fixed in v0.3.1. Thanks for the report!

nice, thanks. I'll check it out


During Windows startup the words "Start Typing" appear briefly. This also happens during updates to Windows.  It looks like the Alt+Keyboard was pressed except that there are only the words that flash on screen briefly.

Environment
Windows build number: [run "ver" at a command prompt]
PowerToys version:
PowerToy module for which you are reporting the bug (if applicable):

Steps to reproduce

Expected behavior

Actual behavior

Screenshots

Or maybe it's the window display status.

@Starzuft thanks for the feedback. We are aware of this issue and it's being tracked in #2974. Closing this as a duplicate.


feat(tutorial): complete step 2 - RTP

Completes react-step-2

Is row 1 of my Landing Page supposed to be this tall?  I cannot spot any coding discrepancy that would cause it to be taller than the sample in the tutorial instructions.

👍 Looks good - 🎉 You are one step closer to completion of the Carbon React tutorial and earning the digital credential.


Update wiki and organize better

Create a flow diagram of how henchman operates. And explain what each part does.
E.G main -> preprocess plans -> plan.setup -> plan.execute


Update test.sh to cover standard and airbnb style guide

would it be worth iterating for both style guides?
yes "" | ./node_modules/.bin/vue init . test

Yes definitely. It should test every combination if possible


Raid spawned Entities not giving any reward

*Detailed description of the issue:
It seems like all the raid-spawned mobs not giving points neither money or exp. When I spawn them using spawn egg or kill for example the pillager at an outpost, only then I will get any reward out of them.
CONFIG SECTION:
Jobs/hunter.yml
    VINDICATOR:
      income: 20.0
      points: 20
      experience: 30.0
    VEX:
      income: 60.0
      points: 20
      experience: 60.0
    PILLAGER:
      income: 20.0
      points: 30
      experience: 30.0
    WITCH:
      income: 40.0
      points: 40
      experience: 50.0
    EVOKER:
      income: 50.0
      points: 40
      experience: 60.0

Jobs version:
<IP_ADDRESS>
Server Type (Spigot/Paper/etc):
Paper
Server Version (using /ver):
1.20.4 (Paper 478)

There isn't any internal distinction between regular mobs and the ones spawned for the raid. Potential issue could be with 3rd party plugin compatibility, but as of testing payments are being given out during raids from pillagers or other mobs.


MQTT - For clean sessions, close and unsubscribe any subscriptions on disconnect

Partially fixes #1499

Superseded by PR https://github.com/EnMasseProject/enmasse/pull/1514