YARN-9009: Fix flaky test TestEntityGroupFSTimelineStore.testCleanLogs

In TestEntityGroupFSTimelineStore, testCleanLogs fails when run after testMoveToDone.
testCleanLogs fails because testMoveToDone moves a file into the same directory that testCleanLogs cleans, causing testCleanLogs to clean 3 files, instead of 2 as testCleanLogs expects.
To fix the failure of testCleanLogs, we can delete the file after the file is moved by testMoveToDone.
Link to issue: YARN-9009

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
0
Docker mode activated.

-1
patch
11
https://github.com/apache/hadoop/pull/438 does not apply to trunk. Rebase required? Wrong Branch? See https://wiki.apache.org/hadoop/HowToContribute for help.

Subsystem
Report/Notes

GITHUB PR
https://github.com/apache/hadoop/pull/438

JIRA Issue
YARN-9009

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-438/1/console

versions
git=2.7.4

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
0
Docker mode activated.

-1
patch
14
https://github.com/apache/hadoop/pull/438 does not apply to trunk. Rebase required? Wrong Branch? See https://wiki.apache.org/hadoop/HowToContribute for help.

Subsystem
Report/Notes

GITHUB PR
https://github.com/apache/hadoop/pull/438

JIRA Issue
YARN-9009

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-438/2/console

versions
git=2.7.4

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
0
Docker mode activated.

-1
patch
9
https://github.com/apache/hadoop/pull/438 does not apply to trunk. Rebase required? Wrong Branch? See https://wiki.apache.org/hadoop/HowToContribute for help.

Subsystem
Report/Notes

GITHUB PR
https://github.com/apache/hadoop/pull/438

JIRA Issue
YARN-9009

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-438/3/console

versions
git=2.17.1

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
0
Docker mode activated.

-1
patch
12
https://github.com/apache/hadoop/pull/438 does not apply to trunk. Rebase required? Wrong Branch? See https://wiki.apache.org/hadoop/HowToContribute for help.

Subsystem
Report/Notes

GITHUB PR
https://github.com/apache/hadoop/pull/438

JIRA Issue
YARN-9009

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-438/4/console

versions
git=2.7.4

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
0
Docker mode activated.

-1
patch
12
https://github.com/apache/hadoop/pull/438 does not apply to trunk. Rebase required? Wrong Branch? See https://wiki.apache.org/hadoop/HowToContribute for help.

Subsystem
Report/Notes

GITHUB PR
https://github.com/apache/hadoop/pull/438

JIRA Issue
YARN-9009

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-438/5/console

versions
git=2.7.4

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
0
Docker mode activated.

-1
patch
10
https://github.com/apache/hadoop/pull/438 does not apply to trunk. Rebase required? Wrong Branch? See https://wiki.apache.org/hadoop/HowToContribute for help.

Subsystem
Report/Notes

GITHUB PR
https://github.com/apache/hadoop/pull/438

JIRA Issue
YARN-9009

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-438/6/console

versions
git=2.17.1

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
0
Docker mode activated.

-1
patch
13
https://github.com/apache/hadoop/pull/438 does not apply to trunk. Rebase required? Wrong Branch? See https://wiki.apache.org/hadoop/HowToContribute for help.

Subsystem
Report/Notes

GITHUB PR
https://github.com/apache/hadoop/pull/438

JIRA Issue
YARN-9009

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-438/7/console

versions
git=2.7.4

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
0
Docker mode activated.

-1
patch
10
https://github.com/apache/hadoop/pull/438 does not apply to trunk. Rebase required? Wrong Branch? See https://wiki.apache.org/hadoop/HowToContribute for help.

Subsystem
Report/Notes

GITHUB PR
https://github.com/apache/hadoop/pull/438

JIRA Issue
YARN-9009

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-438/8/console

versions
git=2.17.1

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
0
Docker mode activated.

-1
patch
10
https://github.com/apache/hadoop/pull/438 does not apply to trunk. Rebase required? Wrong Branch? See https://wiki.apache.org/hadoop/HowToContribute for help.

Subsystem
Report/Notes

GITHUB PR
https://github.com/apache/hadoop/pull/438

JIRA Issue
YARN-9009

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-438/9/console

versions
git=2.17.1

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m  0s
Docker mode activated.

-1 :x:
patch
0m  4s
https://github.com/apache/hadoop/pull/438 does not apply to trunk. Rebase required? Wrong Branch? See https://wiki.apache.org/hadoop/HowToContribute for help.

Subsystem
Report/Notes

GITHUB PR
https://github.com/apache/hadoop/pull/438

JIRA Issue
YARN-9009

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-438/3/console

versions
git=2.17.1

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m  0s
Docker mode activated.

-1 :x:
patch
0m  5s
https://github.com/apache/hadoop/pull/438 does not apply to trunk. Rebase required? Wrong Branch? See https://wiki.apache.org/hadoop/HowToContribute for help.

Subsystem
Report/Notes

GITHUB PR
https://github.com/apache/hadoop/pull/438

JIRA Issue
YARN-9009

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-438/4/console

versions
git=2.17.1

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m  0s

Docker mode activated.

-1 :x:
patch
0m 20s

https://github.com/apache/hadoop/pull/438 does not apply to trunk. Rebase required? Wrong Branch? See https://cwiki.apache.org/confluence/display/HADOOP/How+To+Contribute for help.

Subsystem
Report/Notes

GITHUB PR
https://github.com/apache/hadoop/pull/438

JIRA Issue
YARN-9009

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-438/1/console

versions
git=2.17.1

Powered by
Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.


add a recommend feature

Recommend relevant tracks/artists/albums depending on what's currently playing. Output and interaction could work like the search functionality.

I'll take this one! Cool project idea 👍

Thanks for your contribution! I'll take a look into it this weekend.

Thanks again @PFwrench , just merged in your PR. I am about to publish the new version to npm shortly.


Easier to access RetroLab tree

Add Help > Launch RetroLab Tree to the menu
Redirect from /retro or /retro/ to /retro/tree
Closes #134

Released in https://pypi.org/project/retrolab/0.3.0a2/

@meeseeksdev please backport to 0.2.x


rpc: the arguments for api method are incorrect

Is there an existing issue?

[X] I have searched the existing issues

Experiencing problems? Have you tried our Stack Exchange first?

[X] This is not a support question.

Description of bug
I want to add rpc function in my substrate blockchain to supply restful apis for others.But some mistake occur when the project is built.The errors show like this:
45  |         api.get_value(&at,v).map_err(runtime_error_into_rpc_err)
|             --------- ^^^ expected associated type, found &BlockId<_>
|             |
|             arguments to this method are incorrect

Steps to reproduce
1、add rpc configuration to the prject correctly
2、build the project
3、errors like this:
45  |         api.get_value(&at,v).map_err(runtime_error_into_rpc_err)
|             --------- ^^^ expected associated type, found &BlockId<_>
|             |
|             arguments to this method are incorrect

Did you follow some tutorial or how did you add it to the template?
Where did you get the code from?

Did you follow some tutorial or how did you add it to the template? Where did you get the code from?

yeah,I followed  some tutorials to add it to my template,sunch as  https://substrate.stackexchange.com/questions/5554/how-to-add-custom-rpcs  and  https://github.com/AlexD10S/susbtrate-node-template/blob/rpc-custom-methods/pallets/template/rpc/src/lib.rs#L9  and others. I compared the codes among them and found that they did the same thing.But ,when I added the codes in my project, errors occured like that when it is built.So,maybe,I think  wether  the newest codes causing the problem,I am not sure.

@AlexD10S do you know if the tutorial maybe needs an update?

@AlexD10S do you know if the tutorial maybe needs an update?
yeah,I know.I download the newest version of substrate-node-template and add the rpc configuration to it following the tutorial,changing the version to the newest in the file Cargo.toml of  rpc.The version is v1.0.0.(branch = "polkadot-v1.0.0")

@AlexD10S do you know if the tutorial maybe needs an update?

I have found the answer.Thanks.

I am going to take a look, probably it needs an update. The tutorial was done with polkadot-v0.9.28.
@Snikko If you have found an answer, can you share your solution here or in the StackExchange question with a new answer or editing mine. The community will benefit if you share your solution there.

I am going to take a look, probably it needs an update. The tutorial was done with polkadot-v0.9.28.
@Snikko If you have found an answer, can you share your solution here or in the StackExchange question with a new answer or editing mine. The community will benefit if you share your solution there.

In recent versions,we have to change some codes in the file pallets/template/src/rpc/src/lib.rs,as follows:
impl<C, Block> TemplateApiServer<::Hash> for TemplatePallet<C, Block>
where
Block: BlockT,
C: Send + Sync + 'static + ProvideRuntimeApi + HeaderBackend,
C::Api: TemplateRuntimeApi,
{
fn get_value(&self, at: Option<::Hash>) -> RpcResult
{
    let api = self.client.runtime_api();
    let at = at.unwrap_or_else(||self.client.info().best_hash);

    api.get_value(at).map_err(runtime_error_into_rpc_err)
}

}


add types to ambiguous parameters to help overload resolution

While working through #3550 I had a devil of a time building with more recent Mono versions than are used in the CI pipeline. This PR fixes the type-based mono failures which have arisen due to mono incorporating span overloads for certain members.

can you please send a PR that activates this mono version in CI?


Move BrowserKit to dev requirements?

I would propose a PR myself, but I want to be sure: is there any reason to keep "symfony/browser-kit" in "require" section of composer.json (instead of "require-dev")?
It looks like this application is never using anything in the Symfony\Component\BrowserKit namespace, so the only use I can see is for tests.

:+1:

Nice catch. This definitely looks like a mistake. Thanks!

Fixed by #650


Appropriate way to ensure Grid shows up below Header

When using a Header, followed by a Grid as in the following, the content of the Grid may hid underneath the Header, what's the appropriate way to deal with this?

....

Hi @arcfide , the Header component has a fixed position, which can obscure content directly below it.
Try increasing the margin-top value for bx--grid:

<svelte:head>
  <link
    rel="stylesheet"
<EMAIL_ADDRESS>  />
</svelte:head>

....

Due to some SASS stuff that I have, I was unable to do this exactly, but I was able to use the principle to work around the issue. Thanks.


[ Fabric ] Update couchdb image for HLF 2.2.0

Signed-off-by: abevers<EMAIL_ADDRESS>Changelog

Update peer CouchDB image for HLF 2.2.0 from hyperledger/fabric-couchdb:0.4.18 to couchdb:3.1

To be reviewed by
@jagpreetsinghsasan @lakshyakumar
Linked issue
Resolves #1088

Create this on develop branch; feature/fabric220 is merged with develop now

Will do. @jagpreetsinghsasan indeed it was only an image change, logs of CouchDB looked fine + adding of organization worked.


Update migration for 1.2.0

Pull Request Test Coverage Report for Build 3208

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals

Change from base Build 3196:
0.0%

Covered Lines:
700

Relevant Lines:
700

💛  - Coveralls


Update/packagecloud provider

A bit of reworking to switch to using the packagecloud repo for varnish packages
also updates the varnish version matching regexs to handle version 5.0/5.1 of varnish

@MWilkinson thanks for this - are you able to rebase against master please?

@bashtoni That should have done it

Thanks @MWilkinson 👍

Thank you @MWilkinson for the patch. However the packagecloud puppet module lacks support of modern operating systems like CentOS 7 or Ubuntu 16/17. I believe it would be better to only change the repositories without using the packagecloud puppet module which isn't being maintained very active.


Viewport ARVR + ARVR camera crash Issue under GLES3, not GLES2

Godot version
3.4 official (v3.4.stable.official.206ba70f4)
System information
Windows 11 x64, GLES3, Intel Core i7-8750H, Intel UHD Graphic 630, Nvidia GeForce GTX 1050Ti, Nvidia GameReady 496.49
Issue description
Describe
Crash when attempted to open a Viewport tscn that configured for ARVR & has an ARVR camera. It only happens with GLES3. Doing the same with GLES2 won't cause any trouble.
Terminal log
Hexagon Engine
Quick open scene ZetrixViewport.tscn
...
ERROR: Condition "ret == 0" is true. Returned: ERR_CANT_FORK
   at: execute (platform/windows/os_windows.cpp:2843)
thirdparty/mbedtls/library/ssl_tls.c:5084: mbedtls_ssl_fetch_input() returned -27648 (-0x6c00)
thirdparty/mbedtls/library/ssl_tls.c:4455: ssl_get_next_record() returned -27648 (-0x6c00)
thirdparty/mbedtls/library/ssl_cli.c:1691: mbedtls_ssl_read_record() returned -27648 (-0x6c00)
ERROR: TLS handshake error: -27648
   at: _do_handshake (modules/mbedtls/stream_peer_mbedtls.cpp:87)
mbedtls error: returned -0x6c00

ERROR: GL ERROR: Source: OpenGL Type: Error     ID: 1282        Severity: High  Message: GL_INVALID_OPERATION error generated.
   at: _gl_debug_print (drivers/gles3/rasterizer_gles3.cpp:124)
ERROR: GL ERROR: Source: OpenGL Type: Error     ID: 1282        Severity: High  Message: GL_INVALID_OPERATION error generated.
   at: _gl_debug_print (drivers/gles3/rasterizer_gles3.cpp:124)
ERROR: GL ERROR: Source: OpenGL Type: Error     ID: 1282        Severity: High  Message: GL_INVALID_OPERATION error generated. The required buffer is missing.
   at: _gl_debug_print (drivers/gles3/rasterizer_gles3.cpp:124)
ERROR: GL ERROR: Source: OpenGL Type: Error     ID: 1282        Severity: High  Message: GL_INVALID_OPERATION error generated. The required buffer is missing.
   at: _gl_debug_print (drivers/gles3/rasterizer_gles3.cpp:124)
ERROR: GL ERROR: Source: OpenGL Type: Error     ID: 1282        Severity: High  Message: GL_INVALID_OPERATION error generated. The required buffer is missing.
   at: _gl_debug_print (drivers/gles3/rasterizer_gles3.cpp:124)
ERROR: FATAL: Index p_index = 0 is out of bounds (size() = 0).
   at: get (./core/cowdata.h:156)
PS C:\Users\joelr\Documents\kolmorotzzet (kolmorotshitt)\Artistic Setups\Godot>

editor closes.
tried to also remake the similar ARVR viewport & added its VR Nodes under ReplacementZetrixViewport.tscn to find that closing & reopening it crashes as well under GLES3
TestViewporto
Open Zetrixer.tscn
Editing project: C:/Users/joelr/Documents/starring codes/Godot Projects/TestViewporto (C:::Users::joelr::Documents::starring codes::Godot Projects::TestViewporto)
Godot Engine v3.4.stable.official.206ba70f4 - https://godotengine.org
PS C:\Users\joelr\Documents\kolmorotzzet (kolmorotshitt)\Artistic Setups\Godot> OpenGL ES 3.0 Renderer: NVIDIA GeForce GTX 1050 Ti/PCIe/SSE2
OpenGL ES Batching: ON

ERROR: Unsupported locale 'in', falling back to 'en'.
   at: set_locale (core/translation.cpp:980)
ERROR: unsupported format character
   at: (core/variant.cpp:3067)
ERROR: unsupported format character
   at: (core/variant.cpp:3067)
ERROR: unsupported format character
   at: (core/variant.cpp:3067)
ERROR: unsupported format character
   at: (core/variant.cpp:3067)
ERROR: unsupported format character
   at: (core/variant.cpp:3067)
ERROR: unsupported format character
   at: (core/variant.cpp:3067)
ERROR: unsupported format character
   at: (core/variant.cpp:3067)
ERROR: unsupported format character
   at: (core/variant.cpp:3067)
ERROR: unsupported format character
   at: (core/variant.cpp:3067)
ERROR: unsupported format character
   at: (core/variant.cpp:3067)
ERROR: unsupported format character
   at: (core/variant.cpp:3067)
ERROR: unsupported format character
   at: (core/variant.cpp:3067)
ERROR: unsupported format character
   at: (core/variant.cpp:3067)
ERROR: unsupported format character
   at: (core/variant.cpp:3067)
ERROR: unsupported format character
   at: (core/variant.cpp:3067)
ERROR: unsupported format character
   at: (core/variant.cpp:3067)
ERROR: Can't use canvas background mode in a render target configured without sampling
   at: render_scene (drivers/gles3/rasterizer_scene_gles3.cpp:4212)

Editor locks up. soft-locked. force close needed.
I have tried other possible configurations, but  none of them crash. only Zetrixer does.
Steps to reproduce
New from scratch

Create new project, use GLES3
have a new Viewport. configure for ARVR,
add new ARVR camera inside that viewport
Save that node tscn
close that node tscn
open it again. It crashes under GLES3
Repeat with GLES2. it does not crash.

Using minimal project

Open this minimal project
Try open following tscn:

Emti.tscn Empty viewport
WithRegularCam.tscn has just regular Camera node
WithRegularCam.tscnARVR same as above, but the viewport checkbox ARVR
Zetrixer.tscn minimally configured to be ARVR. with ARVR camera & viewport checkbox ARVR

Notice that it crashes whenever Zetrixer.tscn being opened. It crashes under GLES3.
repeat process but with GLES2. open the same Zetrixer.tscn and it does not crash.

(BIG REPOSITORY) Using Hexagon Engine

Clone & Open Hexagon Engine project
Quick open dummy viewport called Viewportoroso.tscn which is basically empty viewport with nothing but checkbox ARVR and stuff. Also try open other control scene. As you can see, normally this should opens fine
Quick open VR viewport called ZetrixViewport.tscn or ReplacementZetrixViewport.tscn. If you were in GLES3, the video driver crash, editor closes.
repeat with GLES2. open ZetrixViewport.tscn or ReplacementZetrixViewport.tscn again, won't crash.

Minimal reproduction project
Minimal project
TestViewporto.zip
(OPTIONAL, NOT MINIMAL) Hexagon Engine
https://github.com/Perkedel/HexagonEngine

I also have had tried the minimal project on linux
Godot Version
3.4 Official (v3.4.stable.official.206ba70f4)
System
Linux x64 (Ubuntu) (Uname -r = Linux joelwindows7-Strix-15-GL503GE 5.8.0-59-generic #66-Ubuntu SMP Thu Jun 17 00:46:01 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux), GLES3, Intel Core i7-8750H, Intel UHD Graphic 630, Nvidia GeForce GTX 1050Ti, Nvidia driver 460.91.03
Result
TestViewporto
Open Zetrixer.tscn
diting project: /media/joelwindows7/OS/Users/joelr/Documents/starring codes/Godot Projects/TestViewporto (::media::joelwindows7::OS::Users::joelr::Documents::starring codes::Godot Projects::TestViewporto)
Godot Engine v3.4.stable.official.206ba70f4 - https://godotengine.org
OpenGL ES 3.0 Renderer: GeForce GTX 1050 Ti/PCIe/SSE2
OpenGL ES Batching: ON
joelwindows7@joelwindows7-Strix-15-GL503GE:/media/joelwindows7/OS/Users/joelr/Documents/kolmorotzzet (kolmorotshitt)/Artistic Setups/Godot$
ERROR: unsupported format character
   at: vformat (core/variant.cpp:3067)
ERROR: unsupported format character
   at: vformat (core/variant.cpp:3067)
ERROR: unsupported format character
   at: vformat (core/variant.cpp:3067)
ERROR: unsupported format character
   at: vformat (core/variant.cpp:3067)
ERROR: unsupported format character
   at: vformat (core/variant.cpp:3067)
ERROR: unsupported format character
   at: vformat (core/variant.cpp:3067)
ERROR: unsupported format character
   at: vformat (core/variant.cpp:3067)
ERROR: unsupported format character
   at: vformat (core/variant.cpp:3067)
ERROR: unsupported format character
   at: vformat (core/variant.cpp:3067)
ERROR: unsupported format character
   at: vformat (core/variant.cpp:3067)
ERROR: unsupported format character
   at: vformat (core/variant.cpp:3067)
ERROR: unsupported format character
   at: vformat (core/variant.cpp:3067)
ERROR: unsupported format character
   at: vformat (core/variant.cpp:3067)
ERROR: unsupported format character
   at: vformat (core/variant.cpp:3067)
ERROR: unsupported format character
   at: vformat (core/variant.cpp:3067)
ERROR: unsupported format character
   at: vformat (core/variant.cpp:3067)
ERROR: Can't use canvas background mode in a render target configured without sampling
   at: render_scene (drivers/gles3/rasterizer_scene_gles3.cpp:4212)
^C

Same hang, I have to ^C (Ctrl + C in terminal window, Force close).

I can reproduce the issue with the MRP on Linux. It doesn't seem to crash per se for me but it does stall when opening the Zetrixer.tscn scene.
Checking where it's stuck at with gdb, I get:
(gdb) bt
#0  0x00007facefa0ac45 in<EMAIL_ADDRESS>() from /lib64/libc.so.6
#1  0x00007facefa0f653 in nanosleep () from /lib64/libc.so.6
#2  0x0000000002967d43 in OS_Unix::delay_usec (this=0x7ffd9596d500, p_usec=49451) at drivers/unix/os_unix.cpp:243
#3  0x00000000046b619d in OS::add_frame_delay (this=0x7ffd9596d500, p_can_draw=true) at core/os/os.cpp:812
#4  0x00000000017f534c in Main::iteration () at main/main.cpp:2291
#5  0x00000000017b8c45 in OS_X11::run (this=0x7ffd9596d500) at platform/x11/os_x11.cpp:3705
#6  0x00000000017a680f in main (argc=2, argv=0x7ffd9596de48) at platform/x11/godot_x11.cpp:55


keyof becoming union of string literal in emitted type definitions

TypeScript Version:  3.0.1

Search Terms: declaration emit keyof as union type
Code
We're seeing this problem in LitElement: https://github.com/Polymer/lit-element/blob/master/src/lib/decorators.ts#L43
export const customElement = (tagName: keyof HTMLElementTagNameMap) =>
    (clazz: Constructor<HTMLElement>) => {
      window.customElements.define(tagName, clazz);
      // Cast as any because TS doesn't recognize the return type as being a
      // subtype of the decorated class when clazz is typed as
      // `Constructor<HTMLElement>` for some reason. `Constructor<HTMLElement>`
      // is helpful to make sure the decorator is applied to elements however.
      return clazz as any;
    };

We do this so that users are forced to add their elements to the HTMLElementTagNameMap:
@customElement('my-element')
class MyElement extends HTMLElement {}

declare global {
  interface HTMLElementTagNameMap {
    'my-element': MyElement;
  }
}

Expected behavior:
The declaration for customElement is emitted as:
export declare const customElement: (tagName: keyof HTMLElementTagNameMap) => (clazz: Constructor<HTMLElement>) => any;

And the example user code has no errors.
Actual behavior:
This is the declaration emit for customElement (see https://unpkg.com/@polymer/lit-element@0.6.1/lib/decorators.d.ts):
export declare const customElement: (tagName: "object" | "a" | "abbr" | "acronym" | "address" | "applet" | "area" | "article" | "aside" | "audio" | "b" | "base" | "basefont" | "bdo" | "big" | "blockquote" | "body" | "br" | "button" | "canvas" | "caption" | "center" | "cite" | "code" | "col" | "colgroup" | "data" | "datalist" | "dd" | "del" | "dfn" | "dir" | "div" | "dl" | "dt" | "em" | "embed" | "fieldset" | "figcaption" | "figure" | "font" | "footer" | "form" | "frame" | "frameset" | "h1" | "h2" | "h3" | "h4" | "h5" | "h6" | "head" | "header" | "hgroup" | "hr" | "html" | "i" | "iframe" | "img" | "input" | "ins" | "isindex" | "kbd" | "keygen" | "label" | "legend" | "li" | "link" | "listing" | "map" | "mark" | "marquee" | "menu" | "meta" | "meter" | "nav" | "nextid" | "nobr" | "noframes" | "noscript" | "ol" | "optgroup" | "option" | "output" | "p" | "param" | "picture" | "plaintext" | "pre" | "progress" | "q" | "rt" | "ruby" | "s" | "samp" | "script" | "section" | "select" | "slot" | "small" | "source" | "span" | "strike" | "strong" | "style" | "sub" | "sup" | "table" | "tbody" | "td" | "template" | "textarea" | "tfoot" | "th" | "thead" | "time" | "title" | "tr" | "track" | "tt" | "u" | "ul" | "var" | "video" | "wbr" | "xmp") => (clazz: Constructor<HTMLElement>) => any;

And the above user code has an error, because extending HTMLElementTagNameMap has no effect.
Playground Link: The Playground doesn't show declaration files.
Related Issues: This is exactly the issue, but it was closed and locked: https://github.com/Microsoft/TypeScript/issues/21445

There's another issue assigned to me that is this which I had a stale PR for.

Both behaviors are somewhat problematic, and there's a consistency problem here because we're still going to potentially emit expanded names in certain cases due to an inability to emit anything else (e.g. if you have a switch and exclude certain cases before returning)

Yikes. I still don't think expansion is the right solution even in those cases because it breaks declaration merging. I'd rather infer an overly broad type than an overly narrow one.
It sounds like expansion is only done because there are types that can be inferred that can't be expressed in the type syntax. Is subtraction the only one? (extends might be another)
This might be a reason to re-open the subtraction types issue, or to add syntax for all types.

We ran into the same problem: https://github.com/PolymerLabs/actor-helpers/pull/35/files/4f886d342f13f32c5aa7ca012bde52c71432667e#r236728831 Surprisingly, in the class definition we had before, we did not have this problem. However, when we moved this class into a function, the declaration file became incorrect.

Anyone figured out a workaround for this?
I'm releasing a module that depends on users augmenting module types and only just after doing initial release experiments I noticed this literal inlining of the keyof occurring when emitting the declarations which breaks my module.
Planning to do a code mode of some sorts for the emitted declaration files currently because I'm completely stuck with this atm but that's a very dirty solution...

@epeli  Don't know if it helps, but as mentioned in other issues #33117 and #17294 this issue does not impact function and class declarations, only function and class expressions. Maybe you could structure your code to use function/class declarations? It's hard to propose a more concrete solution without actual code.
@justinfagnani The code in the original ticket also works as expected with a function declaration, not sure you came across the workaround:
export type Constructor<T> = new()=> T

export function customElement(tagName: keyof HTMLElementTagNameMap){
    return (clazz: Constructor<HTMLElement>) => {
      window.customElements.define(tagName, clazz);
      // Cast as any because TS doesn't recognize the return type as being a
      // subtype of the decorated class when clazz is typed as
      // `Constructor<HTMLElement>` for some reason. `Constructor<HTMLElement>`
      // is helpful to make sure the decorator is applied to elements however.
      return clazz as any;
    }
};

Outputs in d.ts file:
export declare type Constructor<T> = new () => T;
export declare function customElement(tagName: keyof HTMLElementTagNameMap): (clazz: Constructor<HTMLElement>) => any;

Oh, I didn't know that! But unfortunately the issue does seem to impact function declarations inside other functions.
Eg. very minimally my code is like this:
export interface SharedThings {
    foo: string;
    bar: string;
}

export function createMyThing() {
    function thing<T extends keyof SharedThings>(mode: T): T {
        return {} as T;
    }

    return thing;
}

and TypeScript emits this
export interface SharedThings {
    foo: string;
    bar: string;
}
export declare function createMyThing(): <T extends "foo" | "bar">(mode: T) => T;

In reality my code is bit more complicated though I think it's comes down to watch's above.
But in more detail inside my module I have a generic createMyThing() in lib.ts:
export function createMyThing<Shared>() {
    function thing<T extends keyof Shared>(mode: T): T {
        return {} as T;
    }

    return {
        thing: thing,
    };
}

which is emitted correctly
export declare function createMyThing<Shared>(): {
    thing: <T extends keyof Shared>(mode: T) => T;
};

and in index.ts I do
export interface SharedThings {
    foo: string;
    bar: string;
}

export const MyThing = createMyThing<SharedThings>();

and that unfortunately emits to
export interface SharedThings {
    foo: string;
    bar: string;
}

export declare const MyThing: {
    thing: <T extends "foo" | "bar">(mode: T) => T;
};

@epeli  You can still get the correct declaration emit if you add an interface. It does imply some type duplication, but at least the emitted code is what you want it to be:
export interface IMyThing<Shared>{
    thing<T extends keyof Shared>(mode: T): T
}
export function createMyThing<Shared>(): IMyThing<Shared> {
    function thing<T extends keyof Shared>(mode: T): T {
        return {} as T;
    }

    return {
        thing: thing,
    };
}

export interface SharedThings {
    foo: string;
    bar: string;
}

export const MyThing = createMyThing<SharedThings>();

in d.ts we get:

export declare const MyThing: IMyThing<SharedThings>;

That could work indeed! But only nearly for my usecase.
In my index.ts file I actually destructure the created object and export the functions individually
export const { thing } = createMyThing<SharedThings>();

and that emits again 🤦
export declare const thing: <T extends "foo" | "bar">(mode: T) => T;

Also doing
export const MyThing = createMyThing<SharedThings>();
export const thing = MyThing.thing;

Emits the same thing. MyThing exports correctly but thing is being inlined.

Hmm, at least I seem to be able to do
export const thing: IMyThing<SharedThings>["thing"] = MyThing.thing;

I has an interface declared by merging declaration files.
// module-a/index.d.ts
declare module 'my-module'{
  export default interface MyInterface {
    a: string
  }
}

// module-b/index.d.ts
declare module 'my-module'{
  export default interface MyInterface {
    b: number
  }
}

type Keys = keyof MyInterface

export function myFunc<T extends Keys>(k: Keys) {}

At emitting time only some declaration files available that leads to somethings like:
export declare function myFunc(k:'a') // 🤦♀

I'm seeing this issue as well in a function that accesses keys of a type from a peer dependency.
import { SomethingTypes } from "peer-dependency";

export default {
    foo<S extends keyof SomethingTypes>(bar: MyType<S>) { }
}

becomes
    foo<S extends "key1" | "key2" | "key3"...

This is an issue because it means my package needs to be updated in tandem with the peer dependency.


feat(integration-tests): Add S3 state store integration test

Okay @valmack, new version up with ceramic2 renamed to ceramicClient and some related cleanups


Feature Request: unit_prod_price & unit_load_cost forecasts

Thanks for implementing the price and cost sensors.
It would be great if this could be extended (like the other EMHASS published sensors) to include the future forecasts as an atribute.

Hi, yes sure. This should be an easy fix. It can be added in the next release.

I don't seem to be getting much through these attributes ;-(
They are all coming out as 0.0.

Same issue here. It seems the value is rounded to nearest whole number at some point and then converted to a float again. Here's what it looks like for me (sorry for the large screenshot but I wanted to the the 2.0 values included):

This is an easy fix. It is already solved here: #91
It will be available on the next release.

I've just published a new release, it should work as expected.

Unfortunately I am still doing the rounded to 0.0 on the forecasts so this issue should be reopened.

Ok, it works as expected on the tests. I'll take a look at this

Let me know if you want me to test any code.

Thanks Mark. Just a question this is happening for both unit_prod_price and unit_load_cost?

I can concur. I have the same issue after updating to 0.4.13. Both unit_prod_price and unit_load_cost have attributes rounded to nearest integer, even if they are floats.

Thanks Mark. Just a question this is happening for both unit_prod_price and unit_load_cost?

Yes both are being rounded to 0.0

This is amazing:
https://chat.openai.com/share/6a5bd9ed-f67f-4c32-a5d7-96e06de1255d

--- retrieve_hass.py
+++ retrieve_hass_modified.py
@@ -231,7 +231,7 @@
datum[entity_id.split('sensor.')[1]] = vals_list[i]
forecast_list.append(datum)
data = {

       "state": str(state),

       "state": "{:.2f}".format(state),
       "attributes": {
           "unit_of_measurement": unit_of_measurement,
           "friendly_name": friendly_name,

@@ -307,7 +307,7 @@
friendly_name, "scheduled_forecast", state)
else:
data = {

           "state": str(state),

           "state": "{:.2f}".format(state),
           "attributes": {
               "unit_of_measurement": unit_of_measurement,
               "friendly_name": friendly_name

--- retrieve_hass_modified.py
+++ retrieve_hass_modified_v2.py
@@ -223,7 +223,7 @@
list_df = copy.deepcopy(data_df).loc[data_df.index[idx]:].reset_index()
list_df.columns = ['timestamps', entity_id]
ts_list = [str(i) for i in list_df['timestamps'].tolist()]

   vals_list = [str(np.round(i)) for i in list_df[entity_id].tolist()]

   vals_list = [str(np.round(i, 2)) for i in list_df[entity_id].tolist()]
   forecast_list = []
   for i, ts in enumerate(ts_list):
       datum = {}

Some of the nice usages for chatgpt ;-)


Add FLs and TLs as approvers

Make FLs and TLs approvers for cases where standard approvers aren't suitable/are hard to reach.
Ref OSD-25197

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 52.11%. Comparing base (4c15609) to head (1aa02d3).

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #119   +/-   ##
=======================================
  Coverage   52.11%   52.11%
=======================================
  Files           4        4
  Lines         236      236
=======================================
  Hits          123      123
  Misses         93       93
  Partials       20       20

/test validate


Perform a Runtime Upgrade

learn about what a "runtime upgrade" is and how to perform one.
Create a test branch, and add a new extrinsic in the Roles pallet called "nominate":

Allows current Manager and Auditor to "nominate" another account to become the same role.
Only works for Manager and Auditor roles.

Launch a local testnet using code compiled without the new extrinsic.
Switch to the new version, and compile the new code into WASM.
Observe that the new extrinsic isn't there in the current local testnet.
Perform a "Runtime Upgrade".
Observe that the new extrinsic can be called. Test that it works.

Runtime Upgrade
make change locally
runtime lib upgrade version:  spec_version: 100,
cargo build --release
find the wasm file in target/release/wbuild/xy-chain-runtime
copy the file to upload
stash the change code and run localnet
// build and run local testnet
cargo build --release
./target/release/xy-chain --dev
go to front-end use root user Alice
select sudo, sudo(call)
system setcodewithoutcheck()
upload the wasm file
submit


Update search-the-audit-log-in-security-and-compliance.md

Updating the documentation with the recent changes that are made " This event does not capture token refresh activities"

@nenonix @JohanFreelancer9 - kindly do the copy editor review for this PR. Thanks.

@markjjo - PR has been copy edited and is ready for final review.
Thank you.
cc: @kenwith


Zone errors replace filename in stacktrace to [angular]

Currently I'm using Rollbar service for crash reporting. It uses pre-uploaded sourcemaps to parse exception statcktraces. Zone replaces filename in stacktrace with [angular] and Rollbar fails to translate it to actual source lines. Currently I have to manually extract originalStack  before submitting. I wonder if this replacement is really needed?
Original error translated:
Error: Rolbar test
File "webpack:///./~/zone.js/dist/zone.js" line 915 col 1 in ZoneAwareError
var error = NativeError.apply(this, arguments);
File "webpack:///./Spa_Source/app/main/header/header.component.ts" line 40 col 15 in Header.onSelect
throw new Error('Rolbar test');
File "ng:///AppModule/Header.ngfactory.js" line 114 col 24 in Object.eval [as handleEvent]
File "webpack:///./~/<EMAIL_ADDRESS>line 11799 col 86 in Object._ [as handleEvent]
var /** @type {?} */ handleEvent = function (view, nodeIndex, eventName, event) { return ((((...
File "webpack:///./~/<EMAIL_ADDRESS>line 12419 col 68 in Object.handleEvent
handleEvent: function (view, nodeIndex, eventName, event) { return view.def.handleEvent(v...
File "webpack:///./~/<EMAIL_ADDRESS>line 8773 col 1 in dispatchEvent
return Services.handleEvent(view, nodeIndex, eventName, event);
File "webpack:///./~/<EMAIL_ADDRESS>line 10638 col 30 in [anonymous]
return function (event) { return dispatchEvent(view, index, eventName, event); };
File "webpack:///./~/<EMAIL_ADDRESS>line 3840 col 35 in SafeSubscriber.i [as _next]
function (value) { generatorOrNext(value); };
File "webpack:///./~/rxjs/Subscriber.js" line 236 col 1 in SafeSubscriber.__tryOrUnsub
fn.call(this._context, value);
File "webpack:///./~/rxjs/Subscriber.js" line 185 col 1 in SafeSubscriber.next
this.__tryOrUnsub(this._next, value);
File "webpack:///./~/rxjs/Subscriber.js" line 125 col 1 in Subscriber._next
this.destination.next(value);
File "webpack:///./~/rxjs/Subscriber.js" line 89 col 1 in Subscriber.next
this._next(value);
File "webpack:///./~/rxjs/Subject.js" line 55 col 1 in EventEmitter.Subject.next
copy[i].next(value);
File "webpack:///./~/<EMAIL_ADDRESS>line 3814 col 53 in EventEmitter.emit
EventEmitter.prototype.emit = function (value) { _super.prototype.next.call(this, value); };
File "webpack:///./Spa_Source/app/main/header/menu/header.menu.component.ts" line 52 col 23 in HeaderMenu.onItemClick
this.selected.emit(item);

Zone wrapped error translated:
Error: Rolbar test
File "[angular]" line (unknown) in Header.onSelect (http://site/Spa_Dist/main.js?636294494840000000=2164285:1:1952491)
File "[angular]" line (unknown) in Object.eval [as handleEvent] (ng:///AppModule/Header.ngfactory.js:114:24)
File "[angular]" line (unknown) in Object._ [as handleEvent] (http://site/Spa_Dist/main.js?636294494840000000=2164285:1:50186)
File "[angular]" line (unknown) in Object.handleEvent (http://site/Spa_Dist/main.js?636294494840000000=2164285:1:58606)
File "[angular]" line (unknown) in dispatchEvent (http://site/Spa_Dist/main.js?636294494840000000=2164285:1:23025)
File "[angular]" line (unknown) in http://site/Spa_Dist/main.js?636294494840000000=2164285:1:36518
File "[angular]" line (unknown) in SafeSubscriber.i [as _next] (http://site/Spa_Dist/main.js?636294494840000000=2164285:1:98744)
File "[angular]" line (unknown) in SafeSubscriber.__tryOrUnsub (http://site/Spa_Dist/main.js?636294494840000000=2164285:1:170229)
File "[angular]" line (unknown) in SafeSubscriber.next (http://site/Spa_Dist/main.js?636294494840000000=2164285:1:169424)
File "[angular]" line (unknown) in Subscriber._next (http://site/Spa_Dist/main.js?636294494840000000=2164285:1:168433)
File "[angular]" line (unknown) in Subscriber.next (http://site/Spa_Dist/main.js?636294494840000000=2164285:1:168049)
File "[angular]" line (unknown) in EventEmitter.Subject.next (http://site/Spa_Dist/main.js?636294494840000000=2164285:1:261622)
File "[angular]" line (unknown) in EventEmitter.emit (http://site/Spa_Dist/main.js?636294494840000000=2164285:1:98192)
File "[angular]" line (unknown) in HeaderMenu.onItemClick (http://site/Spa_Dist/main.js?636294494840000000=2164285:1:1953583)

@kemsky , thank you for posting the issue, in zone.js 0.8.10, by default , the Zone Error will not be loaded, so you can just upgrade to 0.8.10, you can get the original error. And if you want the ZoneAwareError feature, you can load zone.js/dist/zone-error.js manually.

Close for now.


Add info about hotels + location

Info about location is implemented in https://github.com/Inria-Visages/brainhackrennes-2018/pull/8.
I don't know how to add all the hotels. Or maybe just a sentence saying that interested attendees can contact us for a list of suitable hotels?
What are your thoughts on this?

Just saw this one. Where do we mention that they can contact us for any information about accommodations?

We have a list of hotels but I was not sure how this could fit on the website. You suggestion to add a comment with our contact for more info on accommodation sounds good! Do you want to send a PR?


Microsoft Edge friendly?

Description
I ran code-server2.1523-vsc1.38.1-linux-x86_64 and loaded the page on Edge v. 25.10586.0.0 only to have it spit:
SCRIPT1053: Const must be initialized - workbench.web.api.js (6,968)

Also ran code-server2.preview.11-vsc1.37.0-linux-x86_64 which says
HTML1506: Unexpected token.

Also tried code-server1.1156-vsc1.33.1-linux-x64 which says
SCRIPT1006: Expected ')' - ide.main.5b173b.js (53,5812)

Of course any major browsers are fine - chrome, ff, safari. Kinda awkward since it's Microsoft's own creation.

@working-name try out their Insiders Beta, you'll have more luck using it than the vendor-supplied Edge.


Add latest Foxit ADMX

https://kb.foxitsoftware.com/hc/en-us/articles/360040241112-Available-GPO-templates

Hi Jonathan,
Unfortunately, Foxit blocks anything that is not a browser from accessing their website.
This means we cannot use powershell to find if there's a new version and follow that link to the downloads.
Not even the "Copy web-request to Powershell" trick worked, so I'm lost here (https://www.powershellbros.com/powershell-tip-of-the-week-create-invoke-webrequest-from-chrome/).
Cheers,
Arjan


[Bug] Login bug

https://github.com/boxbilling/boxbilling/issues/984
What happened?
After logging out of the BoxBilling site, I am unable to log into the site.
After reinstalling BoxBilling 4.22 I could never log back into the system using the admin account the first ime.
On another attempt, I created another admin user just after installation, and that user could not log in either from another device or browser.
On another occasion, I created a standard user after installation and was able to login in a different browser with the standard user, but not with the initial admin user created at installation.
a)I copied the password HASH from the working user account to the admin user "pass" field but that didn't work either.
b) So in looking at another Boxbilling issue about the trailing slash, I noticed that there is a SALT included in the bb-config.php file but not in the database in the "table:admin".

So to fix the problem, I copied the salt from the bb-config.php file and placed it in the salt field for each user, and this allowed all the users to log into the site.
My question is,
Is this by design to not include the "SALT" in the database for each user?
Did I miss something during the installation process that caused this to work this way?
Is this a BUG and the installation process is supposed to add the SALT to each user upon the user creation process?

BoxBilling Version
v4.22-beta.1
What version of PHP are you running?
7.4x
Additional Notes
Additional notes

Failed to reproduce this bug despite installing current version on nginx, Apache, and Litespeed and running different PHP versions.
There are no reports of it from any other user, so I think that for now we can assume that it has either been solved since the bug report or is something highly environment specific.
Closing this issue for now, can be reopened in the future if there are more reports of it occurring.


Add CR settings for CDS Hooks and remove dependency on Spring Boot from CR configs.

Resolved by #5394


Mervat: ux/ui design

Week 6
Check-In
I Need Help With:

What went well?

communicating with my partner in the team.

What went less well?

facing problem with my PC, took long time to fix it.
still facing problems with npm but I'm trying to work on it.

Lessons Learned

assign enough time to study and don't delay work.

Sunday Prep Work

[x] User Empathy: You understand what user empathy is, and can use it to understand a classmate's needs and help them plan a home page.
[ ] Design Cycle: You will be able to describe the design cycle and what steps you will take in each state (Empathize, define, ideate, prototype, testing and implement).
[x]  Stakeholder Interviews: You can interview another student to learn their motivations, needs, and blocks
[ ]  Rapid Prototyping: You can use rapid prototyping techniques (such as paper prototyping) to test initial design hypotheses and receive user feedback.
[ ] User Journeys: You can write user journeys for websites that you use.
[ ]  Design Principles: You can apply some of the key design principles to your own site, such as alignment, proximity, contrast, balance and space.
[ ]  Accessible Design: You will be able to make a website design more accessible.
[ ]  CSS: You can use CSS3 to implement responsive & accessible designs.
[ ]  Open Source Software: You understands the principles of open licensing and can make a contribution to a classmate's home page.
[ ]  Web Accessibility: You can navigate a web page using a screen reader, and can use semantic elements and ARIA labels to make your web pages accessible.
[ ]  Figma: You can create, share and collaborate on a website design using Figma.

still facing problems with npm but I'm trying to work on it

Any luck with this? Let us know if you need help, unfortunately we have experience with those :-)

Any luck with this? Let us know if you need help, unfortunately we have experience with those :-)

Till now I was able to manage it .... thank you 😄

Check-In
I Need Help With:

What went well?

communicating with team.
getting used to figma

What went less well?

this week I did have enough time to concentrate.

Lessons Learned

keep trying until I get it right.


Use built-in unix command stat instead of exiftool

The part you want to Enhancement
We can get file attributes without additional programs, but use the built-in stat utility.
Why it is necessary to enhancement
We won't need to install a third party program.
Additional context
Windows also has an alternative command: Windows equivalent to the unix "stat" command?.
You may also find this useful: stat(1) — Linux manual page.
Here's what it looks like on macOS and ubuntu. You can also specify the output format you want via the --format argument.

Looks great.
It will be better if we don't need to install another tool.


Fix HTML report pointing to instrumented files

The HTML report generated by the current runCoverage will point to instrumented files. cleanUp needs to run before api.report() so that the correct contract files are used.

Thank you!

Published in 0.1.8.


Why command-simplified

The Original Why Command show in class was very complex and needs more time to complete.
In the mean time, I have simplified my Why Command to function like an Easter egg like it did in Phase A. Every time the why command is activated on a person index, it displays "Because  lives in ".
The Reason class is meant to be a placeholder for the Insurance class which we intend to implement in the future.

Changes Unknown when pulling d518ba1742e57fa45379646e5d98730a8cc27861 on arnollim:WhyCommand-Simple into ** on CS2103AUG2017-T13-B1:master**.


ES6 Module

It'd be nice to have this as an ES6 module (as well as UMD) to avoid polluting the HTML.. Thanks!

I tend to agree, as I am a huge fan of ES6 modules. I'll see what I can do.
Of course, the horrible option is to wrap it in a file like this:
import './dialog-polyfill.js';

const dialogPolyfill = window.dialogPolyfill;
export default dialogPolyfill;
delete window.dialogPolyfill;

🤣

sorry, I was hoping to send this over to you sooner. Open for feedback/suggestions/code review on the changes!

I'm very much a bundler noob but it's my understanding that default exports are controversial https://twitter.com/ericsimons40/status/1090771410492960768?s=19

Some complaints about default exports are listed at https://blog.neufund.org/why-we-have-banned-default-exports-and-you-should-do-the-same-d51fdc2cf2ad , but these are mostly surmountable with linting rules. Since a polyfill really has one purpose, it would seem unlikely to me that one would wish to cram other items into the same polyfill, so I personally don't see anything wrong with default exports here.
However, for the PR, I'd recommend that the source use an ES6 export since Rollup allows one to indicate via standard means that this is a module by design (without committing to a specific variable name, except in the global build). (There are still advantages for having a separate ESM distribution build though, as it allows distributions all in the same directory and if any dependencies are ever needed, the ESM dist will get these bundled.)
Adding the export to source also avoids the need for use strict in source, since modules have this mode on by default (and Rollup will add the strict directive in non-ESM builds for you).

We don't have opinions on default exports vs not. Like I said above, the way the polyfill works is mostly left over. Others I've worked on use MutationObserver (or something like that) just to automagically upgrade things - in those cases we don't need exports at all.
@brettz9 is mostly right though, please ES6 export and we can build to CJS for the NPM release. (I'll look at the PR again tomorrow).

@samthor I'm happy to make changes,  I'll try to summarize what I think is being asked:

add dialog-polyfill.cjs.js to the .gitignore file so we don't check in the commonjs build
in package.json on npm prepublishOnly event, generate dialog-polyfill.cjs.js

Is this correct? Are there other desired changes?
Just let me know, happy to help!

I might suggest making a separate format: "es" distribution (and point module to it instead of source)... Just a bit better practice, imo, to have a convention to find all usable files within dist, especially in case the package ever would rely on a dependency or split the source files (yes, if you use the ".js" extension, split source files could still be imported at run-time, but potentially less desirable for performance than having it all pre-packaged in an "es" format bundle).

Can we leave comments on the PR? #176

this issue should be resolved now since the PR was merged. @samthor can we get a new npm release for this please? 🙏

Done
https://github.com/GoogleChrome/dialog-polyfill/releases

As a continuation of this, if you load in dialog-polyfill with require as such:
const dialogPolyfill = require('dialog-polyfill');

If you bundle this down with webpack, it defaults to resolving the module field before the main field, which results in the actual contents of the module behind dialogPolyfill.default as it is bundling the ESM build rather than the CJS build.
As a fix for this, would it be possible to support the exports field by adding the following to the package.json:
  "exports": {
    ".": {
      "import": "./dist/dialog-polyfill.esm.js",
      "require": "./dist/dialog-polyfill.js"
    }
  },

I did this in a test project and then if you did require('dialog-polyfill') it would include the CJS version in the webpack bundle.

actually now that the last remaining version of node that lacks support for esm will be unmaintained in April (soon) https://nodejs.org/en/about/releases/  it might make sense to drop everything but esm, bump the major version.


Getting private services from container is deprecated since Symfony 3.2

Q
A

Bug report?
no

Feature request?
no

BC Break report?
no

Used Version
1.0.6

When accessing the auditReader service as described in the README, the following deprecation notice is thrown by Symfony (I am using Symfony 3.4):
User Deprecated: The "simplethings_entityaudit.reader" service is private, getting it from the container is deprecated since Symfony 3.2 and will fail in 4.0. You should either make the service public, or stop using the container directly and use dependency injection instead.

Should have been fixed in https://github.com/simplethings/EntityAuditBundle/pull/316


wrong width calculation

I'm just trying to put some complex html elements inside a section whose has it's class loaded by jquery + slick, however it loades the children elements with wrong widths.
====================================================================
[  https://codepen.io/leodsgn/pen/zzKdeg  ]
====================================================================
Steps to reproduce the problem

Load jquery + slick in html
Created a section with class ".services-featured__grid" with some blocks inside of it that should be the information cards that would be the slider items
Loaded the class in jquery followed by the slick function and configurations
Got the error

====================================================================
What is the expected behaviour?
Have a simple slides with the items inside the section ".services-featured__grid".
====================================================================
What is observed behaviour?
Looks like the slider calculation is wrong and the items have it's width reduced and put one above the others.
====================================================================
More Details

Which browsers/versions does it happen on?
Google Chrome #latest + Safari #latest
Which jQuery/Slick version are you using?
jquery 3.2.1
slick.js 1.6.0
Did this work before?
In a simple div with images inside, it works fine!

Ok. Looks like it's working now for 2 reasons:

Removed the display: flex from my CSS
Added the slick.css instead of slick-theme.css (or keep both)

Now everything works fine.

I also have into this problem, I will leave the answer here, maybe it will save someone time.
Flex is the first obvious problem, because many sliders have Flex issues. I changed all parent's Flex to Block and that didn't fix the problem.
I accidentally discovered that the problem is overflow-y: auto; in the parent container.


[Fix] Fix in discounts and summary decimals

Se agrega un fix en descuentos.
Se borra código legacy de descuentos.
Se agrega un fix en los decimales del Summary de Revisa y Confirma.

Codecov Report

Merging #949 into develop will decrease coverage by 0.06%.
The diff coverage is 60%.

@@            Coverage Diff             @@
##           develop    #949      +/-   ##
==========================================
- Coverage    29.27%   29.2%   -0.07%
==========================================
  Files          294     294
  Lines        14742   14714      -28
  Branches      1367    1366       -1
==========================================
- Hits          4315    4297      -18
+ Misses        9891    9882       -9
+ Partials       536     535       -1

Impacted Files
Coverage Δ

.../main/java/com/mercadopago/core/CheckoutStore.java
32.25% <ø> (ø)
:arrow_up:

...ain/java/com/mercadopago/PaymentVaultActivity.java
0% <0%> (ø)
:arrow_up:

.../mercadopago/presenters/PaymentVaultPresenter.java
63.88% <100%> (-1.61%)
:arrow_down:

.../com/mercadopago/presenters/CheckoutPresenter.java
59.44% <75%> (+0.12%)
:arrow_up:

...ain/java/com/mercadopago/util/MercadoPagoUtil.java
12.5% <0%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5d689b6...f59064b. Read the comment docs.


Feat/docker local testing

Howdy!
Hopefully this is okay. Brief bit of info is in docker/README.md.
Currently the docker/docker_build/setup.sh only adds a few python modules (Basically the ones I have been testing against) so  we might need to expand this to include all the ones that are required. I've added a note in the README.md about this.
Should just be a case of docker-compose up to test locally (I've been doing it all morning :smile: )
Cheers.

Ugh, I done goofed. Let me rebase it so it doesn't pull in all my handler stuff too :man_facepalming:

LGTM, the only thing that is missing an entry in the CHANGELOG.md, under the unreleased section.
We have detailed changelog docs at https://github.com/sensu-plugins/community/blob/master/HOW_WE_CHANGELOG.md.


Are these dependencies still needed?

broccoli-merge-trees
broccoli-static-compiler

Both are still used in index.js to include fonts.


[Feature Request]

Could you please submit your build to f-droid and maintain it for a while?
Many less tech savvy persons would get an easier access to the program without trusting a random (for them at least) sounding online website.

Just add the IzzyOnDroid Repository to the F-Droid Store App and install it this way


Move DataGrid data transformation to Django Ninja schema

###Description of the Tech Debt###
There is a good description of the benefits of doing this in #755 which covers other pages which we do data transformation on the front end.

[ ] Industry User Admin DataGrid - processExternalDashboardUsersTileData in @/app/utils/users/adminUserOperators.ts. Also could likely remove this file altogether and move getExternalDashboardUsersTileData to industry_user_admin/dashboard/users/page.tsx
[ ] Operations DataGrid - formatOperationRows in routes/operations/Operations.tsx
[ ] Operations DataGrid - formatUserOperatorRows in routes/access-requests/AccessRequests
[ ] rename data in the Ninja Schemas to rows

###Tech Debt Triage#
The purpose of our technical debt triage process is to analyze technical debt to determine risk level of the technical debt and the value in tackling that technical debt.
Risk Value Scoring:

Level
Value

High
3

Medium
2

Low
1

Technical Debt - Risk Types
Level
Value

Business Area Risk - Risk of business area visibility / damage to user experience
1

Developer Fault Risk - How likely will this tech debt cause a future error related to coding on top of it
3

System Fault Risk - Risk of system errors or application downtime
2

Time Scale Risk - Compound risk effect if left alone. How much more difficult to fix or dangerous will this become over time?
2

Time Sink Risk - How much will this tech debt slow the development process down
2

TOTAL SCORE:
10

This may be addressed by the work on the part 2 dashboard

@BCerki is this still relevant? I'm putting a deletion candidate tag on it.


fix cmake config for downstream packages

The cmake config file was looking for the old Kokkos install files and was missing other dependencies.

Codecov Report

Merging #33 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #33   +/-   ##
=======================================
  Coverage   84.31%   84.31%
=======================================
  Files          32       32
  Lines        5655     5655
=======================================
  Hits         4768     4768
  Misses        887      887

Flag
Coverage Δ

#mpicc
84.31% <ø> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2944dcc...f742846. Read the comment docs.


NodeJS: CommonJS vs ECMA

Describe the feature
The NodeJS package is currently built in ECMA, which makes it incompatible with a CommonJS project.  https://github.com/aws/glide-for-redis/blob/main/node/npm/glide/tsconfig.json#L4
Use Case
Currently our project (who wants to use glide) is built like this :
{
  "compilerOptions": {
    "module": "commonjs",
    "moduleResolution": "node",
    "target": "es2020",
    "lib": [
      "es2020"
    ],
  },
}

So, we can't use this package due to our current configuration. It's also impossible for us to change the way we build our project, because of many packages used.
 ealen…/web-services/core/core on  master +252 -1 [!] is 📦 v0.0.1 via  v20.11.1 on ☁  saml (us-east-1) [X] 祥14s
❯ npm run start

><EMAIL_ADDRESS>start
> node --require dotenv/config dist/main.js

/home/ealen/code/web-services/core/core/dist/main.js:4
const glide_for_redis_1 = require("@aws/glide-for-redis");
                          ^

Error [ERR_REQUIRE_ESM]: require() of ES Module<EMAIL_ADDRESS>from /home/ealen/code/web-services/core/core/dist/main.js not supported.
index.js is treated as an ES module file as it is a .js file whose nearest parent package.json contains "type": "module" which declares all .js files in that package scope as ES modules.
Instead either rename index.js to end in .cjs, change the requiring code to use dynamic import() which is available in all CommonJS modules, or change "type": "module" to "type": "commonjs" in<EMAIL_ADDRESS>to treat all .js files as CommonJS (using .mjs for all ES modules instead).

    at Object.<anonymous> (/home/ealen/code/web-services/core/core/dist/main.js:4:27) {
  code: 'ERR_REQUIRE_ESM'
}

Node.js v20.11.1

Proposed Solution
Is it possible to create "hybrid" modules that support commonJS and ECMA ?

https://dev.to/mbarzeev/hybrid-npm-package-through-typescript-compiler-tsc-150c
https://www.sensedeep.com/blog/posts/2021/how-to-create-single-source-npm-module.html

Other Information
No response
Acknowledgements

[ ] I may be able to implement this feature request
[ ] This feature might incur a breaking change

Client version used
0.2.0
Environment details (OS name and version, etc.)
Ubuntu 22.04.2 LTS - Node v20.11.1

@avifenesh PTAL

Thanks @Ealenn ,
This feature was not planned. We will be happy for contribution, otherwise we’ll update you once the feature is implemented and released. We will be happy to work with you together and further discuss it.


Prefer Go To Source Definition Should Be Enabled By Default

I'm a Typescript developer, and I think it's safe to say that no developer I've ever met has ever wanted to go to a Typescript definition when we CTRL/Command + Click a bit of code :)  We all want to see the code for what we clicked, not its type (although, obviously, "Goto Type" still makes sense when you click on a type).
It turns out, VS Code already has the correct behavior built-in, but for some reason you force people to enable it manually.  This is the reverse 80/20 rule: you're making 80%+ devs (who don't want to go to types) go to types, when less than 20% of them want to.  It should be the other way around: VS Code should support most devs out of the box, with a weird setting you have to enable if you're a freak (no judgment) who prefers looking at types to looking at code.
Please make "Prefer Go To Source Definition" enabled by default.   Not for me (I've already fixed it), but for every other Javascript AND Typescript dev.

There are good reasons why it's not enabled by default: it's far slower and less reliable

But who cares if it's slow?
Trading performance for usefulness is a bad trade :(


From's orphan rules being asymmetric is annoying

I can do impl<T> From<T> for NewType<T>, but I can't do impl<T> From<NewType<T>> for T even though I can do impl From<NewType<u32>> for u32.
That leads to unfortunate huge sets of impls like https://docs.rs/simd-trick/0.3.0/simd_trick/struct.Simd.html#impl-From<Simd<[m64%3B 8]>>

Couldn't you do impl Into<T> for NewType<T> though? And thus not have all those impls, given end users are supposed to bound on Into not From?


Cannot start kali (xfce4)

Hello.
I am having a problem starting my Kali chroot.
I just got a new crouton install and created a Kali chroot.
(sudo sh -e ~/Downloads/crouton -r kali -t xfce)
Then I ran sudo startxfce4 to start Kali.
It returned
Entering /mnt/stateful_partition/crouton/chroots/kali...
/usr/bin/startxfce4: Starting X server

X.Org X Server 1.12.4
Release Date: 2012-08-27
X Protocol Version 11, Revision 0
Build Operating System: Linux 3.16.0-4-amd64 x86_64 Debian
Current Operating System: Linux localhost 3.8.11 #1 SMP Mon Apr 27 08:37:50 PDT 2015 x86_64
Kernel command line: cros_secure console= loglevel=7 init=/sbin/init cros_secure oops=panic panic=-1 root=/dev/dm-0 rootwait ro dm_verity.error_behavior=3 dm_verity.max_bios=-1 dm_verity.dev_wait=1 dm="1 vroot none ro 1,0 2506752 verity payload=PARTUUID=4453db81-7fc7-9443-b1b3-dedc142b0b9e/PARTNROFF=1 hashtree=PARTUUID=4453db81-7fc7-9443-b1b3-dedc142b0b9e/PARTNROFF=1 hashstart=2506752 alg=sha1 root_hexdigest=19983e99694f43f58c9b7fe794a36276d6631a9b salt=c1f66bbcb95439a8ee2d0617298166203029c4b74e1da8c2eb976c10a5fbe491" noinitrd vt.global_cursor_default=0 kern_guid=4453db81-7fc7-9443-b1b3-dedc142b0b9e add_efi_memmap boot=local noresume noswap i915.modeset=1 tpm_tis.force=1 tpm_tis.interrupts=0 nmi_watchdog=panic,lapic iTCO_vendor_support.vendorsupport=3
Build Date: 09 February 2015  09:46:52AM
xorg-server 2:1.12.4-6+deb7u6 (Julien Cristau<EMAIL_ADDRESS>
Current version of pixman: 0.26.0
        Before reporting problems, check http://wiki.x.org
        to make sure that you have the latest version.
Markers: (--) probed, (**) from config file, (==) default setting,
        (++) from command line, (!!) notice, (II) informational,
        (WW) warning, (EE) error, (NI) not implemented, (??) unknown.
(++) Log file: "/tmp/Xorg.crouton.1.log", Time: Thu May  7 18:16:06 2015
(==) Using system config directory "/usr/share/X11/xorg.conf.d"

Fatal server error:
xf86EnableIOPorts: failed to set IOPL for I/O (Operation not permitted)

Please consult the The X.Org Foundation support
         at http://wiki.x.org
 for help.
Please also check the log file at "/tmp/Xorg.crouton.1.log" for additional information.

Server terminated with error (1). Closing log file.
/usr/bin/xinit: giving up
/usr/bin/xinit: unable to connect to X server: Connection refused
/usr/bin/xinit: server error
Unmounting /mnt/stateful_partition/crouton/chroots/kali...

Please help.
The problem is obviously in  whatever xf86EnableIOPorts is, but I don't know how to fix it.
Thanks
--Anthony

Exactly same issue, happens since the chromebook update. Still looking for answers

The only way now is update your chroot with sudo sh ~/Downloads/crouton -t xiwi -n kali -u This will install the xiwi target which lets your chroot run in a chromeos window. See for more info #1505
@Alfriadox Please close this issue since it is tracked in #1505

Ok. Thank You.


Option to change font size of label

Describe the solution you'd like
A button to change the font size of label

Are you working on this? (Yes/No)
Yes

Thanks for this @Palaksharma23 but I don't think there is much utility in being able to adjust font size. Also the Properties dialog box is getting bigger and bigger (as you can see in your screenshot), so we may not want to add more things to it unless necessary.

Guys anyone working on this issue.


Enable asset store for Godot 3.0

I enabled it and allow loads only 3.0 assets from site - This is simple fix in http request line, I wonder why nobody touches this...
fix for https://github.com/godotengine/godot/issues/7147

And why its printed ERROR in the description of each asset - its a subject of another issue, if I remove filter it loads 2.1 with that bug for each assets, my PR does nothing with it - it just enabled asset store and make it use 3.0 filter. Installation, searching worked as expected..

Ok, I squashed these commits into one


Nomination Pools unstake setup screen #85ztp5qyy

Task linked: CU-85ztp5qyy iOS. Nomination Pools. Unstake - setup screen


Training slowing down dramatically

Did anyone face the issue of the training process slowing down? For example, training one DQN-CTS worker on Montezuma's Revenge runs at about 220 iter/sec after 100.000 steps and 35 iter/sec after 400.000. Any thoughts? Thank you.

Hi @ionelhosu, I think when it's running at 220 iter/sec the training hasn't actually started yet; it's just filling the replay buffer until it reaches some minimum size. That explains the slowdown, but it is unexpected just how slow that training updates are. I'd like to do some tensorflow profiling to spot what the bottleneck is here, but if you find anything interesting on your own please let me know.


[Feature Request]: Plugin Support

Hey, I love this mod. Would it be possible that besides the mod you would also release a plugin for PaperMC? Similar to this one.
I would appreciate native support from this repository, not only for modded servers like Fabric, but also for plugin servers like PurpurMC, because I think many people like to use this mod on servers that are not modded servers.
I also think that you don't need a huge config for the plugin. Maybe just that you could restrict certain channels or something like that.
Thanks for consideration. 👍🏻

Providing native support for Bukkit servers was mentioned during development but was discarded due to the lack of demand.
Reading your feature request provides us with more motivation to push such a plugin to production.
This plugin wouldn't be programmed for Paper or any other Spigot work specificly but in the Bukkit (Spigot) environmentto provide support for every Bukkit fork.
We don't plan on restricting users by server-side configs in any way. If such a plugin would be created natively there wouldn't be any user-restricting configurations for admins to set.
Please don't expect us to provide Ping Wheel users with a plugin in the near future. We made the mod for fabric specifically and providing partial support for Bukkit would create extra stress on maintaining the mod.

Providing native support for Bukkit servers was mentioned during development but was discarded due to the lack of demand.
Reading your feature request provides us with more motivation to push such a plugin to production.
This plugin wouldn't be programmed for Paper or any other Spigot work specificly but in the Bukkit (Spigot) environment to provide support for every Bukkit fork.
We don't plan on restricting users by server-side configs in any way. If such a plugin would be created natively there wouldn't be any user-restricting configurations for admins to set.
Please don't expect us to provide Ping Wheel users with a plugin in the near future. We made the mod for fabric specifically and providing partial support for Bukkit would create extra stress on maintaining the mod.

Providing native support for Bukkit servers was mentioned during development but was discarded due to the lack of demand.
Reading your feature request provides us with more motivation to push such a plugin to production.
This plugin wouldn't be programmed for Paper or any other Spigot work specifically but in the Bukkit (Spigot) environment to provide support for every Bukkit fork.
We don't plan on restricting users by server-side configs in any way. If such a plugin would be created natively there wouldn't be any user-restricting configurations for admins to set.
Please don't expect us to provide Ping Wheel users with a plugin in the near future. We made the mod for fabric specifically and providing partial support for Bukkit would create extra stress on maintaining Ping Wheel.

Hello again..
My keyboard stumbled over my cat and somehow this repo got released?
You can also download the plugin on CurseForge when it gets approved by the moderators.
Modrinth and SpigotMC will follow soon.

Thats so cool! Thanks a lot!

Hope you tested it already and it works as intended on the mentioned bukkit forks.

Just to avoid confusion. This plugin didn't work until 4 days ago.


Dummy pull request to test out stuff about signoffs

Dummy pull request to test out stuff about signoffs

Should this PR be closed?


Lagging in v-on:change

I had an input with v-on:change directive in it to call some method I declared inside the Vue objects. But I realized there are delays in calling the method whenever the value is changed.
I reproduced it in here:
https://jsfiddle.net/lookman/4y2wmxot/2/

Okay. Browsers will not fire a change event until the item loses focus. Using input event seems working better

@luqmanrom Yes 😄


Formstack Forms v1

Please check the following conditions for your PR.

[x] apiDefinition.swagger.json is validated using paconn validate command.
[x] apiProperties.json has a valid brand color. Invalid brand colors are #007ee5 and #ffffff.

Hey @dougelliott - do you need anything from us to assist with the code review here? Looking forward to getting Forms submitted in ISV studio!

Hey @dougelliott - do you need anything from us to assist with the code review here? Looking forward to getting Forms submitted in ISV studio!


Unexpected HTTP Caching on Real Devices but not on Emulator

Steps to Reproduce
I'm using dart:io HttpClientRequest
My Web Server returns an ETag, so a client might want to cache the response,
but I couldn't find any docs on how to disable caching on client side.
The caching happens on an Android API 25 Device, but on an API 23 Emulator, the response is not cached.
Should I add a cache-control: no-cache header to my response from server or is this configurable from client side?

This should be in the documentation, for people to know the behaviour of the client. And, be able to configure this, would be nice too.

I don't think there is a good place for us to document Android specific behavior around the network. If anywhere the best place to document this might be https://docs.flutter.dev/data-and-backend/networking
If you'd like to ask for more flutter documentation you can file an issue at https://github.com/flutter/website
Since there are no code changes we can make here I'll close this for now. cc @brianquinlan in case you think I'm overlooking anything.


PHP: PHAR fails to compile for some benchmarks

php-bug-2011-10-15-0a1cc5f01c-05c5c8958e

Similar issue: https://bugs.php.net/bug.php?id=50400

Can be averted by configuring with --disable-phar, but this may skip some important, possibly negative test cases.

Addressed in new version of PHP benchmarks


Registry: accessibility fix list

resolve https://github.com/open-telemetry/opentelemetry.io/issues/1637

Accessibility Insights for Web

@chalin , @cartermp: can you double check if that works for you, thanks.


Support customizing branches in mono_repo.yaml

Acknowledged
On Mon, Sep 24, 2018 at 7:14 AM Jacob MacDonald<EMAIL_ADDRESS>wrote:

@jakemac53 commented on this pull request.
In mono_repo/lib/src/commands/travis.dart
https://github.com/dart-lang/mono_repo/pull/103#discussion_r219851059:

@@ -211,6 +211,17 @@ String _travisYml(RootConfig configs, Map<String, String> commandsToKeys) {
'${toYaml(configs.monoConfig.travis)}\n';
}

var defaultBranches = configs.monoConfig.travis.containsKey('branches')

nit: branchConfig, branches, something like that. The default is really
the string in the else here, not this variable.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/dart-lang/mono_repo/pull/103#pullrequestreview-158122855,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AABCirmAngDmxnSYCHe_1hFriRwr_Ecfks5ueOi9gaJpZM4W1bW4
.


Android issue with decimals

When I pay with a decimal number, the payment couldn't be finished. But if I pay a rounded number (like 10.00) it works fine.
Console logs:
[paypal.sdk] request failure with http statusCode:400,exception:Bad Request
[paypal.sdk] request failed with server response:{"name":"VALIDATION_ERROR","details":[{"field":"transactions.item_list.items","issue":"Currency amount must be non-negative number, may optionally contain exactly 2 decimal places separated by '.', optional thousands separator ',', limited to 7 digits before the decimal point and currency which is a valid ISO Currency Code"}],"message":"Invalid request - see details","information_link":"https://developer.paypal.com/docs/api/#VALIDATION_ERROR","debug_id":"b35d95054f98c"}
[paypal.sdk]
[paypal.sdk] VALIDATION_ERROR

@javiholcman it will be great if you can give me more details about this issue ie. Android OS version, device language and also which PayPal.Forms versions are you using?

@AlejandroRuiz I am using a Spanish language on a S6 device of Genymotion and the 2.0.4 version of Paypal.Forms.

I have exactly the same error from a Samsung Galaxy Tab 2.

This is the array that I am sending:

And here is the output...
06-24 15:22:12.550 D/SRIB_DCS(29308): log_dcs ThreadedRenderer::initialize entered!
06-24 15:22:12.550 D/PhoneWindow(29308): FMB isFloatingMenuEnabled mFloatingMenuBtn : null
06-24 15:22:12.550 D/PhoneWindow(29308): FMB isFloatingMenuEnabled return false
06-24 15:22:12.600 D/SRIB_DCS(29308): log_dcs ThreadedRenderer::initialize entered!
06-24 15:22:12.690 I/Timeline(29308): Timeline: Activity_idle id: android.os.BinderProxy@34e35df9 time:16083758
06-24 15:22:14.290 W/paypal.sdk(29308): fg SN:11 PayPal Debug-ID: ef4a37d1b1be8 [sandbox, 2.14.1;release]
06-24 15:22:14.290 E/paypal.sdk(29308): request failure with http statusCode:400,exception:Bad Request
06-24 15:22:14.300 E/paypal.sdk(29308): request failed with server response:{"name":"VALIDATION_ERROR","details":[{"field":"transactions.item_list.items","issue":"Currency amount must be non-negative number, may optionally contain exactly 2 decimal places separated by '.', optional thousands separator ',', limited to 7 digits before the decimal point and currency which is a valid ISO Currency Code"}],"message":"Invalid request - see details","information_link":"https://developer.paypal.com/docs/api/#VALIDATION_ERROR","debug_id":"ef4a37d1b1be8"}
06-24 15:22:14.300 E/paypal.sdk(29308):
06-24 15:22:14.300 E/paypal.sdk(29308): VALIDATION_ERROR
06-24 15:22:14.330 D/PhoneWindow(29308): FMB installDecor mIsFloating : true
06-24 15:22:14.330 D/PhoneWindow(29308): FMB installDecor flags : 8388610
06-24 15:22:14.330 W/ResourceType(29308): Failure getting entry for 0x01080ad9 (t=7 e=2777) (error -75)
06-24 15:22:14.340 D/ViewRootImpl(29308): Buffer Count from app info with  ::-1 && -1 for :: com.elfo.visionshop from View :: -1 DBQ Enabled ::false false
06-24 15:22:14.350 D/PhoneWindow(29308): FMB isFloatingMenuEnabled mFloatingMenuBtn : null
06-24 15:22:14.350 D/PhoneWindow(29308): FMB isFloatingMenuEnabled return false
06-24 15:22:14.380 D/SRIB_DCS(29308): log_dcs ThreadedRenderer::initialize entered!
06-24 15:22:14.380 E/ViewRootImpl(29308): sendUserActionEvent() mView == null
Any workaround? :-)

@AlejandroRuiz could you reproduce it?

Definitely because of decimals - if you use rounded values, payment works. If you use decimals , eg 15.99, the payment fails. I tried using decimal.round(15.99,2) and other conversions but this is definitely occuring at the paypal.forms level.

Just wanna check if there are any workarounds for this while this is getting fixed (is it getting fixed ? )?

@javiholcman - have you tried using the paypal account (not sandbox) with this? I am going to try the non-sandbox to see if this is happening in the normal paypal accounts (to check if it affects there too). But if you have already tried the normal paypal account, please let us know so that we can cross this test off the list).

Hi @kevinleungwork. No I don't. In my case I don't need to use decimals. We just rounded values. Sorry.

@javiholcman - thanks for your prompt reply and sharing your findings :) . I will let you guys know what was my outcome. Sadly, in my case, I have to cover transactions using cents or pennies (hence the issue with decimals).

@kevinleungwork did you have any code example about your usage and your android device system config, I tried to replicate the @fcogutierrez  and @javiholcman issue using Spanish(Spain) and using EUR and NOK money type and everything is working fine on my side so i need more insights to replicate this issue

@AlejandroRuiz - Hello Alejandro, Thank you for your prompt reply. Actually, I have just connected my project with the nuget package (paypal forms 2.06) and I followed:
https://libraries.io/nuget/PayPal.Forms
I initialised with my paypal sandbox id for the app:
global::Xamarin.Forms.Forms.Init ();
CrossPayPalManager.Init(new PayPalConfiguration(
PayPalEnvironment.NoNetwork,
"Your PayPal ID from https://developer.paypal.com/developer/applications/"
)
{
//If you want to accept credit cards
AcceptCreditCards = true,
//Your business name
MerchantName = "Test Store",
//Your privacy policy Url
MerchantPrivacyPolicyUri = "https://www.example.com/privacy",
//Your user agreement Url
MerchantUserAgreementUri = "https://www.example.com/legal"
}
);
I added:
I reused the paypal tests you used inside a click event:
async void BuyManythingsCustomAddressButton_Clicked(object sender, EventArgs e)
{
var result = await CrossPayPalManager.Current.Buy(
new PayPalItem[] {
new PayPalItem ("sample item #1", 2, new Decimal (87.50), "HKD", "sku-12345678"),
new PayPalItem ("free sample item #2", 1, new Decimal (0.00), "HKD", "sku-zero-price"),
new PayPalItem ("sample item #3 with a longer name", 6, new Decimal (37.99), "HKD", "sku-33333")
},
new Decimal(12.55),
new Decimal(13.20),
new ShippingAddress("My Custom Recipient Name", "Custom Line 1", "", "My City", "My State", "12345", "MX")
);
if (result.Status == PayPalStatus.Cancelled)
{
Debug.WriteLine("Cancelled");
}
else if (result.Status == PayPalStatus.Error)
{
Debug.WriteLine(result.ErrorMessage);
}
else if (result.Status == PayPalStatus.Successful)
{
Debug.WriteLine(result.ServerResponse.Response.Id);
}
}
I changed:

USD to HKD (but both USD and HKD throw this error)
I just used my paypal sandbox client ID (as no username or password needed by your solution), and the sandbox has been credited to HK$99999
FOr my android emulator, I am using android 5 and also used 1gb of memory in my visual studio environment.

Actually, not many changes to be honest.
SO what happens when the above code section executes is that I get a paypal sign in, which I can fill in, and then it starts processing, and at that point, it throws the error about the payment not being valid (and it only happens when the total amount sent to paypal has decimal values - for round numbers with no decimals, there are no issues).

@kevinleungwork which language and country did you have set on your Android device?

@AlejandroRuiz here you have a solution with every configured. You will be able to reproduce the decimals issue quickly :-)
POC.zip

@AlejandroRuiz - Thank you for your help.
I am using English on my android emulator and the country, I checked the locale and it is 'US' on the emulator.
I also just checked and to be precise, the android is 5.1.1.

@javiholcman @fcogutierrez @kevinleungwork this is now fixed on version which will be available in nuget right now if you get another error please check next link https://github.com/paypal/PayPal-Android-SDK/search?q=request+failure+with+http+statusCode%3A422%2Cexception%3AUnprocessable+Entity&type=Issues&utf8=✓ this happen due a misconfigured Paypal sandbox-live user account please close the ticket if your issue is now solved

Hi @AlejandroRuiz.
First of all, THANKS A LOT for your work :)
I updated the library but I get this message:
07-29 11:34:21.315 E/paypal.sdk(31350): request failure with http statusCode:422,exception:Unprocessable Entity
07-29 11:34:21.315 E/paypal.sdk(31350): request failed with server response:{"name":"PAYMENT_CREATION_ERROR","debug_id":"fd2957722489d","message":"checkout-session not created","information_link":"https://developer.paypal.com/docs/api/#PAYMENT_CREATION_ERROR"}

Please read my previous notes

@AlejandroRuiz  I already read your notes and visited the link but I do not see any helpful there...

@fcogutierrez as the Paypal guys said in that threads that issue is related with a differents types of issues if you want to test it successfully use USD instead of NDK , wait until the Paypal guys give you information related of your debug_id or try creating a new sandbox config

Strange, but with "USD" instead of "NOK" it works perfectly... :S

Thanks a lot for your help and quick response @AlejandroRuiz .
However, for me, I am still facing an issue
Trying this code for a payment in the sandbox:
protected async void performPayment()
{
var result = await CrossPayPalManager.Current.Buy(new PayPalItem[] {
new PayPalItem ("sample item #1", 2, new Decimal (87.50), "USD",
"sku-12345678"),
new PayPalItem ("free sample item #2", 1, new Decimal (0.00),
"USD", "sku-zero-price"),
new PayPalItem ("sample item #3 with a longer name", 6, new Decimal (37.99),
"USD", "sku-33333")
}, new Decimal(20.5), new Decimal(13.20));
if (result.Status == PayPalStatus.Cancelled)
{
//Debug.WriteLine("Cancelled");
}
else if (result.Status == PayPalStatus.Error)
{
//Debug.WriteLine(result.ErrorMessage);
}
else if (result.Status == PayPalStatus.Successful)
{
//Debug.WriteLine(result.ServerResponse.Response.Id);
}
}
this now returns this error:

I researched about this error, and it mentions that .Net 4.6 made a change to this function (currently, I am still on .Net 4.5 in my project). I need to test further on this...

I'll check in a free time on VS/Win since im using XS/Mac

@AlejandroRuiz - thank you for your kind help. Greatly appreciate it :-). I will keep checking what is wrong on my end too, and share any findings.

Hi @AlejandroRuiz , I found that the error occurs in :+1:  var result = await CrossPayPalManager.Current.Buy(new PayPalItem[] {
new PayPalItem ("sample item #1", 2, new Decimal (87.50), "USD",
"sku-12345678"),
new PayPalItem ("free sample item #2", 1, new Decimal (0.00),
"USD", "sku-zero-price"),
new PayPalItem ("sample item #3 with a longer name", 6, new Decimal (37.99),
"USD", "sku-33333")
}, new Decimal(20.5), new Decimal(13.20));
The 'String.Format not found' occurs there (before even logging to Paypal - the error in version 2.06 allowed the login to paypal first and then threw 'payment information is invalid' , but in this new version, the error 'String.Format not found' occurs before the paypal login and just after triggering the 'CrossPayPalManager.Current.Buy' method.
I hope this helps. I am using visual studio 2015 and xamarin on that environment, on a windows machine (it is not ideal and visual studio has been slowing degrading in quality), but it would still be nice to have it working on visual studio.
Thanks for your help!

@AlejandroRuiz - I have repaired my vs (because I suspected the String.Format issue seemed to originate from the native libraries) and xamarin and it is now working. It seems my vs installation had a slight issue.
Thanks a lot for your help and this great component! I will continue to test it and share any issues here if any.

hey Guys This Thread is very useful for me. and i am asking one question i am not getting any return success message or any return values from PayPal in xamarin forms. here PayPal logging in then payment after payment not getting any success message.
i am using the PayPal configuration like this(below code)
var result = await CrossPayPalManager.Current.Buy(new PayPalItem("Test Product", new Decimal(12.50), "USD"), new Decimal(150.30));
if (result.Status == PayPalStatus.Cancelled)
{
Debug.WriteLine("Cancelled");
}
else if (result.Status == PayPalStatus.Error)
{
Debug.WriteLine(result.ErrorMessage);
}
else if (result.Status == PayPalStatus.Successful)
{
Debug.WriteLine(result.ServerResponse.Response.Id);
}
Thanks in Advance

@sureshtest what is the Environment that you have, also provide a console output about your issue and if there a new issue please create another ticket for that, don't put any not-related data for tickets

Hi @AlejandroRuiz After completion of payment balance is not increasing of my merchant account.But Status Always come success . I sent my App client Id in PayPalConfiguration under your paypald is this correct ?


implement python method to convert E-field values to photon number density

We've decided to use the 'arbitrary units' setting in SRW, so that we can use SI units for our calculations.
The following sub-issues need to be resolved:

[ ] from user-specified pulseE [J] and laser pulse dimensions; infer the correct multiplicative factor to obtain E [V/m] from SRW
[ ] for an SRW wavefront, wavelength & slice width (in [s] or [m]), calculate the number of photons in each grid cell

A secondary consideration is where on the cell (side, vertices, center) are the E-field values are known.
Initially, we can assume they are known in the cell centers.

Start by creating a notebook to demonstrate.

In the LaserPulseSlice constructor, the ds variable should be self.ds so that the slice length can be obtained.
For now, a work around is to use self.num_sig_long, self.sig_s and the number of slices to calculate this externall.
pulseE is specified in the params object for LaserPulseSlice, which I think is kind of strange.
It would be more natural to specify the energy in the LaserPulse as a whole, although either approach can work.
Our working model is that slices do not have longitudinal structure, so one must assume each slice is a flat top.
If one specifies a single slice, then this is obviously wrong.
However, maybe that's OK, because a single-slice representation is not going to be accurate in any case.
We want the algorithm to work well in the limit that N >> 1

@k-wolfinger -- please check whether the wavefront intensity that results from a single-slice instantiation is consistent with the user-specified value of self.pulseE

Neither the LaserPulse nor the LaserPulseSlice constructors are creating a data member from pulseE, so it is not possible to query a pulse or a slice for its energy.

Currently not passing information on the pulse length to srw. Fix this by multiplying pulseE by a factor proportional to the length of the slice.


Copy the error in problems view

VSCode Version: Code 1.14.2 (cb82febafda0c8c199b9201ad274e25d9a76874e, 2017-07-19T23:22:50.650Z)
OS Version: Darwin x64 16.4.0
Extensions: the listing length exceeds browsers' URL characters limit

Steps to Reproduce:

Create a python file and add some problematic code
from requests import hello
The problems view says No name 'hello' in module 'requests'

When I right click on copy this problem it copies the following:
file: 'file:abc.py'
severity: 'Error'
message: 'E0611:No name 'hello' in module 'requests''
at: '5,1'
source: 'pylint'

Possible to expose another copy command to copy just the error itself for quick googling? This is a feature request and probably low priority. Still wanted to document and get feedback.

Reproduces without extensions: Yes

Added a new action to context menu to copy message


refactor: add PreviewTextLazyLoad as external plugin to application configuration

add config to conjoon for extjs-app-webmail


Enable randomization in the queuing strategy

What would you like to be added:
Aside from StrictFIFO and BestEffortFIFO , allow randomized admission of queued workloads.
Why is this needed:
Today, we encourage users to submit as many workloads as possible to saturate the queue resources. However, this could lead to imbalanced admission of workloads based on FIFO for preemptible workloads.
Completion requirements:
This enhancement requires the following artifacts:

[ ] Design doc
[x] API change
[ ] Docs update

The artifacts should be linked in subsequent comments.

Today, we encourage users to submit as many workloads as possible to saturate the queue resources. However, this could lead to imbalanced admission of workloads based on FIFO for preemptible workloads.

This is interesting, I would like to explore your setup to better understand the expectations.
Do you mean that userA is faster to send the jobs than userB and they block the queue of userB for a prolonged time? If so, is it because userA and userB are in different time-zones?
Resolving this type of imbalances is one of the objectives of the Fair Sharing - it will be released in 0.7, we are yet going to add some user-facing docs.
I would also like to know if you have generally short- or long-running jobs? Do you use same priority for all of them?

/cc @mwielgus @alculquicondor

Do you mean that userA is faster to send the jobs than userB and they block the queue of userB for a prolonged time? If so, is it because userA and userB are in different time-zones?

Yes, userA could submit all his jobs all at once to the preemptible queues prior to userB; it's not necessarily time zone based issue, since a lot of the jobs are adhoc runs.

I would also like to know if you have generally short- or long-running jobs? Do you use same priority for all of them?
Jobs tend to be long running ~ 10 hr, and currently we set the same priority for preemptible jobs.

Thanks @mimowo , could you point me to the PRs for this feature? I can test it out on our end as well.

Thanks @mimowo , could you point me to the PRs for this feature? I can test it out on our end as well.

I think a good entry point might be the API PR: https://github.com/kubernetes-sigs/kueue/pull/2070.
AFAIK @alculquicondor is working on some docs for 0.7.

Fair sharing is documented here https://kueue.sigs.k8s.io/docs/concepts/preemption/#fair-sharing
I suppose that, with that, this feature request is no longer needed.
Please reopen with more details if you disagree.
/close


Extra tick mark when using livesearch in Bootstrap 4

As you can see in the gif, when using liveSearch, and clicking on an option, the highlighted option gets a tick as well. This is with bootstrap 4, Firefox and Chrome.

Bug reports must include a live demo of the problem. Per our contributing guidelines, please create a reduced test case via Plunker, jsFiddle, CodePen or JS Bin, and report back with your link, Bootstrap version, bootstrap-select version, and specific browser and OS details.
This seems like an issue that was fixed in v1.13.2 (#2027).

Bug reports must include a live demo of the problem. Per our contributing guidelines, please create a reduced test case via Plunker, jsFiddle, CodePen or JS Bin, and report back with your link, Bootstrap version, bootstrap-select version, and specific browser and OS details.
This seems like an issue that was fixed in v1.13.2 (#2027).

I have updated my post with a live demo. It is different from the issue you linked. Thanks!

Looks like this was introduced in v1.13.2.

It appears that the first, highlighted option is not actually selected, it's just erroneously given a checkmark.

I've pinpointed the problem. Should be fixed in the next release.


reCAPTCHA fails to render same reCAPTCHA-id on the same page

We have the contact form two places on the same page, and when reCAPTCHA tries to render it get's this:

And this is because in the recaptcha_v2_invisible.js you use the recaptchaContainer.id instead of just the dom element. ref container in the documentation here
[edit]: i get this on the checkbox version also.
So in my case it tries to add the same id two times, and it fails.
Could you test this to see if this is the case?

Thanks for the details @espensgr. It does look like we should just be using the container there. I'll take a closer look and update this thread when I have more.

And it looks like you have PR waiting for me already!

Yeah, thought that would be easier 😄

This is added in v1.4.1


show compare shows wrong diff

When we have local changes not yet committed and we do a device pull a 'show compare' wrongly shows a diff from the device that was just pulled. In this example a prefix list was already deleted on the device that was pulled before attempting to commit:
snc@snc-lab[/]# show compare
   clixon-controller:services {
-     prefix-filter:prefix-filter as2839 {
-        filter-name pfxl-ripe-as-kth;
-        ip-version ipv4;
-        as-macro AS-KTH;
-        irr-sources [
-           RIPE
-       ]
-        manual-prefixes [
-           <IP_ADDRESS>/32
-       ]
-        device-groups [
-           ALL
-       ]
-     }
   }
               policy-options {
+                 prefix-list pfxl-ripe-as-kth {
+                    prefix-list-item <IP_ADDRESS>/32 {
+                    }
+                    prefix-list-item <IP_ADDRESS>/18 {
+                    }
+                    prefix-list-item <IP_ADDRESS>/18 {
+                    }
+                    prefix-list-item <IP_ADDRESS>/24 {
+                    }
+                    prefix-list-item <IP_ADDRESS>/24 {
+                    }
+                    prefix-list-item <IP_ADDRESS>/24 {
+                    }
+                    prefix-list-item <IP_ADDRESS>/24 {
+                    }
+                    prefix-list-item <IP_ADDRESS>/24 {
+                    }
+                    prefix-list-item <IP_ADDRESS>/24 {
+                    }
+                    prefix-list-item <IP_ADDRESS>/24 {
+                    }
+                    prefix-list-item <IP_ADDRESS>/24 {
+                    }
+                    prefix-list-item <IP_ADDRESS>/24 {
+                    }
+                    prefix-list-item <IP_ADDRESS>/24 {
+                    }
+                    prefix-list-item <IP_ADDRESS>/24 {
+                    }
+                    prefix-list-item <IP_ADDRESS>/24 {
+                    }
+                    prefix-list-item <IP_ADDRESS>/24 {
+                    }
+                    prefix-list-item <IP_ADDRESS>/24 {

This has been fixed already