The Tab-Completion for cmdline mode, i.e. :, seems to be broken after the last update.

FAQ

[X] I have checked the FAQ and it didn't resolve my problem.

Issues

[X] I have checked existing issues and there are no open or closed issues with the same problem.

Neovim Version
NVIM v0.7.0-dev+890-g574a58220
Minimal reproducible config
use {
  'hrsh7th/nvim-cmp',
  requires = {
    'neovim/nvim-lspconfig',
    'hrsh7th/cmp-nvim-lsp',
    'hrsh7th/cmp-buffer',
    'hrsh7th/cmp-path',
    'hrsh7th/cmp-nvim-lua',
    'hrsh7th/cmp-vsnip',
    'hrsh7th/vim-vsnip',
    'onsails/lspkind-nvim'
  },
  config = function()
    local cmp = require'cmp'
    cmp.setup {
      snippet = {
        expand = function(args)
          vim.fn["vsnip#anonymous"](args.body)
        end
      },
      mapping = {
        -- <option-shift-P/N>
        ['<C-S-p>'] = cmp.mapping.scroll_docs(-4),
        ['<C-S-n>'] = cmp.mapping.scroll_docs(4),
        ['<C-o>'] = cmp.mapping.complete(), -- O for Open: This will open completion menu.
        ['<C-c>'] = cmp.mapping.close(), -- C for Close: This will close completion menu.
        ['<C-y>'] = cmp.mapping(
          cmp.mapping.confirm {
            behaviour = cmp.ConfirmBehavior.Insert,
            select = true
          }, { "i", "c" }
        ),
        -- Tab Completion.
        ['<Tab>'] = cmp.mapping(cmp.mapping.select_next_item(), { 'i', 's' }),
        ['<S-Tab>'] = cmp.mapping(cmp.mapping.select_prev_item(), { 'i', 's' })
      },
      sources = {
        { name = 'nvim_lua' },
        { name = 'nvim_lsp' },
        { name = 'vsnip' },
        { name = 'buffer', keyword_length = 2 },
        { name = 'path' },
      },
      sorting = {
        -- WARNING: Copy-paste from https://github.com/tjdevries/config_manager/blob/master/xdg_config/nvim/after/plugin/completion.lua
        comparators = {
          cmp.config.compare.offset,
          cmp.config.compare.exact,
          cmp.config.compare.score,

          -- copied from cmp-under, but I don't think I need the plugin for this.
          -- I might add some more of my own.
          function(entry1, entry2)
            local _, entry1_under = entry1.completion_item.label:find "^_+"
            local _, entry2_under = entry2.completion_item.label:find "^_+"
            entry1_under = entry1_under or 0
            entry2_under = entry2_under or 0
            if entry1_under > entry2_under then
              return false
            elseif entry1_under < entry2_under then
              return true
            end
          end,

          cmp.config.compare.kind,
          cmp.config.compare.sort_text,
          cmp.config.compare.length,
          cmp.config.compare.order,
        }
      },
      formatting = {
        format = require'lspkind'.cmp_format({
          with_text = true,
          menu = ({
            buffer = "[buf]",
            path = "[dir]",
            nvim_lsp = "[lsp]",
            nvim_lua = "[lua]",
            vsnip = "[vsnip]",
          })
        })
      },
      experimental = {
        native_menu = false,
        ghost_text = false,
      }
    }
  end
}

Description
In short, now completion in the cmdline won't work. I remove this plugin and it works.
As described in https://github.com/neovim/neovim/issues/17098
Steps to reproduce
Hit :, type something half-done, and then try <Tab> to auto-complete.
Expected behavior
can
Actual behavior
can't
Additional context
No response

already fixed.

@hrsh7th: it seems to still happen in my case.

Oh... Sorry. I understood your issue. I'll investigate it...

After the last update, for me, it started working, but only partially. Completion with arrows works, but with Tab I have some strange symbols instead of actual completion.

I've reverted the keymap handling commits. Sorry for annoying. I think now it works.

I thought I messed up my dots while I was configuring my dots hahaha. Thanks for fast resolution @hrsh7th! It's working now.

@peeeyow: Dotfile-panic.

I will continue to work on improving key mapping...

Thanks @hrsh7th!!! 🎉


Workspace Scheduling Controller

Signed-off-by: Steve Kuznetsov<EMAIL_ADDRESS>

Depends on

https://github.com/kcp-dev/kcp/pull/215
https://github.com/kcp-dev/kcp/pull/218

@ncdc @sttts @davidfestal @imjasonh @smarterclayton ready for review - the actual logic of the controller is not super well defined, so mostly looking for feedback on the e2e and overall approach

@ncdc @sttts addressed the simpler comments, broke into more commits that can be split out of this PR and/or for review

Needs https://github.com/kcp-dev/kcp/pull/258 for real verification but otherwise this addressed all comments

Giving it one more quick look

Going to merge. If we need to fix anything, can do in a follow-up.


Diff Drive Demo not loading diff_drive_controller

I am trying to run the diff drive demo but the diff_drive_controller doesn't load.  I run ros2 launch ros2_control_demo_robot diffbot_system.launch.py and it start successfully.   Checking the loaded controllers with ros2 control list_controllers, only joint_state_broadcaster[joint_state_broadcaster/JointStateBroadcaster] active is shown.  I can load it manually but it stays inactive.  Any insights to how to get the controller loading on start?

Dear @tonybaltovski Thanks for the report.
Could you confirm that you have the following exception in the terminal where you launched the demo:
[ros2_control_node-1] ros2_control_node: /opt/ros/foxy/include/rcppmath/clamp.hpp:41: constexpr const T& rcppmath::clamp(const T&, const T&, const T&) [with T = double]: Assertion !(hi < lo)' failed.` ?
I run into a similar problem and found a possible fix. But I still need to track down the root of the problem.

@olivier-stasse that does not seem to be the issue.  The node does not crash.

Pulling in the recent changes fixed the issue.  I do believe it could be an issue with name spacing in ros2_controllers but haven't got a chance to investigate it.

@tonybaltovski glad that the recent changes fixed the issue.


Fix header for search engines

Currently the header title and meta info is not visible by search engines, check the php code and / or use https://alligator.io/vuejs/vue-seo-tips/

replaced with php values, lets see...

works


[Bug] Unable to correctly verify the Flink cluster URL

Search before asking

[X] I had searched in the issues and found no similar issues.

Java Version
1.8
Scala Version
2.12.x
StreamPark Version
2.1.1
Flink Version
1.14.5
deploy mode
remote
What happened
When creating a new Flink cluster, if an incorrect cluster URL is entered, it can also pass the verification. Here is an example of a correct URL demonstration and two error demonstrations:

When an incorrect cluster is configured, it can cause trouble for future use.
Error Exception
no exception

Screenshots
as above
Are you willing to submit PR?

[X] Yes I am willing to submit a PR!(您是否要贡献这个PR?)

Code of Conduct

[X] I agree to follow this project's Code of Conduct

fixed in new version


fix url for capture-download

fix this:

fixed: when serving behind a proxy, simply put this in your settings.py:
USE_X_FORWARDED_HOST = True
SECURE_PROXY_SSL_HEADER = ('HTTP_X_FORWARDED_PROTO', 'https')


update AboutUs and rename .adoc

Pull Request Test Coverage Report for Build 403

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 77.755%

Totals

Change from base Build 402:
0.0%

Covered Lines:
1856

Relevant Lines:
2387

💛  - Coveralls


Java 16+ support

What steps will reproduce the problem?

Success
What happens instead?
[INFO] --- git-code-format-maven-plugin:3.0:format-code (default-cli) @ projectname ---
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  0.394 s
[INFO] Finished at: 2021-07-02T13:19:12+02:00
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal com.cosium.code:git-code-format-maven-plugin:3.0:format-code (default-cli) on project projectname: Execution default-cli of goal com.cosium.code:git-code-format-maven-plugin:3.0:format-code failed: An API incompatibility was encountered while executing com.cosium.code:git-code-format-maven-plugin:3.0:format-code: java.lang.IllegalAccessError: class com.google.googlejavaformat.java.JavaInput (in unnamed module @0x73d3e555) cannot access class com.sun.tools.javac.parser.Tokens$TokenKind (in module jdk.compiler) because module jdk.compiler does not export com.sun.tools.javac.parser to unnamed module @0x73d3e555
[ERROR] -----------------------------------------------------
[ERROR] realm =    plugin>com.cosium.code:git-code-format-maven-plugin:3.0
[ERROR] strategy = org.codehaus.plexus.classworlds.strategy.SelfFirstStrategy

Environment:

OS: Arch Linux
Git version: 2.32.0
git-code-format-maven-plugin version: 3.0
Maven version: 3.8.1
Java version: 16.0.1

Additional context
https://github.com/google/google-java-format/issues/538
https://github.com/google/google-java-format/issues/612

It still doesn't work if I use 3.1. Is that possible that it's not been released?

@mudlee I can confirm that the fix is in 3.1.
You can see the tag at https://github.com/Cosium/git-code-format-maven-plugin/commit/62a8da70ffa5470584694bb1b739a3f323236119

@hashworks does it work for you on 3.1?

See the images below. I've already removed ~/.m2 and cleaned my env, no luck.

According to https://github.com/google/google-java-format/releases/tag/v1.10.0, java flags must be passed in addition.

According to https://github.com/google/google-java-format/releases/tag/v1.10.0, java flags must be passed in addition.

Thanks for the blazing fast help! May I ask how can I add these flags in a case of maven? I've tried  everything I know, but I cannot pass java args to the plugin :(

OK, prepending the mvnw cli with these below works!
MAVEN_OPTS="--add-exports jdk.compiler/com.sun.tools.javac.api=ALL-UNNAMED --add-exports jdk.compiler/com.sun.tools.javac.file=ALL-UNNAMED --add-exports jdk.compiler/com.sun.tools.javac.parser=ALL-UNNAMED --add-exports jdk.compiler/com.sun.tools.javac.tree=ALL-UNNAMED --add-exports jdk.compiler/com.sun.tools.javac.util=ALL-UNNAMED"

Is there a way to add those to the pom.xml or integrate them into the plugin?

The plugin can format/verify code at 2 occasions:

after a manual trigger
after a commit

To my knowledge, the only way to pass java options for the first case would be to fork a new VM (the same way maven surefire plugin can do). That looks really overkill.
Meanwhile, I think using https://maven.apache.org/configure.html#mvn-jvm-config-file should solve your issue.

I added https://github.com/Cosium/git-code-format-maven-plugin/blob/master/README.md#jdk-16-peculiarities to the README.


Add .clear() method

It would be useful to have a clear() method to reset the FilteredSpaceSaving data structure while keeping the allocated memory for reuse.

Added in 0.4.0

Wow, that was fast. Thank you! And thank you for creating this library.


Highlight entire Path on mouseover

Hi guys. Since this issue existed before #50 I feel it would be a better place to have a bit of a discussion.
Do you already have an idea in mind about how to visually highlight your paths ?
@superjox mentionned 'painting' them black, it could be one way, but if I've read correctly it would hide coloured info such as inversion and maybe annotations.
One way to highlight a given path could be to hide or diminish the visual intensity of other paths that we would not want to see, for instance turning all paths with the same greyish tone, except for those we'd like to be highlighted.
As space grouping is also a good way to attract the eye, it could be used too to make a focus on a given path. An empty space can always be useful.
Another/a supplementary option could be to attribute a colour to a given path, and stick with it, for the Structural Variation, but as a kind of halo too, maybe. This would only
work when paths have no SV in common though (else, what's going to happen when a Link is common to multiple path? Which colour to apply? Should we apply two of them alternating?).
Small draft examples below :

(Also, shouldn't there be Adjacent Links in the zone in the middle ? How come the Path is stopping with neither AL nor SV and starting again later? Maybe I've missed an explanation about this in the Specifications, though)

With in the zone you mean within one component?
If you mean the highlighted path, I can't see it stopping anywhere.
Please take a look at https://graph-genome.github.io/pantograph.html for further explanations.
If things are still unclear please open an issue at https://github.com/graph-genome/graph-genome.github.io. Thanks!

Ah, and I like the last highlighting type the best. If you hover over a link and highlight all corresponding paths by color, that is cool. But keep in mind that maybe we only one to highlight one specific path, then color would be misleading, because of the links.
Or we could highlight a path by texture?
This only makes sense when we draw a path with a sufficient height in pixels.

@subwaystation I followed your advice and opened a new issue: https://github.com/graph-genome/graph-genome.github.io/issues/18
That might not be much but at least it will keep this issue here clean.
A thing that could be interesting rather than highlighting paths on hovering Link, would be to sort them on the y axis on click, with the path having the given Link first. No colour problem and faster visual identification!
Sticking to the path highlighting thing:
When you say color would be misleading, do you mean because of the order of the Links for one Component ? Indeed if we keep one color for a path+affiliated Links, then it would be harder to follow the Links I guess.
Texture could be an answer, indeed.

good ideas. I actually like the grey out everything else best, since we can still see the annotations as @SingingMeerkat pointed out. Texture would be good as well, but can be hard to identify if cell height is small. I would reserve highlighting a row by a colored frame maybe for annotations with meta data.
I also like the idea of @SingingMeerkat to sort the paths on top that share a link (best would be also for variants, i.e. single bins). However please note, the default behavior of clicking on links should be to jump to the other end of it (#6).


Returned path length is off by one

According to documentation, the path length returned by wai_getExecutablePath is the actual number of characters without a terminating zero byte. Actually, at least on Windows, the value returned includes the trailing zero byte.
This can lead to bugs. For instance, when creating a string like this:
std::string path(buffer, length);

The result is a string with length length that (wrongly) contains a zero character as part of the string.
I see two possible solutions. If all platforms consistently add the zero byte, just the documentation needs to be changed. Otherwise, the individual implementations should be changed to behave consistently.

I believed that's addressed by ba75d51713a5a0eb8e617a28dcff4998f96b85e2 that fixes #5?

Consider this a duplicate.

Sorry for the inconvenience


Auto update schemas

Automatically update the schemas in the task standard. Addresses https://github.com/METR/vivaria/issues/418
This will regenerate all the schemas, and push any changes to the current branch (so the one in the PR)
Testing:

manual test instructions: change one of the added schema files (but in a way that prettier won't complain) and it should be changed right back

I confess that I wouldn't know how to update my IDE to use these JSON Schemas. How about documenting that?

I confess that I wouldn't know how to update my IDE to use these JSON Schemas. How about documenting that?

I'm afraid I have even less of an idea than you do :D Sami mentioned schemastore for this, but that seems an additional step

Taking this over in https://github.com/METR/vivaria/pull/541


Cacti 1.2.25 and Weathermap 0.98a

Just updated from Cacti 1.2.23 to 1.2.25 and all of a sudden i see this in the logs.. however it doesnt affect weathermap operations.. is there a way to clear this? Running Weathermap 0.98a
PLUGIN WARNING: Plugin 'weathermap' is attempting to call 'api_plugin_register_realm' improperly in function 'weathermap_config_arrays'

We welcome pull requests.  Please create one.

sorry, im not really a developer so im not sure what you mean by pull request, but i did try to go to the option of a pull request and its just greyed out for me and nothing else to select so im not sure what im exactly doing.
Im just trying to contribute to make the newer version better.

It's not the complicated.  Click on the 'fork' word in the top right, and GitHub will make a copy under your account.  Then go to the files in the location and Edit the file that needs to be changed.  Once you are done making changes, a button should show up to "Contribute" or "Create Pull Request" where you can contribute your minor changes back to the Cacti version of the Repo.  Give it a shot.

ok thanks, i worked it out should see it.
What about inside cacti weathermap tab options, what file is that kept in? (one i screenshot)

Usually the setup.php.  look for config_settings hook.

ok i found it in setup.php in weathermap plugin.. when you make the changes manually in the cacti tab "configuration > settings> Weathermap", where are they changes actually saved in, what file?

Nothing left to do I think.  Pull requests are always welcome.


Added horusec-config file icon

Changes proposed:

[X] Add
[ ] Delete
[ ] Fix
[ ] Prepare

Icon for configuration of Horusec, this an open source tool that orchestrates other security tools and identifies security flaws or vulnerabilities in projects and put all results in a database for analysis and generation of metrics.

@lucasbrunozup I tried to optimize it according to our guidelines but for some reason I can't use it in illustrator. It seems that it doesn't recognize de vector paths. @KingDarBoja can you take a look at it to see if it's something related to my illustrator version? Once this is solved we can merge it.

@lucasbrunozup I tried to optimize it according to our guidelines but for some reason I can't use it in illustrator. It seems that it doesn't recognize de vector paths. @KingDarBoja can you take a look at it to see if it's something related to my illustrator version? Once this is solved we can merge it.

I used figma to create it, maybe that's why.
What specifically are the adjustments that need to be made? I fix it, I send it again.

@lucasbrunozup I tried to optimize it according to our guidelines but for some reason I can't use it in illustrator. It seems that it doesn't recognize de vector paths. @KingDarBoja can you take a look at it to see if it's something related to my illustrator version? Once this is solved we can merge it.

I used figma to create it, maybe that's why.
What specifically are the adjustments that need to be made? I fix it, I send it again.

We are using the following settings at Illustrator: https://github.com/vscode-icons/vscode-icons/wiki/Contributing
It is missing the title and since the icon is smaller, I don't think we need a gradient but rather plain colours.

@lucasbrunozup I tried to optimize it according to our guidelines but for some reason I can't use it in illustrator. It seems that it doesn't recognize de vector paths. @KingDarBoja can you take a look at it to see if it's something related to my illustrator version? Once this is solved we can merge it.

I used figma to create it, maybe that's why.
What specifically are the adjustments that need to be made? I fix it, I send it again.

We are using the following settings at Illustrator: https://github.com/vscode-icons/vscode-icons/wiki/Contributing
It is missing the title and since the icon is smaller, I don't think we need a gradient but rather plain colours.

I adjusted the size and color of the icon.

Do we have any more pending issues preventing the merge?

Do we have any more pending issues preventing the merge?

Nope, just wait a little bit as we as maintainers are a bit busy at the time being for providing a new release 😊


teleport: 2.4.1 -> 3.1.8

Motivation for this change
#57860
Things done
Updated version and SHA.

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[x] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Assured whether relevant documentation is up to date
[ ] Fits CONTRIBUTING.md.

Really dislike how this application needs root to write to /var/lib.

@GrahamcOfBorg build teleport

@worldofpeace probably an issue for upstream or a service module. Or do you think it needs to be addressed in this packaging?

@worldofpeace probably an issue for upstream or a service module. Or do you think it needs to be addressed in this packaging?

homebrew has done something interesting https://github.com/Homebrew/homebrew-core/blob/master/Formula/teleport.rb
I don't think it resolves that issue completely, so maybe it should be left alone for now.
And yes service a module would improve this.


Migrate General section functionality to the app level settings page.

Resolve #994
This PR update general section and model of general section in setting page
Screenshot

the app level security should be accessed from to navigation tab.


Dedup implementation of operator module

Right now the operator module duplicates all typing declarations and definitions for built-in operators. This is cumbersome and annoying to extend; we should find a way to infer the operator module's typing from the already well-known typing of built-in operators, instead.

This is now done.


Add back query support

Previous versions has a basic query implementation. Which is highly useful. But is removed in current version.
Manas used it to implement n3-solid-insert-delete-patch support. Currently it copied query code from previous version into the same rdf_utils package, and uses that. If sophia provides it natively, it would be great.

that's a good point. When I started the v0.8 refactoring, I first removed all the non-essential crates, adding them back gradually. I'll consider adding this one sooner rather than later.

Sorry for messing with issue.
Indeed that would also be great.
To be frank, it will also enable sparql-update support. https://github.com/manomayam/manas/issues/36

there it is: https://crates.io/crates/sophia_sparql
enjoy :)
NB: for sparql-update, we are not there yet 😅


Disable jobs using unstable runners for maintenance.

The nodai-amdgpu-mi300-x86-64 and nodai-amdgpu-w7900-x86-64 runners have been unstable since around last Friday:

losing connection with GitHub
accepting jobs then never starting them, resulting in some 6 hour+ queues that eventually failed with timeouts
needing magic scripts run to get a working GPU (this was technically fixed, but needs a stable solution)

The nodai-amdgpu-mi250-x86-64 runner seems to be stable for now, but it may also need to be taken offline to stabilize.
The nodai-amdgpu-mi250-x86-64 runner started reporting regressions in benchmark workloads with no code changes (e.g. attempt 1, attempt 2).
Disabling all jobs using those runners while we troubleshoot.

The runners are back online, so this isn't urgent. Will still probably want to disable jobs and take runners offline for maintenance/monitoring in some controlled way. Maybe not this week though.

This is stale so closing it. The runners are still unstable, but we can open new PRs for that.


Valorous and Conqueror's Deathbringer don't provide set bonus.

Describe the bug
A clear and concise description of what the bug is.
To Reproduce
Steps to reproduce the behavior:
Equip Valorous Deathbringer Robe and Conqueror's Deathbringer Hood in the WOTLK Warlock simulator and the set bonus does not show up as enabled.
Expected behavior
One should received the 2 piece set bonus for the Deathbringer Set.
Sim Links and Screenshots
https://wowsims.github.io/wotlk/warlock/#eJzjUuBgEmAyYLJg9GCMYCxgamBknMDIuIGR6QAj4wVGxheMjE7CHIwKTAaMFowOjAEgNYwrGBmFGKQmsTYxsgXkJFamFnGwCHBILWHk4hfY84JJ4o2sEtvRQ0y3djBxsQg0P2Xi4hHY+5xJ4pGsEvNnoBi7wO5dTBKT5YCq3z5ikvjBocS2bwfTR6AMl8Dth0wSc4SUGBm4eAWe7GaSmCKjxAI0h4GLU+DjHiYl5ltg/duAqtplQQygQdNkgLb07wPZtfMBiNy/C0S+2gtSeQZoxi9ZILcBLLhgG5MSFwcjyC8BrBGsi5jOMnHNYGIYBViBkAGpOqo4OBgFmCSYChizJLj4gGxmCUYFRg1ggDswSrEB+awSjF2MarpGBsZAZGxgaGBsamBoZApkGZsagQhDXVNTAxAwNXrEKMFx8ymTwNx2Zonbp5kUmi4zafy7xGTQeJkJmCo/MLLMYmTohEaepcMtRoZZTAxKT5k4wQINaQ6CECkRB8lZM0HgpL0lROSCvWIaGFyzN9rKpBAswaFF40TwodGBGsY0nDxCFXNIAZAw87nr4Ajh/7D3YExgDMKacapF1rk/rGqx57q+uMCW67i9x8MqkIg9RPaDPUzd4a8aMf2H3tp/A1FfH9i/Cdwh1/r6pT26eUMVkJ5xAFfrjzY=
Desktop (please complete the following information):

OS: Windows 10
Browser Chrome
Version 109.0.5414.75 (Official Build) (64-bit)

Additional context
I love you and thank you for your hard work.

It is implemented in the sim, the UI just isn't correctly showing it because wowhead separated the two set names. You can validate by swapping out the set item and putting in the same stats manually and you can see that immolate damage drops.


fix error log

Priority
Is this PR blocking your next action?
NO
Screenshot
Provide a screenshot, GIF, or video of the change if possible. People like pictures.

What Changed & Why
missing template string quotes to print out modelName

Fixed #124
@Emerson  can we get this and a few others merged and cut a new release

Let's do it!

@billxinli @Emerson thank you! 😺


feat: Fix CI build

Congratulations on the launch !
Just a couple CI things :

Uses setup-node v3 that has cache by default
Uses npm over yarn since your package.json uses npm

All things considered, running cabal build contract in CI is really long... Hopefully with docker layering it won't be rebuilding everything from scratch all the time and will be faster on the next runs

@Hebilicious Thank you! I'm gonna check it out later or tomorrow👍🏻

@Hebilicious Thank you! I'm gonna check it out later or tomorrow👍🏻

@alessandrokonrad I can comment out the Haskell build until I figure out what's going on... Can't get it to work on Docker or on MacOS 🤔

@Hebilicious Thank you! I'm gonna check it out later or tomorrow👍🏻

@alessandrokonrad I can comment out the Haskell build until I figure out what's going on... Can't get it to work on Docker or on MacOS 🤔

Yeah that would be a good idea👍🏻

@Hebilicious Thank you! I'm gonna check it out later or tomorrow👍🏻

@alessandrokonrad I can comment out the Haskell build until I figure out what's going on... Can't get it to work on Docker or on MacOS 🤔

Yeah that would be a good idea👍🏻

I've commented out the on-chain build, this should be good to merge 🚀

@alessandrokonrad Btw, have I wanted to know if you have managed/tried to build locally without nix ?
I also have started working on a plutus standard for NFTs, opened an issue here to let you know.
Might be easier to DM, my discord is Hebilicious#3910

@alessandrokonrad Btw, I wanted to know if you have managed/tried to build locally without nix ?

I do not use nix here. You only need cabal and ghc.

I also have started working on a plutus standard for NFTs, opened an issue https://github.com/Berry-Pool/nft-plutus/issues/1 to let you know.
Might be easier to DM, my discord is Hebilicious#3910

Cool I'll take a look and will DM you


Reload resources to build.gradle

No more tears

Coverage remained the same at 71.728% when pulling ee42d1a9e7694e2fe64cbb809a1996b4a58102fb on laurpulk:reload_resources_updated into 353d9c54c0df0ed588d93ed765e985973140b3d5 on tdd-pingis:master.


ENH: Support for statistical analysis of whole containers

All topography/line scan classes now have a unit attribute and a unit keyword argument for the constructor
The scale pipeline function has support for converting between units
Container have a pipeline function scale_dependent_statistical_property that runs a whole container statistical analysis

Hi @mcrot - I need your help here. For some reason, ScaledTopography can no longer be pickled. When unpickling, properties are missing. This is super weird, I have never seen this before. Do you have any ideas what may be going on?

I found the problem but the error was very unintuitive

Hi @mcrot - this is now ready for your review

Hi @mcrot - I think I have addressed all your comments. Can you have a look at the current PR again? Note that I cleaned up the CI configuration to make as much use of Ubuntu's packages as possible.

Hi @mcrot - I changed the behavior to issue a deprecation warning when a unit is passed in the info dictionary. Also, you should get a deprecation warning now if you access the unit key of the info dictionary.

Oh, there are more changes that I haven't reviewed yet, please wait..

I've fixed heights_scale_factor to height_scale_factor

Hi @mcrot - I am happy with your changes to the deprecation module and have addressed the other issues you raised


fix: Make sure onComplete resets the position even when not looping

This makes sure that subsequent play calls with the same audio (or simply resume) with restart after completion.

Should this fix also work on macOS?
My onComplete callback is only being triggered the first time I play an audio and it completes.
Subsequent plays aren't triggering the onComplete on macOS but work in Windows.


fix(wallet): Reset Transaction Object

This PR:

Resets the transaction object after any failed broadcast attempt.

Otherwise, the user will most likely run into the same issue unless they specifically close out of and return to the Send view. Which is not an ideal experience.

I don't understrand why do we need this? What if it was just a network connection error?


mix umbrella project  Errors generating relup

I test in your git repository exrm-umbrella-test .
and change the master_app version to 0.0.2
then mix release
Errors generating relup
Could not open file  exrm-umbrella-test/apps/master_app/rel/master_app/lib/master_app-0.0.2/ebin/master_app.appup

I'll take a look, this may be related to another issue I'm currently investigating. Thanks for reporting!

now I changed the v2_path = "#{File.cwd!}/_build/#{env}/lib/#{app}" like this . and fixed the problem .
but I donot think this is a good solution .
I am not very familiar of the  Mix.Project.compile_path method.

or delete config = [build_path: Mix.Project.build_path, umbrella?: true] the build_path?


Web output issue - no charts/graphics

System information

Have I written custom code (as opposed to using zenbot vanilla): no - using installed codes
OS Platform and Distribution (e.g., Linux Ubuntu 16.04): Windows 10 with Docker v20.10.2
Zenbot version (commit ref, or version):  on commit 3,637
Zenbot branch: DeviaVir
NodeJS version: v10.23.2
Python version (when using a python script):
Exact command to reproduce (include everything): docker-compose up
Did I make any changes to conf-sample.js?: Updated ccxt API keys

Describe the problem
Describe the problem clearly here. Be sure to convey here why it's a bug in Zenbot or a feature request.
I am using Docker and can verify from the console that Zenbot is running (in --paper mode). Opening the local website shows only dashboard text output - there are no charts or graphics on the page. I have verified on Edge, IE, and Chrome with the same issue on each. Any suggestions?
I would submit a screen shot put its just a large blank space with just the dashboard text.

if you are using docker, i had to use my system ip like <IP_ADDRESS>:17365 in the browser versus localhost:17365 or <IP_ADDRESS>:17365.  Some of the javascript resources will not load using localhost.  You can find this out by using devtools console in firefox or chrome.

That brings up the same thing (thanks tho). I am starting Zenbot with cmd and see output but it is not excepting any commands - ie l = list available commands. I think this is why the website is not showing anything because I am not able to dump from the CLI.
Do I need to start the docker with -d and run trade --paper from within the docker cli (just to a different port)? Or is there a way to get the cmd window to take my inputs? Any suggestions would be great.

After updating docker-compose.yml file to the deviavir/zenbot:unstable image and rebuilding the Docker - everything is working.


Allowed symbols in DSN user and password?

Is there a way to escape a special symbols ( # in my case) ?

Did you try encoding them using percent encoding?

It works! Thanks


RuntimeError: pubsub connection not set.

Version:  redis-py=3.1.0  and redis=3.2.10
Platform:  Python 2.7.5 / CentOS Linux release 7.4.1708 (Core)
Description:
Infrastructure

two machines (worker1, worker2 ) for running celery worker services with default concurrency (=8).
one dedicated machine (redis1) for running redis server.

**** Issue ****
After the workers running for some time, suddenly a worker running on machine1 dies due to a RuntimeError raised losing a connection to pubsub.
machine1.worker.log
[2019-02-01 13:43:39,477: CRITICAL/MainProcess] Unrecoverable error: RuntimeError(u'pubsub connection not set: did you forget to call subscribe() or psubscribe()?',)
Traceback (most recent call last):
  File "/opt/c1/cip-middleware/webapp/virtualenv/lib/python2.7/site-packages/celery/worker/worker.py", line 205, in start
    self.blueprint.start(self)
  File "/opt/c1/cip-middleware/webapp/virtualenv/lib/python2.7/site-packages/celery/bootsteps.py", line 119, in start
    step.start(parent)
  File "/opt/c1/cip-middleware/webapp/virtualenv/lib/python2.7/site-packages/celery/bootsteps.py", line 369, in start
    return self.obj.start()
  File "/opt/c1/cip-middleware/webapp/virtualenv/lib/python2.7/site-packages/celery/worker/consumer/consumer.py", line 322, in start
    blueprint.start(self)
  File "/opt/c1/cip-middleware/webapp/virtualenv/lib/python2.7/site-packages/celery/bootsteps.py", line 119, in start
    step.start(parent)
  File "/opt/c1/cip-middleware/webapp/virtualenv/lib/python2.7/site-packages/celery/worker/consumer/consumer.py", line 598, in start
    c.loop(*c.loop_args())
  File "/opt/c1/cip-middleware/webapp/virtualenv/lib/python2.7/site-packages/celery/worker/loops.py", line 91, in asynloop
    next(loop)
  File "/opt/c1/cip-middleware/webapp/virtualenv/lib/python2.7/site-packages/kombu/asynchronous/hub.py", line 354, in create_loop
    cb(*cbargs)
  File "/opt/c1/cip-middleware/webapp/virtualenv/lib/python2.7/site-packages/kombu/transport/redis.py", line 1047, in on_readable
    self.cycle.on_readable(fileno)
  File "/opt/c1/cip-middleware/webapp/virtualenv/lib/python2.7/site-packages/kombu/transport/redis.py", line 344, in on_readable
    chan.handlers[type]()
  File "/opt/c1/cip-middleware/webapp/virtualenv/lib/python2.7/site-packages/kombu/transport/redis.py", line 674, in _receive
    ret.append(self._receive_one(c))
  File "/opt/c1/cip-middleware/webapp/virtualenv/lib/python2.7/site-packages/kombu/transport/redis.py", line 685, in _receive_one
    response = c.parse_response()
  File "/opt/c1/cip-middleware/webapp/virtualenv/lib/python2.7/site-packages/redis/client.py", line 3032, in parse_response
    'pubsub connection not set: '
RuntimeError: pubsub connection not set: did you forget to call subscribe() or psubscribe()?

While at the same time I have spotted that worker running on machine2 suffers due to not being able to connect to redis. Eventually, it managed to recover and reconnect to redis and receiving the queued tasks.
machine2.worker.log
[2019-02-01 14:43:41,722: WARNING/MainProcess] consumer: Connection to broker lost. Trying to re-establish the connection...
Traceback (most recent call last):
  File "/opt/c1/cip-middleware/webapp/virtualenv/lib/python2.7/site-packages/celery/worker/consumer/consumer.py", line 322, in start
    blueprint.start(self)
  File "/opt/c1/cip-middleware/webapp/virtualenv/lib/python2.7/site-packages/celery/bootsteps.py", line 119, in start
    step.start(parent)
  File "/opt/c1/cip-middleware/webapp/virtualenv/lib/python2.7/site-packages/celery/worker/consumer/mingle.py", line 40, in start
    self.sync(c)
  File "/opt/c1/cip-middleware/webapp/virtualenv/lib/python2.7/site-packages/celery/worker/consumer/mingle.py", line 44, in sync
    replies = self.send_hello(c)
  File "/opt/c1/cip-middleware/webapp/virtualenv/lib/python2.7/site-packages/celery/worker/consumer/mingle.py", line 57, in send_hello
    replies = inspect.hello(c.hostname, our_revoked._data) or {}
  File "/opt/c1/cip-middleware/webapp/virtualenv/lib/python2.7/site-packages/celery/app/control.py", line 143, in hello
    return self._request('hello', from_node=from_node, revoked=revoked)
  File "/opt/c1/cip-middleware/webapp/virtualenv/lib/python2.7/site-packages/celery/app/control.py", line 95, in _request
    timeout=self.timeout, reply=True,
  File "/opt/c1/cip-middleware/webapp/virtualenv/lib/python2.7/site-packages/celery/app/control.py", line 454, in broadcast
    limit, callback, channel=channel,
  File "/opt/c1/cip-middleware/webapp/virtualenv/lib/python2.7/site-packages/kombu/pidbox.py", line 315, in _broadcast
    serializer=serializer)
  File "/opt/c1/cip-middleware/webapp/virtualenv/lib/python2.7/site-packages/kombu/pidbox.py", line 290, in _publish
    serializer=serializer,
  File "/opt/c1/cip-middleware/webapp/virtualenv/lib/python2.7/site-packages/kombu/messaging.py", line 181, in publish
    exchange_name, declare,
  File "/opt/c1/cip-middleware/webapp/virtualenv/lib/python2.7/site-packages/kombu/messaging.py", line 203, in _publish
    mandatory=mandatory, immediate=immediate,
  File "/opt/c1/cip-middleware/webapp/virtualenv/lib/python2.7/site-packages/kombu/transport/virtual/base.py", line 605, in basic_publish
    message, exchange, routing_key, **kwargs
  File "/opt/c1/cip-middleware/webapp/virtualenv/lib/python2.7/site-packages/kombu/transport/virtual/exchange.py", line 151, in deliver
    exchange, message, routing_key, **kwargs)
  File "/opt/c1/cip-middleware/webapp/virtualenv/lib/python2.7/site-packages/kombu/transport/redis.py", line 781, in _put_fanout
    dumps(message),
  File "/opt/c1/cip-middleware/webapp/virtualenv/lib/python2.7/site-packages/redis/client.py", line 2716, in publish
    return self.execute_command('PUBLISH', channel, message)
  File "/opt/c1/cip-middleware/webapp/virtualenv/lib/python2.7/site-packages/redis/client.py", line 775, in execute_command
    return self.parse_response(connection, command_name, **options)
  File "/opt/c1/cip-middleware/webapp/virtualenv/lib/python2.7/site-packages/redis/client.py", line 789, in parse_response
    response = connection.read_response()
  File "/opt/c1/cip-middleware/webapp/virtualenv/lib/python2.7/site-packages/redis/connection.py", line 636, in read_response
    raise e
ConnectionError: Error while reading from socket: (u'Connection closed by server.',)
[2019-02-01 14:44:50,237: INFO/MainProcess] Received task: c1_cip_middleware.tasks.validate_purchases.run_purchases_validation[a411dd90-ab50-4101-becb-90adda3663a2]

*** Questions ***
I wonder what are the circumstances/scenarios when RuntimeError is raised, thus, the worker gets into the "unrecovery" stage and must be stopped?
I am in doubt what could be a root-cause of having this issue, especially that one worker managed to recover but the other one just died?

Can you try upgrading to redis-py 3.2.0? There are a number of connection management improvements that might help this issue.

Same error with redis-py version 3.3.10, ubuntu 18, celery 4.2.0, redis v5.  It resolved itself after 2 hours.

@andymccurdy I have the same error with redis-py 3.3.11

Same even with redis-py 3.5.3...

Just experienced this in redis-py 3.5.3, causing a worker to crash.
The suggested option health_check_interval does not exist according to documentation:
https://docs.celeryproject.org/en/stable/userguide/configuration.html
According to the changes from that day there are some possible suspects:
We've been experiencing this after switching to gevent (because of serialization issues with django, https://github.com/celery/celery/issues/5924)
And changing the celery config to be more resilient to outages (coming from no resilience):
CELERY_BROKER_CONNECTION_RETRY = True
CELERY_BROKER_CONNECTION_MAX_RETRIES = 400

note that these settings are only related to AMPQ broker, but not Redis
CELERY_BROKER_CONNECTION_RETRY = True
CELERY_BROKER_CONNECTION_MAX_RETRIES = 400

https://docs.celeryproject.org/en/stable/userguide/configuration.html#std-setting-broker_connection_max_retries


use scipy.sparse.linalg function without linsolve namespace

Scipy 1.8 renamed scipy.sparse.linalg.linsolve to scipy.sparse.linalg._linsolve, because linsolve is not part of the public API. All public API functions from it are directly accessible and documented in scipy.sparse.linalg

Thanks! Is this compatible with older Scipy version(s)? I have not touched this code for a long time, so I need to get to the picture.

Yes, all used functions have been part of the official scipy.sparse.linalg API in 1.0.0, which is your current minimum scipy:
https://docs.scipy.org/doc/scipy-1.0.0/reference/sparse.linalg.html

OK, thanks! LGTM.


[PE-D][Tester C] Deadline Data Validation from JSON file

How to reproduce: Edit the value of deadline in JSON file and run the application again.
Expected: Application should report that the data of that deadline field is invalid, then it could show deadline as empty or just remove it.
Actual: Currently, the application show the invalid deadline without warning anything.

Labels: severity.Medium type.FunctionalityBug
original: purivirakarin/ped#10

Not feature flaw, fix in UG


Scrcpy can't find my device

Hi, I have a problem with Scrcpy not detecting my phone. My phone is Nokia 6.1 and is being detected by Android Studio without any problems. USB debugging is enabled of course. Also, Scrcpy does detect running Android emulator, and it mirrors the screen as expected.
Info about my system:
firzen@buddha:~$ lsb_release -a
No LSB modules are available.
Distributor ID: Debian
Description:    Debian GNU/Linux 10 (buster)
Release:        10
Codename:       buster
firzen@buddha:~$ uname -a
Linux buddha 5.1.16 #1 SMP Wed Jul 3 18:52:54 BST 2019 x86_64 GNU/Linux

How I installed Scrcpy:
sudo snap install scrcpy
scrcpy  # didn't work
snap info scrcpy
snap connections
sudo snap install core
sudo snap connect scrcpy:adb-support :adb-support
sudo snap connect scrcpy:x11 :x11
sudo snap connect scrcpy:desktop :desktop
sudo snap connect scrcpy:desktop-legacy :desktop-legacy
sudo snap connect scrcpy:network :network
sudo snap connect scrcpy:wayland :wayland

What Scrcpy outputs when I connect my phone via USB cable with phone screen turned on:
firzen@buddha:~$ scrcpy
INFO: scrcpy 1.12 <https://github.com/Genymobile/scrcpy>
adb: error: failed to get feature set: no devices/emulators found
ERROR: "adb push" returned with value 1

Could someone please help me to get Scrcpy working? Thank you in advance! :-)

What is the result of adb devices?

@rom1v I don't seem to have adb in $PATH, and so it outputs:
firzen@buddha:~$ adb devices
bash: adb: command not found

When I go to my android tools directory, adb does list my phone:
firzen@buddha:~/tools/android-sdk/platform-tools$ ./adb devices
List of devices attached
PL2GARD851705414        device

I have tried to create a symlink using sudo ln -s /home/firzen/tools/android-sdk/platform-tools/adb /usr/bin/adb, but Scrcpy still behaves the same way as described above..

Try a non-snap version of scrcpy. The adb from snap probably can't detect your device due to permissions.

See: https://github.com/sisco311/scrcpy-snap/issues/4

I ran into a similar issue using the snap version of scrcpy (Ubuntu still has an older version on its repos).  This is the way I end up solving it:

adb kill-server #start clean

plug your device
adb devices #check if the device is connected
or

connect via TCP
adb connect _IP_:_PORT_

export the path to currently used adb or use the same path to adb when you connected to the device, in the previous step
export ADB=$(which adb) scrcpy

run scrpy
scrcpy

hve you enabled usb debugging (and wifi debugging) from advanced settings on your phone?


New to this data set, seeing alot of empty fields.. is this intentional?

Hello,
Great work here!
I was wondering what to make of fields that have missing data.. For instance, some players do not have positions. when i run: game.players.csv("game_all_players.csv") the resulting csv file shows most of the player without a position in the positions column. Even popular players like J.Kearse have their position empty. But for other fields that are normally floats or integers, when empty in the dataset, should they be interpreted as zero?
Thanks for any insights.

Position information comes from each team's nfl.com roster page (ie. ARI).  If a player in nflgame does not appear on an active NFL roster at the time that nflgame-update-players was run then they will not have position data populated.
I'm not 100% clear on your code to generate your csv file but, yeah, you're probably correct.  If a stats category is empty over the scope of a number of games, then it is probably true that the field can be interpreted as 0.
import nflgame
games = nflgame.games(year=2015, week=10, kind='REG')
players = nflgame.combine_max_stats(games)
for player in players:
    if player.playerid == '00-0019596':  # Tom Brady
        print player
        print player.stats
        print 'passing yards:', player.passing_att, player.stats.get('passing_att', 0), player.passing_att == player.stats.get('passing_att', 0)
        print 'punt blocks:', player.defense_puntblk, player.stats.get('defense_puntblk', 0), player.defense_puntblk == player.stats.get('defense_puntblk', 0),

T.Brady
OrderedDict([('passing_incmp_air_yds', 209), ('passing_sk', 3), ('passing_att', 42), ('passing_sk_yds', -5), ('fumbles_forced', 2), ('fumbles_tot', 2), ('passing_int', 1), ('fumbles_lost', 1), ('passing_yds', 334), ('passing_incmp', 16), ('passing_cmp', 26), ('rushing_yds', 9), ('rushing_att', 2), ('passing_tds', 2), ('passing_cmp_air_yds', 227), (u'rushing_lngtd', 0), (u'passing_twoptm', 0), (u'fumbles_yds', 0), (u'fumbles_rcv', 0), (u'fumbles_trcv', 0), (u'passing_twopta', 0), (u'rushing_tds', 0), (u'rushing_twopta', 0), (u'rushing_lng', 10), (u'passing_ints', 1), (u'rushing_twoptm', 0)])
passing yards: 42 42 True
punt blocks: 0 0 True

Thanks for the reply. Yeah it seems as though an empty field would just be a zero.
I'm trying to get game stats per player and am currently doing this to get it:
game.players.passing().csv( "game_data.csv")
Using this method, an example of a row that i'm getting in my csv files looks like this:
 There you could see the blanks
Should I be going about it another way which would give me cleaner results?
Thanks again!

Guess it really depends on what you're trying to do and how married you are to getting your data out in csv format...
import nflgame
games = nflgame.games(year=2016, week=1, kind='PRE')

for game in games:
    print game
    game.players.passing().csv( "game_data.csv")  # I assume you're doing something like this...

    # If you're married to CSV format and you want all games in separate files you could do something like this:
    game.players.csv('{}@{}game_data.csv'.format(game.away, game.home))
    # will give you a .csv file for every game played in the week

    # You could just as easily be accessing all of the data directly...
    for player in game.players.passing():
        print player, player.formatted_stats()
    # this will print out each passers name with all categories they registered a statistic in
    # ie. T.Savage passing_att: 24, passing_twoptm: 0, passing_twopta: 0, passing_yds: 168, passing_cmp: 14, passing_ints: 0, passing_tds: 2

    # Or just the data you were interested in...
    for player in game.players.passing():
        print '{} threw {} completions in {} attempts ({:0.2f}%)'.format(
            player, player.passing_cmp, player.passing_att,
            player.passing_cmp/float(player.passing_att)*100)
    # will print out a formatted string for each passer's completion percentage
    # ie. T.Savage threw 14 completions in 24 attempts (58.33%)

    # You probably know this, but no need to limit yourself to just passers...
    for player in game.players:
        print player, player.stats
    # this will print each player (regardless of whether they were a passer or not) and stats recorded
    # ie. D.Pettinato OrderedDict([(u'defense_ffum', 0), (u'defense_tkl', 1), (u'defense_int', 0), (u'defense_ast', 0), (u'defense_sk', 0)])

If you are truly after the csv formatted data, there are a couple of different things you could do.
# gives you a 3461 line csv file with all players that recorded a stat in week 1 of this preseason
import nflgame
games = nflgame.games(year=2016, week=1, kind='PRE')
players = nflgame.combine_max_stats(games)
players.csv('all_week1_data.csv')

# gives you a 2307 line csv file with all players and their aggregated stats over weeks 4, 5, and 6 in 2015
import nflgame
games = nflgame.games(year=2015, week=range(4, 7), kind='PRE')
players = nflgame.combine_max_stats(games)
players.csv('all_weeks456_data.csv')

# why stop at a single week or even a range of weeks.  How about the entire season?
import nflgame
games = nflgame.games(year=2015, kind='REG')
players = nflgame.combine_max_stats(games)
players.csv('entire_2015_season.csv')

ochawkeye, really great examples thank you for taking the time to do that!
player.formatted_stats() looks like it might be what i'm looking for.

Hey, i think you're talking about an issue that was answered here: https://github.com/BurntSushi/nflgame/issues/204
The reason why you are seeing new lines in the csv is because the DictWriter in seq.py uses Windows-style line terminators (\r\n) rather than Unix-style (\n). A fix that worked for me was to open up seq.py, go to line 333 and change (fileName, 'w+') to (fileName, 'wb').

I'm on OSX with NFLGame fully up to date.  In any fashions listed in this thread, i am still getting csv outputs that dont have the player position in their column.  However these players with empty positions do indeed have stats for that game.

Looks to me like there is a bug with .guess_position on this line.
        if self.player is not None:
            return self.player.position

Problem there is that self.player is never None.  So it never gets into trying to deduce the position from the stats.
I changed that line to
        if self.player.position:
            return self.player.position

Now nflgame will try to guess the position if one is not present.
import nflgame

games = nflgame.games(year=2015, week=range(4, 7), kind='REG')
players = nflgame.combine_play_stats(games)

for player in players:
    print player.player, '\t\tnflgame:', player.player.position, '\tguess:', player.guess_position

Justin Tucker (K, BAL)          nflgame: K      guess: K
Mike Vick (, )                  nflgame:        guess: QB
Heath Miller (, )               nflgame:        guess: WR
Brandon Williams (NT, BAL)      nflgame: NT     guess: NT
David DeCastro (G, PIT)         nflgame: G      guess: G
Elvis Dumervil (OLB, BAL)       nflgame: OLB    guess: OLB

Thanks @ochawkeye that worked for me.  As far as i can tell thus far these guesses are accurate.
not to derail this thread, but i also don't see a stat for 'starter'. Is that attribute somewhere or will i need an external source for that?

Not 100% accurate but it does a pretty good job from what I can tell.  I suppose a game where a guy like Darren Sproles catches more balls than he runs will give it problems.
The only positions it will guess are QB, RB, WR, DEF, K and P.  So a guy like Heath Miller won't accurately be listed as a TE.
A game start is not a stat found in the JSON that nflgame uses.  There are sources out there that do include that.  See: gamebook

I should probably note that after making this change to my player.py file one of my regular scripts failed last night midway through the Thursday night game with an AttribureError on a line that included a call to .guess_position.  I reverted my change to player.py and my script went back to running as normal.
I didn't get a change to dig into what specifically the error was and now it seems to be gone.
YMMV


Investigate 'no space left on device' issue during import

Transaction block buffer is now stored in database disk, because OS disk was too small for large analyses.


ControlMessage: SOL_TLS control message falls back to ControlMessageOwned::Unknown

When enabling kTLS on a socket (which mostly involves setting up the SOL_TLS sockopt), that socket may receive some control messages like so:
  2023-06-29T11:56:33.154070Z TRACE ktls::ktls_stream: received UnknownCmsg(
    cmsghdr {
        cmsg_len: 17,
        cmsg_level: 282,
        cmsg_type: 2,
    },
    [
        23,
    ],
)

The cmsg_level corresponds to libc::SOL_TLS, cmsg_type corresponds to TLS_GET_RECORD_TYPE
I believe the additional data in the Vec<u8> corresponds to TLS message types: 22 is handshake, 23 is application data, see RFC 5246.
This happens because, after the TLS 1.3 handshake, tickets can be sent by the server to the client (for resumption, see rustls 0.21's flag for that).
If you're doing userland TLS, your deframer handles those messages gracefully and either throws away or stores the tickets for further use. But with kTLS, they have to go somewhere, and.. if you've received a ticket and you do a read() on the socket, you get errno 5 (helpful, I know!). If you do a recvmsg() you get one of these with the "bonus data" set to 22, which again, is the TLS 1.2/1.3 "handshake" type.
I'm working on a PR that recognizes those message types, adding a variant to ControlMessageOwned. The diff is probably a handful of lines and y'all don't need to bother yourselves with those details anyway but since there's fuck-all documentation about kTLS offline I needed to put it down somewhere.

cmsg_type corresponds to libc::SCM_CREDENTIALS

I mean, they're both equal to 2, but that doesn't really say anything. I should probably dig deeper to find out what cmsg_type really corresponds to when level is 282.

@fasterthanlime Are you going to upstream the setsockopt part of the kTLS setup to nix too? I've been working on my own impl at https://github.com/arsing/ktls-test and have a bunch of extensions to libc and nix for it. Eg I noticed hapsoc/ktls is doing it directly whereas mine integrates into the nix SetSockOpt mechanism.
I was going to start PRing them, but since you've already done part of the effort maybe you want to do it.

@Arnavion feel free to go ahead with your own PRs, I’d be delighted to have it but am having enough trouble landing that one PR as is 🙃

Okay, thanks.

Fixed by #2065


[question] MbTiles support

This is rather question that bug report. Is there any code sample showing how to display raster layer using tiles from local MbTiles file?

I was able to accomplish this by using the "FromSyncImage" method. You can store your images in your XamarinForm Project and  rather than the native projects. Make sure you sent their build types to "Embedded Resource". I believe in "Droid" the folder path name to the resource files requires an "_". Check the code below. Hope this helps.
objTile = TileLayer.FromSyncImage((int x, int y, int zoom) =>
{
var assembly = this.GetType().GetTypeInfo().Assembly;                 byte[] buffer;
Stream stream = null;
try
{
                stream = assembly.GetManifestResourceStream($"XamarimFormProjectNamespace.Res._{zoom}._{x}.{y}.png");

                long length = stream.Length;
                buffer = new byte[length];
                stream.Read(buffer, 0, (int)length);

                return buffer;
            }
            catch (Exception ex)
            {
                System.Diagnostics.Debug.WriteLine(ex.Message);
            }
            finally
            {
                if (stream != null)
                    stream.Close();
            }
            return appImage;
        });

Google Maps can not read "MbTiles" .
MbTiles is "MapBox Binary VECTOR Tile", but Google Maps can not render vector tile.

Google Maps can not read "MbTiles" .
MbTiles is "MapBox Binary VECTOR Tile", but Google Maps can not render vector tile.

Thanks, but your comment is not accurate, MBTiles format is designed to support both raster and vector data.
Raster version is used quite often

Hi @spatialguy, sorry you're correct.
If you want to use format: png/jpeg/etc, you can use @tekinc 's suggested code.

Read MBTile file using stream = assembly.GetManifestResourceStream(...
Get image from MBTile file.
Return image's byte array.

Hi @spatialguy, sorry you're correct.
If you want to use format: png/jpeg/etc, you can use @tekinc 's suggested code.

Read MBTile file using stream = assembly.GetManifestResourceStream(...
Get image from MBTile file.
Return image's byte array.

Thanks @tekinc , @amay077 . I was able to get it working using BruTile library. The trick is to correctly convert tile coordinates between Google Maps and TMS:
                var mbTiles = _mbTiles.Value; // open mbTiles file using brutile
                var layer = TileLayer.FromSyncImage((int x, int y, int zoom) =>
                {
                    var yMax = 1 << zoom;
                    var y1 = yMax - y - 1; // from Google Maps tiling to TMS
                    var tileIndex = new TileIndex(x, y1, zoom.ToString());
                    var tileInfo = new TileInfo {Index = tileIndex};
                    var data = mbTiles.GetTile(tileInfo);
                    return data;
                });

and code to open MbTiles file:
        private readonly Lazy<MbTilesTileSource> _mbTiles = new Lazy<MbTilesTileSource>(
            () =>
            {
                return new MbTilesTileSource(
                    new SQLiteConnectionString(ResourcesDeployService.MbTilesFilePath, false));
            }) ;

@spatialguy Thanks for those pieces of code, it helped me out with loading an mbtiles file. I'm trying to load multiple mbtiles together, to use as layering (for example I have a custom map base layer, I want to ability to toggle on/off another layer for parking meters). I have issue where the parking meter layout transparent segments are blacked out like this

This causes my base layout to not show.
Have you had any experience with this issue? I appreciate any help I can get, thanks.


[Bug]: Unable to use recognize speakers option

What happened?
I enabled the 'recognize speakers' option but the 'downloading AI models' meter in the bottom right does not progress. I left it overnight. If I move the 'recognize speakers' slider to enabled again, it will stay enabled without downloading the AI models but then when I start to transcribe it brings up an error:
Caused by:
Failed to create ONNX Runtime session: Load model from C:\Users\XXX\AppData\Local\github.com.thewh1teagle.vibe\segmentation-3.0.onnx failed:Protobuf parsing failed.
Note I am using 2.4.0 older CPU because the newer versions do not work for me, they crash as soon as I attempt to transcribe.
Steps to reproduce

step one...
step two...

What OS are you seeing the problem on?
Window
Relevant log output
options: {
  "path": "C:\\Users\\XXX\\Downloads\\662637_callRecording.wav",
  "lang": "en",
  "verbose": false,
  "n_threads": 4,
  "init_prompt": "",
  "temperature": 0.4,
  "translate": null,
  "max_text_ctx": null,
  "word_timestamps": false,
  "max_sentence_len": 1
}

Caused by:
    Failed to create ONNX Runtime session: Load model from C:\Users\XXX\AppData\Local\github.com.thewh1teagle.vibe\segmentation-3.0.onnx failed:Protobuf parsing failed.

    Location:
        C:\Users\runneradmin/.cargo\registry\src\index.crates.io-6f17d22bba15001f\pyannote-rs-0.2.7\src\session.rs:7:19

Location:
    core\src\transcribe.rs:145:108

Duplicate of https://github.com/thewh1teagle/vibe/issues/279


Initialization on OnAfterRenderAsync doesn't work

Hi,
I'm trying to initialize the pie chart on the first render of the document.
The code below will not draw anything. If I remove the "firstRender" check, it will be redrawn over and over again.
I tried to put different if clauses in the method itself, but I believe there must be a simple way how to async load the elements on the first render and keep it that way.
With non-async method this works just fine.
Is this behaviour expected?
<ApexChart TItem="ElementModel" @ref="_chart">
    <ApexPointSeries TItem="ElementModel"
         Items="items"
         SeriesType="SeriesType.Pie"
         XValue="@(e => e.Description)"
         YAggregate="@(e => e.Sum(e => e.Amount))"
         OrderByDescending="e=>e.Y" />
</ApexChart>

@code {
 private List<ElementModel> items = new List<ElementModel>();

 protected async override Task OnAfterRenderAsync(bool firstRender)
 {
        if (firstRender)
        {
            await UpdateElements();
        }
 }

 private async Task UpdateElements()
 {

       var elements= await Client.GetElements();
       var elements1= new ElementModel() { Description = "Elements1",  Amount = 2 };
       var elements2= new ElementModel() { Description = "Elements2",  Amount = 3 };

        items = new List<ElementModel>() { elements1, elements2};

        //Two UpdateSeries seems to be necessary
        await _chart.UpdateSeriesAsync(true);
        await _chart.UpdateSeriesAsync(true);

        this.StateHasChanged();
    }
}

Hello,
Is there a special reason why you override the OnAfterRenderAsync?

Hi @joadan ,
thank you for your answer.
Correct me if I'm wrong, but if I want to load elements on the initialization of the component I need to do it either with overriding OnInitializedAsync or OnAfterRenderAsync .
To have _chart accessible and rendered I do it in OnAfterRenderAsync (and only after first render).
I will be happy to hear suggestion how to do it better and where to call UpdateElements in this case.
The goals is that whenever this component is used, the elements are loaded from DB and drawn.

Have you check the sample, https://apexcharts.github.io/Blazor-ApexCharts/features/chart-data
This gives you two examples of loading data async.

Oh thank you @joadan
I had it this way as the first draft, but what I made different now was to set "items" null at the beginning and not an empty list. After this, it started to work.


Possibly a better way to set eGPU

@mayankk2308 If you ever decide to optimize this script, I suggest you take a look at this PLIST file:
~/Library/Preferences/com.apple.LaunchServices/com.apple.LaunchServices.plist has a collection named "LSeGPUIsPreferred".
Opening this collection we see a list of all app bundles.
For each app bundle we have two items. "Item 1" is a number.
Prefer eGPU Selected = 3
Prefer eGPU Not Selected = 2
I think this would be the safest way to modify this via a script and also allow backing up this file if needed.
Example PLIST as XML:
The "data" field is BASE64 encoded.
<?xml version="1.0" encoding="UTF-8"?>
<!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/PropertyList-1.0.dtd">
<plist version="1.0">
<dict>
	<key>LSeGPUIsPreferred</key>
	<dict>
		<key>com.apple.BluetoothExplorer</key>
		<array>
			<data>Ym9vaxADAAAAAAQQMAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAADAIAAAQAAAADAwAAAAAAIAwAAAABAQAAQXBwbGljYXRpb25zGgAAAAEBAABBZGRpdGlvbmFsIFRvb2xzIGZvciBYY29kZQAACAAAAAEBAABIYXJkd2FyZRYAAAABAQAAQmx1ZXRvb3RoIEV4cGxvcmVyLmFwcAAAEAAAAAEGAAAQAAAAJAAAAEgAAABYAAAACAAAAAQDAAD5FVQLAAAAAAgAAAAEAwAAlxYBBwAAAAAIAAAABAMAAG1IAQcAAAAACAAAAAQDAACDTwEHAAAAABAAAAABBgAAkAAAAKAAAACwAAAAwAAAAAgAAAAABAAAQcIJu3QAAAAYAAAAAQIAAAIAAAAAAAAADwAAAAAAAAAAAAAAAAAAAAgAAAABCQAAZmlsZTovLy8MAAAAAQEAAE1hY2ludG9zaCBIRAgAAAAEAwAAAKAgaHQAAAAIAAAAAAQAAEHBzOSKUFO7JAAAAAEBAAAxNDU0Q0Y1Ny0xQTRGLTQ4QzEtODVEMS0yMjQxNTI0RThFMTEYAAAAAQIAAIEAAAABAAAA7xMAAAEAAAAAAAAAAQAAAAEAAAABAQAALwAAAAAAAAABBQAASAAAAAEBAAAvQXBwbGljYXRpb25zL0FkZGl0aW9uYWwgVG9vbHMgZm9yIFhjb2RlL0hhcmR3YXJlL0JsdWV0b290aCBFeHBsb3Jlci5hcHDMAAAA/v///wEAAAAAAAAAEAAAAAQQAAB4AAAAAAAAAAUQAADQAAAAAAAAABAQAAD4AAAAAAAAACAQAABYAAAAAAAAADAQAADAAAAAAAAAAEAQAADoAAAAAAAAAAIgAACoAQAAAAAAAAUgAAAYAQAAAAAAABAgAAAoAQAAAAAAABEgAABcAQAAAAAAABIgAAA8AQAAAAAAABMgAABMAQAAAAAAACAgAACIAQAAAAAAADAgAAC0AQAAAAAAABDQAAAEAAAAAAAAAAD/AAC8AQAAAAAAAA==</data>
			<integer>3</integer>
		</array>
		<key>com.apple.Notes</key>
		<array>
			<data>Ym9va6ACAAAAAAQQMAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAnAEAAAQAAAADAwAAAAAAIAYAAAABAQAAU3lzdGVtAAAMAAAAAQEAAEFwcGxpY2F0aW9ucwkAAAABAQAATm90ZXMuYXBwAAAADAAAAAEGAAAQAAAAIAAAADQAAAAIAAAABAMAAORYAAD///8PCAAAAAQDAAB2zwYA////DwgAAAAEAwAAS4YHAP///w8MAAAAAQYAAFwAAABsAAAAfAAAAAgAAAAABAAAQcGsHSKAAAAYAAAAAQIAAAIAAAAAAAAADwAAAAAAAAAAAAAAAAAAAAgAAAABCQAAZmlsZTovLy8MAAAAAQEAAE1hY2ludG9zaCBIRAgAAAAEAwAAAKAgaHQAAAAIAAAAAAQAAEHBzOSKUFO7JAAAAAEBAAAxNDU0Q0Y1Ny0xQTRGLTQ4QzEtODVEMS0yMjQxNTI0RThFMTEYAAAAAQIAAIEAAAABAAAA7xMAAAEAAAAAAAAAAQAAAAEAAAABAQAALwAAAAAAAAABBQAAHgAAAAEBAAAvU3lzdGVtL0FwcGxpY2F0aW9ucy9Ob3Rlcy5hcHAAAMwAAAD+////AQAAAAAAAAAQAAAABBAAAEgAAAAAAAAABRAAAIwAAAAAAAAAEBAAALAAAAAAAAAAIBAAADQAAAAAAAAAMBAAAHwAAAAAAAAAQBAAAKAAAAAAAAAAAiAAAGABAAAAAAAABSAAANAAAAAAAAAAECAAAOAAAAAAAAAAESAAABQBAAAAAAAAEiAAAPQAAAAAAAAAEyAAAAQBAAAAAAAAICAAAEABAAAAAAAAMCAAAGwBAAAAAAAAENAAAAQAAAAAAAAAAP8AAHQBAAAAAAAA</data>
			<integer>3</integer>
		</array>
		<key>com.apple.DVDPlayer</key>
		<array>
			<data>Ym9vaxADAAAAAAQQMAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAADAIAAAQAAAADAwAAAAAAIAYAAAABAQAAU3lzdGVtAAAHAAAAAQEAAExpYnJhcnkADAAAAAEBAABDb3JlU2VydmljZXMMAAAAAQEAAEFwcGxpY2F0aW9ucw4AAAABAQAARFZEIFBsYXllci5hcHAAABQAAAABBgAAEAAAACAAAAAwAAAARAAAAFgAAAAIAAAABAMAAORYAAD///8PCAAAAAQDAABZWQAA////DwgAAAAEAwAABscAAP///w8IAAAABAMAABd0AQD///8PCAAAAAQDAADFdAEA////DxQAAAABBgAAjAAAAJwAAACsAAAAvAAAAMwAAAAIAAAAAAQAAEHBiGotgAAAGAAAAAECAAACAAAAAAAAAA8AAAAAAAAAAAAAAAAAAAAIAAAAAQkAAGZpbGU6Ly8vDAAAAAEBAABNYWNpbnRvc2ggSEQIAAAABAMAAACgIGh0AAAACAAAAAAEAABBwczkilBTuyQAAAABAQAAMTQ1NENGNTctMUE0Ri00OEMxLTg1RDEtMjI0MTUyNEU4RTExGAAAAAECAACBAAAAAQAAAO8TAAABAAAAAAAAAAEAAAABAAAAAQEAAC8AAAAAAAAAAQUAADgAAAABAQAAL1N5c3RlbS9MaWJyYXJ5L0NvcmVTZXJ2aWNlcy9BcHBsaWNhdGlvbnMvRFZEIFBsYXllci5hcHDMAAAA/v///wEAAAAAAAAAEAAAAAQQAABwAAAAAAAAAAUQAADcAAAAAAAAABAQAAAIAQAAAAAAACAQAABYAAAAAAAAADAQAADMAAAAAAAAAEAQAAD4AAAAAAAAAAIgAAC4AQAAAAAAAAUgAAAoAQAAAAAAABAgAAA4AQAAAAAAABEgAABsAQAAAAAAABIgAABMAQAAAAAAABMgAABcAQAAAAAAACAgAACYAQAAAAAAADAgAADEAQAAAAAAABDQAAAEAAAAAAAAAAD/AADMAQAAAAAAAA==</data>
			<integer>3</integer>
		</array>
		<key>com.mowglii.ItsycalApp</key>
		<array>
			<data>Ym9va3QCAAAAAAQQMAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAcAEAAAQAAAADAwAAAAAAIAwAAAABAQAAQXBwbGljYXRpb25zCwAAAAEBAABJdHN5Y2FsLmFwcAAIAAAAAQYAABAAAAAkAAAACAAAAAQDAADOCpYEAAAAAAgAAAAEAwAAAYxZBAAAAAAIAAAAAQYAAEgAAABYAAAACAAAAAAEAABBwbICFwAAABgAAAABAgAAAgAAAAAAAAAPAAAAAAAAAAAAAAAAAAAACAAAAAEJAABmaWxlOi8vLwwAAAABAQAATWFjaW50b3NoIEhECAAAAAQDAAAAoCBodAAAAAgAAAAABAAAQcHM5IpQU7skAAAAAQEAADE0NTRDRjU3LTFBNEYtNDhDMS04NUQxLTIyNDE1MjRFOEUxMRgAAAABAgAAgQAAAAEAAADvEwAAAQAAAAAAAAABAAAAAQAAAAEBAAAvAAAAAAAAAAEFAAAZAAAAAQEAAC9BcHBsaWNhdGlvbnMvSXRzeWNhbC5hcHAAAADMAAAA/v///wEAAAAAAAAAEAAAAAQQAAA4AAAAAAAAAAUQAABoAAAAAAAAABAQAACIAAAAAAAAACAQAAAkAAAAAAAAADAQAABYAAAAAAAAAEAQAAB4AAAAAAAAAAIgAAA4AQAAAAAAAAUgAACoAAAAAAAAABAgAAC4AAAAAAAAABEgAADsAAAAAAAAABIgAADMAAAAAAAAABMgAADcAAAAAAAAACAgAAAYAQAAAAAAADAgAABEAQAAAAAAABDQAAAEAAAAAAAAAAD/AABMAQAAAAAAAA==</data>
			<integer>3</integer>
		</array>
		<key>com.apple.Safari</key>
		<array>
			<data>Ym9va3ACAAAAAAQQMAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAbAEAAAQAAAADAwAAAAAAIAwAAAABAQAAQXBwbGljYXRpb25zCgAAAAEBAABTYWZhcmkuYXBwAAAIAAAAAQYAABAAAAAkAAAACAAAAAQDAAAGtykEAAAAAAgAAAAEAwAACbcpBAAAAAAIAAAAAQYAAEgAAABYAAAACAAAAAAEAABBwayxYgAAABgAAAABAgAAAgAAAAAAAAAPAAAAAAAAAAAAAAAAAAAACAAAAAEJAABmaWxlOi8vLwwAAAABAQAATWFjaW50b3NoIEhECAAAAAQDAAAAoCBodAAAAAgAAAAABAAAQcHM5IpQU7skAAAAAQEAADE0NTRDRjU3LTFBNEYtNDhDMS04NUQxLTIyNDE1MjRFOEUxMRgAAAABAgAAgQAAAAEAAADvEwAAAQAAAAAAAAABAAAAAQAAAAEBAAAvAAAAAAAAAAEFAAAYAAAAAQEAAC9BcHBsaWNhdGlvbnMvU2FmYXJpLmFwcMwAAAD+////AQAAAAAAAAAQAAAABBAAADgAAAAAAAAABRAAAGgAAAAAAAAAEBAAAIgAAAAAAAAAIBAAACQAAAAAAAAAMBAAAFgAAAAAAAAAQBAAAHgAAAAAAAAAAiAAADgBAAAAAAAABSAAAKgAAAAAAAAAECAAALgAAAAAAAAAESAAAOwAAAAAAAAAEiAAAMwAAAAAAAAAEyAAANwAAAAAAAAAICAAABgBAAAAAAAAMCAAAEQBAAAAAAAAENAAAAQAAAAAAAAAAP8AAEwBAAAAAAAA</data>
			<integer>3</integer>
		</array>
	</dict>
</dict>
</plist>

Excellent find! I will consider incorporating it once I have the time. Thank you!

Your welcome :)

This plist doesn't exist by default? I don't see it on my work laptop. I'll check on my other macs soon.

I used FSMonitor to see what change when it’s triggered.
The process LDS is modifying this file every time the eGPU setting is toggled, no need to even close the Get Info window.


Search capabilities from Phoenix (phoenix.0)

I was wondering, would there be an option to adjust fuzzy searching or synonyms? The ability to do "X" or "Y" but not "Z", partial search as you type (mainly to update the count of matched items as I type so I can see if I entered something that just plummeted the number of results), some faceting or filters (could put moulinette cloud results as an option there), minimum resolution, aspect ratio. Sorting based on creator/source and resolution could be great too. Some hotkeys or modifiers so I can click and drag/drop as a tile, token, etc.. And a quick option to open sibling files of a result in the file manager or something bespoke. This would let me dig into a specific pack or folder to look for something similar. These are some features I'd find helpful. Lmk if any of these already exist, thank you 😁. I do know there technically are some workarounds to some of these requests.
Some use cases are if I'm trying to prioritize a certain creator to match art style but it isn't a strict requirement. Or if I'm looking for a specific dimension (particularly aspect ratio) for a part of a building. If the aspect ratio filter could be set either a strict or fuzzy one, I'd be super excited. A resolution sort of filter could remove some thumbnails that get indexed, or assets that are just too big or small for the use case. Other stuff could be like image extension. Or sound track duration.
For the hotkeys to not conflict with the base hotkeys, I was thinking something akin to "shift+begin click drag then release shift" on the image to make it drop as an actor. So users can still press shift again to do the position adjustment on drop.
A recently searched history or recently used items section would be helpful. Sometimes I use an asset but I need it again or had to delete the tile/actor, forgetting to copy the image url. Custom collections/tagging for keeping track of assets that I'm reusing often.

I won't implement this. Librairies tend to be slow for fuzzy search on high number of assets and Moulinette already implements regex search


⚠ Mobitopup has degraded performance

In 5e92372, Mobitopup (https://napcard.voz.tech) experienced degraded performance:

HTTP code: 200
Response time: 10341 ms

Resolved: Mobitopup performance has improved in e95ad79.


Main API does not pass process arguments.

 Let's close this until someone notices the issue and files is properly.


graylog: 3.3.2 -> 3.3.3

Bumps Graylog and integrations plugins to 3.3.3 which fixes CVE-2020-15813, provides bugfixes and new features.
Solves security issue mentioned in #94001 for nixos-unstable.
/cc @Ma27

Motivation for this change
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[x] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[x] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[x] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

@GrahamcOfBorg test graylog


Test & debug aws health events alert

Check if it captures the personal AWS Health Dashboard events.

The test happened, and it works.


implementation not found: hipExtLaunchMultiKernelMultiDevice

Hi, I'm on HIP tag roc-3.0.0 and I cannot build TensorFlow r1.15-rocm due to librccl.so: undefined symbol: hipExtLaunchMultiKernelMultiDevice.
In my /home/nick/projects/ROCm/HIP/build/hip_prof_gen.log.txt log file, there is a warning:
Warning: implementation not found: hipExtLaunchMultiKernelMultiDevice

Below are instructions how I build HIP:
$ cd ~/projects/ROCm/HIP

Patchhipify-clang/CMakeLists.txt:
@@ -7,6 +7,9 @@ if (MSVC AND MSVC_VERSION VERSION_LESS "1900")
     return()
 endif()

+find_package(Z3 HINTS /opt/z3/lib/cmake/z3)
+include_directories(${Z3_CXX_INCLUDE_DIRS})
+
 find_package(LLVM REQUIRED)
 message(STATUS "Found LLVM ${LLVM_PACKAGE_VERSION}:")
 message(STATUS "   - CMake module path: ${LLVM_CMAKE_DIR}")

Patch bin/hipcc:
@@ -217,6 +217,7 @@ if ($HIP_PLATFORM eq "clang") {
       $HIPCXXFLAGS .= " -std=c++14 -fms-extensions -fms-compatibility";
     } else {
       $HIPCXXFLAGS .= " -std=c++11";
+      $HIPCXXFLAGS .= " -D__HIP_VDI__";
     }
     $HIPCXXFLAGS .= " -isystem $HIP_CLANG_INCLUDE_PATH";
     $HIPLDFLAGS .= " -L$HIP_LIB_PATH";

Build, compile, and install:
$ mkdir build
$ cd build
$ cmake -DCMAKE_INSTALL_PREFIX=/opt/rocm/hip -DHSA_PATH=/opt/rocm/hsa -DBUILD_HIPIFY_CLANG=ON -DHIP_COMPILER=clang -DCMAKE_BUILD_TYPE=Release ..
$ make -j 16
$ sudo make -j 16 install
$ echo "/opt/rocm/hip/lib" | sudo tee /etc/ld.so.conf.d/hip.conf
$ sudo ldconfig
$ echo "export HIP_PATH=/opt/rocm/hip" | sudo tee -a /etc/profile.d/rocm.sh
$ echo "export HIPCC_VERBOSE=7" | sudo tee -a /etc/profile.d/rocm.sh

My hipconfig --full output:
HIP version  : 3.0.19493-36529b16

== hipconfig
HIP_PATH     : /opt/rocm/hip
HIP_PLATFORM : hcc
CPP_CONFIG   :  -D__HIP_PLATFORM_HCC__=   -I/opt/rocm/hip/include -I/opt/rocm/hcc/include -I/opt/rocm/hsa/include

== hcc
HSA_PATH     : /opt/rocm/hsa
HCC_HOME     : /opt/rocm/hcc
HCC clang version 10.0.0 (/home/nick/projects/ROCm/hcc/llvm-project/clang<PHONE_NUMBER>9e83a2ddd5abe0affe700723cdd852) (based on HCC 3.0.19502-286651a0-40756364719 )
Target: x86_64-unknown-linux-gnu
Thread model: posix
InstalledDir: /opt/rocm/hcc/bin
LLVM (http://llvm.org/):
  LLVM version 10.0.0svn
  Optimized build.
  Default target: x86_64-unknown-linux-gnu
  Host CPU: znver1

  Registered Targets:
    amdgcn - AMD GCN GPUs
    r600   - AMD GPUs HD2XXX-HD6XXX
    x86    - 32-bit X86: Pentium-Pro and above
    x86-64 - 64-bit X86: EM64T and AMD64
HCC-cxxflags :  -hc -std=c++amp -I/opt/rocm/hcc/includeHCC-ldflags  :  -hc -std=c++amp -L/opt/rocm/hcc/lib -Wl,--rpath=/opt/rocm/hcc/lib -ldl -lm -lpthread -lhc_am -Wl,--whole-archive -lmcwamp -Wl,--no-whole-archive

=== Environment Variables
PATH=/opt/rocm/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/usr/games:/usr/local/games:/snap/bin
HIP_CLANG_PATH=/opt/rocm/llvm/bin
HIPSYCL_CUDA_PATH=
HIP_PATH=/opt/rocm/hip
HIPCC_VERBOSE=7
HCC_HOME=/opt/rocm/hcc

== Linux Kernel
Hostname     : semtexrocm
Linux semtexrocm 5.2.0-rc1 #1 SMP Wed Feb 12 11:07:21 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
No LSB modules are available.
Distributor ID: Ubuntu
Description:    Ubuntu 18.04.3 LTS
Release:        18.04
Codename:       bionic

Here a simple example to reproduce (you may need to change directory according to your system):
$ mkdir ~/tmptest
$ cd ~/tmptest
$ cp ~/projects/ROCm/HIP/tests/src/test_common.h .
$ cp ~/projects/ROCm/HIP/tests/src/runtimeApi/module/hipExtLaunchMultiKernelMultiDevice.cpp .
$ hipcc hipExtLaunchMultiKernelMultiDevice.cpp -o exe

There will be error like:
/tmp/hipExtLaunchMultiKernelMultiDevice-20822f.o: In function `main':
hipExtLaunchMultiKernelMultiDevice.cpp:(.text+0x4ca): undefined reference to `hipExtLaunchMultiKernelMultiDevice'
clang-10: error: linker command failed with exit code 1 (use -v to see invocation)

@nikAizuddin,
With latest 'master' I don't see the issue . I could compile test hipExtLaunchMultiKernelMultiDevice successfully. Can you give a try with latest and let me know if you still see the issue?
Any specific reason why you are sticking to roc 3.0.x branch? It is always good to avoid very old version as there will be some known issues which are already fixed in latest.
Based on your response will take up next steps.

I could compile test hipExtLaunchMultiKernelMultiDevice successfully

That's weird, you are already using HIP that is build with clang is it? I could compile too if I build HIP with -DHIP_COMPILER=hcc.

Any specific reason why you are sticking to roc 3.0.x branch?

Because https://github.com/RadeonOpenCompute/ROCm/blob/rocm-3.0/default.xml uses roc-3.0.0 tag. I haven't tried latest master yet. I'm going to try it now.

@SarbojitAMD  Here I tried HIP clang with latest master commit d29ad504640ddf608368c0a97de5ef28a18b5fa0.
I tried compile hipExtLaunchMultiKernelMultiDevice.cpp:
$ hipcc hipExtLaunchMultiKernelMultiDevice.cpp

now I got a different error:
HIP_PATH=/opt/rocm/hip
HIP_PLATFORM=clang
HIP_CLANG_PATH=/opt/rocm/llvm/bin
HIP_CLANG_INCLUDE_PATH=/opt/rocm/llvm/lib/clang/10.0.0/include
HIP_INCLUDE_PATH=/opt/rocm/hip/include
HIP_LIB_PATH=/opt/rocm/hip/lib
DEVICE_LIB_PATH=/opt/rocm/lib
hipcc-args: hipExtLaunchMultiKernelMultiDevice.cpp
LoadLib(libhsa-ext-finalize64.so.1) failed: libhsa-ext-finalize64.so.1: cannot open shared object file: No such file or directory
LoadLib(libhsa-ext-image64.so.1) failed: libhsa-ext-image64.so.1: cannot open shared object file: No such file or directory
hipcc-cmd: /opt/rocm/llvm/bin/clang++  -std=c++11 -isystem /opt/rocm/llvm/lib/clang/10.0.0/include -isystem /opt/rocm/hsa/include -isystem /opt/rocm/hip/include -D__HIP_ARCH_GFX900__=1  --cuda-gpu-arch=gfx900 -O3 -mllvm -amdgpu-early-inline-all=true -mllvm -amdgpu-function-calls=false  --hip-device-lib-path=/opt/rocm/lib  -L/opt/rocm/hip/lib -Wl,--rpath-link=/opt/rocm/hip/lib -lhip_hcc --cuda-gpu-arch=gfx900 -O3 -lgcc_s -lgcc -lpthread -lm  -x hip hipExtLaunchMultiKernelMultiDevice.cpp
hipExtLaunchMultiKernelMultiDevice.cpp:119:5: error: use of undeclared identifier 'hipExtLaunchMultiKernelMultiDevice'
    hipExtLaunchMultiKernelMultiDevice(launchParamsList, nGpu, 0);
    ^
1 error generated when compiling for gfx900.

But if I add -D__HIP_VDI__ to the compilation such as:
$ hipcc -D__HIP_VDI__ hipExtLaunchMultiKernelMultiDevice.cpp

I'll get undefined reference to "hipExtLaunchMultiKernelMultiDevice":
HIP_PATH=/opt/rocm/hip
HIP_PLATFORM=clang
HIP_CLANG_PATH=/opt/rocm/llvm/bin
HIP_CLANG_INCLUDE_PATH=/opt/rocm/llvm/lib/clang/10.0.0/include
HIP_INCLUDE_PATH=/opt/rocm/hip/include
HIP_LIB_PATH=/opt/rocm/hip/lib
DEVICE_LIB_PATH=/opt/rocm/lib
hipcc-args: -D__HIP_VDI__ hipExtLaunchMultiKernelMultiDevice.cpp
LoadLib(libhsa-ext-finalize64.so.1) failed: libhsa-ext-finalize64.so.1: cannot open shared object file: No such file or directory
LoadLib(libhsa-ext-image64.so.1) failed: libhsa-ext-image64.so.1: cannot open shared object file: No such file or directory
hipcc-cmd: /opt/rocm/llvm/bin/clang++  -std=c++11 -isystem /opt/rocm/llvm/lib/clang/10.0.0/include -isystem /opt/rocm/hsa/include -isystem /opt/rocm/hip/include -D__HIP_ARCH_GFX900__=1  --cuda-gpu-arch=gfx900 -O3 -mllvm -amdgpu-early-inline-all=true -mllvm -amdgpu-function-calls=false  --hip-device-lib-path=/opt/rocm/lib  -L/opt/rocm/hip/lib -Wl,--rpath-link=/opt/rocm/hip/lib -lhip_hcc --cuda-gpu-arch=gfx900 -O3 -lgcc_s -lgcc -lpthread -lm  -D__HIP_VDI__ -x hip hipExtLaunchMultiKernelMultiDevice.cpp
/tmp/hipExtLaunchMultiKernelMultiDevice-ba34b8.o: In function `main':
hipExtLaunchMultiKernelMultiDevice.cpp:(.text+0x4ca): undefined reference to `hipExtLaunchMultiKernelMultiDevice'
clang-10: error: linker command failed with exit code 1 (use -v to see invocation)

I see the same things as @nikAizuddin: regular hcc-based hip can build the test program, while hip-clang either has the undeclared identifier error, or, with __HIP_VDI__, produces the undefined reference error. I'm on a built from source ROCm stack on NixOS; a difference in our builds is that my hip-clang is built against clang 11 (since the instructions just pull from the master branch of upstream llvm-project without specifying a revision, I likely just built my hip-clang a bit more recently).

@acowley @nikAizuddin
hip-clang is work in progress there are APIs which are yet to be enabled and hipExtLaunchMultiKernelMultiDevice one of them hence you are seeing the issue. Will update once support is enabled for hip-clang.

hipExtLaunchMultiKernelMultiDevice() implemented in rocm3.10 hence closing the ticket now.


Add technology uglifier for LES's

This seems to work locally:

However, if I try to save it (it does save):
Something goes wrong at ETEngine (for api/v3/scenarios/<scenario-id>/converters/stats):

Seems that strong parameters is needed for this to work. 🤔

Sorry for being thick: how does converting technologies to a hash fix the 401 Unauthorized response? Was ETMoses sending data in the wrong format?

Oh, I'm sorry for not explaining.
This is the current sitaution. Currently on beta there's still an error ocurring when trying to import a scenario for ETMoses. This is the error. The problem is the formatting.
After the couple of lines of fixing in this PR the other error bubbles up at ETEngine (probably due to the Rails 5 upgrade I can imagine).

Got it, thanks!
You're right about the strong params in ETEngine. ConverterController#stats needs the following change:
- keys = params.require(:keys)
+ keys = params.require(:keys).permit!.to_h

I created a PR here: https://github.com/quintel/etengine/pull/999


Fixes #938: consolidating macro use on time.html

Fixes #938: consolidating macro use on time.html
Test by visiting any page with a date like the events.

:+1:

:+1:


Color Picker Roll Back Changes

Just noticed that the color picker no longer shows hex value along with RGB value. As a web designer, it helps a lot if I have access to both values. Also, I am aware that I can choose to copy the RGB value only from the settings menu. Please bring back that feature in the next update.

@SauronsEyes

This could become obsolete for you whe we release the ColorPicker V2 (#5379).
I wouldn't roll back the changes. But maybe we could have an option for this.

Yeah sure, you could add a check box to enable/disable the option. And wow thanks for the quick reply :V

We won't fix it in the current version since the new version will provide it.


Add DG and Target user profile, value proposition, and user stories u…

…p to 1.2 only

Codecov Report

Merging #57 (2a0b995) into master (201e2e1) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master      #57   +/-   ##
=========================================
  Coverage     72.15%   72.15%
  Complexity      399      399
=========================================
  Files            70       70
  Lines          1232     1232
  Branches        125      125
=========================================
  Hits            889      889
  Misses          311      311
  Partials         32       32

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 201e2e1...2a0b995. Read the comment docs.


Fix datahub data source provider

What changes were proposed in this pull request?
(Please fill in changes proposed in this fix)
How was this patch tested?
(Please explain how this patch was tested. E.g. unit tests, integration tests, manual tests)
(Refer to this test guide)

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.jiru.whf seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.

Could you please give more description about this PR?

We're closing this PR because it hasn't been updated in a while.


AppBar.leading BackButton issue in RTL, flutter version 3.24.0

Steps to reproduce

Run the code sample (RTL mode), I did test an ios simulator, iPhone 15 Plus.

This happens whether you put an explicit BackButton, or use an implied (default) one.
Expected results
The back button should change the direction for RTL, and should be padded from the right edge.
Actual results
The button is not padded and seems to be out of bounds of screen a bit, and the direction is not changed.
Code sample
Code sample
import 'package:flutter/material.dart';

void main() {
  runApp(
    MaterialApp(
      home: Directionality(
        textDirection: TextDirection.rtl,
        child: Scaffold(
          appBar: AppBar(
            leading: const BackButton(),
          ),
        ),
      ),
    ),
  );
}

Screenshots or Video

Screenshots / Video demonstration

Logs
Logs
[Paste your logs here]

Flutter Doctor output
Doctor output
[✓] Flutter (Channel stable, 3.24.0, on macOS 14.5 23F79 darwin-arm64, locale en-LY)
[✓] Android toolchain - develop for Android devices (Android SDK version 34.0.0)
[✓] Xcode - develop for iOS and macOS (Xcode 15.2)
[✓] Chrome - develop for the web
[✓] Android Studio (version 2024.1)
[✓] IntelliJ IDEA Ultimate Edition (version 2023.3.3)
[✓] VS Code (version 1.91.1)

@erabti
This seems to be working as expected in latest master version, as shown below:

You can switch to it and confirm at your end. Since it works well in master, I will close this as fixed.

@darshankawar this is a breaking change, is there a plan to include this in a hotfix for the stable version?

Hot-fix request is open already : https://github.com/flutter/flutter/issues/153037


CSS is different between local development build and built for prod

🐛 Bug Report
When running docusaurus start the CSS is different than running docusaurus build followed by docusaurus serve.
Have you read the Contributing Guidelines on issues?
Yup
To Reproduce

Check out https://github.com/facebook/jest/pull/11229
Run yarn from root
cd into website/
Compare yarn docusaurus start and yarn docusaurus build && yarn docusaurus serve

Expected behavior

The website should look identical
Actual Behavior

The CSS looks different
Dev:

Prod:

I assume this is some bug in the ordering of css files when built vs running in dev mode.
Your Environment

Public source code: https://github.com/facebook/jest/tree/master/website
Public site url: https://jestjs.io/
Docusaurus version used: 2.0.0-alpha.c32d8bd11
Environment name and version: Chrome 89.0.4389.90, Node v14.16.0
Operating system and version (desktop or mobile): macOS Big Sur 11.2.3

Reproducible Demo
Checkout the branch from https://github.com/facebook/jest/pull/11229 (https://github.com/SimenB/jest/tree/remove-sass), instructions are above in this issue (it's just "run the website"). From that PR you can also see that the netlify preview shows the same CSS as the local docusarus build version

Hi,
As explained in DM, this is not an issue with Docusaurus itself but rather it's an issue with the site that has conflicting CSS rules that are too dependent on CSS insertion order.
CSS is code-splitted by Webpack and lazy-loaded and inserted in pages on demand.
For example when you go to https://jestjs.io/help, the following CSS files load:

Now when you navigate to the homepage you get new CSS files loaded on-demand:

This order may be different according to the navigation patterns of the user, and you should make sure that one CSS chunk does not mess-up with another CSS chunk.
That's why we use CSS-in-JS or methodologies like BEM: to avoid polluting the global CSS namespace and preventing this kind of problem from happening.
You didn't have this on Docusaurus 1 because on each navigation you "reset" the page CSS as it's not a real SPA navigation. The problem appears in Docusaurus 2 because it's an SPA navigation, but you'll have the same problem with CRA, Gatsby, Next, VuePress...
Let's continue this in DM and find a solution for the Jest website.
May also be related to https://github.com/facebook/docusaurus/issues/3678

I still think it's a bug that dev and prod do not agree on a fresh navigation (or refresh) on the same page. It's not about navigation in that case - some prod optimization breaks css insertion order. The fact other frameworks may or may not have the same bug doesn't make it any less of a bug.
But of course if we fix this for Jest it doesn't really impact me anymore, so I'm happy with that resolution 😀

It also affects other projects of the React ecosystem.
https://github.com/facebook/create-react-app/issues/7190
https://github.com/gatsbyjs/gatsby/issues/9733
https://github.com/gatsbyjs/gatsby/issues/9733
If you have any solution to fix this problem let me know, but I don't have any apart advising you to scope your styles and make them independent or insertion order and specificity issues.
All this is why we invented CSS in JS:
https://speakerdeck.com/vjeux/react-css-in-js

Here the problem is "non-deterministic resolution". It's not something new and it affects many sites for many years already.


5 credit card payments on a single order.

I'm not sure if the customer has pressed the checkout button five times or something, but it seems a customers credit card has been subtracted five times.

Hi Paul,
Better is to ask this kind of question to<EMAIL_ADDRESS>We will look into it.
Regards,
Rik
Adyen

Hi Paul,
The transactions are done separately to our system. Could you check if you have any exceptions in your checkout.
Regards,
RIk
Adyen

@rikterbeek We haven't experienced the same problem with more recent orders. Unfortunately our logs only go back for a few days, so I can't find what happened with this order.

I'll reopen an issue when we encounter it.


[Snyk] Upgrade @nodesecure/scanner from 3.4.0 to 3.4.1

This PR was automatically created by Snyk using the credentials of a real user.Snyk has created this PR to upgrade @nodesecure/scanner from 3.4.0 to 3.4.1.

:information_source: Keep your dependencies up-to-date. This makes it easier to fix existing vulnerabilities and to more quickly identify and fix newly disclosed vulnerabilities when they affect your project.

The recommended version is 1 version ahead of your current version.
The recommended version was released 22 days ago, on 2022-04-18.

Release notes

Package name: @nodesecure/scanner

3.4.1 - 2022-04-18What's Changed

docs: add antoine-coulon as a contributor for code, security by @ allcontributors in #34
fix: add location as options of hydratePayloadDependencies by @ fraxken in #39

Full Changelog: v3.4.0...v3.4.1

3.4.0 - 2022-03-18What's Changed

Add @ nodesecure/ci-action to GitHub workflow by @ antoine-coulon in #28
feat: add new option to include cwd devDependencies by @ fraxken in #29
Update dependencies by @ fraxken in #33

New Contributors

@ antoine-coulon made their first contribution in #28

Full Changelog: v3.3.0...v3.4.0

    from @nodesecure/scanner GitHub release notes

Commit messages

Package name: @nodesecure/scanner

10b4d8e 3.4.1
35eed83 Merge pull request #39 from NodeSecure/fix-vulnerabilities
1d4ff89 fix: add location as options of hydratePayloadDependencies
f62cca0 docs: add antoine-coulon as a contributor for code, security (#34)

Compare

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open upgrade PRs.
For more information:
🧐 View latest project report
🛠 Adjust upgrade PR settings
🔕 Ignore this dependency or unsubscribe from future upgrade PRs

@tony-go No i guess we need to wait that i merge my PR.


pkg/logging: redirect klog output to logurs

klog currently redirects all of its output to stderr which might
prevent users from detecting potentially error messages generated by
klog since the logging format is different from logrus. Redirecting klog
output to logrus will make the logging messages consistent.
Master:
level=info msg="Waiting until all pre-existing resources related to policy have been received" subsys=k8s-watcher
W0410 09:55:21.017837   31587 reflector.go:402] githu....

With commit:
level=info msg="Waiting until all pre-existing resources related to policy have been received" subsys=k8s-watcher
level=warning msg="github.com/cilium/cilium/pkg/k8s/watchers/network_p...
level=info msg="github.com/cilium/cilium/pkg/k8s/watchers/network_p...

Unfortunately, klog as a bug / feature that prints the each log level
message on each writer. This will be fixed upstream.
Candidate to backport this to 1.7?

test-me-please

test-me-please

I think 1.7 backport makes sense, to pick up on issues in user environments. v1.7 will be supported for some time yet.

test-me-please

Coverage increased (+0.02%) to 46.661% when pulling ce1e84823a4749c2f86295153610ea641d73d172 on pr/set-klog-to-logrus into 7abdfa3b1819d99749f9bf478f7732022bd15602 on master.

hit #10118


Input subsystem core implementation

Hi, this is the first PR for the input subsystem, adding the core functionalities, sample, testing and documentation. This has been proposed in https://github.com/zephyrproject-rtos/zephyr/issues/54622 and is built on the proof of concept code presented there and in the architecture WG.
Tentatively planning to follow-up with the kscan adapter implementation, porting over the zephyr,gpio-keys driver and then the three kscan keyboard drivers (npcx, mchp and ite, there's some code dedup opportunity there).

Zbus can handle all the event work done here without significant overhead. I think you should use zbus for this part. I will propose an alternative using zbus. If we have a Zephyr message bus in the RTOS, using another implementation of the same thing would be strange to an official input driver. Don't you fellows think? @fabiobaltieri @gmarull

I haven't checked in detail, but from what I heard in the Arch WG, ZBus could be added as another option, so you'd have callbacks, thread+queue and zbus. I guess it's the most flexible solution.

Major updates:

bunch of inline doc update, kconfig help etc
dropped most options from the sample project conf
added configurable thread priority
renamed INPUT_QUEUE_SIZE to INPUT_QUEUE_MAX_MSGS

Zbus can handle all the event work done here without significant overhead. I think you should use zbus for this part. I will propose an alternative using zbus. If we have a Zephyr message bus in the RTOS, using another implementation of the same thing would be strange to an official input driver. Don't you fellows think? @fabiobaltieri @gmarull

I haven't checked in detail, but from what I heard in the Arch WG, ZBus could be added as another option, so you'd have callbacks, thread+queue and zbus. I guess it's the most flexible solution.

Yeah that was the idea, there should be a third option for direct integration for applications using zbus for other stuff as well, would love it as a followup feature. I could convert the THREAD option to a choice to facilitate that.

Reworked the Kconfig to have an INPUT_MODE choice that can be set to either INPUT_MODE_SYNCHRONOUS or INPUT_MODE_THREAD, should make it easier to extend, cleans the help text a bit too.

fixed few more inline doc refs

@gmarull

I haven't checked in detail, but from what I heard in the Arch WG, ZBus could be added as another option, so you'd have callbacks, thread+queue and zbus. I guess it's the most flexible solution.

Makes sense. I can provide the zbus code if you guys think it is ok.

@gmarull

I haven't checked in detail, but from what I heard in the Arch WG, ZBus could be added as another option, so you'd have callbacks, thread+queue and zbus. I guess it's the most flexible solution.

Makes sense. I can provide the zbus code if you guys think it is ok.

Of course!

@gmarull  @fabiobaltieri I have created a PR to Fabio's fork, adding zbus to the input subsystem. https://github.com/fabiobaltieri/zephyr/pull/1. Please take a look and let me know what you guys think. I made some changes regarding struct input_event to optimize the usage and improve readability.

@gmarull @fabiobaltieri I have created a PR to Fabio's fork, adding zbus to the input subsystem. fabiobaltieri#1. Please take a look and let me know what you guys think. I made some changes regarding struct input_event to optimize the usage and improve readability.

No rush, wait for this PR to be reviewed and merged and then you can open a PR on the main project.

@fabiobaltieri

No rush, wait for this PR to be reviewed and merged and then you can open a PR on the main project.

Ok. The majority of the work is done already.

Changes in this push

reworked the input data structure to have an explicit flag field for sync, shrank the type down to 8 bit (which should be plenty enough anyway), reserved 0xf0 to 0xff now. Changed the callback API and rest of the code to match. This is to make it easier to pass the structure around on message system that can only pass a pointer. This is a change from the RFC and one more change from the Linux structure that inspired this, but I think it makes sense in this context.
dropped empty drivers/input.h

@fabiobaltieri please rebase

rebased (merge conflict on maintainer file)

Also needs an entry in the API table

Yeah good point.

few more inline doc fixes
added an entry in docs/develop/api/overview

Couple other suggestions for the docs. At least I got confused about whether input_report() is a function or a family of functions from just reading the documentation. Since the answer is "both", I think this could be made clearer

Cool, all applied.