psutil: 5.9.0 -> 5.9.1

Description of changes
Release notes:
5.9.1
2022-05-20
Enhancements

1053_: drop Python 2.6 support.  (patches by Matthieu Darbois and Hugo van
Kemenade)
2050_, [Linux]: increase read(2) buffer size from 1k to 32k when reading
/proc pseudo files line by line. This should help having more consistent
results.
2057_, [OpenBSD]: add support for cpu_freq()_.
2107_, [Linux]: Process.memory_full_info()_ (reporting process USS/PSS/Swap
memory) now reads /proc/pid/smaps_rollup instead of /proc/pids/smaps,
which makes it 5 times faster.

Bug fixes

2048_: AttributeError is raised if psutil.Error class is raised
manually and passed through str.
2049_, [Linux]: cpu_freq()_ erroneously returns curr value in GHz while
min and max are in MHz.
2050_, [Linux]: virtual_memory()_ may raise ValueError if running in a
LCX container.

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage

It built a ton of stuff, failed the first couple times due to running out of disk space, then I think it succeeded? I'm really not sure what happened

[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.11 Release Notes (or backporting 22.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[X] Fits CONTRIBUTING.md.
[X] ALSO tested by building s-tui before and after psutil update. Before it reports CPU frequency in GHz labeled as MHz, after it reports in MHz labeled as MHz.

This should get backported to 22.05, but I think I don't have permission to add the label. There's supposed to be a gear next the "Labels" in the sidebar but I don't see one. Can someone add the label? Or give me the permissions to do so.

:/ OK


.macos: Enable firewall and set sensible defaults

This enables the macOS firewall and also set sensible defaults such as enabling stealth mode (no response to ping / ICMP requests).

These changes are already pending in #686.

Did not see that. Looks much more extensive - thus closing this PR.

Still, you can help me advocate for a merge of security-related config at #686! :)


Make Azure SQL FOG resource depend on secondary DB creation

Fixes https://github.com/cloudfoundry-incubator/csb-brokerpak-azure/issues/8

Fixes #8


[Avatar] Add ability to change fallback icon

Duplicates

[X] I have searched the existing issues

Latest version

[X] I have tested the latest version

Summary 💡
The fallback icon used for Avatar is hard-coded to be the MUI Person icon. This should be configurable through props for MUI consumers using a different icon library.
Examples 🌈
Pagination exposes a components prop that lets consumers specify first, last, next, and previous icons.
Motivation 🔦
We are using MUI as a base for a component library with different designs and icons. We temporarily worked around this by providing our own icon as the default children prop, but this effectively removes the alt -> letter feature. This required us to provide extra documentation to explain the difference from default MUI behavior.

Take a look at https://mui.com/material-ui/react-avatar/#fallbacks. You can basically provide the fallback with either children, the first letter of the alt, or use the default. This gives you enough flexibility for all three scenarios

I don't think this completely covers what I'm asking for - the fallbacks documentation referenced says the following:

If there is an error loading the avatar image, the component falls back to an alternative in the following order:

the provided children
the first letter of the alt text
a generic avatar icon

By providing our icon in children it will never fall back to the first letter of the alt text. I'll accept this as "closed/won't fix" and continue to document the difference in behavior on our end.

@jake-collibra
Try this in the root of your MUI theme file:
      MuiAvatar: {
        styleOverrides: {
          root: {
            '.MuiAvatar-fallback': {
              background: `url(${DefaultProfileImage.src}) center no-repeat`,
              backgroundSize: '100% 100%',
              width: '100%',
              height: '100%',
              path: {
                display: 'none',
              },
            },
          },
        },
      },

@alexander-vashchuk This would work with a default image, but I'm trying to replace the SVG with my own. I attempted the same using the source of the SVG in a data tag passed to the URL, but with no luck.
I'm still waiting for this functionality.


Events / Signals

Steam user suggested this:

I think it would be great to have an event detector on timed traffic lights.
For example on an intersection with a low-usage tram line: the intersection works like there was no tram line, but when a tram shows up, traffic lights change to a certain defined state (and pauses the loop, or even just background it), then switches back to the loop.

So event can, in this case, switch between traffic light programmes.
There could be various triggers (if we can find really fast no-performance-impact way to do this sort of stuff) for example:

Certain vehicle class approaching
Vehicles on certain lane
Time-based (eg. allow tidal lanes)

Events could affect any of the features - junction restrictions / priority signs / traffic lights / etc.
Just the time-based event alone could facilitate most if not all the stuff in https://github.com/krzychu124/Cities-Skylines-Traffic-Manager-President-Edition/milestone/11

I love that, and I think that good starting point would be to check how CO made a level crossings (auto-close on approaching train)

If events were chained it could perhaps facilitate #11

Step 1. Design a thread-safe super cheap message/event passing mechanism
Step 2. Ensure that if event/message was not processed, it would not fill up the mailbox in the receiver, maybe allow one event of a kind, and maybe some time-to-live when it becomes obsolete.
Step 3. Send messages and enjoy crossings knowing the car situation.

Just saw this posted on Reddit, which would be perfect example of where event/signal system could be useful:


Fixed compilation when building with APPLICATION_EXTENSION_API_ONLY

Fixes #351.
Unfortunately this code path isn't hit on tests so I couldn't verify if it works.
I considered other approaches, such as using @available(iOSApplicationExtension, unavailable), but that would have required a major refactor because the drawHierarchyInKeyWindow comes from several layers up.

Thank you!


icmpv6: fix repr parsing panic with packets 40-43 bytes long

this is a followup to #807, I read the code again and it turned out to be wrong

Could you add a previously-failing test?

ok


Correct typo- Changed dependencyReport TO htmlDependencyReport

Context

Correcting the typo will ensure that the doc does not seem confusing to the users.

Contributor Checklist

[ ] Review Contribution Guidelines
[ ] Make sure that all commits are signed off to indicate that you agree to the terms of Developer Certificate of Origin.
[ ] Check "Allow edit from maintainers" option in pull request so that additional changes can be pushed by Gradle team
[ ] Provide integration tests (under <subproject>/src/integTest) to verify changes from a user perspective
[ ] Provide unit tests (under <subproject>/src/test) to verify logic
[ ] Update User Guide, DSL Reference, and Javadoc for public-facing changes
[ ] Ensure that tests pass locally: ./gradlew <changed-subproject>:check

Gradle Core Team Checklist

[ ] Verify design and implementation
[ ] Verify test coverage and CI build status
[ ] Verify documentation
[ ] Recognize contributor in release notes

Closing the PR, as unable to resolve conflicts. Will open a new PR

Changed my mind. Polluting with unnecessary PRs doesn't make sense. Have posted on Stackoverflow, awaiting response. If someone here could suggest how to resolve this conflict, it would be really great.


Create or choose a license

Create or (most likely) choose a license for the application.

Revised BSD License has been chosen and added.


Ontology contains a class _undefined_primitive_term

looks like a mistake:

This comes from OGMS. However, since we do not rely on any of these classes, I have removed them.


Add Account Id To Zone Creation

According to the docs, this is a required parameter.
Closes #189

@jacobbednarz thanks for all the feedback! I think I've addressed everything


VS2017 RC4 does not package multi-target projects

I've used an existing solution and a new solution after installing RC4. I'm finding that the package on build setting is not working where the project uses multi-targeting.
Here is an example proj file updated after creating a new core library.
<Project Sdk="Microsoft.NET.Sdk">

  <PropertyGroup>
    <TargetFrameworks>netcoreapp1.0;net452</TargetFrameworks>
    <GeneratePackageOnBuild>True</GeneratePackageOnBuild>
  </PropertyGroup>

</Project>

The original value was <TargetFramework>netcoreapp1.0</TargetFramework> which did produce the package on build.
The package is no longer built if the element is changed to  <TargetFrameworks>netcoreapp1.0</TargetFrameworks> and defining either a single TFM or mulitple.

I just tried and could repro this with rebuild: https://github.com/NuGet/Home/issues/4527. Does it work for you if you just "build"?

Yes, I was just doing rebuilds. I can also confirm that the package is built with build, but not rebuild.

Great, I'll dupe it against https://github.com/NuGet/Home/issues/4527. Thanks!


[Question]: Issues when fine tuning embedding model BAAI/bge-m3 with llama index fine-tuning guide

Question Validation

[X] I have searched both the documentation and discord for an answer.

Question
Hi everyone, I am trying to fine-tune an embedding model called BAAI/bge-m3 and im following this guide: https://docs.llamaindex.ai/en/stable/examples/finetuning/embeddings/finetune_embedding.html
I already did the fine tuning part and evaluated OpenAI ada, the bge-m3 model but I am now stuck evaluating my fine tuned model.
I got this function:
from tqdm.auto import tqdm
import gc
def memory_evaluate(
dataset,
embed_model,
top_k=5,
verbose=False,
batch_size=3 # Adjust batch size based on your memory constraints
):
corpus = dataset.corpus
queries = dataset.queries
relevant_docs = dataset.relevant_docs
Initialize the VectorStoreIndex outside the loop with all nodes
nodes = [TextNode(id_=id_, text=text) for id_, text in corpus.items()]
index = VectorStoreIndex(
nodes=nodes,
embed_model=embed_model,
show_progress=verbose
)
retriever = index.as_retriever(similarity_top_k=top_k)
eval_results = []
Convert queries to a list of items for batch processing
query_items = list(queries.items())
Process queries in batches to manage memory usage
for i in tqdm(range(0, len(query_items), batch_size), disable=not verbose):
batch_queries = query_items[i:i+batch_size]
for query_id, query in batch_queries:
    retrieved_nodes = retriever.retrieve(query)
    retrieved_ids = [node.node.node_id for node in retrieved_nodes]
    expected_id = relevant_docs[query_id][0]
    is_hit = expected_id in retrieved_ids  # assume 1 relevant doc

    eval_result = {
        "is_hit": is_hit,
        "retrieved": retrieved_ids,
        "expected": expected_id,
        "query": query_id,
    }
    eval_results.append(eval_result)

    # Clean up to free memory
    del retrieved_nodes, retrieved_ids
    gc.collect()

return eval_results
but when I run this:
finetuned_model = "local:/content/drive/MyDrive/model_output_test"
val_results_finetuned = memory_evaluate(val_dataset, finetuned_model)
I get this error:
ValueError Traceback (most recent call last)
in <cell line: 1>()
----> 1 val_results_finetuned = memory_evaluate(val_dataset, finetuned_model)
5 frames
/usr/local/lib/python3.10/dist-packages/transformers/models/auto/configuration_auto.py in from_pretrained(cls, pretrained_model_name_or_path, **kwargs)
1141 return CONFIG_MAPPING[pattern].from_dict(config_dict, **unused_kwargs)
1142
-> 1143 raise ValueError(
1144 f"Unrecognized model in {pretrained_model_name_or_path}. "
1145 f"Should have a model_type key in its {CONFIG_NAME}, or contain one of the following strings "
ValueError: Unrecognized model in /content/drive/MyDrive/model_output_test. Should have a model_type key in its config.json, or contain one of the following strings in its name: albert, align, altclip, audio-spectrogram-transformer, autoformer, bark, bart, beit, bert, bert-generation, ....
I know that the model type is missing from the config.json file but when i opened it look a bit weird, here it is what it said:
{"in_features": 1024, "out_features": 1024, "bias": false}. I also tried adding the model_tyoe to xlm-roberta but wasn't succesful either.
Does anyone knows the error?
Thank you for taking the time to read this!

Maybe try pip install --upgrade transformers ?

Maybe try pip install --upgrade transformers ?

I tried but still have the same issue as before. Do I have to fine-tune again the model with the transformers library updated or just use the evaluate function again?
I just tried using the evaluate function again with the transformers library updated but I did not fine-tune  it again.


replaced fmt with more specific term throughout howfairis and its tests

List of related issues or pull requests
Refs: #173
Describe the changes made in this pull request
fmt -> more descriptive var name
Instructions to review the pull request

Thank you sir


chore(deps): upgrade compiler dependencies

Upgrades project dependencies. See details in workflow run.

Automatically created by projen via the "upgrade-compiler-dependencies-k8s-25-main" workflow

⚪ Backport skipped
The pull request was not backported as there were no branches to backport to. If this is a mistake, please apply the desired version labels or run the backport tool manually.
Manual backport
To create the backport manually run:
backport --pr 3715

Questions ?
Please refer to the Backport tool documentation


[CU-868avn8pq] Lazily loads lottie animations

Task linked: CU-868avn8pq Lazy load components that use react-lottie


Enable Multi GPU Training for AutoMM Detection

Enabled multi gpu training.
Added 2 options for validation metric: using val loss or mAP:

Using val loss is much faster and good for small models like yolov3_mobilenetv2_320_300e_coco
Using mAP gives better performance and the longer validation time is negligible for medium/large models.

Copied torchmetrics mAP implementation and wait for their stable release with this bug and this bug fixed.
Completed TODOs:

infer ROIS type correctly in evaluation/prediction, and remove col_name hardcode
correctly transform label for detection and remove reset_index
move data unpack to collate function, remove .to(self.device) in lit_mmdet.

For reviewers I'll suggest to skip the map.py where it contains the torchmetrics mAP implementation (in 0.8.0) with only one line fix as described here.
For the model's performance please see internal quip document.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@FANGAreNotGnu I think torchmetrics 0.10.1 has just been released https://github.com/Lightning-AI/metrics/releases/tag/v0.10.1 and it's available in pypi. We may not need map.py anymore.


Error: [PostgreSQL error] failed to retrieve server_version_num: host or service not provided, or not known

Please read the CONTRIBUTING.md guidelines to learn on which channels you can
seek for help and ask general questions:
https://github.com/Kong/kong/blob/master/CONTRIBUTING.md#where-to-seek-for-help
Summary
SUMMARY_GOES_HERE
Steps To Reproduce

Additional Details & Logs

Kong version ($ kong version)
Kong debug-level startup logs ($ kong start --vv)
Kong error logs (<KONG_PREFIX>/logs/error.log)
Kong configuration (the output of a GET request to Kong's Admin port - see
https://docs.konghq.com/latest/admin-api/#retrieve-node-information)
Operating system

Check if the Kong container can reach postgres at the host you defined?

Even in the same network, you still need to tell Kong the ip address of your postgresDB. So use --link would solve your problem.  The following worked perfectly for me. @adarshcr1
docker run -d --name kong-database \
                -p 5432:5432 \
                -e "POSTGRES_USER=kong" \
                -e "POSTGRES_DB=kong" \
                postgres:9.6

sleep 5

docker run --rm \
    --link kong-database:kong-database \
    -e "KONG_DATABASE=postgres" \
    -e "KONG_PG_HOST=kong-database" \
    kong:1.0.3-alpine kong migrations bootstrap

Or without using legacy --link, you can use
docker network create my-network

docker run -d --name kong-database \
    --network my-network \
    -p 5432:5432 \
    -e "POSTGRES_USER=kong" \
    -e "POSTGRES_DB=kong" \
    postgres:9.6

docker run --rm \
    --network my-network \
    -e "KONG_DATABASE=postgres" \
    -e "KONG_PG_HOST=kong-database" \
    kong:1.0.3-alpine kong migrations bootstrap

Thank you .got it

I have tried to run @brianhuangyl example, but same error:
cb62c03cac3d057d2e6d592291769689c1378e67476523d54ff5d0ba674fa742
Error: [PostgreSQL error] failed to retrieve server_version_num: host or service not provided, or not known

  Run with --v (verbose) or --vv (debug) for more details

some more information:
$ docker --version
Docker version 19.03.6-ce, build 369ce74a3c

$ uname -r
5.5.4-arch1-1

This error indicates the Kong instance can't talk to your postgres server.
Run a debug container and try and connect to the postgres server I believe you'll find it's not possible. Official docs for running Kong in docker are here https://docs.konghq.com/install/docker/

I have tried to run @brianhuangyl example, but same error:
cb62c03cac3d057d2e6d592291769689c1378e67476523d54ff5d0ba674fa742
Error: [PostgreSQL error] failed to retrieve server_version_num: host or service not provided, or not known

  Run with --v (verbose) or --vv (debug) for more details

some more information:
$ docker --version
Docker version 19.03.6-ce, build 369ce74a3c

$ uname -r
5.5.4-arch1-1

So am I

Same issue I have encountered as well. Any idea

The postgresql docker container has been updated recently to require a password. This is reflected in our docker-compose.
This error indicates Kong cannot communicate with the postgresql database that's where your efforts should be focused on debugging. Use a shell where Kong is running from and try the same connection parameters to demonstrate the issue

I met the same issue. It seems you have to specify KONG_PG_PASSWORD param when execute  "docker run kong"

@hutchic Thank you for your pointers, I am able to bring it by setting KONG_PG_PASSWORD

Thanks. setting KONG_PG_PASSWORD resolved this.
On Thursday, March 5, 2020, 07:13:17 PM PST, merkerxu<EMAIL_ADDRESS>wrote:
I met the same issue. It seems you have to specify KONG_PG_PASSWORD param when execute "docker run kong"
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or unsubscribe.

If you are loading your configuration from kong.conf use flag -c 'path/to/kong.conf', otherwise load your configurations into environment variables

it worked for me like this
docker run --rm \
--link kong-database:kong-database \
--network kong-net
-e "KONG_DATABASE=postgres" \
-e "KONG_PG_HOST=kong-database" \
-e "KONG_PG_USER=kong" \
-e "KONG_PG_PASSWORD=xxxxxxx" \
kong:latest kong migrations bootstrap

docker run --rm --link kong-database:kong-database --network kong-net -e "KONG_DATABASE=postgres" -e "KONG_PG_HOST=kong-database" -e "KONG_PG_USER=kong" -e "KONG_PG_PASSWORD=kong" kong:latest kong migrations bootstrap
Error: [PostgreSQL error] failed to retrieve PostgreSQL server_version_num: temporary failure in name resolution
Run with --v (verbose) or --vv (debug) for more details

I've the similar error logs:
Error: [PostgreSQL error] failed to retrieve PostgreSQL server_version_num: Host is unreachable
Error: [PostgreSQL error] failed to retrieve PostgreSQL server_version_num: temporary failure in name resolution
docker version: 18.06.3-ce
When I switch docker to 18.09.5, those errors disappear.
some more information:
$ uname -r
4.18.0-269.el8.x86_64

Was still getting this error but as @hutchic pointed out my Postgres container was exiting as soon as it started since I had not provided a POSTGRES_PASSWORD field. The following commands worked for me
docker run -d --name kong-database --network=kong-net -p 5555:5432 -e "POSTGRES_USER=kong" -e "POSTGRES_DB=kong" -e "POSTGRES_PASSWORD=helloworld" postgres:9.6

docker run --rm --link kong-database:kong-database --network=kong-net -e "KONG_DATABASE=postgres" -e "KONG_PG_HOST=kong-database" -e "KONG_PG_PASSWORD=helloworld" kong:latest kong migrations bootstrap

Same error @RonLek even with this :(

@hutchic I am facing this issue even after providing password. I am using postgres 13.
when i try to deploy postgres from sub chart of kong, it works fine but when i deploy postgres from postgres operator and try to connect, kong failed to connect. can you please help me to resolve this

Was still getting this error but as @hutchic pointed out my Postgres container was exiting as soon as it started since I had not provided a POSTGRES_PASSWORD field. The following commands worked for me
docker run -d --name kong-database --network=kong-net -p 5555:5432 -e "POSTGRES_USER=kong" -e "POSTGRES_DB=kong" -e "POSTGRES_PASSWORD=helloworld" postgres:9.6

docker run --rm --link kong-database:kong-database --network=kong-net -e "KONG_DATABASE=postgres" -e "KONG_PG_HOST=kong-database" -e "KONG_PG_PASSWORD=helloworld" kong:latest kong migrations bootstrap

Thanks!! This works for me as well!

sleep 5
Saved my life


MediaSessionService: ANR specifically when using C.USAGE_ALARM with setDeviceVolumeControlEnabled(true)

Version
Media3 main branch
More version details
SHA-1: c35a9d62baec57118ea898e271ac66819399649b

Bump media3 version to 1.4.1

Devices that reproduce the issue

xgody  X_18 - SDK 29 (physical)
moto g04s - SDK 34 (physical)
Pixel 8 pro -  SDK 34 (emulated)
Pixel 8 pro -  SDK 35 (emulated)

Devices that do not reproduce the issue
No response
Reproducible in the demo app?
Yes
Reproduction steps
Modify 'demo-session-service' -> DemoPlaybackService.kt

adding  .setDeviceVolumeControlEnabled(true) to ExoPlayer.Builder
adding custom AudioAttributes with C.USAGE_ALARM

  @OptIn(UnstableApi::class) private fun initializeSessionAndPlayer() {

    Log.i("DemoPlaybackService", "initializeSessionAndPlayer called")

    val musicAudioAttributes = AudioAttributes.Builder()
      .setUsage(C.USAGE_ALARM) // not working
      //.setUsage(C.USAGE_MEDIA) // working
      .build()

    val player =
      ExoPlayer.Builder(this)
        .setDeviceVolumeControlEnabled(true) // adding this causes the error
        .setAudioAttributes(musicAudioAttributes, /* handleAudioFocus= */ false)
        .build()
    player.addAnalyticsListener(EventLogger())

    mediaLibrarySession =
      MediaLibrarySession.Builder(this, player, createLibrarySessionCallback())
        .also { builder -> getSingleTopActivity()?.let { builder.setSessionActivity(it) } }
        .build()
  }

Expected result
Opens successfully
Actual result
ANR: "Media3 Session Demo isn't responding"
Media
Not applicable

Thanks for reporting @rphm! I could reproduce the issue locally.
After some debugging, I can see that we end up in DefaultAnalyticsCollector:
https://github.com/androidx/media/blob/c35a9d62baec57118ea898e271ac66819399649b/libraries/exoplayer/src/main/java/androidx/media3/exoplayer/analytics/DefaultAnalyticsCollector.java#L779-L786
https://github.com/androidx/media/blob/c35a9d62baec57118ea898e271ac66819399649b/libraries/exoplayer/src/main/java/androidx/media3/exoplayer/analytics/DefaultAnalyticsCollector.java#L788-L795
And we can't complete this generateCurrentPlayerMediaPeriodEventTime(); because we don't have any MediaItems in the queue yet and getCurrentMediaItemIndex requires:
https://github.com/androidx/media/blob/c35a9d62baec57118ea898e271ac66819399649b/libraries/exoplayer/src/main/java/androidx/media3/exoplayer/ExoPlayerImpl.java#L1121-L1126
https://github.com/androidx/media/blob/c35a9d62baec57118ea898e271ac66819399649b/libraries/exoplayer/src/main/java/androidx/media3/exoplayer/ExoPlayerImpl.java#L2882-L2885
We block on Exoplayer's constructor and of course by that point Exoplayer Builder hasn't built yet because we are still trying to set the new stream type (from the Default=Music to new Alarm) and notifying all the listeners
https://github.com/androidx/media/blob/c35a9d62baec57118ea898e271ac66819399649b/libraries/exoplayer/src/main/java/androidx/media3/exoplayer/ExoPlayerImpl.java#L417-L420
I will look into what other Event times we can generate at that point to avoid this catch-22

instead of changing the eventTime, we decided to avoid both onDeviceInfoChanged and onDeviceVolumeChanged callbacks by initializing the StreamVolumeManager straight away with the correct stream type (rather than setting it with "music/media" and then notifying the listeners that it changed to "alarm").
Thank you for catching this bug! You should see the fix in the next published version (probably 1.5.0-beta01)


TypeError: Failed to parse URL from /api/tina/gql

Cloned repo, followed setup instructions to a T.
As noted in title, getting an error at first run of the starter.
 ⨯ TypeError: Failed to parse URL from /api/tina/gql
    at Object.fetch (node:internal/deps/undici/undici:11730:11)
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
    at async TinaClient.request (file:///Users/aaroncohen/dev/web/handstand/node_modules/tinacms/dist/client.mjs:33:17)
    at async requester (webpack-internal:///./tina/__generated__/types.ts:193:22)
    at async getStaticProps (webpack-internal:///./pages/index.tsx:43:23) {
  page: '/',
  [cause]: TypeError: Invalid URL
      at new URL (node:internal/url:775:36)
      at new Request (node:internal/deps/undici/undici:5270:25)
      at fetch (node:internal/deps/undici/undici:9508:25)
      at Object.fetch (node:internal/deps/undici/undici:11728:18)
      at fetch (node:internal/process/pre_execution:314:27)
      at TinaClient.request (file:///Users/aaroncohen/dev/web/handstand/node_modules/tinacms/dist/client.mjs:33:23)
      at requester (webpack-internal:///./tina/__generated__/types.ts:193:35)
      at Object.page (webpack-internal:///./tina/__generated__/types.ts:177:20)
      at getStaticProps (webpack-internal:///./pages/index.tsx:43:100)
      at /Users/aaroncohen/dev/web/handstand/node_modules/next/dist/compiled/next-server/pages.runtime.dev.js:17:4070
      at /Users/aaroncohen/dev/web/handstand/node_modules/next/dist/server/lib/trace/tracer.js:133:36
      at NoopContextManager.with (/Users/aaroncohen/dev/web/handstand/node_modules/next/dist/compiled/@opentelemetry/api/index.js:1:7062)
      at ContextAPI.with (/Users/aaroncohen/dev/web/handstand/node_modules/next/dist/compiled/@opentelemetry/api/index.js:1:518)
      at NoopTracer.startActiveSpan (/Users/aaroncohen/dev/web/handstand/node_modules/next/dist/compiled/@opentelemetry/api/index.js:1:18093)
      at ProxyTracer.startActiveSpan (/Users/aaroncohen/dev/web/handstand/node_modules/next/dist/compiled/@opentelemetry/api/index.js:1:18854) {
    code: 'ERR_INVALID_URL',
    input: '/api/tina/gql'

I fixed this problem by changing contentApiUrlOverride to http://localhost:4001/graphql

This is a good answer, but in order to provide more flexibility, i used process.env.NEXT_PUBLIC_SITE_URL+"/api/tina/gql".

Hi, can't we have tina gql api wrapped in app/router since what I am seeing is the next build is not working, when I try to put it in prod.


Drop faster-pr-diff-options feature

https://github.com/sindresorhus/refined-github/issues/3551#issuecomment-692278619

As someone who uses this multiple times a day, why?

As someone who uses this multiple times a day, why?

ohhh its still there on enterprise... did not know that

ohhh its still there on enterprise... did not know that

It's not just on Enterprise, but on any commit. The feature is only disabled on PRs, so the readme is still up to date.


GAE standard bookshelf - step 5

Added a small logging.properties. Will merge once travis is happy.


chore: Update K8s version in GH Actions FVTs

Motivation
Kubeflow/KServe are targeting K8s 1.22, so ModelMesh functional tests should test on this version.
Modifications
The GitHub Actions workflow for FVTs was increased to 1.22.10 from 1.20.7. The Minikube version used
was also increased.
Result
Functional tests now run on K8s 1.22.

/lgtm


Add info page

Add an info page to the site so that visitors can see who made the site, why it was created, as well as visiting the GitHub page. The path for the page could be something like /info, and an info icon could be shown on the top left of the header to offset the gear icon/settings button.

The info path has been added


Removed Plugin Directory code from ExtensionsOrchestrator

Description
Removes plugin directory code from
Issues Resolved
#3696
Check List

[X ] New functionality includes testing.

[X ] All tests pass

[X ] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@peterzhuamazon do we have gradle check workflow enabled for feature branches?

@peterzhuamazon do we have gradle check workflow enabled for feature branches?

@owaiskazi19 seems like my initial assumption is not correct, at least the feature branch need a github actions yml to trigger.
Please let me know what are the branches I need to backport.
Thanks.

Please let me know what are the branches I need to backport.

Can you check with core team? For extensibility we have feature/extensions

@ryanbogan I have merged the gradle check into this feature/extensions branchs.
Please rebase your PR with upstream and you would get gradle check.
Thanks.

start gradle check

start gradle check

This won't work anymore. As we have moved our gradle check to GHA :)

start gradle check

This won't work anymore. As we have moved our gradle check to GHA :)

How can I run it again?

Hi Ryan, in order to trigger again just push another commit or rerun the workflow in the check list.
The latter probably requires repo admin access, but rebase your branch and push again can be done by everyone.


setText function doesn't erase the previous text, just draw the new text  above

There is a workaround just setText with null as text.
polyline.setText(null, textOptions); // erase the previous text
polyline.setText(newText, textOptions); // draw the new one

Yeah just chain it
polyline.setText(null).setText(newText, textOptions);


Institutions finale tests

finally done!

This looks great. I pushed a couple of small changes:

Reverted the schema consistency checks in the base Model method. I like this idea a lot, but unfortunately it breaks any model that uses nullable=False. The problem is that Spark, when it actually writes out the schema into the Parquet, changes all fields to be nullable=True, for some kind of compatibility reason. (See here.) Which means, when we then re-load the dataframe, the schema check fails since the Parquet thinks everything is nullable, but the declared schema thinks some fields aren't.
One solution would be to just never use nullable=True in our schemas, but that's a loss, since, at the application level, Spark does enforce the constraint when we do spark.createDataFrame(...). So we get an assurance that the non-nullable fields are populated at write-time, which is valuable.

In the institutions tests, moved the three fixtures into a conftest.py file, which just means that we don't have to explicitly import that df fixture, which was causing flake8 warnings.

Instead of using a separate spark_uuid4() helper function defined in institutions.utils, I moved this into the body of Institutions.build(). This was because, for some reason, the call to udf() spins up a SparkContext, or something, which then conflicts with the pytest-managed session when anything is imported from utils in the tests.

@wearpants Let me know if these changes look good, and let's merge. Thanks!

All looks fine but I might rename 'df' to institutions_df if you relocated
it since it's not the only data frame well have
On May 29, 2017 1:27 PM, "David McClure"<EMAIL_ADDRESS>wrote:

This looks great. I pushed a couple of small changes:

Reverted the schema consistency checks in the base Model method. I
like this idea a lot, but unfortunately it breaks any model that uses
nullable=False. The problem is that Spark, when it actually writes out
the schema into the Parquet, changes all fields to be nullable=True,
for some kind of compatibility reason. (See here
https://github.com/apache/spark/blob/master/docs/sql-programming-guide.md#parquet-files.)
Which means, when we then re-load the dataframe, the schema check fails
since the Parquet thinks everything is nullable, but the declared schema
thinks some fields aren't.
One solution would be to just never use nullable=True in our schemas,
but that's a loss, since, at the application level, Spark does enforce the
constraint when we do spark.createDataFrame(...). So we get an
assurance that the non-nullable fields are populated at write-time, which
is valuable.
In the institutions tests, moved the three fixtures into a conftest.py
file, which just means that we don't have to explicitly import that df
fixture, which was causing flake8 warnings.
Instead of using a separate spark_uuid4() helper function defined in
institutions.utils, I moved this into the body of Institutions.build().
This was because, for some reason, the call to udf() spins up a
SparkContext, or something, which then conflicts with the pytest-managed
session when anything is imported from utils in the tests.
@wearpants https://github.com/wearpants Let me know if these changes
look good, and let's merge. Thanks!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/opensyllabus/osp-pipeline/pull/37#issuecomment-304704637,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAe2AOlvuHiA0Wb-XhDMLX5jMNNWDiJzks5r-wANgaJpZM4NoKS2
.

I put it in a conftest.py that's specific to the institutions tests, so it's only in scope under that module, not the whole suite. This is effectively the same as just importing the df variable from one test file to another, like before, so I think it's fine to leave it as df.

sorry, path was folded up... looks great :-)
On Mon, May 29, 2017 at 2:26 PM, David McClure<EMAIL_ADDRESS>wrote:

Merged #37 https://github.com/opensyllabus/osp-pipeline/pull/37.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/opensyllabus/osp-pipeline/pull/37#event-1101311002,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAe2AJjoGOe_1hfb6YqsX2LgaXIjQIvWks5r-w3mgaJpZM4NoKS2
.


change default privacy setting

Consistent with privacy stance, defaulting sharing to false.

@jessopb what's the status on this? are you still working on it? appears that the tests are failing.

I can't look into fixing the tests at this time.

sorry, i thought zenhub screwed up


Make the end-to-end encryption more explicit

Currently, a client application can deduce the transport key to protect the communication between client and server systems. It would be nice to give this feature a bit more official support, namely by:

extending the SOAP interface by "encrypt" / "decrypt" methods
adding support in API authentication object so that we don't have to call the SOAP interface all the time
extending the client libraries to make this a bit more transparent on developer's side.

I have to postpone this to 0.13.0, since we need to release 0.12.0 already...

[ ] extending the SOAP interface by "encrypt" / "decrypt" methods
[ ] adding support in integration libraries so that we don't have to call the SOAP interface all the time
[ ] extending the client libraries to make this a bit more transparent on developer's side.

We currently seem to have everything we need for 0.13.2: a non-personalized encryption support and a base for personalized encryption. Moving to 0.14.0.

Not relevant anymore. It will be replaced with ECIES scheme.


Integrate Puffin Egui more neatly

Currently i just have some things uncommented.

[ ] integrate https://crates.io/crates/profiling for nicer profiling decorators
[ ] Add a debug helper with the puffin window added into it as its currently a floating window within the egui window
[ ] add a build flag to enable it (ie: cargo run --profile)

waiting on this: https://github.com/EmbarkStudios/puffin/pull/234


Fall back to HTTP on right condition when HttpHostConnectException

Fixes #767.
I think it makes sense to me to fall back to HTTP only when certain conditions are met: https://github.com/GoogleContainerTools/jib/issues/767#issuecomment-409723110
Does it make sense?

Looks good - although I'm wondering if there will be many repeated warning messages for someone trying to use an HTTP registry.

That's a valid point. We could add a counter somewhere to print only a limited number of repeated warnings. But I don't think I'd like to add that feature now. I'd think it's a small price to pay for using insecure servers. However, I'll file an issue so that we can discuss.


Use Central Package Management

This Pull request Centralises all Nuget Versions in the Directory.Packages.props File:
see here:
https://devblogs.microsoft.com/nuget/introducing-central-package-management/

This pull request had the nice side effect that instead of several Versions of a nuget package only one is used (The one specified in the Directory.Packages.props). So this reduced the Downloaded nuget packages from 3.5GB to around 2GB.
I fixed also some Package Inconsistency that came to light with this Pullrequest.
When I had to upgrade Versions I tried to upgrade to the minimal next higher Versions so that it would compile.
For Eto (Sample) I had to make following workaround.
<ItemGroup>
    <!-- Explicitly reference Linux native dlls to get them included -->
    <PackageReference Include="SkiaSharp.NativeAssets.Linux" />
    <PackageReference Include="Eto.Forms" />
  </ItemGroup>

  <ItemGroup Condition="'$(BuildPlatform)'=='Wpf'">
    <PackageReference Include="Eto.Platform.Wpf" />
  </ItemGroup>

The References of Eto.Platform.Wpf and Eto.Forms are not needet, But with the Central Package Managment they need to specified or else it won't compile. Currently I only specified the Additional References for WPF for the other Build Platforms it has to be done like for Wpf with the Correct Eto.Platform.... Nuget package.
Maybe @rafntor Could help to specify the other platforms beside Wpf.

With this Checkin the Versions need only to be changed in two places. Directory.Packages.props and nuspec Files.

The build-platform is auto-detected based on some rules in 'Sdk.targets'.
I think it will be fine if you include these ;
"Eto.Platform.Wpf" - "Eto.Platform.Gtk" - "Eto.Platform.Mac64"
That should allow 'dotnet build' to execute and produce an executable on each platform if all works out.
Does it work to add also these to 'Directory.Packages.props' instead of Eto.Sample ?

I made a PR .. please have a look ;-)


Failed to parse source map error when used with create-react-app 5.x

When the current 3.7.0 package is installed with create-react-app I got some warnings like that:
WARNING in ./node_modules/graphql-request/dist/index.js
Module Warning (from ./node_modules/source-map-loader/dist/cjs.js):
Failed to parse source map from 'node_modules\graphql-request\src\index.ts' file: Error: ENOENT: no such file or directory, open 'node_modules\graphql-request\src\index.ts'
 @ ./src/lib/backend.ts 9:0-48 23:17-30
 @ ./src/index.tsx 16:0-42 32:14-25

The warning is correct cause the included source map point to a source file witch is not included in the package.
I think it could be solved by removing all source maps from the release package or include the src files at the correct location.

any progress on this?

Also having this issue, any updates?

Tritvial fix at #317

Yup, I'm facing the same problem. I hope someone can review @willstott101 PR.


Arabic locale

Coverage increased (+0.06%) to 90.75% when pulling ab7db59fa8b2462853d1a93a24207b898262b3da on Mahmoud-Mardeni:arabic-locale into c649f9f54ad1a8fb5a523cbb29db848a2f58ee85 on epoberezkin:master.

@Mahmoud-Mardeni thank you. Please update readme as well.

Coverage increased (+0.06%) to 90.75% when pulling 4f8ca708d92ec42e379056868b9be3879de66636 on Mahmoud-Mardeni:arabic-locale into c649f9f54ad1a8fb5a523cbb29db848a2f58ee85 on epoberezkin:master.

Coverage increased (+0.06%) to 90.75% when pulling cf7b2fd7abe9811dcbe6e7e9f51888b834986f7e on Mahmoud-Mardeni:arabic-locale into c649f9f54ad1a8fb5a523cbb29db848a2f58ee85 on epoberezkin:master.

thank you, it's in 2.2

Appreciate it. Thanks indeed.

Hi - sorry - almost accidentally checked the translations, and they are not alway consistent with the English messages... Could you maybe review?

It's up to you of course - you may no longer need them...


Toast after Share isn't clickable

I clicked Share, and then I clicked "OK" in the popup. I saw the Toast telling me a gist was created. Yay!
I tried clicking on the text in the Gist, to go to it.
Expected: To open a new tab to view the gist.
Actual: The text in the toast is not clickable.

Maybe @kasperpeulen  might want to take a look at this one?

fixed by https://github.com/dart-lang/dart-pad/pull/306


Fix Companion docs

Fix: https://docs.ipfs.tech/how-to/companion-node-types/#external

Clarify External means kubo.
Remove Embedded till ready to be replaced via helia.

Remove Embedded till ready to be replaced via helia

This is tagged under "Fix companion docs" but this is bigger than docs right?  We're also talking about removing code here.  Your call, but this seems like its own issue providing some justification (linking to js-ipfs deprecation issue) with PR of code removal doc changes linked to it.
I think we should do this before we ship MV3.

Clarify External means kubo.

Instead of "Set to "External" to connect to a local node using the HTTP API." how about 'Set to "External" to connect to a local Kubo node using the Kubo RPC API."
Anytime we see "HTTP API" we should be fixing to disambiguate between the HTTP Gateway API and the Kubo RPC API.

Other things regarding "API" in the settings screen
API → Kubo RPC API

@whizzzkid: I want to make sure you saw my comments that were added after merge: https://github.com/ipfs/ipfs-companion/pull/1230#pullrequestreview-1523136268


libsrt: init at 1.4.1

Motivation for this change
I'd like to compile ffmpeg with Secure Reliable Transport (SRT) support (https://github.com/Haivision/srt, https://www.srtalliance.org/).
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[x] Ensured that relevant documentation is up to date
[ ] Fits CONTRIBUTING.md.

I already packaged srt January 2019: #54380
It's here: https://github.com/NixOS/nixpkgs/blob/a3013da6a272780adb46aadf4bf192136301c99c/pkgs/development/libraries/srt/default.nix

facepalm good catch


fix type

Codecov Report

Merging #1482 (3316993) into master (423d566) will decrease coverage by 0.17%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master    #1482      +/-   ##
==========================================
- Coverage   39.52%   39.35%   -0.18%
==========================================
  Files         598      590       -8
  Lines       35068    34956     -112
==========================================
- Hits        13860    13756     -104
+ Misses      19681    19666      -15
- Partials     1527     1534       +7

Impacted Files
Coverage Δ

infra/conf/jsonpb/jsonpb.go
11.11% <0.00%> (ø)

infra/conf/merge/merge.go
50.00% <ø> (ø)

infra/conf/mergers/merge.go
0.00% <0.00%> (ø)

infra/conf/mergers/merger_base.go
9.67% <0.00%> (ø)

infra/conf/synthetic/router/router_strategy.go
41.66% <ø> (ø)

infra/conf/v2jsonpb/v2jsonpb.go
11.11% <0.00%> (ø)

proxy/http/server.go
0.52% <ø> (ø)

proxy/shadowsocks/client.go
1.00% <ø> (ø)

proxy/trojan/client.go
1.36% <ø> (ø)

proxy/vless/inbound/inbound.go
0.40% <ø> (ø)

... and 23 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 423d566...3316993. Read the comment docs.

Thanks for your work


fix: use linear interpolation to implement range LINEAR fill strategy

I hereby agree to the terms of the GreptimeDB CLA
What's changed and what's your intention?
Use linear interpolation to implement range LINEAR fill strategy
The previous LINEAR strategy of range fill was implemented using the average value. Only the data before and after an null data point are non-empty, and the value of this point will be filled with the average of the two numbers. Now the implementation is changed to linear interpolation. As long as there are more than two non-empty data points in the entire time series, all null data points can be filled in using linear interpolation.
Checklist

[x]  I have written the necessary rustdoc comments.
[x]  I have added the necessary unit tests and integration tests.

Refer to a related PR or issue link (optional)

Good job! Question: is this algorithm the same with other TSDB? Like the prometheus for example.

The idea mainly comes from questdb/influxdb, they all use linear interpolation as fill strategy, our original implementation is too simple.


fix options test

Codecov Report

Merging #140 into master will not change coverage.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master     #140   +/-   ##
=======================================
  Coverage   98.71%   98.71%
=======================================
  Files           1        1
  Lines          78       78
  Branches       27       27
=======================================
  Hits           77       77
  Misses          1        1

Impacted Files
Coverage Δ

src/clean-webpack-plugin.ts
98.71% <100%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 82c8718...901affd. Read the comment docs.


More tests for observeOn and subscribeOn

Change looks good to me.

Merged with a873580. thanks @staltz !


"マイクロソフト チーム" needs to be replaced with "Microsoft Teams".

https://docs.microsoft.com/ja-jp/microsoftteams/teams-adoption-your-first-teams

ドキュメントの詳細
⚠ このセクションを編集しないでください。 docs.microsoft.com で必須です ➟ GitHub の問題のリンク。

ID: 885bbb1b-81d6-b45e-80b3-335b1213bb23
Version Independent ID: 00b8e219-cd96-e8ce-bf06-96a03ab82ffc
Content: Microsoft Teams で最初のチームを作成する
Content Source: Teams/teams-adoption-your-first-teams.md
Service: msteams
GitHub Login: @karuanag
Microsoft Alias: karuanag

@samanthaw this looks like one for your team

@hyoshioka0128 Thank you for reporting this issue, at this time we will not fix the over-translation of Microsoft Teams. It is a known issue that some of our product names are being unnecessarily translated by the machine translation. We are investigating a solution to fix these issues.

@samanthaw Thanks.


i get the following issue since today

[pluralsight:course] visual-studio-azure-migrating-applications-services: Downloading JSON metadata
[download] Downloading playlist: Migrating Applications and Services to Azure with Visual Studio 2019
[pluralsight:course] playlist Migrating Applications and Services to Azure with Visual Studio 2019: Collected 29 video ids (downloading 29 of them)
[download] Downloading video 1 of 29
[pluralsight] Downloading login page
[pluralsight] Logging in
[pluralsight] d3d1ea77-6e6c-49cf-b9a5-5cffb9d6a7dd-0: Downloading JSON metadata
[pluralsight] d3d1ea77-6e6c-49cf-b9a5-5cffb9d6a7dd-0: Downloading mp4-high-widescreen viewclip graphql
[pluralsight] d3d1ea77-6e6c-49cf-b9a5-5cffb9d6a7dd-0: Waiting for 2 seconds to avoid throttling
[pluralsight] d3d1ea77-6e6c-49cf-b9a5-5cffb9d6a7dd-0: Downloading captions JSON
[pluralsight] d3d1ea77-6e6c-49cf-b9a5-5cffb9d6a7dd-0: Downloading captions JSON
WARNING: Unable to download captions JSON: HTTP Error 404: Not Found
[download] C:\Users\Thanzeel\Videos\Pluralsight\Migrating Applications and Services to Azure with Visual Studio 2019\01 - Course Overview#\01 - Course Overview.mp4 has already been downloaded
[download] 100% of 2.57MiB
[download] Downloading video 2 of 29
[pluralsight] cbb0f9e2-da79-4db2-8b88-0f682f65914a-0: Downloading JSON metadata
[pluralsight] cbb0f9e2-da79-4db2-8b88-0f682f65914a-0: Downloading mp4-high-widescreen viewclip graphql
[pluralsight] cbb0f9e2-da79-4db2-8b88-0f682f65914a-0: Waiting for 2 seconds to avoid throttling
ERROR: No video formats found; please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; type  youtube-dl -U  to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.

why u close without response


setup: add drizzel studio in scripts

Command: bun run db:studio
https://local.drizzle.studio/?port=4000

Typically react frontend runs on 3000, better use some non conflicting port number for the studio.

@shivamvijaywargi port updated to 4000.


Incorrect description

in both sections for enabling and disabling network security for private endpoints, number 6 is incorrect. For "enabling" it says
"In the properties for the default subnet, select the checkboxes for Network Security Groups, Route tables, or both in NETWORK POLICY FOR PRIVATE ENDPOINTS."
However, in the Portal, it is just "Security" and NOT "NETWORK POLICY FOR PRIVATE ENDPOINTS".
Could you please check and update.
Thank you.
Tobias

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 27e73372-f414-57f3-73c1-109f83a8db10
Version Independent ID: 6f8c2c28-34ef-18dd-1c02-c528db3a5db2
Content: Manage network policies for private endpoints - Azure Private Link
Content Source: articles/private-link/disable-private-endpoint-network-policy.md
Service: private-link
GitHub Login: @asudbring
Microsoft Alias: allensu

@tmassoth
Thanks for your feedback! We will investigate and update as appropriate.

@tmassoth
Could you please check below screenshot which refer to enable or disable network policy for private endpoints as per your requirement.

if there are any further questions regarding the documentation, please tag me in your reply and we will be happy to continue the conversation.

@tmassoth
We are going to close this thread as resolved but if there are any further questions regarding the documentation, please tag me in your reply and we will be happy to continue the conversation.


Removing color stops

Hi,
1st of all, thanks for making this lib :)
Not a bug, just a thing I noticed: I was playing around with the demo and noticed it's quite tedious to remove color stops (using the trash button). Would be great to just being able to use Backspace or even drag n drop the color stop out of the track so you don't require a button in your UI to remove them. Example: https://cssgradient.io/
I think using the delete/backspace key can be achieved using the hook somehow, but the drag n drop method seems more complicated I assume?
Anyway, just leaving this here and would love to see it.
Thanks and keep it up :)

Interesting idea, I like it! I think we could roadmap some additional features in the same realm like switching between points with the tab button and so forth. Will spin a branch with keyboard listeners if your willing to do a little testing.

Thanks! Absolutely :)

Added the described the functionality in version 2.1.6, also added the tab button to quickly switch between selected points.
Take a peak and let me know what you think!

Added the described the functionality in version 2.1.6, also added the tab button to quickly switch between selected points.
Take a peak and let me know what you think!

Hey, thanks for the quick implementation :) I can confirm that backspace removes the color stop and tabbing through the color stops works as well (cool!), but no matter how much I drag the color stop out of the track, it's not removed. I think that would be the most intuitive thing to do though in order to remove it.


V4 automated sensitivity analysis

Pull Request Key Information
Reason for change
Automated sensitivity analysis is a powerful tool for understanding the impact of uncertain parameters on model outputs.
What was changed
Developed a new LDAR-Sim sensitivity analysis module to allow users to run sensitivity with low effort.
Intended Purpose
Will allow users to specify parameters to vary and their values/ variations.
Level of version change required
N/A
Testing Completed
Various new unit tests added to test new functionality. All unit tests passing:
unit_test_results.txt
Manual Testing Completed with Simple Sensitivity Scenarios for Each Sensitivity Level (Methods, Programs, Virtual World). Parameters and sensitivity results attached:
Sensitivity Analysis Testing.zip
Target Issue
N/A
Additional Information
N/A

Updated testing results for SHA1: 10ad1f2
Unit testing:
unit_test_results.txt
Manual testing:
Sensitivity Analysis Testing2.zip


chore(deps): update dependency @cyclonedx/cdxgen to v9.8.7

This PR contains the following updates:

Package
Update
Change

@cyclonedx/cdxgen (source)
patch
9.8.5 -> 9.8.7

Release Notes

CycloneDX/cdxgen (@cyclonedx/cdxgen)
v9.8.7
Compare Source
What's Changed

feat: safely log git url by @setchy in https://github.com/CycloneDX/cdxgen/pull/612
Add support for paket.lock files by @robaliias in https://github.com/CycloneDX/cdxgen/pull/611
Fixes issues with trimComponents by @BaseCrusher in https://github.com/CycloneDX/cdxgen/pull/613
Fixes #614 #609

New Contributors

@robaliias made their first contribution in https://github.com/CycloneDX/cdxgen/pull/611
@BaseCrusher made their first contribution in https://github.com/CycloneDX/cdxgen/pull/613

Full Changelog: https://github.com/CycloneDX/cdxgen/compare/v9.8.6...v9.8.7
v9.8.6
Compare Source
What's Changed

Feature/javans improvements by @prabhu in https://github.com/CycloneDX/cdxgen/pull/604
feat(server) add simple health endpoint by @setchy in https://github.com/CycloneDX/cdxgen/pull/605
Update references of SBoM to SBOM by @setchy in https://github.com/CycloneDX/cdxgen/pull/610
build: add eslint prettier plugin by @setchy in https://github.com/CycloneDX/cdxgen/pull/607

Full Changelog: https://github.com/CycloneDX/cdxgen/compare/v9.8.5...v9.8.6

Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.

[ ] If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

superseded by

https://github.com/MediaMarktSaturn/technolinator/pull/201


Fix flaky container e2e test

What does this PR do?
Fix flaky TestAdmissionControllerWithoutAPMInjection test
Motivation
Tests shouldn't be flaky
Describe how to test/QA your changes
Possible Drawbacks / Trade-offs
Additional Notes
Case study: failed test
=== RUN   TestKindSuite/TestAdmissionControllerWithoutAPMInjection
    base_test.go:55: START  kindSuite/TestAdmissionControllerWithoutAPMInjection 2024-09-23 13:53:08.999358781 +0000 UTC m=+359.919080680
    k8s_test.go:961:
        	Error Trace:	/go/src/github.com/DataDog/datadog-agent/test/new-e2e/tests/containers/k8s_test.go:961
        	            				/go/src/github.com/DataDog/datadog-agent/test/new-e2e/tests/containers/k8s_test.go:895
        	Error:      	map[string]string{} does not contain "DD_DOGSTATSD_URL"
        	Test:       	TestKindSuite/TestAdmissionControllerWithoutAPMInjection
    k8s_test.go:964:
        	Error Trace:	/go/src/github.com/DataDog/datadog-agent/test/new-e2e/tests/containers/k8s_test.go:964
        	            				/go/src/github.com/DataDog/datadog-agent/test/new-e2e/tests/containers/k8s_test.go:895
        	Error:      	map[string]string{} does not contain "DD_TRACE_AGENT_URL"
        	Test:       	TestKindSuite/TestAdmissionControllerWithoutAPMInjection
    k8s_test.go:967:
        	Error Trace:	/go/src/github.com/DataDog/datadog-agent/test/new-e2e/tests/containers/k8s_test.go:967
        	            				/go/src/github.com/DataDog/datadog-agent/test/new-e2e/tests/containers/k8s_test.go:895
        	Error:      	map[string]string{} does not contain "DD_ENTITY_ID"
        	Test:       	TestKindSuite/TestAdmissionControllerWithoutAPMInjection
    k8s_test.go:968:
        	Error Trace:	/go/src/github.com/DataDog/datadog-agent/test/new-e2e/tests/containers/k8s_test.go:968
        	            				/go/src/github.com/DataDog/datadog-agent/test/new-e2e/tests/containers/k8s_test.go:895
        	Error:      	map[string]string{} does not contain "DD_ENV"
        	Test:       	TestKindSuite/TestAdmissionControllerWithoutAPMInjection
    k8s_test.go:971:
        	Error Trace:	/go/src/github.com/DataDog/datadog-agent/test/new-e2e/tests/containers/k8s_test.go:971
        	            				/go/src/github.com/DataDog/datadog-agent/test/new-e2e/tests/containers/k8s_test.go:895
        	Error:      	map[string]string{} does not contain "DD_SERVICE"
        	Test:       	TestKindSuite/TestAdmissionControllerWithoutAPMInjection
    k8s_test.go:974:
        	Error Trace:	/go/src/github.com/DataDog/datadog-agent/test/new-e2e/tests/containers/k8s_test.go:974
        	            				/go/src/github.com/DataDog/datadog-agent/test/new-e2e/tests/containers/k8s_test.go:895
        	Error:      	map[string]string{} does not contain "DD_VERSION"
        	Test:       	TestKindSuite/TestAdmissionControllerWithoutAPMInjection
    k8s_test.go:990:
        	Error Trace:	/go/src/github.com/DataDog/datadog-agent/test/new-e2e/tests/containers/k8s_test.go:990
        	            				/go/src/github.com/DataDog/datadog-agent/test/new-e2e/tests/containers/k8s_test.go:895
        	Error:      	map[string]*v1.HostPathVolumeSource{} does not contain "datadog"
        	Test:       	TestKindSuite/TestAdmissionControllerWithoutAPMInjection
    k8s_test.go:1000:
        	Error Trace:	/go/src/github.com/DataDog/datadog-agent/test/new-e2e/tests/containers/k8s_test.go:1000
        	            				/go/src/github.com/DataDog/datadog-agent/test/new-e2e/tests/containers/k8s_test.go:895
        	Error:      	map[string][]string{"kube-api-access-k727h":[]string{"/var/run/secrets/kubernetes.io/serviceaccount"}} does not contain "datadog"
        	Test:       	TestKindSuite/TestAdmissionControllerWithoutAPMInjection
    base_test.go:59: FINISH kindSuite/TestAdmissionControllerWithoutAPMInjection 2024-09-23 13:53:19.0230929 +0000 UTC m=+369.9428[148](https://gitlab.ddbuild.io/DataDog/datadog-agent/-/jobs/648058421#L148)02

Test started at 13:53:08, finished at 13:53:19, so ran for 11 seconds
According to the k8s event stream:
Already running pod was killed at 13:53:09
New pod was created at 13:53:36 (17 seconds after the test finished)
So, based on the timeframe, it can be concluded that the old pod did not finish deleting immediately, and since there is no wait in the test, the old pod was what was used for the rest of the calculations for the test.
This PR should force us to retain the old pod name, and ensure that the new pod name does not match the old one

/merge


sync chart.

Sync the chart from installer to cover some manifests diff found in run_mandiff.

@morvencao: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

operator-lint-dind
72eec914e10ddaee2e937264da08bee1d6a46464
link
/test operator-lint-dind

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest


Hovering while file has error causes warning

If you open a file and cause an error in it and immediately hover over a variable it will spit out something like:
  Message: Request textDocument/hover failed with message: Cannot read property 'tokens' of undefined
  Code: -32603 ```

Fixed by #213


Svg with filter does not render properly

I have this svg
<svg width="40" height="40" viewBox="0 0 40 40" xmlns="http://www.w3.org/2000/svg" xmlns:xlink="http://www.w3.org/1999/xlink">
<title>93EB1BA0-2B14-4C04-802D-A0760609AEE7</title>
<defs>
<path d="M0 20C0 8.954 8.952 0 20 0c11.046 0 20 8.952 20 20 0 11.046-8.952 20-20 20C8.954 40 0 31.048 0 20zm28 1a1 1 0 0 0 0-2h-7v-7a1 1 0 0 0-2 0v7h-7a1 1 0 0 0 0 2h7v7a1 1 0 0 0 2 0v-7h7z" id="a"/>
<filter x="-50%" y="-50%" width="200%" height="200%" filterUnits="objectBoundingBox" id="b">
<feMorphology radius=".5" in="SourceAlpha" result="shadowSpreadInner1"/><feOffset in="shadowSpreadInner1" result="shadowOffsetInner1"/>
<feComposite in="shadowOffsetInner1" in2="SourceAlpha" operator="arithmetic" k2="-1" k3="1" result="shadowInnerInner1"/>
<feColorMatrix values="0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0.02 0" in="shadowInnerInner1"/>
</filter>
</defs>
<g fill="none" fill-rule="evenodd">
<use fill="#333" xlink:href="#a"/>
<use fill="#000" filter="url(#b)" xlink:href="#a"/>
</g>
</svg>

Which renders fine if embedded manually:

But when I load it through this loader (default webpack-2 settings) it ends up as:

It seems that the filter part is not being rendered properly
This is the html I get when inspecting it in chrome after render
<svg width="40" height="40" viewBox="0 0 40 40" xmlns="http://www.w3.org/2000/svg" xmlns:xlink="http://www.w3.org/1999/xlink">
<title>93EB1BA0-2B14-4C04-802D-A0760609AEE7</title>
<defs>
<path d="M0 20C0 8.954 8.952 0 20 0c11.046 0 20 8.952 20 20 0 11.046-8.952 20-20 20C8.954 40 0 31.048 0 20zm28 1a1 1 0 0 0 0-2h-7v-7a1 1 0 0 0-2 0v7h-7a1 1 0 0 0 0 2h7v7a1 1 0 0 0 2 0v-7h7z" id="a">
</path>
<filter x="-50%" y="-50%" width="200%" height="200%" filterUnits="objectBoundingBox" id="b">
<feMorphology radius=".5" in="SourceAlpha" result="shadowSpreadInner1">
</feMorphology>
<feOffset in="shadowSpreadInner1" result="shadowOffsetInner1">
</feOffset>
<feComposite in="shadowOffsetInner1" in2="SourceAlpha" operator="arithmetic" k2="-1" k3="1" result="shadowInnerInner1">
</feComposite>
<feColorMatrix values="0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0.02 0" in="shadowInnerInner1">
</feColorMatrix>
</filter>
</defs>
<g fill="none" fill-rule="evenodd">
<use fill="#333" xmlns:xlink="http://www.w3.org/1999/xlink" xlink:href="#a">
</use>
<use fill="#000" filter="url(#b)" xmlns:xlink="http://www.w3.org/1999/xlink" xlink:href="#a">
</use>
</g>
</svg>

and this is react devtools of the component

IMO You should load svg's with file-loader
Also you could try removing the filter element, as I doubt it is actually visible

I got a similar problem. Maybe try to change some configurations of svgo https://github.com/svg/svgo
with that, my problem was resolved :
svgo: {
   pretty: true,
   plugins: [
      {removeTitle: false},
      {removeStyleElement: true},
      {cleanupIDs: false}
   ],
   floatPrecision: 2
}

Looks like similar problem to #165 . and there the problem seems to be fixed by disabling this svgo plugin - { cleanupIDs: false }.


vmconversion doesn't like std/pegs

I have a type that has a Peg object in it. When trying to pass it between the vm and code it errors. It's a bit of an odd error:
/Users/jaremycreechley/projs/nims/cimporter/src/cimporter.nim(200, 38) template/generic instantiation of `implNimscriptModule` from here
/Users/jaremycreechley/.asdf/installs/nim/1.6.10/nimble/pkgs/nimscripter-1.0.17/nimscripter/expose.nim(94, 26) template/generic instantiation of `fromVm` from here
/Users/jaremycreechley/.asdf/installs/nim/1.6.10/nimble/pkgs/nimscripter-1.0.17/nimscripter/vmconversion.nim(292, 15) template/generic instantiation of `fromVmImpl` from here
/Users/jaremycreechley/.asdf/installs/nim/1.6.10/nimble/pkgs/nimscripter-1.0.17/nimscripter/vmconversion.nim(175, 28) template/generic instantiation of `fromVm` from here
/Users/jaremycreechley/.asdf/installs/nim/1.6.10/nimble/pkgs/nimscripter-1.0.17/nimscripter/vmconversion.nim(97, 25) template/generic instantiation of `fromVm` from here
/Users/jaremycreechley/.asdf/installs/nim/1.6.10/nimble/pkgs/nimscripter-1.0.17/nimscripter/vmconversion.nim(292, 15) template/generic instantiation of `fromVmImpl` from here
/Users/jaremycreechley/.asdf/installs/nim/1.6.10/nimble/pkgs/nimscripter-1.0.17/nimscripter/vmconversion.nim(175, 28) template/generic instantiation of `fromVm` from here
/Users/jaremycreechley/.asdf/installs/nim/1.6.10/nimble/pkgs/nimscripter-1.0.17/nimscripter/vmconversion.nim(292, 15) template/generic instantiation of `fromVmImpl` from here
/Users/jaremycreechley/.asdf/installs/nim/1.6.10/lib/pure/pegs.nim(81, 31) Error: expression 'typeof(obj)(kind: kind)' is of type 'Peg' and has to be used (or discarded)

Can you compile with --expandMacro:fromVmImpl and post the generated conversion procedure?

I'll try and do this today. I want to update ants, so it'd be a good time.


error type in localscript when refrencing a local player in a nested if statement

local plr = game.Players.Local.Player
while wait() do
if plr == plr then
plr = nil
end end

plr is defined as error type after if statement

If you use correct semantics instead of game.Players, you'll notice there's no error in this code, albeit, plr should be nil after the if statement


Incorrect SMILES string for (3S)-citryl-CoA and (3S)-citryl-CoA(6-) entries

The SMILES strings for the following two entries seem to incorrectly specify the 3R instead of the 3S stereochemistry:
https://www.ebi.ac.uk/chebi/searchId.do?chebiId=CHEBI:15459
https://www.ebi.ac.uk/chebi/searchId.do?chebiId=CHEBI:57321
Can you please check and fix the SMILES strings for these entries? Thank you!

Thanks for letting us know. The structures have now been updated.


store/proxy: set {Min,Max}Time accordingly to the nodes

It doesn't make sense to advertise that a Thanos Query node has data
since the beginning of the time and till the end of time if it only has
nodes which have specific time ranges of data.
Change it accordingly by checking each time range of each node and
setting it to the min/max values.
Mainly created as a draft at the beginning to gather some opinions and to run the E2E tests (:
TODO:

Add tests for this PR

Yes yes, I will do that once I will have some more spare time :P


TileMap.set_cell not work on WorkerThreadPool add_group_task

Tested versions
v4.2.1.stable.official.b09f793f5
System information
Godot v4.2.1.stable - Windows 10.0.19045 - Vulkan (Mobile) - integrated AMD Radeon(TM) Graphics (Advanced Micro Devices, Inc.; 31.0.21023.2010) - AMD Ryzen 7 5800U with Radeon Graphics (16 Threads)
Issue description

# Generator.gd
extends Object

class_name Generator

const PER_CHUNK_SIZE = Vector2i(16, 16)
const MAP_CHUNK_COUNT = Vector2i(8, 8)

var tile_map: TileMap
var arr = []

func _init(_tile_map: TileMap):
	self.tile_map = _tile_map
	self.arr.clear()
	for x in range(0, MAP_CHUNK_COUNT.x):
		for y in range(0, MAP_CHUNK_COUNT.y):
			arr.push_back(Vector2i(x * PER_CHUNK_SIZE.x, y * PER_CHUNK_SIZE.y))
	var group_id = WorkerThreadPool.add_group_task(self.thread_generate, arr.size())
	WorkerThreadPool.wait_for_group_task_completion(group_id)

func thread_generate(idx):
	var position = arr[idx]
	for x in range(0, PER_CHUNK_SIZE.x):
		for y in range(0, PER_CHUNK_SIZE.y):
			self.tile_map.set_cell(0, Vector2i(position.x + x, position.y + y), 0, Vector2i(0, 0))

# World.gd
extends Control

@onready var tile_map = $TileMap

# Called when the node enters the scene tree for the first time.
func _ready():
	Generator.new(tile_map)
	pass

# Called every frame. 'delta' is the elapsed time since the previous frame.
func _process(delta):
	pass

Steps to reproduce
# World.gd
extends Control

@onready var tile_map = $TileMap

# Called when the node enters the scene tree for the first time.
func _ready():
	Generator.new(tile_map)
	pass

# Called every frame. 'delta' is the elapsed time since the previous frame.
func _process(delta):
	pass

Minimal reproduction project (MRP)
maptile_demo_2.zip

Tile maps are not thread safe, but please explain how it doesn't work, are you getting an error? Are is breaking?

not thread safe
Windows MessageBox
the Instruction at 0x00007ff referenced memory at 0x1f6515, The memory could not be written


Can not open file with chinese file name

Hi,
Thanks for the issue. Found that the program does not support non ASCII character on argv.
A work around before a fix is to open the file directly from the program or drag and drop the file to the program window.


chore(deps): upgrade dev dependencies

Upgrades project dependencies. See details in workflow run.

Automatically created by projen via the "upgrade-dev-dependencies-2.x" workflow

⚪ Backport skipped
The pull request was not backported as there were no branches to backport to. If this is a mistake, please apply the desired version labels or run the backport tool manually.
Manual backport
To create the backport manually run:
backport --pr 2107

Questions ?
Please refer to the Backport tool documentation


Initial draft of orpml XML Schema [WIP]

This is a rough first pass - it has been awhile.
TODO:
OR element selector for content section
Namespaces

WIP!

@stevenalanwilson - raised this as a WIP - I'll add to it over the next day or so and give you a shout when ready.

@rishson ok thanks mate, ping me when you want a review.


storm product analytics example

Merged w/https://github.com/spring-projects/spring-xd-samples/commit/446ed57c947d64ff568a7413ca303e9a34c9a754


MQ2 sensor component for ESP-IDF (IDFGH-4955)

Hello everybody. Is there any MQ2 library available for ESP-IDF?.
Currently there are these amazing libraries that work great on Arduino-ESP32 https://github.com/miguel5612/MQSensorsLib.
Is there any possible way to import those Arduino libraries and use them as native components on ESP-IDF, MQ2 specifically?.
Thanks in advance

@Yoimer Thanks for your advice. But I think ESP-IDF tends to support more basic and core components, while ESP-IoT-Solution is more suitable to support such external sensor drivers. MQ series will be considered to add to https://github.com/espressif/esp-iot-solution/tree/master/components/sensors

Thanks for reporting, sorry for the very slow turnaround, let us track in https://github.com/espressif/esp-iot-solution/issues, feel free to reopen.


Update package.json

Removed beautify script for smaller package.json
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context.
Fixes # (issue)
Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[ ] I have signed the Adobe Open Source CLA.
[ ] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[ ] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes.
[ ] All new and existing tests passed.

Created for a test. No need to merge.


[WIP] Add c++ exception scenario

Adds a scenario which triggers a C++ exception. This cannot currently be caught by most in-process crash reporters, so the expected behaviour is for 0 requests to be received.

I've updated the scenario to check that a report is generated with an empty stacktrace.


use safe-buffer module to make Buffer.from() available in old versions of Node.js

(Happy to modify it so it only touches the tests if you'd prefer to not add a module to the actual library code, since there's already code in there to avoid Buffer constructor if Buffer.from() exists.)

Tracking: https://github.com/nodejs/node/issues/19079

@Trott I specifically landed this to https://github.com/mafintosh/duplexify/pull/17 without extra deps.
A one-liner shouldn't require an extra dependency. Perhaps move that to dev deps only, if it's required for tests?

@ChALkeR Sure, done.

I think since #17 landed, this is obsolete but if I'm mistaken, by all means, re-open.


inference error

I have trained on my own datasets, language is Chinese, and I use my own cleaners and symbols.
However, when I use my trained model to infer tts( inference.py ), loading model has some errors like this:
File "/home/liuyiheng/HierSpeechpp/inference.py", line 157, in model_load
text2w2v.load_state_dict(torch.load(a.ckpt_text2w2v))
File "/home/liuyiheng/HierSpeechpp/env/lib/python3.10/site-packages/torch/nn/modules/module.py", line 2041, in load_state_dict
raise RuntimeError('Error(s) in loading state_dict for {}:\n\t{}'.format(
RuntimeError: Error(s) in loading state_dict for SynthesizerTrn:
Missing key(s) in state_dict: "enc_q.pre.weight", "enc_q.pre.bias", "enc_q.enc.in_layers.0.bias", "enc_q.enc.in_layers.0.weight_g",....
Unexpected key(s) in state_dict: "model", "iteration", "optimizer", "learning_rate".
Can you explain why this error occured?
I only replace "ckpt_text2w2v" checkpoints to my trained checkpoints ,other checkpoints use yours' checkpoints .

Is there anything else I should be aware of when infering tts?
Thank you very much for taking time out of your busy schedule to answer questions!

Hi
Change your checkpoint loader as below
    _ = utils.load_checkpoint(a.ckpt_text2w2v, text2w2v, None)

Thanks


[README] "just run pnpm dev and scan the QR-code" - fails because package.json dev specifies iOS

Love this template!!
One small issue with the getting started guide - README notes:

Note: If you want to use a physical phone with Expo Go, just run pnpm dev and scan the QR-code.

apps/expo/package.json contains:
"scripts": {
    "start": "expo start",
    "dev": "expo start --ios",
    "clean": "rm -rf .expo .turbo node_modules",
    "android": "expo start --android",
    "ios": "expo start --ios",
    "web": "expo start --web",
    "lint": "eslint . --ext ts,tsx"
  },

Running pnpm dev tries to launch iOS, which on non-iOS platforms prompts for Xcode install
Possible solutions:

Change readme
Change apps/expo/package.json to not default to --ios

Thoughts on approach if I were to make the edit?

Delete the note. It doesn't work without it due to turbo's terminal not being interactive


Rename app.so -> app.dylib

This relies on https://github.com/flutter/engine/pull/2738

@abarth @chinmaygarde

Thank you. lgtm.


🐛🏁 Fix collision with a windows defined macro

Windows defines a macro called ERROR in wingdi.h:
#define ERROR               0

This lead to numerous errors when trying to include toml.h. Instead of
relying on preprocessor conditions I chose to simply rename the token
type to ERROR_TOKEN.

Oh, thank you!
LGTM


Datadog Formatter Issue

Hello,
Sorry to ask here but I didn't find a better place to ask this question.
I have an Elixir app running in a GKE cluster that is sending logs and OTEL data to Datadog. We are using the LoggerJSON.Formatters.DatadogLogger in the Elixir config file to get the Span and Trace ID in the format Datadog "understand", but we are facing an issue where the IDs are not being converted.
For example, I can see these values in the GKE logs console in GCP:
jsonPayload: {
message: "[1.4.9|oban_logger.ex:0028|handle_event/4] [Oban] stop heartbeat/Sync(_DHL:a1LHs00000SVhCAMA1) ran in 435ms"
dd.trace_id: "d44f4e1f64c0d340e33bb9493f1bc491"
syslog: {3}
domain: [1]
otel_trace_flags: [2]
logger: {4}
dd.span_id: "f84c24131a261413"
erl_level: "notice"
}
labels: {6}
logName: "projects/cargosense-production-general/logs/stdout"
receiveTimestamp: "2023-07-11T20:30:24.026440953Z"

As you can see, the IDs are being keept with the original values.
I have a small Elixir app where the formatter is working correctly and correlation in Datadog is working fine.
The configuration on both apps is exactly the same, but I know from the developers (I'm the DevOps guy) that they are using some decorators (I think that's the correct term) for log messages and I'm wondering if that is messing up with the Datadog formatter.
Is there any options we need to set to get the correct values for the Span and Trace IDs?
This is the configuration we are using in the app where the formatter is not working:
config :logger,
  # This backend is required for data dog
  backends: [LoggerJSON],
  level: :info

config :logger_json, :backend,
  metadata: :all,
  formatter: LoggerJSON.Formatters.DatadogLogger

Version of the logger we are using is 5.1.2
Elixir version is 1.14.3
I can send more details if needed.
Thanks a lot for the help and sorry I can give more details since I'm not an Elixir developer.

Hello. This should be fixed in the master branch. Sorry for such a log reply.


feat(datepicker): disable datepicker dates based on dateDisabled prop…

…erty (#799)

Implemented dateDisabled property on date picker in day, month and year mode.
Added Disable Tomorrow example to demo app

Current coverage is 85.62% (diff: 100%)

Merging #1130 into development will not change coverage

@@           development      #1130   diff @@
=============================================
  Files               35         35
  Lines             1280       1280
  Methods            228        228
  Messages             0          0
  Branches           213        213
=============================================
  Hits              1096       1096
  Misses             184        184
  Partials             0          0

Powered by Codecov. Last update fe6ad23...2df72df

@valorkin We need this feature. Can you please merge this pull request.

ok, had to rebase on top of dev

I have updated my branch if that helps.

Thank you @valorkin , @sdolier  for your follow up.

Looks good to me! Thanks!

There are a bunch of features in dev branch,
Will be tested and released next week.
If urgent I can publish it as @beta

I can wait for the release. But if you want me to test this feature then please publish it as @beta


Update Plugin Artifacts Links for v0.179.3

Automated changes by create-pull-request GitHub action

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Missing updates to dotty-compiler

scala.macros.Universe has moved to scala.macros.core.Universe in #24
DottyUniverse should have a Context available to gensym

Did https://github.com/scalacenter/dotty/pull/4 also add Context to DottyUniverse?

It's implemented in the following PR:
https://github.com/scalacenter/macros/pull/26

Fixed in #26 ?


hybridkem-x-wing: add experimental support for importKey.

Codecov Report
Attention: Patch coverage is 90.36145% with 8 lines in your changes missing coverage. Please review.

Project coverage is 88.16%. Comparing base (b27a400) to head (ec3d2cb).

Files with missing lines
Patch %
Lines

packages/hybridkem-x-wing/src/xWing.ts
90.36%
6 Missing and 2 partials :warning:

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #467      +/-   ##
==========================================
+ Coverage   87.87%   88.16%   +0.29%
==========================================
  Files          60       60
  Lines        4296     4369      +73
  Branches      448      470      +22
==========================================
+ Hits         3775     3852      +77
+ Misses        520      514       -6
- Partials        1        3       +2

Flag
Coverage Δ

unittests
88.16% <90.36%> (+0.29%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Sechub fails with 401 when using server config from property file

Sechub fails with 401 when using server config from property file
/usr/bin/sechub -reportformat html -configfile /mypathto/sechub.json scan
_____           _   _       _
/  ___|         | | | |     | |
\ `--.  ___  ___| |_| |_   _| |__
`--. \/ _ \/ __|  _  | | | | '_ \
/\__/ /  __/ (__| | | | |_| | |_) |
\____/ \___|\___\_| |_/\__,_|_.__/ Client Version 0.23.0-20210203082137

2021-04-12 12:07:04 (+02:00) Creating new sechub job
2021-04-12 12:07:05 (+02:00) ERROR: The HTTP request failed with error '401 '

using a similar file like:
{
  "apiVersion": "1.0",
  "server": "https://myserver.lala.net/",
  "user": "my_technical_user",
  "project": "myproject",
  "codeScan": {
    "fileSystem": {
      "folders": [
        "./"
      ]
    },
    "excludes": [
      "**/*.log",
      "**/node_modules/**",
      "**/test/**"
    ]
  }

calling sechub like that works:
/usr/bin/sechub -server "https://myserver.lala.net/" -reportformat html -configfile /mypathto/sechub.json scan

Hi @MichaBub,
I've done some investigations:
Server config from property file is working.
The error occurs when the server url has a trailing `/'.
-> So to fix your issue, just change
"server": "https://myserver.lala.net/"

into
"server": "https://myserver.lala.net"

Anyhow, I'll implement for the next client release that trailing slashes will work. :-)


Split samples

Codecov Report

Merging #3 into master will increase coverage by 2.03%.
The diff coverage is 74.36%.

@@            Coverage Diff            @@
##           master      #3      +/-   ##
=========================================
+ Coverage   41.37%   43.4%   +2.03%
=========================================
  Files           8       8
  Lines         817     917     +100
=========================================
+ Hits          338     398      +60
- Misses        461     494      +33
- Partials       18      25       +7

Impacted Files
Coverage Δ

storages/memory.go
78.94% <100%> (-1.3%)
:arrow_down:

storages/base.go
90.69% <100%> (-1.46%)
:arrow_down:

storages/clickhouse.go
69.31% <72.76%> (-2.01%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0c0c155...e03a8b0. Read the comment docs.

Codecov Report

Merging #3 into master will increase coverage by 2.41%.
The diff coverage is 76.69%.

@@            Coverage Diff             @@
##           master       #3      +/-   ##
==========================================
+ Coverage   41.37%   43.78%   +2.41%
==========================================
  Files           8        8
  Lines         817      909      +92
==========================================
+ Hits          338      398      +60
- Misses        461      486      +25
- Partials       18       25       +7

Impacted Files
Coverage Δ

storages/base.go
90.69% <100%> (-1.46%)
:arrow_down:

storages/memory.go
78.94% <100%> (-1.3%)
:arrow_down:

storages/clickhouse.go
70.81% <75.22%> (-0.51%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0c0c155...2377a58. Read the comment docs.


[WIP] Fix the docs generation script

Description:
With this PR my goal is to fix the docs generation script.
Apparently there were some big changes in packages used in this process, and this script was not updated so far.
[WIP] How to test it?
dotnet tool restore

# don't know yet if this is necessary
# but I run it before the other commands
dotnet run -- Docs

cd docs/
dotnet fornax build

I moved back to .NET 6 for the action: https://github.com/SaturnFramework/Saturn/blob/main/.github/workflows/docs.yml#L19
Any concerns with merging and iterating from there?

Ack, I'll keep working considering the .NET 6 SDK. I'm actually using the version 6.0.200 as well.

@baronfel @cartermp Do you know if we have some docs related to this documentation generation?
I'm having some trouble understanding that code. And apparently, there were a bunch of major updates (at least in the FSharp.Formatting library), so some types are broken and I'll need to fix them.

@64J0 unfortunately no, I don't know much about this particular docs tool. As for FSharp.Formatting, yes, it's undergone an incredible amount of breaking changes as well. I almost wonder if it's easier to just start entirely from scratch.

FsLabOrg uses a similar strategy to build the docs with Fornax. And it's working AFAIK. Later I'll try to replicate its configuration here, at least for the build docs job.

https://github.com/fslaborg/fslaborg.github.io

Since I'm not going to keep working in this PR for a while, I decided to close it. In the future, if it's still required, I can get back when having free time.


Release?

Hi David,
Could you publish a release so we could get a link to the vsix files?
The vsix can be published as a release asset.
Thanks!

Sorry, I'm out of time at the moment. I'll do it eventually.

Bump.


-[ISO8601DateFormatter dateComponentsFromString:timeZone:range:fractionOfSecond:] (ISO8601DateFormatter.m:619)

I've go this issue, with no extra details.
There's a way to fix it, or avoid it?
1	libobjc.A.dylib	objc_msgSend + 2
2	CoreFoundation	-[__NSDictionaryM objectForKey:] + 128
3	MyApp	-[ISO8601DateFormatter dateComponentsFromString:timeZone:range:fractionOfSecond:] (ISO8601DateFormatter.m:619)
4	MyApp	-[ISO8601DateFormatter dateFromString:timeZone:range:] (ISO8601DateFormatter.m:692)
5	MyApp	-[ISO8601DateFormatter dateFromString:timeZone:] (ISO8601DateFormatter.m:686)

I think the issues is because there is not thread protection when we read or write to timeZonesByOffset.

Ah, yes. I think this was fixed by #39—NSCache is thread-safe, whereas NSMutableDictionary is not.


A Question about vocals

Hello Mr author
I had some couple of Questions I hope they get answered.
So I want to train a 24khz to 48khz model for singing raw vocals that have no background music nor Reverberation at all,
just pure raw studio vocals but then I have some Questions.
1-These vocals are in different languages English has approximately 50 hours of vocals, Chinese 90 hours,
Korean 2.5 hours , Japanese 6.6 hours and Italian 1 hour. So the question is, would having different languages confuse and corrupt the algorithm and make the output bad and hallucinating or would it have a greater good impact or should I only train the English ones ?
2- I Should keep my almost 150 hours dataset alone and not mix it with MusDB dataset that has musical mixtures and full songs with instrumentals on, right?? just treat this 150 hours dataset like VCTK, right?
3- Some of these raw vocals aren't transcribed , is this okay ? Does aero train and accept non transcribed data.
4-I Don't really understand FFT , hop lengths and window sizes thingy. What will produce the best quality out of
these parameters for my case which I stated above? The (64/512) or the (256/1024) or (256/512) or (128/512)?
And Also how to know the configuration aka  FFT , hop lengths and window sizes of my dataset and how to convert my
dataset to the specific configuration that I want out of the 4 or the one that you will recommend.
I don't mind the training time I want the most optimal and the most highest quality for upscaling so if there is another configuration That isn't mentioned above tell me about it.
Again sorry if I'm asking basic questions, And thanks for your time.

Hey there,

You can try to train on a more general  dataset, it might even work better than VCTK. In general, I'm not assuming anything about the language, so there is a good chance it will work. It might require some tweaking. If you encounter problems, I suggest that you first train without a discriminator - only the Multi-Resolution STFT loss, to see that you are able to generate high frequencies. It will probably have audible artifacts, but nonetheless - if you succeed to generate high frequencies, it's a first step.

It might be more difficult to train music and speech at the same time, as they are very different. But I don't know, maybe it's worth a try. Let me know what you found out.

No need for transcription.

Empirically I found that 64/512 reaches the best quality, but it takes the most computational resources. So there is a trad off.

Just make sure your dataset is in the correct sample rate (e.g. Low Res = 4/8/16 kHz, High res = 16/24/48, or whatever you see fit) in accordance with the configuration files. Technically, you can use any FFT, hop length and window sizes you want, and it should not be a problem as the code should deal with it. But I can't guarantee that you won't need to do a bit of tweaking in the code for it to work.

In general, the most optimal configuration is the hop-length of 64. Though for the high-resolution sample rates: e.g. 12->48 kHz, this takes a lot of computational resources. So it really depends on what  GPUs you have within your reach.

Sorry for the late reply.
Let me know how it went and Good Luck!
M


Unable to compile Pumpkin / Ramp: rustc 1.26.0-nightly

The README specify pumpkin = "2.0.*" where https://crates.io/crates/pumpkin specify pumpkin = "1.0.*".
When using pumpkin = "1.0.*" (2.0.* is not available) with rustc 1.26.0-nightly (55c984ee5 2018-03-16) I am getting lot of compilation errors from ramp. For example:
error[E0658]: use of unstable library feature 'ptr_internals': use NonNull instead and consider PhantomData<T> (if you also use #[may_dangle]), Send, and/or Sync (see issue #0)
    --> /Users/Gary/.cargo/registry/src/github.com-1ecc6299db9ec823/ramp-0.2.5/src/int.rs:3416:27
     |
3416 |             ptr: unsafe { Unique::new(alloc::heap::EMPTY as *mut Limb) },
     |                           ^^^^^^^^^^^
     |
     = help: add #![feature(ptr_internals)] to the crate attributes to enable

How can we get pumpkin to compile?
Thanks,

Hmm... I'll take a look at this in a little bit.

This has been addressed in the latest release: https://github.com/zcdziura/pumpkin/releases/tag/v2.0.1


Upgrade cert-manager to 1.10.2. Closes #405.

Previous upgrade: cert-manger 1.5.0

Updated the upstream version
Changed the folder name
Updated .krmignore
[x] Tested on GKE 1.23

Full testing on GKE 1.24 or 1.25 will be done once all components will be upgraded.
I chose 1.10.2 over 1.10.1 as the latest patch included vulnerability fixes and a significant performance boost.

It looks good to me, but do we want to remove version number cert-manager-1-10 from the folder name? In this case, we just need to pull from upstream and rely on it for cert manager version.

Thank you! Updated.


BUG-Date Selector / Localization Provider

Description
MUI: Can not find utils in context. It looks like you forgot to wrap your component in LocalizationProvider, or pass dateAdapter prop directly.
How to reproduce
Open a page with DateSelector
Expected behavior
Shouldn't error
An Error showing on the page at least

depends on the way we import it:
import { LocalizationProvider } from "@mui/x-date-pickers/LocalizationProvider"; is valid
while import { LocalizationProvider } from "@mui/x-date-pickers"; does not provoke any 'compilation' error but generates a runtime error :-(


Model Helpers

Hi,
I'm currently working on a project using the gem and added some features including:

#wait_for_state - waiting (EM looping) until a desired state is reached
#reload - reloading of resources
#run - run actions (custom posts)

Thanks for the great work.
Cheers

merged 👍


PRODUCTION: Host local copies of libraries

Update deploy script (not in repo) to replace remote URLs with local copies during deploy.

https://github.com/lidel/yt-looper/commit/06fd250db54131d421132e8c1afdaec090f3a5b3:

Switch CDN to http://jsdelivr.com/ to fix TravisCI
production use yt.aergia.eu/x/ instead of cdn.jsdelivr.net  to take advantage of single SPDY/HTTP2 pipe


Run SQLite Vacuum when exporting

The VACUUM command optimizes and cleans up the SQLite DB, resulting in a decreased DB size.
Closes https://github.com/AndreasSko/go-jwlm/issues/15

Coverage decreased (-0.07%) to 81.427% when pulling 9f932a3260f3b0738f49de35e554372495b3e5d1 on vacuum into 9779fb623c16531ef42acbba52943d85742389aa on master.


[Bug] legend textStyle rich align work wrong

Version
5.3.0
Link to Minimal Reproduction
https://stackblitz.com/edit/js-zqokyc
Steps to Reproduce
see https://stackblitz.com/edit/js-zqokyc
Current Behavior
when the "lastName" in rich align is 'left', the align and width option is invalid. (just align === 'left‘  use 'right' or 'center' it is work)
Expected Behavior
let 'lastName' align left
Environment
- OS:
- Browser:
- Framework:

Any additional comments?
No response

with PR:
https://github.com/ecomfe/zrender/pull/897

with PR:
https://github.com/ecomfe/zrender/pull/897


Check archive names before creation

We should try to find a way of ensuring that an archive name is valid before allowing it to be created.
For example:
>>> import datafs
>>> api = datafs.get_api('test')
>>> archive = api.create('\\\\\\C::\\\~~~~~!!$@')
>>> archive
<DataArchive auth://\\\C::\\~~~~~!!$@>
>>> with archive.open('w+') as f:
...   f.write(u'the file contents')
...
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "C:\Anaconda2\envs\datafs\lib\contextlib.py", line 17, in __enter__
    return self.gen.next()
  File "C:\Anaconda2\envs\datafs\lib\site-packages\datafs\core\data_archive.py", line 450, in open
    with opener as f:
  File "C:\Anaconda2\envs\datafs\lib\contextlib.py", line 17, in __enter__
    return self.gen.next()
  File "C:\Anaconda2\envs\datafs\lib\site-packages\datafs\core\data_file.py", line 183, in open_file
    authority, cache, read_path, version_check, hasher) as read_fs:
  File "C:\Anaconda2\envs\datafs\lib\contextlib.py", line 17, in __enter__
    return self.gen.next()
  File "C:\Anaconda2\envs\datafs\lib\site-packages\datafs\core\data_file.py", line 75, in _choose_read_fs
    if not authority.fs.isfile(read_path):
  File "C:\Anaconda2\envs\datafs\lib\site-packages\fs\errors.py", line 257, in wrapper
    return func(self,*args,**kwds)
  File "C:\Anaconda2\envs\datafs\lib\site-packages\fs\osfs\__init__.py", line 258, in isfile
    return _isfile(self.getsyspath(path))
  File "C:\Anaconda2\envs\datafs\lib\site-packages\fs\osfs\__init__.py", line 166, in getsyspath
    self.validatepath(path)
  File "C:\Anaconda2\envs\datafs\lib\site-packages\fs\base.py", line 305, in validatepath
    raise InvalidCharsInPathError(path)
fs.errors.InvalidCharsInPathError: Path contains invalid characters: \\\C::\\~~~~~!!$@/None
>>>

Definitely need to do this


Update installation.adoc

Fixes #26748
Contributor Checklist

[x] Review Contribution Guidelines
[x] Make sure that all commits are signed off to indicate that you agree to the terms of Developer Certificate of Origin.
[x] Make sure all contributed code can be distributed under the terms of the Apache License 2.0, e.g. the code was written by yourself or the original code is licensed under a license compatible to Apache License 2.0.
[ ] Check "Allow edit from maintainers" option in pull request so that additional changes can be pushed by Gradle team
[ ] Provide integration tests (under <subproject>/src/integTest) to verify changes from a user perspective
[ ] Provide unit tests (under <subproject>/src/test) to verify logic
[ ] Update User Guide, DSL Reference, and Javadoc for public-facing changes
[ ] Ensure that tests pass sanity check: ./gradlew sanityCheck
[ ] Ensure that tests pass locally: ./gradlew <changed-subproject>:quickTest

Reviewing cheatsheet
Before merging the PR, comments starting with

❌ ❓must be fixed
🤔 💅 should be fixed
💭 may be fixed
🎉 celebrate happy things

Thank you for your contribution!
As commented on the referenced issue someone will follow up.

@bot-gradle test and merge

Your PR is queued. See the queue page for details.

I've triggered a build for you. Click here to see all failures if there's any.