HBASE-26435 The log rolling request maybe canceled immediately in LogRoller due to a race

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
5m  7s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

-0 :warning:
test4tests
0m  0s
The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ branch-1 Compile Tests _

+1 :green_heart:
mvninstall
10m 20s
branch-1 passed

+1 :green_heart:
compile
0m 45s
branch-1 passed with JDK Azul Systems, Inc.-1.8.0_262-b19

+1 :green_heart:
compile
0m 47s
branch-1 passed with JDK Azul Systems, Inc.-1.7.0_272-b10

+1 :green_heart:
checkstyle
1m 40s
branch-1 passed

+1 :green_heart:
shadedjars
3m 18s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 49s
branch-1 passed with JDK Azul Systems, Inc.-1.8.0_262-b19

+1 :green_heart:
javadoc
0m 41s
branch-1 passed with JDK Azul Systems, Inc.-1.7.0_272-b10

+0 :ok:
spotbugs
3m  8s
Used deprecated FindBugs config; considering switching to SpotBugs.

+1 :green_heart:
findbugs
3m  5s
branch-1 passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
2m  8s
the patch passed

+1 :green_heart:
compile
0m 45s
the patch passed with JDK Azul Systems, Inc.-1.8.0_262-b19

+1 :green_heart:
javac
0m 45s
the patch passed

+1 :green_heart:
compile
0m 48s
the patch passed with JDK Azul Systems, Inc.-1.7.0_272-b10

+1 :green_heart:
javac
0m 48s
the patch passed

+1 :green_heart:
checkstyle
1m 29s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
shadedjars
3m  6s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
hadoopcheck
5m  6s
Patch does not cause any errors with Hadoop 2.8.5 2.9.2.

+1 :green_heart:
javadoc
0m 32s
the patch passed with JDK Azul Systems, Inc.-1.8.0_262-b19

+1 :green_heart:
javadoc
0m 42s
the patch passed with JDK Azul Systems, Inc.-1.7.0_272-b10

-1 :x:
findbugs
2m 59s
hbase-server generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)

_ Other Tests _

-1 :x:
unit
48m  5s
hbase-server in the patch failed.

+1 :green_heart:
asflicense
0m 28s
The patch does not generate ASF License warnings.

96m 37s

Reason
Tests

FindBugs
module:hbase-server

Mismatched wait() in org.apache.hadoop.hbase.regionserver.LogRoller.run()  At LogRoller.java:At LogRoller.java:[line 161]

Failed junit tests
hadoop.hbase.procedure.TestProcedureManager

hadoop.hbase.client.TestMetaRegionLocationCache

hadoop.hbase.master.balancer.TestRegionLocationFinder

hadoop.hbase.regionserver.TestHRegionFileSystem

hadoop.hbase.client.TestClientClusterStatus

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3832/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/3832

Optional Tests
dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile

uname
Linux b1183aad97dd 4.15.0-156-generic #163-Ubuntu SMP Thu Aug 19 23:31:58 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
/home/jenkins/jenkins-agent/workspace/Base-PreCommit-GitHub-PR_PR-3832/out/precommit/personality/provided.sh

git revision
branch-1 / 0d214ff53e

Default Java
Azul Systems, Inc.-1.7.0_272-b10

Multi-JDK versions
/usr/lib/jvm/zulu-8-amd64:Azul Systems, Inc.-1.8.0_262-b19 /usr/lib/jvm/zulu-7-amd64:Azul Systems, Inc.-1.7.0_272-b10

findbugs
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3832/1/artifact/out/new-findbugs-hbase-server.html

unit
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3832/1/artifact/out/patch-unit-hbase-server.txt

Test Results
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3832/1/testReport/

Max. process+thread count
635 (vs. ulimit of 10000)

modules
C: hbase-server U: hbase-server

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3832/1/console

versions
git=2.17.1 maven=3.6.0 findbugs=3.0.1

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 34s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

-0 :warning:
test4tests
0m  0s
The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ branch-1 Compile Tests _

+1 :green_heart:
mvninstall
10m 22s
branch-1 passed

+1 :green_heart:
compile
0m 46s
branch-1 passed with JDK Azul Systems, Inc.-1.8.0_262-b19

+1 :green_heart:
compile
0m 49s
branch-1 passed with JDK Azul Systems, Inc.-1.7.0_272-b10

+1 :green_heart:
checkstyle
1m 39s
branch-1 passed

+1 :green_heart:
shadedjars
3m 20s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 51s
branch-1 passed with JDK Azul Systems, Inc.-1.8.0_262-b19

+1 :green_heart:
javadoc
0m 40s
branch-1 passed with JDK Azul Systems, Inc.-1.7.0_272-b10

+0 :ok:
spotbugs
3m  8s
Used deprecated FindBugs config; considering switching to SpotBugs.

+1 :green_heart:
findbugs
3m  5s
branch-1 passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
2m  7s
the patch passed

+1 :green_heart:
compile
0m 44s
the patch passed with JDK Azul Systems, Inc.-1.8.0_262-b19

+1 :green_heart:
javac
0m 44s
the patch passed

+1 :green_heart:
compile
0m 49s
the patch passed with JDK Azul Systems, Inc.-1.7.0_272-b10

+1 :green_heart:
javac
0m 49s
the patch passed

+1 :green_heart:
checkstyle
1m 27s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
shadedjars
3m  2s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
hadoopcheck
5m  7s
Patch does not cause any errors with Hadoop 2.8.5 2.9.2.

+1 :green_heart:
javadoc
0m 32s
the patch passed with JDK Azul Systems, Inc.-1.8.0_262-b19

+1 :green_heart:
javadoc
0m 40s
the patch passed with JDK Azul Systems, Inc.-1.7.0_272-b10

+1 :green_heart:
findbugs
2m 58s
the patch passed

_ Other Tests _

-1 :x:
unit
133m 18s
hbase-server in the patch failed.

+1 :green_heart:
asflicense
0m 38s
The patch does not generate ASF License warnings.

177m 22s

Reason
Tests

Failed junit tests
hadoop.hbase.replication.TestReplicationEndpoint

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3832/2/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/3832

Optional Tests
dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile

uname
Linux 4448da3254da 4.15.0-156-generic #163-Ubuntu SMP Thu Aug 19 23:31:58 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
/home/jenkins/jenkins-agent/workspace/Base-PreCommit-GitHub-PR_PR-3832/out/precommit/personality/provided.sh

git revision
branch-1 / 0d214ff53e

Default Java
Azul Systems, Inc.-1.7.0_272-b10

Multi-JDK versions
/usr/lib/jvm/zulu-8-amd64:Azul Systems, Inc.-1.8.0_262-b19 /usr/lib/jvm/zulu-7-amd64:Azul Systems, Inc.-1.7.0_272-b10

unit
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3832/2/artifact/out/patch-unit-hbase-server.txt

Test Results
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3832/2/testReport/

Max. process+thread count
4293 (vs. ulimit of 10000)

modules
C: hbase-server U: hbase-server

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3832/2/console

versions
git=2.17.1 maven=3.6.0 findbugs=3.0.1

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 33s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

-0 :warning:
test4tests
0m  0s
The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ branch-1 Compile Tests _

+1 :green_heart:
mvninstall
10m 10s
branch-1 passed

+1 :green_heart:
compile
0m 44s
branch-1 passed with JDK Azul Systems, Inc.-1.8.0_262-b19

+1 :green_heart:
compile
0m 48s
branch-1 passed with JDK Azul Systems, Inc.-1.7.0_272-b10

+1 :green_heart:
checkstyle
1m 39s
branch-1 passed

+1 :green_heart:
shadedjars
3m 17s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 49s
branch-1 passed with JDK Azul Systems, Inc.-1.8.0_262-b19

+1 :green_heart:
javadoc
0m 41s
branch-1 passed with JDK Azul Systems, Inc.-1.7.0_272-b10

+0 :ok:
spotbugs
3m  7s
Used deprecated FindBugs config; considering switching to SpotBugs.

+1 :green_heart:
findbugs
3m  4s
branch-1 passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
2m  7s
the patch passed

+1 :green_heart:
compile
0m 44s
the patch passed with JDK Azul Systems, Inc.-1.8.0_262-b19

+1 :green_heart:
javac
0m 44s
the patch passed

+1 :green_heart:
compile
0m 47s
the patch passed with JDK Azul Systems, Inc.-1.7.0_272-b10

+1 :green_heart:
javac
0m 47s
the patch passed

+1 :green_heart:
checkstyle
1m 28s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
shadedjars
3m  4s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
hadoopcheck
5m  6s
Patch does not cause any errors with Hadoop 2.8.5 2.9.2.

+1 :green_heart:
javadoc
0m 33s
the patch passed with JDK Azul Systems, Inc.-1.8.0_262-b19

+1 :green_heart:
javadoc
0m 42s
the patch passed with JDK Azul Systems, Inc.-1.7.0_272-b10

+1 :green_heart:
findbugs
2m 52s
the patch passed

_ Other Tests _

-1 :x:
unit
131m 58s
hbase-server in the patch failed.

+1 :green_heart:
asflicense
0m 40s
The patch does not generate ASF License warnings.

175m 38s

Reason
Tests

Failed junit tests
hadoop.hbase.replication.TestReplicationEndpoint

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3832/3/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/3832

Optional Tests
dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile

uname
Linux 73efe5dc6437 4.15.0-156-generic #163-Ubuntu SMP Thu Aug 19 23:31:58 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
/home/jenkins/jenkins-agent/workspace/Base-PreCommit-GitHub-PR_PR-3832/out/precommit/personality/provided.sh

git revision
branch-1 / 0d214ff53e

Default Java
Azul Systems, Inc.-1.7.0_272-b10

Multi-JDK versions
/usr/lib/jvm/zulu-8-amd64:Azul Systems, Inc.-1.8.0_262-b19 /usr/lib/jvm/zulu-7-amd64:Azul Systems, Inc.-1.7.0_272-b10

unit
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3832/3/artifact/out/patch-unit-hbase-server.txt

Test Results
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3832/3/testReport/

Max. process+thread count
4480 (vs. ulimit of 10000)

modules
C: hbase-server U: hbase-server

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3832/3/console

versions
git=2.17.1 maven=3.6.0 findbugs=3.0.1

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Reidddddd PTAL? This is for branch-1.

Some tests are failing due to the patch. Currently I am working on production incidents and won't get time to look into failures until next week. Sorry for the delay.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
8m  3s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

-0 :warning:
test4tests
0m  0s
The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ branch-1 Compile Tests _

+1 :green_heart:
mvninstall
10m 24s
branch-1 passed

+1 :green_heart:
compile
0m 46s
branch-1 passed with JDK Azul Systems, Inc.-1.8.0_262-b19

+1 :green_heart:
compile
0m 51s
branch-1 passed with JDK Azul Systems, Inc.-1.7.0_272-b10

+1 :green_heart:
checkstyle
1m 56s
branch-1 passed

+1 :green_heart:
shadedjars
3m 33s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 48s
branch-1 passed with JDK Azul Systems, Inc.-1.8.0_262-b19

+1 :green_heart:
javadoc
0m 43s
branch-1 passed with JDK Azul Systems, Inc.-1.7.0_272-b10

+0 :ok:
spotbugs
3m 20s
Used deprecated FindBugs config; considering switching to SpotBugs.

+1 :green_heart:
findbugs
3m 16s
branch-1 passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
2m 19s
the patch passed

+1 :green_heart:
compile
0m 45s
the patch passed with JDK Azul Systems, Inc.-1.8.0_262-b19

+1 :green_heart:
javac
0m 45s
the patch passed

+1 :green_heart:
compile
0m 51s
the patch passed with JDK Azul Systems, Inc.-1.7.0_272-b10

+1 :green_heart:
javac
0m 51s
the patch passed

+1 :green_heart:
checkstyle
1m 42s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
shadedjars
3m 22s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
hadoopcheck
5m 33s
Patch does not cause any errors with Hadoop 2.8.5 2.9.2.

+1 :green_heart:
javadoc
0m 32s
the patch passed with JDK Azul Systems, Inc.-1.8.0_262-b19

+1 :green_heart:
javadoc
0m 42s
the patch passed with JDK Azul Systems, Inc.-1.7.0_272-b10

+1 :green_heart:
findbugs
3m 11s
the patch passed

_ Other Tests _

-1 :x:
unit
152m 54s
hbase-server in the patch failed.

+1 :green_heart:
asflicense
0m 36s
The patch does not generate ASF License warnings.

206m 37s

Reason
Tests

Failed junit tests
hadoop.hbase.mapreduce.TestLoadIncrementalHFiles

hadoop.hbase.replication.TestReplicationEndpoint

hadoop.hbase.TestZooKeeper

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3832/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/3832

Optional Tests
dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile

uname
Linux 7002f4eaba3f 4.15.0-162-generic #170-Ubuntu SMP Mon Oct 18 11:38:05 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
/home/jenkins/jenkins-home/workspace/Base-PreCommit-GitHub-PR_PR-3832/out/precommit/personality/provided.sh

git revision
branch-1 / a2406f3764

Default Java
Azul Systems, Inc.-1.7.0_272-b10

Multi-JDK versions
/usr/lib/jvm/zulu-8-amd64:Azul Systems, Inc.-1.8.0_262-b19 /usr/lib/jvm/zulu-7-amd64:Azul Systems, Inc.-1.7.0_272-b10

unit
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3832/1/artifact/out/patch-unit-hbase-server.txt

Test Results
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3832/1/testReport/

Max. process+thread count
4167 (vs. ulimit of 10000)

modules
C: hbase-server U: hbase-server

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3832/1/console

versions
git=2.17.1 maven=3.6.0 findbugs=3.0.1

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.


Packaging request: tailwindcss cli

Project description
Tailwindcss is a utility-first CSS framework. The team has recently built a cli to facilitate the compilation process.
Metadata

homepage URL: https://tailwindcss.com/docs/installation#using-tailwind-cli
source URL: https://github.com/tailwindlabs/tailwindcss
license: mit
platforms: it is an npm package, so unix, linux, darwin

Here is also the link to the npm package containing the executable of the cli: https://www.npmjs.com/package/tailwindcss
It does not seem complicated to build in Nix but I have just never done that before so it feels a little overwhelming to me. Would appreciate a hand.

Welcome to nixpkgs! There's a nixpkgs manual that contains useful information for packaging for nixpkgs. There are also specific sections for adding packages and specific languages. Here's what I did to package tailwindcss.

Thanks, @jyooru for the warm welcome and the guidance. I did not know those docs were that accurate.
And thank you also for taking the time to create this PR, that is much appreciated.

Do you know by any chance why tailwindcss still does not appear on https://search.nixos.org/packages (unstable channel), while I can properly install it with nix-env -iA nixpkgs.nodePackages.tailwindcss?
The nixpkgs-unstable channel is correctly built of what I can see: https://status.nixos.org/
Is there anything special blocking me from finding it? Maybe there is a delay before it shows up on search.nixos.org.

I've just tried installing it on my system and it's not working either.
search.nixos.org is updated hourly: https://github.com/NixOS/nixos-search/actions/workflows/cron-nixpkgs.yml
It seems to have broken 12 hours ago, but this was merged 2 days ago, and even running a local nix search doesn't show nodePackages.tailwindcss...
After a little investigation, it looks like there's a bigger problem here.
I've tried a few PRs that add a new node package and none seem to be available on nixos-unstable but are available in the nixpkgs repository (eg nix-build -A nodePackages.tailwindcss.
For example, #129668, added 9th of July:
❯ nix-shell -p nodePackages.terser
error: attribute 'terser' missing

Where as running it through the master branch (through flakes):
❯ nix shell .#pkgs.nodePackages.terser
❯ terser --help
Usage: terser [options] [files...]
...

@Mic92, is this a bug worth making an issue for?

This works for me:
$ nix-shell -I nixpkgs=https://github.com/NixOS/nixpkgs/archive/nixpkgs-unstable.tar.gz --builders '' -p nodePackages.tailwindcss

I confirm. From what I see, the package is included in the nixpkgs-unstable branch.
commit af0da8e2eaf7ccafba00fc778fe87ad3d7faf492
Author: Joel<EMAIL_ADDRESS>Date:   Fri Dec 10 11:37:25 2021 +1000

    tailwindcss: init at 3.0.1

$ git branch --all --contains af0da8e2eaf7ccafba00fc778fe87ad3d7faf492

remotes/origin/haskell-updates
remotes/origin/master
remotes/origin/nixos-unstable
remotes/origin/nixos-unstable-small
remotes/origin/nixpkgs-unstable        <-- HERE
remotes/origin/staging
remotes/origin/staging-next

And the last successful build of nixpkgs-unstable (as reported on https://status.nixos.org/) is c473cc8714710179df205b153f4e9fa007107ff9.
And so af0da8e2eaf7ccafba00fc778fe87ad3d7faf492 belongs to this build.
$ git log --oneline c473cc8714710179df205b153f4e9fa007107ff9 | grep af0da8e2eaf
af0da8e2eaf tailwindcss: init at 3.0.1

However, I still don’t see it in https://search.nixos.org

I don't think search.nixos.org indexes all packages in nodePackages because we don't build all packages in nodePackages.
To make it show up in nixos-search, we need an alias in all-packages.nix. Something like:
tailwindcss = nodePackages.tailwindcss;

Are you sure about this? If I take for example leetcode-cli, it does not exist in all-packages.nix while it appears in search.nixos.org.
And there are many other examples of packages that I can find in search.nixos.org belonging to pkgs/development/node-packages/node-packages.json and not to all-packages.nix.

# pkgs/top-level/all-packages.nix
  nodePackages = dontRecurseIntoAttrs nodejs.pkgs;

I believe dontRecurseIntoAttrs means something along the lines of only evaluate the values you need. The packages that do show up have been evaluated because they have been aliased elsewhere or because they may be a dependency of another package that has been evaluated.

Are you sure about this? If I take for example leetcode-cli, it does not exist in all-packages.nix while it appears in search.nixos.org.
And there are many other examples of packages that I can find in search.nixos.org belonging to pkgs/development/node-packages/node-packages.json and not to all-packages.nix.

looks like the import in nixos-search is broken: https://github.com/NixOS/nixos-search/runs/4521001235?check_suite_focus=true

Let’s first see what happens once the import is fixed then.
Thanks for creating the issue @Mic92.


Incorrect results when H is applied to 2nd qubit of a 2 qubit system

using QuantumSavory

ra = Register(1)
rb = Register(1)

st = L0⊗X1

initialize!((ra[1], rb[1]), st)
ra.staterefs[1].state[]

apply!(rb[1], H)
ra.staterefs[1].state[]

Here, the initial state L0⊗X1 should be transformed to L0⊗L0 when Hadamard is applied to the 2nd qubit, but instead we get X1⊗X1

Could you double check this? I do not seem to be able to reproduce it:
julia> ra = Register(1)
Register with 1 slots: [ Qubit ]
  Slots:
    nothing

julia> rb = Register(1)
Register with 1 slots: [ Qubit ]
  Slots:
    nothing

julia> st = L0⊗X1
|Z₁⟩|X₁⟩

julia> initialize!((ra[1], rb[1]), st)
State containing 2 subsystems in QuantumOpticsBase implementation
  In registers:
    1@12899361520081501929
    1@4465442880340761800

julia> ra.staterefs[1].state[]
Ket(dim=4)
  basis: [Spin(1/2) ⊗ Spin(1/2)]
 0.7071067811865475 + 0.0im
                0.0 + 0.0im
 0.7071067811865475 + 0.0im
                0.0 + 0.0im

julia> apply!(rb[1], H)
(Register[Register with 1 slots: [ Qubit ]
  Slots:
    Subsystem 2 of QuantumOpticsBase.Ket<PHONE_NUMBER>3556155838], 0.0)

julia> ra.staterefs[1].state[]
Ket(dim=4)
  basis: [Spin(1/2) ⊗ Spin(1/2)]
 0.9999999999999999 + 0.0im
                0.0 + 0.0im
                0.0 + 0.0im
                0.0 + 0.0im

Please reopen if it is indeed reproducible.

Oh, my bad, I was testing it on a wrong branch


dropzone

dropzone
http://www.whatwg.org/specs/web-apps/current-work/multipage/dnd.html#the-dropzone-attribute

This issue was imported from Google Moderator
Moderator votes: +5
Issue added by snifty on 2012-07-20
To vote this issue up or down, simply include +1 or -1 in your comment.

Covered by http://caniuse.com/#feat=dragndrop :

Currently no browser supports the dropzone attribute.

Yup.


Smart Dashboard?

Is there support for displaying the smart dashboard?
To me this is an important feature given the lack of a graphical robot.

If you open the SD from the driver station or by clicking on the jar, it expects to talk to the real robot (either through the USB cable, or DNS lookup, or known IP address).  If you want to use the SD locally, you need to start it and specify the IP to use (localhost).
If you are using the quickstart version, it should come with an open_smart_dashboard.bat script that makes it simple to do.  Otherwise you can download the one from the repo and use that for convenience.

Oh, that was a little obvious. Thanks though!


Question about the perfetto UI

Hello folks!
Thanks for the great project. I have some question about perfetto ui.
I am using the legacy chrome json format in perfetto for pytorch profiling, the trace file is generate by python. I noticed that perfetto can highlight releated trace spans. How can i use it for json format? If json format do not support it, can i use c++ sdk for generate binary trace file for the highlight feature?
We are focusing on distributed profiling, there are lots of process groups so i really want to use highlight feature! Thanks.
And i noticed binary file is much smaller than json file.
One more question about c++ sdk, I have some trace data which is not generated by perfetto tracing tools, does perfetto offers c++ api to generate trace file? Or I just use the proto define and fill it then serializing it?

I noticed that

I noticed that perfetto can highlight releated trace spans

Can you please clarify what you mean by this? Your screenshot simply shows some pinned tracks and an empty selection: I don't understand what you mean by "related trace spans".

And i noticed binary file is much smaller than json file.

Yeah this is very WAI: the JSON format is much much less efficient in encoding than the protobuf format by design.

I noticed that

I press command+enter which is newline on my editor, when I realize it, it has published 😱

I noticed that perfetto can highlight releated trace spans

Can you please clarify what you mean by this? Your screenshot simply shows some pinned tracks and an empty selection: I don't understand what you mean by "related trace spans".

And i noticed binary file is much smaller than json file.

Yeah this is very WAI: the JSON format is much much less efficient in encoding than the protobuf format by design.

My bad.
I will illustrate it by image.
In this trace file, there 8 process, [0,1,4,5] is a group1 and [2,3,6,7] is group2.
I want when i hover on span of any process in group1, all spans in process [0,1,4,5] will highlight, like the gif in https://perfetto.dev/docs/visualization/perfetto-ui shows.

That's a special property of scheduling tracks only and cannot be replicated with userspace slices on either the proto or JSON format.
@stevegolton can comment further but seems very unlikely that we'd be looking to add any similar feature in the short to medium term for userspace slices b

The track highlighting differs depending on the track.
The only type of "bulk" highlighting we have on non-scheduling tracks (like in your latest screenshot) is that all tracks with the same title are highlighted. This is only on certain track impls, but I think that's what you're seeing.
On scheduling tracks as in your first screenshot and the gif on https://perfetto.dev/docs/visualization/perfetto-ui, all slices are grayed out apart from slices that originate from the same utid / pid, with slices from the same utid receiving a more pronounced highlight than slices just from the same pid.
As @LalitMaganti mentioned, there is no way to configure this from the trace aside from setting the slice titles to the same thing which probably isn't desirable.

@stevegolton thanks. So can i just generate "scheduling tracks" as my trace span and set them with same tid/pid or someother property to archive my goal?

Possibly, though scheduling tracks are designed to represent what's scheduled to run on each CPU at any given moment, so they have other limitations and are represented differently in the UI compared to userspace slices - e.g. limited number of tracks (one per CPU), no nested slices, different details panel, etc.
If they can be repurposed for your use case then that's great, but it might be a bit of a hack.
See https://perfetto.dev/docs/data-sources/cpu-scheduling

Possibly, though scheduling tracks are designed to represent what's scheduled to run on each CPU at any given moment, so they have other limitations and are represented differently in the UI compared to userspace slices - e.g. limited number of tracks (one per CPU), no nested slices, different details panel, etc.
If they can be repurposed for your use case then that's great, but it might be a bit of a hack.
See https://perfetto.dev/docs/data-sources/cpu-scheduling

thanks, i will try it :)

Hi, all.
I have another issue. I have 2 spans, but they are very close, looks like perfetto ui merge them into longer one, but another one is displayed as 1ns.
Some spans data which cause merging spans.

span name
start
duration

matmul_bmnk_1_8192_33936_16380_
1717052741134262
13303

matmul_bmnk_1_8192_16380_33936_
1717052741147574
13901

The timeline displayed in perfetto ui.

I minus 10us for each duration in spans, it looks good, but i want to known how can i solve it in right way.
Thanks.

Spans cannot be overlapping on a single track. Not sure what your are emitting at the proto level at this point but if you are emitting track event (https://perfetto.dev/docs/reference/synthetic-track-event) then you want to emit each event on an async track with the same name so the UI would merge them together.

Spans cannot be overlapping on a single track. Not sure what your are emitting at the proto level at this point but if you are emitting track event (https://perfetto.dev/docs/reference/synthetic-track-event) then you want to emit each event on an async track with the same name so the UI would merge them together.

I am using sync track, all spans are in same thread, may be there are some problem with the precision of my data. Thanks

Sorry to bother again.
I am using protobuf to generate my own trace, and i use interning data already. But i have lots of spans, and i merge the protobuf message in python, it eat lots of memory. The origin data size is about 2.6GiB, so the timeline maybe 3GiB, I noticed perfetto has util to split traces, i want to known how can i generate partial of track events and use trace_processor to visualize it in UI? Is there any c++ interface of trace_processor?

i merge the protobuf message in python, it eat lots of memory.

Instead of creating a single giant Trace message, I'd suggest creating a trace protobuf of a few thousand slices, flushing that to disk, clearing the trace protobuf and repeating. Trace messages can be directly concatenated together without any extra work.

I noticed perfetto has util to split traces,

Trace processor is not a utility to split traces, it is purely for analysing traces and can be used as the backend of the UI to visualize large traces.

Is there any c++ interface of trace_processor?

Yes as mentioned in our docs (https://perfetto.dev/docs/analysis/trace-processor) but I'm pretty sure it's not what you want if you're struggling with putting together large trace files.

Instead of creating a single giant Trace message, I'd suggest creating a trace protobuf of a few thousand slices, flushing that to disk, clearing the trace protobuf and repeating. Trace messages can be directly concatenated together without any extra work.

So once I create several protobuf binary files, how can perfetto ui load multiple binary files into same tab?

Trace processor is not a utility to split traces, it is purely for analysing traces and can be used as the backend of the UI to visualize large traces.

My trace is huge, so can i just split repeated messages and use trace processor to visualize large traces?

So once I create several protobuf binary files, how can perfetto ui load multiple binary files into same tab?

Just concatenate the protobufs into the same file by appending one chunk of protobuf after another. Trace protobufs can be freely concatenated at the byte level.

so can i just split repeated messages and use trace processor to visualize large traces?

Sure but only in different UI instances. There is no way to split a trace into multiple files and then visualize everything at the same time: you should just generate the file in a merged way in the first place.

Thanks your quick reply.
Let me clarify my process and please help me to check my understand, thanks!

Just concatenate the protobufs into the same file by appending one chunk of protobuf after another. Trace protobufs can be freely concatenated at the byte level.

I am using multiprocessing to processing each data into Trace. And the proto define in perfetto is
message Trace {
  repeated TracePacket packet = 1;

  // Do NOT add any other field here. This is just a convenience wrapper for
  // the use case of a trace being saved to a file. There are other cases
  // (streaming) where TracePacket are directly streamed without being wrapped
  // in a Trace proto. Nothing should ever rely on the full trace, all the
  // logic should be based on TracePacket(s).
}

And at last, i will merge multiple Trace into one Trace, this merge processing eats lots of memory. As you mentioned, I just SerializeToString each Trace and flush them to disk one by one, no need to merge into one large Trace?

As you mentioned, I just SerializeToString each Trace and flush them to disk one by one, no need to merge into one large Trace?

Correct.


feat(mlp): [WIP] Add MLP chart

Motivation
Addin MLP chart to helm charts, moving the application helm charts from app repo to central repo.
Modification

Added MLP chart from mlp repo
Modify source for DB-migrations to point to github repo

Checklist

[ ] Chart version bumped
[x] README.md updated

we don't have to include *.tgz for dependencies, if it is not present then helm will download it

@ariefrahmansyah, This will be the corresponding MR in CaraML to add the MLP chart in the CaraML charts repo.
Points to note here:

I've removed the ConfigMap resource that the MLP chart was created earlier which was added as a mounted volume in containers.

This is because we no longer need to add the volume, instead we get this information from the docker image pulled.
Also, I've confirmed after checking the code that we don't need the volume mounted in the MLP container., Once this chart is accepted, I will raise another PR in the MLP repo to use this published chart instead of the dir present in its repo for e2e tests.

Please let me know if you see any conerns.


Make getState controllable

Hi,
Thanks for the great lib. I'm using it to test my middlewares. But since in middleware I can access the API getState, could you make it more controllable by passing the actions along when calling getState
getState () {
    return isFunction(getState) ? getState(actions) : getState
},

So I can use it like this
const store = mockStore(actions => {
    const lastAction = actions[actions.length - 1]
    if (!lastAction) return {}
    if (lastAction.type === 'GET_FOO') return { foo: 'foo' }
})
store.getState() // {}
store.dispatch({ type: 'GET_FOO' })
store.getState() // { foo: 'foo' }

What do you think? If you're OK with it I can make a PR 😊

@toan2406 that's what I would like to have too.

I also need it too.

store.getState() // {}
store.dispatch({ type: 'GET_FOO' })
store.getState() // { foo: 'foo' }

This part of the code is invalid from the perspective of immutable event dispatching: you are dispatching one action but getting from the store another one.
@toan2406 Could you please describe the problem that you are facing more in details, so we can try to come up with the solution which would not break the ideas behind redux?

@dmitry-zaets Thanks for your reply. For example I want to simulate the redux example, which is:
store.getState() // 0
store.dispatch({ type: 'INCREMENT' })
store.dispatch({ type: 'INCREMENT' })
store.dispatch({ type: 'DECREMENT' })
store.getState() // 1

So with the actions as the argument for the callback when I create the mockStore, I can do something like this:
const store = mockStore(actions => {
    const defaultState = 0
    return actions.reduce((result, action) => {
        if (action.type === 'INCREMENT') return result + 1
        if (action.type === 'DECREMENT') return result - 1
        return result
    }, defaultState)
})

For the example on the above comment, maybe I should make it clearer like this:
store.dispatch({ type: 'GET_FOO', payload: fetch('/get_foo_api') })
// after promise is resolved and store is updated; for the mock can just make it synchronously
store.getState() // { foo: 'foo' }

I don't understand about immutable event dispatching. Could you pls give more info about it? Thanks alot.

@toan2406 Thanks a lot for the explanation. My bad, I've misunderstood the initial explanations.
https://github.com/arnaudbenard/redux-mock-store/pull/109


properties.cause referred to as properties.clause

Check "Therefore, using the clause above may result in an alert not being triggered, because the properties.clause property value will be set to null."

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 73f3e9c6-8cf1-6c8d-2de7-54f6d3740fc1
Version Independent ID: 42af845a-aed7-a035-33ee-66077d7efc57
Content: Template to create Resource Health alerts - Azure Service Health
Content Source: articles/service-health/resource-health-alert-arm-template-guide.md
Service: service-health
GitHub Login: @stephbaron
Microsoft Alias: stbaron

@VaclavK Thanks for bringing this to our notice. I have made changes to the document and once the changes are approved , it will reflect in the document soon.
We will close the issue for now. If there are further questions , please revert and we will be glad to assist you.


Login fails with response 429

I have followed the instructions in the README. Although the auth-token is received successfully, authorization fails with error code 429. Any idea what the problem is?

The same problem

Fixed in #54. The only thing that needs to change is the firefox version in the request header as that was too outdated

Thanks again @btw04 your fixes over the past few years have been terrific for those of us using the library long term but not familiar enough with the codebase to fix it ourselves. For those like me, before the pull request is merged in, you can just add the code that btw04 modified before the ticktickclient is initialized and this will overwrite the variables accordingly and seems to work for me. EG:
`
USER_AGENT = "Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:123.0) Gecko/20100101 Firefox/123.0"
X_DEVICE_ = '{"platform":"web","os":"OS X","device":"Firefox 123.0","name":"unofficial api!","version":4531,' \
TickTickClient.HEADERS = {'User-Agent': USER_AGENT,
'x-device': X_DEVICE_}
`

For me just patching headers didn't work, I needed to update the endpoint:
class TickTickClientPatched(TickTickClient):
    def _login(self, username: str, password: str) -> None:
        """
        Logs in to TickTick and sets the instance access token.

        Arguments:
            username: TickTick Username
            password: TickTick Password

        """
        url = self.BASE_URL + 'user/signon?wc=true&remember=true'
        user_info = {
            'username': username,
            'password': password
        }
        parameters = {
            'wc': True,
            'remember': True
        }

        response = self.http_post(url, json=user_info, params=parameters, headers=self.HEADERS)

        self.access_token = response['token']
        self.cookies['t'] = self.access_token

client = TickTickClientPatched(
    os.getenv("TICKTICK_USERNAME"), os.getenv("TICKTICK_PASSWORD"), auth_client
)

I am wondering about the policy of when to mark an issue as closed.  One approach is to close the issue when the cause is known and a workaround is available.  Another approach would be to only close it when code fixes are reflected in the version that new users install.  The default in GitHub is that only open issues are displayed. A new user could install the app, have a problem then look into the list of open issues and not see the appropriate issue in GitHub. For this reason I favour the second approach of only closing the issue when code fixes are reflected in the version that new users install.


Allow user to type "1 + delimiter" and auto format to "01 + delimiter" for date

Currently if a user were to type "1" and then the delimiter they would be blocked from typing the delimiter and would need to go back and add a 0 before the 1.
The field should detect that if a user has typed the delimiter value on their own, it should fix the format of the month / day entered and move on to the next part of the date, similar to what it does if the user types 2 or 3.

@sdzaveri
I work around this case with bind keydown event with the below handler function.
function processRawInput(event) {
  const { delimiter, dateFormatter } = this.cleaveInstance.properties;
  if (event.key !== delimiter) {
    return;
  }
  const { blocks, datePattern } = dateFormatter;
  let value = event.target.value.replace(/[^\d]/g, "");
  let result = "";
  blocks.forEach((length, index) => {
    if (value.length > 0) {
      let sub = value.slice(0, length);
      const sub0 = sub.slice(0, 1),
        rest = value.slice(length);

      switch (datePattern[index]) {
        case "d":
        case "m":
          const prefixDigit = parseInt(sub0, 10);
          if (sub.length === 1 && prefixDigit === 0) {
            sub = "01";
          } else if (prefixDigit > 0 && prefixDigit < 10) {
            sub = `0${sub}`;
          }
          break;
      }
      result += sub;
      value = rest;
    }
  });
  this.cleaveInstance.setRawValue(result);
}


Multiple @GeneratedValue are not possible

I like to do this:
    /**
     * @var int
     *
     * @ORM\Column(type="integer")
     * @ORM\Id
     * @ORM\GeneratedValue(strategy="AUTO")
     */
    private $id;

    /**
     * @var \Ramsey\Uuid\Uuid
     *
     * @ORM\Column(type="uuid")
     * @ORM\GeneratedValue(strategy="CUSTOM")
     * @ORM\CustomIdGenerator(class="Ramsey\Uuid\Doctrine\UuidGenerator")
     */
    private $uuid;

But this is not possible. It will remove the AUTO_INCREMENT from the id field. More info: http://stackoverflow.com/questions/13915944/two-generated-values-in-doctrine
So please add to documentation how to use it additionally to an id field.

I've bypassed this issue by adding an event listener to my code. My application is based on the Symfony Framework so your code might be different.
Let's say we have EntityA and EntityB and both have the following code:
    /**
     * @var \Ramsey\Uuid\Uuid
     *
     * @ORM\Column(type="uuid")
     */
    private $uuid;

(Don't forget to create setUuid($uuid) and getUuid() on the entity classes)
Event listener:
<?php
namespace AppBundle\EventListener;

use AppBundle\Entity\EntityA;
use AppBundle\Entity\EntityB;
use Doctrine\Common\EventSubscriber;
use Doctrine\ORM\Event\LifecycleEventArgs;
use Ramsey\Uuid\Doctrine\UuidGenerator;

class UuidSubscriber implements EventSubscriber
{
    /**
     * @var UuidGenerator
     */
    private $generator;

    /**
     * @param UuidGenerator $uuidGenerator
     */
    public function __construct(UuidGenerator $uuidGenerator)
    {
        $this->generator = $uuidGenerator;
    }

    /**
     * {@inheritdoc}
     */
    public function getSubscribedEvents()
    {
        return [
            'prePersist',
            'preUpdate',
        ];
    }

    /**
     * @param LifecycleEventArgs $args
     */
    public function prePersist(LifecycleEventArgs $args)
    {
        $this->updateUuid($args);
    }

    /**
     * @param LifecycleEventArgs $args
     */
    public function preUpdate(LifecycleEventArgs $args)
    {
        $this->updateUuid($args);
    }

    /**
     * @param LifecycleEventArgs $args
     */
    public function updateUuid(LifecycleEventArgs $args)
    {
        $entity = $args->getEntity();

        if (!$entity instanceof EntityA
            && !$entity instanceof EntityB
        ) {
            return;
        }

        if (empty($entity->getUuid())) {
            $uuid = $this->generator->generate($args->getEntityManager(), $entity);
            $entity->setUuid($uuid);
        }
    }
}

This will automatically add a new UUID to the $uuid field of the entities EntityA and EntityB if no UUID has been manually set.

Thanks for the update. I wasn't ignoring this issue, though I should have spoken up to acknowledge that I saw it. I just wasn't sure exactly how to address it, but your solution looks good.

@ramsey It would be nice if this would be added to the documentation.
Another easier solution would be to use Lifecycle Events directly in the entity class:
http://doctrine-orm.readthedocs.io/en/latest/reference/events.html#lifecycle-callbacks

@JHGitty, would you like to send a PR to update the README with examples? You might be able to explain the issue better than I can.

Is there a solution if you're mixing a fixed primary key property with another auto increment (sequence) property? I cannot get this sorted out.

Can this issue be reopened? It is still not possible (at least in certain cases) to add a second GeneratedValue when the database already exists and is already populated. This results in the "doctrine:schema:update" command trying to alter the existing GeneratedValue column.
Imagine you have a populated database with this schema:
/**
* @ORM\Entity
**/
class MyEntity
{
    /**
     * @var int
     *
     * @ORM\Column(name="id", type="integer")
     * @ORM\Id
     * @ORM\GeneratedValue(strategy="IDENTITY")
    **/
    private $id;
}

You then add a new GeneratedValue column to it.
/**
* @ORM\Entity
**/
class MyEntity
{
    /**
     * @var int
     *
     * @ORM\Column(name="id", type="integer")
     * @ORM\Id
     * @ORM\GeneratedValue(strategy="IDENTITY")
    **/
    private $id;
    /**
     * @var int
     *
     * @ORM\Column(name="public_id", type="uuid")
     * @ORM\Id
     * @ORM\GeneratedValue(strategy="CUSTOM")
     * @ORM\CustomIdGenerator(class="Ramsey\Uuid\Doctrine\UuidGenerator")
    **/
    private $publicId;

}

Then you try to update your schema:
/var/www bin/console doctrine:schema:update --force
This fails with following message:
SQLSTATE[HY000]: General error: 1833 Cannot change column 'id': used in a foreign key constraint 'FK_2D25F90A9E6B1585' of table 'mydb.other_table'

If I let the command dump the SQL then I see that it tries to do an alter statement on the id column, even though from the SQL you can see that it didn't change at all.
/var/www bin/console doctrine:schema:update --dump-sql
ALTER TABLE my_entity ADD public_id CHAR(36) NOT NULL COMMENT '(DC2Type:uuid)', CHANGE id id INT NOT NULL;

If I remove GeneratedValue from the public_id column then everything is fine.
/**
* @ORM\Entity
**/
class MyEntity
{
    /**
     * @var int
     *
     * @ORM\Column(name="id", type="integer")
     * @ORM\Id
     * @ORM\GeneratedValue(strategy="IDENTITY")
    **/
    private $id;
    /**
     * @var int
     *
     * @ORM\Column(name="public_id", type="uuid")
     * @ORM\Id
    **/
    private $publicId;

}

/var/www bin/console doctrine:schema:update --dump-sql
ALTER TABLE my_entity ADD public_id CHAR(36) NOT NULL COMMENT '(DC2Type:uuid)';

Might be caused by or related to https://github.com/doctrine/doctrine2/issues/7215

Might be caused by or related to doctrine/orm#7215

Related, yes. Not caused, and yes, this is still an issue.

Why don't use a simple constructor to initialise uuid ?
    public function __construct()
    {
        $this->uuid = Uuid::uuid4();
    }

@alebec Have you tried using the constructor for this in a production system, and what would the possible downsides be compared to using a subscriber?

The proposed solution seems correct to me (although I had to explicitly do new UuidGenerator() rather than injecting it because of argument "$uuidGenerator" of method "__construct()" references class "Ramsey\Uuid\Doctrine\UuidGenerator" but no such service exists, probably due to some changes in the lib).
Nevertheless, as mentionned by @alebec, one could directly use Uuid::uuid4(); because this is basically all the generator does. This makes the generator quite useless in this particular case, so I think the doc should reflect that and redirect to ramsey/uuid instead with a prePersist ready-to-use example.
@ramsey If this seems fine by you, I am ready to pull-request this documentation change
As for @pluk77 question whether using the constructor rather than the event listener/subscriber system, I have no answer for this now but I would feel more comfortable with a prePersist listener.

@Arnaud-J, please feel free to open a PR. Thanks!


0.72.0-rc.0

Text Message is broken in insert field...

The Bug is in current RC Version too ... my misstake :(


Broken : JS Code in Head Master is Broken

Refer to image.......

The top of my git log is shown below:
commit 692014d8c2691351751c3921b99a92f99acca3f9
Merge: 459ec4c 3846abc
Author: Maxime Beauchemin<EMAIL_ADDRESS>Date:   Fri Jan 15 10:12:11 2016 -0800

    Merge pull request #879 from thibault-ketterer/readme_update

    Readme update

commit 3846abcb038e3743f9004b05dd9f359b329c4723
Author: thibault ketterer<EMAIL_ADDRESS>Date:   Fri Jan 15 17:11:04 2016 +0100

    [readme] rename link

Hmn.. it looks like the issue is related to minified JS files not being found..

What's your flask-admin version? Share the output of pip freeze | grep -i flask

Hmn.. I installed using python setup.py install, so pip freeze does not show the version.

That admin/admin thing look bad. Plugins messing up your blueprints? If you have plugins can you try turning them off temporarily?

I don't use plugins.. don't actually know what they are.
Also, the admin/admin paths are the same on our current production machine, which work fine.

It looks like some of the JS is available, but some are missing.
On the main DAG overview page for example, I see the following as either available or missing:
Available

/admin/admin/vendor/select2/select2.min.js
/admin/admin/bootstrap/bootstrap3/js/bootstrap.min.js
/static/jqClock.min.js
/admin/admin/vendor/bootstrap-daterangepicker/daterangepicker.js?v=1.3.22
/admin/admin/admin/js/form.js?v=1.0.0
/static/d3.v3.min.js

Missing (404)

/admin/admin/vendor/jquery-2.1.1.min.js
/admin/admin/vendor/moment-2.8.4.min.js

This might also be related https://github.com/airbnb/airflow/issues/726

@r39132 did you ever find a solution to this ... just upgraded to the airbnb_prod branch and now facing the same issue.

Do a clean install of flask_admin,
pip unsintall flask_admin
pip install flask_admin==1.4.0

no dice

@mistercrunch @r39132
Just did a clean install of airbnb_prod.<IP_ADDRESS> and got the same issue.
FYI I was running airbnb_prod.<IP_ADDRESS> before.

What's your flask_admin version?
pip freeze | grep -i admin

you may need a sudo pip uninstall flask_admin

(airflow) [airflow@usw2dbdpag01 ~]$ pip freeze | grep -i admin
Flask-Admin==1.4.0
(airflow) [airflow@usw2dbdpag01 ~]$

Are you in a virtualenv? If so nuke it and make a new one maybe.

did that ... multiple times ... also tried master same issue ... reverting to <IP_ADDRESS> fixes it ... ill keep working on it in the morning. is jquery installed by flask-admin ?

Yeah flask-admin ships with jquery and we piggyback on it

maybe grep your whole box for jquery-2.1.1.min.js to see where that is coming from

@mistercrunch found the problem ... isolating the root cause ... need to install on a new environment to make sure that it's not caused by artifacts on my system .. but i doubt it since it's isolated in a virtualenv. Details to follow shortly .. got to get to work.

@mistercrunch got it ... post mortem and PR coming today .. I really need to leave for work now :)

@mistercrunch got a few issues to deal with ... so not sure if I'll get around to submitting a proper fix today. It looks like the cleanup step in setup.py is not working and a file which was removed from the repo at some point (airflow/www/templates/admin/base.html) is remaining in the build directory which is not being deleted and then being installed even though it's no longer in the repo.
A clean repo, clearing the build artifacts,  or removing that file from the installation solves the issue. Maybe you could have a step at the beginning of setup.py that deletes existing build artifacts.
(airflow) [airflow@usw2dbdpag02 airflow]$ git status
On branch gd_prod_<IP_ADDRESS>
nothing to commit (working directory clean)
(airflow) [airflow@usw2dbdpag02 airflow]$ ls -lha airflow/www/templates/admin/
total 12K
drwxr-xr-x. 2 airflow airflow 4.0K Feb 25 23:33 .
drwxr-xr-x. 4 airflow airflow 4.0K Feb 25 23:33 ..
-rw-r--r--. 1 airflow airflow 2.5K Feb 25 23:33 master.html
(airflow) [airflow@usw2dbdpag02 airflow]$ ls -lha build/lib/airflow/www/templates/admin/
total 16K
drwxr-xr-x. 2 airflow airflow 4.0K Feb 25 23:33 .
drwxr-xr-x. 4 airflow airflow 4.0K Feb 25 23:04 ..
-rw-r--r--. 1 airflow airflow 3.8K Feb 25 23:04 base.html
-rw-r--r--. 1 airflow airflow 2.5K Feb 25 23:33 master.html
I've noticed the build artifacts not getting deleted on both my servers and my mac.

making sure you clean on install also does the trick.
python setup.py clean extra_clean install

@r39132 I believe this will also solve the issue for you


Add mobileNumber() method for nb_NO

Added $faker->mobileNumber for Norwegian mobile phone numbers.
Included tests for the method, and added docs to the readme.md about this. Tests are currently passing.

Thank you, @carestad and @pimjansen!


Colab error: OSError: data/hi-transformer does not appear to have a file named config.json. Checkout 'https://huggingface.co/data/hi-transformer/main'

Traceback (most recent call last):
File "/content/hi-transformers/language_modelling/run_mlm.py", line 626, in
main()
File "/content/hi-transformers/language_modelling/run_mlm.py", line 335, in main
config = HATConfig.from_pretrained(model_args.config_name, **config_kwargs)
File "/usr/local/lib/python3.10/dist-packages/transformers/configuration_utils.py", line 590, in from_pretrained
config_dict, kwargs = cls.get_config_dict(pretrained_model_name_or_path, **kwargs)
File "/usr/local/lib/python3.10/dist-packages/transformers/configuration_utils.py", line 617, in get_config_dict
config_dict, kwargs = cls._get_config_dict(pretrained_model_name_or_path, **kwargs)
File "/usr/local/lib/python3.10/dist-packages/transformers/configuration_utils.py", line 672, in _get_config_dict
resolved_config_file = cached_file(
File "/usr/local/lib/python3.10/dist-packages/transformers/utils/hub.py", line 388, in cached_file
raise EnvironmentError(
OSError: data/hi-transformer does not appear to have a file named config.json. Checkout 'https://huggingface.co/data/hi-transformer/main'

I would love to try your code, but it is just not working.  Try the Colab notebook yourself: https://colab.research.google.com/drive/15feh49wqBshgkcvbO6QypvJoa3dG6P5S?usp=sharing
I just keep getting errors.

Hi @Tylersuard,
There were some minor bugs due to the major renaming from hi-tranformer to hat before the release. Now, things should work fine.
Consider this Colab example: https://colab.research.google.com/drive/15feh49wqBshgkcvbO6QypvJoa3dG6P5S?usp=sharing
I couldn't install torch_xla for TPU support in the Colab environments with python 3.9, so I worked with a GPU env.
At the moment, training a model from scratch (config) is not possible, so consider warm-starting a model from a BERT or RoBERTa checkpoint.
python models/hat/convert_roberta_to_htf.py --layout p1 --max_sentences 32
!python models/hat/convert_bert_to_htf.py --layout p1 --max_sentences 32

If it's important for you to start from scratch, consider initializing a BERT/RoBERTa from scratch, and then use it as a "fake" warm-start model.


Merge faisalman 0.7.33 and bump to 0.7.33

What I did
I am merging the 0.7.33 tag of the faisalman repo to the master branch of the amplitude repo
git remote add real git@github.com:faisalman/ua-parser-js.git
git fetch real
git pull real 0.7.33

To help resolve conflicts, I linted copies of https://github.com/faisalman/ua-parser-js/blob/0.7.33/src/ua-parser.js and https://github.com/amplitude/ua-parser-js/blob/master/src/ua-parser.js and then produced a diff: https://github.com/kevinyou/demo-ua-parser-comparison/blob/main/diff.diff . These include any changes to source code, including the security vulnerability and slight user agent tweaks.
Then I ran
npm run test-ci

and fixed lint and test issues (copied the device-test.json file)
Then I ran npm run build

@yuhao900914 Looks like it's been approved. Could we get this merged?


Adding hobby field

Hobby is a many to many field inside the user class.
Every user can choose a number of hobbies when signing up.
The hobbies are used to match between an apartment owner and seeker.
Also updated .gitignore to include macOS directory config files.
Fixes #46

I'm not sure whether we should push the migration files, as we will definitely have a conflict when we'll try to merge our PRs.
Maybe we should exclude them from our PRs and instead run the migrate command after we pull from upstream?

The only migrations you really need to share are the ones you do manually to add data to the system. This is done for either testing, or to populate tables with data that the application expects to be there.
All the other ones can probably be added to the vagrantfile so that it automatically does makemigrations and migrate when the system comes up.

LGTM

@simzacks should we add the migration folders to the .gitignore and add makemigrations to the bootstrap.sh?

I think adding the migration files to the .gitignore would be a great idea. With one caveat. There are some migration files that are manually created. For example, when you add test data to the system, or preload data (such as lookup information) in.
So those would have to be included in any case.

@nadavsu Please add Omer and Or as reviewers.
Good job with the hobbies model! watch for the migration files as @Micha546 said :)

LGTM, note that user migration files are in the repo (and the PR).

LGTM, note that user migration files are in the repo (and the PR).

Yep. Added an issue and will soon submit a new PR closing it.


Remember keys in rememberSaveableBackStack

Updates rememberSaveableBackStack to use use the initial root screen(s) as keys.
Before this, you could never get a new backstack when using rememberSaveableBackStack. This blocks using navigable Circuits within views that may have their root screen change, such as a ComposeView in a RecyclerView or other XML layout that has data being rebound.
This includes a small test suite to cover both remember cases and NavigableCircuitContent.

@ZacSweers will need another auto-merge approval, had to run the formatter


node-gyp causing errors

The node-gyp build process is causing errors on windows and linux.

See #30735


Open an existing project --- Without a Solution...

(Happy Holidays).... I would have thought this easy, but hours in, and no success...

Thank you, and happy holidays to you too!

I would have thought this easy,

I think that's the way it is ~
var xp = new XProject("project file");

// ... do something
xp.GetProjectReferences().Count();

But for another powerful loading/managing take a look at IEnvironment -> IXProjectEnv; Here's old note

Thanks... When i was "doing the crazy" of finding a solution that contained the project, then opening the solution, then selecting the project.... I was able to load a specific configuration... I do not see how to do that for a direct XPRoject constructor call...
OLD Code (for laughing)
                   List<net.r_eg.MvsSln.Core.ProjectItemCfg> proj = data.ProjectItemsConfigs.Where(p =>                     (p.project.fullPath.ToLower() == projInfo.FullPath.ToLower()) &&                     (p.projectConfig.Configuration.ToLower() == desiredConfiguration.ToLower()) && (p.projectConfig.Platform == desiredPlatform)                     ).ToList();                     if (proj.Count == 0)                     {                         SimpleLogger.WriteLine("Project Load Failure for Configuration");                         return null;                     }                     if (proj.Count > 1)                     {                         SimpleLogger.WriteLine("Project Load Ambigious for Configuration");                         return null;                     }                     data.Env.LoadProjects(new[] { proj[0] });                     net.r_eg.MvsSln.Core.IXProject targetProject = data.Env.Projects.First();

Thanks... When i was "doing the crazy" of finding a solution that contained the project, then opening the solution, then selecting the project.... I was able to load a specific configuration... I do not see how to do that for a direct XPRoject constructor call...
OLD Code (for laughing)
                   List<net.r_eg.MvsSln.Core.ProjectItemCfg> proj = data.ProjectItemsConfigs.Where(p =>                     (p.project.fullPath.ToLower() == projInfo.FullPath.ToLower()) &&                     (p.projectConfig.Configuration.ToLower() == desiredConfiguration.ToLower()) && (p.projectConfig.Platform == desiredPlatform)                     ).ToList();                     if (proj.Count == 0)                     {                         SimpleLogger.WriteLine("Project Load Failure for Configuration");                         return null;                     }                     if (proj.Count > 1)                     {                         SimpleLogger.WriteLine("Project Load Ambigious for Configuration");                         return null;                     }                     data.Env.LoadProjects(new[] { proj[0] });                     net.r_eg.MvsSln.Core.IXProject targetProject = data.Env.Projects.First();

Not even sure what are you trying here :)
Environment implementations contains various loaders of the each project instances. This is manger where you can simply manage project collections through its single entity (the default implementations are IsolatedEnv/XProjectEnv).
For other cases you can use XProject or direct implementations (msbuild or future IeXod)

Not even sure what are you trying here :)
Environment implementations contains various loaders of the each project instances. This is manger where you can simply manage project collections through its single entity (the default implementations are IsolatedEnv/XProjectEnv).
For other cases you can use XProject or direct implementations (msbuild or future IeXod)


fix: (flutterfire_ui documentation folder name) rename the documentation folder name to 'docs'

Description
Rename The flutterfire_ui documentation folder to 'docs'. This fixes the links to the documentation in the package's readme file.
Related Issues
Fixes #8628
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process. Updating the pubspec.yaml and changelogs is not required.

[*] I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
[NA] My PR includes unit or integration tests for all changed/updated/fixed behaviors (See [Contributor Guide]).
[NA] All existing and new tests are passing.
[NA] I updated/added relevant documentation (doc comments with ///).
[NA] The analyzer (melos run analyze) does not report any problems on my PR.
[*] I read and followed the [Flutter Style Guide].
[*] I signed the [CLA].
[*] I am willing to follow-up on review comments in a timely manner.

Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?

[ ] Yes, this is a breaking change.
[*] No, this is not a breaking change.

Should we fix the README instead? The Dart docs say the docs directory should be called 'doc/'.

Should we fix the README instead? The Dart docs say the docs directory should be called 'doc/'.

Thanks for the input @kevinthecheung. I wasn't aware of that. I will close this PR and open a new one with the  README fixed.


Refactor error types or introduce new class

Which package/s are you suggesting this feature for?
types
Is your feature request related to a problem? Please describe
For TFChain not all errors are handled, we can't sync the changes of the chain errors.
many tfchain errors got thrown as generic tfchain error
Describe the solution you'd like
we should have an error class that have module name and error name props, and can be passed the contractor

Issue update
Work done

Created a new Error wrapper to throw errors based on their type.
Determined the type of error and threw it accordingly.
Updated the error interface to differentiate between Module, Token, and other error types.
Remove the TFChain error from the types package.


Fortify Scan - Path Manipulation at portal/vendor/vlucas/phpdotenv/src/Loader.php, line 163

Hi,
Thanks a lot for the library, it's verify helpful. This library has come along with the laravel package for us. So we use the Fortify Scan to identify possible vulnerabilities. We have received a vulnerability in this package, the details of which are mentioned below -

Allowing user input to control paths used in file system operations could enable an attacker to access or modify otherwise protected system resources.

At line 163 in file portal/vendor/vlucas/phpdotenv/src/Loader.php,  we have a function -
protected function readLinesFromFile($filePath){ //some code }. According to the Fortify Scan it would be better if we validate $filePath variable, before performing any sort of file operations. This variable $filePath is also passed in the constructor when the Loader Class is called.
If we could have a way to validate $filePath before it is passed to the other functions of the file, it would help us close this vulnerability. Hence requesting you to llok into the same.

There is no vulnerability here. The file path should not ever be user provided it. If for some reason you need that, you should validate it yourself.
There is nothing we should do to validate it, since as far as we're concerned, all paths are valid.


Add batch-index support for histograms

Hi @KSauter,
Thanks for the contribution. What kind of testing have you done for these changes?

Hi @dwelch-spike ,
i have it running on ~20 servers since beginning of May with different Aerospike versions.
I did not find any tests in this repository that I could extend for this case.


Replace homegrown benchmark CI runner with codspeed

Shotover has always had a homegrown system for reporting benchmark regressions in CI.
For every PR: It runs the benchmarks for the main branch, then runs the benchmarks for the PRs branch, then compares the results, reporting any large difference in results.
It then posts the analysis in a comment like this https://github.com/shotover/shotover-proxy/pull/1495#issuecomment-1958780353
However, the UX has been lacking:

Have to sift through noisy criterion logs to find results
Only comments when it detects a regression/improvement, this means the system not running and the system saying :+1: are indistinguishable.

And maintaining it has been a pain.
In fact, right now the system is silently broken after an update to one of our github actions dependencies.
Recently various services that will manage all of this for us has appeared.
The most promising looking is https://codspeed.io
Here I've enabled it in a test repo https://github.com/rukai/shotover-proxy/pull/1
It posts a comment that links to https://codspeed.io/rukai/shotover-proxy/branches/codspeed_pr which presents all the results really nicely.
It claims to significantly reduce benchmark noise, but its not clear how exactly they are achieving it.
From the results on the page I linked, it does look like the results are largely noise free!
The page also allows inspecting a flamegraph of each benchmark which is impressive and will be quite handy.
One downside is that we need to use a fork of criterion to enable codspeed.
But if we decide codspeed is not right for us then we can really easy revert back if needed, since codspeed does not change the API at all in its criterion fork.
So I propose we replace our homegrown system with codspeed, which this PR implements.

I'm generally a fan of adopting an external service / capability for something that is not core to the project that brings in a net win in development velocity. Sounds like we also have an easy out if it's not living up to its promises.
Do you have an example (artificial or not) of what a real regression looks like (e.g. throwing a sleep into that example PR)?
+1

well that was enlightening, I added a 1s sleep and they claim it did not regress performance, there is a -8% decrease to that bench but I expected something in the order of -1000% https://github.com/rukai/shotover-proxy/pull/2
It would seem they are doing some kind of instruction counting and thats why the sleep is largely ignored.
This is not ideal but its also acceptable and realistic, if you are going to measure microbenchmark performance on a noisy CI cloud machine you will need to pull some tricks like that.

Adding a more realistic regression with a .clone() is caught:
https://github.com/rukai/shotover-proxy/pull/3
This flamegraph diff of the bench shows exactly were the regression was introduced:

So cool!


TypeError: Cannot read property 'findNode' of undefined

First off, thanks for creating this plugin, the lack of this support has been one of the biggest issues with implementing Gridsome with new projects.
After installing the plugin and adding it in the config, I'm currently getting the following error when running gridsome develop (v 0.7.13):
TypeError: Cannot read property 'findNode' of undefined
    at ImageDownloader.getFieldType (\node_modules\@noxify\gridsome-plugin-remote-image\gridsome.server.js:138:37)
    at ImageDownloader.api.loadSource (\node_modules\@noxify\gridsome-plugin-remote-image\gridsome.server.js:32:36)
    at Plugins.run (\node_modules\gridsome\lib\app\Plugins.js:141:17)
    at process._tickCallback (internal/process/next_tick.js:68:7)

I'm using Strapi as my data source, but I'm not sure if I understand the naming convention correctly. Shouldn't typeName be my collection (Strapi) and the sourceField where the image url is located?
  plugins: [
    {
      use: "gridsome-source-strapi",
      options: {
        contentTypes: [
          "teams"
        ]
      }
    },
    {
      use: "@noxify/gridsome-plugin-remote-image",
      options: {
        typeName: "Strapi",
        sourceField: "teams.edges.node.fields.photo_250x250.url",
        targetField: "imageDownloaded",
        targetPath: "./src/assets/remoteImages"
      }
    }

Hi @havardl,
thanks for reporting.
It seems, that the current implementation via api.loadSource is not the best one,
because loading the data from a remote source needs some time.
Since the loadSource methods is called via Promise ( if I'm not wrong ), they're run in parallel.
Currently we have no solution for this, sorry.

@noxify The most recent release of Gridsome (v0.7.15) adds support for a promise-style onBootstrap hook, which may be better for this sort of operation. It also runs after loadSource and onCreateNode, so the internal store will have all the data needed.

Thanks for the hint :) did they released a new version (0.7.15)?

https://www.npmjs.com/package/gridsome/v/0.7.15

@thetre97 thanks for the link - i have blocked some time today to test it :)

Hey @thetre97,
i tried to get it running with onBootstrap but it seems I'm too stupid for this...
What is working
Running a  console.log via api.onBootstrap prints the log at the expected place
Example:
Initializing plugins...
Load sources - 0.33s
Create GraphQL schema - 0.05s
Create pages and templates - 0.05s
Generate temporary code - 0.06s
### Console log via onBootstrap

Calling the GraphQL to check if the defined field exists in the collection
To test this behavior ( or the bug? ), I use Contenful as data source.
My initial test failed with the described error message in the initial post from @havardl .
With the onBootstrap "implementation", everything works as expected for this step.
What is not working
Creating a new Schema Type <-- Here I need some help
Since we're in the "hook" logic, it's not possible to run a command which extends the GraphQL.
Please find below my steps to reproduce.
Not tested
Updating the nodes
Since I wasn't able to add a new schema type to the GraphQL, i didn't invest some time to check this.

Steps to reproduce
To test it locally:

Create a new gridsome page via gridsome create remote_downloader
Install and configure a source plugin and if needed, also the remark-transformer plugin
Run cd remote_downloader to change the directory
Create a new directory with the name packages
Run cd packages
Run git clone https://github.com/noxify/gridsome-plugin-remote-image imageDownloader
Run cd imageDownloader
Run npm install

After this 8 steps you have to overwrite the packages/imageDownloader/gridsome.server.js with the following content: https://gist.github.com/noxify/7f3085b400991535ef997dedaacf2b1d

Note: The code from the gist includes only the parts which are needed to show what's not working - it doesn't download an image or something else!

In the /gridsome.config.js you have to define the plugin like this:
 {
      use: '~/packages/imageDownloader',
      options: {
        'typeName' : 'ContentfulAsset',
        'sourceField': 'file.url',
        'targetField': 'imageDownloaded',
        'targetPath': './src/assets/remoteImages'
      }
 }

With the code from the gist, it doesn't matter which source plugin you're using.

@noxify Ah yes, that's true - I hadn't thought about that.
I guess in theory you would need to have multiple stages:

Gridsome already includes an Image schema type, so shouldn't be any need to add that.
Use onCreateNode to check if a node matches the target typeName, if so edit it to add an Image relation under another field (i.e. localImage, and 'optimistically' add the local image path, assuming it the filename will be the same as the remote url filename. E.g. { file: { url: 'https://example.com/image.jpg', localImage: { type: 'Image', path: './src/assets/remoteImages/image.jpg''} } } (psuedo code)
When it gets to onBootstrap, get the target field type, loop through it and download & save using the target url & local path.

Don't know whether that actually makes it more complicated though 🤔😏

Hi @thetre97
thanks for the fast feedback.

Gridsome already includes an Image schema type, so shouldn't be any need to add that.

The new field type is needed in case, that if the source field is an array, the target field has to be an array, too.
Since it seems not possible to use [Image] directly in the target field definition, I use addSchemaType to create a new type Images, which has image: [Image] as definition.

Use onCreateNode to check if a node matches the target typeName, if so edit it to add an Image relation under another field...

This could work - I have to verify it.

When it gets to onBootstrap, get the target field type, loop through it and download & save using the target url & local path.

Maybe we should download the remote images inside onCreateNode - Because if the download wasn't successful, we should set the value from the target field to null.

Don't know whether that actually makes it more complicated though

Maybe :)  but if it's working with remote source we can generate a benefit for the community.
Refactoring it later should not be the problem. If I'm not wrong, there are some plans to extend the hook system in the next gridsome versions.

here the result from my first tests with api.onCreateNode() and api.createSchema().
Initializing plugins...
### Run Create Node
### Run Create Node
### Run Create Node
### Run Create Node
### Run Create Node
### Run Create Node
Load sources - 0.31s
### Run Create Schema
Create GraphQL schema - 0.05s

I hope i can continue this week.

Hey @thetre97
i think I got it.
With the following code ( https://gist.github.com/noxify/7f3085b400991535ef997dedaacf2b1d ), it seems to work as expected.
Next steps are to activate the image downloader.
Thanks a lot for all the hints <3
What is currently working:

Adding the new schema type Images
Adding the defined target field to the collection schema
Updating the collection nodes
GraphQL converts the path to a valid image

Hey @dsturm @havardl @havardl
I have created a new branch with all changes:
https://github.com/noxify/gridsome-plugin-remote-image/tree/fix/findNodes
Please feel free to test and check that everything is working.
My test with the contenful source was successful, but to make sure there is no hidden breaking change, it would be good if someone else could test it, too.

Great - nice work. I'll give it a try this w/e...

fixed with https://github.com/noxify/gridsome-plugin-remote-image/releases/tag/v1.1.0

Is not fixed for me ;) https://github.com/nevercodealone/strapi-rolandgolla.de/pull/new/feature/remoteImage

Hey @rogoit
it seems there is no source defined in your https://github.com/nevercodealone/strapi-rolandgolla.de/blob/feature/remoteImage/gridsome/gridsome.config.js

Maybe I can fix the docs with your next answer ;) https://webstone.info/documentation/gridsome-plugin-remote-image/

I do not find anywhere an example for the right configuration...do you have a link? @noxify

What exactly is your problem?
The main problem yesterday was that there was no source plugin defined.
Did you add a source plugin to your project and configured it correctly in your gridsome.config.js?

Hi, maybe i am not the best on JS. But i installed the plugin and add the setting to my config as you see in the link. You tell me something from a source. But I did not find any example of a property source.
So i sent you my example code. But I do not know what I have to do now. Thx for your answer and passion by the way ;)

Add the error comes up with installation and setting. The error from the topic here. On actual master everything is fine

@rogoit - ping mich am besten per Discord mal an :)
User ID: Marcus from JammeryHQ#3715


Limit number of files to be uploaded

I need some help please. How can we limit the number of files to be uploaded?
Thanks

Hey there - good question!
Right now, the library does not provide an out of the box solution to do this. But, I've created a jsfiddle for you to demonstrate how to make this work. It's a bit rudimentary, but it gets the job done and should provide you the feature you were looking for. Basically, we make use of the imageSelected event hook to let us know when the selecting action has taken place. Then we use the fileLimit variable to prune our image thumbnails and cachedFileArray accordingly.
Make sure to set the multiple option in your HTML on the input, and to pass true as the second parameter in the library initialization (to allow multiple thumbnails in the preview pane). Also, a caveat is that we need to use a short setTimeout to wait for the image thumbnails to display. This causes a small flash-of-content, but I think will be ok for your needs at the moment.
We are planning a little bit of a rewrite to this library in the coming weeks - mainly to allow an option object to be passed in to the initialization, so we can provide a bit more customization and some cleaner code. Until then, this should hold those over looking to limit file uploads.
Here's the jsfiddle
Below is the js code in the fiddle:
// Initialize
var upload = new FileUploadWithPreview('myFirstImage', true)

// Set file limit
var fileLimit = 3

// Register for the change event on the input
upload.imageSelected = function(event) {

  // If we haven't selected more than your limit, let's exit here
	if (upload.cachedFileArray.length < fileLimit) {
		return
  }

  // Splice the real cachedFileArray with your file limit
  upload.cachedFileArray = upload.cachedFileArray.splice(0, fileLimit)

  // Must set a small timeout because the thumbnails take some time to be drawn.
  window.setTimeout(function() {

    // Grab all the image thumbnails
    var imageThumbnails = document.querySelectorAll('.custom-file-container__image-multi-preview')

    // Loop through them, removing them from the dom if they're over the limit
    for (var x = 0; x < imageThumbnails.length; x++) {
      if (x > (fileLimit - 1)) {
        imageThumbnails[x].remove()
      }
    }

    // Make sure to update our input count
    upload.inputLabel.innerHTML = upload.cachedFileArray.length + ' files selected';

    // Here you'll see the cachedFileArray contains the correct number of images
    console.log(upload.cachedFileArray)
  }, 500)

};

Let us know if that works for you.

Closing for now - let us know how it goes!


"Developer Tools" dissapeared

I can't turn on developers tools any more. Neither from the menu, nor from the preference page.
Help? I really need developer tools. I have no idea how to get them back. I see stock "electron" showing them, so we must have broken something.
Also:
remove developer tools from the "preference page" it's ok to have that functionality available from the menu only.

This was related to --disable-seccomp-filter-sandbox argument that needs to be passed to chromium.
Seems like something on my Linux box got upgraded to a point where this didn't work any more, so I have to pass this to electron in order for things to work.
See:
https://chromium.googlesource.com/chromium/src/+/0e94f26e8/docs/linux_sandboxing.md


Implement contains method in SlackResponse

Description
It's cool that SlackResponse instance looks like a dictionary and supports getting values by key or get() method, but it always returns False when you try to check the existence of keys in the response, e.g. "error" in response.
What type of issue is this? (place an x in one of the [ ])

[ ] bug
[x] enhancement (feature request)
[ ] question
[ ] documentation related
[ ] testing related
[ ] discussion

Requirements (place an x in each of the [ ])

[x] I've read and understood the Contributing guidelines and have done my best effort to follow them.
[x] I've read and agree to the Code of Conduct.
[x] I've searched for any related issues and avoided creating a duplicate issue.

Reproducible in:
slackclient version: 2.3.1
python version: 3.7.1
Steps to reproduce:
from slack import WebClient
client = WebClient(token)
response = client.team_info()
print("ok" in response)  # False

Expected result:
True
Actual result:
False

Thanks for the suggestion! This looks like a nice idea to me.

I came to think we should not implement __contains__ using data at the top level. You can do the same by key in response.data. Doing this way is also simple enough so that let me close this issue without implementing a bit tricky dunder method. see also: https://github.com/slackapi/python-slackclient/pull/663


MCHECKSTYLE-297: Add licenses stanza

This allows license compliance tools like VersionEye to categorize
dependencies.

VersionEye is no license compliance tools apart from that if versionEye can't correctly handle the inheritance in Maven POM files, cause it sheds many informations which are done by inheritance.


feat(rhineng-8063): expanded row behavior and more mock data variety

The behavior of row expanded should be the same as in cluster details.
To test:
Try switching expanded rows on and off and apply filters. The expanded row should stay expanded if it is shown in the filtered results

:tada: This PR is included in version 1.38.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Move TMS restli related code out of open source.

Add skeleton for a generalized DAO framework.

Coverage remained the same at 0.0% when pulling a458685c15c6a09039a37df27cb1e0f9a2c0c5c0 on mars-lan:dao into 14e2b7b8ff66990a3a4fbb33c0ecdf28f6ac2abe on linkedin:linkedin.


Add crit stage logic to affliction

Increment/Decrement 2 stages if crit fail/success
Skip createStageMessage on create if onset present

https://github.com/foundryvtt/pf2e/assets/6688366/42b4e817-9e1a-40f3-bd92-454f7bacbeda


[cxx-interop] Add CxxSet protocol for std::set ergonomics

This adds a protocol to the C++ standard library overlay which will improve the ergonomics of std::set, std::unordered_set and std::multiset when used from Swift code.
As of now, CxxSet adds a contains function to C++ sets.
C++ stdlib set types are automatically conformed to CxxSet: std::set, unordered_set, std::multiset. Custom user types are not conformed to CxxSet automatically: while a custom type might have an interface similar to std::set, the semantics might differ, and adding a conformance would cause confusion.

I think we should also extend this to provide a conversion mechanism from Swift set to a C++ set.
I'd like to make it a separate change though.

@swift-ci please smoke test

@swift-ci please smoke test

@swift-ci please smoke test Linux


Could you share your instances_trainval35k.json.zip file ?

here they are on S3: https://s3.amazonaws.com/amdegroot-datasets/instances_trainval35k.json.zip
We also have created a script to form the trainval35k dataset for you on the COCO branch.  We hope to merge these into master soon
https://github.com/amdegroot/ssd.pytorch/blob/coco/data/scripts/COCO2014.sh

Sorry @ellisbrown , I knew this S3 link before adding the issue. Unfortunately, I got 'access denied' response when using the command line
curl -LO  https://s3.amazonaws.com/amdegroot-datasets/instances_trainval35k.json.zip
The file I got is:
<?xml version="1.0" encoding="UTF-8"?> <Error>AccessDenied<Message>Access Denied</Message><RequestId>A4DF808B97BA75E5</RequestId><HostId>L88xkRSVyyagBYgVHKb860AkBPFdH1RcYZK1kfOaJWILmVe3YLeFEUyU9v6xPvbiOuL05yJUUUo=</HostId></Error>

Sorry about that, I still need to make the bucket public.
This link should work.  It's the same annotations, just taken from Ross Girshick's py-faster-rcnn repo, which is where I pulled ours from.


Add Tekton Pipelines extension to Telemetry section

Signed-off-by: Sudhir Verma<EMAIL_ADDRESS>

Thanks @sudhirverma


Well, sure, but it still seems like a bug. I guess it doesn't really freeze the shell, though.

Is it repeats with 1.11+?


Update pyruter to 1.1.0 to be able to reuse aiohttp session.

Description:
This updates pyruter to be able to reuse the aiohttp session as discussed in the comments here https://github.com/home-assistant/home-assistant/pull/18237#discussion_r231397156
Related issue (if applicable): fixes #
Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#<home-assistant.io PR number goes here>
Example entry for configuration.yaml (if applicable):
sensor:
  platform: ruter
  stop_id: 2190400

Checklist:

[x] The code change is tested and works locally.
[ ] Local tests pass with tox. Your PR cannot be merged unless tests pass
[x] There is no commented out code in this PR.

If user exposed functionality or configuration variables are added/changed:

[ ] Documentation added/updated in home-assistant.io

If the code communicates with devices, web services, or third-party tools:

[ ] New dependencies have been added to the REQUIREMENTS variable (example).
[ ] New dependencies are only imported inside functions that use them (example).
[x] New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
[ ] New files were added to .coveragerc.

If the code does not interact with devices:

[ ] Tests have been added to verify that the new code works.

Can be merged when build passes.


Update search results in error 80244008

Windows XP Professional x86 SP3, Dell Inspiron 5100. i was able to install updates initially but after a restart, it refuses to check. I believe the error has something to do with WSUS, but reinstalling legacy update did not fix it.

I have also been experiencing this on my Dell Dimension 8300 with XP Professional x86 SP3. At first I thought it was because I had installed Office XP but the issue persists even after a complete reinstall of XP.

seems as if the issue has resolved itself. potentially a problem on legacy update's side.

It most likely was because my server ran out of space. Fixed now, sorry that happened. Made some space earlier and will clean up further over the next few days so it hopefully won’t happen again.

hi ^^
i have the same issue on a VM i did a while back and i just installed Legacy Update and it got me this error. Tho i have the update pop-up in systray for updates that still work (it install them and all)


pylint now passes perfectly

pylint fails if a function has over 32 arguments. The function praw.models.reddit.subreddit._create_or_update() had 34, so pylint gave it a fail and caused pre_push.py to exit with code 1. Solution: disable to too-many-arguments check on this function with # pylint: disable=too-many-arguments
the praw.objector file has a couple of functions which use "return" instead of "return None", which again makes pylint fail when there are inconsistent return types. I've updated "return" statements to "return None"
pre_push.py now exits with code 0 (build completely successful).

Coveralls check is failing here. Seems you fixed the praw.objector file in the latest push 3 days ago and I was looking at the previous push. However I prefer my solution - what do you think?

Thanks for this! I've been meaning to fix these errors for a while.

As for the coverage, @bboe's solution maintains coverage because the last line gets executed, while your fails because it doesn't. Personally, I agree that it's not as nice to define a retval and then return it, instead of just returning straight away.

Hmm the unreachable code seems to be a result of both of the previous pushes merging together. Perhaps that was my fault - I mentioned in my last contribution that this is my first experience with git/syncing etc.
Try now

Thanks for the fix. pre_push.py now exits with 0.
About the return None: to get coverage to pass you could either revert to @bboe's solution (which might not be pretty but it works), or write a test that would evaluate that line.
Thanks for your hard work.

Thanks for the contribution. The retval approach is needed because there isn't any way to get through that function without it matching. That said, perhaps a hash table, instead of a loop would be better in that case. Hmm.


More work on self hosted compiler

I believe I am pretty close to making the self-hosted compiler compile itself.

Something weird happens with booleans on Windows if optimizations are enabled when compiling the self-hosted compiler. It ends up getting a boolean foo that behaves so that foo as int evaluates to 255, not 0 or 1 as expected. Also, if ... or foo does not run when this happens.
This will take a while to minimize into something small, so I can make a bug report / question to LLVM. It is difficult, because the self-hosted compiler is creating bool 255, and it is a lot of code.

I believe I am pretty close to making the self-hosted compiler compile itself.

Yay!!


GO:0070937 CRD-mediated mRNA stability complex

Please add the following amendments:

Def:
A protein complex that binds to, and promotes stabilization of, mRNA molecules containing the coding region instability determinant (CRD). In human, IGF2BP1 and at least four additional proteins: HNRNPU, SYNCRIP, YBX1, and DHX9.

Def:
A protein complex that binds to, and promotes stabilization of, mRNA molecules containing the coding region instability determinant (CRD). In human, it may consist of IGF2BP1, HNRNPU, SYNCRIP/HNRNPQ, YBX1, and DHX9.

Rational: many mRNA transcripts have a CRD but the binding complexes have not been identified for all so may differ. See #13170 for an alternative complex on a the related major CRD.
Synonyms:
coding-region determinant of instability-mediated mRNA stability complex [EXACT]
coding-region instability determinant -mediated mRNA stability complex [EXACT]
Rational: They can't decide whether they call it "determinant of instability" or "instability determinant"!
Thanks,
Birgit

oops; @pgaudet,  I did this with another related ticket. Sorry

I added the syns but changed the def back because there are 22 non IEA annotations in quickgo that may need to be looked at to see if proposed def renders any of them incorrect.

I would have thought the new def makes it more generic, not narrower.

Still, we need to check when changing a def. Many are ISS based on a GO_Ref, ; 5 are IDAs;
I am attaching the file if you want to look; But they are to the proteins you mention, so most likely this will be fine. I'll push this tomorrow when I feel more comfortable.
gene_association.goa.txt

CSDE1 is the one I will check, as it's not one of  IGF2BP1, HNRNPU, SYNCRIP/HNRNPQ, YBX1, or DHX9.

I thinking that the annotation for CSDE1 using PMID:15314026 might actually be a binding annotation to mCRD GO:0106002, and not suggesting it is a member with a cc annotation. It's more likely a complex binding annotation with mCRD (GO term) as input. The def change will not effect my concerns about that. So I will go ahead and change the wording of the def as you suggest.

Thanks, Harold.

Done; closed

NB: CSDE1 is part of the related mCRD~ complex so yes, it probably is just an interactor with the CRD dep on circumstances :)