Ecto.Preloader.do_preload ignores internal stack trace leading to odd error msg

Hi,
Elixir: 1.0.4
Ecto: 1.0.2 (but the relevant code is still in master 9445e as of now).
I'm raising this ticket as I encountered an error message which caused some confusion...
Running a query to Repo.all with a preload attached resulted in the following error:
[error] #PID<0.494.0> running TestBed.Endpoint terminated
Server: <IP_ADDRESS>:4000 (http)
Request: GET /v1/directory/1/listings
** (exit) an exception was raised:
    ** (ArgumentError) argument error
        (ecto) lib/ecto/repo/preloader.ex:51: Ecto.Repo.Preloader.do_preload/4
        (ecto) lib/ecto/repo/preloader.ex:19: Ecto.Repo.Preloader.query/5
        (ecto) lib/ecto/repo/queryable.ex:99: Ecto.Repo.Queryable.execute/5
        (ecto) lib/ecto/repo/queryable.ex:15: Ecto.Repo.Queryable.all/4
        (test_bed) web/controllers/listings_controller.ex:9: TestBed.ListingsController.index/2
        (test_bed) web/controllers/listings_controller.ex:1: TestBed.ListingsController.phoenix_controller_pipeline/2
        (test_bed) lib/phoenix/router.ex:265: TestBed.Router.dispatch/2
        (test_bed) web/router.ex:1: TestBed.Router.do_call/2

This left me none the wiser as to what was up so I hunted down the code in Ecto raising the error and commented out the rescue & re-raise lines and got this error instead:
[error] #PID<0.494.0> running TestBed.Endpoint terminated
Server: <IP_ADDRESS>:4000 (http)
Request: GET /v1/directory/1/listings
** (exit) an exception was raised:
    ** (ArgumentError) argument error
        (stdlib) :ets.lookup(:tzdata_current_release, :release_version)
        lib/tzdata/release_reader.ex:41: Tzdata.ReleaseReader.current_release_from_table/0
        lib/tzdata/release_reader.ex:13: Tzdata.ReleaseReader.simple_lookup/1
        lib/tzdata/release_reader.ex:5: Tzdata.ReleaseReader.zone_list/0
        lib/tzdata/release_reader.ex:22: Tzdata.ReleaseReader.periods_for_zone_or_link/1
        lib/tzdata.ex:137: Tzdata.periods/1
        lib/tzdata.ex:216: Tzdata.periods_for_time/3
        lib/calendar/date_time.ex:391: Calendar.DateTime.from_erl_timezone_validity/4

As you can see, the error is in a different library completely and knowing that allows me to hunt it down (in the morning anyway).
I asked in IRC an ericmj said the reason for re-raising would be to shorten the stack trace, so I thought I'd start a discussion here as to whether that is beneficial when it ends up hiding an error like this. I also realise that the stack trace in the 2nd one does not read back to the developer's app code so...is there a way we can get the best of both worlds?
Thanks all!
Darian

I think we should remove the reraise and recommend increasing the stacktrace limit if ecto truncates it.


Threat Detection?

I plan on working on that later. It's not as obvious to do as it sounds though.

Hmm, maybe if half of their mass can eat you, then stay a certain amount of distance away from them.


Data Class support

Hey!
I've added support for Ruby's Data class and seems like something to add to UniversalID natively. Here's my implementation:
UniversalID::MessagePackFactory.register(
  type: Data,
  packer: -> (model, packer) {
    packer.write(model.class)
    packer.write(model.to_h)
  },
  unpacker: -> (unpacker) {
    model_name = unpacker.read
    model_name.new(**unpacker.read)
  }
)

This is a great addition. Would you mind submitting a PR?


Modified SalesforceClient, HttpClient and API default version.

SalesforceClient: used SecurityProtocolType.Tls12 as TLS 1.0 is not accepted anymore by Salesforce.
HttpClient: removed several using blocks that swallow exception traces + implemented IDisposable pattern.
Soap and Bulk request managers: API default version set to 38.0.

Michael,
This is my first pull request, so I hope I'm doing it well.
My first update is because TLS 1.0 not allowed anymore by Salesforce, so I replaced it by TLS 1.2.
I also updated the HttpClient classe because the PerformRequest method threw a NullReferenceException.   I also took the opportunity to implement the IDisposable pattern.
Thank you for your great library!
Loïc

Hello,
I removed to unnecessary comments in HttpClient as requested.
I also found valuable to define one's own security protocol when using the library. Hence I added a new argument to SalesforceClient with a default value to have no impact on existing code (adding this argument to the Login method would have impacts on GetSession and GetSessionId methods too).
Looking forward to hearing from you,
Loïc

This looks great thank you


updated: avatarcircles component to support profie urls

fix #305
Separate PRs from #326

@sanjay-mali Nice! But where’s my avatar, haha? I’m adding mine at the end 😂


Only download required packages

First, thanks for making this; I've been thinking about doing something similar for a while.
This change makes it so that only packages which are potentially required are downloaded.
I did this because the original method takes a while to download all the packages and fills up the store. It would be nice to enable other repositories too, and this should make that a bit less painful.
If you don't want this because the whole idea is too complicated, that's fine -- I'll keep my fork separate.
This could maybe do with refactoring a bit, perhaps moving the new functions to a separate 'opkg' module?

Great optimization. Well done!


Using run and Item: attack simultaneously

Describe the bug
I would like to be able to use attacks as well as running simultaneously similar to the fireball powerup in the Mario games
To Reproduce
Steps to reproduce the behavior:

Attach script to button. Item: attack on press
Also attach script to button. Player speed 2 on press

Expected behavior
Run when the button is held, attack when the button is tapped.
Platform (please complete the following information):
Gbstudio 2 beta 4

I do think we need On Press/On Hold/On Release tabs for scripts to properly handle this. You can kinda get away with using a timer script and two variables tracking the button state to detect if a button is pressed/held/released, but due to issue #629 your sprite will fly off screen if you change the movement speed while the sprite is off tile.

I do think we need On Press/On Hold/On Release tabs for scripts to properly handle this. You can kinda get away with using a timer script and two variables tracking the button state to detect if a button is pressed/held/released, but due to issue #629 your sprite will fly off screen if you change the movement speed while the sprite is off tile.

I wouldnt mind at all if they both fired off at the same time without an "on hold".. my problems is that they do not work at all together. You have to choose one or the other. Either run or attack.. Not both.

You can not attach 2 scripts to one button, it will overwrite the last attachment.
You must make the code for both functions part of one attached script, just fire a projectile, then set speed, no need for 2 attachments.
With 2.0 beta 4 and 5, attach scripts also override the default button behavior, so you can disable actor movement like 1.2 https://github.com/chrismaltby/gb-studio/blob/v2beta/CHANGELOG.md#200-beta4
As mentioned with #629  setting player speed while mid tile is buggy in all 2.0 betas currently.

You can not attach 2 scripts to one button, it will overwrite the last attachment.
You must make the code for both functions part of one attached script, just fire a projectile, then set speed, no need for 2 attachments.
With 2.0 beta 4 and 5, attach scripts also override the default button behavior, so you can disable actor movement like 1.2 https://github.com/chrismaltby/gb-studio/blob/v2beta/CHANGELOG.md#200-beta4
As mentioned with #629 setting player speed while mid tile is buggy in all 2.0 betas currently.

It unfortunately doesnt work. Only the first action listed in the attach script works.


Strange behaviour of uib-collapse inside ng-repeat

Faced with strange behaviour of uib-collapse inside ng-repeat with changing collection: animations calls with each collection update, despite the fact that uib-collapse is set to false;
See plunkr: http://plnkr.co/edit/rP1AlbLsi1qXuJOJL0D6?p=preview

Maybe related? https://github.com/angular-ui/bootstrap/issues/4848

Closing as support question answered on SO, link

I got only a partial answer on SO about transition between primitives.
But what about first opening of uib-collapse="false" with animation? I suppose it shouldn't be happened, but it does...

This is a result of the expand animation being run immediately in the link function.  Adding the following code:
if (!scope.$eval(attrs.uibCollapse)) {
  element.addClass('in')
    .addClass('collapse')
    .css({height: 'auto'});
}

at the top of the linking function seems to solve the problem.  Updated plunk with code changes.

Thank you! Is there a chance that this fix will be included in next releases? I think changing of vendor sources is a bad practice :)

I wonder if this is related to all of our ngAnimate modal + collapse issues - can you check on whether the fix fixes those issues to @RobJacobs?

@wesleycho Will do, wanted to get the positioning PR in first.

This is not related to the modal issues - that one turns out to be a gotcha with ng-app needing to be present on the body element or higher.

Actually...nevermind, I could be mistaken.

So to clarify why the collapse class is removed - Bootstrap uses the collapsing class to set the transition, and the in class to animate.

Great job, @wesleycho , thank you!


Fix packing sub_cmd.

sub_cmd is an unsigned char, since VENDOR_PROTOTYPE is 0xff. If not, it cannot be encoded.
Currently, Config.CMD.VENDOR_PROTOTYPE (0xFF) cannot be encoded, since it is encoded as <b (signed char). It must be encoded as <B (unsigned char).

Thanks!


[Feature Request] Add function to adjust luminance of a color

The source color can be interpolated with black or white until the correct luminance is found.
Proposed API -
const styles = {
  background: setLuminance('#CCCD64', 0.5),
}

Demand has not been high enough to implement this feature. We are opening to revisiting the decision if demand increases.


SAA-2208: Use shorter timeout for prison api

Codecov Report
Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 84.57%. Comparing base (718fc02) to head (e91fc16).

Files with missing lines
Patch %
Lines

...tiesmanagementapi/config/WebClientConfiguration.kt
0.00%
1 Missing :warning:

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #1201   +/-   ##
=========================================
  Coverage     84.57%   84.57%
  Complexity     3757     3757
=========================================
  Files           385      385
  Lines         12767    12767
  Branches       1098     1098
=========================================
  Hits          10798    10798
  Misses         1459     1459
  Partials        510      510

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Allatori Deobfuscation not working, using the correct transformers..

I don't know what else to do/use can someone please help me, I can provide more information and I'm active on Github daily. Thank you!

i think you need to add bukkit to your libraries


Support Casdoor authentication for Spring Cloud Alibaba

We already support SpringBoot very well:

Starter: https://github.com/casdoor/casdoor-spring-boot-starter
Example: https://github.com/casdoor/casdoor-spring-boot-example

Now we need to support Spring Cloud: https://spring.io/projects/spring-cloud , especially Spring Cloud Alibaba: https://spring.io/projects/spring-cloud-alibaba
An example is RuoYi: http://ruoyi.vip/

We need to connect https://gitee.com/y_project/RuoYi-Cloud to Casdoor

@seriouszyx

@leo220yuyaodog

Done, see discussions here: https://github.com/casdoor/casdoor-spring-cloud-starter/pull/2#issuecomment-1221559091
Docs at: https://casdoor.org/docs/integration/spring-cloud


Size should return (x1-x0, y1-y0) not (x1, y1)

I was going about building out the tests and I encountered this:
var tileLayout = d3.tile().extent([[100, 200], [300, 350]]);
test.deepEqual(tileLayout.size(), [200, 150]); // Currently fails - actual: [ 300, 350 ]

In the source, tile.size() is returning (x1, y1):
tile.size = function(_) {
  return arguments.length ? ... : [x1, y1];
};

Perhaps it should be changed to return (x1-x0, y1-y0)?
tile.size = function(_) {
  return arguments.length ? ... : [x1 - x0, y1 - y0];
};

The same design applies to voronoi.size.
I guess it’s more reasonable to return the difference. The reason I did it the other way is that when you set the size, the top-left is always [0,0], so the returned size is equivalent assuming that you are using voronoi.size consistently to both set and get. But your interpretation is more reasonable if you are mixing them together.

Ahh great, I see you made the change in d3-voronoi, so I'll go ahead and merge #18 to change it over here too.


Waste of time as usual

Neither this step on the next (adding a controller) will run when you add /HelloWorld to the target URL. I guess it's been out more than a month and is now obsolete.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: faf18d20-d28f-1efa-d329-181fff3630fa
Version Independent ID: 46a7c2e0-4871-491f-02c2-54f7df2237b1
Content: Get started with ASP.NET Core MVC
Content Source: aspnetcore/tutorials/first-mvc-app/start-mvc.md
Product: aspnet-core
Technology: aspnetcore-tutorials
GitHub Login: @Rick-Anderson
Microsoft Alias: riande

The tutorial works. I'm not sure what step you missed. You might try asking on StackOverflow,.

@KrhHou  we have over half a million users saying this works.


"Error: Cannot find module '@vendia/serverless-express'

I have not changed anything with my build process, but for some reason I'm now getting this error when deploying to my development and production environments.
Seems to work fine on my local.
{
"errorType": "Runtime.ImportModuleError",
"errorMessage": "Error: Cannot find module '@vendia/serverless-express'\nRequire stack:\n- /var/task/lambda.js\n- /var/runtime/UserFunction.js\n- /var/runtime/index.js",
"stack": [
"Runtime.ImportModuleError: Error: Cannot find module '@vendia/serverless-express'",
"Require stack:",
"- /var/task/lambda.js",
"- /var/runtime/UserFunction.js",
"- /var/runtime/index.js",
"    at _loadUserApp (/var/runtime/UserFunction.js:100:13)",
"    at Object.module.exports.load (/var/runtime/UserFunction.js:140:17)",
"    at Object. (/var/runtime/index.js:43:30)",
"    at Module._compile (internal/modules/cjs/loader.js:1015:30)",
"    at Object.Module._extensions..js (internal/modules/cjs/loader.js:1035:10)",
"    at Module.load (internal/modules/cjs/loader.js:879:32)",
"    at Function.Module._load (internal/modules/cjs/loader.js:724:14)",
"    at Function.executeUserEntryPoint [as runMain] (internal/modules/run_main.js:60:12)",
"    at internal/main/run_main_module.js:17:47"
]
}

Sorry you're hitting this. Could you show your lambda.js and the serverless-express entry in package.json?

Not the original issue author, but I am experiencing the exact same issue:
Package.json:
"aws-serverless-express": "^3.2.0"
Lambda.js
// generated by @ng-toolkit/serverless
const awsServerlessExpress = require('aws-serverless-express');
const server = require('./dist/server');
const awsServerlessExpressMiddleware = require('aws-serverless-express/middleware');

const binaryMimeTypes = [
  'application/javascript',
  'application/json',
  'application/octet-stream',
  'application/xml',
  'image/jpeg',
  'image/png',
  'image/gif',
  'text/comma-separated-values',
  'text/css',
  'text/html',
  'text/javascript',
  'text/plain',
  'text/text',
  'text/xml',
  'image/x-icon',
  'image/svg+xml',
  'application/x-font-ttf',
  'font/ttf',
  'font/woff',
  'font/woff2',
  'application/font-woff',
  'application/font-woff2',
  'application/x-font-woff',
  'application/x-font-woff2'
];

server.app.use(awsServerlessExpressMiddleware.eventContext());

const serverProxy = awsServerlessExpress.createServer(server.app, null, binaryMimeTypes);
module.exports.universal = (event, context) => awsServerlessExpress.proxy(serverProxy, event, context);

I npm installed @vendia/serverless-express, npm removed aws-serverless-express and updated the two requires in the lambda.js but I'm still receiving this issue.

@selected-pixel-jameson are you also using @ng-toolkit/serverless? I wonder if it's something different there. You can get the example https://github.com/vendia/serverless-express/tree/master/examples/basic-starter up and running and maybe compare what's different?

So we figured it out, it's an interaction with the serverless deploy, it automatically applies an ignore to certain paths in node-modules for the aws-serverless-express in the serverless.yml. Once we updated those to exclude the new name/path it worked.
Snip from serverless.yml:

package:
  exclude:
   - src/**
   - node_modules/**
   - firebug-lite/**
   - e2e/**
   - coverage/**
   - '!node_modules/@vendia/**'
   - '!node_modules/aws-/**'
   - '!node_modules/binary-case/**'
   - '!node_modules/type-is/**'
   - '!node_modules/media-typer/**'
   - '!node_modules/mime-types/**'
   - '!node_modules/mime-db/**'

Glad you fixed it. Closing


Notebook diff editor: Notebook becomes dirty without any apparent changes

Just running a Python notebook will mark it as dirty. The notebook diff editor could tell me why, but it doesn't:

Most likely the execution count that causes notebooks to be dirty.
I too found that we do not display the execution count and the like in the diff view.

Solution:

We can try to include execution number in metadata


Importing model and visualizing it with Lucid

I'm trying to open an autoencoder model I've trained myself, on Lucid, and I'm using as reference the notebook Importing a graph into modelzoo.
I'm mostly in doubt on how to use the provided class:
  model_path = 'nasnet_mobile_graphdef_frozen.pb.modelzoo'
  image_shape = [224, 224, 3]
  image_value_range = (0, 1)
  input_name = 'input'

What should I define as image_shape, image_value_range? For what images I'm considering this? The output of a certain convolutional layer?
Also, for what is defined the input_name?

Hi Ricardo,
the input_name refers to the input-node of your Tensorflow-graph. The image-shape, as far as i know, refers to the size of images your model expects. The image_value_range specifies the values, that are possible for every channel in your Picture. For a typical picture, those are between 0 and 255. However, for a CNN you normalize them to be between -1 and 1 or 0 and 1.
When i tried to import my own model into Lucid, it only worked when i removed all constraints for the expected size of the images, exept the number of channels(3).

Thanks for the highlight @tschwabe . Another question, if I want to run Lucid on a model with more channels (>3), is it possible to use it? I wonder that perhaps I need to constrain it for three channels due to the RGB mapping.

Im not exactly sure. I would recommend to remove the constraints from the height and the width and keep it for the channels, thats what i did.

First question: When you said to remove width and height constraints, and keep channels, would be something like going from [224, 224, 3] to [:, :, 3]?
Second: I've now tested just passing the model_path and input_name arguments, and got this error:
ValueError: Dimensions must be equal, but are 3 and 7 for 'import/conv2d_1/convolution' (op: 'Conv2D') with input shapes: [1,?,?,3], [3,3,7,16]. It is weird, because I've not specified a image_shape argument.

Oh, I see. How did you change/edit your trained model? (I'm new to Tensorflow)

I trained my model with fixed size of the pictures. Then i constructed a new model with the same Architekturen, but no constraints, and loaded the wheights from the other model Into the new one..
I guess there is a prettier way to do it..

image_shape, image_value_range, and input_name are all required even in theory.
In a nutshell, when lucid imports your model's graph, it needs to replace your model's input (usually a tf.placeholder) with it's own parameterization. To construct this input, it needs to know about the following:

image_shape so the input lucid creates fits onto your model.
image_value_range so the input lucid creates provides pixel values similar to those your model was trained on. Different architectures use different pre-processing, so we can not guess. Many architectures normalize to between 0 and 1, but some use -1 to 1, yet others expect 0 to 225.
input_name is the name of the tensor (usually a tf.placeholder) that is used as an input in your original model. We need to know about it so we know where to feed data into your model. Many architectures simply call this input, but different architectures use different names, so we can not guess.

image_shape has an additional layer of complexity, because we try to allow for flexibility in the input size, but this works best for using larger inputs than the model expects. Smaller inputs lead to smaller spatial dimensions in higher layers—which can lead to shape issues when e.g. your pooling layer has a kernel size that is larger than the remaining spatial dimensions.
As a first step, set image_shape to the input size your original model expects, and use param.image(...) with that same size. This should avoid most shape-related issues.
Also, @ricardobarroslourenco, feel free to create colab notebooks that let me reproduce your issue. I can not promise actual support, but if you can make it easier for me to work on your problem… it increases the probability of me doing just that. Thanks for being an early adopter! :-)

@tschwabe 's extra step should not be necessary when you tell lucid to use the same input size as you use during training.

@ludwigschubert thanks for the thorough answer. Let me give you some background on my application.
In my project, I'm building a convolutional autoencoder, but the application is meant for remote sensing images I'm parsing from Google Earth Engine. More specifically I'm ingesting several multispectral images (7 channels, each one associated with a spectral band acquired at the satellite sensor) in which I want to replicate cloud texture patterns. We believe that such cloud class we feed to the autoencoder is too broad, and we expect to have a reasonable amount of variance at the hidden layers, even the most compact ones, even after convergence (by class misclassification of a cloud class, or due to cloud classes that are not described in the present framework, but were enclosed into a hyper class due to lack of a more proper label).
The reason I'm willing to use Lucid is to streamline the process of visualizing the embeddings I'm learning because I will probably drive my network architecture development, and parametrization, by the features I'm able to represent, and their quality. Ideally, this embeddings would show textures present in the samples I'm providing and would be subject to analysis by geophysicists on their feasibility as new cloud classes.
Currently, I've been working on a colab notebook which needs some cleanup, and I'll be glad to share it with you :smiley:
What google account should I share it to?

Sounds like an exciting application!
Creatively, my Google Account is my Github username @google.com. :-)

Thanks @ludwigschubert . I've just shared with you a more clean and commented notebook. Thanks a lot for your availability :)

@ludwigschubert I would like to know if you were able to run the notebook. I've changed the dataset permissions, so it should be ok.

@ricardobarroslourenco  I am not sure if you have resolved your issues of not able to visualize if your model takes input something like [batch_size,w,h,1]. I was able to visualize by making a small change To this image module
something like this at line number 37
return rgb[...,1]
The resultant image rendered is black and white.

@hegman12 oh nice. I'll try to change that and see how it goes.

Sorry for tacking this on, but a similar question on the subject of image_value_range, based on https://github.com/tensorflow/lucid/blob/master/lucid/modelzoo/vision_models.py .
In the following class, image_value_range is set as image_value_range = (-117, 255-117). I have seen this with InceptionV1 as well as InceptionV3. Does anyone know where this comes from? I don't see these values in the InceptionV1 preprocessing codes.
class InceptionV1(Model):
model_path = 'gs://modelzoo/InceptionV1.pb'
labels_path = 'gs://modelzoo/InceptionV1-labels.txt'
image_shape = [224, 224, 3]
image_value_range = (-117, 255-117)
input_name = 'input:0'

@ebwendol The specific pre-trained weights we use were trained on that input range. We are not using the weights trained with the slim reimplementation. @colah is currently working on getting more models and more versions of models into modelzoo—check out #85 if you're curious. In particular, this will include slim's InceptionV1, with the value range that you'd expect from a slim model—(-1,1).

@ludwigschubert Thank you very much for clarifying this!

@ricardobarroslourenco @tschwabe @ebwendol @MahrRah @hegman12
We've been working on a new workflow for importing models into Lucid, which aims to make it much easier! We'd love your feedback. You can find code and discussion at PR #152.

Hi @colah ! Thanks for the heads up. I've just moved back to Brazil (I've left the PhD at UChicago), so I am still accomodating things. I'll let you know once I test it, but this is a nice contribution :)


Remove explicit ContentDeserializer construction in visit functions

This is a good suggestion from https://github.com/serde-rs/serde/pull/2821#pullrequestreview-2288334462. I was not able to measure any binary size improvement — the rlib is 111K before and after. But it's worth making the change.

If you are worried about the size of the generated code, then maybe merge

#2564 (besides, it reduces compile time)
#2811 (besides, it fixes one bug and corrects areas of responsibility of Content[Ref]Deserializer). This one removes a lot of generic code, so should expect reducing size, especially when flattening or internally or adjacently tagged enums is used

I rebased both PRs on current master for easing of testing.

Some tests on my computer (the same test library project as in #2821):

Commit
Size (bytes)
Diff from master (bytes)

master
143694

visitor-driven
152842
+9148

common-field
136930
-6764

both
142462
-1232


Can't create multiple versions of image

I am trying to create two new versions of the uploaded image, one large and one small.
What I found is, the large is always the same size as thumb.
require "image_processing/mini_magick"

class AttachmentUploader < Shrine
  include ImageProcessing::MiniMagick

  plugin :activerecord
  plugin :logging, logger: Rails.logger

  plugin :determine_mime_type
  plugin :store_dimensions
  plugin :direct_upload, max_size: 20*1024*1024, presign: -> (r) do
    r.params["fields"] || {}
  end
  plugin :remove_attachment
  plugin :versions, names: [:original, :large, :thumb]

  def process(io, context)
    if context[:phase] == :store
      file = io.download
      large = resize_to_limit!(file, 1200, 1200)
      thumb = resize_to_limit!(file, 300, 300)

      {
        original: io,
        large: large,
        thumb: thumb,
      }
    end
  end
end

The data behind this:
pp JSON.parse(Upload.last.attachment_data)
  Upload Load (0.5ms)  SELECT  "uploads".* FROM "uploads"  ORDER BY "uploads"."id" DESC LIMIT 1
{"original"=>
  {"id"=>"3a0768ce990db7637c54126d634a3e2ebee35ee6d3546bf3fba599f46939.jpg",
   "storage"=>"store",
   "metadata"=>
    {"filename"=>"Interstellar UHD 2.jpg",
     "size"=>1691252,
     "mime_type"=>"image/jpeg",
     "width"=>3840,
     "height"=>2160}},
 "large"=>
  {"id"=>"21c487c57e193eae3650025b453b0669ee083603621af0879823f454025c.jpg",
   "storage"=>"store",
   "metadata"=>
    {"filename"=>"Interstellar UHD 2.jpg",
     "size"=>14306,
     "mime_type"=>"image/jpeg",
     "width"=>300,
     "height"=>169}},
 "thumb"=>
  {"id"=>"7bd60d5ac34e0cc8164067571c36914588135bc87673f9f9b68660277ee7.jpg",
   "storage"=>"store",
   "metadata"=>
    {"filename"=>"Interstellar UHD 2.jpg",
     "size"=>14306,
     "mime_type"=>"image/jpeg",
     "width"=>300,
     "height"=>169}}}

This is actually expected behaviour. If you use resize_to_limit! (with a bang), that modifies the file in-place. So in your example, large will have the same path as file, and thumb as well. So when you resize_to_limit! the file again and assign it to thumb, it will modify large as well. This is generally how references work.
What is not expected was that I was recommending it in the README. In processing versions you should generally always use the non-bang methods (resize_to_limit instead of resize_to_limit!). I updated the documentation with this recommendation.

:+1: Awesome, thanks :)


Update confirmdialogdemo.html

Add an example for showing the contents of except 'yes' or 'on'.
###Defect Fixes
When submitting a PR, please also create an issue documenting the error.
###Feature Requests
Due to company policy, we are unable to accept feature request PRs with significant changes as such cases has to be implemented by our team following our own processes.
Smaller scaled feature implementations such as adding a property to a component will be considered for merging.

add some parameters for the contents of 'acceptLabel' and 'rejectLabel'

add some parameters for the contents of 'acceptLabel' and 'rejectLabel'


Revert "gdown: 3.2.6-0 in 'kinetic/distribution.yaml' [bloom]"

Reverts ros/rosdistro#14932
Sorry, I found https://github.com/ros-infrastructure/ros_release_python and think it must be used for releasing python-gdown.

Note, Please be a little more careful about your revert commits. This had 3 commits inside it, but most of them were empty. When we merge we squash, but it's not good to reference reverting things that you're not actually reverting.

I see. Thanks.


Allow parsing of duration strings 1y2w3d4h5m6s

It'd be nice to parse duration strings like this 1y2w3d4h5m6s. Is that likely possible in Arrow?

I would lean towards "no".  In general, Arrow deals with moments in time, not durations.

A slight change to the originally suggested format would allow arrow to support ISO8601 Duration fields, which one of my current projects could benefit from.
Would you accept a pull request for that functionality?

@ABitMoreDepth FWIW, I ended up finding the feature in Pendulum
In [2]: pendulum.parse('P2Y3M4DT5H6M7S')
Out[2]: Duration(years=2, months=3, days=4, hours=5, minutes=6, seconds=7)


Removed 'form-data' npm package

Summary

Ticket Link

Related Pull Requests

Has server changes (please link here)
Has mobile changes (please link here)

Screenshots

Release Note

NONE

E2E tests not automatically triggered, because PR has no approval yet. Please ask a developer to review and then try again to attach the QA label.

/e2e-test

Successfully triggered E2E testing!
GitLab pipeline | Test dashboard

@hmhealey https://github.com/mattermost/mattermost-webapp/blob/ff7327f6aee73780db45f6508f3ac05ab8664ea0/packages/client/package.json#L19-L21
Its safe to say we can remove from here too?

@hmhealey
https://github.com/mattermost/mattermost-webapp/blob/ff7327f6aee73780db45f6508f3ac05ab8664ea0/packages/client/package.json#L19-L21
Its safe to say we can remove from here too?

Yeah, we should remove that at the same time

/e2e-test

Successfully triggered E2E testing!
GitLab pipeline | Test dashboard


Fix a few broken documentation links

Hi,
While browsing the documentation I noticed a few broken documentation links (on Github and Read the Docs). I have fixed those broken links and made sure the changes work on both Github and Read the Docs.
Thanks,
Rob

Thanks :+1:


Templates2

Purpose

Migrates the following tutorials into module template form, so that they can be pushed to Ballerina Central.

content_based_routing
scatter_gather_flow
service_composition
json_to_jms
alert_notification_using_amazonsqs
gmail_client_application
salesforce_ftp_integration
salesforce_to_mysql

Related issue: #411

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Add CI badge

Codecov Report

Merging #3 (a242bd2) into master (17d6c9a) will not change coverage.
The diff coverage is n/a.

:exclamation: Current head a242bd2 differs from pull request most recent head 9503a72. Consider uploading reports for the commit 9503a72 to get more accurate results

@@           Coverage Diff           @@
##           master       #3   +/-   ##
=======================================
  Coverage   67.83%   67.83%
=======================================
  Files           7        7
  Lines         914      914
  Branches        3        3
=======================================
  Hits          620      620
  Misses        294      294

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 17d6c9a...9503a72. Read the comment docs.


Migrate Carbon Aware WebApi to consume CA library

Issue Number: #209
Summary
As a Carbon Aware Developer, I want to have the CA WebAPI consumer layer use the Carbon Aware Library so that changes can be made in a single place: the CA Library.
Changes

Updated WebAPI to use handlers, models, and exception in the GSF.CarbonAware Library
Updated Unit Testing

Checklist

[x] Local Tests Passing?
[x] CICD and Pipeline Tests Passing?
[ ] Added any new Tests?
[ ] Documentation Updates Made?
[ ] Are there any API Changes? If yes, please describe below.
[x] This is not a breaking change. If it is, please describe it below.

Are there API Changes?
If yes, what are the expected API Changes? Please link to an API-Comparison workflow with the API Diff.
N/A
Is this a breaking change?
If yes, what workflow does this break?
N/A
Anything else?
Other comments, collaborators, etc.

Please follow GitHub's suggested syntax to link Pull Requests to Issues via keywords

This PR Closes #209

Codecov Report

Merging #233 (14ef3e7) into release (14ef3e7) will not change coverage.
The diff coverage is n/a.

:exclamation: Current head 14ef3e7 differs from pull request most recent head 1d31730. Consider uploading reports for the commit 1d31730 to get more accurate results

@@           Coverage Diff            @@
##           release     #233   +/-   ##
========================================
  Coverage    77.06%   77.06%
========================================
  Files           71       71
  Lines         2429     2429
  Branches       244      244
========================================
  Hits          1872     1872
  Misses         486      486
  Partials        71       71


Any scripts?

Hi~! Could please provide some scripts to run the pytorch model on 2D datasets? I don't know how to run it.

Hi @kai-wen-yang ,
We provide training and evaluation scripts implemented with PyTorch to reproduce 2D experiments in train_and_eval_pytorch.py .

Scripts means the command line order, like
python train_and_eval_pytorch.py --data_flag pathmnist -- ..


Add adminer to makefile

AC

Makefile contains command that starts adminer which allows connection to db service

Done in https://github.com/CodeForPoznan/pah-fm/pull/337


⚠ Samsung has degraded performance

In 8470b39, Samsung (https://samsung.com) experienced degraded performance:

HTTP code: 200
Response time: 2656 ms

Resolved: Samsung performance has improved in 1034e77.


$request->input('metadata') converting empty object to empty array

This is the code snippet -
$metadata = $request->input('metadata', (new \StdClass));

if metadata key is not present in request body, an empty object is associated to $metadata variabled, but if value is {} of this key, it is returning an empty array [], not an empty object.
Any solution to this. Workaround I've put for now is type casting this $metadata to object ((object) $metadata), but IMO it's a hack. empty array [] and empty object {} are two entirely different things.

Thanks for the report. Please can you provide the exact Laravel version you are using?

Actually, the input method doesn't belong to us, it's on symfony's class. Feel free to take this up with them. Thanks again. :)


Anypath abstractmethods

Disclaimer: I quickly hacked this as a draft/suggestion. There might be better/nicer methods to achieve the same.
I suggest to add some abstractmethods to AnyPath so that the methods available for both CloudPath and pathlib.Path can be seen when AnyPath is used as type annotation. It would be nice if there are more elegant solutions but I think the overall behavior would be useful.
Currently missing:

Docstrings for functions that differ between pathlib.Path and CloudPath
CloudPathMeta could inherit from AnyPathMeta to avoid code duplication

I probably won't be around the next days but wanted to leave this as starting point to discuss.

Codecov Report

Merging #266 (3d455b3) into master (98ed2e5) will decrease coverage by 2.5%.
The diff coverage is 73.2%.

@@           Coverage Diff            @@
##           master    #266     +/-   ##
========================================
- Coverage    94.8%   92.2%   -2.6%
========================================
  Files          21      21
  Lines        1321    1450    +129
========================================
+ Hits         1253    1338     +85
- Misses         68     112     +44

Impacted Files
Coverage Δ

cloudpathlib/anypath.py
76.1% <71.8%> (-23.9%)
:arrow_down:

cloudpathlib/cloudpath.py
93.5% <100.0%> (ø)

cloudpathlib/__init__.py
92.8% <0.0%> (-7.2%)
:arrow_down:

cloudpathlib/s3/s3client.py
92.9% <0.0%> (-2.7%)
:arrow_down:

cloudpathlib/gs/gsclient.py
92.8% <0.0%> (-1.8%)
:arrow_down:

cloudpathlib/local/implementations/azure.py
97.5% <0.0%> (-0.1%)
:arrow_down:

cloudpathlib/local/implementations/gs.py
100.0% <0.0%> (ø)

cloudpathlib/local/implementations/s3.py
100.0% <0.0%> (ø)

Any opinion on this @pjbull? I'm happy to make this a polished PR or go after another solution if you have any suggestions.

Sorry @chbehrens. Delay is because, as you point out, the current implementation is a lot of boilerplate which seems less than ideal just to support use of AnyPath as a type hint (does typing things as Union[CloudPath, Path] instead work for your purposes?). I don't have a better implementation off the top of my head, and like you say we should think about it in the context of our overall class hierarchy. Happy to open an issue for discussion, but I'm not super keen on this PR as is. Maybe @jayqi has a different opinion.

Don't get me wrong, I'm also not keen on it the way it is. I just did it to show what I'd like to achieve in the end behavior-wise but preferably via something more meta programming like. That's why I made it a draft and was wondering whether you have some ideas or what you think of the overall intended behavior.
I'm sorry if it's the wrong format here, I just thought a draft PR might demonstrate it better than an issue.

@ringohoffman Do you have thoughts on this after implementing your changes in #298? Is there a cleaner/easier way to get useful type hinting for AnyPath without duplicating all the signatures?

I was asking about this over at https://github.com/microsoft/pyright/issues/4331 and got back a few suggestions... and the virtual superclass approach was not one of them. I will have to play around to see which results in the most expected / convenient typing experience.

Much appreciated! Curious what you discover.

It does some interesting stuff in regard to typing.

😆 😆 😆

@chbehrens I'm going through old PRs to keep them moving.
I think that I've come around on this. I was hoping for some cleaner upstream fix that makes this kind of polymorphic class work, but I don't think there's another way to get useful completions for AnyPath until something like #347 comes in upstream in Python (and we can subclass from that).
Would you be willing to rebase this on the latest and add tests/docs?
Outside of that, I am curious if one of the other ideas in this thread might work: https://github.com/microsoft/pyright/issues/4331#issuecomment-1350209969
It does seem that Protocol is potentially a friendlier implementation than ABC since it is slightly less boilerplate and plays nicer with static type checkers, but I'm not sure it solves all our issues without some experimentation.

I'll try to have a look at it if I find time but let's just close this, an issue would be better suited to track the topic if necessary.

I've experimented with Protocols, and one of the main problems IIRC is that the Pydantic validation methods were getting caught up in it. There's also some annoying stuff with API changes to Path over different Python versions, and not being able to match all of them.


codelens shouldn’t be fully updated

Every time I press Enter at the bottom, the codeLens above will be re-rendered, and the page will shake a lot. I think there should be a diff comparison to batch update.

I think there should be a diff comparison to batch update.

There is something like this but you might be returning an empty array of code lenses inbetween. Please share a minimal repro that allows us to reproduce this

Hi @jrieken, thank you for such a quick recovery.
I used the code repository in the official vscode-sample as a demonstration.
https://github.com/microsoft/vscode-extension-samples/tree/main/codelens-sample

I found a problem. Because I did not register registerCodeLensProvider during initialization, but at a certain moment, I had this problem after dynamically using registerCodeLensProvider. But I think I can change my writing method to avoid this problem.


Error highlights don't replace source locations in hover text

I can't figure out an example at the moment, but I've seen this.  Errors in hover text sometimes don't replace source locations, so you see something like program.hs:5:3, where our convention is to replace that with "Line 5, Column 3"

@nixorn Another likely quick fix, if you have time to look.

Ok, when I'll encounter this I'll pay attention to it.

https://code.world/#PqIBNGrbqNnwDz3ZFc8zTQw is an example.


[BFCL] Error when consecutively generate from multiple oss_models with vllm

I have plenty of models and I want to test them all. So I run a bash script like this:
bfcl generate --model "model_1" --test-category simple
bfcl generate --model "model_2" --test-category simple
...

The first generation was good. But the second run and thereafter encountered the following error:

I suspect the reason is that VLLM_PORT still occupied by the previous run, so I got the output of ps -aux when the second run just began. However it seems the previous vllm server has already ended.

Now I have no idea why this isn't working, could you help me with this?
Or what's the recommended way if I want to run many models automatically?
Update:
Just after I open this issue, I find the error disappears if I wait long enough before the next run. (sleep 60 after each line).
But still, I wonder if there's a better way to do this?

Hi @YifanHao,
I think the issue you are encountering is because vllm takes some time to shutdown the server and clean up after all the inference are done, and so the best approach would be probably like what you are doing (eg, add some time interval between the runs).

Got it. Thanks for your reply!


ARROW-12988: [CI][Python] Revert skip of failing test in kartothek nightly integration build

Revert of #10466

@github-actions crossbow submit test-conda-python-3.7-kartothek-master test-conda-python-3.7-kartothek-latest


removes last_name in returned user

What does this PR do?
Removes last_name from returned user object when retrieving a reportback or reportback-item. Since we are displaying both first_name and photo in the user object (with the param load_user=true) we do not want to expose the user's last_name.
Where should the reviewer start?
This gets deleted in Transformer.php but is also taken out of the user object in Reportback.php and ReportbackItem.php
How should this be manually tested?
http://dev.dosomething.org:8888/api/v1/reportback-items.json?load_user=true and/or
http://dev.dosomething.org:8888/api/v1/reportbacks.json?load_user=true should not have last_name in the user object.
What are the relevant tickets?
Fixes #5756
cc @jonuy @aaronschachter

I think we should leave the last name in the Reportback and ReportbackItem classes, but keep it out of the Transformer like you are doing. The classes are internal to the app, while the Transformer is the only thing that takes that data and exposes it to the api. We internally may need the last name for the user down the line.

got it, thanks @weerd! Makes a lot of sense to have it there if we need access to it but just not expose it. Added it back in!

:+1:


add wit inspect

Fix #76
We could add colors later on to make the tree more readable
bar@9a045e56
└─ xyz@2a0b2c81->13dfbe03
foo@814e0e1f
├─ baz@8dc2af98
└─ xyz@13dfbe03
   └─ fizz@38ef24c0

I added a commit for generating dot files. If desired, I can make it a separate pull request, but I thought it'd be easier to put it here than deal with merging/rebasing later


Issue with issuing SSL cert

Error occurred: Status: 403, Detail: Error creating new cert :: Authorizations for these names not found or expired: mail.arshem.com, Type: urn:acme:error:unauthorized
I get this when trying to install an SSL cert. Ideas?

Is the DNS serving records for that address?

It uses CNAME for that address, no A record for mail

What is the CNAME set to?

arshem.com.

I'm not seeing any DNS records for that domain at all

http://mxtoolbox.com/SuperTool.aspx?action=cname%3Amail.arshem.com&run=toolpage#

I found the issue: My firewall wasn't allowing DNS lookups, thus the call was failing. Sorry William!

No problem, it did throw me off that mxtoolbox was able to do the lookup.


feat: add emoji to slack alarm notification

Add an emoji to the Slack notification when forwarding alarms to Slack.

:tada: This PR is included in version 2.11.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Regarding signals in GDNative version

Hey @Gramps!
Any particular reason why signals are not implemented on GDNative version? If you can give more details about this maybe I can lend a hand.

Hey there!  To be honest, I don't really remember anymore.  The issue is from before Godot 3 was released.  According to Karrofel, who did all the GDNative stuff for Godot, signals would just not work at all.  I never really tested it at the time and never got it working on Windows either; just decided to wait until Godot 3 was released.  Now that it is, I still haven't gone back to see if it was non-functional or not.
I believe, and I could be wrong, that "emit_signal" cannot be called in the CPP like it can with the module.  I haven't really had time to mess with it yet.  I know there was something broken preventing it from compiling so I cut them out of the current version (I should have commented them out instead), but a lot of the groundwork is in there.
Feel free to see if you can get them working.  I'm doing updates for the SteamworksPy wrapper (Python) and updates for the GodotSteam (Godot 2 and 3) modules, as well as my game projects, currently.  I'll try to get to the signal thing again this coming week and at least report back with the specific issue; as well as add that code back in and comment out what doesn't work so it can be examined better.  If you get there before I do, let me know!

Hey!
Turns out a few weeks back I tried and got them working. AFAIK the only difference is that the emit_signal function now belongs to the owner. Example in godotsteam.cpp:
owner->emit_signal("leaderboard_loaded", (int)callData->m_bLeaderboardFound, callData->m_hSteamLeaderboard);
I only implemented a few things regarding leaderboards and it's working properly. Not production ready, you know, but I've been able to upload scores using gdnative.
I'm a little bit doubtful about messing with your code myself. However if you don't have the time to do this I'll start working on it, as I will eventually need it :)
Also, thanks so much for you effort!

That's fantastic!  That should allow us to implement all the signals actually.
I'm still working on the next big update for the module versions.  Again, feel free to add signals in.  I probably won't be able to get to it for another week and a half to two weeks.
And welcome and thank you!  Glad there is finally direction for signals.  It was the last thing it needed!

Got the signals in, updated to the newest functionality to match the modules, and compiles OK... but it doesn't work now.  This happened before and I don't remember why.  But super close!

Great! I hope to have some time this weekend to check it out!
El jue., 26 abr. 2018 20:47, GP Garcia<EMAIL_ADDRESS>escribió:

Got the signals in, updated to the newest functionality to match the
modules, and compiles OK... but it doesn't work now. This happened before
and I don't remember why. But super close!
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/Gramps/GodotSteam/issues/23#issuecomment-384750697,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AGYYqotN4n7YidI0aXpILwsGTJtOXXgjks5tshZHgaJpZM4TATfN
.

I haven't pushed the update yet, but will do so today so it's available to tinker with.  Hopefully someone gets it running if I don't; but it's got all the goods!

Holy crap!  It's been almost a year and I've gotten sidetracked with stuff!  Anyway, I'll be depreciating this branch and pick it back up after 3.1 officially launches in hopes that I can streamline this process and make it easier to use.

Hey, is there a GDNative version? That would be totally awesome.

There is a GDNative branch but it's quite experimental and somewhat outdated.  I plan to give it some love this weekend and see if I can bring it up to speed with the rest of the module!  The current version should be in the branch list.

I actually already released the game haha. Hacked some stuff, overall
worked like a charm.
El dom., 17 feb. 2019 19:34, GP Garcia<EMAIL_ADDRESS>escribió:

Holy crap! It's been almost a year and I've gotten sidetracked with stuff!
Anyway, I'll be depreciating this branch and pick it back up after 3.1
officially launches in hopes that I can streamline this process and make it
easier to use.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/Gramps/GodotSteam/issues/23#issuecomment-464492331,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AGYYqhpOj4dFBViD9k8CJqI22IFVUPZ1ks5vOaCzgaJpZM4TATfN
.

@jgcamarasa  So it worked in production?  Nice.  Haha, I didn't think it was ready for that.  What's your game?

Since my last post @Antkolos fixed the signal issues and I think we're good.  Granted I can't get GDNative to work period anymore, others seem to have better luck!

It's all good.
That looks awesome!  Definitely looks like a game I'd play.  Mind if I add it to the documentation's Games Using GodotSteam page?
I got my GDNative setup working so I'll be updating the how-to as well as updating the branch to match the modules.  Couldn't have done it without @Antokolos' help really.

Sure, go ahead! Thanks so much for the library, really made my life quite easier. <3

Added you to steam (CastorHouse) so I can share a key with you :)

Sounds good, I'll add it this afternoon.  If you want something in addition to the Steam store page, like a blog or Twitter, let me know.  And glad it helped!


"I am still going" missing in exercise 20 sliceref

Background
I finished exercise 19 and the gopherlings watch window gave me an error message that did not at all resemble exercise 20 (because it skipped directly to exercise 21)
Proposed change
Add
// I AM STILL GOING

to exercise 20
EDIT: Also separately - thank you for maintaining this repo. Despite what my issues might indicate, I am very happy to have this training resource.

You are correct- and the comment is also missing in excercises 31 and 32, which is the root cause of #11. Let me know if you want to create a PR for them!

I do, thank you. It'll show up at some point later today when I can fit it in.

Feel free to file a PR for #9 as well, no rush!


[Feat] Chat Analytics

Hello,
it would be nice to important to have chat analytics on the chat bot, namely a way to have some of the metrics contained in this article.
Some of the things I personally find useful:

User # number of requests
User question and responses (configurable, for example, the first X questions and answers so that we can analise user chatbot interaction)

The implementation of where to store the chat analytics could be a configurable choice between:

Azure Application Insights
Google Tag Manager
Any other that you can find useful

Thanks

This is definitely nice to have, but might be better supported via plugins when support for it is available. Will cater for such a use case!

Hey @miguelisidoro, thought to update that it is now possible to do chat analytics by relying on events: https://react-chatbotify.com/docs/api/events
In particular, you might want to leverage on the following:

https://react-chatbotify.com/docs/api/events#rcbpostinjectmessageevent
https://react-chatbotify.com/docs/api/events#rcbstopstreammessageevent

It's possible to write a plugin for this but it is unlikely that such a plugin will be done soon 🥹


Update zio, zio-test, zio-test-magnolia, ... to 2.0.17 in main

About this PR
📦 Updates

dev.zio:zio
dev.zio:zio-test
dev.zio:zio-test-magnolia
dev.zio:zio-test-sbt

from 2.0.15 to 2.0.17
📜 GitHub Release Notes - Version Diff
Usage
✅ Please merge!
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

⚙ Adjust future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "dev.zio" } ]

Or, add this to slow down future updates of this dependency:
dependencyOverrides = [{
  pullRequests = { frequency = "30 days" },
  dependency = { groupId = "dev.zio" }
}]

labels: library-update, early-semver-patch, semver-spec-patch, commit-count:1

Superseded by #131.


Fix skinnedmesh

It seems that if there is a skinnedmesh ssr will break. I guess that's the issue.

Thanks, I'll look into the pr and fix it in the next release.

It should be fixed now, the issue was that I forgot to set the right material: https://github.com/0beqz/screen-space-reflections/commit/de0ac1a7f3e41292369e5376440b7803c91f7ff6#diff-a5040d75280b2e8f228dfdb046db84e2a2ad6d242029ad44830181d111144a2cR55


Documentation doesn't mention "address" parameter for sending to syslog server

My Ain was not sending messages to remote syslog server. I had to set "address" parameter which was missing in the documentation.

Still true.

Still true...


Update coredns to 1.9.3.

How to categorize this PR?

/area networking
/kind enhancement
What this PR does / why we need it:
Update coredns to 1.9.3.
Which issue(s) this PR fixes:
None.
Special notes for your reviewer:
Release note:

Update coredns to v1.9.3.

/invite @DockToFuture

/approve


bullet-featherstone: Support convex decomposition for meshes

🎉 New feature
Replaces #603
Depends on

https://github.com/gazebosim/sdformat/pull/1382
https://github.com/gazebosim/gz-common/pull/585

Summary
Supports convex decomposition on meshes. Bullet-featherstone implementation will parse the new mesh ~simplification~ optimization attribute introduced in https://github.com/gazebosim/sdformat/pull/1380, decompses the mesh into convex meshes, and builds btConvexHullShape collision shapes.
Compared to btGImpactMeshes (which is currently used for all meshes), the convex hulls seems to be more stable, do not have gaps between meshes (collision margins can be set to 1mm instead of 1cm), and some manual testing shows potentially faster performance (dependent on the number of submeshes generated)
Added test to verify that convex decomposition flag is parsed and valid collisions are generated.
Other changes:

the m_erp2 ~value is now only set when there are meshes in the scene. The param was reduced to improve stability in https://github.com/gazebosim/gz-physics/pull/600. I think we do not need to do it globally when there are no meshes in the world as the instability seems to only come from meshes.~ The value is also bumped up a little too prevent to much penetration - This will likely need more tuning as we do more testing with bullet.

To Test

Run gz sim with bullet-featherstone plugin and a world that has a model (e.g. Cordless Drill Simplified) that uses mesh decomposition:
gz sim -v 4 your_test_world.sdf --physics-engine gz-physics-bullet-featherstone-plugin

Checklist

[x] Signed all commits for DCO
[x] Added tests
[ ] Added example and/or tutorial
[ ] Updated documentation (as needed)
[ ] Updated migration guide (as needed)
[ ] Consider updating Python bindings (if the library has them)
[ ] codecheck passed (See contributing)
[ ] All tests passed (See test coverage)
[ ] While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

I think convex_decomposition and convex_hull operations should apply to the fusion of all submeshes, unless only a single submesh is specified, in which case it would act only on that submesh. In the unoptimized case, we could also consider merging to a single mesh shape instead of using btCompoundShape (this can happen in separate pull requests)

hmm ok to make this happen, we'll need to:

update sdf description - currently it explicitly states decomposition is for each submesh
add a new function to merge multiple common::SubMeshes into one (before calling gz::common::ConvexDecomposition with that one combined submesh)

I'll work on these changes

hmm ok to make this happen, we'll need to:

update sdf description - currently it explicitly states decomposition is for each submesh
add a new function to merge multiple common::SubMeshes into one (before calling gz::common::ConvexDecomposition with that one combined submesh)

I'll work on these changes

https://github.com/gazebosim/sdformat/pull/1386
https://github.com/gazebosim/gz-common/pull/588

I'm getting some unexpected penetration with convex_decomposition. I've attached the .sdf files.

I found that by setting a small m_globalCfm value, it's able to prevent this penetration, e.g.
diff --git a/bullet-featherstone/src/Base.cc b/bullet-featherstone/src/Base.cc
index ac66f574..80a04ced 100644
--- a/bullet-featherstone/src/Base.cc
+++ b/bullet-featherstone/src/Base.cc
@@ -49,6 +49,7 @@ WorldInfo::WorldInfo(std::string name_)
   // the penentration impulse depends on the erp2 parameter so set to a small
   // value (default in bullet is 0.2).
   this->world->getSolverInfo().m_erp2 = btScalar(0.02);
+  this->world->getSolverInfo().m_globalCfm = btScalar(0.001);

by default m_globalCfm is 0


[Feature Request] Add support of tags in search

Hello,
The search bar does not seem to search through tags.
I would like to be able to get posts having tags matching a given term.
For example, here is a post with several tags, including Hate

Here is the search result for the term hate

Hello,
yeah that's true.
So far I thought it might be enough to be able to find all posts belonging to a tag by clicking on the tag in the list view or/and in the tags page.


Test that EventStream's are present on ChangeSet after UnitOfWork operation

There was existing test coverage, so I'm closing this one.


feat: implemented email validation in the homepage newsletter

Description

Add email validation to the Subscribe Newsletter homepage.
Use AbstractAPI Email Validation, which provides 100 API requests per month.
Generalize the code for all three newsletter statuses: success, error, and invalid.

Related issue(s)
Fixes #2125
Implementation

Use AbstractAPI Email Validation, which provides 100 API requests per month

IMHO, we won't use any paid external service unless it is a Freemium tool (with large FREE limits, unlike 100 requests per month, which can be abused by even a single bot).

Use AbstractAPI Email Validation, which provides 100 API requests per month

IMHO, we won't use any paid external service unless it is a Freemium tool (with large FREE limits, unlike 100 requests per month, which can be abused by even a single bot).

Ah okay. Got it. I will switch to some other tool that's free with a high limit.
Also, I'm open to any member suggesting some tools.

Hi @AKACHI-4 , I did some research on Email verification tool and I found some tools (for free) :

check if email exists. . Did not speficy the number of verification request limit of validation. Its SaaS version is paid but for this open source version it's free.
verifalia. Stated that they doesnt have a verification limit, but having HTTP rate limits.

Hope it helps. Will update if I found more tools

Hey @RegretfulWinter, Thanks for this .. It means a lot to me. I will check out and commit changes ASAP.

I am considering using @chimanos/deep-email-validator. After reviewing the code and documentation, I found that this package consolidates regex, SMTP, and disposable mail checks. The package is free and can be downloaded from npm.
The reasons I chose not to go with the following options are:

check-if-mail-exists: While the Docker method seems viable, the problem is that we would have to keep a server running regardless of the current status of newsletter requests. This could result in extra processing as we would have to deploy it on a cloud for users to maintain.
verifalia : The API documentation is somewhat tangled and it's hard to obtain any fixed information regarding the API's use with the current request rate limit. It also throws an HTTP 429 Status Code when the limit is exceeded.

However, I am open to further suggestions for improvement.

Now, that's not good. I should have checked before making a decision... Results, I should continue my search and work on this issue.

With my search so far, it seems impossible to find a completely free email validation service. The best I've found offers 50 validations per day, which could easily be exhausted by bot spamming.
What could be the solution?
Perhaps using npm packages or creating something myself. For instance, I could use Rust code and the 'check-if-mail-exists' function, then deploy it. However, I must consider the worst-case scenario of handling 1 million validation requests per day. That's a significant load, and even my API might not be able to handle it without asking me to pay.
I suppose 50 validations per day might be sufficient. If not, I could use regex and SMTP check npm packages as an alternative.

verifalia. Stated that they doesnt have a verification limit, but having HTTP rate limits.

The part where they say "unlimited" is supposed to refer to concurrent verification jobs at a time, and they don't have a limit over that, which in no way corresponds with the count of requests a single account or user can make.
I logged in and found only those 50 daily credits tho.

@AKACHI-4 what's the status of this PR

closing this as there is no update from the contributor


[Bug]: Extension CD pipeline breaks after upgrading to 3.49.3

Please confirm that you have:

[X] Searched existing issues to see if your issue is a duplicate. (If you’ve found a duplicate issue, feel free to add additional information in a comment on it.)
[X] Reproduced the issue in the latest CLI version.

In which of these areas are you experiencing a problem?
Extension
Expected behavior
I can resume deployment of my extension in my CD pipeline
Actual behavior
I'm deploying a theme extension in a CD pipeline using github actions. My pipeline has worked fine until today when I got a message:
"error_message": "Upgrade your CLI version to run the deploy command.",

Fine, I upgraded from 3.45.4 to 3.49.3.
I reran the job and encountered this error:
Flag not specified:                                                         │
│                                                                              │
│  client-id                                                                   │
│                                                                              │
│  This flag is required in non-interactive terminal environments, such as a   │
│  CI environment, or when piping input from another process.                  │
│                                                                              │
│  To resolve this, specify the option in the command, or run the command in   │
│  an interactive environment such as your local terminal.

I don't see this documented anywhere, but I added the flag to my deployment command:
npm run deploy:shopify-frontend -- -f -client-id
The feedback just says flag, so I didn't add client-id=XXXX
I reran the job, and then encountered this deployment error:
Couldn't find shopify.app.lient-id.toml in extensions/XXXXXX.
I have never had this file before - also notice the likely spelling mistake in the error feedback (lient-id, not client-id). I don't see this file documented anywhere either...
What should this file contain? What do I need to do to ensure I can deploy my extension in a CD pipeline again?
Reproduction steps

npm run deploy:shopify-frontend -- -f

Operating System
ubuntu-latest
Shopify CLI version (check your project's package.json if you're not sure)
3.49.3
Shell
No response
Node version (run node -v if you're not sure)
No response
What language and version are you using in your application?
No response

Hi @eatoncw, thanks for raising up this issue. Right now, in your CD environment how do you set the api-key used to deploy?. I guess we have found a little issue because in the documentation you will see that the env variable SHOPIFY_API_KEY should be used but right now it's not working neither.
Please as a quick workaround, could you set the env variable SHOPIFY_FLAG_APP_API_KEY in your CD setup?, you should find it in the .env file or in the dashboard.
Please, let me know if it works for you.


Nav buttons after scrollable header

Need to add nav button after scrollable header + maybe make sticky nav after scrolling down? Page size looks big.

Another option - small fixed menu button when we scroll. But it could be annoying

Probably won't do it - with scroll for results size is okay


Better formatting for xcvm list

With many versions of Xcode installed, the list can appear pretty cluttered. Clean up the formatting or possibly format it into a table (if it looks better).

This has been started with the TableKit target that can make nicer formatted output. But there's still room for improvement in its rendering, like column titles being cutoff.
   ┃ Versio ┃ Build   ┃ Name
━━━╇━━━━━━━━╇━━━━━━━━━╇━━━━━━━━━━━━━━━━━━
   │ 10.1   │ 10B61   │ Xcode-10-1.app
   │ 10.3   │ 10G8    │ Xcode-10-3.app
   │ 11.7   │ 11E801a │ Xcode-11-7.app
   │ 12.3   │ 12C33   │ Xcode-12-3.app
 * │ 12.5.1 │ 12E507  │ Xcode-12-5-1.app
   │ 13.0   │ 13A233  │ Xcode-13-0.app


script for creating cluster and deploy openebs in azure

Signed-off-by: nsathyaseelan
What this PR does / why we need it:
This PR will gives the script for creatng aks cluster and setup OpenEBS in Azure
Special notes for your reviewer:
While running the above script it gives the below output and it creates the log file in the name of oebs_aks.log
output :
Installing Prerequisites...
Get:1 http://security.ubuntu.com/ubuntu xenial-security InRelease [102 kB]
Hit:2 http://archive.ubuntu.com/ubuntu xenial InRelease
Hit:3 http://archive.ubuntu.com/ubuntu xenial-updates InRelease
Hit:4 http://archive.ubuntu.com/ubuntu xenial-backports InRelease
Fetched 102 kB in 2s (42.9 kB/s)
Reading package lists... Done
Installing Azure CLI
Installed Azure CLI Version: (2.0.29)
Logging into Azure Account
Logged in Account name : admin@*****************
Creating Resource Group
Resource Group created in the name of : aks-openebs-zp3pvh35pf-rg
Creating AKS Cluster.....
AKS cluster created in the name of: aks-openebs-zp3pvh35pf-cluster
Getting credentials to connect aks cluster
Kubectl already Installed, Skipping
Creating Public IP.....
Associating Public IP to the Network Interface...
Installing iSCSI packages
The authenticity of host '<IP_ADDRESS> (<IP_ADDRESS>)' can't be established.
ECDSA key fingerprint is SHA256:YYaLJOEPUdRn50hlIs0+0qhOZMu6buaVD4ui5ybVI6c.
Are you sure you want to continue connecting (yes/no)? yes
Warning: Permanently added '<IP_ADDRESS>' (ECDSA) to the list of known hosts.
Get:1 http://security.debian.org jessie/updates InRelease [63.1 kB]
Ign http://deb.debian.org jessie InRelease
Get:2 http://deb.debian.org jessie-updates InRelease [145 kB]
Get:3 http://deb.debian.org jessie Release.gpg [2434 B]
Get:4 http://deb.debian.org jessie Release [148 kB]
Get:5 http://security.debian.org jessie/updates/main amd64 Packages [643 kB]
Get:6 http://deb.debian.org jessie-updates/main amd64 Packages [23.1 kB]
Get:7 http://deb.debian.org jessie/main amd64 Packages [9064 kB]
Fetched 10.1 MB in 33s (299 kB/s)
Reading package lists...
Reading package lists...
Building dependency tree...
Reading state information...
The following NEW packages will be installed:
open-iscsi
0 upgraded, 1 newly installed, 0 to remove and 39 not upgraded.
Need to get 296 kB of archives.
After this operation, 2052 kB of additional disk space will be used.
Get:1 http://deb.debian.org/debian/ jessie/main open-iscsi amd64 2.0.873+git0.3b4b4500-8+deb8u2 [296 kB]
debconf: delaying package configuration, since apt-utils is not installed
Fetched 296 kB in 5s (49.7 kB/s)
Selecting previously unselected package open-iscsi.
(Reading database ... 14826 files and directories currently installed.)
Preparing to unpack .../open-iscsi_2.0.873+git0.3b4b4500-8+deb8u2_amd64.deb ...
Unpacking open-iscsi (2.0.873+git0.3b4b4500-8+deb8u2) ...
Processing triggers for systemd (215-17+deb8u7) ...
Running in chroot, ignoring request.
Setting up open-iscsi (2.0.873+git0.3b4b4500-8+deb8u2) ...
invoke-rc.d: policy-rc.d denied execution of start.
update-rc.d: warning: start and stop actions are no longer supported; falling back to defaults
Running in chroot, ignoring request.
update-rc.d: warning: start and stop actions are no longer supported; falling back to defaults
Running in chroot, ignoring request.
Processing triggers for systemd (215-17+deb8u7) ...
Running in chroot, ignoring request.
The authenticity of host '<IP_ADDRESS> (<IP_ADDRESS>)' can't be established.
ECDSA key fingerprint is SHA256:3Tfg1N+lngSpzO3zKiE/eib8i0vNNYIKaOacHKW2h9w.
Are you sure you want to continue connecting (yes/no)? yes
Warning: Permanently added '<IP_ADDRESS>' (ECDSA) to the list of known hosts.
Get:1 http://security.debian.org jessie/updates InRelease [63.1 kB]
Ign http://deb.debian.org jessie InRelease
Get:2 http://deb.debian.org jessie-updates InRelease [145 kB]
Get:3 http://deb.debian.org jessie Release.gpg [2434 B]
Get:4 http://deb.debian.org jessie Release [148 kB]
Get:5 http://security.debian.org jessie/updates/main amd64 Packages [643 kB]
Get:6 http://deb.debian.org jessie-updates/main amd64 Packages [23.1 kB]
Get:7 http://deb.debian.org jessie/main amd64 Packages [9064 kB]
Fetched 10.1 MB in 38s (265 kB/s)
Reading package lists...
Reading package lists...
Building dependency tree...
Reading state information...
The following NEW packages will be installed:
open-iscsi
0 upgraded, 1 newly installed, 0 to remove and 39 not upgraded.
Need to get 296 kB of archives.
After this operation, 2052 kB of additional disk space will be used.
Get:1 http://deb.debian.org/debian/ jessie/main open-iscsi amd64 2.0.873+git0.3b4b4500-8+deb8u2 [296 kB]
debconf: delaying package configuration, since apt-utils is not installed
Fetched 296 kB in 6s (48.5 kB/s)
Selecting previously unselected package open-iscsi.
(Reading database ... 14826 files and directories currently installed.)
Preparing to unpack .../open-iscsi_2.0.873+git0.3b4b4500-8+deb8u2_amd64.deb ...
Unpacking open-iscsi (2.0.873+git0.3b4b4500-8+deb8u2) ...
Processing triggers for systemd (215-17+deb8u7) ...
Running in chroot, ignoring request.
Setting up open-iscsi (2.0.873+git0.3b4b4500-8+deb8u2) ...
invoke-rc.d: policy-rc.d denied execution of start.
update-rc.d: warning: start and stop actions are no longer supported; falling back to defaults
Running in chroot, ignoring request.
update-rc.d: warning: start and stop actions are no longer supported; falling back to defaults
Running in chroot, ignoring request.
Processing triggers for systemd (215-17+deb8u7) ...
Running in chroot, ignoring request.
Deploying OpenEBS operator...
Deploying OpenEBS Storage classes
Checking Pod status....
kubectl get pods --all-namespaces
NAMESPACE     NAME                                    READY     STATUS    RESTARTS   AGE
kube-system   heapster-2574232661-8bkfd               2/2       Running   0          1m
kube-system   kube-dns-v20-2253765213-2hjkj           3/3       Running   0          3m
kube-system   kube-dns-v20-2253765213-hwnc7           3/3       Running   0          3m
kube-system   kube-proxy-f1hz1                        1/1       Running   0          3m
kube-system   kube-proxy-lvz3b                        1/1       Running   0          3m
kube-system   kube-svc-redirect-92s8s                 1/1       Running   0          3m
kube-system   kube-svc-redirect-mpjpj                 1/1       Running   0          3m
kube-system   kubernetes-dashboard-2898242510-6gxwq   1/1       Running   0          3m
kube-system   tunnelfront-2851197899-tmssw            1/1       Running   0          3m

@ksatchit @yudaykiran please review this PR

Can this be accompanied by a brief note about how to use/run this script, what it does etc.., - preferably in a README?


Feature/prisma setup

Description
Prisma is setup and is deployed to my heroku account which can be used as the dev server, since docker is causing nothing but problems.
https://biobid-4efc34e917.herokuapp.com/default.
In the code that address is missing to prevent it to getting pushed to github since I couldn't get env files to work with it either.
Type of change

[X] New feature (non-breaking change which adds functionality)

Change Status

[X] Complete, tested, ready to review and merge

Checklist

[X] My code follows the style guidelines of this project
[X] I have performed a self-review of my own code
[ ] My code has been reviewed by at least one peer
[X] There are no merge conflicts

Excellent work Josh


Show points for family's events

Children born/died, siblings born/died, parent's died, spouse died, etc

I think that this is done, isn't it?

Yes! It is. Good catch.


Cannot use optional chaining with esproposal.optional_chaining=enable

With this  .flowconfig:
.*/build

[include]

[libs]

[options]
suppress_type=$FlowFixMe
suppress_comment= \\(.\\|\n\\)*\\$FlowFixMe
include_warnings=true
esproposal.class_static_fields=enable
esproposal.class_instance_fields=enable
esproposal.optional_chaining=enable
esproposal.nullish_coalescing=enable

[lints]
all=error
unclear-type=warn
sketchy-null=off
sketchy-number-and=off

I still get Error:(5, 13) Flow does not yet support method or property calls in optional chains. error from in this code:
// @flow

function test() {
  const a: ?string = ''
  const b = a?.trim()
}

Expected behaviour: Optional chains should yield no such errors with esproposal.optional_chaining=enable.

AFAIK that's known issue and a reason why this is still open: https://github.com/facebook/flow/issues/4303

Duplicate of #4303


NIFI-5318 Implement NiFi test harness: initial commit of nifi-testharness

All issues are fixed from the previous pull request comments.
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:

[x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?

[x] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

[x] Has your PR been rebased against the latest commit within the target branch (typically master)?

[x] Is your initial contribution a single, squashed commit?

For code changes:

[x] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
[ ] Have you written or updated unit tests to verify your changes?
[ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
[ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
[ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
[ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?

For documentation related changes:

[ ] Have you ensured that format looks appropriate for the output in which it is rendered?

Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.

Hi @lfrancke I've fixed the issues you noticed. Can you please review the current state?

Thanks! Unfortunately for some reason I can't see your new commit...
(I should maybe also add that I'm not a committer, I wast just interested in this PR)

@peter-gergely-horvath can you push that commit?

@MikeThomsen The pull request contains the latest changes; after @lfrancke had made his comments, I corrected the issues mentioned, nuked my whole fork and force-pushed my new version.
(I'm wondering what the preferred approach is for you, when there are some suggestions regarding a pull request: maybe it would be worth documenting this in NiFi dev manual?)

@peter-gergely-horvath the consensus seems to be just keep pushing new commits and let us do a squashed commit for you because that helps GitHub maintain the context of feedback in a review.

@MikeThomsen OK, in the future, I will follow that approach. For this pull request, please review as it is, since the current state contains everything in a squashed commit.

Hi @MikeThomsen I intentionally have no test configuration in the project (at least for now): they are merely samples of what can be done, but they should not be executed as part of the core NiFi build.
NiFi is a beast, starting and stopping it takes some time, I do not want to add that to the each NiFi build.
Please create a new Maven project quickstart project (that will have testing configuration enabled) and add the following (replacing ${nifi version} with the current one) to the dependencies:
<dependency>
	<groupId>org.apache.nifi:</groupId>
	<artifactId>nifi-testharness</artifactId>
	<version>${nifi version}</version>
</dependency>

once done, you can take the samples into your own project, where you can experiment with the test harness.
I understand piggybacking on the tests directory is maybe not the perfect place to deliver samples, but given the circumstances I think it is acceptable and could maybe be improved in the future.

That makes sense: I'll look into that... once I have a tiny bit of time...

Hi @MikeThomsen sorry for the delay, I have been just very busy. It turns out there have been some changes in the flow XML format, which I have fixed against the latest GA version: now all of the tests are executed properly.
I have also introduced strict version checking: the NiFi version referenced in the flow file is checked against the actual version of the NiFi distribution used so that we can avoid confusion in the future.
If a user tries to run the test harness with a flow created using a different version of NiFi than the one actually used, this will fail fast, preventing a non functioning installation leaving the user being confused why it does not work properly.

Hi @MikeThomsen sorry for the delay, I have been just very busy.

Thanks. I've got a lot on my plate as well, but will try to find some time early this week to review.

@MikeThomsen This is kind of tricky: NiFi flows refer the precise version of NiFi within the flow XML file, so you have something like this for the processor definitions:
      <class>org.apache.nifi.processors.standard.GetHTTP</class>
      <bundle>
        <group>org.apache.nifi</group>
        <artifact>nifi-standard-nar</artifact>
        <version>1.7.1</version>
      </bundle>

When you export a flow file to test, I would expect the you to use precisely the same NiFi version as the one used to export the flow file.
I think there is a little bit of confusion here: please note that these tests do not test the test-harness. The test-harness itself is not tested (kind of a chicken-and-egg issue): these test cases are merely samples, which are referenced in the documentation: they demonstrate how an end-user could create test cases for his/her own flows.
Please download the ZIP of NiFi 1.7.1 to the Downloads directory within your user home (referenced by org.apache.nifi.testharness.samples.Constants#NIFI_ZIP_DIR as
new File(System.getProperty("user.home"), "Downloads") ) and try running the test case again.

Closed an created a new pull request for the same issue from a clean state: https://github.com/apache/nifi/pull/3165


Implement ContentStorageAPI

What was wrong?
We need a way to store content, both in a persistent way, and ephemeral manner.
How was it fixed?
Implemented the ContentStorageAPI.
This includes both an in-memory version and a version that uses the filesystem for persistence.
Cute Animal Picture

Hold off on review, still have a TODO to be done.

This is ready for review


Added modulefiles support

Added modulefiles support for Linux.

documentation?
tests?

Changes looks ok. But I still not see tests and changes in docs.

/intelci: run set infra_branch:dev/mariapet-modulefiles-ci

test part will be merged in parallel.  Docs -i suggest to do this in parallel via another PR.


Clarify SOP for sources of definitions for reaction terms

Questions from @pgaudet

Is there a preference whether we add the EC or RHEA ID as the def xref?

proposal:

The definition xref should describe the source of the definition. If RHEA and EC are the same, use RHEA. In cases where the definition is too divergent from RHEA, then use the appropriate source: EC, or a PMID.
( I usually do not keep both, but I noticed Raymond keeps both.)

Agreed, in all cases the definition should reflect the provenance. If we get from EC, then use the EC. If we get from RHEA, use the RHEA. If a curator altered this via their own interpretation, then use the curator in addition to the sources they used.
These should be universal rules for all terms in all ontologies.

Is there a need/desire to preserve def xrefs like "[GOC:pz]" if the revised def is based solely on EC/RHEA?
If we change the definition, then we should remove the GOC:curator xref, since they are not the source anymore.

I would assume if a curator xref is there then they did something other than copy the text over, and we should keep it. That assumption may not universally hold but I don't think there is a priority to go back and remove these now.
Carried on from:
Originally posted by @pgaudet in https://github.com/geneontology/go-ontology/issues/27560#issuecomment-2048042201
https://wiki.geneontology.org/Guidelines_for_GO_textual_definitions
I added this to the next ontology call to get some clarification.

@cmungall and I went over this together. For enzymes:

If there is a RHEA that is an exact match to the GO term, use the RHEA definition and use RHEA as the definition cross-reference.
If there RHEA is broader and the EC corresponds to the GO term, use the EC definition(see note 1)  and EC as the definition cross-reference.
If neither match, use a PMID.
If the activity is not describe neither in RHEA not in EC, it may be appropriate to use another source, such as MetaCyc, UM_BBD, but these cases should be rare.

Notes:

EC definitions must be edited:
1.1 in GO, we use =rather than <=>or other notations
1.2 In GO, we dont wrap charges in parentheses (see also https://wiki.geneontology.org/Guidelines_for_GO_textual_definitions#Guidelines_on_chemical_nomenclature)
The definition cress-reference should usually contain a single database source; otherwise it is ambiguous which source was used.
If a curator modified the definition significantly, they should also add themselves as definition cross-reference (GOC:initials as described in https://github.com/geneontology/go-site/blob/master/metadata/users.yaml)

And for the case where we replace/update an existing enzyme definition that has a 'GOC:initials' xref with a new definition that exactly matches the RHEA/EC, then I'd say we should remove the old 'GOC:initials' and just have the RHEA or EC def xref.
Would you agree?

@sjm41 Let's discuss this on the ontology call tomorrrow.

I also propose we dont keep general textbook references, as these are almost untraceable, even if you know the edition (for eg
https://isbnsearch.org/isbn/0201090910 in fructose-1-phosphate aldolase activity

as these are almost untraceable,

But sources like Wikipedia that are freely editable provide an illusion of traceability - yes, that definition has a stable URL but that URL can point to a convoluted history of edits whose changes to the meaning of the definition can be complicated and hard to sort out, and may well lead ultimately back to that textbook. This is not an argument against Wikipedia, only a doubt about the possibility of coming up with sources that are truly transparent, stable, and accessible. Sorry, this is a tangent to the basic plan spelled out above, which looks like a plausible way to minimize disorder.

Updated https://wiki.geneontology.org/Guidelines_for_GO_textual_definitions#Cross-references_for_definitions
@raymond91105 @deustp01 @ValWood @sjm41 @cmungall @thomaspd
Feedback is welcome!

Sometimes it's difficult to find a better worded definition than wiki's.
Should we adopt version-specific Wiki reference practice? If so, what is the format, Wikipedia:Endocytosis&oldid=1210084552?


Enable directory and file filtering to run specific tests

An additional benefit of this, is that all of the crison data files are organised into sub-directories

Directory filtering is done.  File filtering is still to do.


deduce type: adding support for bool

Hi @galeone
Thanks for your work. Did you check that your modification actually works?
Your modification would be interesting to directly create boolean tensors from c++ bool data structures. Nevertheless, the tensor constructor uses std::vector, which is specialized for std::vector<bool>. From the documentation:

The specialization has the same member functions as the unspecialized vector, except data, emplace, and emplace_back, that are not present in this specialization.

I tried your code in my computer and I couldn't make it work, as I can't call values.data() on a vector of bools.
Perhaps the solution would be to create specialized constructors that accept a std::vector<bool>, convert them to unsigned char and then call the correct funtion.
Thanks!
Sergio

Uhm that's really strange - I'm using that code right now and it's working fine.
I wrapped your library in an unreal engine plugin, using it in this way (my wraper name is TFTensor)
template <typename T> TArray<T> TFTensor::Data() const {
    auto data = _tensor->get_data<T>();
    TArray<T> ret;
    ret.SetNumUninitialized(data.size());
    for (SIZE_T i = 0; i < data.size(); ++i) {
        ret[i] = data[i];
    }
    return ret;
}

I also defined the operator overloading for == and != and when I used it in this way
        It("It should be possiblie to compare the tensors", [this] {
            TFTensor x{1.}, y{2.};

            auto no = x == y;
            auto yes = x != y;

            TestTrue("x == y is false", !no.Data<bool>()[0]);
            TestTrue("x != y is true", yes.Data<bool>()[0]);
        });

It's working fine

Interesting,
Did you try to create a tensor directly from boolean data? Like:
auto t = cppflow::tensor({true, true, false});

In that case, effectively, it doesn't work because std::vector has no .data. :exploding_head:

Exactly hahaha
I guess that to make it work on that case we would need to do more changes :disappointed:.


Simpler logic - not needed to nest conditions

Description
Simpler logic - not needed to nest conditions
Type of change

[ ] Refactor
[ ] New feature
[ ] Bug fix
[ ] CVE fix
[x] Optimization
[ ] Documentation Update
[ ] Configuration Update
[ ] Bump-up dependent library

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (bd4265b) 96.09% compared to head (8195068) 91.55%.
Report is 28 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #440      +/-   ##
==========================================
- Coverage   96.09%   91.55%   -4.54%
==========================================
  Files          32       32
  Lines        1075     1090      +15
==========================================
- Hits         1033      998      -35
- Misses         42       92      +50

Files
Coverage Δ

ols/app/models/config.py
97.74% <100.00%> (+0.03%)
:arrow_up:

... and 3 files with indirect coverage changes


Too many open files

my server log throw this exception :
1/27/2020 11:11:19 AM [Info] Listener socket restarting
1/27/2020 11:11:19 AM [Info] Server started at wss://<IP_ADDRESS>:8181 (actual port 8181)
1/27/2020 11:11:19 AM [Info] Listener socket restarted
1/27/2020 11:11:20 AM [Error] Listener socket is closed System.AggregateException: One or more errors occurred. (Too many open files) ---> System.Net.Sockets.SocketException: Too many open files
  at System.Net.Sockets.SocketAsyncResult.CheckIfThrowDelayedException () [0x00014] in <2703bbaa0a6e4686b6033c2dddb1a363>:0
  at System.Net.Sockets.Socket.EndAccept (System.Byte[]& buffer, System.Int32& bytesTransferred, System.IAsyncResult asyncResult) [0x0002c] in <2703bbaa0a6e4686b6033c2dddb1a363>:0
  at System.Net.Sockets.Socket.EndAccept (System.IAsyncResult asyncResult) [0x00000] in <2703bbaa0a6e4686b6033c2dddb1a363>:0
  at Fleck.SocketWrapper+<>c__DisplayClass25_0.<Accept>b__0 (System.IAsyncResult r) [0x0001a] in <a67c2a4ea08e45378c68140f7d0916f5>:0
  at System.Threading.Tasks.TaskFactory`1[TResult].FromAsyncCoreLogic (System.IAsyncResult iar, System.Func`2[T,TResult] endFunction, System.Action`1[T] endAction, System.Threading.Tasks.Task`1[TResult] promise, System.Boolean requiresSynchronization) [0x0000f] in <285579f54af44a2ca048dad6be20e190>:0
   --- End of inner exception stack trace ---
---> (Inner Exception #0) System.Net.Sockets.SocketException (0x80004005): Too many open files
  at System.Net.Sockets.SocketAsyncResult.CheckIfThrowDelayedException () [0x00014] in <2703bbaa0a6e4686b6033c2dddb1a363>:0
  at System.Net.Sockets.Socket.EndAccept (System.Byte[]& buffer, System.Int32& bytesTransferred, System.IAsyncResult asyncResult) [0x0002c] in <2703bbaa0a6e4686b6033c2dddb1a363>:0
  at System.Net.Sockets.Socket.EndAccept (System.IAsyncResult asyncResult) [0x00000] in <2703bbaa0a6e4686b6033c2dddb1a363>:0
  at Fleck.SocketWrapper+<>c__DisplayClass25_0.<Accept>b__0 (System.IAsyncResult r) [0x0001a] in <a67c2a4ea08e45378c68140f7d0916f5>:0
  at System.Threading.Tasks.TaskFactory`1[TResult].FromAsyncCoreLogic (System.IAsyncResult iar, System.Func`2[T,TResult] endFunction, System.Action`1[T] endAction, System.Threading.Tasks.Task`1[TResult] promise, System.Boolean requiresSynchronization) [0x0000f] in <285579f54af44a2ca048dad6be20e190>:0 <---

1/27/2020 11:11:20 AM [Info] Listener socket restarting
1/27/2020 11:11:20 AM [Info] Server started at wss://<IP_ADDRESS>:8181 (actual port 8181)
1/27/2020 11:11:20 AM [Info] Listener socket restarted
1/27/2020 11:11:21 AM [Error] Listener socket is closed System.AggregateException: One or more errors occurred. (Too many open files) ---> System.Net.Sockets.SocketException: Too many open files
  at System.Net.Sockets.SocketAsyncResult.CheckIfThrowDelayedException () [0x00014] in <2703bbaa0a6e4686b6033c2dddb1a363>:0
  at System.Net.Sockets.Socket.EndAccept (System.Byte[]& buffer, System.Int32& bytesTransferred, System.IAsyncResult asyncResult) [0x0002c] in <2703bbaa0a6e4686b6033c2dddb1a363>:0
  at System.Net.Sockets.Socket.EndAccept (System.IAsyncResult asyncResult) [0x00000] in <2703bbaa0a6e4686b6033c2dddb1a363>:0
  at Fleck.SocketWrapper+<>c__DisplayClass25_0.<Accept>b__0 (System.IAsyncResult r) [0x0001a] in <a67c2a4ea08e45378c68140f7d0916f5>:0
  at System.Threading.Tasks.TaskFactory`1[TResult].FromAsyncCoreLogic (System.IAsyncResult iar, System.Func`2[T,TResult] endFunction, System.Action`1[T] endAction, System.Threading.Tasks.Task`1[TResult] promise, System.Boolean requiresSynchronization) [0x0000f] in <285579f54af44a2ca048dad6be20e190>:0
   --- End of inner exception stack trace ---
---> (Inner Exception #0) System.Net.Sockets.SocketException (0x80004005): Too many open files
  at System.Net.Sockets.SocketAsyncResult.CheckIfThrowDelayedException () [0x00014] in <2703bbaa0a6e4686b6033c2dddb1a363>:0
  at System.Net.Sockets.Socket.EndAccept (System.Byte[]& buffer, System.Int32& bytesTransferred, System.IAsyncResult asyncResult) [0x0002c] in <2703bbaa0a6e4686b6033c2dddb1a363>:0
  at System.Net.Sockets.Socket.EndAccept (System.IAsyncResult asyncResult) [0x00000] in <2703bbaa0a6e4686b6033c2dddb1a363>:0
  at Fleck.SocketWrapper+<>c__DisplayClass25_0.<Accept>b__0 (System.IAsyncResult r) [0x0001a] in <a67c2a4ea08e45378c68140f7d0916f5>:0
  at System.Threading.Tasks.TaskFactory`1[TResult].FromAsyncCoreLogic (System.IAsyncResult iar, System.Func`2[T,TResult] endFunction, System.Action`1[T] endAction, System.Threading.Tasks.Task`1[TResult] promise, System.Boolean requiresSynchronization) [0x0000f] in <285579f54af44a2ca048dad6be20e190>:0 <---

the server do a restarting none stop
i see the  System.Net.Sockets.SocketException (0x80004005): Too many open files log, in my knowledge, its related of how many client is connected and how many opend file can be in the system
but this is the test server , and there is only 5 clients.
so i was thinking that the problem maybe the server doesn't disconnect the old clients after a timeout, i test that with the following process:
i connect a client via ws (or wss )
after that , i manage  to disconnect the client without sending the goodbye , (Ctrl+C).
i waited to see if the client will disconnect , and that dosent happen .
any help ?

Always the same issue ... Any help?

it's more than one year that I'm having these issues and no one answered ...


Added quiet mode for CLI

Signed-off-by: Lesan Tudor<EMAIL_ADDRESS>

@TudorLesanHP please fix issues and add test before pull request..

@orius123 or @avimora  can you review this too?

fixes #64

@meirwah fixed

@orius123 please review this too...

more tests are needed here..
where are tasts for the async?

@tudorlesan please update this branch...
@orius123 / @avimora  can you review this too?

@avimora can you review this too?

@tudorlesan please update branch...

so :+1: to merge this...

fixes #64


Add a blog_path(name=nil) helper

There are helpers to link to calendar pages, tag pages, but not the blog index itself.

I don't think there is a canonical blog path. You could list the full list of posts on any page.
Seems like a better fit for a helper specific to your project:
def blog_page
  "/blog/"
end

Unless I'm missing something,

Well, I assumed single or multiple blog configurations with prefixes could use one that would return the prefix used for that particular blog.
But might be a not super-necessary thing and more of a nice to have.

On 01 Jun 2015, at 19:43, Thomas Reynolds<EMAIL_ADDRESS>wrote:
I don't think there is a canonical blog path. You could list the full list of posts on any page.
Seems like a better fit for a helper specific to your project:
def blog_page
"/blog/"
end
Unless I'm missing something,
—
Reply to this email directly or view it on GitHub.

I'm going to close this, but I totally get your point. I think if we add a "root template" option or something similar to the calendar path options, this would make a lot more sense.
I've posted to twitter to see how many other users have a similar use-case. We'll see.


Beta testing

Hi, i really would like to test your alexa skills with my xbox one kodi setup.  I am living in Germany.
Email is<EMAIL_ADDRESS>

https://github.com/kodi-connect/kodi-connect/blob/master/tutorial-alexa/readme.md


proxy: add support for proxy authentication with user-specified header values

Yea, this seems good to me. CI found an unused binding for Socks5 { .. } that needs fixing.


Resize token embedding.

Hi,
Are there any methods to resize a pretrained models after I add in new vocabulary?
Thanks in advance!

Hi @hungphongtrn thanks for creating the issue. We don't currently have any such methods in the library, but I'm curious to know more about what you have in mind here. Is the idea to append additional indices to the embedding for an existing vocabulary? If so, how would the new indices be initialized -- randomly, or from some other set of weights that can be passed in? Similar question for the final projection back to the vocab dimension since this would need to be updated as well.