Fix code example

The Leaflet L.LatLng() function sets the lat and lng functions on itself, then returns undefined.
This causes ember to throw and error, because location is a required parameter, and it is being set to undefined.
To get the actual created LatLng object, we need to use new L.LatLng().
This change is tested and working on Ember 2.8, and Leaflet 3.0.1

@ashleysommer It seems that this is a great piece of work. Unfortunately i don't have any app to test that properly right now. Can you confirm that the supplied changes would work with the latest version of ember-leaflet? Are the tests passing for it locally? Recently i had some issues with tests in ember-leaflet-marker-cluster after upgrading it to use ember-composability-tools. Can you confirm that all tests still pass?

My apologies, I accidentally committed a lot more changes to this PR than I meant to. I have reverted it back to just the one commit.
This PR is simply the fix in the code example in README
There will be a separate, much larger PR in the next day or so, which will address compatibility with ember-leafler 3.0.2

@ashleysommer you have deleted ember-cli-htmlbars from dependencies in package.json, because of that ember doesn't start. There is a message:

Addon templates were detected, but there are no template compilers registered for ember-leaflet-layer-control. Please make sure your template precompiler (commonly ember-cli-htmlbars) is listed in dependencies (NOT devDependencies) in ember-leaflet-layer-control's package.json.

If you restore this line, everything works well (ember-leaflet 3.0.5).

@jpalach Are you referring to the changes in PR here: #4?
This is a fix for a code example, there are no changes to dependencies in this PR. If there is an issue with PR  #4, move the discussion there please.

Sorry, my bad. It is about https://github.com/canufeel/ember-leaflet-layer-control/pull/4


Address Field Fixed #6312

Issue Reference
Link: https://github.com/bagisto/bagisto/issues/6312

@devansh-webkul
The customer should not be able to place the order without selecting any shipping method. Please find the screen recording Here

@devansh-webkul
The address should not save without filling in the address details. Please find the screen recording Here

@devansh-webkul
The customer is not able to edit the address. Please find the screen recording Here

@devansh-webkul
The place order button is disabled also after filling all the required fields. Please find the screen recording Here


SMUI Integration

This PR integrates SMUI (https://github.com/querqy/smui) in Chorus for Elasticsearch.
"SMUI is a tool for managing Solr-based onsite search" (see https://querqy.org/docs/smui/). So it has its limitations in an Elasticsearch-based environment.
Synonyms and UP/DOWN rules have been successfully tested using the Elasticsearch specific syntax of the Querqy rules in SMUI.
Future Katas will illustrate working with SMUI within Chorus for Elasticsearch in more detail.

This looks great, however I am having a problem where keycloak is spinning on my laptop...   Nervous to merge this till I get that sorted!

That makes absolutely sense!
Can you check the logs and paste or attach them to this PR? I'm wondering whether this is the same keycloak issue that I experienced.

This looks great, however I am having a problem where keycloak is spinning on my laptop... Nervous to merge this till I get that sorted!

I had a problem with keycloak too. If I remember correcly now, adding the following line to "/etc/hosts" fixed it on my Ubuntu 20.04 System with Docker version 20.10.7, docker-compose version 1.25.0.


org.apache.spark.api.python.PythonException: 'ValueError: Did not find word ' ' in the list of tokens although it is expected to be found'

We are running Presidio using spark but though we are replacing all unicode and new line in text using below regex we are getting Value Error error from the job. Please help us on this and let us know the solution to fix this.
"'ValueError: Did not find word ' ' in the list of tokens although it is expected to be found'"
Regex used to replace unicode and other space character.
re.sub(r'\t|\u00A0|\u1680|\u2000|\u2001|\u2002|\u2003|\u2004|\u2005|\u2006|\u2007|\u2008|\u2009|\u200A|\u202F|\u205F|\u3000|\n',' ',str(text))
Please reply us on this.

Kindly give us a reply team.

Could you please create a reproducible example? It's difficult to say where the issue is.

omri374
Could please let us know which entity type in below list will take more time to detect or have more of complex pattern match.
since we are implementing  presidio on a larger data(GB size) in order to achieve throughput time. We are planning to limit the entity list as per complexity & its processing time.
List of Entities
https://microsoft.github.io/presidio/supported_entities/

Hi, the NER models (Spacy or others) are the usual suspects, and the phone-number recognizer which compares each text to a large set of formats is another. Best thing to do would be to run a profiler.
On the spaCy side you could consider using a smaller model (e.g. en_core_web_sm which might be less accurate but faster), and for the phone numbers you could configure it to look up phone numbers belonging to less countries.

Thanks https://github.com/omri374 do we have any other such PII category. Shall we consider IBAN code in the complex list.

Consider IBAN as a recognizer that takes longer than others? Could be. Do you have a list of entities you are expected to have in your dataset?

omri374
Since our spark run are taking time. So we are trying to reduce the entities to get some less run time.
so we are looking at least for some basic hashing to happen in our dataset.
May be we can implement only Numeric PII entities alone for multiple languages.
{'CREDIT_CARD','EMAIL_ADDRESS','PHONE_NUMBER','PASSPORT','SSN','DRIVER_LICENSE/MEDICAL','BANK_NUMBER', 'IP_ADDRESSS','ITIN'}
Its good if we add some more simple entities into above list too.


ControlCenter DataDir Creation when custom

Description
Fix issue with Control Center when defining a custom DataDir and the directory needs to be created.
Type of change

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

How Has This Been Tested?
Test Lab Env
Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] Any dependent changes have been merged and published in downstream modules

Can we close this one, as it is handled here: https://github.com/confluentinc/cp-ansible/pull/206

Other solution resolved in #206


n_epochs does not work as an argument.

I gave a model n_epochs as 5, but it is calculating 14 epochs as usual.

It seems training epochs are always 14 and we can tune validation epochs.


Fixes for jupyterlab-chart-editor

Smooths the way for https://github.com/plotly/jupyterlab-chart-editor/pull/24

looks good 💃


Ux sync public callbacks

Description
Add callback to be used when filling the nbgl_contentActionCallback_t of nbgl_content_t structures used with the ux_sync_genericReview function. It will be called to confirm or reject a flow when the user touches a button (e.g. with nbgl_contentInfoButton_t) or long press button (e.g. with nbgl_contentInfoLongPress_t). The callback is triggered and is passed the token of the button that was touched. The button used to confirm the flow should have the token FIRST_USER_TOKEN. Other tokens will be considered as rejection of the flow.
Changes include

[x ] New feature (non-breaking change that adds functionality)

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Please upload report for BASE (master@2e56806). Learn more about missing BASE report.

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #705   +/-   ##
=========================================
  Coverage          ?   60.19%
=========================================
  Files             ?       12
  Lines             ?     1726
  Branches          ?        0
=========================================
  Hits              ?     1039
  Misses            ?      687
  Partials          ?        0

Flag
Coverage Δ

unittests
60.19% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


simple script to train tf model

This seems like great code, I'm just having a simple problem right now.  I have gotten all of the prerequisites installed on an AWS gpu-enabled machine via a conda environment, installed "app" as a python package via pip, and then I get a little stuck.  I was able to run the code in app/main.py after making some hacks in that file.  My question is simple: What is the simplest way to train your model; what are the command line arguments?  Thanks!

Hi, the app is written so you would need to run it as module. such as python3 -m app.main to train, python3 -m app.main eval to predict based on most recent checkpoint. Sorry there hasn't been much documentation around it.


Scheduled Jobs do not respect Time Zones after first run.

Environment

Nautobot version (Docker tag too if applicable): 1.6.17
Python version: 3.11
Database platform, version: Postgres 15
Middleware(s): N/A

Steps to Reproduce

Configure TIME_ZONE as Europe/Berlin (UTC+2) in nautobot_config.py
Have that mounted in every component (App, Worker, Celery Beat)
Schedule a Job to run daily at 10:00am

Expected Behavior
Scheduled Job to run daily at 10:00am Berlin's time.

Observed Behavior
First run of the Job runs correctly at 10:00am Berlin's time. Subsequent runs were at 8:00am Berlin's time.
Looks like Celery Beat, after the 1st run, is scheduling the Jobs based on time stored in DB (which is in UTC), ignoring the time zone's difference.
'last_run_at': datetime.datetime(2024, 4, 18, 6, 0, 0, 303339, tzinfo=<UTC>),
'name': 'gerasimos-test',
'one_off': False,
'queue': 'default',
'start_time': datetime.datetime(2024, 4, 17, 8, 0, tzinfo=<UTC>),
'task': 'nautobot.extras.jobs.scheduled_job_handler',
'total_run_count': 4,

Another thing I noticed, is that the total run count is double of the actual runs.

Quick update regarding the above. Looks like that if you configure the Scheduled Jobs with custom interval and add the crontab to run at specific time daily, everything works as expected. Meaning scheduling the above job but with the following:
'crontab': '0 10 * * *',
 'interval': 'custom',

the Job is scheduled at 10:00am Berlin's time, respecting the time zone as shown below:
'last_run_at': datetime.datetime(2024, 4, 22, 8, 0, 0, 604761, tzinfo=<UTC>),
 'start_time': datetime.datetime(2024, 4, 19, 10, 0, tzinfo=<UTC>),

I hope this helps to identify the issue. Keep in mind, still the total run count is double the actual.

See also #3349

Looks like the issue may be that our ScheduledJob.to_cron() and ScheduledJob.get_crontab() methods are not properly timezone aware (as alluded to originally in https://github.com/nautobot/nautobot/issues/3349#issuecomment-1492567578). Likely approach to fixing this:

Add a TimezoneField to the ScheduledJob model and set it based on TIME_ZONE when creating the ScheduledJob. (This appears necessary because with our default of USE_TZ=True, DateTimeField always converts a provided datetime to UTC before storing to the database, losing important context like DST).
to_cron() for DAILY and WEEKLY ScheduledJobs needs to retrieve the timezone and pass it through to get_crontab as an additional parameter
get_crontab() needs to either pass the timezone's nowfun when creating a schedules.crontab() OR switch to creating a celery-beat TzAwareCrontab instead.

Will need to test with:

TIME_ZONE = utc
TIME_ZONE = Americas/New York (with/without DST in effect)
changing TIME_ZONE after creating a ScheduledJob and making sure the original timezone of the job remains in effect.


(PDB-3209) Bump clj-parent to 0.3.0

This includes a new version of trapperkeeper-metrics that fixes a bug
affecting PuppetDB. Specifically when requesting many metrics via
POST, a stream closed exception would occur. Bumping to 0.3.0 of
clj-parent will fix that.

Test PASSed

CLA signed by all contributors.


How can we use injectScript to getServersideProps from remotes and enable server side render in Nextjs app

Currently our app uses NextFederationPlugin to implement Micro Frontend. We have two micro apps

frame - a container to host pages exposed from product
product - a remote app exposes page components in next.config.js

We want to use injectScript in getServerSideProps to get the page component's props in frame. But we get errors related to webpack and we have no idea how to debug this. We wonder if the next-mf team is making injectScript work with server side render and within getServersideProps any time soon .

@yululu1234 not sure if I can understand your issue fully but I can relate it to mine which I got it working some days back. Please check https://github.com/gitneeraj/nextjs-mf-host/blob/main/pages/[...slug].js if it helps at all.
Here the slug page dynamically loads the federated page and executes its GSSP.

Open a PR, I'd gladly take in a utility export in my next plugin.

@gitneeraj does your solution render on server side?

@alibek-gao Honestly I haven't checked for SSR with my above approach(as am occupied with another project) and I don't think it would work as I get the module client side.
I also noticed you linked a beta PR, curious to know if that solves the SSR as well?

@gitneeraj yes, it works, but it has a room for improvement

@alibek-gao May I know why your PR was closed? Any critical issue?

@gitneeraj I removed PathToRemoteMap data structure, because it adds unnecessary complexity and the possibility of memory leaks.

@alibek-gao I pulled in your latest from the beta PR branch and it throws this error

I guess the pathResolver should return the remote and the module path( Eg: remoteApp & ./pages/contact) at this line
https://github.com/module-federation/universe/pull/839/files#diff-8e23c4736059c81a4d63b1c6db4a1555d7249da5ddc4d3321de605ff6a80c9a9R65

current version of nextjs-mf has import issue with injectScript
I did not find solution, only workaround:
https://github.com/module-federation/universe/blob/3f951cdb7b9b934c3ce756d0df703a2d444a4140/apps/3000-home/pages/[...slug].js

@alibek-gao replacing pathResolver with matchFederatedPage works well as it returns the correct remote and module path. defaultPathResolver returns the incorrect values for me to be used in injectScript. Was this tried before?
Here is the working SSR repo https://github.com/gitneeraj/nextjs-mf-host/blob/main/pages/[...slug].js#L14

@gitneeraj could you give me an example

defaultPathResolver

getMatchedPage

path
remoteContainer
modulePath
remoteContainer
modulePath

..
..
..
..
..

@alibek-gao
Path: /contact
defaultPathResolver

remoteContainer: contact
modulePath: ./index

getMatchedPage

remoteContainer: remote1
modulePath: ./page/contact

I apologize for the confusion, but I'd like to clarify a few things. Are you experiencing problems with version 6 but not with version 7, or is it the other way around?
Given that version 7 is a substantial overhaul, I'm particularly interested in knowing whether the beta versions have brought about any improvements or introduced any issues.


Possible to set custom headers in the response?

Is it currently possible to set a custom header in the response, for example, Set-Cookie?

Custom headers are not directly supported, if you need this then add the header to the specification, or solve it with middelware.
What to you need Set-Cookie for?

The question was inspired by the way Medusa implements auth for their ecommerce API. They support cookie-based auth by sending a request to /auth/session, which returns a Set-Cookie header after successful authentication. However, there is no immediate use case on our side since, for the time being, we only support JWT tokens and API tokens.


Please check the url and the case when user pass in a single name

Can you please clarify the issue?

like when I call getGenders('Peter'), the script will crash. And I found the example url at https://genderize.io is follow:
GET https://api.genderize.io/?name=peter

This was because of updates to the API. This was fixed with the last commit.


Unzip prompts when overwriting existing files.

Fixing it by force overwriting on top of existing files.

@gregg-miskelly @caslan


[BUG] Changing json file marks it as corrupt

VSCode Version: 1.490 (User Setup)
OS Version: Windows NT x64 10.0.18363

Steps to Reproduce:

Create a C++ project
Generate a json files
Change contents of the json file
Run the program
You will then get an error saying that the file type is not recognized

Does this issue occur when all extensions are disabled?: No

@ANF-Studios  Please comment the list of extensions related to JSON in VS code

Please add a screenshot of the error dialog.
Also please run with any extensions. Likely the error is from an extension and an issue need to be filed against the extension.

@ANF-Studios Please comment the list of extensions related to JSON in VS code

It happens with the C/C++ Extension by Microsoft (ms-vscode.cpptools)

Please add a screenshot of the error dialog.

I copied the terminal and removed some personal details.
> Executing task in folder Project: cl.exe /Zi /EHsc /Fe: 'c:\Users\<Username>\source\VSCode\Project\.vscode\tasks.exe' 'c:\Users\<Username>\source\VSCode\Project\.vscode\tasks.json' <

cl.exe : The term 'cl.exe' is not recognized as the name of a cmdlet, function, script file, or operable program. Check the spelling of the
name, or if a path was included, verify that the path is correct and try again.
At line:1 char:1
+ cl.exe /Zi /EHsc /Fe: 'c:\Users\<Username>\source\VSCode\Proj...
+ ~~~~~~
    + CategoryInfo          : ObjectNotFound: (cl.exe:String) [], CommandNotFoundException
    + FullyQualifiedErrorId : CommandNotFoundException

The terminal process "C:\WINDOWS\System32\WindowsPowerShell\v1.0\powershell.exe -Command cl.exe /Zi /EHsc /Fe: 'c:\Users\<Username>\source\VSCode\CCPlayground\.vscode\tasks.exe' 'c:\Users\<Username>\source\VSCode\Project\.vscode\tasks.json'" terminated with exit code: 1.

Terminal will be reused by tasks, press any key to close it.

> Executing task in folder Project: cl.exe /Zi /EHsc /Fe: 'c:\Users\<Username>\source\VSCode\Project\.vscode\tasks.exe' 'c:\Users\<Username>\source\VSCode\Project\.vscode\tasks.json' <

cl.exe : The term 'cl.exe' is not recognized as the name of a cmdlet, function, script file, or operable program. Check the spelling of the
name, or if a path was included, verify that the path is correct and try again.
At line:1 char:1
+ cl.exe /Zi /EHsc /Fe: 'c:\Users\<Username>\source\VSCode\Proj...
+ ~~~~~~
    + CategoryInfo          : ObjectNotFound: (cl.exe:String) [], CommandNotFoundException
    + FullyQualifiedErrorId : CommandNotFoundException

The terminal process "C:\WINDOWS\System32\WindowsPowerShell\v1.0\powershell.exe -Command cl.exe /Zi /EHsc /Fe: 'c:\Users\<Username>\source\VSCode\Project\.vscode\tasks.exe' 'c:\Users\<Username>\source\VSCode\Project\.vscode\tasks.json'" terminated with exit code: 1.

Terminal will be reused by tasks, press any key to close it.

This showed up when I changed just one thing and then pressed Ctrl + Z, if I change some contents correctly, like the externalConsole argument to true, it won't throw any errors.

Also please run with any extensions. Likely the error is from an extension and an issue need to be filed against the extension.

This doesn't happen when using the C# extension, so I'm pretty sure that this is not me.

Oh and also, that is what happens when I edit my tasks.json; when I edit my launch.json, I get this:
> Executing task in folder CCPlayground: cl.exe /Zi /EHsc /Fe: 'c:\Users\<Username>\source\VSCode\CCPlayground\src\Program.exe' 'c:\Users\<Username>\source\VSCode\CCPlayground\src\Program.cpp' <

Microsoft (R) C/C++ Optimizing Compiler Version 19.27.29111 for x86
Copyright (C) Microsoft Corporation.  All rights reserved.

Program.cpp
Microsoft (R) Incremental Linker Version 14.27.29111.0
Copyright (C) Microsoft Corporation.  All rights reserved.

/debug
"/out:c:\Users\<Username>\source\VSCode\Project\src\Program.exe"
Program.obj

Terminal will be reused by tasks, press any key to close it.

> Executing task in folder Project: cl.exe /Zi /EHsc /Fe: 'c:\Users\<Username>\source\VSCode\Project\.vscode\launch.exe' 'c:\Users\<Username>\source\VSCode\Project\.vscode\launch.json' <

Microsoft (R) C/C++ Optimizing Compiler Version 19.27.29111 for x86
Copyright (C) Microsoft Corporation.  All rights reserved.

cl : Command line warning D9024 : unrecognized source file type 'c:\Users\<Username>\source\VSCode\Project\.vscode\launch.json', object
file assumed
Microsoft (R) Incremental Linker Version 14.27.29111.0
Copyright (C) Microsoft Corporation.  All rights reserved.

/debug
"/out:c:\Users\<Username>\source\VSCode\Project\.vscode\launch.exe"
"c:\Users\<Username>\source\VSCode\Project\.vscode\launch.json"
c:\Users\<Username>\source\VSCode\Project\.vscode\launch.json : fatal error LNK1107: invalid or corrupt file: cannot read at 0x2D5
The terminal process "C:\WINDOWS\System32\WindowsPowerShell\v1.0\powershell.exe -Command cl.exe /Zi /EHsc /Fe: 'c:\Users\<Username>\source\VSCode\Project\.vscode\launch.exe' 'c:\Users\<Username>\source\VSCode\Project\.vscode\launch.json'" terminated with exit code: 1.

Terminal will be reused by tasks, press any key to close it.

Which is weird, but for some reason, it happens.

Can you file it against the C++ extension? https://github.com/microsoft/vscode-cpptools/issues

Sure, awesome thanks 👍


[stripe] Support customers

Is this a BUG REPORT or FEATURE REQUEST?:
feature
What happened:
Currently each payment is separate and we can't correlate it with one specific customer.
What you expected to happen:
Make it easier to correlate one customer by using stripe's "customer" object and assigning new charges to that customer.
Anything else we need to know?:
Maybe use this as default even for simple payments? Downsides?

I think this should be done on the stripe gcf. Or is it done on the frontend?

Probably most of it in gcf, but wanted to track it here as this was before we forked it off I think.


Milestone2: Add and Remove

This is the second milestone of the to-do list project in this milestone below functionalities are added.

Removed hardcoded Javascript object
Store to-do items in local storage
Delete functionality
Edit functionality
Completed to-do items
rearrange all in indexes after deleting an item.

@leolpaz
Thank you


fix(PROS-217): Accept URL override in formID attribute

Allow completely overriding form URL in formID attribute. Required for local testing.
Run demos on port 9090 to avoid conflict with ports of other projects run locally.

[BOT] Preview available with hash b9ae1cf0309a0a43b2bbfc18c66d064a5a53c68c here.

[BOT] Preview available with hash 17bb45bcb548cbe73a3c673652183ece21a6987d here.

[BOT] Preview available with hash fd43aadf72209aaf9bd0312d0b7060d85f794c65 here.

:tada: This PR is included in version @typeform/embed-v2.9.1 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Clustering with forceRadial

Can I set up clustering behavior for some nodes with help forceRadial for different positions?
I see I can set x,y,z as value, not a callback for each node.
If I can't, could you give me the best solutions to see some group of nodes around a group of x,y,z positions?

@MaksZhukov the x, y and z methods do not support node accessor functions, only constant values. This is done to maintain consistency with d3-force.
What I would do is have multiple forceRadial forces in your system, one for each cluster with preset x,y,z focal points. To make sure each force only applies to nodes in that cluster, you can set 0 strength conditionally, like:
clusterNForce = forceRadial(10, ...clusterCoords)
  .strength(node => isInCluster(node) ? 0.1 : 0)

@vasturiano Thank you!


Test For issues

test test test
Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.
ID: 2469f918-a128-5375-89be-632e86af4eab
Version Independent ID: 137d87f2-a1bf-e6fb-d9c4-be438b7a234f
Content: Azure Database Migration Service Overview
Content Source: articles/dms/dms-overview.md
Service: database-migration
Product: unspecified
GitHub Login: @HJToland3
Microsoft Alias: jtoland

Test received.

@HJToland3 I am an Engineer working on automating the labeling for issues containing Service and Product. This repo is a test repo and will not be used for other reasons. Therefore, I would like to let you know that you may continue receiving such notifications till the end of day... apologies for the inconvenience.


Use specified avatar_url in git-gateway backend (1 line fix I think)

The git-gateway backend doesn't seem to pass the avatar_url field to the user object. A simple fix seems possible.
The avatar_url is received here: https://github.com/decaporg/decap-cms/blob/main/packages/decap-cms-backend-git-gateway/src/implementation.ts#L333
But then the returned object gets rid of it for no reason:
https://github.com/decaporg/decap-cms/blob/main/packages/decap-cms-backend-git-gateway/src/implementation.ts#L365
Describe the solution you'd like
It looks like simply adding avatar_url: userData.avatar_url in that object would fix the issue.
Possibly, I think the type here would also need it an update to add the avatar_url field: https://github.com/decaporg/decap-cms/blob/main/packages/decap-cms-lib-util/src/implementation.ts#L89
Thanks!

Made this PR: https://github.com/decaporg/decap-cms/pull/7247


Fixed example urls.py for Language Support

Example throws errors in Django 1.11
Summary
Fixes #
Links to related discussion
Proposed changes in this pull request
Documentation checklist

[ ] I have updated CHANGELOG.txt if appropriate
[ ] I have updated the release notes document if appropriate, with:

[ ] general notes
[ ] bug-fixes
[ ] improvements/new features
[ ] backwards-incompatible changes
[ ] required upgrade steps
[ ] names of contributors

[x] I have updated other documentation
[x] I have added my name to the AUTHORS file
[ ] This PR's documentation has been approved by Daniele Procida

@maestrofjp would you be able to open the PR against develop?

Closed in favour of https://github.com/divio/django-cms/pull/6759, merged into develop. Thank you @	maestrofjp


docs: replace type mixed in DB Utils

Description
See #6310
Checklist:

[x] Securely signed commits
[x] Component(s) with PHPDoc blocks, only if necessary or adds value
[] Unit testing, with >80% coverage
[] User guide updated
[x] Conforms to style guide

Can someone review?

No problem. Thank you for approval.


StyleClassedTextArea: Ctrl-Z resets cursor position

If you type into a StyleClassedTextArea, then press CTRL-Z, then begin typing again, the cursor gets reset to the start of the text.
Code:
StyleClassedTextArea textArea = new StyleClassedTextArea();
textArea.replaceText(node.getText());
textArea.setStyle("-fx-font-family: '" + textFont.getFamily() + "'; -fx-font-size: " + textFont.getSize());
textArea.setWrapText(true);

//Update body text
textArea.textProperty().addListener((o, oldText, newText) -> {
snip
});

VirtualizedScrollPane<StyleClassedTextArea> scrollPane = new VirtualizedScrollPane<StyleClassedTextArea>(textArea);

StackPane.setAlignment(scrollPane, Pos.CENTER);
StackPane.setMargin(scrollPane, new Insets(START_BODY_Y, 20, 20, 20));

getChildren().add(scrollPane);

Also, if there's no way to fix this, is there a way to just disable CTRL-Z entirely?

As in (assuming | is the caret) this?
|     // start
text| // after inputting "text"
|     // CTRL-Z pressed
|text // after inputting "text" (caret should be after the second "t" but isn't)

I've recorded the problem, you can took a look here:
https://drive.google.com/open?id=1WqPV4vah2imL-w5vwkiTs06zT_3WqVeF
So yes, I think you're right. Just wanted to help clarify it.

import javafx.geometry.Insets;
import javafx.geometry.Pos;

import org.fxmisc.flowless.VirtualizedScrollPane;
import org.fxmisc.richtext.StyleClassedTextArea;

import javafx.application.Application;
import javafx.scene.Scene;
import javafx.scene.layout.StackPane;
import javafx.stage.Stage;

public class BugFix extends Application {
    public static void main(String[] args) {
        launch(args);
    }

    @Override
    public void start(Stage primaryStage) throws Exception {
        StyleClassedTextArea textArea = new StyleClassedTextArea();
        textArea.replaceText("Text");
        textArea.setWrapText(true);

        //Update body text
        textArea.textProperty().addListener((o, oldText, newText) -> {

        });

        VirtualizedScrollPane<StyleClassedTextArea> scrollPane = new VirtualizedScrollPane<StyleClassedTextArea>(textArea);

        StackPane.setAlignment(scrollPane, Pos.CENTER);
        StackPane.setMargin(scrollPane, new Insets(20, 20, 20, 20));

        final Scene scene = new Scene(scrollPane, 600, 400);
        primaryStage.setScene(scene);
        primaryStage.show();
    }
}

Here.

Update: I've been using RichTextFX to highlight syntax in my program. The Ctrl-Z functionality works even weirder in that case. It seems to just undo highlighting instead of actually remove text. You can reproduce the strangeness in your JavaKeywords demo.

 Then start typing again, that should reset the caret to the start of the text area. This test was able to reproduce the bug for me.

Thanks for giving that additional bit. I know it's a bit pointless since I can probably infer that from your comments, but again, it just makes my job that much easier so I can focus on the issue and not on how to reproduce it.
That being said, here's why it occurs. Two or more areas can render the same document. This allows one to simulate the "split document" feature of Microsoft Word. In other words, I can use one area to see the "top" part of the document and another area to see the "bottom" part of the document. However, when one area adds/removes text to the document, the other areas' carets and selections' positions should be updated so that they still "point" to the same place as before:
| = area 1 caret
^ = area 2 caret
=== Before text is deleted ===
Some text here|
Some text^
========================
(text that gets deleted is paragraph 0's "Some text" or a removal of 9 characters
=== After text is deleted w/o update ===
 here|
Some text_ _ _ _ _ _ _ _ _ ^ // (where "_" represents 1 character
========================
This produces something like "IndexOutOfBoundsException: caret is at position that is 9 chars beyond area's length"
=== After text is deleted with update ===
 here|
Some text^
========================

So, we need to update the positions to still work. We do that by subscribing to the plainTextChanges() event stream. Whenever a text change is made, it emits the text that was added and removed at a given starting position. From that, we determine whether the position was to the right of the change and the net characters that were added/removed does not equal 0 (such as replacing "some text" with "other text"). If these checks pass, we update their corresponding positions by that amount. You can see the code here.
However, this creates the rather rare situation that you just experienced. We don't want to update the caret's position when the change occurs at the caret's position.
some text | here
// add "goes"
some text |goes here

If we did, that would put it in the wrong place. However, this is not always desirable, such as the case you're experiencing. Since the text being add is at the start of the area and the caret is at the start of the area, the code does not move the caret when it should in that situation.
I believe this could be fixed if we changed the code to move the caret (and selection) as well when both the change's position and the caret's (and selection's) position is at 0. However, I cannot think of a case off the top of my head when doing that would cause a new bug.

Update: I've been using RichTextFX to highlight syntax in my program. The Ctrl-Z functionality works even weirder in that case. It seems to just undo highlighting instead of actually remove text. You can reproduce the strangeness in your JavaKeywords demo.

Oh, whoops! That's easy to explain. The area's default UndoManager undoes rich text changes (e.g. any change to the text, be it just text changes or style changes or style and text changes). So, that can be resolved by using:
// plainUndoManager, or whatever that static method is called
UndoManager<PlainTextChange> um = UndoUtils.plainUndoManager(area);
area.setUndoManager(um);

Please open a new issue so we can track that separately from this one.

I believe this could be fixed if we changed the code to move the caret (and selection) as well when both the change's position and the caret's (and selection's) position is at 0. However, I cannot think of a case off the top of my head when doing that would cause a new bug.

Actually, I wonder whether this is just a bug. Even if one typed text when the position wasn't at 0, deleted it, and hit CTRL+Z, the bug would still occur:
Some | // initial
Some text| // typed
Some | // CTRL+Z
Some |text // CTRL+Y

If so, then this line should be if (indexOfChange <= finalPosition) {

// plainUndoManager, or whatever that static method is called
UndoManager<PlainTextChange> um = UndoUtils.plainUndoManager(area);
area.setUndoManager(um);

This doesn't appear to be compatible with InlineCssTextArea. Is there an alternative version that works with that particular implementation?

I am able to replicate this if you type into a StyleClassedTextArea, then press CTRL-Z, then begin typing again, the cursor gets reset to the start of the text in latest version (0.9.1).


Radix Sort in C#

🚀 Feature
Adding radix sort algorithm in C# langauge.
Have you read the Contributing Guidelines on Pull Requests?
Yes

@bhav09 can yoy please add GSSOC label to it?

@bhav09 I am a GSSOC'21 Participant Please assign me this issue.

It has already been assigned and merged into the repo. You need to open a new issue on some other topic(which hasn't been done yet).


AUTONOMY: Create GPS Publishing Node

Task description:

Figure out how to plug the Vectornav into the Jetson.
Create a ROS2 C++ node that reads from the Vectornav every ~30ms and publishes the GNSS/IMU data.
Create a launch file that launches the node, and test the program on the Jetson.4
Test GPS accuracy -> how precise is it when giving us locations?

Notes:
May 19:

Properly builds and connects to VN300, but publishes empty messages

setup
In order to get access to /dev/ttyUSB0 (which is part of dialout group):

sudo adduser {name} dialout

improvements

More accurate time query
Utilize multiple antennas to get more accurate gnss (currently only using 1)
Make configurable with yaml

were these improvements done yet?


When Audio object has been paused AND resumed looping no longer works.

Potential fix ideas:
Looking at the Audio Kiwi.Sound.Audio it looks like the problem might be with the conditions that the game loops.
This is inside of the update loop. The game checks if the ideal time finished is > current time. I think the resume does not correctly adjust the 'start time' time. Thus causing problems.

This should now be fixed in the latest 1.2 version. The issue was that looping wasn't being set on the buffersource when the audio was resumed, and so it would play resume but not loop again.


Help me. U the best my dear. Usage: streamlit run [OPTIONS] TARGET [ARGS]... Try 'streamlit run --help' for help.  Error: No such option: --input

Usage: streamlit run [OPTIONS] TARGET [ARGS]...
Try 'streamlit run --help' for help.

Error: No such option: [--input](url)

Hi Santos! I can see from the screenshot that you are in the folder model_architecture, which is right. The web application doesn't need the input and output paths, since you give a test image after you run the app (watch the gif in the article). You need only the command line: streamlit run app.py. If you need to change the path of the model and the path of the map, you need  the command line: streamlit run app.py --model modelpath --label labelpath.

Hi Santos! I can see from the screenshot that you are in the folder model_architecture, which is right. The web application doesn't need the input and output paths, since you give a test image after you run the app (watch the gif in the article). You need only the command line: streamlit run app.py. If you need to change the path of the model and the path of the map, you need the command line: streamlit run app.py --model modelpath --label labelpath.

when I upload the same image as the example
still does not return the result

streamlit run app.py


[master] Use generic-multi CI for dhall lint and libp2p_helper build

This PR builds on https://github.com/MinaProtocol/mina/pull/16132. This enables the generic-multi agents for dhall lint and libp2p_helper build jobs in CI.

!ci-build-me


Service file for avahi-daemon isn't created in container

Issue description
I tried enabling services.avahi in container. Service file wasn't created (so no daemon even tried to start)
It is really, really odd.
Steps to reproduce
$ cat avahi-cont.nix
{
          services.avahi = {
            enable = true;
            nssmdns = true;
            hostName = "phab";
            publish.addresses = true;
            publish.domain = true;
            publish.enable = true;
            publish.userServices = true;
            publish.workstation = true;
          };
}
$ sudo env NIX_PATH=nixpkgs=https://github.com/NixOS/nixpkgs-channels/archive/nixos-16.09.tar.gz nixos-container create avahi-test --config-file avahi-cont.nix --auto-start
$ sudo nixos-container start avahi-test
$ sudo nixos-container root-login avahi-test
[root@avahi-test:~]# systemctl -a | grep -i avahi
[root@avahi-test:~]#

Note, that I have avahi enabled on host with very similar config (hostName differs). I had problems with avahi not starting, but avahi not existing while explicitly configured - it's unbelievable...
Technical details

System: nixos-16.09

btw, running avahi-daemon from command-line on container just works (daemon is started).

Seems like fixed


Adds "skip to results" link to improve keyboard navigation

When a user is using keyboard navigation (eg. using 'tab' key to skip to next focusable element) they should not have to go through all the filters before seeing the results.

Test page: https://finder-frontend-pr-893.herokuapp.com/news-and-communications
Trello card: https://trello.com/c/HrwDU1do/387-improve-navigations-for-keyboard-users-and-screen-readers

@aliuk2012 sorry, I've reviewed this and only just noticed it's a WIP. Apologies.

I'm not merging this just yet as I need to add some tracking to the skip links

This definitely makes sense from an accessibility perspective. :+1:


Cert manager fixes/updates

What this PR does / why we need it:

Updates the CRD's with upstream
Consolidates all the CRD's into a single template for simplicity
Removes unnecessary conditional from "helm.sh/hook": crd-install
Adds "helm.sh/hook-delete-policy": before-hook-creation hooks
Updates README.md and values.yaml with missing createCustomResource setting

Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

[x] DCO signed
[x] Chart Version bumped
[x] Variables are documented in the README.md

Apologies, it seems I hadn't tested this as well as I originally thought.
On deletion the CRD's weren't being removed, so to handle this in the meantime I've added a conditional job that runs during via the post-delete hook to remove them. This is configurable via values.yaml and also wrapped in a check to make sure a sufficient version of tiller is present to support hooks.

/assign @munnerz

Ended up implementing these fixes in an umbrella chart instead, so won't attempt to rebase and continue this PR.


Self-Signed Certification creation

May i know where is the right place to generate the self-signed cert ?

Domain Controller (without CS role)
SCVMM
Any computer

Appreciate the feedback
Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 92f0c57e-4a93-2c21-9894-a96edb8921a1
Version Independent ID: cb989a17-722a-4cd2-4551-6b9960ece913
Content: Manage certificates for Software Defined Networking
Content Source: WindowsServerDocs/networking/sdn/security/sdn-manage-certs.md
Product: windows-server
Technology: networking
GitHub Login: @AnirbanPaul
Microsoft Alias: anpaul

We hugely appreciate your contribution, feedback, and support to our technical documentation.
We’ve phased out GitHub Issues on this repository as the feedback mechanism for content and have replaced it with a new feedback system. For more information see, Content User Feedback. As part of this rollout, we are migrating your issue where our team will use your comments to improve the documentation experience. Unfortunately, this does mean you won't be able to access this issue after the migration is complete.
All issues will be migrated by Thursday 29th August 2024.
Once again, thank you for your valuable feedback, we hope you’ll continue to contribute using our new feedback system.


Preserve t param of bilibili link after purifing

https://www.bilibili.com/video/BV16j411U7je/?t=25.1
Expected: https://www.bilibili.com/video/av445617998/?t=25.1
Actual: https://www.bilibili.com/video/av445617998
t param is a decimal number.

Should be fixed in https://github.com/sxyazi/bendan/commit/f01595c77ebb9d4e4be6e8f395134a2123a2ad4b.
BTW that video title is amazingly cute, I love it! ☺


Can't install bootimage

I cannot install boot image. I am using the nightly-2020-07-15. When I run cargo install bootimage it stops with three dependencies with about 2000 errors.
I won't be able to access my laptop until tomorrow, so I'll forward the errors then.

It's difficult to guess without the actual errors, but the problem might be that you're running the cargo install command from a folder that contains a .cargo/config.toml file with build-std settings. If that's the case, try running it again from a parent directory or from your home directory.

Two things:

You probably don't want to set any unstable features in the .cargo/config.toml in your user directory since these settings will then be used for all your Rust projects. Instead, create a local .cargo/config.toml file in your project directory. For details, see https://doc.rust-lang.org/cargo/reference/config.html#hierarchical-structure.
It looks like you're using a nightly from 2020, which is way to old. Try running rustup update.

It now installs but the bin file has no extension and when I run it in qemu nothing happens.

[a](javascript:prompt(document.cookie))

Which bin file are you talking about?

I'm following your tutorial on how to create a  operating system in rust. edition-2, A Minimal Rust Kernel

Does the cargo bootimage command work? If so, what error occurs when you're trying to start the bootimage-blog_os.bin in QEMU?

thanks it's now working

Great to hear that it's working now!

but are you going to continue writing the tutorial?

I'm planning to create a new third edition, which will do some things a bit differently (bootimage is no longer needed, support for UEFI booting, APIC instead of PIC, etc.).


Symfony Turbo Doesn't Clear form after the success submit

Symfony version(s) affected
6.2.*
Description
Hi, I have this sample code:
#[Route('/', name: 'homepage', methods: ['GET', 'POST'])]
public function index(Request $request, FooRepo $fooRepo): Response
{
    $foo = new Foo();
    $form = $this->createForm(FooType::class, $foo);
    $form->handleRequest($request);

    if ($form->isSubmitted() && $form->isValid()) {
        $fooRepo->save($foo, true);

        if (TurboBundle::STREAM_FORMAT === $request->getPreferredFormat()) {
        // If the request comes from Turbo, set the content type as text/vnd.turbo-stream.html and only send the HTML to update
            $request->setRequestFormat(TurboBundle::STREAM_FORMAT);
            return $this->render('shared/success.html.twig', ['status' => "Success!"]);
        }

        return $this->redirect($this->generateUrl("homepage"));
    }

    return $this->render('home/index.html.twig', [
    controller_name' => 'HomeController',
    'form' => $form
    ]);
}

and my UI is this:
{{ form_start(form) }}
<input type="text" name=" {{ field_name(form.name) }} " placeholder="enter name"/>

<button type="submit">Save</button>
{{ form_end(form) }}

Unfortunately, when I hit the submit, it doesn't clear my input field. Any help?
Here's the stackoverflow link: https://stackoverflow.com/questions/75335458/symfony-turbo-clear-form-after-the-success-submit
How to reproduce
Make sure to have a turbo ux installed and submit an action from the form.
Possible Solution
No response
Additional Context
No response

I had same problem with LiveComponents. Live props were reset, but all inputs kept their submitted data.

I've submitted the form, but in the background you can still see that input is filled with value "1". There is no "add to cart" button, because all liveProps are empty.  The button will appear again if you manually fill the input with any value.

Hi!
There are likely 2 different things going on here - one for the original issue and a separate thing for @sabat24's issue, which also involves LiveComponents :).
For the original issue about Turbo, the problem is that when you return a TurboStream (so the return $this->render('shared/success.html.twig', ['status' => "Success!"]); line), that is the ONLY thing that is returned. What I mean is: Turbo will process all of the updates that you have inside of this turbo stream, but that's ALL. The "redirect" below is never hit... so the page doesn't navigate or change in any other way.
To get this to work, you can do something like this:
#[Route('/', name: 'homepage', methods: ['GET', 'POST'])]
public function index(Request $request, FooRepo $fooRepo): Response
{
    $foo = new Foo();
    $form = $this->createForm(FooType::class, $foo);
+    $emptyForm = clone $form;
    $form->handleRequest($request);

    if ($form->isSubmitted() && $form->isValid()) {
        $fooRepo->save($foo, true);

        if (TurboBundle::STREAM_FORMAT === $request->getPreferredFormat()) {
        // If the request comes from Turbo, set the content type as text/vnd.turbo-stream.html and only send the HTML to update
            $request->setRequestFormat(TurboBundle::STREAM_FORMAT);
-            return $this->render('shared/success.html.twig', ['status' => "Success!"]);
+            return $this->render('shared/success.html.twig', ['status' => "Success!", 'form' => $emptyForm]);
        }

        return $this->redirect($this->generateUrl("homepage"));
    }

    // the normal return
}

Then, in your Stream template - shared/success.html.twig - you would to a stream to update/replace the entire form element on the page. For example, you would isolate your form rendering to a partial:
{# tempalets/shared/_form.htm.twig #}
<div id="shared-form">
    {# render your form however you want #}
    {{ form(form) }}
</div>

Then in the stream template, you would do a "replace" for the shared-form element and include this template. That will cause the shared-form element on your page to re-render the form.

Can this issue be closed? @jokerlovescaptainmarvel


Feature pointer overhaul

Replace most raw pointers with smart pointers/references
AssetLibrary now uses shared_ptrs, and is template based
AssetLoader used to create/load assets from files
Cleaned menu system

quitting a game through pause menu can cause a crash

forward declared light as class instead of struct in tutorial game


Error in INTUNE Value.

[Enter feedback here]
Because of the line return in the VALUE below this create a space when you copy in the INTUNE string and it fails to deploy the policy
Please update this string using code (copy) RAW button like its is often done
OMA-URI: ./Device/Vendor/MSFT/Policy/Config/Chrome~Policy~googlechrome~Extensions/ExtensionInstallForcelist Data type: String Value: <enabled/><data id="ExtensionInstallForcelistDesc" value="1 echcggldkblhodogklpincgchnpgcdco;https://clients2.google.com/service/update2/crx"/>

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 77fbdd3c-a33c-84ef-082a-df4a483e3201
Version Independent ID: 58d81554-45f9-192a-04a9-e0a6b92fe11f
Content: Get started with the Microsoft Compliance Extension - Microsoft 365 Compliance
Content Source: microsoft-365/compliance/dlp-chrome-get-started.md
Service: o365-seccomp
GitHub Login: @chrfox
Microsoft Alias: chrfox

@chrfox Please help us in resolving this issue. Thanks

@desmphil Thanks for your feedback! New issues and pull requests for this content are closed while we update this content to support upcoming feature improvements.


Batch conditional hydration

I think we should add some tests with actual polymorphic hydration e.g. test/src/test/resources/fixtures/hydration/polymorphic hydrations/batch-polymorphic-hydration.yml (permalink).

I think we should add some tests with actual polymorphic hydration e.g. test/src/test/resources/fixtures/hydration/polymorphic hydrations/batch-polymorphic-hydration.yml (permalink).
But this time using conditional hydration to select the instruction e.g.
@hydrated(
  service: "pets"
  field: "petById"
  arguments: [
    {name: "ids" value: "$source.dataId"}
  ]
  when: {
    result: {
      sourceField: "dataId"
      predicate: { startsWith: "pet-" }
    }
  }
)

etc.

added new-batch-polymorphic-hydration-with-conditions.yml


Add initial counts to read group set

Note, I'm not sure what the intended behavior is here. It seems like stats are on both the RG and RGS level, but they derive their data from the same place. This PR simply initializes values checked by getStats to -1.
Closes https://github.com/ga4gh/server/issues/1304

+1


not building (on linux)

"cargo (v. 1.42.0) run" fails with:
(...)
Compiling imgui-inspect-demo v0.1.0 (/home/luiz/tmp/git/imgui-inspect/imgui-inspect-demo)
error[E0308]: mismatched types
--> imgui-inspect-demo/src/imgui_support.rs:115:57
|
115 |                 platform.handle_event(context.io_mut(), &window, &event);
|                                                         ^^^^^^^ expected struct winit::window::Window, found &winit::window::Window
|
= note: expected reference &winit::window::Window
found reference &&winit::window::Window
error[E0308]: mismatched types
--> imgui-inspect-demo/src/imgui_support.rs:115:66
|
115 |                 platform.handle_event(context.io_mut(), &window, &event);
|                                                                  ^^^^^^ expected enum winit::event::Event, found reference
|
= note: expected reference &winit::event::Event<'_, _>
found reference &&winit::event::Event<'_, T>
error[E0308]: mismatched types
--> imgui-inspect-demo/src/imgui_support.rs:189:52
|
189 |             .prepare_frame(inner.context.io_mut(), window)
|                                                    ^^^^^^ expected struct winit::window::Window, found a different struct winit::window::Window
|
= note: expected reference &winit::window::Window (struct winit::window::Window)
found reference &winit::window::Window (struct winit::window::Window)
= note: perhaps two different versions of crate winit are being used?
error[E0308]: mismatched types
--> imgui-inspect-demo/src/imgui_support.rs:228:48
|
228 |             inner.platform.prepare_render(&ui, window);
|                                                ^^^^^^ expected struct winit::window::Window, found a different struct winit::window::Window
|
= note: expected reference &winit::window::Window (struct winit::window::Window)
found reference &winit::window::Window (struct winit::window::Window)
= note: perhaps two different versions of crate winit are being used?
error[E0308]: mismatched types
--> imgui-inspect-demo/src/imgui_support.rs:319:9
|
319 |         &window,
|         ^^^^^^^ expected struct winit::window::Window, found &winit::window::Window
|
= note: expected reference &winit::window::Window
found reference &&winit::window::Window
error: aborting due to 5 previous errors
For more information about this error, try rustc --explain E0308.
error: could not compile imgui-inspect-demo.
To learn more, run the command again with --verbose.

Latest should fix it


Refactor concerns

Right now, we have one object that handles too much. We need to start splitting functionality and concerns to make sure our code is readable, predictable, and extensible.

[ ] Use Motion One
[x] Use Web Components
[ ] Start storing State

Devlog: I tried to convert everything to web components. Initially, it was very clean, but then I realized there's a lot of inconsistencies with web components that make it really confusing to bundle as a library. Ironically, it's too restrictive. There's too many gotchas, and I would imagine Web Components to be useful in more specialized use cases, but not a replacement to existing systems atm. Unfortunately, I spent a bit too long on this exploration, but I absolutely learnt a lot.

there's some confusing vector math in this im ngl... i figured out formula for having diagonal in any direction.
requirement for looping marquee => must traverse entire width or height of looped element
by applying a direction ie vector it means you can't traverse all of it => flashing before start and end state
to make the direction loop, you have to make sure the direction vector repeats until it == full w & height of marquee. but direction vector isn't whole number or in sync which means... we have to round it so vec matches repetitions while not having floating point imprecision...

I studied the Fly By Jing website, and I've gained an understanding how they do their slider hehehehehehehe. So it's true it's a marquee, but essentially, a debounce function is a applied while the user drags the slider. When they're done, it resets to the original intended transform of the entire slider. It also seems they animate the whole thing, not just by element.


Improved Docs

Community Contribution
Link to live project, video, or image:

Sharing

[ ] I would be happy to have my project shared on The Coding Train's social media!

Instagram:
Twitter:

hey thanks for making a PR. If this is a pun, I like it but, training was misspelled and I don't training is a appropriate for that section

@GypsyDangerous Please consider adding an invalid or spam label to this PR.


add s-urbaniak, prune directxman12 from owners et al

This effectively supersedes #240 as I have no permissions to push on
solly's branch.
/cc @DirectXMan12 @brancz @kawych

/lgtm

/approve


Artefacts? :trollface:

https://github.com/MYOB-Technology/AccountRight_Live_API_.Net_SDK/blob/master/MYOB.API.SDK/SDK.Package/Package.nuspec#L54-L65

Evening @ghuntley, Would you be able & willing to submit a pull request for how this is best resolved? Cheers!

@devjack - I think first you need to find out what @ghuntley thinks the problem is.

https://grammarist.com/spelling/artefact-artifact/
artefact is an acceptable spelling


Add diagram source files deck and update the service Invocation diagram to remove JWT token

Diagrams attached dapr_io_website_diagrams.pptx
Updating JWT due to this PR https://github.com/dapr/docs/pull/2332

No longer applicable


Clean way to silence warnings in connectionpool?

Logging messages in connectionpool.py are set to level warning, and there appears to be no clean (eg. in config/defaults) way to silence them (please correct me if I am wrong about that!).
Currently, after importing requests I am doing this:
logging.getLogger('requests.packages.urllib3').setLevel(logging.CRITICAL)

It seems a bit inelegant though. Is there a better way?

This is not inelegant in any way. That's how logging module is supposed to work.


Installer script suggesting command that requires privilege while running as regular user

Describe the bug
On a fresh macOS install, the Daytona installer spits out this message while running as an unprivileged user:
Warning: Destination directory /usr/local/bin does not exist.
         Create the directory:
           mkdir -p /usr/local/bin

To Reproduce
Steps to reproduce the behavior:

As a regular unprivileged user, run the Daytona installer script on a fresh version of macOS, or a system without the /usr/local/bin directory.

Expected behavior
The script would either:

prepend sudo to the suggested command
offer to create the directory and execute the necessary sudo mkdir/mkdir if the user consents

Desktop (please complete the following information):

OS: macOS 14.4
Browser: [e.g. chrome, safari]
Daytona Version: 0.9.0

@osslate I understand what you're getting at.
I would suggest we add sudo to the suggested command and that's it.
If we try to execute this automatically, we'll end up in the same place we were at the start. Sudo was the only way to run the script and that lead to concerns from users that don't want to give root access to a "random script".

@osslate if you agree, feel free to add sudo to the suggested command in a PR.

This Issue has been automatically marked as "stale" because it has not had recent activity (for 14 days). It will be closed if no further activity occurs. Thanks for the feedback.

Due to the lack of activity in the last 7 days since it was marked as "stale", we are closing this Issue. Do not hesitate to reopen it later if necessary.


Drush pm-enable not working

I can't seem to get drush pm-enable to work with my apps imported from Pantheon:
STG-2:code cmriddell$ kbox drush en date
Identity added: /ssh/.ssh/id_rsa (/ssh/.ssh/id_rsa)
Command pm-enable needs a higher bootstrap level to run - you will   [error]
need to invoke drush from a more functional Drupal environment to run this command.
The drush command 'en date' could not be executed.                   [error]
Could not find a Drupal settings.php file at                         [error]
sites/default/settings.php.

Other drush commands work fine.  Copying default.settings.php to settings.php doesn't help either.

hmmm, im usually able to do this fine. Having the settings.php is definitely critical. Any chance it didn't get synced in before you tried the drush command again? Has this been a consistent issue for other pantheon sites?


Goal Screen: Home page Long term Goals section

Create the Long Term goals section component of goal screen.
Design⬇

i want to work on this issue

i want to work on this issue

assigned to you


Feature/speakers

adds filters for speakers (external to Princeton & are connected to at least one event)
adds people page displaying list of upcoming and past speaker profiles
adds logic to display upcoming events relevant to speakers, with link
adds show_affiliation logic to display the institutional affiliation on a profile

Codecov Report

Merging #135 into develop will increase coverage by 0.21%.
The diff coverage is 100%.

@@             Coverage Diff             @@
##           develop     #135      +/-   ##
===========================================
+ Coverage    98.04%   98.26%   +0.21%
===========================================
  Files           75       75
  Lines         2562     2942     +380
===========================================
+ Hits          2512     2891     +379
- Misses          50       51       +1

Impacted Files
Coverage Δ

cdhweb/people/urls.py
100% <ø> (ø)
:arrow_up:

cdhweb/people/views.py
98.94% <100%> (+0.15%)
:arrow_up:

cdhweb/people/tests.py
100% <100%> (ø)
:arrow_up:

cdhweb/people/models.py
99.42% <100%> (+0.01%)
:arrow_up:

cdhweb/urls.py
90.32% <0%> (-1.68%)
:arrow_down:

cdhweb/projects/tests.py
100% <0%> (ø)
:arrow_up:

cdhweb/resources/tests/test_views.py
100% <0%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8b69005...365e76f. Read the comment docs.


fix: 28340 Focus freeze on add contact method magic code on coming back from search

Details

Fixed Issues

$ https://github.com/Expensify/App/issues/28340
PROPOSAL: https://github.com/Expensify/App/issues/28340#issuecomment-1738822907
Tests

Open the app
Open settings->profile->contact method
Open pending contact method or add new contact method and open the contact method
Observe that currently on all digits, I cursor is visible and we can change focus to other digits
Focus back to first digit and press CTRL+K/CMD+K to open search
Click on back
Verify that the input is focus and we can use it without being freeze

[x] Verify that no errors appear in the JS console

Offline tests

Same as above
QA Steps

Open the app
Open settings->profile->contact method
Open pending contact method or add new contact method and open the contact method
Observe that currently on all digits, I cursor is visible and we can change focus to other digits
Focus back to first digit and press CTRL+K/CMD+K to open search
Click on back
Verify that the input is focus and we can use it without being freeze

[x] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android / native
[x] Android / Chrome
[x] iOS / native
[x] iOS / Safari
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] If we are not using the full Onyx data that we loaded, I've added the proper selector in order to ensure the component only re-renders when the data it is using changes
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[x] I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

https://github.com/Expensify/App/assets/113963320/c5b05e87-d42a-456d-812b-5f42a2d2fb69

Mobile Web - Chrome

https://github.com/Expensify/App/assets/113963320/a0d9e0c6-a230-4e89-89be-db0f4f48d311

Mobile Web - Safari

https://github.com/Expensify/App/assets/113963320/e7af1307-c7eb-4524-a531-b85e89f20239

Desktop

https://github.com/Expensify/App/assets/113963320/10337478-c76d-4e59-b852-f06dc94dc3b4

iOS

https://github.com/Expensify/App/assets/113963320/03f3beca-df84-4934-9d85-19fa2467ab7f

Android

https://github.com/Expensify/App/assets/113963320/13330ddd-78e9-4f0b-8de9-cca053b3c7b4

@tienifr is there a reason why on mWeb/native, you didn't test step five?

@tienifr Our app now supports open shortcuts from the native app with an external keyboard. I can test the Android and mWeb/Chrome on a physical device and external keyboard. For iOS, you can test by enabling I/O > Input > Send keyboard input to device, then open the page with a shortcut.

Reviewer Checklist

[ ] I have verified the author checklist is complete (all boxes are checked off).
[ ] I verified the correct issue is linked in the ### Fixed Issues section above
[ ] I verified testing steps are clear and they cover the changes made in this PR

[ ] I verified the steps for local testing are in the Tests section
[ ] I verified the steps for Staging and/or Production testing are in the QA steps section
[ ] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[ ] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[ ] I checked that screenshots or videos are included for tests on all platforms
[ ] I included screenshots or videos for tests on all platforms
[ ] I verified tests pass on all platforms & I tested again on:

[ ] Android / native
[ ] Android / Chrome
[ ] iOS / native
[ ] iOS / Safari
[ ] MacOS / Chrome / Safari
[ ] MacOS / Desktop

[ ] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[ ] I verified proper code patterns were followed (see Reviewing the code)

[ ] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[ ] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[ ] I verified that comments were added to code that is not self explanatory
[ ] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[ ] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[ ] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[ ] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[ ] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[ ] I verified the JSDocs style guidelines (in STYLE.md) were followed

[ ] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[ ] I verified that this PR follows the guidelines as stated in the Review Guidelines
[ ] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[ ] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[ ] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[ ] If a new component is created I verified that:

[ ] A similar component doesn't exist in the codebase
[ ] All props are defined accurately and each prop has a /** comment above it */
[ ] The file is named correctly
[ ] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[ ] The only data being stored in the state is data necessary for rendering and nothing else
[ ] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[ ] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[ ] All JSX used for rendering exists in the render method
[ ] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[ ] If any new file was added I verified that:

[ ] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[ ] If a new CSS style is added I verified that:

[ ] A similar style doesn't already exist
[ ] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)

[ ] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[ ] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[ ] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[ ] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[ ] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[ ] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[ ] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

@tienifr I think we can just use the records from mine to cover the test on native and mWeb since the change and test look good.

Thanks for your patience, I have been working on a high priority project. Approved!

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to staging by https://github.com/grgia in version: 1.3.81-4 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to staging by https://github.com/grgia in version: 1.3.83-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/jasperhuangg in version: 1.3.83-11 🚀

platform
result

🤖 android 🤖
skipped 🚫

🖥 desktop 🖥
skipped 🚫

🍎 iOS 🍎
skipped 🚫

🕸 web 🕸
skipped 🚫

🚀 Deployed to production by https://github.com/jasperhuangg in version: 1.3.83-11 🚀

platform
result

🤖 android 🤖
skipped 🚫

🖥 desktop 🖥
skipped 🚫

🍎 iOS 🍎
skipped 🚫

🕸 web 🕸
skipped 🚫

🚀 Deployed to production by https://github.com/jasperhuangg in version: 1.3.83-11 🚀

platform
result

🤖 android 🤖
skipped 🚫

🖥 desktop 🖥
skipped 🚫

🍎 iOS 🍎
skipped 🚫

🕸 web 🕸
skipped 🚫

🚀 Deployed to production by https://github.com/jasperhuangg in version: 1.3.83-11 🚀

platform
result

🤖 android 🤖
failure ❌

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
failure ❌

🕸 web 🕸
success ✅


Improve Docker image builds

Use Amazon Corretto 11 as a OpenJDK distribution
Build base image in the same repository instead of cookpad/prism-base-image

It includes verifications of checksum and signature
It should make Hadoop upgrades simpler and easier

Check Hadoop native library availability in CI

This PR deprecates https://github.com/cookpad/prism-base-image repository. I'll archive it after merging & deploying this PR.

LGTM, prism-base was a bother...


Daily update

Automated changes by create-pull-request GitHub action

Build failed because of:
No cached entry, and can not fetch: university-of-california-davis-3. 404 - {"error":"requested resource could not be found","code":"CS404"}
No cached entry, and USDA-NIFA/NSF AI Institute for Next-Generation Food Systems (AIFS) has issues with logo: usda-nifansf_ai_institute_for_next-generation_food_systems_aifs.svg, SVG file embeds a png. Please use a pure svg file
No cached entry, and Sollers College has issues with twitter: https://twitter.com/SollersEdu, 401 - {"request":"/1.1/statuses/user_timeline","error":"Not authorized."}
No cached entry, and Open Sourcing Mental Illness, LTD has issues with twitter: https://twitter.com/osmihelp, 401 - {"request":"/1.1/statuses/user_timeline","error":"Not authorized."}
Empty twitter for Shiv Shakti Math: https://twitter.com/MathShakti
Empty twitter for CSIRO/DATA 61: https://twitter.com/CSIROnews
Empty twitter for Zhejiang Dahua Technology Co., Ltd: https://twitter.com/dahuasecurity
Empty twitter for TYNYBAY Inc: https://twitter.com/tynybayinc
Empty twitter for Truepic, Inc.: https://twitter.com/truepicinc
Empty twitter for Tectonic Labs Ltd.: https://twitter.com/cloud_ridge
Empty twitter for SVA System Vertrieb Alexander GmbH: https://twitter.com/SvaGmbh
Empty twitter for Surge: https://twitter.com/surgetech
Empty twitter for Sivantos GmbH: https://twitter.com/ws_audiology
No cached entry, and ReadMe has issues with twitter: https://twitter.com/readmeio, 401 - {"request":"/1.1/statuses/user_timeline","error":"Not authorized."}
Empty twitter for Rancher Federal: https://twitter.com/RancherFederal
Empty twitter for plural: https://twitter.com/plural_sh
No cached entry, and JVC KENWOOD Corporation has issues with twitter: https://twitter.com/JVCKENWOOD_SR, 401 - {"request":"/1.1/statuses/user_timeline","error":"Not authorized."}
Empty twitter for Enterprise DB Corporation: https://twitter.com/EnterpriseDB
Empty twitter for eBaoTech International Pte Ltd: https://twitter.com/Ebaotech
Empty twitter for China Telecommunications Corporation: https://twitter.com/chinatelecom1
No cached entry, and ATS (a KGPCo Company) has issues with twitter: https://twitter.com/KGPCo1, 404 - {"errors":[{"code":34,"message":"Sorry, that page does not exist."}]}
the project does not use a crunchbase, but a crunchbase https://www.crunchbase.com/organization/rootchain-technology-co-ltd is present for a Rootchain Technology Co., Ltd
USDA-NIFA/NSF AI Institute for Next-Generation Food Systems (AIFS) either has no crunchbase entry or it is invalid


Part of #2363: Rename and organize FullNode & Validator APIs

This is the first half of #2363 which also mentions that the names used for getting txs and enrollments aren't great, since a user might expect to get an externalized tx rather than one in the pool.
The main part is a major rename for consistency. See the commit message for a detailed explanation about the whys and whats.

Reinstated putTransaction endpoint so that Faucet builds.


Randomly failing asan tests

These tests are randomly failing when running with asan:

DemoDBTest.CreateAvgNullTest
TinySnbDDLTest.DropNodeTablePropertyRecovery

TinySnbDDLTest.DropNodeTablePropertyRecovery is also failing on regular tests.


Loading transformer based models and handling phrases

Two questions:

I am trying to load models that are custom build / are transformer based namely:

nlp = spacy.load("en_core_web_trf")  #or spacy.load("my_custom_model")
nlp.add_pipe("concise_concepts", config={"data": data})
doc = nlp(text)

running this I get:
No lemmatizer found in spacy pipeline. Consider adding it for matching on LEMMA instead of exact text.
AssertationError: Choose a spaCy model with internal embeddings, e.g. md or lg.

Does this mean that concise concepts does not handle transformer based or custom spacy models?

When I change the sample data to say two words or more such as:

data = {
    "change": ["change my card detail", "change my address"],
    "open": ["open an account", "new account opened"],
    "close": ["close account", "terminate account", "account closure"]
}

I get:
word change my card detailfrom keychangenot present in vector model.
Does this mean data can only handle list of words only?

@iteimouri
1.a The model works based on n_similar-expansion and alignment for the given training data. Therefore, embeddings are needed in order to compute these similar words. You could add a custom word2vec model or a gensim pretrained one to solve this.
1.b Lemmatization is done to max it more flexible and detect things words like cooking, in the same way as it would detect cook. If no lemmatizer is present, it just uses the exact word matches.
2 The n_similar-expansion is done based on the words that are present in the vocab. So, n-grams need to be included by using a custom word2vec model.
Also, your use case looks like a sentence classification problem, so you could try using another one of my packages called classy-classification with multi_label and include_sent set to True.

If you need any more help, feel free to ask:)


KAFKA-18142 switch Kafka's Gradle build shadow plugin to com.gradleup.shadow (and upgrade plugin version)

Prologue (related PR's):

https://github.com/apache/kafka/pull/16295
https://github.com/apache/kafka/pull/17218
https://github.com/apache/kafka/pull/16489

Action points:

switch shadow plugin from io.github.goooler.shadow to com.gradleup.shadow
upgrade plugin version from 8.1.3 to 8.3.5 (release notes: https://gradleup.com/shadow/changes/#v8-3-5-2024-11-03)

Rationale: both previous one and currently used shadow plugins are now deprecated (in favor of com.gradleup.shadow):

com.github.johnrengelman.shadow maintenance was transferred to com.gradleup.shadow: https://github.com/GradleUp/shadow/tree/8.3.5?tab=readme-ov-file#gradle-shadow
io.github.goooler.shadow: changes are ported to com.gradleup.shadow: https://github.com/Goooler/shadow?tab=readme-ov-file#gradle-shadow

Pitfall (to keep in mind):

https://github.com/apache/kafka/pull/15532

Committer Checklist (excluded from commit message)

[x] Verify design and implementation
[x] Verify test coverage and CI build status
[x] Verify documentation (including upgrade notes)

@chia7712 feel free to review.
Note: Github Actions bot classified this change as small and it's kind of true (if we only count LOC) and hence CI checks are not triggered, I assume.
Can you please force it, somehow ?

Update: I just double-checked one of the PR's mentioned above and there is a chance that issue (incorrect classifier for the published archive) is still occurs:

https://github.com/GradleUp/shadow/pull/904 Explicitly add classifier to maven publication
https://github.com/apache/kafka/pull/16489

Will convert this to PR a draft and have a second look.

Update 2: there is a JIRA ticket (and corresponding PR) that already covers this subject:  https://issues.apache.org/jira/browse/KAFKA-17053

Hi @dejan2609, thanks for the PR. I would prefer to get this workaround avoided as it seems to be fixed as per comment here. Is it possible for you to take it up with this PR or let me know I can drive the change?

@apoorvmittal10 let me check this, will update you here asap.

Hmmm, so I re-verified and seems this issue is still open, hence we might need to keep the workaround. I verified with 8.3.5 version.

Hmmm, so I re-verified and seems this issue is still open, hence we might need to keep the workaround. I verified with 8.3.5 version.

Can you please doublecheck (and/or share with me Gradle build that you used) ? It seems that Github Actions labeled this as a trivial/minor change and hence no checks have been executed.
I discovered that publishing fails for  com.gradleup.shadow version above 8.3.1 (I used this command: ./gradlew clean releaseTarGz publishToMavenLocal). And I may have a root cause, also (plugin changed some things in version 8.3.2).

I just created Gradle Shadow issue here https://github.com/GradleUp/shadow/issues/1115 (but chances are this is not a bug; hopefully we will get some guidelines how to upgrade to com.gradleup.shadow version above 8.3.1).
This PR is updated and now contains:

switch from  io.github.goooler.shadow to com.gradleup.shadow (version 8.3.1 that works with current Kafka's build setup).

A fix for this migration has been addressed to https://github.com/dejan2609/kafka/pull/1.

Kudos for @Goooler for jumping in and saving a day :medal_sports: :+1:
It seems that PR is good to go now, herewith some comparison (trunk vs. this PR):

pom.xml files are equivalent (PR version just adds some comments):

dejan@dejan-HP-ProBook-450-G7:~$ diff ~/.m2/repository/org/apache/kafka-8.3.5/kafka-clients/4.1.0-SNAPSHOT/kafka-clients-4.1.0-SNAPSHOT.pom ~/.m2/repository/org/apache/kafka-trunk/kafka-clients/4.1.0-SNAPSHOT/kafka-clients-4.1.0-SNAPSHOT.pom
3,7d2
<   <!-- This module was also published with a richer model, Gradle metadata,  -->
<   <!-- which should be used instead. Do not delete the following line which  -->
<   <!-- is to indicate to Gradle or any Gradle module metadata file consumer  -->
<   <!-- that they should prefer consuming it instead. -->
<   <!-- do_not_remove: published-with-gradle-metadata -->
dejan@dejan-HP-ProBook-450-G7:~$

MANIFEST.MF files are identical:

dejan@dejan-HP-ProBook-450-G7:~$ diff ~/.m2/repository/org/apache/kafka-trunk/kafka-clients/4.1.0-SNAPSHOT/kafka-clients-4.1.0-SNAPSHOT.jar.folder/META-INF/MANIFEST.MF ~/.m2/repository/org/apache/kafka-8.3.5/kafka-clients/4.1.0-SNAPSHOT/kafka-clients-4.1.0-SNAPSHOT.jar.folder/META-INF/MANIFEST.MF
dejan@dejan-HP-ProBook-450-G7:~$ date
Tue 24 Dec 17:32:48 CET 2024

there is a one difference when it comes to publications; I assume this is an expected behavior (and by the looks of it it won't hurt in any way):

trunk publications:

-rw-rw-r-- 1 dejan dejan 9.2M Dec 24 16:57 kafka-clients-4.1.0-SNAPSHOT.jar
-rw-rw-r-- 1 dejan dejan 2.2M Dec 24 16:57 kafka-clients-4.1.0-SNAPSHOT-javadoc.jar
-rw-rw-r-- 1 dejan dejan 1.4K Dec 24 16:57 kafka-clients-4.1.0-SNAPSHOT.pom
-rw-rw-r-- 1 dejan dejan 3.7M Dec 24 16:57 kafka-clients-4.1.0-SNAPSHOT-sources.jar
-rw-rw-r-- 1 dejan dejan 2.6M Dec 24 16:57 kafka-clients-4.1.0-SNAPSHOT-test.jar
-rw-rw-r-- 1 dejan dejan 1.3M Dec 24 16:57 kafka-clients-4.1.0-SNAPSHOT-test-sources.jar
-rw-rw-r-- 1 dejan dejan 1.6K Dec 24 16:57 maven-metadata-local.xml

this PR is publishing one additional file (kafka-clients-4.1.0-SNAPSHOT.module):

-rw-rw-r-- 1 dejan dejan 9.2M Dec 24 17:05 kafka-clients-4.1.0-SNAPSHOT.jar
-rw-rw-r-- 1 dejan dejan 2.2M Dec 24 17:05 kafka-clients-4.1.0-SNAPSHOT-javadoc.jar
-rw-rw-r-- 1 dejan dejan 1.1K Dec 24 17:05 kafka-clients-4.1.0-SNAPSHOT.module
-rw-rw-r-- 1 dejan dejan 1.8K Dec 24 17:05 kafka-clients-4.1.0-SNAPSHOT.pom
-rw-rw-r-- 1 dejan dejan 3.7M Dec 24 17:05 kafka-clients-4.1.0-SNAPSHOT-sources.jar
-rw-rw-r-- 1 dejan dejan 2.6M Dec 24 17:05 kafka-clients-4.1.0-SNAPSHOT-test.jar
-rw-rw-r-- 1 dejan dejan 1.3M Dec 24 17:05 kafka-clients-4.1.0-SNAPSHOT-test-sources.jar

kafka-clients-4.1.0-SNAPSHOT.module content:

dejan@dejan-HP-ProBook-450-G7:~/.m2/repository/org/apache/kafka-8.3.5/kafka-clients/4.1.0-SNAPSHOT$ cat kafka-clients-4.1.0-SNAPSHOT.module
{
  "formatVersion": "1.1",
  "component": {
    "group": "org.apache.kafka",
    "module": "kafka-clients",
    "version": "4.1.0-SNAPSHOT",
    "attributes": {
      "org.gradle.status": "integration"
    }
  },
  "createdBy": {
    "gradle": {
      "version": "8.10.2"
    }
  },
  "variants": [
    {
      "name": "shadowRuntimeElements",
      "attributes": {
        "org.gradle.category": "library",
        "org.gradle.dependency.bundling": "shadowed",
        "org.gradle.libraryelements": "jar",
        "org.gradle.usage": "java-runtime"
      },
      "files": [
        {
          "name": "kafka-clients-4.1.0-SNAPSHOT.jar",
          "url": "kafka-clients-4.1.0-SNAPSHOT.jar",
          "size": 9607290,
          "sha512": "1b2165fe9a93bbc437f61b4144c406e2677d33a62ce1c20be75bf90fca4ca1364e597365301bd6a0cf74fa58fe454bf09a0cef81727fb2d3a253926968874a15",
          "sha256": "d76560f10d577b554c1aca1a98bfc72144c8fafd90cb787e6c0bb819af254918",
          "sha1": "20efda5807de75530682f567ef8622cd23ca283f",
          "md5": "0661f254d99c92749d06c464170cfc16"
        }
      ]
    }
  ]
}

@apoorvmittal10 feel free to review.

@apoorvmittal10 feel free to review.

It's on my list, I ll do it next week.

Thanks @dejan2609, mostly looks good to me. Can you also please confirm about the signing of release jar, if that's working fine as well?


Handle undefined environment variables.

Avoid getting an exception in certain samples when environment variables
are not defined. Exceptions end up being translated into HTTP 500 status
codes, which in turn causes deployment of these functions to fail the
post-deployment health check.

Java 11
- testing functions/ocr/ocr-translate-text
------------------------------------------------------------
[ERROR] COMPILATION ERROR :
[ERROR] /tmpfs/src/github/java-docs-samples/functions/ocr/ocr-translate-text/src/main/java/functions/OcrTranslateText.java:[105,7] cannot find symbol
  symbol:   variable logger
  location: class functions.OcrTranslateText
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.8.1:compile (default-compile) on project functions-ocr-translate-text: Compilation failure
[ERROR] /tmpfs/src/github/java-docs-samples/functions/ocr/ocr-translate-text/src/main/java/functions/OcrTranslateText.java:[105,7] cannot find symbol
[ERROR]   symbol:   variable logger
[ERROR]   location: class functions.OcrTranslateText

ping

@ace-n @eamonnmcmanus PING?

I think the ball is in @ace-n's court.


[release/1.1 backport] Bump to Go 1.11.x

backport of https://github.com/containerd/containerd/pull/2420, https://github.com/containerd/containerd/pull/2436 and https://github.com/containerd/containerd/pull/2435
Go 1.12 was released, with which Go 1.10 reached end of support, so let's update this release branch to test against Go 1.11 (Go 1.12 still has some issues, but we could update to Go 1.12.1 once that's released)

Codecov Report

Merging #3078 into release/1.1 will not change coverage.
The diff coverage is n/a.

@@             Coverage Diff              @@
##           release/1.1    #3078   +/-   ##
============================================
  Coverage        49.07%   49.07%
============================================
  Files               85       85
  Lines             7598     7598
============================================
  Hits              3729     3729
  Misses            3194     3194
  Partials           675      675

Flag
Coverage Δ

#linux
49.07% <ø> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9d16e2e...8f044b8. Read the comment docs.

LGTM


Move storage code into a subpackage

This PR was created via: https://gist.github.com/dhermes/e239691aa584bd56a5352e34aad27cf3
export PROJECT_DIR="${HOME}/google-cloud-python"
export READMES_DIR="${HOME}/i-wrote-some-readmes-for-2357"
cd ${PROJECT_DIR}
git worktree add -b make-storage-subpackage ../hotfix official/master
python make_commits.py \
  --git-root "${PROJECT_DIR}/../hotfix" \
  --package storage \
  --package-name "Google Cloud Storage" \
  --readme "${READMES_DIR}/storage/README.rst"

LGTM

Won't the chnages to top-level files conflict with #2410?
The duplication across the sub-repositories (.coveragerc, MANIFEST.in, etc.) is getting worse:  to we have an issue to track stripping that out?
Likewise the duplication inside the top-level stuff (.travis.yml, tox.ini).

@tseaver Yes essentially all will conflict, but luckily I can just re-run the script (that is why I ran it).

The duplication of .coveragerc can be wrapped into a single file (put it in #2404 to track)
The duplication of MANIFEST.in is essentially necessary, just like do-nothing __init__.py files are. Also note that over time these files may take on a life of their own
The top-level stuff in (tox.ini and .travis.yml) will be greatly reduced when I address #2277

OK, LGTM

Pushed to resolve rebase conflict and re-ran script. Won't wait on Travis since a) that could be awhile and b) this will be painful.


Added support for pagination, GCP support and package bump

Pagination Support
GCP NA support
Package bump

Approved.
@sunil-lakshman Please add API test cases for the added features.

@nadeem-cs Pagination Api testcases are added in both entries and assets

Hi @nadeem-cs and @sunil-lakshman,
Kindly note that the suggested import statement differs from the one specified in the comment. Please review the following:
Original:
import contentstack from '@contentstack/delivery'

Suggested:
import contentstack from '@contentstack/delivery-sdk'

Done @ishaileshmishra & @nadeem-cs


could convert flannel to calico

mkdir -p /etc/cni/net.d/
cat < /etc/cni/net.d/10-flannel.conf
{
“name”: “cbr0”,
“type”: “flannel”,
“delegate”: {
“isDefaultGateway”: true
}
}
EOF
mkdir /usr/share/oci-umount/oci-umount.d -p
mkdir /run/flannel/
cat < /run/flannel/subnet.env
FLANNEL_NETWORK=<IP_ADDRESS>/16
FLANNEL_SUBNET=<IP_ADDRESS>/24
FLANNEL_MTU=1450
FLANNEL_IPMASQ=true
EOF
kubectl apply -f https://raw.githubusercontent.com/coreos/flannel/master/Documentation/kube-flannel.yml

@tscswcn I don't think I understand the issue you're reporting.
Can you clarify that?
/triage needs-information

/close


chore: update Poetry to 1.5.1 (last version supporting Python 3.7)

:tada: This PR is included in version 4.12.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


hinting similiar commands #151

Using leven package to calculate the difference between two strings. And displays similiar commands which have leven point smaller than 4.
@dthree please check if I'm doing wrong.

Looks really good!
Could you add in some tests? I would be interested to see the relative results based on different sets of registered commands.
4 seems like a really high edit distance. For example, if you have the commands ls, bb and ck enabled, and entered a, it would probably suggest all of the above.

I've just run gulp build and added a test suite https://gist.github.com/minhchu/4438f898a8a7bc5fcaa5c72218fca2c6
But there are some problems.
When I run only that test suite mocha --grep "hinting command", it passes. But when I run the whole test mocha`, it throws some unexpected errors:
(node) warning: possible EventEmitter memory leak detected. 11 vorpal_ui_keypres
s listeners added. Use emitter.setMaxListeners() to increase limit.

Do you have any idea ?

If you set maximum distance to 4, it still works for your example because leven distance between a and ls is 2 < 4 ...

Node gives that warning when more than 10 (?) listeners are attached to the same emitter. Try require('events').EventEmitter.defaultMaxListeners = Infinity in the test file to fix this.
Maybe Vorpal could set this automatically, the default treshold is completely arbitrary anyways.

Haven't looked far into it, but are you sure we aren't ignoring some problem?
Is this because the test instantiates at least 10 instances of Vorpal?
While developing it I only got this error when I messed something up on the prompt, and had to fix it.

Let me check again.
I think there is a problem with this approach. For example:
I have a list of commands:
foo:command
foo:anothercommand
foo:awesomecommand

When I type foo, there will be no suggestions.

Yeah, that's all considered one word, and those have a huge edit distance from foo.


Ignore files when using the 'cwd' option

I ran into a minor issue when files are not ignored when using cwd option with chokidar.watch, neither in the paths parameter with paths starting with !, nor in the ignored property of the options parameter.
I fixed it jus taking care of the cwd option in the _isIgnored function and change taking care of paths starting with ! in the add function when cwd is used.
I also tested this feature in the cwd describe in the test.js.

Thanks! Just a few code style nits, but generally looks good for merge+publish.


Advanced Filters Not Autofilling on Revisit to Patient Tab

Describe the bug
When revisiting the Patient Page, previously applied advanced filters are not autofilled in the Advanced Filter form.
To Reproduce
Steps to reproduce the behavior:

Go to Patients Tab
Apply filters
Revisit Patients Tab
Open Advance filter tab and we can the advanced filters are not auto fiiled

Expected behavior
When the Patients page is revisited, previously applied filters should automatically populate the fields in the Advanced Filter form.
Screenshots
Before navigating away (Filters applied)

After revisiting the page (Filters not autofilled)

Desktop (please complete the following information):

OS: [e.g. iOS]
Browser [e.g. chrome, safari]
Version [e.g. 22]

Smartphone (please complete the following information):

Device: [e.g. iPhone6]
OS: [e.g. iOS8.1]
Browser [e.g. stock browser, safari]
Version [e.g. 22]

Additional context
Add any other context about the problem here.

I want to work on this. Assign it to me