Dev/Stable: binance import from commandline not working (from UI it works)

Note: this is the technical bug tracker, please use other platforms for getting support and starting a (non technical) discussion. See the getting help page for details.
I'm submitting a ...
[ X] bug report
[ ] question about the decisions made in the repository
Action taken (what you did)
All other prerequisites already there as I have several other versions running and working on my dev maschine.

git clone https://github.com/askmike/gekko.git
npm install --only=production
copy sample-config.js to config-test.js
change exchange to binance in config.watch
change daterange in config.importer to:
from: "2018-04-14 00:00:00"
run:
node gekko.js -c config-test.js --import

Expected result (what you hoped would happen)
history folder should be created and there should be a binance database
NOTE!! If I import using the UI on my developer 0.5.14, then it works !!
Actual result (unexpected outcome)
history folder does not exist.
Other information (e.g. detailed explanation, stacktraces, related issues, suggestions how to fix, links for us to have context, eg. stackoverflow, etc)
C:\Trade>git clone https://github.com/askmike/gekko.git
Cloning into 'gekko'...
remote: Counting objects: 11422, done.
remote: Total 11422 (delta 0), reused 0 (delta 0), pack-reused 11422
Receiving objects: 100% (11422/11422), 3.14 MiB | 557.00 KiB/s, done.
Resolving deltas: 100% (7360/7360), done.
C:\Trade>move gekko gekko-stable
1 dir(s) moved.
C:\Trade>cd gekko-stable
C:\Trade\gekko-stable>npm install --only=production

<EMAIL_ADDRESS>install C:\Trade\gekko-stable\node_modules\websocket
(node-gyp rebuild 2> builderror.log) || (exit 0)

C:\Trade\gekko-stable\node_modules\websocket>if not defined npm_config_node_gyp (node "C:\Program Files\nodejs\node_modules\npm\node_modules\npm-lifecycle\node-gyp-bin\....\node_modules\node-gyp\bin\node-gyp.js" rebuild )  else (node "C:\Program Files\nodejs\node_modules\npm\node_modules\node-gyp\bin\node-gyp.js" rebuild )
Building the projects in this solution one at a time. To enable parallel build, please add the "/m" switch.
bufferutil.cc
win_delay_load_hook.cc
Creating library C:\Trade\gekko-stable\node_modules\websocket\build\Release\bufferutil.lib and object C:\Trade\gek
ko-stable\node_modules\websocket\build\Release\bufferutil.exp
Generating code
Finished generating code
bufferutil.vcxproj -> C:\Trade\gekko-stable\node_modules\websocket\build\Release\bufferutil.node
bufferutil.vcxproj -> C:\Trade\gekko-stable\node_modules\websocket\build\Release\bufferutil.pdb (Full PDB)
validation.cc
win_delay_load_hook.cc
Creating library C:\Trade\gekko-stable\node_modules\websocket\build\Release\validation.lib and object C:\Trade\gek
ko-stable\node_modules\websocket\build\Release\validation.exp
Generating code
Finished generating code
validation.vcxproj -> C:\Trade\gekko-stable\node_modules\websocket\build\Release\validation.node
validation.vcxproj -> C:\Trade\gekko-stable\node_modules\websocket\build\Release\validation.pdb (Full PDB)

<EMAIL_ADDRESS>install C:\Trade\gekko-stable\node_modules\sqlite3
node-pre-gyp install --fallback-to-build

[sqlite3] Success: "C:\Trade\gekko-stable\node_modules\sqlite3\lib\binding\node-v57-win32-x64\node_sqlite3.node" is installed via remote

<EMAIL_ADDRESS>postinstall C:\Trade\gekko-stable\node_modules\relieve
node links.js

added 623 packages in 43.667s
C:\Trade\gekko-stable>copy sample-config.js config-test.js
1 file(s) copied.
C:\Trade\gekko-stable>node gekko.js -c config-test.js --import
______   ________  __    __  __    __   ______

/      \ /        |/  |  /  |/  |  /  | /
/$$$$$$  |$$$$$$$$/ $$ | /$$/ $$ | /$$/ /$$$$$$  |
$$ | $$/ $$ |_    $$ |/$$/  $$ |/$$/  $$ |  $$ |
$$ |/    |$$    |   $$  $$<   $$  $$<   $$ |  $$ |
$$ |$$$$ |$$$$$/    $$$$$  \  $$$$$  \  $$ |  $$ |
$$ _$$ |$$ |_____ $$ |$$  \ $$ |$$  \ $$ _$$ |
$$    $$/ $$       |$$ | $$  |$$ | $$  |$$    $$/
$$$$$$/  $$$$$$$$/ $$/   $$/ $$/   $$/  $$$$$$/
    Gekko v0.5.14
    I'm gonna make you rich, Bud Fox.

2018-04-15 12:50:33 (INFO):     Setting up Gekko in importer mode
2018-04-15 12:50:33 (INFO):
2018-04-15 12:50:33 (WARN):     The plugin Trading Advisor does not support the mode importer. It has been disabled.
2018-04-15 12:50:33 (WARN):     The plugin Paper Trader does not support the mode importer. It has been disabled.
2018-04-15 12:50:33 (WARN):     The plugin Performance Analyzer does not support the mode importer. It has been disabled.
2018-04-15 12:50:33 (DEBUG):    No end date specified for importing, setting to 2018-04-15 10:50:33
2018-04-15 12:50:37 (DEBUG):    Processing 9649 new trades. From 2018-04-14 00:00:01 UTC to 2018-04-14 00:59:59 UTC. (an hour)
2018-04-15 12:50:42 (DEBUG):    Processing 11139 new trades. From 2018-04-14 01:00:01 UTC to 2018-04-14 01:59:58 UTC. (an hour)
2018-04-15 12:50:50 (DEBUG):    Processing 7167 new trades. From 2018-04-14 01:59:59 UTC to 2018-04-14 02:59:57 UTC. (an hour)
2018-04-15 12:50:56 (DEBUG):    Processing 5937 new trades. From 2018-04-14 02:59:58 UTC to 2018-04-14 03:59:56 UTC. (an hour)
2018-04-15 12:51:01 (DEBUG):    Processing 8354 new trades. From 2018-04-14 03:59:58 UTC to 2018-04-14 04:59:55 UTC. (an hour)
2018-04-15 12:51:03 (DEBUG):    Processing 4944 new trades. From 2018-04-14 04:59:58 UTC to 2018-04-14 05:59:54 UTC. (an hour)
2018-04-15 12:51:07 (DEBUG):    Processing 5116 new trades. From 2018-04-14 05:59:55 UTC to 2018-04-14 06:59:51 UTC. (an hour)
2018-04-15 12:51:12 (DEBUG):    Processing 11029 new trades. From 2018-04-14 06:59:54 UTC to 2018-04-14 07:59:52 UTC. (an hour)
2018-04-15 12:51:20 (DEBUG):    Processing 6476 new trades. From 2018-04-14 07:59:56 UTC to 2018-04-14 08:59:51 UTC. (an hour)
2018-04-15 12:51:22 (DEBUG):    Processing 6582 new trades. From 2018-04-14 08:59:52 UTC to 2018-04-14 09:59:50 UTC. (an hour)
2018-04-15 12:51:27 (DEBUG):    Processing 8749 new trades. From 2018-04-14 09:59:51 UTC to 2018-04-14 10:59:49 UTC. (an hour)
2018-04-15 12:51:33 (DEBUG):    Processing 7149 new trades. From 2018-04-14 10:59:51 UTC to 2018-04-14 11:59:48 UTC. (an hour)
2018-04-15 12:51:36 (DEBUG):    Processing 10804 new trades. From 2018-04-14 11:59:49 UTC to 2018-04-14 12:59:47 UTC. (an hour)
2018-04-15 12:51:43 (DEBUG):    Processing 8048 new trades. From 2018-04-14 12:59:49 UTC to 2018-04-14 13:59:43 UTC. (an hour)
2018-04-15 12:51:45 (DEBUG):    Processing 5569 new trades. From 2018-04-14 13:59:47 UTC to 2018-04-14 14:59:45 UTC. (an hour)
2018-04-15 12:51:48 (DEBUG):    Processing 5096 new trades. From 2018-04-14 14:59:46 UTC to 2018-04-14 15:59:42 UTC. (an hour)
2018-04-15 12:51:55 (DEBUG):    Processing 6486 new trades. From 2018-04-14 15:59:49 UTC to 2018-04-14 16:59:43 UTC. (an hour)
2018-04-15 12:51:58 (DEBUG):    Processing 5359 new trades. From 2018-04-14 16:59:44 UTC to 2018-04-14 17:59:42 UTC. (an hour)
2018-04-15 12:52:04 (DEBUG):    Processing 5441 new trades. From 2018-04-14 17:59:44 UTC to 2018-04-14 18:59:41 UTC. (an hour)
2018-04-15 12:52:06 (DEBUG):    Processing 4801 new trades. From 2018-04-14 18:59:42 UTC to 2018-04-14 19:59:37 UTC. (an hour)
2018-04-15 12:52:10 (DEBUG):    Processing 6460 new trades. From 2018-04-14 19:59:41 UTC to 2018-04-14 20:59:38 UTC. (an hour)
2018-04-15 12:52:13 (DEBUG):    Processing 5400 new trades. From 2018-04-14 20:59:41 UTC to 2018-04-14 21:59:38 UTC. (an hour)
2018-04-15 12:52:19 (DEBUG):    Processing 6119 new trades. From 2018-04-14 21:59:39 UTC to 2018-04-14 22:59:37 UTC. (an hour)
2018-04-15 12:52:26 (DEBUG):    Processing 6864 new trades. From 2018-04-14 22:59:41 UTC to 2018-04-14 23:59:35 UTC. (an hour)
2018-04-15 12:52:32 (DEBUG):    Processing 8132 new trades. From 2018-04-14 23:59:38 UTC to 2018-04-15 00:59:34 UTC. (an hour)
2018-04-15 12:52:35 (DEBUG):    Processing 6101 new trades. From 2018-04-15 00:59:36 UTC to 2018-04-15 01:59:34 UTC. (an hour)
2018-04-15 12:52:38 (DEBUG):    Processing 4789 new trades. From 2018-04-15 01:59:35 UTC to 2018-04-15 02:59:33 UTC. (an hour)
2018-04-15 12:52:41 (DEBUG):    Processing 3590 new trades. From 2018-04-15 02:59:34 UTC to 2018-04-15 03:59:31 UTC. (an hour)
2018-04-15 12:52:43 (DEBUG):    Processing 5404 new trades. From 2018-04-15 03:59:33 UTC to 2018-04-15 04:59:27 UTC. (an hour)
2018-04-15 12:52:48 (DEBUG):    Processing 4971 new trades. From 2018-04-15 04:59:33 UTC to 2018-04-15 05:59:21 UTC. (an hour)
2018-04-15 12:52:51 (DEBUG):    Processing 4772 new trades. From 2018-04-15 05:59:32 UTC to 2018-04-15 06:59:29 UTC. (an hour)
2018-04-15 12:52:56 (DEBUG):    Processing 4062 new trades. From 2018-04-15 06:59:30 UTC to 2018-04-15 07:59:28 UTC. (an hour)
2018-04-15 12:52:58 (DEBUG):    Processing 5091 new trades. From 2018-04-15 07:59:30 UTC to 2018-04-15 08:59:26 UTC. (an hour)
2018-04-15 12:53:01 (DEBUG):    Processing 4478 new trades. From 2018-04-15 08:59:30 UTC to 2018-04-15 09:59:25 UTC. (an hour)
2018-04-15 12:53:03 (DEBUG):    Processing 4274 new trades. From 2018-04-15 09:59:27 UTC to 2018-04-15 10:50:33 UTC. (an hour)
2018-04-15 12:53:03 (INFO):     Done importing!
C:\Trade\gekko-stable>dir history
Volume in drive C has no label.
Volume Serial Number is 60FB-0204
Directory of C:\Trade\gekko-stable
File Not Found
C:\Trade\gekko-stable>dir
Volume in drive C has no label.
Volume Serial Number is 60FB-0204
Directory of C:\Trade\gekko-stable
15-04-2018  12:49              .
15-04-2018  12:49              ..
15-04-2018  12:39                81 .dockerignore
15-04-2018  12:39               156 .editorconfig
15-04-2018  12:39                25 .env
15-04-2018  12:39              .github
15-04-2018  12:39               584 .gitignore
15-04-2018  12:39                54 .prettierrc
15-04-2018  12:39                40 .travis.yml
15-04-2018  12:39               254 appveyor.yml
15-04-2018  12:39              config
15-04-2018  12:44            10.888 config-binance-ProdBBHACandle01.js
15-04-2018  12:50            12.607 config-test.js
15-04-2018  12:39             2.697 CONTRIBUTING.md
15-04-2018  12:39              core
15-04-2018  12:39             1.182 docker-compose.yml
15-04-2018  12:39               218 docker-entrypoint.sh
15-04-2018  12:39               672 Dockerfile
15-04-2018  12:39              docs
15-04-2018  12:39              exchanges
15-04-2018  12:39             2.000 gekko.js
15-04-2018  12:39              importers
15-04-2018  12:39             1.108 LICENSE
15-04-2018  12:39              logs
15-04-2018  12:40              node_modules
15-04-2018  12:40           162.292 package-lock.json
15-04-2018  12:40             2.066 package.json
15-04-2018  12:39              plugins
15-04-2018  12:39             5.152 plugins.js
15-04-2018  12:39             1.306 README.md
15-04-2018  12:39            12.608 sample-config.js
15-04-2018  12:39              strategies
15-04-2018  12:39               639 subscriptions.js
15-04-2018  12:39              test
15-04-2018  12:39              util
15-04-2018  12:39              web
21 File(s)        216.629 bytes
15 Dir(s)  29.678.034.944 bytes free

Propably You don't use SQLite in Your config-test.js.
If You do not wait for import You can download dump from here: https://github.com/xFFFFF/Gekko-Datasets and create history folder manually.

Cool, thanks for the downloads :)
Default in sample-config.js is:
config.adapter = 'sqlite';
And it works fine with Kraken and Poloniex - with same config !
Just Binance cannot import on commandline !?
I got a bit further. if I setup using a Candle Writer, meaning setting:
config.candleWriter = {
enabled: true
}
then start it, I get binance databse files.
C:\Trade\gekko-stable>dir history
Volume in drive C has no label.
Volume Serial Number is 60FB-0204
Directory of C:\Trade\gekko-stable\history
15-04-2018  19:16              .
15-04-2018  19:16              ..
15-04-2018  19:16           200.704 binance_0.1.db
1 File(s)        200.704 bytes
2 Dir(s)  29.641.670.656 bytes free
BUT IT CAN'T USE THE DATA:
2018-04-15 17:41:01 (INFO):     Setting up Gekko in realtime mode
2018-04-15 17:41:01 (INFO):
2018-04-15 17:41:01 (INFO):     Setting up:
2018-04-15 17:41:01 (INFO):              Trading Advisor
2018-04-15 17:41:01 (INFO):              Calculate trading advice
2018-04-15 17:41:01 (INFO):              Using the strategy: ******************
2018-04-15 17:41:02 (INFO):             The trading method requests 5000 minutes of historic data. Checking availablity..
2018-04-15 17:41:02 (INFO):
2018-04-15 17:41:02 (INFO):             No usable local data available, trying to get as much as possible from the exchange..
2018-04-15 17:41:02 (INFO):             Preventing Gekko from requesting 5000 minutes of history.
2018-04-15 17:41:02 (DEBUG):            Fetching exchange data since 240 minutes ago
2018-04-15 17:41:02 (DEBUG):            Available exchange data:
2018-04-15 17:41:02 (DEBUG):                    from: 239 minutes ago
2018-04-15 17:41:02 (DEBUG):                    to: 180 minutes ago
2018-04-15 17:41:02 (DEBUG):            Unable to stitch datasets.
2018-04-15 17:41:02 (INFO):             Not seeding locally available data to the trading method.
If I move the database to a system with frontend and scan it, it says:
Unable to find datasets in the following markets:

binance:USDT:BTC

So the database is just empty.

OK :)
Look, I am working with gekko now for some months. I am not beginner ;)
One more time :)
Kraken and Poloniex works !
Binance does NOT work.
I import data from kraken and can use it anyway I like.
I cannot import data from Binance in the commandline
I started the trader to show that there is no data in the binance database.

Hmm, no idea why ... But today it works !?
There must be something in my previous config files that are disturbing things. It is strange as I use the same config files for poloniex and kraken, just changed exchange and coins...
With clean config like described here it works.
To help someone else who is in same situation. Here is what to do if import does not work.
copy sample-config.js to config-test.js
change exchange to binance in config.watch (or the exchange you want). Also change currency if you want.
Change daterange in config.importer to (the date you want to start importing data) we will import until now:
from: "2018-04-14 00:00:00"
Set candlewrite enabled: true in config-test.js:
config.candleWriter = {
enabled: true
}

run:
node gekko.js -c config-test.js --import
If you want to keep the data updated, then run this before starting import. Only works on linux ;)
nohup node gekko.js -c config-test.js &
that will run gekko in the background and write candle data into the database.


Check for previous/existing GitHub issues/module proposals

[X] I have checked for previous/existing GitHub issues/module proposals.

Check this module doesn't already exist in the module indexes

[X] I have checked for that this module doesn't already exist in the module indexes; or I'm proposing the module to be migrated from CARML/TFVM.

Bicep or Terraform?
Bicep
Module Classification?
Resource Module
Module Name
avm/res/network/network-manager
Module Details
Migration from CARML
https://github.com/ahmadabdalla/bicep-registry-modules/tree/users/ahmad/4415_networkManagers
Do you want to be the owner of this module?
Yes
Module Owner's GitHub Username (handle)
ahmadabdalla
(Optional) Secondary Module Owner's GitHub Username (handle)
No response

Hi @ahmadabdalla,
Thanks for requesting/proposing to be an AVM module owner!
We just want to confirm you agree to the below pages that define what module ownership means:

Team Definitions & RACI
Shared Specification (Bicep & Terraform)
Module Support

Any questions or clarifications needed, let us know!
If you agree, please just reply to this issue with the exact sentence below (as this helps with our automation 👍):
"I CONFIRM I WISH TO OWN THIS AVM MODULE AND UNDERSTAND THE REQUIREMENTS AND DEFINITION OF A MODULE OWNER"
Thanks,
The AVM Core Team
#RR

I CONFIRM I WISH TO OWN THIS AVM MODULE AND UNDERSTAND THE REQUIREMENTS AND DEFINITION OF A MODULE OWNER

Hi @ahmadabdalla,
Thanks for confirming that you wish to own this AVM module and understand the related requirements and responsibilities!
Before starting development, please ensure ALL the following requirements are met.
Please use the following values explicitly as provided in the module index page:

For your module:

ModuleName - for naming your module
TelemetryIdPrefix - for your module's telemetry

For your module's repository:

Repo name and folder path are defined in RepoURL
Create GitHub teams for module owners and contributors and grant them permissions as outlined here.
Grant permissions for the AVM core team and PG teams on your GitHub repo as described here.

Check if this module exists in the other IaC language. If so, collaborate with the other owner for consistency. 👍
You can now start the development of this module! ✅ Happy coding! 🎉
Please respond to this comment and request a review from the AVM core team once your module is ready to be published! Please include a link pointing to your PR, once available. 🙏
Any further questions or clarifications needed, let us know!
Thanks,
The AVM Core Team

I will be working on this issue in the next 10 days.

[x] Module published.
[x] GitHub teams are available and assigned to their parents.
[x] CODEOWNERS file updated.

Thank you for your work @ahmadabdalla! I'm closing this issue now.


My project talks to your server

Hello thanks for this library - I built React Oxide using it: https://github.com/bootrino/reactoxide

you're welcome, how can i help you?

The only suggestion I have is for you to ensure your install documentation is up to date and has been tested.
Apart from that your server works well.
Perhaps you could put a link to the React Oxide project on your projects README.MD?

done 66fb38aff35c43bb65f89be819bb681552620ebe


Better Documentation for use in Java

About this issue

Briefly describe the issue
The Documentation gives details for Kotlin only

This is related to #484 and the ProGuard item in the Readme.md https://github.com/mikepenz/AboutLibraries#proguard
.withFields(R.string::class.java.fields) is specific to Kotlin and gives a Lint error and won't compile when trying to use this option from a Java based App.
The correct value for a Java App seems to be
.withFields(R.string.class.getFields())
The other documentation on how to use was easy enough to convert from Kotlin examples to Java just the "withFields" was a bit more problematic to determine the right value

How can the issue be reproduced / sample code
Build a Release Version of a Java based App using the libary

Details

[8.8.4 ] Used library version
[4.1.0 ] Used gradle build tools version
[4.1.3 ] Used tooling / Android Studio version
[ ] Other used libraries, potential conflicting libraries

Checklist

[X ] Searched for similar issues
[X ] Checked out the sample application
[X ] Read the README
[X ] Checked out the CHANGELOG
[X ] Read the MIGRATION GUIDE

@Zardozz Java is no longer officially supported. While it may work we don't plan to provide documentation for it.
I would highly recommend that you have a look into Kotlin as it will significantly improve your work.
The last version which was officially targeting Java was v6.2.3 which can be found here: https://github.com/mikepenz/AboutLibraries/tree/v6.2.3
Beware that this old version lacks a ton of features.

I have looked in to Kotlin, it is more work than is worth it, it's a shame that you limit the usability of your library artificially and if other library developer took a similar attitude then by moving to Kotlin I would just get a bigger problem is reverse.


DataFrame.(Groupby).first Not Implemented?

Opening this to track https://github.com/ray-project/ray/issues/2262
cc @crystalzyan

Close to track #1311


Feat: Thyroid Cancer Recurrence Classification Model

I want to add a Thyroid Cancer Recurrence Classification Model. The model will be trained on the following dataset:
https://www.kaggle.com/datasets/jainaru/thyroid-disease-data/data

@arpy8 assign this issue to me

I want to work on this issue. Please assign it to me.


ParseError:Unexpected token "varying vec3 vWorldPosition;"

I'm unable to get this working with this glsl file: https://github.com/ngokevin/kframe/blob/master/components/sun-sky/shaders/vertex.glsl
browserify -t [ browserify-shader ] public/packages.js

browserify -t [ browserify-shader --parameterize=true ] public/packages.js

node_modules/aframe-sun-sky/shaders/vertex.glsl:1
varying vec3 vWorldPosition;
        ^
ParseError: Unexpected token

I'm using Browserify 13.1.1.

Hi Chris, does your vertex shader work if you run it through a parser?
Try: http://shdr.bkcore.com

I also have this problem. My shader can work with a parser.

It looks like it's trying to compile the .glsl file as JavaScript, instead of just turning it into a string. I'm also getting a similar compile error on the very first character of my shader:
#extension GL_OES_standard_derivatives : enable
^
ParseError: Unexpected character '#'


Cleanup refactor

Thanks so much for the review @devinivy! I definitely need help with testing the errors that can crop-up throughout the module, how to cause them to happen in the test file

Alright, left some more comments.  Once those are resolved I think we should merge this and do any other review in a more general passthrough for cleanup, etc.

Thx you!! 🎉

Coverage increased (+30.4%) to 100.0% when pulling 8fb5e77c9ef2daaf99d54192355775e2fbccd3b7 on cleanup-refactor into c7757356586d57d4a53c0f020dfc125b256743f9 on join-table-improvements.


Build error

I have download afone
pod install
open .xcworkspace
getting error in Bridging header file 'AbtoSipClientWrapper/AbtoSipPhoneObserver.h' file not found
thanks in advance

You either have to add the ABTO VoIP SDK or to disable the adapter if you don’t want to use it.


Multi-Graph-Supported-FalkorDB

Description
Switch graph:
Feature Introduction: Adds the switch_graph(graph_name: str) method to allow switching between graphs on the same database connection.
Why It's Needed:
Improves efficiency when working with multiple graphs under the same driver.
Removes the need to open a new connection for each graph, reducing connection overhead.
Use Case:
Ideal for applications managing several graphs simultaneously, where quick transitions between graphs are required without disconnecting or re-establishing new connections.
Goal:
Enhance performance and streamline workflows by maintaining a single connection while managing different graphs.
Fixes # (issue)
New Package?
Did I fill in the tool.llamahub section in the pyproject.toml and provide a detailed README.md for my new integration or package?

[ ] Yes
[x] No

Version Bump?
Did I bump the version in the pyproject.toml file of the package I am updating? (Except for the llama-index-core package)

[ ] Yes
[x] No

Type of Change
Please delete options that are not relevant.

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

How Has This Been Tested?
Your pull-request will likely not be merged unless it is covered by some form of impactful unit testing.

[ ] I added new unit tests to cover this change
[x] I believe this change is already covered by existing unit tests

Suggested Checklist:

[x] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] I have added Google Colab support for the newly added notebooks.
[ ] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes
[ ] I ran make format; make lint to appease the lint gods

@galshubeli is it possible to add a test or two that actually runs in CICD? Seems like coverage is quite low

@galshubeli is it possible to add a test or two that actually runs in CICD? Seems like coverage is quite low

I added tests, but I need to find a way to add an environment variable. How can I do that?

Seems like the tests you added require connecting to an actual falkordb instance
Either

mark them as skip if the instance isn't reachable
mock out the client interactions so that they can run in CICD
if falkordb has an "in-instance in-memory mode" we could use that

You're right. I'll add it to the property graph and bump the version
accordingly.
Could you assist me with the graph client? Specifically, is it possible to
use Docker in your CI? Additionally, I haven't been able to find a way to
mock the client while still testing the graph methods.
Thank you very much for your help!
Best regards,
Gal Shubeli
On Thu, 17 Oct 2024 at 19:44, Logan @.***> wrote:

@.**** commented on this pull request.
Can you bump the version of the integration? (I can't actually push to the
PR branch)
—
Reply to this email directly, view it on GitHub
https://github.com/run-llama/llama_index/pull/16482#pullrequestreview-2375765023,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/A5ZB2FS3EJ6YUPCKQQFJ6I3Z37SPJAVCNFSM6AAAAABPWCDB5KVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDGNZVG43DKMBSGM
.
You are receiving this because you were mentioned.Message ID:
@.***>

Can you bump the version of the integration? (I can't actually push to the PR branch)

Is there a way to use Docker in this workflow? Mocking the client not test the connection with the graph.
@logan-markewich

@galshubeli you can technically spin up docker yea, there's a few unit tests that do this
Check out llama-index-integrations/vector-stores/llama-index-vector-stores-redis/tests
But also, mocking the client is fine, assuming the mocked responses are accurate


Bevy 0.14 on master

updates cargo.toml to have the 0.14, removes unneeded features (https://github.com/bevyengine/bevy/issues/13728 was resolved) and bumps version

Thanks! I opened #250 since I had to rebase and update a couple of files.


On debian system, simple_pose.sh and pose_camera.py run failed with RuntimeError error.

Description
our system version was 5.10.64
cat /proc/version
Linux version 5.10.64 (builder@f1f16f0420d2) (aarch64-linux-gnu-gcc (Debian 10.2.1-6) 10.2.1 20210110, GNU ld (GNU Binutils for Debian) 2.35.2) #1 SMP PREEMPT Wed Jan 12 08:21:50 UTC 2022
root@iot2050-debian:~/coral/project-posenet#

when executed python3 simple_pose.py, it meet this error. we had reboot it but always meet this error, same error occurred when executed python3 pose_camera.py.
root@iot2050-debian:~/coral/project-posenet# python3 simple_pose.py
Traceback (most recent call last):
  File "/root/coral/project-posenet/simple_pose.py", line 28, in <module>
    poses, inference_time = engine.DetectPosesInImage(pil_image)
  File "/root/coral/project-posenet/pose_engine.py", line 127, in DetectPosesInImage
    self.run_inference(input_data.flatten())
  File "/root/coral/project-posenet/pose_engine.py", line 102, in run_inference
    edgetpu.run_inference(self._interpreter, input_data)
  File "/usr/lib/python3/dist-packages/pycoral/utils/edgetpu.py", line 205, in run_inference
    invoke_with_membuffer(interpreter_handle, input_data.ctypes.data,
RuntimeError: InvokeWithMemBuffer failed: Subgraph is already in use. Using an interpreter or a subgraph in multiple threads is not supported. Recursion in the graph is not supported.
root@iot2050-debian:~/coral/project-posenet#

Click to expand!
Issue Type
Support
Operating System
Linux
Coral Device
Mini PCIe
Other Devices
No response
Programming Language
Python 3.9
Relevant Log Output
cat /proc/version
Linux version 5.10.64 (builder@f1f16f0420d2) (aarch64-linux-gnu-gcc (Debian 10.2.1-6) 10.2.1 20210110, GNU ld (GNU Binutils for Debian) 2.35.2) #1 SMP PREEMPT Wed Jan 12 08:21:50 UTC 2022
root@iot2050-debian:~/coral/project-posenet#

when executed python3 simple_pose.py, it meet this error. we had reboot it but always meet this error

root@iot2050-debian:~/coral/project-posenet# python3 simple_pose.py
Traceback (most recent call last):
  File "/root/coral/project-posenet/simple_pose.py", line 28, in <module>
    poses, inference_time = engine.DetectPosesInImage(pil_image)
  File "/root/coral/project-posenet/pose_engine.py", line 127, in DetectPosesInImage
    self.run_inference(input_data.flatten())
  File "/root/coral/project-posenet/pose_engine.py", line 102, in run_inference
    edgetpu.run_inference(self._interpreter, input_data)
  File "/usr/lib/python3/dist-packages/pycoral/utils/edgetpu.py", line 205, in run_inference
    invoke_with_membuffer(interpreter_handle, input_data.ctypes.data,
RuntimeError: InvokeWithMemBuffer failed: Subgraph is already in use. Using an interpreter or a subgraph in multiple threads is not supported. Recursion in the graph is not supported.
root@iot2050-debian:~/coral/project-posenet#

Hi hjonnala,
Thanks for your replay, I check them like following:
root@iot2050-debian:~# python3
Python 3.9.2 (default, Feb 28 2021, 17:03:44)
[GCC 10.2.1 20210110] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> import tflite_runtime as tflite
>>> import pycoral
>>> from pycoral.utils.edgetpu import get_runtime_version
>>> get_runtime_version()
'BuildLabel(COMPILER=10.2.1 20210110,DATE=Dec  9 2021,TIME=20:56:53), RuntimeVersion(14)'
>>> tflite.__version__
'2.5.0'
>>> pycoral.__version__
'2.0.0'
>>>

Hi, the error is due to tflite runtime version.
Please uninstall pycoral and tflite runtime and install it using again with sudo apt-get install python3-pycoral..

Seems like it is resolved in latest meta-coral by moving to tflite 2.5.2.
@hjonnala We cannot use your pre-compiled binaries because we want to redistribute them, and that implies reproducibility without binary dependencies. Also, we'd like to get all this properly packaged by Debian one day so that most user do not need to fall back to an extra repo any more to get started. meta-coral is a stepping stone for that vision.

Hi @jan-kiszka pleae check this page to build Coral libraries for your application: https://coral.ai/docs/notes/build-coral/
Thanks!


refactor(protocol): name address manager param clearer

Given that we have two address manages (shared and rollup), naming parameters this way is less confusing.

this looks good, and the parameter naming is much more clearer now


Google Apps Script to blogger API

Expected Behavior
I try to access the https://developers.google.com/apis-explorer/#search/stats/m/blogger/v3/blogger.pageViews.get with Google Apps Script.
Sample URL:
Description:
function bloggerAPI() {

  var api = "https://www.googleapis.com/blogger/v3/users/self/blogs";

  var headers = {
    "Authorization": "Bearer " + getService().getAccessToken()
  };

  var options = {
    "headers": headers,
    "method" : "GET",
    "muteHttpExceptions": true
  };

  var response = UrlFetchApp.fetch(api, options);

  var json = JSON.parse(response.getContentText());

  for (var i in json.items) {
    Logger.log("[%s] %s %s", json.items[i].id, json.items[i].name, json.items[i].url);
  }
}

Actual Behavior
ReferenceError: "getService" is not defined. (line 18, file "Code")
Steps to Reproduce the Problem

write the code
the project is link for authorization
1.I got the error

Hi!
Just replace the line 18, file "Code" with Authorization": "Bearer " + ScriptApp.getOAuthToken(). After that open the manifest file and add at least the next json:
{
  "timeZone": "Europe/Moscow",
  "dependencies": {
  },
  "exceptionLogging": "STACKDRIVER",
  "oauthScopes": [
    "https://www.googleapis.com/auth/blogger",
    "https://www.googleapis.com/auth/script.external_request"
  ]
}

It should be fine.

For general support, see https://developers.google.com/apps-script/support

Because I start with Apps Script and try to use the project ... according to this note:
Warning: Starting on or after April 8, 2019, the Google Cloud Platform Console won't be able to access the default GCP projects created for new Apps Script projects. Older, existing scripts may have default GCP projects that are still accessible, however. If you have a new script and require access to its GCP project from the Google Cloud Platform Console, you must use a standard GCP project.
https://developers.google.com/apps-script/guides/cloud-platform-projects#standard_cloud_platform_projects
The error is clear :
You do not have sufficient permissions to view this page
There was an error while loading /apis/credentials/consent?folder=&organizationId=&project=xxxx.

You are missing at least one of the following required permissions:
Project

clientauthconfig.brands.get
oauthconfig.verification.get
resourcemanager.projects.get


Version Packages (beta)

This PR was opened by the Changesets release GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to beta, this PR will be updated.
⚠⚠⚠⚠⚠⚠
beta is currently in pre mode so this branch has prereleases rather than normal releases. If you want to exit prereleases, run changeset pre exit on beta.
⚠⚠⚠⚠⚠⚠
Releases
<EMAIL_ADDRESS>Minor Changes

#388 58425e6 Thanks @mrcjhicks! - Updated avatar and avatar group tokens
Description

Updated avatar size tokens, including all sizes from 75 to 700
Added new avatar size tokens, from 800 to 1500
Added new avatar border thickness and color tokens
Added avatar group size tokens, from 50 to 500
Added avatar group spacing tokens, from 50 to 500

Motivation and context

Avatar: added new sizes and updated existing sizes to better match other components and work across a variety of use cases.

⚠ Important note: Accepting updates from this release will update the avatar sizes. The largest change in size is 8px. In some cases, you may want to relink to a new size. View the migration guide below to find the closest recommended size:

Former avatar size
Available avatar size

size 50 (16 x 16)
size 50 (16 x 16)

size 75 (18 x 18)
size 50 (16 x 16) or size 75 (20 x 20)

size 100 (20 x 20)
size 75 (20 x 20)

size 200 (22 x 22)
size 75 (20 x 20) or size 100 (24 x 24)

size 300 (26 x 26)
size 100 (24 x 24) or size 200 (28 x 28)

size 400 (28 x 28)
size 200 (28 x 28)

size 500 (32 x 32)
size 300 (32 x 32)

size 600 (36 x 36)
size 400 (36 x 36)

size 700 (40 x 40)
size 500 (40 x 40)

--
size 600 (44 x 44)

--
size 700 (48 x 48)

--
size 800 (52 x 52)

--
size 900 (56 x 56)

--
size 1000 (64 x 64)

--
size 1100 (72 x 72)

--
size 1200 (80 x 80)

--
size 1300 (88 x 88)

--
size 1400 (96 x 96)

--
size 1500 (104 x 104)

Token Diff
Tokens added (24):

avatar-border-color
avatar-border-width
avatar-group-size-100
avatar-group-size-200
avatar-group-size-300
avatar-group-size-400
avatar-group-size-50
avatar-group-size-500
avatar-group-size-75
avatar-size-1000
avatar-size-1100
avatar-size-1200
avatar-size-1300
avatar-size-1400
avatar-size-1500
avatar-size-800
avatar-size-900
avatar-to-avatar-100
avatar-to-avatar-200
avatar-to-avatar-300
avatar-to-avatar-400
avatar-to-avatar-50
avatar-to-avatar-500
avatar-to-avatar-75

Token values updated (8):

avatar-size-100
avatar-size-200
avatar-size-300
avatar-size-400
avatar-size-500
avatar-size-600
avatar-size-700
avatar-size-75

<EMAIL_ADDRESS>Patch Changes

Updated dependencies [58425e6]:

<EMAIL_ADDRESS>

Run report for ceccf084
Total time: 28s | Comparison time: 27.7s | Estimated loss: 302.9ms (1.1% slower)

Action
Time
Status
Info

🟩
SyncWorkspace
4.8ms
Passed

⬛
SetupToolchain(node:~20.12)
1.3s
Skipped

🟩
SyncProject(node, root)
0.2ms
Passed

🟩
SyncProject(node, tokens)
0.3ms
Passed

🟩
SyncProject(node, csvGenerator)
0.1ms
Passed

🟩
InstallWorkspaceDeps(node:~20.12)
5.5s
Passed

🟩
RunTask(csvGenerator:generateCSV)
262.2ms
Passed

🟩
RunTask(tokens:buildManifest)
253.8ms
Passed

🟩
RunTask(csvGenerator:test)
1.3s
Passed

🟩
RunTask(root:test)
1.5s
Passed

🟩
RunTask(tokens:buildTokens)
19s
Passed

🟩
RunTask(tokens:build)
16.7ms
Passed

🟩
RunTask(tokens:generateDiffResult)
2.1s
Passed

Touched files
.changeset/pre.json
packages/tokens/CHANGELOG.md
packages/tokens/package.json
tools/token-csv-generator/CHANGELOG.md
tools/token-csv-generator/package.json


PRed my :fire: mixtape fam

This 🌮is so spicy you'll need a 🚒all up in your 👂holes

Partial implementation of additional tape @blha303

PLEASE EVACUATE THE SITE!

Added fire alarms so people know how 🔥 this is

Accidental syncopation because why not
🔥🔥🔥🔥
🔥 🚨 🔥
🔥 🚒 🔥
🔥🔥 🔥🔥

It's time for a reeeeeemix

Unbelievably good. 5/5

@md678685 tape content enhanced

Sounds the same to me

It is the same, it just has more 📼


Organized Standard Library

Also:

Added library use to README.md
Updated scripts already using library functions
Added a few more library modules to flesh out (e.g., transposition—I have many functions to go there)
Maybe a few more scripts?

Do we know for sure that forward slash path names work on Windows?
On Fri, Jun 12, 2020 at 12:40 PM Nick Mazuk<EMAIL_ADDRESS>wrote:

@Nick-Mazuk https://github.com/Nick-Mazuk requested your review on: #13
https://github.com/Nick-Mazuk/jw-lua-scripts/pull/13 Organized Standard
Library.
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
https://github.com/Nick-Mazuk/jw-lua-scripts/pull/13#event-3439365247,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ACYB6X4AP27OURK2TFRAUBLRWJR5XANCNFSM4N4QS6MQ
.

I don't know, nor do I know how to test it.
Bit it looks like there's a Lua function AssureEndingPathDelimiter() for finale.FCString() that adds the correct path delimiter for the OS. Perhaps we can use that?
Like perhaps:
local path = finale.FCString()
path:SetRunningLuaFolderPath()
path:AssureEndingPathDelimiter()
path.LuaString = path.LuaString .. library
path:AssureEndingPathDelimiter()
package.path = package.path .. ";" .. path.LuaString .. "?.lua"
Seems like that's more complicated than it can be.
On Fri, Jun 12, 2020 at 10:57 AM, rpatters1 <<EMAIL_ADDRESS>> wrote:

Do we know for sure that forward slash path names work on Windows?
On Fri, Jun 12, 2020 at 12:40 PM Nick Mazuk < notifications@ github. com (
<EMAIL_ADDRESS>) >
wrote:

@Nick-Mazuk < https:/ / github. com/ Nick-Mazuk (
https://github.com/Nick-Mazuk ) > requested your review on: #13
< https:/ / github. com/ Nick-Mazuk/ jw-lua-scripts/ pull/ 13 (
https://github.com/Nick-Mazuk/jw-lua-scripts/pull/13 ) > Organized Standard

Library.
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
< https:/ / github. com/ Nick-Mazuk/ jw-lua-scripts/ pull/ 13#event-3439365247
( https://github.com/Nick-Mazuk/jw-lua-scripts/pull/13#event-3439365247 ) >,

or unsubscribe
< https:/ / github. com/ notifications/ unsubscribe-auth/ ACYB6X4AP27OURK2TFRAUBLRWJR5XANCNFSM4N4QS6MQ
(
https://github.com/notifications/unsubscribe-auth/ACYB6X4AP27OURK2TFRAUBLRWJR5XANCNFSM4N4QS6MQ
) >
.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub (
https://github.com/Nick-Mazuk/jw-lua-scripts/pull/13#issuecomment-643409733
) , or unsubscribe (
https://github.com/notifications/unsubscribe-auth/ABLFUIY4RUJZKTTTMV3QFUTRWJT7NANCNFSM4N4QS6MQ
).

Before we add all the clunky code everywhere, let me test it on windows. I
think it will work, but we need to be certain. Also, there's a (slightly)
cleaner way to get the delimiter if it doesn't work.
On Fri, Jun 12, 2020 at 1:15 PM Nick Mazuk<EMAIL_ADDRESS>wrote:

I don't know, nor do I know how to test it.
Bit it looks like there's a Lua function AssureEndingPathDelimiter() for
finale.FCString() that adds the correct path delimiter for the OS. Perhaps
we can use that?
Like perhaps:
local path = finale.FCString()
path:SetRunningLuaFolderPath()
path:AssureEndingPathDelimiter()
path.LuaString = path.LuaString .. library
path:AssureEndingPathDelimiter()
package.path = package.path .. ";" .. path.LuaString .. "?.lua"
Seems like that's more complicated than it can be.
On Fri, Jun 12, 2020 at 10:57 AM, rpatters1 <<EMAIL_ADDRESS>>
wrote:

Do we know for sure that forward slash path names work on Windows?
On Fri, Jun 12, 2020 at 12:40 PM Nick Mazuk < notifications@ github.
com (
<EMAIL_ADDRESS>) >
wrote:

@Nick-Mazuk < https:/ / github. com/ Nick-Mazuk (
https://github.com/Nick-Mazuk ) > requested your review on: #13
< https:/ / github. com/ Nick-Mazuk/ jw-lua-scripts/ pull/ 13 (
https://github.com/Nick-Mazuk/jw-lua-scripts/pull/13 ) > Organized
Standard

Library.
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
< https:/ / github. com/ Nick-Mazuk/ jw-lua-scripts/ pull/
13#event-3439365247
( https://github.com/Nick-Mazuk/jw-lua-scripts/pull/13#event-3439365247
) >,

or unsubscribe
< https:/ / github. com/ notifications/ unsubscribe-auth/
ACYB6X4AP27OURK2TFRAUBLRWJR5XANCNFSM4N4QS6MQ
(

https://github.com/notifications/unsubscribe-auth/ACYB6X4AP27OURK2TFRAUBLRWJR5XANCNFSM4N4QS6MQ

) >

.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub (

https://github.com/Nick-Mazuk/jw-lua-scripts/pull/13#issuecomment-643409733

) , or unsubscribe (

https://github.com/notifications/unsubscribe-auth/ABLFUIY4RUJZKTTTMV3QFUTRWJT7NANCNFSM4N4QS6MQ

).

—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
https://github.com/Nick-Mazuk/jw-lua-scripts/pull/13#issuecomment-643417583,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ACYB6X2CDGIKOOHT4UTMYITRWJWARANCNFSM4N4QS6MQ
.

Sounds good.
If there's a more elegant way that works, I'd opt for that.
On Fri, Jun 12, 2020 at 11:19 AM, rpatters1 <<EMAIL_ADDRESS>> wrote:

Before we add all the clunky code everywhere, let me test it on windows. I
think it will work, but we need to be certain. Also, there's a (slightly)
cleaner way to get the delimiter if it doesn't work.
On Fri, Jun 12, 2020 at 1:15 PM Nick Mazuk < notifications@ github. com (
<EMAIL_ADDRESS>) > wrote:

I don't know, nor do I know how to test it.
Bit it looks like there's a Lua function AssureEndingPathDelimiter() for

finale.FCString() that adds the correct path delimiter for the OS.
Perhaps
we can use that?
Like perhaps:
local path = finale.FCString()
path:SetRunningLuaFolderPath()
path:AssureEndingPathDelimiter()
path.LuaString = path.LuaString .. library
path:AssureEndingPathDelimiter()
package.path = package.path .. ";" .. path.LuaString .. "?.lua"
Seems like that's more complicated than it can be.
On Fri, Jun 12, 2020 at 10:57 AM, rpatters1 < notifications@ github. com
<EMAIL_ADDRESS>) >
wrote:

Do we know for sure that forward slash path names work on Windows?
On Fri, Jun 12, 2020 at 12:40 PM Nick Mazuk < notifications@ github.
com (
notifications@ github. com<EMAIL_ADDRESS>) ) >
wrote:

@Nick-Mazuk < https:/ / github. com/ Nick-Mazuk (
https:/ / github. com/ Nick-Mazuk ( https://github.com/Nick-Mazuk ) ) >
requested your review on: #13
< https:/ / github. com/ Nick-Mazuk/ jw-lua-scripts/ pull/ 13 (
https:/ / github. com/ Nick-Mazuk/ jw-lua-scripts/ pull/ 13 (
https://github.com/Nick-Mazuk/jw-lua-scripts/pull/13 ) ) > Organized
Standard

Library.
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
< https:/ / github. com/ Nick-Mazuk/ jw-lua-scripts/ pull/
13#event-3439365247
( https:/ / github. com/ Nick-Mazuk/ jw-lua-scripts/ pull/ 13#event-3439365247
( https://github.com/Nick-Mazuk/jw-lua-scripts/pull/13#event-3439365247 )
) >,

or unsubscribe
< https:/ / github. com/ notifications/ unsubscribe-auth/
ACYB6X4AP27OURK2TFRAUBLRWJR5XANCNFSM4N4QS6MQ
(

https:/ / github. com/ notifications/ unsubscribe-auth/ ACYB6X4AP27OURK2TFRAUBLRWJR5XANCNFSM4N4QS6MQ
(
https://github.com/notifications/unsubscribe-auth/ACYB6X4AP27OURK2TFRAUBLRWJR5XANCNFSM4N4QS6MQ
)

) >

.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub (

https:/ / github. com/ Nick-Mazuk/ jw-lua-scripts/ pull/ 13#issuecomment-643409733
(
https://github.com/Nick-Mazuk/jw-lua-scripts/pull/13#issuecomment-643409733
)

) , or unsubscribe (

https:/ / github. com/ notifications/ unsubscribe-auth/ ABLFUIY4RUJZKTTTMV3QFUTRWJT7NANCNFSM4N4QS6MQ
(
https://github.com/notifications/unsubscribe-auth/ABLFUIY4RUJZKTTTMV3QFUTRWJT7NANCNFSM4N4QS6MQ
)

).

—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
< https:/ / github. com/ Nick-Mazuk/ jw-lua-scripts/ pull/ 13#issuecomment-643417583
(
https://github.com/Nick-Mazuk/jw-lua-scripts/pull/13#issuecomment-643417583
) >,
or unsubscribe
< https:/ / github. com/ notifications/ unsubscribe-auth/ ACYB6X2CDGIKOOHT4UTMYITRWJWARANCNFSM4N4QS6MQ
(
https://github.com/notifications/unsubscribe-auth/ACYB6X2CDGIKOOHT4UTMYITRWJWARANCNFSM4N4QS6MQ
) >
.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub (
https://github.com/Nick-Mazuk/jw-lua-scripts/pull/13#issuecomment-643419649
) , or unsubscribe (
https://github.com/notifications/unsubscribe-auth/ABLFUI7CIBREBH3JQUM6NS3RWJWT3ANCNFSM4N4QS6MQ
).

I just tested on Windows, and it works fine. Apparently Windows has
accepted '/' as a path delimiter since DOS 2.0, as long as it wasn't on the
command line.
On Fri, Jun 12, 2020 at 1:22 PM Nick Mazuk<EMAIL_ADDRESS>wrote:

Sounds good.
If there's a more elegant way that works, I'd opt for that.
On Fri, Jun 12, 2020 at 11:19 AM, rpatters1 <<EMAIL_ADDRESS>>
wrote:

Before we add all the clunky code everywhere, let me test it on windows.
I
think it will work, but we need to be certain. Also, there's a (slightly)
cleaner way to get the delimiter if it doesn't work.
On Fri, Jun 12, 2020 at 1:15 PM Nick Mazuk < notifications@ github. com
(
<EMAIL_ADDRESS>) > wrote:

I don't know, nor do I know how to test it.
Bit it looks like there's a Lua function AssureEndingPathDelimiter()
for

finale.FCString() that adds the correct path delimiter for the OS.
Perhaps
we can use that?
Like perhaps:
local path = finale.FCString()
path:SetRunningLuaFolderPath()
path:AssureEndingPathDelimiter()
path.LuaString = path.LuaString .. library
path:AssureEndingPathDelimiter()
package.path = package.path .. ";" .. path.LuaString .. "?.lua"
Seems like that's more complicated than it can be.
On Fri, Jun 12, 2020 at 10:57 AM, rpatters1 < notifications@ github.
com
<EMAIL_ADDRESS>) >
wrote:

Do we know for sure that forward slash path names work on Windows?
On Fri, Jun 12, 2020 at 12:40 PM Nick Mazuk < notifications@ github.
com (
notifications@ github. com<EMAIL_ADDRESS>) ) >
wrote:

@Nick-Mazuk < https:/ / github. com/ Nick-Mazuk (
https:/ / github. com/ Nick-Mazuk ( https://github.com/Nick-Mazuk )
) >
requested your review on: #13
< https:/ / github. com/ Nick-Mazuk/ jw-lua-scripts/ pull/ 13 (
https:/ / github. com/ Nick-Mazuk/ jw-lua-scripts/ pull/ 13 (
https://github.com/Nick-Mazuk/jw-lua-scripts/pull/13 ) ) > Organized
Standard

Library.
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
< https:/ / github. com/ Nick-Mazuk/ jw-lua-scripts/ pull/
13#event-3439365247
( https:/ / github. com/ Nick-Mazuk/ jw-lua-scripts/ pull/
13#event-3439365247
( https://github.com/Nick-Mazuk/jw-lua-scripts/pull/13#event-3439365247
)
) >,

or unsubscribe
< https:/ / github. com/ notifications/ unsubscribe-auth/
ACYB6X4AP27OURK2TFRAUBLRWJR5XANCNFSM4N4QS6MQ
(

https:/ / github. com/ notifications/ unsubscribe-auth/
ACYB6X4AP27OURK2TFRAUBLRWJR5XANCNFSM4N4QS6MQ
(

https://github.com/notifications/unsubscribe-auth/ACYB6X4AP27OURK2TFRAUBLRWJR5XANCNFSM4N4QS6MQ

)

) >

.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub (

https:/ / github. com/ Nick-Mazuk/ jw-lua-scripts/ pull/
13#issuecomment-643409733
(

https://github.com/Nick-Mazuk/jw-lua-scripts/pull/13#issuecomment-643409733

)

) , or unsubscribe (

https:/ / github. com/ notifications/ unsubscribe-auth/
ABLFUIY4RUJZKTTTMV3QFUTRWJT7NANCNFSM4N4QS6MQ
(

https://github.com/notifications/unsubscribe-auth/ABLFUIY4RUJZKTTTMV3QFUTRWJT7NANCNFSM4N4QS6MQ

)

).

—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
< https:/ / github. com/ Nick-Mazuk/ jw-lua-scripts/ pull/
13#issuecomment-643417583
(

https://github.com/Nick-Mazuk/jw-lua-scripts/pull/13#issuecomment-643417583

) >,

or unsubscribe
< https:/ / github. com/ notifications/ unsubscribe-auth/
ACYB6X2CDGIKOOHT4UTMYITRWJWARANCNFSM4N4QS6MQ
(

https://github.com/notifications/unsubscribe-auth/ACYB6X2CDGIKOOHT4UTMYITRWJWARANCNFSM4N4QS6MQ

) >

.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub (

https://github.com/Nick-Mazuk/jw-lua-scripts/pull/13#issuecomment-643419649

) , or unsubscribe (

https://github.com/notifications/unsubscribe-auth/ABLFUI7CIBREBH3JQUM6NS3RWJWT3ANCNFSM4N4QS6MQ

).

—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
https://github.com/Nick-Mazuk/jw-lua-scripts/pull/13#issuecomment-643420676,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ACYB6X7EOTNH4BI6POGK7T3RWJW47ANCNFSM4N4QS6MQ
.

TIL. I worked on DOS and Windows as a day job from 1984-2011 and never
knew. Dang.
On Fri, Jun 12, 2020 at 1:39 PM Robert Patterson <
<EMAIL_ADDRESS>wrote:

I just tested on Windows, and it works fine. Apparently Windows has
accepted '/' as a path delimiter since DOS 2.0, as long as it wasn't on the
command line.
On Fri, Jun 12, 2020 at 1:22 PM Nick Mazuk<EMAIL_ADDRESS>wrote:

Sounds good.
If there's a more elegant way that works, I'd opt for that.
On Fri, Jun 12, 2020 at 11:19 AM, rpatters1 <<EMAIL_ADDRESS>>
wrote:

Before we add all the clunky code everywhere, let me test it on
windows. I
think it will work, but we need to be certain. Also, there's a
(slightly)
cleaner way to get the delimiter if it doesn't work.
On Fri, Jun 12, 2020 at 1:15 PM Nick Mazuk < notifications@ github.
com (
<EMAIL_ADDRESS>) > wrote:

I don't know, nor do I know how to test it.
Bit it looks like there's a Lua function AssureEndingPathDelimiter()
for

finale.FCString() that adds the correct path delimiter for the OS.
Perhaps
we can use that?
Like perhaps:
local path = finale.FCString()
path:SetRunningLuaFolderPath()
path:AssureEndingPathDelimiter()
path.LuaString = path.LuaString .. library
path:AssureEndingPathDelimiter()
package.path = package.path .. ";" .. path.LuaString .. "?.lua"
Seems like that's more complicated than it can be.
On Fri, Jun 12, 2020 at 10:57 AM, rpatters1 < notifications@ github.
com
<EMAIL_ADDRESS>) >
wrote:

Do we know for sure that forward slash path names work on Windows?
On Fri, Jun 12, 2020 at 12:40 PM Nick Mazuk < notifications@
github.
com (
notifications@ github. com<EMAIL_ADDRESS>) ) >
wrote:

@Nick-Mazuk < https:/ / github. com/ Nick-Mazuk (
https:/ / github. com/ Nick-Mazuk ( https://github.com/Nick-Mazuk
) ) >
requested your review on: #13
< https:/ / github. com/ Nick-Mazuk/ jw-lua-scripts/ pull/ 13 (
https:/ / github. com/ Nick-Mazuk/ jw-lua-scripts/ pull/ 13 (
https://github.com/Nick-Mazuk/jw-lua-scripts/pull/13 ) ) > Organized
Standard

Library.
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
< https:/ / github. com/ Nick-Mazuk/ jw-lua-scripts/ pull/
13#event-3439365247
( https:/ / github. com/ Nick-Mazuk/ jw-lua-scripts/ pull/
13#event-3439365247
( https://github.com/Nick-Mazuk/jw-lua-scripts/pull/13#event-3439365247
)
) >,

or unsubscribe
< https:/ / github. com/ notifications/ unsubscribe-auth/
ACYB6X4AP27OURK2TFRAUBLRWJR5XANCNFSM4N4QS6MQ
(

https:/ / github. com/ notifications/ unsubscribe-auth/
ACYB6X4AP27OURK2TFRAUBLRWJR5XANCNFSM4N4QS6MQ
(

https://github.com/notifications/unsubscribe-auth/ACYB6X4AP27OURK2TFRAUBLRWJR5XANCNFSM4N4QS6MQ

)

) >

.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub (

https:/ / github. com/ Nick-Mazuk/ jw-lua-scripts/ pull/
13#issuecomment-643409733
(

https://github.com/Nick-Mazuk/jw-lua-scripts/pull/13#issuecomment-643409733

)

) , or unsubscribe (

https:/ / github. com/ notifications/ unsubscribe-auth/
ABLFUIY4RUJZKTTTMV3QFUTRWJT7NANCNFSM4N4QS6MQ
(

https://github.com/notifications/unsubscribe-auth/ABLFUIY4RUJZKTTTMV3QFUTRWJT7NANCNFSM4N4QS6MQ

)

).

—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
< https:/ / github. com/ Nick-Mazuk/ jw-lua-scripts/ pull/
13#issuecomment-643417583
(

https://github.com/Nick-Mazuk/jw-lua-scripts/pull/13#issuecomment-643417583

) >,

or unsubscribe
< https:/ / github. com/ notifications/ unsubscribe-auth/
ACYB6X2CDGIKOOHT4UTMYITRWJWARANCNFSM4N4QS6MQ
(

https://github.com/notifications/unsubscribe-auth/ACYB6X2CDGIKOOHT4UTMYITRWJWARANCNFSM4N4QS6MQ

) >

.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub (

https://github.com/Nick-Mazuk/jw-lua-scripts/pull/13#issuecomment-643419649

) , or unsubscribe (

https://github.com/notifications/unsubscribe-auth/ABLFUI7CIBREBH3JQUM6NS3RWJWT3ANCNFSM4N4QS6MQ

).

—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
https://github.com/Nick-Mazuk/jw-lua-scripts/pull/13#issuecomment-643420676,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ACYB6X7EOTNH4BI6POGK7T3RWJW47ANCNFSM4N4QS6MQ
.

I never knew that either!
Interesting how Windows accepts different delimiters depending on where you use them, though.
On Fri, Jun 12, 2020 at 11:41 AM, rpatters1 <<EMAIL_ADDRESS>> wrote:

TIL. I worked on DOS and Windows as a day job from 1984-2011 and never
knew. Dang.
On Fri, Jun 12, 2020 at 1:39 PM Robert Patterson <
robert@ robertgpatterson. com<EMAIL_ADDRESS>) > wrote:

I just tested on Windows, and it works fine. Apparently Windows has
accepted '/' as a path delimiter since DOS 2.0, as long as it wasn't on
the
command line.
On Fri, Jun 12, 2020 at 1:22 PM Nick Mazuk < notifications@ github. com (
<EMAIL_ADDRESS>) >
wrote:

Sounds good.
If there's a more elegant way that works, I'd opt for that.
On Fri, Jun 12, 2020 at 11:19 AM, rpatters1 < notifications@ github. com
<EMAIL_ADDRESS>) >
wrote:

Before we add all the clunky code everywhere, let me test it on
windows. I
think it will work, but we need to be certain. Also, there's a
(slightly)
cleaner way to get the delimiter if it doesn't work.
On Fri, Jun 12, 2020 at 1:15 PM Nick Mazuk < notifications@ github.
com (
notifications@ github. com<EMAIL_ADDRESS>) ) > wrote:

I don't know, nor do I know how to test it.
Bit it looks like there's a Lua function
AssureEndingPathDelimiter()
for

finale.FCString() that adds the correct path delimiter for the OS.
Perhaps
we can use that?
Like perhaps:
local path = finale.FCString()
path:SetRunningLuaFolderPath()
path:AssureEndingPathDelimiter()
path.LuaString = path.LuaString .. library
path:AssureEndingPathDelimiter()
package.path = package.path .. ";" .. path.LuaString .. "?.lua"
Seems like that's more complicated than it can be.
On Fri, Jun 12, 2020 at 10:57 AM, rpatters1 < notifications@
github.
com
( notifications@ github. com<EMAIL_ADDRESS>) ) >
wrote:

Do we know for sure that forward slash path names work on
Windows?
On Fri, Jun 12, 2020 at 12:40 PM Nick Mazuk < notifications@
github.
com (
notifications@ github. com ( notifications@ github. com (
<EMAIL_ADDRESS>) ) ) >
wrote:

@Nick-Mazuk < https:/ / github. com/ Nick-Mazuk (
https:/ / github. com/ Nick-Mazuk ( https:/ / github. com/ Nick-Mazuk
( https://github.com/Nick-Mazuk )
) ) >
requested your review on: #13
< https:/ / github. com/ Nick-Mazuk/ jw-lua-scripts/ pull/ 13 (

https:/ / github. com/ Nick-Mazuk/ jw-lua-scripts/ pull/ 13 (
https:/ / github. com/ Nick-Mazuk/ jw-lua-scripts/ pull/ 13 (
https://github.com/Nick-Mazuk/jw-lua-scripts/pull/13 ) ) ) > Organized
Standard

Library.
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
< https:/ / github. com/ Nick-Mazuk/ jw-lua-scripts/ pull/
13#event-3439365247
( https:/ / github. com/ Nick-Mazuk/ jw-lua-scripts/ pull/
13#event-3439365247
( https:/ / github. com/ Nick-Mazuk/ jw-lua-scripts/ pull/ 13#event-3439365247
( https://github.com/Nick-Mazuk/jw-lua-scripts/pull/13#event-3439365247 )
)
) >,

or unsubscribe
< https:/ / github. com/ notifications/ unsubscribe-auth/
ACYB6X4AP27OURK2TFRAUBLRWJR5XANCNFSM4N4QS6MQ
(

https:/ / github. com/ notifications/ unsubscribe-auth/
ACYB6X4AP27OURK2TFRAUBLRWJR5XANCNFSM4N4QS6MQ
(

https:/ / github. com/ notifications/ unsubscribe-auth/ ACYB6X4AP27OURK2TFRAUBLRWJR5XANCNFSM4N4QS6MQ
(
https://github.com/notifications/unsubscribe-auth/ACYB6X4AP27OURK2TFRAUBLRWJR5XANCNFSM4N4QS6MQ
)

)

) >

.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub (

https:/ / github. com/ Nick-Mazuk/ jw-lua-scripts/ pull/
13#issuecomment-643409733
(

https:/ / github. com/ Nick-Mazuk/ jw-lua-scripts/ pull/ 13#issuecomment-643409733
(
https://github.com/Nick-Mazuk/jw-lua-scripts/pull/13#issuecomment-643409733
)

)

) , or unsubscribe (

https:/ / github. com/ notifications/ unsubscribe-auth/
ABLFUIY4RUJZKTTTMV3QFUTRWJT7NANCNFSM4N4QS6MQ
(

https:/ / github. com/ notifications/ unsubscribe-auth/ ABLFUIY4RUJZKTTTMV3QFUTRWJT7NANCNFSM4N4QS6MQ
(
https://github.com/notifications/unsubscribe-auth/ABLFUIY4RUJZKTTTMV3QFUTRWJT7NANCNFSM4N4QS6MQ
)

)

).

—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
< https:/ / github. com/ Nick-Mazuk/ jw-lua-scripts/ pull/
13#issuecomment-643417583
(

https:/ / github. com/ Nick-Mazuk/ jw-lua-scripts/ pull/ 13#issuecomment-643417583
(
https://github.com/Nick-Mazuk/jw-lua-scripts/pull/13#issuecomment-643417583
)

) >,

or unsubscribe
< https:/ / github. com/ notifications/ unsubscribe-auth/
ACYB6X2CDGIKOOHT4UTMYITRWJWARANCNFSM4N4QS6MQ
(

https:/ / github. com/ notifications/ unsubscribe-auth/ ACYB6X2CDGIKOOHT4UTMYITRWJWARANCNFSM4N4QS6MQ
(
https://github.com/notifications/unsubscribe-auth/ACYB6X2CDGIKOOHT4UTMYITRWJWARANCNFSM4N4QS6MQ
)

) >

.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub (

https:/ / github. com/ Nick-Mazuk/ jw-lua-scripts/ pull/ 13#issuecomment-643419649
(
https://github.com/Nick-Mazuk/jw-lua-scripts/pull/13#issuecomment-643419649
)

) , or unsubscribe (

https:/ / github. com/ notifications/ unsubscribe-auth/ ABLFUI7CIBREBH3JQUM6NS3RWJWT3ANCNFSM4N4QS6MQ
(
https://github.com/notifications/unsubscribe-auth/ABLFUI7CIBREBH3JQUM6NS3RWJWT3ANCNFSM4N4QS6MQ
)

).

—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
< https:/ / github. com/ Nick-Mazuk/ jw-lua-scripts/ pull/ 13#issuecomment-643420676
(
https://github.com/Nick-Mazuk/jw-lua-scripts/pull/13#issuecomment-643420676
) >,
or unsubscribe
< https:/ / github. com/ notifications/ unsubscribe-auth/ ACYB6X7EOTNH4BI6POGK7T3RWJW47ANCNFSM4N4QS6MQ
(
https://github.com/notifications/unsubscribe-auth/ACYB6X7EOTNH4BI6POGK7T3RWJW47ANCNFSM4N4QS6MQ
) >
.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub (
https://github.com/Nick-Mazuk/jw-lua-scripts/pull/13#issuecomment-643428352
) , or unsubscribe (
https://github.com/notifications/unsubscribe-auth/ABLFUIYEVVXPORKAW6XFJQDRWJZETANCNFSM4N4QS6MQ
).

According to the Google, Windows using '' was an accident of history due
to the DOS command line treating '/' as an option flag. (Instead of the
more familiar '-'.) So only the command line parser ever cared, and then
only when it was ambiguous. Google says you could always "CD ./subdir" for
example, because that isn't ambiguous.
On Fri, Jun 12, 2020 at 1:58 PM Nick Mazuk<EMAIL_ADDRESS>wrote:

I never knew that either!
Interesting how Windows accepts different delimiters depending on where
you use them, though.
On Fri, Jun 12, 2020 at 11:41 AM, rpatters1 <<EMAIL_ADDRESS>>
wrote:

TIL. I worked on DOS and Windows as a day job from 1984-2011 and never
knew. Dang.
On Fri, Jun 12, 2020 at 1:39 PM Robert Patterson <
robert@ robertgpatterson. com<EMAIL_ADDRESS>) > wrote:

I just tested on Windows, and it works fine. Apparently Windows has
accepted '/' as a path delimiter since DOS 2.0, as long as it wasn't on
the
command line.
On Fri, Jun 12, 2020 at 1:22 PM Nick Mazuk < notifications@ github.
com (
<EMAIL_ADDRESS>) >
wrote:

Sounds good.
If there's a more elegant way that works, I'd opt for that.
On Fri, Jun 12, 2020 at 11:19 AM, rpatters1 < notifications@ github.
com
<EMAIL_ADDRESS>) >
wrote:

Before we add all the clunky code everywhere, let me test it on
windows. I
think it will work, but we need to be certain. Also, there's a
(slightly)
cleaner way to get the delimiter if it doesn't work.
On Fri, Jun 12, 2020 at 1:15 PM Nick Mazuk < notifications@ github.
com (
notifications@ github. com<EMAIL_ADDRESS>) ) > wrote:

I don't know, nor do I know how to test it.
Bit it looks like there's a Lua function
AssureEndingPathDelimiter()
for

finale.FCString() that adds the correct path delimiter for the OS.
Perhaps
we can use that?
Like perhaps:
local path = finale.FCString()
path:SetRunningLuaFolderPath()
path:AssureEndingPathDelimiter()
path.LuaString = path.LuaString .. library
path:AssureEndingPathDelimiter()
package.path = package.path .. ";" .. path.LuaString .. "?.lua"
Seems like that's more complicated than it can be.
On Fri, Jun 12, 2020 at 10:57 AM, rpatters1 < notifications@
github.
com
( notifications@ github. com<EMAIL_ADDRESS>) ) >
wrote:

Do we know for sure that forward slash path names work on
Windows?
On Fri, Jun 12, 2020 at 12:40 PM Nick Mazuk < notifications@
github.
com (
notifications@ github. com ( notifications@ github. com (
<EMAIL_ADDRESS>) ) ) >
wrote:

@Nick-Mazuk < https:/ / github. com/ Nick-Mazuk (
https:/ / github. com/ Nick-Mazuk ( https:/ / github. com/
Nick-Mazuk
( https://github.com/Nick-Mazuk )
) ) >
requested your review on: #13
< https:/ / github. com/ Nick-Mazuk/ jw-lua-scripts/ pull/ 13
(

https:/ / github. com/ Nick-Mazuk/ jw-lua-scripts/ pull/ 13 (
https:/ / github. com/ Nick-Mazuk/ jw-lua-scripts/ pull/ 13 (
https://github.com/Nick-Mazuk/jw-lua-scripts/pull/13 ) ) ) > Organized
Standard

Library.
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
< https:/ / github. com/ Nick-Mazuk/ jw-lua-scripts/ pull/
13#event-3439365247
( https:/ / github. com/ Nick-Mazuk/ jw-lua-scripts/ pull/
13#event-3439365247
( https:/ / github. com/ Nick-Mazuk/ jw-lua-scripts/ pull/
13#event-3439365247
( https://github.com/Nick-Mazuk/jw-lua-scripts/pull/13#event-3439365247
)
)
) >,

or unsubscribe
< https:/ / github. com/ notifications/ unsubscribe-auth/
ACYB6X4AP27OURK2TFRAUBLRWJR5XANCNFSM4N4QS6MQ
(

https:/ / github. com/ notifications/ unsubscribe-auth/
ACYB6X4AP27OURK2TFRAUBLRWJR5XANCNFSM4N4QS6MQ
(

https:/ / github. com/ notifications/ unsubscribe-auth/
ACYB6X4AP27OURK2TFRAUBLRWJR5XANCNFSM4N4QS6MQ
(

https://github.com/notifications/unsubscribe-auth/ACYB6X4AP27OURK2TFRAUBLRWJR5XANCNFSM4N4QS6MQ

)

)

) >

.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub (

https:/ / github. com/ Nick-Mazuk/ jw-lua-scripts/ pull/
13#issuecomment-643409733
(

https:/ / github. com/ Nick-Mazuk/ jw-lua-scripts/ pull/
13#issuecomment-643409733
(

https://github.com/Nick-Mazuk/jw-lua-scripts/pull/13#issuecomment-643409733

)

)

) , or unsubscribe (

https:/ / github. com/ notifications/ unsubscribe-auth/
ABLFUIY4RUJZKTTTMV3QFUTRWJT7NANCNFSM4N4QS6MQ
(

https:/ / github. com/ notifications/ unsubscribe-auth/
ABLFUIY4RUJZKTTTMV3QFUTRWJT7NANCNFSM4N4QS6MQ
(

https://github.com/notifications/unsubscribe-auth/ABLFUIY4RUJZKTTTMV3QFUTRWJT7NANCNFSM4N4QS6MQ

)

)

).

—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
< https:/ / github. com/ Nick-Mazuk/ jw-lua-scripts/ pull/
13#issuecomment-643417583
(

https:/ / github. com/ Nick-Mazuk/ jw-lua-scripts/ pull/
13#issuecomment-643417583
(

https://github.com/Nick-Mazuk/jw-lua-scripts/pull/13#issuecomment-643417583

)

) >,

or unsubscribe
< https:/ / github. com/ notifications/ unsubscribe-auth/
ACYB6X2CDGIKOOHT4UTMYITRWJWARANCNFSM4N4QS6MQ
(

https:/ / github. com/ notifications/ unsubscribe-auth/
ACYB6X2CDGIKOOHT4UTMYITRWJWARANCNFSM4N4QS6MQ
(

https://github.com/notifications/unsubscribe-auth/ACYB6X2CDGIKOOHT4UTMYITRWJWARANCNFSM4N4QS6MQ

)

) >

.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub (

https:/ / github. com/ Nick-Mazuk/ jw-lua-scripts/ pull/
13#issuecomment-643419649
(

https://github.com/Nick-Mazuk/jw-lua-scripts/pull/13#issuecomment-643419649

)

) , or unsubscribe (

https:/ / github. com/ notifications/ unsubscribe-auth/
ABLFUI7CIBREBH3JQUM6NS3RWJWT3ANCNFSM4N4QS6MQ
(

https://github.com/notifications/unsubscribe-auth/ABLFUI7CIBREBH3JQUM6NS3RWJWT3ANCNFSM4N4QS6MQ

)

).

—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
< https:/ / github. com/ Nick-Mazuk/ jw-lua-scripts/ pull/
13#issuecomment-643420676
(

https://github.com/Nick-Mazuk/jw-lua-scripts/pull/13#issuecomment-643420676

) >,

or unsubscribe
< https:/ / github. com/ notifications/ unsubscribe-auth/
ACYB6X7EOTNH4BI6POGK7T3RWJW47ANCNFSM4N4QS6MQ
(

https://github.com/notifications/unsubscribe-auth/ACYB6X7EOTNH4BI6POGK7T3RWJW47ANCNFSM4N4QS6MQ

) >

.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub (

https://github.com/Nick-Mazuk/jw-lua-scripts/pull/13#issuecomment-643428352

) , or unsubscribe (

https://github.com/notifications/unsubscribe-auth/ABLFUIYEVVXPORKAW6XFJQDRWJZETANCNFSM4N4QS6MQ

).

—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
https://github.com/Nick-Mazuk/jw-lua-scripts/pull/13#issuecomment-643434791,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ACYB6X6DP377SHJZSBOBE33RWJ3DHANCNFSM4N4QS6MQ
.


Fixes cropped carousel items in Safari

This fixes a deviation of the carousel rendering between Chrome and Safari.
⬅ Chrome | Safari ➡
Before
Before it looked on large screens like this (left: Chrome, right: Safari):

After
After applying this fix, it looks correct:

This fix does not change rendering on small screens. Before and after look like this:

Thx Jan


[8.x] Fix forwarded call with named arguments

This PR fixes one instance where passing named arguments is currently broken.
// Doesn't work before this PR, ends up calling the base `listContents` method
// with arguments `true, false` instead of `'', true`

app('filesystem')->listContents(recursive: true);

Laravel's support policy is very clear that named arguments are not guaranteed to be backwards-compatible:

PHP's named arguments functionality are not covered by Laravel's backwards compatibility guidelines [...] using named arguments when calling Laravel methods should be done cautiously.

However, the array_values call that this PR removes explicitly prevents named arguments from being used at all, even if the developer is using them intentionally and understands the implications of doing so.
I understand that there are a lot of strong opinions about whether named arguments are a good idea, and personally I agree with the decision to exclude them from any backwards-compatibility guarantees, but they are part of the language so it makes sense for it to at least be possible to use them.
See also #38066.

Is it possible this array_values call was present for some other reason?

It was added as a replacement for call_user_func_array to make Laravel 6 compatible with PHP 8, here: https://github.com/laravel/framework/commit/82ffe3cd4a72887ba3e6f8f4bf8fa28fda1f3691#diff-4f23ce415eb581db9639b4aba229a0c5df474b436a7dd46a075a06dcbb4532db
There are several other very similar places in the framework doing this kind of thing with __call() and it's inconsistent, some of them use ...array_values($parameters) and some just use ...$parameters. Even in that commit, it was done differently in different places.
Honestly I think array_values is there just to discourage/prevent use of named arguments (and I totally understand discouraging using them I just don't want it to be prevented entirely). @GrahamCampbell would probably know for sure though.

I don't think you can even unpack an array with string keys until PHP 8.1?

I've tested this on PHP 8 and 8.1 and it works in function arguments (but not in something like ['one', ...['two' => 'three']]). I'll try on 7.4.

Technically it doesn't work on PHP 7.4 but you'd never be able to get that far because there aren't named arguments in PHP 7.4, so the $parameters array would never have string keys.

Okay cool, I just tried it with call_user_func_array too and named arguments actually work fine there, it can handle an associative array. So even though PHP 8 wasn't out/supported, technically this used to work before it was updated to use argument unpacking with ... instead.

Last comment I swear 😅 after looking through every array_values call in the framework, I think this is actually the one and only place this is broken, specifically because it's inside a __call(). Other magic methods in the framework don't call array_values on their parameters like this, and everywhere else array_values is used it's on user input, which makes sense because you don't know if it has string keys or not. Inside magic methods though it's safe not to.


RoundedBoxView <IP_ADDRESS> is dependant to XF 1.4

I upgraded XF to <IP_ADDRESS>90 and RoundedBoxView to <IP_ADDRESS>. The plugin works perfect on Droid and iOS however I'm getting the error on WP8 project. The error disappears when I exclude the plugin from WP8.
Error	33	Cannot resolve reference assemblies. Please check the reference assemblies. Cannot resolve dependency to assembly 'Xamarin.Forms.Platform.WP8, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=null' because it has not been preloaded. When using the ReflectionOnly APIs, dependent assemblies must be pre-loaded or loaded on demand through the ReflectionOnlyAssemblyResolve event.

This is a known issue with win phone projects not respecting the Forms version dependency. I will publish a version of the nuget for Forms 2.0. That should resolve your issue

<IP_ADDRESS> is out with support for Forms 2.0
https://www.nuget.org/packages/Xam.Plugins.Forms.RoundedBoxView/
enjoy

Thank you Paul.


Enhancement: select metrics by regex/wildcard

I'd like to be able to select fields by a regular expression or a wildcard instead of having to list each of them independently in the metrics field

Regex/wildcard would be very useful for gathering SNMP data with SNMP WALK

Someone knows an alternative solution for this?


micromamba not running correctly

Describe the bug
trying to run micromamba with the instructions from wiki and get this error when running my mambashell.nix:

error    libmamba Overwriting root prefix is not permitted
critical libmamba Aborting.

Steps To Reproduce
Steps to reproduce the behavior:

install micromamba
setup a shell.nix as described here.  I called mine mambashell.nix
run nix-shell mambashell.nix

Expected behavior
was expecting to be put into a mamba environment
Screenshots
na
Additional context
https://discourse.nixos.org/t/nix-shell-with-micromamba-and-fhs/25464/8
Notify maintainers
@mausch

Metadata
Please run nix-shell -p nix-info --run "nix-info -m" and paste the result.
[user@system:~]$ nix-shell -p nix-info --run "nix-info -m"
 - system: `"x86_64-linux"`
 - host os: `Linux 6.1.68, NixOS, 23.11 (Tapir), 23.11.2130.d65bceaee0fb`
 - multi-user?: `yes`
 - sandbox: `yes`
 - version: `nix-env (Nix) 2.18.1`
 - nixpkgs: `/nix/var/nix/profiles/per-user/root/channels/nixos`

Add a :+1: reaction to issues you find important.

Does the workaround described in discourse work for you?

the method here does not work for me either.  I get this result when running micromamba activate my-mamba-environment after I enter the nix shell:

'micromamba' is running as a subprocess and can't modify the parent shell.
Thus you must initialize your shell before using activate and deactivate.
To initialize the current bash shell, run:
    $ eval "$(micromamba shell hook --shell=bash)"
and then activate or deactivate with:
    $ micromamba activate

To automatically initialize all future (bash) shells, run:
$ micromamba shell init --shell=bash --prefix=~/micromamba
Supported shells are {bash, zsh, csh, xonsh, cmd.exe, powershell, fish}.
critical libmamba Shell not initialized

when I try eval "$(micromamba shell hook --shell=bash)" followed with micromamba activate I get (still in the nix shell):

bash: hash: hashing disabled

if I ignore that and try something like mamba install matplotlib I get:

mamba: command not found

bash: hash: hashing disabled

Pretty sure you can safely ignore this.

mamba: command not found

This package is for micromamba not mamba.

ahh, I see.  I also need -c conda-forge at the end or add micromamba config append channels conda-forge to the nix shell.
It seems like less hassle when using just the base environment.  In fact, as of now, the instructions from here seem to work ok if just a base environment is needed.
{ pkgs ? import <nixpkgs> {}}:
let
  fhs = pkgs.buildFHSUserEnv {
    name = "my-fhs-environment";

    targetPkgs = _: [
      pkgs.micromamba
    ];

    profile = ''
      set -e
      eval "$(micromamba shell hook -s bash)"
      export MAMBA_ROOT_PREFIX=${builtins.getEnv "PWD"}/.mamba
      micromamba activate
      micromamba install --yes -f conda-requirements.txt -c conda-forge
      set +e
    '';
  };
in fhs.env

I guess the remaining question is... are the instructions here correct?  Seems like it would help if they were updated with what I have above, which just uses the base environment.  That said, I believe people will want to use alternate environments and I still haven't achieved this yet.  thanks for your patience.

I was able to do something like the following (this is an untested adaptation from my flake version where I use conda-lock).
{pkgs ? import <nixpkgs> {}}: let
  mambaactivation = pkgs.writeText "mambaactivation" ''
    set -e
    export MAMBA_ROOT_PREFIX=${builtins.getEnv "PWD"}/.mamba
    eval "$(micromamba shell hook --shell=bash)"
    micromamba activate
    micromamba install --yes -f conda-requirements.txt -c conda-forge
    set +e
  '';
  fhs = pkgs.buildFHSEnv {
    name = "mamba-env";
    targetPkgs = _: [pkgs.micromamba];
    runScript = "bash --rcfile <(cat $\{HOME\}/.bashrc ${mambaactivation})";
  };
in
  fhs.env

This will always bring you to a bash shell, though usually with e.g. direnv I can stay in zsh when using devShells.

I'll close this now.
The docs I wrote in https://nixos.wiki/wiki/Python#micromamba are not pinned so it's expected they'll need to be updated as micromamba changes.
If someone finds that the docs are broken and figures out how to fix them, please just update the wiki. That's the whole point of the wiki being publicly editable :slightly_smiling_face:
As a side note I no longer use micromamba (I've switched to poetry) or a direct FHS (I've switched to https://devenv.sh/ ) so I'm no longer qualified to maintain that documentation.


gitlab: 11.5.4 -> 11.5.5 (CVE-2018-20229)

Motivation for this change
This bumps gitlab from 11.5.4 to 11.5.5, fixing CVE-2018-20229
Needs backport to 18.09.
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[x] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Assured whether relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

@GrahamcOfBorg test gitlab


feat: define user id and group instead of name in the Dockerfile

Description
Define user id and group instead of name in the Dockerfile
Note that the entry point will set the username.
Motivation
Be able to use this image in Pods qualified with security context restricted in Kubernetes and Opensift clusters.
TL'DR:

In a k8s cluster if we try to run a Pod/Container with this image as restricted without informing RunAsUser we will face the error: "container has runAsNonRoot and image will run as root …
Then, if we try to use this image in Openshift in the same circumstances we will check:
Error: container has runAsNonRoot and image has non-numeric user (memcache), cannot verify user is non-root Therefore, for a Pod/Container to be qualified to the restricted-v2 SCC (the most restricted context) we cannot use RunAsUser.

NOTE: It was checked locally with the command memcached -m 1024 -o modern -v and all worked fine.

Could we get this one merged and do a new release?

Hi @tianon,
Thank you for the reply. Following some comments inline. Note that the proposed change here is also to follow up the Dockefile good practices and ensure better security. I hope that the following info can show you why this silly, nit change is important and I can persuade you to support this change and help us out :-)

I'd honestly rather not maintain this UID explicitly like this,

We do this in the image already, see:
RUN addgroup -g 11211 memcache && adduser -D -u 11211 -G memcache memcache

https://github.com/docker-library/memcached/blob/master/alpine/Dockerfile#L3-L4
https://github.com/docker-library/memcached/blob/master/debian/Dockerfile#L3-L5

especially since there's no functional difference between the two when actually running the image

That is not true.
From Docker Docs

Note that when specifying a group for the user, the user will have only the specified group membership. Any other configured group memberships will be ignored.

When the user doesn’t have a primary group then the image (or the next instructions) will be run with the root group.

From: https://docs.docker.com/engine/reference/builder/#user
NOTE: Therefore because the container user is always a member of the root group, the container user can read and write these files.
From Dockefile best practices

https://docs.docker.com/develop/develop-images/dockerfile_best-practices/
On Kubernetes (>= 1.24) you can check
If you create a Pod/Container to be admitted as restricted and does not violate the PodSecurity with the following security context config:
spec:
      securityContext:
        runAsNonRoot: true
        seccompProfile:
          type: RuntimeDefault
      ...
      containers:
      - name: controller-manager
        securityContext:
          allowPrivilegeEscalation: false
          capabilities:
            drop:
            - ALL

The Pod/Container will not run because it would be inited as root. You will check the error container has runAsNonRoot and image will run as root …
On Openshift
To allow a workload to run as restricted(restricted-v2 SCC) you MUST leave the runAsUser field empty, or provide a value that falls within the specific user range for the namespace. Otherwise, you will only be able to run the Pod if it has access to the SCC nonroot-v2 or anyuid. Note that we cannot here define a specific userID because it will depend on the namespace. So, if I want to distribute an Operator using this image I do not know what is the ns where it will be installed and it begins to add complexities on top.
Therefore you will face issues like:
Leave the runAsUser field empty, or provide a value that falls within the specific user range for the namespace. provide a value in the ranges: [1000680000,<PHONE_NUMBER>]
Then, you can also check its docs:

Lastly, the final USER declaration in the Dockerfile should specify the user ID (numeric value) and not the user name. This allows OpenShift Container Platform to validate the authority the image is attempting to run with and prevent running images

(and one is distinctly more user-friendly to read than the other). 😬
What do you mean with and one is distinctly more user-friendly to read than the other?
The UID and GID are defined in the Dockerfile already. (as described above)
It does not change how users can run the image. It addresses what I need that I am facing beforehand but others will begin to face it when start to use it in the future versions for k8s and OCP where this restriction might begin to be enforced.
TL'DR: Regards the suggested solutions:

run the image explicitly as the user (or as any user -- it really doesn't matter which user you run this image as, and you could even choose a different one randomly every time it starts since there's no on-disk state which is what usually makes UID/GID changes difficult)

That is exactly what is not possible to do to achieve the goal.

maintain a short Dockerfile that's auto-built with just FROM memcached \n USER 11211:11211 (if it has to be baked into the image itself)

That is the alternative solution that I am trying to avoid with this PR.

implement something like a mutating admission webhook on the cluster which can pull the image and resolve the UID/GID appropriately to then dynamically update the applied configuration appropriately (which I think is the most "Kubernetes" solution to this problem)

That does not address the problem.
I hope that this content and argumentations can help us to get this one merged :-)

Please stop mentioning me.  I'm not a maintainer of this repository and I don't work for Docker either.

This is a duplicate of https://github.com/docker-library/memcached/issues/36. We already define the user ID and its primary group ID; repeating the UID information later in the Dockerfile is not something we want to do as the username is much clearer to users than just a "random" ID (especially when doing docker inspect).
This seems like a failing of Kubernetes to not support looking up the defined username and of OpenShift in both not resolving the username to an ID and not having something like an alternate method of defining a non-root uid for the namespace mapping in "restricted-v2 SCC".

HI @yosifkit,

This is a duplicate of https://github.com/docker-library/memcached/issues/36. We already define the user ID and its primary group ID; repeating the UID information later in the Dockerfile is not something we want to do as the username is much clearer to users than just a "random" ID (especially when doing docker inspect).

The current approach does not follow the good practices defined in the Docker docs, please check all info shared here  https://github.com/docker-library/memcached/issues/80 to understand the motivations.

This seems like a failing of Kubernetes to not support looking up the defined username and of OpenShift in both not resolving the username to an ID and not having something like an alternate method of defining a non-root uid for the namespace mapping in "restricted-v2 SCC".

That is not a failure.
That is how docker works. If we do not define it then the image is inited as part of the GID 0.

https://github.com/docker-library/memcached/blob/1f2afc73fbae68b30d0d0455decf60b1675af513/debian/Dockerfile#L4
We do set an explicit user ID when the user is created as the docs suggest (so it isn't non-deterministic) and we even set the primary group so that the following does not apply.

When the user doesn’t have a primary group then the image (or the next instructions) will be run with the root group.

So, no we are not going to repeat the value of that user ID in the USER directive just because the popular container orchestration platform fails to even try to look it up from the image.

Closing since it was not accepted.


enable HMR/hero page filter

cherry-pick from https://github.com/odota/ui/pull/443

Typically just link the issue in the PR and let it auto close on merge

Oh, github does that? I thought it only supports if the issue is linked in the commit message.


Which S3 bucket is used for storing data in QnABot Content Designer?

Could someone clarify which S3 bucket is used for storing data in the QnABot Content Designer?

Hi @preethy-1
Can you please clarify your questions? Which data are you referring to? the question bank, the static assets (cloud formation template) to deploy the solution, the content for kendra or bedrock kb?
Have you looked ta the solution implementation guide? https://docs.aws.amazon.com/solutions/latest/qnabot-on-aws/solution-overview.html

Hi @fhoueto-amz
Thanks for the response.
I am referring to the data that we are adding to the Content Designer, such as questions and answers for QnA and text passages. I have checked the available S3 buckets but couldn't find where these data are stored. Could you please clarify which S3 bucket is being used for storing this content?

Hi
The questions and answers and text passages added through the content designer are stored in opensearch not in S3.  Please refer to the published documentation  https://docs.aws.amazon.com/solutions/latest/qnabot-on-aws/solution-overview.html and precisely https://docs.aws.amazon.com/solutions/latest/qnabot-on-aws/how-qnabot-on-aws-works.html for more details

The architecture overview (https://docs.aws.amazon.com/solutions/latest/qnabot-on-aws/architecture-overview.html) also explains the same


Http signatures do not work in Graal native-image

When using HTTP Signatures with MAC, the native image builds fine, but fails in runtime.
Attached trace.
oops.txt

This can be worked around by
--enable-all-security-services flag when building the native image. This has a big impact on image size though, so better would be to follow steps in
https://github.com/oracle/graal/blob/master/substratevm/JCA-SECURITY-SERVICES.md to enabled it for each security provider (e.g. only when it is used)


Update demon-editor.po Italian

Hello.
I don't speak Italian, but after checking with several online translators, I have some questions.
For example, abbreviated names. Strings: 30, 36, 42, 45, 1062.
In addition, you need to clarify the meaning of the following lines. Maybe they convey the wrong meaning. Strings: 684, 927, 1038, 1224, 1257.
Also line 14 should be left as is.
Please check again. Thanks!

Hello,

For example, abbreviated names. Strings: 30, 36, 42, 45, 1062.
Italian is a very verbose language compared to English, so it isn't better use abbreviated names.

In addition, you need to clarify the meaning of the following lines. Maybe they convey the wrong meaning. Strings: 684, 927, 1038, 1224, 1257.
684 ---> There are 2 spaces between 2 a and 3 word "Cambia sul canale (Ctrl + Z)"
927 ---> With "get" do you mean "download"? If yes It's correct
1038 ---> Instead to write "...." I wrote what does the command (Extract compressed file)
1224 ---> Must be "Programma per riprodurre gli streams:"
1257 ---> It's correct...

Hi,

Italian is a very verbose language compared to English, so it isn't better use abbreviated names.

This increases the space occupied for the column. And many users find it redundant.  This also applies to 1038. Examples: Reloading... Removing... etc.
1224 is not exactly a program. This is library or framework.
927 - in this case similar to 'receive'

I have changed many things of old translation because many strings was made with Google Translator and I did understand a very little of DemonEditor so I used before in English. I think that now people understand  ALL: I translate sense of strings, not single words, and I try to make a translation that all people understand!!!

Personally, I don't see any big problems here. Especially using a different language. BUT, I am faced with the fact that many users very often have completely opposite meanings about how something should look and work.


Removing cachePath from discoverTypings and DiscoverTypingsInfo.

Removing cachePath from discoverTypings and DiscoverTypingsInfo.
With the move to using the packageNameToLocation map it is no longer required.

:+1:


python312Packages.itemloaders: 1.3.1 -> 1.3.2

Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.
meta.description for python312Packages.itemloaders is: Library to populate items using XPath and CSS with a convenient API
meta.homepage for python312Packages.itemloaders is: https://github.com/scrapy/itemloaders
meta.changelog for python312Packages.itemloaders is: https://github.com/scrapy/itemloaders/raw/v1.3.2/docs/release-notes.rst
Updates performed

Ran passthru.UpdateScript

To inspect upstream changes
Impact
Checks done

built on NixOS
The tests defined in passthru.tests, if any, passed
found 1.3.2 with grep in /nix/store/n0981svvbd23chm8zlv59qsc0m06bssg-python3.12-itemloaders-1.3.2
found 1.3.2 in filename of file in /nix/store/n0981svvbd23chm8zlv59qsc0m06bssg-python3.12-itemloaders-1.3.2

Rebuild report (if merged into master) (click to expand)

12 total rebuild path(s)

12 package rebuild(s)

First fifty rebuilds by attrpath

cewler
python311Packages.itemloaders
python311Packages.scrapy
python311Packages.scrapy-deltafetch
python311Packages.scrapy-fake-useragent
python311Packages.scrapy-splash
python312Packages.itemloaders
python312Packages.scrapy
python312Packages.scrapy-deltafetch
python312Packages.scrapy-fake-useragent
python312Packages.scrapy-splash

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/n0981svvbd23chm8zlv59qsc0m06bssg-python3.12-itemloaders-1.3.2 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A python312Packages.itemloaders https://github.com/r-ryantm/nixpkgs/archive/e3ce727a588807dfb2a7186317d4e03fdcf8b509.tar.gz

Or:
nix build github:r-ryantm/nixpkgs/e3ce727a588807dfb2a7186317d4e03fdcf8b509#python312Packages.itemloaders

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/n0981svvbd23chm8zlv59qsc0m06bssg-python3.12-itemloaders-1.3.2
ls -la /nix/store/n0981svvbd23chm8zlv59qsc0m06bssg-python3.12-itemloaders-1.3.2/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

12 packages failed to build:

cewler
cewler.dist
python311Packages.scrapy-fake-useragent
python311Packages.scrapy-fake-useragent.dist
python312Packages.scrapy
python312Packages.scrapy-deltafetch
python312Packages.scrapy-deltafetch.dist
python312Packages.scrapy-fake-useragent
python312Packages.scrapy-fake-useragent.dist
python312Packages.scrapy-splash
python312Packages.scrapy-splash.dist
python312Packages.scrapy.dist

10 packages built:

python311Packages.itemloaders
python311Packages.itemloaders.dist
python311Packages.scrapy
python311Packages.scrapy-deltafetch
python311Packages.scrapy-deltafetch.dist
python311Packages.scrapy-splash
python311Packages.scrapy-splash.dist
python311Packages.scrapy.dist
python312Packages.itemloaders
python312Packages.itemloaders.dist

Maintainer pings

[!TIP]
As a maintainer, if your package is located under pkgs/by-name/*, you can comment @NixOS/nixpkgs-merge-bot merge to automatically merge this update using the nixpkgs-merge-bot.

Add a :+1: reaction to pull requests you find important.

Result of nixpkgs-review pr 346253 at e3ce727a run on x86_64-linux 1

:x: 1 package failed to build:

python311Packages.scrapy-fake-useragent

:white_check_mark: 10 packages built:

cewler
python311Packages.itemloaders
python311Packages.scrapy
python311Packages.scrapy-deltafetch
python311Packages.scrapy-splash
python312Packages.itemloaders
python312Packages.scrapy
python312Packages.scrapy-deltafetch
python312Packages.scrapy-fake-useragent
python312Packages.scrapy-splash


Add compiler support for FreeBSD

I tried to compile wazero for FreeBSD, but got an error.
../../../../pkg/mod/github.com/tetratelabs/wazero@v0.0.0-20220529032218-029a79476b4f/internal/engine/compiler/mmap.go:74:16: undefined: syscall.Mprotect

Looks like Mprotect is not implemented in syscall.
https://github.com/golang/go/blob/aac1d3a1b12a290805ca35ff268738fb334b1ca4/src/syscall/zsyscall_freebsd_amd64.go
It is implemented in golang.org/x/sys/unix. I confirmed I could compile it after replacing syscall with golang.org/x/sys/unix.
https://github.com/golang/sys/blob/bc2c85ada10aa9b6aa9607e9ac9ad0761b95cf1d/unix/zsyscall_freebsd_amd64.go#L296-L308
If wazero needs to keep zero dependency (otherwise, need to rename it to waone?), can't we even use golang.org/x? Do you want to re-implement syscalls for other platforms in wazero?

hi @knqyf263 and thanks for reporting. yes it is indeed the goal to have zero deps. I think what you are hitting is lack of precision in our engine detection. It doesn't switch on a variant of linux so you are getting a later error like this (for the compiler). I suspect the interpreter would work, for example.
We have already added code for mmap for windows, based on demand, and ensure it with a test dimension. That allowed it to use the compiler instead of the interpreter, which doesn't have this issue.
We could add a runtimeconfig for BYOMMap easily enough so that folks can opt-into that for mmap. However, it may not be the only issue in the compiler. Our assembler has some platform specific nuance in it also. Let's first see what's going on in FreeBSD and get a test dimension up?

I'll clarify something we'll have to put into docs somehow.
The compiler has components that aren't OS-specific (the assembler) and also parts that are: the engine impl has a little and also the mmap function.
Since FreeBSD had an issue with one of these parts, we should have a test dimension to ensure it works. This doesn't mean we can all operating systems, but in this case it sounds like we should as it hit an issue and you need it and it probably won't be hard to support!

It doesn't switch on a variant of linux so you are getting a later error like this (for the compiler). I suspect the interpreter would work, for example.

I got it. So, another workaronud is wazero disables compiler for unsupported platform? Only interpreter will be available for some platform. It can be slower, but it is fine. If it is not hard to support mmap in other platforms, it is better though.

indeed I think that we accidentally use compiler where we haven't tested it is a sort of bug. The intent was to fallback to interpreter when not supported. I'll narrow the flags down as the experience is better slow vs crash.

https://github.com/tetratelabs/wazero/pull/612 to make sure no-one else gets this error. After I'll work on FreeBSD

haven't forgotten this. I will merge it while takeshi is afk next week :D

testing is very slow, but this works. However, I have no means to test freebsd+arm64 https://github.com/tetratelabs/wazero/pull/671

https://github.com/tetratelabs/wazero/pull/671 has a glitch which is I can't recreate the failure locally. Also the test setup is brittle as vagrant rate-limits us. I'm tempted to use travis to verify if there's actually a real issue or not.

looks like @mathetake's eagle eyes saved the day!


Prioritize CIIP Feature Requests

This ticket follows #1980 (Identify Feature Requests) and #100 (Prepare for Part 2).
Acceptance Criteria:

[ ] Conduct Feature Request Part 2 session on Nov. 25
[ ] Fill in values in the Feature Matrix using rankings from session
[ ] Collectively decide on features to work on

Looks like this was assigned to the cif repo - we should update to ciip.


Video is blinking while App is online and only Local Video but on other side Remote App is working Fine

I am having issue while using Twilio video SDK Every thing else is working fine but whenever I am going online Local video track is blinking anyone have faced this issue please help me out and if you need any type of code i will post it just comment out what section of code you want.
func startPreview() {
        if PlatformUtils.isSimulator {
            return
        }
        camera = TVICameraCapturer(source: .frontCamera, delegate: self)
        let videoConstraints = TVIVideoConstraints { (constraints) in
            constraints.maxSize = TVIVideoConstraintsSize640x480
            constraints.minSize = TVIVideoConstraintsSize480x360
            constraints.maxFrameRate = TVIVideoConstraintsFrameRate30
            constraints.minFrameRate = TVIVideoConstraintsFrameRate10
        }
       localVideoTrack = TVILocalVideoTrack.init(capturer: camera!, enabled: true, constraints: videoConstraints, name: "Camera")
        if (localVideoTrack == nil) {
            print("Failed to create video track")
        } else {
            localVideoTrack!.addRenderer(self.CameraView)

        }
    }

Hi @nomimalik1769,
Are you by any chance adding self.CameraView as a renderer multiple times? That's the only obvious thing I can think of that would cause the flickering that you describe.
Is the same issue reproducible for you in the QS app?
What version of the SDK?
What device?
What OS version?
Best,
Chris

I am adding video renderer in two places one is when I am going online and the other is this function tell me if I am doing this wrong Thank You.
 func subscribed(to videoTrack: TVIRemoteVideoTrack,
                    publication: TVIRemoteVideoTrackPublication,
                    for participant: TVIRemoteParticipant) {

        if (self.remoteParticipant == participant) {
            videoTrack.addRenderer(self.CameraView!)
        }
    }

Hi @nomimalik1769,
Sorry that I did not reply to your question.
It looks like you are adding self.CameraView as a renderer of both localVideoTrack and up to one remote Participant. You should create one TVIVideoView for each TVIVideoTrack that you want to display on screen. The regular QuickStart example demonstrates how to do this.
Best,
Chris

Actually, this was not the issue and also not at my end actually I was connecting my App with android mean we are working on Android and iOS both same APP and the fault was on that end and it's been solved anyway. Thank You for your reply.

Hlo
I am facing fliker issue in case of video call in twilio Help me to solve this.