Fix for spring test in multi-cloud

These changes enable spring to run live tests against Public, UsGov and China.
Update file :

sdk/spring/spring-cloud-azure-test-eventhubs-binder/test-resources.json,
sdk/spring/spring-cloud-azure-test-eventhubs-binder/src/test/resources/application.yaml

If the endpoint of Storage Blob is not specified, the checkPointStore of EventHubs points to the Public cloud by default, so add output parameter PRIMARY_STORAGE_BLOB_ENDPOINT in test-resource.json and add configuration parameter endpoint and parameter value ${PRIMARY_STORAGE_BLOB_ENDPOINT} in application.yaml

Pipeline results:
https://dev.azure.com/azure-sdk/internal/_build/results?buildId=1643816&view=results
benbp, joshfree and Xiaolu Dai for notification.

/azp run java - spring - ci

The error in compatibility-tests pipeline has been fixed in https://github.com/Azure/azure-sdk-for-java/pull/29478.

@benbp Please help merge this PR. Thanks.


integrate icons and alerts component

a simple icon integration

Thanks a lot!
I was pretty busy in the last couple of weeks and didn't find time to continue working on this so any help is much appreciated! Looks good at first sight except some dependencies which have to be devDependencies. Will look at the PR more in depth later on

I hope i can be helpful, i added alert component.

Would be very grateful if you open a new PR of each new component because it's hard to analyze changes for several components at once. Keep this one as it is but if you want to add a new component, please make a new PR

ok @cristijora , i released new PR... now i'm going to keep in mind it.

I will merge these PRs for now even though there are some changes I would require but because they are linked between them its easier if I merge them and then make my changes on top of that.
Some guidelines for further PRs

1 PR for 1 Component
Install everything under devDependencies (html-loader for example)
Make sure the component has docs and the implementation is at least functional/complete


[BUG] After Hyprland crashed, pypr refused connect

Reproducible Steps

Hyprland crashed (back to Login Manager)
Relogged in to Hyprland
Realized pyprland hotkeys are not working
pypr is running but errored out (not sure the error)
Killed pyprland with pkill pypr
Run pypr but got ConnectionRefusedError: [Errno 111] Connection refused

I was googling for 30 min if my Python env is messed up again. Then I realized the cause was Hyprland crashed last night. I restarted and pypr runs again.
Environment

OS: Arch Linux
Hyprland version: 0.45.2
pyprland version: 2.4.3

Thank you.

if you kill pypr with "kill" or "pypr exit", then it needs to be ran again in the background...
I guess in your case, the crash wasn't properly handled somehow and the socket remained, so pypr didn't start when you restarted hyprland maybe?
Next time if that happens, can you just type "pypr" in a console to see if the deamon can start ?


Add "Hall of Fame" promotion to the finish page

After they did their secret santa is the best place to promote the Hall Of Fame 😎

Thanks 👍 :)


Convert landmark to blendshape.

mediapipe is so great. But I still can't find a solution to convert from mediapipe to blendshapes. I need the names of point in blendshapes via mediapipe.
I found this issue and https://github.com/google/mediapipe/commit/ba10ae8410ce431f593c95986a230add675e5ccd.
Is there a way to apply it to Javascript? I'm using Ready Player Me's 3DModel via react-three-fiber and it's working based on blendshapes.
readyplayermemodel.glb.zip

@baronha,
Thanks for the reminding the feature request, We are marking this as Duplicate of #3421 and forwarding the request internally based on other roadmaps we will let us know if any specific update on this functionality. thank you!

It is already public in production. I will close this issue. Thank you mediapipe's team

It is already public in production. I will close this issue. Thank you mediapipe's team

Can you tell me where can I find the link for this feature?

It is already public in production. I will close this issue. Thank you mediapipe's team

Can you tell me where can I find the link for this feature?

Class in the following link provides this functionality.

https://developers.google.com/mediapipe/api/solutions/python/mp/tasks/vision/FaceLandmarker

You can find .task data from the following link:
https://github.com/google/mediapipe/tree/54e4dfc853ddb6d75004a0bb79ef72dcdd8308f9/mediapipe/tasks/testdata/vision


residual check comparing with FLT_EPSILON instead of 0 to avoid flickeri...

Removing the flickering as per issue - https://github.com/telly/TLYShyNavBar/issues/39

closes #39
Thanks!


Error while attempting to get secret from Vault

Has anyone seen this error while attempting to get the secret from the vault
020-05-13T17:06:34.2940600Z TASK [debug] *******************************************************************
2020-05-13T17:06:34.3470632Z ok: [localhost] => {
2020-05-13T17:06:34.3472376Z     "output['secrets'][0]['secret']": "VARIABLE IS NOT DEFINED!: list object has no element 0"
2020-05-13T17:06:34.3472751Z }
I can get the secret via JSON and az cli with no issue. Getting this to work via ansible it has troublesome.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: db9852a7-a21b-494a-c17e-448876f6cdf2
Version Independent ID: 1ffa0bb6-5d10-cee8-d4d9-7b3cbf829c0c
Content: Tutorial - Use Azure Key Vault with a Linux virtual machine in Ansible
Content Source: articles/ansible/key-vault-configure-vm-security.md
Service: ansible
GitHub Login: @TomArcherMsft
Microsoft Alias: tarcher

Hi @georgepapad,
Within the tutorial there is an additional task that must be added to the playbook to register the output variable.
    - name: Get latest version of a secret
      azure_rm_keyvaultsecret_info:
        vault_uri: "{{ kv_uri }}"
        name: "{{ kv_secret_name }}"
      register: output

The task uses the azure_rm_keyvaultsecret_info module to retrieve the secret from Azure Key Vault and stores the JSON output in an Ansible variable called output.
That variable is then parsed and displayed on the screen with the debug module in the following task.
    - debug:
        var: output['secrets'][0]['secret']

Can you confirm you have the above tasks within your playbook?
Thank you,

Hi @georgepapad,
Within the tutorial there is an additional task that must be added to the playbook to register the output variable.
    - name: Get latest version of a secret
      azure_rm_keyvaultsecret_info:
        vault_uri: "{{ kv_uri }}"
        name: "{{ kv_secret_name }}"
      register: output

The task uses the azure_rm_keyvaultsecret_info module to retrieve the secret from Azure Key Vault and stores the JSON output in an Ansible variable called output.
That variable is then parsed and displayed on the screen with the debug module in the following task.
    - debug:
        var: output['secrets'][0]['secret']

Can you confirm you have the above tasks within your playbook?
Thank you,

Another option would be to use '{{lookup(azure_keyvault_secret)}}`
---
- hosts: localhost
  gather_facts: false
  connection: local
  tasks:
    - name: Look up secret when ansible host is general VM
      vars:
        url: 'https://ansiblekeyvaultdev.vault.azure.net/'
        secretname: 'adminPassword'
      debug: msg="the value of this secret is {{lookup('azure_keyvault_secret',secretname,vault_url=url, client_id=client_id, secret=secret, tenant_id=tenant)}}"

Please let me know if either of these options resolves your issue. :)

Another option would be to use '{{lookup(azure_keyvault_secret)}}`
---
- hosts: localhost
  gather_facts: false
  connection: local
  tasks:
    - name: Look up secret when ansible host is general VM
      vars:
        url: 'https://ansiblekeyvaultdev.vault.azure.net/'
        secretname: 'adminPassword'
      debug: msg="the value of this secret is {{lookup('azure_keyvault_secret',secretname,vault_url=url, client_id=client_id, secret=secret, tenant_id=tenant)}}"

Please let me know if either of these options resolves your issue. :)

Please let me know if these suggestions do not resolve your issue.

Please let me know if these suggestions do not resolve your issue.


Lung CT Segmenter fails if marker are placed too fast

When new lung masks are created from a CT volume and the markers are placed too fast after pressing the "Start" button, the switch from "R-3" to "L-1" marker will sometimes be not made and the program will continue with marker "R-4". This does not happen if you wait approx. 1 s between the marker placements.

It turns out that this is caused by at least two problems:
      self.logic.updateSegmentation()

is time-consuming and not necessary during placement of initial seeds
      rightLungF = self.logic.rightLungFiducials.GetNumberOfDefinedControlPoints()

can sometimes lag behind, even after
      slicer.app.processEvents()

In these cases, GetNumberOfDefinedControlPoints misses the last set fiducial and returns a number too low.
The last commit improves placement speed, though not yet 100% safe not to place the extra unwanted markers.

Nice work!
What do you mean by "      rightLungF = self.logic.rightLungFiducials.GetNumberOfDefinedControlPoints()" can lag? The number is incremented when the point is placed, not yet when in preview state.
If placing the points is significant effort then we can probably fully automate the process by registering an atlas image (can be simply an average-looking chest image) to the patient image and use the transform to transfer control points that are specified in the atlas image. Or, AIAA segmented could be used, at least to initialize seeds.

What do you mean by " rightLungF = self.logic.rightLungFiducials.GetNumberOfDefinedControlPoints()" can lag? The number is incremented when the point is placed, not yet when in preview state.

You place a new fiducial normally: everything ok.
You place fiducials faster, lets say three in a row on the left lung in coronal view: Eventually, the process will fail because updateGUIFromParameterNode() gets called on each of the three placements, but during the third call    GetNumberOfDefinedControlPoints() still returns the old number (2, not 3), so the switch to "T-1" does not happen, "L-4" is generated instead.
Do you have an idea?

If placing the points is significant effort then we can probably fully automate the process by registering an atlas image (can be simply an average-looking chest image) to the patient image and use the transform to transfer control points that are specified in the atlas image. Or, AIAA segmented could be used, at least to initialize seeds.

Great. I was already thinking about using MONAILabel for that?

Now acceptable.


Show Steps in Title

In debug mode, we see: ("Step " + (_this._current + 1) + " of " + _this._steps.length)
Is it possible to have an option that if 2 or more steps exist to optionally show them before the step title as: 1/3 - Step 1 Title, 2/3 - Step 2 Title, 3/3 - Step 3 Title?
And the tour option would be Steps: True?

[ASK]
i have new template at file template.htm.
i want to change my template with include file template.htm.
How can i do that ?


Modules not working

Hello Shiv,
I try to install this modules, after adding this module the Payment Gateway page is not loading, please check
i'm using WHMCS 6.3.1
Thanks
Anu

Hello Anu,
Can please clear what is issue, page is showing black or anything else? please provide screenshot if possible,
Thanks

Hello All,
If any one wants to discuss on this, contact me. I will help regarding this development.

too old and no one responding so closing now


V1.14.x

testing examples

I think this PR may have been created inadvertently. I'm going to close it, but if I'm wrong and there is a change here we should review, please update the PR description to include the goal of this PR.


add test 4 pares handshake

What this PR does:
Which issue(s) this PR fixes:

Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?:

LGTM


[breaking] remove alias exports DefaultContext and EyreContext

The following aliasing exports are unused and can be removed:
#[cfg(feature = "anyhow")]
#[doc(hidden)]
pub use DefaultHandler as DefaultContext;
#[cfg(feature = "anyhow")]
#[doc(hidden)]
pub use EyreHandler as EyreContext;

The aliases might be imported downstream, making this a breaking change.

Status:#181 is ready for review and merge.


Enabled support for tracing crate as a non default feature

In our crates, we use tracing as the crate for logging. The rust-log-panics crate doesn't work well in its current state since it uses log crate for logging the panics. Enabled the crate to use macros from the tracing crate on enabling 'with-tracing' feature, and kept the default features to use 'with-log' which uses log crate. Also added a compile error if there is an attempt to use both these features together

What is adding an unused dependency on tracing supposed to do?

For our case, we use the tracing crate for our logging. Since this crate uses log crate, the message being logged doesn't show up. Adding the support for logging using tracing crate as a separate feature, helps us then be able to see the panic message by disabling the default features and enabling 'with-tracing' feature, as in that case, the macros are used from the tracing crate

I would recommend hooking tracing up to log, rather than trying to patch every single transitive dependency using log: https://docs.rs/tracing/latest/tracing/#consuming-log-records


Log lines longer than 16384 characters are improperly joined

Bug description
Per https://github.com/moby/moby/pull/22982 and https://github.com/moby/moby/issues/32923, the max length of a line logged in docker is 16k. When the line gets longer, it is streamed to multiple line entries in the log file. This looks like so:
{"log":"<15k+ characters> ... this is a sin","stream":"stdout","time":"2019-12-05T00:26:59.526348635Z"}
{"log":"gle log entry.\n","stream":"stdout","time":"2019-12-05T00:26:59.526348635Z"}}

However, the point where these lines should join when viewing a container's logs in portainer appears to have some sort of special character (�). In my case, this renders as either <15k+ characters> ... this is a sin�gle log entry. or with an @ symbol instead (though this isn't actually the symbol - I have no idea what it actually is).
Expected behavior
The line should display as <15k+ characters> ... this is a single log entry.
Steps to reproduce the issue:

Create a container which will attempt to log a line larger than 16384 UTF-8 characters
View container logs in portainer web view
a. If things render fine, attempt to copy text and notice there will be a weird character at the cutoff point
b. Alternatively, open developer tools in browser and view source

Technical details:

Portainer version: 1.22.2
Docker version (managed by Portainer): 18.09.3
Platform (windows/linux): linux
Command used to start Portainer (docker run -p 9000:9000 portainer/portainer): probably that, but I'm unsure
Browser: Firefox 71.0b10 (64-bit)

Additional context
When viewing the log file for the container via docker logs, the entries appear to be joined together with no errors.

Reproduced on 1.23.2

This will be addressed in #3749


Remove use of app.getComponent and id attributes

Redo the demo's so they use @ViewChild instead of app.getComponent(). Also remove the id attributes from ion-nav.

This will be required for the beta7 update.

Unless I missed anything, this should already be taken care of. I vote we also remove the id directory from ionic-site as well.

Missed in in Tabs. But other than that, we're good.


Add committee selector to motion meta data submitters

Resolve #3429
This selector allows to fill the submitters extension text field with committee names. Select a committee and press save, the committee name is appended to the extension text field.
The received forwarding committees are returned by the presenter, which fills the possible committee names.

Where can I find the extension of recommendation? @Elblinator please give a step-by-step instruction to find that widget.

Updated the committee field to include:

direct fill
middot
keepOpen
disableIds.

This is more in the way the motion-extension-field is built.

Please review again.


Implemented modules versions

Ticket: ENT-7736

@craigcomstock I will replace these magic whitespaces with a regex in a following PR


Control docs: update messaging for focus to be less keyboard-specific

Quick updates to the Control node documentation to include gamepad references and remove explicit references to keyboard where focus works across keyboard, gamepad, and mouse inputs.
3.x version: https://github.com/godotengine/godot/pull/66855

Waiting on the review for the 3.x version before merging this one.

Looks good! Could you squash the commits? See PR workflow for instructions.

@akien-mga looks like it needs re-approval after merging the suggestions.


BoundTo Lifestyle

Is there anyway to use a bound lifestyle with aspnet core i.e. In Castle Windsor you can do:
container.Register(Component.For<IFoo>().ImplementedBy<Foo>().LifeStyle.BoundTo<IBar>());
I don't see any option for this at the moment.

No there is no equivalent.

@davidfowl is there a plan for this or am I SOL?

You are SOL.

@davidfowl Ok lol thanks, can I ask then how does Scoped lifetime work in a non web program? If I have two threads is the scoping between those threads ?

@Dave3of5 scoping is extremely simple. You make a scope, and scoped instanced are tied to the lifetime of the scoped container. As in, you need to manually resolve instances from the scoped container to get the scoped instance. That's it. There's no magic per thread, per anything ambient scope.

@davidfowl Sorry still quite don't understand. So if I had two threads running in parallel both resolving from the same container any instance created via scoped would use the same instance. Whereas if I had two containers (one for each) thread they would get different instances ?

@davidfowl Nevermind I understand it now.
I would create a scope per thread / task. Is there anyway to have different registrations per scope something like: http://docs.autofac.org/en/latest/lifetime/working-with-scopes.html#adding-registrations-to-a-lifetime-scope.
Doesn't need to be done exactly like this but for example if I two static methods that would create different lifetime registrations would I just call whatever method as the first line of the scope?

We don't support registering services in a scope (they aren't child container builders). Scoped containers themselves just represent the lifetime of the scoped services.

Doesn't need to be done exactly like this but for example if I two static methods that would create different lifetime registrations would I just call whatever method as the first line of the scope?

Yes, you just create a scope and use that service provider.


refac(invoke-wpfinstall.ps1): simplify taskbaritem invocation

Type of Change

[ ] New feature
[ ] Bug fix
[ ] Documentation update
[x] Refactoring
[ ] Hotfix
[ ] Security patch
[ ] UI/UX improvement

Description

Refactor: functions/public/Invoke-WPFInstall.ps1

Simplify code and make it shorter

Testing

Not needed
Impact

Make code shorter and easier to read
Issue related to PR

Resolves #

Additional Information

Checklist

[x] My code adheres to the coding and style guidelines of the project.
[x] I have performed a self-review of my own code.
[ ] I have commented my code, particularly in hard-to-understand areas.
[ ] I have made corresponding changes to the documentation.
[x] My changes generate no errors/warnings/merge conflicts.

My apologies. Removing null asignments caused the install/uninstall to not work
This was also a problem in https://github.com/ChrisTitusTech/winutil/pull/2797
I will make sure to better test in the future


Number too long

Hi, im trying to encode three numbers, id, user id and date.
Unfortunately it appears to be falling over on the date, when i pass:<PHONE_NUMBER> i get nothing back, however if i just remove one number from the end of the date number, i get an encoded string.
is there a limit?

Have you bcmath extension?

Closing due to inactivity.


optionally disable tens and teens

Any objections to a PR which optionally disables tens and teens from the number captures? I find that many teens get confused with tens for example forty vs fourteen. I also find that it is faster to just say digits serially, for example four two three -> 423. However, with the tens enabled four two three gets confused forty three. I understand why tens and teens are included, perhaps the community would be okay with making them optional?

I would like to be able to disable this too, since this gets too eagerly (mis)recognized for me. It might even be nice to be able to disable it on the fly (i.e., to be able to toggle it as we might toggle a language).

I'm open to this, but I'm not sure there's really a great mechanism for readily toggling these.

I realized using a tag is the obvious way to toggle more specific captures for this at runtime. Something that could be thrown in settings.talon.

@dwiel Are you still interested in adding this feature, or perhaps conformer is working well enough for you now?


Fix #393 : API endpoint for docker artifact

This PR fixes issue #393

it adds an endpoint to the API to get the link to the Docker image artifact : api/v1/build/{build_id}/docker/
it updates the openAPI json file for the documentation

I ran the webserver and downloaded the file from /docs :)


Fixes issue with resubscribe using an incorrect resourceVersion

Fixes #5997
Occurred changes and/or fixed issues
removes nextResourceVersion which contained an issue wherein an unrelated resourceVersion could be used to resubscribe to a resource collection. Replaces it with a simple fetch to get the new resourceVersion from steve.
Technical notes summary
watches triggered without a revision should make an additional HTTP call to the API to get one now.
Areas or cases that should be tested
Create a downstream cluster with "CATTLE_WATCH_TIMEOUT_SECONDS" set to 180 seconds
Wait ~30 minutes for a "too old" message to appear for a resource in the Websocket messages
You should notice an API call is made and the new subscription is made with the correct resourceVersion from that API call.

Closing in favour of https://github.com/rancher/dashboard/pull/7719 / https://github.com/rancher/dashboard/pull/7671


Replace csso with cssnano

Next release of cssnano will support synchronous usage, see https://github.com/cssnano/cssnano/issues/68#issuecomment-510563780.

Why reduce functionality?


Accessibility review

Chris and @angelmplus to put together scope or work/approach vendor.

This has been organised with the HK Blind Union. The first report will be complete by December 22. Taking into account holidays we'll be able to action results in the new year.
CC: @rdunk

Closing issue.


labels(engine): implement pkg/label

What problem does this PR solve?
Issue Number: ref #6270
What is changed and how it works?

Implemented a general purpose mechanism to support labels and selectors.

Check List
Tests

Unit test

Questions
Will it cause performance regression or break compatibility?
No.
Do you need to update user documentation, design documentation or monitoring documentation?
No.
Release note
None.

Codecov Report

Merging #6271 (bccb8d4) into master (bcb773a) will decrease coverage by 0.0036%.
The diff coverage is 68.9655%.

Flag
Coverage Δ

dm
51.9158% <ø> (+0.0430%)
:arrow_up:

engine
63.0499% <ø> (-0.0469%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.
@@               Coverage Diff                @@
##             master      #6271        +/-   ##
================================================
- Coverage   59.0443%   59.0407%   -0.0037%
================================================
  Files           736        738         +2
  Lines         85346      85419        +73
================================================
+ Hits          50392      50432        +40
- Misses        30483      30522        +39
+ Partials       4471       4465         -6

/merge

/run-all-tests

/run-kafka-integration-test

/run-kafka-integration-test


[WFCORE-767] Introduce parameters object for SimpleResourceDefinition

As Brian points out on the PR comment referenced in the description of https://issues.jboss.org/browse/WFCORE-767.

Linux Build 1993 is now running using a merge of bada5f7966eeb70cee22034440a958a9e16992d5

Windows Build 1541 is now running using a merge of bada5f7966eeb70cee22034440a958a9e16992d5

Core - Full Integration Build 1133 is now running using a merge of bada5f7966eeb70cee22034440a958a9e16992d5

Windows Build 1541 outcome was SUCCESS using a merge of bada5f7966eeb70cee22034440a958a9e16992d5
Summary: Tests passed: 3209, ignored: 71 Build time: 0:22:31

Linux Build 1993 outcome was SUCCESS using a merge of bada5f7966eeb70cee22034440a958a9e16992d5
Summary: Tests passed: 3209, ignored: 71 Build time: 0:26:03

Core - Full Integration Build 1133 outcome was SUCCESS using a merge of 376d21561a80182e81867e0e14ab25853a7e04e8
Summary: Tests passed: 2878, ignored: 377 Build time: 0:49:53

Linux Build 1994 is now running using a merge of 376d21561a80182e81867e0e14ab25853a7e04e8

Windows Build 1542 is now running using a merge of 376d21561a80182e81867e0e14ab25853a7e04e8

Core - Full Integration Build 1134 is now running using a merge of 376d21561a80182e81867e0e14ab25853a7e04e8

Windows Build 1542 outcome was SUCCESS using a merge of 376d21561a80182e81867e0e14ab25853a7e04e8
Summary: Tests passed: 3209, ignored: 71 Build time: 0:22:30

Linux Build 1994 outcome was SUCCESS using a merge of 376d21561a80182e81867e0e14ab25853a7e04e8
Summary: Tests passed: 3209, ignored: 71 Build time: 0:25:44

Core - Full Integration Build 1134 outcome was FAILURE using a merge of 376d21561a80182e81867e0e14ab25853a7e04e8
Summary: Tests failed: 1 (1 new), passed: 2876, ignored: 377, muted: 1 Build time: 0:48:59
Build problems:
Failed tests detected
Failed tests
org.jboss.as.test.clustering.cluster.sso.ClusteredSingleSignOnTestCase(SYNC-tcp).testNoAuthSingleSignOn: <no details avaliable>

Maybe this build should be on ResourceDefinition directly so it could be easier to use it in all implementations.

Also while you are here, can you also add builder variant to constructor of PersistentResourceDefinition?

Linux Build 1995 is now running using a merge of 49ef192bbcc4ce9462d8c6dd14903a0b84e34686

Core - Full Integration Build 1135 is now running using a merge of 49ef192bbcc4ce9462d8c6dd14903a0b84e34686

Windows Build 1543 is now running using a merge of 49ef192bbcc4ce9462d8c6dd14903a0b84e34686

Windows Build 1543 outcome was SUCCESS using a merge of 49ef192bbcc4ce9462d8c6dd14903a0b84e34686
Summary: Tests passed: 3209, ignored: 71 Build time: 0:22:22

Linux Build 1995 outcome was SUCCESS using a merge of 49ef192bbcc4ce9462d8c6dd14903a0b84e34686
Summary: Tests passed: 3209, ignored: 71 Build time: 0:25:33

Core - Full Integration Build 1135 outcome was SUCCESS using a merge of 49ef192bbcc4ce9462d8c6dd14903a0b84e34686
Summary: Tests passed: 2877, ignored: 377, muted: 1 Build time: 0:53:25

Windows Build 1545 is now running using a merge of fa9cc55dcea22dbac3a82039cbcc0bf31ebab1b5

Linux Build 1997 is now running using a merge of fa9cc55dcea22dbac3a82039cbcc0bf31ebab1b5

Core - Full Integration Build 1137 is now running using a merge of fa9cc55dcea22dbac3a82039cbcc0bf31ebab1b5

Windows Build 1545 outcome was SUCCESS using a merge of fa9cc55dcea22dbac3a82039cbcc0bf31ebab1b5
Summary: Tests passed: 3209, ignored: 71 Build time: 0:22:56

Linux Build 1997 outcome was FAILURE using a merge of fa9cc55dcea22dbac3a82039cbcc0bf31ebab1b5
Summary: Execution timeout (new); tests passed: 2908, ignored: 56; org.wildfly.core:wildfly-core-testsuite-domain Build time: 0:45:09
Build problems:
Execution timeout
Process exited with code 137

Core - Full Integration Build 1137 outcome was SUCCESS using a merge of fa9cc55dcea22dbac3a82039cbcc0bf31ebab1b5
Summary: Tests passed: 2878, ignored: 377 Build time: 0:47:36

retest this please

Windows Build 1546 is now running using a merge of fa9cc55dcea22dbac3a82039cbcc0bf31ebab1b5

Linux Build 1998 is now running using a merge of fa9cc55dcea22dbac3a82039cbcc0bf31ebab1b5

Core - Full Integration Build 1139 is now running using a merge of fa9cc55dcea22dbac3a82039cbcc0bf31ebab1b5

Windows Build 1546 outcome was SUCCESS using a merge of fa9cc55dcea22dbac3a82039cbcc0bf31ebab1b5
Summary: Tests passed: 3209, ignored: 71 Build time: 0:22:32

Linux Build 1998 outcome was FAILURE using a merge of fa9cc55dcea22dbac3a82039cbcc0bf31ebab1b5
Summary: Execution timeout; tests passed: 2908, ignored: 56; org.wildfly.core:wildfly-core-testsuite-domain Build time: 0:45:02
Build problems:
Execution timeout
Process exited with code 137

Core - Full Integration Build 1139 outcome was SUCCESS using a merge of fa9cc55dcea22dbac3a82039cbcc0bf31ebab1b5
Summary: Tests passed: 2877, ignored: 377, muted: 1 Build time: 0:48:54

Linux Build 2002 is now running using a merge of fa9cc55dcea22dbac3a82039cbcc0bf31ebab1b5

Linux Build 2002 outcome was SUCCESS using a merge of fa9cc55dcea22dbac3a82039cbcc0bf31ebab1b5
Summary: Tests passed: 3209, ignored: 71 Build time: 0:25:16

@ctomc This has been merged as-is, if you want to implement your ideas, please open a PR


Raise severities for cloudwatch alarms

Cloudwatch has only two severities: OK and ALARM plu one informative INSUFFICIENT_DATA. Since ALARM is the highest severity I would raise it to critical, INSUFFICIENT_DATA to major and OK leave as normal.
The rationale by this is that  since ALARM is used for alarms, it should have the highest priority.
This can be done either statically, just as now or by supplying severty map in config. I can as always provide a PR for both.

This is a good use case for a plugin because not everyone would agree with your choice of severity levels.
It would be great if you could write a plugin to make the severities configurable for AWS cloudwatch. You could call it alerta-cloudwatch plugin and we could add it to the alerta-contrib repo.
It would look something like ...
class AwsCloudwatch(PluginBase):

    def pre_receive(self, alert):
        if alert.event_type != 'cloudwatchAlarm':
            return alert
        if alert.raw_data['NewStateValue'] == 'ALARM':
            severity = 'critical'
        else ...

What do you think?

This is a good idea. I will take this path.

I will close this one. We have creaed a plugin and will PR  to alerta-contrib

Thanks.


Adjust font in code editor

The code editor on GitHub seems to introduce its own styles and overwrites font for <pre> tags. This makes our font-family styling disappear. From short testing in the dev tools it seems that we only need to include the following style in our CSS to make our fonts work in the editor as well:
pre.CodeMirror-line {
  font: inherit;
}

Note that I have only tested this in the dev tools so far and it might not work if our stylesheet is loaded before the editor stylesheet.

@Turbo87 Could you create a pull request with this proposal so we could review and merge? Thanks!


Fix tests in main!

Add strings required by util.js tests to spec_helpers, also do not load images during test time to stop all the log spamming.

In fbb173dd9 I ended up just moving the asset loading stuff into the PixiTextures class, this way we don't need an extra boolean flag to say whether context should load textures or not.  It looks like the tests are ok now!
I'll also add your fix to spec_helpers  too, I just forgot to include it in that commit.


Improved DOA metrics update in protobuf

To follow the update in ZenCode, we define new outputs:

magnitude: it was before the amplitude measured in the RD which was not very useful since it is not a per-object measurement and is redundant with the rd_mean_snr. It is now the magnitude of the coefficient of an object estimated by the DOA MLE estimator
doa_snr: SNR measured after the DOA estimation. We estimate the variance of the noise as sigma^2 = ||z - coeff * a(theta, phi)||^2 / (n - m) where n is the number of measurements and m the number of parameters to estimate. We then have doa_snr = |coeff| / sigma
azimuth_variance: is the variance on the estimate. It is defined as  cov(theta) = sigma^2 * (Hessian(cost(theta))) ^ -1
rd_mean_snr replaces confidence

To be merged when the PR is approved in ZenCode

The PR in ZenCode is merged. I realized that since amplitude was renamed to magnitude, it can create a forward compatibility issue. @jimmy-zendar what do you think should be the way to move forward with that ?

The path forward is to wait that feature-algorithms is merged into master and the debian packages are updated.


ر

Before opening:

Search for duplicate or closed issues
Validate any HTML to avoid common problems
Read the contributing guidelines

Bug reports must include:

Operating system and version (Windows, macOS, Android, iOS)
Browser and version (Chrome, Firefox, Safari, Microsoft Edge, Opera, Android Browser)
A reduced test case or suggested fix using CodePen or JS Bin

stop trying to learn how to github here on a public repo...


Fix misspelled words in comments and error messages

What does this PR do?
This pull request fixes several misspelled words found in the repository.  I used https://github.com/client9/misspell for the detection.
Motivation
I am a heavy user of dd agent 😄
Additional Notes
None.

Thanks @seratch for these fix! 🙇 (you'll need to sign the CLA for the PR to be merged 🖋)
@DataDog/agent-core should we make the misspell check a bit wider within the invoke task?

@mfpierre I've signed the CLA.


Make OCLKind and PTXKind consistent for LocalArrayNodes

Describe the feature
There is an inconsistency between the OpenCL and the PTX backends.
The inconsistency is observed in the generate method of the LocalArrayNode. Prior to the TornadoVMContext features, this node was used only from the snippets. So, we could use the constructor that uses the ResolvedJavaType field. Now, that we append this node from the CompilerGraphPlugins, we use a second constructor that uses the JavaKind instead of the ResolvedJavaType.
This change in the OpenCL backend was ok, as the generate method used the following line to obtain the LIRKind.
// line in the generate method
LIRKind lirKind = LIRKind.value(gen.getLIRGeneratorTool().target().arch.getWordKind());

However, in the PTX backend the LIRKind was obtained by the kind that was initialized in the constructor from the ResolvedJavaType.
// line in the constructor
this.kind = PTXKind.fromResolvedJavaType(elementType)

// line in the generate method
LIRKind lirKind = LIRKind.value(kind);

In order to make it work for the TornadoVMContext, I made the PTX generate method to use the gen.getLIRGeneratorTool().target().arch.getWordKind()` similar to the OpenCL method. This seems to work for all unit-tests.
Feature description:
After discussion with @jjfumero and @gigiblender, we decided to merge the new API, and open this issue for this feature:
Make the LIRKind to be obtained by the kind (OCLKind or PTXKind).
To do this, we can create a new method in the OCLKind, PTXKind classes that resolves the backend kind from the JavaKind. For example:
public static OCLKind fromResolvedJavaKind(JavaKind javaKind);

public static PTXKind fromResolvedJavaKind(JavaKind javaKind);

I think the way to go is by getting word kind from the constructor. For that, we can add a new method in OCLKind from type JavaKind to OCLKind, if possible.


[top_darjeeling] Fast subsystem interrupts?

desc
Is there a need to support fast external interrupts?
From my point of view, most interrupts can probably be hooked into the "gpio" bus for darjeeling. We can then enable the gpio interrupts to trigger and let the software decode the mapping on where it should go.
However, if there is a need to more directly wire this into the plic, we made need to make some infra changes to support it.

This has been implemented using a soc_proxy module that is similar in construction like sensor_ctrl.
The advantage is that the wiring / mapping to the PLIC is direct.
CC @andreaskurth


 It would make sense to make this a retriable error and invoke exponential retry to push back on the load.
The error comes down as
INTERNAL: Abrupt GOAWAY closed sent stream. HTTP/2 error code: PROTOCOL_ERROR, debug data: client_throttled

Retrying internal is dangerous and can lead to things like replayed queries of death. PROTOCOL_ERROR seems the wrong error code here; it sounds like there was no HTTP/2 protocol violation. It is unclear to me why ENHANCE_YOUR_CALM wasn't used instead. ENHANCE_YOUR_CALM is mapped to gRPC status RESOURCE_EXHAUSTED.

@ejona86 take a look at b/261946753#comment6 and b/262072291. Let me know if you still think mitigating it on the clientside by retrying client_throttled errors is still wrong. My understanding is that this is similar to go/rst_stream

go/rst_stream didn't know the cause. It was quite troublesome, and might have been caused by the client, a proxy, or the backend. Although I also didn't notice anybody from gRPC team (nor GFE?) on that doc.
In this case, we have the clear error reason client_throttled and the server is obviously using the wrong HTTP/2 error code. This seems like a one-line change to fix the proxy. Looking at b/262072291, this has already been fixed in cl/496413349 by changing the error code to NO_ERROR. That will map to UNAVAILABLE in gRPC.


fix: small typo in EAGAIN error message

Change-Type: patch
See: https://github.com/resin-io-modules/drivelist/pull/195#pullrequestreview-50825872
Signed-off-by: Juan Cruz Viotti<EMAIL_ADDRESS>

Ahhhhh VersionBot again! Why do I keep forgetting about it? -.-

Tut tut ;)


Fixes issue #1404

Fixes #1404
Description of the changes:

When the unit converter's category is changed, the corresponding property setter for the CurrentCategory variable mistakenly calls OnPropertyChanged("CurrentCategory") instead of RaisePropertyChanged("CurrentCategory"). This results in a failure to notify XAML that the CurrentCategory variable has changed, resulting in the corresponding UI to not be updated accordingly.

How changes were validated:

Manual testing.

/azp run

/azp run


Configure the EBS CSI add-on to tag the created volumes

Opened as a draft because it's not yet fully tested. I've created the cluster and I can see the add-on configuration is there, but I haven't been able to complete it because I'm hitting the issue:
 creating IAM OIDC Provider: LimitExceeded: Cannot exceed quota for OpenIdConnectProvidersPerAccount: 100

Once some providers are cleaned up, I'll complete the test and verify that the EBS volumes are properly tagged, then promote to ready for review.

Confirmed that it works with the volume created for the redis rate-limiting:


.Net: New Feature: configure the agents with functions by name

name: configure the agents with functions by name
about: Today to create a ChatCompletionAgent I can give it a
FunctionChoiceBehavior = FunctionChoiceBehavior.Required(someListOfKernelFunctions)
But that means I must program the finding by hand of the functions, and the build of that list parameter. But the agent can already find them by name - like I see in the prompt template (MyPlugin-MyFunction). So how about configuring the list of functions with the string list of names? Or only functions from a certain plugin? Some filtering would make my code much cleaner (I call this less boilerplate).
Of course I can use FunctionChoiceBehavior = FunctionChoiceBehavior.Required() then everything and the kitchen sink will be available, but right now my agents for some reason got the bad habit to call EVERY functions they can, so I'd rather filter that in some way.

Hi @sorin-costea, there are a few options to do it and you can use any of them:
// Option 1 - use only one function
KernelFunction getWeatherFunction = kernel.Plugins.GetFunction("HelperFunctions", "GetWeatherForCity");
OpenAIPromptExecutionSettings settings = new() { FunctionChoiceBehavior = FunctionChoiceBehavior.Required(functions: [getWeatherFunction]) };

// Option 2 - use all plugin functions
IEnumerable<KernelFunction> allPluginFunctions = kernel.Plugins["HelperFunctions"];
OpenAIPromptExecutionSettings settings = new() { FunctionChoiceBehavior = FunctionChoiceBehavior.Required(functions: allPluginFunctions) };

// Option 3 - use a few plugin functions
IEnumerable<KernelFunction> functions = kernel.Plugins["HelperFunctions"].Where(f => f.Name is "GetWeatherForCity" or "GetCurrentUtcDateTime");
OpenAIPromptExecutionSettings settings = new() { FunctionChoiceBehavior = FunctionChoiceBehavior.Required(functions: functions) };

// Option 4 - specify functions by their FQNs
RequiredFunctionChoiceBehavior behavior = (RequiredFunctionChoiceBehavior)FunctionChoiceBehavior.Required();
behavior.Functions = ["HelperFunctions-GetWeatherForCity", "HelperFunctions-GetCurrentUtcDateTime"];
OpenAIPromptExecutionSettings settings = new() { FunctionChoiceBehavior = behavior };

The options 1, 2, and 3 would allow your code to fail fast and detect misconfiguration(either a plugin or a function is not registered) early at the plugin/function lookup line. Option 4 will inform you about misconfiguration at a later stage when you prompt the AI model.
Options 1, 2, and 3 were designed to be used from code, while option 4 was designed to narrow downs the list of advertised functions from JSON/YAML prompt templates.
Our advice would be to use options 1, 2, or 3 to detect misconfiguration as early as possible.

Thank you so much for the examples, now I can really start!

Oops maybe I shouldn't have closed it? In any case, for ME it's solved thank you :)


Sets values in specific config file to default

This sets the config values in the listproviders file acl.default.create.properties to their default values. This should already have happened in the PR associated with the files creation, but was simply overlooked. With these values set to their defaults, the ACL tab in the event and series details view in the Admin UI should function again.

With these values set to their defaults, the ACL tab in the event and series details view in the Admin UI should function again.

Can you briefly describe what the issue is and when it was introduced?

With these values set to their defaults, the ACL tab in the event and series details view in the Admin UI should function again.

Can you briefly describe what the issue is and when it was introduced?

Right. The issue was introduced with PR #4487. It prevented role assignment to users in role tab in the event and series details view of the admin ui, as described in this comment: https://github.com/opencast/opencast/pull/4487#issuecomment-1419632301

So both configs work fine for me in the sense that the configs do what is promised. Don't see anything "broken" just not what is the default for Opencast.


JBPM-5990 - Add MomentJS library

Requirement for new date range picker widget
Matched available language locales with the ones used by kie-wb

@ederign +1, will take a look on that for future work.


Docker container for Journal device and data as osd-directory

I would like to run a OSD container with Journal set to block device and OSD data set to a file system for Jewel release (Centos 7). What this means is that I would like to set OSD_TYPE=directory and OSD_JOURNAL=/dev/xxx. However, as per ceph-docker documentation this mix of settings is not supported. Is there a reason for not supporting this? or did I misread the documentation?

@leseb I was wondering if you had any thoughts on this issue.

That's easy, just set -e OSD_DEVICE=/dev/sda and -e OSD_JOURNAL=/dev/sdb. The container will do the rest and configure the fs for ceph data and the block device for the journal.

@leseb To clarify, the scenario I am describing is where I want to set OSD_DIRECTORY=directory as I have a file system directory that I want to bind mount to  /var/lib/ceph/osd/. At the same time, I want to expose a block level device for the journal. It looks like the docker image does not support this combination.

Well in this case, you will have to manually symlink the journal to the block device. This is not supported by the directory scenario because this allows us to run with unpriviledged container (since you have a file for the journal and the ceph data store on a fs, no block device access is required).

Ah OK, So all I need is a symlink ( that is named journal) to the block device under the osd_directory and the container would make appropriate use of it as a journal? Thanks.

Correct


Support for overwrite by deleting the existing file when it fails with 409 error

Which version of the AzCopy was used? 10.24
Note: The version is visible when running AzCopy without any argument
Which platform are you using? (ex: Windows, Mac, Linux)
Windows
What command did you run?
2024/05/23 08:47:23 ERR: [P#0-T#18] COPYFAILED: https://admsazcopytestgen2.blob.core.windows.net/azcopy-unit-tests/source-new2/Data1/PartyBcTranslation/part-00000-b60a0e1b-3640-43da-aa6d-3c4ba10254d7-c000.snappy.parquet?REDACTED-=2018-03-28 : 409 : 409 Blob operation is not supported.. When Staging block from URL. X-Ms-Request-Id: 94f0d2a6-c01e-00c7-54ed-ac65f5000000
Note: Please remove the SAS to avoid exposing your credentials. If you cannot remember the exact command, please retrieve it from the beginning of the log file.
What problem was encountered?
2024/05/23 08:47:23 ERR: [P#0-T#18] COPYFAILED: https://admsazcopytestgen2.blob.core.windows.net/azcopy-unit-tests/source-new2/Data1/PartyBcTranslation/part-00000-b60a0e1b-3640-43da-aa6d-3c4ba10254d7-c000.snappy.parquet?-REDACTED-&sv=2018-03-28 : 409 : 409 Blob operation is not supported.. When Staging block from URL. X-Ms-Request-Id: 94f0d2a6-c01e-00c7-54ed-ac65f5000000
How can we reproduce the problem in the simplest way?
Have you found a mitigation/solution?

@rnandurimsft, can you provide logs?  We may already have support for this feature via a hidden flag.

@seanmcc-msft [
656a936c-9b68-c948-7c69-9c196d7dc894.log
](url)
Please find attached the logs.
Sure, please let me know the flag, I could give a try and let you know


fix: publicRuntimeConfig pima v.3

:tada: This PR is included in version 1.1.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Getting JSON data to influxDB

Hi Chris, thanks,
This is very good work.
Just wondering how you managed to get JSON data to influxDB because the current version of InfluxDB doesn’t support the JSON . The predominant reason it was deprecated was that decoding JSON was the largest performance bottleneck in the system.
See https://github.com/influxdata/influxdb/pull/2696#issuecomment-106968181

Please read my blog post here about it.  I use Logstash to inject JSON data into Influx.  Might not be the most performant, but it works for my use case perfectly.
https://fauie.com/2016/06/27/suricata-stats-to-influx-dbgrafana/


Background acrylic and In-app acrylic behaves the same in WinUI 3.

Describe the bug
In WinUI 3, Background acrylic and In-app acrylic applies the same brush, i.e. the latter one. This can also be seen in the WinUI 3 Controls Gallery. Here's the image from the app -

Background acrylic

In-app acrylic
I think the cause of this bug is that in WinUI 3, <AcrylicBrush> has no property called BackgroundSource. It takes values like Backdrop or HostBackdrop to denote In-app or Background respectively.
Mica also doesn't work in WinUI 3.
Steps to reproduce the bug
You can see this bug every time you try to set any brush from Background acrylic as the brush (AcrylicBackgroundFillColorDefaultBrush, for instance). Here's an example to reproduce this bug -

Start a Grid, and add a Rectangle inside it. Set the Fill property to a solid color and set the size to something like (200,200).

<Grid>
        <Rectangle Fill="Blue" Width="200" Height="200"></Rectangle>
</Grid>

Inside the Grid and below the Rectangle, add another Grid. Set its Background property to {ThemeResource AcrylicInAppFillColorDefaultBrush}.

<Grid>
        <Rectangle Fill="Blue" Width="200" Height="200"></Rectangle>
        <Grid Background="{ThemeResource AcrylicInAppFillColorDefaultBrush}"></Grid>
</Grid>

As you can see, in-app acrylic works just fine!

Change the value of Background to {ThemeResource AcrylicBackgroundFillColorDefaultBrush} and check if anything changes.

    <Grid>
        <Rectangle Fill="Blue" Width="200" Height="200"></Rectangle>
        <Grid Background="{ThemeResource AcrylicBackgroundFillColorDefaultBrush}"></Grid>
    </Grid>

You can see that nothing changes even after setting the Background to a Background acrylic brush.
Expected behavior
Expected behavior can be understood from these images from XAML Controls Gallery -

Background acrylic selects the application background as the source.

In-app acrylic selects whatever is behind the control as the source.
Screenshots
No response
NuGet package version
WinUI 3 - Windows App SDK 1.0 (If you're seeing your issue in older previews of WinUI 3, please try this release)
Windows app type

[X] Win32
[x] UWP

Device form factor
Desktop
Windows version
Insider Build (xxxxx), May 2021 Update (19043), October 2020 Update (19042), May 2020 Update (19041), November 2019 Update (18363), May 2019 Update (18362), October 2018 Update (17763)
Additional context
Workaround for this bug
I think you already know what I am about to mention, but you can place the current background image of the user's PC behind a Grid, and apply the Background acrylic as the brush (if this gets patched, then the brush will work as expected, without making changes). But this is not the absolute solution, it will not work as expected (image resizes with window and many problems).

Background acrylic isn't currently supported. You can vote for it and other things here:
https://portal.productboard.com/winappsdk/1-windows-app-sdk/c/28-background-acrylic

Thank you! Well, I already knew it, just wanted to make things clear.


fix: get_lb_autoscaling_data_inside_module

:tada: This PR is included in version 2.3.1 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


full build issue

Thank you for the wonderful Bible reference parser.
I'm currently working on building something comprehensive. When I use the Perl script add_cross_lang.pl full, it works as expected and updates data.txt under src/full folder.
Next, I ran the Perl script 01.add_lang.pl full and encountered the following error messages:
Splitting Exod by length...
Deep recursion on subroutine "main::make_book_regexp" at ./01.add_lang.pl line 335.
Exod 44
Deep recursion on subroutine "main::validate_node_regexp" at ./01.add_lang.pl line 242.

Could you please help me understand what might be causing this issue?
I appreciate your assistance!

I have submitted a pull request for the Persian language on GitHub. You can find it here:
https://github.com/openbibleinfo/Bible-Passage-Reference-Parser/pull/51

I also tested the original code. When I ran 01.add_lang.pl full after add_cross_lang.pl full, it went into an infinite recursion loop. Here's the message:
Splitting Exod by length...
Deep recursion on subroutine "main::make_book_regexp" at ./01.add_lang.pl line 334.
Exod 44
Deep recursion on subroutine "main::validate_node_regexp" at ./01.add_lang.pl line 242.

Thank you, @ralaska, for your contribution to the Farsi/Persian language fa. Were you able to fix this issue? Currently, we rely on the Bible-Passage-Reference-Parser on website (https://bible.peplamb.com), but Persian-speaking users are experiencing difficulties because they are required to input text in English. Additionally, not all Urdu books (ur) have similar pronunciations to Persian (fa). If you can create the 01.add_lang.pl full file and share the minified javascript version, it would be a great help to us.

Thank you for reaching out. I've been diligently working to resolve the issue with the 01.add_lang.pl full script (both in its original form from @openbibleinfo on Mac Apple Silicon Chip and also with fa work I have been working on). As I mentioned, I encountered the infinite recursion problem which seems to be affecting the parsing of certain references. Unfortunately, I haven't found a definitive solution to this problem yet.
I understand the importance of having a functional Persian/Farsi language reference parser, especially considering the differences between Urdu and Persian pronunciations which led me to start working on this project to support some on our applications that relay on this amazing reference parser. I would greatly appreciate any insights or assistance from the community and, if possible, from @openbibleinfo. If we can address this issue collectively, it would benefit a larger user base.
In the meantime, I will continue to investigate this and will keep you posted on any progress I make. If anyone else in the community has encountered a similar issue or has insights into a potential fix, I'm all ears.


Add GitHub Deployment integration

Currently, this creates the Deployment as well as the DeploymentStatus in one go. This is because I couldn't figure out how to preserve the deployment ID across different events. If anyone has any ideas of how to do that, please let me know!
Fixes #98

Do you want me to try to add tests for the service logic? The previous integration didn't have tests for that, and I'm not sure I'm familiar enough with Go to mock the GitHub services. Open to learning if it's needed though!

I've tested this in a custom build of Argo and it works great with deployments!

@nan-yu, what is the best way to get a review on this? I just saw you were tagged on another PR a few weeks ago and figured maybe this PR didn't notify anyone, so thought I'd give it a try. Apologies if you are not the right person to ping. Thank you!

@jaredtbates I am not an owner of this repo. I was tagged because my colleague and I would like to contribute as well.
It seems @pasha-codefresh and @alexmt recently reviewed and approved PRs. I would suggest tagging them for review.

Thank you, @pasha-codefresh and @alexmt, if you get any time, could you take a look at your convenience? No rush, but would appreciate your input. We're running a custom build of Argo internally in the meantime.

@jaredtbates PR looks good to me, could you please resolve conflicts?

@pasha-codefresh thanks for looking at this! I just merged in the latest changes and resolved conflicts. Let me know if anything else needs done!

Thank you!


Preserve blank lines

I'm using escodegen to reformat user code in the Khan Academy live-editor. If a student adds spaces between lines to make things more reabable we'd like to maintain that format while fixing the indentation and other issues that might exist.
This submission fixes some issues from the previous one.

@Constellation Let me know if there are any other changes you want me to make.

LGTM!

Thank you for your great contribution!

And sorry for further late reply.

@Constellation No worries.  Thanks for the merge!

Released it as 1.5.0 :D


Export nerfstudio dataset format export to e.g. COLMAP or NSVF?

Is there an option to export the nerfstudio dataset format to for example a format such as COLMAP or NSVF?

We do not currently have a script for that conversion.


python311Packages.peewee: 3.16.3 -> 3.17.0

Diff: https://github.com/coleifer/peewee/compare/refs/tags/3.16.3...3.17.0
Description of changes

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.


Updated wheel release mechanism

Biggest change really is now,

There is only one C++ library - much simpler for build time

Fixes somethings from https://github.com/X-DataInitiative/tick/issues/504

no segfaults seen in a while
csr deprecations assessed

OSX still has some weird issues with random, and I'm guessing this is the reason why some real tests are failing now
for instance
Traceback (most recent call last):
  File "/Users/runner/work/tick/tick/tick/linear_model/tests/logistic_regression_test.py", line 93, in test_LogisticRegression_fit
    self.assertGreater(
AssertionError: 0.6981863527347516 not greater than 0.699 : solver sgd with penalty binarsity and intercept False reached too low AUC

I changed it from .7 to .69, but I'm not sure it really should be changed, maybe it's ok?
@Mbompr thoughts?
With this pull request, we should be able to publish new wheels to both test-pypi repo on master merge
And
push to pypi regular on release/tag

Sorry, just discovering this thread :o, wow the amount of work is huge !
Honestly, these tests involving randomness are very bad designed, but I didn't know that back then :).
About changing the AUC threshold from .7 to .69, this is not an issue at all. The only thing we are checking is that the model is learning something significantly better than random (which would lead to 0.5), so 0.65 or 0.6 would also be fine.
About the darwin test filtering, this is due to
        # This is temporary
        # At the moment, seeds are not cross platform as distributions in
        # C++ depends on standard library shipped with compiler
        import os
        if os.name == 'posix':
            import platform
            if platform.system() == 'Darwin':
                # We check that we get the same as what was recorded
                np.testing.assert_almost_equal(seeded_sample_1, seeded_sample)

(note the "temporary"...). That is also bad designed. The test purpose was to check if with the same seed we were obtaining the same random numbers. But nothing really guarantees this and I guess an update in darwin random number generation can break this easily.
I would thus simply remove this part of the test as well as all seeded_sample arguments. I would need help tell me, otherwise I'm quite happy to not setup tick, cmake and swig on my machine :)


Parse bitfields; use system headers to test

It turns out bitfields were the only things missing!
Note that this only parses bitfields, they are not implemented at all (i.e. the code will be compiled exactly the same whether or not it uses bitfields).

Closes #131


Add an option to include comments in FTA score calculation

Add an option to include comments in FTA score calculation.
Exclude comments by default.

e2e test case in test.yml needs the line count updating

Fta score in the e2e test also needs to be updated, since the number of lines was corrected


Feature/intercept

This PR restructures the hydrology model in the following ways (sorry I got carried away, I am aware that this is a lot of change for  one PR):

moving functions out of update() for better unit testing
use numpy arrays where possible to avoid dealing with coordinates
introduce a function for canopy interception
divide input precipitation and evapotranspiration by 30 to run model for 30 (identical) days and calculate monthly mean/sum

Still to do, maybe better in a separate PR:

evapotranspiration needs to change to transpiration, but this requires changing the dummy data set which I don't want to do too often, will do when we complete milestone 1.5
move from 30 x the same day to loading daily data or introducing stochasticity
all the other little TODOs which have to do with below ground hydrology

Type of change

[x] New feature (non-breaking change which adds functionality)
[x] Optimization (back-end change that speeds up the code)
[ ] Bug fix (non-breaking change which fixes an issue)

Key checklist

[x] Make sure you've run the pre-commit checks: $ pre-commit run -a
[x] All tests pass: $ poetry run pytest

Further checks

[x] Code is commented, particularly in hard-to-understand areas
[x] Tests added that prove fix is effective or that feature works

Codecov Report

Merging #315 (505feef) into develop (bd86d67) will decrease coverage by 0.96%.
Report is 155 commits behind head on develop.
The diff coverage is 92.73%.

@@             Coverage Diff             @@
##           develop     #315      +/-   ##
===========================================
- Coverage    97.55%   96.60%   -0.96%
===========================================
  Files           47       52       +5
  Lines         2171     2530     +359
===========================================
+ Hits          2118     2444     +326
- Misses          53       86      +33

Files Changed
Coverage Δ

virtual_rainforest/core/data.py
85.84% <57.14%> (-4.98%)
:arrow_down:

...rtual_rainforest/models/plants/functional_types.py
66.66% <66.66%> (ø)

virtual_rainforest/models/plants/plants_model.py
92.68% <92.68%> (ø)

virtual_rainforest/core/utils.py
94.00% <93.75%> (-6.00%)
:arrow_down:

virtual_rainforest/models/plants/canopy.py
94.23% <94.23%> (ø)

virtual_rainforest/core/config.py
98.04% <95.45%> (-0.62%)
:arrow_down:

virtual_rainforest/core/base_model.py
100.00% <100.00%> (ø)

virtual_rainforest/core/constants.py
100.00% <100.00%> (ø)

virtual_rainforest/core/grid.py
95.94% <100.00%> (ø)

virtual_rainforest/entry_points.py
63.79% <100.00%> (ø)

... and 13 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Engine cleanup

Changelog:

rails g fortitude:install now installs defaults and theme_defaults for customization. I don't think copying all files into your Rails app is the way to go.
compass install fortitude does the same thing
grunt test builds a test compass app to make sure compass integration works
no changes to Bower
modified Fortitude.rb to be more flexible
README has installation instructions

@lifeiscontent review?

@agius should we merge this? It looks pretty clean. I'm just not familiar with the grunt side of things.
Any reason why you chose grunt over gulp?

@agius the only thing I would add is maybe bump the minor version of fortitude. search the entire project. I believe it needs to be updated in bower, ruby library, and Gemfile.lock.

omg, this is the install UX I've been looking for!
Hmmm, to copy the theme or not to copy the theme.

I don't think copying all files into your Rails app is the way to go.

Can you explain more about why? The original theory behind copying the theme into a project was to give users an already-themed-sandbox to jump right into without having to worry about versioning or a dependency on upstream theme code.


docs: changed order of scripts in "Run in your own app" to match the …

…first step
Changed the order of the scripts to be inline with the previous step, so that you don't overlook the pnpm and npm and copy the wrong command by accident
Overview

What is it?

[ ] Feature / enhancement
[ ] Bug
[X] Docs / tests / types / typos

Description
Changed the order of the scripts to be inline with the previous step, so that you don't overlook the pnpm and npm and copy the wrong command by accident
Use cases and why

Checklist:

[X] My code follows the developer guidelines of this project
[X] I have performed a self-review of my own code
[X] I have made corresponding changes to the documentation
[ ] Added new tests to cover the fix / functionality

ghat makes sens. thx @jeroenbach 🙏


Update docs to mention trimgalore core usage nuances

When running trimgalore on PE data, alloting 8 or fewer cpus to the task will result in only 1 being used.  Using 9 or more cpus will run trimgalore in a parallelized manner as expected.
There have been discussions related to why this is necessary here and the trimgalore docs also mention it.
Describe the solution you'd like
Mentioning this in the pipeline docs would be helpful, particularly for users that use custom configs.

Added a brief description to the pipeline output docs here :) https://github.com/nf-core/rnaseq/pull/579/commits/6e5ca3e0dc83387a66f58286ea7218bd9ed1e261


[Feature]: Support for a proposal model that takes inputs from base model

🚀 The feature, motivation and pitch
In approaches like Medusa/EAGLE/Hydra, the speculative model uses the last hidden states from the base model to propose candidates. This feature will allow any such approaches to be implemented with ease. One idea is to store the required base model's outputs along with the sequence and then use that while generating candidates for the next iteration.
Alternatives
No response
Additional context
No response

If this makes sense, I would like to implement this. I can also implement the Medusa and EAGLE approach that can help test this feature.

Hi @KexinFeng
Currently what I've implemented only takes top-1 predictions to get single-sequence draft tokens. I agree that tree-style speculation is essential to get a significant acceleration. I've observed it in a torch.compile based implementation I worked on (based on gpt-fast), but I've not tried implementing that in vllm yet as it looked more complicated at the time and I knew it is already being worked on.
As for the current implementation of Medusa and EAGLE using a single sequence, I'll create a PR as soon as I've tested it a bit more and have company approvals.

cc @cadedaniel @LiuXiaoxuanPKU for visibility.

@abhigoyal1997 This is indeed an important feature that people have been looking for. It's also within my exploration radar, and I look forward to its implementation in vllm. Here is some detailed question. I know for Medusa, tree-draft-tokens play an essential role; for Eagle, it is also important. In your implementation, did you enable tree-draft-tokens, or is it still the single-sequence draft-tokens?
I'm asking this because I'm developing this tree-style speculation. And it will be a perfect match with the Medusa/Eagle/Hydra here. We can maybe combine the effort and see how the performance boost when the two technieques are put together. #4565 (comment)

I'm excited that you're working on this. I'm also considering adding tree attention to vllm to adapt it to EAGLE. How is your work going now？ I'd like to ask where I should make efforts to modify it, and do you have an open source plan?


Reporter should display ms/sec appropriately

Instead of
[06:51:36] Finished "default" in 24420 ms

Display
[06:51:36] Finished "default" in 24.4 s

Thanks @Aweary !


Add Transaction Hash

can i suggest adding the versions to the titles in future? would make it easier to review! :)


Fix escaping of (

Fixies flake's W605: invalid escape sequence

failing is unrelated to this patch.


Can this plugin locate the place when clicking on the title in table of tables?

It seems that this plugin will open a new page for the block when clicking on the title in Table of Contents. Can it jump to the place in the original page like Typora outline instead of opening a new page?
Typora:

Jump instead of opening a newpage:

Available in v1.5.1. Just remove the checkbox in the plugin settings!


Refactor package names from seedu.address to seedu.tracey

Codecov Report

Merging #53 (53e9d00) into master (112d871) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master      #53   +/-   ##
=========================================
  Coverage     70.65%   70.65%
  Complexity      437      437
=========================================
  Files            75       75
  Lines          1445     1445
  Branches        150      150
=========================================
  Hits           1021     1021
  Misses          376      376
  Partials         48       48

Impacted Files
Coverage Δ

src/main/java/seedu/tracey/AppParameters.java
75.00% <ø> (ø)

src/main/java/seedu/tracey/Main.java
0.00% <ø> (ø)

src/main/java/seedu/tracey/MainApp.java
0.00% <ø> (ø)

...rc/main/java/seedu/tracey/commons/core/Config.java
68.18% <ø> (ø)

...in/java/seedu/tracey/commons/core/GuiSettings.java
69.23% <ø> (ø)

...ain/java/seedu/tracey/commons/core/LogsCenter.java
78.37% <ø> (ø)

.../main/java/seedu/tracey/commons/core/Messages.java
0.00% <ø> (ø)

...c/main/java/seedu/tracey/commons/core/Version.java
82.50% <ø> (ø)

...in/java/seedu/tracey/commons/core/index/Index.java
100.00% <ø> (ø)

...ey/commons/exceptions/DataConversionException.java
100.00% <ø> (ø)

... and 65 more

:mega: Codecov can now indicate which changes are the most critical in Pull Requests. Learn more


KubeletConfiguration doesn't work while using ntpConfiguration

What happened: Kubelet configuration didn't apply to kubernetes nodes, when ntp configuration used in VSphereMachineConfig manifests of these nodes
What you expected to happen: Kubelet configuration applied correctly along with configured ntp servers
How to reproduce it (as minimally and precisely as possible): Set any settings in kubeletConfiguration for controlPlane or workerNode (ex. maxPods), set any valid servers for ntp in VSphereMachineConfig manifests of nodes, for which kubeletConfiguration used
Anything else we need to know?: Bottlerocket OS used for cluster
Environment:

EKS Anywhere Release: v.0.20.2

Thank you for creating this issue. Do you mind adding more details about the cluster configuration?
Was this a create or an upgrade? If it was an upgrade, what version was the cluster originally created with? What was the kubernetes version used?
Without divulging sensitive information, do you mind sharing the cluster spec used? Specifically the hostOSConfiguration and the kubeletConfiguration specified?
In the hostOSConfiguration was the field for bottlerocketConfiguration also populated with any settings?
When the cluster was created, did the NTP server settings get set properly?

Hi, @mitalipaygude !

Was this a create or an upgrade? If it was an upgrade, what version was the cluster originally created with? What was the kubernetes version used?

I tried both creating new cluster, and upgrading freshly created cluster, behavior was the same in both scenarious. Every time I add ntpConfiguration to VSphereMachineConfig, kubeletConfiguration get ignored. Kubernetes version was 1.30.

In the hostOSConfiguration was the field for bottlerocketConfiguration also populated with any settings?

No, only ntpConfiguration

When the cluster was created, did the NTP server settings get set properly?`

Yes, NTP settings was correct and got applied to nodes
Example of config with both kubeletConfiguration and hostOSConfiguration, all other parts which not related to this problem removed:
apiVersion: anywhere.eks.amazonaws.com/v1alpha1
kind: Cluster
metadata:
  name: workload-test
spec:
  controlPlaneConfiguration:
    count: 3
    kubeletConfiguration:
      kind: KubeletConfiguration
      maxPods: 50
    machineGroupRef:
      kind: VSphereMachineConfig
      name: workload-test-cp
---
apiVersion: anywhere.eks.amazonaws.com/v1alpha1
kind: VSphereMachineConfig
metadata:
  name: workload-test-cp
spec:
  osFamily: bottlerocket
  hostOSConfiguration:
    ntpConfiguration:
      servers:
        - ntp.example.loc

Hello @kobin23 , thank you for the response. We are looking into this issue and mostly should have a fix in the upcoming patch release for the same.

Fixed in v0.20.4 version


Correct cURL sample of unit user's document

Correspond to the following two points

The method of specifying the owner name in creation and acquisition of cell is "{UnitURL}/{UnitUserName}".
It corresponds to change to "personium-localunit:/{CellName}/#{UnitUserName}".

The method of cURL sample issuing unit user token is GET.
The correct answer is corrected for POST.

This issue include two issues, 1 & 2. Number 2 (bug) can correct soon , but Number 1 (enhancement) can not correct soon. So , I change only number 2 , and create new Issue for number 1.


Calculated Version customization

Is there any way of adding version customization for the version calculated by jgitver?
Currently, I'm using jgitver and it allows to have versions like:
Tag: v1.2.4-example  ---> Calculated version: 1.2.4 or 1.2.4-SNAPSHOT
Is it possible to add a customization in order to achieve this:
Tag: v1.2.4-example  ---> Calculated version: 1.2.4.something or 1.2.4.something-SNAPSHOT

@Timunas if you use jgitver using the maven.like mode, this is not possible unless you work on the branch example.
But if you use jgitver in non maven like mode, then any qualifier part of tag that serve as version base is reused for the final version computation.
If you use the maven plugin then something like below should do the trick.

Nevertheless, I'll evaluate the fact that the qualifier is ignored in maven like mode.

Yeah, I understand that. But in my scenario, I want to achieve that without adding the customization to the tag.
In my case, for example I want to tag my component with v1.0.0 and then based on that tag deploy several artifacts that just change a dependency version:
For dependency version X, I would want: TAG = v1.0.0 Version= X-1.0.0 or 1.0.0-X
For dependency version Y, I would want: TAG = v1.0.0 Version= Y-1.0.0 or 1.0.0-Y

@Timunas I you want the above I see 2 solutions with current jgitver
Solution 1:

tag the commit with 1.0.0
create branch X and Y on this commit
checkout branch X, mvn validate ->1.0.0-x
checkout branch Y, mvn validate ->1.0.0-y

Solution 2:

tag the commit with 1.0.0
switch to a DETACHED head
use feature created in #40 to provide an additional qualifier using either system property jgitver.branch or environment variable JGITVER_BRANCH

May I ask you what is your use case for the need of 2 different versions for the same commit?

and I forgot to mention that #33 will answer your needs.
Definitively it would be beneficial to find time to provide it...

@McFoggy I will try to explain.
So I have a project currently in sbt (using sbt dynver for versioning) and now moving to maven and that is why I'm using maven jgitver plugin.
In the build tool, when a new tagged release is going to be deployed to nexus, we want to deploy 3 artifacts bundled with dependencies that basically have the same code but using a different external dependency version for one of them.
Lets say we tag it with v1.0.0. And we have these external dependency versions: (10, 11, 12)
When we call sbt publish with an env var like DEP_VERSION=12, it will basically pull the tag and then
package the artifacts and publish artifacts with a version like: 12-1.0.0
So I want to achieve something similar with jgitver and maven.
I can see a possible way of doing this using jenkins CI and making it checks out the code to a different branch.
Anyway, the artifacts versions are currently prefixed and I don't want to change the behavior, but it seems that for now the only way of doing this is using one of the solutions above that will add the branch name as a suffix.

@Timunas in actual version the " easiest way to achieve what you ask for is to use a branch either explicitly by checkout-ing such branch, or by providing fake branch information when working on a detached HEAD.
It exists another solution, that seems to work (bug?) only when on HEAD (at least in maven mode). This solution consists in providing the qualifier in the tag that is used as base version for the computation.
Thus something like the following should also work:

git tag -a v1.0.0-X
mvn validate => 1.0.0-X

Yeah, thank you for explaining the available solutions.
Anyway, it would be nice to have the issue #33  implemented.


Request: API method to get wallet transactions

Hi,
I went through the API but can't seem to find any method that gives me a list of transactions.
Having such an API call would be awesome!
I asked about it more often and i think the answer thus far was that it's a hidden feature somewhere. I forgot where though.
Cheers,
Mark

This is not available because NKN node has no efficient way to do that, just like other blockchains using balance model (e.g. Ethereum). The most convenient way is to use blockchain explorer. You might want to check rule110's nkn openapi. We hosted one openapi node at https://openapi.nkn.org/docs/


Impossible to add XCFramework to flutter ios plugin

Steps to reproduce
Hi there,
I try to create a flutter ios plugin that ships with the PDFium binary inside. I tried multiple approaches now, and it seems to be impossible to get flutter and xcode to get the framework along with the plugin. I googled and tried for multiple days now and there is no real documentation (other than hello world examples) that show how to add external dependencies to ios plugins.
I tried with static libs, but then, the simulator is not supported.
I tried with xcframeworks, but then, xcode build does not find my framework.
I do not know how to proceed, it just seems impossible.
So:

Create the flutter plugin with platform ios
Download the pdfium framework from https://github.com/paulocoutinhox/pdfium-lib/releases/download/6276/ios.tgz
Extract the ios.tgz and find the .xcframework folder there
Copy the framework folder into the plugins /ios folder
Configure podspec with

  s.vendored_frameworks = 'pdfium.xcframework'
  s.preserve_paths = 'pdfium.xcframework'
  s.xcconfig = { 'OTHER_LDFLAGS' => '-framework pdfium' }
  s.libraries = ['c++', 'z']

Try to run the project
Find an error "Error (Xcode): Framework 'pdfium' not found"

Expected results
I expect that xcode takes the framework, since it is specified and links it to the plugin lib. I also found resources on how to configure the podspec to configure striping for non-global symbols only. But I'm not even there :)
Actual results
The above mentioned error. No chance on running the project on the simulator or any real device so far.
Code sample
None. There is no code in the plugin, just an external ref.
Screenshots or Video
No response
Logs
Logs
Launching lib/main.dart on iPhone 15 Pro Max in debug mode...
Running Xcode build...
Xcode build done.                                           12.7s
Failed to build iOS app
Error (Xcode): Framework 'pdfium' not found

Error (Xcode): Linker command failed with exit code 1 (use -v to see invocation)

Could not build the application for the simulator.
Error launching application on iPhone 15 Pro Max.

Flutter Doctor output
Doctor output
[✓] Flutter (Channel stable, 3.22.0, on macOS 14.5 23F79 darwin-arm64, locale en-CH)
    • Flutter version 3.22.0 on channel stable at /opt/homebrew/Caskroom/flutter/3.16.0/flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 5dcb86f68f (3 weeks ago), 2024-05-09 07:39:20 -0500
    • Engine revision f6344b75dc
    • Dart version 3.4.0
    • DevTools version 2.34.3

[✓] Android toolchain - develop for Android devices (Android SDK version 34.0.0-rc3)
    • Android SDK at /Users/xxx/Library/Android/sdk
    • Platform android-34, build-tools 34.0.0-rc3
    • ANDROID_HOME = /Users/xxx/Library/Android/sdk
    • Java binary at: /Users/xxx/Applications/Android Studio.app/Contents/jbr/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 17.0.10+0-17.0.10b1087.21-11572160)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 15.4)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Build 15F31d
    • CocoaPods version 1.15.2

[✗] Chrome - develop for the web (Cannot find Chrome executable at /Applications/Google
    Chrome.app/Contents/MacOS/Google Chrome)
    ! Cannot find Chrome. Try setting CHROME_EXECUTABLE to a Chrome executable.

[✓] Android Studio (version 2023.3)
    • Android Studio at /Users/xxx/Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 17.0.10+0-17.0.10b1087.21-11572160)

[✓] VS Code (version 1.89.1)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.88.0

[✓] Connected device (3 available)
    • iPhone 15 Pro Max (mobile)      • D608EF19-9F30-49DD-8931-D701418E9762 • ios          •
      com.apple.CoreSimulator.SimRuntime.iOS-17-5 (simulator)
    • macOS (desktop)                 • macos                                • darwin-arm64 • macOS 14.5
      23F79 darwin-arm64
    • Mac Designed for iPad (desktop) • mac-designed-for-ipad                • darwin       • macOS 14.5
      23F79 darwin-arm64

[✓] Network resources
    • All expected network resources are available.

! Doctor found issues in 1 category.

Hi @buehler, I see there's an open issue addressing the case you described at https://github.com/flutter/flutter/issues/86275. It's still open.
Closing this issue as a duplicate, so please follow up on it for further updates.

Hey @huycozy
Thank you! Will follow the new issue then.


Change pageShifts from int to byte, to reduce memory usage

Motivation:
Change int pageShifts to byte pageShifts to reduce memory usage, because the byte range is enough for pageShifts.
Modification:
Change int pageShifts to byte.
Result:
Reduce memory footprint.

Does this really matter a lot ? I dont think the savings really worth it .

@normanmaurer @franz1981  There may many PoolSubpage objects been created, but yes it takes minor effect, feel free to close this.

After checked the PoolSubpage 's memory footprint, there is no difference between byte' and intforPoolSubpage , the byte` might be padded to 4 bytes. So close this.

Thanks hope you enjoyed the JOL plugin, is pretty handy!

@franz1981 Thanks a lot, but the JOL plugin shows object instance size increased from byte pageShifts  to int pageShifts, but the VisualVM plugin shows no different size between them(disabled UseCompressedOops) when actually inspect it while running. This may depends on my laptop's specific JVM. But anyway, this is a minor optimization which I think it is OK to stay code unchanged.

@franz1981 OK, I'll stick on jol plugin.


fix: update link in email

just remembered it's not updated

hmm for some reason before this pr, the email says http://localhost:8000 as seen above^ though the most recent master branch is http://localhost:3000

im not sure why but the link isn't updated, did i miss out somewhere or its the deployment side @seelengxd apologies for tag

thanks for the catch! was deployment side - build trigger was on a temporary branch


Bitwise read/write

As of now, there is no bitwise (bit by bit) read/write functions available.
Reading a bit is not so important because we can read a word and use desired bit inside the word, that might be handled in the application.
But writing a bit is a more complex operation (like database transactions) so it should be included/exposed by the library, possibly with a "dot notation" format:
client.write "C100.01", true/false

I would like to implement this, although time is against me. When I looked at the Omron manual, it seemed that MEMORY AREA WRITE can only write a WORD to the PLC. Therefore I think we would have to read a WORD to get its current value, amend the BIT value we wanted to write and then send that WORD back to the PLC.
Can anyone see a better way of doing this?

Mentioned PR's satisfies this issue. Thank you.


Following the Swap Widget example, getting "Can't resolve 'fs'"

Followed the example of the Swap Widget as in the README file, but I get:
next-dev.js?3515:20 ./node_modules/@ref-finance/ref-sdk/dist/ref-sdk.esm.js:3:0
Module not found: Can't resolve 'fs'

In the browser console.
See the implementation in my app here.
package version:
"@ref-finance/ref-sdk": "^1.1.5",

My guess is that the error happens at near.ts:
import fs from 'fs';

And then it gets exported as a whole for both server and client in index.ts:
export * from './near';

Should we add logic whether to export near.ts for only server side?

@max-mainnet any ideas what could be causing this error?
I know that outside the server environment, fs (file system) is not available, hence the error in the browser. But I assume the SwapWidget will not use fs in the client side?

+1

Hi @matricore @netpoe thanks for reporting this one. I have noticed this pb these days, I think the quick fix on your side is to overrides the config in your dapp side, the following is what linear does to prevent this issue. They use webpack to package the app, I think it helps though just a temporary solution for it.

yes , that's the cause of this issue, sdk exports modules node env needs, so a conflict on web side.

I know that outside the server environment, fs (file system) is not available, hence the error in the browser. But I assume the SwapWidget will not use fs in the client side?
yes this is the cause of the issue, we have decided to fix it in the future, listed in our todos now.

@max-mainnet thanks for the reference. I was able to do it in NextJS 13 with:
module.exports = {
  webpack: (config, { isServer, webpack }) => {
    if (!isServer) {
      config.plugins.push(new webpack.NormalModuleReplacementPlugin(/^fs$/, "../package.json")); // resolve to any file, relative to the node_module directory
    }

    return config;
  },
};

@max-mainnet following the discussion, I've found another issue:
Now that the widget renders successfully, I'm setting the defaultTokenList prop to have only 2 tokens:
return (
    <SwapWidget
      darkMode
      defaultTokenList={[defaultTokenInMetadata, defaultTokenOutMetadata]}
      className={clsx(styles["ref-swap-widget"], className)}
      onSwap={onSwap}
      onDisConnect={onDisConnect}
      width="100%"
      connection={{
        AccountId: accountId || "",
        isSignedIn: !!accountId,
      }}
      transactionState={{
        state: swapState,
        setState: setSwapState,
        tx,
        detail: "(success details show here)",
      }}
      enableSmartRouting
      onConnect={onConnect}
      defaultTokenIn={property.token.address}
      defaultTokenOut={property.contract.id}
    />
  );

Where defaultTokenList={[defaultTokenInMetadata, defaultTokenOutMetadata]} is:
{
    "spec": "ft-1.0.0",
    "name": "Tether USD",
    "symbol": "USDT.e",
    "icon": "data:image/svg+xml,%3Csvg xmlns='http://www.w3.org/2000/svg' width='32' height='32'%3E%3Cg fill='none' fill-rule='evenodd'%3E%3Ccircle cx='16' cy='16' r='16' fill='%2326A17B'/%3E%3Cpath fill='%23FFF' d='M17.922 17.383v-.002c-.11.008-.677.042-1.942.042-1.01 0-1.721-.03-1.971-.042v.003c-3.888-.171-6.79-.848-6.79-1.658 0-.809 2.902-1.486 6.79-1.66v2.644c.254.018.982.061 1.988.061 1.207 0 1.812-.05 1.925-.06v-2.643c3.88.173 6.775.85 6.775 1.658 0 .81-2.895 1.485-6.775 1.657m0-3.59v-2.366h5.414V7.819H8.595v3.608h5.414v2.365c-4.4.202-7.709 1.074-7.709 2.118 0 1.044 3.309 1.915 7.709 2.118v7.582h3.913v-7.584c4.393-.202 7.694-1.073 7.694-2.116 0-1.043-3.301-1.914-7.694-2.117'/%3E%3C/g%3E%3C/svg%3E",
    "reference": null,
    "reference_hash": null,
    "decimals": 6,
    "id": "usdt.fakes.testnet"
}

{
    "spec": "ft-1.0.0",
    "name": "Splitfund.xyz Property 3",
    "symbol": "SF3",
    "reference": null,
    "reference_hash": null,
    "decimals": 6,
    "id": "splitfund-3-d7ce.factory.splitfund.testnet"
}

both valid NEP141 tokens.
However, the widget won't display the latter:


Make rootVolume dependent on disk size being specified

When used in Azimuth, this will allow the volume type and AZ to be specified globally or by the template while allowing the individual cluster to specify volume sizes without worrying about conditional merges.

@scrungus Prod :-)


Slurm profile and exome analysis set up script for integration with Stager

exome_setup_stager.py: this script parses input from Stager (family, participants, and linked files) to set up the analysis directory for running the crg2 exome pipeline.
dnaseq_slurm_api.sh: not an actual script, but these are the commands I imagine we would add to Stager's call to the slurm API
An example call to exome_setup_stager.py:
python3 exome_setup_stager.py -a /hpf/largeprojects/ccmbio/mcouse/temp -f F1 -d '"P1":["file.bam", "file.vcf"]' '"P2":["file.bam"]'
I've made a few assumptions here (structure of the arguments passed to exome_setup_stager.py, and that the user calling the script has crg2 set up in their home directory).

@kevinlul let me know if this meshes with what you envision for pipeline automation


Default entry point is being updated incorrectly

Minimal, reproducible code sample, a copy-pastable example if possible
I don't think it's worth trying to create an MRE for this situation, please see below.
Problem description
This has turned out to be a much more subtle issue than I first thought. The problem looks like it's due to a combination of two factors:

The interface of the EntryPoint object changing over time, and
The monkey-patching of importlib.metadata by importlib_metadata

To start with, we need to look at the evolution of importlib_metadata. Until importlib_metadata version 4.13.0, the EntryPoints class had an __iter__ method. This method was deprecated much earlier (sometime around 3.x) but was not removed until version 5.0.0. Meanwhile, version 4.8.1 introduced support for EntryPoints.__getitem__ via the DeprecatedTuple class, functionality which had been supported in previous versions but had been removed.
Now, when we roll around to version 5.0.0, the removal of EntryPoints.__iter__ meant that iteration over an EntryPoints object instead fell back to calling __getitem__ (this is how iterables are designed in Python). The problem is that the __getitem__ implementation would in turn call _key, which would return a tuple (self.name, self.value, self.group). This is a problem because the old __iter__ implementation instead returned iter((self.name, self)).
The relevant code in numcodecs for Python 3.9 is assuming that we'll get the second interface, such that given a tuple of EntryPoint objects we'll be able to process it as key-value pairs of the form (name, EntryPoint), which works with the old explicit __iter__ API but not the new __getitem__ implicit iteration API.
A major part of the complexity comes from the fact that importlib_metadata was provisionally added to the standard library as importlib.metadata in Python 3.8, then made a full part of the standard in 3.10. As of Python 3.9, the version of the code still had an EntryPoints object that defined __iter__, i.e. it was matching importlib_metadata<5.0.0. Therefore, the code in numcodecs seems like it should work. However, importlib_metadata actually monkey-patches parts of importlib.metadata:
>>> from importlib.metadata import entry_points
>>> type(entry_points()[next(iter(entry_points()))][0])
<class 'importlib.metadata.EntryPoint'>
>>> import importlib_metadata
>>> type(entry_points()[next(iter(entry_points()))][0])
<class 'importlib_metadata.EntryPoint'>

Note that on the final line we go from importlib.metadata to importlib_metadata. This is the root of the problem: if you have a newer version of importlib_metadata installed in Python 3.9, you start seeing EntryPoints objects with the new iteration protocol instead of the old one. Therefore, in the Python 3.9 scenario numcodecs needs to handle both possibilities.
The simplest solution is to avoid relying on the iteration protocol altogether and simply construct the appropriate update argument manually. This is what I now do in #475.
Version and installation information
Please provide the following:

Value of numcodecs.__version__: 0.12.0
Version of Python interpreter: 3.9.18
Operating system (Linux/Windows/Mac): Linux (Ubuntu 20.04
How NumCodecs was installed (e.g., "using pip into virtual environment", or "using conda"): Using conda or pip

Also, if you think it might be relevant, please provide the output from pip list or
conda list depending on which was used to install NumCodecs.

Yeah we had to do the same in RAPIDS unfortunately
Reading over Vyas' nice writeup above would help
Reviewing the PR: https://github.com/zarr-developers/numcodecs/pull/475
Suggesting a test we can use to ensure we don't reintroduce this accidentally in the future


Incorrect Name metadata

According to the https://github.com/openzim/overview/wiki/Naming-Convention, the Name metadata is incorrect in phet created ZIM files.
It is currently: phets_afr while it should be phets_af_all for instance: ISO-639-1 language code and selection/all specifier.
This is based on 2023-03-01 run

@pavel-karatsiuba please update. This is indeed a convention we have that we don't respect. Shoukd be straight.

@kelson42
phet zim can be multilingual so the metadata Name will be equal to phets_mul. Which language do I need to set in this case?

Yes, "phet_mul_all"

Given you've agreed to use the _all selection specifier in the Name, is there a reason not to use it in the filename?
The convention suggests using the same because it avoids confusion ans most likely simplifies maintenance.
phet_mul_2023-03.zim
- Language: afr,sqi,amh,ara,hye,aym,aze,bak,eus,bel,ben,bis,bos,bul,mya,cat,nya,zho,zho,zho,hrv,ces,dan,nld,eng,est,fao,fin,fra,fur,glg,lug,kat,deu,ell,guj,hat,hau,heb,hin,hun,isl,ibo,ind,gle,ita,jpn,kan,kaz,khm,kik,kin,kor,kur,lao,lav,lit,mkd,msa,mal,mlt,mri,mar,ron,mon,nep,nob,nno,ori,orm,pus,fas,pol,por,ron,rus,srp,hbs,snd,sin,slk,slv,sot,spa,swa,swe,tgl,tgk,tam,tel,tha,bod,tir,tsn,tur,tuk,twi,ukr,urd,uzb,vie,cym,wol,xho,yor
- Name: phets_mul_all

phet_af_2023-03.zim
- Language: afr
- Name: phets_af_all

Let me know if you decide to change the name so I'll cleanup the folder.


flight state to parsing

test this please

test models please

test models please

@mjburton11 ready to merge this if it passes model tests

@bqpd they won't pass unfortunately until I get convexengineering/solar#13 to pass

merging now, will fix solar, gassolar and jho after.


License updates for dependabot/github_actions/erlef/setup-elixir-1.11

This PR was auto generated by the licensed-ci GitHub Action.
It contains updates to cached github/licensed dependency metadata to be merged into dependabot/github_actions/erlef/setup-elixir-1.11: (branch, PR).
The licensed-ci action will add comments to this PR with the status of license checks.  Please make any changes needed to fix any status failures on this branch, then merge license updates into your branch.
If updates are unexpected, please check the github/licensed changelog for recent updates.

The licensed-ci GitHub Action updated cached license metadata based on changes to dependabot/github_actions/erlef/setup-elixir-1.11: (branch, PR).
licensed status result: SUCCEEDED
All status checks succeeded, please merge when ready.
Checking cached dependency records for licensed
.............................
29 dependencies checked, 0 errors found.

/cc @dependabot[bot]


Added Restful conditional

Had a problem building, but added simple conditional in the event the call needed is not a query string, but a restful query in the ending URI.
Fixes #21

Hi @weklund, thanks for the PR!
Maybe we could avoid to use another option? I suggest to use the queryParamName for this.
If we want to use RESTful queries:
{
  queryParamName: null
}

There we are :)

Thanks!


Edit an existing row by sending the row number

I have been searching about editing fields of an existing row by sending the row number. I know this can be done with cells by sending the specific cell but is there a way to send an array or object to edit a row completely?
Apprecciate your help. Thanks in advance.

This module is not really set up for that at the moment, but you might be able to do something hacky

load a single row
clone it
change the _rowNumber property to the row in question (A1 style row, ie first row is 1, not 0)
update the values, call save


Inquirer plugin crashes with plop 1.6.0

Looks like there is some mismatch in plop, inquirer, around the use of promises:
Offending code:
plop/node_modules/inquirer/lib/ui/prompt.js:79:50
PromptUI.prototype.fetchAnswer = function (question) {
  var Prompt = this.prompts[question.type];
  var prompt = new Prompt(question, this.rl, this.answers);
  return rx.Observable.defer(function () {
// This next lines fails as prompt.run() doesn't seem to return a promise
    return rx.Observable.fromPromise(prompt.run().then(function (answer) {
      return {name: question.name, answer: answer};
    }));
  });
};

Log:
(Use "/" key to search this directory)[ERROR] Cannot read property 'then' of undefined TypeError: Cannot read property 'then' of undefined
    at /Users/ppodil/Projects/react-mobx-seed/node_modules/plop/node_modules/inquirer/lib/ui/prompt.js:79:50
    at tryCatcher (/Users/ppodil/Projects/react-mobx-seed/node_modules/rx/dist/rx.js:63:31)
    at Defer.subscribeCore (/Users/ppodil/Projects/react-mobx-seed/node_modules/rx/dist/rx.js:2536:37)
    at Defer.tryCatcher (/Users/ppodil/Projects/react-mobx-seed/node_modules/rx/dist/rx.js:63:31)
    at setDisposable (/Users/ppodil/Projects/react-mobx-seed/node_modules/rx/dist/rx.js:2082:46)
    at Defer.Rx.ObservableBase.ObservableBase._subscribe (/Users/ppodil/Projects/react-mobx-seed/node_modules/rx/dist/rx.js:2097:9)
    at Defer.Rx.Observable.observableProto.subscribe.observableProto.forEach (/Users/ppodil/Projects/react-mobx-seed/node_modules/rx/dist/rx.js:2034:19)
    at MergeObserver.handleSubscribe (/Users/ppodil/Projects/react-mobx-seed/node_modules/rx/dist/rx.js:3525:28)
    at MergeObserver.next (/Users/ppodil/Projects/react-mobx-seed/node_modules/rx/dist/rx.js:3531:14)
    at MergeObserver.Rx.internals.AbstractObserver.AbstractObserver.onNext (/Users/ppodil/Projects/react-mobx-seed/node_modules/rx/dist/rx.js:1762:31)

I believe this is likely a problem with a plugin that has not been updated to the 1.x release of inquirer. If you need to use plugins that use the 0.x version of inquirer you may need to revert the version of plop that you are using to 1.5.0. I'm open to other possible solutions, but I don't know of any at this time.

I'm happy to re-open this issue if there are other possible ways to address this issue.

Ok, for now I am switching back to 1.5.0. Hope @nicksrandall gets a chance to look and fix this.

if not, someone will probably make a fork that will work

fixed via https://github.com/nicksrandall/inquirer-directory/releases/tag/v2.1.0

Awesome @nicksrandall. Could you please publish to NPM as well :-)

Finally was able to updated inquirer-directory and things are stable again. Thanks @nicksrandall


Issue 54

Going to merge what I have to main and come back to it after we figure out how were going to multi-dispense