Update serialize() object in src/vessel-charging/BidParams.ts and associated tests in src/vessel-charging/BidParams.test.ts using Jest

first-timers-only
This issue is tagged 🕺  first-timers-only. It is only for people who have never contributed to open source before, and are looking for an easy way take their first steps.
Consider this your chance to dip your toe into the world of open-source, and get some bragging rights for writing code that makes drones fly, lets cars find charging stations, helps people and goods get from place to place, and more.
Find more first-timers-only issues from DAV Foundation here.
Thank you for your help :heart:
What is this project?
DAV (Decentralized Autonomous Vehicles) is a new foundation working to build an open-source infrastructure for autonomous vehicles (cars, drones, trucks, robots, and all the service providers around them) to communicate and transact with each other over blockchain.
As an organization that believes in building a large community of open-source contributors, we often create issues like this one to help people take their first few steps into the world of open source.
dav-js
This repo contains the DAV JavaScript SDK. This SDK allows developers to build applications and servers that connect to the DAV network. For example, allowing a drone to find charging stations, or an autonomous car to ask for traffic data.
How you can help
In order to foster a community that is welcoming for open source contributions, it is important for us to have good test coverage. And good tests are simple, readable tests.
Here is a good opportunity to update one of our tests.
The Issue
In the src/vessel-charging/BidParams.ts class, the serialize() method is not returning our arguments correctly. provider, manufacturer and model are being set to this.amenities but they should be set to their associated arguments.
Currently:
  public serialize() {
    const formattedParams = super.serialize();
    Object.assign(formattedParams, {
      entranceLocation: this.entranceLocation,
      exitLocation: this.exitLocation,
      availableFrom: this.availableFrom,
      availableUntil: this.availableUntil,
      energySource: this.energySource,
      amenities: this.amenities,
      provider: this.amenities,
      manufacturer: this.amenities,
      model: this.amenities,
    });
    return formattedParams;
  }

The Updates
Please update the test file src/vessel-charging/BidParams.test.ts to ensure amenities, provider, model, manufacturer are being handled correctly and update src/vessel-charging/BidParams.ts by passing the associated arguments to provider, manufacturer, model.
1. Update the tests
The test should ensure amenities, provider, model and manufacturer are being passed through and returning correctly in the test file src/vessel-charging/BidParams.test.ts.
Please update this test by:

Adding Amenities to the ./enums import

import { EnergySources, Amenities } from './enums';

Add arguments amenities, provider, model and manufacturer to the instantiation of BidParams

const bidParams = new BidParams({
  // existing params
  amenities: [Amenities.Docking, Amenities.Grocery],
  provider: 'Charging Co',
  model: 'iCharger',
  manufacturer: 'Vessel Chargers',
});

Update serializedBidParams object with the arguments (amenities, provider, model and manufacturer) passed above

const serializedBidParams: any = {
  // existing properties
  amenities: [Amenities.Docking, Amenities.Grocery],
  provider: 'Charging Co',
  model: 'iCharger',
  manufacturer: 'Vessel Chargers',
};

After making your changes, run npm run jest.
You should receive an error similar to below.

This is expected as the serialize() method in src/vessel-charging/BidParams.ts is still returning provider, manufacturer and model as this.amenities.
The next update will fix this error.
2. Update serialize() in BidParams
The serialize() method in src/vessel-charging/BidParams.ts should return the arguments associated with provider, manufacturer and model.

Update the serialize() method

  public serialize() {
    const formattedParams = super.serialize();
    Object.assign(formattedParams, {
      entranceLocation: this.entranceLocation,
      exitLocation: this.exitLocation,
      availableFrom: this.availableFrom,
      availableUntil: this.availableUntil,
      energySource: this.energySource,
      amenities: this.amenities,
      provider: this.provider,
      manufacturer: this.manufacturer,
      model: this.model,
    });
    return formattedParams;
  }

After making your changes, run npm run jest to make sure our tests are now passing.
Contributing to dav-js

[ ] Make sure this issue is labeled up-for-grabs and not labeled claimed, to verify no one else is working on it.
[ ] Comment on this issue that you would like to do it (if you're the first you can start working on it immediately)
[ ] Open dav-js GitHub page and click the ★ Star and then ⑂ Fork buttons
[ ] Clone a copy to your local machine with $ git clone git@github.com:YOUR-GITHUB-USER-NAME/dav-js.git
[ ] Install dependencies by running npm install
[ ] Make sure everything is working and all tests pass by running npm run jest
[ ] Code Code Code
[ ] Make sure everything is still working and all tests pass by running npm run jest again
[ ] Commit all your changes
[ ] Push your local changes back to github with $ git push -u origin master
[ ] Visit your fork on GitHub.com (https://github.com/YOUR-USER-NAME/dav-js) and create a pull request for your changes.
[ ] Make sure your pull request describes exactly what you changed and references this issue (include the issue number in the title like this: #7)
[ ] Please do not fix more than one issue at a time. Your pull request should only fix what is described in this issue.

Asking for help
We appreciate your effort in taking the time to work on this issue and help out the open source community and the foundation. If you need any help, feel free to ask below or in our gitter channel. We are always happy to help 😄

Hey :) I'll take a shot at it!

I'm running into issues installing the dependencies with npm - not sure if this is a windows issue?
Getting these errors:

<EMAIL_ADDRESS>preinstall C...\dav-js
(rm .git/hooks/* && cp ./.githooks/* .git/hooks) || true
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR<EMAIL_ADDRESS>preinstall: (rm .git/hooks/* && cp ./.githooks/* .git/hooks) || true
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>preinstall script.

'rm' is not recognized as an internal or external command,
operable program or batch file.
'true' is not recognized as an internal or external command,
operable program or batch file.

Hey @shalini-s thanks for helping out! I am getting this error on Windodws as well. It is passing on a Mac :sweat_smile: I will let our devs know.

Hi @shalini-s It looks like you found a bug 🐞 My apologize for the issue. We will let you know when this is resolved.
I have also added more depth to this issue. It is different from when you started. If you have any questions, you are more than welcome reach out 👐 .

Hey @shalini-s, our devs pushed out a fix for Windows that should resolve the install errors. Could you pull from master and let me know if you are still getting install errors?

 System Windows_NT 10.0.17134
gyp ERR! command "C:\Program Files\nodejs\node.exe" "C:\Users\...\AppData\Roaming\npm\node_modules\npm\node_modules\node-gyp\bin\node-gyp.js" "rebuild"
gyp ERR! cwd C:\Users...\dav-js\node_modules\keccak
gyp ERR! node -v v8.11.1
gyp ERR! node-gyp -v v3.8.0
gyp ERR! not ok
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR<EMAIL_ADDRESS>rebuild: node-gyp rebuild
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>rebuild script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.
npm WARN Local package.json exists, but node_modules missing, did you mean to install?
npm ERR!      C:\Users...\AppData\Roaming\npm-cache_logs\2018-10-15T04_09_14_521Z-debug.log
"Keccak bindings compilation fail. Pure JS implementation will be used."

 System Windows_NT 10.0.17134
gyp ERR! command "C:\Program Files\nodejs\node.exe" "C:\Users\...\AppData\Roaming\npm\node_modules\npm\node_modules\node-gyp\bin\node-gyp.js" "rebuild"
gyp ERR! cwd C:\Users.\dav-js\node_modules\scrypt
gyp ERR! node -v v8.11.1
gyp ERR! node-gyp -v v3.8.0
gyp ERR! not ok
npm WARN<EMAIL_ADDRESS>requires a peer of<EMAIL_ADDRESS>but none is installed. You must install peer dependencies yourself.
npm WARN optional SKIPPING OPTIONAL DEPENDENCY<EMAIL_ADDRESS>(node_modules\fsevents):
npm WARN notsup SKIPPING OPTIONAL DEPENDENCY: Unsupported platform for<EMAIL_ADDRESS>wanted {"os":"darwin","arch":"any"} (current: {"os":"win32","arch":"x64"})
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR<EMAIL_ADDRESS>install: node-gyp rebuild
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>install script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.
npm ERR!      C:\Users...\AppData\Roaming\npm-cache_logs\2018-10-15T04_09_17_740Z-debug.log

@shalini-s Just before we dive into this, could you clone the latest version of the repository, do npm install again and let us know what you're getting?

@mariolo1985  @TalAter I will have a go with all the First timers. :)

is this still an issue?


Update: Request Validator plugin parameter validation info

Description
To be able to do parameter validation with the Request Validator plugin, the parameter must be deserialized according to the
OAS type serialization (see https://swagger.io/docs/specification/serialization/).
Adding this info to the plugin's docs.
https://konghq.atlassian.net/browse/DOCU-1896
Testing instructions
Preview link:
Checklist

[x] Review label added
[x] PR pointed to correct branch (main for immediate publishing, or a release branch: e.g. release/gateway-3.2, release/deck-1.17)

Covered in https://github.com/Kong/kong-ee/pull/6522


Migrate CI from Travis and Appveyor to GitHub Actions

Travis is not available, so we have to migrate to GitHub Actions. We also can drop the Appveyor as well.

https://github.com/nervosnetwork/blake2b-rs/commit/f7d1f29b155f3498500080eeb1db45624ecdbbfb


Browsers other than Firefox

I've downloaded pdf.js tonight with a view to using it for a project.  I tried the viewer.html with Safari and whist the viewer loads, the PDF did not.  I then tried it with Firefox and it all works perfectly.
It doesn't work in chrome either.  Is there any intent to get this working with all the major web-browsers ?
When trying this:
https://mozilla.github.io/pdf.js/web/viewer.html
With Safari online it works fine, but the offline demo:
file://svr/pdfjs/web/viewer.html
Does not ?

When trying this:
https://mozilla.github.io/pdf.js/web/viewer.html
With Safari online it works fine, but the offline demo:

What about chrome?

file://svr/pdfjs/web/viewer.html
Does not ?

Maybe but not sure, this seems to be a problem of file:// protocol, some browsers does not allow to access local files using xhr due to security reasons. Basically it violates Access-Control-Allow-Origin.

Thank you, that makes sense.

As mentioned in the README, see https://github.com/mozilla/pdf.js#getting-the-code, not all browsers support file:// URLs. The solution is to use a web server; closing as answered.


Keybase throws track error when friend changed his key.

Hi,
A few weeks ago I had to change my key and push them to keybase. There is no problem thus far..
The main reason for what we use Keybase is to make key sharing easy and managable. However after I changed my keys and asked my friend to refresh (pull) their list, they received an error says that:
"2018-10-03T13:33:35.818522+03:00 - [WARN keybase log_ui.go:36] 010 Keybase says that ziyahan owns key fc8ef5e568350fb6357287e7bc7829cc3574089e, but you have not tracked this fingerprint before. [tags:ENG=XaToxD4mfA6w]"
and could  not update my public key in their list. If and only after the unfollowing and then following me, they can update their list with my new key.
It is very weird.
Could you explain why it happened and whether it is expected behavior? It seems a bug.
Thanks in advance.

 This sounds exactly as intended. Did you reset your account? If so your followers need to reverify your identity.  Were this not the case, we could reset people Willy billy and replace legit account with fake accounts, and your followers would get bogus keys.

How refollow works? Where is the functionality. I cannot see anything releated to "refollow" :)

Thank you very much!


Fixer configuration parameters should be documented

It seems the documentation for fixers lives in the root readme file, which is convenient, but neglects to specify which parameters can be passed and their valid values. The readme only makes a distinction between fixers that have parameters and those that do not. For example, for a configurable fixer, the documentation states:

Rule is: configurable.

This is inadequate and should instead provide a detailed list of each parameter and its accepted values. If this would make the documentation too verbose to live in the root readme then it should be linked in a separate documentation file.

use describe command to get description on CLI of rule and it's parameters.
readme update is on the way: #2500

Valid point, solution is on the way.
Closing. For detailed discussion how to present data in readme file, go to mentioned PR.


Please add support  Viomi water heater

Hi,
Would it be possible to support viomi water heater? Many Thanks
Device Model
viomi.waterheater.e8
22/11/2021, 23:43:33Miot Bridgemiot[Water Heater] Got device configuration, initializing device with name: Water Heater
22/11/2021, 23:43:33Miot Bridgemiot[Water Heater] Device model known: viomi.waterheater.e8! Creating device!
22/11/2021, 23:43:33Miot Bridgemiot[Water Heater] Initializing device properties
22/11/2021, 23:43:33Miot Bridgemiot[Water Heater] Initializing device actions
22/11/2021, 23:43:33Miot BridgemiotWARNING[Water Heater] Device not supported! Using a generic device with limited properties! Consider requesting device support!
Best Regards,
Daniel

Should be possible. Will add support in the next update!

Should be possible. Will add support in the next update!

Many thanks for your support

The device should now be supported as of version 0.9.18

![WeChat Image_20211203160243](https://user-images.githubusercontent.com/88359393/144567045-a1dc691e-56e7-4e27-bbe9-2a00304b3854.jpg

)

Viomi water heater is not a Kettle. It is a bath water heater. Besides, I can't turn on the bath water heater in homekit. In homekit, it is only able to show the water temp and always showing turn off even though it is in heating mode.
Please kindly help to see whether we can control the heater in homekit. Many many thanks

Oh, is it not a kettle? You should have mentioned that in the beginning since most of the device s I usually never even heard of before...
I can have a look at it again but it will take quite some time till I have time to do that...

Sorry for my misleading information. Thanks for your help

Should now be fixed in version 1.0.0


ESP8266 Digital input not constant floating from 0 to 1

Hello all,
i am facing an issue on setting a int based on a digital input(D5).When the DI is High (conected to the 3.3v) the values are always swapping between 0 and 1. When Connected directly to the ground the value is stable at 0 as expected.

thank you

Your high source of power probably has high impedance. Can you try use
pulldown resistor? What is your circuit?
On Wed, Jun 27, 2018, 13:12 Cleric182<EMAIL_ADDRESS>wrote:

Hello all,
i am facing an issue on setting a int based on a digital input(D5).When
the DI is High (conected to the 3.3v) the values are always swapping
between 0 and 1. When Connected directly to the ground the value is stable
at 0 as expected.
[image: untitled]
https://user-images.githubusercontent.com/40640002/41988839-421eea70-7a35-11e8-8ff9-dfb36f393771.png
thank you
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/firebase/firebase-arduino/issues/361, or mute the
thread
https://github.com/notifications/unsubscribe-auth/AD3-GHD3rFaygE7CJL_UGHfgB0XLo9Vnks5uA70UgaJpZM4U6E3W
.

Have you tried isolating the power source rather than powering it off of
the 3.3v esp8266 board?
https://photos.app.goo.gl/3zvVWhV1b33bvu4K9
On Jun 27, 2018 5:11 PM, "Sergei Kotlyachkov"<EMAIL_ADDRESS>wrote:
Your high source of power probably has high impedance. Can you try use
pulldown resistor? What is your circuit?
On Wed, Jun 27, 2018, 13:12 Cleric182<EMAIL_ADDRESS>wrote:

Hello all,
i am facing an issue on setting a int based on a digital input(D5).When
the DI is High (conected to the 3.3v) the values are always swapping
between 0 and 1. When Connected directly to the ground the value is stable
at 0 as expected.
[image: untitled]
<
https://user-images.githubusercontent.com/40640002/41988839-421eea70-7a35-11e8-8ff9-dfb36f393771.png

thank you
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/firebase/firebase-arduino/issues/361, or mute the
thread
<
https://github.com/notifications/unsubscribe-auth/AD3-GHD3rFaygE7CJL_UGHfgB0XLo9Vnks5uA70UgaJpZM4U6E3W
.

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/firebase/firebase-arduino/issues/361#issuecomment-400845657,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AY0XX39Y1WqCmo5iCNENzyoajh6NVPN7ks5uBAMWgaJpZM4U6E3W
.


Sunbreak Support

Data additions

[x] Add Sunbreak icons of large monsters under MHRS game tag.
[x] Add on basic data and image link to returning monsters.
[x] Add new monster skeletons and basic (known) info.
[x] Add descriptions for new monsters and Sunbreak descriptions for returning monsters.
[x] Add/Correct elements, ailments and weaknesses for new monsters.
[x] Add elements/ailments for final boss.
[x] Add returning/new small monsters. Noone seems to care to document these before release.
[x] Add in-depth info for returning/new small monsters.
[x] Add icons for returning/new small monsters.

Technical:

[x] Change MHRise naming scheme to MHR.
[ ] Figure out how to convert to .ndjson, this file is otherwise unupdated. I can't figure out how to do this, or what it's even for, so it would be nice if someone else could explain/do it for me.
[ ] Add new monster $oid fields. I don't know what these are or what they're for, so someone else might have to do so.

@Glazelf I have a JS file I use locally to do the .ndjson conversions, do you think this would be valuable to add to the code base? While it runs without the need of any JS packages, I dont want it to feel like you need any specific programming knowledge to use anything in this repo. It might also be worth wondering if we actually need both formats. Originally I only had the .ndjson file, as this was addapted from a mass export of a personal DB I was using, just then later on added the .json format as it is more widely used.
The $oid are for if inserting into a noSQL db (specifically postgress uses this format, another legacy from my originally mass export). I think that technically these would be auto added in most implementations, but for people who want to use this outside an actual DB, these just provide a unique ID value. I also have a local script to check the uniqueness as well which I can commit to the code base. It might also be worth just updating the key to id instead, while still ensuring that each id in a unique value.
Come to think of this, I might have a play around with git pipelines with some of my local script to do things like an id check, or auto generate the ndjson file
Massive thank you for all your work. Have been super busy with my real job lately so havn't been able to devote the time I would like to to this

@Glazelf I have a JS file I use locally to do the .ndjson conversions, do you think this would be valuable to add to the code base? While it runs without the need of any JS packages, I dont want it to feel like you need any specific programming knowledge to use anything in this repo. It might also be worth wondering if we actually need both formats. Originally I only had the .ndjson file, as this was addapted from a mass export of a personal DB I was using, just then later on added the .json format as it is more widely used.
The $oid are for if inserting into a noSQL db (specifically postgress uses this format, another legacy from my originally mass export). I think that technically these would be auto added in most implementations, but for people who want to use this outside an actual DB, these just provide a unique ID value. I also have a local script to check the uniqueness as well which I can commit to the code base. It might also be worth just updating the key to id instead, while still ensuring that each id in a unique value.
Come to think of this, I might have a play around with git pipelines with some of my local script to do things like an id check, or auto generate the ndjson file
Massive thank you for all your work. Have been super busy with my real job lately so havn't been able to devote the time I would like to to this

I don't personally use the ndjson files, I had never heard of them before this repo.
You could share the code or add the ndjson file to the PR if you think it's valueable. A git pipeline sounds useful for this for sure haha, avoids double work.
I think regular IDs would provide a more global value over oIDs, especially if oids are automatically generated I don't see the point of having them hardcoded as well.


Param text rework

For the first release should go through all parameters and make sure the text description is in a good state.

@tumbili I've looked at some key params and their descriptions are mostly good and none are in the default group. Moving this to the 2nd beta release.

Pretty much done by now.


do we need to be able to use skip_checks on specific tables?

We were discussing this in Issue #364. Basically right now we have one table (fuel_receipts_costs_eia923) that we need to use the index to function as the auto-incrementing id column because there are duplicate records. If we could use skip_checks on a specific table we could disable the duplicate-row check and then we could get rid of this special case.
As Zane discussed a bit, I think we would need to be able to embed it into the metadata and it would need to be skipped without any processing while trying to validate the metadata so that anyone trying to use the datapackage could validate the package without needing to see and impement any special cases.
Right now, we have a work around for this, so it is not a high priority, but it would be useful for the future.
@roll @zaneselvans

@cmgosnell
I've created a card on our side for it - https://github.com/frictionlessdata/pilot-catalyst/projects/1?fullscreen=true


Update docs with missing layer props.

Fixe #906 and some other missing props.

@heshan0131 please review the coverage prop text.


Allow for emission of swift.extension symbols for extensions to external types in SymbolGraphGen

This PR introduces a new mode to the Symbol Graph generation that changes how extensions to external types are handled. Since we are explicitly only talking about extensions to external types, all symbols and relationships under consideration live in Symbol Graph Files with names of the form<EMAIL_ADDRESS>Any symbols resulting from such an extension are no longer directly associated with the extended type (which does not exist in the same Symbol Graph File), but with a new kind of symbol, the swift.extension symbol. There is one such symbol for every extension block that extends an external type. This swift.extension symbol is also connected to the symbol of the type it extends via an extensionTo relationship.
These changes are directly related to this discussion about the Symbol Graph Format. This initial pitch motivates the feature and gives more context on why these changes are necessary.
List of changes:

introduction of the swift.extension symbol and extensionTo relationship
adding support for ExtensionDecl to the Symbol class
adding a typeKind field to the symbol's extension mixin which indicates what kind of
symbol was extended
introduction of the -emit-extension-block-symbols flag, which enables the behavior
outlined below
adaptions to SymbolGraphASTWalker that ensure a swift.extension symbol is emitted
for each extension to a type that does not exist in the local symbol graph
adaptions to SymbolGraph and SymbolGraphASTWalker that ensure relationships are
correctly associated with the swift.extension symbol instead of the original type
declaration's (extended nominal's) symbol where applicable
adaptions to SymbolGraphASTWalker that ensure swift.extension symbols are connected
to their respective extended nominal's symbol using an extensionTo relationship

Overall, these changes should ensure that:

documentation frameworks can access the documentation comments on top of extension blocks for extensions to external types
documentation frameworks can reconstruct which members/conformances are associated with a certain extension block (and its documentation)
documentation frameworks can know what kind of type was extended (struct/class/enum/protocol)
legacy documentation frameworks don't observe a breaking change (as all breaking changes are hidden behind the CLI flag)

This PR can be seen as a first step to fixing SR-15410, but more changes to other repositories further up the stack will be necessary.

@swift-ci Please smoke test

I am happy with the changes at this point. Can we rebase this, so that we can run CI?

I am happy with the changes at this point. Can we rebase this, so that we can run CI?

I've been working off of tag swift-DEVELOPMENT-SNAPSHOT-2022-08-30-a recently because checking out main fails for me (it used to work, though):
> utils/update-checkout --scheme main
... omitted some lines here ...
[llvm-project]                          + git checkout stable/20220421
[llvm-project]                          Previous HEAD position was 57827dcce6fa Merge pull request #5224 from akyrtzi/pr/stable/ignore-module-flags-if-not-enabled
[llvm-project]                          Switched to branch 'stable/20220421'
[llvm-project]                          Your branch is up to date with 'origin/stable/20220421'.
[swift-nio-ssl]                         + git submodule update --recursive
[sourcekit-lsp]                         + git submodule update --recursive
[swift-experimental-string-processing]  + git submodule update --recursive
[llvm-project]                          + git fetch --recurse-submodules=yes --tags
[llvm-project]                          + git rebase FETCH_HEAD
[llvm-project]                          Current branch stable/20220421 is up to date.
[llvm-project]                          + git submodule update --recursive
======UPDATE FAILURES======
Traceback (most recent call last):
  File "/Users/themomax/Development/github.com/apple/swift/utils/update-checkout", line 15, in <module>
    update_checkout.main()
  File "/Users/themomax/Development/github.com/apple/swift/utils/update_checkout/update_checkout/update_checkout.py", line 639, in main
    fail_count += check_parallel_results(update_results, "UPDATE")
  File "/Users/themomax/Development/github.com/apple/swift/utils/update_checkout/update_checkout/update_checkout.py", line 70, in check_parallel_results
    print("%s failed (ret=%d): %s" % (r.repo_path, r.ret, r))
AttributeError: 'KeyError' object has no attribute 'repo_path'

@daniel-grumberg I managed to fix the issue on my side and rebased. You can run the CI now!

@swift-ci Please smoke test

Rebased, fixed conflicts, addressed your remaining comments, and squashed again. Thanks for the final review @QuietMisdreavus ! Can you please kick off the CI again?

@swift-ci Please smoke test

@theMomax Thanks so much! As soon as CI is green, i'll merge it.

Apologies for the late comment. Can we also add a new element in lib/Option/features.json? That help build systems know when they have a version of the Swift compiler that supports this new flag so that they don't need to hard code what version numbers support what flags.
It doesn't have to be done in this PR if you prefer to land this now and open a new PR that update features.json.

@d-ronnqvist if you don’t mind, I‘d prefer to update the features.json with my next PR, which will add support for default implementation relationships. Before that, the extension block symbol feature isn’t really „complete“ anyway. I cut that part out of this PR as the change set had become quite large already (on this PR and the accompanying swift-docc PR).

I'll go ahead and merge this, since it's all ready to go and doesn't affect anything unless you add the new flag.


Configured DataSetWriterId ist not applied

If I configure the DataSetWriterId in the publishednodes.json, this is not applied to the publisher DataSetMessage property DataSetWriterId (PubSub format). Same issue for the DataSetWriterGroup. I would assume, that this will be applied to the DataSetWriterGroup of the NetworkMessage.
This is my publishednodes.json configuration:
[
  {
    "EndpointUrl": "opc.tcp://*****:4840",
    "UseSecurity": false,
    "DataSetWriterId": "VRA01OPCUA1",
    "DataSetWriterGroup": "VRA01OPCUA1",
    "OpcNodes": [
      {
        "

These are my container create options of the publisher module:
\"Cmd\":[\"PkiRootPath=./pki\",\"--pf=/appdata/publishednodes.json\",\"--fd=true\",\"--ll=Information\",\"--mm=PubSub\",\"--fm=true\",\"--lf=/appdata/publisher.log\",\"--aa\"]

@Haeavar  which version are you using?

@Haeavar  which version are you using?

@jehona-m we are using the version "mcr.microsoft.com/iotedge/opc-publisher:2.7.199"
As additional info. The pubsub message format looks like following the. Where the DataSetWriterId contains the EndpointUrl from the above configuration (without the port :4840).
{   "body": [     {       "MessageId": "88418",       "MessageType": "ua-data",       "PublisherId": "Standalone_vra01msiot5_publisher",       "DataSetClassId": null,       "Messages": [         {           "DataSetWriterId": "opc.tcp://****_36748ee7ee3c69bd655a162d44638ac18793937d",           "SequenceNumber": 88418,           "MetaDataVersion": {             "MajorVersion": 1,             "MinorVersion": 0           },

@jehona-m we are using the version "mcr.microsoft.com/iotedge/opc-publisher:2.7.199"
As additional info. The pubsub message format looks like following the. Where the DataSetWriterId contains the EndpointUrl from the above configuration (without the port :4840).
{   "body": [     {       "MessageId": "88418",       "MessageType": "ua-data",       "PublisherId": "Standalone_vra01msiot5_publisher",       "DataSetClassId": null,       "Messages": [         {           "DataSetWriterId": "opc.tcp://****_36748ee7ee3c69bd655a162d44638ac18793937d",           "SequenceNumber": 88418,           "MetaDataVersion": {             "MajorVersion": 1,             "MinorVersion": 0           },

@Haeavar the bug has been fixed on the main branch. You can try the preview build 2.8.142-alpha to verify that it is working as expected.

@Haeavar the bug has been fixed on the main branch. You can try the preview build 2.8.142-alpha to verify that it is working as expected.

@koepalex someone has removed all non-tagged versions from https://mcr.microsoft.com/v2/iotedge/opc-publisher/tags/list .
How can I pull the version 2.8.142-alpha?

@koepalex someone has removed all non-tagged versions from https://mcr.microsoft.com/v2/iotedge/opc-publisher/tags/list .
How can I pull the version 2.8.142-alpha?

@Haeavar as you already figured the version was removed from mcr. There will be in the future no pre-releases (from this repository) on mcr anymore. Therefor you need either to build main branch and test it locally or for production wait for the next release (from main branch).

@Haeavar as you already figured the version was removed from mcr. There will be in the future no pre-releases (from this repository) on mcr anymore. Therefor you need either to build main branch and test it locally or for production wait for the next release (from main branch).

Closed due to inactivity, if main version still not working please reopen


Setup workflow for automated deployment

Deploy the build version to Ask Buddie site.

I will do it!


No metadata is present in the term document matrix with Topic Model

Hi,
I am replicating line by line the example with Topic List of words from demo_word_list_topic_model.py .
Here is the error message in python:
Traceback (most recent call last):
  File "demo_word_topic_list_model.py", line 27, in <module>
    html = st.produce_scattertext_explorer(
  File "C:\Users\xxxxxxxx\anaconda3\envs\xxxxxxx\lib\site-packages\scattertext\__init__.py", line 487, in produce_scattertext_explorer
    scatter_chart_explorer.inject_metadata_term_lists(topic_model_term_lists)
  File "C:\Users\xxxxxxxx\anaconda3\envs\xxxxxxxx\lib\site-packages\scattertext\ScatterChart.py", line 104, in inject_metadata_term_lists
    raise TermDocMatrixHasNoMetadataException("No metadata is present in the term document matrix")
scattertext.ScatterChart.TermDocMatrixHasNoMetadataException: No metadata is present in the term document matrix

Your Environment

Operating System: Windows 64 bits
Python Version Used: Python 3.8.5
Scattertext Version Used: scattertext==<IP_ADDRESS>
Environment Information: ???

I'm pushing a new version, <IP_ADDRESS> which should correct this issue. Please update your version and try again.

Works great now, thanks!!


Add cache hit ratio for dataset

Ⅰ. Describe what this PR does
Add cache hit ratio for dataset
Ⅱ. Does this pull request fix one issue?

fixes #526
Ⅲ. List the added test cases (unit test/integration test) if any, please explain if no tests are needed.
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews

Can somebody explain why the cache hit ratio need be print, a little confused.

Can somebody explain why the cache hit ratio need be print, a little confused.

Can somebody explain why the cache hit ratio need be print, a little confused.

The goal is to enhance visibility, and they can get the insight of the dataset if it's suitable for cache, or if the cache capacity is  enough for the dataset.  We need the users to know what actions to take if they can't get benefit from the data cache.

Can somebody explain why the cache hit ratio need be print, a little confused.

The goal is to enhance visibility, and they can get the insight of the dataset if it's suitable for cache, or if the cache capacity is  enough for the dataset.  We need the users to know what actions to take if they can't get benefit from the data cache.


Fix flaky TransactionResponse tests

Post-upgrade I've noticed a sharp increase in CI failures related to the transaction-response-test
FAIL  packages/fuel-gauge/src/transaction-response.test.ts > TransactionResponse > should throw error for a SqueezedOut status update [submitAndAwait]
Error: Passed-in lambda didn't throw.
 ❯ Module.expectToThrowFuelError packages/errors/src/test-utils/safeExec.ts:101:11
     12|
     13|   return { error, result };
     14| };
       |             ^
     15|
 ❯ packages/fuel-gauge/src/transaction-response.test.ts:280:5

After not seeing this issue anymore for a few weeks and doing analysis in #2286, I'm going to close this issue.


ExpansionTile should expose padding for title property

Since it uses a ListTile for the title property, we should be able to customize that ListTile completely

@shihaohong I would like to work on this issue.

Sounds good!

@shihaohong Great, I have submitted a PR. Look forward to reviews :)


Image quality

How can i get exact image quality ?

Hi,
This is a very old project which was built on iOS7 and tested on iPhone 5! Certain dependencies may have changed, this project has not been updated.
You can try modifications for porting this code into the current iOS version, if possible.
I can assure you, it was a fully working code back then (only issue being, it was terribly slow). If you use a similar test image, you should be able to reproduce the exact quality of output.
Unfortunately, I cannot assure any support at the moment.
Regards,
Agniv.


Scalar attention or vector attention in the multi-head variant

It seems that the implementation of the multi-head point transformer produces scalar attention scores for each head.
https://github.com/lucidrains/point-transformer-pytorch/blob/99bc3958138d8c9d3b882e4ac50b1a18a86160fe/point_transformer_pytorch/multihead_point_transformer_pytorch.py#L62

@ZikangZhou https://github.com/lucidrains/point-transformer-pytorch/commit/f9d4e56a26ceee70deb60da230fef40c656396e6 lemme know if that works

@ZikangZhou also would be curious the perf difference between scalar vs vector attention


Revert "fix: remove return null for non image mimeType"

Reverts GraphCMS/gatsby-source-graphcms#215

@all-contributors please add @notrab for code, bug, maintenance, doc

@all-contributors please add @notrab for code, bug, maintenance, doc

@all-contributors please add @notrab for code, bug, maintenance, doc


Fix CI build for Mac using CMake

The CMake build for Mac isn't getting the right C compiler, it seems, because it's complaining about OpenMP.

this has been addressed in the readme


OFFICE EXCEL 只能导出一个SHEET页的数据量

Description
OFFICE EXCEL 只能导出一个SHEET页的数据量，并且名字很奇怪。
以前的版本到达单页上限之后继续在文件中新建SHEET导出。

历史版本是这样的：

DBeaver Version
DBeaver Community <IP_ADDRESS>412170022
Operating System
Windows 11 专业版 24H2
Database and driver
Vertica
JDBC driver for Vertica 12+ Database
DBeaver Office integration  https://dbeaver.io/update/office/latest/
Steps to reproduce
安装DBeaver Office integration - https://dbeaver.io/update/office/latest/ 插件后 查询导出。
Additional context
No response

Please translate your ticket into English.

Please translate your ticket into English.

Excel can only export the data of one sheet, and the name is very strange
Previous versions continued to create a new sheet in the file for export after reaching the single-page limit

Please try the early access version, it should already be fixed there: https://dbeaver.io/files/ea/

Please try the early access version, it should already be fixed there: https://dbeaver.io/files/ea/

Sorry, I am using ea now, but the problem still exists.

After the amount of exported data reaches the upper limit of a single page, the export will continue. But no new sheet page displays data.

Okay, I see.
Please try using Data Export instead. But please ensure the following option is set to 1048575 or lower. This is the maximum number of rows per sheet allowed by Excel:

You can find more information here:
https://github.com/dbeaver/dbeaver/wiki/Data-transfer#export-data

Okay, I see.
Please try using Data Export instead. But please ensure the following option is set to 1048575 or lower. This is the maximum number of rows per sheet allowed by Excel:

You can find more information here: https://github.com/dbeaver/dbeaver/wiki/Data-transfer#export-data
okay thank you
But there are still some problems
The query is normal under certain conditions, but the file name cannot be generated during export. The error is as follows.


run: Add support for fentry, fexit and raw_tracepoint programs

First commit reworks the logic to provide better debug information and error control.

I tested it with the fexit version of trace_open you shared on slack. It works well in the sense that the code was loaded but nothing was printed (I suppose the eBPF code has a problem, but that's OK):

I tried with this program and it worked fine for me.
// SPDX-License-Identifier: GPL-2.0
// Copyright (c) 2019 Facebook
// Copyright (c) 2020 Netflix

#include <vmlinux.h>
#include <bpf/bpf_helpers.h>
#include <bpf/bpf_tracing.h>
#include <bpf/bpf_core_read.h>

#include <gadget/macros.h>
#include <gadget/mntns_filter.h>
#include <gadget/types.h>

#define TASK_RUNNING 0
#define NAME_MAX 255
#define INVALID_UID ((uid_t)-1)

struct event {
	gadget_mntns_id mntns_id;
	gadget_timestamp timestamp;
	/* user terminology for pid: */
	__u32 pid;
	__u32 uid;
	__u32 gid;
	int ret;
	int flags;
	__u16 mode;
	__u8 comm[TASK_COMM_LEN];
	__u8 fname[NAME_MAX];
};

struct {
	__uint(type, BPF_MAP_TYPE_PERF_EVENT_ARRAY);
	__uint(key_size, sizeof(u32));
	__uint(value_size, sizeof(u32));
} events SEC(".maps");

GADGET_TRACER(open, events, event);

SEC("fexit/do_sys_open")
int BPF_PROG(do_sys_open, int dfd, const char *filename, int flags, umode_t mode, long ret) {
	struct event event = {};

	u32 pid = bpf_get_current_pid_tgid();
	u64 uid_gid = bpf_get_current_uid_gid();
	u64 mntns_id = gadget_get_mntns_id();

	if (gadget_should_discard_mntns_id(mntns_id))
		return false;

	/* event data */
	event.pid = bpf_get_current_pid_tgid() >> 32;
	event.uid = (u32)uid_gid;
	event.gid = (u32)(uid_gid >> 32);
	bpf_get_current_comm(&event.comm, sizeof(event.comm));
	bpf_probe_read_user_str(&event.fname, sizeof(event.fname), filename);
	event.flags = flags;
	event.mode = mode;
	event.ret = ret;
	event.mntns_id = mntns_id;
	event.timestamp = bpf_ktime_get_boot_ns();

	bpf_perf_event_output(ctx, &events, BPF_F_CURRENT_CPU, &event,
			      sizeof(event));

	return 0;
}

char LICENSE[] SEC("license") = "GPL";

Perhaps the version I shared on slack was incomplete.

I am approving this PR, but I am wondering if we should not have an eBPF code to showcase this?

More than a use case, I'd say we need tests for it. Opened https://github.com/inspektor-gadget/inspektor-gadget/issues/2301.


Boon Long conversion fails for larger numbers

Some Numbers whose string length is equal to that of Long.Max
in this case it will fail at digit[1]. The digit[1] is greater than 2 (Long.Max[1])
@Test
    public void testBoonConversion () {
        final String aLongNumberAsString = "1520698688883654656";
        final long aLongNumberAsLong = Long.valueOf(aLongNumberAsString);

        Assert.assertTrue("Number is less than long max ", aLongNumberAsLong < Long.MAX_VALUE);
        Assert.assertEquals(" Numbers should match after conversion", aLongNumberAsString, String.valueOf(aLongNumberAsLong));
        Assert.assertTrue("Should be valid a long ", CharScanner.isLong(aLongNumberAsString.toCharArray(), 0, aLongNumberAsString.length()));

    }

I've provided a PR against "advantageous/boon" with the fix. It should be easy to port, code seemed identical to me there.

https://github.com/advantageous/boon/pull/19

Sagar... you are using Advantageous Boon BTW since you are using QBit.

Not sure what it means.
Please clarify

Sagar

On Jun 27, 2016, at 10:08 AM, Richard Hightower<EMAIL_ADDRESS>wrote:
Sagar... you are using Advantageous Boon BTW since you are using QBit.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.

Stephane Landele fixed the qbit boon version. I will do a release with that fix.


Add more links to other projects

e.g. tket

Context please?

This is at the front documentation page.   Documentation revamp should consider this.
@karlunho

I'll pick this up - @karlunho prepared a doc for this

https://quantumai.google/cirq/ecosystem exists now, closing.


Expose 'type-fest' as dependency instead of devDependency

Currently this package makes use of the type-fest package, for example this piece of code uses the PascalCase type from that package. However the dependency of type-fest is set underneath devDependencies while technically this should be underneath dependencies or in the worst case as a peerDependency.
The current situation is problematic for our build (we're using Bazel) we're getting build errors such as:
BUILD.bazel:6:11: in ts_project rule //packages/libs/prismic:tsconfig: target '@npm//type-fest:type-fest' is not visible from target '//packages/libs/prismic:tsconfig'. Check the visibility declaration of the former target if you think the dependency is legitimate

The workaround to get this working is to add type-fest to our package.json as a dependency, however this is a bad practice. (e.g. mismatch in versions)
Therefor my question; Can we move this to dependencies?

Hey @BillyBlaze, thanks for pointing this out. I've moved the type used from type-fest (PascalCase) into the package so we don't need it as a dependency. You can see the change in this PR: #121
This fix will be published in the next release which should come out early next week. I'll post here again once it's published. Thanks!

Hi @angeloashmore, your welcome and thanks for your quick response! Removing the dependency is even a better solution :smile:  I have updated my project and everything is good!


Fixed Set-Cookie header send twice in second and following request

This PR resolves #138
The problem
If we have cookies and sessions enabled in application.rb like:
cookies true
sessions :cookie, secret: 'SECRET'

and we make a first request to one endpoint of our Application we have the following cookie in the response:
Set-Cookie: rack.session=hash; path="/"; HttpOnly;

and the cookie session is set in out browser.
If we make a second request, then the following header in request is sent:
Cookie: rack.session=hash

and the following headers in the response:
Set-Cookie: rack.session=hash; path="/"; HttpOnly;
Set-Cookie: rack.session=hash; path="/"; HttpOnly;

Because the Cookie is sent in the second request and followings we shouldn't get Set-Cookie headers for rack.session.

cc @lotus/core-team

@AlfonsoUceda This works great, thank you :+1:


DRX pipelines show intermittent stalling

This seems to be a feature of running everything on a single server.  It's not clear what is going wrong but it doesn't seem to be related to the TBF buffer.  Could be a (another) problem with RetransmitOp.

I thought packet pacing might help with some of the T-engine packet loss but it doesn't really seem to do anything.

What did seem to change things was moving half the T-engines from verbs to "standard" packet capture.  No idea why that matters.  Maybe some kind of resource limit in verbs or on the cards?  It's still not perfect but it's better.

Since this problem seems to be resolved I'm closing this and moving the T-engine stuff to #30.


[BEAM-11130] Exclude OrderedListState VR tests.

OrderedListState tests fail on Dataflow runner v2. Excluding them for
now until the feature is supported.

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Choose reviewer(s) and mention them in a comment (R: @username).
[ ] Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
[ ] Update CHANGES.md with noteworthy changes.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI.

Run Java Dataflow V2 ValidatesRunner

R: @kennknowles


[AutoRelease] t2-servicebus-2022-08-05-16988(Do not merge)

https://github.com/Azure/sdk-release-request/issues/3059
Live test fail, detailed info is in pipeline log(search keyword FAILED)!!!
https://dev.azure.com/azure-sdk/internal/_build?definitionId=1031
BuildTargetingString
azure-mgmt-servicebus
Skip.CreateApiReview
true

issue link:https://github.com/Azure/sdk-release-request/issues/3059


Small docs edits

@janpaul123 - what do you think of my reorg of the Getting Started page?

Added headers
Changed steps from bullets to numbers
Made as many copy-and-paste-able code snipets into their own lines (because mdbooks make those easier to copy)

Old version:

New version:

That looks awesome!!

Great, will do the same for the whole docs


[gatsby-theme-cara]: Change size/factor of sections

First of all, thanks for the open source project. I would like to share some issues with the theme.
When you add long texts in Hero, Projects and About section, the page doesn't have a good responsiveness behaviour, It will be great to achieve this.
When you see the theme in a phone in landscape mode, the text overlaps for all parts.
Kind regards

When you add long texts in Hero, Projects and About section, the page doesn't have a good responsiveness behaviour, It will be great to achieve this.

Fixed in: https://github.com/LekoArts/gatsby-themes/commit/e893a9b60911f475017931ecd9841321cb3d4fa8
You now can change the factor of each section. The prop refers to react-spring's prop:
https://www.react-spring.io/docs/props/parallax
This means that if you shadow src/templates/cara.tsx with these contents:
import React from "react"
import { Parallax } from "react-spring/renderprops-addons.cjs"
import Layout from "@lekoarts/gatsby-theme-cara/src/components/layout"
import Hero from "@lekoarts/gatsby-theme-cara/src/components/hero"
import Projects from "@lekoarts/gatsby-theme-cara/src/components/projects"
import About from "@lekoarts/gatsby-theme-cara/src/components/about"
import Contact from "@lekoarts/gatsby-theme-cara/src/components/contact"

const Cara = () => (
  <Layout>
    <Parallax pages={5}>
      <Hero offset={0} factor={1} />
      <Projects offset={1} factor={2} />
      <About offset={3} factor={1} />
      <Contact offset={4} factor={1} />
    </Parallax>
  </Layout>
)

export default Cara

You can change the factor of each page instead of shadowing each section.

When you see the theme in a phone in landscape mode, the text overlaps for all parts.

Unfortunately that's not something I want to fix.

I put the cara.tsx file in the templates directory and made some changes to the factors but I don't see any changes happen when I save the file.


Using Xml Comments along with Operation Filters in the correct order

I just came across this one today, we are using 'IncludeXmlComments' to pull in details from our code and then updating certain portions dynamically via Operation Filters.
In the sample config that is provided the 'IncludeXmlComments' call is after the add custom Operation Filters sample, which will basically over write any modifications that you may have made via your operation filters if the same info is in the xml comments.
Hope that makes sense. Just thought a change to the default ordering in the sample or a note about usage may be required. Or there may already be something there and I haven't seen it?

See v5.2.2


Slayer Target Respawn Timer

Is your feature request related to a problem? Please describe.
Recent implementation of respawn timer for NPC Indicator is very nice. But I mostly use it for slayer task. However this is not implemented yet.
Describe the solution you'd like
Add the respawn timer for slayer targets also.
Describe alternatives you've considered
Been typing in slayer monster into NPCs to Highlight option to get the respawn timer.

osbuddy has an option to add an option to the right click context menu above mobs "Tag"
https://user-images.githubusercontent.com/30416150/28856118-13e4f5c0-770f-11e7-9821-d4e47f3e2d69.png
Having this as an opt-in mechanism would allow npcs to be easily tagged (either tag + tag all or just tag being tag all, similar to how typing in a monster will highlight it for all types)


New Icon

@amka, hey there, would you like a new icon for the app? I can design one that follows the human interface guidelines of elementary.
Great app btw, very useful. Cheers!!

@Suzie97 Sure! I'm so bad at designing icons :) It will be really cool if can make it!

Cool, I'll make a PR in a soon.

@amka I made a PR with the icons, lemme know if you like them or you want changes.

@Suzie97 I'm sorry for such a long delay. Thank you for your submission, it looks great! One thought that bothers me is that I have a few more applications like Norka and Turtle and I like the style of the icons.
May I ask you to try to implement all icons in one style? Just to clarify for the end-user these apps is made by TenderOwl?

@Suzie97 I'm sorry for such a long delay. Thank you for your submission, it looks great! One thought that bothers me is that I have a few more applications like Norka and Turtle and I like the style of the icons.
May I ask you to try to implement all icons in one style? Just to clarify for the end-user these apps is made by TenderOwl?

Do you mean that I do the other icons in the style of Frog? i.e. just using animal faces similar to frog? I can do that.

@Suzie97 I mean could you create icons for the other apps too?

@Suzie97 I mean could you create icons for the other apps too?

yeah sure. You want them in the style of my frog icon right?

Maybe not so smiling :) Smiling mink looks funny, but I'd prefer thinking of Norka like a tool for a job, not for joy.

Great. I'll make PRs in the next few weeks. Do you want any changes to the frog icon or are you ready to merge?

Great. I'll make PRs in the next few weeks. Do you want any changes to the frog icon or are you ready to merge?

Ah, not sure actually. I like its funny style :) Just wanna it to be in a single idea as the new icons. So if you find a way to make a consistent style - so let it be just as is.

Closed due to inactivity.


Bug(Binder): should not allow to refer the oringinal schema name + table alias

Describe the bug
Users can refer table with the table's original schema name and table alias, which is illegal in PG and other DB system.
To Reproduce
dev=> create schema s;
CREATE_SCHEMA
dev=> create schema ^C
dev=> create table s.t(v int);
CREATE_TABLE
dev=> select s.tt.v from s.t tt;
 v
---
(0 rows)

Expected behavior
in PG:
dev=# create schema s;
CREATE SCHEMA
dev=# create table s.t(v int);
CREATE TABLE
dev=# select s.tt.v from s.t tt;
ERROR:  invalid reference to FROM-clause entry for table "tt"
LINE 1: select s.tt.v from s.t tt;
               ^
HINT:  There is an entry for table "tt", but it cannot be referenced from this part of the query.

Additional context

please open test in e2e_test/batch/duckdb/select/test_multi_column_reference.slt.part when the issue is closed

Any update?


Add indexPatterns to map embeddable output for dashboard filters

Description
In dashboard global filter bar component, it need read indexPatterns information from maps embeddable output to correctly show the maps data layers indexPattern.
Consuming ref: https://github.com/opensearch-project/OpenSearch-Dashboards/blob/main/src/plugins/dashboard/public/application/dashboard_app_controller.tsx#L292

Issues Resolved
https://github.com/opensearch-project/dashboards-maps/issues/214
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Codecov Report

Merging #272 (a465764) into main (f3d21b9) will not change coverage.
The diff coverage is n/a.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
@@           Coverage Diff           @@
##             main     #272   +/-   ##
=======================================
  Coverage   91.79%   91.79%
=======================================
  Files          10       10
  Lines         268      268
  Branches       34       34
=======================================
  Hits          246      246
  Misses         16       16
  Partials        6        6

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


Site messed up with recent HEAD

https://pjs-web.de/
I addressed all the changes in https://sourcethemes.com/academic/updates/v2.4.0/
Site source: https://github.com/rbind/pat-s_web
git submodule
+99e0edf9bb63dbdea003a255cb7a3a2ff4f80e1b themes/academic (v2.4.0-16-g99e0edf)

Is this related to the recent change to Bootstrap 4?
Inspecting the errors I don't see what could potentially be wrong.
Is is an issue on my side or a theme issue?
Building with HUGO v0.48

You are overriding Academic with your own files such as header.html and CSS. Removing your overrides or updating them based on the new versions of these files would help. Please use the support forums if you need further support. Thanks.

@gcushen Completely forgot about the custom header.html. I am very sorry stealing your time with this issue!


Initial AA Sidecar Docs.

🚀 Deployed on https://66bfdd02832d57c361f4898a--cozy-fox-0defec.netlify.app


1.9 regression failing in groupBy

Hi folks, I couldn't find an issue containing the groupBy function. So I'm creating one. Please redirect if I missed anything. Thanks for all the hard work. Appreciate it!
When updating from version 1.8.3 to 1.9.0 the behaviour of groupBy changed in a way that grouping by arrays was possible in 1.8.3, but it's not possible in 1.9.0. At least not as I'm expecting it to work 🤔
The below test would succeed in 1.8.3 where it throws an exception in 1.9.0. Am I doing something wrong?
var anArray = [1,2];
var list = [{
	arrayProp: anArray,
	otherProp: 1
}, {
	arrayProp: anArray,
	otherProp: 2
}];

var res = _.groupBy(list, 'arrayProp');
// var res = _.groupBy(list, function(element) {
//  	// stringified version of key is equal and gets grouped
//  	return JSON.stringify(element.arrayProp);
// });
var groupByKey = Object.keys(res)[0];
console.log(Object.keys(res).length) // 1
console.log(groupByKey); // 1,2

var expected = 2
var actual = res[groupByKey].length;
if (actual !== expected) {
	throw new Error("TEST FAILURE. EXPECTED " + 2 + ". GOT " + actual)
}

-> Uncaught Error: TEST FAILURE. EXPECTED 2. GOT 1

Thanks for reporting this. I think we need to switch to a simpler version of _.has for our internal use. In most of our six internal cases, we don't actually want the special behavior for Arrays (deep property access).
I think we probably do need to support the case where someone wants to group by (or count by) a key that is not a string, but could be coerced to a string.
I'll look into making a PR in the next few days. In the mean time, you could do something like this, which would be a bit more explicit:
var res = _.groupBy(list, val => String(val.arrayProp));

thanks @captbaritone . This should work but I don't want to change my code right now. I'm not super eager to use 1.9 and can wait a bit more.

This will be fixed in the next release.


shift-space produces escape sequence in terminal

Steps to reproduce

start macvim gui
enter :term<enter> to start terminal mode
enter od -c<enter> to start octal dump
enter -space followed by  followed by -D to end input
observe output

% od -c
^[[32;2u
0000000 033   [   3   2   ;   2   u  \n
0000010

Expected behaviour
I expect shift-space to produce a space character, 020
% od -t x1

0000000 20 0a
0000002

Version of Vim
VIM - Vi IMproved 8.2 (2019 Dec 12, compiled Sep 24 2021 14:13:28) Included patches: 1-3455
Environment
OS: MacOS 10.15.7 and 12.0.1
terminal: MacVim 8.2.3455
TERM: xterm
shell: GNU bash, version 5.1.12(1)-release (x86_64-apple-darwin21.1.0)
FWIW I tried a vanilla env without .bashrc .bash_profile and .vimrc with same result
Logs and stack traces
No response

@smolin thank you. for an issue
Could you please to try this in Vim in terminal (with no GUI) and vanilla vim, like /usr/bin/vim?

@eirnym Thanks for getting back to me. I tested just now with /usr/bin/vim and /Applications/MacVim.app/Contents/MacOS/Vim and both result in the expected behavior -  results in char 020 AKA
Thanks! I love MacVim by the way, otherwise it's the bee's knees.

See also https://github.com/vim/vim/issues/6040.
@smolin - this issue is fascinating and it definitely nerd sniped me.  It's easily reproducible but I don't have enough arcane knowledge about terminal emulators to be totally sure that it's a bug in MacVim or even in Vim for that matter.
With iTerm 2 it's possible to make the issue happen or not happen at will with just /usr/bin/vim.  By default, Shift+Space in a :term terminal results in a space being inserted.  However, with Report modifiers using CSI u enabled, Shift+Space in a bash prompt in a :term terminal gives a ^[[32;2u.  It also results in a ^[[32;2u in the regular shell with no vim involved at all.
The Fish shell (which doesn't use readline) supports CSI u as well; see this example of binding Shift-Space.  Running that bind at a fish prompt inside a :term terminal results in a regular space character being inserted.
The Bash shell does not currently support CSI u as a result of its use of readline.  From the second email on this thread from 18 April 2022 on the bug-readline list, support for CSI u isn't currently a priority:

I think I'll wait until more terminal emulators support this.

Vim appears to be sending reasonable CSI u codes to its subprocesses, though I can't find any explicit mention of CSI u support in https://github.com/vim/vim discussions.
From https://github.com/vim/vim/issues/6040#issuecomment-827176487:

As a workaround you can remap Shift-Space:
tnoremap <S-space> <space>

This mapping will break apps that expect to receive Shift-Space!

For example, the Shift+Space mapping that works in vim inside a vim terminal won't work.
Hope this helps clarify things even if it doesn't fix the issue.  This might go away entirely as more applications start supporting CSI u.

As it's Vim core issue, it's better to discuss it there and when comment here when it's resolved

Thank you @mplough for linking the base issue


IOS- iphone and ipad MS Teams App Adaptive Cards not loading

iOS
Hi Team,
We are using v4 bot framework SDK and rendering adaptive cards on MS teams channel. It is working fine in Desktop and Android but not on IOS. Upgraded to 1.2.3 for the adaptive cards nuget package in the SDK and device details are as below.

iphone 6
version - 12.4.5
ms teams app version - 2.0.2

ipad mini
version - 12.4.5
ms teams app version -2.0.2
CreateCase.txt

Behavior is app is getting crashed when bot is trying to render the card. PFA for reference of the payload. Kindly please check and comment as this is a road block for all the features in the Bot.

Hi Team,
Could you please help responding to the above ?

Thanks for reporting this @RajaniJillaGit . @VikrantSingh01 what version of AC is being used here in the repro would you know (they are using msteams version 2.0.2) ? Meanwhile, @almedina-ms are you able to help test the attached payload out on the latest nightly release of our Visualizer test app please to see if the crash that is being reported here repro's for just the raw AC renderer stack? thanks. @nesalang  FYI.

@shalinijoshi19 ,
Crash happened with the payload because of '*'.
This was fixed by #3779, confirmed it worked on 1.2.7 branch (jwoo/rel/1.2).

Hi Team,
Do we need to upgrade the nuget package ? Please confirm necessary steps to be taken.

Hi @RajaniJillaGit our fix would be absorbed by the Teams iOS app and once that's done your scenario should just work once you get the fixed version id the Teams ios app. We're slated to publish our iOS updates eow this week, and Teams will follow suit later in the next few weeks.. @VikrantSingh01 for fyi/ comment as well. Please stay tuned and thanks for your patience!

@nesalang did this ship with AdaptiveCards v1.2.7 last week? I dont see this tagged right if it did? @VikrantSingh01 on the timeline for absorbing 1.2.7 on the Teams app side at their end..

@nesalang did this ship with AdaptiveCards v1.2.7 last week? I dont see this tagged right if it did? @VikrantSingh01 on the timeline for absorbing 1.2.7 on the Teams app side at their end..

@shalinijoshi19 Yes, this is shipped. This issue was dupe of #3776, and the fix for #3776 was shipped as part of 1.2.7

Ok so this should have been resolved as such. @RajaniJillaGit FYI that this issue is a #duplicate of #3766 shipped as part of AC 1.2.7, currently in testing by the Teams iOS team. There should be no nuget package update needed at your end for this issue specifically since it's the Teams host app that will need to consume the latest AC cocoapod framework package. @VikrantSingh01 what is the recommended update channel here that we can point folks to for Teams updates esp wrt AdaptiveCards intake?

@shalinijoshi19 Kindly please suggest the version to upgrade the teams app ?

@RajaniJillaGit a representative from Microsoft will be reaching out to you with workaround details here while Teams works on upgrading to 1.2.7 in the next month. (it's not ready or released for you to be picked up); Meanwhile also attaching the proposed workaround from @nesalang here:

Instead of using the plain wildcard character (*) in your inline textrun's for the RichTextBlock, can you try using ***** (escaped markdown sequence for bold? ) or italics instead?

@shalinijoshi19 is the update (1.2.7) given for MsTeams ?

Hi,
I'm using version 2.0.9, and it's still not working on IOS.
Tks.

@Subhasish-msft/@shalinijoshi19 , with V2.0.9 teams update this is working for iPhone 10 but with same update it is not working for iPhone 6
can you tell me for which all iPhone version it will support???


Automatically switching dictionaries based on keyboard layout language

Is your feature request related to a problem? If so, please describe.
Currently, ZipChord keeps working and with the same dictionaries even if I switch my keyboard layout to a language other than English. This causes issues when trying to type something in a different language because ZipChord keeps functioning with the English dictionaries.
Describe the solution or functionality you'd like
Add the ability to either pause ZipChord when using a non-English keyboard layout, or add the ability to switch dictionaries on/off based on currently working language.
Additional context
In my example, I'm using a standard English (US) layout, switching to a standard Russian keyboard layout.

Thank you for the suggestion! I'll add it to my roadmap. Eventually, I'm planning on supporting switching dictionaries and ZipChord keyboard and language settings automatically with Windows keyboard layout changes. (Things have been busy with my new job.) In the meantime, a workaround is to use the configurable keyboard shortcut to Pause/Resume ZipChord (https://github.com/psoukie/zipchord/wiki/Application-Keyboard-Shortcuts-window)


Error when compiling

Traceback (most recent call last):
File "/home/y2kbug/.arduino15/packages/esp32/tools/esptool_py/3.0.0/esptool.py", line 38, in
import serial
ModuleNotFoundError: No module named 'serial'
exit status 1
Error compiling for board NodeMCU-32S.

What exactly solved this? I'm trying to figure it out.

What exactly solved this? I'm trying to figure it out.

I have forgotten. Please try:
pip3 install pyserial

I solved my issue (might have been different than yours): https://randomnerdtutorials.com/solved-failed-to-connect-to-esp32-timed-out-waiting-for-packet-header/
Basically, it was throwing tons of errors, but the important was that I either needed to hold the boot button down or connect a capacitor between the gnd and en pins to allow it to receive data properly.


fix: revert version of zap

What this PR does:
Which issue(s) this PR fixes:

Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?:

Codecov Report

Merging #53 (cd90e0e) into develop (091113c) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop      #53   +/-   ##
========================================
  Coverage    54.92%   54.92%
========================================
  Files            1        1
  Lines           71       71
========================================
  Hits            39       39
  Misses          32       32

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


Update Griffin to the current devel and fix an input accordingly

As title.

@YaqiWang you can do refs #000 for a submodule update

oh

Job VTB Documentation on 375f782 wanted to post the following:
View the site here
This comment will be updated on new commits.

I m ok with merging this but we can expect failures in direwolf and bluecrab on something like this btw

Looks like CIVET will push Griffin master into bluecrab automatically but not direwolf. Or maybe we treat direwolf same as failed but allowed for now?

well except here we d need Griffin devel to be used in direwolf as well, then this test can pass.

Yes. If we do auto update in direwolf, it will be good. I actually thought we possibly had it before.

It wont, it needs to be a devel version of Griffin that gets pulled, not the master.
This is why the blue crab recipe is failing.
I think the current process would be to update the submodules in blue crab and dire wolf to Griffin devel, then they can pass here.

If both are failed and allowed, then Griffin can move things from devel to master and be able to update bluecrab. If we do that for direwolf, it can update direwolf as well. This is one of the example I was talking: https://moosebuild.hpc.inl.gov/job/393031/.

Or we make VTB as failed but allowed, then once things reach Griffin master and all depending apps master, we can just update submodules for VTB. What do you think?

The problem with that is that we can't trust most people to not merge things that break VTB :-)

I am having headache again on this... I do not have access to direwolf anyway. We do not have auto submodule update for VTB, right?

Yeah it really depends on who we want to give the job of updating those two. I'm fine with allowed to fail in VTB for these two, then automatic submodule updates take care of making it pass between VTB devel and VTB main

no automatic submodule update in VTB yet yes, but it is coming

Can we let VTB direwolf use VTB griffin? In this way, the test will pass.

I dont know how to do that apart from making a PR to direwolf.
I m merging on failing as this will self-resolve for blue crab, and resolve when I make a PR for direwolf

@GiudGiud or @loganharbour Why we are still seeing this https://moosebuild.hpc.inl.gov/job/393516/? Maybe this MR has not made its way into the master branch?

@GiudGiud or @loganharbour Why we are still seeing this https://moosebuild.hpc.inl.gov/job/393516/? Maybe this MR has not made its way into the master branch?

Guillaume explained this above:

It wont, it needs to be a devel version of Griffin that gets pulled, not the master.
This is why the blue crab recipe is failing.
I think the current process would be to update the submodules in blue crab and dire wolf to Griffin devel, then they can pass here.

you can see on civet.inl.gov that devel is failing.

That test (I invalidated half hour ago) is still testing against old VTB. With this change, I've updated the failing input and we should not see the error.

this MR is not making it into master because direwolf is failing. We need to update the recipe to allow to fail on dire wolf
OR update griffin submodule in dire wolf

That test (I invalidated half hour ago) is still testing against old VTB.

https://civet.inl.gov/branch/13349/ you can see devel here..


spanner: how should transactional promises look?

Originally posted by @callmehiphop
@vkedia @stephenplusplus @lukesneeringer @jgeewax so our typical callback vs. promise convention is pretty simple - omit the callback and you shall receive a promise. I think this is the first API that really complicates this approach.
Consider the following example
database.runTransaction()
  .then(transaction => {
    return Promise.all([
      transaction,
      transaction.getRows('Singers')
    ]);
  })
  .then([transaction, rows] => {
    // do some kind of mutation based on the rows
    return transaction.commit();
  })
  .then(() => {
    // do something async/unrelated to the transaction
  });

My main issue is that in order to properly retry our transaction here, we would need to capture all functions passed to the promise before transaction.commit() and retry them in the correct order before allowing any chaining that occurs after to continue. Technically I don't think this is even feasible, but even if it were I think the overall behavior itself is totally unpredictable for our users. Based on this opinion, I think that our traditional approach will not fly here.
That being said, if we were to continue to try and let both callbacks and promises live together within a single method, we need a different way of letting the user tell us that they want promises.
My current suggestion is to let the user return a promise within the callback (like so)
database.runTransaction((err, transaction) => {
  if (err) return Promise.reject(err);

  // do some transactional based stuff
  return transaction.commit();
})
.then(() => {
  // transaction is committed, so some other stuff now
});

However after some discussion in my PR, this also may be confusing for the users. So I would like to revisit this specific API since we don't have a precedent for this specific issue.
An idea that we've been kicking around would basically be to not directly support promises in and out of this method, but only in.. This means the code would resemble the following
database.runTransaction((err, transaction) => {
  if (err) {
    // an error occurred while trying to get/create a session + transaction
  }

  // do reads/writes/etc. here

  // now the user has a choice between using a promise or a callback
  // and while this function will be ran multiple times in the event of an aborted error
  // commit will not resolve until either a success or final error occurs
  transaction.commit()
    .then(() => console.log('committed successfully!'))
    .catch((err) => console.error(err));
});

At which point if a user doesn't feel that this is the way they want to use Promises, it would be fairly easy to wrap that into something like
function runTransactions() {
  return new Promise((resolve, reject) => {
    database.runTransaction((err, transaction) => {
      if (err) return reject(err);
      // do transaction stuff
      transaction.commit().then(resolve, reject);
    });
  });
}

A quick "A or B" is:
// A)
datastore
  .runTransaction(function(err, transaction) {
    if (err) {
      // Could not start transaction
      return Promise.reject(err)
    }

    // ...transaction stuff...
    return transaction.commit()
  })
  .then(success)
  .then(doSomethingElse)
  .catch(handleErrors)

// B)
datastore.runTransaction(function(err, tranaction) {
  if (err) {
    // Could not start transaction
  }

  // ...transaction stuff...
  transaction.commit()
    .then(success)
    .then(doSomethingElse)
    .catch(handleErrors)
})

Gist: https://gist.github.com/stephenplusplus/3cb49529ee537c640a4670edf900e294

I am opposed to the current solution being discussed.
A question for @vkedia:

If you have a series of transaction.doSomething calls that succeed, and then transaction.commit fails with a retryable error, why not just retry transaction.commit? Does Spanner auto-rollback the transaction if a commit call returns 503, for example? These are separate GRPC calls; from the client perspective, a failed commit call should not necessitate retrying every previous call in the transaction.

A comment:

An uncommitted transaction is just a batch. It is totally valid to have methods like insert and update all save to a list of calls on the transaction so that they can be replayed in a retry situation. The transaction object is being passed down the Promise, and it is fine for it to maintain state.

@lukesneeringer There are two levels of retries here. In case of a retryable error like UNAVAILABLE, gapic would take care of retries and it would retry just the commit call. The retry we are discussing is when commit fails with ABORTED which usually means that there was some other conflicting transaction but there might be other reasons for that. In that case the correct thing to do is to create a new transaction again and do all the operations on that new transactions again. If you just replay the commit, it would again fail with ABORTED.
This page talks more about this:
https://cloud.google.com/spanner/docs/transactions#rw_transaction_interface

Thanks, that answers my question. So, the correct solution becomes to save the operations that were made on the transaction and replay them.

Yes, and we also have to replay arbitrary user code that may have been executed before, after, and in-between the calls to our API, e.g. reading a file from disk, making a remote request, querying Datastore, etc. That's why I'm drawn towards design B, which creates a sandbox that a transaction lives in. Our docs can explain that everything inside of it has the chance of being re-run completely.
I also think it's less prone to user error. They won't have to remember to return a promise from the runTransaction callback, which is a pattern that you might have to think about twice before understanding. It also creates the awkward dual-handling of an error-- first, in the runTransaction callback, then in the catch block.
I dislike B because the user cannot easily connect datastore.runTransaction() into another promise pipeline. However, given the sandbox philosophy of a transaction, I think this is acceptable for the benefits of less potential for confusion seen in A.

Something that @vkedia has asked about a few times is why we make the user manually call commit and I think that by abstracting that away, we might be able to solve this. In an earlier version of Datastore we never used to make the user call commit directly, instead we had them pass in multiple callbacks, one of which we supplied a done function to let us know that the transaction was finished.
Pretending we took a similar approach here, here's how our callback version would look
database.runTransaction((transaction, done) => {
  transaction.run('SELECT * FROM Singers', (err, rows) => {
    if (err) {
      done(err);
      return;
    }

    transaction.insert('Singers', { ... });
    done();
  });
}, (err) => {
  // the transaction is finished
});

The introduction of the second callback would mean we can now use the same mechanism to guess whether or not the user wants a Promise as everywhere else in the library.
database.runTransaction((transaction) => {
  return transaction.run('SELECT * FROM Singers').then([rows, resp] => {
    transaction.insert('Singers', {});
  });
}).then(() => {
  // the transaction is finished
});

I think the downside here is that we still have to pass in a callback that returns a promise, but I don't think there's any avoiding that due to the retry requirement for aborted transactions.
Thoughts?

I think the downside here is that we still have to pass in a callback that returns a promise, but I don't think there's any avoiding that due to the retry requirement for aborted transactions.

Doesn't B avoid this? The user wouldn't have to return the promise, they would just use whatever pattern they wanted (promise or not) inside the sandbox.
Taking away the commit() action makes it more confusing to me, since then the user is returning a transaction.run() to the runTransaction() callback and handling the hidden commit() outside of runTransaction().
Just to re-state, users did not like when we had a done() for Datastore transactions. Related:

http://stackoverflow.com/questions/34320065/gcloud-datastore-transaction-issue-using-nodejs
http://stackoverflow.com/questions/36653881/capture-err-in-gcloud-node-transaction

Doesn't B avoid this? The user wouldn't have to return the promise, they would just use whatever pattern they wanted (promise or not) inside the sandbox.

Sorry, what I meant was that there is no avoiding providing a callback (not the returning the promise part)

Taking away the commit() action makes it more confusing to me, since then the user is returning a transaction.run() to the runTransaction() callback..

That's a fair point, but it seems like maybe coming up with a better name for runTransaction could cut back on confusion here

..and handling the hidden commit() outside of runTransaction().

I think you're not really handling commit per se, but when the transaction is finished in general - like if an error were to occur at any time during or if everything went fine. To me this is very reminiscent of async.

Just to re-state, users did not like when we had a done() for Datastore transactions.

That is definitely something to consider but I think given the current options for our problem, if we end up supporting a promise mode for this, there will likely be some aspect of it the users don't like and/or find confusing.

Yes, and we also have to replay arbitrary user code that may have been executed before, after, and in-between the calls to our API

Do we? What if we only replayed the SQL, regardless of how that SQL came to be?
That is less powerful than replaying arbitrary user code, and there are reasons to consider against doing it, but it is a far easier solution.
That said, we can replay arbitrary code too, as long as the code is passed as a function. That actually more or less becomes the "atomic transaction" code I originally posted.
(Editor's note: I do not have throughput to follow this thread right now, but it is critically important. Keep discussing it, but please do not make any final decisions without a meeting. Thanks.)

So, the question here is which of these two is going to be the bigger gripe for our users:

breaking the idiomaticity of our sample code by using callbacks (as @vkedia proposed in #334)
forcing users who want to use dynamic queries to use static ones (as @lukesneeringer suggested)

Personally, I think that someone will be unhappy regardless of which one we choose. I'm leaning slightly towards @vkedia's proposal, but I'm not sold on anything yet.

What if we passed in a function, and then the entire function could just be re-run?

@lukesneeringer So how is that different from the current callback based API? Are you saying that the passed in function would return a Promise?

I'm merging @vkedia's linked PR to our samples repo now, as it fixes #2118 (which is arguably a more urgent issue) - but please do continue discussing this. :smile:

Maybe it is not different. Sorry, I derped.

@callmehiphop please correct me if I'm wrong, but as far as how these methods technically behave, I believe we have that part working-- with the exception of a bug that didn't include the transaction ID on the outgoing API requests. With that fixed, we handle the retry logic correctly.
This conversation is to help us find the most obvious API for the user who wants to use promises for transactions. Flip back to the A or B post: https://github.com/GoogleCloudPlatform/google-cloud-node/issues/2152#issuecomment-290074963 -- A is what we previously had, until we removed it, and B is a refactor.

@stephenplusplus that is correct!

Unless we hear other opinions, I think it's up to us, @callmehiphop! From a code-only standpoint (not factoring in anything other than the UX of the API), which one would you like to move forward with, A or B?

@stephenplusplus going to go with B on this one - essentially we just won't support Promises on this method and if the user wants to use them they'd have to wrap it themselves.

I discussed this with @vkedia and @jgeewax a few weeks ago. The problem with removing promises from certain methods (IIUC, runTransaction() and the streaming methods) is that users might use a third-party promises implementation like Bluebird, thus re-introducing the problem we want to avoid. A more robust solution would be to return promises for these methods (if the user does not provide a callback), but don't automatically retry ABORTED transactions in a promise.
What do you think @stephenplusplus, @callmehiphop, and @swcloud?

@bjwatson I think not retrying for promises makes sense to me. As it is runTransaction will retry all the things and we can create a new public method like getTransaction or beginTransaction etc. that does not have that logic baked in and can be used via promises.

@callmehiphop SGTM. As long as we provide some kind of promise mechanism for that method, then users are unlikely to seek out their own.


Adding gesture recogniser to backgroundView

New issue checklist

[X] I have reviewed the README and documentation
[X] I have searched existing issues and this is not a duplicate

General information

IGListKit version: 3.0.0
iOS version(s): 10.3
CocoaPods/Carthage version: 1.3.1
Xcode version: 8.3.3
Devices/Simulators affected: iPad
Reproducible in the demo project? (Yes/No): WIP
Related issues: None

Debug information
If you add a gesture recogniser to a UIView or anything else it appears that IGListKit doesn't revert to the background view when doing something performUpdates, [], performUpdates for some reason in between the background view get's nil (emptyView?) but sometimes it doesn't.
# Please include debug logs using the following lldb command:
po [IGListDebugger dump]

it appears that IGListKit doesn't revert to the background view when doing something performUpdates

I do not understand this sentence...
Have you tried adding a gesture recognizer to an example project to reproduce this? Could you share such a project?

Ya not sure I follow what is wrong here. Are you talking about the backgroundView API on UICollectionView? If so, that gets consumed by our emptyView API on the IGListAdapterDataSource. If you use the empty view, you can add gestures to that.

Whoops, sorry, I wasn't aware I already posted repo 😅
Yes, a search is happening in a search bar and I would like to be able to dismiss the keyboard by tapping on the UICollectionView so I added the tap gesture recogniser to the backgroundView.
E.g. I created my own UIView assigned to my UICollectionView and then when I change the data source through ListAdapter my backgroundView appears to get lost.  Currently fixed it by doing the following in performUpdates completion handler.
if self.collectionView.backgroundView != self.contentBackgroundView {
    self.collectionView.backgroundView = self.contentBackgroundView
}

I would try to make the issue appear in the example app.

Oh ya, the background view is going to be overwritten/replaced and hidden/displayed based on whether or not there is content. Can you just add the tap gesture to the collection view itself?

Actually, I can't reproduce it anymore when I tried to make an example app. Earlier I had to the feeling that my backgroundView I assigned to my CV got nullified or a. new one got created but looks like it doesn't seem to be case. Or maybe the behaviour differ in other versions of iOS 🤔


ncu-team: list organizations members

It may be useful to add the possibility to list organizations members instead of only team members.
What do you think?

I don't think node core would need to list all of the members in node org. + if we think of fetching ~500 people i could take bit longer.
That being said i'd like to hear what other have to say on this.

I don't think this would benefit anyone, I am not even sure whether being a member of the org implies anything (?).

Well...we do have the members team although not every member of the org is in it, but it's close.

I think the question is answered so this could be closed? Please reopen if required.


Update logging_interceptor.rb

use block syntax to compute logs only when meant to be logged

updated from master

updated again


chore(main): release 1.8.2

:robot: I have created a release beep boop
1.8.2 (2024-06-08)
Bug Fixes

github脚本添加flutter环境 (6a1a7c3)
pub publish必须要求example，回退名称 (b83e0c5)

This PR was generated with Release Please. See documentation.

:robot: Release is at https://github.com/luoyi58624/luoyi_dart_base/releases/tag/v1.8.2 :sunflower:


Add content: How to commit code to a Git repository with VS Code

Type of change
Add new content
What should this PR do?

Add content: DEVED-141
Add screenshots with captions in the form of <figure> and <figcaption> tags.
Add a small CSS addition to center the screenshots and their captions, and to display the smaller screenshots at 75% width instead of full width.

What are the acceptance criteria?

Front-matter is correct and complete
Markdown formatting is rendering correctly
All screenshots load correctly
All links are working
The header image displays correctly in the page
The content's card in the index displays correctly

How should this PR be tested?

Open the link to the new content in the deploy preview: https://deploy-preview-199--sourcegraph-learn.netlify.app/how-to-commit-code-to-a-git-repository-with-visual-studio-code

Pull request process
Reviewers:

Test functionality using the criteria above.
Offer tips for efficiency, feedback on best practices, and possible alternative approaches and things that may not have been considered.
For shorter, "quick" PRs, use your best judgement on #2.
Use a collaborative approach and provide resources and/or context where appropriate.
Provide screenshots/grabs where appropriate to show findings during review.

Reviewees:

Prefer incremental and appropriately-scoped changes.
Leave a comment on things you want explicit feedback on.
Respond clearly to comments and questions.

Merging in main branch to look at the date, etc. on deploy preview

Thanks for spotting that step numbering issue!


Remove unnessesary try-catch block.

This removes the not needed try-catch block that tried to initialize an RsaSigner and caught any exception that would have been thrown.

@ihrigb Please sign the Contributor License Agreement!
Click here to manually synchronize the status of this Pull Request.
See the FAQ for frequently asked questions.

@ihrigb Thank you for signing the Contributor License Agreement!