Specify the domain of decommission variables

Pull request details
Describe the changes made in this pull request
List of related issues or pull requests
Closes #828
Collaboration confirmation
As a contributor I confirm

[ ] I read and followed the instructions in README.dev.md
[ ] The documentation is up to date with the changes introduced in this Pull Request (or NA)
[ ] Tests are passing
[ ] Lint is passing

@abelsiqueira @datejada It is more or less straightforward to do this for the decommission variable of the compact method, so I did this before the refactor.
The simple method is a bit more complex because it is indexed differently, i.e., not using an indice set yet, but it will be the same idea (and the conditions are very similar as well). Since we'll refactor, I did not do it for the simple method and rather do it in the factor.

@abelsiqueira both the link and the codecov/project fails are confusing to me, could you have a look? Thanks!

For completeness, repeating some thigns from the chat here.
The link check failure is probably due to changes in the treatment of automated link checkers by the end points. Recommended solution is to ignore at the moment, and check after we apply Bestie (#676). If the error persists we can add it to the ignore list. This is safe to do for this website at least. We can think again for the others.
On a side note, it is actually possible to add it to the ignore list at .markdown-link-check.json right now, but we would need to go check how to run it locally
The Codecov error is probably because version "1" points to "1.11" now (https://github.com/JuliaLang/www.julialang.org/pull/2160) and that affected how the coverage is processed.
Possible solutions:

Set a range of acceptable coverage instead of the 100% goal - it will be harder and harder to keep it at 100%, so this might be an incentive and the right time to do it
Change the for and remove the intermediary variable constraints_files.

For completeness, repeating some thigns from the chat here.
The link check failure is probably due to changes in the treatment of automated link checkers by the end points. Recommended solution is to ignore at the moment, and check after we apply Bestie (#676). If the error persists we can add it to the ignore list. This is safe to do for this website at least. We can think again for the others. On a side note, it is actually possible to add it to the ignore list at .markdown-link-check.json right now, but we would need to go check how to run it locally
The Codecov error is probably because version "1" points to "1.11" now (JuliaLang/www.julialang.org#2160) and that affected how the coverage is processed. Possible solutions:

Set a range of acceptable coverage instead of the 100% goal - it will be harder and harder to keep it at 100%, so this might be an incentive and the right time to do it
Change the for and remove the intermediary variable constraints_files.

After some searching, it seems that I have to use an inline comment, but it does not work
<!-- markdownlint-disable-next-line -->
[Visit this link](https://code.visualstudio.com)

Is this what I should do?


#83, #84 - solving issues with TypeError in browser and dependecies

Current coverage is 49.57%

Merging #99 into master will not affect coverage as of f8fe2de

@@            master     #99   diff @@
======================================
  Files           10      10
  Stmts          119     119
  Branches         0       0
  Methods          0       0
======================================
  Hit             59      59
  Partial          0       0
  Missed          60      60

Review entire Coverage Diff as of f8fe2de

Powered by Codecov. Updated on successful CI builds.


Re-Review post issues

Hi!
Got an error after new commits after the first PR review.
Steps to reproduce:

Create a PR with some errors in the prometheus targets file;
Get your first PR review from pint;
Change something else and push commits to PR;
You will receive this error.
level=fatal msg="Execution completed with error(s)" error="submitting reports: creating review: POST https://api.github.com/repos/xxx/yyy/pulls/95/reviews: 422 Unprocessable Entity [{Resource: Field: Code: Message:Pull request review thread line must be part of the diff, Pull request review thread start line must be part of the same hunk as the line., and Pull request review thread diff hunk can't be blank}]"

I see that current GH integration can also create duplicated comments and would probably make sense to move it to use checks API - https://docs.github.com/en/rest/checks/runs?apiVersion=2022-11-28
I'll try to look into that when I have some time

This is fixed in the next release - #486


connection to server at "postgres" (<IP_ADDRESS>), port 5432 failed: FATAL:  password authentication failed for user "postgres" Stopping docker

D:\studioprojectD\muddra\muddra_server> .\setup-tables.cmd
Starting docker
[+] Running 3/3
✔ Network muddra_server_default       Created                                                                                0.7s
✔ Container muddra_server-redis-1     Started                                                                                2.0s
Waiting for Postgres...
Postgres is ready
failed to get console mode for stdin: The handle is invalid.
psql: error: connection to server at "postgres" (<IP_ADDRESS>), port 5432 failed: FATAL:  password authentication failed for user "postgres"
Stopping docker

What did you do to reach this?
Perhaps you have an old volume from a previous container with the same name?
Take a look at: https://stackoverflow.com/questions/76172995/serverpod-unable-to-authenticate-with-postgres


  Add that as a modifier.

Replace this paragraph with a description of your changes and rationale. Provide links to external references/discussions if appropriate.

Resolves SR-NNNN.

@swift-ci please smoke test and merge


feat: add generic struct builders generation

Implement builders for structs with generic params.
type AType[T any] struct {
    Prop T
}

[x] Refactor the whole thing for it to be pretty and maintenable (because right now it's ugly with the loop directly in the function reading the file.
[x] There seems to be some common code with computeProperty, function has been reused but it shouldn't since it entitles one to but a struct with tags and as such break the whole generation
[x] Add some complex tests to ensure it's OK in any generation case
[x] Handle a property generation with a generic type func SetProp(prop T) and not func SetProp(prop package.T), because obviously right now T is considered an exported type of given package and there's no boolean in ast.X to check if the type a generic one so comparison may need to be done manually ...

🎉 This issue has been resolved in version v1.2.0 🎉


chore: release 2.0.1

:robot: I have created a release *beep* *boop*
2.0.1 (2019-06-08)
Bug Fixes

bash script still had a couple bugs (#190) (9fabd64)
should use single = for bash comparison (#188) (068d1a4)

Release is at https://github.com/googleapis/release-please/releases/tag/v2.0.1

The release build has started, the log can be viewed here. :sunflower:

:egg: You hatched a release! The release build finished successfully! :purple_heart:


Leverage PHP 7 language features

Task Description

With the PHP version requirement bump we can use language features introduced in PHP 7, like scalar type declarations, return type declarations, and the null coalescing operator.
See https://www.php.net/manual/en/migration70.new-features.php for a full list of changes.
I expect the IDE can help with a lot of these optimizations.

Useful features.

Scalar type declarations
Return type declarations
Group use declarations

PHPStorm gives me tons of recommendations for automatically adding types and using null coalescing operators throughout the code base. That seems like a good start. Don't think grouping use statements provides much value, so we can skip that for now.
We have to be careful adding type declarations to add_action/add_filter callbacks, as it's not guaranteed that we get the expected type.

PHPStorm gives me tons of recommendations for automatically adding types and using null coalescing operators throughout the code base

How do you see these recommendations?

I think the ones I get are provided by the https://plugins.jetbrains.com/plugin/7622-php-inspections-ea-extended- plugin. Can highly recommend installing it 👍

This might be useful as well - https://github.com/rectorphp/rector

After trying out refactor, here is the output.
https://github.com/google/web-stories-wp/commit/55d3a46e07a8595d024e39464be91bed617fd4cf

Looks promising 👍
We'll probably have to remove some of those for add_filter/add_action callbacks as mentioned above.
Also, we can add return type hints.


app.js not found

After running npm run dev, The generated web page is blank and this is the error in the console:
"NetworkError: 404 Not Found - http://localhost:3000/app.js"

And a toast is appearing briefly with the following text:
Compile Error
Cannot find module 'react-tap-event-plugin'
from '/home/leszek/yo/material-ui-sass-git/
material-ui-sass/less/docs/src/app'

@leszekhanusz did you try with a fresh install? It looks like a dependency problem.
git clone --recursive https://github.com/gpbl/material-ui-sass.git
cd material-ui-sass

npm install    # will install material-ui-sass dep
npm run setup  # will install material-ui docs and deps
npm run dev    # run the dev environment

Yes.
I tried the commands above in a new folder and got the same result.
No obvious error during compilation:
http://en.textsave.org/jz0b

I cannot reproduce it on OS X, npm 2.5.1 and node 0.12.0 – maybe you are using an older version of npm? The missing module is actually specified in the parent's package.json as peer dependency.
However in case it is an issue with the material-ui package docs :(

I'm on Ubuntu 14.10 with the chris-lea node ppa
node v0.10.37
npm 1.4.28

Hmm the package.json file of material-ui is not there because material-ui is not a dependency ....
Works after doing npm install material-ui in the material-ui-sass folder.

material-ui is probably installed globally on your side.

Installing material-ui in material-ui-sass is an half fix since it does not install the docs required to run the demo app (that's why we are using the submodule). Anyway, glad you could fix it :-)


Update extensions-release.md

Updated connected registry extension notes.

@JnHs
Can you review the proposed changes?
Important: When the changes are ready for publication, adding a #sign-off comment is the best way to signal that the PR is ready for the review team to merge.
#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

#sign-off

@JnHs @Court72 any update on the sign-off?

#sign-off

@getk12,
Thank you for contributing to this Azure documentation. Unfortunately, changes to Azure Arc content can't be accepted this week. The Skilling Content group is migrating this content to a new repository: azure-management-docs.
In the meantime, we are closing this PR and tagging it so that when the content is available in the new repo, we can follow up with new location information.
#label:"migrate-followup"
#please-close

#sign-off

@getk12
The migration has been paused, and changes to Azure Arc content can be accepted for now. Thanks for your patience!
#remove-label:"migrate-followup"

#sign-off


Site is not running

There's not a lot of info given, but I did follow @msims04 information from here #1 .
The site isn't coming up at all. Nginx is working, so is php7. I have tested them both manually several times. I'm not getting any page response at all. Will this even work on Nginx?
During installation, I received no errors at all (surprisingly). However there is little information regarding the Eve Application setup as well as the .env file. Does Eve App need to be Authentication Only or Authenticated API Access? If API, which scopes need to be added? For the .env file, which settings are absolutely required? There are many there but I only had information for some of them. And the API key that it asks for, is that corp or player API?
Thanks for any help.

Ok, so apparently there were some SSL issues that I have gotten cleared up. So now the page loads, however it is mostly blank (http://prntscr.com/e2zsml) and I don't know how to populate anything.
Also, if I try to login, I get a 404 page not found error.

This was the solution to my problem:
nginx.conf
location / {
    try_files $uri $uri/ /index.php?$query_string;
}

Source: https://laravel.com/docs/5.4#web-server-configuration


fix: track promise only after a successful sendRpc()

Motivation

In rare case, a sendRpc() call may be failed or got delayed, we should only track promise after a successful sendRpc

part of #413

Codecov Report
Patch coverage: 16.66% and project coverage change: -0.04 :warning:

Comparison is base (1e1cf5a) 83.31% compared to head (5afb90a) 83.27%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #415      +/-   ##
==========================================
- Coverage   83.31%   83.27%   -0.04%
==========================================
  Files          48       48
  Lines       11800    11804       +4
  Branches     1271     1271
==========================================
- Hits         9831     9830       -1
- Misses       1969     1974       +5

Impacted Files
Coverage Δ

src/index.ts
70.33% <16.66%> (-0.14%)
:arrow_down:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

after 3.5h, there are more than 2k untracked promise due to unsuccessful sendRpc() call in a mainnet node with only Nimbus peers


[Docs] MovR Tutorial for PonyORM

Background: https://airtable.com/tblD3oZPLJgGhCmch/viw1DKmbKhg2MIECH/recMmUqtH5ZZ1GEWT
Description: CockroachDB now provides application code and documentation for using MovR with PonyORM
Team: Andrew Woods, Rafi Shamim, Eric Harmeling

Dup of https://github.com/cockroachdb/docs/issues/6264


make_pass_decorator strips argument

The inner most wrapper of make_pass_decorator invokes a function with *args[1:] which strips an argument.
A smaller example could be made but the following is the invoking other commands example from the docs modified to also take in a custom config object.
The only difference between dist_working and dist_broken is the order of the decorators and consequently the parameters they take.
In my opinion they should both be valid and work.  What happens in dist_broken is, like the title says, the make_pass_decorator wrapper invokes the function with *args[1:] which removes the context object put there by the previous decorator.
import click

class MyConfig(object):
    def __init__(self, verbose):
        self.verbose = verbose

pass_config = click.make_pass_decorator(MyConfig)

@click.group()
@click.option('--verbose', '-v', is_flag=True)
@click.pass_context
def cli(ctx, verbose):
    ctx.obj = MyConfig(verbose=verbose)

@cli.command()
@click.option('--count', default=1)
def test(count):
    click.echo('Count: %d' % count)

@cli.command('dist-working')
@click.option('--count', default=1)
@pass_config
@click.pass_context
def dist_working(ctx, cfg, count):
    if cfg.verbose:
        click.echo('about to forward')
    ctx.forward(test)
    if cfg.verbose:
        click.echo('about to invoke')
    ctx.invoke(test, count=42)

@cli.command('dist-broken')
@click.option('--count', default=1)
@click.pass_context
@pass_config
def dist_broken(cfg, ctx, count):
    if cfg.verbose:
        click.echo('about to forward')
    ctx.forward(test)
    if cfg.verbose:
        click.echo('about to invoke')
    ctx.invoke(test, count=42)

There is a fix for this.  Can we consider this a bug and get the fix merged?


initial commit, not ready yet for production, but tests passes, so de…

…finitely ready for initial commit

This PR contains:

[ ] bugfix
[x] feature
[ ] refactor
[ ] documentation
[ ] other

Are tests included?

[ ] no
[x] yes (bugfixes and features will not be merged without tests)

Breaking Changes?

[x] no
[ ] yes (breaking changes will not be merged unless absolutely necessary – please provide motivation)

List any relevant issue numbers:

Description
Guys, this is the initial commit, the entry and the library are working fine on my tests (you can reproduce the tests by compiling and running the util in tests -> CUtilHelloWorld)
@InteractiveYelp I had no idea you were trying to build utils in C (Jeffrey pointed me to an issue you've raised in the forum), this library does a bit more than you've got there, so I am sure you'll be happy to review and also help me to improve this code.
The way this works is by creating a library that then can be simply linked to regular C built using CUtil and the util code is generated correctly, has a stack, doesn't corrupt anything in RISC OS and should make it easy to build utils using C.
Next I am figuring out how to add malloc and free support.
Please note: this pull request is for Develop, not main.

I see you are still making changes, @pzaino . Will you ask for review again when you are done, pleas?

@skymandr

I also think that this code looks like at least some of the functions could be unit-tested, perhaps using the build-service. That would be really cool.

I totally agree, I just constantly running out of time to look into the integration, but I really would like to integrate with the build-service at least for the testing part.
Is anyone of us having some spare cycles? Otherwise we'll need to wait until I have uploaded all my early work.

@skymandr

I have one major concern though: why are the o-files checked in? These are build-artifacts, right? If so, I don't think they should be in the source tree.

You are absolutely correct, but I have got some "complain" from people who do not have DDE, so for now let's leave them there, I need to finish a full building framework written in Lua that also generates the RiscPkg Package, I know it's not a good engineering process  like we have it now, but to convince and move the whole ROS community to adopt git and github seems to be a very time consuming effort. I suspect that main issue is that many in the community do not have professional software development background or at least not in the recent years, but obviously I could be wrong.
Anyway I am planning to remove the objects as soon as I have a full building system in place, sounds good? Otherwise I have to package manually each piece to allow non-DDE people to be able to play with them. I am also trying to always support GCC too, but supporting two different compilers is also a time consuming activity. Anyway I am open to better ideas :)

Anyway, I am planning to remove the objects as soon as I have a full building system in place, sounds good? Otherwise I have to package manually each piece to allow non-DDE people to be able to play with them. I am also trying to always support GCC too, but supporting two different compilers is also a time consuming activity. Anyway I am open to better ideas :)

An alternative would be to make a release including the object files. Would be best of course if this were automated, but manual would be fine too. Another alternative would be to have a separate branch called something instructive, for those who need the object files.

An alternative would be to make a release including the object files. Would be best of course if this were automated, but manual would be fine too. Another alternative would be to have a separate branch called something instructive, for those who need the object files.

Speaking of which, today got a request to add support to build the lib using ROOL !Build, just adding this here to remember to look into that at some point.

An alternative would be to make a release including the object files. Would be best of course if this were automated, but manual would be fine too. Another alternative would be to have a separate branch called something instructive, for those who need the object files.

Speaking of which, today got a request to add support to build the lib using ROOL !Build, just adding this here to remember to look into that at some point.

Add an issue instead?

Add an issue instead?

Done, thanks for reminding me, duh! 😄
Any chance you can have a look into this request and see if we can adapt my building scripts to support the builder? Thanks in advance @skymandr !!!


allow to construct BytesMut with custom alignment

added BytesMut::with_capacity_aligned to allocate BytesMut with custom alignment
fix #600

Close for now. I have no idea to archive aligned drop and ensure share ref able to drop aligned yet.
I'll reopen this pr later when I can do it.
If anyone have idea please comment :smile: .

My use-case is the same as yours, @Wireless4024: I need an aligned buffer to use O_DIRECT.
I just submitted PR #684, which gives one way in which it might be possible to create a Bytes with arbitrary alignment.


shoal user is hard-coded in init file

It is good that users have the option to run shoal with a custom account, e.g. 'shoal' instead of 'nobody'. It will make it more convenient for users if the USER configuration variable is loaded from the .conf file instead of being hard-coded in the init script:
USER=nobody
Otherwise each time the RPM is updated, the init script (which may have been changed to specify a custom user) will be wiped out and the user will have to apply their customization again. So it would be better for this to be in the shoal_agent.conf file.

Please don't call python from init script.
Two configuation files
/etc/sysconfig/shoal

which is the configuration for the init script that starts with
if [ -f /etc/sysconfig/shoal ] ; then
   . /etc/sysconfig/shoal
fi

In here set SHOAL_USER (don't use USER in fact since this is the shell's user)

The daemon itself can then use the /etc/shoal/shoal_agent as it does now.

I support the general item to run as a user 'shoal' and not nobody.

I agree, that is much simpler.

Closing. Solved by @traylenator 's patch.


Add ProgressListener to the list of Listeners

A progress listener tracks the progress of the QueryBatcher and have the progress published to consumers registered with the listener.
PR 928
This will be used to track the PR and add functional tests and documentation

https://github.com/marklogic/java-client-api/pull/932

This is pushed in https://github.com/marklogic/java-client-api/tree/post4.1 branch

Information available in Java Client API documentation.


Enable CI test runs on downlevel Windows

This is done :)

We got successful runs on all platforms. Closing

So it's green forever? :)
Build buddies from now on should start watching these builds as well then.  cc @moozzyk @Tratcher

Oh? 2008R2 has almost never passed.

@victorhurdugaci?


fix: Reusing 'SaleArtworksHomeRailContainer' rail

The type of this PR is: Bugfix

This PR resolves CX-2143
Description
The requirement is to show the Auction lot amount of the artwork instead of showing Contact for price. It's a bug that required a fix. While investigating I figured out that there are two different rails being used in two different places in the app, the Home screen and the Auctions screen. They both share the same query lotsByFollowedArtistsConnection and fetch the same result. So instead of using two different components, this PR has fixed it by reusing the same component SaleArtworkTileRailCardContainer, in both places and deleted the other one, instead of fixing the Contact for price bug.

Home Screen
Auctions screen

Reason for using the same in different places is still in talks between the team.
https://artsy.slack.com/archives/C01B2P6LJUU/p1637585750294800
Probably we'll come up with removing one.
PR Checklist (tick all before merging)

[x] I have included screenshots or videos to illustrate my changes, or I have not changed anything that impacts the UI.
[x] I have tested my changes on iOS and Android.
[x] I have added tests/stories for my changes, or my changes don't require testing/stories, or I have included a link to a separate Jira ticket covering the tests.
[x] I have added a feature flag, or my changes don't require a feature flag. (How do I add one?)
[x] I have documented any follow-up work that this PR will require, or it does not require any.
[x] I have added an app state migration, or my changes do not require one. (What are migrations?)
[x] I have added a changelog entry below or my changes do not require one.

To the reviewers 👀

[ ] I would like at least one of the reviewers to run this PR on the simulator or device.

Changelog updates
Changelog updates

Cross-platform user-facing changes

Resuing the same SaleArtworksHomeRailContainer and deleting the other rail instead of fixing 'Contact for price' - sam

iOS user-facing changes

Android user-facing changes

Dev changes

This PR contains the following changes:

Cross-platform user-facing changes (Resuing the same SaleArtworksHomeRailContainer and deleting the other rail instead of fixing 'Contact for price' - sam)

  Generated by :no_entry_sign: dangerJS against 729c6cbebb2e988122dcf4b330e394c7a4df8714

#squashongreen


If the measure function is defined: only return from execution of lay…

…outNode, when the node has no children.
I'am currently working on a new implementation of the TextView element in react-native.
My implementation uses the node->measure function to calculate the height of the element, but a TextView may also have subviews. If thats the case it's necessary to execute the rest of the layoutNode function and not stopping it after line 318.
This change does not affect the behaviour of the other module ( RCText ), that uses the measure function, because this element will always have a children_count of zero.

This is a little embarrassing: only changed 3 lines of code and it's failing: think I just copied the code from C to javascript ... :/
I'll create another pull request.


Change behaviour of converters option

This issue relates to the discussion on #101.
The converters option currently extends the default converters but when invoking toMarkdown, it appears like it overrides them.
If the converters option were to override the converters, we could expose the default converters publicly (e.g. toMarkdown.defaultConverters, toMarkdown.gfmConverters), which could then be extended as follows:
var myConverters = […]

toMarkdown('…', {
  converters: myConverters.concat(toMarkdown.defaultConverters)
})

hi @domchristie , still not totally clear to me. From #101 it appears that custom converts are prepended to the default converters. In other words, defining a custom converter will first run that one, followed by the default ones. Is that correct?
Specifically, I'm trying to set relative image urls to absolute ones. Since (I believed) the custom converter is run before the default ones, simply doing the following should work imho, however it does not.
{
  filter: 'img',
  replacement: (out, imgEl) => {
    imgEl.src = "http://example.com/"  + imgEl.src;
    return out;
  }
}

Any tip on how I can achieve what I want to do?

defining a custom converter will first run that one, followed by the default ones. Is that correct?

Unfortunately not. The library just picks the first converter that matches the filter. So to achieve what you want, you'll have to do add a converter like the following:
{
  filter: 'img',
  replacement: function (content, node) {
    var alt = node.alt || ''
    var src = node.getAttribute('src') || ''
    var title = node.title || ''
    var titlePart = title ? ' "' + title + '"' : ''
    return src ? '![' + alt + ']' + '(http://example.com' + src + titlePart + ')' : ''
  }
}

I will consider a preprocess option so that a node can be modified before conversion.

This thread is very import.  It should be in the doc for developers. The converters option is very flexible. Its behavior need to be clarified.
I think the overwriting behavior is reasonable, except, when user defined a catch-all/default tag handler, move it to the end of the convert array but before the built-in default tag handler.  Maybe we should have a separate name for defaultFilter,  so it doesn't surprise users!
{
  defaultFilter: () => true,
  replacement: (content, node) => content
}

Extending built-in filter behavior sounds good but I doubt their usefulness.  It can be done as a function decorator:

// expose function decorator helper functions to users
const before = function (beforeFn, f) {
  return function (...xs) {
    const ys = beforeFn(...xs)
    return f(...ys)
  }
}

const after = function (afterFn, f) {
  return function (...xs) {
    const ret = f(...xs)
    return afterFn(ret)
  }
}

// Now, when a user define a filter, she gets the replacement property of the built-in filter with the same name

{
   filter: 'p',
   replacement: after(function (x) {
      return x + '--> length of previous paragraph: ' + x.length
   }, replacementFunctionOfBuiltInPTag)
}

To me, it would be much easier to overwrite, because to use the decorator way, I had to closely exam the return value of a built-in function, which is a string,  without structure. When I do a before doco, I can't pass more arguments to the built-in replacement function, which renders it useless.
My suggestion:

put the inner working of converters options in doc
provide converter examples in the doc
keep the current way of doing things
have a separate name for default converter

If user defined a catchAll filter, put it at the end of the filter array and remove the default catchAll filter.
A hackish implmentation:

  converters = mdConverters.slice(0)

  var findIdxOfDefaultConverterDefinedByUser = function (xs) {
    return xs.findIndex(function (e) {
      // console.log(e.filter)
      // if filter is an function and calling it without arugument
      // returns true, then it's a catch-all filter
      // e.g
      // filter: function () {
      //   return true
      // }
      var f = e.filter
      return (typeof f === 'function') && f() === true
    })
  }

  var userDefinedCatchAllFilter = function (xs) {
    return findIdxOfDefaultConverterDefinedByUser(xs) > - 1
  }
  var removeOldCatchAllFilter = function (xs) {
    var ys = []
    xs.forEach(function (e) {
      if (typeof e.filter === 'function' && e.filter.length === 0) {
        // FIXME
        // Hackish. Because the default filter uses 'this',
        // we can't call f() == true
        // It will throw confusing error msg:
        // 'var hasSiblings = node.previousSibling || node.nextSibling
        // TypeError: Cannot read property 'previousSibling' of undefined'
        // I noticed the catch-all filter function deesn't have a argument,
        // all other filter functions have one.
      } else {
        ys.push(e)
      }
    })
    return ys
  }
  var addUserDefinedConverters = function (userConverters, defaultConverters) {
    var idx, catchAllFilter, updatedDefaultConverters;
    if (!userDefinedCatchAllFilter) {
      return defaultConverters.concat(userConverters)
    } else {
      idx = findIdxOfDefaultConverterDefinedByUser(userConverters)
      catchAllFilter = userConverters[idx]
      userConverters.splice(idx, 1)
      updatedDefaultConverters = removeOldCatchAllFilter(defaultConverters)
      return updatedDefaultConverters.concat(userConverters).concat([catchAllFilter])
    }
  }

  if (options.gfm) {
    converters = gfmConverters.concat(converters)
  }

  if (options.converters) {
    converters = addUserDefinedConverters(options.converters, converters)
  }

@academyofzhuang how do you feel about how this is handled in the turndown branch: defaultReplacement is an option: https://github.com/domchristie/to-markdown/blob/turndown/src/turndown.js#L29-L31

@domchristie , it's what I would ask for!
Before that branch becoming the default, I have to use this clumsy implementation in my project.
The turndown branch fixed two "bugs" in the current master which I had to change source code to walk around it.

The sentence stop after a number.
The catch-all filter option

Can't we to see it go live!


ViewportTexture must be assigned in code to be rendered in-game and does not render in the editor when reloading scene.

Godot version
4.0 Beta 5
System information
Windows 10, Vulkan, Nvidia drivers version 516.94
Issue description
When assigning a ViewportTexture to a material it displays in the editor however, when the game is launched the ViewportTexture does not display correctly and only draws a solid purple color. Additionally, when the scene is closed and re-opened this same issue occurs. Expected behavior is that the texture displays the same in-game as it does in the editor. Assigning the ViewportTexture using GDScript circumvents this issue.

Quad on the left has its texture assigned in GDScript, Quad on the right has its texture assigned in the editor.
Steps to reproduce
Create a SubViewport with a camera3d as a child.
Set the SubViewport's update mode to always. (Update mode "When Visible" doesn't seem to work currently)
Create a quad mesh with a standard material and set its albedo_texture to a ViewportTexture pointing to the SubViewport .
Save the scene.
Close and reopen the scene.
Minimal reproduction project
ViewportBugMRP.zip

@InitialCon this is likely due to another bug where viewport textures of 512x512 do not render. If you change the resolution this should be resolved; to something like 514x514.

That bug has already been fixed in beta 5, I checked myself to confirm it and these two bugs are unrelated.

Same version, i also have the same problem. Everything renders fine in the editor and in game it is just purple all over.

Yeah. My original theory was that Viewport textures aren't being set when the engine loads a scene but I didn't want to include speculation in the issue.

This seems to be a contributing to an issue I'm experiencing in regard to ViewportTextures and setting them via tool scripts. Godot seems to not see them when the application loads initially. I have to close and reopen the scenes.

This issue is similar to #68088, see https://github.com/godotengine/godot/issues/68088#issuecomment-1321067723 for the cause of this issue.

I am still experiencing this issue in Beta 10. I believe this error may be related?

I've found the cause of this issue. While the editor claims you need to make your material local to scene for it to display correctly and throws an error if you don't, you actually need to make the mesh that it's attached to local to scene as well to avoid this issue. Should this be changed or do we take the simple solution of changing the message that is displayed when you assign a viewport texture to reflect this?


Changed svm.SVC kernel='rbf' and added decision_function_shape='ovo'

Changed svm.SVC kernel='rbf' and added decision_function_shape='ovo', which seems to work well with learning the SVM model when number of classes(different people) increases for multi class classification and kernel='rbf' kernel would also work well with such high-dimensional data.

@iamsiddhantsahu hi, how to recognize a amount of people ,more than 10k?


Support checking snake case and camel case

Add native functions to check snake case and camel case

https://pkg.go.dev/github.com/iancoleman/strcase

https://github.com/iancoleman/strcase depends on the global variable
https://github.com/iancoleman/strcase/blob/531aaa44de12ec166ceb71d9bdad7c8295e4235f/acronyms.go#L7-L13


Fixed missing "end" in nginx.conf

Hi,
I think there was a typo (missing "end" in a Lua block in nginx.conf file), here's a fix for that.
Cheers!
Sébastien Roccaserra.

Thanks!


Create Submission Window Management Quartz Job

Create a Quartz job that will Manage Submission Windows per the linked requirements
Development Notes:

Convert the following tables from the Oracle host to Postgres

[x] CAMDMD.RESPONSIBILITY
[x] CAMD.PLANT_PERSON
[x] CAMD.PROGRAM_PHASE
[ ] CAMDECMPSAUX.SUBMISSION_LOG
[ ] CAMDECMPSAUX.SUBMISSION_LOG_CHECK_SESSION
[ ] CAMDECMPSAUX.SUBMISSION_QUEUE_LOG
[ ] CAMDECMPSAUX.SUBMISSION_STAGE_LOG

Create Initial Window for each Monitor Plan that is expected to report for the quarter

See Creating Initial Submission Windows section in the linked document
Reopening of windows with Critical 2 submissions is only needed because the submission process currently closes the windows when Critical 2 submissions occur. WE NEED TO CHANGE THIS SO THEY STAY OPEN

Next item

research and Spike to better understand tables and Views necessary for Submission Process to be converted, will be broken down into smaller components

Not needed for March 15th Conference

Additional tickets will come out of this one. Other tickets will be tracked seperately in the backlog

Will not be ready for testing until Mats bulk file functionality is completed

Is not ready for testing until we get recipient endpoint from Mark H. This ticket will need to be tested by someone with database access

see Finish submission window job #5910


Fix broken Trainer.test

Fixes #979 and #1007. Note that #770 claims to fix this problem as well (https://github.com/PyTorchLightning/pytorch-lightning/issues/1007#issuecomment-593436335), but includes other changes.

@neggert i tried that... #985 working on this PR. But not having success...
For some reason if .fit is called the accuracy is low (in test) but direct eval is fine

Which test is that in? Probably one process has the untrained weights.

FWIW, I think we still need a longer-term fix for returning values from torch.multiprocessing.spawn. This PR is just a band-aid to get the test passing.

wait. i think i made progress...
The weights summary call somehow wipes the model.
I put a patch in for now but need to head out for the next few hours. Let's merge that PR and maybe you can take a look at it. Otherwise, i'll look in more detail tonight.
I also added a print with the results of the test because people were asking about that.

oh shoot.. looks like that problem is still happening.
I fixed a few other .test problems but the ddp is the last one.
I have a few options.
Option 1 (hack):
Why don't we save a checkpoint when ddp_train ends then load weights once .spawn is done.
Option 2:
Use a mp Queue or look into model.share_weights()

@neggert @Borda
Ok, the PR i submitted (merged) passed all tests.
Try again?


Is LWJGL a required dependency?

Hi,
im currently in the progress of writing a binding for JME3. I noticed, that upon creating the Font
		fontTexture = IO.INSTANCE.getFonts().getTexDataAsRGBA32();
I get an expection:
java.lang.NoClassDefFoundError: org/lwjgl/system/MemoryUtil
	at uno.buffer.BufferKt.bufferBig(buffer.kt:18)
	at imgui.FontAtlas.addFontFromMemoryTTF(font.kt:160)
	at imgui.FontAtlas.addFontFromMemoryCompressedTTF(font.kt:176)
	at imgui.FontAtlas.addFontFromMemoryCompressedBase85TTF(font.kt:185)
	at imgui.FontAtlas.addFontDefault(font.kt:147)
	at imgui.FontAtlas.addFontDefault(font.kt:138)
	at imgui.FontAtlas.getTexDataAsAlpha8(font.kt:242)
	at imgui.FontAtlas.getTexDataAsRGBA32(font.kt:253)
	at ImGuiState.initialize(ImGuiState.java:25)
	at com.jme3.app.state.BaseAppState.initialize(BaseAppState.java:124)
	at com.jme3.app.state.AppStateManager.initializePending(AppStateManager.java:251)
	at com.jme3.app.state.AppStateManager.update(AppStateManager.java:281)
	at com.jme3.app.SimpleApplication.update(SimpleApplication.java:236)
	at com.jme3.system.lwjgl.LwjglAbstractDisplay.runLoop(LwjglAbstractDisplay.java:151)
	at com.jme3.system.lwjgl.LwjglDisplay.runLoop(LwjglDisplay.java:197)
	at com.jme3.system.lwjgl.LwjglAbstractDisplay.run(LwjglAbstractDisplay.java:232)
	at java.lang.Thread.run(Thread.java:812)
Caused by: java.lang.ClassNotFoundException: org.lwjgl.system.MemoryUtil
	at java.net.URLClassLoader.findClass(URLClassLoader.java:444)
	at java.lang.ClassLoader.loadClass(ClassLoader.java:490)
	at sun.misc.Launcher$AppClassLoader.loadClass(Launcher.java:376)
	at java.lang.ClassLoader.loadClass(ClassLoader.java:423)
	... 17 more

So the question is, is lwjgl required for this?
Or is there some way I can configure the system to use a different buffer implementation?
Reason is, that I try to only use the official JME3 api for the binding in the hope that it will also work with jogl ect.
Greetings, Empire

Yes. You should not run into issues adding LWJGL core and STB however, which are the necessary pieces, as you won't ever touch openGL in LWJGL. However, I see one issue with this which I'll PR later. Until then, try adding LWJGL and seeing what happens.

Adding only the required LWJGL dependencies at this time should work, there are not issues where I though there would be.

Yes, I get a bit further now, but there is still some issue with that buffer stuff.
Uncaught exception thrown in Thread[jME3 Main,5,main]
VerifyError: Bad type on operand stack
Exception Details:
  Location:
    org/lwjgl/system/MemoryUtil.memRealloc(Lorg/lwjgl/PointerBuffer;I)Lorg/lwjgl/PointerBuffer; @1: invokestatic
  Reason:
    Type 'org/lwjgl/PointerBuffer' (current frame, stack[0]) is not assignable to 'org/lwjgl/system/CustomBuffer'
  Current Frame:
    bci: @1
    flags: { }
    locals: { 'org/lwjgl/PointerBuffer', integer }
    stack: { 'org/lwjgl/PointerBuffer' }
  Bytecode:
    0x0000000: 2ab8 001a 1bb2 0015 b800 0fb8 0028 1bb8
    0x0000010: 0016 4d2a c600 142c c600 102c 2ab6 0030
    0x0000020: 1bb8 0026 b600 3157 2cb0
  Stackmap Table:
    append_frame(@40,Object[#325])

Have you already seen this somewhere? running on jdk 1.8.0_131

do you get an actual stacktrace, or a hs_err_pid_* file?

Only the one in the bottom. This looks like an jvm error actually, as Pointerbuffer directly extends Custombuffer, it should always be assignable. I will investigate further.

apparently the lwjgl version I used is build with a buggy compiler, and should never have compiled in the first place O.o. I will try with another version later.

Hi Empire,
ideally we would have jogl as dependency only for the jogl implementation and similar for lwjgl.
However, we do also use lwjgl for the buffer management (creation, access e deletion) and the stb binding (although there were some attempts from the community to use FreeType)
I'll forward your issue to spasi regarding lwjgl, to see if we can solve together :)

I would offer to build a pull request, similar to the one I did back a while in JME3
http://javadoc.jmonkeyengine.org/com/jme3/util/BufferAllocator.html
Basically it is a simple interface that tunnels all allocations, and can be set to a different implementation before startup. This allows jme to use specific allocators for lwjgl, jogl, directbytebuffers (with destroy reflection hack).
-> This would allow pure jvm logic by using directbytebuffers (eg for pure serverside to image rendering)
-> Using lwjgl or jogl based on the choosen driver.
If you agree, I will try to prepare a pull request for this once done.

@empirephoenix Based on the stacktraces above, it looks to me like you're trying to use JME3's lwjgl2 backend. imgui depends on lwjgl3, which is not at all compatible with lwjgl2 (e.g. CustomBuffer did not exist in lwjgl2). Obviously there's nothing wrong with how lwjgl3 has been compiled, etc.
Switching to the lwjgl3 backend should fix the weird issues.

Theoretically I have no problems with that..
But I guess we should operate at the uno-sdk level because I do all the buffer management there using lwjgl MemoryUtil class..
Anyway, uno-sdk depends on its turn on gli, which also uses lwjgl
So, if we/you want to change that we have to find a nice and good solution

Actually trying to use it with the lwjgl 3 backend created it's own set of similar issues.
Where I currently have a few issues understanding the reason behind, as far as I understood the c++ imgui one of the big features is, that it is completely renderer agnostic and has no dependencies to opengl or directx (Or is this a misunderstanding?), so why does the port require an opengl implementation?

It doesn't require OpenGL. It only uses the lwjgl-core (for memory management) and lwjgl-stb (for font rendering) modules.

hm ok, lwjgl-stb has lwjgl full in the dependencies anyway, so there is not much won then.

Actually trying to use it with the lwjgl 3 backend created it's own set of similar issues.

Could you please post more details about this? Is there something about lwjgl3 that caused the issues?


1 of 2 shards failed  The data you are seeing might be incomplete or wrong.

Hi Firts I want to thank you for this Dashboard, follow your instructions and found a couple if issues in my Kibana, I set Modsec2 and Suricata, Suricata is working fine but Modsec2 have disply problems.  Any help will be highly appreciatted.
Shard Failures
{
"took": 7,
"timed_out": false,
"_shards": {
"total": 2,
"successful": 1,
"skipped": 1,
"failed": 1,
"failures": [
{
"shard": 0,
"index": "filebeat-7.8.1-2020.07.28-000001",
"node": "avET7gESR7isL8CSrge11w",
"reason": {
"type": "illegal_state_exception",
"reason": "Rewrite first"
}
}
]
},
"hits": {
"total": 0,
"max_score": 0,
"hits": []
}
}
Request
{
"aggs": {
"3": {
"date_histogram": {
"field": "@timestamp",
"fixed_interval": "30m",
"time_zone": "America/Mexico_City",
"min_doc_count": 1
},
"aggs": {
"4": {
"filters": {
"filters": {
"Intercepted": {
"bool": {
"must": [
{
"query_string": {
"query": "exists:modsecurity2 AND exists:modsecurity2.audit.audit_data.action.intercepted",
"analyze_wildcard": true,
"time_zone": "America/Mexico_City"
}
}
],
"filter": [],
"should": [],
"must_not": []
}
},
"Passed": {
"bool": {
"must": [
{
"query_string": {
"query": "exists:modsecurity2 AND NOT exists:modsecurity2.audit.audit_data.action.intercepted",
"analyze_wildcard": true,
"time_zone": "America/Mexico_City"
}
}
],
"filter": [],
"should": [],
"must_not": []
}
}
}
}
}
}
}
},
"size": 0,
"stored_fields": [
"*"
],
"script_fields": {},
"docvalue_fields": [
{
"field": "@timestamp",
"format": "date_time"
},
{
"field": "event.created",
"format": "date_time"
},
{
"field": "event.end",
"format": "date_time"
},
{
"field": "event.start",
"format": "date_time"
},
{
"field": "file.accessed",
"format": "date_time"
},
{
"field": "file.created",
"format": "date_time"
},
{
"field": "file.ctime",
"format": "date_time"
},
{
"field": "file.mtime",
"format": "date_time"
},
{
"field": "kafka.block_timestamp",
"format": "date_time"
},
{
"field": "netflow.collection_time_milliseconds",
"format": "date_time"
},
{
"field": "netflow.exporter.timestamp",
"format": "date_time"
},
{
"field": "netflow.flow_end_microseconds",
"format": "date_time"
},
{
"field": "netflow.flow_end_milliseconds",
"format": "date_time"
},
{
"field": "netflow.flow_end_nanoseconds",
"format": "date_time"
},
{
"field": "netflow.flow_end_seconds",
"format": "date_time"
},
{
"field": "netflow.flow_start_microseconds",
"format": "date_time"
},
{
"field": "netflow.flow_start_milliseconds",
"format": "date_time"
},
{
"field": "netflow.flow_start_nanoseconds",
"format": "date_time"
},
{
"field": "netflow.flow_start_seconds",
"format": "date_time"
},
{
"field": "netflow.max_export_seconds",
"format": "date_time"
},
{
"field": "netflow.max_flow_end_microseconds",
"format": "date_time"
},
{
"field": "netflow.max_flow_end_milliseconds",
"format": "date_time"
},
{
"field": "netflow.max_flow_end_nanoseconds",
"format": "date_time"
},
{
"field": "netflow.max_flow_end_seconds",
"format": "date_time"
},
{
"field": "netflow.min_export_seconds",
"format": "date_time"
},
{
"field": "netflow.min_flow_start_microseconds",
"format": "date_time"
},
{
"field": "netflow.min_flow_start_milliseconds",
"format": "date_time"
},
{
"field": "netflow.min_flow_start_nanoseconds",
"format": "date_time"
},
{
"field": "netflow.min_flow_start_seconds",
"format": "date_time"
},
{
"field": "netflow.monitoring_interval_end_milli_seconds",
"format": "date_time"
},
{
"field": "netflow.monitoring_interval_start_milli_seconds",
"format": "date_time"
},
{
"field": "netflow.observation_time_microseconds",
"format": "date_time"
},
{
"field": "netflow.observation_time_milliseconds",
"format": "date_time"
},
{
"field": "netflow.observation_time_nanoseconds",
"format": "date_time"
},
{
"field": "netflow.observation_time_seconds",
"format": "date_time"
},
{
"field": "netflow.system_init_time_milliseconds",
"format": "date_time"
},
{
"field": "process.start",
"format": "date_time"
},
{
"field": "suricata.eve.flow.end",
"format": "date_time"
},
{
"field": "suricata.eve.flow.start",
"format": "date_time"
},
{
"field": "suricata.eve.timestamp",
"format": "date_time"
},
{
"field": "suricata.eve.tls.notafter",
"format": "date_time"
},
{
"field": "suricata.eve.tls.notbefore",
"format": "date_time"
}
],
"_source": {
"excludes": []
},
"query": {
"bool": {
"must": [],
"filter": [
{
"match_all": {}
},
{
"range": {
"@timestamp": {
"gte": "2020-07-30T05:00:00.000Z",
"lte": "2020-07-31T04:59:59.999Z",
"format": "strict_date_optional_time"
}
}
}
],
"should": [],
"must_not": []
}
}
}
Response
{
"took": 10,
"timed_out": false,
"_shards": {
"total": 2,
"successful": 1,
"skipped": 1,
"failed": 1,
"failures": [
{
"shard": 0,
"index": "filebeat-7.8.1-2020.07.28-000001",
"node": "avET7gESR7isL8CSrge11w",
"reason": {
"type": "illegal_state_exception",
"reason": "Rewrite first"
}
}
]
},
"hits": {
"total": 0,
"max_score": 0,
"hits": []
}
}

I am not quite sure if this error message "1 of 2 shards failed" is connected with a filebeat module. Shard is a piece of information where elasticsearch keeps its data. If not all of them are available (e.g. one cluster node is down or file corrupted ) then probably similar message appears. If data is not so important it can be rebuild by just removing index (it drops all shards), reset filebeat index for log files and process the files once again.

Thank You, I will increase shards to 3 to avoid this kind of problem.   Question…  actually the fields.yml file exists due the Suricata filebeat installation, this affects yours?   Aside Suricata uses JSON the directives setup.template.fields: /etc/filebeat/fields.yml
setup.template.json.enabled: false and setup.template.overwrite: true on Filebeat.yml could affect the Suricata?
I´m new on this matter and really appreciate your help on this, wants to use your Modsecurity dashboard, think is really helpful.
Best regards
EP
De: molu8bits<EMAIL_ADDRESS>Enviado el: lunes, 3 de agosto de 2020 09:26 a. m.
Para: molu8bits/modsecurity-filebeat-kibana<EMAIL_ADDRESS>CC: epadron54<EMAIL_ADDRESS>Author<EMAIL_ADDRESS>Asunto: Re: [molu8bits/modsecurity-filebeat-kibana] 1 of 2 shards failed The data you are seeing might be incomplete or wrong. (#6)
I am not quite sure if this error message "1 of 2 shards failed" is connected with a filebeat module. Shard is a piece of information where elasticsearch keeps its data. If not all of them are available (e.g. one cluster node is down or file corrupted ) then probably similar message appears. If data is not so important it can be rebuild by just removing index (it drops all shards), reset filebeat index for log files and process the files once again.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub https://github.com/molu8bits/modsecurity-filebeat-kibana/issues/6#issuecomment-668052948 , or unsubscribe https://github.com/notifications/unsubscribe-auth/AQORCIQPM5GBZLMQHPEGBETR63CJBANCNFSM4POPXONA .  https://github.com/notifications/beacon/AQORCIW47RXYXH52D2JGNELR63CJBA5CNFSM4POPXONKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOE7I23VA.gif
--
Este correo electrónico ha sido comprobado en busca de virus por AVG.
http://www.avg.com

fields.yml is just a fields.yml from Filebeat 7.3.2 distribution + added required fields to handle modsecurity2. So it consists of required fields for Suricata from 7.3.2.
It's very important to change these settings (related to fields) before first run of filebeat and before first index filebeat* is created (mappings is created when index is created and you cannot change it for an existing index).
If you send log entries for modsecurity parsed by the module but without correct mappings then fields can be incorrectly recognized. E.g. Elasticsearch doesn't know that shoud create geo_point for ip addresses and saves them as text values (or other type of strings). Mappings are created when index is created and Elasticsearch guesses what type should be assigned to specific fields. Unfortunately for most of fancy fields types like geo_point or ip address those mapping are not good enough to create visualisation, as they expect strictly defined fields.
Mapping fields in filebeat and elasticsearch is not easy topic. Moreover is changing from version to version. You can start to learn details e.g. here: https://www.elastic.co/guide/en/beats/filebeat/7.x/configuration-template.html

Got it, Highly Appeciated.
Best Regards
EP
De: molu8bits<EMAIL_ADDRESS>Enviado el: lunes, 3 de agosto de 2020 03:04 p. m.
Para: molu8bits/modsecurity-filebeat-kibana<EMAIL_ADDRESS>CC: epadron54<EMAIL_ADDRESS>Author<EMAIL_ADDRESS>Asunto: Re: [molu8bits/modsecurity-filebeat-kibana] 1 of 2 shards failed The data you are seeing might be incomplete or wrong. (#6)
fields.yml is just a fields.yml from Filebeat 7.3.2 distribution + added required fields to handle modsecurity2. So it consists of required fields for Suricata from 7.3.2.
It's very important to change these settings (related to fields) before first run of filebeat and before first index filebeat* is created (mappings is created when index is created and you cannot change it for an existing index).
If you send log entries for modsecurity parsed by the module but without correct mappings then fields can be incorrectly recognized. E.g. Elasticsearch doesn't know that shoud create geo_point for ip addresses and saves them as text values (or other type of strings). Mappings are created when index is created and Elasticsearch guesses what type should be assigned to specific fields. Unfortunately for most of fancy fields types like geo_point or ip address those mapping are not good enough to create visualisation, as they expect strictly defined fields.
Mapping fields in filebeat and elasticsearch is not easy topic. Moreover is changing from version to version. You can start to learn details e.g. here: https://www.elastic.co/guide/en/beats/filebeat/7.x/configuration-template.html
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub https://github.com/molu8bits/modsecurity-filebeat-kibana/issues/6#issuecomment-668215361 , or unsubscribe https://github.com/notifications/unsubscribe-auth/AQORCIWYOM6JRPPC37CJL7TR64J2HANCNFSM4POPXONA .  https://github.com/notifications/beacon/AQORCISLMPGBOV762JCGT3LR64J2HA5CNFSM4POPXONKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOE7KCQQI.gif
--
Este correo electrónico ha sido comprobado en busca de virus por AVG.
http://www.avg.com


Encoding Error in Win10 Debian subsystem

I try to get the script running under a Debian subsystem running below Win10. I sadly get this error and have no idea what to do about.
Backing up to: /mnt/c/temp/trello_bkup/test/
Incremental: False
Tokenize: False
Backup my boards: True
Backup organization boards: False
Backup closed board: False
Backup archived lists: False
Backup archived cards: False
Attachment size limit (bytes): 100000000
Saving full json for board Essensplan with id ******************* to Essensplan_full.json
Traceback (most recent call last):
File "/usr/local/bin/trello-full-backup", line 11, in
sys.exit(main())
File "/usr/local/lib/python3.5/dist-packages/trello_full_backup/init.py", line 5, in main
cli()
File "/usr/local/lib/python3.5/dist-packages/trello_full_backup/backup.py", line 318, in cli
backup_board(board, args)
File "/usr/local/lib/python3.5/dist-packages/trello_full_backup/backup.py", line 175, in backup_board
backup_card(id_card, c, args.attachment_size, tokenize)
File "/usr/local/lib/python3.5/dist-packages/trello_full_backup/backup.py", line 111, in backup_card
mkdir(card_name)
File "/usr/local/lib/python3.5/dist-packages/trello_full_backup/backup.py", line 27, in mkdir
if not os.access(name, os.R_OK):
UnicodeEncodeError: 'ascii' codec can't encode character '\xfc' in position 5: ordinal not in range(128)

Thanks for the report.
It looks like an encoding issue. Would it be possible to try on Win10 directly (outside of the Debian subsystem)?

Easy said... Is there any native way to run under Windows 10? Trying to install Docker directly on Win10 required Hyper-V, screwing up the Juniper VPN Setup... Also a CR regarding the Local Firewalls is required on IT supplier site^^  - If there is no native way, I would sadly say it is not possible to test :(

OK, finally done. With PIP for Win10 I've managed to get it running.
Some characters like " are still causing problems when used in Trello Headlines while not being escaped, but the Option -t solves this.
Apart from this: A really great tool! Thanks, man. I just need to test to restore some stuff now ;)

i am getting encoding error in windows 10
Traceback (most recent call last):   File "c:\anaconda3\lib\runpy.py", line 193, in _run_module_as_main     "__main__", mod_spec)   File "c:\anaconda3\lib\runpy.py", line 85, in _run_code     exec(code, run_globals)   File "C:\anaconda3\scripts\trello-full-backup.exe\__main__.py", line 7, in <module>   File "c:\anaconda3\lib\site-packages\trello_full_backup\__init__.py", line 5, in main     cli()   File "c:\anaconda3\lib\site-packages\trello_full_backup\backup.py", line 318, in cli     backup_board(board, args)   File "c:\anaconda3\lib\site-packages\trello_full_backup\backup.py", line 175, in backup_board     backup_card(id_card, c, args.attachment_size, tokenize)   File "c:\anaconda3\lib\site-packages\trello_full_backup\backup.py", line 119, in backup_card     print('Saving', card_name)   File "c:\anaconda3\lib\encodings\cp1252.py", line 19, in encode     return codecs.charmap_encode(input,self.errors,encoding_table)[0] UnicodeEncodeError: 'charmap' codec can't encode characters in position 2-4: character maps to <undefined>

the above is from bash. from cmd i am seeing:
Traceback (most recent call last):   File "c:\anaconda3\lib\runpy.py", line 193, in _run_module_as_main     "__main__", mod_spec)   File "c:\anaconda3\lib\runpy.py", line 85, in _run_code     exec(code, run_globals)   File "c:\anaconda3\scripts\trello-full-backup.exe\__main__.py", line 7, in <module>   File "c:\anaconda3\lib\site-packages\trello_full_backup\__init__.py", line 5, in main     cli()   File "c:\anaconda3\lib\site-packages\trello_full_backup\backup.py", line 302, in cli     org_boards_data['me'] = requests.get(my_boards_url).json()   File "c:\anaconda3\lib\site-packages\requests\models.py", line 898, in json     return complexjson.loads(self.text, **kwargs)   File "c:\anaconda3\lib\json\__init__.py", line 354, in loads     return _default_decoder.decode(s)   File "c:\anaconda3\lib\json\decoder.py", line 339, in decode     obj, end = self.raw_decode(s, idx=_w(s, 0).end())   File "c:\anaconda3\lib\json\decoder.py", line 357, in raw_decode     raise JSONDecodeError("Expecting value", s, err.value) from None json.decoder.JSONDecodeError: Expecting value: line 1 column 1 (char 0)


Postgres dialect parse password with spaces (#775)

Fixes #775 This fixes two problems - the postgres dialect can parse a password with spaces. If an error occurs the Parse func returns an error instead of panicking.
There are some problems still however:

The Parse function cannot handle symbols like # in a password but we handle that in Grafana (where I found this bug) by escaping everything before creating the connection string.

The code seems to be based on code from pq from 5 year ago. The current version of pq does a lot more checks when parsing connection strings to handle all these cases - see this PR that fixed the panic problem in pq.

Working on fixing the coverage tests - not sure exactly why are failing yet.

Aha, was a little too aggressive with removing code. Needs to be able to parse opts and not just urls.

Codecov Report

Merging #779 into master will decrease coverage by 3.02%.
The diff coverage is 88.88%.

@@            Coverage Diff             @@
##           master     #779      +/-   ##
==========================================
- Coverage   51.37%   48.35%   -3.03%
==========================================
  Files          39       39
  Lines        8605     8568      -37
==========================================
- Hits         4421     4143     -278
- Misses       3693     3945     +252
+ Partials      491      480      -11

Impacted Files
Coverage Δ

dialect_postgres.go
6.93% <88.88%> (-59.25%)
:arrow_down:

logger.go
55.69% <0%> (-6.33%)
:arrow_down:

session_insert.go
51.5% <0%> (-6.27%)
:arrow_down:

session_raw.go
53.79% <0%> (-4.14%)
:arrow_down:

xorm.go
63.38% <0%> (-2.82%)
:arrow_down:

session_update.go
49.37% <0%> (-2.8%)
:arrow_down:

session_query.go
57.05% <0%> (-2.36%)
:arrow_down:

session.go
53.06% <0%> (-2%)
:arrow_down:

convert.go
25.88% <0%> (-1.78%)
:arrow_down:

... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4e88774...ff790bc. Read the comment docs.

@lunny Changes made. Is that what you were thinking?

@daniellee yes and merged.


Issues with helm repo add

Hi Team,
I was trying to use the dkron helm chart to install in my local k8s cluster. However I am encountering the following error while trying to add the repo:
helm repo add dkron https://github.com/distribworks/dkron-helm/dkron
Error: looks like "https://github.com/distribworks/dkron-helm/dkron" is not a valid chart repository or cannot be reached: failed to fetch https://github.com/distribworks/dkron-helm/dkron/index.yaml : 404 Not Found

Can someone please help how do I use the dkron-helm to install dkron in my K8s cluster?
Thanks.

This won't work without the package in the repository AFAIK
I just packaged and pushed it to the repo.
You can install like: helm repo add dkron https://raw.githubusercontent.com/distribworks/dkron-helm/master


WIP: Dev/add windows cmd support

Depends on #384 to be merged.
Integration test are still missing.

Will reopen using the draft feature


[Snyk] Security upgrade grpcio from 1.41.1 to 1.53.2

This PR was automatically created by Snyk using the credentials of a real user.Snyk has created this PR to fix one or more vulnerable packages in the `pip` dependencies of this project.
Changes included in this PR

Changes to the following files to upgrade the vulnerable dependencies to a fixed version:

cmd/suggestion/nas/darts/v1beta1/requirements.txt

Vulnerabilities that will be fixed
By pinning:

Severity
Priority Score (*)
Issue
Upgrade
Breaking Change
Exploit Maturity

661/1000  Why? Recently disclosed, Has a fix available, CVSS 7.5
Excessive Iteration SNYK-PYTHON-GRPCIO-5834443
grpcio:  1.41.1 -> 1.53.2
No
No Known Exploit

(*) Note that the real score may have changed since the PR was raised.
Some vulnerabilities couldn't be fully fixed and so Snyk will still find them when the project is tested again. This may be because the vulnerability existed within more than one direct dependency, but not all of the affected dependencies could be upgraded.
Check the changes in this PR to ensure they won't cause issues with your project.

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.
For more information:
🧐 View latest project report
🛠 Adjust project settings
📚 Read more about Snyk's upgrade and patch logic

Learn how to fix vulnerabilities with free interactive lessons:
🦉 Learn about vulnerability in an interactive lesson of Snyk Learn.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 72.857%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
3111

Relevant Lines:
4270

💛  - Coveralls


primitives with gate body connection

Added primitives with gate body connections. Primitives name are Switch_GB_NMOS and Switch_GB_PMOS

This will resolve issue #533


Delay is capped at 1.5 second without mention

Thanks for fortio, which I'm using to compare stacks - it's a great tool!
Something took me a bit by surprise, which is that the delay parameter is set to 1.5 second if I put it to anything higher.
The code seems to confirm that:

https://github.com/istio/fortio/blob/cdb21807bcf3b2b83b94aba311d1a58d5c4ea311/fhttp/http_utils.go#L345
https://github.com/istio/fortio/blob/cdb21807bcf3b2b83b94aba311d1a58d5c4ea311/fhttp/http_utils.go#L364

I think having an error instead of capping out would be less surprising (just my opinion!).

yes the problem is how to communicate a warning clearly / noticeably
i guess we should make that max a flag. the reason for the relatively low current max is that it’s easy to clog up a server with a lot of waiting go routines with a large delay

@ldemailly thanks for the input! Just FWIW, I'm using this flag to simulate slow responding services (I'm benchmarking systems who talk to such slow responding services), so having something that follows the delay (rather than just a max flag) is really helpful to test out this type of scenario! (I guess it's more a side-feature though!).

note that you can easily change that max yourself in the meantime
I don’t get why a flag for max would not work for you? (you could start a server with a max of say 1h or whichever very large maximum you would wish)


Doc/simplify browser esm parcel

A PR to update the Browser ESM Parcel sample as per: https://github.com/microsoft/monaco-editor/issues/2823#issuecomment-993706028

Thank you for this PR!
It would be awesome if you could add .idea/ to the ignore file in a separate PR though, so that the history reads nicely.

Ok, I can do that later today 🙂
On Wed, Dec 15, 2021, 5:14 AM Henning Dieterichs @.***>
wrote:

Thank you for this PR!
It would be awesome if you could add .idea/ to the ignore file in a
separate PR though, so that the history reads nicely.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/microsoft/monaco-editor/pull/2829#issuecomment-994624025,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AACXAF7L2IRKHCYRUSWA2OTURBTB7ANCNFSM5KCM3LIQ
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

Closing in favor of a cleaner PR.

Here's also a trick I use a lot in case I ever want to ignore a folder completely in a git repository without touching the top level .gitignore: just add a .gitignore file in the folder you want completely ignored with the content *.

Whoa! Brilliant!
On Wed, Dec 15, 2021, 11:40 AM Alexandru Dima @.***>
wrote:

Here's also a trick I use a lot in case I ever want to ignore a folder
completely in a git repository without touching the top level .gitignore:
just add a .gitignore file in the folder you want completely ignored with
the content *.
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
https://github.com/microsoft/monaco-editor/pull/2829#issuecomment-994965805,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AACXAFZFGBJT4NNH5DTCWYTURDAH3ANCNFSM5KCM3LIQ
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.


Adds github action for linktesting

Signed-off-by: Robert Fekete<EMAIL_ADDRESS>

@fekete-robert this looks like it's working now. Lets fix these links and merge this as well as it is super useful

@csatib02 @akijakya if you have some free capacity to push this PR to the end, please do. we only need to make sure the CI is passing. we can discard other changes if needed


[TC-218] CRUD Users - Self-Service

Allow customer (admin roles only) to CRUD users.
1. Creator gets to choose tenant assignment based on any available tenant to the user, default will be for same tenant as the creator.
2. Creator can sets role for user, default is read only.
Author: Ashish Timilsina
JIRA Link: https://issues.apache.org/jira/browse/TC-218
Found Version: 2.1.0

duplicate of #1267


SQFormDialogStepper Add ability to disable submit/next button programmatically

As a user of the stepper
I want to be able to disable the next/submit button until an API call or some other function occurs outside of the Formik context
So that I can stop users from going forward to the next step or submitting.

:tada: This issue has been resolved in version 3.1.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Array rotate optimization

fixes https://github.com/crystal-lang/crystal/issues/8515
Add special case for array rotate to optimize for small arrays.
Looks like the for size 3, 100 the new rotate is faster and 10, 32 the old rotate is faster.  I dont know why.
require "benchmark"

x3 = Array(Int32).new(3){|i| i}
x10 = Array(Int32).new(10){|i| i}
x32 = Array(Int32).new(32){|i| i}
x100 = Array(Int32).new(100){|i| i}

GC.disable

Benchmark.ips do |x|
  x.report("3 rotate! 2") { x3.rotate!(2) }
  x.report("3 new_rotate! 2") { x3.new_rotate!(2) }
end
Benchmark.ips do |x|
  x.report("10 rotate! 2") { x10.rotate!(2) }
  x.report("10 new_rotate! 2") { x10.new_rotate!(2) }
end
Benchmark.ips do |x|
  x.report("32 rotate! 2") { x32.rotate!(2) }
  x.report("32 new_rotate! 2") { x32.new_rotate!(2) }
end
Benchmark.ips do |x|
  x.report("100 rotate! 2") { x100.rotate!(2) }
  x.report("100 new_rotate! 2") { x100.new_rotate!(2) }
end

$ crystal tmp.cr --release
    3 rotate! 2  18.07M ( 55.33ns) (± 5.25%)  48.0B/op   1.00× slower
3 new_rotate! 2  18.12M ( 55.20ns) (± 5.39%)   0.0B/op        fastest
    10 rotate! 2  18.38M ( 54.40ns) (± 5.02%)  48.0B/op        fastest
10 new_rotate! 2  18.18M ( 55.01ns) (± 3.26%)   0.0B/op   1.01× slower
    32 rotate! 2  17.93M ( 55.77ns) (± 5.47%)  48.0B/op        fastest
32 new_rotate! 2  17.87M ( 55.98ns) (± 4.70%)   0.0B/op   1.00× slower
    100 rotate! 2  15.36M ( 65.12ns) (± 9.45%)  48.0B/op   1.10× slower
100 new_rotate! 2  16.87M ( 59.29ns) (± 7.10%)   0.0B/op        fastest

Thank you! What happens if you remove GC.disable from the benchmark? I don't think that's something one should do in benchmarks because you do want to take into account the time it takes for the GC to claim memory.

@asterite looks like the only one that is faster without the GC is an array of 3.
    3 rotate! 2  17.85M ( 56.03ns) (± 3.01%)  48.0B/op   1.03× slower
3 new_rotate! 2  18.47M ( 54.14ns) (± 4.08%)   0.0B/op        fastest
    10 rotate! 2  19.00M ( 52.63ns) (± 1.90%)  48.0B/op        fastest
10 new_rotate! 2  18.53M ( 53.96ns) (± 4.80%)   0.0B/op   1.03× slower
    32 rotate! 2  18.32M ( 54.59ns) (± 1.78%)  48.0B/op        fastest
32 new_rotate! 2  18.09M ( 55.27ns) (± 2.54%)   0.0B/op   1.01× slower
    100 rotate! 2  18.09M ( 55.27ns) (± 1.13%)  48.0B/op        fastest
100 new_rotate! 2  16.72M ( 59.80ns) (± 5.26%)   0.0B/op   1.08× slower

@asterite I filled the rest of the array with filler.  Looks like we are faster in all cases now.
 crystal tmp.cr --release
    3 rotate! 2  18.27M ( 54.72ns) (± 1.80%)  48.0B/op   4.04× slower
3 new_rotate! 2  73.80M ( 13.55ns) (± 4.04%)   0.0B/op        fastest
    10 rotate! 2  19.47M ( 51.37ns) (± 3.52%)  48.0B/op   4.14× slower
10 new_rotate! 2  80.55M ( 12.41ns) (± 3.68%)   0.0B/op        fastest
    32 rotate! 2  18.42M ( 54.29ns) (± 2.21%)  48.0B/op   3.23× slower
32 new_rotate! 2  59.41M ( 16.83ns) (±10.28%)   0.0B/op        fastest
    100 rotate! 2  18.05M ( 55.41ns) (± 1.35%)  48.0B/op   2.99× slower
100 new_rotate! 2  54.05M ( 18.50ns) (± 4.67%)   0.0B/op        fastest

With the uninitialized StaticArray size 3 is a little slower but faster then now.  And the rest are more performant.
$ crystal tmp.cr --release
    3 rotate! 2  17.06M ( 58.60ns) (± 4.18%)  48.0B/op   3.19× slower
3 new_rotate! 2  54.51M ( 18.35ns) (± 3.32%)   0.0B/op        fastest
    10 rotate! 2  18.17M ( 55.05ns) (± 2.08%)  48.0B/op   4.00× slower
10 new_rotate! 2  72.64M ( 13.77ns) (± 3.57%)   0.0B/op        fastest
    32 rotate! 2  17.10M ( 58.49ns) (± 2.52%)  48.0B/op   3.36× slower
32 new_rotate! 2  57.40M ( 17.42ns) (± 9.59%)   0.0B/op        fastest
    100 rotate! 2  16.75M ( 59.70ns) (± 1.49%)  48.0B/op   3.21× slower
100 new_rotate! 2  53.79M ( 18.59ns) (± 3.54%)   0.0B/op        fastest

using case is even a little faster except for size 32 I have no idea why I thought llvm would basically optimize these to be the same.
$ crystal tmp.cr --release
        3 rotate! 2  16.82M ( 59.44ns) (± 2.68%)  48.0B/op   3.69× slower
    3 new_rotate! 2  53.14M ( 18.82ns) (± 4.53%)   0.0B/op   1.17× slower
3 new_new_rotate! 2  62.16M ( 16.09ns) (± 4.54%)   0.0B/op        fastest
        10 rotate! 2  17.66M ( 56.64ns) (± 3.26%)  48.0B/op   4.01× slower
    10 new_rotate! 2  67.39M ( 14.84ns) (± 4.85%)   0.0B/op   1.05× slower
10 new_new_rotate! 2  70.79M ( 14.13ns) (± 4.88%)   0.0B/op        fastest
        32 rotate! 2  16.98M ( 58.89ns) (± 1.94%)  48.0B/op   3.35× slower
    32 new_rotate! 2  56.86M ( 17.59ns) (± 9.36%)   0.0B/op        fastest
32 new_new_rotate! 2  55.90M ( 17.89ns) (± 8.69%)   0.0B/op   1.02× slower
        100 rotate! 2  16.35M ( 61.18ns) (± 2.49%)  48.0B/op   3.28× slower
    100 new_rotate! 2  51.34M ( 19.48ns) (± 7.49%)   0.0B/op   1.04× slower
100 new_new_rotate! 2  53.57M ( 18.67ns) (± 4.99%)   0.0B/op        fastest

please wait before merging I am almost done with implementing an in place transformation.

@asterite and @sdogruyol this is ready to merge :)
I added a few more test but was unable to do an in place rotate and have it be more performant then the current solution.

There's actually another optimization we can do, if we really want to squeeze all we can from this method.
It seems that when the size of the array is 9 or less, the reversal algorithm works faster than doing a bunch of memcpy.
The logic is this:
Slice.new(to_unsafe, size).reverse!
Slice.new(to_unsafe + size - n, n).reverse!
Slice.new(to_unsafe, size - n).reverse!

We should do that if size <= 9, so we could put that condition after if n == 0. Actually, my benchmarks seems to show that it's faster when (n == 1 && size <= 7) || size <= 9 but I don't know if we'd like it to be that specific... so maybe if size <= 8 is good enough. Or maybe just leave this PR like that, though the difference is significant in some cases (1.28x faster).

I think we can apply reversal algorithm into this PR. In my benchmark, the reversal algorithm performs better when rotate distance is close to (N/2). If array is large, it would allocate large memory to do rotation. This will degrade performance. Hence, the rotate logic could be:
if rotate_distance == 0
  # ignore
else rotate_distance <= SMALL_SIZE
  # stack-based copy algorithm
else
  # reversal algorithm
end

@firejox I benchmark Ed the existing code against the reversal algorithm and for some reason the existing code was faster for large arrays. You could maybe try to create a benchmark and see if you get the same results.

@asterite  I think you're right. My benchmark result shows that the reversal algorithm is slower than existing code for large array.  But still, the reversal algorithm could be useful in some place.
Benchmark when rotate n/3 elements
    10 rotate! 3   7.57M (132.04ns) (± 8.60%)  65.0B/op   3.30× slower
10 new_rotate! 3  25.00M ( 40.01ns) (± 3.27%)   0.0B/op        fastest
    100 rotate! 33   1.44M (694.30ns) (± 1.45%)  177B/op   5.42× slower
100 new_rotate! 33   7.80M (128.21ns) (± 6.13%)  0.0B/op        fastest
    1000 rotate! 333 281.39k (  3.55µs) (± 2.32%)  2.03kB/op   4.03× slower
1000 new_rotate! 333   1.13M (881.35ns) (± 5.50%)    0.0B/op        fastest
    10000 rotate! 3333  48.39k ( 20.66µs) (± 1.84%)  13.1kB/op   2.31× slower
10000 new_rotate! 3333 111.98k (  8.93µs) (± 7.41%)    0.0B/op        fastest
    100000 rotate! 33333   5.74k (174.22µs) (± 1.01%)  130kB/op   1.75× slower
100000 new_rotate! 33333  10.02k ( 99.83µs) (± 6.07%)   0.0B/op        fastest
    1000000 rotate! 333333 496.68  (  2.01ms) (± 0.92%)  1.27MB/op        fastest
1000000 new_rotate! 333333 492.28  (  2.03ms) (± 2.31%)    0.0B/op   1.01× slower
    10000000 rotate! 3333333  55.13  ( 18.14ms) (± 0.90%)  12.7MB/op        fastest
10000000 new_rotate! 3333333  49.70  ( 20.12ms) (± 2.67%)    0.0B/op   1.11× slower

Besides, I found another in-place algorithm that has nice performance. It is complicate but perform well. The code is in here. And the benchmark is the following.
Benchmark when rotate n/3 elements
        10 rotate! 3   7.80M (128.28ns) (± 8.15%)  65.0B/op   3.23× slower
    10 new_rotate! 3  25.17M ( 39.73ns) (± 3.33%)   0.0B/op        fastest
10 new_new_rotate! 3  24.89M ( 40.18ns) (± 3.75%)   0.0B/op   1.01× slower
        100 rotate! 33   1.36M (733.62ns) (± 2.83%)  177B/op   5.59× slower
    100 new_rotate! 33   7.62M (131.32ns) (± 2.79%)  0.0B/op        fastest
100 new_new_rotate! 33   7.09M (140.99ns) (± 2.96%)  0.0B/op   1.07× slower
        1000 rotate! 333 344.30k (  2.90µs) (± 1.80%)  1.35kB/op   3.16× slower
    1000 new_rotate! 333   1.08M (929.08ns) (± 2.13%)    0.0B/op   1.01× slower
1000 new_new_rotate! 333   1.09M (918.57ns) (± 0.63%)    0.0B/op        fastest
        10000 rotate! 3333  50.05k ( 19.98µs) (± 2.26%)  13.1kB/op   2.28× slower
    10000 new_rotate! 3333 109.90k (  9.10µs) (± 9.55%)    0.0B/op   1.04× slower
10000 new_new_rotate! 3333 114.09k (  8.77µs) (± 2.37%)    0.0B/op        fastest
        100000 rotate! 33333   5.67k (176.36µs) (± 2.06%)  130kB/op   1.80× slower
    100000 new_rotate! 33333  10.21k ( 97.90µs) (± 2.89%)   0.0B/op        fastest
100000 new_new_rotate! 33333   9.97k (100.31µs) (± 3.62%)   0.0B/op   1.02× slower
        1000000 rotate! 333333 501.28  (  1.99ms) (± 1.23%)  1.27MB/op   1.12× slower
    1000000 new_rotate! 333333 513.57  (  1.95ms) (± 1.35%)    0.0B/op   1.09× slower
1000000 new_new_rotate! 333333 559.62  (  1.79ms) (± 2.25%)    0.0B/op        fastest
        10000000 rotate! 3333333  55.62  ( 17.98ms) (± 1.29%)  12.7MB/op        fastest
    10000000 new_rotate! 3333333  50.82  ( 19.68ms) (± 1.51%)    0.0B/op   1.09× slower
10000000 new_new_rotate! 3333333  55.15  ( 18.13ms) (± 1.60%)    0.0B/op   1.01× slower

@firejox I was using memcopy and could not get this to work.  I love that you figured it out.  I would be interested in seeing if we could speed this up by using the static array in some places and moving things in blocks.

Is this something that could make it in to 0.33 coming up?

@jwoertink there was some back and forth on this.
I don't know what is really blocking this.

For example, there was no response on the last review question: https://github.com/crystal-lang/crystal/pull/8516#discussion_r356364894
@jwoertink Since this is just an optimization, there's really no pressure to put this into 0.33.0

Is there anything else needed to merge this?

The discussion above seems unresolved too.

@firejox Could you please review this PR?  If you have a proposal to this PR from this https://github.com/crystal-lang/crystal/pull/8516#issuecomment-561963769 I would love to see it.


css improvement of quick send page

Back & Next button is not middle aligned with left & right arrow .
Chrome browser, Version 60.0.3112.101 (Official Build) (64-bit)

My chrome 60.0 display normally. I'm using windows 7. @tranvictor Can you check in OS X?

Yes, I'm using Mac.

@andrewsource it is not normal in Safari Mac.


Microsoft.AspNetCore.Diagnostics.EntityFrameworkCore install fails

When I used package manager console to install:
"Microsoft.AspNetCore.Diagnostics.EntityFrameworkCore",
it tried to install version 7.  Since this is in .Net 6 framework it fails as incompatible.
I ended up copying the package manager command from Nuget.org for version 6.0.12.
It installs ok.
I haven't finished the page tutorial yet though.  I am on the Create a Database section.
I'm pretty sure it will work though.

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 7a54c97f-ddd4-b041-5e5f-a2df009ace50
Version Independent ID: fa488196-1f98-08ea-adcc-17d9dac86727
Content: Razor Pages with Entity Framework Core in ASP.NET Core - Tutorial 1 of 8
Content Source: aspnetcore/data/ef-rp/intro.md
Product: aspnet-core
Technology: aspnetcore-data
GitHub Login: @Rick-Anderson
Microsoft Alias: riande

If your TFM is 7, it will install 7

I also get this error same as @smiller7812  and I have net6.0 in my .csproj file.

It's because the tutorial has us use .Net 6.0 as the framework to target instead of seven since it has not been updated.  So when you install with the Install-Package command in the tutorial with no version specified it will get the latest.
I go to nuget.org, search for "Microsoft.AspNetCore.Diagnostics.EntityFrameworkCore",  click the package manager tab.  There is a versions button where you can get the latest 6.X.X version. Click the copy button and plug it into Visual Studio Package Manager console.

From: Anro95 @.>
Sent: Wednesday, December 28, 2022 6:37 AM
To: dotnet/AspNetCore.Docs @.>
Cc: smiller7812 @.>; Mention @.>
Subject: Re: [dotnet/AspNetCore.Docs] Microsoft.AspNetCore.Diagnostics.EntityFrameworkCore install fails (Issue #27969)
I also get this error same as @smiller7812https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fsmiller7812&data=05|01||e401dff0e9864f54289e08dae8c7e887|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|638078242555961615|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000|||&sdata=2dZAPz6uVQUt%2FU3z5E8SUkg1odUDAYWZVpLar%2FaNU6o%3D&reserved=0 and I have net6.0 in my .csproj file.
—
Reply to this email directly, view it on GitHubhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fdotnet%2FAspNetCore.Docs%2Fissues%2F27969%23issuecomment-1366586756&data=05|01||e401dff0e9864f54289e08dae8c7e887|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|638078242555961615|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000|||&sdata=qZEisEsHT2k9FgB9LEAtEppWNqa%2Fp%2BHV9TtWJl8YwaI%3D&reserved=0, or unsubscribehttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAM4QAHCQ2M26WANQOBUOQILWPQQ7XANCNFSM6AAAAAATJAY3VY&data=05|01||e401dff0e9864f54289e08dae8c7e887|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|638078242555961615|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000|||&sdata=8%2B71dHovCwvxBO8u%2FeUCurAu5Bg4wDN1cjVsym4dlBs%3D&reserved=0.
You are receiving this because you were mentioned.Message ID: @.***>

I also get this error same as @smiller7812 and I have  <TargetFramework>net6.0</TargetFramework> in my .csproj file.

Then you'll get the .NET 6 version.
Perhaps you had a transient error and need to try again.

I don't get the ,Net 6 version... I have to explicitly install it!
I use VS 2022 to create razor project. I get the TargetFramework=net6.0. I follow tutorial and run this in Package Manager Console:
Install-Package Microsoft.AspNetCore.Diagnostics.EntityFrameworkCore
I then get this errormessage: "NU1202: Package Microsoft.AspNetCore.Diagnostics.EntityFrameworkCore 7.0.1 is not compatible with net6.0..."
I solve it by using smiller7812's solution to run this in Package Manager Console:
NuGet\Install-Package Microsoft.AspNetCore.Diagnostics.EntityFrameworkCore -Version 6.0.12
It installs and works. Problem solved!


Fix for texture added to not color groups

Questions
Answers

Branch?
develop

Description?
allow to setProperty('color') only for color or textures factets

Type?
bug fix

Category?
FO

BC breaks?
yes or no ?

Deprecations?
yes or no ?

Fixed ticket?
BOOM-3454

How to test?
before fix attributes in facated search are treated as color options so they design is bad

This change is

Hello @iqit-commerce, can you please edit the top comment to fill the missing descriptions in the table ?
This is important for our reports and changelogs

Reviewed 1 of 1 files at r1.
Review status: all files reviewed at latest revision, 2 unresolved discussions.

src/Ps_FacetedsearchFiltersConverter.php, line 43 at r1 (raw file):

                            ->setValue($id)
                        ;

Trailing white spaces should be removed. Including for the blank lines.

src/Ps_FacetedsearchFiltersConverter.php, line 52 at r1 (raw file):

                            }
                        }

Trailing white spaces should be removed. Including for the blank lines.

Comments from Reviewable

Ping @iqit-commerce

Reviewed 1 of 1 files at r2.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable

@iqit-commerce Can you explain what do you solve and complete the fields "Description" & "How to test?"
Thanks !

Thank you @LittleBigDev for fixing commit!
@marionf Everthing is in ticket, in short facated search handled non color attributes as color attributes becouse it was setting property color for each of facets

@iqit-commerce Yes if you choose for your attribute color/texture, it's considered like this even if you don't choose any color or upload texture.
If you don't choose any color or don't upload a texture, you shouldn't select color/texture but rather drop down or radio button.

@marionf Of course i know that, problem is that if you choose dropdown attribute, and then in facated search you want to show is as checkbox, then you get bad display becouse attributes is treated as color and this PR fix that

@iqit-commerce

I create a dropdown attribute

I create 3 values

I choose checkbox for this attribute in faceted module

I don't see bad display in FO

@marionf In last 2 months i have around 2-4 customers with such issue per week. I'm developer of popular theme and and a lot of people contact with me. Issue looks like
https://ticksy_attachments.s3.amazonaws.com/Captura%20de%20pantalla%202017-10-22%20a%20la(s)%205.25.48%20p.m._770.png
And for both attibutes types is set as dropdown, and as you can see on screenshot some value of attribute looks fine when other not. I know it is not screenshot from classic theme but when I was fixing this issue i switched to classic and there was same issue
I do not know maybe issue comes becosue customers imported their attribues, but attribute type was set as dropdown

@marionf Ohh i found a way how to reproduce that

create color attribute with type color, add some colors attributes
then you decide you do not want to have this colors as color picker, so you change this attribute typ to dropdown
on product page attribute is now visible as dropdown
on facated search attribute is still visible as color picker

So there is issue, and this PR fix it, becouse it check if type of group is color grup, then it add properties, without this check attributes which were in past as color type even if they are changed to dropdown type still contains color information in db that's why facated searchs how them as color becouse without fix it is just checkif if color or texture url exist

@iqit-commerce Thank you for these details, I can reproduce the issue and your PR solve it, so let's merge it !

🎉

@marionf Great, thank you!

Thank you all :)


Report appear sometimes in github page and not appear all times

We are using test-reporter for generating report in github pages. When we execute sometimes report appears in github page and sometimes it is not appear. When we check checkrun details reprort is available in the Summary of step with checkrun html
Kindly help to resolve issue.
  - name: QE Test Report
    uses: ***/test-reporter@0d00bb14cb0cc2c9b8985df6e81dd333188224e1
    if: success() || failure()
    with:
      name: Test Report            # Name of the check run which will be created
      path: |
        ${{ github.workspace }}/test/test_output/**/*.xml
      reporter: java-junit
      list-tests: 'all'
      fail-on-error: 'false'

Hello,
I'm facing with the same behavior in my repository.
Here is my step to generate report:
- name: Test Report         id: reporter         continue-on-error: true         uses: dorny/test-reporter@v1         if: always()         with:           fail-on-error: 'false'           name: Test Results Report           path: ${{ github.workspace }}/results/mytests.trx           reporter: dotnet-trx


crashing when writing a 1MB file after reaching the size of two blocks

Hello, so i'm working with littlefs on an STM32L4 QSPI device . At first, primary tests are fine everything is working as intended so i wanted to push it a little further and play with larger files.
I'm trying to write a 1MB image into my QSPI but in the middle of the process i'm having a crash, here is my call stack :

I tried to change my configuration ( block_size) several times and did some tests i noticed that my file size can't exceed the size of two blocks when reaching it i get that crash. I can't figure out why i'm having this strange behavior.
Thank you for your help.

Did you verified this assert? This can help you to debug it.

Hello @lsilvaalmeida  and thank you for your reply.
Here's the assert that fails  :
LFS_ASSERT(head >= 2 && head <= lfs->cfg->block_count)
which is located in :
lfs_ctz_extend  function
when it fails head value is<PHONE_NUMBER> , block_count 256 , i guess something is wrong with that head value .
any suggestions?

This means that your head is pointing to -1<PHONE_NUMBER> = 0xFFFFFFFF), which is strange. Try to see if head has this value even at the beginning of this call or where this changes his value.
Furthermore, which are your cache and block sizes?

Hello @lsilvaalmeida  Sorry for the late reponse.
my cache_size is 256
block_size 32768 ( 0x8000 )
head value is becoming strange only when reaching the size of two blocks , here is a screenshot showing where it is changing  :

It's after going out of the lfs_bd_read function head value takes<PHONE_NUMBER> so i tried to follow where it's changing in lfs_bd_read but i didn't find any operation that can do that in this function it's just after the return that head takes that value, even after head = lfs_fromle32(head) it dosen't change.
I have to mention that if i increase the block size which makes  my file_size < 2*block_size  everything is fine it crashes only when my file_size is superior to the size of two blocks.

While checking if i can find a related issue i guess i found one #6
I tried the solution proposed, changed lfs_ctz, lfs_popc, lfs_npw2 implementation but the problem persists. I'm using SW4STM32 compiler.

I'm using FatFs to read an image 1MB from an sdcard and then write it on the QSPI using littlefs.
can it be related to FatFs causing this strange behavior ?

It's not caused by FatFs, well i'm trying to write a large file using a for loop (no FatFs here) , it's crashing but not in the head assert ,  it's also in lfs_ctz_extend function but just before the head assert when going in the lfs_bd_read my user_read function is returning an error ( after a timeout in the qspi driver)
when the crash happens block =<PHONE_NUMBER> ( same value as head before) .
Increasing cashe_size and block_size resolves the problem. Can't figure out what's causing this

Tested the same code but with littlefs v1.7 , working just fine ..
might be  something related to the cache_size and my QSPI driver.


Component: Masthead: On hover, the search and profile background color is different compared to the menu list.

Detailed description
Issue:- When user hover on search and profile icon, background color is lighter shape compared to menu and IBM logo background.
Additional information

@Praveen-sr @RobertaJHahn
https://github.com/carbon-design-system/ibm-dotcom-library/pull/2236


Migration fails at task['uuid'] = re.search(UUID_REGEX, stdout).group(0)

Do you recognize the reason for this error?

$ task --version
2.5.3

Task 2 of 135: * **Bugs**
tid:<PHONE_NUMBER>
name: * **Bugs**
project: Bag
priority:
tags:
entry: 2019-10-10T13:13:01+00:00
due:
recur:

Import this task? (y, n, d, t, P, p, r, q, ?): y
Importing '* **Bugs**' (Bag)... FAILED ('NoneType' object has no attribute 'group')
Traceback (most recent call last):
  File "/Users/senthilx/cpython-3.11/lib/python3.11/runpy.py", line 196, in _run_module_as_main
    return _run_code(code, main_globals, None,
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/senthilx/cpython-3.11/lib/python3.11/runpy.py", line 86, in _run_code
    exec(code, run_globals)
    ^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/senthilx/git/todist-taskwarrior2/todoist_taskwarrior/cli.py", line 372, in <module>
    cli()
    ^^^^^
  File "/Users/senthilx/venvs/cpython/lib/python3.11/site-packages/click/core.py", line 764, in __call__
    return self.main(*args, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/senthilx/venvs/cpython/lib/python3.11/site-packages/click/core.py", line 717, in main
    rv = self.invoke(ctx)
         ^^^^^^^^^^^^^^^^
  File "/Users/senthilx/venvs/cpython/lib/python3.11/site-packages/click/core.py", line 1137, in invoke
    return _process_result(sub_ctx.command.invoke(sub_ctx))
                           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/senthilx/venvs/cpython/lib/python3.11/site-packages/click/core.py", line 956, in invoke
    return ctx.invoke(self.callback, **ctx.params)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/senthilx/venvs/cpython/lib/python3.11/site-packages/click/core.py", line 555, in invoke
    return callback(*args, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/senthilx/venvs/cpython/lib/python3.11/site-packages/click/decorators.py", line 17, in new_func
    return f(get_current_context(), *args, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/senthilx/git/todist-taskwarrior2/todoist_taskwarrior/cli.py", line 215, in migrate
    add_task_interactive(**data)
    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/senthilx/git/todist-taskwarrior2/todoist_taskwarrior/cli.py", line 339, in add_task_interactive
    return add_task(**task_data)
           ^^^^^^^^^^^^^^^^^^^^^
  File "/Users/senthilx/git/todist-taskwarrior2/todoist_taskwarrior/cli.py", line 230, in add_task
    return taskwarrior.task_add(
           ^^^^^^^^^^^^^^^^^^^^^
  File "/Users/senthilx/venvs/cpython/lib/python3.11/site-packages/taskw/warrior.py", line 693, in task_add
    task['uuid'] = re.search(UUID_REGEX, stdout).group(0)
                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AttributeError: 'NoneType' object has no attribute 'group'

Hey @orsenthil
This originates from the taskw library and there appear to be two recent issues that relate to it: #144 and #146.
What happens here, is that the taskw library reads stdout and tries to parse out the uuid that the task cli generated. For whatever reason the uuid is not present in the output.
I think this is specific to taskwarrior 2.5.3 and was fixed in fixed in pull 147, but there hasn't been a release of taskw since then.
I have two ideas on how this might be fixed:
(1) The easiest for you would be to add verbose=new-uuid in your taskrc
(2) Otherwise, you can try to change the requirements.txt to point to the unreleased version and then install and re-run. But of course, as an unreleased version, it might still have bugs/regressions.
- # Temporarily use this until upstream PR #121 is merged
- # https://github.com/ralphbean/taskw/pull/121
- git+git://github.com/matt-snider/taskw.git@develop
+ git+git://github.com/ralphbean/taskw.git@develop

Let me know if you have some time to try that out

Hi @matt-snider , both these suggestions worked. I think, applying the patch to your repo will be good idea.

Non interactive migrate failed for me at 85th task. It might probably be a local task issue or API rate.
For the problem in the issue, your solution works. Thank you.


tracee: 0.13.0 -> 0.13.1

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/aquasecurity/tracee/releases.
meta.description for tracee is: Linux Runtime Security and Forensics using eBPF
meta.homepage for tracee is: https://aquasecurity.github.io/tracee/latest/
meta.changelog for tracee is: https://github.com/aquasecurity/tracee/releases/tag/v0.13.1
Updates performed

Golang update

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact

Checks done (click to expand)

built on NixOS
Warning: a test defined in passthru.tests did not pass
found 0.13.1 with grep in /nix/store/mgva59w0i8sy6dcwv8dpnspg9612dgjh-tracee-0.13.1
found 0.13.1 in filename of file in /nix/store/mgva59w0i8sy6dcwv8dpnspg9612dgjh-tracee-0.13.1

Rebuild report (if merged into master) (click to expand)

1 total rebuild path(s)

1 package rebuild(s)

First fifty rebuilds by attrpath
tracee

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/mgva59w0i8sy6dcwv8dpnspg9612dgjh-tracee-0.13.1 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A tracee https://github.com/r-ryantm/nixpkgs/archive/68e9d5dff81d584eb6210a142434c3c1eb51ea71.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/mgva59w0i8sy6dcwv8dpnspg9612dgjh-tracee-0.13.1
ls -la /nix/store/mgva59w0i8sy6dcwv8dpnspg9612dgjh-tracee-0.13.1/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

1 package built:

tracee

Maintainer pings
cc @06kellyjac for testing.

Result of nixpkgs-review pr 225737 run on x86_64-linux 1

1 package built:

tracee