Fix memory leak

I think the way you had it, you were initializing new variables and using more memory every time you iterated through the loop. I think that would cause a memory leak. This should achieve some slight memory improvements, also since err is being returned, we can set it during function initialization.
(Thank you for contributing to Caddy! Please fill this out to help us make the most of your pull request.)
1. What does this change do, exactly?
2. Please link to the relevant issues.
3. Which documentation changes (if any) need to be made because of this PR?
4. Checklist

[ ] I have written tests and verified that they fail without my change
[ ] I have squashed any insignificant commits
[ ] This change has comments for package types, values, functions, and non-obvious lines of code
[ ] I am willing to help maintain this change if there are issues with it later

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Thanks for clarifying, sorry about that.

I thought about this more, and wouldn't you allocate less memory just zeroing out the variables at the end of the loop and using a single instance of the variables instead of creating a set for each time through the loop? Gains would be dependent on the active number of servers and number of resets.

Not really, these are on the stack and the impact here is negligible. Try doing some profiling, you'll see what I mean.


msp430f2452 examples not run

Good day,
A few years ago I used the first version of the nrf24l01 + library in msp430G2452 without problems, but now with the new one it does not work, I have tried it with the G2231 and with the G2553 and it works very well, my IDE is the IAR. You could tell me if you tried it. Thank you.
ANDRÉS FELIPE RODRÍGUEZ

I do not use IAR and have no intention of supporting it.  Please use MSP430-GCC or the TI compiler.


Fix background correction for non-square images and online mode

This PR fixes background correction bugs for:

non-square cameras --- the load_bg function contained a bug that caused non-square images to apply a constant background correction instead of a pixel-wise background correction. This bug affected automaton and Yuming's setup (Oryx cameras), but not hummingbird which is why this bug slipped by previous tests.
online mode --- online results now match offline results in 'Estimated' and 'Measured + Estimated' modes. Currently, the online and offline modes use different section of the code for background correction, and this PR brings these sections into sync.

I tested these fixes on automaton, and I will merge after code review.
I'll test more thoroughly on hummingbird in advance of our 0.2.0 release.

Codecov Report

Merging #167 (5c8b539) into main (bb54f65) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main     #167      +/-   ##
==========================================
- Coverage   11.08%   11.06%   -0.02%
==========================================
  Files          44       44
  Lines        5965     5972       +7
==========================================
  Hits          661      661
- Misses       5304     5311       +7

Impacted Files
Coverage Δ

recOrder/io/utils.py
0.00% <0.00%> (ø)

recOrder/pipelines/qlipp_pipeline.py
0.00% <0.00%> (ø)

recOrder/plugin/widget/main_widget.py
0.00% <0.00%> (ø)

recOrder/plugin/workers/acquisition_workers.py
0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


Automatic line breaking

MathJax have an option for automatic linebreaking.
http://mathjax.readthedocs.org/en/latest/output.html#automatic-line-breaking
It is a very useful feature for small viewports and large expressions. Can I enable it somehow in MathView?

Hmm, I am not an expert in MathJax. Rather than providing a pre-configured version of MathJax, I choose to add another method config() to MathView in version 0.0.5.
Now you can try call
MathView.config(
"MathJax.Hub.Config({\n"+
            "  CommonHTML: { linebreaks: { automatic: true } },\n"+
            "  \"HTML-CSS\": { linebreaks: { automatic: true } },\n"+
            "         SVG: { linebreaks: { automatic: true } }\n"+
            "});");

before the setText() method to enable auto linebreaking. Please try upgrade to version 0.0.5 and see if this works for you!


ld warnings when upgrading to 1.9 on macOS

What version of Go are you using (go version)?
1.8.4 upgrading to 1.9.1
Does this issue reproduce with the latest release?
Yes
What operating system and processor architecture are you using (go env)?
GOARCH="amd64"
GOBIN=""
GOEXE=""
GOHOSTARCH="amd64"
GOHOSTOS="darwin"
GOOS="darwin"
GOPATH="/Users/buchanae"
GORACE=""
GOROOT="/usr/local/go"
GOTOOLDIR="/usr/local/go/pkg/tool/darwin_amd64"
GCCGO="gccgo"
CC="clang"
GOGCCFLAGS="-fPIC -m64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -fdebug-prefix-map=/var/folders/kw/m6dz8snx7h33ppbkbllnqt48bkhsqx/T/go-build472819290=/tmp/go-build -gno-record-gcc-switches -fno-common"
CXX="clang++"
CGO_ENABLED="1"
PKG_CONFIG="pkg-config"
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
OSX 10.11.6
What did you do?

uninstalled the existing version of Go (1.8.4) which I had installed via homebrew
downloaded 1.9.1 release tarball, installed as instructed
built a project (github.com/ohsu-comp-bio/funnel)
Got the following warnings during build. Build did appear to succeed:

ld: warning: object file (/var/folders/kw/m6dz8snx7h33ppbkbllnqt48bkhsqx/T/go-link-991847961/000000.o) was built for newer OSX version (10.11) than being linked (10.10)
ld: warning: object file (/var/folders/kw/m6dz8snx7h33ppbkbllnqt48bkhsqx/T/go-link-991847961/000001.o) was built for newer OSX version (10.11) than being linked (10.10)
ld: warning: object file (/var/folders/kw/m6dz8snx7h33ppbkbllnqt48bkhsqx/T/go-link-991847961/000003.o) was built for newer OSX version (10.11) than being linked (10.10)
ld: warning: object file (/var/folders/kw/m6dz8snx7h33ppbkbllnqt48bkhsqx/T/go-link-991847961/000004.o) was built for newer OSX version (10.11) than being linked (10.10)
ld: warning: object file (/var/folders/kw/m6dz8snx7h33ppbkbllnqt48bkhsqx/T/go-link-991847961/000005.o) was built for newer OSX version (10.11) than being linked (10.10)
ld: warning: object file (/var/folders/kw/m6dz8snx7h33ppbkbllnqt48bkhsqx/T/go-link-991847961/000006.o) was built for newer OSX version (10.11) than being linked (10.10)

Tried deleting directories in the warnings, thinking it was a cached object from an old build. No effect.
Tried using the 1.9.1 installer (instead of the tarball). No effect.
Downgraded to 1.8.4 (installed via installer) and the warnings went away.

The system linker was most likely always producing those warnings.  The change from Go 1.8 to 1.9 is that in 1.8 the Go linker would hide any warnings from the system linker, whereas in Go 1.9 the warnings are shown.  See #17935.
I don't know why you are getting those warnings, though.

I am experiencing the same issue on a OS X 10.10.5 system, after upgrading to Go1.9.2
The binaries that are built appear to work fine, so far.

I am now getting these warnings OS X 10.10.5 after upgrading to Go 1.10.0

I got this warning too on OSX Mojave 10.14 Beta after upgrading to golang 1.11.

Also seeing this after upgrading from 10.12 to 10.13.
ld: warning: object file (/var/folders/vh/1kdv9jt922ddgm0r9tprx3y80000gn/T/go-link-684600122/000000.o) was built for newer OSX version (10.13) than being linked (10.12)

Is this maybe related to some kind of cache that we can dump?

@cagedmantis this can be closed; progress is being tracked on #36025

Closing this issue since the associated work is being tracked in #36025.


Fixes #101

Update for 23-SNAPSHOT
Update to GradingService
Removing unused continueButton that gives an error in wicket debug mode

@ottenhoff This incorporates the changes in #99 but there were some other fixes needed to get this going
@adrianfish I think I got all the GradingService changes correct. It looks like isGradebookDefined was removed completely and isn't needed anymore right? I briefly tested this with and without the gradebook added to the site and with manual and automatic grading.
An issue I saw (don't know if it was the same before) with manual, is that in attendance all of the students showed up with the maximum points and it didn't go to the gradebook until one of the students was changed or manually entered. There wasn't any way I could see to trigger a grade to go in. I guess automatic is the way to go. This may need to be improved?


buttons are invisible

the button on discord still work but they are invisible -> right top corner

can you elaborate with the issue?
what theme are you using? there's like bunch of themes here and i can't possibly know what you're using right now.

oh sorry, didnt see the other cool themes in here, i was talking about the revert titlebar theme


Update main.rs to handle mismatched collection domain entries

Relevant issue was opened here:
https://github.com/TristanBilot/phishGNN/issues/5#issue-1617454511
I was able to get this working, succeeding in outputting ~15,000 entries to CSV, though I intend to batch quite a bit more before I begin training with it, and if need be, I will further update, should I run into any subsequent issues.
I do believe the issue I raised is fixed with this PR. As I had mentioned, I am not very skilled with Rust, so please review and check my work 🙂

Hi, and thanks for the PR!
Ideally we'd treat the source of the problem (mismatch of trailing slash) rather than improve error handling around it, however the problem still exists (despite having tried to avoid this kind of scenario), so I'm tempted to accept this PR. I also noticed an error I made while reviewing it, so this is good. 😅 If you don't mind, I'll add a few comments w.r.t. the Rust code (otherwise I'll just apply these changes myself).

Adjustments made per request 🙂 let me know if this is satisfactory @71
If not, I don't mind making further adjustments.

Perfect, thanks!


[JENKINS-47609] Add clone option "core.longpaths" to enable long file names

JENKINS-47609
Please refer to this PR: jenkinsci/git-plugin#856
Note: This feature doesn't cover all use-cases, it will work properly after this git-for-windows issue is resolved

@MarkEWaite Closing this pull request as well. (in reference to PR #856)


Write imageid to .dobi dir on pull action

On a pull action, dobi wasn't filling in the imageid field in the .dobi directory, causing a later build action to fail to use the cached version on the check:
if image.ID != record.ImageID || record.Info.ModTime().Before(mtime) {
t.logger().Debug("Image record older than context")
return true, nil
}
This change fixes it so dobi writes the imageid on pulls.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.Leif Huhn seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.

There now the CLAassistant is happy.

Bump. This one is fairly straightforward, I hope. Before the patch the files in .dobi look like this after a pull:
imageid: ""
lastpull: 2020-08-04T11:55:49.771412103-05:00
and after the patch they look like:
imageid: sha256:ea2320b68c0ad296a1665a0dd061ca17e1d213792fa6db7446d79a1a35a6aee4
lastpull: 2020-08-04T11:56:44.365497112-05:00

LGTM, thanks!


The app doesn't run

Hi,
I wanted to contribute to this small app, but when I tried to run it locally it just doesn't start.

It doesn't print any error to the console at all!
Does anybody know what's happening there?
Thanks,
Andrés

And I tried to run it locally on my MBPR 2014 and on a remote VPS on Digital Ocean with no success in either case.

@Angarsk8 oh this app is a bit old and like i guessed it misses.
Kemal.run

Can you add it to the end your of app.cr file?

It was definitely that! I could have inferred that if I had opened the file, but I didn't! :sweat_smile:
Thanks,


Add Cam Deatherage to Contributors list

Hello, Would you please add me to the contributors list.

Hi  @ctd1077, I'm quite elated about your pull request. I wanna evolve this project to addresses various problems faced by first-time contributors. I'd love to learn about your journey in open source community, the problems, pain points you had etc.
Could you explain how you felt when you went through the tutorial, made a pull request and learned that I merged it?
We’ve recently added social share  to our web app. Could you please go to https://roshanjossey.github.io/first-contributions/#social-share and share your first contribution to open source?
Also, check out projects with easy issues while you’re there.


Update dependencies

Update to latest graphsync
Update go-ipld-prime
Update to latest datastore (with contexts)
Update to latest libp2p

Codecov Report

Merging #63 (afd4244) into main (af597f2) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #63      +/-   ##
==========================================
+ Coverage   66.58%   66.60%   +0.01%
==========================================
  Files          19       19
  Lines        1664     1647      -17
==========================================
- Hits         1108     1097      -11
+ Misses        413      409       -4
+ Partials      143      141       -2

Impacted Files
Coverage Δ

dtsync/util.go
46.75% <100.00%> (-1.12%)
:arrow_down:

test/util.go
82.51% <100.00%> (ø)

dtsync/sync.go
74.31% <0.00%> (-1.84%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update af597f2...afd4244. Read the comment docs.


Added a basic implementation of Q objects, see #1

This is a basic implementation of Q objects. Right now, lifter does not use them in any way, but it should be easy enough to convert filter, exclude and other queryset arguments to Q objects.

This is looking great, @EliotBerriot :+1:

Thanks! Since I needed Q objects whil working on nested iterables, I opened another PR that is based on this very branch but go further to handle iterables, see #11.
To anyone who read this, any feedback would be welcome :)

An interesting issue regarding the whole query engine has been open (#15), we should probably wait for it to be resolved before continuing the work on this.

This has been implemented in 0.2 using another API, I'm closing this.


fix: fix inconsistent spacing

Summary

Fix some inconsistent spacing in the proposal right sidebar

Fix remaining h4.eyebrow tag with mb-2 instead of mb-2.5 like all the rest of the h4
Remove the extra py-2 surrounding the vote form on Proposal page (this padding should appear only on vote form inside proposals list)
Remove extra spacing after choices list in Editor

How to test

Go to a proposal
All header in the right sidebar have same bottom margin (mb-2.5)
The vote form does not have extra padding on bottom (only 24px between bottom of the form to next H4 tag)
Go to Editor
Select different voting system (basic/single choice)
There should be no extra spacing after the choices list (only 24px between bottom of the form to next H4 labels tag)

@wa0x6e

See https://github.com/snapshot-labs/sx-monorepo/pull/921


Add parentSpanID to app logs

Spring Cloud sleuth adds traceID and spanID to application logs. It would be great if it also supported adding parentSpanID. So if incoming request had a traceId and a spanID as 6b55de22492307e8, 96e487b6bfd9ca76 then app logs would write parentSpanID in this format:
2016-09-09T11:12:34.19-0700 [APP/0]      OUT 2016-09-09 18:12:34.196DEBUG [,6b55de22492307e8,d1e467b6bfd8ca04,96e487b6bfd9ca76,true] 12 --- [nio-8080-exec-7] o.s.web.servlet.DispatcherServlet        : DispatcherServlet with name 'dispatcherServlet' processing GET request for [/]

Here the app logs preserved traceID 6b55de22492307e8, added spring boot's own spanID d1e467b6bfd8ca04 and also preserved the incoming spanID and wrote it as 96e487b6bfd9ca76 right after the new spanID
This allows systems who ingest these logs to form a call stack of entire trace without needing any extra information.

I am in requirement of same thing. Can anyone guide if this is possible because when I added %X{parentSpanId :-} in log pattern it is always empty. but the parentSpanId is going as part of header request.


Allow handling of 404s

Perhaps initiate a transition with [] as routes, that way middleware can ignore or handle.

That's already the case, a transition with routes: [] takes place - so middleware can handle that.
Also, what I do in my own app is add a route('missing', path(':path*')) at the end - this way you can actually nest this under application route as well if you want to always activate the application route too, etc.
Basically, I think both options are good enough, I just need to update the docs.

Fixed by #109


Unexpected model create behaviour for non-integer primary keys

When primary key is i.e. String, model instance returned from model.object.create has primary key as sequential integer. Once instance is fetched again, primary key is as expected - type and value wise.
Postgres behaviour is similar. Returned instance primary key in this case is actually None. Same for UUID type. Once fetched again, everything is as expected.
Could be that problem originates from databases library or incorrect usage of it.
Two copy/paste tests.
import random

import databases
import pytest
import sqlalchemy

import orm
from tests.settings import DATABASE_URL
from tests.test_columns import async_adapter

database = databases.Database(DATABASE_URL, force_rollback=True)
metadata = sqlalchemy.MetaData()

def key():
    return "".join(random.choice("abcdefgh123456") for _ in range(8))

class Model(orm.Model):
    __tablename__ = "model"
    __metadata__ = metadata
    __database__ = database

    id = orm.String(primary_key=True, default=key, max_length=8)
    name = orm.String(max_length=32)

@pytest.fixture(autouse=True, scope="function")
def create_test_database():
    engine = sqlalchemy.create_engine(DATABASE_URL)
    metadata.create_all(engine)
    yield
    metadata.drop_all(engine)

@async_adapter
async def test_pk_1():
    model = await Model.objects.create(name="NAME")
    assert isinstance(model.id, str)

@async_adapter
async def test_pk_2():
    model = await Model.objects.create(name="NAME")
    assert await Model.objects.all() == [model]

Does somebody has an update on this? I have the same issue. using a str uuid as PK, but the id is always an integer before the new object is read from DB

+1 the same with UUID

Noticed same issue, ended up writing own create in our BaseModel did basically same as is done in QuerySet.create but added the returning clause to the insert statement.
class BaseModel(orm.Model):
    __abstract__ = True

    @classmethod
    async def create(cls, **kwargs):
        fields = cls.fields
        required = [key for key, value in fields.items() if not value.has_default()]
        validator = typesystem.Object(
            properties=fields, required=required, additional_properties=False
        )
        kwargs = validator.validate(kwargs)

        pk_column = getattr(cls.__table__.c, cls.__pkname__)
        expr = cls.__table__.insert().returning(pk_column)
        expr = expr.values(**kwargs)

        instance = cls(kwargs)
        instance.pk = await cls.__database__.execute(expr)
        return instance

@Nipsuli That's really helpful thanks - we probably ought to update the create method along those lines.

I am able to reproduce this using sqlite.
$ pip list
Package           Version
----------------- -------
aiosqlite         0.16.0
databases         0.4.1
orm               0.1.5
pip               20.2.4
pydantic          1.7.2
setuptools        50.3.2
SQLAlchemy        1.3.20
typesystem        0.2.4
typing-extensions <IP_ADDRESS>
wheel             0.35.1

The script:
import databases
from pydantic import BaseModel, Field
import orm
import sqlalchemy
import asyncio

database = databases.Database('sqlite:///test.sqlite')
metadata = sqlalchemy.MetaData()

class Foo(orm.Model):
	__tablename__ = 'footable'
	__database__ = database
	__metadata__ = metadata

	fielda = orm.Text(primary_key=True)
	fieldb = orm.Text(index=True)

engine = sqlalchemy.create_engine(str(database.url))
metadata.create_all(engine)

async def foo():
	a = await Foo.objects.create(fielda='dataa', fieldb='datab')
	print('fa:', repr(a.fielda))
	print('fb:', repr(a.fieldb))

asyncio.run(foo())

The results:
$ python test.py
fa: 1
fb: 'datab'

As you can see, the returned results are an integer.  If the data was fetched again, it'd be present.
The database is created correctly:
sqlite> .dump footable
PRAGMA foreign_keys=OFF;
BEGIN TRANSACTION;
CREATE TABLE footable (
	fielda TEXT NOT NULL,
	fieldb TEXT NOT NULL,
	PRIMARY KEY (fielda)
);
INSERT INTO footable VALUES('dataa','datab');
CREATE INDEX ix_footable_fieldb ON footable (fieldb);
COMMIT;

and as you can see above in the dump, the correct data is in the database, just the object was created incorrectly.

Just ran a test, and it goes wrong here:
instance.pk = await self.database.execute(expr)

a print of the instance before that line has the data being correct.  An option is that if pk is present in kwargs, simply don't do the assignment.  I don't know the layers well enough to say what is correct though.  Also, not sure how/if this addresses the case where multiple fields are the primary key.

@tomchristie @Nipsuli
The proposed solution will work in PostgreSQL and MySQL but not in SQLite.
SQLite does not support RETURNING clauses until version 3.35.0 and that is not still supported on current python versions.
For anyone interested, the reason this is happening is that SQLite uses a virtual column ROWID which is an Integer and returns that on INSERT by default.
When using non-integer columns as PrimaryKey, this will still return the ROWID instead of PK.
This can be solved by using the RETURNING clause but that's not available yet.
Any feedback is appreciated.


Working directory spec

I was browsing through the README and wondering if there would be a way in the yml file to specify the working directory snag should watch in case I wanted to keep the .snag.yml defined somewhere else but specify either a particular subfolder I wanted to watch instead of exclude all the rest. Also in case it was relative (ie: ../directory) there woudn't be a way to do it via ignore.
Perhaps this is something I could pass in to the cli itself? path to the .snag file (and assume current directory as working one instead)?
I think it'd be cool to document somewhere all the options possible for the yml and the cli also as just simple "samples" don't cut it when you're looking for more advanced usecases?

This may go hand in hand with the idea I had about running commands off the snag command without the need to have a .snag.yml file. I found myself wanting to run one or two commands without having to specify the file.
I think being able to specify the watch directory in the snag file would add a great deal of flexibility. I would like to see how we can approach this in a intuitive way.


Automation running 3 times every trigger

Describe the bug
I have 1 trigger. Agile current price change, this should trigger every 30 mins. However, it seems to trigger 3 times at exactly the same time. Maybe milliseconds apart. 1 or 2 of which will be with data from the previous current rate.
Expected behavior
Automation should only run once with the trigger of current rate every half an hour
Home Assistant Version
. Home Assistant 2023.3.6
Supervisor 2023.03.2
Operating System 9.5
Frontend 20230309.1 - latest
Integration Version
6.3.0.
Fresh Install?
After upgrade
yaml
alias: Current above average or next
description: ""
trigger:

platform: state
entity_id:

sensor.agile_current_rate
condition:

condition: or
conditions:

condition: numeric_state
entity_id: sensor.agile_current_rate
above: sensor.agile_avg_rate
condition: numeric_state
entity_id: sensor.agile_current_rate
above: sensor.agile_next_rate
action:

service: switch.turn_off
data: {}
target:
entity_id: switch.battery_settings
delay:
hours: 0
minutes: 0
seconds: 3
milliseconds: 0
service: switch.turn_off
data: {}
target:
entity_id: switch.battery_settings
device_id: idhere
domain: mobile_app
type: notify
message: not charging
title: above av or next
mode: single

This might be beause the attributes are changing trigerring the automation, you can check that in the automation trace view or try setting to: null on the automation trigger to ignore attributes.

Hello and sorry you're having issues. Like @mateuszdrab suggested, the traces of the automations might give an indication on why the automation is called multiple times in quick sucession. I also assume that you've renamed the default name of the sensors as sensor.agile_current_rate is not one provided by default.


bug: tapIgnoreEvent doesn't check for data-tap-disabled

Type: bug
Platform: mobile webview
For various reasons I had to use another scrolling library in one area of my app. To disable the Ionic scroll stuff, I used overflow-scroll="true" on the ion-content and also data-tap-disabled="true" on a container element. However the Ionic tap library was still interfering (causing events not to fire in the other library).
It boiled down to the tapIgnoreEvent method in tap.js:
function tapIgnoreEvent(e) {
  if(e.isTapHandled) return true;
  e.isTapHandled = true;

  if( ionic.scroll.isScrolling && ionic.tap.containsOrIsTextInput(e.target) ) {
    e.preventDefault();
    return true;
  }
}

It's not checking if the element, or a parent, has the "data-tap-disabled" attribute set.
It should be using the isElementTapDisabled method like other tap handlers. Changing first line to the following fixes issues:
function tapIgnoreEvent(e) {
  if(e.isTapHandled || ionic.tap.isElementTapDisabled(e.target)) return true;
  ...

We do not recommend using two scroll libraries in the same app.

I don't understand why the proposed "fix" was rejected.  The documentation states that the "data-tap-disabled" can be used to bypass tap handling for designated elements and that isn't 100% true.
I too have a non-supported use-case (IE Browser for Desktop with HTML5 Video Element whose control clicks are being intercepted by the tap handler), but I don't see why I shouldn't be able to use "data-tap-disabled" sucessfuly.

Fixed in 311967991c7adb493e48ea575be2b39a8047415d


Profiling large composite bloq construction and qubit counting timings

This PR includes

A parametrically-large bloq for testing decomposition and qubit count loosely modeled on a qrom-ish circuit
A series of potential optimizations, whose timing I've recorded below (check the second commit for the details)
Reversion of all of the optimizations except those that are a meaningful win with limited code health burden

I timed qubit counting as well as just doing a decomposition.
len(LargeBloq(n_select=60, n_ops=120).decompose_bloq().bloq_instances)
14282

%%timeit
val = get_cost_value(LargeBloq(n_select=60, n_ops=120), QubitCount())

baseline
1.91 s ± 8.29 ms per loop (mean ± std. dev. of 7 runs, 1 loop each)

qubit count operation re-ordering
    1.63 s ± 82.7 ms per loop (mean ± std. dev. of 7 runs, 1 loop each)

with cached shape property
    1.06 s ± 23.3 ms per loop (mean ± std. dev. of 7 runs, 1 loop each)

the first two optimizations, and changes to register sorting
    1.02 s ± 6.77 ms per loop (mean ± std. dev. of 7 runs, 1 loop each)

the first two optimizations, and removing some of the dispatch from register shape
    959 ms ± 12.2 ms per loop (mean ± std. dev. of 7 runs, 1 loop each)

the first two optimizations, and non-attrs classes for BloqInstance, Soquet, ... #130
    733 ms ± 7.09 ms per loop (mean ± std. dev. of 7 runs, 1 loop each)

All optimizations
    609 ms ± 4.29 ms per loop (mean ± std. dev. of 7 runs, 1 loop each)

%%timeit
cb = LargeBloq(n_select=60, n_ops=120).decompose_bloq()

baseline
373 ms ± 10.4 ms per loop (mean ± std. dev. of 7 runs, 1 loop each)

qubit count changes, cached shape property: n/c

register sort
    346 ms ± 5.2 ms per loop (mean ± std. dev. of 7 runs, 1 loop each)

no fancy shape
    291 ms ± 16.6 ms per loop (mean ± std. dev. of 7 runs, 1 loop each)

non-attrs quantum graph
    276 ms ± 1.52 ms per loop (mean ± std. dev. of 7 runs, 1 loop each)

all optimizations
    171 ms ± 3.28 ms per loop (mean ± std. dev. of 7 runs, 10 loops each)

Conclusions

marginal improvements for the things I tried when speeding up a decomposition, probably not worth it
15k bloqs in ~1s is probably fine. Decompositions shouldn't have that many sub-operations
Qubit counting was doing a decomposition twice, which is not good for performance

15k bloqs in ~1s is probably fine. Decompositions shouldn't have that many sub-operations

From a theoretical perspective, the complexity for qubit counting should probably be linear; i.e. - O(N + M) where N is number of nodes in the composite graph and M is number of edges. A modern machine can execute ~1e8 operations per second. We should aim to support qubit counting for ~1e5-1e6 bloqs in the decomposition per ~1s; discounting for ~100x slowdown due to Python and constant factors wrt error checking / data structures etc.
Right now this number is ~1.5e4 -- I think we should try to speed things up somewhere between ~10x - 100x as a reasonable goal. It'll be good to profile what is bringing the biggest slowdown in terms of constant factors.


Request for OkAuthorization fields to be made public

After parsing the response from 3scale, there is no way to access the OkAuthorization's fields as their visibility is set to private by default. Either getters or publishing fields would do the trick for accessing them. I can create a PR so, can you please mention which method is favorable?
Reference: https://github.com/3scale-rs/threescalers/blob/c7fb31a2bf064da06197caa7830576b9d80ca3d2/src/response.rs#L111

Definitely best to provide getters - public fields create a usually unneeded and very strong contract for a library. /cc @davidor

Related PR: #89

Closed via #89.


Upload.php getting wrong MIME Type for .CSV file.

My computers setup:
Mac OS 10.8.2
Chrome 24.0.1312.52
MAMP 2.1.1
PHP 5.4.4
The MIME Type that the upload class is returning when I try to upload a csv file created by Mac Excel is text/plain
I had a friend upload the same file from his Windows 7 machine and he didn't have any problems.
Here is a link to the file I am trying to upload:
https://www.dropbox.com/s/xq2wgh90vmgjj9h/play_codes.csv
I don't know much about mime types but after reading this article it looks like the issue I am having is based on my local computer configuration (Browser, OS, etc)
http://blog.futtta.be/2009/08/24/http-upload-mime-type-hell/


hasElaborateAssign should check whether the type is assignable

verylonglogin.reg (@denis-sh) reported this on 2013-09-23T03:37:55Z
Transfered from https://issues.dlang.org/show_bug.cgi?id=11108
CC List

monarchdodra

Description
The usage of `hasElaborateAssign` on unassignable types (e.g. `const` ones) which now results in returning `false` is almost definitely an error. So `hasElaborateAssign` has to reject such types.

monarchdodra commented on 2013-10-12T05:17:02Z
I don't believe this is a good choice.

I think a trait can be used inside a runtime check, and as such, all traits should always compile.

This is currently the case for every trait we have, be they in std.traits or std.range.

The trait name is "hasElaborateAssign". It should really just answer yes/no. Not yes, no, error.

github-bugzilla commented on 2013-10-09T07:05:09Z
Commit pushed to master at https://github.com/D-Programming-Language/phobos

https://github.com/D-Programming-Language/phobos/commit/73fa0f036a366c381beb0e784a1b28eccfe99741
Merge pull request #1623 from denis-sh/fix-Issue-11108-again-fixup-pull-1598

Fix issue 11108 again (fixup pull #1598)

github-bugzilla commented on 2013-10-08T21:51:00Z
Commits pushed to master at https://github.com/D-Programming-Language/phobos

https://github.com/D-Programming-Language/phobos/commit/76fcee3a6679b2348fad1e375c62b2c7c82d430e
Fix Issue 11108 - `hasElaborateAssign` should check whether the type is assignable

Issue URL: http://d.puremagic.com/issues/show_bug.cgi?id=11108

https://github.com/D-Programming-Language/phobos/commit/561d266f485646ced9c0449a7a64fa16563dd3a6
Merge pull request #1598 from denis-sh/fix-Issue-11108

Fix Issue 11108 - `hasElaborateAssign` should check whether the type is assignable

verylonglogin.reg commented on 2013-09-23T03:41:18Z
https://github.com/D-Programming-Language/phobos/pull/1598

github-bugzilla commented on 2013-10-08T23:30:39Z
Commits pushed to master at https://github.com/D-Programming-Language/phobos

https://github.com/D-Programming-Language/phobos/commit/396d629120a05ff65ba6d89997f99a8a00a9ef67
Revert "Fix Issue 11108 - `hasElaborateAssign` should check whether the type is assignable"

This reverts commit e82724d740d223b52be2800eeec8d5ed4f673dfb.

https://github.com/D-Programming-Language/phobos/commit/2f65b41d41328004f21e1047d85c055446d3285b
Merge pull request #1621 from monarchdodra/undoHasElaborate

Revert "Fix Issue 11108 - `hasElaborateAssign` should check whether the ...

github-bugzilla commented on 2013-10-12T05:17:19Z
Commits pushed to master at https://github.com/D-Programming-Language/phobos

https://github.com/D-Programming-Language/phobos/commit/8751ccfb0c70b5f4166eb7707af983ccab460ab2
Revert "Fix for issue 11108"

This reverts commit c930d8bd5e5246653a0300aac791b4c82b0466c5.

https://github.com/D-Programming-Language/phobos/commit/d327f339aaf8b8d6a7ad6e62626355a0e5e0fdd3
Merge pull request #1628 from monarchdodra/revert11108

Revert "Fix for issue 11108"

verylonglogin.reg commented on 2013-10-12T05:44:14Z
(In reply to comment #5)
> I don't believe this is a good choice.
>
> I think a trait can be used inside a runtime check, and as such, all traits
> should always compile.
>
> This is currently the case for every trait we have, be they in std.traits or
> std.range.
>
> The trait name is "hasElaborateAssign". It should really just answer yes/no.
> Not yes, no, error.

See https://github.com/D-Programming-Language/phobos/pull/1623#issuecomment-26196738 for reply:
> So, we are talking about this:
>
> if (isAssignable!SS && !hasElaborateAssign!SS)
>
> Even in the case it would be just rare and uncommon code it is silly to make regular code error-prone (spending programmers time on debugging their mistakes) to support some patterns almost nobody use. But we are talking here about not just rare and uncommon, but almost definitely incorrect construction indicating an error. And you really did the error here [see pull discussion] which my pull shown.


Allow for using native modules instead of SystemJS

With things like vite, snowpack, and jspm, I think it's time that single-spa-playground allows you to use import() instead of System.import() to load the microfrontends. Notice the new module loader question:

I'm merging this now so that I can demo Vite in single-spa-playground. However, please leave any comments / feedback on this PR and I'll come back and create a new PR to address feedback.


Can't install: dependency @hugomrdias/pull-ws is now private

npm installing this package results in
npm ERR! command git ls-remote<EMAIL_ADDRESS>npm ERR! ERROR: Repository not found.
npm ERR! fatal: Could not read from remote repository.

It looks like this repository is now private. Any recommendations to install this correctly? Is there any similar package I can substitute?

Oh, I just looked at some of the open issues below this one. Is this thing dead?


The assembly 'Castle.Windsor [...] is not registered for COM Interop

Hi! I have a .NET library with Register for COM interop_attribute set to true, and COM visibile too in csproj. This library references Castle.Windsor 5.1.1 on .NET Framework 4.8, and when I build, I get this compiler error:
The assembly 'Castle.Windsor, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=407dd0808d44fbdc' is not registered for COM Interop. Please register it with regasm.exe /tlb.
I noticed that with other nuget libraries (for example Dapper 2.0.90) I don't have any problem to compile a dll registered for COM Interop. Is there something I'm missing? If I manually register the dll with regasm, it works, but I'm wondering why I have to do it manually!
Thanks a lot.

Looks like it was broken when Windsor was moved to the .NET SDK project format and so the assembly is defaulting to COM visible.
CommonAssemblyInfo.cs doesn't have [assembly: ComVisible(false)] like Castle Core. ComVisible(false) used to be set via the MSBuild build scripts before the move.


[SPARK-42690][CONNECT] Implement CSV/JSON parsing functions for Scala client

What changes were proposed in this pull request?
This pr add a new proto message
message Parse {
  // (Required) Input relation to Parse. The input is expected to have single text column.
  Relation input = 1;
  // (Required) The expected format of the text.
  ParseFormat format = 2;

  // Options for the csv/json parser. The map key is case insensitive.
  map<string, string> options = 3;
  enum ParseFormat {
    PARSE_FORMAT_UNSPECIFIED = 0;
    PARSE_FORMAT_CSV = 1;
    PARSE_FORMAT_JSON = 2;
  }
}

and implement CSV/JSON parsing functions for Scala client.
Why are the changes needed?
Add Spark connect jvm client api coverage.
Does this PR introduce any user-facing change?
No
How was this patch tested?

Pass Github Actions
Manual checked Scala 2.13

why not using from_json and from_csv to do this?

why not using from_json and from_csv to do this?

How to get the schema?

not sure whether I’m missing something, but isn’t the schema already provided by users?

probably not related to this PR:
https://github.com/apache/spark/blob/39a55121888d2543a6056be65e0c74126a9d3bdf/connector/connect/client/jvm/src/main/scala/org/apache/spark/sql/DataFrameReader.scala#L63-L76
  def schema(schemaString: String): DataFrameReader = {
    schema(StructType.fromDDL(schemaString))
  }

when the user provide a DDL string, it invoke the parser. Here I think we should keep both StructType and DDL string, and pass them to the server side.

probably not related to this PR:
https://github.com/apache/spark/blob/39a55121888d2543a6056be65e0c74126a9d3bdf/connector/connect/client/jvm/src/main/scala/org/apache/spark/sql/DataFrameReader.scala#L63-L76
  def schema(schemaString: String): DataFrameReader = {
    schema(StructType.fromDDL(schemaString))
  }

when the user provide a DDL string, it invoke the parser. Here I think we should keep both StructType and DDL string, and pass them to the server side.

message Read seems also need to consider this？I think we can further discuss this problem in a separate jira?

@LuciferYang thank you for woking on this.
merged into master/branch-3.4

Thanks @zhengruifeng @hvanhovell @HyukjinKwon  ~


Add format function in CLI

What changes are proposed in this pull request?
Add a new function in golang CLI to support reformatting the json output to yaml and so on.
Why are the changes needed?
For info commands, it'll provide a easier way to change the format.
Does this PR introduce any user facing changes?
nope

cc @twalluxio

alluxio-bot, merge this please

alluxio-bot, merge this please


Unhelpful error with StatelessComponents

TypeScript Version:  1.8.10
Code
File: src/App.tsx
/// <reference path="../typings/index.d.ts" />
import * as React from "react"
import Child from "./Child"

const App = () => {
    return (

Hello World

        <Child />
        <Child />

)
}

export default App

File: Child.tsx
/// <reference path="../typings/index.d.ts" />
import * as React from "react"

interface ChildProps {
    bold: boolean
}

const Child: React.StatelessComponent<ChildProps> = ({bold}) => {
    if (bold) {
        return
Child

    }
    return
Child

}

export default Child

File: tsconfig.json
{
    "compilerOptions": {
        "target": "es6",
        "jsx": "preserve"
    }
}

Expected behavior:
An error free compile
Actual behavior:
/usr/local/lib/node_modules/typescript/lib/tsc.js:33078
                throw e;
                ^

TypeError: Cannot read property 'flags' of undefined
    at isRelatedTo (/usr/local/lib/node_modules/typescript/lib/tsc.js:16013:32)
    at checkTypeRelatedTo (/usr/local/lib/node_modules/typescript/lib/tsc.js:15941:26)
    at checkTypeAssignableTo (/usr/local/lib/node_modules/typescript/lib/tsc.js:15819:20)
    at isTypeAssignableTo (/usr/local/lib/node_modules/typescript/lib/tsc.js:15813:20)
    at getJsxElementAttributesType (/usr/local/lib/node_modules/typescript/lib/tsc.js:18463:47)
    at checkJsxOpeningLikeElement (/usr/local/lib/node_modules/typescript/lib/tsc.js:18564:40)
    at checkJsxSelfClosingElement (/usr/local/lib/node_modules/typescript/lib/tsc.js:18265:13)
    at checkJsxElement (/usr/local/lib/node_modules/typescript/lib/tsc.js:18281:25)
    at checkExpressionWorker (/usr/local/lib/node_modules/typescript/lib/tsc.js:20437:28)
    at checkExpression (/usr/local/lib/node_modules/typescript/lib/tsc.js:20349:42)

I imagine I'm doing something wrong here but I can't figure out what it is because the error message is a little obtuse.
There's a repo demoing the whole problem here: https://github.com/alexjg/typescript-error-demo
Thanks

"React.StatelessComponent" aren't you supposed to inherit from it? I didn't take a look now but that is what a gathered from my last read of the release notes 🌹

Ah, maybe I've misunderstood the way it's mean to be used, I was going based on this blog post and the definition of the StatelessComponent, which looks like this:
interface StatelessComponent
 {
    (props?: P, context?: any): ReactElement<any>;
    propTypes?: ValidationMap
;
    contextTypes?: ValidationMap<any>;
    defaultProps?: P;
    displayName?: string;
}

Which looks to me like it's a function which returns a ReactElement but has some extra properties right? I'm new to TypeScript so very likely to be reading it wrong.

Irrespective of the potential "misuse" you have encountered a tsc compiler error, which shouldn't happen, versus a legitimate TypeScript language error.  I am sure the TypeScript team will be along soon to triage it and figure what is going wrong with the compiler.

My misunderstanding. The new thing I was thinking is a new "class" called React.PureComponent 🌹

Looks like a duplicate of #7286, which has been fixed in 2.0


Unable to nest navigators without creating new navigators due to screen component being created

Currently it seems that intermediary screen components are created due to the screen parameter in routes being interpreted as a react functional component.

function route(screen, path, navigationOptions, _) {
  return {
          screen: (function (props) {
              var navigation = props.navigation;
              var state = Navigation$BsReactNavigation.stackState(navigation);
              return Curry._3(screen, navigation, state[/* params */2], props.screenProps);
            }),
          path: Js_undefined.fromOption(path),
          navigationOptions: Js_undefined.fromOption(navigationOptions)
        };
}

This issue triggers the following warning and breaks the ability to navigate across navigators:
You should only render one navigator explicitly in your app, and other navigators should by rendered by including them in that navigator. Full details at:
https://reactnavigation.org/docs/common-mistakes.html#explicitly-rendering-more-than-one-navigator

Yes. That's an actual issue. We want to have intermediate step to convert JS navigation screen props to Reason component which accepts props as function arguments instead of object. I don't know how to solve this issue right now. Maybe some escape with JS HoC accepting Reason component. I'm not sure when I'll have time to check this.


Action doesn't seem to get the right revision value

Hi,
I'm trying to use this action in our workflows to get PR checks and detailed information on runs for each commit, however I can't seem to get this work.
I get this from the logs:
Gathering inputs
  Using git revision [SHA]

However that SHA is not the last commit SHA on my PR, but rather a SHA of a "detached HEAD state", which I can confirm if I try to visit the url of that SHA in github.com, I get a warning saying "This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository".
Am I doing something fundamentally wrong? I am using the action as in the example in the README.

@jbanulso Can you share the trigger for the workflow.  Are you triggering on [push] or [pull_request]?

Ok, it looks like the GITHUB_SHA environment variable isn't the HEAD commit of the branch for action type pull_request: https://github.community/t/github-sha-not-the-same-as-the-triggering-commit/18286
https://docs.github.com/en/free-pro-team@latest/actions/reference/events-that-trigger-workflows#workflow_dispatch
We will work on a fix to grab the SHA of the tip commit on the branch a different way.

Thanks for the report!

No problem, thank you for looking into it. And for the record, it works fine when the trigger is on: [push]

@jbanulso This fix was released last week.  Let us know if you are still seeing issues.


<IP_ADDRESS>

Trying to migrate old acegi plugins to Spring Security, but it looks like a commit from back in august broke support for Non-Domain-Class based principals.
Commit that broke this support:
https://github.com/grails-plugins/grails-spring-security-core/commit/e8e9eecb2dcb8489d1065a9ee1644b5ce223f0fc
Plug-ins affected:
grails-spring-security-ldap
grails-spring-security-mock
grails-spring-security-shibboleth
grails-spring-security-cas
grails-spring-security-saml

I just found a bug in my patch, I'm closing this and re-submitting.


Update email notification setting label for clarity

we send notifications for other things, e.g. events. this also matches up with the description from the API docs:
https://developers.linode.com/api/v4#operation/getProfile

Coverage remained the same at 32.462% when pulling fa5c085afd864525ba160efebe97dba6b860f3aa on update-email-notification-setting-desc into 37a6834ecf2b9ab5d639b1baec24f8f725eb7fe7 on develop.


Disabling headers

What would you like to be added:
Something like the kubectl --no-headers option, to disable showing the + pod › container line every time stern starts tailing one pod.
Why is this needed:
I use stern in CI/CD and I don't want it to output the list of all pods when it begins, when combined with --since=1s, to avoid flooding the output.

headers are output to stderr. Therefore, you can avoid outputting them by doing the following:
$ stern . 2>/dev/null
nginx-587df8d89d-m7xx8 nginx-unprivileged /docker-entrypoint.sh: /docker-entrypoint.d/ is not empty, will attempt to perform configuration
nginx-587df8d89d-m7xx8 nginx-unprivileged /docker-entrypoint.sh: Looking for shell scripts in /docker-entrypoint.d/
nginx-587df8d89d-m7xx8 nginx-unprivileged /docker-entrypoint.sh: Launching /docker-entrypoint.d/10-listen-on-ipv6-by-default.sh
nginx-587df8d89d-m7xx8 nginx-unprivileged 10-listen-on-ipv6-by-default.sh: info: Getting the checksum of /etc/nginx/conf.d/default.conf
nginx-587df8d89d-m7xx8 nginx-unprivileged 10-listen-on-ipv6-by-default.sh: info: /etc/nginx/conf.d/default.conf differs from the packaged version
nginx-587df8d89d-m7xx8 nginx-unprivileged /docker-entrypoint.sh: Launching /docker-entrypoint.d/20-envsubst-on-templates.sh
nginx-587df8d89d-m7xx8 nginx-unprivileged /docker-entrypoint.sh: Launching /docker-entrypoint.d/30-tune-worker-processes.sh
nginx-587df8d89d-m7xx8 nginx-unprivileged /docker-entrypoint.sh: Configuration complete; ready for start up
nginx-587df8d89d-m7xx8 nginx-unprivileged 2022/12/19 00:17:20 [notice] 1#1: using the "epoll" event method
nginx-587df8d89d-m7xx8 nginx-unprivileged 2022/12/19 00:17:20 [notice] 1#1: nginx/1.23.2
nginx-587df8d89d-m7xx8 nginx-unprivileged 2022/12/19 00:17:20 [notice] 1#1: built by gcc 10.2.1 20210110 (Debian 10.2.1-6)
nginx-587df8d89d-m7xx8 nginx-unprivileged 2022/12/19 00:17:20 [notice] 1#1: OS: Linux 5.4.0-131-generic
nginx-587df8d89d-m7xx8 nginx-unprivileged 2022/12/19 00:17:20 [notice] 1#1: getrlimit(RLIMIT_NOFILE): 1048576:1048576
nginx-587df8d89d-m7xx8 nginx-unprivileged 2022/12/19 00:17:20 [notice] 1#1: start worker processes
nginx-587df8d89d-m7xx8 nginx-unprivileged 2022/12/19 00:17:20 [notice] 1#1: start worker process 34
nginx-587df8d89d-m7xx8 nginx-unprivileged 2022/12/19 00:17:20 [notice] 1#1: start worker process 35
nginx-587df8d89d-m7xx8 nginx-unprivileged 2022/12/19 00:17:20 [notice] 1#1: start worker process 36
nginx-587df8d89d-m7xx8 nginx-unprivileged 2022/12/19 00:17:20 [notice] 1#1: start worker process 37
nginx-587df8d89d-m7xx8 nginx-unprivileged 2022/12/19 00:17:20 [notice] 1#1: start worker process 38
nginx-587df8d89d-m7xx8 nginx-unprivileged 2022/12/19 00:17:20 [notice] 1#1: start worker process 39
nginx-587df8d89d-m7xx8 nginx-unprivileged 2022/12/19 00:17:20 [notice] 1#1: start worker process 40
nginx-587df8d89d-m7xx8 nginx-unprivileged 2022/12/19 00:17:20 [notice] 1#1: start worker process 41
nginx-587df8d89d-m7xx8 nginx-unprivileged 2022/12/19 00:17:20 [notice] 1#1: start worker process 42
nginx-587df8d89d-m7xx8 nginx-unprivileged 2022/12/19 00:17:20 [notice] 1#1: start worker process 43
nginx-587df8d89d-m7xx8 nginx-unprivileged 2022/12/19 00:17:20 [notice] 1#1: start worker process 44
nginx-587df8d89d-m7xx8 nginx-unprivileged 2022/12/19 00:17:20 [notice] 1#1: start worker process 45

If you do not want to include pod info in the log line, you can use the --template flag.
$ stern --template '{{.Message}}{{"\n"}}' . 2>/dev/null
/docker-entrypoint.sh: /docker-entrypoint.d/ is not empty, will attempt to perform configuration
/docker-entrypoint.sh: Looking for shell scripts in /docker-entrypoint.d/
/docker-entrypoint.sh: Launching /docker-entrypoint.d/10-listen-on-ipv6-by-default.sh
10-listen-on-ipv6-by-default.sh: info: Getting the checksum of /etc/nginx/conf.d/default.conf
10-listen-on-ipv6-by-default.sh: info: /etc/nginx/conf.d/default.conf differs from the packaged version
/docker-entrypoint.sh: Launching /docker-entrypoint.d/20-envsubst-on-templates.sh
/docker-entrypoint.sh: Launching /docker-entrypoint.d/30-tune-worker-processes.sh
/docker-entrypoint.sh: Configuration complete; ready for start up
2022/12/19 00:17:20 [notice] 1#1: using the "epoll" event method
2022/12/19 00:17:20 [notice] 1#1: nginx/1.23.2
2022/12/19 00:17:20 [notice] 1#1: built by gcc 10.2.1 20210110 (Debian 10.2.1-6)
2022/12/19 00:17:20 [notice] 1#1: OS: Linux 5.4.0-131-generic
2022/12/19 00:17:20 [notice] 1#1: getrlimit(RLIMIT_NOFILE): 1048576:1048576
2022/12/19 00:17:20 [notice] 1#1: start worker processes
2022/12/19 00:17:20 [notice] 1#1: start worker process 34
2022/12/19 00:17:20 [notice] 1#1: start worker process 35
2022/12/19 00:17:20 [notice] 1#1: start worker process 36
2022/12/19 00:17:20 [notice] 1#1: start worker process 37
2022/12/19 00:17:20 [notice] 1#1: start worker process 38
2022/12/19 00:17:20 [notice] 1#1: start worker process 39
2022/12/19 00:17:20 [notice] 1#1: start worker process 40
2022/12/19 00:17:20 [notice] 1#1: start worker process 41
2022/12/19 00:17:20 [notice] 1#1: start worker process 42
2022/12/19 00:17:20 [notice] 1#1: start worker process 43
2022/12/19 00:17:20 [notice] 1#1: start worker process 44
2022/12/19 00:17:20 [notice] 1#1: start worker process 45

If you still have any issue, please feel free to reopen this issue.


Uncaught Error: tunneling socket could not be established, cause=connect ETIMEDOUT <IP_ADDRESS>:80

[Enter steps to reproduce:]

...
...

Atom: 1.17.2 x64
Electron: 1.3.15
OS: Microsoft Windows 7 Professional
Thrown From: Atom Core
Stack Trace
Uncaught Error: tunneling socket could not be established, cause=connect ETIMEDOUT <IP_ADDRESS>:80
At stream.js:74

Error: tunneling socket could not be established, cause=connect ETIMEDOUT <IP_ADDRESS>:80
    at ClientRequest.onError (~/AppData/Local/atom/app-1.17.2/resources/app/node_modules/tunnel-agent/index.js:177:17)
    at ClientRequest.g (events.js:286:16)
    at emitOne (events.js:96:13)
    at ClientRequest.emit (events.js:188:7)
    at Socket.socketErrorListener (_http_client.js:308:9)
    at emitOne (events.js:96:13)
    at Socket.emit (events.js:188:7)
    at emitErrorNT (net.js:1272:8)
    at _combinedTickCallback (internal/process/next_tick.js:74:11)
    at process._tickCallback (internal/process/next_tick.js:98:9)

Commands
     -7:56.5.0 core:save (input.hidden-input)
  2x -4:18.3.0 autocomplete-plus:activate (input.hidden-input)
     -3:55.6.0 find-and-replace:show (input.hidden-input)
     -3:50.1.0 core:confirm (input.hidden-input)
 17x -3:48.9.0 core:backspace (input.hidden-input)
     -3:41.4.0 line-ending-selector:show (atom-text-editor.editor.is-focused)
     -2:41.9.0 command-palette:toggle (input.hidden-input)
     -2:34.7.0 core:confirm (input.hidden-input)
 24x -2:34 core:backspace (input.hidden-input)
     -1:49.7.0 settings-view:install-packages-and-themes (input.hidden-input)
     -1:44.9.0 core:backspace (input.hidden-input)

Non-Core Packages
refactor 0.11.4

Thanks for the report!  Based on other reports, this seems like a transient networking issue - I'll go ahead and close as a dupe for now (/cc https://github.com/atom/atom/issues/14019) but if you get this error consistently and can reproduce, please let us know @monicasenapati :v:


Create and log a useful user and/or debug message in src/ramstk/dao/DAO.py.

This issue was automatically generated from a TODO comment in the file src/ramstk/dao/DAO.py.

This is the same as issue #239.


allow including arbitrary css files

I don't want to copy and paste my css into the <mj-style> tag, but instead use a css file that I can link.
Is this possible today, and if not, will this be added soon?
Expected behavior:
allow e.g. <link rel="stylesheet" href="email.css"> or <mj-link rel="stylesheet" href="email.css"> that will be inlined
Observed behavior:
need to use <mj-style>[css here]</mj-style>

Hi @apopiak
Can't you just use a regular mj-include with .mjml.css inside a mj-style ? This could work easily

Hi @apopiak
Did you test this solution ? Does it fit your needs ?

Thanks for following up. I will try the suggestion and get back to you.
On Thu, Feb 23, 2017, 17:58 Maxime Brazeilles<EMAIL_ADDRESS>wrote:

Hi @apopiak https://github.com/apopiak
Did you test this solution ? Does it fit your needs ?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/mjmlio/mjml/issues/550#issuecomment-282052606, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AGoVYvEoceECfGervix0SBusd9AT0aliks5rfbqrgaJpZM4MAfgL
.

had the same issue, tried it like this:
<mj-style>
    <mj-include path="./mjml/snippets/head/styles.mjml.css"/>
</mj-style>

but that didn't work:
events.js:160
      throw er; // Unhandled 'error' event
      ^
ReferenceError: Node is not defined

Hi @mratz-immonet
Can you give more information about your setup (OS/MJML Version/Node Version) ?

sure: MacOS X / "mjml": "^3.1.1" / 3.9.5

Can you try to update Node to at least node 6/7 please ?

oh wait i checked npm. node is at 6.2.2

Your error seems totally unrelated from mj-include, I've already seen that error on the Slack but no chance to reproduce on my side can you prove the full template in https://mjml.io/try-it-live please ?

Alright. I tried your suggestion (sorry for the wait) and it's not working.
<mjml>
  <mj-head>
    <mj-style>
      <mj-include path="email.mjml.css" />
    </mj-style>
  </mj-head>
  <mj-body>
    ...
  </mj-body>
</mjml>

errors with:
>> error processing file code/templates/emails/base.mjml
Fatal error: Node is not defined

Which leads me to assume that mjml elements are not supported inside of an <mj-style>.

node version: 7.5.0
mjml version: 3.2.0

@iRyusa

Well it looks to be fixed in 3.3 branch, can you try with beta 8 to confirm ?

@iRyusa, I'm trying to accomplish the same thing and not working for me either. I'm using MJML app  2.0.1 released a few days ago by @meriadec running MJML 3.3.2. I tried including the code in  and  but no go on either.

<mj-style inline="inline">
  a{color:#71b8e4; text-decoration:none;}
  #section-title {text-align:left; color:#2e364d; font-size:14px; font-family:'Arial',sans-serif;}
  h5{color:#666; font-size:14px; margin-bottom:0;}
  h6{color:#2a9dc9; font-size:14px; font-weight:600; margin-bottom:0;}
  #phone{margin-top:0;}
  .action-step{font-size:12px; font-weight:800; color:#333; text-align:center; width:75%; margin-left:auto; margin-right:auto; line-height:12px;}
</mj-style>

  <mj-section  padding="0">
  <mj-text>

  </mj-text>
  </mj-section>

  <mj-section padding="0" padding-bottom="35px" padding-top="35px">
  	<mj-text>

All New Cohort Analysis
A fresh new way to look at your collection curves.

    </mj-text>
    <mj-text>

Cohort analysis provides meaningful insights into your fee collection based on vintages of your clients. These reports can be customized and filtered to help you identify revenue trends and shortfalls and forecast future receivables.

Here’s a quick overview of what the sessions will cover

    </mj-text>
  </mj-section>

  <mj-section  padding="0" padding-bottom="75px" padding-left="35px" padding-right="75px" padding-top="25px">
  <mj-text>

Hi John,

Thanks again for your inquiry. DebtPayPro is one of the most powerful and efficient platforms on the market. We've developed great tools to help your business close more deals, collect payments and market to your clients. We look forward to speaking with you soon. We're here to answer your questions, demo our product and show you any specific functionality tailored to your business needs.

We’ve assigned you a product specialist who will be in touch shortly with next steps.
Sincerely,
DebtPayPro

  </mj-text>
  </mj-section>

  <mj-include path="./help.mjml" />

  <mj-include path="./footer.mjml" />

</mj-container>

Hello @dshastry
We don't support external css, you can only include local files with mj-include
btw this issue looks to be fixed in 3.3.x branch so i'm closing it, feel free to open your own issue !

Ah gotcha. Thanks for clarifying @iRyusa!

@iRyusa what if I'm using a webfont from myfonts? It needs an:
/* @import must be at top of file, otherwise CSS will not work */
@import url("//hello.myfonts.net/count/XXXXXX");

You can use mj-font, to import font safely, mj-style, mj-raw in head... there's a lot of working solution

I see, I tried with mj-raw and it worked.
I was confused by your remark:

We don't support external css, you can only include local files with mj-include

    <mj-section padding="0px">
        <mj-column>
            <mj-text align="center" padding="0px">
              <link rel="stylesheet" href="https://maxcdn.bootstrapcdn.com/bootstrap/3.4.1/css/bootstrap.min.css">
            </mj-text>
        </mj-column>
    </mj-section>

Why is there no documentation how to import custom fonts, that are not part of Google fonts?

Yeah, it is so intuitive.
Here is a solution for someone who will face the same problem.
Add this to <mj-head>
<mj-raw>       <link href="domain.com/fonts.css" rel="stylesheet" type="text/css">     </mj-raw>
in .fonts.css define @font-face
if you have CORS problem, create .htaccess file where you have fonts.css and add
<IfModule mod_headers.c>   <FilesMatch "\.(ttf|ttc|otf|eot|woff|woff2|font.css|css)$">     Header set Access-Control-Allow-Origin "*"   </FilesMatch> </IfModule>

Don’t use mj-raw like that or outlook will fallback everything to TimesOn 10 Nov 2023, at 12:34, Andraz @.**> wrote:
Yeah, it is so intuitive.
Here is a solution for someone who will face the same problem.
Add this to

in .fonts.css define @font-face
if you have CORS problem, create .htaccess file where you have fonts.css and add
 <FilesMatch ".(ttf|ttc|otf|eot|woff|woff2|font.css|css)$"> Header set Access-Control-Allow-Origin ""
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: @.***>

@iRyusa what do you suggest then?

 <mjml>
   <mj-head>
     <mj-font name="Raleway"
       href="domain.com/fonts.css" />
   </mj-head>
   <mj-body>
     <mj-section>
       <mj-column>
         <mj-text font-family="Raleway, Arial">
           Hello World!
         </mj-text>
       </mj-column>
      </mj-section>
   </mj-body>
 </mjml>

Happy new year! I'm facing an issue here, where some of my files aren't getting included. I'm using <mj-incude> tags, and only one of the files is getting included. I've been facing this issue for a while, and I don't know what to do.


Added script to find minimal set of spirv-opt flags that triggers an assertion failure

Added script to find minimal set of spirv-opt flags that triggers an assertion failure.

Needs license.


Bare imports in LitElement

Hello,
maybe this is not the best place for asking this, but there are no other places.
I'm wondering why the LitElement uses bare imports in its source and force us to use Polymer CLI or a bundler (or pika).
I cannot see the point of this design decision, I would be glad to learn the reason behind.

There is no other viable way for LitElement to import lit-html. WIth npm there's no guarantee where lit-html will be installed to, so there's no relative or absolute path we could use. Most tools do not deal well with cross-package paths either.
Bare specifiers on the other hand are well supported in most tools. You can use the Polymer CLI, but also other tools like es-dev-server, Webpack, Parcel, Rollup with rollup-plugin-node-resolve, unpkg.com, Pika, and more.

Thanks for the answer. I'm not totally sure I'm persuaded on the npm argument: npm has a unique root, the only thing a user can do is to change the root, and in this case this would be valid for all the packages, preserving the cross-package paths in any case. Also, manually changing/renaming the dir of single modules makes no sense.
What am I missing?

lit-element would need to import lit-html from it's modules directory like so: ./node_modules/lit-html/lit-html.js.
When someone then installs lit-element, lit-html is no longer installed at that location. It's actually at ../lit-html/lit-html.js relative from lit-element.js.
npm does not guarantee the location of modules, not the name of the module folder. importing by package name is how npm works, for better or worse. There is a proposal for implementing this in the browser too: https://github.com/WICG/import-maps it's implemented in chrome behind a flag. With https://github.com/guybedford/es-module-shims you can use import maps on any browser that supports modules.

Thanks for the answer. I partially see your point.

lit-element would need to import lit-html.

Wouldn't be easier to provide a complete bundle or install lit-html in ./node_modules/lit-element/node_modules?
Npm used to install package deps in a specific node_modules directory inside the package itself once, if I'm not wrong.

That will not work when you have other dependencies that need lit-html as well. And besides lit-html and lit-element, this problem will apply to other types of packages as well. For example lit-element itself is a shared dependency of many web components you might use in an application.
All things considered bare imports are the best solution right now, and they might be the standard solution in the future. For now with a small transformation step we get pretty close to build free development

Actually, re-reading your previous message:

lit-element would need to import lit-html from it's modules directory like so: ./node_modules/lit-html/lit-html.js.

correct. But, again, wouldn't be easier for the user to provide a "production build" when all the paths are relative to the node_modules directory of the project of the user? You keep discriminating 2 use cases, but actually here there is just one real use case, the case the user uses lit-element as a dependency of his own project, am I wrong?

the case the user uses lit-element as a dependency of his own project.

It doesn't make sense to bundle lit-html with lit-element because it does not re-export everything from lit-html. This would actually harm more than help as already mentioned.
As an example, directives have to be imported separately and that's intentional.
This is not an issue, this is how npm works. The bare imports have been discussed many times.
Please see https://github.com/Polymer/polymer/issues/5411#issuecomment-477364441 for explanation by the Polymer team.


Firebase Performance

I am trying to integrate a custom trace for my ionic app, However Visual studio code says that the startTrace and stopTrace functions are not part of the Firebase plugin and I get a similar issue when trying to deploy on my device via the command line. Is this feature implemented yet?

Hey, did you make any progress with this? I can call startTrace and stopTrace fine without error, but I can't see my traces coming through.

I haven't tried start and stop trace recently. I just wanted it to measure
app latency for my API calls. Instead I just created an event and kept
track of the time difference before and after the event. Not as much data
but got the job done.
On Mon, Jul 30, 2018, 10:15 PM MumblesNZ<EMAIL_ADDRESS>wrote:

Hey, did you make any progress with this? I can call startTrace and
stopTrace fine without error, but I can't see my traces coming through.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/arnesson/cordova-plugin-firebase/issues/741#issuecomment-409097565,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AeD4VDDVWXnto5KCJU6L2QiqRfqNJT7iks5uL-gOgaJpZM4UqjzT
.

closing as resolved


Adding a variable to specify the date format used by controller.

Hi! Can you remove the commit with the dist folder and rework your first commit message according to the contributing guidelines please?

Dist folder removed and commit message changed.

Great work @daniel-oliveiravas !

Ok, now it's easier to look the code, thanks! There is a little problem, the format is not dynamic. It will only use the one set at init. The easier way to fix this is to always use $scope.dateFormat inside the directive instead of re-assigning to the var dateFormat. And doing that, you need to make sure that it's always initialised, so add a test in the init or link function (like in the search field).
And could you change your "if" line 18 to be in Allman style while you're doing that? (meaning the brace must be on a new line)
Thanks a lot for the PR!

We've just released LumX v1.0.0rc1. This new version add the option, so I'm closing your PR. Thank you!


Implement Data Analytics

With the upcoming rework of the ClemBot database and the addition of an API, I was thinking this would be a suitable time to start implementing some data analytics functionality in the bot.
Suggested analytics to track (feel free to propose others):

Global usage of commands and subcommand (perhaps also track emoji reactions too? e,g, page-turning)
Server-by-server usage of the above. Server owners could perhaps also be given access to the analytics for their respective servers
Error tracking (what server, user, and the message did the error come from)

These trackers should not merely be counters but should also track the rate of usage so that analytics visualizations/plots can be generated to better understand how ClemBot is being used. For example, there could be a table of hour-by-hour (or even minute-by-minute) usage of ClemBot. This could be helpful for dealing with spam attacks meant to bog down the bot if that were to ever become an issue.
This information could prove useful in the future for prioritizing which proposed features to implement first, as well as for tracking errors and figuring out what is causing them.

This feature has partially been implemented right?

No it has not, this is kinda an ongoing tracking feature


[Documentation Bug]: Fixing grammatical errors in CODE_OF_CONDUCT.md file

Describe the bug ✍
This bug report is about fixing grammar mistakes in the CODE_OF_CONDUCT.md file. The document has some errors that need to be corrected for better understanding. The goal is to make sure everyone can easily understand the Code of Conduct.
Provide step by step information reproduce the bug 📄

Read the CODE_OF_CONDUCT.md file.
Find any mistakes in grammar or wording(spellings).
Correct the mistakes following language rules.
Check the changes for accuracy.
Submit the corrected file for review.

Select program in which you are contributing
GSSoC24
Code of Conduct

[X] I follow CONTRIBUTING GUIDELINE of this project.

I'm eager to work on this issue. Please assign one to me.


Non-string types are not included in the URL parameters for GET requests

Started playing around with this API tonight and noticed an issue
Any parameter from any of the Codable objects that's not a string is not included in the queryItems for the URLRequest
The issue comes from this code
https://github.com/rrainn/Lemmy-Swift-Client/blob/57aba1d4b642882b34089017342f3b5c103f5a83/Sources/Lemmy-Swift-Client/Lemmy_Swift_Client.swift#L19-L23
Casting the value as String always returns nil for all the datatypes that aren't a String (int/enums, etc)
This gets a little more annoying to fix too as Mirror returns non-nil value even when nil so using String(describing: value) doesn't work either
One option would be to cast to CustomStringConvertible but you would also need to make all your enums conform to this protocol to work, which I guess wouldn't be that difficult
The other option which is working in my quick testing is to just serialize it to JSON and then use String(describing: value) like this
			request.url = request.url?.appending(queryItems: mirror.children.compactMap { (label, value) in
			let encoder = JSONEncoder()
			if let data = try? encoder.encode(apiRequest), let jsonObject = try? JSONSerialization.jsonObject(with: data, options: []), let parameters = jsonObject as? [String: Any?] {
				request.url = request.url?.appending(queryItems: parameters.compactMap { key, value in
					guard let value else { return nil }
					return URLQueryItem(name: key, value: String(describing: value))
				})
			}

Happy to put together a pull request for either approach

Potentially can be closed with https://github.com/rrainn/Lemmy-Swift-Client/pull/4


[Bug] Use find instead of include to match tags

Description
Improper use of includes resulted in taggedInfoObject being undefined. This, in turn, led to a broken link config when setting categoryLinkSource to "info", which, in turn, resulted in info docs not associated to a sidebar.
Before:
      const taggedInfoObject = intros.find((i) =>
        i.tags ? i.tags.includes(tag) : undefined
      );

After:
      const taggedInfoObject = intros.find((i) =>
        i.tags ? i.tags.find((t: any) => t.name === tag) : undefined
      );

Motivation and Context
bug fix
How Has This Been Tested?
tested with MT Monitor API using multi-spec
Screenshots (if appropriate)
https://user-images.githubusercontent.com/9343811/199828973-344dbfe1-8c5d-44ca-85a4-4ac08a08d011.mov

Also tested with CSPM API:
{
    type: "category",
    label: "Access Keys",
    link: { type: "doc", id: "cspm/prisma-cloud-access-keys-api-overview" }, // seems to be working as expected
    items: [
      {
        type: "doc",
        id: "cspm/get-my-access-keys",
        label: "List Access Keys",
        className: "api-method get",
      },
...


[tests-only] Remove passing tests from pending state

Bump oCIS commit-id for the tests
Todo:

[x] unauthenticated/*
[x] unauthorized/*
[x] appsTest
[x] capabilitiesTest
[x] filesTest
[ ] fileTrashTest
[ ] fileVersionTest
[ ] groupTest
[ ] loginTest
[ ] publicLinkTest
[ ] requestOcsTest
[ ] shareRecipientTest
[ ] sharingTest
[ ] sharingWithAttributesTest
[ ] signedUrlIntegrationTest
[ ] userTest

Blocked until https://github.com/owncloud/owncloud-sdk/pull/1085


Why can not set eval dataset in examples/lora_single_gpu/llama3_lora_sft.yaml ??

Reminder

[X] I have read the README and searched the existing issues.

System Info
Why can not set eval dataset in examples/lora_single_gpu/llama3_lora_sft.yaml ??
if i set eval_dataset in examples/lora_single_gpu/llama3_lora_sft.yaml, there will be a exception:
Traceback (most recent call last):
File "/home/work/vllm-env/bin/llamafactory-cli", line 8, in
sys.exit(main())
File "/home/work/llm_test_lz/project/LLaMA-Factory/src/llamafactory/cli.py", line 96, in main
run_exp()
File "/home/work/llm_test_lz/project/LLaMA-Factory/src/llamafactory/train/tuner.py", line 27, in run_exp
model_args, data_args, training_args, finetuning_args, generating_args = get_train_args(args)
File "/home/work/llm_test_lz/project/LLaMA-Factory/src/llamafactory/hparams/parser.py", line 130, in get_train_args
model_args, data_args, training_args, finetuning_args, generating_args = _parse_train_args(args)
File "/home/work/llm_test_lz/project/LLaMA-Factory/src/llamafactory/hparams/parser.py", line 116, in _parse_train_args
return _parse_args(parser, args)
File "/home/work/llm_test_lz/project/LLaMA-Factory/src/llamafactory/hparams/parser.py", line 43, in _parse_args
return parser.parse_yaml_file(os.path.abspath(sys.argv[1]))
File "/home/work/vllm-env/lib/python3.10/site-packages/transformers/hf_argparser.py", line 423, in parse_yaml_file
outputs = self.parse_dict(yaml.safe_load(Path(yaml_file).read_text()), allow_extra_keys=allow_extra_keys)
File "/home/work/vllm-env/lib/python3.10/site-packages/transformers/hf_argparser.py", line 377, in parse_dict
raise ValueError(f"Some keys are not used by the HfArgumentParser: {sorted(unused_keys)}")
ValueError: Some keys are not used by the HfArgumentParser: ['eval_dataset']
Reproduction
CUDA_VISIBLE_DEVICES=0 llamafactory-cli train examples/lora_single_gpu/llama3_lora_sft.yaml
Expected behavior
No response
Others
No response

We have not implemented this feature


Support for mGPU

The DirectX Tool Kit  for DirectX12 does not expose the ability to set the node for multi-adapter use, so it only supports the 0th node as it is.
For details, see MSDN

See this pull request


Create an day reports list view

Good to know:

[ ] Look at https://app.steady.space/

duplicated #115


Add note about setting invalid property in validation demos

It's unclear for users what's happening to text-field when it contains invalid value.
(This is the DX tests finding)

The demos are pretty much rewritten since this ticket was opened. Closing.


fix(footer): fix the onlineMember number error

fix:issue#106
ref: PR #6e3a3
I test in my local environment. OnlineStatus filed works as I expected. So it might be the API can't get it correctly.
I think the reason why the number of people online has remained unchanged is that the original code has been reading global variables from memory. (I'm not sure if it works online)
There is old code in PR#6e3a3 in object/basic.goline 71
func GetHighestOnlineNum() int {
	if highestOnlineNum != 0 {
		return highestOnlineNum
	}
...

This if statement makes the same value return all the time. So I think this may cause the result we got always 41.

Here I test in my local environment:
before:

And I request the API http://localhost:7000/api/get-online-num.

after:

It seems that onlineStatus could affect onlineNumber normally now.

Here I test in my local environment:
before:

And I request the API http://localhost:7000/api/get-online-num.

after:

It seems that onlineStatus could affect onlineNumber normally now.

@oceanlvr another requirement is:

Don't calculate the online member count in real-time for each request.
Use a cache to store online member count, re-calculate cache every 10 minutes.

@oceanlvr another requirement is:

Don't calculate the online member count in real-time for each request.
Use a cache to store online member count, re-calculate cache every 10 minutes.

I think the reason that causes the variable to remain unchanged is that the timed task fails to load correctly.
Solution: This PR should be rolled back. And Try to restart the project.
Reason: In the online database, the field CronUpdateJobs is missingexpireOnlineMember configuration.  (CronUpdateJobs manage the Timed task. package Cron read from CronUpdateJobs and update every hour)

I think the reason that causes the variable to remain unchanged is that the timed task fails to load correctly.
Solution: This PR should be rolled back. And Try to restart the project.
Reason: In the online database, the field CronUpdateJobs is missingexpireOnlineMember configuration.  (CronUpdateJobs manage the Timed task. package Cron read from CronUpdateJobs and update every hour)


The -cpuprofile flag no longer works

I was working on a fix for issue #1377 and was surprised that

the default elvish binary did not support the -cpuprofile flag, and

that building with go build -o ./elvish ./cmd/withpprof/elvish did not result in an Elvish binary that correctly handled the -cpuprofile flag. With, or without, my fix for handling the exit command.

The reason for both issues is commit 33a04f8dc, merged seven months ago, that refactored the code in response to the desire to minimize the size of the elvish binary for unusual situations. Such as using elvish as a shell in an embedded environment where every byte in the size of the binary matters.
Issue #1 is because we now have to do something like go build ./cmd/withpprof/elvish rather than simply running make get (which, FWIW, I have never liked as a make target name).
Issue #2 is because the defer in the cpuprofile setup stops profiling when the pprof Run() function returns. Which is before anything useful to be profiled is executed.
On my macOS ARM system the elvish binary without pprof support is 9.5 MB, and with it the size is 9.8 MB. That is a 3.2% increase in size for profiling support. Performance metrics are extremely useful; especially in a relatively new shell like Elvish that is undergoing rapid development. A borderline insignificant increase in the size of the binary is worthwhile, IMHO, to make it easy to capture performance metrics that will help us figure out where it is most advantageous to make performance improvements.

For those wondering about the rationale for commit 33a04f8: It was primarily in response to the u-root project wanting an easier way to build an Elvish binary that did not include support for the interactive history daemon. That project desired a shell written in Go whose binary was as small as possible. They had been using an old version of the source that they had edited by hand to eliminate the daemon. But users of that project were unhappy that the documented behavior of the current Elvish version was very different from the (old) version they provided. So we restructured the Elvish source to include a cmd/nodaemon build target so that the u-root project would have  way to depend on a current version of Elvish with minimal effort. As part of that work @xiaq decided to also make support for the -cpuprofile flag optional and not included in either the standard or no-daemon Elvish binary.
Rather than fix the cmd/withpprof build target I'm inclined to simply undo commit 33a04f8 and move profiling support back into the standard Elvish binary; which means it will also be part of the cmd/nodaemon target used by the u-root project. While this will increase the size of the Elvish binary the difference is small and shouldn't be a problem -- even for the u-root project. Too, the utility of always being able to get profiling data is going to be valuable as we begin focusing more on performance and less on changes to the syntax of Elvish.

Should there should be separate -cpuprofile and -memprofile flags or a single -profile flag that enables both profiles with distinct file names using the -profile argument as a prefix? As I write this the change I am working on has distinct flags for consistency with the Go tools.

While this will increase the size of the Elvish binary the difference is small and shouldn't be a problem -- even for the u-root project.

I am also of the opinion that if the small (~3%) size increase is a problem for the u-root project then the nodaemon build should be modified to also explicitly exclude profiling support. That is, profiling should be enabled for standard Elvish builds.

The discussion regarding P.R. #1606 makes it clear that simply moving profiling support back into the primary Elvish binary is not an acceptable solution. So the question is how to fix the problem in the current cmd/withpprof/elvish build target that causes it to not emit profiling data. Also, when fixing that problem support for a -memprofile option should be added.

Regarding other points:

Re -memprofile: there are two different types of memory profiles, heap and allocs. heap doesn't make sense as a global flag; I added support for allocs and the flag is called -allocsprofile.

Re the name nodaemon: it describes the difference with the "default" variant in cmd/elvish. Renaming it "tiny" may become necessary in future if it sheds more components, but doesn't make so much sense now.


Upgrade camshaft version to 0.59.1

This fixes the duplicated column names problem for aggregate-intersection
See https://github.com/CartoDB/camshaft/pull/331
This has been tested in staging.

@dgaubert I'll clean up those yarn.lock conflicts tomorrow, then ping you when it is ready for CR

Will create a new PR for this, branching off from master to reduce clutter


Feature: Support Alpha channel in colours

Hi there,
it would be great to have the option to pass in a background or a text colour that supports alpha channels with the RGBA format #RRGGBBAA or #RGBA, e.g.
https://ui-avatars.com/api/?background=a0a0a00f
The nice thing about beeing able to set an alpha channel, is that it can also be set to a semi transparent level, not just fully transparent or fully visible.
Btw: The url with the 8 digit colour code currently results in a broken 0x0 pixel image.
Cheers

I've realised, that you're using Intervention/image and that they currently don't support an alpha channel via hex and therefore opened an issue  there as well.

Very good idea! I will look into a solution — definitively something I'd want it to support


Documenting test queries in web of science

"Amazon Flex" + driver
1 result: https://www.webofscience.com/wos/woscc/summary/b8173632-ce3c-4f57-b2ea-6d04c24db605-80bff1a3/relevance/1

Uber + driver
386 results: https://www.webofscience.com/wos/woscc/summary/58235fbc-9a27-4cd1-91ce-98e124625a3d-80c049f4/relevance/1

familar friends Hall & Krueger, Roseblat & Stark, Chen (the Uber economist), Katie Wells
studies on the mental health of drivers..."technostress"; the taxi industry
case studies in specific countries: Poland, Taiwan, Australia, Brazil, India, Canada -- this seems like a good sign

DoorDash + restaurant
2 results: https://www.webofscience.com/wos/woscc/summary/39b3f3d7-6091-4eab-9150-1f6918436be0-80c10ada/relevance/1

I expected a small number of results - there may be a better approach for collecting publications that aren't about TNCs

"delivery network company" OR "third-party delivery" OR "DoorDash" OR "Gojek" OR "Shipt" OR "Caviar" OR "Roadie" OR "Jumia Food" OR "Deliveroo" OR "Foodora" OR "Swiggy" OR "PedidosYa" OR "Rappi"

1286 results
Caviar returns studies about caviar the food (273 results are in Marine Biology, and more scattered across Dairy & Animal Sciences, genome sciences, molecular biology, and other physical sciences)
Eliminating Caviar as a search term yields 85 results - a mix of studies about delivery logistics, economic sustainability of the delivery sector, labor protests
Shipt and Rappi returned a few non-relevant studies

Next steps:
Decide on a set of queries that includes

Modified (e.g. ridehail)
Add companies or platforms from LS list of most prevalent
Keep DNC vs TNC datasets separately


Make requirements more flexible for boto-related dependencies

Hi guys!
When trying to install from the recent versions of bionty, it seems the restrictions for boto-related packages added in https://github.com/laminlabs/lndb-storage/pull/7 make it difficult for pip to solve for them in an environment with many requirements.
Would it be possible to loosen up the requirements for these packages?
Thanks,
James

Thank you @jggatter , we will think how to simplify dependencies overall.
The problem with these boto-related pins is that they come not from us actually, but from s3fs through aibotocore, where the pins are done in a rather strange way that causes problems. This is why we pin them here to actually simplify installation. Now probably it doesn't help anymore. I will update fsspec to the most recent version soon, maybe it will help on its own.

Understood. It's the same problem I was experiencing yesterday when trying to install bionty. It's not an uncommon problem, and it's something unfortunate that pip acknowledges (https://github.com/pypa/pip/issues/8713).
My workaround was to pin the same versions of botocore and boto3 in my project as what is pinned here. That seems not to have conflicted with dependency requirements of other packages. It's likely not the best long-term solution, but I can be attentive about updating the requirements.
Just for my understanding, would it be possible for a wider range of fsspec versions to be accepted? I see other packages like pandas and prefect allowing for more flexibility with fsspec.


Allow generation from PURE to Rosetta code

Add ability to generate Rosetta syntax from PURE code for all types (synonyms, enums, classes and functions).
Ideally we start of a with metamodel in pure to represent these concepts and then transform into that metamodel before projecting as string.
The current version which projects directly to string lives here: https://github.com/finos/legend-pure/tree/master/legend-pure-code-compiled-core/src/main/resources/core/external/format/rosetta

This issue is stale because it has been open for 30 days with no activity. Please remove stale label or add any comment to keep this open. Otherwise this will be closed in 5 days.

This issue was closed because it has been inactive for 35 days. Please re-open if this issue is still relevant.


Tap gesture in Onboarding?

Hello!
Is it possible to add tap gesture in on-boarding?
So that user could go to the next screen not only with swipe but also with tap (come back to the previous screen only with swipe, obviously).
Thank you.

@IVANKRUPSKI Sure, it's easy enough to do!
The on-boarding example is entirely driven by a scrollview, so in order to achieve this you would simply add a button that sets the scrollview offset to the following page, and the animation will update as the scrollview scrolls.
Does that help?

Yea,
Thanks, Steve!


Fix backdrop video

VideoPlayer now requires playerState and playerActions.
REDMINE-17588

Coverage remained the same at ?% when pulling 59f64ed505ecf9d4210e168603b71dece7269f28 on tf:fix-backdrop-video into a2e5d664392c327d6750b4fefbbdd8973bf7159e on codevise:master.


I have created branch and file and commit, and open a pull request

I have created a branch, a file, commit and a pull request

I have created a branch, file, commit and a pull request please feel free to add anything


openssl-genpkey documentation for the DSA/DH params is controversial

Documentation for openssl-genpkey parameters generation is controversial and confusing.
How can we generate DH and DHX parameters? DH is PKCS#3 style DH, while DHX is X9.42 style DH. But then its not clear what dh_paramgen_type does, since that is documented as meaning 0 == PKCS3 and 1 == X9.42. What happens if you do "-algorithm -DHX" but with "dh_paramgen_type:0", vs "-algorithm DH" with "dh_paramgen_type:1" what kind of params do you get (note the PEM headers are different for DH vs DHX)
Its also unclear from this test what "pbits" and "qbits" options do. Qbits is only documented for DSA not DH on the genpkey page, and pbits isn't documented at all except it appears in one of the genpkey examples (for DSA).
From here: https://github.com/openssl/openssl/pull/13930#discussion_r563637923

dh_paramgen_type is currently ignored and that is a bug.

dh_paramgen_type is currently ignored and that is a bug.

qbits doesn't seem to make a lot of sense for PKCS#3 DH (which has no q parameter)

qbits doesn't seem to make a lot of sense for PKCS#3 DH (which has no q parameter)

Reported #13956 for the dh_paramgen_type being ignored.

Reported #13956 for the dh_paramgen_type being ignored.

qbits doesn't seem to make a lot of sense for PKCS#3 DH (which has no q parameter)

Removed it from the generating script

qbits doesn't seem to make a lot of sense for PKCS#3 DH (which has no q parameter)

Removed it from the generating script

The doc is not quite right. What this does in 1.1.1 is actually..
0 = use generator                                           (Assigns to DH type key)
1 = fips 186-2 gen (this is less than ideal)     (Assigns to DHX type key)
2 = fips 186-4 gen                                           (Assigns to DHX type key)
And yes the -algorithm parameter is problematic..

This is currently problematic in another way with providers in that the application must decide the keytype first, then feed it all the parameters.  We have no mechanism for changing keytype under the hood.

This is related to #13871 and #13956

Documentation is updated..
The dh_paramgen_type is just ignored if the group is set which is also documented.


Home Page Overhaul

Navbar with search is consistent with other pages. Overrides home page index from Sufia to start customizing page. Hides other partials to work on customization. Moves the share section out of the index, removes a lot of extra divs and styles, makes a row and two columns for the marketing text and share.
Adds typography style sheet to override default Bootstrap styles. Fixes up some styles with overrides and roughs in the basic spacing and layout.
Adds the announcement box back in, super horrible overrides for style, and adds moar bootstrap syntax. Updates the styles for the announcement section and uses moar ugly overrides because of the very specific declarations from Sufia. Adjusts spacing and styles for the announcement section and the home tabs with content.
Moves the search box to its own row below the marketing row.
Removes the white background on the announcement text and makes the text white.
Addresses the following:

#437
#438
#439
#481


Helm 3 changed release name parameter of helm template

Helm 2:
helm template [flags] CHART

Helm v3.0.0-alpha.1:
helm template [NAME] [CHART] [flags]

This makes usage incompatible:
$ helm template --name my-release-name path/to/chart
Error: unknown flag: --name

and having two positional (= unnamed) arguments is not a good idea in general since the order can be mistaken. I recommend reintroducing {-n,--name}.

@AndiDog First off, I think it's pretty fine for it to be incompatible considering the version change is a major version change v2 -> v3
About the order being mistaken, for me it doesn't sound like a solid reason. And even if it's considered as a solid reason, there will be some set of people saying otherwise - to use arguments instead of flags. The helm maintainers cannot satisfy everyone with both the features. I think users need to understand their opinions.
Apart from this, some things to notice or think about:

Consider the upgrade sub command which has release name as an argument in both v2 and v3. I think it's great to keep both install and upgrade sub command consistent.

In v2, helm install has release name as an optional flag and if it's not specified, it uses a generated name - which I wasn't comfortable with when doing production deployments and from what I know, release names cannot be renamed which makes the situation a hassle. In v3, this cannot happen as in v3, release name is a required argument, and if you want generated name, you specify a flag for it and then you can omit the release name.

Many tools take up "main input" as arguments (required/optional) and take flags as input for modifying behavior. Check rg, fd tools for examples. I think "main input" is a very relative word. Of course it's up to the tool's builder to choose what's best for their tool, users and the UX

And for me personally, it felt weird to have the release name as a flag rather than an argument.

The release name was made mandatory as part of Helm 3. Helm will not auto-generate a name for you unless you use the --generate-name flag.
So, to replicate the same behaviour, use helm template --generate-name ....


Access to pipeline variables

I want to write a pipeline definition (specifically, a reusable template) that will not run a job if a given variable has not been set for the pipeline. Something along the lines of:
condition: and(succeeded(), ne('', ${{ parameters.token }}))

where the user may pass in:
parameters:
  token: $(TOKEN_SECRET)

where TOKEN_SECRET here is a variable that is defined in the web UI as a secret pipeline variable. If the secret variable is available (i.e., we are not in testing a PR, or secrets in PRs is enabled), then the job should run. Otherwise, it should not.
Currently, this does not work. I get the error
Unrecognized value: '$'.

when trying to parse the condition. I have also tried
parameters:
  token: variables['TOKEN_SECRET']

but this value appears to always be empty, even when secrets are supposed to be available.
I suspect that the reason for all of this is that variables are not generally available at the "planning stage", or whatever it is called, only at runtime. However, it seems like an exception should be possible for pipeline-defined variables?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 3f151218-9a11-0078-e038-f96198a76143
Version Independent ID: 09c4d032-62f3-d97c-79d7-6fbfd89910e9
Content: Conditions - Azure Pipelines
Content Source: docs/pipelines/process/conditions.md
Product: devops
Technology: devops-cicd
GitHub Login: @andyjlewis
Microsoft Alias: alewis

Same issue.

For what it's worth, I ended up using this unfortunate workaround.

@jonhoo Thank you for the feedback.
Secrets are covered in https://docs.microsoft.com/azure/devops/pipelines/process/variables?view=azure-devops&tabs=yaml%2Cbatch#secret-variables.
I'll take a look at adding a note or work-around.

@msebolt I saw that page, but as far as I can tell it does not address any of the points from my original post? If it does, could you please point me at the relevant text?

Sorry for the delay on this.
@jonhoo I was only referring to the documentation that would state exceptions to using secrets.
Assigning to author.

Thanks for your question. It looks like your question isn't an issue with the documentation, but an issue or question specific to your implementation or a bug in the product itself.
For help with a specific task, here are a couple of options where you might consider asking your question:

Azure DevOps on Stack Overflow
Azure DevOps Support Bot

If you've encountered an issue with the product itself, to make sure it gets in front of the right people, please submit your bug here.
If you have an idea for improving the product, please submit your idea here.


[DEVOPS - BUG] FCD not working correctly

There are currently 2 issues

fcd_collector service exits with

Jul 17 18:04:57 lcd-mainnet bash[1062284]: Error: getaddrinfo EAI_AGAIN lcd.palomachain.com
Jul 17 18:04:57 lcd-mainnet bash[1062284]:     at GetAddrInfoReqWrap.onlookup [as oncomplete] (node:dns:109:26)

and
07-17 18:05 [ERROR]: Connect Timeout Error
Jul 17 18:05:34 lcd-mainnet bash[1063828]: ConnectTimeoutError: Connect Timeout Error
Jul 17 18:05:34 lcd-mainnet bash[1063828]:     at onConnectTimeout (/home/fcd/fcd/node_modules/undici/lib/core/connect.js:182:24)
Jul 17 18:05:34 lcd-mainnet bash[1063828]:     at /home/fcd/fcd/node_modules/undici/lib/core/connect.js:129:46
Jul 17 18:05:34 lcd-mainnet bash[1063828]:     at Immediate._onImmediate (/home/fcd/fcd/node_modules/undici/lib/core/connect.js:170:9)
Jul 17 18:05:34 lcd-mainnet bash[1063828]:     at processImmediate (node:internal/timers:466:21)

lcd_api service exits with

]: 07-17 18:07 [INFO]: Paloma FCD Suite is listening on port 3060
Jul 17 18:07:35 lcd-mainnet bash[1069654]: 07-17 18:07 [INFO]: RPCWatcher: connection lost
Jul 17 18:07:35 lcd-mainnet bash[1069654]: 07-17 18:07 [ERROR]: RPCWatcher: error: TIMEOUT
Jul 17 18:07:35 lcd-mainnet bash[1069654]: /home/fcd/fcd/node_modules/ws/lib/websocket.js:285
Jul 17 18:07:35 lcd-mainnet bash[1069654]:       abortHandshake(this, this._req, msg);
Jul 17 18:07:35 lcd-mainnet bash[1069654]:       ^
Jul 17 18:07:35 lcd-mainnet bash[1069654]: Error: WebSocket was closed before the connection was established
Jul 17 18:07:35 lcd-mainnet bash[1069654]:     at WebSocket.close (/home/fcd/fcd/node_modules/ws/lib/websocket.js:285:7)
Jul 17 18:07:35 lcd-mainnet bash[1069654]:     at ReconnectingWebSocket._disconnect (/home/fcd/fcd/node_modules/reconnecting-websocket/dist/reconnecting-websocket-cjs.js:539:22)
Jul 17 18:07:35 lcd-mainnet bash[1069654]:     at ReconnectingWebSocket._handleError (/home/fcd/fcd/node_modules/reconnecting-websocket/dist/reconnecting-websocket-cjs.js:180:19)
Jul 17 18:07:35 lcd-mainnet bash[1069654]:     at ReconnectingWebSocket._handleTimeout (/home/fcd/fcd/node_modules/reconnecting-websocket/dist/reconnecting-websocket-cjs.js:529:14)
Jul 17 18:07:35 lcd-mainnet bash[1069654]:     at Timeout.<anonymous> (/home/fcd/fcd/node_modules/reconnecting-websocket/dist/reconnecting-websocket-cjs.js:524:75)
Jul 17 18:07:35 lcd-mainnet bash[1069654]:     at listOnTimeout (node:internal/timers:559:17)
Jul 17 18:07:35 lcd-mainnet bash[1069654]:     at processTimers (node:internal/timers:502:7)

already done  during trouble shooting in /home/fcd/fcd/run_collector.sh and /home/fcd/fcd/run_api.sh

updated endpoints from lcd2 and rpc2 to lcd and rpc since lcd2 and rpc2 are not yet set up in namecheap
updated chain id to tumbler
updated initial_height to first block on tumbler (15841320)

Closing for now.


[CI] testing

Signed-off-by: Esteban Martinena<EMAIL_ADDRESS>

Reusable CI implemented here https://github.com/open-rmf/rmf_traffic/pull/89


Added a bit more description on what the plugin does

This is probably not the best description of the plugin functionality and usage but that's a start. The rest can probably be easily picked up from the source code.

:waning_gibbous_moon:


Add policy.open-cluster-management.io healthchecks

This is a pre-community PR for squad review.

/hold for others