Writing SCF module

SCF code with functions working, testing using Travis CI

Testing completed, need code comments

Code comments left as separate issue


Split bundle_skel.sh into bundle_skel_.sh

bundle_skel.sh is split into

installer/bundle/bundle_skel_AIX.sh
installer/bundle/bundle_skel_HPUX.sh
installer/bundle/bundle_skel_Linux.sh
installer/bundle/bundle_skel_SunOS.sh

Change Linux bundle to install/upgrade all packages as a set

Okay, there's lot of remaining cleanup here, particularly for UNIX platforms. I only reviewed the first UNIX file (AIX), assuming you'll make all related changes to the other UNIX files (HP, Solaris). And I want to use your time efficiently. So here's my proposal:

Clean up AIX and all other UNIX files,
Clean up Linux file,

Do a limited test pass. By that, I mean: Do a pbuild, and install on at least one flavor of each platform (AIX 6.1 OR AIX 7.1, don't bother doing both; one HP, one Solaris, and one Linux). Then send me an updated PR. I'll do one final pass and, assuming no remaining problem will sign off.
At that point, assuming no further changes, do a complete test pass (install on all platforms that we support) and commit. If any of the tests fail, then fix that platform and rerun all installation tests for that platform.
The idea here is that, for the final set of changes, you want to install and upgrade on every single platform at least once. But you don't need to do that if you know further changes are coming down the line. And I don't want to catch typos that at least a basic install / upgrade would have caught.
Seem reasonable? If so, do another cleaning pass and send me a new PR, thanks. Hopefully you can get to this quickly; I think we'd both like to wrap this up in the next day or so.
Nicely done, by the way. Having one combined file was a real mess after a while. I think these improvements will make a big difference in maintainability. Imagine just testing on Linux if that's all you changed! :smile:

Very nicely done. I wish these changes were in place years ago, it would have made our maintenance work a whole lot easier. You really did do a great job with this, it's so much cleaner and nicer, and it will pay off in spades with easier maintenance down the road.
If you make any further changes, verify your installation tests. If you took shortcuts in prior installation tests, do full testing now (after any final changes). You want to try hard not to commit something broken to master considering we're getting close to shipping the 2016 version.
You have sign-off. I did note that you have two separate commit messages. Please merge this into one meaningful commit message before merging to master. If you need instructions on how to do that, let me know, although I think it's documented (more or less) in ostc-docs.

The git reset --soft HEAD^ command basically says "undo the last commit, but keep any source changes made in that commit staged". Thus, when you git commit --amend, the reset changes are merged with the prior changes.

Thanks for all the guidance.  I've included the additional comments related to OMI_EXIT_STATUS and the changes needed in the sunos skeleton.
I squashed the commits and did thorough checking :

pbuild
upgrade (with and without --force)
install

on all the pbuild platforms (as well as on an RHEL vm).
Linux Comparison Code to SunOs skeleton : I will send these changes in a separate PR.
Removing PROVIDER_ONLY for Linux :  I will club this too with the above new PR. I will analyze the impact on make and configure before I do so.


[Bug]: Error during database creation

Contact Details
<EMAIL_ADDRESS>What happened?
While trying to create a database, I got this error:
Error creating database "" : TypeError: kr.getDataviewAPI(....).isDataArray is not a function
No database is created.
What platform were you using?
Desktop
Version of the plugin
3.3.1
Relevant log output
app.js:1 Error: [CM6] tree.iterate has changed syntax.
See the stack trace to find the faulty plugin and file an issue with the plugin author.
Details: https://discuss.codemirror.net/t/release-0-20-0/4302
    at app.js:1:1045852
    at e.iterate (app.js:1:501709)
    at e.Uc.iterate (app.js:1:1046086)
    at Object.build (plugin:obsidian-admonition:766:2080)
    at Object.update (plugin:obsidian-admonition:766:1896)
    at e.update (app.js:1:350332)
    at e.updatePlugins (app.js:1:440837)
    at e.update (app.js:1:439009)
    at e._dispatch (app.js:1:436036)
    at e.dispatch (app.js:1:437814)

Are you using the latest version of the plugin in your Obsidian vault?

[X] I have verified that I am on the latest version

Are you check if there is a similar issue?

[X] I have verified that there are not similar issues

Hello @gbeyrend ,
It looks like a problem with obsidian-admonition in base of the logs you shared. Could you try to disable it and try to create another db?

Thank you very much for your swift answer. I tried it and it didn't work. It. was misleading because I actually didn't paste the whole log. Here is the correct log :
ParseService.ts:59 Uncaught (in promise) TypeError: kr.getDataviewAPI(...).isDataArray is not a function
at Tm.parseDataArray (ParseService.ts:59:12)
at Tm.parseLiteral (ParseService.ts:29:9)
at x2.parseValueToThuthyYaml (databaseHelperCreationModal.ts:250:29)
at x2.eval (databaseHelperCreationModal.ts:61:50)
at Generator.next ()
at eval (Constants.ts:14:11)
at new Promise ()
at a (plugin:dbfolder:1:697)
at eval (databaseHelperCreationModal.ts:60:70)
at t.onChanged (app.js:1:1140355)

kr.getDataviewAPI(...).isDataArray is not a function it's a dataview tool.
I want to resolve your problem but I can not relate the bug
The lines:
https://github.com/RafaelGB/obsidian-db-folder/blob/7cf3d16e1da05820a3beaf11566692e6ffd29d7e/src/services/ParseService.ts#L45

Neither do I, even if I am more an R user. I don't see what I am doing wrong, I have the same version as others, no conflicts with other plugins. Maybe, if possible, would you have 15 minutes one day to check with me remotely in private @RafaelGB ? I don't see the reason why the plugin is not working for me.

I got the same error; I'm using the latest software and plugins:
obsidian v1.1.16
dataview 0.4.21 (just updated it today)
From the error, it seems that it has something to do with Dataview,  seems that it did not get its parameter? It's worth mentioning that I also fail to use MetadataMenu 0.4.21 properly, a plugin that I just tried out today, which relies on dataview. This plugin tells me "plugin is not a valid fileClass" when I follow the tutorial.

I tried creating a database by right-click on a folder and choosing "new database folder", then a new page including the following error information shows up:

Update: I installed the latest mobile version on android, then the database file can be created properly, and I can add rows to create files; however, seems that I can't add column, even though a message showing that it has been created successfully, I can't see the column appearing in the table. Moreover, if I try to type something in the a cell within the table, the same error message as on the desktop version appears.
FYI, the vault folder on the android was copied from my desktop.

I saw more bugs here; for example, if I use "Tag" column in the clean new vault, I can type arbiratry string to create new tags, but in my previous vault, typing arbitrary strings only lead to "no options"

I'm wrong in saying that the above bug does not appear in a new vault; however, I found a solution to this problem, though I believe that there still might be a bug here. Please see the relevant post:
https://github.com/RafaelGB/obsidian-db-folder/issues/850#issue-1623788020

I will create a custom isDataArray function to control this kind of error.
I'm sorry for the delay in responding, I moved house

as I said in the previous reply， this bug disappears after I uninstall dataview totally and reinstall it, though I found another relevant bug. Please see #850

however, the file icon issue persists in my vault, though this issue does not occur in a clean new vault.

to summarize, the dataview issue disappears after I uninstall dataview and install it again, though the icon issue as shown in the previous reply can occur in my previous vault, though it does not appear in a clean new vault.
BTW, I found that I'm not the only one that suffers of the icon issue; I saw a tutorial video on db-folder on internet, and I  notice that the icon issue also appears in that tutorial video, though the poster didn't realize this as a bug.
The second relevant issue here is the #850, which is associated with creating and using tags in a database file.

this issue and the control of the dataArray will be controlled with #850 , about the icon problem will be investigate independently, thanks for your testing, I really appreciate it

Can you share a zip with your .obsidian folder to reproduce the problem? without debug it could be difficult to find the source of this mysterious problem

plugins.zip
plugins2.zip
Above are the plugin files within the plugin folder of the new vault, which is created upon copying those within my previous vault into this new vault (tha latter has dataview and dbfoler installed properly).  Of course,  I didn't copy the dataview and dbfolder during the above operation).
Notice that, the new vault (with dataview and dbfolder installed properly) worked properly at first,  but after this paste and restart the vault (I noticed that the newly imported plugins are all disabled by default, which I didn't touch),  the previous rows within a database file got lost, and it reports the following error when I create  a new row:

After I delete those newly pasted plugin folders and restart the vault, the missing rows come back, and I can continue creating new rows.


Include untagged workspace costs

Resolves #2468
What is being addressed
Include untagged resources cost under workspace
How is this addressed

Get resource group by tag
Get costs filtered by resource group list or tag (before change it was only by tag)
Pending work - check if required to rollup costs for workspace services and user resources in sperate resource group
Documentation updated

/test-extended

/test

/test

/test

/test


VMware SD-WAN and SASE Solution v1.0.0

Change(s):

Added new solution: VMware SD-WAN and SASE (v1.0.0)
Included Function App for VMware Edge Cloud Orchestrator API integration
Included Analytics Rules for VMware SD-WAN and SASE
Included Hunting Queries for VMware SD-WAN and SASE
Included Workbook for VMware SD-WAN and SASE

Reason for Change(s):

New Solution Added

Version Updated:

No

Testing Completed:

Yes

Checked that the validations are passing and have addressed any issues that are present:

Need Help

@microsoft-github-policy-service agree company="VMware Inc"

Hello @stlaszlo, Input file and SolutionMetadata file are missing from the Solution folder. Can you please add those.
These files are required for Solution repackaging.
You can refer to this Solution for more info. https://github.com/Azure/Azure-Sentinel/tree/master/Solutions/Armorblox
Input file is present in Data folder

Hello @stlaszlo, Please go on with the above requested changes.

@v-prasadboke ack, work in progress.

Hello @stlaszlo Thanks for letting me know. Update me once when it's done.
You can ping me on teams at<EMAIL_ADDRESS>

@v-prasadboke I've committed the changes, sorry for the delayed update, but the company killed off MS Teams last week :)

@v-prasadboke I've committed the changes, sorry for the delayed update, but the company killed off MS Teams last week :)

Thanks for the updates @stlaszlo, I'll take a look at this changes and let you know before 21 December, 2023.

Hello @stlaszlo, can you please resolve the Code QL errors.
Thanks.

Hello @stlaszlo, Can you please provide write/push access to this Branch.
You can do that by heading over to repo's setting and select collaboration from the left blades and invite me as an collaborator.
Thanks.

@v-prasadboke collaborator invite is out, many thanks for flagging this. I will also check the CodeQL errors and fix them.

Hello @stlaszlo, Solution is missing with data connector. It has azure deploy  file can you please add data connector to it.
Also folder structure inside the zip is missing with python libraries please add it as well.
you can refer to this solutions data connector for more clarification  https://github.com/Azure/Azure-Sentinel/tree/master/Solutions/AtlassianJiraAudit/Data Connectors

Ack, I'll check and fix, thanks.

Hello  @stlaszlo, Any updates on the above mentioned comments,.


Support ANDROID_SDK_ROOT in addition to ANDROID_HOME

I don't know if we need changes outside of this repo, but this should address #15114 which relates to our use of ANDROID_HOME which is now deprecated.
The change currently still prefers ANDROID_HOME since that's what the SDK appears to do:
https://developer.android.com/studio/command-line/variables

If ANDROID_HOME is defined and contains a valid SDK installation, its value is used instead of the value in ANDROID_SDK_ROOT.

The flutter doctor output will list both variables, so aid troubleshooting if something seems wrong.
Note: This changes the Cirrus script to set ANDROID_SDK_ROOT since that's now our "preferred" option (even if we check the other first) - everything seems to pass on my fork, but I don't know if there are any other implications of no longer having ANDROID_HOME set (for ex. in anything that only runs on certain branches).
(cc @dnfield since your name is on a comment about ANDROID_HOME in here!)

@gspencergoog there's a mention of using ANDROID_HOME for Fastlane (https://flutter.io/docs/deployment/fastlane-cd). Is this just because it calls SDK commands, or might there be some requirement to have ANDROID_HOME set for it to work (is it possible to test this before landing?)

(no idea why accepting your text change resulted in these failed builds... I'll rebase in the hope it's something already fixed elsewhere)

I don't know about the Fastlane question.  I think it probably executes some Android SDK commands, but I'm not sure.  @xster, do you know?

I found in some fastlane code it checks both variables:
https://github.com/fastlane/fastlane/blob/c2fa5335777921dc14ab751f28a8a6c07dc4d5ef/fastlane/lib/fastlane/helper/adb_helper.rb#L19
So I think they're probably handling both. @gspencergoog @xster do you think it's safe to land this, or should we try and find some way of testing fastlane locally? (I don't know what's involved).

I think it's probably safe to land: the code falls back, so it should work whether ANDROID_SDK_ROOT or ANDROID_HOME are set, and we can just revert or add ANDROID_HOME back into .cirrus.yml if there's something we're missing.


[FLINK-9682] Add setDescription to execution environment and provide description field for the rest api

What is the purpose of the change
This pull request add setDescription to execution environment and provide description field for the rest api
Brief change log

add setDescription API to execution environment and provide description field for the rest api

Verifying this change
This change is already covered by existing tests, such as (please describe tests).
Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): (yes / no)
The public API, i.e., is any changed class annotated with @Public(Evolving): (yes / no)
The serializers: (yes / no / don't know)
The runtime per-record code paths (performance sensitive): (yes / no / don't know)
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes / no / don't know)
The S3 file system connector: (yes / no / don't know)

Documentation

Does this pull request introduce a new feature? (yes / no)
If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

Travis failed, please investigate.

@zentol yes, this PR did not contain the code about displaying the description of the job on the web page, I want to hear the opinion fro you and @tillrohrmann , how to show the description? display behind the job name in job detail page?

That's really something that should've been cleared up in the JIRA before any line of code was written.
On the spot i can't think of a good place to put it. You would want this description to show up in the job overview, but longer descriptions won't fit in there I believe.

@zentol yes, if the description is very long, that would be not suitable to display, maybe other choose :

show a tip with mouseover event?
pop a window to display?

what about split this issue into two task?

provide a setDescription API
display it on the web page

hi @tillrohrmann what's your idea about the way of showing the description of the job, or split the issue into backend API and frontend presentation?

Hi @yanghua , I think if the description is too long, we can simply cut off the description. It is safe and easy.

@hequn8128 thanks for your suggestion. Yes, cutting off the description is a choice. But currently, for the web UI, if the description does not show in a new line, there is only little zone can be used. In this situation, if we cut off the description would confuse users.

I would be ok with splitting the work between the backend and frontend work.
@zentol  raised an important point which is where to place the content. Wha about the following proposal?

Where the red arrows are we could insert new columns for the description. But I'm not a terribly good web designer...

hi @tillrohrmann I have split the original issue into two issues, this PR for the first backend issue, the second issue will depend on this PR, please review~

@zentol can you review this PR? so that I can start the part 2 of the task as soon as possible. thanks.

cc @tillrohrmann and @dawidwys

@tillrohrmann those locations in the UI work for me

cc @tillrohrmann

@zentol and @tillrohrmann Hope this PR can be reviewed as soon as possible so that we can start the second part.

@pnowojski and @dawidwys Can someone help me review this PR, it seems that Till and Chesnay are busy.

@zentol Can you review this PR?

Not at the moment.

@pnowojski and @dawidwys @GJL can someone help me to review this PR? It also has the other half to complete, but must rely on this PR to be merged before it can begin. Thanks.

@dawidwys I have refactored the PR, please review again. thanks.

@dawidwys any review suggestion?

@dawidwys My original intention was to provide job description information in a form similar to setDescription, which avoids intrusion into modifications to related APIs such as execute(). But your advice is also very good, I have adopted and refactored the relevant code. But japicmp always reports API compatibility errors. My current approach may not be correct. Can you review it and give you some advice?

@tillrohrmann and @aljoscha any opinion about this PR broke the API compatibility?

Hi @zentol , It seems that Till is very busy recently. If you have time, can you look at this PR, it takes too long and often leads to conflicts. After been reviewed by @dawidwys ,  it seems that there should have been no big problems, but there is an API that breaks compatibility and I am trying to exclude only that API. Thanks.

I'm closing this as "Abandoned", since there is no more activity and the code base has moved on quite a bit. Please re-open this if you feel otherwise and work should continue.


Should add design document for node affinity

As we almost finished the review work on node selector and node affinity design for firmament/poseidon scheduler, should we add the markdown-type document to this project? e.g. create a docs/design folder and drop the document in.
BTW, contributors should send design document PR before starting feature developing.

/cc @deepak-vij @shivramsrivastava

Definitely, we need to convert the GoogleDoc to MD format.
Also, going forward we need to have the design document ready prior to doing implementation. Till now, we have been following code-first approach. Going forward, as we are much more comfortable with the codebase and overall design, we need to follow the design document first approach. As a matter of fact, this is what we are doing for Pod Affinity as well as Taints and Tolerations work as well.

Design document is already created now. Closing this issue.
https://github.com/kubernetes-sigs/poseidon/blob/master/docs/design/node_affinity_and_selector_for_poseidon.md


Release deprecated label fix

Related issue: https://github.com/harvester/harvester/issues/2899
Signed-off-by: Connor Kuehl<EMAIL_ADDRESS>

cc @yaocw2020 can u PTAL and cutting a new RC version for the network-controller since there are some code changes, thanks.


Proposal: Throws attribute

Hello. While your suggestion surely make sense, I don't see what additional opportunities migrating this to attributes will open to users. The only argument of the attribute is exception FQN (string) and there is no additional profit in specifying this FQN in attribute argument rather than phpdoc tag value.
I will decline this proposal for now, but these may be reconsidered in future. Thank you for the suggestion.

Hello. While your suggestion surely make sense, I don't see what additional opportunities migrating this to attributes will open to users. The only argument of the attribute is exception FQN (string) and there is no additional profit in specifying this FQN in attribute argument rather than phpdoc tag value.
I will decline this proposal for now, but these may be reconsidered in future. Thank you for the suggestion.


Add turn by turn directions

Follow up to the more general #25

One thing that usually annoys me with other maps providers is the inability to see street names along the route (especially when biking, I peek at the route and remember the couple streets I need to turn onto). Perhaps we can add this from information that we get from the route ?


No CSS or JS on front

Hello,
I'm trying to use your super field :-)
But i have a prob on the front, when i want to display content of the editojs_field
My index.html content the same as exemple, but no css or js loaded, is it normal ?
The tag{% load editorjs %}must do the work no ?
Thanks a lot for your work

this example should work
https://github.com/2ik/django-editorjs-fields/tree/dev/example
tag {% load editorjs %} is required


Fix datastax licenses

Build error is
[15:50:59]
Failed to publish artifacts: You do not have enough permissions to access build with id: 1313894
To login manually go to "/login.html" page
@ryadav88 any ideas ?

@takirala any idea why this tests fail with this error message?


Mac Support

Deej seems really cool/useful, but I use a mac as my main computer.  Are there any plans to get Mac Support on the roadmap?

Hi there @ipfaffy, thanks for writing!
I looked into this, but it seems that currently there isn't any Core Audio library to allow adjustment of individual app volumes on OSX (and thus, also no Go bindings for one).
The closest thing I found was a cool application called BackgroundMusic, which I haven't delved too much into but it seems to include a driver-like component that registers itself as a virtual audio output device, uses Core Audio to distinguish individual audio streams coming into it from other apps and makes them adjustable through a Cocoa-based tray UI.
Doing the same with Go, while certainly possible, is beyond my capabilities. Unfortunately I don't think Mac support will be added anytime soon :(
Other functionality in deej should be fully cross-platform, so if anyone feels like they can tackle the Core Audio stuff that would be very welcome!

I have submitted a PR for adding AppleScript support to BackgroundMusic with the intent of connecting to hardware sliders via a system like deej. Now it should be relatively trivial to interface deej to BackgroundMusic via os/exec to run AppleScript commands.
I need to design and build out my electronics / hardware so it might be a moment before I can write that layer. Perhaps someone else can get to it before me, but if not once I have my hardware set up I'll write something up and submit a PR here.

Hi @marcuswu, thanks for writing.
This looks like an interesting option, but I would not want to go with it as a core implementation for deej's main fork because it relies on an external piece of software (that I'm not able, or willing, to package with deej). A core implementation would have to use a more native approach, in the interest of debuggability and performance.
That being said, I imagine that if you implement this in your own fork of deej, it would be a completely feasible solution for most folks wanting to run it on a Mac (and I'll be happy to link to that from a resource such as our user FAQ).

You listed a few concerns here, what are your criteria?
I believe deej already relies on external software that's not packaged directly with deej. Is it because it's not a go project that can automatically be pulled and managed with go tools? If someone built some go code to add to deej to interact directly with BackgroundMusic's audio driver, would that suffice or are you unwilling to use BackgroundMusic's audio driver either? How much is performance a concern here?
I would like to understand more before I decide how I'll spend my time.

deej is currently distributed to most users as a standalone binary with no pre-requisites, other than having a connected hardware device to talk to. Every audio-related interaction is done directly against the operating system's audio APIs, and not some external software that the user is required to interact with (or ensure its existence). This is the most critical aspect IMO, and it applies regardless of whether the client code interacts with Background Music via AppleScript, direct communication with its internal audio driver or any other means.
As for performance, it shouldn't necessarily become an issue with your approach - it likely isn't - but it is crucial that calls are able to be executed rapidly (taking very little time to act) and in quick succession - as a potentiometer movement can generate as much as thirty calls (at 3% volume increments). If that isn't the case, interacting with the hardware isn't gonna feel snappy and responsive.
To be fair, I haven't measured out the real performance cost (if any) of doing something like this, but if you were to use something like os/exec every call directly translates to a fork operation - which could absolutely get laggy under some circumstances (especially when e.g. a slider is bound to multiple audio sessions and needs to adjust each one that many times). The only way to know for sure is to test it out in a scripted manner - if it seems fine there, I can't think of a reason it wouldn't work well with deej.
I'm not ruling out the possibility of it being a fully working solution, but it's not necessarily one I'd be comfortable signing off on. I hope that gives the additional context that my previous reply lacked, but if you have additional concerns I'm happy to address them :)

Thanks for pointing this out, @geekquixotic - however, this is still not a native solution and as such wouldn't be able to be completely contained within deej.


donati22

👷 Deploy Preview for gladia processing.

Name
Link

🔨 Latest commit
b121e14a82f845469b289c6f77ad00865132abdc

🔍 Latest deploy log
https://app.netlify.com/sites/gladia/deploys/641d512868efd40008b09673


How can I force the datatype before import ?

Hello,
It would be nice if it was possible to specify the datatype of the colums of a CSV being imported.
I have a CSV with a column having text based on numbers.

The column is seen like numbers,

values are truncated
Zero is missing

How can I force the datatype before import ?
Regards

With the version 3.0.0, it is possible to set "Column Data Types"
Exemple : {"COM":"string"}
Data imported had the good format

Issue closed


Using extname instead ext

Remove warning by using extname replace ext
Document#ext is now a key in the #data hash.
https://github.com/octopress/codefence/issues/17
Also upgrade ruby version and change test by inspecting newer Jekyll template rendering.

@imathis @parkr
Could you help to review this pr?
It remove the warning.


Create new trail from toolbar should probably hide other trails when switching to creation task

If you start typing in a trail name in the picklist that does not already exist (e.g. trying to create a new trail on the fly), the toolbar switches to trail creation function but retains the picklist showing your other trails.  None of the other trails are selectable in the list, but are visible.  Probably should look for a way to switch out the picklist with a text area box when transitioning from trail selection to trail creation modes.

Also need to clear trail input box if no trails exist for the domain.


eventTransformer not able to set symbol

When trying to set a new symbol for certain events using the event transformer an error occours.
config:
eventTransformer: (ev) => {
    if (ev.title.search('summer') > -1) ev.symbol = "umbrella-beach"
    return ev
},

I have tried different variations to set the new symbol:
ev.symbol = "umbrella-beach"
ev.symbol = "[umbrella-beach]"
ev.symbol = "['umbrella-beach']"
error in console:
Uncaught (in promise) TypeError: event.symbol.join is not a function
    at Class.draw (MMM-CalendarExt3.js:450:44)
    at Class.getDom (MMM-CalendarExt3.js:153:16)
    at main.js:113:35
    at new Promise (<anonymous>)
    at updateDom (main.js:111:10)
    at Object.updateDom (main.js:552:4)
    at Class.updateDom (module.js:358:6)
    at MMM-CalendarExt3.js:102:14

Try this;
ev.symbol = ['umbrella-beach']

Thanks. 😄
Please don't ask me why I tried setting an array using quotation marks.


Fix login unauthorized

Proposed change

This PR includes various changes to improve the flaky login/unauthorized situation:

Add -10s offset when storing token expiry to mitigate timing issues on /vehicles endpoint
Add retry strategy to north_america/rest_of_world login

Sometimes the /authenticate endpoint does not seem to work correctly, happend to me in the Android app as well

Type of change

[x] Bugfix (non-breaking change which fixes an issue)
[ ] New feature (which adds functionality to this library)
[ ] Breaking change (fix/feature causing existing functionality to break)
[ ] Code quality improvements to existing code or addition of tests

Additional information

This PR fixes or closes issue: fixes #393
This PR is related to issue: https://github.com/home-assistant/core/issues/63214

Checklist

[ ] The code change is tested and works locally.
[ ] Tests have been added to verify that the new code works.

@gerard33 please have a look, I do not get any log entries regarding authorization anymore 💪
Downside: If a user enters a wrong password, it will be tried up to three times (max. 2 seconds) before he'll get an error message...

@gerard33 thanks, just released 0.8.8 so please have a look ;)


swipe StackNavigator

Is it possible to swipe between screens with StackNavigator?

Yes.

@spencercarli I've read the documentation but I've found just the swipeenabled option but It is for TabNavigator. I need it for the StackNavigator. Can you tell me where I should read? Thanks :)
Sorry, I didn't follow the issue template since this isn't an issue, but just a question. I don't know if there is another way/space to write questions ^^'

@manuTro, please respect this project's maintainers and their time, and take a few seconds (!) to check what the issue template has to say on docs and questions. Thanks 😉

@spencercarli Hello, do you know how to swipe to any other screens (with gesturesEnabled：true) please? I have three screens A, B, C. I navigate A to B, B to C. I want goBack to A, of course it works by using goBack() function, but how make it by swiping? Thank you.

How is it possible to swipe between stacks like instagram stories? I can not find any reference?

Use gesturesEnabled to enable swiping back in a stack navigator. (See here).
Still looking for something to enable swiping forward, though..

@manuTro these issues are the first ones that pop up in google search so it is particularly important to follow the maintainers guidelines especially for common issues, which other people are also going to come across.
Since the latest version of react navigation there is truly no documentation on implementing custom transition and navigations. It would be nice if someone provided a relevant link to implementing custom navigators and transition in the vein of this.
https://medium.com/the-react-native-log/implement-snapchat-like-swipe-navigation-declaratively-in-react-native-309e71229c89


Swap English text to symbolic emojis

Contributes to the vision of #52

WDYT @toddmedema ?
The gutter may need its margins/buffers reworked to fit these, but I really like the immediate understanding of the emojis.

I like this direction! Two thoughts:

Are you able to increase the font size? The icons seem a bit small
The icons themselves are a bit indistinct (what is a sunset but a sunrise in reverse?) - I think a good way of clarifying this would be to add a ☀ in the middle, at noon. Think you're up for that challenge? Looks like noon is always symmetrically between rise and set, so rather than having to calculate the full astronomical noon time, you could take a shortcut and just do sunrise + (sunset - sunrise) / 2

@n-hebert oddly, I just pulled this down and it's rendering fine for me -

Maybe try pushing your latest changes and I can test again, and maybe we both test in a couple browsers to see if it's a browser-specific issue?

Ah! It's a firefox bug!
Chromium doesn't have it

Glad we found that out! Since only 3% of people use firefox and it's only a cosmetic issue, I think this is good enough for this project. Thank you for the contribution! What's next? 😁


Detect top-level qualified constant lookups (cbase)

The problem
Some cops look for usage of constants, and typically assume that the bare constant is used like Const. Another way of referencing constants is to qualify it to the top-level as ::Const. This can be useful to disambiguate in situations where namespaced classes and modules clash with ones at the top-level.
An example of code that has not been detected due to this omission, Lint/NonDeterministicRequireOrder checks for Dir['./support/**/*.rb'].each but not for ::Dir['./support/**/*.rb'].each.
The solution I would like
I would like for cops that detect patterns involving constants to detect both bare and qualified usage.
Alternatives I have considered
One option is to modify node patterns like (const nil? :Array) to one of the following:

(const {nil? cbase} :Array)
(const {cbase nil?} :Array)
(const {nil? (cbase)} :Array)

All of the above patterns seem to be used at least once in rubocop, and all would be equivalent. The top form seems to be the most used.
An additional thought is that perhaps an internal cop might want to check for patterns containing (const nil? to prevent future cops from missing the chance to detect qualified constants.
Clearly Lint/ConstantResolution needs to remain without matching cbase as that is what it would autocorrect to.
Additional context
Cops that pattern match for (const nil? ...):
$ grep -R "(const nil?" -l
lib/rubocop/cop/mixin/enforce_superclass.rb
lib/rubocop/cop/lint/rand_one.rb
lib/rubocop/cop/lint/redundant_splat_expansion.rb
lib/rubocop/cop/lint/non_deterministic_require_order.rb
lib/rubocop/cop/lint/constant_resolution.rb # should not change for this issue
lib/rubocop/cop/lint/debugger.rb # pattern could be condensed to (const {nil? (cbase) :Kernel)
lib/rubocop/cop/lint/useless_access_modifier.rb
lib/rubocop/cop/lint/nested_method_definition.rb
lib/rubocop/cop/lint/unused_method_argument.rb
lib/rubocop/cop/style/dir.rb
lib/rubocop/cop/style/documentation.rb
lib/rubocop/cop/style/stderr_puts.rb
lib/rubocop/cop/style/date_time.rb
lib/rubocop/cop/style/empty_literal.rb
lib/rubocop/cop/style/rescue_standard_error.rb
lib/rubocop/cop/style/proc.rb
lib/rubocop/cop/style/signal_exception.rb
lib/rubocop/cop/style/struct_inheritance.rb
lib/rubocop/cop/style/symbol_proc.rb
lib/rubocop/cop/style/zero_length_predicate.rb
lib/rubocop/cop/style/redundant_freeze.rb
lib/rubocop/cop/style/redundant_exception.rb
lib/rubocop/cop/style/random_with_offset.rb
lib/rubocop/cop/style/expand_path_arguments.rb
lib/rubocop/cop/style/colon_method_call.rb
lib/rubocop/cop/style/mutable_constant.rb
lib/rubocop/cop/internal_affairs/redundant_message_argument.rb # `::MSG` would never be used here so no need to change

Implementation Direction
I am happy to prepare a PR for this if people agree it would be useful.
Questions that would be useful to have answers to before diving in:

Would (const {nil? cbase} :Name) be the preferred pattern for cops that refer to top-level constants?
Would it be worth adding a spec for the mixin EnforceSuperclass? This seems to have been added for rails cops but they have moved out to rubocop-rails gem. It is entirely possible that it's used in other extension gems too...
Are there any other exclusions to those mentioned above for cops that should only check for bare Const?
Would an internal cop be useful to persuade new patterns involving constants to check for the qualified form ::Const too?

On reflection, I don't think an internal cop to force later patterns to check for top-level constants is justified.

Sorry I missed this issue. I agree with everything.


Document manager

Will merge this into the "refactoring" branch.

Added parent hydration with Proxies.

Added node name hydration

This is now being developed in https://github.com/dantleech/DocumentManager


KiCAD HAT Template

I'm working on fixing the 3D model issue.

Besides fixing the location of the 3D model, the schematic symbol of the HAT header should have the pins in the same position as the physical layout. That makes it easier to read when looking for a particular pin on the board.

@ntzovanis
I fixed the 3D model issue and converted the male pin headers to female ones. Then added a release with the Raspberry Pi header pin grouped.
Then I modified the schematics symbol to match the physical header layout and added this to another release.
So customers can choose whatever they prefer.
Please take a look on both designs and approve it everything is okay.


DocsArchive-<IP_ADDRESS>Auto archive content

Please don't merge this PR until target archive repo PR https://github.com/OPS-E2E-PPE/docs-archive-test-target_62fb4808-0aa8-4900-8487-b18d6a1e7daf/pull/1 is merged into live branch.
Auto archive content to https://github.com/VSC-Service-Account/docs-archive-test-target_62fb4808-0aa8-4900-8487-b18d6a1e7daf.git

Docs Build status updates of commit 7f2766d:
:x: Validation status: errors
Please follow instructions here which may help to resolve issue.

File
Status
Preview URL
Details

:x:Error

Details

[Error-BuildPermissionInsufficientError] Your repository https://github.com/VSC-Service-Account/docs-archive-test-source has enabled Docs Build service account. It seems that at least one of the accounts, e2ebd4, does not have Read permission to the repo. Please ask your repo admin to grant correct permission to service accounts (refer to this document: https://review.docs.microsoft.com/en-us/engineering/projects/ops/engdocs/how-to-grant-service-account-permission-in-your-repository?branch=master) and then retry the build.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel


Animation loop restart lag

Hello, I just bought pixel composer and have been having a lot of fun creating some looping and tiling particle animations :)
I have noticed that when an animation restarts, it has a slight delay. Which makes it look like it doesn't perfectly loop in time. The actually exported animation is fine, it's just in the preview it lags on the first frame.
https://github.com/Ttanasart-pt/Pixel-Composer/assets/6849168/853ee89a-90e1-4ac6-9e8a-55b7720f82f4
You can see in the video frame 1 is on screen longer than the rest. It's only a 4 frame animation running at 12 fps.
Is this something you observe, or is it just me?

I believe this has been fixed in 1.16
The release notes state:

Fix animation stutter by 1 frame when looped.

Thanks 🙏


Doesnt work on VMInstance

wanted to deploy on VMinstance but isnt working. On locahost its working fine
is the access blocked internationally?

Please elaborate

When I run the code on a VMInstance, I get a captcha answer None error code and the code asks me to restart. But when I run it on my local host. It's working fine.
Here is am image of the error on the server.

😂 😂


FTPES error: Can't connect

Hi,
I'm using PureFTPD configured with TLS.
It work with Yummy FTP Pro in FTPS (explicit) mode.
Tested with FileProvider, using ftpes://xxxx (same IP - login - pass), i got this error on server side:

Sorry, cleartext sessions and weak ciphers are not accepted on this server.#012Please reconnect using TLS security mechanisms.

iOS side:

CFNetwork SSLHandshake failed (-9807)
TCP Conn 0x600000492280 SSLHandshake failed (-9807)
SocketStream write error [0x600000492280]: 3 -9807
Error: Error Domain=NSOSStatusErrorDomain Code=-9807 "(null)" UserInfo={_kCFStreamErrorCodeKey=-9807, _kCFStreamErrorDomainKey=3}

Is it a problem with self-signed certificate or weak TLS or something like that ?
Thanks

Hi,
I'm using PureFTPD configured with TLS.
It work with Yummy FTP Pro in FTPS (explicit) mode.
Tested with FileProvider, using ftpes://xxxx (same IP - login - pass), i got this error on server side:

Sorry, cleartext sessions and weak ciphers are not accepted on this server.#012Please reconnect using TLS security mechanisms.

iOS side:

CFNetwork SSLHandshake failed (-9807)
TCP Conn 0x600000492280 SSLHandshake failed (-9807)
SocketStream write error [0x600000492280]: 3 -9807
Error: Error Domain=NSOSStatusErrorDomain Code=-9807 "(null)" UserInfo={_kCFStreamErrorCodeKey=-9807, _kCFStreamErrorDomainKey=3}

Is it a problem with self-signed certificate or weak TLS or something like that ?
Thanks

Hi, did you solve your problem?
How did you make the self-signed certificate?
Thanks


Feature/improving tables formatting

Before submitting this PR, please make sure:

[X] Your code builds clean without any errors or warnings
[X] You are using approved title ("feat/", "fix/", "docs/", "refactor/")

A description of the changes proposed in the pull request:
This task adds formatting to the printout tables in the client. It allows the user to set the format in the configs.
Previous:

New:

There was an issue discovered with the lexer parsing to add colour to text elements. Now fixed and test case updated.
Affected commands:

history
connect
config
orderbook
ticker

Tests performed by the developer:

Test for each one of the affected commands
Updated lexer test case

Tested and approved by QA team
Test Summary:

Confirmed tables-format working as expected using the commands history, connect, config, orderbook and ticker
Created a strategy and went through initial prompts successfully
Confirmed wallet and exchange balances are reflecting correct
Started the strategy without issues, confirmed orders are created and cancelled based on config
Ran a test bot for several hours without errors
Confirmed in logs that there is no errors when orders are filled.
Trade information are correct (price, size) based on history command output
Confirmed no issue installing and running it on different supported OS (linux (ubuntu), macos, windows and arm
Confirmed no issue building on source or docker build.
-Tried several Pretty-print tabular table format and its working as expected without any issue using config tables-format

Proposal created: https://snapshot.org/#/hbot-prp.eth/proposal/0xfd8c923edaa62d62b51c242ea612c43de46fcf37a5c76a571700785b014a3674

I agree with the changes. The new functionality will allow the client to present more readable and clear tables. But in my opinion the new tabulate dependency should be installed using conda instead of pip (we use pip only for dependencies that are not included in conda)

@aarmoa, I agree, and I've addressed that in the latest commit.


Add geotype to datatypes

Todos

[ ] design decisions

[ ] name of the field

current proposals: geoCoordinate, geoLocation, geoPoint

my personal favorite being geoCoordinate
cc @laura-ham @bobvanluijt

[ ] design of the where filter

@laura-ham suggestions?

[x] spike out happy path in janusgraph only

[x] index creation
[x] adding property
[x] searching by property within range

[x] add new data type on import, goal: an import with geoCoordinates field succeeds

[x] allow in schema creation
[x] allow in class instance creation
[x] validation?

[x] add basic validation
[x] refactor validateSchemaInBody (it's way too long and extremely difficult to read/extend)

[x] janus graph create vertex

[ ] include on simple read queries

[x] Local Get
[ ] Network Get

[ ] filter by property

[ ] Local Filters

[x] extract filter from graphql
[ ] set required validations, so that required fields cannot be omitted
[ ] apply filter in connectors (Janusgraph)

[ ] Network Filters

[ ] deal with property in GetMeta and Aggregate

proposal for now to simply not support those fields there
long-term?

[ ] Update docs
[ ] e2e/acceptance test

Original Content below: for most up-to-date summary see comments below
Abstract Examples

A location in a 2-dimensional space, i.e. x=3, y=5
Coordinates that point to a location on a world map

Research Questions

Are geo types always two-dimensional or can they also be more dimensional?

Part 1: Do we have use cases for more than 2d?
Part 2: Is there technical support for more than 2d?

Optimal way to query, e.g. within 500m coordinates x,y mixes concepts of metrical distance and coordinates, what API do we want

Features we'd need

Import/update geo coordinates
use geo in where filters (see research question)
do we want to allow aggregation functions like Aggregate or GetMeta

if so, what should they look like?
if so, is there technical support in our current stack?
if so, right from the start or later?

cc @bobvanluijt @laura-ham

Please don't forget to add it to the ontology docs :-)

@etiennedi
I think we should support at least 3D geo types. A simple example is the altitude of locations on earth (@bobvanluijt could be important for satellite measurements as well).
But I think we should not adopt the name geotype for this datatype, but rather something more abstract/general like coordinate.

Optimal way to query, e.g. within 500m coordinates x,y mixes concepts of metrical distance and coordinates, what API do we want
To support this, we have to assume that we only applying geocoordinates, and not any other coordinate in a 2/3/4/5/..-dimensional space. Also, there are many different geographical coordinate formats around (http://www.avenza.com/help/geographic-imager/5.0/coordinate_formats.htm), so conversion will be needed if we want to support comparisons with meters etc. (assuming the only support is geographical coordinates, not any dimensional space.) In addition, maybe aviation or maritime fields use other coordinate systems..

So I guess the first decision should be made on if we want to support only geographical coordinates (and then, 2d or 3d) or any dimensional space.
Then, we could start thinking about filters and querying etc.

Summary of what @laura-ham, @bobvanluijt and I discussed on Slack:

We accept that there are many use cases for coordinates (different coordinate systems, different dimensions), but specifically want to reduce this problem to “a place on earth”
At first we will only support latitude and longitude as the only two parameters (mostly motivated by the fact that a) we see a use case for this in the very short-term and b) our current backends (connectors) don’t support anything else)
However, in the future we might add Altitude as a third parameter, to effectively make this 2d system a 3d system (however, still limited to places on (or above/below) earth
Our main goal is to able to query within x kilometers of point<lat,long> -> We have not talked about how this filter would look like, but would do so next.
The new datatype would be entered as a map like nameOfNewType: {"latitude": 0.12345, "longitude": 0.9875} whereas the numbers represent the decimal format. We have not talked about what this prop should be called, but would do so next.

Janusgraph Research Results
add a field called location that is a Geoshape and add it to the existing (elasticsearch-based) index:
graph.tx().rollback()
mgmt = graph.openManagement()
  newProp = mgmt.makePropertyKey("location").dataType(Geoshape.class).cardinality(Cardinality.SINGLE).make()
  existingIndex = mgmt.getGraphIndex("search")
  mgmt.addIndexKey(existingIndex, newProp)
mgmt.commit()

Add a vertex with the coordinates of Amsterdam:
g.addV().property("location", Geoshape.point(52.366667, 4.9)) // Amsterdam

Try to find it based on the coordinates of Düsseldorf:
g.V().has("location", geoWithin(Geoshape.circle(51.233333, 6.783333, 100)))
// -> no results

g.V().has("location", geoWithin(Geoshape.circle(51.233333, 6.783333, 300)))
// found the vertex we created above

Something on a meta-level (not necessarily related to Geoloc) we should make a distinction between types and formats (as you can already see here). Especially from a connector PoV this is important, it might be the case that a non-JanusGraph connector is unable to deal with functionality like geoWithin(). There is still value though because it informs an end-user about what a type might contain.
Example (note the @dataType):
{
    "@context": "http://semi.network",
    "classes": [
        {
            "class": "Car",
            "description": "This is a car",
            "keywords": [
                {
                    "keyword": "Vehicle",
                    "weight": 1
                }
            ],
            "properties": [
                {
                    "@dataType": [
                        "geoLocation"
                    ],
                    "description": "location of the car",
                    "keywords": [],
                    "name": "location"
                }
            ]
        }
    ]
}

The more descriptive it is, the better the end-user will be able to use it (for example, @laura-ham's point about using coordinate would be too ambiguous. However, it is simple to add both).
Use case example;

User requests meta information from meta-endpoint.
The user learns that Car.location == geoLocation
The user can now use the coordinates to plot these -for example- on a map.

Completely different example;

dataType==float64 and dataFormat==temprature.
This is minimal but helpful for end-users

This means a few things;

Without the connector functionality, this is already valuable.
We now call it @dataType this should actually be: @dataFormat where a string is also seen as a format.
@etiennedi can add functionality when needed (while keeping it connector agnostic).

@laura-ham I just realized that I was sometimes using the name geoCoordinate (singular) and sometimes geoCoordinates. I just changed it to make sure it's unique throughout, but I'm not sure yet which option is better.
Is there such a thing as a single coordinate? Or would the combination of latitude and longitude both be a coordinate, i.e. we'd always have a pair of coordinates? If so, should the type be called geoCoordinates?

@bobvanluijt would mind creating a separate issue for https://github.com/creativesoftwarefdn/weaviate/issues/729#issuecomment-467774557. I think I agree with what you're saying, but I'd like to tackle this independently of this issue. Thansk

@laura-ham I'll most likely get to the point today where I have to build the where filter for a "range search". Do you have any spontaneous design idea? If not, I can also just build something that works, and then we can make it nicer whenever you have some time.

@laura-ham I just realized that I was sometimes using the name geoCoordinate (singular) and sometimes geoCoordinates. I just changed it to make sure it's unique throughout, but I'm not sure yet which option is better.
Is there such a thing as a single coordinate? Or would the combination of latitude and longitude both be a coordinate, i.e. we'd always have a pair of coordinates? If so, should the type be called geoCoordinates?

I think there is only a plural Coordinates in our case, we always have at least a latitude and longitude. (we were not the first ones wondering this https://www.quora.com/Are-coordinates-plural-or-singular) However, I see Janusgraph uses the singular form GeoCoordinate..

@laura-ham I'll most likely get to the point today where I have to build the where filter for a "range search". Do you have any spontaneous design idea? If not, I can also just build something that works, and then we can make it nicer whenever you have some time.

TLDR; see last piece of code and explanation below :)
I think we should keep as close to the original design as possible, athough we indeed have to make some additions to make it work for coordinates as well. Until now, value<...> is based on the dataTypes, and points to a single value to compare the data with. Here, we however need more input; we need the coordinates and the distance. I am wondering if it would be a problem for the user to make this a dict instead of a single input. For example:
{
  Local {
    Get {
      Things {
        City(where: {
          operator: WithinGeoRange,
          valueGeoRange: {geoCoordinates: {latitude: 0.5, longitude: 0.5}, distance: 2.0},
          path: ["geolocation"]
        }) {
          name
          geolocation {
            latitude
            longitude
          }
        }
      }
    }
  }
}

Do we need to introduce new operators like Within and Outside? Or could we use the existing operators LessThan, LessThanEqual, Equal (unlikely to be used, but still), GreaterThan and GreaterThanEqual? So:
{
  Local {
    Get {
      Things {
        City(where: {
          operator: LessThanEqual,
          valueGeoRange: {geoCoordinates: {latitude: 0.5, longitude: 0.5}, distance: 2.0},
          path: ["geolocation"]
        }) {
          name
          geolocation {
            latitude
            longitude
          }
        }
      }
    }
  }
}

I would go for Within and Outside now that I think of it... What do you think?
An alternative might be:
{
  Local {
    Get {
      Things {
        City(where: {
          operator: LessThanEqual,
          valueGeoDistance: {geoCoordinates: {latitude: 0.5, longitude: 0.5}, distance: 2.0},
          path: ["geolocation"]
        }) {
          name
          geolocation {
            latitude
            longitude
          }
        }
      }
    }
  }
}

Then what came to my mind is what if you want to find locations in a range with a from and to distance specification:
{
  Local {
    Get {
      Things {
        City(where: {
          operator: WithinGeoRange,
          valueGeoRange: {geoCoordinates: {latitude: 0.5, longitude: 0.5}, distance: {from:2.0, to:3.0}},
          path: ["geolocation"]
        }) {
          name
          geolocation {
            latitude
            longitude
          }
        }
      }
    }
  }
}

And if you only want to specify one limit:
{
  Local {
    Get {
      Things {
        City(where: {
          operator: WithinGeoRange,
          valueGeoRange: {geoCoordinates: {latitude: 0.5, longitude: 0.5}, distance: {to:2.0}},
          path: ["geolocation"]
        }) {
          name
          geolocation {
            latitude
            longitude
          }
        }
      }
    }
  }
}

Sorry for posting my whole thought process here. I think the last design would be the best. We need to introduce two new operators: WithinGeoRange and OutsideGeoRange (I think mentioning Geo in the name is good because this filter will only work on GeoCoordinates, not on other datatypes).
(I am wondering, if it would be possible to query the latitude and longitude separately, since these are parts of a single property datatype?)
We would have to specify in the docs that the distance should always be in kilometers (and also the correct format of coordinates of course).

Sorry for posting my whole thought process here. I think the last design would be the best. We need to introduce two new operators: WithinGeoRange and OutsideGeoRange (I think mentioning Geo in the name is good because this filter will only work on GeoCoordinates, not on other datatypes).

Agreed. I'll update it.
However, I'll only implement the case where only distance: { to } is set for now. And outscope the from part. This is because we're on a tight timeline to v1 and I need to cut corners whereever possible. We can then introduce the additional from field in a later minor version. (cc @bobvanluijt)
Possibly the same for OutsideGeoRange, then again, that's probably just adding a not() operator.

(I am wondering, if it would be possible to query the latitude and longitude separately, since these are parts of a single property datatype?)
Not with janus, there it's a single entity (Geoshape.Point that requires both)

We would have to specify in the docs that the distance should always be in kilometers (and also the correct format of coordinates of course).

Yes, I've always started that for the graphQL description fields, but I haven't touched the docs yet until we have finalized the design a bit. Since I could use every help possible, do you have some time to take that up by any chance?

However, I'll only implement the case where only distance: { to } is set for now. And outscope the from part. This is because we're on a tight timeline to v1 and I need to cut corners whereever possible. We can then introduce the additional from field in a later minor version. (cc @bobvanluijt)

Yes, makes sense.

Possibly the same for OutsideGeoRange, then again, that's probably just adding a not() operator.

True, let's remove OutsideGeoRange, because this is indeed the same as applying the not operator.

(I am wondering, if it would be possible to query the latitude and longitude separately, since these are parts of a single property datatype?)
Not with janus, there it's a single entity (Geoshape.Point that requires both)

So this cannot be requested as separate properties as we do in the query above?

Yes, I've always started that for the graphQL description fields, but I haven't touched the docs yet until we have finalized the design a bit. Since I could use every help possible, do you have some time to take that up by any chance?

I could do the docs, but not before tomorrow. Do you also mean https://github.com/creativesoftwarefdn/weaviate/blob/develop/docs/en/use/ontology-schema.md#property-datatypes in addition to GraphQL docs?

So this cannot be requested as separate properties as we do in the query above?

From a db perspective (in the janus case) we retrieve the pair as an atomic unit. However, in the graphql resolver we only show what the user requested. So if they only want to show the Latitude, but not the Longitude that's fine.
However, if they try to perform transaction on it (such as a within-range search) both fields have to be provided. This is also how I've currently implemented it on the first iteration of the where filter I've just build. All three fields (lat, lon, dist) are required.

I could do the docs, but not before tomorrow.

That would be absolutely fine. Also later would be fine. In fact this might be good, because then you could actually verify that the way I've implemented matches what you want to document.
Yes, so far I've only filled the description fields in the graphql API itself. This might also make sense to review, but it's only 3 sentences so far. I haven't touched any markdown files yet. :)
Thanks a lot

So this cannot be requested as separate properties as we do in the query above?

From a db perspective (in the janus case) we retrieve the pair as an atomic unit. However, in the graphql resolver we only show what the user requested. So if they only want to show the Latitude, but not the Longitude that's fine.

Okay thanks, I get that. But it is still not clear how the user then can request to get the value for longitude and latitude back as separate property values, while it is in the database formatted into one property.

Not sure I understand the last part.
In the db the type of the field that I call geolocation above is a Geoshape.Point. This Java class in turn has properties for the coordinates. I think it's an array of two floats whereas element 0 is lat and element 1 is long. This is at the same level where the prop name would be the java class String which doesn't have any properties, but is just the string itself.
In the graphql resolver I can then transform this array into the respective fields. This is currently working already:

Does this help? Or am I completely misunderstanding the problem?

Okay, so by default there is a latitude and longitude field in every property with the @datatype GeoCoordinates?

Okay I completely understand it now :) thanks for the clear explanation!

@laura-ham
Spontaneous thought: Would distance: { min max } be easier to understand than distance { from to }. I find from to a bit ambiguous in the setting of coordinates and maps, because it reminds me of taking a measurement from a specific point to another. Wondering what you think about this.

If we talk about distance then I agree that min and max would be better options. I initially copied the from and to from https://www.compose.com/articles/geofile-elasticsearch-geo-queries-2/, using them for geo_distance_range.

Cool, then I'll reflect that as well. :)

This is is the flow mentioned in https://github.com/creativesoftwarefdn/weaviate/issues/729#issuecomment-468314128 with the updated names:
{
    "name": "geolocation",
    "@dataType": [
	"geoCoordinates"
    ],
    "description": "The city's longitude and latitude",
    "keywords": [
      { "keyword": "location", "weight": 1.0 }
    ]
}

and on import we have to specify something like this:
"schema": {
    "name": "Amsterdam",
    "population": "1800000",
    "isCapital": true,
    "geolocation": {
	"latitude": 52.366667,
	"longitude": 4.9
    }
}

@laura-ham because I'm working on the docs I've already tackled this.


Updated CHANGES.md for the InterfaceAdapter implementation.

Thanks! I added some comments, minor things, but I didn't want to have to do the two-pull-request dance.

I updated the branch with some clarifications for upgrading projects based on your feedback, and fixed some formatting issues.

OK, I think that was the last thing.

awesome, thanks. Sorry for being picky and pushing that on you - wish there was a way I could push code to pull requests more easily :)


Kernel updates for 2024-06-21

Description of changes
https://cdn.kernel.org/pub/linux/kernel/v6.x/ChangeLog-6.9.6
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Tested on my usual pile of hardware, and it seems to have some security relevant fixes, so let's just merge.


Enable scrolling while dragging predefined feedback in modeling and text exercise assessments

Is your feature request related to a problem?
When assessing text and modeling exercises, the predefined drag and drop feedback boxes are a great way to speed up the process for similar submissions. However, these drag and drop boxes do not always fit on the screen together with the submission. This is especially the case for text-based exercises with short answers. In this case, not every predefined feedback box is reachable anymore and therefore cannot be used.
Describe the solution you'd like
Enable scrolling while you are dragging a predefined feedback box.
Describe alternatives you've considered
Using the built-in zoom feature of the browser. Zooming out makes everything visible and draggable, but this only works to a certain extent. Users on small laptops won't be able to read the submission anymore if they have to zoom out in order to reach the predefined feedback and drag it onto the submission.
Additional context
TODO: please re-upload images that do not show real solutions or real grading instructions

@niclasschuemann I had to remove your screenshots. Please do not upload them in case they include real solutions or real grading instructions of courses on Artemis. Please use fake or example data

@niclasschuemann Could you please elaborate more? As seen in the screencast below it is indeed possible using a small screen to scroll while dragging the grading instruction. Maybe you need to adapt your browser settings?


CPP: Handle 'realloc' better in MemoryMayNotBeFreed.ql

The MemoryMayNotBeFreed.ql query normally considers a realloc to be both an alloc, and a free of the old pointer.  A subtlety is that if realloc fails and returns NULL it does not free the old pointer.  To account for this the query considers the free of the old pointer to occur only if and when the return value is checked:
ptr_b = realloc(ptr_a, new_size);
if (ptr_b == 0)
{
  // handle failure (perhaps with an explicit free(ptr_a))
} else {
  // the realloc is considered to free ptr_a here
}

This works well up until we assign to the same variable:
ptr_a = realloc(ptr_a, new_size);
if (ptr_a == 0)
{
  // handle failure (which might be a bit awkward since we've just overwritten ptr_a)
} else {
  // the realloc is considered to free ptr_a here
}

Because now we get confused by the old vs new ptr_a and think the new allocation is being freed.
The ideal solution is probably to upgrade this query to use something like DataFlow rather than LocalScopeVariableReachability (I've created a JIRA ticket for this).
However, we need a quick fix because it's causing a regression on version 1.3 of the samate test-suite compared to the results we had on version 1.2.  The workaround is not to consider this particular pattern on realloc as to be a free at all.

@geoffw0 this is for 1.18, right? I've put the 1.18 milestone on it, and I've retargeted the PR to the rc/1.18 branch.

I think my retargeting of the PR and my triggering of Language-Tests/CPP got a bit racy and that Jenkins is now testing rc/1.18 of our internal repo with a submodule that's based on this PR merged into this repo's master. But that should be close enough that I'll accept the results.

@geoffw0 this is for 1.18, right?

I had been hoping so, yes.

The test failed because (I think) this repo's master is broken (contains d4f9b5eb5296b4f0c6693d576db8e55964f30f27). I'll try to confirm on some other PRs that this repo's rc/1.18 is okay.

The only test failures now are the ones that will be fixed by the internal PR, so I'm merging both now.


Add support for short url & query params

Should solve #6

@bdadam tests are up to date too
hope you could merge and release this very soon, I'll really appreciate :)

Merged. Thanks.


Improve FSI debugging experience for OSS build & Do not add all vs dependencies to the EnableOpenSource VSIX

Allow the OSS build to enable F5 debugging of Open Source updates to FSI.
This is accomplished by deploying fsi.exe and fsianycpu.exe to the vsix component, where it will be activated when debugging the open source build of fsharp.
Instructions:

build fsharpproto
open vsintegration\src\deployment.sln in VS 2013 / 2015
Set enableopendource as the start up project
Press F5 ... and wait a while
Visual Studio will start up, all of the VSAddins, including fsi will be from the open source build.

Please Note:
This does not wire up the OSS F# compiler to visual studio.  It does not deploy updated templates.  They will follow as we get time.
Kevin
2nd commit just fixes the bug where the vsix contains all of the dependencies which can be found in VS.

a459dd6 is a merge commit , can you rebase this pr to review it easier?
4a12503 the FSharp.Core.fsproj as lot of whitespace changes

Looks ok besides bulk whitespace changes.
Would request that you undo whitespace updates to FSharp.Core.fsproj and source.extension.vsixmanifest, since they

Make it hard to see what has actually changed
Introduce tabs, which are not previously used in projects/targets in this repo (besides a few small pockets, which should probably be cleaned up)


Laravel 5.5 autodiscovery.

Updated the package to be autodiscovered.

Thanks, this should close #74


[docs] Add the FAQ section

\cc @DevExpress/testcafe-docs @Nuarat
Preview at http://strelyaev-w8:8080/testcafe/faq/

Didn't we decide to swap Troubleshooting and General Questions?

I don't remember. Did we?

@testcafe-build-bot \retest

@testcafe-build-bot \retest

FPR


Improve release process

Add additional targets to Makefile
- add clustertasks
- update image ref in operator deployment
Update release docs
Signed-off-by: Nikhil Thomas<EMAIL_ADDRESS>

/hold

/hold cancel

/retest

/retest

/retest


did we loose the different colors associated with the 3 types of recalls?  red, orange, yellow?

the 3 colors were primarily meant to appear on the "dashboard" that is part of the info window - which has been deprecated. Since this info window doesn't appear anymore we don't really need that continuation on the tabs.


Set-VM A parameter cannot be found that matches parameter name 'EnhancedSessionTransportType'.

After following the VM shell instructions and having shut down the VM - Enabling the enhanced session fails.
Issuing the command (Set-VM -VMName <your_vm_name>  -EnhancedSessionTransportType HvSocket) from within a PowerShell administration console I get the following error:
Set-VM : A parameter cannot be found that matches parameter name 'EnhancedSessionTransportType'. At line:1 char:29  Set-VM -VMName UbuntuGnome  -EnhancedSessionTransportType HvSocket  CategoryInfo          : InvalidArgument: (:) [Set-VM], ParameterBindingException  FullyQualifiedErrorId : NamedParameterNotFound,Microsoft.HyperV.PowerShell.Commands.SetVM

I've updated my Windows 10 Pro install 1709 build 16299.248, and issued a restart but the same issue persists. Does my Hyper-V local setup be prepared/configured prior to attempting this outside of the Windows Update mechanism?

Never mind the above, as per your post, it looks like one would need to be running insider builds which is not an option for me - I'd rather not risk compromising my main Windows 10 development workstation nor do I wish to look into nested Hyper-V virtualisation.


Update slurm setup for new arguments

We've switched scheduler_file to scheduler_file_path in the configuration, so the wait script will need to be updated accordingly.

config.yaml should be benchmark_config.yaml


Color inconsistency for namespaced keywords

Pretty strange, but slash in namespaced keywords picks the same color as what is defined for numbers.
Not sure, though, whether this needs to be addressed in this plugin source, or it has something to do with @cursive-ide.

It's a clojure-extras problem! I'll try to submit a fix on the next version, tks for reporting :)

Fixed it on master (v0.5.1), Jetbrains should approve it shortly in the marketplace 🎉


MINOR: Move Alan Gates to Emiritus member

What changes were proposed in this pull request?
This PR aims to move Alan Gates to Emiritus member.
Also, Ubuntu version update is also applied.
Why are the changes needed?
Requested by Alan Gates.
How was this patch tested?
Manually review.

Thank you, I will merge this now!


Fix RN 0.47 breaking change

RN 0.47 removed createJSModules() and without this fix, the module as a whole will break the build

Hi, thanks!
What's the impact of this change for previous versions? Will it still work?

@Apercu Because I only removed the Override, the method will still work for older versions of RN, but will now also stop breaking for newer versions of RN. Behavior stays the same for the module in both instances.

Cool, thanks!


Make README.md clearer regarding default variant

I believe the current README doesn't make it really obvious that :solid is the default variant so I tried to make it clearer regarding this.

Thank you!


MSSQL JSON support

Just letting you know - MSSQL is gonna implement JSON support.
http://blogs.msdn.com/b/jocapc/archive/2015/05/16/json-support-in-sql-server-2016.aspx
We might want to copy the syntax - or be aware of this when we implement MSSQL flavourd AlaSQL

Agree. Plus there are similar implementations in Postgres and Oracle. To be discovered.

Postgres JSON functions and datatype:

http://www.postgresql.org/docs/9.3/static/functions-json.html
http://www.postgresql.org/docs/9.4/static/datatype-json.html

check out this - it's important for our MySQL compliant flavour
http://mysqlserverteam.com/json-labs-release-native-json-data-type-and-binary-format/
Some more details on the mysql JSON date
http://mysqlserverteam.com/json-labs-release-json-functions-part-1-manipulation-json-data/

Agershun:
As far as I understand it is not so hard to realize MySQL and Prostres JSON functions and casting procedures. It wlll take day pr two. BTW IMHO original AlaSQL's JSON is better than MySQL/Postgres/SQL Server realizations. Ok, I will create issue and some code :)

I put it on the long list so we can reopen when its time has come...


Fix compiler warning/error when HFP_DYNAMIC_MEMORY is not TRUE. (IDFGH-1378)

The error_exit label is not used in a goto statement unless dynamic memory allocation is enabled. Depending on the setting of compiler flags, this may generate an error during compilation.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Has been fixed before espressif's bluetooth refactoring where bluedroid was bounced to host/bluedroid.


Universal listings - POC of updating filters dialog in response to removing active filters

A proposed approach for updating the filter dialog state in response to removing an active filter (cc @thibaudcolas @laymonage):

Move the filter dialog content to its own include
Update the index_results endpoint to accept a filter_fragment=1 URL variable - if this is present, insert a <template id="filters-dialog-fragment"> element containing the re-rendered filter HTML
Pass filter_fragment=1 as part of the 'remove filter' URLs
Update SwapController to check for the presence of the <template>, and update the dialog body with it if found

Obviously for the final version we'll want to do something smarter and more Stimulus-y than hard-coding the element replacement code, and apply this on top of #11477 when that's ready. Also, as this stands the date pickers stop working after the replacement - because they still rely on inline scripts within the fragment, and setting innerHTML does not execute these. (Do we have a non-jQuery solution for this yet...?)

Sorry.
Why not see if the TeleportController can do what you need to move the Async response partial to a different part of the DOM.
https://github.com/wagtail/wagtail/blob/main/client/src/controllers/TeleportController.ts

@lb- my rebase in #11516 uses TeleportController.

@lb- my rebase in #11516 uses TeleportController.

Legend. Much nicer.


Spark HBT Improvement: Adding executor instances

This request is to improve Spark HBT and add more parameters. With this we would be suggesting three more parameters: spark.dynamicAllocation.minExecutors, spark.dynamicAllocation.maxExecutors, spark.executor.instances. Currently we are changing these parameters only we are making any changes in executor cores. If we are increasing number of cores, that means we would be needing less executors and vice versa.
Testing Done:
We have tested following use cases:

Suggestion should include previous values if there are no changes. This is to make sure that, if there are no changes in these parameters, we are still carrying forward the last suggested value.
If executor cores are decreasing, number of executors are decreasing in same proportion.
If executor cores are increasing, number of executors are increasing in same proportion.
If there is no value found in previous execution for one of the parameter, do not suggest anything for that parameter.

Changed debug logging to info level logging.

Closing after merge


Typos in README.md

(we should archive this repo at some point, lz4 is a superior compression algorithm both in speed and compression ratio, at the moment it's only used for warp-sync snapshot in parity-ethereum AFAIK)


Cannot start docker container

Hi everyone,
I am running into issues starting the docker container. It failed due to issues with the bind mounts and I couldn't find a solution. Logs say
Microsoft.Extensions.Hosting.Internal.Host Unhandled exception. System.UnauthorizedAccessException: Access to the path ...  is denied.
My compose looks the following:
version: '3.9'
services:
  ghostfoliosidekick:
    image: vibenl/ghostfoliosidekick
    container_name: ghostfolio-sidekick
    networks:
      - ghostnet
    volumes:
      - /volume1/docker/ghostfoliosidekick/config:/gfsk/config
      - /volume1/docker/ghostfoliosidekick/import:/gfsk/import
    environment:
      GHOSTFOLIO_URL: ghostfolio-app:3333
      GHOSTFOLIO_ACCESTOKEN: abc
      FILEIMPORTER_PATH: /gfsk/import
      CONFIGURATIONFILE_PATH: /gfsk/config

networks:
  ghostnet:
    name: dockernet
    external: true

I was trying different destinations but always the same result. I was as well trying to start the container with user flags, but didn't work as well. Maybe you have an idea? thanks!

Your configuration seems fine, the only things I can think of are:

Perhaps adding HTTPS:// before the url
Double check the access token
You can connect to the official ghostfolio instance and see if that works.

I have an integration test that tests to a live system, perhaps have a look at that for inspiration?
https://github.com/VibeNL/GhostfolioSidekick/blob/master/IntegrationTests/Run.cs

Next week I'll see if I can add some more helpful logging

Thanks for the quick reply! So far, I am pretty sure this is a matter of file/folder permissions of the mounted folders.
Again, the logs:
"
2024/02/02 09:05:25,stderr,   at GhostfolioSidekick.Configuration.ApplicationSettings..ctor() in /src/Configuration/ApplicationSettings.cs:line 12

2024/02/02 09:05:25,stderr,"   at System.IO.File.ReadAllText(String path, Encoding encoding)
"
2024/02/02 09:05:25,stderr,"   at System.IO.StreamReader.ValidateArgsAndOpenPath(String path, Encoding encoding, Int32 bufferSize)
"
2024/02/02 09:05:25,stderr,"   at System.IO.Strategies.OSFileStreamStrategy..ctor(String path, FileMode mode, FileAccess access, FileShare share, FileOptions options, Int64 preallocationSize, Nullable`1 unixCreateMode)
"
2024/02/02 09:05:25,stderr,"   at Microsoft.Win32.SafeHandles.SafeFileHandle.Open(String fullPath, FileMode mode, FileAccess access, FileShare share, FileOptions options, Int64 preallocationSize, UnixFileMode openPermissions, Int64& fileLength, UnixFileMode& filePermissions, Boolean failForSymlink, Boolean& wasSymlink, Func`4 createOpenException)
"
2024/02/02 09:05:25,stderr,"   at Microsoft.Win32.SafeHandles.SafeFileHandle.Init(String path, FileMode mode, FileAccess access, FileShare share, FileOptions options, Int64 preallocationSize, Int64& fileLength, UnixFileMode& filePermissions)
"
2024/02/02 09:05:25,stderr,   --- End of inner exception stack trace ---

2024/02/02 09:05:25,stderr, ---> System.IO.IOException: Permission denied

2024/02/02 09:05:25,stderr,Unhandled exception. System.UnauthorizedAccessException: Access to the path '/app/gfsk/config' is denied.

the binds are mounted into the docker container with the respective owner flags of the host system. From what I see in the dockerhub, dotnet is running inside the container with a very specific uid:
ENV APP_UID=1654 ASPNETCORE_HTTP_PORTS=8080 DOTNET_RUNNING_IN_CONTAINER=true
Just a guess, since I am not an expert on this field, but I assume this could be the issue. I wonder no one else had this issue?!

I'm not a docker expert, but here is my config
ghostfoliosidekick:
image: vibenl/ghostfoliosidekick:latest
container_name: Ghostfolio-Ghostfoliosidekick
hostname: ghostfoliosidekick
security_opt:
- no-new-privileges:true
environment:
- GHOSTFOLIO_URL=url
- GHOSTFOLIO_ACCESTOKEN=abc
- FILEIMPORTER_PATH=/var/lib/data
- CONFIGURATIONFILE_PATH=/var/lib/data/config.json
restart: always
volumes:
- /volume1/docker/ghostfolio/sidekick:/var/lib/data:r
depends_on:
ghostfolio:
condition: service_started

Thank you! :-) I found the issue. My problem was the configuration file path pointing at a folder instead of a file:
So it was
CONFIGURATIONFILE_PATH: /gfsk/config
instead of
CONFIGURATIONFILE_PATH: /gfsk/config/config.json

Your welcome 😁


Zookeeper events aren't entirely reliable

I've seen behavior when running this in a production environment. It appears that the tree watcher wasn't getting pinged with updating events so the delay counts are climbing and climbing.
A restart of daemon resets the counter to the expected delay

Interestingly, since rolling out #20 and a different reporting methodology, I'm no longer seeing this drift upwards in metric reporting. I believe I had misdiagnosed this previously.
Going to close out this ticket until I see na indication otherwise that we're not getting events published.


License in feature.xml

Make sure we know what the license is, then add it to the license element in feature.xml

This is the text to include:
Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0

Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.


doc/languages-frameworks/python: Reword section to make commit rules a bit clearer

Description of changes
See the minor confusion at https://github.com/NixOS/nixpkgs/pull/339136#issuecomment-2329997524

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/prs-ready-for-review/3032/4801


1.x

SimpleCookie get cookie failed,when I set cookie to root,but in sub path exists the sample cookieId,
shiro get invaid cookie。eg:
www.domain.com/    cookie one
www.domain.com/abc    cookie two
private static javax.servlet.http.Cookie getCookie(HttpServletRequest request, String cookieName) {
        javax.servlet.http.Cookie cookies[] = request.getCookies();
      javax.servlet.http.Cookie cookie = null;
        if (cookies != null) {
            for (javax.servlet.http.Cookie cookie : cookies) {
                if (cookie.getName().equals(cookieName)) {
                    cookie = cookie;
                }
            }
        }
        return cookie;
    }

@rainbowJson was this PR targeted to the correct branch?

i found in 1.3.x-1.4.0 @bdemers

@rainbowJson I'm not sure i'm following.  There are many conflicts in this PR

@rainbowJson Can you rebase with master to resolved the conflicts?

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/Shiro-pr-jdk11/12/

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/Shiro-pr/183/

Hello @rainbowJson.
I will close this PR for now. There are too many conflicts, and the description is not clear enough what the intended  change is.
Feel free to open an issue or another pull request if the underlying problem you wanted to solve still exists.


Magnifying glass in corner

Hey, nice work on the app so far.
One thing I noticed when scanning my first document was, that when adjusting the frame around the document, the magnified Section is not visible, due to the finger beeing above it.
Expected behavior: have a corner with the magnified section so that one can adjust the frame better :)

@justTOBBI Thanks!
You are not the first one to have that issue. It is not the first thing you see but you dont need to press "on" the corner to select it. I will select the closest one. Consequently you can touch a bit on the side so that you always see the magnifying glass.
I might add a text explanation on that view.


Persistent error "There was an issue connecting to your repo provider, click "Re-authenticate app" in Genethis verral Settings, and then try your build again."

Describe the bug
I am following the AWS tutorial, finishing "Module 3: Add Authentication". The authentication example app runs fine locally but does not build.
I had a problem before this which I fixed by following the suggestion in https://github.com/aws-amplify/amplify-cli/issues/6117 and clamping the AWS CLI version used for build to be the same as my local version (4.45.2), which solved this error.
But then I got the error about re-authenticating my app. I followed the instructions, deleting the existing web hooks and the re-authenticating, but the error message persists.
The console output seems to suggest that the build process accessed my github account okay and was able to clone my test app. It also appears that it was able to update the amplify CLI version from 4.29.4, to the version I am using locally, 4.45.2.
But, the log stops there and I can't see any explicit errors:
2021-03-20T16:23:54.404Z [INFO]: Git SSH Key acquired
021-03-20T16:23:54.404Z [INFO]: Git SSH Key acquired
2021-03-20T16:23:54.483Z [INFO]: # Cloning repository: git@github.com:jameshume/amplifyapp.git
2021-03-20T16:23:54.491Z [INFO]: Agent pid 137
2021-03-20T16:23:54.519Z [INFO]: Identity added: /root/.ssh/git_rsa (/root/.ssh/git_rsa)
2021-03-20T16:23:54.796Z [INFO]: Cloning into 'amplifyapp'...
2021-03-20T16:23:55.347Z [INFO]: Warning: Permanently added the RSA host key for IP address '<IP_ADDRESS>' to the list of known hosts.
2021-03-20T16:23:57.189Z [INFO]: # Switching to commit: 56fb35293b153e241baf7e23e00f41f401b6b205
2021-03-20T16:23:57.196Z [INFO]: Agent pid 150
2021-03-20T16:23:57.200Z [INFO]: Identity added: /root/.ssh/git_rsa (/root/.ssh/git_rsa)
2021-03-20T16:23:57.204Z [INFO]: Note: switching to '56fb35293b153e241baf7e23e00f41f401b6b205'.
                                 You are in 'detached HEAD' state. You can look around, make experimental
                                 changes and commit them, and you can discard any commits you make in this
                                 state without impacting any branches by switching back to a branch.
                                 If you want to create a new branch to retain commits you create, you may
                                 do so (now or later) by using -c with the switch command. Example:
                                 git switch -c <new-branch-name>
                                 Or undo this operation with:
                                 git switch -
                                 Turn off this advice by setting config variable advice.detachedHead to false
2021-03-20T16:23:57.205Z [INFO]: HEAD is now at 56fb352 added auth
2021-03-20T16:23:57.210Z [INFO]: Successfully cleaned up Git credentials
2021-03-20T16:23:57.211Z [INFO]: # Checking for Git submodules at: /codebuild/output/src684925248/src/amplifyapp/.gitmodules
2021-03-20T16:23:57.231Z [INFO]: # Retrieving cache...
2021-03-20T16:23:59.127Z [INFO]: # Extracting cache...
ed
2021-03-20T16:24:02.904Z [INFO]: # Retrieving environment cache...
2021-03-20T16:24:02.935Z [INFO]: # Retrieved environment cache
2021-03-20T16:24:02.936Z [INFO]: # Ensuring NPM package '@aws-amplify/cli' is version: '4.45.2'
2021-03-20T16:24:13.611Z [INFO]: # Patching NPM package '@aws-amplify/cli' from 4.29.4 to 4.45.2...
021-03-20T16:23:54.404Z [INFO]: Git SSH Key acquired
2021-03-20T16:23:54.483Z [INFO]: # Cloning repository: git@github.com:jameshume/amplifyapp.git
2021-03-20T16:23:54.491Z [INFO]: Agent pid 137
2021-03-20T16:23:54.519Z [INFO]: Identity added: /root/.ssh/git_rsa (/root/.ssh/git_rsa)
2021-03-20T16:23:54.796Z [INFO]: Cloning into 'amplifyapp'...
2021-03-20T16:23:55.347Z [INFO]: Warning: Permanently added the RSA host key for IP address '<IP_ADDRESS>' to the list of known hosts.
2021-03-20T16:23:57.189Z [INFO]: # Switching to commit: 56fb35293b153e241baf7e23e00f41f401b6b205
2021-03-20T16:23:57.196Z [INFO]: Agent pid 150
2021-03-20T16:23:57.200Z [INFO]: Identity added: /root/.ssh/git_rsa (/root/.ssh/git_rsa)
2021-03-20T16:23:57.204Z [INFO]: Note: switching to '56fb35293b153e241baf7e23e00f41f401b6b205'.
                                 You are in 'detached HEAD' state. You can look around, make experimental
                                 changes and commit them, and you can discard any commits you make in this
                                 state without impacting any branches by switching back to a branch.
                                 If you want to create a new branch to retain commits you create, you may
                                 do so (now or later) by using -c with the switch command. Example:
                                 git switch -c <new-branch-name>
                                 Or undo this operation with:
                                 git switch -
                                 Turn off this advice by setting config variable advice.detachedHead to false
2021-03-20T16:23:57.205Z [INFO]: HEAD is now at 56fb352 added auth
2021-03-20T16:23:57.210Z [INFO]: Successfully cleaned up Git credentials
2021-03-20T16:23:57.211Z [INFO]: # Checking for Git submodules at: /codebuild/output/src684925248/src/amplifyapp/.gitmodules
2021-03-20T16:23:57.231Z [INFO]: # Retrieving cache...
2021-03-20T16:23:59.127Z [INFO]: # Extracting cache...
2021-03-20T16:24:02.800Z [INFO]: # Extraction completed
2021-03-20T16:24:02.904Z [INFO]: # Retrieving environment cache...
2021-03-20T16:24:02.935Z [INFO]: # Retrieved environment cache
2021-03-20T16:24:02.936Z [INFO]: # Ensuring NPM package '@aws-amplify/cli' is version: '4.45.2'
2021-03-20T16:24:13.611Z [INFO]: # Patching NPM package '@aws-amplify/cli' from 4.29.4 to 4.45.2...
2021-03-20T16:25:00.879Z [INFO]: # Done patching NPM package '@aws-amplify/cli'

Not sure how to debug this further... are there any other logs I can access?
Thanks,
James
To Reproduce
Steps to reproduce the behavior:

Click "Redeploy this version" in my amplify console

Expected behavior
Expected it to build correctly
Screenshots
I think the description should be enough but will add screenshots if anyone thinks they will prove useful.
Desktop (please complete the following information):

OS: Windows 10 Pro 10.0.19041 (Build 19041)
Browser Chrome
Version 89.0.4389.90 (Official Build) (64-bit)

I am also experiencing this issue, it's new. Also getting 502 errors.

Can either or both of you share your appId (part of the app ARN) and/or region where you're experiencing this issue?

ca-central-1
arn:aws:amplify:ca-central-1:108497320985:apps/d2wp73l7cepdb3

@monckey100 I'm seeing this in the build error logs:
2021-03-22T21:02:55.021Z [WARNING]: [error] Could not resolve routes
--
105 | 2021-03-22T21:02:55.023Z [WARNING]: [fatal] Request failed with status code 502
106 | at createError (node_modules/axios/lib/core/createError.js:16:15)
107 | at settle (node_modules/axios/lib/core/settle.js:17:12)
108 | at IncomingMessage.handleStreamEnd (node_modules/axios/lib/adapters/http.js:260:11)
109 | at IncomingMessage.emit (node:events:381:22)
110 | at IncomingMessage.emit (node:domain:470:12)
111 | at endReadableNT (node:internal/streams/readable:1307:12)
112 | at processTicksAndRejections (node:internal/process/task_queues:81:21)
113 | 2021-03-22T21:02:55.040Z [WARNING]: ╭────────────────────────────────────────────────╮
114 | │                                                │
115 | │   ✖ Nuxt Fatal Error                           │
116 | │                                                │
117 | │   Error: Request failed with status code 502   │
118 | │                                                │
119 | ╰────────────────────────────────────────────────╯
120 | 2021-03-22T21:02:55.060Z [WARNING]: npm
121 | 2021-03-22T21:02:55.060Z [WARNING]: ERR! code 1
122 | npm ERR! path /codebuild/output/src368922229/src/sparxtrading_2.0
123 | 2021-03-22T21:02:55.062Z [WARNING]: npm
124 | 2021-03-22T21:02:55.062Z [WARNING]: ERR! command failed
125 | npm ERR! command sh -c nuxt generate
126 | 2021-03-22T21:02:55.068Z [WARNING]:
127 | 2021-03-22T21:02:55.068Z [WARNING]: npm ERR! A complete log of this run can be found in:
128 | npm ERR!     /root/.npm/_logs/2021-03-22T21_02_55_062Z-debug.log
129 | 2021-03-22T21:02:55.068Z [HELP]: Outputting the npm debug log
130 | 0 verbose cli [ '/usr/local/bin/node', '/usr/local/bin/npm', 'run', 'export' ]
131 | 1 info using<EMAIL_ADDRESS>132 | 2 info using<EMAIL_ADDRESS>133 | 3 timing config:load:defaults Completed in 1ms
134 | 4 timing config:load:file:/usr/local/lib/node_modules/npm/npmrc Completed in 0ms
135 | 5 timing config:load:builtin Completed in 0ms
136 | 6 timing config:load:cli Completed in 1ms
137 | 7 timing config:load:env Completed in 1ms
138 | 8 timing config:load:file:/codebuild/output/src368922229/src/sparxtrading_2.0/.npmrc Completed in 0ms
139 | 9 timing config:load:project Completed in 0ms
140 | 10 timing config:load:file:/root/.npmrc Completed in 0ms
141 | 11 timing config:load:user Completed in 0ms
142 | 12 timing config:load:file:/usr/local/etc/npmrc Completed in 0ms
143 | 13 timing config:load:global Completed in 0ms
144 | 14 timing config:load:cafile Completed in 0ms
145 | 15 timing config:load:validate Completed in 0ms
146 | 16 timing config:load:setUserAgent Completed in 0ms
147 | 17 timing config:load:setEnvs Completed in 0ms
148 | 18 timing config:load Completed in 4ms
149 | 19 verbose npm-session 248635961fae611d
150 | 20 timing npm:load Completed in 10ms
151 | 21 timing command:run Completed in 232057ms
152 | 22 verbose stack Error: command failed
153 | 22 verbose stack     at ChildProcess.<anonymous> (/usr/local/lib/node_modules/npm/node_modules/@npmcli/promise-spawn/index.js:64:27)
154 | 22 verbose stack     at ChildProcess.emit (node:events:369:20)
155 | 22 verbose stack     at maybeClose (node:internal/child_process:1067:16)
156 | 22 verbose stack     at Process.ChildProcess._handle.onexit (node:internal/child_process:301:5)
157 | 23 verbose pkgid<EMAIL_ADDRESS>158 | 24 verbose cwd /codebuild/output/src368922229/src/sparxtrading_2.0
159 | 25 verbose Linux 4.14.219-119.340.amzn1.x86_64
160 | 26 verbose argv "/usr/local/bin/node" "/usr/local/bin/npm" "run" "export"
161 | 27 verbose node v15.12.0
162 | 28 verbose npm  v7.6.3
163 | 29 error code 1
164 | 30 error path /codebuild/output/src368922229/src/sparxtrading_2.0
165 | 31 error command failed
166 | 32 error command sh -c nuxt generate
167 | 33 verbose exit 1
168 | 2021-03-22T21:02:55.071Z [ERROR]: !!! Build failed
169 | 2021-03-22T21:02:55.071Z [ERROR]: !!! Non-Zero Exit Code detected

Are you not seeing this on your end?

Hey @ganipcanot, I'm also experiencing the same issue. Here is my app arn: arn:aws:amplify:us-east-2:682088751517:apps/dk65qdzmmrw0p

here's a try:
Before pushing the code to AWS amplify try to generate the build locally
npm run build
(in my case it was SVG issue, which AWS console was not detecting)

Over the past couple of years, we have made several improvements to the build logs output in the Amplify console.
Our recommendation would be to first build your application locally (to see if any errors are returned in the process) and then commit the changes to a git repository followed by deploying it on Amplify Hosting.
I am going to close this thread but please feel free to create a new issue if you are experiencing any issues with Amplify Hosting. Thanks!


📝 Documentation Improvement: Update contribute.md

📝 Description
Add some sections in contribute.md:

How to make a pull request
How to create a new branch
Rules to follow .
How to clone a repositry
Pls assign this issue to me @

🖼 Screenshots
No response
📋 Additional Information
No response

Okay, you can start working on this issue.

okk