Backupstore file locks

longhorn/longhorn#612

Punted for 1.0.2

The build failure is caused by an error in the new restore logic?
https://github.com/longhorn/longhorn-engine/blob/4f6eefe90709a219e8d61eaccca263048a3fdd4c/pkg/sync/rpc/server.go#L199
Since we fail the restore operation on purpose to test the delete lock even though the actual restore operation wasn't even started yet, this will still be classified as errorState and not recovered. So after removing the Delete lock the following restore operation should succeed but because the previous restore operation failed (wasn't even started) the code no longer allows for restores?
@shuo-wu Shouldn't this just fallback to full restores?

The build failure is caused by an error in the new restore logic?
https://github.com/longhorn/longhorn-engine/blob/4f6eefe90709a219e8d61eaccca263048a3fdd4c/pkg/sync/rpc/server.go#L199
Since we fail the restore operation on purpose to test the delete lock even though the actual restore operation wasn't even started yet, this will still be classified as errorState and not recovered. So after removing the Delete lock the following restore operation should succeed but because the previous restore operation failed (wasn't even started) the code no longer allows for restores?
@shuo-wu Shouldn't this just fallback to full restores?

All errors after the restore initialization will be blindly recorded in RestoreStatus. Some errors won't affect the following restores and some are critical. But it would be complicated to enable Longhorn to distinguish the errors and start a full restore as the fallback. Instead, Longhorn can directly mark the replica as ERROR first then see if the existing data can be reused during the following rebuilding. (The data reusing is not implemented yet.)
As for the failure you encounter in the test, can you check if function sync_agent_server_reset  works for you? :
https://github.com/longhorn/longhorn-engine/blob/4f6eefe90709a219e8d61eaccca263048a3fdd4c/pkg/sync/rpc/server.go#L257
Or you can create a separate test for each restore related case.

longhorn/longhorn-engine#529 fixed the valid test failure
there is still a flaky test tracked at longhorn/longhorn#1628

This is good to go, I kicked of the build again and we can look into the root cause of the flaky test during the bug fixing phase.


Fix Issuer #58: normalize-by-median: accept paired & unpaired data at the same time

fix: Fixes issue #58 Allows unpaired data to be included with paired data.
refactor: Pulls error handling for normalize into separate wrapper function.

[ ] Is it mergeable?
[ ] Did it pass the tests?
[ ] If it introduces new functionality in scripts/ is it tested?
Check for code coverage with make clean diff-cover
[ ] Is it well formatted? Look at make pep8, make diff_pylint_report,
make cppcheck, and make doc output. Use make format and manual
fixing as needed.
[ ] Did it change the command-line interface? Only additions are allowed
without a major version increment. Changing file formats also requires a
major version number increment.
[ ] Is it documented in the ChangeLog?
http://en.wikipedia.org/wiki/Changelog#Format
[ ] Was a spellchecker run on the source code and documentation after
changes were made?
[ ] Is the Copyright year up to date?

Can one of the admins verify this patch?

Can one of the admins verify this patch?

Jenkins, add to test list

Jenkins, ok to test

Jenkins, test this please


Feature Request: Choose Availability Zone for EKS

Rancher versions:
rancher/server or rancher/rancher: v2.0.6
rancher/agent or rancher/rancher-agent: -
Type/provider of hosts: (VirtualBox/Bare-metal/AWS/GCE/DO)
AWS
When setting up a new cluster in AWS it allows you to choose region, but not availability zones of the nodes. I was unable to setup an EKS cluster through the UI as AWS returned an error that there was not enough capacity in the given AZ. With no option to change the AZ I had to create the cluster directly in AWS and then import it into Rancher.

EKS is currently only supported in the US East (N. Virginia) US West (Oregon) regions, and you can select both of them in rancher as below, each AZ only allows maximum 3 clusters, and it is the AWS limitation.

And for the node templates, you can define as many as you like in different regions.


[New Feature]: Schedule Screen Developement

Feature Request
You need to create one new screen that provides the latest DU Hacks Hackathon Schedule information. You will get data from Schedule Data API. API will give you a JSON response.
Point down the features
• First you need to get Proper response from the API.
• It is your task to think how you can display response which is coming from the given API most effectively & with good designs so the screen looks more interesting.
• Add one menu called "Schedule Information" in SideDrawerMenu. After clicking that menu button your screen which you created for Schedule functionality needs to be open & display.
• While developing the screen Please maintain a color palette, Font Style of the project. You can achieve this by using SizeConfig & Theme Files available in the project just go through home screen code once and see how that is being utilized in project.
• Your design needs to give Professional Vibes.
• Note : The most Good looking Design and Most optimal code PR will get merged.
Select program in which you are contributing
hacktoberfest
Code of Conduct

[X] I follow CONTRIBUTING GUIDELINE of this project.

Greetings @om1512🎀 ! , We are excited to have you dive into another issue with us!🚀
Your involvement in our project has been invaluable, and we're confident that your skills and insights will help us conquer this challenge😇. This issue represents an exciting opportunity for us to improve and enhance our project, and we are thrilled to have you on board.
We request you to follow CONTRIBUTING GUIDELINES.
Looking for your PR soon!
In case of any issues, you can contact us on Discord.❣

Hello i want to work on this issue ,
I have worked on api's..
Please assign this to me..

Hello om1512,
I have worked with several Flutter applications and am interested in this API work. If you're satisfied, you can assign me. Thank you! Have a nice day!

Hello i want to work on this issue , I have worked on api's.. Please assign this to me..

I wanted to personally thank you for your enthusiasm! We greatly appreciate your willingness to help improve our project.
Create seprate file for this feature or we can say that Screen. And try to fullfill requirements listed above ⬆.
Thank you we are waiting for your PR.

Hello om1512,
I have worked with several Flutter applications and am interested in this API work. If you're satisfied, you can assign me. Thank you! Have a nice day!

GREAT... there is one person working on this issue after creation of this screen you can also work on this and optimized and with perfect UI PR will get mearged. We greatly appreciate your willingness to help improve our project.
Create seprate file for this feature or we can say that Screen. And try to fullfill requirements listed above ⬆.
Make sure that you attach Snapshots of your work.
Thank you we are waiting for your PR.

Hey @om1512,
You can close this issue...

Hey @om1512 ! I wanted to inform you that we have closed issue.Thank you for your understanding, and we look forward to your continued engagement with our repository🤗.
In case of any issues, you can contact us on Discord.
Thank you! ❣
Happy Coding! ✨
Will See you soon❣


Phonegap Barcode Scanner Plugin iOS doesn't work with Ionic 1.2.4

I am consoling errors in the terminal. When I try to bring up the barcode scanner (phonegap-plugin-barcodescanner) with my app using Ionic 1.2.4, it freezes and throws this error in the console for iOS and Android.
461469 error Error: Can't find variable: cordovascan@http://192..............
The code following documentation from http://ionicframework.com/docs/1.0.0-rc.0/api/utility/ionic.Platform/:
I updated our code to tell it to only run this stuff  if ionic.Platform.isWebView() is true. Beforehand, the plugin was working with an older version of Ionic. After changing this according to Ionic's documentation, the barcode scanner now does not work. How can I tell if this plugin will be compatible with Ionic 1.2.4? Does this error mean that I just have to find another barcode scanner plugin for my app?
(function (root) {
  'use strict';
  root.Application.controller('AppCtrl', [
    '$scope',
    '$ionicPlatform',
    function ($scope, $ionicPlatform) {
      $ionicPlatform.ready(function() {
         if (ionic.Platform.isWebView()) {
          networkRegistry.register({
                // do some stuff
      });
    }
  ]);
})(this);

ionic info:
Cordova CLI: 5.4.1
Gulp version:  CLI version 3.9.0
Gulp local:   Local version 3.9.0
Ionic Version: 1.2.4
Ionic CLI Version: 1.7.11
Ionic App Lib Version: 0.6.5
ios-deploy version: 1.8.3
ios-sim version: 5.0.4
OS: Mac OS X El Capitan
Node Version: v4.2.3
Xcode version: Xcode 7.2 Build version 7C68

Hello! Thanks for opening an issue with us! Would you be able to provide a codepen that we can use to export and test this issue on our devices? You can use this template i made (http://plnkr.co/edit/jnOrQRtE8rN2WCXDQYQY?p=info) to make it. Thanks again!

It's not able to be produced in webview/browser. it has to do with an issue on iOS and potentially android devices.

Though I'm using a fork of the phonegap barcode scanner, I'm not able to reproduce this myself.  I've explicitly added Cordova iOS 4.1.1.  Below is my ionic info and package.json.

Cordova CLI: 6.1.1
Gulp version:  CLI version 3.9.1
Gulp local:   Local version 3.9.1
Ionic Version: 1.2.4-nightly-1917
Ionic CLI Version: 2.0.0-beta.19
Ionic App Lib Version: 2.0.0-beta.9
ios-deploy version: 1.8.5
ios-sim version: 5.0.8
OS: Mac OS X El Capitan
Node Version: v4.2.3
Xcode version: Xcode 7.3 Build version 7D175

{
  "name": "test",
  "version": "1.0.0",
  "description": "asdf",
  "dependencies": {
    "chromedriver": "^2.21.2",
    "gulp": "^3.9.1",
    "gulp-concat": "^2.6.0",
    "gulp-cssnano": "^2.1.0",
    "gulp-rename": "^1.2.2",
    "gulp-sass": "^2.1.1"
  },
  "devDependencies": {
    "bower": "^1.7.7",
    "gulp-ignore": "^2.0.1",
    "gulp-phantomcss": "^0.1.1",
    "gulp-sourcemaps": "^1.6.0",
    "gulp-tslint": "^4.3.1",
    "gulp-typescript": "^2.11.0",
    "gulp-util": "^3.0.7",
    "jasmine-core": "^2.3.4",
    "jasmine-reporters": "^2.1.1",
    "karma": "^0.13.19",
    "karma-chrome-launcher": "^0.2.1",
    "karma-cordova-launcher": "0.0.9",
    "karma-jasmine": "^0.3.6",
    "karma-ng-html2js-preprocessor": "^0.2.0",
    "karma-phantomjs-launcher": "^1.0.0",
    "karma-spec-reporter": "0.0.24",
    "phantomjs": "^2.1.3",
    "protractor-jasmine2-html-reporter": "0.0.6",
    "shelljs": "^0.6.0",
    "tslint": "^3.3.0",
    "typescript": "^1.7.5"
  },
  "cordovaPlugins": [
    "cordova-plugin-console",
    "cordova-plugin-app-version",
    "cordova-plugin-device",
    "cordova-plugin-dialogs",
    "cordova-plugin-statusbar",
    "cordova-plugin-inappbrowser",
    "cordova-plugin-camera",
    "cordova-plugin-media-capture",
    "cordova-plugin-file",
    "cordova-plugin-geolocation",
    "cordova-plugin-file-transfer",
    "cordova-plugin-network-information",
    "cordova-plugin-certificates",
    "cordova-plugin-whitelist",
    "cordova-plugin-x-toast",
    "cordova-plugin-transport-security",
    {
      "locator": "https://github.com/dually8/BarcodeScanner.git",
      "id": "phonegap-plugin-barcodescanner"
    },
    {
      "locator": "https://github.com/litehelpers/Cordova-sqlite-enterprise-free",
      "id": "cordova-sqlite-evfree"
    },
    "ionic-plugin-keyboard"
  ],
  "cordovaPlatforms": [
    "android",
    {
      "platform": "ios",
      "version": "4.1.1",
      "locator"<EMAIL_ADDRESS>    }
  ]
}

PS: If you have an updated cordova cli, I think it automatically adds the latest iOS version.  You might have to remove it and re-add it.  Not 100% sure.
PSS: Insert shameless plug for my fork of the barcode scanner here.

So, I have tested on my android devices (Nexus 7 2013 running Android 6.0.1 (latest stable public release), Nexus 6 running the Android N dev preview, and a moto x 2014 running android 5.1) and have not been able to reproduce any issue. Would you be able to provide a git repo of you code that i could pull down and use to test on my devices with instead of a codepen? Thanks again!

It's a private repo that can't be shared.. Also, it has to be on a device
because it only happens when ionic.Platform.isWebView()) is false.
I tried adding and removing ios with ionic platform remove ios and `ionic
platform add ios' which doesn't do anything.
On Mon, Apr 11, 2016 at 2:31 PM, Justin Willis<EMAIL_ADDRESS>wrote:

So, I have tested on my android devices (Nexus 7 2013 running Android
6.0.1 (latest stable public release), Nexus 6 running the Android N dev
preview, and a moto x 2014 running android 5.1) and have not been able to
reproduce any issue. Would you be able to provide a git repo of you code
that i could pull down and use to test on my devices with instead of a
codepen? Thanks again!
—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
https://github.com/driftyco/ionic/issues/6110#issuecomment-208571494

  "name": "test",
  "version": "1.0.0",
  "description": "test",
  "scripts": {
    "xcode": "open platforms/ios/*.xcodeproj"
  },
  "dependencies": {
    "gulp": "^3.8.11",
    "gulp-concat": "^2.2.0",
    "gulp-minify-css": "^0.3.0",
    "gulp-rename": "^1.2.0",
    "lodash.defaults": "^3.0.0"
  },
  "devDependencies": {
    "bower": "^1.3.3",
    "gulp-autoprefixer": "^2.0.0",
    "gulp-cached": "^1.0.1",
    "gulp-debug": "^1.0.1",
    "gulp-less": "^3.0.0",
    "gulp-remember": "^0.3.0",
    "gulp-sass": "^2.1.0",
    "gulp-sourcemaps": "^1.3.0",
    "gulp-util": "^2.2.14",
    "less-plugin-autoprefix": "^1.1.0",
    "require-dir": "^0.1.0",
    "shelljs": "^0.3.0",
    "xcode": "0.6.2"
  },
  "cordovaPlugins": [
    "https://github.com/EddyVerbruggen/LaunchMyApp-PhoneGap-Plugin.git",
    "https://github.com/whiteoctober/cordova-plugin-app-version.git",
    "org.apache.cordova.console",
    "com.verso.cordova.clipboard",
    "nl.x-services.plugins.socialsharing",
    "nl.x-services.plugins.toast",
    "org.apache.cordova.inappbrowser",
    "org.apache.cordova.device",
    "./engine/cordova-crosswalk-engine-c0.7.1",
    "org.apache.cordova.splashscreen",
    "cordova-plugin-crosswalk-webview",
    "cordova-plugin-splashscreen",
    "com.phonegap.plugins.barcodescanner",
    "cordova-plugin-statusbar"
  ],
  "cordovaPlatforms": [
    "ios",
    "android"
  ]
}

The Cordova plugins might need to be updated due to the new plugin naming conventions. http://cordova.apache.org/announcements/2015/04/21/plugins-release-and-move-to-npm.html

Could it potentially be our environment, plugins, or other dependencies
that are clashing? Seems weird that QR scanner wont work with Ionic 1.2.4
On Tue, Apr 12, 2016 at 11:54 AM, CJ Coffey<EMAIL_ADDRESS>wrote:

The Cordova plugins might need to be updated due to the new plugin naming
conventions.
http://cordova.apache.org/announcements/2015/04/21/plugins-release-and-move-to-npm.html
—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
https://github.com/driftyco/ionic/issues/6110#issuecomment-209051816

@hasLoren Have you gotten a chance to try @dually8 's fork of that plugin?

And also make sure your plugins have no . (periods) in them.  Due to the new naming convention, you shouldn't see any dots unless you're installing a plugin locally (e.g ./somefolder/someplugin)  Things like org.apache.cordova.console should now be cordova-plugin-console.

Hello! I am going to close this issue for now as it has been a little while since there was any activity. Thanks for using ionic!

I tried changing the namespace and it still didn't help. Still getting the
same error that it can't find cordova
On Mon, Apr 25, 2016 at 9:35 AM, Justin Willis<EMAIL_ADDRESS>wrote:

Closed #6110 https://github.com/driftyco/ionic/issues/6110.
—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
https://github.com/driftyco/ionic/issues/6110#event-640279542

@hasLoren Sorry your still having this issue. Would you mind opening an issue over on the ionic-cli repo (https://github.com/driftyco/ionic-cli) describing this issue please?


Cartesian to internal coordinates

Not really an issue, but more of a feature request (in case it doesn't exist).
Is there any way to convert conformations from cartesian to internal coordinates (z-matrix) using rdkit?

@pcko1 I don’t believe there is one at the moment, but quick googling suggests a number of solutions, such as https://pypi.org/project/chemcoord/ (Python), OpenBabel (C, C++)

thanks, I have seen the existing implementation but was wondering whether it is also implemented in our favourite library

thanks, I have seen the alternative implementations but was wondering whether it is also implemented in our favourite package

@ptosco While this extension is nice, https://pypi.org/project/chemcoord/, is there a way to get MMFF gradients with respect to the internal coordinates? Or might I have to program this myself?
Also seconding the feature request to build this into RDKit!

@tarungog you can check currently available functionality in the C++ and Python API docs. There is a calcGrad accessor on the ForceField object accessible from both C++ and Python that will give you gradients at the position of each force field particle. From C++ you can also access gradients of individual force field contributions through ForceFields::ForceFieldContrib::getGrad().

Not sure if this is still relevant, but I implemented Zmatrix retrieval from an rdkit object in python: https://github.com/wutobias/r2z
Maybe it is of use to someone. If there is interest, I also have code to project gradients on the internals.


Exposing a getUniformName function.

There is a function to get the uniforms from a shader(getShaderUniforms) but no way to identify them.
Context has a method to get a uniform's name(Context::getName), but is not exposed in the main bgfx header.
This is an extremely easy thing to expose to the main bgfx header.
But if there is an agreed need for this function to be exposed, I will send a pull request.
Sidenote, I also don't know what type they are or how many elements there is if it is an array.

The reason why is not exposed is because your app should know about what uniforms you're using. Only case where this is not true is if you're making something like RenderMonkey.

Thanks for responding, What you said is a fair argument. I'm not making a new RenderMonkey, I merely want it for debugging purposes and maybe some other dynamic stuff. And I suppose you don't feel comfortable with somebody using bgfx to make something like RenderMonkey? And its cool if you don't, I can still use uniforms like you said and be fine. I just saw a need for a method to be exposed and wouldn't have minded being able to see a name for all the uniforms without modifying bgfx some. You can close this if you see no need for this verbose functionality.

So generally if you create all uniforms you need in your shaders and getShaderUniforms returns some shader uniform you didn't create it's generally an error (typo, or you forgot to create uniform).
Reason why I don't want to add it is because I have some major shader changes planned and don't want to add more API before that.
RenderMonkey clone on top of bgfx would be actually good idea for project. :)

Hi, sorry for bothering, but do you have any detailed ideas or plans for "some major shader changes"?

Plan is to get to single shader binary (spir-v) and use runtime shader translation to specific renderers (see shader_*.cpp/h in src directory).

One more usecase for getUniformName. For example, I have so called shared uniforms, like light params or normal matrix. Then, I create a shader and engine will know, which uniforms are shared and which are not so the engine can update shared uniforms accordingly when submitting a draw call.


Report a violation when freeze is called on a frozen string literal…

… in Style/RedundantFreeze

I've rebased and merged this myself.


finished all the routes

added post, put helpfulness and put reported for both q and a

good job meilin


fix(test-tooling): use of hardcoded password

Commit to be reviewed

fix(test-tooling): use of hardcoded password
Primary Changes
----------------
1. BREAKING CHANGE: "password" is now a mandatory parameter of the newEthPersonalAccount function
defined in openethereum-test-ledger.ts. It was previously optional.
2. Updated line 236 in openethereum-test-ledger.ts so the default password argument to the
newEthPersonalAccount function is not hardcoded.

Fixes #2766
Pull Request Requirements

[ ] Rebased onto upstream/main branch and squashed into single commit to help maintainers review it more efficient and to avoid spaghetti git commit graphs that obfuscate which commit did exactly what change, when and, why.
[ ] Have git sign off at the end of commit message to avoid being marked red. You can add -s flag when using git commit command. You may refer to this link for more information.
[ ] Follow the Commit Linting specification. You may refer to this link for more information.

Character Limit

[ ] Pull Request Title and Commit Subject must not exceed 72 characters (including spaces and special characters).
[ ] Commit Message per line must not exceed 80 characters (including spaces and special characters).

A Must Read for Beginners
For rebasing and squashing, here's a must read guide for beginners.

Did you verify if the test cases requiring this piece of code clearly specifies test as the password?

@jagpreetsinghsasan There are no test cases in the repo using this code/function

@ashnashahgrover Please fix the commit lint issues and document that it's a breaking change in the commit message (which then will get recognized by the change log and put in the release notes). You can find the expected format for breaking changes in the conventional commit messages standard.

@petermetz I have addressed these changes.

@ashnashahgrover The breaking change is that you made a previously optional parameter of the function mandatory. It doesn't refer to line breaks in text (although those can be important too because the commit linter will fail that as well). Please refactor the PR description/commit message accordingly.

Have adjusted both the commit message and PR description accordingly.

@ashnashahgrover The breaking change is that you made a previously optional parameter of the function mandatory. It doesn't refer to line breaks in text (although those can be important too because the commit linter will fail that as well). Please refactor the PR description/commit message accordingly.

Have adjusted both the commit message and PR description accordingly.

No it isn't updated @ashnashahgrover
CURRENT PR BODY (Breaking changes going out of the primary changes section)

CURRENT COMMIT MESSAGE (Breaking changes are after the fixes tag)

Currently this one is stuck because of a pending change request from @jagpreetsinghsasan
@ashnashahgrover In case you didn't re-request review from @jagpreetsinghsasan , please do that.
@jagpreetsinghsasan If there was a re-request review then please re-review when you get the chance so that we can move this along.
I'm not sure either way where did this one get stuck, but either which way let's get in moving!


Find discrepancies in Feed

I ran fintech-to-ynab for multiple weeks with Monzo. Unfortunately the balance is off. Also unfortunately ynab doesn't really sort by datetime so it's hard to manually compare.
It should be fairly simple to compare the transactions programatically. Is there a rake task to show what is missing?

Running the import CLI should add any that are missing. But, i started messing around with this, but be careful as it was just hacked together to help me with foreign transactions amounts that had been changed since they were first charged.
https://github.com/fintech-to-ynab/fintech-to-ynab/blob/master/app/services/import/monzo.rb#L19-L71

In the meantime I figured out what's wrong. Hopefully this will help:
If you use your Monzo card for contactless payment on TfL the charges behave a little different. On first enter you will be charged 10 pennies. At the end of the day this transaction is then replaced with the total amount of your days worth trip. So your balance will be off by that amount minus 10 cents.

Yeah that makes sense. The TFL stuff is a mess (not Monzo's fault).
The script above would have fixed that for you. It's basically the same situation as when foreign transactions have their GBP amounts update once the transaction settles.


How to write custom query with Spring FirestoreReactiveRepository

Just wanted to make sure the question opened in stackoverflow  will get your attention.

Hey @p595285902 - will take a look at this for you shortly...

@p595285902 we don't support @Query custom queries because there is no query language in Cloud Firestore. I could recommend using name based query methods:
public interface UserRepository extends FirestoreReactiveRepository<User> {
    Flux<User> findByAge(Integer age);

    Flux<User> findByAgeGreaterThanAndAgeLessThan(Integer age1, Integer age2);

    Flux<User> findByAgeGreaterThan(Integer age);

    Flux<User> findByAgeGreaterThan(Integer age, Pageable pageable);

    Mono<Long> countByAgeIsGreaterThan(Integer age);
}

See documentation for more details.

Thanks for the quick reply.

Cloud Firestore only supports filter components joined by AND, and the following operations:

Is OR going to come anytime soon?

Thank you.


Still supported?

Is the OPC UA Server for IOBroker still under development? I see some issue that are not addressed for years.
I am facing the same issues. Is it worth to provide additional input here?

Yes please provide ... as more details the better

Closed as no new info provided


Request to switch MatTimepickerIntl properties to function/accessors

So I am in need of implementing various internationalizations for the component.
We have our translations stored in txt files for various reasons, one being real time modification; but it could very well be a Db and ultimately it does not matter much I think.
Now, I would appreciate it if MatTimepickerIntl would have a function/accessor instead of string for translations.
This is because I can change localization on the fly and while I am able to reset values for public properties on change, it would be easier to have a function that does it on the fly.
So, instead of inputsTitle: string; I'd like inputsTitle: string | () => string;
Even better, ideally I would like to have something akin to how AgGrid does it:
this.getLocaleText = (params: GetLocaleTextParams): string => { 			return LocalizationService.get(ag_grid.${params.key});  		}; // LocalizationService is our custom translations provider and ag_grid is our custom token for clarity of entries
In this way, there only exists 1 single function to read the value of a localizable string and I never have to do anything else about it.
Each params.key is property name (so for instance, 'inputsTitle') and instead of writing hardcoded values in my custom classes, I would be able to just set 1 function to read values from wherever my localization storage is (implementation for reading is what would be overridable).
Also, it's weird localization is not (initially) bound to both translations and hour format?

I added changes property. So, if you have a new string and need to update it just call intl.changes.next(). This is the same approach as material datepicker has. You can get string from anywhere, change them and call intl.changes.next() then.
Fixed in:
15.4.3
16.4.3
17.6.3
18.0.4


Comparing option is grayedout since the new 1.17 update

Hi and thanks for this great plugin,
however, since the 1.17 update, the comparing option is grayed out, at least in my case.

I use ST 2 (2.0.2 build 2221) on win 10 x64.
Maybe I am wrong somewhere but yet everything was working fine before this update.
Thanks in advance for checking this out.
My dirty solution is to backup the 1.17 sbs_compare.py and replace with the 1.16.2 one, sorry I am not familiar with python

Oops, looks like I broke something for ST2 in that update. Sorry about that.
Patched, should be working now. Thanks for reporting this!


fix: use CGO_ENABLED=0 for release builds

Ensure that release builds are built with cgo disabled.  This is usually the case for cross-compiled builds anyway, but adding this flag makes builds consistent regardless of what platform they are being built on.
In particular, without CGO_ENABLED=0, if you make the release builds on a linux/amd64 system then the linux/amd64 binary is dynamically linked against the system libc of the build machine, meaning a binary built on a glibc-based system like Ubuntu will not work on a musl libc system like Alpine.  This is what appears to have happened for release 2.8.1.
But the same source code built on a different system (e.g. darwin/arm64) would cross-compile the linux/amd64 binary with cgo disabled, making a static binary that works on both glibc and musl systems.  This is what appears to have happened for release 2.8.2.
Setting CGO_ENABLED=0 in the Makefile will make the behaviour consistent for future releases, producing static binaries for the linux builds in all cases, whatever the build platform.
Fixes #684

Nice one, yeah I compiled the 2.8.2 on MacOS, whereas older releases were compiled on Ubuntu Linux


Ensure that package creation task is executed before publishing

Resolves #58.

thanks. I feel like this will fix a handful of issue's that popped up after the last big refactor

Would be nice if this were cut into a release..

Indeed, 0.3.0 is basically unusable now if you have the problem this fixes.

+1


derive Default on Option-heavy structs to enable ..Default::default() pattern

Hiya! Not a bug, just a little usability thing that I felt could be improved a little. A lot of the option structs are very Option<T>-heavy, and in several cases the user won't need all of the fields. This derive allows the user to initialize these structs in a much cleaner manner, without needing to put in several field: None,.

Thank you!


Blog sidebar is missing

Is this a bug report?
Yes
Have you read the [Contributing Guidelines on issues]
Yes
Environment
Chrome
Steps to Reproduce

Load https://docusaurus.io/blog/

Expected Behavior
See sidebar
Actual Behavior
Sidebar is missing
Reproducible Demo
Visit https://docusaurus.io/blog/
This broke in #646. @ahmadalfy would you be available to have a look?

Sure, apologies for that

Not a problem, it hasn't been released to users, so it's all good. Thanks for the quick response!

When I reverted the change, I still see the same view.
Just to confirm, this isn't the sidebar you are talking about right?
https://imgur.com/a/SBJYA0j

OK I found it, I wasn't seeing it because I thought it is deployed. Will fix that


Is it possible to use tokio runtime instead of the dune-event-loop?

hi, Thanks to your project, I've learned a lot from it.
When looking into the JsRuntimeState, I find out that it implements the javascript async keyword through the rust future.
Today we usually use the popular tokio async runtime. Is it possible to use it along with this js runtime?
Also, could you please give some more design & technical details about the EventLoop inside dune-event-loop?

Hello @linrongbin16 👋
Thanks for reviewing Dune, and apologies for the delayed response—my time is currently limited, and I'm prioritizing other projects for now.
You're almost correct about how the native JsFuture trait is utilized in the runtime. It's not exactly about implementing the async keyword, as it's also used in cases like setTimeout and setInterval, but you've captured the main idea behind it. I'm not sure how straightforward it would be to integrate tokio into this project, as my original goal was to build the event loop myself, and the entire runtime is structured around that. I’m confident that the dune-event-loop crate provides everything the runtime needs, as it’s modeled after libuv, which is what Node.js uses internally.
I wrote some technical documentation where I cover a few details (in case you haven't seen it yet): https://github.com/aalykiot/dune/blob/main/docs/the-runtime.md
I had considered writing technical documentation specifically for the event loop (and still might), but I just need to find the time and energy to do so. 😅

Really thanks for your reply! Looking forward to your tech document about the event loop!

hi, I come back and want to share some learning with you, hope I don't bother you.
After reading the source code of this project for quite a time, I realize each pair of task and task_cb are all sync functions. It seems task is usually the slow work, for example download js module from network/http. And task_cb is usually pure CPU/memory operations so they are fast.
And for the event loop, (please correct me if I am wrong) it uses a thread pool to execute every task, and then invoke the callbacks.
Let's focus on the load_import function and EsModuleFuture. They are both sync.
When I am trying to rewrite it with tokio runtime, I found I need to make the load_import to async, and the EsModuleFuture can be turned into an async function as well.
Because when the module is a URL, load_import will be slow, and inside it, we could use some async methods to download the js module from the network/http.
Thanks again to your project, I've learned so much from it!

Hello again @linrongbin16 👋, since you're likely interested in the internals due to your own project, rsvim, I'll do my best to provide detailed answers to your questions. I’m not sure how I would approach integrating tokio into Dune, as it wasn’t really designed with async Rust in mind, but I imagine it would be a challenge.

task vs task_cb

It's easier to grasp the concepts of task and task_cb when viewed from the perspective of the event loop, rather than focusing on the runtime itself. The event loop (dune-event-loop) was specifically designed to be context-aware. With this in mind, a task is essentially something you want to offload to the thread pool for execution. This is primarily used (even within Dune) to handle operations that could block a thread, such as file I/O, DNS resolution, etc. Since both JS and the runtime run on a single thread, blocking it would cause problems. Ideally, for network-related tasks, it's better to rely on network primitives (like Dune does for the TCP/HTTP part of the runtime), but that required too much effort, so I opted to use the thread pool for fetching ES modules instead.
The core idea is that you submit your task to the thread pool, and once the blocking or long-running operation completes, the task_cb callback is invoked with the results.
https://github.com/aalykiot/dune-event-loop?tab=readme-ov-file#documentation
let mut event_loop = EventLoop::default();
let handle = event_loop.handle();

let read_file = || {
    let content = std::fs::read_to_string("./examples/async.rs").unwrap();
    Some(Ok(content.as_bytes().to_vec()))
};

let read_file_cb = |_: LoopHandle, result: TaskResult| {
    let bytes = result.unwrap().unwrap();
    let content = std::str::from_utf8(&bytes).unwrap();
    println!("{}", content);
};

handle.spawn(read_file, Some(read_file_cb));

while event_loop.has_pending_events() {
    event_loop.tick();
}

Now, the reason we have the JsFuture trait is similar to the issue you encountered with V8 not being Send (https://github.com/rsvim/rsvim/issues/112), meaning you can't transfer Isolates or HandleScopes to other threads to execute JS code. :(

Event-Loop Ticks

As I mentioned earlier, the event loop, runtime, and V8 (aka JavaScript) all run on a single thread—the main thread.
While V8 might utilize multiple threads for various tasks, the actual execution of JavaScript happens on the same thread as the runtime. You can think of it as V8 and the runtime sharing the same thread, with execution switching back and forth between them.
When the event loop is ticked, it eventually reaches the poll phase:
/// Performs a single tick of the event-loop.
pub fn tick(&mut self) {
    self.prepare();
    self.run_timers();
    self.run_poll(); // <------------- THIS ONE.
    self.run_check();
    self.run_close();
}

https://github.com/aalykiot/dune-event-loop/blob/main/src/lib.rs#L422-L429
https://github.com/aalykiot/dune-event-loop/blob/main/src/lib.rs#L519
At this stage, a decision is made on whether the event loop should block the main thread and wait for events, such as a timer expiring or the thread pool completing a task, or continue running until the tick ends. The reason we block the main thread at this point is because there's nothing to do at that moment (we're waiting), and this allows the OS to deschedule us from the CPU, conserving resources. When there's work to be done, the OS will wake us up, and the loop will resume, handing control back to the runtime. The runtime will then instruct V8 to execute some JavaScript..

Here's more info about low-level kernel polling: https://medium.com/@avocadi/what-is-epoll-9bbc74272f7c

I hope I was able to answer some of your questions and didn’t end up confusing you even more. 😅
Feel free to ask any more questions about Dune's internals. Thanks! 🙂

thank you!


Test against Django 2/3, Python 3.7/3.8

Coverage decreased (-1.7%) to 83.813% when pulling a10771fc47938aa1c4eb838db5e0a156f10b2e55 on new_python_django_versions into 25edc4172b1e398323f8f51c1b31410ce9905b99 on master.

Yay!


google/global.txt:  Can sometimes freak out on Google Images

Eats every result, regardless of them being spam or not.

This issue occurs for me as well on a variety of searches.
With the search query "memtest menu" in private browsing, every image result gets eaten for me.

I've tested that with every other filter disabled and only "uBlock-Origin-dev-filter – Google+DuckDuckGo – Global" enabled, the results get eaten; with "uBlock-Origin-dev-filter – Google+DuckDuckGo – Global" disabled, the results do not get eaten.

It appears the problem is that the filter list selects the .MjjYud element. On the normal search results page, each .MjjYud corresponds to a single search result, which makes it work perfectly. On the image search results page, however, all the search results are wrapped in a .MjjYud, meaning every result gets eaten if at least one result matches one of the blacklisted domains.

I've found a fix that seems to work for now, although it allows image results to surface from the site you want to blacklist.
I replaced :upwards(.MjjYud) in the filter with :upwards(.Ww4FFb).
So for example, to block Google results from example.com, you'd use google.com###rso .MjjYud a[href*="example.com"]:upward(.Ww4FFb).


[crashpad/vcpkg-tool-gn] build failure

Package: crashpad[core]:x64-windows -> 2022-09-05#1
Host Environment

Host: x64-windows
Compiler: MSVC 19.33.31630.0
vcpkg-tool version: 2022-11-10-5fdee72bc1fceca198fb1ab7589837206a8b81ba
vcpkg-scripts version: 06071749b 2022-12-14 (32 hours ago)

To Reproduce
vcpkg install
Failure logs
-- Note: crashpad only supports static library linkage. Building static library.
-- Using cached C:/vcpkg/downloads/crashpad-261679b3d2f3336d8531ed38e110254c3e2d1c10.tar.gz
-- Cleaning sources at C:/vcpkg/buildtrees/crashpad/src/4c3e2d1c10-1c4f0a1e28.clean. Use --editable to skip cleaning for the packages you specify.
-- Extracting source C:/vcpkg/downloads/crashpad-261679b3d2f3336d8531ed38e110254c3e2d1c10.tar.gz
-- Using source at C:/vcpkg/buildtrees/crashpad/src/4c3e2d1c10-1c4f0a1e28.clean
-- Using cached C:/vcpkg/downloads/crashpad-5654edb4225bcad13901155c819febb5748e502b.tar.gz
-- Extracting source C:/vcpkg/downloads/crashpad-5654edb4225bcad13901155c819febb5748e502b.tar.gz
-- Using source at C:/vcpkg/buildtrees/crashpad/src/b5748e502b-44507d16bb.clean
-- Found external ninja('1.10.2').
-- Getting CMake variables for x64-windows
-- Generating build (x64-windows-dbg)...
-- Generating build (x64-windows-rel)...
-- Building (x64-windows-dbg)...
CMake Error at scripts/cmake/vcpkg_execute_build_process.cmake:131 (message):
    Command failed: "C:/Program Files/Microsoft Visual Studio/2022/Community/Common7/IDE/CommonExtensions/Microsoft/CMake/Ninja/ninja.exe" -C C:/vcpkg/buildtrees/crashpad/x64-windows-dbg client client:common util third_party/mini_chromium/mini_chromium/base handler:crashpad_handler
    Working Directory: C:/vcpkg/buildtrees/crashpad/src/4c3e2d1c10-1c4f0a1e28.clean
    See logs for more information:
      C:\vcpkg\buildtrees\crashpad\build-x64-windows-dbg-out.log
      C:\vcpkg\buildtrees\crashpad\build-x64-windows-dbg-err.log

Call Stack (most recent call first):
  scripts/cmake/vcpkg_build_ninja.cmake:3 (vcpkg_execute_build_process)
  scripts/cmake/vcpkg_build_ninja.cmake:24 (z_vcpkg_build_ninja_build)
  scripts/cmake/vcpkg_install_gn.cmake:95 (vcpkg_build_ninja)
  buildtrees/versioning_/versions/crashpad/f7ead3d493577856543add942c07776fe60ded9e/portfile.cmake:99 (vcpkg_install_gn)
  scripts/ports.cmake:147 (include)

C:\vcpkg\buildtrees\crashpad\build-x64-windows-dbg-out.log
ninja: Entering directory `C:/vcpkg/buildtrees/crashpad/x64-windows-dbg'

C:\vcpkg\buildtrees\crashpad\build-x64-windows-dbg-err.log
ninja: error: FindFirstFileExA(../../../../../e:/vtslink/client/build-debug/vcpkg_installed/x64-windows/debug/lib): 文件名、目录名或卷标语法不正确。

Additional context
vcpkg.json
{
  "name": "vts-link-client",
  "version-string": "0.0.1",
  "dependencies": [
    "kcp",
    "libdatachannel",
    "brotli",
    "libyuv",
    "protobuf",
    "concurrentqueue",
    "crashpad",
    {
      "name": "ffmpeg",
      "default-features": true,
      "features": [
        "nvcodec",
        "qsv",
        "x264"
      ]
    }
  ],
  "overrides": [
    {
      "name": "openssl",
      "version-string": "1.1.1m#2"
    }
  ],
  "builtin-baseline": "06071749ba78c76f425765106a94b1832a2ae06e"
}

For anyone who wants a workaround:
So the problem is for sure related to the ../../../../../E:/ path, and the solution is simple:

Clone the gn.exe upstream and modify file src/gn/escape.cc
In function EscapeStringToString, add this code to remove leading ../

// Escapes |str| into |dest| and returns the number of characters written.
size_t EscapeStringToString(std::string_view str,
                            const EscapeOptions& options,
                            char* dest,
                            bool* needed_quoting) {

  auto vol = str.find(":/");
  if (vol != std::string::npos) {
    str = str.substr(vol - 1, str.size() - vol + 1);
  }

Build the code with VS Developer console if you are using windows (or follow the gn document)
Replace the gn.exe in vcpkg_installed\x64-windows\tools\gn under your project's cmake folder
Regenerate the cmake and you are good to go.

Confirmed, reproduced locally.

Related links:
https://bugs.chromium.org/p/gn/issues/detail?id=317
https://gn-review.googlesource.com/c/gn/+/14940

Any suggestions? Could we build gn instead of download it and patch gn for this problem?

Some feedback based on my recent update to port skia.
(My changes are meant to be generalizable for other gn ports, but I would need more time to do it.)
gn versioning
gn should be used in the version required by the actual package. However, it is a soft requirement: you may use a newer version with good success.
vcpkg doesn't offer an interface to select a particular version. ATM vcpkg has three way to get gn:

Port vcpkg-gn installs 1945 (4aa9bdfa).
Port vcpkg-tool-gn installs 2014 (c114b7e0).
vcpkg_find_acquire_program installs  2014 (c114b7e0).

crashpad wants gn 2ecd43a10266bd091c98e6dcde507c64f6a0dad3, but implicitly uses the third method. So the version it uses lags by app. 28  commits.
You might try to add a dependency on vcpkg-tool-gn, and update this port to a new version of gn.
Dependency handling
vcpkg needs to de-vendor some dependencies which otherwise would be built by gn. Port crashpad has a function replace_gn_dependency to handle this for zlib.
Please check that it is not this function which injects build code which breaks gn.

Does that specific version of gn handles path correctly? Because I tried the latest port and it still failed.

Does that specific version of gn handles path correctly? Because I tried the latest port and it still failed.

Please ensure you test with the requested version of gn. I don't understand what you actually tried.
I cannot test (MSVC) windows triplets, only mingw triplets which usually come with other problems (and alternative path syntax).
The point is: there is a ninja rule which looks strange. Why is it generated in this way, from which input?
If already the input is invalid, we can't say that gn doesn't handle paths correctly. Garbage in, garbage out.
OTOH it seems to work for upstream, and it works in vcpkg CI.

The point is: there is a ninja rule which looks strange. Why is it generated in this way, from which input?

The strange path (../../../../../E$:/) seems generated by gn (It might comes from input cli, but I don't find any related pattern.) Resulting a corrupted ninja build file.

To make it explicit: Is E:... the location of your user project?

Yes, that is my project using manifest mode. And my vcpkg root is C:\vcpkg
If I directly vcpkg install crashpad it will succeed, probably because buildtree and install path are not crossing disk and both on C:.

Please test the changes from #28503. I could do some limited experimentation with mingw. It seems that the problem is indeed related to the injection of the zlib paths. With native Windows paths (\ separator), I don't see the invalid zlib dependency, but the lib still appears in command lines as needed.

@dg0yt Sadly no, this is not fixed and the error are same. The path still has leading ../../../../../E:/

Same for skia: #24719

Does all google projects community like dead? Nobody checks issues...

FYI: I managed to fix this issue in upstream, do we need to revert #29058 ?
https://gn-review.googlesource.com/c/gn/+/16620


ObjectDB instances leaked at exit/Leaked instances not freed properly

Describe the bug
When exiting a game with PankuConsole using get_tree().quit(), this appears in the log file:
USER` WARNING: ObjectDB instances leaked at exit (run with --verbose for details).

--verbose debug:
Leaked instance: GDScriptNativeClass:-9222826679087398058
Leaked instance: GDScriptNativeClass:-9222825579575770280
Leaked instance: GDScript:-9222391272482798372 - Resource path: res://addons/panku_console/common/panku_module.gd
Leaked instance: GDScript:-9222387973947915043 - Resource path: res://addons/panku_console/modules/native_logger/module.gd
Leaked instance: GDScript:-9222189512099101470 - Resource path: res://addons/panku_console/modules/screen_notifier/module.gd
Leaked instance: GDScript:-9222098252633996057 - Resource path: res://addons/panku_console/modules/keyboard_shortcuts/module.gd
Leaked instance: GDScript:-9222358287133965079 - Resource path: res://addons/panku_console/common/module_options.gd
Leaked instance: GDScript:-9222153777971198698 - Resource path: res://addons/panku_console/modules/system_report/module.gd
Leaked instance: GDScript:-9222149379924687564 - Resource path: res://addons/panku_console/modules/history_manager/module.gd
Leaked instance: GDScript:-9222102650680507076 - Resource path: res://addons/panku_console/modules/engine_tools/module.gd
Leaked instance: GDScript:-9222040528273537722 - Resource path: res://addons/panku_console/modules/interactive_shell/module.gd
Leaked instance: GDScript:-9221892094203787904 - Resource path: res://addons/panku_console/modules/general_settings/module.gd
Leaked instance: GDScript:-9221576534366616129 - Resource path: res://addons/panku_console/modules/expression_monitor/module.gd
Leaked instance: GDScript:-9221592477285218877 - Resource path: res://addons/panku_console/modules/screen_crt_effect/module.gd
Leaked instance: RefCounted:-9221356082285247014
Leaked instance: RefCounted:-9221355532529433107
Leaked instance: RefCounted:-9221350034971294216
Leaked instance: RefCounted:-9221349485215480327
Leaked instance: RefCounted:-9221348935459666438
Leaked instance: RefCounted:-9221348385703852549
Leaked instance: RefCounted:-9221347835948038660
Leaked instance: RefCounted:-9221347286192224771
Leaked instance: RefCounted:-9221346186680596993
Leaked instance: RefCounted:-9221345636924783104
Leaked instance: RefCounted:-9221335741320133117
Leaked instance: GDScript:-9221341788634085884 - Resource path: res://addons/panku_console/modules/native_logger/env.gd
Leaked instance: Resource:-9221326945227110907 - Resource path:
Leaked instance: GDScript:-9221332992541063674 - Resource path: res://addons/panku_console/modules/native_logger/opt.gd
Leaked instance: GDScript:-9221236235517819339 - Resource path: res://addons/panku_console/modules/screen_notifier/env.gd
Leaked instance: RefCounted:-9221230188203866568
Leaked instance: RefCounted:-9221211496506194318
Leaked instance: GDScript:-9221226889668983181 - Resource path: res://addons/panku_console/modules/system_report/env.gd
Leaked instance: GDScript:-9221219193087588748 - Resource path: res://addons/panku_console/modules/system_report/os_report.gd
Leaked instance: RefCounted:-9221210946750380427
Leaked instance: RefCounted:-9221201600901544330
Leaked instance: GDScript:-9221207648215497097 - Resource path: res://addons/panku_console/modules/history_manager/env.gd
Leaked instance: Resource:-9221192804808522120 - Resource path:
Leaked instance: GDScript:-9221198852122474887 - Resource path: res://addons/panku_console/modules/history_manager/opt.gd
Leaked instance: RefCounted:-9221115838994577682
Leaked instance: GDScript:-9221121886308530449 - Resource path: res://addons/panku_console/modules/engine_tools/env.gd
Leaked instance: Resource:-9221107042901555472 - Resource path:
Leaked instance: GDScript:-9221113090215508239 - Resource path: res://addons/panku_console/modules/engine_tools/opt.gd
Leaked instance: RefCounted:-9221098246808533262
Leaked instance: GDScript:-9221104294122486029 - Resource path: res://addons/panku_console/modules/keyboard_shortcuts/env.gd
Leaked instance: Resource:-9221089450715511052 - Resource path:
Leaked instance: GDScript:-9221095498029463819 - Resource path: res://addons/panku_console/modules/keyboard_shortcuts/opt.gd
Leaked instance: RefCounted:-9221046020006213843
Leaked instance: GDScript:-9221052067320166610 - Resource path: res://addons/panku_console/modules/interactive_shell/env.gd
Leaked instance: Resource:-9221037223913191633 - Resource path:
Leaked instance: GDScript:-9221043271227144400 - Resource path: res://addons/panku_console/modules/interactive_shell/opt.gd
Leaked instance: RefCounted:-9220958608831805538
Leaked instance: GDScript:-9220964656145758305 - Resource path: res://addons/panku_console/modules/general_settings/env.gd
Leaked instance: Resource:-9220947613715527776 - Resource path:
Leaked instance: GDScript:-9220955860052736095 - Resource path: res://addons/panku_console/modules/general_settings/opt.gd
Leaked instance: RefCounted:-9220933320064366686
Leaked instance: GDScript:-9220939367378319453 - Resource path: res://addons/panku_console/modules/screen_crt_effect/env.gd
Leaked instance: Resource:-9220924523971344476 - Resource path:
Leaked instance: GDScript:-9220930571285297243 - Resource path: res://addons/panku_console/modules/screen_crt_effect/opt.gd
Leaked instance: RefCounted:-9220915727878322266
Leaked instance: GDScript:-9220921775192275033 - Resource path: res://addons/panku_console/modules/expression_monitor/env.gd
Hint: Leaked instances typically happen when nodes are removed from the scene tree (with `remove_child()`) but not freed (with `free()` or `queue_free()`).

That's really Weird, RefCounted's lifecycle should be managed automatically by the engine instead of users, maybe a cyclic reference?
I have tried to reproduce, it still happens randomly even if you don't use get_tree().quit().
Also, the get_tree().quit() should be renamed to something like get_tree().force_quit() since it doesn't send any notifications which means there's no way to know if the program is about to quit, use get_tree().root.propagate_notification(NOTIFICATION_WM_CLOSE_REQUEST) instead (I know it's kind of cumbersome) so the plugin can save things properly.

I've tried a simple project containing two RefCounted instances that references each other, and same thing happens.
USER WARNING: ObjectDB instances leaked at exit (run with --verbose for details).
   at: cleanup (core/object/object.cpp:2208)
Leaked instance: GDScriptNativeClass:-9222873408331578639
Leaked instance: RefCounted:-9222491877796739897
Leaked instance: RefCounted:-9222491328040926008
Leaked instance: GDScript:-9222501223645575989 - Resource path: res://A.gd
Hint: Leaked instances typically happen when nodes are removed from the scene tree (with `remove_child()`) but not freed (with `free()` or `queue_free()`).
USER ERROR: Resources still in use at exit (run with --verbose for details).
   at: clear (core/io/resource.cpp:493)
Resource still in use: res://A.gd (GDScript)

Seems it's indeed the case, cyclic reference, the dark side of garbage collector free languages...
There must be a circle reference somewhere in my codebase, and according to the documentation:

RefCounted instances caught in a cyclic reference will not be freed automatically. For example, if a node holds a reference to instance A, which directly or indirectly holds a reference back to A, A's reference count will be 2. Destruction of the node will leave A dangling with a reference count of 1, and there will be a memory leak. To prevent this, one of the references in the cycle can be made weak with @GlobalScope.weakref().

So, the solution is obvious now, find that reference loop, then, use weakref() to break the loop.

hellish...

Decide to use Node instead of RefCounted now.

Thanks for the fix! Going to follow up on that soon.

Apologies for the delay. The issue is indeed fixed! @Ark2000

good to see it.


[bug] luafilesystem broken when installed with --lua-versions 5.2, 5.3 and 5.4

rocks install --lua-version 5.3 luafilesystem
nix shell nixpkgs#lua5_3
lua
> require("lfs")
error loading module 'lfs' from file<EMAIL_ADDRESS><EMAIL_ADDRESS>undefined symbol: luaL_register
stack traceback:
        [C]: in ?
        [C]: in function 'require'
        stdin:1: in main chunk
        [C]: in ?

It looks to me like we're not linking (the correct?) lua headers ~(perhaps they're not installed as needed?)~.

This has been fixed, likely by https://github.com/nvim-neorocks/rocks/pull/226/commits/1259af214a744b698d5c9bdec7efdea04be156cc


[Feature]: refactor the action naming, Closes #209

🎯 Aim
Solve #209, and to give @Adam-it a PR as B-day present 🥳 🎈
📷 Result

✅ What was done

[ ] Didn't removed 'Current' from CliActions.ts ==> Don't know if you want me te remove 'Current' from there too? 🤔
[X] Removed 'Current' in README.md
[X] Removed 'Current' in tasks-and-actions.md
[X] Removed 'Current' in CommandPanel.ts

🔗 Related issue
Closes: #209

Awesome 🤩
Best present 🎁 ever 😍


update p5js.org/examples Hello P5 section to ES6

This will involve updating all examples in src/data/examples/en, src/data/examples/es, and src/data/examples/zh-Hans folders.
As a step forward in the transition to ES6 all of the examples on https://p5js.org/examples should be updated to use ES6 standard. This will often mean simply switching 'var' to 'let' or in some cases using es6 classes where applicable.
There are tons of resources online for learning about ES6. Here is an interactive guide that covers the biggest features.

resolved with https://github.com/processing/p5.js-website/pull/345


feat(ViewCompiler): enable compiling strings

Untested. Written in GH editor.

I wasn't abel to merge this since it was from a while back. However, I did get the fix in. Not sure why this didn't get in earlier. My apologies.

Any background on how to begin using this fix? Just trying to catch up!

It's not released yet. But basically, the compiler will take a string and return a view factory.

Oh great to check out! Looking forward to the release :) :+1:


Remove user dependencies to match with the readme instructions

Remove ios/Pods folder  and add it to .gitingnore
Push schemas to shared folder
Remove from ios/allprojects.xcworspace the folder xcuserdata and add it to git ignore
Add require('crypto') on shim

@Franpastoragusti Pod install seems to undo the version changes included in this PR, is that expected?


nixos/initrd-network-ssh: fix test

Motivation for this change
The test relied on moving initrd secrets from the store into the
initrd which was fine here as it's only an integration test and not a
production environment.
However, this broke in 20.09 when support for this was dropped[1]. To make
sure that the snakeoil key used as hostkey for sshd here actually gets
copied into the VM, I added a small script for this that takes care of
this process while building the initial ramdisk.
[1] d930466b7728e5515991cb73c060fc3f32bdc001
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[x] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

Hm, does this relate to #91744?

The problem I have with #91744 is that I don't want to touch the initrd-ssh-module right now as the current behavior is (from my PoV at least) rather unintuitive and I'm too afraid to change something there and probably causing further breakage.
I filed this PR since I wrote a similar testcase for a personal pet-project where I encountered the same issue, so I figured that it would make sense to fix this test as well. Until we have a working solution everyone agrees on, it would make sense IMHO to use this (temporary) fix to make sure that the current functionality works fine and we don't introduce some accidental regressions.

@GrahamcOfBorg test initrd-network-ssh

@emilazy what do you think? :)

Ported to 20.09 as 3090f4def1af5c14ec0e5e0395f5ea8b2fe2d7a6.

This is probably related to https://github.com/NixOS/nixpkgs/pull/99618 where I was trying to provide a mechanism to properly do it during bootloader install time (as that allows you to generate the key on the server/during install/…).


typo in tutorial

📚 The doc issue
in this tutorial https://pytorch.org/audio/stable/tutorials/audio_resampling_tutorial.html
there's a typo in https://pytorch.org/audio/stable/tutorials/audio_resampling_tutorial.html#performance-benchmarking

Suggest a potential alternative/fix
No response

Hi @nouranali, thanks for posting the issue. It will be fixed in #3212.


"Wallet timestamp" should be renamed to "wallet date"

User @crwatkins noted with surprise that the wallet timestamp did not change after a few hours. Since a timestamp is normally associated with an instance in time that changes on each refresh a better name for the timestamp field would be "wallet date" which may be more accessible to users and provide a better indication of its purpose.

Wallet date would be a bit confusing because there are other BIP32 based wallets (e.g. LightHouse) where their 'wallet creation date' is an actual date. Calling this field 'wallet date' suggests you could type in a date, which you cannot.
How about 'date stamp' to suggest that it is encoded (i.e. a 'stamp') and date related (hence does not change so quickly ?

As a user, I don't know what the timestamp is for.   I don't know why I wrote it down.  I don't know where I would use it.  I can't parse the numbers to translate to a date for pure information sake.

That's kind of the point.
We JUST want you to write it down.
Here is some information: just write it down.
By trying to explain exactly what it is, what the encoding is etc we dilute considerably what the primary message is, which is: Just write it down.

Perhaps an accompanying note: "The date stamp makes wallet restore operations faster in MultiBit HD. Please record it alonside your wallet words now."

I have renamed timestamp to datestamp.
Also added explanatory sentence on wallet creation screen.
Screenshot:

Awaiting review and closing

If screenshots aren't working, check that you're not running NoScript, or that you've enabled all the GitHub scripts. Should be a simple drag/drop operation on Mac.

Could you have another crack at getting a screenshot here to assist third-party review?

Looks good, apart from one nit: "Your wallet words protects all your bitcoins" is a hold over from our previous use of seed phrase, perhaps a quick update to "Your wallet words protect all your bitcoins".
Paging @crwatkins to review the screenshot :-)

This screenshot definitely addresses all the concerns I provided.  For newbies, instead of "protects all your bitcoins" which is a little abstract, perhaps "allows you to restore your wallet if..." would be more informative.  Again, this is fine as-is.

We did consider the "Allows you to restore your wallet" approach in an earlier iteration but it made the screen rather wordy and user testing indicated that most people didn't read the screen anyway.

Looks like I can close this now.

Agreed.


Silent install of playwright dotnet

How to do silent install of playwright.
This is the code am using
var exitCode = Program.Main(new[] { "install", "--with-deps", "chromium" });
Whenever this runs, it shows command prompt and i donot want this popup

Please re-file with clear reproduction steps and follow the bug template, thanks for your understanding!


Cannot Switch To PHP 8.1

Describe The Bug
I cannot switch to PHP 8.1.
PHP Versions
Upgrading from PHP 8.0 to PHP 8.1.
To Reproduce

Open Terminal
Type: php -v
Output: PHP 8.0.25
Type: brew link --overwrite --force<EMAIL_ADDRESS>Restart Terminal
Type: php -v
Output: PHP 8.0.25

Expected Behavior
PHP should switch to version 8.1.
Screenshots/Logs

Please remove<EMAIL_ADDRESS>and<EMAIL_ADDRESS>from your PATH. The only locations you need are /usr/local/bin and /usr/local/sbin which are there in your PATH and brew links the PHP version in those locations.


Additional insert of empty <div> tag is throwing off my CSS element sizing.

Hey all,  I have a TransitionChild that contains a <div> tag with a class something downs the line of class="relative flex-1 flex flex-col max-w-xs w-full pt-5 pb-4 bg-purple-700".  However, when I run this the sizing is all off.   I have found that in the inspection there is an additional <div> tag insterted before the body of a TransitionChild  with class= " ".  This additional div is throwing off my css and the resizing.  Is this the expected behaviour and I should work around this?  Or is this a bug that needs to get addressed?

Can you share the relevant code?

@rgossiaux Yes, working on it.

`
<button
type="button"
on:click={() => (isOpen = !isOpen)}
class="m-12 px-4 py-2 text-base font-medium leading-6 text-gray-700 transition duration-150 ease-in-out bg-white border border-gray-300 rounded-md shadow-sm hover:text-gray-500 focus:outline-none focus:border-blue-300 focus:shadow-outline-blue sm:text-sm sm:leading-5">
Toggle!

 (isOpen = false)}>

 (isOpen = false)}>
								Close sidebar

							{#each navigation as item}

									{item.name}

							{/each}

`

Thanks.
The empty div tags come from the transitions--each <Transition> and <TransitionChild> component renders exactly one div. In the React/Vue versions you have the ability to do as={Fragment} to not render anything and have the transition classes applied to the child component, but that's impossible to do directly in Svelte and would need some kind of more elaborate workaround (like exposing a prop getter or maybe for transitions an action which you could apply). At that point I'm not sure the increase in complexity is worth it.
The main downside is just when converting Tailwind UI snippets, I think. In cases where they use as={Fragment} you might need to pull some of the CSS classes up to the <Transition> / <TransitionChild>. In your case, try adding a class= prop to the problematic transition and duplicating or replacing some of the classes there.
Looking at your snippet, if the problematic element is the                <div class="relative flex-1 flex flex-col max-w-xs w-full pt-5 pb-4 bg-indigo-700">, you can just remove that div and move all of its classes to the parent <TransitionChild>.

@rgossiaux Cool, thanks!  I had the feeling that was gonna be the case but I wanted to check in before I committed.  Thanks again for your awesome work.


Some Language_ID in CLDF pics datasets have additional numbers

Hi,
Looking through data at https://github.com/cldf-datasets/apics/blob/master/cldf/values.csv#L1111 I discovered that some Language_IDs use additional numbers in the beginning or in the end of ID, for example 1201 for 20 in the 1110 line. I did not find anything about that in CLDF documentation, though this occurs several times in the data. Do not sure if it is an actual issue, considering data displayed correctly on the site, but just in case I decided to mention it here.

The language IDs are correct! For some varieties, the APiCS project also collected some data for sociolects. These sociolects typically have a four-digit ID, see for example https://github.com/cldf-datasets/apics/blob/master/cldf/languages.csv#L4-L6

The language IDs are correct! For some varieties, the APiCS project also collected some data for sociolects. These sociolects typically have a four-digit ID, see for example https://github.com/cldf-datasets/apics/blob/master/cldf/languages.csv#L4-L6

Thank a lot, sorry for bothering!

Thank a lot, sorry for bothering!

Btw. this is described here: https://github.com/cldf-datasets/apics/blob/f687a830a62aa5e16ad1b5d477e92d6307c10e6f/cldf/StructureDataset-metadata.json#L507-L508

Btw. this is described here: https://github.com/cldf-datasets/apics/blob/f687a830a62aa5e16ad1b5d477e92d6307c10e6f/cldf/StructureDataset-metadata.json#L507-L508


Incompatible with "scape and run: parasites" mod

When I install Valkyrie-0.2-Dev-8 alongside the latest 1.9.12 version of "scape and run: parasites"mod,the large parasites like Haunter, Bogle, Marauder, and other big parasites experience model corruption.

Hmm, I have fixed this I think, it might not be in Dev-8 though maybe in Dev-9 then

so when will Dev-9 comeout

so when will Dev-9 comeout

Working on it right now

sorry to bother but dev-10 still doesn't fix that

will it be fixed later

waiting for fix

I have no idea what could be causing this, could you install OptiFine, it will disable some part of Valkyrie which I think might be the culprit

yes after i installed optifine its model looks normal


Switching default renderer causes error for versions later than 4.0.28

Greetings,
We are encountering an issue where the example code from recipes.md for Switching the default renderer does not work on any version later than 4.0.28.
Is there a new way of switching the default renderer in versions later than 4.0.28?
TypeError
Cannot read property 'current' of undefined
eval
https://r9o9o.csb.app/node_modules/react-three-fiber/web.js:290:131
applyProps
https://r9o9o.csb.app/node_modules/react-three-fiber/web.js:276:35
createInstance
https://r9o9o.csb.app/node_modules/react-three-fiber/web.js:354:3

Working sandbox: https://codesandbox.io/s/react-three-fiber-custom-renderer-version-error-r9o9o?file=/src/index.js
To reproduce the error kindly change the version of react-three-fiber to any version later than 4.0.28.
Thanks

what's this for, or ... what's your goal?
in v5 we plan to rewrite that part, because the current implementation needs some extra data attached to the scene in order to function.

Thanks for the reply @drcmda.
Our specific use case is that in response to user input (clicking a button) we render a copy our the current scene and then extract the image data from the canvas so that the user can download the still image. For this use-case it is advantageous for us to be able to render a scene using render() as shown in the the sandbox so that we can also allow the user to provide input such as width, height, scale, etc, without altering the main scene being rendered.

the current implementation needs some extra data attached to the scene in order to function

Is it possible/do you have examples of how we can provide this extra data when calling render() in the current implementation? We would like to be able to upgrade to the latest 4.X version is possible.

you can do that in useFrame, there you have full control over how you render. you absolutely dont need to switch renderers for this. see https://github.com/react-spring/react-three-fiber/discussions/592

Thanks for the reference @drcmda. We can look for at useFrame, however we initially avoided using useFrame() as for our specific use-case we are leveraging invalidateFrameloop to render only a single frame, and our expecation was that useFrame would not be invoked if the render loop is not running.

well useframe will be called if you change props or invalidate, just like the internal one.

In the linked discussion you recommened using <Canvas onCreated={...} /> to access the state which seems to contain the gl reference. If I an following the logic correctly, is the thought that you would save off a ref (ref = state.gl) and then access ref.current.domElement when the user input occurs (clicks on the button)?

Ok... yeah, passing the state up to the parent in a callback prop and then saving that to a prop, which can then be accessed to call ref.current.gl.render(ref.current.scene, ref.current.camera) seem to work.


issue when deploy project

I'm encountering an issue when i'm  trying to deploy my project on host it's not work but on localehost it's work properlly
. and thanks

What is broken about it? I'm here checking the issues because for my app, on localhost when navigating to a subdomain it works fine, but when I build the project, I get a flash of the normal homepage before the subdomain homepage is rendered.
Do you use Nuxt Content perhaps?


Check all Help-Links

It seems that some help-links still direct to /dp/ - this should be fixed (remove /dp/)

https://github.com/cdskev/ginlo-ios/commit/a7fe44084b5a78cc9c04b74528d15f260f2e7151


overlarge class breaks alignment of tables.

See https://wicg.github.io/background-fetch/#events at wider widths.

See https://github.com/w3c/tr-design/issues/86 and https://github.com/w3c/tr-design/issues/104. :(

Fixed in Bikeshed by 01f91429, I'm gonna go PR tr-design now to fix it for everything else.


Issue.1111.master

@richbrowne
What issues does this address?
Fixes #1111
...
What's this change do?
Adds the template stdeb.cfg file back and adds the build Dockerfile and script for Ubuntu LTS 16.04
Where should the reviewer start?
On a machine with git and docker properly install, from the repository directory run:
./f5-openstack-agent-dist/scripts/package_agent.sh "ubuntu" "14.04"
./f5-openstack-agent-dist/scripts/package_agent.sh "ubuntu" "16.04"

Any background context?

On a clean clone of f5-openstack-agent in the 'mitaka' branch I get this:
$python ./f5-openstack-agent-dist/scripts/universal_truth.py
Traceback (most recent call last):
  File "./f5-openstack-agent-dist/scripts/universal_truth.py", line 63, in <module>
    main()
  File "./f5-openstack-agent-dist/scripts/universal_truth.py", line 57, in main
    edit_setups(cfg)
  File "./f5-openstack-agent-dist/scripts/universal_truth.py", line 50, in edit_setups
    construct_setups._construct_cfgs_from_json(cfg)
  File "/tmp/f5-openstack-agent/f5-openstack-agent-dist/scripts/construct_setups.py", line 69, in _construct_cfgs_from_json
    _construct_file(rpm.setup, rpm.reqs, rpm.fmt, rpm.start)
  File "/tmp/f5-openstack-agent/f5-openstack-agent-dist/scripts/construct_setups.py", line 182, in _construct_file
    name = str(req.name)
AttributeError: Requirement instance has no attribute 'name'
An error occurred: Requirement instance has no attribute 'name'

An no deb_dist/stdeb.cfg is written.
Let me know what the proper 'build' process should look like and we can get rid of the setup files as long as they are written properly.

The output of pip parse_request which is what is 'missing' the name attribute is a string:
Requirement.parse('f5-sdk==2.3.3')

John, what version of pip is in your system?  Are you building in Linux?  Maybe Ubuntu?

Clean Ubuntu host build.. 16.04.3. I'll upgrade pip and let you know..
$ cat /etc/lsb-release
DISTRIB_ID=Ubuntu
DISTRIB_RELEASE=16.04
DISTRIB_CODENAME=xenial
DISTRIB_DESCRIPTION="Ubuntu 16.04.3 LTS"
$ uname -a
Linux buildhost 4.4.0-75-generic #96-Ubuntu SMP Thu Apr 20 09:56:33 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux
$ pip --version
pip 7.1.2 from /usr/lib/python2.7/dist-packages (python 2.7)

I ran this on an Ubuntu Xenial system with pip version 8.1 and MacOS with
pip version 9.1
This script runs as a part of our travis build too on 14.04.  I would
definitely like to understand why this is failing for you.
I might change my travis build to Xenial and see how that works.
On Fri, Dec 1, 2017 at 4:25 AM, John Gruber<EMAIL_ADDRESS>wrote:

Clean Ubuntu host build.. 16.04.3. I'll upgrade pip and let you know..
$ cat /etc/lsb-release
DISTRIB_ID=Ubuntu
DISTRIB_RELEASE=16.04
DISTRIB_CODENAME=xenial
DISTRIB_DESCRIPTION="Ubuntu 16.04.3 LTS"
$ uname -a
Linux buildhost 4.4.0-75-generic #96
https://github.com/F5Networks/f5-openstack-agent/pull/96-Ubuntu SMP Thu
Apr 20 09:56:33 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux
$ pip --version
pip 7.1.2 from /usr/lib/python2.7/dist-packages (python 2.7)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/F5Networks/f5-openstack-agent/pull/1113#issuecomment-348471478,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AIVe0WLU26HotDah6poniXY8dewVP1OLks5s7-JDgaJpZM4Qvnbs
.


"express is not a function", when using express in server middleware

Environment

Operating System: Linux
Node Version:     v16.13.1
Nuxt Version:     2.16.0-27322574.c1d02ea3
Package Manager<EMAIL_ADDRESS>Bundler:          Webpack
User Config:      srcDir, head, publicRuntimeConfig, css, plugins, components, buildModules, vuetify, i18n, modules, axios, compilerOptions, build, watchers
Runtime Modules<EMAIL_ADDRESS>Build Modules:    pinia/nuxt<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>

Reproduction
https://codesandbox.io/s/nostalgic-waterfall-zb1pt?file=/package.json
Restart the server if needed.
Get the error:
ERROR [worker] express is not a function
Describe the bug
When trying to start a server with express in /server/middleware, I get the error.
Additional context
I try to move from @nuxt/composition-api to @nuxt/bridge.
My old setup used this piece of code (running nuxt as a middleware of express):
  const nuxt = await loadNuxt(isDev ? 'dev' : 'start');
  app.use(nuxt.render);

According to this remark: https://github.com/nuxt/framework/discussions/1451#discussioncomment-1548835 the best way to get the server working again is to run my express server as a middleware of nuxt). That is what I am trying to do.
Logs
No response

import express from "express"

@danielroe
Page not found

not solved after using import express from "express" Error : Cannot use import statement outside a module


molecules WIP

This first commit handles molecules in the linelist and reads in molecular partition functions.  More to come.
Minor points

I deleted your comment about storing the partition data in FITS files.  Upon reflection, I think it's better to stick with plain text to minimize dependencies.  LMK if you disagree.
In the partition function dictionary (and in other dicts in the future), molecules are stored without an ionization state.  I.e. instead of CO_I, it's just CO, even though C_I, C_II, C_III are also keys.  This is because (as far as I can tell) linelists don't have features of ionized molecules.  This shouldn't be a huge hassle to reverse later if we wish.

This commit includes a working solution to the moleq equations.
In order to get the working, I had to remove the logic that culls the list of species considered, so now all syntheses involve all elements and molecules.  This isn't as ridiculous as it sounds since getting the C I number density correct involves taking CO into account, which involves taking O into account, which involves taking MgO into account, etc.
One kind of bad thing I did was to truncate the arrays in atomic_data.jl to go only up to U, so that they would align with the Barklem data.  I can try to fix this before we merge if you think it's important.  I'm kind of split.
I moved saha_boltzman.jl to statmmech.jl because it contains a lot more stuff now. I  also got rid of saha and replaced it with better-designed (imo) saha_ion_weights.   I had to go in a tweak you continuum opacity tests in a couple places to get everything working.
I've also reduced the direct use of globals, possibly to zero.
Sorry this is kind of a monster PR.  What remains is writing some more tests, and calculating opacity from molecules.

This is now ready for review.


OpenShift node reboot

Hi,
After a reboot of the openshift-node's machine, should sdn be configured correctly ?
In my case it seems not.
A node that rebooted tries to contact a pod hosted on another node, and got no route to host :
[root@cm-chaos-openshift-rbox-node-fld6 ~]#  tracepath <IP_ADDRESS>
 1?: [LOCALHOST]                                         pmtu 1500
 1:  cm-chaos-openshift-rbox-node-fld6.figaro.amadeus.net 3006.666ms !H
     Resume: pmtu 1500

When I run debug.sh script, it says :
Node cm-chaos-openshift-rbox-node-fld6.figaro.amadeus.net: the IP in OpenShift (<IP_ADDRESS>) does not match DNS/hosts (<IP_ADDRESS>)
By the way the node is considered as ready in the master, pods are scheduled on it.
Any idea of what went wrong ?
Thanks !

When I run debug.sh script, it says :
Node cm-chaos-openshift-rbox-node-fld6.figaro.amadeus.net: the IP in OpenShift (<IP_ADDRESS>) does not match DNS/hosts (<IP_ADDRESS>)

So where is that coming from?

<IP_ADDRESS> is the IP of the docker0 interface on the openshift master, so this message is weird

I did more tests on 5 openshift nodes:

4 of them seem to have a broken sdn after reboot. debug.sh says the IP is not matching
1 node's openshift-sdn seems to be working after a first reboot. Then it's broken at the second reboot. For this node (cm-chaos-openshift-rbox-node-868e.figaro.amadeus.net), debug.sh does not complain about IP.
debug.sh's output :

[root@openshift-master ~]# ./debug.sh
Analyzing master
Node cm-chaos-openshift-rbox-node-9y91.figaro.amadeus.net: the IP in OpenShift (<IP_ADDRESS>) does not match DNS/hosts (<IP_ADDRESS>)
Node cm-chaos-openshift-rbox-node-fld6.figaro.amadeus.net: the IP in OpenShift (<IP_ADDRESS>) does not match DNS/hosts (<IP_ADDRESS>)
Node cm-chaos-openshift-rbox-node-scg9.figaro.amadeus.net: the IP in OpenShift (<IP_ADDRESS>) does not match DNS/hosts (<IP_ADDRESS>)
Node cm-chaos-openshift-rbox-node-wdxb.figaro.amadeus.net: the IP in OpenShift (<IP_ADDRESS>) does not match DNS/hosts (<IP_ADDRESS>)

Analyzing cm-chaos-openshift-rbox-node-868e.figaro.amadeus.net (<IP_ADDRESS>)

Analyzing cm-chaos-openshift-rbox-node-9y91.figaro.amadeus.net (<IP_ADDRESS>)
Could not find node name in /etc/origin/master/master-config.yaml

Analyzing cm-chaos-openshift-rbox-node-fld6.figaro.amadeus.net (<IP_ADDRESS>)
Could not find node name in /etc/origin/master/master-config.yaml

Analyzing cm-chaos-openshift-rbox-node-scg9.figaro.amadeus.net (<IP_ADDRESS>)
Could not find node name in /etc/origin/master/master-config.yaml

Analyzing cm-chaos-openshift-rbox-node-wdxb.figaro.amadeus.net (<IP_ADDRESS>)
Could not find node name in /etc/origin/master/master-config.yaml

So I can collect logs :
openshift-sdn-debug.zip

Root cause found by @david-martin and Jawed Khelil :
At reboot time, the facter 2.4's  ipaddress 's value is docker0 interface's IP.
Problem should be solved by upgrading facter to 3.x
Closing it.

@menren I did what now?
This thread escapes me completely

A certain Jose David Martin of Red Hat helped me to solve this issue. Sorry if it's not you. It was a blind guess ...

Possibly this David Martin https://github.com/jdnieto


onPressIn doesn't work if key has been changed

onPressIn doesn't work every other touch.
import React, { Component } from 'react';
import {AppRegistry, TouchableWithoutFeedback, Text, View} from 'react-native';

export default class test extends Component {
	constructor(props) {
		super(props);
		this.state = {index: 1};
		this.inc = this.inc.bind(this);
	}
	inc() {
		this.setState({index: (this.state.index + 1)});
	}
	render() {
		return (
		<TouchableWithoutFeedback onPressIn={this.inc} key={this.state.index}>
			<View>
				<Text>Index {this.state.index}</Text>
			</View>
		 </TouchableWithoutFeedback>
		)
	}
}

AppRegistry.registerComponent('test', () => test);

If you remove key from
<TouchableWithoutFeedback onPressIn={this.inc} key={this.state.index}>

or replace onPressIn with onPress it would work every touch.

React Native version: 0.41
Platform: Android
Operating System: Windows

There might be a bug in RN, but this example looks like it's intentionally created to make things fail. In what real life scenario, does key have to change in the middle of a press?

@hey99xx For example, I want to use object id as a key and I want to show new objects onPressIn.

Hi there! This issue is being closed because it has been inactive for a while. Maybe the issue has been fixed in a recent release, or perhaps it is not affecting a lot of people. Either way, we're automatically closing issues after a period of inactivity. Please do not take it personally!
If you think this issue should definitely remain open, please let us know. The following information is helpful when it comes to determining if the issue should be re-opened:

Does the issue still reproduce on the latest release candidate? Post a comment with the version you tested.
If so, is there any information missing from the bug report? Post a comment with all the information required by the issue template.
Is there a pull request that addresses this issue? Post a comment with the PR number so we can follow up.

If you would like to work on a patch to fix the issue, contributions are very welcome! Read through the contribution guide, and feel free to hop into #react-native if you need help planning your contribution.


⚠ Hartman Foundation has degraded performance

In 86027b4, Hartman Foundation (https://gordonhartman.com/) experienced degraded performance:

HTTP code: 200
Response time: 2791 ms

Resolved: Hartman Foundation performance has improved in 12f4e3d.

Resolved: Hartman Foundation performance has improved in 12f4e3d.


Where does cflint-ui come from?

Hi,
I wondered where cflint-ui.bat might come from.
I got the impression it's being generated by a certain call to maven
I tried mvn -e -X package appassembler:assemble and got:
[ERROR] Failed to execute goal org.codehaus.mojo:appassembler-maven-plugin:1.10:assemble (default-cli) on project CFLint: The parameters 'programs' for goal org.codehaus.mojo:appassembler-maven-plugin:1.10:assemble are missing or invalid -> [Help 1]
org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute goal org.codehaus.mojo:appassembler-maven-plugin:1.10:assemble (default-cli) on project CFLint: The parameters 'programs' for goal org.codehaus.mojo:appassembler-maven-plugin:1.10:assemble are missing or invalid
        at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:220)
        at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:153)
        at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:145)
        at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:116)
        at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:80)
        at org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build(SingleThreadedBuilder.java:51)
        at org.apache.maven.lifecycle.internal.LifecycleStarter.execute(LifecycleStarter.java:128)
        at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:307)
        at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:193)
        at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:106)
        at org.apache.maven.cli.MavenCli.execute(MavenCli.java:862)
        at org.apache.maven.cli.MavenCli.doMain(MavenCli.java:286)
        at org.apache.maven.cli.MavenCli.main(MavenCli.java:197)
        at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
        at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
        at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
        at java.lang.reflect.Method.invoke(Method.java:497)
        at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced(Launcher.java:289)
        at org.codehaus.plexus.classworlds.launcher.Launcher.launch(Launcher.java:229)
        at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode(Launcher.java:415)
        at org.codehaus.plexus.classworlds.launcher.Launcher.main(Launcher.java:356)
Caused by: org.apache.maven.plugin.PluginParameterException: The parameters 'programs' for goal org.codehaus.mojo:appassembler-maven-plugin:1.10:assemble are missing or invalid
        at org.apache.maven.plugin.internal.DefaultMavenPluginManager.populatePluginFields(DefaultMavenPluginManager.java:668)
        at org.apache.maven.plugin.internal.DefaultMavenPluginManager.getConfiguredMojo(DefaultMavenPluginManager.java:621)
        at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:121)
        at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:208)
        ... 20 more

Compilation of the classes and running tests seems to work. There is a file target\classes\com\cflint\main\CFLintMain.class.
Best,
Bernhard

the ui bat comes from the pom (lines 254-161)
mvn clean package
should work for you
I'm not a maven expert, I can't speak to the your choice of parms.
The steps we use to deploy a release are in the comment at the bottom of the pom. (jerronjames set it up)

I modified line 243 to read
package
and called mvn clean package -P deploy
That worked.

Any idea what is different about your case?  Should we make that change to
the CFLint source?
On Thu, Nov 17, 2016 at 4:13 AM, Bernhard Döbler<EMAIL_ADDRESS>wrote:

I modified line 243 to read
package
and called mvn clean package -P deploy
That worked.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/cflint/CFLint/issues/212#issuecomment-261193991, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AFtZu2-g4h_NDwkEzAvH6mehQ8_dXtpPks5q_BqzgaJpZM4Kzk-7
.

I'm not experienced in mvn, sorry. Generation of runnable files during the packaging phase just seemed more right to me that during the integration-testing phase. Was a try that worked.

changed the pom.  Thanks!


Set this-command in selectrum-repeat to selectrum-last-command

Closes #438.

Thanks, for your contribution!


consul-template: 0.36.0 -> 0.37.1

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://repology.org/project/consul-template/versions.
meta.description for consul-template is: Generic template rendering and notifications with Consul
meta.homepage for consul-template is: https://github.com/hashicorp/consul-template/
Updates performed

Golang update

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact
Checks done

built on NixOS
Warning: a test defined in passthru.tests did not pass
found 0.37.0 with grep in /nix/store/fx3vs87kynp55g7zjk97v4pqdhmf6s64-consul-template-0.37.0
found 0.37.0 in filename of file in /nix/store/fx3vs87kynp55g7zjk97v4pqdhmf6s64-consul-template-0.37.0

Rebuild report (if merged into master) (click to expand)

1 total rebuild path(s)

1 package rebuild(s)

First fifty rebuilds by attrpath
consul-template

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/fx3vs87kynp55g7zjk97v4pqdhmf6s64-consul-template-0.37.0 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A consul-template https://github.com/r-ryantm/nixpkgs/archive/c2e7248c6a57a62a6befc2156bb47ab8c751b76a.tar.gz

Or:
nix build github:r-ryantm/nixpkgs/c2e7248c6a57a62a6befc2156bb47ab8c751b76a#consul-template

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/fx3vs87kynp55g7zjk97v4pqdhmf6s64-consul-template-0.37.0
ls -la /nix/store/fx3vs87kynp55g7zjk97v4pqdhmf6s64-consul-template-0.37.0/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

1 package built:

consul-template

Maintainer pings
cc @cpcloud @pradeepchhetri for testing.

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/hashicorp/consul-template/releases.
meta.description for consul-template is: Generic template rendering and notifications with Consul
meta.homepage for consul-template is: https://github.com/hashicorp/consul-template/
Updates performed

Golang update

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact
Checks done

built on NixOS
Warning: a test defined in passthru.tests did not pass
found 0.37.1 with grep in /nix/store/iz8if2909pvwl32a85w53mmb5r4xjx8i-consul-template-0.37.1
found 0.37.1 in filename of file in /nix/store/iz8if2909pvwl32a85w53mmb5r4xjx8i-consul-template-0.37.1

Rebuild report (if merged into master) (click to expand)

1 total rebuild path(s)

1 package rebuild(s)

First fifty rebuilds by attrpath
consul-template

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/iz8if2909pvwl32a85w53mmb5r4xjx8i-consul-template-0.37.1 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A consul-template https://github.com/r-ryantm/nixpkgs/archive/9e633d53f3cb3030588012187ed12633cc60f9c7.tar.gz

Or:
nix build github:r-ryantm/nixpkgs/9e633d53f3cb3030588012187ed12633cc60f9c7#consul-template

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/iz8if2909pvwl32a85w53mmb5r4xjx8i-consul-template-0.37.1
ls -la /nix/store/iz8if2909pvwl32a85w53mmb5r4xjx8i-consul-template-0.37.1/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

1 package built:

consul-template

Maintainer pings
cc @cpcloud @pradeepchhetri for testing.


Document available lua functions in the README.md

Currently the keybind examples make use of available <cmd> style calls. Seeing as we now have access to vim.keymap.set, I think it would be useful to also detail the names of the functions made available by require('trouble') and what args they may take. (For instance: require('trouble').toggle() and require('trouble').toggle('workspace_diagnositcs'))

Development on the main branch is EOL.
Trouble has been rewritten and will be merged in main soon.
This issue/feature either no longer exists or has been implemented on dev.
For more info, see https://github.com/folke/trouble.nvim/tree/dev


[FEATURE REQUEST] Support for MacOS

Is it possible to make support for MacOS?

Blocked by https://github.com/flutter/flutter/issues/41725

Hi @sarbagyastha This isn't blocked anymore. Will you be working on it? 🙏

I believe this is now blocked on flutter/flutter#153773

Is there a way around not setting the background color for now but still show embedded youtube in macos flutter?

I tried comment out the call to set background https://github.com/at15/youtube_player_flutter/commit/2c8460cd4139af13048c5eb1b365e4525508d6ee, but I don't see any updates from controller's stream. I guess there is more issue than just setting background.


Last line not getting tokenized after upgrade of highlight.js

Describe the issue/behavior that seems buggy

The last line of code does not get highlighted correctly.
The issue persists in at least Java and Python, I suspect the issue will appear in any code.
I suspect the API has changed since the code I'm working with was written.
Sample Code or Instructions to Reproduce

let tokenized = hljs.highlight(codeContent, {language}).value;
this.note = this.note.replace('{content}', '
' + tokenized + '
');

The end of note later looks like this:
print("Hallo Welt")
x = input("Mach mal")
doSomething()

With everything except the last line being formatted.
Expected behavior

The last line should be parsed into at least one span.
Additional context

I am updating a typescript program which used highlight.js 9.10.0 before and now uses 11.6.0.
I looked in the breaking changes but could not figure out what was going wrong.

The last line should be parsed into at least one span.

Why?

Because this:

is what the input is.
Don't you agree that the last line should be parsed?

No. Many grammars don't highlight function calls.  Try different content, like adding a keyword.

Tried it, it was indeed as you said. Is there any way I could add some flag/span to apply custom rendering for these cases?
My extension currently works by replacing stuff in the tags, but the function calls don't have any tags.
The other option would be to look for anything not formatted by spans and create a custom default span.

There is no guarantee of highlighting on every line, it just depends on the source code.
It's not clear to me at all what you're trying to accomplish or what your plugin hopes to do.

My plugin exports code to Microsoft OneNote with highlighting.
This is what is currently being sent to OneNote:

The line has nether the correct font nor the correct size.
My goal would be to have a span around everything, so I could set those values by string.replace() as I do for all the other spans.
The only way I can think of right now is having a regex that finds /w between a closing and an opening span, but not between an opening and a closing span. If not every line gets a span, that is probably what I will do.
I will close this issue since the behavior is already correct.

This actually worked perfectly, thank you for the answer and the advice.


Set initializers should work for bython

import os

def main(){
  c= {1,3}
  print('hello')
  print({'A':1,
        'b':2}
        )
}
main()

Fails with
  File "python_main.py", line 4
    c=:1,3
    ^
IndentationError: expected an indented block

Try ending your statements with semicolons.


Use local images

Hi there!
Is there something that needs to be done to load images from the public folder?
I've been trying but I'm not able to get them loaded. It always throws a 404 not found.

+1 Also images cannot be resolved when import

Hi,
I added the FAQ section to the readme, which includes a guide on how to load images :smile:
https://github.com/xxczaki/styled-react-boilerplate#how-to-add--use-static-assets-ex-images


Can't install with the project inside the folder have a non breaking space in name

Describe the bug
Can't install with the project inside the folder have a non breaking space in name
To Reproduce

Give the project on the folder like: ~/Example Folder/my-project
Install jest-preview via command line npm install --save jest-preview

Expected behavior
Can install without error
Screenshots

Environment (please complete the following information)

OS: MacOS 11.6.1
Jest version: 0.1.6

Thank @tinhvqbk. Confirmed it's a bug. I will fix this in the next version

@tinhvqbk This bug is fixed in https://www.npmjs.com/package/jest-preview/v/0.1.7

@all-contributors please add @tinhvqbk for bug


[website] Update MUI X license redirect link

Fix https://github.com/mui/material-ui/blob/6eabacaf0e79a52f65f1147bbf4b835c79d4f4d1/docs/public/_redirects#L26 that points to the wrong location after:
https://github.com/mui/mui-store/pull/139
Add a new code redirection for the LICENSE files: https://unpkg.com/<EMAIL_ADDRESS>

@joserodolfofreitas I did a new iteration on the PR. I believe that we are good at this point. Happy to answer any questions on why each change.

Thanks @joserodolfofreitas for the iteration, I'm taking off this in #32515 and https://github.com/mui/mui-x/pull/4711, among a number of other problems.


[docs] Non-enrolled Apple Developer account code signing guide

MacOS code signing documentation mentions the following:

Code signing on macOS requries an Apple Developer account which is either paid (99$ per year) or on the free plan.

However, further down in "Downloading the certificate" section the link to Certificates, IDs & Profiles page isn't accessible to non-enrolled accounts making it impossible to download the certificate.
Is there an alternative guide for free (non-enrolled) accounts, or should only the enrolled account be required to code sign the application?

You can self-sign the app which ist free, but also fairly useless. It makes aarch64 Apps run via right click like x86 Apps though. For self signing iirc you don't need any Account though so i'm not sure what the docs are trying to say.
Maybe it was more in the spirit of "there are 2 types but you need the paid one" idk