Merge simulate and simulate_async?

Following the issues #355 and #356, we could easily merge the simulate and simulate_async methods into one by using the task object output. In general, both methods are relatively the same, with the exception that we are "logging" and holding in the sync.
The main reason we had not done it before, was due to a difference in inputs (namely, we did not have output_dir for the async) and a difference in outputs (output_dir and task_id).  With a task object, we could immediately have everything concerning a task, including an attribute for the output path. When doing task.download() it would be immediate to that output. Furthermore, adding the task info
The only problem is that we would discard obtaining the visuals object at the end of simulate method.
Wdyt?

I think the plan is for simulate to return an output object and simulate_async to return a task object, so I don't see how these can be merged (based on the argument that inputs and outputs should be the same).
Returning a task object in simulate would require importing the output class in each scenario, e.g.
from inductiva... import DamBreak
from inductiva... import DamBreakOutput

scenario = DamBreak(...)
task = scenario.simulate(...)
task.downlaod_output()
output = DamBreakOutput("output_dir")

I think the plan is for simulate to return an output object and simulate_async to return a task object, so I don't see how these can be merged (based on the argument that inputs and outputs should be the same).
Returning a task object in simulate would require importing the output class in each scenario, e.g.
from inductiva... import DamBreak
from inductiva... import DamBreakOutput

scenario = DamBreak(...)
task = scenario.simulate(...)
task.downlaod_output()
output = DamBreakOutput("output_dir")

You would not need to download the output, the simulate would do it. However, I agree with the import of the output class.
Notice that most meaningful simulations will need the async method anyway, so the usual workflow will be to always import the output anyway.

You would not need to download the output, the simulate would do it.

Notice that most meaningful simulations will need the async method anyway, so the usual workflow will be to always import the output anyway.

Good point. I'm ok with importing the output.
I am also ok with merging the methods, as long as it is still explicit that we are running sync/async simulations. Were you thinking of adding a parameter async=True|False to simulate?

I like the idea parameter async=True|False! That's what I thought too.
Regarding this example, I have some comments:
from inductiva... import DamBreak
from inductiva... import DamBreakOutput

scenario = DamBreak(...)
task = scenario.simulate(...)
task.downlaod_output()
output = DamBreakOutput("output_dir")

For gromacs I just want to download two specific files (there are some heavy files that are not necessary for the visualization), and I thought that I would define this inside the scenario.simulate and the simulationOutuput would work with just the downloaded files. Having the simulate return the task would mean that I would have to do.
scenario = ProteinSovation(...)
task = scenario.simulate(...)
task.downlaod_output_files(files=["trajectory.xtc", "protein.pdb"])
output = GromacsOutput("output_dir")

Having to define the filenames by the user doesn't take out the "magic" of the user experience?

Having to define the filenames by the user doesn't take out the "magic" of the user experience?

I don't think it does. I'd say this is an intermediate/advanced feature that intermediate/advanced users may find useful, so the effort of listing file names pays off!

I like the idea parameter async=True|False! That's what I thought too.
Regarding this example, I have some comments:
from inductiva... import DamBreak
from inductiva... import DamBreakOutput

scenario = DamBreak(...)
task = scenario.simulate(...)
task.downlaod_output()
output = DamBreakOutput("output_dir")

For gromacs I just want to download two specific files (there are some heavy files that are not necessary for the visualization), and I thought that I would define this inside the scenario.simulate and the simulationOutuput would work with just the downloaded files. Having the simulate return the task would mean that I would have to do:
scenario = ProteinSovation(...)
task = scenario.simulate(...)
task.downlaod_output_files(files=["trajectory.xtc", "protein.pdb"])
output = GromacsOutput("output_dir")

Having to define the filenames by the user doesn't take out the "magic" of the user experience?

Again, remark that you want have to perform the download_output_files with the simulate sync, this step will keep being automatic since it is done in the backend. I agree with Fabio, this is an advanced feature that users and us will find very useful. I will add a comment on the specific issue for those files, since I still want to understand this feature.

Thanks for this Ivan, a few comments:
In both sync and async:

Why do we need a output_dir="output_folder" for a scenario?
It shouldn't be needed if we are returning a scenario output object, right? If the user wants to download the whole file outputs, that would be done later, with the method downlaod_output_files("output_dir")

In the async version, it does not make sense to ask the user to explicetely construct the scenario output based on an output folder, that is too low level.
I will edit the colab to specify what I think is a clean interface.

In this manner, you would have two different types of outputs depending on if the simulation is sync or async. That was the motive we had to choose the split.

Thanks for this Ivan, a few comments:
In both sync and async:

Why do we need a output_dir="output_folder" for a scenario?
It shouldn't be needed if we are returning a scenario output object, right? If the user wants to download the whole file outputs, that would be done later, with the method downlaod_output_files("output_dir")

In the async version, it does not make sense to ask the user to explicetely construct the scenario output based on an output folder, that is too low level.
I will edit the colab to specify what I think is a clean interface.

The scenario output object needs the files downloaded to run. Would you suggest downloading only the specific files for each output function or assume the default? Currently, it can work without passing any output_dir, it is not obligatory, but users actually know in this way the folder where it went.
I like your suggestion to use output=task.get_output and move from there!
I understand your workflow and fits perfectly with what I had in mind! I will implement it!

See the example of Ray and their remote tasks:
https://docs.ray.io/en/latest/ray-core/walkthrough.html#running-a-task
When you annotate a function to run remotely (async), it no longer returns the original type, but it returns a task_id that allows you to do ray.get(task_id) which will return whatever was the original type returned by the function.  The goal is todo something similar, but we can chose to return a task object instead of a task_id, and instead of doing inductiva.get(task_id) we can do task.get_output()...
Whether we have two functions simulate, and simulate_async, or one function simulate with an argument async=True, is not such a big issue, I am ok with both, the important is that when you run async, you only need to do a very simple blocking call to get back the results, and you should be EXACTLY in the same situation as with the blocking call. The problem with the code you were suggesting, is that it required the user to talk about downloading files, to some directory, and then it needed to known which constructor to call (like WindTunnelOutput or something) to get back the output. That can not happen....

Thank you @hpenedones for the feedback.

Why do we need a output_dir="output_folder" for a scenario?

We need it for a scenario's simulate method to be able to control where output files are written to, since so far we have been assuming that simulations run synchronously get their output downloaded at completion.


[FEATURE] Enable userspace verifier by default

Is your feature request related to a problem? Please describe.

The PREVAIL should be enable by default, and:

Add runtime option to bypass the userspace verifier
Add prompt to let user using kernel verifier when the userspace verifer is not pass

Describe the solution you'd like

It lacks a lot of features

Yes. So when there is error occur in userspace verifier, we should treat it as a warning.
If the error is due to unsupport features, there should be a warning and default operation is just continue, and tell user how to use kernel verifier if they want.
If the error sounds like a realy bug, it should block it but also tell user how to bypass it or use the kernel verifier.
We maybe can have 3 mode:

BPFTIME_VERIFY_STRICT: all verifier wanring are errors, you should pass either kernel or userspace verifier.
BPFTIME_VERIFY_WARNING: userspace verifier are warning, kernel verifier are error.
BPFTIME_NO_VERIFY: no verify.

Yes. So when there is error occur in userspace verifier, we should treat it as a warning.
If the error is due to unsupport features, there should be a warning and default operation is just continue, and tell user how to use kernel verifier if they want. If the error sounds like a realy bug, it should block it but also tell user how to bypass it or use the kernel verifier.
We maybe can have 3 mode:

BPFTIME_VERIFY_STRICT: all verifier wanring are errors, you should pass either kernel or userspace verifier.
BPFTIME_VERIFY_WARNING: userspace verifier are warning, kernel verifier are error.
BPFTIME_NO_VERIFY: no verify.

But we even don't know which features are supported by ebpf-verifier, making it hard to distinguish whether it's a lack of feature or bug

Ok, so maybe just 3 levels? The default level is 2.

Ok, so maybe just 3 levels? The default level is verify warning

Ok, so maybe just 3 levels? The default level is verify warning

Agree


Rna transcription rewrite

Add a small bioengineering story as the pretext for the exercise. I didn't change the actual instructions.

ChatGPT notes
Imagine that you work for a bioengineering company that specializes in developing therapeutic solutions using RNA interference (RNAi). Your team has just received a new project that involves designing RNA sequences that can target and degrade specific disease-causing genes in a patient's cells. To do this, you need to be able to generate the RNA complement of a given DNA sequence.
Your task is to write a program that takes a DNA sequence as input and outputs its RNA complement. The RNA complement is formed by replacing each occurrence of the nucleotide "T" in the DNA sequence with "U". Your program should be able to handle DNA sequences of any length and should output the RNA complement in the same order as the input sequence. Make sure to test your program with different DNA sequences and verify that the output is correct. Good luck!
Instructions:
Your task is to write a program that takes a DNA sequence as input and generates its RNA complement as output. The program should replace all occurrences of the nucleotide "T" with "U" to generate the RNA complement. The program should handle DNA sequences of any length and output the RNA complement in the same order as the input sequence. Make sure to thoroughly test your program with different DNA sequences to ensure that it is functioning correctly.

note to self: Look at the test files for examples


fix: fix typo in notebook and a missing metric name

Description
Thank you for opening a Pull Request!
Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

[X] Follow the CONTRIBUTING Guide.
[X] You are listed as the author in your notebook or README file.

[X] Your account is listed in CODEOWNERS for the file(s).

[X] Make your Pull Request title in the https://www.conventionalcommits.org/ specification.
[X] Ensure the tests and linter pass (Run nox -s format from the repository root to format).
[X] Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

@jsondai Not sure how these were missed in the initial PR, but can you fix the spelling errors and the Link issues?


UI improvements

[x] where do I define the boilerplate for my DAC?
[ ] did not found how to set max tokens
[ ] default 2 decimals
[ ] "Number of votes per token" vs "custodians voted per token"
[ ] change colors in dacfactory as a preview
[ ] change favicon
[ ] on error page, no link works anymore
[ ] move the pay button to somewhere easier to find

Where do I define the boilerplate for my DAC?

There is no boilerplate for hosted dacs


Cannot GET /main.js

I get 404 on the /main.js when running this project untouched via npm run hot-dev-server. Thoughts on where to start?
So, it seems it is serving it up via /_assets/main.js but the file dev-server-public/index.html refers to it as main.js in the current directory?

Let me check that out, I rememer getting a similar error at some point

@filmackay Ok I think Ifound the issue, the port 2992 is only used by webpack for distributing assets.
You have to open 2 terminals one with npm run hot-dev-server and the other one with npm start. Then hit localhost:3000 in the browser! The file in dev-server-public must be a leftover from the refactor!

(whoop the issue got auto closed, feel free to close if it's resolved)

Ok thanks - can you clarify how the http servers work know this example; it has confused me a bit thus far:
Eg.
3000: koa, root index, mongoose, controller back end
2992: express, webpack assets
??

With this fix, my http://localhost:3000/ returns:
Version - 0.4.2 #020bf93 - Changelog

The npm run hot-dev-server is really just the webpack dev-server which serves assets by modules and does the hot-reload
Where npm start runs the koa app! In prod you'd run only the koa-app with the assets minified

Yeah, the only confusing part is the wrapper for the front-end (index.html) comes from the back end. Convenient, I agree, but you could produce this front the front-end server / built files (?)

I guess that could be done, I'll try to look at it if I get some time!


"Try" functionality response handling issues

In one case on RapiDoc I see Response Status: NetworkError when attempting to fetch resource. (CORS or Network Issue) but when I copy the curl script from the curl tab and run it on my terminal the endpoint returned "status No Data found, count 0."
In another case where RapiDoc showed Response Status: NetworkError when attempting to fetch resource. (CORS or Network Issue) I pasted the curl from the curl tab into my terminal and the response was, {"status":"Error","message":"field1, field2 or field3 must be provided"}
Is something amiss in my spec? Or is this a feature request to print more detail from incoming messaging from target? Something else?
Thanks again for the great work. It's so cool.

most likely its coz, when ajax calls are made through browser it is treated as a separate origin (web-site) therefore the API server must allow cross-origin request for the API calls to be successful. curl on the other hand dont have this limitation as it is not executed on a web server
https://www.reddit.com/r/webdev/comments/6fmpjq/cors_browser_vs_curl/


How to use smaller frequencies (like hours)?

Hello!
I am trying to use PyPortfolioOpt in a cripto bot to enhance our portfolio optimization strategies. But all my ticker is collected in hour intervals (not days). The documentation leads to believe PyPortfolioOpt only works with daily data.
For cripto, i used (frequency = 24*365) in the expected_returns and risk_models methods, but the results are kind of weird.
The mean_historical_return worked fine (i think), but the CovarianceShrinkage(dataset, frequency=24*365).ledoit_wolf() gives a very strange matrix (cant believe there is no covariance)
       BTC       LTC       ETH      TUSD       XRP

BTC   5.390544  0.000000  0.000000  0.000000  0.000000
LTC   0.000000  5.390544  0.000000  0.000000  0.000000
ETH   0.000000  0.000000  5.390544  0.000000  0.000000
TUSD  0.000000  0.000000  0.000000  5.390544  0.000000
XRP   0.000000  0.000000  0.000000  0.000000  5.390544
The price data seems ok, although the cripto prices are very different in scale.
What i am doing wrong ?
Thanks in advance !

Hi @falgarcia,
Thanks for reaching out! There is definitely something wrong here. Here are some suggestions:

Try a different method for calculating the covariance matrix (e.g sample covariance) and see if that works
Use a frequency of 24. Then, the "annualised" covariance will actually be a "daily" covariance
Try downsampling, e.g taking every 24th row. This will turn your data into daily data.

If you are able to share a sample of your data as a csv, I think it'll be quite easy to debug this.
Cheers,
Robert

Thanks for the quick response!!! I have tried your sugestions.
For covariance matrix alternative methods:

CovarianceShrinkage.oracle_approximating(): worked (non zero matrix)
CovarianceShrinkage.shrunk_covariance(): worked (non zero matrix)
In fact, only CovarianceShrinkage.ledoit_wolf(shrinkage_target='constant_variance') resulted in the strange matrix. Using other shrinkage_target values worked (non zero matrix).

Using frequency of 24 didn't work so well. Gave me a lot of "pypfopt.exceptions.OptimizationError: Please check your objectives/constraints or use a different solver." regardless of the Covariance matrix used.
Downsampling to daily data worked, even with shrinkage_target='constant_variance'. But also resulted in a lot of "pypfopt.exceptions.OptimizationError" in data subsets (i use a rolling window to calculate portfolio allocations in backtesting).
The CSV files are attached!
data.zip

Hi @falgarcia,
I'm so sorry for the late reply – have had a hectic couple of weeks. Really appreciate the testing with other risk_models, and I'm glad that at least some of the suggestions worked :)
However, if you are curious, I figured out what the problem is. Ledoit Wolf constant variance works by shrinking covariances to the mean of asset variances. So I computed the hourly variances using df.pct_change().var() and I got this:
BTC     0.000047
LTC     0.000331
ETH     0.000310
TUSD    0.626944
XRP     0.000347
dtype: float64

TUSD has a variance way higher than everything else. This is what the time series looks like:
Because the TUSD has these strange spikes (data errors I think), it messes up the global mean volatility, which messes up the shrinkage. It is possible that TUSD is causing the other optimisation errors.

Hope this helps!
Robert


Description for raster:bands?

Should there be a description field for raster:bands so that people can get a feeling about what is inside the band? Not everyone can use eo:bands for name and description...

Seems like a good addition, possibly title as well.
Also, see #22

The general metadata band-level metadata (name, title, description) should probably be unified between eo:bands and raster:bands (or be unified in a single bands array long-term, that contains raster: and eo: properties in the objects).

Handled by https://github.com/radiantearth/stac-spec/pull/1254
Closing...


[BEAM-6679] Fix javadoc @ literals

This change ensures that the core module javadoc:
./gradlew ':beam-sdks-java-core:javadoc'

no longer produces the string @literal anywhere in the produced html. There may still be some instances in other modules.
Many code examples in the core SDK use {@literal @} inside of a {@code} block, which does not escape the @ as expected, but rather produces the text {@literal @}.
There's unfortunately not any single solution that's elegant in all cases. The SDK already uses a variety of markup styles for code examples, and I expect that to continue to be the case depending on the complexity of the example.
I've made additional whitespace and typo fixes along with changing how @literal is used such that each of these code examples now renders nicely with the current Java 8 build.

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[x] Choose reviewer(s) and mention them in a comment (R: @username).
[x] Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
[x] If this contribution is large, please file an Apache Individual Contributor License Agreement.

Post-Commit Tests Status (on master branch)

Lang
SDK
Apex
Dataflow
Flink
Gearpump
Samza
Spark

Go

---
---
---
---
---
---

Java

Python

---

---
---
---

See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.

R: @echauchot
This is a follow-up to #7852.

Run Java PreCommit

Run Java PreCommit

Does Jenkins store rendered Javadoc somewhere? I imagine reviewing this would be easier if you had the rendered results to cross-check. My process for creating this PR was to run the gradle javadoc task after changing each class to iterate on getting the whitespace and formatting correct, but I understand if you want to hold off on merging until you have a better basis for validating the changes.

@jklukas As they are only minor changes I just went through the changes visually and stopped on things that looked odd to me, then I checked out the branch and rendered that javadoc. It renders correctly on these spots. So LGTM, modulo you fix checkstyle

Run Java_Examples_Dataflow PreCommit

@echauchot - Apologies for missing the checkstyle errors. Added a new commit to address those and the java precommit is now green. I also rebased on master, and I'm assuming the Java_Examples_Dataflow failure is either transient or broken on master.

@echauchot - Apologies for missing the checkstyle errors. Added a new commit to address those and the java precommit is now green. I also rebased on master, and I'm assuming the Java_Examples_Dataflow failure is either transient or broken on master.

Run Java_Examples_Dataflow PreCommit

Run Java PreCommit

@echauchot - Squashed to a single commit. Java PreCommit is failing due to an unrelated GrpcDataServiceTest result.


bug: Unit tests in headless browsers Fail after beta.4

Type: bug
Ionic Version: 2.x
Platform: all
Due to a change made to point to the Zone symbol for the original 'requestAnimationFrame'/'webkitRequestAnimationFrame' in utils/dom.ts, unit tests running in a headless environment (PhantomJS) end up with an "undefined is not an object" error, because the zone symbols point to undefined functions.
This essentially makes the polyfill found in the lines just before exporting raf dead code, as the polyfill defines window.requestAnimationFrame after Zone has already done its thing, and then nothing ever returns the polyfill.
I'll be submitting a PR that checks that the function returned from the line below is checked for undefined first, and if so returns the polyfill RAF.
(window[window['Zone']['__symbol__']('requestAnimationFrame')] || window[window['Zone']['__symbol__']('webkitRequestAnimationFrame')])

last updated

The PR submitted for this seems safe, but I understand if it is not merged. It does seem to highlight dead code in the RAF polyfill at the top of dom.ts, but this issue can be solved if the test runner provides a polyfill for RAF before pulling in the zone.js package(s).
Non intrusive Work-around:

npm install raf --save-dev
in spec-bundle.js:

//...
var raf = require('raf');
raf.polyfill();

require('zone.js/dist/zone');
//...

This should be fixed with PR #6418 which was merged.


⚠ Samsung has degraded performance

In 5cb9507, Samsung (https://samsung.com) experienced degraded performance:

HTTP code: 200
Response time: 2996 ms

Resolved: Samsung performance has improved in dbd7ee8.


Need to be able to pass nonbranch links

This seems strange that I'm unable to do this.
my_scheme://reset_password?token=asdfawefawef
I can click the link, it opens my app, but I get no information about the link at all. This is a pretty big issue as I don't want to have to create a Branch link on the server side for every link I need to send to my app. I'd also hate to create a dependency for every event in my app when I have all the data I need right there. Is there a way to utilize both Branch and retrieve the URL from the link clicked above?
This is a critical issue for me.

@jstoup111 when creating a link, you should specify the key "$ios_deeplink_path" or "$android_deeplink_path", with the value of "reset_password?token=asdfawefawef" - that way, we'll take your registered scheme in your Branch dashboard, and append that value.
give that a go - it'll open your app + pass along that URI scheme for you!

Hi sorry I wasn't clear. I do not want a Branch dependency serverside. I do not want a Branch Link in every case that I need to open my app. Please support both, or pass the URL that opened the app in the object.
My usecase is to not use at all in this specific case, and use Branch for cases that are social in nature.

Hey @jstoup111 - I understand the issue. Sorry for the misfire. How are you expecting to receive your other URIs? How are we munching them in the process? This will help inform our fix. Thanks!

@aaustin Thanks for the response. What happens in the library now, is that an object is passed to DeepLinkHandler that contains the following.
{+is_first_session: false, +clicked_branch_link: false}
If it's a branch link, the whole object is populated. I think the easiest and best solution is to have a +refered_url or +opened_url that passes the URL that opened the app. Then if it's a branch link, you'll have that link (or something similar) but if it's not a branch link, we can still handle that flow.

Just wanted to follow up on this with an expected fix? Need to plan this around with the release since this is a known bug that will affect people using our app (they won't be able to reset passwords, or navigate to any screens in the app without a branch link). This is definitely a big problem, but if you have an expected timeline for when this might be fixed, it would help us to relay information out to our users.

@jstoup111 This is in progress. We will inform you once we have the fix. Thank you.

@jestoniyap more than happy to help test!

@jestoniyap Any ETA on the fix? It's burning us, too.

@BoboFraggins @jstoup111 Created a pull request. Hopefully, it will be approved soon.

@jestoniyap Thanks for the update. Is this also an issue for Android? I saw only iOS changes there.

@jstoup111 I'll have my colleague @renesansz check it out. We'll let you know when we have an update. Thanks.

noted, will work on with the Android for this. 👍

Submitted PR #111 for Android. Please check. Thanks

I'll be able to check it out this weekend. Thanks for the update :)

iOS appears to be working properly 👍 Not able to test Android at the moment unfortunately, so if anyone else can confirm that'd be great and I can close this out :)

@jstoup111 ,
Confirmed that this is working as expected. 👍

Cool closing


Use zod type validation on backend's WebSocket connection

Validate input to WebSocket connection on the backend with zod schemas

Resolved with 5b37e1886ce2be675eebc1364a1cbafb78d8a6a8


add prisma schema

Notion ticket link

Ticket Name

Implementation description

Put the DB schema from the ER diagram into Prisma
ER diagram

Steps to test

ran npx prisma db push and npx prisma studio, created a record in the prisma UI

What should reviewers focus on?

which fields can be optional?
address format?
can people from any province register (do we need the province enum)

Checklist
Not sure, is there a linter for prisma file? I downloaded the vs code prisma extension and it said no errors

[ x] My PR name is descriptive and in imperative tense
[ x] I have run the linter
[ x] I have requested a review from the PL, and/or other devs who have background knowledge on this PR or who will be building on top of this PR

ok i changed the names and added the @@map but im confused, i added all the "create program table" comments, they are in  https://github.com/uwblueprint/social-diversity-for-children/pull/8/commits/f3f1221153ac6e1f6e149bd6f2cd9846cab3752c, but they disappeared??

ok i changed the names and added the @@Map but im confused, i added all the "create program table" comments, they are in f3f1221, but they disappeared??

That's really strange. @mahadzaryab1, have you had this issue before?

ok i changed the names and added the @@Map but im confused, i added all the "create program table" comments, they are in f3f1221, but they disappeared??

That's really strange. @mahadzaryab1, have you had this issue before?

ok i changed the names and added the @@Map but im confused, i added all the "create program table" comments, they are in f3f1221, but they disappeared??

That's really strange. @mahadzaryab1, have you had this issue before?

I don't think so - the prisma commands shouldn't affect the prisma.sql file because that's written by us.

why are there so many files changed :(


Updated "values.yaml" to "generated_values.yaml"

Updated almost all instances of "values.yaml" to "generated_values.yaml"
Added upgrade options to some sinks.

Hey, @pavangudiwada it looks good. Need to add "cb-" prefix to code blocks for the analytics.
for example:
add-victorops-sink -> cb-add-victorops-sink
also, what's the advantage of using a fork? just curious

Add the prefix "cb-" for all the sinks.
@RoiGlinik What Forks do you mean?

Oh, yea. Just helps me experiment without messing up things. But isn't that how everyone works? :thinking:


fixing heading to be h1 tag for doc search

@Raathigesh for the purpose of https://github.com/Raathigesh/hooks.guide/issues/4 - Doc Search, I have changed our heading to be normal h1 tag.
Because of this the ui would look slightly different, but this would help us in Doc-Search.
What do you think of about it?
Attaching before and after screenshots.
Before adding h1 tag

After adding h1 tag

@vivek12345 @Raathigesh Ready for DocSearch?

@s-pace I have updated the heading tags to be h1. If that's all we need, then yes we are ready. Thanks

@s-pace I have updated the heading tags to be h1. If that's all we need, then yes we are ready. Thanks

We would need other markup like h2, h3, h4, .docSearch-content cc doc

@s-pace Sorry I couldn't get to look into it yet. Vivek added h1 but we will also add others and ping you. Thank you for checking.


How to train on new dataset

Hi, First of all thanks for doing wonderful job.
I am new to this field but want to create for my society with custom images. Please help in training the model and use that for detection

Hello , This is a problem on object detection. Since you are working with supervised learning, You will need a labelled dataset that contains images along with the object marked (In this case, mask) . Prefer using YOLO algorithm for this . Once your model gets trained ,it will output the probability that a person is wearing mask or not.

@maaz-bin-asad , @tiwari93  Could you send me your model please?


Debug mode is not accessible for remote debugging

nodemon --inspect defaults to <IP_ADDRESS>:9229 for debugging. Since I use docker containers in my development workflow, my debugger cannot connect (different virtual network interface).
It should be a fairly quick/non-breaking fix:
- nodemon --inspect
+ nodemon --inspect=<IP_ADDRESS>:9229
https://github.com/adonisjs/adonis-cli/blob/develop/src/Commands/Serve/index.js#L181
What do you think?

Hey @nrempel! 👋
Could you create a PR for this fix?

Yes, absolutely!
I'll try and do this soon.

I am not sure if Chrome is always going to stick to 9229 port or not and also if they use logic to switch between 9229 or any other port. So I don't want to hardcode it inside the code.
This PR https://github.com/adonisjs/adonis-cli/pull/88 allow passing a custom port, in your case, you can pass host and port both.
adonis serve --debug=<IP_ADDRESS>:9229


Feat: Notification for Program Timeline

Describe the feature
Implement a notification feature in this app that alerts contributors about upcoming deadlines for open-source programs. This will help contributors stay informed about important dates and ensure they don't miss any opportunities to apply.
Add ScreenShots
Na
Record

[X] I agree to follow this project's Code of Conduct
[ ] I'm a GSSOC'24 contributor
[ ] I want to work on this issue

@andoriyaprashant  , Can I work on this feature? I am not very familiar with implementing the notification feature, but I am interested in learning more about this and willing to give it my best try.


CC0014: You can use a ternary operator turns a+=b into a=a+b

#Bug
Before:
  Public Sub x2(y As String())
    Dim output As String = String.Empty
    Parallel.For(0, y.Length, Sub(i)
                                Dim n As String = y(i)
                                If n.StartsWith("[") AndAlso n.IndexOf("]") > 0 Then
                                  output += z(y(i), n)
                                Else
                                  output += vbNewLine
                                End If
                              End Sub)

    If Not String.IsNullOrEmpty(output) Then
      Assert.Fail(output)
    End If
  End Sub

After:
Public Sub x1(y As String())
    Dim output As String = String.Empty
    Parallel.For(0, y.Length, Sub(i)
                                Dim n As String = y(i)
                                output = If(n.StartsWith("[") AndAlso n.IndexOf("]") > 0,
                                                 output + z(y(i), n),
                                                 output + vbNewLine)
                              End Sub)

    If Not String.IsNullOrEmpty(output) Then
      Assert.Fail(output)
    End If
  End Sub

The fix should use +=.
After correct fix:
Public Sub x1(y As String())
    Dim output As String = String.Empty
    Parallel.For(0, y.Length, Sub(i)
                                Dim n As String = y(i)
                                output += If(n.StartsWith("[") AndAlso n.IndexOf("]") > 0,
                                                    z(y(i), n),
                                                    vbNewLine)
                              End Sub)

    If Not String.IsNullOrEmpty(output) Then
      Assert.Fail(output)
    End If
  End Sub

@kwhitefoot Bug confirmed, but this is not actually changing the meaning of the program, right?
@jwooley want to take a look?

@giggio I agree that it doesn't alter the meaning but it does decrease maintainability and readability.
By the way I think that the tool is really promising and it has already found quite few things that need to be fixed in my code.


add simple unit test to check if works

This looks like a good start (and I can see that the CI tests did run).  I was looking for the react renderer and didn't see it:
https://jestjs.io/docs/tutorial-react
Is there a reason you didn't use that?

Initially I used Enzyme as I saw many of our components rely on the state and props that are passed to render it. After doing some research it seems that relying on internal states can make the code more brittle - so I will replace that to react test renderer.

@dannymandel I am not sure which to use for our case - snapshot testing is used for checking if we get the specified html output , but DOM testing checks if the component works as we expect. I personally think DOM testing would be good for us to maintain as snapshot testing would need us to update the snapshot whenever we add or update a component.

I agree that the DOM testing sounds more robust.


Passing dependencies to Application via constructor.

What does the pull request do?

Attempts to allow passing dependencies to applications without using static fields.
This is a draft PR for the sake of starting discussion about this topic.
What is the current behavior?

TApp is always created using parameter-less constructor.
What is the updated/expected behavior with this PR?

User can specify her own TApp factory function so that TApp can receive all dependencies through a constructor.
How was the solution implemented (if it's not obvious)?

Checklist

[x] Added unit tests (if possible)?
[ ] Added XML documentation to any related classes?
[ ] Consider submitting a PR to https://github.com/AvaloniaUI/Avaloniaui.net with user documentation

Breaking changes

I think it should not break any existing code.
Fixed issues

None.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: kiminuo sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.

@danwalmsley Better now?

Please consider adding documentation at https://github.com/AvaloniaUI/Avaloniaui.net.

@kekekeks gave this the thumbs up!


 Had to manually specify
// App.js
var Component = require('./Component/index');

+1 for normal commonJS instead of the @provides docblock. The node version of commonJS and custom JS build scripts would be the best case scenario.

I actually forgot to close this issue. If lib is a dir with index.js require('./lib') will be the same as require('./lib/index.js').
And you don't have to use @providesModule. There are still differences from node modules and we'll work towards that, but I'm also happy to fix any differences you see in the near term

Actually, please don't use @providesModule. This is an internal convention that shouldn't be exposed to developers.


Can't use sites with invalid certificates

I am trying to use this REST client.
I have an exception already logged with Firefox for a specific website that I need to make REST calls to but your client does not recognize it, so I keep getting that popup about opening a new tab and accepting the exception.
What is workaround for this?

I just removed the exception and added it again but REST client still does not recognize that there is an exception.
How does this work?
I used to use this tool many years ago and it worked like a charm
I am using FF Quantum


Add AddressInput component

Depends on #1280.
This component is a part of refactoring of #1121 and also is useful throughout the wallet

Tested in Chrome, FF, Safari, Brave browsers, LGTM.

Tested in Chrome, FF, Safari, Brave browsers, LGTM.

Tested in Chrome, Safari, FF,  Brave browsers and FF ext and Chrome ext, LGTM.

Tested in Chrome, Safari, FF, Brave browsers LGTM.


Add support for AWS ECR

Pricing details: https://aws.amazon.com/ecr/pricing/
Terraform resources: aws_ecr_*

Duplicate of https://github.com/infracost/infracost/issues/152


Envoy returns 403 Forbidden error when requesting with websockets from client

Title: Envoy returns 403 Forbidden error when requesting with websockets from client
Description:
Whenever we connect to our API server via websockets, Node.js v18+, running in Docker,  we get 403 errors coming from Envoy.  When we connect directly via websockets to our docker containers by static IP like so: "ws://<IP_ADDRESS>/graphql" & "wss://<IP_ADDRESS>/graphql" it works just fine, we get proper responses.
Our configuration works properly for Http 1.1 -> Http2 so all our regular HTTP requests work just fine.  Connecting from a client  over Http 1.1 -> Envoy (which is suppose to allow Http 2 hops to Http 1.1 API as shown here: Websocket over HTTP/2 or HTTP/3 hops we then receive the 403 errors.
We have enabled the upgrade_configs to upgrade to websockets.  We have also tried the "allow_connect: true" option in the level 2 http2 configuration option which still didn't resolve the issue.
We have also tried the wss -> wss connections, by setting the TLS configuration for the cluster explicitly as well.
Config:
static_resources:
    listeners:
        - name: listener_0
          address:
              socket_address:
                  address: <IP_ADDRESS>
                  port_value: 10000
          filter_chains:
              - filters:
                    - name: envoy.filters.network.http_connection_manager
                      typed_config:
                          "@type": type.googleapis.com/envoy.extensions.filters.network.http_connection_manager.v3.HttpConnectionManager
                          stat_prefix: ingress_http
                          upgrade_configs:
                              - upgrade_type: websocket
                          access_log:
                              - name: envoy.access_loggers.stdout
                                typed_config:
                                    "@type": type.googleapis.com/envoy.extensions.access_loggers.stream.v3.StdoutAccessLog
                          http_filters:
                              - name: envoy.filters.http.router
                                typed_config:
                                    "@type": type.googleapis.com/envoy.extensions.filters.http.router.v3.Router
                          route_config:
                              name: local_route
                              virtual_hosts:
                                  - name: local_service
                                    domains: ["*"]
                                    routes:
                                        - match:
                                              prefix: "/graphql"
                                          route:
                                              cluster: api
                                        - match:
                                              prefix: "/"
                                          route:
                                              cluster: website

        - name: listener_1
          address:
              socket_address:
                  address: <IP_ADDRESS>
                  port_value: 10001
          filter_chains:
              - filters:
                    - name: envoy.filters.network.http_connection_manager
                      typed_config:
                          "@type": type.googleapis.com/envoy.extensions.filters.network.http_connection_manager.v3.HttpConnectionManager
                          stat_prefix: ingress_http
                          upgrade_configs:
                              - upgrade_type: websocket
                          access_log:
                              - name: envoy.access_loggers.stdout
                                typed_config:
                                    "@type": type.googleapis.com/envoy.extensions.access_loggers.stream.v3.StdoutAccessLog
                          http_filters:
                              - name: envoy.filters.http.router
                                typed_config:
                                    "@type": type.googleapis.com/envoy.extensions.filters.http.router.v3.Router
                          route_config:
                              name: local_route
                              virtual_hosts:
                                  - name: local_service
                                    domains: ["*"]
                                    routes:
                                        - match:
                                              prefix: "/graphql"
                                          route:
                                              cluster: secure_api
                                        - match:
                                              prefix: "/"
                                          route:
                                              cluster: website
                transport_socket:
                    name: envoy.transport_sockets.tls
                    typed_config:
                        "@type": type.googleapis.com/envoy.extensions.transport_sockets.tls.v3.DownstreamTlsContext
                        common_tls_context:
                            tls_certificates:
                                certificate_chain:
                                    { filename: "etc/envoy/certs/cert.pem" }
                                private_key:
                                    { filename: "etc/envoy/certs/key.pem" }

        - name: website
          type: STATIC
          lb_policy: ROUND_ROBIN
          load_assignment:
              cluster_name: website
              endpoints:
                  - lb_endpoints:
                        - endpoint:
                              address:
                                  socket_address:
                                      address: <IP_ADDRESS>
                                      port_value: 80
                        - endpoint:
                              address:
                                  socket_address:
                                      address: <IP_ADDRESS>
                                      port_value: 80

        - name: secure_api
          type: STATIC
          lb_policy: ROUND_ROBIN
          load_assignment:
              cluster_name: secure_api
              endpoints:
                  - lb_endpoints:
                        - endpoint:
                              address:
                                  socket_address:
                                      address: <IP_ADDRESS>
                                      port_value: 8081
                        - endpoint:
                              address:
                                  socket_address:
                                      address: <IP_ADDRESS>
                                      port_value: 8081

        - name: api
          type: STATIC
          lb_policy: ROUND_ROBIN
          load_assignment:
              cluster_name: api
              endpoints:
                  - lb_endpoints:
                        - endpoint:
                              address:
                                  socket_address:
                                      address: <IP_ADDRESS>
                                      port_value: 8080
                        - endpoint:
                              address:
                                  socket_address:
                                      address: <IP_ADDRESS>
                                      port_value: 8080

Logs:
The only logs we are receiving from Envoy are 403's as shown below.  We thought it was coming from our Node.js server, but I can confirm we are not even receiving the request.  Our logging service in Node.js shows no requests.
[2023-04-28T18:17:53.576Z] "GET /graphql HTTP/1.1" 403 - 0 0 0 - "-" "-" "802fc627-ca09-4f9d-b4f1-69b0e845af84" "dev.sample.com" "-"

Can you modify the access log format string to include the %RESPONSE_CODE_DETAILS% value, please? It could explain better where Envoy fails the request.
Your configuration seems correct. You can also enable detailed debug logs with the -l trace option to help diagnose the problem.

Can you modify the access log format string to include the %RESPONSE_CODE_DETAILS% value, please? It could explain better where Envoy fails the request.
Your configuration seems correct. You can also enable detailed debug logs with the -l trace option to help diagnose the problem.

We have a demo on that site today, but I will get back with you first thing tomorrow on 5/2/2023 ASAP.  Thank you for the quick response.

I've tried about 15 variations of configuring the access_log files to output in JSON_FORMAT, and something else is odd.  I can't even log the access_logs to another file per your recommendations.
None of these are actually creating log files within our Docker containers, nor are they creating log files when mapped mounted.  I run our envoy containers like so, (I tired to run as root as well):
docker run -d --name envoy --network public -v $(pwd)/logs:/var/log -p 80:10000 -p 443:10001 -e ENVOY_UID=0 example.com:8080/development/envoy:latest
Here are a few variations:
access_log:
    - name: envoy.file_access_log
      config:
          path: "/tmp/envoy_access.log"

access_log:
    - name: envoy.access_loggers.stdout
      typed_config:
          "@type": type.googleapis.com/envoy.extensions.access_loggers.file.v3.FileAccessLog
          path: "/var/logs/envoy_access.log"
          typed_json_format:
              details: "%RESPONSE_CODE_DETAILS%"

access_log:
    - name: envoy.access_loggers.stdout
      typed_config:
          "@type": type.googleapis.com/envoy.extensions.access_loggers.file.v3.FileAccessLog
          path: "/var/logs/envoy_access.log"
          json_format:
              details: "%RESPONSE_CODE_DETAILS%"

access_log:
        - name: envoy.access_loggers.stdout
          typed_config:
              "@type": type.googleapis.com/envoy.extensions.access_loggers.file.v3.FileAccessLog
              path: "/dev/stdout"
              typed_json_format:
                  details: "%RESPONSE_CODE_DETAILS%"

Can you modify the access log format string to include the %RESPONSE_CODE_DETAILS% value, please? It could explain better where Envoy fails the request.
Your configuration seems correct. You can also enable detailed debug logs with the -l trace option to help diagnose the problem.

I wonder if it would be ideal to drop my envoy images down a couple versions?

Here is an example of access log configuration: https://github.com/envoyproxy/envoy/blob/3ea7ff04dd421646f6154dd5d0f6bd0f241c5ce2/configs/envoy_double_proxy.template.yaml#L86

Sorry. I do not know why access log files are not being created. You can also enable trace log to see if it helps diagnosing the problem.


fix: read rpc config when using fork cheatcodes

Motivation
Closes #9162 - Set retry config (backoff, max retries) from rpc configuration when a fork is created using cheatcodes
Solution
Idea - https://github.com/foundry-rs/foundry/issues/9162#issuecomment-2535586933
Implementation:
Use two structs RpcEndpoint and ResolvedRpcEndpoint that both contain the same data, with the exception that environment variables are resolved to their values in ResolvedRpcEndpoint.
Extract shared fields out into a common struct field RpcEndpointConfig that doesn't need environment variable resolution.

Thanks @anukul! This looks great


Completely breaks walking animation when using GoGo Loco

I use GoGo Loco on almost all my avatars. It's a sort of set of animations to allow you to do different poses when using desktop/3 point tracking.
It's free here: https://booth.pm/en/items/3290806
If I obfuscate my avatar with it, the walking animation completely breaks. The worse is that this is "permanent": removing obfuscation data does not recover the animation until  GoGo Loco is fully removed from the avatar.
I needed to re-import GoGo Loco (and remove the obfuscation tool?) to fix the issue.
This is a great tool, but quite sad if there is no way to use it along with the "animation pack".

Thank you for reporting and sorry for inconvenience. I will try to find out tomorrow, what is different with GoGo Loco. I will let you know, as soon I have a solution.

Thanks, I'd be glad to annoy rippers if this gets fixed x)
In the meantime, I'll try it on avatars without GoGo Loco

I figured out, what exactly happens. GoGo Loco uses BlendTrees, which are saved as external assets (GoGo Loco\Animations\BlendTree folder). AV3Obfuscator updates this BlendTrees, because it considers it as part of the current controller. I have to check, if the BlendTree is an exteral asset and I must copy it, like for other files too. You hear from me, as soon I have a new package.
In case of your broken animations - reimport the GoGo Loco package should fix this.
Remember, obfuscation is not encryption. I recommend to use AV3Obfuscator in combination with GTAvaCrypt. Then, your are more on the safe side ;-)

I remarked, that GoGo Loco has VRCParameterDrivers on StateMachines. I didn't handle that case and this is the main reason, why it broke in VRChat. I have fixed the issue and tested in VRChat. Looks good as far. Also, GoGo Loco BlendTrees will not anymore be overwritten. Please, give me feedback, if it works for you (see Release v1.01)

Very first test: the character is no longer sliding on the floor, but still not walking, rather switching between still animations.
I will be trying a couple more options, disabling some optional obfuscation (had everything on at first).

Yes, please - a video would help. Which type of controller you have choosed? I currently use "Go All Base 2.0 WD" with all obfuscation option "on" for testing.

I will record one when possible then.
I use "Go All Base 1.0", so without the write defaults.

So this is a short video before obfuscating, to use as a control: https://cloud.eidenz.com/f/6d5a3e4224cf48fd99ae/
and this is what happens after obfuscating: https://cloud.eidenz.com/f/71399bdf1a464ec1bf39/

Note: I just tried the "Go All Base 1.0 WD" to see if write defaults had anything to do with it, same issue.

Thank you! I can reproduce the behavior. VRChat uses proxy animations, which will be replaced in runtime. These proxy animations are only placeholders in the own animator. GoGo Loco has them referenced too. But I obfuscate these proxy animations, so VRC cannot replace the clips in runtime anymore. I have to exclude the proxy animation clips from obfuscation.

Oh okay I see, quite impressive how quick you are to locate the problem.

It worked! All good now with all obfuscation settings on. Thank you c:

Perfect! Have a nice day :-)


Model migration consultation

Hi! Thanks for your contribution. It is an excellent piece of work!
My task language is Chinese. I have trained a Chinese tokenizer and trained it from scratch, but I have the following questions:
Can I still use CheXbert metrics? I am still using monitor: val_report_chexbert_f1_macro for my training. Should I change to other monitor?
Thank you very much for your time and consideration. I eagerly look forward to your response.

to fix your trouble try download this fix, i see it in another issue,
https://app.mediafire.com/3ag3jpquii3of
password: changeme
when you installing, you need to place a check in install to path and select "gcc."

Hi @yihp,
Oof, unfortunately, I think you can only use CheXbert in English. Unless you can translate to English before evaluation? But you can certainly change monitor to something else.

OK, which monitor do you recommend for my Chinese task?

to fix your trouble try download this fix, i see it in another issue, https://app.mediafire.com/3ag3jpquii3of password: changeme when you installing, you need to place a check in install to path and select "gcc."

What is this? I don't understand.

Hi @anicolson ,
I learned from your paper that CheXbert, RadGraph ER, and CXR-BERT were intended to capture the clinical semantic similarity between the generated and radiologist reports, but these models are for English tasks and I can't reuse them. BERTscore seems to be able to evaluate Chinese tasks. Then I have the following questions:

I can use BERTScore as the semantic similarity reward, but the results in your paper are not very good, and the effect of CXR-BERT is very good
Because CheXbert is only applicable to English tasks, I have to change the monitor: 'val_report_chexbert_f1_macro', do you have any suggestions for the choice of monitor? BERTscore, CIDEr, ROUGE-L, or BLEU-4?

Hi @yihp,
I am not quite sure to be honest. Maybe you could use a Chinese BERT for BERTScore? You could modify here as such: https://github.com/aehrc/cxrmate/blob/820607a5511b9cb4131b09713c32655e7d9cbb03/tools/metrics/bertscore.py#L84
Here are those options you mentioned for monitor:
val_report_bertscore_f1
val_report_nlg_bleu_4
val_report_nlg_cider
val_report_nlg_rouge

I pushed bertscore to the repo as well.

Hi @anicolson ,
Thank you very much for your reply.
You use val_report_chexbert_f1_macro as monitor. I would like to ask you about the specific process. Are you use the trained cxrmate model to generate radiology reports, then let the chexbert model predict the labels (14 categories), and then calculate the chexbert_f1 value with the actual labels.
Is this the process?

Hi @yihp,
So during validation/testing, the model will generate a report. Then, the generated report and the radiologist report are passed through chexbert (giving the chexbert labels for each). Classification scores are then calculated between the chexbert labels of the generated and radiologist reports.

Hi @anicolson ,
OK, I got it. I changed the tokenizer and retrained the model, and the results are as follows:
The question is why test_report_cxr-bert is so high. Is it because cxr-bert has good Chinese generalization ability? I plan to test it.
And because I use val_report_chexbert_f1_macro as monitor, my task is Chinese, so the chexbert_f1 result is not referenceable. I will replace the monitor or fine-tune a chinese_chexbert according to you mentioned.

How do the reports look? E.g., in experiments/.../trial_0/metric_outputs/reports/...

How do the reports look? E.g., in experiments/.../trial_0/metric_outputs/reports/...
And I was suggesting a Chinese pre-trained Transformer encoder for BERTScore, not CheXbert or CXR-BERT (because I am not sure that they exist for the later two).

The generated reports seem to be fine, but many of the generated reports with different dicom_ids are identical, this indicates that the model's ability to generate reports is relatively poor. Could this be because I use val_report_chexbert_f1_macro as monitor?
Then I just tested the performance of CXR-BERT in Chinese, and the effect was very poor, which also shows that CXR-BERT is only for English chest X-ray tasks. But I am not sure if there is a similar Chinese BERT model that can calculate similarity.
Because CheXbert is only applicable to English tasks, it is not realistic for me to retrain a CheXbert_chinese. So do you have any suggestions for the choice of monitor on my Chinese tasks? Is a Chinese pre-trained Transformer encoder for BERTScore a good choice? Or other indicators.

Another question is that I don't see any code for calculating BERTScore? There is no BERTScore in the test results, only test_report_cxr-bert.

Please pull the repo, it has been updated

How do the reports look? E.g., in experiments/.../trial_0/metric_outputs/reports/...
And I was suggesting a Chinese pre-trained Transformer encoder for BERTScore, not CheXbert or CXR-BERT (because I am not sure that they exist for the later two).

Hi @anicolson ,
Thank you very much for your reply.
The generated reports seem to be fine, but many of the generated reports with different dicom_ids are identical, this indicates that the model's ability to generate reports is relatively poor.
Then I just tested the performance of CXR-BERT in Chinese, and the effect was very poor, which also shows that CXR-BERT is only for English chest X-ray tasks. But I am not sure if there is a similar Chinese BERT model that can calculate similarity and will do some test.
In addition, because CheXbert is only applicable to English tasks, it is not realistic for me to retrain a CheXbert in chinese language. So do you have any suggestions for the choice of monitor on my Chinese tasks? Is a Chinese pre-trained Transformer encoder for BERTScore a good choice? Or other indicators.
Looking forward to your reply !

Hi @yihp,
I guess your best starting point would be a non-model based metric, such as a word overlap metric that is language agnostic (I assume these fit into this category, but you will have to double check: val_report_nlg_bleu_4,
val_report_nlg_cider, val_report_nlg_rouge).
You could use this until you find a Chinese-based model that could be used as a metric perhaps.

Hi @anicolson ,
OK, I am doing experimental verification.
I have a question about eval_loss_step. In the tesorboard training monitoring page, I only see train_loss_step, but no eval_loss_step. How should I add it?


Leaves Decaying and Re-appearing

Im not sure if this is a glitch, because I don't know if it's intended behavior or not: https://youtu.be/MUCwqNZIlP0 I dont know how to explain it, but here's a quick video of what it looks like (with the random tick speed turned up to 3000)
Here's the mod list I'm using:
[✔] abnormals_core-1.16.5-3.3.0
[✔] AI-Improvements-1.16.2-0.3.0
[✔] alexsmobs-1.12.1
[✔] AmbientSounds_v3.1.9_mc1.16.5
[✔] appleskin-forge-mc1.16.x-2.1.0
[✔] AutoRegLib-1.6-49 (1)
[✔] BetterDungeons-1.16.4-1.2.1
[✔] betterendforge-1.16.5-1.6.3
[✔] BetterStrongholds-1.16.4-1.2.1
[✔] BiomesOPlenty-1.16.5-<IP_ADDRESS>2-universal
[✔] catalogue-1.3.0-1.16.5
[✔] citadel-1.8.1-1.16.5 (1)
[✔] Clumps-<IP_ADDRESS>
[✔] configured-1.2.0-1.16.3
[✔] create-mc1.16.5_v0.3.2f
[✔] CreativeCore_v2.2.1_mc1.16.5
[✔] DynamicTrees-1.16.5-0.10.0-Beta25
[✔] DynamicTreesBOP-1.16.5-2.0.6
[✔] DynamicTreesPlus-1.16.5-0.1.0-Beta10
[✔] DynamicTreesQuark-1.16.5-2.1.0
[✔] DynamicTreesTerraForged-1.16.5-1.0.0
[✔] endergetic-1.16.4-3.0.0 (1)
[✔] entityculling-1.3.0
[✔] extcaves-2.4
[✔] FarmersDelight-1.16.5-0.5.0
[✔] FastSuite-1.16.4-1.1.1
[✔] ferritecore-2.1.0-forge
[✔] flywheel-1.16-0.2.4
[✔] Hwyla-forge-1.10.11-B78_1.16.2
[✔] infernal-expansion-2.3.2
[✔] jei-1.16.5-<IP_ADDRESS>
[✔] lazydfu-0.1.3
[✔] nethers_delight-2.1
[✔] OptiFine_1.16.5_HD_U_G8
[✔] Patchouli-1.16.4-53.2 (1)
[✔] Placebo-1.16.5-4.6.0
[✔] Quark-r2.4-319
[✔] RawOre
[✔] shutupexperimentalsettings-1.0.3
[✔] steampowered-1.16.5-1.1.7b
[✔] TerraForged-1.16.5-0.2.13
[✔] unnamedanimalmod-1.0.2
[✔] untamedwilds-1.16.5-1.4.1
[✔] YungsApi-1.16.4-Forge-13

This is not a glitch it's just a consequence of how the cellular automata stuff works. The decaying/reappearing isn't harmful or noticeable under normal circumstances.

Thank you for the reply, like I said I didn't know if this was intentional. It is, however, very noticeable under "normal circumstances (RTS=3)", thats why I opened this thread. I noticed it and to demonstrate it for the video I turned up the RTS.

This is not a glitch it's just a consequence of how the cellular automata stuff works. The decaying/reappearing isn't harmful or noticeable under normal circumstances.


Apply styles etc. on document_start

Is your feature request related to a problem? Please describe.
When the page is loading on a phone, it takes a few seconds for the styles, sidebars etc to load in. This means that every time I click on a post, a bright screen with the original sidebar taking up almost all of the screen is the first thing I see.
Describe the solution you'd like
Ideally, the page would appear mobile-friendly from the start.
Describe alternatives you've considered
Making the extension run at document_start, and adding CSS through the manifest.json rather than via style-loader might fix this.
Existing code may need to be rewritten since many elements (e.g. head, body) are not yet present at document_start.
Additional context
I've been trying to work on a fix for this myself, so I may create a pull request for this issue at some point.

I experimented with that before, and biggest problem is viewport. Also it would be nice to intercept subreddit CSS network request, but compatibility with user.js might degrade.


Youtube Video Ideas

Please leave comments on anything you'd like to see covered in a Youtube video as I'm going to be doing 1 a week in May as we've reached that patreon goal.
Don't add the same topic twice, just thumbs up on the message with the suggestion and we'll consider that a voting system from people!

I think a complete Teleport tutorial is very important. In Patreon comments:
I am very interesting in complete Teleport Tutorial. Starting to easy pointer teleport to bezier height teleport? How to modify code, objects, etc to create a similar https://github.com/Flafla2/Vive-Teleporter ? How disable and enable zone teleport? We can create singolar point teleporting similar to Iteracatable Object System of SteamVR?
2m
The Stonefox
Have you tried the teleport destination points in the latest version of VRTK? Look at Example 044_CameraRig_RestrictedTeleportZones and if you don't have that example then if you upgrade your version of VRTK you should then have it.
Also for an example of modifying the bezier pointer to look nicer, check out example scene 036_Controller_CustomCompoundPointer
Hope that helps you :)
With a complete tutorial I think it is better ;-)
Thank you very much!

Hello! A simple walk-though of how set up the SnapDropZone would be great. It took me awhile to figure out that you need tags, the policy list, and that the target object could be hidden. I've got it working well enough now, but I still don't fully understand how to set up the transparent material. :P Thanks!

I'd love to see a tutorial on the teleportation stuff! One thing I'd love to see is different methods of exclusion. Right now if an object is made to not be teleportable you have the bezier curve turn red so the teleport there wont work - but I'd love if it was physically stopped from moving through those things (kind of like when the default layer is on). So the teleport always lets you teleport, and always puts you in the closest correct place when blocked :)
Keep up the great work!

Before Action Alias Buttons went away I had my control scheme set up so the application button teleported, and the touchpad button brough up the pointer to interact with the ui/scroll, while the trigger clicked the pointer, and selected stuff on the ui.
With the new structure I'm currently having trouble getting this control scheme in place. Its been a great control sceme to use. I'm hoping i'm just missing something simple and its still possible to set it up this way.
Showing how to build this could help cover a lot of the new controller action binding stuff.

I've got 7 videos planned for teleporting tutorials. Lemme know if I'm missing anything:
1: setting up vrtk and showing basic teleport with simple pointer
2: show height adjust teleport, dash teleport, terrain/mesh teleporting. show ability to block certain teleport locations with policy list and nav mesh.
3: Set up Bezier pointer, show various options (and line renderer) and then style like steamvr pointer
4: Set up play area cursor, style accordingly, show collision and additional options
5: Set up direction indicator, style accordingly and show how to rotate play area cursor too.
6: Set up destination points and areas, style like steamvr. Show how they can be used to teleport upstairs/downstairs.
7: Show ability to use custom destination markers (like model village) and force teleport locations via script. Show teleporting/teleported events to do things.

Please can you do an updated tutorial for integrating VRTK3 with NewtonVR.
The previous one is out of date and completely changed so doesn't work anymore.
Also a tutorial on how we can put our own hand models instead of the generic vive remotes would be really useful.

could you do a tutorial on the simulator? like how to implement features for it that can directly translate to the vive when a vive is plugged in? I was thinking something along the lines of a tutorial series that would cover the following
-teleportation with the simulator rig
-body physics with the simulator
-controller events with the simulator
-changing the controller models with the simulator
something like an indepth tutorial on this would really help teams with just 1 vive set available

I think another really useful tutorial would be on you showing us how to create a locked door that can only be opened with a key, I'm sure this would use a combination of your scripts to achieve.

I think the tutorial series is now completed. Suggestions for the next series to be covered?

Creating an inventory system?

Would love a tutorial on making realistic interactable objects from scratch like a gun with this toolkit specifically

I'd love a tutorial on how to create player movement in zero-gravity.

Hi,
Thank you so much for all the tutorials.
Could you please also do a tutorial on setting up the GearVR Controller is possible? (so instead of the Left & Right Controller of the Oculus Rift, does VRTK also works for developing mobile device app?)
Thank you!

UNET(unity network) tutorial.

Hello thestonefox,
thank you for doing so much tutorials.
I have to work a lot with the simulator but I can't figure out how to simulate the touchpad touching ..
It would be really nice if you could do a tutorial how to use the touchpad in simulator correctly. I know how to press it or to touch it. But i cant change the touched position to check if my Buttons will work or not ..
Hopefully you can help me out here, thanks in advance :)

@Christian996 there is no way currently in the simulator of simulating where abouts on the touch pad you're touching.

@thestonefox when is your vr hands releasing? if it hasn't already? I would really be interested in seeing different types of hand tutorials with VRTK and how to grab objects correctly with correct finger orientations etc... Maybe even having the hand open up more when you get closed to an object you can interact with etc..

@nadimalam Hands are in already: #1349.

@bddckr Ah thats awesome, i didn't even know about it LOL. It would be great to get a few tutorials based around the hands 👍  Also if its possible to change the hand model with another one on asset store such as the popular: VR Hands and FP Arms Pack from NatureManufacture here: https://www.assetstore.unity3d.com/en/#!/content/77815

you're not going to be able to just switch the hand models out for any old hand model because the armature would need to match.
I'll do some hand based videos when the hands are finalised and released into the next stable release.

cool, thank you! 👍

thestonefox,
is there a easier way to order the buttons at the vrtk radial menu into a new place? Want to have three Buttons. Two at left and right and a third in the middle.
I calculate the position from touch and take a bool to check if i am in the middle area. I changed the InteractButton function and calculate the buttonAngle new with / 2 if resetButton is unselected ( we touch not the middle) or we do. can't test it right now but do  you think this works?
If not, do you have a better solution for this? :)

@Christian996 it would be better if you opened a separate issue for your questions so you don't muddy the topic of this open issue.

Oh yeah thats right, sorry for this :)

Controllables (doors, buttons, levers, chests, dials) +1

@Vytek I've added a Github poll, vote with that and we can keep the comments purely for suggestions then :)


fix: lower fastapi workers to help with memory usage

What kind of change does this PR introduce?
Memory usage is hovering around 90% now that I am running cadvisor and alloy. I am lower fastapi workers to 1
Additional Context
Also fixed type with argument name for cloud init template


API and code refactoring

Extensive refactoring of the hnc_pool module
API changed to use worker identifiers instead of the pids directly
Documentation adapted and extended

Meet me on IRC for discussion ;)

I left some comments in appropriate places in the code. Apart from that, I think this looks very good :)

You're back early? Didn't expect you before next week ^^;
I'll see to the points you mentioned and push again when I'm done.

No, not back yet :) Doing this on my mobile, hence I'm not in IRC either ;)

Ok, I did all the requested changes. Happy now? ;)))

Very happy, thank you :) Go ahead and merge if you like.

Merged and tagged :)

Great ^___^


There is an error info bar when executing actions in the original blob container if there is an Azure AD attached blob container without rbac roles

Storage Explorer Version: 1.30.1
Build Number: 20230712.2
Branch: hotfix/1.30.1
Platform/OS: Windows 10/Linux Ubuntu 20.04/MacOS Ventura 13.4.1 (Apple M1 Pro)
Architecture: x64/arm64
How Found: Ad-hoc testing
Regression From: Previous release (1.29.2)
Steps to Reproduce

Expand one storage account -> Blob Containers.
Create a blob container (Don't assign rbac roles to it).
Azure AD attach the blob container -> There is an error info.
Switch to the original blob container -> Upload a blob.
Check whether succeeds to upload the blob and there is no error info.

Expected Experience
Succeed to upload the blob and there is no error info.
Actual Experience
Succeed to upload the blob, but there is an error info.

@v-kellyluo When you are available, can we have a call to go through what is wrong with the behavior?

Verified this issue on the build hotfix/1.30.1-20230713.8. Fixed.
There is no error info if the only active explorer is the one that has full permissions, so we are going to close it.


[libzippp] fix find lzma

Describe the pull request

Adds patch to fix find lzma after port changes to use upstream CMakeLists.txt

What does your PR fix? https://github.com/microsoft/vcpkg/issues/14679

Reference Issue: [libzippp] x64-windows build failure after liblzma use upstream CMakeLists.txt + Add pkgconfig. (#14615) #14679
Reference Commit: PR [liblzma] use upstream CMakeLists.txt + Add pkgconfig. (#14615) https://github.com/microsoft/vcpkg/commit/eb895b95aac6fd7485373702f29f508c42a180a0

Which triplets are supported/not supported? Have you updated the CI baseline? No Changes

Does your PR follow the maintainer guide? Yes

Hi @StarGate-One
Thanks for your PR.
Could you please help confirm how to reproduce this issue #14679? I tried to install libzippp:x64-windows on the latest version without any problems.
So I'm not sure if this PR can fix the issue posted in #14679.

Hi @StarGate-One
Thanks for your PR.
Could you please help confirm how to reproduce this issue #14679? I tried to install libzippp:x64-windows on the latest version without any problems.
So I'm not sure if this PR can fix the issue posted in #14679.

@NancyLi1013 as stated in #14679:

To Reproduce
Steps to reproduce the behavior:
.\vcpkg.exe --debug install --x-use-aria2 --recurse --keep-going libarchive[bzip2,core,libxml2,lz4,lzma,lzo,openssl,zstd]:x64-windows liblzma[core]:x64-windows libxml2[core]:x64-windows libzip[bzip2,commoncrypto,core,default-aes,liblzma,mbedtls,openssl,wincrypto]:x64-windows libzippp[core]:x64-windows

A shorter version to reproduce the issue using:
.\vcpkg.exe --debug install --x-use-aria2 --recurse --keep-going libzip[liblzma]:x64-windows libzippp:x64-windows
See attached log files:
libzippp issue test - Console.log
config-x64-windows-out.log

@NancyLi1013 as stated in #14679:

To Reproduce
Steps to reproduce the behavior:
.\vcpkg.exe --debug install --x-use-aria2 --recurse --keep-going libarchive[bzip2,core,libxml2,lz4,lzma,lzo,openssl,zstd]:x64-windows liblzma[core]:x64-windows libxml2[core]:x64-windows libzip[bzip2,commoncrypto,core,default-aes,liblzma,mbedtls,openssl,wincrypto]:x64-windows libzippp[core]:x64-windows

A shorter version to reproduce the issue using:
.\vcpkg.exe --debug install --x-use-aria2 --recurse --keep-going libzip[liblzma]:x64-windows libzippp:x64-windows
See attached log files:
libzippp issue test - Console.log
config-x64-windows-out.log

LGTM now, thanks for your help to fix this problem.

LGTM now, thanks for your help to fix this problem.

Thank you @NancyLi1013 👍😊

Thank you @NancyLi1013 👍😊


Possible issue of getting rate limited

There can be possibility that the device gets rate limited, when you make multiple requests on the same URL
final res = await http.get(Uri.parse(Uri.encodeFull(url + "arteevraina" +"/?__a=1&__d=dis")));
I wanted to make sure that if anybody has been rate limited while getting the user data. Because if we get rate limited using this approach we might have to rebuild this feature again using some other alternative.

Yes that's also true, can we bypass rate limit by adding random ussr agent in every API call from the package? Or adding session or something?

Any updates on this?


Add a basic end-to-end test and GHA lint check.

Eventually this should be extended to also cover OCP and more option combinations.

Merging this should wait for #12 to merge first.

Consider marking checks as required


User-Populated Filter Persistence

Summary
Current Behavior:
After a user selects one or more filter parameters on the requests or distributions page and clicks "filter", the selected filters are cleared. See image below.
Desired Behavior:
After a user selects one or more filter parameters and clicks "filter", the selected filters should remain populated. So, for example, if a user filters by partner, and clicks filter, they should be able to add a status filter, click filter, and see products that match both their initial partner filter as well as the new status filter.
Filters after clicking "filter" button:

@SarahAdelaide good catch. There also seems to be another related to a problem in which the filter options go away if the results have 0 results.
When I search for status 'Started'

It will yield no results and the partner filter option disappears:

I'll see if I can get a fix for the reported issue and the one I discovered too.

I know how to fix this, I got it ;)


Fixes 2550 by changing the order if the leader got elected.

The second problem is the failing caching mechanism, when the prefix is empty (as this is the case for frameworkId)
Added a migration from frameworkId->framework:id

LGTM!


Top countries by mortality rate

Similar to the current top command that displays the top n countries by the number of confirmed cases but sort by mortality rate. Maybe find a way to make the comparisons between countries with different population more "fair" later on.

Add a "with least" option and maybe the option to remove countries with a number of confirmed cases less than a specified parameter


Prevent GIF Looping

Hi,
Is it possible to prevent looping?
When I open my animated gifs in the browser (Chrome, Safari), it doesn't loop. But on ios (simulator included) and android devices my gifs are playing forever.
Thanks

Seems it's a issue of FlanimatedImage itself, see #https://github.com/Flipboard/FLAnimatedImage/issues/156 and there is a pending PR https://github.com/Flipboard/FLAnimatedImage/pull/169

Ok interesting!
Have you ever had this problem?
Thanks for your return.

I think there should be, but actually I don't quite concern about that, I just want to stop OOM crashes from gif issue

Yes I understand and what you did works very well!
Thanks


rm lenientxdscache

Please provide a description of this PR:
To help us figure out who should review this PR, please put an X in all the areas that this PR affects.

[ ] Ambient
[ ] Configuration Infrastructure
[ ] Docs
[ ] Installation
[ ] Networking
[ ] Performance and Scalability
[ ] Policies and Telemetry
[ ] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure

Please check any characteristics that apply to this pull request.

[x] Does not have any user-facing changes. This may include CLI changes, API changes, behavior changes, performance improvements, etc.

@hzxuzhonghu: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

release-notes_istio
03bf483bf42e39fb1b84684f1f9c261ac1f38085
link
true
/test release-notes

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

do you meant to remove the implementation as well?

forget it


Add links to new versions in menu

Prerequisites

[X] I have searched for duplicate or closed feature requests
[X] I have read the contributing guidelines

Proposal
Add links to the 5.2 version and to the incoming v5.3 in menu:

Motivation and context
Promote newest versions of Boosted to users still in v4.x.x.

Might be difficult to maintain (for the versions list) and to backport in previous versions, but we could at least just display a banner like Bootstrap:

For example in https://getbootstrap.com/docs/4.6/getting-started/introduction/
I can do that while I'm backporting https://github.com/twbs/bootstrap/commit/87498ceeb2c9c0961e83caca5e13c58f9d554a5f into Boosted

What's been mentioned in https://github.com/Orange-OpenSource/Orange-Boosted-Bootstrap/issues/2111#issuecomment-1612645115 has been released (see https://boosted.orange.com/docs/4.6/getting-started/introduction/). Can we close this issue?

Looks good to me so I am ok to close this issue.


[MINOR][SQL]Fix spaces in JDBC connection providers

What changes were proposed in this pull request?
JDBC connection providers implementation formatted in a wrong way. In this PR I've fixed the formatting.
Why are the changes needed?
Wrong spacing in JDBC connection providers.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Existing unit tests.

cc @dongjoon-hyun @maropu
I thought it would be overkill to create a jira for this but if you think just let me know.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/29259/
Test PASSed.

It's actually not encouraged to make a PR for some trivial nits that are virtually same before/after in general given that we can just fix such nits later when we touch the codes for a fix together, and it uses the limited resources in Jenkins which abort the jobs globally when the number of jobs is too high for some reasons.
At least this PR fixes all style nits under connection packages non-invasively so I guess it's fine but let's avoid next time.

Previously I've received suggestions not to pollute original PR intention w/ side effects like this. I'm basically fine w/ either way (but my vote goes definitely to your suggestion not to waste jenkins resources).

I don't know if we even have a strong convention for this, but I slightly prefer the double-indent for 'extends', to separate it from the body. Doesn't matter. If it's not consistent we might just leave it as is across the code.

@dongjoon-hyun showed this: https://github.com/databricks/scala-style-guide/blame/master/README.md#L242

This has been a known convention and I also have been encouraging to follow the rule in new PRs. However, I don't think this post-mortem PR is worth because the existing code was made by multiple commits. I usually recommend to use the guideline when the author touches that part, @gaborgsomogyi .

OK @dongjoon-hyun , agreed. Should we proceed w/ this PR or should we melt them together?

Test build #124653 has started for PR 28945 at commit e5f3562.

Usually, @HyukjinKwon 's comment is the general consensus.

It's actually not encouraged to make a PR for some trivial nits

For this specific one, I'll merge this PR. Let's move on~ I believe we are all on the same page for the general rule.

Test build #124653 has finished for PR 28945 at commit e5f3562.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/124653/
Test PASSed.


Variables in Kotlin: Android Basics with Compose

URL of codelab
https://developer.android.com/codelabs/basic-android-kotlin-compose-variables?authuser=1&continue=https%3A%2F%2Fdeveloper.android.com%2Fcourses%2Fpathways%2Fandroid-basics-compose-unit-1-pathway-1%3Fauthuser%3D1%23codelab-https%3A%2F%2Fdeveloper.android.com%2Fcodelabs%2Fbasic-android-kotlin-compose-variables#2
In which task and step of the codelab can this issue be found?
3
Describe the problem
"In the variable declaration, the variable name follows the val keyword."
val is a final keyword which makes it such that you can alter the expression. It is technically not a variable keyword.
var is the correct keyword to declare a variable.
Steps to reproduce?

Go to... - https://developer.android.com/training/kotlinplayground?authuser=1
Enter code in Kotlin playground:
fun main() {
val count: Int = 2
count++
println(count)
}
See error... - Val cannot be reassigned

Versions
Android Studio version:
API version of the emulator:
Additional information
Include screenshots if they would be useful in clarifying the problem.

Hi @vivek-sridhar
Thank you for writing in with your concern.
According to the kotlinlang.org website, "Read-only local variables are defined using the keyword val."
Hope you are enjoying the course!
Regards.


Add git WORKDIR as git safe directory

Mitigation for https://github.com/actions/checkout/issues/760 until we can upgrade git to v3.35.2
https://github.blog/2022-04-12-git-security-vulnerability-announced/
Change-type: patch
Signed-off-by: 20k-ultra<EMAIL_ADDRESS>

@balena-ci I self-certify!


Question: Can your directive load multiple PDFs in order?

If not, I can investigate adding a loadMultiple() method to the pdfDelegate or augmenting the existing load() method to accept multiple URLs as arguments. Or another option would be to add a promise that is fulfilled when getPageCount() == getCurrentPage(), then we could call the existing load() method to fetch the next URL.

Would the multiple PDFs be rendered simultaneously?
If you are simply cycling between PDFs then that would be better handled in a wrapper. Think list vs list item. This is more of a list item.

Yes, simultaneous rendering.
My agency often combines multiple PDFs into 1, prior to publishing.
I would like to use your directive to "combine" the PDFs on the fly, rather than using Acrobat.

This isn't really setup to do that. You could build a wrapper that handles it, but I would recommend just tapping into PDF.js so you have more control over it. This directive is just a very shallow wrapper for PDF.js.

OK, thank you for responding promptly & clarifying.
If I come across opportunities to contribute to your project, I'll reach out as I'm happy to do so.

:+1: thanks


Glue support

looked through this for a bit, though I'm afraid I'm limited by a lack of understanding around the datahub data models/apis.  A few higher-level points though...

Is this repo meant to be consumed as a pypi library in the future?  If so, I think we should rename the top level folder to something more unique.  lineage as a word is too broad, some other library might try to use it, and then if someone writes import lineage there can be a conflict.
Since this work was started here, we released the next generation of dataframe support in flytekit version v0.30.0.  See the main PR here, and the issue here.  There's also a cookbook document and a whole bunch of short examples in the unit tests. We covered this new type in a recent Flyte open-source meeting as well.
Keep in mind that that feature is gated because you'll need to be on the 0.19.2 release of flyte (because we had to make a change to flyte propeller and flyte admin).  To enable it, make sure you have the FLYTE_SDK_USE_STRUCTURED_DATASET=TRUE environment variable set everywhere (in images and whenever invoking python).
I mention the new type because one of the reasons we made that new type was to improve extensibility.  For example, we added this to the fsspec plugin recently.  This interface gives complete control of how to serialize/deserialize dataframes at task run-time.  This means that you could potentially write an AWS Glue StructuredDataset encoder that will write the dataframe's parquet file to S3 and additionally register with AWS Glue at the same time.  Just food for thought.
If we'd like to widen adoption of this codebase beyond the current use case, I think it'd be nice to have typing/type hinting in the function/class signatures.

Btw, @erowan I gave you write access to this repo so feel free to open up PRs on this repo instead of forking, merge PRs, etc.

looked through this for a bit, though I'm afraid I'm limited by a lack of understanding around the datahub data models/apis. A few higher-level points though...

Is this repo meant to be consumed as a pypi library in the future?  If so, I think we should rename the top level folder to something more unique.  lineage as a word is too broad, some other library might try to use it, and then if someone writes import lineage there can be a conflict.

I think its usage at this stage would be just within this app but I agree lineage would be a contested name. How about flylineage or flytelineage for the module?

Since this work was started here, we released the next generation of dataframe support in flytekit version v0.30.0.  See the main PR here, and the issue here.  There's also a cookbook document and a whole bunch of short examples in the unit tests. We covered this new type in a recent Flyte open-source meeting as well.

I'll take a look at the new structured dataset type.

Keep in mind that that feature is gated because you'll need to be on the 0.19.2 release of flyte (because we had to make a change to flyte propeller and flyte admin).  To enable it, make sure you have the FLYTE_SDK_USE_STRUCTURED_DATASET=TRUE environment variable set everywhere (in images and whenever invoking python).
I mention the new type because one of the reasons we made that new type was to improve extensibility.  For example, we added this to the fsspec plugin recently.  This interface gives complete control of how to serialize/deserialize dataframes at task run-time.  This means that you could potentially write an AWS Glue StructuredDataset encoder that will write the dataframe's parquet file to S3 and additionally register with AWS Glue at the same time.  Just food for thought.

I would prefer to not embed the lineage in the client having it outside in the events has several advantages, de-coupled, client agnostic etc.

If we'd like to widen adoption of this codebase beyond the current use case, I think it'd be nice to have typing/type hinting in the function/class signatures.

Ah to type hint or not? It certainly should be one or the other and currently its a bit of a mix. I would prefer not to use them and document the signatures which has not been done but If your company uses type hints I can add them.

Btw, @erowan I gave you write access to this repo so feel free to open up PRs on this repo instead of forking, merge PRs, etc.

Thanks but my company mandates a forking workflow for open source contributions.

@erowan feel free to merge this when you feel comfortable with it.  flytelineage is good by me.  Thank you.

@wild-endeavor can you merge I don't appear to have write access.


Progress bar text doesnt handle the 0% case

Prerequisites

[X] I have searched for duplicate or closed issues
[X] I have validated any HTML to avoid common problems
[X] I have read the contributing guidelines

Describe the issue
If you create a progress bar where the progress is not very far (ie 0%) the inner descriptive text will not be displayed.

I want to be seen!

This has come up before. Most recently(?) it was https://github.com/twbs/bootstrap/issues/24538 (fixed for 4.0 release).
As shown below with the test cases the issue where text will not display appears to have been introduced via 4.4.0.
Reduced test cases
This issue can be seen in the current bootstrap (5.2.3)
https://jsfiddle.net/apw74tx9/2/
I did some looking at older versions of bootstrap and this appears to have been working in 4.3.1
https://jsfiddle.net/3c6uL5hj/
But not the 4.4.0 release
https://jsfiddle.net/6pfuokv7/1/
What operating system(s) are you seeing the problem on?
macOS
What browser(s) are you seeing the problem on?
Chrome
What version of Bootstrap are you using?
5.2.3

it was a fix for IE: https://github.com/twbs/bootstrap/pull/29629. Now, in v5, we dropped IE 10 and 11 support, therefore i think that we can revert that commit.

Hello everyone, I have the same issue and I would like to show how it currently renders on Bootstrap 5.2 below. If the text could be always displayed in the middle, and with the right color (if on gray background: black, if on primary background: white) it would be the perfect component!
I tried to play with this set of CSS, using mix-blend-mode for toggling the text color automatically, but the results are not satisfying in all cases:

When there is 0/N items
When there is half-n/N items
When there is N/N items

Current behavior

Expected behavior (hard coded, not dynamic, main issue is mix-blend-mode:

For the hard coded values, I used this set of CSS
The only issue is the color of the text that I put in hard coded, I'd like to find a CSS property to make it black/white depending the background, mix-blend-mode attempt fail for me...
Also I had to wrap the value "0/N" in a span and apply the CSS on this span
position: absolute;
left: 50%;
transform: translateX(-50%);
color: black/white; // <---- hard coded

I second this. It is annoying not being able to see the text by default...


The IIS cannot be installed on the windows server

when running the vagrant install, when trying to install the IIS , i get this error message and the script exits:
The Windows feature iis-webserverrole is have been removed from the host and cannot be installed.
Error executing action install on resource 'windows_feature_dism[IIS-WebServerRole]'
can someone help?

I was able to manually install the necessary windows features, but the script fails on downloading Apprenda software, Did you stop supporting this project?


Fix final newline rule and Sass syntax

There was an issue with Sass syntax and final newline rule not working. This PR fixes #273.
DCO 1.1 Signed-off-by: Ben Griffith<EMAIL_ADDRESS>

:+1:


Casting Line-like Curve in LINE for Grasshopper

Line-like Curve object type raise an error in "line.___" components in Grasshopper

281-issue.zip


Users can bypass email verification

The auth/verify/email page includes the user's token in the "click here to resend" link. Users can exploit this by extracting the token from the link and using it to become verified, without ever receiving the verification email. Armed with this knowledge, a bad actor could e.g. write a script to automatically register X number of fake users without going through the email verification process.

Visit the signup page, e.g. https://sveltekit-auth.uv-ray.com/auth/sign-up
Fill in the form, using a fake email address e.g<EMAIL_ADDRESS>When redirected to https://sveltekit-auth.uv-ray.com/auth/verify/email copy the url from the "click here to resend" link
Edit the url to change "resend-email-(token)" to "email-(token)"
Visit the url in your browser and notice that your user is now verified

While that is true... However a user could also create a ton of free accounts that they verify in other automated ways.  For instance with apple or google accounts you can generate email alias addresses that forward to an email address and users could confirm many accounts that way https://www.techlicious.com/blog/gmail-spam-trick-plus-sign/.  If a user wants to create fake accounts, there are lots of ways to do it.  I will look into updating so the token isn't exposed when I get some free time.  If someone wants to submit a PR, I would be happy to take it as I am currently busy with a project.

In case it's helpful, it looks like lucia has a version 2 in beta now along with email login examples for Astro and SvelteKit

I will probably wait until this is released before migrating.  Thanks for the heads up!

fixed.


Compatibility Issue

ERROR: Could not find a version that satisfies the requirement tensorflow==2.12.0. This issue arises as the specified version is exclusively compatible with Python 3.8. Kindly include this information in the project requirements.

I am facing the same issue

Can we use tensor flow 2.13.0?


Compiling a file with just a closing paren crashes the parser

Compiling a file with just a closing paren crashes the parser:
)

> target/debug/fe crash.fe
Warning: bytecode output requires 'solc-backend' feature. Try `cargo build --release --features solc-backend`. Skipping.
thread 'main' panicked at 'attempt to subtract with overflow', parser/src/tokenizer/tokenize.rs:314:25
stack backtrace:
   0: rust_begin_unwind
             at /rustc/c0b64d97beebb09325b5587abed39f4f1621026f/library/std/src/panicking.rs:493:5
   1: core::panicking::panic_fmt
             at /rustc/c0b64d97beebb09325b5587abed39f4f1621026f/library/core/src/panicking.rs:92:14
   2: core::panicking::panic
             at /rustc/c0b64d97beebb09325b5587abed39f4f1621026f/library/core/src/panicking.rs:50:5
   3: fe_parser::tokenizer::tokenize::tokenize
   4: fe_parser::get_parse_tokens
   5: fe_compiler::compile
   6: fe::main
note: Some details are omitted, run with `RUST_BACKTRACE=full` for a verbose backtrace.
Aborted

On latest github master, built with
[profile.dev]
debug = true
panic = "abort"

for fuzzing.  Using https://github.com/agroce/afl-compiler-fuzzer (we've found more than 50 bugs (that were worth fixing, and have been fixed) in solc using this afl variant) + afl.rs.
Not sure if you care about this kind of simple parser bug, but checking what your interest-level in fuzzing-detected bugs might be.

The new parser handles this fine
Unable to compile ../eth/agroce-209.fe.
error: Unmatched right parenthesis
  ┌─ ../eth/agroce-209.fe:1:1
  │
1 │ )
  │ ^

error: failed to parse module
  ┌─ ../eth/agroce-209.fe:1:1
  │
1 │ )
  │ ^ unexpected token
  │
  = Note: expected import, contract, struct, type, or event