support cargo test

Is there any chance we can make cargo test work with our enclave code?
it would be great if we could use standard cargo test. Right now we can only do handmade testing which is a lot less convenient to track
right now we get a clash between std and sgx_tstd:
   Compiling substratee-worker-enclave v0.6.0 (/home/abrenzikofer/substraTEE-worker/enclave)
error: duplicate lang item in crate `std` (which `test` depends on): `f32_runtime`.
  |
  = note: the lang item is first defined in crate `sgx_tstd` (which `substratee_worker_enclave` depends on)

error: duplicate lang item in crate `std` (which `test` depends on): `f64_runtime`.
  |
  = note: the lang item is first defined in crate `sgx_tstd` (which `substratee_worker_enclave` depends on)

error: duplicate lang item in crate `std` (which `test` depends on): `panic_impl`.
  |
  = note: the lang item is first defined in crate `sgx_tstd` (which `substratee_worker_enclave` depends on)

error: duplicate lang item in crate `std` (which `test` depends on): `begin_panic`.
  |
  = note: the lang item is first defined in crate `sgx_tstd` (which `substratee_worker_enclave` depends on)

error: duplicate lang item in crate `std` (which `test` depends on): `oom`.
  |
  = note: the lang item is first defined in crate `sgx_tstd` (which `substratee_worker_enclave` depends on)

error: aborting due to 5 previous errors

error: could not compile `substratee-worker-enclave`.

generally speaking, cargo test collects all #[test]s and creates a binary with a fixed driver and libtest. we don't have chance to change the compiler ad libtest. so the only chance to use cargo test is to test the untrusted app, not the enclave.
good news is that we can use inventory and a proc-macro to implement something very similar to #[test] which collect every test fn pointer (decorated by the customized proc macro attribute) into a static array and then drive these test fn ptrs with our own prebuilt driver. in this way, though we cannot use #[test], we can construct an only with all test fns automatically, and export only 1 ECALL fn for triggering the tests.

though our initial PoC works, it has problem with ld from LLVM9, which optimizes out ctors.
related issues:
https://github.com/mmastrac/rust-ctor/issues/27
https://github.com/mmastrac/rust-ctor/issues/43

this approach is acceptable. important for us is that tests are collected automatically and results are summarized clearly

though our initial PoC works, it has problem with ld from LLVM9, which optimizes out ctors.
related issues:
mmastrac/rust-ctor#27
mmastrac/rust-ctor#43

Regarding the # [ctros] link issue, unused symbols are pruned, even if # [used] is used.
After testing, the following method can be used to temporarily solve this problem:
When linking test-enclave.a in your Makefile, use the whole-archice ld command line option
-Wl,-whole-archive -ltest-enclave -Wl,-no-whole-archive

@brenzi, please refer to this PR (https://github.com/apache/incubator-teaclave/pull/269) on how to use inventory to automatically collect test cases.

@mssun perhaps we could "downport" it to the sdk and make it available to developers like @brenzi

In addition to the automatic collection of test cases, we can also provide a cargo subcommand such as cargo teaclave. When executing cargo teaclave test, it can automatically provide an integration test driver.
The only thing bothers me about "downport" is that the update of SDK requires huge efforts. Test drivers, however, is not as stable as std. A better way is to implement this in the Teaclave platform first and stablize in the SDK when necessary.
In summary, @brenzi, you can simply implement your own test drivers first (similar with https://github.com/apache/incubator-teaclave/pull/269). Then, we can gradually improve the test toolchain in the SDK.


[docs][cli] Educate people on expo-snackify

Where would be the best place to convey to people that they can share their project by running npx expo-snackify?

I would suggest to add one more card into the website next to the other available options.


Python3 support

This adds support for Python3. All tests run successfully.

I'm willing to look into a Python 2 & 3 port. What's the minimum version of Python 2 which must be supported? The job gets substantially easier with only Python 2.6.

I've been writing one here at
https://github.com/gorakhargosh/pyoauth that
should work on Python 2 and 3 starting at
Python 2.5. However, due to the lack of time
these days, I've been unable to work on it
lately.
Have a look if you're interested.
Cheers, =)

@gorakhargosh : I think it makes sense to focus on python-oauth2, because many people are already using it (going by PyPI download counts), and they'll be reluctant to port their code to another OAuth library in order to use Python 3.

@jaitaiwan can you take a look at this? It's related to #158. @hades thanks for the PR! :tada:

@joestump added to the list. I have a feeling that my PR doesn't use the futures lib... but I don't think any others do either. Will continue the chat in #158.

This one fails to work in Pyk2 so I think we may drop it https://travis-ci.org/CentricWebEstate/python-oauth2/jobs/75874253
Thoughts @rickhanlonii @joestump?

Yeah, there are other pk3 wips that are farther along at this point. Thanks for the contribution @hades!


How to actually make shapes?

Thanks for the tutorial!

Bump! How do we actually generate all these path values for morph?
Thanks heap!

I created an SVG path by hand, then took the d variable to use as the value in the string. Here is an SVG path tutorial: http://tutorials.jenkov.com/svg/path-element.html
For morphing to work, each path needs to have the same number of commands (M, a, Q etc), and each command needs to have the same number of variables. Unfortunately I don't know any tools that generates that for you.

I think you can convert SVG files to Android VectorDrawable files using online tools, like this one:
http://inloop.github.io/svg2android/


⚠ ClamAV has degraded performance

In 0de4dcc, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 112 ms

Resolved: ClamAV performance has improved in 9461d4e.


injected history has isActive but default history don't

when I access this.props.history it has the isActive method, but when I access history right after createBrowserHistory() it doesn't have the same method. Am I doing something wrong?

Thanks for your question!
We want to make sure that the GitHub issue tracker remains the best place to track bug reports and feature requests that affect the development of History.
Questions like yours deserve a purpose-built Q&A forum. Would you like to post this question to Stack Overflow with the tag #react-router? https://stackoverflow.com/questions/ask?tags=react-router.
We also have an active and helpful React Router community on Reactiflux, which is a great place to get fast help with History and with the rest of the React ecosystem. You can join at https://discord.gg/0ZcbPKXt5bYaNQ46.


[video_player] Fix race condition on disposing the VideoController.

Description
After, or while in process of, disposing the VideoController, the bufferingUpdate is still being fired which causes the ChangeNotifier._debugAssertNotDisposed to fail.
I am adding the verification of the _dispose flag before  applying any change to the value variable.
Related Issues
flutter/flutter#25936
flutter/flutter#30238
Checklist

[x] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[ ] My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
[x] All existing and new tests are passing.
[ ] I updated/added relevant documentation (doc comments with ///).
[x] The analyzer (flutter analyze) does not report any problems on my PR.
[x] I read and followed the Flutter Style Guide.
[x] The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
[x] I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
[x] I updated CHANGELOG.md to add a description of the change.
[x] I signed the CLA.
[x] I am willing to follow-up on review comments in a timely manner.

Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?

[x] No, this is not a breaking change.

Hi, thanks for your contribution.
I don't think this addresses https://github.com/flutter/flutter/issues/30238, could you please remove that from your related issues please.
Could you also update the version number, thanks!

@iskakaushik done.

We made a commercial app with Flutter that has thousands of users which is using video controller plugin. It would be perfect if this PR was accepted. So we won't have to use our fork. Thanks for PR and also effort of Flutter team!


Node.js version : e.g. 16.13.1
suitecloud-cli version : 1.3.2
Terminal/CMD tool :  WSL in VSCode
Describe the bug
Using VSCode + WSL, trying to add a new account via browser session goes nowhere. It seems like it's trying to launch the browser in WSL which won't work (no GUI)
To Reproduce
Steps to reproduce the behavior:

Open a WSL based project in VSCode
attempt to "SuiteCloud:  Setup Account"

Actual Behavior
Step 2 fails. Eventually with an error like
Can't connect to X11 window server using '<IP_ADDRESS>:0' as the value of the DISPLAY variable.

Expected Behavior
Use the existing Windows browser session to setup account.

@ShawnTalbert We don't support WSL officially.
I think WSL doesn't support browser by default. You can check some solutions to use browser in WSL mentioned in this article

I don't see why WSL should be involved here?
If webstorm is running in windows, can it not launch a windows browser?


ApiError on init

🐛 Bug Report
upon installation of the cli, when first trying to preview a project, the only feedback is
Error: [ApiError { code: 10000, message: "Authentication error", other: {} }]
Environment

operating system: MacOs Mojave 10.14.6
output of rustc -V:
output of node -v: v12.9.0
output of wrangler -V: 1.4.0

Steps to reproduce
yarn global add @cloudflare/wrangler
wrangler config

add the cloudflare email, and a token from the workers template with the following permissions
Account.Workers KV Storage, Account.Workers Scripts, Zone.Workers Routes
on an exisiting gatsby js site run
wrangler init --site my_site
output
❯ wrangler init --site sassy_technology
✨  Succesfully created a `wrangler.toml`
⬇ Installing cargo-generate...
🌀  🐑  Generating a new webpack worker project with name 'workers-site'...
🔧   Creating project called `workers-site`...
Removed: "/Users/raphael/Documents/Projects/javascript/gatsby-starter-mate/workers-site/.genignore"
Removed: "/Users/raphael/Documents/Projects/javascript/gatsby-starter-mate/workers-site/LICENSE_MIT"
Removed: "/Users/raphael/Documents/Projects/javascript/gatsby-starter-mate/workers-site/LICENSE_APACHE"
✨   Done! New project created /Users/raphael/Documents/Projects/javascript/gatsby-starter-mate/workers-site

edit the wrangler.toml fille

add your account_id
add bucket = "./public"

when trying to preview with
wrangler preview --watch
the error appears.
additional information
not really sure how to debug
output of wrangler whoami
💁  👋  You are logged in with the email<EMAIL_ADDRESS>I'm not the only one experiencing the issue
https://community.cloudflare.com/t/apierror-code-10000-message-authentication-error-other/117711/4
What did you expect to see?
something a little more informative. I'm not sure what to do next
What did you see instead?
an information message with no clear steps to resolve

hi @happysalada ! sorry you are running into this issue. i believe this error would mean that you have configured wrangler incorrectly- which means that either you Global API key, email address, or both were incorrect when you run wrangler config.
2 commons issues are using an API token instead of your Global API key, or having changed your email recently. can you run wrangler config again ensuring you use the correct values?
i definitely agree the error message could be made better! we'll look into fixing it!

The api key was the problem! My bad.
Thanks for the thoughtful reply.

I'm getting this error even with my global API key. Additionally, wrangler dev returns
Error: Could not upload your script. Check your internet connection or https://www.cloudflarestatus.com/ for rare incidents impacting the Cloudflare Workers API.


Messenger on non routed messages

Hello,
I just found this library which may feet our needs and usable with your browser and foundry library which we already like :slightly_smiling_face:
We are using the messenger with async message and also messages which are not routed. Is there a way to handle them with this library? As there is no transport, I have a doubt but we can't route all of our message and most of them must be kept synchronous.
Maybe you can give me an advice on how I can test my message is dispatched by my controller? I didn't find a solution except by using the profiler but it might not be the better solution, isn't it?
Thanks

Indeed I meant the default sync handling, messages which are not listed in framework.messenger.routing configuration.
I can test the effect but sometimes they are a bit hard and the better alternative would be some unit tests on the handler.
If the only way is to define a sync transport and list all of my messages I will try to test the effect (mainly check if entity is in the db or not)
Thanks

I think a common pattern is to make Sync and Async interfaces and all your messages implement one or the other. In your routing, send Sync messages to the sync transport and Async messages to the async transport. If you did this, you could use the library the way you want.

Got it. One solution I'm thinking of is for this library to provide a MessageBus decorator for each defined bus (very similar to TraceableMessageBus that the profiler uses). You could use this to inspect the dispatched messages in your tests. I'm just not sure how something like this would fit int the current API without being confusing.

Yes, that's what I was thinking of too: defining a custom message bus in services_test.yaml to be able to trace this messages and being able to retrieve it from the test self::getContainer()->get(TestMessageBus::class)->getMessages().
This is what a colleagues is doing in his tests. Something like that.
But if there is a solution to prevent the manual definition of such service, it would be great :grinning:

Yes, using the bus could open more possibilities I think than using the messenger.
Transport should indeed not be lost. I have no idea of use case as I am not using the messenger with this need of low level but I have the feeling it would be still needed. :-)
I think it makes more sense too (to query the bes instead of messenger as the method name suggests) as the configuration on symfony defines two things : transport and buses. :tada:
Thank you for this exchanges, very valuable and rewarding :-)

I believe this was solved with #54.

Yes. I thought it would have been closed automatically.
Thank you.


Using new CMake FindCUDA elements

Hi Soumith,
I am getiing arch portion of FindCUDA into CMake, here:
https://github.com/Kitware/CMake/pull/237.
With this change, I would finally be able to drop my cutorch clone as it would work with or without new bits of FindCUDA installed.

Thanks!


Add Pipelines class which encapsulates internal data transformations

This PR adds a Pipelines class which can be used as a standalone component to encapsulate data pipelines consisting of Source, Filter and Transform components. Internally this class is used to manage the data transformations that drive View components thereby introducing a better separation of concerns between the Target objects, the View components and the actual data transformations that occur.

Codecov Report

Merging #291 (794a157) into master (079e42d) will increase coverage by 0.34%.
The diff coverage is 76.15%.

@@            Coverage Diff             @@
##           master     #291      +/-   ##
==========================================
+ Coverage   65.35%   65.70%   +0.34%
==========================================
  Files          57       58       +1
  Lines        5779     5960     +181
==========================================
+ Hits         3777     3916     +139
- Misses       2002     2044      +42

Impacted Files
Coverage Δ

lumen/state.py
73.37% <70.00%> (-0.24%)
:arrow_down:

lumen/pipeline.py
70.27% <70.27%> (ø)

lumen/dashboard.py
77.45% <71.42%> (-1.16%)
:arrow_down:

lumen/target.py
78.08% <78.26%> (+2.01%)
:arrow_up:

lumen/views/base.py
62.50% <82.69%> (-0.83%)
:arrow_down:

lumen/base.py
94.11% <100.00%> (ø)

lumen/tests/test_dashboard.py
100.00% <100.00%> (ø)

lumen/tests/test_target.py
100.00% <100.00%> (ø)

lumen/tests/views/test_base.py
100.00% <100.00%> (ø)

... and 4 more

Help us with your feedback. Take ten seconds to tell us how you rate us.


How do i like a song?

Hi @teaminkling, its really good looking app and written clean. It would be nice to draw a like/heart button on main window.

Hi @msudgh, thanks for the patience. You can like a song with the + button at the bottom right of the mini-player. Clicking on "Save to Your Library" should be the same as liking the song.

@paced Thanks for respond


Fix up ipcache access in datapath

This PR replaces the ipcache_lookup46 with lookup_ip[46]_remote_endpoint()
where the older kernel does not support it.
Fixes: #11351
Signed-off-by: Swaminathan Vasudevan<EMAIL_ADDRESS>

Coverage increased (+0.004%) to 38.026% when pulling 45708686dbad76675d32a0d7e5b027c9619f839b on soumynathan:fix-up-ipcache-access-datapath into a7ec82ee7e803411daf3adfcc5b5ae921ece13c2 on cilium:master.

test-me-please

retest-4.19

retest-4.19

retest-runtime

retest-4.9

retest-4.9

retest-runtime

Runtime-4.9 hit only known flake #11512. This is good to merge.


Set procs to recompile to avoid plan cache noise

Hi Ola,
We do this across the Blitz* scripts:
ALTER PROCEDURE [dbo].[sp_Blitz]
    @Help TINYINT = 0 ,
...
WITH RECOMPILE
AS

Which helps us to avoid interfering in anyone's plan cache, or one of our procs being detected by... well, another one of our procs. Heh.
This would cover all the non-dynamic SQL statements in your procs, but the dynamic bits would (I believe) need recompile hints individually.
On the plus side, the only one I've seen cause any kind of resource consumption is the call to sys.dm_db_index_physical_stats in dbo.IndexOptimize.
Low priority, but I appreciate your time.
Thanks,
Erik

Thank you for the suggestion.
For statements in my stored procedures that are executed many times (in while loops) the plan caching is important for performance.
I know that from looking at the performance of the stored procedure for customers with large number of databases on a server, or large number of objects in a database.

Ah, okay, thanks. Makes sense.
Erik


var name disables autocomplete

From @svipben on May 23, 2018 8:17

VSCode Version: 1.23
OS Version: macOS

Very weird behavior.
class Application {
  constructor() {
    this.cache = {};
  }
  log() {}
}

const name = new Application();
name. // no autocompletion for cache and log

If call my var name autocomplete disappears. But if I for e.g. call it app it works.

Copied from original issue: Microsoft/vscode#50330

From @svipben on May 23, 2018 8:19
Found another one problem.

I believe there's something wrong with built-in methods and that's why this problem occurs. Because name and length are mostly native/built-in

From @svipben on May 23, 2018 8:20
This happens with JavaScript and TypeScript.

Tested in<EMAIL_ADDRESS>The problem is that name and length are being resolved to the ES d.ts file instead of the local declaration

The variables name and length exist because they are properties of the global object, window.

In a downleveled environment, which is what we assume, that const will be a var and merge with the global value


Port qoqo/examples from qoqo_pyquest to qoqo_quest

The new Backend from qoqo_quest is used in the qoqo/examples now. Also documentation (README etc.) has been adapted.

Codecov Report

Merging #158 (c9d1904) into main (42fe74a) will increase coverage by 0.95%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #158      +/-   ##
==========================================
+ Coverage   90.11%   91.07%   +0.95%
==========================================
  Files          33       17      -16
  Lines        5050     3248    -1802
==========================================
- Hits         4551     2958    -1593
+ Misses        499      290     -209

Flag
Coverage Δ

unittests
91.07% <ø> (+0.95%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

roqoqo/src/backends.rs
61.90% <ø> (ø)

qoqo/src/operations/pragma_operations.rs

qoqo/src/lib.rs

qoqo/src/quantum_program.rs

qoqo/src/operations/multi_qubit_gate_operations.rs

...c/measurements/measurement_auxiliary_data_input.rs

...measurements/cheated_basis_rotation_measurement.rs

qoqo/src/operations/two_qubit_gate_operations.rs

qoqo/src/measurements/cheated_measurement.rs

qoqo/src/operations/measurement_operations.rs

... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 42fe74a...c9d1904. Read the comment docs.


Minor Subtitle Issues

Minor issue:

Cannot download "automatically generated" English subtitles (same key as "normal ones")

"Kind of" more important:

Caption 'lang' is in Finnish (I access YouTube from Finland)

Replicate:
On a video that has captions, from an IP geolocated "not in English-speaking countries" (and localized)
[...]
pprint(yt.captions.all())
[...]

I see
[
,

,

,

,

,

,

,

,

,

,

,

,

,

,

,

,

,

]

. Is that not English?

Yes it is. "But so are these:"
,

Ahh, so you can't download
. Can you select that option in a browser?

So does calling captions[1].xml_captions return None?

Oops! I didn't think of that :/ My bad
Yes, it does
>>> with open('desktop/test.xml', 'w') as f:
...     f.write(yt.captions.all()[1].xml_captions)
...
69637

>>> with open('desktop/test.xml', 'w') as f:
...     f.write(yt.captions.all()[2].xml_captions)
...
33621

For automatic captions, it's possible that you'd like to remove all: ,  (since automatic subtitles gradually appear in gray and later in time they become white as the speaker continues)
Example
2
000:000:10,160 --> 000:000:18,920
bigger welcome hello San Francisco TEDx

3
000:000:15,620 --> 000:000:23,900
oh my god blinding light hi everybody

Feel free to handle (or not) the ticket as you which. 😄

This issue is annoying cause I can't reproduce of course! What's the value of the Caption's attribute url? Might as well tell me the non auto generated English subtitle url to.

tl;dr: auto-generated have the kind=asr key
Auto-generated: https://www.youtube.com/api/timedtext?sparams=asr_langs%2Ccaps%2Cv%2Cxorp%2Cexpire&expire=1530420386&caps=asr&hl=fi_FI&signature=BF5729C2A51E334A03B65A32240A2C945B564D0D.51EB8F6F32C3A694F243F1FA21D6EBF40106030E&key=yttt1&asr_langs=es%2Cru%2Cnl%2Cpt%2Cde%2Cko%2Cit%2Cen%2Cja%2Cfr&v=some-id&xorp=True&kind=asr&lang=en
Engish: https://www.youtube.com/api/timedtext?sparams=asr_langs%2Ccaps%2Cv%2Cxorp%2Cexpire&expire=1530420386&caps=asr&hl=fi_FI&signature=BF5729C2A51E334A03B65A32240A2C945B564D0D.51EB8F6F32C3A694F243F1FA21D6EBF40106030E&key=yttt1&asr_langs=es%2Cru%2Cnl%2Cpt%2Cde%2Cko%2Cit%2Cen%2Cja%2Cfr&v=some-id&xorp=True&lang=en

Is it possible to add functionality for getting auto generated subtitles for language, that not presented in Captions?


Fixes #85032 TreeItem.get_prev_visible and TreeItem.get_prev_in_tree no longer returns null when wrap is true

fixes #85032
TreeItem.get_prev_visible and TreeItem.get_prev_in_tree don't return null anymore when setting wrap to true.
I have compiled the code and it works.
Here is a test. make sure to select one of the items before pressing the button. if the first item selected is root it will return null.
otherwise pressing the button while an item is selected will allow to navigate through the TreeItems indefinitely, mimicking the behaviour of TreeItem.get_next_visible and TreeItem.get_next_in_tree.
TestTree.zip

You should target master not 4.1, changes can then be cherry picked.
If you need more information about the update process please see: PR Workflow - Updating your branch. If wanted I can fix the branch for you.

Rebasing on master and force-pushing should fix it.
But generally changing branches means review spam as seen above and I don't think it can be avoided (now it's too late anyway, so could as well finish it).

@Jesusemora if you don't have time to try rebase and force-push as was recommended by @KoBeWi, I can do it for you if GitHub access and permissions let me. If that is not possible, I can create a new PR with this changes and try to add you as author.

This PR has been inactive for a year. Feel free to open a new one at this point.

Here is the PR with the fix code and some new unit tests added by me

Superseded by #97157
Thanks for the contribution nonetheless.


MutationObserver error in IE10

C3 Graphs shows an MutationObserver error in IE10

Does this still exists?
Do not have IE to verify that it does.

closing for inactivity.


[cppumock] onobject for const-methods

Hi
How can I use the onObject(void *) method from MockActualCall inside const-methods?
Here the this pointer points to a const object, thus I cannot give the this pointer to the onObject method.
Code example:
virtual bool isSetting(std::string const &rKey) const
{
  mock().actualCall("IDatabaseMock::isSetting").onObject(this).withStringParameter("rKey", Key.c_str());

  return mock().returnIntValueOrDefault((int)false) ? true : false;
}

(This example does not compile, since the this pointer points to a constant object, but onObject expects a pointer to a non-const object.)
Is there another method?
Best regards

It's not perfect, but you can use withConstPointerParameter("this", this)
instead.
Ryan
On Sat, Dec 5, 2015 at 10:23 AM, ZahlGraf<EMAIL_ADDRESS>wrote:

Hi
How can I use the onObject(void *) method from MockActualCall inside
const-methods?
Here the this pointer points to a const object, thus I cannot give the
this pointer to the onObject method.
Code example:
virtual bool isSetting(std::string const &rKey) const
{
mock().actualCall("IDatabaseMock::isSetting").onObject(this).withStringParameter("rKey", Key.c_str());
return mock().returnIntValueOrDefault((int)false) ? true : false;
}
(This example does not compile, since the this pointer points to a
constant object, but onObject expects a pointer to a non-const object.)
Is there another method?
Best regards
—
Reply to this email directly or view it on GitHub
https://github.com/cpputest/cpputest/issues/803.

@ryanplusplus
Thanks, that sounds like a quite nice workaround :)
I will give it a try...

I usually use const_cast<type *>(this).
@basvodde Is there a reason onObject doesn't just take const void *?  I'm not too familiar off the top of my head with the internals of CppUMock, so I don't know if the stored pointer needs to be non-const for a reason or not.  I wouldn't think it needs to modify the class at all though (especially since it's a void *), so it seems like that would work ok.

@Andne
Yes having a onObject that can take a const void* would be the best solution. Hopefully we can get it in one of the next releases.

I can't think of a good reason @Andne

Seems this is done already, closing it.


transport.produce() failed with exception: json.exception.type_error.302 with v3.4.0

Whenever calling:
Producer producer = transport.produce(this, track, null, null, "{"type":"microphone","paused":0}");
I get an error:
[json.exception.type_error.302] type must be string, but is number
If I set "paused":"0" I get another json.exception.type_error.302 about an empty array (!?)
I'm getting a similar error for video where the codec options are {"videoGoogleStartBitrate":1000} and appData is {"type":"camera","deviceId":"1","paused":0}
With mediasoup-client:3.4.0
implementation 'io.github.haiyangwu:mediasoup-client:3.4.0'

public Producer produce(
Producer.Listener listener,
MediaStreamTrack track,
List<RtpParameters.Encoding> encodings,
String codecOptions,
String codec,
String appData)
The fifth parameter is codec which was added in this version.
On Wed, Jan 4, 2023 at 12:10 AM grebulon @.***> wrote:

Whenever calling:
Producer producer = transport.produce(this, track, null, null,
"{"type":"microphone","paused":0}");
I get an error:
[json.exception.type_error.302] type must be string, but is number
If I set "paused":"0" I get another json.exception.type_error.302 about
an empty array (!?)
I'm getting a similar error for video where the codec options are
{"videoGoogleStartBitrate":1000} and appData is
{"type":"camera","deviceId":"1","paused":0}
With mediasoup-client:3.4.0
implementation 'io.github.haiyangwu:mediasoup-client:3.4.0'
—
Reply to this email directly, view it on GitHub
https://github.com/haiyangwu/mediasoup-client-android/issues/65, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AAOBOGWGC55D4SEFGD2IWDDWQRFQ5ANCNFSM6AAAAAATP3B62U
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

--
Haiyang Wu
@.***>

The fifth parameter is codec which was added in this version.

It think that if you change function prototypes, it's better to make it in a way that will break compilation, so that it will be more visible.
Thank you for the quick response and for the work that you put into this 🙏

It's a good point, I'll make this change in the next version.
On Wed, Jan 4, 2023 at 6:30 PM grebulon @.***> wrote:

The fifth parameter is codec which was added in this version.
It think that if you change function prototypes, it's better to make it in
a way that will break compilation, so that it will be more visible.
Thank you for the quick response and for the work that you put into this
🙏
—
Reply to this email directly, view it on GitHub
https://github.com/haiyangwu/mediasoup-client-android/issues/65#issuecomment-1370748849,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAOBOGRBZNJRD3B5HKCMKZTWQVGLTANCNFSM6AAAAAATP3B62U
.
You are receiving this because you modified the open/close state.Message
ID: @.***>

--
Haiyang Wu
@.***>


trouble with mri_convert

Hi,
ciftify gives me the following error:
/Users/neurolab/opt/anaconda3/lib/python3.7/site-packages/ciftify/utils.py:286: YAMLLoadWarning: calling yaml.load() without Loader=... is deprecated, as the default Loader is unsafe. Please read https://msg.pyyaml.org/load for full details.
config = yaml.load(yaml_stream)
dyld: lazy symbol binding failed: Symbol not found: ___emutls_get_address
Referenced from: //Users/neurolab/Desktop/Stephan/Programmes/freesurfer/bin/../lib/gcc/lib/libgomp.1.dylib
Expected in: /usr/lib/libSystem.B.dylib
dyld: Symbol not found: ___emutls_get_address
Referenced from: //Users/neurolab/Desktop/Stephan/Programmes/freesurfer/bin/../lib/gcc/lib/libgomp.1.dylib
Expected in: /usr/lib/libSystem.B.dylib
Traceback (most recent call last):
File "/Users/neurolab/opt/anaconda3/bin/ciftify_recon_all", line 8, in
sys.exit(main())
File "/Users/neurolab/opt/anaconda3/lib/python3.7/site-packages/ciftify/bin/ciftify_recon_all.py", line 1436, in main
run_ciftify_recon_all(tmpdir, settings)
File "/Users/neurolab/opt/anaconda3/lib/python3.7/site-packages/ciftify/bin/ciftify_recon_all.py", line 125, in run_ciftify_recon_all
settings.registration, temp_dir)
File "/Users/neurolab/opt/anaconda3/lib/python3.7/site-packages/ciftify/bin/ciftify_recon_all.py", line 683, in convert_FS_surfaces_to_gifti
write_cras_file(freesurfer_subject_dir, cras_mat)
File "/Users/neurolab/opt/anaconda3/lib/python3.7/site-packages/ciftify/bin/ciftify_recon_all.py", line 707, in write_cras_file
'brain.finalsurfs.mgz')])
File "/Users/neurolab/opt/anaconda3/lib/python3.7/site-packages/ciftify/utils.py", line 442, in get_stdout
stdout = subprocess.check_output(cmd_list)
File "/Users/neurolab/opt/anaconda3/lib/python3.7/subprocess.py", line 411, in check_output
**kwargs).stdout
File "/Users/neurolab/opt/anaconda3/lib/python3.7/subprocess.py", line 512, in run
output=stdout, stderr=stderr)
subprocess.CalledProcessError: Command '['mri_info', '/Users/neurolab/Desktop/Stephan/Oncology/Data/Recon/Sub0002_Ses1_Scan_01_ANAT1.gz/mri/brain.finalsurfs.mgz']' died with <Signals.SIGABRT: 6>.
When I try manually in the terminal mri_convert /Users/neurolab/Desktop/Stephan/Oncology/Data/Recon/Sub0002_Ses1_Scan_01_ANAT1.gz/mri/brain.finalsurfs.mgz
it does not give me any error.
Anyone an idea?
Thanks a lot.
Stephan

what happens when you try mri_info /Users/neurolab/Desktop/Stephan/Oncology/Data/Recon/Sub0002_Ses1_Scan_01_ANAT1.gz/mri/brain.finalsurfs.mgz ?

gives me all the information:
type: MGH
dimensions: 256 x 256 x 256
voxel sizes: 1.000000, 1.000000, 1.000000
type: UCHAR (0)
fov: 256.000
dof: 0
xstart: -128.0, xend: 128.0
ystart: -128.0, yend: 128.0
zstart: -128.0, zend: 128.0
TR: 2200.00 msec, TE: 0.00 msec, TI: 0.00 msec, flip angle: 0.00 degrees
nframes: 1
PhEncDir: UNKNOWN
FieldStrength: 0.000000
ras xform present
xform info: x_r =  -1.0000, y_r =   0.0000, z_r =   0.0000, c_r =     6.0030
: x_a =   0.0000, y_a =  -0.0000, z_a =   1.0000, c_a =    24.8667
: x_s =   0.0000, y_s =  -1.0000, z_s =  -0.0000, c_s =   -16.3771
talairach xfm : /Users/neurolab/Desktop/Stephan/Oncology/Data/Recon/Sub0002_Ses1_Scan_01_ANAT1.gz/mri/transforms/talairach.xfm
Orientation   : LIA
Primary Slice Direction: coronal
voxel to ras transform:
-1.0000   0.0000   0.0000   134.0030
0.0000  -0.0000   1.0000  -103.1333
0.0000  -1.0000  -0.0000   111.6229
0.0000   0.0000   0.0000     1.0000
voxel-to-ras determinant -1
ras to voxel transform:
-1.0000   0.0000  -0.0000   134.0030
-0.0000  -0.0000  -1.0000   111.6229
0.0000   1.0000  -0.0000   103.1333
-0.0000  -0.0000  -0.0000     1.0000

stack overflow says it might indicate a memory error - were you maybe running any other programs at the same time as ciftify? Can you replicate the error if you run ciftify by itself (i.e. with little/no other programs running)?

Dear all,
I am running the ciftify_recon_all command on a MBP 2019 with Catalina.
It works, when I type in the command (in my terminal) for every subject such as:
ciftify_recon_all --ciftify-work-dir /Users/neurolab/Desktop/Stephan/Oncology/Data/HCP --fs-subjects-dir /Users/neurolab/Desktop/Stephan/Oncology/Data/Recon Sub0001_Ses1_Scan_01_ANAT1.gz
but when I use a loop(in a zsh terminal) for all my subjects I receive the error below:

#!/bin/csh

set count = 3
set stop = 100

set att_file = /Users/neurolab/Desktop/Stephan/Oncology/Data/Recon/list.txt

while($count <= $stop)
set sub = `head -n $count $att_file | tail -n 1 | awk '{print $1}'`

echo %%-------------------------${count}--------------------------${sub}----------------------------

echo $sub

ciftify_recon_all --ciftify-work-dir /Users/neurolab/Desktop/Stephan/Oncology/Data/HCP --fs-subjects-dir /Users/neurolab/Desktop/Stephan/Oncology/Data/Recon $sub

@ count = $count + 1

end

/Users/neurolab/opt/anaconda3/lib/python3.7/site-packages/ciftify/utils.py:286: YAMLLoadWarning: calling yaml.load() without Loader=... is deprecated, as the default Loader is unsafe. Please read https://msg.pyyaml.org/load for full details.
  config = yaml.load(yaml_stream)
dyld: lazy symbol binding failed: Symbol not found: ___emutls_get_address
  Referenced from: //Users/neurolab/Desktop/Stephan/Programmes/freesurfer/bin/../lib/gcc/lib/libgomp.1.dylib
  Expected in: /usr/lib/libSystem.B.dylib

dyld: Symbol not found: ___emutls_get_address
  Referenced from: //Users/neurolab/Desktop/Stephan/Programmes/freesurfer/bin/../lib/gcc/lib/libgomp.1.dylib
  Expected in: /usr/lib/libSystem.B.dylib

Traceback (most recent call last):
  File "/Users/neurolab/opt/anaconda3/bin/ciftify_recon_all", line 8, in <module>
    sys.exit(main())
  File "/Users/neurolab/opt/anaconda3/lib/python3.7/site-packages/ciftify/bin/ciftify_recon_all.py", line 1436, in main
    run_ciftify_recon_all(tmpdir, settings)
  File "/Users/neurolab/opt/anaconda3/lib/python3.7/site-packages/ciftify/bin/ciftify_recon_all.py", line 125, in run_ciftify_recon_all
    settings.registration, temp_dir)
  File "/Users/neurolab/opt/anaconda3/lib/python3.7/site-packages/ciftify/bin/ciftify_recon_all.py", line 683, in convert_FS_surfaces_to_gifti
    write_cras_file(freesurfer_subject_dir, cras_mat)
  File "/Users/neurolab/opt/anaconda3/lib/python3.7/site-packages/ciftify/bin/ciftify_recon_all.py", line 707, in write_cras_file
    'brain.finalsurfs.mgz')])
  File "/Users/neurolab/opt/anaconda3/lib/python3.7/site-packages/ciftify/utils.py", line 442, in get_stdout
    stdout = subprocess.check_output(cmd_list)
  File "/Users/neurolab/opt/anaconda3/lib/python3.7/subprocess.py", line 411, in check_output
    **kwargs).stdout
  File "/Users/neurolab/opt/anaconda3/lib/python3.7/subprocess.py", line 512, in run
    output=stdout, stderr=stderr)
subprocess.CalledProcessError: Command '['mri_info', '/Users/neurolab/Desktop/Stephan/Oncology/Data/Recon/Sub0014_Ses1_Scan_01_ANAT1.gz/mri/brain.finalsurfs.mgz']' died with <Signals.SIGABRT: 6>.

The process never uses all of my memory. But I think the same error comes up when I run ciftify with some other programmes.
But running the loop alone also brings up the same error.


Don't hide when the main window is closed

This is one of the first things I noticed when I started using Radiant. I've never seen an OS X app hide itself when you close its main window, and the behavior was pretty surprising! I hope to make more substantial contributions in the future :notes:.

Awesome, thanks!

I don't see a difference. Out of interest, what has this changed?

Before this patch, closing the main window "hid" Radiant as if you'd pressed command+H. The two main effects of hiding are…

Radiant stops being the "active" application. Whichever app was previously active takes menu bar and keyboard focus.
Any other windows (like the Preferences window, if it's open) become invisible until you switch back to Radiant.

It's interesting behavior, since a lot of the time when you close the main window you probably want to use another application, but it's pretty nonstandard and was confusing to me since I use the keyboard a lot (and would expect to be able to give keyboard input to Radiant after closing the main window or to switch to a specific app with command+tab).
Hope that made sense! Let me know if it didn't.

Ah OK I get it. Good spot, I'd never even noticed that before :-)


Should stop sending global settings and keybindings via IPC

Instead we should have a way to instantiate these settings on the renderer side (including watching).

@joaomoreno cc

I created the NodeConfigurationService which should serve as a stepping stone for this. Any environment with node access should be able to instantiate one of these guys, which listens on changes to the global settings. We then can compose it with another guy which listens on changes to the local workspace settings. Reusability is key here.

Louis <3


no way to run the delete command quietly

I'd like to run the delete command with a -no-prompt flag, but that is not available so I don't believe there is a way to run deletes (skipping the trash) via a script.

--quiet
heh. it's there.

Hello @ryansinn thanks for the question and welcome to drive!
Cool that you solved it yourself, cheers!

Thanks for the response!
It would be helpful if the documentation stated what switches are supported for all the commands.
Sorry, I didn't think to try it before I opened the ticket -- I was already deep into the other ticket issue when I hit a snag with the prompts issued by the delete command when trying to create a solution that would allow the manipulation (specifically for me, the deletion (skipping the trash)) of files on google drive without having to sync the files to the local system (because in my case the files originated from the local system, so they're already there.   Trying to use Google Drives to store server data backups in the cloud -- might be using the wrong solution for the job ;)


[Bug]: There are two sets of descriptions when hovering over a function call expression

Description
When hovering over a documented function call expression, it generates two duplicated sets of descriptions in the same window, as shown below.

Steps to Reproduce
Hover over the function call expression in the following Ballerina code.

# Description.
#
# + param - parameter description
# + return - return value description
function name(string param) returns string {
    return "hello";
};

public function main() {
    _ = na<cursor>me("hello");
}

Affected Version(s)
Ballerina 2201.8.3 (Swan Lake Update 8)
OS, DB, other environment details and versions
OS: macOS 14.1.2 23B92
JDK: openjdk 17.0.8 2023-07-18
Related area
-> Compilation
Related issue(s) (optional)
No response
Suggested label(s) (optional)
No response
Suggested assignee(s) (optional)
No response

This will be fixed with https://github.com/ballerina-platform/ballerina-lang/pull/41773. @nipunayf can you verify?

The problem occurs in a specific scenario that contains a series of single file projects and cannot be reproduced when attempting to isolate the problem.


Remove "debug" when submit charts.

The ACTIONS_RUNNER_DEBUG is not defined in the setting.
And in this PR of github-script, it replaced getInput("debug") with getBooleanInput("debug") which can't handle undefined.
https://github.com/actions/github-script/commit/8d9f8fc050d038eac46e34e317ca8dc9b3a83e71#diff-4fab5baaca5c14d2de62d8d2fceef376ddddcc8e9509d86cfa5643f51b89ce3d
That is why we have error:
TypeError: Input does not meet YAML 1.2 "Core Schema" specification: debug
Error: Unhandled error: TypeError: Input does not meet YAML 1.2 "Core Schema" specification: debug
Support boolean input list: `true | True | TRUE | false | False | FALSE`

/assign @qiujian16

/approve
/lgtm


Migrate s2n_hash implementations to OpenSSL EVP_Digest

Currently, s2n_hash directly uses the OpenSSL hash implementations. As per OpenSSL's API documentation, "Applications should use the higher level functions EVP_DigestInit etc. instead of calling the hash functions directly". The migration to the EVP_Digest implementations will also be a prerequisite for FIPS compliance.

I have some work-in-progress changes in my private evp_hash branch. Currently, these changes pass our integration tests but there are still some fuzz failures that I am looking into and the changes to s2n_hash are causing our HMAC SAW tests to fail.
@atomb , @ntc2 , or @jldodds - would you be able to provide any guidance on what changes are needed to the HMAC.saw spec based on these s2n_hash changes? I wasn't able to find much in the form of SAW documentation. Here are the failing SAW tests.

If it can wait until then, I can probably look into this next week.

@atomb - that would be great, thanks.

I've taken a more careful look at this, and the bottom line is that getting this working is going to require support in SAW for pointers to opaque types (specifically, struct types declared but not defined in the LLVM file being processed). We've hacked around this in the past, but I think it's time for a proper solution.
The good news is that I think there's a good chance that we may be able to implement this in SAW in the near future. And, on top of that, I think it'll clean up the proof scripts significantly. But the necessary features aren't in place quite yet.

@atomb Do you have any status updates on SAW support for opaque structs? The change in question for this issue is nearly ready for a PR (I can send an updated remote branch for you to follow along if you're interested) and we would like to avoid working on a hacked work around for OpenSSL's 1.1.0 EVP_MD_CTX opaque struct.

Most of the features are now in place to at least do an initial version of the proof, and I have a draft of the modifications locally. We need to make a couple more small changes before it'll fully go through, though.

@bpdavidson Yes, it would be helpful if you could send me a pointer to an updated remote branch. The branch I was looking at doesn't seem to exist any more.

@atomb - sorry for the delay. Here's an updated work-in-progress commit. The plan is now to use the opaque EVP message digest API's only for FIPS mode at the moment as they internally dynamically allocate memory on the request path.

The latest code structure brings up some interesting questions. Because it has the option to retain essentially the old underlying API, we could get the proof to work again by making just a minor adjustment, but that would only cover the case where it's being used in the old mode and wouldn't prove anything about EVP-based use. However, it would allow Travis builds to succeed, which could be the key goal for now. When it comes to the EVP-based mode, it looks as though we have roughly the right features in SAW now to make it possible to prove it, but the code is different enough from the original that I think it'll be a non-trivial amount of effort (partly because the proof will need to be ported to a new proof script interface to take advantage of some of the new features).
Does anyone have thoughts about whether it's higher priority to get the whole thing working now, or to just get a proof equivalent to the old one working so that CI succeeds?

These changes have been merged into awslabs:feature/fips in PR #529. Once PR #555 is merged into awslabs:feature/fips, awslabs:feature/fips can be merged into awslabs:master and this issue can be closed.

Resolved: awslabs:feature/fips has been merged into awslabs:master


"No response" after running about several days

hardware: Raspberry Pi 3B
homebridge version: 0.4.22
nodejs version: 6.11.2
iOS version: 10.3.2
We implemented a platform plugin(as a bridge) that communicate our original lighting control through serialport. There are dozens of accessories in bridge.  System runs well and Home App control is also well. But after several days, all accessories icon in Home App display "No Response".  It cannot be recovered by restarting  Raspberry Pi, Home App or my iPad.  Surely to change username in config.json and delete persist/* files can recovery it.
It perhaps stuck somehow(reference in common issues of README.md). But we hope our product could be stable because it is planning to sale. Could anybody know the real reason and how to solve it?

I have the same issue,
By the way, are you planing on selling Homebridge as a product?
Pretty sure that is illegal.

I have Homebridge installations that have run flawlessly for months. It is only as stable as the most unstable plugin.
FYI, Apple’s open HomeKit license does not apply to sold products. Those must be MFI certified and the current Homebridge implementation does not support the hardware chip required for that. You might be able to get around that by simply charging for implementation services of your free plugin. I’d be wary of that because the spirit of the open license is that it is for “personal development” only and we can only slip by here because you install your own product.

One more note.. your symptoms described are often caused by invalid values being set on characteristics. You can try using my fork of hap-nodejs in place of the npm release. It contains validation checks designed to prevent that kind of total loss of an installation.

Thank you pdlove. Our product is not for retail market, just intergrate enginnering project, so this product based on Rpi and plugin can be free for customer.
Let's focus on technology.  I've never seen invalid values  in debug level log. So I‘m curious what will happen if  characteristics was set a invalid value. in Characteristic.prototype.setValue source code, it seems that only handle undefine and null.  And if a numeric characteristic is set a string?
And which release should I clone from you fork or just clone master?
Thank you very much again.

@nhyjq It shouldn't be much longer until the changes are merged into the master. You might simply want to wait a week or so to test it then. If you can't wait, you can pull it from the fork I've got. To implement this, I've added a validateValue function that is called when the characteristic's value is being change. The change can come from a setCharacteristic/updateCharacteristic and it's also validated when a function performs it's callback. The validate process attempts to coerce a valid value and will retain the original if it can't figure out what you're doing. Here's a link to the current iteration so you can see: https://github.com/pdlove/HAP-NodeJS/blob/c04ea56a15ddcedea47e7ce9a07585c8f4d7d284/lib/Characteristic.js#L172

Workaround: npm install -g<EMAIL_ADDRESS>@pdlove Thank you very much! 👍

The changes have been merged into the latest HAP-NodeJS and homebridge should be updated shortly for the new version.

Should install it by running "sudo npm install -g homebridge", or just HAP-NodeJS?

@pdlove Thank you very much. I'll test this version ASAP.

Works great so far!

Works. Issue can by closed.


Teams Exploratory- Failed to upload file attachment

It is confusing that based on the licensing there is a default 2gb personal storage for file attachment but then every time we try to attach a file we receive an error.
Based on my understanding for you to attach a file you should have a onedrive or any cloud related storage. Correct me if im wrong.
Thanks

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: f897ae9b-852a-b617-7de0-d76dbd9f1820
Version Independent ID: 161b1845-53fd-8912-a5f9-737d3bcdaadc
Content: Manage the Microsoft Teams Exploratory experience - Microsoft Teams
Content Source: Teams/teams-exploratory.md
Service: msteams
GitHub Login: @LolaJacobsen
Microsoft Alias: lolaj

@Yoeeee thank you for submitting feedback.
I think the best way forward is if you open a service ticket in your tenant so this can get resolved ASAP. Based on the outcome let me know if it is something that can be called out in the docs.
Please follow this link to contact support for business products:https://docs.microsoft.com/office365/admin/contact-support-for-business-products
Please keep us posted here on the resolution so we can feed whatever information you discover into the content.


Issue 279 using JCache

@iliyanvelchevio thank you for reproducing.
I close this pull request, because I have decided to extend base TCK for distributed buckets instead of modification the test for particular integration https://github.com/bucket4j/bucket4j/commit/4c3ea89e931784d7e8ea078bb9dc5381f03cff6d


Add keyType to postgres s3 helm template

keyType was missing from the list of s3 config fields.

This change allows us to use role based access when running within EKS.

You would need to add this to the values.yaml too, right?


Is it possible to execute scripts from a probot app?

Feature Request
Describe the solution you'd like
I'm looking for a way to perform file mutations via a node script.
For example:

A user installs a bot
It will then periodically check the source files and run a node cli script
That script will output some changes to N files
Those get added to a commit => branch => pull request
User can then look at the PR and decide whether to merge them

Describe alternatives you've considered
Github Actions seem to be a good avenue for this as well, but I'm looking to bundle this into a nice Bot that can easily be installed.

It will then periodically check the source files and run a node cli script

Anything you have to do "periodically" against the source files of a repository is typically something that would be a better fit for a GitHub Action that you run on a schedule. The best experience for getting it easily installed would be to publish the action to the marketplace, and you can maintain the logic of it without having to host an app that does all the scheduling.
@actions/toolkit is the most similar developer experience to Probot in Actions, and would be where I would start for something like this.


fix(/cves/[id]/exposed_images): fix query

Secure Coding Practices Checklist GitHub Link

https://github.com/RedHatInsights/secure-coding-checklist

Secure Coding Checklist

[x] Input Validation
[x] Output Encoding
[x] Authentication and Password Management
[x] Session Management
[x] Access Control
[x] Cryptographic Practices
[x] Error Handling and Logging
[x] Data Protection
[x] Communication Security
[x] System Configuration
[x] Database Security
[x] File Management
[x] Memory Management
[x] General Coding Practices

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 61.06%. Comparing base (13cd3fb) to head (497e96a).
Report is 13 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #196      +/-   ##
==========================================
+ Coverage   60.07%   61.06%   +0.98%
==========================================
  Files          46       50       +4
  Lines        2928     2527     -401
==========================================
- Hits         1759     1543     -216
+ Misses        969      772     -197
- Partials      200      212      +12

Flag
Coverage Δ

unittests
61.06% <100.00%> (+0.98%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


[DO_NOT_MERGE] AutoML Natural Language Entity Extraction and Sentiment Analysis

"In September, these PRs (the [DO NOT MERGE] AutoML PRs) will be closed ~ this'll happen after updated, generated versions of these samples are published to the website (via google-cloud-java samples/ directories)
Until then, they'll continue to hang around, mainly so that we remember not to delete the branches these are sent from (because they are being used to publish docs at the moment)" - Rebecca

@nirupa-kumar This PR has no files.

@nnegrey Please review

Took a look at the entity-extraction code, looks great, just some questions throughout, not necessarily required code changes.
Taking a break, will look at sentiment-analysis later. :)

@nnegrey Thanks a lot for reviewing the code. I have fixed everything but the folder re-org. Please do let me know if there is anything else.

Looks great! Just the last comment on the package names above.

In Process of being converted to auto-generated samples.

@nnegrey These samples DISAPPEARED!
This page is breaking and we cannot republish it:
https://cloud.google.com/natural-language/automl/sentiment/docs/datasets#automl-nl-example-java
Does anyone know where these samples went?
This is the "View on GitHub" link which now 404s:
https://github.com/GoogleCloudPlatform/java-docs-samples/blob/language/language/automl/sentiment-analysis/java/src/main/java/com/google/cloud/language/automl/sentiment/analysis/samples/DatasetApi.java
/cc @sirtorry

👋 Hi! Giving an update on these. Saw them still sitting around and wanted to ping with status incase folks stumble upon these!
In September, these PRs (the [DO NOT MERGE] AutoML PRs) will be closed ~ this'll happen after updated, generated versions of these samples are published to the website (via google-cloud-python samples/ directories)
Until then, they'll continue to hang around, mainly so that we remember not to delete the branches these are sent from (because they are being used to publish docs at the moment)
Long story. But long story short – these are planned to be resolved this month.

Status update please?  Can we close this?

Closing.
I will be moving many of these this quarter to the automl folder created in this PR: I believe we can close the PR, but the branches need to stick around as the docs reference them directly while we migrate them to a new location.
Branch is currently referenced in docs.


How to make custom helper sum array {{sum this}}?

I try like this:
sum: function(arr) {

    const s = 0;
    for(const i=0; i<arr.length; i++) {
      s = s + arr[i];
    }

    return s;

}

{{#each something}}
  <td>{{sum this}}</td>
{{/each}}

but in this case nothing appears, any suggestions?
[this] contains numbers
50 | 10 | 10 | 10 | 5 | 5 |
60 | 10 | 10 | 10 | 5 | 5 |
50 | 10 | 10 | 10 | 10 | 10
so result should be
160 | 30 | 30 | 30 | 20 | 20 |
but in my method return zero values.

https://handlebarsjs.com/#helpers

https://jsfiddle.net/15trz4j8/
I think your problem is that you are using const instead of let. s = s + arr[i]; does not work, if s is a const, neither does i++ if i is a const.


Saluki 5x sensors

Please use PX4 Discuss or Slack to align on pull requests if necessary. You can then open draft pull requests to get early feedback.
Describe problem solved by this pull request
A clear and concise description of the problem this proposed change will solve.
E.g. For this use case I ran into...
Describe your solution
A clear and concise description of what you have implemented.
Describe possible alternatives
A clear and concise description of alternative solutions or features you've considered.
Test data / coverage
How was it tested? What cases were covered? Logs uploaded to https://review.px4.io/ and screenshots of the important plot parts.
Additional context
Add any other related context or media.

LGTM. Let's merge after the  orientations have been checked on the real hw

Orientations checked. Second ICM42688P disabled


Added hyperspectral_image_classification_with_gsmote to applications

The confusion matrix image still missing. to be added.

Codecov Report

Merging #8 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master       #8   +/-   ##
=======================================
  Coverage   98.83%   98.83%
=======================================
  Files           4        4
  Lines         171      171
=======================================
  Hits          169      169
  Misses          2        2

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5171799...713292c. Read the comment docs.


Fix #1416 - Fails to download gfycat.com/amp/*

Category
This change is exactly one of the following (please change [ ] to [x]) to indicate which:

[x] a bug fix (Fix #1416)
[ ] a new Ripper
[ ] a refactoring
[ ] a style change/fix
[ ] a new feature

Description
Adding a string replace to remove the "/amp"
Testing
Required verification:

[x] I've verified that there are no regressions in mvn test (there are no new failures or errors).
[x] I've verified that this change works as intended.

[x] Downloads all relevant content.
[x] Downloads content from multiple pages (as necessary or appropriate).
[x] Saves content at reasonable file names (e.g. page titles or content IDs) to help easily browse downloaded content.

[x] I've verified that this change did not break existing functionality (especially in the Ripper I modified).

Optional but recommended:

[x] I've added a unit test to cover my change.

LGTM


Autocomplete not working

I know this could be a known issue, I am using scala 2.11.7, spark 2.0.2, and i found autocomplete not working using spark-notebook master.
Do we have any plan to fix it?

so far it works for only scala 2.10.
related https://github.com/andypetrella/spark-notebook/issues/726


Shift-enter should not move cursor to end of line

Type: Bug

Behaviour
Expected vs. Actual
Expected behavior is after I press shift-enter to run a line of code (thank you for improving this in #13495!), either of these happen:

Cursor goes to beginning of line
Cursor stays at same horizontal position. (I am offering this as an idea, but not sure what I think of it. The prior may be better.)

What actually happens is the cursor is jumped to the very end of the line. I am often having to scroll left to recall what the line is about.
Steps to reproduce:

Press shift-enter on a line of code when the next line also has a line of code.

Diagnostic data

Python version (& distribution if applicable, e.g. Anaconda): 3.11.5
Type of virtual environment used (e.g. conda, venv, virtualenv, etc.): Conda
Value of the python.languageServer setting: Default

Output for Python in the Output panel (View→Output, change the drop-down the upper-right of the Output panel to Python)

XXX

User Settings

languageServer: "Pylance"

Extension version: 2024.2.1
VS Code version: Code 1.87.2 (863d2581ecda6849923a2118d93a088b0745d9d6, 2024-03-08T15:20:17.278Z)
OS version: Windows_NT x64 10.0.22631
Modes:

System Info

Item
Value

CPUs
13th Gen Intel(R) Core(TM) i9-13900H (20 x 2995)

GPU Status
2d_canvas: enabledcanvas_oop_rasterization: enabled_ondirect_rendering_display_compositor: disabled_off_okgpu_compositing: enabledmultiple_raster_threads: enabled_onopengl: enabled_onrasterization: enabledraw_draw: disabled_off_okskia_graphite: disabled_offvideo_decode: enabledvideo_encode: enabledvulkan: disabled_offwebgl: enabledwebgl2: enabledwebgpu: enabled

Load (avg)
undefined

Memory (System)
31.68GB (11.89GB free)

Process Argv
G:\My Drive\research\Campsite checker\check_sites.py --crash-reporter-id dc4451c2-191b-43ac-a004-eab6bc408e8b

Screen Reader
no

VM
0%

A/B Experiments
vsliv368cf:30146710
vspor879:30202332
vspor708:30202333
vspor363:30204092
vscoreces:30445986
vscod805cf:30301675
binariesv615:30325510
vsaa593cf:30376535
py29gd2263:30899288
c4g48928:30535728
azure-dev_surveyone:30548225
a9j8j154:30646983
962ge761:30959799
pythongtdpath:30769146
welcomedialog:30910333
pythonidxpt:30866567
pythonnoceb:30805159
asynctok:30898717
pythontestfixt:30902429
pythonregdiag2:30936856
pyreplss1:30897532
pythonmypyd1:30879173
pythoncet0:30885854
2e7ec940:30986170
pythontbext0:30879054
dsvsc016:30899300
dsvsc017:30899301
dsvsc018:30899302
cppperfcontrol:30979541
d34g3935:30971562
fegfb526:30981948
bg6jg535:30979843
dsvsc020:30976470

Hello, @arencambre. Thanks for the call out! This behavior of the Python extension smartly selecting the minimum amount of executable code, and advancing the cursor to the next executable statement is from the Smart Send feature. This allows Python developers to quickly shift+enter and execute their code inside their Python file.
If you wish to turn off this behavior and get your desired cursor staying at the same position, you may go to settings and type smart send. You should be able to turn off this setting for your user/workspace setting depending on your preference.
Alternative solution to have the best of the both world would be you explicitly selecting/highlighting the chunk of code that you wish to run, this would cause Python extension to execute what you have selected, and will not do anything to move around your cursor. When you do not highlight any chunk of code and shift+enter, you will still be able to use the smart send behavior!
Let me know if you need some other help

This behavior of the Python extension smartly selecting the minimum amount of executable code, and advancing the cursor to the next executable statement is from the Smart Send feature. This allows Python developers to quickly shift+enter and execute their code inside their Python file.

This is fine, and I love it!
The current behavior is the cursor advanced to after the statement, at the end of that line. I think a sensible default is the cursor is advances to the beginning of the line that has the next executable statement.

This is fine, and I love it!

Glad you are enjoying the feature!! Thank you :)

I think a sensible default is the cursor is advances to the beginning of the line that has the next executable statement. This shows me what is usually the most important part of a line of code, plus I avoid the horizontal position jumping around as I shift-enter through lines of code.

This can be subjective in a way, but ever since smart send was released on August, users seem to be pretty happy with it.
It may have to do with folks using popular formatter like Ruff and Black-formatter and limit their code length to not be long to encounter the same pain points of the viewport scrolling related issue that you mentioned.
Considering folks will shift+enter as they incrementally write their code throughout the Python file, and have a formatter with around 100 character length, placing the cursor to the end made sense as it seemed more intuitive and gave the sense that they are ready to execute on that line without further changes.
I will still bring this up to the team though.

Thank you. Here's a practical example of what I am facing. Note how the code gets obscured when I shift-enter from a long line to a short line:


Spreadsheet doesn't recognize script, GESI not found in "get addons"

subject says it all
I can't use functions, and it looks like gesi is not listed in the Google sheets addons at the moment.

Known issue.  Nothing I can do but wait.
tl;dr while in the process of migrating GESI to a new Google Cloud Platform project due to some changes on their end I unpublished the old project.  I thought this just meant "don't show this in the store", but it apparently totally revoked the add-on.  The old and new projects are currently in review by Google to be added back to the store.
Best case scenario is that happens soon and people can reinstall it and everything should continue to work.  Ultimately people will need to install the "new" add-on (uses the same underlying code so no functional difference).  But given the new project is also undergoing verification for its OAuth flow, that may be a while.

ah, haven't seen that... thank you very much o7

Update on this.
Due to the inability to revert back to the old GCP project, we'll need to wait for the new project to go through the verification process; of which I have underway.  When GESI is verified and added back to the store, only 100 people may install it until GESI's OAuth flow is also verified.  I anticipate that this may take a fair amount of time.  However, after this process is complete GESI should be more future proof in the eyes of Google.

Will the new app still be called GESI?  Will you make an announcement somewhere when it is re-published.  Keen to get back to using your add on - thank you.

Will the new app still be called GESI?  Will you make an announcement somewhere when it is re-published.  Keen to get back to using your add on - thank you.

Yes and yes.

Yes and yes.

Any indication as to when it's gonna be available again?

Any indication as to when it's gonna be available again?

@Zenrer No.

@Zenrer No.

I have managed to re-add GESI to my sheet.  Your app is back in the Add-Ons Marketplace.

I have managed to re-add GESI to my sheet.  Your app is back in the Add-Ons Marketplace.

GESI should be back to normal.  OAuth verification has been completed and its back in the marketplace.  For those of you using local installs, be sure to delete your local GESI files and EVE dev application before installing.

GESI should be back to normal.  OAuth verification has been completed and its back in the marketplace.  For those of you using local installs, be sure to delete your local GESI files and EVE dev application before installing.


Statewise testing graph broken

Describe the bug
State specific testing count graph is not working
To Reproduce
Steps to reproduce the behavior:

Scroll down tk graphs in the landing page
Select any state eg : Maharashtra from the dropdown
Tested graph is not plotted

Expected behavior
Tested graph should be plotted correctly
Screenshots

Desktop (please complete the following information):
NA. Tested on Phone
Smartphone (please complete the following information):

OnePlus 3T android 9 pie
Google Chrome 81.0.4044.138

Additional context
NA

Looks like this was temporary


DAT-11762

Description
This ticket contains the following changes:
Improvement

Rename liquibase-core module to liquibase-standard (https://datical.atlassian.net/browse/DAT-13446)
Create a new liquibase-core module to generate liquibase-core.jar bundle and publish in GPM (https://datical.atlassian.net/browse/DAT-13448) GPM : https://github.com/liquibase/liquibase/packages/1783578?version=github-action-DAT-13446-newer-SNAPSHOT
Modify liquibase-dist module to generate only distributable liquibase tar file (https://datical.atlassian.net/browse/DAT-13447)

Things to be aware of

We are publishing liquibase-core to GPM https://github.com/liquibase/liquibase/packages/ . The liquibase-core contains cli+snowflake+standard module
We ARE NOT publishing liquibase-standard
All the extensions can still consume liquibase-core as before.
Sub-modules like liquibase-integration-testing , liquibase-extension-testing can use liquibase-standard in their pom.xml for test-jar for testing purposes locally.

Impact
This change should not impact the user experience at all. They should still be able to download the liquibase-core module and perform their duties.

[ ] Bug fix (non-breaking change which fixes expected existing functionality)
[x] Enhancement/New feature (adds functionality without impacting existing logic)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Things to be aware of

Things to worry about

Additional Context

I'd like to see a functional test run/test harness run on this branch. Is it possible to make that happen?


Update Dockerfile with CUDA 11.8

docker image里的cuda好像要升级一下，不然有这个报错: server log:2024-11-09 12:31:36 2024-11-09 20:31:36,085 INFO send inference response 2024-11-09 12:31:36
0%|          | 0/1 [00:00<?, ?it/s]2024-11-09 20:31:36,093 INFO synthesis text 你好,我是通义生成式语音大模型,请问有什么可以帮您的吗?
2024-11-09 12:31:44
0%|          | 0/1 [00:08<?, ?it/s]
2024-11-09 12:31:44 2024-11-09 20:31:44,105 ERROR Exception iterating responses: cuFFT error: CUFFT_INTERNAL_ERROR
2024-11-09 12:31:44 Traceback (most recent call last):
2024-11-09 12:31:44   File "/opt/conda/lib/python3.10/site-packages/grpc/_server.py", line 589, in _take_response_from_response_iterator
2024-11-09 12:31:44     return next(response_iterator), True
2024-11-09 12:31:44   File "/opt/CosyVoice/CosyVoice/runtime/python/grpc/server.py", line 62, in Inference
2024-11-09 12:31:44     for i in model_output:
2024-11-09 12:31:44   File "/opt/CosyVoice/CosyVoice/runtime/python/grpc/../../../cosyvoice/cli/cosyvoice.py", line 61, in inference_sft
2024-11-09 12:31:44     for model_output in self.model.tts(**model_input, stream=stream, speed=speed):
2024-11-09 12:31:44   File "/opt/CosyVoice/CosyVoice/runtime/python/grpc/../../../cosyvoice/cli/model.py", line 191, in tts
2024-11-09 12:31:44     this_tts_speech = self.token2wav(token=this_tts_speech_token,
2024-11-09 12:31:44   File "/opt/CosyVoice/CosyVoice/runtime/python/grpc/../../../cosyvoice/cli/model.py", line 138, in token2wav
2024-11-09 12:31:44     tts_speech, tts_source = self.hift.inference(speech_feat=tts_mel, cache_source=hift_cache_source)
2024-11-09 12:31:44   File "/opt/conda/lib/python3.10/site-packages/torch/utils/_contextlib.py", line 115, in decorate_context
2024-11-09 12:31:44     return func(*args, **kwargs)
2024-11-09 12:31:44   File "/opt/CosyVoice/CosyVoice/runtime/python/grpc/../../../cosyvoice/hifigan/generator.py", line 410, in inference
2024-11-09 12:31:44     generated_speech = self.decode(x=speech_feat, s=s)
2024-11-09 12:31:44   File "/opt/CosyVoice/CosyVoice/runtime/python/grpc/../../../cosyvoice/hifigan/generator.py", line 350, in decode
2024-11-09 12:31:44     s_stft_real, s_stft_imag = self._stft(s.squeeze(1))
2024-11-09 12:31:44   File "/opt/CosyVoice/CosyVoice/runtime/python/grpc/../../../cosyvoice/hifigan/generator.py", line 334, in _stft
2024-11-09 12:31:44     spec = torch.stft(
2024-11-09 12:31:44   File "/opt/conda/lib/python3.10/site-packages/torch/functional.py", line 641, in stft
2024-11-09 12:31:44     return _VF.stft(input, n_fft, hop_length, win_length, window,  # type: ignore[attr-defined]
2024-11-09 12:31:44 RuntimeError: cuFFT error: CUFFT_INTERNAL_ERROR

这个好像有人提过一个pr，似乎是跟rtx显卡有关的问题，这个dockerfile是在v100上验证过的


vagrant: bump net-next vagrant image

Both (net-next, regular) builds contain:

Bump of cached Istio container images

net-next build also contains latest bpf tree on track for 5.7:

Fixes for BPF TPROXY

Coverage increased (+0.002%) to 46.932% when pulling ecb1a52aef0096da8e7496064933d5a71123c528 on joestringer:submit/bump-net-next-box into dcbdb1e05a60924dc53715fe2295513717ed8a22 on cilium:master.

test-me-please

test-me-please

Provisioning failure.

restart-ginkgo

Hit provisioning issues, in part because it's spending time pulling istio v1.5.1 container images. I've pinged @jrajahalme to add these into the dev VM, will wait on that.
https://jenkins.cilium.io/job/Cilium-PR-Ginkgo-Tests-Validated/18647/execution/node/122/log/

test-me-please

@nebril I haven't updated the @v419_SERVER_VERSION as I didn't see a jenkins target that I could trigger to generate a new image. Is this documented somewhere?

Just one failure, apparently the regular box got rid of yamllint and the runtime tests depend on it.

PR https://github.com/cilium/cilium/pull/10952 should allow us to just rebase and merge the existing VMs without having to go and generate the box images again just to pick up yamllint.

test-me-please


HADOOP-17050 S3A to support multiple DTs

Contributed by Steve Loughran.
DT plugins will be asked for any additional token issuers,
an array can be returned, each one will be asked for tokens.

not yet tested.
@bgaborg -will this do? the APIs only allow each DT issuer to issue zero or one token, but you can return a list of other implementations of the DT issuer API.
To offer multiple tokens, you will need to implement this interface and return whatever token identifiers you like. They don't need to be subclasses of the S3A one.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
22m 19s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

-1 :x:
test4tests
0m  0s
The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
19m  2s
trunk passed

+1 :green_heart:
compile
0m 36s
trunk passed

+1 :green_heart:
checkstyle
0m 28s
trunk passed

+1 :green_heart:
mvnsite
0m 40s
trunk passed

+1 :green_heart:
shadedclient
15m  3s
branch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
0m 30s
trunk passed

+0 :ok:
spotbugs
1m  3s
Used deprecated FindBugs config; considering switching to SpotBugs.

+1 :green_heart:
findbugs
1m  0s
trunk passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 33s
the patch passed

+1 :green_heart:
compile
0m 29s
the patch passed

+1 :green_heart:
javac
0m 29s
the patch passed

+1 :green_heart:
checkstyle
0m 19s
the patch passed

+1 :green_heart:
mvnsite
0m 32s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
shadedclient
13m 51s
patch has no errors when building and testing our client artifacts.

-1 :x:
javadoc
0m 27s
hadoop-tools_hadoop-aws generated 2 new + 4 unchanged - 0 fixed = 6 total (was 4)

+1 :green_heart:
findbugs
1m  1s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
1m 31s
hadoop-aws in the patch passed.

+1 :green_heart:
asflicense
0m 32s
The patch does not generate ASF License warnings.

80m 17s

Subsystem
Report/Notes

Docker
ClientAPI=1.40 ServerAPI=1.40 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-2043/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/2043

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle

uname
Linux e88778ede215 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / 9fe4c37c25b

Default Java
Private Build-1.8.0_252-8u252-b09-1~18.04-b09

javadoc
https://builds.apache.org/job/hadoop-multibranch/job/PR-2043/1/artifact/out/diff-javadoc-javadoc-hadoop-tools_hadoop-aws.txt

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-2043/1/testReport/

Max. process+thread count
413 (vs. ulimit of 5500)

modules
C: hadoop-tools/hadoop-aws U: hadoop-tools/hadoop-aws

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-2043/1/console

versions
git=2.17.1 maven=3.6.0 findbugs=3.1.0-RC1

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

i couldn't think of any tests without having a provider actually issue tokens here

+1 LGTM
(after some offline discussions)
Thanks @steveloughran !

thx. will fix the javadocs then commit
[WARNING] /home/jenkins/jenkins-slave/workspace/hadoop-multibranch_PR-2043/src/hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/auth/delegation/S3ADelegationTokens.java:459: warning - Tag @link: missing '#': "DelegationTokenIssuer.collectDelegationTokens()"
[WARNING] /home/jenkins/jenkins-slave/workspace/hadoop-multibranch_PR-2043/src/hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/auth/delegation/S3ADelegationTokens.java:459: warning - Tag @link: can't find DelegationTokenIssuer.collectDelegationTokens() in org.apache.hadoop.fs.s3a.auth.delegation.S3ADelegationTokens

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
22m 24s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

-1 :x:
test4tests
0m  0s
The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
18m 39s
trunk passed

+1 :green_heart:
compile
0m 35s
trunk passed

+1 :green_heart:
checkstyle
0m 28s
trunk passed

+1 :green_heart:
mvnsite
0m 40s
trunk passed

+1 :green_heart:
shadedclient
15m  9s
branch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
0m 29s
trunk passed

+0 :ok:
spotbugs
1m  1s
Used deprecated FindBugs config; considering switching to SpotBugs.

+1 :green_heart:
findbugs
0m 58s
trunk passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 34s
the patch passed

+1 :green_heart:
compile
0m 28s
the patch passed

+1 :green_heart:
javac
0m 28s
the patch passed

+1 :green_heart:
checkstyle
0m 19s
the patch passed

+1 :green_heart:
mvnsite
0m 32s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
shadedclient
14m  9s
patch has no errors when building and testing our client artifacts.

-1 :x:
javadoc
0m 25s
hadoop-tools_hadoop-aws generated 1 new + 4 unchanged - 0 fixed = 5 total (was 4)

+1 :green_heart:
findbugs
1m 13s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
1m 38s
hadoop-aws in the patch passed.

+1 :green_heart:
asflicense
0m 32s
The patch does not generate ASF License warnings.

80m 35s

Subsystem
Report/Notes

Docker
ClientAPI=1.40 ServerAPI=1.40 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-2043/2/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/2043

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle

uname
Linux 5fdba5d56231 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / fbb87754306

Default Java
Private Build-1.8.0_252-8u252-b09-1~18.04-b09

javadoc
https://builds.apache.org/job/hadoop-multibranch/job/PR-2043/2/artifact/out/diff-javadoc-javadoc-hadoop-tools_hadoop-aws.txt

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-2043/2/testReport/

Max. process+thread count
442 (vs. ulimit of 5500)

modules
C: hadoop-tools/hadoop-aws U: hadoop-tools/hadoop-aws

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-2043/2/console

versions
git=2.17.1 maven=3.6.0 findbugs=3.1.0-RC1

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 32s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

-1 :x:
test4tests
0m  0s
The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
19m  0s
trunk passed

+1 :green_heart:
compile
0m 36s
trunk passed

+1 :green_heart:
checkstyle
0m 25s
trunk passed

+1 :green_heart:
mvnsite
0m 45s
trunk passed

+1 :green_heart:
shadedclient
14m 58s
branch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
0m 31s
trunk passed

+0 :ok:
spotbugs
1m 18s
Used deprecated FindBugs config; considering switching to SpotBugs.

+1 :green_heart:
findbugs
1m 16s
trunk passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 42s
the patch passed

+1 :green_heart:
compile
0m 36s
the patch passed

+1 :green_heart:
javac
0m 36s
the patch passed

+1 :green_heart:
checkstyle
0m 23s
the patch passed

+1 :green_heart:
mvnsite
0m 40s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
shadedclient
16m 55s
patch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
0m 28s
the patch passed

+1 :green_heart:
findbugs
1m 20s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
1m 40s
hadoop-aws in the patch passed.

+1 :green_heart:
asflicense
0m 34s
The patch does not generate ASF License warnings.

62m 52s

Subsystem
Report/Notes

Docker
ClientAPI=1.40 ServerAPI=1.40 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-2043/3/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/2043

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle

uname
Linux fdaeb627010e 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk /<PHONE_NUMBER>7

Default Java
Private Build-1.8.0_252-8u252-b09-1~18.04-b09

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-2043/3/testReport/

Max. process+thread count
413 (vs. ulimit of 5500)

modules
C: hadoop-tools/hadoop-aws U: hadoop-tools/hadoop-aws

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-2043/3/console

versions
git=2.17.1 maven=3.6.0 findbugs=3.1.0-RC1

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.


Would it be possible to add an option to log everything to a separate logfile?

At the moment on Debian logging is sent to stdout and /var/log/syslog. I would like to be able to specify a separate logfile where all logging will be sent.

I'll take a look on that but feel free to propose PR in the meantime.

If Python logger would be in use, standard pythonic log management would be in place.
I'll take a look into this.

Resolved by #30


Can't start the script

python3 start.py
Requirement already satisfied: configparser in /data/data/com.termux/files/usr/lib/python3.10/site-packages (5.3.0)
[1]    21795 abort      python3 start.py
Any solution???

Hi! Try reinstalling python and updating all the pip libraries, no other ideas


Port to OCaml 5.00

This PR ports all of the examples to OCaml 5.00 (effects without the dedicated syntax). It also updates the information on how to get it running locally with pins for OCaml 5.00 compatible versions of dune (just upstream) and lwt (a personal fork, see ocsigen/lwt#923). It's probably not worth merging until that issue is properly fixed.
Most of the changes were mechanical. One to maybe check is ref.ml which like the state.ml one you shared in patricoferris/awesome-multicore-ocaml#2 need some extra type annotations.
I see this repository used to use travis, as a follow-up PR I can remove that and add a Github Action to test things if that's desirable?

The changes look good.
We can revive the multishot continuations thanks to @dhil's https://github.com/dhil/ocaml-multicont library.

I see this repository used to use travis, as a follow-up PR I can remove that and add a Github Action to test things if that's desirable?

Certainly. This would be useful.

One point about continuations in 5.00 is that the stack memory allocated for a continuation is not managed by the GC. Hence, the continuations must be resumed either by continue or discontinue.
I believe that the version of the queens benchmark currently in the repo leaks the stacks, and it may be better to use the one here. The pointed benchmark is also idiomatic in that it collects all of the solutions.

This is good to go when OCaml 5.00 compatible packages have been released.
Keen to have this up as it is going to be the primary reference manual for effect handlers users in OCaml 5.00.

@patricoferris Let me know when the dependent packages have been released. I am eager to merge the PR :-)

I agree @kayceesrk, I believe dune 2.9.2+ is compatible now (and released). I'm not sure how long it will be before lwt and multicont get a new (or first) release. In the meantime I can just add an effects-examples.opam file so the setup is just
$ opam install .
$ dune build

Hiding the pinning information in the opam file and changing it once there are proper releases ?

I plan to release multicont as soon as 5.00.0+trunk stabilise a bit.

I can just add an effects-examples.opam file so the setup is just

This sounds good to me.
Lots of folks are starting to look at this repo. It would be useful if the code reflected what will be in OCaml 5. With that in mind, the proposed plan works well.

Hmm, the latest trunk branch causes the multishot examples to seg fault it would seem. I happen to have two switches for 5.00.0+trunk, one I just created and one from a while ago (I'm not aware of any way to ask opam what commit the two compilers are from ://). The one from a while ago doesn't seg fault.

There is a separate breaking change that is in flight:  https://github.com/ocaml/ocaml/pull/11044. It may be worth waiting for this to land first.

Latest commit handles the renaming along with the compiler version number changing too. Multishot still seg faulting.

I plan to release multicont as soon as 5.00.0+trunk stabilise a bit.

@dhil do you think you could cut a release? I think the code is a bit more stable. If you want more time, perhaps we can merge the PRs and mark the multicont tests as failing.

Latest commit handles the renaming along with the compiler version number changing too. Multishot still seg faulting.

Interesting. The memo.ml example does not segfault on my system. I suppose this could be related to the recent changes to alloc_for_stack (c.f. https://github.com/ocaml/ocaml/commit/dd2fe0a5db). What operating system are you using, and what CPU architecture is it running on top of?

I plan to release multicont as soon as 5.00.0+trunk stabilise a bit.

@dhil do you think you could cut a release? I think the code is a bit more stable. If you want more time, perhaps we can merge the PRs and mark the multicont tests as failing.

Yes, I can look into making a release soon.

Segmentation faults are now gone on latest trunk + latest commit of ocaml-multicont :)) 👍

I have released a version of multicont on OPAM
$ opam search multicont
# Packages matching: match(*multicont*)
# Name    # Installed # Synopsis
multicont --          Multi-shot continuations in OCaml

Unfortunately I think trunk may have just broken multicont :/ https://github.com/ocaml/ocaml/pull/11105
#=== ERROR while compiling multicont.1.0.0~rc.1 ===============================#
# context     2.1.0 | macos/x86_64 | ocaml-variants.5.0.0+trunk | https://opam.ocaml.org#257f9ce1
# path        ~/.opam/5.0.0+trunk/.opam-switch/build/multicont.1.0.0~rc.1
# command     ~/.opam/opam-init/hooks/sandbox.sh build make all
# exit-code   2
# env-file    ~/.opam/log/multicont-21630-61b387.env
# output-file ~/.opam/log/multicont-21630-61b387.out
### output ###
# ocamlc -c -strict-formats -strict-sequence -safe-string -bin-annot -warn-error -a multicont.mli multicont.ml
# ocamlc -c fiber_primitives.c
# fiber_primitives.c:97:12: error: no member named 'size_bucket' in 'struct stack_info'
#     stack->size_bucket = size_bucket;
#     ~~~~~  ^
# 1 error generated.
# make: *** [fiber_primitives.o-byte] Error 2

Looks like it was changed to cache_bucket but the semantics may have also changed, I'm not super familiar with the internals of fibers...

There was a bug in the implementation of cache buckets, which was fixed in https://github.com/ocaml/ocaml/pull/11105.

OK. Thanks for bringing this to my attention. I will look into syncing up the library with trunk.

I've sync'ed multicont with the latest ocaml/ocaml trunk now. I will prepare another release soon.

@dhil Thanks for making the release: https://github.com/dhil/ocaml-multicont/releases/tag/v1.0.0-rc.2.

It was recently merged into the main open repository.

Ok. Let's merge this one. Thanks @patricoferris and @dhil for the work!
The next step is to use Github Actions for the repo.