add metrics sample

add metrics sample
depends on: https://github.com/apache/dubbo-go/pull/2594

plz rerun the CI


[add]launch_configuration bug fixes

I'm just now coming back to maintain this repository using the new AWS SDK and AWS launch templates. I will not be maintaining the old ELBAS that relied on launch configurations and AWS SDK v1.
Most of the changes in this PR are taken care of by launch templates. I do like the elbas:list command idea though, so I've made #33 to track this feature.


Zod rejects UUIDs that Postgres deems valid

Originally reported by @fooware in Discord
Turns out that Postgres will accept a truly random UUID, but Zod will reject it if it doesn't have the version nibble and possibly also the variant bits set correctly.
The end result is that if such an "invalid" UUID is entered into the database from a system that doesn't validate the input with Zod, Electric sync will permanently die on all clients until the offending row is removed.
You don't get any good errors or anything either indicating the underlying problem:

I mean, it is technically correct, but having stricter UUID checks in Electric vs Postgres is a bomb waiting to happen at the worst possible time in production, IMHO.
Related issue / discussion at Zod:
https://github.com/colinhacks/zod/issues/2122

To get an example to test, simply generate a valid V4 UUID, like this one:
76e1760a-d17a-41cd-9453-d8a9d6c994e0

Then replace the -4 (version 4) with for example -f (not a valid version) like so:
76e1760a-d17a-f1cd-9453-d8a9d6c994e0

Postgres will accept this "UUID" just fine as for example a primary key, but Zod and Electric will throw an error trying to read it from the DB.

Curly braces around UUID's are very common in Microsoft applications also referred to as GUIDs it would be great if these could also be validated, maybe a separate GUID validator or some options?
PostgreSQL also accepts the following alternative forms for input: use of upper-case digits, the standard format surrounded by braces, omitting some or all hyphens, adding a hyphen after any group of four digits. Examples are:
A0EEBC99-9C0B-4EF8-BB6D-6BB9BD380A11
{a0eebc99-9c0b-4ef8-bb6d-6bb9bd380a11}
a0eebc999c0b4ef8bb6d6bb9bd380a11
a0ee-bc99-9c0b-4ef8-bb6d-6bb9-bd38-0a11
{a0eebc99-9c0b4ef8-bb6d6bb9-bd380a11}
https://www.postgresql.org/docs/current/datatype-uuid.html

👋 we've been working the last month on a rebuild of the Electric server over at a temporary repo https://github.com/electric-sql/electric-next/
You can read more about why we made the decision at https://next.electric-sql.com/about
We're really excited about all the new possibilities the new server brings and we hope you'll check it out soon and give us your feedback.
We're now moving the temporary repo back here. As part of that migration we're closing all the old issues and PRs. We really appreciate you taking the time to investigate and report this issue!


The control is not displayed when we add an alert() into dp.change event

The behavior only happens the first time when we select a new date and the alert is shown and the widget isn't.
Here an example of the code:
$(".date").datetimepicker({
        format:'YYYY-MM-DD',
        useCurrent: true,
        icons: {
          time: "fa fa-clock-o",
          date: "fa fa-calendar",
          up: "fa fa-arrow-up",
          down: "fa fa-arrow-down"
        }
		}).on('dp.change', function (event) {
        alert("value was changed");
    }).find('input:first').....

The issue was replicated on v4.14.30 and v4.17.47
on v3.1.3 it's working correctly.

Hi, please help me regarding this
When I tried to set the date and time value for inline bootstrap datetimepicker using  jQuery ("#datetimepicker1").data('DateTimePicker').date(11/04/2017 11:23:45);
I got error in console uncaught. Type error:  can't read property date of undefined..
Please help me regarding this. It's urgent..
Is there any other way to set date and time in datetimepicker..

Hi, please help me regarding this
When I tried to set the date and time value for inline bootstrap datetimepicker using  jQuery ("#datetimepicker1").data('DateTimePicker').date(11/04/2017 11:23:45);
I got error in console uncaught. Type error:  can't read property date of undefined..
Please help me regarding this. It's urgent..
Is there any other way to set date and time in datetimepicker..

Please help me regarding this. I am struck with this issue

@ramppt  as I said before you need to use JQuery obove you're not using it:
("#datetimepicker1").data('DateTimePicker').date(11/04/2017 11:23:45)
you need to put
$("#datetimepicker1").data('DateTimePicker').date('11/04/2017 11:23:45')
If you continue to spamming other issues I'll have to block you of the repo.
If you need more help ask at https://stackoverflow.com/

Hi William,
I have done in the same way. But still throws the same error. Any other way to set the value.

@ramppt Create an issue and make a Minimal, Complete, and Verifiable example

Ok William. Thank you. I will post the example.
Meanwhile can you tell me how to set date and time for bootstrap datetimepicker other than that method..
Thanks once again

only the first change is working


Echobot example: user error (expected Bool, encountered String)

It's not an auth error as I can get a different error if I put in a wrong token, but there's no helpful error message aside from this. Is there any way I can make it be more verbose?

The problem appears to originate in makeSlackCall (the rtm.start one) at
    rawResp <- liftIO $ W.getWith opts url

Hmm, no, I'm mistaken, it's the sessionInfo parse that's failing.

Yuck, debugging aeson errors is pain and horror. The issue is teamIconDefault
The JSON I'm receiving is "image_default": "1", which definitely isn't a Maybe Bool

@srhb: I just hit this too.  PR submitted: #79
Hopefully slack will update docs/api for accuracy.  :slightly_smiling_face:

Thanks @jship, merged.


Add get and delete methods for attributes

Currently ProjectAttributes, ProjectDomainAttributes and WorkflowAttributes can be used to specify resource overrides. The only existing endpoint is to update (or implicitly create) these overrides but the delete semantics are undefined. To remedy this, this change introduces a delete API for all these customizable attributes AND a get to check what the existing values are currently set as.
In the future, only system administrators will be able to mutate these values once we have authorization rolled out.

Can you add a better description?

@wild-endeavor

Can you add a better description?

Done.

friendly ping @wild-endeavor @EngHabu


How can I set PDF meta-data

There's currently no way, but I just opened a PR to do the same: #257

So as @alistair-broomhead 's #259 is now merged into 'develop', you can start using the new feature :) Works like this:
pisaDocument(
    src=six.StringIO(HTML_CONTENT),
    dest=pdf_file,
    context_meta=METADATA
)


[incubator/kafka] external connection broke since version 0.11.0

Is this a request for help?: No

Is this a BUG REPORT or FEATURE REQUEST? (choose one): BUG REPORT

Version of Helm and Kubernetes:
Helm: 2.10.0  Kubernetes: 1.10.3
Which chart:
incubator/kafka
What happened:
Can't connect from external with the version 0.11.0, and the version 0.10.1 is good.
What you expected to happen:
How to reproduce it (as minimally and precisely as possible):
Anything else we need to know:

Kinda off-topic, but @ericwangqing could you please share a working config for 0.10.1?
I've never gotten the external setup working, at any version whatsoever. It always happens one of the following:

Initial deployment goes badly, e.g. https://github.com/helm/charts/issues/7556
Deployment goes fine, but the advertised host is still an internal cluster IP, so I can write to Kafka from outside the cluster but not read from it.

I've just got this working. The step missing in the documentation is to update the "listeners" configuration property. Here's my config:
configurationOverrides:
  "offsets.topic.replication.factor": 3
  "auto.leader.rebalance.enable": true
  "auto.create.topics.enable": true
  "confluent.support.metrics.enable": false
  "advertised.listeners": |-
    EXTERNAL://{{ .Environment.Name }}-kafka.internal.mydomain.com:$((31090 + ${KAFKA_BROKER_ID}))
  "listener.security.protocol.map": |-
    PLAINTEXT:PLAINTEXT,EXTERNAL:PLAINTEXT
  "listeners": "PLAINTEXT://<IP_ADDRESS>:9092,EXTERNAL://<IP_ADDRESS>:19092"
external:
  enabled: true
  domain: internal.mydomain.com

I'll make a pull request with the documentation update.

It seems to work for me if I set:
kafka:
  external:
    enabled: true
    servicePort: 9092 # instead of the default 19092

I fixed this issue in PR https://github.com/helm/charts/pull/12778. Please read through the comments in the PR on how to use the external kafka broker feature, especially what to update in values.yaml.


[C++][FS][Azure] Implement Move() for flat namespace storage accounts

Describe the enhancement requested
https://github.com/apache/arrow/issues/38704 implemented Move on hierarchical namespace storage accounts but we sill need to implement it for flat namespace storage accounts.
Supporting both file and directory moves would be nice but to achieve parity with GCS and S3 filesystems we only need to support file moves.
This is a child of https://github.com/apache/arrow/issues/18014.
Component(s)
C++

cc @felipecrv - you mentioned that you planned to work on this.
Assuming https://github.com/apache/arrow/pull/40021 is completed before this issue then this ticket should include enabling the python side tests for move. I will add TODO(GH-40025) comments where relevant.

cc @felipecrv - you mentioned that you planned to work on this.
Assuming #40021 is completed first, then this ticket should include enabling the python side tests for move. I will add TODO(GH-40025) comments where relevant.

If you can pass the tests on a real HNS storage account, it should be the same test code running against a different environment. The semantics should be the same. I don't plan to add new test cases in azurefs_test.cc for Move() on flat namespace accounts because the test code is supposed to run the same way on these different environments.

I don't think its worth running the python tests against real blob storage.

I would be grateful if you ran these tests manually against a real storage account with HNS support to catch any issues with the tests themselves. If they pass on the HNS implementation with Move() I can more easily take care of any issue that arises when we run it against flat-namespace Azurite.

I would be grateful if you ran these tests manually against a real storage account with HNS support to catch any issues with the tests themselves.

Turns out this was definitely a good idea. I was expecting everything to pass but there where actually a lot of failures
FAILED pyarrow/tests/test_fs.py::test_filesystem_is_functional_after_pickling[builtin_pickle-AzureFileSystem] - OSError: Failed to create directory '156d07e6-c9d2-11ee-989a-71cec6336ac8/a/aa/aaa/': https://tomtesthns.blob.core.windows.net/156d07e6-c9d2-11ee-989a-71cec6336ac8 Azure Error: [InvalidUri] 400 The request URI is invalid.
FAILED pyarrow/tests/test_fs.py::test_filesystem_is_functional_after_pickling[cloudpickle-AzureFileSystem] - OSError: Failed to create directory '165e703f-c9d2-11ee-989a-71cec6336ac8/a/aa/aaa/': https://tomtesthns.blob.core.windows.net/165e703f-c9d2-11ee-989a-71cec6336ac8 Azure Error: [InvalidUri] 400 The request URI is invalid.
FAILED pyarrow/tests/test_fs.py::test_get_file_info[AzureFileSystem] - OSError: Failed to create directory '165e7042-c9d2-11ee-989a-71cec6336ac8/a/aa/aaa/': https://tomtesthns.blob.core.windows.net/165e7042-c9d2-11ee-989a-71cec6336ac8 Azure Error: [InvalidUri] 400 The request URI is invalid.
FAILED pyarrow/tests/test_fs.py::test_get_file_info_with_selector[AzureFileSystem] - OSError: Failed to delete a directory: selector-dir/: https://tomtesthns.blob.core.windows.net/17d5de34-c9d2-11ee-989a-71cec6336ac8/selector-dir/ Azure Error: [InvalidUri] 400 The request URI is invalid.
FAILED pyarrow/tests/test_fs.py::test_create_dir[AzureFileSystem] - OSError: Failed to create directory '17d5de35-c9d2-11ee-989a-71cec6336ac8/test-directory/': https://tomtesthns.blob.core.windows.net/17d5de35-c9d2-11ee-989a-71cec6336ac8 Azure Error: [InvalidUri] 400 The request URI is invalid.
FAILED pyarrow/tests/test_fs.py::test_delete_dir[AzureFileSystem] - OSError: Failed to create directory '1925cd58-c9d2-11ee-989a-71cec6336ac8/directory/nested/': https://tomtesthns.blob.core.windows.net/1925cd58-c9d2-11ee-989a-71cec6336ac8 Azure Error: [InvalidUri] 400 The request URI is invalid.
FAILED pyarrow/tests/test_fs.py::test_delete_dir_with_explicit_subdir[AzureFileSystem] - OSError: Failed to create directory '1925cd59-c9d2-11ee-989a-71cec6336ac8/directory/': https://tomtesthns.blob.core.windows.net/1925cd59-c9d2-11ee-989a-71cec6336ac8 Azure Error: [InvalidUri] 400 The request URI is invalid.
FAILED pyarrow/tests/test_fs.py::test_delete_dir_contents[AzureFileSystem] - OSError: Failed to create directory '1a1e807e-c9d2-11ee-989a-71cec6336ac8/directory/nested/': https://tomtesthns.blob.core.windows.net/1a1e807e-c9d2-11ee-989a-71cec6336ac8 Azure Error: [InvalidUri] 400 The request URI is invalid.
FAILED pyarrow/tests/test_fs.py::test_copy_file[AzureFileSystem] - OSError: Failed to copy a blob. (https://tomtesthns.blob.core.windows.net/1a1e807f-c9d2-11ee-989a-71cec6336ac8/test-copy-source-file -> https://tomtesthns.blob.core.windows.net/1a1e807f-c9d2-11ee-989a-71cec6336ac8/test-copy-target-file) Azure Error: [CannotVerifyCopySource] 401 Server ...
FAILED pyarrow/tests/test_fs.py::test_move_directory[AzureFileSystem] - OSError: Failed to create directory '1b30faf0-c9d2-11ee-989a-71cec6336ac8/source-dir/': https://tomtesthns.blob.core.windows.net/1b30faf0-c9d2-11ee-989a-71cec6336ac8 Azure Error: [InvalidUri] 400 The request URI is invalid.
FAILED pyarrow/tests/test_fs.py::test_move_file[AzureFileSystem] - OSError: Failed to delete a file: test-move-target-file: https://tomtesthns.blob.core.windows.net/1b30faf1-c9d2-11ee-989a-71cec6336ac8/test-move-target-file Azure Error: [LeaseIdMissing] 412 There is currently a lease on the resource and no lease ID was specified in the request.
FAILED pyarrow/tests/test_fs.py::test_open_output_stream_metadata[AzureFileSystem] - OSError: CommitBlockList failed for 'https://tomtesthns.blob.core.windows.net/283b1457-c9d2-11ee-989a-71cec6336ac8/open-output-stream-metadata'. Committing is required to flush an output/append stream. Azure Error: [InvalidMetadata] 400 The metadata specified is invalid. It has charact...

Most of them are failed to create directory which I think boils down to fs->CreateDir("directory/") failing on hierarchical namespace. I will make an issue and PR about this case.

After sorting the obvious ones (https://github.com/apache/arrow/issues/40052). The move related failures are
FAILED pyarrow/tests/test_fs.py::test_copy_file[AzureFileSystem]
E   OSError: Failed to copy a blob. (https://tomtesthns.blob.core.windows.net/de8a4b50-c9d7-11ee-989a-71cec6336ac8/test-copy-source-file -> https://tomtesthns.blob.core.windows.net/de8a4b50-c9d7-11ee-989a-71cec6336ac8/test-copy-target-file) Azure Error: [CannotVerifyCopySource] 401 Server failed to authenticate the request. Please refer to the information in the www-authenticate header.
E   Server failed to authenticate the request. Please refer to the information in the www-authenticate header.
E   RequestId:00a565a9-001e-0044-6ce4-5d5550000000
E   Time:2024-02-12T18:52:28.9014466Z
E   Request ID: 00a565a9-001e-0044-6ce4-5d5550000000

FAILED pyarrow/tests/test_fs.py::test_move_directory[AzureFileSystem]
E   OSError: Failed to delete a directory: target-dir/: https://tomtesthns.blob.core.windows.net/de8a4b51-c9d7-11ee-989a-71cec6336ac8/target-dir Azure Error: [LeaseIdMissing] 412 There is currently a lease on the resource and no lease ID was specified in the request.
E   There is currently a lease on the resource and no lease ID was specified in the request.
E   RequestId:a33fdb5a-a01f-0062-76e4-5d1d48000000
E   Time:2024-02-12T18:52:31.3655532Z
E   Request ID: a33fdb5a-a01f-0062-76e4-5d1d48000000

FAILED pyarrow/tests/test_fs.py::test_move_file[AzureFileSystem]
E   OSError: Failed to delete a directory: target-dir/: https://tomtesthns.blob.core.windows.net/de8a4b51-c9d7-11ee-989a-71cec6336ac8/target-dir Azure Error: [LeaseIdMissing] 412 There is currently a lease on the resource and no lease ID was specified in the request.
E   There is currently a lease on the resource and no lease ID was specified in the request.
E   RequestId:a33fdb5a-a01f-0062-76e4-5d1d48000000
E   Time:2024-02-12T18:52:31.3655532Z
E   Request ID: a33fdb5a-a01f-0062-76e4-5d1d48000000

@av8or1 here is the link to the WIP PR https://github.com/apache/arrow/pull/40203


Update core CHANGELOG.md wording to be more accurate

Follow-up from https://github.com/Azure/azure-sdk-for-cpp/pull/4752#discussion_r1254735216

Unrelated CI error tracked in https://github.com/Azure/azure-sdk-for-cpp/issues/4761


Optimize react global context auth

Using Navigate and Link instead of windlow.lcoation.href fixed the issue!


Make sure division yields integer

In python 3, division by / yields float like 46 / 2 yields 23.0 which
shouldn't be input of list index. To make division result integer, it must
be 46 // 2 which yields 23 .
This is a fix for #457 . I'm not sure why this code had been working in my Python 3.5 environment, but this patch fixes the issue and working fine in my machine. Maybe should we check other / s usage for list index?

Thanks!


Add ones and eye - #2

Added a couple convenience routines and tests for every entry. I mean could add a million other things so there's a slippery slope argument to be made against just adding a bunch of extras to this module, but as quick and simple as it is, seemed reasonable.
I can merge this, just seeking a second opinion that it's not unreasonable.

Thanks!


ci: add unit, install and integration test workflows

@barryvdh You will need to:

Add a COMPOSER_AUTH containing the repo.magento.com JSON to your action secrets
2 . Enable Github Actions on the repo

The unit test fails: https://github.com/fruitcake/magento2-email-advanced-config/actions/runs/2571258987
The rest seems to be running.
I think I should probably add unit-test script to php vendor/bin/phpunit I guess?

See https://github.com/fruitcake/magento2-email-advanced-config/pull/4


Parsing base

PR with alpha features of the project.
Working on AWS(auth with Env vars or Env from Secret Keys) and GCP(auth with Service account)
Implements already methods for Vault, AzureKV and IBM Cloud, but they need to be more tested yet.
CLI Examples
kestoeso -i path/to/kes/definition.yaml --to-stdout --kes-namespace=kes --kes-deployment-name=kubernetes-external-secrets

kestoeso -i path/to/kes/ --to-stdout --kes-namespace=kes --kes-deployment-name=my-custom-name

kestoeso -i path/to/kes -o path/to/eso

Testing Locally
To test locally, the first thing that needs to be done is to deploy kes for the given provider. After that, deploy eso.
After that, you can test adderence convertion with this one-liner:
kestoeso -i path/to/kes/ --to-stdout --kes-namespace=kes | kubectl apply --dry-run=server -f  -

Examples
input

examples/aws-secretsmanager.yaml

apiVersion: kubernetes-client.io/v1
kind: ExternalSecret
metadata:
  name: aws-secretsmanager
spec:
  backendType: secretsManager
  # optional: specify role to assume when retrieving the data
  roleArn: arn:aws:iam::123412341234:role/let-other-account-access-secrets
  # optional: specify region of the secret
  region: eu-west-1
  data:
    - key: demo-service/credentials
      name: password
      property: password
    - key: demo-service/credentials
      name: username
      property: username

kes deployment

Name:                   kubernetes-external-secrets
Namespace:              kes
CreationTimestamp:      Thu, 14 Oct 2021 11:05:45 -0300
Labels:                 app.kubernetes.io/instance=kubernetes-external-secrets
                        app.kubernetes.io/managed-by=Helm
                        app.kubernetes.io/name=kubernetes-external-secrets
                        helm.sh/chart=kubernetes-external-secrets-8.3.0
Annotations:            deployment.kubernetes.io/revision: 2
                        meta.helm.sh/release-name: kubernetes-external-secrets
                        meta.helm.sh/release-namespace: kes
Selector:               app.kubernetes.io/instance=kubernetes-external-secrets,app.kubernetes.io/name=kubernetes-external-secrets
Replicas:               0 desired | 0 updated | 0 total | 0 available | 0 unavailable
StrategyType:           RollingUpdate
MinReadySeconds:        0
RollingUpdateStrategy:  25% max unavailable, 25% max surge
Pod Template:
  Labels:           app.kubernetes.io/instance=kubernetes-external-secrets
                    app.kubernetes.io/name=kubernetes-external-secrets
  Service Account:  kubernetes-external-secrets
  Containers:
   kubernetes-external-secrets:
    Image:      ghcr.io/external-secrets/kubernetes-external-secrets:8.3.0
    Port:       3001/TCP
    Host Port:  0/TCP
    Environment:
      AKEYLESS_API_ENDPOINT:           https://api.akeyless.io
      AWS_REGION:                      us-west-2
      GOOGLE_APPLICATION_CREDENTIALS:  /app/gcp-creds/gcp-creds.json
      LOG_LEVEL:                       info
      LOG_MESSAGE_KEY:                 msg
      METRICS_PORT:                    3001
      POLLER_INTERVAL_MILLISECONDS:    10000
      WATCH_TIMEOUT:                   60000
      AWS_ACCESS_KEY_ID:               <set to the key 'access-key' in secret 'aws-secret'>  Optional: false
      AWS_SECRET_ACCESS_KEY:           <set to the key 'secret' in secret 'aws-secret'>      Optional: false
    Mounts:
      /app/gcp-creds from gcp-creds (ro)
  Volumes:
   gcp-creds:
    Type:        Secret (a volume populated by a Secret)
    SecretName:  gcp-creds
    Optional:    false
Conditions:
  Type           Status  Reason
  ----           ------  ------
  Available      True    MinimumReplicasAvailable
  Progressing    True    NewReplicaSetAvailable
OldReplicaSets:  <none>
NewReplicaSet:   kubernetes-external-secrets-94b467b7 (0/0 replicas created)
Events:          <none>

command line:
kestoeso -i examples/aws-secretsmanager.yaml --kes-namespace=kes --stdout
output
apiVersion: external-secrets.io/v1alpha1
kind: ClusterSecretStore
metadata:
  creationTimestamp: null
  name: secretsmanager-secretstore-autogen-xvlbzgba
spec:
  controller: ""
  provider:
    aws:
      auth:
        secretRef:
          accessKeyIDSecretRef:
            key: access-key
            name: aws-secret
            namespace: kes
          secretAccessKeySecretRef:
            key: secret
            name: aws-secret
            namespace: kes
      region: eu-west-1
      role: arn:aws:iam::123412341234:role/let-other-account-access-secrets
      service: SecretsManager
status:
  conditions: null

---
apiVersion: external-secrets.io/v1alpha1
kind: ExternalSecret
metadata:
  creationTimestamp: null
  name: aws-secretsmanager
spec:
  data:
  - remoteRef:
      key: demo-service/credentials
      property: password
    secretKey: password
  - remoteRef:
      key: demo-service/credentials
      property: username
    secretKey: username
  secretStoreRef:
    kind: ClusterSecretStore
    name: secretsmanager-secretstore-autogen-xvlbzgba
  target:
    name: aws-secretsmanager
    template:
      metadata: {}
status:
  refreshTime: null

---

This PR is a draft mainly because It's too big, and because I think some design decisions can still be taken at this time (although it's not supposed to be a long-living tool).

Hey all!
Today I've finished testing with the following providers:

IBM
GCP
AWS
Azure
Vault

I'm changing this PR from draft to an actual PR. Waiting on feedback.

Hey @gusfcarvalho nice work! I think we should clean up the code a bit before merging it. Could you please:

remove comments of unneeded code (imports, example code)
finish documentation of CLI help

I think then we're good to merge IMO.

Looking forward to checking this out!

Hey @moolen and @knelasevero ! Sorry for the long delay, got a little bit busy with work.
I also took the chance to improve a little bit the map of templates, in order to allow some templating (the easy ones) to be compatible with the tool.

Gonna merge this one. We can iterate further with more PRs :)
@gusfcarvalho maybe goreleaser makes sense for this project? Then it is easier for us to release and get people to use it. We can open an issue if it makes sense


Top level notebooks: Import from modules

This is part of my attempt to make modules more consistent and truly modular.
The end goal is to ensure that end users can import every thing from separate modules (dataset, instrument ...)
This is small step in that direction

bors merge


chore(main): release 1.2.10

:robot: I have created a release beep boop
1.2.10 (2024-01-17)
Bug Fixes

Generate new packages (#258) (e830914)

This PR was generated with Release Please. See documentation.

:robot: Release is at https://github.com/somleng/sms-gateway/releases/tag/v1.2.10 :sunflower:


Update manifests for latest Crosswalk Project

Valid version numbers must follow the format "ab.cd.efg", where only 'a'
is mandatory.
As per manifest-fields.json in crosswalk-website, the manifest fields
app.launch.local_path and version have been replaced by start_url
and xwalk-version respectively since Crosswalk 8.
The samples shall not target a specific version of Crosswalk, instead
they shall target the latest ones. I will try to refine the space dodge
game samples for this purpose if no others take action at XWALK-4748.
BUG=https://crosswalk-project.org/jira/browse/XWALK-2569

@rakuco PTAL, thanks.

lgtm, thanks

I am on holiday until Tuesday 1st September.
If urgent, please email my colleague Phil Walton (phil@softforge.co.uk).
Kind regards,
Joe Palmer


Update documentation to correct the static method calls of non static methods

Grayloon\Magento\Magento::api is not a static method.

Hey @davoc,
Thanks. Feel free to send a PR otherwise, it's not really a problem. You can either register the facade or just the methods described in the documentation example.

Hey @davoc,
Thanks. Feel free to send a PR otherwise, it's not really a problem. You can either register the facade or just the methods described in the documentation example.


Enable -werror

Warnings should be treated as errors to ensure the quality of the code remains.

Done in ec3e324.


NIFI-9437 Flowfile Expiration cannot exceed 24 days

Summary
NIFI-9537 enables setting flowfile expiration longer than 24 days.
Tracking
Please complete the following tracking steps prior to pull request creation.
Issue Tracking

[x] Apache NiFi Jira issue created

Pull Request Tracking

[x] Pull Request title starts with Apache NiFi Jira issue number, such as NIFI-00000
[x] Pull Request commit message starts with Apache NiFi Jira issue number, as such NIFI-00000

Pull Request Formatting

[x] Pull Request based on current revision of the main branch
[x] Pull Request refers to a feature branch with one commit containing changes

Verification
Please indicate the verification steps performed prior to pull request creation.
Build

[ ] Build completed using mvn clean install -P contrib-check

[x] JDK 8
[ ] JDK 11
[ ] JDK 17

Licensing

[ ] New dependencies are compatible with the Apache License 2.0 according to the License Policy
[ ] New dependencies are documented in applicable LICENSE and NOTICE files

Documentation

[ ] Documentation formatting appears as expected in rendered files

Will review

I tested this out with a unit test in StatelessFlowFileQueue and found that the limit was still 24 days, which seems to be a result of the setFlowFileExpiration() method still casting to int. I also tested the function at runtime still works correctly for small times like 10 seconds. I did not verify that the expiration now works for > 24 days.

Hello @thenatog,
Thank you very much for your review. I hesitated whether flowfile expiration should be corrected as even 24 days seemed too long for stateless NiFI however you are right, let's be consistent. I've modified the code accordingly.

+1 looks good, will merge


shm/copy-region doesn't always copy the highlighted region

I'm not sure if I'm misunderstanding how shm/copy-region is supposed to work, but it seems like shm's copy-region frequently gets confused and copies some unexpected part of the buffer than what is the highlighted shm region. I expect it to copy what I think shm considers to be the current "node". I'm using shm 20160211.1154
The minimal example I can show is:
data Foo = Foo {foo :: String|}

I hit ] until foo :: String is under the current node face. I then hit M-w for shm/copy-region, move down a line and hit C-y for shm/yank and it looks like:
data Foo = Foo {foo :: String|}
}

In other words, it pastes the } rather than foo :: String. Another example, if I move point to f|oo so just the word "foo" is the current node and do the same, it yanks from point onward: oo :: String}. Is shm/copy-region misbehaving or am I really looking for an as-yet non-existent shm/copy-node?
Thanks, and thanks so much for SHM, it has improved my Haskell life greatly!

As an update, I noticed you actually have the functionality for this built into shm-kill-node so its trivial to implement this:
(defun shm/copy-node ()
  "Copy the current node."
  (interactive)
  (shm-kill-node nil nil nil t))

Now I just need to come up with a reasonable keybinding for it. Is there any interest in this being in the core functionality?

shm/copy-region just works on the regular Emacs region. You're supposed to use e.g. shm/mark-node via C-M-SPC to set the region to the boundaries of the node. Then shm/copy-region will copy the selected region.

(Sometimes you copy more than one node like n do statements or import lines, in which case shm/copy-region will still work as expected.)

Ah ok. So this is totally a misunderstanding of terminology on my part. I think I had mixed up node and region in my head. It looks like shm/copy-node will save me a few keystrokes from having to mark node though, so I'm happy. Thanks!

👍


[SVCS-421] Remove unsizable response reader flag

Ticket
https://openscience.atlassian.net/browse/SVCS-421
Purpose
The purpose of this PR is the remove the superfluous unsizable argument from the response reader safely and change the stream size behavior to make more sense.
Changes

Removes unsizable parameter for StreamResponseReader
Changes conditional so size parameter directly controls stream size.
Adds unit tests.

Side effects
None that I know of.
QA Notes
Download a file from each of the following providers:

GoogleDrive
Github
Bitbucket
Box
Dropbox
GitLab

These all use size as a positional argument.
Deployment Notes
None.

Coverage increased (+0.1%) to 89.89% when pulling ab86787ab4395b510c7658d736de96eff21811c1 on Johnetordoff:feature/remove-unsizable-response-reader-flag into 3ec764ae879c107c405d67b1e2d60d1018eafa96 on CenterForOpenScience:develop.


AudioStreamOGGVorbis.loop default should be false

From my personal experience, non-repeating sound effects normally outnumber looping music tracks in a game project.

From the docs:

In general, what is recommended, is to use WAV for most sound effects, especially those that are short and repetitive, and OGG for music, voice and long sound effects.

Hmm... Didn't know that. Thanks.
More from the docs:
- Audio files of type .wav are considerably big, but use little amount of your CPU to play. Hundreds of them can be played simultaneously with little impact to performance. This format is usually best for short sound effects, as the importer will trim them and convert them to IMA-ADPCM.
- Audio files of type .ogg are much smaller, but use considerably more amount of CPU power to play back, so only a few can be played back (especially on mobile!). This format is usually best for music or long sound effect sequences. It also works well for voice at relatively low bitrates.


Deploy avahi in resin-image

Avahi service will be installed and enabled on development and normal resin-image. This service needs to be able resolve local hostname using libnss-mdns.
This needs a test case.

This is great! One difficulty, that devices of the same type have the same host name set at the moment, isn't it? Would that cause issue with the avahi operation, e.g. having a bunch hosts called raspberrypi3 on the network?

@imrehg By default each device will have uuid as hostname. The preconfigured resin one will be used only in development where it is expected to have only one device in the local network. See the referenced #318

thanks, replying there


Error on main website

Opening main page welcomed with next error message:
In "index.sql": The following error occurred while executing an SQL statement:
error returned from database: (code: 1) no such table: example
The SQL statement sent by SQLPage was:
SELECT 'dynamic' AS component, properties FROM example WHERE component = 'shell' LIMIT 1;

The documentation page also gives an error:
In "documentation.sql": The following error occurred while executing an SQL statement:
error returned from database: (code: 1) no such table: example
The SQL statement sent by SQLPage was:
SELECT 'dynamic' AS component, json_patch(json_extract(properties, '$[0]'), json_object('title', coalesce(CAST(? AS TEXT) || ' - ', '') || 'SQLPage Documentation')) AS properties FROM example WHERE component = 'shell' LIMIT 1;

Browser: Tor 14.0.2

Now evrything works fine

I'm leaving this opened until we pinpoint and fix the underlying issue.


fix: Schema registry message key field format correction

About this change - What it does
References: #347
Confluent Schema Registry message key uses field order of keytype, subject, version, magic and Karapace has used order of subject, version, magic, keytype. Kafka won't compact the topic correctly as the key field byte contents are different.
Confluent Schema Registry uses the most compact format of the JSON in the key, for example {"keytype":"SCHEMA","subject":"foo","version":1,"magic":0}. There is no whitespaces, indent nor linebreaks.
Why this way
First approach
On Karapace startup the schema message topic is consumed and each key format checked. If format is not correct a tombstone message and corrected message is sent to the topic.
I used the approach @hackaugusto suggested in the ticket but decided to use the schema reader thread.
The limitation is that it cannot call the schema writing functions as those will trigger offset watching and would cause deadlock.
Another issue is with registries that have a lot of records and this has a significant memory pressure as invalid entries are first collected in memory and then processed. This was rejected and next approach taken.
Second approach, current solution
The correction processing is moved to background thread which is started when Karapace leader is ready. The correction is run per record and consumed from start. There is a special marker record sent to schemas topic when correction is run. This allows to identify if correction has already been run.
Notes

Backup restore could also correct the keys for records.

I think KeyFormatCorrector could be made slightly simpler by removing the flag whether the correction has been already run from that. KeyFormatCorrector could do exactly what its name state, correct the keys. And whether or not, the correction has been run should be outside of KeyFormatCorrector itself.
In practise

key_correction_done flag would not exist.
If told start, it would start (if not running already). It's the problem of the caller if it has already been run.
The marker handling (_send_key_correction_done_marker) would not be in KeyFormatCorrector but in the caller side.
When the KeyFormatCorrector is ready, it'd tell using a callback or some other mechanism to its "owner" that it's ready. That entity would then write the marker, i.e. call _send_key_correction_done_marker.

The only problem I can see is that the caller would use a different Kafka producer to write the marker. And that could at least fail.


Local name resolution (mDNS) is not working with fresh install of WSL 2 on Windows 11

Windows Version
Microsoft Windows [Version 10.0.22631.4541]
WSL Version
<IP_ADDRESS>
Are you using WSL 1 or WSL 2?

[x] WSL 2
[ ] WSL 1

Kernel Version
Linux version <IP_ADDRESS>-microsoft-standard-WSL2 (root@f9c826d3017f) (gcc (GCC) 11.2.0, GNU ld (GNU Binutils) 2.37) #1 SMP Tue Nov 5 00:21:55 UTC 2024
Distro Version
24.04
Other Software
On a fresh install of Windows 11 with WSL 2, local IP names ( e.g.: beanie.local) resolved correctly in PowerShell but not within WSL 2.
Steps Taken:

Works in PS not in WSL:

Attempted to ping beanie.local insode Powershell, ping succeeded.
Attempted to ping beanie.local inside WSL 2, but the ping failed.

Avahi Daemon - is this the problem?:

Installed and started avahi-daemon in WSL 2 to enable mDNS resolution.
Ran avahi-browse to check if the mDNS service was working, but the command hung and did not return any results.
Checked the avahi-daemon logs via journalctl and saw no errors during startup, but it didn't help with mDNS resolution in WSL 2.

Firewall Configuration - is this the problem?:

Attempted to enable mDNS by opening ports in Windows Firewall:

Inbound Port: Allowed UDP traffic on port 5353 for mDNS.
Outbound Port: Allowed outbound traffic on port 5353 for mDNS.

Despite these changes, mDNS resolution still didn’t work within WSL 2.

Manual Workaround - bummer...why is this so...frustrating?:

Edit /etc/hosts in WSL 2: As a workaround, manually added an entry for beanie.local in the WSL /etc/hosts file, mapping it to its IP address.
Configure /etc/wsl.conf: Adjusted DNS settings in /etc/wsl.conf to try to improve name resolution and restarted WSL after modifications.

Issue with mDNS Service in WSL 2:

Despite configuring avahi-daemon and adjusting firewall settings, mDNS still didn't resolve .local addresses within WSL 2.
The issue is that mDNS multicast packets are not natively supported in WSL 2, and avahi-daemon or similar services cannot fully resolve .local addresses.

Resolution:
While manual entries in /etc/hosts provided a workaround, the mDNS service didn't work as expected within WSL 2, even after opening the necessary ports. The firewall changes were tested (allowing inbound and outbound UDP traffic on port 5353), but they did not enable mDNS support in WSL 2.
Conclusion - Huh? Please help?:
The problem was temporarily fixed by:

Editing /etc/hosts: Manually adding an entry for beanie.local in WSL 2's /etc/hosts file, mapping it to the correct IP address.
**Editing /etc/wsl.conf: add the following entry to /etc/wsl.conf:

# [network]
# generateHosts = false

Request for Help on Stack Overflow:
Any advice on getting full mDNS support working inside WSL 2 would be greatly appreciated."
Repro Steps
see above..
Expected Behavior
ping beanie.local resolves without having to modify a hosts file. All locals just resolve.
Actual Behavior
ping beanie.local does nto resolve unless added to hosts file and 3 chickesn are spun clockwise over my head.
Diagnostic Logs
No response

Facing the same issue, I have created a script to manually update etc/hosts and added it in .bashrc as an alias. This way whenever the ip changes for .local domain, I can update the etc/hosts file manually through command.

thanks for reporting the issue. can you please check if the documentation we have about mDNS resolution resolves your issue? (https://learn.microsoft.com/en-us/windows/wsl/troubleshooting#resolve-local-names-in-wsl)


[ALLUXIO-6456]change the attribute of mBufferNotFullOrFailed to final

change the attribute of mBufferNotFullOrFailed to final

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/17153/
Test PASSed.


Repeated line?

There are any reason because of the duplicated line?
https://github.com/datasciencebr/rosie/blob/196dd673618c187af397f0a47f5e6ede8499b62e/rosie/chamber_of_deputies/adapter.py#L52

There are any reason because of the duplicated line?

AFAIK, no. Probably just a silly mistake… Feel free to fix it : )


Dialogflow API is not working

My Dialogflow query endpoint is returning 500 response

See this :  https://github.com/dialogflow/dialogflow-javascript-client/issues/103#issuecomment-429536937


make new membership start day after previous ends

Addresses #2147

@maneesha I added small change for when user is creating a new membership. Now the agreement end date will be 1 day lower than previously calculated.
For example, when user selects 2022-05-15 as agreement start date, then new agreement end date will be 2023-05-14 (+1 year, -1 day). Previously it would have been +1 year (2023-05-15).
Apart from that I fixed some small issues, and one pretty big one: agreement duration warning was not being shown.
Please take a look and decide if you like the changes.


Cyberpion detection

Added a detection using the Cyberpion connector

@v-rucdu As requested, here is the detection.

@v-rucdu As requested, here is the detection.

@aprakash13 Do you need anything further from me to approve this detection?

Helloooo?

Helloooo? @aprakash13 @shainw @NoamLandress

@cyberpion-yotam - Apologies on the missed follow up on this.  Simply slipped out of view for Ajeet, but he is on it today and will get a response out.


VS shows documentation for attributes when writing the component tag

Reproduced using 3.0.0-preview4 SDK and d16.1stg

The fix for this would be in WTE. They build the tooltip.

@danroth27 can you please follow up with the tooling team so that this can be fixed? Thanks!

Adding @NTaylorMullen since he was seeing something similar in VS Code as well.

Ya there's a good chance the way we're generating bind, event handlers etc. TagHelperDescriptors may be resulting in this behavior. Would have to investigate more. Either way it's consistent in VSCode.

That's because you implemented tooltips the same thing WTE does.
IDK how we would generate different descriptors without redoing everything. What we generate is "correct" - but we don't like how that displays, so we should change how it displays.

Assigning to Taylor as he still believe this is under our control.

This should be fixed already.

This should be fixed already.

Wait really? When?

@rynowak?

IDK LOL?

@NTaylorMullen please follow up on this. Let's either get this fixed, if we can do it on our own, or please follow up with the owners to get this fixed.


ES6 string.includes does not work on IOS 8 (it works on ios9)

Spent like two says debugging this and it boiled down to that "ES6 string.includes does not work on IOS 8"
Tested on IOS 9 it works. I have switched to good ole string.indexOf for now and now my app runs smoothly.
When debugging you dont see this as the code runs in a chrome browser (hence hard to discover)
React Native version 0.19.
Ios version 8.4.1

spent like two days

Thanks for finding this, javascript runtime environment differences are a pain -_-
We should add this polyfill https://developer.mozilla.org/en/docs/Web/JavaScript/Reference/Global_Objects/String/includes to packager/react-packager/src/Resolver/polyfills/String.prototype.es6.js
Would you be interested in submitting a PR to do it?


How to export the painting to image

Hi,
Is it possible to export the painting/drawing I did in scribble to image (jpg, png) or pdf ?
Best regards
Mike

Hi,
at the moment, this is not possible. It is a planned feature however and should arrive in the near future :)

Version 0.2.0 is out and with it comes a renderImage() method in the ScribbleNotifier! You can take a look at the example to see how it works :) feel free to contact me if you have any more questions


Bug report: (1.16.1) Cannot select file (not folder) on Linux with XDG Desktop Portal enabled

Describe the bug
On Arch Linux with KDE, if XDG Desktop Portal enabled (xdg-desktop-portal and xdg-desktop-portal-kde installed and set the environment variable GTK_USE_PORTAL=1), you may not able to select file to send, as the selection window will close immediately after it pops up, and LocalSend will raise you "You have not granted the necessary permissions. Please grant them in the settings."
To reproduce

To ensure the XDG Desktop Portal is enabled, install xdg-desktop-portal and xdg-desktop-portal-kde, then open a terminal and set the environment variable GTK_USE_PORTAL=1.
Open LocalSend in the same terminal.
Click "File" (not "Folder") in the send page. You should see a file selection window pop up that matches the desktop environment style, this is provided by XDG Desktop Portal.
Wait a few seconds and the window may suddenly close on its own.
If the window is still open, navigate to a directory with many files (such as /usr/bin), scroll down, placing the cursor over the file list to trigger this bug.

Expected behavior
The file selection window should not be closed on its own.
Screenshots
No response
Desktop (please complete the following information)

OS: Arch Linux

Smartphone (please complete the following information)
No response
Additional context
No response

also getting this error, but with an entirely different portal on a different application. librewolf prints GTK_FILE_CHOOSER_ACTION_SELECT_FOLDER is not supported by GtkFileChooserNativePortal because portal is too old.


Can't override 'go vet' executable (can override golint though)

I'm doing some development and want to use an alternate go vet to check some things. I do the same for golint, so I do something like this:
let g:syntastic_go_golint_exec = '~/bin/mygolint'
let g:syntastic_go_govet_exec = '~/bin/mygovet'

For golint (mygolint) this works fine, but syntastic seems to ignore mygovet. I'm not the best viml coder out there, but the salient difference between the two seems to be:
golint.vim:
    let makeprg = self.makeprgBuild({})

govet.vim
    let makeprg = 'go vet'

Said in another way, go vet is hardcoded. Can this be changed? If so, what would be the best way to go about it?
Thanks!
UPDATE:
I should have, of course, ran :PluginUpdate first. I see that the current govet.vim code is:
    let makeprg = self.getExec() . ' vet'

I'll try to see if I can get this to work but I'll probably need to do some contortions with an alternate dispatching script.

For golint (mygolint) this works fine, but syntastic seems to ignore mygovet.

Yes, this is documented.

let makeprg = self.getExec() . ' vet'

Yes, you can override the go executable.  You can't override the vet argument.

I'll try to see if I can get this to work but I'll probably need to do some contortions with an alternate dispatching script.

What exactly are you trying to do?

What exactly are you trying to do?

Like I said, running a custom govet binary. Anyway, I "fixed" it by wrapping it in a shell script which replaces the "vet" argument with .. It works fine. Thanks!


liburing update to 2.7

Library name
liburing
New version number
2.7
Other information that may be useful (release notes, etc...)
Bug fixes since April 2024 + sync to kernel 6.10 (aligned with Ubuntu Noble kernel):
https://github.com/axboe/liburing/releases/tag/liburing-2.7

https://github.com/microsoft/vcpkg/pull/40601


Example Gantt Chart

After a couple of years I think that the Asana + InstaGantt might be the best free product to get them going on.
https://asana.com/apps/instagantt
Would be nice to have one that they can see. And show them how to do the screenshots.

@swkresie Did we do this?

I added a link to the shoe tying machine (2018 project) spring quarter gantt chart to the Reports page under the scheduling information section for report 1 and 2. I also added the link to the Meetings page where AIO content is described. I also added the link to the Gantt charts page.

Thanks!


Cleaned up demo app model for sl-calendar

Closes softlayer/sl-ember-components#1233

Reviewed 1 of 1 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from the review on Reviewable.io


Store existing schemas to the DB

In the example below I use MongoEngine to store objects to the DB. The DB models are in the folder server/openapi_server/dbmodels.
https://github.com/nlpsandbox/data-node

Ah, that's where the models were located!


Add Ashsanti to Contributors list

Hi  @Ashsanti, I'm quite elated about your pull request. I wanna evolve this project to addresses various problems faced by first-time contributors. I'd love to learn about your journey in open source community, the problems, pain points you had etc.
Could you explain how you felt when you went through the tutorial, made a pull request and learned that I merged it?
We’ve recently added social share  to our web app. Could you please go to https://roshanjossey.github.io/first-contributions/#social-share and share your first contribution to open source?
Also, check out projects with easy issues while you’re there.

hi @Roshanjossey, thanks for the wonderful journey that you have created here. Its perfect for first timers to learn about git. thanks a ton for making it so simple to understand with step by step procedure.
i followed all the steps carefully, and learnt about those commands and it worked for me!
keep up your work. Thanks again:)

I’d urge you to continue contributing to other open source projects.
We also have a slack team to help/mentor people trying to contribute to open source projects.
You can join the team by going to https://goo.gl/PM1Jdh


dev mode ignoring X-Forwarded-Proto and X-Forwarded-Host headers

Discussed in https://github.com/sveltejs/kit/discussions/11900

Originally posted by yannishin February 26, 2024
I expected the return from the Hook to be event.url.host=ui.foo.com, event.url.protocol=https:, but it is returning event.url.host=ui_server/ui, event.url.protocol=http:.
How should I solve this issue?
Given that event.request.headers.get("X-Forwarded-Host") and event.request.headers.get("X-Forwarded-Proto") are returning null, it seems that the node server(adapter-node.) is not recognizing the X-Forwarded-??? headers.
For reference, the API Server developed with spring boot is correctly returning ui.foo.com, https:.
This is Nginx Config
upstream ui_server {
ip_hash;
ui.foo.com:17001;
keepalive 100;
}
location /ui {

    proxy_pass  http://ui_server/ui;

    proxy_http_version 1.1;
    proxy_set_header Connection $connection_upgrade;
    proxy_set_header Upgrade $http_upgrade;
    proxy_set_header        Host $host;
    proxy_set_header        X-Real-IP $remote_addr;
    proxy_set_header        X-Forwarded-For $proxy_add_x_forwarded_for;
    proxy_set_header    X-Forwarded-Proto $scheme;
    proxy_set_header    X-Forwarded-Host $host;
    proxy_set_header Forwarded "for=$proxy_add_x_forwarded_for; host=$host; proto=$scheme";

    charset utf-8;

    access_log /opt/naon/app/nginx/logs/ui-access.log postdata;
  }

@yannishin Are the appropriate environment variables set at runtime in the built application? https://kit.svelte.dev/docs/adapter-node#environment-variables-origin-protocolheader-hostheader-and-port-header

@Conduitry
https://kit.svelte.dev/docs/adapter-node#environment-variables-origin-protocolheader-hostheader-and-port-header
The description in the link above seems to apply to the settings when building, and I want it to apply in dev mode.

Ah, okay, if it's in dev mode, then you're not actually running any adapter-node code.
What you're asking to do isn't currently supported. We could either add SvelteKit-level configuration for controlling this at dev time only (which feels a bit weird to me), or we could roll this into work to let adapter influence the dev-time behavior of apps (which feels like the better solution, but will take longer to settle on an API - #2304).

Because of this development with Cloudflare tunnel + SvelteKit is harder :(


extends audioWorkletNode

Hi, in this repo you didn't implement class XXX extends window.audioWorkletNode function in reactjs. I got an error when I was trying to do so.
Same issue I posted in create-react-app repo:
https://github.com/facebook/create-react-app/issues/6517
Have you got a solution for it?

Hi there,
I didn't extend the base AudioWorkletNode class because I had no reason to extend the functionality of the API as it stands. I was having a similar problem with the AudioWorkletProcessor interface which was solved by serving processors from the public directory.
You may find the following links useful:
https://hackernoon.com/implementing-audioworklets-with-react-8a80a470474
https://stackoverflow.com/questions/49971779/error-audioworkletnode-is-undefined-in-react-app


Migrate from dask[complete] to dask[array] to reduce number of dependencies

Pull Request Checklist:

[x] This PR addresses an already opened issue (for bug fixes / features)

This PR fixes #465

[ ] Tests for the changes have been added (for bug fixes / features)
[ ] Documentation has been added / updated (for bug fixes / features)
[ ] HISTORY.rst has been updated (with summary of main changes)
[ ] bumpversion (minor / major / patch) has been called on this branch
[ ] Tags have been pushed (git push --tags)

What kind of change does this PR introduce?
This PR changes the dask dependency to use [array] in lieu of [complete]. This is raised due to a bug present in<EMAIL_ADDRESS>where [complete] was erroneously removed. On examination, the test ensemble doesn't perform .to_dataframe() or distributed operations, so the reasoning here is that we shouldn't be installing the libraries needed for these operations in a "vanilla" xclim installation.

Does this PR introduce a breaking change?
No.

Other information:

Maybe we should add a note in the docs about this?
Also, I think that distributed is used in the  workflow example notebook. The build may not fail, but that's because notebooks aren't executed.

This is true. Leads me to believe that it might be a good idea to add a new recipe with those libraries installed or to simply document that distributed is an optional dependency for doing "cool stuff". I'll add to this PR and ask for another review.

It could be in setup.py docs_requirements only.


Somehow v1 of this action can't be found

As seen on the CI logs here https://github.com/JuliaPlots/GraphRecipes.jl/actions/workflows/compathelper.yml the action complains about not finding v1 of compathelper. Though using version v999.0.1 works.

Yeah, this action has not yet been officially released

v999.0.1 is just a testing tag that I will delete before I officially release this action.


Code coverage should be over 80% on final release of 2.0

https://codecov.io/github/monixio/monix?branch=master

2.0.0 was already released and the target has definitely been reached. Closing.


fix: ssr in dev mode

Fix #188
There was an issue with waku dev --with-ssr. It worked within the repo, so it was hard to notice.
The error is now reproduced within the repo, but CI doesn't have --with-ssr yet. #186

An idea clicked me, and it worked.

The error is now reproduced within the repo, but CI doesn't have --with-ssr yet. https://github.com/dai-shi/waku/issues/186

I'm thinking of separating the CI code with examples. Since examples are just showcases to the user. test need more edge case, logic and less UI

The error is now reproduced within the repo, but CI doesn't have --with-ssr yet. #186

I'm thinking of separating the CI code with examples. Since examples are just showcases to the user. test need more edge case, logic and less UI

https://github.com/dai-shi/waku/pull/191


Initial import of istio.deps

@sebastienvas @yutongz PTAL
This change is required for auto upate on dependency as in istio/infra PR#336. With stable SHAs built-in, it also makes metrics much easy to get. If this looks good, similar changes will be rolled out to other istio repos.

Jenkins job istio/presubmit passed

can you say a little bit about what is the meaning of what is in this file and what is it used for ?

This file defines a list of repos as dependencies of the parent repo. It only concerns about repos under the istio project umbrella. Automated dependency update uses this file to learn what dependencies are and pull their latest versions to compare with what has been used on master of parent repo. It might be useful to take a look at https://github.com/istio/test-infra/blob/master/toolbox/util/dependency.go

thx! I was mostly curious about LastStableSHA and File


Embeddings: should we move to new OpenAI embeddings?

Currently, we use ada-002 as the proprietary (OpenAI) embedding algorithm. We could move to one of the new ones, or even offer a choice (text-embedding-small is a lot less expensive): https://platform.openai.com/docs/guides/embeddings

@Wang-Cankun @fengsh27 FYI


Linux Foundation svg is cutoff on smaller mobile devices

I wanted to open an issue to see if it is possible to edit the svg that is used. I wasn't sure if that was provided by the Linux Foundation and could have any changes. If changes can be made, I can work on making it fit on mobile now.
Here is what it currently looks like:

It can be changed. I ripped it from a Linux Foundation PDF because we didn't have a proper SVG version. ;)

Fixed by https://github.com/nodejs/new.nodejs.org/pull/63


Adding code scanning (CodeQL)

CodeQL is the code analysis engine developed by GitHub to automate security checks. You can analyze your code using CodeQL and display the results as code scanning alerts.
There are two main ways to use CodeQL analysis for code scanning:
Add the CodeQL workflow to your repository. This uses the github/codeql-action to run the CodeQL CLI. For more information, see "Setting up code scanning for a repository."
Run the CodeQL CLI directly in an external CI system and upload the results to GitHub. For more information, see "About CodeQL code scanning in your CI system ."
About CodeQL
CodeQL treats code like data, allowing you to find potential vulnerabilities in your code with greater confidence than traditional static analyzers.
You generate a CodeQL database to represent your codebase.
Then you run CodeQL queries on that database to identify problems in the codebase.
The query results are shown as code scanning alerts in GitHub when you use CodeQL with code scanning.
CodeQL supports both compiled and interpreted languages, and can find vulnerabilities and errors in code that's written in the supported languages.

I don't see this in the github actions list

@ValarDragon I think this has to get merged into main first prior to seeing it in the CI workflow :-/


213 rfc

References https://github.com/openownership/register/issues/213 .

For the PSC dataset, inserting new statement IDs into the destination index takes a long time, because the destination index has to be resorted each time. Optimise by introducing a second index, both of which are used for deduplication and sizes, but with usually only the second index resorted. This ensures by both indexes are kept in order at all times. Periodically (every 100K statements), merge the indexes and rewrite them, requiring a sort over all elements.
This reduces full indexing and combining of DK dataset from 1342s to 682s—almost a 2x increase in speed. Improvements are anticipated to be even better for larger datasets such as PSC.


No warning/error when adding a function tag/highlight on an address outside of that function

Version and Platform (required):

Binary Ninja Version: 4.1.5902 Enterprise
OS: macOS
OS Version: 15.0.1
CPU Architecture: aarch64

Bug Description:
Calling Function.add_tag("tags", "this_tag", address) or set_user_instr_highlight in Python with an address outside of the function will still succeed and create your tag/highlight with no error or warning, but never show the tag or highlight. This is...probably not what we want?
Expected Behavior:
We should, at minimum, be warning here. But, an error/exception might be the correct move here instead.

I have some alternate recommendations:

Add a warning in the documentation for Function.set_user_instr_highlight that there are no backend checks to ensure the address given is within the function, and if the address is not valid within the function the behavior is undefined.

Function.add_tag, when given an address, seems identical in functionality to BinaryView.add_tag. Instead of having this functionality in two places, one where it always works as expected and one where it sometimes silently fails (I'm assuming that assumption is correct), deprecate Function.add_tag and point people towards BinaryView.add_tag in the docs?

First one is a great suggestion, re-opening to track the documentation request.

Those are different functions with different purposes -- and both do have documentation that describes the differences I think?


Potential Use case: Could OSS donations of time / money be tax deductible?

This is technically lobbying another group for a slightly different purpose, so I'm not sure it fits with the core ideas of the project, but it came as a suggestion so I wanted to mention it here.
If a lot of .NET devs work in corporate shops and we're trying to convince them to donate time/money to causes that help move the entire industry forward, in the public, for free, then might we be able to raise awareness enough to gain a tax credit for those companies who contribute to such work?
Technically it's awarding companies for doing the right thing, but if it gets the outcome we'd like to see, I think it might be worth it to try.
This might need to be a separate project, though. And there's also the question of how such time would be quantified for the government (vs. the fact that OSS projects can assess for themselves who's contributing -- doing so in a government/regulated atmosphere is a different beast)

Just a reminder that different countries can have wildly variances when it comes to tax exemptions.
OTH if some countries pick it up, it may be easier to gain momentum in others


[OpenAI] [Assistants] add types/src

Packages impacted by this PR
@azure/openai-assistants
Issues associated with this PR
https://github.com/Azure/azure-sdk-for-js/issues/28529
Describe the problem that is addressed by this PR
types/src wasn't added to package build files list
What are the possible designs available to address the problem? If there are more than one possible design, why was the one in this PR chosen?
Are there test cases added in this PR? (If not, why?)
Provide a list of related PRs (if any)
Command used to generate this PR:**(Applicable only to SDK release request PRs)
Checklists

[ x] Added impacted package name to the issue description
[ ] Does this PR needs any fixes in the SDK Generator?** (If so, create an Issue in the Autorest/typescript repository and link it here)
[x ] Added a changelog (if necessary)

API change check
API changes are not detected in this pull request.


Reuse same object on retry.

Closes #549.
Fix from #551 was not not taking into account the retry call.

Thank you so much, @validide! Can you fix the sign-off requirement by following the below URL?
https://github.com/CycloneDX/cdxgen/pull/553/checks?check_run_id=16796882410

Yes, looking into it now.


implements and "Did not expect BoundT"

Here is the tryflow
Not sure if it's a bug or the way I'm using it.
I couldn't find a similar use case in flow tests.

@samwgoldman you're probably the best one to look into this.
looks like it ends up doing an InstanceT ~> ImplementsT where it compares the two map methods, but at least one hasn't been specialized for whatever reason (I think that's the bug?) so it does a PolyT ~> PolyT where the A from the interface hasn't been subst'd.

drat! investigating...


[Performance, Refactor, BugFix] Faster loading of uninitialized storages

cc @teopir
cc @shagunsodhani this is a good example of prealloc with tensordict. We were using a lot of lazy stacks and stacking at the last minute. Using a preallocated TD instead (create an empty td -> get a bunch of views of that td -> write on the first view, and all views get instantiated instantaneously) made the whole thing 20 - 1000x faster!

cc @teopir
cc @shagunsodhani this is a good example of prealloc with tensordict. We were using a lot of lazy stacks and stacking at the last minute. Using a preallocated TD instead (create an empty td -> get a bunch of views of that td -> write on the first view, and all views get instantiated instantaneously) made the whole thing 20 - 1000x faster!

Awesome <3


[FEA] Include bootstrap recommended configs in qualification output

Fixes https://github.com/NVIDIA/spark-rapids-tools/issues/410.
We add the recommended configs that the bootstrap tool would generate to the qualification output, both in the CLI and in the summary log file.
We will generate these recommended configs only when the qualification tool outputs a recommended GPU cluster.

Can you paste example output of the updates with bootstrap info for some of the qual commands?

An example qualification output with bootstrap recommendations is as follows:
____________________________________________________________________________________________________
                                        QUALIFICATION Report
____________________________________________________________________________________________________

Output:
--------------------
Qualification tool output: MY_OUTPUT_FOLDER/qual_20230724230150_aD24bdc7/rapids_4_spark_qualification_output
    qual_20230724230150_aD24bdc7
    ├── rapids_4_spark_qualification_output
    │   ├── rapids_4_spark_qualification_output_stages.csv
    │   ├── rapids_4_spark_qualification_output_unsupportedOperators.csv
    │   ├── rapids_4_spark_qualification_output_execs.csv
    │   ├── rapids_4_spark_qualification_output.log
    │   ├── ui
    │   │   └── html
    │   │       ├── raw.html
    │   │       ├── index.html
    │   │       ├── application.html
    │   │       └── sql-recommendation.html
    │   └── rapids_4_spark_qualification_output.csv
    └── qualification_summary.csv
    3 directories, 10 files
    - To learn more about the output details, visit https://nvidia.github.io/spark-rapids/docs/spark-qualification-tool.html#understanding-the-qualification-tool-output
    - Full savings and speedups CSV report: MY_OUTPUT_FOLDER/qual_20230724230150_aD24bdc7/qualification_summary.csv
+----+--------------------------------+-----------------------------+------------------+------------------+---------------+-----------------+-----------------+-----------------+
|    | App ID                         | App Name                    | Speedup Based    | Savings Based    |           App |   Estimated GPU |   Estimated GPU |   Estimated GPU |
|    |                                |                             | Recommendation   | Recommendation   |   Duration(s) |     Duration(s) |         Speedup |      Savings(%) |
|----+--------------------------------+-----------------------------+------------------+------------------+---------------+-----------------+-----------------+-----------------|
|  0 | application_xxxxxxxxxxxxxx_xxxx | xxxxxxxxxxx                 | Recommended      | Recommended      |         58.85 |           31.43 |            1.87 |           24.71 |
|  4 | application_xxxxxxxxxxxxxx_xxxx | xxxxxxxxxxxxxxxxxxx | Recommended      | Recommended      |         62.20 |           35.54 |            1.75 |           19.45 |
+----+--------------------------------+-----------------------------+------------------+------------------+---------------+-----------------+-----------------+-----------------+

Report Summary:
------------------------------  ------
Total applications                   2
RAPIDS candidates                    2
Overall estimated speedup         1.81
Overall estimated cost savings  22.01%
------------------------------  ------

Notes:
--------------------
 - Apps with the same name are grouped together and their metrics are averaged

Instance types conversions:
---------------  --  --------------------
Standard_DS3_v2  to  Standard_NC4as_T4_v3
---------------  --  --------------------
To support acceleration with T4 GPUs, switch the worker node instance types

Recommended Spark configurations:
-------------------------------------------------  -----
spark.executor.cores                               4
spark.executor.memory                              8192m
spark.executor.memoryOverhead                      5939m
spark.rapids.sql.concurrentGpuTasks                2
spark.rapids.memory.pinnedPool.size                4096m
spark.sql.files.maxPartitionBytes                  512m
spark.task.resource.gpu.amount                     0.25
spark.rapids.shuffle.multiThreaded.reader.threads  4
spark.rapids.shuffle.multiThreaded.writer.threads  4
spark.rapids.sql.multiThreadedRead.numThreads      20
-------------------------------------------------  -----

Looks great!  Only minor nit to change:
Recommended Spark configurations:

to
Recommended Spark configurations for running on GPUs:

Thank you @mattahrens! Changes have been updated.

Stdout with the new section:

the stdout still shows how to run bootstrap in case the user wants to regenerate the ecommendations on the new GPU-cluster
@mattahrens does this output look fine for you?

____________________________________________________________________________________________________
                                        QUALIFICATION Report
____________________________________________________________________________________________________

Output:
--------------------
Qualification tool output: /output_folder/qual_20230726164047_cF92b80f/rapids_4_spark_qualification_output
    qual_20230726164047_cF92b80f
    ├── qualification_summary.csv
    └── rapids_4_spark_qualification_output
        ├── ui
        │   └── html
        │       ├── sql-recommendation.html
        │       ├── index.html
        │       ├── application.html
        │       └── raw.html
        ├── rapids_4_spark_qualification_output_stages.csv
        ├── rapids_4_spark_qualification_output_unsupportedOperators.csv
        ├── rapids_4_spark_qualification_output.csv
        ├── rapids_4_spark_qualification_output_execs.csv
        └── rapids_4_spark_qualification_output.log
    3 directories, 10 files
    - To learn more about the output details, visit https://nvidia.github.io/spark-rapids/docs/spark-qualification-tool.html#understanding-the-qualification-tool-output
    - Full savings and speedups CSV report: /output_folder/qual_20230726164047_cF92b80f/qualification_summary.csv
+----+-------------------------+---------------------+----------------------+------------------+---------------+-----------------+-----------------+-----------------+
|    | App ID                  | App Name            | Speedup Based        | Savings Based    |           App |   Estimated GPU |   Estimated GPU |   Estimated GPU |
|    |                         |                     | Recommendation       | Recommendation   |   Duration(s) |     Duration(s) |         Speedup |      Savings(%) |
|----+-------------------------+---------------------+----------------------+------------------+---------------+-----------------+-----------------+-----------------|
|  0 | app-20200423035604-0002 | spark_data_utils.py | Strongly Recommended | Recommended      |       1201.72 |          317.25 |            3.79 |           10.96 |
+----+-------------------------+---------------------+----------------------+------------------+---------------+-----------------+-----------------+-----------------+

Report Summary:
------------------------------  ------
Total applications                   2
RAPIDS candidates                    2
Overall estimated speedup         3.23
Overall estimated cost savings  -4.33%
------------------------------  ------

Notes:
--------------------
 - Apps with the same name are grouped together and their metrics are averaged

Initialization Scripts:
-----------------------
To launch a GPU-accelerated cluster with RAPIDS Accelerator for Apache Spark, add the
  following to your cluster creation script:
    --initialization-actions=gs://goog-dataproc-initialization-actions-us-central1/spark-rapids/spark-rapids.sh \
    --worker-accelerator type=nvidia-tesla-t4,count=1

To create a GPU cluster, run the following script:

``bash
#!/bin/bash

export CLUSTER_NAME="dataproc-cluster"

gcloud dataproc clusters create $CLUSTER_NAME \
    --image-version=2.1.5-ubuntu20 \
    --region us-central1 \
    --zone us-central1-a-a \
    --master-machine-type n1-standard-2 \
    --num-workers 2 \
    --worker-machine-type n1-standard-2 \
    --num-worker-local-ssds 2 \
    --enable-component-gateway \
    --subnet=default \
    --initialization-actions=gs://goog-dataproc-initialization-actions-us-central1/spark-rapids/spark-rapids.sh \
    --worker-accelerator type=nvidia-tesla-t4,count=1 \
    --properties 'spark:spark.driver.memory=50g'

``

Recommended Spark configurations for running on GPUs:
-----------------------------------------------------

For the new GPU-accelerated cluster with RAPIDS Accelerator for Apache Spark,
  it is recommended to set the following Spark configurations:

-------------------------------------------------  -----
spark.executor.cores                               2
spark.executor.memory                              4096m
spark.executor.memoryOverhead                      1536m
spark.rapids.sql.concurrentGpuTasks                2
spark.rapids.memory.pinnedPool.size                103m
spark.sql.files.maxPartitionBytes                  512m
spark.task.resource.gpu.amount                     0.5
spark.rapids.shuffle.multiThreaded.reader.threads  2
spark.rapids.shuffle.multiThreaded.writer.threads  2
spark.rapids.sql.multiThreadedRead.numThreads      20
-------------------------------------------------  -----

Regenerating recommended configurations for existing clusters:
--------------------------------------------------------------

To generate the recommended configurations on an existing GPU Cluster,
  re-run the Bootstrap tool to provide optimized RAPIDS Accelerator
  for Apache Spark configs based on GPU cluster shape.
  Notes:
    - Overriding the Apache Spark default configurations on the cluster
      requires SSH access.
    - If SSH access is unavailable, you can still dump the recommended
      configurations by enabling the `dry_run` flag.

``bash
# To see all options, run `spark_rapids_user_tools dataproc bootstrap -- --help`

# The following cmd overrides the default Apache Spark configurations
# on the cluster (requires SSH)
spark_rapids_user_tools dataproc bootstrap \
    --cluster $CLUSTER_NAME \
    --verbose \
    --nodry_run

# The following cmd dumps the recommended configurations to the output
# without overriding the existing cluster configurations
spark_rapids_user_tools dataproc bootstrap \
    --cluster $CLUSTER_NAME \
    --verbose

``

pr-451-ammend.patch
@cindyyuanjiang I could not push to the feature branch. So, I uploaded the changes as a diff-patch

Couple comments:
1. I don't think we should have the bash with escape quotes in there.  It should be obvious what commands to run to create the cluster.

2. I don't think we want to give the bootstrap command since we've already provided the settings.

Thanks @mattahrens .
I disabled the bash scripts snippets and removed the bootstrap cmd.
New STDOUT looks as the following:
Report Summary:
------------------------------  ------
Total applications                   2
RAPIDS candidates                    2
Overall estimated speedup         3.23
Overall estimated cost savings  -4.33%
------------------------------  ------

Notes:
--------------------
 - Apps with the same name are grouped together and their metrics are averaged

Initialization Scripts:
-----------------------
To launch a GPU-accelerated cluster with RAPIDS Accelerator for Apache Spark, add the
  following to your cluster creation script:
    --initialization-actions=gs://goog-dataproc-initialization-actions-us-central1/spark-rapids/spark-rapids.sh \
    --worker-accelerator type=nvidia-tesla-t4,count=1

Recommended Spark configurations for running on GPUs:
-----------------------------------------------------

For the new GPU-accelerated cluster with RAPIDS Accelerator for Apache Spark,
  it is recommended to set the following Spark configurations:

-------------------------------------------------  -----
spark.executor.cores                               2
spark.executor.memory                              4096m
spark.executor.memoryOverhead                      1536m
spark.rapids.sql.concurrentGpuTasks                2
spark.rapids.memory.pinnedPool.size                103m
spark.sql.files.maxPartitionBytes                  512m
spark.task.resource.gpu.amount                     0.5
spark.rapids.shuffle.multiThreaded.reader.threads  2
spark.rapids.shuffle.multiThreaded.writer.threads  2
spark.rapids.sql.multiThreadedRead.numThreads      20
-------------------------------------------------  -----

We added back the bash script for creating the gpu cluster. Latest STDOUT looks like the following:
Report Summary:
------------------------------  ------
Total applications                   1
RAPIDS candidates                    1
Overall estimated speedup         1.43
Overall estimated cost savings  49.10%
------------------------------  ------

Instance types conversions:
------------  --  ------------
m5zn.6xlarge  to  g4dn.4xlarge
------------  --  ------------
To support acceleration with T4 GPUs, switch the worker node instance types

Initialization Scripts:
-----------------------

To create a GPU cluster, run the following script:

```bash
#!/bin/bash

export CLUSTER_NAME="user-tools-qualification-emr-20"

aws emr create-cluster \
    --name "$CLUSTER_NAME"  \
    --release-label emr-6.9.0 \
    --log-uri s3://$LOG_BUCKET/logs \
    --applications Name=Hadoop Name=Spark Name=Livy Name=JupyterEnterpriseGateway  \
    --bootstrap-actions '[{"Path":"s3://BUCKET_NAME/aws-emr-bootstrap.sh","Name":"My Spark Rapids Bootstrap action"}]'  \
    --ec2-attributes '{"KeyName":"MY_KEY_NAME","InstanceProfile":"EMR_EC2_DefaultRole","AvailabilityZone":"us-west-2b"}'  \
    --service-role EMR_DefaultRole \
    --instance-groups InstanceGroupType=MASTER,InstanceCount=1,InstanceType=m5a.12xlarge \
                      InstanceGroupType=CORE,InstanceCount=4,InstanceType=g4dn.4xlarge \
    --configurations file://aws-emr-configuration.json \
    --ebs-root-volume-size 100 \

Recommended Spark configurations for running on GPUs:
For the new GPU-accelerated cluster with RAPIDS Accelerator for Apache Spark,
it is recommended to set the following Spark configurations:

spark.executor.cores                               16
spark.executor.memory                              32768m
spark.executor.memoryOverhead                      8396m
spark.rapids.sql.concurrentGpuTasks                2
spark.rapids.memory.pinnedPool.size                4096m
spark.sql.files.maxPartitionBytes                  512m
spark.task.resource.gpu.amount                     0.0625
spark.rapids.shuffle.multiThreaded.reader.threads  16
spark.rapids.shuffle.multiThreaded.writer.threads  16
spark.rapids.sql.multiThreadedRead.numThreads      20


woofjs tutorial for onboarding total beginners without teacher

We are considering using woofjs in the near future with 6th graders, and currently I think the tutorials might be too hard without hints.  I'm worried it will be difficult to bridge from code.org to woofjs.  I was considering adding more hints to the basic tutorials to see if that would help.  For instance, in step 3 where it says "When you click on your shape, make it appear at a random spot." I think it would be useful to add a hint link for students to get started.  This could be two-level, initially just pointing them to the right set of blocks, or giving them some specific examples.
Would this be useful, or were you thinking more about screencasts ala Khan Academy or similar?

Thanks for reaching out! That point is definitely well taken.
We normally recommend moving students from code.org to Scratch and then to WoofJS. Potentially, having your students work though a few levels of our Scratch curriculum would make this Woof curriculum more approachable.

The main point of the WoofJS curriculum is to leverage students understanding of Scratch into a new understanding of text-based coding. "When you click on your shape, make it appear at a random spot." is a very reasonable hint for a student who's proficient in Scratch, which the curriculum is designed for. It would be no problem for them to come up with the following sequence of blocks:

From here, they merely need to look in the relevant block menus in Woof (or search for the blocks in the searchbar) to replicate this layout in Woof. Of course, the student will doubtlessly make syntax errors while doing this on their first time and that's where the teacher will come in to help them figure that out. Unfortunately our error messages aren't nearly good enough for students to be self-service there.
However, if you have a limited number of teachers that can help students figure out syntax errors or if you don't have time for them to become proficient in Scratch before they tackle WoofJS, I totally understand if you'd like more thorough walkthroughs of WoofJS. A WoofJS teacher not associated with our company made some amazing ones here: https://www.codemahal.com/tutorials/woofjs/
If you wanted to create more thorough walkthroughs for WoofJS, I'd love to help however we can. Potentially, we could even embed them in our curriculum sequence if it made sense 👍

Thanks for the response.  I don't think I was aware of your Scratch curriculum until you mentioned it.  We will give that sequence a go and see how it works.  Some of the students have already done some Scratch.  In my case we are volunteering with a lunchtime club, and have the luxury of not having to teach an entire class.  But I do volunteer with a full class at another school too.  So I can try some different things out with 6th graders of varying abilities (and teachers too!)


Encountering Jinja2 SyntaxError after adding another css file

I've been encountering this confusing error; which is Jinja2.exceptions.TemplateSyntaxError: expected token ',', got 'string'.
This only happened after I added another css file to my html script. But previously, it worked fine.
Here are the previous errors i've encountered regarding this issue:
<link rel="icon" href="{{ url_for('static', filename='images/favicon.png') }}">
jinja2.exceptions.TemplateSyntaxError: expected token ',', got 'static'

Home

jinja2.exceptions.TemplateSyntaxError: expected token ',', got 'string'

Environment:

Python version: 3.12.4
Flask version: 3.0.3

Show the full template. Also double-check that you don't have e.g. typographical quotes instead of the standard '. Maybe you didn't properly close some previous Jinja tag?


"npm install -g npm-windows-upgrade" does not work on machines without access to registry.npmjs.org

We have a custom npm repository from where we get all our npm packages.
Access to registry.npmjs.org is blocked by our firewall.
Is it possible to talk you into deleting the shrinkwrap.json file?
We use the npm --registry <nexus server> option to install all packages.
Currently I have a fork of this repository with it removed https://github.com/KrauseStefan/npm-windows-upgrade

Alternatively implementing something like the angular team has done would properly also work. This effectively removes the resolve url from the shrinkwrap, but keeps the version.
See:
https://github.com/angular/angular.js/commit/f684cb09a56d44c0814eda7e1613ecf4d2c5da15#commitcomment-5731712

Hey, fair points - I think we can try to remove it and see if anyone's running into trouble without it. Let me update the package.json with more strict instructions and push a new minor!

Alright, done! Give 2.3.0 a try, it should do the trick for you!

Thank you, I works great in our environment :)


fix: try and decode json, returning None if invalid

Fixes when a response returns a 204 whereby there is no content to be deserialized

Internal issue: https://linear.app/knock/issue/KNO-1157/[python-sdk]-empty-response-causes-deserialization-error

Looks...good I guess? 😂


Custom cast media control notifications

I'm customizing media controls for Android devices. When playing media locally, on an android device, I solved it using MediaSession: https://developers.google.com/web/updates/2017/02/media-session
I even added ActionHandlers for previous and next tracks.
I have a very similar goal when casting. It'd look something like this: https://developers.google.com/cast/docs/design_checklist/sender
I believe I'd have to add a chrome.cast.media.GenericMediaMetadata to chrome.cast.media.MediaInfo.
Create a request, and load it:
var request = new chrome.cast.media.LoadRequest(mediaInfo);
castSession.loadMedia(request).then(...)
Can I achieve this customization via CastProxy? I didn't find documents on how to extend its functionality either. Would this need to be a new feature or could I work around it myself?
Thanks in advance,

I don't know the answer off-hand, but I'm looking into this now.

Awesome, Thanks @joeyparrish!

This should be a good example on how it's implemented: Google CastVideos repo

@vaage I understand how doing that could work, but wouldn't that be a problem when updating Shaka? I was looking forward to a solution that doesn't require me customizing Shaka's code, so I could still update from npm seamlessly. Am I missing something here? Can I add the customization to shaka.cast.CastReceiver.prototype.sendMediaInfoMessage_ elsewhere? In my own code, I mean.
Thanks!

We don't have support for that feature right now, nor do we have an official way in the library to inject it. If you were to add support for it, we are always welcoming to pull requests and would be happy to evaluate the pull request and add it to the project.

@sergioavazquez, I've added the "help wanted" tag to indicate that we would be happy to review a pull request for this feature.  Please read CONTRIBUTING.md for details.  Thanks!

Is anyone interested in seeing this supported?


Integrating with boost::pfr?

The recent pfr update introduces a new feature allowing the retrieval of aggregated object member names.
This enhancement enables the parsing and serialization of aggregate object types without the need for macros or defined functions, directly accessing the members and their names.
(For potential concerns or limitations, please refer to the caveats.)
Your thoughts on this development would be appreciated.

If I unterstand the issue correctly, this is about conversions. From the cursory look, such feature can be a part ofBoost.PFR. PFR doesn't even have to add a physical dependency on JSON (see https://www.boost.org/doc/libs/release/libs/json/doc/html/json/conversion/avoiding_physical_dependency.html).

such feature can be a part ofBoost.PFR

Sounds really strange :) Boost.Json already have Boost.Desribe intergation, why? Doesn't it was better to make such feature a part of Describe?  Of course not, since they both are reflection libraries and they not obliged to be swiss knife for every reflection usecase.
BTW Boost.PFR is a great candidate to be used as fallback for type for which conversion is not found. And shoud we need it as fallback, it's possible to implement only on the Boost.JSON side.

By the same logic, Boost.JSON can't implement conversion logic for every reflection library and composite type in existence. How about this: if someone makes a JSON conversion implementation for PFR, I will integrate it as an example.

If anyone is interested in a JSON lib that has default field reflection, check glaze. They use the same technique as boost PFR.
I think boost::json needs to support reflection without specifying anything information about structs.


allow download of src/dst grey scale bit map visualization

The visuals are great, but sometimes I want to download the png to include in a doc.

So is the ask you want to be able to right click source/destination and then have  a "Open Image in New Tab" link?

Open Image in New Tab is a decent option, but the option to 'save image to file' is the direct path I'm seeking.

@31453 will make it so when you click on the image on the mouse over you can do something with it


Subtitles not working?

Everything works flawless except the "user-own" subtitles, they dont show up in the player...
anyone else having this problem?
torrentsTime.init({
publisher_id:{id},
subtitles: "blalbal.srt",
source: "blabla.torrent",
title: "blabla",
(...)

Having the same problem. I am trying to load a zip subtitle (supposed to be supported) from a remote host but no subtitle options are given when running the video.
@Atirs , did you manage to resolve this issue?

@paishin nope..
I've tried with both zip and just srt file, still not working..

I have the same problem, anyone got a solution?


Delay reporting test finish

For some reason on macOS vscode kill extensionHost nodeJS instance before main process able to process output from test. This PR add delay to let main vscode process handle test output. Also it make sure that we generate test code coverage report before report that test are finished.
Also it return run test on latest vscode version.
Fix: #221

Codecov Report

Merging #243 into master will not change coverage by %.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #243   +/-   ##
=======================================
  Coverage   71.06%   71.06%
=======================================
  Files          37       37
  Lines        2364     2364
  Branches      398      398
=======================================
  Hits         1680     1680
  Misses        684      684

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b5e2593...f8c1779. Read the comment docs.


Distance - Search results return no results when submitting tracked distance to someone

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: 9.0.46-4
Reproducible in staging?: Y
Reproducible in production?: Y
Email or phone of affected tester (no customers<EMAIL_ADDRESS>Issue reported by: Applause Internal Team
Action Performed:

Navigate to staging.new.expensify.com
Go to self DM and submit a distance expense
Click on submit it to someone
Search for any users' email

Expected Result:
Users show up in the results
Actual Result:
No users show up and no results found is shown
Workaround:
Unknown
Platforms:

[x] Android: Native
[x] Android: mWeb Chrome
[ ] iOS: Native
[ ] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[ ] MacOS: Desktop

Screenshots/Videos
https://github.com/user-attachments/assets/589f2b74-2327-4007-96fd-c476054eb371

View all open jobs on GitHub

@bfitzexpensify  FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

Proposal
Please re-state the problem that we are trying to solve in this issue.
The submit to someone result is empty.
What is the root cause of that problem?
When we select submit to someone, it should show a user list. However, if the account doesn't have a distance P2P beta, then no user will be shown.
https://github.com/Expensify/App/blob/5d25b40eab1416d2d67624a376099853a2b6af86/src/pages/iou/request/MoneyRequestParticipantsSelector.tsx#L130
https://github.com/Expensify/App/blob/5d25b40eab1416d2d67624a376099853a2b6af86/src/libs/OptionsListUtils.ts#L1983-L1986
What changes do you think we should make in order to solve the problem?

Hide the submit to someone button if the track is a distance and user/account doesn't have the distance P2P beta.
https://github.com/Expensify/App/blob/5d25b40eab1416d2d67624a376099853a2b6af86/src/pages/home/report/ReportActionItem.tsx#L418-L455
const {canUseP2PDistanceRequests} = usePermissions();
const [isActionableTrackDistanceRequest] = useOnyx(
    `${ONYXKEYS.COLLECTION.TRANSACTION}${ReportActionsUtils.isActionableTrackExpense(action) ? ReportActionsUtils.getOriginalMessage(action)?.transactionID : -1}`,
    {selector: (transaction) => isDistanceRequest(transaction)},
)
...

if (ReportActionsUtils.isActionableTrackExpense(action)) {
    const transactionID = ReportActionsUtils.getOriginalMessage(action)?.transactionID;
    const actionableButtons = [
        {
            text: 'actionableMentionTrackExpense.categorize', ...,
        }, ...
    ];

    if (canUseP2PDistanceRequests || !isActionableTrackDistanceRequest) {
        actionableButtons.unshift({
            text: 'actionableMentionTrackExpense.submit',
            key: `${action.reportActionID}-actionableMentionTrackExpense-submit`,
            onPress: () => {
                ReportUtils.createDraftTransactionAndNavigateToParticipantSelector(transactionID ?? '0', reportID, CONST.IOU.ACTION.SUBMIT, action.reportActionID);
            },
            isMediumSized: true,
        });
    }

    return actionableButtons;
}

This is already fixed in https://github.com/Expensify/App/pull/50331.