[Feature Request]: Add "David Viscott" quote.

Is there an existing issue for this?

[X] I have searched the existing issues

Feature Description
I will add david viscott quote on love.
Record

[X] I agree to follow this project's Code of Conduct
[X] I want to work on this issue
[X] I'm willing to provide further clarification or assistance if needed.

@JayShukla8 Please assign me this issue under hacktoberfest.

see #178


fix tiny typo in README

Hi, thank you for your effort. This typo was reported earlier https://github.com/TheR1D/shell_gpt/pull/115 and merged today.


Update readme for AppDelegate.swift

My react native app has AppDelegate in Swift.
Here are changes required to make it launch with Lottie Animation

Lgtm!


Added Bilinar_Search.java in search

Have you read the Contributing Guidelines on Pull Requests?
Yes
Description
Bilinear Search is a searching technique which works like linear search except it searches from both the direction.
Checklist

[x] I've read the contribution guidelines.
[x] I've checked the issue list before deciding what to submit.
[x] I've edited the README.md and link to my code.

Related Issues or Pull Requests
#1270

@atarax665 Please review my PR on Bilinear Search

LGTM!


Implemented bug fix for updating assets with invalid/empty fields.

Description
Implemented validity checks before updating an item.  If all fields are valid and contain information, then the user can update the asset.
Closes #63
Type of Change

[X] Bug fix
[ ] New/Update feature
[ ] New/Update Documentation

Additional Information

Approved working as per description


Run chmod on .sh files under devtools directory only

Resolves backlog/issues/430
Signed-off-by<EMAIL_ADDRESS><EMAIL_ADDRESS>

Test with jck-8 extended.jck set (which contains all devtools tests) on Linux : Grinder/12851
(Note: the original reason for adding the chmod step was related to a failure under devtools).

All devtools related tests pass when run with this PR. Details here: in internal Grinder/12851

All devtools related tests pass when run with this PR. Details here: in internal Grinder/12851

Test on z/OS with JDK 11 where no devtools folders exist so no chmod should occur:
Internal Grinder/12869

Test on z/OS with JDK 11 where no devtools folders exist so no chmod should occur:
Internal Grinder/12869

Git does track the executable bit, so we would prefer to store the executable bit directly in the repo.

Git does track the executable bit, so we would prefer to store the executable bit directly in the repo.

Hi @llxia ,
Following your comment, I updated the execution bits in the devtool scripts in the JCK 8 repo in my branch (basically did chmod 777 on all the related *.sh files under devtools) and ran the devtools tests, but there are failures in the test for which the original issue raised : jck-devtools-java2schema-CustomizedMapping_0:
Please see this internal Grinder: 12879.
So, it appears that updating the execution bit in the files in the git repo doesn't work.
The failures of course go away if chmod command is run explicitly after download of the JCK materials, as evident in the previous build I had run with the chmod command still in the PR:
Please see this internal Grinder Grinder/12851 (result for jck-devtools-java2schema-CustomizedMapping test).
So, as I had stated in https://github.ibm.com/runtimes/backlog/issues/430#issuecomment-26531115 , we can have the chmod command in the script since with this PR we will only be chmod'ing a specific set of .sh files in JCK repo - meaning time will not be a concern.

Hi @llxia ,
Following your comment, I updated the execution bits in the devtool scripts in the JCK 8 repo in my branch (basically did chmod 777 on all the related *.sh files under devtools) and ran the devtools tests, but there are failures in the test for which the original issue raised : jck-devtools-java2schema-CustomizedMapping_0:
Please see this internal Grinder: 12879.
So, it appears that updating the execution bit in the files in the git repo doesn't work.
The failures of course go away if chmod command is run explicitly after download of the JCK materials, as evident in the previous build I had run with the chmod command still in the PR:
Please see this internal Grinder Grinder/12851 (result for jck-devtools-java2schema-CustomizedMapping test).
So, as I had stated in https://github.ibm.com/runtimes/backlog/issues/430#issuecomment-26531115 , we can have the chmod command in the script since with this PR we will only be chmod'ing a specific set of .sh files in JCK repo - meaning time will not be a concern.

@llxia - I've updated this PR and simply omitted the chmod step from this script. Please see testing results reported in backlog/issues/430.
Please note, this PR should be delivered together with the PR in the test repo where permission bits have been set.

@llxia - I've updated this PR and simply omitted the chmod step from this script. Please see testing results reported in backlog/issues/430.
Please note, this PR should be delivered together with the PR in the test repo where permission bits have been set.


influx data or influx db executables packages or files

can we have influx data or influx db executables packages or files like prometheus and atlas:
e.g.
https://github.com/prometheus/prometheus/releases/download/v2.5.0/prometheus-2.5.0.linux-amd64.tar.gz
https://github.com/Netflix/atlas/releases/download/v1.5.3/atlas-1.5.3-standalone.jar

@ashuptdr all executable packages can be downloaded using commands/links available on the InfluxData Downloads page.


not working authentication with google to host! How config redis to .env?

Help me!

just try the local_setup branch if you're having trouble

i use ioredis BTW

i use ioredis BTW

How use ioredis? Where can I install? How get key API user and pass?

today it returns error 500, please double check ,it not works anymore

today it returns error 500, please double check ,it not works anymore

thanks. its working now


How to use Redis Store with Moleculer js?

How can i implement sessions in moleculer js using express-session and redis store for saving the session data?
Does express-session runs without express server in moleculer js?

Yes, you can use many express middleware in the moleculer-web API gateway, as well.

#155 https://github.com/moleculerjs/moleculer-web/issues/155
I tried the middlewares but redis store is not working.
At first i thought like middleware is not called then @AndreMaz told me that "express server is not needed you can directly call middlewares and use express-session with the help of middlewares no need to create and start the express server.". But when i'm trying to connect to redis it is not working and the cookie is not sent and session data is not stored but when the same is tried with express framework alone it is working.

Please create a repro repo with middlewares what you need and we will check it.

I've created a repo please check.
https://github.com/Moulali1995/moleculerjs-redis-jwt-express-session.git
env variables in .env.tmpconfig

login API: JWT token is generated http://localhost:3000/auth/login
payload : { "username": "user1", "password": "admin" }
authentication API: using the above JWT token and sending it in cookie headers http://localhost:3000/api/user
unable to see any sort of session id generated in the redis cli monitor.why? In response there is no express session cookie passed generated by the middleware express-session when the same is tried in express framework it works .why?

It's not correct:
ctx.meta.$responseHeaders = { Cookie: `session_token=${data.key}` };

Please check how to set a cookie or use a lib to generate cookie string.

Thanks @icebob it worked by removing the express-session code and directly using set and get methods of redis-store and by using set-cookie method.


Extract embedding from the .wav

Hi, @jymsuper!
I want to extract embedding from the .wav sound. Tell me please, how can I do this?

Hi.
I'm sorry but I didn't upload the code for feature extraction.
I will upload the code soon.
As I explained in the README, I used the library below.
https://github.com/jameslyons/python_speech_features

Okey, it would be very usefull. Thank you for your development!


Using --strings flag?

I tried the following as per the README (great job btw :-) to pass any flag to eye-js:
https://notation3.org/eyejs/test-strings.html
But the "--strings" flag does not seem to work. As a sanity check I also tried with "--pass-only-new" which outputs the expected inferences. Also checked the N3 code with the command-line eye (using strings flag) and it works there.

I've just tried running the following with the eye-js cli
$ npx eyereasoner --quiet --strings ./data.n3

and there is no output so there does seem to be a bug.
@josd is the log:outputString using stdout differently from other results?

It is in exactly the same way that the output via --strings is written.
When I test locally, I also don't see any output from
<script src="https://code.jquery.com/jquery-3.6.3.min.js"></script>
<script src="https://eyereasoner.github.io/eye-js/3/latest/index.js"></script>

<script>
    async function eyeWithFlags(files, flags) {
        let output = "";
        const Module = await eyereasoner.SwiplEye({ print: (str) => { output += str + "\n" }, arguments: ['-q'] });

        for (let file of files)
            Module.FS.writeFile(file.path, file.data);

        eyereasoner.queryOnce(Module, 'main', flags);
        return output;
    }
</script>

<script type="module">

    const data = `
@prefix rdfs: <http://www.w3.org/2000/01/rdf-schema#>.
@prefix log: <http://www.w3.org/2000/10/swap/log#> .
@prefix : <http://example.org/>.

:Let :output "abc" .

{ :Let :output ?out } => { 1 log:outputString ?out } .
`

    let out = await eyeWithFlags([
            { path: 'data.n3', data: data }
        ],
        ['--nope', '--pass-only-new', '--n3', './data.n3'] // works
        // ['--strings', '--n3', './data.n3'] // does not work
    );
    console.log(out);

</script>

This is fixed as of v3.1.2 :tada: - lets leave this issue open until we add some tests to avoid regressions.

:tada: This issue has been resolved in version 4.0.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release
v4.0.0

Your semantic-release bot :package::rocket:


docs: give unity

add semicolon for unity

more pretty.
it's better than nothing.
At least, that's my opinion. :)

Yup! Thanks for the contribution 🎉


Kumarabd/feature/helm charts

Description
This PR fixes #2837
@leecalcote Ive moved the charts back inside to have it as a dependency chart (This is recommended if the other charts depend on a parent chart to exist).
Signed commits

[x] Yes, I signed my commits.

We're in need of a Traefik Mesh chart. We can leave Octarine aside, but should probably include Citrix, too.

We'll want to include a chart for Meshery Operator, too.

Need to add instructions for the user to be able to switch channels between stable and edge.

meshery.io repo needs cleaned up with charts being removed. Verify that all looks good on Artifact Hub.

I think we are all set here save for the final item of incorporating the (ref/tag) release tag.

@leecalcote All of the items are covered. Good to release.


Change pom for uploading 1.5.0 plugin to nexus.

Change for uploading 1.5.0 plugin to nexus.

LGTM

LGTM


Add some ignoreCase methods, rename stringCI to ignoreCase

follow up to #46
What do you think @stephenjudkins ? I want to publish a new version, but the name just wasn't sitting well with me.
Can you review this and the other new methods I added?
There is one ambiguity: string can be converted to Iterable[Char] in scala, so I added ignoreCaseChar and ignoreCaseCharIn but to save space for the common case, I used ignoreCase to accept a string. A clearer, but more verbose approach would be to do ignoreCaseString, but I feel that's a bit long. That said, ignoring case isn't that common, so maybe that's okay. I don't know.

👍 i think this all looks great. I picked stringCI simply because it was the name use in atto but I like these a bit better. I wouldn't quibble too much about ignoreCaseString vs ignoreCase, I think having string be the "default" thing is probably what 99% of parsers will be doing


⚠ T:Riza Docs has degraded performance

In f51aeb1, T:Riza Docs (https://docs.triza.dev) experienced degraded performance:

HTTP code: 200
Response time: 7366 ms

Resolved: T:Riza Docs performance has improved in a6a952d.


[Proposal] Improve OkHttp Documentation

This issue serves as a first step in proposing changes to the OkHttp Documentation found under https://square.github.io/okhttp
The reasons
While the docs do look nice do they miss out on a lot of different features that are provided by the 'Material for MkDocs' Theme (Which I call just 'Material' throughout this issue for simplicity reasons) and PyMdown Extensions (Also known as Pymdownx).
Changes
I propose the following main changes to the documentation.
Dark theme
Material offers a simple setting for using dark theme called slate:
theme:
  palette:
    scheme: slate

And let's be honest: This bright theme is not good for the eyes to look at and a dark theme would be a lot better to use.
Note, that the dark theme was addes in a later 5.x version of Material, so upgrading should be recommended.
Using tabs
Material offers the usage of tabs.
This allows you to keep pages organized in tabs, which are visible at the top of the page.
Adding it only requires this in the mkdocs.yml
theme:
  features:
  - navigation.tabs

As mentioned allows this to group pages together under a single name, which makes it look better in comparison to just having all pages listed on the side.
As an example can you group and add the changelog_3x.md, changelog_2x.md, changelog_1x.md and changelog.md under the Change Log section like this:
nav:
# ...
- 'Change Logs': # I suggest renaming this to Change Logs
  - 'Latest': changelog.md
  - 'Version 3.x': changelog_3x.md
  - 'Version 2.x': changelog_2x.md
  - 'Version 1.x': changelog_1x.md

General reordering of pages
Next proposal is to reorder and group pages together into their own separate sections.
You already have 4.x as a separate group, which considering all other pages being separated seems somewhat odd and inconsistent.
I propose the following Folder structure to use:
docs/
  │
  ├─ 4.x/
  │  ├─ mockwebserver/
  │  │  └─ okhttp3.mockwebserver/
  │  │     └─ index.md
  │  ├─ okhttp/
  │  │  └─ okhttp3/
  │  │     └─ index.md
  │  ├─ okhttp-brotli/
  │  │  └─ okhttp3.brotli/
  │  │     └─ index.md
  │  ├─ okhttp-dnsoverhttps/
  │  │  └─ okhttp3.dnsoverhttps/
  │  │     └─ index.md
  │  ├─ okhttp-logging-interceptor/
  │  │  └─ okhttp3.logging/
  │  │     └─ index.md
  │  ├─ okhttp-sse/
  │  │  └─ okhttp3.sse/
  │  │     └─ index.md
  │  ├─ okhttp-tls/
  │  │  └─ okhttp3.tls/
  │  │     └─ index.md
  │  ├─ okhttp-urlconnection/
  │  │  └─ okhttp3/
  │  │     └─ index.md
  │  └─ upgrading_to_okhttp_4.md
  ├─ changelogs/
  │  ├─ changelog.md
  │  ├─ changelog_3x.md
  │  ├─ changelog_2x.md
  │  ├─ changelog_1.md
  │  └─ tls_configuration_history.md
  ├─ contribute/
  │  ├─ code_of_conduct.md
  │  └─ contributing.md
  ├─ features/
  │  ├─ caching.md
  │  ├─ calls.md
  │  ├─ concurrency.md
  │  ├─ connections.md
  │  ├─ debug_logging.md
  │  ├─ events.md
  │  ├─ https.md
  │  ├─ inteceptors.md
  │  └─ r8_proguard.md
  ├─ security/
  │  ├─ security.md
  │  └─ security_providers.md
  ├─ index.md
  ├─ recipes.md
  ├─ releasing.md
  └─ works_with_okhttp.md

The benefits of such a structure would be a more organized look and feel.
Note that this folder structure would also be mostly mirrored in the navigation as follows:
nav:
nav:
  - 'Overview':
    - 'Introduction': index.md
    - 'Stack Overflow ⏏': https://stackoverflow.com/questions/tagged/okhttp?sort=active
  - 'Features':
    - 'Caching': features/caching.md
    - 'Calls': features/calls.md
    - 'Concurrency': features/concurrency.md
    - 'Connections': features/connections.md
    - 'Debug Logging': features/debug_logging.md
    - 'Events': features/events.md
    - 'HTTPS': features/https.md
    - 'Interceptors': features/interceptors.md
    - 'R8 / ProGuard': features/r8_proguard.md
  - 'Recipes': recipes.md
  - 'Security':
    - 'Security Policy': security/security.md
    - 'Security Providers': security/security_providers.md
  - 'Works with OkHttp': works_with_okhttp.md
  - '4.x API':
    - 'Upgrading to OkHttp 4': 4.x/upgrading_to_okhttp_4.md
    - 'okhttp': 4.x/okhttp/okhttp3/index.md
    - 'brotli': 4.x/okhttp-brotli/okhttp3.brotli/index.md
    - 'dnsoverhttps': 4.x/okhttp-dnsoverhttps/okhttp3.dnsoverhttps/index.md
    - 'logging-interceptor': 4.x/okhttp-logging-interceptor/okhttp3.logging/index.md
    - 'sse': 4.x/okhttp-sse/okhttp3.sse/index.md
    - 'tls': 4.x/okhttp-tls/okhttp3.tls/index.md
    - 'urlconnection': 4.x/okhttp-urlconnection/okhttp3/index.md
    - 'mockwebserver': 4.x/mockwebserver/okhttp3.mockwebserver/index.md
  - '3.12.x API':
    - 'okhttp ⏏': https://square.github.io/okhttp/3.x/okhttp/
    - 'dnsoverhttps ⏏': https://square.github.io/okhttp/3.x/okhttp-dnsoverhttps/
    - 'logging-interceptor ⏏': https://square.github.io/okhttp/3.x/logging-interceptor/
    - 'sse ⏏': https://square.github.io/okhttp/3.x/okhttp-sse/
    - 'tls ⏏': https://square.github.io/okhttp/3.x/okhttp-tls/
    - 'urlconnection ⏏': https://square.github.io/okhttp/3.x/okhttp-urlconnection/
    - 'mockwebserver ⏏': https://square.github.io/okhttp/3.x/mockwebserver/
  - 'Change Logs':
    - 'Latest': changelogs/changelog.md
    - 'Version 3.x': changelogs/changelog_3x.md
    - 'Version 2.x': changelogs/changelog_2x.md
    - 'Version 1.x': changelogs/changelog_1x.md
    - 'TLS History': changelogs/tls_configuration_history.md
  - 'Contributing':
    - 'Contribute': contribute/contributing.md
    - 'Code of Conduct': contribute/code_of_conduct.md

Usage of other pymdownx extensions
I believe using the Emojis extension of pymdownx together with the MaterialX emoji option, which is part of Material and enables the usage of SVG icons from Fontawesome, Material Design and Octicons, would be beneficial for the documentation.
Right now is the main benefit/feature I imagined, which is displaying something like Fontawesome's external-link-alt icon in the navigation tree on the left, not supported.
I opened an issue on Material proposing such a change, as it would look better to use such an icon to indicate external pages, rather than using ⏏.
Unfortunately is this not doable for extensions and themes.
But perhaps there would also be other places where the usage of either emojis or icons could be beneficial to use.
Live Preview
All the changes I discussed above can be found on a live-preview I made over here: https://andre601.ch/okhttp
Notes
I used the following things for this:

MkDocs 1.1
Material for MkDocs 6.2.8
pymdown-extensions 7.x

I simply used pip install -U mkdocs-material to download and use Material for MkDocs and all nessesary dependencies.
Also note, that due to the structure of the OkHttp Docs, some pages use placeholder MD files as the navigation would otherwise break.
These placeholder files wouldn't be included in a possible PR. If a PR is requested, will one be made with the above changes. Any alterations or additions requested would also be implemented here.

Wow, that live preview is amazing. Lets do it.


Vscode exception in http requests on Android

Is there an existing issue for this?

[X] I have searched the existing issues
[X] I have read the guide to filing a bug

Steps to reproduce

Create a project to make an http request
Run with debug mode active in vscode (F5)

Expected results
Code successfully executed
Actual results

It causes the error in the debug, but the request is completed and I can retrieve the body
Code sample
I'm not creating a code example, because any http request causes an exception in Android.
I've already set the internet permission in AndroidManifest.xml
Screenshots or Video
No response
Logs
This exception does not generate a log in the terminal, it is only reported in the vscode debug tool
Flutter Doctor output
[√] Flutter (Channel stable, 3.13.3, on Microsoft Windows [versÆo 10.0.19044.3086], locale pt-BR)
• Flutter version 3.13.3 on channel stable at C:\src\flutter
• Upstream repository https://github.com/flutter/flutter.git
• Framework revision<PHONE_NUMBER> (7 days ago), 2023-09-06 14:32:31 -0700
• Engine revision b8d35810e9
• Dart version 3.1.1
• DevTools version 2.25.0
[√] Windows Version (Installed version of Windows is version 10 or higher)
[√] Android toolchain - develop for Android devices (Android SDK version 32.1.0-rc1)
• Android SDK at C:\Users\vitor.melo\AppData\Local\Android\sdk
• Platform android-33, build-tools 32.1.0-rc1
• Java binary at: C:\Program Files\Android\Android Studio\jre\bin\java
• Java version OpenJDK Runtime Environment (build 11.0.11+9-b60-7590822)
• All Android licenses accepted.
[√] Chrome - develop for the web
• Chrome at C:\Program Files\Google\Chrome\Application\chrome.exe
[√] Android Studio (version 2021.1)
• Android Studio at C:\Program Files\Android\Android Studio
• Flutter plugin can be installed from:
https://plugins.jetbrains.com/plugin/9212-flutter
• Dart plugin can be installed from:
https://plugins.jetbrains.com/plugin/6351-dart
• Java version OpenJDK Runtime Environment (build 11.0.11+9-b60-7590822)
[√] VS Code (version 1.82.0)
• VS Code at C:\Users\vitor.melo\AppData\Local\Programs\Microsoft VS Code
• Flutter extension version 3.72.0
[√] Connected device (3 available)
• 22041219NY (mobile) • fyx4z9eeqs65fmtw • android-arm64  • Android 13 (API 33)
• Chrome (web)        • chrome           • web-javascript • Google Chrome 116.0.5845.180
• Edge (web)          • edge             • web-javascript • Microsoft Edge 116.0.1938.76
! Device emulator-5554 is offline.
[√] Network resources
• All expected network resources are available.
• No issues found!

Hi @vitoramaral10. Thanks for filing this. This seems similar to https://github.com/flutter/flutter/issues/126650 which has been closed as fixed and I think the fix is on the master channel. Also kindly check this for more insights into a workaround https://github.com/flutter/flutter/issues/126650#issuecomment-1576503525.
It was also being tracked here: https://github.com/dart-lang/sdk/issues/53334
I'd be closing this as it seems a fix is currently on its way, If you disagree, kindly comment and I'll reopen this.
Thank you.

Hi @vitoramaral10. I see the bug was later reopened and tracked in the Dartlang repo. Are you able to check this fix on the latest master channel?

This bug is fixed in 3.13.4 version, thanks!

Hello, the bug has returned in version 3.13.6, please be careful with releases so as not to keep bringing back bugs that have already been fixed.


Fixed typo in release workflow

There is a typo in release workflow. This PR fixes that.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 30.87%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
4072

Relevant Lines:
13191

💛  - Coveralls


Any way to force to Bedrock to save all visible chunks?

Your app works well, but it only renders chunks about 10 to 16 chunks away.  I read somewhere it's because they're not actually saved to disk beyond a short distance to help performance, except for chunks with certain pre-generated structures.  Is there any way to force bedrock to save all visible chunks, or at least the first layer exposed to the sky?

In my Bedrock client (Windows 10) I see 16 as the max video render distance.  Presumably this is measured in chunks.  This would match up with the 10 to 16 chunk distance of what you are seeing rendered by PapyrusCS.  So I think your question is based on a false premise.  In other words, Bedrock most likely DOES save all visible chunks.

the only way really is to set the tick-distance parameter in the config file to a higher value, but that would hit the performance of the server a bit.

I'm not sure if anybody else is struggling with this raised issue, but I'm not sure I understand at all, what is being claimed is broken.
I have a world (my main one), where my children play near spawn and I play some  1300 chunks away.  When I get Papyrus to generate my worldmap, I get everything that has been explored.
see attached screenshot, and please note that my cursor is placed above a coordiante of approximately 14,000 x 14,000

In your screenshot, I see you explored to the east in a straight line. That line to the east should be much wider if it actually rendered everything you saw... but it only renders something like 16 blocks away from the player at all times, irregardless of render distance. I just don't know if it's a bug with papyrus or if the game simply doesn't save blocks beyond something like 16 blocks in any direction from the player.
To put this another way, let's say you wanted to have the map render a section of the map, let's say 200x200 and your render distance was 100.  If you stood in the center of this, you could see all of it in-game, but the renderer would only render about 20x20 or whatever low number it actually shows. To get it to render all 200x200 blocks, you would have zig zag over it in small sections, as if you were mowing the grass.

I read something a while ago (sorry, I don't have a link off hand) that suggested chunks only get saved to the file if they differ from what gets generated from the seed. That would make sense as an optimisation to keep the size of the save file down. I don't know if that might explain what's being seen here? Even though you can see a chunk, if nothing's happened in it, the game doesn't need to save it because it knows it can just regenerate it exactly the same next time. (I don't pretend to know the details of how this is implemented or what might count as a 'change' to trigger it to save it or not, but I can see how the concept could make sense). As I say, I can't remember where I read it, so I can't vouch for it's accuracy...

I guess that all depends on what 'differs from generation' means.
My son loves to explore and just run in random directions and rarely moves blocks when he does this. As a result, I have huge swathes of paths that are hundreds upon hundreds of chunks long that are saved to my world.
Again. I'm not sure what the specifics are.
Do you have a world you could save to that could be looked at?

I'm going to explore the idea that @AaronHofer put forward when I get home using a variety of render distances.
I have funny suspicion this is a combination of render distance and ticking radius. But ultimately is a Minecraft thing and not a papyrus thing.

Hi there,
Did an experiment with two worlds on windows 10.  Both of them new worlds, using the same seed.
The only difference between these two worlds is the "simulation distance" (also referred to as the ticking radius).
In the left-hand one, the simulation distance was set to 4.  In the middle-hand and right-hand ones, the simulation distance was set to 12.  For the 2 12-chunk maps, the render distance was set to 32 and 44 respectively.
Once each world was loaded, I slowly turned around in game until the view distance had rendered to the full extent in all directions, then did the same looking down and looking up.

All of the Papyrus render options were the same (as close to default as possible
4-chunk sim:          PapyrusCs.exe -w "...\minecraftWorlds\yNoRXxJzAAA=" -o .\map1\
12-chunk sim # 1:     PapyrusCs.exe -w "...\minecraftWorlds\adsRX97oAgA=" -o .\map2\
12-chunk sim # 2:     PapyrusCs.exe -w "...\minecraftWorlds\ReERXxRmAAA=" -o .\map3\

the 4-chunk sim has an on-disk size of 674KB.  the 12-chunk sims have an on-disk size of 1.92MB and 2.25MB respectively
I can't fully explain the 'scatter in the outskirts', but I assume, given the scatter in the two left images (where the render distance is the same) appears to be identical in (outside of the rendered radius of 4 and 12 chunks respecitively), this has to do with minecraft rendering stuff such as falling blocks, water/lava flows and other similar things outside the simulation distance.  And thus, as @PaulWalkerUK has noted, these chunks' 'generated state' differs from the current state, and thus is candidated as needing to be saved.
This seems to lend additional credence to why the 44-chunk render distance (right hand image) has more chunks presented in the "scatter" in the 3rd Papyrus-generated map.
All in all, my conclusion is that there is no way to get Papyrus to fix this (and would recommend this ticket be closed), because PapyrusCs can simply not render data that is not physically present in the save files.
As far as I know, there is no way to get the simulation distance to go above 12 (due to the sheer overhead of managing all of the ticking events and mobs in those chunks).  My bedrock server, which admittedly is not the most powerful machine, has trouble handling 5 users if the simulation distance is above 10.  I tend to keep it down to around 8 or so (mostly because of the machines I have in my my world in near my personal respawn location.
If there is a desire to have the "full render distance saved to disk", that would need to be taken up with Microsoft/Mojang themselves.

For reference, I think it was this comment I was thinking of. It's from 2017 but it sounds like the person has first hand knowledge of the code base

Great work karpana. I think the "scatter" are chunks with dungeons in them or some other pre-generated object.
If it really is simply because bedrock isn't saving the chunks then I don't see any possible solution without a completely different approach, like reading memory in real-time. I wish the bedrock devs would make it so it at least partially saves all the chunks, specifically the first block that isn't air.

I'm not sure if there's a status to close this as "out of scope", but I think what's neede here, if it's going to happen at all is for 2 things to occur
either
a) Minecraft actually saves down all chunks that were rendered (unlikely, and definitely out of scope for this project)
or
b) Somebody would need to incorporate the procedural generation protocols into Papyrus to "fill in" the missing chunks so that they could be rendered (which I think is also out of scope for this project)


KAFKA-9769: Finish operations for leaderEpoch-updated partitions up to point ZK Exception

KAFKA-9769: Finish operations for leaderEpoch-updated partitions up to point ZK Exception occurs.
https://issues.apache.org/jira/browse/KAFKA-9769
For example, in such case, we will have the following mechanism :
1 - P1 and P2 succeeds. leaderEpoch for them are incremented because no ZkException occurs
2 - while making follower for P3, ZkException occurs and the leaderEpoch is not updated and thus thepartitionsToMakeFollower += partition isn’t executed. We catch this ZkException in line 1498 and log it as an error. No Exception is thrown.
3 - After catching the exception, makeFollower for P4 is then not executed.
4 - so the partitionsToMakeFollower only contains P1, P2. And fetchers are added to these partitionsToMakeFollower
Signed-off-by: Andrew Choi<EMAIL_ADDRESS>Committer Checklist (excluded from commit message)

[ ] Verify design and implementation
[ ] Verify test coverage and CI build status
[ ] Verify documentation (including upgrade notes)

@mjsax Hello Matthias! I would appreciate your review. Thanks in advance!

I am not really familiar with this part of the code. Maybe @hachikuji or @cmccabe can help?

Thanks for referring Matthias. Would appreciate your review @hachikuji @cmccabe

@mjsax Hi Matthias, would you happen to know if there were any other reviewers available? I don't mind waiting, but was curious what the ETA usually appears to be.

Feel to reach out to the dev mailing list and call for review.

@andrewchoi5 Just want to make sure I understand the problem. The scenario is that we lose the zk session while handling a LeaderAndIsr request. Current LeaderAndIsr handling works like this:

Check epoch of each partition. If it is less than or equal to current epoch, ignore the update.
Update the epoch for each partition.
Make followers and leaders, which involves loading topic configs from zk.

So the problem occurs when we hit an error loading the topic configs in step 3). This potentially causes us to miss the needed state changes from that request and also prevents us from being able to retry them because the epoch has already been updated. Is that right?
I guess the fix here is only a partial fix. We would still be left with the one failed partition, right?
Off the top of my head, I am wondering whether we should be retrying the request at a lower level. For example, maybe getEntityConfigs could catch the ZooKeeperClientExpiredException and retry. I assume there is a good reason we do not catch this exception in retryRequestUntilConnected already. Perhaps it is unsafe to assume that the requests are still valid after a session expiration. However, just for reading configurations, I do not see a problem retrying after a session expiration.
cc @junrao

@andrewchoi5 : Thanks for finding this issue. We fixed https://issues.apache.org/jira/browse/KAFKA-9932 recently. So, the fetchLogConfig from ZK method is called rarely during makeFollowers() now. If we do hit the ZK exception, there are a few options: (1) As Jason mentioned, we could keep retrying from ZK until successful. This probably needs to be done in a separate thread to avoid blocking the request handler thread. So, it can be a bit involved. (2) Don't update the leader epoch (we can choose to update the leader epoch after the local log is obtained successfully) and log an error. Since this issue should be rare now, maybe we can do (2) for now?

Hi @junrao. Thank you for your review -- I have further synced up with @jjkoshy on this PR.
The partition's new leader epoch update is actually happening after the point at which ZooKeeper Exception is thrown. Therefore, when the createLogs throws ZooKeeper Exception, the new leader epoch does not actually get updated.
In the catch case for ZooKeeperClientException, I have populated the responseMap with the topic partition and the Errors.NETWORK_EXCEPTION. If you suggest any other Error to be populated in this responseMap, please let me know and I will change it accordingly.

In the catch case for ZooKeeperClientException, I have populated the responseMap with the topic partition and the Errors.NETWORK_EXCEPTION. If you suggest any other Error to be populated in this responseMap, please let me know and I will change it accordingly.

I haven't looked at this code in a while so I may not have enough context at this point, but I don't think we should use the network exception error code - i.e., this isn't a network issue between the coordinator and broker but between the broker and zk. Also, there doesn't seem to be any active retry attempt from the controller to resend the request in this scenario.

In the catch case for ZooKeeperClientException, I have populated the responseMap with the topic partition and the Errors.NETWORK_EXCEPTION. If you suggest any other Error to be populated in this responseMap, please let me know and I will change it accordingly.

I haven't looked at this code in a while so I may not have enough context at this point, but I don't think we should use the network exception error code - i.e., this isn't a network issue between the coordinator and broker but between the broker and zk. Also, there doesn't seem to be any active retry attempt from the controller to resend the request in this scenario.

Correct -- I wasn't able to find the best, close enough Errors exception to populate, especially since there was none related to ZooKeeper in that class.

@andrewchoi5 : Since the controller only checks KAFKA_STORAGE_ERROR in LeaderAndIsrResponse now, perhaps we can just log an error without sending an error code back for now.

Thanks, @junrao .
Removed the population of responseMap with the ERROR code.

Hello @junrao @hachikuji  -- I have made some updates to address the comments. Thanks!

Thanks for the review @junrao -- let me know if there's anything else for revision.

Closed by accident.

@junrao -- let me know if anything else needs your attention. Thanks!

ok to test


Mini Player slowly expanding at a constant rate

OS: Windows 10 (Creators Update)
Issue Descriptions: Mini player is constantly attempting to grow in size for no reason. Zoom levels are also distorted during and after this.
Steps to Reproduce: Open application, click mini player

Duplicate #2269


Remove assets from cache, fix issue when switching from mlt to mf

Note: This would increase loading time


Filter out unneeded series from studies

Definition of Done / Acceptance Criteria
As a researcherer I'd like to only get series that I'm interested in, no receiving all series. Especially localising series which aren't useful to me.
Testing
No response
Documentation
No response
Dependencies
No response
Details and Comments
May have to be filtering on receipt, probably a regex because inconsistent naming and numbering?

Summary of chat with @HChughtai
A study is a whole imaging "session" (but that word means something else so don't use it).
A series is a set of instances (images) within a study taken with the same physics parameters, and with a certain purpose (eg. to search for areas to scan in more detail)
Every MRI study will have a T1 weighted scan, you would typically want this included (it's a bit like a reference or baseline for other types of scan).
But we will want to filter out some types of series that are unlikely to be useful for our research users, such as "positioning" series (synonyms: "localizer", "scout")
The DICOM tag "Series Description" is likely the most useful one here. Unfortunately, it's based - at least in part - on manually entered data, so will vary from machine to machine, operator to operator, and could have typos etc.
So the person specifying the research project will not be able to give a simple list of series description strings to include or exclude.
We assume the purpose of this filter is to reduce disk space and network transfers and reduce the amount of unwanted data that the researchers have to deal with, but that there are no anonymisation consequences here.
Therefore, it is better to accidentally include rather than to accidentally exclude something, and therefore, at least as a first pass, we should focus on what things we can safely exclude, rather than drawing up a list of safe strings for inclusion or trying to classify every single series description.
A starting point might be to exclude anything containing a string suggesting it's a positioning series (see synonyms above, and consider alternate spellings). It's surely unlikely someone would include that string in a series description if it were not such a thing, given the technical meaning.
However, it seems clear that we need to implement a framework for including and excluding things via the project config file, rather than eg. hardcoding strings.
You can also query the VNA metadata, and then only request the series you want, to reduce load on the VNA. Maybe not in the first pass though.
We should record somewhere which series got rejected (in DB or logs)
Dicom files: one file per series is the modern standard; older standard (which the hospital likely uses) is one file per instance.
John Stutters wrote a script to generate mock dicom data. There's apparently also a pre-existing library for this.

Thanks for the notes @jeremyestein - looks like we're agreed on the way forward, but to summarise:

this issue will focus on filtering out series that are uneeded for research
Filtering can occur either when pulling from PACS/VNA or after recieved in PIXL (likely the latter in this pass)
We should record what we reject to aid in debugging
We should have an eye on future environments and design an approach that could be customised further in future.

@milanmlft was also looking into modifying the script that John Stutters wrote to generate mock DICOM data, so may be worth having a chat with him too. The library that I mentioned was https://github.com/sjoerdk/dicomgenerator but it's no actively maintained and doesn't seem to allow full configuration of DICOM tag content

See #348 for an updated version of the mock DICOM generator


How to get an IP , the docker is going to assigned to the next container by passing subnet

Hello,
Is there any to get the next ip (of a network) for a container ?
Or how docker chooses IP to be assigned to the container.
Actually i have written a script to generate the valid IP set from the subnet ip range.
However , some time i get an error saying " context deadline exceeded"
Thanks,
Gurushant

IP Address management is handled with IPAM drivers, which are not really under swarmkit's management. We call out to libnetwork to choose the addresses for services and tasks. I don't know what your second question means, but in general "context deadline exceeded" means whatever operation you're trying to complete has taken too long. It's impossible to say why you'd get this error without knowing what the failing script should be doing and how.
In either case, your problem isn't in swarmkit, it's either in the docker engine, the IPAM driver, or libnetwork.


BQ V2 / Airbyte Cloud migration: Google Directory

This PR does the usual set of find-and-replaces (etc) to modify the dbt for the Google Directory sync for compatibility with Airbyte's BQ V2 connector.

@jitoquinto, do you have any idea why the SQLFluff lint check is failing? This is what I see when I run SQLFluff locally (via cta_dbt_helper.sh):


support creation of public IP without directly assigning to network interface

currently creating a public IP (floating IP) requests for network interface id (optional)
So that would force me to create a NIC with an public IP assigned.
I'd rather create the public IP upfront and attach it at a later to an interface as I then have the ability to rebuild a node and keep the same public IP.
Or is there any other proposed way to do that?
seems to be related: https://github.com/stackitcloud/terraform-provider-stackit/pull/582/files

Hi @mhenselin,
Thanks for opening the issue.
I'm not sure I fully understood you question. Are you asking if it's possible to create a public IP without associating it to a network interface right away? You can do that by not setting the network_interface_id field.
Let me know if this doesn't answer your question.

thanks. I already realized that the associate resource was added
closing


Update enigma.Dockerfile

Reference Issues/PRs
Your Dockerfile is already set up to handle various dependencies, especially for CTF and reverse engineering tasks. Here are some optimizations and improvements for this setup:
What does this implement/fix? Explain your changes.
Layer Minimization: Combine RUN instructions where possible to reduce image layers.
Dependency Management: Clean up apt cache after each installation step to keep the image size manageable.
Download Management: Use wget with -q (quiet) for less verbose output.
Consistent Environment Variables: Group common configurations (like ENV PATH) together.

Hi @Reckon-11 . Have you checked that the dockerfile still builds?

Assuming all external resources are available and paths are correct, this Dockerfile should build successfully.

Please test that it still builds

Keeping DEBIAN_FRONTEND=noninteractive helps avoid interactive prompts during apt-get install, which can block the Docker build. Was there a particular reason for this change?


How drag between multiple rows?

Is is possible to make the items draggable vertically and horizontally at the same time? I set horizontal to ‘true’ and turned it into 2 rows. However, I could only drag the items within the same row. Is is possible to drag swap Item 1 with Item 4?

any solution you found?

not supported

some one can implement this?

@haolipang Did you find any solution?


ISTIO Sidecar performance impact Istio: 1.0.6. same observed in 1.2.3

After side car Injected ,  performance dropped to half .  Even the request incoming is not at steady rate. over time it is degrading. istio version : 1.0.6
[ ] Configuration Infrastructure
[ ] Docs
[ ] Installation
[ ] Networking
[X ] Performance and Scalability
[ ] Policies and Telemetry
[ ] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure
Expected behavior : After side car Injected ,  if performance  drops , it should not be more than 10%.  And performance should be steady , with time it should not degrade.*
**Following are steps our testing: **
Without side car :
1. client simulator (vegeta) to send GET/POST request -> application pod using pod service IP
In statistics we can see it is able to reach 8k  tps for 8 hours run . it was stable for 8hours.
2.  Side car attached to the pod.  (we have mTLS disabled)
client simulator (vegeta) to send GET/POST request -> application pod using pod service IP.
In statistics we can see it was reaching upto 4k . BUT problem is that it is degrading over time.
it 8 hours end it was around 500.
istio version : 1.0.6
Environment:
We are using kubernetes cluster.
Deployment pod were given CPU: 4., Memory: 4Gi
Application is using 2Gi Memory.
So side car has 2 Gb memory to use.
Environment where bug was observed openstack

A couple things:

I would recommend reading https://istio.io/blog/2019/performance-best-practices/

Istio 1.0 is end of life now. We have made substantial performance improvements since then so I would encourage you to try out newer versions.

Deployment pod were given CPU: 4., Memory: 4Gi
Application is using 2Gi Memory.
So side car has 2 Gb memory to use.

Kubernetes handles resources by container, not by pod. The sidecar has its own limits and requests assigned to it. I forgot what the defaults are on 1.0 since we have changed them since, but you can check with kubectl get pod -oyaml.
The performance getting worse over time suggests to me some component, likely mixer telemetry, is overloaded perhaps.
Also consider that if you have a low latency application, say 1ms, and you Envoy adds roughly 1ms of overhead, that means your throughput will be 50% of what it was without Envoy unless you increase the number of connections. More details are in the blog I posted above.

For mixer we had " policyCheckFailOpen: true" .
so even if mixer is over loaded traffic should get passed . as policyCheckFailOpen is set to true.
#policyCheckFailOpen allows traffic in cases when the mixer policy service cannot be reached.
#Default is false which means the traffic is denied when the client is unable to connect to Mixer.
Upgrading istio is option is there. Still we want to verify everything . then will go for upgrade.
How to increase the cpu for only for side car . it is 10m . default value is taking ...
I tried to update the deployment file of application. with the following :
annotations:
    sidecar.istio.io/proxyCPU: "1"
    sidecar.istio.io/proxyMemory: 1Gi

And restarted the pod , still it is showing default value.

For mixer we had " policyCheckFailOpen: true" .

This is only for mixer policy, mixer telemetry is also a factor. Even if it fails open, it can still impact latency though I believe, as it may take some time for the request to fail.

How to increase the cpu for only for side car . it is 10m . default value is taking ...

For 1.0 I am not sure, we don't support that version anymore and I have never used it.
In 1.2 you can use https://istio.io/docs/reference/config/installation-options/#global-options
global.proxy.resources.requests.cpu
So are you using mixer policy at all?

We have tried to disabled mixer .. but that also is giving same result. was there any memory leak related problem in 1.0.6 . any idea?

There have been many many performance problems addressed since 1.3. Without
more details about what problems you are seeing it's hard to say
On Mon, Aug 5, 2019, 1:35 AM nokiabaitanik<EMAIL_ADDRESS>wrote:

We have tried to disabled mixer .. but that also is giving same result.
was there any memory leak related problem in 1.0.6 . any idea?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/istio/istio/issues/15981?email_source=notifications&email_token=AAEYGXPQ27VJ6AUR3ZDXPPLQC7Q4NA5CNFSM4IIQBMWKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD3RDCQI#issuecomment-518140225,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAEYGXICJULOFULIMK3WMPLQC7Q4NANCNFSM4IIQBMWA
.

Okay. fine. we will update the istio version and check and if still it persists , will seek for help.
I am closing the ticket now.
Thanks for the help and information.

We updated the istio to 1.2.3 . but issue still persists . performance is degrading over time.
without istio tps is going to 8k. with istio side car it is max going 2.5k ..
But the main issue is it is degrading over time. even it is 2.5k ,it should be stable at 2.5k.
For application container:
resources:
limits:
cpu: "2"
memory: 3Gi
requests:
cpu: "2"
memory: 3Gi
For istio side car :
resources:
limits:
cpu: "2"
memory: 1Gi
requests:
cpu: 100m
memory: 128Mi

How did you install istio? Is mixer enabled? Is it using high CPU/hitting the CPU limit?
Did you read https://istio.io/blog/2019/performance-best-practices/?
Can you provide more info about cpu usage of all components, what you set up is?

we used helm charts to install the istio . mixer was enabled .
mixer:
policy:
# if policy is enabled the global.disablePolicyChecks has affect.
enabled: true
telemetry:
enabled: true
Application was only 27% of cpu.
"cpu usage of all components, what you set up is?" -- > what components you need . If you have commands , please share that.

we have tried to disable mixer . but same thing.
disablePolicyCheck: true
mixerReportServer: disabled
And apart for application and istio-proxy nothing is taking up the cpu.

please refer https://github.com/istio/tools/blob/81cc22348059bb17ad9c2f571018e78780a1bbf5/perf/istio-install/values.yaml

resource wise , I am not sure whether there is a problem or not . because cpu limit was not hitting earlier.
and even for 500 tps it behaving same. But for 500 tps , it is stable for 2 hours . Then it starts dropping .
we are using the values.yaml what comes default with the istio helm charts. the cpu limis  is 2 and memory limit is 1Gi.

Please give an update. What others details you need?

Closed as dupe of #16370


Change term - scientificName

Term change

Submitter: Quentin Groom

Efficacy Justification (why is this change necessary?): To improve clarity of the term usage, particularly to distinguish the different terms that can hold a scientific Latin name

Demand Justification (if the change is semantic in nature, name at least two organizations that independently need this term): This is largely for people and organizations publishing Darwin Core files to avoid repeated questions that keep cropping up. The issue #28 highlighted that the definitions of scientificName, acceptedNameUsage and originalNameUsage are all similar to one another, however, their intended usage is quite distinct, even though it is not clearly documented. The intension of this suggested change is to add to the comments of the term to help users understand the use of the terms more easily. The suggested explanations were given by @deepreef in #28, but they are only preliminary.

Stability Justification (what concerns are there that this might affect existing implementations?):  The intension is that the comments would reinforce the existing definition and thus improve stability.

Implications for dwciri: namespace (does this change affect a dwciri term version)?: No implication

Current Term definition: https://dwc.tdwg.org/list/#dwc_scientificName
Proposed attributes of the new term:

Usage comments (recommendations regarding content, etc., not normative): This term should not contain identification qualifications, which should instead be supplied in the IdentificationQualifier term. When applied to an Organism or Occurrence, this term should be used to represent the scientific name that was applied to the associated Organism in accordance with the Taxon to which it was or is currently identified.
Examples: Coleoptera (order). Vespertilionidae (family). Manis (genus). Ctenomys sociabilis (genus + specificEpithet). Ambystoma tigrinum diaboli (genus + specificEpithet + infraspecificEpithet). Roptrocerus typographi (Györfi, 1952) (genus + specificEpithet + scientificNameAuthorship), Quercus agrifolia var. oxyadenia (Torr.) J.T. Howell (genus + specificEpithet + taxonRank + infraspecificEpithet + scientificNameAuthorship).

I think @deepreef 's comment above is still very accurate and accommodates both the Taxon and Occurrence view.
My suggestion is that this becomes the updated usage comment.
One thing I wonder only now about is whether we should clarify that not only Linnean names are acceptable for scientificName, but also hybrids, OTU names or any other "label". Maybe this can be done just by adding a few examples:
Comments: The full scientific name, with authorship and date information if known. When forming part of an Identification, this should be the name in lowest level taxonomic rank that can be determined. This term should not contain identification qualifications, which should instead be supplied in the IdentificationQualifier term. When applied to an Organism or Occurrence, this term should be used to represent the scientific name that was applied to the associated Organism in accordance with the Taxon to which it was or is currently identified.
Example: Puma concolor (Linnaeus, 1771), Abies pinsapo var. marocana (Trab.) Ceballos & Bolaño, Salticidae, Formica Linnaeus, 1758, BOLD:ABY4511, Annona × cherimoya

I think @deepreef 's comment above is still very accurate and accommodates both the Taxon and Occurrence view.
My suggestion is that this becomes the updated usage comment.
One thing I wonder only now about is whether we should clarify that not only Linnean names are acceptable for scientificName, but also hybrids, OTU names or any other "label". Maybe this can be done just by adding a few examples:
Comments: The full scientific name, with authorship and date information if known. When forming part of an Identification, this should be the name in lowest level taxonomic rank that can be determined. This term should not contain identification qualifications, which should instead be supplied in the IdentificationQualifier term. When applied to an Organism or Occurrence, this term should be used to represent the scientific name that was applied to the associated Organism in accordance with the Taxon to which it was or is currently identified.

I have updated the Usage comment in the first comment in the issue. This is what will go out in this release. I have not updated the examples to include OTUs and hybrids, however, as this is new and hasn't had time for public consideration. We should include that in the later set of revisions for the definitions of the term set scientificName, acceptedNameUsage, parentNameUsage, originalNameUsage, and probably also verbatimIdentification.

Example: Puma concolor (Linnaeus, 1771), Abies pinsapo var. marocana (Trab.) Ceballos & Bolaño, Salticidae, Formica Linnaeus, 1758, BOLD:ABY4511, Annona × cherimoya

Done.


Create DownloadImageFromGEE.ipynb

How to extract data from GEE to HDFS
Did you read the Contributor Guide?

Yes, I have read Contributor Rules and Contributor Development Guide

Is this PR related to a JIRA ticket?

Yes, The PR name follows the format python-vector-osm.md (PR #582).

What changes were proposed in this PR?
New example
Did this PR include necessary documentation updates?

No, this PR does not affect any public API so no need to change the docs.

@carolgit What's the difference between the two conflicting notebooks? Can you fix it?


Merging dev to master for new release

Merging dev to master for new release

Changes Unknown when pulling 6f7fc9ed45e7625442e23234788fa8440207cab2 on dev into ** on master**.


Add items to Schema

This adds the ability to add "items" to a schema, which is required if you want to use array information.

@DavyHubrecht hey, will you continue with this one? it will be closed by stale bot pretty soon I think

@DavyHubrecht hey, will you continue with this one? it will be closed by stale bot pretty soon I think


Remove ICU4J

#1570 started to use standard plugins with embulk-util-guess:0.3.0, which has its own copy from ICU4J. Embulk is now free from ICU4J that has occupied ~10MB in the executable binary.
The embedded lib/embulk/guess/charset.rb needed ICU4J, but it's now obsolete. The standard guess plugins should have no problems because they have their own copy of ICU4J. Some third-party guess plugins may be impacted, though.

Thanks!


Subnetwork final + Model Version 2.0 alpha2

Summary
Important This PR Replaces #166 and #175 and is the follow-on for #185
TL; DR: Test features of this PR with the following commands:

micro test of all features: python compute_nhd_routing_SingleSeg_v02.py -f ../../test/input/yaml/CustomInput.yaml;
a bigger dataset with no WRF-Hydro input: python compute_nhd_routing_SingleSeg_v02.py -n Mainstems_CONUS -tv --nts 288 --parallel by-subnetwork-jit-clustered --subnet-size 150 --debuglevel 1
TODO:
Falls Lake Florence Event (requires not-yet-available input datasets + attached input file)
CONUS (only works on Cheyenne; requires attached input file)

This PR includes

a new function build_subnetworks that takes the subnet creation function of the 'subnetwork_creation' branch and pushes those subnetworks through a threaded call to the compute_network script. A number of upgrades implemented here reduce the most critical performance bottlenecks so that CONUS Full Resolution simulation is now feasible.
Ability to execute based on an input .json or .yaml file defining all other input parameters or data file locations. As inputs and model controls become more complex, this ability permits more efficient input
Integrated capability for reading channel warm states from WRF-Hydro restart files. Code for reservoir warm states is present but should be brought on-line and tested in another PR.
Integrated capability for comparing the t-route output to the Wrf-Hydro output for the same set of input qlaterals and restart files. This builds on capability introduced as part of #185 and is a key tool for demonstrating parity with existing NWM functions.
Reorganization of the v02 execution and compile scripts (organization, dev option for package install, blacking, additional cli options...)

This is the next level of the version 2.0 alpha of our framework (see #185 initial alpha). When the reservoir and Data Assimilation capabilities are incorporated with the capabilities in this PR, that should represent the full beta. Delivered as such, with any appropriate testing and minor performance or feature upgrades, the framework will be able to replace all relevant functions of the existing channel routing capability within the NWM framework. In addition to reservoir and DA integration, standardization of outputs to match the current NWM, and incorporation of more appropriate logging are two important elements of the final delivery.
Explanation
1) build_subnetworks
With this PR, four execution modes are availble: serial (default), --parallel by-network; --parallel by-subnetwork-jit; and --parallel by-subnetwork-jit-clustered
Tests:
python compute_nhd_routing_SingleSeg_v02.py -n Mainstems_CONUS -tv --nts 288 --debuglevel 1
python compute_nhd_routing_SingleSeg_v02.py -n Mainstems_CONUS -tv --nts 288 --parallel --debuglevel 1
python compute_nhd_routing_SingleSeg_v02.py -n Mainstems_CONUS -tv --nts 288 --parallel by-subnetwork-jit --subnet-size 150 --debuglevel 1
python compute_nhd_routing_SingleSeg_v02.py -n Mainstems_CONUS -tv --nts 288 --parallel by-subnetwork-jit-clustered --subnet-size 150 --debuglevel 1

On a workstation with 36 cores (which are all used by default under the parallel scheme with no --cpu-pool option specified), this runs in 92, 42, 24, and 24 seconds, respectively -- not a full linear scaling, but a clear improvement. These simulations use a constant qlateral at all segments and a warm state of 0.
TODO: The output shown with the debuglevel is sorted differently for the two tests... fix this.
The scaling is sensitive to the subnet-size. Choosing a too-large subnet-size reduces the potential parallelizability of the problem; a too-small subnet-size incurs significant overhead because the GIL must be reacquired, as presently configured, in between each level of subnetwork.
__TODO: __ Encapsulate the entire build_subnetwork capability into a function -- currently, the output requires further processing before it can be used in the compute_network routing engine.
The test has also been executed with the CONUS_FULL_RES_v20 network. Execution on the full-resolution dataset exposes an important limitation of our subnetwork development process. When the network is extremely dense (as in the case of the full-resolution NHD-based NWM hydrofabric), the subnetwork generation algorithm produces many small subnetworks at the 'leaves' of the traversal (i.e., near the headwaters). If these are simulated individually, they use the parallel pool resources very inefficiently. The workaround presented here is to cluster the small subnetworks together and include them with other subnetworks so that the computational load is more evenly distributed across threads. While there are a number of ways this could be improved, my recommendation is that we look at two in the near term (see below.)
# Standard serial execution

# Standard by-network parallelization
ipython compute_nhd_routing_SingleSeg_v02.py -- -t -n CONUS_FULL_RES_v20 -v --debuglevel 1 --parallel --nts 100 --cpu-pool 12
_JIT Preprocessing time_ 0 seconds.
_PARALLEL TIME = total time_  seconds

# Just-in-time Subnetwork parallelization _with no_ clustering
ipython compute_nhd_routing_SingleSeg_v02.py -- -t -n CONUS_FULL_RES_v20 -v --debuglevel 1 --parallel by-subnetwork-jit --subnet-size 15000 --nts 100 --cpu-pool 12
_JIT Preprocessing time_  seconds.
_PARALLEL TIME_  seconds.
_Total time_  seconds.

# Just-in-time Subnetwork parallelization _with_ clustering
ipython compute_nhd_routing_SingleSeg_v02.py -- -t -n CONUS_FULL_RES_v20 -v --debuglevel 1 --parallel by-subnetwork-jit-clustered --subnet-size 15000 --nts 100 --cpu-pool 12
_JIT Preprocessing time_  seconds.
_PARALLEL TIME_  seconds.
_Total time_  seconds.

Just-In-Time parallelization
The "Just-in-Time" or JIT idea is explained further in our AGU poster:
TODO: Get the AGU content into a Markdown file in this Git repository. (Also consider publishing via ORCID.)

Calculate first the headwater reaches of edges of the longest network...
Followed by all reaches below headwaters, etc.
Orchestrating the computation so each dependency is computed just before it is needed downstream (hence "Just-in-time") provides best theoretical potential speedup.
Practical efficiencies are obtained by grouping the reaches into cascading orders of subnetworks.

Caption: Grouping the reaches into subnetworks balances the practical impact of many parallel calls. An optimal subnetwork size is small enough to permit sufficient parallelism and large enough to ensure that parallel overhead is not burdensome. Colors denote subnetworks of common reverse network order. Higher order subnetworks are computed prior to lower order subnetworks in order to maintain topological dependencies.
Opportunistic Parallelization
Using a very similar analysis of the network, but ordering instead from the headwaters, we could identify all the subnetworks that could execute simultaneously in a first pass, and so on down to the bottom. While this seems like a nuanced difference from the JIT (which calculates any given subnetwork only just before it is needed by the downstream neighbors; or in other words, the precedents to each subnetwork are guaranteed to be part of the calculation immediately preceding it), the Opportunistic parallelization approach with uniformly sized subnetworks actually guarantees a pretty significant bottleneck towards the end of a very large network (i.e., the Mississippi), when only a single series of reaches or subnetworks remains. Undoubtedly, there are approaches to laying out the subnetworks to minimize the difficulty...
Options for improving the subnetwork creation
Per comment above, these are two most likely candidates for improving the subnetwork algorithm:
TODO: Implement:

a heuristic subnetwork construction scheme that generates even-sized networks;
experiment with and document computational performance impacts of thinning the network.

A number of other possibilities include the following:

For parallel execution path between the network-based parallelization and the subnetwork-based parallelization, it seems like the the function we need to imitate is reachable_network, which produces the independent_networks object, as they are called in this branch. reachable_network calls the reachable function, which I propose could be adapted to accept option inputs to specify split points (see note below)
The return from reachable_network could include additional "remainder" sets specifying the next upstream elements from what was reached in the BFS traversal -- if the traversal continues to the leaves of the network, the "remainder" set would be empty and if the traversal is split somehow, the remainder would be a set of new subnetwork tailwaters to continue tracing upstream.
The split points could be specified by any of the following (not an exhaustive list of options):

reservoir inlets and outlets
a maximum number of segments or junctions (the tracing algorithm would have to step backward after passing the threshold)
a minimum number of segments or junctions (the tracing algorithm would have to continue one step forward after passing the threshold; this is what is currently implemented in build_subnetworks.
any arbitrary list of junction segments
a number of subnetworks to target (would require additional functions to count and divide into one of the more elemental subdivision types.)

Also... While not strictly necessary for execution, we are choosing to require that the subdivision must always split at junctions. This greatly simplifies the logic to connect between the cascading subnetworks.
2) Yaml/Json input control
Reading a custom input file was introduced incrementally in pull requests #149 #137 #90 and is moved forward an additional level with this PR.
 If we wish, we could adjust the v01 scripts to use the named-columns.
3) WRF-Hydro Warm States Read
The ability to ingest a warm state dataframe has been present for a while. This simply uses the already-built v01 function to read warm states and passes them into the proper dataframe in v02.
TODO: As visible in the above output from the CustomInput.json simulation, the is almost identical (values on 10, 16, 20, an 21 differ by .000001...). It would be good to be absolutely clear on the reason for the deviations since we have proven that correlation can be binary identical if the inputs are identical --- I suspect that there is a difference in the precision of the stored warm states vs. their internal value when used by WRF-Hydro.
4) Test capability
The test capability is triggered by including the following elements in the custom input file (populated with the default test data in the repository):
parity_parameters:
    parity_check_input_folder: "../../test/input/geo/NWM_2.1_Sample_Datasets/Pocono_TEST1/example_CHRTOUT/"
    parity_check_file_pattern_filter: "/*.CHRTOUT_DOMAIN1"
    parity_check_file_index_col: feature_id
    parity_check_file_value_col: streamflow
    parity_check_compare_node: 4186169

TODO: Add identical command-line flags in a command group.
TODO: Rebuild the time-step flexible capabilities in the original --test pocono1
5) Miscellaneous
This series of updates includes a number of refinements ultimately leading to being able to execute a CONUS-wide parity test and benchmark run. What we learned in heading that direction is that we have significant work to do to handle I/O more effectively.
TODO: Create self-looping capability to allow simulations of arbitrary length; for instance, the 8-year benchmark simulation would take quite a long time to load, if it loaded at all, and would likely far exceed any reasonable memory limit during execution.

Tagging contributors:
@awlostowski-noaa
@jhrehanoaa
@groutr
@jdhondia-noaa
@kumdonoaa

Tagging contributors:
@awlostowski-noaa
@jhrehanoaa
@groutr
@jdhondia-noaa
@kumdonoaa

ping @jmmcreight

ping @jmmcreight


init

See the readme for deets

Actually, I'd suggest moving all source and tests into a src folder, we use this pattern in other TS packages and it makes things pretty smooth as the build folder is kept seperately in dist.

Swapped things around @SimonSchick . A bit cleaner now 😄


added batching to matcher.py and unit tests

Description
A new environment variable, BATCH_SIZE, was introduced in the matcher.py file to control the batch size when sending items to the LLM. The default value for BATCH_SIZE is 50 if the environment variable is not explicitly set.
Additionally, a function process_items_in_batches() was added to implement the batching logic. This function divides the input items into batches based on the BATCH_SIZE value and processes them accordingly. Special handling ensures that when BATCH_SIZE is set to 0, all items are processed together in a single batch.
Fixes #63
Type of change
Please delete options that are not relevant.

[ ] Bug fix (non-breaking change which fixes an issue)

Testing
Six unit tests were implemented to verify the functionallity of the batching logic:

Test for basic batching: Confirms that 10 items are split into 2 batches when BATCH_SIZE is set to 5.
Test for single batch: Ensures that when BATCH_SIZE exceeds the number of items, all items are processed in a single batch.
Test for BATCH_SIZE == 0: Validates that batching is disabled, and all items are processed together.
Test for negative BATCH_SIZE: Ensures that when BATCH_SIZE is set to a negative value, it defaults to 0.
Test for default behavior: Confirms that BATCH_SIZE defaults to 50 when the environment variable is not set.
Test for invalid BATCH_SIZE: Verifies that BATCH_SIZE defaults to 50 if set to an invalid value.

Test Configuration

Library version:
OS: Windows11
Toolchain: 3.10.0

Checklist

[ ] My code follows the style guidelines of this project
[ ] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes
[ ] Any dependent changes have been merged and published in downstream modules
[ ] I have checked my code and corrected any misspellings

Thanks Anastasia!


this doesn't work anymore

Describe the bug
A clear and concise description of what the bug is.
VOD / Channel link
The url where you encountered the error
Browser
Chrome, Edge, Firefox, Brave, ...
Additional context
Add any other context about the problem here.

Doesn't on Chrome but still works on Firefox

Hello, I used the extension a few months ago and everything is fine until now the direct message only for subscribers appears again... I uninstalled it, installed it and it's still the same.

same on opera :(

same here on Chrome, I really hope that this will be corrected/updated soon, I really appreciate this extension, I would be so down if it disappeared

works on firefox / edge

worked fine on firefox yesterday but doesn't work anymore on any vod

No longer works on edge, for me

update : works on firefox in incognito mode for whatever reason

Hello,
Here's a link to a VOD that doesn't work for me
https://www.twitch.tv/videos/2112631244

Hello, Here's a link to a VOD that doesn't work for me https://www.twitch.tv/videos/2112631244

tested with edge and firefox. it works, i forgot about Hugo :D

Same issue.. doesn't work any more on Chrome and Edge (normal browser and inprivate/incognito)

It works in incognito mode because any incompatible extensions are also disabled, in my case, using chrome, it was the TTV LOL extension preventing this one from working. Once disabled, this one started working again, if you have it, or any other ad blocker extension for twitch, try disabling them.

It works in incognito mode because any incompatible extensions are also disabled, in my case, using chrome, it was the TTV LOL extension preventing this one from working. Once disabled, this one started working again, if you have it, or any other ad blocker extension for twitch, try disabling them.

i tried disabling every extensions i have on normal mode but it doesn't work. it still does in incognito mode tho

Oh, it works for you. I didn't expect you to know Hugo :D

how did you install it so we see why it doesn't work

mine for exemple

It works in incognito mode because any incompatible extensions are also disabled, in my case, using chrome, it was the TTV LOL extension preventing this one from working. Once disabled, this one started working again, if you have it, or any other ad blocker extension for twitch, try disabling them.

i tried disabling every extensions i have on normal mode but it doesn't work. it still does in incognito mode tho

Did you try restarting firefox in normal mode after disabling the extensions?

Oh, it works for you. I didn't expect you to know Hugo :D

how did you install it so we see why it doesn't work

mine for example

yeah so nothing special :(

Oh, ça marche pour vous. Je ne m’attendais pas à ce que vous connaissiez Hugo :D

Comment l’avez-vous installé pour que nous voyions pourquoi cela ne fonctionne pas

Here is my installation

I've deactivated all my extensions but it still doesn't work, except in incognito mode.

It works in incognito mode because any incompatible extensions are also disabled, in my case, using chrome, it was the TTV LOL extension preventing this one from working. Once disabled, this one started working again, if you have it, or any other ad blocker extension for twitch, try disabling them.

i tried disabling every extensions i have on normal mode but it doesn't work. it still does in incognito mode tho

Did you try restarting firefox in normal mode after disabling the extensions?

yes but it doesn't work either

It worked for me about 1 hour ago on chrome. Since then it no longer works. The only way to make it work is private browsing on Firefox, everything else is impossible.

deleting cookies for twitch.com made it work again for me on firefox

It still work. but if this extension were to be blocked/banned or patched by Twitch,
really, I wouldn't be surprised. because there are plenty of stupid kid guy attempting to boast by sharing title a clip
" I'm Hack Twitch! / Free Watch Sub Only VODs on Twitch! / I'm Hacker man 🤣 " on YouTube/Social. something like that :)
If it doesn't work in the future, it's nothing surprising.

Not working in firefox.

Just log out of your account and good job, you've solved this problem lmao

Just log out of your account and good job, you've solved this problem lmao

I just did that, and it does not fix it. (Deleted all cookies)

I can confirm clearing cookies for twitch.tv and reloading the page does work, even without private window (on Firefox)
Thanks @hozoruuuu

this solution doesn't work on edge, in any case for me the only one that works is incognito mode.

deleting cookies for twitch.com made it work again for me on firefox

thanks it worked for me too

Clearing all twitch.tv cookies in Edge (and restarting browser) does NOT work.

it works on chrome and opera:
You must go to the padlock then to cookies and site data then close access to all sites.
you can then refresh, start again if it doesn't work

After 10 times, it finally worked (edge). it's strange.

Please update to https://github.com/besuper/TwitchNoSub/releases/tag/0.7.1


feat: allow deleting uploaded files

Bug Report
Description
Bug Summary:
It looks like that when a document is removed through the UI, the file stays on disk.
Steps to Reproduce:
Upload a document, then remove it.
Go check the upload directory and the document is still here.
Expected Behavior:
Document should be cleaned if nothing in the UI need it anymore (no chat, no document)
Actual Behavior:
Document stays on disk
Reproduction Details
Confirmation:

[x] I have read and followed all the instructions provided in the README.md.
[x] I am on the latest version of both Open WebUI and Ollama.

Installation Method
docker

This is intended for admins to monitor what's being uploaded to the webui, but I agree we should have the option to clear the upload directory. Feel free to make a PR!

also for privacy reason, if one user wants to remove their file. it should not stay around on the server side.

I would also like to add, that there seems to be a bug, that when you tried to delete a document and want to reupload it (with different embedding or chunking params), you get an error message from chroma that collection is already present. only complete reset of vector store is currently fixing that.
2024-05-06 10:05:46 ERROR:apps.rag.main:Collection a306bf8fac91dba35a51d1eae7acbbff768e709c447684733365d0efecdb305 already exists 2024-05-06 10:05:46 Traceback (most recent call last): 2024-05-06 10:05:46   File "/app/backend/apps/rag/main.py", line 582, in store_docs_in_vector_db 2024-05-06 10:05:46     collection = CHROMA_CLIENT.create_collection(name=collection_name) 2024-05-06 10:05:46                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ 2024-05-06 10:05:46   File "/usr/local/lib/python3.11/site-packages/chromadb/api/client.py", line 198, in create_collection 2024-05-06 10:05:46     return self._server.create_collection( 2024-05-06 10:05:46            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ 2024-05-06 10:05:46   File "/usr/local/lib/python3.11/site-packages/chromadb/telemetry/opentelemetry/__init__.py", line 127, in wrapper 2024-05-06 10:05:46     return f(*args, **kwargs) 2024-05-06 10:05:46            ^^^^^^^^^^^^^^^^^^ 2024-05-06 10:05:46   File "/usr/local/lib/python3.11/site-packages/chromadb/api/segment.py", line 167, in create_collection 2024-05-06 10:05:46     coll, created = self._sysdb.create_collection( 2024-05-06 10:05:46                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ 2024-05-06 10:05:46   File "/usr/local/lib/python3.11/site-packages/chromadb/telemetry/opentelemetry/__init__.py", line 127, in wrapper 2024-05-06 10:05:46     return f(*args, **kwargs) 2024-05-06 10:05:46            ^^^^^^^^^^^^^^^^^^ 2024-05-06 10:05:46   File "/usr/local/lib/python3.11/site-packages/chromadb/db/mixins/sysdb.py", line 225, in create_collection 2024-05-06 10:05:46     raise UniqueConstraintError(f"Collection {name} already exists") 2024-05-06 10:05:46 chromadb.db.base.UniqueConstraintError: Collection a306bf8fac91dba35a51d1eae7acbbff768e709c447684733365d0efecdb305 already exists
Open WebUI Version
v0.1.123 (latest)

Added on dev!


Release gsa63

Codecov Report

Merging #227 (65e2cfe) into main (98b89b7) will increase coverage by 2.15%.
The diff coverage is 19.85%.

@@            Coverage Diff             @@
##             main     #227      +/-   ##
==========================================
+ Coverage   19.91%   22.06%   +2.15%
==========================================
  Files         208      220      +12
  Lines       27141    26954     -187
==========================================
+ Hits         5404     5948     +544
+ Misses      21737    21006     -731

Flag
Coverage Δ

gsagh
22.06% <19.85%> (+2.15%)
:arrow_up:

integration
∅ <ø> (∅)

Flags with carried forward coverage won't be shown. Click here to find out more.

 Learn more


docs(connectivity_plus): Improve documentation onConnectivityChanged method

Description
Following the discussion here: https://github.com/fluttercommunity/plus_plugins/pull/2599#issuecomment-2013129686
The goal of the plus plugins is to be as truth to the underlying platform as possible, while providing an easy way to access for all Flutter compatible platforms.
This PR adds a bit of context to the onConnectivityChanged method, explaining why the Stream may emit multiple values on Android.
Not that people ever reads documentation, but maybe someone will find it useful :)
Any comments are welcome.
Related Issues

Related: #2599

Checklist

[x] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[x] I titled the PR using Conventional Commits.
[x] I did not modify the CHANGELOG.md nor the plugin version in pubspec.yaml files.
[x] All existing and new tests are passing.
[x] The analyzer (flutter analyze) does not report any problems on my PR.

Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?

[ ] Yes, this is a breaking change (please indicate that with a ! in the title as explained in Conventional Commits).
[x] No, this is not a breaking change.

Thanks for taking care of this.
I had some thoughts on it and feel that maybe we could consider doing filtering with some distinct method? I don't think it should lead to some missed connection types changes being missed. I am in sort of doubtful state if it is worth it to send all events, especially duplicated ones.

Yes, I cannot think a case where a dev would want to get all the events and not just distinct.
We should also change from a List to a Set, to ensure the order of the data doesn't matter when calculating the distinct.
Kind of related, I'd like to add an assert as well to ensure that the returned list/set always contains at least one item and cannot be empty, since I've found myself having to check "if contains None or isEmpty" every time.


Version 1.0.32 - enable private cert

:tada: This PR is included in version 1.0.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Make or operator "smarter"

See this https://github.com/prometheus/prometheus/issues/9624. In case of a or b we only want to calculate b if a doesn't fully cover everything.
Related to https://github.com/thanos-community/promql-engine/issues/5

As it turns out the engine did not implement or at all. I attempt to add support for it in #318


fix: update article for JavaScript String.indexOf()

[x] I have read freeCodeCamp's contribution guidelines.
[x] My pull request has a descriptive title (not a vague title like Update index.md)
[x] My pull request targets the master branch of freeCodeCamp.
[x] None of my changes are plagiarized from another source without proper attribution.
[x] All the files I changed are in the same world language (for example: only English changes, or only Chinese changes, etc.)
[x] My changes do not use shortened URLs or affiliate links.

@moT01 Is this PR merge-ready?


Refactor examples and modules with run command flag change

Purpose
Required examples and documentation changes for https://github.com/ballerina-platform/ballerina-lang/pull/18633
Fixes #18709
Check List

[x] Read the Contributing Guide
[ ] Required Balo version update
[ ] Updated Change Log
[ ] Checked Tooling Support (#)
[ ] Added necessary tests

[ ] Unit Tests
[ ] Spec Conformance Tests
[ ] Integration Tests
[ ] Ballerina By Example Tests

[ ] Increased Test Coverage
[ ] Added necessary documentation

[ ] API documentation
[ ] Module documentation in Module.md files
[ ] Ballerina By Examples

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@512bf54). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master   #18708   +/-   ##
=========================================
  Coverage          ?   15.57%
=========================================
  Files             ?       47
  Lines             ?     1220
  Branches          ?      184
=========================================
  Hits              ?      190
  Misses            ?     1016
  Partials          ?       14

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 512bf54...7f2fbf6. Read the comment docs.


Improve Toxic Messages Dataset

Describe Problem
The current BERT based automod AI is not accurate enough for production use in the CSS server.
Suggest Solution
Some work has already been done in developing a new dataset. We need to integrate the non toxic messages into the dataset and expand on the toxic messages until we have a 10k/1k ratio, then retrain.

We now have a large corpus of toxic messages. I will begin work soon on sifting, augmenting, and utilizing the dataset.


Upgrade OpenRewrite Templating 1.20.0 -> 1.20.1

This PR contains the following updates:

Package
Type
Update
Change

OpenRewrite Templating

patch
1.20.0 -> 1.20.1

OpenRewrite Templating
compile
patch
1.20.0 -> 1.20.1

Release Notes

openrewrite/rewrite-templating (OpenRewrite Templating)
v1.20.1
Compare Source
What's Changed

Fix indenting by @jevanlingen in https://github.com/openrewrite/rewrite-templating/pull/121
Sort preconditions by uses-type and uses-method first by @jevanlingen in https://github.com/openrewrite/rewrite-templating/pull/122
Bugfix: Preconditions of overloaded @BeforeTemplate methods are filtered away by @jevanlingen in https://github.com/openrewrite/rewrite-templating/pull/123

Full Changelog: https://github.com/openrewrite/rewrite-templating/compare/v1.20.0...v1.20.1

[ ] If you want to rebase/retry this PR, check this box

Suggested commit message:
Upgrade OpenRewrite Templating 1.20.0 -> 1.20.1

See:
- https://github.com/openrewrite/rewrite-templating/releases/tag/v1.20.1
- https://github.com/openrewrite/rewrite-templating/compare/v1.20.0...v1.20.1

Looks good to me; thanks for the thorough comparison diff above! Here's the type of change we were after:
diff -u -r JUnitToAssertJRulesRecipes.java JUnitToAssertJRulesRecipes.java
--- JUnitToAssertJRulesRecipes.java	2024-12-22 11:47:38.165025627 +0100
+++ JUnitToAssertJRulesRecipes.java	2024-12-22 11:47:44.929053235 +0100
@@ -1197,8 +1197,11 @@
             };
             return Preconditions.check(
                     Preconditions.and(
-                        new UsesType<>("org.junit.jupiter.api.function.ThrowingSupplier", true),
-                        new UsesMethod<>("org.junit.jupiter.api.Assertions assertDoesNotThrow(..)", true)
+                        new UsesMethod<>("org.junit.jupiter.api.Assertions assertDoesNotThrow(..)", true),
+                        Preconditions.or(
+                            new UsesType<>("org.junit.jupiter.api.function.Executable", true),
+                            new UsesType<>("org.junit.jupiter.api.function.ThrowingSupplier", true)
+                        )
                     ),
                     javaVisitor
             );

For this set of templates:
https://github.com/PicnicSupermarket/error-prone-support/blob/acb8b651b725196f6c3cd182d1dcb3c1480d9514/error-prone-contrib/src/main/java/tech/picnic/errorprone/refasterrules/JUnitToAssertJRules.java#L678-L694
Previously we would only match one of those templates, or none at all, whereas we can now correctly match both.


Dict transformer doesn't match values

In a database, I'd like to transform values of a column using the Dict transformer. The original database has this:

The transformer used is configured like this
  transformation:

    - schema: public
      name: provider
      transformers:
        - name: Dict
          params:
            column: name
            values:
              Clinique Louis Pasteur Nancy: "Établissement 1"
              Clinique Ambroise Paré Thionville: "Établissement 2"
              Polyclinique La Ligne bleue: "Établissement 3"
              Clinique Jeanne d'Arc: "Établissement 4"
            # fail_not_matched: false

Yet, when validating or dumping, greenmask fails with
2024-04-25T16:06:46+02:00 WRN error flushing gzip buffer error="io: read/write on closed pipe"
2024-04-25T16:06:46+02:00 WRN error closing TableDumper writer error="error closing gzip writer: io: read/write on closed pipe"
2024-04-25T16:06:46+02:00 WRN error flushing gzip buffer error="io: read/write on closed pipe"
2024-04-25T16:06:46+02:00 WRN error closing TableDumper writer error="error closing gzip writer: io: read/write on closed pipe"
2024-04-25T16:06:46+02:00 WRN error flushing gzip buffer error="io: read/write on closed pipe"
2024-04-25T16:06:46+02:00 WRN error closing TableDumper writer error="error closing gzip writer: io: read/write on closed pipe"
2024-04-25T16:06:46+02:00 FTL cannot make a backup error="data stage dumping error: at least one worker exited with error: error processing table dump: dump error: dump error on table public.provider at line 1: dump error on table public.provider at line 1: unable to match value for \"Polyclinique La Ligne bleue\""

I tried to quote (single and double) the keys in greemask config, with no difference. I even tried with simple keys (without space or special chars) with the same result.

Hi! Thank you for reporting. I will check it ASAP.

I've just checked. The greenmask applied lowercase somehow. This is a bug.

It is not a bug, it is likely a design. So I should consider the best way how to overcome this obstacle

@dani
I've made a PR with the workaround. I need some time to test it. If everything is alright I will publish it in the next release (next week)

Fixed. You can build the main branch manually by calling make build or wait for the next release (expected next week)

Published in v0.1.11


require_client_auth exists but is never used

The parameter require_client_auth appears in the TLS sections of the various listeners, but is never used to generate any kubernetes object. This much be a copy/paste issue and could be removed, but I want to look into where it came from, the benefits of making it functional, and the time it would take to do so.

Will remove from values.yaml but keep this issue open.

https://docs.redpanda.com/docs/21.11/cluster-administration/configuration/


Get neighbor list

Is there an option the get
a list of all neighbors of a node using the "-n" flag?

That's missing... Should be not hard  to add, I'll try.

Closed by cb7eacf .


[Feature] Add progress bar smoothing

Currently for small files:

The progress wheel start off with a delay,
Then the wheel quickly spins an entire cycle
Then there's another delay at the end.

This can be improved by incorporating the setup & teardown times of the uploads into the progress, as suggested here.

Resolved with https://github.com/upload-js/uploader/commit/b34d2540d35cdda7fcefdc6077ad246888dfb131


Did not see the inferernce function in this repo.

Thanks for your excellent work. Though I do not know how to infer this model to synthesis audio. Could you please tell me how to do the inference and perhaps add more details in the readme?

You have to use coqui for inference. They have all the inference code for this model.

https://github.com/PyThaiNLP/PyThaiTTS/blob/dev/pythaitts/pretrained/khanomtan_tts.py


Requirement Gathering

@todo

[ ] User Requirement

[ ] User Research

[ ] User Interview (3 days)
- @input :question: Prepare user interview questions
- @output :question: Document containing user interview result
[ ] Stakeholder's Interview (1 day)
- @input :question: Prepare stakeholder interview questions
- @output :question: Document containing stakeholder interview result
[ ] Persona Creation (1 day)
- @input :question: Document containing interview result
- @output :question: User persona document
[ ] User Stories Map (1 day)
- @input :question: Document containing interview result
- @output :question: User story map document
[ ] User Task Flow (1 day)
- @input :question: User story map document
- @output :question: Task flow document

[ ] Product Requirement (2 days)

[ ] Study previous features and functionalities from the input document/resources
- @input :question: website section for organizing structure and processes
- @input :question: dat-ecosystem garden application form
- @input :question: Joining Rules
- @input :question: dat-ecosystem open collective account
- @output :question: Document containing layout structures, colors palletes, navigation structure and images

[ ] Business Requirement(2 days)

[ ]    Conduct Comepetitive Analysis

[ ] Identify competitors
[ ] Analyze competitors' online presence
[ ] Check online reviews
[ ] Talk to competitors’ customers
[ ] Identify their strengths and weaknesses

@output :question: dat ecosystem requirement document

Next #40

@info
The product requirement section defines the product we are about to build: It outlines the product's purpose, its features, functionalities, and behavior. Next, you share the PRD with (and seek input from) stakeholders - business and technical teams who will help build, launch or market your product.
A competitive analysis is a strategy that involves researching major competitors to gain insight into their products, sales, and marketing tactics. Implementing stronger business strategies, warding off competitors, and capturing market share are just a few benefits of conducting a competitive market analysis.

feedback 2022.04.28
good, but :-)

the first todo requirement gathering does not need to be a link to itself, raw text is enough

the inputs should not have a checkbox and the reason is, that it is good enough to know there is an input planned and once you created that input as an output elsewhere (e.g. in #45), then you can update the symbol from :question: to :package: and you are also familiar with the input ...but if the input was created by somebody else than you, then just make an extra todo with a checkbox that says:

* [ ] study User Research
    * `@input` :question: [`user research document`](#...)

also ...no input or output should ever link to issues, they always have to link to documents and only if inputs were produced in other issues you should use from #<no> to indicate that issue and if an output is used in other issues you can list them as a sub bullet point list of next #<no> to iterate all the issues the output is used in as an input

lastly, the next #40 needs to be attached to at least a single output if you want to do this issue at all :-)

merged into #49


Control ColumnHeadingComponent

Hey,
I'm trying to pass two arguments to a custom column heading component:

A boolean - whether a checkbox is checked
A function - toggles the checkbox

But I cannot seem to pass the new boolean every time it changes...
I'm doing something like this:
In the Griddle render, I have a map function to map the columns definitions, and i'm doing this:
.map(column => {
    const {
        columnName: id,
        displayName,
        customComponent,
        cssClassName,
        customHeaderComponent: CustomHeaderComponent,
        customHeaderComponentProps
    } = column;

    const props = {
        cssClassName,
        id,
        title: displayName
    };

    if (customComponent) {
        const enhancedComponent = EnhanceWithRowData(props => {
            const componentProps = _.assign({}, props, { metadata: column });
            return customComponent(componentProps);
        });
        props.customComponent = enhancedComponent;
    }

    if (CustomHeaderComponent) {
        console.log(customHeaderComponentProps);
        const enhancedComponent = EnhanceWithMetada(props => {
            const componentProps = _.assign({}, props, { metadata: customHeaderComponentProps });
            return <CustomHeaderComponent {...componentProps} />;
        });
        props.customHeadingComponent = enhancedComponent;
    }

    return (
        <ColumnDefinition key={id} {...props} />
    );
})

const EnhanceWithMetada = connect((state, props) => ({
    metadata: props,
}));

and in my component:
const EnableDisableHeaderCell = ({ metadata }) => {
    const { isChecked, onToggle } = metadata;
    const title = isChecked ? 'Shows all users in the account' : 'Shows only users who are enabled in the account';

    return <span className="cell-true-false-toggler">
            Enabled
            <input
                className="ios-switch-small"
                id="enabled-users-cell"
                onChange={onToggle}
                title={title}
                type="checkbox"
                checked={isChecked}
            />
            <label htmlFor="enabled-users-cell" title={title} />
        </span>;
};

I really don't know what to do from, tried everything...

Can you share what onToggle?

onToggle(e) {
    const { checked } = e.target;
    this.setState({ checked });
}

And how does the checked property in state turn into an isChecked property in metadata?
Or more generally, could you post a Gist (or PR with a story!) that's self-contained? It feels like the problem is how state is propagating through.

I'll try to do my best to describe it here -
I have 3 components:

Users table container - where I have the defs of the columns (columnMetadata for griddle V0.x)
CustomGriddle - where I just pass the columnMetadata as a param
CustomHeaderComponent (the one I pasted earlier)

The users table container builds the columnMetadata according to it's state -
In one certain column (call it 'enabled'), it adds the 'isChecked' state's var to the column's metadata (and also the onToggle function)
when press on 'onToggle' in the header component, it raises the 'handleToggle' in the users table container, which sets the state, changes the columnMetadata and then of course re-renders, which re-render the customGriddle which render the CustomHeaderComponent
As you can see (I hope you can, I'm really trying to do my best...) I'm trying to convert my app from v0 to v1... and I get stuck on these things...

@liorbentov Did you ever figure this out?


Add support for static ips

We are not using floating-ips and will get 403 for anything related to floating ips.
Thus we are having problems deleting the instances since it will do a floating ip list first.
https://github.com/jenkinsci/openstack-cloud-plugin/blob/master/src/main/java/jenkins/plugins/openstack/compute/internal/Openstack.java#L324
Can anyone help with this? Make floating ip  configurable?

The feature is not there. Please watch #128 for progress.