Make it possible to use arbitrary non-Route elements inside of a Switch

See #31

Codecov Report

Merging #33 into master will not change coverage.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master      #33   +/-   ##
=======================================
  Coverage   98.41%   98.41%
=======================================
  Files           5        5
  Lines         126      126
  Branches       24       25    +1
=======================================
  Hits          124      124
  Misses          2        2

Impacted Files
Coverage Δ

index.js
100% <ø> (ø)
:arrow_up:

matcher.js
100% <100%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f1fd7ee...259fb74. Read the comment docs.


Unknown Column Path

Motivation
While using tap-hubspot, Singer Slack User Patryk Kallinowski ran into the following error:
target_postgres.postgres.PostgresError: ('Exception writing records', Exception("Unknown column path: ('properties', 'num_contacted_notes', 'value') for table: ('deals',)"))

After uploading his catalog.json file generated by tap-hubspot, the issue appears to be around this stream/sub-schema:
{
  "streams": [
    {
      "stream": "deals",
      "tap_stream_id": "deals",
      "schema": {
        "type": "object",
        "properties": {
          ...
          "properties": {
            "type": "object",
            "properties": {
              ...
              "num_contacted_notes": {
                "type": "object",
                "properties": {
                  "value": {
                    "type": ["null", "number", "string"]
                  },
                  ...
                }
              },
              ...
            }
          }
        }
      },
      "metadata": [
        ...
      ]
    }
  ]
}

At the very least, this error message can be improved to:

contain more context and information for those debugging
more descriptive/better language to identify what precisely has gone wrong
be associated with a function which has a complete docstring

And:

more testing to assure that whatever underlying bug (if any) is resolved

Notes
https://singer-io.slack.com/archives/C2TGFCZEV/p1552316668073400
catalog.json can't be uploaded as a part of this issue, available via download in the link above.
Suggested Musical Pairing
https://www.youtube.com/watch?v=PfrHCNo2I3M

I think I've identified the bug here. It has to do with how we're serializing fields which have multiple types. There are, I think, a couple bugs therein:

multi type, non numeric
single type, [null, number] which has values being sent as integers (ie, the schema is [null, number], but the values are something like 1234, 567, 8, 90 etc.

I'm fixing this bug, and then I will improve the error message.

Correction: the single type for [null, number] is perfectly fine.
I've found the issue. When we have a null value we cannot assign it a "python type". ie, we don't really know what value "lack of value" represents in Postgres. As such, for split column types, we don't know which column to write "nothing" to.
The fix, is effectively to do less work. Presently we set default null values for every column in the remote schema. Since we've already done this, if we see that we're going to write yet another null value to the column, we can avoid this, which circumvents us trying to find a column mapping for an unknown schema.


Spreadsheet improvement

I am listing some improvements to the final spreadsheet:

Not stamp Manf and Desc column if all them are empty / None /  '' / not exist in all designators  (this rule may be also include to Value column, this would happen with the CSV module);
Add a fourth color / rule to Qty column (maybe gray), priority to the other 3, with the logic colorize if all Manf# and  Cat# are empty. Reason: sometimes I want to make a list and buy just the specific components, usually common resistors and capacitors remains in my "local stock", so I leave this designators empty in KiCad, but I keep filled the manf#of the specific kind of R.

It was not getting other informations.


Healthmonitor resurrects on SSH login alerts

Whenever a user does ssh into a VM (manual or by doing bosh ssh), the agents sends an alert to the Healthmonitor (https://github.com/cloudfoundry/bosh-agent/blob/master/agent/alert/ssh_adapter.go#L16). The HM has a pretty simple check to figure out if resurrection needs to be triggered for an alert, which just checks for the presence of a few properties (https://github.com/cloudfoundry/bosh/blob/master/src/bosh-monitor/lib/bosh/monitor/plugins/resurrector.rb#L38).
Turns out, those ssh alerts from the agent do have those properties set, here is an example what it looks like:
<Bosh::Monitor::Events::Alert:0x00557d12802a98 @attributes={"id"=>"4427b8ec-f0c2-483d-5f9f-328f4b340a8f", "severity"=>4, "title"=>"SSH Login", "summary"=>"Accepted publickey for vcap from <IP> port 33080 ssh2: RSA e3:5f:58:81:63:dc:86:04:c4:44:ec:64:fa:e2:6a:5c", "created_at"=>1493049382, "source"=>"service-fabrik-0116-dc8e0796-f55b-41a1-aee4-5403e1756f3b: postgresql_slave_z1(2fba6f93-a142-49d9-845a-2a131f8a4f85) [id=500e3447-a4cb-4ef3-b5ea-aecd648f7e4f, index=0, cid=i-0024e3bb42d1260e3]", "deployment"=>"service-fabrik-0116-dc8e0796-f55b-41a1-aee4-5403e1756f3b", "job"=>"postgresql_slave_z1", "instance_id"=>"2fba6f93-a142-49d9-845a-2a131f8a4f85"}, @kind=:alert, @logger=<Logging::Logger:0x2abe892b9928 name="/var/vcap/sys/log/health_monitor/health_monitor.log">, @errors=#<Set: {}>, @id="4427b8ec-f0c2-483d-5f9f-328f4b340a8f", @severity=4, @title="SSH Login", @summary="Accepted publickey for vcap from <IP> port 33080 ssh2: RSA e3:5f:58:81:63:dc:86:04:c4:44:ec:64:fa:e2:6a:5c", @source="service-fabrik-0116-dc8e0796-f55b-41a1-aee4-5403e1756f3b: postgresql_slave_z1(2fba6f93-a142-49d9-845a-2a131f8a4f85) [id=500e3447-a4cb-4ef3-b5ea-aecd648f7e4f, index=0, cid=i-0024e3bb42d1260e3]", @deployment="service-fabrik-0116-dc8e0796-f55b-41a1-aee4-5403e1756f3b", @job="postgresql_slave_z1", @instance_id="2fba6f93-a142-49d9-845a-2a131f8a4f85", @created_at=2017-04-24 15:56:22 UTC>

Director doesn't do anything, but still executes a scan_and_fix task.

Updated to reflect that this also happens when doing bosh ssh

I'm also seeing this behavior due to the following other messages:
health_monitor.log-I, [2017-04-27T16:11:58.438951 #52726]  INFO : [ALERT] Alert @ 2017-04-27 16:11:58 UTC, severity 1: process is not running
health_monitor.log-I, [2017-04-27T16:11:58.439098 #52726]  INFO : (Event logger) notifying director about event: Alert @ 2017-04-27 16:11:58 UTC, severity 1: process is not running
health_monitor.log:W, [2017-04-27T16:11:58.439553 #52726]  WARN : (Resurrector) notifying director to recreate unresponsive VM: warden-prometheus prometheus/05d41d5e-0afc-4894-8e0f-45b4c8260d0f

(it appears a process is repeatedly crashing on that VM due to lack of disk space, but monit keeps restarting it.. yet this is trying to trigger a VM recreation?)
I, [2017-04-27T16:06:20.072576 #8017]  INFO : [ALERT] Alert @ 2017-04-27 16:06:20 UTC, severity 4: Connection closed by <IP_ADDRESS> [preauth]
I, [2017-04-27T16:06:20.072745 #8017]  INFO : (Event logger) notifying director about event: Alert @ 2017-04-27 16:06:20 UTC, severity 4: Connection closed by <IP_ADDRESS> [preauth]
W, [2017-04-27T16:06:20.073258 #8017]  WARN : (Resurrector) notifying director to recreate unresponsive VM: eastus-jumpbox jumpbox/5b46a0c7-1724-438e-a560-eb4a94044672

(an artifact of having a public IP)

Validated this is fixed in 3586.x, tested on 3586.36.


fix #447 archive_max_duration

This thing is seems to be fixed in release_v2.0.3 version.
Closing for that reason - it is basically the same thing.


Undefined method `preview_source'

I recently installed lookbook on dev environment and I could not make it work. I am getting the error once I select the component to preview.
Undefined method `preview_source' for #<Lookbook::Preview:0x00007f17f70fa5f8 @preview=GroupComponents::SearchComponentPreview, @preview_inspector=#<Lookbook::SourceInspector:0x00007f17f70fa5d0 @code_object=#<yardoc class GroupComponents::SearchComponentPreview>, @position=10000, @label=nil, @hidden=false, @methods=[#<yardoc method GroupComponents::SearchComponentPreview#default>], @id=nil, @display_params={}>, @items=[], @path="group_components/search", @refpath="group_components/search", @examples=[#<Lookbook::PreviewExample:0x00007f17f98213c0 @name="default", @preview=#<Lookbook::Preview:0x00007f17f70fa5f8 ...>, @example_inspector=#<Lookbook::SourceInspector:0x00007f17f98211e0 @code_object=#<yardoc method GroupComponents::SearchComponentPreview#default>, @label=nil, @hidden=false, @display_params={}>, @refpath="group_components/search/default">]>
Did you mean?  preview_class

I am currently using (If that helps):
ruby version 3.1.0
rails version <IP_ADDRESS>
Thanks for your help beforehand.

Yeah!
That worked...
Thank you very much.

Excellent! Glad it's sorted :-) To be honest Lookbook should probably disable that setting when rendering previews. I'll try to add that in to stop other people running into the same issue.


Drop card banner = collection banner Leadlight

can we make the card banner same as the collection banner?

its smol but it looks much better

can we make the card banner same as the collection banner?

Yes, let's have a try


problems when there are top level filesystem mount points

In the code that tries to mount the overlays, there is a check for top level directory mount points that is a little too aggressive for systems the have user filesystems mounted at locations like /srv and /home (which is the custom of the system administrators where I work).
this line
       if [ -d "$top_dir_abs" ] && ! mountpoint -q "$top_dir_abs"; then

excludes the LVM volumes mounted at /srv/and /home on my system via the "! mountpoint" clause.
When I run try from my home directory (/home/mccahill) it fails like this:
        /tmp/tmp.P5nVCaSZ5L: line 4: cd: /home/mccahill: No such file or directory

Try does run correctly when run from a directory for which it has created an overlay.
I can see why try wants to exclude mounts like /boot, /dev, /proc, /run, /sys, and so on, but user filesystem mounts need to have overlays.

Thanks for the report! Could you please try the branch mount-fix and let me know if it works on your setup.

I encountered this same issue, and yes the mount-fix branch fixes it for me :raised_hands:

I have the same issue, and the current main does not fix it for me:
16:06:01 $ try pip3 install libdash
Warning: Failed mounting /home as an overlay, see /tmp/tmp.R14M4UGHNQ
Warning: Failed mounting /snap as an overlay, see /tmp/tmp.R14M4UGHNQ
Warning: Failed mounting /tmp as an overlay, see /tmp/tmp.R14M4UGHNQ
Warning: Failed mounting /usr as an overlay, see /tmp/tmp.R14M4UGHNQ
Warning: Failed mounting /var as an overlay, see /tmp/tmp.R14M4UGHNQ
Warning: Failed mounting /run/user/1000/doc as an overlay, see /tmp/tmp.R14M4UGHNQ
Warning: Failed mounting /home/stavros as an overlay, see /tmp/tmp.R14M4UGHNQ
Warning: Failed mounting /usr/local as an overlay, see /tmp/tmp.R14M4UGHNQ
Warning: Failed mounting /var/games as an overlay, see /tmp/tmp.R14M4UGHNQ
Warning: Failed mounting /var/log as an overlay, see /tmp/tmp.R14M4UGHNQ
Warning: Failed mounting /var/lib as an overlay, see /tmp/tmp.R14M4UGHNQ
Warning: Failed mounting /var/lib/AccountsService as an overlay, see /tmp/tmp.R14M4UGHNQ
Warning: Failed mounting /var/lib/apt as an overlay, see /tmp/tmp.R14M4UGHNQ
Warning: Failed mounting /var/lib/NetworkManager as an overlay, see /tmp/tmp.R14M4UGHNQ
Warning: Failed mounting /var/lib/dpkg as an overlay, see /tmp/tmp.R14M4UGHNQ
Warning: Failed mounting /var/lib/docker/zfs/graph/ab70723c0d03ace2dab092988bdb726b9c7da165ef903741ed6d85d7a7489ca4 as an overlay, see /tmp/tmp.R14M4UGHNQ
Warning: Failed mounting /var/lib/docker/zfs/graph/c2276dcb514032531472e4f20341225fe99c0cdad1af3b87812b2789481ea9de as an overlay, see /tmp/tmp.R14M4UGHNQ
Warning: Failed mounting /var/snap as an overlay, see /tmp/tmp.R14M4UGHNQ
Warning: Failed mounting /var/snap/firefox/common/host-hunspell as an overlay, see /tmp/tmp.R14M4UGHNQ
Warning: Failed mounting /var/mail as an overlay, see /tmp/tmp.R14M4UGHNQ
Warning: Failed mounting /var/www as an overlay, see /tmp/tmp.R14M4UGHNQ
Warning: Failed mounting /var/spool as an overlay, see /tmp/tmp.R14M4UGHNQ
Warning: Failed mounting /boot as an overlay, see /tmp/tmp.R14M4UGHNQ
Warning: Failed mounting /boot/efi as an overlay, see /tmp/tmp.R14M4UGHNQ
Warning: Failed mounting /boot/grub as an overlay, see /tmp/tmp.R14M4UGHNQ
Warning: Failed mounting /snap/bare/5 as an overlay, see /tmp/tmp.R14M4UGHNQ
Warning: Failed mounting /snap/core20/1891 as an overlay, see /tmp/tmp.R14M4UGHNQ
Warning: Failed mounting /snap/core20/1950 as an overlay, see /tmp/tmp.R14M4UGHNQ
Warning: Failed mounting /snap/core22/750 as an overlay, see /tmp/tmp.R14M4UGHNQ
Warning: Failed mounting /snap/core22/766 as an overlay, see /tmp/tmp.R14M4UGHNQ
Warning: Failed mounting /snap/firefox/2710 as an overlay, see /tmp/tmp.R14M4UGHNQ
Warning: Failed mounting /snap/firefox/2760 as an overlay, see /tmp/tmp.R14M4UGHNQ
Warning: Failed mounting /snap/gnome-3-38-2004/137 as an overlay, see /tmp/tmp.R14M4UGHNQ
Warning: Failed mounting /snap/gnome-3-38-2004/140 as an overlay, see /tmp/tmp.R14M4UGHNQ
Warning: Failed mounting /snap/gnome-42-2204/105 as an overlay, see /tmp/tmp.R14M4UGHNQ
Warning: Failed mounting /snap/gnome-42-2204/111 as an overlay, see /tmp/tmp.R14M4UGHNQ
Warning: Failed mounting /snap/gtk-common-themes/1535 as an overlay, see /tmp/tmp.R14M4UGHNQ
Warning: Failed mounting /snap/snap-store/638 as an overlay, see /tmp/tmp.R14M4UGHNQ
Warning: Failed mounting /snap/snap-store/959 as an overlay, see /tmp/tmp.R14M4UGHNQ
Warning: Failed mounting /snap/snapd/19361 as an overlay, see /tmp/tmp.R14M4UGHNQ
Warning: Failed mounting /snap/snapd/19457 as an overlay, see /tmp/tmp.R14M4UGHNQ
Warning: Failed mounting /snap/snapd-desktop-integration/57 as an overlay, see /tmp/tmp.R14M4UGHNQ
Warning: Failed mounting /snap/snapd-desktop-integration/83 as an overlay, see /tmp/tmp.R14M4UGHNQ
Warning: Failed mounting /tmp/.mount_desktoh3wGH2 as an overlay, see /tmp/tmp.R14M4UGHNQ
/tmp/tmp.0wS2EKl09A: line 4: cd: /tmp/try: No such file or directory

@skorokithakis I wonder if your problem is #19. Can you show us the output of findmnt -A and lsblk?

Sure:
16:47:23 $ findmnt -A
TARGET                                                                               SOURCE                               FSTYPE                      OPTIONS
/                                                                                rpool/ROOT/ubuntu_0rbgsw             zfs                         rw,relatime,xattr,posixacl
├─/sys                                                                               sysfs                                sysfs                       rw,nosuid,nodev,noexec,relatime
│ ├─/sys/kernel/security                                                             securityfs                           securityfs                  rw,nosuid,nodev,noexec,relatime
│ ├─/sys/fs/cgroup                                                                   cgroup2                              cgroup2                     rw,nosuid,nodev,noexec,relatime,nsdelegate,memory_recursiveprot
│ ├─/sys/fs/pstore                                                                   pstore                               pstore                      rw,nosuid,nodev,noexec,relatime
│ ├─/sys/firmware/efi/efivars                                                        efivarfs                             efivarfs                    rw,nosuid,nodev,noexec,relatime
│ ├─/sys/fs/bpf                                                                      bpf                                  bpf                         rw,nosuid,nodev,noexec,relatime,mode=700
│ ├─/sys/kernel/debug                                                                debugfs                              debugfs                     rw,nosuid,nodev,noexec,relatime
│ ├─/sys/kernel/tracing                                                              tracefs                              tracefs                     rw,nosuid,nodev,noexec,relatime
│ ├─/sys/fs/fuse/connections                                                         fusectl                              fusectl                     rw,nosuid,nodev,noexec,relatime
│ └─/sys/kernel/config                                                               configfs                             configfs                    rw,nosuid,nodev,noexec,relatime
├─/proc                                                                              proc                                 proc                        rw,nosuid,nodev,noexec,relatime
│ └─/proc/sys/fs/binfmt_misc                                                         systemd-1                            autofs                      rw,relatime,fd=29,pgrp=1,timeout=0,minproto=5,maxproto=5,direct,pipe_ino=23252
│   └─/proc/sys/fs/binfmt_misc                                                       binfmt_misc                          binfmt_misc                 rw,nosuid,nodev,noexec,relatime
├─/dev                                                                               udev                                 devtmpfs                    rw,nosuid,relatime,size=7951664k,nr_inodes=1987916,mode=755,inode64
│ ├─/dev/pts                                                                         devpts                               devpts                      rw,nosuid,noexec,relatime,gid=5,mode=620,ptmxmode=000
│ ├─/dev/shm                                                                         tmpfs                                tmpfs                       rw,nosuid,nodev,inode64
│ ├─/dev/hugepages                                                                   hugetlbfs                            hugetlbfs                   rw,relatime,pagesize=2M
│ └─/dev/mqueue                                                                      mqueue                               mqueue                      rw,nosuid,nodev,noexec,relatime
├─/run                                                                               tmpfs                                tmpfs                       rw,nosuid,nodev,noexec,relatime,size=1605968k,mode=755,inode64
│ ├─/run/lock                                                                        tmpfs                                tmpfs                       rw,nosuid,nodev,noexec,relatime,size=5120k,inode64
│ ├─/run/credentials/systemd-sysusers.service                                        ramfs                                ramfs                       ro,nosuid,nodev,noexec,relatime,mode=700
│ ├─/run/credentials/systemd-tmpfiles-setup-dev.service                              ramfs                                ramfs                       ro,nosuid,nodev,noexec,relatime,mode=700
│ ├─/run/credentials/systemd-sysctl.service                                          ramfs                                ramfs                       ro,nosuid,nodev,noexec,relatime,mode=700
│ ├─/run/credentials/systemd-tmpfiles-setup.service                                  ramfs                                ramfs                       ro,nosuid,nodev,noexec,relatime,mode=700
│ ├─/run/snapd/ns                                                                    tmpfs[/snapd/ns]                     tmpfs                       rw,nosuid,nodev,noexec,relatime,size=1605968k,mode=755,inode64
│ │ ├─/run/snapd/ns/firefox.mnt                                                      nsfs[mnt:[4026533041]]               nsfs                        rw
│ │ └─/run/snapd/ns/snapd-desktop-integration.mnt                                    nsfs[mnt:[4026533175]]               nsfs                        rw
│ ├─/run/user/1000                                                                   tmpfs                                tmpfs                       rw,nosuid,nodev,relatime,size=1605964k,nr_inodes=401491,mode=700,uid=1000,gid=1000,inode64
│ │ ├─/run/user/1000/gvfs                                                            gvfsd-fuse                           fuse.gvfsd-fuse             rw,nosuid,nodev,relatime,user_id=1000,group_id=1000
│ │ └─/run/user/1000/doc                                                             portal                               fuse.portal                 rw,nosuid,nodev,relatime,user_id=1000,group_id=1000
│ ├─/run/docker/netns/2ead400bd7fc                                                   nsfs[net:[4026533211]]               nsfs                        rw
│ └─/run/docker/netns/72095a979a5e                                                   nsfs[net:[4026533195]]               nsfs                        rw
├─/home/stavros                                                                      rpool/USERDATA/stavros_vnfof6        zfs                         rw,relatime,xattr,posixacl
├─/root                                                                              rpool/USERDATA/root_vnfof6           zfs                         rw,relatime,xattr,posixacl
├─/srv                                                                               rpool/ROOT/ubuntu_0rbgsw/srv         zfs                         rw,relatime,xattr,posixacl
├─/var/lib                                                                           rpool/ROOT/ubuntu_0rbgsw/var/lib     zfs                         rw,relatime,xattr,posixacl
│ ├─/var/lib/AccountsService                                                         rpool/ROOT/ubuntu_0rbgsw/var/lib/AccountsService
│ │                                                                                zfs                         rw,relatime,xattr,posixacl
│ ├─/var/lib/NetworkManager                                                          rpool/ROOT/ubuntu_0rbgsw/var/lib/NetworkManager
│ │                                                                                zfs                         rw,relatime,xattr,posixacl
│ ├─/var/lib/apt                                                                     rpool/ROOT/ubuntu_0rbgsw/var/lib/apt zfs                         rw,relatime,xattr,posixacl
│ ├─/var/lib/dpkg                                                                    rpool/ROOT/ubuntu_0rbgsw/var/lib/dpkg
│ │                                                                                zfs                         rw,relatime,xattr,posixacl
│ ├─/var/lib/docker/zfs/graph/ab70723c0d03ace2dab092988bdb726b9c7da165ef903741ed6d85d7a7489ca4
│ │                                                                                rpool/ROOT/ubuntu_0rbgsw/var/lib/ab70723c0d03ace2dab092988bdb726b9c7da165ef903741ed6d85d7a7489ca4
│ │                                                                                zfs                         rw,relatime,xattr,posixacl
│ └─/var/lib/docker/zfs/graph/c2276dcb514032531472e4f20341225fe99c0cdad1af3b87812b2789481ea9de
│                                                                                rpool/ROOT/ubuntu_0rbgsw/var/lib/c2276dcb514032531472e4f20341225fe99c0cdad1af3b87812b2789481ea9de
│                                                                                zfs                         rw,relatime,xattr,posixacl
├─/var/games                                                                         rpool/ROOT/ubuntu_0rbgsw/var/games   zfs                         rw,relatime,xattr,posixacl
├─/usr/local                                                                         rpool/ROOT/ubuntu_0rbgsw/usr/local   zfs                         rw,relatime,xattr,posixacl
├─/var/log                                                                           rpool/ROOT/ubuntu_0rbgsw/var/log     zfs                         rw,relatime,xattr,posixacl
├─/var/snap                                                                          rpool/ROOT/ubuntu_0rbgsw/var/snap    zfs                         rw,relatime,xattr,posixacl
│ └─/var/snap/firefox/common/host-hunspell                                           rpool/ROOT/ubuntu_0rbgsw[/usr/share/hunspell]
│                                                                                zfs                         ro,noexec,noatime,xattr,posixacl
├─/var/mail                                                                          rpool/ROOT/ubuntu_0rbgsw/var/mail    zfs                         rw,relatime,xattr,posixacl
├─/var/www                                                                           rpool/ROOT/ubuntu_0rbgsw/var/www     zfs                         rw,relatime,xattr,posixacl
├─/var/spool                                                                         rpool/ROOT/ubuntu_0rbgsw/var/spool   zfs                         rw,relatime,xattr,posixacl
├─/boot                                                                              bpool/BOOT/ubuntu_0rbgsw             zfs                         rw,nodev,relatime,xattr,posixacl
│ ├─/boot/efi                                                                        /dev/nvme0n1p1                       vfat                        rw,relatime,fmask=0022,dmask=0022,codepage=437,iocharset=iso8859-1,shortname=mixed,errors=remount-ro
│ └─/boot/grub                                                                       /dev/nvme0n1p1[/grub]                vfat                        rw,relatime,fmask=0022,dmask=0022,codepage=437,iocharset=iso8859-1,shortname=mixed,errors=remount-ro
├─/snap/bare/5                                                                       /dev/loop0                           squashfs                    ro,nodev,relatime,errors=continue,threads=single
├─/snap/core20/1891                                                                  /dev/loop1                           squashfs                    ro,nodev,relatime,errors=continue,threads=single
├─/snap/core20/1950                                                                  /dev/loop2                           squashfs                    ro,nodev,relatime,errors=continue,threads=single
├─/snap/core22/750                                                                   /dev/loop3                           squashfs                    ro,nodev,relatime,errors=continue,threads=single
├─/snap/core22/766                                                                   /dev/loop4                           squashfs                    ro,nodev,relatime,errors=continue,threads=single
├─/snap/firefox/2710                                                                 /dev/loop5                           squashfs                    ro,nodev,relatime,errors=continue,threads=single
├─/snap/firefox/2760                                                                 /dev/loop6                           squashfs                    ro,nodev,relatime,errors=continue,threads=single
├─/snap/gnome-3-38-2004/137                                                          /dev/loop7                           squashfs                    ro,nodev,relatime,errors=continue,threads=single
├─/snap/gnome-3-38-2004/140                                                          /dev/loop8                           squashfs                    ro,nodev,relatime,errors=continue,threads=single
├─/snap/gnome-42-2204/105                                                            /dev/loop9                           squashfs                    ro,nodev,relatime,errors=continue,threads=single
├─/snap/gnome-42-2204/111                                                            /dev/loop10                          squashfs                    ro,nodev,relatime,errors=continue,threads=single
├─/snap/gtk-common-themes/1535                                                       /dev/loop11                          squashfs                    ro,nodev,relatime,errors=continue,threads=single
├─/snap/snap-store/638                                                               /dev/loop12                          squashfs                    ro,nodev,relatime,errors=continue,threads=single
├─/snap/snap-store/959                                                               /dev/loop13                          squashfs                    ro,nodev,relatime,errors=continue,threads=single
├─/snap/snapd/19361                                                                  /dev/loop14                          squashfs                    ro,nodev,relatime,errors=continue,threads=single
├─/snap/snapd/19457                                                                  /dev/loop15                          squashfs                    ro,nodev,relatime,errors=continue,threads=single
├─/snap/snapd-desktop-integration/57                                                 /dev/loop16                          squashfs                    ro,nodev,relatime,errors=continue,threads=single
├─/snap/snapd-desktop-integration/83                                                 /dev/loop17                          squashfs                    ro,nodev,relatime,errors=continue,threads=single
└─/tmp/.mount_desktoysblPB                                                           desktop-3.6.0.AppImage               fuse.desktop-3.6.0.AppImage ro,nosuid,nodev,relatime,user_id=1000,group_id=1000

16:47:27 $ lsblk
NAME        MAJ:MIN RM   SIZE RO TYPE MOUNTPOINTS
loop0         7:0    0     4K  1 loop /snap/bare/5
loop1         7:1    0  63,5M  1 loop /snap/core20/1891
loop2         7:2    0  63,4M  1 loop /snap/core20/1950
loop3         7:3    0  73,8M  1 loop /snap/core22/750
loop4         7:4    0  73,9M  1 loop /snap/core22/766
loop5         7:5    0 242,9M  1 loop /snap/firefox/2710
loop6         7:6    0 244,8M  1 loop /snap/firefox/2760
loop7         7:7    0 349,7M  1 loop /snap/gnome-3-38-2004/137
loop8         7:8    0 349,7M  1 loop /snap/gnome-3-38-2004/140
loop9         7:9    0 460,7M  1 loop /snap/gnome-42-2204/105
loop10        7:10   0 466,5M  1 loop /snap/gnome-42-2204/111
loop11        7:11   0  91,7M  1 loop /snap/gtk-common-themes/1535
loop12        7:12   0  45,9M  1 loop /snap/snap-store/638
loop13        7:13   0  12,3M  1 loop /snap/snap-store/959
loop14        7:14   0  53,3M  1 loop /snap/snapd/19361
loop15        7:15   0  53,3M  1 loop /snap/snapd/19457
loop16        7:16   0   428K  1 loop /snap/snapd-desktop-integration/57
loop17        7:17   0   452K  1 loop /snap/snapd-desktop-integration/83
nvme0n1     259:0    0 931,5G  0 disk
├─nvme0n1p1 259:1    0   512M  0 part /boot/grub
│                                     /boot/efi
├─nvme0n1p2 259:2    0     2G  0 part [SWAP]
├─nvme0n1p3 259:3    0     2G  0 part
└─nvme0n1p4 259:4    0   927G  0 part

Okay, I think your issue is indeed #19.

I agree, does it work if you unmount /tmp/.mount_desktoysblPB ? @skorokithakis

It does not:
20:17:24 $ sudo umount -f /tmp/.mount_deskto3rbIlV
umount: /tmp/.mount_deskto3rbIlV: target is busy.

20:17:34 $ sudo umount -fl /tmp/.mount_deskto3rbIlV

stavros@talos:~ (master|✚4)
20:17:46 $ try pip3 install libdash
Warning: Failed mounting /home as an overlay, see /tmp/tmp.CLH0bJRRum
Warning: Failed mounting /snap as an overlay, see /tmp/tmp.CLH0bJRRum
Warning: Failed mounting /usr as an overlay, see /tmp/tmp.CLH0bJRRum
Warning: Failed mounting /var as an overlay, see /tmp/tmp.CLH0bJRRum
Warning: Failed mounting /run/user/1000/doc as an overlay, see /tmp/tmp.CLH0bJRRum
Warning: Failed mounting /home/stavros as an overlay, see /tmp/tmp.CLH0bJRRum
Warning: Failed mounting /var/lib as an overlay, see /tmp/tmp.CLH0bJRRum
Warning: Failed mounting /var/lib/AccountsService as an overlay, see /tmp/tmp.CLH0bJRRum
Warning: Failed mounting /var/lib/NetworkManager as an overlay, see /tmp/tmp.CLH0bJRRum
Warning: Failed mounting /var/lib/apt as an overlay, see /tmp/tmp.CLH0bJRRum
Warning: Failed mounting /var/lib/dpkg as an overlay, see /tmp/tmp.CLH0bJRRum
Warning: Failed mounting /var/lib/docker/zfs/graph/ab70723c0d03ace2dab092988bdb726b9c7da165ef903741ed6d85d7a7489ca4 as an overlay, see /tmp/tmp.CLH0bJRRum
Warning: Failed mounting /var/lib/docker/zfs/graph/c2276dcb514032531472e4f20341225fe99c0cdad1af3b87812b2789481ea9de as an overlay, see /tmp/tmp.CLH0bJRRum
Warning: Failed mounting /var/games as an overlay, see /tmp/tmp.CLH0bJRRum
Warning: Failed mounting /usr/local as an overlay, see /tmp/tmp.CLH0bJRRum
Warning: Failed mounting /var/log as an overlay, see /tmp/tmp.CLH0bJRRum
Warning: Failed mounting /var/mail as an overlay, see /tmp/tmp.CLH0bJRRum
Warning: Failed mounting /var/snap as an overlay, see /tmp/tmp.CLH0bJRRum
Warning: Failed mounting /var/snap/firefox/common/host-hunspell as an overlay, see /tmp/tmp.CLH0bJRRum
Warning: Failed mounting /var/spool as an overlay, see /tmp/tmp.CLH0bJRRum
Warning: Failed mounting /var/www as an overlay, see /tmp/tmp.CLH0bJRRum
Warning: Failed mounting /boot as an overlay, see /tmp/tmp.CLH0bJRRum
Warning: Failed mounting /boot/efi as an overlay, see /tmp/tmp.CLH0bJRRum
Warning: Failed mounting /boot/grub as an overlay, see /tmp/tmp.CLH0bJRRum
Warning: Failed mounting /snap/bare/5 as an overlay, see /tmp/tmp.CLH0bJRRum
Warning: Failed mounting /snap/core20/1891 as an overlay, see /tmp/tmp.CLH0bJRRum
Warning: Failed mounting /snap/core20/1950 as an overlay, see /tmp/tmp.CLH0bJRRum
Warning: Failed mounting /snap/core22/750 as an overlay, see /tmp/tmp.CLH0bJRRum
Warning: Failed mounting /snap/core22/766 as an overlay, see /tmp/tmp.CLH0bJRRum
Warning: Failed mounting /snap/firefox/2710 as an overlay, see /tmp/tmp.CLH0bJRRum
Warning: Failed mounting /snap/firefox/2760 as an overlay, see /tmp/tmp.CLH0bJRRum
Warning: Failed mounting /snap/gnome-3-38-2004/137 as an overlay, see /tmp/tmp.CLH0bJRRum
Warning: Failed mounting /snap/gnome-3-38-2004/140 as an overlay, see /tmp/tmp.CLH0bJRRum
Warning: Failed mounting /snap/gnome-42-2204/105 as an overlay, see /tmp/tmp.CLH0bJRRum
Warning: Failed mounting /snap/gnome-42-2204/111 as an overlay, see /tmp/tmp.CLH0bJRRum
Warning: Failed mounting /snap/gtk-common-themes/1535 as an overlay, see /tmp/tmp.CLH0bJRRum
Warning: Failed mounting /snap/snap-store/638 as an overlay, see /tmp/tmp.CLH0bJRRum
Warning: Failed mounting /snap/snap-store/959 as an overlay, see /tmp/tmp.CLH0bJRRum
Warning: Failed mounting /snap/snapd/19361 as an overlay, see /tmp/tmp.CLH0bJRRum
Warning: Failed mounting /snap/snapd/19457 as an overlay, see /tmp/tmp.CLH0bJRRum
Warning: Failed mounting /snap/snapd-desktop-integration/57 as an overlay, see /tmp/tmp.CLH0bJRRum
Warning: Failed mounting /snap/snapd-desktop-integration/83 as an overlay, see /tmp/tmp.CLH0bJRRum
/tmp/tmp.HKiE92wdmR: line 4: cd: /home/stavros: No such file or directory

Old error: /tmp/tmp.0wS2EKl09A: line 4: cd: /tmp/try: No such file or directory
New error: /tmp/tmp.HKiE92wdmR: line 4: cd: /home/stavros: No such file or directory
What happens if you try running try in temp again? Now it is failing because /home/stavros is nested.
Also, could you try with branch nested-mount (need to install mergerfs) (and running from your home dir)
If you don't like mergerfs, you can install unionfs-fuse and change the two appearances of mergerfs to unionfs (L70, L83)

Should be addressed by #67


Bumped runtime for heroku.

Python has released a security update! Please consider upgrading to python-3.7.6
Learn More: https://devcenter.heroku.com/articles/python-runtimes

Thanks!


Roles not showing in Roles Grid and throwing the Error.

Bug report
What happened
Roles not showing in Roles Grid and throwing the Error. Please check the attached screenshot.

Is it a bug in the latest version of Backpack?
Yes
Backpack, Laravel, PHP, DB version
PHP VERSION:
PHP 8.1.10 (cli) (built: Aug 30 2022 18:05:49) (ZTS Visual C++ 2019 x64)
Copyright (c) The PHP Group
Zend Engine v4.1.10, Copyright (c) Zend Technologies
LARAVEL VERSION:
v9.42.2@607d7867c93706eae20e28e46679f8a66e2a23ec
BACKPACK VERSION:
5.4.10@050b288caf2f60c79313f2b0b7d4fefd25177f3f

Hello @mikdanjey thanks for the report.
We already merged the fix for it, we will tag a new version later this evening with some additional fixes.
You can check the release draft here: https://github.com/Laravel-Backpack/CRUD/releases/tag/untagged-3a70596c3dc83da70a8f
When that version is tagged, that bug will be fixed, so in a few hours a composer update backpack/crud will pull the fix for you.
Going to close this, wish you all the best 🎅

Thanks for fixed this in your side. I understood not released so far.
FYI, I can't see your tag link:
https://github.com/Laravel-Backpack/CRUD/releases/tag/untagged-3a70596c3dc83da70a8f

What you mean you can't see the tag link ? Does the release link I provided don't work for you ? Maybe because it's not released it's only accessible to maintainers? Sorry I didn't know about that. 😞
Here is a screenshot of it:

It will be released in a few hours, if you subscribe to repository notifications you will be notified when we do it 👍
Let me know if I can help you with something else, cheers!

Great Thanks, Looks fine. I got it this draft version.
Closing this bug :)


Fix type definition for the import/no-unresolved rule

The code:
'import/no-unresolved': ['error', { ignore: ['\\.(css|scss|sass|less)$'] }]
Previously, this rule would give a TypeScript error: Type '{ ignore: string[]; }' is not assignable to type 'number'.
But it is the correct form for the no-unresolved rule: https://github.com/import-js/eslint-plugin-import/blob/main/docs/rules/no-unresolved.md
This fixes that by removing the extra number definition in the rules array (I think this was meant to be the RuleSeverity, but that's already handled in the RuleConfig for this rule)

Oh I found out that I didn't generate the rules for import 😬
I did that now... https://github.com/Shinigami92/eslint-define-config/commit/e49956c78cae596b1c32c3b50dd647c88d0d3369
Could you rebase your PR and check it, if your update is still needed?
If so, maybe we need to update the meta section in eslint-plugin no-unresolved.js#L18

Ah yeah, I fixed the conflict and now there are no changes at all anymore. So I will close this and make a release soon.
But thanks 👍


Mainnet Playground: Mnemonics field is not accepting TF Chain secret (Hex)

"I already have a deployment on my account. And If I remember correctly, I used the hex TFChain to create that deployment.
I had to reinstall my OS. I'm trying to re-login to the deployment window, and this time it wouldn't accept my Hex TFChain secret" - Crisp user: Roeljamil /<EMAIL_ADDRESS>
Additionally, Scott also assisted by testing his hex secret, and it appears to have not gone through as well:

The main issue with this @scottyeager is you can't get the mnemonic from the hex seed, which we use -them menmonic- to encrypt the user's metadata information (info about deployments), so if the user uses the hex seed -while that got supported in https://github.com/threefoldtech/tfgrid-sdk-ts/issues/8- we will the user to provide both the seed and the mnemomics to decrypt previously stored metadata and renecrypt on the chain using that seed and reintroduce another migration

#8


Subparser command name is not constrained by Literal type definition

There is a nice example for using Literal[] typing for arguments (https://github.com/bluenote10/typed_argparse#convenience-functionality-to-map-literalenum-to-choices) but there does not appear to be a similar approach for subparser command definitions.
Would it be possible to add something similar in this module?
Conceptually I'm thinking of something similar to the choices approach, only for the subparser, e.g. something like:
subparsers = parser.add_subparsers(
        help="Available sub commands",
        dest="mode",
        required=True,
        choices=MyArgs.get_choices_from("mode"),
    )

If the project had the approach shown in https://github.com/bluenote10/typed_argparse#support-for-union-useful-for-subcommand-parsing, then perhaps you'd need a union of the different mode definitions.
Alternately it would be nice if validate() could catch cases where the Literal[...] definition did not match the argument passed to subparsers.add_parser().
This module has been very helpful, thanks for making it available!

Doesn't that already work? As far as I can see argparse doesn't infer the "choices" from an argument passed into add_subparsers but rather from the first arguments passed to subparsers.add_parser. To give a full example:
import argparse
import sys
from typing import List, Literal, Union

from typed_argparse import TypedArgs, WithUnionType

class CommonArgs(TypedArgs):
    verbose: bool

class ArgsFoo(CommonArgs):
    mode: Literal["foo"]
    file: str

class ArgsBar(CommonArgs):
    mode: Literal["bar"]
    src: str
    dst: str

Args = Union[ArgsFoo, ArgsBar]

def parse_args(args: List[str] = sys.argv[1:]) -> Args:
    parser = argparse.ArgumentParser()
    parser.add_argument("--verbose", action="store_true", help="Verbose")
    subparsers = parser.add_subparsers(
        help="Available sub commands",
        dest="mode",
        required=True,
    )

    parser_foo = subparsers.add_parser("foo")
    parser_foo.add_argument("file", type=str)

    parser_bar = subparsers.add_parser("bar")
    parser_bar.add_argument("--src", required=True)
    parser_bar.add_argument("--dst", required=True)

    return WithUnionType[Args].validate(parser.parse_args(args))

if __name__ == "__main__":
    parse_args()

Behaves as follows:

There is just the minor redundancy that subparsers.add_parser has to duplicate the value from the Literal. It might be possible to come up with a helper function that allows to reference the type + the field to get to the literal value. Something like subparsers.add_parser(get_literal_value_of(Foo, "mode")). Is that what you are looking for?

To that end, something like you suggested would help, though to be honest there are a number of other minor redundancies (like property names matching add_argument() calls) that I'm not sure it's really necessary.

That's also my impression. I'll leave the issue open as a reminder just in case I come across an elegant idea...

The main thing I was looking for was a failsafe against typos in validate(), and it is already there! Sorry for the false alarm :)

No worries!

I'd close this assuming the issue has been resolved? Feel free to re-open / ask more if needed.


Migrate GH App config from github-app to github_app

Dashes don't play well with protobuf, let's migrate the github-app key to github_app. Since the config was always empty and the enrolling client didn't set it this should be still quite safe.

No longer needed


Add version: WinDirStat.WinDirStat.Beta version <IP_ADDRESS>4-10-12

Pull request has been created with komac v2.6.0 :rocket:
Microsoft Reviewers: Open in CodeFlow

Hi @assarbad,
This manifest adds a DisplayVersion to the AppsAndFeaturesEntries that isn't present in previous manifest versions. This entry should be added to the previous versions, or removed from this version.
(Automated response - build 896.)

Superseded by #182771


checkpoint: Add the missing options

Add the missing command-line options as documented for runc: https://github.com/opencontainers/runc/blob/main/man/runc-checkpoint.8.md
(This does not mean that they are necessarily implemented)
@adrianreber In case you need to sync the options for this command.

@adrianreber For context, this is part of the work I am doing on ociplex, and attempt to restore podman compatibility for Kata Containers using Youki as an in-between, see https://github.com/c3d/youki/tree/ociplex.

Not sure this is a good idea. Podman tries to figure out certain features of crun and runc by parsing the help output. The expectation is, that if it is listed in the help output it is supported.
In the case of youki it is not really important as checkpoint is still hidden behind checkpointt.

Not sure this is a good idea. Podman tries to figure out certain features of crun and runc by parsing the help output. The expectation is, that if it is listed in the help output it is supported.
In the case of youki it is not really important as checkpoint is still hidden behind checkpointt.

I was not aware of this behaviour of podman. That's weird 😄 . Well, I need these changes on my branch, feel free to pick them up if/when you implement that. I'll also figure out a way to have this be different for ociplex and youki.

Not sure this is a good idea. Podman tries to figure out certain features of crun and runc by parsing the help output. The expectation is, that if it is listed in the help output it is supported.
In the case of youki it is not really important as checkpoint is still hidden behind checkpointt.

I was not aware of this behaviour of podman. That's weird smile . Well, I need these changes on my branch, feel free to pick them up if/when you implement that. I'll also figure out a way to have this be different for ociplex and youki.

It is only during restore: https://github.com/containers/podman/blob/main/pkg/checkpoint/crutils/checkpoint_restore_utils.go#L229

@adrianreber OK, I understand your constraints. In any case, the changes in this PR are not for immediate consumption. It's more "If you need to implement this or that option, feel free to grab it from this branch". I will try to maintain two parallel branches:

The oci-changes branch, where I'll try to keep only the OCI command-line interface changes

The ociplex branch where we are developing an OCI multiplexer that leverages youki's command-line parsing, the primary goal being to build a bridge between podman and shimv2-only runtimes like Kata Containers v2 and later.

I'll try to reorder and cleanup the commits in these branches to rebase ociplex on oci-changes. In case there is no negative impact of adding the missing options. It's really your call if and when you want to do that.

Codecov Report

Merging #1613 (43bbdfb) into main (74a499f) will decrease coverage by 0.11%.
The diff coverage is 0.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1613      +/-   ##
==========================================
- Coverage   68.83%   68.73%   -0.11%
==========================================
  Files         120      120
  Lines       13109    13135      +26
==========================================
+ Hits         9024     9028       +4
- Misses       4085     4107      +22

Not sure this is a good idea. Podman tries to figure out certain features of crun and runc by parsing the help output. The expectation is, that if it is listed in the help output it is supported.
In the case of youki it is not really important as checkpoint is still hidden behind checkpointt.

BTW, podman should use the feature command to verify the futures of the oci runtimes
https://github.com/opencontainers/runtime-spec/pull/1130

On 7 Mar 2023, at 03:36, Toru Komatsu @.***> wrote:
Not sure this is a good idea. Podman tries to figure out certain features of crun and runc by parsing the help output. The expectation is, that if it is listed in the help output it is supported.
In the case of youki it is not really important as checkpoint is still hidden behind checkpointt.
BTW, podman should use the feature command to verify the futures of the oci runtimes
opencontainers/runtime-spec#1130

Interesting. I was not aware of this command, and it’s not implemented in Youki yet, but it's tracked.
https://github.com/containers/youki/issues/815

@utam0k Not an inconvenience at all. Thanks for pointing that out, I'll work on it.

Given this PR is stale for more than a year, I will close this. Please re-open when needed.


Api port should be exposed by default.

As a new user I just edit compose file and bring up a container. But unfortunately forget about exposing api port in docker compose. That's why I faced with ssl error when trying to connect to api.
Should be added at:
https://github.com/cdalvaro/docker-salt-master/blob/581808b8fa059b56ad7b0bb8a58ea95c7f202c0f/docker-compose.yml#L12
Of course it can be added as commented row, because it is not enabled by default. But  I think it should be. That's just an example.
@cdalvaro what do you think about this ?

Hi @vskubriev,
Thank you for reporting this!
I see right adding the salt-api port to the docker-compose.yml, but commented.
As you've said, since the service is not enabled by default, it could be confusing to open the port but leave the service disabled.
So I'll update the docker-compose.yml with the salt-api settings commented. This way anyone who wants to enable the service will only have to uncomment those lines and set the password.
I will also update REAMDE.md and Wiki to help other people with this!
Thank you again for your time and help!


make is failing

Hello, make command is failing with following message:
======================================================================
FAIL: test_version (test_views.test_misc.TestMisc)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/root/envs/modernpaste/modern-paste/tests/test_views/test_misc.py", line 53, in test_version
    self.assertIn('modern-paste.git', version_string[3])  # You might need to change this if the project is renamed
AssertionError: 'modern-paste.git' not found in 'https://github.com/LINKIWI/modern-paste'

Could you please tell me what might be wrong here or is it a bug?

This is a known bug. The unit test checks that the /version URI correctly prints git details, but will fail if you cloned the repository without the .git extension.
A temporary workaround is to change the remote URL to include modern-paste.git rather than modern-paste. From the repository directory, run
git remote set-url https://github.com/LINKIWI/modern-paste.git
Thanks for the report.

The unit test will now pass even for different remote URLs.


Firestore DocumentReference.delete

Tested on iOS simulator.
Having some issues with running Android Emulator atm, will update when I get any results.
PTAL.
Fixes flutter/flutter#12802

Tested in Android Emulator.

One thing I noticed in both iOS and Android: deleting a document while subscribed to a query in the same collection results in two DocumentChanges:

DocumentChangeType.added (bad)
DocumentChangeType.removed

Deleting a document using Firebase Console results in only  removed change. Not sure yet why it behaves this way...

Wondering who should I tag to get this reviewed/approved. :)
@collinjackson ...?
The extra change event seems to unrelated to the delete itself and should be investigated separately.

Closing this in favor of #258.


Btabs abd Btab are not working.

I have been using BTabs and BTab previously. Not it has stopped working.
I downgraded to 0.1.10 version but still the same.

Do you have a minimal reproduction project?
I've also been using BTabs without any issue until 0.1.14
Are you sure your bootstrap-vue-3 in  package-lock.json is below 0.1.14?

Here is the screenshot:

That's running 0.1.14 as you can see on line 3906, revert back to 0.1.13 or use the latest from GitHub

Please close the issue

Downgraded to 0.1.13 and issue resolved.


ReferenceError: SKIP_RE is not defined  - Does not work with Ecma 6.0…

… since it is enabled in GAS

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.radzisz seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.

Thanks for the PR!
Please pass the CLA check then I'll be able to merge this PR.
Appreciate it.

@radzisz looking forward to you signing the CLA and getting this pull request approved 😄. I'm currently having to point my gast at your forked repo, otherwise all errors thrown are of this SKIP_RE form and frustratingly opaque.

Merge to #24


Adding Html as a dependency results in error.

When I add the swift-html package as a dependency I get the following error:
product dependency 'Html' in package 'swift-html' not found
Not sure what to do here, have the feeling it has to do with tools versioning could that be?
package dependency looks as follows:
.package(url: "https://github.com/pointfreeco/swift-html.git", from: "0.3.1"),
target dependency: (needed for 5.2)
.product(name: "Html", package: "swift-html"),

SPM changed their conventions with 5.2+, which makes things a lil confusing. The swift-html package is named Html, so I think you need to specify the product and package to be the same here:
.product(name: "Html", package: "Html"),

I think that should get things working, though you may also need to add name to the package directive.
We should really change things, though, in the future to use swift-html as the package name.

SPM changed their conventions with 5.2+, which makes things a lil confusing. The swift-html package is named Html, so I think you need to specify the product and package to be the same here:
.product(name: "Html", package: "Html"),

I think that should get things working, though you may also need to add name to the package directive.
We should really change things, though, in the future to use swift-html as the package name.

I was using that, but got it working by also adding a name property to the package dependency itself:
.package(name: "Html", url: "https://github.com/etc", from: "0.3.1")
Might be worth adding to the readme! (the name addition wouldn't be necessary if the package name and gh url slug match, so `name: "swift-html")
I was trying to use Html with vapor 4, got it working so I'll make a PR with an example of the above in a minute :)

I was using that, but got it working by also adding a name property to the package dependency itself:
.package(name: "Html", url: "https://github.com/etc", from: "0.3.1")
Might be worth adding to the readme! (the name addition wouldn't be necessary if the package name and gh url slug match, so `name: "swift-html")
I was trying to use Html with vapor 4, got it working so I'll make a PR with an example of the above in a minute :)

I only just realised that this is exactly what you're describing in the last two lines of your response, apologies 😅

I only just realised that this is exactly what you're describing in the last two lines of your response, apologies 😅


Fixed AtPathResolver to deal with complex objects correctly

Fixes #1770
Description

Fixed AtPathResolver to deal with complex objects correctly
Specific Changes

Adjusted transformPath method in AtPathResolver to resolve path correctly

Testing

Unit tests covered.

Pull Request Test Coverage Report for Build 120648

15 of 15 (100.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.03%) to 67.327%

Totals

Change from base Build 119935:
0.03%

Covered Lines:
10334

Relevant Lines:
14527

💛  - Coveralls


Release bug fixes

Releases the following

removes CTA
onboard issues with wallet connect
zindex scrolling bug

Operations is confirming the fixes in the cloudflare deployment before we merge to prod


Remove the general options related to native libraries

CppSharp has had settings such as Options.Headers, Options.Libraries and others from the very beginning. However, they reflect its past limitation of only being able to produce one binding per run. With the Module class which we've had for quite some time now, this is no longer true. Therefore it should remain the only way of specifying settings of libraries to wrap.
We should also update any parts of our documentation which talk about these options to remove.

Those settings have been marked as obsolete, in two months they must be deleted.


Priority feature

For specific developments with Bluetooth Low Energy, I need to activate location, but I don't need it to be PRIORITY_HIGH_ACCURACY. It could be nice if we can pass a priority param

PRIORITY_BALANCED_POWER_ACCURACY
PRIORITY_HIGH_ACCURACY
PRIORITY_LOW_POWER
PRIORITY_NO_POWER

This feature is only for android 8.1 and less (https://support.google.com/accounts/answer/3467281?hl=en)

Why not, I will try this asap.


[microsoft/release-branch.go1.22] Update 1.22 release notes

Update the release notes for 1.22.0.
I wrote an initial draft, but @qmuntal PTAL and go ahead and push any changes you have in mind. 🙂 E.g. I'm not sure if we should maybe call out whether each new algorithm is FIPS-compliant or not.

Depends on https://github.com/microsoft/go/pull/1127

I'm not sure if we should maybe call out whether each new algorithm is FIPS-compliant or not.

IMO it is not necessary. You are called it out with the following sentence:

Not every algorithm implemented by a crypto backend is necessarily allowed in a FIPS-compliant program.


V1.x

I have updated the angular 4 to angular 6 in the source code. But there is build error in lib\services\search.service.ts. I have commented on the error code and I was able to build the code properly. It seems everything works properly. Please, can you review the code and give feedback to me. I need angular6 support for my new project
I think,  I dont have permission push code this branch

You opened a PR to merge 1.x branch to master without your changes.
In order to propose your changes, you should fork the repository first.
See the guide: https://akrabat.com/the-beginners-guide-to-contributing-to-a-github-project/

I've followed following guide line every time i receive this message "remote: Permission to Rebilly/ReDoc.git denied to wageeshwara.  "

No, you haven't. You even haven't completed Step 1. I don't see fork of ReDoc in your repo.

Step 1: Set up a working copy on your computer
Firstly you need a local fork of the the project, so go ahead and press the “fork” button in GitHub. This will create a copy of the repository in your own GitHub account and you’ll see a note that it’s been forked underneath the project name:
Forked
Now you need a copy locally, so find the “SSH clone URL” in the right hand column and use that to clone locally using a terminal:
git clone git@github.com:wageeshwara/ReDoc.git

Note that you have to clone YOUR OWN COPY of repository wageeshwara/ReDoc and not Ribilly/ReDoc

Really sorry to bother you. Thank you for giving the correct guidance. So I have followed the procedure correctly and made a pr. If you can review and give feedback that would be great.

@RomanGotsiy Great, Thanks!


CMake Compiled source code appears：error: could not find git for clone of libusb

Computer Networking

2.CMake3.13

Download：https://github.com/IntelRealSense/librealsense/tree/master/wrappers/opencv

@honghande ,
Building librealsense with defaults requires git being installed. This is one of the BUILD_WITH_TM2
CMake's option prerequisites.
You can either install git, or unselect that option in order to proceed.
See #2719  for details.

Thank you, yes, I installed git, now I can make Cmake, but I also tried not to choose BUILD_WITH_TM2 is still invalid, so the best way is to install git.

@ev-mp Thank you, yes, I installed git, now I can make Cmake, but I also tried not to choose BUILD_WITH_TM2 is still invalid, so the best way is to install git.


Egg Hatching

Short Description:
Added egg hatching as suggested in #97
Changes:

added USE_ITEM_EGG_INCUBATOR method to new api wrapper
created incubator object
new config option fill_incubators allows incubators filled with new eggs
dirty little message on success in GET_HATCHED_EGGS

@OpenPoGo/maintainers

There should be an option to only use the unlimited incubator.

👍 Looks good to me.

Please add --fill-incubators (and -fi) to the cli args, and update the README accordingly. Other then that great work!

done

:+1: awesome! @wchill if you could review this with the new changes as well that'd be great


feat: Emit event if stream was closed or read buffer overflowed

Currently we ignore there result of read_buf. For example:
let crlf_result = match find_crlf(&self.read_buffer[self.seen_bytes..], self.crlf_relaxed) {
    Some(crlf_result) => crlf_result,
    None => {
        // No full line received yet, more data needed.
        stream.0.read_buf(&mut self.read_buffer).await?;
        return Ok(None);
    }
};

But according to the documentation of read_buf the result value 0 has a special meaning:

If n is 0, then it can indicate one of two scenarios:

This reader has reached its “end of file” and will likely no longer be able to produce bytes. Note that this does not mean that the reader will always no longer be able to produce bytes.
The buffer specified had a remaining capacity of zero.

I think we need to handle both cases by doing this:

If the buffer is not full yet and read_buf returns 0, then we need to emit {Client,Server}FlowEvent::StreamClosed.
If the buffer is full and it does not contain a complete IMAP message, then we need to emit {Client,Server}FlowEvent::ReadBufferOverflowed.

Fixes #79

Sounds reasonable :+1: Even better: I think there are/were some TODOs in imap-flow (or maybe on some unmerged branch) that complain about the missing StreamClosed event. So... freeing two birds with one key!

I've created #87 for the bufferoverflow issue.


Add Django Rest Framework Mixins for Viewset / ListAPIView

The DRF documentation is confusing. Can you provide a full example for "Simple Model", implementing DRF ListView?

Hi. I just add MVTRenderer in code and example in documentation (master).
I will release that later


ErrorException  : Array to string conversion

Getting this error when trying to use @version.
I have set git-local as commit mode.
commit:
mode: git-local
How to fix this error?

The default config/version.yml will work fine with git commits once you publish the version ServiceProvider.
Here are the steps I used:

You might need to update git.version.local to be describe --tags flag ( see Issue #71 ) in config/version.yml (this is the only change needed). Try this if you get the GitTagNotFound exception.

Create a tag in the standard format (e.g. 1.0.0).

git tag 1.0.0 f8a69aef9b9852eca1073148cc228209b073c96e

Absorb the commit through the tag

php artisan version:absorb


Command line argument parsing

#18
Implement command line argument read.

Fixing time allocation.
Sprint 2.
{t:30}


.drone.yaml: better go test command

Should fix e2e testing

not necessary anymore, as it seems to have landed in our main branch.


enh: better playground

#2000

Hi. Can you consider moving the workspace button next to the playground button? To me the workspace should not be much more accessible than the settings or playground and I'd rather see my chat list.


WebGL use case: streaming lots of geometries in real-time

Not a feature or a bug report.
It's more a discussion about what could be done in the future with WebGL for that kind of use case.
The use case in question.
Around 100K geometries have to be represented on the map.
Each of those geometry will update at most every few seconds and will be pushed toward Openlayers via Websocket for example.
As of right now, this would mean that every time a feature is updated, Openlayers has to rebuild the shaders' buffers for WebGL.
The performance would therefore be atrocious.
We can imagine that tiling capability for WebGL could enhance this. In that case, multiple buffers may exist (?) for the different tile.
But then, everytime a highly populated tile is updated this would mean a slow down.
Alternatively, we could split the geometries not with tiles but by grouping them every X geometries without considering their positions.
For example, every 1K geometries, would have their own WebGL buffer.
Here the number of geometry to group by should be choose carefully. Too large, and there is a high chance that a geometry updates, and updates at the same time the whole buffer. Too little, and I guess, this would cause memory issue, or some other weirdness, as there would be too many GPU programs running at the same time (just a guess here).
What is your take on that ?
How would you approach this problem ?
Could Openlayers propose some solution for that kind of use case in the future ?

Technically nothing prevents us from updating only parts of the vertex buffers in webgl. There are some things to consider though:

currently we're only dealing with points; eventually we might have geometries with variable amount of coordinates, so having one huge buffer with all geometries inside might not be the most future-proof choice
listening on changes on individual features will definitely be too costly

The most logical approach would be to group features by some criteria (maybe just order of appearance?) and use separate buffers for each group of features. Then, when a feature gets updated, the buffers for the whole group can be rebuilt.
An option could be offered in the API to favor either frequent updates and high rendering time (small groups), infrequent updates and low rendering times (large groups) or balanced.

currently we're only dealing with points; eventually we might have geometries with variable amount of coordinates, so having one huge buffer with all geometries inside might not be the most future-proof choice

If I understand correctly, knowing the number of coordinates for features in the buffer is a must-be to be able to update part of the buffer easily.
Then another grouping possibilities might be to group geometries by number of coordinates.

The most logical approach would be to group features by some criteria (maybe just order of appearance?) and use separate buffers for each group of features. Then, when a feature gets updated, the buffers for the whole group can be rebuilt.

This is indeed easy to understand how this would work.
However, this approach would always be sub-optimal. You will always do some unneeded work whenever you update a buffer.
And if the geometry updates are spread evenly among groups at any time, the performance gain might be small (or you'd need to use very small group size)

Also if the features are grouped by proximity, a basic culling operation can be done to avoid drawing out of view groups for free. But this comes at the cost of added complexity when a feature geometry is changed (which might switch groups).

This would only makes sense for very large dataset (1M+ geometries) where you expect performance drop when all geometries are in view.
Even though reducing impact on ressource usage is always good, I'd say this would be a niche use case as this would imply the worst case scenario has bad performance.

If I understand correctly, knowing the number of coordinates for features in the buffer is a must-be to be able to update part of the buffer easily.

Also, the amount of coordinates in a geometry can change. And we cannot add/remove numbers in a buffer like we would in a regular array. So there would be two cases:

some vertices in a geometry are updated; this can be done without rebuilding the whole buffer
a geometry gains or lose vertices (ie when drawing a polygon, or adding/removing to a geometry collection); this requires a full rebuild

This way having moving points in a large dataset (which is a common usecase) could be quite fast, provided it's not multi points.

Being able to stream geometries that gain/lose vertices fast could opens interesting possibilities.
If we had different buffer for each n-vertices geometries, updating or adding a geometry is not hard, if I understand well, and those operations do not require a full rebuild.
Only deleting requires the full rebuild, because then, you have old data.
If, for every geometries in the buffers, we passed a boolean attribute a_discard, then in the vertex buffer, the first instruction could be:
if (a_discard){
  discard;
}

Skipping rendering for that geometries.
Now, to update a geometry from n vertices to n+1 vertices, you only need to set a_discard to true in the n-vertices buffer and add the geometry to the (n+1)-vertices buffer.
That way, no need to rebuild buffers at all.
On the javascript side, it would require to track the empty space in each buffer to be able to add new geometry to the first empty space instead of the end of the buffer.
And an occasionnal rebuild might be useful if the buffer become too fragmented.

I don't know, this sounds a bit complex regarding the expected gain. Rebuilding a buffer isn't an extraordinary thing to do, it's long if you have many features in it (> 10'000 becomes noticeable I'd say) but it's still manageable.

Without considering the number of vertices of a geometry.
If you need to remove multiple geometries in a large dataset during a short interval, you'd need to rebuild the buffer and lag would be significant. Even if you group features in different buffer, in the worst case scenario, the deletions would be spread evenly accross the buffers and so would be similar to rebuilding one big buffer.
Having a buffer with empty geometry space in it would avoid that entirely for sure.
Now, it's also possible to have a large number of multi-vertices geometry.
For example a large number of single point geometry represented by a polygon shape.
Now, will there be a lot of use cases for a large number of geometries with their number of vertices varying in real-time ?
That would definitely be a very exciting application.
Cloud-shapes updating in real-time, historical paths of multiple gps devices, various animations like replaying the historical countries borders or the icebergs breaking from the ice floe for example. I'm sure there is more even if a bit niche.


Docker build failure

The reason:
Step 18/26 : COPY --from=builder /usr/local/lib/* /usr/local/lib/
 ---> Using cache
 ---> e01b6497df4e
Step 19/26 : COPY --from=builder /opt/eosio/bin /opt/eosio/bin
COPY failed: stat /var/lib/docker/aufs/mnt/932731c8c65c2f41e6c8ffed3faeb96ce2d19a999b603979efe359e8687a375c/opt/eosio/bin: no such file or directory

The result of docker version:
Client:
 Version:       17.12.0-ce
 API version:   1.35
 Go version:    go1.9.2
 Git commit:    c97c6d6
 Built: Wed Dec 27 20:03:51 2017
 OS/Arch:       darwin/amd64

Server:
 Engine:
  Version:      17.12.0-ce
  API version:  1.35 (minimum version 1.12)
  Go version:   go1.9.2
  Git commit:   c97c6d6
  Built:        Wed Dec 27 20:12:29 2017
  OS/Arch:      linux/amd64
  Experimental: true

Does anyone else occur this issue?

This should be resolved with PR #1218


haskell: update "distributed-process" family of packages

@peti We can also remove "distributed-process-platform" (it's deprecated now, splitted into all those packages). If you prefer, I can do further "add cabal2nix'ed library" commits without PRs.

@abbradar, I switched to haskell-ng and consequently don't use the haskellPackages set any more. Please feel free to update and/or fix packages in that hierarchy as you please without  going through a PR and without notifying me.

This ended up with me moving to haskell-ng myself ^_^ . I think I'll just close this.


Video device types not up to date in matter_devices.xml

Problem
I cross-referenced device_library.pdf version 0.8-core-appclusters-devtype-ncr, 2022-05-01 21:37:45 -0700: Draft with matter_devices.xml and found the following video related items to not be up to date:

10.2 Basic Video Player (0x0028) is missing from matter_devices.xml
10.3 Casting video player (0x0023) is called “Video Player” in matter_devices.xml
10.5 Content App is called “Content Application” in matter_devices.xml
10.5 Content Application in matter_xml incorrectly references cluster TV Channel. It should be Channel.
10.6 Casting Video Client is missing from matter_devices.xml
10.7 Video Remote Control is missing from matter_devices.xml

Proposed Solution
Update matter_devices.xml according the latest spec.

hi @balloob can you please specify where can I find the matter_devices.xml?
TV Channel was renamed 6 months ago. I don't know how you're still able to find this reference

It's here:
https://github.com/project-chip/connectedhomeip/blob/master/src/app/zap-templates/zcl/data-model/chip/matter-devices.xml
Tip: You can press T on any GitHub page to search the files in the repository.

We should label this issue with "Request Cert Blocker"

@balloob
What should be the device id for these two?
10.6 Casting Video Client is missing from matter_devices.xml
10.7 Video Remote Control is missing from matter_devices.xml

I do not know. I just noticed that it's missing.


[Excel](custom functions) removing preview from custom functions

Docs Build status updates of commit c5c3e51:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/develop/make-office-add-in-compatible-with-existing-com-add-in.md
:white_check_mark:Succeeded

docs/excel/custom-functions-architecture.md
:white_check_mark:Succeeded

docs/excel/custom-functions-authentication.md
:white_check_mark:Succeeded

docs/excel/custom-functions-batching.md
:white_check_mark:Succeeded

docs/excel/custom-functions-best-practices.md
:white_check_mark:Succeeded

docs/excel/custom-functions-changelog.md
:white_check_mark:Succeeded

docs/excel/custom-functions-debugging.md
:white_check_mark:Succeeded

docs/excel/custom-functions-dialog.md
:white_check_mark:Succeeded

docs/excel/custom-functions-errors.md
:white_check_mark:Succeeded

docs/excel/custom-functions-json-autogeneration.md
:white_check_mark:Succeeded

docs/excel/custom-functions-json.md
:white_check_mark:Succeeded

docs/excel/custom-functions-localize.md
:white_check_mark:Succeeded

docs/excel/custom-functions-naming.md
:white_check_mark:Succeeded

docs/excel/custom-functions-overview.md
:white_check_mark:Succeeded

docs/excel/custom-functions-parameter-options.md
:white_check_mark:Succeeded

docs/excel/custom-functions-requirements.md
:white_check_mark:Succeeded

docs/excel/custom-functions-runtime.md
:white_check_mark:Succeeded

docs/excel/custom-functions-save-state.md
:white_check_mark:Succeeded

docs/excel/custom-functions-troubleshooting.md
:white_check_mark:Succeeded

docs/excel/custom-functions-volatile.md
:white_check_mark:Succeeded

docs/excel/custom-functions-web-reqs.md
:white_check_mark:Succeeded

docs/excel/make-custom-functions-compatible-with-xll-udf.md
:white_check_mark:Succeeded

docs/excel/xll-compatibility-requirements.md
:white_check_mark:Succeeded

docs/includes/excel-custom-functions-note.md
:white_check_mark:Succeeded

docs/includes/xll-compatibility-note.md
:white_check_mark:Succeeded

docs/reference/manifest/equivalentaddin.md
:white_check_mark:Succeeded

docs/reference/manifest/equivalentaddins.md
:white_check_mark:Succeeded

docs/reference/manifest/filename.md
:white_check_mark:Succeeded

docs/reference/manifest/progid.md
:white_check_mark:Succeeded

docs/reference/manifest/type.md
:white_check_mark:Succeeded

docs/reference/requirement-sets/excel-api-requirement-sets.md
:white_check_mark:Succeeded

docs/toc.yml
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


provider: no bids if service count is not 1

This may be a pricing issue, but I don't think that it is.
deployment:
  web:
    primary:
      profile: web
      count: 2

it was Inventory in the ballroom.


Async conform support

It'd be helpful if the conform method supported a callback to help with async validation of properties. eg a database lookup

waiting for async before can use it.

waiting for async before can use it.

This is discouraging to see that this issue was opened in 2013 and it still isn't resolved.  Async support is fundamental in node programming.  I can't even use promises because the conform function can't see the returns I'm making in a callback...this should definitely be supported

This project isn't supported much anymore. I'm guessing the people that support it are super busy, or just don't have time to do it. My team and I have just been updating the code to match what we need.

I and my colleagues maintain fork (conform.js)[https://github.com/okv/conform.js] main features we've added - optional source modifications (apply default values to the source object, apply type casting results to the source object, etc). But we also don't have async conform function because we don't need that. But if somebody do the pr (with tests), we could accept that =)


Saving FastSurferCNN output in mgz, nii, or nii.gz

Description
This PR incorporates saving of FastSurferCNN output in mgz, nii, or nii.gz formats, through the save_image function.
The desired output format is inferred from the output file name, and the function handles saving the output in that format.
Note that an AssertionError is raised for an invalid or unsupported file format.
Note: the default segmentation output format has been set to nii.gz (the documentation has also been updated to reflect this).

I think it is not a good idea to just change the default to .nii.gz. We should at least add a check for .mgz if the default .nii.gz is not found in run_fastsurfer.sh. We have been using .mgz for quite some time and this might mess with processing steps other users have already set up. I know that the switch is simple (the user can just provide the additional flag to use .mgz), but I would either keep the default output to .mgz or have an automatic check if the .nii.gz is not found. @m-reuter, what do you think?

After discussing the issue with Martin, we decided to keep the default format at .mgz for the time being. Instead, a separate flag should be issued if the user wants nifti-output (or automatically detect ending in output segmentation file name).

I have reverted the relevant changes; the default format is mgz as before.
The desired output format is still inferred from the output filename extension.
I have made small additions to the READMEs to mention the supported segmentation output file formats. Let me know if you prefer this be documented differently.


Remove all unused and unnecessary code.

The codebase contains a lot of confusing code that is not used / not maintained. It should be removed to create less confusion for new users.

Feel free to tackle this if you want, but don't remove features just becuase they aren't being used in the starter. i.e. Disqus.


Take package name from pyproject.toml project.name

If there is a pyproject.toml, then take the conda package name from that instead
of from the wheel, unless overridden by this tool's cli or pyproject.toml options.
This will handle the case where the only reason to rename the package is because
of name normalization (e.g. turning . into -)

Done but needs test.


LocalFilesystem should watch as opt-in

new LocalFilesystem().watch()
For most use-cases, LocalFileSystem doesn't need watching.

I wouldn't say "most".
How about new LocalFilesystem({watch:false}) where the default is {watch:true}?

we need to put watch mechanism as a constructor option.
I suggest that by default we use chokidar for that and by default we have it on,
but to add {watch: false | watcher} option.
So you can turn watching of or pass own watch mechanism with similar events api to chokidar.

@tyv then it would not be such a simple tool to use anymore IMO

@amir-arad why? we would use chokidar by default. so current usage will same with an ability to pass another fsWatcher compatible watcher

can you describe a valid and concrete use-case for this ability that is not covered by completely disabling the watcher, or customizing its configuration?

@amir-arad this thread: https://github.com/wix/kissfs/issues/41#issuecomment-284429160

This is not a use case for the local file system, it's a test. In this case, the difference is crucial.

That is not a use case for the local file system, it's a test.

then if we want to fulfill the test we have to make this.watcher public.

how about (this as any).watcher as Watcher ?

can you describe a valid use-case for this ability that is not covered by completely disabling the watcher, or customizing its configuration

since we have them in npm, someone would definitely will ask to use them https://www.npmjs.com/package/node-watch


Checkboxes arn't showing in Mozilla FireFox browsers and their forks

Mozilla FireFox Developer Edition

Mozilla FireFox

But it works well in any Chromium based browser...

Thank you! :D


Facet search and facets in search inconsistency

Describe the bug
In the facet search documentation and how it's implemented facets search can't be done on numerical values. But why if adding a facets parameter for attributes of numeric type in the search query body does it work?
To Reproduce
Steps to reproduce the behavior:

Create an index, with attributes of numerical type
Add the attributes to filterableAttributes
Populate the index
Using search add facets parameter containing attributes that are of numerical type. In response, you get populated facetDistribution
Using facet search (/facet-search), search for the same facetName as in the previous point and you'll get empty facetHits

Expected behavior
I'd expect either for it to be populated in both cases or empty in both cases.
Meilisearch version:
v1.3.1

Hello @admirlju
Sorry, so far, Meilisearch does not support face search for numbers, as written here in our odcs
A workaround could be to convert your numerical values into strings.
If the workaround does not work for you, you can open a discussion here so that our product team can consider it and better know about your usecase. Please add as many details as you can so that we are sure to understand your specific need 😊
Thank you!

I close this issue due to a lack of answers. Nothing is definitive of course, feel free to ask to re-open if needed 😊


Remove a Bogus Early-Exit From Closure Specifier Computation

This doesn't need to early-exist by checking for tokens like this.
Fixes #768

@swift-ci test


Fix tags validation issues

Add callIfExists method, which will call a chosen method only if it exists

Is the issue occurring for more than just .persist() then?

Yep, so I was going to try and pass in an event that I create from the document node but since it's a special react event and has special methods I couldn't do that. Since tags have a more proactive approach to validation I'm not concerned about this validation not working for them (in the short term), but this will make it so the tags at least function.

To follow on, do we even need persist at all? I haven't really looked into why we need it if Tags can't even access it anyway.
If we do use this solution, would it be better to define the function outside of the handler so we aren't re-defining it with every validation check or whatever (every keypress)?

Yeah from what I can tell until React v17 persist is necessary because any calls to the synthetic event methods when it hasn't been persisted are considered illegal invocations.
Personally, my long-term recommendation would be to move away from the synthetic event-based validation error popups and use an inline or block-based error message.
But yes you're right, I should probably move it to outside the method. Maybe just a static in the JS file.

I did just update us to React 17. Does that mean we get rid of Persist then?

Oooh that's a good question, I'll check.

Did you get a chance to check? Otherwise I can just merge it now so our users can have tags working again.

Yep, I just removed the persist call but we do still need the new function for the other event methods we call.


Cannot parse valid ISO 8601 date with a leap second

Description of the Issue and Steps to Reproduce:
moment('2016-12-31T23:59:60Z')
// moment.invalid(/* 2016-12-31T23:59:60Z */)

moment('2016-12-31T23:59:60Z', 'YYYY-MM-DDTHH:mm:ssZ')
// moment.invalid(/* 2016-12-31T23:59:60Z */)

This should be parsed correctly since this is a valid ISO 8601 date with a leap second.
Environment:
Node.js v6.10.0
Moment v2.17.1
References:
ISO 8601:2004[E] section 2.2.2 leap second

Looks like Node.js Date cannot parse/handle leap seconds as well.

Yeah, because JS Date is unix time based, this issue goes all the way down the stack - it's inherent in ECMAScript. I'm a delegate to TC39, and I'm actually working to fix this, but obviously this is only a stage 0 proposal right now, so that's a long way down the road.
In the mean time, I'm not sure if there's an appropriate solution to this problem. We can't exactly write validation code that accepts 60 in the seconds place as-appropriate, since leap seconds are intermittent. There would be no formula and we would have to manually add each one as it came - lots of weird stuff.
Do you have a solution to this problem that you think would be reasonable?

Right, we could make the parser accept this, but we couldn't represent the date after we did so:
> new Date(1483228799000)
2016-12-31T23:59:59.000Z
> new Date(1483228799000 + 1000)
2017-01-01T00:00:00.000Z

I think the way it works is that the underlying system is responsible for making an abrupt time change later, such as repeating the first second of 2017. So the leap second is implemented as a break between the neat visible-to-JS timeline and reality. In theory, you could create a userspace library that knows when leap seconds happened or will happen and has its own representation of the date, and then does the appropriate work to translate things back into the JS non-leaped timeline, presumably by doing its own version of repeating seconds. Not only does that sound complicated, but it's very far from how Moment works or is likely to ever work. If JS is going to put its head in the sand about leap seconds, we're going to too.


Animation bug in chrome and opera

When switching between items in Chrome and Opera, you can see the item that was just moved jump as it's done moving. This issue does not exist in other browsers.
Chrome:
https://vimeo.com/369621511
Opera:
https://vimeo.com/369623795
Firefox:
https://vimeo.com/369622980
Edge:
https://vimeo.com/369623386

Hi, I'm having the exact same issues which make the usage of this plugin not a viable option for now.
That's a pity cause it has all I need and is very easy to implement. Let's hope somebody will find a solution :(

Just curious -- how come the demo works just fine in the same browsers? It looks flawless there.
http://brokensquare.com/Code/jquery-flipster/demo/

I just got a notification that the chromium issue tracking this has been closed and I'm no longer seeing this behavior in Chrome, so I think we can consider this fixed.


[BUG] Certificate in Vault is also generated or copied even if flag in configuration tls_disable is set to true

Describe the bug
Certificate in Vault is also generated or copied even if flag in configuration tls_disable is set to true in Vault configuration.
To Reproduce
Steps to reproduce the behavior:

Create Vault config in Epiphany configuration, e.g:

---
kind: configuration/vault
title: Vault Config
provider: aws
name: default
specification:
  vault_enabled: true
  tls_disable: true

Execute epicli apply ... with your configuration file and settings from abov

Expected behavior
With flag tls_disable set to true part of code related to certificates should be skipped.
Config files
Shown above.
OS (please complete the following information):

OS: All

Cloud Environment (please complete the following information):

Cloud Provider: All

Additional context
No any additional context.

It has been tested. The certificate generation/copying now depends on the value of the tls_disable parameter.


Update repositories.txt

hello，DFRobot_A111 was renamed to DFRobot_RS01， we hope delete DFRobot_A111.

Hello @Arya11111. I am confirming your request.
Unlike submissions, this type of request is still handled manually. The Library Manager index maintainer occasionally comes through to clear all the outstanding requests and merges these pull requests when it is done. You will get a notification from GitHub at that time.
After that, you can monitor the indexing of the library via its dedicated logs web page.
Information about that here:
https://github.com/arduino/library-registry/blob/main/FAQ.md#can-i-check-on-library-releases-being-added-to-library-manager

Done in #1300


Manage Allocation bug on payments.

Critical Changes
Changes

We fixed an issue that prevented Opportunity Allocation updates when an Opportunity was both fully scheduled and had a paid Payment. As part of this change, we updated GAU Allocation classes, including ALLO_PaymentSync_SVC.cls. This change is intended for use in a future release and should have no visible impact on your org.

Issues Closed
New Metadata
Deleted Metadata

@KietTruongSFDO Release note revised. Please sanity check?

@KietTruongSFDO Release note revised. Please sanity check?

I updated it from "fully allocated" to "fully scheduled".

@KietTruongSFDO Release note revised. Please sanity check?

@lianeyee I updated it from "fully allocated" to "fully scheduled".

@KietTruongSFDO Could you clarify what's mean by "fully scheduled"?

@KietTruongSFDO Release note revised. Please sanity check?

@lianeyee I updated it from "fully allocated" to "fully scheduled".

@KietTruongSFDO Could you clarify what's mean by "fully scheduled"?

@lianeyee  Sure, "fully scheduled" means that the full amount of the donation is scheduled (they could be paid or unpaid). If there's an Opportunity for $1,000 and there's 10 scheduled payments of $100, then it would be fully scheduled. If the amount is that is scheduled is less than the opportunity amount, then it would be under scheduled and the opposite would be over scheduled.

@KietTruongSFDO Release note revised. Please sanity check?

@lianeyee I updated it from "fully allocated" to "fully scheduled".

@KietTruongSFDO Could you clarify what's mean by "fully scheduled"?

@lianeyee Sure, "fully scheduled" means that the full amount of the donation is scheduled (they could be paid or unpaid). If there's an Opportunity for $1,000 and there's 10 scheduled payments of $100, then it would be fully scheduled. If the amount is that is scheduled is less than the opportunity amount, then it would be under scheduled and the opposite would be over scheduled.

I guess I'm questioning the terminology. A set of Payments is simply "scheduled." There's no such thing as being partially scheduled versus fully scheduled, is there? I get that the sum of the total Payment amounts may not match the overall Opportunity amount--it's not recommended but it is possible. @markross-sfdo Is "over- and under-scheduling" a thing?

@KietTruongSFDO Release note revised. Please sanity check?

@lianeyee I updated it from "fully allocated" to "fully scheduled".

@KietTruongSFDO Could you clarify what's mean by "fully scheduled"?

@lianeyee Sure, "fully scheduled" means that the full amount of the donation is scheduled (they could be paid or unpaid). If there's an Opportunity for $1,000 and there's 10 scheduled payments of $100, then it would be fully scheduled. If the amount is that is scheduled is less than the opportunity amount, then it would be under scheduled and the opposite would be over scheduled.

I guess I'm questioning the terminology. A set of Payments is simply "scheduled." There's no such thing as being partially scheduled versus fully scheduled, is there? I get that the sum of the total Payment amounts may not match the overall Opportunity amount--it's not recommended but it is possible. @markross-sfdo Is "over- and under-scheduling" a thing?

@lianeyee I think partially scheduled and under scheduled would be the same.


Replace class setup functions with Pytest fixtures

Since we recently refactored the tests to use Pytest, it would be nice to convert the existing unittest-style setup/teardown class functions into Pytest-style fixtures. This would lead to better maintainability and compatibility going forward.
An example of the setup_class(cls) code that should be replaced: https://github.com/crsmithdev/arrow/blob/master/tests/test_factory.py#L17

I'm gonna tackle this issue this weekend.

Great to have you back @krisfremen!

@jadchaar good to be back, pull request ready for review :)


How to invoke a function with custom client context?

On AWS, I'm using Lambda function which receives event data and custom client context. For local testing, I want to run curl and invoke function with custom client context, defined as: https://github.com/aws/aws-lambda-runtime-interface-emulator/blob/5a79e1e82cf701cff870ae7d665523fb356e6c47/lambda/core/directinvoke/customerheaders.go#L15
I dug into codes, and found aws-lambda-rie seems not to add client context to a invoke payload: https://github.com/aws/aws-lambda-runtime-interface-emulator/blob/5a79e1e82cf701cff870ae7d665523fb356e6c47/cmd/aws-lambda-rie/handlers.go#L96-L103
So, is there any ways to use custom client context with aws-lambda-rie? Should I send a pull request for this? It seems that Lambda-Runtime-Client-Context header is related to this, but I cannot find a way to use it properly.
Environment: I'm using aws-lambda-rie command in public.ecr.aws/lambda/nodejs:18.2<IP_ADDRESS> image (https://gallery.ecr.aws/lambda/nodejs). Locally, I confirmed my function implementation can receive event data by running curl -XPOST "http://localhost:9000/2015-03-31/functions/function/invocations" -d '{"payload":"hello world!"}', but cannot receive client context by adding Lambda-Runtime-Client-Context header like -H 'Lambda-Runtime-Client-Context: { "foo":"bar" }'. On AWS, my function can receive custom client context.

I asked AWS Support and received an answer which says there is no ways to pass client context to my function for now.
Alternatively, as a workaround, if it's possible to change function code, we can set client context in the code if no client context is given.

Still pending actual release with this feature. I'll keep open until next release.

@valerena when can we expect v1.19 to be available in public.ecr.aws/lambda/provided:al2 and public.ecr.aws/lambda/provided:al2023?

I reached out to the team in charge of maintaining those images. We'll see what they say

The images with the new version of RIE were released and are available (https://gallery.ecr.aws/lambda/provided and also in other runtimes).


buildsystem: Add an option to compress debug sections

Compressing debug sections can reduce the output
ELF file size substantially.

bintools_template.cmake also needs updating.
https://github.com/zephyrproject-rtos/zephyr/blob/045a11fad19582b4434ea0dcf7b1cc01a4958767/cmake/bintools/bintools_template.cmake#L1

Added, thank you!


Do not rerender if key changes but not data

This is so that you do not get an unnecessary rerender when the key has changed but the cached data is the same. In my case I'm conditionally fetching and when the key becomes valid I get an extra render while data is still undefined.
A few changes are from a linter that I assume ran on commit? Let me know if it's uncouth to have left them there.

Thank you @morgs32! Can you solve the conflict? And we will take this PR 👍

Sorry for the delay. Rebased and left out the lint fixes.


Provide an option to WebGraphQlTester to select transport protocol

I want to test the all operations via WebSocket transport protocol in my WebFlux/WebSocket example project, but when running an integration test on a real HTTP sever, from the background console info, it always to use HTTP not WebSocket.

This should be covered by #163.