No action performer when trying to move two bots

Everything is working fine until commit fcf5aba5787cdc7f94cc2ccb2c6c1301d7dcd8e9
As mentioned previously, I'm working on a demo for multiple robots based off of the bt_example. Everything was working as expected until the aforementioned commit. Planner returns a plan but when run, one of the bots begins execution while the other logs No action performer for (move bot assembly_zone body_car_zone). retrying until eventual failure.

Hi @sethhoward
You should have two instances of the move node, like this:
    move_1_cmd = Node(
        package='plansys2_bt_actions',
        executable='bt_action_node',
        name='move_1',
        namespace=namespace,
        output='screen',
        parameters=[
          example_dir + '/config/params.yaml',
          {
            'action_name': 'move',
            'bt_xml_file': example_dir + '/behavior_trees_xml/move.xml'
          }
        ])

    move_2_cmd = Node(
        package='plansys2_bt_actions',
        executable='bt_action_node',
        name='move_2',
        namespace=namespace,
        output='screen',
        parameters=[
          example_dir + '/config/params.yaml',
          {
            'action_name': 'move',
            'bt_xml_file': example_dir + '/behavior_trees_xml/move.xml'
          }
        ])

It is supposed that one is busy executing one action. So you need another. In a real application, each robot has its own move node.

Hi @sethhoward
You should have two instances of the move node, like this:
    move_1_cmd = Node(
        package='plansys2_bt_actions',
        executable='bt_action_node',
        name='move_1',
        namespace=namespace,
        output='screen',
        parameters=[
          example_dir + '/config/params.yaml',
          {
            'action_name': 'move',
            'bt_xml_file': example_dir + '/behavior_trees_xml/move.xml'
          }
        ])

    move_2_cmd = Node(
        package='plansys2_bt_actions',
        executable='bt_action_node',
        name='move_2',
        namespace=namespace,
        output='screen',
        parameters=[
          example_dir + '/config/params.yaml',
          {
            'action_name': 'move',
            'bt_xml_file': example_dir + '/behavior_trees_xml/move.xml'
          }
        ])

It is supposed that one is busy executing one action. So you need another. In a real application, each robot has its own move node.

Ok, I'll give that a try. Previously this worked:
move_cmd = Node(
    package='plansys2_bt_actions',
    executable='bt_action_node',
    name='move',
    namespace=namespace,
    output='screen',
    parameters=[
      [planner_dir, '/params/plansys_params_', namespace, '.yaml'],
      {
        'specialized_arguments': [[namespace]],
        'action_name': 'move',
        'bt_xml_file': example_dir + '/behavior_trees_xml/move.xml'
      }
    ])

Where this node was generated for each robot being brought into the world. I'm assuming this was just a lucky coincidence and not the proper creation and the name as well as specialized_arguments should be unique for each bot?

Ok, I'll give that a try. Previously this worked:
move_cmd = Node(
    package='plansys2_bt_actions',
    executable='bt_action_node',
    name='move',
    namespace=namespace,
    output='screen',
    parameters=[
      [planner_dir, '/params/plansys_params_', namespace, '.yaml'],
      {
        'specialized_arguments': [[namespace]],
        'action_name': 'move',
        'bt_xml_file': example_dir + '/behavior_trees_xml/move.xml'
      }
    ])

Where this node was generated for each robot being brought into the world. I'm assuming this was just a lucky coincidence and not the proper creation and the name as well as specialized_arguments should be unique for each bot?

Hi @sethhoward
First of all, update to HEAD as soon as I merge #73. This PR contains a utility to check the action performers for each action. This PR also fixes a possible bug I introduced some commits ago. I changed the /actions_hub topic to actions_hub, but it could be a failure if you use a different namespace for each robot, so I have just reverted.
If you don't find section performers, check that they exist and they are in an inactive state. Maybe someone didn't configure correctly.
I would like also to explain the protocol to find the action performers, so you can understand the problem:

I use the topic /actions_hub to deliver the actions to each action performer, which is implemented in plansys::ActionExecutorClient. The other part of this communication is in the Executor, instantiating a plansys::ActionExecutor for each action to execute.
You can echo /actions_hub to see the plansys2_msgs/msg/ActionExecution messages. This message implements the protocol.
Each time an action has to be executed this happens:

The Executor sends a plansys2_msgs::msg::ActionExecution::REQUEST with the action and the parameters, asking for any action performer to execute it.
As soon as each action performer receives the request, each action performer checks if it implements that action, is inactive and the arguments fit (here the specialized_arguments, if any,  are checked). If affirmative, it sends a plansys2_msgs::msg::ActionExecution::REQUEST, declaring that it is willing to execute. Here, this action performed is committed to this request. This avoids sending more than one response for different requests.
The Executor receives the responses. The first response is confirmed with a plansys2_msgs::msg::ActionExecution::CONFIRM message. Successive responses are answered with plansys2_msgs::msg::ActionExecution::REJECT.
When an action performer receives a plansys2_msgs::msg::ActionExecution::CONFIRM, it activates to execute the action. In case of a rejection, it releases the commit, and it is ready to participate in another request.

I will write this description in the documentation on the web page soon, but I wanted to give you more information now.
I hope this helps you :wink:

Hi @sethhoward
First of all, update to HEAD as soon as I merge #73. This PR contains a utility to check the action performers for each action. This PR also fixes a possible bug I introduced some commits ago. I changed the /actions_hub topic to actions_hub, but it could be a failure if you use a different namespace for each robot, so I have just reverted.
If you don't find section performers, check that they exist and they are in an inactive state. Maybe someone didn't configure correctly.
I would like also to explain the protocol to find the action performers, so you can understand the problem:

I use the topic /actions_hub to deliver the actions to each action performer, which is implemented in plansys::ActionExecutorClient. The other part of this communication is in the Executor, instantiating a plansys::ActionExecutor for each action to execute.
You can echo /actions_hub to see the plansys2_msgs/msg/ActionExecution messages. This message implements the protocol.
Each time an action has to be executed this happens:

The Executor sends a plansys2_msgs::msg::ActionExecution::REQUEST with the action and the parameters, asking for any action performer to execute it.
As soon as each action performer receives the request, each action performer checks if it implements that action, is inactive and the arguments fit (here the specialized_arguments, if any,  are checked). If affirmative, it sends a plansys2_msgs::msg::ActionExecution::REQUEST, declaring that it is willing to execute. Here, this action performed is committed to this request. This avoids sending more than one response for different requests.
The Executor receives the responses. The first response is confirmed with a plansys2_msgs::msg::ActionExecution::CONFIRM message. Successive responses are answered with plansys2_msgs::msg::ActionExecution::REJECT.
When an action performer receives a plansys2_msgs::msg::ActionExecution::CONFIRM, it activates to execute the action. In case of a rejection, it releases the commit, and it is ready to participate in another request.

I will write this description in the documentation on the web page soon, but I wanted to give you more information now.
I hope this helps you :wink:

Hi @sethhoward
May I have the complete pddl, including dropoff, to do some tests?

Absolutely, I realized we haven't tried this domain with a solitary robot on either foxy or main branch.
(:requirements :strips :typing :adl :fluents :durative-actions)

;; Types ;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;
(:types
robot
zone
piece
car
);; end Types ;;;;;;;;;;;;;;;;;;;;;;;;;

;; Predicates ;;;;;;;;;;;;;;;;;;;;;;;;;
(:predicates

(robot_at ?r - robot ?z - zone)
(piece_at ?p - piece ?z - zone)

(piece_is_wheel ?p - piece)
(piece_is_body_car ?p - piece)
(piece_is_steering_wheel ?p - piece)

(piece_not_used ?p - piece)

(is_assembly_zone ?z - zone)
(carry ?r - robot ?p - piece)

(car_assembled ?c - car)

);; end Predicates ;;;;;;;;;;;;;;;;;;;;
;; Functions ;;;;;;;;;;;;;;;;;;;;;;;;;
(:functions

);; end Functions ;;;;;;;;;;;;;;;;;;;;
;; Actions ;;;;;;;;;;;;;;;;;;;;;;;;;;;;
(:durative-action move
    :parameters (?r - robot ?z1 ?z2 - zone)
    :duration ( = ?duration 5)
    :condition (and
        (at start(robot_at ?r ?z1)))
    :effect (and
        (at start(not(robot_at ?r ?z1)))
        (at end(robot_at ?r ?z2))
    )
)

(:durative-action pickup
    :parameters (?r - robot ?p - piece ?z - zone)
    :duration ( = ?duration 5)
    :condition (and
        (at start(robot_at ?r ?z))
        (over all (robot_at ?r ?z))

        (at start(piece_at ?p ?z))
    )
    :effect (and
        (at end(carry ?r ?p))
        (at end (not (piece_at ?p ?z)))
        (at start (not(piece_not_used ?p)))

        ; prevents a double move where both bots attempt to fetch the wheel even though only on can.
        ; also, Plansys2 skill layer will fail to execute the pick and place actions.
        (at start(robot_at ?r ?z))
    )
)

(:durative-action dropoff
    :parameters (?r - robot ?p - piece ?z - zone)
    :duration ( = ?duration 5)
    :condition (and
        (at start(robot_at ?r ?z))
        (over all (robot_at ?r ?z))

        (at start(carry ?r ?p))
    )
    :effect (and
        (at end(piece_not_used ?p))
        (at end(not(carry ?r ?p)))
        (at end(piece_at ?p ?z))

       ; Plansys2 skill layer fails without this even though the plan looks solid
        (at start (robot_at ?r ?z))
    )
)

(:durative-action assemble
    :parameters (?r - robot ?z - zone ?p1 ?p2 ?p3 - piece ?c - car)
    :duration ( = ?duration 5)
    :condition (and
        (at start(is_assembly_zone ?z))
        (at start(robot_at ?r ?z))
        (over all (robot_at ?r ?z))

        (at start(piece_at ?p1 ?z))
        (at start(piece_at ?p2 ?z))
        (at start(piece_at ?p3 ?z))

        (at start(piece_not_used ?p1))
        (at start(piece_not_used ?p2))
        (at start(piece_not_used ?p3))

        (at start(piece_is_wheel ?p1))
        (at start(piece_is_body_car ?p2))
        (at start(piece_is_steering_wheel ?p3))
    )
    :effect (and
        (at start(not(piece_not_used ?p1)))
        (at start(not(piece_not_used ?p2)))
        (at start(not(piece_not_used ?p3)))
        (at end(car_assembled ?c))

    )
)

);; end Domain ;;;;;;;;;;;;;;;;;;;;;;;;```

@fmrico
Foxy release with the domain above fails to run the gripper tasks with one robot unless the (at start(robot_at ?r ?z)) guard is included in pickup.
The Main branch running the same domain works fine using the above domain and also removing (at start(robot_at ?r ?z))
        ...

        (at start (not(piece_not_used ?p)))

        ; prevents a double move where both bots attempt to fetch the wheel even though only on can.
        ; also, Plansys2 skill layer will fail to execute the pick and place actions.
       ; (at start(robot_at ?r ?z))

       ...

It also successfully complete the mission with one robot. The issue of early assembly appears only when running multiple actors:
0.000: (move robot1 assembly_zone steering_wheels_zone)  [5.000]
5.001: (pickup robot2 body_car_1 body_car_zone)  [5.000]
5.001: (pickup robot1 steering_wheel_1 steering_wheels_zone)  [5.000]
10.001: (move robot2 body_car_zone assembly_zone)  [5.000]
10.001: (move robot1 steering_wheels_zone assembly_zone)  [5.000]
15.002: (dropoff robot2 body_car_1 assembly_zone)  [5.000]
15.002: (dropoff robot1 steering_wheel_1 assembly_zone)  [5.000]     <-- assembly begins after this step
20.003: (move robot2 assembly_zone wheels_zone)  [5.000]
25.004: (pickup robot2 wheel_1 wheels_zone)  [5.000]
30.004: (move robot2 wheels_zone assembly_zone)  [5.000]
35.005: (dropoff robot2 wheel_1 assembly_zone)  [5.000]
40.006: (assemble robot1 assembly_zone wheel_1 body_car_1 steering_wheel_1 car_1)  [5.000]

(define (problem factory_1) (:domain factory)
(:objects
    robot1 - robot
    robot2 - robot
    wheels_zone - zone
    steering_wheels_zone - zone
    body_car_zone - zone
    assembly_zone - zone
    wheel_1 - piece
    body_car_1 - piece
    steering_wheel_1 - piece
    car_1 - car
)

(:init
    (robot_at robot1 assembly_zone)
    (robot_at robot2 assembly_zone)
    (is_assembly_zone assembly_zone)
    (piece_at wheel_1 wheels_zone)
    (piece_at body_car_1 body_car_zone)
    (piece_at steering_wheel_1 steering_wheels_zone)
    (piece_is_wheel wheel_1)
    (piece_is_body_car body_car_1)
    (piece_is_steering_wheel steering_wheel_1)
    (piece_not_used wheel_1)
    (piece_not_used body_car_1)
    (piece_not_used steering_wheel_1)
)

(:goal (and
    (car_assembled car_1)
))

Here are the BT definitions:
Pickup
<root main_tree_to_execute = "MainTree" >
    <BehaviorTree ID="MainTree">
       <Sequence name="root_sequence">
           <OpenGripper    name="open_gripper"/>
           <ApproachObject name="approach_object"/>
           <CloseGripper   name="close_gripper"/>
       </Sequence>
    </BehaviorTree>
</root>

Drop off
    <BehaviorTree ID="MainTree">
       <Sequence name="root_sequence">
           <OpenGripper    name="open_gripper"/>
       </Sequence>
    </BehaviorTree>
</root>

@sethhoward  I think I found the problem. Working on it...

Hi @sethhoward
This Bug should be already fixed with the last refactors? Could you check it, please.

Sorry for the delay. I checked out the latest Foxy-devel branch. Using the same project as above as well as another project running in a different environment, map and doing a simple pick/place (no assembly).
I'm unsure if the refactors have fixed the issues because we're failing after the pickup!
[bt_action_node-30] CloseGripper tick 5
[bt_action_node-30] OpenGripper halt
[bt_action_node-30] ApproachObject halt
[bt_action_node-30] CloseGripper halt
[bt_action_node-29] [WARN] [1616703436.362754649] [robot.move_robot]: current and specialized arguments lenght doesn't match 3 1
[bt_action_node-29] [INFO] [1616703436.367674280] [robot.move_robot]: Waiting for "navigate_to_pose" action server
[bt_action_node-29] [INFO] [1616703436.368123553] [robot.move_robot]: "move" BtActionNode initialized
[bt_action_node-29] [ERROR] [1616703436.372999917] []: Caught exception in callback for transition 13
[bt_action_node-29] [ERROR] [1616703436.373020478] []: Original error: parameter 'waypoints' has already been declared
[bt_action_node-29] [WARN] [1616703436.373034937] []: Error occurred while doing error handling.```

Thoughts? Anything else I can provide?

Aside from my comments (which are more of a usability/client issue). This bug has been fixed. Thanks!

Thanks for testing, @sethhoward


spawn call overwrites instead of ORs flags

See: https://github.com/IBM/xmlservice/blob/20800d6be4aa4748b6eb226896c899c9c7e752ab/src/plugipc.rpgle#L1488
It overwrites a mutually exclusive job name flag, but it's also getting rid of the multithreaded job flag. Is this intentional? If so, the previous two lines should be dropped or this turned into an |=?

It seems intentional.
The change comment said:

1.9.3 xmlservice change spawn attributes no thread, different name

Previous flags are overwritten. Not sure why leave dead code there. Since XmlService is running under single-threaded job, the setup seems OK.


adding eslint standards, to start correcting many code inconsistencies

While looking over the React and Express Code, I am noting several inconsistencies and coding styles. I have added a standard eslint file, basing from air-bnb, and the required eslint dependencies required. This should over time, correct the inconsistencies and vulnerabilities in the Javascript.
Examples of the Error Present:
/Users/g6qs/Projects/conductor/ui/src/routes.js
6:8  error  'WorkflowDia' is defined but never used      no-unused-vars
11:8  error  'WorkflowMetaDia' is defined but never used  no-unused-vars
31:2  error  Missing semicolon                            semi
4:8   error  'ReactDOM' is defined but never used               no-unused-vars
7:5   error  'log' is never reassigned. Use 'const' instead     prefer-const
7:31  error  A space is required after '{'                      object-curly-spacing
7:32  error  Extra space after key 'src'                        key-spacing
7:64  error  A space is required before '}'                     object-curly-spacing
13:5   error  'app' is never reassigned. Use 'const' instead     prefer-const
14:10  error  Unexpected string concatenation                    prefer-template
21:5   error  'server' is never reassigned. Use 'const' instead  prefer-const
21:56  error  Unexpected function expression                     prefer-arrow-callback
22:3   error  Unexpected var, use let or const instead           no-var
23:3   error  Unexpected var, use let or const instead           no-var
23:7   error  Use object destructuring                           prefer-destructuring
/Users/g6qs/Projects/conductor/ui/src/utils/DOMUtils.js
7:22  error  Unexpected string concatenation  prefer-template
15:22  error  Unexpected string concatenation  prefer-template
✖ 2656 problems (2506 errors, 150 warnings)
2076 errors, 36 warnings potentially fixable with the --fix option.

@mstier-nflx can you please take a look at this PR?
Thanks.

@hunterford @mstier-nflx How do I get this merged?


add paniptic seg eval

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.
Motivation
Support point cloud panoptic segmentation for semanticKITTI and nuScenes.
Modification
Add panoptic segmentation evaluation and the test module.
BC-breaking (Optional)
Does the modification introduce changes that break the back-compatibility of the downstream repos?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.
Use cases (Optional)
If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.
Checklist

Pre-commit or other linting tools are used to fix the potential lint issues.
The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
If the modification has potential influence on downstream projects, this PR should be tested with downstream projects.
The documentation has been modified accordingly, like docstring or example tutorials.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.xzq seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


Receipt tests may have been broken

Sorry about that, I will fix them with the new methods soon

Hopefully just a matter of changing constructors. No rush.

These should be fixed.
I think the only receipt based test still giving me trouble is the view image one

All receipt tests pass


Add Augmented Reality Renderer

Add augmented reality renderer to show bigger schemas inside of room for example

this is the diagram issue


Add a CommandLineApplicationMarshall class

This should act as a state machine and manager for the sub-commands. It will take in the string or string[] of input and pass it along to the appropriate child command based on state.
It will have a method called AddCommandLineApp that will accept a CommandLineApp object and add it to the list of main commands.
The Marshall should inherit from CommandLineApp but should override Execute so it can intervene with correct state.
It will have a private property that indicates the current position in the CommandLineApp hierarchy. which will allow you to navigate down through the commands without having to type the command name or command chain repeatedly.
If I have an application called Hello with a default command that adds my name. so input of Hello Theo returns a response of Hello Theo, it's nice to meet you. the current command level would not change.
but if I input simply Hello the Marshall will execute this as Set "Hello" as the active command node and then run -h on the hello command
Features Needed

Set Active Command Node
Go up Active Command Node Chain
List current Active Command Node and Chain
Allow a Command Node to kick a user up a level. -- For example if a child CommandLineApplication has an "Exit" Command, it should be able to tell the marshall via it's response that the input was to exit it.
Marshall should not do Console.ReadLine, it should receive input and provide a response object back. ** for now the response object should be a message and an optional flag telling the Host that the session can be terminated.

Some commands might have no parameters or options beneath them, so we can't assume that a command of "Hello" automatically means "set my new command level"
Maybe it needs to mean "Execute this command AND set my new command level" ?
Or do I need differentiation between a Command and a CommandContext ? -- I feel like adding more taxonomy will confuse things more than just handling it.
I'm gonna try and just update CommandLineApplication.Execute() to implement the behavior I want first.

the best way to handle this is to make it explicit.
Hello means "Run hello regardless of context"
focus hello means "Make hello my new context"
This can be done by giving the CommandLineApp a native Command called "focus"

Went with keeping the CommandLineApplication as the top level object and ditched the Marshall Idea. Added some automatic commands and some internal handling changes to make it all go nice and smooth.
If you call .ConfigureForFocus() on any commandlineapplication object it will add the "Focus" command to itself and the Unfocus and GetContext commands to all the children. This lets you say focus hello and then just run -h to get the help for your new context. The new help should include the GetContext and Unfocus commands as well


Remove dead code and turn on noUnusedParameters

This removes unused functions, properties, and the CacheValidator service which was never used.

A lot of unnecessary (parameter) parens removed. Really cool! How did you do this? Could I do something like this too?

Richard recently turned on a tslint rule to identify single-arg anonymous functions to not allow brackets (which I don't feel too strongly about one way or the other). I found all the instances by running an inspection in my IDE and then fixed them semi-manually. Eventually I believe Richard wants the fixes to happen automatically using tslint CLI but I think we're not quite there yet.


Undo changes introduced 4.2.11 to fix unmute bug

4.2.11 fixes a bug in IE11 that breaks unmute function.
3de44e7#diff-8e5b21e030b4838c834057ce630b535b
This pull request reverts dash.js, flv.js. hls.js and html5.js to fix unmute.
See commits for more details.

Coverage remained the same at 74.487% when pulling ce8c1e53720e288f550c07e62158a01140f29bd3 on tnbnicer:master into 8be6b644eaf7883a068b3d16d653da9abc18648d on mediaelement:master.


Start using the v4 block list again

Now that the rule matching code in privacy-grade has been updated to
properly ignore unsupported rule actions, it should be safe to switch
back to the v4 block list again. That is necessary to get Click to
Load working for MV3 builds again, and is the next step towards
removing the legacy social_ctp_configuration.json[1] configuration
file.
Note: We also needed to fix the Click to Load YouTube test
configuration, that was missing the surrogate script entry. It
turned out that this was working by accident using the v4 block
list actions in the test block list file.
1 - https://staticcdn.duckduckgo.com/useragents/social_ctp_configuration.json

Reviewer: @jdorweiler
CC: @ladamski
Steps to test this PR:
MV2:

Check that Facebook Click to Load works correctly (see the test page).
Check that videos load as normal on the YouTube test page.

MV3:

Check that Facebook Click to Load works correctly (see the test page). Especially important is to check that requests are being blocked (not only that the placeholders are being shown.)
It's expected that videos are blocked incorrectly, with no placeholder shown on the YouTube test page. I will be fixing that next.

Automated tests:

[ ] Unit tests
[x] Integration tests

Reviewer Checklist:

[ ] Ensure the PR solves the problem
[ ] Review every line of code
[ ] Ensure the PR does no harm by testing the changes thoroughly
[ ] Get help if you're uncomfortable with any of the above!
[ ] Determine if there are any quick wins that improve the implementation

PR Author Checklist:

[ ] Get advice or leverage existing code
[ ] Agree on technical approach with reviewer (if the changes are nuanced)
[ ] Ensure that there is a testing strategy (and documented non-automated tests)
[ ] Ensure there is a documented monitoring strategy (if necessary)
[ ] Consider systems implications

Test YouTube Click To Load CTL: YouTube interacting with iframe API is failing for me locally so there's something a bit broken I suspect (running test-int so MV2)

Also Youtube doesn't load in MV3 as its blocked (since youtube CTL is not yet ready). But since Youtube action is not defined/enabled in duckduckgo/privacy-configuration#603, we should ensure that MV3 also abides by the config?

Yea, that's expected (see testing instructions). It will be next on my list to fix, after we land this.

Also Youtube doesn't load in MV3 as its blocked (since youtube CTL is not yet ready). But since Youtube action is not defined/enabled in duckduckgo/privacy-configuration#603, we should ensure that MV3 also abides by the config?

Yea, that's expected (see testing instructions). It will be next on my list to fix, after we land this.

Yes but as I said, since the action is not enabled we should not be blocking those in MV3 either?

Also Youtube doesn't load in MV3 as its blocked (since youtube CTL is not yet ready). But since Youtube action is not defined/enabled in duckduckgo/privacy-configuration#603, we should ensure that MV3 also abides by the config?

Yea, that's expected (see testing instructions). It will be next on my list to fix, after we land this.

Yes but as I said, since the action is not enabled we should not be blocking those in MV3 either? To clarify, do you mean you'll fix youtube next or fix skipping disabled actions for MV3? :)

I meant I will be fixing MV3 Click to Load next, so that it's only active when it should be. Fixing YouTube CTL is out of scope for this project.


cmd/link: using -linkshared dies if compile not passed -p option

Please answer these questions before submitting your issue. Thanks!

What version of Go are you using (go version)?

tip

What operating system and processor architecture are you using (go env)?

Ubuntu 16.04.

What did you do?

./make.bash
go install -buildmode=shared std
cd ../test
go run run.go -linkshared method4.go

What did you expect to see?

no output

What did you see instead?

# go run run.go -- method4.go
exit status 1
panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x18 pc=0x4b4275]

goroutine 1 [running]:
panic(0x5a0bc0, 0xc420010180)
    /opt/opensource/go/src/runtime/panic.go:500 +0x1a1
cmd/link/internal/ld.relocsym(0xc4204c8690)
    /opt/opensource/go/src/cmd/link/internal/ld/data.go:530 +0x1425
cmd/link/internal/ld.reloc()
    /opt/opensource/go/src/cmd/link/internal/ld/data.go:658 +0xe7
cmd/link/internal/ld.Ldmain()
    /opt/opensource/go/src/cmd/link/internal/ld/pobj.go:213 +0x10ff
cmd/link/internal/amd64.Main()
    /opt/opensource/go/src/cmd/link/internal/amd64/obj.go:45 +0x19
main.main()
    /opt/opensource/go/src/cmd/link/main.go:28 +0x27d

FAIL    method4.go  0.693s
exit status 1

r.Sym.Sect is nil in:
		case obj.R_ADDROFF:
			o = Symaddr(r.Sym) - int64(r.Sym.Sect.Vaddr) + r.Add

r.Sym is a type symbol ("type..NEZkhXSX") from libstd.so.
Is noone else seeing this?

Ping @crawshaw

If I patch ldshlibsyms to fill out r.Sym.Addr and r.Sym.Sect.Vaddr then the test fails like this:
runtime: nameOff 0x6f698 out of range 0x6039c0 - 0x604468
fatal error: runtime: name offset out of range

which suggests an offset into the some section in libstd.so is being compared against the location of a section in the executable?

Oh phew, this is a test bogosity as well, it's because run.go does not pass -p  to go tool compile. Some nasty hacks to do that make all the tests (apart from goprint) pass, so not a 1.7 blocker imo.

compile -p is an option not a requirement. Whatever is broken here should work without it.

(Sorry I missed your original ping @mwhudson, the first email github sent was when @rsc commented.)
I don't understand the connection between -p and this bug. Do you understand how setting -p is fixing it?

No, I don't remember any more, would have to start investigating again.
sent from my phone, please excuse brevity
On 18 Oct 2016 23:51, "David Crawshaw"<EMAIL_ADDRESS>wrote:

(Sorry I missed your original ping @mwhudson https://github.com/mwhudson,
the first email github sent was when @rsc https://github.com/rsc
commented.)
I don't understand the connection between -p and this bug. Do you
understand how setting -p is fixing it?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/golang/go/issues/16632#issuecomment-254472880, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AApBFrveZrGOTw89J1UcGvPSLaP2ylSjks5q1KRngaJpZM4JenUI
.

@mwhudson, is this still a problem?

I just ran across the same problem. With tip this test still fails:
$ go run run.go -linkshared method4.go
# go run run.go -- method4.go
exit status 1
cannot parse package data of prog.o for hash generation, no newline found
cannot parse package data of method4a.o for hash generation, no newline found
panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x10 pc=0x50491e]

goroutine 1 [running]:
cmd/link/internal/ld.relocsym(0xc420512000, 0xc42053d5c0)
        /home/b00375952/Sources/go/go/src/cmd/link/internal/ld/data.go:639 +0x115e
cmd/link/internal/ld.(*Link).reloc(0xc420512000)
        /home/b00375952/Sources/go/go/src/cmd/link/internal/ld/data.go:772 +0xbe
cmd/link/internal/ld.Main()
        /home/b00375952/Sources/go/go/src/cmd/link/internal/ld/main.go:221 +0xa20
main.main()
        /home/b00375952/Sources/go/go/src/cmd/link/main.go:58 +0xac

FAIL    method4.go      0.244s
exit status 1

I can reproduce the same panic backtrace when building my own code in shared mode.

I have gathered some additional information after playing with this on tip. type..NEZkhXSX is the hashed name of the symbol type..importpath.main.. This symbol is defined in runtime.a and hence also in libstd.so. Consider the following three cases:

prog.o is compiled without -dynlink. The symbol name is never hashed. It is referenced in prog.o but never defined. prog.o is linked with method4a.o, runtime.a, sys.a and atomic.a. The reference in prog.o is relocated to the definition in runtime.a, and an executable is generated correctly.

prog.o is compiled with -dynlink -p=main. Due to dynamic linking, the symbol name is hashed by link to save space. type..NEZkhXSX is referenced and also defined in prog.o. Thus, by the time libstd.so is loaded in ldshlibsyms, the symbol already has type SRODATA and presumably a valid pointer in its Sect field. link doesn't crash in ld.relocsym but eventually fails because it can't parse package data for hash generation (as indicated in my previous comment), which seems to be a separate, new issue.

prog.o is compiled with only -dynlink. type.NEZkhXSX is referenced in prog.o but never defined. When ldshlibsyms encounters the definition in libstd.so, it sees that the symbol still has type Sxxx, so it changes its Type to SDYNIMPORT and its File to $GOROOT/pkg/linux_amd64_dynlink/libstd.so, and leaves its Sect field as nil. This causes the crash because the symbol reference is a R_ADDROFF relocation in another type symbol, specifically type.*main.T2, and the relocation must be relative to start address of a known section.

I understand why type..importpath."". isn't defined in prog.o, but why is type..importpath.main. defined in runtime.a? It seems that the problem could be avoided by having link generate a section that defines type..importpath.main. on the fly (if it is linking an executable), before ldshlibsyms is invoked.

Answering my own question, the import path for package main is created in runtime.a by this line of code in dumpbasictypes:
https://github.com/golang/go/blob/04d6f982ae63c4026bf5f65891547b3353d3b63b/src/cmd/compile/internal/gc/reflect.go#L1541

I have patched cmd/link/internal/gc/main.go to add a definition for type..NEZkhXSX (when linking an executable in linkshared mode), and that fixes the test case. But the problem affects more than just relocations for type..import."". In my situation, I am trying to build a shared library from code that uses runtime symbols via //go:linkname. Doing so leads to R_CALL and R_GOTPCREL relocations for runtime symbols, whose pkgPath are not defined in the section where the relocation occurs.
The problem started with commit c1659883, when the type of  uncommonType.pkgPath was changed from name to nameOff, to reduce code size. Without undoing that change, I think there are two potential approaches to make this work:

Teach link to insert symbol definitions for all relocated pkgPath names whose symbols are SDYNIMPORT.

Create a new type of nameOff for the pkgPath field, which provides two methods to resolve the desired name, depending on the type of the symbol. If the symbol is defined in the binary being built, this field remains a 32-bit offset from the current section. If the symbols is SDYNIMPORT and undefined, this field works like a GOT-relative address.

Removing release-blocker since this has been happening since Go 1.8.

I have written a fix for this problem on 1.9, but tip now gives a different error with this test case:
# go run run.go -- method4.go
exit status 1
/home/b00375952/Sources/go/go/pkg/tool/linux_amd64/link: prog.o is not an archive file

FAIL    method4.go      0.178s
exit status 1

run.go needs to be updated to run go tool compile with -pack so that intermediate output files are proper archives.

Actually my fix is incomplete. It only handles the specific case I care about (method offsets to methods defined in shared libraries), not the general case of section-relative offsets to types and strings in shared libraries.


Isn't the teleport skill delay too long?

This is probably 'standard' (same behavior as GMO)

but, I think 1500ms delay before teleporting seems too slow for a 'teleport'.
Could we make this shorter? like 300ms or 500ms? or configurable

As far as I remember I tried to implement it as original as possible. Reducing this time also gives an advantage in PvP for the wizards. Best would be a configuration for that, I guess. I'm not sure where it fits the best yet. Maybe a plugin configuration? 😅

To balance this advantage, we could make it similar to summon that has a cooldown. 😂 but yeah, understandable if we're really copying the original behavior.


Unable to remove unknown dispatcher / Task exception was never retrieved

I've been seeing this error for a long time (but there weren't many lightnings in my area, so it was not that disturbing), but after last night's heavy storm my log is completely flooded with errors like this one:
2022-06-24 01:20:27 WARNING (MainThread) [homeassistant.helpers.dispatcher] Unable to remove unknown dispatcher <bound method BlitzortungEvent._delete_callback of <Entity Lightning Strike: 11.1>> 2022-06-24 01:20:27 WARNING (MainThread) [homeassistant.helpers.dispatcher] Unable to remove unknown dispatcher <bound method BlitzortungEvent._delete_callback of <Entity Lightning Strike: 10.4>> 2022-06-24 01:20:27 WARNING (MainThread) [homeassistant.helpers.dispatcher] Unable to remove unknown dispatcher <bound method BlitzortungEvent._delete_callback of <Entity Lightning Strike: 11.0>> 2022-06-24 01:20:27 WARNING (MainThread) [homeassistant.helpers.dispatcher] Unable to remove unknown dispatcher <bound method BlitzortungEvent._delete_callback of <Entity Lightning Strike: 9.9>> 2022-06-24 01:20:27 ERROR (MainThread) [homeassistant] Error doing job: Task exception was never retrieved Traceback (most recent call last):   File "/usr/src/homeassistant/homeassistant/helpers/entity.py", line 823, in async_remove     raise HomeAssistantError( homeassistant.exceptions.HomeAssistantError: Entity geo_location.lightning_strike_d1bdf8bace0a5acebac5bea67c7ab81813dd42d7 async_remove called twice 2022-06-24 01:20:27 ERROR (MainThread) [homeassistant] Error doing job: Task exception was never retrieved Traceback (most recent call last):   File "/usr/src/homeassistant/homeassistant/helpers/entity.py", line 823, in async_remove     raise HomeAssistantError( homeassistant.exceptions.HomeAssistantError: Entity geo_location.lightning_strike_a59aa47b0065943abb02bbb747da93791c602b4d async_remove called twice 2022-06-24 01:20:27 ERROR (MainThread) [homeassistant] Error doing job: Task exception was never retrieved Traceback (most recent call last):   File "/usr/src/homeassistant/homeassistant/helpers/entity.py", line 823, in async_remove     raise HomeAssistantError( homeassistant.exceptions.HomeAssistantError: Entity geo_location.lightning_strike_ba4e9b0eef410178e498ddd61fe968be19f88268 async_remove called twice 2022-06-24 01:20:27 ERROR (MainThread) [homeassistant] Error doing job: Task exception was never retrieved Traceback (most recent call last):   File "/usr/src/homeassistant/homeassistant/helpers/entity.py", line 823, in async_remove     raise HomeAssistantError( homeassistant.exceptions.HomeAssistantError: Entity geo_location.lightning_strike_202b54cb32f7a2d773e3ba0a0a75f43be036c609 async_remove called twice 2022-06-24 01:30:27 WARNING (MainThread) [homeassistant.helpers.dispatcher] Unable to remove unknown dispatcher <bound method BlitzortungEvent._delete_callback of <Entity Lightning Strike: 9.0>> 2022-06-24 01:30:27 ERROR (MainThread) [homeassistant] Error doing job: Task exception was never retrieved Traceback (most recent call last):   File "/usr/src/homeassistant/homeassistant/helpers/entity.py", line 823, in async_remove     raise HomeAssistantError( homeassistant.exceptions.HomeAssistantError: Entity geo_location.lightning_strike_69d9b680565a44fc0412ad2fd50981eb842cbee4 async_remove called twice 2022-06-24 01:32:27 WARNING (MainThread) [homeassistant.helpers.dispatcher] Unable to remove unknown dispatcher <bound method BlitzortungEvent._delete_callback of <Entity Lightning Strike: 7.7>> 2022-06-24 01:32:27 ERROR (MainThread) [homeassistant] Error doing job: Task exception was never retrieved Traceback (most recent call last):   File "/usr/src/homeassistant/homeassistant/helpers/entity.py", line 823, in async_remove     raise HomeAssistantError( homeassistant.exceptions.HomeAssistantError: Entity geo_location.lightning_strike_adb44db53ec6665bdfed5750e551c79ebb612f6f async_remove called twice
I saw an issue on the same matter already closed, but obviously the solution was not successfull. Can you please do something about it?

Any feedback on this (from the author or someone else)? Or am I the only one having this issue?

Me too. In addition, my log is also flooded with entries like
Jul 30 15:53:00 server conmon[198500]: homeassistant.exceptions.HomeAssistantError: Entity geo_location.lightning_strike_aa8e8762701f86f1951c39f8e3b3c18708792493 async_remove called twice
Jul 30 16:00:02 server conmon[198500]: 2022-07-30 16:00:02 ERROR (MainThread) [homeassistant.components.geo_location] Entity id already exists - ignoring: geo_location.lightning_strike_d159ada5e7f3c69ee93481f36536eec2d09f912d

This integration currently seems to be a bit log-intensive ;-).

Same here.


Error in netcdf-4 endianness handling?

The attached file appears to produce incorrect result.
I believe this is because endianness is attached to the type
object (NC_TYPE_INFO_T) rather than the var object (NC_VAR_INFO_T).
In the attached, we define an enum type and use it as the var type
for two different variables. We then set different endianness on the
two variables. What happens is that the endianness of the first variable
is changed when the endianness of the second variable is set.
t_endian.zip

The rule is, as documented, that endianness should be set only for numeric types, not user-defined types.
This is a restriction on user-defined types that few are likely to notice or care about. No one really wants to mess with endianness, now that every processor uses little-endian and netCDF-4 uses native endian by default.
@WardF if you have a way to assign issues to me, you can do that with this issue. I'll can fix it when I get back from vacation.


Add Python-3.13 support

Python 3.13: Oct 2024 https://peps.python.org/pep-0719/

update tox and github CI
update setup.cfg
update document
bump version x.Y.z for compatible update

Add support py313 after drop dj32 and dj40 due to avoid version combination complexity.

In fact, django that works with Python 3.13 is 5.1 or later.

Done by #164


feat(backend): add getUUIDHistory() repository method

...to be used in the /models api to get a more detailed UUIDHistory PLAT-215

@ApostolosBenisis rebased on the working branch and should be ready for final review. It can now be visualized in the frontend as well


How do I process ESP32-S2 random PSRAM error or Image hash failed (IDFGH-4296)

The module is esp32-s2-wroom 2MB PSRAM
The partitions.csv
nvs,      data, nvs,     0x9000,  0x6000,
phy_init, data, phy,     0xf000,  0x1000,
factory,  app,  factory, 0x10000, 1M,
storage,  data, spiffs,  , 0x80000,

idf.py size
Total sizes:
 DRAM .data size:   13732 bytes
 DRAM .bss  size:   22928 bytes
Used static DRAM:       0 bytes (      0 available, nan% used)
Used static IRAM:       0 bytes (      0 available, nan% used)
Used stat D/IRAM:  125583 bytes ( 267633 available, 31.9% used)
      Flash code:  490183 bytes
    Flash rodata:  121008 bytes
Total image size:~ 736774 bytes (.bin may be padded larger)

The current overall problem is: it is easy to restart indefinitely, or suddenly restart during use, and then it will restart indefinitely. The three esp32-s2s in hand all have the same situation. The two logs that often appear during infinite restart are as follows:
SPIWP:0xee
mode:DIO, clock div:1
load:0x3ffe8100,len:0x4
load:0x3ffe8104,len:0x1914
load:0x40050000,len:0x18a8
load:0x40054000,len:0x210c
entry 0x40050314
I (48) boot: ESP-IDF v4.2-dev-1983-gccdfbb865-dirty 2nd stage bootloader
I (48) boot: compile time 16:26:31
I (48) boot: chip revision: 0
I (52) qio_mode: Enabling default flash chip QIO
I (57) boot.esp32s2: SPI Speed      : 80MHz
I (62) boot.esp32s2: SPI Mode       : QIO
I (67) boot.esp32s2: SPI Flash Size : 4MB
I (72) boot: Enabling RNG early entropy source...
I (77) boot: Partition Table:
I (81) boot: ## Label            Usage          Type ST Offset   Length
I (88) boot:  0 nvs              WiFi data        01 02 00009000 00006000
I (95) boot:  1 phy_init         RF data          01 01 0000f000 00001000
I (103) boot:  2 factory          factory app      00 00 00010000 00100000
I (110) boot:  3 storage          Unknown data     01 82 00110000 00080000
I (118) boot: End of partition table
I (122) esp_image: segment 0: paddr=0x00010020 vaddr=0x3f000020 size=0x1d8b0 (121008) map
I (153) esp_image: segment 1: paddr=0x0002d8d8 vaddr=0x3ffc9b60 size=0x02740 ( 10048) load
I (156) esp_image: segment 2: paddr=0x00030020 vaddr=0x40080020 size=0x77ac8 (490184) map
0x40080020: _stext at ??:?

I (248) esp_image: segment 3: paddr=0x000a7af0 vaddr=0x3ffcc2a0 size=0x00e64 (  3684) load
I (249) esp_image: segment 4: paddr=0x000a895c vaddr=0x40024000 size=0x00404 (  1028) load
0x40024000: _WindowOverflow4 at E:/esp32/esp-idf/components/freertos/xtensa/xtensa_vectors.S:1730

I (255) esp_image: segment 5: paddr=0x000a8d68 vaddr=0x40024404 size=0x15758 ( 87896) load
I (285) esp_image: segment 6: paddr=0x000be4c8 vaddr=0x40070000 size=0x0001c (    28) load
I (296) boot: Loaded app from partition at offset 0x10000
I (297) boot: Disabling RNG early entropy source...
I (297) cache: Instruction cache        : size 8KB, 4Ways, cache line size 32Byte
I (304) cache: Data cache               : size 8KB, 4Ways, cache line size 32Byte
E (312) psram: PSRAM ID read error: 0x00ffff7f
E (317) cpu_start: Failed to init external RAM!

The other one cannot be given here because I did not save the log. But the reason for the error is probably written: calculate image hash 0xAA (0xBB) AA!=BB, but I am not using OTA related functions.
Once the above infinite restart occurs, it is usually completely disconnected from the power for a few seconds, including unplugging the battery, and then plugging in the power to start, and it will work normally.
I don’t even know where to find this kind of problem, and where it is......

Do you have connected something to pin IO26? Its is psram cs on wrover module (wroom is no psram).
Do you have stable power supply, maybe USB cable is bad quality.

No, I know IO26 is used by PSRAM, so it is left floating
You mean there may be a problem with the power supply of the USB port? But the working current of this module is only a few hundred mA. Can the USB port still not be able to provide it?

USB port is fine, but sometimes quality of USB cable is not. And if its battery powered then make sure wires are not too long, i had situation when old esp32 battery powered with 30-ish cm wires caused issue to run.

USB port is fine, but sometimes quality of USB cable is not. And if its battery powered then make sure wires are not too long, i had situation when old esp32 battery powered with 30-ish cm wires caused issue to run.

Thanks for your answer, I will try :)

@chegewara Thanks for the notes. @coollofty has your issue resolved? Thanks.

@chegewara Thanks for the notes. @coollofty has your issue resolved? Thanks.

Not sure, more testing .....

@coollofty Thanks for reporting, would you please help share if any updates for this issue? Thanks.

@coollofty  Thanks for reporting, would you please help share if any updates for this issue? Thanks.

After a period of testing, I can basically confirm that the problem is caused by the power supply:)


setSignedCookie is not setting up the cookie , local host

What version of Hono are you using?
4.5.11
What runtime/platform is your app running on?
Cloudfare workers
What steps can reproduce the bug?
I try to sign the cookie ,  it does return token and everything , but when i try to check it in browser , it doesn't show me cookie in application tab via localhost , and says authorization error I am working on a backend using Hono, JWT, and signed cookies. When a user signs in, I generate a JWT token and set it as a signed cookie using the following code:
c```
onst jwt = await sign({ id: user.id }, c.env.JWT_SECRET);
const cookie_secret = c.env.COOKIE_SECRET;
console.log(jwt);
await setSignedCookie(c, "bearer_token", jwt, cookie_secret, {
expires: new Date(Date.now() + 7 * 24 * 60 * 60 * 1000), // Cookie expiry (1 week)
httpOnly: true, // Only accessible via HTTP (prevents JavaScript access)
sameSite: "None", // Allows cross-site cookies
});
return c.json({ message: "successfully signed in", success: true });
### What is the expected behavior?
I expect the signed cookie to be set in the browser (visible in the Application > Cookies tab) after signing in, and for it to be automatically sent with subsequent API requests. However, after signing in:

The cookie doesn't appear in the browser's Application tab. I get a 401 Unauthorized error when trying to make authenticated requests to the API, indicating the token is missing or not being sent. What I've Tried:

Checked the logs: The JWT is being correctly generated, but it isn't appearing as a cookie in the browser. Cookie options: I added the httpOnly: true flag to prevent JavaScript access and sameSite: "None" to allow cross-site requests (since my frontend and backend are on different origins during development: localhost and <IP_ADDRESS>). CORS handling: My frontend uses axios to make requests with withCredentials: true for cookies, and I’ve configured CORS on the server.

### What do you see instead?

_No response_

### Additional information

_No response_

Hi @pranaydwivedi444
I think the screenshot says all of the things:

It's not a bug.

https://medium-blog-worker-serverless.vercel.app/blog/all
I have deployed it , here is my front end ,
here is my backend ,
https://backend.pranaydwivedi444.workers.dev/
I still can't understand the issue why the CORS error
`app.post("/signup", async (c) => {
//fetching body
const body = await c.req.json();
const prisma = c.get("prisma");
const { success } = signupInput.safeParse(body);
if (!success) {
return c.text("invalid inputs", 411);
}
//create user in db
const existingUser = await prisma.user.findUnique({
where: { email: body.email },
});
if (existingUser) {
  return c.json({ error: "User already exists" }, 409); // Conflict status code
}

try {
const user = await prisma.user.create({
data: {
email: body.email,
name: body.name || " ",
password: body.password,
},
});
const secret = c.env.JWT_SECRET;
const JWT = await sign({ id: user.id }, secret);
const cookie_secret = c.env.COOKIE_SECRET;
await setSignedCookie(c, "bearer_token", JWT, cookie_secret, {
expires: new Date(Date.now() + 7 * 24 * 60 * 60 * 1000),
sameSite: "None",
secure: true,
httpOnly: true,
});
// return jwt token
return c.json({
message: "successfull signed in",
success : true,
});
} catch (err) {
c.status(403);
return c.json({ error: error while signingup + ${err} });
}
});
app.post("/signin", async (c) => {
const prisma = c.get("prisma");
const body = await c.req.json();
const { success } = signinInput.safeParse(body);
if (!success) {
return c.text("invalid inputs", 411);
}
const user = await prisma.user.findUnique({
where: {
email: body.email,
password: body.password,
},
});
if (!user) {
c.status(403);
return c.json({ error: "user not found" });
}
const jwt = await sign({ id: user.id }, c.env.JWT_SECRET);
const cookie_secret = c.env.COOKIE_SECRET;
await setSignedCookie(c, "bearer_token", jwt, cookie_secret, {
expires: new Date(Date.now() + 7 * 24 * 60 * 60 * 1000),
});
return c.json({ message :"successfully signed in ", success: true });
});`
Here is my auth middleware :
export const authMiddleware: MiddlewareHandler = async function (c, next) {
  try {
    // const headerToken = c.req.header("Authorization") || "";
    // const token = headerToken.split(" ")[1];
    const cookie_secret = c.env.COOKIE_SECRET;
    const token = await getSignedCookie(c, cookie_secret, "bearer_token");
    if (!token) {
      c.status(401);
      return c.json({
        message: "Tokken missing",
      });
    }

    const secret = c.env.JWT_SECRET;
    const response = await verify(token, secret);
    if (response.id) {
      c.set("authorId", response.id);
      await next();
    }
  } catch (error) {
    c.status(401);
    return c.json({
      message: "Tokken error" + error,
    });
  }
};

I am using axios to send request
async function handleAPIBlogRequest(url: string) {
try {
const response = await axios.get(${backendUrl}/${url}, {
withCredentials: true,
});
return response.data;
} catch (error) {
throw error;
}
}

@pranaydwivedi444
It's difficult to run your code on my machine. Please provide a minimal project that does not use Prisma, Zod, or some libraries. If not, I'll close this issue.


Update 15.18 breaks backward compatibility: new required argument --staging-dir for apply?

Since June 26, our automated build systems fail because the command line arguments of the apply command have changed? I didn't find anything about these changes in the official doc though, and it seems there is a required --staging-directory argument now? What is it for?
Posting this as an issue, maybe it wasn't intended to make this new parameter required?

Hi!
Indeed, there was a rewrite of the patcher at some point, then the apply command was switched to it on master, then I was recently forced to release a stable builder of butler to fix another bug, so, yeah, --staging-directory is mandatory now (and it's using new patching code). But the patch format should remain stable.
Patching as implemented in butler is optimized for delivering game updates, so it tries to:

Use as little disk space as possible
Commit the result "as atomically as possible"

That's the purpose of the staging directory When doing patching in-place, it first applies the changes to a staging directory, and at the last minute, it applies those to the target directory.
I would recommend reviewing if butler v15.18.0 is fit for your purposes, or revert to an earlier version - in either case, please note that we don't offer support for that particular usage of butler (outside of itch.io), except for me personally compulsively replying to polite github issues.
But yeah, ultimately, if I were you, I'd take a look at github.com/itchio/wharf, and use those APIs directly. Although, there too, there is no stability guarantee I can offer you, so, pin your dependencies.
Hope this helps!

(That said, when patching to another directory, it seems like --staging-dir should not be required, so, yeah, it might be a bug, and I would like to take a look at it, but don't have the time to do that right now)

Oh OK, thanks for the answers :)


FileNotFound error if you don(t have a config.yaml

Add a single check to not try to load config.yaml when it isn't present in the filesystem

This has now been added


Feature/epoch info

Resolves:
https://github.com/rsproule/tanks/issues/10
https://github.com/rsproule/tanks/issues/11


Foreign keys recreated each time a migration is added, principal object not accessible from the dependent object

Hi. I created a very simple model with a principal entity (Author) and a dependent entity (Book) with a foreign key. I observe two strange behaviours (bug? or bad understanding of EF usage from my part?) :

The first migration is performed correctly, but any subsequent execution of dnx ef migrations add results in a new migration that recreates the foreign key.
EntityFramework returns null when I perform a book.Author query (even though the author actually exists in the database - cf. test case 1 below), except if I have already previously loaded the author, manually, within the same instance of the DbContext (cf. test case 2 below).

I'm using Entity Framework 7.0.0-rc1-final with Microsoft SQL Server 2014. DNX version : 1.0.0-rc1-update1. See my project.json below.
My model:
    public class Author
    {
        public int Id { get; set; }
        public string Name { get; set; }
    }

    public class Book
    {
        public int Id { get; set; }
        public string Title { get; set; }

        public int AuthorId { get; set; }
        public Author Author { get; set; }
    }

    public class EssaisContext : DbContext
    {
        public DbSet<Author> Authors { get; set; }
        public DbSet<Book> Books { get; set; }

        protected override void OnConfiguring(DbContextOptionsBuilder optionsBuilder)
        {
            optionsBuilder.UseSqlServer(@"Data Source=localhost;Integrated Security=true;Initial Catalog=Essais");
        }
    }

My test cases:
        public static void Main(string[] args)
        {
            // Populate database
            const string BOOK_TITLE = "Fables";
            const string AUTHOR_NAME = "La Fontaine";

            using (var db = new EssaisContext())
            {
                var author = db.Authors.Where(q => q.Name == AUTHOR_NAME).FirstOrDefault();
                if (author == null)
                {
                    author = new Author { Name = AUTHOR_NAME };
                    db.Authors.Add(author);
                }

                if (! db.Books.Any(q => q.Title == BOOK_TITLE))
                    db.Books.Add(new Book { Author = author, Title = BOOK_TITLE });

                db.SaveChanges();
            }

            // Test case 1 (fails)
            using (var db = new EssaisContext())
            {
                var book = db.Books.Where(q => q.Title == BOOK_TITLE).FirstOrDefault();
                Console.WriteLine("1) book.Author: " + (book.Author != null ? "not null <== OK" : "null <== NOT OK"));

                // Writes: 1) author.Book: null <== NOT OK
            }

            // Test case 2 (succeeds)
            using (var db = new EssaisContext())
            {
                var author = db.Authors.Where(q => q.Name == AUTHOR_NAME).FirstOrDefault();

                var book = db.Books.Where(q => q.Title == BOOK_TITLE).FirstOrDefault();
                Console.WriteLine("2) book.Author: " + (book.Author != null ? "not null <== OK" : "null <== NOT OK"));

                // Writes: 2) author.Book: not null <== OK
            }

            Console.WriteLine("Press any key to terminate...");
            Console.ReadKey();
        }

Every execution of dnx ef migrations add MIGRATION_NAME (after the initial migration) produces the following migration:
    public partial class MIGRATION_NAME : Migration
    {
        protected override void Up(MigrationBuilder migrationBuilder)
        {
            migrationBuilder.DropForeignKey(name: "FK_Book_Author_AuthorId", table: "Book");
            migrationBuilder.AddForeignKey(
                name: "FK_Book_Author_AuthorId",
                table: "Book",
                column: "AuthorId",
                principalTable: "Author",
                principalColumn: "Id",
                onDelete: ReferentialAction.Cascade);
        }

        protected override void Down(MigrationBuilder migrationBuilder)
        {
            migrationBuilder.DropForeignKey(name: "FK_Book_Author_AuthorId", table: "Book");
            migrationBuilder.AddForeignKey(
                name: "FK_Book_Author_AuthorId",
                table: "Book",
                column: "AuthorId",
                principalTable: "Author",
                principalColumn: "Id",
                onDelete: ReferentialAction.Restrict);
        }
    }

My project.json:
    {
      "version": "1.0.0-*",

      "compilationOptions": {
        "emitEntryPoint": true
      },

      "dependencies": {
        "EntityFramework.Core": "7.0.0-rc1-final",
        "EntityFramework.Relational": "7.0.0-rc1-final",
        "EntityFramework.MicrosoftSqlServer": "7.0.0-rc1-final",
        "EntityFramework.Commands": "7.0.0-rc1-final"
      },

      "commands": {
        "EFFK": "EFFK",
        "ef": "EntityFramework.Commands"
      },

      "frameworks": {
        "dnx451": { },
        "dnxcore50": {
          "dependencies": {
            "Microsoft.CSharp": "4.0.1-beta-23516",
            "System.Collections": "4.0.11-beta-23516",
            "System.Console": "4.0.0-beta-23516",
            "System.Linq": "4.0.1-beta-23516",
            "System.Threading": "4.0.11-beta-23516"
          }
        }
      }
    }

Note: the issue is the same with EntityFramework 7.0.0-rc2-16649 on DNX 1.0.0-rc2-16357 (CLR, x86)

Duplicate of https://github.com/aspnet/EntityFramework/issues/3751 which is already fixed in our nightly builds and the fix will ship in RC2.

I see, for the migration problem, thank you.
However #3751 does not mention the second problem, being that EntityFramework returns null when I query the principal object from the dependent object (even though the principal object actually exists in the database) - cf. test case 1 above. Is it somehow related?

Sorry about that... I deal with so many issues each week I have to skim read. Always best to open a separate issue for each bug you hit. Re-opening to look at the second issue.

@sebok - Lazy loading is not available in EF7 see issue #3797
To have values in book.Author you should use Include to tell EF to load Author navigation property.
var book = db.Books.Include(b => b.Author).Where(q => q.Title == BOOK_TITLE).FirstOrDefault();
The second test works because you already queried Authors so book.Author info was available in context.

Thank you very much!


Preprocessor line reader

In https://github.com/metanorma/metanorma-standoc/blob/main/lib/metanorma/standoc/macros.rb , there is code to determine the status of a line during preprocessing of Asciidoctor, pass_status(). That code is used in the LinkProtectPreprocessor, so that lines that are passthrough or comments are not processed by that preprocessor. It needs to be made into a class, and brought into utils, so it can be shared among all line-based preprocessors; that includes metanorma-plugin-preprocessor, per https://github.com/metanorma/metanorma-plugin-glossarist/issues/27

The line processing loop in preprocessors is now exemplified in the following:
    class LinkProtectPreprocessor < Asciidoctor::Extensions::Preprocessor
      def process(document, reader)
        p = Metanorma::Utils::LineStatus.new
        lines = reader.lines.map do |t|
          p.process(t)
          !p.pass && t.include?(":") and t = inlinelinkmacro(inlinelink(t))
          t
        end
        ::Asciidoctor::PreprocessorReader.new document, lines
      end

p.pass is whether the current line is to be passed through, as a preformatted line, or not. In most preprocessors, if the current line is a passthrough line, it needs to be ignored; that includes source code, passthrough, literals...
... and I've just realised: it also needs to include block comments.

I'm adding this to all Preprocessors under Metanorma. @HassanAkbar That includes metanorma-plugin-glossarist

Actually, no: datastruct and lutaml do need to be able to populate sourcecode and even comment text. I'm not going to insert it, at least for now, outside where I already have, the embed and link preprocessors. If we need to change that, we know where the method is.

This did debug some of the detecting of passthrough status, so it was worthwhile.


Error using qap_measures_pipeline

Traceback (most recent call last):
File "/home/demenzbild/anaconda2/bin/qap_measures_pipeline.py", line 10, in
obj.run()
File "/home/demenzbild/anaconda2/lib/python2.7/site-packages/qap/cli.py", line 552, in run
from nipype.pipeline.plugins.callback_log import log_nodes_cb
ImportError: No module named callback_log
Can you pleas help me solving this issue?
Thanks

Hi @tragus1 @rpcary @stefanotambalo
You should install nipype==0.13.1 to get it working:
pip install nipype==0.13.1```

It will remedy the situation. We are working on improve this scenario.

Thank you very much!
I'm going to give it a try.
S.
Stefano Tambalo
Istituto Italiano di Tecnologia
Center for Neuroscience and Cognitive Systems @ UniTN
Corso Bettini 31, 38068 Rovereto - Italy
<EMAIL_ADDRESS>
From: Anibal S?lon<EMAIL_ADDRESS>Sent: Wednesday, September 5, 2018 4:38:16 PM
To: preprocessed-connectomes-project/quality-assessment-protocol
Cc: Stefano Tambalo; Mention
Subject: Re: [preprocessed-connectomes-project/quality-assessment-protocol] Error using qap_measures_pipeline (#120)
Hi @tragus1https://github.com/tragus1 @rpcaryhttps://github.com/rpcary @stefanotambalohttps://github.com/stefanotambalo
You should install nipype==0.13.1 to get it working:
pip install nipype==0.13.1```
It will remedy the situation. We are working on improve this scenario.

You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/preprocessed-connectomes-project/quality-assessment-protocol/issues/120#issuecomment-418755258, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AShpnNZuJwUUn7-sIG-p_VqaIrc0OTsHks5uX-HYgaJpZM4TIDfJ.

Hi, I'm still struggling with runtime errors.
I'm running QAP in a 2.7 virtual env, when I launch the script qap_measures_pipeline, it systematically crashes returning (not considering FutureWarning):
[...]
from nipype.pipeline.plugins.callback_log import log_nodes_cb
ImportError: No module named callback_log
[...]
from cli.py.
Any suggestion/solution?
Thanks in advance.

Hi Stefano,
could you please run this command in your virtual env?
python -c "import nipype; print(nipype.__version__)"

Thanks
Anibal Solon
Assistant Research Scientist
Computational Neuroimaging Laboratory
p:<PHONE_NUMBER>
e<EMAIL_ADDRESS><EMAIL_ADDRESS>Child Mind Institute
445 Park Avenue (entrance on 56th Street)
New York, NY 10022
childmind.org https://aidbox.org/ct/?i=638132000000914&t=1
Em qui, 6 de set de 2018 às 07:04, Stefano Tambalo<EMAIL_ADDRESS>escreveu:

Hi, I'm still struggling with runtime errors.
I'm running QAP in a 2.7 virtual env, when I launch the script
qap_measures_pipeline, it systematically crashes returning (not considering
FutureWarning):
[...]
from nipype.pipeline.plugins.callback_log import log_nodes_cb
ImportError: No module named callback_log
[...]
from cli.py.
Any suggestion/solution?
Thanks in advance.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/preprocessed-connectomes-project/quality-assessment-protocol/issues/120#issuecomment-419054595,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAiVXULy-0N6X8ftOePkdaWG5Pq6b8nNks5uYQFXgaJpZM4TIDfJ
.

Hi Anibal, sorry for the huge delay.
Here's the output in 2.7 virtual env:
/home/*********/anaconda3/envs/py27/lib/python2.7/site-packages/h5py/init.py:36: FutureWarning: Conversion of the second argument of issubdtype from float to np.floating is deprecated. In future, it will be treated as np.float64 == np.dtype(float).type.
from ._conv import register_converters as _register_converters
0.12.1
Thanks!

Hi @stefanotambalo
the output suggests that you are using an older version of nipype (0.12.1). We recommend you to install the version 0.13.1:
pip install nipype==0.13.1

Thank you

Hi @stefanotambalo
it still looks like a nipype version problem.
To reproduce the error outside qap, you can run:
import nipype
print("Nypipe version", nipype.__version__)
print(nipype.__file__)
from nipype.pipeline.plugins.callback_log import log_nodes_cb

Please send us the output so we can try to identify the problem origin.

Hi @anibalsolon,
here's the output:
/home/stefano/anaconda3/envs/py27/lib/python2.7/site-packages/h5py/__init__.py:36: FutureWarning: Conversion of the second argument of issubdtype from floattonp.floatingis deprecated. In future, it will be treated asnp.float64 == np.dtype(float).type.   from ._conv import register_converters as _register_converters ('Nypipe version', u'0.13.1') /home/stefano/anaconda3/envs/py27/lib/python2.7/site-packages/nipype/__init__.pyc
Is it useful?
S.


Create python-publish.yml

Just trying out

We will see about this. at the moment I have no idea how to deploy a python package


The command runs again and again with no exit.


Support the variant type within Snowflake

@alberttwong The JSON type is what you want in StarRocks.

I tried json type and it wouldn't load.  Let me send you what I did.

https://github.com/StarRocks/starrocks/discussions/22777


millet-ls does not terminate when closing the editor

Environment

Millet version: 0.9.0
Editor version: VS Code 1.77.3
OS version: macOS 13.1

Steps to reproduce

Launch vs code
Open a sml folder
Observe millet-ls starts in activity monitor
Close vs code

Expected behavior
millet-ls should not be in activity monitor anymore (the process should quit)
Actual behavior
It remains

Fixed in e326ae2cfbe206972a3feddb6c84b3f8977542a3


add parsing custom data

So I went with little modified second approach. Backend can store and send user data as a dictionary. The dictionary would consist of three fields, required: type (ex. "hyperlink"), value (ex. "https://www.google.com"); and optional: displayValue (a string that if exists will be displayed instead of value).
Custom values are recognizable and parsed by type filed. If type is not recognizable displayValue or value will be displayed as string.
Waiting for feedback 😄
Backend changes: https://github.com/Problematy/goodmap/pull/21
Closes #9

I didn't tell this, but initially I had in mind custom types which casts to specific way of displaying, so (if I understand this code correctly) is great.
As for javascript code I'd like someone else to review this changes.
From my point of view I have one little thing which is not yet common for this repository, but would be nice. It is unit test. :)

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

14 of 15 (93.33%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-5.6%) to 94.444%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/popup_data.js
14
15
93.33%

Totals

Change from base Build<PHONE_NUMBER>:
-5.6%

Covered Lines:
21

Relevant Lines:
22

💛  - Coveralls

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Warning: This coverage report may be inaccurate.
This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

For more information on this, see Tracking coverage changes with pull request builds.
To avoid this issue with future PRs, see these Recommended CI Configurations.
For a quick fix, rebase this PR at GitHub. Your next report should be accurate.

Details

14 of 15 (93.33%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-5.6%) to 94.444%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/popup_data.js
14
15
93.33%

Totals

Change from base Build<PHONE_NUMBER>:
-5.6%

Covered Lines:
21

Relevant Lines:
22

💛  - Coveralls

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Warning: This coverage report may be inaccurate.
This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

For more information on this, see Tracking coverage changes with pull request builds.
To avoid this issue with future PRs, see these Recommended CI Configurations.
For a quick fix, rebase this PR at GitHub. Your next report should be accurate.

Details

14 of 15 (93.33%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-5.6%) to 94.444%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/popup_data.js
14
15
93.33%

Totals

Change from base Build<PHONE_NUMBER>:
-5.6%

Covered Lines:
21

Relevant Lines:
22

💛  - Coveralls


[Service Bus Client] Fix List Doc Comments

Summary
The focus of these changes is to add the needed child elements to the <item> tags of the <list> elements in the doc comments.
Last Upstream Rebase
Monday, April 5, 3pm (EST)
Related and References

Remarks section missing (#20084)
<list> (C# programming guide)

closes #20084


exiftool: bumped to 12.20

Existing package

[x] I am the maintainer of this package.

Mmm. @Vouivre next time please include the manifest :)

@dilyn-corner Because this package doesn't exist on kisslinux/community ?

Just as proof that you built and installed it

For changes like dependencies or formatting the manifest is unecessary but I'd think of version changes like new packages.
I didn't think about it until after I had merged both and I figured you'd only need to hear it once :)
Thank you!


res.updateConfiguration() deprecated in API 25

Hello,
I was reviewing the code of the library and I noticed that it's using res.updateConfiguration() (deprecated in API 25) for all API versions, instead of using the approach described in the article.
https://github.com/YarikSOffice/lingver/blob/083f4e98f43f81d00b33fb62bdc3434ccbfcc0b5/library/src/main/java/com/yariksoffice/lingver/Lingver.kt#L116-L132

Actually, the article contains 2 approaches. I prefer this one since it covers more use cases despite using some deprecated API which are not likely to be removed anytime.
For instance, there is no way to update a locale for application.context using the modern approach via createConfigurationContext.

My bad sorry, I didn't continue reading after "API level 25" section. I've researched a bit more and it makes sense your solution. Thank you very much.


move vagrant configuration to new repository

Create a repository with only VagrantFile and bootstrap script to download and compile rest dependend packages.

Moved to https://github.com/h2020-westlife-eu/wp6-vm. Updated README.md of both repositories.


Expose mods remote status to Squirrel VM

Add a Squirrel VM method to know if a given mod is remote or not (heavily inspired by NSIsModEnabled function).
Used by https://github.com/R2Northstar/NorthstarMods/pull/799

Merging based on reviews.


Display confirmation dialog with preview before pasting and uploading clipboard directly to chat

Maybe display a modal window to preview and then confirm before calling the converse API to upload (to prevent accidental clipboard content/picture leak to the chat).

Good Idea!!

This should do it. Available in version 0.8.6

@deleolajide perfect! Thanks man! (y)


auditore scans

Source name
auditore scans
Source link
https://auditorescans.com
Source language
Português (Brasil)
Other details
No response
Acknowledgements

[X] I have checked that the extension does not already exist by searching the GitHub repository and verified it does not appear in the code base.
[X] I have searched the existing issues and this is a new ticket, NOT a duplicate or related to another open or closed issue.
[X] I have written a meaningful title with the source name.
[ ] I have admitted that I am a clown by having checked this box, as I have not read these acknowledgements.
[X] I will fill out all of the requested information in this form.

This site might be dead

According to the groups uploads on MangaDex they seem to now be be called asgardscans and are using https://asgardscans.com/ as their wbsite

Both of the links are currently dead. Open a new issue if they open another site.


Datatable.net integration feasibility

Hello,
for pivot() (not pivotUI) datatable.net rendering is almost possible,
the only thing blocking is the colspan/rowspan of the headers, because the number of column in the header do not match the number of col in the data.
refactoring the headers to be able to have at least one non empty cell in the tbody for each cell in the thead leads to a working/ filterable/sortable pivot result,
here a jsfiddle with some tweak of the headers demonstrating it working :
https://jsfiddle.net/MVTeraflop/kn381h7s/1188/
I was wondering, if it could be possible to add a default renderer compatible with datatable
in order to produce multilevel headers like in this example
:https://datatables.net/examples/advanced_init/complex_header.html

A couple of responses:

You're welcome to create a renderer that meets your needs and then we can discuss the idea of integrating it or a generalized version into the main library when I get a sense of what it might look like. I don't have any time to devote to building one myself, and I don't think I would want to modify the default TableRenderer at this time.
Does DataTables support multilevel row headers as well as column headers? If not, then special handling will be required for when the renderer encounters multiple row attributes. In the past I have found data-grid-type components to be a poor fit for a PivotTable.js renderer because they are very column-oriented whereas the pivot table is symmetric in its treatment of rows and columns.

Hi, thx for the quick answer

when I get a sense of what it might look like.
you can click on the 'tb2 to datatable' on my fiddle for a first idea https://jsfiddle.net/MVTeraflop/kn381h7s/1188/

You are right for the "very column oriented" of table, but in static reports, it works most of the time
like here : http://rwjblue.github.io/pivot.js/
(do not hesitate to add row by clicking on row label fields)
I will try creating a new renderer for  my project to deals with those extra rowspan and colspan.

Hi, thx for the quick answer

when I get a sense of what it might look like.
you can click on the 'tb2 to datatable' on my fiddle for a first idea https://jsfiddle.net/MVTeraflop/kn381h7s/1188/

You are right for the "very column oriented" of table, but in static reports, it works most of the time
like here : http://rwjblue.github.io/pivot.js/
(do not hesitate to add row by clicking on row label fields)
I will try creating a new renderer for my project to deals with those extra rowspan and colspan.

Hi,
I had a similar use case. Were you able to solve this issue.
I am also trying to incorporate datatable.net and PivotUI.


NumberBox Mode does not work

Hi, tnx for this great control
I tested a little and it seems that there is some issues:
changing DisplayMode in Runtime crash app
<muxc:PagerControl DisplayMode="ButtonPanel"/>

changing DisplayMode to NumberBox does not do anything

Thank you for creating this issue. Unfortunately, I'm unable to reproduce the crash, could you please show the code you used to get the app to crash or attach a repro project?
Regarding numberbox not working, this was a mistake on my end. Version 1.0.1 is out now that has the fix for this.

thank you, both issue fixed.


chore(ci): merge develop to main for NuGet references for examples update

Issue number: 184
Summary
Sync main with develop for NuGet references for examples update post release v0.0.2-preview
Changes
Example NuGet Package

Please provide a summary of what's being changed

User experience

Please share what the user experience looks like before and after this change

Checklist
Please leave checklist items unchecked if they do not apply to your change.

[x] Meets tenets criteria
[x] I have performed a self-review of this change
[x] Changes have been tested
[ ] Changes are documented
[x] PR title follows conventional commit semantics

Is this a breaking change?
RFC issue number:
Checklist:

[ ] Migration process documented
[ ] Implement warnings (if it can live side by side)

Acknowledgment
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

Codecov Report
Base: 56.35% // Head: 56.35% // No change to project coverage :thumbsup:

Coverage data is based on head (f06ba2c) compared to base (f854e95).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #186   +/-   ##
=======================================
  Coverage   56.35%   56.35%
=======================================
  Files          41       41
  Lines        1778     1778
=======================================
  Hits         1002     1002
  Misses        776      776

Flag
Coverage Δ

unittests
56.35% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


SAK-45743 My Connections: update Apache Wicket 8.12.0

Nice @axxter99 !

Do you think is a good oportunity to use a common version of Wicket 9.x?

@mpellicer wicket 9:
Java version This Wicket version requires at least the following Java version: JDK 11.0 or newer.


does frontier support EVM script? or contract call?

like this exec EVM script
https://github.com/aragon/aragon-apps/blob/631048d54b9cc71058abb8bd7c17f6738755d950/apps/voting/contracts/Voting.sol#L355
or call erc20 transferFrom
https://github.com/aragon/aragon-apps/blob/631048d54b9cc71058abb8bd7c17f6738755d950/apps/token-manager/contracts/TokenManager.sol#L318

Yes it does :)

Yes it does :)

You can execute the contract call as following.
https://github.com/paritytech/frontier/blob/master/ts-tests/tests/test-contract-methods.ts#L46

You can execute the contract call as following.
https://github.com/paritytech/frontier/blob/master/ts-tests/tests/test-contract-methods.ts#L46


delete-activity.md requires an update on delete behaviour

Line number 23 on delete-activity.md
In this section, we say that the blob if deleted cannot be recovered. This is only true data lake scenarios where there is no concept of delete markers or versioning. For Azure blob store with soft delete enabled, the deleted blob can be undeleted and recovered.
We need to change this section and make this more explicit for the reader.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 4ba2189a-2668-421f-7332-2d77628cda52
Version Independent ID: a1cef662-7abe-f611-1304-df5d5e9e4444
Content: Delete Activity in Azure Data Factory - Azure Data Factory
Content Source: articles/data-factory/delete-activity.md
Service: data-factory
GitHub Login: @dearandyxu
Microsoft Alias: yexu

@raunakjhawar Thanks for the feedback and bringing this to our notice. At this time we are reviewing the feedback and will provide an update as appropriate.

@raunakjhawar  I have updated the doc as per our discussion.


Req. update(_:) method

I'm working on some prime stuff, and I need a squareRoot(of:) method that doesn't rely on floating points. So, I use Newton's method. It's relatively fast and super simple. In doing so, I noticed that the implementation for core integers and what I might write for UIntXL is similar. UIntXL has an update(_:) method for in-place assignments. If all binary integers had this method, then perhaps I could make squareRoot(of:) and friends generic over all binary integer.

As a side note, I can get a decent initial approximation since I've already added leadingZeroBitCount to NBKBinaryInteger.

Although, in this particular case it might not matter because the allocation is followed by division :man_shrugging:


Application crash when connection becomes unstable

Hi,
I use NetworkAnalyzer to monitor my own internet connection, our ISP has been having issues for over 4 months and I need to send logging/evidence of outages. Scenario:

Latency Monitor
I use 5 hosts: <IP_ADDRESS> / <IP_ADDRESS> / <IP_ADDRESS> (DNS Servers) and google.com and tweakers.net
When package loss hits around 30% across all hosts (monitored through a little powershell script with those 5 same hosts) NetworkAnalyzer crashes and I can't generate a report for that session.

The way the reports are generated by NA are brilliant and are very good evidence in my fight with the ISP. Can replicate every time.

Hmm, interesting that it crashes then. I'm currently working on implementing local session data storage so even when a crash occurs you won't lose any data logged up until that point. This will help alleviate the issues of losing data. I'll look into why it would crash at that point though and work on a fix to have out with the next build.

In case it matters, Windows 11 23H2, tried on 24H2 as well and it's the same. Just a LAN connection. If you find it hard to replicate, can help and do some testing.
Sidenote: Happy to see feedback so fast and taken seriously :)

Always good to have feedback on things and be made aware of problems. My intention is to write a piece of software that is stable and usable so I welcome any user input.
As I'm still learning C#, I can't promise I'll have an immediate fix for some issues (though this one I have an idea of where the problem is), but I'll do my best to fix any actual bugs brought up.

@benjaminwanders I believe the issue here is probably that I was not properly disposing of the Ping class when each instance was finished. I've since added logic to dispose of each Ping instance upon completion which should resolve this issue.
Just in case there are other contributing factors here, I've also added logging which should help with further troubleshooting this issue.
These changes will be available in Version 1.6.0, which should be available soon, once I finish testing the changes I've implemented.


unified-signatures incorrectly reports a violation and enters an infinite loop

Bug Report

TSLint version: 5.4.2
TypeScript version:2.5.0-dev.20170808
Running TSLint via: CLI or Atom

Consider the following snippet:
// These overloads can be combined into one signature taking `T[][] | Array<T | T[]>`. (unified-signatures)
unnest<T>(x: Array<T | T[]>): T[];

So one attempts to fix it like requested:
These overloads can be combined into one signature taking `T[][] | T[][] | Array<T | T[]>`. (unified-signatures)
unnest<T>(x: T[][] | Array<T | T[]>): T[];

So one attempts to fix it like requested:
These overloads can be combined into one signature taking `T[][] | T[][] | T[][] | Array<T | T[]>`. (unified-signatures)
unnest<T>(x: T[][] | T[][] | Array<T | T[]>): T[];

So one attempts to fix it...
TSLint config
Just a regular dtslint/dt.json
Actual behavior

unified-signatures violation is reported
fix is made
unified-signatures violation is reported
fix is made
unified-signatures violation is reported
fix is made
unified-signatures violation...

Expected behavior

unified-signatures is not reported since Array<T | T[]> is already unified.
...
profit

I cannot reproduce this with the TSLint 5.7.0 and TypeScript 2.5.1
Can you please upgrade and verify that it's fixed? Otherwise I need a bit more information about your failing code.


oauth2server: fix PostgreSQL compatibility

Sets user_id nullable on Client and Token tables.

Fixes testsuite to completely clean database records after tests are
finished. (closes #3145)

Signed-off-by: Leonardo Rossi<EMAIL_ADDRESS>

ping @jirikuncar


Ausländerbehörde problem

I am trying to get Termine Ausländerbehörde for Residence permit to study.
The telegram part sticks after "Fetching available appointment types..." as you can see the picture
https://drive.google.com/file/d/199clrziXmMr4HKZ4JFWy6VWVW0cfevyW/view
And I don't know whether "appointments = get_termins(ForeignLabor, 'Niederlassungserlaubnis allgemein')" line in the termin_api.py works or not. Because I always get "ERROR: cannot find termins data in server's response. See log.txt for raw text" message, I put an inifinity loop in main function, but I don't get any appointment messages for 2 days.

Thanks for the report!
Should be fixed now. ABH introduced yet another level of check (so far it's easy fixable, but I don't like the trend).


Fix errors/warnings found by the linter

Fix errors/warnings found by the linter at #861.
Extracted from #861 to easier review.

Friendly ping to @justinfagnani!


Update usage instructions

Could you please update the README with instructions on how to use the generated file?
I am using the template using flavours but was unfortunately not able to load the theme in doom emacs.
Any help would be appreciated.

The generated file should be named doom-base16-theme.el. It should be placed in the custom-theme-directory, which by default is .config/doom/themes


Update go version

Build log
Preview build with this PR (commit): https://252-280922552-gh.circle-artifacts.com/0/index.html


prisma.yml via CLI argument

Is your feature request related to a problem? Please describe.
Almost all CLI tools provide a flag (usually -f) for changing the path to the configuration file.
Describe the solution you'd like
Prisma CLI should support -f/--file flag to provide the path of prisma.yml file
Describe alternatives you've considered
Currently, I have to namespace multiple projects into their own folders.

I like this suggestion!
What commands would this apply to?
prisma deploy already uses -f/--force.
What would happen when there is a .graphqlconfig.yml that points to a different prisma.yml - what about .env files, which would be used? The one in the current folder .env, or the one in the same folder as the prisma.yml file?

Local scope should resolve first i.e. -f should be used even if there is a .graphqlconfig.yml file.
It sucks that -f can't be used anymore, I will use -f as a placeholder for the actual flag until we choose one.
This will apply to app prisma commands that use a prisma.yml internally.

We can use -c <path> or --config <path> to point to a prisma.yml file since -f/--force is not available.
CLI flag takes higher precedence over any other method of prisma.yml resolution.

This is available in the latest alpha - 1.28.0-alpha.13, please install it via npm install -g prisma@alpha.

This is available in the latest beta 1.29.0-beta, please install it via npm install -g prisma@beta.

I'm running Prisma with Nexus and have a post-deploy script running on my prisma.yml.
npx nexus-prisma-generate --client ./src/generated/prisma-client --output ./src/generated/nexus-prisma
When that runs, I get the error: Could not find prisma.yml file. Anyway to specify the path for prisma.yml when executing nexus-prisma-generate?

This is available in the latest stable, 1.29.x, please install it via npm install -g prisma.
As the issue regarding a similar flag in nexus tooling is tracked in its own issue, I am closing this issue, please reopen a new issue if required.


#166541932 FetchApi office application

What does this PR do?

Lets a user apply for office from the site UI
Description of Task to be completed?

[x] Create a class for office application.
[x] Update the application form fields to allow a user to pick from a predefined offices
[x] Notify user when the application has been submitted successfully

How should this be manually tested?
After cloning the repository to your local machine - check
README.md for instructions. Checkout the branch ft-fetchApi-express-interest-166541932 open the index.html page to serve the homepage. Signup a new user or user an existing user.
On the dashboard open the vie for office option. Fill in  the form with the appropriate details such as an existing party name.
Any background context you want to provide?
Allows user to vie for office and await admin approval
What are the relevant pivotal tracker stories?
#166541932

Coverage remained the same at 97.452% when pulling c6b4e9f53f34ebcf0bb908d66bf0887d6b25873f on ft-fetchApi-express-interest-166541932 into 4f7168876fef2649d33c7972c88a12c4ea5d9276 on develop.


View/Menu alias for GetState

Just like Menu/View alias for the other structs

Hi @ifarbod, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. Real humans will now evaluate your PR.

TTYL, MSBOT;

I didn't add this to State because you already have aliases:
bool __cdecl IsBackPressed() const { return buttons.back; }
bool __cdecl IsViewPressed() const { return buttons.back; }
bool __cdecl IsStartPressed() const { return buttons.start; }
bool __cdecl IsMenuPressed() const { return buttons.start; }


Heterogeneous comparisons for Option

It would be useful to be able to compare Option<T> with Option<U> if T and U are comparable themselves. I.e.
impl<A, B> PartialEq<Option<B>> for Option<A> where A: PartialEq<B> { ... }

assert!(Some(String::from_str("str")) == Some("str"))

Heterogeneous comparisons for Option are clear and unambiguous and there are precedents - some other basic library types, like Vec or [T] support heterogeneous comparisons too.
cc @aturon
cc https://github.com/rust-lang/rust/pull/22838

For some reason after this change Some("str") == None can't infer the type of None despite the fact that PartialEq has default type parameter.
At the same time Some(0u8) == None still can infer the type of None.

Default type parameters do not currently drive inference, iirc.

There is an issue open for generalizing comparison across all types in std. This is mainly a matter of what's been implemented, rather than a strong philosophical stance.
cc https://github.com/rust-lang/rust/issues/20927 as well.

Potentially leads to widespread type inference regressions, when x == y can not hint the type for y anymore.


User Story 12- As a Regional Strategist, I require access to the top N populated capital cities within a continent, with N specified based on strategic considerations, to analyse regional economic competitiveness, assess political influence, and develop strategic plans for regional development and cooperation

tasks to complete
Connect to the existing database.
Add function to retrieve data on population
Add function to retrieve data on capital cities
Add function to retrieve data on continents
Generate report

SELECT population, name AS CapitalCity, continent
FROM country;
-- retrieve data on population, continent and Capital city


Refactor tests using ArrangeCollectionTestCases to expanded cases

@leandromoh Can you refactor tests using ArrangeCollectionTestCases to use the technique demonstrated in PR #424? The idea would be to expand the test cases to be more explicit instead of looping internally.

I'm working on this one right now.

@atifaziz Sorry, I forgot about It. Too busy.

@Arithmomaniac Thanks!
@leandromoh No worries.


Change dynamicTyping value

The CSV parser won't parse the title of the task as a text if it consists the only numbers.
After I've changed this param locally my sync works fine.

Sorry for taking so long to merge this in; the project got put on the backburner for a while. And thanks for the fix!!


New Themes!

Added Setting Menu Option

Change Theme, Toggle Sticker on/off, view version, and see changelog

Added 5 new themes based on various new characters!

Re:Zero:

Emilia (Dark/Light Theme)

Danganronpa:

Mioda Ibuki (Dark/Light Theme)

Hatsune Miku (Dark Theme)

[ ] Selection fixed


cmd/pprof: go tool pprof starts the prof without binary

go version go1.4.1 linux/amd64
go tool pprof cpu.prof

Entering interactive mode (type "help" for commands)
(pprof) top
10.29s of 10.29s total (  100%)
      flat  flat%   sum%        cum   cum%
    10.29s   100%   100%     10.29s   100%

where i should have typed this
go tool pprof mybinary cpu.prof

I did fail to read the help correctly so it is my own fault - but it gave me no indication i did anything wrong.
ref: https://groups.google.com/forum/#!topic/Golang-Nuts/dd9QwwGdt34

Note: Only Googlers can work on this, because pprof in go 1.5 is just a copy of internal source according to https://github.com/golang/go/blob/master/src/cmd/pprof/README

Not true. Hack on Go's version at will. We'll deal with synchronizing with Google's version occasionally in batches.

Starting a pprof without the binary is still helpful if the profile contains symbol info like when fetched via the net/http/pprof endpoint.

This keeps tripping people up (see #14324 for instance). Is it possible for pprof to give an error, or at least a warning, if it detects this bad usage? (i.e. no binary and the profile doesn't contain the necessary symbols itself to be useful.)

@rakyll my report we discussed was a duplicate, here is the one you might want to track :)

From the 1.9 release notes ( https://golang.org/doc/go1.9#go-tool-pprof )
Profiles produced by the runtime/pprof package now include symbol information, so they can be viewed in go tool pprof without the binary that produced the profile.

I think this can be closed.

Yay.


fromJson raise JsonError with valid json

Hello,
It seems jsony json parser has issue parsing some floats with E scientific notation.
Here's the minimal exemple code to reproduce the issue:
import jsony
import std/json

let s = r"""[9e-8]"""
#echo s
echo parseJson(s) # std json parse works
echo fromJson(s) # Invalid float. At offset: 5 [JsonError]

Some running context:

Nim Compiler Version 1.6.0 [Windows: amd64]
jsony installed with nimble install jsony today (2021-11-04)
throw in release or debug mode, no other compiler flags used

The Issue
The payload [9e-8] is a valid json and std/json or python json parser handle it without raising errors.
Jsony should be able to parse it successfully.
Please note that, for now, I only encoutered this error with this specific value 9e-8.
Other values parsed with jsony (even those in E scientific notation) are successfully parsed.
Regards.

Thank you for reporting the issue!
I have found and fixed bug in json-in-json number handling.


Update F# language reference index to point to FSharp.Core api ref

Link out to here for interested folks: https://fsharp.github.io/fsharp-core-docs/
Since the MSDN stuff is kaput and has been for quite a while
Plus it looks nicer :)

A problem remains that if you search https://docs.microsoft.com/en-us/dotnet/fsharp/ for eg. "List.allPairs"  you get no results https://docs.microsoft.com/en-us/search/?terms=allPairs&scope=.NET when the page you need is at https://fsharp.github.io/fsharp-core-docs/reference/fsharp-collections-listmodule.html#allPairs

A problem remains that if you search https://docs.microsoft.com/en-us/dotnet/fsharp/ for eg. "List.allPairs"  you get no results https://docs.microsoft.com/en-us/search/?terms=allPairs&scope=.NET when the page you need is at https://fsharp.github.io/fsharp-core-docs/reference/fsharp-collections-listmodule.html#allPairs