License headers in source files is wrong

Package Name:

All
Describe the bug
We currently state the phrase in our code, including auto-generated code:
// Licensed under the MIT License. See License.txt in the project root for license information.

But this is not where the license file is.  It's called "LICENSE", and the header comments should be changed to reflect this.

We have a list of officially blessed copyright headers for various languages here (Microsoft Internal, sorry).
Also, the LICENSE.md file must be included in the package. I'll update the guidelines to be more clear about this.

Reposting here for those who do not have access:
// Copyright (c) Microsoft Corporation. All rights reserved.
// Licensed under the MIT License.

I believe with latest efforts on enabling the eslint plugin v3 on all our packages, we have the below copyright
// Copyright (c) Microsoft Corporation.
// Licensed under the MIT license.

@joheredi Does the code generator have a default copyright text to use or relies on the user to provide one? If it has its own, then we should update it to use the above text


plain-craft-launcher: Add version 2.7.1

Plain craft launcher is a popular Minecraft launcher.

[x] I have read the Contributing Guide.

Thanks for opening a pull request :slightly_smiling_face:
As I understand it, this launcher allows playing Minecraft without having purchased the game, so I'm afraid I can't accept it in scoop-games for legal reasons.


systemd-boot-builder.py: fix crash, clean up code

Motivation for this change
Fix a crash introduced in e2be5dc1f4f12eaab10ae2311d293c114868ca1b and clean up the code to improve coding style consistency, match Python 3 best practices and make the script more readable and easy to maintain overall.
Followed PyLint's advice, which now rates the file 10.00/10 with these reports disabled:
invalid-name,missing-docstring,wrong-import-position,unspecified-encoding
line-too-long,too-many-locals,too-many-branches,too-many-statements

(changes are grouped, so per-commit diffs are a lot clearer than the PR's unified one)
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[x] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
22.05 Release Notes (or backporting 21.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

I spent ~30 minutes reading through these changes, and no issues jumped out. Overall it's a huge improvement in code quality. The test suite over at nixos/tests/systemd-boot.nix still seems to pass (if I ran it correctly).

cc better python devs than I. @FRidh @Mic92

also CC @danielfullmer who wrote the tests, @Enzime who authored and @pennae who reviewed #150408

I would suggest splitting this into two commits, one that changes the coding style and the other that fixes the crash, that would make it a lot easier to review.
Also can you write a test case for the specific crash this fixes?

+1 that https://github.com/NixOS/nixpkgs/pull/155054#issuecomment-1021806207 should be reverted before this is merged

I also did not saw any concerns when reading the code. But maybe address @edrex comment from above.

I also looked through these changes and they are looking good to me.
This should fix #159623.
Can I help to speed this up? (I am currently affected by this and am "motivated" :/ )
@Enzime what kind of test should be written where for this script? The only place where I see it referenced is the nix file next to it and that does only do a static code check with mypy during installation to the nix store:
https://github.com/NixOS/nixpkgs/blob/6471f13deae7ca4e36a6aac5b6e5ae09004ab066/nixos/modules/system/boot/loader/systemd-boot/systemd-boot.nix#L50-L59
There are some tests for the systemd-boot setting in nixos/tests/systemd-boot.nix but the bug that should be fixed in this PR is in the python script: undefined variable profile in line 230:
https://github.com/NixOS/nixpkgs/blob/e2be5dc1f4f12eaab10ae2311d293c114868ca1b/nixos/modules/system/boot/loader/systemd-boot/systemd-boot-builder.py#L220-L230

@lucc AFAIK this doesn't have a fix for https://github.com/NixOS/nixpkgs/issues/159623, which is a regression from https://github.com/NixOS/nixpkgs/commit/ce8c102a468a795fca428d2e9576652ad8d13e59. Reverting that change should fix the error reporting, revealing the underlying error (in my case it was ENOSPACE, indicating my boot partition was full). Since this branch hasn't been rebased since that was merged, there would be a merge conflict i guess.

Since https://github.com/NixOS/nixpkgs/commit/ce8c102a468a795fca428d2e9576652ad8d13e59 has been backported to 21.11, I think that should be reverted in a separate commit before this is merged, and then that commit can be backported. @m-bdf do you want to rebase prepending a revert commit since this seems ready to merge otherwise?

Resolved the merge conflict and force-pushed. Can confirm this PR solves https://github.com/NixOS/nixpkgs/issues/15962 for me (i. e. garbled error messages).
I think we should either merge this or revert the regression quickly, as this is a pretty non-obvious pitfall and risks people inadventingly booting into old generations.

Thanks everyone for taking the time to review this PR :two_hearts:
@edrex for some reasons I won't explain here, I've been working on a NixOS live USB for a few days already, and trying to clone the nixpkgs repo (unsurprisingly) freezes the entire system, so I haven't been able to revert ce8c102a468a795fca428d2e9576652ad8d13e59 yet.
In the meantime, @sternenseemann rebased this PR on master, resolving the conflict and making it mergeable as-is, without creating a proper revert commit. Thus, do you think backporting 7c21a5f6e54ece0fd74534ebf6663261bfaaf3a1 (or even this entire PR) would be reasonable?

sorry slow response, some time AFK

do you think backporting https://github.com/NixOS/nixpkgs/commit/7c21a5f6e54ece0fd74534ebf6663261bfaaf3a1 (or even this entire PR) would be reasonable?

It seems like just backporting the regression fix would have the smallest impact, but I'm new here so not sure what the guidelines are for backporting. I feel like a fix should definitely be backported since the regression was.
Also, didn't mean to steamroll @Enzime's request:

Can you write a test case for the specific crash this fixes?

At least characterizing the crash seems like good process.

I also think we should only backport a fix and not the whole refactoring part of this pr.

Thanks for your review @FRidh!
I'm working on the changes you've suggested, using pathlib.Path everywhere is quite a big change though, so it's going to take a bit of time to implement properly :smile:


IOU - After creating expense, adding receipt shows error

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: 9.0.17
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team
Action Performed:

Go to https://staging.new.expensify.com/home
Tap fab - new workspace
Open a workspace chat
Create a expense
Open the expense created and tap plus icon and try to upload a receipt

Expected Result:
After creating expense, adding receipt must not show error "The receipt didn't upload. Download the file or dismiss this error and lose it."
Actual Result:
After creating expense, adding receipt shows error "The receipt didn't upload. Download the file or dismiss this error and lose it."
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[x] Android: Native
[x] Android: mWeb Chrome
[ ] iOS: Native
[ ] iOS: mWeb Safari
[ ] MacOS: Chrome / Safari
[ ] MacOS: Desktop

Screenshots/Videos
Add any screenshot/video evidence

https://github.com/user-attachments/assets/0524cfc7-0dee-48b1-a52d-d835db537713
View all open jobs on GitHub

This appears to be fixed for me on staging - asking QA for a retest

Bug is fixed
https://github.com/user-attachments/assets/a382eb36-fef4-40a6-bdf5-597128bc77c3
https://github.com/user-attachments/assets/01c82c99-c827-4c07-b474-5aea62890251

Nice


refactor: ESlint migration & prettier

fixes: #1719
fixes: #1271

Nico... I am soo sorry :< and you probably know why. But this prettier was so nicely configured by default and that array-type looks much better now >_<

travis... hello? I have removed TSlint -.-

@nicojs help... Travis hates me ;-;

IT'S GREEN YAAAAAAAAS 🎉

@nicojs If you could check & possibly merge this it would be nice <3 :3

This looks really good! I'll have a closer look later today and if everything goes well I'll merge it. Thanks a lot! 👍

I've added configure to fix-on-save in vscode.
I absolutely love some of the rules eslint brings to the table. We enable more rules :). For example @typescript-eslint/no-floating-promises. There is no reason to have dangling promises, and they probably all bugs. Enabling the rule will show a couple of bugs. We can enable rules in separate issues IMHO, not in this one.

Love it @nicojs! For now it would be nice if you merge it. Then we can discuss other rules which should be changed! (Take a consideration that for now @typescript-eslint is ~beta version - it doesn't have all features it had before, and so some are missing like ordered-imports [unless they changed it in some last versions])

Yeah, I've tried to enable ordered imports. It works, but it doesn't have the autofix feature: https://eslint.org/docs/rules/sort-imports

The --fix option on the command line automatically fixes some problems reported by this rule: multiple members on a single line are automatically sorted (e.g. import { b, a } from 'foo.js' is corrected to import { a, b } from 'foo.js'), but multiple lines are not reordered.

Never mind that for now.  Thanks a lot once again. Logging off for tonight 🍻


Unpack list into named variables

bb_unpack LISTVAR var1 var2 ...
would set var1=${LISTVAR[0]}, etc.
Stop assigning once the list is empty.

Similar, bb_rename ITEM1 ITEM2 ... var1 var2 ... to set var1=ITEM1, etc.
Useful so you can do this in a function: bb_rename "$@" foo bar


Crosslinking

Here is the updated WebSTR links, Orphanet, GARD, and good ol MedGen

Did you want me to just grab the json, or include any of the other files?

I grabbed just the json and did some manual merging, so all this info is in now.


Typing next/navigation

Apologies for multiple issues this week. Trying to type all the things with the new next13.
I notice that useRouter is typed only from the next/link import and not the new next/navigation module, and I was wondering if it will be supported in the future.
Thanks for the great package!

@litewarp No apologies necessary, I appreciate you taking the time to open issues. It’s easy to encounter a rough edge in a library and move on without giving any feedback.
Thank you for pointing that out, I can certainly add support for next/navigation in the next few days.

Hey @litewarp I did some investigation here and Next's app directory now uses strings for Link and useRouter -- removing the ability to use the UrlObject form.
https://github.com/vercel/next.js/discussions/41745#discussioncomment-4239793

A workaround is using route from nextjs-routes: https://github.com/tatethurston/nextjs-routes#what-if-i-need-a-runtime. Eg:
import { useRouter } from 'next/navigation';

useRouter.push(route({ pathname: "/api/foos/[foo]", query: { foo: "foobar" } }));

Closing because this reflects the API that the nextjs team chose for the new app directory. If you would like to see this implemented, you can voice that here. I'm happy to revisit this if next/navigation becomes type-able beyond string

NextJS now supports this via an experimental configuration option: https://beta.nextjs.org/docs/configuring/typescript#statically-typed-links

If there is sufficient interest in porting this functionality to nextjs-routes I'll look into it, but my current recommendation is that folks use next's builtin capability. Note: this only applies to app directory routes -- there is not route type generation for pages directory.

would be great for those who cant migrate to next 13

@tran-simon next/navigation comes from next13, could you explain your use case?

I'm on next12, I would like a way to type search parameters.

@tran-simon can you provide a code example?

For path `www.myapp.com/organization/myorg?user=user
  const { query, push } = useRouter();

  const {user} = query

  // ...

  push({
    query: {
      user: 'test'
    }
  })

It would be great to have user strongly typed. That way, if in the future I rename user to something else typescript will complain if I forget to rename it in some places

@tran-simon did you mean to post on  https://github.com/tatethurston/nextjs-routes/issues/39 instead ?


Fixes issue with terraform destroy of RDS on AWS

[#145883965]
terraform now sets the flag to create snapshots on deletion to true and throws an exception if the snapshot identifier is not provided. This PR provides the final snapshot identifier.

Hold off merging this, there is an issue with multiple runs with the same final identifier

It is good for merge now - I am explicitly setting the skip_final_snapshot to true, instead of defaulting it to false. With false it requires a snapshot identifier which has to be unique across runs. Skipping was the previous behavior.


Data classification: VS would be crash when selecting the column to predict after switching from file to SQL Server Database File data source and vice versa.

System Information (please complete the following information):
Windows OS: Windows-11-Enterprise-22H2
ML.Net Model Builder 2022: <IP_ADDRESS>6203 (Main Build)
Microsoft Visual Studio Enterprise: 2022(17.5.5)
.Net: 6.0, 7.0
Describe the bug

On which step of the process did you run into an issue:
VS would be crash when selecting the column to predict after switching from file to SQL Server Database File data source and vice versa.

TestMatrix
File1: https://testpass.blob.core.windows.net/test-pass-data/wikipedia-detox-250-line-data.tsv
File2: https://github.com/dotnet/machinelearning-samples/raw/main/samples/modelbuilder/MulticlassClassification_RestaurantViolations/RestaurantScores.zip
To Reproduce
Steps to reproduce the behavior:

Select Create a new project from the Visual Studio start window.
Choose the C# Console App (.NET Core) project template.
Add model builder by right click on the project.
Select "Data classification" scenario.
On the Data page, choose attached "File1" data source and "Sentiment" column to predict.
Choose attached "File2" SQL Server Database File data source.
VS would be crash when selecting any column to predict.

Expected behavior
Select any column to predict successfully after switching from file to SQL Server Database File data source and vice versa.
Gif

Additional context

The bug is still repro on the latest main build <IP_ADDRESS>6803. And now even more serious, once you switch to another file, the bug would be repro.

The bug has been fixed on the latest main build <IP_ADDRESS>7401.


Architecture: NKG operator

TODO: Refine
Design operator (a conceptual operator NOT a RedHat Operator) and relationship to GatewayClass and data plane fleet and control plane.
Deployments, DaemonSets, leader election, namespace awareness, tenant and data plane isolation between classes.
An NMS solution for cluster load balancer.

No use case for this at this time.


WIP: Test 'Blob.rewrite' w/ 'user_project' set.

Note that both new tests are failing.

@frankyn notes offline:

Rewrite has a known issue with userproject and the Storage team has a fix for it, but pending review and release. I'll keep you posted.


add additional field into node for autograd

I feel like there is a growing requirement for row-stored attribute in graph (just like your proposal). Could we discuss more on this? For example, will map<string, shared_ptr<any>> be a better abstraction?

You can put map<string, shared_ptr> into any


Cleanup the repo

Let's remove unused things like python test scripts and test docker files from the repo.

Python scripts were already removed. Closing for now. Let's keep cleaning as we go.


User signout  is not working.

Hi @acoulon99 ,
I tried to use your project to learn how to use token authentication with MEAN.js, but user signout is not working. I think, it is because missing the post from angular view, but I am learning Angular and Node.js and I don't how to fix it yet.
Thank you very much. :+1:

@acoulon99  I am trying to use token authentication with version 0.4.0 of MEAN.js. I used your code with jsonwebtoken instead jwt-simple. https://github.com/ricardodovalle/meanjs-token-auth
I will appreciate any help or suggestion, I am a Node.js beginner.
Thanks.

Hey,
Sorry for the delay. I was pretty busy with a couple of things.
You are correct, user signout isn't working yet, and there are a number of loose ends that need to be tied. We're needing this internally as well, so this is perfect timing. I'll be working on this again starting today and into next week.

I'll also be updating the documentation which should help you apply this to your own deployment of the MEANjs stack.

Hi @acoulon99, thank you very much :+1:
I create a thread inside mean.js github project too.

Ok, I updated the project a bit.
Signout should work now, but not from the Angular web app yet. I added a couple of test cases to the test folder which should demonstrate how the end point works. I'm also going to work on a set of instructions for building and deployment as well as highlight the key changes I've made while including tokens.
It's still a young project, but hopefully with community help we can make a solid tool that others can reference. Some next steps include removing/refactoring most of the Angular app so that it's simpler to learn from.


fix: adjust alarm toggle variable

:tada: This PR is included in version 1.3.1 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


sync: require kernel version >= 5.3 to try using copy_file_range

Codecov Report

Merging #2331 (d11f467) into main (6dbc25b) will increase coverage by 0.02%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #2331      +/-   ##
==========================================
+ Coverage   61.68%   61.70%   +0.02%
==========================================
  Files         137      137
  Lines       25400    25400
==========================================
+ Hits        15667    15674       +7
+ Misses       7906     7905       -1
+ Partials     1827     1821       -6

Impacted Files
Coverage Δ

pkg/meta/redis.go
71.87% <0.00%> (ø)

pkg/meta/redis_lock.go
76.33% <0.00%> (+1.52%)
:arrow_up:

pkg/sync/sync.go
45.61% <0.00%> (-0.87%)
:arrow_down:

pkg/meta/tkv_mem.go
87.86% <0.00%> (-0.58%)
:arrow_down:

pkg/meta/base.go
71.44% <0.00%> (-0.15%)
:arrow_down:

pkg/meta/tkv.go
76.11% <0.00%> (+0.10%)
:arrow_up:

pkg/meta/sql.go
66.04% <0.00%> (+0.27%)
:arrow_up:

pkg/meta/sql_lock.go
72.84% <0.00%> (+1.32%)
:arrow_up:

pkg/meta/tkv_lock.go
83.91% <0.00%> (+1.39%)
:arrow_up:

... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 490cd9f...d11f467. Read the comment docs.


attempt to assess/merge the dot-finder into cooltools

trying to merge into cooltools with https://github.com/sergpolly/cooloop
trying git repo merge (subtree-kind of)
independent code assessment

readme/license etc - tiny issues resolved
loopy.py inside ./cooltools would be the main source file
old_loopify.py is legacy stuff - needed for now to perform tests (could be removed)
plotools - just some plotting , could be removed potentially
tests are UBER-important for the progress (!) only dot-finder tests for now including some mock data ...
tests are passing with cooloop/dotfinder inside cooltools !
Could you guys take a look at the current stage and let me know if this kind of code needs much more work/little work/etc to be merged into cooltools/master ? How critical is to have legacy stuff removed ? etc ? again loopify.py and tests are the main players here.
also being inside cooltools would make it easier to make a CLI version - would be nice for capturing the entire picture/protocol of loop-calling

cleaned up and removed a lot of legacy stuff, tests are passing - ready to merge, I'd say


Could not find the skeleton for Anim Blueprint

Hi, @yuokamoto,
When I open the 'ABP_RRMany' Animation Blueprint, following error occurs:

This issue causes the following errors when packaging the game.
Error: [AssetLog] /home/user/UnrealProjects/turtlebot3-UE/Plugins/RapyutaSimulationPlugins/Content/Character/ABP_RRManny.uasset: [Compiler] ABP_RRManny  - The skeleton asset for this animation Blueprint is missing, so it cannot be compiled!

I have tested under the following condition.

Ubuntu 22.04
UE 5.3.2
turtlebot3-UE (branch: jammy_UE5.3)
rclUE (branch: UE5_devel_humble)
RapyutaSimulationPlugins (branch: UE5.3)

I update UE5.3 and confeirmed packaging work in jammy_UE5.3

Close issue #283


oControl.getHeight is not a function

Master branch just doesn't work (Home page cannot be opened).

Uncaught TypeError: oControl.getHeight is not a function
at Object.BaseChartJSRenderer.render (BaseChartJSRenderer.js?eval:27)
at Object.R.renderControl (RenderManager-dbg.js:773)
at Object.I.render (IconTabBarRenderer-dbg.js:86)
at Object.R.renderControl (RenderManager-dbg.js:773)
at Object.P.render (PageRenderer-dbg.js:131)
at Object.R.renderControl (RenderManager-dbg.js:773)
at Object.N.render (NavContainerRenderer-dbg.js:67)
at Object.R.renderControl (RenderManager-dbg.js:773)
at Object.X.render (XMLViewRenderer-dbg.js:111)
at Object.R.renderControl (RenderManager-dbg.js:773)

workaround for this error is adding width and height property metadata in the BaseChartJS.js
height : {type : "string", group : "Appearance", defaultValue : "0"},
width : {type : "string", group : "Appearance", defaultValue : "0"},

Hey, do you perhaps know (presuming I set circumvent this error by deleting that part of code) how to set the chart height property? Preferably in percentages?
Thanks


Not actually moving the symlinks when switching branches in the presence of subdots

Luke made a fix in http://gitlab.dotmesh.io:9999/dotmesh/dotmesh/commit/8b5e87189f49116f31d077925fed0d59d6661ec8 - the code that chooses which symlinks to rewrite wasn't stripping subdots off of the Docker mount names, so a container that mounted foo.bar would get restarted when foo changed branch, but the symlink wasn't actually changed.
The test didn't pick this up, as the test containers don't really know if their filesystem has changed or not under them.
Make the test (or a new test) positively confirm that the data under the existing containers changes when they're restarted.

Did this in fc0258f5f71662c5c59bbc9c3847157c13031584, forgo to close the ticket!


Add endpoints for file object and info key editing

New endpoints:
Note: using either of these endpoints does not trigger jobs based on gear rules as per previous discussion
PUT /api/container/container_id/files/file_name
Endpoint that allows editing of file object.
Allowable fields:

type
measurements *
modality

* Must be an array, replaces existing array
Example Request
PUT /api/acquisitions/5984d10adf01e2001433dde8/files/4784_1_1_localizer.dicom.zip HTTP/1.1
Content-Type: application/json

{
	"type": "dicom",
	"modality": "MR",
	"measurements": ["functional"]
}

POST /api/container/container_id/files/file_name/info
Format of request:
# set or delete required, can have both
{
	"set": {},
	"delete": []
}

"set" is a non-empty map of key : value (values may be scalars or complex objects). All keys are added to the info key if they do not exist, or are replaced by the value if they do exist
"delete" is a non-empty list of top level keys to be deleted. If key does not exist, request is ignored.

OR
{
	"replace": {}
}

the value of the "replace" key will be set as the value of the info key for the file. It can be an empty map.

Example Requests
POST /api/acquisitions/5984d10adf01e2001433dde8/files/4784_1_1_localizer.dicom.zip/info HTTP/1.1
Content-Type: application/json

{
	"set": {
		"top_level_key": 123,
		"complex_object_key": {
			"a": 1,
			"b": 2
		}
	},
	"delete": ["keys", "to", "be", "removed"]
}

POST /api/acquisitions/5984d10adf01e2001433dde8/files/4784_1_1_localizer.dicom.zip/info HTTP/1.1
Content-Type: application/json

{
	"replace": {
		"notice": "this is a full replace of the info field"
	}
}

Breaking Changes

None

Review Checklist

Tests were added to cover all code changes
Documentation was added / updated
Code and tests follow standards in CONTRIBUTING.md

FYI @kofalt, @dpuccetti, @ryansanford

@gsfr, @lmperry Is this intention still that editing a file's attributes via these routes will not trigger jobs? That was the intention with the classification change. Let me know if opinions have shifted.
An idea: it could be an opt-in two step process. If the client sends a query param like create_jobs=true or something the backend could make the change, create a batch of the proposed jobs that would be created, and let the user review and cancel or launch the batch depending on their choice?

After discussion with @gsfr offline, changes should spawn jobs and it will be the default behavior. Any change to make it optional can come at a later date if necessary.


Configure language?

Hi, I'd like to know if there's the possibilty to change the language. If so, where's the part of the code to tackle? Thanks so much in advance. Best!

hi there @rossanag, we currently allow you to pass in a language to the api/service via: https://github.com/valhalla/valhalla-docs/blob/master/api-reference.md#directions-options
this seems to be hardcoded to en at present which isnt even a valid language code. it would seem we need to spend a bit of time making this easier for users or lrm to set.
@hanbyul-here @kdiluca what are your thoughts here?

I was reading the link you post, I haven't time to try it to know how difficult it is. But it could be easier to put an example at least of some of the most used configurations options. In my case I need it to be configured to spanish, I guess the 'sp' parameter is the correct one.
I appreciate any hints, thanks

we currently only support en-US and are working on adding other languages. we hope to offer a means by which users who are interested in a particular language can add those translations. you can follow this development effort over here: https://github.com/valhalla/odin/issues
as for what the language would be, if you live in Spain for example you language might be: es-ES

Thanks for your response, I will check this issues. Best!

I second for examples @rossanag , it is true that lrm-mapzen doesn't have exposed function for directions-options yet. This will be another issue and reflected on next update of lrm-mapzen!


Ignore android-patches directory for jest, metro and flow

Please select one of the following

[ ] I am removing an existing difference between facebook/react-native and microsoft/react-native-macos :thumbsup:
[ ] I am cherry-picking a change from Facebook's react-native into microsoft/react-native-macos :thumbsup:
[ ] I am making a fix / change for the macOS implementation of react-native
[x] I am making a change required for Microsoft usage of react-native

Summary

The android-patches directory contains patches where the patch files is named as the same as the file that will be patched. This causes issues when trying to patch package.json, as various tools try to operate on any file that is named package.json unless explicitly ignored.
Changelog

[Android] [Fixed] - Ignore android-patches directory for jest, metro and flow.
Test Plan

Ensuring all PR checks succeed is sufficient.

Is this platform specific config

Never mind this


chore(style/checkbox) force publish

NPM token was invalidated so need to push a trivial change to force publish styles up to the registry.

Did this bump the npm package properly? https://www.npmjs.com/package/@kongponents/styles I still see 2.0.0 here

@xitongzou no we need to make a change to npm packages to accept automation tokens


[SPARK-9437][core] avoid overflow in SizeEstimator

https://issues.apache.org/jira/browse/SPARK-9437

Merged build triggered.

Merged build started.

any suggestions on a test that doesn't require 2 GB of memory?

Test build #38853 has started for   PR 7750 at commit bc1cb82.

LGTM. Could we also check all the other instances where alignSize is called ?

Test build #38853 has finished for   PR 7750 at commit bc1cb82.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

@shivaram good idea.  I updated one more spot where it seems there could be overflow -- I will admit I don't completely understand what is going on there, but the change seems safe.  the only other place its called is https://github.com/apache/spark/blob/master/core/src/main/scala/org/apache/spark/util/SizeEstimator.scala#L217 which is not going to overflow.

Merged build triggered.

Merged build started.

Test build #38877 has started for   PR 7750 at commit 29493f1.

Does the val size = math.min(s1, s2) line need toLong too? it gets multiplied by a big number before being divided by one. I could be missing why it's not needed or can't be done but seemed like a possible issue.

s1 & s2 are already longs, which means so is size -- so no change needed there.
(not that I had checked this before you mentioned it ...)

Yeah its tricky to add a test case for this -- We could do it by refactoring the code and testing a smaller function which takes in the array size as an argument etc. but that'll be a much bigger code change. Since this is a more contained change I'd actually recommend just merging the current diff for now.

Test build #38877 has finished for   PR 7750 at commit 29493f1.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Jenkins, retest this please

Merged build triggered.

Merged build started.

Test build #149 has started for   PR 7750 at commit 29493f1.

Merged build triggered.

Merged build started.

Test build #38932 has started for   PR 7750 at commit 29493f1.

Test build #149 has finished for   PR 7750 at commit 29493f1.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test build #38932 has finished for   PR 7750 at commit 29493f1.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Jenkins, retest this please

Merged build triggered.

Merged build started.

Merged build triggered.

Merged build started.

Test build #162 has started for   PR 7750 at commit 29493f1.

Test build #39039 has started for   PR 7750 at commit 29493f1.

Test build #162 has finished for   PR 7750 at commit 29493f1.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test build #39039 has finished for   PR 7750 at commit 29493f1.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

LGTM. Merging this


Added check to avoid waiting when no transitions are waiting

When starting a new screen there might be some appear transitions we need to play. I added a test to see if there are any, if not, we can start immediately showing the UI.

Fixes #44

Thanks Christian!


Add course bundle spec and examples

Here we "finalize" the course bundle spec and give a couple examples. I based the spec off of the draft quest bundle spec / examples that existed in the repo, as well as some offline thinking and discussions.
Looking for feedback on anything/everything, with particular questions around:

The name course
How to fully qualify labs and quizzes

Leave comments here and we can try to resolve things through discussion on here. If need be we can set up a separate meeting. I'm hoping to have this merged by the end of the week.
Thanks!

 Course bundle spec

After further discussion, we are hoping to use this spec for the future combined ILT/SPL concept. We will create separate GameTemplate and LearningPath specs (which will likely for now be identical to this one but have separate names to support unbundling into separate models and future enhancements that only apply to one or the other)

@eniskonuk thanks for the comments!

I am anticipating that the quiz spec will be added separately (in the not-too-distant future) by @rickcnagy.
I don't have full context on what's in classroom_template nor what it is all used for, but hot labs and fraud protection sound more like runtime concerns than authoring/content concerns. I don't know what instructor modules are.
I'd like to hear more about what you're picturing for course code and version string. @jgan may also have opinions there.

Let's discuss this morning.

I discussed with Enis, and we decided:

Okay for quiz spec to be added separately, but it shouldn't be too long before we get it in.
Hot labs and fraud protection require more thought (I'm still leaning towards this being a classroom [/offering context] concern, but will discuss further with people).
instructor_resources will be added.
Course code is unneeded, as we will use folder names as slugs.
Version string will be added, and we will update proposed website models accordingly (<-- this is likely to be controversial, and we may want a meeting to discuss [cc @jgan]).

@eniskonuk - version_string will be handled at the locale-level; sorry that was unclear. And this bundle spec can handle all of the main features of those that I am aware of. We can expand it if/when we find pieces that we missed.

Alright, based on yesterday afternoon's conversations I added two more commits:

Rename Course to CourseTemplate, since we are standardizing on FooTemplate being the content set, and then Foo being the offered instance.
Added versions as a locale dictionary, specifying that they should be considered decorators and not source of truth for revision history.

Thanks for all the great discussion, everyone - I appreciate everyone taking the time to engage in this discussion. Merging now!


Version Repository URI Paths

Goal
To support URI schema paths for the versions repository.
Motivation
Currently only local paths are support, but there is no reason why Openpype couldn't download versions from cloud storages.
Our use case for this is that we have a project where we cant guarantee that the versions repository path is the same for remote users, but we can provide a download link to a dropbox folder which would be the same for everyone.
Implementation
We would use URI paths to define which type of storage the version repository is on:
file:// > local file system
git:// > git repository
dropbox:// > dropbox folder/link
For backwards compatibility any paths that fail or do not return a URI scheme, should be treated as local file system path.

We should also add special handling for UNC paths as they are used probably mostly for this case and cannot be specified asi URI.

Yeah, I'm guessing it doesnt support UNC paths atm?
In which case that might have to be a different issue.

Yeah, I'm guessing it doesnt support UNC paths atm?

I think UNC paths are supported


[AutoPR hanaonazure/resource-manager] Fixing operation id to be named consistently

Created to sync https://github.com/Azure/azure-rest-api-specs/pull/5666

This PR has been merged into https://github.com/Azure/azure-sdk-for-js/pull/2291


Packaging

Codecov Report

Merging #10 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #10   +/-   ##
=======================================
  Coverage   64.24%   64.24%
=======================================
  Files          13       13
  Lines         660      660
=======================================
  Hits          424      424
  Misses        236      236

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4ccf202...1e6110b. Read the comment docs.


Add .env file support for  option --dart-define-from-file

Proposal
I suggest to make possible to specify .env files to the --dart-define-from-file in addition to the Json format.
Issue
Close #128667
Pre-launch Checklist

[x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
[x] I read the [Tree Hygiene] wiki page, which explains my responsibilities.
[x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
[x] I signed the [CLA].
[x] I listed at least one issue that this PR fixes in the description above.
[x] I updated/added relevant documentation (doc comments with ///).
[x] I added new tests to check the change I am making, or this PR is [test-exempt].
[x] All existing and new tests are passing.

I think every of your suggestion has been applied to the code @andrewkolos.
One step closer to the good state.

This pr should get a lot of attention. This is huge.


useing  sections does not work

useing  sections does not work

i mean sticky section

@iloveaman this library does not have "sticky section", you're very welcome to code it and submit a PullRequest.
This library have normal sections (that are just another view on the RecyclerView child views). A working implementation of it can be seen on our app (https://play.google.com/store/apps/details?id=com.baseapp.eyeem) on the Settings page.


Fatal error no 2, failed to extract bootstrap, iPad4,2 iOS 11.4.1

Hello.
Getting an error with Undecimus-v3.0.0-b31:

Restore rootFS via settings, run jailbreak, let it reset the file system and then attempt to jailbreak again.
Also enable airplane mode and make sure you have find my iPhone turned off when attempting the jailbreak the second time around.

If you read the log it shows the reason why it's failing to extract bootstrap and you can uninstall the tweak in cydia.

Restore rootFS via settings, run jailbreak, let it reset the file system and then attempt to jailbreak again.
Also enable airplane mode and make sure you have find my iPhone turned off when attempting the jailbreak the second time around.

Thanks for this. If I couldn't only get the exploit to work more than 1/10 times.

i have the same error and the same conflicts libssl and openssl, help

@sidmostwanted tried, doesn’t work , but thanks

@devcline have u found any solution to this?

Does anyone knows how to fix this ?? I cant jailbreak my iphone 6s plus 12.1.2


Add functionality for locking user accounts

An admin endpoint should be created to allow locking user accounts.

Initial implementation in 20f5255e0a7c44bb2576568d1f25376421e2ff03


Split up some large command handlers

This PR does two things (in two separate commits, as all of this is likely to be subjective).  It is purely a refactoring and should not change any existing behaviour.  (Okay, okay.  In the vanishingly implausible cases where an app has an empty URL, the print behaviour changes slightly.  Truth in advertising.)

It splits the apps and sqlite command handlers into subcommand handlers.  This removes two levels of indentation from the actual command handling code, to my eye making it easier to track, and creates some visual separation between the subcommand blocks.
It streamlines (in my opinion of course!) the rendering part of the spin cloud apps info command by moving some logic into helper functions, and teasing apart the "what do we want to print" from the actual printing.  I feel this makes it easier to read as a "top to bottom" function by reducing the nested ifs/matches.

Yes, I didn't feel it was worth it for 4-7 lines per block - the logic is mostly farmed out already, just to free functions rather than subcommand associated functions.  I'm happy to do it though if folks feel it worthwhile.

That makes sense to me!


Unshift breaks template conditionals

I haven't spent a long time with either Ractive nor this problem yet, so any direction is much appreciated.
I have the following template with conditional partials:
{{#each items}}
  {{#if attr1}}
    {{> partial1}}
  {{else}}
    {{> partial2}}
  {{/if}}
{{/each}}

The partial calls an expression: {{{ linkify(attr1) }}}.
All is good until I do unshift. To reproduce the error,
var items =  [{
     attr1: 'foo',
     attr2: 'bar'
 }, {
     attr2: 'bar2'
 }, {
     attr1: 'foo1',
     attr2: 'bar'
 }];

// a delayed loop I used for debugging
var i = 0;
setInterval(function () {
  if (i < 3) ractive.unshift('items', items[i]);
  i = i + 1;
}, 1000);

I get error messages from Ractive.js saying Failed to compute "$linkify(attr1..., but attr1 is never referenced unless it's if tested. If I just change unshift to push the problem goes away.

I would be nice if you set up a jsfiddle for this. I'm pretty sure the error comes with a few additional information. Chrome's dev tools can also break on caught errors, so you might want to check why that computation error happens.

Please see the following jsfiddle: http://jsfiddle.net/alchen/jh189yyy/2/
I also found out it is only a problem if I reference attributes of an object in an expression. E.g.
    bar: function (attr) {
        return attr.x + 'bar';
    }

I tried to dig into the code a little bit; This is the best I can tell:

Ractive inserts first item, and calculates `${bar(items-0-attr1)}.
Ractive inserts second item, and sees that items-0 has change and attempts to recalculate the same ${bar(items-0-attr1)}, because it was there earlier.
But the new items-0 doesn't have an attr1, so it throws an error when recomputing the expression.

Push is probably unaffected because the index part of the key path doesn't change. The only clean fix I can think of is to introduce an internal counter and a map from the counter to index so we always known where the xth element is at.

We should really consider rewording this warning, because this is at least the third instance of this question in a little over a month.
@alchen Check out what I wrote in #1951.

The program isn't actually breaking, the failed to compute error is simply a warning that ractive sends in debug mode. Like @martypdx said in the other thread [#1924], the message is harmless other than an annoying console log, and it will get cleaned up in 0.8 due to his work in #1740. For example, I set a new value to pros after four seconds, and there are no after-effects of the warning: http://jsfiddle.net/hLym2xcy/11/

@Madgvox ah, yes, I did realize things are still rendered perfectly; I was just thinking whether the expression should be called at all. Certainly nice knowing it will be taken care of in #1740. Thanks for the reply!


ci: update python workflows to trigger correctly

Updated the Python formatter workflow to trigger on push to main and on pull requests.
Removed unused output from the formatter pipeline and updated Python linter workflow to run only after the formatter workflow is completed.

I think we need to combine the formatter and linter pipeline. workflow_run only triggers on main branch.


On v1.1.4,problem occurs with the node built with PROMPT_MAIN

When with bootstrap v1.1.4
renewCertificates does not work properly on nodes built using "privateKeySecurityMode: PROMPT_MAIN"

Also, if "privateKeySecurityMode: PROMPT_MAIN" is used and built new node with config / start is executed, an error will be issued and the process will end.

The custompriset used in this validation is:
`privateKeySecurityMode: PROMPT_MAIN
#privateKeySecurityMode: ENCRYPT
nodes:
-
#mainPrivateKey: 8B7B3769C2D1CD6B82E01AE6B5B0CC6723FB9ADEE5E70B98580C942FAA75D7A4
mainPublicKey: B473A112CCFFBB60E9A816DC86D97D4C41CED0D2067A1A105313A63E39E3BD5A
#main address = TAA6DP62XPOGLJ7EPOQZOSEBA3CH2QSOXMF4DVOZ`

@fboucquez I investigated the issue.
The error happens in this line:
https://github.com/fboucquez/symbol-bootstrap/blob/dev/src/service/BootstrapAccountResolver.ts#L57
I was able to fix it by copy same method isValidPrivateKey into BootstrapAccountResolver and replace CommandUtils.isValidPrivateKey with BootstrapAccountResolver.isValidPrivateKey
Not sure what is cause but would be good to check other prompts with validation.

Thanks @dusanjp for reporting this issue.
@cryptoBeliever, It's one of those ugly circular dependencies that are hard to detect, related to how imports work, if the files import more than it should.

Hello, @fboucquez I missed your comment. I've checked, and I'm able to:

renew certificates
send link transaction
with strategy PROMPT_MAIN
:+1:


Fix broken urls in README

This fixes broken urls in the README after the restructuring of the docs.

Rebasing with main will fix the docs build

Something went wrong in your rebasing

Something went wrong in your rebasing

Yeah, can't figure out what, though...

Did you update upstream before the rebase?
git fetch upstream
git rebase upstream/main

?

Yup, which is why I'm confused


ActionTargets implementation (WIP)

renamed/adjusted obs N in the config: INVENTORY_N_OBS (<- ITEM_N_OBS), MARKET_N_OBS (<- EXCHANGE_N_OBS), COMMUNICATION_NUM_TOKENS
separated InventoryItem (for sell/use/give) and MarketItem (for buy) classes and fixed other places accordingly, like io/action.py and scripted/baselines.py
implemented ActionTargets in nmmo/core/observation.py, which provide binary masks to indicate valid action parameters
reviewed and changed the skill levels required for using items, mainly using the max over all skills for using armors, ration, poultice (still, specific skill levels required for other tools, weapons, ammo )
extended test_ammo_use.py to include ActionTargets and Observations tests
made the last ammo count (before the fix, the last ammo was used without adding ammo damage)

and some minor edits here and there

Still need to add DESTROY/GIVE-GOLD actions, combat status, and apply the combat status to ActionTargets (i.e., no buy/sell/give/destroy during combat), but created the PR to see if I'm heading the right direction.

Thanks for the review, David!
About the perf test ... yes, the current implementation of ActionTargets mask does slow the system down. Once it is correctly implemented, we should optimize it.

Making ActionTargets has a serious performance issue, so will make it optional.
Would adding it in the config sound good? Thanks, @daveey!


Propagate Disable User Agent Config to Http Client

In #10895 I introduced this config, but I had made an error. I never actually set this config in the final Apache HttpClient that gets created. This fixes that.
Test Plan: Several integration/unit-tests that run as part of the PR use the HttpClient so that should take care of smoke testing.
Side Note: The reason we had to do this was because we were running into a JDK bug we reported in #10894. But I think a better way to avoid this issue to set the http.agent system property, since the commons http-client does this:

Codecov Report
Attention: Patch coverage is 0% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 0.00%. Comparing base (6b0cfeb) to head (56d8697).
Report is 1 commits behind head on master.

Files
Patch %
Lines

...org/apache/pinot/common/utils/http/HttpClient.java
0.00%
2 Missing :warning:

Additional details and impacted files
@@              Coverage Diff              @@
##             master   #12479       +/-   ##
=============================================
- Coverage     46.87%    0.00%   -46.88%
=============================================
  Files          1829     2360      +531
  Lines         96638   129472    +32834
  Branches      15656    20078     +4422
=============================================
- Hits          45300        0    -45300
- Misses        48104   129472    +81368
+ Partials       3234        0     -3234

Flag
Coverage Δ

integration
0.00% <0.00%> (?)

integration2
0.00% <0.00%> (?)

java-11
?

java-21
0.00% <0.00%> (-46.72%)
:arrow_down:

skip-bytebuffers-false
0.00% <0.00%> (-46.87%)
:arrow_down:

skip-bytebuffers-true
0.00% <0.00%> (-46.66%)
:arrow_down:

temurin
0.00% <0.00%> (-46.88%)
:arrow_down:

unittests
?

unittests1
?

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

I am not sure how to test this via UTs. The user-agent config is passed to the Apache Commons HttpClient.
After the client is created, there's no way to verify what the user-agent config value is.  You can refer to org.apache.http.impl.client.HttpClientBuilder#build. The part where this config is used is in the screenshot in the description.
Existing UTs take care of sanity testing the change.

We can extract a method like below and add a UT for this method to check whether the HttpClientBuilder instance is updated with all the targeted configs passed to HttpClientConfig while building HttpClient. WDYT?
  static void setConfigsToHttpClientBuilder(HttpClientConfig httpClientConfig, HttpClientBuilder httpClientBuilder) {
    if (httpClientConfig.getMaxConnTotal() > 0) {
      httpClientBuilder.setMaxConnTotal(httpClientConfig.getMaxConnTotal());
    }
    if (httpClientConfig.getMaxConnPerRoute() > 0) {
      httpClientBuilder.setMaxConnPerRoute(httpClientConfig.getMaxConnPerRoute());
    }
    if (httpClientConfig.isDisableDefaultUserAgent()) {
      httpClientBuilder.disableDefaultUserAgent();
    }
  }

Since the fix is very straight forward, I'll merge it now. We can consider adding a test separately

Created a followup issue https://github.com/apache/pinot/issues/12519


Add tile getters and setters for tilemaps

Adds these blocks:

We currently don't have a way to get/set tiles and walls in tilemaps assigned in variables

I love it. I wonder if it would be a nice simplification to make myTilemap an optional parameter to each of the definitions, available as an expandable argument. By default it would act on the current tilemap.

@eanders-ms the ones in the scene category already work on the current tilemap, these were meant to compliment those.
That being said, I could still make that change! Or maybe just change the shadow block to be the "current tilemap" block instead of a variable.


Banner responsive fixes

Fixing the homepage jump that happens on load. This PR also addresses various responsive issues.

@jhaaaa This should be ready to review now. No rush. Thank you!


implementing the trait Step is not unsafe

Hi and thanks for your crate!
I'm having trouble compiling its dependency RAMP. What I did so far:

Add ramp-primes = "0.4.0" and ramp = "0.5" to my Cargo.toml
rustup toolchain install nightly; rustup default nightly

When I call cargo run, I get this error:
  Compiling ramp v0.5.9
error[E0199]: implementing the trait `Step` is not unsafe
    --> /home/mb/.cargo/registry/src/github.com-1ecc6299db9ec823/ramp-0.5.9/src/int.rs:3697:1
     |
3697 | / unsafe impl std::iter::Step for Int {
3698 | |     fn steps_between(start: &Int, end: &Int) -> Option<usize> {
3699 | |         let diff = (start - end).abs();
3700 | |
...    |
3715 | |     }
3716 | | }
     | |_^

For more information about this error, try `rustc --explain E0199`.
error: could not compile `ramp` due to previous error

cargo version gives:
cargo 1.57.0-nightly (d56b42c54 2021-09-27)

I've had this issue for awhile now. No clue how to fix it.
I suggest you look at num-primes instead. It uses num as opposed to RAMP which does not use unsafe code like RAMP. Its maintained more than this crate and compiles.
Both crates also have the exact same API as num-primes is based on ramp-primes.
Hope this helps!


[BUG] "\n" or "\r\n" separator supported in UTILITY > List > Join?

Not sure if this is bug or feature. Is "\n" or "\r\n" separator supported in UTILITY > List > Join?
I've tried \n and \r\n, both just printed the separator as ASCII in a single line rather than breaking into new line

No they're not supported there yet


[BUGS] Home page buttons are not working

Description
Home page sign up buttons and explore the shop button are not working.
Screenshots
No response
Additional information
No response
🥦 Browser
Google Chrome
👀 Have you checked for similar open issues?

[X] I checked and didn't find similar issue

🏢 Have you read the Contributing Guidelines?

[X] I have read the Contributing Guidelines

Are you willing to work on this issue ?
Yes I am willing to submit a PR!

Navbar Signup Button is also Not Working so please also check that out.


use local version of zeroclipboard movie

fixes issues in some recent browser (eg latest chrome on latest os x)
where the flash "movie" won't load unless it is local.
the error it gives is a generic "uncaught exception" in
ZeroClipboard activate -> flashState.bridge.setSize.
curiously it still works fine in some browsers (firefox) and
older chrome was also fine but I'm guessing
security modes are being tightened in browsers.

none of the other recommended settings for fixing this seem to work:
* trustedDomains
* trustedOrigin
* allowScriptAccess
* and even the flash config in the browser

it's just a small movie however so should be low impact (smaller than most of our images).
put in img path to simplify access.

also, zeroclipboard is updated from 1.3.1 to 1.3.5 (latest stable 1.x branch).
(2.x branch looks like it might be a bigger api change although some fixes in this area are reported.)

FYI almost identical change made (just now) to docs at https://github.com/apache/brooklyn-docs/pull/12

oops previous comment should have been https://github.com/apache/brooklyn-ui/pull/3#issuecomment-183264340
(this PR is of course identical to itself!)
closing for now while we resolve the binaries-in-source issue as discussed at the issue above


[BACKLOG-16710] - fixes EnvUtil for locales with variants.

deletes duplicated code.

Build Completed
:x: This pull request has errors. They will need to be addressed before it can be accepted. See below for more details. Some links are also available below for further assistance in addressing those issues.
Build Commands
mvn -Dsurefire.runOrder=alphabetical -B -fn -f 'pom.xml' -pl 'engine,core' -P '!assemblies' -amd clean install && mvn -B -f 'pom.xml' -pl 'engine,core' -P '!assemblies' -amd site

Cleanup Commands
mvn -B -f 'pom.xml' -pl 'engine,core' -P '!assemblies' -amd build-helper:remove-project-artifact

Changed files
  core/src/main/java/org/pentaho/di/core/util/EnvUtil.java
  core/src/test/java/org/pentaho/di/core/util/EnvUtilTest.java
  engine/src/test/java/org/pentaho/di/trans/steps/loadsave/LoadSaveTester.java

Unit Test Coverage
These statistics help you identify how your changes have affected the coverage of the following files. If a file is not in this list, then its coverage was not affected by your changes. To get some help interpreting these metrics, please refer to Jacoco's documentation.

:warning: Coverage Changes: <0.1% (click to expand)
org.pentaho.di.job.entries.evalfilesmetrics.JobEntryEvalFilesMetrics

Branch Change: -0.4% :small_red_triangle_down:
Complexity Change: -0.5% :small_red_triangle_down:

org.pentaho.di.job.entries.evaluatetablecontent.JobEntryEvalTableContent

Branch Change: -1% :small_red_triangle_down:
Complexity Change: -1% :small_red_triangle_down:
Instruction Change: -0.2% :small_red_triangle_down:

org.pentaho.di.job.entries.sql.JobEntrySQL

Instruction Change: -3.3% :small_red_triangle_down:
Line Change: -3.9% :small_red_triangle_down:

org.pentaho.di.trans.steps.memgroupby.MemoryGroupByMeta

Branch Change: -1.1% :small_red_triangle_down:
Complexity Change: -1.3% :small_red_triangle_down:

org.pentaho.di.trans.steps.textfileinput.TextFileInputMeta

Branch Change: -0.5% :small_red_triangle_down:

org.pentaho.di.trans.steps.gpload.GPLoadMeta

Branch Change: -0.9% :small_red_triangle_down:
Complexity Change: -0.8% :small_red_triangle_down:
Instruction Change: -0.2% :small_red_triangle_down:

org.pentaho.di.trans.steps.salesforceupdate.SalesforceUpdateMeta

Instruction Change: -0.2% :small_red_triangle_down:

License header violations

:heavy_exclamation_mark: Copyright year is not the current year on engine/src/test/java/org/pentaho/di/trans/steps/loadsave/LoadSaveTester.java. Found 2017. Was expecting 2018

Build Completed
:x: This pull request has errors. They will need to be addressed before it can be accepted. See below for more details. Some links are also available below for further assistance in addressing those issues.
Build Commands
mvn -Dsurefire.runOrder=alphabetical -B -fn -f 'pom.xml' -pl 'engine,core' -P '!assemblies' -amd clean install && mvn -B -f 'pom.xml' -pl 'engine,core' -P '!assemblies' -amd site

Cleanup Commands
mvn -B -f 'pom.xml' -pl 'engine,core' -P '!assemblies' -amd build-helper:remove-project-artifact

Changed files
  core/src/main/java/org/pentaho/di/core/util/EnvUtil.java
  core/src/test/java/org/pentaho/di/core/util/EnvUtilTest.java
  engine/src/test/java/org/pentaho/di/trans/LoadSaveTester.java
  engine/src/test/java/org/pentaho/di/trans/steps/loadsave/LoadSaveTester.java

Unit Test Coverage
These statistics help you identify how your changes have affected the coverage of the following files. If a file is not in this list, then its coverage was not affected by your changes. To get some help interpreting these metrics, please refer to Jacoco's documentation.

:warning: Coverage Changes: <0.1% (click to expand)
org.pentaho.di.job.entries.getpop.MailConnectionMeta

Branch Change: -1% :small_red_triangle_down:
Complexity Change: -1.5% :small_red_triangle_down:
Instruction Change: -0.3% :small_red_triangle_down:

org.pentaho.di.job.entries.waitforsql.JobEntryWaitForSQL

Branch Change: -0.7% :small_red_triangle_down:
Complexity Change: -0.9% :small_red_triangle_down:
Instruction Change: -0.1% :small_red_triangle_down:

org.pentaho.di.trans.steps.checksum.CheckSumMeta

Instruction Change: -0.2% :small_red_triangle_down:

org.pentaho.di.trans.steps.constant.ConstantMeta

Instruction Change: -0.1% :small_red_triangle_down:

org.pentaho.di.trans.steps.dimensionlookup.DimensionLookupMeta

Branch Change: -1.8% :small_red_triangle_down:
Complexity Change: -1.1% :small_red_triangle_down:
Instruction Change: -0.4% :small_red_triangle_down:
Line Change: -0.3% :small_red_triangle_down:

org.pentaho.di.trans.steps.replacestring.ReplaceStringMeta

Instruction Change: -0.1% :small_red_triangle_down:

org.pentaho.di.trans.steps.setvalueconstant.SetValueConstantMeta

Instruction Change: -0.2% :small_red_triangle_down:

org.pentaho.di.trans.steps.symmetriccrypto.symmetriccryptotrans.SymmetricCryptoTransMeta

Branch Change: -3.3% :small_red_triangle_down:
Complexity Change: -1.8% :small_red_triangle_down:
Instruction Change: -0.3% :small_red_triangle_down:

org.pentaho.di.trans.steps.synchronizeaftermerge.SynchronizeAfterMergeMeta

Instruction Change: -0.1% :small_red_triangle_down:

org.pentaho.di.trans.steps.webservices.WebServiceMeta

Branch Change: -1.7% :small_red_triangle_down:
Complexity Change: -1.2% :small_red_triangle_down:
Instruction Change: -0.1% :small_red_triangle_down:

org.pentaho.di.ui.repository.pur.repositoryexplorer.model.UIEERepositoryUser

Branch Change: -8.3% :small_red_triangle_down:
Complexity Change: -6.7% :small_red_triangle_down:
Instruction Change: -0.9% :small_red_triangle_down:
Line Change: -3.1% :small_red_triangle_down:

org.pentaho.di.trans.steps.salesforceupdate.SalesforceUpdateMeta

Instruction Change: -0.2% :small_red_triangle_down:

License header violations

:heavy_exclamation_mark: Copyright year is not the current year on engine/src/test/java/org/pentaho/di/trans/steps/loadsave/LoadSaveTester.java. Found 2017. Was expecting 2018

Build Completed
:fire: This pull request has some issues. It would be preferable to fix them in order for it to be just perfect. See below for more details. Some links are also available below for further assistance in addressing those issues.
Build Commands
mvn -Dsurefire.runOrder=alphabetical -B -fn -f 'pom.xml' -pl 'engine,core' -P '!assemblies' -amd clean install && mvn -B -f 'pom.xml' -pl 'engine,core' -P '!assemblies' -amd site

Cleanup Commands
mvn -B -f 'pom.xml' -pl 'engine,core' -P '!assemblies' -amd build-helper:remove-project-artifact

Changed files
  core/src/main/java/org/pentaho/di/core/util/EnvUtil.java
  core/src/test/java/org/pentaho/di/core/util/EnvUtilTest.java
  engine/src/test/java/org/pentaho/di/trans/LoadSaveTester.java
  engine/src/test/java/org/pentaho/di/trans/steps/loadsave/LoadSaveTester.java

Unit Test Coverage
These statistics help you identify how your changes have affected the coverage of the following files. If a file is not in this list, then its coverage was not affected by your changes. To get some help interpreting these metrics, please refer to Jacoco's documentation.

:warning: Coverage Changes: -0.1% (click to expand)
org.pentaho.di.core.injection.bean.BeanInjector

Branch Change: -0.7% :small_red_triangle_down:
Complexity Change: -1.2% :small_red_triangle_down:

org.pentaho.di.job.entries.getpop.MailConnectionMeta

Branch Change: -1% :small_red_triangle_down:
Complexity Change: -1.5% :small_red_triangle_down:
Instruction Change: -0.3% :small_red_triangle_down:

org.pentaho.di.job.entries.sql.JobEntrySQL

Instruction Change: -3.3% :small_red_triangle_down:
Line Change: -3.9% :small_red_triangle_down:

org.pentaho.di.trans.steps.groupby.GroupByMeta

Branch Change: -2.1% :small_red_triangle_down:
Complexity Change: -2.1% :small_red_triangle_down:

org.pentaho.di.trans.steps.memgroupby.MemoryGroupByMeta

Branch Change: -3.3% :small_red_triangle_down:
Complexity Change: -3.8% :small_red_triangle_down:
Instruction Change: -0.3% :small_red_triangle_down:
Line Change: -0.9% :small_red_triangle_down:

org.pentaho.di.trans.steps.replacestring.ReplaceStringMeta

Instruction Change: -0.1% :small_red_triangle_down:

org.pentaho.di.trans.steps.tableoutput.TableOutputMeta

Branch Change: -0.9% :small_red_triangle_down:
Complexity Change: -0.8% :small_red_triangle_down:

org.pentaho.di.trans.steps.textfileinput.TextFileInputMeta

Branch Change: -0.5% :small_red_triangle_down:

org.pentaho.di.engine.configuration.impl.EmbeddedRunConfigurationManager

Complexity Change: -66.7% :small_red_triangle_down:
Instruction Change: -92.3% :small_red_triangle_down:
Line Change: -90% :small_red_triangle_down:
Method Change: -66.7% :small_red_triangle_down:

org.pentaho.di.engine.configuration.impl.extension.RunConfigurationImportExtensionPoint

Branch Change: -90% :small_red_triangle_down:
Complexity Change: -95% :small_red_triangle_down:
Instruction Change: -99.6% :small_red_triangle_down:
Line Change: -100% :small_red_triangle_down:
Method Change: -100% :small_red_triangle_down:

org.pentaho.di.engine.configuration.impl.extension.RunConfigurationInjectExtensionPoint

Branch Change: -83.3% :small_red_triangle_down:
Complexity Change: -80% :small_red_triangle_down:
Instruction Change: -98.7% :small_red_triangle_down:
Line Change: -94.7% :small_red_triangle_down:
Method Change: -100% :small_red_triangle_down:

org.pentaho.di.engine.configuration.impl.extension.RunConfigurationRunExtensionPoint

Branch Change: -37.5% :small_red_triangle_down:
Complexity Change: -42.9% :small_red_triangle_down:
Instruction Change: -63.2% :small_red_triangle_down:
Line Change: -67.9% :small_red_triangle_down:
Method Change: -100% :small_red_triangle_down:

org.pentaho.di.engine.configuration.impl.MetaStoreRunConfigurationFactory

Complexity Change: -72.7% :small_red_triangle_down:
Instruction Change: -53.9% :small_red_triangle_down:
Line Change: -42.4% :small_red_triangle_down:
Method Change: -80% :small_red_triangle_down:

org.pentaho.di.engine.configuration.impl.pentaho.DefaultRunConfiguration

Complexity Change: -96.2% :small_red_triangle_down:
Instruction Change: -95.5% :small_red_triangle_down:
Line Change: -97.7% :small_red_triangle_down:
Method Change: -96.2% :small_red_triangle_down:

org.pentaho.di.engine.configuration.impl.pentaho.DefaultRunConfigurationExecutor

Branch Change: -73.1% :small_red_triangle_down:
Complexity Change: -70% :small_red_triangle_down:
Instruction Change: -80.4% :small_red_triangle_down:
Line Change: -77.2% :small_red_triangle_down:
Method Change: -85.7% :small_red_triangle_down:

Note: The list of offending coverage changes extends beyond the presented results and was truncated to prevent reaching the comment size limit.


Issue 104 - Add source map to NPM and PyPi packages

Fixes #104
Relates to plotly/dash#478
Relates to https://github.com/plotly/dash-table/issues/284

Add source-map to build output
Add source-map to npm package
Add source-map to PyPi package

Got a 500 error the first time I did a review, seems it posted it twice now. Whoops!

If anyone wonders, the dev js file is smaller but removing the "eval source map" causes it to take 1 line per code line instead of squishing everything (with evals), explaining the 30k lines diff

That's because we're not using the dynamic flag yet. When loaded "correctly" through the devtools this will not happen anymore.

The external code map works for debugging, looked like it was even more stable for dev bundle. The min bundle also debugged but it was jumping over things.
:dancer:

The external code map works for debugging, looked like it was even more stable for dev bundle. The min bundle also debugged but it was jumping over things.

Thanks for checking this out. I thought we might be able to get rid of the dev build after the change but if you see improved behavior when debugging with it, let's keep it.


[Languages] The hashCode() function in Java

Topic Suggestion
The hashCode() function in Java
Proposed article introduction
By invoking the hashCode() method on an object in Java, you may retrieve the hash code value associated with that object. In the Object class, this function is implemented by default, and it is inherited by all other classes, including those created by the user.
Because this method is called on the same object during a single instance of a Java application. It always returns the same integer number, assuming that no data utilized by the equals() method has been updated.
In this tutorial, we will look into details about the hashCode() function in Java and how we can implement it.
Key takeaways
The reader will understand the following concepts in details;

Overview on hashCode() in Java
Using hashCode() in Data Structures
Understanding How hashCode() Works
A Naive hashCode() Implementation
Improving the hashCode() Implementation
Standard hashCode() Implementations
Handling Hash Collisions
Creating a Trivial Application

References
N/A

Good afternoon and thank you for submitting your topic suggestion.
Your topic form has been entered into our queue and should be reviewed (for approval) as soon as a content moderator is finished reviewing the ones in the queue before it.

Sounds like a helpful topic - let's please be sure it adds value beyond what is in any official docs and/or what is covered in other blog sites. (the articles should go beyond a basic explanation - and it is always best to reference any EngEd article and build upon it).
Please be attentive to grammar/readability and make sure that you put your article through a thorough editing review prior to submitting it for final approval. (There are some great free tools that we reference in EngEd resources.)
ANY ARTICLE SUBMITTED WITH GLARING ERRORS WILL BE IMMEDIATELY CLOSED.
Please be sure to double-check that it does not overlap with any existing EngEd articles, articles on other blog sites, or any incoming EngEd topic suggestions (if you haven't already) to avoid any potential article closure, please reference any relevant EngEd articles in yours. - Approved


[iOS] Use mainBundle in RCTConvert to resolve asset paths

See #3888 for why this is necessary. Essentially, [NSBundle mainBundle] loads the file path for the target app which is the only way to reference images.
Test plan: Make sure unit tests pass!
cc @javache @nicklockwood

@facebook-github-bot shipit

This broke some of our internal tests which were relying on assets located in the test bundle. I'm going to need to solve that before I can land this. The fix itself is correct though - we'll find another solution for the tests.

Sure thing, thanks for letting me know!


Plugin not working on Win10

With either entry saved in notes.md, tag explorer does not populate, am I doing something wrong? I have tried removing the date field as well
# Daily Task Notes

## Entry 1

---

tags: [First Entry, Note Test, Confluence, JIRA, Ping Down]
date: 10/9/2021

---

notes go here

OR
# Daily Task Notes

## Entry 1

---
tags: [First Entry, Note Test, Confluence, JIRA, Ping Down]
date: 10/9/2021
---

notes go here

This is front matter:
---

tags: [First Entry, Note Test, Confluence, JIRA, Ping Down]
date: 10/9/2021

---

The "front" in "front matter" means it must be at the top of the document. You don't have it at the top of the document, so it is not recognized.
If you want to define tags at arbitrary locations in the document, then use the HTML comment style as shown here:
https://github.com/blakedietz/vscode-nested-tags#features


Clean up Protocols guide

markdown not resolved to link
editor notes in live version
add inline code snippets

preview: https://deploy-preview-464--tbd-website-developer.netlify.app/docs/web5/learn/protocols

Done in 32432bd


Add a Carousel Landing page template

Issue Type:

[x] Feature Request

idea
Add a carousel landing page template that is suitable for volunteering comunities to present themselves in a compact modern way.
Screenshots
This is a demo of an already established website. (Images are blurred)

I want to work on this under GSSOC2022. Can you assign it to me.


chore(protocol): remove buggy ERC20Airdrop2 and apply improvements

See https://github.com/code-423n4/2024-03-taiko-findings/issues/255

Approved, but still think ERC20Airdrop2 is usable in Trailblazer hence it smoothens down the sell pressure with that gradual unlock. But eventually we can get it back, if needed.

Lets try to fix the bug then.


MySQL error message

Just restarted and I see this message in docker compose logs:
server_mysql_1     | ERROR 1064 (42000) at line 14: You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near 'SET_GLOBAL max_connections = 1000' at line 1

No idea what this means, or if this has always been there, I'm afraid, but thought it worth a report.

Related to #66 , can you manage to wipe the db data, and try a fresh build?
I had super weird behaviour when I was trying to upgrade packages and think it was due to a mismatch in cached database details.

Should note that my version upgrades a lot. Including the MySQL base image: https://github.com/AI-Planning/planning-as-a-service/compare/main...haz:planning-as-a-service:main#diff-384e92019121a5f7537238f61bc89717e9a9bde9af213a6a8aea7a703f3c9136R65

Can you tell me how to wipe the db data?  I shut down the PaaS system with docker compose down and then restarted the DB server (only) with docker compose up mysql.  That gets the mysql container started, but in a state where mysql is running and I cannot delete the db data files (in /var/lib/mysql/), because they are in use.
I need to stop the mysql daemon but... I don't know how! 🤦🏻 The only recipes I know use service or systemctl and that doesn't seem to be how this image works it. I checked the mysql image docs but they say nothing about how to shutdown a running server in a container.

Oy! Never tried from within the image. Always a sudo rm -rf db_data or whatever on the outside. Will have a look tonight if I can't get a work-around in the Makefile route, as suggested in #66


Add New Parent Picklist Values for Relationship Type

Note: FOR INTERNAL USE ONLY. For support questions, please use the EDA Chatter group in The Power of Us Hub.
For feature requests, please use the Ideas tab in The Power of Us Hub.

Do you want to request a feature or report a bug?
Feature

What is the current behavior?

What is the expected behavior?
Add new types of relationship:

Guardian
Dependent
Stepfather
Stepmother
Stepparent
Stepdaughter
Stepson
Stepchild
Foster Parent
Foster Daughter
Foster Son
Foster Child

What is the motivation / use case for changing the behavior?

Acceptance Criteria

Given: I am on a certain page
When: I click a button
Then: An action should occur

Keyboard Acceptance Criteria

Given: I am navigating the site using only my keyboard
When: I tab to the button
Then: I should see the button highlighted on focus
And When: I press enter on a highlighted button
Then: An action should occur

Screenreader Acceptance Criteria

Given: I am using a screenreader to navigate the site
When: I tab to the button
Then: I should hear the label of the button
And When: I press enter
Then: I should hear that an action has occurred

Tracking W-7976620


The inference of quantized models based on float16 weights fails on CPU

The inference of models with float16 weights in their Linear layers is not supported on CPU ('RuntimeError: "addmm_impl_cpu_" not implemented for 'Half').
Since addmm is not natively supported for integer either, we fallback to float16 for inference, which leads to a failure.
One possible workaround would be to fallback to float32, but it is a bit awkward (and it is not done for float models).

Hi @dacorvo I suppose you are using torch as the inference framework according to the error message. I think it's might not a good idea to use torch directly.

torch is heavy to deploy
There are many other torch ops that didn't support int(int8, int16, int32 etc.) dtypes, it seems torch focus on training and float dtypes.
Torch lacks performance optimization for inference, especially quantized inference.

I don't understand your comment. quanto is a pytorch quantization toolkit.

@dacorvo Sorry, I may have misunderstood the scope of Quanto. Previously, I thought Quanto was a fake quantization tool that exports fake-quantized or quantized models and then feeds them to inference frameworks like ONNXRuntime for inference. However, when I recalled that Quanto was implementing some inference operator kernels, I realized that Quanto itself also supports quantized inference.
One more question: What hardware will Quanto support for quantized inference in the short term? CUDA, x86, and mps?

Yes, these are the short terms. We (Hugging Face) have also started discussions with our hardware partners to see if they are interested in contributing dedicated kernels (like mkl, amd, ...).


Change label management to rely on independent rest calls

Calc delta for labels from metadata and page information, then add/remove labels via independent confluence api calls
Seems to address "Label appear and disappear (PingPong) #226"

Let's see if this improves the situation with labels :) Thanks!


fixed to use relative url's (also added BASEPATH env var)

If BASEPATH is not specified, it defaults to '/'.
This pull request effectively combines #104 and #94
And fixes #113 and #114

It would be awesome if we could get this reviewed merged in! :) @Morriz @kwk


Add even more non-standard ligatures (PR 15517 follow-up)

Given that we already create multi-byte ToUnicode entries in other cases, see e.g. the getNormalizedUnicodes table, this is hopefully fine.

/botio test


fix: add find_package(Threads) to the OsalConfig.cmake

When importing osal into another project the Threads::Threads dependency was not forwarded.
This PR correctly includes the find_package(Threads) into the OsalConfig.cmake. Thus making it possible to include osal as a system dependency.
This fixes https://github.com/rtlabs-com/p-net/issues/323

This solution looks good, thanks. It only applies to Linux though and might break builds for cross-compiled targets and Windows, if the Threads package is not available. Could you update the PR to only affect Linux builds? Alternatively I can merge this and fix the other builds in a separate commit.

Afaik Threads should resolve to the platform-specific threading implementation. I.e. pthrads on linux and something else on windows?

Yes, it won't work with FreeRTOS tasks for instance. At best it will not break compilation if the host platform happens to have something installed that the Threads package can find, but whatever it is won't be used. We don't rely on the Threads package on Windows either, and if we did it should never resolve to pthreads on Windows which is not what we are using.

Yes, it won't work with FreeRTOS tasks for instance. At best it will not break compilation if the host platform happens to have something installed that the Threads package can find, but whatever it is won't be used. We don't rely on the Threads package on Windows either, and if we did it should never resolve to pthreads on Windows which is not what we are using.

Oh well, in that case I ll update this to only generate the dependency on linux

Unfortunately it looks like GH has no way to mark PR:s merged if you squash outside of the UI like I did. Anyway this is merged now.


How do i access serenity::client::context inside poise::Context

slash command example:
...
client.data.write().await.insert::<sleeper::RedisPool>(pool);
...

#[poise::command(slash_command)]
pub async fn block(ctx: Context<'_>, deployer: Address) -> Result<()> {
    let pool = ctx.data.read().await.get::<crate::RedisPool>()?;
    Ok(())
}

error: attempted to take value of method data on type poise::Context<'_, (), ErrReport> method, not a field
im aware those are two different Context types, one is serenity::client::context, the other is poise::Context
for example in the Handler trait i have a different Context type, which can access data, how can i access that in my slash commands?
i would like to share RedisPool in slash commands and in the Handler struct.

nvm literally just found it 5 seconds later, its ctx.serenity_context()

Use poise's data. Check out the examples.

Use poise's data. Check out the examples.

yes i could, but then i have to add it to both data fields (serenity context and pose::command context)

No you wouldnt, see the poise event handler example.

No you wouldnt, see the poise event handler example.

you are right, true. is there any disadvantage in using ctx.serenity_context() in the slash commands?

Yes, its fine, but you should do your command responses through poise's Context, feel free to use serenity's context to do other stuff as you please.

Just to let you know we have a discord server which you could use to ask questions instead of opening github issues. (https://discord.gg/serenity-rs)


Function inference helpers

fun and act functions to help with delegate inference
just needs to take a func and return it

#13


Add ExifCleaner

Project URL
https://exifcleaner.com
Category
Images
Description
Remove image metadata with drag and drop, multi-core batch processing, and dark mode.
Why it should be included to Awesome macOS open source applications  (optional)
Supports macOS's dark mode.
Checklist

[x] Edit applications.json instead of README.md.
[x] Only one project/change is in this pull request
[x] Screenshots(s) added if any
[x] Has a commit from less than 2 years ago
[x] Has a clear README in English

@szTheory Thank you! 👍


create examples/output/ again

targets that put stuff in examples/output/ may need to create the dir unless we change the cleanup mechanism
the absence of this dir creation step didn't seem to effect the GH Actions but it was leading to make squeaky-clean all test errors on my workstation

I started adding squeaky-clean targets to my LinkML Makefiles when I was green and didn't want to stray too far from the established clean actions. I agree, its confusing and should be unified or documented better.


Inconsistency between Emoji and Emote

At the time of writing, to create an Emoji object, you'd have to pass the unicode into its public constructor; to create an Emote object, you'd have to do it through either the Parse or the TryParse method, and the object's constructor is internal only.
This feels extremely inconsistent and can sometimes be confusing.

Does Discord even make a distinction between Emoji and Emotes in the API?

Emote: To give expression to emotion
Emoji: Japanese for picture-character(s). (Yes, 絵文字 has no aspect of time like any jp. noun; "emojis" hurts to read. 🌵)
Mostly they can be used interchangeably in this case. But 🆎 is definitly not an emote. ;)

@BinkanSalaryman did you read the issue? The definition has nothing to do with the issue. The point of the issue was to point out the inconsistent implementation.

@Still34 I did, why so pricky? I hope I lifted your confusion that drove you to submit the naming as an issue!

Also, the terms used in this lib all follow the terms defined by Discord. Emote is specifically for a custom guild emote, while Emoji is for standard Unicode ones.

Discord only defines emoji at https://discordapp.com/developers/docs/resources/emoji...

Apologies if I sounded hostile; however, I still fail to understand why you brought up the definition when the issue itself was questioning the implementation between the current Emote and Emoji.


passing variables to pypandoc?

I'm writing a small script to take an input file from argparse for conversion and publication of .md files to git repos and two mediawikis. Super happy to find this wrapper but I'm running into an issue, and I can't work out if it's my bad python knowledge or pypandoc, here is where I'm at:
#!/usr/bin/env python

import argparse
import mwclient
import pypandoc

parser = argparse.ArgumentParser(description='Cross publish your texts to Mediawikis and git repos')
parser.add_argument('-f', '--file', type=argparse.FileType('r'), help='your input text file')
args = parser.parse_args()
print args.file.readlines()

input = args.file.readlines()
print input
output = pypandoc.convert_file(input, 'mediawiki')
print output

but when I run it, I get this response:
Traceback (most recent call last):
  File "crosspublish.py", line 14, in <module>
    output = pypandoc.convert_file(input, 'mediawiki')
  File "/usr/local/lib/python2.7/dist-packages/pypandoc/__init__.py", line 137, in convert_file
    raise RuntimeError("source_file is not a valid path")
RuntimeError: source_file is not a valid path

For which I can not fine a solution. Is it not possible to pass variables to pypandoc?
Many many thanks, and all the best.

Covert_file expects a filename as input, and currently you pass in the filecontent. You either change your code to get a filename (an opened file like the parser currently returns does not work) from your parser or read in the file like now and use convert_text on your input.

Hey, thanks that did it, thanks for your help and time!
Cheers!


Aliases sometimes wait for an inordinate amount of time after exit

This mostly happens in ConEmu but does happen in busybox sh as well as cmd.exe, sometimes even executables outside wait after exit too when called from within busybox sh (like msys64 man.exe).
Its especially noticeable when calling aliases from other aliases or even just doing 'system("ls")'.
I solved this by doing ExitProcess() in alias.c and recompiling all the aliases. Since no matter what i do anything compiled in tiny mode  using mainCRTStartup using just return exhibits the same problem.
Can one really return safely from mainCRTStartup ?

Hmm, which Windows is this (10, 11, etc.) and is it 32-bit or 64-bit? A
delay on exit is typical of a memory access violation, which for console
applications is usually silent. That would happen if there was nowhere to
return, or a trashed return pointer. Could you run the alias under GDB to
see if catches a crash on exit? If so, it would be also great if you could
reproduce on a debug build (compile with -g3) to understand why. If no
crash, at least it may show where the delay occurs. Perhaps there's a
security program interfering (e.g. injecting a thread)?
I have never seen official documentation for the mainCRTStartup prototype,
except that it's supposed to be stdcall. But Microsoft doesn't stdcall in
their own definition (see exe_min.cpp in Visual Studio 2022). It's usually
written with no arguments (e.g. in Mingw-w64 and older Visual Studio):
int mainCRTStartup(void);
Other times it accepts a pointer to the PEB (Visual Studio 2022):
int mainCRTStartup(void *);
That would matter for stdcall, except Windows seems to arrange such that
it won't, i.e. the caller does not use the stack. The Visual Studio source
potentially returns the application exit status, so it seems they're not
afraid of returning. Indeed, it works fine in a quick, minimal test:
$ echo 'mov $123,%eax;ret' | cc -xassembler -nostartfiles -
$ ./a ; echo $?
Reports the "123" exit status at least as far back as Windows XP, and on
both 32-bit and 64-bit. Give ret a small immediate for a stdcall return
and it still works fine.
Returning from the main thread does not immediately exit the process, and
it will wait until all other threads have exited. Calling ExitProcess() is
a good way to avoid this behavior. Though, of course, the alias program
doesn't start threads.
I'm fine with calling ExitProcess for a "cleaner" exit (08ff830), but I'd
like to better understand the nature of what's happening here rather than
guess. Thank you for reporting this, grable!

Im running on Windows 10 x64 1511, a rather old version.
Running your assembler example in w64devkit.exe alone works fine.
Running the example in w64devkit.exe inside ConEmu waits for a while then prints "0".
Heres a test case i used to test further:
//   $ gcc -Os -fno-asynchronous-unwind-tables -s -nostartfiles -Wl,--gc-sections -o test_crtstart1.exe test_crtstart.c
//   $ gcc -DEXITPROCESS -Os -fno-asynchronous-unwind-tables -s -nostartfiles -Wl,--gc-sections -o test_crtstart2.exe test_crtstart.c

void *GetStdHandle(int) __attribute((dllimport,stdcall));
int WriteFile(void *, const void *, int, int *, void *) __attribute((dllimport,stdcall));
int ExitProcess(int) __attribute((dllimport,stdcall));

#if __i386
__attribute((force_align_arg_pointer))
#endif
__attribute((externally_visible))
int mainCRTStartup(void)
{
	const char msg[] = "this is a test\n";
	int dummy;
	WriteFile( GetStdHandle(-11), msg, sizeof(msg), &dummy, 0);
#ifdef EXITPROCESS // test_crtstart2
	ExitProcess(123);
#else
	return 123; // test_crtstart1
#endif
}

Running in w64devkit.exe alone:
$ ./test_crtstart1 ; echo $?
this is a test
 123
$ ./test_crtstart2 ; echo $?
this is a test
 123
$ gdb ./test_crtstart1.exe
Reading symbols from ./test_crtstart1.exe...
(No debugging symbols found in ./test_crtstart1.exe)
(gdb) run
Starting program: C:\Projects\C\tinylib\test_crtstart1.exe
this is a test
 [Inferior 1 (process 4792) exited with code 0173]
(gdb) exit
$ gdb ./test_crtstart2.exe
Reading symbols from ./test_crtstart2.exe...
(No debugging symbols found in ./test_crtstart2.exe)
(gdb) run
Starting program: C:\Projects\C\tinylib\test_crtstart2.exe
this is a test
 [Inferior 1 (process 8052) exited with code 0173]
(gdb) exit

Running w64devkit.exe inside ConEmu:
$ ./test_crtstart1.exe ; echo $?
this is a test
<.... waiting for a while ...>
 0
$ ./test_crtstart2.exe ; echo $?
this is a test
 123
$ gdb ./test_crtstart1.exe
<.... waiting for a while ...>
Reading symbols from ./test_crtstart1.exe...
(No debugging symbols found in ./test_crtstart1.exe)
(gdb) run
Starting program: C:\Projects\C\tinylib\test_crtstart1.exe
[New Thread 7740.0x1d98]
[New Thread 7740.0x1c50]
this is a test
 [Thread 7740.0xf18 exited with code 123]
<.... waiting for a while ...>
[Thread 7740.0x1d98 exited with code 0]
[Inferior 1 (process 7740) exited normally]
(gdb) exit
$ gdb ./test_crtstart2.exe
<.... waiting for a while ...>
Reading symbols from ./test_crtstart2.exe...
(No debugging symbols found in ./test_crtstart2.exe)
(gdb) run
Starting program: C:\Projects\C\tinylib\test_crtstart2.exe
[New Thread 3940.0x70]
[New Thread 3940.0x7e4]
this is a test
 [Thread 3940.0x70 exited with code 123]
[Thread 3940.0x7e4 exited with code 123]
[Inferior 1 (process 3940) exited with code 0173]
(gdb) exit

This does look more like a ConEmu issue than anything else really, that extra spawned thread is probably what is injected by ConEmu for output capture and other things and that is where the waiting seems to happen. So your initial assumption was right ;)
Im also having trouble reproducing the waiting without ConEmu so i might be misremembering where ive seen it...
It is weird though that gdb waits at startup too when run inside ConEmu.

After further testing, i cant reproduce any waiting outside ConEmu, unless i call _sprintf or _snprintf  which automatically links the executable to msvcrt.dll.
gdb even waits at the same spot, right after the main thread exits...
So it seems msvcrt.dll also does something when attached to a process compiled in "tiny mode" and thus an ExitProcess is required for a clean exit.

Thanks for all this detail! That's been very helpful. The "New Thread" log
is the smoking gun, enough to figure out almost everything. When I run my
assembler example under ConEmu with GDB, I also see three extra threads,
though I do not observe a delayed exit nor a zero status. When I link
msvcrt.dll (outside ConEmu) I also see one extra thread, which is normal.
In all cases threads are blocked on ZwWaitForWorkViaWorkerFactory any time
I look at them. Perhaps your particular, local system configuration delays
threads blocked on that function? Or maybe they're blocked on something
else? (If you'd like to check, use "info threads" in GDB.) I was unable to
reproduce the delay, only these thread spawns.
As for ConEmu, I learned that it explicitly hooks every process in its
tree. Even without the hook it injects a thread via CreateRemoteThread. By
my measurements, this triples process startup time. That sounds worse than
it really is, and the difference is just barely perceptible.
https://conemu.github.io/en/ConEmuHk.html
I went down the rabbit hole reading the ConEmu sources and investigating.
It obfuscates its CreateRemoteThread lookup to evade security scanners
(InjectRemote.cpp), and embeds a kind of shell code (Infiltrate.cpp) for
doing its work. Fascinating stuff.
If your situation is common, perhaps it's gone unnoticed because it's
unusual for programs to return on their main thread. Every runtime I've
seen makes a non-returning exit system call instead of returning. I always
do it in Windows Subsystem applications because interacting with windowing
implicitly spawns of threads that don't return. Considering environments
that inject threads, I suppose I should always ExitProcess or similar even
in trivial console applications. I'll do so from now on.
I did all testing on Windows 10 22H2 with ConEmu 230724 (newest stable).
If you can reproduce the assembly example on the latest ConEmu, consider
reporting there. At only two instructions, it's the most trivial Windows
program possible, and does not involve runtimes nor compiler shenanigans.

Thanks, did not expect you to trawl through ConEmu, it is quite the rabbit hole indeed.
Just for completeness i ran this to get various timeouts:
#include <stdio.h>
#include <windows.h>

int main() {
	int value;
	#define PRINT(x)	if(SystemParametersInfoA( SPI_GET ## x, 0, &value, 0) == 0) puts( #x " = unknown\n");		\
								else printf( #x " = %d\n", value)
	PRINT(ACTIVEWNDTRKTIMEOUT);
	PRINT(FOREGROUNDLOCKTIMEOUT);
	PRINT(HUNGAPPTIMEOUT);
	PRINT(WAITTOKILLTIMEOUT);
	PRINT(WAITTOKILLSERVICETIMEOUT);
	return 0;
}

My output:
ACTIVEWNDTRKTIMEOUT = 500
FOREGROUNDLOCKTIMEOUT = 25363236
HUNGAPPTIMEOUT = 5000
WAITTOKILLTIMEOUT = 5000
WAITTOKILLSERVICETIMEOUT = 5000

Nothing looks out of the ordinary, so il close this.


⚠ Bofrost.lu has degraded performance

In be7baaa, Bofrost.lu (https://www.bofrost.lu) experienced degraded performance:

HTTP code: 200
Response time: 2110 ms

Resolved: Bofrost.lu performance has improved in c98870e after 6 minutes.


[BUG] Ugly screen after archiving an event

Describe the bug
After archiving an event the screen is left in undefined state.
To Reproduce
Steps to reproduce the behavior:

Go to 'Events' and click on an event
Click on 'Archive' and confirm the operation. After it's completed, the screen is left in an undefined state.

Expected behavior
After archiving an event, the user should be redirected back to the Events grid.
Screenshots

Desktop (please complete the following information):

OS: Linux Ubuntu 18.04 LTS
Browser: Chrome
Version: 80.0.3987.116 (Official Build) (64-bit)

Additional context
Deleting event works as expected.

@vladimirpetrov please test and close

Fix confirmed, closing the issue.


Replace EFnParamPat with Pattern

While certain patterns that are part of the PatternKind enum aren't valid for params, as long as we don't use those when inferring params it shouldn't be a problem.  Replacing EFnParamPat with Pattern allows us to remove a lot of code that is quite similar and simplifies the overall AST.
This PR also fixes an issue that was prevent ({x}: {x: number, y: number}) => x.

Codecov Report

Merging #305 (13969fb) into main (a2d713f) will increase coverage by 0.09%.
The diff coverage is 70.45%.

@@            Coverage Diff             @@
##             main     #305      +/-   ##
==========================================
+ Coverage   90.12%   90.21%   +0.09%
==========================================
  Files          31       31
  Lines        5214     5081     -133
==========================================
- Hits         4699     4584     -115
+ Misses        515      497      -18

Impacted Files
Coverage Δ

crates/crochet_ast/src/expr.rs
0.00% <0.00%> (ø)

crates/crochet_codegen/src/d_ts.rs
76.42% <0.00%> (-0.55%)
:arrow_down:

crates/crochet_infer/src/update.rs
88.60% <69.23%> (-3.06%)
:arrow_down:

crates/crochet_infer/src/infer_fn_param.rs
89.13% <84.84%> (-3.73%)
:arrow_down:

crates/crochet_parser/src/lib.rs
96.91% <90.90%> (+0.51%)
:arrow_up:

crates/crochet_codegen/src/js.rs
95.14% <100.00%> (+0.17%)
:arrow_up:

crates/crochet_infer/src/infer_type_ann.rs
85.65% <100.00%> (ø)

crates/crochet_infer/src/lib.rs
99.09% <100.00%> (ø)

crates/crochet_infer/src/unify.rs
89.91% <100.00%> (+1.66%)
:arrow_up:

crates/crochet_types/src/pat.rs
72.22% <0.00%> (-2.78%)
:arrow_down:

... and 4 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


Why is separate a private function?

I've always wondered why separate is a private function in arcade physics. seems to me there are tons of applications for a separate function as good as Phaser's outside of using collide. What are the arguments against making it public and documented in the API? Suppose I want to check for overlaps between 2 Phaser.Rectangles directly (using Phaser.Rectangle.intersects) and then separate them? I realize separate is supposed to use physics bodies but I assume it works just as well on normal Phaser.Rectangles. Maybe that's not the best example but I know I've run into scenarios before where I wanted to create a separation directly (not using collide). I think it would be useful if separation accepted other paramaters as well, like how quickly and how far the objects should separation.
Also curious as to why collide and overlap are different functions - why not make it 1 function with separate as an option?

collide and overlap are public facing API methods, which is why they are separate (because they're easier to understand than an argument you may overlook).
I could make separate public, but there's little benefit as it only works on Arcade Physics bodies (try it on a Rectangle and see the errors you'll get). What I agree it should have though is the ability to separate but not exchange velocities. And at the end of the day, if you really wanted to call the function, you could anyway. I suspect the edge-cases for that are quite tiny though.

I see. Suppose I want to mark off areas of an image and have an object collide with those areas. My only option, if I want to use separate, is to have sprites and sprite bodies representing each area of that image? That's my predicament. I want to mark off areas of an image for collision but creating separate sprites and bodies for each area would be too taxing on performance. I had hoped I could use Phaser.Rectangles to mark the areas. That solves the actual collision detection part of the problem (with rectange.intersects) but not the separation part.


feat(36048): Apply uncalled function checks to ternaries

Fixes #36048

The following lines cause the error
https://github.com/microsoft/TypeScript/blob/fa3173f8f6443307739fc7c41f2bdd680f56a844/src/server/project.ts#L1382
https://github.com/microsoft/TypeScript/blob/fa3173f8f6443307739fc7c41f2bdd680f56a844/src/server/project.ts#L1312
Is it the right condition in this case?
cc @sandersn @DanielRosenwasser @weswigham

Yes, those errors are correct, and they should be fixed before merging this PR. I asked @uniqueiniquity to investigate.

Fix is https://github.com/microsoft/TypeScript/pull/36885, thanks @uniqueiniquity for figuring it out.

@sandersn Oke, I'll wait to merge PR #36885.

OK, @a-tarasyuk can you merge from master and I'll re-run the user tests to make sure they're still good.

@typescript-bot test this
@typescript-bot user test this

user and RWC tests look clean