Check if clang_Type_getNumTemplateArguments is loaded before use

Fixes #1304, which reapplies #916 which was regressed by #915.

 Warning

These commits modify unsafe code. Please review it carefully!

Thanks!
@bors-servo r+

:pushpin: Commit c63a095 has been approved by emilio

:hourglass: Testing commit c63a095d65a9f3271b32b3d76a1916483d5a8575 with merge 1f097ddd484f57eb9e81a1d0872494ee1d0f6ad0...

:sunny: Test successful - status-travis
Approved by: emilio
Pushing 1f097ddd484f57eb9e81a1d0872494ee1d0f6ad0 to master...


Feature cvp deployment

Create workflow to connect ansible-avd to CloudVision server

[x] Convert inventory to container structure
[x] Create dataset for cv_configlet
[x] Create dataset for cv_device (1 configlet per device)
[x] Collect facts (cv_facts)
[x] Create containers (cv_container)
[x] Attach devices to containers (cv_container)
[x] Create configlets (cv_configlet)
[x] Attach configlets to devices (cv_device)
[x] Support Merge mode for configlets / containers
[x] Build Documentation (Module documentation / Role README)

Must be updated to support new AVD outputs

Currently Supported:

Create cvp variables for containers and devices topology
Create cvp variables for configlets
Deploy containers to CVP
Move devices to targetted container
Create configlet on CVP

TODO:

Bind configlet to devices.

PR implement following tasks:

Convert inventory to container structure
Create dataset for cv_configlet
Create dataset for cv_device (1 configlet per device)
Collect facts
Create containers
Attach devices to containers
Create configlets
Attach configlets to devices

Ready for testing at scale

Tested in lab with CVP2018.2.4 / ansible-cvp 1.0.1 / 6 devices (2 spines and 2 pairs of leafs) / devices where in ZTP mode before running playbook

Resync with release-eft to get latest version of roles.

Start rebase with collection structure

Ready to review and merge

Need to update  eos_config_deploy_cvp diagram before publication.

Ready for review by @carlbuchmann


SQL Operations Studio cant expand list of databases.

SQL Operations Studio Version: sqlops 0.23.6 (8a3011756318a2ded1e6e84332230a2b2bf9c544, 2017-11-06T21:51:43.232Z)
OS Version: Windows_NT x64 10.0.15063

Steps to Reproduce:

I cant see all list of databases, however there are a lot of ones.

close as duplicate https://github.com/Microsoft/sqlopsstudio/issues/12


Ellie Link Generator - v1 (Stateless & Messageless Files Only)

Description
This PR showcases basic functionality for the Ellie Link Generator. It generates a simple AST of the file which is able to be manipulated to work in Ellie. It currently works on Stateless and Messageless files, though isn't able to inject the Ant.Css stylesheet into the code yet.
By the way, ignore the first two commits where I was toying around with HTTP requests in JS and Elm.
Additional technical notes can be found on this comment.
Screenshots
(not applicable)
Action Items

[x] I have read the CONTRIBUTING doc
[x] This PR is as small as it can be, and only implements one thing (not many)
[x] I have manually tested my feature
[ ] I have written a "good" amount of tests (including visual and unit tests) (not yet)
[ ] Figure out how to import the defaultStyles for ellie code demos to have correct styling applied
[ ] Export a better "file parser" function in Utils.FileParser.
[x] Use extensible records in Container.elm for more readability.
[ ] Remove hard-coding of ant version in flag declaration and use environment variables

[ ] Specify environment variable name in webpack.config.js

Post-Merge

Add a comment to the Ellie-app issue
Consider maybe creating an issue to add Sentry (or some similar service) and to log parse errors in prod.

I'm still reviewing your PR, but I had a thought pop into my head that I wanted to write down so I didn't forget:
Ellie link generation should only run once for each file and henceforth the output should be saved in memory. Thus, if I:

navigate to, say, https://elm-antd.netlify.app/components/button and click on the ellie links
then go to another page .. i.e. https://elm-antd.netlify.app/components/alert
And then I go back to https://elm-antd.netlify.app/components/button, I shouldn't need to regenerate the ellie links again.

Do you get what I mean?

Thanks for such a detailed code review! Before I fix the issues, I'll just reply to the comment you made earlier:

Ellie link generation should only run once for each file and henceforth the output should be saved in memory (in each page's Model or something like that)

I totally get what you mean, but the good news is that I think this already works that way! The URL Generator only executes every time the ExampleSourceCodeLoaded msg is run, and that is stored in the memory as well. I also looked at the Elm Debugger and the ExampleSourceCodeLoaded isn't rerun when you renavigate to the same page.

Hey, just wanted to thank you again for the great code review. I won't be able to resolve all of them today, but will do them tomorrow or over the weekend. This project is super exciting!

Looks like there's an unrelated issue going on with the visual_tests. Don't worry about that. I can investigate later.

Hey @joshuanianji,
Just want to check in. Any idea on when you'll have some time to continue working on this PR?

Hey @supermacro! I've been really busy lately, but the term is finishing up soon and I hope to continue working on this PR within the next couple of weeks. Sorry for the wait!

Hey @supermacro, I'll be able to work on this PR more often now that my term is almost over. Excited to see this project move forward!

Hey @joshuanianji 👋
Hope you're doing well. I just wanted to check in and see if you have any plans on continuing this work.
Regards,
Gio


Project Console >>CLA Groups : “View Companies” CTA is displayed two times

Summary
“View Companies”  CTA  is coming multiple times
Background
Provide context to the issue - provide steps to reproduce the behavior, such as:

Install the EasyCLA Application.
Add a CLA Group.
Add Contributor License Agreements.

Expected behavior
“View Companies” CTA  should be displayed only once
Screenshots

this is fixed in prod.


[SMALLFIX] Check file equality by comparing URI

Fixes alluxio/new-contributor-tasks#594.

@maobaolong  can you elaborate why we have this fix?
Is it because files[0].getPath() may return null?

@maobaolong

so this change is pending due to the check error shown in above comment, is it?

because the authority of default uri could be different with the current one, and if the authority is null, it may be "null", so we don't care the authority but the path.

close as this PR for now as it is duplicated from https://github.com/Alluxio/alluxio/pull/13560


Allowed memory size of 536870912 bytes exhausted (tried to allocate 253833216 bytes)

Issue on PHP 8.3.3 Laravel 10.45.1
Snippet:
    Route::get('/dashboard', function () {
        xr(auth()->user());
        return view('dashboard');
    })->name('dashboard');

php.ini:
pcre.jit=0
output_buffering=4096

memory_limit=512M
upload_max_filesize=2M

Hello Bruno. Thanks for reporting this.
Could you check if the issue is on the server or the client? You could try using vdd() instead of xr() to determine if the issue is on the client side.

Doing vdd now I get iconv(): Detected an illegal character in input string

Doesn't look good 😅.
Could you get for me a way to replicate this locally? I need to dig a lot and I'm sure that I can nail it. I just need  a basic POC to get into it.

I will do that when I am free :)

Hey, I am back. Sorry for late reply. Here is my setup:

Using Laravel Herd 1.6.0
PHP 8.3.6

Here are the steps to install and replicate:
# Install Laravel installer:
composer global require laravel/installer
laravel new fix-xrdebug
cd fix-xrdebug

Prompt answers:
Laravel Jetstream
<Enter> Livewire
<Enter> (Selects nothing)
<Enter> Pest
<Enter>

Now you should have Jetstream with Livewire installed.
It will prompt you for a db install, just install sqlite.

Once done.

npm run dev # to install UI
php artisan serve # to run server or use xampp or anything server you want

It might ask you to generate a secret, you will see a button when you go on the website: for ex. localhost:8080.
composer require --dev xrdebug/php -W
composer dump-autoload
# run xrdebug server on another terminal meanwhile.

Then go on app/web.php then xr(auth()->user());  for the dashboard path ( for ex. at localhost:8080).
Go on <base url>/register or click on register button on home screen.
Now you should see the error as explained in the issue.
Note:

Just tested on Laravel 11. The issue is still around. Hope it is just my config and its not a general issue! Good luck !

This issue is on the underlying library at chevere/var-dump, seems to be related to how it handles circular references. I don't do that on my daily work, therefore it will take me a ton of time to debug this.

No worries. Why not try debugging it on Laravel itself?

I don't use Laravel and it won't help either, the issue is how VarDump handles known objects, it has a "cache" but at property level, not at the entire debug object. That's why it ends up filling the memory.

It's quite a challenge, so you are digging in vardump directly?

It's quite a challenge, so you are digging in vardump directly?

No, var_dump also gets hung by memory limit. For this stuff I need to use Symfony's VarDumper and basically replicate the "one dump per reference" motto instead of dump every reference until the chevere/var-dump limit (which is a nested level of 100).
As Laravel pass the app reference pretty much everywhere, the Chevere VarDump is not aware of all the times it has printed that reference as is only check per property nesting, not context. This means that it prints every app up to 100 nested levels, and on multi-level it does it again so it fills up really quick.
I need to move the know references to a top level dump collector, and simply print #ref instead of circle it every time.


Plugin not launching

I went to Plugins > Iconify and nothing happens. Restarted Sketch and still no-go.
Please advise. Thank you.

It should open window. What version of Sketch are you using?

Found possible issue. Last version had sketch-module-web-view module with bug that could have caused that issue. Can you download version 1.0.2 (Sketch should update it if you restart it) and try it?

It is working now after updating.
I am running Sketch 52.6

Thanks! Please report any other issues if you find something. This is a new plug-in and my first attempt at making Sketch plug-in, so I'm sure it was not the only bug.


fk processing

added condition to avoid repeating entries for constraints
added else condition to avoid int(None) error

(passed test locally)

could you rebase your changes, so it will be able to run tests before merge

rebased


updated vagrant files to stretch

Updated vm to stretch, updated package location for rethinkdb since there's no package in debian archives, update node to version 8.  Setcap and npm install commands are commented out as they both created issues.  Will need to run npm install on host before starting vm to work in current state.
Confirmed to work on debian testing host.

Thanks for taking a stab at this! The fact that we have to use unofficial Debian packages is really worrying, of course; we most likely will have to transition to a different DB backend (e.g., MongoDB is we want to stay in a similar paradigm) since RethinkDB is going nowhere (even the fork, RebirthDB, seems largely inactive and doesn't publish packages through a signed repo).
Let me poke at this a bit more and see if I can get the npm install working before merging.

Debian has updated to Buster and Rethink has an official package


Docstring not supported on flyteconsole

docstring is already stored in database but not exposed to UI
My idea is to add a docstring column and provide an doc icon to hover. When users hover on the icon, they can see the doc

cc @wild-endeavor @eapolinario


[BUG] Incorrect JVM Version

Is there an existing issue for this?

[X] I have searched the existing issues

🐛 Describe the bug
The current JVM version is set to 1.8 which is legacy nowadays, the better option is to update it to the current LTS.
✔ Expected behavior
No response
👣 Steps to Reproduce
No response
💻 Platform

[X] Windows
[X] macOS
[X] Linux
[X] Other

⭐ Environment
1.0.3-SNAPSHOT
✍ Additional context
No response

The error was with the user


Open org files in another buffer

Thanks for your project, it's really awesome !
I would like to have the same behavior as the gif in your readme : when I click on a node I would like to open it in another buffer, not in the current one (the EAF browser buffer).
It's not the case from scratch, so have you done some modifications in your EAF config to make it possible ?

The EAF in the gif is the stock version, no changes have been made. I don’t use EAF, opened it for the purpose of demonstration.
One way to reproduce what you want is, open an org roam file, open EAF in another buffer. It should open the clicked node in the buffer with the org roam file.

I've tried different setup, but the one with EAF didn't work has excepted for me.
Nevertheless I now use a custom qutebrowser config and it works like a charm.
Thanks.


Optionally specify a data directory for command-line

optionally specify a data directory, change a couple data dir things to prevent crashes on readonly filesystems
#1818

@rmillikin Thanks a lot for fixing this issue. We have a group of users on our HPC cluster waiting to use this software. If the PR will take a while, can we use your forked repo?

@rsdmse I think this should get merged quite soon, but if you want, you can pull the current smithchemwisc/metamorpheus:dev tag from dockerhub which includes this change. usually the dev tag is the current master branch, but I made an exception in this case and pushed this PR to the dev tag for testing in Singularity.
something like this (assuming you're using Singularity to pull from dockerhub):

but in case that doesn't suit your purposes, yes you can definitely build this PR and use it as you wish.

@rsdmse it's not from my forked repo though, it's from a branch in this repo. https://github.com/smith-chem-wisc/MetaMorpheus/tree/optionalDataDir

Thanks so much for your prompt reply!

I was unable to specify and output folder with quotations (either "" or '') which is need for file paths with spaces.
e.g. "C:\User\Bob The Builder\Metamorpheus"

@trishorts this might be a singularity issue but I can poke around for a solution.
https://github.com/hpcng/singularity/issues/5437
https://stackoverflow.com/questions/62963043/escaping-filename-spaces-with-singularity-files-directive


tablePrefix is broken?

Before version 2.0.8 when using tablePrefix it can be useful set column names in ActiveQuery like {{%tableName.columnName}}. Yii was convert this into correct quoted column name 'tbl_tableName'.'columnName'. In Yii 2.0.8 this behavior is broken and no info for workaround can be found.
What steps will reproduce the problem?
Try to search records like:
User::find()->where(['{{%users.email}}' => 'test@email.com'])->one();
What is the expected result?
Expected to see one ActiveRecord of User type.
Expected SQL: SELECT * FROM 'tbl_users' WHERE 'tbl_users'.'email' =<EMAIL_ADDRESS>LIMIT 1
What do you get instead?
Database exception. {{%tableName.columnName}} converts in {{%tableName.'columnName}}'
SQL: SELECT * FROM 'tbl_users' WHERE {{%tbl_users.'email}}' =<EMAIL_ADDRESS>LIMIT 1
Additional info

Q
A

Yii version
2.0.8

PHP version
5.6.17-0+deb8u1

Operating system
Debian 8.0.1

I guess the syntax should be
{{%users}}.email
than you should be fine

Yes, I know how to solve this {{%users}}.email or even {{%users}}.[[email]]. Ive found it in core. But it does not described in docs. And why it was changed? No one word in UPGRADE.md about this change!

http://www.yiiframework.com/doc-2.0/guide-db-dao.html#quoting-table-and-column-names
Previous version are bug https://github.com/yiisoft/yii2/pull/11238

The bug thats working perfectly and as expected (by me) :)


Show multiple cheat sheets when found (#147)

If there are multiple cheat sheets with the same name
in several upstream repositories, show all of them.
To limit output with one single source only,
its name must be prepended to the query with ::
# show the dd cheat sheet from tldr only
curl cht.sh/tldr:dd

# show the dd cheat sheet from all repositories
curl cht.sh/dd

If there are no cheat sheets in the specified repository found,
the default fall back is used.

LGTM. Using f-strings an typing bumps the minimal Python to 3.6. I guess there no value in supporting Python 2.7 compatible codebase for this project.
I think that maybe some verbose mode should also show a direct link to the cheat source code.

Yes and yes.
I think one should switch to Python 3.6+ completely, and cradually update the whole codebase accordingly
(using f-strings, typing hints, etc.).
Regarding the direct link, I plan to add in the same format as we have for stackoverflow:
#  [Justin Peel] [so/q/2835559] [cc by-sa 3.0]

Makes sense for SO. Although Google fails to find [so/q/2835559] - it can only make one's lucky with something like stackoverflow:2835559.

Actually, you are not supposed to use Google here. Just replace so with stackoverflow.com.
It must be a hyperlink in future (not all terminals support this, but many do)

The direct hyperlink to the cheatsheet is what I missed in the past. Discovering where do they come from takes time. That's why it is nice to have verbose mode with full source details.


[5.7] When scheduling a job, respect the already set queue

Resubmit of https://github.com/laravel/framework/pull/25159 with a proper test.

I found I had to explicitly set the connection for my SQS queues to work.
SQS would receive the message but it would continuously retry to process until it went into the dead letter queue.
This failed to process even though my default connection was 'sqs'.
            $queue_name = config('queue.connections.sqs.queue_prefix') . '_manifest';
            $job = (new LoadManifestFile($path))
            	->onQueue($queue_name);

while this worked
            $queue_name = config('queue.connections.sqs.queue_prefix') . '_manifest';
            $queue_connection = config('queue.default');
            $job = (new LoadManifestFile($path))
            	->onQueue($queue_name)
            	->onConnection($queue_connection);

Controller
    public function process(Request $request)
    {
        $path = trim($request->get('path'));
        if (isset($path)) {

            ManifestPath::updateOrCreate(['path' => $path]);
            $queue_name = config('queue.connections.sqs.queue_prefix') . '_manifest';
            $queue_connection = config('queue.default');
            $job = (new LoadManifestFile($path))
            	->onQueue($queue_name)
            	->onConnection($queue_connection);
            $this->dispatch($job);
            return ['data' => [
                'path' => trim($path)
            ]
            ];
        }
        return ['data' => [
            'success' => false
        ]
        ];

    }

Job LoadManifestFile
<?php

namespace App\Manifests\Jobs;

use Exception;
use App\Exceptions\DropboxFileDoesNotExist;
use App\Helpers\Dropbox;
use App\Manifests\Manifest;
use App\Manifests\ManifestPath;
use App\Manifests\Events\ManifestFileError;
use App\Manifests\Events\ManifestFileMoved;
use Illuminate\Bus\Queueable;
use Illuminate\Queue\SerializesModels;
use Illuminate\Queue\InteractsWithQueue;
use Illuminate\Contracts\Queue\ShouldQueue;
use Illuminate\Filesystem\FilesystemManager;
use Log;

class LoadManifestFile implements ShouldQueue
{
    use InteractsWithQueue, Queueable, SerializesModels;
    /**
     * @var
     */
    public $path;

    /**
     * Loads a manifest file into the database
     *
     * @param $path
     */
    public function __construct($path)
    {
        $this->path = $path;
    }

    /**
     * Execute the job.
     *
     * @param Dropbox $dropbox
     * @param Manifest $manifestModel
     */
    public function handle(Dropbox $dropbox)
    {
        $manifestPath = ManifestPath::where('path', $this->path)->first();
        if (isset($manifestPath)) {
            $manifestPath->delete();
        }
        try {
            $content = $this->getContent($dropbox, $this->path);
            $manifest = Manifest::firstOrCreateFromJson($content);
            $dropbox->archiveManifest($this->path,$manifest->getJson($manifest));
            broadcast(new ManifestFileMoved($this->path));
        } catch (Exception $e){
            broadcast(new ManifestFileError($this->path));
        }
    }
    private function getContent(Dropbox $dropbox, $path)
    {
        try {
            $content = $dropbox->getFileOrFail($path);
            return $content;
        } catch (DropboxFileDoesNotExist $exception){
            $this->logError($exception);
        }

    }

    /**
     * @param Exception $error
     */
    public function logError(Exception $error)
    {
        Log::info('LoadManifestFile:' . $error->getMessage());
    }
}

config/queue.php
<?php

return [

    'default' => env('QUEUE_DRIVER', 'sqs'),
    'connections' => [
        'sqs' => [
            'driver' => 'sqs',
            'key' =>  env('SQS_KEY'),
            'secret' =>  env('SQS_SECRET'),
            'prefix' => env('SQS_URL'),
            'queue_prefix' => env('SQS_QUEUE_PREFIX', 'api'),
            'queue' => env('SQS_QUEUE_PREFIX', 'api') . '_general',
            'region' => 'us-east-1',
        ],
    ],
    'failed' => [
        'database' => env('DB_CONNECTION', 'mysql'),
        'table' => 'failed_jobs',
    ],
];

I am having the same issue with redis, it only dispatches to redis if I specify ->onConnection('redis').


ADD Rtum

Team:
Ruthenium teams are located in Singapore and Indonesia, each core member has more than five years of experience in the internet world.
George weiss. is an internet and internet software designer from Australia. He is the CEO of one of the payment and software platforms.
Juan Lee. This is an architect. Interested in all fields of design, including architecture, interior design, graphics, industry and fashion.
hendru Yung. Software engineers, game programmers, robotics engineers, and a group of technology entrepreneurs with a rich background in distributed systems, cryptography, signal processing, mathematics, and statistics.
Criss Emanuel is a proactive, proactive person who is determined to achieve personal and professional goals in the investment management industry today.
Kevin Nicolas. he is a technical project manager with a job history in the information service industry
Basic project information:
The Ruthenium Platform is a payment service for social or independent travel, where the function serves as a medium of exchange or payment for transportation services
More about Rtum
Official website: https://rutenium.com
Github: https://github.com/rutheniumtoken
Twitter: https://twitter.com/Officeruthenium
Telegram: https://t.me/ruthenium_group
Recommended gas limit: 90000

Incorrect information submitted, please go through our guide and check again.


Selection in cmp window not highlighted?

Not sure if there's a conflict with some other setting I have, but I don't see this in any other color scheme.

Here's gruvbox for comparison:

Thanks for pointing this out to me. Identified the problem and working on a fix.


[YUNIKORN-1249] Upgrade ginkgo from v1 to v2

What is this PR for?
Upgrade ginkgo from v1 to v2 and remove the dependency on k8s test framework.
What type of PR is it?

[ ] - Improvement

Todos

[ ] - Task

What is the Jira issue?
https://issues.apache.org/jira/browse/YUNIKORN-1249
How should this be tested?
Screenshots (if appropriate)
Questions:

[ ] - The licenses files need update.
[ ] - There is breaking changes for older versions.
[ ] - It needs documentation.

PR is in good shape. Raised two more follow up jiras YUNIKORN-1648 and YUNIKORN-1649 to address few more things.


Cannot fetching SQLite.swift

A shell task (/usr/bin/env git fetch --prune --quiet https://github.com/stephencelis/SQLite.swift.git refs/tags/:refs/tags/ +refs/heads/:refs/heads/ (launched in /Users/mark/Library/Caches/org.carthage.CarthageKit/dependencies/SQLite.swift)) failed with exit code 1
i can fetching other lib

Please ask on StackOverflow for this kind of questions (we are tracking bugs on GitHub)


TLS with user provided secret doesn't seem to work

Problem statement
While trying to make mTLS between KIC and Admin API work I encountered some difficulties so I thought I'd share some of them.
Using the following script to generate certs and create Kubernetes Secrets:
#!/usr/bin/env bash

set -o pipefail
set -e
set -x

CACERT=ca.crt
CAKEY=ca.key
TLSKEY=tls.key
TLSCERT=tls.crt
TLSCSR=tls.csr

echo "Creating root CA" && \
  openssl \
  req -x509 -sha256 -days 365 -newkey rsa:2048 -nodes \
  -subj "/C=US/ST=County/L=City/O=Kong/OU=Kong_Kubernetes/CN=*.kong.pod.cluster.local" \
  -keyout ${CAKEY} -out ${CACERT}

openssl req -newkey rsa:2048 -keyout ${TLSKEY} -nodes \
  -subj "/C=US/ST=County/L=City/O=Kong/OU=Kong_Kubernetes/CN=*.kong.pod.cluster.local" \
  -out ${TLSCSR}

openssl x509 -req -CA ${CACERT} -CAkey ${CAKEY} -in ${TLSCSR} -out ${TLSCERT} \
  -subj "/C=US/ST=County/L=City/O=Kong/OU=Kong_Kubernetes/CN=*.kong.pod.cluster.local" \
  -days 365 -CAcreateserial -extfile domain.ext

(
cat << EOF
apiVersion: v1
kind: Secret
metadata:
  name: adminapi-cert
  namespace: kong
type: kubernetes.io/tls
data:
  tls.crt: $(base64 -i ${TLSCERT})
  tls.key: $(base64 -i ${TLSKEY})
EOF
) | kubectl apply -f -

(
cat << EOF
apiVersion: v1
kind: Secret
metadata:
  name: ca-cert
  namespace: kong
type: kubernetes.io/tls
data:
  tls.crt: $(base64 -i ${CACERT})
  tls.key: $(base64 -i ${CAKEY})
EOF
) | kubectl apply -f -

domain.ext file
authorityKeyIdentifier=keyid,issuer
basicConstraints=CA:FALSE
subjectAltName = @alt_names
[alt_names]
DNS.1 = *.kong.pod
DNS.2 = *.kong.pod.cluster.local
DNS.3 = *.kong-gateway-admin.kong.svc

and these values.yaml for the ingress chart:
gateway:
  replicaCount: 2
  readinessProbe:
    initialDelaySeconds: 0
    timeoutSeconds: 1
    periodSeconds: 1

controller:
  ingressController:
    image:
      repository: kong/kubernetes-ingress-controller
      tag: "3.0"

    adminApi:
      tls:
        client:
          enabled: true
          # If set to true, you are expected to provide your own secret (see secretName, caSecretName).
          certProvided: true
          # Client TLS certificate/key pair secret name that Ingress Controller will use to authenticate with Kong Admin API.
          # If certProvided is set to false, it is optional (can be specified though if you want to force Helm to use
          # a specific secret name).
          secretName: "adminapi-cert"
          # CA TLS certificate/key pair secret name that the client TLS certificate is signed by.
          # If certProvided is set to false, it is optional (can be specified though if you want to force Helm to use
          # a specific secret name).
          caSecretName: "ca-cert"

    env:
      gateway_discovery_dns_strategy: pod
      log_level: debug
      anonymous_reports: "false"
      kong_admin_tls_skip_verify: "false"

      ## Do we need this?
      # kong_admin_tls_server_name: ""
      kong_admin_ca_cert:
        valueFrom:
          secretKeyRef:
             name: ca-cert
             key: tls.crt

I keep getting
2023-11-06T19:50:58Z    info    setup   Retrying kong admin api client call after error {"v": 0, "retries": "0/60", "error": "making HTTP request: Get \"https://10-244-0-87.kong.pod:8444/\": tls: failed to verify certificate: x509: certificate is not valid for any names, but wanted to match 10-244-0-87.kong.pod"}

The certificates I'm able to get from the Admin API seem to be OK:
k get secret -n kong adminapi-cert -o jsonpath='{.data.tls\.crt}' | base64 -d | openssl x509 -text | less
Certificate:
    Data:
        Version: 3 (0x2)
        Serial Number:
            59:d1:b8:63:5a:46:76:8c:2c:13:0d:bb:aa:01:cd:ae:78:f6:99:7c
        Signature Algorithm: sha256WithRSAEncryption
        Issuer: C = PL, ST = County, L = City, O = Kong, OU = Kong_Kubernetes, CN = *.kong.pod.cluster.local
        Validity
            Not Before: Nov  6 19:27:10 2023 GMT
            Not After : Nov  5 19:27:10 2024 GMT
        Subject: C = PL, ST = County, L = City, O = Kong, OU = Kong_Kubernetes, CN = *.kong.pod.cluster.local
        Subject Public Key Info:
            Public Key Algorithm: rsaEncryption
                Public-Key: (2048 bit)
                Modulus:
                    00:cc:fe:aa:c3:d8:6f:f8:6d:64:a3:ad:5b:62:42:
                    0f:a4:45:d6:37:df:60:10:34:dc:3b:1f:66:e4:5c:
                    12:47:cf:4a:cd:94:21:96:81:51:6a:6b:20:63:08:
                    34:71:2f:29:9a:69:cf:e4:80:10:0f:a3:1b:c4:d4:
                    36:c3:b7:45:d6:6e:a3:50:93:ac:c4:d5:49:16:ab:
                    a3:28:40:c2:ab:bd:9b:6f:9d:25:f1:3f:7e:fd:13:
                    a7:0c:c9:30:ae:2a:1d:42:3b:23:dd:03:dd:df:0f:
                    12:26:60:df:49:ec:24:e0:3f:49:38:f3:0c:0a:c2:
                    47:cf:35:d6:65:36:84:8d:e4:e5:e6:55:ec:41:34:
                    10:d4:40:06:c2:1e:38:1c:28:5c:b3:93:69:49:a8:
                    05:22:9f:f5:de:3e:0b:f5:a4:0c:f0:13:e2:18:67:
                    45:40:df:21:8a:08:c9:e3:2e:05:94:0e:4b:0d:85:
                    fd:fe:a6:96:9e:fb:12:59:d1:fc:e6:73:89:0f:65:
                    07:de:5d:b9:39:d2:fa:77:06:bb:8f:25:42:af:ce:
                    78:7d:08:ad:dd:a0:19:ca:15:6d:5b:d1:84:2f:0a:
                    ec:a2:85:67:aa:25:6a:ab:7c:8b:e6:ff:56:f0:53:
                    dd:2a:70:7f:7b:85:fe:16:06:80:99:e8:ae:17:38:
                    df:eb
                Exponent: 65537 (0x10001)
        X509v3 extensions:
            X509v3 Authority Key Identifier:
                C9:2E:D0:77:1B:FB:63:71:02:7F:1E:A8:C3:5F:BB:8C:2D:85:A2:4E
            X509v3 Basic Constraints:
                CA:FALSE
            X509v3 Subject Alternative Name:
                DNS:*.kong.pod, DNS:*.kong.pod.cluster.local, DNS:*.kong-gateway-admin.kong.svc
            X509v3 Subject Key Identifier:
                62:CA:00:D1:E8:48:51:7B:B7:DF:17:8D:EB:3E:09:C4:89:A1:01:58
    Signature Algorithm: sha256WithRSAEncryption
    Signature Value:
        72:33:09:24:92:2b:12:a2:0c:e3:5a:f7:e3:a7:f2:c5:e5:4e:
        3d:51:29:68:16:b6:12:fc:7a:a4:33:58:b4:60:80:30:52:dd:
        e3:38:d3:b1:28:45:29:86:c9:53:f4:a8:c8:ca:9d:87:c8:77:
        ee:1d:ea:c8:1f:81:aa:87:6d:ec:16:cd:be:08:b8:ad:1a:a9:
        24:7f:9b:b9:b3:c1:44:7f:a7:4e:91:5b:b9:2b:1e:f4:28:3e:
        f8:a8:8e:14:5f:09:37:9b:e8:cf:40:e7:b7:1f:88:25:d2:75:
        17:cf:4b:3a:ad:58:1f:71:62:db:c9:60:10:33:13:b4:b9:6a:
        7c:74:b5:68:14:73:89:0e:70:c1:33:0b:d5:f9:07:a1:11:7b:
        43:a8:58:55:21:c2:a6:3c:df:40:5d:14:88:f8:b3:30:6a:59:
        0b:2c:c3:d7:85:e2:81:4f:fd:e6:f6:7b:3e:8f:64:72:04:c5:
        c6:80:18:96:b5:20:c2:9f:71:a6:a5:47:1d:0a:b5:4d:c5:e9:
        b7:f9:25:87:58:e0:9a:f6:9c:0a:8a:58:2e:6d:19:32:94:05:
        de:e9:6b:a8:88:dd:92:fe:9f:95:b9:ab:1b:e1:b4:eb:ad:df:
        62:33:4f:e4:d0:df:5c:67:76:29:33:4f:38:fd:5e:49:93:f0:
        10:d6:52:8e
-----BEGIN CERTIFICATE-----
MIIEHzCCAwegAwIBAgIUWdG4Y1pGdowsEw27qgHNrnj2mXwwDQYJKoZIhvcNAQEL
BQAweTELMAkGA1UEBhMCUEwxDzANBgNVBAgMBkNvdW50eTENMAsGA1UEBwwEQ2l0
eTENMAsGA1UECgwES29uZzEYMBYGA1UECwwPS29uZ19LdWJlcm5ldGVzMSEwHwYD
VQQDDBgqLmtvbmcucG9kLmNsdXN0ZXIubG9jYWwwHhcNMjMxMTA2MTkyNzEwWhcN
MjQxMTA1MTkyNzEwWjB5MQswCQYDVQQGEwJQTDEPMA0GA1UECAwGQ291bnR5MQ0w
CwYDVQQHDARDaXR5MQ0wCwYDVQQKDARLb25nMRgwFgYDVQQLDA9Lb25nX0t1YmVy
bmV0ZXMxITAfBgNVBAMMGCoua29uZy5wb2QuY2x1c3Rlci5sb2NhbDCCASIwDQYJ
KoZIhvcNAQEBBQADggEPADCCAQoCggEBAMz+qsPYb/htZKOtW2JCD6RF1jffYBA0
3DsfZuRcEkfPSs2UIZaBUWprIGMINHEvKZppz+SAEA+jG8TUNsO3RdZuo1CTrMTV
SRaroyhAwqu9m2+dJfE/fv0TpwzJMK4qHUI7I90D3d8PEiZg30nsJOA/STjzDArC
R8811mU2hI3k5eZV7EE0ENRABsIeOBwoXLOTaUmoBSKf9d4+C/WkDPAT4hhnRUDf
IYoIyeMuBZQOSw2F/f6mlp77ElnR/OZziQ9lB95duTnS+ncGu48lQq/OeH0Ird2g
GcoVbVvRhC8K7KKFZ6olaqt8i+b/VvBT3Spwf3uF/hYGgJnorhc43+sCAwEAAaOB
njCBmzAfBgNVHSMEGDAWgBTJLtB3G/tjcQJ/HqjDX7uMLYWiTjAJBgNVHRMEAjAA
ME4GA1UdEQRHMEWCCioua29uZy5wb2SCGCoua29uZy5wb2QuY2x1c3Rlci5sb2Nh
bIIdKi5rb25nLWdhdGV3YXktYWRtaW4ua29uZy5zdmMwHQYDVR0OBBYEFGLKANHo
SFF7t98Xjes+CcSJoQFYMA0GCSqGSIb3DQEBCwUAA4IBAQByMwkkkisSogzjWvfj
p/LF5U49USloFrYS/HqkM1i0YIAwUt3jONOxKEUphslT9KjIyp2HyHfuHerIH4Gq
h23sFs2+CLitGqkkf5u5s8FEf6dOkVu5Kx70KD74qI4UXwk3m+jPQOe3H4gl0nUX
z0s6rVgfcWLbyWAQMxO0uWp8dLVoFHOJDnDBMwvV+QehEXtDqFhVIcKmPN9AXRSI
+LMwalkLLMPXheKBT/3m9ns+j2RyBMXGgBiWtSDCn3GmpUcdCrVNxem3+SWHWOCa
9pwKilgubRkylAXe6WuoiN2S/p+Vuasb4bTrrd9iM0/k0N9cZ3YpM084/V5Jk/AQ
1lKO
-----END CERTIFICATE-----

Trying to access port forwarded Admin API yields:
openssl s_client -showcerts -connect localhost:8443  </dev/null
CONNECTED(00000006)
Can't use SSL_get_servername
depth=0 C = US, ST = California, L = San Francisco, O = Kong, OU = IT Department, CN = localhost
verify error:num=18:self-signed certificate
verify return:1
depth=0 C = US, ST = California, L = San Francisco, O = Kong, OU = IT Department, CN = localhost
verify return:1
---
Certificate chain
 0 s:C = US, ST = California, L = San Francisco, O = Kong, OU = IT Department, CN = localhost
   i:C = US, ST = California, L = San Francisco, O = Kong, OU = IT Department, CN = localhost
   a:PKEY: id-ecPublicKey, 256 (bit); sigalg: ecdsa-with-SHA256
   v:NotBefore: Nov  6 19:27:22 2023 GMT; NotAfter: Nov  1 19:27:22 2043 GMT
-----BEGIN CERTIFICATE-----
MIICODCCAd2gAwIBAgIRAIItPBY9Yib9NQTnk7hI+2gwCgYIKoZIzj0EAwIwdTEL
MAkGA1UEBhMCVVMxEzARBgNVBAgMCkNhbGlmb3JuaWExFjAUBgNVBAcMDVNhbiBG
cmFuY2lzY28xDTALBgNVBAoMBEtvbmcxFjAUBgNVBAsMDUlUIERlcGFydG1lbnQx
EjAQBgNVBAMMCWxvY2FsaG9zdDAeFw0yMzExMDYxOTI3MjJaFw00MzExMDExOTI3
MjJaMHUxCzAJBgNVBAYTAlVTMRMwEQYDVQQIDApDYWxpZm9ybmlhMRYwFAYDVQQH
DA1TYW4gRnJhbmNpc2NvMQ0wCwYDVQQKDARLb25nMRYwFAYDVQQLDA1JVCBEZXBh
cnRtZW50MRIwEAYDVQQDDAlsb2NhbGhvc3QwWTATBgcqhkjOPQIBBggqhkjOPQMB
BwNCAAS/+jrg1VzawnnvB6X5Kovm9Ko3XqcUZY0IsLjKmdRFsDNGAuodn56sP/U+
4NUISjdSCEPlyHgbX9ugMFJferI5o04wTDAMBgNVHRMBAf8EAjAAMB0GA1UdJQQW
MBQGCCsGAQUFBwMBBggrBgEFBQcDAjAdBgNVHQ4EFgQUgQQzAgwonXBBtjyCVqEu
0I6WI98wCgYIKoZIzj0EAwIDSQAwRgIhAMF4E5n1/rkhOQRThnn2uwlxNvzmPX6e
2MgXX0KpmpNzAiEAn7ARBPKlhvHza+8m/luo3VJUyCXasQze76TlQ098n/I=
-----END CERTIFICATE-----
---
Server certificate
subject=C = US, ST = California, L = San Francisco, O = Kong, OU = IT Department, CN = localhost
issuer=C = US, ST = California, L = San Francisco, O = Kong, OU = IT Department, CN = localhost
---
No client certificate CA names sent
Peer signing digest: SHA256
Peer signature type: ECDSA
Server Temp Key: X25519, 253 bits
---
SSL handshake has read 942 bytes and written 373 bytes
Verification error: self-signed certificate
---
New, TLSv1.3, Cipher is TLS_AES_256_GCM_SHA384
Server public key is 256 bit
This TLS version forbids renegotiation.
Compression: NONE
Expansion: NONE
No ALPN negotiated
Early data was not sent
Verify return code: 18 (self-signed certificate)
---
DONE

(I've tried use different hostname to access it via /etc/hosts but with the same result)

Simple answer here is that the Kong config doesn't have the cert set up. It needs something roughly along the lines of https://github.com/Kong/charts/blob/main/charts/kong/README.md#certificates but for gateway.env.admin_ssl_cert and gateway.env.admin_ssl_cert_key.
That sets up the server certificate serving on the gateway, but not verification of the client certificate presented by the controller. IIRC that relies on injecting NGINX directives (similar to step 8 in https://docs.nginx.com/nginx-management-suite/admin-guides/configuration/secure-traffic/, the ssl_client_certificate and ssl_verify_client bits, so gateway.env.nginx_admin_ssl_client_certificate pointed to the mounted CA cert and gateway.env.nginx_admin_ssl_verify_client=on). I don't think there was ever any dedicated kong.conf functionality for it, and the community addition of the controller client certificate args just used that.
Did you have a doc you were working from? I forget what we created for the rollout of the ingress chart, and it doesn't look like there's anything in the chart README.md for it. We probably want to just inject it automatically in the long run, but can't really with an umbrella chart--one or the other won't be able to reference generated resources easily.
In classical very backwards fashion I pulled this out by decrypting the comms between the two, which was probably unnecessary (coulda just hit the admin API with curl to see the cert details), but I wanted to confirm how to do it. Golang has no runtime built-in key log dump, and you need to modify code:
ingress-controller-key-dump.diff.txt
go-kong-dump.diff.txt
The controller change is the one actually needed, since go-kong lets you provide your own client and we do. Left as a diff archive since I did a hack job and it's one of those things where we probably shouldn't ship it without a global --enforce-production to just exit immediately if anything like that is on.
From there you can dump traffic and kubectl cp the key dumps for Wireshark's TLS decrypt.

Thanks for pointing me to these envs!
I managed to make it works with the following values:
gateway:
  admin:
    tls:
      client:
        secretName: "ca-cert"
  replicaCount: 2
  env:
    admin_ssl_cert: /etc/secrets/adminapi-cert/tls.crt
    admin_ssl_cert_key: /etc/secrets/adminapi-cert/tls.key
  secretVolumes:
  - adminapi-cert

controller:
  ingressController:
    image:
      repository: kong/kubernetes-ingress-controller
      tag: "3.0"

    adminApi:
      tls:
        client:
          enabled: true
          # If set to true, you are expected to provide your own secret (see secretName, caSecretName).
          certProvided: true
          # Client TLS certificate/key pair secret name that Ingress Controller will use to authenticate with Kong Admin API.
          secretName: "client-adminapi-cert"
          # CA TLS certificate/key pair secret name that the client TLS certificate is signed by.
          caSecretName: "ca-cert"

    env:
      gateway_discovery_dns_strategy: pod
      log_level: debug
      anonymous_reports: "false"
      kong_admin_tls_skip_verify: "false"

      kong_admin_ca_cert:
        valueFrom:
          secretKeyRef:
             name: ca-cert
             key: tls.crt

and the slightly modified script for the certs:
#!/usr/bin/env bash

set -ex -o pipefail

readonly CACERT=ca.crt
readonly CAKEY=ca.key
readonly TLSKEY=tls.key
readonly TLSCERT=tls.crt
readonly TLSCSR=tls.csr
readonly CLIENTTLSKEY=clienttls.key
readonly CLIENTTLSCERT=clienttls.crt
readonly CLIENTTLSCSR=clienttls.csr

readonly DAYS=365
readonly BITS=4096
readonly NAMESPACE=kong

test -f ${CACERT} || (echo "Creating root CA" && \
  openssl \
  req -x509 -sha256 -days ${DAYS} -newkey rsa:${BITS} -nodes \
  -subj "/C=US/ST=California/L=San Francisco/O=Kong/OU=Kong_Kubernetes/CN=ca.kong.pod" \
  -keyout ${CAKEY} -out ${CACERT})

openssl req -newkey rsa:${BITS} -keyout ${TLSKEY} -nodes \
  -subj "/C=US/ST=California/L=San Francisco/O=Kong/OU=Kong_Kubernetes/CN=*.kong.pod" \
  -out ${TLSCSR}

openssl x509 -req -CA ${CACERT} -CAkey ${CAKEY} -in ${TLSCSR} -out ${TLSCERT} \
  -subj "/C=US/ST=California/L=San Francisco/O=Kong/OU=Kong_Kubernetes/CN=*.kong.pod" \
  -days ${DAYS} -CAcreateserial -extfile domain.ext

openssl req -newkey rsa:${BITS} -keyout ${CLIENTTLSKEY} -nodes \
  -subj "/C=US/ST=California/L=San Francisco/O=Kong/OU=Kong_Kubernetes/CN=client.kong.pod" \
  -out ${CLIENTTLSCSR}

openssl x509 -req -CA ${CACERT} -CAkey ${CAKEY} -in ${CLIENTTLSCSR} -out ${CLIENTTLSCERT} \
  -subj "/C=US/ST=California/L=San Francisco/O=Kong/OU=Kong_Kubernetes/CN=client.kong.pod" \
  -days ${DAYS} -CAcreateserial

function secret()
{
  local NAME=${1}
  local NS=${2}
  local CERT=${3}
  local KEY=${4}
kubectl apply -f - <<EOF
apiVersion: v1
kind: Secret
metadata:
  name: "${NAME}"
  namespace: ${NS}
type: kubernetes.io/tls
data:
  tls.crt: $(base64 -i ${CERT})
  tls.key: $(base64 -i ${KEY})
EOF
}

secret client-adminapi-cert ${NAMESPACE} ${CLIENTTLSCERT} ${CLIENTTLSKEY}
secret adminapi-cert ${NAMESPACE} ${TLSCERT} ${TLSKEY}
secret ca-cert ${NAMESPACE} ${CACERT} ${CAKEY}

(domain.ext stays as is)
2023-11-07T18:48:22Z    debug   events  successfully applied Kong configuration to https://10-244-0-200.kong.pod:8444   {"v": 1, "type": "Normal", "object": {"kind":"Pod","namespace":"kong","name":"kong-controller-7cb994b99f-xpxd8","apiVersion":"v1"}, "reason": "KongConfigurationSucceeded"}

Given the above I wonder if we should close this or consider using this content in a guide in the docs or elsewhere 🤔 ? We don't seem to have a comprehensive guide saying how to configure this. We mostly cover the case of getting and configuring the cert at the ingress level.

Yeah, this basically becomes a docs ticket.
Per Michael we originally had this in https://docs.konghq.com/kubernetes-ingress-controller/2.12.x/guides/using-gateway-discovery/#installation but it hadn't gotten ported yet.


CoreDslOutlineTreeProvider can't handle cyclic dependencies

The following code snippet causes Eclipse to crash because it generates a stack overflow when generating the outline view.
InstructionSet A extends A {}

Aside of the stack overflow this should not be valid code since an ISA is referenced in the declaration. and this would happen in circular description...

This is fixed with the latest XText version used in #33


Feature/Functionality Requests: Legacy Judge QOL - Mercurial Item Entry and CS PDF Exporter

Feature/Function Request 1: Allow Mercurial Effects to be entered as items from a compendium.
Benefit: This will benefit Legacy Judge's in preparation of games for players coming from other systems of play, and cut down prep time for the Wizard and Elf classes.
Feature/Function Request 2: Allow the Judge or Player to export a character onto the Form Fillable PDF offered through Legacy rulings so that it can be distributed immediately after players have updated the sheet for the next Legacy game.
Feature/Function Request 3: Is it possible to add designated fields in character sheets to indicate currency, which can potentially be used in reference to the item prices in the compendium. My thought here is the eventuality of having more in relation to loot sheets, shops, etc.

I'm closing this but I've created individual issues for each item. I've also added some comments below.

Feature/Function Request 1: Allow Mercurial Effects to be entered as items from a compendium.
Benefit: This will benefit Legacy Judge's in preparation of games for players coming from other systems of play, and cut down prep time for the Wizard and Elf classes.

I'll have a think about the best way to do this. Currently we support assigning from the number but I know you mentioned this doesn't always help if people don't keep their legacy sheets well. Maybe it can just be a dropdown on the spell sheet if the Core Book is loaded, but I need to think about how it would fit in the UI.

Feature/Function Request 2: Allow the Judge or Player to export a character onto the Form Fillable PDF offered through Legacy rulings so that it can be distributed immediately after players have updated the sheet for the next Legacy game.

I had a play with this before ReaverCon and I discovered that it was easy to get into a PDFoundry sheet, but this doesn't help as there's no way to export a PDF from it. They were originally considering this as a feature, but appear to have abandoned that due to security concerns. There are other services that generate PDFs online, but none that I found that work with form fillable sheets so I didn't get very far. There's also the issue of how we distribute the PDFs to think about.
I've seen talk on the Foundry Discord that someone was working on a PDF Exporter module. If that gets off the ground we can integrate with it.

Feature/Function Request 3: Is it possible to add designated fields in character sheets to indicate currency, which can potentially be used in reference to the item prices in the compendium. My thought here is the eventuality of having more in relation to loot sheets, shops, etc.

I like this idea and I'm not too happy with the current solution of merging 'As Coin's items into one of those items.


md-autocomplete error - Invalid regular expression unterminated group or end of pattern

Bug, feature request, or proposal:
I used md-autocomplete from this gide - https://material.angular.io/components/component/autocomplete
What is the expected behavior?
When i writing this symbols '/()' i've got console.error ' Invalid regular expression: {my value}: at end of pattern'  or 'Invalid regular expression: {my value}: Unterminated group'
My application is being stopped because of this.
What are the steps to reproduce?
I need a solution without errors
What is the use-case or motivation for changing an existing behavior?
It's strange, bit this example https://material.angular.io/components/component/autocomplete causes an error in a similar case too

See #4440

@willshowell  Good! it's work if i don't use RegExp

Should be closed via https://github.com/angular/material2/pull/4921

Should be resolved in master.


ipc_service: icmsg: Improve packets reception

This improves packets reception in the icmsg backend. The remote can receive the same amount of data that were send by host. It removes local data coping into the internal buffer and fix and issue where data from host larger than remote buffer was silently dropped. Additionally this PR contains documentation clarification for the spsc_pbuf_claim function.

Just rebase plus small naming change send_buffer->tx_buffer

Just come comments to consider.

@emob-nordic can you take ownership of subsys/ipc/ipc_service/lib/icmsg.c as well in the CODEOWNERS file?


Something Went Wrong - Power Toys Run

Microsoft PowerToys version
"0.62.1"
Running as admin

[ ] Yes

Area(s) with issue?
PowerToys Run
Steps to reproduce
Just started searching for my name "sridhar", then I got something went wrong
✔ Expected Behavior
Looking for search results on my PC, what are the files I have with my name?
❌ Actual Behavior

Other Software
No response

Same here with 0.62.1 in Admin Mode. As far as I was able to reproduce the bug, it does not matter what I'm searching for. Just happens sporadically.
Full bug report zip:
PowerToysReport_2022-09-29-10-50-01.zip

Can you please upgrade to latest 0.73 and verify if the issue still occur?
/needinfo


Prevent Mouse Clicks If Another App Is in Use

Is there a way to prevent unwanted clicks? The wallpaper shouldn't respond if I click on VS Code or any other application. Or a listener triggered whenever another app is active in the entire visible area would suffice.
I've tried using focus and blur listeners, but the page seems to stay in focus all the time.
https://github.com/user-attachments/assets/e2757b27-99e6-4221-a518-91382b3695af

Yes that's what I'm working on.

I appreciate the effort.


[Port] Use standard key events for Notebook keybindings (#17880)

Fixes https://github.com/microsoft/azuredatastudio/issues/17878
Fixes keybindings on Windows.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 17 (0.0%)  changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.0009%) to 41.715%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/sql/workbench/contrib/notebook/browser/cellViews/markdownToolbar.component.ts
0
6
0.0%

src/sql/workbench/contrib/notebook/browser/cellViews/textCell.component.ts
0
11
0.0%

Totals

Change from base Build<PHONE_NUMBER>:
-0.0009%

Covered Lines:
27293

Relevant Lines:
59373

💛  - Coveralls


[Feature Request] Multiple Profiles

I'd like to be able to quickly switch between game profiles.
For me the main reason I want this is because I'd like to read multiple games in the same day, and quickly switch without having to change the title, port, etc. If you're only reading one game this isn't an issue, but if you're reading two or three, it can be a little tedious.
For instance reading うみねこ２ & 魔法使いの夜, I'd like to create two "profiles" and have the settings switch when I select one.
I was proof of concepting something on my own, before I found this, but was thinking it would be something along these lines:

You could select a game from a profile, and it would switch settings, like title, port to connect on, clipboard listening, vertical text, etc. The box all the way on the left being a title override - I'm not tied to the UI, just throwing it out there.
This would be particularly useful with Agent & textractor coexisting, as they could bind to different ports and you could have both programs open without issue while using the hook page, and switch between multiple games open without having to open and close them constantly. To take it a step further, you could use the metadata sent by TextractorSender or Agent to automatically detect the apps path and switch profiles automatically.

I'll leave it open and consider to add it when i find time.. though i will leave it to be like a simple "settings-as-of-the-time-of-saving" list of "presets" the user can switch between... something like storing lines etc. will stay global for the time being as all the data is stored in local storage which is capped at 5mb and would probably fill it up very quickly in that way

One thought I had was just making a copy of the index.html locally, and using that file/page as a second profile.
Unfortunately it looks like chrome shares localstorage across all the files? I didn't dive into it any deeper yet.
If there's some workaround there to allow different file:// uri's as different "namespaces" that could act as a basic profile system with little need to refactor.

for now i think i would still prefer to store a list of configuration arrays with user friendly names rather  then starting to namespace it by location etc.


Issues with pandas Timedelta - init and addition

Environment data

Language Server version: 2020.9.7
OS and version: Windows 10
Python version (& distribution if applicable, e.g. Anaconda): Anaconda Python 3.7.5

Expected behaviour
No error
Actual behaviour
import pandas as pd

ts = pd.Timestamp("10/1/2020 10:00")
td = pd.Timedelta(minutes=10)

sm = ts + td
print(sm)

reports 3 issues

On the pd.Timestamp line is the same issue as reported in #427
On the pd.Timedelta line is the message Argument missing for parameter "value"
On the line with the sum, is the message:

Operator "+" not supported for types "Timestamp" and "Timedelta"
  Operator "+" not supported for types "Timestamp" and "Timedelta"

Possible fix (not sure if the __new__ part is right, but it worked!), which include the suggested fixes in #427 and #436
diff __init__.pyi.ORIG __init__.pyi
119,120c119,120
< class Timedelta(object):
<     def __init__(self, value: Any, unit: str = ..., **kwargs) -> None: ...
---
> class Timedelta(datetime.timedelta):
>     def __init__(self, value: Any = ..., unit: str = ..., **kwargs) -> None: ...
149c149,151
< class Timestamp(object):
---
> class Timestamp(datetime.datetime):
>     @override
>     def __new__(self, ts_input: Any, **kwargs): ...
153,158c155,160
<         freq: Any,
<         tz: Any,
<         unit: str,
<         year: int,
<         month: int,
<         day: int,
---
>         freq: Any = ...,
>         tz: Any = ...,
>         unit: str = ...,
>         year: int = ...,
>         month: int = ...,
>         day: int = ...,
243c245
<     def strftime(self) -> str: ...
---
>     def strftime(self, fmt:str) -> str: ...

This issue has been fixed in version 2020.10.0, which we've just released. You can find the changelog here: https://github.com/microsoft/pylance-release/blob/master/CHANGELOG.md#2020100-7-october-2020

Hi, has this issue returned?  As far as I can tell, I'm currently seeing it on v2023.2.30.  See screenshots below, in which Pylance misidentifies a pd.Timestamp as a pd.Timedelta following .  Perhaps it is due to my older Python and Pandas versions:

Python v3.6.8
Pandas v1.1.5

Location of warning:

Description of warning:

Version of Pylance:

@bschnurr (sorry! just tagging someone who appears to be an active contributor - looks like @jakebailey no longer works on this repo)

Please report any issues with pandas stubs in the pandas-stubs repo.  https://github.com/pandas-dev/pandas-stubs
Don't use screenshots - if we are to test this, we need to copy/paste code samples.
With python 3.9, your issue doesn't occur.  You might be having a problem because you are using an old version of python as well as a very old version of pandas.  We test the stubs with python 3.8 through 3.11, and only with the latest release of pandas (currently 1.5.3)


version mismatch with wrenc?

Your instructions for installing wren locally on Linux (https://exercism.org/docs/tracks/wren/installation) are for wrenc v0.2.90 (wren v0.4.0). This installed successfully and I could run wrenc to get a console prompt, but package installation failed. Running wrenc package.wren install gave the error "Could not load module 'wren-package'." and I got a similar error from the wren console prompt.
The repo https://github.com/joshgoebel/wren-console/releases currrently gives v0.3.1 (dated Nov 2021), and this seems to have none of the same problems: at least with hello-world, I haven't got further yet. I'm not sure of the best way to respond - maybe update the installation instructions to v0.3??
Thanks for providing this resource, I now look forward to learning the language.

Exactly. I think I completed the docs before everything was good and ready. I'll get the version numbers updated soon. Thanks.

@colinleach Check #125

I'm a bit confused by the github workflow, but the changes look good - thank you!

New version of libc incompatible with Wren 0.4.0... it needs a small patch, but that's not going to matter for just a docfix.

libc is far beyond my expertise (sorry - I'm a retired organic chemist, not an IT professional). What I will say is that I came to Wren via the 12in23 challenge and I very much hope others will too. It would be a pity to repel them at Hello World: your language deserves more respect.

Not my language. I only helped build out the track and tooling. But yes, Wren is awesome.

The docs say 3.1 now... can this be closed?


0.1.5版本安装失败

如题，pub get 时候提示：
Because chart_demo depends on mp_chart ^0.1.5 which doesn't match any versions, version solving failed.
pub get failed (1; Because chart_demo depends on mp_chart ^0.1.5 which doesn't match any versions, version solving failed.)

估计要翻墙，我这开了vpn是行的


Can't make it work...

Hi,
I'm using Phystrix to call a web service to print something on a web page.
Each time I call my page which the extern web service unavalaible:

the HealthCountsSnapshot values never change
so the circuit is never open
for each call the result of allowRequest is always TRUE

What I understand from the code :

the values are never store in (apc  is for statistic purpose only) so the next request don't know what happened before
the code is the same than Hystrix (java) and that is the issue, the java thread stay in memory and so the values, not in php.

Is that a correct analysis?
Maybe I'm using Phystrix badly.
I'm waiting for your answer.
Best regards
FL

Well, same problem.
https://github.com/upwork/phystrix/blob/c8ac8984e3ac754e733ac6cf3f109eeb75bf66e9/library/Odesk/Phystrix/MetricsCounter.php#L111
Here, each executes command has a new timestamp, so when get function execute, It must be 0. Maybe I have made some mistake.
Thank you for your effort.

Hi, the code is not the same as Java's code. In fact, most of the work behind Phystrix was assessing tools and technologies available to make the concept work in PHP environment.
APC is used to store the metrics and they are preserved between requests, that is the point. Only when the command is considered unhealthy the circuit is open. We have been using Phystrix in high load enterprise applications for a few years now.
I hope this helps. @LFranck If you can provide steps to reproduce the issue you're having, I would take take a look.
@persevereVon could you rephrase your comment, or better create a separate issue

Hi,
I'm using ab (apache benchmark) to call the page 1000 times without connection.
I see :

the fallback is called
but the counter never change
allowRequest return always true
the circuit is never Open

Please, tell me where in the code the values of HealthCountsSnapshot are saved for the next php thread.
If not, how other php thread work ?
best regards
FL

@lcf sorry for my English. And I have a question, if I change the cache engine to redis, is it still working properly? thank you!

@persevereVon
Can you create your own issue and not disturb mine, please ?

@LFranck OK, sorry

Cleared up the thread a little. @LFranck when execute sees a failure, it will call markFailure method which will increment value in APC in a tread safe manner, so all failures are counted.
Data in APC will be available until the bucket expires.

I FOUND IT ! I FOUND IT !!!
Just here in odesk\phystrix-bundle\Resources\config\config.yml
By default :
phystrix.state_storage.class: Odesk\Phystrix*ArrayStateStorage*
And I need :
phystrix.state_storage.class: Odesk\Phystrix*ApcStateStorage*
But now, I have an another issue : my apache work with OPcache
and I read than both can't be installed in same time.
thanks
FL

End of the story :
with the correct configuration and apcu installed, everything is fine.
Thanks for your help.
FL

I believe that's actually a mistake in the bundle component. Array adapter is only to be used for testing and development environment. I don't think it should be the default.
I'll look into it, thank you @LFranck!


Force enhanced error handling to all updated providers

🗣 Description

The "if" is no longer needed. There were some cases where this actually caused bugs in the report output. It's been so long though that those bugs may or may not be able to be replicated at this point. But as a defensive measure we should remove the if that's no longer needed.

Removal of the if statement is implemented in this change.

💭 Motivation and context

closes #145

🧪 Testing

Generate report before if removal using  same reproduction code in issue:

.\Testing\Functional\RegoCachedProviderTesting.ps1 -ProductNames aad -LogIn $true -ExportProvider $true -Quiet $false

 .\Testing\Functional\RegoCachedProviderTesting.ps1 -ProductNames aad -LogIn $false -ExportProvider $false -Quiet $false

 .\Testing\Functional\RegoCachedProviderTesting.ps1 -ProductNames aad,teams -LogIn $false -ExportProvider $false -Quiet $false

Generate report after if statement removed using above code
Compare reports

✅ Pre-approval checklist

[x] This PR has an informative and human-readable title.
[x] PR targets the correct parent branch (e.g., main or release-name) for merge.
[x] Changes are limited to a single goal - eschew scope creep!
[x] Changes are sized such that they do not touch excessive number of files.
[x] All future TODOs are captured in issues, which are referenced in code comments.
[x] These code changes follow the ScubaGear content style guide.
[x] Related issues these changes resolve are linked preferably via closing keywords.
[x] All relevant type-of-change labels added.
[x] All relevant project fields are set.
[x] All relevant repo and/or project documentation updated to reflect these changes.
[x] Unit tests added/updated to cover PowerShell and Rego changes.
[x] Functional tests added/updated to cover PowerShell and Rego changes.
[x] All relevant functional tests passed.
[ ] All automated checks (e.g., linting, static analysis, unit/smoke tests) passed.

✅ Pre-merge checklist

[ ] PR passed smoke test check.

[ ] Feature branch has been rebased against changes from parent branch, as needed
Use Rebase branch button below or use this reference to rebase from the command line.

[ ] Resolved all merge conflicts on branch

[ ] Notified merge coordinator that PR is ready for merge via comment mention

✅ Post-merge checklist

[ ] Feature branch deleted after merge to clean up repository.
[ ] Verified that all checks pass on parent branch (e.g., main or release-name) after merge.

There's the one line I commented about above that I'd like you to remove, but other than this, this looks good so. I tested this (with that line removed) and the error handling still works as expected. I also tested using the rego cached provider testing and played around with manually tweaking the "teams_successful_commands" list (including removing the key entirely). In all cases, it worked as expected.
So address that small change and then I'll approve.

Whoops, I meant to request changes not approve. I'll leave it be as it's such a small change, but please do still make the change :)


Quasar Framework project with Oidc-client

This is an example of how to use the oidc-client library with the Quasar framework.
There are some details to configure it with Quasar, so I think it would be worth adding it to the wiki as a sample project.

quasarOidcClient

Done, although I admit I have no idea what Quasar Framework is.

Basically, Quasar is a framework that uses Vue inside it.
With quasar-cli I can do a SPA, PWA, SSR, hybrid applications Android and IOS and desktop applications with Electron.
All this changing command in quasar-cli.
https://quasar-framework.org/


signals: send both the user instances and user IDs for bw compatibility

I'm not sure why the signals are transporting the user IDs only, but it's quite a shame because it requires making new database requests within the signal receiver(s).
This PR adds the full user instances in signal parameters, while keeping the IDs for backward compatibility. Note that the argument order was unchanged so old code will not break with this patch.

Coverage remained the same at 97.255% when pulling 5136a22db65b7688388fcadf116ab6a9b670e430 on Zopieux:pr-signal-instances into 92af0d00b9eeba7320eef52eee71ca199e021c3b on arteria:master.


Pin flake8 to avoid needing to import any types mentioned in type hints

Attempts to fix the build.
Another attempt is #866
Long story short, it looks like Flake8 now requires you to import anything mentioned in a type hint comment. This is extra annoying to reconcile across python versions. Hopefully they will resolve this upstream.
Changes proposed in this pull request:

Pin Flake8 to avoid nonsense in new version

:+1:

Thanks

It's still failing

I accidentally pinned it in the wrong location (should have been in the tox.ini, not setup.py).

@jmcs it's working now!

:+1:


Add Flush Message

This change adds the flush message which can be used when the bucket has been flushed. In addition, it fixes the not yet used expiration op code.

Closed since finding out that the server side doesn't use the flush code.


Wrong descriptions for our bundle artifacts

Descriptions of these packages...
https://github.com/SpineEventEngine/validation/packages/1653756
https://github.com/SpineEventEngine/validation/packages/1653726
say that they are: "Core Protocol Buffers library. Protocol Buffers are a way of encoding structured data in an
efficient yet extensible format."
They are not.
It probably is picked by GitHub from the metadata of the bundled code of ProtoBuf, but it's misleading and needs correction.

Fixed by manually editing them via GitHub UI.


fix: Add testing prefix

Adds the testing prefix, as we have in our contributors guide

@RobPasMue Can you take a look? Also, the doc build CI is failing due to secrets is undefined, do you have any idea if this is a temporary error or we should look into it?

No temporary error. My guess is that it is failing to read that ${{ secrets.* }} variable in the .yml file. Give me a sec


bump/operator-sdk

This PR upgrades operator-sdk to 1.23 which uses controller-runtime v0.12.2 and k8s.io v0.24.2 libs.
/kind feature
/priority important-sonn
/assign

/ok-to-test

/priority important-soon

/lgtm


New test failures

It appears that this has crept in the last few weeks (saw it in my travis):
Cannot assign to an immutable value
  in method process at /home/jonathan/devel/perl6/3rdparty-modules/perl6-IO-MiddleMan/lib/IO/MiddleMan.pm6 (IO::MiddleMan) line 30
  in method put at /home/jonathan/devel/perl6/3rdparty-modules/perl6-IO-MiddleMan/lib/IO/MiddleMan.pm6 (IO::MiddleMan) line 44
  in block <unit> at t/01-hijack.t line 14

This seems to afflict all the tests.

Just fixing


Survey.Data not working for ChoicesFromWeb drop down

Are you requesting a feature, reporting a bug or ask a question?
Bug?
What is the current behavior?
Survey.Data is not setting data correctly when using a drop down with choices from web as the datasource.
What is the expected behavior?
I would expect the dropdown to work exactly the same no matter what the datasource as I've tried to show in the example.
How would you reproduce the current behavior (if this is a bug)?
In the plunker below, look at the index.js file and you will see that I'm setting the two drop downs in the same way and they are using the same values, but the second drop down gets its items using ChoicesFromWeb and the first drop down gets it's items from a predefined list. The first drop downs value is set using survey.Data, but the second drop downs value is not set.
Provide the test code and the tested page URL (if applicable)
https://plnkr.co/edit/OiT3N5KFwt54FjWjONTU?p=preview

Thank you for the report. It's a bug. We'll fix it.

@michaelh15 The bug has been fixed. The fix will be available in the next minor release.
Thank you,
Andrew


All transformer implementations are in org.wildfly.transformer subpackages

I propose to move transformer implementations from org. to com. package @scottmarlow

@ropalka isn't com. packages typically for commercial software products and org.* for non-profit or open source?

like for www.redhat.com, we could use com.redhat.product

Let's discuss it @scottmarlow . My point of view is

org namespace is for API
com is for implementation

Consider Open JDK project as an example. It is open source.
It contains java & javax packages (defacto API packages)
and everything that starts with com. is considered implementation detail
and it is not recommended to import these classes.

com.redhat.transformer.asm
com.redhat.transformer.nodeps
is also fine

com.wildfly doesn't sound like a company name though, org.wildfly is more typical for our projects.

com.redhat does sound like Red Hat specific code, my preference is to be vendor neutral.

OK @scottmarlow - I changed this proposal PR accordingly

Thanks, looks good @ropalka


Self-hosted Git backup

It's more convenient for me to use services like GitHub to host code, as other people use them to collaborate.
However, as I don't want to be dependent on a centralized platform to be the only place storing my source code, I'd like to have a server mirror all of my GitHub/lab/sourcehut/whatever repositories so that I can still access everything in the case of an outage.
https://gitolite.com/gitolite/
gitea
sourcehut
all look like they could be promising

https://github.com/bjornfor/nixos-config/blob/master/options/gitolite-mirror.nix manage gitolite mirror repositories

https://github.com/bjornfor/nixos-config/blob/master/options/gitolite-mirror.nix manage gitolite mirror repositories

https://github.com/bjornfor/nixos-config/blob/master/cfg/cgit.nix cgit backup

https://github.com/bjornfor/nixos-config/blob/master/cfg/cgit.nix cgit backup

https://github.com/bjornfor/nixos-config/blob/master/cfg/git-daemon.nix

https://github.com/bjornfor/nixos-config/blob/master/cfg/git-daemon.nix

Looks like I have to back up git repositorier individually... which is unfortunate

Looks like I have to back up git repositorier individually... which is unfortunate

https://hanez.org/howto-mirror-self-hosted-git-to-github.html

https://hanez.org/howto-mirror-self-hosted-git-to-github.html


LSP2 Encoder Added Links & Description

This PR introduces updated headings, links, and description
Screenshot

Btw, no need for conventional commits on this repo


HtmlNode.GetEncapsulatedData fails when target property is a nullable value type

1. Description
HtmlNode.GetEncapsulatedData throws an exception when properties of some nullable value type should be populated.
2. Exception
Unhandled exception. System.Exception: Unhandled Exception : Invalid cast from 'System.String' to 'System.Nullable`1[[System.Int32, System.Private.CoreLib, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=7cec85d7bea7798e]]'.
   at HtmlAgilityPack.HtmlNode.GetEncapsulatedData(Type targetType, HtmlDocument htmlDocument) in C:\Repos\HtmlAgilityPack\HtmlAgilityPack.Shared\HtmlNode.Encapsulator.cs:line 224
   at HtmlAgilityPack.HtmlNode.GetEncapsulatedData[T]() in C:\Repos\HtmlAgilityPack\HtmlAgilityPack.Shared\HtmlNode.Encapsulator.cs:line 36

3. Fiddle or Project
https://dotnetfiddle.net/6JUCcn
[HasXPath]
public class Model
{
    [XPath("div", "foo")]
    public int? NullableInt {get;set;}
}

string html = @"
Hello world!
";

var doc = new HtmlDocument();
doc.LoadHtml(html);
var m = doc.DocumentNode.GetEncapsulatedData<Model>();

Console.WriteLine($"m.NullableInt = {m.NullableInt}");

4. Any further technical details
HAP 1.11.50
.NET 7
(as per dotnetfiddle demo linked above)

The problem are the calls of Convert.ChangeType. According to Github code search, only the HtmlNode.Encapsulator.cs source file features Convert.ChangeType calls: https://github.com/search?q=repo%3Azzzprojects%2Fhtml-agility-pack Convert.ChangeType&type=code
To properly support nullable value types, calls of Convert.ChangeType could be replaced with a utility function similar to this:
static object ChangeType(string value, Type targetType)
{
    var nullableUnderlyingValueType = Nullable.GetUnderlyingType(targetType);
    if (nullableUnderlyingValueType == null)
    {
        return Convert.ChangeType(value, targetType);
    }

    var valueInstance = Convert.ChangeType(value, nullableUnderlyingValueType);
    return Activator.CreateInstance(targetType, valueInstance);
}

Additionally, I'm not sure if this is a major feature. Apart from the three places where I have seen type conversions so far, are there any other areas involved? Will it potentially affect more people since the project has not enabled the Nullable project option?
Also, some of our files are encoded in Windows-1252. Every time I make changes, to avoid disrupting others' work, I save them back as Windows-1252. This seems to be a specific encoding that certain editors use for saving files, right? It that correct to keep Windows-1252 or should we switch to UTF-8 with BOM?

Will it potentially affect more people since the project has not enabled the Nullable project option?

The <nullable> setting in .csproj project files (and the equivalent #nullable pragma) is about nullable reference types only. It is not about nullable value types and therefore has no impact on nor is it an indication of whether a project can or does use nullable value types.


Add conda version check to update conda frontend in test

Addresses #166

@LeandroRitter I added a check for conda version in runtest.sh which by default will change the conda frontend to mamba if the conda version is <23.10.


foreach Variable Assignment isn't Validated by PSAvoidAssignmentToAutomaticVariable

Steps to reproduce
Invoke-ScriptAnalyzer -ScriptDefinition 'foreach ($Host in $foo) {}'

Expected behavior
The Variable 'Host' cannot be assigned since it is a readonly automatic variable that is built into PowerShell, please use a different name.

Actual behavior

Environment data
> $PSVersionTable
Name                           Value
----                           -----
PSVersion                      7.4.4
PSEdition                      Core
GitCommitId                    7.4.4
OS                             Microsoft Windows 10.0.22631
Platform                       Win32NT
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0…}
PSRemotingProtocolVersion      2.3
SerializationVersion           <IP_ADDRESS>
WSManStackVersion              3.0

> (Get-Module -ListAvailable PSScriptAnalyzer).Version | ForEach-Object { $_.ToString() }
1.22.0

I think adding an additional check in AvoidAssignmentToAutomaticVariable.cs for ForEachStatementAst is the simplest solution. I can submit a pull request with the suggested change if that's acceptable.

Thanks this is a tricky one because of scoping--- we will take a look a the PR, thanks for opening


[BUG]/app/.playwright/node/linux-x64/playwright.sh' with working directory '/app'. Permission denied

FROM mcr.microsoft.com/playwright/dotnet:v1.40.0-jammy AS base
USER $APP_UID
WORKDIR /app

FROM mcr.microsoft.com/dotnet/sdk:8.0 AS build
ARG BUILD_CONFIGURATION=Release
WORKDIR /src
COPY ["MicroServicesAutoSyncJinMin/MicroServicesAutoSyncJinMin.csproj", "MicroServicesAutoSyncJinMin/"]
RUN dotnet restore "MicroServicesAutoSyncJinMin/MicroServicesAutoSyncJinMin.csproj"
COPY . .
WORKDIR "/src/MicroServicesAutoSyncJinMin"
RUN dotnet build "MicroServicesAutoSyncJinMin.csproj" -c $BUILD_CONFIGURATION -o /app/build

FROM build AS publish
ARG BUILD_CONFIGURATION=Release
RUN dotnet publish "MicroServicesAutoSyncJinMin.csproj" -c $BUILD_CONFIGURATION -o /app/publish /p:UseAppHost=false

FROM base AS final
WORKDIR /app
COPY --from=publish /app/publish .
RUN chown -R $APP_UID /app
ENTRYPOINT ["dotnet", "MicroServicesAutoSyncJinMin.dll"]

Sounds like your user has no permissions of running your RUN chown -R $APP_UID /app line.
You could do USER $APP_UID after that instead of in line 2 and then it should work.

Sounds like your user has no permissions of running your RUN chown -R $APP_UID /app line.
You could do USER $APP_UID after that instead of in line 2 and then it should work.

It seems that there is no such command, is this related to my use of Windows system?
I can't run without using Docker, the Linux environment is too difficult.

Folding into https://github.com/microsoft/playwright-dotnet/issues/2814.


Any advice on the best way to test one's setup?

I am really liking this gem however I have a question about testing.  Here is my setup:
I have a number of different things that can trigger updates to the index and thus handle it manually.  I need to test that I am doing it properly however as far as a I can tell this isn't easily done given the async nature of the setup.
E.g. If object A is created, update index for object B.  This doesn't seem to work because I need to put it in my after_commit hook in the object (or elasticsearch won't see it) and the way that tests are setup (at least using shoulda and TestUnit) the transactions never complete until the test is over.
Any thoughts on a better way to do this?
Thanks.

Hey, I'm not sure I understand entirely the described issue, but here are my thoughts:
1/ In unit tests, I recommend stubbing Tire methods, or stubbing HTTP responses with Webmock/Fakeweb.
2/ In integration tests, I recommend letting everything bubble thru the stack.
If I understand correctly, you need to update the ES index (Tire method update_index) in the after_commit hook, not in the after_save hook, which is the default. So, calling self.tire.update_index in the after_commit block should be enough?
Lemme know if this advice is in the right direction, and please paste some simplified code so we can have a better understanding of what's going on...

The reason that I want to call the update_index in the after_commit vs. after_save hook is that because rspec and testunit wrap a whole test in a transaction calling update index will not help because the transaction never completes and thus ES doesn't see the update objects in the database when I would want to make assertions.  This is true for unit tests at least.
The reason I am testing this is because I have one indexed model, call it Document.  It has e.g. an array of authors.  Adding an author should trigger an update on the index for Document.  This needs to be triggered in the after_create/after_commit for author.
I will try just stubbing everything in my unit tests and seeing if I can make it work by just writing integration tests.
Thanks.

Hi, this is related to the mechanics of how transactions work in uni tests, then? Is this related to the config.use_transactional_fixtures = true setting?

@joshcutler: Ping, any news?


Bluetooth: Move common code to common/

Since more and more code is going to be reused by both the Host and the
Controller, this commit introduces a common/ folder that will contain
everything that is not tied to one of the two components but shared by
them.
Signed-off-by: Carles Cufi<EMAIL_ADDRESS>

@jhedberg apparently rfcomm.h uses BT_STACK which requires log.h, so this doesn't build right now. I wonder if a public header file like rfcomm.h should include a private one?

Regarding rfcomm.h and BT_STACK, I think that's something that needs to be fixed by RFCOMM switching to a single internal thread that uses k_poll to multiplex things. That way the thread details which require BT_STACK wont be in the public header file any more. This is something however that should not be blocking the progress of your patches, so I'd suggest to make a temporary hack for now and just include the internal header from the public one.

@jhedberg which public one? there is no more public one, I completely removed it since it did not contain public APIs. Is there another way I can work around this?


Bug:Inhibitor Obelisk is not working

What happens:
Inhibitor Obelisk is not working
What you expected to happen:
Steps to reproduce:
Inhibitor Obelisk function will not work at the following times:
When returning to Overworld from another dimension
When you enter the world
When the player is dead and respawn

MODPACK:Modern skyblock3 Departed Ver.3.6.0
Minecraft Version:1.12.2
forge-<IP_ADDRESS>08
EnderCore-1.12.2-0.5.57
EnderIO-1.12.2-5.0.44
(Normal world, not MODPACK WORLD)
Minecraft Version:1.12.2
forge-<IP_ADDRESS>15
EnderCore-1.12.2-0.5.57
EnderIO-1.12.2-5.0.44

SpongeForge? yes/no
Optifine: NO
Single Player: Single

inhibitor obelisk stops enderman and other monster from teleporting and works fine for me

i think leaving the

What you expected to happen:

part empty is the biggest issue here :)

not enough information about issue your have inhibitor

Inhibitor prevents teleporting, it does not prevent logging in or respawning---nor does it promote it would.
For dimension travelling: There is no way to hook into that to prevent it aside from blocking travelling to a dimension completely. We'd be happy to add this, but you need to first get Forge to add a suitable hook/event.

Inhibitor Obelisk function will not work at the following times:
When returning to Overworld from another dimension
When you enter the world
When the player is dead and respawn
so these thing do not do any of this there use prevent teleportation like travel anchors enderman travel staff and sword ender fluid and so much more that involves teleporting

To HenryLoenwind
I am not good at English and can not explain this phenomenon well.
I translated using a translation site, but it does not seem to be transmitted well.
I am sorry that I can not communicate well.


feat(server): SSO + RBAC. Closes #3525

Checklist:

[x] Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
[x] The title of the PR is (a) conventional, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
[x] I've signed the CLA.
[ ] I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
[ ] My builds are green. Try syncing with master if they are not.
[x] My organization is added to USERS.md.

Closes #3525

On a side note, this will require argo-server to have extra permissions: list and get on the involved service accounts and get on their secrets. Users will have to create extra roles and bindings for argo-server with those permissions - or they have to be added to the Helm chart.

On a side note, this will require argo-server to have extra permissions: list and get on the involved service accounts and get on their secrets.

Yes. I'm not sure why our tests are not highlighting this issue mind you.

@alexec have you decided to pursue some other course for implementing the RBAC?

No, this is the likely implementation, but we may changes how SSO works underneath.

Replaced by #4198


Problems using seperate postgres reader/writer hosts with pgstac

Ported from stac-utils/stac-fastapi#370.
Original Issue:
I'm running into problems when using pgstac with separate reader and writer hosts (in my case an Aurora cluster). Search endpoints return an error similar to the following:
 cannot execute SELECT FOR UPDATE in a read-only transaction

The issue appears to be that the SQL functions defined by pgstac for searching perform operations that require write access (select for update, create temp table, etc). But, the search endpoints connect to the DB through the readpool
https://github.com/stac-utils/stac-fastapi/blob/5dc8e0eb63d9cc07663968ed5ed9505e753bf298/stac_fastapi/pgstac/stac_fastapi/pgstac/core.py#L119-L120
This is not a problem when a single host is used for both read and write, as in the docker compose yaml. https://github.com/stac-utils/stac-fastapi/blob/5dc8e0eb63d9cc07663968ed5ed9505e753bf298/docker-compose.yml#L47-L48
When POSTGRES_HOST_READER points to a host that is truly read-only, however, this becomes a problem.

confirmed here that search is not a read-only operation:
https://github.com/stac-utils/pgstac/issues/191#issuecomment-1613537719
The problem may be here: https://github.com/stac-utils/stac-fastapi-pgstac/blob/main/stac_fastapi/pgstac/core.py#L163
Because search is a write operation, it should be using ...get_connection(request, "w")

Now that https://github.com/stac-utils/pgstac/pull/215 is merged.  Does that fix this issue?  Is there anything that needs to be done to make use of it?

From what I can see this is still an issue. Any clue?

As far as I understand, stac-fastapi-pgstac still knows nothing about the readonly mode, right?

I was able to get it to work in RDS.  You have to use one of the pre-release 3.0 versions of stac-fastapi-pgstac, then update the pgstac setting readonly to true.

I was able to get it to work in RDS. You have to use one of the pre-release 3.0 versions of stac-fastapi-pgstac, then update the pgstac setting readonly to true.

What version of pgSTAC did you have to use? I don't quite understand what the right combination for it.
Thanks in advance!

Looks like 3.0 of stac-fastapi-pgstac was just released.  It will use pgstac 0.8.x.  I'm using the docker images posted at https://github.com/stac-utils/stac-fastapi-pgstac/pkgs/container/stac-fastapi-pgstac and setting environment variables for the reader/writer endpoints from RDS.


Not an issue don't flag it! Missed something in the great doc

Hi as mentioned in the title is not an issue, have an php app in which i put some job via https://github.com/pda/pheanstalk/
$pheanstalk
            ->useTube('testtube')
            ->put(json_encode(array('hello' => 'mdjaman')));

then i want fivebeans worker to process the job; unfornatedly i missed something in documentation.
Can someone point me to right track

@mdjaman You didn't really explain what your problem is.
Would you not use something like the following?
client.watch('testtube', watchErr => {
  if (watchErr) console.log(watchErr)
  client.reserve((err, jobId, rawPayload) => {
    var payload = JSON.parse(rawPayload.toString())
    // Process `payload` here
  })
})

@mdjaman
Encountered same issue with putting jobs from PHP. It turned out, that fivebeans uses it's format of payload.
To make it work, i actually had to format it on PHP side:
$beanstalk->putInTube('testtube', [
    'testtube', // Tube name has to be in the payload as well
    [
        'type' => 'handler-type', // Handler key defined in JS's options object
        'payload' => $payload // Here goes actual data that worker will receive
    ]
], $priority, $delay);

And my JS code is
var Beanworker = require('fivebeans').worker;
var options =
{
    id: 'my_worker',
    host: '<IP_ADDRESS>',
    port: 11300,
    handlers:
    {
        'handler-type': notifier // 'type' in PHP code
    },
    ignoreDefault: true
}
var worker = new Beanworker(options);

worker.start(['testtube']);

I know this issue is old, but hope that helps anyone.
Maybe we really should cover it in Docs though? @ceejbot


Check product use categories configuration

Just a suggestion ... you should check if this is set to true:
groups[seo][fields][product_use_categories][value]
And if this is not set to true you can just skip this part.
Console/Command/RegenerateUrlRewritesCategoryAbstract.php
$productUrlRewriteResult = $this->_getUrlRewriteHandler()->generateProductUrlRewrites($category);

// fix for double slashes issue
foreach ($productUrlRewriteResult as &$urlRewrite) {
  $urlRewrite->setRequestPath($this->_clearRequestPath($urlRewrite->getRequestPath()));
}

$this->_doBunchReplaceUrlRewrites($productUrlRewriteResult, 'Product');

What do you think?

@bjoern-flagbit @scolandrea
Hi.
Maybe create a option for this and if command was executed with this option then script will take into account this config value and skip/not skip this part of logic?
Because for main part of store owners this will not be clear. But who knows can use the option.

@olegkoval Hi!
Yeah, definitely this functionality should be optional because by default Magento uses _ product_use_categories_ only when it was set as true.
It might be an optional argument for the regenerate command.
What do you think?

I would go with @bjoern-flagbit suggestion,  as the URL generated of new product later on would be the same as those regenerated. It force store owner to be consistent with their store config. BUT, it should be documented.

Hello @bjoern-flagbit , @scolandrea .
Please, upgrade to v1.4.2. I've added this option and name of option is "--check-use-category-in-product-url".
Best regards,
Oleg Koval


EM06 not working with integration any more

Hi,
my EM06 stopped working with HomeAssist. I have already tried an update to the actual version and a reset of the device. Firmware is uptodate and I see the device and values in the Refoss-App, but the Refoss integration did not find the device. I would like to avoid to delete the old sensors to keep the history data.
Reload of the integration and HA reboot did not change anything. HA ist uptodate too.

https://www.home-assistant.io/integrations/refoss/
Please check the firmware version,
Is the WiFi within the same local area network.

Hi @ashionky
EM06 had been working, but was stalled, so I needed to do a reset. After I was not able to integrate it in HA again, I have uninstalled this REFOSS integration and tried the HA Official integration and after that also did not work, I have reinstalled this over HACS. Firmware is 2.3.8.

Is the device and HA on the same network?
Operation:
On HA, delete both Refoss and Refoss Lan first and integrate them again with Refoss. Try again.

Uploading VID_20241022_160606.mp4…

https://github.com/user-attachments/assets/203851aa-b11f-477b-a7f6-0e32c81e2c02

The above described Issue still persists for me as well

I have tried the solution and get "No Devices found in network" (free translated from German).
EM06 and Home Assist are both in the IOT network, Home Assist has a second interface into the normal network. MQTT and other MultiCast integration works without issue in the IOT network. The EM06 is still working with the refoss app on android.


Add exports field to package.json

This solves https://github.com/rollup/plugins/issues/1130
Bundling json-bigint with rollup fails without this change.

Just wanted to say that the ordering of the exports and the inclusion of a default can make a difference to WebPack and esbuild, as I recently discovered with my own small modules.

Looks good. I'll consider it.
See #300 for previous on exports.

LGTM
Fixed type error for TypeScript nodenext module type

Okay, thank you.

@MikeMcl  Is there any plan to public a new release containing this fix? I'm waiting for this to fix a critical webpack issue.

@coldcode001 Release imminent...

@coldcode001
Published v9.1.0.
Thanks for the nudge.


[Feature request] Add search for shape selector

When I have a lot of vox's, the scroll can get really large and sensitive and its hard to find shapes.

Available in v0.5.0-beta8.


Unmount corrupted folder is case nodeserver restarted

What changes are proposed in this pull request?
Unmount corrupted folder is case csi-nodeserver restarted
Related to issue #14917
This change just mitigate the issue. If node-server restated, it will try to remount the folder. But user job still can not access data during restarting period.
Just notice these is another solution for this issue https://github.com/Alluxio/alluxio/pull/15165. Believe this solution is more robustness and better for critical job. But this solution need more efforts to be mutual for production workload. Maybe at this stage, we can keep the both.
Notice: this change requires k8s version above 1.18
This change not tested yet, we need to kill the nodeserver. After it restarted, check if the mount path is remounted

Thanks @Binyang2014 !

alluxio-bot, merge this please


invalid syntax on 4th line

Issue Type: Bug
hello_world_text = 'Hello World Variable'
print ('Hello World!!!')
print('hello_world_text')
print('hello_world_text')!!!!! duh run the test Mr_robot
print ('hello_world_text')
It shouldn't be invalid but it is.

Please add screen shots of your issue.

I will try that first. Thank you!
Malik Washington M.Ed Candidate Georgia State University. Social Studies Department Chair Dekalb County Public Schools

On Oct 8, 2019, at 3:44 AM, Alex Ross<EMAIL_ADDRESS>wrote:

Does it reproduce if you disable all extensions?
Please add screen shots of your issue.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.


Could you please add me to your organization/community

Just starting getting my grips with interacting with GitHub and I think your organisation is a good place to start
Thanks!

Invitation sent for the GitHub Organisation. Welcome to the community 🎉
Don't forget after accepting to make it public so it appears on your github profile for everyone else to see, you can do this by finding your name in the github organisation list and change the dropdown to public https://github.com/orgs/EddieJaoudeCommunity/people
Tips for practicing:
Customise your GitHub profile, here is a live stream on it https://www.youtube.com/watch?v=cT6GXCuS0Zo
Practice repo, instructions how to add your name to the README in the README https://github.com/EddieJaoudeCommunity/hacktoberfest-practice
Remember contributing to open source is not just about code, its about collaboration, communication and adding value
I hope that helps


Add support for token revocation

This PR adds support for token revocation. It's implemented similarly to how token introspection is implemented. Let me know what you think. Happy to write tests too just let me know how you'd like them structured and where. I didn't see an obvious place for the tests to live.
Usage:
const client = new OAuth2Client({
  // ...

  // Can also be auto-discovered if discoveryEndpoint is supplied
  revocationEndpoint: '/revoke'
});

const token = await client.clientCredentials();

await client.revoke(token);

// can also supply tokenTypeHint (default is 'access_token')
await client.revoke(token, 'access_token');

// To revoke a refresh token
await client.revoke(token, 'refresh_token');

Fixes #125

There are currently unittests in the test/ directory. Running 'npm test' should execute them. If you're not comfortable adding these I'll find some time writing them

More specifically, I was looking for tests that invoke client.introspect so I could copy them, but I couldn't find any. Am I missing something?

There are currently unittests in the test/ directory. Running 'npm test' should execute them. If you're not comfortable adding these I'll find some time writing them

More specifically, I was looking for tests that invoke client.introspect so I could copy them, but I couldn't find any. Am I missing something?

No, this library doesn't have a 100% coverage , but I've been trying to add them with every change or new feature

There are currently unittests in the test/ directory. Running 'npm test' should execute them. If you're not comfortable adding these I'll find some time writing them

More specifically, I was looking for tests that invoke client.introspect so I could copy them, but I couldn't find any. Am I missing something?

No, this library doesn't have a 100% coverage , but I've been trying to add them with every change or new feature

I'll see what I can do

Ok, have a look, let me know what you think

Geez my last 2 comments were in 'draft' for a month and a half , sorry . Forgot to hit the green button


Update cats-core to 2.0.0

Updates org.typelevel:cats-core from 1.6.1 to 2.0.0.
Release Notes/Changelog
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "org.typelevel", artifactId = "cats-core" } ]

labels: semver-major

Codecov Report

Merging #362 into master will decrease coverage by 0.08%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #362      +/-   ##
==========================================
- Coverage   80.86%   80.77%   -0.09%
==========================================
  Files         128      128
  Lines        3340     3340
  Branches       91       91
==========================================
- Hits         2701     2698       -3
- Misses        639      642       +3

Impacted Files
Coverage Δ

...e/akka/actor/process_index/ProcessIndexProto.scala
97.95% <0%> (-1.54%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 872a725...98d0d34. Read the comment docs.


bisq-desktop: 1.9.4 -> 1.9.5

Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.
meta.description for bisq-desktop is: "A decentralized bitcoin exchange network"
meta.homepage for bisq-desktop is: "https://bisq.network"
meta.changelog for bisq-desktop is: ""
Updates performed

Ran passthru.UpdateScript

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact

Checks done (click to expand)

built on NixOS
The tests defined in passthru.tests, if any, passed
found 1.9.5 with grep in /nix/store/2ay7xvkci6pv5nh3p50g0k390f3bkycb-bisq-desktop-1.9.5
found 1.9.5 in filename of file in /nix/store/2ay7xvkci6pv5nh3p50g0k390f3bkycb-bisq-desktop-1.9.5

Rebuild report (if merged into master) (click to expand)

1 total rebuild path(s)

1 package rebuild(s)

First fifty rebuilds by attrpath
bisq-desktop

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/2ay7xvkci6pv5nh3p50g0k390f3bkycb-bisq-desktop-1.9.5 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A bisq-desktop https://github.com/r-ryantm/nixpkgs/archive/943296d93de1faf211ff5f0e5a9a7a6447cb0cf5.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/2ay7xvkci6pv5nh3p50g0k390f3bkycb-bisq-desktop-1.9.5
ls -la /nix/store/2ay7xvkci6pv5nh3p50g0k390f3bkycb-bisq-desktop-1.9.5/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

1 package built:

bisq-desktop

Maintainer pings
cc @uningan @emmanuelrosa for testing.

Also worked for me.


As a user, I want to see a list of essays with previews so that I can view recently published analysis.

dev notes
this is the analysis landing page, including whatever things are different about it from the sources landing page.

Duplicate of #254


Use readable-stream for frontend compatibility

This fixes https://github.com/crypto-browserify/cipher-base/issues/11, by using the browser-compatible readable-stream module.

hey @Treyone!
If you don't mind me asking, why did you close this MR? I am running into the same error with this module and was wondering if you solved it another way (maybe through your webpack config?)
Thanks!

Hi ! I though this was useless (there are dusty PRs in this repo :) ) and indeed I solved that in webpack configuration:
  resolve: {
    alias: {
       ...
    },
    fallback: {
      ...
      stream: require.resolve('readable-stream')
    },

To give you the full story;  I tried it first and it didn't work. I tried again in alias and it worked, so I went in the docs to learn the exact difference and that made me realised I had an abandoned stream npm that was wrongfully imported in my project. I removed it and the fallback does the job.

@Treyone thanks so much for the quick reply, you are absolutely right abou the alias working. I will take a look to see if I also had the wrong stream npm module in my project as well, thanks!


Week 3, 01 Colour Processing

Font type 'FreeSerifBold.ttf cannot be found from the system, use DejaVuSerif.ttf instead
Replace mask = ig.subset(channel=0).allocate(True,dtype=np.bool) by mask = ig.subset(channel=0).allocate()

updating these now

I created also #69 , but will close it approve #77


Download images from sample project directly (without being zipped)

Being able to just download all the images to one folder instead of having to download the zip and then unzip it would be a nice QoL improvement

Multi file download is not supported by html5.  You can always use git to download from github.