Import "nanopb.proto" has not been loaded.

I got this runtime error:
~/work/build/mypkg(proto*) » python ./test1.py
Traceback (most recent call last):
  File "../test1.py", line 12, in <module>
    import mypkg.my_api as my_api
  File "/home/raczb/work/build/mypkg/my_api .py", line 22, in <module>
    import mypkg.proto.my_proto_pb2 as my_proto_pb2
  File "/home/raczb/work/mypkg/proto/my_proto_pb2.py", line 25, in <module>
    dependencies=[nanopb__pb2.DESCRIPTOR,])
  File "/home/raczb/work/.env/lib/python3.6/site-packages/google/protobuf/descriptor.py", line 829, in __new__
    return _message.default_pool.AddSerializedFile(serialized_pb)
TypeError: Couldn't build proto file into descriptor pool!
Invalid proto descriptor for file "proto/my_proto.proto":
  proto/ymir.proto: Import "nanopb.proto" has not been loaded.

after build:
protoc -I.:ext/nanopb/generator/proto/ --python_out=mypkg proto/my_proto.proto
protoc -I.:ext/nanopb/generator/proto/ --python_out=mypkg proto/nanopb.proto

It works only with protobuf==3.1 any other protobuf throws this exception

Seems like some kind of problem with Python protobuf libraries. One can put the nanopb options in separate .options file, if including nanopb.proto causes problems.


Tags TypeScript / Redux update

Thanks for submitting a PR! Please check the boxes below:

[x] I have run pre-commit to check linting
[x] I have filled in the "Changes" section below?
[x] I have filled in the "How did you test this code" section below?

Changes
Refactor:

CRUD for tags
Tag filtering (user page, features page and Datadog widget page)
Colour select
Feature settings (create/edit flag)
Added types

New:

Adds tag info to user feature rows

Manually tested all of the above pages

@kyle-ssg I have a feeling that, despite this PR saying there are no conflicts, there actually are. I'd imagine this could be what is causing the E2E tests to fail too? I tried to do the merge but it wasn't trivial so I'm leaving it to you.

Closing for #1930


Update installation

changes in docs:

changes in install.md: https://github.com/intel/scikit-learn-intelex/blob/doc-installation/INSTALL.md


chore(clerk-js): Introduce Form.PasswordInput, InputGroup, Checkbox

Description
This PR handles the internal refactor of internal form components.

Drop Form.Control type checkbox, introduce Form.Checkbox
Drop Form.Control with groupSuffix and groupPrefix, introduce Form.InputGroup
Drop Form.Control type password, introduce Form.PasswordInput
Replaces the usage of the old pattern with the new components

Changes are applied to both ui and ui.retheme dirs

Checklist

[ ] npm test runs as expected.
[ ] npm run build runs as expected.
[ ] (If applicable) JSDoc comments have been added or updated for any package exports
[ ] (If applicable) Documentation has been updated

Type of change

[ ] 🐛 Bug fix
[ ] 🌟 New feature
[ ] 🔨 Breaking change
[ ] 📖 Refactoring / dependency upgrade / documentation
[ ] other:

Packages affected

[ ] @clerk/backend
[ ] @clerk/chrome-extension
[ ] @clerk/clerk-js
[ ] @clerk/clerk-expo
[ ] @clerk/fastify
[ ] gatsby-plugin-clerk
[ ] @clerk/localizations
[ ] @clerk/nextjs
[ ] @clerk/clerk-react
[ ] @clerk/remix
[ ] @clerk/clerk-sdk-node
[ ] @clerk/shared
[ ] @clerk/themes
[ ] @clerk/types
[ ] build/tooling/chore

@panteliselef You will need to apply these changes to the ui-retheme directory. I will share more info within the day

@nikosdouvlis Do u mind unblocking this ? The changes u requested have been pushed.


fix Link binlog files according to consistent rowsets #41319

cherry pick from #41319

run buildall

run buildall


Add SFNO tests and Makani optional dependency.

Modulus Pull Request
Description

Added optional Makani dependency required for SFNO models.
Added basic tests to verify that Makani SFNO can be used in Modulus.
Minor reformat of Dockerfile: removed trailing spaces, replaced tabs with spaces.

Checklist

[x] I am familiar with the Contributing Guidelines.
[x] New or existing tests cover these changes.
[x] The documentation is up to date with these changes.
[x] The CHANGELOG.md is up to date with these changes.
[ ] An issue is linked to this pull request.

Dependencies

/blossom-ci

/blossom-ci

/blossom-ci

/blossom-ci


feat:Hotkeys for tab selection

This PR adds hotkeys for the tabs (ctrl+{first letter of tabname except for Check-in as ctrl+c kills the terminal - there it is ctrl+i}.
I have not found how only to trigger confirm if it is on screen, I will have to read a bit more about Textualize to get that going.
Closes #22

The best way to deal with the confirm/cancel hotkeys might be to have the dialog screen all inherit from the same class, then set the bindings in that class.


make utils an internal package

This intentionally breaks the build for everyone who is using the old logging API. This makes sense because we force people to stop using a deprecated API.

Codecov Report

Merging #648 into master will decrease coverage by 0.32%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #648      +/-   ##
==========================================
- Coverage   91.25%   90.93%   -0.32%
==========================================
  Files          80       73       -7
  Lines        5555     5338     -217
==========================================
- Hits         5069     4854     -215
+ Misses        305      304       -1
+ Partials      181      180       -1

Impacted Files
Coverage Δ

flowcontrol/flow_controller.go
97.67% <ø> (ø)
:arrow_up:

crypto/cert_compression.go
86.16% <ø> (ø)
:arrow_up:

crypto/key_derivation.go
80.77% <ø> (ø)
:arrow_up:

frames/stop_waiting_frame.go
100% <ø> (ø)
:arrow_up:

stream.go
97.7% <ø> (ø)
:arrow_up:

h2quic/client.go
86.9% <ø> (ø)
:arrow_up:

handshake/connection_parameters_manager.go
98.44% <ø> (ø)
:arrow_up:

h2quic/server.go
62.87% <ø> (ø)
:arrow_up:

qerr/quic_error.go
100% <ø> (ø)
:arrow_up:

client.go
88.89% <ø> (ø)
:arrow_up:

... and 29 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6be03b5...9950c00. Read the comment docs.

Apparently, @codecov-io doesn't include the internal package.


Messages should not be limited to 255 chars

This is because the underlying column has type character varying(255).

Yes, we should switch this to TEXT

Hey guys, is the column in question named 'sentence' in the 'messages' table?

Yup! We'd need a new pair of up/down migrations to modify that column.
To get the timestamp like the other migrations have, try $ date +%s

Are you creating the migrations by hand or is there some package/library helping you with it? Another follow up question: as a general rule/guideline what command/s do I run to check if I haven't broken anything(tests!)? I can't find that in the contributing guide or elsewhere. Thanks in advance. 😄

I tried go test but I get
2016/04/21 22:14:48 failed to start server could not connect to database: dial tcp <IP_ADDRESS>:5432: getsockopt: connection refused

Probably something wrong with my Db..

Yes, that's an error in trying to connect to your DB. Did you run cmd/setup.sh? Did it skip DB setup or run through everything there? Do you have Postgres running?
There's no tool to make migrations. Just create the files and write the SQL--should be one line.

Is this output normal?
➜  abot git:(master) go test ./...
ok  	github.com/itsabot/abot	7.197s
ok  	github.com/itsabot/abot/core	0.177s
?   	github.com/itsabot/abot/core/log	[no test files]
?   	github.com/itsabot/abot/core/template	[no test files]
?   	github.com/itsabot/abot/core/websocket	[no test files]
?   	github.com/itsabot/abot/data/ner	[no test files]
?   	github.com/itsabot/abot/shared/datatypes	[no test files]
?   	github.com/itsabot/abot/shared/helpers/address	[no test files]
?   	github.com/itsabot/abot/shared/helpers/timeparse	[no test files]
?   	github.com/itsabot/abot/shared/interface/cal	[no test files]
?   	github.com/itsabot/abot/shared/interface/cal/driver	[no test files]
?   	github.com/itsabot/abot/shared/interface/email	[no test files]
?   	github.com/itsabot/abot/shared/interface/email/driver	[no test files]
?   	github.com/itsabot/abot/shared/interface/emailsender	[no test files]
?   	github.com/itsabot/abot/shared/interface/emailsender/driver	[no test files]
?   	github.com/itsabot/abot/shared/interface/payment	[no test files]
?   	github.com/itsabot/abot/shared/interface/payment/driver	[no test files]
?   	github.com/itsabot/abot/shared/interface/sms	[no test files]
?   	github.com/itsabot/abot/shared/interface/sms/driver	[no test files]
?   	github.com/itsabot/abot/shared/knowledge	[no test files]
ok  	github.com/itsabot/abot/shared/language	0.047s
?   	github.com/itsabot/abot/shared/nlp	[no test files]
?   	github.com/itsabot/abot/shared/plugin	[no test files]
?   	github.com/itsabot/abot/shared/task	[no test files]

Sorry I deleted my earlier post before you replied.. my db wasn't running. 😛

Yup, that means it all passed! When you create a pull request TravisCI will automatically run all the tests as well.

Thanks, I'll get to work and send in some code soon hopefully!


@xstate/test test plan strategy

Bug or feature request?
Maybe a feature.
Description:
I've just started to try the @xstate/test package and wondering whether to generated test plans cover all things(or is that the intended strategy)?
For example, a simple machine:
const machine = Machine({
  initial: "close",
  states: {
    close: {
      on: {
        FOCUS: "open"
      }
    },
    open: {
      on: {
        ENTER: "close",
        BLUR: "close"
      }
    }
  }
});

And then get test plans by setting the initial state to 'close' and 'open'.
(Bug) Expected result:
I would expect the test plans contain the following test plans which cover all the paths and states, no matter the initial state is 'open' or 'close'.
close -> open via FOCUS
open -> close via ENTER
open -> close via BLUR

(Bug) Actual result:
Actually, with an initial state 'close' I got:
-> close, via
close -> open, via FOCUS

and with an initial state 'open' I got:
-> open, via
open -> close, via ENTER
open -> close, via BLUR

(Bug) Potential fix:
Before digging into the source code, I would like to know whether these are the intended result. If so, shall we implement some other test plan strategy to generate the paths I expect?
(Feature) Potential implementation:
Same here.

These are the intended results currently, as the tests focus on state coverage. I'll add a feature that focuses on transition coverage (not sure what this will look like yet).
Here is a workaround:
const machine = Machine({
  initial: "close",
  context: { wasClosed: false },
  states: {
    close: {
      on: {
        FOCUS: "open"
      },
      exit: assign({ wasClosed: true })
    },
    open: {
      on: {
        ENTER: "close",
        BLUR: "close"
      }
    }
  }
});

Thanks for the feedback.
In my experience with states chart, transition coverage need more configurable strategy to avoid explosion.
Anyway, the test package is really useful and I started to using it in some complex UI component.

Hey, I'm new for the library, is there a solution (not a workaround above) for this issue?

Hey, I'm new for the library, is there a solution (not a workaround above) for this issue?

Yes, or at least soon - in the latest @xstate/test@alpha, state traversal is based on the state and previous event, by default, so the main issue is mitigated.


Wrong argument parsing in convert-image.cc

Hi
I was having problems rescaling images using mirtk-convert-image. On close inspection I found out that, for some reason the option parsing looks like this
if (OPTION("-char") == 0) do something
changing them to
if (OPTION("-char")) do something
solved all my problems

Forget it. Seems I had an outdated version of the Software, closing now...


Publish on Zenodo

following README.txt completion and notebook clean up, create release and publish on zenodo.

addressed in #65


Refactoring to follow guide

This is a refactoring to make the app reflect the DoneJS guide

Note: Once this is merged the database of the production app needs to be deleted.


Add onapiready handler

When joining a room there will be a brief period before the Subscriber
API data channel is established.  Methods that use the API during that
time will fail silently.  This can be a source of race conditions for
code that needs to set the initial state of streams immediately after
joining.
This change adds an onapiready handler that will be called once the
data channel is established, which provides a way to avoid such race
conditions.

+1 for resolving a join promise on connect

Ah, yeah that's a much better idea :+1:  I'll try that instead.

@kevinmcconnell awesome!


[Bug]Why FULLSrceen Mod with 2 pause Button

@PierfrancescoSoffritti
FULLSrceen Mod with 2 pause Button
Please Help!

https://goo.gl/photos/6Whn7FP9moKgh7Gc9

build your sample,android 6.0

Hi, remove this line from MainActivity.java
youTubePlayerView.setCustomActionRight();

thanks for your help


Request for Comments: Remove browser UI from React-Native

To continue the discussion from this PR: https://github.com/storybooks/storybook/pull/3278
I'd like to get some opinions on these removing the browser side of the UI
Pros:

Reduce steps to run RN from 2 terminal processes (RN packager & Storybook) to 1 (RN packager)
Get rid of the confusion of nothing displaying in the web Storybook preview
Create possibility of distributing SB RN app (through Expo, Test Flight, etc) #3224, #3235
Simplify SB RN development process by removing dependency on @sb/react
Enables more thorough testing (storyshot only works for the SB UI, not the actual stories)
Run more than one instance of RN storybook at a time

Cons:

Breaks compatibility with all current addons

With haul, currently, you'd only need to run 1 terminal process I guess?
The only part of the web UI that's not used at all is the Preview. Hiding it should be a storybook wide option configurable via storybook options addon.
This is currently possible.
Not familiar enough with storybook to comment.
Not familiar enough with storybook to comment.
Not familiar enough with storybook to comment.

I don't agree with removing browser side ui. I like having option to integrate storybook with ide addons (like in vscode or webstorm). They are expecting rn to use websockets. Also when developing I like to have multiple devices running at same time on same storybook (android, ios, multiple ios devices and so on).
I feel like we should improve onDeviceUI to support addons, so there would be feature parity between what you can achieve with browser, but we shouldn't remove browser completely.

We currently only have 2 RN compatible addons that require the side panel in the browser - actions and knobs. I'm not aware of any third party RN addons.
We can easily build a logger for actions in the onDeviceUI although knobs would be a bit harder. I'm curious to see how users use knobs in conjunction with Storybook RN.
I don't think cross platform addons are achievable quite yet. I have yet to see a truly cross platform (react & react-native) set of UI components that doesn't require significant configuration and maintenance.
I'm pretty neutral about this support for browser UI. I think this PR will solve most of the pain points I have in using Storybook RN as a developer https://github.com/storybooks/storybook/pull/3278.
I brought this up because it's probably the buggiest stable framework we support. RN is least tested piece of code we have in this repo and we don't have any tests for web UI + RN UI working together in conjunction. The only thing we test for is if the CLI works and is able to start, and if snapshots can be taken in a vanilla app.

Well to make addons work we could additionally add renders for RN part. But that would mean that now we have to update two renders instead of one.
One ugly solution that could theoretically allow us to still use same addons (react) would be to integrate browser in phone to render addons? Just an idea.


[BUG] No auto-generated stub files for mlx.core for 0.8.0

Describe the bug
When I install mlx from pip, the latest version 0.8.0 does not have auto-generated stub files for mlx.core, thus there is no type hint in VSCode. When I install version 0.7.0, there are stub files. It's probably a bug introduced when mlx switched to nanobind.
A quick GitHub search shows that there is indeed a command that generates stub files, but perhaps there is a bug in the config somewhere that the stub files are not included in the pip package.
https://github.com/ml-explore/mlx/blob/be98f4ab6be2e466e2ebf59622e5f4866b6527e2/setup.py#L136-L139
https://github.com/ml-explore/mlx/blob/be98f4ab6be2e466e2ebf59622e5f4866b6527e2/.circleci/config.yml#L43-L47
To Reproduce
NA
Expected behavior
There are stub files.
Desktop (please complete the following information):

OS Version: 14.2
Version 0.8.0

Additional context
NA

Thanks for flagging, I will check!

Should be fixed in 0.8.1 if you pip install -U mlx you will get that.


SVCORE-2140 - Upgrade library to Net Standard 2.0 and introduce Dependency Injection for logging

Description
Tickets: SVCORE-2140]
Summary: Introduces dependency injection and makes use of if for logging purposes.
Background
As part of the effort to migrate the library to the Net Standard 2.0, we need to get rid of the Netco library that we depend on and cannot be upgraded. This presents a challenge, since we use the Netco library for logging and resilience policies, both in a static way.
About these changes
This PR is intended for demonstration purposes and does not completely remove Netco.
In this PR we introduce dependency injection in the library, as a way to take advantage of the built in logging framework in recent Net versions and its ILogger interface. Since Netco was used for logging, these changes replace its use for that purpose with the built in framework.
The changes in this PR go a bit further and refactor SoapWebRequestServices introducing an interface for it and making it compatible with DI. This is also just for demonstration purposes, as it wasn't requested originally for this ticket. The class was renamed for clarity purposes, since classes for Rest API and SOAP API have the same names.
We also replaced the resilience policies from Netco with Polly policies as an extra step to demonstrate how to do it, and because those dependencies would prevent us from getting rid of Netco.
Test were updated where necessary to account for the changes in the classes under test.
Files of notice
The following are the files where the most impactful changes here made:

ThreeDCartFactory - We inject dependencies using the DI engine here
PolicyRegistry - Replaces ActionPolicies and uses Polly instead of the Netco provided retry policies; logging support added via PolicyContext; can be improved further (new Canary can be used for reference)
ServiceCollectionExtensions - This is where we setup DI for the library

What we didn't do
We DO NOT get rid of Netco all the way. We didn't convert the class all the way to Net Standard and though everything builds, tests are failing. There is still work to do, but it is expected that the team handling the library updated will take care of that.
PR Readiness Checklist

[ ] I have updated all relevant configuration
[x] Followed development conventions to the best of my ability
[x] Code is documented, particularly public interfaces and hard-to-understand areas
[-] Tests are updated / added and all pass
[x] Performed a self-review of my own code
[x] Acceptance criterias are confirmed by testing changes in UI (or another appropriate way)
[ ] Confluence documentation is updated, if needed
[x] New code does not generate new warnings

Closed as this was only intended for reference. The referencing code was already written.


Graph Scaling

[x] Decrease Overall size of Graph
[x] Remove layout function from Graph.tsx
[ ] Improve performance (marginally)
[x] Node Color's based on Event Type
[x] Fix Graph Camera (view new nodes in realtime)
[x] Add option to have an offset for the y-axis


Splitting all the logging drivers

Here I'm adding specific pages for logging driver that where missing.
This is still a work in progress, I'm opening the PR to track progress. I will squash the commits once completed so please don't merge yet
I did also  minor fixes like typos etc.. to this pr
Progress

[x] gelf
[x] syslog
[x] json-file

Comments and reviews are welcome also if work is still in progress

@mstanleyjones everything has been completed, commits squashed, rebased to the master

I did some copy-edits. Let's wait for Netlify to finish and if it looks good, I'll merge this. Thanks!


[WIP] 4. Repositories: Need to reword text under "Institutional Repositories" heading and add FAQ

Wording under "Institutional Repositories" heading is not clear enough for explaining why you should include JScholarship. Note that the wording should still be appropriate when JScholarship is the only option and the user cannot opt out. There should be a FAQ for this to link to and provide more info.
Text will be added when available

Proposed text under Institutional Repositories heading in step 4:
A Submission to the following will put you in compliance with your institution's open access policy. If you are already making your publication openly available elsewhere (e.g. PubMed Central), this may be optional.

Propose FAQ text.
What is my institution's open access policy?
As of July 1, 2018, Johns Hopkins University has implemented an open access policy that requires all peer reviewed articles be made openly available. To learn more about this policy visit the Office of the Provost's webpages on Open Access at Johns Hopkins

Proposed FAQ text.
What is my institution's open access policy?
As of July 1, 2018, Johns Hopkins University will put in effect the university wide open access policy that requires all peer reviewed articles be made openly available. To learn more about this policy visit the Office of the Provost's webpages on Open Access at Johns Hopkins

Proposed FAQ text.
What is my institution's open access policy?
As of July 1, 2018, Johns Hopkins University will put in effect the university wide open access policy that requires all scholarly articles produced by full-time faculty members be made openly available. To learn more about this policy visit the Office of the Provost's webpages on Open Access at Johns Hopkins

sounds good to me

perfect!


Simulated annealing

Wonderful work done. Please could you provide the simulated annealing part of the solution provided in the paper.

Hi @bunmalik, I didn't get a chance to implement that part of the paper.


cross-linux-android with prebuilt NDK toolchains and roc-java dockerfile

This PR contains:

cross-aarch64-linux-android renamed into cross-linux-android;
cross-linux-android image now based on prebuilt NDK toolchains;
roc-java image containing android sdk and ndk.

NB:

For reducing image size and have more granularity over various tools versions, installation by sdkmanager of the various components are executed only when image is run.
If a volume is mounted at /sdk path of the container (for example by -v android-sdk:/sdk option), next run of the image will not install again components already installed previously.
By specifying API, BUILD_TOOLS_VERSION, NDK_VERSION, CMAKE_VERSION environment variables at docker run phase, user can override default values choosing which he prefers;
for example by:
docker run -it --rm -v android-sdk:/sdk --env API=27 --env BUILD_TOOLS_VERSION=27.0.3 roc-java:jdk11 <cmd...>
With docker build hooks two images are built with openjdk10 and openjdk11; other images can be built simply adding more entries to roc-java/hooks/images.csv file.

Awesome!
What do you think about renaming rocproject/roc-java to something like rocproject/roc-java-android or rocproject/java-android, to make it clear that this image is primary intended for Android builds?
(Because it we try to use it to build roc-java for the host system, we'll get libroc.so linked with glibc, libuv, etc. from docker image, not from the host system, which is likely not what we want).

Awesome!
What do you think about renaming rocproject/roc-java to something like rocproject/roc-java-android or rocproject/java-android, to make it clear that this image is primary intended for Android builds?
(Because it we try to use it to build roc-java for the host system, we'll get libroc.so linked with glibc, libuv, etc. from docker image, not from the host system, which is likely not what we want).

Yes I'll rename to rocproject/java-android.

I've added builds of cross-linux-android with NDK versions 19, 20 and 21 (with tags ndk19, ndk20 and ndk21 respectively), which are based on prebuilt toolchains for all platforms and APIs.
If you want to add also NDK version 18 current build hook allows to add a subfolder with a different Dockerfile for that NDK version (i.e. cross-linux-android/ndk18/Dockerfile).
Docker build hooks are now placed on root folder (under hooks) and sym-linked only to sub-folders that need them.

Nitpick: maybe rename /hooks to something like /_hooks to make them distinguishable from images directories?

Thanks!

The images are ready:

https://hub.docker.com/r/rocproject/cross-linux-android/tags
https://hub.docker.com/r/rocproject/java-android/tags

/link https://github.com/roc-project/roc-java/pull/12


Only optional properties of generic parameter are inferred

TypeScript Version:  2.4.0
Code
abstract class Base<TParams> {
    private params: TParams; //cfr https://github.com/Microsoft/TypeScript/issues/1396
}
interface IParams {
    optional?: number;
}
interface IParams2 {
    required: number;
}
class Component extends Base<IParams> {

}
class Component2 extends Base<IParams2> {

}

function test<TParams>(component: Base<TParams>, params: TParams) {
}

var component = new Component();
var component2 = new Component2();

test(component, {  }); //<-- property "optional" of interface "IParams" is inferred correctly (run this in Playground and press ctrl+space with the cursor in the brackets)
test(component2, {  }); //<-- property "required" of interface "IParams2" is NOT inferred at all. It IS inferred when you make optional as well!

Expected behavior:
see comments in the code snippet!

As mentioned in #17655: changing
function test<TParams>(component: Base<TParams>, params: TParams) {
}

To
function test<TParams>(component: Base<TParams>, params: TParams & {}) {
}

Makes the compiler throw an error on the missing "required" property of interface "IParams2".
So as far as enforcing types is concerned, this works.
However, intellisense still does not suggest the property "required" when pressing ctrl+space in the object literal!
It DOES when that property is made optional.

This is the same underlying issue that https://github.com/Microsoft/TypeScript/issues/14829 is addressing. All references to a generic type parameters are used to infer a type from the invocation; in some cases, you want to infer from one, and just check in another. the & {} trick makes it so that you have a lower priority inference and thus use the inference from the other reference only.
another way of doing this is using two type parameters, e.g.:
function test<T, U extends T>(component: Base<T>, params: U) {
}

closing in favor of #14829


Create fedora package vim-bootstrap

Way of using:
dnf install vim-bootstrap
vim-bootstrap -langs=python,lua,ruby,javascript,haskell -editor=vim > ~/.vimrc

Today install https://github.com/avelino/vim-bootstrap#offline-usage

With #275 covering openSUSE install, OBS also provides a way to build Arch, Debian, Ubuntu and Fedora packages. I can look at RPM-based package generation on OBS so packages can be available there for different distributions.


ModuleNotFoundError: No module named 'gym_hiway'

When I run run run_smarts.py, I get the following error
How can I fix this?
Traceback (most recent call last):
  File "examples/run_smarts.py", line 16, in <module>
    from gym_hiway.env.list_hiway_env import ListHiWayEnv
ModuleNotFoundError: No module named 'gym_hiway'

https://github.com/ying-wen/malib/blob/7cd2a4af55cf1f56da8854e26ea7a4f3782ceea2/examples/run_smarts.py#L16

Hi @rsuwa , since the SMARTS environment (gym_hiway) has changed a lot, this 'gym_hiway.env.list_hiway_env' interface is not working anymore.

https://github.com/ying-wen/pymarl/blob/master/src/envs/smarts_env.py  also has issue because AgentPolicy is  deprecated (- Removed deprecated class AgentPolicy from agent.py.)


Proper sort of Grids

I have a problem with sorting grids as you see in the picture below, Green box pushes the Red box down:

But actually i need something like this:

I would appreciate if anyone help to solve my problem. (grid classes included in the images)

Hi @kultz ,
Check out this basic layout http://codepen.io/abdullahsalem/pen/qaNrOO, however you can also nest more grids inside those initial columns (red, green and blue).
Let me know if that helps you, please.

@abdullahsalem Ok, nice solution. But the trick done with extra classes of "column row". Would you please explain how does it work ?

I believe that it is a convenient way to achieve the layout you drew more than it is a "trick" 😃, and to learn more about layouting using Grids component, check out these resources:

http://foundation.zurb.com/sites/docs/grid.html
https://www.youtube.com/playlist?list=PLKlA1QwYBcmfA0tIwFL_LqDeb7EGwo3xu


Implement simplified flash component

Implement simple flash message component (no titles - we only used them for 2 things)
Make success icon great (green) again
Duplicated JS will 🔥 when the existing notification component 🔥 in a subsequent PR

Review app deployed to https://teaching-vacancies-review-pr-3132.london.cloudapps.digital

could you add a screenshot to description of what this looks like?


Fix verification column in SAMM project

Missing data

Fixed

bug was duplicated ID in schema

Fix as deployed to QA server


@mzikherman - Refresh the user account whenever form submission happens on an inquiry

Fixes an issues that wasn't totally fixed in https://github.com/artsy/force/issues/191
The issue being :"If I type in an email that exists, I can't type a new one: https://cl.ly/302b0r052D3d "
This fixes it by clearing the related account whenever the user submits (the related account is whats used to determine whether a user has an account and is not signed in).

Got it, makes sense 👍


how to setup ?

Great addok add-on, thanks for it !
Since v1.0, how should it be installed ? I tried pip install git+https://github..., and the install went ok.
I also modified addok.conf file, but when launching addok, I get an error 'cannot import name get_labels'.
Thanks for your help, Etienne

More doc with this commit edb10f07c64c8a9e97d651fef67614632e188d13
Note: converting to addok 1.0 is still under process.


add MoveTopButton in ConvertHistoryDetailDialog

SSIA

JaCoCo Code Coverage 81.04% :white_check_mark:

Class
Covered
Meta
Status

  Generated by :no_entry_sign: Danger

Snapshot diff report

File name
Image


Relaxing constraints of constant expression

Following points of current specification might be something worth reconsideration especially for AOT compilation.

Classes with non-final members can't be instantiated as constant, but non-final built-in types such as int and List can.
Constant constructors have to be marked asconstregardless of being able to be called withnew.  In addition, the system can likely know the call site contexts to distinguish constant.
Formal parameters of constant constructors aren't "potentially constant expressions" which can be used in initializer lists or bodies of them.

Both int and constant List classes are constant. You can thing of const [list,literal] as creating an instance of a different class than [non,const,list,literal], and the const class is as const as anything. It's special in that it's can have different lengths anyway, and that is special. Integers have no non-final fields either.
Constant constructors are required to have only potentially constant expressions as initializers and have no body. We could allow any constructor satisfying this to be used with const, without needing to mark it as const, but not doing that is deliberate. It would make it a breaking change to add a body to such a constructor, or to change an initializer list expression to being not-potentially const, even if the author never intended the class to be used to create constants. That's why the author has to opt in to a constructor, and thereby the class, being constant capable. It's a significant commitment that restricts further changes to the class. If a constructor isn't marked const, it's because it's not intended to be const and using it as such can and will break in a future update.
Formal parameters of constant constructors are potentially constant expressions and they can be used in initializer lists. They can't be used in bodies since const constructors can't have bodies.
They can't have bodies because we want to guarantee that the constructor can be "evaluated" at compile-time without executing any user-provided code, both to avoid diverging and to avoid needing an interpreter for the entire language in the compiler.
All in all, loosening those particular restrictions is not something we plan to do, unless we do a complete overhaul of the entire constant system.

I understand that int is a class that has only final field and only variable referring it can be mutable.
But, I don't understand that immutable List can be replaced, added and removed the members of it.
Anyway, that's not the point.
I was talking about something breaking change, and I have come to think that this place is not appropriate such a thing.
Thank you anyway.

Const lists are completely immutable, you can't change anything about them. They are as compile-time constant as any other const. A const list does have a remove method, but it will throw if you try to call it.
It's true that this is probably not the best place to start out with a new change suggestion.
It is the correct place to ask for changes, but not a great place for discussions about them.
I'm all for discussing changes to const, even breaking ones. :)
There are just some things that can't be broken without the result no longer being compile-time constants.  In that case, the discussion will be about removing const and replacing it with something else. That's also cool.

Yes const lists such as const [1, 2, 3] is immutable.
I meant `[1, 2, 3]orList(3)is mutable, at the same timeconst [1, 2, 3]`` is legal.

I said that I understand int is immutable, but I change my mind that int is mutable, because i++ must not be re-construction process.
Of course const 1 is constant, anyway.

Formal parameters of constant constructors are potentially constant expressions and they can be used in initializer lists.

They can't.
class A {
  final int a;
  const A(this.a);
}

class B {
  final A a;
  const B(x) : a = const A(x); // error: Arguments of a constant creation must be constant expressions
}

The integer objects themselves are immutable. Doing i++ is equivalent to i = i + 1; and i + 1 is a method call that returns a different integer. It changes which value the variable i is bound to, but the integer objects themselves never change. Due to the way things are defined, it works as if there is exactly one int object with the value 1, one with the value 2, etc., and int.operator+ returns the integer object corresponding to the addition of the values of its operands.
The constant lists are not the same type of list as the non-constant lists, so one being mutable and the other not isn't special. What is interesting is that const [listliteral] is the only way to create instances of the constant list class.
Formal parameters of const constructors can be used as potentially const expressions. However, the code const A(x) requires x to be an actual compile-time constant expression, not just potentially one. That's because it would thenbe an error to write new B(new SomeMutableSubclassOfA()), so we can't allow a potentially constant value to flow into the const A(...) expression.
That is an annoying restriction, and one we would like to do something about. One idea is to allow you to write something equivalent to auto A(x) which would be equivalent to const A(x) when the constructor is called using const and equivalent to new A(x) when called using new Then it would be OK to let x occur in that expression because it would keep const values and non-const values separated and never create a const value with a non-const value inside.

Doing i++ is equivalent to i = i + 1; and i + 1 is a method call that returns a different integer.

I see.

The constant lists are not the same type of list as the non-constant lists.

I understand that, but it is something surprising.

One idea is to allow you to write something equivalent to auto A(x) which would be equivalent to const A(x) when the constructor is called using const and equivalent to new A(x) when called using new

Once, I thought something like this and I think this is reasonable.
At the same time, I think const deemed as auto is also OK, because const constructor can be called with new, anyway.

print("${([1,2,3]).runtimeType}"); // List
print("${(const [1,2,3]).runtimeType}"); // List
print("${([1,2,3]).runtimeType == (const [1,2,3]).runtimeType}"); // false

Surprising!
Is there any specification document of these types?

ECMA-408 seys both of them are List<dyamic>.

There is no documentation of the actual types used to implement list literals. It's an implementation details how they are represented under the hood, all that is promised is that they implement the List interface, which they do so const [] is List<dynamic> is true.
Both List and int are really interfaces, the actual implementation classes are hidden from view, and depending on the implementation would be extremely brittle since there is no promise that it won't change in a future version.
The list implementation types also overwrite the runtimeType getter to further hide the implementation details - otherwise code might work differently between different platforms. The same things is done for int which is actually three different types internally in the VM (for small, medium and big integers).
You can tease the actual type out of the VM using reflection:
import "dart:mirrors";

String className(Object object) =>
    MirrorSystem.getName(reflect(object).type.qualifiedName);

main(){
  // Run on 64-bit VM.
  print(className(const []));     // dart.core._ImmutableList
  print(className(new List(0)));  // dart.core._List
  print(className([]));           // dart.core._GrowableList

  print(className(0));                    // dart.core._Smi
  print(className(0x7fffffffffffffff));   // dart.core._Mint
  print(className(0x10000000000000000));  // dart.core._Bigint

  print(className(0.5));                  // dart.core._Double
}

You can see that the actual classes are private classes in the VM's version of dart:core.
The dart2js compiled version instead has the types _interceptors.JSArray, _interceptors.JSInt and _interceptors.JSDouble.

I have understood runtimeType is exceptional.
Sorry, I miss lead you to describe detail things.
The only thing what I want to know is the reason why user defined classes has stricter restriction to be constant.
I guess that checking expressions constant without specific class representation is too difficult for the system, so user defined types can have only final members but they can't have constructor bodies, and so on, correct?
For what it is too difficult, for JIT compilation ,for AOT compilation or for both of them?
Might Strong Mode change this situation?

The only reason List and Map are special is that there are literals in the syntax to describe them.
That allows the language to treat const literals differently from non-const literals..
The reason that num, String, bool, and null values are special is that the compiler is able to know for certain how their methods/operators work. The classes are sealed and cannot be implemented or extended, so if something is an int, the compiler knows how its + operation works.
The design for compile-time constants has made some choices:

can be computed at compile time without executing any user code
are canonicalized
evaluates to objects not different from other objects of the same class
are created using the same constructor as non-const objects

Together these choices have some consequences:

Const constructors can't contain user code. No body, no method calls except on num/bool/string objects.
Objects must be deeply immutable, otherwise they can't be canonicalized - so no non-final fields.
The constructor initializer list expressions must work both in const and non-const calls, which is why we have introduced the "potentially constant expression" which is very limited, but does allow you to do some simple operations in the constructor.

With those restrictions in place , many changes can make a class or constructor no longer compatible with being const, so we require the class author to opt in to being const. Using a non-const declared class to create const objects is fragile, so we don't allow it. That's a consequence of the restrictions we required above and a wish for authors to write stable dependable code where you can predict which changes might break clients of the class.
That's why you can't use any class that has final fields and a simple constructor with const - it's for your own protection.
All in all, the restrictions are there for a reason, most caused by the initial choices about how compile-time constants in Dart should work. Loosening those restrictions isn't as easy as removing one particular restriction because that would make constants no longer act like constants were intended to work. If anything, it's easier to add more specialized constant expressions, with fine tuned limits, than it is to remove an existing constraint completely.
Possible additions could be:

const instance fields: Liike final fields, but can be read at compile time from a compile-time constant instance). Alone this breaks the field/getter symmetry, so it probably also needs ...
const getters/methods: Methods where the body is a single return of a potentially compile-time constant expression which can only refer to parameters or const instance fields on the same object. These can be called at compile time as a compile-time constant expression. But then we still have to find a way to prevent recursion, otherwise the compiler might never complete.
make c[i] a compile time constant expression if c is a list or map constant and i is a constant index of the appropriate type. But this only works for literal list or map constants, not for any constant object that happen to implement List or Map.

As you can see, there are things to do, but most have a catch that means it's not trivial to add the feature. That means that there has to be a comparable advantage to adding them, otherwise it's just complication without benefit.
Another option is to remove compile-time constants completely and add other features that gives the same benefits for places where you need it (canonicalization, immutability, computed only once, but not necessarily all of them at the same time). That's a major change, so again it requires the benefit to be worth the effort.
So, we're definitely thinking about const, it's not always the best solution for what it's being used for, but changing it isn't simple.


Add  '--experimental-keystone-url' parameter to kube-apiserver.

Is this a BUG REPORT or FEATURE REQUEST? (choose one): FEATURE REQUEST
Hi,
In my environment, I already use openstack and need to authenticate by keystone.
I want to set '--experimental-keystone-url' parameter to '/roles/kubernetes/master/templates/manifests/kube-apiserver.manifest.j2' by inventory variable like others.
Thanks.

This can be set with the apiserver_custom_flags in k8s-cluster.yml

@woopstar Thanks for reply!!


onClick doesn`t work

I cannot click on anything in Firefox. onClick event is ignoring.
Steps to Reproduce (for bugs)
https://material-ui-next.com/demos/tabs/#tabs

Tech
Version

Material-UI
v1.0.0-rc.0

Browser
Mozilla Firefox v60 (x64)

Please provide a full reproduction test case. This would help a lot 👷 .
A live example would be perfect. This codesandbox.io template may be a good starting point. Thank you!


Deprecate govuk-header__navigation--no-service-name class

What
Deprecate the govuk-header__navigation--no-service-name class for removal in a future major release.
Why
This class adds padding to the top of the navigation to compensate for a header that doesn't have a service name:

However, there are no examples of this class, and it's not used in the template. It's not clear why you'd ever want to use it.
(If we do change our mind and decide to keep this class around for some reason, we should add an example for it to the review app)
Who needs to know about this
Designers, developers
Done when

[ ] Class annotated as deprecated
[ ] Release notes make it clear the class is deprecated and will be removed in a future major version.

As discussed in v4 scoping, the work to deprecate this isn't a breaking change. We should deprecate this in a smaller release and then remove it in the next breaking release.


a.textContent is checked even if the text is shortened for the link

Is there a way to skip the check of textContent for the a tag?
https://example.com/foo/...

Originally posted by @MichaIng in https://github.com/lycheeverse/lychee/issues/259#issuecomment-865908305

While checking our forum for outdated links, I recognised that also shortened URL text within anchor tags is checked. phpBB shortens long URLs. so that such an element is produced:
https://example.com/loong/looong/url/th ... index.html

lychee now checks the URL itself but as well the text, where it identifies https://example.com/loong/looong/url/th as URL, which of course fails.
So once a basic functionality exists to exclude URLs/text based on HTML tags, the text content of tags/elements which have an explicit src/href/... attribute could be excluded by default, as AFAIK such shortening is quite common.

Just tested this and you're right. This is a bug, and we should exclude textContent unless --include-verbatim is enabled.

Related: https://github.com/lycheeverse/lychee/issues/1462#issuecomment-2380225133


Handle long genotype names better

This might need a bit of line wrapping:
"KR25A+SV40NLS(K143A,R144A,K145A,R146A,R149A,K151A,K152A,K156A,K161A,R163A,K164A,K169A,K172A,K177A,K184A,K187A,K191A,K217A,K222A,K241A,K242A,K243A,K251A,R256A,K261A,with SV40 NLS added at N-terminus)"
https://www.pombase.org/genotype/5bf20875f2c283f7-genotype-8

A suugestion....we don't really need to be able to actually read these in Canto, other than to differentiate from related alleles.
I suggest that  on "annotation" pages at least we shorten
by
"KR25A+SV40NLS(K143A,R144A,K145A,R146A....."
at some suitably agreed   cut-off ?

read these in Canto

I was mostly thinking about the website genotype pages where that example runs off the side of the screen.
(Although they're too long in Canto too)

[ ]  AI try to find out which  gene/allele this is for future

the example is an allele of swi6 from PMID:22683269 (session 5bf20875f2c283f7)

This is swi6
the issue is in the heading
http://pombase-dev.bioinformatics.nz/genotype/swi6-KR25A%2BSV40NLS-K143A,R144A,K145A,R146A,R149A,K151A,K152A,K156A,K161A,R163A,K164A,K169A,K172A,K177A,K184A,K187A,K191A,K217A,K222A,K241A,K242A,K243A,K251A,R256A,K261A,with_SV40_NLS_added_at_N-terminus-other-expression-not_assayed
AI:  introduce a teeny-weeny bit of whitespace to enable line wrapping

https://www.pombase.org/genotype/swi6-KR25A%2BSV40NLS-K143A,R144A,K145A,R146A,R149A,K151A,K152A,K156A,K161A,R163A,K164A,K169A,K172A,K177A,K184A,K187A,K191A,K217A,K222A,K241A,K242A,K243A,K251A,R256A,K261A,with_SV40_NLS_added_at_N-terminus-other-expression-not_assayed
only a problem in the header:

gene page and  alelle page otherwise fine...

Is this a solution? If so looks quick?

That's fixed now.


Remove allocation in hashDigest to improve hashing speed

Using an constant-sized array rather than a slice lets Go allocate the hash
on the stack rather than the heap when possible.
benchmark                   old ns/op     new ns/op     delta
BenchmarkHashes-8           771           497           -35.54%
BenchmarkHashesSingle-8     492           239           -51.42%

benchmark                   old allocs     new allocs     delta
BenchmarkHashes-8           4              1              -75.00%
BenchmarkHashesSingle-8     3              0              -100.00%

Hey @serialx have you had a chance to look at this? 😄

Oops! Sorry for the delay. LGTM!

awesome, thanks!


defaults: fix missing 'tableau_ssl_crt_ext' default variable

Fixing a typo introduced with #8

cc @gaetanfl

This is a necessary change. Would be great to have it in the master branch.

cc @wikitops


Support for "const modifier on type parameters" with JSDoc

🔍 Search Terms
"const type parameter jsdoc", "const generic jsdoc", "const template jsdoc"
✅ Viability Checklist

[X] This wouldn't be a breaking change in existing TypeScript/JavaScript code
[X] This wouldn't change the runtime behavior of existing JavaScript code
[X] This could be implemented without emitting different JS based on the types of the expressions
[X] This isn't a runtime feature (e.g. library functionality, non-ECMAScript syntax with JavaScript output, new syntax sugar for JS, etc.)
[X] This isn't a request to add a new utility type: https://github.com/microsoft/TypeScript/wiki/No-New-Utility-Types
[X] This feature would agree with the rest of our Design Goals: https://github.com/Microsoft/TypeScript/wiki/TypeScript-Design-Goals

⭐ Suggestion
v5.0 added support for "const modifier on type parameters", but it is not supported with JSDoc @template tag (or at least I couldn't make it work nor find any documentation about it).
I propose adding support for the const prefix in the @template squirrely braces:
/**
* @template {const Array<any>} T
*/

📃 Motivating Example
The same as "const modifier on type parameters" itself..
💻 Use Cases

What do you want to use this for?
...
What shortcomings exist with current approaches?
...
What workarounds are you using in the meantime?
I have to wrap the generic value with /** @type {const} */(...) every time I'm using the function

A workaround for this that you can use at the declaration site:
/** @type {<const T>(a: T) => T} */
function test(a) {
    return a;
}

@Andarist thanks! :)

squirrely braces

Well, that’s a new one 😆

is U const? Who knows.

Reminds me of C pointers.
int* p,q;  // p is int*, q is int

Used to trip me up all the time; now it just annoys me.

I see this is checked in and marked as completed, but I cannot make it work? If I try to run the same thing as from the connected checkin, I get this:

Ok, the first part (about not being able to set @template const) was up to vscode language server using older typescript version.
Still, I am not able to set explicit type for jsdoc typed function:


Incorrect null checks

Given the following code:
import 'package:clickdating_server/src/generated/protocol.dart';
import 'package:serverpod/serverpod.dart';
import 'package:serverpod_auth_server/module.dart';

class AdminEndpoint extends Endpoint {
  @override
  get requireLogin => true;

  @override
  get requiredScopes => {Scope.admin};

  Future<void> banUserById(Session session, int userId) async {
    await session.auth.signOutUser(userId: userId);
    await Users.invalidateCacheForUser(session, userId);
    final user = await Users.findUserByUserId(session, userId);
    assert(user != null);
    user!.blocked = true;     // (1) `!` is required here
    await session.db.update(user);
    final profile = await Profile.findSingleRow(session,
        where: (profileTable) => profileTable.userId.equals(userId));
    assert(profile != null);
    profile!.accountStatus = 'B';  // (2) `!` is required here
    profile!.accountStatusChangedDate = DateTime.now();   // (3) `!` is not needed here
    await Profile.update(session, profile!);    // (4) `!` is not needed here
  }
}

See the commented lines.
For (1) and (2), really the linter or compiler should do a better job of realizing the assertion guarantees the local is not null after the assertion.
But even if that's not possible (because it is Dart's policy to not rely on assertions for null analysis, e.g. if assertion checks can be disabled), then still (3) and (4) should not be reporting The '!' will have no effect because the receiver can't be null. Try removing the '!' operator.
(2) is inconsistent with (3) / (4).

Dart 3.0.1, Linux

The thing is, asserts can be disabled. So basically asserts aren't guaranteed to run, therefore it can lead to unsafe behavior.

(2) is inconsistent with (3)/(4).

Basically when you use a null-assert operator !, it promotes the variable to non-nullable, because there are two cases.
First case, the null-assert operator throws an Exception. Basically, the code after it doesn't run because it is null.
Second case, the null-assert operator succeeds guaranteeing to the compiler that the value is not null. So it doesn't force you to null assert again after (2). See here:
import 'package:clickdating_server/src/generated/protocol.dart';
import 'package:serverpod/serverpod.dart';
import 'package:serverpod_auth_server/module.dart';

class AdminEndpoint extends Endpoint {
  @override
  get requireLogin => true;

  @override
  get requiredScopes => {Scope.admin};

  Future<void> banUserById(Session session, int userId) async {
    // ...
    final profile = await Profile.findSingleRow(session,
        where: (profileTable) => profileTable.userId.equals(userId));
    assert(profile != null);
    // If [profile] is [null], the program will throw an exception, ignoring the code below.
    // else it's not [null], and we continue running, guaranteeing that it's not null anymore,
    //   so we don't need the assert in the following lines after this.
    profile!.accountStatus = 'B';  // (2) `!` is required here
    //  (You *can* remove it now, because it got promoted by the compiler to not null).
    profile!.accountStatusChangedDate = DateTime.now();   // (3) `!` is not needed here
    await Profile.update(session, profile!);    // (4) `!` is not needed here
  }
}

Also, asserts aren't guaranteed to run in production, so it's unsafe to use them as null assertions. (Which you noted.)

    //  (You *can* remove it now, because it got promoted by the compiler to not null).

No, I can't remove the ! at (2), it is required. Presumably because asserts can be disabled.
However I solved the mystery as to why the ! is not needed at (3) or (4): those two instances are guarded by (2). I thought it was inconsistent behavior, but if I remove the ! from (3) and (4), there is no error, but if I then remove the ! from (2), there is an error on all 3 lines, because there is now no guard.
I hadn't taken the guarding behavior into consideration, which is why I found this fishy. But now it makes perfect sense. Thanks, and sorry to take your time on this!


Update README.md

@jackowild please check this one too

@diegolinan can you squash the merge next time please. The history now has 5 Update README.md commits.

Oops... Forgot to do that. Sorry.


added organization and starred repos api

@Anmol92verma I don't see any option to see the organizations or starred repos 🤷🏻♂

@nikhilbansal97 the api for org and starred repos is written in github.dart . Can’t you see that in the commit ?

I meant in the app. There is no option to see the organizations and starred repos in the app.

Yes bhai! That will be added with the view


Not available on Sub-sites & Cannot deploy throgh App-Catalog (App Stapling)

We have multiple site collections and many sub-sites within. The content authors intent to use the modern web-parts even from the sub-sites. We want the web parts to be by default available across sub-sites once installed at the root. Its a very tedious process & practically not possible to ask the site owners to install the app across all sites considering the amout of sub-sites in scope.
We observed the below issues though - to achieve the objective

Web parts installed in root site is not available to sub-sites. Added to App-catalog and installed in Root site.
Unlike the regular SharePoint Add-ins / .APP which can be installed at the app-catalog and deployed across site collections from app-catalog, when we try this with the moden web parts it fails with an exception

This is a very important capability which you might have to consider and if not will result in limited usage of the framework for large scale implementations.

My client needs this capability too, but it's currently not supported:
#483 (comment)
#344 (comment)
Hopefully tenant-scoped deployment (SPFx equivalent described by Pat in the 2nd link above) will be implemented soon to resolve this...


Added reset.css code. Added javascript link, jquery link, materialize…

… link into html.

Thanks for this!


Support picking variants for SF Symbols

The current implementation works, and shouldn't block an initial release. Pushing to 'Next'.


How to configure format?

Hi,
I want to be able to configure the format, e.g.: 2017-11-21 or 08:31.
Looking at your code I see that it isn't possible.
Also I see that you're using a lot of hard coded stuff. I can very well imagine that people might want to use another language besides English.
See for example this line in my vim settings. I have bound F11 to strftime("%H:%M") which returns the result of the unix function strftime.

@m-ghaoui, you are absolutely right and may not believe, but I want it also to be configurable. That's is a future of this extension. And thank you very much for submitting your request.
Please, take  a look at the following PullR:
https://github.com/jvlad/InsertTimeStamp.vscode.ts/pull/3
There may be the feature you want. I didn't like the code in that PullR since it doesn't lead the project to the direction I want. Therefore, I didn't merge that PullR.
I want to support prefix and postfix – strings that will appear along with timestamp itself. Feature#1
Another thing that I want to have as well: support multiple formats and assign shortcuts for each of them. Feature#2
Consider the use case:

Each time you press Ctrl+Alt+T you get timestamp like ###### Tue Nov 21 17:42:58 MSK 2017
AND
Each time you press Ctrl+Alt+D you get timestamp like Today: 2017-11-21

Support multiple languages for names of months and week_days is a killer feature. I want it as well.
Feature#3
The problem: don't have time to work on it. Your request played a huge role in moving the development of this extension forward: above I have just written the specification.

I'm not sure what direction you want the extension to take that the pull-request does not. The prefix and postfix strings can easily be modified with a custom format. By implementing custom formats, desired features #1 and #2 are immediately covered. Even if there are some details to work out in new features, the extension is crippled without any customization.

By implementing custom formats, desired Feature#1 and Feature#2 are immediately covered
– @kupiakos, you are right about Feature#1. It's funny I didn't think about it that way. Thanks a lot for the point. Indeed, it seems to be useless to work on Feature#1 as it was formulated.
Feature#2 is as a bit more complex, I mean, having custom formats is required but not sufficient for having Feature#2.

Anyway, the main problem with pushing on the development process is the lack of my time.

the extension is crippled without any customization
– totally agree. However, I still use it the way I intended to use it many time every day. It's not excuse, I just wanted to point out that there is at least one person who still sees the extension as a bit useful piece of code.

I suppose what I don't understand is why the pull request which fully implements Feature#1, and partially implements Feature#2, is not being merged into the current codebase, considering it would bring the repo closer to the end-goal, even if not completely there.

See your point. Hope to take yet another look at the pull request you
mentioned in 2 weeks. It was a long time ago I considered to not to merge
it...
On Mon, Feb 12, 2018 at 11:19 PM, Alyssa Haroldsen<EMAIL_ADDRESS>
wrote:

I suppose what I don't understand is why the pull request which fully
implements Feature#1, and partially implements Feature#2, is not
being merged into the current codebase, considering it would bring the repo
closer to the end-goal, even if not completely there.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/jvlad/InsertTimeStamp.vscode.ts/issues/4#issuecomment-365049139,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AL98kdwuWu3eWjrm2h1i6j1_2o75uIxIks5tUJy6gaJpZM4QlZ0X
.

--
Vlad Zamskoi.
+375 25 721-4985
 (Minsk, Belarus)
+972 53 306-5004
 (Ramat Gan, Israel)
I am mobile apps developer;
learn more at mobileAppSoft.com http://mobileappsoft.com/


testing

finally time to connect, create db, seed the stuff, and test if the get, post, put, and delete routes in all the files work.

Testing is ongoing, but so far I've tested get request and it works.
Fixed a issue where reference tables were not found. Apparently modelName in all the files are not capitalize, so now all the model names are capitalized and it works now.
this was the error
Unhandled rejection SequelizeDatabaseError: Failed to open the referenced table 'category'     at Query.formatError (D:\WEBDEV\Modules\13-orm\wk13-ORM-E-commerce-Back-End\develop\node_modules\sequelize\lib\dialects\mysql\query.js:244:16)     at Query.handler [as onResult] (D:\WEBDEV\Modules\13-orm\wk13-ORM-E-commerce-Back-End\develop\node_modules\sequelize\lib\dialects\mysql\query.js:51:23)     at Query.execute (D:\WEBDEV\Modules\13-orm\wk13-ORM-E-commerce-Back-End\develop\node_modules\mysql2\lib\commands\command.js:36:14)     at Connection.handlePacket (D:\WEBDEV\Modules\13-orm\wk13-ORM-E-commerce-Back-End\develop\node_modules\mysql2\lib\connection.js:456:32)     at PacketParser.onPacket (D:\WEBDEV\Modules\13-orm\wk13-ORM-E-commerce-Back-End\develop\node_modules\mysql2\lib\connection.js:85:12)     at PacketParser.executeStart (D:\WEBDEV\Modules\13-orm\wk13-ORM-E-commerce-Back-End\develop\node_modules\mysql2\lib\packet_parser.js:75:16)     at Socket.<anonymous> (D:\WEBDEV\Modules\13-orm\wk13-ORM-E-commerce-Back-End\develop\node_modules\mysql2\lib\connection.js:92:25)     at Socket.emit (node:events:514:28)     at addChunk (node:internal/streams/readable:545:12)     at readableAddChunkPushByteMode (node:internal/streams/readable:495:3)     at Readable.push (node:internal/streams/readable:375:5)     at TCP.onStreamRead (node:internal/stream_base_commons:190:23)

Keep getting SequelizeEagerLoadingError only in product-routes.
CRUD functions in category-routes and tag-routes

Testing completed. All issues resolved. I was initially unable to create a new product. But I realize I was using tag_id for all my codes, while the starter code was using tagId. Once I changed that in my post request for product I was able to get everything working.


CommonUtils - ensure home directory exists.

The common utils attempts to copy certain config files into the user's home directory... without first ensuring the directory exists!
Create the user's home directory if it doesn't exist.

@microsoft-github-policy-service agree


serrors: Add linter

This changes adds a linter that ensures the varargs input to
serrors.{New, WithCtx, Wrap, WrapStr} is well-formed.
fixes #3196

This change is

WORKSPACE, line 293 at r1 (raw file):
Previously, sustrik (Martin Sustrik) wrote…
Add at least a one-line readme to the GitHub repo so that it's obvious what it is for.

I would suggest also that this goes into anapaya/scion space in case someone would like to make a change.

WORKSPACE, line 293 at r1 (raw file):
Previously, sustrik (Martin Sustrik) wrote…

Add at least a one-line readme to the GitHub repo so that it's obvious what it is for.

I would suggest also that this goes into anapaya/scion space in case someone would like to make a change.

As this is a personal project I'm doing outside of work, I don't think this should be in scionproto.

WORKSPACE, line 293 at r1 (raw file):
Previously, Oncilla wrote…
As this is a personal project I'm doing outside of work, I don't think this should be in scionproto.

ack


Undefined Method When Running Artisan make:searchable-model

Not sure why, when following the tutorial in GitHub and in your article on Medium. I am getting the following error:
php artisan make:searchable-model Content --index-configurator=ContentIndexConfigurator
[Symfony\Component\Debug\Exception\FatalThrowableError]
Call to undefined method Illuminate\Foundation\Console\ModelMakeCommand::handle()
I tried artisan cache:clear, artisan config:clear, composer dump-autoload and re-ran, but same result. I also tried to find the SearchableModel class to check that out  ScoutElastic\SearchableModel, but I don't seem to have it.
Any ideas?

Nevermind, in Laravel 5.4 ModelMakeCommand.php does not have handle() function, it has a fire(), which was changed in 5.5. I am going to fork and make a version that works for us in 5.4 if possible. I will make a PR after if you want to check it out.  Thanks.

Hey, you can use v1.3.1. It works with Laravel 5.4. Some new features won't be available, but everything described in the README for that version should work.

@sajadk are you sure, that you are using Laravel 5.6?
ModelMakeCommand has the handle method https://github.com/laravel/framework/blob/bbe8950cbe86df1818dfe32fed8b906cbf093e5e/src/Illuminate/Foundation/Console/ModelMakeCommand.php#L37

@babenkoivan oh..sorry! I was running this command in Laravel 5.4 version of the project.


Cargo invocation has failed: Error: spawn ENOMEM

Which OS: windows10
Which VSCode version: 1.40.1
Which extension version: 1.4.1
Which adapter type: native
What is the problem and how did you get there:
It works fine in 1.4.0. But when i upgraded to 1.4.1 and debugged, vscode reported an error:
Cargo invocation has failed: Error: spawn ENOMEM' .

There is no useful message in output even if i turns on the lldb.verboseLogging,  just Running `cargo run --message-format=json`... .
Cargo works fine too in terminal.
launch.json
    "version": "0.2.0",
    "configurations": [
        {
            "type": "lldb",
            "request": "launch",
            "name": "Cargo launch",
            "cargo": {
                "args": [
                    "run",
                ]
            },
            "program": "${cargo:program}",
            "args": []
        }
    ]
}

I have the same issue on macOS 10.14.6 (Mojave) and VSCode 1.40.1

Also noticing ENOENT on macOS 10.15.1 (Catalina) and VSCode 1.40.1

Also  "Error: spawn cargo ENOENT" on Manjaro 18.1.0 VSCode 1.40.1

ENOENT on Fedora 31
VSCode 1.40.1
LLDB Extension 1.40.1 with native adapter (classic doesn't work either).
Downgrading to 1.40.0 fixes the problem for me.

I tried downgrading to 1.38.0, but still doesn't work for me (ENOENT)

MacOS 10.14.6
VSCode 1.40.1
Extension 1.4.1 doesn't work. Gives an error "Error: spawn cargo ENOENT". In Developer Tools I see the line "ERR No application in the Launch Services database matches the input criteria."
Extension 1.4.0 works perfectly fine.

Arch Linux
VSC 1.40.1
Downgrading to code-lldb 1.4.0 works for me too.

This error also macOS and win10, I think someone missed PATH environment variables.

The issue doesn't look like the bug of extensions but editor. It seems to be resolved in vscode 1.40.2(https://github.com/microsoft/vscode/issues/84540). But I'm not sure if ENOENT error is also resolved.

Downgrading to 1.4.0 worked for me

osX 10.15.1
viscode  1.40.2
Acquiring platform package for CodeLLDB.
Package is located at https://github.com/vadimcn/vscode-lldb/releases/download/v1.4.2/vscode-lldb-x86_64-darwin.vsix
Downloading...
Downloaded 0%
Downloaded 5%
Downloaded 5%
Downloaded 5%
Downloaded 10%
Downloaded 10%
Downloaded 15%
Downloaded 20%
Downloaded 15%
Downloaded 25%
Downloaded 30%
Downloaded 35%
Installing...
Installing...
Installing...
Downloading lldb stops downloading
Error: end of central directory record signal not found
There's an error like this.

Cargo invocation should be fixed in 1.4.2.
@seong8681: download issue is likely something else.  Try re-installing the extension.


[Bug/Crash]: Doesn't work on exported game, missing .dll file

What happened?
If I play from the editor it works fine, but when exporting my game, it no longer works. I did some testing, and in a new project I saw when exporting the game, 2 .dll files are being created, but on my project only 1 .dll file is being created, which is "discord_game_sdk_binding.dll" I don't understand why this is happening, and guessing this is the reason it doesn't work when exporting, hope you can help.
Version
1.5
Godot Version
4.0.2 stable
GDScript
extends Node

# Called when the node enters the scene tree for the first time.
func _ready():
	set_physics_process(false)

	Discord_Activity.app_id = *****REMOVED*****
	print("is discord working: " + str(Discord_Activity.get_is_discord_working()))
	Discord_Activity.details = "Loading into space..."
	Discord_Activity.large_image = "game_icon"
	Discord_Activity.start_timestamp = int(Time.get_unix_time_from_system())
	Discord_Activity.refresh()

var update_timer : float = 15
var update_start_time : float = 10

func _process(delta):
	update_timer -= delta
	if update_timer <= 0:
		update_timer = update_start_time
		update_activity()

func update_activity():
	Discord_Activity.details = "Buying and selling"
	Discord_Activity.state = "Money: "+  str(player_data.money_usd).pad_decimals(2)
	Discord_Activity.refresh()

Additional information
Log file:
USER SCRIPT ERROR: Parse Error: Identifier "Discord_Activity" not declared in the current scope.
at: GDScript::reload (res://addons/discord-sdk-gd/sdk_utility.gd:4)
USER ERROR: Script does not inherit from Node: res://addons/discord-sdk-gd/sdk_utility.gd.
at: start (main/main.cpp:2776)
USER SCRIPT ERROR: Parse Error: Identifier "Discord_Activity" not declared in the current scope.
at: GDScript::reload (res://discord.gd:8)
USER SCRIPT ERROR: Parse Error: Identifier "Discord_Activity" not declared in the current scope.
at: GDScript::reload (res://discord.gd:9)
USER SCRIPT ERROR: Parse Error: Identifier "Discord_Activity" not declared in the current scope.
at: GDScript::reload (res://discord.gd:10)
USER SCRIPT ERROR: Parse Error: Identifier "Discord_Activity" not declared in the current scope.
at: GDScript::reload (res://discord.gd:11)
USER SCRIPT ERROR: Parse Error: Identifier "Discord_Activity" not declared in the current scope.
at: GDScript::reload (res://discord.gd:12)
USER SCRIPT ERROR: Parse Error: Identifier "Discord_Activity" not declared in the current scope.
at: GDScript::reload (res://discord.gd:13)
USER SCRIPT ERROR: Parse Error: Identifier "Discord_Activity" not declared in the current scope.
at: GDScript::reload (res://discord.gd:25)
USER SCRIPT ERROR: Parse Error: Identifier "Discord_Activity" not declared in the current scope.
at: GDScript::reload (res://discord.gd:26)
USER SCRIPT ERROR: Parse Error: Identifier "Discord_Activity" not declared in the current scope.
at: GDScript::reload (res://discord.gd:27)
Checks

[X] I tried reinstalling the addon in a new project.

Okay so I continued to mess around with it, and after making a new export preset it creates both .dll files, not sure if this is intended, a common issue, or just a me problem. Not sure what you want me to do with this issue, I'll leave it open until you reply.

This is could be a very weird godot bug i assume. There is a export script wich checks for export events and copies the extra dll file in this addon. Did you really just make a new export preset nothing else? Weird would make more sense when this would be fixed with new export template files

I'll probably add this to a FAQ section in the docs when i'll release 2.0 if this isn't a corrupt template issue

Did you really just make a new export preset nothing else? Weird would make more sense when this would be fixed with new export template files

Yes, I just clicked add new and created a new Windows export (forgot to say what platform before), and it worked, after that I copied over my settings manually one by one and it worked again with my settings, don't really understand it. The project itself worked fine with the other export preset, and that preset is from months ago from before I added the plugin, as I added the plugin yesterday. I will also say, that export preset is probably created with a Godot 4 alpha build, maybe beta, as I started this project when the alpha release of Godot 4, so maybe that could also be something to do with it, but I don't really know.

I also tested this in 1.5 in a new project, using the default Windows Desktop export preset, and it created the two .dll files just fine.

Oh youset 1.5 already as your version? Because exports where heavily buggy in 1.4

Oh, well, I never tried to export the project before now.

oh lol sorry i thought you where the first person i was on mobile

So, this is fixed now? Because you closed the issue. OP was also using 1.5.

So I just tried exporting my project again, with the new preset, and it is only exporting 1 .dll once again...
Also this error was printed to the console: editor/export/editor_export_plugin.h:125 - Required virtual method EditorExportPlugin::_get_name must be overridden before calling.

Also this error was printed to the console: editor/export/editor_export_plugin.h:125 - Required virtual method EditorExportPlugin::_get_name must be overridden before calling.

This also happens to me, but only when I load the project and export it for the first time. After that, the error doesn't happen. When I restart the project and export the game for the first time again, the error happens. It doesn't seem to me like it affects anything, though.

This also happens to me, but only when I load the project and export it for the first time. After that, the error doesn't happen. When I restart the project and export the game for the first time again, the error happens. It doesn't seem to me like it affects anything, though.

Okay yeah, this is also true for me, but my 2nd .dll file is still not being exported, so maybe the error isn't relevant to my issue. I might end up either just needing to remember not to delete the 2nd .dll file ever and maybe it won't need a new one every time, or just remove the plugin and forget about using it for this project since this issue seems specific to my project possibly.

Well, both files are located in bin// (in this case windows). You could export the project and copy the files from there into your export destination folder.

editor/export/editor_export_plugin.h:125 - Required virtual method EditorExportPlugin::_get_name must be overridden before calling

Also I think we should move this into it's own issue.


Not possible to write unit tests for components that import Monaco editor

Describe the bug
We weren't able to write unit tests for components that used some component that imported Monaco editor. Screenshot attached.
To Reproduce
Steps to reproduce the behavior:

Create new unit test
Import eg. kube-object-menu.tsx
Try rendering the component (or even console.log)
See error

Expected behavior
Shouldn't crash fatally.
Screenshots
Environment

Lens Version: from master
OS: OSX
Running tests using make test -- --watch

For the time being I think you need to use jest.mock("react-monaco-editor", () => null); until this is fixed by #4225


palettes:0.3.0

I am submitting

[x] a new package
[ ] an update for a package

I have read and followed the submission guidelines and, in particular, I

[x] selected a name in conformance with the guidelines
[x] added a typst.toml file with all required keys
[x] added a README.md with documentation for my package
[x] have chosen a license and added a LICENSE file or linked one in my README.md
[x] ensured that my submission does not infringe upon the rights of a third party
[x] tested my package locally on my system and it worked
[x] named this PR as name:version of the submitted package
[x] agree that my package will not be removed without good reason

Description: This library provides different color palettes with human-readable names in Typst dictionaries.

Hey, thanks for your package submission! Could you add a bit of "pazazz" to the package name? As-is, it's merely descriptive, which could deceive users into assuming this is an officially endorsed package.

Thank you for the response! Sure thing.

I hope this name has enough pazazz :smiley:

It sure has!

Thank you!


Updating taco-remote-lib to cope with cordova 5.4.0

Cordova 5.4.0 uses a new option type to pass arguments, and this change adapts to that. taco-remote-multiplexer now inspects the cordova version, and selects between a new version and the previous version depending on which cordova is targeted.

@nisheetjain do you agree with how this forking is done? If we want to make bugfixes / feature additions for both older and newer cordovas, with this structure we'll have to release multiple new packages...

Looks good to me. yes I agree with the change. This is how we originally planned it :)


Allow animations at different speeds than 60 FPS.

Related mbostock/d3#802. Since we use requestAnimationFrame internally, all animations run at 60 FPS. It might be nice to allow animations at other frame rates… but it’s not clear how that API should be exposed.

Punting on this.


Fix crash on PtraceCleanup

I found I was getting a crash, due to an unhandled SIGTRAP, the second time I profiled a process with --threads. My initial thought was that this was because the munmap stuff was not thread safe (it doesn't pause threads while poking instructions into code), so fixed this.
However, I was wrong. The real issue is that for reasons I don't fully understand, the PtraceCleanup isn't successful unless we explicitly detach from the process - implicitly detaching by exiting does not seem to be sufficient. I've added an explicit PtraceDetach, and I don't see the issue any more.
I've also modified PtraceAttach to use waitpid with __WALL. This was mostly done as a debugging measure (one theory was that maybe it was stopping on the wrong thing, so I thought tightening up the wait logic might force it to fail earlier), although it may have the side effect of allowing --threads on pre-4.9 kernels, so I've left it in.

I think this may also fix #60. The SYSCALL-ADD-ADD-ADD in the disassembly (just after another SYSCALL, where it couldn't possibly work) in that issue is similar to what I've seen - ADD rax is 0x0000, so this is the remnant of poking 0x0000000000000f05.

Interesting. There are a lot of weird idiosyncrasies around ptrace, so yeah, this may be necessary.


Sometimes, terminal is not responsive to mouse events

Once I left the terminal opened for a while, I can notice that the terminal is not responsive to mouse events anymore, and the mouse pointer design keeps on horizontal movement mode (the pointer with two arrows, one to the left, the other to the right).
The mouse is useless in any button of the terminal (since buttons to child windows or alert boxes), though they all work correctly (when key-stroking at least).
I do not think I could give any more details (reproduction, for example), and I did my best to explain the error itself, but if any of you guys think you actually need more information, I will give it to you as well and fast as possible.

Update: the mouse pointer design is not always the horizontal move one. It varies depending on the border you hover when entering the window (entering from sides will make the cursor a horizontal moving, while entering from below makes it a vertical moving and entering from the status bar, over the window, will make it stay as an arrow pointer unless there is a tab. In that case it will make it an horizontal move cursor).

@Vyber90 any chance you're using PowerToys?

I use PowerToys, but I do not let it run in the background for performance reasons. Only for PowerRename.
My WT version is 0.11.1121.0

I'm actually having the same and persistent problem right now. It is happening on a newly opened terminal, and persists even after opening. For me it's the vertical move drag mouse.
Afaik I am not using PowerToys. I'm running version 0.11.1191.0 distributed from the windows store.

I guess an additional difference in my case is the entire terminal seems to be also un-responsive to keyboard input. I can drag the window from the title bar, but none of the title-bar buttons work, nor does right-clicking do anything.

I have the same problem. The whole window doesn't respond to mouse actions other than dragging via the title bar. Closing power toys and restarting the terminal solves the problem.

@ScatteredRay that sounds like #4448, actually. We're working with the input team to track that one down.
@Vyber90 even though you're not running PowerToys constantly, i'd be interested to see if upgrading it to >=0.17 helps you.

@DHowett-MSFT I just observed that, if I do not use PowerToys at all, the Terminal's window works correctly as far as I am concerned. With PT 0.17 it works properly too.
By the way, I am that guy who sent you the diagnostics report about some keyboard problems in order to not make a whole new GitHub issue. Actually, it seems like there were mouse problems in the beginning, but now they got replaced by keyboard troubles.

Thanks for that repro, by the way. The Windows team is, as you might imagine, busy with some conference stuff... but we'll be able to get to it soon.
Thanks for confirming about PT as well. Gonna close this one out as a duplicate of the other issue we're using to track "powertoys blows up terminal".
/dup #3325.


Switched to sdx.common async_consumer.

Closing for now - superseded by standalone rabbit consumer work and will need to be reapplied to new default branch (master)


Add additional simple support nogoods

If there are multiple ground rules in the input program (i.e., before grounding!), each with a unique ground head, we can generate completion nogoods for each of them. So far this did not happen if the unique ground heads were of the same predicate.

Build fails because of #239, but I do not think the cause for this issue comes from this pull request.

Thank you for the reminder. This PR adds certain completion nogoods, which is a good step in the right direction. There is, however, also a more principled approach in the direction of adding completion noogods currently under development (see PR #283 ). What is added here, also gets generated in #283 and more. I am currently working on the completion branch/PR (it needs a complete restructuring itself to cover more cases), with the goal of getting it ready in the next month. It is quite likely that this contribution here will be overwritten/redone/removed with #283. Do you still want it merged at this time?

Yes please, because having ready features merged to master reduces maintenance efforts when we need them in other branches.
Thanks for your work on #283 though!

I just found out that this pull request is buggy, because it does not check for multiple ground rules whose heads are of the same predicate if the heads are actually different.
For example, consider the following program:
h :- not a.
h :- not b.

With this pull request, completion nogoods for both rules are created individually, which is wrong.
Therefore, @AntoniusW I´m retracting this pull request and hope to be able to use your feature soon! I suggest you incorporate a unit test for this very condition in your branch.


Update contributing guide with new label policy

Update contributing guide with the new label policy including C and M labels.
Update PR template with more concrete instructions on labels.

Sorry for the cross post :)
PRs

A-* Pull request status. @s3krit: Automation should ensure this is kept in sync with GH's native review system. ONE REQUIRED.
B-* Changelog and/or Runtime-upgrade post composition markers. Automation uses this. ONE REQUIRED.
C-* Release notes release-priority markers. Automation uses this. EXACTLY ONE REQUIRED.
D-* More general tags on the PR denoting various implications and requirements.

Issues

I-* Issue severity and type. EXACTLY ONE REQUIRED.
P-* Issue priority. AT MOST ONE ALLOWED.
Q-* Issue difficulty. AT MOST ONE ALLOWED.
Z-* More general tags on the issue, denoting context and resolution.

I have removed the M-* class as they have in any case been superseded by GH's Project functionality.

While updating the PR template I noticed that it is actually a checklist, not a template.
Do we want to add something more template-like to the top? Suggestions?


Can't edit title of parent task

There is no way how to change the title of a parent task. Here's some boilerplate code to test with:
const Listr = require('listr')

const tasks = new Listr([
    {
        title: "My task",
        task: (ctx, majorTask) => new Listr([
            {
                title: "Minor task 1",
                task: (ctx, minorTask) => new Promise((res, rej) => {
                    setTimeout(res, 2000)
                }).then(() => minorTask.title += " DONE")
            },
            {
                title: "Minor task 2",
                task: (ctx, minorTask) => new Promise((res, rej) => {
                    setTimeout(res, 2000)
                }).then(() => minorTask.title += " DONE")
            },
        ], { concurrent: false }).then(() => {
            majorTask.title += ' DONE'
        })
    }
])

tasks.run()

The new Listr().then() part doesn't work of course.
The only way I can think of is wrapping new Listr().run() into my own Promise, but what a hassle.
Instead of 'DONE' I would of course like to use something more practical like counting minutes that the task took to complete.

Well I made a hack. Would be nice for a cleaner way of doing this:
const Listr = require('listr')

const tasks = new Listr([
    {
        title: "My task",
        task: (ctx, majorTask) => new Listr([
            {
                title: "Minor task 1",
                task: (ctx, minorTask) => new Promise((res, rej) => {
                    setTimeout(() => {
                        if (isLastTask(minorTask))
                            majorTask.title += " DONE"
                        res()
                    }, 2000)
                })
            },
            {
                title: "Minor task 2",
                task: (ctx, minorTask) => new Promise((res, rej) => {
                    setTimeout(() => {
                        if (isLastTask(minorTask))
                            majorTask.title += " DONE"
                        res()
                    }, 2000)
                })
            }
        ], { concurrent: false })
    }
])

tasks.run()

function isLastTask(task) {
    let waiting = 0
    for (const t of task._task._listr._tasks) {
        if (t.isStopped !== true)
            waiting++
    }
    return waiting <= 1
}

I have the same requirement. Might be nice to have a complete task property that is called when a task completes.
In the meantime my approach is to override the subtask instance's run method to add a promise handler that updates the parent title:
new Listr([{
  title: 'Parent',
  task: (ctx, task) => {
    const list = new Listr(subtasks);
    const runFn = list.run.bind(list);

    list.run = () => {
      return runFn().then(() => {
        task.title += " is done"; // "Parent is done"
      });
    };

    return list;
  },
}]);


fix: Image with voiLUT not apply ww and wc changes.

An explicit VOI LUT serves as a Replacement for Window Centre and Width therefore it is NOT technically allowed to window an image with a VOI LUT applied.
I guess the behaviour shown by the library is as per standards


Feature/generators

Organizes generators, adds more docs, tests & doctests
Adds an approximate generator for integers, floats, and calendar terms
Adds some counter-based generators

Welcome to Codecov :tada:
Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.
Thanks for integrating Codecov - We've got you covered :open_umbrella:


Device page does not obey theme CSS

Home Assistant release with the issue:

0.100.0
Last working Home Assistant release (if known):
Operating environment (Hass.io/Docker/Windows/etc.):

hassio
Integration:

Description of problem:
When I go to "Configuration"->"Devices" the page doesnt obey the theme css.

Problem-relevant configuration.yaml entries and (fill out even if it seems unimportant):

Traceback (if applicable):

Additional information:

https://github.com/home-assistant/home-assistant/issues/26735 This is an issue with your theme

Duplicate of https://github.com/home-assistant/home-assistant-polymer/issues/3772


Pre go-live cleanup of ff docs

Harness Developer Pull Request
Thanks for helping us make the Developer Hub better. The PR will be looked at
by the maintainers.
What Type of PR is This?

[ ] Issue
[ ] Feature
[x] Maintenance/Chore

If tied to an Issue, list the Issue(s) here:

Cleaned up some issues on FF docs and updated version numbers of some SDKs

House Keeping
Some items to keep track of. Screen shots of changes are optional but would help the maintainers review quicker.

[x] Tested Locally
[ ] Optional Screen Shoot.

Preview environment: https://ci.pr.harness.io/pr-215

Preview environment: https://ci.pr.harness.io/pr-215

Preview environment: https://ci.pr.harness.io/pr-215

Preview environment: https://ci.pr.harness.io/pr-215

Changes made as per Kim's review. Merging branch.


createAssociatedTokenAccountIdempotentInstruction shouldn't require client to pass in associatedToken

The handy createAssociatedTokenAccountIdempotentInstruction allows you create instructions that idempotently create associated token accounts. One thing that annoys me about it is that it requires me to pass in the associated token account, like so:
...
.preInstructions([
        createAssociatedTokenAccountIdempotentInstruction(
          this.provider.publicKey,
          token.getAssociatedTokenAddressSync(
            tokenMint,
            pdaOwner,
            true
          ),
          pdaOwner,
          tokenMint
)]
...

I don't see the purpose of this given that associated token accounts can always be derived by the getAssociatedTokenAddressSync. Maybe this function was written before getAssociatedTokenAddressSync existed? In any case, it would be nice if this parameter was made optional or removed entirely.

The instruction creators like this are meant to be totally customizable, just like createAssociatedTokenAccountInstruction -- if you want to add a helper, PRs are always welcome!

What does customizable mean here? An associated token account pubkey is the result of applying getAssociatedTokenAddressSync to mint and owner, so what's the point of having both mint/owner and associatedToken? I'm trying to understand what use-case this unlocks

"customizable" just means you can set every possible account in the instruction, even if it's incorrect. If you're particularly performance-sensitive, then this creator allows you to incur the cost of deriving the associated token account address just once rather than being forced to do it multiple times.
But either way, we can definitely add a helper!


bulk: update Free Tier docs for Bulk I/O

BACKUP, RESTORE, IMPORT and Core Changefeeds should now be mentioned as available in Free Tier
(Note: this is contingent on free tier clusters being upgraded to 21.1)
(Note: EXPORT is NOT supported and therefore is specifically not mentioned here. We chose not to implement because running cockroach sql "query" > file.csv is a more direct way to export your data)
The major caveats are:

You can only use userfile as file storage for BACKUP, RESTORE and IMPORT -- you cannot use http, s3, etc. (This does not apply to Core Changefeeds because that writes to the SQL connection rather than file storage)
We should note that userfile takes up space and that you should ensure you have enough space to both load the file and take whatever action you want to take. We could say 1GB as a safe limit maybe for first IMPORT?
We probably want to note that even if you cockroach userfile delete 'file' that it takes gc.ttl to be removed from disk. Right now that's 25h but we're having conversations to lower that.
We can also suggest database and/or table level backups because cluster level backups would take backups of the userfile stuff too (since it's technically table data).
(NOTE: I actually think that you cannot do cluster restore, because you have to first load data into userfile first. Ugh. It's not a great experience because it doesn't fail saying you can't, it'll fail with another error. So we probably should explicitly say that you can't on Free Tier, and maybe in a troubleshooting section explain the error as well)

@mwang1026 I'd like to clarify some things here regarding the doc work, specifically regarding userfile as a BACKUP/RESTORE destination.
We don't currently document userfile URLs as a valid target for BACKUP/RESTORE operations in CRDB:
https://www.cockroachlabs.com/docs/v21.1/backup#backup-file-urls
https://www.cockroachlabs.com/docs/v21.1/restore#backup-file-urls
The userfile topic appears to be distinct from cloud and local file destinations, and only references IMPORT:
https://www.cockroachlabs.com/docs/v21.1/use-userfile-for-bulk-operations.html
Is this a hole in the CRDB docs? If so, it sounds like @kathancox should first update the CRDB docs with this information so we can consume it in the Cloud documentation for the Serverless MVP launch.

The same situation applies to changefeeds. We don't document how they work with userfile URLs.
https://www.cockroachlabs.com/docs/v21.1/create-changefeed.html

OK. We can document them, with the caveat that it is not recommended for production usage outside of free tier.
I'd also argue that we don't have examples of how it works, but it is "just another file storage" option. But I agree for completeness it's worth having an end-to-end example somewhere of how you

upload your backup to userfile from local
then run restore off of it
then delete that file from userfile once you're done with it

When speaking with Kathryn it was unclear whether that lives in CRDB or in CC. I didn't have a particular preference


Redirect 301 from /landing-pages/{collectionsPageId} to /collections

Sending the google juice to /collections.
I'm not sure if doing this with Koa is the right way, but it works.

We're doing this with edge lambdas for similar situations
https://github.com/wellcomecollection/wellcomecollection.org/blob/master/cache/edge_lambdas/redirects.js


Add PathVar map, emap

Follow up from https://github.com/http4s/http4s/issues/2405
The motivation is that, as a user, in order to use make your own PathVar you have to make your own full extractor (e.g. LocalDateVar in https://http4s.org/v0.23/docs/dsl.html#handling-path-parameters) or make your own org.http4s.dsl.impl package so that you can access PathVar and its constructor.
I implemented map and emap in PathVar, and added  StringVar which can be used as a starting point for creating custom PathVars. @diesalbla suggested a  "super-trait PathMatch[A]" but I did not understand what the purpose would be, I'll happily make the adjustment.
As it is this would encourage user-defined PathVars to be vals and not objects, which becomes inconsistent with QueryParams for example. If this is a problem (I really have no opinion) then something like
abstract class CustomPathVar[A](cast: String => Option[A]) extends PathVar(...) would still be flexible enough, though less compositional.
I don't know if any of this is MiMa-approved (I ran mimaFindBinaryIssues, does that do anything?).

I ran mimaFindBinaryIssues

Not sure what that one does. CI runs mimaReportBinaryIssues.

MiMa no longer complains, and yet this feels less useful now :smiling_face_with_tear:. Before making this PR I didn't know you could just make an extractor (my fault, hadn't read the doc) so this seemed like a great idea. I'll leave it up to reviewers to decide if it's worth it.


Support for sklearn Pipelines

MCA is currently not able to be part of a sklearn Pipeline containing any preceding steps.
In my case I need an Imputer to fill any NaN values.
Working Example:
from sklearn.impute import SimpleImputer
from prince.mca import MCA

test_data = pd.DataFrame(data=np.random.random((10, 5)))
test = Pipeline(steps=[
    ("mca", MCA()),
])
test.fit_transform(test_data)

But including a SimpleImputer results in a numpy array that is being forwarded to the MCA:
from sklearn.impute import SimpleImputer
from prince.mca import MCA

test_data = pd.DataFrame(data=np.random.random((10, 5)))
test = Pipeline(steps=[
    ("impute", SimpleImputer()), # This Breaks the Pipeline since it returns an ndarray
    ("mca", MCA()),
])
test.fit_transform(test_data)

I've tried including a dummy transformer step betwen the imputer and MCA that forwards an arbitrary DataFrame with generic index and column labels, but it results in a KeyError with unknown Index labels being searched in the column list:
KeyError: "None of [Index(['Col_0_0.0', 'Col_0_1.0', 'Col_0_2.0', 'Col_0_3.0', 'Col_0_4.0',\n       'Col_0_5.0', 'Col_1_0.0', 'Col_1_1.0', 'Col_1_2.0', 'Col_2_0.0',\n       'Col_2_1.0', 'Col_3_0.0', 'Col_3_1.0'],\n      dtype='object')] are in the [columns]"

Any suggestions?

Hey there @MyNameIsFu!
I believe you can make this work using sklearn's set_output API:
from sklearn.impute import SimpleImputer
from sklearn.pipeline import Pipeline
from prince.mca import MCA
import numpy as np

test_data = pd.DataFrame(data=np.random.random((10, 5)))
test = Pipeline(steps=[
    ("impute", SimpleImputer()), # This Breaks the Pipeline since it returns an ndarray
    ("mca", MCA()),
])
test[0].set_output(transform="pandas")
test.fit_transform(test_data)

I hope this works for you!

I added a note to the FAQ on the documentation website. I'll close this :)