cmd/go: install pkg@version: print deprecation messages

What version of Go are you using (go version)?

$ go version
go version devel go1.21-2ef70d9d0f9 Tue Mar 21 06:53:28 2023 +0000 linux/amd64

Does this issue reproduce with the latest release?
yes
What operating system and processor architecture are you using (go env)?
go env Output
$ go env
GO111MODULE=""
GOARCH="amd64"
GOBIN=""
GOCACHE="/home/arccy/.cache/go-build"
GOENV="/home/arccy/.config/go/env"
GOEXE=""
GOEXPERIMENT=""
GOFLAGS="-trimpath "-ldflags=-s -w""
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GOINSECURE=""
GOMODCACHE="/home/arccy/.data/go/pkg/mod"
GONOPROXY=""
GONOSUMDB=""
GOOS="linux"
GOPATH="/home/arccy/.data/go"
GOPRIVATE=""
GOPROXY="https://proxy.golang.org,direct"
GOROOT="/home/arccy/sdk/gotip"
GOSUMDB="sum.golang.org"
GOTMPDIR=""
GOTOOLDIR="/home/arccy/sdk/gotip/pkg/tool/linux_amd64"
GOVCS=""
GOVERSION="devel go1.21-2ef70d9d0f9 Tue Mar 21 06:53:28 2023 +0000"
GCCGO="gccgo"
GOAMD64="v3"
AR="ar"
CC="gcc"
CXX="g++"
CGO_ENABLED="0"
GOMOD="/home/arccy/tmp/testrepo0151/go.mod"
GOWORK=""
CGO_CFLAGS="-O2 -g"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-O2 -g"
CGO_FFLAGS="-O2 -g"
CGO_LDFLAGS="-O2 -g"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -Wl,--no-gc-sections -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build287293194=/tmp/go-build -gno-record-gcc-switches"

What did you do?
$ go install go.seankhliao.com/testrepo0150@latest
go: downloading go.seankhliao.com/testrepo0150 v0.0.0-20230324184925-aa9dc37d2fb8

What did you expect to see?
deprecation message printed like with go get
$ go get go.seankhliao.com/testrepo0150@latest
go: module go.seankhliao.com/testrepo0150 is deprecated: use v2
go: added go.seankhliao.com/testrepo0150 v0.0.0-20230324184925-aa9dc37d2fb8

What did you see instead?
no deprecation message
cc @bcmills @matloob

For reference, the code in go get that prints these messages is here:
https://cs.opensource.google/go/go/+/master:src/cmd/go/internal/modget/get.go;l=1604-1629;drc=2f2c5e41e7728cae99abd14e8bd5ffcfebf9df8e
And the code in go install that implements go install pkg@version is here:
https://cs.opensource.google/go/go/+/master:src/cmd/go/internal/work/build.go;l=843-874;drc=0aa14fca8c639c9ceba264dbf0d82bd53306aeaa

perhaps adding CheckDeprecation right after this line will fix this?

Should go run also print deprecations and retractions?

deprecations: the proposed change should affect go install or go run when it uses pkg@version, but not when only pkg is supplied.

retractions: I believe it is already handled here


Crashes when replaced with Quilt Loader 0.18.1-beta.64

crash-2023-01-30_01.14.27-client.txt
crash-2023-01-30_01.12.18-client.txt

This is also causing crashes with Iris:
2023-01-29-3.log

Thanks for the reports! This should be fixed in beta 65.


Chainlink's latestRoundData might return stale results

Affected Smart contracts
PriceOracleProxyETH.sol
Severity:
Medium
Description:
https://github.com/LodestarFinance/lodestar-protocol/blob/cfca1ae275d023a02198798bbcb24b2a1f646776/contracts/Oracle/PriceOracleProxyETH.sol#L134-L135
here lodestar using Chainlink's latestRoundData API, but there is no check if the return value indicates stale data. This could lead to stale prices according to the Chainlink documentation:

https://docs.chain.link/docs/historical-price-data/#historical-rounds

Recommendation:
add checks for stale data
(uint80 roundId, int256 price, uint256 timestamp, uint256 answeredInRound, ) = aggregator.latestRoundData();
 require(price > 0, 'invalid price');
require(answeredInRound >= roundId, 'stale price');
require(timestamp != 0, 'round not complete');

Don't specified Attack scenario

@rotcivegaf  it's crucial to remember that not every issue can be framed as an attack scenario, and our ultimate goal should be to improve the overall security and functionality of the smart contract in question.
In this particular scenario, it is a critical problem that must be addressed by the developers to ensure the accuracy and reliability of the smart contract.
let the committee decide.


🐞[Bug]:When Language selected the UI of page is improper

Is there an existing issue for this?

[X] I have searched the existing issues

Describe the bug
Hey @sk66641  ,
After selecting the language the UI page is not proper as it was in english. The font size getting increased. I would like to solve this under GSSOC'

24
Expected behavior
The UI of page after selecting the text would be similar as it was in english.
Add ScreenShots
No response
What browsers are you seeing the problem on?
No response
Record

[X] I have read the Contributing Guidelines
[X] I'm a GSSOC'24 contributor
[X] I want to work on this issue

Similar to #375


Is it possible to change the "text to voice" language?

I just found out that I can change the "recognized words" by editing words.txt, which is perfect since I can adjust them to my individual needs!
The logical next step would be to add words in my (and my childs 😉) native language German. In order for this to make sense, I'd also like to hear those recognized words pronounced correctly by a "German voice".
Is it possible to change the voice to a German one by adjusting some file or windows system setting?

The app seams to use System.Speech so it should be possible
I have not tried it myself but found some information earlier when researching the issue, maybe the following can help? https://stackoverflow.com/questions/29163994/adding-a-new-language-to-speechsynthesizer

I managed to change the language by adjusting the code & making a custom build of mine:
Controller.cs:ThreadedSpeak constructor
// Original
CultureInfo keyboardLanguage = System.Windows.Forms.InputLanguage.CurrentInputLanguage.Culture;
InstalledVoice neededVoice = this.SpeechSynth.GetInstalledVoices(keyboardLanguage).FirstOrDefault();

// Force german voice
CultureInfo culture = CultureInfo.GetCultureInfo("de-DE");
InstalledVoice neededVoice = this.SpeechSynth.GetInstalledVoices(culture).FirstOrDefault();

I guess there's no way right now to change this via some some config file etc. but only by either creating a custom build like I did or by changing the default input language which I wanted to avoid for several reasons.

Figured out that changing the text-to-speech language is rather easy: Use the Windows language preference selector (keyboard/language). Changing that from English to German also changed the text-to-speech voice for me.

I managed to change the language by adjusting the code & making a custom build of mine:
Controller.cs:ThreadedSpeak constructor
// Original
CultureInfo keyboardLanguage = System.Windows.Forms.InputLanguage.CurrentInputLanguage.Culture;
InstalledVoice neededVoice = this.SpeechSynth.GetInstalledVoices(keyboardLanguage).FirstOrDefault();

// Force german voice
CultureInfo culture = CultureInfo.GetCultureInfo("de-DE");
InstalledVoice neededVoice = this.SpeechSynth.GetInstalledVoices(culture).FirstOrDefault();

I guess there's no way right now to change this via some some config file etc. but only by either creating a custom build like I did or by changing the default input language which I wanted to avoid for several reasons.

I was trying to compile (with the commands Dotnet and msbuild) for portuguese (pt-pt) following @CombeeMike solution but I have a lot of errors (libraries that were installed but are not found like .NetFramework and NewtonSoft, etc.) and cannot do it - I'm googling every error but when I think I found a solution for an error another one follows. I am using Visual Studio Code last version to compile. I am a COMPLETE newbie, as you already knew!

Are those errors are to be expected (or what am I doing wrong)?
I work with Special Needs Students. I use BabySmash since the beggining as an example of some cool things for teachers I work with but I don't use it with the kids because of the English language. With the Portuguese localization (that I tried before) I could use Baby Smash with the kids.
Thank you.

@ruiefe I just now got my own fork of BabySmash updated to latest dependencies and added a couple tiny improvements.  So I tried this out.
BabySmash builds best via Visual Studio editions other than VSCode; Visual Studio 2019 is also free and gets past the dependency problems that dotnet build BabySmash.sln command line seems to have problems with by default, even when trying to specify with --packages /packages/.  (Back when BabySmash was first built, VSCode wasn't really an option yet, and I don't think anyone had tried out command-line building of it yet back while this project was maintained more.)
Although VS 2019 resolves the NuGet package find, if you want to build from the shanselman/babysmash base fork, you will also likely have one more build issue to work though: Signing.  The fastest/easiest way is to turn off signing for now:

In the Solution Explorer pane, there will be a [C#] BabySmash project (probably in bold) to right-click on.
Select "Properties".
Select the "Signing" tab on the left.
Uncheck the "Sign the ClickOnce manifests".
Try building.

Figured out that changing the text-to-speech language is rather easy: Use the Windows language preference selector (keyboard/language). Changing that from English to German also changed the text-to-speech voice for me.

This works pretty well, thanks for the hint; basically in the comment before we can see that it depends on the active keyboard layout. 😉
Did something similar for Portuguese support but I believe for most locales it's necessary to manually install the TTS language (Helia for pt-PT), for which I followed:

The recipe at How to install more voices to Windows Speech?
Did prioritizing using the Control Panel applet (referred out of the main solution) at: %windir%\sysWOW64\speech\SpeechUX\SAPI.cpl

That will cause letters and words.txt to be in the desired language; for the remaining expressions (shapes and colors, used in meta and special keys), it's currently only available in English and Russian. Should be pretty simple to translate (and contribute). 😊

Should be pretty simple to translate (and contribute). 😊

PR available in #37. Mind related glitch found there, to be fixed at a later stage. And please help answering the question, if you know of any exception. 😉


Update to 1.12.2 (No obfuscation changes)

Tested and working. Cant figure out how to PR into a new branch, please make 1.12.2 branch.

Thanks for your PR! I already had that ready though and just had to do some more testing.


Set _currentWeek in _onPageChange

Setting the state in a widget higher up the hierarchy from WeekView which will cause _regulateCurrentDate to execute and set the start date from the last-set _currentWeek, which is only changed if the week goes out of bounds, not when the page changes.

Hello @Cellaryllis Please create this pull request on develop branch. Refer CONTRIBUTING.md for more info


Check maxTokenizationLineLength in monarchLexer

This PR fixes https://github.com/microsoft/monaco-editor/issues/3025
The issue is described in the issue linked above, but basically when monaco-editor was parsing and tokenizing lines, it was using monarch tokenizer instead of TextMate tokenizer which was already checking the maxTokenizationLineLength option. So I added the maxTokenizationLineLength check in monarch tokenizer as well.

Sorry for the delay, I've finally been signed off by my employer @alexdima

Could I get reviews? This bug is freezing up the UIs and there's no workaround other than fixing it in the source.

@alexdima My bad, I messed up the rebase bu it should be fixed now. I ran the tests locally and they all passed.

This PR is ready for review @alexdima

Hi @hediet you seem to be assigned to the original bug report issue. Could you run the CI? This bug is making the UI unresponsive for 5+ seconds sometimes.

@alexdima @hediet could I please get a review?

It seems like the Hygiene and Layering job is stuck

Looks like the recently added Code OSS check is failing on all the PRs made in the past 3 days.

@alexdima hello could you run the CI?

Thank you!


MSI login using Docker stack

I am trying to get cli to log in via MSI on docker stack. The problem is that docker stack doesn't appear to allow access to <IP_ADDRESS> (it doesn't support host networking)
To get around this, I have obtained the token and written it to file, with the hope of being able to use it to log into az login, in the same way that can be done for Powershell.
Is there a way to use the token from MSI to log in to cli?
This is using the azuresdk/azure-cli-python image.

@theMichaelB I'm unsure if MSI is supported on Docker stack machines - it may only be directly supported on Azure VM. However, we have documentation on using the CLI to perform MSI login:
https://docs.microsoft.com/en-us/azure/active-directory/msi-qs-configure-cli-windows-vm?toc=%2Fcli%2Fazure%2Ftoc.json&bc=%2Fcli%2Fazure%2Fbreadcrumb%2Ftoc.json&view=azure-cli-latest
https://docs.microsoft.com/en-us/azure/active-directory/msi-how-to-get-access-token-using-msi?toc=%2Fcli%2Fazure%2Ftoc.json&bc=%2Fcli%2Fazure%2Fbreadcrumb%2Ftoc.json&view=azure-cli-latest

using the command line sudo docker run --net=host -it azuresdk/azure-cli-python it works as expected as this maps the container to localhost - however when running under Docker stack, it is not possible - or at least I've not yet found out how - to map through to localhost
Obviously, it is possible to pass the token into the container (via the filesystem) but CLI would need to support logging in with just a token to make it work. (a function that PS has)

Propagating the token cache by mounting the ~/.azure/ directory into your docker container should mean that the CLI instance has access to those tokens and is authenticated. However, you'd have to keep a daemon running on your host machine to keep hitting the MSI endpoint to keep the token cache up-to-date. To me this all feels very hacky.
I'd recommend just using Service Principals to authenticate your agents in Docker containers independently and not relying on parlaying the host's MSI tokens through. I'm going to close this issue out, but feel free to keep this conversation going if you really believe this is an important scenario. I'll be happy to re-open if there's lots of interest.

Hi @marst,
I think it would be usefull to be able to authenticate using MSI with docker.
Currently we have built an azure function that connects to AML to get some metadata from our models to postprocess some predictions done by an AML scoring pipeline.
When using MSI in the azure function everything works as we have configured the managed identity properly. And when we run the python code locally in our azure ml VM this also works as we get the workspace config from.
However when testing the docker file that we mount in azure function locally we get the following error:
azureml._vendor.azure_cli_core.azclierror.AzureResponseError: AzureResponseError:
        Message: Failed to connect to MSI. Please make sure MSI is configured correctly.
Get Token request returned http error: 400, reason: Bad Request
        InnerException None
        ErrorResponse
{
    "error": {
        "message": "Failed to connect to MSI. Please make sure MSI is configured correctly.\nGet Token request returned http error: 400, reason: Bad Request"
    }
}
The terminal process "/bin/bash '-c', 'docker run --rm -it  postprocessor:latest'" terminated with exit code: 1.

Terminal will be reused by tasks, press any key to close it.

Suggestions are welcome!


Add connect plugin. Update React-Router example.

This PR adds a Provider and Connect addon similar to the react-redux project. Additionally, it updates the ReactRouter example to utilize these addons.
Connect will listen to app and prop changes to calculate new state. This state is injected into a child component as props. By default, this is pure. For projects that mutate data (please don't do this), you can pass an optional { pure: false } to Connect.
This is inspired heavily by a combination of the NuclearJS and Redux implementations of this concept:

https://github.com/jordangarcia/nuclear-js-react-addons/blob/master/src/connect.js
https://github.com/rackt/react-redux/blob/master/src/components/connect.js

Basic usage:
const Presenter = Connect(function (props) {
  let { id } = props.params

  return {
    list  : Lists.get(id),
    items : Items.childrenOf(id)
  }
})

const ListPage = Presenter(React.createClass({
    /// this component will have app, list, and items props
})

ReactDOM.render(<Provider app={ app }><ListPage /></Provider>)

Further, this means that the application instance does not need to be continually passed down to child components. The React context API bridges the gap for us. Connected components can accept an app property if not relying on context. This should make it easy to patch in an application when testing.

:+1: nice job

:+1: that was fast!


TS-4472 Fixes http_current_active_client_connections_stat metric

The issue here is that there are two m_active member variables, in
both Http1ClientSession and Http1ClientTransaction. However, the former
contains the latter, so this patch eliminates the m_active from the
session class, and then consistently sets and checks the m_active from
the http1ClientTransaction class.

FreeBSD build successful! See https://ci.trafficserver.apache.org/job/Github-FreeBSD/415/ for details.

Looks good to me

Linux build successful! See https://ci.trafficserver.apache.org/job/Github-Linux/309/ for details.

Looks good


Missing quotes

What happens?
Upon passing a dataset do the Spark linker we get:
pyspark.sql.utils.ParseException:
mismatched input '00' expecting {'ADD....

etc.
Looking at https://github.com/moj-analytical-services/splink/blob/99f321b26966fe0798628723dd9e2fa90d75b316/splink/spark/linker.py#L239 (thanks @patrikkj) it seems you can get situations here that is interpreted wrongly unless maybe {self.splink_data_store} is quoted. There are also other instances of the same usage without the quotes.
To Reproduce
Passing self.splink_data_store a value of 00-00-00-00-00 yields this error. The value obviously depends on the database and catalog. In our case, this is what we have to work with. Same dataset works fine with the DuckDB linker.
OS:
Linux
Splink version:
3.9.2
Have you tried this on the latest master branch?

[X] I agree

Have you tried the steps to reproduce? Do they include all relevant data and configuration? Does the issue you report still appear there?

[X] I agree

Thanks for the report! I've added what should be the fix in here - https://github.com/moj-analytical-services/splink/pull/1558.
The entire team (other than I) are off this week, so I'm not sure when this will get merged.
For the time being (and assuming you're able to on your machines), you can install the dev build from that branch using:
pip install git+https://github.com/moj-analytical-services/splink.git@1f8d4851956e40134a0e036e4f02a6d1b275a7ac

Thanks a lot @ThomasHepworth. Greatly appreciated.


Unknown word - CssSyntaxError on comment

I just installed the stylelint for styled-component and run it.
I checked the documentation to see what's wrong with my code but can't figure it out.
This is the code I have in my project :
package.json
    "lint:css": "stylelint app/**/*.js",

...
    "stylelint": "^7.9.0",
    "stylelint-config-standard": "^16.0.0",
    "stylelint-processor-styled-components": "0.0.4",

.stylelintrc
{
  "processors": ["stylelint-processor-styled-components"],
  "extends": "stylelint-config-standard",
  "syntax": "scss",
  "rules": {
      "color-hex-case": "lower",
      "color-hex-length": "short",
      "color-no-invalid-hex": true
  }
}

style.js
import { css } from 'styled-components';

/* STYLEGUIDE v.0.1 */ <= The error is coming from this line

/* FONT-SIZE */

const fontSize = {
  default: '1.2rem',
  medium: '1.4rem',
  big: '2rem',
  bigger: '2.4rem',
};

/* COLORS */

/* Internal color variable */

webpack
{
      test: /\.css$/,
      include: /node_modules/,
      loaders: ['style-loader', 'css-loader'],
}

The comment looks like the one from the Stylelint documentation. Is it coming from this Github repo or from Styleling himself? Did you had this issue before?
Thanks a lot!

The actual error

Hi everyone,
I have just left this comment in #4 that exposes at least one pattern that causes this issue.

Any progress on this?

I'll assume this is no longer an issue since #4 has been closed with the release of 0.1.0.
If not please let me know and I'll reopen. In that case please submit a PR with a failing testcase demonstrating the problem. Otherwise we'll take care of it as well but it might take a bit longer.


Error when installing ManimPango via pip on windows

Recently I'm attempting to refactor Text class in manimgl, and the job requires me to clone into ManimPango and rewrite it to fit the new structure for Text. I had a problem when installing ManimPango via pip on my Windows. I followed instructions in README, and an error popped out while running pip install -e ., which is listed as follows:
Obtaining file:///E://ManimKindergarten/ManimPango
  Installing build dependencies ... done
  Getting requirements to build wheel ... error
  ERROR: Command errored out with exit status 1:
   command: D:/msys64/mingw64/bin/python.exe D:/msys64/mingw64/lib/python3.9/site-packages/pip/_vendor/pep517/in_process/_in_process.py get_requires_for_build_wheel C:/Users/Michael/AppData/Local/Temp/tmprw4q63fg
       cwd: E:/ManimKindergarten/ManimPango
  Complete output (31 lines):
  Failed to open 'D:/msys64/mingw64/lib/pkgconfig\freetype2.pc': Too many open files
  Package 'freetype2', required by 'harfbuzz', not found
  Traceback (most recent call last):
    File "setup.py", line 130, in check_min_version
      check_call(command, stdout=subprocess.DEVNULL)
    File "D:/msys64/mingw64/lib/python3.9/subprocess.py", line 373, in check_call
      raise CalledProcessError(retcode, cmd)
  subprocess.CalledProcessError: Command '['pkg-config', '--print-errors', '--atleast-version', '1.30.0', 'pangocairo']' returned non-zero exit status 1.

  During handling of the above exception, another exception occurred:

  Traceback (most recent call last):
    File "D:\msys64\mingw64\lib\python3.9\site-packages\pip\_vendor\pep517\in_process\_in_process.py", line 280, in <module>
      main()
    File "D:\msys64\mingw64\lib\python3.9\site-packages\pip\_vendor\pep517\in_process\_in_process.py", line 263, in main
      json_out['return_val'] = hook(**hook_input['kwargs'])
    File "D:\msys64\mingw64\lib\python3.9\site-packages\pip\_vendor\pep517\in_process\_in_process.py", line 114, in get_requires_for_build_wheel
      return hook(config_settings)
    File "C:/Users/Michael/AppData/Local/Temp/pip-build-env-yphr7s_4/overlay/lib/python3.9/site-packages/setuptools/build_meta.py", line 177, in get_requires_for_build_wheel
      return self._get_build_requires(
    File "C:/Users/Michael/AppData/Local/Temp/pip-build-env-yphr7s_4/overlay/lib/python3.9/site-packages/setuptools/build_meta.py", line 159, in _get_build_requires
      self.run_setup()
    File "C:/Users/Michael/AppData/Local/Temp/pip-build-env-yphr7s_4/overlay/lib/python3.9/site-packages/setuptools/build_meta.py", line 281, in run_setup
      super(_BuildMetaLegacyBackend,
    File "C:/Users/Michael/AppData/Local/Temp/pip-build-env-yphr7s_4/overlay/lib/python3.9/site-packages/setuptools/build_meta.py", line 174, in run_setup
      exec(compile(code, __file__, 'exec'), locals())
    File "setup.py", line 197, in <module>
      _pkg_config_pangocairo.check_min_version(MINIMUM_PANGO_VERSION)
    File "setup.py", line 133, in check_min_version
      raise RequiredDependencyException(f"{self.name} >= {version} is required")
  __main__.RequiredDependencyException: pangocairo >= 1.30.0 is required

I saw another similar issue #53, but it seems that it's already fixed. So it seems wierd to me. And, installing manimgl via pip install -e . which relies on this dependency doesn't cause any problem. I've checked that MSYS2 MINGW64 shell was used to execute commands.
Any help will be appreciated :D

Hey @YishiMichael! More of a general comment than a concrete solution for your issue here:
@naveen521kk also has put some thought into refactoring Text, not sure what the current status is but you can find a sketch of the plans at https://github.com/ManimCommunity/manim/issues/2355. To avoid further fragmentation between Grant's personal version of Manim and the community version, we should try to stick to the same version of ManimPango, meaning that all changes to the interface should also be ported to ManimCommunity/manim. We'd certainly love to have you as a contributor! :-) (And even if you prefer to stick to 3b1b/manim, I'm sure we will find a suitable way for collaborating.)

@behackl Yeah I'd like to contribute to ManimCE as well!
I've read #2355 and was pleased to see the new implementation design. I'm looking forward to collaborating with manim community, started with Text class.

Thanks for the contribution. As @behackl mentioned it would be great if the changes you do on Grant's version related to ManimPango/Text API be ported to ManimCommunity/manim.
Also, I have been planning to refactor the Text API https://github.com/ManimCommunity/manim/issues/2355 and also have thoughts to provide a stable API here https://github.com/ManimCommunity/ManimPango/issues/28; suggestions about them welcome. I have been waiting for the refactor period (which we announced a while ago) to be done, but it seems like we won't have anything like it anytime soon; which means I would start working on it anytime soon (probably after the exams which will end by march).

Failed to open 'D:/msys64/mingw64/lib/pkgconfig\freetype2.pc': Too many open files
Package 'freetype2', required by 'harfbuzz', not found

This is the error from pkg-config, which seems like just restarting your computer and re-running the install should fix it.

It doesn't work... But thanks for replying. I may try other means.

It doesn't work... But thanks for replying. I may try other means.

Maybe try running pacman -Qkq in that shell to check whether all the files are installed correctly? Also, try running pkg-config --libs --cflags pangocairo manually on that shell to see if it errors out in that case?

It goes into error when I run pkg-config --libs --cflags pangocairo. The message is
$ pkg-config --libs --cflags pangocairo
Failed to open 'D:/msys64/mingw64/lib/pkgconfig\freetype2.pc': Too many open files
Package 'freetype2', required by 'harfbuzz', not found

Does the pacman command suceed? Also, does a file called D:/msys64/mingw64/lib/pkgconfig\freetype2.pc exists?

Also, what does pkg-config --version and which pkg-config commands print?

The file D:/msys64/mingw64/lib/pkgconfig/freetype2.pc exists. And here's the output:
$ pacman -Qkq
mingw-w64-x86_64-make /mingw64/bin/mingw32-make.exe

$ pkg-config --version
0.23

$ which pkg-config
/mingw64/bin/pkg-config

The file D:/msys64/mingw64/lib/pkgconfig/freetype2.pc exists. And here's the output:
$ pacman -Qkq
mingw-w64-x86_64-make /mingw64/bin/mingw32-make.exe

$ pkg-config --version
0.23

$ which pkg-config
/mingw64/bin/pkg-config

Hmm, I'm wondering why pkg-config is used instead of pkgconf, I remember they replaced pkgconf by default. Did you ever update the packages there ie run (pacman -Syu)? If yes, can you run pacman -S mingw-w64-x86_64-pkgconf and then press yes for all questions asked from Pacman. If not, please update first using pacman -Syu, it should ask about replacement and just input yes there.

I've run the commands provided, i.e.
$ pacman -Syu
$ pacman -S mingw-w64-x86_64-pkgconf

I've also restarted my computer.
They worked --- the error changed :(
Listed here:
$ pip install -e .
Obtaining file:///E://ManimKindergarten/ManimPango
  Installing build dependencies ... done
  Checking if build backend supports build_editable ... done
  Getting requirements to build wheel ... done
  Preparing metadata (pyproject.toml) ... done
Installing collected packages: ManimPango
  Attempting uninstall: ManimPango
    Found existing installation: ManimPango 0.4.0.post2
    Can't uninstall 'ManimPango'. No files were found to uninstall.
  Running setup.py develop for ManimPango
    ERROR: Command errored out with exit status 1:
     command: D:/msys64/mingw64/bin/python.exe -c 'import io, os, sys, setuptools, tokenize; sys.argv[0] = '"'"'E:/ManimKindergarten/ManimPango/setup.py'"'"'; __file__='"'"'E:/ManimKindergarten/ManimPango/setup.py'"'"';f = getattr(tokenize, '"'"'open'"'"', open)(__file__) if os.path.exists(__file__) else io.StringIO('"'"'from setuptools import setup; setup()'"'"');code = f.read().replace('"'"'\r\n'"'"', '"'"'\n'"'"');f.close();exec(compile(code, __file__, '"'"'exec'"'"'))' develop --no-deps
         cwd: E:/ManimKindergarten/ManimPango/
    Complete output (17 lines):
    running develop
    C:/Users/Michael/AppData/Local/Temp/pip-build-env-clt6hnp4/overlay/lib/python3.9/site-packages/setuptools/command/easy_install.py:160: EasyInstallDeprecationWarning: easy_install command is deprecated. Use build and pip and other standards-based tools.
      warnings.warn(
    C:/Users/Michael/AppData/Local/Temp/pip-build-env-clt6hnp4/overlay/lib/python3.9/site-packages/setuptools/command/install.py:34: SetuptoolsDeprecationWarning: setup.py install is deprecated. Use build and pip and other standards-based tools.
      warnings.warn(
    running egg_info
    writing ManimPango.egg-info/PKG-INFO
    writing dependency_links to ManimPango.egg-info/dependency_links.txt
    writing top-level names to ManimPango.egg-info/top_level.txt
    reading manifest file 'ManimPango.egg-info/SOURCES.txt'
    reading manifest template 'MANIFEST.in'
    no previously-included directories found matching 'docs/_build'
    adding license file 'LICENSE'
    writing manifest file 'ManimPango.egg-info/SOURCES.txt'
    running build_ext
    building 'manimpango.cmanimpango' extension
    error: --plat-name must be one of ('win32', 'win-amd64', 'win-arm32', 'win-arm64')
    ----------------------------------------
  ERROR: Can't roll back ManimPango; was not uninstalled
ERROR: Command errored out with exit status 1: D:/msys64/mingw64/bin/python.exe -c 'import io, os, sys, setuptools, tokenize; sys.argv[0] = '"'"'E:/ManimKindergarten/ManimPango/setup.py'"'"'; __file__='"'"'E:/ManimKindergarten/ManimPango/setup.py'"'"';f = getattr(tokenize, '"'"'open'"'"', open)(__file__) if os.path.exists(__file__) else io.StringIO('"'"'from setuptools import setup; setup()'"'"');code = f.read().replace('"'"'\r\n'"'"', '"'"'\n'"'"');f.close();exec(compile(code, __file__, '"'"'exec'"'"'))' develop --no-deps Check the logs for full command output.

Now the problem is https://www.msys2.org/news/#2021-12-21-potential-incompatibilities-with-newer-python-setuptools I should've updated the README file about it. Simply, running export SETUPTOOLS_USE_DISTUTILS=stdlib before the pip command should work.

Many thanks for your patience!! It's finally installed successfully.


Replicate AWS DSD route53 so we can delegate tribunals.gov.uk to Mode…

Replicate AWS DSD route53 so we can delegate tribunals.gov.uk hosted zone records to new instance in Modernisation Platform core-network-services

close and reopen


BIGTOP-3825: remove debug messages on Solr build script

Description of PR
How was this patch tested?
For code changes:

[ ] Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'BIGTOP-3638. Your PR title ...')?
[ ] Make sure that newly added files do not have any licensing issues. When in doubt refer to https://www.apache.org/licenses/

Oh sorry, my comment may have been misleading. I meant L155 and L157 is unnecessary, but I'm not sure if we could remove L156 without any problem. Can we remove it @kevinw66?

Oh sorry, my comment may have been misleading. I meant L155 and L157 is unnecessary, but I'm not sure if we could remove L156 without any problem. Can we remove it @kevinw66?

Yes, that's debug code which I'm trying to view the files under conf dir

+1, sorry for my late response.

Merged into master. Thanks @kevinw66!


Hack to use hostname -s as a node name

Evaluating at:
https://github.com/GoogleCloudPlatform/hpc-toolkit/pull/2641/checks


NullReferenceException when executing c# benchmarking tool w/ checkpoints

When executing C# benchmarking tool with the following configurations:
reads_percent = -1 (i.e. 100% RMW)
kCheckpointMilliseconds= 10000
kRunSeconds = 60 seconds
kUseSmallData = true/false
kUseSyntheticData = true
kCheckpointStoreContents = true
kAffinitizedSession = true/false
kSmallMemoryLog = true/false
Threads exit with NullReferenceException while checkpointing from the main-thread. Basically, the error occurs during the invocation of session.CompletePending(false), and in specific this line of code in FASTERThread.cs:
ref Value value = ref pendingContext.value.Get();
StackTrace:
System.NullReferenceException: Object reference not set to an instance of an object.
at FASTER.core.FasterKV2.InternalCompleteRetryRequest[Input,Output,Context,FasterSession](FasterExecutionContext3 opCtx, FasterExecutionContext3 currentCtx, PendingContext3 pendingContext, FasterSession fasterSession) in D:\arabyads\sandbox\FASTER\cs\src\core\Index\FASTER\FASTERThread.cs:line 217
at FASTER.core.FasterKV2.InternalCompleteRetryRequests[Input,Output,Context,FasterSession](FasterExecutionContext3 opCtx, FasterExecutionContext3 currentCtx, FasterSession fasterSession) in D:\arabyads\sandbox\FASTER\cs\src\core\Index\FASTER\FASTERThread.cs:line 204    at FASTER.core.FasterKV2.InternalCompletePending[Input,Output,Context,FasterSession](FasterExecutionContext3 ctx, FasterSession fasterSession, Boolean wait) in D:\arabyads\sandbox\FASTER\cs\src\core\Index\FASTER\FASTERThread.cs:line 167    at FASTER.core.ClientSession6.CompletePending(Boolean spinWait, Boolean spinWaitForCommit) in D:\arabyads\sandbox\FASTER\cs\src\core\ClientSession\ClientSession.cs:line 396
at FASTER.benchmark.FASTER_YcsbBenchmark.RunYcsb(Int32 thread_idx) in D:\arabyads\sandbox\FASTER\cs\benchmark\FasterYcsbBenchmark.cs:line 164
at FASTER.benchmark.FASTER_YcsbBenchmark.<>c__DisplayClass29_1.b__1() in D:\arabyads\sandbox\FASTER\cs\benchmark\FasterYcsbBenchmark.cs:line 304
at System.Threading.ThreadHelper.ThreadStart_Context(Object state)
at System.Threading.ExecutionContext.RunInternal(ExecutionContext executionContext, ContextCallback callback, Object state)
--- End of stack trace from previous location where exception was thrown ---
at System.Threading.ExecutionContext.RunInternal(ExecutionContext executionContext, ContextCallback callback, Object state)
at System.Threading.ThreadHelper.ThreadStart()

Thanks for the report. The linked PR fixes this issue.

Also, you do not need to set kCheckpointStoreContents as its intention is for backup for fast future benchmark runs when running without periodic checkpoints. You only need to set kCheckpointMilliseconds to enable periodic checkpointing. We have updated the benchmark code with renamed variables in the PR to remove the confusion:

kCheckpointMilliseconds => kPeriodicCheckpointMilliseconds
kCheckpointStoreContents => kBackupStoreForFastRestarts

Thanks for the update and the clarification. Issue is fixed.


Does the mx.symblo.LineaRregressionOutput surpot the multi-lable?

I am building my net in symbol.***.py. And the task I do is a multi-lable regression task.
I think the LinearRegressionOuput can surport the regression task. But I don't know whether it surpport the multi-lable?
The output of my net is a 2 dimension feature. Can the LinearRegressionOuput recognize it?

yes, it support.


Custom MIME type is not recognized and an error has occurred

Describe the bug
This demo uses a JavaScript library called Riot.js imported via CDN.
The library requires the use of custom MIME types(type="riot") when importing custom component files on HTML, as follows:
<script type="riot" data-src="/components/my-tag.riot"></script>

But, StackBlitz seems interpret this setting(type=“riot”) as empty strings(type=“”) when parsing. In this case, StackBlitz says error.
I apologize for the inconvenience, but I would appreciate it if you could check. Thank you!
Link to the blitz that caused the error
https://stackblitz.com/edit/vitejs-vite-b7mnc4?file=index.html,components%2Fmy-tag.riot&terminal=dev
Steps to reproduce

Go to demo page of stackblitz
The application starts, but an error occurs in js and the screen goes blank.

Expected behavior
I know this is a bit of a duplicate, but StackBlitz seems interpret this setting(type=“riot”) as empty strings(type=“”) when parsing.
By the way, when I tried the exact same file locally (running on live-server, etc.), no error occurred.
Parity with Local

[X] I have run the project in my local machine and I could not reproduce the issue.

Screenshots

Platform
Browser name  = Chrome
Full version  = 103.0.5060.134
Major version = 103
navigator.appName = Netscape
navigator.userAgent = Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/<IP_ADDRESS> Safari/537.36
performance.memory = {
  "totalJSHeapSize": 72360483,
  "usedJSHeapSize": 69798015,
  "jsHeapSizeLimit":<PHONE_NUMBER>
}
Hash = 1f021b18268b32e6c6b2095e039ac8c9f88b0d52

Additional context
No response

Hi @kkeeth! Yes this looks like a bug on our side. I created an internal ticket for this. Thanks for reporting 🙏 !


Put exporters in bulleted list with a link and one sentence description

For this:

How about we have a bulleted list of the exporters which says something like:

command_line_exporter which sends telemetry events to the python console jupyter is running on
...

https://github.com/educational-technology-collective/jupyterlab-pioneer/tree/main#configurations


Artifact Filter UI redesign

Reorganizing the UI including a few optimizations like:

Depending on what someone selects in the slot toggle group we could restrict the options in the main stat drop down menu.
Fixing the issue in https://github.com/frzyc/genshin-optimizer/issues/995
Anything along the way 🫡

I will work on this slowly, if someone wants to see this change sooner feel free to get it before me. For any questions just pop a comment.

If you're redesigning the filters theres some ideas in here #1205

If you're redesigning the filters theres some ideas in here #1205

We should narrow scope for this issue to only the UI redesign, and no system changes as all the suggestions in #1205.


Fixes #1 | Better formatting for 'between' and Minor code clean-up

Specs:

Added check to format between case differently.
Removed redundancy from package.json.
Added . for the between message.
Built boss.min.js using new additions.

Todo:

[x] Improve README.md

@cezarlz please review this and let me know if I need to change something.

Did you test it? Can you show me an example of the this implementation? Some screenshot or the final error message.
Thanks!

@cezarlz here's a screenshot.

Amazing @mbad0la. Merging now...

@cezarlz thanks! 🙂


headerCreateAll misses some files which are covered by headerCheckAll

I'm updating a license header in project for more than 200 files.
sbt headerCreateAll misses some of files, and sbt headerCheckAll fails on that files.

Interesting, removing all copyrigth headers from the first file in the list, ublock it.

Same issue here.
This is quite annoying in a large project with many sub-projects.

I suspect this is due to the Create tasks being incremental.  An sbt clean before headerCreateAll seems to address this for me.


[Safari] Adding Item to Reading List brings up Safari Window

Extension
https://www.raycast.com/loris/safari
Description
When I add a URL to my Safari reading list, I expected that after hitting Cmd+Enter to add the new item, the Raycast window would just close – done.
It does not close for me. And additionally Safari comes up when it was minimized or hidden before. It switches the sidebar on to display the reading list.
If this is intended behaviour, I'd like to suggest an option to turn this off :)
Steps To Reproduce

minimize or hide Safari window
open some other application
call Raycast and use the Safari Extension to add a new item to the reading list

Current Behaviour
Safari window comes up, after adding the new item to the reading list through raycast.
Expected Behaviour
The Raycast window closes and I get a little confirmation that the new item was added (like in the quick capture function of the Logseq Raycast extension). Safari does nothing.

Unfortunately that's how Safari interprets the AppleScript. There isn't much we can do here.


Everything is broken in the new nightly build action

https://github.com/NYCPlanning/data-engineering/actions/runs/6918492239/job/18820824380
Empty filter change breaks the jq call on the check changes jobs. The others? TBD

Builds seem broken separate from nightly qa
https://github.com/NYCPlanning/data-engineering/actions/runs/6931114009/job/18852165914

So many builds were broken by this commit
For two reasons

build workflows that have slightly differently named variables. Those are easily fixed
workflows that still spin up their own database

The latter will take a tad more work. So for now, I'm going to

remove the changes in the above commit
call this script (and align usage) as a step (or part of a step) in build workflows that need it explicitly for now. It maybe makes sense philosophically as well - the docker bash script is about finalizing the setup of the python/apt environment (and so also is run when setting up dev container), while the schema stuff is specific to a build.

@alexrichey fyi

call this script as a step in build workflows that need it explicitly for now

makes sense to me!

Oh, my bad. I should have done more thorough testing with that. Thanks for catching and fixing @fvankrieken


⚠ HDBits has degraded performance

In ab678d9, HDBits ($HDB) experienced degraded performance:

HTTP code: 200
Response time: 2053 ms

Resolved: HDBits performance has improved in 2a6da11 after 12 minutes.


Form Steppers

Please consider implementing form steppers:
https://material.google.com/components/steppers.html#

Seems like an extension of our collapse plugin, so we'll pass on doing anything more there. Thanks though!


Delete multiple projects at once

My project list is quite large and deleting each project one by one is quite cumbersome (it requires confirmation for each project)
Proposed solution
Implement the possibility to select multiple projects, click a button and delete them all.
Possible implementation could consider an edit button present in the project list than when clicked would:

allow the user the select using checkboxes multiple project.
display a "cancel" and "delete" button
Once the selection is done, clicking on the delete button would delete all the selected project. Clicking on the "cancel" button would cancel the selection and the editing process.

The edit button could be further expanded in the future with export functionalities etc.
Alternatives considered
Naming the project folder not with the project id but with their name, however it will create a consistency problem if a project will change its name

I guess we could additionally/alternatively make the folder names longer with a new naming strategy such as:
projectName_projectId

@antoine2711 That was indeed my first attempt, but I am unable to run it on my local instance for some reasons: https://github.com/opencultureconsulting/openrefine-client/issues/22 (no problem on other server instances).

Hi @wetneb , I'll provide solutions (written and design mockups) for this issue.

After installing and playing around the OpenRefine app, I came up with design solutions for this issue.
The goal, which is to make it easier for users to select multiple projects , whether they want to delete them or duplicate them. I also added a printing feature.
The below screenshots were designed in Figma on this link. https://www.figma.com/file/W3X6vO1Mn36xdkaGPz8cx6/OpenRefine-Issues?node-id=0%3A1&t=CLUgY3oIOelbonuK-1
I added checkbox to each project list to aid selection if user wants to select a single project and also, a primary checkbox at the top label header to allow users select multiple or all projects.
Also, is a breadcrumb which will appear after a user has selected multiple projects and on click, will drop down options which include print, duplicate and delete ( we can add to the list in the future, of course).
After selection, when a user clicks on delete, a prompt with buttons "delete and cancel" where the user can either go ahead to delete the selected projects ot cancel the selection.
Here are the screenshots.

thiis is nice, I also came up with something but yours is better especially the three dot menu

this is what I came up with, my approach was to allow the selection of projects through a checkbox with a delete button.
Projects can be selected one by one

All projects can be selected at once

this is what I came up with, my approach was to allow the selection of projects through a checkbox with a delete button.
Projects can be selected one by one

All projects can be selected at once

This is good too. However, I think it's important to reduce the time it'd take a user to select multiple projects at once .

this is what I came up with, my approach was to allow the selection of projects through a checkbox with a delete button.
Projects can be selected one by one

All projects can be selected at once

This is good too. However, I think it's important to reduce the time it'd take a user to select multiple projects at once .

Oh actually all projects can be selected when a user clicks on the checkbox at the top

Thanks both @Lydiaofficial and @wumionwheels!
I have removed the "design proposal needed" tag to signify that you have contributed such proposals already. We will follow up on it and try to refine them together.
PS: May I suggest that you do not quote the entire message you are replying to, especially if it contains images, as it makes the thread rather bloated and hard to read? When you are writing a message on a GitHub issue that is a reply to the latest message on the thread, it is already clear from the order of the messages and their contents that you are replying to the previous message. It would be great if you could edit your messages above and remove those unnecessary quotes. Thanks!

Thank you for your feedback. I have edited my comments and gotten rid of the quotes.

Ok sorry about that, thank you for the feedback. I look forward to refining it together too

@lozanaross yes please, I would love to do that.

Also, it is definitely worth thinking about what actions could be done for multiple projects at the same time. Do we already have a duplicating feature? I don't think so, but it could make sense indeed.
For the printing option, I am not too sure. We do not have any printing feature yet and the use case seems unclear to me. I would rather formulate it as an exporter.
In any case, while it is useful to think about what sorts of actions could be triggered with the same mechanism, we should not expand the scope of this issue too much: for instance, printing is clearly a different functionality.

Alright. Thank you for the feedback @wetneb
I'll take it into account.

After some days of research, on how multi-selection is done on OpenRefine, as emphasised by @lozanaross  and analysing what actions are possible for multiple projects at the same time, @wetneb , I have iterated on this issue and improved the design in the following ways:

I maintained the current header design for open projects on OpenRefine

but improved on its content by changing 'All" to the number of open ptojects a user has and adding a checkbox for multiple selection. As is shown here

Clicking on the checkbox next to total projects count will select all projects on the user's interface. Which will then present the user with possible actions for multi-selected projects like "Delete all, Duplicate all and Export all". Like in the main app, the export button maintains it's dropdown to allow the user decide in what format to export the selected projects.

This thereby, ensures the table labels are not affected by whatever actions users decide to execute .

When a user selects one project by clicking on the checkbox icon next to the project's information, the various possible action that user can take is then highlighted on the top header along with the number of selected projects. As it is a single project, user will see buttons: "Delete, Duplicate and Export".

When a user clicks on "duplicate or duplicate all", a prompt, telling the user the number of projects that will be duplicated by executing the action and giving them buttons to either cancel the action or proceed.

Below are more screenshots to show when a user selects multiple projects but not all projects  and how a user can deselect all selected projects (in the caes of multiple project selection) by clicking on the checkbox or drop down to select none and quickly revert to unchecked projects.

Here is the link to figma design : https://www.figma.com/file/W3X6vO1Mn36xdkaGPz8cx6/OpenRefine-Issues?node-id=38%3A11345&t=CTVSLIExAddTcqWY-1

I would just export each project independently and bundle everything up in a zip file. Not sure if that's useful to anyone though. And it's probably worth first leaving out since it's a very different feature.

Thank you so much @thadguidry .
@wetneb , I guess it makes sense to remove the export option from the screenshots in multi-selection then?
Also, anymore feedback, so I would know if to record this as acepted or otherwise.


Update assignees in JIRA where missing

Note: migrated from original JIRA: https://issues.apache.org/jira/browse/ARROW-11031
I have started updating tasks in Jira that were missing assignees.
I see that [~nevi_me]  [~alamb] [~jorgecarleitao] have asked about how to do this in the past so I will briefly explain here.
First you need admin permissions to Jira (I will grant these to you now).
Next you need to add new contributors to the "contributors" role in JIRA. To do this, go to the project setting for Apache Arrow. Select "users and roles" on the left. Click "add user to role" in top right. Then enter the user name and choose the "contributor" role.
After that you can assign issues to that user (and they can self-assign too)

Comment from Jorge Leitão(jorgecarleitao) @ 2020-12-27T11:21:16.019+0000:
Thanks a lot, [~andygrove] .

I updated all issues for the 3.0 release. The search criteria: [https://issues.apache.org/jira/issues/?jql=project%20%3D%20ARROW%20AND%20resolution%20%3D%20Fixed%20AND%20fixVersion%20%3D%203.0.0%20AND%20component%20in%20(Rust%2C%20%22Rust%20-%20DataFusion%22)%20AND%20assignee%20in%20(EMPTY)%20ORDER%20BY%20updated%20DESC%2C%20created%20DESC%2C%20priority%20DESC]

I am still unable to add people as contributors, so there are 2 issues with missing assignee that need to be added as contributors.
Comment from Andy Grove(andygrove) @ 2020-12-28T01:06:30.700+0000:
[~jorgecarleitao] I managed to get distracted immediately after filing this and had not added you as admin but I have now, along with [~alamb] and [~nevi_me]
Comment from Andy Grove(andygrove) @ 2021-01-06T18:21:24.414+0000:
Removed fix version since this does not block the release


Introduction to eventuals::filesystem

Provides asynchronous operations with the filesystem. Uses libuv as the base.
Those operations are not interruptible due to the way of their implementation in libuv.

Committed in 5102f9bc8ad1aff1a69899b9507eb80f49cee235.


Problem on Android Release Build

I want to make android release on windows, and follow official suggestion to use the easy method:
env CC="C:\Program Files\LLVM\bin\clang-cl.exe"  CXX="C:\Program Files\LLVM\bin\clang-cl.exe" FILAMENT_REQUIRES_CXXABI=true ./build.sh -p android  -c release
But the error occurs:

So what step i'm wrong? Or if there is other ways to run android samples on my android devices?
thx for your anwser

But I really really really want to build filament-android on windows to run
the android sample, can you help me please?Tthank you very much.
Romain Guy<EMAIL_ADDRESS>于2018年11月20日周二 下午11:29写道：

Closed #504 https://github.com/google/filament/issues/504.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/google/filament/issues/504#event-1977661074, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AYHhKPyAM70WfwynueZN43q78deLTjyWks5uxB_PgaJpZM4YrQQp
.


feat: add mav2 account

uses a placeholder signer for now

PR-Codex overview
This PR focuses on enhancing the ma-v2 smart contracts by introducing new modules, utility functions, and updating existing structures to support single signer validation and modular account functionalities.
Detailed summary

Added PackSignatureParams type and packSignature utility function in utils.ts.
Implemented SingleSignerValidationModule with methods for encoding installation and uninstallation data.
Introduced new address constants in addresses.ts.
Enhanced singleSignerMessageSigner to utilize the packSignature function.
Updated various ABI definitions for modules including paymasterGuardModule, timeRangeModule, and others.
Refined the createSMAV2Account function to incorporate new functionalities.
Added detailed comments and documentation throughout the code for clarity.

The following files were skipped due to too many changes: account-kit/smart-contracts/src/ma-v2/abis/maV2.ts, account-kit/smart-contracts/src/ma-v2/abis/smaV2.ts, account-kit/smart-contracts/src/ma-v2/abis/smaStorage.ts

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Merge activity

Dec 13, 11:12 AM EST: The merge label 'graphite-merge-queue' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.

[!WARNING]
This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

#1209
#1208  👈 (View in Graphite)
#1207
#1203
main

How to use the Graphite Merge Queue
Add the label graphite-merge-queue to this PR to add it to the merge queue.
You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.


How to handle major version changes / breaking changes ?

Helm v3 has been released. Should we update food to that version?
Taking terraform example, we have updated it always, irrespective of breaking changes

as a rolling update system, the latest version should always be available. We can try to see if the helm@2 convention implemented by homebrew would work here.

see also https://github.com/fishworks/gofish/issues/130


Change Text Inside an Element Using jQuery

I put the the right tags  but the system wont take syntax.
Challenge Name
Change Text Inside an Element Using jQuery
Issue Description
Emphasize the text in your target4 button by adding HTML tags.
Browser Information

Browser Name, Version:
Operating System:
Mobile, Desktop, or Tablet:

Your Code

jQuery Playground

#left-well

        <button class="btn btn-default target" id="target1">#target1</button>
        <button class="btn btn-default target" id="target2">#target2</button>
        <button class="btn btn-default target" id="target3">#target3</button>

#right-well

        <button class="btn btn-default target" id="target4">#target4</button>
        <button class="btn btn-default target" id="target5">#target5</button>
        <button class="btn btn-default target" id="target6">#target6</button>

HAHAHA what a silly mistake. man I need to take a break I been working for hours trying to finish these challenges.

@dconner09, no problem. you could ask for help at Help chat room for getting challenge related help.
Happy Coding!

The only thing you missed here is the #

not working!!!!!!!!

they have askd not to change the text of the button....
I hve included this code which solved but one error
[Emphasize the text in your target4 button by adding HTML tags.]
check my code.......................
$(document).ready(function() {
$("#target1").css("color", "red");
$("#target4").html("#target4");
$("#target4").text("#target4");
});

@GokulManickam
Please use the HelpJavaScript chat room for getting challenge related help.
or use forum. https://forum.freecodecamp.org/
These GitHub Issues are for reporting bugs on the freeCodeCamp website only.
Happy Coding.


Remove all reflection

All tests pass locally. I would also highly recommend setting *warn-on-reflection* to true, to prevent these from showing up in the future.
Thanks!

Any interest in this?

@jeaye yes, I have just been swamped with work lately, I will get to it eventually if one of the other committers doesn't beat me to it.

I appreciate the update! Cheers.

This has been merged now, thanks!

Thank you!


Update to core 1.5.0

The CocoaPods CI job complained of not being able to find handover.hpp: https://ci.realm.io/job/objc_pr/3832/configuration=Release,swift_version=2.2,target=cocoapods/console
It's possible handover.hpp and thread_confined.hpp need to be added to the podspec.
Same thing goes for #3946 /cc @JadenGeller

The non-public headers thankfully don't need to be explicitly listed in the podspec anymore; the problem was just that it was relying on Xcode's extra-forgiving logic to let you include files anywhere in the project by just the bare name.

Ah yes, that makes more sense. Thanks for clarifying.

👍


[Bug]: ECM model does not work (solvers.py tries to get initial SOC from concentrations)

liionpack Version
0.3.8
Python Version
3.8
Describe the bug
When trying to model with ECM model parameters (that was checked with pybamm separately) I am getting this error:
File "liionpack/solver_utils.py", line 427, in solve     output = rm.solve( File "liionpack/solvers.py", line 207, in solve     self.setup_actors(nproc, self.inputs_dict, initial_soc) File "liionpack/solvers.py", line 478, in setup_actors     a.setup(   File "liionpack/solvers.py", line 46, in setup     _, _ = lp.update_init_conc(parameter_values, initial_soc, update=True)   File "liionpack/sim_utils.py", line 53, in update_init_conc     c_n_max = param["Maximum concentration in negative electrode [mol.m-3]"] KeyError: 'Maximum concentration in negative electrode [mol.m-3]'
Ofc it makes no sense for the ECM model but it is enforced in solvers.py (line 39)
        self.parameter_values = parameter_values         if initial_soc is not None:             if (                 (type(initial_soc) in [float, int])                 or (type(initial_soc) is list and len(initial_soc) == 1)                 or (type(initial_soc) is np.ndarray and len(initial_soc) == 1)             ):                 _, _ = lp.update_init_conc(parameter_values, initial_soc, update=True)             else:                 lp.logger.warning(                     "Using a list or an array of initial_soc "                     + "is not supported, please set the initial "                     + "concentrations via inputs"                 )
Steps to Reproduce
No response
Expected behaviour
No response
Relevant log output
No response
Additional context
No response

actually a life example with ECM would be really cool


Exception when screen is locked on Android #55

In my environment, when I verified with this manifest file, the error disappeared.
It's probably correct, but I'll verify our project.

Fixed instead in #64 thanks!


New package: CRNHexagon v0.1.0

Registering package: CRNHexagon
Repository: https://github.com/matthiashimmelmann/CRNHexagon.jl
Created by: @matthiashimmelmann
Version: v0.1.0
Commit: fa313300849fa64330621abdf1535c4ae93bc70b
Reviewed by: @matthiashimmelmann
Reference: https://github.com/matthiashimmelmann/CRNHexagon.jl/commit/fa313300849fa64330621abdf1535c4ae93bc70b#commitcomment-146967966

Can you comment on why you would like to register the supplementary information from a paper as a package in General? Supplementary information typically doesn't meet the bar of being useful beyond the immediate context of the underlying paper, which does not make it a good candidate for General according to the guidelines in the README. It's certainly possible that some supplementary material could take the form of a package that other packages could use as a dependency, but the usage information in your README doesn't really hint at that. Note that packages do not need to be registered in order to be installed. Anyone can pull it from GitHub to verify the paper. The only thing that would make registration an absolute necessity is if other packages in General need it as a dependency, and then it might be better to structure and describe it independently from the paper.
I also don't see the connection between the package name and the paper, so it doesn't seem like the name is really descriptive of the package, which would be a requirement for registration.


[Improvement][UI] Improve Kyuubi UI Engine Page filter condition

Code of Conduct

[X] I agree to follow this project's Code of Conduct

Search before asking

[X] I have searched in the issues and found no similar issues.

What would you like to be improved?
As title:

Kyuubi UI Engine Page filter condition
menu header title font-style

How should we improve?
No response
Are you willing to submit PR?

[X] Yes. I would be willing to submit a PR with guidance from the Kyuubi community to improve.
[ ] No. I cannot submit a PR at this time.

menu header title font-style

just send an independent follow-up PR to fix it.

just send an independent follow-up PR to fix it.

Sure, file #5608  to fix this.


Calling the useOrder() hook in the thank you page raises an error

Please list the package(s) involved in the issue, and include the version you are using

@shopify/checkout-ui-extensions v0.27.1
"<EMAIL_ADDRESS>  version "0.27.0"
  resolved<EMAIL_ADDRESS>  integrity sha512-hash
  dependencies:
    "@remote-ui/async-subscription" "^2.1.14"
    "@remote-ui/react" "4.5.x"
    "@shopify/checkout-ui-extensions" "^0.27.0"
    "@types/react" ">=17.0.0 <18.0.0"

Describe the bug

Unlike the other hooks (such as useCustomer()) that just return undefined if there isn't data available, if you use the useOrder() hook in a checkout extension that renders in the thank you page, it raises an error.

I understand that the order is not processed yet when the shopper reaches the thank you page, but if it raises an error, we need to conditionally call hooks -- which breaks the rules of hooks and is therefore not advisable  -- or we need to keep re-structuring our extension which limits our ability to create the best shopper experience, especially if this sort of behaviour propagates to the other hooks.
This case is especially important because the thank you page and the order status page are very close to each other in terms of shopper journey.
Steps to reproduce the behavior:

create a checkout extension
render the same extension in both thank you page and order status page

render('Checkout::ThankYou::Dynamic::Render', () => <App />);
render('Checkout::OrderStatus::Dynamic::Render', () => <App />);

use the useOrder() hook inside said extension

Expected behavior

useOrder() would just return undefined when the extension is rendered in the thank you page, like it was doing a few versions before.

Thank you =)

Just to be extra clear, the useOrder() hook raises this error which gets in the way of re-using code as described above. Other hooks such as useEmail() just don't return the data if that's not available (ref).

@lucasprag the order API is only available to order status extension targets and will not be available for thank you page extension targets. The error is being thrown to make this more explicit. Is this error causing your extension to crash?

Is this error causing your extension to crash?

@jamesvidler Thank you for you reply =) Yes, it's raising the error from the screenshot and making the extension crash in the thank you page.
I understand that the order is only available in the order status extension targets. My point above is that with other hooks, they just return undefined if the data is not available.
⭐  The problem is that the decision to make the order hook raise an error when using it in other targets -- such as the thank you page targets -- makes it much harder to create an extension that could work on both thank you and order status pages.
This is especially important in this case because these pages are very similar and we (at Smile) would like to create similar experiences as well without having to work around this sort of problem.
Does it make sense?

@lucasprag, yes I can see how it would be better to not throw an error in case. What I might recommend instead would be to attempt to read the order this way:
function Extension() {
  const { extension } = useApi();
  let order = null;

  if(extension.target === 'Checkout::OrderStatus::Dynamic::Render') {
    const api = useApi('Checkout::OrderStatus::Dynamic::Render');
    order = api.order;
  }
}

In the meantime, i'll bring this up with the team to review if we want to continue to do this with our hooks.

Thank you for considering it. I will also give your suggestion a try 👍🏼

Hello, because using useOrder on the thank you page is causing an error, I want to confirm how to obtain order information in the current version as of 2nd July 2023. Will there be any way for us to get order information on the thank you page in the upcoming version that will be released in October? @lucasprag @andrewpye

@jamesvidler so thank you so much for all that. I will close this issue then. 🙇🏼

@jamesvidler so thank you so much for all that. I will close this issue then. 🙇🏼


fix blockchain defaults for config-less dapps

Additional fixes for config-less dapps such as the simple template
Cool Spaceship Picture

Please wait for https://github.com/embark-framework/embark/pull/845 before merging this.


Views Controlled Vocabularies TG call Feb 24 at 16:00 UTC

The Views Controlled Vocabularies Task Group will have an online meeting at 16:00 UTC on Wednesday, February 24, 2021. That corresponds to 11:00 AM Eastern (US) Standard Time (New York), 10:00 AM Central (US) Standard Time (Chicago), 9:00 AM Mountain (US) standard time (Phoenix), and 5:00 PM Central European time (Stockholm).
We will look at additional image sets for different groups and added concepts to describe them.
Join Zoom Meeting
https://vanderbilt.zoom.us/j/91277688201
Meeting ID: 912 7768 8201
Find your local number: https://vanderbilt.zoom.us/u/aswwvjpkO
Add to Google Calendar
Download Outlook .ics calendar invitation

Don't forget that the Views Controlled Vocabularies Task Group is meeting on Wed, Feb 24 at 16:00 UTC. See https://github.com/tdwg/ac/issues/190 for local meeting times and connection details.

Meeting notes are []here](https://github.com/tdwg/ac/blob/master/views/historical/vcv-notes-2021-02-24.pdf)


Jest.mock does not resolve modules correctly when NODE_PATH is set

Description
Running tests with NODE_PATH=src npm test.
Expected behavior
jest.mock('my_module') should be resolved to src/my_module.
Actual behavior
jest.mock('my_module') does not resolve to src/my_module.
Environment

npm ls react-scripts (if you haven’t ejected): 0.8.4
node -v: v6.9.2
npm -v: 3.10.9

@mzuccala could you please update react-scripts to v0.9.0 and confirm that tests are still green?

I verified that this indeed happens, but only if you import it relatively in jest.mock call but absolutely in the app code, or vice versa. This doesn’t seem to happen if you import files consistently in one way or another both in app and jest.mock() calls. So the workaround is to use a consistent convention across your whole app.
I agree this seems like a big, and I filed it as https://github.com/facebook/jest/issues/3069. It is highly unlikely that we can do anything about it on our side, so I’ll close this issue. Please feel free to track https://github.com/facebook/jest/issues/3069 (and maybe even contribute a fix!)

This was fixed in<EMAIL_ADDRESS>


Skip AAD internal filter when is already authenticated or token not issued by AAD

Summary

When AADAuthenticationFilter or AADAppRoleStatelessAuthenticationFilter is auto-configured it will take action on every bearer token. This PR will skip the processing when the current context is already authenticated or the token is not issued by Azure AD.
Issue Type

New Feature

Starter Names

active directory spring boot starter

Additional Information

Hey @saragluna / @jialindai  - Any updates on this, when would it be part of a release.
Thanks.

@nikhilingole This will be out in our next release, which is two weeks later.

Thanks @saragluna for the update and fixing the issue.
As a side comment - Shouldn't the response from the filter be 401/403 if the Token in invalid/expired etc instead of 5xx.

Hi @saragluna, I thing you have to look on AbstractAuthenticationProcessingFilter.

AbstractAuthenticationProcessingFilter - a base Filter used for authentication.
https://docs.spring.io/spring-security/site/docs/current/reference/html5/#servlet-authentication-abstractprocessingfilter

The issue here is that AADAppRoleStatelessAuthenticationFilter is extended from OncePerRequestFilter. It's executed on EVERY request. That is absolutely wrong. It ignores configuration extended from WebSecurityConfigurerAdapter. That's why there is no any way to configure multiple authentication providers.


Invalid credentials with refresh_token

Followed instructions for 3/14/24 update. Obtained refresh_token, without quotes, from my login to manager.sensicomfort.com and entered it into HA integration request. "Invalid credentials." Result is immediate, integration does not load/"think" during this process.

Perhaps there was a miscopy. Try this. Select the “Application” tab instead of the “Network” tab in the Developer Tools. Then under “Storage” “Session storage” select the “refreshToken” Key in the presented Key, Value table. The “refreshToken” value will be shown below the Key, Value table without enclosing quotes for an easier select copy action.

What is your HA and Sensi version? I attempted adding Sensi with bad token and got this. Your prompt looks very different.

Perhaps there was a miscopy. Try this. Select the “Application” tab instead of the “Network” tab in the Developer Tools. Then under “Storage” “Session storage” select the “refreshToken” Key in the presented Key, Value table. The “refreshToken” value will be shown below the Key, Value table without enclosing quotes for an easier select copy action.

This solved my issues after updating the files. Thank you to all for the work on getting this functional again!

I could be wrong. I believed genregasm was trying to fix a broken Sensi integration as was I. The posted image of the prompt is similar to what I saw when responding to HA’s “Sensi needs reconfiguration”, except my refreshToken paste passed the test. My HA is 2023.11.2 with frontend 20231030.2. Sensi is the latest release v1.3.1.

this worked for me, however, the integration seems to fail after about 3-4 hours and it asks me to enter in another refresh token?

this worked for me, however, the integration seems to fail after about 3-4 hours and it asks me to enter in another refresh token?

I noticed that too. I should have a fix for that later today.

I could be wrong. I believed genregasm was trying to fix a broken Sensi integration as was I. The posted image of the prompt is similar to what I saw when responding to HA’s “Sensi needs reconfiguration”, except my refreshToken paste passed the test. My HA is 2023.11.2 with frontend 20231030.2. Sensi is the latest release v1.3.1.

Maybe uninstall/reinstall the integration. The authentication prompt should include a link to manager and more instructions.

I also had to reconfigure again. After seeing these posts I restarted HA to see what would happen. Reconfigure was again required. The previous fix did not uninstall the Sensi integration. There is a file named “sensi” at config/.storage that looks like a json file containing “access_token” and “refresh_token” value pairs. Out of ignorance for me, like rubbing chicken bones together, I replaced both those values with the values (not also the key names) for “authToken” and “refreshToken” copied from the manager.sensicomfort.com website. The Sensi authentication became restored upon restarting HA. The authentication survived subsequent HA restarts so far and also a server reboot. All of that might be meaningless for all I know about the HA authentication process.

When I go to https://manager.sensicomfort.com/ it redirects me to https://manager.sensicomfort.com/choose-plan. is anyone else having this issue or do I need to pay for a plan to get access to this.

When I go to https://manager.sensicomfort.com/ it redirects me to https://manager.sensicomfort.com/choose-plan. is anyone else having this issue or do I need to pay for a plan to get access to this.

You need to have the developer tab of your browser open as you log in. You don't need to buy a plan. Check prior updates/documentation for the information you need to capture from there.

this worked for me, however, the integration seems to fail after about 3-4 hours and it asks me to enter in another refresh token?

Me as well

this worked for me, however, the integration seems to fail after about 3-4 hours and it asks me to enter in another refresh token?

Same here.   I enter in the same token, and it takes it, but the whole integration needs to be restarted before any controls work.   Will probably try to get them into Homekit and try that route.   Shame, it was really nice when it worked.

The token can expire. 1.3.2 has better support for renewing the token when data load indicates expiration.

When the token expires, the frontend appears to display stale data.  It doesn’t flag the entities as unavailable.  This means I can adjust the desired temperature to a new temperature and it looks like it’s working.  I see the new temperature set.  But on the back end there is no communication.  So the end user thinks they’ve set a new temperature when in reality the token expired means nothing is changing.
I think the solution (for expired) would be to set all entities as unavailable so the end user sees on the frontend that communication is down.
I understand that refreshing the token is the ultimate goal.  But I’m trying to say that in the event of failure to authenticate the entities should not display stale (last known) values.  Displaying unavailable is better.

The integration flags entities as unavailable based on online status i.e. thermostat being accessible from Sensi servers. It would be trivial to extend that to authentication failure.

The token refresh should be working (v1.3.2).

The token refresh should be working (v1.3.2).

It looks like it is....so far it has not stopped working after a day or so.   What I did was complete remove and delete the older version and just reinstall the integration and it's all good now.    Thanks so much for your efforts.


Can l use the two stream model as a feature extractor ?

Hello,
thank you for your work.
l'm asking  how can l use  spatial and temporal model on UCF-101 for features extraction ?
Thank you

have you solved this problem??


V2 Framework Driver not picked up

Hey there,
I have a .NET 6.0 console project which references NUnit.Engine 3.14.0 and NUnit.Extension.NUnitV2Driver 3.9.0. When I try to run NUnit2 tests from test assembly (targeting .NET Framework 4.8, referencing NUnit 2.6.4), I get the following result:
Either assembly contains no tests or proper test driver has not been found.
According to the documentation, V2 Framework Driver should be used automatically if installed. Am I missing something?
Please find attached solution which can be used to reproduce the issue.
NUnit3_Repro.zip

There are two problems:

The driver is being referenced by your project rather than being installed as an engine extension. Normally extensions are not referenced in this way. I recognize that you may be using the reference simply to get the extension to be copied to the correct directory, however.

Your project is targeting .NET 6.0, the engine reference pulls in the a .NET Core version of the engine. The extension, OTOH, targets the .NET 2.0 framework. So even if it is installed in the correct place, it cannot be loaded.

The extension works for various runners, which target versions of the .NET Framework. It has never been ported to .NET Standard or Core, because the existing runners don't need it.
There's an open question as to whether we'll continue to support V2 tests in future versions (4.x) or the engine. I'll go ahead and create a new issue to address that.
I'm closing this as "Not a bug" but if you disagree or have more comments, you can still post them hear and I'll respond.


Enhanced documentation on lifecycle handlers

Improved documentation for lifecycle handlers:

Documented, that they run inside the same Container they're attached to.
Documented, that the exit code of the handlers matters and why this is useful.

This PR fixes kubernetes/kubernetes/issues/97387.
NOTE: Might need some polishing and cross-validation.

Disclaimer:
I did those changes to my best knowledge and abilities. If I'm wrong with my terminology, placment of the paragraphs, etc. please bear with me, this is my first PR in this repo :smiley:

/check-cla

/check-cla

Okay so it seems like I only got the email to verify my ID but not the one to sign the CLA. This page says:

I didn't get the email agreement to sign. How do I resend?
Please contact us using the form on the bottom of the pending agreement page.

However I don't know where the "pending agreement page" is. Any clues?

Ping

Ping

👋 @Anticom .
Thanks for contributing!
Just checking if you are working on this PR?
Reach out if you need help or have questions about the suggested changes?
Page preview:
https://deploy-preview-25757--kubernetes-io-master-staging.netlify.app/docs/tasks/configure-pod-container/attach-handler-lifecycle-event/#discussion

No response from author for quite some time.
Please feel free to reopen when time is good.
/close


Joint snaps to lower range once simulation starts?

I have a simple hinge joint defined with
<joint type="hinge" axis="0 1 0" range="-59 59" damping="0" stiffness="0" armature=".01" limited="true" solimplimit="01 .99 .01"/>
and I can't understand why it snaps to its lower range once the simulation starts. Setting the range to "0 59" stops the snapping obviously but I need to be able to set the desired range. What is it about setting the minimum here that forces the thigh to the position shown? (left leg removed for simplicity)
I've tried playing with the stiffness, damping, and solimplimit attributes and have come to undertsand it's something I don't.

video https://youtu.be/wiZ_B39Vi5c
xml https://www.principiaprogrammatica.com/dump/test.xml

Looks like a self-collision? Hit the 'C' and/or 'F' buttons in simulate to verify.
Also read this for a more thorough explanation. Perhaps this text should be upgraded to the documentation.

That was it, thank you. Self collision is enabled when the root is static.

Is it possible to disable self collision in this case?

Either that or use the exclude clause, which might be more convenient.


fix(onStart): Remove stop propagation call so events will bubble up

Closes #611

In ionic, there is an event attached to swipe left/right to show/hide side menu. Removing event.stopPropagation() on start causes opening of side menu when the slider is dragged to right. There can be many different cases or framework which has an event attached to swipe especially for mobile application, I am not sure removing event.stopPropagation() from the library was a good idea because now every developer who uses this library for mobile apps will have to write onStart option to ensure event.stopPropagation(); to prevent side menu from opening.
To solve this I have added an option for slider configuration.
options: {                 onStart: function () {                     event.stopPropagation();                 }, }

Adding onStart as an option does not solve this issue of side menu opening. Rolling back to 6.4.3 :-(


SMD-716 - Validate intervention themes

Ticket
Pathfinders - validate intervention themes as part of cross-table validation
Change summary

For “Outputs” and “Outcomes” tables, validate that “Output” and “Outcome” belong to the list of available outputs or outcomes for the intervention theme selected
Remove any straightforward checks on whether outputs or outcomes belong to a flat list of allowed values
For “Project finance changes” table, validate that “Intervention theme moved from” and “Intervention theme moved to” belong to the list of available intervention themes

Hey @nsnape, I took your point about the unwieldy code in core/validation/specific_validation/pathfinders/round_1.py to heart and have completely refactored that file to reduce repetitiveness and noise...
Now we have three new helper methods:

_error_message which abstracts away the Message construction to avoid the need to repeatedly pass None for cell_index and error_type
_check_values_against_allowed which checks that the values in a specified column of a DataFrame are within a list of allowed values
_check_values_against_mapped_allowed which checks that the values in a specified column of a DataFrame are within a list of allowed values determined by another column

These helper methods are then leveraged by other methods in the module. I've also added docstrings to all methods, including in core/transformation/pathfinders/round_1/control_mappings.py.
Cheers and please bear in mind I'll be off till the 10th now so won't be able to respond to any comments


Avoid compiling/linking mismatched version of Intel SGX SDK

Right now, Tealcave only support a specific version of Intel SGX SDK. Linking with a different version may result in undefined behavior. Basically, there are two methods to avoid compiling with a mismatch version of Intel SGX SDK:

[x] Check Intel SGX SDK version in cmake
[ ] Install the compatible SDK on demand

We can do both in our building system and add an option to download the specific version of SDK on demand.

The first fix in the proposal has been implemented in #285.


Remove NoMethodError test

This test causes an error in rspec >= 3 due to a deprecation of the not_to raise_error syntax. The caller is instead expected to either specify that no
error will be raised, or give a specific error that will be raised.
Since the second case is covered by another test, this one can be removed.

Thanks for fix!


Improve Sign Up process

Bring below box (without title) under text ^^. Then keep 2 buttons under. So that people can sign up directly from the main page.

Its an embed form I can't add signup button beside telegram button

can we have telegram button like sign up button on last image ^^ and just add "AND" between both boxes?

Displayed on staging

Can we make the section a bit smaller (same size as before if we can while keeping buttons in)?

Instead of "AND" Telegram
-> "AND JOIN US ON" Telegram

fixed


[Bug]: Cannot make consecutive completion calls for guided decoding with grammar

Your current environment
Collecting environment information...
PyTorch version: 2.1.2+cu121
Is debug build: False
CUDA used to build PyTorch: 12.1
ROCM used to build PyTorch: N/A

OS: Ubuntu 22.04.3 LTS (x86_64)
GCC version: (Ubuntu 11.4.0-1ubuntu1~22.04) 11.4.0
Clang version: Could not collect
CMake version: version 3.27.4
Libc version: glibc-2.35

Python version: 3.10.12 (main, Jun 11 2023, 05:26:28) [GCC 11.4.0] (64-bit runtime)
Python platform: Linux-5.4.242-156.349.amzn2.x86_64-x86_64-with-glibc2.35
Is CUDA available: True
CUDA runtime version: 12.2.128
CUDA_MODULE_LOADING set to: LAZY
GPU models and configuration:
GPU 0: NVIDIA A100-SXM4-80GB
GPU 1: NVIDIA A100-SXM4-80GB

Nvidia driver version: 470.182.03
cuDNN version: Probably one of the following:
/usr/lib/x86_64-linux-gnu/libcudnn.so.8.9.5
/usr/lib/x86_64-linux-gnu/libcudnn_adv_infer.so.8.9.5
/usr/lib/x86_64-linux-gnu/libcudnn_adv_train.so.8.9.5
/usr/lib/x86_64-linux-gnu/libcudnn_cnn_infer.so.8.9.5
/usr/lib/x86_64-linux-gnu/libcudnn_cnn_train.so.8.9.5
/usr/lib/x86_64-linux-gnu/libcudnn_ops_infer.so.8.9.5
/usr/lib/x86_64-linux-gnu/libcudnn_ops_train.so.8.9.5
HIP runtime version: N/A
MIOpen runtime version: N/A
Is XNNPACK available: True

CPU:
Architecture:                    x86_64
CPU op-mode(s):                  32-bit, 64-bit
Address sizes:                   46 bits physical, 48 bits virtual
Byte Order:                      Little Endian
CPU(s):                          96
On-line CPU(s) list:             0-95
Vendor ID:                       GenuineIntel
Model name:                      Intel(R) Xeon(R) Platinum 8275CL CPU @ 3.00GHz
CPU family:                      6
Model:                           85
Thread(s) per core:              2
Core(s) per socket:              24
Socket(s):                       2
Stepping:                        7
BogoMIPS:                        6000.00
Flags:                           fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush mmx fxsr sse sse2 ss ht syscall nx pdpe1gb rdtscp lm constant_tsc arch_perfmon rep_good nopl xtopology nonstop_tsc cpuid aperfmperf tsc_known_freq pni pclmulqdq monitor ssse3 fma cx16 pcid sse4_1 sse4_2 x2apic movbe popcnt tsc_deadline_timer aes xsave avx f16c rdrand hypervisor lahf_lm abm 3dnowprefetch invpcid_single pti fsgsbase tsc_adjust bmi1 avx2 smep bmi2 erms invpcid mpx avx512f avx512dq rdseed adx smap clflushopt clwb avx512cd avx512bw avx512vl xsaveopt xsavec xgetbv1 xsaves ida arat pku ospke
Hypervisor vendor:               KVM
Virtualization type:             full
L1d cache:                       1.5 MiB (48 instances)
L1i cache:                       1.5 MiB (48 instances)
L2 cache:                        48 MiB (48 instances)
L3 cache:                        71.5 MiB (2 instances)
NUMA node(s):                    2
NUMA node0 CPU(s):               0-23,48-71
NUMA node1 CPU(s):               24-47,72-95
Vulnerability Itlb multihit:     KVM: Vulnerable
Vulnerability L1tf:              Mitigation; PTE Inversion
Vulnerability Mds:               Vulnerable: Clear CPU buffers attempted, no microcode; SMT Host state unknown
Vulnerability Meltdown:          Mitigation; PTI
Vulnerability Mmio stale data:   Vulnerable: Clear CPU buffers attempted, no microcode; SMT Host state unknown
Vulnerability Retbleed:          Vulnerable
Vulnerability Spec store bypass: Vulnerable
Vulnerability Spectre v1:        Mitigation; usercopy/swapgs barriers and __user pointer sanitization
Vulnerability Spectre v2:        Mitigation; Retpolines, STIBP disabled, RSB filling, PBRSB-eIBRS Not affected
Vulnerability Srbds:             Not affected
Vulnerability Tsx async abort:   Not affected

Versions of relevant libraries:
[pip3] numpy==1.22.2
[pip3] onnx==1.14.0
[pip3] pytorch-quantization==2.1.2
[pip3] torch==2.1.2
[pip3] torch-tensorrt==2.0.0.dev0
[pip3] torchdata==0.7.0a0
[pip3] torchtext==0.16.0a0
[pip3] torchvision==0.16.0a0
[pip3] triton==2.1.0+e621604
[conda] Could not collectROCM Version: Could not collect
Neuron SDK Version: N/A
vLLM Version: 0.4.0.post1
vLLM Build Flags:
CUDA Archs: 5.2 6.0 6.1 7.0 7.2 7.5 8.0 8.6 8.7 9.0+PTX; ROCm: Disabled; Neuron: Disabled
GPU Topology:
GPU0	GPU1	CPU Affinity	NUMA Affinity
GPU0	 X 	NV12	0-23,48-71	0
GPU1	NV12	 X 	0-23,48-71	0

Legend:

  X    = Self
  SYS  = Connection traversing PCIe as well as the SMP interconnect between NUMA nodes (e.g., QPI/UPI)
  NODE = Connection traversing PCIe as well as the interconnect between PCIe Host Bridges within a NUMA node
  PHB  = Connection traversing PCIe as well as a PCIe Host Bridge (typically the CPU)
  PXB  = Connection traversing multiple PCIe bridges (without traversing the PCIe Host Bridge)
  PIX  = Connection traversing at most a single PCIe bridge
  NV#  = Connection traversing a bonded set of # NVLinks

🐛 Describe the bug
I cannot create consecutive calls to the Open AI API server when specifying the guided_grammar param.
   }
... )
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/usr/local/lib/python3.10/dist-packages/openai/_utils/_utils.py", line 275, in wrapper
    return func(*args, **kwargs)
  File "/usr/local/lib/python3.10/dist-packages/openai/resources/chat/completions.py", line 667, in create
    return self._post(
  File "/usr/local/lib/python3.10/dist-packages/openai/_base_client.py", line 1213, in post
    return cast(ResponseT, self.request(cast_to, opts, stream=stream, stream_cls=stream_cls))
  File "/usr/local/lib/python3.10/dist-packages/openai/_base_client.py", line 902, in request
    return self._request(
  File "/usr/local/lib/python3.10/dist-packages/openai/_base_client.py", line 978, in _request
    return self._retry_request(
  File "/usr/local/lib/python3.10/dist-packages/openai/_base_client.py", line 1026, in _retry_request
    return self._request(
  File "/usr/local/lib/python3.10/dist-packages/openai/_base_client.py", line 978, in _request
    return self._retry_request(
  File "/usr/local/lib/python3.10/dist-packages/openai/_base_client.py", line 1026, in _retry_request
    return self._request(
  File "/usr/local/lib/python3.10/dist-packages/openai/_base_client.py", line 993, in _request
    raise self._make_status_error_from_response(err.response) from None
openai.InternalServerError: Internal Server Error

Complete traceback from the server:

Received request cmpl-c3e665c611c84d979b15b39763bff7c7: prompt: '<s>[INST] <<SYS>> You are a helpful assistant. <</SYS>> Give me a number:  [/INST]', sampling_params: SamplingParams(...), prompt_token_ids: [...], lora_request: None
Engine background task failed
Traceback (most recent call last):
File "/usr/local/lib/python3.10/dist-packages/lark/lexer.py", line 665, in lex
yield lexer.next_token(lexer_state, parser_state)
File "/usr/local/lib/python3.10/dist-packages/lark/lexer.py", line 598, in next_token
raise UnexpectedCharacters(lex_state.text, line_ctr.char_pos, line_ctr.line, line_ctr.column,
lark.exceptions.UnexpectedCharacters: No terminal matches '1' in the current parser context, at line 1 col 2
11
^
Expected one of:
* <END-OF-FILE>
Previous tokens: Token('__ANON_0', '1')
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "/usr/local/lib/python3.10/dist-packages/vllm/engine/async_llm_engine.py", line 38, in _raise_exception_on_finish
task.result()
File "/usr/local/lib/python3.10/dist-packages/vllm/engine/async_llm_engine.py", line 480, in run_engine_loop
has_requests_in_progress = await asyncio.wait_for(
File "/usr/lib/python3.10/asyncio/tasks.py", line 445, in wait_for
return fut.result()
File "/usr/local/lib/python3.10/dist-packages/vllm/engine/async_llm_engine.py", line 454, in engine_step
request_outputs = await self.engine.step_async()
File "/usr/local/lib/python3.10/dist-packages/vllm/engine/async_llm_engine.py", line 213, in step_async
output = await self.model_executor.execute_model_async(
File "/usr/local/lib/python3.10/dist-packages/vllm/executor/gpu_executor.py", line 148, in execute_model_async
output = await make_async(self.driver_worker.execute_model)(
File "/usr/lib/python3.10/concurrent/futures/thread.py", line 58, in run
result = self.fn(*self.args, **self.kwargs)
File "/usr/local/lib/python3.10/dist-packages/torch/utils/_contextlib.py", line 115, in decorate_context
return func(*args, **kwargs)
File "/usr/local/lib/python3.10/dist-packages/vllm/worker/worker.py", line 221, in execute_model
output = self.model_runner.execute_model(seq_group_metadata_list,
File "/usr/local/lib/python3.10/dist-packages/torch/utils/_contextlib.py", line 115, in decorate_context
return func(*args, **kwargs)
File "/usr/local/lib/python3.10/dist-packages/vllm/worker/model_runner.py", line 666, in execute_model
logits = self.model.compute_logits(hidden_states, sampling_metadata)
File "/usr/local/lib/python3.10/dist-packages/vllm/model_executor/models/llama.py", line 351, in compute_logits
logits = self.logits_processor(self.lm_head.weight, hidden_states,
File "/usr/local/lib/python3.10/dist-packages/torch/nn/modules/module.py", line 1518, in _wrapped_call_impl
return self._call_impl(*args, **kwargs)
File "/usr/local/lib/python3.10/dist-packages/torch/nn/modules/module.py", line 1527, in _call_impl
return forward_call(*args, **kwargs)
File "/usr/local/lib/python3.10/dist-packages/vllm/model_executor/layers/logits_processor.py", line 58, in forward
logits = _apply_logits_processors(logits, sampling_metadata)
File "/usr/local/lib/python3.10/dist-packages/vllm/model_executor/layers/logits_processor.py", line 97, in _apply_logits_processors
logits_row = logits_processor(token_ids, logits_row)
File "/usr/local/lib/python3.10/dist-packages/vllm/model_executor/guided_logits_processors.py", line 92, in __call__
allowed_tokens = self.fsm.allowed_token_ids(self.fsm_state[seq_id])
File "/usr/local/lib/python3.10/dist-packages/outlines/fsm/fsm.py", line 313, in allowed_token_ids
interactive.exhaust_lexer()
File "/usr/local/lib/python3.10/dist-packages/lark/parsers/lalr_interactive_parser.py", line 52, in exhaust_lexer
return list(self.iter_parse())
File "/usr/local/lib/python3.10/dist-packages/lark/parsers/lalr_interactive_parser.py", line 43, in iter_parse
for token in self.lexer_thread.lex(self.parser_state):
File "/usr/local/lib/python3.10/dist-packages/lark/lexer.py", line 674, in lex
raise UnexpectedToken(token, e.allowed, state=parser_state, token_history=[last_token], terminals_by_name=self.root_lexer.terminals_by_name)
lark.exceptions.UnexpectedToken: Unexpected token Token('__ANON_0', '1') at line 1, column 2.
Expected one of:
* <END-OF-FILE>
Previous tokens: [Token('__ANON_0', '1')]

More Context:

I copied llama-2-7b safetensor weights to ./model_files.
I ran the Open AI API server with: python -m vllm.entrypoints.openai.api_server --model ./model_files --dtype float32 --api-key <API_KEY>

cc @simon-mo

We recently merged https://github.com/vllm-project/vllm/commit/138485a82de50f90536ea0a650dd2f6bba1927e9 on main branch which might help resolve this issue. @saiatmakuri can you help test on the main branch? Thank you!

fixed with https://github.com/vllm-project/vllm/pull/4189


Fails in case of nil value

When deserialize a column containing nil values ("N;") fails with following error:

Error: org.jruby.exceptions.RaiseException: (NoMethodError) undefined method `[]' for nil:NilClass

Pull request with fix: https://github.com/cynipe/embulk-filter-pherialize/pull/2


add signingPublicKey to object store key register request

The deployed version of object store appears to have this now, so it needs to be added in so the keys can be added via the ui again 🤞

Codecov Report

Merging #89 (4cb26a7) into main (4fc8f1c) will not change coverage.
The diff coverage is n/a.

:exclamation: Current head 4cb26a7 differs from pull request most recent head 938099e. Consider uploading reports for the commit 938099e to get more accurate results

@@            Coverage Diff            @@
##               main      #89   +/-   ##
=========================================
  Coverage     11.70%   11.70%
  Complexity       35       35
=========================================
  Files            65       65
  Lines          3392     3392
  Branches        359      359
=========================================
  Hits            397      397
  Misses         2938     2938
  Partials         57       57

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4fc8f1c...938099e. Read the comment docs.