Synced the documentation with master branch

Changes
Explain the motivation for making this change. What existing problem does the pull request solve?
The documentation in the develop branch is not updated. Therefore updating the documentation as per the master branch

We're not using concept of develop branch here. Everything get's merged to master and we do releases to build on production.
@GauravGusain98 this PR is not needed.

Closing this PR as it is not required.


SET up khan board for final project , Rails + React, module 6 Microverse

number of members = 4

we separated the project into front end and back end
this is the front-end part:

link for the repository => https://github.com/benja27/Doctor-Appoinments---Front-End
link of the Khan board => https://github.com/users/benja27/projects/14

this is the back end part:
repository => https://github.com/sylvester-wamaya/doctor-appointment-backend
khan board link => https://github.com/users/sylvester-wamaya/projects/5/

Hi STUDENT_MENTION
While you made a great effort in this project, unfortunately, I cannot proceed to review your code.
Invalid Code Review Request
You have submitted a project, that does not contain a screenshot of the Kanban board.
Your Code Review Request will be marked as invalid in your Dashboard, so please submit a new one once you are ready 🙏
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.

Invalid Code Review Request does not count into the code reviews limit.

Hi @benja27,
Wow, you did it 🎉

Your project is complete!  There is nothing else to say other than... it's time to merge it :shipit:
Congratulations! 🎉
Optional suggestions
Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.

As described in the Code reviews limits policy  you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.


A readOnly mode

In this case no listeners like press etc. should work but it can still be controlled from outside by passing playbackNotes

Yeah, I think this makes sense to do. Perhaps instead of calling the prop readOnly we might want to call it something like disableInput or something, to map more closely to what it does. Alternatively, we might want to rename props.disabled to props.loading and then use props.disabled for disabling input (downside is that that would be a breaking change).

@ritz078 I believe this is addressed in #36 with Piano.activeProps, which I released in v3.0.0 today, which when set essentially makes the component readonly. Let me know if this doesn't meet the requirement here and I'll reopen this.

CSS can be used to disable pointer events on a parent element
.avoid-clicks {
  pointer-events: none;
}

with react styles, should look like this:
<div style={{pointerEvents: "none"}}>
          <Piano
            noteRange={noteRange}
            width={300}
            disabled={false}
            playNote={playNote}
            stopNote={stopNote}
            activeNotes={activeNotes}
          />
</div>


Alsa audio module muting bot the Master and Speaker channels..

Pulseaudio module mutes both the alsa-audio Master and Speaker channels when i click on the icon. On clicking on it the second time it unmutes the Master but not the Speaker channel still inhibiting sound. Is there a way to disable the click handlers on the a pulseaudio module as i encounterd this when i mistakenly click on the volume module status

Pulseaudio doesn't have channels, are you referring to alsa channels?

@NBonaparte yes i'm refering to the alsa channels. I was able rebuild the it without the scroll and right click and scroll listeners

I refered to it as pulse audio because the modules is called pulseaudio in the source code even though its just an object wrapper interfaing with the alsa api

[module/volume]
type=internal/volume

That's the alsa module. If your system uses pulseaudio, use the pulseaudio module (you will need to use the polybar-git package). If not, we'll have to debug this further, as I haven't seen this problem when only alsa is used,

@patrick96 i dont understand.. from the source its clear alsa is the underlying implementation. I built the polybar from source because i had to make some changes from the wireless_tool to nl80211. The system is a lenovo T530 with alsa drivers and a pulseaudio server.

It's not, the pulseaudio interacts with the pulseaudio library (libpulse). I don't know where you see the pulseaudio module use the alsa API

@patrick96 i used the alsa api.
i have tried
type = internal/alsa

and
type=internal/volume

So what i'm saying is this is a bug in the polybar alsa module.

Both configurations lead to the same bug I can rename the the topic to Alsa.

internal/volume is just the old (deprecated) name for internal/alsa, their functionality is identical. The problem you have is not a polybar one, but caused by using alsa controls when you use both alsa and pulse, this was already reported in #900, #505, #704 and here. That's why I suggested using the pulseaudio module because it doesn't have this problem.
Closing this as a duplicate.

@patrick96 i have both the pulseaudio server and alsa driver installed on my system so what configutation should i use for my current build?

This

rebuilt my moded version with alsa and broke and bar.
but a fresh clone from github with type=internal/pulseaudio worked as expected


Feature/3729/multiple account error messages

When a 409 is received while attempting to link a new account, the snackbar message that pops up will have a link to the docs. Currently, the if there is an error linking your Google account, that uses a banner error instead of the snackbar component (apparently there is some special setup that needs to be done? See here)
GH issue: dockstore/dockstore#3729
Pairs with: https://github.com/dockstore/dockstore/pull/4063

(TIL, note readthedocs latest is not like Docker Hub latest. It is just the default branch for the repo)


LAMHDI SO review ticket #6: ‘variant collection’

The current definition of 'variant collection' in SO is “a sequence collection comprised of one or more sequences of an individual”.
A. It is not clear what is meant by ‘of an individual’ . . . this seems to be the phrase used to distinguish a ‘variant collection’ from a ‘sequence collection’. Our understanding of this distinction is that a members of a ‘variant collection’ necessarily represent comparable versions of some particular genetic feature - ie they are ‘sequence variants’ that are versions of a particular gene, genome, or other feature that shows variation between individuals (or within an individual, as can be the case for alleles). The 'variant collection' class can then be used to reference, for example, the set of alleles of a given gene that are found across a population of individuals, or within a single individual. By contrast, the more general class ‘sequence collection’ would be used to reference collections that are not necessarily comprised of comparable versions of some particular feature. For example, ‘genome’ would be a ‘sequence collection’ but not a ‘variant collection’ because its members are the individual chromosome sequences - not alternate versions of some specific sequence feature.
If this understanding is correct, consider including the above explanation as an rdfs:comment, and amending the definition to something like: “a sequence collection whose members represent variants of a particular sequence feature or collection of an individual (e.g. a gene or a genome), that vary from each other in virtue of sequence alterations they contain”.
B. Also, consider replacing the current superclass axiom “sequence_collection and (has_part some sequence_alteration)” with “has_member some sequence variant” (where ‘sequence variant’ has the axiom has_part some sequence alteration).
C. Finally, if the interpretations above are correct, it does not make sense for ‘allele’ or ‘genotype’ to be children, as they are not ‘collections of variants’. An allele is a single sequence (defined as ’one of a set of sequence variants’), and thus seems should be a child of ‘sequence variant’. A genotype, while representing a collection in the sense that it is about a set of discontinuous sequences in a genome, is not a ‘variant’ collection in the sense described above because this is not a collection of alternate versions of some specific sequence feature. Separate tracker tickets will be submitted for these issues concerning 'allele' and 'genotype'

Response from @keilbeck to Matthew Brush
Hi Matt
Since we got the travel grant to work with you on these issues, I am making all the lamdi requests 'pending'
--K


Nice Work

Just wanted to give a shout out, this looks like in the spirit of Vue1 / angular1 and KISS principals really really nice simple DX.
I'm a fan of Pinia too but I'm going to give this a go my next project.
Cheers!

Thanks! I really appreciate your feedback ❤


plexamp: 4.1.0 -> 4.2.0

Motivation for this change
Upgrades plexamp from 4.1.0 to 4.2.0
This PR was automatically generated by nixpkgs-upkeep.

CI workflow that created this PR.
Internal tag: 409b2dbc4e6e89e223f9ebb9a7e60009.

Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[ ] NixOS
[ ] macOS
[x] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 168075 run on x86_64-linux 1

1 package built:

plexamp


Add doctrings to please interrogate

I'll go ahead and merge this one so pre-commit is happy again. :wink:


Feature - Remote Notes!

Notes for remote events
What if you were at a lecture and you need to write some details while also having a time reference? Doesn't it just feel terrible to not have notes for all your calendar events?
Well now you can! REMOTE REPLACE EVENTS
Enter notes immediately and start writing. Your events will also have a special symbol [N] that shows that this event is actually copied from remote!

What other things:

names for remote calendars! untill now, you could only see the url and color of a remote source, but now you can also have a name!

no more: "You cannot edit this event" prompt - it was so frustrating!
replaced special characters in events with _
instant transition to the note (because this implementation does not hold some sort of cache or index, the naming convention cannot be changed for files, as such, it is only natural that I open the file instead of prompting for open)
sorry for messy code, i'm not sure how I should've write things better but I can change stuff if you give me some advice

@davish please review, currently no formatter is available for remote events and it would be really useful to connect events on your calendar with your notes in this way.

Well this is the missing feature to make this plugin great(useable)!
Any intention of adding this in, or do you intend to maintain your fork @firststef ?

@emmertex Thanks, well I would have loved to add it to the plugin but @davish doesn't seem to respond, I was thinking of doing a merge into my branch but I might not have time to do it right now, if you need I could let you know.

Hi @emmertex and @firststef, sorry for not having responded to this PR. For the past few months I've been working on a big refactor of the plugin started in #204 and which will be finished in #303. It'll remove all the models that this PR relies on, and so unfortunately I don't think this PR will be a good fit for merging. The good news is that this feature will be much,  easier to implement efficiently in the new system.

ok, i'll close this then


docs: fix ant task README headings

This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. We will now review your pull request.
Thanks,
Microsoft Pull Request Bot

Was looking at old branch


[New Best Practice Guide]: Code Coverage

Checked for duplicates
Yes - I've already checked
Describe the needs
Code coverage is a metric that helps developers understand the percentage of their source code that is "covered" or executed by automated tests. Achieving high code coverage can help in identifying areas of the code that might be prone to bugs or other issues.
We need to document and share the manual steps to calculate code coverage for teams to leverage, but also work to streamline and automate the calculation of code coverage.

The unity-py python github build has code coverage generation and reporting built in by using pytest-coverage and the coveralls platform for reporting. just set it up a bit ago and it was pretty fast, free for open source projects, and has some nice reporting options. example of the reporting dashboard is here: https://coveralls.io/github/unity-sds/unity-py

The unity-py python github build has code coverage generation and reporting built in by using pytest-coverage and the coveralls platform for reporting. just set it up a bit ago and it was pretty fast, free for open source projects, and has some nice reporting options. example of the reporting dashboard is here: https://coveralls.io/github/unity-sds/unity-py

Thanks @mike-gangl! For Python projects, that sounds like a winner.
@jl-0 - which all languages do you hope to generate code coverage statistics for on an on-going basis?

@riverma This is a draft code-coverage-tools page. I incorporated the suggestion from @mike-gangl for Python code coverage tools (pytest-coverage, coveralls). Please let me know if you have other suggestions for tools/languages @jl-0.
Thanks!

@riverma It looks like it may be a good idea to incorporate pytest-coverage into Python Starter Kit if not yet done. What do you think?

@riverma It looks like it may be a good idea to incorporate pytest-coverage into Python Starter Kit if not yet done. Or would it be more appropriate for a continuous testing starter kit? What do you think?

@jpl-jengelke - what do you think about @yunks128 recommendation about?

I think it would be an excellent addition to the Python Starter Kit. I would add it to the tests directory at the top of the repo. I believe the best approach is to show by example how these things work.

Sorry, missed this thread.  This looks good for Python, I am also hoping we can cover Javascript.  One of the soft requirements was to have a tool that could record code coverage during execution in the cases where a defined test suite had not yet been developed.  I know this is possible with python and node, but was not sure if there was method that did both

One of the soft requirements was to have a tool that could record code coverage during execution in the cases where a defined test suite had not yet been developed. I know this is possible with python and node, but was not sure if there was method that did both

@jl-0 - could you elaborate on what you meant by "code coverage during execution in the cases where a defined test suite had not yet been developed"? How would we test for test case coverage without test cases?

@jl-0 - I'm not quite following - what's the format for the "documented test procedure"? Code coverage tools look at function / method references and follow the execution stack to see the portion of code covered - is what you're talking about a tool to scan a text document for references to code function or method names?


defaultValue not passing row index to function

Expected behavior and actual behavior.
The documentation for the defaultValue function in the schema says The arguments passed to this function are: argument[0] = canvasDatagrid.header, argument[1] = row index.
I tried that with a function with two parameters, but only the header appears to be passed, and the row index parameter is showing up as undefined.
Looking at the code in intfs.js, it looks like only the header object is being passed and not the row index.
self.applyDefaultValue = function (row, header) {
           var d = header.defaultValue || '';
           if (typeof d === 'function') {
               d = d.apply(self.intf, [header]);
           }
           row[header.name] = d;
       };

Steps to reproduce the problem.

var grid = canvasDatagrid({
    parentNode: parentNode,
    data: [
        {col1: 'foo', col2: 0, col3: 'a'},
        {col1: 'bar', col2: 1, col3: 'b'},
        {col1: 'baz', col2: 2, col3: 'c'}
    ]
});
grid.addColumn({
    defaultValue: function (e,r) {
        console.log(r); //Will return undefined instead of row index
        return new Date().toString();
    },
    title: 'Bar',
    type: 'date',
    name: 'bar'
});

Is there a workaround for this?

That's not good.  Yeah, you should be able to get the row number from grid.data.length since the new row is always the last row.  If that doesn't work, let me know, there's likely a few other ways, like grid.selectedRows.

I am trying it on an insertColumn, not a new row, so it's not always the last row.
I tried changing d = d.apply(self.intf, [header]); to d = d.apply(self.intf, [header,row]);, and I think I am getting the row, trying to get a row index so I can pass that instead.

I'm so sorry, somehow I read the title as "not passing new row index" when it quite clearly does not say that.
Your assessment is correct.  Depending on how the action was invoked, you can potentially use the activeCell values.
It is obviously a bug, so a PR is welcome.  You've already identified the problem, I bet it's easy to fix.


Readlink api not return correctly in the frontend

@Rizary am I right that the problem on screenshot is that we have 2 links read in arklib, but only 1 displayed in GUI?

it's fixed on #50


Autosave saves version to the wrong doc

Link to reproduction
No response
Describe the Bug
Have a collection with autosave on.
Create 2 docs in that collection.  The latest doc saves a latest version to the first.
Video below.
To Reproduce
https://github.com/payloadcms/payload/assets/12794616/005f8c1b-20d0-4c9b-b2dd-c8eda4e4569f
Payload Version
2.0.11
Adapters and Plugins
bundler-webpack db-mongodb plugin-cloud-storage plugin-sentry richtext-slate

@dacgray Do you use the nested-docs-plugin too or not ?

nope, i don't use the nested doc plugin.

Ok then it's a core problem 👍

Hey @JessChowdhury — please get this pulled up and able to be reproduced with a debugger, and I will help identify the cause / fix.
Thank you everyone!

Hey @dacgray + @ClementLaval, this issue has been resolved here and you can expect it with the next release - which will go out today. Thank you for raising this issue, I'm impressed this bug snuck by us for so long 🐛


Edit example file for dropdowns

Create example from form "Skade på hund, katt eller hest". See Se opp.

Is this still relevant? Can it be grouped with general documentation?


Missing step in README.md: Add joinedGroups field in user document

The README.md does not include the step required to use the app as user.
TODO
Create the following documentation:

Adding a new user to Firestore
Updating the joinedGroups fields for a user after creating a new group

Done.


fix(tooltip): remove tooltip component after it's parent destroyed

fix #1111

I signed it!

@gucheen could you add a unit test for this?

Unit test has been added, but there was something wrong with the test scripts. 'gulp' was missing in travis.

@andrewseguin this may be obsolete based on your animation change, thoughts?

LGTM


Fix preload animated image and improve performance

Prepare and preload animated frames asynchronously can improve performance apparently.
While there are more than 25 visible GIFs on screen, FPS is raised from 30 to ≈60.

Current coverage is 73.90% (diff: 10.00%)

Merging #529 into master will decrease coverage by 0.24%

@@             master       #529   diff @@
==========================================
  Files            21         21
  Lines          2232       2238     +6
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
- Hits           1655       1654     -1
- Misses          577        584     +7
  Partials          0          0

Powered by Codecov. Last update 743e3f2...c9d7f82

LGTM!


ENOENT: no such file or directory node_modules/highlight.js/tools/build.js

Describe the bug
Impossible to install the package actually
To Reproduce
Steps to reproduce the behavior:

npm i storybook-addon-vue-info
See the error about highlight.js

Expected behavior
Your dependency highlight.js has an error which break the install
Screenshots
40151 verbose stack Error: ENOENT: no such file or directory, chmod '/projectFolder/node_modules/highlight.js/tools/build.js'
40152 verbose cwd /projectFolder
40153 verbose Darwin 18.2.0
40154 verbose argv "/Users/user/.nvm/versions/node/v8.12.0/bin/node" "/Users/user/.nvm/versions/node/v8.12.0/bin/npm" "i"
40155 verbose node v8.12.0
40156 verbose npm  v6.5.0
40157 error path /projectFolder/node_modules/highlight.js/tools/build.js
40158 error code ENOENT
40159 error errno -2
40160 error syscall chmod
40161 error enoent ENOENT: no such file or directory, chmod '/projectFolder/node_modules/highlight.js/tools/build.js'
40162 error enoent This is related to npm not being able to find a file.
40163 verbose exit [ -2, true ]

Desktop (please complete the following information):

Version 0.7.1

Additional context
NPM install works fine without your package

@throrin19 Cannot reproduce with steps below (tested on Linux laptop).
$ npx -p @vue/cli vue create storybook
$ cd storybook
$ npx -p @storybook/cli sb init
$ npm i -D storybook-addon-vue-info
# Same result without -D flag

Could you provide a reproduce repo?

Ok, I think it was a problem with highlight.js, After test, the error disapear


Deleting a transaction/script template should go to the last created template

Originally reported by @mrbrianhobo

Currently, when a template is deleted, the app navigates to the Contract script. It would be more intuitive if the app navigates to the last created template of the type that was deleted (Transaction/Script) since there will always be at least 1 template of each type.

I made it to reset to first one in a list of deleted types. Cause tracking which one was the last one would lead to inconsistent behavior.

Fixed!

Fixed!


Add-DbaAgReplica does not add replica

I created a new AG with New-DbaAvailabilityGroup and all worked great.  I wanted to add a replica do that AG and the code runs, but does not add.

Are there any errors on the secondary or primary replica when you attempt to add it?

No errors reported. It appears to work but nothing is changed with the Ag.


Before hook exception reported as skipped instead of fail

**Environment **

protractor-multiple-cucumber-html-reporter: 1.8.0
Node.js version: 10.15.0
NPM version: 6.8.0
Platform name and version: MacOs
protractor version: 5.4.1
Cucucmber version: 5.1.0
protractor-cucumber-framework version: 6.1.1

Describe the bug
When error occurs in Before hook the report shows an error on before but in summary it shows as 'skipped'
To Reproduce
Steps to reproduce the behavior:
declare Before hook that return error:
Before(function (scenario, done) {
done('error');
}
Expected behavior
Report should show the Scenario as error
Actual behavior
Report show the Scenario as Skipped

@ofirmgr
Can you please provide the original create JSON file (so not the merged one) where with the error in the before hook?
Thanks

here is the original json:
[
{
"keyword": "Feature",
"name": "demo feature",
"line": 1,
"id": "demo-feature",
"tags": [],
"uri": "e2e/demo.feature",
"elements": [
{
"id": "demo-feature;demo-scenario",
"keyword": "Scenario",
"line": 3,
"name": "demo scenario",
"tags": [
{
"name": "@debug",
"line": 2
}
],
"type": "scenario",
"steps": [
{
"keyword": "Before",
"hidden": true,
"match": {
"location": "e2e/steps/common.steps.ts:31"
},
"result": {
"status": "failed",
"duration": 3000000,
"error_message": "Error: blabla\n    at World. (e2e/steps/common.steps.ts:32:10)"
}
},
      {
        "arguments": [],
        "keyword": "Given ",
        "line": 4,
        "name": "TODO",
        "match": {
          "location": "e2e/steps/common.steps.ts:95"
        },
        "result": {
          "status": "skipped"
        }
      },
      {
        "keyword": "After",
        "hidden": true,
        "match": {
          "location": "e2e/steps/common.steps.ts:34"
        },
        "result": {
          "status": "passed",
          "duration": 426000000
        },
        "embeddings": [

        ]
      },
      {
        "keyword": "After",
        "hidden": true,
        "match": {
          "location": "node_modules/protractor-cucumber-framework/lib/resultsCapturer.js:26"
        },
        "result": {
          "status": "passed",
          "duration": 1000000
        }
      }
    ]
  }
]

}
]

[
{
"keyword": "Feature",
"name": "demo feature",
"line": 1,
"id": "demo-feature",
"tags": [],
"uri": "e2e/demo.feature",
"elements": [
{
"id": "demo-feature;demo-scenario",
"keyword": "Scenario",
"line": 3,
"name": "demo scenario",
"tags": [
{
"name": "@debug",
"line": 2
}
],
"type": "scenario",
"steps": [
{
"keyword": "Before",
"hidden": true,
"match": {
"location": "e2e/steps/common.steps.ts:31"
},
"result": {
"status": "failed",
"duration": 3000000,
"error_message": "Error: blabla\n    at World. (e2e/steps/common.steps.ts:32:10)"
}
},
      {
        "arguments": [],
        "keyword": "Given ",
        "line": 4,
        "name": "TODO",
        "match": {
          "location": "e2e/steps/common.steps.ts:95"
        },
        "result": {
          "status": "skipped"
        }
      },
      {
        "keyword": "After",
        "hidden": true,
        "match": {
          "location": "e2e/steps/common.steps.ts:34"
        },
        "result": {
          "status": "passed",
          "duration": 426000000
        },
        "embeddings": [

        ]
      },
      {
        "keyword": "After",
        "hidden": true,
        "match": {
          "location": "node_modules/protractor-cucumber-framework/lib/resultsCapturer.js:26"
        },
        "result": {
          "status": "passed",
          "duration": 1000000
        }
      }
    ]
  }
]

}
]

[
{
"keyword": "Feature",
"name": "demo feature",
"line": 1,
"id": "demo-feature",
"tags": [],
"uri": "e2e/demo.feature",
"elements": [
{
"id": "demo-feature;demo-scenario",
"keyword": "Scenario",
"line": 3,
"name": "demo scenario",
"tags": [
{
"name": "@debug",
"line": 2
}
],
"type": "scenario",
"steps": [
{
"keyword": "Before",
"hidden": true,
"match": {
"location": "e2e/steps/common.steps.ts:31"
},
"result": {
"status": "failed",
"duration": 3000000,
"error_message": "Error: blabla\n    at World. (e2e/steps/common.steps.ts:32:10)"
}
},
{
"arguments": [],
"keyword": "Given ",
"line": 4,
"name": "TODO",
"match": {
"location": "e2e/steps/common.steps.ts:95"
},
"result": {
"status": "skipped"
}
},
{
"keyword": "After",
"hidden": true,
"match": {
"location": "e2e/steps/common.steps.ts:34"
},
"result": {
"status": "passed",
"duration": 426000000
},
"embeddings": [
]
},
{
"keyword": "After",
"hidden": true,
"match": {
"location": "node_modules/protractor-cucumber-framework/lib/resultsCapturer.js:26"
},
"result": {
"status": "passed",
"duration": 1000000
}
}
]
}
]
}
]

Closing this issue because it's an issue with multiple-cucumber-html-reporter, I created a new issue, see https://github.com/wswebcreation/multiple-cucumber-html-reporter/issues/87

@ofirmgr
I've been checking this on the multiple-cucumber-html-reporter plugin, check the results

I've also been checking this with this plugin and it also works

To reproduce this do the following:

Clone this module with git clone https://github.com/wswebcreation/protractor-multiple-cucumber-html-reporter-plugin.git
Go to the directory cd protractor-multiple-cucumber-html-reporter-plugin
install the dependencies with npm i
Go to the file /test/cucumber/step_definitions/steps.js and at line 3 remove the comment.
Run the tests npm run t

And check the report, please let me know if this also works for you


[WIP] Make Resource a real component

As discussed, this would require too much voodoo to work for now


Blocked users appears on chat

Application often shows messages from blocked users (I checked couple of times) and sometimes Ignore Highlights are checked, it's about random users from the blocked list, there is no regular rule when they show.
I've got a list of around 200 blocked users on twitch, when the amount was small it didn't occur.

Duplicate of c2#2767. Issue is not specific to chatterino7


Bump github actions ubuntu runner version to 22.04

@cgahr - I've cherry picked your commit to apply black fixes here.  Let's merge this one first so that we have clean builds and then tackle the others.


[CLI] Fix empty value for commandline flag

tkn-result was receiving the empty value from the commandline. This fixes that by initializing after flags are set.
Fixes: #582

Changes

Submitter Checklist
These are the criteria that every PR should meet, please check them off as you review them:

[ ] Has Docs included if any changes are user facing
[ ] Has Tests included if any functionality added or changed
[x] Tested your changes locally (if this is a code change)
[x] Follows the commit message standard
[x] Meets the Tekton contributor standards (including functionality, content, code)
[x] Has a kind label. You can add a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
[ ] Release notes block below has been updated with any user-facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings)
[ ] Release notes contain the string "action required" if the change requires additional action from users switching to the new release

Release Notes
NONE

/assign @avinal

@enarha @sayan-biswas Please review and merge this.

The change breaks the tests.
[ tmp] -> cd results/tools/tkn-results/
[ tkn-results] -> go test ./...
?       github.com/tektoncd/results/tools/tkn-results   [no test files]
?       github.com/tektoncd/results/tools/tkn-results/cmd/records       [no test files]
?       github.com/tektoncd/results/tools/tkn-results/docs      [no test files]
?       github.com/tektoncd/results/tools/tkn-results/internal/flags    [no test files]
?       github.com/tektoncd/results/tools/tkn-results/internal/format   [no test files]
?       github.com/tektoncd/results/tools/tkn-results/internal/portforward      [no test files]
ok      github.com/tektoncd/results/tools/tkn-results/cmd       0.013s
ok      github.com/tektoncd/results/tools/tkn-results/internal/client   0.034s
--- FAIL: TestParseFileConfig (0.00s)
    config_test.go:63:   (*config.Config)(
        -       nil,
        +       &{
        +               Address:        "a",
        +               Token:          "b",
        +               ServiceAccount: &config.ServiceAccount{Namespace: "e", Name: "f"},
        +               SSL:            config.SSLConfig{RootsFilePath: "c", ServerNameOverride: "d"},
        +       },
          )

--- FAIL: TestEnvVarConfig (0.00s)
    config_test.go:63:   (*config.Config)(
        -       nil,
        +       &{SSL: config.SSLConfig{RootsFilePath: "a", ServerNameOverride: "b"}},
          )

--- FAIL: TestFlagConfig (0.00s)
    config_test.go:63:   (*config.Config)(
        -       nil,
        +       &{
        +               Address:        "1",
        +               Token:          "2",
        +               ServiceAccount: &config.ServiceAccount{Namespace: "e", Name: "f"},
        +               SSL:            config.SSLConfig{RootsFilePath: "c", ServerNameOverride: "d"},
        +       },
          )

FAIL
FAIL    github.com/tektoncd/results/tools/tkn-results/internal/config   0.003s
FAIL

It seems previous tests were wrong. That's expected values.

OK. Fixed the tests.

@enarha @sayan-biswas Can you please review this and then merge?

/approve

/lgtm


Indeces -> Indices

word 'indices' is used but misspelled in the codebase.

Thanks for letting me know :)


Added Arc into the browser list.

NOTE: A similar PR may already be submitted! Please search among the Pull request before creating one.
Types of Changes
What types of changes does your PR introduce? Put an x in all boxes that apply

[x] New addition to list
[ ] Fixing bug in existing item in list
[ ] Removing item from list
[ ] Changing structure (organization) of list

Proposed Changes
Describe each of your changes here to communicate to the maintainers why we should accept this pull request.

If you're adding something to the list, be sure to explain why it should be added.
I added Arc browser into the list as I realized this is probably one of the best browsers that I have used in my life. It is Mac exclusive now, and you have to join the waitlist to use it except for students who can get early access. But I still believe this is a great browser in terms of both usability and aesthetics. The "space" feature and the Spotlight-like search experience as well as easy access to files are amazing. I have used safari, chrome, Edge, and many browsers in the past, and arc browser is the one that yields the best usability. I also added the Chinese version.
If you're fixing a bug or resolving a feature request, be sure to link to that issue.

PR Checklist
Put an x in the boxes once you've completed each step. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

[x] I have read the CONTRIBUTING guide
[x] I have explained why this PR is important
[x] I have added necessary documentation (if appropriate)

Further Comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

Added Arc browser, but people, except for students, still need to join the waitlist to wait for downloading.


Integrate vCard as data in QrCode

Is your feature request related to a problem? Please describe.
I'm currently working on an app, which should generate a QR code with contact information.
Describe the solution you'd like
It would be great if one could put a vCard in a QR code and also parse vCards from QR codes.
Describe alternatives you've considered
I could convert my object class to a string and put that in a QR code, but that somehow doesn't feel right..

QR codes can only contain strings, numbers and symbols (kanji, etc). They can't contain binary information. I'm not really sure what the ask is here. The alternative you suggested is probably the best implementation scenario.

Same issue here!


New cargo shuttle for fland

About the PR
new cargo shuttle for fland
Media

[X] I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Changelog
:cl:

tweak: New cargo shuttle for fland

i think everywhere should be the same shuttle.

I think everwhere should have different shuttles.

I like cargo shuttles being different, adds flavor to cargo and adds the possibility for stations with a different type of cargo only compatible with the specific cargo shuttle of the station (like europa, it wouuld need a different "shuttle").

i defer to @Emisse on this one but generally there is no reason to add more maps to the game for such a limited purpose. Cargo shuttles are getting used by 10 players max, so you get a lot less mileage compared to an evac shuttle for not a lot of gain. Especially considering the fact that the size isn't really an issue, like how it is for evac on highpop maps.

ATM there's no easy way to manage all of the shuttles for a station short of copying the yaml unless I start making separate components for each thing.

i dont really want to set the precedent of adding unique cargo shuttles everywhere, core i was already iffy on. each one will add more maintenance to anyone doing changes that affects map code or things affecting cargo shuttle

i dont really want to set the precedent of adding unique cargo shuttles everywhere, core i was already iffy on. each one will add more maintenance to anyone doing changes that affects map code or things affecting cargo shuttle

they said they'd maintain it, and its a separate file to the fland map as well

Another vote for the rule of cool from me. Of they're every breaking it should be easy enough to yoink them for the default shuttle as long as their dock arrangement is consistent.

im sorry but this creates a lot of overhead for testing things regarding station entities, this should ideally be converted to something like a string on the map prototype itself like the evac shuttle rather than stored as a station entity

also yes probably reverting cores cargo shuttle as well until this is done


Crashing when using empty vec() of AsciiMath

Issue Summary
When I input vec() of AsciiMath, it causes Math Processing Error.
see also: https://github.com/asciimath/asciimathml/issues/130
Steps to Reproduce:
see the link above.
Supporting information:
This issue has already fixed in the upstream branch of asciimathml (link to commit), but MathJax doesn't contain this change yet.

Please see the comments there for more details.


Chunked transfer encoding broken by zsh-5.4.2

The behavior of ERR_RETURN has changed causing send_chunk to prematurely exit because of a non-zero return status for sysread which means we end up never sending the last chunk signaling the end of payload.

Fixed by https://github.com/zsh-users/zsh/commit/d29ad85533d5c1f7b5b7cf420ab0cd910032fb50. Keeping open until zsh-5.4.3


CodIn Community Paragraph in Readme.md

Description
Improve the readability and corrected grammatical errors of CodeIn Community paragraph in Readme file
Screenshots
Before

After

Please assign this issue to me under hacktoberfest @IAmTamal

I am willing to contribute to this issue.. Kindly assign me

Description :
I have corrected the grammatical errors, made the sentences more compatible in English and used more precise terms of CodeIn Community paragraph in Readme file so that the user can understand the crux of para easily.

Please assign this issue to me

please assign this issue to me under hacktoberfest

please assign me this issue


feat: Add realTouch command

This PR introduces new realTouch command and closes #4

🎉

:tada: This PR is included in version 1.2.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Seek option

Is it possible to use the seek function on jwplayer. If so how?
This is how it would be done in a "normal" page
a href="#" onclick="jwplayer().seek(2437);"
I just can't figure how to do it in Angular.

Solved by doing the obvious :)
 function PlayerSeek(chapter) {             $log.info('PlayerSeek '  + chapter.IndexTime);             jwplayer().seek(chapter.IndexTime); }


Automated Package Upgrade

:tada: This PR is included in version 2.2.144 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Compilation error in file test_string.cpp with japanese locale

Godot version:
Reproduced on 3.1, 3.1.1, 3.1-stable and 3.1.1-stable
OS/device including version:
Windows 10, japanese locale, Python 3.7.3, Visual Studio Express 2019
Issue description:
Compilation error in file test_string.cpp
E:\godot>scons -j4 p=windows vsproj=yes
scons: Reading SConscript files ...
Configuring for Windows: target=debug, bits=default
Found MSVC compiler: amd64
Compiled program architecture will be a 64 bit executable (forcing bits=64).
YASM is necessary for WebM SIMD optimizations.
WebM SIMD optimizations are disabled. Check if your CPU architecture, CPU bits or platform are supported!
Checking for C header file mntent.h... (cached) no
scons: done reading SConscript files.
scons: Building targets ...
[Initial build] Compiling ==> main\tests\test_string.cpp
[Initial build] test_string.cpp
[Initial build] main\tests\test_string.cpp(951): warning C4819: The file contains a character that cannot be represented in the current code page (932). Save the file in Unicode format to prevent data loss
[Initial build] main\tests\test_string.cpp(1060): error C2001: newline in constant
[Initial build] string.cpp(1062): error C2146: syntax error: missing ';' before identifier 'String'
[Initial build] Compiling ==> thirdparty\libvpx\vp9\common\vp9_scale.c
[Initial build] Compiling ==> thirdparty\libvpx\vp9\common\vp9_scan.c
[Initial build] scons: *** [main\tests\test_string.windows.tools.64.obj] Error 2
Compiling ==> thirdparty\libvpx\vp9\common\vp9_seg_common.c
vp9_scale.c
vp9_scan.c
vp9_seg_common.c
scons: building terminated because of errors.
Steps to reproduce:
Follow instructions from official docs on compilation with japanese locale
Minimal reproduction project:
Follow instructions from official docs on compilation with japanese locale

I've been able to compile succesfully by adding a space at the end of both test strings (lines 1059 and 1060 in tag 3.1.1-stable):
String upper = L"АБВГДЕЁЖЗИЙКЛМНОПРСТУФХЦЧШЩЪЫЬЭЮЯ ";
String lower = L"абвгдеёжзийклмнопрстуфхцчшщъыьэюя ";

I added this test as part of #26760, seems like it's not that portable to define wchar_t literals that way, perhaps file encoding needs to be changed (UTF-8 is by default).
@RicardRC check the file encoding for test_string.cpp and try resaving it with UTF-8/UTF-16 encoding and see if that works.
Note: storing the test string with u prefix results in this:
main\tests\test_string.cpp(1071): error C2440: 'initializing': cannot convert from 'const char16_t [34]' to 'String'

So most likely the file encoding should be fixed instead. I don't know how git checks out files on systems with japanese locale, but something tells me it defaults to UTF-16 which leads to this problem.
Note: test_string.cpp compiles fine with UTF-16 LE encoding on my system.

I'm using japanese locale as the secondary language, only kicks in sometimes. Anyway, I'll try what you propose and report results when I find a minute, before 48 hours.

Windows 10, Python 3.6.4, Visual Studio Community 2017
I can't seem to reproduce the issue, but at some step I've noticed that after compiling Godot under japanese locale Test 32: lstrip and rstrip would fail (godot --test string) which does test some other unicode characters, but I'm unable reproduce it again as well...

I reported only the error that prevents compilation. I do see another warning, on test 31, that states something related to your proposed solution.
1>main\tests\test_string.cpp(951): warning C4819: The file contains a character that cannot be represented in the current code page (932). Save the file in Unicode format to prevent data loss
UTF-8, MSVSC2019

I reported only the error that prevents compilation. I do see another warning, on test 31, that states something related to your proposed solution.
1>main\tests\test_string.cpp(951): warning C4819: The file contains a character that cannot be represented in the current code page (932). Save the file in Unicode format to prevent data loss
UTF-8, MSVSC2019

UTF-8 with BOM results:
Just warnings on test 32, the same that you seem to have reproduced sporadically
But at least no errors, so the engine compiles and works
1>main\tests\test_string.cpp(1010): warning C4566: character represented by universal-character-name '\u00BF' cannot be represented in the current code page (932)
1>main\tests\test_string.cpp(1010): warning C4566: character represented by universal-character-name '\u00B5' cannot be represented in the current code page (932)
1>main\tests\test_string.cpp(1010): warning C4566: character represented by universal-character-name '\u00FF' cannot be represented in the current code page (932)
1>main\tests\test_string.cpp(1011): warning C4566: character represented by universal-character-name '\u00BF' cannot be represented in the current code page (932)
1>main\tests\test_string.cpp(1011): warning C4566: character represented by universal-character-name '\u00B5' cannot be represented in the current code page (932)
1>main\tests\test_string.cpp(1011): warning C4566: character represented by universal-character-name '\u00FF' cannot be represented in the current code page (932)
1>main\tests\test_string.cpp(1012): warning C4566: character represented by universal-character-name '\u00B5' cannot be represented in the current code page (932)
1>main\tests\test_string.cpp(1012): warning C4566: character represented by universal-character-name '\u00BF' cannot be represented in the current code page (932)
1>main\tests\test_string.cpp(1012): warning C4566: character represented by universal-character-name '\u00FF' cannot be represented in the current code page (932)
1>main\tests\test_string.cpp(1013): warning C4566: character represented by universal-character-name '\u00B5' cannot be represented in the current code page (932)
1>main\tests\test_string.cpp(1013): warning C4566: character represented by universal-character-name '\u00BF' cannot be represented in the current code page (932)
1>main\tests\test_string.cpp(1013): warning C4566: character represented by universal-character-name '\u00FF' cannot be represented in the current code page (932)
1>main\tests\test_string.cpp(1039): warning C4566: character represented by universal-character-name '\u00BF' cannot be represented in the current code page (932)
1>main\tests\test_string.cpp(1039): warning C4566: character represented by universal-character-name '\u00B5' cannot be represented in the current code page (932)
1>main\tests\test_string.cpp(1039): warning C4566: character represented by universal-character-name '\u00FF' cannot be represented in the current code page (932)
1>main\tests\test_string.cpp(1040): warning C4566: character represented by universal-character-name '\u00BF' cannot be represented in the current code page (932)
1>main\tests\test_string.cpp(1040): warning C4566: character represented by universal-character-name '\u00B5' cannot be represented in the current code page (932)
1>main\tests\test_string.cpp(1040): warning C4566: character represented by universal-character-name '\u00FF' cannot be represented in the current code page (932)
1>main\tests\test_string.cpp(1041): warning C4566: character represented by universal-character-name '\u00B5' cannot be represented in the current code page (932)
1>main\tests\test_string.cpp(1041): warning C4566: character represented by universal-character-name '\u00BF' cannot be represented in the current code page (932)
1>main\tests\test_string.cpp(1041): warning C4566: character represented by universal-character-name '\u00FF' cannot be represented in the current code page (932)
1>main\tests\test_string.cpp(1042): warning C4566: character represented by universal-character-name '\u00B5' cannot be represented in the current code page (932)
1>main\tests\test_string.cpp(1042): warning C4566: character represented by universal-character-name '\u00BF' cannot be represented in the current code page (932)
1>main\tests\test_string.cpp(1042): warning C4566: character represented by universal-character-name '\u00FF' cannot be represented in the current code page (932)

Thanks for reporting, well the universal fix would be to replace those unicode characters by unicode literals (\u00B5), but that would make the code less readable, so I'm not sure about this.
Found related discussion in some other repository with similar configuration: abseil/abseil-cpp#85
So it makes sense to replace those characters by literals in order to stay portable between different compilers.

It does not solve it. Same as before:
warning: character represented by universal-character-name '\u00BF' cannot be represented in the current code page (932)
AND
error: error reading end of line in string literal at the end of the Upper cyrillic character literal string
I've been researching a little and found this (which is frustrating...)
https://stackoverflow.com/questions/688760/how-to-create-a-utf-8-string-literal-in-visual-c-2008
The only way for me to compile is still to encode the file in UTF-8-BOM, which gets rid of the cyrillic error, but not the warnings. But at least compiles.


Adds additional check for package

Motivation

Please give a brief description for the background of this change.

The handler was failing in the event that both dpkg and rpm were both installed
Modifications
Change summary
The verify-packages-installed handler will fail if both rpm and dpkg are installed. This fixes that.
Revision diff summary
If there is more than one revision, please explain what has been changed since the last revision.
Testing
Passed integration tests successfully.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

How can it fail if both dpkg and rpm were installed on the machine? We have the if-elseif condtional statements to check that?


Update factories.py

Hi @ruchithavemula , You meant for this to go to your fork not the upstream repo. :)


[Question]: Reproduce LLMLingua-2 on the LongBench SingleDoc dataset

Describe the issue
We referred to your code https://github.com/microsoft/LLMLingua/blob/main/experiments/llmlingua2/evaluation/compress.py, https://github.com/microsoft/LLMLingua/blob/main/experiments/llmlingua2/evaluation/eval_longbench.py
target token: 2000
compresse model: llmlingua-2-bert-base-multilingual-cased-meetingbank
llm model: Mistral-7B-Instruct-v0.1 (from https://huggingface.co/mistralai/Mistral-7B-Instruct-v0.1/tree/main)
LongBench singledoc tasks: qasper, multifieldqa_en, narrativeqa
Hardware platform: 1 Nvidia A100-80GB
The result is different from the conclusions in the paper (Table 4, LLMLingua-2-small, LongBench-SingleDoc , 2000-token cons.)
The compressed prompt evaluation score is:
{'qasper': 32.27, 'multifieldqa_en': 33.04, 'narrativeqa': 8.84}
average score 24.7 (25.3 in paper)
The uncompressed prompt evaluation score is:
{"multifieldqa_en": 37.07, "qasper": 33.83, "narrativeqa": 19.89}
30.3 (24.5 in paper)
What's the experiment settings in the paper and what makes the difference in the evaluation result. Thank you for your reply

Hi @56wangyun, thanks for your support with LLMLingua-2.
In general, you should be able to reproduce the results of Table 4 by following the steps in eval_longbench.py and compress.py. Could you provide more details, including the codebase for Mistral inference, as well as the coding environment? This information would help ensure accurate replication of the results.

Hi @56wangyun, thanks for providing the detailed information.
I believe the difference in results may indeed be attributed to the use of different Mistral models. As mentioned in the "Mistral-7B as the Target LLM" part of the Experiment section, we utilized the "mistral-7B-v0.1" model (available at https://github.com/mistralai/mistral-src) rather than the "mistral-7B-instruct-v0.1" model as the target model. Hope this information aids in replicating the results.


doc makefile skeleton

/cc @dpordomingo @Serabe
This is the skeleton for the docs makefile. Let's build on top of this.

Added python api generation to Makefile and sphinx commons

It does not use any styling from the landing. Most of the styling is done via sphinx config.

Looks pretty nice. It would be good that this repository had a .travis.yml to test itself with a dummy project. But I guess that's a completely different task.

Travis fails....
https://travis-ci.org/src-d/ci/builds/235629716

Obviously, there is no .travis.yml (and there should not be one) :stuck_out_tongue:

@david java was removed because I was told by @mcuadros we would not be having Java projects.
Scala, on the other hand, we will, but it's not yet implemented.
I don't think we should export these values from commons. We'd have to postprocess them or export them in a way that they can be put in that format, because the way to configure the sphinx theme is via the conf.py file.

@erizocosmico That was my question, if it would worth to read from the exported commons, to be in sync with the landing theme.


fix: Unable to disable page view on POST page

Issue #83

The develop branch is behind the main branch, so change to hotfix.

The develop branch is behind the main branch, so change to hotfix.

Sorry, it's not a hotfix apply, recommand to change your code to develop branch, thanks.


Possible to use with Sagemaker?

Hello,
Is it possible to use this plugin with Sagemaker? In the documentation, it looks like each Pytorch Estimator needs a .tar.gz file on S3, which seems incompatible with using this Dataset and keeping the data on S3 (rather than copying and unzipping). https://sagemaker.readthedocs.io/en/stable/frameworks/pytorch/sagemaker.pytorch.html

@jbohnslav
We're upstreaming the amazon-s3-plugin-for-pytorch into the torchdata package (https://github.com/pytorch/data/pull/165).
We're dropping support for this plugin.
I'm not sure if I understood you correctly. However, the estimator doesn't seem to require a .tar.gz file in your reference. I do see the PyTorch Model needs its model_data as a .tar.gz, but it's very irrelevant to the Dataset.

Closing the long non-responding issue.


Get latency depends on JSR 107 or not

The result of DefaultCacheStatistics.getCacheAverageGetTime depends on if JSR107 is used or not.
When using directly Ehcache, it will contain the latency to get only. When using JSR107, it will contain the latency of get, invoke, getAndPut, getAndRemove.
We should make sure it contains only get and create a specific one for JSR107 (since it is a JSR107 specification).

This solution is fine as long as this red-headed step child that is the 107 statistic is kept chained up in the basement where no one can see it. I.e. don't expose the 107 stat through the regular API.


Create a flakiness dashboard for pre-submit LUCI tests

Now we only have such for post-submit LUCI tests. Presubmit flakiness may not close the tree, but it stalls the auto roller and affects contributors

CC @keyonghan

Pre-submit flakiness dashboards are ready.


AttributeError: module 'Tami4EdgeAPI' has no attribute 'request_otp'

Hi Guy,
there must be something I'm doing wrong, or a missing resource on my environment, I'de love for some guidance,
here is my code: (taken from your example)
#!/usr/bin/env python3

import Tami4EdgeAPI

# You must add the country code!
phone_number = "+97250xxxxxxx"

Tami4EdgeAPI.request_otp()
otp_code = input("Enter OTP: ")
refresh_token = Tami4EdgeAPI.submit_otp(otp_code)
output(refresh_token)

installed the library using pip3 and running with python3
➜  tami4-auto-boil pip3 --version
pip 20.3.3 from /usr/local/lib/python3.9/site-packages/pip (python 3.9)
➜  tami4-auto-boil python3 --version
Python 3.9.1

Thanks

Hi, can you try from Tami4EdgeAPI import Tami4EdgeAPI ?
It's my mistake, I will edit the readme.

Thanks,
issue resolved!
(there was another small mistake in the readme example, Tami4EdgeAPI.request_otp should receive the phone_number as a parameter)


Point cloud can't show in hololens2

I've tried to use the hololens2 branch in unity and it works,but when I built them in hololens2, there was no reaction.
Then I rebuilt the NetworkCommunication in Release mode,but it failed and I could only ues Debug mode to rebuild.
The release mode error is MSB3073.

What is your unity version? I am trying with 2020.3, seems not working any more. GestureSettings.NavigationX etc seems no longer supported?

Unfortunately I have not tried running this in a while and I can't remember what I used last. Let me know if you figure it out and I'll update the readme.

I have the exact same problem (error MSB3073 while rebuilding the NetworkCommunication). Were you able to figure this out?

Can you post the whole error from the build process?

Thank you so much for your time! I was able to deploy the app in HL2, but
after I enter the IP address, I cannot see anything. I see the discussion
in your GitHUB and it was recommended to build the network
communication; however, when I build it (Release/ARM64) I receive this
error message:
MSB3073 The command "copy C:\Users\University of
NM\Documents\GitHub\LiveScan3D-Hololens\NetworkCommunication\Release\NetworkCommunication.dll
C:\Users\University of
NM\Documents\GitHub\LiveScan3D-Hololens\NetworkCommunication\..\HololensReceiver\Assets\Plugins\x86
copy C:\Users\University of
NM\Documents\GitHub\LiveScan3D-Hololens\NetworkCommunication\Release\NetworkCommunication.winmd
C:\Users\University of
NM\Documents\GitHub\LiveScan3D-Hololens\NetworkCommunication\..\HololensReceiver\Assets\Plugins\x86
:VCEnd" exited with code 1. NetworkCommunicationWinRT C:\Program Files
(x86)\Microsoft Visual
Studio\2019\Community\MSBuild\Microsoft\VC\v160\Microsoft.CppCommon.targets
155
Is there anything that I am missing? Thank you in advance.
Best regards,
Mahsa
On Wed, Feb 22, 2023 at 1:35 AM Marek @.***> wrote:

Can you post the whole error from the build process?
—
Reply to this email directly, view it on GitHub
https://github.com/MarekKowalski/LiveScan3D-Hololens/issues/31#issuecomment-1439622157,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/A5YQKD36UL2L5U5XUNLN4BTWYXFTTANCNFSM6AAAAAAQXOVTWY
.
You are receiving this because you commented.Message ID:
@.***>

Looks like what fails is a post-build step that copies the DLL + winmd file into the unity project. Do the directories referenced in the copy command exist? Does "C:\Users\University of NM\Documents\GitHub\LiveScan3D-Hololens\NetworkCommunication\Release\NetworkCommunication.dll" exist?
I suspect the issue may be due to spaces in the path as command line arguments do not like spaces.

Yes, it does. As I can deploy the app on Hololens2, maybe the problem is
not related to network communication. I also have some warning in Unity
saying that the 'Gesture manager' and 'object manipulator' are obsolete in
this version of unity (2018.4.14f1). I am guessing maybe the reason that I
cannot see anything on HL2 is because of that?
On Wed, Feb 22, 2023 at 12:51 PM Marek @.***> wrote:

Looks like what fails is a post-build step that copies the DLL + winmd
file into the unity project. Do the directories referenced in the copy
command exist? Does "C:\Users\University of
NM\Documents\GitHub\LiveScan3D-Hololens\NetworkCommunication\Release\NetworkCommunication.dll"
exist?
I suspect the issue may be due to spaces in the path as command line
arguments do not like spaces.
—
Reply to this email directly, view it on GitHub
https://github.com/MarekKowalski/LiveScan3D-Hololens/issues/31#issuecomment-1440706859,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/A5YQKDZS52XLVCKOF7KGUQTWYZU2VANCNFSM6AAAAAAQXOVTWY
.
You are receiving this because you commented.Message ID:
@.***>

Did you manage to resolve this in the end? Unfortunately I have not had the bandwidth to run this app on HL2 recently, so not sure I can help with the HL2 aspect of it.

Did you manage to resolve this in the end? Unfortunately I have not had the bandwidth to run this app on HL2 recently, so not sure I can help with the HL2 aspect of it.

Yes, we did. The main issue was that it was using the previous version of mixed reality without ever updating it to MRTK2. Once we updated it to MRTK2 it worked perfectly.

Hey Mahsa, I am also trying to convert the program to a newer version but i have some issues. How did you resolve the problem with the gesture control. thanks in advance.


Introduce dedicated activity groups

Currently there seems to be no need to introducing a dedicated class. The current Activity class does its work.


safer does not work on Windows

The context manager I'm using for write:
with sopen(self.fitbitjsonfn, mode='wt', delete_failures=True) as jfile:
jdump(self.fitbitjson, jfile)
Error:
FileExistsError: [WinError 183] Cannot create a file when that file already exists: 'C:\Users\edlip\Documents\code\vsc_ws\fitbit_charge\src\main\resources\base\json\tmpcwbtnzjz' -> 'C:\Users\edlip\Documents\code\vsc_ws\fitbit_charge\src\main\resources\base\json\fitbit.json'

Thanks for the clear report!  I'll get on this right now.
You are as far as I know the first Windows user, so if it's a Windows thing, I might need to experiment a little with you.
Developing!

Oh, if you had the whole stack trace, that would be great too.

So it does seem to be a Windows thing - I just pushed a test for rewriting files and it seems to work.  :-/
https://github.com/rec/safer/commit/b58ed8f0cdd913768f92f70b551ef5b53894d54c
The whole stack trace will be helpful, or I might push out a test version for you.

Also:  delete_failures=True is the default, you don't need to set it.
with sopen(self.fitbitjsonfn, mode='wt', delete_failures=True) as jfile:

can just be
with sopen(self.fitbitjsonfn, 'wt') as jfile:

Sorry for all the traffic, I hate bugs.  :-D
I'm setting up with Appveyor which allows me Windows builds for CI.  Really good to do anyway.
I only have a fairly limited slot to work on this today.  I might get it done, or otherwise, tomorrow.

https://ci.appveyor.com/project/rec/safer/builds/32685082/job/02opb49eud7cdt0k reproduces the issue.

Stack trace
Traceback (most recent call last):
File "C:\Users\edlip\AppData\Local\Programs\Python\py8Test1\lib\site-packages\safer.py", line 188, in safer_close
os.rename(temp_file, name)
FileExistsError: [WinError 183] Cannot create a file when that file already exists: 'C:\Users\edlip\Documents\code\vsc_ws\fitbit_charge\src\main\resources\base\json\tmp19i4hg6w' -> 'C:\Users\edlip\Documents\code\vsc_ws\fitbit_charge\src\main\resources\base\json\fitbit.json'
Python 3.8.2, venv list:
Package            Version

-fxparse           0.20
altgraph           0.17
astroid            2.3.3
atomicwrites       1.3.0
attrs              19.3.0
autopep8           1.5
Babel              2.8.0
base36             0.1.1
beautifulsoup4     4.8.2
cffi               1.14.0
colorama           0.4.3
cryptography       2.8
et-xmlfile         1.0.1
fbs                0.8.4
future             0.18.2
fuzzywuzzy         0.18.0
isort              4.3.21
jdcal              1.4.1
lazy-object-proxy  1.4.3
lxml               4.5.0
mccabe             0.6.1
money              1.3.0
more-itertools     8.2.0
numpy              1.18.3
ofxtools           0.8.20
openpyxl           3.0.3
orderedset         2.0.3
packaging          20.1
pefile             2019.4.18
Pillow             7.1.1
pip                20.1
pluggy             0.13.1
py                 1.8.1
py7zr              0.6
pyAesCrypt         0.4.3
pycodestyle        2.5.0
pycparser          2.20
pycryptodome       3.9.7
PyInstaller        3.6
pylint             2.4.4
pyparsing          2.0.2
pypiwin32          223
PyQt5Designer      5.14.1
PySide2            <IP_ADDRESS>
pytest             5.3.5
python-dateutil    2.2
python-Levenshtein 0.12.0
pytz               2019.3
pywin32            227
pywin32-ctypes     0.2.0
rope               0.16.0
safer              3.0.0
setuptools         41.2.0
shiboken2          <IP_ADDRESS>
six                1.14.0
soupsieve          2.0
sqlite3-backup     0.3.0
sqlparse           0.3.1
texttable          1.6.2
torch              1.5.0+cu92
torchvision        0.6.0+cu92
wcwidth            0.1.8
wrapt              1.11.2
wsgi-intercept     0.6.5
xmltodict          0.12.0

Oh, don't close this!  :-o

No rush in fixing it, it is just for me and switching back to plain open is simple

Hit the wrong button

Well, you won't be the last I hope!
Unfortunately, reading Appveyor's logs are daunting - because there are multiple issues.
https://ci.appveyor.com/project/rec/safer/builds/32685082/job/02opb49eud7cdt0k

Cannot create a file when that file already exists: this is to do with os.rename() but what?

UnicodeDecodeError: 'charmap' codec can't decode byte 0x8f in position 2: character maps to  - probably due to reading UTF-8 from that file, but that test doesn't even need to be enabled for windows.

But then tons of things like this:  AssertionError: 'hello' != 'OK!'

Which means that is just "doesn't work" - it gives the wrong answers.

Clearly there are a lot of ideas to do with Windows files I just don't understand.
I'm going to do some research;  it might be some time though.

Not sure if it applies but while researching this before opening the issue I spotted this in the built-in open
Changed in version 3.3:
The opener parameter was added.
The 'x' mode was added.
IOError used to be raised, it is now an alias of OSError.
FileExistsError is now raised if the file opened in exclusive creation mode ('x') already exists.

Sorry I didn't respond, Ed - but I still don't have any good solution for Windows development here.
Until I either get a Windows machine or a Windows collaborator, I'm probably not going to be able to fix this.  :-/
I released version 4 with a lot of new things in it and by popular demand, by default everything is now memory-cached, not file cached, so that might work better for you.

os.replace instead of os.rename seems to be the solution for Windows. It's supposed to work the same as os.rename on POSIX. According to the stdlib documentation of os.rename:

If you want cross-platform overwriting of the destination, use replace().

I'll bet that would work, but it'd be great to actually test it on Windows somehow!
I'll make that change anyway, it can hardly hurt.

Thanks for the quick change. I can confirm that this works like a charm on both Windows and Linux (at least for my use case: with safer.open(file_path, "w", delete_failures=False) as file:).
Would you mind creating a release for this change so I can install safer from pypi?

Done!!
I'm not going to close this bug because soon I will have access to a
windows machine so I can try all the edge cases, just to be sure.
On Fri, May 5, 2023 at 10:32 AM Florian Meinicke @.***>
wrote:

Thanks for the quick change. I can confirm that this works like a charm on
both Windows and Linux (at least for my use case: with
safer.open(file_path, "w", delete_failures=False) as file:).
Would you mind creating a release for this change so I can install safer
from pypi?
—
Reply to this email directly, view it on GitHub
https://github.com/rec/safer/issues/8#issuecomment-1535915983, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AAB53MRWWIR7WXRLXHTFPHLXES3JBANCNFSM4M2KN23Q
.
You are receiving this because you were assigned.Message ID:
@.***>

--
/t
PGP Key: @.***
https://tom.ritchford.com https://tom.ritchford.com
https://tom.swirly.com https://tom.swirly.com

Well, it took longer than expected, but we did seem to fix this issue and now we have a collaborator with a Windows machine!
If you're still interested, @EdLipson5117, give it a try.


Howto make text to number

As the title describe, are there some  requirement to convert text to numbers?

I assume here that the text you say corresponds to the original log, and the number corresponds to the log template.
To fairly compare model performance, I used the log template extracted by others here
If you want to extarct it by your self, I recommend using Drain which is the most effective log parsing method. Check it here! logparser.

@donglee-afar  see, thanks.

I assume here that the text you say corresponds to the original log, and the number corresponds to the log template.
To fairly compare model performance, I used the log template extracted by others here
If you want to extarct it by your self, I recommend using Drain which is the most effective log parsing method. Check it here! logparser.

Hi @donglee-afar,  the link to the extracted templated is failed. Do you have any clue or alternative?

http://people.iiis.tsinghua.edu.cn/~weixu/200nodes.rar


Fix #629

This adds a test that lints the source tree for the issue, and fixes the violations that were present.

Quoting Jason Hennessey (2017-03-16 18:22:36)

Minor feedback. Overall, I like it, though think this functionality
might better belong to something like one or more of the [1]python
linters.

I thought I'd looked through them and not found the functionality, but
pylint does seem to support this. I agree that I'd rather to it that way
than maintain our own; I'll see about swapping in that implementation.

Rather than including everything by default and using a blacklist,
could we switch to a whitelist of directories to scan (like haas,
scripst, tests, maybe examples)?

I'm worried about missing things.

Sometimes I name my virtualenv directory something without a dot at the
front to remind myself that I've created one in a particular directory,
and I don't want to get bombarded

I'm okay adding a few more things to accommodate other developers'
workflows, though of course I don't want the size of the list to spiral
out of control.  I'm sure we can come up with a small-ish number of ways
to name things that works for everyone though.  How about adding
startswith('_')?

Rather than including everything by default and using a blacklist,
could we switch to a whitelist of directories to scan (like haas,
scripst, tests, maybe examples)?

I'm worried about missing things.

We currently do this in ci/pep8_tests.sh:
  pep8 *.py tests/ haas/

Quoting Jason Hennessey (2017-03-16 22:55:49)

We currently do this in ci/pep8_tests.sh:
pep8 *.py tests/ haas/

One of the issues was in examples/, and we ought to be passing it
scripts/ as well. I think this demonstrates my point.

So I looked at each of the linters in linked from that page. Pylint is the only one that checks for this at all, and when I ran it on master it missed 2 of the 6 instances that mine caught. I agree that this is something there ought to be a generic tool for that we can just use, but the available options don't seem to be up to snuff. I'd rather maintain the solution that I wrote than use something that doesn't work properly.

@henn, ping.

@knikolla could you review this please? Thanks!

@henn, ping. I addressed your other two comments, but per my comment above I don't think the existing linters cut it. It's been almost a month since I mentioned that, and I haven't heard back.

@henn, ping. I addressed your other two comments, but per my comment above I don't think the existing linters cut it. It's been almost a month since I mentioned that, and I haven't heard back.

@zenhack - do you know why CI is complaining?

@henn, odd, the line it's referencing doesn't actually exist. There were merge conflicts now that the port_revert stuff is merged, so I fixed those, and there was an error in the brocade driver. It passes locally (but so did the old version); we'll see what travis does this time.

We currently do this in ci/pep8_tests.sh:
pep8 *.py tests/ haas/

One of the issues was in examples/, and we ought to be passing it
scripts/ as well. I think this demonstrates my point.

Would having a better whitelist seem reasonable to you?
For instance, keeping the whitelist in a single file (with examples/ added), then referencing it from here and from the pep8 test?
I'd prefer to place as few project-specific naming restrictions as we can get away with.

@henn, what do you think of generating the whitelist like this:
cd "$(git rev-parse --show-toplevel)" # Enter the soruce tree root
# list all files not matched by a .gitignore and ending in .py or .wsgi:
git ls-files $(find -name .gitignore| sed 's/^/--exclude-per-directory /') | \
	grep -E '\.(py|wsgi)$'

@henn, done. Not surprisingly, we were missing a couple of files.

Cool. Would you mind addressing my comments in tests/lint.py.
After that, I think we're good to go.

@henn, I think that's everything -- sorry for missing those on the first pass.


Repair cosmic Ray Rejection implementation

Add ability to use the cosmic ray rejection mask created in the first (ccd) pipeline

when trimming the image ccd.data, the ccd.mask attribute must be trimmed as well.

If there hasn't been a cosmic ray rejection the mask attribute is a None

The cosmic ray rejection mechanism is not working properly. We are using astropy' LACosmic, David explained to me that LACosmic was not designed for spectroscopy and suggested to use this code. I installed it and tried and seems to work much better. See the animation in full screen and zoom it if necessary.

I have finally implemented the dcr code in the redccd. There are some small issues to be solved like the dcr.par file required by dcr this is hard coded and can't be changed. The user will have to place a modified version in the raw_data directory or the program will copy a default one.

It works well. In general this will require the user to compile a code. For what I've read it is possible to compile C code when running python setup.py install by configuring setup.py accordingly but I think this should be left for version 1.0.

This is ok for the beta version.

This has been fully implemented. There is a possible problem though for data with binning different than 1x1 in such case it is necessary to change the parameters for dcr at dcr.par
Default dcr.par
THRESH	= 3.0	// Threshold (in STDDEV)
XRAD	= 9	// x-radius of the box (size = 2 * radius)
YRAD	= 9	// y-radius of the box (size = 2 * radius)
NPASS	= 5	// Maximum number of cleaning passes
DIAXIS	= 0	// Dispersion axis: 0 - no dispersion, 1 - X, 2 - Y
LRAD	= 1	// Lower radius of region for replacement statistics
URAD	= 3	// Upper radius of region for replacement statistics
GRAD	= 1	// Growing radius
VERBOSE	= 1	// Verbose level [0,1,2]
END

Modified dcr.par for data with binning 2x2
THRESH  = 2.0   // Threshold (in STDDEV)
XRAD    = 9     // x-radius of the box (size = 2 * radius)
YRAD    = 9     // y-radius of the box (size = 2 * radius)
NPASS   = 5     // Maximum number of cleaning passes
DIAXIS  = 0     // Dispersion axis: 0 - no dispersion, 1 - X, 2 - Y
LRAD    = 1     // Lower radius of region for replacement statistics
URAD    = 3     // Upper radius of region for replacement statistics
GRAD    = 0     // Growing radius
VERBOSE = 1     // Verbose level [0,1,2]
END

You can find the description of those parameter in the paper. http://adsabs.harvard.edu/abs/2004PASP..116..148P

The discussion of parameters variation is discussed here #105


docker: curl: (22) The requested URL returned error: 404 Not Found for certain plugins

UPDATE: this is no longer happening for now, but still interested in learning more
I noticed today that my build of the docker container stopped working due to plugins not being accessible
Looks like the same issue as https://github.com/jenkinsci/docker/issues/470 and maybe a couple others? Don't see anything open tho. https://github.com/jenkinsci/docker/commit/dc6193987dbe19b5c812246d01886faaf6ebb3bd says "They retry will likely get another mirror" but maybe there's a way to guarantee that?
If I remove pipeline-model-definition:1.3.1 and configuration-as-code:experimental it works. Is downtime on the plugins download site tracked anywhere? Not sure about the best place for these types of issues to be tracked. Also it's not entirely clear which URL precisely is failing.
I poked around at https://updates.jenkins.io/download/plugins/ to see if I could find a missing plugin, but both workflow-steps-api (https://updates.jenkins.io/download/plugins/workflow-step-api/) and structs seem to be available.
Docker commands that you execute
Reproduction available at https://gitlab.com/jcrben-repro/jenkins-jcasc-docker - run ./builder_jenkins.sh as mentioned in the readme
Note: the repro repo uses 2.128 but I also tried the latest tag.
Actual result
Stalls out with docker: curl: (22) The requested URL returned error: 404 Not Found for certain plugins
Expected outcome
Docker container built successfully
Have you tried a non-dockerized Jenkins and get the expected outcome?
No - specifically want to use the docker version.
Output of docker version
Client:
 Version:      18.03.1-ce
 API version:  1.37
 Go version:   go1.9.5
 Git commit:   9ee9f40
 Built:        Thu Apr 26 07:13:02 2018
 OS/Arch:      darwin/amd64
 Experimental: false
 Orchestrator: swarm

Server:
 Engine:
  Version:      18.03.1-ce
  API version:  1.37 (minimum version 1.12)
  Go version:   go1.9.5
  Git commit:   9ee9f40
  Built:        Thu Apr 26 07:22:38 2018
  OS/Arch:      linux/amd64
  Experimental: true

Other relevant information

There are some temporary issues, something for the Jenkins INFRA team to look at

Encountering this again now with jenkins/jenkins:2.133:

Seems like there's a bug here where it's not trying a different mirror.

Just experienced this myself -- were you able to find a workaround @jcrben ?

This is still ocurring. I have an automated build to create a jenkins blueocean image from the following Dockerfile:
FROM jenkins/jenkins:alpine

USER root

ARG user=root
ARG group=root

RUN echo http://dl-cdn.alpinelinux.org/alpine/edge/community >> /etc/apk/repositories && \
    apk -U add docker py-pip

RUN pip install docker-compose

RUN /usr/local/bin/install-plugins.sh blueocean

RUN rm -rf /var/lib/apt/lists/* \
    /var/cache/apk/* \
    /usr/share/man \
    /tmp/*

VOLUME /var/run/docker.sock

On the build I get lot's of 404 not found on plugins lke sse-gateway workflow-step-api that are internal dependencies of blueocean.

Hello, though this issue can occur from time to time, this is AFAICT not an issue that is specific to this repository. As @caerl

So I guess this isn't tracked anywhere? Do you mind if I open an INFRA issue, or would that just be a distraction or a duplicate?

I am having this exact same issue and not sure how to circumvent it. Can't find any other tickets related to this either.


[RFE] Add support to declare API Protection profiles

It would be nice to be able to configure API Protection profiles in a declarative fashion
I´m currently trying to develop a service to automatically deploy virtual servers that must have a different API protection profile for each one, and can´t find a way to do it besides direct iControl API requests (and that´s proving hard as the entrypoints are not documented at all)

Wrong repo, sorry

Do you have any examples/workflows/APIs you can provide to help me better understand what you are trying do to?  there are several ways to automate things on tmos.

Do you have any examples/workflows/APIs you can provide to help me better understand what you are trying do to? there are several ways to automate things on tmos.

I´m so sorry, opened the issue under the wrong repo, meant to do it under the f5-appsvcs-extension: https://github.com/F5Networks/f5-appsvcs-extension/issues/636
please close this one, sorry about the inconveniencies...


[RFC][CI] Remove simple test ci_test-base.yml

What does this PR do?
I'd like to suggest removing the workflow completely for maintainability. It also saves a few hundred MiB of cache size limit (10GB per repo).

What the workflow does
All it does is basically measuring the code coverage over pytorch_lightning by running pytest pytorch_lightning.
coverage run --source pytorch_lightning -m pytest pytorch_lightning -v

Questions
This doesn't make any sense to me, and if it does to you, I'd love to hear your answers to the following questions:

Why do we need to measure codecov here while we already do in ci_test-full.yml. To me, it looks like a complete duplicate.
https://github.com/PyTorchLightning/pytorch-lightning/blob/83436ee3dfd0d4079e0f8e704ba76aca672af19d/.github/workflows/ci_test-full.yml#L132
Mind that it runs pytest pytorch_lightning above ⬆.
Why do we run pytest pytorch_lightning to measure codecov in the first place? As far as I understand, pytest pytorch_lightning runs only doctests but doesn't run any actual tests. Is the codecov result from running doctests useful
really?

Does your PR introduce any breaking changes? If yes, please list them.
None
Before submitting

[RFC] Was this discussed/approved via a GitHub issue? (not for typos and docs)
[x] Did you read the contributor guideline, Pull Request section?
[x] Did you make sure your PR does only one thing, instead of bundling different changes together?
[n/a] Did you make sure to update the documentation with your changes? (if necessary)
[n/a] Did you write any new necessary tests? (not for typos and docs)
[n/a] Did you verify new and existing tests pass locally with your changes?
[n/a] Did you list all the breaking changes introduced by this pull request?
[n/a] Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

[x] Is this pull request ready for review? (if not, please submit in draft mode)
[x] Check that all items from Before submitting are resolved
[x] Make sure the title is self-explanatory and the description concisely explains the PR
[ ] Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?
Make sure you had fun coding 🙃 🪨 🚀
cc @borda @carmocca @akihironitta

This requires that an admin disables the "source (ubuntu-20.04, 3.9)" required check. Ping us about it when GPU ci is working again

Ok, let's as part of the PR move this simple testing so if there is an issue it fails fast


Building

Hi.
I'm encountering problems when building the library.
When I do cmake -S zxing-cpp -B zxing-cpp.release -G "MinGW Makefiles it builds everything but says that it cannot find stb module (No package 'stb' found). How do I solve this?
 How come?

With BUILD_DEPENDENCIES set to Auto, which is the default, and a working git installation, stb should be fetched by cmake automatically.
I remember having seen those warnings somewhere at some point in time. Maybe it is a compiler "bug" to complain here. Can you provide full warning message here?

With BUILD_DEPENDENCIES set to Auto, which is the default, and a working git installation, stb should be fetched by cmake automatically.
I remember having seen those warnings somewhere at some point in time. Maybe it is a compiler "bug" to complain here. Can you provide full warning message here?

Also installed Git again and I still get the stb module problem...

Those warnings are bogous. Updating your compiler might fix that.
The question is if your cmake installation sees git. I suggest you post the complete output of cmake -S zxing-cpp -B zxing-cpp.release -G "MinGW Makefiles here. Maybe that will reveal something.

The question is if your cmake installation sees git. I suggest you post the complete output of cmake -S zxing-cpp -B zxing-cpp.release -G "MinGW Makefiles here. Maybe that will reveal something.

$ cmake -S zxing-cpp -B zxing-cpp.release -G "MinGW Makefiles"                  -- The C compiler identification is GNU 8.1.0 -- The CXX compiler identification is GNU 8.1.0 -- Detecting C compiler ABI info -- Detecting C compiler ABI info - done -- Check for working C compiler: C:/mingw64/bin/gcc.exe - skipped -- Detecting C compile features -- Detecting C compile features - done -- Detecting CXX compiler ABI info -- Detecting CXX compiler ABI info - done -- Check for working CXX compiler: C:/mingw64/bin/c++.exe - skipped -- Detecting CXX compile features -- Detecting CXX compile features - done -- Setting build type to 'Release' as none was specified. -- Performing Test CMAKE_HAVE_LIBC_PTHREAD -- Performing Test CMAKE_HAVE_LIBC_PTHREAD - Success -- Found Threads: TRUE -- Performing Test COMPILER_NEEDS_FLOAT_STORE -- Performing Test COMPILER_NEEDS_FLOAT_STORE - Success -- Found PkgConfig: C:/mingw64/bin/pkg-config.exe (found version "0.23") -- Checking for module 'stb' --   No package 'stb' found INFO: Qt (Gui/Multimedia/Quick) not found, skipping Qt examples INFO: OpenCV not found, skipping ZXingOpenCV example -- Configuring done (12.0s) -- Generating done (0.1s) -- Build files have been written to: C:/zxing-cpp.release

The question is if your cmake installation sees git. I suggest you post the complete output of cmake -S zxing-cpp -B zxing-cpp.release -G "MinGW Makefiles here. Maybe that will reveal something.

I see. You actually don't have any problem, I would argue. The AUTO mode tried to detect a locally installed stb package, did not find any and then fetched the source directly from github. Do you have any compilation errors or is there anything actually not working with your build as expected?

The cmake --build zxing-cpp.release -j8 works and doesn't give me any errors, apart from the bogus warnings. Tried to open the ZXingOpenCV.exe and it works. So I guess I shouldnt worry about the stb module missing, right?

right?

right (see my explanation above).


Repeat loop bug, not able to acuumulate the value

Description:
The stringsBase64url function in our codebase is intended to convert a binary slice (Slice data type) into a Base64 URL-safe encoded slice. However, we've encountered an issue where the function's output does not match the expected length. Specifically, while the calculated size of the Base64 encoded data is correct, the resulting encoded data (Builder object) does not contain the expected number of bits.
Function:
fun stringsBase64url(bytes: Slice): Slice {
    let size: Int = bytes.bits() / 6;
    let result: Builder = beginCell();
    repeat (size) {
        let code: Int = bytes.loadUint(6);
        // ... (code-to-character mapping logic)
    }
    dump(size);
    dump(result.bits());
}

Observed Behavior:
When invoking stringsBase64url with a specific input, the expected behavior is to get a Base64 URL-safe encoded string with a bit length corresponding to the input data. However, the actual behavior observed is that while the size variable correctly represents the number of 6-bit groups, the result's bit count (obtained from result.bits()) is unexpectedly 0. This discrepancy indicates that the result object is not being populated with encoded data as intended.
Example Case:

Input: Binary slice of certain length (not specified).
Expected Output: size variable showing 44 (indicating 44 groups of 6 bits each), and result.bits() reflecting a non-zero value, representing the encoded data's bit length.
Actual Output: size is 44, but result.bits() is 0.

Impact:
This bug affects the functionality of any system component relying on Base64 URL-safe encoding of binary data, potentially leading to data loss or incorrect data processing.
Steps to Reproduce:

Provide a binary slice as input to stringsBase64url.
Observe the output of dump(size) and dump(result.bits()).
Compare the two outputs and note the inconsistency in the bit length of the result object.

Possible Areas to Investigate:

The loop logic within repeat (size) and how it interacts with the result object.
The methods storeUint and beginCell, ensuring they function as expected.
The handling of edge cases where the bytes input might lead to rounding issues or other anomalies in size calculation.

Additional Notes:

It would be beneficial to add more diagnostic logging or debugging information to pinpoint where the result object is failing to accumulate the encoded bits.
Verifying with various inputs of different lengths and patterns can help in isolating the issue further.

full code:
    fun stringsBase64url(bytes: Slice): Slice {
        let size: Int = bytes.bits() / 6;
        let result: Builder = beginCell();
        repeat (size) {
            let code: Int = bytes.loadUint(6);
            if (code < 26) {
                result.storeUint(code + 65, 8);
            }
            else if (code >= 26 && code < 52) {
                result.storeUint(code + 97 - 26, 8);
            }
            else if (code >= 52 && code < 62) {
                result.storeUint(code + 48 - 52, 8);
            }
            else if (code == 62) {
                result.storeUint(45, 8);
            }
            else if (code == 63) {
                result.storeUint(95, 8);
            }
            // dump(code);
        }
        dump(result.bits());
        // Check size Bits lengths
        size = bytes.bits();
        if (size > 0) {
            let length: Int = bytes.loadUint(size) << (6 - size);
            if (length < 26) {
                result.storeUint(65 + length, 8);
            }
            if (length >= 26 && length < 52) {
                result.storeUint(97 + length - 26, 8);
            }
            if ((length >= 52) && (length < 62)) {
                result.storeUint(48 + length - 52, 8);
            }
            if (length == 62) {
                result.storeUint(45, 8);
            }
            if (length == 63) {
                result.storeUint(95, 8);
            }
        }
        return result.endCell().beginParse();
    }

Same issue in: https://github.com/tact-lang/tact/issues/117


Spelling mistake

Describe the bug
Spelling mistake:
 must "note" be empty.
Expected behavior
 must note "not" be empty.
Screenshots

May I take this?


Integer literals in MLIL+ occasionally lose their '0x' prefix

As you can see, the integer literals in HLIL on the left are missing the '0x' prefix that they have in the disassembly on the right.
Originally, I suspected that integer literals might be limited to 16 characters by the call to sprintf when formatting them, but that's not the case and you can see inside of the if statement in the screenshot that isn't the case.
Furthermore, it seems like changing the type of the ptr argument from void* causes the token inside of the call to swift_bridgeObjectRelease to render correctly, but not the other pictured tokens starting with d0.

@jonpalmisc Could you please share a binary that reproduces this?

Here's the binary. Navigate to 1000071ac and set the type for _swift_bridgeObjectRelease to void _swift_bridgeObjectRelease(void *). You should then be able to observe the bug.
lockdownmoded.not.a.txt

You should also be able to observe this when changing the type of x0_15 (set in each switch case) to void *.

I can reproduce this. This should be a relatively easy fix


Create mobile UI

Currently, when the web page is viewed on mobile it does not scale in any way. It would be nice if the application dynamically adapted to window size.
My vision is that the user should never have to do horizontal scrolling. The width of the page should not exceed the window width unless the user has zoomed in too close to one of the controls and needs to scroll to see the entirety of it.

Figured this out in 1a01837e205497919e7c36a7f5878ed569daa626 and forgot to close this issue.


Duplicate files bug

Hi!
I had an great idea, create 200 new files but when I would delete files, I got this bug, like if I had duplicate file.

project version : v1.1.5

Can't seem to replicate the bug, to me if they exceed the screen width (at 65) they just hide behind the word & character counter.


FlyoutShowOptions

Would be nice to port UWPs FlyoutShowOptions that allows to control exact position where the flyout opens.

FWIW I didn't include FlyoutShowOptions with the Flyout PR because the Popup positioning API isn't robust enough to handle what's needed. And I think Wayland makes this harder since it has a more limited windowing API such that "open at <x, y>" may not be possible (at least that's what I've gathered, but I'm not all that familiar with Wayland). If so, maybe we could make them hints and just support them where possible?

ExclusionRect is probably trivial to implement provided the flyout content is measured, but requires the position the underlying window is opened (overlay popups can do this now by looking at the Bounds position of the OverlayPopupHost)

Position - (see above)

ShowMode and Placement I don't really see the value of including here as they're already properties on FlyoutBase

There was idea to do the opposite - and remove current flyout placement property (or deprecate it) and introduce flexible Popup properties instead - including offsets and anchor.

There was idea to do the opposite - and remove current flyout placement property (or deprecate it) and introduce flexible Popup properties instead

If the Popup positioning properties could still be set on the Flyout as attached properties I guess I would be OK with it. My instinct would be to include the same properties in both Flyout and Popup though for simplicity. Popup long term really should be more of a primitive and not used directly in apps too.

There was idea to do the opposite - and remove current flyout placement property (or deprecate it) and introduce flexible Popup properties instead - including offsets and anchor.

I'd be against that. Flyouts are really meant as a convenience wrapper around popups (over-simplification), with FlyoutPlacementMode allowing a quick way to get the popup to show at common places relative to its target. I certainly don't want to have to "experiment" with the different anchor and gravity settings and hope I get it right - rather just set BottomEdgeAlignedRight (or whatever) and be done. I don't know where the anchor/gravity stuff came from, but it doesn't exist in the microsoft ecosystem (at least I've never seen it) and I remember the trial and error I had building the flyout behavior.
Extending the current API may be appropriate, though. Offsets I could see being potentially useful and maybe the ConstraintAdjustment. But honestly, FlyoutPlacementMode really covers a lot of cases, how often do you need even more control over that other than showing a specific point on screen/the cursor (this probably should be addressed, if possible) - and if you do, you're probably building a custom control where you probably should use a popup with maximum control.
Also, WinUI extended their Popup to include DesiredPlacement and ActualPlacement properties, of type PopupPlacementMode, and those enum values are the same as FlyoutPlacementMode. So these new enum values should not be removed, if anything add them to Popup to bring parity between the two.

Flyouts are really meant as a convenience wrapper around popups (over-simplification)

But unfortunately, with current Flyout it's not possible to set Offset property at minimum. That's the biggest point of inflexibility of this control. Other popup properties...not so sure.

but it doesn't exist in the microsoft ecosystem (at least I've never seen it)

That's Wayland-like API

how often do you need even more control over that other than showing a specific point on screen/the cursor (this probably should be addressed, if possible) - and if you do, you're probably building a custom control where you probably should use a popup with maximum control.

The simplest example - add flyout to the button with Placement=Bottom, but move it slightly by 4px down adding a padding. Sounds like a typical designing task, but harder to achieve with flyouts.

These changes should be discussed together with another issue - https://github.com/AvaloniaUI/Avalonia/issues/9583 , @kekekeks.
Possibly adding attached properties is the nicest option.
Also, I had an idea of extending Flyout to support native menus. So, developers could easily set NativeMenuFlyout instance on the Button.Flyout for example. This feature would also require moving some APIs between FlyoutBase and TemplatedFlyoutBase. But I stopped (at least for 11.0) as there are no much flexibility with platform specific APIs. https://github.com/AvaloniaUI/Avalonia/discussions/8581


 Making sure it doesn't break.

Docs Build status updates of commit ac06c49:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

advocates/index.yml
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


Support hybrid test environment

This PR adds support for using a virtual OCP environment and having OpenStack computes on physical environments. The changes that are done here

Supports extra networks created by ci_nmstate
Performances all the necessary configurations to enable using of the extra networks
Enables of reading of physical nodes

As a pull request owner and reviewers, I checked that:

[x] Appropriate testing is done and actually running

/approve

/lgtm


Change Navbar dropdown menu text colour

Basic Information
Currently the navbar dropdown menu has a white text colour on top of a white background, this results in poor visibility

Other Information
[Are there any additional information that we should know about?]

Hello,
Hope you're doing well.
I was able to reproduce this issue and I tried to make some changes too so that the text in submenu is readable.
So, after changing the background color of dropdown menu items, the dropdown menu looks something like this:

Do you think this color looks fine or should I make any other changes?
Let me know your thoughts on the same.
Sincere apologies if at all you find any mistakes during this implementation.
Thanks and Regards,
Mohit Kambli

made redundant due to issue 71


Doesn't detect screen focus in fullscreen apps

Hey!
I just want to say firstly, this is a great app.
So the issue I'm having is that when I'm on a full screen app on my external monitor and I change brightness, it changes the brightness of my internal display. In order for it to recognize that the focus is on the monitor I need to switch to a different desktop on the monitor that doesn't contain a fullscreen app.
Thank you for listening!

Can you test this on the new v2.0.0? I think it should work now?

I can confirm that this happens on 2.0.0 (Build 640).

@JoniVR Yeah still seems to happen on 2.0.0

@JoniVR Hey! Do you have any thoughts on this by any chance?

Just noticed this is probably a duplicate of #30, so will continue tracking in there.
@oakif I haven't had the time to look into this yet and there's some higher priority stuff I want to get done first, but anyone is free to take a look at it 🙂