Persistent cache

readAll is very slow on slow servers (e.g. Raspberry Pi)
there should be a PHP serialized file-cache (userdata/cache/*.ser) that gets called with cron.php

I have following solution:

We check the versions of the plugins, combined with the highest UPDATE and the highest CREATE timestamp. This is our "cache id". If the cache ID changes, then we will re-create the cache completely

This is my code, not fully tested.
private $cache_id = null;
private function cache_id() {
        if (!is_null($this->cache_id)) return $this->cache_id;
        $this->cache_id  =  'Create='.OIDplus::db()->getScalar("select max(created) as ts from ###objects where updated is not null;");
        $this->cache_id .= '/Update='.OIDplus::db()->getScalar("select max(updated) as ts from ###objects where updated is not null;");
        foreach (OIDplus::getObjectTypePluginsEnabled() as $otp) {
                $this->cache_id .= '/'.$otp->getObjectTypeClassName().'='.$otp->getManifest()->getVersion();
        }
        return $this->cache_id;
}

public function readAll($noCache = false) {

// Local cache (to save time for multiple calls during the same HTTP request)
if(true !== $noCache && null !== self::$cache){
        return self::$cache;
}

// File cache (to save time between HTTP requests)
$cache_file = OIDplus::localpath().'/userdata/cache/frdl_alt_id.ser';
if (file_exists($cache_file)) {
        $cache_data = unserialize(file_get_contents($cache_file));
        $cache_id = $cache_data[0];
        if ($cache_id == $this->cache_id()) {
                return $cache_data[1];
        }
}

............

// File cache (to save time between HTTP requests)
$data = array($alt_ids, $rev_lookup);
$cache_data = array($this->cache_id(), $data);
file_put_contents($cache_file, serialize($cache_data));

// Local cache (to save time for multiple calls during the same HTTP request)
self::$cache = $data;

return $data;

}

@wehowski Can you please test it?

(The function OIDplusDatabaseConnection::getScalar() was added right now in SVN Rev 989)


'hostDir' in volume mount does not work as expected like docker -v option.

Description:
'hostDir' does not work as expected like docker -v option.
Reproduce steps:
# kubectl version
Client Version: version.Info{Major:"0", Minor:"13+", GitVersion:"v0.13.2-1-g58b98aca84becd", GitCommit:"58b98aca84becdabbfc8d719c47b375a6a1bc855", GitTreeState:"clean"}
Server Version: version.Info{Major:"0", Minor:"13+", GitVersion:"v0.13.2-1-g58b98aca84becd", GitCommit:"58b98aca84becdabbfc8d719c47b375a6a1bc855", GitTreeState:"clean"}

# cat docker-hub-gui-rc.json
{
   "kind":"ReplicationController",
   "apiVersion":"v1beta3",
   "metadata":{
      "name":"registry-ui",
      "namespace": "paas",
      "labels":{
         "name":"registry-ui"
      }
   },
   "spec":{
      "replicas":1,
      "selector":{
         "name":"registry-ui"
      },
      "template":{
         "metadata":{
            "namespace": "paas",
            "labels":{
               "name":"registry-ui"
            }
         },
         "spec":{
            "volumes": [
                {"name": "host-log", "source": {"hostDir": {"path": "/my-abc/log/"}}}
            ],
            "containers":[
               {
                  "name":"registry",
                  "image":"xa.repo.ndp.com:5000/paas/docker-registry-ui",
                  "volumeMounts": [
                      {"name": "host-log", "mountPath": "/abc/log"}
                  ],
                  "ports":[
                      "containerPort": 8080
                  ]
               }
            ]
         }
      }
   }
}

# kubectl create -f docker-hub-gui-rc.json
# kubectl get po
POD                 IP                  CONTAINER(S)        IMAGE(S)                                       HOST                          LABELS              STATUS              CREATED
registry-ui-0oq95   <IP_ADDRESS>          registry            xa.repo.ndp.com:5000/paas/docker-registry-ui   <IP_ADDRESS>/<IP_ADDRESS>   name=registry-ui    Running             4 minutes

# docker ps
CONTAINER ID        IMAGE                                                 COMMAND                CREATED             STATUS              PORTS                    NAMES
c2376dca373f        xa.repo.ndp.com:5000/paas/docker-registry-ui:latest   "/bin/sh -c /usr/sha   4 minutes ago       Up 4 minutes                                 k8s_registry.f82a2d67_registry-ui-0oq95_paas_2993d738-d789-11e4-a180-005056817c03_6c7027e9
51fa60e1b724        kubernetes/pause:go                                   "/pause"               4 minutes ago       Up 4 minutes                                 k8s_POD.b3fed21_registry-ui-0oq95_paas_2993d738-d789-11e4-a180-005056817c03_8d08b6f5
416bade71333        xa.repo.ndp.com:5000/paas/registry:latest             "docker-registry"      30 hours ago        Up 30 hours         <IP_ADDRESS>:5000->5000/tcp   serene_wright
root@paas-185:~/paas/github/kubernetes/projects/paas# docker inspect c2
...
        "Volumes": {
            "/var/lib/h2/": {},
            "/var/lib/tomcat7": {}
        },
        "WorkingDir": "/usr/share/tomcat7/bin"
    },
...
    "HostConfig": {
        "Binds": [
            "/var/lib/kubelet/pods/2993d738-d789-11e4-a180-005056817c03/volumes/kubernetes.io~empty-dir/host-log:/abc/log",
            "/var/lib/kubelet/pods/2993d738-d789-11e4-a180-005056817c03/containers/registry/c2376dca373f09de40b68f42692752c32a3b006763c93d73b06781ee8fdef7b2:/dev/termination-log"
        ],
..................
    "Volumes": {
        "/abc/log": "/var/lib/kubelet/pods/2993d738-d789-11e4-a180-005056817c03/volumes/kubernetes.io~empty-dir/host-log",    ========> why it is not "/my-abc/log"?
        "/dev/termination-log": "/var/lib/kubelet/pods/2993d738-d789-11e4-a180-005056817c03/containers/registry/c2376dca373f09de40b68f42692752c32a3b006763c93d73b06781ee8fdef7b2",
        "/var/lib/h2": "/var/lib/docker/vfs/dir/c5e8d597adfbc1d88d83e67ae02ec0f41216d4d5654073720d23ceefc2ab56f5",
        "/var/lib/tomcat7": "/var/lib/docker/vfs/dir/b3e97c6c8ca216ff81b762d2a2b33b9a98b144e283ddd14a497f276ce24ab1d9"
    },
    "VolumesRW": {
        "/abc/log": true,
        "/dev/termination-log": true,
        "/var/lib/h2": true,
        "/var/lib/tomcat7": true
    }
}
]

v1beta3 is not v1beta1 - we will write up a FAQ.
On Tue, Mar 31, 2015 at 6:48 PM, Gao Zheng<EMAIL_ADDRESS>wrote:

        "volumes": [
            {"name": "host-log", "source": {"hostDir": {"path": "/my-abc/log/"}}}
        ],

try:
"volumes": [
{"name": "host-log", "hostPath": {"path": "/my-abc/log/"}}}
],

Got it and it works well, thanks.
I got the specification from here:
https://cloud.google.com/container-engine/docs/pods/operations#pod_configuration_file.
It seems only for v1beta1. Do we have template specification of v1beta3?

v1beta3 was literally enabled today :)   We will write a FAQ doc for
converting.
On Tue, Mar 31, 2015 at 9:54 PM, Gao Zheng<EMAIL_ADDRESS>wrote:

Got it and it works well, thanks.
I got the specification from here:
https://cloud.google.com/container-engine/docs/pods/operations#pod_configuration_file.
It seems only for v1beta1. Do we have template specification of v1beta3?
—
Reply to this email directly or view it on GitHub
https://github.com/GoogleCloudPlatform/kubernetes/issues/6267#issuecomment-88349590
.

Okay, another question is when we could have a stable v1 release, both API and K8s itself?
I can not find any plan from roadmap.md and releases page. It is important for our product scheduling. Thanks again.

We're driving hard at a 1.0 release right now.  ETA is Q2 - the next few
months.  v1beta3 API is the v1 API release candidate - there should be no
more major changes before v1.
On Tue, Mar 31, 2015 at 10:01 PM, Gao Zheng<EMAIL_ADDRESS>wrote:

Okay, another question is when we could have a stable v1 release, both API
and K8s itself?
I can not find any plan from roadmap.md and releases page. It is
important for our product scheduling. Thanks again.
—
Reply to this email directly or view it on GitHub
https://github.com/GoogleCloudPlatform/kubernetes/issues/6267#issuecomment-88350519
.

Closing this as the issue seems resolved. Feel free to file more issues if you run into problems!


feat(autoFix): fix the commit message case instead of ignoring case

First step to auto fix things :-)
validateMessage() is becoming monstruous... but if there is a big refacto to come, it may not be a good idea to split it in this PR. Tell me ;-)
Close #105

Codecov Report

Merging #106 into master will not change coverage.
The diff coverage is 100%.

@@          Coverage Diff          @@
##           master   #106   +/-   ##
=====================================
  Coverage     100%   100%
=====================================
  Files           3      3
  Lines         126    133    +7
=====================================
+ Hits          126    133    +7

Impacted Files
Coverage Δ

lib/validateMessage.js
100% <100%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 888617b...a69277b. Read the comment docs.

LGMT since the new parameter is guarded in triggering the functionality needed by it. Good catch seeing that on the first round. :wink:
I wouldn't worry about refactoring V1's code. It's already mostly understood (even for its flaws.) Any refactoring as well, I'd like us to use newer tech which would mean upgrading the node version requirement. V2 is going to depend on other packages to do the heavy lifting. So that alone will clean things up a lot. I do have an active folder working on some initial experimentation for that, but it comes in between other projects. :ocean:


populate table with undeclared identifiers

One of zig's goals is to solve the "only the first compile error is useful" problem. So when "undeclared identifier" error happens, put the identifier in a table with the type set to the poison value. So there should only be 1 "undeclared identifier" error for each undeclared identifier.

Is this really worth the effort? I never watch past the first error in C++ implementations which have decades of code inside. Large number of errors actually annoys me, I need to scroll to find the first one and mentally separate it from the rest.
Exception to this is the same error over and over, like renamed item not resolved in many places.

Large number of errors actually annoys me, I need to scroll to find the first one and mentally separate it from the rest.

This is exactly the thing this would solve. So you would only get 1 instance of "use of undeclared identifier 'foo'". Then foo would be an identifier with the poison value, so anything that referenced it also got the poison value.
The poison value silences error messages.


Paginator Uses Incorrect Template

Laravel Version: 5.6.0
PHP Version: 7
Database Driver & Version: Irrelevant

Description:
In the documentation for Pagination, under Customizing the Paginator View it says:
"This command will place the views in the resources/views/vendor/pagination directory. The default.blade.php file within this directory corresponds to the default pagination view. Simply edit this file to modify the pagination HTML."
However upon editing default.blade.php it will not update the pagination HTML. This is because the incorrect view(s) is called in Illuminate\Paginator\AbstractPaginator class:
    /**
     * The default pagination view.
     *
     * @var string
     */
    public static $defaultView = 'pagination::bootstrap-4';

    /**
     * The default "simple" pagination view.
     *
     * @var string
     */
    public static $defaultSimpleView = 'pagination::simple-bootstrap-4';

You must edit boostrap-4.blade.php instead. This should be changed to default.blade.php as the documentation states and to avoid opinionated decisions about specific UI frameworks should Laravel use a different HTML structure in the future.

Confirmed. After upgrading to 5.6 my resources/views/vendor/pagination/default.blade.php stopped being used.

Just needs to be clarified in the docs. This was a recent change.

There are 2 solutions:
Option 1: Rename your pagination/default.blade.php to pagination/bootstrap-4.blade.php (could be confusing if you're not really using Bootstrap though)
Option 2: Add Paginator::defaultView('pagination::default'); to a service provider
In my case, I'm using UIKit so now I'm using Paginator::defaultView('pagination::uikit'); with a pagination/uikit.blade.php

This has also confused me. Why would default not be the default view it is using?
Upgrade guide only said it changed the template to BS4 but I thought it would just be updating default.blade.php (which I already override by publishing the vendor views).
Think I'll do what @fitztrev has said and make sure it always uses a certain view. Thanks.


Routing

Hi,
I install vue-router and try in createWindow to change the loadFile like that
updateWindow.loadFile(Path.join(app.getAppPath(), 'renderer', 'index.html#splash'));

But got an error
Not allowed to load local resource: file:///C:/laragon/www/temp/dist/win-unpacked/resources/app.asar/renderer/index.html%23splash
How I create Router
const router = createRouter({
  history: createWebHistory(),
  routes,
});

export default router;

Some help pls :) thx a lot

This error you're getting has nothing to do with VueRouter itself.
You're trying to load in an index.html file with an anchor included. That's impossible.
You want to do something like the following:
updateWindow.loadFile(Path.join(app.getAppPath(), 'renderer', 'index.html'),  { hash: 'splash' });


fix specificity for :has, :not, :is and :where

fixes : https://github.com/microsoft/vscode-css-languageservice/issues/248

:has, :is and :not now get the specificity of the most specific list item.
:where always adds zero specificity

@romainmenke Cool, thanks a lot!

Needed it in postcss-preset-env, also suggesting it here was a small effort :)
Thank you for reviewing and merging so quickly!


Markdown resize not working when Markdown added into new tab as full width

In some cases, markdown resize doesn't work. Specifically when markdown is being added into new tab.
Expected results
Should be able to resize Markdown.
Actual results
Can't resize the Markdown.
Screenshots

How to reproduce the bug

Go to Dashboard edit mode
Add new tab at the bottom of a page (or add tab within a tab)
Add Markdown into the tab
Markdown will be full width by default, and the resize (in right corner) doesn't work

Environment
(please complete the following information):

superset version: master

Checklist
Make sure these boxes are checked before submitting your issue - thank you!

[ ] I have checked the superset logs for python stacktraces and included it here as text if there are any.
[x] I have reproduced the issue with at least the latest released version of superset.
[x] I have checked the issue tracker for the same issue and I haven't found one similar.

@kkucharc

@kkucharc tested on latest master, still not working properly.
resizing works at the dashboard level, but not tab level.

Agreed. I tested this yesterday too. This is some corner case which isn't fixed yet.

Hi, thanks for testing and letting me know. This is interesting, because on latest master I was able to resize it:

Or maybe I miss some steps:

I go to dashboards
Add markdown and resize to max
Add tabs
Move markdown to tabs
Resize markdown

Can you tell me what browser are you using for testing?

@junlincc @zuzana-vej That's strange, I just tested in on the latest master and resizing does work in a tab. Though contrary to the description, Markdown isn't full width by default (though if I resize it to full width, further resizing still works)

.

Yes! Verified. Thank you!


Using pre-compiled .node modules

Hi,
I'm trying to use iohook  with this repository and I'm running into issues. I'm not sure if I should post here or in the iohook repository, or somewhere else. This is the error message I receive:
Error: Cannot find module '/absolute_path_to_project/dist/builds/electron-v64-darwin-x64/build/Release/iohook.node'

I believe my current issue is related to how webpack is set up in this project? However, I'm a novice node developer with this being my first project so I could be wrong.
It seems that for OS X users (I'm on OS X 10.15) iohook comes with pre-built .node modules that will be referenced whenever you import and attempt to use iohook. When using iohook with this project, it will attempt to reference the module here: /absolute_path_to_project/dist/builds/electron-v75-darwin-x64/build/Release/iohook.node.
However, when I check the dist folder, there is no corresponding builds folder. My guess is that something is wrong with webpack and it doesn't properly copy this .node module?
I do see an iohook.node exists at this location: ./node_modules/iohook/builds/electron-v75-darwin-x64/build/Release/iohook.node.
Another theory I have is that somehow, because of how web pack is set up, the app is attempting to look for iohook in an incorrect location? Someone else ran into the same issue I have at the bottom of this issue (https://github.com/wilix-team/iohook/issues/55), however, it is looking for iohook.node at a different location: ./node_modules/iohook/builds/electron-v75-darwin-x64/build/Release/iohook.node
If anyone could provide some guidance on this issue (even if it's just to let me know that this is an incorrect diagnosis) that would be greatly appreciated.
Possibly relevant threads:

https://github.com/wilix-team/iohook/issues/55
https://github.com/webpack-contrib/node-loader/issues/12

I included this because I added node-loader to my project so it might be related to that

10.15 had problems before. I've updated several of the dependencies, this should fix your problem as well. Please reopen if the problem persists.


Video Sync Stops Working After The Video Changes From The Initial One

A slightly annoying problem I noticed is that when the video changes (eg. the next episode starts), the chat will keep working, but the video will no longer sync. This is most likely because the <video> tag changes when the episode changes, but the event listeners are not re-added. This shouldn't be too difficult a fix.

After considering it a bit more this seems like a feature request more than a bug, since it isn't happening due to a problem with the existing code, but is instead a request for something extra to be added.


[BUG] Interaction template objects don't work in fcl.query method

Current Behavior
Calling fcl.query with an interaction template object returns an error:
Error: FCL configureDependencies Error: Unsupported template version
    at deriveDependencies (C:\flow\node_modules\@onflow\fcl-core\dist\fcl-core.js:423:13)
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
    at async prepTemplateOpts (C:\flow\node_modules\@onflow\fcl-core\dist\fcl-core.js:436:20)
    at async Module.query (C:\flow\node_modules\@onflow\fcl-core\dist\fcl-core.js:501:10)

This error occurs regardless of the value of the f_version field in the template.
Expected Behavior
Calling fcl.query with an interaction template object returns the execution result.
Steps To Reproduce
I used the following template with the goal of getting a list of staking nodes on testnet:
{
    "f_type": "InteractionTemplate",
    "f_version": "1.1.0",
    "id": "000",
    "data": {
        "type": "transaction",
        "interface": "",
        "messages": [
            {
                "key": "title",
                "i18n": [
                    {
                        "tag": "en-US",
                        "translation": "Get Stakig Nodes"
                    }
                ]
            },
            {
                "key": "description",
                "i18n": [
                    {
                        "tag": "en-US",
                        "translation": "Get a list of staking nodes for the current epoch"
                    }
                ]
            }
        ],
        "cadence": {
            "body": "import \"FlowIDTableStaking\"\n// This script gets all the info about all nodes and returns it\n\npub fun main(): [FlowIDTableStaking.NodeInfo] {\nlet staked_nodes = FlowIDTableStaking.getStakedNodeIDs()\nlet node_info: [FlowIDTableStaking.NodeInfo] = []\nfor node in staked_nodes {\nnode_info.append(FlowIDTableStaking.NodeInfo(node))\n}\nreturn node_info\n}"
        },
        "dependencies": [
            {
                "contracts": [
                    {
                        "contract": "FlowIDTableStaking",
                        "networks": [
                            {
                                "address": "0x9eca2b38b18b5dfe",
                                "network": "testnet"
                            }
                        ]
                    }
                ]
            }
        ],
        "arguments": {}
    }
}

I called it like this:
import * as fcl from "@onflow/fcl";

fcl.config({
    "accessNode.api": "https://access-testnet.onflow.org",
    "discovery.wallet": "https://fcl-discovery.onflow.org/testnet/authn",
    "flow.network": "testnet"
})

fcl.query({
    template: template
}).then(result =>
    console.table(result.map(r => ({ id: r.id, networkAddress: r.networkingAddress })))
)

Environment
- OS: Windows 11
- Node: 18.12.1
- yarn: 1.22.19
- @onflow/fcl: 1.10.1

What are you currently working on that this is blocking?
No response

The issue seems to be caused by some missing awaits in prepTemplateOpts on lines 15 and 21. This means that fcl.mutate() is also affected by this bug. I will try to publish a PR for this shortly.


MCMC over trees for posterior inference.

implement MCMC as one of the search strategies @murrellb

See #37


Sonustar patch 4

Related Issue

Issue #462
Description

adding my project and updating the JSON file.
Screenshots

please sir accept and merge my pull request

please solve the conflict error.

hello sir, I have resolved the conflict which was created in the JSON file @priyankarpal


Feat/improvement chat server

Some improvements:

reduce nested if.
Use template log instead interpolation.
Use parallel for each instead of linear for each.
add guard clauses.

Thanks again :)


Cannot list sessions for a given reviewer

After fixing #190, I discovered that listing the sessions that a given reviewer can review is no longer working.
This has not been caught by automated tests because sqlite3 doesn't apply the rules regarding group by and having clauses of SQL like MySQL does.
MySQL (https://dev.mysql.com/doc/refman/5.0/en/group-by-handling.html) doesn't allow a non-aggregated column (such as session.final_reviews_count) to be references in either a group_by or a having clause unless aliased somewhere else.
As a result, as soon as the reviewer_sessions page starts loading, the db query is performed and errors out with the following error:
ActionView::Template::Error (Mysql2::Error: Unknown column 'sessions.final_reviews_count' in 'having clause': SELECT COUNT(*) AS count_all, sessions.id AS sessions_id FROM `sessions` LEFT OUTER JOIN reviews ON sessions.id = reviews.session_id AND reviews.type = 'FinalReview' WHERE `sessions`.`conference_id` = 6 AND (`sessions`.`state` NOT IN ('cancelled')) AND (author_id <> 1 AND (second_author_id IS NULL OR second_author_id <> 1)) AND ((track_id = 26 AND audience_level_id <= 16) OR (track_id = 27 AND audience_level_id <= 17) OR (track_id = 28 AND audience_level_id <= 18) OR (track_id = 29 AND audience_level_id <= 19) OR (track_id = 30 AND audience_level_id <= NULL) OR (track_id = 31 AND audience_level_id <= NULL)) AND (reviews.reviewer_id IS NULL OR reviews.reviewer_id <> 1) AND (final_reviews_count < 3) GROUP BY sessions.id HAVING count(reviews.id) = sessions.final_reviews_count):
    1: - title t('actions.reviewer_sessions', count: @sessions.total_entries)

The SQL fix is simple:
SELECT COUNT(*) AS count_all, sessions.id AS sessions_id, sessions.final_reviews_count AS sessions_reviews_count FROM `sessions` LEFT OUTER JOIN reviews ON sessions.id = reviews.session_id AND reviews.type = 'FinalReview' WHERE `sessions`.`conference_id` = 6 AND (`sessions`.`state` NOT IN ('cancelled')) AND (author_id <> 1 AND (second_author_id IS NULL OR second_author_id <> 1)) AND ((track_id = 26 AND audience_level_id <= 16) OR (track_id = 27 AND audience_level_id <= 17) OR (track_id = 28 AND audience_level_id <= 18) OR (track_id = 29 AND audience_level_id <= 19) OR (track_id = 30 AND audience_level_id <= NULL) OR (track_id = 31 AND audience_level_id <= NULL)) AND (reviews.reviewer_id IS NULL OR reviews.reviewer_id <> 1) AND (final_reviews_count < 3) GROUP BY sessions.id HAVING count(reviews.id) = sessions_reviews_count);

(Note the extra AS for reviews count at the select level)
Unfortunately, ActiveRecord builds the count call in https://github.com/rails/rails/blob/b88220732dffe336a0814bb91a4f5acc6e91e508/activerecord/lib/active_record/relation/calculations.rb#L300. When it does so, the only AS fields that are gathered are the ones of the group_by clause.
So we either have to find a way to change that query to remove the group_by and having clauses when counting (unlikely) or add the extra aliasing without changing the results.
This is likely an issue introduced by #114 as Rails 4 did a bunch of optimizing with the Arel queries which likely included simplifying the count queries.

@hugocorbucci I really don't know rails so well like you and others, but if the AR querying API is limiting a little bit we could introduce a view on the database and map it to a new model as a temporary workaround until finding a permanent solution.
It is really not pretty, but it may be a fast way to  solve the problem.

@lcobucci it would be possible, but there is a lot of logic that build this query, that would has to be moved into a view or procedure and It would consume a lot of effort as well and the final solution would be terrible.
I tried a fix in PR 192 => https://github.com/agile-alliance-brazil/submissions/pull/192

#192 makes the count of the number of sessions to review wrong (it combines the groups).
As a result, pagination doesn't work either which serious limits how many can be reviewed.

As I said before, I'm don't know ruby nor rails, but I don't see why something like this would be so terrible (as an attachable and easy to remove workaround):
CREATE VIEW session_for_review AS
SELECT
    sessions.id AS sessions_id,
    COUNT(*) AS count_all,
    sessions.final_reviews_count,
    sessions.conference_id,
    sessions.state,
    sessions.author_id,
    sessions.second_author_id,
    sessions.track_id,
    sessions.audience_level_id,
    sessions.created_at,
    reviews.reviewer_id,
    reviews.type
FROM sessions
LEFT OUTER JOIN reviews
    ON sessions.id = reviews.session_id
GROUP BY sessions.id
HAVING count(reviews.id) = final_reviews_count;

class SessionForReview < ActiveRecord::Base
  # Mapping information and other things...

  scope :for_conference, ->(conference) { where(conference_id: conference.id)}
  scope :not_author, ->(u) {
    where('author_id <> ?  AND type = '#?'"', user.id, review_type)
  }

  scope :for_preferences, ->(*preferences) {
    return none if preferences.empty?
    clause = preferences.map { |p| "(track_id = ? AND audience_level_id <= ?)" }.join(" OR ")
    args = preferences.map {|p| [p.track_id, p.audience_level_id]}.flatten
    where(clause, *args)
  }

  def self.for_review_in(conference)
    sessions = for_conference(conference).without_state(:cancelled) # I don't if this works =P
    if conference.in_early_review_phase?
      sessions.submitted_before(conference.presubmissions_deadline + 3.hours)
    else
      sessions
    end
  end
end

I'm cloning the repo and will try something like this.

Sorry guys, I won't be able to try that approach. I can't provision the bundled VM =/
It goes well until the provision start: https://gist.github.com/lcobucci/d1623c04bca7f14f1701
Anyway... good luck there :smile:

@lcobucci Mainly this is pretty hard to implement because of the coupling ActiveRecord imposes between your database and your code. To use your view, I'd have to identify anything that uses sessions in those contexts.

@lcobucci Having said that, I have no idea why your VM is not provisioning correctly. I'd have to find that out.

Ok! Seems like 337ac17 actually fixes both the pagination as well as the count and the rest of the stuff.
So I'm closing this up for now. We'll reopen if we have new problems.
Regarding the VM, @lcobucci it'd be better to open another issue with details.

Perfect @hugocorbucci! I'm glad that the issue is solved.
Sorry for being persistent on the suggestion.
I'll open an issue for the VM with more information.


Support variant serialization/deserialization for the latest Ergo runtime

Is your feature request related to a problem? Please describe.
Ergo 0.20.* relies on a few changes to the Concerto serialisation that have to be consistent with the Ergo JavaScript run time. The changes include:

Alternative representation for enums consistent with the new typed enums in Ergo
Alternative representation for Integer and Long values to ensure proper printing in toString and in the templates support
Additional option for serialisation of relationships

This should be controlled by a proper option on the serialiser and ensure backward compatibility when that option is turned off (which should be the default).
Describe the solution you'd like
Fold changes for that serialization from the Ergo 0.20 branch into Concerto, which avoid much code duplication and provides for better and more systematic testing.
Additional context
This is part of a core refactoring for the 0.20 release. This change will also facilitate review and discussion for improvements in future releases.

Initial code for this can be found in https://github.com/accordproject/ergo/commit/500b0f7c2963577c0ad92eea11a5749720d69e54
PR which supports this new option and passes all the tests is available at:
https://github.com/accordproject/concerto/pull/111

Fixed in #111


How to obtain the 'th_trans' values for the MANO model

Hi,
Great work! How do you obtain the 'hand_info['trans']' during annotation? To my knowledge, the translation vector of the hand should be a part of the 'theta' parameter. Did you also optimize this translation vector?

Hi Toytiny,
We have jointly optimized the translation vector and 48D rotations via the hand pose annotation process mentioned in our paper. Our loss functions are defined in Equation 1 and 2, and details are introduced in the appendix. Hope it can help you.


Attach Maven artifact with project sources

You'll need the following in your pom.xml:
<plugin>
  <groupId>org.apache.maven.plugins</groupId>
  <artifactId>maven-source-plugin</artifactId>
  <executions>
    <execution>
      <id>attach-sources</id>
      <goals>
        <goal>jar</goal>
      </goals>
    </execution>
  </executions>
</plugin>

Already there
https://github.com/radekpakula/pdf-viewr-addon/blob/vaadin8/pdfviewer-addon/pom.xml

Hmm, mvn install seems to produce a correct assembly ZIP file, but sources jar is not in the directory. Compare these two links:
http://vaadin.com/nexus/content/repositories/vaadin-addons/pl/pdfviewer/pdfviewer/1.3.5/
http://vaadin.com/nexus/content/repositories/vaadin-addons/de/steinwedel/vaadin/addon/messagebox/4.0.21/


"Sharing settings" doesn't work

When getting a share setting link, the link takes you to the page, and has the data for the Wikipedia pages, put doesn't then actually enter them into the settings. This doesn't work on firefox, edge and chrome.

Which browser versions are you using?
It works for me using
Chrome Version 120.0.6099.216
Firefox 121
Can you still reproduce the error in private mode? Could be some extensions interfering

cant reproduce

0x98F0d68C0a69B869260e7CB78341FeAF3d03fb0c


Accessing the replications

Hi,
I'm currently using the artifactory-client-java library to automate the configuration of our Artifactory server.
One of my automation rules relates to the configuration visible in the Replications tab (the web page where you can find the "Enable Active Replication of This Repository" checkbox).
Does the API currently support the calls to these REST services Update Repository Replication Configuration or Create or Replace Local Multi-push Replication  ?

I checked the API again and since it seems that the replication-related features are missing, I'll try to add them in a pull request.

I have pushed some changes on my GitHub fork here. Will create a PR when I think the code is good enough and you have merged this.
Note: I'm aware that I'm probably opening a can of worms by implementing this feature. I'll try to keep the API as consistent as possible.

I'm adding tests to the PR ...

I just pushed some (12) integration tests for the replication features


Docker image does not have the correct version set

Due to how the image is built, the version is not passed to the github  docker/build-push-action and therefore the version is not recorded in the docker image.
Either fix the workflow or build the image manually

should be fixed now by using goreleaser


When provisioning Hosted downstream clusters, the external/internal addresses are missing in the Cluster Management -> Machine Pools Page

Setup:

Rancher version: v2.7.2-rc6 and v2.7-head (Commit ID: 6ee3949)
Browser type & version: Brave

Describe the bug:
When deploying a downstream Hosted cluster, the external/internal IP does not appear in the Cluster Management > Machine Pools page
To Reproduce:

Spin up a Rancher server
Provision an Azure AKS downstream cluster
Once the cluster comes up Active, navigate to the Cluster Management > Machine Pools page for the cluster

Note that the external/internal IP addresses are missing

Result:
The external/internal IP addresses are missing in the Cluster Management > Machine Pools page for downstream Hosted clusters.
Expected Result:
The external/internal IP addresses SHOULD NOT be missing in the Cluster Management > Machine Pools page for any clusters.
Screenshots:

Additional Information:
This issue does not reproduce for RKE2, K3s, or RKE1 downstream clusters
This issue is related to issue 7802

Will check once we complete migrating AKS from Ember to Vue.

I have not been able to reproduce this issue using default values to provision AKS, nor when importing AKS clusters

This seems to be fixed in 2.9 as I was not able to reproduce it using default values to provision AKS cluster.


--policy-assignment parameter is incorrectly defined.

With reference the the following AZ CLI docs page: https://docs.microsoft.com/en-us/cli/azure/policy/state?view=azure-cli-latest
There are 2 references on this page to the definition of the "--policy-assignment" parameter. Both are incorrect.
The 2 references currently show:

The correct definition is not the NAME of the Policy Assignment, it is the last alpahnumeric pattern of the assignment ID.
Looking at a policy assignment in the Azure Portal, it is the highlighted string below:

Kind Regards.... Jukius Davies

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: ca46c96d-8c88-7c4a-d75f-1c6c45d0f75c
Version Independent ID: 9b8bdef9-8f67-7e82-1ae8-9356b62e84b0
Content: az policy state
Content Source: src/azure-cli/azure/cli/command_modules/resource/_help.py
Service: azure-resource-manager
GitHub Login: @rloutlaw
Microsoft Alias: routlaw

add to S176

In fact, the policy assignment name is the suffix of policy assignment ID in CLI:

So this should be a issue of Portal: the original Assignment name should make it clear that it is Assignment display name and show the real Assignment name to avoid misleading users.

In fact, the policy assignment name is the suffix of policy assignment ID in CLI:

So this should be a issue of Portal: the original Assignment name should make it clear that it is Assignment display name and show the real Assignment name to avoid misleading users.

To the best of knowledge, the standard across Azure Portal is to have Name = display. However, I see how the CLI documentation stating Name of policy assignment, but actually meaning ID of policy assignment can be confusing. I have submitted a request to update. Thank you.

To the best of knowledge, the standard across Azure Portal is to have Name = display. However, I see how the CLI documentation stating Name of policy assignment, but actually meaning ID of policy assignment can be confusing. I have submitted a request to update. Thank you.


Adding Chinese support

Add Chinese support, in order to improve the development of the project

Hey @AFLDT  You are willing to contribute? https://github.com/kerberos-io/agent/issues/47

Well done @AFLDT !!


addition of py_ast

The dataset consists of parsed Parsed ASTs that were used to train and evaluate the DeepSyn tool.
The Python programs are collected from GitHub repositories
by removing duplicate files, removing project forks (copy of another existing repository)
,keeping only programs that parse and have at most 30'000 nodes in the AST and
we aim to remove obfuscated files

Hi @reshinthadithyan !
As mentioned on the Slack, it would be better in this case to parse the file lines into the following feature structure:
"ast": datasets.Sequence(
    {
        "type": datasets.Value("string"),
        "value": datasets.Value("string"),
        "children": datasets.Sequence(datasets.Value("int32")),
    },
)

Here are a few more things to fix before we can move forward:

the class name needs to be the CamelCase equivalent of the script name, so here it will have to be PyAst
the README.md needs to have the tags at the top
The homepage/info list at the top should be in the same format as the template (added a suggestion)
You should add the dataset tags and field description to the README as described here: https://github.com/huggingface/datasets/blob/master/ADD_NEW_DATASET.md#tag-the-dataset-and-write-the-dataset-card

Good luck, let us know if you need any help!

Hello @yjernite, changes are made as we talked. Hope this would suffice. Thanks. Feel free to point out any room to improvement.

Good progress! Here's what still needs to be done:

first, you need to rebase to master for the tests to pass :)
the information in your Data Fields paragraph should go into Data Instances. Data fields should describe the fields one by one, as in e.g. https://github.com/huggingface/datasets/tree/master/datasets/eli5#data-fields
you still need to add the YAML tags obtained with the tagging app

Should be good to go after that!

Hello @yjernite, changes as talked are being done.

Looks like this PR includes changes about many other files than the ones for py_ast
Could you create another branch and another PR please ?


Upgraded to v0.30.0 and get "Whoops, looks like something went wrong." when saving/editing

So, in Bookstack I see all my entries, can view anything jsut fine (it seemed ok after the latest update based on that).
But, once I add a new entry or try to save an edited entry in a book, I get the above "Whoops" error with nothing else to go on. Everything was working fine before this version. (I think it was v29)
I run this on Linux using the Docker container:
linuxserver/bookstack@sha256:9d5df6d504263a6f41a0ceae25f00e563f298bbf3fd411cc7755a8ea57633287
During the update, the bookstack container logs offered this info:
Running config - db_user set
/var/run/s6/etc/cont-init.d/50-config: line 77: warning: command substitution: ignored null byte in input
/var/run/s6/etc/cont-init.d/50-config: line 77: warning: command substitution: ignored null byte in input
Migrating: 2020_08_04_111754_drop_joint_permissions_id
Migrated:  2020_08_04_111754_drop_joint_permissions_id (0.7 seconds)
Migrating: 2020_08_04_131052_remove_role_name_field
Migrated:  2020_08_04_131052_remove_role_name_field (0.05 seconds)
Migrating: 2020_09_19_094251_add_activity_indexes
Migrated:  2020_09_19_094251_add_activity_indexes (0.15 seconds)
looking closer at various logs, I notice this error in the /bookstatck/log/ngix/error.log (edited to remove specific details):
2020/09/22 13:47:02 [error] 548#548: *85 FastCGI sent in stderr: "PHP message: PHP Warning:  Unknown: POST Content-Length of 275 bytes exceeds the limit of 100 bytes in Unknown on line 0" while reading response header from upstream, client: <IP_ADDRESS>., server: _, request: "POST /books/bookname/draft/76 HTTP/1.1", upstream: "fastcgi://<IP_ADDRESS>:9000", host: "books.server.com:6876", referrer: "https://books.server.com:6876/books/bookname/draft/76"
Hoping someone might help me understand more about what's going on here. Is it possible to go back to a previous version with the same database (or has the db been changed now).
Any help appreicated, Thanks

Turns out simply restarting the container and I found it working. Still testing.
More on this here: https://github.com/linuxserver/docker-bookstack/issues/64

Hi @cwldev, Yeah, You likely encountered the linked linuxserver.io issue. The pull request on their side to fix this has been merged so the latest containers should be fine although you may have needed a restart or two for the faulty file to be updated then picked up by the container. Will therefore close this.


fix(ios): fix placeholder flicker on iOS. #10733 11844

Short description of what this resolves:
This resolves a flicker that happens on iOS when overscrolling a page containing inputs with placeholder attributes. See #11844 and #10733 for examples
This might be needed in v4 as well, haven't tested it.
Changes proposed in this pull request:

Changes placeholder to be position: absolute and adjusts its positioning with translateY. This specific change fixes the flicker
Removes the position: static on .item-input ion-input which defaults it back to position: relative.

Ionic Version: 3.x
Fixes: #10733 and #11844
Unclear about the implications of the position: static change. In my testing of a few of the form tests I didn't notice any issues.

Need to add a quick tweak to get the input cover sizing back to normal

Don't merge this yet, needs some more work to fix the input-cover and also get the placeholder working with all the various input types

Hi there! We're going to be closing this as the repo is now organized for V4. For V3 related issues/PRs, please direct them here
https://github.com/ionic-team/ionic-v3
Thanks!


Calling non-existent static method does not produce an error

This code shouldn't type check, since goodbye isn't declared as a static method on C:
/** @flow */
class C {
  static hello(): string {
    return 'hello';
  }
}

function foo() {
  var hello = C.goodbye();
}

However, it type-checks with no errors under Flow 0.9.2.

@avikchaudhuri wrote

Static properties are only checked for consistency. So currently you won't get an error if a static property doesn't exist, but you should get an error if you set it to something and use it like something else.

We do this because we find people adding static properties to classes on the fly, so we can't make the set of static properties fixed at class definition time.

Hmm, ok, so this is currently the expected behavior. It would be nice to figure out some other compromise, like the one we have for object types, where you can add properties initially, but not after it is "sealed". Or maybe there should be some way to declare a class "sealed" or something like that.

I'm not sure that this is expected behavior.  I think that static properties are the outlier because ES6 classes do not admit inline static properties:
class D {
  static ngProperty = 5; // Error under ES6 classes
}
D.okProperty = 5; // This is ok under ES6 classes

Static methods are written inline, so I don't think that the static properties caveat applies.  At least I don't think that it should apply.
(I expect that my code fragment will fail under Flow without an explicit static okProperty: number in the body of D.  A D.someFn = function () { ... } case is kind of interesting:  maybe it warrants a warning, since Flow does a better job with static someFn... implemented in the class body?)

This has been fixed, closing.


Tv2 sync release47

This PR contains a few of the latest changes from TV2/develop.
Co-authored by @LindvedKrvang and @jstarpl

Codecov Report
Base: 68.09% // Head: 68.10% // Increases project coverage by +0.00% :tada:

Coverage data is based on head (d94326c) compared to base (ab0b3c1).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           release47     #780   +/-   ##
==========================================
  Coverage      68.09%   68.10%
==========================================
  Files            278      278
  Lines          34708    34708
  Branches        4639     4639
==========================================
+ Hits           23636    23637    +1
+ Misses         10631    10630    -1
  Partials         441      441

Impacted Files
Coverage Δ

meteor/lib/lib.ts
70.05% <100.00%> (ø)

...ver/lib/customPublication/optimizedObserverBase.ts
82.60% <0.00%> (+0.86%)
:arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


[Fix] Prevent circular block references and transclusions

It is currently unclear what would happen is such a case. Memory "overflow"?

Implemented in #144


Getting the map name from its file name?

Hi!
Is there an easy way to reconcile a JSON file from the "Grinding Stats" folder to the map it belongs to?
While browsing the code (I am not an ActionScript developer), I assume this line is responsible for naming the file using the map's IdName?

the file is stored as the mapid.Jason, there isn't that easy of a way to get the name of the map from the I'd that I know of.

Is the mapId only a value that's internal to Trackmania? Or can I find it on third-party apps like TMX or Trackmania.io?

it is used on TM.io, but i dont think it is used on tmx
im sure theres a way to use nadeo's api to get information from the mapid, but i dont know how exactly to do it.
to get the trackmania.io page for the track, just append it to this url https://trackmania.io/#/leaderboard/


Updated astropy_helpers

CC @eteq - please check me on this when you get the chance.

I'm closing this because I updated to master rather than the release version. @eteq - you can now officially ignore my original request for a spot-check on this, I've played around with the helpers enough to know how to do this now.


Fixed read_frame #126.

This PR addresses #126, fixing the UnboundLocalError.

Thank you for the PR!


Add a function(s) to filter NuSTAR event lists and produce final event lists

This will largely be stage 2 of the nupipeline I think - we have all the spacecraft files we need, and the supporting hot/bad pixel files for each instrument, now we want to take the unfiltered, but calibrated, event lists and turn them into something more suitable for scientific use. This will involve searching for flares and removing bad time intervals (including times where the earth gets in the way, etc.).

Yeah I do think that the file path length is what is causing the issue...
This is really quite irritating - maybe I'll have to make my own event list symlink. I just don't know why it is trying to use the absolute path to open the bloody file

The ffilecat error occurs when xselect tries to read event list file headers I think - for some reason it still seems to use the absolute full path even though nudas creates a symlink.

Perhaps there is a path in one of the header values it tries to read and is too long? I doubt it, because I did run a test on the Desktop using mostly the same setup but pointing to a DAXA generated event list. So in that case am I even on the right track here?

Stage 2 will definitely run when given standard inputs bar the input event list file (and it is using the event list file I specify) - the command I ran is this:
nupipeline indir='/Users/dt237/Desktop/60061248002' fpma_infile='/Users/dt237/code/test_daxa/daxa_output/archives/process_nustar_test/processed_data/nustar_pointed/60061248002/events/obsid60061248002-instFPMA-subexpALL-en-events.fits' outdir='outputs' obsmode='SCIENCE_SC' steminputs='nu60061248002' instrument='FPMA' entrystage=2 exitstage=2 inmastaspectfile='/Users/dt237/code/test_daxa/daxa_output/archives/process_nustar_test/processed_data/nustar_pointed/60061248002/misc/obsid60061248002-mast.fits' fpma_inoptaxisfile='/Users/dt237/code/test_daxa/daxa_output/archives/process_nustar_test/processed_data/nustar_pointed/60061248002/misc/obsid60061248002-instFPMB-subexpALL-optaxis.fits' fpma_indet1reffile='/Users/dt237/code/test_daxa/daxa_output/archives/process_nustar_test/processed_data/nustar_pointed/60061248002/misc/obsid60061248002-instFPMA-subexpALL-refpixel.fits' inpsdfilecor='/Users/dt237/code/test_daxa/daxa_output/archives/process_nustar_test/processed_data/nustar_pointed/60061248002/misc/obsid60061248002-psd.fits' clobber='yes' chatter='4'

It does work for SCIENCE mode.
So my next thought is that the daxa output directories are what is pushing it over the edge?


Invalid FiniteGroups.block_decomposition function

The point group reducible representation satisfies the group multiplication at a precision of 10**-10. But the block_decomposition function seems to give the wrong results.
I attached a python code that could reproduce the wrong results.
In the code, 'PG_WingerD_Reps' is a 676-dimensional reducible representation of C3i, and the PG_Winger_D_deccom are some  irreducible representation which is decomposed from  'PG_WingerD_Reps'. But all two-dimensional representations in PG_Winger_D_deccom seem irreducible.
issue.zip

The error was caused by the complex data type of the irreps. Previously, for a given irrep of type Vector{Matrix{T}}, the reality of T was used to identify the reality of the representation (if the argument R=true and the irrep is complex, the function returns a real projection to the real irreps). However, when all irreps are calculated by function irreps, the real and complex representation coincide and Julia promote the output array to be of type Vector{Vector{Matrix{ComplexF64}}}, which further cause the reality ambiguity.
In this update, the imaginary part of the irreps are explicitly checked before invoking the real-irrep algorithm.


Add playAll() and playSync()

Attempt at #228.   See example for usage.
My use case is: "X minutes, Y seconds" which is comprised of 4 files (X.mp3, Y.mp3, minutes.mp3, seconds.mp3) and X & Y are numeric between 0 to 60, requiring only 62 files vs. 3600! if spoken as one sentence.
Possible additions:
[ ] Add a loop: true/false parameter
[ ] others?...

Let me know if this is going in the right direction -- I can work on updating the readme and other docs.
Also, what do you think of renaming playAll() to playList()?  In fact it'd be great if the list was made available so it could be added to (or removed from).
p =  player.playList(['foo', 'bar']);
// little later
p.playlist.add('baz');

Also nice-to-have is to know when the list has finished.  So maybe an onPlayListCompletion !?

hi, can you also add to your feature loading next songs (with choose option of how much songs to load ahead).

You will need multiple audio players and just use set URL on each and when you want to play next use resume.

I like playSequentially or similar more than playAll.

This PR is quite outdated and haven't got updates in a long time. Closing this. If the author wants to continue working on this, just lets us know and we can re open the PR.


Make datadelivery group optional in inventory

With this PR, when there is no datadelivery group in the Ansible inventory, the head node of the cluster will be used (i.e. hosts under the group lrms_server in the inventory.

Very good - this is the simple setup I use also when using frontend-server as the datadelivery server.


Clarification about the data licence - CC BY-NC-SA 4.0 or not

Thanks for sharing this work. Not sure if this is the best place to ask questions about the dataset but I thought GitHub would be an easier reference for others than private emails.
Looking at the EpiSurg dataset I can see the custom "Data use agreement" but the landing page also has a "CC BY-NC-SA 4.0" badge as shown below:
https://doi.org/10.5522/04/9996158.v1
The README in the zip file refers to the "Data use agreement" but doesn't mention CC BY-NC-SA 4.0 or any other restriction.
Could you clarify if CC BY-NC-SA 4.0 applies and if not maybe ask UCL to remove the badge?

Hi, @tvercaut. Sorry for the delay, I've been on holiday. I will investigate this and get back to you. Are you interested in using the dataset?

Maybe @HChughtai could also provide some advice.

Hi @fepegar - not the remit of the team I'm part of, but I believe that license is chosen by the uploaders when they create an entry on the UCL Research Data Repository. You may want to contact the helpdesk email address on that page for clarification and for modification if you can't do so yourself directly.

Thanks @fepegar, yes we have been discussing about using this dataset with Rachel and @aaronkujawa. I just need to make sure it won't be a problem in terms of licensing.

@fepegar @rsparks : Would you have any update on this issue?

@tvercaut, sorry for the delay in response I am not @rsparks on here so did not receive the original query. I am afraid this dataset is currently available only for non-commercial purposes so the CC-BY-NC-SA-4.0 does apply. Happy to have a more detailed conversation to potentially seek a more permissive license if you would like to use this for commercial purposes.

Oops. Sorry, Rachel!

Thanks Rachel. I would suggest clarifying this on the landing page under "Data use agreement" and also highlight this in the zipped dataset itself. The option of a permissive licence would of course be interesting. I'll catch-up offline on this.


New map listeners

Make map changes more efficient

Very nice, clean work on all of these commits.
Minor nits (not worth iterating on):

Commit titles should be in imperative form. "Improve flatten" vs "Improved flatten," "Add new _update helper for maps" vs "New _update helper," etc.
Commit titles should be capitalized.
You don't need rx.snap to just inspect things in the specs.
Bonus if you can also submit doc updates on relevant changes (e.g. changed rx.flatten, showing off its new power).

I'm cutting a new release for the breaking change.
I also need to add you to the contributors.


Use go-lru for caching / session store

Feature Description
go-lru from harshi corp is thread safe and also has ability to store ttl.
adding ttl to session tokens will automatically clear them on failure

https://github.com/hashicorp/golang-lru

Describe the solution you'd like

Describe alternatives you've considered

Additional context

Decided to use internal cache with clearing worker #343


To Add UnRegister Drop Event when Page Unload

Issue:
The Drop event did not unregister when "UnRegisterDrop" was called
Description:
As the previous discussion, the drop event is not unsubscribed when "unload" the page even calls "UnRegisterDrop" at "OnDisappearing" shell lifecycle methods. The main reason why is that UIElement.Drop does not unsubscribed drop event in the "UnRegisterDrop" function.
Solution:
To unregister the Drop Event, add the OnDrop function. When "RegisterDrop" is called, subscribe OnDrop event. When "UnRegisterDrop" is called, unsubscribe OnDrop event.

Thank you for your contribution! I prefer to keep the method signature the same on all platforms.
I made changes to unsubscribe from DragStarting and Drop events.


Export Merged File to Source Path

Is your feature request related to a problem? Please describe.
When merging my footage, I'm working completely off of a USB storage device to keep my footage organized for a large project. It's more annoying to have to dive into the ReelSteady-Joiner project directory in Documents for each joined file and move them into the source path, or change the project directory every time I need to join footage from different folders on a single project on the external device.
Describe the solution you'd like
It would be nice to have an option for the _joined file exported to the same directory as the source footage similar to where the _smoothed file ends up for ReelSteady and GyroFlow.
Describe alternatives you've considered
There aren't any currently.
Additional context
Working on large projects with FPV footage dispersed into multiple folders for multi-person teams makes this more difficult to manage. A simple feature like this would easily improve the workflow.

This is not a priority, but it seems to me a good option, for future versions I will add an option that allows the video files to be saved as you explain.


SFO production data page enforces all products to be reported on

Description:
If the operation is an SFO, the products should start all selected, and the user shouldn't have the option of de-selecting them
Acceptance Criteria:
Given I am an SFO operator
When I report production data
Then I see a page with all products selected
And I am not able to deselect them
Development Checklist:

[ ] Checklist item
[ ] Checklist item
[ ] Checklist item
[ ] Meets the DOD

Definition of Ready (Note: If any of these points are not applicable, mark N/A)

[ ] User story is included
[ ] User role and type are identified
[ ] Acceptance criteria are included
[ ] Wireframes are included (if required)
[ ] Design / Solution is accepted by Product Owner
[ ] Dependencies are identified (technical, business, regulatory/policy)
[ ] Story has been estimated (under 13 pts)

Definition of Done (Note: If any of these points are not applicable, mark N/A)

[ ] Acceptance criteria are tested by the CI pipeline
[ ] UI meets accessibility requirements
[ ] Configuration changes are documented, documentation and designs are updated
[ ] Passes code peer-review
[ ] Passes QA of Acceptance Criteria with verification in Dev and Test
[ ] Ticket is ready to be merged to main branch
[ ] Can be demoed in Sprint Review
[ ] Bugs or future work cards are identified and created
[ ] Reviewed and approved by Product Owner

Blocked By/Blocking
Notes:

@patriciarussellCAS to determine if this is required for the app to pass all necessary controls


Update README.md

I updated the setup instructions to use the buildpack published in Heroku's Buildpack Registry.

Great! Thanks!


[Warhammer 4e Character Sheet] v1.61 - Armor Tab update

[ ] The pull request title clearly contains the name of the sheet I am editing.
[ ] The pull request title clearly states the type of change I am submitting (New Sheet/New Feature/Bugfix/etc.).
[ ] The pull request makes changes to files in only one sub-folder.
[ ] The pull request does not contain changes to any json files in the translations folder (translation.json is permitted)

Changes / Description

Updated Armor Tab - There is now 3 (Light/Medium/Heavy) Equip/unequip buttons at the top of the tab. This allows quicker equipping and unequipping of Armor for players. Also all Equip/Unequip and Worn/Unworn actions in this tab now automatically activate or disable the corresponding Armor penalties.

Character Sheet Info Roll20 Internal Use only.


Incorrect color highlighting for React Components

left is theme in vscode (correct)
right is theme in Zed (incorrect)

🤔variables look off as well isItemEditable

syntax highlighting is fundamentally different from VS Code. it heavily depends on the language server you're using (if any) and any matching exported tokens laid out here
what language server extension are you using for React? I will check if need to color anything specific.

Thx @tecandrew I believe React syntax is built-in for Zed so it says javascript

can you attach the snippet you've screenshot in the issue? I have a React app with me now, but I don't see the coloring issue

np @tecandrew here is the ChangeIcon component in its entirety
import { faClone } from "@fortawesome/free-regular-svg-icons";
import { faPen, faTrash } from "@fortawesome/free-solid-svg-icons";
import { FontAwesomeIcon } from "@fortawesome/react-fontawesome";
import PropTypes from "prop-types";
import icons from "../../../uswds/img/sprite.svg";
import Tooltip from "../../UI/USWDS/Tooltip";
import { DISABLED_ICON_CLASSES } from "./DisabledChangeIcons.constants";

/**
 * This component displays the edit, delete, and duplicate icons for a budget line.
 * @component
 * @param {object} props - The component props.
 * @param {Object} props.item - The item or data for the row.
 * @param {boolean} props.isItemEditable - Whether the item is editable.
 * @param {string} [props.lockedMessage] - The message to display when the item is not editable.
 * @param {function} props.handleSetItemForEditing - The function to set the row item for editing.
 * @param {boolean} [props.isItemDeletable] - Whether the item is deletable.
 * @param {function} props.handleDeleteItem - The function to delete the row.
 * @param {function} [props.handleDuplicateItem] - The function to duplicate the row.
 * @param {boolean} [props.duplicateIcon] - Whether to show the duplicate icon.
 * @param {boolean} [props.sendToReviewIcon] - Whether to show the send to review icon.
 * @param {function} [props.handleSubmitItemForApproval] - The function to submit the item for approval.
 * @returns {JSX.Element} - The rendered component.
 **/

const ChangeIcons = ({
    item,
    isItemEditable = false,
    lockedMessage,
    handleSetItemForEditing = () => {},
    isItemDeletable = isItemEditable,
    handleDeleteItem = () => {},
    handleDuplicateItem = () => {},
    duplicateIcon = true,
    sendToReviewIcon = false,
    handleSubmitItemForApproval = () => {}
}) => {
    const disabledClasses = `text-primary height-2 width-2 margin-right-1 cursor-pointer ${DISABLED_ICON_CLASSES}`;
    const notEditableOrDeletableMsg = "Only budget lines in Draft or Planned Status can be edited or deleted";

    return (
        <>
            <div className="display-flex flex-align-center">
                {isItemEditable && (
                    <>
                        <Tooltip
                            label="Edit"
                            className="line-height-body-1"
                        >
                            <button
                                id={`edit-${item?.id}`}
                                title="Edit"
                                aria-label="Edit"
                                data-cy="edit-row"
                                onClick={() => handleSetItemForEditing(item?.id)}
                            >
                                <FontAwesomeIcon
                                    title="Edit"
                                    icon={faPen}
                                    className="text-primary height-2 width-2 margin-right-1 cursor-pointer"
                                />
                            </button>
                        </Tooltip>
                        <Tooltip
                            label={`${isItemDeletable ? "Delete" : "Disabled"}`}
                            className="line-height-body-1"
                        >
                            <button
                                id={`delete-${item?.id}`}
                                title="Delete"
                                aria-label="Delete"
                                data-cy="delete-row"
                                onClick={() => isItemDeletable && handleDeleteItem(item.id, item.display_name)}
                            >
                                <FontAwesomeIcon
                                    title="Delete"
                                    icon={faTrash}
                                    className={`text-primary height-2 width-2 margin-right-1 cursor-pointer ${
                                        !isItemDeletable ? DISABLED_ICON_CLASSES : ""
                                    }`}
                                />
                            </button>
                        </Tooltip>
                    </>
                )}
                {!isItemEditable && (
                    <>
                        <Tooltip
                            position="top"
                            label={lockedMessage ? lockedMessage : notEditableOrDeletableMsg}
                            className="line-height-body-1"
                        >
                            <button
                                id={`edit-${item?.id}`}
                                title="Edit"
                                aria-label="Edit"
                                data-cy="edit-row"
                                disabled={true}
                            >
                                <FontAwesomeIcon
                                    icon={faPen}
                                    className={disabledClasses}
                                />
                            </button>
                        </Tooltip>
                        <Tooltip
                            position="top"
                            label={`${lockedMessage ? lockedMessage : notEditableOrDeletableMsg}`}
                            className="line-height-body-1"
                        >
                            <button
                                id={`delete-${item?.id}`}
                                title="Delete"
                                aria-label="Delete"
                                data-cy="delete-row"
                            >
                                <FontAwesomeIcon
                                    icon={faTrash}
                                    className={disabledClasses}
                                />
                            </button>
                        </Tooltip>
                    </>
                )}

                {isItemEditable && duplicateIcon && (
                    <Tooltip
                        label="Duplicate"
                        className="line-height-body-1"
                    >
                        <button
                            id={`duplicate-row-${item?.id}`}
                            title="Duplicate"
                            aria-label="Duplicate"
                            data-cy="duplicate-row"
                            onClick={() => handleDuplicateItem(item?.id)}
                        >
                            <FontAwesomeIcon
                                icon={faClone}
                                className="text-primary height-2 width-2 cursor-pointer margin-left-0"
                            />
                        </button>
                    </Tooltip>
                )}
                {/* NOTE: Do we ever want to not allow duplicating BLIs? */}
                {!isItemEditable && duplicateIcon && (
                    <Tooltip
                        position="top"
                        label="Disabled"
                        className="line-height-body-1"
                    >
                        <button
                            id={`duplicate-${item?.id}`}
                            title="Disabled"
                            aria-label="Disabled"
                            data-cy="duplicate-row"
                            disabled={true}
                            onClick={() => {}}
                        >
                            <FontAwesomeIcon
                                icon={faClone}
                                className={disabledClasses}
                            />
                        </button>
                    </Tooltip>
                )}
                {isItemEditable && sendToReviewIcon && (
                    <Tooltip
                        label="Submit for approval"
                        className="line-height-body-1"
                    >
                        <button
                            id={`submit-for-approval-${item.id}`}
                            title="Submit for approval"
                            aria-label="Submit for approval"
                            data-cy="submit-row"
                            onClick={() => handleSubmitItemForApproval(item.id)}
                        >
                            <svg className="usa-icon text-primary height-205 width-205 cursor-pointer margin-left-0">
                                <use xlinkHref={`${icons}#send`}></use>
                            </svg>
                        </button>
                    </Tooltip>
                )}
                {!isItemEditable && sendToReviewIcon && (
                    <Tooltip
                        position="top"
                        label={`${
                            lockedMessage
                                ? lockedMessage
                                : "Only team members on this agreement can edit, delete, or send to approval"
                        }`}
                        className="line-height-body-1"
                    >
                        <button
                            id={`submit-for-approval-${item?.id}`}
                            title="Submit for Approval"
                            aria-label="Submit for Approval"
                            data-cy="submit-row"
                            disabled={true}
                        >
                            <svg
                                className={`usa-icon text-primary height-205 width-205 cursor-pointer margin-left-0 ${DISABLED_ICON_CLASSES}`}
                            >
                                <use xlinkHref={`${icons}#send`}></use>
                            </svg>
                        </button>
                    </Tooltip>
                )}
            </div>
        </>
    );
};

ChangeIcons.propTypes = {
    item: PropTypes.object.isRequired,
    isItemEditable: PropTypes.bool,
    lockedMessage: PropTypes.string,
    handleSetItemForEditing: PropTypes.func,
    isItemDeletable: PropTypes.bool,
    handleDeleteItem: PropTypes.func,
    handleDuplicateItem: PropTypes.func,
    duplicateIcon: PropTypes.bool,
    sendToReviewIcon: PropTypes.bool,
    handleSubmitItemForApproval: PropTypes.func,
    goToApproveIcon: PropTypes.bool,
    handleGoToApprove: PropTypes.func
};

export default ChangeIcons;

I found what affects this. The type coloring is mapped to the identifier Javascript highlight. to match VS Code, it should be Pink.

however, the type coloring is generic and applies to all other languages as well. see python example. this is determined by the default python highlights.scm from Zed too

the VS code version for python has these highlights as Catppuccin Yellow

😅 I don't think there's a good middle ground here. It's not that the coloring is "wrong," but more-so the syntax coloring methods between the two are very different. An external Zed language server can probably override this and make the highlighting more Javascript-React specific. There's already that option in VS code

I do see that Zed docs say that they support TypeScript/TSX natively
What do you suggest as a path forward?

typescript encounters the same behavior: the type_identifier highlight is mapped to identifier

i'll probably just keep the coloring as-is. Mostly to keep it more inline with the Catppuccin Style Guide. "Types" should be Catppuccin Yellow. I know this isn't a hard requirement, but it simplifies things 🫡

VSCode uses textmate grammers, whereas Zed uses treesitter for it's parsing.
It's not a possibility to have syntax highlighting for each editor be the same. Of course, we can get close as possible but I'm inclined to agree with @tecandrew since it's worse off to make these pink and have it affect other tokens in other languages.

thanks @tecandrew for looking into this for me. Appreciate your hard work to get this theme into Zed.


Update scalatest to 3.1.2

Updates org.scalatest:scalatest from 3.1.1 to 3.1.2.
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "org.scalatest", artifactId = "scalatest" } ]

labels: test-library-update, semver-patch

Pull Request Test Coverage Report for Build 91

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 78.523%

Totals

Change from base Build 89:
0.0%

Covered Lines:
117

Relevant Lines:
149

💛  - Coveralls


How to complex test grpc server

I want to test my grpc server with full list of interceptors

and the question is?


Normal Angular Error.

Can you please share the implementation code for Figure 10 in your paper? (Code for computing the normal angular error between meshes.)

@bbrument Can you please help with this?
Thanks 👍🏻

@aaryapatel007 For MAE, we first used Blender to render normal maps based on the views provided by the calibration and then we computed a basic angular error pixel by pixel with a maximum threshold at 45°. I can add the second part of the code relative to the MAE computation fairly quickly. But if you are also interested in the Blender normal rendering, it is gonna take more time.

Hey @RobinBruneau, Thanks for your reply!
It will be helpful if you can share the second part of your code.

You can find my function just below :
normal_map_1,normal_map_2 : HxWx3 images
mask_1,mask_2 : HxW images
def MAE(normal_map_1, normal_map_2, mask_1, mask_2):
    normal_map_1 = normal_map_1 * 2.0 - 1.0
    normal_map_2 = normal_map_2 * 2.0 - 1.0

    mask_both = mask_1 + mask_2  # Fusion of both masks
    ind_remove = np.where(mask_1 < 0.5)  # Outside both masks
    ind_keep = np.where(mask_1 > 1.5)  # Inside both masks
    ind_bad = np.where(mask_both == 1.0)  # Only on one mask

    n1 = normal_map_1 / np.linalg.norm(normal_map_1, axis=2, keepdims=True)
    n2 = normal_map_2 / np.linalg.norm(normal_map_2, axis=2, keepdims=True)
    dot_n = (n1 * n2).sum(axis=2).clip(-1.0, 1.0)
    geodesic_distance = np.arccos(dot_n)

    MAE_score = np.copy(geodesic_distance)
    MAE_score[ind_bad[0], ind_bad[1]] = 0.0
    MAE_score[ind_remove[0], ind_remove[1]] = 0.0
    nb = len(ind_keep[0])
    MAE_mean_score = np.sum(MAE_score) / nb

    geodesic_distance = geodesic_distance.clip(0.0, np.pi / 4)
    geodesic_distance /= (np.pi / 4)
    geodesic_distance[ind_bad[0], ind_bad[1]] = 1.0
    MAE_image = plt.cm.jet(geodesic_distance)[:, :, :3]
    MAE_image[ind_remove[0], ind_remove[1], :] = 1
    MAE_image_crop = MAE_image[np.min(ind_keep[0]):np.max(ind_keep[0]), np.min(ind_keep[1]):np.max(ind_keep[1]), :]

    return MAE_score, MAE_mean_score, MAE_image, MAE_image_crop

Thanks @bbrument for providing the code!
I also had another doubt, how did you make the circular zoom-ins in figure 9 of the paper where you compare your method with NeuS on different number of input view.

Hi @RobinBruneau, Can you please share which video editing software you used to make the mesh comparison videos?

Hi @RobinBruneau, Can you please share which video editing software you used to make the mesh comparison videos?


[BUG][security.yml] deploy custom security config is not supported if auth type is different than oidc

If copy_custom_security_configs is true custom file security_plugin_conf.yml is not deployed because the check is made on  auth_type == 'oidc'.
- name: Security Plugin configuration | Copy the security configuration file 3 to cluster
  template:
    src: security_plugin_conf.yml
    dest: "{{ os_sec_plugin_conf_path }}/config.yml"
    backup: yes
    owner: "{{ os_user }}"
    group: "{{ os_user }}"
    mode: 0600
    force: yes
  when: auth_type == 'oidc'

So if you customised security_plugin_conf.yml to use ldap or anything but oidc then you cannot deploy the configuration.
I suggest an easy fix by adding an alternative check :
- name: Security Plugin configuration | Copy the security configuration file 3 to cluster
  template:
    src: security_plugin_conf.yml
    dest: "{{ os_sec_plugin_conf_path }}/config.yml"
    backup: yes
    owner: "{{ os_user }}"
    group: "{{ os_user }}"
    mode: 0600
    force: yes
  when: auth_type == 'oidc' or copy_custom_security_configs

This changed should not cause too much trouble.

[Triage]
Hey @french-kiwy thanks for raising an issue, I now get the problem, can you please raise a PR and contribute to the fix you suggested?
Thank you
@gaiksaya @bbarani @peterzhuamazon


Make npm pkg

couldn't get the npm package fortune, went with fortune-css instead.
did some tests with publishing compiled css vs straight, but ran into issues when trying to import it from a quick create-react-app. screenshot below of it working 🔮

gave you write access to the npm package. will share tomorrow how to publish new versions yourself

How exciting, fortune-css pkg it is. Think touched on it but I hadn't made any decisions on whether to include the dist folder & then what kind of files we want to build…eg cssvars, vanilla, prefixed.


[SC-1118] USDC as connector on avax

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 83.73%. Comparing base (80eaa4b) to head (ec7910b).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #126   +/-   ##
=======================================
  Coverage   83.73%   83.73%
=======================================
  Files          33       33
  Lines         861      861
  Branches      179      179
=======================================
  Hits          721      721
  Misses        140      140

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Remove FoolUpdater and do everything through the manager

The updater attribute of the manager was introduced to simplify adapting some components to PyTorch. However,  since there is no real Updater in ppe, it shouldn't be relied upon.
This change might break some user code when they use their old chainer extensions with ppe but I think is a good moment to get rid of it.

I would like to ask the opinion of @corochann and @belltailjp about removing the updater 😇

I think it should be fine, as the one I proposed to introduce itself (#18) doesn't (and perhaps won't) manage these info. For my codes currently under dev/maintenance, migration cost is affordable.

I'm fine with the change too.

pfnCI, test this please.

Could you check the test failure?

rebased!

pfnCI, test this please.

LGTM!


移动条码识别位置,如若需要改动源码,能否告知修改哪些自定义View哪些地方呢?

我这边需要实现一个这样的功能,请问如何把识别位置置顶呢?
如果需要修改源码的话,能否告知修改哪些地方:
BarcodeView、CameraPreview、CompoundBarcodeView、ViewfinderView?

"I need to implement one such function here. How do I put the identification position to the top?
If you need to modify the source code, can you tell me where to change:
BarcodeView, CameraPreview, CompoundBarcodeView, ViewfinderView?"

这个库的识别区域已经被定死在正中间,所有如果我想改变识别区域的话,要这么做呢.

你能否努力用英语写你的评论？ 我是法国人，我会说一点中文，但国际工作语言是英语 ;）

如果有更多人能够理解，你会有更多的答案。

The recognition area of this library has been fixed in the middle, so if I want to change the recognition area.
How do I do that?

Please post issues in English.
The logic is currently in PicturePreview#calculateFramingRect. You'll have to override this method in BarcodeView to change the position.


Added clear button to clear search query.

Created custom button for Android.
clearbuttonmode only works for iOS.
Fix:#628

Thanks for the PR. I was thinking that we need that also.
I looked what icon the other apps use and they use the X without background.
So it is the same as we have for iOS. Should we switch to it?

Done 👍
How it looks now?
iOS dark theme

iOS light theme

Android dark theme

Android light theme

Updated 👍
Rebased & fixes flow text.

Updated :+1:
Button with size 44 was looking too big.

with size 30 (though touchable area is large than icon)

@borisyankov rebased 👍

This eslintrc file conflicts all the time ;)

@borisyankov ready to go in before any other conflict arises :)

It is in! 👍


[WIP] Global resync Kafka channels when config-kafka is changed

Fixes #

Proposed Changes

Release Note

Docs

I'm confused... Is this adding the dynamic watching of the configmap to consolidated channel?  I thought that was not workable and we were going to remove that capability from the distributed channel?

@travis-minke-sap
The problem with on-the-fly reloading is around the dispatcher/receiver and not on the controller.
My current thinking is:

User changes config-kafka
Controller picks it up, it does a global resync
At this stage, we also need to reload the dispatchers/receivers. Either by getting the controller to recreate them entirely, or by watching the configmap directly committing suicide inside distributers/receivers.

What I would like to disable is reloading config-kafka without restarting the dispatcher/receiver pod.

That doesn't work properly because there are some parameters in config-kafka that can only be set once in a process
Just killing the entire process and starting from scratch makes the code much simpler

I can't add automated e2e tests for this. The old behavior didn't have a test either.
I wrote some YAML + some tools here: https://github.com/aliok/kafka-ch-reload-tests
I did some manual tests and I can see everything works fine when config-kafka changes during message ingestion by KafkaChannel.
Reload logic in KafkaChannel controller is only affecting the controller itself anyway. It doesn't do anything about dispatcher. (it was this way and I want to keep it that way).

cc @eric-sap mind having a look?

The moving of the GlobalResync into a function that is called when the configmap changes seems like an overall useful change.  Just to confirm - all that does is force a re-reconcile of the KafkaChannels, and has nothing to do with any restarting of deployments/pods (because the consolidated KafkaChannel reconciler doesn't do that unless the image changes or the replicas were somehow set to zero).  My knowledge of the consolidated behavior is somewhat limited, though, and there may be behavior I've missed.

@eric-sap

Just to confirm - all that does is force a re-reconcile of the KafkaChannels, and has nothing to do with any restarting of deployments/pods

Yes, that's true.
I am working on another PR that does the restart of the dispatcher pods.

/hold
Let's wait for the release cut for getting this in.

/unhold

/lgtm
(though I don't believe I'm in the group with permissions to use that command)

/test pull-knative-sandbox-eventing-kafka-upgrade-tests


Resizing subdivisions claims outside of top level claim border/Overlapping claims

The title is very self explanatory; it is possible to resize subdivisions outside of the top level claim border.
This causes issues as you might expect.
Version: 1.8.9 <IP_ADDRESS>

Actually, I've seen several cases of normal claims overlapping so I think that this issue is not just subdivisions.

@inklit OK thanks, I'll look into this soon.

Just thought I'd mention when claims are overlapping, it takes like 4x attempts to delete the claim before the land is actually unclaimed again.
It sort of switches between the overlapping claims about twice.
Also, there's other odd behaviour in overlapped claims, such as some(?) events not really being cancelled properly (onBlock.pre for example is not cancelled at all when a claim overlaps - tested it with ComputerCraft)

@inklit Does this still occur with latest build?

I'll test later today.

I believe that this is fixed, if it occurs again I'll create a new issue.


Feature: handle 'reload scripts'

fixes #279

Looks awesome, nice way to dynamically figure out which modules to reload. Was worried this would have to been handled all over the place. Very nice :)


Aliases support

Both from the default system location, and specified with the --aliases flag.

Support for the --aliases flag has been added. Default system location handling will be done as part of #3.


Add direct link to screencast video

The original blog post links to a direct media download from the blog itself, which no longer works. A quick search shows that https://vimeo.com/1720508 should be the same screencast, but externally hosted. (The Vimeo link also links back to the original post)

Thanks @


fixed some ncRna piecharts and some asthetics on the pages

Can this please go on the live site too.
Thank you

Hi AJ
Do you want your changes to go on both the release/85 and master branch? if that's the case can you please do a pull request on the postreleasfix/85 branch.
I dont quite understand why the commit is to merge the changes into release/85

Done.
Thanks Ridwan.
On 26/07/2016 10:20, Ridwan Amode wrote:

Hi AJ
Do you want your changes to go on both the release/85 and master
branch? if that's the case can you please do a pull request on the
postreleasfix/85 branch.
I dont quite understand why the commit is to merge the changes into
release/85
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/Ensembl/ensembl-webcode/pull/469#issuecomment-235211238,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AMH2v3DvXrWYLUqCHAVQCp0u0gaEHrMDks5qZdF2gaJpZM4JT5qQ.


Remove the need to keep the stream around

Its a common footgun in using rodio. It should be possible to store the stream in the sink.
Remaining questions, does the stream need to be accessible when a sink is used? If so how? Does sink get a method to get the stream?
Implementation wise it seems like storing the stream in an Arc will work.

Can Sink's output be not a stream but another source? Should they give some shared reference to the output stream?
I would keep sink as simple as possible unless there is a compelling case to add anything to it. It is a lot harder to remove things from API than to add them.

I am trying to prototype now how to best to do this.

Can Sink's output be not a stream but another source?

Thats actually quite a nice idea. I wonder if there is any reason thats not the case right now... It seems quite elegant!

How would it help out for this issue though? The stream still needs to be kept somewhere.
And Sink is not really a footgun atm I rather not change it, Rodio has a ton of users depending on Sink in its current form.

Just to note, i am working on this while creating a stream builder.
My latest version is here https://github.com/PetrGlad/rodio/tree/init-revamp

Ahh good to hear, take your time to play around with it. Feel free open a (draft) PR once you want feedback. I had a quick look at a diff and saw some unrelated (I think?) changes (stuff with k == 0 in src/conversions/sample_rate.rs).

so I still need to explain/justify some of the choices there.

Comments explaining why you did things a certain way are invaluable for maintainers, both later on when the code needs to be changed/updated/fixed and during review. So that would be very nice :)
If at all possible please split unrelated changes to different PR's, that makes them far easier to discuss and review. I can help out with that.

Yes, some changes are unrelated, I will check that but they are mosly non-functional. I can trim the changeset down if that is a problem. Regarding that change in sample_rate.rs fix failing tests. Also there are failing checks on the doc comments. These checks are normally  performed by cargo test.

More on sample_rate tests, the quickcheck generates random values for inputs and usually probes also very small and very large values, so this causes overflows. My fix prevents testing very large coefficients. If that case is expected to be handled, then some other fix is required there.

I can trim the changeset down if that is a problem

That would be nice, it makes reviewing easier and there is less of a chance of a bug slipping through.

https://github.com/RustAudio/rodio/pull/640

Addressed as part of #641 :partying_face: :balloon:


add auto save option for files

As a user, it would be great to have an option to auto save changed files after some delay when the user stops to make changes in the file.

I would also like this feature because it would allow the rust-analyser information to be updated more easily.

And auto save on Window/Tab changes, as in VS Code.

Duplicate of #248


Invoke-DbaDatabaseShrink should skip offline and snapshots

Bug Report

General Troubleshooting steps

[X ] Verified running latest release of dbatools?
[ ] Verified errors are not related to permissions?
[ ] Can duplicate in new/fresh PowerShell.exe session?

Version Information

Operating System (Name|Version):
PowerShell Version:
SQL Server (Edition|Version):

Steps to Reproduce

[ ] Attach any screenshots (if possible/allowed)
[ ] Attach logs generated by dbatools (Get-DbatoolsLog)
[ ] Attach output from PowerShell console (if possible/allowed)

Feature Request
Add skip of databases that are not online and cannot be shrunk,  Use IsAccessible property.

fixed via https://github.com/sqlcollaborative/dbatools/commit/5d23ac3a2b377a41ef637c0aba2c0d82ea2656aa#diff-7f4806ae4cd44ab9998b9a934409a8aa


Update CONTRIBUTORS.md

Adding my name to CONTRIBUTORS.md

Thanks @glee2244.  CC #4959

#4959 got merged.


Feature request: Standardize order of class components

Hi Jörg-Michael, I'd like to request a new rule to standardize the order of class components in the class definition.
Clean Code suggests the following order:

Static constants
Private static variables
Private instance variables
Functions

Of course, we can't use this 1:1 because ABAP classes are structured using SECTIONs. Adapting these general guidelines for ABAP classes, a possible standardized order could look like this:

INTERFACES
TYPES
CONSTANTS
ENUM
CLASS-DATA
DATA
CLASS-METHODS
METHODS

I imagine that a common variant of this approach would be this:

[...]
CLASS-DATA
CLASS-METHODS
DATA
METHODS

The same approach could be used for interface definitions.
What do you think about this?

Please keep in mind that the statements in the definition sections can "only look up". Some maybe not so obvious relations that would have to be considered to not cause syntax errors with your suggested order:
CONSTANTS some_constant_value TYPE i VALUE 42.
INTERFACES my_interface DATA VALUES read_only_attribute = some_constant_value.

DATA instance_attribute TYPE i.
CLASS-DATA static_attribute LIKE instance_attribute.

TYPES: BEGIN OF ENUM my_enum,
         a,
       END OF ENUM my_enum.
TYPES: BEGIN OF line,
         component TYPE my_enum,
       END OF line.

DATA some_attribute TYPE i.
TYPES some_type LIKE some_attribute.


Rename the kv directory

What type of enhancement is this?
Configuration, User experience
What does the enhancement do?
The v0.4 standalone process will create a directory named kv. I think it's really a bad name, it doesn't provide any useful info for the users.
Some choices such as meta, state, or internal would be better.
Implementation challenges
No response

@killme2008 , you mean here

@killme2008 , you mean here

Yes, prefer a better name to describe it's usage. cc @waynexia  What's your option?

@Lilit0x We decided to use metadata as the new name of this internal state directory.  Are u interested in creating a PR for it?

@killme2008 , yes, I am

@Lilit0x Thank u👍🏻. Appreciate it if you could create a PR today or tomorrow, we want to release v0.4.0 tomorrow.


Change cyhy-mailer to send via our AWS organization

@jsf9k commented on Fri Apr 03 2020
🐛 Bug Report
At some point mail sent via the old CyHy AWS account will start to fail.

Resolved via cisagov/cyhy-amis#255 and cisagov/cool-dns-cyber.dhs.gov#12.


Observability docs issue - App Insights

In the dapr observability docs for setting up Azure Application Insights with the open telemetry collector: https://docs.dapr.io/operations/monitoring/open-telemetry-collector/#how-to-configure-distributed-tracing-with-application-insights , it asks for :
Check out the file open-telemetry-collector.yaml and replace the  placeholder with your APP_INSIGHTS_KEY. However that file doesn't contain an APP_Insight_Key.
It does however contain: azuremonitor:
endpoint: "https://dc.services.visualstudio.com/v2/track"
instrumentation_key: "".
Filling that with an App Insight Instrumentation key does nothing.

Thanks. Moving to docs repo.


Covid19 Dectection using chest X-Ray

@avinashkranjan I would work on this issue. I am a participant in SWOC 2021
Aim

The system will detect whether the person is having a covid 19 or not.

Details

I will train the model first with the machine learning algorithms by collected data sets.
After that, I will test how much accuracy is being there.
And I will include this whole system using Tkinter GUI. so that if a user just imports an x-Ray image,  we can check whether suffering from the covid -19 or not.

This script helps the students who are trying to learn or explore machine learning algorithms in their studies.

Go Ahead @saiharsha-22

@avinashkranjan thank you for assising the issue I will start working on it.


Kelloggs scraper is not working

ENVIROMENT: production
URL: https://scrapers.peviitor.ro/
Browser: Chrome
Device: laptop
OS: Windows 10
STEPS TO REPRODUCE:

Open URL: https://scrapers.peviitor.ro/src/kelloggs/index.html/
Click: "Run scraper" button

EXPECTED RESULTS:
Scraper should be active and functional
ACTUAL RESULTS:
Scraper status: INACTIVE -- and the page is displaying this error: "python3: can't open file 'kelloggs.py': [Errno 2] No such file or directory"

Issued moved in Scrapers_UI https://github.com/peviitor-ro/Scrapers-UI/issues/


Only variables should be passed by reference - php 7.3.0

PHP Notice:  Only variables should be passed by reference in .../src/ServerRequestHandler.php on line 307
Using php 7.3.0
Solution:
src/ServerRequestHandler.php: 307: $ext = strrchr($filename, ".");

Thank you for your fix.
That's implemented and generated the release tag 3.0.1


Creating a bounty didn't post to #bounty-board and clicking claim on the front end refreshes the front page

Describe the bug
Created a bounty and Degen didn't create a bounty in the #bounty-board channel.
Currently unable to claim.
To Reproduce
Steps to reproduce the behavior:

/bounty create Bounty Board Outreach Proposal 1000
Defined the details and criteria
Click DRAFT
Modify the description
Create
Bounty is NOT created in #bounty-board channel and when hovering over the claim it button, it references the https://bountyboard.bankless.community

Expected behavior
When drafting and creating, the bounty is posted to #bounty-board channel.
Screenshots

Attempted to claim via /bounty claim bounty-id: 61896f4f5f6f5200201b38d1I and received this error:

Although, Links tried it twice, and it eventually was claimed. He also clicked claim it on the front end.
Maybe it refreshed?

I think this is related to bountybot + some old integrations. Either way doesn't seem to be a persistent issue so closing


[Feature Request] Dedicated Bookmarks Search

I really love the quick navigation that is possible by consecutively accessing outlinks and backlinks directly from the AQS prompt. But I find it always a bit difficult to find a meaningful starting point to traverse my notes.
I think a great starting point could be utilizing Bookmarks as a dedicated search target like "file, link, backlink, 2-hop" in AQS. Right now, the "Star" sort priority is a bit cumbersome for this, as it doesn't filter out all the other notes and most importantly (for me at least), it doesn't sort the starred/bookmarked files by order of appearance in the bookmark pane. To access my bookmarked files, i still use quick switcher++, which works too, but i always have to switch to AQS afterwards to traverse through links, open pdfs etc.
If I quickly want to go through several files and then realize "oh it was actually that other file connected to my other bookmark" i always have to repeat that process of switchting between QuickSwitcher++ and AQS.
A translation of the new grouping/folder structure for bookmarks would be a nice extra too. QuickSwitcher++ solved this by Naming the entry for a grouped bookmark in a Path format like "Group A/Bookmark A". I think that is a good comprimise.
It would be nice to represent all the possible entries of the Bookmarks Pane, like bookmarks to Heading, Search Queries, Folders  etc.
Basically a mirroring of the bookmarks pane through AQS
Cheers and always a big thank you for the great work :)

Thank you for your FR, @Glint-Eye  :)
Personally, I don't need it very much because I don't use the bookmark feature. However, if other people need it, I'll consider it not as the "target" but as a dedicated bookmark search 👍


Default Colab Demo installation issues

I was just testing the Colab Demo without any changes on a V100 / CUDA 11.2 / Python 3.7.12 and ran into following errors.
When installing the CUDA libs and libc:
/sbin/ldconfig.real: /usr/local/lib/python3.7/dist-packages/ideep4py/lib/libmkldnn.so.0 is not a symbolic link
Later at romp.predict.image:
ImportError: /usr/local/lib/python3.7/dist-packages/pytorch3d/_C.cpython-37m-x86_64-linux-gnu.so: undefined symbol: _ZNK2at6Tensor2leERKN3c106ScalarE

This is the caused by installation failure of pytorch3d.
Note that for now installing pytorch3d via pip only supports Pytorch1.9 and CUDA 10.2, see here.
Sadly, Pytorch1.9 is not currently available now..
I will add the support for rendering results via Pyrender later. For now, the situation is prettey ackward...

You can install pytorch 1.9.0 through conda:
conda install -n test pytorch==1.9.0 torchvision torchaudio cudatoolkit=10.2 -c pytorch. I'm testing out if this resolves the issue!

Vimal

You can install pytorch 1.9.0 through conda:
conda install -n env_name pytorch==1.9.0 torchvision torchaudio cudatoolkit=10.2 -c pytorch. I'm testing out if this resolves the issue!
Vimal

This seems to resolve the issue! I've submitted a pull request with some other changes that I had to make in order to get the video demo to work. Thanks for the awesome repo and congrats on the paper!
Vimal

Thanks, Vimal,
This is really helpful.
Best,
Yu


fix(react-router): do not decode already escaped URL path segments

Closes #2046

thank you~ 🚀 🎉 🎉