Simplifies code in Data Providers and enhances API reference

Summary
Simplifies the usage in data providers and enhances documentation.
Details and comments
BaseDataProvider: eliminates code repetitions when checking for self._data and adds more documentation in API reference.
RandomDataProvider, WikipediaDataProvider, YahooDataProvider: adds more documentation in API reference.
RandomDataProvider: replaces unnecessary calls to Pandas with more readable Numpy functions.
✅ I have added the tests to cover my changes.
✅ I have updated the documentation accordingly.
✅ I have read the CONTRIBUTING document.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

@edoaltamura This has been inactive for sometime, did you want to complete this off? You need at least to add from __future__ import annotations into some of these to allow the use of | in earlier Python versions.

I can make time to finalize it this coming week!

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

49 of 75 (65.33%)  changed or added relevant lines in 6 files are covered.
4 unchanged lines in 3 files lost coverage.
Overall coverage decreased (-0.08%) to 75.743%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

qiskit_finance/data_providers/_base_data_provider.py
20
21
95.24%

qiskit_finance/data_providers/random_data_provider.py
15
16
93.75%

qiskit_finance/data_providers/yahoo_data_provider.py
6
7
85.71%

qiskit_finance/data_providers/wikipedia_data_provider.py
5
7
71.43%

qiskit_finance/data_providers/exchange_data_provider.py
2
10
20.0%

qiskit_finance/data_providers/data_on_demand_provider.py
1
14
7.14%

Files with Coverage Reduction
New Missed Lines
%

qiskit_finance/data_providers/_base_data_provider.py
1
85.33%

qiskit_finance/data_providers/exchange_data_provider.py
1
18.03%

qiskit_finance/data_providers/data_on_demand_provider.py
2
27.66%

Totals

Change from base Build<PHONE_NUMBER>:
-0.08%

Covered Lines:
612

Relevant Lines:
808

💛  - Coveralls

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

49 of 75 (65.33%)  changed or added relevant lines in 6 files are covered.
7 unchanged lines in 4 files lost coverage.
Overall coverage increased (+0.04%) to 75.866%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

qiskit_finance/data_providers/_base_data_provider.py
20
21
95.24%

qiskit_finance/data_providers/random_data_provider.py
15
16
93.75%

qiskit_finance/data_providers/yahoo_data_provider.py
6
7
85.71%

qiskit_finance/data_providers/wikipedia_data_provider.py
5
7
71.43%

qiskit_finance/data_providers/exchange_data_provider.py
2
10
20.0%

qiskit_finance/data_providers/data_on_demand_provider.py
1
14
7.14%

Files with Coverage Reduction
New Missed Lines
%

qiskit_finance/data_providers/_base_data_provider.py
1
85.33%

qiskit_finance/data_providers/exchange_data_provider.py
1
18.03%

qiskit_finance/data_providers/data_on_demand_provider.py
2
27.66%

qiskit_finance/data_providers/wikipedia_data_provider.py
3
64.58%

Totals

Change from base Build<PHONE_NUMBER>:
0.04%

Covered Lines:
613

Relevant Lines:
808

💛  - Coveralls

I updated the method bindings also in a couple of other places where relevant. I like working on the fine details! 🙂

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

49 of 75 (65.33%)  changed or added relevant lines in 6 files are covered.
4 unchanged lines in 3 files lost coverage.
Overall coverage decreased (-0.08%) to 75.743%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

qiskit_finance/data_providers/_base_data_provider.py
20
21
95.24%

qiskit_finance/data_providers/random_data_provider.py
15
16
93.75%

qiskit_finance/data_providers/yahoo_data_provider.py
6
7
85.71%

qiskit_finance/data_providers/wikipedia_data_provider.py
5
7
71.43%

qiskit_finance/data_providers/exchange_data_provider.py
2
10
20.0%

qiskit_finance/data_providers/data_on_demand_provider.py
1
14
7.14%

Files with Coverage Reduction
New Missed Lines
%

qiskit_finance/data_providers/_base_data_provider.py
1
85.33%

qiskit_finance/data_providers/exchange_data_provider.py
1
18.03%

qiskit_finance/data_providers/data_on_demand_provider.py
2
27.66%

Totals

Change from base Build<PHONE_NUMBER>:
-0.08%

Covered Lines:
612

Relevant Lines:
808

💛  - Coveralls


Action to detect eslint errors

Somehow does not work with npm install --only=dev, therefore ci is used.


Feature/flex 4475 extend relay status

I stopped the pull request build after pointing the submodules to development branch.


SAK-42738: switch from npm install to npm ci

https://jira.sakaiproject.org/browse/SAK-42738
The webcomponents project runs some NPM goals. The "install" goal specifically will modify the following files if the Maven build fails:

webcomponents/tool/src/main/frontend/package-lock.json
webcomponents/tool/src/main/frontend/package.json

This can be a problem if you're not aware of the issue and constantly checking if these files were modified after a failed build. The danger is that these unintended modifications can leak into commits if you're not extra careful.
According to some articles online, NPM 5.7.0 introduced the "ci" command as an    "additional way to achieve fast and reproducible builds...", and changing from "install" to "ci" resolves this issue.
References:

https://stackoverflow.com/questions/45022048/why-does-npm-install-rewrite-package-lock-json
https://github.com/jhipster/generator-jhipster/issues/8642

I'm not even sure if this worked, git is still reporting package-lock.json as being modified...

No more modified files after a failed build with these changes.


support reading github urls

currently story urls that point to github are not read correctly.  need to investigate why and fix.

https://github.com/jiggy-ai/hn_summary/commit/26fe4996b6d8c459047e914517d3f31a719c0c4c


Make Website button at the end of slides more clear

"Return to syllabus" or something that tells you what that's bringing you to.

[ ]  RStudio
[ ]  Reproducibility
[ ]  Basic R
[ ]  Data IO
[ ]  Subsetting
[ ]  Summarization
[ ]  Data classes
[ ]  Data cleaning
[ ]  Manipulating
[ ]  Esquisse
[ ]  Data viz
[ ]  factors
[ ]  Statistics
[ ]  Functions

@avahoffman I think it also might help to add the lab directly... like this:
🏠 [Class Website](https://jhudatascience.org/intro_to_r/)
💻 [Lab](https://jhudatascience.org/intro_to_r/modules/Subsetting_Data_in_R/lab/Subsetting_Data_in_R_Lab.Rmd)

@carriewright11 this is awesome, good idea!

This is done!


Cleanup condition group

where(Function<C, C>) is just an alias to where(block.apply((C) clone()))
clone() makes it a real function without side-effect.
cc: @k-kagurazaka

Beautiful!


Time series web mapping with leaf map draft notebook

Proposed changes
This is a concept notebook for a functionality I haven't seen well documented for visualising time-series spatial data in a jupyter nb.
Checklist (replace [ ] with [x] to check off)

[ ] Notebook created using the DEA-notebooks template
[ ] Remove any unused Python packages from Load packages
[ ] Remove any unused/empty code cells
[ ] Remove any guidance cells (e.g. General advice)
[ ] Ensure that all code cells follow the PEP8 standard for code. The jupyterlab_code_formatter tool can be used to format code cells to a consistent style: select each code cell, then click Edit and then one of the Apply X Formatter options (YAPF or Black are recommended).
[ ] Include relevant tags in the final notebook cell (refer to the DEA Tags Index, and re-use tags if possible)
[ ] Clear all outputs, run notebook from start to finish, and save the notebook in the state where all cells have been sequentially evaluated
[ ] Test notebook on both the NCI and DEA Sandbox (flag if not working as part of PR and ask for help to solve if needed)
[ ] If applicable, update the Notebook currently compatible with the NCI|DEA Sandbox environment only line below the notebook title to reflect the environments the notebook is compatible with

Hey @s-m-t-c, thanks so much for putting this together - I think it will be a great addition to the repo (have been wanting to get some Leafmap examples in here for ages too). Unfortunately there's a bit of an issue with widgets on the Sandbox at the moment, causing the map to not appear for me:

This is currently being worked on, so will hopefully have a solution soon. The other thing we'll need to do is get leafmap installed by default on the Sandbox - do you currently install any specific version, or just pip install leafmap to get the latest?

@robbibt I understand you're still working on the widget issue. Use the latest version of leafmap for this.


[WIP][crypto] increase size of URS to 2^18

This increases the upperbound for zkapp circuits from 2^16 to 2^18.
Last time we checked that benchs didn't seem great, but this PR introduce a new GPU-accelerated MSM implementation and so it'll probably be more acceptable.
I'd be nice to do some benchmarks before merging this, but unfortunately it seems like proof systems is currently not in sync with this repo so I can't test this.

this is just to test things, also it does not force you to use the GPU implementation

Stale, closing


Test: Add test for include option in banner plugin

What kind of change does this PR introduce?
test

Did you add tests for your changes?
test

Does this PR introduce a breaking change?
None

What needs to be documented once your changes are merged?
None

@jeffin143 pls sign CLA

Seem So this has worked ! I mean now the cla is green


Error trying to install via RStudio Server (Unix)

I'm trying to install Feather at work but ran into a problem trying to install via RStudio on Unix;
In file included from feather/api.h:22,
from feather_types.h:2,
from RcppExports.cpp:4:
./feather/buffer.h: In constructor ‘feather::MutableBuffer::MutableBuffer()’:
./feather/buffer.h:93: error: ‘nullptr’ was not declared in this scope
./feather/buffer.h: At global scope:
./feather/buffer.h:111: error: ‘constexpr’ does not name a type
./feather/buffer.h: In constructor ‘feather::BufferBuilder::BufferBuilder()’:
./feather/buffer.h:116: error: ‘nullptr’ was not declared in this scope
./feather/buffer.h: In member function ‘feather::Status feather::BufferBuilder::Append(const uint8_t*, int)’:
./feather/buffer.h:125: error: ‘MIN_BUFFER_CAPACITY’ was not declared in this scope
./feather/buffer.h: In member function ‘std::shared_ptrfeather::Buffer feather::BufferBuilder::Finish()’:
./feather/buffer.h:141: error: ‘nullptr’ was not declared in this scope
./feather/buffer.h:146: error: ‘nullptr’ was not declared in this scope
In file included from feather/api.h:23,
from feather_types.h:2,
from RcppExports.cpp:4:
./feather/common.h: At global scope:
./feather/common.h:20: error: expected initializer before ‘const’
./feather/common.h:32: error: ‘constexpr’ does not name a type
./feather/common.h: In function ‘bool feather::util::get_bit(const uint8_t*, int)’:
./feather/common.h:35: error: ‘BITMASK’ was not declared in this scope
./feather/common.h: In function ‘bool feather::util::bit_not_set(const uint8_t*, int)’:
./feather/common.h:39: error: ‘BITMASK’ was not declared in this scope
./feather/common.h: In function ‘void feather::util::clear_bit(uint8_t*, int)’:
./feather/common.h:43: error: ‘BITMASK’ was not declared in this scope
./feather/common.h: In function ‘void feather::util::set_bit(uint8_t*, int)’:
./feather/common.h:47: error: ‘BITMASK’ was not declared in this scope
In file included from feather/api.h:24,
from feather_types.h:2,
from RcppExports.cpp:4:
./feather/io.h: In constructor ‘feather::LocalFileReader::LocalFileReader()’:
./feather/io.h:65: error: ‘nullptr’ was not declared in this scope
./feather/io.h: In constructor ‘feather::MemoryMapReader::MemoryMapReader()’:
./feather/io.h:91: error: ‘nullptr’ was not declared in this scope
./feather/io.h: In constructor ‘feather::FileOutputStream::FileOutputStream()’:
./feather/io.h:178: error: ‘nullptr’ was not declared in this scope
In file included from feather/api.h:25,
from feather_types.h:2,
from RcppExports.cpp:4:
./feather/metadata.h: In constructor ‘feather::metadata::Table::Table()’:
./feather/metadata.h:150: error: ‘nullptr’ was not declared in this scope
make: *** [RcppExports.o] Error 1
ERROR: compilation failed for package ‘feather’

removing ‘/home/Scott.Jacobs/R/x86_64-redhat-linux-gnu-library/3.2/feather’
Error: Command failed (1)

Feather requires a C++11-capable gcc, at least gcc 4.8 (4.9 or higher recommended). On RedHat you can install the devtoolset to get the newer gcc, but I don't know the precise details


error message for stats.invwishart

The scale argument to stats.invwishart must be positive definite (see documentation http://docs.scipy.org/doc/scipy-0.16.1/reference/generated/scipy.stats.invwishart.html). The error message, however, that is returned for a non-positive definite matrix could me more clear.
When I run the following code
df = 2
scale = [[1, 1], [0, -1]]
stats.invwishart.rvs(df=df, scale=scale)

I get the following error message

LinAlgError: 2-th leading minor not positive definite

When I first encountered this error message it I was not entirely sure what the problem was. A better error message might read something like

ValueError: Scale matrix must be positive definite

I'm using scipy version 0.17.0.

It's probably easy enough to catch the a LinAlgError and reraise. Whether it's worth it, I don't know. Maybe consider adding a note to the docstring instead.


Add support for Azure

Terratest has an aws package with a number of utilities useful for AWS. It would be great to add similar utilities for testing code in Azure.

I am a member of Azure group and I am also thinking about this these days. I wonder what kind of features are important and thus really needed.

Hi @foreverXZC! Good question :)
I suspect many of the same utilities we have in the aws package would be useful, such as functions to make it easier to work with authentication, regions, machine images, logging, user accounts, and so on.

I'm contributing back some relevant work. See https://github.com/gruntwork-io/terratest/pull/332

@nmiodice Would love to work with you on this, as I wrote the beginnings of one as well.  I was going to open a PR later tonight! My work is laid out a little differently than yours, so I might open a PR as well just to get the mainters' thoughts on how we could come together on approach.

@drmmarsunited Absolutely. Looking through your PR I like the approach you took with the authorizer as it is more robust and works with non-service principal use cases. Other than that, these look very compatible.
I suggest that we get one merged (either one) and then we can work off of that common base. Thank you for putting this PR up, and it is too funny that we did it within an hour of each other! OSS community hard at work :)

@nmiodice and @drmmarsunited Thank you both for the Azure PRs! Love seeing support for another cloud 👍
Any thoughts on how you'd like to merge your two approaches together?

@brikis98 - We could pretty easily merge our code bases.  My only concern with the approach that @nmiodice took, is that it's too focused on creating clients.  On one hand, that pretty closely aligns with the how the Azure Go SDK itself works, but for testing purposes, I'd prefer to see targeted, specific and prescriptive methods, much like the AWS module.
As someone who will immediately be a consumer of this module for my team and other teams in the business here, I'd like to see the style/approach to these modules follow as closely as possible.  It makes the developer experience pretty seamless, and that would be a big win, instead of having to learn a different pattern for each cloud provider's module.

Agreed on maintaining a common style for Terratest with prescriptive methods. That said, @nmiodice, wasn't your PR just one of several planned ones? Are the follow-up PRs similar in style to what @drmmarsunited is mentioning?

@brikis98 Not to be nagging on you guys, but this initiative is super important to the teams here (given  we do a fair bit of work on the Azure platform).  Can we time box the feedback window here?  I'm ready to start contributing more helper methods to the Azure module to enable my teams.  I'm totally game to work with @nmiodice, but I want to keep the ball rolling and not get stalled.

Agreed on not holding it up too long. @nmiodice Let me know your thoughts. If we don't hear back in a day or two, we'll roll forward and hopefully you can add your contributions later on.

OK, moving forward with @drmmarsunited's PR.

Following the work that @drmmarsunited has done to introduce Azure support, I would like to contribute coverage for network-related resources in the azure module :

Virtual Networks
Subnets
Network Security Groups
Public IPs

Should I open a separate issue regarding Azure networking resources ?

I don't think any of the Azure PRs were ever completed... So I think we still need a base PR!

@brikis98 mine was merged a while back.

@drmmarsunited Ah, I'm sorry, you're right, I was thinking of https://github.com/gruntwork-io/terratest/pull/332.

@robmorgan @yorinasub17 did you have some ideas on how you might work with azure for integration testing of Azure PRs?

Hey @rguthriemsft and @TsuyoshiUshio,
First, apologies for our slow response on the topic here. To explain the current situation and be completely transparent, we as a team are not focused on Azure right now. We want to eventually move on to supporting Azure in our company, but this is not a high priority at the moment as we focus on AWS and GCP.
With that said, we believe that Terratest should support it reasonably, especially given the interest from Microsoft (e.g Microsoft wrote a blog post about Terratest! https://docs.microsoft.com/en-us/azure/terraform/terratest-in-terraform-modules), so we are looking for ideas for how to do it. That is, the following areas are where we need help:

A community lead (perhaps from Microsoft?) who can help review and maintain the quality of the Azure features of terratest. We are happy to help with PR reviews, but given our limited experience with Azure, our reviews will be limited to general code quality of terraform and golang.

Credits for running unit and integration tests for the library. Since Azure is not a priority for us, and since we are a small startup, it is hard for us to justify spending $4-5k annually to maintain a community project. By the way, this estimate is based on our spend of AWS and GCP from terratest. Since the Azure library is still small, this is likely to be less, but as we get more and more contributions, this will probably be a reasonable estimate.

As far as the latest contribution you have shared on AKS, since it looks ready to go, we'll be moving forward with it. That is, we'll kick off our sanity check build and if that passes, go ahead to merge it. However, for contributions going forward, we have agreed that it will be difficult for us without some kind of automated testing. So to move forward, we will need to address the above two concerns.
Hope that makes sense. Happy to answer any questions you might have!

Thanks for the feedback.  I am investigating options and will get back shortly.

Okay, great!

Hey everyone, I am also looking at contributing to the Azure part of Terratest. We recently discovered this and love it. At present, we are mostly a .Net shop with a couple of people dipping their toes into Go. What @TsuyoshiUshio said in his Jan 15th post about limited Go knowledge and documentation around the API, having wrapper methods here for Azure validation would be helpful. While I am not an employee of Microsoft, I have spent the last 3 years working in Azure and went from ARM templates, to Azure CLI, to using Terraform with Terratest. I have been looking for a project to support and this one really excites me and would love to help in this space around Azure.
I would be open to helping lead, review, and maintain the quality of Azure features of Terratest.
In regards to automated testing, there are many services that have free tiers that we can make sure the automated tests are using to validate these. For all the module validations I am doing for Alaska Airlines, I have a single Resource Group and Service Principal created to apply and destroy terrafrom against. I also have a nightly job that blows away anything in that resource group in case something went wrong during the tests so I don't have resources living longer than they should. I will keep my eyes on the cost of our solution and can provide some data if that will help.
I plan on adding the app service plan, web app, function app, auto scaling, alerting, app insights, and action group suite that is generally used together when creating PaaS web apps.
We also have plans for Redis, CosmsoDB, SQL Server, Service Bus, Event Grid, Event Hub, Key Vault, and Resource Groups.

@tsalright Thanks for the interest! We're discussing this internally with the team and will get back to you on this.

gruntworks team, I have a proposal for moving forward.  Would it be possible to have a discussion of which the outcome we can post back into this issue?  You can reach me at rguthrie at microsoft dot com of which I can outline our thinking?  We would love to imrpove the azure support and @tsalright happy to work together if we can find a good solution for accepting PRs.
@robmorgan @yorinasub17

@rguthriemsft Just sent you an email!

@robmorgan @yorinasub17 Have you thought about adding some additional tags to the issues to identify Terratest Core, GCP, AWS, Azure, etc to quickly identify the areas they are related to? I was thinking of this when I was looking at the issues and wanting to see which ones were Azure related so I could see what I could help with beyond the stuff I would like to add.

@tsalright we already have one for GCP, but I guess we could for the other packages. @yorinasub17 any preferences?

UPDATE: we're in talks with @rguthriemsft and have a call scheduled next week. Once agreed on a plan forward, we'll post the notes here. @tsalright , we appreciate your help! We'll be following up with you once we figure out our plans going forward with Microsoft, hopefully by end of week next week.

Have you thought about adding some additional tags

I think this is a good idea! We haven't done a good job with tagging even though we have the gcp label... I think we can do this going forward, but we don't quite have the bandwidth to go through old issues and label things at the moment.

Oh also, forgot to mention that we will continue to welcome feedback from anyone in the community no matter how the call turns out with MS. We hope to work with MS to set up some basic scaffolding to make maintenance easier, but we are eager to get help from the community on PRs, issues, etc.

Update for everyone: We are starting to do some work around setting up proper CI / CD for Terratest with Azure. We can't share any details or timelines right now, but just wanted to give you all a heads up that we haven't forgotten about this!

Also, I just tagged a number of issues/PRs with the Azure label. We'll come back to those when the work mentioned in my comment above has been completed.

Just a quick update to the Terratest Azure community. We are working on getting the pipeline up and running to start processing the Azure PRs that are out there. We are in the testing and validating phase of it. We will have an update in another week or two.

I think we can consider this issue resolved and would like to just add a link to the Developing for Azure as well as the examples

Sounds good to me! I'll mark this ticket as resolved.


#122 Broken paging

Fix the compatible version of dependencies to revert ldapjs to version 0.7.x. This resolves #122.
Versions of other dependencies have also been fixed to the current latest major version releases (the versions which would have been installed with the existing dependencies specification. These versions are assumed to work correctly, however this has not been explicitly tested.

This is how I would immediately patch the issue for a 0.7.3 release. Yur call on how you'd prefer to move forward.

Closing stale PR


Subsequent build fails on Win7 x64

When I build for the first time the folder structure is created and files etc.
Having made some changes to the source and running build again I get an error.
{ [Error: EPERM, mkdir 'q:\getimage\getimage\linux64']
errno: -4048,
code: 'EPERM',
path: 'q:\getimage\getimage\linux64' }
The folder structure is subsequently deleted.
Running a build again then succeeds.
The key part is, this is on a network drive where I keep all by projects. Running this on a local drive there is no issue.
Perhaps a timing\callback issue on the directory preparation ? i.e. the delete if it exists.

I have the same issue on a local drive. If I delete it manually before the build, everything's fine.

Is this Linux only or what?

I was on Win7 x64, usin a mapped drive. Local builds are fine. I was building a Linux .exe though.
Assuming there is some asynchronous stuff going on, if the delete is slow ( network\ slow HD ) then the next step is starting before the delete is complete ?

I re-did some of the promises in 2.2.1 so hopefully this is OK. Let me know if it still persists with the latest build.


[PE-D][Tester A] Inaccurate addc quickstart

Also tried:
addc n/John Doe p/92345123<EMAIL_ADDRESS>lc/18.09.2023 1500 o/NUS
EDIT: quick start suggested the command above, with o/, but I guess it isn't supposed to be there
EDIT EDIT: command summary also has the same problem, including o/, but also including add instead of addc

Labels: severity.High type.FunctionalityBug
original: H1410101/ped#2

Fixed in #153


exact.pyx

Some conversion to cython of the exact inference algorithm. Can be tested using this gist.
Currently untested, due to the setup issue (also mentioned in the gitter chat):
I'm trying to edit the pracmln code and test it simultaneously.
This requires being able to modify the code, and run tests on the modified version
(as opposed to a version that was installed in a virtualenv using setup.py).

This may be a trivial question, but I would be grateful if somebody could please help me setup a development environment such that I can run pracmln from the version controlled git repository
cloned on my computer as opposed to the one installed on my system.

This entire time, it turns out, I've been modifying pracmln code in the Git repository, but re running the same unchanged pracmln version I had earlier installed in my virtualenv.

This PR was initially meant for review, with work only on exact.pyx
However, I didn't want to create separate branches for every other file changed (for easier testing), and have hence edited other files on the same branch.
This PR hence contains the entire first iteration of Cython changes being made to the inference module (python3)

This PR has been reopened, and merge conflicts resolved.


AMICAL with VISIR data

Hello AMICAL developers!
As I noted on ESO's VISIR website, this code is the proposed tool for SAM data reduction. But is there a manual for it? I saw there is an example tutorial just for SPHERE.
Apologies in advance if this question should not be on Issues.
Thank you for your time !

Yes, VISIR is compatible with AMICAL but we did not test yet this feature. It's supposed similar to what is done for SPHERE actually, so feel free to try it on your own dataset.

Hi @stellaCL, did you manage to solve your problem? This issue can be closed for now?

Hello everyone,
I have some visir SAM data to reduce and I want to test the amical code, Which are the input data requeriments?
First, I compared with JWST data and those FITS files are in data cubes, but my raw observations are distributed on diferents frames. Do I need to create my own cube to make the reduction? Which is the structure of the input data?
My second question is about the header. Do amical use information from the header? Which Keywords? But more important, do amical recognize VISIR header?

Hi @bentitan, usually, the appropriate data format is datacube in fits files. One file is typically a bunch of frames used to compute the statistics and build the covariance matrices (uncertainties). You can check, for instance, the example files used for SPHERE or NIRISS. AMICAL does use the header keyword that should be standard between ESO instruments (at least). You can follow the tutorial used for SPHERE dataset, I should be very similar to the VISIR one.

Hello @DrSoulain
Thanks for your answers. After all I clean all my observations manually to recover the raw interferograms using sigma clipping. Then I follow the same CHOP/NOD steps of calibration:
Achop - Bchop    -    (Achop -Bchop)
NOD1                        NOD2
I cropped the images, turn the negatives into positives multiplying by -1. Finally I put all my data into a cube of dimensions of x/y/N, where x and y are the number of pixels in x and y directions and N is the amount of interferograms that I obtained and I modified the header a little.
After that I tried example_SPHERE.py changing the respective input parameters for VISIR and the code partially works, but I am not sure if the output data is completely good because the visibility is not well behaved.
Since I do not understand very good the inner reduction of amical, I have two possible ideas why I have this problem.

VISIR/SAM mode does not have an exposure calulcator to obtain a good SNR, therefore the integration time of our observations is not enough to calculate the observables. Actually I cannot run amical with allowing clip=True

On one of my diagnostic plots the splodge positions looks very shifted respect to the power spectrum and it cannot do the fit well

I should modify my input parameters but I do not kwow which one.
Do you have any idea how to fix it? (As a comment, I use exactly the same input file example_SPHERE.py, but with my data)


Added mysqli support to replace old deprecated mysql functions

In the installation module, old MySQL deprecated functions were used, I have updated the same using mysqli object oriented way.

Coverage remained the same at 41.52% when pulling cc5339133bfd01a117a06f363a21d0f7921ba61f on RohanSakhale:install-support-mysqli into 452ad1c165f47b522d09d312d966b86d1cd6ebf5 on boxbilling:master.

Seems that boxbilling is back!

Fantastic!

Le 23 mai 2018 à 17:36, psycholyzern<EMAIL_ADDRESS>a écrit :
Seems that boxbilling is back!
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

We never left & we do closely monitor our GitHub & we do still respond to support tickets.

you say "We never left", while you merging a pull request from 2016.... :D

I have been looking at this GitHub for 2 years, I did this pull request now as it was authorised - I'm looking at 4 pull requests currently to be merged. I'm sorry if you believe this is well overdue.


Commissioning support for product line nrf52811

Hi I am trying to implement Openthread for a device on a Nrf52811 controller. I have been warned about the lack of 192 kb memory and the lack of a acceleration module. But nevertheless, the protocol does not take up much space, even a little remains for its software. And the acceleration can be transferred to the program.
So what I was trying to do:

Build Openthread firmware for nrf52811
I use libmbedcrypto-software.a in the makefile due to the fact that nrf52811 does not support hardware acceleration, instead of libmbedcrypto.a
in the main code main.c I use the inclusion of Openthread by the function from the otJoinerStart API
from the last repository Openthread collected libraries for nrf52811 with the key JOINER = 1

Where did I get my knowledge:
https://infocenter.nordicsemi.com/index.jsp?topic=%2Fcom.nordic.infocenter.thread_zigbee.v2.0.0%2Fthread_openthread_libraries.html&cp=4_2_0_1_0_8_0&anchor=openthread_libs
Help me find the right solution to build an NRF52811 with joiner support

@oc1tane , thanks for reaching out. This concern is not just code size, but also available RAM. The steps below should get you a build of MTD with JOINER enabled:

Set OPENTHREAD_CONFIG_MESSAGE_USE_HEAP_ENABLE to 1.
./bootstrap
make -f examples/Makefile-nrf52811 JOINER=1

Hope that helps.

Thanks for the quick reply, indeed I did so...
Compiled the libraries of the thread downloaded through the git and slipped them into the directory of the SDK Nordic
./openthread/output/nrf52811/lib (folder openthread from github) -> (to)  ./external/openthread/lib/nrf52811/gcc (folder SDK Nordic v.4.0)

/usr/local/Cellar/arm-none-eabi-gcc/9-2019-q4-major/gcc/bin/../lib/gcc/arm-none-eabi/9.2.1/../../../../arm-none-eabi/bin/ld: <PATH_TO_NORDICSDK>/v4.0/external/openthread/lib/nrf52811/gcc/libopenthread-nrf52811-sdk.a(libopenthread_nrf52811_sdk_a-alarm.o): in function nrf_rtc_event_pending': <PATH_TO_OPENTHREAD>/openthread/examples/../third_party/NordicSemiconductor/nrfx/hal/nrf_rtc.h:352: multiple definition of RTC1_IRQHandler'; _build/nrf52811_xxaa/drv_rtc.c.o:<PATH_TO_NORDICSDK>/v4.0/components/libraries/timer/drv_rtc.c:349: first defined here
/usr/local/Cellar/arm-none-eabi-gcc/9-2019-q4-major/gcc/bin/../lib/gcc/arm-none-eabi/9.2.1/../../../../arm-none-eabi/bin/ld: _build/nrf52811_xxaa/main.c.o: in function joiner_timer_handler': <PATH_TO_OPENTHREAD>/Other/magnetic/pca10056/blank/armgcc/../../../main.c:370: undefined reference to otJoinerStart'
/usr/local/Cellar/arm-none-eabi-gcc/9-2019-q4-major/gcc/bin/../lib/gcc/arm-none-eabi/9.2.1/../../../../arm-none-eabi/bin/ld: _build/nrf52811_xxaa/thread_utils.c.o: in function platform_init': <PATH_TO_NORDICSDK>/v4.0/components/thread/utils/thread_utils.c:129: undefined reference to otHeapSetCAllocFree'
/usr/local/Cellar/arm-none-eabi-gcc/9-2019-q4-major/gcc/bin/../lib/gcc/arm-none-eabi/9.2.1/../../../../arm-none-eabi/bin/ld: <PATH_TO_NORDICSDK>/v4.0/external/openthread/lib/nrf52811/gcc/libopenthread-nrf52811-sdk.a(libopenthread_nrf52811_sdk_a-system.o): in function otSysDeinit': <PATH_TO_OPENTHREAD>/openthread/examples/../examples/platforms/nrf528xx/src/system.c:122: undefined reference to nrf5TransportDeinit'
/usr/local/Cellar/arm-none-eabi-gcc/9-2019-q4-major/gcc/bin/../lib/gcc/arm-none-eabi/9.2.1/../../../../arm-none-eabi/bin/ld: <PATH_TO_NORDICSDK>/v4.0/external/openthread/lib/nrf52811/gcc/libopenthread-nrf52811-sdk.a(libopenthread_nrf52811_sdk_a-system.o): in function otSysInit': <PATH_TO_OPENTHREAD>/openthread/examples/../examples/platforms/nrf528xx/src/system.c:101: undefined reference to nrf5TransportInit'
/usr/local/Cellar/arm-none-eabi-gcc/9-2019-q4-major/gcc/bin/../lib/gcc/arm-none-eabi/9.2.1/../../../../arm-none-eabi/bin/ld: <PATH_TO_NORDICSDK>/v4.0/external/openthread/lib/nrf52811/gcc/libopenthread-nrf52811-sdk.a(libopenthread_nrf52811_sdk_a-system.o): in function otSysProcessDrivers': <PATH_TO_OPENTHREAD>/openthread/examples/../examples/platforms/nrf528xx/src/system.c:142: undefined reference to nrf5TransportProcess'
/usr/local/Cellar/arm-none-eabi-gcc/9-2019-q4-major/gcc/bin/../lib/gcc/arm-none-eabi/9.2.1/../../../../arm-none-eabi/bin/ld: <PATH_TO_NORDICSDK>/v4.0/external/openthread/lib/nrf52811/gcc/libopenthread-nrf52811-sdk.a(libopenthread_nrf52811_sdk_a-flash_nosd.o): in function nrf5FlashPageErase': <PATH_TO_OPENTHREAD>/openthread/examples/../examples/platforms/nrf528xx/src/flash_nosd.c:36: undefined reference to nrfx_nvmc_page_erase'
/usr/local/Cellar/arm-none-eabi-gcc/9-2019-q4-major/gcc/bin/../lib/gcc/arm-none-eabi/9.2.1/../../../../arm-none-eabi/bin/ld: <PATH_TO_NORDICSDK>/v4.0/external/openthread/lib/nrf52811/gcc/libopenthread-nrf52811-sdk.a(libopenthread_nrf52811_sdk_a-flash_nosd.o): in function nrf5FlashWrite': <PATH_TO_OPENTHREAD>/openthread/examples/../examples/platforms/nrf528xx/src/flash_nosd.c:48: undefined reference to nrfx_nvmc_bytes_write'
collect2: error: ld returned 1 exit status

@oc1tane , for questions specific to the Nordic SDK, I suggest posting in Nordic DevZone.
/cc/ @LuDuda

Hello @oc1tane,
As Jonathan mentioned, please create a ticker on Nordic's DevZone.
To give you some hints:

It seems you use nRF5 SDK for T&Z in version 4.0, but you pasted instruction to version 2.0. I suggest to migrate to follow steps for 4.0 version - link.
nRF5 SDK in version 4.0 was based on specific OpenThread commit. It is possible to upgrade it to the newest version, however there might be a lot of warnings/errors that you would need to solve, since master progressed a lot from that moment. I would suggest to checkout OpenThread to this commit as a first step.
The error log undefined reference to otJoinerStart' might suggest that new libraries generated by you don't have Joiner support. Make sure to do make -f examples/Makefile-nrf52811 clean before building with new switches.

I was able to compile and run the application except for an error that causes a heap in thread_utils. I commented out the platform_init () function and the firmware began to weigh about 178 kb, which allows it to be flashed to nrf52811, but the problem is that the entire timer began to work involuntarily, and the joiner does not occur when the button is pressed. Apparently this function is very important how can it be repaired?
/usr/local/Cellar/arm-none-eabi-gcc/9-2019-q4-major/gcc/bin/../lib/gcc/arm-none-eabi/9.2.1/../../../../arm-none-eabi/bin/ld: _build/nrf52811_xxaa/thread_utils.c.o: in function platform_init':
/Downloads/nRF5_SDK_for_Thread_and_Zigbee_v4.1.0_32ce5f8/components/thread/utils/thread_utils.c:129: undefined reference to otHeapSetCAllocFree' collect2: error: ld returned 1 exit status


documentation about the pieces

not so much a bug as a documentation request
I didn't know there were pieces until I found the soon-to-be-obsolete sourceforge link that pointed
to the pieces:
https://github.com/nasa/SC
https://github.com/nasa/SCH
https://github.com/nasa/FM
https://github.com/nasa/MM
https://github.com/nasa/HK
https://github.com/nasa/HS
https://github.com/nasa/DS
https://github.com/nasa/CF
https://github.com/nasa/SBN
could you put cFS under a different directory, for example, https://github.com/nasa/cFS_and_pieces/?
the reason is,  https://github.com/nasa/ contains a lot of stuff, so the cFS pieces are not easy to find
also, when I grab cFS through git are these parts included in the build of cFS?
and if so, then in what subdirectory can I find their source?

I apologize, I realize now this should go into discussions

Closing as cFS apps, libraries, and tools are listed in README.


Make health indicator on index page

DoD:
there should be statuses: on the front page of the project.

Python script(s) statuses
1-1) Python scripts DB connection statuses
Database statuses
Golang statuses
RabbitMQ statuses
Metric for online users number.

[X] webserver_auth
[] webserver_websockets
[X] db server
[ ] mq server
[ ] gameserver

Prolly should close for now and open two tasks for webserver_sockets and gameserver healths.


Add documentation for implements in the class chapter

I realized that there already is documentation for this in the interfaces chapter. :/

Oops, I'll take a look to see if I can merge it somehow.


Prevent space bombs

The Candid serialisation format has two singleton types whose encoding size is zero: null and reserved. That means that an array of arbitrary size over these types (or a super-type like opt t) can be represented in constant space in the serialisation format, but may blow up arbitrarily on the receiver side, creating the risk of DoS attacks.
The space savings from this representation (as opposed to a single byte) are probably not significant for practical use cases, because there normally is little value in passing data of singleton types in the first place.
We should hence change the representation. The challenge is how to do that in a sufficiently backwards-compatible manner.

I'm not sure how much of a problem this is? Presumably a canister has to do sanity checking of all input from untrusted sources anyways, e.g. after decoding check that arrays are not too large. So this Candid space bomb will either exhaust the instruction limit for this message, or be caught then. In neither case, the huge list will actually hit persistent storage.
It might have been worth starting differently, but we knew about this, didn't we? So not sure if it's worth doing breaking changes for this now.

Also, out of curiosity, how do interop protocols that support compression on the transport layer deal with this? Most compression algorithms allow for such space bombs?

Yeah, I wonder if it's worth fixing. We always do subtype checking before decoding. Unless the receiver expects a vec null/reserved type, sending such a vector will be rejected immediately.
Suppose null now takes one byte, then the maximal vector we can send is 2M (message size limit). Maybe in the spec, we can say the number of null/reserved values in a message should be less than 2M?

Unless the receiver expects a vec null/reserved type, sending such a vector will be rejected immediately.

Not quite – as @nomeata reminded me earlier in private conversation, you can send a vec null to a canister expecting a vec opt t, due to subtyping.

@rossberg @nomeata With the extensible variant change, users can now send opt vec null to a function that expects opt nat. I wonder what's the best non-breaking change we can make to the spec?
One idea is to limit the size of vec null/vec reserved on the wire. vec opt empty is isomorphic to vec null, but it's not zero sized, so it's not a problem.

But in that case, the vec null wouldn't be decoded to a huge value, would it? The subtype check would run first, and just return null?
The code that then skips over the vec null value would naively stupidly count down the size of that vector; presumably that can be optimized, as so:
https://github.com/dfinity/motoko/blob/7d413846d8ab050fdab2b27678daf24b92fb17a9/rts/motoko-rts/src/idl.rs#L307-L10

With the variant spec change, we only check subtyping for reference types. So for decoding opt nat, we will have to decode a huge vector.

I have to page it all back in, sorry. So what's happening is that it tries to decide the vec null as an int, but this fails (dynamically), and due to the special rules for opt this becomes null?
In that case the (implementation) question would be whether the decoder fails before actually materializing the vector. I think the Motoko decoder would. More naive ones (like the Haskell one) probably don't.
I don't see much room for wire format changes (e.g. don't allow zero sized values in vectors); wouldn't that break existing clients? Or is that breakage acceptable?

We should add a test excercising this to the test suite, to incentives fixes :-)
I think in the Haskell code I'll add a special form “Vector of constant value” (Replicated :: Natural -> Value -> Value). When decoding, I can recognize a zero size element and decode efficiently to that form, and then later the coercion code can take it from there. So no large architectural changed needed. Maybe the same approach works for rust.

It looks like the code for skipping  a vec does the right thing in Motoko.
If decode the first element makes no progess through the buffer, just return.
unsafe fn skip_any_vec(buf: *mut Buf, typtbl: *mut *mut u8, t: i32, count: u32) {
    if count == 0 {
        return;
    }
    let ptr_before = (*buf).ptr;
    skip_any(buf, typtbl, t, 0);
    let ptr_after = (*buf).ptr;
    if ptr_after == ptr_before {
        // this looks like a vec null bomb, or equivalent, where skip_any
        // makes no progress. No point in calling it over and over again.
        // (This is easier to detect this way than by analyzing the type table,
        // where we’d have to chase single-field-records.)
        return;
    }
    for _ in 1..count {
        skip_any(buf, typtbl, t, 0);
    }
}

Not sure I understand what the Motoko deserializer is doing in this case. Perhaps @nomeata can confirm it is ok.

I think the Motoko deserializer is indeed ok. We should add test that blow up for implementations that aren't ok to the official test suite.


adviceDebug and aggregateAdvice should fail if there are errors

I specified the following configuration:
dependencyAnalysis {
    issues {
        all {
            onAny {
                severity('fail')
            }
        }
    }
}

When I add an unused dependency intentionally and run buildHealth then the task fails. However, when I run adviceDebug or aggregateAdvice on the module with the unused dependency, both task finish successfully. I would expect them to finish with a failure.

The problem with buildHealth in my case is that the project is very large and running it takes more than ten minutes. I'd rather run a smaller task for the module I'm currently modifying.

@bartek-wesolowski , how come you created an issue 13.5 hours earlier? 🙀
Other than that, I fully support this request :)

Copy-pasting from 275

My current plan for this is to use the gradle.buildFinished() listener as the only point of advice-failure. I don't want individual tasks to fail because if a user runs buildHealth I want the whole build to finish and only then fail. If I collect all failures during the build, I can check that collection in the buildFinished listener, and react accordingly.

I suppose @vlsi is right, this issue came first ;-)

autonomousapps: As I have said several times, the intended end-user task is buildHealth. If that build failed early, because a subsidiary task failed, it would be a Bad Thing.

I believe users can decide which failure is important and which is not.
They can add use --continue, they can use mustExecuteAfter, and they can use an extra Gradle execution.
However, I expect that a common use case would be to add check { dependsOn("buildHealth") } dependency, so users do not really call buildHealth manually because they don't really need to know of such a task.

Relates to https://github.com/gradle/gradle/issues/14553.

The associated PR resolves this issue to my satisfaction. However, it does not meet the articulated desire of failing on adviceDebug. Instead:

A new task is registered on each module: :module:projectHealth. This task aggregates tasks like :module:adviceDebug, :module:adviceRelease, etc. This projectHealth task will fail if severity has been set to fail.
:failOrWarn has been removed. :buildHealth will now fail directly if there is any issue in a build where severity has been set to fail.

There are a couple of consequences of this:

You can also run projectHealth and it will sort-of-kind-of-almost mimic :buildHealth insofar as it runs all the advice tasks in all the projects. A failure in any project would immediately fail the build, and you could also run projectHealth --continue and have the build keep going even in the face of one or more failures. It's not like :buildHealth in that only the latter produces a file output that is a List<BuildHealth>, and only the latter would trigger the post-analysis task, should there be one.
This change further formalizes the intended "API" of this plugin. I expect users to primarily run projectHealth and buildHealth. I do not intend to provide additional support for direct invocations of tasks like adviceDebug. In particular, these variant-specific tasks will never fail, regardless of the severity level.

The wiki will be updated accordingly.

Thanks.
In practice, #289 is almost the same as I suggested in #275 modulo task names:

Vladimir: Note: I know the current aggregateAdvice performs computations, and what I suggest is to use a technical (hidden from users) task to perform computations, and make aggregateAdvice always-stale task that would print advice and it would fail as it is necessary.


Add half precision testing [1/n]

Before submitting

[x] Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
[x] Did you read the contributor guideline, Pull Request section?
[x] Did you make sure to update the docs?
[x] Did you write any new necessary tests?

What does this PR do?
Issue https://github.com/PyTorchLightning/metrics/issues/57
Adds testing interface for half precision and apply to few metrics.
Follow up PRs will add the testing to remaining metrics and add documentation to metrics where it will not work.
Note, that we cannot really do anything about it not working for some of the metrics as some pytorch operations (e.g torch.log) does not support half precision + cpu.
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃

can we rather use this function version? https://github.com/PyTorchLightning/pytorch-lightning/pull/6434

can we rather use this function version? PyTorchLightning/pytorch-lightning#6434

Of course :]

@SkafteNicki mind resolve conflicts... :]


Error: command error: failed to load modules: module xxx/xxx not found in  either add it as a Hugo Module or store it in "xxx/themes".: module does not exist

Hi:
After I upgraded the theme to the latest version V3, I encountered an error， as follows:
Error: command error: failed to load modules: module "github.com/hugomods/icons/vendors/lucide" not found in "/Users/wanzi/github/wzdushu/wnote/themes/github.com/hugomods/icons/vendors/lucide"; either add it as a Hugo Module or store it in "/Users/wanzi/github/wzdushu/wnote/themes".: module does not exist
Then I executed the following operations without any problem, but the same error occurred when starting hugo. Is it because of my path problem?：
cd /Users/wanzi/github/wzdushu/wnote/themes/jane
hugo mod get github.com/hugomods/icons/vendors/mdi
hugo mod get github.com/hugomods/icons/vendors/lucide

My hugo and golang version:
hugo v0.136.0+extended darwin/arm64 BuildDate=2024-10-15T13:17:24Z VendorInfo=brew
go1.23.2 darwin/arm64

My hugo project directory structure：
> pwd
/Users/wanzi/github/wzdushu/wnote
> tree -L 2
.
├── archetypes
│   └── default.md
├── config.toml
├── content
│   ├── about.md
│   ├── notes.md
│   └── post
├── data
├── layouts
├── public
├── static
└── themes
    └── jane

10 directories, 4 files

You will need to initialize Hugo Modules (go.mod), and then Hugo will start downloading the required modules when building the site and starting the server.
$ cd /path/to/yoursite
$ hugo mod init github.com/yourname/yourrepo
$ hugo server

Thank you very much for your feedback. This was indeed an oversight on my part, and I will update the README.md file as soon as possible.

The current issue is a bit beyond my expectations.
I didn't consider that using Hugo modules would require installing the Go language environment, as I already had Go installed on my computer.
If this is the case, I might need to think about it more carefully.
It's possible that removing the Hugo modules might be a better option... I don't want installing Go to be a must choice.
Give me some time to consider how to better handle this issue.

I referred to your Github action configuration, I lowered my Hugo version, and now I can start the server and generate static pages normally.
It is indeed necessary to update the read document, which must rely on the Go module. In addition, you need to pay attention to the go version and hugo version.

您需要初始化 Hugo 模块（go.mod），然后 Hugo 将在构建站点和启动服务器时开始下载所需的模块。
$ cd /path/to/yoursite
$ hugo mod init github.com/yourname/yourrepo
$ hugo server

Yeah, I know I need to initialize the go module. I tried it but it didn’t work. Finally, I lowered the hugo version to 0.121.0 to keep it consistent with the author.

fixed in 35c16043ca4169ba2bcc4dc30c9a4ed8802649cb . Now, we don't need hugo modules.


404 pages are looking different for different screen sizes

Note: for support questions, please use stackoverflow. This repository's issues are reserved for feature requests and bug reports.

I'm submitting a ...

[x] bug report
[ ] feature request
[ ] support request => Please do not submit support request here, see note at the top of this template.

Do you want to request a feature or report a bug?

What is the current behavior?
404 pages are looking different for different screen sizes.
Details here

If the current behavior is a bug, please provide the steps to reproduce, ideally also a screenshot or gif if it's a style issue

What is the expected behavior?
To be discussed

What is the motivation / use case for changing the behavior?

Other information (e.g. detailed explanation, stacktraces, related issues, suggestions how to fix, links for us to have context, eg. stackoverflow, gitter, etc)

Probably fixed already


Fix bug with incorrect high and low values when trend is used

bug fixed, example:

Implement since build v1.3.dev78
Debug build: https://app.travis-ci.com/github/Tim55667757/PriceGenerator/builds/259412521
PyPI artifact for testing: https://pypi.org/project/pricegenerator/1.3.dev78/


fix: websocket timing bug

Signed-off-by: Ammon Burgi<EMAIL_ADDRESS>Summary of Changes

Fix for Websocket timing bug

Related Issues
N/A
Pull Request Checklist
This is just a reminder about the most common mistakes. Please make sure that you tick all appropriate boxes. But please read our contribution guide at least once; it will save you a few review cycles!
If an item doesn't apply to your pull request, check it anyway to make it apparent that there's nothing to do.

[ x ] All commits contain a DCO Signed-off-by line (we use the DCO GitHub app to enforce this).
[ ] Updated LICENSE-3RD-PARTY.md for any added dependencies or vendored components.
[ ] Added tests for changed code (run scripts/preflight to run tests and check code style).
[ ] Prefixed code comments with GitHub nick and an appropriate prefix.
[ x ] Coding style is consistent with the rest of the framework.
[ ] Updated documentation for changed code and new or modified features.

If you have any questions to any of the points above, just submit and ask! This checklist is here to help you, not to deter you from contributing!
PR template adapted from the Python attrs project.

Merging with Main


E1017 with nested !Select

cfn-lint version: (cfn-lint --version)
0.46.0
Description of issue.
When linting this CFT YAML:
subnet0A:
    DependsOn: ipv6CidrBlock
    Type: 'AWS::EC2::Subnet'
    Properties:
      VpcId: !Ref vpc
      CidrBlock: !Select
        - !Select
          - 1
          - !Split
            - ','
            - !FindInMap
              - subnetMap
              - !Ref numAzs
              - !Ref numSubnets
        - 'Fn::Cidr':
            - !GetAtt
              - vpc
              - CidrBlock
            - !Select
              - 0
              - !Split
                - ','
                - !FindInMap
                  - subnetMap
                  - !Ref numAzs
                  - !Ref numSubnets
            - !FindInMap
              - subnetMap
              - maskTocidrBits
              - !Ref subnetMask

I get this error:
E1017 Select index should be an Integer or a function Ref or FindInMap for Resources/subnet0A/Properties/CidrBlock/Fn::Select
Template works fine.
thanks
Cfn-lint uses the CloudFormation Resource Specifications as the base to do validation. These files are included as part of the application version. Please update to the latest version of cfn-lint or update the spec files manually (cfn-lint -u)

https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/intrinsic-function-reference-select.html#w2ab1c33c28c51c15 says it only supports Ref and FindInMap.  It looks like that may be inaccurate and you can also embed another select?

Correct, it seems to work for me anyway.


Move pipelines to store [WIP]

This pull requests moves the pipelines (not the datasets yet) to the store and wires up the react components to function with these new pipelines.
To test this, you can simply attempt to bind data to a mark and notice that the pipeline objects are now objects in the redux store, but overall functionality is still maintained.

Hi @nikhilkhanna, I've merged some older PRs in from the end of the Bocoup engagement and that's created some conflicts on this branch. Could you rebase and push so that I can merge w/o conflicts? It would also be good to get rid of the three unrelated commits at the head of this PR (regarding the Dockerfile). Thanks!


Custom final message on keyboard interrupt

This PR introduces an additional kwarg named keyboard_interrupt_msg, which let's you customize the output of whaaaaat when a user hits ctrl+c. Now hardcodede as Cancelled by user, this let's you do something like this:
prompt(questions, style=style, keyboard_interrupt_msg="Ok ok, I'm backing off! See ya later")

which would result in:
[?] Some question where you hit ctrl+c

Ok ok, I'm backing off! See ya later

I understand that you want to add a lot of additional features to whaaaaat but this is not what we intended. whaaaaat is supposed to be a small library (like a building block). If you want to implement more complex dialogues I suggest you use something like https://github.com/finklabs/banana or write your own.


v0.4.0 Cant save the report due to missing timedelta

DEBUG:http://klustair-frontend:80 "POST /api/v1/pac/report/16eecc80-bb87-464b-8b2b-f305b62fecd2/summary/create HTTP/1.1" 200 328
Traceback (most recent call last):
File "/app/./runner.py", line 370, in
run()
File "/app/./runner.py", line 300, in run
api.cleanupDB(args.limitDate, args.limitNr)
File "/app/api.py", line 81, in cleanupDB
d = timedelta(days = int(limitDate))
ValueError: invalid literal for int() with base 10: 'false'

Workaround: add aLIMITDATE (-ld) parameter.

This should be fixed now. v0.4.0 was rebuilt and published.
https://github.com/klustair/klustair/commit/9405846e571fd90d0feae7957e9a9b6c843edd68


Design proposal for integration

Closing as a duplicate of https://github.com/opensearch-project/OpenSearch/issues/4555


Westinm/claims mapping

Map claims in JsonWebTokenHandler. Move the ClaimTypeMapping class into TokenUtilities.

I wasn't sure what from JwtSecurityTokenHandler should be moved up to TokenHandler; let me know your thoughts.


Nested menu design

For patterns in the UI where there are nested menus (such as network selector in top nav and language selector), we should have a better pattern for how to handle those. Screenshot examples below:

Wallet menu in design system with nested menu switcher is ready
https://www.figma.com/design/ur5hElxplkmlY9gnGKlwrm/Components-%26-Styles---Decent-Design-System-1.0.0?m=auto&node-id=2168%3A20014&t=QRpmoGVZcRiSRtD3-1

@nicolaus-sherrill Sidebar language nested menu. I think just using the same expanded sidebar menu component is the way to go. Mocked up here https://www.figma.com/design/ur5hElxplkmlY9gnGKlwrm/Components-%26-Styles---Decent-Design-System-1.0.0?node-id=2919-7224&t=QRpmoGVZcRiSRtD3-4

@decentdao/design does this issue still need to be open?

@adamgall well without a languages menu option, I would think not.


Does not play a sound

installed the plugin but it didn't make a sound. tried change settings to enable/disable, play only in editor or not, toggled mute mode, but nothing works.
Running on pycharm pro 2020.1.1

@Demyxter @eduhoribe thanks for reporting and especially for stacktrace! We just released version 1.0.2, where the issue should be fixed


px4fmu-v3_default binary naming

The px4fmu-v3_default was merged with px4fmu-v2_default plus access to an additional 1MB of flash. The output binary of the px4fmu-v3_default build is named px4fmu-v2_default, which needs to be fixed for the s3 deploy (QGC download).

@dagar Have you a chance to wrap this up this weekend?


[BUG] freeze and crash visual studio

Description
Keep crash visual studio if add such code:
To Reproduce

Create an empty project, target to .Net 6.
Paste code, visual studio should freeze, then crash:

using PropertyChanged.SourceGenerator;

namespace Test1;
partial record Class1(Class1 Class1)
{
    [Notify] string _value;
}

Version Info

PropertyChanged.SourceGenerator version: 1.0.5
Roslyn version: 4.3.0-3.22470.13 (80a8ce8d)
Visual Studio version: 17.3.5

Good spot, thanks!

This will be fixed in 1.0.6 shortly

You are the fastest developer I have met.


FATAL: Cannot find subcommand for: 'tidy backup clean'

Following the instructions for installing knife-tidy, to get rid of the chef sugar errors during restore, I am executing the following steps:
$chef gem install knife-tidy
or
$git clone https://github.com/chef-customers/knife-tidy.git
$cd knife-tidy
$cp conf/substitutions.json.example conf/substitutions.json
$knife tidy backup clean --backup-path /path/to/your/backup --gsub-file conf/substitutions.json
As for the last command, i get:
-bash-4.1# knife tidy backup clean --backup-path ../backup_8_28_2017_315PM --gsub-file conf/substitutions.json
FATAL: Cannot find subcommand for: 'tidy backup clean --backup-path ../backup_8_28_2017_315PM --gsub-file conf/substitutions.json'
Available subcommands: (for details, knife SUB-COMMAND --help)

@kamal2222ahmed sorry about this issue.  It should be corrected in the most recent versions.
Please uninstall all previous versions and install latest.
~/Devel/ChefProject/chef-server-vagrant (master *%=)$ chef gem uninstall knife-tidy

Select gem to uninstall:
 1. knife-tidy-0.1.0
 2. knife-tidy-0.1.1
 3. knife-tidy-0.2.0
 4. knife-tidy-0.2.1
 5. knife-tidy-0.2.2
 6. knife-tidy-0.2.3
 7. knife-tidy-0.2.4
 8. All versions
> 8
Successfully uninstalled knife-tidy-0.1.0
Successfully uninstalled knife-tidy-0.1.1
Successfully uninstalled knife-tidy-0.2.0
Successfully uninstalled knife-tidy-0.2.1
Successfully uninstalled knife-tidy-0.2.2
Successfully uninstalled knife-tidy-0.2.3
Successfully uninstalled knife-tidy-0.2.4
~/Devel/ChefProject/chef-server-vagrant (master *%=)$ chef gem install knife-tidy
Fetching: knife-tidy-0.2.4.gem (100%)
Successfully installed knife-tidy-0.2.4
1 gem installed
~/Devel/ChefProject/chef-server-vagrant (master *%=)$ knife tidy backup clean --backup-path backups --gsub-file ../knife-tidy/conf/substitutions.json
INFO: Validating admin
INFO: Validating delivery
INFO: Validating john
INFO: Validating pivotal
INFO: Loading users
INFO: Loading members for acmeinc
INFO: Loading clients for acmeinc
INFO: Loading groups for acmeinc
INFO: acmeinc Actors loaded!
INFO: Loading users
INFO: Loading members for brewinc
INFO: Loading clients for brewinc
INFO: Loading groups for brewinc
INFO: brewinc Actors loaded!
INFO: No metadata.rb in /Users/jmiller/Devel/ChefProject/chef-server-vagrant/backups/organizations/brewinc/cookbooks/compat_resource-12.19.0 - skipping
INFO: Loading audit
INFO: Loading compat_resource
INFO: Generating new metadata.json for /Users/jmiller/Devel/ChefProject/chef-server-vagrant/backups/organizations/brewinc/cookbooks/audit-4.1.0
INFO: No metadata.rb in /Users/jmiller/Devel/ChefProject/chef-server-vagrant/backups/organizations/brewinc/cookbooks/compat_resource-12.19.0 - skipping
** Finished **
~/Devel/ChefProject/chef-server-vagrant (master *%=)$


Move pytest_unordered into a package to fix including py.typed

As far as I can tell, py_modules and package_data don't play well together in setuptools. I found a few other projects with similar issues and the fix seemed to be converting to a package. Tested this with python -m build and inspecting the built wheel.

Released 0.5.1


In Chef 13 cannot find the vgs command. Works in Chef 12.

Cookbook version
4.1.4
Chef-client version
13.2.20
Platform Details
RHEL 7.1
Scenario:
Create a volume group.
Steps to Reproduce:
Run sudo chef-client -c /etc/chef/client.rb -l auto from a CI build.
Expected Result:
Converges fine from a CI build.
Actual Result:
17:06:52                           * lvm_volume_group[sys] action create
17:06:52                             * chef_gem[chef-ruby-lvm-attrib] action install (up to date)
17:06:52                             * chef_gem[chef-ruby-lvm] action install (up to date)
17:06:52
17:06:52                             ================================================================================
17:06:52                             Error executing action `create` on resource 'lvm_volume_group[sys]'
17:06:52                             ================================================================================
17:06:52
17:06:52                             Errno::ENOENT
17:06:52                             -------------
17:06:52                             No such file or directory - vgs
17:06:52
17:06:52                             Cookbook Trace:
17:06:52                             ---------------
17:06:52                             /var/chef/cache/cookbooks/lvm/libraries/provider_lvm_volume_group.rb:125:in `create_volume_group'
17:06:52                             /var/chef/cache/cookbooks/lvm/libraries/provider_lvm_volume_group.rb:60:in `action_create'
17:06:52
17:06:52                             Resource Declaration:
17:06:52                             ---------------------
17:06:52                             # In /var/chef/cache/cookbooks/yahoo-ss-smashhome/recipes/partition_setup.rb
17:06:52
17:06:52                              11: lvm_volume_group 'sys' do
17:06:52                              12:   physical_volumes '/dev/sda3'
17:06:52                              13: end
17:06:52                              14:
17:06:52
17:06:52                             Compiled Resource:
17:06:52                             ------------------
17:06:52                             # Declared in /var/chef/cache/cookbooks/yahoo-ss-smashhome/recipes/partition_setup.rb:11:in `from_file'
17:06:52
17:06:52                             lvm_volume_group("sys") do
17:06:52                               provider Chef::Provider::LvmVolumeGroup
17:06:52                               action :create
17:06:52                               default_guard_interpreter :default
17:06:52                               declared_type :lvm_volume_group
17:06:52                               cookbook_name "yahoo-ss-smashhome"
17:06:52                               recipe_name "partition_setup"
17:06:52                               physical_volumes "/dev/sda3"
17:06:52                             end
17:06:52
17:06:52                             System Info:
17:06:52                             ------------
17:06:52                             chef_version=13.2.20
17:06:52                             platform=redhat
17:06:52                             platform_version=7.1
17:06:52                             ruby=ruby 2.4.1p111 (2017-03-22 revision 58053) [x86_64-linux]
17:06:52                             program_name=chef-client worker: ppid=13881;start=00:06:30;
17:06:52                             executable=/opt/chef/bin/chef-client

This was working fine with chef 12. I've done a little debugging and it looks like the PATH environment variable is different in chef 12 and chef 13.
In Chef 12 the PATH is /usr/local/bin:/usr/bin:/opt/chef/embedded/bin:/opt/chef/embedded/bin:/usr/local/sbin:/usr/sbin:/sbin:/bin on my system during the chef run.
In Chef 13 the PATH is /usr/local/bin:/usr/bin during the chef run.
The vgs command is located in /usr/sbin/vgs and /sbin/vgs. What can I do to make this work?

This may be related to this change: https://github.com/chef/chef/commit/d24976bbd8846a60d186790f38124f312e91473d#diff-d19a42ae266a2919d7cfeb43c77dbaffL253
Looks like the path isn't being sanitized by default anymore.

@chilicheech What's that $PATH variable look like on your system?

@tas50 When I ssh to the box and get a login shell the path is: /usr/local/bin:/usr/bin:/usr/local/sbin:/usr/sbin
Without a login shell, such as when running ssh username@hostname sudo chef-client from a CI build, the path is: /usr/local/bin:/usr/bin

Just ran into this same issue on Chef 13.6

If you upgrade to a later Chef 13 release this will be resolved.


HDDS-5719. Reduce number of mini-clusters needed for decommission tests

What changes were proposed in this pull request?
There are a few scenarios in the decommission and maintenance integration tests that can be combined into the same test, reducing the number of mini-clusters needed. There changes reduce the number of tests (and clusters) by 3.
The last runtime for the decommission tests was:
[INFO] Running org.apache.hadoop.ozone.scm.node.TestDecommissionAndMaintenance
[INFO] Tests run: 11, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 389.226 s - in org.apache.hadoop.ozone.scm.node.TestDecommissionAndMaintenance

What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-5719
How was this patch tested?
Existing tests

The new code ran in:
[INFO] Running org.apache.hadoop.ozone.scm.node.TestDecommissionAndMaintenance
[INFO] Tests run: 8, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 371.798 s - in org.apache.hadoop.ozone.scm.node.TestDecommissionAndMaintenance

Saving about 18 seconds. This is only a small gain, but the cluster in these tests are created in the background, so it does save some parallel CPU overhead.


Lauren & Mark's blog post loading funky

We talked about this but please let me know if you need details.
https://suncoast.io/blog/instructor-mark-dewey-on-how-react-can-help-land-you-a-job

Replaced image and fixed.


Favicon changes after clicking on a link on iPad

On iPad the bsky Favicon changes to the one of the last Website I clicked a link while scrolling through my timeline.
See attached examples.

I'm using Safari on an iPad Pro 11 with iPadOS 17.0.3

This is most likely a bug in iPadOS since our favicon support is not browser-specific and this error cannot be reproduced by me on any desktop browsers.
For now, I am closing this issue but feel free to comment here if this issue is reproducible on other platforms as well.


Could not load file or assembly 'Esri.ArcGISRuntime, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=8fc3cc631e44ad86'

I am trying to create map using Esri.ArcGISRuntime.Xamarin.Forms nuget. For this I have created new project in Xamarin.Forms and installed this nuget. Then I have write this code:
Initialize Map key in App.xaml.cs
public partial class App : Application
{
   public App()
   {
       InitializeComponent();

       Esri.ArcGISRuntime.ArcGISRuntimeEnvironment.ApiKey = "my_api_key";
       MainPage = new MainPage();
   }
}

MainPage.xaml: Map UI
<ContentPage xmlns="http://xamarin.com/schemas/2014/forms"
             xmlns:x="http://schemas.microsoft.com/winfx/2009/xaml"
             xmlns:esriUI="clr-namespace:Esri.ArcGISRuntime.Xamarin.Forms;assembly=Esri.ArcGISRuntime.Xamarin.Forms"
             xmlns:vm="clr-namespace:ArcGis_POC"
             x:Class="ArcGis_POC.MainPage">
    <ContentPage.BindingContext>
        <vm:MainPageViewModel />
    </ContentPage.BindingContext>
    <StackLayout>
        <esriUI:MapView x:Name="MyMapView" />
    </StackLayout>
</ContentPage>

MainPage.xaml.cs
public partial class MainPage : ContentPage
{
    public MainPageViewModel thisVm;

    public MainPage()
    {
        InitializeComponent();

        thisVm = ((MainPageViewModel)BindingContext);
        thisVm.SetupMap();
    }
}

MainPageViewModel
public class MainPageViewModel : BaseViewModel
{
    private Map _map;
    public Map Map
    {
        get { return _map; }
        set
        {
            _map = value;
            OnPropertyChanged();
        }
    }

    public void SetupMap()
    {
        // Create a new map with a 'topographic vector' basemap.
        Map = new Map(BasemapStyle.ArcGISTopographic);
    }
}

When I am trying to run thi46application in UWP with x64/x86 setup it gives this error. Anyone know how to fix this?
System.BadImageFormatException
  HResult=0x80131058
  Message=Could not load file or assembly 'Esri.ArcGISRuntime, Version=<IP_ADDRESS>,
  Culture=neutral, PublicKeyToken=8fc3cc631e44ad86'. Reference assemblies should not be loaded for
  execution.  They can only be loaded in the Reflection-only loader context. (Exception from HRESULT: 0x80131058)
  Source=ArcGis_POC

I have also tried to install Esri.ArcGISRuntime.UWP in UWP project individually but it also gives this error
Severity Code Description Project File Line Suppression State
Error NU1202	Package Esri.ArcGISRuntime.UWP 100.13.0 is not compatible with uap10.0.16299
(UAP,Version=v10.0.16299) / win10-arm64-aot. Package Esri.ArcGISRuntime.UWP 100.13.0
supports: uap10.0.18362 (UAP,Version=v10.0.18362)

In Android it runs but shows blank white screen.
Nugets I'm using:
:white_check_mark: Esri.ArcGISRuntime.Xamarin.Forms (100.13.0)
:white_check_mark: Xamarin.Forms (<IP_ADDRESS>1)
:white_check_mark: Xamarin.Essentials (1.7.0)
:white_check_mark: NETStandard.Library (2.0.3)

@divyesh008

For this I have created new project in Xamarin.Forms

Which project template did you start with in Visual Studio?

I have also tried to install Esri.ArcGISRuntime.UWP in UWP project individually but it also gives this error Error NU1202	Package Esri.ArcGISRuntime.UWP 100.13.0 is not compatible with uap10.0.16299

That error indicates the minimum platform version in your UWP project is too low. The minimum is 18362: Package Esri.ArcGISRuntime.UWP 100.13.0 supports: uap10.0.18362 (UAP,Version=v10.0.18362)
For more info see:
https://docs.microsoft.com/en-us/windows/uwp/updates-and-versions/choose-a-uwp-version
https://developers.arcgis.com/net/reference/system-requirements/#uwp-requirements-1


[9.x] Collection times method type error (phpstan)

Laravel Version: 9.5.1
PHP Version: 8.1.x
Database Driver & Version: -

Description:
PHPStan reports an error when the collection method times is called without the callback parameter.
Note: This behaviour is not documented.
Unable to resolve the template type TTimesValue in call to method static method Illuminate\Support\Collection<(int|string), mixed>::times()
Steps To Reproduce:
Collection::times(42);

Possible Solution
I couldn't find a good solution. @return static<int, int|TTimesValue> didn't fix the problem.
Maybe it would be better to require the 2nd parameter callback. In addition, allow a single parameter for the range method.

Hey. No code is broken here so this isn't a bug. If you want to fix a phpstan issue we appreciate prs. Thanks.

Hey @nunomaduro,
maybe you could give me a hint on how to fix this problem? 😃 Would sent than a PR.


Cannot build Docker Image(Type : GPU FrameWork : PyTorch, vitis-ai 3.0)

Hi.
When I build Vitis AI 3.0 Docker Image(using command $ ./docker_build.sh -t gpu -f pytorch), errors like below

what error is this? please help me...

저는 vitis-ai 3.0버전을 꼭 사용하고 싶습니다.

I need to use vitis-ai 3.0 ver

@cksdud1974 , will checking it and update you later

Thank you i can install vitis-ai-t1 ,t2, opt_pytorch but pytorch is not installed
lastweek i'm installed pytorch but now, pytorch is not installed.....


Homebrew formula checksum mismatch

The homebrew formula currently has the wrong sha1 checksum.
$ brew install pick
==> Installing pick from thoughtbot/homebrew-formulae
==> Downloading https://github.com/thoughtbot/pick/releases/download/v1.1.0/pick-1.1.0.tar.gz
Already downloaded: /Library/Caches/Homebrew/pick-1.1.0.tar.gz
Error: SHA1 mismatch
Expected: cec167acc776065c055ab13a918d4e0300dca2f8
Actual: 8b035e64cc5faea407e73cce01ca039e3ce3b4ac
Archive: /Library/Caches/Homebrew/pick-1.1.0.tar.gz
To retry an incomplete download, remove the file above.

I wonder if the @DIST_SHA@ directive in the homebrew template needs to specify the .tag.gz file?

I'm experiencing the same problem.

I fixed the problem locally for me by just following the following steps.
First I ran the following:
brew edit pick
Then changed the following line:
- sha1 "cec167acc776065c055ab13a918d4e0300dca2f8"
+ sha1 "8b035e64cc5faea407e73cce01ca039e3ce3b4ac"

Then ran the following again:
brew install pick
It looks like someone just type-oed the sha1 hash because when I actually download the file from that url and run shasum -a 1 pick-1.1.0.tar.gz I get this hash 8b035e64cc5faea407e73cce01ca039e3ce3b4ac

Closed by https://github.com/thoughtbot/homebrew-formulae/commit/60afac6807473d9288be6f899030da12c9721027


Feat: [OV-45016] Pie Chart Initial Release

Small display problem in the doc.

Small display problem in the doc.

Must be a Mac bug, I'll debug it, thanks.


"layout": "raw" should have unstyled <a /> and <p /> elements as well

otherwise my pagination's buttons with layout: raw have color and underscore

Thanks!


Form control plaintext

https://github.com/kaliber5/ember-bootstrap/issues/498

first problem: BS3 apparently uses
<p<EMAIL_ADDRESS>

@basz thanks for your effort so far! Let's see how to do this...
Indeed BS3 seems to expect completely different markup. That could be a reason to create a completely separate plaintext form control, so we create a component at bs-form/element/control/plaintext.js and have different implementations for BS3 and BS4 (by having separate components in the respective bs3/bs4 folders).
So the API from the user's PoV would be something like {{form.element type="plaintext" label=".." ...}}.
Would that make sense? This would not allow for different input types in the case of BS4 (like email), but would that even be useful given they are readonly anyways?

Ok agreed. I’ll go ahead and refactor this a bit.
Read only email tel; etc, makes sense on a implementations level but functionality wise is seems indeed a bit off.

Op 16 dec. 2017 om 11:03 heeft Simon Ihmig<EMAIL_ADDRESS>het volgende geschreven:
@basz thanks for your effort so far! Let's see how to do this...
Indeed BS3 seems to expect completely different markup. That could be a reason to create a completely separate plaintext form control, so we create a component at bs-form/element/control/plaintext.js and have different implementations for BS3 and BS4 (by having separate components in the respective bs3/bs4 folders).
So the API from the user's PoV would be something like {{form.element type="plaintext" label=".." ...}}.
Would that make sense? This would not allow for different input types in the case of BS4 (like email), but would that even be useful given they are readonly anyways?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

On second thought; who says readonly or disabled needs to be enabled for a plaintext input of types other then text?

found that this renders (almost) what I need without EB changes
{{#form.element controlType="text" size='sm' readonly=true disabled=true value=(t 'table.showingOutOfTotal' this.showingOutOfTotal) as |el|}}
            {{component el.control classNames="form-control-plaintext bg-white"}}
          {{/form.element}}

@basz closing this as the PR seems stale and out-dated. Should you want to continue working on this, feel free to reopen! Thanks


task_aux tables should be excluded

The 3 tables that belong to the task engine and are managed by the task engine should be excluded for a migration.
The 3 tables are

tasks_aux_queue
tasks_aux_workers
tasks_aux_scheduler

The property
migration.data.tables.excluded
should be adjusted.

Thanks for reporting. Fixed in #11


tables after delete or edit dont working. why?

Need more details on the issue.
What exactly happens after deletion or editing?
Do you have any error in the browsers console?

Closing the issue, due to inactivity.


[Channels] No way for Reader to detect Read failure due to Write end completion

Repro repo: https://github.com/anurse/corefxlab-1068-repro
Repro steps:

Clone the above repro repo
Restore and run the console app project

Expected behavior: We are able to gracefully terminate the reader when the channel is closed
Actual behavior: ReadAsync throws an internal exception which we have no way of catching (short of catching Exception and using GetType...gross)
This seems like a case where we need ReadAsync to return a type which can indicate if the task completed due to a result becoming available or because the Channel was closed, similar to how Pipelines has a ReadResult type with an IsCompleted property. I realize there is WaitToReadAsync but I still think there is value in ReadAsync completing in a way that allows the caller to detect why it is completing, even if it is just a public exception type (though I'm always a bit nervous about exceptions-as-control-flow).
/cc @davidfowl @KrzysztofCwalina

cc: @stephentoub

Andrew, if it's blocking you, feel free to make the exception type public, and we'll sort it out when I'm back.

I'll look at that. For now I did a terrible no-good very bad hack :) https://github.com/aspnet/SignalR/commit/944ad6142963061d48462d840d759321a6871bbe#diff-4ccd5d321726b6b360e521c80697e077R188

And I think that because WaitToReadAsync exists, I'd actually be OK with using the exception here. If you really want to have a "clean" and "pure" API, use WaitToReadAsync and TryRead in combination. The only reason I can't use WaitToReadAsync is that I have my own implementation of IReadableChannel that uses a Pipeline under the covers and Pipelines don't really have a clean way to "wait for read" right now so I wasn't able to implement that API. Long-term I expect we'd avoid implementing IReadableChannel but for various reasons that was the easiest first attempt at solving the problem we're exploring :)

Let's make the exception type public for now. :) /cc @stephentoub

Let's make the exception type public for now.

Already did ;)

Exception for close isn't the cleanest way to do it. It would be great if there was a way to detect the end of the channel without an error.

It would be great if there was a way to detect the end of the channel without an error.

The are several:

using WaitForReadAsync, where the returned task will have a result of false if nothing more is or will be available to read
using Completion, which will complete in the same condition
using the async enumerator for the channel, where the task returned from MoveNextAsync has same behavior

What additional way is needed?

using the async enumerator for the channel, where the task returned from MoveNextAsync has same behavior

Too ugly. Needs language support.

using Completion, which will complete in the same condition

Using completion is too error prone. It's easy to check completion at the wrong time which may result in missed data. It may be useful in scenarios where something other than the consumer wants to check if the channel is complete.

using WaitForReadAsync, where the returned task will have a result of false if nothing more is or will be available to read

In the below example, if the producer does WriteAsync followed by Complete() on the channel, will the consumer get that data?
while (await channel.WaitToReadAsync())
{
    ByteBuffer buffer;
    if (channel.TryRead(out buffer))
    {
        ConsumeBuffer(buffer);
    }
}

I haven't looked at the implementation to see if WaitForReadAsync returns true if the consumer hasn't consumed everything. Also does anything change if the channel is unbuffered?

  We're talking about:
var e = c.GetAsyncEnumerator();
while (await e.MoveNextAsync())
{
    Use(e.Current);
}

I agree that language support makes it nicer, e.g.
foreach (await var current in c)
{
    Use(current);
}

but not so much so that it's "too ugly".

language support.

As you know, this is something being actively looked at for C# 8.

Using completion is too error prone. It's easy to check completion at the wrong time which may result in missed data

How so?  A channel isn't considered completed until it's been marked for completion AND it has no more data left to consume.  There is no race condition.

the producer does  WriteAsync  followed by  Complete()  on the channel, will the consumer get that data?

Yes, the consumer will get the data.

Also does anything change if the channel is unbuffered?

No.

How so? A channel isn't considered completed until it's been marked for completion AND it has no more data left to consume. There is no race condition.

If this is the case, then we should be fine. @davidfowl was under the impression (and I thought had done some testing) that it was not. My impression was what @stephentoub indicated, that the completion is only triggered after the last item is read.

Yep, it's ok to close this item


Update README.md

Update documentation and usage

Hello, thanks for the PR, that's a really useful thing to have on the frontpage.
I'll merge, but the functionality for switch doesn't work yet, as I'm sure you've noticed

Yes I’ve noticed that, thanks. Do you have any kind of social media where we can chat? I’m VERY interested in this.

Discord would be the best option, if available.

I'm not a big fan of unindexed media, especially for info that could be useful to other people.
If you're just interested in what is required to make switch work, you need to call an undocumented Windows API. There is an example of a crate doing it here: https://github.com/sidit77/com-policy-config
The reason I'm dithering over implementing it are that:

It requires unsafe code
It requires a different GUID for each version of Windows. There is a list of them somewhere but I can't find it
I need to decide on the API for it, which depends on a direction of a downstream project

I will get to it before the end of the year though. If you search that guid on GH you can find a couple of other similar projects like this one: https://github.com/yan0lovesha/AudioSwitch/tree/05e31d49413459107954e8b0ecdc3ae5695e66ff

Sure, thanks for the info.

May I know how are you gonna pull it off, without unsafe code? The repo you mentioned uses custom bindings for PolicyConfig.h, which is necessary to switch devices. Afaik, any external ffi binding would be unsafe, then how?

May I know how are you gonna pull it off, without unsafe code? The repo you mentioned uses custom bindings for PolicyConfig.h, which is necessary to switch devices. Afaik, any external ffi binding would be unsafe, then how?

Yes I agree with you, since it's doing FFI it'll definitely require unsafe code. The issue is that I haven't done it before, so I'll have to learn how to write the unsafe code, safely!

Lgtm, I would like to get good with FFI as well, see you soon. Will contact if I find some info.


Is it possible to create this chart?

Hello, I want to create a create like the attached image. Is it possible to increase the height of bars to 100% like in the image?

100% Stacked column charts


I MISS FRUITY

when's fruity coming back? i really miss it. its like my fav bot (it reminds me of my love)
we have been using it since it wasn't even verified 🥹
discord : kiruchann

Hi there,
Fruity isn't coming back, as per the announcement on the Discord server. It does not have any useful or unique features - anything you're looking for can certainly be found in a better bot. It was only intended to be a coding project as a semi-cool thing and not anything that anyone should actually use.
As for the other bits: if you're using a Discord bot to remind yourself of your partner, you really need to get a life, and as for the verified bit, it was only verified for about a month before I took it down.
You are able to host the bot yourself as the code is right here on GitHub.


attributes with no escaped characters cause LDAPInvalidFilterError

Hello,
First of all, thank you so much for the repo. It's really helpful.
I've been trying to use it and I detect that if I run the following code, it will throw ldap3.core.exceptions.LDAPInvalidFilterError
from ms_active_directory import ADDomain
import os

domain = ADDomain(
   "my.domain", ldap_servers_or_uris=["my.domain"]
)
computer_name = os.environ["COMPUTERNAME"]
session = domain.create_session_as_computer(computer_name)
group = session.find_group_by_sam_name('group name (has this)', ["objectSid"])

I figure it out that it throws the exception because of special characters for the LDAP Query Syntax ( and )
I've fixed in my code it using ldap3.utils.conv.escape_filter_chars but I think it should be added in some other functions of your library.
Thank you

hi @Mr-Reca !
this seems reasonable - I can add it in. I'll also add a keyword argument to skip escaping in order to facilitate scenarios where people do their own escaping. the LDAP protocol is a little weird/loose on escaping (e.g. commas sometimes need to be escaped but sometimes don't) so I was hesitant to force it


Dockerfile publishing

From ongoing thread on docker images in http://apache-spark-developers-list.1001551.n3.nabble.com/Publishing-official-docker-images-for-KubernetesSchedulerBackend-td22928.html
Currently, we have a wide array of dockerfiles that are all based on spark-base, with minor customizations. There is some discussion on publishing those.
Our high level, I think, as articulated on the thread is - We publish canonical images that serve as both - a complete image for most Spark applications, as well as a stable substrate to build customization upon for the subset of applications that need it.
Thoughts? Comments?
cc/ @apache-spark-on-k8s/contributors @felixcheung @tnachen

There are some things we can do to simplify/unify some of those images (by moving the CMD into the scheduler backend code for example). I'm unsure what we might gain by doing that - since the images aren't particularly k8s specific at this time anyway and one could in theory use env-vars and reuse it.

As I mentioned on the SIG meeting discussion, I think moving the CMD back into the scheduler code is not a good idea - for one thing that would take it off the table for users to customize it in their own container images.
The strategy of unifying a spark-base image with mesos seems like a good one.  I would expect any other deviations (kube, mesos, or anything else) to be relatively thin modifications of spark-base

I think it makes sense to me to have one official Spark image.
As of now, I don't see anything in k8s spark-base that is specific to k8s.
mesos does have a Dockerfile (but not image in release) in the Spark codebase, and it has a mesosphere specific base image (FROM) so all in all, we might not be able to say we are replacing/releasing one image or Dockerfile for all cluster type / resource manager, but at least we could say this new image or Dockerfile is not specific to k8s use.
As for the mail thread, I think we could re-articulate the built-in capability for customization with Docker with this spark-base serving as the base image.


Allow Bokeh plots to be glued and pasted

Using the JSON-type output from Bokeh, this creates appropriate HTML and
Javascript nodes in the output when the Bokeh+JSON mimetype is found.
The Python Bokeh library is only imported when it is needed, to avoid a
package dependency on Bokeh. Users will need to install Bokeh via pip or
conda to be able to glue/paste Bokeh plots. Using the JSON output allows
plots to be pasted into figures as well as a general element with no
further changes.
Uses the Sphinx configuration to decide whether a page has Bokeh content
and only loads BokehJS on those pages. This simplifies the script that
needs to be embedded in each paste and ensures that Bokeh is only loaded
once from the CDN, unless the user runs output_notebook(). In the case
where the user runs output_notebook() the BokehJS library is loaded
twice but this doesn't appear to cause any problems.

@choldgraf @chrisjsewell, I am interested to know your thoughts about adding pieces like this one that interfaces with 3rd party libraries. There is some preliminary conversation on the following previous discussion (in case you need some context): https://github.com/executablebooks/meta/discussions/346.

Hey @bryanwweber @damianavila 👋🏼 Essentially I feel these third party interfaces to myst-nb (and thus jupyter-book) should probably be in a separate plugin package, and loaded via entry points

Thanks @chrisjsewell Any pointers to how to do that in the docs or elsewhere?

@bryanwweber there are some docs here:
https://myst-nb.readthedocs.io/en/latest/use/formatting_outputs.html#customise-the-render-process
but this one might be a test-case that drives some enhancements to the documentation (e.g., maybe a short tutorial on implementing your own renderer) I am happy to help write out some steps on how to do this, I think this would be a great way to extend MyST-NB's functionality without adding a lot of complexity to the core (e.g., myst-nb-bokeh could be a dependency)
For reference, here's load_renderer function:
https://github.com/executablebooks/MyST-NB/blob/a4c21b16be56725381fd3d829fde6d212d948906/myst_nb/render_outputs.py#L70
and here's where the entry points are defined:
https://github.com/executablebooks/MyST-NB/blob/ce5f69ccce8c11fccaaa9f6d97b3e224154247cf/setup.cfg#L62

@choldgraf @chrisjsewell Thanks for the references, I'll look into it! I certainly appreciate the desire to keep the core of MyST-NB small! 😄
It seems like this plugin would solve the rendering issue, but not the glueing issue. Using the current myst_nb.glue on a Bokeh Figure stores the HTML for a Bokeh table, plus a plain-text string in the output of the cell.
I think glueing a Bokeh figure would then require a separate function (e.g., glue_bokeh()) defined in the plugin package. To me, it seems like a single UX/API for gluing would be better - why should a user care whether they're gluing a Bokeh figure or Matplolib figure or Python object or anything else?
Do you have any thoughts/opinions about that idea? Thanks!

@choldgraf @chrisjsewell OK, so I tried this approach of loading a renderer from an entry point. Unfortunately, this does not allow pasting either, because the renderer is always set to "default": https://github.com/executablebooks/MyST-NB/blob/e39132e4f1c58352a9f6d3004c7336dbbeca4e8a/myst_nb/nb_glue/domain.py#L44
If I change that string to point to my new renderer entry point, then it works :tada: So this is going to definitely require changes to myst_nb beyond just potentially importing another extension. I assume you'd like me to make any required changes in a new branch/new PR?

@choldgraf @chrisjsewell I'm going to close this. I created an extension package over here: https://github.com/bryanwweber/MyST-NB-Bokeh I'll do some more cleanup and add testing in the next little while. I'll make a separate PR for the fix to MyST-NB that's needed to get it working properly, as I mentioned above ☝
FWIW, the documentation was not super helpful in creating this. I'd be happy to write up a blog post/bit of documentation about how I got all this working. Let me know what's the best place for that. Thanks for the pointers!

Heya yeh no worries cheers

FWIW, the documentation was not super helpful in creating this. I'd be happy to write up a blog post/bit of documentation about how I got all this working. Let me know what's the best place for that. Thanks for the pointers!

@choldgraf, what would be a good place for this? I do not want to lose the generated momentum created by @bryanwweber 😉

I'll make a separate PR for the fix to MyST-NB that's needed to get it working properly, as I mentioned above

Btw, that PR lives here (crosslinking for easier ref): https://github.com/executablebooks/MyST-NB/pull/337


TODO: Bitcart roadmap January 2020

Second year of BitcartCC development!
Massive update from 2019 coming out 1 January 2020 at 20:20!

[x] Add server management settings to admin (almost done)
[x] Improve docs (almost done)
[x] Improve checkout design (MrNaif2018/bitcart-frontend#38)
[ ] Add more examples of usage and new features to SDK(MrNaif2018/bitcart-sdk#3)
[ ] Tor and using your own node support(MrNaif2018/bitcart-docker#8)
[ ] Add omni layer support(electrum-omni probably)
Previous month: #92

This month we have done a lot of progress, brand new docs, improved checkout, improved admin panel.
Next month: #98