Keyword search

Search topics by: title,  can be restricted to search one realm
Search realms by: name
Keywords can be negated with a minus (eg. "-cats" finds anything without cats mentioned), maybe other functions like that
Easy way to have a default "blocked keyword list", eg. if you regularly add "-cats" to your search (you monster!) it would be added automatically
See https://github.com/demcra/demcra/issues/13

Also would be nice to block certain domains, for example "-site:cracked.com" would exclude any links to that domain.  ￼The idea is from Jew_Fucker_69 who proposed this on reddit: https://www.reddit.com/r/RedditAlternatives/comments/3gmxii/what_would_you_change_improve/cu03owv
BTW, I don't have anything against cracked.com, they have some great stuff!


Thanks!

Hi Kenny, thanks for building this. This has enabled me to move back to using Chrome as my primary browser :)

Hey thanks. Glad you liked it. :) If it's not too much, I would like to have a review of Cookie AutoDelete on the Chrome Store.


Update python/thrift/appengine-ssl-gateway to use Container-VM image

Currently the python/thrift/appengine-ssl-gateway sample is using the Container-Optimized Google Compute Engine Image --image container-vm. There is a warning that this is superseded by the Container-VM Image --image gci-beta-... --image-project google-containers.
We should update the sample to use the new image.

@lesv FYI

Alternatively, we could use the CoreOS image. This is what we use in the CP 100 course since it includes a Docker installation.

Yes - since it's public.  It's fast.

Deprioritized, closing. If anyone feels strongly about this, please reply/reopen! :)


Updated the Submission to contain the verifiablePresentation.

Overview
Previously: a Submission objected (which was returned with GetSubmission contained metadata only.
Now: it contains the VerifiablePresentation object that was sent.
Description
This is so API clients can retrieve what the information sent was. An follow up may be to include the JWT that was sent, instead of the actual decoded payload.
How Has This Been Tested?
Unit

Codecov Report

Merging #261 (f17ae68) into main (b2d967b) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #261   +/-   ##
=======================================
  Coverage   24.87%   24.87%
=======================================
  Files          31       31
  Lines        3063     3063
=======================================
  Hits          762      762
  Misses       2184     2184
  Partials      117      117

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


A problem matcher generating a path to a non-existent file and jump to problem leads to an infinite loop

VSCode Version: 1.29.1
OS Version: macOS 10.14.1

Steps to Reproduce:

Create the following:
hello-nested/hello.go:
package main

import "fmt"

foo

func main() {
    fmt.Println("Hello, World!")
}

.vscode/tasks.json:
{
    // See https://go.microsoft.com/fwlink/?LinkId=733558
    // for the documentation about the tasks.json format
    "version": "2.0.0",
    "tasks": [
        {
            "label": "build",
            "type": "shell",
            "command": "go build",
            "options": {
                "cwd": "hello-nested"
            },
            "problemMatcher": "$go",
            "group": {
                "kind": "build",
                "isDefault": true
            }
        }
    ]
}

Run the build task.

Press F8.

VS Code seems to enter some infinite loop. The open editors view is flickering and the UI becomes unresponsive.

Does this issue occur when all extensions are disabled?: Yes

@segevfiner can you please provide a GitHub repository we can clone that demos this. There seems to be more to it (e.g. another folder hello-nested). Makes it easier to ensure we are looking at the same bug

@segevfiner can you please provide a GitHub repository we can clone that demos this. There seems to be more to it (e.g. another folder hello-nested). Makes it easier to ensure we are looking at the same bug

@dbaeumer hello/hello.go was supposed to be hello-nested\hello.go. But sure, here you go: https://github.com/segevfiner/vscode-issue-64346.

@segevfiner thanks for the repository. I am able to reproduce, but not the infinite loop. The reason why the file can't be found is the cwd change in the task. Since the go problem matcher works relative to the working directory you need to tell the problem matcher as well the relative path. Something like:
{
    // See https://go.microsoft.com/fwlink/?LinkId=733558
    // for the documentation about the tasks.json format
    "version": "2.0.0",
    "tasks": [
        {
            "label": "build",
            "type": "shell",
            "command": "go build",
            "options": {
                "cwd": "hello-nested"
            },
            "problemMatcher": {
                "base": "$go",
                "fileLocation": ["relative", "${workspaceFolder}/hello-nested"]
            },
            "group": {
                "kind": "build",
                "isDefault": true
            }
        }
    ]
}

Can you provide more information about the infinite loop you are seeing.

@dbaeumer It seems this doesn't happen with vscode-go 0.7.0 only with 0.7.1-beta.x.

@segevfiner this seems to be a problem with the go extension then. Can you please report the issue there.


Ticked version, regenerated if needed. (Double-check reqs!)

Made using tick_my_feedstocks.py!

[x] I have vetted this recipe

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

Hi Peter, @pmlandwehr
Do you have any estimation of when version 3.0.0 of FLask-security will be merged to conda-forge?
Thanks in advanced

Not immediately - the build is currently blocked by a few other missing py36 builds, e.g. itsdangerous.

[ ] flask-babelex (pull) - seems to need xz?


bookkeeper shell cookie_get command fails in pulsar v2.7.0

Describe the bug
When executing bin/bookkeeper shell cookie_get, the command fails with no such method error.
root@pulsar-mini-bookie-0:/pulsar# bin/bookkeeper shell cookie_get
JMX enabled by default
Exception in thread "main" java.lang.NoSuchMethodError: com.beust.jcommander.JCommander.usage(Ljava/lang/StringBuilder;)V
	at org.apache.bookkeeper.tools.framework.Cli.setupCli(Cli.java:142)
	at org.apache.bookkeeper.tools.framework.Cli.<init>(Cli.java:53)
	at org.apache.bookkeeper.tools.framework.Cli.runCli(Cli.java:243)
	at org.apache.bookkeeper.tools.common.BKCommand.apply(BKCommand.java:64)
	at org.apache.bookkeeper.tools.cli.helpers.BookieShellCommand.runCmd(BookieShellCommand.java:46)
	at org.apache.bookkeeper.bookie.BookieShell.run(BookieShell.java:2235)
	at org.apache.bookkeeper.bookie.BookieShell.main(BookieShell.java:2326)

To Reproduce
Steps to reproduce the behavior:

Install pulsar locally in minikube
kubectl exec -n pulsar -it "pulsar-mini-bookie-0" -- /bin/bash
In the container, execute: bin/bookkeeper shell cookie_get
See error

Expected behavior
Should be able to get cookie for the bookie
Screenshots
NA
Desktop (please complete the following information):

OS: Minikube v1.15.1 on Max OSX 10.14.5
Pulsar v2.7.0. Local setup instructions followed from doc

Additional context
Looks like a packaging issue when bundling jars from bookkeeper and pulsar together. Pulsar depends on jcommander:1.78 and bookkeeper depends on jcommander:1.48. The higher version(1.78) gets bundled in pulsar/lib which does not have usage(StringBuilder) signature.

We are going to cut a release of BK 4.12.1 soon.
Do you mind creating an issue in BK foe the upgrade?
Sending a patch would be top!

Thanks @anvinjain @eolivelli, since we have an issue in the bookkeeper, I will close this issue first.


Close Amazon Connect Stream

Is there a way to do this within the code (triggering Connect Stream to close)? Within my contact flow, I need to pause streaming and I've tried 1. closing the input stream and 2. cancelling the subscription, though they don't work very well. Is there a more straightforward way to do this?

For example, with a computer mic, you can simply do inputStream.close(). What's the respective function to stop Streaming through Kinesis (after you run client.startStreamTranscription())?

In order for you to stop the stream via the Lambda code instead of with the Stop Streaming block in the Contact Flow, you will need to stop the ExecutorService. The executor logic is in the KVSByteToAudioEventSubscription.java file.


There are no pdf files in the output file directory.

No pdf file is generated when I run with example

args_oap stage_one -i /home/bioinfo/sunyy/work/ARG/test/example/input -o /home/bioinfo/sunyy/work/ARG/test/example/1 -f fa -t 8
args_oap stage_two -i /home/bioinfo/sunyy/work/ARG/test/example/1 -t 8
and the output are this:

The current version does not support generating PCA plots (pdf files).


[Schema][Fixlink][1684089]

Updated link in line no. 311. Please review.

Docs Build status updates of commit dc03e5b:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

msteams-platform/resources/schema/manifest-schema.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


White Screen in OS Sonoma

Application version: 2.5.0
OS: MacOS Sonoma 14.0

Steps to Reproduce:

Open the application
Close Mac and don't use it for a while
Open Mac and the app shows white screen
See error screenshot
Cannot do normal Quit. Have to do Force Quit and open the app again.

Screenshots

I have the exact same issue in MacOS Ventura

Have the same issue on the latest macOS Sonoma 14.3.1

Hi, seeing the same issue here on Sonoma 14.5

I had the same issue on Catalina 10.15.7 and it also slowed down my computer. I understand that my Macbook is old but when I uninstalled the app it started working properly again.

Happening in MacOS Sequoia v15.x.x

Don't use Station for a little while, but other applications are active
App suddenly goes white
Have to force quit to restart

Love this app - this is the only downside, as it happens 1-2 times per day. 🙏


rds should support unmark action

RDS supports remove-tag for unmarking a resource, but it should support unmark as an alias to be consistent with EC2

Add mark as an alias for tag and unmark as an alias for remove-tag.


Replace CurrentUser with middleware that fetches user info

https://github.com/artsy/reaction-force/pull/85#discussion_r110449792

This is done.


[resolves #155] Provide camel-sap support

Refer to this link for build results (access rights to CI server needed):
https://fabric8-ci.fusesource.com/job/wildfly-camel-pullreq/518/
Test PASSed.


swapd: add tasks to CheckpointSwapd

NACK on this, this seems to skip of the logic that gets triggered when the tasks are submitted piecemeal instead. The logic could be re-implemented, but this would just be a duplication.


Split XiosInitTest into unit tests for each XIOS concept

Currently we have a single test script for Xios. It would be better to separate this into separate tests for the core XIOS concepts: calendar, axis, domain, grid, field, file. This should be more straightforward now that the same minimal XML file can be used for each.

Closed by #588.


WIP: XLSX import, affects issue fastbolt/entity-importer#6

XLSX import, affects issue fastbolt/entity-importer#6

Codecov Report

Merging #8 (cbe37ba) into main (804ddfc) will increase coverage by 7.31%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##               main       #8      +/-   ##
============================================
+ Coverage     73.58%   80.90%   +7.31%
- Complexity      102      123      +21
============================================
  Files            19       25       +6
  Lines           318      377      +59
============================================
+ Hits            234      305      +71
+ Misses           84       72      -12

Flag
Coverage Δ

unittests
80.90% <100.00%> (+7.31%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

src/EntityImporter.php
87.50% <100.00%> (ø)

src/Exceptions/EntityInstantiationException.php
100.00% <100.00%> (ø)

src/Exceptions/UnsupportedReaderTypeException.php
100.00% <100.00%> (ø)

src/Factory/EntityInstantiator.php
100.00% <100.00%> (ø)

src/Reader/Factory/CsvReaderFactory.php
100.00% <100.00%> (ø)

src/Reader/Factory/ReaderFactoryManager.php
100.00% <100.00%> (ø)

src/Reader/Factory/XlsxReaderFactory.php
100.00% <100.00%> (ø)

src/Reader/Reader/CsvReader.php
100.00% <100.00%> (ø)

src/Reader/Reader/XlsxReader.php
100.00% <100.00%> (ø)

src/Types/ImportSourceDefinition.php
100.00% <100.00%> (ø)

... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 804ddfc...cbe37ba. Read the comment docs.


Add new source IP for action group

Adding source ip of new scale unit

@sushilsakharkar : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@sushilsakharkar It appears that the IP address has been added in a separate update to the article. We'll close this PR. Thanks for your contribution.


Output of sync_to_fileserver could be nicer

pft.sync_with_fileserver(direction="to fileserver")

Currently, the output is
Waiting ..................................................................................................................
(b'sending incremental file list\n./\nblobs_binary.tif\n\nsent 65,434 bytes  received 38 bytes  130,944.00 bytes/sec\ntotal size is 65,280  speedup is 1.00\n',
 b'srun: job 28299358 queued and waiting for resources\nsrun: job 28299358 has been allocated resources\nsrun: error: ioctl(TIOCGWINSZ): Inappropriate ioctl for device\nsrun: error: Not using a pseudo-terminal, disregarding --pty option\n')

If would be good if this was printed, to look like:
sending incremental file list
./
blobs_binary.tif

sent 65,434 bytes  received 38 bytes

closed by commit abd9d3f


'Rust' dropdown should take you to rust-lang.org

Right now, we have three dropdown tabs: 'About', 'Releases', and 'Rust'. The first two take you to a separate page when you click on them. The last does nothing - you have to click on one of the drop-down items. To make it consistent, 'Rust' should take you to rust-lang.org and the 'Rust Programming Language' item should be removed.

New to contributing to this project but happy to pick this up 🎉

@shorsher thank you so much! To get started, change https://github.com/rust-lang/docs.rs/blob/master/templates/header/topbar.html#L56 to be a hyperlink, then run cargo run start-web-server to view your changes locally (more instructions in the README).


SAK-41309 SAK-40650 Grading issue where linked gradebook title is numeric

For me is OK, resolve blocker issue, but IMO this way is too inefficient.
If the Gradebook item is only numeric there are 3 calls to getAssignmentScoreString.
1 - With the name of the GradebookItem
2 - With the Id of the assignemnt
3 - If Gradebook item is numeric another call (but now catch the exception).
I think, if you call getAssignmentScoreString with the name of the Gradebook Item
and you find the object you don't need to do more calls to getAssignmentScoreString.
Although the best solution is what said Steve in
https://github.com/sakaiproject/sakai/pull/6539

I agree all of this could be better I also think it's not common to see someone create a gradebook entry with only numbers!


implement PyTypeMethods

Split from #3606
This PR implements the PyTypeMethods trait and the bound variants of the constructors for PyType.
The most interesting thing in this PR is the bound variant of PyType::from_type_ptr, which I decided to introduce as PyType::from_type_ptr_borrowed, because that pointer doesn't carry ownership.
There's possibly arguments that one (or both) of the PyType constructors should not have bound variants introduced and we should rework the APIs, e.g.:

Deprecate PyType::new in favour of T::type_object (or Python::get_type)
Find a way to make PyType::from_type_ptr_borrowed less like std::slice::from_raw_parts, e.g. should it force a reference count increase?

Let's make a decision about https://github.com/PyO3/pyo3/pull/3703#issuecomment-1869817794 before reviewing this; if we agree to slow things down I'll remove the deprecations from here.

Okay, rebased. To make the deprecation in the macro output conditional I added a gil-refs feature to pyo3-macros. I think that's fine as we'll eventually want that feature to enable / disable creating a GILPool in #[pyfunction] calls.
Also, I'm really not feeling keen on from_type_ptr_borrowed so I might ponder better replacements for that. Suggestions welcome.

Okay, rebased. To make the deprecation in the macro output conditional I added a gil-refs feature to pyo3-macros. I think that's fine as we'll eventually want that feature to enable / disable creating a GILPool in #[pyfunction] calls.

IIRC, all GILPool usages are already moved into the impl_ module. Nevertheless, I don't see a reason to avoid forwarding that feature into our macro helper crate.

Ok, this is finally reviewable! :tada:

I would like to review this, but it would be helpful if the conflicts were fixed first.

Ahh aha as soon as I'd got it ready the new changes to PyErr conflicted! I'll aim to update tonight 👍

Fixed!

🎉 thanks @adamreichold @Icxolu @LilyFoote - this was a thorny one and it feels like quite the milestone to finally get this one rounded out!


Pass flags and service config to middleware

Pass AWSServiceConfig to AWSServiceMiddleware.chain functions
Also add options member to AWSServiceConfig so we can pass flags to middleware.

done #356


Why extract_text function log automatically?

Bug report

when I use the extract_text and logger that I defined at the same time, my logger will log the ouput of extract_text. the picture show detail information.

Is this a bug?  I'm appriciate to you if you can solve this "problem"

I faced this "issue" too. I set the root logger level to ìnfo, because I use it to print out the progress of my code. Thus, when I use extract_text` I get this logs too.
I can think on two solutions:

Open a PR to change logging.info to logging.debug , wich I think that is most appropriated;
Change my code (and your code, and everyone else's code that face this "issue") to use a local logger.

Right now, I changed my code to solve this, but I will open a PR to address this.


Can't automaticly quit python language server after quitting VSCode on macOS

Bug: Notebook Editor, Interactive Window, Editor cells

Steps to cause the bug to occur

Open a ipynb file in VSCode
Close tab or VSCode after finish using it
You can find Microsoft.Python.LanguageServer still in the background, and can be seen in the Activity Monitor.app

Actual behavior
When I finished using jupyter notebooks in vscode, I close the window, press cmd+q to quit VSCode. However, there is a process called Microsoft.Python.LanguageServer which can be seen in the Activity Monitor.app, and using my memory more than 1G.
Expected behavior
When close all of the jupyter notebooks tabs in vscode, the Microsoft.Python.LanguageServer in the background should be automaticly quit.

Your Jupyter and/or Python environment
Please provide as much info as you readily know

Jupyter server running: Local
Extension version: 2020.5.80290
VS Code version: 1.45.1
Setting python.jediEnabled: false
Setting python.languageServer: Microsoft
Python and/or Anaconda version: Python 3.7.7 & conda 4.8.3
OS: Mac
Virtual environment: conda

Developer Tools Console Output
No output available.

Microsoft Data Science for VS Code Engineering Team: @rchiodo, @IanMatthewHuff, @DavidKutu, @DonJayamanne, @greazer, @joyceerhl

Hey @Saafo . Thanks for reporting this. Currently I do repro that after you close a notebook file the language server stays running. However I'm not seeing it ever left running after either the folder is closed in VSCode or after VSCode is fully closed. Is there any specific circumstances where you are seeing this? It is occasionally running for a second or two as it's shutting down, but it's never left fully abandoned that I see.

Well, I tried to repro this for twice, but for the first time, just like your occasion, the language server quit automatically, however, when I tried for the second time, which is in the same procedure, the problem happend as the GIF below:

@Saafo sorry to ask one more quick question on this, does this issue only happen with notebook files? The language server should also start if you are working with standard python .py files in the IDE, do you ever see this issue in those cases? Or is it just getting abandoned when working with notebook files?

@IanMatthewHuff it seems only happen with notebook files. I've tested .py files for twice, and the language server had quitted each time.

@Saafo while I can't replicate this exact issue, I do think I see a possible code path where this could be a problem. We'll discuss this in our triage meeting.
Triage: The refCountedLanguageServer is only getting disposed when VSCode is shut down, not on notebook close. Looks like the monaco component is supposed to handle this, but I don't see it happening. It should get closes on VSCode close, but that is timing dependent.


There is no ScreenControl.unitypackage

Hi!
I'm trying to import the package into my own Unity project as guided in the README in ScreenControl/ScreenControl/. But I can't find ScreenControl.unitypackage. Should I build the package on my end provided the source code from this repository?

Hi,
We do not currently have a public release available for Screen Control, to make this ready to import into your Unity Project you would need to generate your own build after forking the repository and then building from the correct (develop) branch.
Please remember that unless it is an officially released application available from our website or an explicitly agreed license. It is not supported by Ultraleap and we are not responsible for anything that you create.
To get started, you will need to build the ScreenControlService scene, which is at 'Assets/ScreenControl/Service/Scenes’. You will then need to export ONLY the 'Assets/ScreenControl/Client' folder as a package and import it into your own project.
Please be aware that there is a known issue where the 'RingCursor' in the client prefab defaults the 'ringThickness' to 0 and it should be 2.
We are interested to hear more about your project and what you are looking to use Screen Control to create. Please can you send us some details to<EMAIL_ADDRESS>and we can see if there is any advice or guidance that we can provide?

Hi,
We do not currently have a public release available for Screen Control, to make this ready to import into your Unity Project you would need to generate your own build after forking the repository and then building from the correct (develop) branch.
Please remember that unless it is an officially released application available from our website or an explicitly agreed license. It is not supported by Ultraleap and we are not responsible for anything that you create.
To get started, you will need to build the ScreenControlService scene, which is at 'Assets/ScreenControl/Service/Scenes’. You will then need to export ONLY the 'Assets/ScreenControl/Client' folder as a package and import it into your own project.
Please be aware that there is a known issue where the 'RingCursor' in the client prefab defaults the 'ringThickness' to 0 and it should be 2.
We are interested to hear more about your project and what you are looking to use Screen Control to create. Please can you send us some details to<EMAIL_ADDRESS>and we can see if there is any advice or guidance that we can provide?

Understood! Thank you so much for your kind explanation. By the way, what I'm trying to do is to customize gesture recognition using a Rigel evaluation kit.

Understood! Thank you so much for your kind explanation. By the way, what I'm trying to do is to customize gesture recognition using a Rigel evaluation kit.


Add support for imagePullSecret and imagePullPolicy

There shouldn't be any secrets in the chaincode package- these should be part of the Fabric deployment. It may be useful to provide the name of the secret to use in the chaincode package though- tbc.
Similarly, imagePullPolicy seems like an optional configuration option for the builder, rather than something which belongs in the chaincode package.
I previously wondered about a configuration option to provide a kubernetes .yaml file to allow more fine grained control rather than exposing individual options. Probably needs a bit more thought though.

The CC package will declare the image via @digest - there is no need / utility to set the image pull policy.

The image pull policy is part of the image URL - it is not part of the Kube config but is required as a "second dimension" coordinate for the container.

The imagePullSecrets ARE a part of the kube config, and will be applied at the service account.


Make tests framework agnostic

Currently, our tests only run against the FlaskApp. This PR parametrizes the relevant tests to run against both the AsyncApp and FlaskApp.
Unfortunately, the test clients provided by Flask and Starlette are not entirely aligned. This PR addresses this by refactoring the tests so they are framework agnostic.
This increased the number of tests from 483 to 709, of which 66 still fail due to issues with the AsyncApp. I will submit separate PRs targeting this branch to fix those.

Unfortunately, the test clients provided by Flask and Starlette are not entirely aligned. This PR addresses this by refactoring the tests so they are framework agnostic.

I added a new commit which uses the Starlette TestClient for the FlaskApp as well. Since both apps are wrapped by ASGI middleware, this works, and we no longer need to write our tests to match both test client interfaces.
62 tests still failing.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

143 of 156 (91.67%)  changed or added relevant lines in 13 files are covered.
3 unchanged lines in 3 files lost coverage.
Overall coverage increased (+2.04%) to 92.151%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

connexion/apps/asynchronous.py
0
1
0.0%

connexion/middleware/main.py
1
4
25.0%

connexion/lifecycle.py
106
115
92.17%

Files with Coverage Reduction
New Missed Lines
%

connexion/frameworks/flask.py
1
93.1%

connexion/lifecycle.py
1
87.34%

connexion/utils.py
1
87.17%

Totals

Change from base Build<PHONE_NUMBER>:
2.04%

Covered Lines:
3252

Relevant Lines:
3529

💛  - Coveralls


Updated oc version to 4.11.23

Signed-off-by: dislbenn<EMAIL_ADDRESS>

/hold

Closing PR tracking changes in PR: https://github.com/stolostron/multicluster-observability-operator/pull/1152


If directory disk/ already exists then Vagrant Up fails with "no SATA controller" error

In SpectrumScaleVagrant/virtualbox, if an install with vagrant up somehow fails, or if the user simply deletes the VM with vagrant destroy then the subdirectory disk/ is left behind.
This is now empty (It used to contain the 7 LUNs)
However a subsequent vagrant up will always fail with the error
A customization command failed:

["storageattach", :id, "--storagectl", "SATA", "--port", "0", "--device", 0, "--type", "hdd", "--medium", "disk/disk-m1-djk-001.vdi"]

The following error was experienced:

#<Vagrant::Errors::VBoxManageError: There was an error while executing `VBoxManage`, a CLI used by Vagrant
for controlling VirtualBox. The command and stderr is shown below.

Command: ["storageattach", "8f5f4e0d-0771-430d-8dcd-6eee8bc46d02", "--storagectl", "SATA", "--port", "0", "--device", "0", "--type", "hdd", "--medium", "disk/disk-m1-djk-001.vdi"]

Stderr: VBoxManage.exe: error: Could not find a controller named 'SATA'

This is because the Vagrantfile contains
        vbox.customize ['storagectl', :id, '--name', 'SATA', '--add', 'sata', '--hostiocache', 'off']
      end

ie. The SATA controller is only added if the directory disk does not exist

I think the check needs to be there to allow the VM to be stopped and resumed (vagrant halt followed by vagrant reload). Unfortunately I don't currently have a VirtualBox environment at hand to perform more testing.
Wouldn't a reasonable work-around be to manually delete the disk sub-directory after a vagrant destroy?

Yes I agree it is reasonable to expect the user to delete the directory disk/ if for example an install fails for some other reason.
However knowing that this error about no SATA controller is casued by the presence of an existing directory called disk/ requires reading through the VagrantFile to dubug the issue,
Can I suggest that this requirement to deleet the directory is docuemented (or better the vagarnt file prints a warning) ?

Also I beleive that an "rm-r disk/" is insufficent. A full 'vagrant destroy' is needed too, other the error simply repeats

As mentioned above, the SATA controller must not be added when performing a vagrant reload otherwise you get the following error:
A customization command failed:

["storagectl", :id, "--name", "SATA", "--add", "sata", "--hostiocache", "off"]

The following error was experienced:

#<Vagrant::Errors::VBoxManageError: There was an error while executing `VBoxManage`, a CLI used by Vagrant
for controlling VirtualBox. The command and stderr is shown below.

Command: ["storagectl", "4735e3d9-8f56-41fb-9e8d-2b05daa3f78b", "--name", "SATA", "--add", "sata", "--hostiocache", "off"]

Stderr: VBoxManage.exe: error: Storage controller named 'SATA' already exists
VBoxManage.exe: error: Details: code VBOX_E_OBJECT_IN_USE (0x80bb000c), component SessionMachine, interface IMachine, callee IUnknown
VBoxManage.exe: error: Context: "AddStorageController(Bstr(pszCtl).raw(), StorageBus_SATA, ctl.asOutParam())" at line 1089 of file VBoxManageStorageController.cpp
>

This is a known issue when using VirtualBox as provider for Vagrant: https://github.com/hashicorp/vagrant/issues/9313 https://github.com/hashicorp/vagrant/issues/5920
Unfortunately there seems to be no error handling for Vagrantfile customize commands, so the most promising resolution seems to be only creating the storage controller during a vagrant up:
      if ARGV[0] == "up"
         vbox.customize ['storagectl', :id, '--name', 'SATA', '--add', 'sata', '--hostiocache', 'off']
      end

This however means that stopping and starting VMs need to follow the vagrant halt, vagrant reload command sequence instead of using vagrant up to re-start the VM.


XCode 7.3 + Swift 2.2 support

Now that XCode 7.3 was released with Swift 2.2 shipped by default I'm seeing the following issues when trying to install the latest commit on the master branch:
The following build commands failed:
	CompileSwift normal x86_64 /path/to/project/Carthage/Checkouts/CommandLine/CommandLine/StringExtensions.swift
	CompileSwift normal x86_64 /path/to/project/Carthage/Checkouts/CommandLine/CommandLineTests/CommandLineTests.swift
	CompileSwift normal x86_64 /path/to/project/Carthage/Checkouts/CommandLine/CommandLine/Option.swift
	CompileSwift normal x86_64 /path/to/project/Carthage/Checkouts/CommandLine/CommandLineTests/StringExtensionTests.swift
	CompileSwiftSources normal x86_64 com.apple.xcode.tools.swift.compiler
(5 failures)

Can we fix this?

Here's some more information on where this actually might crash:
CommandLine.swift:19:2: error: unknown attribute 'exported'
@exported import Darwin

Thanks for the report! I'm surprised by this though, @exported was removed in #46. Are you sure you're using the latest code from master?

Ah sorry, forgot to close this issue. I already figured out that Carthage has a bug when updating specific dependencies. It's not an issue with CommandLine so I'm closing this. @jatoben Thank you for getting back to me anyways! :+1:


publish new version

We'd like to use the changes made here: https://github.com/bazelbuild/bazelisk/commit/8c5609acaf93d833b9bb7d79e4163198624c17a5 could a new version be published?

Done! (cf. https://www.npmjs.com/package/@bazel/bazelisk)
Please let me know if you spot any issues.


Can this show handles on left side of box and have it resize to the left?

Can it be configured to resize a div to the left?

Came across this recently on my own project. Since this library works from a top-left positioning, to be able to resize on the left or the top, with the right and bottom edges remaining in place, you need to be able to reposition the container, as well as resize it.
So the best this library could do is to receive an onDrag function or something similar to what react-draggable takes and do a little multiple-callback magic. You can easily implement this yourself in your `onResize callback like so:
function onResize(event, { size, handle }) {
    setSize(size)

    // Check is handle on top or left of object
    if (['n', 'w', 'ne', 'nw', 'sw'].includes(handle) {
      // Left or top handles need repositioning when dragging. Only bottom right can be left alone
      let newLeft = myObject.left
      let newTop = myObject.top
      if (handle.indexOf('n') > -1) {
        const deltaHeight - size.height - myObject.height
        newTop -= deltaHeight
      }
      if (handle.indexOf('w') > -1) {
        const deltaWidth = size.width - myObject.width
        newLeft -= deltaWidth
      }
      onDrag({ left: newLeft, top: newTop })
    }
  }

Thanks for this...I will check it out. Do you know if this can be defined with absolute positioning? In my case, I want to show a div that sits on the right side of page and can be dragged to the left to expand, and it should be on top of div below. Can I add style attribute to this and make it absolute?

Yeah if you're using absolute positioning it's even easier. Don't need to mess around with storing left-positioning, you can just set your drawer component to be absolutely positioned with right: 0 and then resizing in any direction will cause it to grow out to the left. I've put together a basic example showing how this can be done here: https://codesandbox.io/s/react-playground-vwlpk?file=/index.js
Note, there's some unpleasant stuttering when dragging to the left due to the library not taking the object's position changing into account. I've opened a PR to fix this https://github.com/STRML/react-resizable/pull/136

Thx for the code snippet! I see that when I resisze, it pulls both sides in.; In my case, I want the right side to stick to the right side of browser...so all you can do is drag left to expand/or back. Like pulling out a drawer from the right side. Is that possible?

I just had one on each side to show the flicking issue I mentioned. The two green bars are each drawers stuck to the side of the browser. Here's a simplified one https://codesandbox.io/s/react-playground-io7rb?file=/index.js

Again, clearly there's some bad stuttering when dragging from the left, but if my PR linked above gets merged, that should be fixed

@conor-kelleher Waiting for your #136  to get merged


DiffTools.TryFind method is confusing

The DiffTools.TryFind is a bit confusing.
Is the feature request related to a problem
Spot the issue:
// Add if not already there
if (!DiffTools.TryFind(name, out _))
{
    DiffTools.AddTool(name, ... );
}

The issue is here that:

There is a overload of TryFind that searches by name:  public static bool TryFind(DiffTool tool, out ResolvedTool? resolvedTool), while the other (with string parameter), searches by extension: public static bool TryFind(string extension, out ResolvedTool? tool)
I expected that the TryFind method is consistent with the AddTool, where name is the first argument.

Describe the solution
There are multiple solutions, those could be technical or semantic breaking. See the "or"s below ;)

Add  TryFindByExtension(string extension, ...)
Rename TryFind(DiffTool tool, ...) to  TryFindByName(DiffTool tool, ...)
Add TryFindByName(string name, ...)
Make TryFind(string extension, ...) obsolete (breaking change!)
Make TryFind(DiffTool tool, ...) obsolete (breaking change!)

Describe alternatives considered

Instead of TryFind  rename to TryFindTool etc for consistency with AddTool
No obsolete but hard breaking change

Additional context
Current work around (ugly, need Equals? Needs dictionary lookup?):
// Add if not already there
if (!DiffTools.Resolved.Any(c => c.Name == name))
{
    DiffTools.AddTool(name, ... );
}

in what scenario are you using that code? is DiffEngine not finding a known tool in the correct location?

We use the merge tool of Visual Studio, not the diffttool. (maybe I could send a PR for that in the future), also Visual Studio is installed in non-common location for me and all my colleagues.  (not my choice - but at least it's consistent 😅)

merge tool of Visual Studio, not the diffttool

give me the command line and i can add it
in that case shouldnt you call DiffTools.AddTool(name, ... ); with a custom name?

in that case shouldnt you call DiffTools.AddTool(name, ... ); with a custom name?

Yes of course, it was a stripped down version :)

give me the command line and i can add it

To be clear, we currently use (still striped down version):
var vsMergePath = @"D:\Programs\Visual Studio\2022\Common7\IDE\CommonExtensions\Microsoft\TeamFoundation\Team Explorer\vsdiffmerge.exe";
var _ = DiffTools.AddTool(
    name: "VisualStudioMerger",
    exePath: vsMergePath,
    targetLeftArguments: (received, approved) => $"\"{approved}\" \"{received}\" \"{approved}\" \"{approved}\" /m",
    targetRightArguments: (received, approved) => $"\"{approved}\" \"{received}\" \"{approved}\" \"{approved}\" /m",
    requiresTarget: true, autoRefresh: true, isMdi: true, supportsText: true, binaryExtensions: new List<string>());

note: I'm not sure if the targetRightArguments are correct - can find docs for targetLeftArguments / targetRightArguments

I've updated my proposal ("Describe the solution")

i agree in principle. can u submit a PR with your changes. then we can iterate on that if necessary

Will try to do that this week/weekend


Other languages

I could commit myself to integrate i18n in the app to be able to offer the application in several languages, starting with Spanish which is my mother tongue.

PRs are welcome!


Fetch access code

Description
Final PR that will activate access codes. See design doc for more detailed context.
Reviewer Notes
This reopens PR #2287.
Setup
Make sure .envrc.local has REQUIRES_ACCESS_CODE set to true.
1. make server_run
2. make client_run
3. go run cmd/generate_access_codes/main.go -ppm 20 -hhg 20
4. login as new Milmove user

Code Review Verification Steps

[x] Code follows the guidelines for Logging
[x] The requirements listed in
Querying the Database Safely
have been satisfied.
Any new migrations/schema changes:

[x] Follow our guidelines for zero-downtime deploys (see Zero-Downtime Deploys)
[x] Have been communicated to #dp3-engineering - Message to be sent 7/8 AM when deploy happens

[x] There are no aXe warnings for UI.
[x] This works in Supported Browsers and their phone views (Chrome, Firefox, IE, Edge).
[x] Tested in the Experimental environment (for changes to containers, app startup, or connection to data stores)
[x] User facing changes have been reviewed by design.
[x] Request review from a member of a different team.
[x] Have the Pivotal acceptance criteria been met for this change?

References

Pivotal story

@kahlouie - thanks for the review and the suggestion. So I definitely have some feelings on what you brought up. This code has been designed, planned, tested on experimental, has been code reviewed numerous times, and tested extensively. Things will undoubtedly go wrong in engineering but when they do, we should respond swiftly and appropriately. While having the benefit of type 2 decision making, creating that PR implies that we do not have confidence in the code that we are releasing are operating in an environment of fear - both of which are not healthy. If you have some reason why you are not confident in the release of that code, let's deal with that first.


Fix CSP failures in FastBoot tests

This was caused by several facts:

ember-a11y-testing adds two styles tags with inline content
ember-cli-fastboot-testing parses the FastBoot rendered HTML string here: https://github.com/embermap/ember-cli-fastboot-testing/blob/47882cebaaf9fb482df3e3b1eae1067807726890/addon-test-support/index.js#L120
while the inline style violating our CSP was somehow ignored before, it seems the latest Chrome 85 now triggers a CSP violation event on that line above
which in turn makes the test fail

This adds hash values to our CSP policy to specifically allow these two inline style elements

Thanks a lot for fixing this one.
We are planning to add a feature to ember-cli-content-security-policy to support these cases with zero config: https://github.com/rwjblue/ember-cli-content-security-policy/issues/149


Document read-only/writable-ephemeral/writable-persistent directories

We need to update the documentation with the paths of all the directories that mounted as persisted (this list).
There are directories that are:

read only
writable but ephemeral
writable and persistent

users should be able to tell directory is which by reading our docs.
At least this page needs to be updated: https://kairos.io/docs/architecture/immutable/
Original Slack thread: https://spectrocloudcommunity.slack.com/archives/C04B1833NEA/p1705020000107159

@jimmykarily Not sure how soon we will address this, but might be worth copying the content of the discussion since it's ephemeral 🤣

Well the essence of it is:
However we noticed that /var/lib is writable and persistent. i.e. new files and their changes persist after reboot.
Is this a mistake in the docs or a bug in Kairos or what?

We just need to document which paths are writable and persisted and which not.


Unable to set 'on_message' argument on UMFuturesWebsocketClient

I am trying to initialize UMFuturesWebsocketClient as follows.
def event_handler(_, message):
    print(message)

class BinanceService:
    def __init__(self, **kwargs):
        if testnet:
            kwargs["base_url"] = "https://testnet.binancefuture.com"
            api_key = os.environ.get("TESTNET_BINANCE_API_KEY")
            api_secret = os.environ.get("TESTNET_BINANCE_API_SECRET")
            ws_url = "wss://stream.binancefuture.com"
        else:
            api_key = os.environ.get("BINANCE_API_KEY")
            api_secret = os.environ.get("BINANCE_API_SECRET")
            ws_url = "wss://fstream.binance.com"

        self.client = UMFutures(key=api_key, secret=api_secret, **kwargs)
        self.web_client = UMFuturesWebsocketClient(
            stream_url=ws_url, on_message=event_handler
        )

However, it gives the following error.
 self.web_client = UMFuturesWebsocketClient(
                      ^^^^^^^^^^^^^^^^^^^^^^^^^
TypeError: UMFuturesWebsocketClient.__init__() got an unexpected keyword argument 'on_message'

Python version: 3.11.3
Django version : 4.2.1
Does anyone have any suggestions or have solved this error before?

I was getting this error because I was using version 3.3.1. I realized later that these web sockets were updated in version 4.0.0rc1. The problem was solved when I switched to version 4.0.0rc2.


import logging and define LOGGER

LOGGER is used on lines 49, 52, 55, and 57.  Without this change NameError might be raised at runtime.
Signed-off-by: Chris Clauss<EMAIL_ADDRESS>

The DCO bot is throwing a false positive. The sign-off is clearly in the commit.
I will merge in spite of this tool false positive.


verify that we're doing Schnorr correctly

the Schnorr proof (ci,j , vi,j ) now has response value vi,j = (ui,j − ci,j * ai,j ) mod q.
"compute vi,j as difference to simplify verification". see 3.3.2

Implemented in PR #158


linkifyHTML detect url wrongly by combining encoded html space

Usage case
Input HTML String ->

https://www.google.com

After running linkifyHTML,:
Expected:
https://www.google.com

Actual:
https://www.google.com

As you can see, it treats &nbsp as part of url, therefore it make the ; visiable.

Update: I tried to use linkify-element, it wouldn't give me this error,

Fixed, will be released with v2.1.4.
Note for the curious, I fixed only the   case (no other HTML named character references) because   counts as whitespace. All other named-character references will be part of the URL due to the http(s):// protocol at the beginning: It forces everything that follows (up to the next whitespace or punctuation) to be part of the URL regardless of its format.


found error in network ERR_NAME_NOT_RESOLVED

Hello my friend found error in icanhazip ERR_NAME_NOT_RESOLVED , but just in his browser laptop. any idea to solve this issue?
she already clear cache, & try in another browser laptop like mozilla still get error like that and she open another web apps like youtube or google work perfectly. but in my laptop browser just work perfectly.

I suggest your friend find another polling url. They are relying on the the old version of the default polling url.


Component for inputting org numbers

What needs to be solved?
We need a component for convenient input of org numbers, where a user can type the number, and immediately see the name of the org, in order to prevent possible misspellings or copying from the wrong place.
How do you want it solved?
A new component that can bind both the name and orgnumber in https://data.brreg.no/enhetsregisteret/api/enheter/996756246
Alternative solutions

A generic components that supports any url and arbitrary mappings between dataModelBindings
A standard way of sharing code in DataProcessWrite, so that we can do this call only when orgnumber actually change.

Additional context
UDI has this in their forms in some of their applications.

Transferring this issue to app-frontend-react repo

Code used in authorisation to validate can be found here:
https://github.com/Altinn/altinn-authorization/blob/e3d697c96443f94c5d8c1544fb02194578d0c72e/src/Altinn.Common.PEP/Altinn.Common.PEP/Utils/IDFormatDeterminator.cs#L9
From Slack message: https://altinn.slack.com/archives/C02EJ9HKQA3/p1708947977052569?thread_ts=1708947977.052569&cid=C02EJ9HKQA3


λ return object

let func=(val:number)=>{x:val};//error
let func=(val:number)=>{return {x:val};};//ok

The first line is, unfortunately , a valid JS grammar production. the {} represent the body of the function, the x is a label, the val is an expression, the function as a whole implicitly returns undefined.
you can wrap it in parans to avoid this. e.g.
let func1 = (val: number) => ({ x: val });

thank you


Microsoft.Bot.Builder solution doesn't build cleanly

The botbuilder projects are all .NET core 2.0.  There a many NU1701 Package fallback warnings, where regular .NET projects are referenced.

+1
It's a dependant project we'll have to change, mostly from the Text-Recognizers repo which are the recognizers used by LUIS.
I'll kick that process off on Monday.

A quick update on this:

I've requested access to the LUIS Recognizer repo, found here. Once I get access, I'll update the underlying code and publish new NuGet packages.
I've kicked off the process to update the Microsoft Recognizers Text repo to migrate to .Net Core2. That'll take a few days, as the person who would approve the PR is on vacation, and it's a possible breaking change for the teams that depend on that code.

To continue to update:

The PR for the Microsoft Recognizers Text repo for .Net Core 2 has been submitted. That'll take a few days to wind through the system.
Still working on a plan for the LUIS Recognizer. The solutions may be more complicated than initially thought.

Is there a reason the EchoBot-AspNet461 project was added to samples? The addition of this project causes .Net Core build issues as well...

It was added at Brandon's request, and authored by Brandon. His thinking, which I agree with, is that it's handy to show the new SDK integrating with an older version of ASP.Net.
I've sent an email to him asking him to cleanup the many build warnings.
I'm open to suggestions until then.

Another update: The Recognizers-text repo has now been updated to .Net Standard 2.0. Their latest NuGet is multi-targeted, and was pulled in by #207.
I've now gotten admin access to to the LUIS SDK Repo and am working with the team to figure out the best path forward.
Progress!

The LUIS SDK Repo is now up-to-date with .Net Standard 2, and has a modern implementation of the C# LUIS SDK. Thanks to @emadelwany for that.
Currently gated on updated the Nuget package, which is in-progress.

@cleemullins I think this has been merged now. Is this good to be closed in that case?

22 warnings on a clean build today after pulling master:

The issues described by this thread are all resolved.
New issues have come up regarding the BotBuilder.Classic assemblies, but they're tracked elsewhere.


book now and explore more button functionable

Fixes: https://github.com/PriyaGhosal/BuddyTrail/issues/172
Fixes: https://github.com/PriyaGhosal/BuddyTrail/issues/171
Description
I have now made the 'Book Now' and 'Explore More' button functional, as it previously wasn’t working for every deal. I created a new webpage for each deal, as each one has different requirements. A reference video is provided below, showing the changes made.
Please make sure to add label 3 for both pr.
https://github.com/PriyaGhosal/BuddyTrail/issues/172 completed
https://github.com/PriyaGhosal/BuddyTrail/issues/171 completed
Type of PR
[ x] Feature enhancement
Screenshots / videos (if applicable)
Book now button is working (https://github.com/PriyaGhosal/BuddyTrail/issues/172 )

Explore More button is working(https://github.com/PriyaGhosal/BuddyTrail/issues/171 )
https://github.com/user-attachments/assets/736d5a1e-781d-418d-8b20-d94e65c896a5
Checklist:
[ x] I have made this change from my own.
[x ] My code follows the style guidelines of this project.
[ x] I have performed a self-review of my own code.
[ x] I have commented my code, particularly in hard-to-understand areas.
[ x] I have made corresponding changes to the documentation.
[ x] My changes generate no new warnings.
[ x] I have tested the changes thoroughly before submitting this pull request.
[ x] I have provided relevant issue numbers and screenshots after making the changes.

@PriyaGhosal

I have resolved all conflicts.

@INam1995 Please see the conflicts highlighted in the image above. Resolve the conflicts in the mentioned files. Ensure you pull all the latest changes before pushing your feature/bug fixes to the main branch.

done please let me know if there is any issue
@PriyaGhosal

@INam1995
This is not looking good. Remove it totally

you only add explore more section webpages . They are very nice

@INam1995
this is not visible

leave Exclusive deals as it is

Please see the conflicts highlighted in the image above. Resolve the conflicts in the mentioned files. Ensure you pull all the latest changes before pushing your feature/bug fixes to the main branch. After resolving the conflicts, please open a new PR for review.
Thank you!


Correction for raw affiliation Building Blocks for Future Electronics Laboratory (2-B FUEL), The Joint CNRS-Ewha-Yonsei Laboratory, UMI 2002, Seoul, Republic of Korea; Center for Quantum Nanoscience, Institute for Basic Science, Seoul 03760, Republic of Korea

Correction needed for raw affiliation Building Blocks for Future Electronics Laboratory (2-B FUEL), The Joint CNRS-Ewha-Yonsei Laboratory, UMI 2002, Seoul, Republic of Korea; Center for Quantum Nanoscience, Institute for Basic Science, Seoul 03760, Republic of Korea
raw_affiliation_name: Building Blocks for Future Electronics Laboratory (2-B FUEL), The Joint CNRS-Ewha-Yonsei Laboratory, UMI 2002, Seoul, Republic of Korea; Center for Quantum Nanoscience, Institute for Basic Science, Seoul 03760, Republic of Korea
new_rors: 01wjejq96;00y0zf565;01n93gn67;01w108f05
previous_rors: 01wjejq96;00y0zf565;01n93gn67
works_examples: W2987984511
contact: ca32299489354d3d23ae5b8a8031c4cb:21847213a7a8043961bb87980f @ sorbonne-universite.fr

This issue was accepted and ingested by the OpenAlex team on 2024-12-19. The new affiliations should be visible within the next 7 days.


Default nameservers without port

If google's public DNS servers on Windows is used following error occurs:
Fatal error: Uncaught exception 'Amp\Dns\ResolutionException' with message 'Connection to udp://<IP_ADDRESS> failed: [Error #0] Failed to parse address "<IP_ADDRESS>"'

The default nameservers setting:
"nameservers" => [
    "<IP_ADDRESS>",
    "<IP_ADDRESS>",
],

A correction could be setting port value:
"nameservers" => [
    "<IP_ADDRESS>:53",
    "<IP_ADDRESS>:53",
],

Thanks. Could you test with the latest dev-master? It should work, I just want to be sure before tagging a new release.

Sounds like this is a php-src inconsistency of win vs. *nix ?

@staabm: What should be a php-src inconsistency here?

The initial report reads like the code (before your referenced commit) worked before on non-windows and doesnt on *nix

Yes, because we read the resolv.conf on Linux, but that doesn't exist on Windows. It's really complicated on Windows to read those settings.

Testet with the last dev-master. It works on my windows system. Thank you for the fast reaction.

Thanks for the verification, 0.8.4 has been tagged.


HDDS-5987. [Ozone-Streaming] Add XceiverClientRatis stream config

Add XceiverClientRatis stream config
jira: https://issues.apache.org/jira/browse/HDDS-5987

hi @captainzmc , can you help review this patch?

This is ozone's patch used fix RATIS-1424?

@captainzmc ,

这是用于修复 RATIS-1424 的臭氧补丁吗？

yes,
the configuration in ratis needs to be applied in ozone.


Tries to fix the broken CI workflows

Description
Tries to fix the broken CI workflows in PR.

Testing instructions
Preview link:
Checklist

[ ] Review label added
[ ] Conditional version tags added, if applicable.

Hmmm, maybe it's needed to adjust permissions at https://github.com/organizations/Kong/settings/actions to allow GITHUB_TOKEN for more privileges

Otherwise, even manually set:
    permissions:
      contents: write
      issues: write
      pull-requests: write

theses permissions at workflow will still result in
GITHUB_TOKEN Permissions
  Contents: read
  Issues: read
  Metadata: read
  PullRequests: read

in actual run.

The issue here is that the action triggers on pull_request rather than pull_request_target, which doesn't have access to secrets when the contributor is submitting from a fork.
Switching to pull_request_target is ok in this instance as executing the check from main is preferred 99% of the time

@mheap Got it, 😃, so maybe it's save to close this PR now.


OCPVE-620: docs: add guidance on Multi-Node Topology Snapshotting

Creates a guidance documentation on Snapshotting and Cloning in Multi-Node Topologies. It specifically recommends to use Stateful Sets alongside preprovisioned and bound source PVCs to avoid running into scheduler limitations that may (or may not) occur in TopoLVM CSI scheduling (I opened a discussion in https://github.com/topolvm/topolvm/discussions/737 to clarify the exact conditions, also I am trying to independently verify this issue).

Codecov Report

Merging #384 (1812657) into main (a962b90) will increase coverage by 39.78%.
Report is 28 commits behind head on main.
The diff coverage is 73.00%.

Additional details and impacted files

@@             Coverage Diff             @@
##             main     #384       +/-   ##
===========================================
+ Coverage   16.59%   56.37%   +39.78%
===========================================
  Files          24       26        +2
  Lines        2061     2235      +174
===========================================
+ Hits          342     1260      +918
+ Misses       1693      884      -809
- Partials       26       91       +65

Files Changed
Coverage Δ

controllers/lvmcluster_controller_watches.go
90.32% <ø> (+90.32%)
:arrow_up:

pkg/vgmanager/vgmanager_controller.go
6.59% <0.00%> (+6.59%)
:arrow_up:

controllers/topolvm_snapshotclass.go
61.22% <14.28%> (+61.22%)
:arrow_up:

controllers/lvmcluster_controller.go
58.63% <50.00%> (+58.63%)
:arrow_up:

pkg/cluster/leaderelection.go
66.66% <66.66%> (ø)

pkg/cluster/sno.go
72.72% <72.72%> (ø)

controllers/topolvm_controller.go
94.14% <100.00%> (+94.14%)
:arrow_up:

pkg/vgmanager/devices.go
76.80% <100.00%> (+2.60%)
:arrow_up:

... and 10 files with indirect coverage changes

Great explanation!
/lgtm
/approve
/hold
for docs team to review.

/unhold @johnwilkins made a pass over this

/unhold


locate(), item_index(), sub_index()

Re: issue #139, this PR adds three new tools:

locate(iterable, pred, n) - Returns the ~first index~ indexes where pred returns True, ~skipping the first n matches.~
~item_index(iterable, item, start, end) - Like list.index(), but for iterables. Returns the first index of item in iterable, restricting the search between start and end.~
~sub_index(iterable, sub, start, end) - List str.index(), but for iterables. Returns the first index where sub-sequence sub starts, restricting the search between start and end.~

locate() is a generalization of what was requested in the issue; the docstring has an example of how to look for a particular item.
~item_index() could be rolled into sub_index(), but it would be slower.~
I like these because they fit the of "easy to specify, seem like itertools should be applicable, tricky to get right" criteria we aim for.
CC: @pylang

I did some timings and a naive approach:
def item_index2(iterable, item, start=0, end=None):
    iterable = islice(iterable, start, end)
    for idx, ititem in enumerate(iterable, start):
        if ititem == item:
            return idx
    else:
        raise ValueError('item "{!r}" not found.'.format(item))

seems to be faster.
iterable = ['a']*10000 + ['b']
item = 'b'

%timeit item_index2(iterable, item)
# 2.6 ms ± 112 µs per loop (mean ± std. dev. of 7 runs, 100 loops each)
%timeit item_index(iterable, item)
# 6.96 ms ± 162 µs per loop (mean ± std. dev. of 7 runs, 100 loops each)

iterable = ['a']*5 + ['b']
item = 'b'

%timeit item_index2(iterable, item)
# 4.12 µs ± 361 ns per loop (mean ± std. dev. of 7 runs, 100000 loops each)
%timeit item_index(iterable, item)
# 10.4 µs ± 358 ns per loop (mean ± std. dev. of 7 runs, 100000 loops each)

This is probably also the case for the subindex approach.

Thanks for running the test. I'll leave the item_index() and sub_index() out of this PR for now.
I've changed locate() to return an iterator over matching indexes, which seems like the right place to end up.


wownero: <IP_ADDRESS> -> <IP_ADDRESS>

Motivation for this change
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[x] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

s/fetchFromGitHub/fetchgit/g Should fix the CI error.

@doronbehar Thanks, I have no idea how my local build passed :D


[Bug] Unit Test projects now reference Xamarin.Forms.Platform.WPF

Description
I'm not sure if this is a bug per-se, but I couldn't find any previous discussion of it so thought I would mention it as it doesn't "feel right". For our Xamarin Forms project, we have some unit tests that verify some of the business logic works and doesn't break between various upgrades. These are not UI tests. Just a standard netcoreapp3.1 project type for unit testing.
Today I installed Xamarin Community Toolkit and noticed the following warnings appeared:
warning NU1701: Package 'OpenTK 3.0.1' was restored using '.NETFramework,Version=v4.6.1, .NETFramework,Version=v4.6.2, .NETFramework,Version=v4.7, .NETFramework,Version=v4.7.1, .NETFramework,Version=v4.7.2, .NETFramework,Version=v4.8' instead of the project target framework '.NETCoreApp,Version=v3.1'. This package may not be fully compatible with your project.

warning NU1701: Package 'OpenTK.GLControl 3.0.1' was restored using '.NETFramework,Version=v4.6.1, .NETFramework,Version=v4.6.2, .NETFramework,Version=v4.7, .NETFramework,Version=v4.7.1, .NETFramework,Version=v4.7.2, .NETFramework,Version=v4.8' instead of the project target framework '.NETCoreApp,Version=v3.1'. This package may not be fully compatible with your project.

My tests still execute and work fine, but it doesn't seem right that my unit tests project would now be forced to reference a platform lib. I downloaded the latest code from here and verified that the unit test project here does the same.
Is this actually a bug or something we have to live with due to no other way to differentiate WPF from a "generic non-platform" project?
Steps to Reproduce

Create a shared library and install Xamarin Forms 5.0.0 and Community Toolkit 1.0.2 via NuGet.
Create a unit test library that has a project reference to the first project.
Compile, see warnings when NuGet packages are restored.

Expected Behavior
No reference to a platform I'm not using and is not valid for unit testing.
Actual Behavior
Xamarin.Forms.Platform.WPF gets added as a dependency of my Unit Tests project, which chains to the OpenTK package as well.
Basic Information

Version with issue: 1.0.2
Last known good version: n/a
IDE: Visual Studio 2019 16.8.4 Windows 10
Platform Target Frameworks:

iOS:
Android:
UWP:

Android Support Library Version:
Nuget Packages: Xamarin Forms 5.0.0
Affected Devices:

Workaround
None so far.
Reproduction imagery

Reproduction Link
Let me know if I need to add one, since the unit tests in XCF exhibit the same behavior.

Please fix this. I run into the same issue. Workaround <GenerateErrorForMissingTargetingPacks>false</GenerateErrorForMissingTargetingPacks> helped.

The workaround with <GenerateErrorForMissingTargetingPacks>false</GenerateErrorForMissingTargetingPacks> doesn't work for my .NET 5 test projects. Also I don't want to disable all (unknown) errors. You can, however, disable them more specifically, if you include the packages yourself, like this:
Project.Tests.csproj:
<ItemGroup>
    <PackageReference Include="OpenTK" Version="3.0.1">
	<NoWarn>NU1701</NoWarn>
    </PackageReference>
    <PackageReference Include="OpenTK.GLControl" Version="3.0.1">
	<NoWarn>NU1701</NoWarn>
    </PackageReference>
</ItemGroup>

But you should check the status of this issue and remove the workaround as soon as possible (or update the package manually, whenever XCT does).

Has there been an update to this? The workaround everyone has mentioned doesn't work for me.

@mgramley Ensure your Unit Test project is targeting .NET Core 3.1 and that the Unit Test CSPROJ includes <GenerateErrorForMissingTargetingPacks>false</GenerateErrorForMissingTargetingPacks>.
We do not have a known way to fix this without removing Xamarin Community Toolkit support for WPF.
We are open to pull requests.

I already had the GenerateErrorForMissingTargetingPacks flag in my project, it did not resolve the issue for me.
For now, since I only need a single view from the toolkit I will pul the latest source files into my project.

@brminnick  false and test project targeting .NET Core 3.1 does not work.

This seems to be the root cause for https://github.com/xamarin/XamarinCommunityToolkit/issues/1167 and https://github.com/xamarin/XamarinCommunityToolkit/issues/1482.

Its nice we have a workaround but this doesn't work for .net5.0 projects and thinking about .net6.0 compatibility when we eventually migrate XF projects to MAUI I'd rather be using a newer .net version than netcoreapp3.1 😅

@jfversluis did you check with the repository owners how they want to untangle the dependency to Xamarin.Forms.Platform.WPF? From my point of view, such a dependency should never have been added. As for now since we move our test projects to net6.0, we had to get rid of XamarinCommunityToolkit. Let me know if we can use it again.

Any update on this? Sad that we havev to run tests on coreapp 3.1.

We're in the same situation as @haavamoa 😫

Had to remove the community toolkit due to this issue :'(

I was running into this issue with my net6.0-android sdk-style app project rather than a unit test project. The GenerateErrorForMissingTargetingPacks workaround did not work for me either but I found this one that does:
  <Target BeforeTargets="_CheckForTransitiveWindowsDesktopDependencies" Name="_FixStupidSdkError_NETSDK1136">
    <ItemGroup>
      <TransitiveFrameworkReference Remove="Microsoft.WindowsDesktop.App" />
      <TransitiveFrameworkReference Remove="Microsoft.WindowsDesktop.App.WPF" />
      <TransitiveFrameworkReference Remove="Microsoft.WindowsDesktop.App.WindowsForms" />
    </ItemGroup>
  </Target>

It's obviously not ideal if you actually develop for these platforms but that wasn't a problem in my case.
I originally tried something like this to force the use of a different target framework without the WPF dependency but it appears the aforementioned target still runs regardless of the PackageReference.ExcludeAssets attribute.


Choose a validation lib and use it to make basic validation on each form

From the discussion we had with @sjcobb @Gladorme, best candidates for now seems to be a conjunction of https://react-hook-form.com/ + https://zod.dev/

From the discussion we had with @sjcobb @Gladorme, best candidates for now seems to be a conjunction of https://react-hook-form.com/ + https://zod.dev/

Yes, let’s start experimenting with this asap and agreed that the libs in description seem like top candidates

All big forms are validated by Zod and React-Hook-Form (#2044), except for plugin spec inputs. It still need to be done. However, plugin should be able to inject their validation schema in the ValidationProvider in order to have full validation.


Connection acquisition incorrectly assumes that there will be a waiter in the pool

Hi,
I keep getting this in my logs when running concurrent tests. It uses 5 concurrent users - and the exception observed is this with the ReactiveX flavour:
SEVERE: Unhandled exception
java.lang.NullPointerException
	at com.julienviet.pgclient.impl.ConnectionPool.lambda$check$1(ConnectionPool.java:165)
	at com.julienviet.pgclient.impl.ConnectionPool.doAcq(ConnectionPool.java:139)
	at com.julienviet.pgclient.impl.ConnectionPool.lambda$doAcq$0(ConnectionPool.java:150)
	at com.julienviet.pgclient.impl.InitCommand.handleMessage(InitCommand.java:93)
	at com.julienviet.pgclient.impl.SocketConnection.handleMessage(SocketConnection.java:233)
	at io.vertx.core.net.impl.NetSocketImpl.handleMessageReceived(NetSocketImpl.java:351)
	at io.vertx.core.net.impl.NetClientImpl$1.handleMessage(NetClientImpl.java:242)
	at io.vertx.core.net.impl.NetClientImpl$1.handleMessage(NetClientImpl.java:239)
	at io.vertx.core.net.impl.VertxHandler.lambda$channelRead$1(VertxHandler.java:146)
	at io.vertx.core.impl.ContextImpl.lambda$wrapTask$2(ContextImpl.java:337)
	at io.vertx.core.impl.ContextImpl.executeFromIO(ContextImpl.java:195)
	at io.vertx.core.net.impl.VertxHandler.channelRead(VertxHandler.java:144)
	at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:362)
	at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:348)
	at io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:340)
	at io.netty.handler.codec.ByteToMessageDecoder.fireChannelRead(ByteToMessageDecoder.java:310)
	at io.netty.handler.codec.ByteToMessageDecoder.channelRead(ByteToMessageDecoder.java:284)
	at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:362)
	at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:348)
	at io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:340)
	at io.netty.channel.DefaultChannelPipeline$HeadContext.channelRead(DefaultChannelPipeline.java:1359)
	at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:362)
	at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:348)
	at io.netty.channel.DefaultChannelPipeline.fireChannelRead(DefaultChannelPipeline.java:935)
	at io.netty.channel.nio.AbstractNioByteChannel$NioByteUnsafe.read(AbstractNioByteChannel.java:141)
	at io.netty.channel.nio.NioEventLoop.processSelectedKey(NioEventLoop.java:645)
	at io.netty.channel.nio.NioEventLoop.processSelectedKeysOptimized(NioEventLoop.java:580)
	at io.netty.channel.nio.NioEventLoop.processSelectedKeys(NioEventLoop.java:497)
	at io.netty.channel.nio.NioEventLoop.run(NioEventLoop.java:459)
	at io.netty.util.concurrent.SingleThreadEventExecutor$5.run(SingleThreadEventExecutor.java:886)
	at io.netty.util.concurrent.FastThreadLocalRunnable.run(FastThreadLocalRunnable.java:30)
	at java.base/java.lang.Thread.run(Thread.java:844)

My pool settings are:
        PgPoolOptions options = new PgPoolOptions()
                .setPort(5432)
                .setHost("vm")
                .setDatabase("xxxxx")
                .setUsername("yyyyy")
                .setPassword("zzzzz")
                .setConnectTimeout(100000)
                .setIdleTimeout(100000)
                .setCachePreparedStatements(true)
                .setLogActivity(true)
                .setReconnectAttempts(10)
                .setTcpFastOpen(true)
                .setMaxSize(25);

All queries issued return a Single, and I'm using the query code like this (rxPreparedQuery):
    public Single<T> get(UUID entityId, Identity identity) {
        Tuple binds = Tuple.of(entityId, identity.getIdentityId());
        return db.rxPreparedQuery("select * from " + typeParameterClass.getSimpleName().toLowerCase() +" where id=$1 and identityid=$2", binds).map(rowPgResult -> {
            if (rowPgResult.size() == 0) {
                return empty();
            }
            Row next1 = rowPgResult.iterator().next();
            return mapRow(next1);
        });
    };

The issue is intermittent, but as I remove my tests concurrency, the error appears less. Running the code more times seems to yield less errors. With a single user, on repeated tests the error will no longer appear.
Seems that this code gets triggered when I see it:
  public void handleMessage(InboundMessage msg) {
    if (msg.getClass() == ReadyForQuery.class) {
      ReadyForQuery readyForQuery = (ReadyForQuery) msg;
      completionHandler.handle(null);
      if (failure != null) {
        handler.handle(CommandResponse.failure(failure, readyForQuery.txStatus()));
      } else {
        handler.handle(CommandResponse.success(result, readyForQuery.txStatus()));
      }
    } else {
      System.out.println(getClass().getSimpleName() + " should handle message " + msg);
    }
  }

That is
        handler.handle(CommandResponse.failure(failure, readyForQuery.txStatus()));

has the status:   txStatus=IDLE
Not sure if related - or that if the error is because the PreparedStatement doesn't exist? I can't figure it out yet.
Any clues?

can you provide a reproducer ? what if you don't use rx ?

it's hard to make sense of this exception because:
ExtendedQueryResultHandler.java:45:
suspended = res.result();

and
CommandBase.java:44
handler.handle(CommandResponse.failure(failure, readyForQuery.txStatus()))

and clearly CommandResponse.failure(...) does not return null

Yes maybe it's misleading. I'll try and write up a quick tests and test cases to reproduce. I'm migrating my project from Scala back to Java so it may be a few days as I get time.
Thanks for looking up.

@vietj I have not had time to create a proper test case for you just yet, however - I swapped over to the  default version (the Kotlin friendly one). I get the same issue regardless of the flavour.
Cheers

let me know if you can provide more context because the stack trace does not make sense to me

@vietj You know, even though it logs this null, the app still is working fine.  Either way, like I said - I'm sticking to this driver as it's the best out there by far

@willks thanks for everything! we spent lot of time in the client to make it simple and efficient!

@vietj I tried the rest already - they all hang with the lightest load and one even required changes to the Postgres configuration!
I have a better hint now at the issue from this pic:
https://ibb.co/mndBDH
So it looks like the waiter is null? I dunno. I'll try and get on that test
private void check() {
    if (waiters.size() > 0) {
      doAcq(ar -> {
        if (ar.succeeded()) {
          PooledConnection proxy = ar.result();
          Future<Connection> waiter = waiters.poll();
          waiter.complete(proxy);
        } else {
          Future<Connection> waiter;
          while ((waiter = waiters.poll()) != null) {
            waiter.fail(ar.cause());
          }
        }
      });
    }
  }

that would be a race condition in the pool under high load ?

@vietj Looks like. It's 5 threads, with 3 requests each. My tests use Scala (SBT) so all integration tests kick off at the same time. Every request does a "user" check based on JWT token, to verify identity. I plan to introduce a cache for this though. My current DA tier acquires connections from pool manually (and returns on error/success/exception) - but also tried using the automatic pool acquisition, which was the initial issue that I raised. The result is the same at this point.
In any case, I'm still developing my app and just ignoring it for now. Compared to the awesome work so far, I'm sure it's one of those "easy to fix" but "difficult to find" concurrency issues. The bane of development! As this is my private app (but high concurrency due use-case) - I have to to test and nut out issues.

@willks you are totally right

I don't have reproducer code, but I know how to trigger this exception. Maybe it will make it easier to find.
If you start with a maxsize pool of 1, then run a query with a cursor, and then try to run another query before closing the cursor, then you will get this exact NullPointerException.
Probably this is the same thing that is happening under high load - by chance all connections in the pool have a cursor open, and one additional request tries to run. A temporary workaround would be to have 1 pool that is only for cursors, and another pool that handles any queries done from within a cursor.

Well, here is a start, but it does reproduce it.
https://github.com/willks/pgtest
Not sure if it's 100% right, but the exception happens. If the pool size is 1, I don't get the issue. Strange.
Use "gradle run" to execute

thanks, will have a look soon.

@willks I've fixed the bug you reported, can you check that master works fine with your branch ? (I've checked with your reproducer and it works fine)

@willks once you have done this check, I can do a 0.5.2 release with the fix

@vietj Looks good!!
Thanks for this


enhancement print table lock owner when failed to try lock

Proposed changes
Issue Number: close #xxx
Problem summary
Sometimes we may encounter error like:
get tableList write lock timeout

But it is hard to find out which thread is holding the lock.
So I add a log to print the lock owner when failed to try lock.
But to avoid print to much lock, only print log if timeout >= 1 second
Checklist(Required)

Does it affect the original behavior:

[ ] Yes
[x] No
[ ] I don't know

Has unit tests been added:

[ ] Yes
[ ] No
[x] No Need

Has document been added or modified:

[ ] Yes
[ ] No
[x] No Need

Does it need to update dependencies:

[ ] Yes
[ ] No

Are there any changes that cannot be rolled back:

[ ] Yes (If Yes, please explain WHY)
[x] No

Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 34.7 seconds
load time: 521 seconds
storage size:<PHONE_NUMBER>0 Bytes
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20230129055345_clickbench_pr_86002.html


Add variables to HIR

Introduce a hir::Variable, which should cover locals, parameters and self. Unlike PatId, variable knows it's owner so it is self-contained, and should be more convenient to use from ra_ide_api.
The goal here is to hide more details about Body from hir, which should make it easier to move Body into hir_def. I don't think that ra_ide_api intrracts with bodies directly at the moment anyway, but the glue layer is based basically on ast::BindPat, which seems pretty brittle.

bors r+


Missing CONTRIBUTING.md File in Repository

The repository currently lacks a CONTRIBUTING.md file, which is an important resource for guiding potential contributors on how to engage with the project effectively. A CONTRIBUTING.md file outlines the contribution guidelines, coding standards, and procedures for submitting pull requests, thus streamlining the contribution process and ensuring consistency across contributions.
Could you please assign this issue to me under GSSOC 24.

@suhanipaliwal I have assigned you this issue, please start working on it.


Export tree builder support

Codecov Report

Merging #4 (f1d24cc) into main (bca193d) will increase coverage by 0.08%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main       #4      +/-   ##
==========================================
+ Coverage   92.30%   92.39%   +0.08%
==========================================
  Files           6        6
  Lines         429      434       +5
==========================================
+ Hits          396      401       +5
  Misses         24       24
  Partials        9        9

Impacted Files
Coverage Δ

src/notionclient/notion_client.go
100.00% <100.00%> (ø)

src/tree/node/node.go
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bca193d...f1d24cc. Read the comment docs.


Please fix saved configurations

I constantly have to re-map my configurations to my bluetooth controller everytime I disconnect and reconnect my controller.
It would be a great alternative if each time I connect a dinput controller via bluetooth to immediately associate it to the last saved xinput controller configuration.

I'm experiencing this issue too. Hoping for a fix.

I was using the 3.22 version because this problem, but after I formatted the computer, it no longer recognizes the installed ViGem. From 3.23 onwards he recognizes normally, but then we have again this problem.

I'm having the same problem. But bindings drop shortly after starting XOutput. I would be really greatful for a fix as there's no exact alternave to XOutput. I cannot use standard gamepads for XInput games due to medical condition that leaves me with tremor. Using hotas-sized joysticks reduces this for me. I've been using XOutput for years and really hoping it's not dead. (XOutpu.log attached).
https://hastebin.com/etediyajev.yaml

Set Read-only on settings.json properties after you configure your devices.

Use "Restart On Crash" for XOutput crashes.

Or test x360ce (equivalent software) but it kill HidGuardian (issue corrected maybe?), it will be necessary to add the device manually in the registry including to return to XOuput.

* Set Read-only on settings.json properties after you configure your devices.

* Use "Restart On Crash" for XOutput crashes.

* Or test x360ce (equivalent software) but it kill HidGuardian (issue corrected maybe?), it will be necessary to add the device manually in the registry including to return to XOuput.

Thanks for your suggestions Zaanza. I've already tried the first two, without success, and was reluctant to switch to x360ce, sinc I've been with xOutput for several years. But, since there doesn't seem to be a solution to the specific problem I have, I've switched to x360ce. And although it involves a bit mre hassle, I suppose I will have to stick to it.
Thanks again.

The first two solutions work 100% on the PCs where I install it.

@Zaanza Can you show us step by step on how to do the first solution?

Sorry for bad english.

Configure your controller in XOuput, disable run at startup in settings (and click on save settings for edit the settings.json).

In XOutput installation folder, right click on settings.json → Properties → Check Read-only → OK (this will prevent any modification of the file even by the user).

Download RestartOnCrash and extract folder in your programs.

In RestartOnCrash settings check start at startup, minimized, system tray...

Add XOutput in RestartOnCrash like this :

Can I do the above solution without RestartOnCrash? Just the Set Read-only on settings.json properties

Yes, but sometimes the program closes on its own after launch games, I think that's what's bothering it.

Tried the method and did not work for me.. When I went to disconnect my controller and reconnect it, the saved configurations became all blank again. :( Hope we get a fix soon..

 Thanks a bunch


generate 2 html files per entrypoint

or at least provide an option to do so. Similar to the option that let's you say whether to inject platform.js, we should have an option to generate both an .html file for browsers that need platform.js and one for those that dont.

This issue has been moved to dart-lang/polymer-dart#445.


Bugfix: Readme images not rendering in gihub

Expected Behavior

Current Behavior

Possible Solution

Steps to Reproduce

Context (Environment)

Possible Implementation

Additional Comments

Duplicate of #1305


[CELEBORN-336] Revive cause should also pass REVIVE_FAILED

What changes were proposed in this pull request?
Revive cause should also pass REVIVE_FAILED
Why are the changes needed?
Does this PR introduce any user-facing change?
How was this patch tested?

ping @waitinfuture @FMX @pan3793


Custom Apache HttpClient configuration is overridden (v2.0.05+)

Describe the bug
After configuring a custom Apache HttpClient for use with Unirest, the request configuration, User-Agent request header, and Accept-Encoding request header are set to default values. In other words, parts of the custom client's configuration are overridden by Unirest. There isn't an easy way to workaround this issue because it's not possible to configure Unirest timeouts after setting a custom client.
There are some other minor bugs. Most of these can be seen in the debug log output below and are located in RequestPrep.

The Content-Type request header is not capitalized
The User-Agent request header is not capitalized
The User-Agent request header value is hard-coded to Unirest version 3.0.00 (unirest-java/3.0.00)
The Accept-Encoding request header is not capitalized

To Reproduce
Steps to reproduce the behavior:

Configure Unirest to use a custom, initialized Apache HttpClient. In our code below, we have a custom HttpClientBuilder class that returns a CloseableHttpClient that we pass to Unirest.config().httpClient(). As you can see, this custom client has our desired user agent string, SSL configuration, and connect/socket timeout configuration.

    Unirest.config().httpClient(HttpClientBuilder.create(userAgent, this.trusting)
                                  .connectTimeout(this.connectTimeout)
                                  .socketTimeout(this.socketTimeout)
                                  .build());

Make a request with Unirest and observe it using default timeouts. Here you can see that a custom socket timeout of 15 seconds is being set back to the default of 60 seconds in the Apache HttpClient debug logs:

2019/06/26 12:14:40:998 PDT [DEBUG] RequestAddCookies - Cookie [version: 0][name: JSESSIONID][value: <session-id>][domain: <hostname>][path: /api][expiry: null] match [(secure)<hostname>:443/api/v1/status]
2019/06/26 12:14:40:998 PDT [DEBUG] RequestAddCookies - Cookie [version: 0][name: localeId][value: en][domain: <hostname>][path: /][expiry: Tue Jun 21 12:14:40 PDT 2039] match [(secure)<hostname>:443/api/v1/status]
2019/06/26 12:14:40:998 PDT [DEBUG] RequestAuthCache - Auth cache not set in the context
2019/06/26 12:14:40:998 PDT [DEBUG] PoolingHttpClientConnectionManager - Connection request: [route: {s}->https://<hostname>:443][total kept alive: 1; route allocated: 1 of 10; total allocated: 1 of 50]
2019/06/26 12:14:40:998 PDT [DEBUG] PoolingHttpClientConnectionManager - Connection leased: [id: 0][route: {s}->https://<hostname>:443][total kept alive: 0; route allocated: 1 of 10; total allocated: 1 of 50]
2019/06/26 12:14:41:013 PDT [DEBUG] DefaultManagedHttpClientConnection - http-outgoing-0: set socket timeout to 15000
2019/06/26 12:14:41:013 PDT [DEBUG] DefaultManagedHttpClientConnection - http-outgoing-0: set socket timeout to 60000
2019/06/26 12:14:41:013 PDT [DEBUG] MainClientExec - Executing request GET /api/v1/status HTTP/1.1
2019/06/26 12:14:41:013 PDT [DEBUG] MainClientExec - Target auth state: UNCHALLENGED
2019/06/26 12:14:41:013 PDT [DEBUG] MainClientExec - Proxy auth state: UNCHALLENGED
2019/06/26 12:14:41:013 PDT [DEBUG] headers - http-outgoing-0 >> GET /api/v1/status HTTP/1.1
2019/06/26 12:14:41:013 PDT [DEBUG] headers - http-outgoing-0 >> Accept: application/json
2019/06/26 12:14:41:013 PDT [DEBUG] headers - http-outgoing-0 >> user-agent: unirest-java/3.0.00
2019/06/26 12:14:41:013 PDT [DEBUG] headers - http-outgoing-0 >> accept-encoding: gzip
2019/06/26 12:14:41:013 PDT [DEBUG] headers - http-outgoing-0 >> Host: <hostname>:443
2019/06/26 12:14:41:013 PDT [DEBUG] headers - http-outgoing-0 >> Connection: Keep-Alive
2019/06/26 12:14:41:013 PDT [DEBUG] headers - http-outgoing-0 >> Cookie: JSESSIONID=<session-id>; localeId=en
2019/06/26 12:14:41:123 PDT [DEBUG] headers - http-outgoing-0 << HTTP/1.1 200 OK
2019/06/26 12:14:41:123 PDT [DEBUG] headers - http-outgoing-0 << Strict-Transport-Security: max-age=31622400; includeSubDomains
2019/06/26 12:14:41:123 PDT [DEBUG] headers - http-outgoing-0 << Content-Type: application/json
2019/06/26 12:14:41:123 PDT [DEBUG] headers - http-outgoing-0 << Transfer-Encoding: chunked
2019/06/26 12:14:41:123 PDT [DEBUG] headers - http-outgoing-0 << Date: Wed, 26 Jun 2019 19:14:40 GMT
2019/06/26 12:14:41:123 PDT [DEBUG] headers - http-outgoing-0 << Server: <server>
2019/06/26 12:14:41:123 PDT [DEBUG] MainClientExec - Connection can be kept alive indefinitely
2019/06/26 12:14:41:123 PDT [DEBUG] PoolingHttpClientConnectionManager - Connection [id: 0][route: {s}->https://<hostname>:443] can be kept alive indefinitely
2019/06/26 12:14:41:123 PDT [DEBUG] DefaultManagedHttpClientConnection - http-outgoing-0: set socket timeout to 0
2019/06/26 12:14:41:123 PDT [DEBUG] PoolingHttpClientConnectionManager - Connection released: [id: 0][route: {s}->https://<hostname>:443][total kept alive: 1; route allocated: 1 of 10; total allocated: 1 of 50]
2019/06/26 12:14:41:123 PDT [DEBUG] MainClientExec - Cancelling request execution

After diving into the Unirest code, I can see that the cause is the logic in the RequestPrep.getHttpRequestBase() method. The User-Agent and Accept-Encoding request headers are overridden on lines 78-83 because they don't first check for any existing custom client values.
        if (!request.getHeaders().containsKey(USER_AGENT_HEADER)) {
            request.header(USER_AGENT_HEADER, USER_AGENT);
        }
        if (!request.getHeaders().containsKey(ACCEPT_ENCODING_HEADER) && config.isRequestCompressionOn()) {
            request.header(ACCEPT_ENCODING_HEADER, "gzip");
        }

The client's RequestConfig is overridden in this same method on line 89. I looked at this history, and this line was added as part of #118 and the overrideConfig() method has been enhanced since. It would seem that a possible resolution would be to make this line conditional based on the lack of a custom client. Alternatively you'd have to check the custom client's value for each RequestConfig field set in overrideConfig().
reqObj.setConfig(overrideConfig());

Here's a stack trace excerpt, if helpful:
overrideConfig:99, RequestPrep (kong.unirest.apache)
getHttpRequestBase:89, RequestPrep (kong.unirest.apache)
prepare:70, RequestPrep (kong.unirest.apache)
request:101, ApacheClient (kong.unirest.apache)
asJson:194, BaseRequest (kong.unirest)
get:465, RestClient (<redacted>)    <-- Our custom REST client that uses Unirest to make requests

This overridden RequestConfig object from the overrideConfig() method is the passed along as requests are executed, which causes the Apache HttpClient to use those values instead of the client's default request configuration.
NOTE: It's possible that there are other places in the Unirest codebase that should be updated to check/account for a custom client.
Expected behavior
After configuring a custom Apache HttpClient for use with Unirest, its configuration should be used for Unirest requests.
Screenshots
N/A
Environmental Data:

Java 8

Below are my specific dev environment details, but this issue has been reproduced in different Java 8 environments as well.

openjdk version "1.8.0_192"
OpenJDK Runtime Environment (Zulu <IP_ADDRESS>-win64) (build 1.8.0_192-b01)
OpenJDK 64-Bit Server VM (Zulu <IP_ADDRESS>-win64) (build 25.192-b01, mixed mode)

We are currently using 2.2.02, but these issues have been around since at least 2.0.05 based on the commit history (https://github.com/Kong/unirest-java/commit/4d21d0c0b00cfea43a7561ff340ea982136b3b48)

Let me know if you have any other questions! Thanks.

So, yea, totally OK with fixing this, however, the intent of Unirest is to abstract Apache as much as possible. Why not just configure Unirest itself to do these things and avoid a custom Http Client?

Thanks for the quick reply! And ha, I figured you'd ask! We definitely want to use the 'native' options in Unirest over a custom client if we can. As far as I can recall, when we last looked at doing this, there were several options that Unirest didn't support. Below I've done my best to recall the options we need and look up their current support status, but there may be one or two I'm missing. Feel free to correct me on the support status as needed.

User agent string: Supported via setDefaultHeader() or addDefaultHeader()
Connect timeout: Supported via connectTimeout()
Socket timeout: Supported via socketTimeout()
Max connections: Supported via concurrency()
Max connections per route: Supported via concurrency()
Disable redirect handling: Supported via followRedirects()
Redirect strategy: Unsupported (although this may not be needed)
Allow use of Java system properties: Supported via useSystemProperties()
Disable TLS validation: Supported via verifySsl() (looks like the Unirest implementation may work, but we'll need to test)

We also explicitly define a default SocketConfig with the socket timeout we want (in addition to the default RequestConfig) due to some historical bugs in the HTTP client library. I suppose we could reassess if this is needed, but I know it was an issue in the past.

So, I'm mulling over the best way to do this, It's tricky because neither the client, nor the request config, are all encompassing of settings (in true Apache Http Client fashion).  some also come with defaults, so detecting, "is that the default or did someone set it" is tricky. My preference is to provide a way for you to override the request config in addition to the client. Do you think this would work for you?
One other note on your original issue. You noted that several of the headers are not capitalized. This was, per the original Unirest on purpose. The RFC for HTTP states that

Each header field consists of a name followed by a colon (":") and the field value. Field names are case-insensitive.
https://www.w3.org/Protocols/rfc2616/rfc2616-sec4.html#sec4.2

While this is the spec, many different systems are somewhat notorious for not following this rule. For example a major identity provider I work with requires the "accept" header to be lowercase. I would have gone with the capitalized version myself but at this point changing it could be a problem (and it's not technically wrong). I have noticed that Jetty will standardize the headers to the cased versions.

I'm currently testing things out on our end using the Unirest options instead of a custom client. If that works, I would be okay you resolving this with 'use as is'.
If you would like to address the main issue (configuration override) or the above attempt fails for some reason, I think your approach would work assuming I understand it correctly. Is it similar to the below?

If a custom client is configured for use with Unirest, use its configuration (in my experience, if the custom client doesn't have something set, the library will use its defaults/standard behavior)
If Unirest has been configured to override a setting (such as the request socket timeout), use that
If a Unirest request has been configured to override a setting, use that (see use of socketTimeout() below)

      Unirest.get(baseUrl + "csrf-token")
        .basicAuth(username, password)
        .accept("application/json")
        .socketTimeout(15000)
        .asJson()

As for the request header capitalization issue, understood. I noted these were minor because the servers we've used seem to handle lowercase just fine. I was just pointing it out for standardization and consistency.
You may, however, want to adjust the hard-coded value for the User-Agent request header to update it with each release of Unirest (unless there was some reason to use 3.0.00).

Alright, my quick/initial testing using the available Unirest options is somewhat promising, but there are some discrepancies from our custom synchronous client approach:

Unirest sets the connection request timeout to the value of the socket timeout versus the library default of -1

I'm not sure if this will have any real impact...likely not

Unirest always uses the DefaultRedirectStrategy

In other words, the strategy is not configurable
Again, probably not an issue

Unirest initializes a pooling connection manager for the synchronous client that has no default SocketConfig defined

As I mentioned above, we have used this to account for some historical bug(s) in the library which may or may not be needed anymore
I noticed in the client debug logs that the socket timeout was first set to 0 before being set to the configured value, so it seems like a defined SocketConfig may not be needed since the correct value gets set before the request is made...

Unirest ignores the configured concurrency settings (the total and per route maximum connections for its synchronous client's connection manager) which results in the library's default of 20 total connections with 2 max per route being used

Is this intentional?
I can provide more detail here if needed, but I held off in case you wanted me to open a new issue for this

As always, let me know if you have any questions. Thanks!

@elusiveeagle I believe the concurrency settings bug was fixed 2.3.07 see #280
If you are still seeing that it's not taking for some reason I can reopen that

@ryber Ah, yes. Thanks. That should do it. I'll try after using the latest version (had been testing with 2.2.02 still).

@ryber Just to circle back: Using Unirest 3.3.08 and the available Config options has been successful so far.
It would probably still be good to fix this issue for any others that may be impacted. At this time, however, we feel pretty confident in this alternative approach. Thanks!

In 2.3.09 I've added the ability to override the RequestConfig factory (see http://kong.github.io/unirest-java/#configuration)
This would in theory give those who want it full control over the Apache config.


Fix offset_by in pic_chat infinite scroll

Great catch! We should also fix this in the example repo.

Great catch! We should also fix this in the example repo.

Actually, the original repo has the correct code already. Only the reading was mistaken.


how to get IP address

Hello,
How to get IP address after wifi is connected?
I was looking through docs but could not found it.
Thank you

IP address is network address. So you need to connect to the network.
You can see the local IP address in the net module, Socket class.
https://kalumajs.org/docs/api/net#socketlocaladdress

Collaborator

I tried as u asked, but I get undefined as output.

you need to put  checking code after Connected to Wi-fi... else it's called immediatelly - not after wifi is really connected.

Still doesn't work, why is there no such function? This is such an essential functionality and should be part of the connection info:
const WiFi = require('wifi').WiFi,
    net = require('net'),
    wifi = new WiFi();

console.log("Connecting to WiFi....");
wifi.connect((err) => {
    if (err) {
        console.error(err);
    } else {
        wifi.getConnection((err, connInfo) => {
            console.log("Connected to Wifi: "+connInfo.ssid);
            const sock = new net.Socket();
            console.log('Address:', sock.localAddress);
        });
    }
});

Connecting to WiFi....
Connected to Wifi: MyWifi
Address: null

With some issue digging I found this: https://github.com/kaluma-project/kaluma/issues/554
That lead me to this code:
console.log("Connecting to WiFi....");
wifi.connect((err) => {
    if (err) {
        console.error(err);
    } else {
        wifi.getConnection((err, connInfo) => {
            console.log("Connected to Wifi: "+connInfo.ssid);
            console.log('Creating HTTP server simply to get my IP...');
            const server = http.createServer();
            server.listen(80, () => {
                console.log(`Yay, my IP is ${server._dev.ip}`);
                console.log('Shutting down server...');
                server.close();
                console.log('On with my code....');
            });
        });
    }
});

Is this really the only way? Spinning up an HTTP server simply to get the local IP address? Even in LUA for ESP8266 something like this has been available forever: https://nodemcu.readthedocs.io/en/release/modules/wifi/#wifistagetip


Namespace fix

Issue #32

Great job, thank you! We will solve this problem by changing only namespaces without affecting project name and csproj files itself.  Because we want to save entire NuGet package name. I will close this PR and re-implement this functionality in the separate branch, because your branch requires precise reverting of some changes. I want to avoid it.