Run 'npm audit fix' to address vulnerabilities

Codecov Report

Merging #7263 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #7263   +/-   ##
=======================================
  Coverage   64.72%   64.72%
=======================================
  Files         425      425
  Lines       20672    20672
  Branches     2282     2282
=======================================
  Hits        13380    13380
  Misses       7167     7167
  Partials      125      125

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1104aca...1f248b1. Read the comment docs.


Change background color to a cell?

I set a "className" to a cell and set custom attributes in my CSS file. When I set "color" property, the text's color changes, but not the cell's background color. "background-color" and "fill" don't do anything as far as I can see. I couldn't find information about it in the examples. How can I set the cell's background color?

If you mean the selected cells, currently they use an inset box-shadow for their coloring


[Event Request] Application “Tests-SM” Codeunit 137162 "SCM Warehouse - Shipping III"

[Event Request]Application “Tests-SCM”, 137162 "SCM Warehouse - Shipping III"
Could you please insert the Initialize procedure at the beginning of the test procedure Initialize?

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. We will update this issue with information about availability. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.


Change colour of button to request booking

That green is off is not at all related to our brand. Please let's change that.
Here is the button as we see it now:

And here is with our beautiful orange colour

Thanks 😄

I'll deal with this and it should be done by Friday.

@buckwierd
Please take care of all the green buttons we have. There are other buttons that have the same green. Log in button is another example.

The element for the booking button is
.ListingPage__bookButton__2IVbZ
This element is being forced to the green colour, meaning if we remove that instruction the button will go to our orange.

The green colour they use for the button is HEX #2ecc71
There is also a hover effect on that button, so when we edit the button colour, we need to manage the hover colour.

The hover colour they are using is HEX #239954

Colors are managed centralised over the "color" css file. Now that issue #79 was fixed, this one should automatically be fixed.

Closing


Ambient.py

Hi,
running OpenRGB under Ubuntu I found the missing screen capture support in Ambient.py quite annoying (since the remaining scripts perform well under Linux) and patched together a workaround.
319d6335f23321c77931b5fc88dc8cde4c3dc3da uses X11 to get the PIL Image from the current screen, but for performance reasons it requires compiling some C code on the machine beforehand (all credit goes to https://stackoverflow.com/questions/69645/take-a-screenshot-via-a-python-script-on-linux). Having the compiled program, Ambient.py runs very well on my machine.
I also played around using k-means clustering instead of just the average RGB value to determine the LED-setting (fd8ea3a6ac8d93d1d43a24b298c9360125feb91f). This is somewhat experimental as it required smoothing out the colors over multiple frames (in this case 3) to prevent flickering due to sampling differences. It works well for me for gaming but it requires scikit-learn for clustering and is not tested on Win or Mac.
Hope you find something oft his useful.
Cheers

This looks great so far :)
I am gonna throw in some try/except and then it should be good to go
Ambient has the same issues on my windows machine but I guess the point of this MR is linux support so I am gonna merge it anyways

This looks great so far :)
I am gonna throw in some try/except and then it should be good to go
Ambient has the same issues on my windows machine but I guess the point of this MR is linux support so I am gonna merge it anyways

Ambient.zip
Make any adjustments you want to that and let me know when you think it is ready
Then I can test and merge if it is working as it should

Ambient.zip
Make any adjustments you want to that and let me know when you think it is ready
Then I can test and merge if it is working as it should


[WIP] Inspect environment variables and set routing prefixes, add catchall endpoint

This PR will introduce a 'catchall' endpoint /*, which will be added as the final handler in the routr stack.
Additionally, DashR does not inspect local environment variables when initializing an app; routes_pathname_prefix and requests_pathname_prefix must be set manually. For greater parity with Dash for Python, the following route-related variables should be checked before setting route prefixes to NULL:

~DASH_URL_BASE_PATHNAME~
DASH_ROUTES_PATHNAME_PREFIX
DASH_REQUESTS_PATHNAME_PREFIX

Two additional helper functions are proposed in this PR:

get_package_mapping: given path to dependency, package string from request URL, and list of dependencies, attempts to build a package_map. The mapping is then used to resolve local paths to dependencies within the R packages that provide them. A list is returned with the R package name providing the dependency, as well as a local path to the file.
get_mimetype: resolve dependency MIME type based on file extension, currently supports application/JavaScript, application/json, text/css.

Lastly, previous versions of DashR did not include a _dash-component-suites handler. This PR also

eliminates static handling of routes for Dash components served upon index loading using ressource_route (which resolves a duplicate route error for the React JS upon relaunching an existing DashR app in the current workspace)
related to item above, :hocho: dashR::resolve_dependencies and register_dependencies
constructs script tags manually, rather than with htmltools
provides a dash_suite handler to serve dependency files, following the Dash convention
provides support for inserting the DashR app name into dependency pathnames
provides support for including a Cache-Control header, and setting the cache lifetime via components_cache_max_age
more careful CSS handling
treats dependencies bundled into DashR (i.e. dash_renderer, react, react-dom) as being part of the dash_renderer "package", to mirror behaviour in Dash for Python
some basic sanity checking for dependencies: removing multiple slashes in pathnames, ensuring that source maps aren't being served until user interacts with debugger, checking for duplicate dependencies

This PR is a work in progress, aiming to implement similar behaviour as found in _configs.py:
https://github.com/plotly/dash/blob/f590166be2ca476c8970512fd9b23aaf26541ae8/dash/_configs.py#L8
...and in dash.py:
https://github.com/plotly/dash/blob/1249ffbd051bfb5fdbe439612cbec7fa8fff5ab5/dash/dash.py#L488
Closes #52.

I think let's 🔪 DASH_URL_BASE_PATHNAME - We've only included it for backwards compatible reasons in dash.py. Instead, we can force users to be more explicit by setting both requests and routes prefixes

fixed in 5fba10f16601ebe26b15f3b96334105b7eafff31

I think let's 🔪 DASH_URL_BASE_PATHNAME - We've only included it for backwards compatible reasons in dash.py. Instead, we can force users to be more explicit by setting both requests and routes prefixes

fixed in 5fba10f16601ebe26b15f3b96334105b7eafff31

@chriddyp @alexcjohnson I've updated the list of proposed changes, and tried to structure the commits in a (slightly) more thoughtful way. I look forward to your comments and suggestions, hopefully we're inching the :football: a bit further towards the deployment goal line with this one.

Previously, we encountered an error: subscript out of bounds message in the R console when attempting to pass a NULL value to the callback handler.
This is possible when using a component like coreLocation, in which an ID may be supplied without a default value. The original code:
callback_args <- lapply(c(request$body$inputs, request$body$state), `[[`, 3)
...has been replaced with:
https://github.com/plotly/dashR/blob/7fa2581d41e8a33c8966490f51ef0ccf371edfd8/R/dash.R#L244-L260
The new code handles inputs which may contain NULL values, which we wish to retain. In R, assigning NULL into a list element removes the element from a list, while appending NULL inserts into an existing list.
https://cran.r-project.org/doc/FAQ/R-FAQ.html#Others:

I've tried to address the most recent round of PR comments, and I think I've licked the _dash-update-component error Nadia mentioned. If it's possible to review and consider :dancer: this one, I'm ready to tackle other issues 🙂
@chriddyp @alexcjohnson @NadiaTahiri @nicolaskruchten


Bring back the floating toolbars in taskbar

Summary of the new feature/enhancement
A long time ago and until Windows 7, people could create toolbars on the taskbar and then drag them off the taskbar, either leaving them floating on the desktop or attaching them on a different desktop edge – like the top, left or right. Those toolbars could even be set to auto-hide so they wouldn't waste space.
Users could have specific toolbars for shortcuts, for showing the drives (my personal favourite) in "My Computer" or the contents of any other directory. That was a really powerful and very useful feature.
I remember it got deprecated on Windows Vista, but if memory serves there was a little "trick" you could do to have it work. By Windows 7, it was gone.
Please bring it back!

Proposed technical implementation details (optional)
I don't have a proposal, but I'm sure the code allowing the toolbars to be detached from the taskbar and re-attached to other monitor edges is still in there, somewhere.

@skagon, can you go into more details in the scenarios you'd use this in.  Easier to talk about scenarios and why something is important.

The scenarios are literally endless and it's quite simple for me to write a few, since that feature is not theoretical but existed in older versions of Windows.
My favourite use was to have a toolbar docked at the top edge of the desktop, set to autohide, and set to show the contents of "My Computer", i.e. all the drives.
In fact, I've grown so used to having that functionality that, ever since Windows removed that functionality, I'm using a third-party application for that (called Winstep).
One other scenario was one that a friend of mine had, where he also had a toolbar set to the top edge, also set to autohide, but instead of the drives, he had created a "shortcuts" toolbar, where he had placed his most-used shortcuts for programs and folders.
Yet another friend (yes, I had shown that trick to everyone I knew) had two toolbars. One on the left edge, where he had shortcuts of the folders he used the most, while at the top he had two toolbars; one was again "My Computer" but since he only had two partitions and one CD-ROM drive, the rest of the space was set to a third toolbar showing shortcuts. All of them were set to autohide.
In fact, I think I've got a screenshot of that old desktop of mine somewhere. Let me see if I can find it.

Yeah, that's it.
I hope you can see how useful something like this is. Actually, the fact that there are other programs that are trying to replicate that functionality by providing "docks" on the desktop, for shortcuts or folders – or even applets but that's besides the point now – I think speaks for itself.
The biggest advantage to having a toolbar docked on a different edge of the screen is that you can have access to its contents without having to minimize or move windows out of the way, so you can get to the shortcuts on the desktop. You can have your desktop completely clean. You can have access to your drives without having to find the "My Computer" a.k.a. "This PC" icon, and it saves clicks, since all you have to do is to move the cursor to the appropriate edge and click on the drive, folder or shortcut you want, directly. Moreover, if you prefer having folders, these folders will automatically expand, so you can just move through the directory structure, subdirectories, and get to the file you want, without a single click. Well, ok, with just one click, at the file itself.
Moreover, you could also, theoretically, also have subdirectories of shortcuts, so you could categorize and group them to your preference, and only have the one toolbar showing the parent directory which contains them!
I can't think of other uses but I'm sure that people will think of more, like they did when that feature was a standard feature of the taskbar.

Thanks crutkas to show interest.
What additional information in particular you would like to what is already given?
From microsoft originally named 'deskbands'.
Probably the most who remember this function found a third-party software to replace their use case. But it´s third party, often with more than asked for.
A different short description:
Choose any folder, also possible "My Computer", let it float (like an window only with an X) or allow docking to border and auto-hide (as the taskbar can).
It will show the folders and files in the choosen folder, only as icon or with description. Similar what you can select for every Toolbar you create on the taskbar.
Some tunes from the past
https://superuser.com/questions/444427/how-can-i-create-a-separate-toolbar-from-the-task-bar
https://answers.microsoft.com/en-us/windows/forum/windows_7-desktop/can-i-separate-the-task-bar-and-tool-bar-that-are/4e0175be-05d9-4411-ab1c-973d8c755781
I read someone used the 'Quick Launch'- Folder to create a 'Pin to taskbar' alike prior to Windows Vista. Only possible through this feature without third-party.

Any update?


Contribution to use the Qt user interface markup language Qml in MITK:

added QmlMitkStdMultiItem, which replaces the QmlMitkFourRenderWindowWidget

different approach to register QmlMitkRenderWindowItems
resembles more the QmitkStdMultiWidget (e.g. storing planes...)
added the respective qml file: MitkStdMultiItem.qml

update QmlMitkRenderWindowItem

removed interaction legacy
updated interactions

update QVTKQuickItem paint method to vertically mirror the displaying texture
enabled glDepthMask (depth buffer writing) to accurately display 3D objects
added example implementations for dataManager and image properties
added an example application in the CTK plugin system (Qmlbench)

required minimum qt version Qt5.5
(based on Matt Tylors pull request: https://github.com/nocnokneo/MITK/tree/bug-18393-qml-rendering-improvements)

Please check
http://bugs.mitk.org/show_bug.cgi?id=19728
for the current state of integration

I have incoroporated the pull request and it works fine in debug mode. In release mode however it crashes when loading an image. Is this a problem you have encountered before?

I am currently working under the assumption that it is a race condition/multi-threading issue. The crash disappears if I add console output to a variety of core classes.

Closing old pull requests. Please leave a comment if you think that this pull request still really needs to be addressed , thank you.


Bumped minimum Sphinx version to 4.5.0.

Related Sphinx changes:

https://github.com/sphinx-doc/sphinx/pull/8898
https://github.com/sphinx-doc/sphinx/issues/8326

Related changes in the djangoproject.com:

https://github.com/django/djangoproject.com/pull/1169

Thanks :+1:


Having issues with Access Token

Hello,
I'm using this provider for the first time. I've setup with success the oauth on the site24x7 console. The following is my configuration on the terraform side:
terraform {
    required_providers {
        site24x7 = {
            source = "site24x7/site24x7"
            version = "1.0.17"
        }
    }
}

provider "site24x7" {
    data_center = "EU"
    retry_min_wait = 1
    retry_max_wait = 30
}

resource "site24x7_amazon_monitor" "aws_monitor_site24x7" {
  // (Required) Display name for the monitor
  display_name = "Test"
  // (Required) AWS access key
  aws_access_key = var.AWS_ACCESS_KEY_ID
  // (Required) AWS secret key
  aws_secret_key = var.AWS_SECRET_ACCESS_KEY
  // (Optional) AWS discover frequency
  aws_discovery_frequency = 5
  // (Optional) AWS services to discover. See https://www.site24x7.com/help/api/#aws_discover_services
  // for knowing service ID.
  aws_discover_services = ["3"]
}

I've set up the environment variables SITE24X7_OAUTH2_CLIENT_ID, SITE24X7_OAUTH2_CLIENT_SECRET and SITE24X7_OAUTH2_REFRESH_TOKEN. Although I'm having the following error on the terraform apply:
Error: POST https://www.site24x7.eu/api/monitors: giving up after 5 attempts due to: Post "https://www.site24x7.eu/api/monitors": oauth2: server response missing access_token.
I would like to ask help.
Thanks in advance,
TIago

Hello @jim-billy-zoho,
There is one thing different in my setup. I'm using our own IdP so it will probably not work with that approach. Any thoughts about it? Can it be that I'm missing something on the configuration?
Many thanks for your help on this.
Thanks,
Tiago


Mismatching className when using Material UI withStyles

See https://github.com/mui-org/material-ui/issues/10522
Sometimes the class names of material UI component are not matching during SSR (for buttons, inputs etc.), needs investigation.

Hi Eric,
Oh, if could recoup the days and sweat and tears I have spent on trying to resolve this issue!!! LOL
I eventually gave up, and now wrap my whole app in  - not ideal. I think the solution is in how SSR is rendered and how it's hydrated on the client - something that I am completely unfamiliar with.

Yeah I'll take a look asap I just wanted to document this. The code is fairly short but dense so hard to debug, for the moment the first step is to have a minimal repro. I can also happen when HOCs are not used correctly.

Should be fixed when https://github.com/VulcanJS/Vulcan/pull/2352 is merged


Can't install ccls server

Describe the bug
Can't install ccls server
Expected behavior
Command line execution ":LspInstall ccls"
Screenshots

System info (please complete the following information):

OS: Ubuntu 20.10
Neovim version: NVIM v0.6.0

Checkhealth output (:checkhealth nvim-lsp-installer):

Paste `:checkhealth nvim-lsp-installer` output here

nvim-lsp-installer: require("nvim-lsp-installer.health").check()
========================================================================
## nvim-lsp-installer report
  - ERROR: **Composer**: not available
  - ERROR: **java**: not available
  - ERROR: **sh**: not available
  - INFO: **tar**: `tar (GNU tar) 1.34`
  - INFO: **gzip**: `gzip 1.10`
  - INFO: **wget**: `GNU Wget 1.21 built on linux-gnu.`
  - INFO: **python3**: `Python 3.8.8`
  - INFO: **PHP**: `PHP 7.4.16 (cli) (built: Oct 26 2021 16:46:20) ( NTS )`
  - INFO: **Ruby**: `ruby 2.7.2p137 (2020-10-01 revision 5445e04352) [x86_64-linux-gnu]`
  - INFO: **Go**: `go version go1.17.5 linux/amd64`
  - INFO: **bash**: `GNU bash, version 5.1.4(1)-release (x86_64-pc-linux-gnu)`
  - INFO: **curl**: `curl 7.71.1 (x86_64-conda_cos6-linux-gnu) libcurl/7.71.1 OpenSSL/1.1.1k zlib/1.2.11 libssh2/1.9.0`
  - INFO: **RubyGem**: `3.2.5`
  - INFO: **pip3**: `pip 21.0.1 from /home/phanlong2811/anaconda3/lib/python3.8/site-packages/pip (python 3.8)`
  - INFO: **node**: `v14.18.2`
  - INFO: **npm**: `6.14.15`

Please also include any other system information you think is relevant!
Install log
If applicable, include nvim-lsp-installer's logs. See :help nvim-lsp-installer-debugging for instructions on how to set the log level and access the logs.
Paste your logs here

    Submodule path 'third_party/rapidjson/thirdparty/gtest': checked out '0a439623f75c029912728d80cb7f1b8b48739ca4'
    -- The CXX compiler identification is GNU 10.3.0
    -- The C compiler identification is GNU 10.3.0
    -- Detecting CXX compiler ABI info
    -- Detecting CXX compiler ABI info - done
    -- Check for working CXX compiler: /usr/bin/c++ - skipped
    -- Detecting CXX compile features
    -- Detecting CXX compile features - done
    -- Detecting C compiler ABI info
    -- Detecting C compiler ABI info - done
    -- Check for working C compiler: /usr/bin/cc - skipped
    -- Detecting C compile features
    -- Detecting C compile features - done
    -- Found ZLIB: /usr/lib/x86_64-linux-gnu/libz.so (found version "1.2.11")
    -- Could NOT find LibXml2 (missing: LIBXML2_LIBRARY LIBXML2_INCLUDE_DIR)
    -- Looking for pthread.h
    -- Looking for pthread.h - found
    -- Performing Test CMAKE_HAVE_LIBC_PTHREAD
    -- Performing Test CMAKE_HAVE_LIBC_PTHREAD - Failed
    -- Check if compiler accepts -pthread
    -- Check if compiler accepts -pthread - yes
    -- Found Threads: TRUE
    -- RapidJSON found. Headers: /usr/include
    -- Configuring done
    fatal: No names found, cannot describe anything.
     I've pushed to branch fix-ccls - could you give it a try?

This is probably because we're not always downloading the correct llvm distribution (on Linux). I've pushed to branch fix-ccls - could you give it a try?
This is the result when I tried

Can you try the latest version of that branch? Should probably work now

Can you try the latest version of that branch? Should probably work now
Not working

Ah I didn't consider versions above 20.04 - could you try once more 🙏?

Ah I didn't consider versions above 20.04 - could you try once more pray?

the installation is successful but it gives error

Just create a .ccls file in the same directory.
see: :h lspconfig-root-detection
https://github.com/neovim/nvim-lspconfig/blob/0f72e5468e510429d5f14b73c93fb528ead1fdaa/lua/lspconfig/server_configurations/ccls.lua#L7

Thanks everyone, it worked <3


EBUCore: output of different versions not documented

While trying different output options, I've remembered that it was possible to output EBUCore in different versions. It still is, but I couldn't find it in the help/manpages.
Shall I add this information to help/manpages?
I've figured out the syntax: Adding "_x.y" selects the version in the output:
$ mediainfo --output=EBUCore_1.3 input.mov

Seems the following versions are supported (brute-force tried):

1.5
1.6
1.8

Even more complex :).
Quick and dirty extraction

"EBUCore_1.5"
"EBUCore_1.6"
"EBUCore_1.8"
"EBUCore_1.8_parameterSegment" or "EBUCore_1.8_ps" (order in XML is parameter then segment)
"EBUCore_1.8_segmentParameter" or "EBUCore_1.8_sp" (order in XML is segment then parameter)
"EBUCore_1.5_JSON"
"EBUCore_1.6_JSON"
"EBUCore_1.8_JSON"
"EBUCore_1.8_parameterSegment_JSON" or "EBUCore_1.8_ps_JSON"
"EBUCore_1.8_segmentParameter_JSON" or "EBUCore_1.8_sp_JSON"
"EBUCore"
"EBUCore_JSON"
"FIMS_1.1"
"FIMS_1.2"
"FIMS_1.3"
"FIMS"
"MPEG-7"
"PBCore_1" or "PBCore1"
"PBCore_1.2"
"PBCore_2" or "PBCore2"
"PBCore_2.0"
"PBCore_2.1"
"PBCore"
"NISO_Z39.87"
"HTML"
"OLDXML"
"XML" or "MIXML"
"MAXML"
"JSON"
"CSV"

Help is definitely not up to date and we don't have the time to focus on it, but if you are interested in updating it we'll take the patch :).

Note: our long term idea is to have an option for listing the output formats + a description, so help part would be shorter (saying that this option exists) and the list would be in only one place, but not yet implemented.

Thanks for the quick parse!
I've renamed the issue, because it's not just EBUcore anymore.
I know this has no priority, but I'm currently going through Mediainfo output options for a workshop I'm preparing, so I could as well improve the docs to make my students (and future users) happy :smiley:


Adding an item to an empty list causes an error

System Health details
N/A
Checklist

[X] I have enabled debug logging for my installation.
[X] I have filled out the issue template to the best of my ability.
[X] This issue only contains 1 issue (if you have multiple issues, open one issue for each issue).
[X] This issue is not a duplicate issue of any previous issues..

Describe the issue
Adding an item to an empty list causes an error
Reproduction steps
Add an item to an empty list
Debug logs
Traceback (most recent call last):
  File "/usr/src/homeassistant/homeassistant/components/websocket_api/commands.py", line 241, in handle_call_service
    response = await hass.services.async_call(
               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/src/homeassistant/homeassistant/core.py", line 2741, in async_call
    response_data = await coro
                    ^^^^^^^^^^
  File "/usr/src/homeassistant/homeassistant/core.py", line 2784, in _execute_service
    return await target(service_call)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/src/homeassistant/homeassistant/helpers/service.py", line 977, in entity_service_call
    single_response = await _handle_entity_call(
                      ^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/src/homeassistant/homeassistant/helpers/service.py", line 1049, in _handle_entity_call
    result = await task
             ^^^^^^^^^^
  File "/usr/src/homeassistant/homeassistant/components/todo/__init__.py", line 463, in _async_add_todo_item
    await entity.async_create_todo_item(
  File "/config/custom_components/mealie/todo.py", line 128, in async_create_todo_item
    self.coordinator.shopping_list_items[self._shopping_list_id][-1].get(
    ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^^^^
IndexError: list index out of range

Diagnostics dump
No response

Fixed in 1.1.3


How to pass file descriptors between processes with it ?

I tried to send the file descriptor using Bootstrapper.send() method but it doesn't work. Bootstrapper.send() method seems to transmit the file descriptor as an ordinary integer, without conversion by the operating system kernel. Similar to the functionality of this crate: https://github.com/polachok/passfd.
There is another question I wonder:
Why is the Bootstrapper#sender wrapped in RefCell instead of Arc, so that Bootstrapper cannot be used in asynchronous traits.
Looking forward to your reply!

The send method uses serialization. If you wrap the fd / object that converts into an fd in HandleRef or Handle you can pass it conveniently this way.
With regards to the bootstapper sender I am not sure right now what the usecase is and what stands against implementing it. In general a RefCell is not replaceable with an Arc, a Mutex might be but comes at an increased cost. If the bootsrapper is an issue, please open a separate issue for it.


Would it be possible to enable multiple points in slices from slices_over?

I was wondering whether it would be possible to enable something like for slice in cube.slices_over(coord, 10): such that slice is a cube containing 10 points from coord?

@ehogan Why don't you just constrain the cube beforehand to contain those 10 points that you want, and then slice over it?
That would be my recommendation.

Ah, I didn't think about that! If I constrain the cube beforehand then I don't need to slice over it :) Thank you!

:+1: Glad to help!


Add Jenkinsfile for preview deployments

Adds a Jenkinsfile so that we can enable preview builds through the EF CI train.

Thank you for this, @autumnfound! We appreciate the support.


Can you pass style parameters to the map?

Interested in styling the google map, using parameters generated by something like this http://gmaps-samples-v3.googlecode.com/svn/trunk/styledmaps/wizard/index.html?utm_medium=twitter

This? https://github.com/istarkov/google-map-react-examples/blob/master/web/flux/components/examples/x_options/options_map_page.jsx#L10

@istarkov Awesome, completely missed that one! I appreciate the quick turn around. :tada:

:-)


Not able to run without setting up and after setting up LaunchDarkely SDK Key

Describe the bug
I had setup this project from scratch and it asked me for launchdarkely , which i went ahead and created one. But I am again and again getting the below error for flags. How can I import and use all the flags that were present earlier for this project.

To Reproduce
Steps to reproduce the behavior:

Go to '...'
Click on '....'
Scroll down to '....'
See error

Expected behavior
A clear and concise description of what you expected to happen.
Screenshots
If applicable, add screenshots to help explain your problem.
Desktop (please complete the following information):

OS: [e.g. iOS]
Browser [e.g. chrome, safari]
Version [e.g. 22]

Smartphone (please complete the following information):

Device: [e.g. iPhone6]
OS: [e.g. iOS8.1]
Browser [e.g. stock browser, safari]
Version [e.g. 22]

Additional context
Add any other context about the problem here.

@VERZUOL1 @karpovdmitry @edwardkcyu Please tell me how to resolve this , I have been stuck here from weeks.


feat: support for borsh @ 1.5

Motivation
Avoid having to implement a new type to handle BorshSerialize and BorshDeserialize for ruint types.
Solution
This PR implements BorshSerialize and BorshDeserialize for Uint and Bits with basic tests.
PR Checklist

[x] Added Tests
[x] Added Documentation
[x] Updated the changelog

This seems reasonable to me. I am not an expert in borsh, so while I've tried to review the logic I am not 100% sure it's correct. Can you leave a 1-2 paragraph comment here about relevant particulars of borsh serialization in case I need to maintain this code in the future :)

Of course! Borsh serializes integers in little-endian format. For Uint deserialization, I think iterating forward over the limbs and serializing each limb as little-endian (via BorshDeserialize::deserialize_reader) does the trick. Do you mind double-checking me?
For example, the test value uses limbs [1, 2, 3, 4], which should be:
// Human readable:<PHONE_NUMBER>1546723056364004793593481054836439088298861789185
1 // 0..8
+ (2 << 64) // 8..16
+ (3 << 128) // 16..24
+ (4 << 192) // 24..32

I also just added lines in the test that call to_le_bytes() to sanity check.
Let me know if I misunderstood how the limbs are put together and I can fix it. Thank you.
For reference: https://borsh.io/ (see Integers section of Specialization).

thank you. does borsh serialize fixed-sized integers as fixed-length bitstrings? i.e. is a u64 always exactly 8 bytes?
My concern with the current implementation is that non-standard sized Uint would currently be serialized at sizes other than their bit size rounded to the nearest byte. E.g. a 7 byte integer like Uint<56, 1> would be serialized as 8 bytes. Is this reasonable for Borsh, or should we use try to encode the minimal number of bytes?

You're right. This was an oversight on my part and tried to be clever with iterating over the limbs.
Maybe I should just do to_le_bytes and serialize that. I'll need to look into how to_le_bytes works under the hood for Uint to make sure this is kosher.

I couldn't find a better way than to use a macro to implement BITS to BYTES relationship. Maybe at some point in the future when we can use Self::BYTES this can be generalized.

thanks, let me spend some time on this early next week and i'll see if i can figure out an elegant solution :)

Would you mind checking out my branch here?  If you think the implementation is correct, I can push it onto this branch and get this merged soon :)


Add double quotes to return tag

Fix issue with git checkout when tag contains special characters

What are problematic tags that this PR is supposed to solve?

@BanzaiMan https://github.com/travis-ci/bugs-questions-comments-ideas/issues/129

Ah, I see. Could you add a spec for that problematic value, then? I tend to think, though, that we want to shell escape the tags properly rather than quoting with %Q{""}. We need to test it, to be sure.

@BanzaiMan I updated to shellescape, please check
@cotsog i am not sure about def tag we will have double if
Here is the build:
https://staging.travis-ci.org/DamianSzymanski/ddd/builds/739212#L180

@BanzaiMan makes sense, please check
@cotsog Thanks


Automatic tests fail on the currently checked in master version

Does it only fail on OSX?
On Ubuntu 16.04 the tests pass.

Good question. I get an assertion failure when doing "make test", on one of the tests. Will solve in a bit.

(Could also be unrelated to rtloss. Will know in a bit)

Wasn't related to rtloss, maybe related to better assertions, not quite sure why this wasn't seen before. But in any case, now it is corrected.

Solved in commit 2a74540


regression with recent jlab

for a couple days/weeks now, I have noticed a regression in jlab sessions that use this extension
the symptoms are

cells take needlessly large height
scrolling up and down triggers odd behaviours, like

space between cells increases even further
cells move from one row to the next
scrolling gets stuck

and this even with notebooks that do not have gridwidth tags at all
I need to

[ ] investigate and confirm my gut feeling that a recent jlab is causing the issue
[ ] bisect to find the actual version that breaks
[ ] find a way to fix the problem

because at first sight what is happening it it rather mysterious
broken jupyter --version
Selected Jupyter core packages...
IPython          : 8.25.0
ipykernel        : 6.29.4
ipywidgets       : 8.1.3
jupyter_client   : 8.6.2
jupyter_core     : 5.7.2
jupyter_server   : 2.14.1
jupyterlab       : 4.2.1
nbclient         : 0.10.0
nbconvert        : 7.16.4
nbformat         : 5.10.4
notebook         : 7.2.0
qtconsole        : 5.5.2
traitlets        : 5.14.3

when forcing pip install jupyterlab<4.1 I get the expected behaviour, i.e. this, on the first example notebooks in this repo

here's the behaviour obtained on the same notebook with jupyterlab 4.2.1
the whole time we're only scrolling down with the mouse

Can you go to Notebook settings and change the windowing mode to none from full (default since 4.2) and see what happens? Similarly, on 4.1 if you change to full can you reproduce this? I would suggest reloading JupyterLab after changing this setting.

with 4.2.1, if I go to 'none' windowing mode, the issue vanishes
what's the deal with the windowing mode ?

and conversely under 4.1.8, moving to 'full` windowing mode triggers the issue

and conversely under 4.1.8, moving to 'full` windowing mode triggers the issue

is there a way for an extension to act on these settings ?

Yes, jupyterlab-execute-time does so, but it has a setting specific to its use case. Some users may find it annoying if you switch the windowing off but as a short-term solution until you can figure out how to support windowed mode it sounds reasonable to me (provided it is well documented).

thanks @krassowski; about this:

until you can figure out how to support windowed mode
I wouldn't know where to start, where is this 'windowing' thing documented ?

I wouldn't know where to start, where is this 'windowing' thing documented ?

https://jupyterlab.readthedocs.io/en/stable/developer/performance.html#windowed-list
https://jupyterlab.readthedocs.io/en/stable/api/modules/ui_components.WindowedList.html
https://jupyterlab.readthedocs.io/en/stable/api/classes/notebook.NotebookWindowedLayout.html
https://jupyterlab.readthedocs.io/en/stable/api/classes/notebook.NotebookViewModel.html

thanks for the pointers
in the meanwhile I'm tempted by the short-term approach (because otherwise the disease will slowly spread to all my students as they upgrade their envs, leading to a mess..)
it feels however that it's not just a matter of changing the windowingMode setting directly - because understandbly my extension won't be allowed to modify the notebook's extension settings, iiuc from reading this
https://discourse.jupyter.org/t/how-do-i-override-settings-using-my-extensions-schemadir-file/8599/2
now, how can I achieve this as an externion developer ?
as opposed to an operator, which the above post only addresses - iiuc again
thanks !

Does this help?
https://github.com/deshaw/jupyterlab-execute-time/blob/c020582313868db92f1b0bdbae71aeb305b29fc1/src/index.ts#L54-L66

yes thanks, I believe this should get me started
just a question though
do I understand correctly that in the linked code, 'enabled' is a setting local to the execute-time extension, and it is not related to the generic 'enabled/disabled' status of an extension, is that right ?
I would have thought that the activate method of the plugin would not even be triggered if the extension is disabled, no ? (in which case a test against 'enabled' would always return true...)


Elixir & Phoenix Tutorial: Build an Authenticated App

Apologies, #1068 was closed (irretrievably) in error and this PR rescues that work.

Hi Luke!
Our SEO expert has reviewed this article and had the following feedback:
Can we try to use often “elixir language” instead of just “elixir” and “phoenix framework” instead of just “phoenix”? I would leave the title as it is.
Can you please make these updates? Thanks!


gitzen.branches: whitespace cleanup

Stack:

#62
#61
#60
#59 ⬅
#58
#57
#56

⚠ Part of a stack created by spr. Do not merge manually using the UI - doing so may have unexpected results.


表格分组时，内部的表头单元格也有圆角

[ ] I'm sure this does not appear in the issue list of the repository

Basic Info

Package Name And Version<EMAIL_ADDRESS>Browser: chrome101.0.4951.41
Reproduction Link: https://arco.design/react/components/table#表头分组

What is expected?
内部的表头单元格不要有圆角


Set default value for entityList variable

Reviewer: @jdorweiler
Description:
If the entityList endpoint is unresponsive when the extension is loaded, the entityList variable remains undefined. The isTracker function later attempts to check request entities against an undefined variable, which throws errors and breaks the extension. This just instantiates entityList as an empty object, which fixes this.
Steps to test this PR:

Change the entityList endpoint in constants.js to a url that doesn't respond.
Compile and load extension in browser.
Visit a site with trackers. Check popup to see that trackers were found. Check extension console to see that no errors are thrown.

👍


Atom freezes when editing a line with a slash and then 2 double quotes after it.

Atom freezes when editing a line with a slash and then 2 double quotes after it.
Reproduction:
1. disable all third-party packages in atom except autocomplete-bash-builtins.
2. open a new file insert "#! /bin/bash" on first line and save file.
3. type '/asdfjklasdfjklasdfjklasdfjkl" " '  (slash, about 30 random letters, double quote, double quote) on line 2 without single quotes.
4. insert a space or letter between between the double quotes.
This doesn't happen in safe mode.
Expected behavior:

Atom doesn't freeze, further editing is seamless. Atom behaves normally.

Actual behavior:

Atom freezes and if you wait long enough, atom will resume.
Comment out line 2 with # and the behavior no longer happens until uncommented
The longer the line in between the slash and the quotes, the longer the freeze will be.
The slash does not have to be the first character on the line

Software versions:

Atom:       1.14.2
Electron: 1.3.13
OS:         linux 4.8.0-39-generic
Misc

apm  1.15.3
npm  3.10.5
node 4.4.5 x64
python 2.7.12+
git 2.9.3

If you can't reproduce the error, just let me know!
EDIT: Altered title and first line of issue to be more discriptive.

Hi @joshwiker14 ! Thank you for reporting this bug. Yes, I can reproduce it on my laptop by following your steps. Gonna fix it!  : )

Thank you so much! I can confirm that the fix solves the issue for me!

@joshwiker14  No problem! Thank you!  : )


You can find a working version of the Advanced End project here

https://github.com/matale/android_paging_advanced_working_end
I have fixed the Advanced end project here so it builds and runs, I haven't worked on any of the other projects so you must import the end project.
I am on AS Electric Eel if that matters.

" FATAL EXCEPTION: main
Process: com.example.android.codelabs.paging, PID: 14380
java.lang.RuntimeException: Unable to start activity ComponentInfo{com.example.android.codelabs.paging/com.example.android.codelabs.paging.ui.SearchRepositoriesActivity}: java.lang.RuntimeException: Cannot find implementation for com.example.android.codelabs.paging.db.RepoDatabase. RepoDatabase_Impl does not exist"


Major update of readme.md

Major update of readme. Idea is to use this for the main organization read me too.

This looks great thanks for bringing these bits together, especially like the expandable bits, didn't realise you could have those in READMEs.
A few thoughts:

Does the how to get involved bit need to be collapsed? Could have it expanded and I still think the page may not be too long?
In that ways to get involved I don't think we make it super clear we also have models on hugging face that people could try to use if they are able to the required input data
Should we add a little paragraph for the section Overview of OCF's nowcasting repositories to explain that the can expand the bits to see the different domains within OCF and also a guide of which are easier to contribute to? Also should we just call that section "Overview of OCF's repositories" and drop the "nowcasting" bit?
I know that our open source Quartz repo can be pinned in our landing github page README which is great so maybe this solves this but it feels that repo gets a bit lost/not highlighted high enough in our repo list in the repo metadata tables

Just thoughts so feel free to disagree! Thanks again

Thanks @sukh for these, these are very useful. See below for things to do to address these
Good idea

[ ] remove nowcasting from repos
[ ] Add a sentence to say expand the sections below
[ ] remove first drop down, to expand how to get involved
[ ] Add sentence about HF models
[ ] Add section of Open Source tools ready to use, like Open-Quartz-Solar-Forecast, elexonpy, nwp-consumer, ...


#4 Add workflow to test multiple os

Additional workflow to test compatibility with multiple operating systems

Codecov Report

Merging #30 into master will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##            master       #30   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files            8         8
  Lines           33        33
=========================================
  Hits            33        33

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9c2159c...e150127. Read the comment docs.


Missing Cargo.lock in the repository / release tarballs

Please include Cargo.lock in the repository and keep it up-to-date when releasing new versions. It’s important for (linux) distributions to ensure reproducible builds.

I'm not sure cargo-make is packaged by any linux dist. could be wrong.

You are wrong… https://repology.org/project/cargo-make/versions. ;) And I’m currently packaging it for Alpine Linux.

oh wow. nice. any chance you can also do some PR to update the docs and put some installation instructions using package managers for relevant dists?

this is now officially released


Branch one

@srikanth458 Please sign the Contributor License Agreement!
Click here to manually synchronize the status of this Pull Request.
See the FAQ for frequently asked questions.

Spam request. I get the feeling people are using the PetClnic as some toy project to learn spring and github!


Fixed #27158 -- Fixed positioning of admin's many-to-many widgets in rtl.css

https://code.djangoproject.com/ticket/27158

It looks okay. My branch is based on stable/1.10.x but I've sent pulled request to master branch.

The pull request isn't to master. See how it says, "wants to merge 1 commit into django:stable/1.10.x"? Anyway, if you can fix the comment about div.help, this should cherry-pick to master just fine.

I've fixed it in a new commit.

Doesn't it need to be: form .aligned p.help, form .aligned div.help?

I've added it in a new you commit to make it more specific as you say.

merged in 13a8e633c273530ebd8d93490a7341a8aabb7346, thanks!


implementation of scripts as on PatchTST and will it work on kaggle GPU P100 ?

Hello, Dear developers
Will dataloader, scripts, etc. be added to this repository as implemented in the PatchTST ?
Do you think your model will work on Kaggle GPU P100 ?
Thanks for your work!

We plan to release the research code which includes these in the near future.

Hi Anton,
Thanks for your interest in MOMENT!
We designed this codebase to be extremely lightweight. In the process, we removed a lot of code to handle different datasets, dataloaders, training, and evaluation scripts.
We are working on releasing a bulkier research code, which will include all of that! Until then, I would point you to the early version of our research code on Anonymous Github.
Unfortunately, I haven't worked with Kaggle GPU P100's. MOMENT weights are loaded in bfloat16, which requires NVIDIA Ampere GPUs. More information about the training and experimental infrastructure can be found in our paper!
Please let us know if it doesn't! Again, thanks for your interest in MOMENT!


Create student.txt

Main URL: itda.ac.id
Course URL: ftk.itda.ac.id
Student URL: mahasiswa.itda.ac.id
P.s. Student URL uses "mahasiswa" in place of student as it is Indonesian for "student". However, the institutional/student email doesn't reflect that, instead, it uses the English word.

@T0kuiten First stage of verification passed, official domain for Institut Teknologi Dirgantara Adisutjipto is student.itda.ac.id as far as I verified. This is just an informational note. Pull request is still in the review. I appreciate your patience while waiting for the final decision.


Adding pt_BR profanity words

This PR aims to add profanity words of the pt_BR.

Hey @devajmeireles 👋
Thanks so much for the contribution! I love that Profanify is getting all this extra language support!
I'll get this PR merged and then tag a new release.


[cmake] Add cmake option to enable UBSan

UBSan features checks not performed by ASan. Both UBSan and ASan can be
enabled simultaneously.
Issue: https://github.com/iree-org/iree/issues/9922

Nice! It would be good to enable this as part of the same build as asan in our CI also. You could do that in this PR, actually.

I'd prefer to keep things separate so that the CI change is easier to roll back without breaking local builds. After all, ubsan complains a lot in my local build at the moment 😉

Relevant script is currently https://github.com/iree-org/iree/blob/main/build_tools/kokoro/gcp_ubuntu/cmake/linux/x86-swiftshader-asan/build.sh though it will hopefully be soon moved to GitHub actions. Do you have a suggested name for a combined asan/ubsan build? Can't just be "sanitizers" because we've also got tsan...

How about we just stick with -asan and add appropriate comments in the script? It's not the name has to fully describe what the build does. WDYT?

V1: Rebased.

Sure, those are both fine with me. Wasn't sure if there was some better way to say "asan and ubsan" but :shrug:

Sure, those are both fine with me. Wasn't sure if there was some better way to say "asan and ubsan" but 🤷

FYI, in my previous project we had one uber script that decided the CMake configuration based on a list of 'features' to enable: https://github.com/GPUOpen-Drivers/llpc/blob/dc2dddef9f77a4d665a59b2569836589803d2537/docker/amdvlk.Dockerfile#L90. So we passed something like "+asan+ubsan" to enable both.


fix explorer import silently ignored when invalid file name

This finishes a TODO to handle allowing the user to rename a file with an invalid file name when import files from the file system.
Fixes: https://github.com/pybricks/support/issues/717

Codecov Report

Merging #1103 (447e346) into master (5eaaa5d) will increase coverage by 0.25%.
The diff coverage is 93.61%.

@@            Coverage Diff             @@
##           master    #1103      +/-   ##
==========================================
+ Coverage   74.63%   74.89%   +0.25%
==========================================
  Files         168      172       +4
  Lines        3955     3999      +44
  Branches      783      792       +9
==========================================
+ Hits         2952     2995      +43
- Misses        993      994       +1
  Partials       10       10

Impacted Files
Coverage Δ

src/explorer/Explorer.tsx
98.90% <ø> (ø)

src/explorer/renameImportDialog/reducers.ts
83.33% <83.33%> (ø)

src/explorer/sagas.ts
96.66% <85.71%> (+0.77%)
:arrow_up:

...explorer/renameImportDialog/RenameImportDialog.tsx
100.00% <100.00%> (ø)

src/explorer/renameImportDialog/actions.ts
100.00% <100.00%> (ø)

src/explorer/renameImportDialog/i18n.ts
100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


ModuleNotFoundError: No module named 'mvtec'

what's package or anything others did I need to install

I'm not entirely sure, but I think it refers to the following: https://github.com/taikiinoue45/mvtec-utils


refactor: make ldp_vc logic reusable

This PR is a refactor of LDP VC handling within ICv2 and PPv2 to make it usable outside of those protocol's handlers. I believe this results in a cleaner implementation, separating the concerns of preparing a credential from the ICv2 protocol and its messages and handlers for those messages.
This refactor enables the other major addition in this PR, adding a couple of new endpoints for LDP VC issue and verify, POST /vc/ldp/issue and POST /vc/ldp/verify. These endpoints are similar to the /jsonld/sign and /jsonld/verify endpoints. However, the big difference is that the /jsonld endpoints did not use the same LDP signing methods used in ICv2 or PPv2. This has caused the two implementations to diverge more and more over time. With this PR, these endpoints are still available but are marked as deprecated. One other significant difference, the inputs for endpoints have changed to be more specific to signing and verifying LDP VCs and not just arbitrary JSON-LD documents.
Fixes #2468.

Some additional testing and fixes pending for this PR. I wanted to open this to see if there were any thoughts on this question:
Should I also move the holder related functions of storing LDP VCs to this interface?

Assuming that we will soon be supporting signing and verifying AnonCreds in W3C format proofs, is there anything else that needs to be done in preparation for that?  Will we be able to use the same interface to sign such credentials?  And ideally, sign a VC twice — once with AnonCreds, once with another key type?  AFAIK, the AnonCreds signature will be aligned with Linked Data Proofs.
Another thought. I believe the “LDP” term has been replaced with Data Integrity Proof…
I’ll edit this message — have to run right now...

Good questions. I really enjoy how nice and simple everything is when it comes to VC formats :smile:
Based on my understanding, AnonCreds in W3C format would be formatted as JSON-LD but would not be using Linked Data Proof signatures since they will of course use CL Signatures. So it would technically not fall in the category of ldp_vc. And to your point on Data Integrity Proofs replacing Linked Data Proofs, I believe you're correct. Based on casual observation, it seems the term ldp_vc will be sticking around for a while at least, given that the format is included in the OpenID4VCI spec as "VC secured using Data Integrity, using JSON-LD, with proof suite requiring Linked Data canonicalization" (which is hilariously verbose). That section clarifies:

Note that Data Integrity used to be called Linked Data Proofs, hence "ldp" in the Credential format identifier

I haven't looked deeply at Data Integrity Proofs but I believe there would be changes required at layers lower than the ones I've touched in this PR. Superficially, it seems the biggest change would be how the signature is represented.
I think the interface I've added here would be beneficial to later adding DIP support, switching behavior by processing the proof_type option. Perhaps that means the manager itself should be renamed :thinking:
I don't think this extends to supporting AnonCreds in W3C format, though. AnonCreds would need a different set of options, at a minimum, which I think makes it not fit particularly well into this interface. I could be persuaded otherwise.

Oh, I just read more of https://w3c.github.io/vc-data-integrity/; it seems that AnonCreds would actually be able to be considered a generic Data Integrity Proof so I think I'm wrong about what I just said.

Looks like a nice clean-up to me!

Brief update: I'm working through the test failures and moving tests that used to apply to the ICv2 and PPv2 format handlers for ld_proof and  dif respectively to tests for the added manager!

This is now ready for review! @swcurran I think this is a good change for JSON-LD creds but there's probably a conversation worth having about how this should interact with the DataIntegrityProofs in the future. This is a good stepping stone in that direction; it will be easier to make that switch when it's time.

@PatStLouis — this might be relevant to the work you are doing — being able to use the JSON-LD credentials independent of DIDComm protocols.  I think you mentioned that yesterday?  Please let me know. Your review of this PR would also be welcome!  :-)

@swcurran thank you for pointing this out to me. @dbluhm I will have a thorough look tomorrow but this seems like a great functionality to have. I'd like to have a discussion with you around the differences you highlighted between these new endpoints and the json-ld endpoints. I understand this will replace the existing json-ld endpoints?
2 comments/question I have

Have you considered using the endpoints /credentials/issue and /credentials/verify to align with the vc-api credential management spec? This would enable aca-py to be interoperable with w3c test-suites out of the box. They also have different endpoints for presentations, /presentations/sign and /presentations/verify which could be interesting to consider. I'm currently writing a PR on the vc-api spec around how error messages should be returned, I'd like to know your approach on this as well! I will base this on the VC data model spec problem details section.
https://w3c-ccg.github.io/vc-api/#issue-credential
https://pr-preview.s3.amazonaws.com/w3c/vc-data-model/pull/1338.html#problem-details

What are your thought's on credential storage? Currently the only way to store a json-ld credential is through the issue-credential v2 protocol. There is however some logic to query those credentials through the /credentials/w3c endpoint. Do you see adding another mechanism to store an already issued credential?

And you are correct, CL signatures are considered data integrity proofs. However, AnonCreds VC type will be difficult to be issued with an endpoint like this because the process for the credential request requires a back and forth between the issuer and the holder. There would need to be some reflections about how to provide the request to this endpoint and how it will look. Super interested in helping with this however.

Pulling in @wip-abramson since we recently had discussions around this for a project we are working on

Hey @PatStLouis, thanks for your interest! I'm not necessarily opposed to implementing the VC-API; the interface is inspired by the VC-API, as was the LD-Proof-VC-Detail attachment format that this work kind of inherits from. There are subtle differences right now and it's been a minute since I did the bulk of this work. I'll take some time to compare and see if there's a clear reason for the differences.

Have a look here if you want an easy to run test-suite that would interact the same way. Just plug in the endpoints and see what happens: https://github.com/credential-handler/verifiable-credential-playground-test-suite

I agree with @PatStLouis.
I think we need an endpoint to store an issued JSON-LD VC. Or is it imagined that applications would handle storage of credentials themselves?
I also think supporting AnonCreds issuance in this way will be hard. AnonCreds issuance requires interaction between issuer and holder passing cryptographic information that needs to be used in protocols other that json-ld sign. To implement this outside of DIDComm, I think we would need API calls to represent each of these interactions (leaving the communication out of band - potentially CHAPI or something else).
Really, AnonCreds jsonld issuance isn't JSON-LD sign at all (I don't think). Isn't it just JSONLD pack? Or W3C VC pack? Some transformation that takes a signed AnonCred and represents it in W3C VC format.

@wip-abramson You had some interesting points relating to didauth and credential storage, would you mind sharing these as well? This should be documented and discussed (its out of scope for this PR however discussing it doesn't hurt)

I'm not sure what I said more about credential storage.
But DIDAuth, is generally recommended when issuing a credential to a DID. First the issuer must request a DIDAuth from the holder for the DID they wish to include in the credential. See https://chapi.io/developers/wallets/#did-authentication-with-chapi
I actually think this would be possible with the endpoints proposed here. You would just JSONLD sign something like this:
const didAuthPresentation = {
    '@context': [
        'https://www.w3.org/2018/credentials/v1',
        'https://w3id.org/security/suites/ed25519-2020/v1'
    ],
    type: ['VerifiablePresentation'],
    holder: 'did:key:z6MkeprvBw4RFHJPQEmtioq4xRrN6Tk8EBSJ37eBCBQNHRjZ',
};

Bold of you to post javascript snippets in an aca-py thread. Thanks for the input!

@swcurran testing now

This looks great and works really well. I would have 2 comments:
Would it make sense to make the proofType optional? AFAIK in acapy the key type is selected upon wallet creation, so by providing a did:key wouldn't it be already bound to a specific proof type? If I'm wrong please enlighten me!
The created timestamp could be formatted to use the 'Z' alternative to specify UTC. Also according to the XMLSCHEMA11-2 date-time specification the milliseconds should be omitted.
2023-12-07T17:58:51.962131+00:00 -> 2023-12-07T17:58:51Z
Question, when you verify a vp, do you also verify the vc signature it holds?
I like the included details upon verification, great context and useful.
Overall I like this alot in comparison to the json-ld endpoints

@dbluhm — let me know how you want to handle @PatStLouis ’s comments — include or merge as is.
Thanks @PatStLouis — good stuff!

@dbluhm you should come present this at the vc-api meeting next week, I know a few people who will be thrilled to see this alignment :)

@PatStLouis Was it the proof created at timestamp specifically that you were referring to?

Sounds good, I was able to sign most of the credentials from this list
Thumbs up from me!


Remove unnecessary @azure/core-http deps

Trying to pay down some debt by removing places we depend on @azure/core-http where I think we don't actually need to.
Used this for discovery: https://cs.github.com/Azure/azure-sdk-for-js?q=%40azure%2Fcore-http"+language%3AJSON
@HarshaNalluru can you confirm that the perf test changes won't affect anything? It looked like we were only using the generateUuid function.

Perf test changes look fine.  This is just a sample perf test for the "template" sample package.


instrumentation-undici records exception when calling Response.body.cancel.

What happened?
Steps to Reproduce
const response = await fetch('https://www.google.com', { method: 'get' });
await response.body?.cancel('HELLO WORLD');

Expected Result
Here the response has a 200 status code. I do not intend to use the response body and since I am using Undici which comes  packaged with Node 20, I explicitly cancel the response body stream as directed by the Undici docs:

The Fetch Standard allows users to skip consuming the response body by relying on garbage collection to release connection resources. Undici does not do the same. Therefore, it is important to always either consume or cancel the response body.

Because this cancellation is an intentional performance optimization that is promoted by the undici maintainers and is not meant to indicate some sort of issue with the request, I expected the generated span status to be OK.
Actual Result
The span status is set to ERROR and an exception is recorded. See the relevant log output below for details.
OpenTelemetry Setup Code
import { UndiciInstrumentation } from '@opentelemetry/instrumentation-undici';

import { NodeSDK } from '@opentelemetry/sdk-node';
import {
  ConsoleSpanExporter,
  SimpleSpanProcessor,
} from '@opentelemetry/sdk-trace-base';

const exporter = new ConsoleSpanExporter();
const sdk = new NodeSDK({
  autoDetectResources: true,
  traceExporter: exporter,
  spanProcessors: [new SimpleSpanProcessor(exporter)],
  instrumentations: [
    new UndiciInstrumentation(),
  ],
});

sdk.start();

process.on('SIGTERM', () => {
  sdk
    .shutdown()
    .then(() => console.log('Tracing terminated'))
    .catch((error) => console.log('Error terminating tracing', error))
    .finally(() => process.exit(0));
});

package.json
{
  "dependencies": {
    "@opentelemetry/instrumentation-undici": "0.6.0",
    "@opentelemetry/sdk-node": "^0.53.0",
    "@opentelemetry/sdk-trace-base": "^1.26.0",
    "undici": "^6.20.0"
  },
  "devDependencies": {
    "typescript": "^5.3.2"
  }
}

Relevant log output
{
  resource: {
    attributes: {
      'service.name': 'unknown_service:node',
      'telemetry.sdk.language': 'nodejs',
      'telemetry.sdk.name': 'opentelemetry',
      'telemetry.sdk.version': '1.26.0',
      'process.pid': 65973,
      'process.executable.name': 'node',
      'process.runtime.version': '20.14.0',
      'process.runtime.name': 'nodejs',
      'process.runtime.description': 'Node.js',
       ...
      'host.arch': 'arm64'
    }
  },
  instrumentationScope: {
    name: '@opentelemetry/instrumentation-undici',
    version: '0.6.0',
    schemaUrl: undefined
  },
  traceId: 'f4372db8a37858d737a008c167d579e6',
  parentId: undefined,
  traceState: undefined,
  name: 'GET',
  id: '14bd8da53cfd3848',
  kind: 2,
  timestamp:<PHONE_NUMBER>178000,
  duration: 335598.666,
  attributes: {
    'http.request.method': 'GET',
    'http.request.method_original': 'GET',
    'url.full': 'https://www.google.com/',
    'url.path': '/',
    'url.query': '',
    'url.scheme': 'https',
    'server.address': 'www.google.com',
    'server.port': 443,
    'user_agent.original': 'undici',
    'network.peer.address': '<IP_ADDRESS>',
    'network.peer.port': 443,
    'http.response.status_code': 200
  },
  status: { code: 2, message: undefined },
  events: [
    {
      name: 'exception',
      attributes: { 'exception.message': 'HELLO WORLD' },
      time: [<PHONE_NUMBER>, 513519708 ],
      droppedAttributesCount: 0
    }
  ],
  links: []
}

FYI @david-luna @trentm (component owners)

Hi @jholm117
undici does not seem to differentiate between a request being aborted and the body being cancelled . In both scenarios undici sends a message to undici:request:error diagnostic channel with the same error type and the only difference is the stack trace.
// when cancelling the response body
// const response = await fetch('https://www.google.com', { method: 'get' });
// await response.body?.cancel();
// we get
{
  ... rest of Span properties
  status: { code: 2, message: 'The operation was aborted.' },
  events: [
    {
      name: 'exception',
      attributes: {
        'exception.type': '20',
        'exception.message': 'The operation was aborted.',
        'exception.stacktrace': 'AbortError: The operation was aborted.\n' +
          '    at new DOMException (node:internal/per_context/domexception:53:5)\n' +
          '    at Fetch.abort (node:internal/deps/undici/undici:9496:19)\n' +
          '    at cancelAlgorithm (node:internal/deps/undici/undici:10226:32)\n' +
          '    at Object.cancel (node:internal/deps/undici/undici:10240:19)\n' +
          '    at readableStreamDefaultControllerCancelSteps (node:internal/webstreams/readablestream:2383:39)\n' +
          '    at [kCancel] (node:internal/webstreams/readablestream:1079:12)\n' +
          '    at ensureIsPromise (node:internal/webstreams/util:185:19)\n' +
          '    at readableStreamCancel (node:internal/webstreams/readablestream:1984:5)\n' +
          '    at node:internal/webstreams/readablestream:1509:15\n' +
          '    at complete (node:internal/webstreams/readablestream:1398:9)'
      },
      time: [<PHONE_NUMBER>, 669599792 ],
      droppedAttributesCount: 0
    }
  ],
  links: []
}

// when aborting the request
// const controller = new AbortController();
// fetch('https://www.google.com', { method: 'get', signal: controller.signal });
// controller.abort();
{
  ... rest of Span properties
  status: { code: 2, message: 'This operation was aborted' },
  events: [
    {
      name: 'exception',
      attributes: {
        'exception.type': '20',
        'exception.message': 'This operation was aborted',
        'exception.stacktrace': 'AbortError: This operation was aborted\n' +
          '    at new DOMException (node:internal/per_context/domexception:53:5)\n' +
          '    at AbortController.abort (node:internal/abort_controller:392:18)\n' +
          '    at Server.<anonymous> (/Users/david/Documents/issues/otel/2482-contrib/index.js:10:18)\n' +
          '    at Server.emit (node:events:514:28)\n' +
          '    at parserOnIncoming (node:_http_server:1143:12)\n' +
          '    at HTTPParser.parserOnHeadersComplete (node:_http_common:119:17)'
      },
      time: [<PHONE_NUMBER>, 943092916 ],
      droppedAttributesCount: 0
    }
  ],
  links: []
}

the only difference is in the stack trace because the error type is the same DOMException. We may think on inspecting the stack traces but we only get them when cancel/abort are called with no params. Passing a reason param in these methods replaces completely the DOMException which makes really difficult to know what to expect. In your example you're passing a string so instrumentation gets that and nothing more which is not enough to know if it came from cancelling a response or aborting a request.
The only solution that comes to my mind right now is to add a new configuration where you can pass a filter function for errors. The instrumentation would not record the error if the filter function returns false. The signature could be
function shouldRecordError(request: UndiciRequest, error: any): boolean {
}

Hi @david-luna! Thanks for looking into this. It's unfortunate there is no way to differentiate between cancel and abort but that aligns with my understanding of the issue as well.
I like your proposed solution. I'm guessing this won't be prioritized internally, so should I put up a PR for it?

Some thoughts, from reading https://opentelemetry.io/docs/specs/semconv/http/http-spans/#status and note [5] at https://opentelemetry.io/docs/specs/semconv/http/http-spans/#http-client (for the error.type span attribute):

Overall, my limited experience is that OTel specs for HTTP are sometimes unclear on whether handling of the response body should be considered.

The error.type attribute note says (emphasis mine)

If the request fails with an error before response status code was sent or received, error.type SHOULD be set to exception type (its fully-qualified class name, if applicable) or a component-specific low cardinality error identifier.
If response status code was sent or received and status indicates an error according to HTTP span status definition, error.type SHOULD be set to the status code number (represented as a string), an exception type (if thrown) or a component-specific error identifier.
The error.type value SHOULD be predictable and SHOULD have low cardinality. Instrumentations SHOULD document the list of errors they report.

In the case on this issue, we do have a response status code, so this spec wording suggests that we should be setting error.type based on the response status code.   I haven't played to see if the handler of the undici:request:error message can tell if there is a response status.

Spec notes on span.status for HTTP instrumentation (https://opentelemetry.io/docs/specs/semconv/http/http-spans/#status) first discusses setting span.status based on HTTP status code, then it says:

HTTP request may fail if it was cancelled or an error occurred preventing the client or server from sending/receiving the request/response fully.
When instrumentation detects such errors it SHOULD set span status to Error and SHOULD set the error.type attribute.

Here is a case where it is unclear if the handling of the body is relevant. It says "or an error occurred preventing the client or server from sending/receiving the request/response fully", but the error.type wording above said "an error before response status code was sent or received".
Note that instrumentation-http is using if (response.aborted && !response.complete) { to set the span status to an error before considering the response status code.
https://github.com/open-telemetry/opentelemetry-js/blob/55a1fc88d84b22c08e6a19eff71875e15377b781/experimental/packages/opentelemetry-instrumentation-http/src/http.ts#L493-L504
IIUC Node.js' response.complete does include the body: https://nodejs.org/api/http.html#messagecomplete

https://opentelemetry.io/docs/specs/semconv/http/http-spans/#http-client-span-duration (I think recently) expanded to discuss issues around the body:

...
If there is any possibility for application code to not fully read the HTTP response (and for the HTTP client library to then have to clean up the HTTP response asynchronously), the HTTP client span SHOULD NOT be ended in this cleanup phase, and instead SHOULD end at some point after the HTTP response headers are fully read (or fail to be read).
...

I haven't played yet, but I think this applies to undici/fetch usage: if the user just never reads the body, do we just not get a undici:request:trailers diagnostics channel message that we use to call span.end()?

So, yuck. I'm not exactly sure what (a) the default behaviour should be and (b) if/what configurability we should provide for this.

I haven't played to see if the handler of the undici:request:error message can tell if there is a response status.

The message itself does not include response info. However, we could cache it on the record we are already keeping:
diff --git a/plugins/node/instrumentation-undici/src/undici.ts b/plugins/node/instrumentation-undici/src/undici.ts
index 1755b741..53b06d4f 100644
--- a/plugins/node/instrumentation-undici/src/undici.ts
+++ b/plugins/node/instrumentation-undici/src/undici.ts
@@ -55,6 +55,7 @@ interface InstrumentationRecord {
   span: Span;
   attributes: Attributes;
   startTime: HrTime;
+  response?: any;
 }

 // A combination of https://github.com/elastic/apm-agent-nodejs and
@@ -358,6 +359,7 @@ export class UndiciInstrumentation extends InstrumentationBase<UndiciInstrumenta
     if (!record) {
       return;
     }
+    record.response = response;

     const { span, attributes } = record;
     const spanAttributes: Attributes = {
@@ -437,6 +439,8 @@ export class UndiciInstrumentation extends InstrumentationBase<UndiciInstrumenta
     if (!record) {
       return;
     }
+    console.log('XXX onError: request: ', request);
+    console.log('XXX onError: response: ', record.response);

     const { span, attributes, startTime } = record;

So, yuck. I'm not exactly sure what (a) the default behaviour should be and (b) if/what configurability we should provide for this.

I'm starting to be inclined towards:

Setting up a test to simulate fetch() request errors that fail before receiving a response (e.g. a network error, or scheme error or something). If we can distinguish those error cases in the onError handler, then let's span.setStatus(ERROR) and set the error.type attribute.  Effectively, we should have an allow-list of error cases that result in using those errors for setting span status. All other errors are considered possibly defined by the user -- and hence it would be up to the user to determine span status, recording an exception, worrying about error.type cardinality.
However, otherwise (if we have a response.statusCode) in the onError, then lets use that statusCode to determine the span status. In this case, let's not span.recordException().
On configurability: I'd love if we could get away with NOT having a config option here. I realize that means changing the instrumentation to no longer recording a span exception on aborts.


Is there anyway to pass a programmatically built string in?

import { Chalk } from "chalk";
const chalk = new Chalk({ level: 3 });
import chalkTemplate from "chalk-template";
import { convertToChalk } from "./convertToChalk.js";

const block = `A deep well of <c="#E56399">transylexic</c> <color value="silver">ambiphobia</color> pulses in and out of existence. What was in that potion?!`;
const templateString = convertToChalk(block);
console.log(chalkTemplate`${templateString}`); //this doesn't work

console.log(
  chalkTemplate`A deep well of {#E56399 transylexic} {#E56399 ambiphobia} pulses in and out of existence. What was in that potion?!`
); //this works fine, both strings are the same

So I am trying to write a little script to automatically output some strings with custom color tags to the terminal. So my convertToChalk function is correctly formatting the template string, but I'm having trouble getting chalkTemplate to interpret it. If I pass the string in 'raw' not as a variable, it works fine.
Any suggestions or insights would be greatly appreciated! I'm sure I"m just not understanding this.
Output looks like this
A deep well of {#E56399 transylexic} {#c0c0c0 ambiphobia} pulses in and out of existence. What was in that potion?!
A deep well of transylexic ambiphobia pulses in and out of existence. What was in that potion?!

note edited to remove swear word that was in my text string

const chalkTemplateFn = str => {
    const strs = [str];
    strs.raw = [str];
    return chalkTemplate(strs);
};

Give that a shot.

That works awesome! Thank you so much for helping me! Is the raw property an element of chalk itself? Or of chalkTemplate?

Neither, it's how tagged template literals work. chalk-template uses raw to be able to catch \{/\}, which would cause it to ignore those characters instead of treaing them like template clauses.
const myTag = (strs, ...args) => console.log({strs, raw: strs.raw, args});

myTag`there are ${99} bottles of \nbeer on the wall`;

/*
{
  strs: [ 'there are ', ' bottles of \nbeer on the wall' ],
  raw: [ 'there are ', ' bottles of \\nbeer on the wall' ],
  args: [ 99 ]
}
*/

Going to go ahead and close this, let me know if you have any other questions :)

wow, okay, I think I understand it now. Thank you again!


Have a validator object

We currently specify an account and tendermint validator like this:
# We'll be swapping it out with our earth node
EARTH_SELF_DELEGATION_ADDR = "cosmos10v6wvdenee8r9l6wlsphcgur2ltl8ztkvhc8fw"
EARTH_SELF_DELEGATION_PUBKEY = "AsYk9vGihCDVRd8V70Ti7FgVptqunyRv9S22J2XM9njJ"
EARTH_VALIDATOR_OP_ADDRESS = "cosmosvaloper10v6wvdenee8r9l6wlsphcgur2ltl8ztkfrvj9a"

EARTH_PUBKEY = "2j+NkKQHAxu36vduy1sDHJZIeZji7nxnmVIizv07MpE="
EARTH_ADDRESS = "A8A7A64D1F8FFAF2A5332177F777A5816036D65A"
EARTH_CONS_ADDRESS = "cosmosvalcons14zn6vngl3la09ffny9mlwaa9s9srd4j65cqc54"

This should be combined into so it can be passed around as a single object

Use sed calls in any validator- and delegator- swapping operation and these swaps must be done before anything else


Update latest major version of Zig to 0.8

Zig 0.8 release party \_()_/!!
I wasn't sure whether to remove the line about Zig 0.8 being unsupported, since for now it should be that everything in the guide works for 0.8, although I guess that might eventually begin to diverge as Zig progresses to 0.9.

Thanks!


How to make it work on Mac?

Currently, there is no support for MacCatalyst, but PRs are welcome! 😊


Implement UI testing

on #2 @tukusejssirs and @TobiTenno discussed removing jest testing and moving to a pure UI testing system like cypress or playwright
we can discuss what we want to implement here and compare how they'd fulfill our needs. the final choice, we'll document at the end of the issue

@tukusejssirs i'm biased towards cypress because I already use it a good bit and it supports verbose component-based testing. i've not looked into playwright much yet
what are the benefits you see for it?

Use whatever you want. Either is fine with me, I have just read that Playwright might be better/preferred these days, however, I am not a frontend dev. :man_shrugging: If you already know how to use Cypress and consider it a good UI tester, I won’t stop you from using it in here.
That said, I do think that for actual unit tests (e.g. functions, methods), Jest does a good job, however, not for UI tests. As I see it, Cypress is more of an integration/e2e tester. On the other hand, this package might not have much code moved into classes/functions moved outside of a component, thus removing Jest altogether might make sense.
Therefore, I let you do it the way you consider the best. :pray:

i'm fine with jest for, say, the library itself, but on this example app, given that we're not testing the functionality of a pure-code (i.e., unrendered, not something in the browser itself); I think we should scrap jest altogether specifically on the UIs in this repo. If we want to use Jest for, say, the API, i'm totally down for that.

Okay, go for it. :pray:

@tukusejssirs & @emagnier I've been trying to speed up the load of the expandable day variant as part of this, cause it's really slow switching months (at least for me?).
particularly, @emagnier, what specific component are you using on https://romcal.js.org? It loads very fast and still has the features I'd like to see, but on all of the rich viewers i've tried, they result in very slow loads if they're at all interactive.
I've tried loading the components w/ react's lazy, but it does next to nothing to help load time on first load and switching months.
Additionally, i'm planning on ejecting and switching to vite for a smaller footprint from react-scripts that we can give as a better example for keeping up-to-date & more freedom to have all of the build configs less annoyingly locked down in the way that react-scripts is.

it's really slow switching months (at least for me?).

For me, it is fast (after the initial loading OFC) for both NPM and PNPM. I have tested this on 2f44d36 and I have tried it on different combinations of locales and calendars. :man_shrugging:

If you look at the readme, I added a variant for displaying the day's json data, like in romcal.js.org to help us get closer to having that open sourced and easier to deploy after version updates, as our exemplar page is outdated (beta 37, I think) and buggy (time bug that I fixed on here) for negative UTC offsets.
So if you run REACT_APP_DAY_VARIANT=developer npm start, the page load time will change. I've migrated it on my branch to Vite, so it works a bit differently there, but I'm working on figuring out why the pretty json viewer is slowing the month switch down.

@emagnier still looking for your feedback, since i don't have the base code for romcal.github.io

Isn’t this the source code for romcal.github.io/romcal.js.org? 🤔

yeah, that's the problem. i can see class names and stuff, but not actual component names

Yeah, sorry for the delay. The code on romcal.github.io is indeed a derived version of the React example from this repo. The JSON viewer used is this one: https://github.com/uiwjs/react-json-view.
I did it quickly and quite experimentally, so the setup is almost non-existent. Indeed, the compiled code here https://github.com/romcal/romcal.github.io is what serves the website (plus the CNAME file for the js.org domain). For your information, I've just pushed the source code to the source branch of this repo.
Clearly, there are certainly things to automate here (like with every new npm publication of romcal, for example).

@emagnier is it a much older version? either way, they seem to have the same issue I do for the most part of slowness transitioning between months & initial slow load (at least on my branch).
IF you have time to look, I'd appreciate your input, i'd happily open another PR to make it faster

once i finish #6, @emagnier, i believe i'll have everything in place to prep CI for automated deploys from the PR merge


[BUG] Check that LF States are defined correctly for the given calibration mode

I ran into a bug on Hummingbird where the, for example, the State1  channel definition contained both the String sent to -  property and the Voltage (V) LC-A and Voltage (V) LC-B properties. When a channel is set in MM, the order in which channel properties are applies may not be well defined.
I was using the MM-Voltage calibration mode, which calibrates only the Voltage (V) LC-A and Voltage (V) LC-B properties. When I acquired data, one of the states had intensity which was obviously wrong, i.e. uncalibrated, presumably resulting from setting the LC state by sending the state1 string to the LC, rather than applying the calibrated voltages. Removing the  String sent to -  property from the channel definition fixed the problem.
recOrder should check for correct definition of the LF channels. When using MM-Retardance calibration mode, channels State0-5 should only have the String sent to -  MeadowlarkLC property. When using MM-Voltage calibration mode channels should have only the Voltage (V) LC-A and Voltage (V) LC-B properties. When using the DAC calibration mode, the MeadowlarkLC device adapter should not be loaded in MM (at least until we develop a device adapter that can handle both software and DAC control).

Is it true that we now only use the MM-Voltage control mode on the HB? I can replace the old config file with the new debugged file I created.

Great find! The undefined behavior you observed here is very likely related to #191.
Following our chat, I will:

add installation instructions for MM-Voltage mode. I will show how to install MM-Voltage mode by default and  I'll move the MM-Retardance instructions to an aside. I'll also warn users not to put both presets in the same group.
check the MM config settings at calibration time and throw an error if the user's config settings don't match their requested calibration mode.

I'll take you up on your offer to update the old config file on hummingbird. Thanks @ieivanov


Update ROS 1 package maintainers.

Precisely what the title says, for ros1 support.

There is a noetic-devel branch as well but it isn't the default and it has not been used for a release to the best of my memory.

@nuclearsandwich just re-targeted this PR against  noetic-devel. Should we make it the default? WDYT @mjcarroll ?

Should we make it the default?

Probably. It was only time and attention deficit after an oversight that kept me from doing so.

Should we make it the default? WDYT @mjcarroll ?

Agree, we should make it default.


bydbatt v.1.0.8

I installed "bydbatt" for a BYD LV Battery.
Installation and startup OK. All configurations, too, apart from setting "installed arrays" to 1 makes the instance stop with
error messages:

host.iobrokerpi
2022-10-28 18:40:55.040
info
Do not restart adapter system.adapter.bydbatt.0 because disabled or deleted

host.iobrokerpi
2022-10-28 18:40:55.039
error
instance system.adapter.bydbatt.0 terminated with code 3 (NO_ADAPTER_CONFIG_FOUND)

bydbatt.0
2022-10-28 18:40:54.322
warn
Terminated (NO_ADAPTER_CONFIG_FOUND): Without reason

bydbatt.0
2022-10-28 18:40:54.258
error
adapter disabled

host.iobrokerpi
2022-10-28 18:40:42.225
info
"system.adapter.bydbatt.0" disabled

host.iobrokerpi
2022-10-28 18:40:22.293
info
Restart adapter system.adapter.bydbatt.0 because enabled

host.iobrokerpi
2022-10-28 18:40:22.292
error
instance system.adapter.bydbatt.0 terminated with code 6 (UNCAUGHT_EXCEPTION)

bydbatt.0
2022-10-28 18:40:21.580
warn
Terminated (UNCAUGHT_EXCEPTION): Without reason

bydbatt.0
2022-10-28 18:40:21.572
error
Cannot read properties of undefined (reading '1')

bydbatt.0
2022-10-28 18:40:21.570
error
TypeError: Cannot read properties of undefined (reading '1')     at AxiosDigestAuth.request (/opt/iobroker/node_modules/@mhoc/axios-digest-auth/dist/index.js:28:41)     at process.processTicksAndRejections (node:internal/process/task_queues:95:5)     at async bydbattControll.getDatenHome (/opt/iobroker/node_modules/iobroker.bydbatt/main.js:105:19)     at async bydbattControll.getInfos (/opt/iobroker/node_modules/iobroker.bydbatt/main.js:78:27)     at async bydbattControll.onReady (/opt/iobroker/node_modules/iobroker.bydbatt/main.js:52:9)

bydbatt.0
2022-10-28 18:40:21.569
error
unhandled promise rejection: Cannot read properties of undefined (reading '1')

bydbatt.0
2022-10-28 18:40:21.567
error
Unhandled  promise rejection. This error originated either by throwing inside of  an async function without a catch block, or by rejecting a promise which  was not handled with .catch().

No one servicing this adapter?
This could all be due to settings. But whete would I find info? e.g on proper number of arrays and of "installed batteries"

install GIT version and check again


FTP function not working

Description
When accessing an FTP server on my LAN, it does not show the login window and the folder appears empty.

I can't find any option to configure access with username and password in the security settings.

Steps To Reproduce

Open App
Enter ftp address in the direction bar
Folder empty

Expected behavior
Login window to access the ftp server.
Files Version
OS Version: 10.0.19043.1266
Windows Version
Windows 10 Version 21H1 (Build SO 19043.1266)
Relevant Assets
No response

Thanks for the report. It's supposed to be asking for user/pw the first time the folder is open unless access as "anonymous" does not return error, maybe that's the issue.

Merging with #5833


styling and adding features on zoom control, change flyTo condition

This will address https://github.com/VEuPathDB/web-monorepo/issues/197 and change flyTo condition to improve zoom to data behavior

[x] Remove the globe button
[x] Set a max zoom out level that equals what we would have gotten from hitting the globe button. When a user hits max zoom out, the zoom out button (the minus) should become gray
[x] Replace the fly to data icon with the Undo icon
[x] Change flyTo condition to Improve zoom to data behavior

A screenshot is attached

Looking at wwarn - when i use the Reset button, I get first zoomed out to the whole world, then markers render with some markers at the very top of the map, then a second render and those markers at the top of the map disappear.
Is this expected?

Good morning @asizemore Thank you for your tests and reviews. I didn't check WWARN case but the thing you observed may happen due to a couple of reasons. The internal procedure of Reset zoom (zoom to data) is to move viewport to [0,0] and zoom level 1, load all markers, then flyTo function occurs: flyTo will lead to the smallest map bound with zoom level that contains all markers: e.g., if all markers are located at Africa, then it will zoom into Africa area.
So, during this process, it may happen that viewport (map center and zoom level) and map tile are already changed, while loading all markers may take some time. So, some markers may be off screen or not shown during data loading, which may be the case what you observed.
I will check WWARN case too.

The WWARN thing is very strange.
There are 6 points at (88.2667, 27.2) - which are almost certainly data provider bugs.
However, they only seem to render at the widest zoom level, when the viewport sent to the back end clearly includes it.
{
	"viewport": {
		"latitude": {
			"xMax": 89.4822408119778,
			"xMin": -89.1746315294642
		},
		"longitude": {
			"left": -111.79687498999998,
			"right": -111.79687499999997
		}
	}
}

Zoom in one leaflet level (same geohash level) and the viewport latitude stops at 86.77. Just shy of the 88.2 where the data is.
{
	"viewport": {
		"latitude": {
			"xMax": 86.77799674310461,
			"xMin": -67.06743335108298
		},
		"longitude": {
			"left": -129.02343749,
			"right": -129.0234375
		}
	}
}

It might be a bug in leaflet. I don't think we should spend a lot of time looking into it, unless we see problems like this nearer to the equator!

@bobular Thank you for your test and reviews The leaflet-disabled class is the default one from leaflet and yes I noticed that they changed the size of the +/-. Perhaps it is acceptable for now as you mentioned. 😃 map.getMaxZoom() seems to work fine 👍


Cannot run docker-machine in powershell

I did a fresh install of the docker toolbox on a new windows box today. I can run docker fine in the docker quickstart
akrop_000@AntonLaptop MINGW64 ~
$ docker-machine.exe ls
NAME      ACTIVE   DRIVER       STATE     URL                         SWARM   DO
CKER    ERRORS
default   *        virtualbox   Running   tcp://<IP_ADDRESS>:2376           v1
.10.2

But in powershell
> docker-machine ls
NAME      ACTIVE   DRIVER       STATE     URL   SWARM   DOCKER    ERRORS
default   -        virtualbox   Stopped                 Unknown

When trying to set env
> docker-machine env default --shell powershell
Error checking TLS connection: Host is not running

Seems like something may be wrong with ssh?
hine Version:  0.6.0, build e27fb87
Regenerating TLS certificates
Found binary path at C:\Program Files\Docker Toolbox\docker-machine.exe
Launching plugin server for driver virtualbox
Plugin server listening at address <IP_ADDRESS>:3275
() Calling .GetVersion
Using API Version  1
() Calling .SetConfigRaw
() Calling .GetMachineName
command=configureAuth machine=default
Waiting for SSH to be available...
Getting to WaitForSSH function...
(default) Calling .GetSSHHostname
(default) Calling .GetSSHPort
(default) Calling .GetSSHKeyPath
(default) Calling .GetSSHKeyPath
(default) Calling .GetSSHUsername
Using SSH client type: external
{[-o BatchMode=yes -o PasswordAuthentication=no -o StrictHostKeyChecking=no -o UserKnownHostsFile=/dev/null -o LogLevel=quiet -o ConnectionAttempts=3 -o ConnectTimeout=10 -o ControlMaster=no -o ControlPath=none<EMAIL_ADDRESS>-o IdentitiesOnly=yes -i C:\Users\akrop_000\.docker\machine\machines\default\id_rsa -p 2844] C:\Program Files (x86)\Gow\bin\ssh.bat}
About to run SSH command:
exit 0
SSH cmd err, output: exit status 1: 'C:\Program' is not recognized as an internal or external command,
operable program or batch file.

Error getting ssh command 'exit 0' : Something went wrong running an SSH command!
command : exit 0
err     : exit status 1
output  : 'C:\Program' is not recognized as an internal or external command,
operable program or batch file.

Getting to WaitForSSH function...
(default) Calling .GetSSHHostname
(default) Calling .GetSSHPort
(default) Calling .GetSSHKeyPath
(default) Calling .GetSSHKeyPath
(default) Calling .GetSSHUsername
Using SSH client type: external
{[-o BatchMode=yes -o PasswordAuthentication=no -o StrictHostKeyChecking=no -o UserKnownHostsFile=/dev/null -o LogLevel=quiet -o ConnectionAttempts=3 -o ConnectTimeout=10 -o ControlMaster=no -o ControlPath=none<EMAIL_ADDRESS>-o IdentitiesOnly=yes -i C:\Users\akrop_000\.docker\machine\machines\default\id_rsa -p 2844] C:\Program Files (x86)\Gow\bin\ssh.bat}
About to run SSH command:
exit 0
SSH cmd err, output: exit status 1: 'C:\Program' is not recognized as an internal or external command,
operable program or batch file.

I'm not sure. Any help would be appreciated
-- EDIT
I switched my ssh to be git ssh but still no dice
Calling .GetSSHUsername
Using SSH client type: external
{[-o BatchMode=yes -o PasswordAuthentication=no -o StrictHostKeyChecking=no -o UserKnownHostsFile=/dev/null -o LogLevel=quiet -o ConnectionAttempts=3 -o ConnectTimeout=10 -o ControlMaster=no -o ControlPath=none<EMAIL_ADDRESS>-o IdentitiesOnly=yes -i C:\Users\akrop_000\.docker\machine\machines\default\id_rsa -p 2844] C:\Program Files (x86)\Git\bin\ssh.exe}
About to run SSH command:
netstat -an
SSH cmd err, output: <nil>: Active Internet connections (servers and established)
Proto Recv-Q Send-Q Local Address           Foreign Address         State
tcp        0      0 <IP_ADDRESS>:22              <IP_ADDRESS>:*               LISTEN
tcp       32      0 <IP_ADDRESS>:22            <IP_ADDRESS>:6790           ESTABLISHED
tcp        0      0 <IP_ADDRESS>:22            <IP_ADDRESS>:6437           TIME_WAIT
tcp        0      0 :::2376                 :::*                    LISTEN
tcp        0      0 :::22                   :::*                    LISTEN
udp        0      0 <IP_ADDRESS>:45647           <IP_ADDRESS>:*
udp        0      0 <IP_ADDRESS>:35499           <IP_ADDRESS>:*
Active UNIX domain sockets (servers and established)
Proto RefCnt Flags       Type       State         I-Node Path
unix  2      [ ACC ]     STREAM     LISTENING      20062 /var/lib/docker/network/files/60e9952cbbf4ed8d7bbeef75bc389238a339851e364c017bf532f5b7c1774446.sock
unix  2      [ ACC ]     SEQPACKET  LISTENING      14400 /run/udev/control
unix  2      [ ACC ]     STREAM     LISTENING      19943 /var/run/docker.sock
unix  2      [ ACC ]     STREAM     LISTENING      18430 /var/run/acpid.socket
unix  3      [ ]         DGRAM                     14409
unix  3      [ ]         STREAM     CONNECTED      23153
unix  3      [ ]         DGRAM                     14410
unix  3      [ ]         STREAM     CONNECTED      23152

(default) Calling .GetSSHHostname
(default) Calling .GetSSHPort
(default) Calling .GetSSHKeyPath
(default) Calling .GetSSHKeyPath
(default) Calling .GetSSHUsername
Using SSH client type: external
{[-o BatchMode=yes -o PasswordAuthentication=no -o StrictHostKeyChecking=no -o UserKnownHostsFile=/dev/null -o LogLevel=quiet -o ConnectionAttempts=3 -o ConnectTimeout=10 -o ControlMaster=no -o ControlPath=none<EMAIL_ADDRESS>-o IdentitiesOnly=yes -i C:\Users\akrop_000\.docker\machine\machines\default\id_rsa -p 2844] C:\Program Files (x86)\Git\bin\ssh.exe}
About to run SSH command:
sudo mkdir -p /var/lib/boot2docker
SSH cmd err, output: <nil>:
(default) Calling .GetMachineName
(default) Calling .GetIP
(default) DBG | COMMAND: C:\Program Files\Oracle\VirtualBox\VBoxManage.exe showvminfo default --machinereadable
(default) DBG | STDOUT:
(default) DBG | {
(default) DBG | name="default"
Host is not running
C:\Projects> docker-machine.exe ls
NAME      ACTIVE   DRIVER       STATE     URL   SWARM   DOCKER    ERRORS
default   -        virtualbox   Stopped                 Unknown

-- EDIT
turns it this is somehow related to running powershell in admin mode. After changing the ssh env var path I can run docker-machine fine in not powershell admin mode.

Seems like the ssh path isn't being escaped, since my ssh is in
C:\Windows\System32>which ssh
C:\Program Files (x86)\Gow\bin\ssh.BAT

@devshorts It appears that docker-machine has a bug with spaces in file paths. It's trying to invoke the SSH executable, but it's failing to resolve the full file path under c:\Program Files, instead truncating it to c:\Program. This is actually a common problem with software that isn't tested with spaces in filesystem paths. I'd suggest updating the title of your issue report to help gain visibility to this.
Cheers,
Trevor Sullivan
Microsoft MVP: PowerShell

This is caused by Gow. Gow has a ssh command which is an alias to plink. It looks like when ran from Windows CMD, docker-machine uses whatever is in the path for ssh and cannot work with plink as a ssh replacement.
I get the same error as the OP when I run docker-machine with Gow in my PATH. Here's my output from Windows CMD:
>docker-machine ls
NAME     ACTIVE   DRIVER       STATE     URL   SWARM   DOCKER    ERRORS
docker   *        virtualbox   Running                 Unknown   Something went wrong running an SSH command!
command : ip addr show dev eth1
err     : exit status 1
output  : 'C:\Program' is not recognized as an internal or external command,
operable program or batch file.

From Git Bash, I get no error whatsoever:
MINGW64 ~
$ docker-machine ls
NAME     ACTIVE   DRIVER       STATE     URL                         SWARM   DOCKER    ERRORS
docker   -        virtualbox   Running   tcp://<IP_ADDRESS>:2376           v1.10.3

If I take Gow out from my PATH (so no ssh command in my path), I get no error in Windows CMD.
The ssh command from Gow looks like this:
"C:\Program Files (x86)\Gow\bin\ssh.bat"
@echo off
plink %1 %2 %3 %4 %5 %6 %7 %8 %9

+1. I created docker-cmd-js, which should help running docker commands on Windows. Most common usage I can see would be using it in gulp. See blog about it if interested. Everything works fine until I execute gulp in a command line with Administrator mode.

This appears to be a bug in golang's native exec.Command function, as per this issue.
The offending code is in the getSSHCmd function, currently at line 376 of:
machine/libmachine/ssh/client.go
Problem: I'm not currently familiar enough with the Go language to propose any kind of Pull Request, but I'm sure there's something simple that can be done to resolve this.
Of course, the work-around is to use some kind of mingw bash shell to run docker-machine, but because it already detects the OS as Windows, you have to remember to add the --shell bash argument to commands like docker env. Otherwise you get commands written for cmd.exe, rather than bash or Powershell.

I can confirm that this problem still exists.
My setup:
Ubuntu 16.04 Server LTS
docker-machine version 0.15.0 build b48dc28d
PowerShell Core 6.1.0-preview.2
Calling docker-machine or ssh from PowerShell scripts, causes timeouts and "hidden" interactive ssh sessions, etc. However, interactive ssh sessions do work when calling ssh directly from a PowerShell prompt.

Note I am using Windows 10 Pro with Hyper-V and docker for windows.
Not docker toolbox and virtualbox.

This fixed for me.
https://github.com/docker/machine/issues/4424#issuecomment-377727985

Now docker-machine runs in the powershell and git bash.
The problem might be because.

I had no docker-machine.exe file created after the above process.