[AutoPR billing/resource-manager] Adding Transactions and BillingSubscription to the BillingRP spec

Created to sync https://github.com/Azure/azure-rest-api-specs/pull/4005

Codecov Report

Merging #3432 into restapi_auto_billing/resource-manager will decrease coverage by 15.85%.
The diff coverage is 82.55%.

@@                            Coverage Diff                             @@
##           restapi_auto_billing/resource-manager    #3432       +/-   ##
==========================================================================
- Coverage                                   53.5%   37.65%   -15.86%
==========================================================================
  Files                                       5665     8857     +3192
  Lines                                     142829   263732   +120903
==========================================================================
+ Hits                                       76419    99302    +22883
- Misses                                     66410   164430    +98020

Impacted Files
Coverage Δ

...illing/azure/mgmt/billing/operations/operations.py
39.39% <0%> (-2.55%)
:arrow_down:

...t/billing/operations/billing_periods_operations.py
51.35% <100%> (-46.93%)
:arrow_down:

...zure/mgmt/billing/models/enrollment_account_py3.py
50% <100%> (ø)

...-mgmt-billing/azure/mgmt/billing/models/invoice.py
100% <100%> (ø)
:arrow_up:

...-billing/azure/mgmt/billing/models/download_url.py
100% <100%> (ø)
:arrow_up:

...ure/mgmt/billing/operations/invoices_operations.py
47.5% <100%> (-48.71%)
:arrow_down:

azure-mgmt-billing/azure/__init__.py
100% <100%> (ø)
:arrow_up:

...mgmt-billing/azure/mgmt/billing/models/resource.py
100% <100%> (ø)
:arrow_up:

...t-billing/azure/mgmt/billing/models/invoice_py3.py
50% <100%> (ø)

...ng/azure/mgmt/billing/models/billing_period_py3.py
50% <100%> (ø)

... and 5256 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bc0bbaa...6dafa92. Read the comment docs.

(message created by the CI based on PR content)


it is not useful

I test the software in two computers,which  named A and B.A computer's signature is IAAA-AAAA-LzgV-7AAA , B computer's signature is IAAA-AAAA-KudG-xQAA。when i copy A's ./example  and license to B, the B return  "licence OK".
I did some experiments in different computers,I found the different computers has common prefix “ IAAA-AAAA“,the postfix didn't inflent the result,all return OK.only prefix influnt the resule,but the prefix is same.
Is my way of using it wrong?

I have same problem, I fixed it by adding some codes to  compare the client_signature and a string which returns from  generate_user_pc_signature, i return LICENSE_OK if two strings is same.

Pull request with fix submitted: #19


Update openapi.json to latest release

Update openapi.json to latest release

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 99.64%. Comparing base (916208b) to head (1ad7c51).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #186   +/-   ##
=======================================
  Coverage   99.64%   99.64%
=======================================
  Files           4        4
  Lines         280      280
  Branches       29       29
=======================================
  Hits          279      279
  Misses          1        1

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


After group adding or modyfing, it does not return to Search tab.

Still not working.

OK, yeah, did not expect that in the develop. invalid.


DoWhy

Name of package: DoWhy
URL of package source code: https://github.com/microsoft/dowhy/
License of package: Apache-2

DoWhy is a Python library for causal inference that supports explicit modeling and testing of causal assumptions. DoWhy is based on a unified language for causal inference, combining causal graphical models and potential outcomes frameworks.
List of package dependencies:

- matplotlib >=3.0
- networkx >=2.0
- numpy >=1.15
- pandas
- pydot >=1.4
- python
- scikit-learn
- scipy
- sympy >=1.4

Available now!


Implement a new Metric Type which will be used for TableMetrics

JIRA:https://issues.apache.org/jira/browse/PHOENIX-6379

@mihir6692 Might want to review this.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
5m 37s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s
The patch appears to include 1 new or modified test files.

_ 4.x Compile Tests _

+1 :green_heart:
mvninstall
15m 23s
4.x passed

+1 :green_heart:
compile
1m  7s
4.x passed

+1 :green_heart:
checkstyle
0m 27s
4.x passed

+1 :green_heart:
javadoc
0m 48s
4.x passed

+0 :ok:
spotbugs
3m 18s
phoenix-core in 4.x has 945 extant spotbugs warnings.

-0 :warning:
patch
3m 24s
Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
6m 52s
the patch passed

+1 :green_heart:
compile
1m  5s
the patch passed

+1 :green_heart:
javac
1m  5s
the patch passed

-1 :x:
checkstyle
0m 29s
phoenix-core: The patch generated 27 new + 0 unchanged - 0 fixed = 27 total (was 0)

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
javadoc
0m 47s
the patch passed

+1 :green_heart:
spotbugs
3m 29s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
183m  8s
phoenix-core in the patch passed.

+1 :green_heart:
asflicense
0m 11s
The patch does not generate ASF License warnings.

223m 33s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1138/1/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/phoenix/pull/1138

Optional Tests
dupname asflicense javac javadoc unit spotbugs hbaseanti checkstyle compile

uname
Linux be7528d71a99 4.15.0-126-generic #129-Ubuntu SMP Mon Nov 23 18:53:38 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev/phoenix-personality.sh

git revision
4.x / 883170e

Default Java
Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08

checkstyle
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1138/1/artifact/yetus-general-check/output/diff-checkstyle-phoenix-core.txt

Test Results
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1138/1/testReport/

Max. process+thread count
4798 (vs. ulimit of 30000)

modules
C: phoenix-core U: phoenix-core

Console output
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1138/1/console

versions
git=2.7.4 maven=3.3.9 spotbugs=4.1.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@vmeka2020 can you squash your commits and raise a new PR with the format of PHOENIX-number Jira title? It will attract to the Jira and run the Hadoop QA, thanks

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m  8s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s
The patch appears to include 1 new or modified test files.

_ 4.x Compile Tests _

+1 :green_heart:
mvninstall
15m 40s
4.x passed

+1 :green_heart:
compile
1m  8s
4.x passed

+1 :green_heart:
checkstyle
0m 29s
4.x passed

+1 :green_heart:
javadoc
0m 49s
4.x passed

+0 :ok:
spotbugs
3m 14s
phoenix-core in 4.x has 945 extant spotbugs warnings.

-0 :warning:
patch
3m 21s
Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
6m 49s
the patch passed

+1 :green_heart:
compile
1m  3s
the patch passed

+1 :green_heart:
javac
1m  3s
the patch passed

-1 :x:
checkstyle
0m 26s
phoenix-core: The patch generated 21 new + 0 unchanged - 0 fixed = 21 total (was 0)

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
javadoc
0m 48s
the patch passed

+1 :green_heart:
spotbugs
3m 27s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
181m 22s
phoenix-core in the patch passed.

+1 :green_heart:
asflicense
0m 10s
The patch does not generate ASF License warnings.

217m 30s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1138/2/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/phoenix/pull/1138

Optional Tests
dupname asflicense javac javadoc unit spotbugs hbaseanti checkstyle compile

uname
Linux 4b6477c0f31c 4.15.0-126-generic #129-Ubuntu SMP Mon Nov 23 18:53:38 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev/phoenix-personality.sh

git revision
4.x / 883170e

Default Java
Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08

checkstyle
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1138/2/artifact/yetus-general-check/output/diff-checkstyle-phoenix-core.txt

Test Results
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1138/2/testReport/

Max. process+thread count
5080 (vs. ulimit of 30000)

modules
C: phoenix-core U: phoenix-core

Console output
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1138/2/console

versions
git=2.7.4 maven=3.3.9 spotbugs=4.1.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.


Lack of TypeScript null safety

Article URL
https://github.com/OfficeDev/office-scripts-docs-reference/blob/main/generate-docs/script-inputs/excel.d.ts
Issue
Office Scripts TypeScript types provide no null safety — mostly not clear where nulls are/aren't allowed or occur:

Many return values might be null, but not typed as such. Often this is documented in JSDoc, but not reflected in the types. For example, DataValidation#getValid is typed () => boolean, whereas it's really () => boolean | null.

Many parameters are nullable, but not typed as such. For example, the extremely useful Table#setPredefinedTableStyle(null) to remove all table styles is completely undocumented (parameter is typed as string).

The inline Code Editor in Excel also provides no null safety. For example:
const nullable = Math.random() > 0.5 ? 1 : null
nullable.toString()

Here, nullable is typed as 1, and nullable.toString() will throw a runtime error 50% of the time.
Presumably this is a tsconfig issue, so maybe outside the scope of documentation, but seems the issues are related.

Hi @lionel-rowe,
Thanks for reporting this. This appears to be a widespread issue here and with the Office JS APIs that sit underneath the Office Scripts API. @gergzk and I will start investigating a fix for both the type definitions and the documentation, though it will likely take some time.

While we acknowledge this issue, there is no timeline for a complete fix. We will be updating individual APIs to indicate null and undefined behavior as we are able. I'm closing this issue to reflect this level of investment.


very slow performance with global sync: True setting vs. async(sync=True)

The async function is very slow with Q_CLUSTER['sync']=True if the sync=True parameter is not given to async.
I have some testcases in my own application:
class ApplicationTestCase(TestCase):
    def test_async_slow(self):
        from time import time
        start = time()

        self.assertEqual(settings.Q_CLUSTER['sync'], True)

        for i in range(0, 5):
            async('django.core.mail.send_mail',
                    subject        = 'Invitation to join team {} at BuzzCo'.format('asd'),
                    from_email     = settings.DEFAULT_FROM_EMAIL,
                    message        = 'hi',
                    recipient_list =<EMAIL_ADDRESS>                    fail_silently  = False,
            )
            print(time() - start)
        self.assertEqual(True, False)   #fail to get output

    def test_async_fast(self):
        from time import time
        start = time()

        self.assertEqual(settings.Q_CLUSTER['sync'], True)

        for i in range(0, 5):
            async('django.core.mail.send_mail',
                    subject        = 'Invitation to join team {} at BuzzCo'.format('asd'),
                    from_email     = settings.DEFAULT_FROM_EMAIL,
                    message        = 'hi',
                    recipient_list =<EMAIL_ADDRESS>                    fail_silently  = False,
                    async=True
            )
            print(time() - start)
        self.assertEqual(True, False)   #fail to get output

outputs:
test_async_fast
0.021257877349853516
0.02476787567138672
0.027889013290405273
0.030992984771728516
0.0339360237121582

test_async_slow
5.010109901428223
5.0143818855285645
5.018315076828003
5.022057056427002
5.025748014450073

Notes:

Django==1.9.7
django-q==0.7.18
q-cluster broker is sqlite ('orm')
emailbackend is the CONSOLE backend

Noticed that

async=True

should be actually be

sync=True

which probably means that test_async_fast was fast because it failed immediately.
Doesn't yet explain why slow took 5s per test though, but for some reason this is not an issue in my project anymore.

after some profiling I've found the reason to be python's socket.getfqdn() taking over 5s so nothing related to Django-Q. Closing the issue.
Solution for those are interested: I replaced Django's emailbackend during tests to a custom one that does not call that function.
class TestEmailBackend(BaseEmailBackend):
    def send_messages(self, messages):
        mail.outbox.extend(messages)
        return len(messages)


[6.0.0-rc.4] ng test --prod fails

Versions
Angular CLI: 6.0.0-rc.4
Node: 8.11.1
OS: linux x64
Angular: 6.0.0-rc.4
... animations, cli, common, compiler, compiler-cli, core, forms
... http, language-service, platform-browser
... platform-browser-dynamic, router

Package                           Version
-----------------------------------------------------------
@angular-devkit/architect         0.5.6
@angular-devkit/build-angular     0.5.6
@angular-devkit/build-optimizer   0.5.6
@angular-devkit/core              0.5.6
@angular-devkit/schematics        0.5.6
@ngtools/json-schema              1.1.0
@ngtools/webpack                  6.0.0-rc.4
@schematics/angular               0.5.6
@schematics/update                0.5.6
rxjs                              6.0.0-turbo-rc.4
typescript                        2.7.2
webpack                           4.5.0

Repro steps
$ ng new testproject
$ cd testproject
$ ng test --prod

Observed behavior
Configuration 'production' could not be found in project 'testproject'.
Error: Configuration 'production' could not be found in project 'testproject'.
    at Architect.getBuilderConfiguration (/tmp/bla/testproject/node_modules/@angular-devkit/architect/src/architect.js:102:23)
    at runSingleTarget (/tmp/bla/testproject/node_modules/@angular/cli/models/architect-command.js:136:89)
    at MergeMapSubscriber.rxjs_2.from.pipe.operators_1.concatMap.project (/tmp/bla/testproject/node_modules/@angular/cli/models/architect-command.js:141:131)
    at MergeMapSubscriber._tryNext (/tmp/bla/testproject/node_modules/rxjs/internal/operators/mergeMap.js:122:27)
    at MergeMapSubscriber._next (/tmp/bla/testproject/node_modules/rxjs/internal/operators/mergeMap.js:112:18)
    at MergeMapSubscriber.Subscriber.next (/tmp/bla/testproject/node_modules/rxjs/internal/Subscriber.js:103:18)
    at Observable._subscribe (/tmp/bla/testproject/node_modules/rxjs/internal/util/subscribeToArray.js:9:20)
    at Observable._trySubscribe (/tmp/bla/testproject/node_modules/rxjs/internal/Observable.js:177:25)
    at Observable.subscribe (/tmp/bla/testproject/node_modules/rxjs/internal/Observable.js:162:93)
    at MergeMapOperator.call (/tmp/bla/testproject/node_modules/rxjs/internal/operators/mergeMap.js:87:23)

Desired behavior
Builds app and runs test, like it does without --prod

You need to add production section to test in angular.json

          "configurations": {
            "production": {
              "fileReplacements": [
                {
                  "replace": "src/environments/environment.ts",
                  "with": "src/environments/environment.prod.ts"
                }
              ]
            }
          }

The configuration is included in the generated angular.json:
{
  "projects": {
    "testproject": {
      "architect": {
        "build": {
          "configurations": {
            "production": {
              "fileReplacements": [
                {
                  "replace": "src/environments/environment.ts",
                  "with": "src/environments/environment.prod.ts"
                }
              ],
            }
          }
        },

(removed irrelevant keys)

Build configuration and test configuration are different. You need to add it as @rokerkony mentioned.


refactor code using black formatter and add dockerhub push cmd, and update base image to version containing cudnn8

Hey there could you explain the rationale behind these changes? There are a lot of files affected including beautification

nvidia/cuda:11.6.2-base-ubuntu20.04 does not include cudnn, so users need to install cudnn and other required dependencies.
However, if use nvidia/cuda:11.6.2-cudnn8-runtime-ubuntu20.04, manual installation is not required.
I updated the port to port 80 to make deployment easier for users.
I also used Python autopep8 to format the code to make it easier for users to understand the code.

This PR contains too many changes. I will create related issues and rewrite the relevant commits.

@jinmiaoluo is this PR still relevant afer merging the other one?

@alesaccoia The code for the first and third topic has been rewritten in PR: https://github.com/alesaccoia/VoiceStreamAI/pull/21
, please take a look.


Remove misplaced PsychrometricData example from MoistAir package at next non-backwards compatible MSL version

Reported by beutlich on 24 Sep 2015 22:02 UTC
Continue from #1757.

Migrated-From: https://trac.modelica.org/Modelica/ticket/1789

Comment by otter on 28 Sep 2015 11:28 UTC
Closed, see discussion in #1757

Modified by beutlich on 28 Sep 2015 11:31 UTC


No implicit UrlForm EntityEncoder.  Why?

Is there a good reason we did not make this implicit, with an implicit charset?  We use this pattern elsewhere (i.e., stringEncoder).
  def entityEncoder(charset: Charset): EntityEncoder[UrlForm] =
    EntityEncoder.stringEncoder(charset)
      .contramap[UrlForm](encodeString(charset))
      .withContentType(`Content-Type`(MediaType.`application/x-www-form-urlencoded`, charset))

/cc @adelbertc

I can't think of one.
On Jun 13, 2015 8:49 PM, "Ross A. Baker"<EMAIL_ADDRESS>wrote:

Is there a good reason we did not make this implicit, with an implicit
charset? We use this pattern elsewhere (i.e., stringEncoder).
def entityEncoder(charset: Charset): EntityEncoder[UrlForm] =
EntityEncoder.stringEncoder(charset)
.contramapUrlForm
.withContentType(Content-Type(MediaType.application/x-www-form-urlencoded, charset))
/cc @adelbertc https://github.com/adelbertc
—
Reply to this email directly or view it on GitHub
https://github.com/http4s/http4s/issues/288.

Closed by f85d947e8fec24f37d5a3ed030a54a1659c04354.


Add OpenROAD remove_buffers to flow

@jjcherry56 points out that we should have the option of calling remove_buffers before we call repair_design, to undo any buffer addition that yosys/abc does.
To complicate matters, Openlane currently has an internal command called remove_buffers. It's controlled by an undocumented environment variable DONT_BUFFER_PORTS. What is it used for? @donn any ideas?
I have a distant memory that it was to remove buffers inserted around tristates. I did find it a mention of it in caravel, but it's commented out:
# mgmt_gpio_in is driven by a tristate cell
# set ::env(DONT_BUFFER_PORTS) "mgmt_gpio_in"

If we are inserting buffers around tristates, I would think we should fix OpenROAD, and just remove this.

There was a bug a while back where resizer but a buffer after a tristate but that was fixed.

There was a bug a while back where resizer but a buffer after a tristate but that was fixed.

Thanks @maliberty, I created https://github.com/The-OpenROAD-Project/OpenLane/pull/1098


Prop to allow dynamic disable/enable of autofocus

Added the disableAutoFocus prop to allow the focus/scrolling action of the form to be disabled. This is useful when the credit card input is used as part of a larger form, as it will steal focus when the form is loaded and information is filled in (e.g. editing previously entered data). Once the form is loaded, the autofocus can easily be enabled so that the input will behave normally when the user interacts with it.

Hey @wchaering ,
Thanks for the PR! Some question though:

disableAutoFocus sounds a bit too similar to the existing autoFocus prop. Is this intentional?
To initialise the form with pre-existing data would adding an initialValues prop works? (e.g. We'll just need to copy the content of initialValues to the form's internal state once it's loaded)

-Sam


Queues medium 1

issue #45 in C++

Can you please update according to the latest README? The new README is now a lot more readable and understandable.


Assertion failure with 0.4.0 release when launching kakoune

I just built and tested the 0.4.0 release on FreeBSD:
$ contour version
QML debugging is enabled. Only use this in a safe environment.
Contour Terminal Emulator 0.4.0
$ hg id
c9c1208587ff default/release/tip release
$ uname -a
FreeBSD triton 14.0-RELEASE-p3 FreeBSD 14.0-RELEASE-p3 #3 fix/sennheiser-bt-headphones-n265403-264a2ccd2ec0: Sat Dec 16 23:48:57 CET 2023     nico@triton:/usr/obj/usr/src/amd64.amd64/sys/TRITON140 amd64
$ kak -version
Kakoune unknown
$

This is kakoune built from a git checkout (development version).
When launching it inside the freshly built contour, contour crashes with the following SIGABRT:
$ contour
QML debugging is enabled. Only use this in a safe environment.
Warning: Invalid audio device ((null):0, (null))
Warning: Failed to create a gst element for the audio device, using a default audio sink ((null):0, (null))
[error] freetype: Failed to set LCD filter. unimplemented feature
Debug[default]: sendKeyEvent:  75   "k"   QFlags<Qt::KeyboardModifier>(NoModifier) (/usr/home/nico/src/contour/src/contour/helper.cpp:142, bool contour::sendKeyEvent(QKeyEvent *, vtbackend::KeyboardEventType, TerminalSession &))
Debug[default]: sendKeyEvent:  75   "k"   QFlags<Qt::KeyboardModifier>(NoModifier) (/usr/home/nico/src/contour/src/contour/helper.cpp:142, bool contour::sendKeyEvent(QKeyEvent *, vtbackend::KeyboardEventType, TerminalSession &))
Debug[default]: sendKeyEvent:  16777220   "\r"   QFlags<Qt::KeyboardModifier>(NoModifier) (/usr/home/nico/src/contour/src/contour/helper.cpp:142, bool contour::sendKeyEvent(QKeyEvent *, vtbackend::KeyboardEventType, TerminalSession &))
[2023-12-19 18:33:48.456191.456191] [vt.parser] Unknown VT sequence: CSI > 4;1 m
Assertion failed: (parameterIndex < _parameters.count()), function param, file /usr/home/nico/src/contour/src/vtbackend/Sequence.h, line 317.
Abort trap (core dumped)
$

I haven't looked at any details yet - if you need any more information please let me know.

Oh many many thanks for testing. Let's see if we can get that fixed before actually releasing 0.4.0. :)

Assertion failed: (parameterIndex < _parameters.count()), function param, file /usr/home/nico/src/contour/src/vtbackend/Sequence.h, line 317.
Abort trap (core dumped)

It says "core dumped", do you happen to have a stack trace for me?
many thanks :)

p.s.: you can also run contour like so:
contour debug vt.trace.sequence

and dump me that (past N lines), because the very last printed VT sequence should be the one that's causing this.

Ah very nice. Seems like kakoune is doing CSI 22 t I cannot find in ctlseqs.txt, that this should be by any means a valid CSI sequence (maybe @j4james knows?). I am sure what is meant is CSI 22 ; 0 t, so the not-found parameter defaulting to 0`. I'll be fixing this. Many thanks!

I am sure what is meant is CSI 22 ; 0 t, so the not-found parameter defaulting to 0.

That would be my assumption too. According to both the ANSI and DEC documentation, any missing or empty parameters should be interpreted as their default value. And unless specified otherwise, a selective parameter would usually default to 0, and a numeric parameter would default to 1.
In this case, it's a selective parameter (you can think of it as an enum rather than an integer), so the default would be 0.

Also, looking at the comments in the kakoune source, it was certainly their intention to save the window title.
https://github.com/mawww/kakoune/blob/83fb65aef5729167b47c6ec22a57e5bd6ac5a9ae/src/terminal_ui.cc#L1472

Ah very nice. Many thanks @j4james :-)


add SPIR-V 1.4 testing for various miscellaneous additions

This PR adds targeted testing for a few remaining miscellaneous SPIR-V 1.4 features:

Variables in the Function storage class can have a NonWriteable decoration.
OpCopyMemorySized can have two optional memory operands.
OpSelect can have composite operands that are not vectors.

I fixed the merge conflict in this PR and in #2053.  I don't have a strong opinion which goes in first.  If it's not this one though, I'll probably need to pull in the latest changes one more time.

Merging as per agreement in the October 29th teleconference.


Added links to purpleair, Mike's twitter, and this repo

Of course, I dunno if you -want- to be linked ;)

Strange! I wanted to add links to other folks contributing, like yourself @obra, but the GitHub contributors page isn't showing that 🤔 I'll leave it there and hope it resolves with time 🙏


Error on windows about paths

This error and that

Because of arm-gcc already installed, I'm sure problem in searching-algorithm in crank.
INFO  crank > compile_setup: "C:\\Program Files (x86)\\GNU Tools Arm Embedded\\9 2019-q4-major\\bin\\arm-none-eabi-gcc.exe" "-g3" "-c" "-mthumb" "-mcpu=cortex-m7" "-mfloat-abi=hard" "-mfpu=fpv5-sp-d16" "-D__FPU_USED=1" "-O2" "-falign-functions=16" "-fomit-frame-pointer" "-gdwarf-2" "-Wall" "-Wno-unused" "-Wstrict-prototypes" "-Wno-unknown-pragmas" "-fverbose-asm" "-Wdouble-promotion" "-mword-relocations" "-fno-common" "-ffunction-sections" "-fdata-sections" "-DTARGET_PLAYDATE=1" "-DTARGET_EXTENSION=1" "-fno-exceptions" "C:/Users/runneradmin/Documents/PlaydateSDK\\C_API\\buildsupport\\setup.c" "-I" "C:/Users/runneradmin/Documents/PlaydateSDK\\C_API" "-o" "D:\\a\\crank\\crank\\crankstart\\target\\thumbv7em-none-eabihf\\release\\setup.o"
Error: The system cannot find the path specified. (os error 3)

I suppose we need to pass normalized non-windows paths to gcc, replace \\ with normal separators /.

This is fixed by #49


Empty response body in ApiException

Under ApiClient.invokeAPI an ApiException is being created with constructor public ApiException(String message). The message includes the response body as part of an exception error message and does not populate fields like responseHeaders and responseBody in ApiException. This makes it inconvenient for clients to parse out the error message returned by docusign.
Please construct the ApiException in a different way so that the responseBody is populated correctly. I am using version 2.4.2.

code changes requested as PR #71

Fixed in version 2.5.1.


Added ssl_ciphers

Allow ssl ciphers to be configured

@jjasghar This is another one we would like to get in this week, it's also just basic config options.

@cmluciano @jjasghar  Humm, seems travis failure is NOT related to this change, but rather to this one: https://github.com/jjasghar/rabbitmq/pull/236   Looks like we pulled out the case to include the yum-epel and yum-erlang, but did not cleanup the specs or the metadata.

Yes that was on purpose. The tests passes with my changes. The reason that they are failing now is due to the removal from the erlang package recipe change.

@cmluciano thx for the update.  I have removed those tests from the spec with my latest push.


Casey fix main scene issues

No task card.
I reverted the merge commit for the berry bush, and then added the drone layer to the list of layers rendered by the main camera.

No issues found, merging.


ERR Attempting to register step with id extensionsWeb twice. Second is dropped.: Error: Attempting to register step with id extensionsWeb twice.

Type: Bug
ERR Attempting to register step with id extensionsWeb twice. Second is dropped.: Error: Attempting to register step with id extensionsWeb twice. Second is dropped.
at vscode-file://vscode-app/c:/Users/artist/AppData/Local/Programs/Microsoft%20Code%20OSS/resources/app/out/vs/workbench/workbench.desktop.main.js:520830:27
at Array.forEach ()
at $F_b._registerWalkthrough (vscode-file://vscode-app/c:/Users/artist/AppData/Local/Programs/Microsoft%20Code%20OSS/resources/app/out/vs/workbench/workbench.desktop.main.js:520828:41)
at vscode-file://vscode-app/c:/Users/artist/AppData/Local/Programs/Microsoft%20Code%20OSS/resources/app/out/vs/workbench/workbench.desktop.main.js:520507:22
at Array.forEach ()
at $F_b.S (vscode-file://vscode-app/c:/Users/artist/AppData/Local/Programs/Microsoft%20Code%20OSS/resources/app/out/vs/workbench/workbench.desktop.main.js:520506:42)
at new $F_b (vscode-file://vscode-app/c:/Users/artist/AppData/Local/Programs/Microsoft%20Code%20OSS/resources/app/out/vs/workbench/workbench.desktop.main.js:520503:18)
at $Er.o (vscode-file://vscode-app/c:/Users/artist/AppData/Local/Programs/Microsoft%20Code%20OSS/resources/app/out/vs/workbench/workbench.desktop.main.js:123856:28)
at vscode-file://vscode-app/c:/Users/artist/AppData/Local/Programs/Microsoft%20Code%20OSS/resources/app/out/vs/workbench/workbench.desktop.main.js:123986:42
at $4h.d (vscode-file://vscode-app/c:/Users/artist/AppData/Local/Programs/Microsoft%20Code%20OSS/resources/app/out/vs/workbench/workbench.desktop.main.js:61245:30)
at get value (vscode-file://vscode-app/c:/Users/artist/AppData/Local/Programs/Microsoft%20Code%20OSS/resources/app/out/vs/workbench/workbench.desktop.main.js:61262:22)
at Object.get (vscode-file://vscode-app/c:/Users/artist/AppData/Local/Programs/Microsoft%20Code%20OSS/resources/app/out/vs/workbench/workbench.desktop.main.js:124033:42)
at new $Hac (vscode-file://vscode-app/c:/Users/artist/AppData/Local/Programs/Microsoft%20Code%20OSS/resources/app/out/vs/workbench/workbench.desktop.main.js:606291:31)
at $Er.o (vscode-file://vscode-app/c:/Users/artist/AppData/Local/Programs/Microsoft%20Code%20OSS/resources/app/out/vs/workbench/workbench.desktop.main.js:123856:28)
at $Er.createInstance (vscode-file://vscode-app/c:/Users/artist/AppData/Local/Programs/Microsoft%20Code%20OSS/resources/app/out/vs/workbench/workbench.desktop.main.js:123827:31)
at $Frb.instantiate (vscode-file://vscode-app/c:/Users/artist/AppData/Local/Programs/Microsoft%20Code%20OSS/resources/app/out/vs/workbench/workbench.desktop.main.js:525155:47)
at $wLb.Q (vscode-file://vscode-app/c:/Users/artist/AppData/Local/Programs/Microsoft%20Code%20OSS/resources/app/out/vs/workbench/workbench.desktop.main.js:526201:50)
at $wLb.P (vscode-file://vscode-app/c:/Users/artist/AppData/Local/Programs/Microsoft%20Code%20OSS/resources/app/out/vs/workbench/workbench.desktop.main.js:526181:37)
at $wLb.O (vscode-file://vscode-app/c:/Users/artist/AppData/Local/Programs/Microsoft%20Code%20OSS/resources/app/out/vs/workbench/workbench.desktop.main.js:526160:37)
at $wLb.L (vscode-file://vscode-app/c:/Users/artist/AppData/Local/Programs/Microsoft%20Code%20OSS/resources/app/out/vs/workbench/workbench.desktop.main.js:526097:31)
at $wLb.openEditor (vscode-file://vscode-app/c:/Users/artist/AppData/Local/Programs/Microsoft%20Code%20OSS/resources/app/out/vs/workbench/workbench.desktop.main.js:526000:35)
at vscode-file://vscode-app/c:/Users/artist/AppData/Local/Programs/Microsoft%20Code%20OSS/resources/app/out/vs/workbench/workbench.desktop.main.js:563153:78
at $yLb.Kb (vscode-file://vscode-app/c:/Users/artist/AppData/Local/Programs/Microsoft%20Code%20OSS/resources/app/out/vs/workbench/workbench.desktop.main.js:563172:19)
at $yLb.Jb (vscode-file://vscode-app/c:/Users/artist/AppData/Local/Programs/Microsoft%20Code%20OSS/resources/app/out/vs/workbench/workbench.desktop.main.js:563138:43)
at $yLb.openEditor (vscode-file://vscode-app/c:/Users/artist/AppData/Local/Programs/Microsoft%20Code%20OSS/resources/app/out/vs/workbench/workbench.desktop.main.js:563051:25)
at $iMb.openEditor (vscode-file://vscode-app/c:/Users/artist/AppData/Local/Programs/Microsoft%20Code%20OSS/resources/app/out/vs/workbench/workbench.desktop.main.js:540594:26)
VS Code version: Code - OSS 1.93.0 (deed0fb5213f2f47ed43fa2c0a9259309050b831, 2024-08-31T07:53:45.858Z)
OS version: Windows_NT x64 10.0.19045
Modes:

System Info

Item
Value

CPUs
AMD Ryzen 5 PRO 4650G with Radeon Graphics (12 x 3693)

GPU Status
2d_canvas: enabledcanvas_oop_rasterization: enabled_ondirect_rendering_display_compositor: disabled_off_okgpu_compositing: enabledmultiple_raster_threads: enabled_onopengl: enabled_onrasterization: enabledraw_draw: disabled_off_okskia_graphite: disabled_offvideo_decode: enabledvideo_encode: enabledvulkan: disabled_offwebgl: enabledwebgl2: enabledwebgpu: enabledwebnn: disabled_off

Load (avg)
undefined

Memory (System)
15.39GB (8.96GB free)

Process Argv

Screen Reader
no

VM
0%

Extensions (13)

Extension
Author (truncated)
Version

icons-carbon
ant
0.2.6

reveal-button
anw
1.1.1

prettier-vscode
esb
11.0.0

file-icons
fil
1.1.0

vscode-language-pack-zh-hans
MS-
1.93.2024082809

remote-containers
ms-
0.383.0

remote-ssh
ms-
0.113.1

remote-ssh-edit
ms-
0.86.0

remote-wsl
ms-
0.88.2

vscode-remote-extensionpack
ms-
0.25.0

remote-explorer
ms-
0.4.3

remote-server
ms-
1.5.2

vim
vsc
1.28.0

(1 theme extensions excluded)

Isn't the code for the main branch up to date

@AlaricWeb which extension were you trying to install?

@AlaricWeb您想安装哪个扩展？
I already took care of it


Add links to README.md headings

Hi 🙂
This would add links without underline or special colour to the files parsed by marked, fixing (partially?) this issue: https://github.com/TypeStrong/typedoc/issues/972
Was thinking that it may be nice to also add links in the headings in the generated API pages, e.g. Properties, Functions, etc. , and in each of the elements titles (e.g. methodA). The last ones are already anchors although they are still using the name attribute, for example:

methodA

However, I think that would involve updating this repository: https://github.com/TypeStrong/typedoc-default-themes with a different approach, and not sure if this issue was referring to that also.
Many thanks for the library and happy to update any code from comments

Thanks! Still leaving #972 open as my intent there was to add links in the typedoc-site, but this is a good change to make.


Compilation Error

There is a compilation error when I run this. It gives:
Cannot find module 'assets-webpack-plugin'

I was able to bypass this when I used yarn but still wasn't working

I had the same error , try to install this "npm install assets-webpack-plugin --save-dev"

I had the same error and solved it by running:
"npm install assets-webpack-plugin --save-dev"

Anyone can please share this the Gentelella in angular 4 version.

So this was inactive very long time, but I just updated to angular 7, and project is now based off of angular CLI.  So probably you've moved on, but just thought I should respond and close all the issues =)


What type of compression in save_single_frameset function used?

Required Info

Camera Model
D435

Operating System & Version
Win 10

Platform
PC

Language
python

Issue Description
Hi,
I use save_single_frameset() function for recording ROS-bag files from D435 camera. And now I want to know if ROS-bag compression is used in this function or not.
I know there is the option in the RealSense Viewer named "ROS-bag Compression" where you can choose one of 3 options (Always compress, Never compress or Use device defaults). I also would like to know what the device defaults are in the RealSense Viewer - does it compress files or not? And I try to understand if my code compresses the file or not.
The parameters of video capture:
config.enable_stream(rs.stream.depth, 640, 480, rs.format.z16, 15)
config.enable_stream(rs.stream.color, 640, 480, rs.format.rgb8, 15)

And in the end I save file with:
frameset = rs.save_single_frameset(filename=frameset_name)
frameset.process(frames)

Could anyone help me please?
Thanks.

Hi @ten156735  At https://github.com/IntelRealSense/librealsense/issues/3594 it is advised that by default, compression is performed by device type and that the compression format is ros-bag lossless LZ4 compression.  Information about the RealSense SDK's LZ4 compression can be found at the link below.
https://github.com/IntelRealSense/librealsense/blob/master/third-party/realsense-file/lz4/lz4.h
As compression is part of the RealSense API rather than exclusive to the Viewer only, I believe that LZ4 compression will be applied to any bag recording by the SDK by default unless deliberately disabled.

Hi @ten156735  Do you require further assistance with this case, please?  Thanks!

Case closed due to no further comments received.


Cannot resolve dependecy

I can't pull in dependency when using sbt or gradle
Full sbt build file
enablePlugins(JavaAppPackaging)

name := "sample"
version := "1.0"
scalaVersion := "2.12.3"

scalacOptions := Seq("-unchecked", "-deprecation", "-encoding", "utf8")

libraryDependencies ++= {
  val scalaTestVersion  = "3.0.1"
  Seq(
    "org.scalaz" %% "scalaz-zio" % "0.1-SNAPSHOT",

    //Logging
    "com.typesafe.scala-logging" %% "scala-logging" % "3.9.0",
    "ch.qos.logback" % "logback-classic" % "1.2.3",

    //Testing
    "org.scalatest"     %% "scalatest" % scalaTestVersion % "test"
  )
}

mainClass in Compile := Some("Rest")

Revolver.settings

Results in the following error
[info] Resolving org.scalaz#scalaz-zio_2.12;0.1-SNAPSHOT ...
[info] Resolving org.scalaz#scalaz-zio_2.12;0.1-SNAPSHOT ...
[warn] 	module not found: org.scalaz#scalaz-zio_2.12;0.1-SNAPSHOT
[warn] ==== local: tried
[warn]   /Users/tom/.ivy2/local/org.scalaz/scalaz-zio_2.12/0.1-SNAPSHOT/ivys/ivy.xml
[warn] ==== public: tried
[warn]   https://repo1.maven.org/maven2/org/scalaz/scalaz-zio_2.12/0.1-SNAPSHOT/scalaz-zio_2.12-0.1-SNAPSHOT.pom
[warn] ==== local-preloaded-ivy: tried
[warn]   /Users/tom/.sbt/preloaded/org.scalaz/scalaz-zio_2.12/0.1-SNAPSHOT/ivys/ivy.xml
[warn] ==== local-preloaded: tried
[warn]   file:////Users/tom/.sbt/preloaded/org/scalaz/scalaz-zio_2.12/0.1-SNAPSHOT/scalaz-zio_2.12-0.1-SNAPSHOT.pom
[info] Resolving com.typesafe.scala-logging#scala-logging_2.12;3.9.0 ...

[warn] 	::::::::::::::::::::::::::::::::::::::::::::::
[warn] 	::          UNRESOLVED DEPENDENCIES         ::
[warn] 	::::::::::::::::::::::::::::::::::::::::::::::
[warn] 	:: org.scalaz#scalaz-zio_2.12;0.1-SNAPSHOT: not found
[warn] 	::::::::::::::::::::::::::::::::::::::::::::::
[warn]
[warn] 	Note: Unresolved dependencies path:
[warn] 		org.scalaz:scalaz-zio_2.12:0.1-SNAPSHOT (/Users/tom/repos/akka-http-microservice/build.sbt#L9-22)
[warn] 		  +- sample:sample_2.12:1.0
[trace] Stack trace suppressed: run 'last *:ssExtractDependencies' for the full output.
[trace] Stack trace suppressed: run 'last *:update' for the full output.
[error] (*:ssExtractDependencies) sbt.ResolveException: unresolved dependency: org.scalaz#scalaz-zio_2.12;0.1-SNAPSHOT: not found

[error] (*:update) sbt.ResolveException: unresolved dependency: org.scalaz#scalaz-zio_2.12;0.1-SNAPSHOT: not found
[error] Total time: 1 s, completed 02-Aug-2018 21:06:26

Also tried in gradle
compile "org.scalaz:scalaz-zio_${scalaVersion}:0.1-SNAPSHOT"

Results in the following error
FAILURE: Build failed with an exception.

* What went wrong:
Could not resolve all dependencies for configuration ':compileClasspath'.
> Could not find org.scalaz:scalaz-zio_2.12:0.1-SNAPSHOT.
  Searched in the following locations:
      https://jcenter.bintray.com/org/scalaz/scalaz-zio_2.12/0.1-SNAPSHOT/maven-metadata.xml
      https://jcenter.bintray.com/org/scalaz/scalaz-zio_2.12/0.1-SNAPSHOT/scalaz-zio_2.12-0.1-SNAPSHOT.pom
      https://jcenter.bintray.com/org/scalaz/scalaz-zio_2.12/0.1-SNAPSHOT/scalaz-zio_2.12-0.1-SNAPSHOT.jar
      https://repo1.maven.org/maven2/org/scalaz/scalaz-zio_2.12/0.1-SNAPSHOT/maven-metadata.xml
      https://repo1.maven.org/maven2/org/scalaz/scalaz-zio_2.12/0.1-SNAPSHOT/scalaz-zio_2.12-0.1-SNAPSHOT.pom
      https://repo1.maven.org/maven2/org/scalaz/scalaz-zio_2.12/0.1-SNAPSHOT/scalaz-zio_2.12-0.1-SNAPSHOT.jar

Also, cannot find scalaz-zio on maven central by searching for it.

Thanks, having it working now

@mantisMolloy the scalaz-zio is published to Sonatype repository which is not searched by sbt, add the following line to make it work:
resolvers += Resolver.sonatypeRepo("snapshots")


add css for visited articles

If the objective is to make the title for search results change color after visiting, and no other links, it might be better to make the rule:
.search_item h2 a:visited {
	color: #629BB8;
}

Which limits it to the class for a search result, rather than the layout element which a white background.  Are these the only links we need to worry about?
The color looks nice, my only concern might be that it is very similar to the deleted item color, but I'm not sure if that is a problem.  You can see a deleted item here ("singleETD" with 0 children):
https://cdr-qa.lib.unc.edu/list/uuid:ad44255f-4263-4d26-84f7-8d3de9de4773
What do you think?

@bbpennel That's a good idea. What do you think of this lighter gray?

Hmm, it stands out, but grey to me indicates that something is not active or clickable.
Tried to find some examples, a surprising number of sites don't change colors it turns out.  Google search results are a fairly minor shift from #190BB8 to #8B0099, so from a bluer tone to a more purplish one.  Stackoverflow also goes from a blue with green in it to a darker blue (#0077CC => #0059A1), wikipedia goes from a blue with red and green components to one that is mostly blue, a little red, and darker.
So the trend seems to be to shift to a cooler and darker tone.  Our links are currently a dark blue-green, which is a little unfortunate since we can't darken much.  It'd be nicer if we had different base colors for header links (lighter and more blue).  Unless we want to try some larger change though, we might want to do something in the blue/purple range?

This was a pretty interesting article, although I don't think we want to try adopting those kinds of standards currently: http://webaim.org/blog/wcag-2-0-and-link-colors/

@bbpennel updated the link color


Updating the section for private link

I would suggest the section https://github.com/SAP-samples/btp-build-resilient-apps/blob/main/tutorials/05_setupconnectivity/privatelink.md (section Bind application to Private Link service) to be moved or referenced in https://github.com/SAP-samples/btp-build-resilient-apps/blob/main/tutorials/06_deploycapapp/README.md (section 14) or at least put there warning to adjust the MTA deployment descriptor

thanks @pavol-amz for the feedback, I made a warning and reference!


Retrain model LightGlue with ourdataset

Hello everyone, I am currently studying to retrain the LightGlue model, but right now I don't know what information I need to proceed with retraining the LightGlue model. Could anyone explain to me? Thank you very much

You can train LightGlue on just a set of images with homography adaptation. The best training requires posed images with depth maps. This can, for example, be generated with COLMAP SfM + MVS.

You can train LightGlue on just a set of images with homography adaptation. The best training requires posed images with depth maps. This can, for example, be generated with COLMAP SfM + MVS.

Thank you for your feedback. So, to retrain LightGlue, I need images with orientation and depth maps, right? Could you provide more information about the required format of the data


Could not install from "node_modules/react-navigation/react-native-tab-view@github:react-navigation/react-native-tab-view

Current behaviour
I am trying to run `npm install` on my React Native project. I am running React Native version 0.53.3 and react-navigation version 1.5.11 and I get this error:
npm ERR! code ENOLOCAL
npm ERR! Could not install from "node_modules/react-navigation/react-native-tab-view@github:react-navigation/react-native-tab-view#36ebd834d78b841fc19778c966465d02fd1213bb" as it does not contain a package.json file.

Expected behaviour
My team ran into this issue last year and it seems that what fixed it was to do add "react-native-tab-view": "^1.3.2",, because the project did not have it inside the package.json file before. I expected for it to fully run npm install afterwards.
 Closing since it's not actionable for me.


config(apps/jenkins): add codecov token for ticdc

/hold should merge at night, since it will cause jenkins redeploy
/lgtm

/approve

/unhold


Add session property task_max_memory

this session property is equivalent to task.max-memory
usage:
set session task_max_memory='1GB';
set session task_max_memory='256MB';
reset session task_max_memory;

@cberner do we need this with the new memory manager in #2873?

Probably not. My plan was to remove the task limit, and instead you would set the per-query-per-node limit. This also isn't a safe session property to add, as users could set the limit arbitrarily high. I think if we're going to add this it should return the minimum of the default (config) value and the session value

It will be good to be able to set per-query-per-node limit.
Because there are various queries(maybe very big) in our cluster, and we can not decide what is the proper value of this property, so we have to set task.max-memory quite high to avoid OOM failure.

@yuananf yep, we face the same issue. I'd rather not merge this, since "task.max-memory" is being replaced by the "query.max-memory" and "query.max-memory-per-node" configs, but feel free to add session properties for those configs! Or if you really need this, please re-open and I'll take another look.

Thanks, I'll have a look at the new configs.


Boilerplates missing required title HTML element

The title element is required in standalone pages by the HTML spec, so I think adding it would help further deabstract from the code one would write in a real project.

Very good point :)


Resource name too long, cannot create taskrun

Expected Behavior
The pipelinerun automatically creates taskruns for every task. It sets up the taskrun name using -. The pod name will be even longer with --pod. When then name is longer then 63 characters it fails to setup the taskrun.
I think we should have some logic to automatically truncated the names, or at least we should create shorter names, e.g. instead of including the whole pipeline name include the uuid.
Actual Behavior
Pipeline fails to reconcile.
Events:
  Type     Reason                 Age                    From                 Message
  ----     ------                 ----                   ----                 -------
  Normal   PipelineRunSucceeded   7m20s (x20 over 14m)   pipeline-controller  PipelineRun reconciled successfully
  Warning  TaskRunCreationFailed  6m50s (x3 over 6m50s)  pipeline-controller  Failed to create TaskRun "health-helm-cd-pipeline-run-28jrg-source-to-image-health-frontend": Internal error occurred: admission webhook "webhook.pipeline.knative.dev" denied the request: mutation failed: Invalid resource name: length must be no more than 63 characters: metadata.name
  Warning  PipelineRunFailed      6m50s (x3 over 6m50s)  pipeline-controller  PipelineRun failed to reconcile

Steps to Reproduce the Problem

Define a pipelinerun so that pipelinerun name + task name are longer than 63chars

Additional Info
I initially didn't hit this as I was using static pipelinerun names. When I switched to generateName, it added enough characters to go over 63.

health-helm-cd-pipeline-run-28jrg-source-to-image-health-frontend
interesting :thinking:
specifically talking about the automatically created taskruns (generated by a pipelinerun) we could probably give them way less meaningful names and get away with it. but we also need a solution names ppl explicitly set :thinking: :thinking::thinking:, tho maybe it's better to tell the user their name is too long and let them pick something else if they are creating a taskrun or pipelinerun manually?

FWIW we've run into similar issues in the context of Jenkins X integrating with Build Pipeline. For now we are leaning towards generating machine-friendly unique names for the CRDs, and then storing metadata somewhere else to associate the user-specified names with those generated names.
Perhaps an additional label or description field on the CRDs that users can set to whatever they'd like would be useful? If the full name is stored somewhere, then maybe truncating if it's too long for the name field seems is a decent compromise? Otherwise an explicit error message seems fine.

Yeah, I'm a +1 on distinguishing between "name of the actual CRD" and "display name for human beings".

Perhaps an additional label or description field on the CRDs that users can set to whatever they'd like would be useful?

That's a good idea!

This actually gets hairier - the step names for things like copying from a bucket or checking out git source etc result in containers with really long names as well.

This actually gets hairier - the step names for things like copying from a bucket or checking out git source etc result in containers with really long names as well.

hm interesting point - okay controversial idea, do steps actually need names? what if we numbered them sequentially instead :thinking: (+ @ImJasonH @shashwathi @pivotal-nader-ziada @tejal29 @vdemeester )

I like step names because it makes debugging easy. We can consider truncating resource names if it's too long.

I like step names because it makes debugging easy. We can consider truncating resource names if it's too long.

If the steps had clear names like step-1, maybe it would still be easy to debug?

we can make sure generated name, for steps or taskruns, have a max number of characters

(Added some more detail in the description re. the "names" and "resources" effected by this issue)

/assign
worked with @bobcatfish on idea on how to fix this issue, PR coming soon


Dark mode Function Node background - Urrg !

Problem/Motivation
After latest update, the Function Node background has changed from a nice Black to a lower contrast Grey. It makes it harder to see text

Node-RED version: V6.1.3
Platform/OS: Hass.io / Home Assistant
Browser: Chrome

Steps to reproduce
Update to V6.1.3 and turn on dark_mode

Proposed changes
Please restore Function Node Background Colour.

It's gonna be part of the next release. :wink:

@bonanitech
Excellent - Much Appreciated  👍👍


Nifi-1069 fix init status exit code and restart

This pull-request continues the work on NIFI-1069 which was reopened at:
https://issues.apache.org/jira/browse/NIFI-1069?focusedCommentId=15604506&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15604506
This is targeting the @JPercivall  comment - NiFi restart does not work anymore.
Originall pull request (which had already been merged):
https://github.com/apache/nifi/pull/1093
--
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:

[x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?

[x] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

[x] Has your PR been rebased against the latest commit within the target branch (typically master)?

[ ] Is your initial contribution a single, squashed commit?

For code changes:

[x] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
[ ] Have you written or updated unit tests to verify your changes?
[ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
[ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
[ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
[ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?

For documentation related changes:

[ ] Have you ensured that format looks appropriate for the output in which it is rendered?

Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.

Reviewing

+1
Visually verified code and did a checkstyle build. Ran the nifi.sh commands and verified each worked as expected. Thanks @michalklempa, I will merge it in.


How to add username/password into client/openai_completion.py when calling triton inference server?

It seems that openai_trtllm does not provide username and password arguments which can be provided to triton inference api.

/close


ImportError: cannot import name 'get_authenticator_from_environment'

Hi Team,
I tried to follow your doc:
https://github.com/IBM/python-sdk-core/blob/master/Authentication.md
and got the following error.
In [1]: from ibm_cloud_sdk_core.authenticators import get_authenticator_from_environment
   ...:
---------------------------------------------------------------------------
ImportError                               Traceback (most recent call last)
<ipython-input-1-e931c8235af5> in <module>
----> 1 from ibm_cloud_sdk_core.authenticators import get_authenticator_from_environment

ImportError: cannot import name 'get_authenticator_from_environment' from 'ibm_cloud_sdk_core.authenticators' (/usr/local/anaconda3/envs/finimp/lib/python3.8/site-packages/ibm_cloud_sdk_core/authenticators/__init__.py)

Seems there is a bit of misalignment because get_authenticator_from_environment is located in the ibm_cloud_sdk_core, not ibm_cloud_sdk_core.authenticators.
Also it would be great to reflect this type of authentication in the main docs, because it was not straightforward to find above mentioned one.
https://cloud.ibm.com/apidocs/natural-language-understanding/natural-language-understanding?code=python#authentication
https://github.com/watson-developer-cloud/python-sdk#iam

Looks like I docs still don't reflect the suggested change. Moving this to the backlog since it should be a fairly simple doc change

Included this change in this PR: https://github.com/IBM/python-sdk-core/pull/104


⚠ Bofrost.be has degraded performance

In 1362b0c, Bofrost.be (https://www.bofrost.be) experienced degraded performance:

HTTP code: 200
Response time: 1176 ms

Resolved: Bofrost.be performance has improved in 23f24cf.


Masks in hierarchy issue

I've got an odd issue with multiple masks in the hierarchy.
When I apply a mask to a container, if any sub containers contain masks, the sub container masks appear to move with the parent mask.
I expected the sub container mask to remain stationary as I move the parent mask.
NOTE: This doesn't happen with older versions of PIXI - this works as I expected with version 3.0.2. The version of PIXI I see this on is version 4.2.2
Here's the sample code I've used.

cat.png is the background image
graphics is the stationary sub container mask
horse.png is the mask I am moving around

Thanks.
 <html>
<head>
   <title>Mask Issue</title>
   <script src="pixi.js"></script>

</head>
<body>

   <script>

   var gameContainer = new PIXI.Container();
   var renderer = PIXI.autoDetectRenderer(800, 600);
   document.body.appendChild(renderer.view);

   var subContainer = new PIXI.Container();
   gameContainer.addChild(subContainer);

   var cat = new PIXI.Sprite.fromImage("cat.jpg");
   subContainer.addChild(cat);

   var graphics = new PIXI.Graphics();
   graphics.beginFill(0xFFFFFF, 1);
   graphics.drawRect(50, 50, 200, 200);
   graphics.endFill();
   subContainer.mask = graphics;
   subContainer.addChild(graphics);

   var horse = new PIXI.Sprite.fromImage("horse.png");
   gameContainer.mask = horse;
   gameContainer.addChild(horse);

   requestAnimationFrame(animate);

   function animate(time)
   {
      requestAnimationFrame(animate);
      var radian = Math.PI * 2 * time / 1000;
      var radius = 100;
      horse.position.set(radius + Math.sin(radian) * radius, radius - Math.cos(radian) * radius);

       renderer.render(gameContainer);
   }
   </script>

   </body>
</html>

I assume this isn't expected behaviour?

Hi @BulletproofMike , na this look s a little weird! Definitely a bug to be squashed!

ahha! this should be fixed in the dev branch now :)


Paythrough crashes if any channel is not in normal state

When a channel is in CHANNELD_AWAITING_LOCKIN ,listpeers does not return scid. I made this change locally to fix it:
channels = list(filter(lambda channel: channel['state'] == 'CHANNELD_NORMAL'  and channel['short_channel_id'] != scid,
channels))
Also had to comment out these lines:
if len(channels) != channels_length-1: # We should have one less channel
return { 'code': -1,
'message': f'Short channel id {scid} is not valid' }
It works for me locally now but creating issue just to let you and others know if they encounter it.

Thank you for the bug report!
This should be fixed in 18654fd339b1264c93031f3469180bd819b903b0.


Restructure Endpoint generation to allow dynamic and stired structures

This PR  is mainly updating endpoint structuring. Additionally some smaller things go also added that were not that easy to cut out again. I tried to separete these things in own commits, so the commits can be used for review.
All details:

Remove some console logs
Rename eventId property to id like on other servers
Steamline property naming for Event related structures
Allow to define discoveryCapabilities structure when getting pairing code
Enhance Array type
Rework Endpoint structuring

Composed devices should only be used on an Aggregator
introduce a custom uniqueId when adding endpoints to be used for endpoint storage
add removeBridgedDevice to remove a device from a bridge
Restructure endpoint structuring to split responsibilities to where they belong
Structure changes are reported back via a structure-changed-callback to commissioning server to update structures on changes
update server/client-lists-attributes when adding/removing clusters
determine a unique endpoint id key from custom-unique id or serialnumber or unique id
leave logic to update partslist on endpoint
Add EndpointStructure class on InteractionServer to hold and handle all relevant endpoint structure data and move logic from endpoint to this
Add Event relevant methods and structures here too already (used later)
Endpoint structure is updated on structure changes

Update examples and add unique id parameter
Changelog

closes https://github.com/project-chip/matter.js/discussions/173

Topics where I wouod be interested in feedback and potential alternativ ideas:

method namings - I'm not too happy with some of the new method names -especially when it comes to that endpoint structure stuff ... so if anyone has better names ... tell :-)
I thought about cutting out the "EndpointStructure" class into an own file but in the end it is specific to InteractionServer, so I ended in staying there.
The unique IDs that are compiled get a bit long potentially ... see e.g. https://github.com/project-chip/matter.js/pull/187/files#diff-7bc184520022fa8b621504a4aea223c78eab76837920a5a88da0554e517809cbR1566 ... On one side this should not be an issue ... we could also shorted the "id source" ... ?!
A big adjustment here was to separate the parts of it that belongs to endpoint vs the structure topics that are just relevant for the commissioingserver ... In the end it is a "revert a former change" where I moved many things to endpoint. In the end too much.

* The unique IDs that are compiled get a bit long potentially ... see e.g. https://github.com/project-chip/matter.js/pull/187/files#diff-7bc184520022fa8b621504a4aea223c78eab76837920a5a88da0554e517809cbR1566 ... On one side this should not be an issue ... we could also shorted the "id source" ... ?!

Forgot to respond to this part, not sure there's anything too bad about the long identifiers but if they'll appear in logs a lot maybe worth shortening.  Here's some ideas:
basicInfoSerialNumber_node-matter-0000-customUniqueId_test-unique-id -> serial:node-matter-0000/custom:test-unique-id
basicInfoSerialNumber_node-matter-0000-index_0-customUniqueId_3333 -> serial:node-matter-0000/[0]/custom:test-unique-id

I decided against ":" because will be used as potentially filename :-) Thats why "_" renaming make sense

@lauckhart please re-review. Updated

I decided against ":" because will be used as potentially filename :-) Thats why "_" renaming make sense

Yeah I figured something like that.  Character mix isn't super important I was just offering up shorter versions.  Although I do assume files would be urlEncoded or somesuch regardless so we don't need to constrain user IDs.


[WFLY-15222] Drop JAX-RS model transformers prior to 3.0.0

Jira issue: https://issues.redhat.com/browse/WFLY-15222

Hi @jamezp , when you have a chance, could you review this? thanks


Remove fomantic api module

I'm 95% sure this module is unused. We do not call .api() anywhere in our JS and that seems required for that module to work as far as I can tell. I think the only danger is if another fomantic module depends on it, so we should carefully check everything.
@wxiaoguang do you recall any place where this module could still be used?

I am 100% sure it is widely used. apiSettings

Guess I revisit later.

Pushed some WIP JS, it's not working currently.

Current challenge is to find out what dropdown wants in return to query argument:


Note about System.import

I was reading through the migration guide and noticed the section about System.import.
When reading it it sounds like System.import is already a thing and the new specified way of how to do dynamic loading, but it is not and probably never will be in its current form (see whatwg/loader#149, whatwg/loader#147 and https://github.com/tc39/proposal-dynamic-import).
I see that some users probably already use System.import and it's nice webpack supports the current spec, BUT It would probably be good to add a note that says that this is not a final specification and that it is very early stage and will be changing in future. I think users should be aware of that so that they can decide if they take the risk of a evolving and changing spec.
I also saw some other sections that said TODO document System.import which maybe should add the same.

See https://github.com/webpack/webpack/pull/3413, support for import() will probably land in the next beta.

Yeah, the current beta implements import(). System.import() can be considered deprecated now.

pull request #499 fixes the deprecated System.import stuff in the migration guide.

Closing since #499 was merged.


uni-directional lane connections

fixes #784. please see issue for more details.
Edit: as a happy coincident this change also fixes the issue with lane connector tool that got confused with bidirectional lanes.
every connection made by lane connector used to be bidirectional. Now its uni-directional unless user creates connection both ways.
highlights:

moved connection data out of obsolete Flags class and into LaneConnectionManager class.
we now need to differentiate between HasConnections() and HasOutGoingConnections().
for the sake of backward compatibility, when I load legacy save I restore the connections both ways.
I did not change the Routing Manager except for renaming a variable name to be more accurate.

code design: There are 3 layers:
UI layer (Lane Connector Tool) : no modification was needed.
Middle layer (Lane Connection Manager) : performs all the validations and checks before passing calls to base layer
Base Layer (used to be Flags but now is ConnectionData): handles getting/setting lane connection data only
build: https://ci.appveyor.com/api/projects/krzychu124/tmpe/artifacts/TMPE.zip?branch=bidirectional-fix-784
the commits are a mess and I was unable to fix them. just review all the commits together.

The code is complete. this is draft just because I want to perform a few more tests.

OK I done my tests. deleting other segments and bidirectional lanes work well.

@aubergine10 @krzychu124 @kvakvs  I merged with master and it works.

master currently seems a bit problematic but this PR does not add any problems.

https://github.com/CitiesSkylinesMods/TMPE/blob/6a55d7f43f5e164952f947678d77eddca63be345/TLM/TLM/Manager/Impl/LaneConnectionManagerData/ConnectionData.cs#L30
Wouldn't it be better to have separate instances of this object for the start and end, like how ExtSegmentEndManager is done? As it stands now, this approach is not friendly to adding new properties, since both start and end properties would have to be created in the same struct.
Also, @krzychu124 expressed concerns about keeping object references in a struct this way. I originally used a struct in my implementation, and switched to a class. My code was much cleaner afterwards, so I think it was a good change despite my initial concerns about overhead.

Also, I really do think there should be separate instances of the array element for the start and end. Otherwise, adding new properties would quickly become very messy.

you can add your new properties to  LaneConnectionData.

What I think could be better here is that the collection should be directly in LaneConnectionManager. It is literally LaneConnectionManager's job to maintain this data

The code to add/remove connections can fail in a lot of ways and is confusing to understand if mixed with other code. I created a layer of abstraction to hide this complexity.

I just realized that I misread the code. That is my fault due to having too many things going on, for me to focus properly.
I can't add the property to LaneConnectionData, because there is an instance for every lane to which a connection exists. LaneConnectionFlags aren't per individual connection; they are per lane end.
Does this all make more sense now?

To further clarify, this is what my implementation looks like:
classDiagram
    LaneConnectionManager "1" --* "MAX_LANE_COUNT * 2" LaneConnection
    LaneConnection "1" --o "0..*" NetLane
    class LaneConnectionManager {
        +LaneConnection[] LaneConnections
    }
    class LaneConnection {
        +uint[] connectedLanes
        +LaneConnectionFlags flags
    }

I vote for the third because, what if someone wants to add another such property later? My need merely exposes the fact that lane ends are a distinct entity that needs its own object. It's exactly analogous to segment ends.

Might be a weird question but:
Why don't we make a Dictionary<LaneEnd, ArrayOfConnections>() where LaneEnd is a struct (laneId + bool) with proper Hashcode, Equals and Comparer to get rid of garbage on access?

we don't need to loop through all lanes
checking if lane has any connection would be solved by: _dict.ContainsKey()
adding connection is also easy (check for key then either create array or resize with one more element).
removing (if no more connections remove key)

Also.. another idea: maybe store connections as bi-directional but flag it somehow it is X -> Y, Y -> X or X <-> Y (forward/backward/both). Wouldn't be that simpler to manage? I see that in this impl. removing invalid lane connection is done by looping through ~262k lanes to find all occurrences... Something is not right with the implementation IMO.

Enlighten me if I'm missing something obvious which makes above solutions a no-go

yes you are missing something:

the loop only exists when I am searching for backward connections. for forward connections there is no loop. using dictionary does not change this.
Dictionary would result into a lot of memory memory fragmentation. I like array of struct is faster.

removing invalid lane connection is done by looping through ~262k lanes to find all occurrences... Something is not right with the implementation IMO.

I have removed backward connections. So that is why I am searching.
the old code does loop through the lanes of the deleted node/segment. I don't know how is that OK since you are assuming that the data for deleted segment is valid. but if I make that assumption I can reduce my search.
I can also store backward lane connections so that can also make my search smaller.
This is a long time ago and I did try to do the things you told me but it didn't work out somehow. I am sure if I try hard enough I can make some improvements. specially if I store backward lane connections. I even tried to cache the number of connections at node but that didn't worked out so good either. maybe I can work on that solution more.
This is not performance critical part of the code so I didn't though its worth too much effort or complication but I can try harder if you want.

Also.. another idea: maybe store connections as bi-directional but flag it somehow it is X -> Y, Y -> X or X <-> Y (forward/backward/both)

Not sure what you exactly mean by this. but I can store both forward and backward connection but flag one of them as disabled     (uni-directional) or enable both of them (bi-directional). that way I don't have to do backward searches and can keep the code more or less like it was before.

Dictionary would result into a lot of memory memory fragmentation. I like array of struct is faster.

What memory fragmentation? Why do you care about it? A lot of new code creates garbage on use (e.g. LaneConnectionManager.GetLaneConnections() -> Select == laneID closure capture + ToArray()).
Why do you really need two arrays of start and end connections in SourceLaneConnectionData? I understand you moved bool from initial lane index calculation level lower but IMO it makes everything more complex.
What's the benefit/use case of storing all lane connections from both ends of the lane? You need to pass bool true or false to get specific connections since all operations are done around the node or two or more segment ends anyways?

A lot of new code creates garbage on use

The performance critical part of the code does not create garbage (i hope!).
@krzychu124 Don't you think array of struct is faster to access than dictionary?
I can understand that you don't like me to loop through many lanes but dictionary does not solve this problem.

@krzychu124
I can understand that you don't like my approach having array of start/end lane connections inside a struct:
struct SourceLaneConnectionData {
            public LaneConnectionData[] StartConnections;
            public LaneConnectionData[] EndConnections;

But I don't understand why?! I really want to do what you want me to but it there should be a justification. You need to give me a solid reason. it would be unwise to change code based on feelings.
This is what I understand from the approaches you have suggested to me so far:

make SourceLaneConnectionData a class inside struct.
- Advantages : it gives you a good feeling
- disadvantages : memory fragmentation - extra if condition for null check - more complex code.
instead of array use dictionary:
- Advantages : it gives you a good feeling
- disadvantages : memory fragmentation - more code - slower speed.

PS: I want to emphesize again that this is a separate debate from the problem of looping through all the lanes. none of the solutions above solve that problem.

What's the benefit/use case of storing all lane connections from both ends of the lane? You need to pass bool true or false to get specific connections since all operations are done around the node or two+ segment ends anyways?

@kianzarrin That's the main question. Why your solution is better than that was used before. Keep in mind we are connecting lane ends, not whole lanes, that's why I asked.
.
.
About memory fragmentation.:

SourceLaneConnectionData[] - constant 2MB size - values containing 2 pointers to arrays, nulls initially (still takes memory),
Dictionary<laneEnd(struct), (connectedEnd[] or struct)>. - grows when needed, values are internally stored in the array

Data is fragmented in both solutions no matter how hard you try.

extra if condition for null check

Really? I see you are doing that in your code all the time?

Anyways, after browsing the new flow I feel like there is too much things hidden by the ConnectionData layer, especially performance issues. See, LaneConnectionManager.HasOutgoingConnections() - why that method expects it will get connections with invalid lanes (also, invalid lane will trigger ConnectionData.RemoveConnections(), so loop through all lanes )??
Check references from RoutingManager, how it uses lane connections and why I'm thinking this new approach is way too slow.
Before it was bunch of null checks + access to by index to array to get info if there are connections, now you need too loop for outgoing connections and worse, loop through all segments to get all lanes to get info if there are not incoming connections.
Idea how it could work (not saying it's the best and should be used)
I'll explain how I see it if we really want to completely replace how old Flags lane connections will be stored:

make readonly struct LaneEnd {uint: laneID + bool}, generate hashcode, equals + Comparer (2 or 3 clicks in IDE to do everything automatically) - you can pass it later as in arg without risk of defensive copies...
connection data as struct, will have one array containing struct values representing connection, in your code it's currently only laneID, which is cool, I'd add info flag for bi-directional connection, extendable later with more props, (instead of array it could be FastList, but I'm not sure if we really need such level of caching, as hardcore option there is another option -> poolable... ConnecitonData struct but with FastList instead of array since array is no cacheable 😂 )
alternatively, one array for one-way connections, second one for bi-directional (same lane id(LaneEnd) cannot be in both at the same time)
add flag in the connection data holding an info if contains any bi-directional connections, if separate array for bi-directional connections not used (then just check for length).

Use cases:
To add outgoing connection to the lane end:

check if key exists, add to connections array otherwise create new LaneEnd connections with that connection item,

To remove outgoing connection from the lane end:

if no other connections left throw away the key and value from dictionary, otherwise remove it from array of LaneEnd,

To remove all outgoing connections from the lane end:

if no bi-directional connections, throw away the key and value from dictionary

To remove all connections of the lane end:

if no bi-directional connections see above, otherwise find bi-directional connections (or use second array - might be easier) and just remove it from the other end

To add incoming connection to the lane end -> just don't! Add outgoing connection from the other lane or convert existing connection to bi-directional!
To check if there are any connections with the lane end:

just check if key exist

To check if there are any outgoing connections from the lane end:

see above

To check if there are any incoming connections to the lane end:

check if contains bi-directional connection, that's all.

Important things:

validate connections (+lane IDs) after savegame load,
update lane ends when they are removed (at a segment level). don't let the connections to contain invalid data at any time - will reduce a ton of checks. If there is 0.001% chance of invalid lane why not make it zero and throw away the check?

Is there possibility that other mod alters something and doesn't trigger whatever causes geometry update (ie. could errors creep in due to other mods)?

To add incoming connection to the lane end -> just don't! Add outgoing connection from the other lane or convert existing connection to bi-directional!

How would the bi-directional work in terms of pathfinder (or wherever else lane connection data is on hotpath)?
For example, if just using the bidirectional flag, train on bidirectional line entering from segment A would have to check segments B and C (...etc) to see if they have a bidirectional connection to it's incoming track?
IMO bi-directional should have an outgoing connection from each lane, both marked as bidirectional so that no matter which way you come at it you see the connection and know it's bidirectional.
Creating / removing / updating lane connections is very rare - only happens on (de)serialisation and user-interaction of some sort (disasters too, but those are also rare); everything should be geared to performance of patfhinding, overlay rendering, and anything else that would be considered "hot path" access of the connection data.

@krzychu124

LaneConnectionManager.HasOutgoingConnections() - why that method expects it will get connections with invalid lanes

It was a long time ago. I don't remember. I think I was trying to improve performance. or maybe this is how I removed backward lanes connections for deleted segments.

Why your solution is better than that was used before.

using 3 dimensional array is confusing and venerable to make mistakes if you get the indexes wrong. here making mistake is hard because of type safety.

Lane connection data is used by rendering (current impl. is not the best in term of performance)

And also used by routing manager but that is also not super performance critical because it is only called after user input. as long as its a little bit fast its acceptable.
About memory fragmentation.:

SourceLaneConnectionData[] - constant 2MB size - values containing 2 pointers to arrays, nulls initially (still takes memory),
Dictionary<laneEnd(struct), (connectedEnd[] or struct)>. - grows when needed, values are internally stored in the array

OK Dict approach sacrifices speed to reduce memory.

@krzychu124 I resolved the performance issue of HasLaneConnections(). The code is working now. should I change the implementation to use your suggested dictionary?

Tests:
1- deleting a road will remove all lane connections to/from that road: In the image bellow I bulldozed the top segment and buses (which may ignore lane arrows) can go forward proving lane connection has been destroyed.

2- bidirectional train tracks: hard to show in pic but they work comfortably.
3- train station : in the test bellow I test the lane transitions using AN track feature (there is a track iff there is a lane transition) :

My only concern is the button left picture.

@krzychu124 if the code is acceptable can you please approve it before more conflicts appear?

There will be merge conflict after #1465 which fixes issue with the new Version property in SerializableDataExtension

And also @aubergine10 planned to do a bit more stuff in <IP_ADDRESS> (probably some of them will be pushed for later anyways) before releasing TEST as stable and moving to next "major version".
I don't plan any changes to lane connector code, and if there will be any necessary (for supporting Aircrafts) your PR will be merged first anyways.
Personally, I don't plan any fixes for <IP_ADDRESS> as I'm focused on support for Airports DLC/Aircrafts in general

IMO we should be looking to push <IP_ADDRESS> to STABLE as soon as we're happy it's got no major issues.
I can change <IP_ADDRESS> milestone to <IP_ADDRESS> for this PR and continuation of options refactor.
Does this PR facilitate what @Elesbaan70 is planning for the displaced traffic lights stuff?

Does this PR facilitate what @Elesbaan70 is planning for the displaced traffic lights stuff?

It does not. But based on further discussions on Discord, that may be moot, so I'd say it's up to @krzychu124 to decide if that matters.

@krzychu124 Can I merge now?


gazebo_version_helpers failed to build

Hi
I am trying to build the packages using catkin build, I am using ros-noetic on ubuntu 22.04, with gazebo-classic, however the build fails due to issue in gazebo_version_helpers. Could you please help?

Hi,
The last version tested was noetic on Ubuntu 20.04. I have it on my schedule to remove gazebo_version_helpers some time in the next couple of months. In case you end up doing it before, it would be nice if you could post a PR. It's basically just removing the #ifdef statements, replace the function calls by the gazebo ones, and drop support for old gazebo versions.
Or just fixing the compiler issue at hand.
Sorry I can't be of more help right now, I currently lack the time to update these packages. But it's on my horizon.

It seems that we both lack the time for this simple task :)

Yes I'm sorry, it's been so busy here. It is moving up my to-do list though, I'm working my way through to get around to looking after my packages (long overdue). I'm planning to migrate all ROS packages to ROS2 within the next 1-2 months. Fingers crossed this timeline works out ;)


Missing automatic provisioning at scale with Azure IoT Edge using EST protocol

Hi,
based on samples I was not able to use the native certificate management feature of Azure IoT edge - EST endpoint implementation
https://learn.microsoft.com/en-us/azure/iot-edge/tutorial-configure-est-server?view=iotedge-1.5
Is this possible with EZCA?

Hi Unfortunately we currently do not, most of our customers use our provisioning APIs to create devices, but thanks for bringing this issue to our attention, we will implement it in the coming weeks and update this thread issue when implemented

Hi this is now possible with EZCA, we have also created a sample for how to issue EST certificates in code: https://github.com/markeytos/EST-Certificate-Client


Documentation website design distorted on some pages

What
Documentation website design distorted on some pages
Details

Browser + version: Google Chrome Version 80.0.3987.87 (Official Build) (64-bit)
Device: MacBook Pro (Retina, 15-inch, Mid 2015) Version 10.15.3 (19D76)
Screenshots

Thank-you for this, @usameavci !
note to self for monday:

doesn't appear to happen with chrome 78
does happen on chromium 80
doesn't happen on firefox 73
happens at the (min-width: 46.25em) breakpoint
probably to do with o-grid
fix probably needs to be on o-layout

Thanks for reporting 😊  closing as this is fixed now in Chrome 80


Infer test group name directly from test file path

Test Group Name Generation

uses the relative file path as test group name
delimiter choice is '~' ('.' is reserved by gtest, '/' is reserved by file path)
current -GROUP property is not removed for backward compatibility (is this necessary?)

Note: some characters such as : and - result in tests not being actually run (some current test cases are like this)

Example
the file test/test_files/tck/match/match8 now has test group name tck~match~match8
Todo
delete -GROUP from all existing test files (do we want to do this?)

Also, can u revisit the false positive issue? We'd better understand what's acceptable directory and file naming conventions under test_files.


Module import failing due to SyntaxError

When using import mangadex in python, the import fails due to a syntax error.
Python version: 3.10.2
To Reproduce
Steps to reproduce the behavior:

Enter python shell
import mangadex

Expected behavior
The import should work
Traceback
>>> import mangadex
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/home/marc/.local/lib/python3.10/site-packages/mangadex/__init__.py", line 8, in <module>
    from .api import (Api)
  File "/home/marc/.local/lib/python3.10/site-packages/mangadex/api.py", line 4
    from __future__ import absolute_import
    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
SyntaxError: from __future__ imports must occur at the beginning of the file

Solution
Move the line from __future__ import absolute_import above import re in api.py
"""
"""
from __future__ import absolute_import
import re #for validating email and prevent spam
...

Hey, I've now tracked the issue with this, and turns out I didn't push the fix to the PyPI (this issue was noticed before), this was an oversight on my part. Thanks for letting me know.

No problem, thanks for pushing the fix so quickly.

Thanks to you for bringing this up. If you find more issues o want to implement something, feel free to make a PR.


Upgrade A couple of our dependency libraries

reference: https://github.com/thenewboston-developers/Account-Manager/pull/386/files
Upgrade the following packages (if they exist on the website)

When you finish, make sure the app doesn't break, and run npm run lint, and make sure there are no linting errors. If there are, fix them

👋

react-scripts require eslint version 6.6.0, so made that change. Rest of them are updated.

As per this, https://github.com/facebook/create-react-app/blob/master/CHANGELOG.md for eslint 7+ we need to update the react-scripts, let me know if I should proceed with this