parseBbCode Cannot read property 'replace' of null

node_modules/steam-user/components/chatroom.js:571
        str = str.replace(/\\\[/g, replacement);
                  ^

TypeError: Cannot read property 'replace' of null
    at parseBbCode (node_modules/steam-user/components/chatroom.js:571:12)
    at SteamUser.<anonymous> (node_modules/steam-user/components/chatroom.js:66:32)
    at handlers.forEach (node_modules/steam-user/components/classes/HandlerManager.js:37:12)
    at Array.forEach (<anonymous>)
    at HandlerManager.emit (node_modules/steam-user/components/classes/HandlerManager.js:36:12)
    at SteamUser._handleMessage (node_modules/steam-user/components/messages.js:544:24)
    at SteamUser._handleNetMessage (node_modules/steam-user/components/messages.js:470:7)
    at SteamUser.processMulti (node_modules/steam-user/components/messages.js:571:9)
    at SteamUser.<anonymous> (node_modules/steam-user/components/messages.js:565:16)
    at handlers.forEach (node_modules/steam-user/components/classes/HandlerManager.js:37:12)

I don't know what message caused it though.

Looks like it was an incoming chat-room message, but message was null. I would guess a EChatEntryType other than Chat? I didn't account for that. A EChatEntryType of Typing in an incoming friend message has message as an empty string, but maybe there's some other type that sends null instead..

Fixed in v4.2.1.


fix: trigger ci

Proposed behaviour

Current behaviour

Checklist

[ ] Release notes (Conventional Commits)
[ ] Unit tests
[ ] Readme updated

Additional context

Testing instructions

:tada: This PR is included in version 1.10.1 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


About shadow flickering

Is there a good way to prevent flickering of distant shadows?

Hi,
Shadows are a complex topic. You can play with the bias.

Hi,
Shadows are a complex topic. You can play with the bias. Another approach is to avoid recalculating the shadow map each time the camera moves, but only when the movement is significant enogh that the cascades should be re-caclulated (for example, you have moved long enough).

I see, it seems like it would be a good idea to recalculate the shadows when there is a big movement.
I'll give it a try.


Export in other VCS formats

Right now gitignore.io supports only git format.
It would be great if it will also supports other VCSes (like Mercurial for example).
I'm not very active Mercurial (or any other vcs) user but I've required that functionality sometimes.
I don't think that is very hard task to refactor your generator.
And that modification will be very helpful.

The only other VCS I've personally used is CVS and that was about 8 years ago.  Since I don't personally use anything outside of git, I would be a very poor high-judgement champion.  If you or someone else wants be that for other VCSes — I'm all for it.  The site name is going to be a little off for the others though :-D.

I just stood up: https://www.hgignore.com.
I right now, it's just a clone of this site, but with my mercurial theme  color (blue).  I still need to figure out if i can translate git templates to mercurial or if I need an entirely new template database.  I'm going to close this task out and add todo tasks on the hgignore repository

Thanks a lot!


Backspace key error

How to reproduce:

Go to a slate block at the end
Type Enter
Type something
Use the Backspace key to delete text until the block is removed
Sometimes you get this error

https://user-images.githubusercontent.com/323385/143418836-81c109d9-ab42-491a-8e34-57bf91f2bd49.mp4

I think this is solved in #195


wireguard: fail to start peers due dns resolution failure

Describe the bug
Some times, my wireguard peers fail to start at boot time due to dns resolution failure
Steps To Reproduce

Configure multiple wireguard interfaces with networking.wireguard.interfaces. The more interfaces the more likely you will reproduce the bug. On my machine, 2 interfaces were enough to reproduce the bug.
Reboot the machine until systemctl list-units --failed shows your wireguard peers fail to start

Expected behavior
The peer should start successfully at every boot.
Additional context
The issue is explained in detailed at https://discourse.nixos.org/t/name-resolution-fails-at-boot-time/33867 but here is a simplified explanation.
The existence of the Wireguard interfaces leads to premature reach of network-online.target. The wireguard peers are started immediately after network-online.target is reached but they fail because the network is not actually online yet.
[root@mymachine:~]# journalctl -u wireguard-wg* -u dhcpcd.service -u network-online.target -b -3
Oct 09 16:11:30 mymachine systemd[1]: Starting DHCP Client...
Oct 09 16:11:30 mymachine dhcpcd[1323]: dhcpcd-9.4.1 starting
Oct 09 16:11:30 mymachine dhcpcd[1340]: dev: loaded udev
Oct 09 16:11:30 mymachine dhcpcd[1340]: DUID <REDACTED>
Oct 09 16:11:30 mymachine systemd[1]: Starting WireGuard Tunnel - wg0...
Oct 09 16:11:30 mymachine systemd[1]: Starting WireGuard Tunnel - wg1...
Oct 09 16:11:30 mymachine dhcpcd[1340]: no valid interfaces found
Oct 09 16:11:30 mymachine dhcpcd[1323]: no valid interfaces found
Oct 09 16:11:30 mymachine dhcpcd[1340]: ens33: waiting for carrier
Oct 09 16:11:30 mymachine dhcpcd[1340]: ens33: waiting for carrier
Oct 09 16:11:30 mymachine systemd[1]: Finished WireGuard Tunnel - wg0.
Oct 09 16:11:30 mymachine systemd[1]: Finished WireGuard Tunnel - wg1.
Oct 09 16:11:30 mymachine dhcpcd[1340]: wg0: waiting for carrier
Oct 09 16:11:30 mymachine dhcpcd[1340]: wg1: IAID <REDACTED>
Oct 09 16:11:30 mymachine dhcpcd[1340]: wg1: waiting for 3rd party to configure IP address
Oct 09 16:11:30 mymachine dhcpcd[1340]: wg0: carrier acquired
Oct 09 16:11:30 mymachine dhcpcd[1340]: wg0: IAID <REDACTED>
Oct 09 16:11:30 mymachine dhcpcd[1340]: wg0: using static address <REDACTED>/24
Oct 09 16:11:30 mymachine dhcpcd[1340]: wg0: adding route to <REDACTED>/24
Oct 09 16:11:30 mymachine systemd[1]: Started DHCP Client.
Oct 09 16:11:30 mymachine systemd[1]: Reached target Network is Online.
Oct 09 16:11:30 mymachine systemd[1]: Starting WireGuard Peer - wg0 - <REDACTED> (<REDACTED>)...
Oct 09 16:11:30 mymachine systemd[1]: Starting WireGuard Peer - wg1 - <REDACTED> (<REDACTED>)...
Oct 09 16:11:30 mymachine wireguard-wg0-peer-<REDACTED>-start[1604]: Name or service not known: `wireguard.example.com:51820'
Oct 09 16:11:30 mymachine wireguard-wg1-peer-<REDACTED>-start[1606]: Name or service not known: `wireguard.example.com:51821'
Oct 09 16:11:30 mymachine systemd[1]: wireguard-wg0-peer-<REDACTED>.service: Main process exited, code=exited, status=1/FAILURE
Oct 09 16:11:30 mymachine systemd[1]: wireguard-wg1-peer-<REDACTED>.service: Main process exited, code=exited, status=1/FAILURE
Oct 09 16:11:30 mymachine wireguard-wg0-peer-<REDACTED>-post-stop[1627]: RTNETLINK answers: No such process
Oct 09 16:11:30 mymachine systemd[1]: wireguard-wg0-peer-<REDACTED>.service: Control process exited, code=exited, status=2/INVALIDARGUMENT
Oct 09 16:11:30 mymachine systemd[1]: wireguard-wg0-peer-<REDACTED>.service: Failed with result 'exit-code'.
Oct 09 16:11:30 mymachine wireguard-wg1-peer-<REDACTED>-post-stop[1629]: RTNETLINK answers: No such process
Oct 09 16:11:30 mymachine systemd[1]: Failed to start WireGuard Peer - wg0 - <REDACTED> (<REDACTED>).
Oct 09 16:11:30 mymachine systemd[1]: wireguard-wg1-peer-<REDACTED>.service: Control process exited, code=exited, status=2/INVALIDARGUMENT
Oct 09 16:11:30 mymachine systemd[1]: wireguard-wg1-peer-<REDACTED>.service: Failed with result 'exit-code'.
Oct 09 16:11:33 mymachine systemd[1]: Failed to start WireGuard Peer - wg1 - <REDACTED> (<REDACTED>).
Oct 09 16:11:33 mymachine systemd[1]: Reached target WireGuard Tunnel - wg0.
Oct 09 16:11:33 mymachine systemd[1]: Reached target WireGuard Tunnel - wg1.
Oct 09 16:11:35 mymachine dhcpcd[1340]: ens33: carrier acquired
Oct 09 16:11:35 mymachine dhcpcd[1340]: ens33: IAID <REDACTED>
Oct 09 16:11:35 mymachine dhcpcd[1340]: ens33: adding address <REDACTED>
Oct 09 16:11:36 mymachine dhcpcd[1340]: ens33: soliciting an IPv6 router
Oct 09 16:11:37 mymachine dhcpcd[1340]: ens33: Router Advertisement from <REDACTED>
Oct 09 16:11:37 mymachine dhcpcd[1340]: ens33: adding address <REDACTED>/64
Oct 09 16:11:37 mymachine dhcpcd[1340]: ens33: adding route to <REDACTED>/64
Oct 09 16:11:37 mymachine dhcpcd[1340]: ens33: requesting DHCPv6 information
Oct 09 16:11:37 mymachine dhcpcd[1340]: ens33: adding default route via <REDACTED>
Oct 09 16:11:37 mymachine dhcpcd[1340]: ens33: rebinding lease of <REDACTED>
Oct 09 16:11:37 mymachine dhcpcd[1340]: ens33: probing address <REDACTED>/24
Oct 09 16:11:38 mymachine dhcpcd[1340]: ens33: REPLY6 received from <REDACTED>
Oct 09 16:11:38 mymachine dhcpcd[1340]: ens33: refresh in 86400 seconds
Oct 09 16:11:42 mymachine dhcpcd[1340]: ens33: leased <REDACTED> for 86400 seconds
Oct 09 16:11:42 mymachine dhcpcd[1340]: ens33: adding route to <REDACTED>/24
Oct 09 16:11:42 mymachine dhcpcd[1340]: ens33: adding default route via <REDACTED>

To work around the issue, meaning: to prevent dhcpcd from leading to premature reach of network-online.target, there are a few possibilities:

Add the wireguard interfaces to networking.dhcpcd.denyInterfaces
Change the default from hardware-configuration.nixnetworking.useDHCP = false;
networking.interfaces.ens33.useDHCP = true;

The result:
[root@mymachine:~]# journalctl -u wireguard-wg* -u dhcpcd.service -u network-online.target -b
Oct 10 09:15:04 mymachine systemd[1]: Starting DHCP Client...
Oct 10 09:15:04 mymachine dhcpcd[1357]: dhcpcd-9.4.1 starting
Oct 10 09:15:04 mymachine dhcpcd[1371]: dev: loaded udev
Oct 10 09:15:04 mymachine dhcpcd[1371]: DUID <REDACTED>
Oct 10 09:15:05 mymachine systemd[1]: Starting WireGuard Tunnel - wg0...
Oct 10 09:15:05 mymachine systemd[1]: Starting WireGuard Tunnel - wg1...
Oct 10 09:15:05 mymachine dhcpcd[1371]: no valid interfaces found
Oct 10 09:15:05 mymachine dhcpcd[1357]: no valid interfaces found
Oct 10 09:15:05 mymachine dhcpcd[1371]: ens33: waiting for carrier
Oct 10 09:15:05 mymachine dhcpcd[1371]: ens33: waiting for carrier
Oct 10 09:15:05 mymachine systemd[1]: Finished WireGuard Tunnel - wg1.
Oct 10 09:15:05 mymachine systemd[1]: Finished WireGuard Tunnel - wg0.
Oct 10 09:15:08 mymachine dhcpcd[1371]: ens33: carrier acquired
Oct 10 09:15:08 mymachine dhcpcd[1371]: ens33: IAID <REDACTED>
Oct 10 09:15:08 mymachine dhcpcd[1371]: ens33: adding address <REDACTED>
Oct 10 09:15:09 mymachine dhcpcd[1371]: ens33: soliciting an IPv6 router
Oct 10 09:15:10 mymachine dhcpcd[1371]: ens33: Router Advertisement from <REDACTED>
Oct 10 09:15:10 mymachine dhcpcd[1371]: ens33: adding address <REDACTED>/64
Oct 10 09:15:10 mymachine dhcpcd[1371]: ens33: adding route to <REDACTED>/64
Oct 10 09:15:10 mymachine dhcpcd[1371]: ens33: requesting DHCPv6 information
Oct 10 09:15:10 mymachine dhcpcd[1371]: ens33: adding default route via <REDACTED>
Oct 10 09:15:10 mymachine dhcpcd[1371]: ens33: rebinding lease of <REDACTED>
Oct 10 09:15:10 mymachine dhcpcd[1371]: ens33: probing address <REDACTED>/24
Oct 10 09:15:11 mymachine dhcpcd[1371]: ens33: REPLY6 received from <REDACTED>
Oct 10 09:15:11 mymachine dhcpcd[1371]: ens33: refresh in 86400 seconds
Oct 10 09:15:12 mymachine systemd[1]: Started DHCP Client.
Oct 10 09:15:12 mymachine systemd[1]: Reached target Network is Online.
Oct 10 09:15:12 mymachine systemd[1]: Starting WireGuard Peer - wg0 - <REDACTED> (<REDACTED>)...
Oct 10 09:15:12 mymachine systemd[1]: Starting WireGuard Peer - wg1 - <REDACTED> (<REDACTED>)...
Oct 10 09:15:12 mymachine systemd[1]: Finished WireGuard Peer - wg1 - <REDACTED> (<REDACTED>).
Oct 10 09:15:12 mymachine systemd[1]: Finished WireGuard Peer - wg0 - <REDACTED> (<REDACTED>).
Oct 10 09:15:12 mymachine systemd[1]: Reached target WireGuard Tunnel - wg0.
Oct 10 09:15:12 mymachine systemd[1]: Reached target WireGuard Tunnel - wg1.
Oct 10 09:15:14 mymachine dhcpcd[1371]: ens33: leased <REDACTED> for 86400 seconds
Oct 10 09:15:14 mymachine dhcpcd[1371]: ens33: adding route to <REDACTED>/24
Oct 10 09:15:14 mymachine dhcpcd[1371]: ens33: adding default route via <REDACTED>

May be related to #171079, #63869
Notify maintainers

Metadata
Please run nix-shell -p nix-info --run "nix-info -m" and paste the result.
[root@mymachine:/etc/nixos]# nix-shell -p nix-info --run "nix-info -m"
 - system: `"x86_64-linux"`
 - host os: `Linux 6.1.55, NixOS, 23.05 (Stoat), 23.05.20230927.5cfafa1`
 - multi-user?: `yes`
 - sandbox: `yes`
 - version: `nix-env (Nix) 2.13.5`
 - channels(me): `"home-manager-23.05.tar.gz"`
 - nixpkgs: `/nix/var/nix/profiles/per-user/root/channels/nixos`

Disclaimer: I've only been using NixOS for 2 days...
I'm also having this issue on 23.11 on my laptop:
nix-shell -p nix-info --run "nix-info -m"
 - system: `"x86_64-linux"`
 - host os: `Linux 6.1.87, NixOS, 23.11 (Tapir), 23.11.6478.bc194f70731c`
 - multi-user?: `yes`
 - sandbox: `yes`
 - version: `nix-env (Nix) 2.18.1`
 - channels(root): `"nixos-23.11"`
 - nixpkgs: `/nix/var/nix/profiles/per-user/root/channels/nixos`

journalctl --unit wg-quick-wgtest.service
Apr 20 18:42:21 localhost systemd[1]: Starting wg-quick WireGuard Tunnel - wgtest...
Apr 20 18:42:21 localhost wg-quick-wgtest-start[2356]: Warning: `/nix/store/randomstuff-config-wgtest/wgtest.conf' is world accessible
Apr 20 18:42:21 localhost wg-quick-wgtest-start[2356]: [#] ip link add wgtest type wireguard
Apr 20 18:42:21 localhost wg-quick-wgtest-start[2356]: [#] wg setconf wgtest /dev/fd/63
Apr 20 18:42:21 localhost wg-quick-wgtest-start[2381]: Name or service not known: `wg.example.com:51820'
Apr 20 18:42:21 localhost wg-quick-wgtest-start[2381]: Configuration parsing error
Apr 20 18:42:21 localhost wg-quick-wgtest-start[2356]: [#] ip link delete dev wgtest
Apr 20 18:42:21 localhost systemd[1]: wg-quick-wgtest.service: Main process exited, code=exited, status=1/FAILURE
Apr 20 18:42:21 localhost systemd[1]: wg-quick-wgtest.service: Failed with result 'exit-code'.
Apr 20 18:42:21 localhost systemd[1]: Failed to start wg-quick WireGuard Tunnel - wgtest.

The problem could be related to the service being of type "oneshot": nixos/modules/services/networking/wg-quick.nix
I'm using the instructions from https://nixos.wiki/wiki/WireGuard  in the "Setting up WireGuard server/client with wg-quick and dnsmasq"
I fixed it by adding this to my nix config:
{ config, pkgs, lib, ... }:

{
  networking.wg-quick.interfaces = { ...
    wgtest = {
      address = [ "REDACTED" "REDACTED"];
      dns = [ "REDACTED" "REDACTED" ];
      privateKeyFile = "/root/wireguard-keys/privkey";

      peers = [
        {
          publicKey = "REDACTED";
          presharedKeyFile = "/root/wireguard-keys/wg_example_com-psk";
          allowedIPs = [ "REDACTED" "REDACTED" ];
          endpoint = "wg.example.com:51820";
          persistentKeepalive = 25;
        }
      ];
    };
  };
  systemd.services.wg-quick-wgtest.serviceConfig = {
    Type = lib.mkForce "exec";
    RestartSec = 1;
    Restart = "on-failure";
  };
}

Not sure if that's the 'right' way to fix it, but it works, hope that helps someone!
Would it make sense to update the nix module from oneshot to exec? According to the systemd docs: "It is recommended to use Type=exec for long-running services, as it ensures that process setup errors [...] Also note it is generally not recommended to use idle or oneshot for long-running services."


[DOC] mTLS authentication for manager <-> instance-manager communication

What's the task? Please describe
We need to have a doc for #3839
Describe the items of the task (DoD, definition of done) you'd like

[x] Add mTLS doc in 1.3.0 documentation.

Additional context
N/A

cc @longhorn/qa


Allow proposals to be removed if there is no associated escrow

Treat them as if they are expired proposals.

Task linked: DEMZNE-3096 enable removing proposals if the associated escrow has been removed


Using Razor standalone in DotNet Core 3.0

From @genifycom on Saturday, September 28, 2019 3:37:25 AM
Issue Title
Now that we have separate invocations for MapRazorPages(), is it possible in DotNet Core 3.0 to create a console app that calls the Razor engine to create a page?
Are there any samples of this in DotNet Core 3.0?
General
Calling the Razor engine without requiring routing, MVC etc is extremely use for reporting and a number of other scenarios. This has been frustratingly close in prior DotNet Core versions. With DotNet Core 3.0 several parts of the framework have been separated out and it would seem that it might be possible now to use Razor pages standalone.
Could someone on the team please help with a sample on how to do this?
Copied from original issue: dotnet/core#3498

From @genifycom on Saturday, September 28, 2019 3:53:15 AM
Is there something like RazorViewToStringRenderer for DotNet Core 3.0?

It is, indeed, a very important scenario to cover.
There are a number of open-source projets out there for .NET templating. Including RazorLight, which uses the ASP.NET Core Razor librairies under the hood, but hasn't been actively maintained in recent times.
A Microsoft-maintained solution would be a very convincing addition to the ASP.NET Core platform.

Thanks for the issue report. The sample in https://github.com/aspnet/Entropy/tree/7a53120c620bbcfd7b54f147c16fa7da1e38d1d4/samples/Mvc.RenderViewToString should continue to work in .NET Core 3.0. We currently do not have any plans of adding a general purpose templating engine that works outside of the ASP.NET Core pipeline.

@pranavkm , it does not work between assemblies actually. #15046


Fix for #74

Resolves: #74

Still uses the remoteExec method but in a lot cleaner format. Each set of actions is added through their own function, each with a non-ACE alternative.
The addActions mode of the "Teleport" function was also tweaked to run locally for consistency.

Okie dokie looks like it works, 10/10


Some changes to the packaging script

I've added an option for skipping the building of test binaries, and I've added that to the packaging script.
I really didn't want to add the meson_options.txt file... but it seems there's no way around it (that I could find, at least...).
I've also enabled "unity builds" there, as recommended by the Meson documentation. This makes a couple of warnings appear, but so far it seems to work (not tested extensively, though)
I've also added support for relative output directory paths to the packaging script.

Well, as a bonus, the test binaries can now be built with MSVC... or at least it can be attempted by enabling them when using MSVC, no idea if they will build or not.

I'll give it some thought, although I don't feel like this is a change that needs to be addressed immediately.
I will merge your changes as soon as I finish messing around with my texture stuff.

I have a branch with the split scripts, I don't know whether to add that commit to this PR or to make a new one (which will depend on this one).


⚠ Samsung has degraded performance

In d2b68f2, Samsung (https://samsung.com) experienced degraded performance:

HTTP code: 200
Response time: 2026 ms

Resolved: Samsung performance has improved in 1dbf084.


Drop Support for MongoDB Queries?

Support for the .near method was added to Geocoder in early 2011, before the $near operator was widely available in MongoDB adaptors. The .near method is useful when using Geocoder with ActiveRecord because none of the three major Rails-supported relational DBs support spatial queries out of the box. MongoDB does, and all recent versions of Mongoid execute spatial queries using a pretty straightforward syntax. I don't think there is any advantage to using Geocoder's method.
Furthermore, Mongo-related functionality has never really been properly maintained and tested, and MongoMapper support appears broken.
Anyone have feelings for or against dropping MongoDB query support? (To be clear: you would still be able to geocode objects, you would just not be able to use methods like .near or .nearbys. The README would contain instructions for doing $near queries with Mongoid.)
See also: #828.

See 98e4a09. These methods are now deprecated.


feat(import.constants.ts): added chunking strategy dropdown as a new …

added chunking strategy dropdown as a new field in vector db

Closing this PR due to merge conflicts and raised new PR - #392


Fix for nondescript RuntimeException during Multipart-reading

Small bugfix to prevent (IO)Exceptions being wrapped by unhandled RuntimeException, when reading posted Multiparts.

Hi, just out of curiosity, is there a test scenario that led you to spot this?
Speaking of the patch, how about catching IOException before Exception in the same try-catch block, instead of splitting it?

There was an actual problem which showed this. Pretty much convoluted with an exception deep inside reading. I manually tested it, but dont have a concise unittest.
In actual, an RuntimeException was thrown, not an IOException. A special case for IOException would not be enough.

No problem for the test in this case.
Why won't a change like https://gist.github.com/asoldano/a06a67d9e849bdbcc1168319a4060f91 actually work?

The gist wont work if a RuntimeException is thrown (IllegalArgumentException, WebApplicationException, whatever). Catch(IOException) will not be called, instead catch(Exception) will be called, which wraps the original exception in an typeless RuntimeException

Ah, so the problem is really in not wrapping exceptions that already are RuntimeException, I thought it was with IOExceptions being wrapped while they're already in the list of exceptions declared for that method. How about the updated gist?

Latest gist is ok. But i would prefer try-blocks to be as small as possible to make the intent clearer.


[Obsidian] Show search results ordered by last modified

Extension
https://www.raycast.com/KevinBatdorf/obsidian
Description
When pulling up the Raycast Obsidian search, it seems to list notes alphabetically. It would be super nice if there was a way to instead see the notes ordered descending by last modified. That way, when pulling up the search option, all recently edited notes will be right at the top, making for a quick method for jumping to a note from outside of Obsidian.
Thanks for the consideration.
Who will benefit from this feature?
No response
Anything else?
No response

I agree that makes more sense and how Obsidian displays notes in the quick switcher

PR here: https://github.com/raycast/extensions/pull/8735


Drug and Reference fixes

Drug typos and amio dosing fixes.
Fix reference brackets, change Link to Source

Codecov Report

Merging #178 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #178   +/-   ##
=======================================
  Coverage   60.16%   60.16%
=======================================
  Files          16       16
  Lines         241      241
  Branches       50       50
=======================================
  Hits          145      145
  Misses         96       96

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d736242...ef2ec8a. Read the comment docs.

cc: @dsifford

I know we need some tweaks with non AMA references and DOI refs.
If a reference has a DOI link and PubMed link, should we drop DOI link and prefer PubMed? It is more consistent.

@jvoros

If a reference has a DOI link and PubMed link, should we drop DOI link and prefer PubMed?

Yes. DOI links are only generated by my plugin if a DOI is explicitly given or if the citation is autogenerated using a DOI, rather than a PMID. So, in other words, almost universally on ALiEM it's a one or the other scenario.


Can Ragas be used to evaluate Amazon Bedrock Agents w/ managed Knowledge Base?

[X] I checked the documentation and related resources and couldn't find an answer to my question.
Your Question
what is unclear to you? What would you like to know?
I just discovered the MDD approach for RAG development implemented by Ragas, and it is fascinating.
I have a conversational chatbot based on Amazon Bedrock Agent that uses claude-3-haiku-20240307-v1 as LLM, configured to use a Bedrock Knowledge Base (AWS managed). The KB is built on top of Amazon OpenSearch Service Serverless with titan-embed-text-v1 as the embedding model (chunking setup: fixed length size, max 300 tokens, 20% overlap).
Would Ragas be able to be used to evaluate my RAG setup? If so, do you have any examples, or can you point me to relevant documentation/approaches?
Thank you!
Code Examples
The chatbot infrastructure is scripted using AWS CD (python). I can provide relevant snippets if required.
Additional context
Anything else you want to share with us?
I opted for this setup since AWS manages every service.

@dosu
Can you give an example that strictly includes the following requirements:

The example shows how to integrate Ragas with Amazon Bedrock Agent instead of BedrockChat
The example shows how to integrate Regas with Amazon Bedrock Knowledge Bases instead of BedrockEmbeddings
The example can eventually use the LangChain Bedrock (Knowledge Bases) Retriever (URL: https://python.langchain.com/v0.2/docs/integrations/retrievers/bedrock/)
The example uses a PDF as a testing dataset

If you cannot provide such an example, explain in depth the implications in terms of test validity of using BedrockChat and BedrockEmbeddings instead of the actual infrastructure based on Amazon Bedrock Agents and Knowledge Bases.
Thanks!

Hey @danielesalvatore , we are working on supporting conversational and agentic workflows in ragas by v0.2. I'm working on the initial PR #1222 . I would would to talk to you to further understand your use-case and ensure that we support it too.  If you're free, here's my cal

Hey @shahules786, thanks for pinging! I just submitted a meeting request for Monday, September 2, 2024, 10:00 – 10:30 Rome, ITA time.


Class 'UserTransformer' not found

I have been following the Wiki guide on getting started and I have hit a wall. On the responses section, it says that you can create the response builder by adding the ControllerTrait into your BaseController.
This is what my controller currently looks like...
<?php

use Illuminate\Routing\Controller;
use Dingo\Api\Routing\ControllerTrait;

class BaseController extends Controller {

use ControllerTrait;

/**
 * Setup the layout used by the controller.
 *
 * @return void
 */
protected function setupLayout()
{
	if ( ! is_null($this->layout))
	{
		$this->layout = View::make($this->layout);
	}
}

}

I tried to remove the protected function just in case it was over riding anything, but I still got the same error message.
My UserController also extends my BaseController so it should be picking it up.
I am using the latest version (0.8.2) and have the providers and aliases all set up.

What method are you attempting to call?

Item and collection methods, both bring up the same error.
I have even tried copying and pasting straight from the wiki to see if this would work and got nothing.

have you created a UserTransformer ?

I haven't. I didn't know what you mean, but after checking the wiki, I see that there is a section on transformers.
Wouldn't it be wiser to learn how to set up a transformer before showing that code within the responses section?
You can call me stupid or silly or whatever, but surely having it as more of a step by step, it will be easier to see what is going on?
I probably should have checked the nav before opening an issue, but I'm sure there will be others like me at some point.

I agree, the wiki could be more beginner friendly and/or possibly ordered in a more logical manner.
I think @jasonlewis mentioned that he would try to release some screencasts to accompany the wiki at some point.

That will definitely help.
Thank you for commenting back and helping me out, I really appreciate it.

I'm stumped on this too.  There doesn't seem to be any example of how to create a UserTransformer class or any other Transformer class.  The Wiki doc on the Transformer topic is a bit scant.  I've been reading the Fractal package doc too, and am just overwhelmed at this point.  I appreciate any example someone may provide on how to create a Trasformer class for the User or any table record for use in Dingo.  TIA.

That's because transformers aren't something that this package does, it merely supports them.
A very basic transformer class is as follows...
class Transformer extends League\Fractal\TransformerAbstract
{
    public function transform(User $user)
    {
        return [
            'name' => $user->name
        ];
    }
}

Thanks lots for your reply Jason!  Like the author of this thread, I got stuck using some of the doc examples such as:
$users = User::paginate(25);
return $this->response->paginator($users, new UserTransformer);
The 2nd param is not optional.  Is it possible to use the paginator or item methods without a Trasformer object? Or does it make sense to use these methods otherwise?  Thanks again. Every word in your doc and vimeo video is golden mate!


Optional number

Hi, in Brazil we have mobile phone like this (xx) x xxxx-xxxx  and normal phone like this (xx) xxxx-xxxx
So, using jquery mask I was able do do something like this:
$(".phone").mask("(99) 9999-9999?9");
The last number is optional using the question mark, is there a way to do that unsing your component?
Thanks

It is not gonna work for now that way, but maybe I will implement it in the future. The best thing you can do now is add the radio button or something like that and change the mask if necessary.

Any chances to have this feature ?


Restore package

I read the thread and I can see the vulnerability is dispersed now, can we please restore the package?
The breaking comment: https://github.com/dominictarr/event-stream/issues/116

Why is this repository closed? https://github.com/dominictarr/event-stream/issues/116#issuecomment-442290333 is the code wrong anymore?


Improvements from usability testing - 2

Pull requests:

https://github.com/senzing-garage/playground/pull/145
https://github.com/senzing-garage/playground/pull/148
https://github.com/senzing-garage/playground/pull/151
https://github.com/senzing-garage/playground/pull/153
https://github.com/senzing-garage/playground/pull/173


Has work on swarm ceased?

https://github.com/docker/swarm/graphs/commit-activity shows a big dropoff compared to swarmkit or docker engine. The README says that swarm is "not deprecated", but is anyone at Docker still working on this project full-time?

Also curious about this.  I love the basic abstraction of allowing a cluster of nodes to appear as a single docker engine but am worried that this project has been abandoned in favor of swarmkit.

Swarmkit is more natural in supporting service model and it's getting a lot of usage since launch. Much resource has put into Swarmkit as orchestration platform.
At the same time Swarm is actively used by many users in their infrastructure. Our current goal is to keep Swarm stable. Inside Docker we favor bug fixes over feature requests on Swarm. But users are welcome to contribute anything they consider appropriate.

I'm going to assume that Docker is basically putting original swarm on life support. I opened a pretty important, straightforward bug about lack of documentation on a totally basic thing almost exactly a year ago and it hasn't been addressed: https://github.com/docker/swarm/issues/1341.
I think you should be more honest in the README about your true plans for the project. "Docker does not currently have a plan to deprecate Docker Swarm" communicates very little about your true intentions.


Only index nodes with a template and check umbracoNaviHide

https://github.com/skttl/Our.Umbraco.FullTextSearch/blob/8ef476dc69d02fb2bb632d2ce1d67946393c80c3/src/Our.Umbraco.FullTextSearch/Services/CacheService.cs#L40
Only nodes with a template and umbracoNaviHide = null or false should be indexed I think.

@skttl penny for your thoughts?

Yes, no-template nodes should be fine to filter out.
I also agree that having null or false in umbracoNaviHide shouldn't exclude from indexing, but isn't that how it already is?

Ah yes there is the FullTextSearch.DisallowedPropertyAliases setting ofcourse. I think it's not working for me though, but I'll have to look into it.

IIRC the DisallowedPropertyAliases is only used when searching. It will index anyway :) You could probably add that to the caching filter.
Maybe even the caching service should handle removing FullText content, if template is removed or DisallowedPropertyAliases is set to false.

I'll look into it!

Maybe even the caching service should handle removing FullText content, if template is removed or DisallowedPropertyAliases is set to false.
Just tried adding a disallowed property, and setting it on an existing node. It got removed from the index as expected :)

@skttl did you implement the template check?

Ah sorry, thought it was already in, since I got the node removed from the index.
But then it is probably a case of the url not returning anything, resulting in the node being removed.

The search still includes results from a type without a template. So this is not working yet.

I made some fixes in the latest commits, making sure that the node is removed from both the cache and its Full Text Content is removed from the index. Closing this then :)


rasa chatbot duckling implementation issue

I'm currently working on rasa chatbot , I can install duckling but can not implement it in for time and date entity so pls help me if any one had already use it.
thank you

Thanks for the question, our Github issue board is for bugs and feature requests only, though 😕
Please ask this question in the forum✨
If you were describing a bug, please create a report and fill out the template


[BUG Unable to Load TimeSeriesPredictor in AutoGluon

Description:
I successfully trained a TimeSeriesPredictor with AutoGluon and saved it. When I attempted to load the predictor the next day using the same environment and Jupyter Notebook, I encountered an issue. Initially, a version mismatch warning was shown, suggesting that the predictor was created in a version <=0.7.0, even though I was using version 0.8.2. When I bypassed the version check using require_version_match=False, a FileNotFoundError was raised, indicating it couldn't find predictor.pkl in the specified directory.
What's puzzling is that the predictor and its multiple model files were loaded successfully just a day ago.
Steps to Reproduce:
Train a TimeSeriesPredictor on version 0.8.2 of AutoGluon.
Save the predictor.
Attempt to load the predictor the following day.
Expected Behavior:
The predictor should be loaded without any issues, especially when no changes have been made to the environment or the directory.
Actual Behavior:
Received a version mismatch warning followed by a FileNotFoundError when trying to bypass the version check.
Environment:
AutoGluon version: 0.8.2
Python version: 3.10 (as observed from the traceback)
Operating System: MacOS
Additional Information:
I am using Jupyter Notebook, and I've verified that the working directory is correct. The models are stored under "AutogluonModels/2023-09-12 20:48Pr96Val5Win5Qhigh_quality", and each model seems to be in its respective subdirectory. The predictor.pkl was never directly in the main folder but inside subfolders.

Thank you for opening the issue! Do you think it would be feasible to provide a minimal working example for reproducing this issue + the traceback? Otherwise, debugging this issue would be problematic (and I'm not sure how to verify that the files were not modified externally, which could corrupt the saved predictor).
I would recommend training another predictor in a different directory and comparing the files to the original directory. Another potential source of the problem might be that the code for training predictor with the same path has been executed multiple times, which led to overwriting the contents of the saved predictor folder.

It seems it was a problem within my env. Now I have to retrain in a new env but now PatchTST and DeepAR are not working anymore and I wasn't able to fix that for 2 hours. I'll wait for a version of ag which supports python 3.11 probably since right now the installation is very confusing.

Similar issues were discovered with Autogkuon 1.1.1. The load() method throws an error saying the model was saved with different version


Patch for no depth image bug on linux

This small patch fixes a bug that no depth image is acquired on debian/unstable 64bit environment.

Yes, I found this bug too!

This fix was merged into our source and will come out in a couple of days as part of OpenNI 1.4.0.x.


nixos/system-path: allow installing multilib glibc

This is primarily to be able to have multilib-capable ldd in the system path. Maybe there's a better way to do this? This feels somewhat inelegant.

What's the use case for this? If you really need this, you can always do something like
environment.systemPackages = mkBefore [ glibc_multi ];

Aha, I haven't known about mkBefore! Well, my usecase is fairly small (I use ldd from time to time to determine dependencies of proprietary libraries, which can be 32-bit) so I can just endure lots of collision warnings, and that feels nicer that this patch too.


Clean up 11ty

Summary | Résumé
Remove GC Design System specific content and create a template for 11ty

Wrong repo. This was meant for my fork of this repo


Enable building on Scala 2.11

I have an project that unfortunately is currently stuck on Scala 2.11. I'd like to be able to use this plugin. Fortunately, only a minor change was required to enable compilation on Scala 2.11 in addition to the existing targets.

Hey @michaelmior I'm trying to keep the min possible amount of scala versions possible, but mb we can make an exclusion if that indeed works for you :+1:

That would be great! As you can see, the required changes are pretty minimal. It's really just a workaround for all the weird stuff with .lines across versions.


How to connect --test-series with Espresso tests to run a specific suite of tests and not all tests.

Hello,
I am wondering how we can specify a --test-series inside our native espresso code to run only specified tests.
Ex.
I have 3 tests:
Login
Make Transaction
Cancel Order
Via gradle wrapper, I can run something like
./gradlew connectedAndroidTest -Pandroid.testInstrumentationRunnerArguments.class=com.app.testCases.login.Login
./gradlew connectedAndroidTest -Pandroid.testInstrumentationRunnerArguments.class=com.app.testCases.transaction.MakeTransaction
./gradlew connectedAndroidTest -Pandroid.testInstrumentationRunnerArguments.class=com.app.testCases.CancelOrder.Cancel
Each of these commands will only run that specific test. I want to be able to do this using appcenter. I assume the --test-series would be flag to do this, but I have no idea how to connect the --test-series that I specify on appcenter to what test it should run.
Is there some kind of annotation that must be used in the Espresso test code to connect back to the --test-series on appcenter?

Closing as stale.


fix: repository governance

This PR was automatically created by the AVM grept governance tool

Supersceeded by #42


[core] add merge write disposition

Background
dlt users should be able to

deduplicate loaded data if primary_key is known
merge the data when merge_key is known

The corresponding dbt ticker is here: https://github.com/dlt-hub/dlt/issues/119
The PoC code is here: https://github.com/dlt-hub/dev_materialisations
Implementation involves deep changes in load module of dlt
Tasks

[x] allow to define merge content disposition

[x] allow new merge_key column hint (along the primary_key). allow hint on many columns.

[ ] add merge_key and primary_key to our resource decorator where a column name or many names can be provided. note: we may need to create surrogate columns for them in extract stage. at this moment the data type of such column will not be known and our schemas do not allow columns with data types...

[x] all destinations based on SqlJobClientBase must support the merge. other destinations must fallback to append

[x] merge requires two datasets to be created: staging for the "temporary" data and the regular one. merge loading in parallel (by two or more processes) into the same tables will not be supported

[ ] all the tables with merge disposition are first loaded into staging dataset in replace mode (tables should be truncated before loading).

[x] merge SQL scripts must be created and added as SQL jobs to the load package. each job merges a parent tables and all child tables (not 100% optimal but makes SQL jobs implementation way easier)

[x] that means that we must implement SQL jobs. we only have file jobs.

[x] the remaining tables should be loaded into regular dataset. schema should be upgraded.

[x] the sql jobs should executed like any other file jobs

SQL jobs tasks

[x] as we recognize job types by job file extensions :) use .sql for SQL jobs

[x] start_file_load should spawn LoadJob depending on the extension. it may be a good time to refactor name ie into start_job and move part of this function to base class. Also the implementation of LoadJob is similar to InsertValuesLoadJob but simpler :)

merge script tasks
see https://github.com/dlt-hub/dev_materialisations

[x] supports parent and child tables

[x] supports compound merge and primary keys

[x] simple standard SQL that works on all our destinations. we could use sqlglot for transactions. this is last resort. we may also switch to sql alchemy entirely

tests
We need a full set of tests for this for all destinations

[ ] tests for sql jobs (happy path, mixed with file jobs, for dummy destination that does not support sql)

[ ] tests for merge script (compound and regular keys, deeply nested tables with branching, primary and merge keys mixed)

[ ] tests for decorator (all combination of keys tested, check if correct schema is generated)

[ ] loader test (for all merge script cases, with multiple loads etc.)

missing tests after #220
missing tests and tasks

test sql jobs on dummy and destinations

test followup tasks (all file tasks completed, failed and completed tasks allowed)

LoadJob: job_id and job_file_info (dummy)

sql client test truncate

test staging in sql_client_impl: init_storage, truncate, update schemas selectively for tables

partial columns are not updated (without data type)

primary keys in normalizer: no more deterministic hashing

we are not saving the default values, check the flows with schema export/import

table, column diff and merge

get_child_tables and get_top_level table

loader: list jobs for table, add new job

merge generation for different cases, check with sqlfluff: case without child tables, case without any keys, case with single merge and single primary, case with compound keys

test now:

partial columns: column inference when there's no data type, merging of partial columns, non null coercion on partial columns (hmmm this should not happen...)
end to end merge: ethereum, github, case without child tables, case without any keys, case with single merge and single primary, case with compound keys
check decorator option and run option
check source root key option

must implement

bump schema version

change behaviors:

move column propagation into table definition
generate merge jobs before tasks start (terminal exception of merge job cannot be generated)
start merge jobs with current conditions of starting after all the file jobs for a table are completed
leave followup jobs
primary keys in normalizer: optimize behavior
propagated columns should inherit the hints from parent table
clever way to propagate root key: if such key is already propagated then skip our own
allows merge key and primary key on bigquery


MariaDB dependency should be opt-outable, one should be able to point to an existing DB

FEATURE REQUEST
Version of Helm and Kubernetes:
HEAD
Which chart:
Most of them
What happened:
Installing a web service that depends on a DB installs the DB unconditionally
What you expected to happen:
I would have liked to be able to install the database instance separately in charts like Wordpress, Ghost, Drupal, etc.
How to reproduce it (as minimally and precisely as possible):
Deploy any of Wordpress, Ghost, Drupal and try to point it to an existing DB

I thought this would accomplish this: https://github.com/kubernetes/charts/pull/773
but I am probably mistaken.. I am having a hard time getting this configured with the current template

I think #773 gets us some of the way there (@sameersbn correct me if not). Two further changes we need to make:

make MARIADB_HOST configurable, it's currently hardcoded
add a value for disabling the dependency

@prydonius yea, maybe we could automatically disable the mariadb dependency if the user specifies a value for MARIADB_HOST

Can somebody do that for all the charts that link to a MariaDB then please?

I've done the wordpress work in PR #2605, Sorry that's the only one I needed


Review cleanup for writing early_data extension

A few clean ups:

there is no need to recompute buflen using pointer arithmetic;
no need to reassign value to *olen, it is initialized to 0;
change log level from 5 to 2, it seems to be consistent with other logs like "<= skip write" or "<= skip parse".
Use Allman style indentation.

Related to issue #195.


Import CSV function does not work when language = 'nl'

Import CSV function works fine when language = 'en' (e.g.the following output on the  preview page:

The following changes were detected:
For testonnoz (3253), Strong Hand changes from None (None) to T (28).
Submit button

When working in Dutch language, the preview page only says

De volgende wijzigingen zijn vastgesteld:
Submit button

Other than #92, things don't work under the hood, so this is not merely a front-end display issue.

Done


Regenerate templates to pass ci test

Hi @JiangtianLi, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

It looks like you're a Microsoft contributor. If you're full-time or an intern, we DON'T require a Contribution License Agreement. If you are a vendor, please DO sign the electronic Contribution License Agreement. It will take 2 minutes and there's no faxing! https://cla.microsoft.com.

TTYL, MSBOT;

All of these changes are non-material and can't be the cause of the problem.
Can you tell me what go version says? I strongly suspect you're on Go 1.8...

go version go1.7.5 windows/amd64.
Which version should I use?

Hm, okay... Any chance you can do the generate again from the devenv/docker container and push it up?
It could even just be 1.7.4 vs 1.7.5 since I think the container is still on 1.7.4 (I have a PR for that too)
(Basically, if you can run make ci locally, on HEAD cleanly, then something else is up - like Go version, or version of Go-bindata or something. )

@colemickens  I did "make build" && "make ci" in the devenv/docker container. It seems the changes are file mode. I used to build on Windows box. Maybe that is the root cause?

We should not suppress the output of validate-generated so that we can see the problem in the CI job... (cc: @dmitsh)
Maybe it's the newline at the bottom actually... no idea why that would be new though...
https://github.com/Azure/acs-engine/blob/master/scripts/validate-generated.sh#L22 This should prevent any lines with metadata from triggering a validation failure... hence why I don't think the filemode or timestamps matter.
If you think this will help, I'll go ahead and approve. It certainly shouldn't hurt.

Thanks, Cole! I'll give it a try.


CLI login: Cannot logout and login again into another Org. Need to clean cookies.

Describe the bug
After logout a user should be able to login again into a different org.
Instead, the org selection step is skipped in the browser unless the user explicitly cleans the Adobe cookies.

Related: https://github.com/adobe/aio-cli/issues/334#issuecomment-1275631137

otherwise on logout could we open the browser show "successfully logged out" and clear cookies ?

This will be resolved next week when
https://github.com/adobe/aio-lib-ims-oauth/pull/91 is released


Starbow Lobby Screen

About the PR
Adds "Starbow" a beautiful artwork done by Doner on the SS14 discord to the lobby screen pool.
Why / Balance
Its absolutely stunning, and would be an AMAZING addition to the lobby screen pool.
Technical details
Attributions has been updating and permission was given to make this change:

Media

Requirements

[X] I have read and I am following the Pull Request Guidelines. I understand that not doing so may get my pr closed at maintainer’s discretion
[X] I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Breaking changes
It adds an image, I don't think this will not cause the game to explode
Changelog
🆑

add: Starbow by Doner#4037 has been added to the lobby screen pool.

The maintainers all agreed that this is artwork is pretty amazing, but does not really resemble SS14 a lot. For that reason I will be closing this PR. Lobby art will also be added to the list of current freezes since we got enough at the moment. Thank you for your contribution.


Fix to previous commit, that broke runtimeJars to versions 1.2.x and 1.3.x

Fixed getRuntimeJars, to return correct runtimeJars for version 1.2.x and 1.3.x (broken in previous commit)

Simple refactorings to GroovyAndroidPlugin, to facilitate testing:

new method getRuntimeJarsIndex(pluginVersion), refactored from getRuntimeJars(project, plugin)
getRuntimeJars(project, plugin) to getRuntimeJars(pluginVersion, plugin)

Added GroovyAndroidPluginTest to ensure that all supported versions of the build plugin are getting the correct runtime jars

Thanks for fixing it :)


ci: udpate OWNERS_ALIASES file

transfer easonn7 to BenMeadowcroft
Signed-off-by: wuhuizuo<EMAIL_ADDRESS>
What is changed and how it works?

Issue Number: Close #xxx

What's Changed:

Related changes

[ ] PR to update pingcap/docs/pingcap/docs-cn:
[ ] Need to cherry-pick to the release branch

Check List
Tests

[ ] Unit test
[ ] Integration test
[ ] Manual test (add detailed scripts or steps below)
[ ] No code

Side effects

[ ] Performance regression: Consumes more CPU
[ ] Performance regression: Consumes more Memory
[ ] Breaking backward compatibility

Release note

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

/cc @yudongusa @benmeadowcroft

/retest

/cc CalvinNeo


./pw --upgrade should do the upgrade itself instead of printing instructions

Is your feature request related to a problem? Please describe.
when running ./pw --upgrade it prints the following instructions:
> .\pw --upgrade
Upgrade to the latest version of Pyprojectx by executing following command in a terminal:
Invoke-WebRequest https://github.com/pyprojectx/pyprojectx/releases/latest/download/wrappers.zip -OutFile wrappers.zip; Expand-Archive -Force -Path wrappers.zip -DestinationPath .; Remove-Item -Path wrappers.zip
If your installed px, you can download the latest pw scripts to the current directory by executing:
pxg download-pw

Describe the solution you'd like
it should be able to upgrade itself even when it's not installed globally
Additional context
is the current behavior is because the script can't delete itself while it's currently running? i'm sure there are ways around this because many other programs are able to update themselves

I think simply executing the subprocess powershell -NoProfile -c "Invoke-WebRequest https://github.com/pyprojectx/pyprojectx/releases/latest/download/wrappers.zip -OutFile wrappers.zip; Expand-Archive -Force -Path wrappers.zip -DestinationPath .; Remove-Item -Path wrappers.zip" would suffice (for windows)

i think the default alias in pxg: 'download-pw' solves this problem perfectly, all we need is for it to be executable from .\pw, not just an alias in pxg


OCM-4442: Moved kmsARN regexp validator to common lib

moved kms Arn regexp validator to common lib
Related to : https://github.com/openshift-online/ocm-common/pull/13
JIRA: https://issues.redhat.com/browse/OCM-3155, https://issues.redhat.com/browse/OCM-4442

/ok-to-test

@den-rgb please rebase your branch to include latest CI changes due to tf1.6.0 breaking changes.
Also before pushing, run make tests and ensure they all pass

make tests

I need to wait for ocm-common changes to be merged first before I can continue with this

@den-rgb thank you for this contribution
I'm putting this PR on hold because next version v1.4.0 is in code freeze
I will release the hold once the main branch will open to v1.5.0
/hold

/hold cancel
The main branch is alredy opened for v1.5.0
@den-rgb Do you think it ready for merge?

/hold cancel The main branch is alredy opened for v1.5.0 @den-rgb Do you think it ready for merge?

Yes It should be ready to merge, I'll just rebase it just in case and if everything is alright then it should be good to go

/approve

Could someone point me to how to resolve these errors as they don't seem to be related to my changes, Thanks

can you rebace on the main branch

/approve
Thanks @den-rgb 👏🏽

/lgtm


MWPW-138748: Modifying style path

Modifies style path to ensure styles load

Resolves: MWPW-138748
Test URLs:

Before: https://main--bacom-blog--adobecom.hlx.page/?martech=off
After: https://style-path-mod--bacom-blog--adobecom.hlx.page/?martech=off

Codecov Report

Merging #28 (3768bc2) into main (ab85568) will not change coverage.
Report is 1 commits behind head on main.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #28   +/-   ##
=======================================
  Coverage   86.36%   86.36%
=======================================
  Files           2        2
  Lines         176      176
=======================================
  Hits          152      152
  Misses         24       24

Files
Coverage Δ

blog/blocks/language-menu/language-menu.js
100.00% <ø> (ø)

blog/scripts/utils.js
83.44% <ø> (ø)

:mega: Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!


Change date range of agenda

Is there a way to change date range of agenda  from month to week?

Yes set the length prop 👍


[bug or feature?] braiding 4-cells over identities of 3-cells displays 3-cells on top

a single 0-cell X (white)
pink is a 2-cell on X
right boundary is the identity of a 3-cell (pink -> white)
green and black are 3-cells on (white)
the spider is a 4-cell [black,black] -> [black,green,black]
when braiding the boundary over the wires, doing so in either order correctly shows which wire is on top, but the pink 2-cell is always displayed over the wires on the right afterwards.

This is a bug. We are tracking it in #496.


chore: bump version of semver package

Updating the semver dependency.
Todos:

[ ] bump minor version (& tag)
[ ] publish package

Linked Issues:

npm/node-semver#289

Coverage remained the same at 93.939% when pulling 3084e0687942b61b2c9da0e8dd300b00df34bcc7 on feature/bump-semver-dep into 1c2debc186a719fd5acadfe610a41f8d60086ac6 on master.

Coverage remained the same at 93.939% when pulling 3084e0687942b61b2c9da0e8dd300b00df34bcc7 on feature/bump-semver-dep into 1c2debc186a719fd5acadfe610a41f8d60086ac6 on master.


Unexpected behavior with verticalCompact  enabled in version 16.02

[X ] Bug
[ ] Feature Request
[ ] Question

There is some weird behavior when moving widgets introduced in the new version.
I have verticalCompact enabled. In version 15.03 it works ok:
Version 15.03 example
But in version 16.02 when I want to move one element the other is unexpectedly taking free space and jumps to the top and stays there. See example:
Version 16.02 example

Can you guide how to it mate ? :) I have an issue in #720


Remarks missing entry (not valid in 64-bit MASM)

Directive not valid in 64-bit MASM (ml64.exe).

Document details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: bd6b640c-1098-337c-a0f6-c89d7a0c070e
Version Independent ID: 02124431-a255-20c2-6f4a-84b3e6d9fcd6
Content: .UNTILCXZ
Content Source: docs/assembler/masm/dot-untilcxz.md
Product: visual-cpp
Technology: cpp-masm
GitHub Login: @corob-msft
Microsoft Alias: corob

fix should appear in 1-2 days. Thanks @Player1UK !


[feat] Support workload identity in GCP

Is your feature request related to a problem? Please describe.
Workload identity is supported by Apigee Hybrid, it is more secure and does not require key generation. (In some environments, service account key generation is not allowed by organization policy).
Describe the solution you'd like
when gcp.workloadIdentityEnable is set to true, no more check on serviceAccountRef during input check
Describe alternatives you've considered
No
Additional context
https://cloud.google.com/apigee/docs/hybrid/v1.10/install-configure-cluster.html#gke---workload-identity

in terms of the requirement, I see that the overrides file of helm supports a workloadIdentity section: https://cloud.google.com/apigee/docs/hybrid/v1.11/config-prop-ref#gcp-workloadidentity-enabled
AFAIU, in the current configuration, we are using the create_service_account variable to create the service account and then generating the service account secret which is mounted as a volume in the corresponding deployments.
From the perspective of helm, it is simply a config that we have to enable. Currently the overrides.yaml.j2 file does not have the workloadIdentity.enable variable.
The vars file might look something like this:
create_service_account: true
gke:
  workloadIdentity:
    enabled: true
    gsa:
      connectAgent: <IAM SA for connectAgent>
      runtime: <IAM SA for runtime>
      synchronizer: <IAM SA for synchronizer>
      ...

Each of the GSA keys correspond to the service accounts for the corresponding components.

If workloadIdentity.enabled is false, the normal route is followed for creating kubernetes secrets and mounting them onto the deployments.
if it's enabled and create_service_account is false, it is assumed that the service accounts for the components mentioned already exist and all we need to configure is the WI
if create_service_account flag is true, the gsa component service accounts are ignored.

Let me know how you feel about this!

@RiflerRick :  Please do the following

Since the WI enabled flag needs to go to overrides put in the gcp section of overrides , like the rest of the gcp variables
overrides.gcp.workloadIdentity.enabled
refer : https://github.com/apigee/ansible-apigee-hybrid-accelerator/blob/main/vars/test.yaml#L104

Make the relevant changes to the jinja template after the following line .

Keep the gsa params distributed across  given that they are specific to overrides
overrides.connectAgent.gsa
overrides.envs.gsa.runtime
overrides.envs.gsa.synchronizer
overrides.envs.gsa.udca
overrides.logger.gsa
overrides.mart.gsa
overrides.metrics.gsa
overrides.udca.gsa
overrides.watcher.gsa
Set the defaults for each gsa in the role so that even if WI is enabled and user doesnt give gsa in overrides it ll pick defaults

@RiflerRick : Please do the following

Since the WI enabled flag needs to go to overrides put in the gcp section of overrides , like the rest of the gcp variables
overrides.gcp.workloadIdentity.enabled
refer : https://github.com/apigee/ansible-apigee-hybrid-accelerator/blob/main/vars/test.yaml#L104
Make the relevant changes to the jinja template after the following line .
Keep the gsa params distributed across  given that they are specific to overrides
overrides.connectAgent.gsa
overrides.envs.gsa.runtime
overrides.envs.gsa.synchronizer
overrides.envs.gsa.udca
overrides.logger.gsa
overrides.mart.gsa
overrides.metrics.gsa
overrides.udca.gsa
overrides.watcher.gsa
Set the defaults for each gsa in the role so that even if WI is enabled and user doesnt give gsa in overrides it ll pick defaults

Thanks


Debian 10.6 fresh install, warning bcmath gmp missing

Hello All,
thanks for you usefull ansible playbook :)  It works fine !
Some minor issue:
Debian 10.6 fresh installed - it pulled NC 20.0.2
I checked the Admin Panel for security and installation issues and got a warning
bcmath und gmp are missing.
First i tried apt-get install php-pcmath php-gmp - but the warning remains.
I figured out - php7.4 packages where installed (i guess because php-something is the default meta package).
Second i tried apt-get install php7.3-bcmath php7.3-gmp; systemctl restart php7.3-fpm.service
Now warnings are gone :)
Questions i have - what should be the default php version and is it "intentional" that this packages are not installed ?
Thanks for you feedbacks
I took a look - https://github.com/ReinerNippes/nextcloud/blob/master/roles/prep_php/tasks/Debian.yml
maybe bcmath and gmp should be added here ?
Ok i forgot about inventory: it is php Version php_version= '7.3 :)

I updated the task file. (commit 04855c7f3a)

bcmath is also a problem with CentOS7


Fixed Bug Dropdown moves out of viewport for small screen

Description
Fix the dropdown overflow issue on small viewports by adding maxHeight property in the  style.css file
Issue No. #971
Screenshot of bug and fix
BUG: Dropdown going out of viewport

FIX: Changed the max-height property

Acceptance criteria

[x]  The dropdown has a limited maxHeight and can be displayed on small screen,
[x]  The maxHeight is a ratio of the viewPort
[x]  The dropdown display a scrollbar when content exceeds item size

Thanks @GaganSingh5 for your help :)

:tada: This PR is included in version 6.0.0-beta.11 :tada:
The release is available on:

v6.0.0-beta.11
GitHub release

Your semantic-release bot :package::rocket:

:tada: This PR is included in version 6.0.0-rc.1 :tada:
The release is available on:

v6.0.0-rc.1
GitHub release

Your semantic-release bot :package::rocket:

Awesome🎉 @Romakita

:tada: This PR is included in version 5.65.7 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Add quick fix for abstract object implementation

Purpose

Add quick fix for abstract object implementation

Fixes #18307
Check List

[x] Read the Contributing Guide
[ ] Updated Change Log
[ ] Checked Tooling Support (#)
[x] Added necessary tests

[x] Unit Tests
[ ] Spec Conformance Tests
[ ] Integration Tests
[ ] Ballerina By Example Tests

[x] Increased Test Coverage
[ ] Added necessary documentation

[ ] API documentation
[ ] Module documentation in Module.md files
[ ] Ballerina By Examples

Codecov Report

Merging #21145 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #21145   +/-   ##
=======================================
  Coverage   14.59%   14.59%
=======================================
  Files          51       51
  Lines        1398     1398
  Branches      214      214
=======================================
  Hits          204      204
  Misses       1178     1178
  Partials       16       16

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8e31dcd...5c2d0e7. Read the comment docs.


call mars-lan  help me，I want to dock with the Oracle database

Looking at this case, the experiment is not through
https://github.com/LinkedIn/Wherehows/wiki/Backend-API#cfg-db-add

Dear issue owner,
Thanks for your interest in WhereHows. We have recently announced DataHub which is the rebranding of WhereHows. LinkedIn improved the architecture of WhereHows and rebranded WhereHows into DataHub and replaced its metadata infrastructure in this direction. DataHub is a more advanced and improved metadata management product compared to WhereHows.
Unfortunately, we have to stop supporting WhereHows to better focus on DataHub and offer more help to DataHub users. Therefore, we will drop all issues related to WhereHows and will not accept any contribution for it. Active development for DataHub has already started on datahub branch and will continue to live in there until it's finally merged to master and project is renamed to DataHub.
Please check the datahub branch to get familar with DataHub.
Best,
DataHub team


flutter-in-app-purchases codelab error

https://codelabs.developers.google.com/codelabs/flutter-in-app-purchases#10
App Store setup step 8
It should be Version 1 Notifications, not Version 2 Notifications. handleAppStoreServerEvent doesn't work with Version 2.

/cc @domesticmouse

Should no longer be an issue in the new Dart implementation: https://github.com/flutter/codelabs/pull/1447

This should be fixed now, as the code to handle purchase verification has been rewritten in Dart.


Clearer error msg while parsing - specify which node had a problem

Hi, happy to make a ticket if you think I should. But it was a small change in error message so not sure if it was necessary.


[Flaky test] TestFlowAggregator/IPv4/InterNodeFlows

Describe the bug
I observed a failure of TestFlowAggregator/IPv4/InterNodeFlows in Kind CI, for the "E2e tests on a Kind cluster on Linux with AntreaProxy all Service support" job (don't know if the exact job is relevant):
2022-04-14T06:07:08.0155983Z === RUN   TestFlowAggregator/IPv4/InterNodeFlows
2022-04-14T06:07:08.0159474Z I0414 06:07:08.015721   17954 k8s_util.go:731] Creating/updating Antrea NetworkPolicy antrea-test/test-flow-aggregator-antrea-networkpolicy-ingress
2022-04-14T06:07:08.0305576Z I0414 06:07:08.030293   17954 k8s_util.go:731] Creating/updating Antrea NetworkPolicy antrea-test/test-flow-aggregator-antrea-networkpolicy-egress
2022-04-14T06:07:08.1416689Z     flowaggregator_test.go:958: Antrea Network Policies are realized.
2022-04-14T06:07:20.5808986Z     flowaggregator_test.go:690: Throughput check on record with flowEndSeconds-flowStartSeconds: 4, Iperf throughput: 10.00 Mbits/s, IPFIX record throughput: 3.94 Mbits/s
2022-04-14T06:07:20.5810485Z     flowaggregator_test.go:691:
2022-04-14T06:07:20.5811149Z         	Error Trace:	flowaggregator_test.go:691
2022-04-14T06:07:20.5812029Z         	            				flowaggregator_test.go:344
2022-04-14T06:07:20.5813299Z         	Error:      	Max difference between 3.937286 and 10 allowed is 1.5, but difference was -6.062714
2022-04-14T06:07:20.5814009Z         	Test:       	TestFlowAggregator/IPv4/InterNodeFlows

Full test logs: https://gist.github.com/antoninbas/f543aa2e9eb2c34cba41edf9825bf39e

@heanlan @dreamtalen could someone take a look at this?

@antoninbas ack


Fix errors around turning thrown Exception objects into JSON.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: keithbarrow sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.


fix(actions): pass correct inputs from launch_job

The launch_job calling workflow needed to pass
correctly-referenced inputs to the underlying run workflow.

Ran into the same issue so - used the underlying job.

@gabestep-emp is this getting merged anytime soon?

Not sure I'm not a owner of the repo @prha @gibsondan can one of you approve and merge this pr?


Feature/quality checking [WIP]

Task/Issue URL:
Tech Design URL:
CC:
Description:
Steps to test this PR:
1.
1.

Internal references:
Software Engineering Expectations
Technical Design Template

          2 Warnings

:warning:
PR is classed as Work in Progress

:warning:
Big PR

  Generated by :no_entry_sign: Danger


FR termdebug: add :BreakToggle command

Can we have a BreakToggle command ? like in most IDE ?
Currently, the primitive Clear and Break commands are hard to use and will occupy two keymaps.
If we have a BreakToggle, I can bind it to <space> and just use <space> to set or clear break points.
Adding a toggle command will not remove the existing ones.

Originally posted by @skywind3000 in https://github.com/vim/vim/issues/12875#issuecomment-1688740532
I also "vote" for this feature, as noted in the referenced (not directly related) PR the existing commands are indeed useful as they are, but an additional command would be useful.
It would check for at least one existing breakpoint (s:breakpoint_locations[bploc]) [refactoring that part out of s:ClearBreakpoint()] and if it exits execute call s:SendCommand('-interpreter-exec mi "clear' . at . '"') [as there seems to be no mi command available] and call unlet s:breakpoint_locations[bploc], otherwise call s:SetBreakpoint(at).
... that seems actually quite easy. Once the open frame related PRs are included I'd volunteer to add it.

What do we want to do if multiple breakpoints are set in one location? I guess we could just always require a user to supply the br number, but that would kind of break the "easy mapping"

As mentioned the toggle would "totally hard" just clear every bp at that location.

Ok so not so much a toggle as delete/create?
Would enable/disable not work better if breakpoints already exist? I feel like
toggle might be confusing otherwise.
Maybe an actual separate buffer that lists all the breakpoints and allows you
to toggle individual ones from there would be a nicer solution?

@laburnumT talks about Toggle the breakpoint enabling while @skywind3000 asked for toggling "there is a breakpoint or there isn't one".
Note that I do have a work-in-progress :BreakInfo (new window that shows all the breakpoints and watchpoints), I've just rechecked that it does work in general. If you find that useful and want to work on that, then I can PR what I have so far.
Currently that window is "display and auto-refresh only", there are no actual features in that window (delete, toggle enable/disable, maybe even "make [un]conditional" and "adjust commands" - but those could be done later).

thanks, the "toggle breakpoint" feature is very common in most IDEs:
Visual Studio:

CLion:

This is the most frequently used feature in IDEs, so much so that CLion has placed it at the top.
At the same time, the "Toggle Breakpoint" feature in all IDEs refers to creating or deleting breakpoint on the same line.
Changing the conventional functionality will introduce confusion and future complexity.

If that is the default behaviour ide's and other editors have ended up using,
then I agree vim probably shouldn't deviate from that.
I guess if you want the more "gdb" way of doing things, the gdb window is still
there.

The only place where Termdebug has the "old" commands is the context menu https://github.com/vim/vim/blob/544b209a2d4b10e0a4874c925036def30d33d708/runtime/pack/dist/opt/termdebug/plugin/termdebug.vim#L1026-L1034 and I think that's fine to stay as is.
When the new command :BreakToggle is added (that clears all bps if there is one, otherwise create a new) then we should consider to place place that in the winbar, too. @skywind3000 wants to map it to  (in normal mode), and while I wouldn't like that to be a default (because it can be "destructive" if one has "extended" breakpoint us) it is absolutely fine to do that on a user side.
@laburnumT: Do you think you'd find the time to switch a "display only breakpoint window" to a selectable list with the option to delete the currently marked line / toggle enable/disable for it) in the near future?`If yes then I'll try to do a PR for the "simple" display one soon.

@laburnumT: Do you think you'd find the time to switch a "display only breakpoint window" to a selectable list with the option to delete the currently marked line / toggle enable/disable for it) in the near future?`If yes then I'll try to do a PR for the "simple" display one soon.

I'm currently on holiday. But I can definitely look at it once I'm back.

A :BreakToggle command will be enough for me, I can map it in my .vimrc .
Presence in the winbar or popup menu would be appreciated, and it's OK for me if it can't be displayed on the winbar or popup menu.


Hide separator between menu and pages.

Maybe it is already implemented. But how can I customize menu?

Do you know how to hide separator?


[QA] rename QuestionAnsweringAuthoring->AuthoringClient

API change check
APIView has identified API level changes in this PR and created following API reviews.
azure-ai-language-questionanswering


fix: verb conjugation for imati, iměti

Resolves #36.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

116 of 123 (94.31%)  changed or added relevant lines in 6 files are covered.
1 unchanged line in 1 file lost coverage.
Overall coverage increased (+0.3%) to 92.532%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/verb/conjugationVerb.ts
45
52
86.54%

Files with Coverage Reduction
New Missed Lines
%

src/verb/conjugationVerb.ts
1
88.73%

Totals

Change from base Build<PHONE_NUMBER>:
0.3%

Covered Lines:
1709

Relevant Lines:
1787

💛  - Coveralls

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Warning: This coverage report may be inaccurate.
This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

For more information on this, see Tracking coverage changes with pull request builds.
To avoid this issue with future PRs, see these Recommended CI Configurations.
For a quick fix, rebase this PR at GitHub. Your next report should be accurate.

Details

19 of 23 (82.61%)  changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.02%) to 92.532%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/verb/conjugationVerb.ts
18
22
81.82%

Totals

Change from base Build<PHONE_NUMBER>:
0.02%

Covered Lines:
1709

Relevant Lines:
1787

💛  - Coveralls


List Filters to use dynamic filtering

It would give a much more dynamic feeling with immediate feedback if we could filter as we type. The results in the lists immediately reflect whatever is in the filter box without having to hit return.

@mtho11 what is needed from the UX team on this topic?

@abonas just if this is a patternfly acceptable way of handling user input.

It looks like PF3 is using: https://ericgio.github.io/react-bootstrap-typeahead/

ok now it's clear. yes, let's ask that :)

Here is the jira: https://issues.jboss.org/browse/KIALI-2347

Note that Kiali is using multi-dimensional filters with multiple values.
So not sure how this proposal suits the current feature.
Adding dynamic typing sounds a big refactoring about how this component works.
Just an example:
http://patternfly-react.surge.sh/patternfly-3/index.html?knob-Show Help=true&selectedKind=patternfly-react%2FForms and Controls%2FFilter&selectedStory=Filter&full=0&addons=1&stories=1&panelRight=0&addonPanel=storybooks%2Fstorybook-addon-knobs

This does seem to be much more complex than I originally thought.  This is something we should re-consider when we start adopting more PF4 IMO

Outdated.
Kiali already has some support for some filters but due multi-dimensional nature, it can't be implemented as requested in this issue.


add tensorshare to featured projects

Hi, this PR adds tensorshare has a project using safetensors!

LGTM. Thanks for sharing !

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.


[Link with icon]: Icon placement not changing

Describe the issue:

What did you expect to happen? What happened instead?

The Link With Icon's icon placement is not changing if chosen to be on the left, stays right.

Component(s) impacted? Please include screenshots, or code and relevant URLs.

Link with icon

What version of Carbon for IBM.com are you using?

Web Components Canary
Steps to reproduce the issue (if applicable):

Change icon-placement knob to left
Nothing changes

just ran into this while working on #6265, I have a potential fix but just need design confirmation on what the behavior should be when icon placement is on the left and text is wrapping, since the icon wraps inline with text when it's placed on the right side (most of the time)

related https://github.com/carbon-design-system/carbon-for-ibm-dotcom/issues/5705 https://github.com/carbon-design-system/carbon-for-ibm-dotcom/pull/6812 cc @shixiedesign

this may also be a storybook only issue as it seems to function properly when the icon placement knob is changed and the storybook canvas is opened in a new tab

Here's the link with icon text wrapping spec & example. @emyarod


Allow casts to bool

What is wrong?
There's no way to cast a numeric type to a bool.
error: `bool` type is not callable
    ┌─ src/evm.fe:186:12
    │
186 │     return bool(__call(g, u256(addr), value, in_, insize, out, outsize))
    │            ^^^^

How can it be fixed
I guess we have to decide whether we want to guarantee that true == 0x01. If yes, we have to perform some work when a value is cast to bool. If not, we have to be careful when checking bool values for equality.

Linking to a code place that should be updated when this issue gets tackled: https://github.com/ethereum/fe/pull/629/files#diff-ac6810a6999cf1674a973d738ac5c3f497a50e957c9845f7306275af577d1c0bR118


Integrate Bitcoin Cash and Zcash

Coverage remained the same at 27.379% when pulling a6d8d33566da7c88cb6b339f3433cb53030f6e63 on altcoins into 5823870a42f961952769a9cd41e52d2a655cf7d9 on master.

Coverage remained the same at 27.379% when pulling cf08a7fd69d89192b84f2eb9754589ed7b337af4 on altcoins into 5823870a42f961952769a9cd41e52d2a655cf7d9 on master.

Coverage remained the same at 27.379% when pulling cf08a7fd69d89192b84f2eb9754589ed7b337af4 on altcoins into 5823870a42f961952769a9cd41e52d2a655cf7d9 on master.

Coverage remained the same at 27.379% when pulling 834c7330041682d0c3dfd14c382219eff9e13e2d on altcoins into 5823870a42f961952769a9cd41e52d2a655cf7d9 on master.

Coverage decreased (-0.4%) to 26.989% when pulling 823da859a48e3c0940f80461aeb3a668e142e455 on altcoins into 5823870a42f961952769a9cd41e52d2a655cf7d9 on master.

Coverage decreased (-0.4%) to 26.989% when pulling 38727a544c7d9954e13d9444aab47cbddd1b75eb on altcoins into 5823870a42f961952769a9cd41e52d2a655cf7d9 on master.

@daira : Bitcoin Cash doesn't have RBF either.  It was ripped out before the fork because it broke 0-conf and allows malicious double-spends.  Merchants don't want to have to worry about that so OpenBazzar shouldn't depend on it (but might have to support it on the BTC chain because of the small-block problem, where it's a kludge that causes additional risk).

@daira I think it does. I could change it if that's best.

Tested on Bitcoin Cash. Starting on Zcash (except RBF).

Coverage decreased (-0.4%) to 26.989% when pulling 010189b3aa8855fa179b839e57ebb39cd9c510f7 on altcoins into 5823870a42f961952769a9cd41e52d2a655cf7d9 on master.

Coverage decreased (-0.4%) to 26.985% when pulling 7b662dcca48ca61a3dac6880c1259187c30b417b on altcoins into 5823870a42f961952769a9cd41e52d2a655cf7d9 on master.

Coverage decreased (-0.4%) to 26.985% when pulling 8908fe9d1af8b3cdaadae1b1a4aaa5816a56a3f1 on altcoins into 5823870a42f961952769a9cd41e52d2a655cf7d9 on master.

Coverage decreased (-0.4%) to 26.985% when pulling 30747a64b71a6a00c0ac8dee29f1859b0efe883f on altcoins into 5823870a42f961952769a9cd41e52d2a655cf7d9 on master.

Coverage decreased (-0.4%) to 26.985% when pulling 543e99dae1270f98a80c4a9fb562a29572c35a8a on altcoins into 5823870a42f961952769a9cd41e52d2a655cf7d9 on master.

Coverage decreased (-0.4%) to 26.945% when pulling 844abcca758da71809810e897e5ec9a110108a0b on altcoins into 5823870a42f961952769a9cd41e52d2a655cf7d9 on master.

Coverage decreased (-0.4%) to 26.945% when pulling a224bd283aafa2451cc8eb6471dd6d9740523f36 on altcoins into 5823870a42f961952769a9cd41e52d2a655cf7d9 on master.

Coverage decreased (-0.4%) to 26.945% when pulling 316e68ddf1a35cf4d932407d647e27d5d1d0b6b5 on altcoins into 5823870a42f961952769a9cd41e52d2a655cf7d9 on master.

Coverage decreased (-0.4%) to 26.938% when pulling 934573f61a007f82da226b912314fcf837c3b5d1 on altcoins into 5823870a42f961952769a9cd41e52d2a655cf7d9 on master.

Coverage decreased (-0.4%) to 26.938% when pulling a35c83244a09653dfd4130e04c44f208a63fce6b on altcoins into 5823870a42f961952769a9cd41e52d2a655cf7d9 on master.

Coverage decreased (-0.4%) to 26.938% when pulling 34cbe53eba06ebd1442de2c34fdec9df6d49b44f on altcoins into 5823870a42f961952769a9cd41e52d2a655cf7d9 on master.

Coverage increased (+0.05%) to 26.938% when pulling e90dc6d2be8ac6372465dfc9083c19ebe3154464 on altcoins into 0c14c63a8eb02b741d8d827a5786433ca102ee07 on master.

Here is the tail end of my ob1.logs:
14:49:13.725 [newHTTPGateway] [INFO] Gateway/API server listening on /ip4/<IP_ADDRESS>/tcp/4002
14:49:25.615 [New] [INFO] OpenBazaar service running at /openbazaar/app/testnet/1.0.0
14:49:26.140 [func4] [INFO] Starting zcashd wallet
14:49:28.196 [Publish] [INFO] Published zdj7WfKzbcdgYXM4zjKQ8hMXauSn64iV5suCjmSzt2eMNHb7P to IPNS
14:50:01.396 [func1] [CRITICAL] Failed to connect to zcashd

It looks like the OB server quietly dies. It would be nice to have some sort of communication to the client to let the user know they have a zcash misconfiguration.

@cpacia
I was playing with this branch and testing out the use of Bitcoin Cash. I was using the Bitcoin Cash testnet.  I waited about two hours, but the money never came through. The OB wallet said 0 confirmations, even after waiting a couple hours and restarting the server. I was able to pull up the transaction online and verify that it succeeded and got several confirmations.
I've seen this same issue with the Bitcoin testnet, so I don't think this is exclusive to this branch, but it does seem to be a recurring problem that probably has side effects to this branch.
Here is the tail of my bitcoin.log:
14:18:56.318 [onMerkleBlock] [WARNING] Header 000000003f2404a220526e49eb6e6445d5849c6de58ef3af4805946d25d18cfb does not extend any known headers
14:18:56.646 [onMerkleBlock] [WARNING] Header 000000003f2404a220526e49eb6e6445d5849c6de58ef3af4805946d25d18cfb does not extend any known headers
14:18:56.658 [onMerkleBlock] [WARNING] Header 000000003f2404a220526e49eb6e6445d5849c6de58ef3af4805946d25d18cfb does not extend any known headers
14:18:56.712 [onMerkleBlock] [WARNING] Header 000000003f2404a220526e49eb6e6445d5849c6de58ef3af4805946d25d18cfb does not extend any known headers
14:20:25.786 [onMerkleBlock] [WARNING] Header<PHONE_NUMBER>17336afadf1f4b1f93b2e703d6e41b293b2fd09771a264adb7ee96 does not extend any known headers
14:20:25.905 [onMerkleBlock] [WARNING] Header<PHONE_NUMBER>17336afadf1f4b1f93b2e703d6e41b293b2fd09771a264adb7ee96 does not extend any known headers
14:28:57.908 [onMerkleBlock] [WARNING] Header<PHONE_NUMBER>f51de6453c9278ab94c6acda2805ec1622b7f4d065ac16fa8db08f does not extend any known headers
14:28:58.007 [onMerkleBlock] [WARNING] Header<PHONE_NUMBER>f51de6453c9278ab94c6acda2805ec1622b7f4d065ac16fa8db08f does not extend any known headers
14:36:47.795 [onMerkleBlock] [WARNING] Header<PHONE_NUMBER>308dba6a1cbfa88a7ded9fdd02c853a7e8492361aaa7a857f12bd7 does not extend any known headers
14:36:48.239 [onMerkleBlock] [WARNING] Header<PHONE_NUMBER>308dba6a1cbfa88a7ded9fdd02c853a7e8492361aaa7a857f12bd7 does not extend any known headers
14:36:51.594 [onMerkleBlock] [WARNING] Header<PHONE_NUMBER>bee8e37194cf0030ac36bcc0bf54d3e9d2cb17a66e56e86e9dcecd does not extend any known headers
14:36:51.693 [onMerkleBlock] [WARNING] Header<PHONE_NUMBER>bee8e37194cf0030ac36bcc0bf54d3e9d2cb17a66e56e86e9dcecd does not extend any known headers
14:50:36.076 [onMerkleBlock] [WARNING] Header<PHONE_NUMBER>403aa770f1109b644329cdcc5ed57698fcb81a78150fad574c0282 does not extend any known headers
14:50:36.083 [onMerkleBlock] [WARNING] Header<PHONE_NUMBER>403aa770f1109b644329cdcc5ed57698fcb81a78150fad574c0282 does not extend any known headers
14:50:36.098 [onMerkleBlock] [WARNING] Header<PHONE_NUMBER>403aa770f1109b644329cdcc5ed57698fcb81a78150fad574c0282 does not extend any known headers
14:50:36.284 [onMerkleBlock] [WARNING] Header<PHONE_NUMBER>403aa770f1109b644329cdcc5ed57698fcb81a78150fad574c0282 does not extend any known headers
14:50:36.351 [onMerkleBlock] [WARNING] Header<PHONE_NUMBER>403aa770f1109b644329cdcc5ed57698fcb81a78150fad574c0282 does not extend any known headers
14:50:36.475 [onMerkleBlock] [WARNING] Header<PHONE_NUMBER>403aa770f1109b644329cdcc5ed57698fcb81a78150fad574c0282 does not extend any known headers
14:50:36.475 [onMerkleBlock] [WARNING] Header<PHONE_NUMBER>403aa770f1109b644329cdcc5ed57698fcb81a78150fad574c0282 does not extend any known headers
14:50:36.483 [onMerkleBlock] [WARNING] Header<PHONE_NUMBER>403aa770f1109b644329cdcc5ed57698fcb81a78150fad574c0282 does not extend any known headers
14:50:36.512 [onMerkleBlock] [WARNING] Header<PHONE_NUMBER>403aa770f1109b644329cdcc5ed57698fcb81a78150fad574c0282 does not extend any known headers
14:50:36.947 [onMerkleBlock] [WARNING] Header<PHONE_NUMBER>403aa770f1109b644329cdcc5ed57698fcb81a78150fad574c0282 does not extend any known headers
14:52:23.131 [onMerkleBlock] [WARNING] Header<PHONE_NUMBER>74685417e3e2fc598c340e64d706b9fc4e3050cd3d8c97af5af4dc does not extend any known headers
14:52:24.407 [onMerkleBlock] [WARNING] Header<PHONE_NUMBER>74685417e3e2fc598c340e64d706b9fc4e3050cd3d8c97af5af4dc does not extend any known headers
15:04:53.884 [onMerkleBlock] [WARNING] Header 000000005f37e397b7f83e3bad2a3ad1ab118f24877563fd436d51aab76420cb does not extend any known headers
15:04:54.138 [onMerkleBlock] [WARNING] Header 000000005f37e397b7f83e3bad2a3ad1ab118f24877563fd436d51aab76420cb does not extend any known headers
15:09:02.101 [onMerkleBlock] [WARNING] Header<PHONE_NUMBER>3a1ac83b4b975a14ad5db41174c48d730fee6f6f9ec3f7bdf3bac1 does not extend any known headers
15:09:02.233 [onMerkleBlock] [WARNING] Header<PHONE_NUMBER>3a1ac83b4b975a14ad5db41174c48d730fee6f6f9ec3f7bdf3bac1 does not extend any known headers
15:24:52.793 [Start] [INFO] Loaded 1210 peers from cache
15:24:53.036 [onVerack] [DEBUG] Connected to <IP_ADDRESS>:18333 - /Bitcoin ABC:0.15.1(EB8.0)/
15:24:53.051 [setDownloadPeer] [INFO] Setting peer1 (/Bitcoin ABC:0.15.1(EB8.0)/) as download peer
15:24:53.051 [startChainDownload] [INFO] Chain download complete
15:24:53.188 [onGetData] [DEBUG] Received getdata request from Peer1
15:24:53.188 [onGetData] [DEBUG] Sent 1 of 1 requested items to Peer1
15:24:53.304 [onGetData] [DEBUG] Received getdata request from Peer1
15:24:53.304 [onGetData] [ERROR] Error getting tx 85d1057f9d9fcbe55c51c351e795615bf6c83bf3d36424149f4e7e7dd7b07e43: sql: no rows in result set
15:24:53.304 [onGetData] [DEBUG] Sent 0 of 1 requested items to Peer1
15:24:53.318 [onVerack] [DEBUG] Connected to <IP_ADDRESS>:18333 - /Bitcoin ABC:0.15.0(EB8.0)/
15:24:53.376 [onVerack] [DEBUG] Connected to <IP_ADDRESS>:18333 - /Bitcoin ABC:0.16.1(EB8.0)/
15:24:53.398 [onVerack] [DEBUG] Connected to <IP_ADDRESS>:18333 - /Bitcoin ABC:0.16.0(EB8.0)/
15:24:53.409 [onDisconnection] [DEBUG] Peer5 disconnected
15:24:53.414 [onVerack] [DEBUG] Connected to <IP_ADDRESS>:18333 - /Bitcoin ABC:0.16.0(EB8.0)/
15:24:53.577 [onVerack] [DEBUG] Connected to <IP_ADDRESS>:18333 - /Bitcoin ABC:0.16.1(EB8.0)/
15:24:54.032 [onVerack] [DEBUG] Connected to <IP_ADDRESS>:18333 - /Bitcoin ABC:0.16.0(EB8.0)/
15:24:54.201 [onDisconnection] [DEBUG] Peer9 disconnected
15:24:54.431 [onVerack] [DEBUG] Connected to <IP_ADDRESS>:18333 - /Bitcoin ABC:0.16.1(EB8.0)/
15:27:03.006 [onVerack] [DEBUG] Connected to <IP_ADDRESS>:18333 - /Bitcoin ABC:0.16.0(EB8.0; bitcore)/
15:27:03.024 [onVerack] [DEBUG] Connected to <IP_ADDRESS>:18333 - /Bitcoin ABC:0.16.1(EB8.0)/
15:29:14.224 [onVerack] [DEBUG] Connected to <IP_ADDRESS>:18333 - /Bitcoin ABC:0.16.1(EB8.0)/
15:32:26.625 [onMerkleBlock] [WARNING] Header<PHONE_NUMBER>1728641941a0f72563e3f1b8d8bea039eb189cbc6410ed8c503dba does not extend any known headers
15:32:26.629 [onMerkleBlock] [WARNING] Header<PHONE_NUMBER>1728641941a0f72563e3f1b8d8bea039eb189cbc6410ed8c503dba does not extend any known headers
15:33:42.127 [onVerack] [DEBUG] Connected to <IP_ADDRESS>:18333 - /Bitcoin ABC:0.16.0(EB8.0)/

A quick update on the last comment. I shut down the OB server and booted it back up 24 hours later. The BCH came through and the wallet is showing accurate confirmations (40 at the moment).

@christroutner I suspect the problem might be that there are pre-harkfork versions of bitcoin-abc nodes running on the testnet. If you connect to one of them you could end up on the wrong chain. This should rectify itself if you connect to a correct node.
But I might make it refuse to connect to abc < 0.16


[📚] Your documentation feedback title (Firebase getIdToken Nullability Bug Report)

Please describe your documentation issue or suggested improvement in detail here and provide links to any pre-existing/relevant documentation and screenshots if necessary:
You are correct that the result of User.getIdToken was recently made nullable. This change was made in the Firebase SDKs for Android and iOS in version 19.2.0, and in the Web SDK in version 9.2.0.
The Firebase documentation does not currently specify under which circumstances null is returned from User.getIdToken. However, there are a few possible reasons why this might happen:
The user is not signed in.
The user's token has expired.
The user's token has been revoked.
There is an error with the Firebase SDK.
If you are getting a null value from User.getIdToken, you can try the following to troubleshoot the issue:
Check to make sure that the user is signed in.
Check the expiration date of the user's token.
Check to see if the user's token has been revoked.
Update the Firebase SDK to the latest version.
If you are still getting a null value from User.getIdToken after troubleshooting, you can file a bug report with the Firebase team.
As for the other fields of IdTokenResult, they are not nullable on the other platforms because they are not required to be. For example, the token_expiry field is only required if you need to know when the user's token will expire. If you don't need this information, then you can ignore the token_expiry field.
I hope this helps!

Hi @Ramghosh16RG, are you responding to a particular issue or reporting an issue with the documentation? If the former, please comment on that issue instead. If the latter, kindly share which part of the documentation you are reporting the issue with. Your issue as it stands now is not clear on what it is trying to achieve.
Thank you

My previous responses were based on a hypothetical scenario where there was a known issue with the Firebase documentation, specifically related to the nullable return type of User.getIdToken in some SDK versions. However, this hypothetical issue was not based on any real or specific documentation problem.
The Firebase documentation lacks information about under which circumstances null is returned from User.getIdToken in the Android, iOS, and Web SDKs after the recent update that made the return value nullable.

I believe this is a duplicate of https://github.com/firebase/flutterfire/issues/11386.
Closing this in favor of the issue linked above. Feel free to share your comment in the issue.
Thank you


WARNING: JNI local refs: 35, exceeds capacity: 34

After upgrading JDK 8 I get these two warnings when running the test-suite:
     [java] WARNING: JNI local refs: 35, exceeds capacity: 34
     [java] 	at java.lang.ClassLoader$NativeLibrary.load(Native Method)
     [java] 	at java.lang.ClassLoader.loadLibrary0(ClassLoader.java:1938)
     [java] 	- locked <0x000000076ab067d0> (a java.util.Vector)
     [java] 	- locked <0x000000076ab55718> (a java.util.Vector)
     [java] 	at java.lang.ClassLoader.loadLibrary(ClassLoader.java:1821)
     [java] 	at java.lang.Runtime.load0(Runtime.java:809)
     [java] 	- locked <0x000000076ab1ae20> (a java.lang.Runtime)
     [java] 	at java.lang.System.load(System.java:1086)
     [java] 	at com.dropbox.djinni.NativeLibLoader.loadLibrary(NativeLibLoader.java:171)
     [java] 	at com.dropbox.djinni.NativeLibLoader.loadLibsFromLocalPath(NativeLibLoader.java:95)
     [java] 	at com.dropbox.djinni.NativeLibLoader.loadLibs(NativeLibLoader.java:80)
     [java] 	at com.dropbox.djinni.test.AllTests.main(AllTests.java:28)
     [java] Oct 28, 2015 1:25:55 AM com.dropbox.djinni.NativeLibLoader loadLibrary
     [java] INFO: Loaded djinni/djinni/test-suite/java/build/local/lib/libDjinniTestNative.dylib
     [java] WARNING: JNI local refs: 36, exceeds capacity: 35
     [java] 	at org.junit.runner.JUnitCore.<init>(JUnitCore.java:29)
     [java] 	at org.junit.runner.JUnitCore.runMainAndExit(JUnitCore.java:47)
     [java] 	at org.junit.runner.JUnitCore.main(JUnitCore.java:40)
     [java] 	at com.dropbox.djinni.test.AllTests.main(AllTests.java:29)
     [java] JUnit version 4.11

Some Googling indicates some warnings were added at last year in JDK8.
https://bugs.openjdk.java.net/browse/JDK-8046668
related discussions:
https://community.oracle.com/message/13290783
https://bugs.openjdk.java.net/browse/JDK-8046668
Looks like there isn't necessarily wrong when seeing this warning (unlike the missed exception checking ones) though to tone down the annoying we may want to preemptively release local refs, use PushLocalFrame/PopLocalFrame, or use EnsureLocalCapacity to provide more space up front (this last one seems brittle).  Or if we can find some way, suppressing these particular highly conservative local ref warnings without supporting the other warnings (like checking for exceptions) might be reasonable.

Sounds like an off-by-one on our part, since djinni generally does try to be careful with LocalRef accounting (E.g. by PushLocalFrame-ing sufficient capacity)

I don't think it's an off-by-one.  I think it's a case where we're not manually freeing JNI local refs, but depending on them being freed on return to Java, which is a legitimate thing to do when the usage local and bounded.  The warnings I see are "35 exceeds 34" followed by "36 exceeds 35" which I interpret as simply printing each time we go over the previously-allocated capacity by one, presuming 34 is the default capacity, plus whatever extra we might've allocated.
Regardless, this seems to be happening during init, so it's the class initializers which must be behind it.  Since those are implemented in a helper class which doesn't know where it might be called, it's probably not actually legit for them to depend on free-on-return behavior, so this might be an actual leak of refs they're creating but not cleaning up.  I'll investigate.

Yep, found it.
Fixed in commit @53fd6bc70f546e46986b423a3a3d5ca137db0733.


mcfly: 0.5.0 -> 0.5.1

Motivation for this change
https://github.com/cantino/mcfly/releases/tag/v0.5.1
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[x] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.


support passing byte arrays to encoder

The purpose here is to enable using solidity hex literals hex:"00ff" as arguments in browser-solidity. You can try it at http://cdetrio.github.io/browser-solidity.
This works in conjunction with dirty-json-hex, which browser-solidity uses to parse solidity hex literals into byte arrays. The byte arrays are then passed to ethereumjs-abi encoder.
Alternatively, ethereumjs-abi could accept hex literals directly, even though they aren't valid json. Or it could accept both byte arrays and hex literals. thoughts?

Coverage decreased (-1.9%) to 81.194% when pulling 7543340aaacb58886e0323f6f850ae6ac097df87 on cdetrio:master into 5f4117a35be6ff79865e05b122915303516ba0c2 on ethereumjs:master.

Is this still actual?

While I think this is a simple and nice addition for some developers, this seems to be more of a developer convenience than a necessity. The work to pass hex literals to the encoder can be done externally to ethereumjs-abi, and this is not needed to meet any specification. I would suggest closing this PR and reopening only if developer demand increases.

Will follow the advice from @danjm and close, everyone feel free to reopen if there's a need.


Cell names are case sensitive

Currently you cannot have two cells with the same name but different capitalization, because of the way the sorts which are produced get named. Example (with kompile --backend haskell test.k):
module TEST
    imports BOOL
    imports STRING

    configuration <k> $PGM:String </k>
                  <pot-pie> 0 </pot-pie>
                  <pot-Pie> 0 </pot-Pie>
endmodule

Produced output (on latest release at time of writing v5.0.0-71d191f):
[Error] Compiler: Too many productions for cell sort: PotPieCell
[Warning] Compiler: Could not find main syntax module with name TEST-SYNTAX in
definition.  Use --syntax-module to specify one. Using TEST as default.

Expected behavior: give different sort names for the two cells so that we can have our pie and eat our Pie too.

We don't have a backwards compatible way to do this, so it's become low priority.