Destroy the existing chart

Expected Behaviour
Destroy the existing chart.
Actual Behaviour
Steps to Reproduce:

NOTE: Add a GIF/Screenshot if required.
Frappé Charts version:

I do not know how to destroy a chart.
	bind_window_events() {
		window.addEventListener('resize', () => this.refresh());
		window.addEventListener('orientationchange', () => this.refresh());
	}

Events on the window can not be canceled.

@lanjingling0510 Not sure of how else we could handle events like these, could you guide on it?

https://github.com/frappe/charts/blob/master/dist/frappe-charts.esm.js#L1192
You can't remove a listener if you pass an anonymous function to it
Do something like this instead maybe
listenToMe () {
  this.draw(true)
}

configure () {
  window.addEventListener('resize', this.listenToMe);
  window.addEventListener('orientationchange', this.listenToMe);
}

destroy () {
  window.removeEventListener('resize', this.listenToMe);
  window.removeEventListener('orientationchange', this.listenToMe);
}

I hope the maintainers can pass the opened PRs, e.g. https://github.com/frappe/charts/pull/94 which deals with this issue. It has been there for 3 months.

unbindWindowEvents is meaningless for the public API & not future proof, a destroy method which call unbindWindowEvents would be better

@pratu16x7 can you fix line 94 and 103 please? it should be the same way as line 93 and 102:
https://github.com/frappe/charts/blob/a47a4d0eb786de169a05fa1b526ce07c43b3b6b9/src/js/charts/BaseChart.js#L92-L94

Also to point out that the current implementation only works when there is 1 chart in the DOM. If there are 2, only 1 can successfully unbind. The fix is to associate BOUND_DRAW_FN to this, i.e.:
this.BOUND_DRAW_FN = this.boundDrawFn.bind(this);
window.addEventListener('resize', this.BOUND_DRAW_FN);
window.removeEventListener('resize', this.BOUND_DRAW_FN);

This bug is hard to tell b/c removeEventListener can silently fail, but you can reproduce it following https://stackoverflow.com/questions/34079323/how-do-i-know-that-removeeventlistener-was-successful.

@pratu16x7 I can make a PR for the above issue if you'd prefer.

@t47io Please do :) Will make sure to merge it asap.

Can be closed
https://github.com/frappe/charts/pull/164


[improve] Use Google re2/j library for user provided regexes

Motivation
Google RE2/J library provide regex library that has worst case linear time processing of pattern, as opposed to standard JDK regexes which could have recursive processing. It's better to avoid these corner cases by just swapping the Pattern class implementation. It's a drop-in replacement for the basic methods we're using, and RE2/J is already a transitive dependency.
Documentation

[ ] doc
[ ] doc-required
[X] doc-not-needed
[ ] doc-complete

Matching PR in forked repository
PR in forked repository:

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 73.26%. Comparing base (bbc6224) to head (797703c).
Report is 340 commits behind head on master.

Additional details and impacted files

@@             Coverage Diff              @@
##             master   #22829      +/-   ##
============================================
- Coverage     73.57%   73.26%   -0.32%
- Complexity    32624    32955     +331
============================================
  Files          1877     1888      +11
  Lines        139502   141764    +2262
  Branches      15299    15559     +260
============================================
+ Hits         102638   103858    +1220
- Misses        28908    29880     +972
- Partials       7956     8026      +70

Flag
Coverage Δ

inttests
27.45% <0.00%> (+2.87%)
:arrow_up:

systests
24.90% <100.00%> (+0.57%)
:arrow_up:

unittests
72.27% <100.00%> (-0.58%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Files
Coverage Δ

...va/org/apache/pulsar/broker/service/ServerCnx.java
72.00% <ø> (-0.15%)
:arrow_down:

...apache/pulsar/broker/service/TopicListService.java
67.20% <ø> (ø)

...ar/client/impl/PatternMultiTopicsConsumerImpl.java
83.45% <ø> (ø)

...rg/apache/pulsar/client/impl/PulsarClientImpl.java
73.85% <100.00%> (-0.45%)
:arrow_down:

...rg/apache/pulsar/client/impl/TopicListWatcher.java
67.14% <ø> (-0.72%)
:arrow_down:

...ava-templates/org/apache/pulsar/PulsarVersion.java
78.12% <ø> (ø)

...ava/org/apache/pulsar/common/topics/TopicList.java
89.65% <ø> (ø)

... and 378 files with indirect coverage changes

@merlimat which branches do we target with this change? do you think that it's safe to cherry-pick this to maintenance branches?

I think it should be fairly safe, given all "normal" regexes should behave in same way as before. At the same time, I don't think there's urgency to patch in stable branches, so I'd say to skip it unless it's needed later.


Hot reload in Webpack broken on >1.0.0

Not sure if this is an issue with riot-hot-reload instead, but posting here since this problem arose when updating riot-tag-loader. Let me know if you'd like me to open this issue in the hot-reload repo instead.

Describe your issue:  Whenever there is a change made in a .tag file, Webpack does compile the change, but the hot reload isn't applied to the component. The change is visible only after a manual page refresh. Hot reloading works fine in regular .js files.

Can you reproduce the issue? Yes, even the Webpack example is broken. Steps to reproduce below.

Clone or download the example repo
Go to the Webpack directory
Run npm install -D riot-compiler (since the compiler seems to be missing)
Go to localhost:3000 or localhost:3000/webpack-dev-server to see that the app is running
Change, e.g. the Generate button text to something else in random.tag
Go back to localhost:3000
Nothing changed, but in console there are logs about HMR happening

On which browser/OS does the issue appear? macOS Sierra, Chrome 63

Which version of Riot does it affect? >=3.7.4

How would you tag this issue?

[ ] Question
[x] Bug
[ ] Discussion
[ ] Feature request
[ ] Tip
[ ] Enhancement
[ ] Performance

fixed thank you!


Scoped package and dynamic require

When using "dynamic requires", it seems that webpack is unable to deal with npm scoped packages, i.e.
require("my-module/lib/" + dynamicOne + "/" + dynamicTwo + ".ext");

works while
require("@my/module/lib/" + dynamicOne + "/" + dynamicTwo + ".ext");

doesn't. Moreover, I tried to use the following alias as a workaround:
"my-module": "@my/module"

to no avail.
Searching turned up nothing except https://github.com/webpack/webpack/issues/1256 which seems to be a similar issue, albeit a different one.

I think I'm just crazy, sorry for the noise.


Allow listing limit only on available values

Description
Please describe your pull request:

Why is it necessary?
I can go to very big shops with big categories and call the listing page with 99999 limit and use useless cpu and space(http-caching)
What does it improve?
Sets the default listing limit, if limit value is not available
Does it have side effects?
Nope

Questions
Answers

BC breaks?
no

Tests pass?
yes

Related tickets?

How to test?
Use limit 9999 or something else in listing page

Maybe this problem has to be addressed in a more general way. Since also problems can occoure when passing the parameter max={581.00} with any possible price value this query: https://github.com/shopware/shopware/blob/27507fe404cede0b75ad561fc081ce4fc9554569/engine/Shopware/Bundle/SearchBundleDBAL/FacetHandler/PriceFacetHandler.php#L134  is executed.
In our shop installation this is called with the root category id (3 in our case).
In larger shop installations without elastic search this query can take over 200s and the query is executed twice.
I am still debugging the problem, since in the installation this problem occours randomly and we have not figured out where exactly this problem comes from.

I have debugged the problem a bit further and the problem in our case was, that there existed a modified robots.txt which did not disallowed /listing so we had requests in the following way from the BingBot:
"URI": "/listing/?p=1&s=124",
"Params": {
    "p":"1",
    "s":"124",
    "module":"frontend",
    "controller":"listing",
    "action":"index",
    "sPage":"1",
    "sSupplier":"124",
    "sCategory":3
},
"Referer": false,
"User Agent": "Mozilla/5.0 (compatible; bingbot/2.0; +http://www.bing.com/bingbot.htm)"

which then triggered the query mentioned in the previous comment on the whole shop. The query looks like the following:
SELECT Min(Round(defaultPrice.price * ( ( 100 - Ifnull(priceGroup.discount, 0) )
                                        / 100
                                             ) *
                            ( ( (
                                  CASE tax.id
                                  WHEN 1 THEN 19
                                  WHEN 4 THEN 7
                                  WHEN 5 THEN 0
                                  end ) + 100 ) / 100 ) * 1, 2)) AS
       cheapest_price
FROM   s_articles product
       INNER JOIN s_articles_details variant
               ON variant.id = product.main_detail_id
                  AND variant.active = 1
                  AND product.active = 1
       INNER JOIN s_core_tax tax
               ON tax.id = product.taxid
       INNER JOIN s_articles_categories_ro productCategory16
               ON productCategory16.articleid = product.id
                  AND productCategory16.categoryid IN ( 3 )
       LEFT JOIN s_articles_avoid_customergroups avoidCustomerGroup
              ON avoidCustomerGroup.articleid = product.id
                 AND avoidCustomerGroup.customergroupid IN ( 1 )
       INNER JOIN s_articles_details availableVariant
               ON availableVariant.articleid = product.id
                  AND availableVariant.active = 1
       INNER JOIN s_articles_prices defaultPrice
               ON defaultPrice.articledetailsid = availableVariant.id
                  AND defaultPrice.pricegroup = 'EK'
                  AND defaultPrice.from = 1
       LEFT JOIN s_articles_prices customerPrice
              ON customerPrice.articleid = product.id
                 AND customerPrice.pricegroup = 'EK'
                 AND customerPrice.from = 1
                 AND availableVariant.id = customerPrice.articledetailsid
       LEFT JOIN s_core_pricegroups_discounts priceGroup
              ON priceGroup.groupid = product.pricegroupid
                 AND priceGroup.discountstart = 1
                 AND priceGroup.customergroupid = '1'
                 AND product.pricegroupactive = 1
       INNER JOIN s_articles_attributes productAttribute
               ON productAttribute.articledetailsid = variant.id
WHERE  avoidCustomerGroup.articleid IS NULL
GROUP  BY product.id
ORDER  BY cheapest_price DESC
LIMIT  1 offset 0

Though there was nothing about the supplier in the query, I am not sure if this is another bug or if this is wanted, I am still debugging this issue further. The shop is running Shopware 5.1.6.

Hello,
thank you for creating this pull request.
I have opened an issue on our Issue Tracker for you. See the issue link: https://issues.shopware.com/issues/SW-17558.
Please use this issue to track the state of your pull request.

Fixed with https://github.com/shopware/shopware/commit/284c657d954d34ea9da65e8399c299d6b651acbb


Argo OnExit does not work properly when using step template in a dag

Summary
Argo OnExit does not work properly when using step template in a dag
Diagnostics
Argo version: v2.9.4
apiVersion: argoproj.io/v1alpha1
kind: Workflow
metadata:
  generateName: dag-primay-branch-
spec:
  entrypoint: statis
  templates:
  - name: a
    container:
      image:  docker/whalesay:latest
      command: [cowsay]
      args: ["hello world"]
  - name: exit
    container:
      image: docker/whalesay:latest
      command: [cowsay]
      args: ["exit!"]
  - name: steps
    steps:
      - - name: step-a
          template: a
  - name: statis
    dag:
      tasks:
      - name: A
        onExit: exit
        template: steps # <--- if change "a", it works!!

In above case, exit will never be called.

Message from the maintainers:
Impacted by this bug? Give it a 👍. We prioritise the issues with the most 👍.

Taking a look now

Able to reproduce

Opened PR to fix 👆

suuper fast! Thank you!!


[IntelliSense] Can't make Jquery detected

VS Code Version: 1.73.1
OS Version: Windows 11 22H2

Steps to Reproduce:
Hello there, i tried with many thing to make IntelliSense detect taht i'm using Jquery, i tried with the jsconfig.json : Nothing
Tried with "reference" : Nothing
I'm kinda lost with the documentation :/
Also i have npm installed on the project (but i dont use it) so I hope it does not conflict..

This sounds like a question on using VSCode
Please start by asking on Stack overflow

We closed this issue because it is a question about using VS Code rather than an issue or feature request. Please search for help on StackOverflow, where the community has already answered thousands of similar questions. You may find their guide on asking a new question helpful if your question has not already been asked. See also our issue reporting guidelines.
Happy Coding!


DEP: signal: deprecate object arrays in sosfilt

This is a follow-up to gh-21211: we deprecated object arrays as inputs to lfilter, but forgot or did not know about sosfilt. These two should probably be in sync, hence follow the lfilter deprecation in sosfilt.

This PR looks "ok" to me, but I believe I found a few issues with the origina/precedent PR in the cross-listed ticket. I'll label that good first issue, since they look like copy-paste errors mostly.


WSL2: eBPF reports incorrect tgid

Windows Version
Microsoft Windows [Version 10.0.26100.2605]
WSL Version
<IP_ADDRESS>
Are you using WSL 1 or WSL 2?

[x] WSL 2
[ ] WSL 1

Kernel Version
Linux version <IP_ADDRESS>-microsoft-standard-WSL2 (root@f9c826d3017f) (gcc (GCC) 11.2.0, GNU ld (GNU Binutils) 2.37) #1 SMP Tue Nov 5 00:21:55 UTC 202
Distro Version
Ubuntu 22.04.5 LTS
Other Software
No response
Repro Steps
I have a simple eBPF tracepoint to listen for a process to exit. When I run it under WSL2 the process id it reports cannot be found in the system.
The code is quite simple:

const volatile pid_t target_userspace_pid = 0;
volatile bool has_exited = false;
volatile int exit_code = 0;

#define MAX_COMMAND_SIZE 64

SEC("tracepoint/sched/sched_process_exit")
int sched_process_exit(struct trace_event_raw_sched_process_template* ctx) {
    u64 pid_tgid = bpf_get_current_pid_tgid();
    // Thread or Task Group ID
    pid_t tgid = pid_tgid >> 32;
    pid_t pid = pid_tgid & 0xffffffff;
    // ignore thread exits
    if (pid != tgid)
        return 0;

    // That's right, Userspace process id is tgid in kernel-space!
    // https://utcc.utoronto.ca/~cks/space/blog/linux/PidsTgidsAndTasks
    pid_t userspace_pid = tgid;

    char command[MAX_COMMAND_SIZE];
    __builtin_memset(command, 0, sizeof(command));
    bpf_get_current_comm(command, sizeof(command));

    // Workaround because on older kernels bpf_printk won't work for more than 3 args, check the note https://docs.ebpf.io/ebpf-library/libbpf/ebpf/bpf_printk/.
    const char fmt[] = "%s";
    char buffer[256];
    BPF_SNPRINTF(buffer, sizeof(buffer), "sched_process_exit: Kernel (pid_tgid %ld, tgid %d, pid %d), Userspace pid: %d, command: %s", pid_tgid, tgid, pid, userspace_pid, command);
    bpf_trace_printk(fmt, sizeof(fmt), buffer);

    if (target_userspace_pid && userspace_pid != target_userspace_pid)
        return 0;

    struct task_struct *task = (struct task_struct *)bpf_get_current_task();
    exit_code = BPF_CORE_READ(task, exit_code)  >> 8;
    has_exited = true;
}

It produces non-existing userspace process ids. I know that because I attached to the Java process with userspace process id 15235, but as you can see it reports it as 21682 in /sys/kernel/debug/tracing/trace_pipe
sudo cat /sys/kernel/debug/tracing/trace_pipe
           <...>-21682   [009] ....1  1605.867150: bpf_trace_printk: sched_process_exit: Kernel (pid_tgid<PHONE_NUMBER>3554, tgid 21682, pid 21682), Userspace pid: 21682, command: java

Expected Behavior
On actual Linux (Ubuntu 24) the tgid (Task Group ID) that is userspace process id matches. This allows the handler properly notify that the attached app exited.
Actual Behavior
Reported tgid (Task Group ID) could not be found in the process list
Diagnostic Logs
No response

/question
I see similar closed issue The pid of the process in wsl2 differs from the pid returned in ebpf program bpf_get_current_pid_tgid(). Should one use bpf_get_ns_current_pid_tgid instead? Then the question how to obtain, probably one can use the same technique as iovisor/bcc ?


Object's scale issue

Hello,
Hello,
sorry for maybe stupid question, but i have this problem: I have model of sunshade with real size 2,4x2x2meters, but when I insert it to our app, it's size doesn't match (picture of that is in attachment). Model (modeled in 1:1) was exported from Blender as glTF file. Google was not too helpfull. Does anyone experience with that? File with glTF file and textures are in attachment.
Thanks.

sunshade.zip

Make sure you have no custom scale factor in your .sfa file.
model: {
      ...
      scale: 1.0, //remove this line or set it to 1.0 and then recreate you sfb file
   },

hello bobekos .... thx for your reaction but we have to work with glTF files. Export what i did was gltf file and there is not scale parameter as you mention here.

hello AlgoRyan... I cleared every pattern which I could, but It didn't help. It still has the wrong scale in the app. I attached gltf and blend file (scene file). What is weird, other smaller models which I have (same export settings as I did in the sunshade model) .. have correct scale.
sunshadeTest.zip

Hi, any progress on this issue? I have similar problem.

nope. I found nothing about this topic.
ut 5. 2. 2019 o 15:23 jknazko<EMAIL_ADDRESS>napísal(a):

Hi, any progress on this issue? I have similar problem.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/google-ar/sceneform-android-sdk/issues/463#issuecomment-460655452,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AruU8giImtOqZO2H3SHD697DtCd41-bvks5vKZPygaJpZM4ZRlks
.


Kafka as default channel provider

Please merge: https://github.com/syedriko/knative-kafka-operator/pull/3

Works as expected!
did install it, using:
cat <<-EOF | kubectl apply -f -
---
apiVersion: operators.coreos.com/v1
kind: OperatorGroup
metadata:
  name: knative-eventing
  namespace: knative-eventing
---
apiVersion: operators.coreos.com/v1alpha1
kind: Subscription
metadata:
  name: knative-kafka-operator-sub
  generateName: knative-kafka-operator-
  namespace: knative-eventing
spec:
  source: knative-kafka-operator
  sourceNamespace: olm
  name: knative-kafka-operator
  channel: alpha
---
apiVersion: eventing.knative.dev/v1alpha1
kind: KnativeEventingKafka
metadata:
  name: knative-eventing-kafka
  namespace: knative-eventing
spec:
  bootstrapServers: my-cluster-kafka-bootstrap.kafka:9092
  setAsDefaultChannelProvisioner: yes
EOF

checked the default-channel-webhook`` ConfigMap and saw that it was updated, to use kafka:
data:
  default-channel-config: |
    clusterdefault:
      apiversion: eventing.knative.dev/v1alpha1
      kind: ClusterChannelProvisioner
      name: kafka
kind: ConfigMap

Creating a channel
Did apply:
apiVersion: eventing.knative.dev/v1alpha1
kind: Channel
metadata:
  name: default-channel
  namespace: default
spec: {}

Saw that a channel got created (k get channels):
default-channel   True             5s

Is it present in Kafka?
yes! Running oc -n kafka exec -it my-cluster-kafka-0 -- bin/kafka-topics.sh --zookeeper localhost:2181 --list I get:
Defaulting container name to kafka.
Use 'oc describe pod/my-cluster-kafka-0 -n kafka' to see all of the containers in this pod.
OpenJDK 64-Bit Server VM warning: If the number of processors is expected to increase from one, then you should configure the number of parallel GC threads appropriately using -XX:ParallelGCThreads=N
knative-eventing-channel.default.default-channel


Specifying a fields property on the prototype breaks the List editor

When fields is specified on the prototype of a List editor, the addItem editor breaks (the modal only shows the top-level key-name as a text field). This does not happen if fields is passed into the constructor.
GoalsForm = Backbone.Form.extend
  schema:
    goals:
      type: 'List'
      itemType: 'Object'
      subSchema:
        goal:
          type: 'Text'
        description:
          type: 'TextArea'

    ignore_this_field: {}

# This works as expected (shows `ignore_this_field`)
form = new GoalsForm()

# This works as expected (hides `ignore_this_field`)
form = new GoalsForm(fields: ['goals'])

# This only shows the `goals` editor, but addItem does not work as expected
form = new (GoalsForm.extend(fields: ['goals']))

This may be related to #2.

I think the issue is with the modal adapter, if I use InlineNestedModel as the itemType then fields works properly even when set on the prototype.

I think the issue with setting fields on the form prototype with a List editor is that the list creates a new sub-form for the modal and uses the extend-ed constructor to do so. Using @form.constructor, it creates a new Backbone.Form, but in doing so it copies over the fields property on the extend-ed form. This means that the fields property on the root form is "shadowing" the sub-form.
In the example above, the GoalsForm constructor is used to create the modal sub-form (with fields = ['goals']), but the schema of the list item/subform only includes goal, so schema[key] returns undefined, which defaults to the Text field we've been seeing.
To make this a little more clear, if you had:
AlbumForm = Backbone.Form.extend
  fields: ['tracks']
  schema:
    tracks:
      type: 'List'
      itemType: 'Object'
      subSchema:
        title: 'Text'
        track_number: 'Number'

The fields: ['tracks'] would be "inherited" by the modal's form (for the song), which doesn't contain the tracks property (it contains title and track_number properties).
The simplest change would be to directly reference Backbone.Form instead of @form.constructor but I'll have to make sure that doesn't have any unintended consequences:
diff --git a/src/editors/extra/list.coffee b/src/editors/extra/list.coffee
index e571e61..03b1a00 100644
--- a/src/editors/extra/list.coffee
+++ b/src/editors/extra/list.coffee
@@ -362,7 +362,7 @@
       @itemToString value
     openEditor: ->
       self = this
-      ModalForm = @form.constructor
+      ModalForm = Backbone.Form
       form = @modalForm = new ModalForm(
         schema: @nestedSchema
         data: @value)

Running git blame on the ModalForm line shows that this.form.constructor was deliberately changed from just using Backbone.Form. It's not entirely clear to me why; reverting that doesn't break any new tests in the original BFF library. The commit mentions templates, but I don't think you'd want to pass custom form templates to your modal sub-form because you'd end up with a similar issue (fields in the root template not being defined in the sub-form) so I'm not sure why that would be desirable.
e.g. in the example above, if you do:
AlbumForm = Backbone.Form.extend
  template: _.template '''
    <form action="">

this is some text

    </form>
  '''
  schema:
    tracks:
      type: 'List'
      itemType: 'Object'
      subSchema:
        title:
          type: 'Text'
        track_number:
          type: 'Number'

then the modal form will be broken because it only has the placeholder for tracks and it has the "this is some text" header which probably isn't the desired effect.

closed by https://github.com/teleomed-labs/backbone-forms/commit/bc16350be8a40791eb99c1234cfc4cd064fe144f


Can't import AngularFire from angularfire2

Version info

Angular:
Firebase:
AngularFire:
Other (e.g. Ionic/Cordova, Node, browser, operating system):
How to reproduce these conditions
Failing test unit, Plunkr, or JSFiddle demonstrating the problem

Steps to set up and reproduce

Sample data and security rules
<-- include/attach/link to some json sample data (or provide credentials to a sanitized, test Firebase project) -->
Debug output
** Errors in the JavaScript console **
** Output from firebase.database().enableLogging(true); **
** Screenshots **
Expected behavior

Actual behavior

If you're using the latest version of AngularFire2, please import from @angular/fire instead of angularfire2. The NPM package for the original angularfire2 has been deprecated in favour of the new NPM package @angular/fire.

P.S. Please consider filling in the issue template or the members of the AngularFire2 team may immediately close your issue without any consideration.


Move MsgServer to attribute in KeeperTestSuite (remove GetMsgServer)

Background
x/stakeibc/keeper/keeper_test.go defines a KeeperTestSuite with a GetMsgServer function. I can't remember why a Getter was used for this and I don't think it's necessary.
Suggested Design
In x/stakeibc/keeper/keeper_test.go, change this:
type KeeperTestSuite struct {
	apptesting.AppTestHelper
}

func (s *KeeperTestSuite) SetupTest() {
	s.Setup()
}

func (s *KeeperTestSuite) GetMsgServer() types.MsgServer {
	return keeper.NewMsgServerImpl(s.App.StakeibcKeeper)
}

To this:
type KeeperTestSuite struct {
	apptesting.AppTestHelper
        MsgServer types.MsgServer
}

func (s *KeeperTestSuite) SetupTest() {
	s.Setup()
        s.MsgServer = keeper.NewMsgServerImpl(s.App.StakeibcKeeper)
}

And update unit tests appropriately
_, err := s.GetMsgServer().LiquidStake(sdk.WrapSDKContext(s.Ctx), &msg)
// changed to
_, err := s.MsgServer.LiquidStake(sdk.WrapSDKContext(s.Ctx), &msg)

Acceptance Criteria

Unit tests pass

Can I handle this ?

Go for it! Thanks for checking first :)

@sampocs Can you have a look ? Thank you!

After discussion here, decision was made to leave this as is


Release 0.2

This issue is for discussion of the 0.2 release process.

For now, the date of the 0.2 milestone is set to April 30 2015. However I think this is not realistic.
Any suggestions?

Depends on if we want to keep everything currently labelled as 0.2. I think that 4 weeks a good amount of time to accomplish #2, #20, #30, #37, #42, #54, and #47. In addition, the testing issues should be at least partially addressed.
#29, #39, and #17 seem like they're going to require more thought and discussion to do well, so I think we'll need to limit the initial scope of those issues, label those parts of the library as experimental, or push them off.

We got a lot of positive feedback on the project at PVSC. The most common issue was installation, especially for new users on Windows. I want to capitalize on whatever extra interest we get out of PVSC, so, I'd like to resolve the easier issues and then release 0.2 with a conda package on Monday or Tuesday. I am going to devote some time today and over the weekend, and then we'll go with whatever state the project is in. I think I can knock out the list above except for #2.
Any objections @bmu @Calama-Consulting or others?
If nobody speaks up then I will break the rules and accept my own PRs.

I went ahead and made conda packages for 0.1 and updated the readme. Here's the process that I stumbled into https://github.com/pvlib/pvlib-python/wiki/Release-procedures

I can have a look at your PR's and merge them. However, I have to focus on my PhD in my spare time and it seems, that I won't get any working time to contribute to pvlib. So my own contribution will not be to much. Maybe we can shift some 0.2 issues to "someday" and release it as it is. I will start for some of "my" issues.

Great thanks @bmu.

Ok, my suggestion is that we go forward with the 0.2 release. We can make a 0.2.1 with tutorial improvements if @NelisW, @Calama-Consulting, or myself find the time.

@Calama-Consulting can you upload to PyPI if you think we're ready? I updated the whats new date and the version.

Closed by 263c90ef26


Fancyzones on multiple monitors doesn't work properly for certain display arrangement where top edges are not aligned

Environment
Windows build number: 10.0.19041.329
PowerToys version: 0.19.0
PowerToy module for which you are reporting the bug (if applicable): FancyZones

Steps to reproduce

Have two monitors one in Portrait mode and another in Landscape mode (I have identical 27" , 3840x2160 resolution)
Arrange display as shown in Screenshot 1
Use FancyZones to set 3 Rows in the Portrait mode display (and 2 columns in Landscape mode display, although this doesn't matter for this issue). Screenshot 2
Use the shift key+mouse drag gesture to place a window in portrait mode display.

Expected behavior

The fancy zones should be highlighted as configured, 3 equal height rows vertically distributed evenly and allowing window to placed.

Actual behavior

Only Rows 1 & 2 are fully visible with a huge margin from Top of the screen. Row 3 is cut in half. Window cannot be placed as configured. Screenshot 3
1.1 I really need this display arrangement to work. Top aligned edge is not suitable for me.
If the displays are arranged with their top edge aligned then fancy zones work properly. Screenshot 4
2.1 BTW I could only get Fancyzones to set different zones for each display by making one display primary at a time and setting the zone configuration. An user friendly way to do it in the settings per monitor would have been much easier.

Screenshots

Windows 10 Enterprise Ver: 20H2 Build: 19042.330
PowerToys Version 0.19.0
Windows Explorer does not snap to the zone boundries on 4k monitor set to 125% scaling. (see attached image - Windows Explorer does not snap correctly in any of the 3 set zones)

I have a 4 monitor setup.
(2) are 16:9 (horizontal)
(1) is 21:9 (horizontal)
(1) is 9:16 (portrait)
It would be ideal to be able to have a Zone Editor for each display. But it's not even letting me drag the layout into a different monitor. I was hoping this would resolve the current issue with vertical monitors, where it's not easy to snap to the top half and bottom half.

@Garconis

It would be ideal to be able to have a Zone Editor for each display

move the mouse on the monitor where you want to edit the layout and press the editor shortcut key, or move the PT Settings on that monitor and click on "Launch zone editor"

@softveda
I can reproduce the problem when I change the monitor orientation while PowerToys is running. If I quit PowerToys and reapply the template it works as expected (so we need for sure to fix the code that receives the event when the screen area changes).
Can you try to verify if it works like that for you too?
Thanks.

@xbloodworkx
the problem you describe is different from the one reported in this issue, please open a new issue because we cannot track two different problems in one place.
Thanks.


Revert "Avoid overshooting"

Reverts FoundationDB/fdb-joshua#49
Oh no, there was a bug somewhere.
It can go into a situation where idle agents doesn't get out.
I'm debugging.

I found a solution.

Can you pls link the solution? :)

https://github.com/FoundationDB/fdb-joshua/pull/52

@xumengpanda Please revert this. I found another edge case. I'll spend more time to test this...  Sigh, I need Joshua for Joshua.


Add MultiPotato

Hi! A new potato has been hot on Twitter and I decided to add it. Let me know if there are any issues!

Thanks, sorry for the late response!

@d4rckh No problem--thanks for adding it!


Add support for ssh addresses?

For whatever reason, git on my computer is reeeeaaaaallly slow when fetching from a repo using a https address -- 45+ seconds, compared to ~0.75 seconds (!) for the ssh address.
Would it be possible to add the ability to use ssh addresses in cloned repos instead of https? Manually wading through repos isn't very fun...

Are you talking about the ZPLUG_PROTOCOL variable?

Jeeze, I'm blind. That would do the trick. Thanks!

Jeeze, I'm blind. That would do the trick. Thanks!

:)


Serializer or code issue

I get this:
[source/agora/common/Amount.d:62] Assertion thrown during test:
Module tests failed: agora.common.Serializer
core.exception.AssertError@source/agora/common/Amount.d(62)

It seems like there is a mismatch somewhere? VarInt being used even though it shouldn't? Because if I set the value of x to zero then the problem goes away..

The issue was between chair and computer.


Update stable version in repo from 1.2.6 to 2.0.0

Think about update stable version to 2.0.0
Version: stable=1.2.6 (978 days old) => latest=2.0.0 (15 days old)
Installs: stable=5739 (87.48%), latest=452 (6.89%), total=6560
Click to use developer portal
Click to edit
Do not close this issue manually as a new issue will be created if condition for update still exists.
Please drop a comment if any reason exists which blocks updating to version 2.0.0 at this time.
Note: This is an automatically generated message and not personally authored by bluefox!
@mcm1957 for evidence

This issue seems to be outdated.
This issue suggests to update the stable version of this adapter to 2.0.0 but the current stable version is already 2.0.0.
So this issue should be closed.
@mcm1957 for evidence


ERROR: Download Media[Run Script] ERROR: [youtube] Wsb-mlDuFxg: Unable to extract uploader id; please report this issue on  https://github.com/yt-dlp/yt-dlp/issues?q= , filling out the appropriate issue template. Confirm you are on the latest version using  yt-dlp -U

DO NOT REMOVE OR SKIP THE ISSUE TEMPLATE

[X] I understand that I will be blocked if I intentionally remove or skip any mandatory* field

Checklist

[X] I'm reporting a bug unrelated to a specific site
[X] I've verified that I'm running yt-dlp version 2023.03.04 (update instructions) or later (specify commit)
[X] I've checked that all provided URLs are playable in a browser with the same IP and same login details
[X] I've checked that all URLs and arguments with special characters are properly quoted or escaped
[X] I've searched known issues and the bugtracker for similar issues including closed ones. DO NOT post duplicates
[X] I've read the guidelines for opening an issue

Provide a description that is worded well enough to be understood
ERROR: Download Media[Run Script] ERROR: [youtube] Wsb-mlDuFxg: Unable to extract uploader id; please report this issue on  https://github.com/yt-dlp/yt-dlp/issues?q= , filling out the appropriate issue template. Confirm you are on the latest version using  yt-dlp -U
It is the latest version
Provide verbose output that clearly demonstrates the problem

[X] Run your yt-dlp command with -vU flag added (yt-dlp -vU <your command line>)
[ ] If using API, add 'verbose': True to YoutubeDL params instead
[X] Copy the WHOLE output (starting with [debug] Command-line config) and insert it below

Complete Verbose Output
[03:12:14.762] Download Media[Script Filter] Processing complete
[03:12:14.775] Download Media[Script Filter] Passing output 'https://www.youtube.com/watch?v=Wsb-mlDuFxg' to Run Script
[03:12:20.297] ERROR: Download Media[Run Script] ERROR: [youtube] Wsb-mlDuFxg: Unable to extract uploader id; please report this issue on  https://github.com/yt-dlp/yt-dlp/issues?q= , filling out the appropriate issue template. Confirm you are on the latest version using  yt-dlp -U

https://github.com/yt-dlp/yt-dlp/issues/6247
Update yt-dlp


Double to float

This update does a lot.

Adds a new feature that enables building in 32-bit mode. This is much faster and more memory efficient, and although I'm not entirely happy with the implementation, I don't see a way around it right now (the Python package will be 64-bit by default but can be manually built in 32-bit mode). In the future, I might separate these into two different packages, but I want to explore more ideas before I do that, and it's not that critical right now.
The GlueX K-Matrix amplitudes are now modified to get around pesky division-by-zero errors!
The Python API no longer has num_threads keyword arguments, they are now just a boolean flag called parallel which is true by default. To change the number of threads, I encourage using the RAYON_NUM_THREADS environment variable.
In the same vein, I removed the Python-side Manager.par_evaluate and merged it into a combined Manager.evaluate function with a similar signature to that of ExtendedLogLikelihood.evaluate. This also simplifies the respective __call__ method.
Some other quality-of-life fixes (rustitude.minimizer wasn't in the .pyi file, updated some docs and tests)

It is important to note that in this PR, the 32-bit mode is in conflict with Minuit and SciPy's minimization algorithms, which are hardcoded with 64-bit precision. This means that when they take a numerical derivative or choose a value related to machine epsilon, it will involve a small 64-bit number that probably can't be represented in 32-bits. This will cause basically all minimization algorithms to fail. The next release will add another crate I'm working on, ganesh, to handle minimization internally with Rust, but this is a work-in-progress, and I felt the updates here were important enough to publish without this addition.

Welcome to Codecov :tada:
Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.
Thanks for integrating Codecov - We've got you covered :open_umbrella:


Update Coverage Behaviour

Problem
Now for uploading coverage, campaign need to be assign coverage insight function and upload it in campaign detail in insights function coverage tab.
I think it is not quite right.
Solution
Move coverage insight function to be a single function like upload boundary, and editing is done in create/update like boundary.

@meomancer, I wonder whether we shouldn't have more coverage functions before making this call? Or at least let's look at how we are treating remote mapping.

@meomancer, I've come around to your initial suggestion, let's update it.

need to update wokflow for this method
cc @smit1678 @MariaSolovyeva

Let's bring this in line with https://camo.githubusercontent.com/059be333ead222a9cf9c36a41759c9fc703d1d97/687474703a2f2f6d6173686173747564696f2e6e65742f332d576f726b466c6f772d757064617465414f492e706e67

I missed this task detail, because it was assigned to meomancer before. Can you guys give me the detail again? @cchristelis @meomancer

Added in #223


Change wording about GitHub to include GH discussions

Signed-off-by: beorn7<EMAIL_ADDRESS>

:+1:


Add an example with time

It took me a bit to figure out how to query time since there isn't any documentation on it. I thought it would be nice to have an example on the README for anybody looking to query fields like created_at or updated_at, etc.

Thank you

How is lastweek defined in the example?


Add an environment that can convert 2D maze with a floorplan into 3D env

Add an environment that can convert 2D maze with a floorplan into 3D miniworld maze.

Hi @shijiegu
Cool environment. I would like to merge it.
However, you've made modifications to miniworld.py and I'm not sure why . Care to elaborate?

Hey,
Sorry for the late response!
Yeah the changes in miniworld can be avoided if you know the package well.
For me I tried multiple formats in this line to set positions
self.box = self.place_entity(Box(color='red'),pos=self.reward_pos)
or anywhere in the code that has "pos".
It seems like whatever my input (row vector or matrix with 1xN) is, it all change to a numpy array of position"s" in the end and the miniworld.py could not understand multiple positions, which in fact is only one.
You might be able to fix this very quickly but other environments will not conflict with this use.


JSON parsing and WebSocket buffer copy errors with Node 6

I am using the latest git version of Discordie, but in the past week or so my bot is crashing from the following errors:
undefined:1
{"t":"TYPING_START","s":535,"op":0,"d":{"user_id":"142098955818369024","timestamp":1468179526,"channel_id":"142072749911834625"}

SyntaxError: Unexpected end of JSON input
    at Object.parse (native)
    at BaseSocket.ws.on.e (/home/mbilker/music-discord/node_modules/discordie/lib/networking/ws/GatewaySocket.js:128:24)
    at emitTwo (events.js:106:13)
    at BaseSocket.emit (events.js:191:7)
    at Receiver.ontext (/home/mbilker/music-discord/node_modules/ws/lib/WebSocket.js:816:10)
    at /home/mbilker/music-discord/node_modules/ws/lib/Receiver.js:477:18
    at Receiver.applyExtensions (/home/mbilker/music-discord/node_modules/ws/lib/Receiver.js:364:5)
    at /home/mbilker/music-discord/node_modules/ws/lib/Receiver.js:466:14
    at Receiver.flush (/home/mbilker/music-discord/node_modules/ws/lib/Receiver.js:340:3)
    at Receiver.opcodes.1.finish (/home/mbilker/music-discord/node_modules/ws/lib/Receiver.js:482:12)

and
/home/mbilker/music-discord/node_modules/ws/lib/Receiver.js:386
    default: srcBuffer.copy(dstBuffer, dstOffset, 0, length); break;
                       ^

RangeError: out of range index
    at RangeError (native)
    at fastCopy (/home/mbilker/music-discord/node_modules/ws/lib/Receiver.js:386:24)
    at Receiver.add (/home/mbilker/music-discord/node_modules/ws/lib/Receiver.js:86:3)
    at TLSSocket.realHandler (/home/mbilker/music-discord/node_modules/ws/lib/WebSocket.js:800:20)
    at emitOne (events.js:96:13)
    at TLSSocket.emit (events.js:188:7)
    at readableAddChunk (_stream_readable.js:177:18)
    at TLSSocket.Readable.push (_stream_readable.js:135:10)
    at TLSWrap.onread (net.js:542:20)

The second error is more of an error with the WebSocket connection.
I have not investigated the cause of these yet or turned on debugging. I just wanted to report this.

I got this error as well.  Someone told me they got rid of this error by downgrading their version of nodejs.  I talked with people on #nodejs, from freenode.  They said that just because a downgrade fixes the problem, doesn't mean it is nodejs is bugged.
/var/lib/openshift/5787d8962d527145a0000115/app-root/runtime/repo/node_modules/discordie/node_modules/ws/lib/Receiver.js:386
default: srcBuffer.copy(dstBuffer, dstOffset, 0, length); break;
^
RangeError: out of range index
at RangeError (native)
at fastCopy (/var/lib/openshift/5787d8962d527145a0000115/app-root/runtime/repo/node_modules/discordie/node_modules/ws/lib/Receiver.js:386:24)
at Receiver.add (/var/lib/openshift/5787d8962d527145a0000115/app-root/runtime/repo/node_modules/discordie/node_modules/ws/lib/Receiver.js:86:3)
at TLSSocket.realHandler (/var/lib/openshift/5787d8962d527145a0000115/app-root/runtime/repo/node_modules/discordie/node_modules/ws/lib/WebSocket.js:800:20)
at emitOne (events.js:96:13)
at TLSSocket.emit (events.js:188:7)
at readableAddChunk (_stream_readable.js:177:18)
at TLSSocket.Readable.push (_stream_readable.js:135:10)
at TLSWrap.onread (net.js:542:20)

From what I could tell, Node 6 seems to crash discordie.
I personally use Node 5.3.0, no issues here

I am running Arch Linux.
I downloaded Node 4.4.7 LTS from the website and reinstalled all modules and this issue went away. It seems this an issue with Node 6.

The lastest update of Discordie fixed this for me.

@songying This is an error in the ws library with socket.io, unrelated to Discordie. Are you using the latest version of Discordie and socket.io?

@songying This is an error in the ws library with socket.io, unrelated to Discordie. Are you using the latest version of Discordie and socket.io?

@mbilker Yes , it's unrelated to Discordie. I just search my error and found this issue was disussing this.


Enhances command flow export, Closes #3407

This PR enhances the command flow export.
Closes #3407

Nice work @nicodecleyre. The timed-out jobs are up and running again.

ready to merge 🚀

merged manually. You rock 🤩


ChanceOfWinning

Hey,
I dont seem to be able to use the ChanceOfWinning function can you help me out?

Nevermind :D
Maybe the args names are not that clear. I thought you should pass actual player objects like alice but the function takes the players skill alice.skill


Button inside header layout

Hi, how can i detect onclick event for button inside the header layout file when using setParallaxHeader(). For simple example, in my header_layout i have
<FrameLayout
          xmlns:android="http://schemas.android.com/apk/res/android"
          android:orientation="vertical"
          android:layout_width="match_parent"
          android:layout_height="wrap_content">

<ImageView
    android:layout_width="match_parent"
    android:layout_height="match_parent"
    android:id="@+id/imageView"
    android:src="@drawable/wallpaper"
    android:adjustViewBounds="true" />

<Button
   android:layout_width="match_parent"
    android:layout_height="match_parent"
    android:id="@+id/my_button" />
 </FrameLayout>

Then, i want to access the button and set onclick event. How can i achieve that. Thank you very much for great lib.

Solved already. Sorry for the rush posting this. Just set the button and onClick as usual.

In fact it's a strange use case. Are you reloading the adapter when you swipe back to your list?

The viewpager automatically reloads the fragment containing the parallaxheader. If the parallaxheader is visible before i swipe, it will still reload but the header is loaded back again. Unless i scroll down till the header is gone, then it will be blank if i swipe to the other fragment. I'm guessing its the issue of scrolling position, the state is not saved. If u need to see any code i can post here, but a bit late because i'm not at my desk. Thank you so much for your response!

@kanytu I found a workaround for now. I changed the viewpager offscreenpagelimit, so it wont destroy the fragment containing the parallaxheader when the viewpager is swiped. Thank you.


fix range check for RCT

The valid range for the rct type is [0,41].
The spec also needs to be updated to require that range.

Can we use named constants, maybe in the API headers?

We don't really seem to do that in the API for the ranges of options. Not saying it's a bad idea, but then maybe we should do it for all options (or at least the ones with a more interesting range than [-1,1]), also e.g. for effort etc.
To be honest this particular option is probably not useful at all, since manually setting a specific global RCT is very likely to produce worse results than doing the default thing (which is trying different RCTs per group). The same is true for the option to manually set a specific global predictor. Perhaps we should deprecate / get rid of such not-very-useful options now we still can, to reduce clutter in the API?

Can we use named constants, maybe in the API headers?

We don't really seem to do that in the API for the ranges of options. Not saying it's a bad idea, but then maybe we should do it for all options (or at least the ones with a more interesting range than [-1,1]), also e.g. for effort etc.
To be honest this particular option is probably not useful at all, since manually setting a specific global RCT is very likely to produce worse results than doing the default thing (which is trying different RCTs per group). The same is true for the option to manually set a specific global predictor. Perhaps we should deprecate / get rid of such not-very-useful options now we still can, to reduce clutter in the API?

Sounds good to me.


chore: use buf.String() instead of string(buf.Bytes())

Team RabbitMQ no longer pays any attention to this fork. Consider switching to, and submitting your PRs again, https://github.com/rabbitmq/amqp091-go/.


Any chance of a swiftUI version of this? I've found information of EventKit & EventKitui rarer than unicorn S*!t

Maybe? But so far I don't have much SwiftUI experience.. Is there something specific you need to achieve with EventKit?

Thank you for replying. Because I've only been learning to code for a few months I've done so exclusively in SwiftUI and am totally lost looking at UIKit stuff. While learning I'm applying what I can to an app project idea that can help with my day job. A part of that will be to register bookings to iOS calendar with event kit.
So to start with at least I'm hoping to replicate the same functionality as your demo here ( but in SwiftUI ) If I managed that much I think I could probably adapt it to do more app specific stuff afterwards. So yeah... a SwiftUI version of this would be exactly what I need to get up and running with Eventkit.
I guess I won't know what gaps in knowledge I might still be missing until I hit the next roadblock :)

Got it! I see what I can do :-)

I have started working on SwiftUI version so I am closing this issue.. :)


build: remove SBT Assembly plugin

:tada: This PR is included in version 2.0.0 :tada:
The release is available on:

2.0.0
GitHub release

Your semantic-release bot :package::rocket:


chore(docs): Readme corrections

:tada: This PR is included in version 1.0.0 :tada:
The release is available on:

npm package (@next-major dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


RFC: React Aria Components

This RFC proposes adding a new component-based API for React Aria built on top of the existing hooks. It will provide an easier way to build accessible components with custom styles for many use cases, while still offering the flexibility to drop down to the lower level hook-based API for even more customizability where needed.
View rendered RFC
In addition, check out the current work in progress documentation to see examples of what many of the components would look like. The current implementation is also on a branch.

This is so awesome! Thanks so much for the work. Here's my feedback (as someone who originally wanted this)

"one-to-one with dom elements": Love this! That's the ideal mental model.
ARIA state styling: Great! Just needs to be clear in the documentation what states are available to be styled.
Allowing className or children to be a function: I'm not the biggest fan since this sort of stuff sometimes leads to inscrutable type errors, but I don't have a better solution, and if its familiar to people coming from other libraries, seems fine.
Item fake DOM stuff: this solution is bonkers and I haven't seen it anywhere else. Personally, I have no idea what the ramifications of that approach will be or how it will hold up. I don't really understand why items can't be used like regular react components...why not just walk the tree recursively until you get to an Item, and then stop descending after that? Typical usage won't have that many layers between the native Item component and the wrapper.
Advanced customization: Had a tough time understanding this bit. Not really sure what's going on here...
Documentation updates: Also great. Would add that a search bar in the sidebar would be really helpful, since there are going to be a lot of pages, and also each component page should be clear about the slots it supports.

@tanishqkancharla thanks for the feedback!

Item fake DOM stuff: this solution is bonkers and I haven't seen it anywhere else.

haha, yeah, it is different for sure. Let me expand on the various options for this that I've seen. The general problem is that we need to have a full list of all the items in the collection to implement things like keyboard navigation, selection, and to generate some ARIA properties like aria-posinset (the index of the item within the collection) and aria-setsize (total number of items). This is a surprisingly hard problem in React.
Our previous implementation walked to JSX tree, looking for <Item> elements. However, if you introduce another component in the middle, like <MyItem>, we wouldn't be able to do this unless we recursively called that component and looked for Items that are returned from that. That would essentially be duplicating what React does, and it would be limited because things like context and hooks wouldn't work as expected.
Another way to do this that many libraries use is to render all items to the DOM, and then query the DOM to find all the items. To set the index of each item within the collection, each item would need to do this and find itself via indexOf or something. This can be quite expensive. In addition, if you don't render all items at once, e.g. when using virtualized scrolling, this solution can't work.
There are some other options as well, like wrapping each item in a context to set the index (so it doesn't need to be manually propagated by the user), but that wouldn't work if a component rendered multiple items:
<ListBox>
  <SomeItems />
</ListBox>

function SomeItems() {
  return <>
    <Item>One</Item>
    <Item>Two</Item>
  </>
}

if we wrapped SomeItems in a context with a single index, both nested items would get the same index. Ryan Florence wrote a good article covering some of these in more detail.
The fake DOM solution is nice because it avoids needing to render the entire collection into the real DOM, meaning it can work with virtualized scrolling, and we can efficiently traverse the whole collection and convert it to whatever representation we need. It also works with context and hooks just like any other React component, and allows wrappers to contain multiple items as you'd expect. We'd only need to render down to the <Item> level, not its children, which also improves performance. Ideally React itself would offer something like this, but the previous attempt (call-return) was abandoned.

Advanced customization: Had a tough time understanding this bit.

I could add some additional details here, but basically the idea is to let you use a component like <ComboBox>, but replace the nested <ListBox> component or any other nested component with your own version. This is useful if you want to customize the DOM structure, override event handlers, access more internal state, or any other more advanced customization that the component API doesn't allow. It is just opening the API up so anyone can create components that integrate with other React Aria Components the same way as the default ones are implemented (by accessing contexts).

This is really great work, such a perfect middle ground between Aria/Stately and Spectrum.
Responding to the first open question, I feel pretty strongly that it should stay separate from the react-aria monopackage, to avoid confusion.
This will clarify how these projects actually accomplish different goals, and that they can be used individually/separately. React Stately provides state, React Aria provides UI logic, including ARIA props management, React <?> provides DOM structure, and React Spectrum is a full-blown component library.
This will also help clarify that the new components are a possible DOM structure, not the the only possible DOM structure.
"React Structure" could be a great name. NPM package is taken but appears unmaintained.
Some background on my opinion: my team is building a design system and component API on top of the hooks API. Our DOM structure and desired props API is highly customized, so we would not be able use most of these components, but the hooks API supports our use case effortlessly. The UI fidelity and DX of the hooks API is unmatched, inside and outside the React ecosystem.
Let me be melodramatic for a sec—React Aria is a landmark in frontend tech. Its abstractions are vastly better than the web platform's inflexible UI logic, tightly coupled to hard-to-style HTML tags. Separating UI logic from DOM structure is the mental model that will push the platform and the industry forward, and in that context, I'd love to see React Aria kept separate from the DOM structure package.

I think the biggest question I have is, how are we going to handle unwanted context propagation?
Do we expect Providers with value={{}} to clear them? Should they be more targeted? merging from parents?
One place I see this being problematic is Buttons inside a Dialog inside a DialogTrigger where the DialogTrigger context that gets applied to the trigger button might also propagate to any buttons inside the Dialog

I don't know that I have a ton to contribute here, but I just wanted to say that I think this is a fantastic idea. I've often wanted to reach for React Aria, but Radix was easier to pick up and run with. That said, React Aria offers much more than Radix, and making it easier to start with React Aria would be great.
Outside of React Aria/Radix, I've turned to Chakra UI due to the ease of use and accessibility being baked in, but with Remix's limited support of CSS-in-JS and NextJS's server components, I think having a solution that offers a CSS first approach is great. (FWIW, I don't know if there are/will be similar limitations with server components with this lib).
Looking forward to this developing further and excited to start using it. Shade/UI for React Aria would be a dream 😍

hi, i'm curious about support for (exit-)animations. i see some data-entering/data-exiting attributes in the example css in the docs - but maybe a dedicated docs page on animations similar to the radix page could make sense?

This sounds excellent! I already use many hooks by copy/pasting example code, fixing typings and consuming with props anyway. I like that hooks are still there when I need customization, but components are high level constructs.
I also find myself conflicted between wanting more and less customizability. Sometimes I want high level constructs and sometimes I wish I could pass a reducer to customize open/close behavior of a combobox. This is not related to the discussion of course, just wanted to get it off my chest. Components will help me a lot!

Is there any way to install it to test?

Is there any way to install it to test?

@hosmelq Just copy the react-aria-components package from the https://github.com/adobe/react-spectrum/tree/aria-component-docs/packages/react-aria-components branch to your project and use it in your package.json:
  "dependencies": {
    "react-aria-components": "file:./packages/react-aria-components",

Really stoked about this!
One question though: it seems that date pickers does not render input tags under the hood, using them inside an html form (like in remix) would not work. What would be the solution to this?
thanks!

@afoures
You'd probably want to stick the value you get from the date picker into a hidden field, like so:
<input value={datePickerValue} name="date" type="hidden" />
You can see an example of this here https://youtu.be/w2i-9cYxSdc?t=210

Awesome work! These headless components is exactly what I miss so much every time when start implementing custom components / comp. extensions. Every time was like spending 2 hours trying to juggle between react-aria, react-stately, and reference implementation from react-spectrum.
Also, you could directly link these aria-components in example sections of various docs, and have a battle-tested working example out of the box.

This is very welcome. I created many of my own components with react-aria / react-stately by copying react-spectrum components and then stripping the spectrum specific parts (like the css classes and stylesheet imports). This worked, but comes at the cost as I now have to maintain the integrations between react-aria / react-stately. So far that has not really been a problem but I can imagine that I will miss out on some bug fixes or small improvements.
I can imagine having something in between spectrum and react-aria / react-stately could fix that. It would be great if the react-spectrum components could be migrated to these react aria components as this would verify it can handle those use-cases. I really like the slots and  in the RFC. If I understand it correctly, this allows maximum composability & flexibility without having to overwrite everything want you want to change just a small thing of the default behavior.

Thanks for all the feedback everyone! Great to hear that this sounds interesting. I'll try to respond to some of the items here.
@AlexVipond

Responding to the first open question, I feel pretty strongly that it should stay separate from the react-aria monopackage, to avoid confusion.

I agree. I think a separate package will keep it clear that it is built on top of React Aria, and it is but one of many possible APIs one could build. I think this will be useful not only as a library of components you can use out of the box, but also as an example when you want to build something more custom, or with a different API.

@snowystinger

I think the biggest question I have is, how are we going to handle unwanted context propagation?

Yeah, we will need to clear contexts out in containers that accept arbitrary children, like Dialog, the same way we do in Spectrum.

@stefanprobst

i'm curious about support for (exit-)animations. i see some data-entering/data-exiting attributes in the example css in the docs - but maybe a dedicated docs page on animations similar to the radix page could make sense?

Yeah, at the moment this is covered on each individual component page that supports animations, as part of the styling section. For example, the Popover docs and the Tooltip docs. We can probably expand this with more examples. I think having an additional page to describe various animation approaches might also be helpful as a general overview.

@afoures

it seems that date pickers does not render input tags under the hood

Adding an <input type="hidden"> as suggested by @IHIutch is the right way to do this. We considered making this built in but the problem is that there are many different date formats that a server could expect (string with/without time, with/without time zone, unix timestamp, etc.) so we have left this to apps so far. Not opposed to adding something here though, just need to come up with the right API that isn't too specific.

@jrmyio

Being able to control the rendered internal component is pretty important in order to use libraries like  framer-motion or even styled components (for example support for an as prop or even an asChild like radix does).

I think the DOM structure may be a little more opinionated than some other libraries because we do have the hooks to fall back to if you need something really custom. However, I agree for common cases this is important. For framer-motion and styled components I think you'd probably wrap the React Aria Components rather than the DOM elements instead. For example:
const StyledButton = styled(Button)`...`;
const AnimatedButton = motion(Button);

This should all work because we pass through DOM props like className, style, etc. through to the underlying DOM node, and also expose a DOM ref.
Customizing more advanced things will hopefully be more rare and can be left to the hooks. We can also expand the component API to cover more common use cases over time.

Good documentation on the CSS selectors that you can use to style various states.

Yes, each component page will have a table detailing all of the states and CSS selectors you need. Here's an example.

A way to customize certain parts without having to re-do everything. The RFC mentions slots and props which sounds pretty flexible.

Yeah, you'll be able to swap out any component with a custom implementation and have it integrate in a larger pattern. For example, you could swap out the ComboBox with a custom implementation with different behaviors but still reuse the ListBox it contains, or visa versa.

Confirmation that these components are actually flexible enough and the hooks are not required for common use-cases. It would be great if the react-spectrum components could be migrated to these react aria components as this would verify it can handle those use-cases.

I think we will see how it goes over time and expand the API as needed. We should be able to migrate parts of React Spectrum over already. Other parts are going to naturally be a bit too complicated, and will need to continue using the hooks for more customization options. I think that's ok - this library isn't intended to cover every single use case. It's designed to be an easier starting point that allows you to progressively drop down to lower level APIs only where needed. That's the flexibility offered by having both hooks and components rather than only one or the other.

This is awesome. I can already think of multiple places that I would get a lot of value out of react-aria-components.
I love the proposal for using a fake DOM to get the rendered children, allowing for custom wrappers. I need to do something similar in another library. One question I do have on this is have you figured out how to keep this type-safe with TS? For example, will I still get code-time errors from tsc if one of my wrappers could return an invalid child?
Great work as always @devongovett and team.

@marshallpete thanks for the feedback!

One question I do have on this is have you figured out how to keep this type-safe with TS? For example, will I still get code-time errors from tsc if one of my wrappers could return an invalid child?

Yeah this is a challenge in general with TypeScript and React. TS does not really have a way to type check JSX element types. JSX.Element in the React types is an alias for React.ReactElement<any, any>, which basically means that type information about the element type is erased. There's an open TS issue for this: https://github.com/microsoft/TypeScript/issues/21699. So for now, we will do runtime validation. In some cases we would want to allow additional elements like presentational divs to be added in between the semantic ones as well, which would also break this type checking.

Thanks again everyone for the feedback! We're going to merge this RFC and move forward with the implementation. You're welcome to continue leaving general comments here, or more specific ones over on the implementation/docs PR here: https://github.com/adobe/react-spectrum/pull/4171

We just shipped the first alpha! Check out the docs here: https://react-spectrum.adobe.com/react-aria/react-aria-components.html We'd love to hear your feedback!

@jrmyio

Being able to control the rendered internal component is pretty important in order to use libraries like  framer-motion or even styled components (for example support for an as prop or even an asChild like radix does).

I think the DOM structure may be a little more opinionated than some other libraries because we do have the hooks to fall back to if you need something really custom. However, I agree for common cases this is important. For framer-motion and styled components I think you'd probably wrap the React Aria Components rather than the DOM elements instead. For example:

Thanks @devongovett
I am loving react-aria-components so far. However, when trying to use framer-motion I think I am running into a limitation of not being able to set the underlying component that is being rendered.
I can do const AnimatedButton = motion(Button); as you proposed, however, what if I want the animation to depend on the hover / press states and animate the actual  element this way. I have no access to those properties wheras support for as / componentType / elementType / component or whatever prop would be called, will allow me wrap a native button element and check the data/aria attributes in that wrapper to set the animation.
I am aware I can go back to using the react-aria hooks, but having built a design system on top of hooks, and the components, I can say the RAC is much much nicer to work with. Aside from this issue , and some internals of the table I haven't come accross limitations of the RCA so far. I really don't want to go give up RAC.

@jrmyio moved this to a separate discussion: https://github.com/adobe/react-spectrum/discussions/4813


How to set cookies

Hi :),
I need to pass jsessionid cookie in the headers of the request.
I tried that:
hlsjsConfig: {     xhrSetup: (xhr) => {          xhr.withCredentials = true;          xhr.setRequestHeader('Cookie', "JSESSIONID=" + jsessionid);     } }
But it doesn't work :

Refused to set unsafe header "Cookie"

How can I perform this operation properly ?

Hi @Kornflexx I think you can try to set the cookie (a special header) 👍
document.cookie = "JSESSIONID=" + jsessionid;

source: mozilla cookie

It doesn't seems to work :(.
I use clappr in a desktop web app (with electron: chrome engine embed)

@Kornflexx maybe you need to figure out a way to set cookie within this electron engine. (how to send cookies, persist..)

@Kornflexx  this might help you https://github.com/electron/electron/blob/master/docs/api/session.md

Ok I used that: https://www.npmjs.com/package/electron-cookies
When I print document.cookie jsessionid is in it. But I still have the same issue (401 unauthorized from distant api).

you can't send cookie header with xhr also electron run on file:/// or localhost and you can only set cookie on the same domain,


Inaccessible host: amplify.us-east-1.amazonaws.com at port 443

How did you install the Amplify CLI?
npm
If applicable, what version of Node.js are you using?
v18.12.1
Amplify CLI Version
10.5.2
What operating system are you using?
Windows
Did you make any manual changes to the cloud resources managed by Amplify? Please describe the changes made.
No manual changes made
Describe the bug
"amplify publish" reports the following error:
Zipping artifacts completed.
× Deployment failed! Please report an issue on the Amplify Console GitHub issue tracker at https://github.com/aws-amplify/amplify-console/issues.
🛑 Inaccessible host: amplify.us-east-1.amazonaws.com' at port 443'. This service may not be available in the `us-east-1' region.
The failure has persisted except for one success yesterday morning.
I have reports saved automatically. I am not sure if it contains sensitive information regarding my project. Please let me know if you need that.
Thanks,
MC
Expected behavior
I wish amplify publish can be successful
Reproduction steps

amplify publish

Project Identifier
c6c0d0e9f3270b1a1a4c378371fcba86
Log output

# Put your logs below this line
√ Successfully pulled backend environment dev from the cloud.

     Do you still want to publish the frontend? Yes
Publish started for amplifyhosting

><EMAIL_ADDRESS>build
> react-scripts build

Creating an optimized production build...
Browserslist: caniuse-lite is outdated. Please run:
  npx update-browserslist-db@latest
  Why you should do it regularly: https://github.com/browserslist/update-db#readme
Browserslist: caniuse-lite is outdated. Please run:
  npx update-browserslist-db@latest
  Why you should do it regularly: https://github.com/browserslist/update-db#readme
Compiled successfully.

File sizes after gzip:

  482.63 kB  build\static\js\main.***.js
  131.4 kB   build\static\css\main.***.css

The project was built assuming it is hosted at /.
You can control this with the homepage field in your package.json.

The build folder is ready to be deployed.
You may serve it with a static server:

  npm install -g serve
  serve -s build

Find out more about deployment here:

  https://cra.link/deployment

√ Zipping artifacts completed.
× Deployment failed! Please report an issue on the Amplify Console GitHub issue tracker at https://github.com/aws-amplify/amplify-console/issues.
🛑 Inaccessible host: `amplify.us-east-1.amazonaws.com' at port `443'. This service may not be available in the `us-east-1' region.

Resolution: Please report this issue at https://github.com/aws-amplify/amplify-cli/issues and include the project identifier from: 'amplify diagnose --send-report'
Learn more at: https://docs.amplify.aws/cli/project/troubleshooting/

Session Identifier: *can provide if needed*

✅ Report saved: ***/report-1704722097128.zip

√ Done

Project Identifier: c6c0d0e9f3270b1a1a4c378371fcba86

Additional information
No response
Before submitting, please confirm:

[X] I have done my best to include a minimal, self-contained set of instructions for consistently reproducing the issue.
[X] I have removed any sensitive information from my code snippets and submission.

Hey @779503982, thank you for reaching out. These types of issues indicate a problem at the network level. Are you currently operating behind a corporate proxy, on vpn, or have an anti-virus/anti-malware program that may be running?
similar issues: https://github.com/aws-amplify/amplify-cli/issues/12155#issuecomment-1453483173, https://github.com/aws-amplify/amplify-cli/issues/11190

Hi @ykethan, thanks for your response! I don't have VPN installed on my laptop. Below is a screenshot of my "Virus & threat protection" in windows settings. It's an ASUS rog zephyrus laptop. I don't know which anti-virus/malware software is running. I will try to stop the software and try again.

Ugh, just turned off the windows security protection like below, however it doesn't resolve the error.

Thanks,
MC

I just tried to publish again with the wifi connected to my phone's hotspot, but it still doesn't work.

Thank you very much. I don't have another PC at hand right now.
This only occurs when running amplify publish, amplify push has been working just fine.
In the new empty directory, amplify init throws the same error: Inaccessible host: amplify.us-east-1.amazonaws.com at port 443. This service may not be available in the `us-east-1' region.

Guess what, the first thing they say we should do if anything goes wrong -- to restart the computer, worked! I restarted it with  update, and ran amplify publish three times in a row, with and without virus protection. All of them worked. What do you think could've gone wrong, though I will definitely restart my computer next time the same error shows up?

@779503982 interesting, if the restart worked. It may be an app was previously the deployment or the anti-virus/malware software might have needed a restart for the changes to take effect.

Thank you very much!!


Failed to list PR of chaos-mesh/chaos-mesh at the "PR Status" on prow.tidb.io

Bug Report

[x] I have searched the issues of this repository and believe that this is not a duplicate.

Related link

Which project:
https://github.com/chaos-mesh/chaos-mesh

PR or Issue Link:
https://github.com/chaos-mesh/chaos-mesh/pull/1621

Acatually, I could NOT list all the PR of chaos-mesh
Steps to reproduce(Optional)
open that URL: https://prow.tidb.io/pr?query=is%3Apr author%3ASTRRL
What is expected?
It could list the PR of chaos-mesh, for example https://github.com/chaos-mesh/chaos-mesh/pull/1621
What is actually happening?
It could list several PR, but none of them is under chaos-mesh.

Seems to work. https://prow.tidb.io/pr?query=is%3Apr author%3ASTRRL


Clearer colors

commit messages should be pretty obvious

Coverage remained the same at 89.337% when pulling 2adbfa16969af8b64cd3f49341133caa5c9f29b5 on clearer_colors into 2118aff8f408e81b895604e890b2f1e402975191 on master.

Hey @haakoneriksen thanks for the pull request. Sorry for the colors being bad. This pull request gets a 👍 from me.
We are planning to rewrite the admin ui and I will keep the colors in mind.

Yeah, @Andersos I like those toggles. I considered making some checkmark or X-es in CSS to make the shape clearer but if you're rewriting it I'm glad I didn't spend the time.
If you're taking feature requests for the admin GUI, I'd like to submit the idea that it would be helpful to see the same feature in all environments. For example, I'd like to see that some feature is on in the "dev" environment, but off in "CI" and "prod" without having to visit three different web pages.

I know @ivarconr has been talking about promoting toggles between environments so if we are going down that path (having Unleash know about different environments) then we might as well consider this use case. The promoting features is still on the idea board so not something I'm promising =)

we are working on a new UI but merging this for now as these colors are nice =)


Add documentation page for Home Page content requests

I feel like it would be good for us to add some documentation on how and what we need to add new cards and banners to the Home Page.  I keep getting this question...
Maybe put it under "Miscellaneous" under a "Home Page Content" page?

Here's a start -
If you have a tutorial, project, lesson or full course that you would like to share with others, we're happy to list it as a resource on the Home Page.  Please read the information below to learn more about the request process.
Criteria

Your content should be open source and free to use
The instructions should be well written and easy to follow
It should not include any personally identifiable information
Content will be reviewed and approved by the MakeCode Team

What you need to submit

For a tutorial, a link to a complete tutorial (see https://makecode.com/writing-docs/tutorials for more details)
For a lesson or course, a link to a public website with the materials
An image of <insert dimensions and/or resolution here>
A name and short description - see below as an example

Process

File a GitHub issue requesting your content to be listed
Include all the relevant information listed above
For micro:bit, please follow the instructions for submitting a tutorial to the Micro:bit Foundation for approval here

For requesting a featured space in the Home Page banner carousel, we require a link, a short description and an image of <insert dimensions and/or resolution here>.  Please note that banner space is very limited, and therefore highly selective.

@abchatra to review too, and I'm not actually sure what image format/dimensions we need

@ganicke would know more on image format/dimensions. I will review the content.


Indicate inputs of operations as files

We need to indicate whether an input of an operation is a file and which format is expected so that we can provide the right editors in the GUI. We need

file_open_mode one of "r", "w", "rw"
file_filters array of Dict(name: str, extensions: List[str])

@forman
What will be the interface on ops side? Something like this?:
@op
@op_input(file, cate_type='file', file_mode='r', file_filters={'Text': ['md', 'txt']})
def file_op(ds: xr.Dataset, file: str):
    pass

By the way, I'd like to do something like cate_type, as that will probably be workable for the solution of #130 #46

This could be a specific 'cate type' Something that necessarily contains a tuple of strings and a dict.

Already implemented in 0.7


[HOLD] Add systemd e2e

What does this PR do?
Add systemd e2e
Additional Notes

The integration itself is in the agent. But it not that unusual to have the code and e2e tests at two locations. Of course, this tests might break if the implement of systemd changes in the agent, but what's tested via e2e should be relatively stable.

platform = linux|darwin|win32 because the e2e test can run on any platform with docker.

Review checklist (to be filled by reviewers)

[x] PR title must be written as a CHANGELOG entry (see why)
[x] Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
[x] PR must have changelog/ and integration/ labels attached
[x] Feature or bugfix must have tests
[x] Git history must be clean
[x] If PR adds a configuration option, it must be added to the configuration file.

This test can be moved to the datadog-core as a integration test.
Example of integration test: https://github.com/DataDog/datadog-agent/tree/68b5802aa067fd0fcd216d9bfd6dc54f9e42bf43/test/integration/corechecks/docker


Changes in ç letter on the US-Intl keyboard

Something is strange, before version 1.24.0 the letter cedilla was being generated when pressed the symbol ' followed by the letter c.
Now if i do this, the VS Code shows "ć". In this version, i need to press Alt + '.
All my workspace (Gnome) works correctly, only in VS Code i have this issue.
It seems that in the past, Fedora had some problem like this:: https://ask.fedoraproject.org/en/question/28468/problems-with-letter-c-in-us-international-keyboard-fedora-19/

VSCode Version: 1.24.0 - 6a6e02cef0f2122ee1469765b704faf5d0e0d859
OS Version: Ubuntu 18.04 - x64
Keyboard: US-Intl with dead keys.

Steps to Reproduce:

Press the key ' followed by the letter c.
If the letter ç is shown then it is correct, otherwise it is wrong.

Does this issue occur when all extensions are disabled?: Yes

Did you try Alt + + + C?

@gusbemacbe  Alt+C does nothing, but Alt-right+C give ©.

You forgot of +.
I mean Alt + Plus + C:

@alexandrudima maybe it is not VSCode's problem, but Ubuntu US International keyboard's problem. A Romanian guy suggested to press AltGr + Plus + C to insert cedilla. Click to go #163 on the official issue of Ubuntu at Launchpad:
https://bugs.launchpad.net/ubuntu/+source/ibus/+bug/518056/comments/163

@gusbemacbe the AltGR+++C also does not work. About the #163 I do not think that's the problem either.
All my workspace is working properly, only happens in VS Code. And only after this last update. I tried doing a downgrade, but it also did not work.
What defines the keyboard layout for the VS Code?

Strange, Luciano, it always works for me on VSCode. I am a multilingual Brazilian and own a Russo-British Apple keyboard and I use the layout English UK Machinotsh International (without dead keys) and always use AltGr + + + C to insert cedilla on VSCode.
Try the layout US International without dead keys and test the same buttons I suggested.

@la-costa It is possible that you have a keybinding bound to ctrl+alt+= that steals the keybinding from typing. You can press ctrl+k ctrl+s and searching for ctrl+alt+ and take a screenshot of that list / unbind ctrl+alt+ keybindings.

Wait, are you speaking of Ctrl or C?

@gusbemacbe i am speaking of C. I am Brazilian, so cedilla (ç) is an important letter for me. Are you using Windows or Linux? Because i think the problem could be only in Linux.
I tried the layout US International without dead keys and also did not work.
An important point is that all my applications work as expected, it's just the VS Code that does not. So I think it's interpreting the wrong layout of the environment. Is there any variable or parameter in the VS Code to set manually?
@alexandrudima I think this is not the cause, but I'm sending what you asked for.

@gusbemacbe i am speaking of C. I am Brazilian, so cedilla (ç) is an important letter for me. Are you using Windows or Linux? Because i think the problem could be only in Linux.

No, I also use the same version of Ubuntu that you are using. I assure you that AltGr + + + C works for me on VSCode Insiders on Ubuntu 18.04 64bits, using UK International (without dead keys) keyboard. Remember that on Linux, UK International, Apple UK International, Apple US International and US International keyboards are same in case of cedilla.
According to the the UK and US International keyboards layouts on Linux:
AltGr + ' or ' + C are designed exclusively for Slavic languages, like Croatian, Czech, Polish and Serbian. Observe that AltGr + ' or ' + any letter also apply for the vocals and some consoants in some Slavic languages, like É, Í, Ó, Ú, Ń, Ź, etc.
AltGr + + are designed for French (C), Portuguese (C), Romanian (S and T) and Turkish (S).

@gusbemacbe ok, I get it, but it does not work.
This is my keyboard layout on the Ubuntu:

Observe the screenshot take from the article of US International on Wikipedia:

The ' + c to insert cedilla works only on Windows. Not applicable on Linux (X11), so you have to AltGr + +  + C.
Source: https://en.wikipedia.org/wiki/QWERTY#US-International

Ah, I am going to test your layout on my Ubuntu.

@gusbemacbe This post has some information about the issue.
https://askubuntu.com/questions/363115/how-to-type-latin-small-letter-c-with-cedilla
After Ubuntu 16.04 the cedilla letter works fine, without need any configuration. The configuration looks ready for GTK and QT.
AltRight+, = "ç" also works.
It looks like the VS Code is no longer using the "IM_MODULE" setting.

Strange, on VSCode, I have just tested the US International with dead keys, pressing Alt + Comma and was able of inserting cedilla. Maybe were you confounding Alt + Quotation with Alt + Comma?

@gusbemacbe No, i am not confounding, but it's so much detail that even I was in doubt :smile:
I my Ubuntu, both works Quotation and Comma. In VS Code, only Comma.
For me it seems something related to the configuration that VS Code uses.

Very good that you have solved. Maybe the Microsoft developers will reconsider IM_MODULE for making Quotation working on VSCode if a French or Brazilian wants to use an US International with dead keys keyboard.
I prefer Apple UK/US International keyboard, building a ABC Extended for X11/Xorg to replace UK/US [Machintosh] International without dead keys on Linux, because it allows me to type in more than 30 pan-Latin languages, including Esperanto, IPA, Vietnamese, Yoruba and Brazilian Amerindian languages. They work perfectly on VSCode.

In version 1.25.1 (or some update of my Ubuntu) the combination 'c worked again.


"close" does not exist on - While using stream passthrough with parquets

Thanks for opening the issue.
Could you please give more details? What's the scenario you're seeing this in?

It occurs when I am using stream passthrough when calling the writer.close(). On further inspection seems to be caused due to "end()" doesn't exist on the passthrough stream.
The intention of using passthrough is to save parquet buffer directly into s3, without creating any stream

I tried to reproduce it in https://github.com/dvirtz/parquets/blob/issue19-2/test/integration.ts#L548 and it seems to work ok.


Fix for issue https://github.com/grails/grails-core/issues/10477

Fix for issue https://github.com/grails/grails-core/issues/10477
See discussion http://stackoverflow.com/questions/42136918/error-upgrading-grails-app-from-3-1-10-to-3-2-5

This fix is to simplistic, issue remains. This fix solves that the default datasource becomes available in the applicationcontext, but initializes the ChainedTransactionManager with a duplicate default datasource platformtransactionManager.

I've created another pull request in https://github.com/grails/gorm-hibernate5/pull/20 which resolves my previously comment. This fix should only be applied or ignored in combination with this pull request.

as gorm-6.0.8 is released, could this change be released with database-migration-3.0.1? thanks!


d3.tree won't accept a hierarchy where children are an empty list

It turns out this line https://github.com/d3/d3-hierarchy/blob/master/src/tree.js#L150 breaks if the passed hierarchy has an empty list of children (due to the fact that children[0] will be undefined
TypeError: Cannot read property 'z' of undefined
at firstWalk (tree.js:150)
at TreeNode.eachAfter (eachAfter.js:10)
at GraphService.tree (tree.js:110)
where GraphService is my code handling my hierarchy graph).
Solving the bug in user code is of course really simple (just need to check length and put undefined or null instead), but I do think d3.tree should check it as well and treat empty arrays just like it treat the null/undefined case.
PS Just to clarify, of course it was not d3.hierarchy to put the list to empty, it was user code accessing a node.children property to filter it.
Sadly there's no API to filter a hierarchy after it has been computed (other than using .each and setting children manually), but computing it from scratch was not feasible in that scenario.
I think a filter API would be welcome; handling empty list cases would suffice otherwise (please note that in the documentation nothing says children lists cant be empty, and the tree function could be called even with non-d3 (but compatible) data structures, so assuming the non-emptiness of a list doenst feel right)

I think this is a case that would be covered by https://github.com/d3/d3-hierarchy/issues/140#issuecomment-478358479

Not exactly. In my case the children are arrays, just empty arrays. d3.hierarcly (probably for optimination sake) makes leaves have children undefined, while it will throw error if emtpy.

The contract of d3.hierarchy currently is that node.children is undefined for leaf nodes. Thus, if node.children is defined, it must be a non-empty array. We could redesign that in a future major version, but that’s the current contract.

Such contract should be documented though.
Documentation exists for a reason, that reason includes explicit declaring
the contracts
Il giorno ven 24 mag 2019, 16:35 Mike Bostock<EMAIL_ADDRESS>ha
scritto:

The contract of d3.hierarchy currently is that node.children is
undefined for leaf nodes. Thus, if node.children is defined, it must be
a non-empty array. We could redesign that in a future major version, but
that’s the current contract.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/d3/d3-hierarchy/issues/144?email_source=notifications&email_token=AAAZEDDENX52BLYJJN5Y4X3PW74MLA5CNFSM4HMDYJBKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODWFSAUA#issuecomment-495657040,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAAZEDBBQFQSM3SNI44MLNDPW74MLANCNFSM4HMDYJBA
.

See https://github.com/d3/d3-hierarchy#hierarchy

The specified children accessor (…) must return an array of data representing the children, or null if the current datum has no children.
The returned node and each descendant has the following properties: (…) node.children — an array of child nodes, if any; undefined for leaf nodes

maybe we should explicitly add "non-empty": must return a non-empty array of data representing the children?

Leaf nodes by definition have no children, so it’s already documented that node.children is undefined in this case. I don’t think the API reference needs any further editing but it will help when we publish extended tutorials and examples for d3-hierarchy.


Add downloading file attachment handler

First draft of an attachment handler that mimics how browsers handle attachments, specifically

download file into a default folder when attachment response is detected
infer filename from octet stream response and use that when saving file
if a file already exists, append number to it. keep incrementing number until you find a slot that is free (thats how Chrome handles duplicate filenames)

The implementation allows defining the download folder. If empty constructor is used, temporary folder is used by default.
Open questions for Ronald

how should I handle exceptions?

When the download folder can't be used, throw an exception, and if so which one? A silent error would not be useful, but don't want to crash the whole driver
When the handle attachment method fails, either due to i/o exception or something else, which exceptions, if any, should be thrown? or should the method eat up the exception and only report and error in the logs?

What about the test cases, how do you recommend mocking the features?

I've added todo notes in my "test" that is really just a method I used to run the thing. The test scenarios I would like to cover are mentioned there, but I have experience with Junit 5 only. Would use a temp dir to test, but if you want to remove any i/o in tests then another option would be to set up mocks.

In general, treat this as a draft as the code is not very clean, but looking for your opinion before refactoring.

@rbri how would you recommend I handle exceptions in the handleAttachments method?
I can promote them upwards, or eat them, log error and move on.
Normal browsers don't crash if a file fails to download, so I would choose that option.
For the constructor, if the destination folder is not readable, throwing an IO exception seems accurate, what are your thoughts?

Sounds all reasonable for me.

@rbri updated attachment handler so it should be good to go.
For tests, how would you recommend creating or mocking a webresponse that is an attachment?
And when are you planning to release 4.2.0? Would like to finish this and have it in a mergeable state before a new version is released.

@skyhirider thanks a lot - will merge this now and then update and add some tests

Thanks for the merge!


ItemsControl with userontrols collection doesn't work.

Describe the bug
I used Avalonia ItemsControl in my project with Avalonia 11.0.10. ItemsControl worked fine with my own viewmodel usercontrols. The update to 11.2.2 broke this scenario.
<Window
    x:Class="AvaloniaItemsControlTest.Views.MainWindow"
    xmlns="https://github.com/avaloniaui"
    xmlns:x="http://schemas.microsoft.com/winfx/2006/xaml"
    xmlns:d="http://schemas.microsoft.com/expression/blend/2008"
    xmlns:mc="http://schemas.openxmlformats.org/markup-compatibility/2006"
    xmlns:v="using:AvaloniaItemsControlTest.Views"
    xmlns:vm="using:AvaloniaItemsControlTest.ViewModels"
    Title="AvaloniaItemsControlTest"
    d:DesignHeight="450"
    d:DesignWidth="800"
    Height="400"
    Width="400"
    x:DataType="vm:MainWindowViewModel"
    Icon="/Assets/avalonia-logo.ico"
    mc:Ignorable="d">

    <ItemsControl ItemsSource="{Binding PanelPages}">
        <ItemsControl.ItemTemplate>
            <DataTemplate DataType="vm:PageViewModel">
                <StackPanel Margin="0,0,0,10" Orientation="Vertical">
                    <v:Page DataContext="{Binding}" />
                </StackPanel>
            </DataTemplate>
        </ItemsControl.ItemTemplate>
    </ItemsControl>

</Window>

using CommunityToolkit.Mvvm.ComponentModel;
using System.Collections.ObjectModel;

namespace AvaloniaItemsControlTest.ViewModels;

public partial class MainWindowViewModel : ViewModelBase
{
    //-----------------------------------------------------------------------------------------------
    [ObservableProperty]
    public string _TestText = "Binding Text ";

    [ObservableProperty]
    ObservableCollection<PageViewModel> _PanelPages = [];
    //-----------------------------------------------------------------------------------------------

    public MainWindowViewModel()
    {
        for (int i = 0; i < 3; i++)
            PanelPages.Add(new PageViewModel(TestText + i));
    }
    //-----------------------------------------------------------------------------------------------
}

<UserControl
    x:Class="AvaloniaItemsControlTest.Views.Page"
    xmlns="https://github.com/avaloniaui"
    xmlns:x="http://schemas.microsoft.com/winfx/2006/xaml"
    xmlns:d="http://schemas.microsoft.com/expression/blend/2008"
    xmlns:mc="http://schemas.openxmlformats.org/markup-compatibility/2006"
    xmlns:vm="using:AvaloniaItemsControlTest.ViewModels"
    d:DesignHeight="450"
    d:DesignWidth="800"
    x:DataType="vm:PageViewModel"
    mc:Ignorable="d">

    <Border
        Grid.Row="0"
        Margin="10,10,10,0"
        BorderBrush="#D1D1D1"
        BorderThickness="1"
        CornerRadius="10">

        <TextBlock
            Margin="5,5,5,5"
            HorizontalAlignment="Left"
            VerticalAlignment="Top"
            Text="{Binding TestText}" />
    </Border>
</UserControl>

namespace AvaloniaItemsControlTest.ViewModels;

public partial class PageViewModel : ViewModelBase
{
    //-----------------------------------------------------------------------------------------------
    [ObservableProperty]
    public string _TestText = "TestText";
    //-----------------------------------------------------------------------------------------------

    public PageViewModel(string text)
    {
        TestText = text;
    }
    //-----------------------------------------------------------------------------------------------
}

Programm incorrect behavior:

I have created a test project to show the issue.
https://drive.google.com/file/d/13O38Ea1-MfUSdeA6OBNF7T2bRSpZCaXx/view?usp=sharing
To Reproduce

Create your own viemodel user control.
Create its instances collection in other viemodel control.
Try to place this collection with ItemsControl.

Expected behavior

Avalonia version
11.2.2
OS
Windows, Linux
Additional context
No response

DataContext="{Binding}"
This assignment is probably useless. Could you test it without this? I don't say it shouldn't, it should. But may be a workaround for the moment.

DataContext="{Binding}"
This assignment is probably useless. Could you test it without this? I don't say it shouldn't, it should. But may be a workaround for the moment.

This assignment isn't useless. It binds the usercontrol datacontext with viemodel instance of datacontexts collection (PanelPages) of parent control.
https://docs.avaloniaui.net/docs/basics/data/data-binding/data-binding-syntax
Empty Binding Path
You can specify data bindings without a Path. This binds to the DataContext of the Control itself (where the binding is defined). These two syntaxes are equivalent:

I really don't konow how to bind it another way in ItemsControl.ItemTemplate. In Avalonia 11.0.10 it worked fine.
Could you suggest another way of binding?

Again, you may not need a binding here at all since it should inherit DataContext automatically. Typically that should magically work. If not, I will try to check your sample the other day

Again, you may not need a binding here at all since it should inherit DataContext automatically. Typically that should magically work. If not, I will try to check your sample the other day

I understand now.
The solution is:
<ItemsControl ItemsSource="{Binding PanelPages}">
        <ItemsControl.ItemTemplate>
            <DataTemplate DataType="vm:PageViewModel">
                <StackPanel Margin="0,0,0,10" Orientation="Vertical">
                    <v:Page />
                </StackPanel>
            </DataTemplate>
        </ItemsControl.ItemTemplate>
    </ItemsControl>

Thank you very much!

Close as duplicate


Remove start page-related commands and display logic

For #16453
This makes the existing start page inaccessible to prepare for #16709. The juicy code removal (+ news file) will be done in a separate PR 🧃

whoops sorry @paulacamargo25 I don't know why it re-requested a review, I guess I shouldn't have used the back button or something 🙈


Dockerfile: fix package URLs after version update

These RPMs have been replaced by newer releases, and this resulted in
download errors.
Signed-off-by: Gabor Igloi<EMAIL_ADDRESS>

This should also fix the Travis build of this repo.

Travis passes; merging!


update protoc plugin helper

github.com/golang/protobuf/protoc-gen-go/generator is deprecated
exchange with google.golang.org/protobuf/compiler/protogen

@livio-a is this still relevant? Or can we close this?

I have no opinion to this

has been solved with #5708 and #5798


Suggestion - Alternate way of use

I read 1162 to find a more RP way to use it - as it's to regain something lost and to lost something on you, so I suggest :

Having a configurable % of chance for it to spawn
Having the ability to configure which room is the 1162 spawn.
Having a message sent when you enter the room to notify you of 1162 presence.
Not throwing an item to start it but rather stay in the room for X (configurable) seconds and not moving.

Randomly lost an item; if no items on the player, lost X (configurable) HP.
Limit to X (configurable) uses.

Thanks for the ideas! I will take a look to implement some of them

Thanks for the ideas! I will take a look to implement some of them