freeCodeCamp profile is missing indications of fields

When you read a profile it's not clear that those are Name, Location, About

Maybe @bbsmooth can give some accessibility indications?

Hey @ieahleen How do I get to that profile you displayed in your first pic?

Thank you @bbsmooth , it's at freecodecamp.org/ieahleen

There are quite a few accessibility issues with this profile page, but I'll stick to the topic at hand. For the personal information displayed in your first pic above, there is no requirement that you need to label what each of these are. Yes, it is not clear what some of these are, but it is not clear for everyone, regardless of how you are accessing the page, so there is no accessibility issue here since everyone experiences this ambiguity. The decision as to whether you want to label these to make it clearer is a usability issue. If we want to make sure that everyone understands what these are then we should label them. If we are fine with the ambiguity then we can leave them as is.

I tested out adding translatable labels next to the Name, Location, and Bio to make it a little clearer. If this looks ok, and there aren't any accessability issues, I can submit a PR with these changes.

I think I would prefer to leave this how it is - but I'm not against adding some labels either. That looks pretty decent. I wonder if it would look better with the colons all lined up - e.g. the colon (:) on each line would be horizontally centered. Hmm, I think that about section allows quite a lot of characters so that may not work well.

I think I would prefer to leave this how it is

It's not terrible as is, but I think there's room for improvement.
However, I'm not sure we need labels for all of them, since Name should be self-explanatory and About probably is, too. That said, Location being the only one with a text label looks a little strange.  We could try using a icon (with aria-label) for Location and see how that looks.
@ahmadabdolsaheb what do you reckon?

I know we're still kind of on the fence about whether labels are needed or not. I tweaked my original changes I screenshotted earlier to line the labels up and put the responses in a  so that they don't bleed past what would look normal. I think this looks better, but I totally understand if we go towards not having labels:

Here's one more screenshot with a longer About section so you can see how it would look if someone wrote a novel for their bio :)

This is neat 🔥

I went ahead and submitted a PR with these changes, if everyone else thinks we shouldn't need the labels, I can close the PR. If everyone approves of the changes, if I could get a hacktoberfest label applied, that would be great!

The redesign of the Profile is way overdue. How about organizing the user information section in the following way. It should make things more obvious.

I like Ahmad's design here - but it also doesn't include any labels. So I think we are probably leaning towards not adding labels. I looked a few profiles quick - twitter, github, our forum - they don't really include labels either. But they do seem to universally use some icons to indicate things where applicable...
Twitter:

GitHub:

Forum:

Our current profile pages have some icons already, so I would vote to stick with those. We could find an icon for each of the areas - or maybe just the location can have one of those drop pins or something. Wondering if we should have this issue focus on adding some icons and make another for the redesign, or just do the redesign here.

For this specific issue, I think we should either add another icon for the location, or just leave it all as is and close this - and create a separate issue for the redesign.

That is a good idea. As Ilenia mentioned, the Profile info is not presented well. It would be better if we focus our attention to a redesign.
I am closing this issue in favor of #48234
Please let me know if this has been closed by mistake.


goframe在线文档打不开了

1. What version of Go and system type/arch are you using?

2. What version of GoFrame are you using?

3. Can this issue be re-produced with the latest release?
4. What did you do?

5. What did you expect to see?
6. What did you see instead?

solved


issues with combine cols

from @LTLA:
not only did it convert it into a pandas DF, it also converted my list of strings into a column of mixed str/doubles.
FYI this is on two singlecellexperiment objects.

Done in #52


Heightmap support for DART

DART supports heightmap geometries. We should tie that into Ignition Physics.
This is needed by https://github.com/ignitionrobotics/ign-gazebo/issues/237.
It can make use of this PR adding heightmaps to SDF: https://github.com/osrf/sdformat/pull/388
See gazebo::physics::DARTHeightmapShape as reference.

I've started work on this in the following branch, but I haven't finished the CustomHeightmapShape constructor and probably need to change the parameters in the AttachHeightmapShape API (I had initially copied the mesh API)

https://github.com/ignitionrobotics/ign-physics/compare/ign-physics2...scpeters:heightmap2

I've started work on this in the following branch, but I haven't finished the CustomHeightmapShape constructor and probably need to change the parameters in the AttachHeightmapShape API (I had initially copied the mesh API)

https://github.com/ignitionrobotics/ign-physics/compare/ign-physics2...scpeters:heightmap2

still need to port the code for creating the heightmap shape:

https://github.com/osrf/gazebo/blob/gazebo11_11.3.0/gazebo/physics/dart/DARTHeightmapShapePrivate.hh#L73-L82
https://github.com/osrf/gazebo/blob/gazebo11_11.3.0/gazebo/physics/dart/DARTHeightmapShape.cc#L56-L68

still need to port the code for creating the heightmap shape:

https://github.com/osrf/gazebo/blob/gazebo11_11.3.0/gazebo/physics/dart/DARTHeightmapShapePrivate.hh#L73-L82
https://github.com/osrf/gazebo/blob/gazebo11_11.3.0/gazebo/physics/dart/DARTHeightmapShape.cc#L56-L68

Rebased @scpeters 's branch onto main and fixed compilation in https://github.com/ignitionrobotics/ign-physics/compare/main...chapulina/4/heightmap


make database sizetype automatically detectable

and don't forget to adapt Match's TPos accordingly, as well!

moved to https://github.com/seqan/lambda/issues/6


merge from template-node-app

package.json

chore(deps): add ^11.5.15 remove ^11.5.14 (devDependencies.npm-pkgbuild)

:tada: This PR is included in version 6.4.0 :tada:
The release is available on:

npm package (@latest dist-tag)
v6.4.0
GitHub release

Your semantic-release bot :package::rocket:


Fix asset paths

When you go to any other page, the CSS and JS paths are incorrect, as you can see in this image:

This pull request fixes the paths to the CSS and JS assets for every page. Here is an image after the file changes:

Thank you.

Thank you.


fix: Slider component

Hello @bloodyowl
By upgrading lake to version v2.7.32 I discover an issue with Slider component. I explain it with screenshot in this issue: https://github.com/swan-io/lake/issues/160
Finally I found an easy fix by forcing the with to 100%. In my case it fixes my issue. And I'm confident this will not add breaking change to your apps.
I also thought about using LakeSlider but it automatically becomes a text input because of the with of my form.
But if you prefer I can make another PR which adapts LakeSlider for my needs.

Hi @bloodyowl,
I know you're busy, especially monday but if you have a few minutes to validate this PR, it will help me lot because the Slider is broken and makes the 3d card configurator unusable.
Wish you a nice day!

Hello @Epimodev ! We had a regression on the LakeButton component which is used in the slider. We just released a fix, normally you can test if it solves your problem :)

Hi @sandrine-ds!
Thanks a lot for your answer.
I just tried and I confirm it works perfectly well!
Wish you a nice day!


[Mobile]add knobs to set QUIC connection options and client connection options

Commit Message: add knobs to set QUIC connection options and client connection options
Additional Description: This allows Envoy Mobile applications to set Quiche's connection options so that more performance tuning can be done.
Please note: My original change doesn't change any BUILD files. These changes are generated by formatting tools.
Risk Level: Low
Testing: Unit tests
Docs Changes: n/a
Release Notes: n/a
Platform Specific Features: Mobile only

Looks like the failure are real.
https://github.com/envoyproxy/envoy/actions/runs/5791108893/job/15695371848?pr=28883
https://dev.azure.com/cncf/envoy/_build/results?buildId=145421&view=logs&jobId=c95d62a5-6bb9-58f0-2a02-7575fd482a15&j=c95d62a5-6bb9-58f0-2a02-7575fd482a15&t=76c9b3e6-0d40-57e9-06f3-2219e9228a0a

/retest

/retest

/restest

/retest


AWS SDK signature v4 support is added.

Check out http://docs.aws.amazon.com/AmazonS3/latest/dev/UsingAWSSDK.html

In frankfurt zone they ask for v4 and we really love to use it. Thanks for the component.

Thanks!


Stop crashing for type_member/type_template mismatch

Motivation

Fixes #5719
Commit summary

Add test showing existing behavior (6ddceee11)
The commented out section crashes, but surprisingly, there's no error
for the other part. I don't think people should be relying on it working
that way, and I intend to make that an error.

Fix crash via findMemberNoDealias (213d2bfbf)
The fix for the crash is one line: findMember -> findMemberNoDealias
What was happening before was that for an example like this (from the
test suite):
class AbstractRPCMethod
 extend T::Generic

  RPCInput = type_member

end
class TextDocumentHoverMethod < AbstractRPCMethod
 RPCInput = type_template

end
Sorbet thought that it foundAll parent type members in the child. That
was deceptive though, because what was actually happening was:

it found the static field class alias we create in
TextDocumentHoverMethod called RPCInput that forwards to the
real type_template on T.class_of(TextDocumentHoverMethod)
it just so happened that the thing it resolves to isTypeMember and
has the same name, so Sorbet would think that it found what it was
looking for.

I've decided to fix this by not allowing any type members to be
redeclared indirectly via an alias. This prevents some code that used to
work from working, but I can only imagine contrived use cases for that,
and this seems wholly better to ban it.
The error handling code implements a special case for the
type_member/type_template mismatch (not out of necessity but instead to
prevent confusion).

Some tests change (697addf2f)

Test plan

See included automated tests.

We have a policy of testing changes to Sorbet against Stripe's codebase before
merging them. I've kicked off a test run for the current PR.  When the build
finishes, I'll share with you whether or how it failed. Thanks!
Stripe employees can see the build results here:
→ https://go/builds/bui_NEoL0eBS8ERoU3
→ https://go/builds/bui_NEoLp9aNyuswMs


Add Request object and implement IBConnector UpdateObject

This patch adds support for the 'Request' NIOS object.
IBConnector UpdateObject method is also implemented in this patch.

Thanks Ko for Merging this. Yes I will address the Locker changes a new PR along with the docker-infoblox changes. I did not do that in this PR as it was too big a change for this PR.

Totally agreed! Thanks!!


HDDS-8382. Upgrade Ratis to 2.5.1

What changes were proposed in this pull request?
Upgrade Ratis to 2.5.1.
Fix for compilation error in tests due to interface change was provided by @szetszwo.  When merging this, please keep the following detail in the commit message:
Co-authored-by: Tsz-Wo Nicholas Sze<EMAIL_ADDRESS>
https://issues.apache.org/jira/browse/HDDS-8382
How was this patch tested?
CI:
https://github.com/adoroszlai/hadoop-ozone/actions/runs/4891132333

TestDeleteWithSlowFollower is flaky (HDDS-8430), but it seems to be failing more frequently with new Ratis.

With Ratis 2.5.1, block is deleted contrary to test expectations.  This results in two kinds of failures, depending on timing:
https://github.com/apache/ozone/blob/7f7ec2397ac029cf2a8bc8490b7ecafb34020b0d/hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/client/rpc/TestDeleteWithSlowFollower.java#L305-L306
https://github.com/apache/ozone/blob/7f7ec2397ac029cf2a8bc8490b7ecafb34020b0d/hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/client/rpc/TestDeleteWithSlowFollower.java#L307-L317
When block deletion reaches the following condition:
https://github.com/apache/ozone/blob/7f7ec2397ac029cf2a8bc8490b7ecafb34020b0d/hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/keyvalue/statemachine/background/BlockDeletingService.java#L223-L232
with Ratis 2.5.1 minReplicatedIndex is always -1 (I guess due to RATIS-1767, but could be wrong), so deletion is allowed.
I think the minReplicatedIndex >= 0 condition is wrong.  If minReplicatedIndex == -1, then we should not allow deleting the blocks, so I removed that condition.  Test passes locally.  Pushed new commit, waiting for CI in fork.

Thanks @smengcl for the review, @szetszwo for helping out with the state machine tests, reviewing and merging this.


QR scanner class missing from repro

Looks like the the GoogleQRScanner.class is missing from the repro. Could you please add it?

Fixed


Update to task version 2.0.0

As per the latest release of vscode, the extension needs to update to task version 2.0.0

@akshita31 Why do we have to do this? After it, what's the new minimum required version to work on the product?

@rchande It was mentioned in the vscode 1.24 release notes - https://code.visualstudio.com/updates/v1_24#_tasks-and-extension-authoring.

Duplicate of #2409


[DEVOPS-1166]  --metrics is also needed to start EKG

Sister PR to https://github.com/input-output-hk/daedalus/pull/1204 -- repairs EKG startup on non-mainnet builds.

Review Checklist:
Basics

[ ] PR is updated to the most recent version of target branch (and there are no conflicts)
[ ] PR has good description that summarizes all changes and shows some screenshots or animated GIFs of important UI changes
[ ] CHANGELOG entry has been added and is linked to the correct PR on GitHub
[ ] Automated tests: All acceptance tests are passing (yarn run test)
[ ] Manual tests (minimum tests should cover newly added feature/fix): App works correctly in development build (yarn run dev)
[ ] Manual tests (minimum tests should cover newly added feature/fix): App works correctly in production build (yarn run package / CI builds)
[ ] There are no flow errors or warnings (yarn run flow:test)
[ ] There are no lint errors or warnings (yarn run lint)
[ ] Text changes are proofread and approved (Jane Wild)
[ ] There are no missing translations (running yarn run manage:translations produces no changes)
[ ] UI changes look good in all themes (Alexander Rukin)
[ ] Storybook works and no stories are broken (yarn run storybook)
[ ] In case of dependency changes yarn.lock file is updated

Code Quality

[ ] Important parts of the code are properly documented and commented
[ ] Code is properly typed with flow
[ ] React components are split-up enough to avoid unnecessary re-rendering
[ ] Any code that only works in Electron is neatly separated from components

Testing

[ ] New feature / change is covered by acceptance tests
[ ] All existing acceptance tests are still up-to-date
[ ] New feature / change is covered by Daedalus Testing scenario
[ ] All existing Daedalus Testing scenarios are still up-to-date

After Review:

[ ] Merge PR
[ ] Delete source branch
[ ] Move ticket to done on the Youtrack board

@deepfire not sure this PR is what we want. We will need to merge release/0.12.0 branch into the develop. I will handle that tomorrow.


dynamic subzone for DNS 2136 update

I have a setup with a dynamic subdomain zone where bind can create a text entry and this text is referenced by an alias in the main zone. The main zone is static and not changeable dynamically. The idea of it is that this should be more safe.
Dynamic Zone wich can be edited by dehydrated auto.mydomain.de
Static Zone mydomain.de
Alias in static zone _acme-challenge.mydomain.de for _acme-challenge.auto.mydomain.de
Text record which is set by dehydrated hook script in bind DNS
_acme-challenge.auto.mydomain.de.
Text record which is checked by dehydrated for validation: _acme-challenge.mydomain.de. - this is not existing but due to alias it looks like it is existing.
Due to changes of letsencrypt (they claim that this setup should never has worked and was never supported but it did work with dehydrated and with certbot) I had to change the auto.mydomain.de subzone to _acme-challenge.mydomain.de subzone. As a result I had to remove the alias entry because subzone and alias could not exist both with identical names.
After that change certbot is working again but dehydrated does not. I adapted my hook file and basically the log is looking good exept the result. All parts of the hookfile seem to work. The text entry is set and text entry is verified in the hook file but the dehydrated script does not seem to check the text entry in the subzone but in the mainzone which does not exist and due to missing alias is not found.
Is there a way to get this running?
Logging:
sudo /etc/dehydrated/dehydrated -c -d "*.mydomain.de mydomain.de" --alias _wildcard.mydomain.de -k /etc/dehydrated/hookmydomain.sh -t dns-01
# INFO: Using main config file /etc/dehydrated/config
Processing *.mydomain.de with alternative names: mydomain.de
 + Checking domain name(s) of existing cert... unchanged.
 + Checking expire date of existing cert...
 + Valid till Sep 29 00:11:26 2022 GMT (Less than 30 days). Renewing!
 + Signing domains...
 + Generating signing request...
 + Requesting new certificate order from CA...
 + Received 2 authorizations URLs from the CA
 + Handling authorization for mydomain.de
 + Handling authorization for mydomain.de
 + 2 pending challenge(s)
 + Deploying challenge tokens...
 + Adding ACME challenge record via RFC2136 update to mydomain.de...
server ns1.mydomain.de 53
zone _acme-challenge.mydomain.de
update add _acme-challenge._acme-challenge.mydomain.de. 300 in TXT "njiETjfA98Us0-_fQp19UQGMXUD28pY0JgIdWMM3uhI"
show
send

 + Checking for dns propagation via Google's recursor... (1/30)
 + domain mydomain.de
 + text _acme-challenge._acme-challenge.mydomain.de
 + token 1 njiETjfA98Us0-_fQp19UQGMXUD28pY0JgIdWMM3uhI
 + token 2 njiETjfA98Us0-_fQp19UQGMXUD28pY0JgIdWMM3uhI
 + token 3 njiETjfA98Us0-_fQp19UQGMXUD28pY0JgIdWMM3uhI
 + Propagation success!
 + Adding ACME challenge record via RFC2136 update to mydomain.de...
server ns1.mydomain.de 53
zone _acme-challenge.mydomain.de
update add _acme-challenge._acme-challenge.mydomain.de. 300 in TXT "cAKVS6jjhCj3uZtGSsnY8ocxtqrMOCT29PasexNGUdg"
show
send

 + Checking for dns propagation via Google's recursor... (1/30)
 + domain mydomain.de
 + text _acme-challenge._acme-challenge.mydomain.de
 + token 1 cAKVS6jjhCj3uZtGSsnY8ocxtqrMOCT29PasexNGUdg
 + token 2 cAKVS6jjhCj3uZtGSsnY8ocxtqrMOCT29PasexNGUdg
 + token 3 cAKVS6jjhCj3uZtGSsnY8ocxtqrMOCT29PasexNGUdg
 + Propagation success!
 + Responding to _acme-challenge for mydomain.de authorization...
 + Cleaning challenge tokens...
 + Removing ACME challenge record via RFC2136 update to mydomain.de...
server ns1.mydomain.de 53
zone _acme-challenge.mydomain.de
update delete _acme-challenge._acme-challenge.mydomain.de. 300 in TXT "njiETjfA98Us0-_fQp19UQGMXUD28pY0JgIdWMM3uhI"
show
send

 + Removing ACME challenge record via RFC2136 update to mydomain.de...
server ns1.mydomain.de 53
zone _acme-challenge.mydomain.de
update delete _acme-challenge._acme-challenge.mydomain.de. 300 in TXT "cAKVS6jjhCj3uZtGSsnY8ocxtqrMOCT29PasexNGUdg"
show
send

 + Challenge validation has failed :(
ERROR: Challenge is invalid! (returned: invalid) (result: ["type"]      "dns-01"
["status"]      "invalid"
["error","type"]        "urn:ietf:params:acme:error:unauthorized"
["error","detail"]      "No TXT record found at _acme-challenge.mydomain.de"
["error","status"]      403
["error"]       {"type":"urn:ietf:params:acme:error:unauthorized","detail":"No TXT record found at _acme-challenge.mydomain.de","status":403}
["url"] "https://acme-v02.api.letsencrypt.org/acme/chall-v3/153375141527/8mSBgw"
["token"]       "J4yzcZYTu0XUGx5ujls4IzylTm0sYm__ss6Qq549R-Xk"
["validated"]   "2022-09-14T18:55:40Z")

I think the relevant part is this one: "No TXT record found at _acme-challenge.mydomain.de","status":403
Threre can't be any text record because that's the subzone byself and this is needed for certbot otherwise it is not working anymore. So basically only the subzone has to be added for the check.
Old hook file:
# NSUPDATE - Path to nsupdate binary
[ -z "${NSUPDATE}" ] && NSUPDATE="sudo /usr/bin/nsupdate -k /etc/dehydrated/Kbackprod.de.+157+03869.private -v"

# SERVER - Master DNS server IP
[ -z "${SERVER}" ] && SERVER="mydomain.de"

# Dynamic Subzone Prefix
[ -z "${SUBPRE}" ] && SUBPRE="auto"

# PORT - Master DNS port (likely to be 53)
[ -z "${PORT}" ] && PORT=53

# TTL - DNS Time-To-Live of ACME TXT record
[ -z "${TTL}" ] && TTL=300

# ATTEMPTS - Wait $ATTEMPTS times $SLEEP seconds for propagation to succeed, then bail out.
[ -z "${ATTEMPTS}" ] && ATTEMPTS=30

# SLEEP - Amount of seconds to sleep before retrying propagation check.
[ -z "${SLEEP}" ] && SLEEP=60

_log() {
echo >&2 " + ${@}"
}

_checkdns() {
local ATTEMPT="${1}" DOMAIN="${2}" TOKEN_VALUE="${3}"
if [ $ATTEMPT -gt $ATTEMPTS ];
then
_log "Propagation check failed after ${ATTEMPTS} attempts. Bailing out!"
exit 2
fi

_log "Checking for dns propagation via Google's recursor... (${ATTEMPT}/${ATTEMPTS})"

host -t txt _acme-challenge.${DOMAIN} <IP_ADDRESS> | grep -- ${TOKEN_VALUE} >/dev/null 2>&1
if [ "$?" -eq 0 ];
then
host -t txt _acme-challenge.${DOMAIN} <IP_ADDRESS> | grep -- ${TOKEN_VALUE} >/dev/null 2>&1
if [ "$?" -eq 0 ];
then
host -t txt _acme-challenge.${DOMAIN} <IP_ADDRESS> | grep -- ${TOKEN_VALUE} >/dev/null 2>&1
if [ "$?" -eq 0 ];
then
_log "Propagation success!"
return
fi
fi
else

_log "Waiting ${SLEEP}s..."
sleep ${SLEEP}
_checkdns $((ATTEMPT+1)) ${DOMAIN} ${TOKEN_VALUE}
fi
}

deploy_challenge() {
local DOMAIN="${1}" TOKEN_FILENAME="${2}" TOKEN_VALUE="${3}"

printf "server ns1.%s %s\nzone %s.%s\nupdate add _acme-challenge.%s.%s. %d in TXT \"%s\"\nshow\nsend\n\n" "${SERVER}" "${PORT}" "${SUBPRE}" "${SERVER}" "${SUBPRE}" "${DOMAIN}" "${TTL}" "${TOKEN_VALUE}" | $NSUPDATE > /dev/null 2>&1
if [ "$?" -ne 0 ];
then
_log "Failure reported by nsupdate. Bailing out1!"
exit 2
fi

# Allow at least a little time to propagate to slaves before asking Google
sleep 5

_checkdns 1 ${DOMAIN} ${TOKEN_VALUE}
}

clean_challenge() {
local DOMAIN="${1}" TOKEN_FILENAME="${2}" TOKEN_VALUE="${3}"

_log "Removing ACME challenge record via RFC2136 update to ${SERVER}..."
printf "server ns1.%s %s\nzone %s.%s\nupdate delete _acme-challenge.%s.%s. %d in TXT \"%s\"\nshow\nsend\n\n" "${SERVER}" "${PORT}" "${SUBPRE}" "${SERVER}" "${SUBPRE}" "${DOMAIN}" "${TTL}" "${TOKEN_VALUE}" | $NSUPDATE > /dev/null 2>&1
if [ "$?" -ne 0 ];
then
_log "Failure reported by nsupdate. Bailing out2!"
exit 2
fi
}

deploy_cert() {
local DOMAIN="${1}" KEYFILE="${2}" CERTFILE="${3}" FULLCHAINFILE="${4}" CHAINFILE="${5}" TIMESTAMP="${6}"

if [ "$DESTINATION" != "" ];
then
_log "Copying certificate files to destination repository"

mkdir -p ${DESTINATION}/${DOMAIN}
if [ "$CERTDIR_MODE" != "" ];
then
chmod ${CERTDIR_MODE} ${DESTINATION}/${DOMAIN}
fi

if [ "$CERTDIR_OWNER" != "" ];
then
chown ${CERTDIR_OWNER}:${CERTDIR_GROUP} ${DESTINATION}/${DOMAIN}
fi

if [ "$CERTDIR_MODE" != "" ];
then
chmod ${CERTDIR_MODE} ${DESTINATION}/${DOMAIN}
fi

for FILE in ${KEYFILE} ${CERTFILE} ${CHAINFILE}
do
FILENAME=$(basename $FILE)
cp ${FILE} ${DESTINATION}/${DOMAIN}

if [ "$CERT_OWNER" != "" ];
then
chown ${CERT_OWNER}:${CERT_GROUP} ${DESTINATION}/${DOMAIN}/${FILENAME}
fi

if [ "$CERT_MODE" != "" ];
then
chmod ${CERT_MODE} ${DESTINATION}/${DOMAIN}/${FILENAME}
fi
done
fi

# Add DOMAIN to domains.txt if not already there
grep ^$HOST\$ ${DOMAINS_TXT} > /dev/null 2>&1
if [ "$?" -ne 0 ];
then
echo ${DOMAIN} >> ${DOMAINS_TXT}
fi
}

unchanged_cert() {
local DOMAIN="${1}" KEYFILE="${2}" CERTFILE="${3}" FULLCHAINFILE="${4}" CHAINFILE="${5}"
}

invalid_challenge() {
local DOMAIN="${1}" RESPONSE="${2}"
:
}

request_failure() {
local STATUSCODE="${1}" REASON="${2}" REQTYPE="${3}" HEADERS="${4}"
}

generate_csr() {
local DOMAIN="${1}" CERTDIR="${2}" ALTNAMES="${3}"
}

startup_hook() {
:
}

exit_hook() {
:
}

HANDLER="$1"; shift
if [[ "${HANDLER}" =~ ^(deploy_challenge|clean_challenge|deploy_cert|unchanged_cert|invalid_challenge|request_failure|generate_csr|startup_hook|exit_hook)$ ]]; then
"$HANDLER" "$@"
fi

New hook File:
[ -z "${NSUPDATE}" ] && NSUPDATE="sudo /usr/bin/nsupdate -k /etc/dehydrated/Kbackprod.de.+157+03869.private -v"

# SERVER - Master DNS server IP
[ -z "${SERVER}" ] && SERVER="torstens-buecherecke.de"

# Dynamic Subzone Prefix
#[ -z "${SUBPRE}" ] && SUBPRE="auto"
[ -z "${SUBPRE}" ] && SUBPRE="_acme-challenge"

# PORT - Master DNS port (likely to be 53)
[ -z "${PORT}" ] && PORT=53

# TTL - DNS Time-To-Live of ACME TXT record
[ -z "${TTL}" ] && TTL=300

# ATTEMPTS - Wait $ATTEMPTS times $SLEEP seconds for propagation to succeed, then bail out.
[ -z "${ATTEMPTS}" ] && ATTEMPTS=30

# SLEEP - Amount of seconds to sleep before retrying propagation check.
[ -z "${SLEEP}" ] && SLEEP=60

# DOMAINS_TXT - Path to the domains.txt file containing all requested certificates.
[ -z "${DOMAINS_TXT}" ] && DOMAINS_TXT="${BASEDIR}/domains.txt"

_log() {
echo >&2 " + ${@}"
}

_checkdns() {
local ATTEMPT="${1}" DOMAIN="${2}" TOKEN_VALUE="${3}"
if [ $ATTEMPT -gt $ATTEMPTS ];
then
_log "Propagation check failed after ${ATTEMPTS} attempts. Bailing out!"
exit 2
fi

_log "Checking for dns propagation via Google's recursor... (${ATTEMPT}/${ATTEMPTS})"

host -t txt _acme-challenge.${SUBPRE}.${DOMAIN} <IP_ADDRESS> | grep -- ${TOKEN_VALUE} >/dev/null 2>&1
if [ "$?" -eq 0 ];
then
host -t txt _acme-challenge.${SUBPRE}.${DOMAIN} <IP_ADDRESS> | grep -- ${TOKEN_VALUE} >/dev/null 2>&1
if [ "$?" -eq 0 ];
then
host -t txt _acme-challenge.${SUBPRE}.${DOMAIN} <IP_ADDRESS> | grep -- ${TOKEN_VALUE} >/dev/null 2>&1
if [ "$?" -eq 0 ];
then
_log "Propagation success!"
return
fi
fi
else

_log "Waiting ${SLEEP}s..."
sleep ${SLEEP}
_checkdns $((ATTEMPT+1)) ${DOMAIN} ${TOKEN_VALUE}
fi
}

deploy_challenge() {
local DOMAIN="${1}" TOKEN_FILENAME="${2}" TOKEN_VALUE="${3}"

_log "Adding ACME challenge record via RFC2136 update to ${SERVER}..."
printf "server ns1.%s %s\nzone %s.%s\nupdate add _acme-challenge.%s.%s. %d in TXT \"%s\"\nshow\nsend\n\n" "${SERVER}" "${PORT}" "${SUBPRE}" "${SERVER}" "${SUBPRE}" "${DOMAIN}" "${TTL}" "${TOKEN_VALUE}" | $NSUPDATE > /dev/null 2>&1
if [ "$?" -ne 0 ];
then
_log "Failure reported by nsupdate. Bailing out1!"
exit 2
fi

# Allow at least a little time to propagate to slaves before asking Google
sleep 5

_checkdns 1 ${DOMAIN} ${TOKEN_VALUE}
}

clean_challenge() {
local DOMAIN="${1}" TOKEN_FILENAME="${2}" TOKEN_VALUE="${3}"

_log "Removing ACME challenge record via RFC2136 update to ${SERVER}..."
printf "server ns1.%s %s\nzone %s.%s\nupdate delete _acme-challenge.%s.%s. %d in TXT \"%s\"\nshow\nsend\n\n" "${SERVER}" "${PORT}" "${SUBPRE}" "${SERVER}" "${SUBPRE}" "${DOMAIN}" "${TTL}" "${TOKEN_VALUE}" | $NSUPDATE > /dev/null 2>&1
if [ "$?" -ne 0 ];
then
_log "Failure reported by nsupdate. Bailing out2!"
exit 2
fi
}

deploy_cert() {
local DOMAIN="${1}" KEYFILE="${2}" CERTFILE="${3}" FULLCHAINFILE="${4}" CHAINFILE="${5}" TIMESTAMP="${6}"

if [ "$DESTINATION" != "" ];
then
_log "Copying certificate files to destination repository"

mkdir -p ${DESTINATION}/${DOMAIN}
if [ "$CERTDIR_MODE" != "" ];
then
chmod ${CERTDIR_MODE} ${DESTINATION}/${DOMAIN}
fi

if [ "$CERTDIR_OWNER" != "" ];
then
chown ${CERTDIR_OWNER}:${CERTDIR_GROUP} ${DESTINATION}/${DOMAIN}
fi

if [ "$CERTDIR_MODE" != "" ];
then
chmod ${CERTDIR_MODE} ${DESTINATION}/${DOMAIN}
fi

for FILE in ${KEYFILE} ${CERTFILE} ${CHAINFILE}
do
FILENAME=$(basename $FILE)
cp ${FILE} ${DESTINATION}/${DOMAIN}

if [ "$CERT_OWNER" != "" ];
then
chown ${CERT_OWNER}:${CERT_GROUP} ${DESTINATION}/${DOMAIN}/${FILENAME}
fi

if [ "$CERT_MODE" != "" ];
then
chmod ${CERT_MODE} ${DESTINATION}/${DOMAIN}/${FILENAME}
fi
done
fi

# Add DOMAIN to domains.txt if not already there
grep ^$HOST\$ ${DOMAINS_TXT} > /dev/null 2>&1
if [ "$?" -ne 0 ];
then
echo ${DOMAIN} >> ${DOMAINS_TXT}
fi
}

unchanged_cert() {
local DOMAIN="${1}" KEYFILE="${2}" CERTFILE="${3}" FULLCHAINFILE="${4}" CHAINFILE="${5}"
}

invalid_challenge() {
local DOMAIN="${1}" RESPONSE="${2}"
:
}

request_failure() {
local STATUSCODE="${1}" REASON="${2}" REQTYPE="${3}" HEADERS="${4}"
}

generate_csr() {
local DOMAIN="${1}" CERTDIR="${2}" ALTNAMES="${3}"
}

startup_hook() {
:
}

exit_hook() {
:
}

HANDLER="$1"; shift
if [[ "${HANDLER}" =~ ^(deploy_challenge|clean_challenge|deploy_cert|unchanged_cert|invalid_challenge|request_failure|generate_csr|startup_hook|exit_hook)$ ]]; then
"$HANDLER" "$@"
fi

Found a solution which was way easier than I thought.
NEW:
host -t txt ${SUBPRE}.${DOMAIN} <IP_ADDRESS> | grep -- ${TOKEN_VALUE} >/dev/null 2>&1
SAME for the other two hosts
printf "server ns1.%s %s\nzone %s.%s\nupdate add %s.%s. %d in TXT \"%s\"\nshow\nsend\n\n" "${SERVER}" "${PORT}" "${SUBPRE}" "${SERVER}" "${SUBPRE}" "${DOMAIN}" "${TTL}" "${TOKEN_VALUE}" | $NSUPDATE > /dev/null 2>&1
printf "server ns1.%s %s\nzone %s.%s\nupdate delete %s.%s. %d in TXT \"%s\"\nshow\nsend\n\n" "${SERVER}" "${PORT}" "${SUBPRE}" "${SERVER}" "${SUBPRE}" "${DOMAIN}" "${TTL}" "${TOKEN_VALUE}" | $NSUPDATE > /dev/null 2>&1

OLD:
host -t txt _acme-challenge.${SUBPRE}.${DOMAIN} <IP_ADDRESS> | grep -- ${TOKEN_VALUE} >/dev/null 2>&1
SAME for the other two hosts
printf "server ns1.%s %s\nzone %s.%s\nupdate add _acme-challenge.%s.%s. %d in TXT \"%s\"\nshow\nsend\n\n" "${SERVER}" "${PORT}" "${SUBPRE}" "${SERVER}" "${SUBPRE}" "${DOMAIN}" "${TTL}" "${TOKEN_VALUE}" | $NSUPDATE > /dev/null 2>&1
printf "server ns1.%s %s\nzone %s.%s\nupdate delete _acme-challenge.%s.%s. %d in TXT \"%s\"\nshow\nsend\n\n" "${SERVER}" "${PORT}" "${SUBPRE}" "${SERVER}" "${SUBPRE}" "${DOMAIN}" "${TTL}" "${TOKEN_VALUE}" | $NSUPDATE > /dev/null 2>&1


binaries not linked on install

cipm doesn't link binaries for deps yet, so lifecycle scripts that use them... can't.

Just as a general status update, this seems to be the main blocker for most of the CI jobs I manage.
Current workaround now that #7 landed is cipm --ignore-scripts && npm rebuild, which works fine as long as the root package itself doesn't have any scripts to execute during install (since they're skipped by npm rebuild).


Calling variadic function leads to segfault

Only affect strings, so this is probably an issue with pointer handling.

Likely due to missing sentinel byte.

Ah, pointers aren't getting visited, that's the problem.


Aggregation missing data

[x] Closes #587  .
[ ] I am familiar with the contributing guidelines.
[x] Tests added.
[ ] Updates entries to docs/source/api.rst for API changes.
[ ] Adds descriptions to appropriate "what's new" file in docs/source/whatsnew for all changes. Includes link to the GitHub Issue with :issue:`num` or this Pull Request with :pull:`num`. Includes contributor name and/or GitHub username (link with :ghuser:`user`).
[ ] New code is fully documented. Includes numpydoc compliant docstrings, examples, and comments where necessary.
[ ] Maintainer: Appropriate GitHub Labels and Milestone are assigned to the Pull Request and linked Issue.

A few updates to compute_aggregate here:

Adds the new_index argument to use for the aggregate and when determining valid periods for the observations in the aggregate. Defaults to previous behavior of trying to infer an aggregate index from the passed in data.
Now KeyError is only raised when an observation's effective range overlaps the index of the data argument (or overlaps the index argument added) and does not exist in the data parameter.
Raises a ValueError if the data/index lies outside the effective range of all of the observations in the aggregate. This was motivated by wanting to alert the user when none of the observations are valid for the data/index. I've manually raised this error to pass a meaningful message, but pandas complains anyway with an index and empty data. May have some ramnifications for reports that need to be handled?

The API should determine aggregate index and pass it to compute_aggregate
@alorenzo175 , @wholmgren What do you guys think of these updates?

I like the updates. I don't think there will be any ramifications for the report as this function is only called by the API. So, we need to make sure the API handles it properly


Update cats-core, cats-free, cats-laws to 2.2.0

Updates

org.typelevel:cats-core
org.typelevel:cats-free
org.typelevel:cats-laws

from 2.1.1 to 2.2.0.
GitHub Release Notes - Changelog - Version Diff
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "org.typelevel" } ]

Applied Migrations

github:typelevel/cats/Cats_v2_2_0

Documentation:

https://github.com/typelevel/cats/blob/master/scalafix/README.md#migration-to-cats-v220

labels: library-update, semver-minor, scalafix-migrations

Codecov Report

Merging #418 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #418   +/-   ##
=======================================
  Coverage   95.90%   95.90%
=======================================
  Files          15       15
  Lines         757      757
  Branches       44       44
=======================================
  Hits          726      726
  Misses         31       31

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3005aff...79458f1. Read the comment docs.


Add db connection timeout

Fix for https://github.com/CartoDB/cartodb/issues/13266
We currently have 2 ways to connect to the user database, depending on the model:

Old User uses Sequel, which has a 20s timeout by default
Carto::User uses AR, which throws a timeout after 2 minutes or so.

In production we already have the connect_timeout configuration in database.yml set to 2.5s, but unused for user databases, and Tonino thinks it's a good value for this.
So the fix is to take that connect_timeout and initialize with it both Sequel and AR connections.

retest this please

Working like a charm, ready to deploy


Does it work for scanned PDF's ?

Unable to match all required fields. The required fields are: ['date', 'amount', 'invoice_number', 'issuer']. Output contains the following fields: ['date', 'currency', 'issuer'].
My template:
[InvoiceTemplate([('issuer', 'Honeywell Int. SDN. BHD'),                   ('keywords', ['Honeywell']),                   ('fields',                    OrderedDict([('date',                                  'DATE OF TASK\\n(\\d{2}-\\w{A-Z}\\d{2})')])),                   ('options', OrderedDict([('remove_whitespace', True)])),                   ('template_name', 'sing.gb.airline.yml'),                   ('exclude_keywords', [])])]
Could Anyone Please Help to fix my issue! Thank you.

can you share your input file and template?


Fix flaky test

Randomized with seed 47487

  1) Event User Relationship Event Destructions Event should be deleted when Relationship is deleted
     Failure/Error: let(:relationship_followed) { create(:relationship, followed: user) }

     ActiveRecord::RecordInvalid:
       Validation failed: Follower has already been taken
     # ./spec/models/event_spec.rb:118:in `block (3 levels) in <top (required)>'
     # ./spec/models/event_spec.rb:131:in `block (3 levels) in <top (required)>'

This was fixed in #755.


fix bug: error type for BufferBuilder

Which issue does this PR close?

Closes #1103
Rationale for this change

What changes are included in this PR?

Are there any user-facing changes?

Codecov Report

Merging #1104 (ed92e06) into master (78de3ab) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #1104   +/-   ##
=======================================
  Coverage   82.32%   82.33%
=======================================
  Files         168      169    +1
  Lines       49436    49462   +26
=======================================
+ Hits        40698    40724   +26
  Misses       8738     8738

Impacted Files
Coverage Δ

arrow/src/array/mod.rs
100.00% <100.00%> (ø)

arrow/src/array/transform/mod.rs
84.86% <0.00%> (-0.14%)
:arrow_down:

arrow/src/datatypes/datatype.rs
66.80% <0.00%> (+0.42%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 78de3ab...ed92e06. Read the comment docs.

@alamb  PTAL

@alamb  PTAL

This change looks fine to me but I don't fully understand the need for it. Is there any behavior change after the changes in this PR?
Or put another way, is there something you plan to do that you can't do without the changes in this PR?

If we use the original code, I can't create a  TimestampSecondBufferBuilder.
I think it's an error or bug.

This change looks fine to me but I don't fully understand the need for it. Is there any behavior change after the changes in this PR?
Or put another way, is there something you plan to do that you can't do without the changes in this PR?

If we use the original code, I can't create a  TimestampSecondBufferBuilder.
I think it's an error or bug.

We will meet the error If we don't do these changes.
error[E0599]: the function or associated item `new` exists for struct `builder::BufferBuilder<datatypes::types::TimestampSecondType>`, but its trait bounds were not satisfied
   --> arrow/src/array/mod.rs:507:39
    |
507 |         TimestampSecondBufferBuilder::new(10);
    |                                       ^^^ function or associated item cannot be called on `builder::BufferBuilder<datatypes::types::TimestampSecondType>` due to unsatisfied trait bounds
    |
   ::: arrow/src/array/builder.rs:83:1
    |
83  | pub struct BufferBuilder<T: ArrowNativeType> {
    | -------------------------------------------- function or associated item `new` not found for this
    |
   ::: arrow/src/datatypes/types.rs:32:9
    |
32  |         pub struct $name {}
    |         ---------------- doesn't satisfy `_: native::ArrowNativeType`
    |
    = note: the following trait bounds were not satisfied:
            `datatypes::types::TimestampSecondType: native::ArrowNativeType`
note: the following trait must be implemented
   --> arrow/src/datatypes/native.rs:31:1
    |
31  | / pub trait ArrowNativeType:
32  | |     std::fmt::Debug
33  | |     + Send
34  | |     + Sync
...   |
75  | |     }
76  | | }
    | |_^

@alamb

We will meet the error If we don't do these changes.
error[E0599]: the function or associated item `new` exists for struct `builder::BufferBuilder<datatypes::types::TimestampSecondType>`, but its trait bounds were not satisfied
   --> arrow/src/array/mod.rs:507:39
    |
507 |         TimestampSecondBufferBuilder::new(10);
    |                                       ^^^ function or associated item cannot be called on `builder::BufferBuilder<datatypes::types::TimestampSecondType>` due to unsatisfied trait bounds
    |
   ::: arrow/src/array/builder.rs:83:1
    |
83  | pub struct BufferBuilder<T: ArrowNativeType> {
    | -------------------------------------------- function or associated item `new` not found for this
    |
   ::: arrow/src/datatypes/types.rs:32:9
    |
32  |         pub struct $name {}
    |         ---------------- doesn't satisfy `_: native::ArrowNativeType`
    |
    = note: the following trait bounds were not satisfied:
            `datatypes::types::TimestampSecondType: native::ArrowNativeType`
note: the following trait must be implemented
   --> arrow/src/datatypes/native.rs:31:1
    |
31  | / pub trait ArrowNativeType:
32  | |     std::fmt::Debug
33  | |     + Send
34  | |     + Sync
...   |
75  | |     }
76  | | }
    | |_^

@alamb

Thanks for your review.


casting Moya Error to NSError in .Falilure case causes Switch to be non-exhaustive

Moya has it's own Error type. When you try to cast it to NSError inside .Failure case, switch suddenly becomes non-exhaustive forcing you to add:
default:
    break

The problem looks like Moya vends its own Error type. It's an ErrorType so every cast to NSError will succeed, but I suspect the Swift compiler is getting confused. Try this:
case .Failure(let error):
    let nsError = error as NSError

Let me know :+1:

Hey @lkuczborski! Thanks for reporting the issue! 🎉
Although Moya's Error inherits from ErrorType and NSError also inherits from ErrorType, the cast from one to another is done by some bridging, because they aren't really connected other than the ErrorType protocol. So when you cast from Moya.Error to NSError, you get some really basic info and the associated type is gone. I'm guessing that the compiler is just confused, and it could be a bug, but I can't tell for sure. For now you can use Moya.Error property nsError. It might be removed in a future so you could copy the code and make your own extension instead.

@ashfurrow This causes associated type to be gone and only basic info is preserved, just like @sunshinejr said. Making my own extension to be future safe seems like a good idea, thanks!

Glad I could help! ✌


Updated from Hybrid Cloud to Universal Print

@JohanFreelancer9 - kindly do the copy editor review for this PR. Thanks

@ChristopherTulip Please incorporate the feedback. Thanks

@jaimeo Please merge this PR. Thanks.


Clear selected activity on record load

If you select an activity, then change contact or opportunity records, the same selected contact is showing. Add triggers to clear the selected value on record change.

Looks like you did this for Contacts. Add similar OnRecordLoad trigger that clears selector's ActivityID for Opportunities.


Non liinear follow up  issue

Issues
{{if eq(slots.slotname.value 'major')}} you are major {{/if}}
{{if eq(slots.slotname.value 'minor')}} you are minor {{/if}}
When i try to use this things in response , I am not getting the expected result ...
How to handle it .

that's not valid handlebars I don't think. You would create two responses, each with one line of the below in it:
{{#eq slots.slotname.value 'major'}} you are major {{/eq}}

and a second response like:
{{#eq slots.slotname.value 'minor'}} you are minor {{/eq}}

For more handlebars info look here: https://blog.spg.ai/a-bot-with-a-handlebar-mustache-6b2e74edc241

Closed due to inactivity. Please re open in case you need help


chore(CHANGELOG): update to v3.16.0

@marstamm beat me to it 😅 https://github.com/bpmn-io/properties-panel/commit/28c7b1f83aabd587a272193ffa39b0a333b49804


Azure Pipelines: Upload Timed Out. Unsure if deployment was successful or not.

Describe the bug

Sometimes (and it is sporadic) the Azure Pipelines Static Web App task fails with the AzureStaticWebApp@0 task
Zipping App Artifacts
App Zip will be created from directory: /e118baeb-8efb-4c9d-bd5e-6accf74a822a-swa-oryx/app/dist
Done Zipping App Artifacts
Uploading build artifacts.
Finished Upload. Polling on deployment.
Status: InProgress. Time: 0.0298873(s)
Status: InProgress. Time: 15.0635654(s)
Status: InProgress. Time: 30.7737882(s)
Status: InProgress. Time: 47.7504889(s)
Status: InProgress. Time: 62.8368332(s)
Status: InProgress. Time: 78.0058851(s)
Status: InProgress. Time: 93.0384401(s)
Status: InProgress. Time:<PHONE_NUMBER>(s)
Status: InProgress. Time:<PHONE_NUMBER>(s)
Status: InProgress. Time:<PHONE_NUMBER>(s)
Status: InProgress. Time:<PHONE_NUMBER>(s)
Status: InProgress. Time:<PHONE_NUMBER>(s)
Status: InProgress. Time:<PHONE_NUMBER>(s)
Status: InProgress. Time:<PHONE_NUMBER>(s)
Status: InProgress. Time:<PHONE_NUMBER>(s)
Status: InProgress. Time:<PHONE_NUMBER>(s)
Upload Timed Out. Unsure if deployment was successful or not.

For further information, please visit the Azure Static Web Apps documentation at https://docs.microsoft.com/en-us/azure/static-web-apps/
If you believe this behavior is unexpected, please raise a GitHub issue at https://github.com/azure/static-web-apps/issues/
Exiting
##[error]Error: The process '/usr/bin/bash' failed with exit code 1

To Reproduce
Steps to reproduce the behavior:
Run a deployment that deploys the static web app in Azure Pipelines using the AzureStaticWebApp@0 task

Expected behavior
No deployment failure
Screenshots

Additional context
Add any other context about the problem here.

I'm having the same issue

Hi. More information would allow more accurate assistance. Generally, this happens if you didn't create a production build (npm run build), then set the app location to the output folder (e.g., dist). The timeout usually happens when you attempt to deploy your root/source folder

I also have this issue and can provide some additional context:
I successfully deployed the app the first time via an ADO Pipeline. Unlike Johnny, I pulled my site from an artifact store and published that, instead of building within the AzureStaticWebApp@0 step. Just app, no API.

With no other changes, the next time I went to deploy, it timed out as @johnnyreilly noted (effectively same screenshot). Here is my configuration, which again, worked for the first time, but fails on the second:

Azure reports the website's status as 'Failed', but won't provide any further details, so I can't determine what exactly the error is.

Despite the job saying it uploaded everything, the website itself shows the old code, so my assumption is that either the upload didn't actually happen or something else failed and Azure rolled back the files.

Update: A later deployment did succeed, so this issue seems random/intermittent


Design choice between upgradeable and regular deploys

As part of #802, we need to define how a user will choose whether a new contract will be upgradeable or not.

My thoughts on this:
Asking on project initialization, as @frangio had mentioned, may not be a good idea, since we may be dropping the need for oz init altogether in v3. Also, the choice seems to be tied to the network where the user is working, so it does not make sense to ask for a project-wide default.
With that in mind, I'd ask the user upon oz deploy. However, there are a few decisions to make:
Upgradeable Yes/No vs Regular/Upgradeable/Minimal
We can ask the user whether they want the deploy to be upgradeable or not (a Y/N question), or on kind of deployment (regular, upgradeable, minimalproxy). While the first is more straightforward, the second can help making the minimal proxy more available. We can think of rephrasing it to "repeatable" or "multiple" deploy, instead of "minimal".
Ask again vs Require flag to change
After the user has chosen the kind of deployment (for a specific network), we can either 1) keep asking the same question on every deploy (though defaulting to the last answer, as we do with networks), or 2) assume that all contracts in the same network will have the same deployment kind, and require a flag to override.
Given that users that work with interactivity may not be familiar with the flags, I'd go with (1), even if we are making the creation process a bit more complex (though defaulting to last answer should ameliorate this).
Network vs Network & Contract
While we should ask after the choice of network (so we can tie the decision to the network), we can ask before or after the choice of contract to deploy. This depends on whether we think if a user will want to have regular and upgradeable contracts on the same project and the same network (which we know is the case for some complex projects).
This would impact on the criteria for choosing the default (or assumed, depending on the previous section) deployment kind. We would need to store the last deployment choice per network & contract, as well as the last choice for the network overall (to use as a default for contracts deployed for the first time in that network), or the last choice for the contract overall (to use as a default for a deployment of that contract in a new network).
Here I'd just remember the last choice per-network, as it's easier to implement, and probably easier for the user to grasp the criteria.

I agree on asking for "kind" rather than yes/no. I'm not sure about using "multiple" for "minimal", because I think people are already familiar with the "minimal proxy" name (are they?); perhaps we can put it in parentheses or something.
I think there is ambiguity in the term "default", we use it in opposite ways. To me, a parameter having a default value means that we won't interactively ask about it, and the only way to change it is via CLI flags, such as --verbose. The other meaning for default I would call a "preselection" during the interactive flow. It's really important not to confuse these two things, particularly because we have --no-interactive, and our choice for a preselection is probably not the same as a choice for default behavior!
There may also be cases where we want a default behavior if interactivity is disabled, but we do want to ask if in the interactive flow. There's certainly cases like this in the current CLI design, but I would try to keep them to a minimum for simplicity. What do you think? I can think of sessions and I think also the --from option is in this category? I'm not sure how I feel about these cases.
My intuition is that defaults should never change dynamically, unless the user asks for it explicitly (e.g., if the options are "yes/no/always"). The reasoning is that we want the tool to behave predictably without a complex mental model. Arguably, preselections also harm predictability, but only for pressing Enter through the interactive prompts, which I think is a good trade-off for when this does come in handy.
Based on the argument of avoiding complex mental models for tool behavior, I agree that basing the preselection only on the network and not on the contract choice is better.
What should the behavior be "kind" be for non-interactive usage of deploy? Do we want to force the user to specifiy it via a flag, or do we want it to have a default? Should it be in the category of "has a default but we ask during interactivity"?

I think there is ambiguity in the term "default", we use it in opposite ways. To me, a parameter having a default value means that we won't interactively ask about it, and the only way to change it is via CLI flags, such as --verbose. The other meaning for default I would call a "preselection" during the interactive flow. It's really important not to confuse these two things, particularly because we have --no-interactive, and our choice for a preselection is probably not the same as a choice for default behavior!

Good point. I was talking about defaults in the sense of preselection, but I like your definitions more.

What should the behavior of "kind" be for non-interactive usage of deploy? Do we want to force the user to specifiy it via a flag, or do we want it to have a default? Should it be in the category of "has a default but we ask during interactivity"?

It's a good question. I think I'd always require it, even if it's a PITA - but it's a very critical setting to just assume. WDYT?

Yeah, I also think we should require it.

This has been implemented as agreed on the comments above in the new oz deploy command that will be released in 2.8.


Update docs dependencies

Update the docs dependencies to match the Pipfile.lock
Fix an issue that the CLI docs can't be displayed.

Looks good to me. Let's see if it solves our issue.


Add Action Summary (home) and Alert (other pages)

Work so far:

Add an Action Summary section to TSS home page
Add a Action Summary Alert to be displayed on all pages except Home and MFA (when NOMFA ) with text indicating outstanding action (CoJ) or other important Form R submission-related info.
Minimise TSS Header on mobile so you can at least see the Action Summary header

Note: The Action Summary Alert state management (mainly around the Form R lists) is a bit messy so will most probably create a follow-up ticket to refactor this.
TIS21-5400
TIS21-5508
TODO
Once this is merged, Tosin will add the Hotjar surveys to the CoJ and Form R confirm pages https://hee-tis.atlassian.net/browse/TIS21-5514

Perhaps not a priority edge-case to deal with, but if the forms service is down, the messaging is a little misleading:

The SonarCloud stuff seems irrelevant (applies to existing code). I haven't checked the code coverage on the tests.

Perhaps not a priority edge-case to deal with, but if the forms service is down, the messaging is a little misleading:

Yup, not great UX . As discussed, will tackle this in a follow-up ticket (which includes other similar instances e.g. a forms service failure on forms list page).

Nothing in the PR comments that can't be picked up in the future, if they apply at all. 🤞

Will just sort the working-related 'quick fixes' now.

so much for the quickness of the fixes!


local resolver args null

I'm trying to implement local resolvers with  "apollo-client": "^2.6.10" and "vue-apollo": "^3.0.4".
Problem: Local resolver don't get args object (is always null) (in this case args.id is expected to be present).
The other parameters parent, context, info are all provided
How I try it:
// schema.js

const gql = require('graphql-tag')

export default gql`

  extend type Query {
    userTest(id: ID!): User
  }

  type UserTest {
    id: ID!
    name: String!
  }

`

// actions.js

import gql from 'graphql-tag'

const GET = gql`
  query userTest ($id: ID!) {
    userTest @client (
      id: $id
    ){
      id
      name
    }
  }
`
export default {
  GET
}

// resolver.js

export default {

  Query: {
    userTest (parent, args, context, info) {
      console.log(args) // null
      return {
        id: 'test',
        name: 'Martin',
        __typename: 'UserTest'
      }
    }
 }
}

Putting it together:
// main.js

import schema from './schema.js'
import resolver from './resolver.js'

.
.
.

// Create the apollo client
const apolloClient = new ApolloClient({
  link: links,
  cache,
  typeDefs: [schema],
  resolvers: [resolver]
})

// Create provider for apollo
const apolloProvider = new VueApollo({
  defaultClient: apolloClient
})

// Add apollo to Vue
Vue.use(VueApollo)

.
.
.

request the information:
// AppUser.vue

<script>

import actions from './actions.js'

export default {
  name: 'AppUser',
  components: { . . . },
  data () {
    return {
      id: 'UserTest_bbac9679-3342-4836-8500-999838b19b59'
    }
  },
  apollo: {
    userTest: {
      query: actions.GET,
      variables () {
        return {
          id: this.id
        }
      }
    }
  }
}
</script>

Any idea what I'm doing wrong?

Important note: This refers to<EMAIL_ADDRESS>Ok. I put my non existent apollo-client-internals knowledge to the test and stumbled over this:
// storeUtils.ts

export function argumentsObjectFromField(
  field: FieldNode | DirectiveNode,
  variables?: Record<string, any>,
): Object | null {
  if (field.arguments && field.arguments.length) {
    const argObj: Object = {};
    field.arguments.forEach(({ name, value }) =>
      valueToObjectRepresentation(argObj, name, value, variables),
    );
    return argObj;
  }
  return null;
}

This function returns null instead of the expected args object.
The variables object provided to this function looks like this:
{id: "UserTest_bbac9679-3342-4836-8500-999838b19b59"}
The field object provided to this function looks like this:
{
  "kind": "Field",
  "name": {
    "kind": "Name",
    "value": "userTest"
  },
  "arguments": [],
  "directives": [
    {
      "kind": "Directive",
      "name": {
        "kind": "Name",
        "value": "client"
      },
      "arguments": [
        {
          "kind": "Argument",
          "name": {
            "kind": "Name",
            "value": "id"
          },
          "value": {
            "kind": "Variable",
            "name": {
              "kind": "Name",
              "value": "id"
            }
          }
        }
      ]
    }
  ],
  "selectionSet": {
    "kind": "SelectionSet",
    "selections": [
      {
        "kind": "Field",
        "name": {
          "kind": "Name",
          "value": "id"
        },
        "arguments": [],
        "directives": []
      },
      {
        "kind": "Field",
        "name": {
          "kind": "Name",
          "value": "name"
        },
        "arguments": [],
        "directives": []
      },
      {
        "kind": "Field",
        "name": {
          "kind": "Name",
          "value": "__typename"
        }
      }
    ]
  }
}

The function expects field.arguments to be not empty, or it returns null.
Why field.arguments is empty is beyond my knowledge.
Maybe a incompatibility cause I use the unsupported apollo-client version 3 (although I have the same behavior as with apollo-client 2.6.1)?

Local state resolver was deprecated since 3.x, it's better to use https://www.apollographql.com/docs/react/local-state/managing-state-with-field-policies. As I know vue-apollo is still not supporting 3.x version.

Hey, thanks for your reply!

Local state resolver was deprecated since 3.x,

That's true,but they still work and "deprecation and removal is still a ways off" (source).
Plus, I have the same behavior with apollo-client 2.6.1 (args field is null)...

@MarMun arguments is about the other things, it's the arguments of the directives (like @export('somearg') will return 'somearg'). Look into the source code: https://github.com/apollographql/apollo-client/blob/ec5c2edf3631ce93200585d9dcc2a3a2086c353f/src/utilities/graphql/storeUtils.ts#L237

Ah, I got it... it's when you are passing arguments to the field, not a variables to a query or a mutation. So it's local arguments, not global variables.


Fix decoding of pointer of empty interface type

fix #129

Codecov Report

Merging #131 (e917f04) into master (336ad14) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #131      +/-   ##
==========================================
- Coverage   74.84%   74.84%   -0.01%
==========================================
  Files          42       42
  Lines       38345    38345
==========================================
- Hits        28700    28698       -2
- Misses       8690     8691       +1
- Partials      955      956       +1


[#6253] Potential NPE in AgentDirectory

Codecov Report

Merging #6278 into master will decrease coverage by <.01%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master    #6278      +/-   ##
==========================================
- Coverage   39.57%   39.57%   -0.01%
==========================================
  Files        3059     3059
  Lines       91381    91388       +7
  Branches    11843    11845       +2
==========================================
+ Hits        36163    36165       +2
- Misses      52236    52243       +7
+ Partials     2982     2980       -2

Impacted Files
Coverage Δ

...m/navercorp/pinpoint/bootstrap/PropertyLoader.java
0% <0%> (ø)
:arrow_up:

...rp/pinpoint/bootstrap/agentdir/AgentDirectory.java
38.63% <0%> (-4.96%)
:arrow_down:

...vercorp/pinpoint/rpc/packet/ServerClosePacket.java
52% <0%> (-16%)
:arrow_down:

...rp/pinpoint/rpc/server/PinpointServerAcceptor.java
84.1% <0%> (-4.64%)
:arrow_down:

...point/rpc/client/DefaultPinpointClientHandler.java
71.75% <0%> (-0.33%)
:arrow_down:

...navercorp/pinpoint/rpc/common/SocketStateCode.java
85.36% <0%> (+2.43%)
:arrow_up:

...tor/metric/datasource/DefaultDataSourceMetric.java
78.12% <0%> (+3.12%)
:arrow_up:

...rc/main/java/com/navercorp/pinpoint/test/Item.java
73.33% <0%> (+10%)
:arrow_up:

...p/pinpoint/rpc/client/WriteFailFutureListener.java
75% <0%> (+18.75%)
:arrow_up:

...pinpoint/rpc/ChannelWriteFailListenableFuture.java
71.42% <0%> (+28.57%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a5acdf3...a91e2db. Read the comment docs.


Refactor build specs

This PR separates the Build and List_revdeps jobs into two modules, sharing code by a functor for both local_build.ml and cluster_build.ml.
Other little bits of refactoring are done.

This PR causes all jobs to succeed without actually doing anything.  See https://github.com/ocaml/infrastructure/issues/110.

Closing with the change pushed to the refactor-build branch (https://github.com/ocurrent/opam-repo-ci/tree/refactor-build).


transcription repressor activity

Please see attached file,
Ruth
Reported by: RLovering
Original Ticket: geneontology/ontology-requests/8782

Hi Ruth,
I am pretty sure that with the renaming of the transcription regulatory MF terms, the distinct transcription repressor terms are now in GO and they are logically defined.
-D


failed to synthesize reported at the beginning of a file

Prerequisites
Please put an X between the brackets as you perform the following steps:

[x] Check that your issue is not already filed:
https://github.com/leanprover/lean4/issues
[x] Reduce the issue to a minimal, self-contained, reproducible test case.
Avoid dependencies to Mathlib or Batteries.
[x] Test your test case against the latest nightly release, for example on
https://live.lean-lang.org/#project=lean-nightly
(You can also use the settings there to switch to “Lean nightly”)

Description
Sometimes, when the auto-filled in by infer_instance parameter fails to find an instance, it reports the error at the beginning of the file, instead of where the failure happened.
Context
Reported on the Lean Zulip.
Steps to Reproduce
Run this code:
  -- <-- `failed to synthesize A` here
class A

structure B where
  h1 : A := by infer_instance
-- using `inferInstance` instead of `by infer_instance` reports the
-- `failed to synthesize A` and the diagnostic comment here
-- not on the `example` below

example : B where

Expected behavior: The error should highlight example.
Actual behavior: The error highlights the beginning of the file.
Versions
[Output of #eval Lean.versionString]
"4.10.0-rc2"
for both the online server and my own computer.
[OS version, if not using live.lean-lang.org.]
Linux Mint
Additional Information
[Additional information, configuration or data that might be necessary to reproduce the issue]
Impact
Add :+1: to issues you consider important. If others are impacted by this issue, please ask them to add :+1: to it.

Could you clarify what you expect when it is := inferInstance? In that case, the error is on inferInstance, but that's because the original inferInstance fails to elaborate and the default value for B.h1 becomes sorry.

Looking again at this, I am not sure what I would expect with inferInstance.  It seems that
class A

structure B where
  h1 : A := inferInstance

is already an error, so this is unrelated to the presence of the example.
So, the only issue here, from my perspective, is the reporting of the error at the beginning of the file, rather that on example when the default value is set to by infer_instance.


Deprecation notice added

It was decided at a GA4GH meeting to deprecate future work in this repository, and make it clear to users that this is the case.

More explanation needed, please.

Hi @heuermh; following the GA4GH plenary meeting in Orlando the project has been reorganised into work streams and driver projects, which supersede & replace the task teams. Being part of the 'old' metadata task team I know that we will still produce a data model, but I don't think the reference implementation will be maintained for example. Also as you can see above the current build in this repository is failing. The new GA4GH website is at https://www.ga4gh.org and hopefully provides more info.

I find it interesting the htsget also implements its own schemas based on BAM fields, when it seems this project would have been a great example for the use of ga4gh-schemas. Any thoughts on why they developed new schemas? This is proof that there is still a need for these.

Github has recently implemented a new feature to archive a repo and make it read-only. Perhaps it is time to use the new feature here?

Perhaps it is time to use the new feature here?

No, I don't believe that would be appropriate.  Even though GA4GH the organization has deprecated future work in this repository, that should not prevent the greater community from doing so (Github reports 117 forks currently).

Archiving only makes this repo read-only, not the forks. In addition, you can still fork archived repos.

I don't see anything wrong with adding a deprecation notice and referencing new projects or efforts.
Archiving the repository however is an act of aggression against the community -- what is wrong with continuing to allow issues to be created and discussed?  pull requests to be considered and merged?
If the current build is in a sorry state, perhaps GA4GH members who did not attend the plenary meeting and weren't part of the deprecation conversation or even non-GA4GH contributors might be willing to help make it right?
https://www.youtube.com/watch?v=OT5mqWKirhI

@heuermh I'm neutral on locking vs. plastering deprecation notes all over the repo.
However, regarding the "pick up & make it work": The problem wasn't the ability/willingness of people to contribute, but rather the existence of independent fiefdoms with different levels of activity (i.e. ~0 for variants after first definitions...), but then interdependencies. I cannot easily convey my frustrating experiences, seeing code after-monthlong-discussions-and-acceptance getting reverted later, due to nobody moving "essential" server code forward.
I had made it explicit that I see the schema fulfilling the role of "glue" keeping different projects/parts of GA4GH together.
However, without an actively guiding hand managing code advancements, I have learned to appreciate the modular approach, where different areas of the schema are managed quasi independently, but with cross-participation. So if there are time stamps in Un*x time somewhere - whatever.
Therefore: I wish for a consistent GA4GH schema in spirit, but see the current "disassemble but talk to each other" approach as a way forward. And sure, with some, limited, effort, one can easily build a coherent + working + better schema than the remnants you see; but it is about uptake through participation (which makes this option a no-go).
Just IMO...


Instancing

Description
Enables instancing in the drawIndexedPrimitives(...)  by adding instanceCount and baseInstance parameters when drawing submesh.

Added the Instanced class that inverts the relationship between a Mesh and the Instance's that share that Mesh.
Added the MTLBuffer transformsBuffer that contains all of the Instance transforms.
Added the MTLBuffer instancedOffsetsBuffer that contains all of the offsets into the transformsBuffer that can be accessed by the GPU inside the vertex shader.

Fixes #1
Type of change

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

Checklist:

[ ] My code follows the style guidelines of this project
[ ] I have performed a self-review of my code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes
[ ] Any dependent changes have been merged and published in downstream modules

Closing this PR as this was the base of https://github.com/codefiesta/VimKit/pull/14


Question about Computation of LambdaRank Gradient

Hi,
For the computation of delta NDCG for LambdaRank gradient in: https://github.com/microsoft/LightGBM/blob/master/src/objective/rank_objective.hpp#L139
Shouldn't it be:
const double dcg_gap = fabs(high_label_gain - low_label_gain);
?
That the dcg_gap should take the abs value?
Thx

It is always the non-negative values, fabs is not needed.

Sorry I don't get it.
Given label_gain_ = 0,1,3,7,15,31,63,...,2^30-1 from https://lightgbm.readthedocs.io/en/latest/Parameters.html#label_gain,
if
high_label = 0, low_label=1,
then
dcg_gap = high_label_gain - low_label_gain = 0 - 1= = -1 <0, right?

Aha, sorry I miss this
if (high_label <= low_label || low_score == kMinScore) { continue; }
Not more questions.
Thx


Using with angular 1.5 throws errors.

When using with angular 1.5, the error :
Error: [orderBy:notarray] http://errors.angularjs.org/1.5.0/orderBy/notarray?p0=%7B%7D
is thrown.

A little bit of code or a fiddle would be helpful.
I am currently using gridster with angular 1.5 but do not get any exceptions.


Disable round corners

Is there an easy way to disable round corners?

I'm following the Material Design spec for Chips, so I'm afraid not: https://material.google.com/components/chips.html

I think you can override chip.xml layout as you want.


Fix duplicated xmlns in IE 11

XMLSerializer in IE 11 automatically set the SVG namespace, therefore, created SVG file with xmlns declared twice, which is then detected as invalid in IE 11.

Thank you for this, I hope to look at it soon.  Have you verified it still works in other browsers?

I have tested the modification to work in Chrome, Firefox and Edge and IE11.

Hi @7Pass, I've merged this, made a few changes, and published as 0.9.0.  Thank you again for the PR.


Arabic support

First, let me thank you for such great project. It really looks promising.
I see that you use StanfordCoreNLP which apparently supports Arabic. Does this mean that WiseOwl can handle Arabic Q&A? If yes, can you please let me know what is needed it to make it work for Arabic?
Thanks again!

I am glad that you liked it.
We are currently using Stanford English models only. It is possible to port it to support Arabic Language. But it would require few models to be trained. Including Stanford Models for Arabic you can use one provided by Stanford.. You will have to train a model for answer type classification using Apache openNLP (MaxEnt). I am not sure if solr is able to index arabic text.

Thank you so much for your reply. Solr can index Arabic without problems. Is there any guide or tutorial on how to train a model using OpenNLP? That would make things easier for me.
Thanks again for sharing your great project with us.

I suggest you start from the documentation of OpenNLP at:
https://opennlp.apache.org/documentation/1.7.2/manual/opennlp.html
Focus on training part of the code it should be easy to get.
Your major task would be to find a dataset of questions with corresponding answer types.
We used a very simple version taken from Taming Text. You can find out more about it at chapter 8 of taming text.
If you are not able to find the corpus, you can generate your own but make sure you have enough questions so that it may perform well.

Thanks a million for your support and for guiding me to the right direction. I appreciate it.
I will try to get the dataset first for Arabic and see how it goes.
Thanks again!

Let me know if you need further help and tell me you are able to obtain a dataset for it.

Hi @asmehra95 :
When I ran this code this.numDocuments = (int) dfCounter.getCount("all");
It always return 0, is that correct ?
Thanks.


Create Sanchitc05.md

Added my unmerged PRs, did all the necessary work, and resolved all the reviews.

https://github.com/Harshdev098/Research-Nexas/pull/357 level 3
https://github.com/Amna-Hassan04/Serenity-Guide/pull/209 level1
https://github.com/Tejashri-Taral/TrendTrove-Ecommerce/pull/797 closed so no points
https://github.com/UppuluriKalyani/ML-Nexus/pull/859 it is on progress the pa will merge it soon
https://github.com/AlfiyaSiddique/TastyTrails/pull/444 level 2


[bug] no-missing-component-display-name not work with early return component

Describe the bug
The following code should not report an error
import { forwardRef, ReactNode } from 'react';

interface Props {
  children?: ReactNode;
}
export type Ref = HTMLButtonElement;

const FancyButton = forwardRef<Ref, Props>((props, ref) => {
  // It's works without this
  if (!props.children) return null;
  return (
    <button ref={ref} className="MyClassName" type="button">
      {props.children}
      hell
    </button>
  );
});

FancyButton.displayName = 'FancyButton';

export default function App() {
  return <FancyButton />;
}

/home/projects/vitejs-vite-bngjjk/src/app.tsx
  8:44  warning  no missing display name  @eslint-react/react/no-missing-component-display-name

✖ 1 problem (0 errors, 1 warning)

Reproduction
https://stackblitz.com/edit/vitejs-vite-bngjjk?file=src%2Fapp.tsx
Expected behavior
No response
Platform and versions
In stackblitz with "@eslint-react/eslint-plugin": "^0.8.9"

Stack trace
No response
Additional context
No response

Thanks for the reproduction, I'll add it to the test cases to prevent it from coming up again.


Error message on asp.net core console app

Failure to fill out this information will result in this issue being closed.
If you are creating an issue for a BUG please fill out this information. If you are asking a question or requesting a feature you can delete the sections below.
If you post a full stack trace in a bug it will be closed, please post it to http://gist.github.com and then post the link here.
Bug Information
Version Number of Plugin: 3.1.1
Device Tested On: Windows7
Simulator Tested On: NetCore console app
Version of VS: 15.8.2
Version of Xamarin:integrated with VS
Versions of other things you are using:
Steps to reproduce the Behavior
1- Create a new ASP.NET Core console app
2- Add nuget Xam.Plugins.Settings
3- At the ver start run: Plugin.Settings.CrossSettings.Current.OpenAppSettings();
Expected Behavior
No error message
Actual Behavior
Exception thrown:
This functionality is not implemented in the portable version of this assembly.  You should reference the NuGet package from your main application project in order to reference the platform-specific implementation.'
Code snippet
Plugin.Settings.CrossSettings.Current.OpenAppSettings();
Screenshots

Asp.net core you need the 4.0 beta

Thanks James! sorry about the trouble!

it is my fault :) i need to update it so it isn't confusing


DRAFT: Custom data directory support

Opened to showcase initial support. Lacks system settings wiring.

Dark
Light

Here is the error output for the android apk

...libbitcoin-qt_arm64-v8a.so: qrc:/qt-project.org/imports/QtQuick/Dialogs/DefaultFileDialog.qml:45:1: module "QtQuick.Dialogs.Private" is not installed

It looks like expected considering https://github.com/bitcoin-core/gui-qml/blob/1e9981df75b559596e8f9386858ec3f147124634/src/qml/bitcoin.cpp#L55-L57

Maybe
diff --git a/build-aux/m4/bitcoin_qt.m4 b/build-aux/m4/bitcoin_qt.m4
index e12d2efa6..5b1a133c1 100644
--- a/build-aux/m4/bitcoin_qt.m4
+++ b/build-aux/m4/bitcoin_qt.m4
@@ -236,6 +236,7 @@ AC_DEFUN([BITCOIN_QT_CONFIGURE],[
         _BITCOIN_QT_CHECK_STATIC_PLUGIN([QtQuickLayoutsPlugin], [-lqml_QtQuick_Layouts_qquicklayoutsplugin])
         dnl qtquickcontrols module plugins
         _BITCOIN_QT_CHECK_STATIC_PLUGIN([QtQuick2DialogsPlugin], [-lqml_QtQuick_Dialogs_dialogplugin])
+        _BITCOIN_QT_CHECK_STATIC_PLUGIN([QtQuick2DialogsPrivatePlugin], [-lqml_QtQuick_Dialogs_Private_dialogsprivateplugin])
         _BITCOIN_QT_CHECK_STATIC_PLUGIN([QtQuickControls1Plugin], [-lqml_QtQuick_Controls_qtquickcontrolsplugin])
         _BITCOIN_QT_CHECK_STATIC_PLUGIN([QmlFolderListModelPlugin], [-lqml_Qt_labs_folderlistmodel_qmlfolderlistmodelplugin])
         _BITCOIN_QT_CHECK_STATIC_PLUGIN([QmlSettingsPlugin], [-lqml_Qt_labs_settings_qmlsettingsplugin])
diff --git a/src/qml/bitcoin.cpp b/src/qml/bitcoin.cpp
index 55a1e152d..288a88b42 100644
--- a/src/qml/bitcoin.cpp
+++ b/src/qml/bitcoin.cpp
@@ -52,9 +52,7 @@ QT_END_NAMESPACE
 Q_IMPORT_PLUGIN(QtQmlPlugin)
 Q_IMPORT_PLUGIN(QtQmlModelsPlugin)
 Q_IMPORT_PLUGIN(QtQuick2DialogsPlugin)
-#ifndef QT_QPA_PLATFORM_ANDROID
 Q_IMPORT_PLUGIN(QtQuick2DialogsPrivatePlugin)
-#endif
 Q_IMPORT_PLUGIN(QtQuick2Plugin)
 Q_IMPORT_PLUGIN(QtQuick2WindowPlugin)
 Q_IMPORT_PLUGIN(QtQuickControls1Plugin)

?

Need rebase.
When undraft? :)

rebased over main

Since we have already #390, do still we need this PR? Does @D33r-Gee need to incorporate anything from here?


DOC Fix docstring of register in PluginManager

Small fix to docstring of register method of PluginManager

Thanks @tlambert03 !


Cloudflare APO Cache Purge not working on the latest version

Confirmation

[X] My issue isn't already found on the issue tracker.
[X] I have replicated my issue using the latest version of the plugin and it is still present.

WordPress version
5.9.2
Cloudflare-WordPress version
4.8.0
PHP version
8.1
Expected result
The cache should be purged from the Cloudflare servers when we update the site content.
Actual result
While using the latest version of the plugin and APO, if we update the site content, the Cloudflare Cache isn't purged and it still shows the old content.
Steps to reproduce

Setup the latest Cloudflare Plugin on WordPress.
Enable APO settings.
Add a Page or article and get it cached on the Cloudflare Servers.
Update the article content from the WordPress dashboard and then open the URL in a private window of your browser.
You will notice that cache isn't purged from the Cloudflare and it still serving the old content.

Additional factoids
APO Cache Purging works fine when we switch the plugin to version 4.7.0
References
No response

What does https://github.com/cloudflare/Cloudflare-WordPress/blob/master/src/WordPress/Hooks.php#L351 evaluate yo for you? Does it show as APO enabled?

Similarly with https://github.com/cloudflare/Cloudflare-WordPress/blob/master/src/WordPress/Hooks.php#L365.

Hey Jacob,
Unfortunately, I am not experienced enough to understand or perform the tasks you have listed above. May you please shed some more details on the debugging process?

Hey Jacob,
Sorry to post this here but unfortunately this issue isn't fixed yet with the new release. Specially for Woocommerce Products. The products are still showing stale prices until refreshed even after updating from the WP Dashboard.
Could you please help us if anything else has to be done along with updating plugin from 4.8.1?
Ref Community Link :

What are the URLs in question that you are having issues with?
Do you have any debug logs to share? Are the covered by the hook defined at https://github.com/cloudflare/Cloudflare-WordPress/blob/master/src/WordPress/Hooks.php#L218?

Hi Jacob,
I am not a technical guy to understand the hooks or code. Bascically we are trying to change the prices of the products from WP Dashboard & when we check on the front end as an admin user - the prices change with immediate effect as the admin users are not covered under cache (bypassed it). But as a user when we try in a separate browser we will only see the old price in the Category Listing Page & when we click on the product & it opens up then the prices are correct.
When the listings page is refreshed also the price changes but not auto purged.
Below is the URL for your reference. The first product which you see - the price should be Rs. 17020 (updated 5min back) but it shows Rs. 17030 (old price)
https://www.pcstudio.in/product-category/motherboard/

Do you have APO enabled? Or any page rules that override the cache behaviour to cache everything?

We have APO Enabled with wordpress plugin installed.
Also we have few page rules as below. Few are for security & a couple for caching
By the way - with the same setup we have been running the website since almost 8 months now but only after 15th March this issue has started troubling.

thanks, i've found your requests internally and it looks like they are making it out of WordPress and into our systems. i'll chat with the cache folks about this and see what the potential issue is. by the plugin logic, it should still be purging everything (not restricting to extensions).
what is in your WordPress debug logs? it should show some HTTP requests being made for the purge calls.

for reference, there are definitely purges happening. these have been in the last 20 minutes.
www.pcstudio.in/product-category/brand/brand-msi/
www.pcstudio.in/brand/msi/feed/
www.pcstudio.in/motherboard-cpu-support/intel-lga-1700/feed/
www.pcstudio.in/product-category/motherboard/feed/
www.pcstudio.in/product-category/motherboard/feed/
www.pcstudio.in/author/vikas/
www.pcstudio.in/feed/
www.pcstudio.in/product-category/brand/brand-msi/feed/
www.pcstudio.in/product-category/motherboard/

As I can see currently the Debug.log file is empty & not been used recently from the File Manager of hosting server.
Also, you mean that there is some issue & the Cache team is working on it?
If purges are happening & then also the content updates aren't happening there seems to be some issue with the caching system or plugin.

no, there is no issue as far as i or the team can see. we're getting the purge requests (as above). are you still running v4.8.1? your debug logs should be showing the HTTP requests that are being made above.

As of now there is no debug log file which contains entries but the php error log shows below entries after enabling the debug mode.
[18-Mar-2022 07:12:52 UTC] PHP Notice:  wp_woocommerce_session_a5d241075b0435145ca346318a1d2d9a cookie cannot be set - headers already sent by /home/pcstudio/public_html/wp-cron.php on line 28 in /home/pcstudio/public_html/wp-content/plugins/woocommerce/includes/wc-core-functions.php on line 1059
[18-Mar-2022 07:12:52 UTC] PHP Notice:  ob_end_flush(): failed to send buffer of zlib output compression (0) in /home/pcstudio/public_html/wp-includes/functions.php on line 5212

the version I am seeing internally is v4.7.0. so either you’ve upgraded/downgraded or the issue isn’t related to the upgrade.

Earlier it was 4.8.0 and as per the discussion on cloudflare community I have tried downgrading the version to 4.7.0 which also didn't work.
This morning when I have seen that the issue was fixed in the latest version of plugin 4.8.1 I have again upgraded that plugin.
Are you saying the website is still on 4.7.0?

I am seeing v4.7.0 coming through in the last 30 minutes. Can you please upgrade to v4.8.1 and try updating posts again? Checking debug logs along the way for the outgoing HTTP requests?

That a prob. Currently the version installed on the dashboard is 4.8.1. Below is the screen shot for your reference.
I have tried updating the posts after the update only & then sent you the URL
I have again changed the price of same product back to original. Can you check if any logs are being made or requests for caching?

these are the last logs i can see making it to us (UTC). ~ 15m ago
2022-03-18 07:12:11 www.pcstudio.in/brand/msi/feed/
2022-03-18 07:12:11 www.pcstudio.in/brand/msi/
2022-03-18 07:12:10 www.pcstudio.in/feed/
2022-03-18 07:12:10 www.pcstudio.in/feed/atom/
2022-03-18 07:12:10 www.pcstudio.in/brand/msi/feed/
2022-03-18 07:12:10 www.pcstudio.in/
2022-03-18 07:12:10 www.pcstudio.in/brand/msi/
2022-03-18 07:12:10 www.pcstudio.in/feed/atom/
2022-03-18 07:12:10 www.pcstudio.in/brand/msi/feed/
2022-03-18 07:12:10 www.pcstudio.in/brand/msi/feed/

i'm beginning to think this is a separate issue 🤔

OMG !
Seems to be some other issue then. Do I need to raise a separate thread here on github?
Let me know the way forward.
Guess only after the last update on March 15th this started.
Also, these requests which are coming to you are from 4.7.0 or 4.8.1? Can you identify that?

the user agent does look wonky as it is sending v4.7.0 (i'll look into that separately). your pages are definitely getting purged (note the age being so low).

~ ❯ curl -svo /dev/null https://www.pcstudio.in/product-category/motherboard/

* Connection state changed (MAX_CONCURRENT_STREAMS == 256)!
< HTTP/2 200
< date: Fri, 18 Mar 2022 07:33:54 GMT
< content-type: text/html; charset=UTF-8
< cf-ray: 6edc4867aaf50c95-EWR
< age: 2
< cache-control: max-age=86400
< last-modified: Fri, 18 Mar 2022 07:16:29 GMT
< link: <https://www.pcstudio.in/wp-json/>; rel="https://api.w.org/", <https://www.pcstudio.in/wp-json/wp/v2/product_cat/18>; rel="alternate"; type="application/json"
< vary: Accept-Encoding
< cf-cache-status: HIT
< cf-apo-via: tcache
< cf-edge-cache: cache,platform=wordpress
< expect-ct: max-age=604800, report-uri="https://report-uri.cloudflare.com/cdn-cgi/beacon/expect-ct"
< x-ua-compatible: IE=edge
< report-to: {"endpoints":[{"url":"https:\/\/[a.nel.cloudflare.com](http://a.nel.cloudflare.com/)\/report\/v3?s=lKe2hRx%2F%2BNS00t5Z0SxJGVZITn0kOvaQxIHqbW0TUf4QAq2Z9cSfPdxbunXGX7ManyKIjj3wzjJzfK2gMDNgQi7eD6A1PseTycxMzy%2BSe8uXC8b8T6Jx9PeWc92DBM3IzA%3D%3D"}],"group":"cf-nel","max_age":604800}
< nel: {"success_fraction":0,"report_to":"cf-nel","max_age":604800}
< server: cloudflare
<
{ [671 bytes data]
* Connection #0 to host [www.pcstudio.in](http://www.pcstudio.in/) left intact

i would suggest you open a support ticket with Cloudflare including the details from here and that you are having issues on 4.7.0 and 4.8.x to ensure we don't go through this all over again. you can also ask the support team to pass it to the APO team who will be able to dig into this a little more too.

Thanks Jacob. I have raised a support ticket from our dashboard with a detailed summary on what's the issue and series of events which happened from last couple of days with the link of this thread as well as the community thread link.
Hoping to hear back from them soon.
We are facing this issue from last couple of days & this gives users a bad experiencen.
Let me know if you have any update on the issue which you wanted to check separately (requests coming from 4.7.0 even after update to 4.8.1)
Thanks Again
Shashikant

do you have a ticket ID? i can give the team a heads up to keep an eye on it.

Hi folks,
We released an update for our plugin. Can you please download it and give it a try?
Please let me know if you still see the issue.
Thank you.

just FYI, v4.8.2 is a no op functionality wise. I only fixed the user agent to show the current version in use.

Hi @firatcf ,
I don't think this update is working.
We have just updated the version to the latest one 4.8.2 & tried changing the prices but still it shows the old prices.
Thanks
Shashikant

Hey,
The issue seems to be fixed now I guess. The prices are getting updated now. Did you work on something or update anything on the plugin side?
Also, can you please let me know usually how much time it takes for the posts to be updated on the front end when caching is used?
Will recheck on couple of other updates & confirm you back if the issue is fixed completely
Thanks
Shashikant

Hi @shashikant-rohit ,
That's good to hear. Please let us know if you experience this issue again.
It should be within 30 seconds.

Hi @firatcf
Some time this is working & sometime not.
I have just updated few product prices and waited for alomost 25 minutes & still the product are showing old prices.
Seems like this isn't fixed temporarily or fully.
Could you please help know what's the issue and how can this be fixed permanently?
Thanks
Shashikant

@shashikant-rohit let’s take this to the support ticket. it’s no longer the issue mentioned here and it’s best served through our usual support methods. from a plug-in perspective, this is working as intended.


Add ability for navbar to scroll

Opening a new issue from #24260 to track this.
In v3, we had a complex navbar that automatically had a max-height and some scrolling for longer navs on smaller viewports. In v4, we have a ton more flexibility around the nav, but no overflow support.

Making a note—restoring the old scroll plus adding a horizontal scroller would be rad.

Duplicate of #23374.


🐛 [FirebaseDatabaseListView] _CastError

Bug report
Describe the bug
FirebaseDatabaseListView(
query: usersQuery,
itemBuilder: (_, snapshot) {
Map<String, dynamic> user = snapshot.value as Map<String, dynamic>;
      return Text('User name is ${user['name']}');
    },
  )

Trying to cast a Snapshot Im getting this issue
The following _CastError was thrown building:
type '_InternalLinkedHashMap<Object?, Object?>' is not a subtype of type 'Map<String, dynamic>' in type cast
Steps to reproduce
Steps to reproduce the behavior:

Go to '...'
'...'
See error or incorrect behavior

Expected behavior
A clear and concise description of what you expected to happen.
Sample project
Providing a minimal example project which demonstrates the bug in isolation from your main App greatly enhances the chance of a timely fix.
Please link to the public repository URL.

Additional context
Add any other context about the problem here.

Flutter doctor
Click To Expand
```
Run `flutter doctor` and paste the output below:
[✓] Flutter (Channel stable, 2.10.4, on Ubuntu 20.04.4 LTS 5.14.0-1027-oem, locale en_US.UTF-8)
[✓] Android toolchain - develop for Android devices (Android SDK version 30.0.3)
[✓] Chrome - develop for the web
[✓] Linux toolchain - develop for Linux desktop
[✓] Android Studio (version 2020.3)
[✓] Android Studio (version 4.2)
[✓] VS Code
[✓] Connected device (3 available)
[✓] HTTP Host Availability
```

Flutter dependencies
Run flutter pub deps -- --style=compact and paste the output below:
Click To Expand
Could not find a file named "pubspec.yaml" in "/home/jesus-carbon/snap/flutter/common/flutter/.pub-cache/hosted/pub.dartlang.org/firebase_core-1.14.0".

Forget it... I already solved this
It seems I have to update flutter and Dart.

Closing this as resolved.


Update zinc to 1.7.0

Updates org.scala-sbt:zinc from 1.6.1 to 1.7.0.
GitHub Release Notes - Version Diff
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Adjust future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "org.scala-sbt", artifactId = "zinc" } ]

Or, add this to slow down future updates of this dependency:
dependencyOverrides = [{
  pullRequests = { frequency = "@monthly" },
  dependency = { groupId = "org.scala-sbt", artifactId = "zinc" }
}]

labels: library-update, early-semver-minor, semver-spec-minor, commit-count:1

Closing in favor of #1845