[SPARK-34926][SQL]  PartitioningUtils.getPathFragment()  should respect partition value is null

What changes were proposed in this pull request?
When we insert data into a partition table partition with empty DataFrame. We will call PartitioningUtils.getPathFragment()
then to update this partition's metadata too.
When we insert to a partition when partition value is null, it will throw exception like
[info]   java.lang.NullPointerException:
[info]   at scala.collection.immutable.StringOps$.length$extension(StringOps.scala:51)
[info]   at scala.collection.immutable.StringOps.length(StringOps.scala:51)
[info]   at scala.collection.IndexedSeqOptimized.foreach(IndexedSeqOptimized.scala:35)
[info]   at scala.collection.IndexedSeqOptimized.foreach$(IndexedSeqOptimized.scala:33)
[info]   at scala.collection.immutable.StringOps.foreach(StringOps.scala:33)
[info]   at org.apache.spark.sql.catalyst.catalog.ExternalCatalogUtils$.escapePathName(ExternalCatalogUtils.scala:69)
[info]   at org.apache.spark.sql.catalyst.catalog.ExternalCatalogUtils$.getPartitionValueString(ExternalCatalogUtils.scala:126)
[info]   at org.apache.spark.sql.execution.datasources.PartitioningUtils$.$anonfun$getPathFragment$1(PartitioningUtils.scala:354)
[info]   at scala.collection.TraversableLike.$anonfun$map$1(TraversableLike.scala:238)
[info]   at scala.collection.Iterator.foreach(Iterator.scala:941)
[info]   at scala.collection.Iterator.foreach$(Iterator.scala:941)
[info]   at scala.collection.AbstractIterator.foreach(Iterator.scala:1429)
[info]   at scala.collection.IterableLike.foreach(IterableLike.scala:74)
[info]   at scala.collection.IterableLike.foreach$(IterableLike.scala:73)

PartitioningUtils.getPathFragment()  should support null value too
Why are the changes needed?
Fix bug
Does this PR introduce any user-facing change?
No
How was this patch tested?
Added UT

Test build #136787 has started for PR 32018 at commit 960f2c1.

ping @MaxGekk Since your pr make partition value support value as null, here I think we need to handle null value and  I meet this in https://github.com/apache/spark/pull/30057 's UT  https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/136751/testReport/

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/41370/

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/41370/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/41370/

Test build #136787 has finished for PR 32018 at commit 960f2c1.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/136787/

I am not sure that it is right fix. I guess, null should be replaced by "__HIVE_DEFAULT_PARTITION__" like:
https://github.com/apache/spark/blob/0494dc90af48ce7da0625485a4dc6917a244d580/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/ExternalCatalogUtils.scala#L122-L127

I am not sure that it is right fix. I guess, null should be replaced by "__HIVE_DEFAULT_PARTITION__" like:
https://github.com/apache/spark/blob/0494dc90af48ce7da0625485a4dc6917a244d580/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/ExternalCatalogUtils.scala#L122-L127

Looks like we should handle it in
https://github.com/apache/spark/blob/0494dc90af48ce7da0625485a4dc6917a244d580/sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/PartitioningUtils.scala#L351-L355

What confused me is that
spark-sql> CREATE TABLE t(i STRING, c string) USING PARQUET PARTITIONED BY (c);
Time taken: 2.12 seconds
spark-sql> INSERT OVERWRITE t PARTITION (c=null) VALUES ('1');
Time taken: 4.984 seconds
spark-sql> desc formatted t partition(c=null);
i	string	NULL
c	string	NULL
# Partition Information
# col_name	data_type	comment
c	string	NULL

# Detailed Partition Information
Database	default
Table	t
Partition Values	[c=null]
Location	hdfs://tl0/user/hive/warehouse/t/c=null
Serde Library	org.apache.hadoop.hive.ql.io.parquet.serde.ParquetHiveSerDe
InputFormat	org.apache.hadoop.hive.ql.io.parquet.MapredParquetInputFormat
OutputFormat	org.apache.hadoop.hive.ql.io.parquet.MapredParquetOutputFormat
Storage Properties	[path=hdfs://tl0/user/hive/warehouse/t, serialization.format=1]
Partition Parameters	{rawDataSize=-1, numFiles=1, transient_lastDdlTime=1617244501, totalSize=396, COLUMN_STATS_ACCURATE=false, numRows=-1}
Created Time	Thu Apr 01 10:35:01 SGT 2021
Last Access	UNKNOWN
Partition Statistics	396 bytes

# Storage Information
Location	hdfs://tl0/user/hive/warehouse/t
Serde Library	org.apache.hadoop.hive.ql.io.parquet.serde.ParquetHiveSerDe
InputFormat	org.apache.hadoop.hive.ql.io.parquet.MapredParquetInputFormat
OutputFormat	org.apache.hadoop.hive.ql.io.parquet.MapredParquetOutputFormat
Time taken: 0.135 seconds, Fetched 25 row(s)

The path can be c=null, for current code, which case the path will be null and which case it can be __HIVE_DEFAULT_PARTITION__?

which case the path will be null and which case it can be HIVE_DEFAULT_PARTITION?

The null partition value should be replaced to __HIVE_DEFAULT_PARTITION__ if it goes via DSv1 and external catalog (Hive  MetaStore doesn't accept null part values, and null part value in filesystem like col0=null is not compatible with other systems). v1 In-Memory catalog follows Hive external catalog as far as I know.
DSv2 impl should handle null itself. So, we shouldn't replace it by  __HIVE_DEFAULT_PARTITION__.

which case the path will be null and which case it can be HIVE_DEFAULT_PARTITION?

The null partition value should be replaced to __HIVE_DEFAULT_PARTITION__ if it goes via DSv1 and external catalog (Hive MetaStore doesn't accept null part values, and null part value in filesystem like col0=null is not compatible with other systems). v1 In-Memory catalog follows Hive external catalog as far as I know.
DSv2 impl should handle null itself. So, we shouldn't replace it by __HIVE_DEFAULT_PARTITION__.

Thanks you a lot for clarify this problem. This make me confused for a long time.

DSv2 impl should handle null itself. So, we shouldn't replace it by __HIVE_DEFAULT_PARTITION__.

I know Why I am confused, I test this in spark 3.0, this behavior has been change to keep consistence.

ping @MaxGekk Updated, current code should be ok since InsertIntoHadoopFsRelationCommand only used in DsV1 or convert from hive related command.

Test build #136816 has started for PR 32018 at commit 03325c3.

Test build #136817 has started for PR 32018 at commit 1305fe5.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/41398/

@AngersZhuuuu Can you add a test for the changes?

UT added and it from the case https://issues.apache.org/jira/browse/SPARK-24937, without current change it will failed
22:30:04.596 WARN org.apache.hadoop.util.NativeCodeLoader: Unable to load native-hadoop library for your platform... using builtin-java classes where applicable
[info] - SPARK-34926: PartitioningUtils.getPathFragment() should respect partition value is null *** FAILED *** (609 milliseconds)
[info]   java.lang.NullPointerException:
[info]   at scala.collection.immutable.StringOps$.length$extension(StringOps.scala:51)
[info]   at scala.collection.immutable.StringOps.length(StringOps.scala:51)
[info]   at scala.collection.IndexedSeqOptimized.foreach(IndexedSeqOptimized.scala:35)
[info]   at scala.collection.IndexedSeqOptimized.foreach$(IndexedSeqOptimized.scala:33)
[info]   at scala.collection.immutable.StringOps.foreach(StringOps.scala:33)
[info]   at org.apache.spark.sql.catalyst.catalog.ExternalCatalogUtils$.escapePathName(ExternalCatalogUtils.scala:69)
[info]   at org.apache.spark.sql.catalyst.catalog.ExternalCatalogUtils$.getPartitionValueString(ExternalCatalogUtils.scala:126)
[info]   at org.apache.spark.sql.execution.datasources.PartitioningUtils$.$anonfun$getPathFragment$1(PartitioningUtils.scala:354)
[info]   at scala.collection.TraversableLike.$anonfun$map$1(TraversableLike.scala:238)
[info]   at scala.collection.Iterator.foreach(Iterator.scala:941)
[info]   at scala.collection.Iterator.foreach$(Iterator.scala:941)
[info]   at scala.collection.AbstractIterator.foreach(Iterator.scala:1429)
[info]   at scala.collection.IterableLike.foreach(IterableLike.scala:74)
[info]   at scala.collection.IterableLike.foreach$(IterableLike.scala:73)

Also cc @wangyum

Test build #136821 has started for PR 32018 at commit 992001b.

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/41398/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/41398/

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/41401/

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/41401/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/41401/

Test build #136821 has finished for PR 32018 at commit 992001b.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/136821/

Test build #136816 has finished for PR 32018 at commit 03325c3.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/136816/

Test build #136817 has finished for PR 32018 at commit 1305fe5.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/136817/

LGTM, @AngersZhuuuu could you update PR's description.

DOne

GA are failing on Avro tests, for instance. And jenkins build failed on the latest commit. @AngersZhuuuu To continue with the fix, let's re-trigger tests. Also @cloud-fan could you look at this PR since you reviewed previous changes related to null part values.

jenkins, retest this, please

Test build #136841 has started for PR 32018 at commit 992001b.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/41419/

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/41419/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/41419/

+1, LGTM. Merging to master. The failed GA is a known issue.
Thank you @AngersZhuuuu, and @cloud-fan @wangyum for your review.

BTW, @AngersZhuuuu does the issue exist in 3.1/3.0/2.4? If so, please, backport the changes.

BTW, @AngersZhuuuu does the issue exist in 3.1/3.0/2.4? If so, please, backport the changes.

Need to check. I will update here after check this

Test build #136841 has finished for PR 32018 at commit 992001b.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/136841/

LGTM2

BTW, @AngersZhuuuu does the issue exist in 3.1/3.0/2.4? If so, please, backport the changes.

Checked all branch, we need to backport to branch-3.0/branch-3.1. Should I raise separated pr or you can just merge to that branchs?

Could you open separate PRs per each branch, please.

Could you open separate PRs per each branch, please.

OK, I will ping you when finish these things.


Textfield (e.g., the search bar)

I customized the M3 version of TextField to an iOS style via https://github.com/InMatrix/veggieseasons_adaptive/commit/b4d64a07d5136ba8a36b89901b79d66a535756f0. It looks pretty similar to CupertinoTextField.

Here's a demo in DartPad: https://dartpad.dev/?id=5e21d29ef2dc94ddad0a4a635679cfad


How can we help?
None
Please read and ensure the following

[X] The installer meets the above requirements

Please provide the following information
Download Page Url: https://systeminformer.sourceforge.io/nightly.php
Publisher: Winsider Seminars & Solutions, Inc.
Package Name: System Informer
Description: A free, powerful, multi-purpose tool that helps you monitor system resources, debug software and detect malware.
Package Version: 3.0.6772
Installer URL: https://github.com/winsiderss/si-builds/releases/download/3.0.6772/systeminformer-3.0.6772-setup.exe

👋 maintainer for System Informer here, I've updated System Informer to be compatible with winget and I've created two PRs, one for the release version and one for the "Canary" version of System Informer:
https://github.com/microsoft/winget-pkgs/pull/180087
https://github.com/microsoft/winget-pkgs/pull/180088
We look forward to being on the winget package repository 🎉


feat: use rollup-plugin-commonjs

As evoqued in #73 and #62

Include node_modules/rxjs/** only and add the possibility to include other commonjs dependencies manually with ng-package.json to #62 problem.

Hi @DDeis,
I really like this improvement!
I suggest the following: we have integration testing samples (in the folder integration obvious). Add a test (a service or component or whatever) to the src that

a) uses the import { map } from 'rxjs/operator/map'; syntax
b) uses the "old-fashioned"(?) import 'rxjs/add/operator/map; syntax

Then, the angular.service.ts used to demonstrate usage of the lib.externals property for the syntax in a. If possible, this test should be kept by another kind of import.
If you like, you can also create another sample, e.g. integration/sample_rxjs that demonstrates the issues you had (the motivation for the change) and the two syntax-ways of using rxjs operators (see above: a, b)

Hi @dherges, thank you for your feedbacks, I can't work on this weekend but I will update the PR follow ONG your recommandations as soon as I can and will check if 'rxjs/add/operator/*' Stills works.
Also I wanted to know what was your opinion about the knew 'commonjs' property in 'ng-package', do you think it's a proper name ? Do you think we we can include this property in 'externals' and create a new property inside for "old fashionned" symbols to have both ways to include together ?

Added sample to demonstrate the two syntax-ways of using rxjs operators as suggested.

@DDeis Hi, thanks for your effort! I will look at it.

@DDeis I made some smaller changes (tab indentation, update the description in the json schema).
However, when trying out this version in a larger project, the build errors:
BUILD ERROR
'BehaviorSubject' is not exported by ..\..\node_modules\rxjs\BehaviorSubject.js
Error: 'BehaviorSubject' is not exported by ..\..\node_modules\rxjs\BehaviorSubject.js
    at error (....\node_modules\ng-packagr\node_modules\rollup\dist\rollup.js:177:12)
    at Module.error$1 [as error] (....\node_modules\ng-packagr\node_modules\rollup\dist\rollup.js:8434:2)
    at Module.trace (....\node_modules\ng-packagr\node_modules\rollup\dist\rollup.js:8536:9)
    at ModuleScope.findDeclaration (....\node_modules\ng-packagr\node_modules\rollup\dist\rollup.js:8114:22)
    at Scope.findDeclaration (....\node_modules\ng-packagr\node_modules\rollup\dist\rollup.js:5907:39)
    at Node.bind (....\node_modules\ng-packagr\node_modules\rollup\dist\rollup.js:7165:29)
    at ....\node_modules\ng-packagr\node_modules\rollup\dist\rollup.js:5701:50
    at Node.eachChild (....\node_modules\ng-packagr\node_modules\rollup\dist\rollup.js:5718:5)
    at Node.bind (....\node_modules\ng-packagr\node_modules\rollup\dist\rollup.js:5701:7)
    at ....\node_modules\ng-packagr\node_modules\rollup\dist\rollup.js:5701:50

error Command failed with exit code 111.

Update the PR to allow specifying the path of the node_modules directory.
Would this solve the issue with monorepos ?

That still breaks existing builds w/ their current configuration. So the change is requiring people to update their config in a project where they were building rxjs dependencies just fine!
Altogether, there are two things:

rxjs and their two import styles #73
commonjs support #62

Is it possible to separate the changes for these two? One for the rxjs thing, one for the commonjs.

Right, maybe we should have two PRs to address these issues distinctively:

rxjs and their two import styles #73: adding missing rxjs dependencies
commonjs support #62: using rollup-plugin-commonjs

PR splited into:

PR #82: rxjs two import styles #73
PR #83: commonjs support #62


Fix entity name inferring for Swift classes

Swift returns classes with the full module name. This change attempts
to use the proper last portion of the full module as the entity name.
Add unit tests and new swift managed object for testing the change.

I am assuming
public func deleteAllDataWithCompletion(completion: ((NSError?) -> Void)?)

still requires declaring your managed objects as @objc? It still creates classes from the entityName.


Software Architecture

Verlinkung - Interaktion mit Issue "Choose and set up database"
Prepare a description of the planned software architecture; include
An overview diagram of runtime components (one page)
An overview diagram of code components (one page)
A summary of the underlying technology stack (one page)
A textual explanation of the diagrams and choices (one page)
Create a PDF and upload the file before class to the Deliverables folder.

To get a holistic view on the architecture, maybe have a look at the Service Blueprint :)
/https://www.nngroup.com/articles/service-blueprints-definition/

The SW architecture is done and committed. I proopse to close this and open a follow up, if we need to modify and/or extend the architecture.
/CC @joluj @IgorShmelev

Agreed, issue can be closed. The Software Architecture doc can be found in the respective "Deliverables" folder on github or in our Shared Google Drive Folder.


Does not work with my subdomain

I tried to use nativefier with a subdomain, but it hangs on this message:
"Packaging app for platform win32 x64 using electron v0.36.4"
There's something strange, because it only occurs with my website. For example, it does work with http://webpic.com.br, http://mail.google.com and http://login.yahoo.com, but doesn't with http://virgo.webpic.com.br.
Nativefier version: 6.6.1
Node version: 0.12.0
Command line: nativefier "http://virgo.webpic.com.br"
OS: Windows 8 and Windows 10

Seems this also happens on sites without subdomains, related to #87. http://digg.com/reader doesn't work for me.

Oh well... I thought it was a problem with subdomains.  :|


[WIP] test CI

Why is this PR needed?
What changes were proposed in this PR?
Does this PR introduce any user interface change?

No
Yes. (please explain the change and update document)

Is any new testcase added?

No
Yes

Build Success with Spark 2.3.4, Please check CI http://<IP_ADDRESS>:12545/job/ApacheCarbonPRBuilder2.3/4141/

Build Success with Spark 2.4.5, Please check CI http://<IP_ADDRESS>:12545/job/ApacheCarbon_PR_Builder_2.4.5/2400/


Added Xarray io deps to setup and env.yml

Description of PR
This PR updates setup.cfg and environment.yml files to reflect adding Xarray io optional dependencies and making sure env.yml is up-to-date.
Summary of changes and related issue
[What's changed in this PR?]
Relevant motivation and context
[Why did you change this and what applicable context is needed to understand why this change is needed?]
Type of change

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

Definition of Done Checklist
Practical

[ ] 80% unit test coverage
[ ] Documentation

[ ] All functions/adjusted functions documented in the readthedocs.
[ ] Documentation is pushed

[ ] Complex code commented
[ ] Naming conventions followed

[ ] Helper functions hidden with _ before the name

[ ] Context of function is clearly provided

[ ] Intent of function is provided
[ ] How to test, so that it is not siloed on scientists and anyone can review
[ ] Appropriate manual testing was completed

[ ] Any notebooks known to utilize the affected functions are still working
[ ] Linting completed and resolved

Conceptual

[ ] Doesn't replicate existing functionality
[ ] Aligns with general coding standard of existing functions
[ ] Matches desired functinonality from users/scientists

 Fix test env and ensure dependencies are there


Responsive Header

Which feature you are going to add

Describe the solution you'd like
responsive useing media query
Screenshots

@kushaljgec2025 Go ahead
Star the repo 🌟 to show your support.


Fix: ArrayAccessTrait not compatible with ArrayAccess + tests

Q
A

Is bugfix?
✔

New feature?
❌

Breaks BC?
❌

Fixed issues
-

👍


Thunderbolt EGPU

Hi have you tried if thunderbolt works with this?
https://www.tonymacx86.com/threads/in-progress-ssdt-for-thunderbolt-3-hotplug.248784/
https://www.tonymacx86.com/threads/guide-how-to-use-egpu-with-any-laptop-equipped-with-thunderbolt-3.283179/post-2010533

No I was not able to figure it out this is what I got
https://www.tonymacx86.com/threads/coffeelake-laptop-thunderbolt-3-egpu-not-working.302541/


Possible misrendering of number in description strings

Shouldn't strings like, e.g., https://github.com/wvanderp/isOsmComplete/blob/main/data/compare.json#L38 render the {{expected}} number?

You are totally right. I have fixed it in 072b44ae7e529aaeb7df13979dad2ea60672634b
I've added the {{expected}} everywhere but left the code from {{actual}} because I have a feeling I'll need it later.
Thank you for pointing it out


net-service information reading error for GraphQL

Description
Error to read host information about Graphql HTTP using curl "net_services" option.
Steps to Reproduce (Bug)

Run the BESU node as follows:

/bin/besu
--network=holesky
--p2p-port=30303
--rpc-http-port=8545
--rpc-http-enabled=true
--rpc-http-cors-origins="*"
--engine-rpc-port=8551
--max-peers=25
--rpc-http-enabled=true
--sync-mode=SNAP
--logging=INFO
--data-storage-format=BONSAI
--Xbonsai-limit-trie-logs-enabled=true
--data-path="/var/lib/besu"
--graphql-http-enabled=true
--graphql-http-host="<IP_ADDRESS>"
--graphql-http-port=8549
--engine-jwt-secret=/secrets/jwtsecret

Check the port using "netstat -tulnp".
Port for Graphql http to listen on 8549

tcp6       0      0 :::8549                 :::*                    LISTEN      2001774/java
tcp6       0      0 :::30303                :::*                    LISTEN      2001774/java
tcp6       0      0 <IP_ADDRESS>:8545          :::*                    LISTEN      2001774/java
tcp6       0      0 <IP_ADDRESS>:8551          :::*                    LISTEN      2001774/java
udp6       0      0 :::30303                :::*                                2001774/java
udp6       0      0 :::48848                :::*                                2001774/java

Run Net-Services command.

curl --location 'http://localhost:8545'
--data '{
"jsonrpc": "2.0",
"method": "net_services",
"params": [],
"id": 1
}'
Actual behavior: Graphql Host information is not present.
{"jsonrpc":"2.0","id":1,"result":{"jsonrpc":{"host":"<IP_ADDRESS>","port":"8545"},"p2p":{"host":"<IP_ADDRESS>","port":"30303"}}}
Expected behavior:
{"jsonrpc":"2.0","id":1,"result":{"jsonrpc":{"host":"<IP_ADDRESS>","port":"8545"},"p2p":{"host":"<IP_ADDRESS>","port":"30303"}, "graphql":{"host":"<IP_ADDRESS>","port":"8549"}}}
Frequency: 100%
Versions (Add all that apply)
Software version: 24.5.1
Java version: openjdk-java-17
OS Name & Version: Ubuntu 22, linux-x86_64

Hey, I am interested in this issue. Could you please assign it to me and Lavender

Sorry.
I am modifying its source code.

From: Preeti @.>
Sent: Tuesday, August 27, 2024 11:20 AM
To: hyperledger/besu @.>
Cc: ITStarMan100 @.>; Author @.>
Subject: Re: [hyperledger/besu] net-service information reading error for GraphQL (Issue #7513)
Hey, I am interested in this issue. Could you please assign it to me and Lavender
—
Reply to this email directly, view it on GitHubhttps://github.com/hyperledger/besu/issues/7513#issuecomment-2311999463, or unsubscribehttps://github.com/notifications/unsubscribe-auth/BKXJWQ5YJ6I5D7J4I5JPNL3ZTRAGLAVCNFSM6AAAAABM72ZPSWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMJRHE4TSNBWGM.
You are receiving this because you authored the thread.Message ID: @.***>

I have completed the code update for the above fix
Who should I contact after submitting a PR request?


Use single replacer for string escaping

The two-stage replacement was making non-null characters look like null chracters to the second replacer, which is no good. Now all the replacing is handled within one replacer, which also does the lookahead for potential octalyness conflicts.
Fixes #21828

By the way, I wrote this code back when we couldn't use JSON.stringify, so a decent amount of logic here could probably be replaced with the JSON.stringify + the special cases I mentioned above + str.slice(1, -1).
But that can be another PR.


Updates exception handling to use Django DatabaseError class

Addresses #142
Using Django’s DatabaseError class as the exception to catch keeps the
library and this try catch database platform agnostic. That way
developers who have a Postgres or MySQL backend should mutually benefit
from this retry.

@avelis code changes look perfect. Exactly what I was going to do. Travis-CI is complaining about that one test for the 3.4 environment. Same intermittent test that has failed for us before:
FAIL: test_time_spent_db_with_path (tests.test_view_requests.TestGetObjects)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/travis/build/django-silk/silk/project/tests/test_view_requests.py", line 98, in test_time_spent_db_with_path
    self.assertTrue(num_results)
AssertionError: 0 is not true

So I think we can ignore that. Unfortunately I'm at the car dealership right now so I only have my work laptop on me but when I get home I can test this branch against the code that was causing the error and report back.
Up to you if you want to wait for that or if you wanna just go ahead and merge. Everything looks good to me.

@hanleyhansen I have gone ahead & merged. Thanks for checking on the pull request for me.


Sign message failed in chrome extension options page with "Invalid url" error response

Instructions
In chrome extension options page. call fcl sdk to sign mesage.
Problem
The signing modal hangs.  The request "https://flow-wallet-testnet.blocto.app/bloctoWeb/meta?" failed with "Invalid url"
Steps to Reproduce

Afraid this issue needs more context as I failed to reproduce using FCL Harness on testnet. What is the chrome extensions option page?
The url should be something like: https://flow-wallet-testnet.blocto.app/bloctoWeb/meta?url=http%3A%2F%2Flocalhost%3A3000
When calling fcl.currentUser().signUserMessage(MSG)
You might also try https://discord.com/channels/613813861610684416/621847426201944074 for more immediate troubleshooting from the community.

can be blocto bug, meta should be their call

Closing. Please reopen if this is still an issue.


Question about benchmark

Hi，i'm highly interested in this position.
I am curious to know if the Hugging Face baseline incorporates Flash Attention2. Could you please offer a reproducible Hugging Face baseline example?

@lugimzzz The baseline as we mentioned is the reference Huggingface implementation from the QLoRA repo - https://colab.research.google.com/drive/1VoYNfYDKcKRQRor98Zbf2-9VQTtGJ24k?usp=sharing, so no, not using FA2. Our benchmark is from the reference implementation, not
I'll edit the readme to include 2 Kaggle benchmarking docs for Unsloth Open vs HF original - it's currently on the dev branch: https://github.com/unslothai/unsloth/tree/dev.2023.12.

https://www.kaggle.com/code/danielhanchen/huggingface-original-laion-oig Reference implementation 60 steps on DDP Kaggle 2 Tesla T4 GPUs takes 40 minutes and 46 seconds
https://www.kaggle.com/code/danielhanchen/unsloth-laion-chip2-kaggle Unsloth implementation 60 steps on DDP Kaggle 2 Tesla T4 GPUs - Unsloth only uses 1 GPU whilst Pro plans use more. takes 4 minutes and 34 seconds (8.64x faster)

If you use 1 GPU, the speedup is as we described in the 1 GPU table on the readme - around 1.8x ish.
The error losses are nearly identical for the first 60 steps, albeit some differences due to FA2, and Triton kernel's internal upcasting to f32:

A bit blurry since I copied it from Google Sheets - you can compare the losses yourself in the 2 notebooks.
All benchmarking uses bsz = 2, ga = 4, max_grad_norm = 0.3, num_train_epochs = 1, seed = 3047, lr = 2e-4, wd = 0.01, optim = "adamw_8bit", schedule = "linear", schedule_steps = 10 except the Slim Orca benchmark on DDP, where it OOMed. We had to reduce the bsz=1 for ALL comparisons on Slim Orca, so the Slim Orca column for all methods is bsz=1. We could have tested Unsloth for Slim Orca on bsz=2, since we reduce memory usage by 50%, but for consistency, it is still bsz=1.
You are more than free to fork the Kaggle notebooks, and change the datasets or play around with them. Hope they're useful!
Thanks for your interest in Unsloth!

@lugimzzz Just wrote up a full blog post on benchmarking + shared 59 notebooks on all our benchmarks if you're interested: https://unsloth.ai/blog/mistral-benchmark


Allow several names for the same chord

Some chords can have several names, e.g. Caug is also called C+ (see also #31). Allow at least some common variants.

See https://en.wikipedia.org/wiki/Chord_names_and_symbols_(popular_music) and maybe get some inspiration from https://github.com/tiehuis/quartic.


Build competition course.

https://docs.google.com/document/d/1ITIsL9fpTk5HKEJW1NENVrkgfCgXqONWpm0sevzeYmo/edit#heading=h.obp73v47rneu
Here are the rules including the dimensions and a 3d model of the course.
We don't need to build the whole thing (it has two parts that are reflections of each other), and we need to be able to store it easily.
This needs to be done by the end of the summer.

Does anyone want to donate a garage or tools/supplies to this project?

From the meeting:
Alwyn has offered his garage.
We need a design, and some able bodies to help out.   I can help out, anyone interested in helping let me know, and we can figure out an agreeable time with everybody.
The design has to be able to break down to be stored, as well as to the specs listed in the competition rules.
We also need a place to store the course.

I got all the tools necessary to build the course. Should I just go buy the materials, keep the receipts, and then get reimbursed later?

The plan is to get together in the next 2 weeks, and build it next Saturday.  We don't have a location yet
Anyone that can make it should respond to the issue, or let me or Ahmed know

We need to get alot of things that are listed on the Things to buy list, Mark if you want to hold off as we will probably be going to buy supplies sometime next week, I know @jasteve4 has volunteered the use of his truck to transport

I haven't started on this issue yet. I can try on making the drawings with the correct dimensions and such. We need to make sure we plan out how we are going to do this with regards to interlocking the components and disassembly. My garage is more than acquitted doing the construction but it is about 35 minutes away from NCSU. Where are you guys planning on doing the construction?

If you want to come up with a plan bring it on Saturday and we can take a look, we have somewhat of a design already, but there are fuzzy details that could be worked out.
@PaladinEng has given us free reign (kidding) of his garage for Saturday June 6th.  We are planning to buy the materials this Saturday probably a bit before 4, there is also a lowes right next to Alwyn's house, so I hear

Can you post an address of where this is taking place?

I don't want to post my address. I'll make sure it get to all who need it.
My house is near the intersection of NC55 and I-40, not far from the
Southpoint Mall
On Thu, May 28, 2015 at 7:45 AM, Mark Vanek<EMAIL_ADDRESS>wrote:

Can you post an address of where this is taking place?
—
Reply to this email directly or view it on GitHub
https://github.com/IEEERobotics/bot2014/issues/354#issuecomment-106287347
.

We bought a lot of the raw materials today at Home Depot. We still need to pick up the red paint form Lowes before next Saturday.
Thanks to all that helped out today.

Everyone is doing cut plans for various parts of the course:
@jasteve4 agreed to do a cut plan for the barge section
@seanketring will do the rail car section
@kennychuang has agreed to do the Tunnel and Rail car section
Brett has agreed to do the floor and walls
Cut plans will be designed from the materials we purchased at Home Depot, and will be presented to the group on Saturday at hackday
On saturday we will also paint the plywood black
Great work everybody see you on Saturday

Are there any other tools or materials you would like me to bring? I got some great right angle clamps for setting up wood. Would we like an extra power hand saw?

Lots of good work done on this last Sunday.
Still to do:
Dowel the course after discussing reflection methods
Decide a method of connecting the two halves together
Paint the tunnel (yellow), barge (grey), and truck (blue)
Paint the last bin and the remaining blocks red
Paint the rails white
This has hack day written all over it.

So I have been talking with Dr. Jovanovic, one of the coordinators of Southeastcon and she recently emailed me:
June 14, 2015:
"I will have to edit the playground, they want the smaller sized one. I will have to do it in next three weeks."
I asked for some clarification on what that meant and she replied:
"Do not build the course until the rules are official
They are asking for the smaller course"
What do we need to do?

We have red paint now assuming they don't change the colors we should be good with paint

we need to tell her that we've already built the course.
On Tue, Jun 23, 2015 at 5:54 PM, SeanKetring<EMAIL_ADDRESS>wrote:

We have red paint now assuming they don't change the colors we should be
good with paint
—
Reply to this email directly or view it on GitHub
https://github.com/IEEERobotics/bot/issues/354#issuecomment-114653362.

Sent her an email explaining our situation
Sent from my iPhone

On Jun 28, 2015, at 12:36 PM, Alwyn Smith<EMAIL_ADDRESS>wrote:
we need to tell her that we've already built the course.
On Tue, Jun 23, 2015 at 5:54 PM, SeanKetring<EMAIL_ADDRESS>wrote:

We have red paint now assuming they don't change the colors we should be
good with paint
—
Reply to this email directly or view it on GitHub
https://github.com/IEEERobotics/bot/issues/354#issuecomment-114653362.

—
Reply to this email directly or view it on GitHub.

Here is what Dr. Jovanovic said:
"Sean,
To answer your question.  Yes there will still be a left and right side course.  The problem that has occurred is that we have been forced to have this years rules reviewed by what feels like no less than 20 different people because of all the BS that happened last year.
In this last round of reviews there was a concern that the track was "too big", when, in fact, the actual playing field is no larger than it has been for past competitions.  The illusion that the track was too big was caused by the fact our drawings had both the left and right tracks shown on the same drawing.  To solve this issue we have updated our drawings to show separate left and right courses.
The idea was that both the left and right designs could be implemented on the same playing field if the tracks are designed with modular components.  This would make it much easier for teams to build and transport the test tracks.
I hope this clears things up.
It is important to realize that we have stated all along that the rules would not be "locked down" (taken out of draft form) until August 15th.  After August 15th all changes have to be approved by the steering committee and logged on the website.  This date was chosen because of the all the additional reviews that have been forced upon us.
Sean"
sounds like we're in pretty good shape.

We now need to plan a hackday where we finish painting the course.   It is an end of summer goal, and one that is low hanging fruit.
Given that I will be out of town for a few weeks, I will not set a date just yet.


Staked amount thresholds

Adds the need for a staked threshold to be met to precent front running of a DAO.
Feedback appreciated!

Converting to draft due to upstream changes


Update readme.md

Changed CivitAI manager to ComfyUI manager, because I think you meant that one ^^. Also I included a link to the ComfyUI Manager, as it is not installed out of the box.

Thank you


Doesn't work with multiple components

Hi @jofftiquez,
I tried using multiple vue-stripe-checkout on the same page and I'm having this error:
Error in mounted hook: "ReferenceError: StripeCheckout is not defined"
Here's an example:
https://codesandbox.io/s/mq2poqz5pj
Any idea how to fix this?
Thanks a lot!

The easiest thing to do is switch to using one checkout on the page and modify the properties before opening. When this component is mounted it requests the stripe bundle, and waits for it to load. However, if another checkout is mounted, it checks if the Stripe bundle is requested, but does not check if it has finished loading, just assumes it is ready and tries using it.
Alternatively, take a quick look at the code, if your use case absolutely prevents you from using this as a singleton. A workaround should not take long

Thanks guys. I ended up changing the properties before .open(). That does the trick for now 👍

@ABuffSeagull thank you for the input.


Correct separator in generated ConfigMap.

The document doesn't show the actual separator used by the generated ConfigMap . The input file uses "=" to separate key from value. The generated ConfigMap uses the YAML ": " separator. The rendered output is not a valid ConfigMap and doesn't match the output of kustomize.

/retest

CLA completed, commenting as directed. Thanks!

The generated configmap does use =, not a : when you apply using an application.properties file. IDK if this is intentional or not.
Perhaps someone from @kubernetes/sig-cli-pr-reviews can provide insight. Is this the intended format of the generated ConfigMap from Kustomize?
node01 $ cat <<EOF >application.properties
> FOO=Bar
> EOF
node01 $ cat <<EOF >./kustomization.yaml
> configMapGenerator:
> - name: example-configmap-1
>   files:
>   - application.properties
> EOF
node01 $ kubectl kustomize ./
apiVersion: v1
data:
  application.properties: |
    FOO=Bar
kind: ConfigMap
metadata:
  name: example-configmap-1-8mbdf7882g

/triage needs-information

I'm sorry, I'd updated the wrong example. I apologize for the confusion it created.
The issue is that the example showing the use of "envs" is incorrect:
apiVersion: v1
data:
    FOO=Bar
kind: ConfigMap
metadata:
  name: example-configmap-1-8mbdf7882g

FOO=Bar is valid for the example earlier in the doc in which it's the content of a .properties file. However this doesn't match YAML key/value syntax in this context, where envs is being used to create YAML keys and values.
I ran the example through kubectl v1.23.0 and got the following output. Note "FOO: Bar", rather than "FOO=Bar" as shown in the doc.
% cat <<EOF >.env
FOO=Bar
EOF

cat <<EOF >./kustomization.yaml
configMapGenerator:
- name: example-configmap-1
  envs:
  - .env
EOF

% ./kubectl kustomize ./
apiVersion: v1
data:
  FOO: Bar
kind: ConfigMap
metadata:
  name: example-configmap-1-42cfbf598f

I've updated the PR accordingly.

I signed it

/remove-triage needs-information

/triage needs-information

I'm not sure if it's my place to toggle needs-information, so leaving for now. Thanks for your time!

/remove-triage needs-information


Show actual image name instead of MISSING_IMAGE name for fabric8-planner builds

For PR builds, the success comment shows MISSING_IMAGE_NAME[0] instead of the actual image name. This PR fixes it.
[0] - https://github.com/fabric8-ui/fabric8-planner/pull/2531#issuecomment-379522291

@pranavgore09 Please review

@jarifibrahim  similar efforts are done in https://github.com/openshiftio/openshiftio-cico-jobs/pull/541
But thanks for updating the message with new features.
I will close that one in favor of this.

@jarifibrahim similar efforts are done in #541

Thanks, Pranav. I didn't know there was a PR already open.
I've updated the PR. Please review again.

@kbsingh  can you please review and merge this PR?


[Tour Of Beam] handle CORS pre-flight requests

Essentially, done as recommended in CF docs, but kept only relevant headers:
Access-Control-Allow-Methods: (GET|POST)
Access-Control-Allow-Origin: *
Access-Control-Allow-Headers: *
Access-Control-Max-Age: 3600

simulate pre-flight requests in integration test for every endpoint
updated README

addresses #24087

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Choose reviewer(s) and mention them in a comment (R: @username).
[ ] Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
[ ] Update CHANGES.md with noteworthy changes.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI.

Thank you!
LGTM

R: @damccorm


Fix Dusan Maldenovic GitHub

Signed-off-by: drasko<EMAIL_ADDRESS>

Codecov Report

Merging #570 into master will decrease coverage by 0.05%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #570      +/-   ##
==========================================
- Coverage   86.92%   86.86%   -0.06%
==========================================
  Files          62       62
  Lines        3381     3381
==========================================
- Hits         2939     2937       -2
- Misses        304      305       +1
- Partials      138      139       +1

Impacted Files
Coverage Δ

writers/cassandra/init.go
60% <0%> (-20%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 998c7ef...03c669a. Read the comment docs.


Update theoretical_description_classification.rst

Description
This PR fixes an error in the documentation. Assuming the scores are ranked from highest to lowest until the conformity score of the true label is found, then the true label Yᵢ should be equal to  πₖ (the last label to be included), not πⱼ. j is a running index, so  Yᵢ  cannot be equal to πⱼ for all j from 1 to k.
Type of change

This change requires a documentation update

Checklist

[x] I have read the contributing guidelines
[ ] I have updated the HISTORY.rst and AUTHORS.rst files
[x] Documentation builds successfully : make doc

Any news on this PR? @vtaquet @LacombeLouis @gmartinonQM ?

The team is currently in vacation, we'll get back to you by next week.
Thanks
Le jeu. 18 août 2022 à 08:48, Andrea Panizza @.***> a
écrit :

Any news on this PR? @vtaquet https://github.com/vtaquet @LacombeLouis
https://github.com/LacombeLouis @gmartinonQM
https://github.com/gmartinonQM ?
—
Reply to this email directly, view it on GitHub
https://github.com/scikit-learn-contrib/MAPIE/pull/215#issuecomment-1219100438,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AIFGUCG536424USHTKBNKK3VZXMDHANCNFSM55N2AZZQ
.
You are receiving this because you were mentioned.Message ID:
@.***>

Codecov Report
Base: 100.00% // Head: 99.77% // Decreases project coverage by -0.22% :warning:

Coverage data is based on head (726e731) compared to base (e56f709).
Patch has no changes to coverable lines.

Additional details and impacted files
@@             Coverage Diff             @@
##            master     #215      +/-   ##
===========================================
- Coverage   100.00%   99.77%   -0.23%
===========================================
  Files           24       24
  Lines         2188     2188
  Branches       241      241
===========================================
- Hits          2188     2183       -5
- Misses           0        4       +4
- Partials         0        1       +1

Impacted Files
Coverage Δ

mapie/_compatibility.py
72.22% <0.00%> (-27.78%)
:arrow_down:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Prompt the user to run pub (at least once in the beginning)

Consider this flow:

clone a git repo
open the new directory in Atom

The user is presented with potentially tons of errors, mainly because pub was never run.

Should we detect that pub was never run and help the user understand that all the warnings might be because they need to install their dependencies?
Atom 1.0.12, dartlang 0.4.5, SDK 1.13.0-dev.2.0 running on macos.

It might be easy to detect this state... is there a pubspec.yaml and no pubspec.lock or .packages? If so, need to run pub get!

Possibly related to #335 - in some cases we may want to auto-run pub, in others auto-prrsent to the user the option to run pub.

fixed - we detect missing or out of date .packages files


Feature/discussion list view

WIP #16  Worked on the discussion backend and frontend.
-Worked on PHP functions and permissions.
-Worked and completed AngularJS front end.

Your commits are in upstream master even though it doesn't look like it's merged in.


Doesn't work with webpack --watch

It rebuilds the bundled .js file, but not the inlined HTML.

This is most likely because of html-webpack-plugin's caching mechanism.  From it's perspective the html file it generates hasn't changed (i.e. the reference to bundle.js is the same).  This inline source plugin works by altering tag definitions generated by html-webpack-plugin, since a new html file isn't emitted the inline source doesn't get updated...
For a quick fix try setting cache: false in your configuration.


Update 05_Dataobject_Relationship_Management.md

Correct a naffed up code block and a typo

I notice the these docs say This tutorial is deprecated, and has been replaced by Lessons 7, 8, 9, and 10 in the Lessons section.
Are those videos going to be updated, or should these tutorials be un-deprecated and cleaned up some more, @unclecheese  :)

@tractorcow Should we remove the This tutorial is deprecated, and has been replaced by Lessons 7, 8, 9, and 10 in the Lessons section.?

Question for @unclecheese :D Maybe we should?


Make presenter view note panel resizable

Is your feature request related to a problem? Please describe.
I prefer to focus on my notes on presenter view, so I would like to have them in bigger than my slides (current and next)
Describe the solution you'd like
Make note panel resizable

Why Closing ?!


+$+(wATCH fREE@@,!!)** Balthazar Ebang Engonga 400 Videos Original Video Link Baltasar Ebang Engonga's 400 Video Viral On Social Media X Trending Now

21 seconds ago
Watch 🟢 ➤ ➤ ➤ 🌐 Click Here To link (Full Viral Video Link)
🔴 ➤►DOWNLOAD👉👉 (Full Viral Video Link)
Watch 🟢 ➤ ➤ ➤ 🌐 Click Here To link (Full Viral Video Link)
🔴 ➤►DOWNLOAD👉👉 (Full Viral Video Link)
L𝚎aked Video Balthazar Baltasar Ebang Engonga Original Video Viral Video L𝚎aked on X Twitter Telegram
Balthazar Baltasar Ebang Engonga Dark Video Female Balthazar Baltasar Ebang Engonga Dark Video Link Viral On Social Media X TikTok Trending Now
Balthazar Baltasar Ebang Engonga Original Video video took the internet by storm and amazed viewers on various social media platforms. Balthazar Baltasar Ebang Engonga , a young and talented digital creator, recently became famous thanks to this interesting video.
 Balthazar Baltasar Ebang Engonga , a young and talented digital creator, recently became famous thanks to this interesting video.
 Balthazar Baltasar Ebang Engonga , a young and talented digital creator, recently became famous thanks to this interesting video.
 Balthazar Baltasar Ebang Engonga , a young and talented digital creator, recently became famous thanks to this interesting video.
 Balthazar Baltasar Ebang Engonga , a young and talented digital creator, recently became famous thanks to this interesting video.
 Balthazar Baltasar Ebang Engonga , a young and talented digital creator, recently became famous thanks to this interesting video.
 Balthazar Baltasar Ebang Engonga , a young and talented digital creator, recently became famous thanks to this interesting video.

Balthazar Ebang Engonga 400 Videos: A Complete Guide to Understanding Its Features, Benefits, and More
Meta Description: Discover everything you need to know about Balthazar Ebang Engonga 400 Videos. Explore its working mechanism, benefits, side effects, and where to buy it.
In recent years, Balthazar Ebang Engonga 400 Videos has been gaining significant attention in various online communities. With claims of unique health benefits and promising results, it’s crucial to understand exactly what this product is, how it works, and whether it’s worth your investment. In this comprehensive guide, we delve into every aspect of Balthazar Ebang Engonga 400 Videos, exploring its ingredients, potential health benefits, side effects, and much more.
What is Balthazar Ebang Engonga 400 Videos?
Balthazar Ebang Engonga 400 Videos is a highly specialized product designed to deliver a range of health benefits, especially to those looking to enhance their well-being through natural supplements.


yaml-cpp-pm isn't compiled anymore under some build conditions

I strongly suspect that this line
 get_property(yaml-cpp-pm_LIB TARGET yaml-cpp-pm PROPERTY LOCATION)

(https://github.com/ethz-asl/libpointmatcher/commit/a9b72eb323#diff-af3b638bc2a3e6c650974192a53c7291R190)
Isn't exactly what we want, because it resolves to a path and not to a target name. It seems not implicitly create a target dependency for pointmatcher anymore:
[ 37%] Building CXX object CMakeFiles/pointmatcher.dir/pointmatcher/TransformationCheckersImpl.cpp.o
[ 39%] Building CXX object CMakeFiles/pointmatcher.dir/pointmatcher/InspectorsImpl.cpp.o
make[2]: *** No rule to make target `contrib/yaml-cpp-pm/libyaml-cpp-pm.a', needed by `libpointmatcher.so.1.2.1'.  Stop.

(taken from http://jenkins.ros.org/job/prerelease-indigo-libpointmatcher/ARCH_PARAM=amd64,UBUNTU_PARAM=trusty,label=prerelease/1/console).
It can be reproduced with a make pointmatcher when yaml-cpp-pm has not been built or its output removed before. Apparently this is what is issued on jenkins.ros.org. (it works with make, because yaml-cpp-pm is within the default targets and before pointmatcher.
The simple solution before a9b72eb323:
set (EXTERNAL_LIBS ${EXTERNAL_LIBS} yaml-cpp-pm )

would make cmake to let libpointmatcher depend on yaml-cpp-pm (in the sense of cmake's target dependencies), in combination with
target_link_libraries(pointmatcher ${EXTERNAL_LIBS})

(not changed with a9b72eb323)
@pomerlef , what was the reason for this location property based solution?
One can fix it with adding an explicit dependency. E.g. :
add_dependencies(pointmatcher yaml-cpp-pm)

But this needs to come after the pointmatcher target's declaration. So maybe we should introduce another collecting variable for dependencies? E.g. POINTMATCHER_EXTRA_DEPS ?

As a suggested solution I've just created #71 .

there was a problem with the find_package(libpointmatcher) command so I cleaned all dependencies and made that change meanwhile. It appear that the problem would be related to  yaml-cpp-pm  not being installed #66 with make install.
Would it be more convienient to roll back to:
set (EXTERNAL_LIBS ${EXTERNAL_LIBS} yaml-cpp-pm )

instead of your patch?

Ah, you mean if yaml-cpp-pm is properly installed, then we don't need to resolve the location anymore? Makes sense... Yes, I would go for that. I'm not that comfortable with relying on the properties. I think they are not that frequently used and will therefore at some point in future break with our expectations. Furthermore it is wrong to use the targets location here, as this will not be the installed location, right? So as soon as someone deletes the build folder it doesn't work anymore. Like it was the problem in libnabo before 62a384d99e943 (see https://github.com/ethz-asl/libnabo/blame/master/CMakeLists.txt#L174 ).
So then we would rollback here (partially), so use exactly the line
set (EXTERNAL_LIBS ${EXTERNAL_LIBS} yaml-cpp-pm )

again.
But that means we have to solve #66. It will be only important for people using the static libpointmatcher version (the dynamic library will already be linked to yaml-cpp-pm). But still this is important as we allow static pointmatcher library. We should not forget then that we need to fix the path in the libpointmatcherConfig.cmake   for yaml-cpp-pm as well, like in https://github.com/ethz-asl/libpointmatcher/blob/master/CMakeLists.txt#L342. This is kind of destroying the concept of EXTERNAL_LIBS again. I'm afraid the best is to not treat yaml-cpp-pm as EXTERNAL_LIBS but give it a special treatment again. Otherwise you have to remove yaml-cpp-pm from EXTERNAL_LIBS before you write it in the installed version of libpointmatcherConfig.cmake.
Oh my, this is all ugly. The ideal would be of course to just support new versions of yaml ;) and get rid of this backed in yaml version (#42).   But who has the time for that? Has anybody ever looked into the effort that would need? Maybe it is just a few lines we are trying to avoid :). That would be a bad joke...

Just had a look: Doesn't seem to be too bad. But we are also not too lucky. I guess 3h. Especially if one goes the cheap way to still support the old API (for environments with no yaml-cpp 0.5). That would be keeping the old code and switch between old and new with the preprocessor.

My hope is to have an intern this summer for that kind of stuff. For now, I need to reduce my supporting time a bit...
My fear with yaml library is that they are still at version 0.5, which means that they didn't want to commit on their current API... But I agree that we should follow the latest version.
Another solution would be to add yaml source in libpointmatcher and to not consider it as a dependency at all.

Yes, packing all the yaml objects into pointmatcher is a nice option as well :). I looked into that already. The problem is that this would mean reading through the CMakeLists.txt of yaml-cpp-mp, which is a bit bigger than what one would expect. But most likely there is nothing important in it. (compiler flags and co.). There is unit test coverage for the yaml functionality of libpointmatcher? If yes, one could just try..

This will be considere close for now


Newly deployed domains do not appear in the domain switcher after bulk deployment

When using the bulk domain creation feature, newly created domains do not immediately appear in the domain switcher in the header. The admin user creating them must logout and log back in before they appear.

Resolved in https://github.com/nmaas-platform/nmaas-portal/pull/123/files


No such element or plugin 'avtp'

Hello.
After completing the build to use AVTP, I am unable to find the AVTP element in GStreamer.
$gst-inspect-1.0 avtp
No such element or plugin 'avtp'
No errors occurred during the installation process. and I can find avtp.pc in /usr/local/lib/x86_64-linux-gun/pkgconfig.
Please let me know what went wrong or if there are any specific areas that I need to check.
I have proceeded with the build as follows.

configuration
Ubuntu 20.04
kernel 5.4
meson 1.2.1

build libavtp
$git clone https://github.com/Avnu/libavtp
$ cd libavtp
$ meson build
$ ninja -C build
$ ninja -C build install

build Gstreamer
$git clone https://github.com/GStreamer/gstreamer.git
$meson build-gst-full
--buildtype=release
--strip
--default-library=static
--wrap-mode=forcefallback
-Dauto_features=disabled
-Dgst-full-libraries=app,video,player
-Dbase=enabled
-Dgood=enabled
-Dbad=enabled
-Dgst-plugins-base:typefind=enabled
-Dgst-plugins-base:app=enabled
-Dgst-plugins-base:playback=enabled
-Dgst-plugins-base:volume=enabled
*-Dgst-plugins-bad:avtp=enabled *
-Dgst-plugins-base:audioconvert=enabled
-Dgst-plugins-good:audioparsers=enabled
-Dgst-plugins-good:isomp4=enabled
-Dgst-plugins-good:deinterlace=enabled
-Dgst-plugins-good:audiofx=enabled
-Dgst-plugins-bad:videoparsers=enabled
$ninja -C build-gst-full
$sudo ninja -C build-gst-full install

Thanks.

Hi @namdala,
Could you please share the output of meson and ninja commands for both libavtp and gstreamer? Maybe something went wrong somewhere, and it's kinda hard to find on the huge gstreamer meson output.


DefaultVisualStudioRazorParser.Dispose isn't called contributing to massive leaks when razor files are closed.

This class holds onto the world and DefaultVisualStudioRazorParser.Dispose is used to clear out the documenttracker from holding onto this object (via the ContextChanged event).

The razor world has changed a bit since this bug was created. @DustinCampbell -- any thoughts on whether this is still an issue? I have to believe it's not, otherwise this would have bubbled up in the past 4.5 years.

I guess these are legacy editor only classes, so we probably can just keep those low on the backlog, or feel free to close if you don't think it's worth investigating.

This is before my time. I'll take a look.


(maint) Bump oldes support puppet version in Gemfile

Packaging currently requires at least Puppet 3.8.1, but the Gemfile is
out of date and lists the olds supported Puppet as 3.5.1. Bumping the
Gemfile to match packaging.

retargeting at stable https://github.com/puppetlabs/puppetdb/pull/1646

Refer to this link for build results (access rights to CI server needed):
http://jenkins-enterprise.delivery.puppetlabs.net/job/enterprise_puppetdb_init-multijob_githubpr-master/64/
Test PASSed.


Support HTTP method HEAD and PUT

Unofficially supported since https://github.com/lpgauth/buoy/pull/18.

Fixed for PUT but now for HEAD.


Testing Examples

Note, I made a change to one of the core package modules (i.e. micap.pipeline.generate_structure_candidates). This was done because during testing I found that there are times when a particular configuration will yield zero contour candidates. I wanted this function to produce a null result as opposed to throwing an error. Let me know if you want to handle differently.

This pull request now merges changes mentioned above (i.e. checking contour length), includes a modification to conditionally allow users to use the signal mask when generating contours, and includes the example script. Let me know of concerns or requested modifications.

Perfect, thanks Ben!


chore(main): release 3.3.0

:robot: I have created a release beep boop
3.3.0 (2024-11-20)
Features

added the cheese (#88) (32b4491)

This PR was generated with Release Please. See documentation.

:robot: Created releases:

v3.3.0
:sunflower:


Support Redis lookup join in FlinkProcessor

What is the purpose of the change
This pull request adds Redis lookup source in Flink Processor.
Brief change log

Adds Redis lookup source in Flink Processor.

Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): no
The public API: yes

Documentation

Does this pull request introduce a new feature? yes
If yes, how is the feature documented? docs

Hi @lindong28 could you please take a look at this PR?

Thanks for the comments @lindong28. I have updated the PR according to the comments.

Thanks for the comments @lindong28. I have updated the PR according to the comments.

Thanks for the update. LGTM.


fix collision issue

PR description
The idea of this PR is to revert some modification that was made to pass tests  https://github.com/hyperledger/besu/pull/5686.
Therefore, I decided to revert some modification on this PR by fixing the problem differently. Indeed, the idea of the collision test that does not pass is to selfdestruct a contract and recreate it afterwards. Instead of modifying the logic of the accumulator and listing all the storage leaves to be deleted during the selfdestruct, which seems to lead to edge cases, I prefer to let BonsaiWorldstate handle it as before and just load the storage with EMPTY_TRIE_HASH if we detect that it has been cleared before pushing the new slots after recreation. Indeed, the clearing of the storage that is done at the beginning of calculateRootHash removes the storage but does not change the storage root of the contract. Therefore, we falsely believe that the storage is not empty.
Fixed Issue(s)

In the case of just a selfdestruct it should be managed by that https://github.com/hyperledger/besu/blob/main/ethereum/core/src/main/java/org/hyperledger/besu/ethereum/bonsai/worldview/BonsaiWorldStateUpdateAccumulator.java#L275
If the contract is recreated without storage we will only delete the flat and we will have the garbage in the tree https://github.com/hyperledger/besu/blob/main/ethereum/core/src/main/java/org/hyperledger/besu/ethereum/bonsai/worldview/BonsaiWorldStateUpdateAccumulator.java#L396 it is the logic that I understands

Sync passed on goerli @garyschulte if you can review it please


on_debug callback not presenting source

I have started integrating rhai into my application and all is going well, but I wanted to catch debug statements, but the second parameter should be the source I specified after compiling the AST with "set_source()"
I've checked and a call to the AST after with ".source()" returns what I set, but the on_debug() call does not include the source parameter.  It is always None.
This feels like a bug, but it's possible I'm not setting something up properly.  The "Rhai Book" says the only thing necessary is to call set_source(), and because ".source()" is returning the expected value, I think I've done that.
Here is the registering of the on_debug statement
        engine.on_debug(|msg, src, pos| {
            eprintln!("{src:?}:{pos}:{msg}");
        });

Here is where I create it.
	...
       match self.rhai.engine.compile(script) {
            Ok(mut ast) => {
                let ast_src = src.as_ref().unwrap();
                let ast_id = format!("{}:{}", ast_src.source, ast_src.source_position);
                ast.set_source(ast_id.as_str());
                println!("get_ast source: {:?}", ast.source());
                let shared = rhai::Shared::new(ast);
                println!("get shared source: {:?}", shared.source());
	...

Here is where I invoke it.
	...
        let ast = &func.unwrap().ast;
        println!("source of ast: {:?}", ast.source());
        let name = &func.unwrap().name;

        match self.rhai.engine.call_fn_with_options::<rhai::Dynamic>(options, &mut scope, ast, name, args) {
        ...

Here is the rhai script I am running:
            fn call_me(p)
                debug("called call_me");
                return `${p.value}_id`
            }

What I get when I run it (it gets run twice in my test suite):
get_ast source: Some("test:4")
get shared source: Some("test:4")
source of ast: Some("test:4")
None:line 3, position 5:"called call_me"
source of ast: Some("test:4")
None:line 3, position 5:"called call_me"

Hhmmm... May be an oversight.
The souce is primarily used when loading separate modules for an easy way to track where functions come from.
It probably should be set also when running an AST. I'll take a look.

Found something strange.  The test here:
https://github.com/rhaiscript/rhai/blob/main/tests/print.rs#L38
should test against setting source in the AST and getting it back in debug statements.

You can check out the new drop https://github.com/rhaiscript/rhai/pull/885
This should fix the issue.

Awesome, I'll check it out.

Closing this for now.  Feel free to reopen if there are further issues.


hard_sigmoid doc

The description wasn't detailed enough. Added a tiny bit more explanation and a reference.
I don't know if this is the proper formatting of the url.

@googlebot I signed it!


add pre-commit hooks for convenient formatting checks

Addresses https://github.com/pytorch/vision/pull/4384#issuecomment-915859276. Right now we only use flake8 as format checker, but I've added a few more that I think are uncontroversial. Let me know if you think otherwise.

There are some formatting failures, but I'll only push fixes if the PR is otherwise ready to go.


ItemStack Persistent Data Container not Saved

What is your Quests version / build number (do not say "latest")?
Quests 4.3.1-b321
Describe the problem and how to replicate it.
Item rewards do not keep their persistent data container. I have a private plugin that saves item information within the ItemStack's pdc.
If I set one of those special items as a reward for a quest, the item that is given does not contain the data that should be in the persistent data container.
I shared a reward entry that should contain persistent data. It looks like they are saved in "PublicBukkitValues". Something here isn't saved correctly, as these items dont behave as they should.
EDIT: The problem is you are reading the "unmendable" entry as a boolean data entry, when it is a String data entry that may be set to "true" or "false" in some cases. PLEASE FIX!!!
Any console errors to share?
None

If applicable, can you provide an example quest from quests.yml?
    rewards:
      items:
      - ==: org.bukkit.inventory.ItemStack
        v: 2975
        type: DIAMOND_CHESTPLATE
        meta:
          ==: ItemMeta
          meta-type: UNSPECIFIC
          display-name: '{"extra":[{"bold":false,"italic":false,"underlined":false,"strikethrough":false,"obfuscated":false,"color":"light_purple","text":"Kavacha"}],"text":""}'
          lore:
          - '{"extra":[{"bold":false,"italic":false,"underlined":false,"strikethrough":false,"obfuscated":false,"color":"red","text":"Unmendable"}],"text":""}'
          - '{"extra":[{"bold":false,"italic":true,"underlined":false,"strikethrough":false,"obfuscated":false,"color":"dark_purple","text":"This
            chest is imbued with"}],"text":""}'
          - '{"extra":[{"bold":false,"italic":true,"underlined":false,"strikethrough":false,"obfuscated":false,"color":"dark_purple","text":"the
            strength of gods."}],"text":""}'
          - '{"extra":[{"bold":false,"italic":false,"underlined":false,"strikethrough":false,"obfuscated":false,"color":"green","text":"-
            Strength II"}],"text":""}'
          - '{"text":""}'
          - '{"extra":[{"bold":true,"italic":false,"underlined":false,"strikethrough":false,"obfuscated":false,"color":"light_purple","text":"EPIC"}],"text":""}'
          enchants:
            PROTECTION_EXPLOSIONS: 5
            PROTECTION_FIRE: 5
            PROTECTION_PROJECTILE: 5
            PROTECTION_ENVIRONMENTAL: 5
            DURABILITY: 10
          PublicBukkitValues:
            rpgcore:god_item: kavacha
            rpgcore:unmendable: 1b

This is merely how the Bukkit API serializes the ItemStack, per
https://github.com/PikaMug/Quests/blob/b7282cbadacedcf32e8123a80f271dd24152d1b1/core/src/main/java/me/blackvein/quests/quests/BukkitQuestFactory.java#L830-L831
where the session data is simply a list of ItemStack. Feel free to submit a Pull Request if you know of a workaround.

Save (and then read) ItemStacks as a String like so: https://pastebin.com/jKBR1f43

I'll re-open, but again please consider submitting a Pull Request.


Automated cherry pick of #4065: fix: 兼容以前的参数

Cherry pick of #4065 on release/2.13.
#4065: fix: 兼容以前的参数

Codecov Report

:exclamation: No coverage uploaded for pull request base (release/2.13@4c0bc84). Click here to learn what that means.
The diff coverage is 0%.

@@              Coverage Diff               @@
##             release/2.13   #4071   +/-   ##
==============================================
  Coverage                ?   6.91%
==============================================
  Files                   ?     508
  Lines                   ?   85769
  Branches                ?       0
==============================================
  Hits                    ?    5927
  Misses                  ?   79341
  Partials                ?     501

Flag
Coverage Δ

#aFlag
6.91% <0%> (?)

Impacted Files
Coverage Δ

pkg/compute/models/managedresource.go
0% <0%> (ø)

pkg/compute/models/networks.go
0.55% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4c0bc84...345292c. Read the comment docs.


Server XML response use correct members and return null if nothing to serialize

Motivation and Context

Fix #1101

Description

fix to use response members for server output
return null if no members

Testing

Tested with S3 API server codegen.

Checklist
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

I think the correct fix is to copy what the client is doing:
https://github.com/awslabs/smithy-rs/blob/f4d3910f227ceb4962eadac994540edb45137709/codegen/src/main/kotlin/software/amazon/smithy/rust/codegen/smithy/protocols/serialize/XmlBindingTraitSerializerGenerator.kt#L106-L115
That is, if there are no xmlMembers, early return null. That way no function to serialize will be generated. Your fix works, but the serializer function will be generated and called when in reality it has no work to do (there are no operation output members to serialize to the body).

@david-perez Since this fix and #1101 are almost related, I updated this PR to fix both.
Thanks for all your explanations - you've made me so much more productive!

Thanks @rcoh ! updated with your suggestions.


Support adding keys to agent

The SSH implementation in macOS Sierra changed. Keys are no longer automatically added to the SSH Agent on reboot. Thus, with Sierra I have to manually run ssh-add -K <~/path/to/key> from the terminal in order to have the key added to the agent. Once done, jsch-agent-proxy is able to pick it up.
However, there is a setting to allow SSH to automatically add keys to the agent. Thus, on the terminal I don't have to call ssh-add... . I just execute git pull/push and the key is added. SSH still uses the passphrase from the keychain.
http://superuser.com/questions/325662/how-to-make-ssh-agent-automatically-add-the-key-on-demand
Can the AddKeysToAgent option somehow be supported by jsch-agent-proxy? Ideally I want a password less operation from within Eclipse - without running ssh-add on the terminal first.

I found a workaround for macOS:
https://github.com/jirsbek/SSH-keys-in-macOS-Sierra-keychain


Implement import of trait names from ClinVar

Information about traits can be retrieved from a static, periodically updated endpoint https://ftp.ncbi.nlm.nih.gov/pub/clinvar/tab_delimited/variant_summary.txt.gz. There is an accompanying checksum file https://ftp.ncbi.nlm.nih.gov/pub/clinvar/tab_delimited/variant_summary.txt.gz.md5.
The main file is a gzipped TSV containing about two dozen columns (first line, starting with #, is a header). There are three columns of interest:

PhenotypeList column contains trait names. There can be one or multiple per record. If there are multiple, they are separated with semicolons, for example Inborn genetic diseases;Mitochondrial complex 1 deficiency, nuclear type 21;Mitochondrial complex I deficiency;not provided
RCVaccession contains IDs of ClinVar RCV records. An RCV record, in general, associates multiple genetic variants with multiple trait names. Similarly, there can be one or multiple, for example RCV000622708;RCV000735415;RCV000000017;RCV000196589.
AlleleID contains the identifier of a genetic variant. Example: 15046.

These columns follow this list of constraints:

The number of semicolon-separated values in PhenotypeList and RCVaccession is always the same for a given record and is always 1 or greater. The values with same same index form pairs.
AlleleID always contains an integer, however, it is not a key for the table and several rows can have the same AlleleID (see below).

Trait names imported into the database should represent a unique set of all trait names present in this file.
To calculate the number of records assigned to each trait, we need to consider all tuples of (AlleleID, RCVaccession, PhenotypeList). For example, exploding along RCVaccession and PhenotypeList, the sample record described above would generate four tuples:

(15046, RCV000622708, Inborn genetic diseases)
(15046, RCV000735415, Mitochondrial complex 1 deficiency, nuclear type 21)
(15046, RCV000000017, Mitochondrial complex I deficiency)
(15046, RCV000196589, not provided)

When we do this for all rows in the file, we need to combine all tuples together and deduplicate them (leave only unique tuples). In this final set, the number of tuples which mention a given trait name is the number of records associated with this trait, which should also be imported into the database and stored in a separate field.
The reason there can be non-unique tuples is because of different reference genomes. Sometimes there will be two records with the same AlleleID and with most columns containing identical or very similar values; the difference will only be in the reference genome (GRCh37/GRCh38) and chromosomal coordinates. This is why we do deduplication to count the number of records correctly.
Some considerations about the import:

Columns in the file can change order, so they should be extracted based on their names, not fixed position indexes.
Import should be performed periodically and automatically; and there should also be a way to trigger import manually (perhaps through a button or a separate page?)
Failure to import must generate some sort of a logging message which must go somewhere (we'll need to think through the logging mechanism, perhaps in a separate issue)
Care should be taken so that user modifications don't overlap with a database modification caused by a user.

To clarify the scope here: as we discussed yesterday, this issue is specifically about backend logic to do the import. Import automation & manual triggering will be implemented separately.

So just to clear the process of selecting trait names and calculating the number of source records

Inserting trait names: I select every single unique trait name that appears in the PhenotypeList column
Calculating source record number: For each AlleleID, I calculate every unique possible tuple with RCVaccession and PhenotypeList. Their number is the source records.

Also, we need to see what the behavior will be for already existing trait names whenever a new import cycle begins. Do we calculate the source records again for already existing trait names, and just insert the new ones as usual?

Another thing, is that I am excluding "not provided" values for both trait name imports and source record number calculation, should I treat those records differently?

Inserting trait names: I select every single unique trait name that appears in the PhenotypeList column

That's correct, provided that the PhenotypeList column values are exploded prior to that—i.e., split by ; character.

Calculating source record number: For each AlleleID, I calculate every unique possible tuple with RCVaccession and PhenotypeList. The number of each trait name's appearance in those is its source record number.

That's correct. Just to clarify, after calculating tuples per each AlleleID, it's also important to combine all of them together and then do the deduplication (remember, AlleleID is not unique per row).
To expand a bit on why we do this: the central object which is in the end submitted to Open Targets is an "evidence string". Each evidence string is defined by a tuple (trait, variant, ClinVar record). So the number of evidence strings generated by any given trait will depend on the total number of (variant, ClinVar record) tuples associated with it. This corresponds to (AlleleID, RCV) tuples in the source data.

Another thing, is that I am excluding "not provided" values for both trait name imports and source record number calculation, should I treat those records differently?

Yeah, that's a good question. ClinVar has a number of trait "names" which cannot be mapped to any ontology term. Most notably "not provided", but there are also things like "see cases", "other" and a couple of others. In this ticket you don't need to address those situations in any special way. In future, we will need a possibility for curators to mark the trait as "invalid", probably necessitating an additional status. This is not a high priority issue. I've added it to backlog: https://github.com/EBIvariation/trait-curation/issues/37

Also, we need to see what the behavior will be for already existing trait names whenever a new import cycle begins. Do we calculate the source records again for already existing trait names, and just insert the new ones as usual?

Regarding this, what I am doing right now is that If a record already exists in the database I leave it as is, and I only insert new ones with their source record numbers. Let me know if I should change this.
Other than that, the script is ready. Should I add a button somewhere to trigger the import and submit it in a PR?

Also, we need to see what the behavior will be for already existing trait names whenever a new import cycle begins. Do we calculate the source records again for already existing trait names, and just insert the new ones as usual?

Regarding this, what I am doing right now is that If a record already exists in the database I leave it as is, and I only insert new ones with their source record numbers. Let me know if I should change this.

Oh, I missed that question, sorry. The correct behaviour in this case is what you described originally: insert new trait names with their record counts + also recalculate number of linked records for all existing traits.

Other than that, the script is ready. Should I add a button somewhere to trigger the import and submit it in a PR?

Yes, please do. I'm not sure where to put this button, though. There is an issue https://github.com/EBIvariation/trait-curation/issues/32 for designing the page for buttons triggering various processes, but it's a separate one. So for now, I guess you could just add the button anywhere where it is convenient. And then, once #32 and subsequent implementation issues are done, we'll move it there.
Another issue is logging. In case the import doesn't go through for some reason, we need a way to access the logs of the script. Do you have any ideas on how to do that best? For example, regarding the Heroku instances where all of this is running, do you have any way to access them (semi-) directly? Or could we make the script, once triggered, output its logs to the Javascript console or something?

Another issue is logging. In case the import doesn't go through for some reason, we need a way to access the logs of the script. Do you have any ideas on how to do that best? For example, regarding the Heroku instances where all of this is running, do you have any way to access them (semi-) directly? Or could we make the script, once triggered, output its logs to the Javascript console or something?

The easiest way to view logs would be to output them to the server console. They can then be accessed via the Heroku CLI or simply by going to the 'logs' page in the Heroku webpage. For example https://dashboard.heroku.com/apps/clinvar-trai-prototype-pmia54t/logs

The easiest way to view logs would be to output them to the server console. They can then be accessed via the Heroku CLI or simply by going to the 'logs' page in the Heroku webpage. For example https://dashboard.heroku.com/apps/clinvar-trai-prototype-pmia54t/logs

OK, that's great, let's use this way for now. Maybe in the future we'll implement some user friendly logging, a status page, email notifications, or something similar. For now Heroku server logs will do just fine


Documentation:  create_single_dose_dataset() example creates duplicates

Please select a category the issue is focused on?
Other
Let us know where something needs a refresh or put your idea here!
Was trying out the ADPPK Template but found that the create_single_dose_dataset() under the "Expand Dosing Records" section was creating duplicates within the variable NFRLT.
ex_exp |> # dataset derived from create_single_dose_dataset in the above linked example
  filter(USUBJID == "01-701-1028")  |> # filters for the first subject as an example
  count(NFRLT, sort = T)  #shows  nominal times which are repeated

which gives:

It seems the duplicates happen for the day of individual visits. Like during the process of unnesting each visit to a dose day/unit, it calculates the visit day twice rather than moving on.

Unsure if this is an actual coding/workflow issue or just specific to the example. In the previous step, "Get Dosing Information" - it creates the original NFRLT variable by NFRLT = 24 * (VISITDY - 1). This NFRLT is then used in the create_single_dose_dataset() to create the nominal time where the duplicates occur. In the other examples, I couldn't find this occuring.
However, when I reformatted the ex data before the create_single_dose_dataset() to have the first visit VISITDY be equal to 0 without altering any of the other visits, it allowed the logic of the function to proceed as intended.
reformatted <- ex_dates |>
  filter(USUBJID == "01-701-1028")  |> #sets subject as an example
   mutate(VISITDY = if_else(VISITDY == 1, 0, VISITDY),
          NFRLT =VISITDY * 24)

#shows the duplicates have decreased
reformatted |>
  create_single_dose_dataset(dose_freq = EXDOSFRQ,
    start_date = ASTDT,
    start_datetime = ASTDTM,
    end_date = AENDT,
    end_datetime = AENDTM,
    nominal_time = NFRLT,
    lookup_table = dose_freq_lookup,
    lookup_column = CDISC_VALUE,
    keep_source_vars = exprs(
      STUDYID, USUBJID, EVID, EXDOSFRQ, EXDOSFRM,
      NFRLT, EXDOSE, EXDOSU, EXTRT, ASTDT, ASTDTM, AENDT, AENDTM,
      VISIT, VISITNUM, VISITDY,
      TRT01A, TRT01P, DOMAIN, EXSEQ, !!!adsl_vars)) |>
  count(NFRLT, sort = T)

There is still duplicates in this reformatted example due to the misalignment of the VISITDY and the actual days between visits. I have the derived days between the first visit 2013-07-19 and last visit 2014-01-07 as 172 days ( 24.57 weeks) not the 168 listed. See attached excel for my visual breakdown: example_doseSchedule.xlsx
Overall, unsure how specific this problem is to the example data set (or my handling of it), or if it is something else. I am happy to help out wherever I can, but I am very new (this is my first issue on Github!)

Hi @jeffreyad do you have time to look into and respond to this issue?

Hi @jeffreyad do you have time to look into and respond to this issue?

@bms63 sure, I'll take a look

Hi @tuiaj thanks for adding the issue.  I had not noticed that before.  I don't think it affects the final ADPPK data since the PC data are only at the baseline visit.
I think you are correct that the VISITDY may not match the VISIT value listed, and the WEEK 2 visit should have VISITDY = 14 instead of 13.
Congrats on your first issue!

@tuiaj would you like to try and make this update?
Congrats on your first issue and providing an excellent write-up!!

Yes - I can try!

@tuiaj Thanks! Feel free to reach out with any questions you have.

Hi @tuiaj any update on this?

@jeffreyad I think they are not around right now - they were trying to do the dummy issue but went AFK.  do you mind taking this on or we can ask others on the team?

@bms63 sure I can take it


fix: dependencies of dependencies

What I did

fixes: #1198
Goes with https://github.com/ApeWorX/ape-solidity/pull/86
Requires https://github.com/ApeWorX/ethpm-types/pull/56
How I did it

How to verify it

Checklist

[ ] All changes are completed
[ ] New test cases have been added
[ ] Documentation has been updated

Seems like this impacts some of the testing workflow. May need some additional QA on usage within projects with tests in them to make sure everything still works.

I tested against like 4 of Yearn repos and I suggest others do the same.

Seems like this impacts some of the testing workflow. May need some additional QA on usage within projects with tests in them to make sure everything still works.

I tested against like 4 of Yearn's repos and I suggest others do the same.

Ah, this is good then. Would appreciate one other person doing QA, then I think this can merge


Adding third party modules

Intention

I'm submitting a discussion request
Definition
Since there is no well established standard for storing and managing Node.js based application, I am defining Monterey's application adding third party modules as editing the package.json file followed by processing of the relevant sections of the that file. This will give us the needed coverage for  Aurelia applications using any of the [SystemJS, RequireJS and Webpack] module loaders / bundlers.
Everything written in this article is limited to applications using RequireJS module loader or equivalently, to applications created with Monterey's Aurelia-CLI wizard
Third party modules could be added initially in the application creation process as well as after the application was created, by using the NPM Package Manager.
The rest of this document describes the changes to the Monterey v0.4.x to achieve that goal.

Summary
This "story" begins with the current Aurelia-CLI based method for creating new applications:

For the next version of Monterey, we want to support a bit more complex starting Aurelia-CLI templates set, which would allow us to add third party modules at the time application is being created - as well as after is is initially created.
The rest of this document describes the changes to the Monterey v0.4.x to achieve that goal.

1. New set of Aurelia-CLI templates:
Here is slightly enhanced version of the first page of Aurelia-CLI Create new application wizard, describing the situation where the user selected ESNext as the Language and (newly defined) Type Extended (level above Default type originally introduced by aurelia-cli tool).

See Extending Aurelia-CLI wizard #391 for more details.

Open issues

How to "configure" some plugins (Materialize bridge for example; KendoUI does not require any pre / post processing tasks)

Note to myself: using the atom json editor is the likely most effective way to make some progress with the above listed issues.


Fix unnecessary bundle refreshes when installing/updating features

Currently, the feature deployer uses the OSGI Resource interface object to determine dependent bundles that require refreshing when bundles associated with a feature are installed or updated.  Unfortunately, there are a number of conditions where equivalent resources will not satisfy the equality conditions of the Resource implementation class(es) involved, resulting in unnecessary dependent bundle refreshes during deployment.
This change replaces the use of the Resource interface with a wrapper class to ensure that equality is evaluated solely on symbolicName/version.

@rovarga this might interest you...

Just a side note, it looks good to me for the "current" feature resolver. The coming simple feature resolver (optional as an alternative to the regular one) is doing a "flat" resolution (no auto refresh).


put function does not update FEN

The problem
put :: Amazons -> Square -> String -> Amazons Is a function that takes a game, a square, and a coordinate and returns the new game. move :: Amazons -> String -> Amazons uses this function but the FEN is properly updated. put should do this too, but that means potential breaking changes could happen.

#7 Solved this issue


Pick-up Download Images at Request Time Out

Purpose
Hello, I'm using the api to download ~16k Google Street View photos and around photo 4500 the request timed out. How can I continue downloading from where the request timed out without having to reload the params, from the timed out point, onto the results again.
Example
params is ab 16k
results = google_streetview.api.results(params)
results.links[4176:].download_links('balt_streetview_downloads')
I want to pick up downloading photos from number 4176. The above doesn't work because results.links is a list and .download_links works on the results. object only.
Notes

@ap266 Thanks for describing the problem! I should develop a retry and fault-tolerant method for download_links.
:wrench: In the meantime, you could save the links with save_links and use requests and shutil to download and retry them from a particular line if they fail:

Read the saved links from file line by line
Make reference to current line
If download fails:

Try the current line again until all lines have been read

❗ This package uses the requests and shutil libraries as well, and you are welcome to use the function at 📃 Line 74 to 79 in helpers.py!


message view: Search view doesn't mark messages as read in some situations.

I may have seen this in a more general situation as well, but an easy to replicate bug:

Search for something, like stream:test+here hello
reply to the last message with hello

expected behavior: the message you just sent should have been marked as read.

use arrow keys to go up and down

message is still not marked as read.

So, do we plan to implement this? @timabbott @rishig

I'm not sure we know what we want here.  I recommend working on other issues.

since we have a reproducer, might be good to fix the bug, independent of future product changes?

Ahh, I hadn't realized this had a reproducer.  Probably a fairly subtle issue to investigate; I should probably take it.

This turned out to be a display logic issue, not a "marking as read" bug.  Next time @rishig, please be clearer in the report what was going on (specifically that it showed the green line, not that the unread counts are off).  It would have saved some confusion on my part about what was being reported.


sql analysis bug

where outside select contains inner computed expression,the can not be explained

SELECT
T_AABC60.acc_id AS __fcol_0,
T_AABC60.(``violation_ad_spend_amt_28d_agent`` - ``violation_ad_spend_amt_28d_acc``) / (``spend_amt_28d_agent`` - ``spend_amt_28d_acc``) AS __fcol_5
FROM
(
SELECT
acc_id,
( violation_ad_spend_amt_28d_agent - violation_ad_spend_amt_28d_acc ) / ( spend_amt_28d_agent - spend_amt_28d_acc )
FROM
test.testabc
WHERE
acc_agent != ''
AND acc_agent != 'avc'
AND dt = date_sub( CURRENT_DATE ( ), 1 )
) AS T_AABC60
LIMIT 5000;

@bigdata-kuxingseng what your mean is this sql could execute，but couldn't explain？

@bigdata-kuxingseng please describe your create table sql. thank you.


Add additional parameter validation before authentication

Hello,
I was switching from using a managed identity in one subscription to service principals in multiple subscriptions and spent a long time debugging the problem. This PR includes the fixes that I think will help reduce the amount of time others spend debugging.

Adds additional parameter validation.
Adds debug logging to help with determining where a failure is occurring during authentication
Adds ncc as an additional dev dependency to help with generating dist/index.js

related to #30

Lots of changes to upstream since this was originally submitted. I'll go ahead and close this since it probably introduced too much or was headed in the wrong direction.


If preferred value not present, return non-preferred values

We have an issue in scholarsphere where if a preferred name is not present in identity services it will return nil and break things.  I thought this was fixed in a previous version of this gem, but it turns out I never fully fixed the issue.  The problem is described here: #14.  I claim it was fixed, but I actually implemented the solution wrong by using .fetch.  .fetch doesn't work the way I thought it did.  .fetch only returns the value in the second argument if the first value is not a hash key in the hash it's being called on.  What we need is something to return the non-preferred name values if the preferred values are nil, '', or not in the hash at all.  The changes I made in this PR should do that.
Let me know if this doesn't sound right @Smullz622 @whereismyjetpack

Also — just something I feel I should mention — I think I'd prefer if this gem was a 1:1 wrapper for the psu identity services.  However, it seems we've already implemented it in some of our systems with the understanding that there will be some data mutations (like returning the non-preferred names when the preferred don't exist).

I 💯 agree. I think we can depreciate our mutations, and let the client decide which to use


More cleaning of Cython dev branch

Aggressively strip out everything not related to the Cython branch for now, to make it easier to focus on relevant code. Let me know if you think we should keep anything else.
Also added makefile to simplify installing and removing package.

I'd suggest keeping everything that will still be needed once converted to Cython. Otherwise these files will need to be picked out of the master branch again later. The things I thought we might want to keep are:

.travis.yml (will need updates, but the file won't be deleted)
LICENSE (needed)
MANIFEST.in (still will be used is my understanding)
CHANGELOG.md, docs/*
binding_version.py and test_parity files might still be needed (but might need updates)
fab file might still be needed for lint?

Sounds good! Added those back in.


Add CDNJS version badge in readme

This will add the badge to show its version on CDNJS and also link to its page on CDNJS!

thx for that!
please point the PR against master, it's currently targeting gh-pages

done, cc #317
Thanks!

looks like we forgot to close this after #317 got merged…


make error

choas@LY:~/Codes/Faster-RCNN_TF/lib$ make
python setup.py build_ext --inplace
running build_ext
skipping 'utils/bbox.c' Cython extension (up-to-date)
skipping 'utils/nms.c' Cython extension (up-to-date)
skipping 'nms/cpu_nms.c' Cython extension (up-to-date)
rm -rf build
bash make.sh
In file included from /home/choas/anaconda/lib/python2.7/site-packages/tensorflow/include/tensorflow/core/framework/op.h:23:0,
                 from roi_pooling_op.cc:22:
/home/choas/anaconda/lib/python2.7/site-packages/tensorflow/include/tensorflow/core/framework/op_def.pb.h:12:2: error: #error This file was generated by a newer version of protoc which is
 #error This file was generated by a newer version of protoc which is
  ^
/home/choas/anaconda/lib/python2.7/site-packages/tensorflow/include/tensorflow/core/framework/op_def.pb.h:13:2: error: #error incompatible with your Protocol Buffer headers. Please update
 #error incompatible with your Protocol Buffer headers.  Please update
  ^
/home/choas/anaconda/lib/python2.7/site-packages/tensorflow/include/tensorflow/core/framework/op_def.pb.h:14:2: error: #error your headers.
 #error your headers.
  ^
/home/choas/anaconda/lib/python2.7/site-packages/tensorflow/include/tensorflow/core/framework/op_def.pb.h:22:35: fatal error: google/protobuf/arena.h: No such file or directory
 #include <google/protobuf/arena.h>
                                   ^
compilation terminated.

I hope someone can help me....Thanks

I tried to degrade my protobuf=2.5.1, but import tensorflow make error

conda install pip
pip install tensorflow

not conda install tensorflow

all right, I have solve this problem~


⚠ Spryr has degraded performance

In 49f9f5f, Spryr (https://spryr.com) experienced degraded performance:

HTTP code: 200
Response time: 6521 ms

Resolved: Spryr performance has improved in 7ddc1ee after 11 minutes.