Disable conpty when accessibility mode is disabled

The way conpty reprints screens causes a lot of issues for assistive technology.

Verified by breaking into TerminalProcess and making sure that useConpty is false.


Vite bundle CSS different than dev with shadcn-svelte

Describe the bug
(I'm not sure if this is an issue for https://github.com/huntabyte/shadcn-svelte or this repo.)
I am creating an application with Tauri and using the shadcn-svelte integration of this library, and one thing I noticed is that with the dev mode, I get about half of the intended styling from shadcn-svelte, and half from this component's built-in styles. The white outline around a toast is from the classes applied through toastOptions, but the style for the action button through toastOptions.actionButton to make it white does not apply.

Then, in the final bundle, the card's white outline is gone but the button styling actually starts to work.

This is even more apparent when I try to use richColors.
In dev mode:

The final bundle for richColors looks the same as if I hadn't applied richColors at all.
I understand I can use the unstyled option for the toast, but I was hoping to keep some of the layout styling, like padding and text size. Maybe the answer is that shadcn-svelte should be using unstyled for their integration and needs to handle all of the styling rather than just adding to existing styles.
Reproduction

Create a clean Tauri app with Svelte and TypeScript as your frontend (maybe optional).
Install shadcn-svelte
Install their Sonner component
Set up the Toaster and create a toast
Observe in the dev mode the button styles don't apply, but toast styles do.
Observe that in the final release build, the toast styles don't apply but the button styles do.

Logs
No response
System Info
System:
    OS: Linux 6.5 Ubuntu 22.04.4 LTS 22.04.4 LTS (Jammy Jellyfish)
    CPU: (24) x64 12th Gen Intel(R) Core(TM) i9-12900
    Memory: 4.06 GB / 30.97 GB
    Container: Yes
    Shell: 5.1.16 - /bin/bash
  Binaries:
    Node: 20.16.0 - ~/.local/share/pnpm/node
    npm: 10.8.1 - ~/.local/share/pnpm/npm
    pnpm: 9.7.0 - ~/.local/share/pnpm/pnpm
  npmPackages:
    @sveltejs/kit: ^2.0.0 => 2.5.24
    svelte: ^4.2.7 => 4.2.18
    svelte-sonner: ^0.3.27 => 0.3.27

Severity
annoyance

I've had the same issue.

I think it has to do with the styles order difference between dev and prod because the rich colors are overwritten on prod but not on dev

The classes that overwrite the styles are in [chadcn location]/ui/sonner/sonner.svelte
I removed them to avoid the issue
<Sonner
	theme={$mode}
	class="toaster group"
	toastOptions={{
		classes: {
			// toast: "group toast group-[.toaster]:bg-background group-[.toaster]:text-foreground group-[.toaster]:border-border group-[.toaster]:shadow-lg",
			toast: "group toast group-[.toaster]:shadow-lg",
			description: "group-[.toast]:text-muted-foreground",
			actionButton: "group-[.toast]:bg-primary group-[.toast]:text-primary-foreground",
			cancelButton: "group-[.toast]:bg-muted group-[.toast]:text-muted-foreground",
		},
	}}
	{...restProps}
/>

So it's not caused by this lib after all


Failed on all eval tasks

Language model:  anas-awadalla/mpt-1b-redpajama-200b
Vision encode:  openai CLIP ViT-L/14
finetune model:  pretrained model  checkpoint_gripper_post_hist_1_aug_10_4_traj_cons_ws_12_mpt_3b_4.pth(download from Hugging Face website)
eval_data:  eval_sequences.json
run eval_calvin.py to evaluate model, all task failed. Just like the following gif:

Can you help me solve this problem?
Besides, what are the differences between the models in the two boxes here？

Hi, the default models are trained on ABCD->D dataset, and the ones in the directory are trained on ABC->D dataset (see CALVIN paper for details.)

It is hard to say the reason. Do you make sure all parameters are the same with the downloaded model?

It is hard to say the reason. Do you make sure all parameters are the same with the downloaded model?

I use CALVIN debug dataset. Except for the parameter “cross_attn_every_n_layers”, everything else is the same。The paramer “cross_attn_every_n_layers” used in training is from factory.py file(pretrained model use cross_attn_every_n_layers=1, while i use cross_attn_every_n_layers=4). The training script is as follows:
python train_calvin.py --report_to_wandb --llm_name mpt_3b --traj_cons --use_gripper --fusion_mode post --rgb_pad 10 --gripper_pad 4 --precision fp32 --num_epochs 1000 --gradient_accumulation_steps 10 --batch_size_calvin 6 --run_name RobotFlamingoDBG --calvin_dataset /datasets/calvin_debug_dataset --cross_attn_every_n_layers 4 --dataset_resampled --loss_multiplier_calvin 10.0 --workers 1 --lr_scheduler const --warmup_steps 5000 --learning_rate 1e-4 --save_every_iter 10000 --window_size 4。

Hello, Professor. I have the same question as you. Have you solved it?


140

QUESTION 140
Hotspot Question
You need to identify which blades in the Azure portal must be used to perform the following tasks:

View security recommendations.
Monitor the health of Azure services.
Browse available virtual machine images.
Which blade should you identify for each task? To answer, select the appropriate options in the answer area.
NOTE: Each correct selection is worth one point.

Monitor
Marketplace
Advisor


raise ipfsApiError on http errors

This causes ipfsApi.http.HTTPClient to raise an exception in response to
HTTP errors, rather than successfully returning an error message to the
caller.  This makes it easier to differentiate errors from successful
responses.
Closes #13.

Thanks, this is something I definitely have thought about and this is a great solution.


Can not reimage a VMSS instance - exception

Describe the bug
Command Name
az vmss reimage
Errors:
'VirtualMachineScaleSetVMsOperations' object has no attribute 'reimage'
Traceback (most recent call last):
python3.6/site-packages/knack/cli.py, ln 215, in invoke
    cmd_result = self.invocation.execute(args)
cli/core/commands/__init__.py, ln 659, in execute
    raise ex
cli/core/commands/__init__.py, ln 722, in _run_jobs_serially
    results.append(self._run_job(expanded_arg, cmd_copy))
cli/core/commands/__init__.py, ln 715, in _run_job
    six.reraise(*sys.exc_info())
...
cli/core/commands/__init__.py, ln 330, in __call__
    return self.handler(*args, **kwargs)
azure/cli/core/__init__.py, ln 784, in default_command_handler
    return op(**command_args)
cli/command_modules/vm/custom.py, ln 2785, in reimage_vmss
    return sdk_no_wait(no_wait, client.virtual_machine_scale_set_vms.reimage,
AttributeError: 'VirtualMachineScaleSetVMsOperations' object has no attribute 'reimage'

To Reproduce:
Steps to reproduce the behavior. Note that argument values have been redacted, as they may contain sensitive information.

Put any pre-requisite steps here...
az vmss reimage --instance-id {} --name {} --resource-group {} --subscription {}

Expected Behavior
Environment Summary
Linux-5.4.0-1036-azure-x86_64-with-debian-buster-sid
Python 3.6.10
Installer: DEB

azure-cli 2.17.1

Additional Context

hi @qwordy could you pls help to have a look?

hi @qwordy could you pls help to have a look?

@juan-acevedo-ntt Thank you for reporting this issue. I have found the cause. Will fix soon.

@juan-acevedo-ntt Thank you for reporting this issue. I have found the cause. Will fix soon.

I have submitted a PR to fix it.

I have submitted a PR to fix it.

Release date: 01/19/2021

Release date: 01/19/2021


UI issue with Catalog (regular and machine driver)

Rancher Version: master 6/13

[x] Catalog View Details is too close to description text

[x] Machine Driver Catalog - Too much white space on bottom

[ ] Machine Driver Catalog - Can't tell how to activate an inactive catalog.  Maybe the menu should be active or there should be a button to activate?

[ ] Catalog vs Machine Driver - why is the Image on top in Catalog and on the bottom in Machine Driver?  Should this be consistent across screens?

Version - master 6/14
Verified fixed


Some questions about repeating the results on SParC.

I want to reproduce the result of SParC on my server, and i only download the code and run the run.sh following the README. The model 'saved_42' is chosen to get the final result.

But the final result is only 46.0, which is lower than the results in the paper. Although I repeat a lot of times, I get some similar results like 45.8 or 45.5.

Maybe are the experimental environments  different? or you use some the different parameters, like learning rate or something.
I hope you can give me some suggestions.

I run this code 5 times,  and the average question accuracy was 45.4% and the average interaction accuracy was 26.46%.
If you reproduce the results,  please give me some suggestions. Thank you!

@RandomTuringDuck  Have you reproduced the results on Sparc ?

When I train the model on SParC and run the testing on the saved model using test_sparc_editsql.sh for some reason it throws this error Unexpected key(s) in state_dict: "utterance_attention_module.query_weights".
Can you tell me what's the issue @ryanzhumich ?


[Extensions] Designs get renamed to "Autogenerated"

Current Behavior

In meshmap, whenever we try to import a design and try to give it a name, eg: "cassandra-service" in the below screenshot, it gets updated. But then, when we try to drag-and-drop that design onto the playground, it gets renamed to "Autogenerated".

https://github.com/user-attachments/assets/9ce5323c-2ce4-4d57-8cfa-41fe1d8a249a
Desired Behavior

Design's names shouldn't change to "Autogenerated"
Screenshots/Logs

Environment

Host OS: Mac Linux Windows
Meshery Server Version: stable-v
Meshery Client Version: stable-v
Platform: Docker Kubernetes

Contributor Guides and Handbook

📚 Meshery Build and Release Strategy
🎨 UI Design For Meshery Extensions Figma in Figma (open invite)
📚 Meshery Extensibility Providers
⌨ Meshery API Docs
🙋🏾🙋🏼 Questions: Discussion Forum and Community Slack

Hi @hargunkaur286 ! Can you confirm if you are working on this, otherwise can I work on this issue?

@hargunkaur286, working on it?


Receive non notifications pushes when apps open

Hello for all...
I already know, when I receive and push with "message" and "title" on payload, even the app is closed, a notifications are displayed on my Android.
But if my push don't have this keys on payload, and only "additional_data". Have some way to receive this push without notification, when the app are opened...?

@theinvensi what you do is use a silent background notification as documented here:
https://github.com/phonegap/phonegap-plugin-push/blob/master/docs/PAYLOAD.md#background-notifications
https://github.com/phonegap/phonegap-plugin-push/blob/master/docs/PAYLOAD.md#background-notifications-1
This way you app can react to background pushes without having to be opened.


Improve org chart page

We currently render the org chart by compiling all team pages' "Members" sections.
That is not a bad approach per se, but we do it all in the client at load time, which is noticeable and breaks often. For example, we currently seem to be adding a footer in the middle of the page, and date/time hover tooltips don't work in the dynamic content. The content can also not be searched I assume.
If we want to continue with this, we should look into doing this at build time. But also we should think about what the "ideal" org chart would look like for our handbook – perhaps data taken from the BambooHR API. Perhaps even a real chart (although those don't necessarily scale better, rather the opposite).

I think we should solve this more generally and not over index on the org chart use case. Idea here: https://github.com/sourcegraph/handbook/issues/649

You might be able to achieve this pretty simply by adding a manager field to team.yml.

Discovered a bug on this page: #818

I implemented my idea above for the product team at https://github.com/sourcegraph/handbook/pull/895. If we like it we could expand it to the whole company and replace this page.

Curious if we can close this due to the work done in (#1763)[https://github.com/sourcegraph/handbook/pull/1763], or if we need to explore further?

I haven't been following that work, but the org chart page still says "The org chart is generated automatically from team pages in the handbook (need to edit it?).". Is that wrong?

I just updated the edit instructions via https://github.com/sourcegraph/handbook/pull/1976, I think with that this can indeed be closed.

thanks @jyavorska !


luci-mod-admin-full: improve applyreboot page

This improve applyreboot page and fix problem with luci-nginx that doesn't refresh the page when the router reboot.
Signed-off-by: Ansuel Smith<EMAIL_ADDRESS>

Do we really need those inline styles? You could move them to the material theme CSS and I'll take care of adding appropriate styles to the other themes.

2 class with that styles should be good right?
applyreboot-container
applyreboot-section

@jow- inline style removed... tested with all the other themes

Almost fine :) Can you please replace fieldset with div ?

done @jow-

merged, thanks!


Update _config.yml

I am not sure this should be merged.  I think it would be better for more use cases to update the README's "Before You Begin" section to explain when the base_url is needed and when it isn't.  This is a particular github usage case that may not be true for many users.

@bexelbie Thanks for the explanation here, you are correct. This is a specific case rather than something all users will need.


Incorrect width applied to horizontal bar charts

The width of horizontal bar charts appears to be set to width + margin.left + margin.right which causes the SVG to break out of its parent container.
Expected Behavior
I would expect the resulting SVG to have the exact width set via .width(n).
Current Behavior
The width of horizontal bar charts appears to be set to width + margin.left + margin.right which causes the SVG to break out of its parent container.  If you attempt to subtract the margins from the width before applying it to the chart, the chart elements are squished.
It'd be great if this matched up with the established  margin conventions in d3.
Possible Solution

Steps to Reproduce (for bugs)
Here's an example - https://jsfiddle.net/ru0kqn95/1/
In this example, the green border of the parent container and the red border of the SVG should match and the chart within should fill the space appropriately.  If you remove the left and right margins, the containers will align.
Context
I've had to result to workarounds to get width working.
Your Environment

Version used: GIT HEAD (e7a95a132f0a6e57f51f92de477c6b8a6371222c)
Browser Name and version: Chrome Version 58.0.3029.110 (64-bit)
Operating System and version (desktop or mobile): macOS 10.12.4

Thanks for providing this lib!  I was hoping someone would come along with a library that followed the reusable pattern.

Hi @Caged , thanks for opening the issue!
 We happen to have some inconsistencies in the way we handle the svg creation and use the D3 margin convention.
We definitely need to fix this! We already have a ticket for a helper that should take care of that process within the chart:  #121. The idea would be to use a helper to create the svg elements and add the margin and g groups.
Thanks and sorry for the inconvenience!

Fixed on #256


Advanced JSON Schema support

There's a lot more that can be done to support JSON Schema evaluation, but I just want to draw attention of a couple potential features I brought up in https://github.com/farmOS/farmOS.js/issues/25#issuecomment-956266157, before I close that issue:

provide validation, via AJV
use AJV's type definitions

I have no time-frame for either of these, but they would make a nice addition.

I believe a lot of the work I've done here can be merged into Farmos.js to get that functionality to work.


feat: Refactor codebase by splitting  crawling functions into separate files closes #108

Description
This pull request implements the proposal outlined in issue #108 to refactor the crawl.py file by splitting the functions into separate files based on their relation and functionality.
Additionally, I have written a doc for each file that describes the functions it contains and their purpose. I have also added an overview doc for the module.
The refactored code is more modular and easier to maintain, with each file containing a subset of related functions that perform a specific task. This improves organization, and testing, and reduces complexity, making the codebase easier to navigate for new team members.
This proposal is essential to improving the maintainability of our codebase, and the changes made in this pull request will have a significant impact on the overall quality of our code.
In addition to the refactoring, I have also updated the test files to import from the new module created, ensuring that our test coverage remains intact.
Changes Made

Refactored crawl.py by splitting the functions into separate files based on their relation and functionality
Updated test files to import from the new module created

How to Test

Clone this branch and run the test files using python -m unittest discover command.

Related Issues

Closes #108

@mshudrak  I think the tests are failing because they need to be changed similar to what I did in the test files.
Or what do you think?

I was initially going to make it into an OOP solution but decided to leave it to GSOC when I get accepted hopefully,
and by this change, it can be easily refactored.

Also will help in adding more GCP resources project and after this change, any new resource added will follow best practices.

Overall looks good. Is it safe to assume that you did not change any code inside any of the functions and only rearranged the files?

Yes, that's correct. I did not change any code inside the functions themselves, only rearranged the files to make them more organized and easier to maintain.

Let's delete the empty file. Also, the tests are currently failing. Why is this?

I believe that the failing tests may be due to the recent changes made to the project structure. One possible reason could be related to the import statements used in the test files. I recommend updating the import statements to match the new project structure, similar to what you did in the test file. This should help resolve the failing tests. What are your thoughts on this?

Upon further investigation, I realized that removing the init.py file from the main directory caused errors and shouldn't delete, but now I understood why its there.

Ok, please make sure the tests are still working before we can merge this

Ok, please make sure the tests are still working before we can merge this

I fixed the testing errors in this PR by changing the import statement as see but idk why they arent passing when they are running using github actions

@ZetaTwo working on fixing the last error

@ZetaTwo, I have resolved all the failing tests except for the one related to the list_services function. Although the function remains the same, I am still investigating the cause of the failure. Do you have any insights or suggestions that could help me debug this issue?

Also, @mshudrak any suggestion/guide as to why this test is failing?

The services unit_test is failing because expected output from GCP has changed. Please do not alter the test. All you need is to identify what changed and update tests/services file accordingly.

As I understand the list_services unit test only checks if there is output using the  and all I did was achieved the same goal but using a different method
Thank you for the feedback, I appreciate it. I understand that the expected output from GCP has changed and that we should not alter the test case. My intention with the modification I made to the verify function was simply to ensure that the assertTrue assertion method passed when the list_services method returned a non-empty list which is exactly what the initial test did but in a different way, the initial test used the verify function is being used to check if the list of services returned by list_services contains at least one service
If updating the services file is the best course of action, I will certainly do so. However, if the only change needed is to modify the verify function to correctly check for the expected output, I believe this would be a simpler solution.

@mshudrak Please let me know your thoughts on this, and if there is anything else I can do to help resolve the issue.

We want to check exact output from GCP with what we have in our tests. There is issue regarding relaxing the unit_tests but it is a separate problem that requires a lot of work. For now, we just want to check exact output from GCP in unit_tests.

There is issue regarding relaxing the unit_tests but it is a separate problem that requires a lot of work. For now, we just want to check exact output from GCP in unit_tests.

yeah I get that, I reverted back the unit test change and now it's falling but by going through the output of the list_services and the service JSON they are identical as I can see the only difference I notest is the single quote and double quote

@mshudrak I also remember that on one of my previous PRs the list_services was also falling I think in a similar way and I think you solved it

@mshudrak thank you so much for the guidance btw

I think it complains about
----------------------------- Captured stdout call -----------------------------
Retrieving access token from instance metadata
Successfully retrieved instance metadata
The following line was not identified in the output:
        "title": "sqladmin API (prod)",

Just ignore this test, I will fix it later.

So far we have 2 PRs for refactoring scanner. I think we need to have some generic class for objects creation as well as specific classes for specific GCP resources. Overall, I believe it is the move in the right direction. However, I think it would be  better to have the right solution in the first place without intermediate commits.
Anyway, thanks for PR, I'd link that one in your GSoC application proposal as an example of what you want to achieve with refactoring. I'd also prefer to have some design, discussion with mentors and then implementation, so I'd leave that one for GSoC timeframe.

So far we have 2 PRs for refactoring scanner. I think we need to have some generic class for objects creation as well as specific classes for specific GCP resources. Overall, I believe it is the move in the right direction. However, I think it would be better to have the right solution in the first place without intermediate commits.
Anyway, thanks for PR, I'd link that one in your GSoC application proposal as an example of what you want to achieve with refactoring. I'd also prefer to have some design, discussion with mentors and then implementation, so I'd leave that one for GSoC timeframe.

Thank you for your feedback. I understand your concerns about having the right solution in place without intermediate commits and having a more detailed design and discussion with the mentors before implementing changes. However, I believe that this initial refactoring can be a great starting point for future improvements, and it will make the project structure better and more maintainable. By merging this PR, we can create a solid foundation for the upcoming work and make it easier for both me and other contributors to build upon it. Would you consider merging this PR as a way of improving the project's overall structure and making it easier for future development?

What about a class based approach?

What about a class based approach? some ideas here #113

Actually i had implemented that but left it for gsoc timeframe

changes made are for my gsoc proposal

I am closing this one for now but we can always reopen it if we decided to move forward with this refactoring attempt.


UE5

Just wanted to let you know.
This is also working in UE5.
Changes to do is to remove the engine definition in uplugin and to remove both namespaces GAMEKIT in gamekit_user_gameplay_data_models.h and rebuild that plugin
Cheers and Thanks !

Would love to have a UE5 branch to pull !

Hi HeldOfTheWelt,
I'm glad you were able to find a workaround. Thank you for sharing that here.
We will be working on supporting UE5 soon. We have another issue open as well for the same, which we have left open until we add UE5 support: https://github.com/aws/aws-gamekit-unreal/issues/5
Thank you!


support uv run invoked via subprocess

system='Windows', release='10', version='10.0.20348', machine='AMD64'
uv 0.4.10 (690716484 2024-09-13)
not sure if that's actually working as intended but @charliermarsh's "uv should just elevate the experience/abstract things away" (if I got that right) leads me to thinking this might be something uv wants to handle.
the topic is that process.terminate() terminates uv (I guess), not the python interpreter invoked with uv run, when used via subprocess. example steps to reproduce:
uv init my_foo

# app.py
import tkinter as tk

app = tk.Tk("foo")
app.mainloop()

# main.py
"""
example module just to run a hello world tkinter app via subprocess.
1st invocation gets started and closed as expected.
2nd invocation via `uv run` eliminating the need to find the correct python interpreter, but terminate doesn't close the python interpreter then.
"""
import subprocess
import time
from pathlib import Path

venv_python = (
    subprocess.check_output(
        ["uv", "run", "python", "-c", "import sys; print(sys.executable)"]
    )
    .decode()
    .strip()
)

app = Path(__file__) / ".." / "app.py"

# works and closes the tkinter app from app.py after 3 seconds
process = subprocess.Popen(
    [venv_python, app],
    stdout=subprocess.PIPE,
    stderr=subprocess.PIPE,
)

time.sleep(3)

process.terminate()

# works rather unexpected since it terminates the uv run process I guess
# tkinter app keeps running
process = subprocess.Popen(
    ["uv", "run", app],
    stdout=subprocess.PIPE,
    stderr=subprocess.PIPE,
)

time.sleep(3)

process.terminate()

just experienced this and though it's worth an issue.
greetings,
Marius

Thanks for the report, definitely a bug.
Related to #6738


Change deprecated minio env variables

Codecov Report

Merging #379 (bdd83cb) into master (7a63c01) will decrease coverage by 0.15%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #379      +/-   ##
==========================================
- Coverage   41.43%   41.28%   -0.16%
==========================================
  Files          32       32
  Lines        4817     4900      +83
==========================================
+ Hits         1996     2023      +27
- Misses       2821     2877      +56

Impacted Files
Coverage Δ

assemblyline_core/updater/helper.py
0.00% <0.00%> (ø)

assemblyline_core/metrics/heartbeat_formatter.py
0.00% <0.00%> (ø)

assemblyline_core/dispatching/dispatcher.py
77.12% <0.00%> (+0.39%)
:arrow_up:

assemblyline_core/server_base.py
83.24% <0.00%> (+3.97%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7a63c01...bdd83cb. Read the comment docs.


New command: spo page default get

Usage
m365 spo page default get [options]
Description
Gets the home page for a specific site
Options

Option
Description

-u, --siteUrl <siteUrl>
URL of the SharePoint site.

Examples
Get the home page of a specific site
m365 spo page default get --siteUrl https://contoso.sharepoint.com/sites/Marketing

Default properties
No response
Additional Info
To get to know which page is the current home page, execute this request:
GET https://contoso.sharepoint.com/sites/Playground/_api/Web/RootFolder?$select=WelcomePage

Thereafter, you should retrieve the site page with a GetFileByServerRelativePath request.

Assign this to me please.

...with a GetFileByServerRelativePath request.

assuming this command will return detailed information about the home page and not just the relative URL.

Assign this to me please.

...with a GetFileByServerRelativePath request.

assuming this command will return detailed information about the home page and not just the relative URL.

Yes, the response should look the same as spo page get.

Instead of creating a new command, I'm wondering if we should just enhance spo page get to align it more with other commands where we return default values.
Examples:

#5856
pp environment get
...

What is your stance on this @pnp/cli-for-microsoft-365-maintainers?

Have we considered the alternative of spo page get --default? Also, since pages are web-scopes artifacts, shouldn't we need web URL rather than site URL?

Have we considered the alternative of spo page get --default? Also, since pages are web-scopes artifacts, shouldn't we need web URL rather than site URL?

Fair point about the webUrl. About the --default, it's something I could support, but currently for other commands we are providing nothing to retrieve the default value. Shouldn't we be more consistent here? It's something we can always change in a major release.


New version: HiroshibaKazuyuki.VOICEVOX.CPU version 0.19.1

Pull request has been created with komac v2.3.0 :rocket:
Microsoft Reviewers: Open in CodeFlow

For moderators
This account is automated by Github Actions and the source code was created by CoolPlayLin. If you have any questions about any pull request, don't hesitate to ping Exorcism0666.

[!warning]
With the new version of Komac, numerous Pull Requests may contain bugs or unwanted elements. If such issues arise, please tag russellbanks so that these bugs can be addressed in future updates.

[!important]
Please carefully review these Pull Request before merging. If it is a Pull Request for removing incorrect content and the URLs are issue, free upon manual checking, please close this Pull Request directly. (It is best to inform Exorcism0666 of the closure.)

良い一日をお過ごしください！

Automatic Validation ended with:

Executable C:\Users\validator\AppData\Local\Microsoft\WinGet\Links\VOICEVOX.exe returned exit code: -1073741515

Automated error analysis suggests -1073741515 may mean Dependency on Microsoft.VCRedist.2015+.64 (or .x86).
(Automated response - build 878.)


feature support ordered data non-traverse compaction

This feature mainly handle compaction for ordered data, adding a min_max key for segment and check if rowset are non-overlapping so we can do compaction just move files and modify rowset meta instead of traverse all rows.
The strategy list below:

more than half of rowsets are non overlapping.
all segments are more than 10M
if base compaction, no delete version contains in input_rowsets.

By the way, my test shows that calc min max key does not effect load performance.
Proposed changes
Issue Number: close #xxx
Problem summary
Describe your changes.
Checklist(Required)

Does it affect the original behavior:

[ ] Yes
[ ] No
[ ] I don't know

Has unit tests been added:

[ ] Yes
[ ] No
[ ] No Need

Has document been added or modified:

[ ] Yes
[ ] No
[ ] No Need

Does it need to update dependencies:

[ ] Yes
[ ] No

Are there any changes that cannot be rolled back:

[ ] Yes (If Yes, please explain WHY)
[ ] No

Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 38.53 seconds
load time: 574 seconds
storage size:<PHONE_NUMBER>4 Bytes
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20221026191453_clickbench_pr_34299.html

TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 38.71 seconds
load time: 598 seconds
storage size:<PHONE_NUMBER>3 Bytes
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20221027040554_clickbench_pr_34536.html

TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 38.63 seconds
load time: 565 seconds
storage size:<PHONE_NUMBER>6 Bytes
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20221027192031_clickbench_pr_34776.html

Hi @yixiutt , I think this is a breaking change to Doris core feature, so I created a new branch:
https://github.com/apache/doris/tree/compaction_opt for this feature dev.
And I have pushed the PR: opt compaction task producer and quick compaction (#13495) to it.
I will close this PR, and please push this PR to branch compaction_opt for testing


feat: Badge Variants

Overview

Adds three new badge variants

PR Checklist

[x] Related to designs: https://www.figma.com/file/UA1Um4T8YYvBMrxBdcFJZT/Author-Components?node-id=232%3A47
[x] Related to JIRA ticket: CONPLAT-662
[x] I have run this code to verify it works
[ ] This PR includes unit tests for the code change

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

📬Published Alpha Packages:@codecademy/gamut-kit@0.5.4-alpha.9a8d0f.0@codecademy/gamut-labs@19.16.16-alpha.9a8d0f.0@codecademy/gamut@35.4.4-alpha.9a8d0f.0<EMAIL_ADDRESS>
🚀 Styleguide deploy preview ready!https://61041e76514c0c0747d28817--gamut-preview.netlify.appDeploy Logs

📬Published Alpha Packages:@codecademy/gamut-kit@0.5.4-alpha.354ce2.0@codecademy/gamut-labs@19.16.16-alpha.354ce2.0@codecademy/gamut@35.4.4-alpha.354ce2.0<EMAIL_ADDRESS>
🚀 Styleguide deploy preview ready!https://610431a78e1bd9090e5a4516--gamut-preview.netlify.appDeploy Logs

📬Published Alpha Packages:@codecademy/gamut-kit@0.5.4-alpha.0689c5.0@codecademy/gamut-labs@19.16.16-alpha.0689c5.0@codecademy/gamut@35.4.4-alpha.0689c5.0<EMAIL_ADDRESS>
🚀 Styleguide deploy preview ready!https://61044aebc693341b5dbc7e4a--gamut-preview.netlify.appDeploy Logs

🚀 Styleguide deploy preview ready!https://61045953c6933428efbc7c53--gamut-preview.netlify.appDeploy Logs

📬Published Alpha Packages:@codecademy/gamut-kit@0.5.5-alpha.ce8ee4.0@codecademy/gamut-labs@19.16.17-alpha.ce8ee4.0@codecademy/gamut@35.4.5-alpha.ce8ee4.0<EMAIL_ADDRESS>
📬Published Alpha Packages:@codecademy/gamut-kit@0.5.5-alpha.0c06b0.0@codecademy/gamut-labs@19.16.17-alpha.0c06b0.0@codecademy/gamut@35.4.5-alpha.0c06b0.0<EMAIL_ADDRESS>
🚀 Styleguide deploy preview ready!https://6107f87e86f404003babd1c6--gamut-preview.netlify.appDeploy Logs


feat: Add polygon mainnet support and fix wallet signature issue

This Stack
This pull request introduces a comprehensive end-to-end decentralized application that serves as a prime example for users of our SDK, providing a practical demonstration of various interactions and functionalities, fostering a solid foundation for their own development endeavors.
This PR
Note:  We need this to by pass a viem bug https://github.com/wagmi-dev/viem/issues/606

Adds a new local storage module
By passes the viem issue with a smartAccountOwner custom impl
Adds polygon mainnet

Test Plan
https://github.com/alchemyplatform/aa-sdk/assets/3498866/f7c29d10-3fbd-4c75-a670-0fc30955806a

FYI: you can now sign the data representation of a message: https://viem.sh/docs/actions/wallet/signMessage.html#usage


use prometheus operator in *KS to launch prometheus

https://github.com/stolostron/backlog/issues/18408
https://github.com/stolostron/backlog/issues/18406
Signed-off-by: Marco<EMAIL_ADDRESS>

/retest

I think we need to have the new introduced images ready in downstream and then merge this PR in. otherwise, it will break the feature in DS build.

build with upstream images already passed.
waiting for ds images ready to merge this pr

💯
/lgtm


Feature request: Simple brute force of parameter grid

Hola!
As I understand from the docs, there is no any methods for trial that simply iteratively do through parameter grid.
The closest one is suggest_discrete_uniform(name, low, high, q), but it samples values from the distribution.
What I need: simple brute force of such grids.
For example, for grid (low=1, high=5, q=1) it produces 5 trials with parameter values of [1, 2, 3, 4, 5] (exclusive or inclusive end). Or the same behaviour with suggest_categorical(name, [1, 2, 3, 4, 5]).
Details:
Why I need this: for heavy models I want to see the dependancy of target metrics on simple parameters which behaviour I can predict. For example, if param=0 metrics will be low and if param=1000 metrics should be high and I run study for 3-4 values of param and see that whether it's true or not. It is also useful when you don't know even the rough the boundaries of given parameter.
So the main reason is just to give Optuna predefined grid, run trials on its values and save results. No sampling, no pruning, just brute force controlled by user.
Why suggest_discrete_uniform is not good for this: it samples values, so for (low=1, high=5, q=1) I can have [1, 2, 2, 5, 4] (in general case not complete and with duplicates).
What I do now: several runs of mentioned suggest_discrete_uniform with proper boundaries (for value of 5 it will be suggest_discrete_uniform(low=5, high=5, q=1), and so on for each value I need). Of course, I can just do this by myself but I don't want write another messy optimiser along with Optuna :)
One of the problems (I can see as a user) for this feature is that n_trials should be compatible with number of values in the resulting grid.
If you think it's bad/not useful feature, please let me know before deleting the issue :)
Thanks!

Hi @roseaysina ,
Thanks for your feature request!
We’ve got similar requests even from other users and been planning to implement GridSearchSampler, whose interface will be something like:
import optuna

def objective(trial):
    x = trial.suggest_uniform('x', -100, 100)
    y = trial.suggest_int('y', -100, 100)
    return x ** 2 + y ** 2

grid = {
    'x': [-50, 0, 50],
    'y': [-99, 0, 99]
}
study = optuna.create_study(sampler=GridSearchSampler(grid))
study.optimize(objective)

Hi @g-votte,
Thanks for reply! I am glad that there are another similar requests)
The code snippet looks great. The only question is that for several parameters is it going to be cartesian product of corresponding grids (like all combinations)?


Reduce memory usage

Out of memory error has occurred and I would like to fix it.

I got enough RAM.


Keep type declarations on publish

This fixes https://github.com/helmoski/cycle-selection-driver/issues/5
I've bumped the package version to 2.0.0 because I've upgraded the dependency to @cycle/run from 4.x to 5.x to fix a typing issue
I did not manage to make the bundling work with webpack, so I finally followed this tutorial and used tsc directly: https://marcobotto.com/blog/compiling-and-bundling-typescript-libraries-with-webpack/

Thank you for reporting the issue and creating a pull request. I was able to get it working with Webpack in #8


Request to delete library

Library TeaScript has been replaced with SScript due to TeaScript being another scripting language, so I replaced TeaScript 1.0.1 with SScript 3.0.0.
Link to library:
https://lib.haxe.org/p/TeaScript/

See #604

See #604
SScript and TeaScript are completely the same, that means 2 same libraries with different names will exist in the server but alright.

See #604

SScript and TeaScript are completely the same, that means 2 same libraries with different names will exist in the server but alright.


Remove line to get docker 1.10 in ubuntu vagrants, 1.11 now default

Docker was failing to start when running the ubunutu vagrant demos because a newer version of docker is now the default. We were pulling docker 1.10, but the config for docker 1.11 uses a new flag that 1.10 doesn't know about. Just use the latest 1.11.
Fixes #892

Ran through the docker libnetwork demo and this change worked fine. LGTM (besides the default string comment)

Both vagrant demos are working fine. Merging.


Remove front page readme code example

I feel like the example code given on the front page or readme should be implemented as fully working code example, removed completely or a link should be given to one of the currently existing examples.
The reason being that since the code is not in any way connected to the build system and tests, it can easily get out of date and confuse new users. It also did not help me much in understanding how to use this library initially since I could not just copy the code to a new empty Rust project and run it without getting errors. This is the reason why I implemented the simple NPC example to aid my own understanding of the library.

Thanks for pointing out, and I totally agree. Which documentation did you find most useful? and did you find any documentation to be superflous? I'm thinking about making the README.md a bit more lean and e.g removing the example code you are referring to and just linking to the /examples folder instead. Could also just make a very simple and short example like your /simple_npc_ai example, but mabye even shorter. What do you think?

I think the documentation is fine. If you are new to the concept of behavior trees and read the main page of this crate it may be hard to reason if this crate and behavior trees in general are useful for your own needs. Therefore simple examples where you get to see immediately how the code is executed line by line is most likely the best and quickest way to understand the basics. The documentation then serves secondary purpose when you want to explore the details. This is what I like about Rust's official documentation, simple code examples are always there to get you going fast.
I could possibly write a new example at some point which would focus on being minimal while making use of couple different actions. For anyone else reading this, feel free to try this as this could be a good exercise to learn the library and contribute to it.
I also submitted bonsai-bt to Are we game yet?'s AI section so perhaps it will help to gain more eyes to the project.


Implement InsertWithValues and add missing constants to make ListStore unsorted/sort by default column.

I am playing around with go and I am trying to implement a responsive UI where I need to insert large amounts of rows into a TreeView/ListStore. Scouring the Internet on how to achieve that I found several recommendations to use gtk_list_store_insert_with_values, which was not yet implemented in gotk3.
I have implemented the missing InsertWithValues wrapper by using gtk_list_store_insert_with_valuesv (instead of the varargs one). Keep in mind this is me touching go and cgo pretty much for the first time ever, so maybe you should take a closer look at it and tell me if my approach is correct.
I also added missing constants in this pull request as well, these are for setting a ListStore to unsorted or to sort by the default column. Setting a ListStore to unsorted is related to my problem of making it fast with lots of inserts.

I'm unfamiliar with this method, but shouldn't it be 'InsertWithValuesV' so 'InsertWithValues' can be used by gtk_list_store_insert_with_values?

Depends if the maintainer wants to implement bindings for gtk_list_store_insert_with_values and gtk_list_store_insert_with_valuesv seperately. The v variant is meant to be used by language bindings like gotk3. It is completely equivalent to gtk_list_store_insert_with_values but uses arrays for its arguments instead of variadic arguments.

Ah, I see. Makes sense. 👍


feat(anoncreds): auto create link secret

As discussed in July 6th WG call, here we add an optional configuration parameter for  anoncreds-rs and indy-sdk modules that makes holder services to auto create a default link secret if no one has been created yet. This check is performed only when it is actually needed (i.e. when creating a credential request) rather than at agent initialization.
It defaults to true, meaning that normally it will not be needed to the consumer to do any specific logic to use AnonCreds as a holder.
Superseeds #1491 and fixes #1490

Codecov Report

Merging #1521 (98b8913) into main (08cdf1b) will increase coverage by 19.52%.
The diff coverage is 53.84%.

@@             Coverage Diff             @@
##             main    #1521       +/-   ##
===========================================
+ Coverage   62.14%   81.67%   +19.52%
===========================================
  Files         773      945      +172
  Lines       17955    22637     +4682
  Branches     3046     3924      +878
===========================================
+ Hits        11159    18488     +7329
+ Misses       6261     3883     -2378
+ Partials      535      266      -269

Impacted Files
Coverage Δ

...ckages/anoncreds-rs/src/AnonCredsRsModuleConfig.ts
14.28% <0.00%> (ø)

packages/anoncreds/tests/legacyAnonCredsSetup.ts
75.75% <ø> (ø)

packages/indy-sdk/src/IndySdkModuleConfig.ts
77.77% <0.00%> (ø)

tests/e2e-test.ts
100.00% <ø> (ø)

...ncreds-rs/src/services/AnonCredsRsHolderService.ts
3.52% <14.28%> (-82.54%)
:arrow_down:

...sdk/src/anoncreds/services/IndySdkHolderService.ts
8.02% <14.28%> (ø)

packages/anoncreds/src/utils/linkSecret.ts
85.71% <85.71%> (ø)

packages/anoncreds/src/AnonCredsApi.ts
71.27% <100.00%> (+53.97%)
:arrow_up:

packages/anoncreds/src/index.ts
100.00% <100.00%> (ø)

packages/anoncreds/src/utils/index.ts
100.00% <100.00%> (ø)

... and 463 files with indirect coverage changes


Make ApiSchema GET Contract consistent for all api Types

Because of the weirdness, clients have to write custom code to extract the exact schema
application/vnd.ms-azure-apim.swagger.definitions+json
{
   "properties" : {
    "contentType": "application/vnd.ms-azure-apim.swagger.definitions+json",
    "document" : "json schema here"
    }
}

But for application/vnd.ms-azure-apim.xsd+xml or application/vnd.oai.openapi.components+json or application/vnd.ms-azure-apim.wadl.grammars+xml
{
   "properties" : {
    "contentType": "application/vnd.ms-azure-apim.swagger.definitions+json",
    "document" : {
          "value" : "api schema here"
         }
    }
}

Is there a approximate ETA on this?

we are planning to release this change in the api-version 2019-08-01, which should go out by the end of September 2019. We are clubbing multiple other changes and hence it will take time.

@solankisamir is there a timeline for when this'll become available in the Swagger too?

@tombuildsstuff, this got delayed and we are just starting on it on the service side changes

@solankisamir any updates?

Any updates solankisamir?

@solankisamir any news? Is there an approximate ETA when we can expect a fix?
Seem the resolution of multiple issues and improvements in the Azure Terrafrom provider are blocked because of that one here. 😢
Thx!

The implementation (and data returned) will stay exactly the same, but the documentation/specification will be changed.
Instead of 2 current contracts specifications:
"contentType": "",
"document":
and
"contentType": "",
"document":
{
"value":"",
}
We will have only one:
{
"properties" : {
"contentType": "application/vnd.ms-azure-apim.swagger.definitions+json",
"document" : {
"value" : " <> "
"definitions" : { <<JSON object descriping types definitions if JSON based (swagger or openApi)>> }
}
}
}
So new contract may contain either "value" or "definitions" filled depending on the content type.
It already works this way right now, but documentation is just unclear.

The documentation changes should be released till the end of the year.

The documentation changes should be released till the end of the year.

Any place we can track the progress besides here?

First of all: Happy new year! 😊🎉

The documentation changes should be released till the end of the year.

Which brings me directly to my question. As end of the year is now over 😉 what is the current progress of this?
Because multiple issues of resources in the Azure Terraform Provider are blocked by this I am very curious when this get finally fixed.
Thx
Jonas

The documentations update completed month or two ago, but it's still in review/publishing stage. At the same time, the question: why it blocks the customer? The documentation changes were described above, so it can be sent to the customer now.

Good question.
@tombuildsstuff or @solankisamir can you please elaborate a bit why this issue here is still blocking several issues in the Azure Terraform Provider Project.
For example: terraform-providers/terraform-provider-azurerm#5096
Thx!

@J0F3 , I checked the item you asked about. In addition to the documentation, customer is using the Azure SDK generated by the specs, which are not updated yet. Specs will be updated together with the documentation. So customer will need to wait till we released 2019-12-01 version. Plan was 01/01/2020 but postponed because of release freezes / reviews.

Ah ok. Thank you @vfedonkin  you for looked into it.

@arifsundrani It looks like https://github.com/Azure/azure-rest-api-specs/pull/8225 was merged on Jan 29th. Does that merge unblock this issue?

@hctv19  I’m not sure as I am just following along. I believe @solankisamir would be able to answer your question.

Not yet. This PR is also required before we can regenerate SDK: #8393

@vfedonkin looks like they finally got #8393 merged, so I think this should be unblocked now

Also gently pinging @solankisamir on this PR since #8393 has been resolved

@solankisamir @vfedonkin Is there anything else needed before this can be approved and merged?

Any update on this? This is the only item that is required to support API Management consumption model via terraforms.

@Harmindersingh05, just yesterday we got signed all required PRs and now preparing the nuget package. Should be ready in nearest days.

Go package is released
https://pkg.go.dev/github.com/Azure/azure-sdk-for-go/services/apimanagement/mgmt/2019-12-01/apimanagement?tab=doc


Parse hashtags in tweets

Right now, tweets are displayed as texts and hashtags appear like that : {tweet text} {Hashtag} {tweet...}.
The goal of this is issue is to parse hashtags in a tweet to display them just like on twitter {tweet text} #{hashtag} {tweet...}

Hi, I'll fix a look on this one

I think it is already being worked on there have been 2 forks since the creation of this issue :/

I've take a look on the other issues and didn't found the one you mentioned, which one it's?

I opened #37 if you want then


Model Option to configure Popup Windows WindowState

added IModelViewPopupWindowState.PopupWindowState

ttt

ttt

ttt

Installer lab build 18.1.603.06 includes commit Model option to configure Popup Windows WindowState #219,Model option to configure Popup Windows WindowState #219 that relate to this task. Please test if it addresses the problem. If you use nuget add our NugetServer as a nuget package source in VS

Installer lab build 18.1.603.06 includes commit Model option to configure Popup Windows WindowState #219,Model option to configure Popup Windows WindowState #219 that relate to this task. Please test if it addresses the problem. If you use nuget add our NugetServer as a nuget package source in VS

Installer lab build 18.1.603.21 includes commit Model option to configure Popup Windows WindowState #219 that relate to this task. Please test if it addresses the problem. If you use nuget add our NugetServer as a nuget package source in VS

Closing issue for age. Feel free to reopen it at any time.
.Thank you for your contribution.


Big-O Performance

Great to see a library like this. I would love to see the Big-O performance of each fuzzy algorithm displayed so I know what size of data I can it for and maybe some advice about pros and cons.
I'm doing some fuzzy matching for accounting purposes ("McDonalds": "is this a business expense? probably not") and I wouldn't know which algo to pick to save the most time

Hello @theronic. Basically, all the library's algorithms can be thought as O(n), n being the size of your strings except for Levenshtein which is O(m * n) which is really O(n^2) in most cases.
To sum up: every distance except for Levenshtein is O(m + n) where m is the length of the first string and n the length of the second (this obviously simplifies to O(n)). And every phonetic algorithm & stemmer is O(n) where n is the length of the given string.
So usually Big O is not very useful to determine the practical performance of those algorithm which are basically trivial in complexity but can hide a certain amount of constant operation under the hood? What I mean is that computing a metaphone code is more expensive than computing the soundex because the latter needs way less operations while still having the same overall time complexity.
What's more, it's rather the difficulty of the fuzzy matching algorithm that must be considered. Are you performing clustering, fuzzy search? Most of the naive version of the algorithms solving these problem are quadratic thus negating the need to even consider the complexity of the stemmers/distances etc. since you are computing pairwise information. But to be able to scale up, you need guarantees on the distances such as triangle inequality etc. and this often means that you will accept using Levenshtein even if its complexity is bad. But I could help you a bit more if you detail your use case, if you want to.

Also, usually people tend to focus more on the algorithm's precision and its adequation to the use case rather than its inherent complexity. This library is now a bit old and I have moved to developping more algorithm for the Talisman library. It comes with an interactive documentation that lets you try the algorithms on line so you can better choose one.


ninja-build package request

ninja-build is a modern make replacement aiming for speedy builds
https://ninja-build.org/

ninja-build-1.8.2 should now be available.


NEXT-7997 - Add dropdown display for variant properties fixes shopwar…

1. Why is this change necessary?
Currently the only options to display the variant switches are as radio buttons. It's not possible to have the variant switch shown as dropdown.
2. What does this change do, exactly?
This change adds a new option to the property display type. Also the display in the frontend was changed, that properties with display type 'select' are shown as select-elements instead of radio buttons.
3. Describe each step to reproduce the issue or behaviour.

Add variants to a product
Go to frontend
All properties are displayed as radio buttons

4. Please link to the relevant issues (if any).
#229
5. Checklist

[ ] I have written tests and verified that they fail without my change
[x] I have squashed any insignificant commits
[x] I have created a changelog file with all necessary information about my changes
[ ] I have written or adjusted the documentation according to my changes
[ ] This change has comments for package types, values, functions, and non-obvious lines of code
[x] I have read the contribution requirements and fulfil them.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.Sebastian Lember seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.Sebastian Lember seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.

I have created a Testing Installation for this Pull Request. It will be available at https://github.sw6.ovh/instance?number=258 in the next minutes.

I have created a Testing Installation for this Pull Request. It will be available at https://github.sw6.ovh/instance?number=258 in the next minutes.

@sebi007 Approved. Thank you for your contribution!

@sebi007 Approved. Thank you for your contribution!


sebastian/comparator should be an explicit dependency

Laravel Version
9.52.16
PHP Version
8.1.28
Database Driver & Version
No response
Description
I'm running phpunit 9.6 using the PHAR build. When calliing $response->assertJson() I see the following error:
Tests\Feature\Api\Users\UserProfileControllerTest::invoke_withRequest_shouldReturnNewAuthorizedUserDetailsShouldReturnReferenceIdValue
Error: Class "SebastianBergmann\Comparator\ComparisonFailure" not found

/var/www/html/vendor/laravel/framework/src/Illuminate/Testing/Constraints/ArraySubset.php:78
/var/www/html/vendor/laravel/framework/src/Illuminate/Testing/Assert.php:40
/var/www/html/vendor/laravel/framework/src/Illuminate/Testing/AssertableJsonString.php:295
/var/www/html/vendor/laravel/framework/src/Illuminate/Testing/TestResponse.php:641
/var/www/html/tests/Feature/Api/Users/UserProfileControllerTest.php:110

The namespace for the class inside the phar is PHPUnitPHAR\SebastianBergmann\Comparator\ComparisonFailure. So yes the problem is obvious, namespace doesn't match.
Solution:
illuminate/testing should not rely on transient dependencies. These dependencies should be required explicitly.
This issue seems to be related: https://github.com/laravel/framework/issues/36393
Steps To Reproduce

Run phpunit using the PHAR build
Create a phpunit test case and run it

<?php

class FooTest extends Illuminate\Foundation\Testing\TestCase
{
    public function testBar(): void
    {
        $response = $this->get('/');

        $response->assertJson([]);
    }
}

Hey there,
Unfortunately we don't support this version of the library anymore. Please check out our support policy on which versions we are currently supporting. Can you please try to upgrade to the latest version and see if your problem persists? If so, please open up a new issue and we'll help you out.
Thanks!


[WIP] Matching content in our doctests

This PR solves issue #189 in order to match the content in our doctests.
I updated all the sources in the texthero folder - the main issue is in the scatterplot function, in visualization.py, where the 3D representation on the browser does not show anything (WiP).
I also updated the file CONTRIBUTING.md in order to inform the project contributors to match as much as possible the doctests in their examples / tests.
To finish, I also updated some doctests in order to add a new line between the doc and the source code sometimes (for clarity), to remove extra whitespaces, etc...

Hi @jbesomi,
I have an issue about the return of replace_stopwords for Python 3.6.
Based on the runners, the doctests for Python 3.6 are not valid due that replace_stopwords filters the punctuations: https://travis-ci.com/github/jbesomi/texthero/jobs/454997146.
However, the doctests for Python 3.X (with X >= 7) are valid because replace_stopwords does not filter the punctuations... As an example, this is output of the runner for Python 3.8: https://travis-ci.com/github/jbesomi/texthero/jobs/454997148.
Do you have any idea about this issue?
It does not seems, in the code, that there is a specific code version for Python 3.6 and another one for the other Python versions...

Hi @k0pernicus, thank you for your PR! Amazing 🎉
Regarding the issue with replace_stopwords, probably this is due to the regex pattern. I will investigate that and get back to you. For you to know, we were thinking about adding a tokenization function and require all preprocessing functions to receive an already tokenized function, to avoid this kind of problems (for this function, for instance, we would have to go through the list of tokens and remove the stopwords).

Hi @jbesomi, thank you for the update :)

For you to know, we were thinking about adding a tokenization function and require all preprocessing functions to receive an already tokenized function, to avoid this kind of problems[...].

Great!
Do not hesitate if you want to test this feature and integrate in this PR, I would be glad to help!

Hi @jbesomi ,
Do you have any news about this issue please? :)

Hi @jbesomi ,
Do you have any news about this issue please? :)

Hi @k0pernicus,
I've intensively thought about this and come to the conclusion that it's better for both of us developers and for all Texthero users to have all preprocessing functions to accept an already Tokenized Series. See here #145 for a complete discussion on the subject. Would you like to help with #145 too? Once implemented, writing replace_stopwords will be much easier, hence we will be able to integrate this PR too.

Hi @k0pernicus,
I've intensively thought about this and come to the conclusion that it's better for both of us developers and for all Texthero users to have all preprocessing functions to accept an already Tokenized Series. See here #145 for a complete discussion on the subject. Would you like to help with #145 too? Once implemented, writing replace_stopwords will be much easier, hence we will be able to integrate this PR too.

Hi @jbesomi,
I would be glad to help for this issue, I can take a look starting tomorrow about #145.

Hi @jbesomi,
I would be glad to help for this issue, I can take a look starting tomorrow about #145.

Thank you @k0pernicus !

Thank you @k0pernicus !


fix: import of EvaluationDataset in testset_schema

EvaluationDataset is imported only for type checking, but it is required in runtime for Testset.to_evaluation_dataset.
fixes #1515

Seems like already fixed in #1516


Propose data staging approach to kopp14

The requirement is to save intermediate data to a dedicate data directory

Thank you @mturilli for jumping on this issue.  Your rapid fix does address the need for an intermediate data directory for kopp14-icesheets stage1.task1, but the same fix would need to be applied to every task...which seems cumbersome.
After thinking about our discussion earlier, I agree that the intermediate data directory isn't really necessary.  I'm thinking I'll remove the hard-coded references to the relative data directory.  I'll set it up so that only relevant output from the tasks are downloaded back to the local machine and then apply the organizational scheme.
If you think this approach is appropriate, I'll go ahead and make the changes on the fix/issue14-15 branch and submit a pull request.

Absolutely, please feel free to iterate on your code as you see it fit and no PR will be needed as you are the developer of this code. I will be the one making PRs when suggesting contributions for your review. Let me know whether you need further help with the testing.

The commit referenced above takes care of this issue.  SLR module code now looks for input and produces output in the same directory in which the SLR module code is run.  I use the download_output_data feature within EnTK to download output from the SLR module and direct it to the user's experiment directory.


Conventional Commits

Many of the other IoT SDK's started using conventional commits. Just wanted to propose it to see if it's something this repo would want to do as well
Link to Conventional Commits

There is a burden on each developer when following these patterns.  Unclear what we would use this for.  If there are specific tools/process that need this please add more details and reactivate.


security-secrets-setup says it succeeded when it also says it fails (and it did fail)

🐞 Bug Report
Affected Services

 The issue is located in: security-secrets-setup
Is this a regression?
maybe?
Description and Minimal Reproduction
clone fuji branch of edgex-go
$ ./cmd/security-secrets-setup/security-secrets-setup -confdir ./cmd/security-secrets-setup/res generate
level=ERROR ts=2019-10-31T15:16:32.496926328Z app=edgex-security-secrets-setup source=logger.go:73 msg="logTarget cannot be blank, using stdout only"
level=ERROR ts=2019-10-31T15:16:32.497171655Z app=edgex-security-secrets-setup source=main.go:124 msg="CertConfigDir from config file does not exist in: ./res"
level=INFO ts=2019-10-31T15:16:32.507093231Z app=edgex-security-secrets-setup source=main.go:128 duration=10.184285ms msg="security-secrets-setup complete"

note that the referenced files from cmd/security-secrets-setup/res/configuration.toml in the git tree don't actually exist when run from a different directory, so this is expected to fail, however we shouldn't have the last message in the log above where it says security-secrets-setup is complete because it didn't complete, it failed
🌍  Your Environment
Deployment Environment:
EdgeX Version: fuji @ dd2af2191e85b0217a30ea176a345c30e0df5ac9

however we shouldn't have the last message in the log above where it says security-secrets-setup is complete because it didn't complete, it failed

I think the intent of the message is to indicate the application (known as security-secrets-setup) execution is complete and not that it completed successfully.  What, if anything, would @anonymouse64 propose for alternate wording?

is to indicate the application (known as security-secrets-setup) execution is complete and not that it completed successfully

But why do we need a message saying that execution is complete? I would just propose that in the error case we don't have this message since it's misleading. It could perhaps be reworded to say something silly like "done executing k thx bai" but I don't see the need for such a message, especially considering that anything needing to monitor the execution status of security-secrets-setup should be using Consul and not searching through log messages.
Additionally, I would be confused if security-secrets-setup did something else after it failed to load CertConfigDir, so it seems the error message about not loading stuff from CertConfigDir seems sufficient information for me to tell that the execution is done

But why do we need a message saying that execution is complete?

It's there because someone (not me) put it there.  I'm not advocating that it is needed.  Just attempting to understand what you would expect as an alternative.
It sounds to me like the simple fix is to remove the message altogether.  Do you (@anonymouse64) concur?

yes removing it is what I would expect, thanks


Add BusinessLogicSyscallHandlerStruct

Codecov Report

Merging #279 (8a9aea6) into 0.11 (4aa8d77) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             0.11     #279   +/-   ##
=======================================
  Coverage   93.50%   93.50%
=======================================
  Files          46       46
  Lines        4650     4650
=======================================
  Hits         4348     4348
  Misses        302      302

Impacted Files
Coverage Δ

...rc/core/syscalls/business_logic_syscall_handler.rs
85.05% <ø> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Fix typo in CMakeLists.txt

Since you've contributed to the project, I'd like to ask you if it is okay to put your GitHub ID on the contributor's list?

totally fine ok ;)

@gst
I hope you've been well!
It's been a long time since you made a contribution to this repository, which I deeply appreciate!
I was going to put your ID contributor's list on the coming update (at the time, in 2021), but I had some issues that I couldn't get my hands on this project. I'm now back on it, and your GitHub ID will be on the contributor's list from today onwards!
Many thanks for the contribution again! :)


how can I solve this?

bug:
how can I solve this?
(imw) maomao@maomao415:~/Codes/image-matching-webui$ python ./app.py Traceback (most recent call last):   File "/home/maomao/Codes/image-matching-webui/./app.py", line 2, in <module>     import gradio as gr   File "/home/maomao/anaconda3/envs/imw/lib/python3.10/site-packages/gradio/__init__.py", line 3, in <module>     import gradio.components as components   File "/home/maomao/anaconda3/envs/imw/lib/python3.10/site-packages/gradio/components/__init__.py", line 1, in <module>     from gradio.components.annotated_image import AnnotatedImage   File "/home/maomao/anaconda3/envs/imw/lib/python3.10/site-packages/gradio/components/annotated_image.py", line 12, in <module>     from gradio import utils   File "/home/maomao/anaconda3/envs/imw/lib/python3.10/site-packages/gradio/utils.py", line 353, in <module>     class AsyncRequest:   File "/home/maomao/anaconda3/envs/imw/lib/python3.10/site-packages/gradio/utils.py", line 372, in AsyncRequest     client = httpx.AsyncClient()   File "/home/maomao/anaconda3/envs/imw/lib/python3.10/site-packages/httpx/_client.py", line 1395, in __init__     proxy_map = self._get_proxy_map(proxies, allow_env_proxies)   File "/home/maomao/anaconda3/envs/imw/lib/python3.10/site-packages/httpx/_client.py", line 216, in _get_proxy_map     return {   File "/home/maomao/anaconda3/envs/imw/lib/python3.10/site-packages/httpx/_client.py", line 217, in <dictcomp>     key: None if url is None else Proxy(url=url)   File "/home/maomao/anaconda3/envs/imw/lib/python3.10/site-packages/httpx/_config.py", line 336, in __init__     raise ValueError(f"Unknown scheme for proxy URL {url!r}") ValueError: Unknown scheme for proxy URL URL('socks://<IP_ADDRESS>:7891/')

You can try to close the network proxy in the system settings and restart a new terminal to run python app.py

unset all_proxy & unset ALL_PROXY can solve this problem

unset all_proxy & unset ALL_PROXY can solve this problem

Using this method does not make the code run successfully, in my case

You can try to close the network proxy in the system settings and restart a new terminal to run python app.py

If I turn off the proxy in the system settings, I will lose network contact with the outside world and cannot continue to download the data and third-party libraries required for successful operation after running ./app.py.

You can try to download the models manually and put them in corresponding folders with the proxy open, then run app.py without the proxy.


Is Haste supposed/known to work on FreeBSD?

I am trying now, for the first time, to install Haste on my PC-BSD laptop; this is essentially a thin wrapper around FreeBSD 10.3-RELEASE-p5.
With haste-compiler, I am still using  8ac3ae991bb08b41c6a92d5e1eee831941fc800a .
Identical procedure (involving a custom installation of GHC-7.10.3) works on Linux.
On the PC-BSD box I get very low-level errors from haste-boot, so my first suspicion is that maybe Haste hasn't been tried on FreeBSD yet?
Downloading Google Closure compiler...
Reading package info from "libraries/rts.pkg" ... done.
Warning: Topdown solver is deprecated
Resolving dependencies...
Configuring ghc-prim-<IP_ADDRESS>...
Building ghc-prim-<IP_ADDRESS>...
Installed ghc-prim-<IP_ADDRESS>
Reading package info from "ghc-prim-<IP_ADDRESS>.conf" ... done.
Warning: Topdown solver is deprecated
Resolving dependencies...
Configuring integer-gmp-<IP_ADDRESS>...
Building integer-gmp-<IP_ADDRESS>...
Installed integer-gmp-<IP_ADDRESS>
cleaning...
Warning: Topdown solver is deprecated
Resolving dependencies...
Configuring base-<IP_ADDRESS>...
Building base-<IP_ADDRESS>...
Failed to install base-<IP_ADDRESS>
Build log ( /usr/home/kahl/.haste-cabal/logs/base-<IP_ADDRESS>.log ):
Configuring base-<IP_ADDRESS>...
Building base-<IP_ADDRESS>...
Preprocessing library base-<IP_ADDRESS>...
In file included from include/Rts.h:216:0,
                 from Flags.hsc:32:
include/rts/storage/Block.h: In function 'Bdescr':
include/rts/storage/Block.h:171:8: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
     ((((W_)p &  MBLOCK_MASK & ~BLOCK_MASK) >> (BLOCK_SHIFT-BDESCR_SHIFT))
        ^
include/rts/storage/Block.h:172:9: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
      | ((W_)p & ~MBLOCK_MASK)
         ^
In file included from include/Rts.h:217:0,
                 from Flags.hsc:32:
include/rts/storage/ClosureMacros.h: In function 'GET_CLOSURE_TAG':
include/rts/storage/ClosureMacros.h:205:12: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
     return (StgWord)p & TAG_MASK;
            ^
include/rts/storage/ClosureMacros.h: In function 'UNTAG_CLOSURE':
include/rts/storage/ClosureMacros.h:211:26: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
     return (StgClosure*)((StgWord)p & ~TAG_MASK);
                          ^
include/rts/storage/ClosureMacros.h:211:12: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
     return (StgClosure*)((StgWord)p & ~TAG_MASK);
            ^
include/rts/storage/ClosureMacros.h: In function 'TAG_CLOSURE':
include/rts/storage/ClosureMacros.h:217:26: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
     return (StgClosure*)((StgWord)p | tag);
                          ^
include/rts/storage/ClosureMacros.h:217:12: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
     return (StgClosure*)((StgWord)p | tag);
            ^
include/rts/storage/ClosureMacros.h: In function 'LOOKS_LIKE_INFO_PTR_NOT_NULL':
include/rts/storage/ClosureMacros.h:247:45: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
     StgInfoTable *info = INFO_PTR_TO_STRUCT((StgInfoTable *)p);
                                             ^
include/rts/storage/ClosureMacros.h: In function 'LOOKS_LIKE_CLOSURE_PTR':
include/rts/storage/ClosureMacros.h:258:32: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
     return LOOKS_LIKE_INFO_PTR((StgWord)(UNTAG_CLOSURE((StgClosure *)(p)))->header.info);
                                ^
In file included from include/Rts.h:209:0,
                 from Flags.hsc:32:
include/rts/storage/ClosureMacros.h: In function 'stack_frame_sizeW':
include/rts/storage/InfoTables.h:390:53: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
 #define GET_LARGE_BITMAP(info) ((StgLargeBitmap*) (((StgWord) ((info)+1)) \
                                                     ^
include/rts/storage/ClosureMacros.h:431:20: note: in expansion of macro 'GET_LARGE_BITMAP'
         return 1 + GET_LARGE_BITMAP(&info->i)->size;
                    ^
include/rts/storage/InfoTables.h:390:33: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
 #define GET_LARGE_BITMAP(info) ((StgLargeBitmap*) (((StgWord) ((info)+1)) \
                                 ^
include/rts/storage/ClosureMacros.h:431:20: note: in expansion of macro 'GET_LARGE_BITMAP'
         return 1 + GET_LARGE_BITMAP(&info->i)->size;
                    ^
In file included from include/Rts.h:210:0,
                 from Flags.hsc:32:
include/rts/storage/ClosureMacros.h:434:36: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
         return 2 + BCO_BITMAP_SIZE((StgBCO *)((P_)frame)[1]);
                                    ^
include/rts/storage/Closures.h:254:61: note: in definition of macro 'BCO_BITMAP'
 #define BCO_BITMAP(bco)      ((StgLargeBitmap *)((StgBCO *)(bco))->bitmap)
                                                             ^
include/rts/storage/ClosureMacros.h:434:20: note: in expansion of macro 'BCO_BITMAP_SIZE'
         return 2 + BCO_BITMAP_SIZE((StgBCO *)((P_)frame)[1]);
                    ^
In file included from include/Rts.h:234:0,
                 from Flags.hsc:32:
include/rts/Threads.h: At top level:
include/rts/Threads.h:53:1: error: unknown type name 'pid_t'
 pid_t  forkProcess     (HsStablePtr *entry);
 ^
In file included from include/Rts.h:237:0,
                 from Flags.hsc:32:
include/rts/Stable.h: In function 'deRefStablePtr':
include/rts/Stable.h:40:29: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
     return stable_ptr_table[(StgWord)sp].addr;
                             ^
compiling dist/build/GHC/RTS/Flags_hsc_make.c failed (exit code 1)
command was: /usr/local/bin/gcc -c dist/build/GHC/RTS/Flags_hsc_make.c -o dist/build/GHC/RTS/Flags_hsc_make.o -fno-stack-protector -D__GLASGOW_HASKELL__=710 -D__HASTE__=006 -Dfreebsd_BUILD_OS=1 -Dx86_64_BUILD_ARCH=1 -Dfreebsd_HOST_OS=1 -Dx86_64_HOST_ARCH=1 -Iinclude -Idist/build/autogen -include dist/build/autogen/cabal_macros.h -I/usr/home/kahl/.haste/x86_64-freebsd-haste-<IP_ADDRESS>-ghc-7.10.3/include -I/usr/local/packages/CalcCheck5/lib/ghc-7.10.3/include/
ExitFailure 1ExitFailure 1haste-cabal.bin: Error: some packages failed to install:
base-<IP_ADDRESS> failed during the building phase. The exception was:
ExitFailure 1
haste-boot: Command `/usr/local/packages/CalcCheck5/bin/haste-cabal' failed with error code 1

$ uname -a
FreeBSD hermes 10.3-RELEASE-p5 FreeBSD 10.3-RELEASE-p5 #0: Thu Jun 30 03:52:15 UTC 2016     root@amd64-builder.pcbsd.org:/usr/obj/usr/src/sys/GENERIC  amd64

It's never been tested on any BSD except for OSX, I'm afraid. The build is quite brittle at the moment, but I imagine that once the build is fixed everything should probably work. Unfortunately I don't have time to spare supporting BSD, but I'd gladly merge any related PRs.

On OSX, are you using clang or gcc?
Any pointers where to start on this, if I get to looking into it in detail?

It's the clang GCC wrapper, I'm afraid. The best place to start is probably the system includes (as well as the ones for base). The current set is essentially a pre-configured set of Linux GHC includes, beaten with a hammer just enough times to compile on OSX and Windows too. Properly generating these from autoconf (or just beating them with a hammer some more...) would likely go a long way towards fixing the problem.

Thank you! --- That at least gives me an idea.
However, I am still wondering why haste-boot compiles any C to native code at all?
I thought that the native code compilation is already done, and haste-boot prepares
the JavaScript libraries?


Does not work on Rails

I've implemented on a rails project and it simply does not work, height of the container is just set to 0px.
Is there a fix for this or can anyone recommend a similar plugin which is rails friendly?

I am definitely using this on Rails and it is working fine, this is pretty much pure JS and SASS though so it should run on just about any framework.
Assuming you are loading the js and css fine, you may want to ensure that the images are loaded before initting it. I use imagesLoaded (https://github.com/desandro/imagesloaded) running as such:
$('.image_container').imagesLoaded(function(){
$('.image_container').twentytwenty();
});

@dahliacreative I am going to close this for now, if this is still an issue for you please reopen and if possible provide a link to the page where it is breaking or the sample output html.
I believe you may have a problem where you are not loading the javascript or css correctly

This was so long ago, I don't even remember what project it was. I think I ended up building my own.


Fix metric export

Codecov Report
Attention: 13 lines in your changes are missing coverage. Please review.

Comparison is base (8e9998a) 76.06% compared to head (ea89e98) 75.50%.

Files
Patch %
Lines

...in/java/prometheus/exporter/jgc/metric/Metric.java
31.57%
12 Missing and 1 partial :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@             Coverage Diff              @@
##               main      #82      +/-   ##
============================================
- Coverage     76.06%   75.50%   -0.56%
  Complexity      224      224
============================================
  Files            13       13
  Lines          1667     1682      +15
  Branches        163      166       +3
============================================
+ Hits           1268     1270       +2
- Misses          320      332      +12
- Partials         79       80       +1

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


2 small things

Antonia needs to do a screen shot of the "home page" for the WT workshop, describing features.

[x] Can we remove the

"You are using the new PomBase site, released on October 24, 2017. Read more ..."
banner?

[x]  I think it would be better to keep the advanced search at the top of the menu items (currently displaced  to second by JBrowse)

Can we remove the
"You are using the new PomBase site, released on October 24, 2017. Read more ..."

I've removed it but left the code in place in case we need a prominent announcement in future.

I think it would be better to keep the advanced search at the top of the menu items

I've changed things that so JBrowse is second in the list.


Allow several font sizes for Subhead headings

What are you trying to accomplish?

This PR allows adjusting the (font) size of headings in the Subhead component. A Hubber asked in Slack why Subhead headings in PVC have a font size of 24px, but a font size of 20px in PRC and in Figma. Rather than change the font size and potentially mess with a bunch of existing usages in dotcom, I have chosen to introduce two heading sizes, large (the default), and medium.
Screenshots

Large
Medium

Integration

No changes necessary in production.
Risk Assessment

[x] Low risk the change is small, highly observable, and easily rolled back.
[ ] Medium risk changes that are isolated, reduced in scope or could impact few users. The change will not impact library availability.
[ ] High risk changes are those that could impact customers and SLOs, low or no test coverage, low observability, or slow to rollback.

Accessibility

No new axe scan violation - This change does not introduce any new axe scan violations.

Merge checklist

[x] Added/updated tests
[x] Added/updated documentation
[x] Added/updated previews (Lookbook)
[x] Tested in Chrome
[x] Tested in Firefox
[x] Tested in Safari
[x] Tested in Edge

Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.

Thanks for working on this, @camertron!
Let's make sure to get an approval from someone on Primer Design on this PR before merge.


Getting Neo4j doesn't work - Windows7

Setup:
Win7
Python: 2.7.13
maven: 3.3.9
Java Version : 1.8.0_40
According to this: https://github.com/brianfrankcooper/YCSB/pull/814/files/20d60a7f7f43121c7f1a4cc6f16112f67d917448
I tried to accomplish, but as I try to run this command :"mvn -pl com.yahoo.ycsb:neo4j-binding -am clean package" I get this error :
[INFO] Scanning for projects...
[ERROR] [ERROR] Could not find the selected project in the reactor: com.yahoo.ycsb:neo4j-binding @
[ERROR] Could not find the selected project in the reactor: com.yahoo.ycsb:neo4j-binding -> [Help 1]
[ERROR]
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR]
[ERROR] For more information about the errors and possible solutions, please read the following articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MavenExecutionException
Any advices?

Accomplished it :+1:  Just download neo4j snapshot-12


Light/Dark theme

As a user, I can toggle between light/dark theme, so that I can customize the app to my preferences.

Due to time constraints, we should modify this user story to only include the dark theme as shown in the UI mockup.

As a user, I want an aesthetically pleasing and intuitive user interface.


Add license text of our logos (Fuzzy Land and Los Fuzzys) visible below them

Sth like:

The logo for "Fuzzy Land" and "Los Fuzzys" can be used for any legal purpose under three conditions:

The logos' author must be attributed by name & link to his web site; Thomas Mayr (thomay.at).
It must be mentioned that this is a logo in the context of "Fuzzy Land" or "Los Fuzzys", depending on the used logo.
The text for the two aforementioned points must be put visible on the same page/area as where the logo is put.
If you are not sure how to add one of our logos to your article, web page, etc., contact us ;)

Would you add/edit sth?

I am not sure about Markenrechte & effects on logos, but maybe just do

https://creativecommons.org/choose/
--> https://creativecommons.org/licenses/by-nd/4.0/

Ok, after a discussion with @stefan2904 we decided to put instead a copyright on our logos/symbols.
So, sth like:
Logo(s) designed by Thomas Mayr (thomay.at), copyright by LosFuzzys.

so cc allows everyone to use it as long as they attribute it to us, even commercially.
and marken-/logo-rechte forbid to use it as other team's logo, I suppose, but i am not sure.

@stefan2904 nice links! So:

LosFuzzys Logo by Thomas Mayr is licensed under a Creative Commons Attribution-NoDerivatives 4.0 International License. If any changes of the logo are made, sharing/distribution of the adapted work is not allowed.

So, currently our copyright text:
CTF operated by LosFuzzys. Infrastructure sponsored by netcup. Logo by Thomas Mayr. All tasks and writeups are copyrighted by their respective authors.

Similar as on https://ctftime.org/.


Change to baseimage-kasmvnc

As suggested in #51
All credit to @ilkersigirci, I just pulled in the recommended changes

Closing in favor of #55 which is far more thorough


Expose tabIndex as configurable

@danwarner I'm curious why you've closed this. Seems like a reasonable request to me. Is there some way to accomplish it without a change to the module?

I'm looking for this feature too, is there a reason I'm not seeing for why this was closed or is it worth me working on a PR?

+1


Cannot load M3U8 file: Crossdomain access denied

I tried to play my HLS stream but the player (JWt): http://.../live/demo.m3u8 always said that: No 'Access-Control-Allow-Origin' header is present on the requested resource
My srs.conf also have:
http_server {     enabled         on;     listen          8080;     dir             ./objs/nginx/html;     crossdomain on; }
I also added Access-Control-Allow-Origi to my Nginx configuration:
`
location / {
root   html;
index  index.html index.htm;
add_header 'Cache-Control' 'no-cache';
add_header Access-Control-Allow-Origin *;
add_header Access-Control-Expose-Headers Content-Length;
    }
    location /live/ {
        types {
            application/vnd.apple.mpegurl m3u8;
            video/mp2t ts;
        }
        root html/;
        add_header Access-Control-Allow-Origin *;
        add_header Access-Control-Expose-Headers Content-Length;
    }

`
Please help me solve this issue. Thank you very much!

SRS fixed it.


MFA documentation

https://github.com/CartoDB/help/issues/174

PR is done in the help repo, waiting for the deploy/public release