Add tests for simulating empty body response

For issue #123 - it appears that null and undefined body responses are already handled OK by pretender. I've added tests for this, and an extra line in the README per the issue comments.

@fraziern can you verify that this is what actually happens? My understanding was that XHR responses for no bodies had null (or maybe undefined) response texts, not empty strings?

@trek good question. I did some testing and it looks like request.response is undefined, while request.responseText === ''. So adding strictEqual(request.response, undefined); and strictEqual(request.responseText, ''); to the tests doesn't break them.
If this is causing issues elsewhere, I can take a look, or I can just add the request.response check to the tests.

Weird, I just did a small test:
var express = require('express');
var app = express();

app.get('/', function(req, res){
  res.send('<html></html>')
});

app.get('/notfound', function(req, res){
  console.log("1")
  res.status(404).end();
});

app.listen(3001);

/*
  httpRequest = new XMLHttpRequest();
  httpRequest.open('GET', 'http://localhost:3000/404', true);
  httpRequest.send(null);
  httpRequest.onreadystatechange = function(){
    if (httpRequest.readyState === XMLHttpRequest.DONE) {
      debugger;
    }
  }

*/

and both httpRequest.response and httpRequest.responseText are "". What browser did you test in?

I was testing with the existing test framework, rather than a separate setup.
I was able to replicate your results in Chrome. However, if I change the responseType to json first, it returns the results I got using only QUnit asserts.
Server:
// app.js
var express = require('express');
var app = express();
var path = require('path');

app.get('/', function(req, res) {
    res.sendFile(path.join(__dirname + '/index.html'));
});

app.get('/save', function(req, res){
  console.log("1");
  res.type('json').status(200).send().end();
});

app.listen(3000, function () {
  console.log('Example app listening on port 3000!');
});

Client:
// index.html
<!DOCTYPE html>
<html>
  <head>
    <meta charset="utf-8">
    <title></title>
  </head>
  <body>
Testing 1, 2, 3...
  </body>

  <script type="text/javascript">
  xhr = new XMLHttpRequest();
  xhr.responseType = 'json';
  xhr.open('GET', 'http://localhost:3000/save', true);
  xhr.send(null);
  xhr.onreadystatechange = function(){
  if (xhr.readyState === XMLHttpRequest.DONE) {
    debugger;
  }
}
  </script>
</html>

Taking a look at the XMLHttpRequest spec, I think this is the correct result:

The response attribute must return the result of running these steps:
If responseType is the empty string or "text"
If state is not loading or done, return the empty string.
Return the text response.
Otherwise
If state is not done, return null.
If responseType is "arraybuffer"
Return the arraybuffer response.
If responseType is "blob"
Return the blob response.
If responseType is "document"
Return the document response.
If responseType is "json"
Return the JSON response.

So I think where that leaves us, is we'd want pretender to properly mimic this behavior, yes? I'm taking a look at this further.

so I think where that leaves us, is we'd want pretender to properly mimic this behavior, yes?

ya, we should mimic spec behavior


pull request for e2e test at 11/30/2016 13:56:05

:white_check_mark: Validation status: passed
For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


fetchAssoc() fails with freshly created Reader

Issue summary
I need to pre-process a CSV file that was given to me that contains a number of columns with duplicate names. In order to process this file I am creating a reader, writing some columns with a writer, and then getting a reader:
$reader = Reader::createFromPath('path/to/file.csv');
$write = Writer::createFromStream(fopen('php://temp', 'r+'));
$columns_to_extract = [1, 2, 3, 4, 5, 43];

foreach ($reader->fetch() as $row) {
    $write->insertOne(array_intersect_key($row, $columns_to_extract));
}

$reader = $write->newReader()->setOffset(0);

And then I pass the $reader into another class that uses fetchAssoc():
function process(Reader $csv)
{
    foreach ($csv->fetchAssoc() as $row) {
        // do stuff with row
    }
}

This works fine for other CSVs, but as soon as I add this pre-processing step, I get the following error:
InvalidArgumentException: the specified row does not exist or is empty in importer/vendor/league/csv/src/Reader.php on line 338

Call Stack:
    0.0002     233496   1. {main}() importer/bin/import:0
    0.0255    1522728   2. League\Csv\Reader->fetchAssoc() importer/bin/import:17
    0.0255    1522928   3. League\Csv\Reader->getAssocKeys() importer/vendor/league/csv/src/Reader.php:247
    0.0255    1523208   4. League\Csv\Reader->getRow() importer/vendor/league/csv/src/Reader.php:281

System informations
(In case of a bug report Please complete the table below)

Information
Description

League\Csv version
8.2.0

PHP/HHVM version
5.6.29

OS Platform
osx

Standalone code, or other way to reproduce the problem
See description.
Expected result
No error.
Actual result
Exception thrown.

Applying the following patch resolves the issue:
--- src/Reader.php	2017-02-21 10:51:56.000000000 -0600
+++ src/Reader.php	2017-02-21 10:51:52.000000000 -0600
@@ -329,7 +329,7 @@
     protected function getRow($offset)
     {
         $fileObj = $this->getIterator();
-        $fileObj->setFlags(SplFileObject::READ_AHEAD | SplFileObject::SKIP_EMPTY);
+        $fileObj->setFlags(SplFileObject::READ_CSV | SplFileObject::READ_AHEAD | SplFileObject::SKIP_EMPTY);
         $iterator = new LimitIterator($fileObj, $offset, 1);
         $iterator->rewind();
         $line = $iterator->current();

For whatever reason, the following code works:
foreach ($reader->fetch() as $row) {
    $write->insertOne(array_intersect_key($row, $columns_to_extract));
}

$reader = Reader::createFromString((string) $write);

@shadowhand it works because the latter uses SplTempFileObject while the first example uses a userland StreamIterator to enable Writer::createFromStream. I'll review your fix and merge it since I have to release a patch version with other fixes hopefully later this week or next week.

My "fix" appears to break other things. :) I'll trust you can sort it out.

@shadowhand while waiting for the patch in your code if you change
$write = Writer::createFromStream(fopen('php://temp', 'r+'));
//by
$write = Writer::createFromFileObject(new SplTempFileObject());

It will work.

@shadowhand the PR #215 should fix your code could you try it please if it's ok for you I'll release the patch

version 8.2.1 is out with the fix

Just confirmed that this fix works. Thanks!


Squared artefacts on image when converting to AVIF

Getting square artefacts at the right edge of the image while converting jpg to avif using av1 compression. Adding some example it might be useful.
Already checked with libheif, as per them bug should be in encoding application.  One observation is, if we scale down speed setting then we are not getting these artefacts.
squared_artefacts_samples.zip

I should mention that this issue only comes with version 0.4.0. Everything works fine with 0.3.4.

Could you please provide more information on how you produced the file?

It was produces using https://github.com/strukturag/libheif library. That library was in turn used inside https://github.com/lovell/sharp to generate image.
When we downgraded Rav1e, the issue went away hence reported here.

If you can provide the settings in use and, even better a command line, it would be great.

Apologies for the delayed response.
Here is the setting I have used. Here speed >5 is causing the issue.
sharp: 0.27.0
libvips: 8.10.5
libheif: 1.10.0
let image = await sharp(inputImage)

  let resizeOptions = {
    kernel: 'lanczos3',
    fastShrinkOnLoad: true,
    width: 388,
    height: null,
    withoutEnlargement: true,
    fit: 'inside'
  };

  let heifOptions = {
    quality: 60,
    compression: 'av1',
    lossless: false,
    speed: 8
  }

  let imageBuffer = await image
    .rotate()
    .resize(resizeOptions)
    .sharpen()
    .heif(heifOptions)
    .toBuffer({resolveWithObject: true});


Documentation page navigation bugfixes

Fixes additional problems found in https://github.com/hydephp/develop/issues/867 regarding functionalities lost during previous refactors. This should fix the last issues and will now match the behaviour of the latest release.
The upcoming documentation site has the index page in the sidebar, this should not be.

Unable to repro this on a local environment. Something is probably wrong with the CI (likely outdated configs)

This was likely caused by the route key not matching the expected. Maybe the dynamic check needs to use the dynamic option.


Module AppRegistry is not a registered callable module (calling runApplication)

Is this a bug report?
(write your answer here)

Have you read the Bugs section of the How to Contribute guide?
(Write your answer here.)

Environment

react-native -v:
node -v:
npm -v:
yarn --version:

Then, specify:

Target Platform:

Development Operating System:

Build tools:

Steps to Reproduce

(Write your steps here:)

Expected Behavior

(Write what you thought would happen.)
Actual Behavior

(Write what happened. Add screenshots!)
Reproducible Demo

(Paste the link to an example project and exact instructions to reproduce the issue.)

React-native Upgrade lead  Module AppRegistry is not a registered callable module (calling runApplication)

I have the same problem

Any update ?

same issue here, crashes android at startup

I recommend opening a new issue that follows the template.

@hramos hi，How did you solve the problem?

same issue here

Same problem here. I wonder why this issue has been closed without any solution. We still have this problem, whether this issue follows the template or not. By the way I am sure there are many other people with the same problem.

I am also getting the same problem. Module AppRegistry is not a registered callable module (calling unmountApplicationComponentAtRootTag) . My debug android apk runs well but when i try to run release build then only i get this error??


proposed : using ci tools

I propose that this repository should be used continuous integration service.
to check code lint, to be analyzing sorce code(go vet or gofmt) , and test automatically when each pull request will be coming.
e.g. https://docs.travis-ci.com/user/languages/go/
I think travis-ci has a high affinity for github.

We will look into this and how to get it setup.

Thank you for adding travis yml file. I have enabled build for this in travis now.


Warnings to avoid hard-to-debug base config errors

I lost three days of debugging because I had copied my vite.config electron setting for base to my web configuration because I didn't realize what would happen when my web-based code called window.history.pushState (as most single-page apps will).  This is in part because the implications of different base settings are not obvious from the documentation, but also because the failures are very hard to debug.
I'm hoping these warnings will save others as I'm guessing it's a common error.

Description

Additional context

What is the purpose of this pull request?

[ ] Bug fix
[ ] New Feature
[x] Documentation update
[ ] Other

Before submitting the PR, please make sure you do the following

[ ] Read the Contributing Guidelines.
[ ] Read the Pull Request Guidelines and follow the Commit Convention.
[ ] Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
[ ] Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
[ ] Ideally, include relevant tests that fail without this PR but pass with it.

Thanks for the PR @UppaJung. Sorry it took us long to get back to you here.
About the second paragraph, electron is currently out of the scope of Vite core (even if the community is using it successfully). I agree with @bluwy here that this information may be better out of the vite docs at this point. The project may change its scope if the user base for electron keeps growing, and I think at that point we may need a separate section for these kind of setups. I hope we see more external posts and starters in awesome-vite from the community in the meantime.
About the first paragraph, would you create a minimal reproduction for the issue you are referring to? We are working on a revamp of how Vite handles relative base (see https://github.com/vitejs/vite/pull/7644) that may help. And if not, it sounds like a real bug to fix. Closing the PR in favor of possibly continuing the discussion in an issue.

electron is currently out of the scope of Vite core

@patek-dev, how are your prospective users and current supposed to know you don't support electron and what is/isn't out of scope? There's nothing on the vite home page that says it's not for use in pages loaded from file:// paths.  In the Comparisons with Other No-Bundler Solutions there's no mention that others might support apps loaded from file URLs whereas vite does not.  As is, it seems inevitable that many other developers will also lose 3 (or more) days of productivity before they finally encounter the sign reading "beware of the leopard"?

Fair enough, the Vite guide starts with "a faster and leaner development experience for modern web projects" which is currently the scope. The phrase could be less vague. I like the way esbuild established its own scope for example https://esbuild.github.io/faq/#upcoming-roadmap. Vite isn't against people using it for Electron, Tauri, Web Extensions, etc. It is just that the focus isn't there at this point, we don't have tests in our CI for these use cases for example, or proper documentation about them. It doesn't sound right to state that they are out of scope in the docs by naming them in our docs. We don't name Laravel and Rails, but these communities are using Vite quite a lot and we have been making an effort to smooth the pain points they find. If there is a PR that is needed for electron, we're probably going to merge it if the complexity justifies the feature.
Thanks for the feedback, it may be a good idea to add a section in the Why Vite guide maybe 🤔


[WIP] No matching versions found

Still work in progress but trying to validate with the playground for issue: https://github.com/Azure/typespec-azure/issues/1647

:x: There is undocummented changes. Run chronus add to add a changeset or click here.
The following packages have changes but are not documented.

:x:@azure-tools/typespec-autorest

Show changes


TiSpark Development Guide

What problem does this PR solve?
Add development guide for TiSpark

do we have a TOC for those dev docs?

/run-all-tests

/merge


Install error on apple m1 silicon

🐞 Bug report
Installing scully in a mac with silicon produce this error
The chromium binary is not available for arm64
Description
I think puppeteer should be upgraded to latest version if possible
https://github.com/puppeteer/puppeteer/issues/6622
💻Your Environment
Angular Version:

Angular CLI: 12.0.1
Node: 16.2.0
Package Manager: npm 7.13.0
OS: darwin arm64

Scully Version:

1.1.4

Angular and NPM 7 are not good friends. The culprit might be there?
If you manually install npm i puppeteer it might just work.  As long as puppeteer doesn't have breaking API changes, it should work.
Can you let us know?

@aaronfrost
The chromium binary is not available for arm64:
If you are on Ubuntu, you can install with:
apt-get install chromium-browser
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR<EMAIL_ADDRESS>install: node install.js
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>install script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

@SanderElias - I tried npm i puppeteer - puppeteer seems installed.
But after that should I do ng add @scullyio/init? (I did and result in the same error)
I also did npm install @scullyio/init - which result in the error again (but even it's successfully how to run :install)
I'm not using Nx
Can we replace puppeteer with playwright?
playwright API is similar, so it should be much issue - I guess

Best solution would be to update the dependency to puppeteer to the most recent version because this has been fixed (see https://github.com/puppeteer/puppeteer/pull/6495) and the current version
https://github.com/scullyio/scully/blob/aa9fd74f3e852d2b584ea84a293865b0d4fa1ebe/package.json#L103
looks rather outdated (as of this writing the most recent version is v10.1.0).
While this project still depends on the old version, you can force to use a newer version of puppeteer in your project by adding the following lines to your package.json file
{
  ...
  scripts: {
    ...
    "preinstall": "npx npm-force-resolutions"
  },
   ...
  "resolutions": {
    "puppeteer": "^10.1.0"
  }
  ...
}

and run npm i afterwards.

Hello! Thank you for your answers!
I tried running npm i puppeteer and with @niklaas solution but I alwais have the error
The chromium binary is not available for arm64.
I don't know why...

@davidecampello In some cases npm i puppeteer does not install chrome, and you need to manually install one.
the steps are described in the puppeteer troubleshooting documentation, which we refer to in the error-message.
Also, there seems to be helpful info over here: https://github.com/puppeteer/puppeteer/issues/6622

thanks @SanderElias, I'll try later

@niklaas Thanks so much for your answer. I didn't know resolutions was a thing until today!
Really though, @scullyio/scully should update puppeteer from 5 (released in Nov 16, 2020) to 10.

Hi, in the latest version of Scully we have made some significant changes. We abstracted the puppeteer renderer to be a plugin and added a playwright render plugin. With this change, we hope to support a bigger variety of browsers and hope that this problem is resolved. Within a week or so we will release a new version, if somebody would verify that this problem then is resolved that would be great,
thanks

I don't see this error anymore with
    "@scullyio/init": "~2.0.5",
    "@scullyio/ng-lib": "~2.0.2",
    "@scullyio/scully": "^2.0.3",

But I am getting
 error TS2739: Type 'Observable<unknown>' is missing the following properties from type 'Observable<ScullyRoute>': _isScalar, _trySubscribe, _subscribe

34     this.article = this.scullyRoutesService.getCurrent().pipe(

Is there a change log or other record of the breaking changes in v2?

@Splaktar We are working on the changelog. Due to "technical difficulties", we seem to have lost a significant part there.
But there was no recent change in that area of the code, so I don't think that should break. This is the code, and it seems untouched for 2 years:
  getCurrent(): Observable<ScullyRoute> {
     /** implementation details here */
  }

I checked the implementation and all the types in there are correct too.
So, I'm not sure if/how your issue is related.

Thank you for looking into this Sander. I don't think that the code changed. It seems like a dependency changed, I.e. RxJs v7

I'm testing with rx7, but I have coded the libs so that they should work with both. What version of rx are you using?

@SanderElias "rxjs": "^6.6.7",, but I'm seeing this in npm ls rxjs
├─┬<EMAIL_ADDRESS>│ └──<EMAIL_ADDRESS>├─┬ UNMET PEER DEPENDENCY<EMAIL_ADDRESS>│ └──<EMAIL_ADDRESS>

Just as a follow up on this, I had to update to RxJS v7 to get this working. It doesn't appear that v2 supports RxJS v6.
Additionally, I don't think that there are any more m1 issues in the latest Scully v2.

I'm closing this issue now, as it is resolved. We recently verified once more that we can run/build/test Scully in full on an M1 machine.


HttpContext lost between HttpClientWrapper and DelegatingHandler

Expected Behavior / New Feature
A DelegatingHandler with IHttpContextAccessor injected can access the current context correctly.
Actual Behavior / Motivation for New Feature
As of version 15.0.7, a custom DelegatingHandler we use now only has access to an empty context and thus httpContextAccessor.HttpContext.User.FindFirst(ClaimTypes.NameIdentifier)?.Value is now null instead of the name like it was in 15.0.6
Steps to Reproduce the Problem

Create a DelegatingHandler that takes in IHttpContextAccessor as an injected dependency.
Register the handler on the route.
Add JWT auth to the route.
In the SendAsync method, call httpContextAccessor.HttpContext.User.FindFirst(ClaimTypes.NameIdentifier)?.Value
See that the value is null

Specifications

Version: 15.0.7
Platform: dotnet 3.1.300
Subsystem: MacOS

Same issue here, version 16.0.1

Hello,
The reason is that after changes done in fe3e8bd23a666daa31ed2e8b00dce2c4630c23a7 a new HttpContext instance is created for every request (or even more instances for aggregated routes). AuthenticationMiddleware (and others) receives a new HttpContext instance, but HttpContextAccessor still has a reference to the original instance. That's why HttpContext obtained by HttpContextAccessor doesn't have any claims.
I've proposed a solution (see pull request #1268 ) where the proper HttpContext will be added as a property to a delegating handler class if the class implements the specified interface.

I tried the code submitted in #1268 (by implementing IDelegatingHandlerWithHttpContext in my DelegatingHandler)  but I experienced that HttpContext.User.Claims were not updated after the first request (so any subsequent requests would use the same user claims).
Steps to reproduce:

Obtain an accessToken for ClientID A (from IdentityServer4)

Use accessToken A towards Route 1 in Ocelot

Observe that HttpContext.User.Claims contained claims present in accessToken A

Obtain an accessToken for ClientID B (from IdentityServer4)

Use accessToken B towards Route 1 in Ocelot

Observe that HttpContext.User.Claims contained claims present in accessToken A

Is this a scenario you've tested?
My workaround-hack for getting user claims to be available in the DelegatingHandler, was to fetch the claims from the httpContext in PreAuthorizationMiddleware and then set them in a custom request scoped RequestData object.
And when I needed that data in the DelegatingHandler, I would just obtain it like this:
var rqData = (RequestData)_httpContextAccessor.HttpContext?.RequestServices.GetService(typeof(RequestData));

@bjartekh thanks, you're right. There's a problem with caching. I'll look into it if I find time.
Unfortunately Ocelot seems to be abandoned after breaking changes with HttpContext :/

@bjartekh if you are interested, I've just fixed the problem with cache.

The Ocelot project seems dead, but if anyone experiences this issue, here is a workaround.
Set and use a IHttpContextAccessor.

Register the IHttpContextAccessor dependency.

// Startup.cs
services.AddHttpContextAccessor();

In your Ocelot configuration OcelotPipelineConfiguration add this code to any Ocelot pipeline middleware that runs after AuthenticationMiddleware. Example used is PreQueryStringBuilderMiddleware, but you can also use PreAuthorizationMiddleware or AuthorizationMiddleware.

// Startup.cs
app.UseOcelot(om => {
    om.PreQueryStringBuilderMiddleware = async (context, next) => {
        var contextAccessor = context.RequestServices.GetRequiredService<IHttpContextAccessor>();
        contextAccessor.HttpContext = context;
    }
}).Wait();

Then inject IHttpContextAccessor into any DelegatingHandler as normal.

Hi @AgentShark !
Thanks for the nice coding recipe!
Does it solve the problem with user claims (aka User property)?
What about to make it as an additional method for the IOcelotBuilder interface of DependencyInjection part of Ocelot?

@raman-m Yes it solves the problems with user claims. AddHttpContextAccessor() can be registered anywhere in services like any other dependency. I don't think there is any such thing as UseHttpContextAccessor(). See Docs

@amweiss  Hi Adam!
I would like personally to thank you for reporting this issue being found in v15.x! Yeah, it was a large upgrade to .NET 5 with a lot of breaking changes made by Tom.
Are you still interested to collaborate on this issue?

Specifications

Version: 15.0.7
Platform: dotnet 3.1.300
Subsystem: MacOS

Are you able to upgrade your solution to .NET 7 with usage of Ocelot v19.0.2 (latest ver.)?
Could you report that the bug is still in v19.0.2 please?
@davipsr  and @bjartekh
Could I pleasantly ask you to check the latest v19.0.2 please?
@AgentShark
What version of Ocelot do you use for your solution proposed in comment on June 26, 2023?

I no longer use this project so I won't be going back to verify.

@amweiss
This is last notification for you...

I no longer use this project so I won't be going back to verify.

Sorry for disturbing you! You can unsubscribe from notifications for this issue.
And I won't address you in discussions anymore.

@raman-m I use v18.0.0 where the issue is still present.

@AgentShark wrote on June 26, 2023:

Yes it solves the problem with user claims.

How can we verify your solution? Do you have some time for contribution?
Could you upload your app sample to GitHub please, as a separate repo?
Also, you can fork the Ocelot repo, create feature branch, and upload your solution as sample in samples folder.
And, please, make a reference to Ocelot project to be sure we test the latest version (.NET 7, v19.0.2).

I don't think there is any such thing as UseHttpContextAccessor(). See Docs

Okay... It seems you misunderstood me.
I meant that we can wrap this your code:
app.UseOcelot(oc =>
{
    oc.PreQueryStringBuilderMiddleware = async (context, next) =>
    {
        var contextAccessor = context.RequestServices.GetRequiredService<IHttpContextAccessor>();
        contextAccessor.HttpContext = context;
        await next.Invoke();
    };
}).Wait();

...as UseAAA() extension for the IApplicationBuilder interface in the OcelotMiddlewareExtensions class.
And/Or
We can develop AddAAA() method for the OcelotBuilder class, which will wrap services.AddHttpContextAccessor() and Ocelot Middleware Configuration as in the Delegating Handlers feature.
I believe we have to extend the OcelotPipelineConfiguration class.
Finally we need to update Ocelot docs:

Middleware Injection and Overrides
Delegating Handlers

See Docs (Access HttpContext from custom components)

Microsoft Learn: Access HttpContext in ASP.NET Core
Exactly! I would say we need to follow the best practices by Microsoft.
I believe your solution is easier one and solid, but it requires some project update with your proposed functionality.

TODO
Create new issue as feature request to design a middleware attached to Ocelot pipeline as the last step before request sending.

+ Accepted

...because of ready PR #1268

@ggnaegi, FYI, the linked pull request #1268 was closed a few days ago due to a significant number of merge conflicts.
I require your assistance to determine the appropriate action for this issue. Since we've implemented the new MessageInvokerPool routing design in the system kernel, it appears this issue may no longer be pertinent. Ultimately, we must replicate the bug testing on the most recent version.

@raman-m Do we have this issue in a multiplexing context?


Github repo "is not a valid dependency for"

Hello, I am having this issue with klarkc/event-infinite-scroll.
Here is the dependencies key in the bower file:
  "dependencies": {
    "polymer": "Polymer/polymer#^1.2.0",
    "iron-ajax": "PolymerElements/iron-ajax#^1.4.0",
    "paper-card": "PolymerElements/paper-card#^1.1.1",
    "numeral": "^1.5.3",
    "iron-image": "PolymerElements/iron-image#^1.2.3",
    "paper-icon-button": "PolymerElements/paper-icon-button#^1.0.7",
    "iron-flex-layout": "PolymerElements/iron-flex-layout#^1.3.1",
    "paper-styles": "PolymerElements/paper-styles#^1.1.4",
    "iron-icons": "PolymerElements/iron-icons#^1.1.3",
    "paper-behaviors": "PolymerElements/paper-behaviors#^1.0.11",
    "flag-icon-css": "lipis/flag-icon-css#^1.4.0",
    "neon-animation": "PolymerElements/neon-animation#^1.2.0",
    "paper-ripple": "PolymerElements/paper-ripple#^1.0.5",
    "textfit-div": "^0.1.0",
    "iron-icon": "1.0.10",
    "web-component-tester": "^5.0.0",
    "promise-polyfill-2": "taylorhakes/promise-polyfill#^6.0.2",
    "event-infinite-scroll": "klarkc/event-infinite-scroll#master",
    "paper-spinner": "^1.2.0"
  },

I don't know why event-infinite-scroll is not working, but might be related to repository key in the bower file of this fork or the use of #master branch.

try using this instead:
 "event-infinite-scroll": "git://github.comklarkc/event-infinite-scroll.git#master",

@klarkc: is this still an issue? @dstockwell @andymutton: ideas of what might be wrong?

The link in the original report seems to work fine now.

Confirmed, working fine now.


Update version to 1.11

High Level Description
Update version to 1.11.0
https://jira.mesosphere.com/browse/DCOS_OSS-1765
Checklist for all PR's

[ ] Included a test which will fail if code is reverted but test is not. If there is no test please explain here:
[ ] Read the DC/OS contributing guidelines
[ ] Followed relevant code rules Rules for Packages and Systemd

Checklist for component/package updates:
If you are changing components or packages in DC/OS (e.g. you are bumping the sha or ref of anything underneath packages), then in addition to the above please also include:

[ ] Change log from the last version integrated (this should be a link to commits for easy verification and review): example
[ ] Test Results: [link to CI job test results for component]
[ ] Code Coverage (if available): [link to code coverage report]

PLEASE FILL IN THE TEMPLATE ABOVE / DO NOT REMOVE ANY SECTIONS ABOVE THIS LINE
Instructions and Review Process
What is the review process and when will my changes land?
All PRs require 2 approvals using github's pull request reviews.
Reviewers should be:

Developers who understand the code being modified.
Developers responsible for code that interacts with or depends on the code being modified.

It is best to proactively ask for 2 reviews by @mentioning the candidate reviewers in the PR comments area. The responsibility is on the developer submitting the PR to follow-up with reviewers and make sure a PR is reviewed in a timely manner. Once a PR has 2 ship-it's, no red reviews, and all tests are green it will be included in the next train.

changed to 1.11-dev

@mesosphere-mergebot bump-ee

the docker smoke test was broken because we didnt have a 1.11 build of the cli, that should have been fixed. rerunning it.

Looks like this is superseded by #2013.

Looks like this is superseded by #2013.

Closing because of this.

@jgehrcke can you please close the one that was opened later? I have been tracking this for a while now.

@jgehrcke can you please close the one that was opened later? I have been tracking this for a while now.

Mhm. We should always start with a JIRA ticket, and every PR should link to its corresponding JIRA ticket. That can help preventing such collision from happening :)
Can you please talk to @lingmann and figure out which PR should survive?

@mesosphere-mergebot bump-ee

@mesosphere-mergebot label  ready for review

mergebot/enterprise/build-status/aggregate is expected as EE has test failures (https://jira.mesosphere.com/browse/DCOS-18664)

@mellenburg  and @sschneid  - Please approve the EE PR as well.

@mesosphere-mergebot label ship-it
The EE failures are due to: (https://jira.mesosphere.com/browse/DCOS-18664)

@mesosphere-mergebot label ship-it


6rd; possibly missing direct connect route?

I'm asking my question here, because it is highly development related.
I operate a repository mirror in Norway, behind an OPNsense firewall. On a couple of occasions I've gotten emails from users saying that they are unable to access my mirror over IPv6. Common for all of them - is that they have the same ISP as me, Altibox, and Altibox uses 6rd. They have confirmed that the mirror is reachable from outside the Altibox network. It doesn't seem to be a problem for all Altibox users, I have a colleague, with Altibox and OPNsense which can connect over IPv6 just fine.
Digging into this I've started to suspect that I may be sending the IPv6 traffic to the border relay, instead of directly to the user, as it should be with 6rd. My understanding is that this is a common misconfiguration on a lot of boxes.
According to rfc5969;
2001:db8::/32 -> 6rd-virtual-int0 (direct connect to 6rd)

If this route is left out, traffic to other 6rd clients, in the same network is sent to the BR when it should in fact be sent directly to the user. And some routers may be rejecting this traffic.
Can anyone confirm, or reject this theory? Ideas for digging deeper?
For those interested, here is an excellent read about 6rd: https://www.cisco.com/c/en/us/products/collateral/ios-nx-os-software/enterprise-ipv6-solution/whitepaper_c11-665758.html

I can't really help with the issue but are you able to get IPv6RD with Altibox working at all with 19.7? Mine stopped working after updating. I've tried with pfsense and that works out of the box

I haven't updated yet, but you are not the first person to experience that. I've got a friend which experienced the same, he also got it working with pfsense.
6RD is not that common, and probably doesn't get tested a lot. I suggest you open a new issue and provide as much information as you can.

This issue has been automatically timed-out (after 180 days of inactivity).
For more information about the policies for this repository,
please read https://github.com/opnsense/core/blob/master/CONTRIBUTING.md for further details.
If someone wants to step up and work on this issue,
just let us know, so we can reopen the issue and assign an owner to it.


Test Results view misses separator between editor and list

There's no separator line between the two components.

Seeing the seperator:


Menu bar unnecessarily changes to hamburger when window width is reduced

This feels similar to #152906 but that's marked as closed.
I don't like the hamburger menu, I want to always see the normal menu bar. It already supports overflowing, but for some reason as soon as the Go menu overflows, it seems to be entirely replaced by the hamburger. I don't understand why this is (when there's already an overflow), and I would prefer it to just move more items into the overflow. The hamburger adds an extra click to get to the File menu (which is almost always the menu I'm using the mouse for).
https://github.com/microsoft/vscode/assets/1078012/a2b654e5-395e-4020-a8a2-30ce63443494
I've tried changing various settings, including setting "Menu Bar Visibility" to "Visible", but nothing seems to fix this (except disabling Command Center, but I feel like that shouldn't be necessary because a) there's an overflow for the menu and b) the command center appears to basically just be a mouse hit target, so could probably shrink in size?).

This feature request is now a candidate for our backlog. The community has 60 days to upvote the issue. If it receives 20 upvotes we will move it to our backlog. If not, we will close it. To learn more about how we handle feature requests, please see our documentation.
Happy Coding!

@sbatten is this not a bug? Why does the menu have an overflow, but not use it here? There is plenty of room for File/Edit/Selection/View but they all vanish and it's not clear to me why.

The goal of this change (we used to do what you are asking) was to try to bring some draggable real estate back to the crowded title bar.

@jrieken any strong feelings here? I believe you had originally suggested the minimum number of menus to be shown before collapsing to a hamburger

If this isn't to be changed, is there way to influence what "Window: New Window Dimensions: default" uses? I don't want any of the other options, I like these new windows being smaller and centered, they're just slightly too small so they trigger this.

No strong feelings. I believe some collapse-to-burger threshold should be kept but the actual value seems a bit aggressive right now

will try reducing the threshold next iteration

With the last upgrade this became worst for me. Now, a part of resizing, if my file has a long name the menu collapses to hamburger. To be honest, for me it's preferable to have the menu than the file name because:

Since I switch very often between recently opened files and projects which are part of the File menu (so at least keep it shown)
The file name can bee seen in the tab already, so I don't think this need to have preference over the menu.
As I don't new big search button (I prefer CTRL + P) I can drag the window by clicking in the window name, so I always have enough space

Also, I think this is also a bug because:

I have the settings set for the Menu Bar Visibility to be always visible, so Why does this get hidden?

If I switch files to another with shorter name, the hamburger does not become a long menu again

My screens are not too big (1366x768 and 1024x768), so this is very noticeable.

LGTM, thanks! 🎉🙂

src/vs/workbench/contrib/inlineChat/browser/inlineChatDecorations.ts.base-sample/package.json.base-sample/package.jsonsrc/vs/workbench/contrib/inlineChat/browser/inlineChatDecorations.ts964437


ECS AMI IDs out-of-date?

Where did you get your ECS AMI IDs in ecs.json?
    "EcsAmiIds": {
      "ap-northeast-1": {
        "id": "ami-8aa61c8a"
      },
      "ap-southeast-2": {
        "id": "ami-5ddc9f67"
      },
      "eu-west-1": {
        "id": "ami-2aaef35d"
      },
      "us-east-1": {
        "id": "ami-b540eade"
      },
      "us-west-1": {
        "id": "ami-5721df13"
      },
      "us-west-2": {
        "id": "ami-cb584dfb"
      }
    }

The ones listed in the Docs match what I see in my AWS Console, which I think should be:
        "EcsAmiIds": {
            "ap-northeast-1": {
                "id": "ami-ce2ba4ce"
            },
            "ap-southeast-2": {
                "id": "ami-3f531f05"
            },
            "eu-west-1": {
                "id": "ami-bd5572ca"
            },
            "us-east-1": {
                "id": "ami-4fe4852a"
            },
            "us-west-1": {
                "id": "ami-2708f363"
            },
            "us-west-2": {
                "id": "ami-8bd4c7bb"
            }
        }

Hi Pete,
The cloudformation file was copied from the firstRun wizard and refers to the slightly older version of the ECS machine image  of august 14th. (amzn-ami-2015.03.f-amazon-ecs-optimized)
The version you refer to (amzn-ami-2015.03.g-amazon-ecs-optimized) is, from september 3rd.
Cheers,
Mark


Change return type to SegmentBuidler.

This forces calling 'build()' after using 'offset' instead of allowing another 'offset' expression which is invalid SQL syntax.

Nice, I've actually been thinking about implementing a way to "guide" users into the correct method calls. I haven't come up with any concrete implementations but it is something I would like to see.


Processing utilities are not compatible with vitest

@metobom tried to use vitest to write unit tests for processing, but he ran into ERR_TRACE_EVENTS_UNAVAILABLE. It seems that Vitest uses a lightwieght v8 engine internally which misses some of the code node_modules (e.g. node:trace_events). See: https://github.com/nodejs/node/blob/main/doc/api/errors.md#err_trace_events_unavailable
A fix would be to remove the imports of the problematic modules. Ideally this should be released as a breaking change.

A similar limitation was encountered in Jest when worker threads are enabled. See: https://github.com/api3dao/airseeker-v2/blob/dfe6d14f540730c947d8fb4f222f91743f8f9053/jest-unit.config.js#L24

I also encountered this error in VS Code when I imported commons from Hardhat config. This causes the solidity extension to hang.
cc: @andreogle I think you encountered this as well.

Agreed on call to just strip away what's necessary in order not to break existing processing snippets.


Visual settings (display)

Visual settings is included in the metadata schema, but not explicitly set by fmu-dataio. Legacy usage of metadata rests on a lot of visual settings being set while generating data, and in the JS workflow defaults have been included in global_variables. This is a pattern that could be continued into fmu-dataio possibly, combined with the option of giving visual settings as input argument.
There is a larger discussion here, however, relating to the responsibility of the data producer vs the data consumer. I think it might be a better (?) pattern to let clients decide visual settings as much as possible. That said, however, visual settings could be the result of domain-specific rules and know-how which could be difficult to convey if not explicitly part of the metadata.
Suggestion, for discussion:
Create a separate VisualSettings object to hold (and calculate) visual settings and pass that to fmu-dataio.ExportData as an argument. If not passed, a skeleton version with default values is included. Experience from JS is that this can quickly escalate, which is why I think keeping it as a separate module is wise. Also, given that patterns might change, I think keeping the interface with the rest of fmu-dataio slim is smart.

Coordinate this with REP and Webviz


supabase start failed after supabase stop --backup + data lost

Bug report

[x] I confirm this is a bug with Supabase, not with my own application.
[x] I confirm I have searched the Docs, GitHub Discussions, and Discord.

Describe the bug
After creating some data in my local supabase instance, and running supabase stop --backup followed by supabase start, I see an error saying that a migration has failed. Running supabase start a second time goes through successfully but all the data from my DB has been lost.
To Reproduce

supabase start
Generate a migration to create a new table
Add some data, like a single user
supabase stop --backup
supabase start
See the error as it tries to apply the migration even though the table already exists.
If you run supabase start again, it will succeed but all the data that was supposed to be backed up will be gone.

Expected behavior
After running supabase stop --backup, I should be able to restart the DB using supabase start without any problems.
Screenshots
Error output after the first supabase start command:
> SUPABASE_INTERNAL_IMAGE_REGISTRY=docker.io npx supabase start

Setting up Edge Functions runtime...
Applying migration<PHONE_NUMBER>3929_create_profiles_table.sql...
Error: ERROR: relation "profiles" already exists (SQLSTATE 42P07)
At statement 0: create table profiles (
  id uuid references auth.users not null,
  username text unique,
  avatarUrl text,
  website text,
  bio text,
  joinedAt timestamp with time zone default timezone('utc'::text, now()) not null,

  primary key (id),
  unique(username)
)
Try rerunning the command with --debug to troubleshoot the error.

System information

OS: macOS
Browser (if applies): NA
Version of supabase-js: 1.53.0
Version of Node.js: v16.15.1

Additional context
My guess would be that the migrations table is not being backed up correctly, resulting in supabase trying to reapply migrations that have already been applied before and resulting in errors.

Yup the migration table isn't created when running local migrations, which is indeed a problem. I will look into it as part of the refactoring PR here https://github.com/supabase/cli/pull/1049

Yup the migration table isn't created when running local migrations, which is indeed a problem.

I see here you are implementing a fix to skip the migrations if there was a backup, are you also planning to have the migration table on local instances?
This would be helpful for us, when we want to migrate the schema of our local instance and not loose any backed up data on the process.

This would be helpful for us, when we want to migrate the schema of our local instance and not loose any backed up data on the process.

Do you mean you want to run a migration on local db that already contains some data? This isn't currently supported by cli but can be worked around by using psql -h localhost -U postgres -p 54322 -f name.sql. We can probably add a migration up command to support such use cases natively though.
If you are talking about backed up data from stop --backup, I believe it's best to keep the db exactly the same after restart. This is why I decided to skip the migrations completely if the backup volume is present.

Do you mean you want to run a migration on local db that already contains some data? This isn't currently supported by cli but can be worked around by using psql -h localhost -U postgres -p 54322 -f name.sql. We can probably add a migration up command to support such use cases natively though.

Yes, that was I was looking for, such command would be much appreciated :pray:

I agree this would be great! Having to reset the entire DB in order to run a migration locally can be a bit tedious


Update RELEASING.md

Add additional step set for new gems.
Fix step for updating google-cloud and stackdriver version requirements.

@jbolinger Good catch, will update, thanks.

@jbolinger: Version step updated.


US-4 support

Added support for US-4 instance.

Sorry about this. Long day. I didn't mean to bring in the other PR on top of this.


DDCE-2536 - updated accessibility-statement/lifetime-isa

Replaced by branch DDCE-2536 with correct GPG commits


🚧 Dev ➾ - Add Ligo mutation testing on NFT scaffold contract

🔗 Epic|Feature Link
No response
🚥 Definition of Done

[X] 🎯 Planning and Design
[ ] 🏎 Dev Implementation (PR merged)
[ ] ✍ Release Notes Added
[ ] 🏆 Product Acceptance

✅ To Do
No response
⚖ Acceptance Criteria
✨ Functional:

[ ] Mutation tests are written and added to the NFT scaffold project
[ ] A guide showing users how to write and execute these mutation tests is published
[ ] Updating the NFT Scaffold documentation

📐 Non-Functional:

[ ] ...

🔭 Scope
🙅♂ Out of Scope:

Unit tests or other tests not related to mutation testing

🧰 Work Description
Ligo now provides native mutation testing as part of its testing framework. There is great value in this for users so this ticket involves adding mutation tests to the nft scaffold project and a guide for how users can write and run these
🦄 Sizing
No response
Code of Conduct

[X] I agree to follow this project's Code of Conduct

Blocked: Claude has reported that the Ligo mutation testing is still a half-baked product and is not ready for production use


Add github reference

[ ]  enhance the performance by using Link-Component of next.js for internal links


Support custom homepage URLs for header link

In every environment, this link takes you to www.gov.uk. This seems unhelpful
when you're in an environment that isn't production as it takes you to a
different environment which can be hard to notice.
This already happens in preview, and now that we are adding GOV.UK Draft (which
is accessed on a different domain), there will be more users looking at the
frontend of GOV.UK in an environment that isn't on the www.gov.uk domain.
This will be paired with a change to static which will use Plek to get the
current website root and pass it in.

:+1:

I think I need to add lines to each of the compilers in @@yield_hash?

Closing until https://github.com/alphagov/govuk_template/pull/146 has been merged/rejected.


GRPC_POLL_STRATEGY=poll bins/opt/end2end_test --gtest_filter=ProxyEnd2end/ProxyEnd2endTest.EchoDeadline/1

Could not reproduce locally.
I0124 23:02:54.997640571    5513 subchannel.cc:603]          New connected subchannel at 0x9dfe90 for subchannel 0x7f5a0c0039b0
I0124 23:02:55.001032691    6018 subchannel.cc:603]          New connected subchannel at 0x7f59e8017240 for subchannel 0x7f5a0c006f70
test/cpp/end2end/end2end_test.cc:1338: Failure
Expected: (response.param().request_deadline() - sent_deadline.tv_sec) <= (1), actual: 2 vs 1
[  FAILED  ] ProxyEnd2end/ProxyEnd2endTest.EchoDeadline/1, where GetParam() = TestScenario{use_proxy=true, inproc=false, credentials='ssl'} (16 ms)
[----------] 1 test from ProxyEnd2end/ProxyEnd2endTest (16 ms total)

Duplicate of https://github.com/grpc/grpc/issues/10092 (which is already fixed)


Landing Zone Example for connected vWan

The Connected Landing Zone assumes a "Hub" vNet to which the LZ "Spoke" is peered, not a vWAN hub.
Given the some of the "In a box" templates (Contoso for Example) deploys a vWAN, it would be great to get a LZ example that connects to the vWAN presumably creating a Microsoft.Network/virtualHubs/hubVirtualNetworkConnections rather than a Microsoft.Network/virtualNetworks/virtualNetworkPeerings resource.

Thanks for the feedback. We recently enabled this in Adventure Works (traditional hub & spoke with virtual network peering), and plan to enable the same for Contoso which is using vWan.

Thanks for the feedback. We recently enabled this in Adventure Works (traditional hub & spoke with virtual network peering), and plan to enable the same for Contoso which is using vWan.

Due to some known platform limitations, we will hold this for now and not enable peering as part of the vwan deployment as that would impact the deployment success rate.


Exporting Home Assistant Configuration failed

hi @grimmpp
just tried out your device discovery which worked fine so far. But when I try to export to home assistant I get the following error:

Exporting Home Assistant Configuration failed!  sender id '0A' of device 'FF-9D-04-8A' is no valid number between 1 and 127.

Then I thought I could uncheck "Export to HA Config" in the right detail panel, but this had no effect.
Am I doing something wrong? Could you please check? I am using the latest version, 0.1.27.
Thanks!

Can you sende me the configure snippet of that device?

 Sorry for that. You need to apply the change. Either push the button or enter when focus in on one of the widgets at the right. The button may be hidden because the layout was not yet properly designed. You can make the console window smaller to see the button.

@grimmpp ok, thanks for the hint. With adapting the UI I can unset the "Export to HA Config". But still I cannot export in the device manager.
I had initially just readout the configuration of a FAM14 and wanted to import that to HA.
So don't know which snippet I could export. Here  a screenshot of one device.

Sorry, it took a bit to understand be issue. I've fixed it and made a new release v0.1.29
Please, let me know if it is working for you.

Maybe it has something todo with that topic:
With current version the HA export still fails for me:
Invalid literal for int() with base 16: 00-00-B0-01

Hello @pa-bs,
I've remove a bug in the export method. Maybe your problem is solved too. Can you please test v0.1.30?

Hi @grimmpp, still failing in line 53 of ha_config_generator.py in 1.30.
I simply replaced the dashes with nothing before, than it works for me.

Got it. Missed to press write to devices with attached USB300 again. Thanks!
Most of the lights and 4/13 of the covers are working now from HA. I will check the ids at the weekend.

hi @grimmpp , I could retest with v0.1.33 and the export is working now smoothly with my configuration.
Thank you very much!


Groq integration broken with latest llama-index version

Bug Description
this will not work anymore:
from llama_index.llms.groq import Groq
llm = Groq(model="llama3-70b-8192", temperature=0)
Settings.llm = llm

Version
had to revert to earlier version
Steps to Reproduce
from llama_index.llms.groq import Groq
llm = Groq(model="llama3-70b-8192", temperature=0)
Settings.llm = llm
Relevant Logs/Tracbacks
No response

What's the error? You tried with updating to latest?
pip install -U llama-index-llms-groq llama-index ?

The error is in an old notebook, but it was something about some abstract class not being able to talk to Groq, etc.   if I have latest packages like you indicate above, it does not work. the latest llama-index-llm-groq + the most recent bersion of llama-index work. but not with this new release of llama-index, the one within the last 24 hrs.

I'll try to recreate in moment and put the traceback here.

@doolingdavidrs21 I think actually you need pip install -U llama-index-llms-openai 👀

https://colab.research.google.com/drive/1bSM1kz2IQlVi4qxxVxDmSMut01v9kHUB?usp=sharing
I don't have an API key, but I think I know what caused the error, and it probably shows up when instantiating. With latest packages, no issue there

here it is:
---------------------------------------------------------------------------
TypeError                                 Traceback (most recent call last)
Cell In[1], line 36
     32 print(hf_token)
     35 from llama_index.llms.groq import Groq
---> 36 llm = Groq(model="llama3-70b-8192", temperature=0)
     37 Settings.llm = llm

TypeError: Can't instantiate abstract class Groq with abstract method _prepare_chat_with_tools

@logan-markewich YES! updating the llama-index-llms-openai package fixed my issue.      So with all the latest and greatest versions, groq is functioning again... Thank you!


Update kustomization.md

Fix typo for the volumeMount field
Running the previous snippets with kubectl apply -k . would generate this error:
error validating ".": error validating data: ValidationError(Deployment.spec.template.spec.containers[0]): unknown field "volumeMount" in io.k8s.api.core.v1.Container;

According to this page, the correct field is "volumeMounts".

CLA: I signed it

/check-cla

/check-cla

/kind cleanup

Hi @AsterYujano .
Thanks for the updates.
Page preview:
https://deploy-preview-28047--kubernetes-io-master-staging.netlify.app/docs/tasks/manage-kubernetes-objects/kustomization/
/lgtm

/approve


Can We do  Conditional Generation for Multiple properties at the same time?

Is it possible to train the model for all the 5 properties at once? if yes , How?

yeah. We have trained the model to condition on 3 properties at the same time. You can do it for 5 in the same way as we have done for 3.

Thank you for the complete overhaul of the codebase and the answer!


Track uses of bug minimizer for eventual paper

It seems useful to collect instances of the bug minimizer being used, since I'm hopeful @achlipala and @Zimmi48 and I will be able to get a paper out of this.
 https://github.com/coq/coq/pull/13969#issuecomment-853937582
ejgallego "you need to refine coqbot otherwise it will collapse with the current criterion; I rarely break the test suite, however I intend to break CI often." https://coq.zulipchat.com/#narrow/stream/243318-coqbot-devs.20.26.20users/topic/CI.20minimization.20feedback/near/235742891 regarding https://github.com/coq/coq/pull/13617
(email from Jim Fehrle subject "coqbot minimizer" 2021-07-25)
https://github.com/coq/coq/pull/14819#issuecomment-910587768 (coqbot on loop)

Early speedbumps and non-uses:

https://github.com/coq/coq/pull/13617 (overeager minimization on infrastructure changes)
https://github.com/coq/coq/pull/9711#issuecomment-850362196 (coq-tools)
https://github.com/coq/coq/pull/12493#issuecomment-864438784, https://github.com/coq/coq/pull/12493#issuecomment-864458525 (infinite loop from build:base)
https://github.com/coq/coq/pull/12493#issuecomment-864457135 (ci-color failure because proxy constant names introduced by the PR change just from moving the Requires around)
https://github.com/coq/coq/pull/13269#issuecomment-854117817, https://github.com/coq/coq/pull/13126#issuecomment-858038186 (missing base artifacts)
https://github.com/coq/coq/pull/13126#issuecomment-857870352 (ci-fiat_parsers, inlining issue)
https://github.com/coq/coq/pull/13126#issuecomment-857870352 (ci-hott, vernac inside proof breaking splitting)
https://github.com/coq/coq/pull/13072#issuecomment-857781670 (request parsing failure)
https://github.com/coq/coq/pull/13072#issuecomment-857804076 (ci-metacoq build system idempotency issue: https://github.com/MetaCoq/metacoq/issues/563)
https://github.com/coq/coq/pull/13072#issuecomment-857885217 (ci-verdi_raft, issue with ambiguous libname prefixes, https://github.com/JasonGross/coq-tools/pull/66)
(need to always upload artifacts, https://github.com/coq/coq/pull/13024)
https://github.com/coq/coq/pull/14536#issuecomment-865359534 (failure of ci-metacoq also present on master)
https://github.com/coq/coq/pull/14492#issuecomment-860114162 (ci-hott, no recognizable error?)
https://github.com/coq/coq/pull/14392#issuecomment-849112996 (base check not finished)
https://github.com/coq/coq/pull/14392#issuecomment-849176004 (ci-perennial, seems to have maybe rebuilt when it should not?)
https://github.com/coq/coq/pull/14391#issuecomment-849062202 (coqbot previously did not support starting minimization when the overall pipeline was still in progress)
https://github.com/coq/coq/pull/14253#issuecomment-862519605 (ci-fiat_parsers, interrupted by timeout)
https://github.com/coq/coq/pull/14234#issuecomment-841864979 (coqbot tagged itself)
https://github.com/coq/coq/pull/13969#issuecomment-846295374 (ci-mathcomp, download issue?)
https://github.com/coq/coq/pull/13969#issuecomment-848805418 (ci-iris coqchk anomaly)
https://github.com/coq/coq/pull/13969#issuecomment-848805751 (ci-equations, mismatch between character locations and byte locations)
https://github.com/coq/coq/pull/13969#issuecomment-848806668 (ci-fourcolor, \r\n line endings on Linux)
https://github.com/coq/coq/pull/13969#issuecomment-848807189 (ci-perennial, perennial passed -noglob, fixed by https://github.com/mit-pdos/perennial/pull/35)
https://github.com/coq/coq/pull/14462#issuecomment-865432124 (ci-metacoq failing everywhere because the commit tested for the base Coq commit was different than the current tip)
https://github.com/coq-community/run-coq-bug-minimizer/commit/c2f176eca216f80e715abbe228603d4fbd637dcf (build log header should inform users of the minimization service that this is where the Coq error message is found)
https://github.com/coq/coq/pull/13107#issuecomment-870663767, https://github.com/coq/coq/pull/14798#issuecomment-903134706 (ci-elpi, hierarchy-builder output test-suite fails with wrapper Coq binaries because file paths are absolutized, reported as https://github.com/math-comp/hierarchy-builder/issues/256 since I don't see a way to fix this without upstream changes)
https://github.com/coq/coq/pull/13107#issuecomment-870664255 (ci-perennial, failure of run-minimizer to strip off -o arguments to coqc)
https://github.com/coq/coq/pull/13107#issuecomment-870663887 (ci-equations, regex for Error: Universe {tmppwdtukmb.112} is unbound. does not match Error: Universe {TestSuite.issues.issue7.110} is unbound.)
https://github.com/coq/coq/pull/13107#issuecomment-870664130 (ci-relation_algebra, syntax error after stripping comments due a notation for ^* plus (x^*) showing up, fixed by https://github.com/JasonGross/coq-tools/commit/f3c3d32386f2765365c42e4590d8528969c9102a)
https://github.com/coq/coq/pull/13107#issuecomment-870663613 (ci-cross_crypto, Cannot find module FCF.FCF, IFS was set wrong for COQPATH handling, fixed by https://github.com/coq-community/run-coq-bug-minimizer/commit/2d6e1f43a8c8ef031a3a91a880365745eec86842)
https://github.com/coq/coq/pull/13107#issuecomment-870664233 (ci-tlc, using symlinks rather than matching paths exactly when rebuilding the ci target resulted in the .v.d files pointing to the wrong dependencies, resulting in non-deterministic build orders and trying to build files before their dependencies finished; fixed by https://github.com/coq-community/run-coq-bug-minimizer/commit/c5073cad137b5b2ecfe3ec974edf7c18a9e57138)
https://github.com/coq/coq/pull/13107#issuecomment-870665002 (ci-bedrock2, The file /github/workspace/builds/coq/coq-failing/_build_ci/bedrock2/deps/coqutil/src/coqutil/Word/Interface.vo contains library Interface and not library coqutil.Word.Interface,  https://github.com/coq-community/run-coq-bug-minimizer/actions/runs/983075891, maybe the exact same absolute path issue, hopefully fixed by https://github.com/coq-community/run-coq-bug-minimizer/commit/c5073cad137b5b2ecfe3ec974edf7c18a9e57138)
https://github.com/coq/coq/pull/13107#issuecomment-872633626 (ci-bedrock2, coqutil fails to fully inline due to https://github.com/JasonGross/coq-tools/issues/67, should be fixed by https://github.com/JasonGross/coq-tools/commit/74f06c5805e4b0bf8217f59c23f39989a9385bbb)
https://github.com/coq/coq/pull/13107#issuecomment-870664569 (ci-coq_performance_tests, Error: /github/workspace/builds/coq/coq-passing/_install_ci/lib/coq/../coq-core/kernel/nativevalues.cmi is not a compiled interface for this version of OCaml., failure to run eval $(opam env) in the right place, finally fixed by https://github.com/coq-community/run-coq-bug-minimizer/commit/8244acedba3adc69d3fc5f6f5f85a604c59c2c8c)
https://github.com/coq/coq/pull/14598#issuecomment-873899991 (ci-compcert, incomplete inlining, neglecting to remove explicit -dump-glob, fixed by https://github.com/coq-community/run-coq-bug-minimizer/commit/6272027c0d12510b99520cee3bd40c95199d5ab9)
https://github.com/coq/coq/pull/14598#issuecomment-874009361 (ci-compcert, .glob files are placed in non-traditional places, regenerating them clobbers .vo files, should be fixed by https://github.com/JasonGross/coq-tools/commit/f1aedb3a0ec4eff59031e6d8c81db4d5501e3f15)
(non-blocking) https://github.com/coq/coq/pull/14579#issuecomment-874992113 (ci-compcert, failure to remove empty sections, should be solved by https://github.com/JasonGross/coq-tools/commit/fdcc5fba858dee96495123b9b53ee8766514033a)
https://github.com/coq/coq/issues/6623#issuecomment-871607628 (missing wget, should be fixed by https://github.com/coq-community/run-coq-bug-minimizer/commit/484e7221bcfaeda0b5c7db1bbd76b0cd8c048a61)
https://github.com/coq/coq/pull/14746#issuecomment-894475827 (ci-unimath, fatal: reference is not a tree: 932fcebde2a08a6c77ce939d711ff4ebd6b4531f)
https://github.com/coq/coq/pull/14819#issuecomment-910587768 (coqbot on loop)
https://github.com/coq/coq/pull/14733#issuecomment-892772832 and https://github.com/coq/coq/pull/14748#issuecomment-898896082 (ci-hott, failure to fully minimize because the local Inductive False gains a universe when put after inlined modules; see https://github.com/JasonGross/coq-tools/pull/75, https://github.com/JasonGross/coq-tools/issues/74, and https://github.com/coq/coq/issues/15073 for more details)
https://github.com/coq/coq/pull/14579#issuecomment-892174014 (ci-perennial, passing coqc gives Error: Unable to locate library iris.algebra.lib.frac_auth, https://github.com/coq-community/run-coq-bug-minimizer/actions/runs/1095458559, transient difference in files that were built in two different versions of perennial --- could maybe use a better error message?)
https://github.com/coq/coq/pull/14746#issuecomment-894317692 (ci-math_classes, failure to fully inline, https://github.com/coq-community/run-coq-bug-minimizer/actions/runs/1105359511, due to timeout of passing coqc being considered a success (oops!), should be fixed by https://github.com/JasonGross/coq-tools/commit/ed441c2713e41fafb6a64be131e8323c904ac686)
https://github.com/coq/coq/pull/14748#issuecomment-952432421, https://github.com/coq/coq/pull/14748#issuecomment-952433049 (the bug minimizer was considering the passing coqc to fail if it times out on based on the failing coqc run, fixed by JasonGross/coq-tools@99d7a6ea16b0b093892f29ddc7c88ab612331984)
https://github.com/coq/coq/pull/14746#issuecomment-960971850 (ci-hott, the bug minimizer could not find the error message in the log due to universes being named based on filename rather than topname, see also https://github.com/coq/coq/issues/15120, fixed by https://github.com/JasonGross/coq-tools/commit/116f50f67709f0cc4e835fb5002e55a1904e9040 and https://github.com/JasonGross/coq-tools/commit/af9fbb2e295ac072578a51e0d6e393e65922fd31)

Not yet diagnosed, but unable to reproduce from the artifact:

https://github.com/coq/coq/pull/14722#issuecomment-890341416 (ci-perennial, UnicodeDecodeError: 'utf-8' codec can't decode byte 0x86 in position 0: invalid start byte on updating with glob file???, https://github.com/coq-community/run-coq-bug-minimizer/actions/runs/1084932272)

Not yet fixed:

https://github.com/coq/coq/pull/13107#issuecomment-870874054 (ci-coq_tools, wrapping the binaries mangles paths)
https://github.com/coq/coq/pull/13107#issuecomment-872424689 (ci-cross_crypto, failure to fully inline due to changes in intuition behavior as a result of Require side effects)
https://github.com/coq/coq/pull/13107#issuecomment-872665027 (ci-bedrock2, coqutil fails to fully inline due to https://github.com/coq/coq/issues/14587)
https://github.com/coq/coq/pull/14722#issuecomment-890353150 (ci-color, CoLoR.Util.Set.* cannot be inlined because Module Set is not valid Coq, https://github.com/fblanqui/color/issues/34)
https://github.com/coq/coq/pull/14798#issuecomment-903141787 / https://github.com/coq/coq/pull/14579#issuecomment-947261717 (ci-verdi_raft, failure to fully inline Verdi.Net, https://github.com/coq-community/run-coq-bug-minimizer/actions/runs/1153876639 / https://github.com/coq-community/run-coq-bug-minimizer/actions/runs/1361582346, details in https://github.com/coq-community/run-coq-bug-minimizer/issues/8#issuecomment-948042551) (instance of https://github.com/coq/coq/issues/3523 on destruct net followed by destruct nwState; reported as https://github.com/uwplse/verdi/issues/130)
https://github.com/coq/coq/pull/14579#issuecomment-947345026 (ci-vst, failure to inline VST.veric.rmaps https://github.com/coq-community/run-coq-bug-minimizer/actions/runs/1361582349, details in https://github.com/coq-community/run-coq-bug-minimizer/issues/8#issuecomment-948041465) (Obligation Tactic := ... follows Require, cf https://github.com/coq/coq/issues/15072, results in change of obligation tactic behavior)

Probably the same as https://github.com/coq/coq/pull/14798#issuecomment-903682395 (ci-vst, failure to inline Flocq.IEEE754.Bits, VST.msl.knot_shims, VST.msl.tree_shares, https://github.com/coq-community/run-coq-bug-minimizer/actions/runs/1158171539)

https://github.com/coq/coq/pull/14579#issuecomment-892338308 and https://github.com/coq/coq/pull/14741#issuecomment-892809568 (ci-fiat-crypto, failure to inline Crypto.Algebra.NsatzTactic because it's incompatible with GlobalSettings --- yet another instance of side effects of Require)
Probable instances of normalize_requires messing up compilation success:

https://github.com/coq/coq/pull/14788#issuecomment-901392205 (ci-compcert, failure to fully inline, https://github.com/coq-community/run-coq-bug-minimizer/actions/runs/1144482830)
https://github.com/coq/coq/pull/14722#issuecomment-890370352 and https://github.com/coq/coq/pull/14722#issuecomment-891004664 (ci-fiat_crypto, resumption somehow messed with supposedly-succeeding error message??? or maybe I'm misreading the log? https://github.com/coq-community/run-coq-bug-minimizer/actions/runs/1085415608)

https://github.com/coq/coq/pull/14788#issuecomment-901071858 (ci-vst, failure to inline Flocq.IEEE754.Bits, https://github.com/coq-community/run-coq-bug-minimizer/actions/runs/1142562994, because Flocq does not install .glob files and we can't really hope to regenerate .glob files living in user-contrib, because we don't know what arguments to invoke coqc with, reported as https://github.com/coq/coq/issues/15074)

In process of fixing

https://github.com/coq/coq/pull/14736#issuecomment-961300322 (ci-cross_crypto, probable failure of passing coqc due to eliminating Require after the the buggy line)

Not yet diagnosed:
PR for testing ci minimization: https://github.com/coq/coq/pull/14328, now https://github.com/coq/coq/pull/14579

TODO: add https://github.com/coq/coq/pull/15487#issuecomment-1013700274 to list for miscomputed / misused glob file


[Bug]: Command search crashes server

/mv version -p output
https://j.mp/3bp0fzM
Server logs
https://pastebin.com/DnXui6U6
Server Version
This server is running Purpur version git-Purpur-1171 (MC: 1.16.5) (Implementing API version 1.16.5-R0.1-SNAPSHOT)

Bug Description
Nothing much to say here but like it is written in the log file entering a /mv ^(.*.*.*)$^ pattern crashes the server when the input pattern is too long.
Steps to reproduce
Enter ^(*.*.*.*.*.*.*)$^ on the minecraft server.
If it isn't creating errors then the pattern wasn't long enough.
Agreements

[X] I have searched for and ensured there isn't already an open or resolved issue(s) regarding this.
[X] I was able to reproduce my issue on a freshly setup and up-to-date server with the latest version of Multiverse plugins with no other plugins and with no kinds of other server or client mods.

Well i found it i wasnt using the latest version of multiverse. The bug is fixed in the v4.3.1 therefor i can close this issue sorry about that.


Icorrect text

[Enter feedback here]
Where the docs says:

will have its GroupName property set to fruits

it should actually says:

will have its GroupName property set to colors

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: a688fe91-33ad-efea-aa29-d56b3c11b42a
Version Independent ID: c0e81ed5-0eb5-a8cc-9eb6-7baf7e464878
Content: Xamarin.Forms RadioButton - Xamarin
Content Source: docs/xamarin-forms/user-interface/radiobutton.md
Product: xamarin
Technology: xamarin-forms
GitHub Login: @davidbritch
Microsoft Alias: dabritch

Microsoft support for Xamarin will end on May 1, 2024 for all Xamarin SDKs including Xamarin.Forms. In preparation for this, all issues and PRs in this repository are being closed.
.NET MAUI is the replacement for Xamarin.Forms, and it's documentation can be found here.


Allow templating of pod annotations

Pull request description
This PR changes the way pod annotations are templated and allows users to use templates in pod annotations.
We want to use this feature in a complex deployment with Helmfile to notice configuration changes that require the pods to restart (e.g. plugin upgrade).
The change is basically non-breaking, but the changed template will result in an additional new line between static and dynamic pod annotations.
A few other examples of charts supporting tpl in pod annotations:

Artifactory
Keycloak

Checklist

[x] I have added unit tests
[x] I have applied the change to all applicable products
[ ] The E2E test has passed (use e2e label)

I guess adding the e2e label is something that you guys need to do?

@pathob
Does this feature change how to reference podAnnotations in the values.Yaml?
Previously we had the following:
podAnnotations:
      reloader.stakater.com/auto: "true"

But after updating to the latest helm chart with these changes we were getting the following error:
cannot unmarshal bool into Go struct field ObjectMeta.spec.template.metadata.annotations of type string
Then we tried commenting that line out and the new helm chart worked fine. Are we missing something here?

Hi @amhibyan
sorry, I didn't mean to break your deployments.
I guess adding a quote to my change would fix it for such cases:
{{- range $key, $value := .Values.podAnnotations }}
{{ $key }}: {{ tpl $value $ | quote }}
{{- end }}

Or as @bianchi2 mentioned, you would need to pass a string by wrapping your annotation value with quotes.
@Atlassian: Let me know if I should provide another PR or whether we can expect users to provide their pod annotations with the correct value type.

I noticed that the Synchrony podAnnotations works fine with our previous method, checked the changes above and noticed that one wasn't changed. Here was ours for Synchrony.
    synchrony:
      enabled: true
      podAnnotations:
        reloader.stakater.com/auto: "true"

It looks like the Keycloak example they have | quote added on.

Here is the error I get when I remove the quotes from the reloader:
Helm upgrade failed: template: confluence/templates/tests/test-shared-home-permissions.yaml:8:8: executing "confluence/templates/tests/test-shared-home-permissions.yaml"  │
│ at <include "confluence.podAnnotations" .>: error calling include: template: confluence/templates/_helpers.tpl:280:19: executing "confluence.podAnnotations" at <$value>: wrong type for value; expec │
│ ted string; got bool

Sorry for the bad question, but what is the best to go about testing something like this before the change is pushed out publicly? Is there a way to reference a specific change/pr? Thanks in advance for getting this pushed so quickly.


args split as characters

I can't get py-mon to work properly when using --args "text".
Instead of invoking my python script with "text" in argv, it send "t", "e", "x", "t".
In main.py code, I dump sys.argv array.
I invoke pymon like this :
"pymon main.py --args config.yaml"
And then I get :
['main.py', 'c', 'o', 'n', 'f', 'i', 'g', '.', 'y', 'a', 'm', 'l']
The argument is correctly parsed by argparse as a string, but then in line 60 of monitor.py you use this construct :
self.process = subprocess.Popen([executable, self.filename, *self.args])
That's where the string is turned into an array, which is wrong.
I've patched it for my own use, since I only need one arg.
But I guess it would be more useful to allow to provide several args on the command line, and use them with subprocess.Popen.

Just fixed this in version 2.0.4! Thank you for reporting :)


Failed to install telepresenceio/telepresence

https://github.com/aquaproj/aqua-registry/issues/812
https://github.com/telepresenceio/telepresence
https://www.telepresence.io/
https://github.com/aquaproj/aqua-registry/pull/155

v2.4.2

Duplicate https://github.com/aquaproj/aqua-registry/issues/833


Image upload fails with no visible error using uploader but fails with exception on edit.

When I click on the image I see:

I try to change the image:

Hey @alinmiron that may be a bug from the recent release, I'll look into fixing it today, thanks


KAFKA-2666: Docs: Automatically generate documentation from config classes

…the way we always planned to

Thanks a lot for the patch. This is super useful! A couple of comments.

If the doc tgz file can include javadoc/, that will be great. If it's not easy to do, the patch is fine as it is.
Also, ConfigDef.toHtmlTable() seems to have a bug. The doc says first sort by required (which is correct), but it's actually sorting by hasDefault. Could you fix it in this patch too?

LGTM overall besides Jun's comments. One general comment: if we are going to make the new producer as the default producer, then we can probably make the new producer docs in the Producer API and Producer Configs section, and list the old producer API / configs as a note as we did for the new producer APIs now instead of a separate subsection.

Oops, I missed @junrao comments! sorry.

Moving Javadoc is a bit more challenging, I'll do it in a separate jira (hopefully I'll have time for it next week)
configDef.toHTML no longer has "required", lack of default is what makes something required and we sort accordingly. See KAFKA-2702 for the discussion and patch.

@guozhangwang: I believe I did mention the new Producer as "Producer" and called the old producer "Old" (see documentation.html)

Thanks for the patch. LGTM

@gwenshap In the API section, we only list the new producer API as a subsection and left an extra link for the old producer APIs; while in the Configs section, we keep both configs of the new and old producers as separate subsections. So I was wondering if we could be consistent and only list an extra link for old producer configs and remove the subsection.

We absolutely could modify the API section. Can you open a JIRA for that? It is unrelated to this PR since the API section is not automated. Another option is to completely remove the API section and just link to the Javadoc.


Prepare for your meetings

Hi Team,
I love the prepare for your meetings fuction and wanted to ask you wheather you could extend this function for various calendars? I am using various calendars and can only see the options for my default calendar. I have several calendars plus managing others calendars as well so I would highly appreciate the possibility of switching between the calendars.
Thanks!!

@helenphamova - Thank you for your feedback! So glad to hear you love the Prepare for meetings feature. I've passed your question on to the team. The Briefing uses the mailbox account settings. I'll let you know if I learn of a way you can do set this up from Outlook. In the meantime, your great suggestion is at least on their list to consider for a future Briefing release.


Can we copy the full directory that has just been created by the command create-react-app myapp to create myapp2, myapp3 ...

Hello,
I wonder if I can copy the full directory that has just been created by the command
create-react-app myapp
To create many other react environments ->  myapp2, myapp3 ... etc?
I used the command :
create-react-app myapp
In a Centos-release-7-3.1611.el7 environment
with :
node -v 7.10.0
npm -v 4.2.0
react version 15.5.4
create-react-app version 1.3.0
It works now, but it was very long. Much more than a few minutes.
And only after three trials, because the command did not finish correctly.
There were only 700 subdirectories that had been created in $ HOME / .npm (dot.npm), whereas there must be about 750 or more.
See here
https://github.com/facebookincubator/create-react-app/issues/2178
I want to build different react environments.
I'm wondering if I can copy all the react/myapp directory
to other
react/myapp2,
react/myapp3
... etc
Even if I know the $HOME/.npm cache should still be there.
Rather than start again and again ( the too long command on my Centos)
create-react-app myapp2
create-react-app myapp3
... etc.
Every time I want to create a new directory react / myapp2, react / myapp3 ... Etc
Because it's too long.
But in a few months, with another versions of modules, it could be a problem to update.

Sure, you can do it.
You could also install Yarn which results in faster installs from cache than current versions of npms.


overflow-scroll can not set dynamically

Ionic version:  (check one with "x")
[x] 1.x
[ ] 2.x
I'm submitting a ...  (check one with "x")
[ ] bug report
[x] feature request
[ ] support request
Current behavior:

There it is :
<ion-content overflow-scroll="the issue is here,can't set synamically only string type supported" scroll="same issue here only true and false, variable not supported"></ion-content>

can not use expression to set in different platforms or situations. And,
can not use ng-attr-overflow-scroll="{{expression here}}" , not working as well.

This issue was moved to driftyco/ionic-v1#231


Decoding Error Handling

I'm currently struggling to find a good way to find more information about an error I am seeing.
invalid character '<' looking for beginning of value
It appears that HTML is being returned. However, I can't find a way to get more information since it is intermittent and I can not manually reproduce it.
What would people think about a custom error on decoding errors. This error would contain the response body and HTTP status code to help in tracking down the issue. Something along the lines of,
type ResponseDecodingError struct {
	Message          string
	HTTPResponseBody []byte
	HTTPResponseCode int
}

I feel like this should contain enough information to allow debugging of errors that the library cannot handle.
Open to thoughts on if there is a better way to handle this.

@dbertouille I've also seen this a few times in the past, it's an annoying issue. I assume it happens here right?
Your proposal would be an easy way to get debugging information for sure, so I think it would be a good addition (see also below). I would suggest renaming HTTPResponseCode to Status and HTTPResponseBody to Body to be more in line with the naming of the existing response error (but not embedding it, probably) and the normal http response in Golang. What do you think?
Just as a sidenote, an entirely other proposal for debugging purposes could be to add a simple logger interface with a simple Debug(...) function to begin with that look like the basic log.Logger type in Golang. This interface could be added to the to the Client struct and then you can supply it with your own logger that supports the logging interface (probably log.Logger in most cases or perhaps logrus). When the logger is non-nil, things like decoding errors could be logged at the debug level. Just a thought.
Thanks for bringing this up :beers:

Thanks for the PR @dbertouille. Closing this issue now. Feel free to re-open if you don't think the issue is resolved :-)


Runtime Error after configuring Active Directory Membership Service

Hi everyone,
I'm trying to set up a git for testing purposes. I followed the installation instructions and tried configuring Bonobo for using our AD. After configuration I run into in a runtime error:
Server Error in '/Bonobo.Git.Server' Application. Runtime Error    Description: An exception occurred while processing your request. Additionally, another exception occurred while executing the custom error page for the first exception. The request has been terminated.
I think my appSettings should be configured correctly:
<appSettings>
    <add key="webpages:Enabled" value="false" />
    <add key="ClientValidationEnabled" value="true" />
    <add key="UnobtrusiveJavaScriptEnabled" value="true" />
    <add key="UserConfiguration" value="~\App_Data\config.xml" />
    <add key="DefaultRepositoriesDirectory" value="~\App_Data\Repositories" />
    <add key="GitPath" value="~\App_Data\Git\git.exe" />
    <add key="GitHomePath" value="~\App_Data" />
    <add key="RecoveryDataPath" value="~\App_Data\Recovery" />
    <add key="LogDirectory" value="~\App_Data\Logs" />
    <add key="serilog:minimum-level" value="Information" />
<!--
    <add key="serilog:minimum-level" value="Verbose" />
-->
    <add key="AuthenticationProvider" value="Cookies" />
    <!--
    <add key="AuthenticationProvider" value="Windows" />
-->
    <add key="ImportWindowsAuthUsersAsAdmin" value="false" />
    <!--<add key="AuthenticationProvider" value="Federation" />-->
    <!--add key="MembershipService" value="Internal" />
    <add key="MembershipService" value="ActiveDirectory" />
    <add key="ActiveDirectoryDefaultDomain" value="[REMOVED]" />
    <add key="ActiveDirectoryBackendPath" value="~\App_Data\ADBackend" />
    <add key="ActiveDirectoryMemberGroupName" value="gitusers" />
    <add key="ActiveDirectoryTeamMapping" value="Developers=gitusers" />
    <add key="ActiveDirectoryRoleMapping" value="Administrator=gitadmins" />-->
    <!--<add key="FederationMetadataAddress" value="https://sts.domain.local/federationmetadata/2007-06/federationmetadata.xml" />
    <add key="FederationRealm" value="https://git.domain.local" />-->
  </appSettings>

A key for ActiveDirectoryDefaultDomain was not in the config and I had to copy it myself.
With best regards
Marcel

Hi
Can you post what i says in the logs folder?
You can also try to navigate to /Home/diagnostics on a browser on the server for more info.
The defaultdomain option is not active in the current master - but you can try this artifact.

@mastrat Take @larshg advice, but also make sure you can get it working without AD login first - that's much more complex than the default configuration - make sure that works first.

Thanks for your reply.
@larshg I can't browse to /home/Diagnostics or localhost/diagnostics etc. Should there anything listen on that URL? Can the verbose level of logging be changed? Cause the log does only contain information of Bonobo starting:
2017-05-09 09:40:41.266 +02:00 [Information] Bonobo starting
2017-05-09 09:53:44.377 +02:00 [Information] Bonobo starting
2017-05-09 09:56:36.778 +02:00 [Information] Bonobo starting

I tried the artifact you provided and I run into the same problem. Applied Web.config to the actual installation - same here.
@willdean It works without any problems when I use the internal MembershipService. Site opens and I can login with default credentials.

@mastrat can you try turn off custom errors in the webconfig and post what exception is shown?

Of course it was a typo in the Web.config. Thanks for the hint of turning off custom errors. So I realised the comment close tag at the end of the line

-->

Seems to work like expected now.


separate preprocessing steps and use AlternativeImage in ocropy wrappers

details see changelog, roughly:

extra processors for binarization, deskewing, dewarping with ocropy
pipeline relies on AlternativeImage – as reference implementation showing how to deal with relative coordinates and coordinate transforms (rotation, translation, offset)
use variant of ocropy page segmentation to re-segment region rectangles into line masks
extra module for common ocropy functions

I will provide more examples and images shortly.

The last commit maintains that functions in common are the same as those in OCR-D/ocrd_tesserocr#48.

examples:
from euler_rechenkunst01_1738 page phys0006 region r_5_3 (as annotated by OCR-D-GT-SEG-LINE):

the cropped raw region

and some cropped raw lines:

now the binarized and deskewed region:

and the line images masked by their rotated polygons:

Please do not merge yet. I will push more changes soon that will further improve:

rebase common functions on processing polygon coordinates throughout (instead of just bounding boxes)
better ensapsulation
resegmentation as a separate processor (not mixed into common), and also used to clip graphic/separator foreground components out of text regions (where they overlap in the annotation)
more improvements on ocropy line segmentation

Besides the changes already announced, this last commit includes a new processor clip which can suppress neighbouring segments (lines vs. line, or regions vs. region – including SeparatorRegion, GraphicRegion etc) by clipping connected components belonging to them to white in the segment's AlternativeImage. (I had to use image clipping instead of polygon shrinking here, because many frequent cases would create interior islands or non-contiguous polygons.)
Due to the nature of comparison between neighbours though, the segments must not have @orientation or AlternativeImage already. That is, for region-level clipping, any region-level binarization or deskewing must come afterwards.
Line-level clipping can be seen as an alternative to resegmentation which does not depend on Ocropy segmentation.

Here are some examples. Starting with the above euler_rechenkunst01_1738 page phys0006 region r_5_3 again:

clipping the region results in a raw image with white spots where neighbours (here r_5_2 and r_5_4) intrude:

this gives an improved starting point for resegmentation:

these are the original polygon line masks annotated in the GT:

now we have a parameter in resegmentation that allows extending them by some amount of pixels first  (to compensate for too tight cropping):

this is how the intersection with the region labels looks like:

and thus, the mask of the largest label, respectively:

finally, the recropped and dewarped images again:

Here are some more clipping examples from euler_rechenkunst01_1738:

page phys0003 region TextRegion_1479743994178_731:

page phys0004 region r_6_2 (not perfect due to suboptimal binarization):

page phys0004 region r_9_3:

page phys0004 region r_9_4:

page phys0005 region r_8_5:

page phys0005 region TextRegion_1475759982805_45:

page phys0005 region TextRegion_1475759982805_44:

page phys0006 region r_5_2 (just above the first example):

page phys0006 region r_5_4 (just below the first example):

@finkf Please review and/or merge!

I am OK to merge this.  But wouldn't it make more sense to separate all the ocropus related parts of ocrd-cis in its own ocrd module?

Splendid! Definitely, it does make sense to have a separate module with all Ocropy based processors. That's exactly what we are planning to do. This is just the first step, so others can start experimenting already. Remember, I started this in your repo because of all your good work on the recognition processor.
The idea is to restructure the repo OCR-D/ocropy into 2 packages, ocrolib (current ocrolib modules plus non-trivial functions in current CLIs) and ocropus (CLIs only, and packaged properly, possibly ported to click). (Both names are still free in PyPI!) This fork is meant to live on as an improved, Python 3 ported, better encapsulated incarnation, which can probably be PRed back  into tmbdev/ocropy.
Moreover, OCR-D/ocrd_ocropy can then become a simple OCR-D wrapper based on ocrolib.
Based on this, I will re-commit all changes not strictly related to wrappers I made here to the new ocrolib. Finally, I will introduce the new processors into OCR-D/ocrd_ocropy, and also rewrite the segmentation processor (the only one I have not touched yet).

OK. Ill merge then.

thx!


Fix null stoptime in timetable trip sorter

 Issue by landonreed
Monday Oct 23, 2017 at 19:58 GMT
Originally opened as https://github.com/catalogueglobal/datatools-ui/pull/42

The first stopTime for a trip was being used to sort the trips returned from the server. When that
stopTime was null, the sorter was failing. This fix iterates over the stopTimes for each pair of
trips until it finds one that exists for each pair and then it sorts on that index.
fixes catalogueglobal/datatools-server#48

landonreed included the following code: https://github.com/catalogueglobal/datatools-ui/pull/42/commits

 Comment by codecov-io
Monday Oct 23, 2017 at 20:06 GMT

Codecov Report

Merging #42 into dev will decrease coverage by <.01%.
The diff coverage is n/a.

@@           Coverage Diff            @@
##             dev     #42      +/-   ##
========================================
- Coverage   1.34%   1.34%   -0.01%
========================================
  Files        314     314
  Lines      10530   10531       +1
  Branches    3623    3623
========================================
  Hits         142     142
- Misses      8543    8544       +1
  Partials    1845    1845

Impacted Files
Coverage Δ

lib/editor/util/index.js
0% <ø> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6ae5163...6ff3e36. Read the comment docs.

 Comment by landonreed
Monday Nov 06, 2017 at 15:18 GMT

@evansiroky can you please review this PR today?  I accidentally deployed an old copy of the dev branch recently and reintroduced this bug into production because I forgot to follow up on this PR.

 Comment by evansiroky
Monday Nov 06, 2017 at 19:12 GMT

I'm going to approve this, but I wouldn't say that it completely fixes https://github.com/catalogueglobal/datatools-server/issues/48.

 Comment by landonreed
Monday Nov 06, 2017 at 19:15 GMT

Can you elaborate @evansiroky (either here or in catalogueglobal/datatools-server#48?


glibcCross: add arm entry for meson flags

Motivation for this change
Fixes evaluation of pkgsCross.arm-embedded.newlibCross
in which it would produce the following error:
attribute 'arm' missing, at ... pkgs/stdenv/generic/make-derivation.nix:273:31

example error:  https://gist.github.com/GrahamcOfBorg/0bd43f44fc2113856214c08ff5ddf4b8
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[ ] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[ ] Fits CONTRIBUTING.md.

proper fix was done : https://github.com/NixOS/nixpkgs/pull/86254 closing


Create app with local persistent volumes hangs the UI (Safari Browser)

I can reproduce this problem only in Safari - Chrome works fine.
Steps to reproduce:

Create Application Form
Switch to persistent volume tab
Enter a number in the Size field

This spinning ball is shown - the UI is dead.

This is connected to the duplicable rows mixin every time a invalid value is added the ui will get stuck. So this is also breaking the env vars and the labels.


What is happening

my vs code is like tis freezing i dont know what is happening on my screen it is not my screen problems cuz when I screenshot i screen shot it and it does not happen to my other applitcation

/duplicate of #210863

Thanks for creating this issue! We figured it's covering the same as another one we already have. Thus, we closed this one as a duplicate. You can search for similar existing issues. See also our issue reporting guidelines.
Happy Coding!