Quick Mode not functioning properly after update (09232023)

Hi
Just wanted to report that Quick Mode seems to not work as intended after the latest update (09232023). If you boot up a game and turn the device off, it will save the state and reload it upon reboot. But if you then try to turn off the device directly after this sequence (again, using the Quick Mode feature), the screen will simply go blank/dark.  It does still save the state and reload it upon reboot. This was not the behavior before this update. I have tested this on both my primary setup, and on a fresh install with the same result.
/M

I was able to replicate this.  I'm investigating it.

Odd, it's not doing it again.  It's like after the update, this occurs after the first attempt to shutdown from quickboot but after that, it doesn't occur again on my end.  Can you confirm this on your end or are you able to reproduce this issue consistently?  If so, what game and emulator have you tried?

I'm able to reproduce this issue consistently. I have tried different games and emulators (mGBA, Gambatte etc.) with the exact same result; the screen will simply go blank when pressing the power button after using Quick Mode prior to this step, and I will have to press it again for the device to actually turn off. As mentioned, Quick Mode did not exhibit this behavior before the latest update.

Did you enable the tap to power off the device in emulationstation so you don't have to do F+Power to turn off?

I have actually. But I have also tried deactivating this feature with the same result. And just to be sure, I have also flashed the OS to another SD card, without messing with settings etc. afterwards. But the Quick Mode issue persists.

Ok, try restoring this backup that contains the updated scripts for quickmode and see if your results are any different.  Make sure you have quickmode enabled in emulationstation first before restoring.  If you don't have it enabled before restoring this backup, just do a Disable Quick Mode then Enable Quick Mode before you start testing.  Let me know the results.  Thanks.
arkosbackup.tar.gz

I found the issue and will have another update out shortly.

Awesome, that sounds great! I'm looking forward to the update! :)

An update is now available that should fix this quickmode issue.  Please update and let me know your results.

I have now updated and tested the update. The issue with the blank screen is now fixed. However, I noticed that when you exit a game that has been suspended in Quick Mode, this game does not show up under the 'Last Played' section. In version 09212023 games that were suspended using Quick Mode did show up under this section. I remember when using Quick Mode in this version, you could see that the script exited out of EmulationStation (very briefly), and then turned the device off (this process probably 'registered' the game under the 'Last Played' section). Now, in the newest update, the device turns off immediately, and the game is not registered. But your fix does indeed fix the blank screen issue.

The game not showing up in Last Played is a known limitation.  I don't have a solution to address that yet.  surprising that it worked previously as that never did for me.  Thanks for confirming that this update fixed this particular issue.

I was surprised as well. But every game was consistently registered under the 'Last Played' section when using Quick Mode in 09212023, which was quite nice. Stability is of course the most important thing, but It would be pretty awesome if this 'feature' could be implemented in a future build. I wonder if games could be 'registered' when launching them, instead of when exiting them. Just a thought.

Okay, so I just figured out how to make games show up under the 'Last Played' section when using Quick Mode'. You simply have to disable the launch image (i.e. rename/delete 'loading.jpg in /roms/launchimages). By doing that every game will consistently be registered under the 'Last Played' section when using Quick Mode.
(I was initially testing the newest update on a fresh install where the launch image was not disabled. This certainly explains why I observed that games were consistently registered under the 'Last Played' section in previous versions using Quick Mode, as I prefer not to have a launch image when booting up a game. So your newest Quick Mode script is superior in every way compared to earlier versions; It's quicker, more reliable, and retains the ability to register games under 'Last Played' (if you disable the launch image).

Upon further testing I have discovered that the newest version of Quick Mode does not work reliably with PS1/PSX games (using retroarch32/PCSX ReARMed). More often than not I receive the message 'Failed to load state from (insert game title, e.g. Final Fantasy VII)'.

The first version didn't work reliably with ps1 games either.  Save states failed more consistently with the first version than this one.  I believe the issue is that the process doesn't wait long enough for the auto savestates to complete before shutting down for cd based systems.   Maybe not all, but certainly for psx and dreamcast.   I haven't figured out a reliable solution for those yet.  I did find a solution for the last played collections though.

Now I think I have a solution for quick mode that will allow the script to wait until retroarch has safely shutdown before powering down the system.  Please restore this backup and help me test and see if it improves reliability of auto save states for ps1.  Be aware that if you test dreamcast, the flycast32_rumble core has issues with auto savestates even outside of quick mode.  Regular retroarch/flycast is more reliable with auto savestates.
Thanks,
arkosbackup.tar.gz

Sounds really nice that you found a solution for the last played collections - it would be awesome to have an implementation that works whether or not you have a launch image enabled.
I have just tested the backup file, and I does not seem to fix the issue on my end when it comes to PS1 games. I still experience the same 'Failed to load state' message. As far as I remember Quick Mode did actually work for this system on update 09212023.

Sorry about that, the backup I provided didn't have the right files in it.  Try this one instead.
arkosbackup.tar.gz

I have been 'stress testing' your newest backup/solution for a few hours, and It seems like it solves the issue with PS1 games in particular. That's awesome, I believe Quick Mode works as intended now! :)

Hi, is quick mode still working well for you?  I've got a person who's reporting that when they attempt to shutdown the device a second time after a game has been resumed in quick mode, the device just goes straight to emulationstation.  I can't replicate this condition on my end.


Managing DB connections for Prisma Client JS (e.g. in serverless environments)

The query engine that's powering the Prisma Client JS API is maintaing a database connection pool. In serverless environments (or when running your application in containers, e.g. using Kubernetes), this connection pool might loose its effectiveness due to the infrastructure it's being deployed on. You can read more about this topic in the docs.
As of now, the recommended workaround is to use a tool like PgBouncer. We are further exploring some options, such as enabling a "DB proxy server" (e.g. using a specific generator that generates a Docker image to host Prisma's query engine) that manages the connection pool for you (similar to the the Prisma 1 architecture).
Also note that there some cloud offerings start to have solutions for connection pooling out-of-the-box, such as AWS Aurora Serverless (Data API).

Hey folks, here's my chime-in on this
Problem:
On some occasions (currently only tested in development (local) environment) Heroku database gets flooded with connections that don't close. On a hobby plan the limit is 20 connections which can be max out in just few interactions with the app and results in a fatal error.
The Error occurs (currently only this case is tested), when creating a new user or logging in.
The Error
Error querying the database: db error: FATAL: too many connections for role

The resolver resolver.js:
export const LoginMutation = extendType({
  type: 'Mutation',
  definition(t) {
    t.field('login', {
      type: 'AuthPayload',
      args: {
        email: stringArg({ nullable: false }),
        password: stringArg({ nullable: false }),
      },
      resolve: async (_parent, { email, password }, ctx) => {
        const currentUser = await ctx.photon.users.findOne({
          where: {
            email,
          },
        })

        ..

        const token = "string"

        ctx.response.cookie('token', token, {
          httpOnly: true,
          maxAge: 1000 * 60 * 60 * 24 * 365,
        })

        return { currentUser }
      },
    })
  },
})

Environment

Prisma Framework<EMAIL_ADDRESS>binary version: 20b6dc13949cccccfef5be07c0be7a3d7c858abe) deployed to Zeit Now V2
Postgres database deployed to Heroku
Apollo Client 3.0 on the client

Reproduction
Currently have not tried producing more than case in which I get this happens, but the one that shows consistent
Also tried to just wait it out to see if it would close after a while, however, the connections remain active even after prolonged period of time (hours that is).
Solutions?
Currently I need restart the server to fix.
Perhaps there is a function that can explicitly close the connection or something that I've missed?
Fingers crossed for solutions/easy workarounds to this 🤞

Is there documentation yet on how to connect through the AWS Aurora Serverless Data API? Thanks.

Is it just me or is there some other bug with the connection pool (unrelated to serverless environments)? I seem to be hitting the same problem as @ScottAgirs. I’m using Heroku Postgres (Hobby, 20 connections) and running one instance of my application locally.
Is there some gotcha I missed? It feels like I shouldn’t be hitting the limit 🤔

This is not really a bug, but we just open a bunch of connections in a connection pool.
You can limit them with appending ?connection_limit=1 to your connection string.
Here you can read more about it: https://www.prisma.io/docs/reference/database-connectors/postgresql#connection-url

Huh 🤔 I’m on a MacBook Pro with 4 cores, so num_physical_cpus * 2 + 1 would be 9, which is lower than the number of connections on the Heroku database, yet I’m still getting “too many connections” errors.
I was trying to solve this problem a few days ago and stumbled upon an issue that mentioned the connection_limit param in the connection string, so I tried that and set it to 10, but I still got errors…
It might be something I’m doing wrong on my end. The app is a Next.js app (a few days ago I ported it from Razzle to Next.js). The errors happened with both frameworks. In both cases I’m instantiating a new PrismaClient and then passing it into a graphQL server as “context” so I can make requests in resolvers using the same client. Both Razzle and Next.js have dev servers that detect when a change is made and reload all the app code so you don’t have to restart the server. Is there some gotcha I’m not seeing with my setup? And/or is it possible some state is being shared across instances in the Prisma client? 🤔

I have same problem. It creates with every query/mutation a new connection, setting up connection_limit solves nothing, it just ignores the number.

Hey @brandonweiss, two questions:

I’m instantiating a new PrismaClient and then passing it into a graphQL server as “context” so I can make requests in resolvers using the same client

Are you instantiating a new PrismaClient per request or do you generally only have a single instance? (the latter is the recommended approach)
Also, are you calling disconnect in your code?

@nikolasburk Not sure the recommended way is to call disconnect since that will kill the query engine process for each request. Generally creating a global PrismaClient with a connection_limit of 1 is sufficient, but you need to limit the number of parallel lambdas that can span (called reserved concurrency in AWS). Otherwise you have to use their new proxy or pgBouncer. That is not a problem related to prisma as much as a general serverless problem.

@nikolasburk Not sure the recommended way is to call disconnect since that will kill the query engine process for each request. Generally creating a global PrismaClient with a connection_limit of 1 is sufficient, but you need to limit the number of parallel lambdas that can span (called reserved concurrency in AWS). Otherwise, you have to use their new proxy or pgBouncer. That is not a problem related to Prisma as much as a general serverless problem.

That all seems correct to me for serverless environments – but I believe in this case we're talking about a long-running Node.js process that's running locally on the user's machine so I believe calling disconnect() when the application terminates is a good practice. Furthermore, it's indeed recommended to only create a single PrisamClient instance rather than creating one for each request. Basically this:
Yes
const prisma = new PrismaClient()
const server = new GraphQLServer({
  schema,
  context: {
    prisma
  },
})

No
const server = new GraphQLServer({
  schema,
  context: {
    prisma: new PrismaClient()
  },
})

@nikolasburk I’m instantiating it once and passing it into the graphQL server context similar to your “yes” example. And I’m not calling disconnect anywhere. I’ll post my exact code:
const prisma = new PrismaClient()

let apolloServer = new ApolloServer({
  context: async ({ req: { session } }) => {
    let userID = session.get("userID")

    return {
      userID,
      prisma,
    }
  },
})

Context is taking a function in order to have access to the request/session, but I’m not instantiating a new client per request—it should always be the same instance, right?
I assume the reason killing/restarting the server works is because Prisma then will call disconnect and flush the connections?
I could be completely misunderstanding how the client and connections works, but if instantiating a new client per-request is bad (because the connections hang around?) … then wouldn’t a dev server reloading essentially recreate that effect? When Next.js trashes the require cache and re-requires the graphQL server, it will create a new client. I assume over time connections must timeout and die, but if someone were to make a lot of changes/reloads really quickly, presumably this would use up all the connections?
If that’s the case, I would sort of expect this to be a bigger problem, but perhaps most people are developing against a local (or remote) database with a much higher connection limit?

@brandonweiss Yes if not for the lifecycle handling done inside the client itself. The recommended way is to call disconnect to be sure, but the client catches some OS signals and kills the child process. See https://github.com/prisma/prisma/blob/3cb0854e771f4c6daf9be007bc199e5c1405dd67/src/packages/engine-core/src/NodeEngine.ts#L790

I assume the reason killing/restarting the server works is because Prisma then will call disconnect and flush the connections?
then wouldn’t a dev server reloading essentially recreate that effect?

We do want to work on automatic disconnect behavior (and most of the time automatic disconnect already should work today) but for now you probably want to be on the safe side and call disconnect explicitly in your code so that it gets. called before your dev server restarts.

I think that my and @brandonweiss problem with heroku should solve adding pgbouncer buildpack
https://devcenter.heroku.com/articles/on-dyno-postgres-connection-pooling

So I was right. With heroku is needed to do this:

add pgbouncer buldpack - heroku buildpacks:add heroku/pgbouncer
create Procfile file (without extension and with uppercase P) in root of your project
add config to Procfile - for me with node.js project it's this one line web: bin/start-pgbouncer npm run start

I was playing around with my setup and discovered that Next.js only rebuilds certain files in development mode. The file I was instantiating the client in was one of those that gets rebuilt on every change refresh.
I moved the client instantiation into a file in a directory that Next.js doesn’t watch.
// lib/prisma.js

const { PrismaClient } = require("@prisma/client")

export default new PrismaClient()

It worked fine for a while, but then I got another “too many connections“ error. I thought about it for a bit and then I remembered someone saying that the client can potentially open lots of connections and it can be constrainted by using the connection_limit query param on the database connection string.
I set mine to 20, as that’s the maximum number of connections for a Heroku dev instance and I was feeling like I’d solved it, and then I got hit with another “too many connections” error.
At this point I have no idea what’s left to try to debug this. I’ve got a log statement right before/after the prisma client gets instantiated and it only ever happens once, right as the dev server starts up, so I’m like 99.9% sure I don’t have multiple clients.
Is it possible there’s a bug in the connection pooling behavior? Any suggestions on what else I might try?
I can add PgBouncer and that will probably fix it, but I’d much rather solve the root problem if at all possible. Thanks! 🙏

Can you verify processes named query-engine and see if you have multiple spawned? That would be the real indicator if clients are spawned or not. Also 20 connections is also a lot for a single client, try setting that to 2-3 it should be sufficient for dev.

Interesting… I just looked and I had 6. I restarted the dev server and I immediately had 2. Made some changes and refreshed a bit and now I have 4.
Ugh, OK, I just tested it again and the file where I instantiated the Prisma client that I thought wasn’t being reloaded is being reloaded 😭
I found an issue on the Next.js repo where people were having similar problems. So it seems like this is going to be an issue with Prisma and pretty much any dev server. A dev server probably needs to have the ability to ignore reloading certain files, which is slightly different from the ability to ignore watching certain files. The latter is common, but the former is something I’m not sure I can remember seeing before.
From a developer experience perspective, this is a tough one. When the docs say not to instantiate a new client for every request, most people will probably understand what the right thing to do is, especially if there is a code example explaining it. But guarding against a problem like this is going to be pretty hard. Neither Prisma nor Next.js are doing anything wrong, but in combination there’s a really unexpected result.
It might be worth adding a note to the documentation about this particular scenario. Since some (or many) dev servers might have no way of not reloading a certain file, it might be worth including this snippet as an example of how to work around it.
import { PrismaClient } from "@prisma/client"

let prisma

if (process.env.NODE_ENV === "production") {
  prisma = new PrismaClient()
} else {
  if (!global.prisma) {
    global.prisma = new PrismaClient()
  }

  prisma = global.prisma
}

export default prisma

Additionally, it would have been really awesome to get a proactive warning that I was instantiating multiple Prisma clients. You could maybe do something clever and keep track of instantiated instances internally and then log a warning if someone creates more than one? Most people probably don’t intend to create multiple clients so a warning could be really helpful. You could also provide a way for people to ignore the warning if they intentionally mean to instantiate multiple clients for some reason? Just some thoughts!

@brandonweiss Agreed, feel free to open a feature request on the multiple clients thing. I would say it probably is not a big priority because eventually prisma will move to a direct binding to rust so it shouldn't be as much as an issue as it is currently.
@nikolasburk @pantharshit00 do you want another issue for the documentation too?

Yes please, docs issue won't hurt and we can track that separately :)

I have been struggling with this as well. It is also a huge pain when running unit tests. Anyhow, I tried the advice given here (using global) and I am still getting hundreds of dangling connections (and related query engine processes). I have a single instance of Prisma that I use across my app (at least that I what I am trying to do!). In that file I implemented the code as mentioned in this thread but it is not helping. I am seeing console messages (Development: Created DB connection. - see code below) that shows that it is creating a new connection over and over again (after every change/compilation - Next.js).
I also have a variation of this sad state of affairs and have to run killall query-engine-darwin with regularity:
jeff gallformers (descriptions●●) % ps -A | grep -c query-engine-darwin
258

Here is my connection code:
/* eslint-disable @typescript-eslint/ban-ts-comment */
import { PrismaClient } from '@prisma/client';

let db: PrismaClient;
if (process.env.NODE_ENV === 'production') {
    db = new PrismaClient();
    console.log('Production: Created DB connection.');
} else {
    // @ts-ignore
    if (!global.db) {
        // @ts-ignore
        global.db = new PrismaClient();
        console.log('Development: Created DB connection.');
    }

    // @ts-ignore
    db = global.db;
}

db.$executeRaw('PRAGMA foreign_keys = ON');

export default db;

I had to resort to --forceExit on my Jest tests otherwise they would hang forever with an open DB connection. I can close it in afterAll but it only works if I wait at least 1 second in the Promise after each test suite for it to actually close. This is untenable as it makes the tests run very slowly. I am not sure if this is a Prisma or SQlite thing. That code looks like this:
afterAll(async (done) => {
    await new Promise((resolve) => {
        setTimeout(() => {
            db.$disconnect();
            resolve();
        }, 1000);
    });
    done();
});

Anyhow, this is a pain in dev but hopefully will not bite me once I move this to production.

@jeffdc For tests we use --runInBand so they dont run in parallel, apart from that we don't do anything particular since I don't think jest reloads modules once they are loaded once.
We don't even do await prisma.$disconnect();, but I didn't check if they leaked connections. Tests are really slow though, but thats fine for me since those are integration tests that are always slow.


x5 JS Performance Improvement

You can simply improve performance by at least 4 or 5 times by using arrays / matrices instead of relatively expensive object calls.
This went from 7 fps to 30 fps comfortably on my machine with no functional change.
It is a little less intuitive to read, however I believe the performance benefit is significantly improved.
I will also experiment with GPU calculations now that the atom definitions are all number matrices. It makes it relatively trivial to add this functionality now.

I've also added a fi to ensure that no atoms escape the boundaries as described here - https://github.com/hunar4321/particle-life/issues/4

That is really cool! Thanks


Logging

@alvin-reyes fb-botmill logs everything to console. Can I make it put logs in a file?
Thanks in advance.

Yes. We've been planning to do this for a while, so yeah it would be an
awesome addition.
Please create a Pull Request once its done and set me as reviewer.
On Thu, Jun 8, 2017 at 6:30 AM Roman Kravchenko<EMAIL_ADDRESS>wrote:

@alvin-reyes https://github.com/alvin-reyes fb-botmill logs everything
to console. Can I make it to put logs in a file?
Thanks in advance.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/BotMill/fb-botmill/issues/124, or mute the thread
https://github.com/notifications/unsubscribe-auth/AERYw_qeY1xq5nbxa2oorp6f73-7TJjlks5sB81VgaJpZM4Nz4Lv
.

I would suggest not to pack logback.xml in the jar file. Let the user decide where and what to log

@andrefsore , do you have any suggestion how can we do it better?

The developer who imports the lib, should create theirs own logback.xml. I had to create logback-test.xml  in order to override logback.xml that was packed in fb-botmil.jar, because I wanted to set the logging level by myself, for instance.


Disallowed unexpected properties in json schema

Are the integration tests still passing after these changes?

Adam,
I have checked this feature with:
instance module
and
two scenarios,
one positive (should pass) and one negative (should fail).
For the positive test I simply executed the test as is + the feature that had been added.
The result of the test was as it had been expected initially: the test passed
For the negative test I introduced a new property (dummy: demo).
The result of the test was as had been expected: the test failed,
please see the screenshot below:
https://www.screencast.com/t/uVgKwEpeSc


Prevent going to state using a promise that fetch remote data

There is always a need to prevent users going to some state depending on some logic. I've seen a lot of questions about this. Most answers tell to use data object when configuring the state and listen to $stateChangeStart event.
But how about when this logic depends on fetching data from remote server?
$scope.$on('$stateChangeStart', onStateChangeStart);

function onStateChangeStart(event, toState) {
  user.fetchLatest().then(function(current){
    if(!current.billing)
      event.preventDefault();
  });
}

If user.fetchLatest() takes too long, event.preventDefault() will not work.
:question:  With the current version of ui-router, how can I accomplish such scenario :question:
Wouldn't be better to support these scenarios when configuring the state?
Something like:
$stateProvider.state('myState', {
  url: '/myState',
  prevent: {
    goTo: 'anotherState',
    deny: preventUsersThatDontHaveBilling
  }
});

//injectable dependencies
function preventUsersThatDontHaveBilling($q, user){
  var deferred = $q.defer();

  user.fetchLatest().then(function(current){
    if(!current.billing)
      deferred.reject();
    else
      deferred.resolve();
  });

  return deferred.promise;
}

If deny promise is rejected, state configured in goTo would be activated instead of myState.

You should probably do that fetch in your run block or do you really want it to run everytime they change the page. Also, changing the state shouldn't matter if your API blocks the user from accessing data if they need to be billed or something.


Doesn't work as expected with Nova TinyMCE

Hello,
I tried to integrate the NovaTinyMCE package with the nova-page-manager.
When I integrate it normally, it does not work (the javascript of the package does not seem to be executed)

When I integrate NovaTinyMCE in the default fields (in vendors: vendor/optimistdigital/nova-page-manager/src/Nova/Page.php) it works.

How is it possible ?
Thank you

I have the same problem

As I managed to find out, this is due to the fact that the textarea identifier contains the ">" symbol, for example, "data-> field_name". The ">" character is not allowed in the identifier, so the plugin cannot find a textarea element to convert to wysiwyg.
You need to change the scheme for creating the identifier.

I found how to fix this. The teeny field has the ability to specify a custom identifier.
NovaTinyMCE :: make ('text') -> id ('my-id')
In this case, the field in the admin panel is displayed correctly.

It's works Thanks !!


Update http4s-circe, http4s-core, ... to 0.23.20

About this PR
📦 Updates

org.http4s:http4s-circe
org.http4s:http4s-core
org.http4s:http4s-dsl

from 0.21.34 to 0.23.20
📜 GitHub Release Notes - Version Diff
Usage
✅ Please merge!
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

💡 Applied Scalafix Migrations

org.http4s:http4s-.*:0.22.0 (created no change)

github:http4s/http4s/v0_22?sha=series/0.22

⚙ Adjust future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "org.http4s" } ]

Or, add this to slow down future updates of this dependency:
dependencyOverrides = [{
  pullRequests = { frequency = "30 days" },
  dependency = { groupId = "org.http4s" }
}]

labels: library-update, early-semver-major, semver-spec-minor, version-scheme:early-semver, scalafix-migrations, commit-count:1

Superseded by #1525.


Addd subgraph deployment script

fixes #342

Added command to deploy subgraph,
subgraph project now supports templating.

LGTM 👍


Material system: GPU occlusion culling doesn't work if resolution not equal to screen resolution

If I have material system and r_gpuOcclusionCulling enabled, and set the resolution to anything significantly less than my screen resolution, I get something like this. Many or most surfaces are not drawn that should be.

I'm not getting any such issues with a lower-sized window. How are you setting your resolution?


Explanation Docs for CRS

This is my initial draft.  Feel free to edit or provide feedback.  I plan to work on it more this afternoon.

@rsokl  Is this fine for now and just merge? I should be able to work on some docs tomorrow and wednesday.

I need to give this more thorough read through

At the moment, it seems this doesn't discuss anything explicitly in the toolbox (I think there's a reference to rai_toolbox.mushin in the intro, but then it isn't discussed again)
At a minimum, it would be great to update the examples to be about configuring and swapping out the parameters of a robustness-related task (e.g., have Adam and SGD be inputs to a perturbation optimizer). Then maybe adding some language about how this is our recommendation for how users of the toolbox build up their experiments?
And is there anything else from rai_toolbox.mushin that should be discussed? Is this where a description on workflows could live or does that merit it's own separate section?


Support announcement threads, private threads, voice text channels and stage text channels

Should voice channels be supported too to send text inside? They do support text messages but no one I know really uses it because too inconvenient

thanks for the pr!
voice text channels (lovely phrase) should be supported but there isnt a separate channel type for them maybe putting ChannelType.GUILD_VOICE in Component.ChannelTypes is the way to do it
could you test this pr maybe taking the voice channel support into its scope and lmk if it works

I don't have Rust installed but at least Stackoverflow tells me it works https://stackoverflow.com/questions/72928111/how-to-send-a-message-to-the-chat-in-a-voicechannel-using-discord-py

did some testing

private threads work BUT the bot has to be mentioned in them first, this is expected but the problem is the bot doesnt tell this properly and it just says the permissions its missing, this is a niche case so ill merge it and create an issue for addressing this
announcement threads work
stage channels say that the bot doesnt have the permissions it needs when it does and voice channels say that the user (not the bot) doesnt have send messages permission both of these require additional handling which i dont have the bandwidth to do

please remove stage and voice channels from this pr and ill merge it

this is now deployed, feel free to reopen if theres any issues


[ESP32] Adding filters to the traces reported to esp-insights.

Change Overview:

Filters the required traces to be reported to the esp-insights .
Provision to add and remove apis to add or remove the traces as per requirement.

Testing:

Tested the esp32 lighting-app for add and remove apis to apply filters and the filtering functionality made available by default.

@shripad621git please also see comments in https://github.com/project-chip/connectedhomeip/pull/28466/
You should at least fix the arguments to the backend to force 2 char* arguments and not use a vaargs with a forced 2nd argument that is unchecked.

@shripad621git consider implementing a tracing backend and use that backend to make your decisions regarding on what you log and what not.
Ideally the implementations should not diverge just because macros overrides allow you to hook into code.
see https://github.com/project-chip/connectedhomeip/blob/master/src/tracing/README.md#usage


fix up pcconfig file

@traversaro maybe you can review this :)

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

Hmm, the linking fails with
LINK : warning LNK4044: unrecognized option '/LD:/bld/libode_1635751983796/_h_env/Library/lib'; ignored
LINK : warning LNK4044: unrecognized option '/lode_double'; ignored

Differently from most other user of pkg-config I saw on Windows (including CMake's function pkg_check_modules ) the ode's Python setup.py expect the .pc file to contain exactly the flags expected by cl.exe, i.e. the MSVC compiler (see https://bitbucket.org/odedevs/ode/src/0b5080331d9551e5e6689ebe6eb899809b5ba392/bindings/python/setup.py#lines-13).
Probably it is also necessary to add the --msvc-syntax pkg-config flag to all invocations of pkg-config in the setup.py, see https://gitlab.freedesktop.org/pkg-config/pkg-config/-/blob/d97db4fae4c1cd099b506970b285dc2afd818ea2/README.win32#L24 for more info.

Indeed the patch https://github.com/conda-forge/libode-feedstock/pull/15/commits/82726b7d535aaa9d07366f8a3d4be64d7fb46b56 (applied only on Windows) seems to be working fine.

@repagh what do you think? It seems good to me.

Looks good to me, too.


cargo-expand: 1.0.29 -> 1.0.30

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/dtolnay/cargo-expand/releases.
meta.description for cargo-expand is: "A utility and Cargo subcommand designed to let people expand macros in their Rust source code"
meta.homepage for cargo-expand is: "https://github.com/dtolnay/cargo-expand"
meta.changelog for cargo-expand is: ""
Updates performed

Rust version update

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact

Checks done (click to expand)

built on NixOS
The tests defined in passthru.tests, if any, passed
found 1.0.30 with grep in /nix/store/j48lyslg9mbhzr3sd8ncwgvim01l3mqw-cargo-expand-1.0.30
found 1.0.30 in filename of file in /nix/store/j48lyslg9mbhzr3sd8ncwgvim01l3mqw-cargo-expand-1.0.30

Rebuild report (if merged into master) (click to expand)

1 total rebuild path(s)

1 package rebuild(s)

First fifty rebuilds by attrpath
cargo-expand

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/j48lyslg9mbhzr3sd8ncwgvim01l3mqw-cargo-expand-1.0.30 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A cargo-expand https://github.com/r-ryantm/nixpkgs/archive/3a09f2c32067b1d646a94f621c42885becc56850.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/j48lyslg9mbhzr3sd8ncwgvim01l3mqw-cargo-expand-1.0.30
ls -la /nix/store/j48lyslg9mbhzr3sd8ncwgvim01l3mqw-cargo-expand-1.0.30/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

1 package built:

cargo-expand

Maintainer pings
cc @xrelkd for testing.

Result of nixpkgs-review pr 186577 run on x86_64-linux 1

1 package built:

cargo-expand


options: cleaning up listener config

removing a transient options API added for the mobile API listener transition.
Risk Level: low
Testing: n/a
Docs Changes: n/a
Release Notes: n/a

/retest


demo site is down

can not reach demo page =)
can you, please, add screenshot as assets?

Hi bro
can you help me to built same site like your site of my fyp project please bro help me  .
can you send me summery of that project which help me to create same app like your app


Document log filters

Closes #2064 by documenting that the feature

Coverage increased (+0.03%) to 84.931% when pulling 841d8068776e534ddfad2ca06bded8a7d1071c92 on nickbabcock:doc-log-filter into 05ffc59d56515ee674c516d83b85502bf3bdd2b3 on dropwizard:master.


Fixed readme rails example for config of the initializer

Ran into an issue when initializing Opbeat in Rails. Turns out it's config instead of configure.

Thank you – but I don't think you are correct. See https://github.com/rails/rails/blob/master/railties/lib/rails/generators/rails/app/templates/config/environments/production.rb.tt#L1


Update docs with references to --install-completion

:memo: Update docs with references to --install-completion and use subcommand everywhere instead of sub-command for consistency with Click

Codecov Report

Merging #9 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master       #9   +/-   ##
=======================================
  Coverage   75.27%   75.27%
=======================================
  Files          16       16
  Lines         554      554
=======================================
  Hits          417      417
  Misses        137      137

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f192d9d...c941db5. Read the comment docs.


Tumblr returns 'oauth_signature does not match expected value' on requesting a token

Trying to authenticate to tumblr, it refuses to return a request tokenclaiming a wrong signature, and I've used the built-in demo to try it with 2 different app key/secrets already
Edit: flickr seems to give the same error

My bad for not following up. From what I've seen previously, frequently this has to do with timestamps/time synchronization. The library definitely works with some other sites, such as twitter, but it's possible other issues besides timing could arise. Encoding issues or special characters come to mind.
Since this is old, I'm going to comment & close, but if you want to follow up and have more info (logs, request info with sensitive info removed, etc), please reopen an we can follow up.


Cannot read property 'map' of null

Describe the bug
Similar to #2680 I guess.
[ETH1]            error: Error updating eth1 chain cache message=Cannot read property 'map' of null
Expected behavior
No.
Steps to Reproduce
NODE_OPTIONS="--max_old_space_size=8192" lodestar beacon \
  --metrics.enabled \
  --eth1.providerUrl https://goerli.infura.io/v3/**SNAP** \
  --rootDir /srv/chain/lodestar \
  --network "pyrmont"

Screenshots
Aug-12 12:01:13.000 []                 info: Syncing - ? left - 0.00 slots/s - finalized: 320 0x198f…7f39 - head: 10334 0x20b0…52cc - clockSlot: 1921805 - peers: 29
Aug-12 12:01:25.001 []                 info: Syncing - ? left - 0.00 slots/s - finalized: 320 0x198f…7f39 - head: 10334 0x20b0…52cc - clockSlot: 1921806 - peers: 27
Aug-12 12:01:26.242 [ETH1]            error: Error updating eth1 chain cache message=Cannot read property 'map' of null
TypeError: Cannot read property 'map' of null
    at Eth1Provider.getLogs (/home/user/lodestar/packages/lodestar/src/eth1/provider/eth1Provider.ts:159:20)
    at runMicrotasks (<anonymous>)
    at processTicksAndRejections (internal/process/task_queues.js:95:5)
    at async Promise.all (index 1)
    at retry (/home/user/lodestar/packages/lodestar/src/util/retry.ts:33:14)
    at Eth1Provider.getDepositEvents (/home/user/lodestar/packages/lodestar/src/eth1/provider/eth1Provider.ts:67:24)
    at Eth1ForBlockProduction.updateDepositCache (/home/user/lodestar/packages/lodestar/src/eth1/eth1ForBlockProduction.ts:164:27)
    at Eth1ForBlockProduction.update (/home/user/lodestar/packages/lodestar/src/eth1/eth1ForBlockProduction.ts:150:31)
    at Eth1ForBlockProduction.runAutoUpdate (/home/user/lodestar/packages/lodestar/src/eth1/eth1ForBlockProduction.ts:124:30)
Aug-12 12:01:35.693 [NETWORK]         error: Unexpected error in assertPeerRelevance peer=16...hM2vJH message=Cannot get block root from slot more than 8192 in the past: 10334 <= 10240
Error: Cannot get block root from slot more than 8192 in the past: 10334 <= 10240
    at Object.lte (/home/user/lodestar/packages/utils/src/assert.ts:31:13)
    at getBlockRootAtSlot (/home/user/lodestar/packages/beacon-state-transition/src/util/blockRoot.ts:18:10)
    at getRootAtHistoricalEpoch (/home/user/lodestar/packages/lodestar/src/network/peers/utils/assertPeerRelevance.ts:98:10)
    at assertPeerRelevance (/home/user/lodestar/packages/lodestar/src/network/peers/utils/assertPeerRelevance.ts:72:11)
    at PeerManager.onStatus (/home/user/lodestar/packages/lodestar/src/network/peers/peerManager.ts:236:7)
    at NetworkEventBus.<anonymous> (/home/user/lodestar/packages/lodestar/src/network/peers/peerManager.ts:185:23)
    at NetworkEventBus.emit (events.js:400:28)
    at NetworkEventBus.emit (domain.js:470:12)
    at Timeout._onTimeout (/home/user/lodestar/packages/lodestar/src/network/reqresp/reqResp.ts:245:43)
    at listOnTimeout (internal/timers.js:557:17)

Desktop (please complete the following information):

OS: Archlinux kernel 5.10.11-arch1-1 #1 SMP PREEMPT Wed, 27 Jan 2021 13:53:16 +0000 x86_64 GNU/Linux
Version: v0.28.0
Branch: master
Commit hash: 2c010b25
Node: nvm use lts/fermium / Now using node v14.17.4 (npm v7.20.5)

Also that one:
Aug-12 12:19:45.632 [ETH1]            error: Error updating eth1 chain cache message=Gateway Time-out:                                                                                [6/1896]
<title>504 Gateway Time-out</title>

504 Gateway Time-out

Error: Gateway Time-out:
<title>504 Gateway Time-out</title>

504 Gateway Time-out

    at JsonRpcHttpClient.fetchJsonOneUrl (/home/user/lodestar/packages/lodestar/lib/eth1/provider/jsonRpcHttpClient.js:105:19)
    at runMicrotasks (<anonymous>)
    at processTicksAndRejections (internal/process/task_queues.js:95:5)
    at JsonRpcHttpClient.fetchJson (/home/user/lodestar/packages/lodestar/lib/eth1/provider/jsonRpcHttpClient.js:53:24)
    at JsonRpcHttpClient.fetch (/home/user/lodestar/packages/lodestar/lib/eth1/provider/jsonRpcHttpClient.js:35:21)
    at Eth1Provider.getLogs (/home/user/lodestar/packages/lodestar/lib/eth1/provider/eth1Provider.js:96:25)
    at async Promise.all (index 0)
    at Object.retry (/home/user/lodestar/packages/lodestar/lib/util/retry.js:17:20)

🤣

Thanks for reporting! Seems that our eth1 consumer doesn't do enough data validation.
The error error: Error updating eth1 chain cache message=Cannot read property 'map' of null TypeError: Cannot read property 'map' of null seems to be caused by an response that does not follow the RPC format. We should add schema validation for all the fields that we expect to exist


Activities Around You

Let's offer a feature to show activities, places, and other things around you based on the guests place location or a manual search (for everyone that is not being hosted)
Activities can be

free sports offerings from sport clubs
donation centers that give out clothes, food, and other essentials
...

Should the host enter these details while registering their place?

Yes, that could also be added and helps us to add content to the platform.
I know a lot of companies and clubs that would add activities as well

Added a simple bulletin board that should meet the current need. Later on we will improve this feature much more.


Subscribe to BitMex pricefeed and post orders to orderbook

The maker should subscribe to the BitMEX pricefeed and post new orders to the orderbook

I started working on this already

I started working on this already

I took over :)


there is a bug in darknet53.py

Good work!
But I think there is a bug in darknet53.py, line 51:
in stead of  x = conv2d_unit(inputs, 2 * filters, (3, 3)), it shoud be x = conv2d_unit(x, 2 * filters, (3, 3)).
Can you check it?

fix it, thanks!


Improved grammar and corrected spelling.

Corrected some words and concordance for portuguese sentences.

[x] I have read freeCodeCamp's contribution guidelines.
[x] My pull request has a descriptive title (not a vague title like Update index.md)
[x] My pull request targets the master branch of freeCodeCamp.
[x] None of my changes are plagiarized from another source without proper attribution.
[x] My article does not contain shortened URLs or affiliate links.

If your pull request closes a GitHub issue, replace the XXXXX below with the issue number.
Closes #XXXXX

Thank you for your contribution to the page! 👍
We're happy to accept these changes, and look forward to future contributions. 🎉


[AlwaysOnTop] Fix: Border stays after moving window to another desktop

Summary of the Pull Request

PR Checklist

[x] Closes: #18673
[ ] Communication: I've discussed this with core contributors already. If work hasn't been agreed, this work might be rejected
[ ] Tests: Added/updated and all pass
[ ] Localization: All end user facing strings can be localized
[ ] Dev docs: Added/updated
[ ] New binaries: Added on the required places

[ ] JSON for signing for new binaries
[ ] WXS for installer for new binaries and localization folder
[ ] YML for CI pipeline for new test projects
[ ] YML for signed pipeline

[ ] Documentation updated: If checked, please file a pull request on our docs repo and link it here: #xxx

Detailed Description of the Pull Request / Additional comments

Validation Steps Performed

Pin window on top
Open TaskView
Move pinned window to another virtual desktop
Return to the initial virtual desktop
Verify border doesn't stay on the initial virtual desktop

@SeraphimaZykova , giving it a test but I'm noticing something weird.
When I press Win+Tab with the Always on Top Window focused, it will show the highlight in the thumbnails of all desktops.
(This is the Win+Tab screen top left corner):

@SeraphimaZykova , giving it a test but I'm noticing something weird. When I press Win+Tab with the Always on Top Window focused, it will show the highlight in the thumbnails of all desktops. (This is the Win+Tab screen top left corner):

Opened an issue for this. It's not a regression, it was working like that in previous releases.


Add action to auto-approve copybara-service bot.

feedback/copybara and import/copybara won't run bc these files do not affect files tracked by copybara. I do not know why they are labeled as Expected -- Waiting for status to be reported I will use admin privileges to merge, and ask around to see if anyone has a solution for requiring these checks to run and pass, but only when applicable to copybara tracked files.


Write Deno Kv Testcode

I wrote deno kv test code because I want to marge https://github.com/unjs/unstorage/pull/233.

Thanks!


YAML

command-not-recognised: "&fUnknown command. Type "/help" for help."
Is there a way to display "" inside the messages?

\" maybe

Thank you again!


Remove the "stat" entry in the PUSH_DATA packet when the object is null

The Semtech UDP protocol states :

The root object can also contain an object named "stat" :
{
	"rxpk":[ {...}, ...],
	"stat":{...}
}

Actually, when the stat object is null, the UDP forwarder adds a null "stat" entry:
{
	"rxpk":[ {...}, ...],
	"stat": null
}

Even if the protocol specification is not clear and this is correct regarding JSON, some LNS do not support a null stat object. Not having the stat entry at all in that case would improve interoperability.
This patch is done on v3 (025b886fcc7bfc23aa6b0c5ee3f39e75909a10d6) but there is no such branch on the repo.

Hi @mullerch looks good to me, could you rebase on the lastest master because the PR can't be merged because of conflicts.
If you want, I can create a v3 branch based on the latest v3 version and then cherry-pick this PR back into that branch after merging.

I would prefer doing my PR on the v3 branch directly as at this time I cannot test the v4 version. So if you create the branch I can rebase on v3 and then you cherry-pick to master.

@mullerch here you go: https://github.com/chirpstack/chirpstack-udp-forwarder/tree/v3


Text

Text should be of different sizes

h1 - h6
base font size can be 12px

can you elaborate more. i would like to work on this issue

can you elaborate more. i would like to work on this issue

sure , this project is going to be ui library , so as every ui library has there own text versions of the simple h1 - h6 items , i want to have the same here but with the ability to have customisations
e.g h1 should have a default font size but other things like colors, underline, italic (possiblities are endless and depends on how you imagine)
for base color should be customisable

Hey @jsh854 interested to work on this issue if possible can you assign it to me ?

Hey @jsh854 interested to work on this issue if possible can you assign it to me ?

done

Hi @jsh854 great initiative, would love to work on this. Wanted to know if you are considering documentation (docs) for this from start or later on..(just curious)

Hi @jsh854 great initiative, would love to work on this. Wanted to know if you are considering documentation (docs) for this from start or later on..(just curious)

yes i am considering that , but initially it would not be ideal - we can think of that once the project takes some pace.


Correct the webhdfs port number when constructing the url

@rushah : Thanks for your contribution! The author, @rothja, has been notified to review your proposed change.

@rushah Thank you for the fix. #sign-off


Portfolio finish mobile version1

This project is all about creating a portfolio template. No complex coding is required for this exercise. The goal is to master all of the tools and best practices learned in previous steps. They will be used in all Microverse projects and most likely in future jobs as well, so it is important to know!. 1- HTML 2- css 3- linters

Hello @KiengPhyl 👋,
This is an additional review as a result of the second opinion request.
We are glad this has been resolved!
Keep rocking 🚀!


Add documentation for creating construct libraries

We should add a page to the website with information about how to author cdk8s construct libraries. Some of the content may overlap with the instructions for creating construct libraries for the AWS CDK, as described in the FAQ of Construct Hub: https://constructs.dev/contribute

I'd be keen to work on this as we are looking to distribute a few pre-baked charts.
At the moment, when I install our package locally into a test project I get failures due to a parent chart not being found.
For some reason, Chart.of(...) fails for
import { BasicApplication } from "shared/charts" // this is locally npm-installed

class X extends Chart {
   constructor(scope: Construct, id: string) {
     super(scope, id)

     new BasicApplication(this, `${id}-basic`, {
        // ... props elided....
     })
  }
}

Should I open a seprate bug for 🔼 or is that something better docs might address?

@felipesere Yes please open a separate bug for this! Thank you :)

I see you already have the PRs sorted 🌶 .
Do you still need the issues?

Nope, all good 👍


Regenerating SDK for CHANNEL_OPENING_FEES webhook event

#201  👈
develop

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @jklein24 and the rest of your teammates on  Graphite

Merge activity

Sep 3, 3:03 PM EDT: @jklein24 merged this pull request with Graphite.


add spec walkthroughs

walkthrough for implementing a PT (outside of openvpn example)
walkthrough for building a PT

See https://www.pluggabletransports.info/implement/go/ for implementing via the Go API
See https://www.pluggabletransports.info/build/how/ for a walkthrough of building a transport in Go


Update default symbol

This extends and modify a bit what's been introduced in PR  #2419.
It makes sure silx.config.DEFAULT_PLOT_SYMBOL is used:

in plot3d scatter items
as the default symbol for sx.scatter and sx.points3d functions.

There is a change of behavior from the initial PR: What was set by the initial PR was the symbol of curves only, while here it changes the symbol of scatters.
@maurov, is that OK for you?
If you need to set a default symbol for curves as well, I would be in favor of introducing a silx.config.DEFAULT_PLOT_CURVE_SYMBOL (default to '') because 2 different default are needed for scatter and curves...

My opinion is that one needs to be able to set a different default symbol for curves and scatter.

Default for curves and scatter are different.
The default for curves is hard-coded to no symbol, while that of scatters can be set through silx.config.
It's easy to make it also settable for curves, but I would only do it if it is needed... because we can add many things in silx.config.

@t20100 I agree with @vasole that we should add in the config both default symbol for scatters and curves. silx.config will inevitably grow. Personally, I would like to have it similar to matplotlib.rcParams, permitting to dynamically change the default settings in a python script or interactively from the python shell.

It is a bit more complicated with curves because there is a special mechanism in PlotWidget with PlotWidget.setDefaultPlotPoints which changes the default symbol...
I'll make something specific for that, but I think we should deprecate this mechanism, it should only be used by the action changing curve style and so it should be implemented there.

Added settable default PlotWidget curve symbol.
Ready for review.


Need update method

It just occurred to me that we may need an API method for updates, which would allow for the client to pick up progress (via task data) and such for a task that is being processed but not yet closed.

Hey @inator
Do let me know if I could be of any help!

@mbad0la - I absolutely welcome the help if you're interested in taking this one on?  If so, I can share the implementation ideas @gr2m and I discussed today.  It's a fairly simple addition and I can get you oriented to the current API to get you started.  I'm currently focused on the task-client refactor, so your kind offer to help is greatly appreciated!

We're thinking that a .progress() method would be more appropriate, with something like:
var taskUpdate = { percentComplete: '45' }
.progress(taskDoc, taskUpdate)

Behind the scenes the taskDoc would have the taskUpdate value pushed into an array property named "progress", which in turn would be synced to the client for the developer to parse and use however they see fit, such as a progress ticker from the above example.
@gr2m, please chime in if this doesn't accurately represent our brainstorming.  Thanks!

I'd love to take this up! Just get me up to speed :p

@mbad0la - I DM'd you on Slack!  Thanks!

@mbad0la - Gregor and I talked bit more on the progress method and have a slight change in approach:
var options = { name: 'optional-name', progressData: data }
.progress(taskDoc, options)

Where the taskDoc is required and options.name and options.progressData are optional.
Sorry for the change midstream.  The tasks concept is maturing rather rapidly and subject to some adjustments. :)

progress: [{name: 'progress', at: '2017-01-03T21:46:55.688Z', progressData: data }]

Will the server be generating the time for the at field (just before pushing the progress object into the progress array)?
Also, only the options.name is optional right? The options.progressData field would now be the necessary one isn't, instead of just the progressData argument discussed earlier?

@mbad0la - yes you'll want to make that field server generated.
options and the both options.name and options.progressData are optional.  Absent progressData basically will supply a sort of "heart beat" back to the client letting it know the task is still processing.  In practice though, I can't imagine that devs will not include some progressData cargo to do something useful on the client with it - like tick up a progress bar.  Still, we wont error if they choose not to include it.
Make sense?

Oops... need to update the api/README before we can close this.

Sure @inator
Is there a documentation reference I can take an example?

@mbad0la - Minimally, if you just want to add the method reference to the existing api/README, that will fine for now.  I expect the docs for tasks will need some TLC before we go prime time with it all, so much of this is likely a placeholder.
Of course if you elect to go further with it, no harm in that either. :)  See the README for hoodie-store-server-api for reference.
Thanks much!

I'll just add a reference for now. Would be better to have a separate PR for documentation.

Going through the docs, I found an anomaly in the code. According to the docs the API methods return a promise but I don't see that happening inside the success and error method. Please confirm.

Going through the docs, I found an anomaly in the code. According to the docs the API methods return a promise but I don't see that happening inside the success and error method. Please confirm.

I think it should... probably my error.  just needs a return added most likely.

@mbad0la - thanks for handling this!  Closing.


Update zerowaste to 0.2.14

About this PR
📦 Updates com.github.ghik:zerowaste from 0.2.1 to 0.2.14
📜 GitHub Release Notes - Version Diff
Usage
✅ Please merge!
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

🔍 Files still referring to the old version number
The following files still refer to the old version number (0.2.1).
You might want to review and update them manually.
build.sbt
website/yarn.lock

⚙ Adjust future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "com.github.ghik", artifactId = "zerowaste" } ]

Or, add this to slow down future updates of this dependency:
dependencyOverrides = [{
  pullRequests = { frequency = "30 days" },
  dependency = { groupId = "com.github.ghik", artifactId = "zerowaste" }
}]

labels: library-update, early-semver-minor, semver-spec-patch, old-version-remains, commit-count:1

Superseded by #519.


Exclude conventional-changelog-core from flow typecheck

Summary
Fixes flow typecheck
Test plan
yarn lint

<3

Codecov Report

Merging #3434 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #3434   +/-   ##
=======================================
  Coverage   63.99%   63.99%
=======================================
  Files         177      177
  Lines        6574     6574
  Branches        4        5    +1
=======================================
  Hits         4207     4207
  Misses       2365     2365
  Partials        2        2

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5749d38...4c5ef8e. Read the comment docs.


Develop the modal w/ margins component

hahnrob created the following on Jun 20:

User Story

As a [user role below]:
As a developer using the Digital Design System

I need to:
have an Expressive Modal in the Locale Selector

so that I can:
include this component in the Locale Selector in the web site I am developing

Additional information

This issue is dependent on the design and the package architecture #860
final design and specs
- Includes:  Functional labels, Visual redlines, Behavior and interaction specs, Desktop and mobile
Box link to Mary O'Donnell's functional specs
While this expressive modal is included in the Locale Selector, it will be developed as a generic component.
Try to leverage the current Carbon modal and applying the expressive theme.
Carbon Modal

Acceptance criteria

[ ] Component has been tested using Netlify
[ ] The component development follows a modular component pattern
[ ] The component should be accessible via ES6 import
[ ] The component should be visible within the living documentation of the Dotcom components
[ ] Presented and approved Product Owner

Original issue: https://github.ibm.com/webstandards/digital-design/issues/1078

On Aug 05, hahnrob commented:
T-shirt Sizing:  Medium

On Sep 10, james-dow commented:
I wanted to make sure I put this here for whoever ends up picking up this ticket. It's the APIs currently being used in v18 for the Locale selector.

Locale Selector API
User Locale API

On Sep 17, hahnrob commented:
Avi's meeting notes from Sept 16 Locale Selector JS file:
Thanks to all of you for attending the call today.
The purpose of the call was to understand and discuss the current and future process/tool/owner for updating the locale selector JS file that it is used by ibm.com DDS team.
https://1.www.s81c.com/common/js/dynamicnav/www/countrylist/usen-utf8.js
This is the recap and key points:

Originally, ECM/IConS was used to author and generate the locale selector JS file. After the sunset of ECM/IConS, the file gets updated manually whenever there is a change. Changes are not frequent.

Updating the file is one small step in a multi-step process for adding/changing locales to Drupal/ibm.com

Tina owns the list of locales and will coordinate with the web master/MSC teams whenever the file needs to be updated.

A JSON format of the file is required for the new version of ibm.com design (Carbon). Once the new design is deployed, both JS and JSON files need to be updated and kept in synch.

Please let me know if I missed/misstated anything major.
Thanks!
Avi Rakhsha
Sr. Manager, Digital Content Platforms
<EMAIL_ADDRESS>

On Oct 03, hahnrob commented:
Design review meetings conducted Oct 3.

ButtonGroup work has been merged in to support this story: https://github.com/carbon-design-system/ibm-dotcom-library/pull/545

Presented in the Oct 28 Sprint Review meeting.  Closing.


Text to speech doesn't work and no errors showed.

Hi. No any sound made from bot when it responds.
I am testing bot on localhost with botEmulator.
OS: Linux Ubuntu
"name": "botframework-emulator",
"version": "3.5.35",
Used valid  MS App ID and MS APP password in BotEmulator and Bot app.
Bot code:
bot.dialog(intents.Greeting, function (session) {
  const userName = session.message.user.name;
  var msg = new builder.Message(session)
    .speak('This is the text that will be spoken.')
    .inputHint(builder.InputHint.acceptingInput);
  session.send(msg).endDialog();
})
  .triggerAction({
    matches: intents.Greeting
});

Bot responds on greeting.. and response JSON is:
{
  "type": "message",
  "speak": "This is the text that will be spoken.",
  "inputHint": "acceptingInput",
  "locale": "en-US",
  "localTimestamp": "2018-06-07T14:17:34+03:00",
  "from": {
    "id": "default-bot",
    "name": "Bot"
  },
  "recipient": {
    "id": "default-user"
  },
  "id": "someID",
  "replyToId": "someID",
  "channelId": "emulator",
  "timestamp": "2018-06-07T11:17:34.570Z",
  "conversation": {
    "id": "someotherID"
  }
}

No any errors in logs. Just this:
[14:11:18] Emulator listening on http://[::]:44979
[14:11:18] ngrok not configured (only needed when connecting to remotely hosted bots)
[14:11:18] Connecting to bots hosted remotely
[14:11:18] Edit ngrok settings
[14:17:31] -> POST 202 [conversationUpdate]
[14:17:31] -> POST 202 [conversationUpdate]
[14:17:33] -> POST 202 [message] hello
[14:17:34] <- POST 200 Reply[message]
[14:17:34] <- POST 200 Reply[event] Debug Event  `

I've read all issues cases on Git, but still cannot hear any sound from the bot.
Will be greatfull for help.Maybe I do something wrong but it's hard to see from my side:)

Cross linking duplicate Stack Overflow question: https://stackoverflow.com/questions/50740112/text-to-speech-doesnt-work-and-no-errors-showed-in-botemulator

removed from stackoverflow

@meksikann sorry for the delay, can you confirm which version of Ubuntu are you using?

@stevengum hi. it's Ubuntu 16.04 LTS

@meksikann sorry for the delay, I'll try to get a repro on this tomorrow or the day after.

@stevengum any updates here? :)

@meksikann Sorry for the delay in getting back to you.
Bing Speech underwent a big API update to Speech Services back at this year's Ignite. Because of this, Bing Speech no longer allows the creation of new speech bots, and Bing Speech will be deprecated in 10/2019.
Our plan is to have Speech Services supported (through the latest Web Chat) on Emulator very soon, and that progress can be tracked here.
This update would mean that bots using Speech Services can support speech. At the moment there is no plan to back-support Bing Speech in Emulator or Web Chat. For more information on Web Chat supporting Speech Services, please take a look at https://github.com/Microsoft/BotFramework-WebChat/issues/1336.


Consider better structure of generated code

Right now, generated code is bloated into the namespace where macros are used. There are also strange limitations on naming of the modules for traits, which creates a place for mistakes.
I would prefer to isolate things a bit. All generated things should go to sv module (so if we #[contract], it would have things generated as sv::ExecMsg, sv::QueryMsg, etc). This way, rules about how to avoid naming collisions would be easy: single contract/interface call per module, but we eventually want the module to be named however the user wants to. Additionally "if you want to use sylvia, do not create sv modules yourself).
Additionally, I want to rename all tests-related generated modules to mt - we want to keep them short to be easy to type around.

Closed in favor of #167


:seedling: Add npm run test and update github action ci-actions.yml to use it

Add a npm run test script to the root package and adjust the Github Action to run from the root directory.  This allows for proper installation of any shared dependencies in the root package.json, and for test scripts to be run in each workspace.
Note: The cli options given in ci-actions.yml for the test script were not actually being passed to the jest command.  An extra -- is needed to send those options.  Those adjustments have also been made.
Note 2: Using npm clean-install in the ci-actions.yml will cause ci tests to fail if package-lock.json has not been updated in a PR. This version of install prevents npm from updating the lock file.
Extracted from #895

Looking great - Thanks @sjd78

@ibolton336  - I think the codecov-action needs to be fixed to upload the right thing since the working directory is changed.  See https://github.com/konveyor/tackle2-ui/pull/895#issuecomment-1554696021 -- "No coverage uploaded for pull request base..."

@ibolton336 - I think the codecov-action needs to be fixed to upload the right thing since the working directory is changed. See #895 (comment) -- "No coverage uploaded for pull request base..."

All fixed.  Needed to give the codecov/codecov-action@v1 action a directory glob to work from.


Opening a terminal in Multi-root workspace appends cwd option for new terminal.

Does this issue occur when all extensions are disabled?: Yes

VS Code Version: 1.63.2
OS Version:

Steps to Reproduce:

Create a multi-folder workspace (with one named 'Build')
Set the setting: "terminal.integrated.cwd": "${workspaceFolder:Build}"

{
    "folders": [
        {
            "name": "Build",
            "path": "build"
        },
        {
            "name": "Core",
            "path": "core/src"
        },
    ],
    "settings": {
        "terminal.integrated.cwd": "${workspaceFolder:Build}"
    }
}

When creating a new terminal with the toggle-terminal shortcut (workbench.action.terminal.toggleTerminal, Ctrl+'), it works as expected, and opens in the 'Build' folder as specified in the setting.
However, when using the other option, to specify the folder (workspace.action.terminal.new, Ctrl+Shift+'), and you select which folder to open, it concatenates the current workspace folder of whatever file you have open, plus the one specified in the setting, and both are full, absolute paths.
So when viewing a file inside of 'core\src\path\to\file', it tries to open it somewhere like this:
C:\Users\luke.meppem\Documents\FooBar\core\src\C:\Users\luke.meppem\Documents\FooBar\build.
There is a hack workaround, by overwriting terminal.integrated.cwd in each sub-folder, and have it set back to ./.
However, this needs to be done in every single sub folder.
I think that when specifying the cwd of the new terminal using workspace.action.terminal.new, there should be a setting to not append the specified cwd for new terminals, as that's already specified by selecting it.
But when opening a terminal without specifying the cwd (like using toggle when you have no terminal, or with split terminal), then it should use the cwd.

The behaviour seems to have changed in newer versions of vscode.
Testing in dev versions (1.66.0), the following behaviour is observed:
Setting: "terminal.integrated.cwd": "${workspaceFolder:Build}" now works on toggleTerminal properly, and opens in the 'Build' folder.
However, creating a new terminal using a specified workspace (workspace.action.terminal.new, Ctrl+Shift+') always creates the terminal in the C:\Users\luke.meppem\Documents\FooBar\build, regardless of the option chosen from the provided workspace folders.
I believe this was fixed in this commit:
https://github.com/microsoft/vscode/commit/14732d4924d27c0d22d8e91640a22e5198044e19
Going through vscode's code, it's clear to see why this is (terminalActions.ts):
It gets the workspace from what you selected:
const workspace = await commandService.executeCommand<IWorkspaceFolder>(PICK_WORKSPACE_FOLDER_COMMAND_ID, [options]);

Sets the cwd to that:
eventOrOptions.cwd = workspace.uri;

Then gets the cwd config option:
const cwdConfig = configurationService.getValue(TerminalSettingId.Cwd, { resource: workspace.uri });
if (typeof cwdConfig === 'string' && cwdConfig.length > 0) {
    const resolvedCwdConfig = await configurationResolverService.resolveAsync(workspace, cwdConfig);

Because cwdConfig is ${workspaceFolder:Build}, it completely overrides the selected workspace folder:
    if (isAbsolute(resolvedCwdConfig) || resolvedCwdConfig.startsWith(AbstractVariableResolverService.VARIABLE_LHS)) {
        	eventOrOptions.cwd = URI.from({
	        	scheme: workspace.uri.scheme,
	        	path: resolvedCwdConfig
        	});

instead of using the selected workspace.
To sum up the current state of the problem:
You cannot set a default terminal cwd, without interfering with the cwd when opening a new terminal in a given workspace folder.

Related: https://github.com/microsoft/vscode/issues/148066
This might be fixed with the recent PRs to the quick pick.

Would it help to make the folders path themselves contain absolute paths instead?

I have a similar issue I'm considering logging; where workspace files break on starting the terminal, if said workspace file was opened via a different dir than it was created.

turns out we could avoid a lot of issues by just making the paths absolute.

These issues are all closely related:

https://github.com/microsoft/vscode/issues/142520
https://github.com/microsoft/vscode/issues/148066
https://github.com/microsoft/vscode/issues/189166

Can confirm that the Issue is still present. Cannot set default terminal CWD to anything other than blank or a relative path on Ubuntu.


test-softlayer-rhel69-x64-1 got " /lib64/libc.so.6: version `GLIBC_2.14' not found "

test build running on test-softlayer-rhel69-x64-1 and got:
/home/jenkins/workspace/TestBuild_Sandbox/openjdkbinary/j2sdk-image//bin/java: /lib64/libc.so.6: version `GLIBC_2.14' not found (required by /data/home/jenkins/workspace/TestBuild_Sandbox/openjdkbinary/j2sdk-image/bin/../lib/jli/libjli.so)
https://ci.adoptopenjdk.net/view/work in progress/job/TestBuild_Sandbox/174/console

@sophia-guo this is expected behavior for our OpenJ9 builds are they are currently built on ubuntu16. I recommended getting a rhel6 machine setup for you so that we could catch these errors in the future. Please test with one of our hotspot binaries as these should now work on rhel6 and rhel7. We will swap the openj9 builds to also build with a lower glibc version once this release is out of the way

This is traked in https://github.com/AdoptOpenJDK/openjdk-infrastructure/issues/256

Thanks @gdams . I also noticed you have created job https://ci.adoptopenjdk.net/view/work in progress/job/openjdk-runtime-test/  to track this. That's great!
Is that the reason test-softlayer-rhel69-x64-1 is re-enabled? The thing is if it is enabled with same labels as other tests machines  it could be dispatched to all our routine jobs(jobs under *test tabs) and fails the jobs.
We can test hotspot binaries on those rhel6 and rhel7 machines using a non-routine job(under work in progress tab) manually. @smlambert  has created a test job(or in progress) to do this. However for those in progress machine probably we need to use a different label convention before its available for routine jobs, say using its hostname. When it's good just update labels and it's ready for all routine jobs.

I re-enabled test-softlayer-rhel69-x64-1 but removed the test label from it so the test jobs won't try to use it.


boards: bl654_dvk: Add BL654 DVK board

Add the Laird Connectivity BL654 DVK board to zephyr.
This board is based off of the nrf52840-pca10056.

Codecov Report

Merging #13274 into master will decrease coverage by <.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #13274      +/-   ##
==========================================
- Coverage   48.75%   48.74%   -0.01%
==========================================
  Files         319      319
  Lines       46871    46871
  Branches    10835    10835
==========================================
- Hits        22850    22849       -1
  Misses      19394    19394
- Partials     4627     4628       +1

Impacted Files
Coverage Δ

arch/posix/core/posix_core.c
90.9% <0%> (-1.02%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d6a19af...0766274. Read the comment docs.

Hi @rerickson1 : Please note that one test is failing in this new proposed board:
https://app.shippable.com/github/zephyrproject-rtos/zephyr/runs/34156/1/tests

Looks good to me, I know @nashif made a few doc changes related to boards, so not sure if this is in sync with those.

Is this without the external oscillator? If so, I wouldn't have expected all radio features to work. We had huge problems getting BLE to work with Zephyr on these boards before connecting the external osc.

Is this without the external oscillator? If so, I wouldn't have expected all radio features to work. We had huge problems getting BLE to work with Zephyr on these boards before connecting the external osc.

By default the 32kHz ext oscillator is not connected.  We have one on the board that can be hooked up easily with some solder bridges.

Is there anything else needed on this.  Again, the shippable error seems unrelated to my changes.  Similar to the BL652 DVK board addition, I believe #13335 fixes the CI issue.

Can you rebase to fix the merge conflict.


NoSuchMethodError in io.javalin.openapi.plugin.DefinitionConfiguration

I recently encountered the following exception (Javalin 6.3.0), which occurs when trying to access the swagger UI:
[JettyServerThreadPool-165] ERROR io.javalin.Javalin - Fatal error occurred while servicing http-request
java.lang.NoSuchMethodError: 'io.javalin.openapi.plugin.DefinitionConfiguration io.javalin.openapi.plugin.DefinitionConfiguration.withInfo(java.util.function.Consumer)'
	at convex.restapi.RESTServer.lambda$8(RESTServer.java:135)
	at io.javalin.openapi.plugin.OpenApiPlugin$createDocumentation$1.invoke(OpenApiPlugin.kt:36)
	at io.javalin.openapi.plugin.OpenApiPlugin$createDocumentation$1.invoke(OpenApiPlugin.kt:25)
	at kotlin.SynchronizedLazyImpl.getValue(LazyJVM.kt:74)

I would expect this not to throw such an exception, because the code compiles fine and the target method apparently exists.
Calling code looks like:
	protected void addOpenApiPlugins(JavalinConfig config) {
		String docsPath="openapi-plugin/openapi-default.json";

		config.registerPlugin(new OpenApiPlugin(pluginConfig -> {
                    pluginConfig
                    .withDocumentationPath(docsPath)
                    .withDefinitionConfiguration((version, definition) -> {
                    	DefinitionConfiguration def=definition;
                        def=def.withInfo((Consumer <OpenApiInfo> )info -> {
					info.setTitle("Convex REST API");
					info.setVersion("0.7.0");
                        });
                    });
		}));

		config.registerPlugin(new SwaggerPlugin(swaggerConfiguration->{
			swaggerConfiguration.setDocumentationPath(docsPath);
		}));
		config.registerPlugin(new ReDocPlugin(reDocConfiguration -> {
	        reDocConfiguration.setDocumentationPath(docsPath);
	    }));

		for (JsonSchemaResource generatedJsonSchema : new JsonSchemaLoader().loadGeneratedSchemes()) {
	        System.out.println(generatedJsonSchema.getName());
	    }
	}

This looks like a bug, though I could be doing something wrong?

This function is definitely there:

https://github.com/javalin/javalin-openapi/blob/main/javalin-plugins/javalin-openapi-plugin/src/main/kotlin/io/javalin/openapi/plugin/OpenApiConfiguration.kt#L55-L57

Maybe you faced some issue with local internal build cache? :thinking: Does it throw when you're launching your code within IDE, or it comes from the final jar?

Thanks @dzikoysk ! I think I managed to solve the problem though I'm not entirely sure how. Possibly some interaction with the way that Eclipse handles JPMS modules?


Middleware: Performing actions after response completes

I'm trying to understand how I could do something after a response completes in a middleware.
Take a request duration logging middleware for example.
I would normally expect to be able to do something like the following
router.use(async (req, res, next) => {
  let start = performance.now();
  await next();
  let duration = performance.now() - start;
  console.log(`Request took ${duration} milliseconds`);
});

However it appears that next() returns immediately and doesn't allow anything useful to be done post request.
Is this by design, or am I missing something?

Sorry for the noise, I figured it out by looking at the express documentation.
srv.use(async (req, res, next) => {
  const start = performance.now();
  res.on('finish', () => {
    const durationMs = (performance.now() - start).toFixed(3);
    log.info(`Handled request to ${req.path} in ${durationMs}ms`);
  });
  next();
});

I do still think, however that the promise version of next() is easier to understand and could be useful.


[Project] Implement "Slack" Puppet

Hello students!
Since the Wechaty is a universal messaging SDK. I believe we can implement this with Slack, but not only on Slack. The Slack and Wechat message may be able to sync the messages. So while there is more open idea we can integrate. I think this would be good project for summer
Link to #30
Required skills for all projects

git version control
collaborative software development on github.com
software development in at least one of Wechaty's six languages on at least one of Linux, macOS, and Windows.

Required skills: TypeScript programming language, Slack API.
Useful Links
Introducing Wechaty Puppet Service (Providers)

https://github.com/wechaty/wechaty-puppet
https://github.com/wechaty/wechaty-puppet-mock

Link to https://github.com/wechaty/wishlist/issues/46


[29] Scene switching in game mode

This adds functionality to clean up and create a new scene while the project is running. Along with this, we can mark entities to persist between scenes.

Created event macro that can pass arguments
Collider events pass actual collider
Made close a struct property of main
Some errors passed to editor
SDL init moved to main module
Refactoring

 Scene switching in game mode


[draft] First throw at concurrent r53 metrics collection

This PR implements a very basic asynchronous route53 metrics collection.
When initializing the Route53 Exporter, a goroutine is started that periodically collects all the r53 metrics and saves them in the cachedMetrics array. upon calling the "real" Collect function, the only the metrics from that cache are pushed to the channel.
One metric is added to the r53 metrics:
aws_resources_exporter_route53_last_updated_timestamp_seconds
which records the unix timestamp of the last time an update has finished.
This PR currently requires a config update as well, becuase route53.timeout has been renamed to route53.interval. I'll open up a PR for that when we've decided to move forward.

Hey @janboll! Thanks for your comments!

Thank you for providing this Pull Request! I want to understand the motivation a little better. Why did you update only the route53-related code to run concurrently?

We are planning to use the aws-resource-exporter to monitor our privatelink aws infrastructure. This currently includes around 500 route53 hosted zones, which are constantly increasing in number. This is a major bottle neck right now, as the r53 api rate limits at 5 requests / second. A metrics are synchronously collected when /metrics is called, it takes around 3 minutes in our environment to return the metrics.
The reason I've only updated the R53 part instead of other exporter is to get early feedback and quickly iterate on the idea. If we decide that we want to move forward with this kind of async collection/serving we can extend this to other exporters.
Also, this is the part that makes the metrics collection horribly slow for us, so it made sense to start here.

How did you plan on testing this change?

Until now, i only ran tests locally against our own environments. Are there any specific test that you are running to verify it in your environment?

Nothing specific I had in mind. I kind of hoped you would volunteer to add some tests here. ;)
But I'd be fine if you run it locally and on stage for a while before promoting it to prod.

@janboll I've looked a bit into unit testing the functionality, but i'm afraid this is way beyond the scope of this PR. I would assume, testing requires implementation of a mock aws client, as we are doing in the aws-account-operator. If you want, I can throw together a POC implementation of that in a separate PR.

Since there are no existing tests or infrastructure, I'm more keen to run this in stage for a bit to validate everything, and then push to prod when ready.
In my experience, when trying to "just add some tests" to code that isn't already written with tests it tends to require a non-trivial amount of refactoring, which as you know will make this PR even larger and more troublesome to review.
I'll open a card for specifically adding unit tests, and will add it to the epic containing this work so that it doesn't get lost.

I've created https://issues.redhat.com/browse/OSD-13040 to track the unit testing work.
Is there anything left we need to do for this to get merged?


Add snippet for RTDB increment on modular SDK

The documentation is missing a code snippet for the RTDB increment operation on the v9/modular API.

Apparently I added this snippet ~2 years ago already. :(


No warning for too few characters for wifi password- Validation should not allow passwords below 6 chars

This was addressed in 1be14165


[Proposal] Keeping Redot in sync with Godot through multiple branches per feature

If there is a feature, lets say rebranding Godot to Redot, we normally make a branch, redot-rebrand and merge it to master through a PR. This is ok in normal cases, though the problem then comes when needing to merge Godot back.
Lets get naming right first:

redot-master (master branch of redot, normally behind godot-master but also has few ahead of godot-master)
godot-master (normally has some features but lacks some from redot)
redot-rebrand (the feature)

If we would merge redot-rebrand into redot-master, it would become out of sync with godot-master, and when we merge rebase redot-master with godot-master, we would have conflicts.
Another way of doing it, is to instead rebase only redot-rebrand from godot-master, and then at the end when we merge it into redot-master(or a release branch) there are no conflicts.
The benefit of this comes when we have 100 branches (redot-feature1, redot-feature2, ...). If we create a redot-master with all of these, the merge conflict from godot-master becomes unmanageable. If we instead rebase each branch (redot-feature1 rebase from godot-master, ..) then when we do merge to release branch, there are no conflicts.
This way also, the person who wrote the feature is in charge of maintaining it and rebasing it, which makes sense. The alternative is a person rebasing one big big branch, which can be very difficult.

"Another way of doing it, is to instead rebase only redot-rebrand from godot-master, and then at the end when we merge it into redot-master(or a release branch) there are no conflicts."
Ahhhh ok, I see what you're proposing now. This sounds good if we do decide to use feature branches on the redot repository. We still aren't decided as a crew if we want to keep doing feature branches on the main repo, but if we do then yes I see what you mean. I'll wait for spartan and trashguy to chime in as well


Submodule being added twice --- Duplicate name UserWarning.

[X] I am on the latest Poetry version.
[X] I have searched the issues of this repo and believe that this is not a duplicate.
[X] If an exception occurs when executing a command, I executed it again in debug mode (-vvv option).

OS version and name: MacOS High Sierra 10.13.6
Poetry version: 0.11.4
Link of a Gist with the contents of your pyproject.toml file:  https://gist.github.com/andersgs/2207a4ea2cbe0f02f0ce7a817ba59a7a

Issue

Hello.
I am loving poetry. I have a module I am writing, and it has a submodule:
bigsdbcli/
├── BigsDBOAuth.py
├── __init__.py
├── configs
          ├── __init__.py
          └── config_test.toml

When I run poetry build it seems to copy the submodule in twice, leading to a "Duplicate name" Warning:
poetry build -vvv
Creating virtualenv bigsdbcli-py3.7 in /XXXXXXX/pypoetry/virtualenvs
Using virtualenv: /XXXXXXX/bigsdbcli-py3.7
Building bigsdbcli (0.1.0)
 - Building sdist
 - Adding: bigsdbcli/BigsDBOAuth.py
 - Adding: bigsdbcli/__init__.py
 - Adding: bigsdbcli/configs/__init__.py
 - Adding: bigsdbcli/configs/config_test.toml
 - Adding: bigsdbcli/configs/__init__.py
 - Adding: bigsdbcli/configs/config_test.toml
 - Adding: pyproject.toml
 - Adding: README.rst
 - Built bigsdbcli-0.1.0.tar.gz

 - Building wheel
 - Adding: /var/folders/8m/70mj29nx7vn5prz6hx2kgxpjt74n0_/T/tmpzhplo28u/bigsdbcli-0.1.0/bigsdbcli/BigsDBOAuth.py
 - Adding: /var/folders/8m/70mj29nx7vn5prz6hx2kgxpjt74n0_/T/tmpzhplo28u/bigsdbcli-0.1.0/bigsdbcli/__init__.py
 - Adding: /var/folders/8m/70mj29nx7vn5prz6hx2kgxpjt74n0_/T/tmpzhplo28u/bigsdbcli-0.1.0/bigsdbcli/configs/__init__.py
 - Adding: /var/folders/8m/70mj29nx7vn5prz6hx2kgxpjt74n0_/T/tmpzhplo28u/bigsdbcli-0.1.0/bigsdbcli/configs/config_test.toml
 - Adding: /var/folders/8m/70mj29nx7vn5prz6hx2kgxpjt74n0_/T/tmpzhplo28u/bigsdbcli-0.1.0/bigsdbcli/configs/__init__.py
 - Adding: /var/folders/8m/70mj29nx7vn5prz6hx2kgxpjt74n0_/T/tmpzhplo28u/bigsdbcli-0.1.0/bigsdbcli/configs/config_test.toml
/usr/local/Cellar/python/3.7.0/Frameworks/Python.framework/Versions/3.7/lib/python3.7/zipfile.py:1448: UserWarning: Duplicate name: 'bigsdbcli/configs/__init__.py'
  return self._open_to_write(zinfo, force_zip64=force_zip64)
/usr/local/Cellar/python/3.7.0/Frameworks/Python.framework/Versions/3.7/lib/python3.7/zipfile.py:1448: UserWarning: Duplicate name: 'bigsdbcli/configs/config_test.toml'
  return self._open_to_write(zinfo, force_zip64=force_zip64)
 - Built bigsdbcli-0.1.0-py3-none-any.whl

As you can see, it adds the submodule twice.
I have tried deleting the virtualenv, and running the command again, but nothing changes.
Thank you.
Anders.

Closing this. If this is still an issue feel free to reopen


[Bug]: AgentDelegateObservation is format as json for CodeActAgent

Is there an existing issue for the same bug?

[X] I have checked the troubleshooting document at https://docs.all-hands.dev/modules/usage/troubleshooting
[X] I have checked the existing issues.

Describe the bug
From the log below, the observation of BrowsingAgent finishing its task is sent to CodeActAgent as json.
This seems to be because of this line: https://github.com/All-Hands-AI/OpenHands/blob/45066f19dcec21b718e1d5dfb0586ae1c3091a90/agenthub/codeact_agent/codeact_agent.py#L156
Current OpenHands version
0.9.3

Installation and Configuration
`make start-backend`

Model and Agent

Model: gpt-4o
Agent: CodeActAgent

Operating System
Linux
Reproduction Steps

make start-backend
On browser type: "go to "All-Hands-AI" github profile and get number of repositories they have"

Logs, Errors, Screenshots, and Additional Context
No response

@enyst This might be the reason for your observation last time. I'm not sure if this is expected and simply modifing the observation above is good enough.

Hmm why is this a bug? Even before the "Message()" implementation, the observation was converted to a LLM-formatted message format?


[994] Personal details form validation bug

Context
https://trello.com/c/ob4qJ14N/994-personal-details-no-error-shown-for-inputting-numbers-into-first-name-middle-name-last-name
Changes proposed in this pull request

Add custom validator with regex pattern and use for name fields on personal details form
Unit test for validator
Add middle name validation but allow it to pass if left empty

Guidance to review
Create new record or edit existing one and see if validation is triggered if invalid details (e.g a number) entered on first name, middle name and last name fields on personal details form.
https://rtt-review-pr-496.herokuapp.com/

 Personal details: No error shown for inputting numbers into First Name, Middle name, Last name

We should be really loose with this validation. At the moment really common names will be excluded - eg O'leary

Unless we know for sure a name can't include a character, I don't think we should be validating it.

PR closed because there needs to be minimal validation on name fields, and should include numbers and even symbols as per the design system.  https://design-system.service.gov.uk/patterns/names/
Definitely edge case but there is a possibility of trainees using numbers and characters in their names.


Weak events: Avoid checking all array values when removing

What does the pull request do?

No need to check all 8 values when array size is known and elements outside of that boundary are null.

You can test this PR using the following package version. 0.10.999-cibuild0020093-beta. (feed url: https://nuget.avaloniaui.net/repository/avalonia-all/index.json) [PRBUILDID]

You can test this PR using the following package version. 0.10.999-cibuild0020200-beta. (feed url: https://nuget.avaloniaui.net/repository/avalonia-all/index.json) [PRBUILDID]


feedbackBuffer is not used

Hi, the feedbackBuffer value calculated here does not appear to be used anywhere:
https://github.com/JDSherbert/Audio-Phaser-Effect/blob/fb8cce804e930fa3e896a519bc93fb510782e6fe/Phaser.cpp#L24

Good find, I will take a look into this!