Specification of kernel directory on command line?

Kernel specification files can currently be one of two locations - System wide or user specific.
Would it be possible to add the ability to specify a kernel directory on the command line? Something like
ipython notebook --kernel_dir=/Users/me/my_kernels/
This could take precedence over the other 2 locations.
One example where this would be useful:
I'm currently trying to build a portable Jupyter install on windows that includes an R kernel. It's for teaching use on a heavily locked-down managed desktop.
The install is based on the PortablePython project and works reasonably well. I have 2 problems, however:

I have to install kernels to the user-profile which defeats the portability somewhat.
If I move the directory containing the portable install, I have to regenerate my kernels.

The enhancement proposed here would fix everything since I could specify the kernel_dir as a relative path in a launch shortcut.

Is sys.prefix within the portable install directory? You should be able to put kernel specs in sys.prefix + '/share/jupyter/kernels/' and it will find them.

Yes, that works nicely. Thank you!
Furthermore, If I put the portable R folder within the directory specified by sys.prefix, this kernel appears to works fine:
{"argv": ["R/R-Portable/App/R-Portable/bin/i386/R.exe","-e","IRkernel::main()", "--args","{connection_file}"],  "display_name":"Portable R" }
I'm going to test the portability by moving between machines but things are looking good!
Thank's for the swift and useful reply!

Great. I'll leave this open because I think specifying a relative path in argv works by happy coincidence rather than deliberate design, and we might want to formalise a way to do that.

Thanks. For info, here are the steps I took to get everything working using Portable Python and Portable R
http://www.walkingrandomly.com/?p=5734

Great, thanks for writing that up. It looks like portable builds of Python will be an official thing when Python 3.5 comes out, so we won't have to rely on a not-very-maintained third party build. I quite like the idea of making 'Jupyter on a stick' - a USB stick with Jupyter, IPython, R and whatever else makes sense.

jupyter/jupyter_client#8 would make it possible to specify an executable with a relative path from sys.prefix, like ['{prefix}/bin/R', ...].


support for by-position and by-params

eth_getBlock, [0, 1]
eth_getBlock {blockNumber: 1, from: 0}

:tada: This issue has been resolved in version 1.0.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Add the ability to select connections

📝 Description of the Change
Adds the ability to select connections.
Relevant properties:

NodifyEditor.SelectedConnection
NodifyEditor.SelectedConnections
NodifyEditor.CanSelectMultipleSelections
BaseConnection.IsSelected
BaseConnection.IsSelectable

(click to expand) Example of selectable custom connection:

<Line X1="{Binding Source.Anchor.X}"
      X2="{Binding Target.Anchor.X}"
      Y1="{Binding Source.Anchor.Y}"
      Y2="{Binding Target.Anchor.Y}"
      StrokeThickness="5"
      nodify:BaseConnection.IsSelectable="True"
      nodify:BaseConnection.IsSelected="{Binding IsSelected}">
    <Line.Style>
        <Style TargetType="Line">
            <Setter Property="Stroke"
                    Value="Red" />
            <Style.Triggers>
                <Trigger Property="nodify:BaseConnection.IsSelected"
                         Value="True">
                    <Setter Property="Stroke"
                            Value="Green" />
                </Trigger>
                <Trigger Property="nodify:BaseConnection.IsSelectable"
                         Value="True">
                    <Setter Property="Cursor"
                            Value="Hand" />
                </Trigger>
            </Style.Triggers>
        </Style>
    </Line.Style>
</Line>

#138

I was checking how everything work to implement connection selection on my side, I was thinking of using the same logic as the nodes with a custom Selector class (or MultiSelector to support shift click ?) maybe use a state to handle the overlap of selection between nodes and connections. Was simply wondering if that would be a good way to do so and if I understood how your code work correctly :)
Only change I would make is to doesn't allow a connection and node to be selected together, but that's opinionated and it's possible to handle the events to do so anyway.

Using a Selector derived class should work, but that involves more work. I did it this way because I don't need all the features of a Selector, for example, virtualization, and I can also extend this solution to allow multiple selections.
However, since NodifyEditor supports custom connections (not derived from BaseConnection), I'm wondering what's the best solution in terms of developer experience to have the custom connections selectable as well.

However, since NodifyEditor supports custom connections (not derived from BaseConnection), I'm wondering what's the best solution in terms of developer experience to have the custom connections selectable as well.

My two cents: if someone use your library but want to have a fully custom element they can't expect to have the same functionnalities than if they use the base classes provided. That the same as why you don't use the Selector class, if you need the features it provide then you just inherit the class, otherwise you have to implement the rest yourself.

I totally agree with your perspective. If a developer chooses to use custom elements, it's reasonable to expect that some functionality from the base classes might need to be re-implemented. However, when it's not overly complex to support those features, I try to include them for a better developer experience — and in this case, I did just that.
Regarding the multi-selection, I ended up using the MultiSelector class because, it turns out that it's not so easy to implement multi-selection from scratch.


General Prefix Greater Than 1 Character Breaks Parsing

Overview
Hello I'm switching to this package from dgc where I was using a prefix that was larger than one character (!coomer) and parsing of commands was working correctly. However attempting to use the same pattern with shireikan causes a "command not found" error when attempting to parse a command. Changing from !coomer to ! works, however even using !c causes the error to happen again.
It would be a good feature to have if we could have longer than 1 character prefixes, as well as the ability to specify alternate prefixes.
Reproduction

Set prefix to greater than 1 character (ie !coomer)
Try to run a command like !coomer help and observe error

The problem is, that shireikan can not handle prefixes with spaces.
For better understanding, take a look at the parsing of the prefix:
!ping hey
^^    ^
||    |
||    +-- Argument
|+------- Invoke
+-------- Prefix

Using prefixes with multiple characters is possible, for example, the default prefix of my bot shinpuru which is sp!:
sp!ping hey
^  ^    ^
|  |    |
|  |    +-- Argument
|  +------- Invoke
+---------- Prefix

Following this structure, you would need to invoke commands as following:
!coomerping hey
^      ^    ^
|      |    |
|      |    +-- Argument
|      +------- Invoke
+-------------- Prefix

So, you would need to define your prefix with a leading space: !coomer .
The thing is, that would actually panic when parsing a command message. I've fixed this in the following commit: 4a066f2f293f2af240226a6c9208568b2f949f2b.
When this solution is okay for your use case, I would close this issue. Maybe I'll consider to implement an option to allow white spaces between prefix and invoke, but that would need further restructuring of the command handler.

If this does not fix the issue in your use case, I'll re-open the issue. ^^


Never Ready

I followed the installation instructions exactly, and used took index.ios.js from the example. When I run the app everything renders, but onReady never fires. I'm using react-native 0.21.0. How can I troubleshoot this?

Could you check by adding a breakpoint in this function here: RCTYouTube.m#L102-L113
If the breakpoint is called, the issue is that RN is not able to deliver the event to JS.
If the breakpoint is not called, the issue is somewhere in the Youtube webview not calling delegate methods.

I checked that. The breakpoint was not called.

The same problem

I have the same issue. I also get "Native component for myProjectName does not exist" warning.

Hi guys,
onReady is called in my case.
I added this onReady={()=>{console.warn('READY');}} in my YouTube tag and it is called ;)
RN 0.25.1 and react-native-youtube 0.7.1

Was this fixed? Downgraded to react-native 0.38, using react-native-youtube 0.8.0.
Video plays and seekTo() works, however onReady, onChangeState and onChangeQuality are never called.

Was this fixed?

Is this fixed yet?


Run selected text in integrated terminal

We should be able to select some lines and have them sent to the terminal, either via a keyboard shortcut or by a right click action.

Can i suggest we expose this same functionality via a command as well - for extension developers.
This way extension developers can launch the integrated terminal window and run some commands to set up the environment or launch a program for CLI debugging.

@DonJayamanne a regular command (not extension API) would suffice for this?

Yes, that would.

@DonJayamanne you can try this out in Insiders tomorrow via the command palette, there is no keybinding though as everything seems to be taken (modifiers+enter, ctrl+shift+r)

@Tyriar, does this change also allow an extension developer to send some text to the terminal window?
What I would like to do is, use the terminal to for debugging python code.

It sends the selected text in the editor only, it's a command so it doesn't take arguments. I think https://github.com/Microsoft/vscode/issues/547 is what you're after.

@Tyriar, thanks, will check that out.


⚠ Bofrost.at has degraded performance

In 9c44d9e, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 822 ms

Resolved: Bofrost.at performance has improved in 28a794d after 6 minutes.


Detect when the user points the camera to a specific location to trigger an event

Is your feature request related to a problem? Please describe.
I'm developing an app with accessibility features for people with visual impairments. It shows the places around with their names, but for that specific requirement this is not enough.
Describe the solution you'd like
I'd like to implement a means of when the user points the camera to a specific place, some event is triggered. That way I could make the app trigger a voice command saying the place's information (like name, description, distance, etc).
Describe alternatives you've considered
Because I'm using a webview of Android to show the aframes, I tried to implement that feature inside the android app, using the android's geolocation api, but I had no success.
Additional context
As I said i'm using the AR.js within an android app. It's possible to create an interface to comunicate the AR.js with the android app.
Is there any way to do this feature?

we can  continue discussing this on new AR.js repo: https://github.com/AR-js-org/AR.js/


className not applied to template

I'm submitting a ...  (check one with "x")
[X] bug report => search github for a similar issue or PR before submitting
[ ] feature request
[ ] support request

Current behavior

json file contains:
[
{
"className": "banner",
"template": "Titlesub-title"
}
]
angular component .css file contains:
formly-field.banner {
color: white;
background: black;
}
Expected behavior

I expect the rendered html to be reverse color, i.e., white on black
Minimal reproduction of the problem with instructions

simple code above
What is the motivation / use case for changing the behavior?

changing styles
Please tell us about your environment:

Mac OS X (latest), IntelliJ IDE, webpack

Angular version: 2.0.X

5.X

Browser: [all | Chrome XX | Firefox XX | IE XX | Safari XX | Mobile Chrome XX | Android X.X Web Browser | iOS XX Safari | iOS XX UIWebView | iOS XX WKWebView ]

Chrome

Language: [all | TypeScript X.X | ES6/7 | ES5]

Node (for AoT issues): node --version =

tested on my side and seems working to me here is a an example: https://stackblitz.com/edit/angular-nkue6r?file=styles.css
for style you have to add display: block; for formly-field.banner selector

Thanks! Interestingly, if I put the same css code in the component css file, it does not work. For example, my angular component is called ngx-formly:
@Component({
selector: 'app-ngx-formly',
templateUrl: './ngx-formly.component.html',
styleUrls: ['./ngx-formly.component.css']
})
Putting the style in ngx-formly.component.css does not work. Putting the style in the global style.css works.

@emiles002 add ::ng-deep before the selector, also I suggest you to learn more about view encapsulation to understand how style is applied in angular

That worked. Thanks for the help and tips. My first angular app, here.

Doesn't work for me. Looks like ::ng-deep is deprecated.

@emiles002 add ::ng-deep before the selector, also I suggest you to learn more about view encapsulation to understand how style is applied in angular

::ng-deep is now deprecated, how can we patch styles by className to custom formly-templates without ::ng-deep and ViewEncapsulation.None?

related to https://github.com/angular/angular/issues/25160, I would expect a replacement plan from angular team (probably slotted)

here are some alternatives as I think angular/angular#25160 may take some time to be resolved and it's not recommended to rely on a deprecated feature 😄:

change the default view encapsulation (https://stackblitz.com/edit/angular-nkue6r?file=app%2Fapp.component.ts):

@Component({
  selector: 'my-app',
  encapsulation: ViewEncapsulation.Native,
  styles: [`
    formly-field.banner {
      color: white;
      background: black;
      display: block;
    }
  `]
})
export class AppComponent {}

or simply use the global style


Does it really work as PWA app? after install on "PWA" on iphone xr, header disappeared and can't click on anything clickable.

Does it really work as PWA app? after install on "PWA" on iphone xr, header disappeared and can't click on anything clickable.  Thank you.

https://github.com/hbstack/pwa/assets/17720932/0b834e33-b43c-4289-8f89-9add1b7556f3
Just tested, works as expected when installing via FireFox on theme.hbstack.dev. I guess the installation wasn't completed on your side, but there isn't enough info to check. What site do you test? Does the site work on when install via FireFox?
Btw, the header will diappear when scrolling down, and show up when scrolling up.

Tested theme.hbstack.dev on iPhone XR via BrowserStack, works fine.

the nav/header disappeared as the the "install on Ubuntu" for example. (any pages are the same). In order to for nav/header to be appear, we can scroll down a bit, then scroll up a bit, then the nav/header appeared with all the functions working.
At the same time, if we want the nav/header appear on the page （as start reading the content from the top, can we hit the back to up button, which somehow the nav/header appear again)
Also for the nav/header to be appear, we can scroll down a bit, then scroll up a bit the nav/header appear）
Although with all these issues with the iphone xr,  they doesn't appear on ipad (the nav/header stays on top nicely).  not sure if ios version problem or my iphone xr problem.
This doesn't seem to be the issue of themes, will close the issue now.

While nav/header appear on ipad. but can't click on search or menu option.

I was able to reproduce it, the JS seems not working on Safari, will look into this this week.

This issue happened on old Safari browsers, I've tested it on iPad and iPhone XR on browserstack, according the test result, the theme works on iOS v15 and iOS v16. There is no plan to support older browsers, so I'm closing it for now.


Make zabbix chef idempotent

I want to see totally separate blocks for Linux and Windows. For example, the original version of recipes/_agent_common_service.rb was divided like this:
# Manage Agent service
if platform_family?('windows')
  service 'zabbix_agentd' do
    service_name 'Zabbix Agent'
    provider Chef::Provider::Service::Windows
    supports :restart => true
    action :nothing
  end
elsif node['init_package'] == 'systemd'
  template '/lib/systemd/system/zabbix-agent.service' do
    source 'zabbix-agent.service.erb'
    owner 'root'
    group 'root'
    mode '0644'
  end

  # RHEL package names it "zabbix-agent"
  service 'zabbix_agentd' do
    service_name 'zabbix-agent'
    supports :status => true, :start => true, :stop => true, :restart => true
    action :nothing
  end
else
  package 'redhat-lsb' if platform_family?('rhel')

  template '/etc/init.d/zabbix_agentd' do
    source value_for_platform_family(['rhel'] => 'zabbix_agentd.init-rh.erb', 'default' => 'zabbix_agentd.init.erb')
    owner 'root'
    group 'root'
    mode '754'
  end

  # Define zabbix_agentd service
  service 'zabbix_agentd' do
    supports :status => true, :start => true, :stop => true, :restart => true
    action :nothing
  end
end

We should be dividing recipes that are cross-platform like this. Don't nest if conditionals inside file resource blocks that only work if the file resource is running where platform_family?('windows').


Update Flash Algo for ARMC6 compiler

The project generator has been updated to include support for Cortex-M33 targets. The uvision project template files need to be updated for ARM compiler 6 projects. The current template causes for following build error:

ArmClang.exe: error: unsupported option '--gnu', did you mean '-fgnu'?

cc @flit

Thanks for pointing this out.


Search under duokan.com doesn't work anymore

https://github.com/Frederick-S/ebooks-api/commit/ec5973c79ea29787fab6e964823dcdf4fb1b01c2


Currently MS Teams client is not supported in non-persistent VDI environments

Currently MS Teams client is not supported innon-persistent VDI environments. This is not published in the articles and customers are asking for official statement from MS regarding that.

@ninadara Hi - Can you confirm this statement, or recommend someone on product side who could? (Also, need suggestions on where to include this info in the docs, if it's accurate and necessary.) Thank you.

@Turgayo can you confirm that we've answered a-mosheh's question in your recent updates to the article?

@Turgayo. We need you to confirm please.

@a-mosheh, thanks for the feeback. I'm investigating and trying to find someone on the PG side that can own this issue. In the meantime, if you have a statement or a suggested update to the article, please include it here by doing the update and doing a Pull Request. Thanks, Tony

Ping @Turgayo

I've assigned two PMs from the product to lend you a hand. We appreciate the feedback. If there are addition/corrections/suggestions to the docs, please edit the topic by clicking Edit (on the right side of the topic) or use VsCode/GtiHub desktop. Let me know how I can help further.

@juturu and @voltarone  Do you have any feedback on this issue? If you are assign an issue, you must help the customer find a resolution. If it's a bug for engineering create a bug for them, if not and a topic needs updated, you can fix the article and issue a PR. Lastly, if it's a no repo or can't be fixed, then let the customer know and close this out.

@krishra85, can you offer any insight here?

Yes, Teams does not have capabilities to support A/V & conferencing in VDI environments yet. The current articles we have only reference Skype for Business capabilities, so I believe this should be taken up as feedback for the Microsoft Teams team (recommend upvoting a User Voice post for this).

Would it be appropriate to mention this in the Known Issues article for Teams, or is there a better place to surface this?

I added this idea to User Voice here: https://microsoftteams.uservoice.com/forums/555103-public/suggestions/34795351-add-capabilities-to-support-a-v-conferencing-in   Please up-vote everyone so we can get some traction on it. Thank you @a-mosheh for the idea. Sorry for the long delay on this!


Debugger - python extension

Added code for python debugging scenario branched off of previous PR. Will set up demo with Ken and Vicky to see whether we want to take it or not.

Pull Request Test Coverage Report for Build 898846716

0 of 0   changed or added relevant lines in 0 files are covered.
3 unchanged lines in 1 file lost coverage.
Overall coverage increased (+0.001%) to 43.425%

Files with Coverage Reduction
New Missed Lines
%

extensions/import/src/wizard/pages/fileConfigPage.ts
3
72.99%

Totals

Change from base Build 886821374:
0.001%

Covered Lines:
26571

Relevant Lines:
55609

💛  - Coveralls

@kburtram Ping 😄

@abist Can this be closed for now?

Closing older PRs.  Please reactivate if still needed.


Remove useless patch files and fix some issues of envoy&istio

Ⅰ. Describe what this PR did
istio:
https://github.com/higress-group/istio/commit/8a08c2421026122bdbdd8f95fb7a20a16e3b499f
envoy:
https://github.com/higress-group/envoy/commit/1fd373ae529a0e1bbbdd39b882e02e1ea787f0e1
https://github.com/higress-group/envoy/commit/a20514683055b4823686b8028c0bb6ffb4ee291e
https://github.com/higress-group/envoy/commit/318c7b5c77dfbacdddedce6f3d79ce7a80f07dea
https://github.com/higress-group/envoy/commit/8c3cc1ac252c8c6d0441d6a9c0b7371610ba32bb
Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 44.34%. Comparing base (ef31e09) to head (28a9cdf).
Report is 70 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1263      +/-   ##
==========================================
+ Coverage   35.91%   44.34%   +8.43%
==========================================
  Files          69       75       +6
  Lines       11576     9821    -1755
==========================================
+ Hits         4157     4355     +198
+ Misses       7104     5139    -1965
- Partials      315      327      +12

see 90 files with indirect coverage changes


load_checkpoint_and_dispatch() method doesn't work with int8 quantized models

System Info
accelerate-0.15.0
bitsandbytes-0.36.0.post2
huggingface-hub-0.11.1
tokenizers-0.13.2
transformers-4.25.1

Compute instance: AWS p4d (8x A100 40Gb)

Information

[ ] The official example scripts
[X] My own modified scripts

Tasks

[ ] One of the scripts in the examples/ folder of Accelerate or an officially supported no_trainer script in the examples folder of the transformers repo (such as run_no_trainer_glue.py)
[X] My own task or dataset (give details below)

Reproduction
I'm trying to use Accelerate in combination with bitsandbytes quantization library to load and dispatch model evenly across multiple GPUs on my compute node to do batch inference.
I expect that load_checkpoint_and_dispatch() method will work regardless the precision of the model. However, that's not the case. Using load_checkpoint_and_dispatch() method with int8 models returns following error: "RuntimeError: Only Tensors of floating point and complex dtype can require gradients". Loading int8 model using  .from_pretrained() method works as expected.
Code sample to reproduce
from transformers import (
    AutoConfig,
    AutoModelForCausalLM,
)
import torch
from accelerate import (
    infer_auto_device_map,
    init_empty_weights,
    load_checkpoint_and_dispatch,
)

# 1. Define initial model parameters
dtype = torch.int8
model_name = "EleutherAI/gpt-neox-20b"
model_config = AutoConfig.from_pretrained(model_name)
max_model_memory = 10

# 2. Define quantization parameters
loading_kwargs = dict()
loading_kwargs["load_in_8bit"] = True
loading_kwargs[
    "load_in_8bit_threshold"
] = 2.0

# 3. Instantiate empty model with int8 precision
with init_empty_weights():
    model = AutoModelForCausalLM.from_pretrained(
        args.model_name, **loading_kwargs
    )

# 4. Get device map based on max_model_memory parameter
max_memory_per_gpu = {
    0: f"{max_model_memory}GIB",
    1: f"{max_model_memory}GIB",
    2: f"{max_model_memory}GIB",
    3: f"{max_model_memory}GIB",
    4: f"{max_model_memory}GIB",
    5: f"{max_model_memory}GIB",
    6: f"{max_model_memory}GIB",
    7: f"{max_model_memory}GIB",
}

device_map = infer_auto_device_map(
    model,
    no_split_module_classes=model._no_split_modules,
    dtype=dtype,
    max_memory=max_memory_per_gpu,
)

# 5. Dispatch already instantiate int8 model
load_checkpoint_and_dispatch(
    model,
    model_name,
    offload_folder=None,
    offload_state_dict=False,
    dtype=args.dtype,
    device_map=device_map
)

The code below returns following stack trace:

Traceback (most recent call last):
load_checkpoint_and_dispatch(  File "/opt/conda/lib/python3.8/site-packages/accelerate/big_modeling.py", line 375, in load_checkpoint_and_dispatch
load_checkpoint_in_model(  File "/opt/conda/lib/python3.8/site-packages/accelerate/utils/modeling.py", line 699, in load_checkpoint_in_model
set_module_tensor_to_device(model, param_name, param_device, value=param)  File "/opt/conda/lib/python3.8/site-packages/accelerate/utils/modeling.py", line 132, in set_module_tensor_to_device
new_value = param_cls(new_value, requires_grad=old_value.requires_grad, **kwargs).to(device)  File "/opt/conda/lib/python3.8/site-packages/torch/nn/parameter.py", line 37, in __new__    return torch.Tensor._make_subclass(cls, data, requires_grad)
RuntimeError: Only Tensors of floating point and complex dtype can require gradients

If i load the same model with the same device map using .from_pretrained() method, it will work just fine.
# 1. Define initial model parameters
dtype = torch.int8
model_name = "EleutherAI/gpt-neox-20b"
model_config = AutoConfig.from_pretrained(model_name)
max_model_memory = 10

# 2. Define quantization parameters
loading_kwargs = dict()
loading_kwargs["load_in_8bit"] = True
loading_kwargs[
    "load_in_8bit_threshold"
] = 2.0

# 3. Instantiate empty model with int8 precision
with init_empty_weights():
    model = AutoModelForCausalLM.from_pretrained(
        args.model_name, **loading_kwargs
    )

# 4. Get device map based on max_model_memory parameter
max_memory_per_gpu = {
    0: f"{max_model_memory}GIB",
    1: f"{max_model_memory}GIB",
    2: f"{max_model_memory}GIB",
    3: f"{max_model_memory}GIB",
    4: f"{max_model_memory}GIB",
    5: f"{max_model_memory}GIB",
    6: f"{max_model_memory}GIB",
    7: f"{max_model_memory}GIB",
}

device_map = infer_auto_device_map(
    model,
    no_split_module_classes=model._no_split_modules,
    dtype=dtype,
    max_memory=max_memory_per_gpu,
)

loading_kwargs['device_map'] = device_map

# 5. Loading model using Transformers API
model = AutoModelForCausalLM.from_pretrained(args.model_name, **loading_kwargs)

Expected behavior
I expect that load_checkpoint_and_dispatch() method works with all supported precisions, including quantized int8.

I think the problem lies within the dtype passed to load_checkpoint_and_dispatch. Not all the weights are converted to int8s, so you can't just pass dtype=torch.int8 like this. Leaving it as none would probably work better.

@sgugger thanks. I tried setting dtype=None in load_and_dispatch_mode(), i believe that model is automatically considered as FP32 in this case. So not exactly what I expected to happen. I can confirm it by looking at final model memory footprint. Let me know if you need any additional details.


[Publisher] Missing menu items when searched through "Go To" search option within an API

Consider a scenario where a user is logged into the publisher and an API is selected. Under the "Go To" option some menu items cannot be searched. Some of them are:

Overview, Configuration, Gateways, Subscriptions, Mediation Policies, Monetization.

issues related to GO TO option https://github.com/wso2/product-apim/issues/6042


Reverse ordering of category keywords - service directory

@saeedmb8 please review
I need to control the order in which the Service Directory category keywords are displayed on the front-end.

@Mitso 👍 🍰


Update devfile/library to support pod-overrides and container-overrides attributes and add integration test for it

What type of PR is this:
/kind feature

What does this PR do / why we need it:
This PR updates the devfile/library to https://github.com/devfile/library/commit/4d107ddd41410b38efaefabaa82fc8526be55792 to support pod-overrides and container-overrides. It also adds integration test for the same.
Which issue(s) this PR fixes:

Fixes #5977
PR acceptance criteria:

[ ] Unit test

[x] Integration test

[ ] Documentation

How to test changes / Special notes to the reviewer:
Steps to update the library:

Devfile Update: go get github.com/devfile/library/v2@4d107ddd4141
Replace all the imports of github.com/devfile/library to github.com/devfile/library/v2
go mod vendor && go mod tidy

/hold
Until https://github.com/devfile/library/pull/161 goes in.

/hold cancel


Certificate Issue RDP Web Client

The RDP Web Client disconnects after handshake. The error shown in the debug window says:
(unknown) 2018-04-09T15:37:36.250Z Connection(ERR): The connection generated an internal exception with disconnect code=UnknownError(46), extended code=, reason=X509_NAME_print_ex failed, (OSSL error: ERR_error_string returned "error:00000000:lib(0):func(0):reason(0)")
Thrown in thread 0 at:
certificateutils.cpp(152)
About this error I found this:
This is due to a bug in the Remote Desktop web control when the certificate on the gateway does not have a subject field. We are planning to fix this in a future update, and for now, use a certificate that has a subject when installing.
The Server has an official certificate, with subject, and has been imported correctly. I tried this on 2 different servers with the RDP Webclient role but both give the same error. Also tried it with our root certificate, but no luck either. the same error occurs.
Yes we use a Gateway Server and all the Server OS are Windows 2016 with the latest updates.
Anybody the same issues / or even better: a solution?

Hi - are you still having this issue? Or did it disappear with the updates to the web client?

Closing issue due to inactivity.  Please reopen to pursue further.


Enhance Spoke VMs in the examples

Can we please introduce the following changes to the examples globally?

Move the instance type from t2.micro to t3.micro
Use Amazon Linux2 AMIs with ssm-agent pre-installed so that users can test without having to install bastion hosts? We probably will have to install nginx via user_data

PR #57 was already merged


Remove "Always use secure connections" and "Use secure DNS" from settings

Why would anyone want to use HTTPS connections or even use a secure DNS service?  Our connections should be visible for everyone to see. Including 3 letter agencies.

Really embracing the FOSS idealogy - Free for everyone to see and open source

Really embracing the FOSS idealogy - Free for everyone to see and open source

Exactly

Keep them there, but enabling them requires like 30 steps and then it crashes. Without enabling it.


cadl, upgrade sdk automation script, for tooling changes

Description
Please add an informative description that covers that changes made by the pull request and link all relevant issues.
If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
All SDK Contribution checklist:

[ ] The pull request does not introduce [breaking changes]
[ ] CHANGELOG is updated for new features, bug fixes or other significant changes.
[ ] I have read the contribution guidelines.

General Guidelines and Best Practices

[ ] Title of the pull request is clear and informative.
[ ] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

[ ] Pull request includes test coverage for the included changes.

This is the testing PR which generate the java package successfully.

/check-enforcer override


Add Table Iterator

Even though this is blocked by #3, lets explicit the possible ways to go. The proposals are inspired by mgo#Iter , AWS DynamoDB and database/sql.
We are going to follow good practices and context object will be part of the API. This might allow setting things like timeouts or early termination if the outer context is Done.
Having the struct describing the row would allow us to have fragments like:
var results []people.Person
if err := table.All(ctx, &results); err != nil {
    return err
}
for i,p := range results {
    fmt.Printf("%d - %+v", i, p)
}

Which loads all table records to memory and ranges over its results. If the table is too big, another option could be used:
var person people.Person
iter := table.Batch(100).Iter()
defer iter.Close()
for iter.Next(ctx, &person) {
    fmt.Printf("%+v", p)
}
if err := iter.Err(); err != nil {
    return err
}

Edit: Added context to the more complicated case

After some thinking and taking a very close look at Ruffus' issue, I would like to propose the following API.
@roll @danfowler Could you please take a look? It is important to bear in mind that Go is statically typed.
// RawIter iterates over a set of rows in its raw form.
type RawIter struct {
}

// Next retrieves the next row from the table, blocking if necessary.
// The row is returned in its raw form, as a slice of strings.
func (i *RawIter) Next() ([]string, error) {
	return nil, nil
}

// Done returns true only if a follow up Next call is guaranteed to return false.
func (i *RawIter) Done() bool {
	return false
}

// RowIter iterates over a set of rows in a table, casting its rows to a
// specified schema.
type RowIter struct {
	Schema schema.Schema
}

// Next retrieves the next row from the table, blocking if necessary.
// The row is returned as a struct, cast to using the Schema.
// See: http://godoc.org/github.com/frictionlessdata/tableschema-go/schema#Schema.CastRow
func (i *RowIter) Next(out interface{}) error {
	return nil
}

// Table represents a tabular data structure. Tabular data consists of a set of rows.
// Each row has a set of fields (columns). We usually expect that each row has
// the same set of fields and thus we can talk about the fields for the table as a whole.
// More at: https://specs.frictionlessdata.io/table-schema/#concepts
type Table struct {
}

// Raw allows to iterate over the table in its raw form (values as strings).
// No validation or cast is performed.
func (t *Table) Raw() (*RawIter, error) {
	return nil, nil
}

// Row allows to iterate over the table casting its rows to the passed-in
// schema.
func (t *Table) Row(schema schema.Schema) (*RowIter, error) {
	return nil, nil
}

// CSV creates a Table from the CSV physical representation.
func CSV(source io.Reader) (*Table, error) {
	return nil, nil
}

// JSON creates a Table from the JSON physical representation.
func JSON(source io.Reader) (*Table, error) {
	return nil, nil
}

@danielfireman
What I've got lately for JavaScript based on the same issue - https://github.com/frictionlessdata/tableschema-js/tree/table-fix#table
Related to static typed implementation.. I think you idea of replacing iter/read is good but I have a concern about table.Raw/Rows() naming. I would say Raw sound more like bytes. May be more explicit like table.Rows()/CastRows()?


[BUG] Pipeline with secrets with special chars does not work

Describe the bug
Using AzureLoadTest@1 task with secrets fails with ##[error]Invalid secrets when the secret value contains "special" characters like : and .. This goes both for secrets referenced in variable group linked to azure keyvault  and secrets defined as pipeline variable.
To Reproduce
Steps to reproduce the behavior:

Create pipeline using AzureLoadTest@1 task
Define a secret
Put : or . (I would assume other special chars also fails) in the secret value
Run pipeline

Expected behavior
Pipeline should run successfully with the provided secrets
AB#1554814

Thanks for reporting this. We will check this and get back to you!!

@nilsgaeq we have fixed this issue. Can you please confirm if it is working?

It does work now, thanks. But it appears that using secrets from keyvault cause the output of what little reporting there is being obfuscated (even the link to the run in the portal), so at it's current state, it does not provide anything that can be inspected in the pipeline itself. Only way to inspect the results is to go into azure portal and navigate to the run from there.

@nilsgaeq are you not able to see the test run results in the pipeline logs?

It is partially obfuscated. Not sure what causes this, but a colleague suggested the keyvault secret variable integration caused this. So it does not yield any useful information. E.g:
Test1
response time 	 : avg=289ms min=***0ms med=***9***ms max=622ms p(90)=622ms p(9***)=622ms p(99)=622ms
requests per sec 	 : avg=***
total requests 		 : ***
total errors 		 : 2
total error rate 	 : 66
Test2
response time 	 : avg=***ms min=***ms med=402ms max=494ms p(90)=494ms p(9***)=494ms p(99)=494ms
requests per sec 	 : avg=***
total requests 		 : ***
total errors 		 : 0
total error rate 	 : 0

Is the portal URL not correct as well? Is it possible to send a screenshot of the entire output? Also, could you confirm if you are running from Azure Pipelines?

That's correct. The url is also obfuscated. It is run in an Azure Devops Pipeline.

@nilsgaeq can you please share the screenshot of the output?

@nilsgaeq we are closing this issue since we haven't received any response. Please re-open if you are still facing it.

I am having this exact issue.
I am running key vault secrets from variable pipeline groups.
If the secrets are something simple like "test, " it will work.  But when I generate the app secret for the app registration within the portal, it has special characters in it.  And this creates a syntax error within the pipeline.
Help on this would be appreciated


Support to verify Webhook signatures

Not sure if this as a genuinely useful feature given this is a tool for debugging, but, I dogfooded https://stripe.com/docs/webhooks/signatures to add signature verification.
Changes

Add signingSecret configuration to config.sample.js
Add verification path to Webhooks express server to verify signatures
Add documentation for signingSecret
Update some outdated, vulnerable dependencies (not, there are still some vulnerable packages which have breaking changes, so didn't get fixed by npm audit fix)

@mg-stripe – would you be able to take a glance at this at your leisure, please? 🙏

re pinging @mg-stripe , would love to see this included!

The more I think about this PR: an alternative approach would be to create the webhook whenever the app starts up and retrieve the webhook signing secret that way. (We'd want to delete and recreate the endpoint every time the app starts up to retrieve the signing secret, since it's only issued at creation time.)
Is the explicit Dashboard flow the easiest for users,  or should we simply do this programmatically and implicitly?

Hi @mg-stripe – thank you so much for the feedback.
I think the application is significantly more user-friendly in a world where it provisions the Stripe webhook endpoint on the user's behalf. I've left in the ability to eschew the necessity to use ngrok and provide your own signing secret, too.
I do have a little FUD on whether removing the endpoint on SIGINT teardown is enough, or if it should be more aggressive by covering more exit codes?
Let me know what you think!

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


proxy_set_effective_context() loses access to callout responses

As implement right now, proxy_on_http_call_response is called on RootContext, which is supposed to find the target StreamContext (or a few...) based on the token_id.
The issue is that once proxy_set_effective_context() is used to let the host know about the switch to the target context, the access to the response is lost (it's only available from the RootContext), which makes this interaction very awkward, since extensions need to extract complete response before calling proxy_set_effective_context(), and only do anything useful  after that call.

#429

Fixed in #429.


[ENH, MRG] Encapsulate warp elec image in function

I thought the checks that the image warp worked properly and handling of the coordinate frames would be better handled by a function than leaving to copy paste. After writing it, the function seems rather cumbersome so it would be nice to get a review and maybe this isn't the best way to go about it. I tried splitting it into a piece for making an image and a piece for warping an image but that was cumbersome as well.
Also I didn't write a test because it is just too cumbersome but the example did work...

Also I didn't write a test because it is just too cumbersome but the example did work...

Everything in MNE should be regression tested -- it's an important part of the work and worth the effort! It's also a useful skill to learn in terms of how to take a complicated problem and distill it to something that proves things work properly, without taking too long to do so.
One idea would be to fake sample's T1 into being CT-like. For example, eyeball two or three 3x3 blocks of voxels (in some known small volume regions) in freeview to call "electrodes". In the test, nib.load the T1, "color in" those hard-coded 3x3 blocks (using numpy slicing to assign values), save the image back out. Use the function in this PR to warp this "sample CT" to fsaverage, assert that you get your 2 or 3 electrodes out, and that they live in the correct fsaverage volumetric ROIs. It sounds like a lot, but I think it will end up being < 30 lines, and should make sure that this function works.
This also lends itself nicely to testing other cases, for example if you color in a single voxel, you might not get this point back, and the function should warn -- and you can assert via pytest.warns(...) that it does, etc.

Also I didn't write a test because it is just too cumbersome but the example did work...

Everything in MNE should be regression tested -- it's an important part of the work and worth the effort! It's also a useful skill to learn in terms of how to take a complicated problem and distill it to something that proves things work properly, without taking too long to do so.
One idea would be to fake sample's T1 into being CT-like. For example, eyeball two or three 3x3 blocks of voxels (in some known small volume regions) in freeview to call "electrodes". In the test, nib.load the T1, "color in" those hard-coded 3x3 blocks (using numpy slicing to assign values), save the image back out. Use the function in this PR to warp this "sample CT" to fsaverage, assert that you get your 2 or 3 electrodes out, and that they live in the correct fsaverage volumetric ROIs. It sounds like a lot, but I think it will end up being < 30 lines, and should make sure that this function works.
This also lends itself nicely to testing other cases, for example if you color in a single voxel, you might not get this point back, and the function should warn -- and you can assert via pytest.warns(...) that it does, etc.

Sounds good, I wrote that after a long day of working on too many PRs at once but also after thinking about it I don't think it's that cumbersome, it's 4 required arguments which is a lot but I think that's the best way for making it modular and making sure you can check step by step. I'm almost done with the test, will push soon.

Ok, this should pass all the tests, but it does take 50 seconds locally to test. @larsoner if you have any ideas to make it faster that would be nice but I'm not sure I have any. Other than that, should be good to go.

Hmmm so
reg_affine, sdr_morph = compute_volume_registration(
        subject_brain, template_brain, zooms=5, niter=[10, 10, 5],
        pipeline=['affine', 'sdr'])

raises
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "<decorator-gen-22>", line 24, in compute_volume_registration
  File "/Users/alexrockhill/projects/mne-python/mne/transforms.py", line 1635, in compute_volume_registration
    return _compute_volume_registration(
  File "/Users/alexrockhill/projects/mne-python/mne/transforms.py", line 1653, in _compute_volume_registration
    pipeline = _validate_pipeline(pipeline)
  File "/Users/alexrockhill/projects/mne-python/mne/transforms.py", line 1578, in _validate_pipeline
    raise ValueError(
ValueError: Steps in pipeline are out of order, expected ('affine', 'sdr') but got ['affine', 'sdr'] instead

but works with a tuple.
I might fix that on this PR if that's okay

Ok, now the test is down to 20 seconds :)

Ok ready for review @larsoner, whenever you get a chance

So I changed the tests so that the zooms=5 but full iterations version is the ground truth but the euclidean distance is still ~0.11 which I think is in meters so that's 110 cm which is really far off...
"Ground truth" (with zooms=5)
[[-0.27778788, 0.24251515, -0.35693939],
 [-0.30033333, 0.24785714, -0.35014286],
 [-0.32261947, 0.25295575, -0.34614159]]

Extra quick version (affine + SDR with low iterations)
[[-0.31253333,  0.352     , -0.3247    ]
 [-0.33082353,  0.35317647, -0.31488235]
 [-0.34751786,  0.34966071, -0.30701786]]

I'll try adding back translation and rigid and see how much of a time hit that is for the precision.

Yes it's possible that the affine step with low zooms breaks things, so doing translation+rigid+SDR in the test (skipping affine) or even just translation+rigid (no affine or SDR) with zooms=5 if it gets us speed + good enough accuracy (< 1 cm would be nice)

Yes it's possible that the affine step with low zooms breaks things, so doing translation+rigid+SDR in the test (skipping affine) or even just translation+rigid (no affine or SDR) with zooms=5 if it gets us speed + good enough accuracy (< 1 cm would be nice)

Great, I'll try that!

Hmmm with zooms=5 even without the affine, we're still at about 10 cm

I'll try messing with the parameters a bit more, it's possible that a few more translation iterations will fix things

I would use nibabel.orthoview() on the before and after images to see what's going wrong. I wouldn't even really expect an identity "registration" for sample-fsaverage to be off by 10cm for most points...

(but maybe I underestimate how far off they are)

Wait, I'm thinking in mm, they are off my ~1 cm 🤦
0.010855916835345538
0.008643073755143938
0.007148324234890798

Oh good, I think atol=0.01 / decimal=2 i.e. 1 cm is good enough for the 5mm-zooms version!

Ok good to go but it was 28 seconds locally, I tried turning down the iterations and skipping steps but everything I did lost precision so I think this is about the best to be ~1 cm precise

Ok this is good to go by me if it's okay with you

Will merge once CIs come back happy, thanks @alexrockhill!

Pushed a commit to set coord_frame='mri' and will merge once CIs come back happy!
(After doing that I realized that it doesn't matter much for this PR which coordinate frame things are plotted in, but it'll be useful when we combine with Brain in #9545, so no harm in having it here.)

Ok, I think good to go!

Indeed, thanks @alexrockhill ! Time for some fun rebasing elsewhere :)

Indeed, thanks @alexrockhill ! Time for some fun rebasing elsewhere :)

The plan is that the dominos fall perfectly!


On Android, KeyboardListener catches software keyboard input.

Steps to reproduce
Our app has a function that operates by distinguishing between hardware (bluetooth) keyboard input and software keyboard input for TextField.
While searching for the API provided by Flutter to implement this, I came across the KeyboardListener widget description below.
/// ..in keyboard_listener.dart
/// A [KeyboardListener] is useful for listening to key events and
/// hardware buttons that are represented as keys. Typically used by games and
/// other apps that use keyboards for purposes other than text entry.

/// ..in hardware_keyboard.dart
/// The [KeyEvent] provides a universal model for key event information from a
/// hardware keyboard across platforms.

From the above explanation, I understood that KeyboardListener only recognizes hardware keys.
We applied this to our project because we thought it suited our requirements, but the actual behavior was different from what we expected.
In fact, when we run the app with the code below using KeyboardListenerd, the backspace (if there is no string to delete) and enter (textfield property - textInputAction: newline) keys entered on the software keyboard are detected as if backspace or enter were pressed on the hardware keyboard.
Additionally, we were unable to determine whether the input was software or hardware from the detected results.
Does this mean I misunderstood the document? or is this not the widget provided with this intention?
I'm not sure if this is a bug, but if this is the intended result, it would be helpful if the documentation for KeyboardListener or KeyEvent was a bit nicer.
Also, if there is a way to implement the above requirements, please kindly let me know.
(I tested it on Samsung Keyboard and GBoard, and the results were different. I used a Korean/English keyboard, and it was also different when I typed in Korean and English. - test os: android - )
Expected results
Key input from the software keyboard is not detected in the Keyboardlistener onKeyEvent.
Actual results
Depending on the keyboard type / input language / key type, onKeyEvent is called for some software keyboard inputs.
Code sample
class Home extends StatefulWidget {
  const Home({super.key});

  @override
  State<Home> createState() => _HomeState();
}

class _HomeState extends State<Home> {
  final FocusNode focusNode = FocusNode();

  @override
  void dispose() {
    focusNode.dispose();
    super.dispose();
  }

  @override
  Widget build(BuildContext context) {
    return Scaffold(
      appBar: AppBar(title: const Text("keyboard listener")),
      body: Column(crossAxisAlignment: CrossAxisAlignment.center, children: [
        KeyboardListener(
          focusNode: focusNode,
          onKeyEvent: print,
          child: const TextField(textInputAction: TextInputAction.newline),
        ),
      ]),
    );
  }
}

Screenshots or Video

Screenshots / Video demonstration
[Upload media here]

Logs
Logs
[Paste your logs here]

Flutter Doctor output
Doctor output
[Paste your output here]

@asci-00
Can you check if this resembles your case or not ?
Also check if this is related https://github.com/flutter/flutter/issues/44681

Hi @darshankawar
Well, I'm not sure it's related, but
#51478 issue is an issue where the OnScreen keyboard (the software keyboard I wrote above) is opened due to input from the hardware keyboard.
#44681 issue is also related to this, and seems to be a question about how to not raise the keyboard when the textfield has focus. It may be related internally, but it seems to be a different problem than mine.

Thanks for the update. Check if this applies to your case as well or not.

The Android InputConnection API allows a software keyboard to send a keypress as a KeyEvent (https://developer.android.com/reference/android/view/inputmethod/InputConnection#sendKeyEvent(android.view.KeyEvent)).
Usually keyboards do that for backspace because sometimes if a text field is already empty you want to move the focus to the previous field. Flutter currently does not distinguish KeyEvents emitted by this method call and KeyEvents generated by physical keyboards.

@darshankawar I'm not sure if I understand the problem correctly. I think the issue is that the hardware keyboard operates differently depending on the mobile device (s9 / pixel) when using RawKeyboardListener.
It seems like a similar problem to some extent, but the point of my issue is that keypress from the “software keyboard” are detected by KeyboardListener, so it seems like a different issue. Please let me know if I misunderstood the issue

@LongCatIsLooong thank you for the reply.
This is an area I don't know, so I'd like to ask. Is the entity that raises KeyEvent using InputConnection the software keyboard? ex) GBoard / Samsung Keyboard
Also, I wonder if the Enter key, other than backspace, also applies.
If so, I am curious as to whether it is possible to distinguish the KeyEvent in Flutter (at a low level) and whether it plans to support the function to distinguish it.
If it is not supported, is there any way to implement the requirements I mentioned?

@asci-00
Check if below issues help in your case or not:
https://github.com/flutter/flutter/issues/142882
https://github.com/flutter/flutter/issues/131510

@LongCatIsLooong thank you for the reply. This is an area I don't know, so I'd like to ask. Is the entity that raises KeyEvent using InputConnection the software keyboard? ex) GBoard / Samsung Keyboard Also, I wonder if the Enter key, other than backspace, also applies. If so, I am curious as to whether it is possible to distinguish the KeyEvent in Flutter (at a low level) and whether it plans to support the function to distinguish it. If it is not supported, is there any way to implement the requirements I mentioned?

Yes. Software keyboards (Gboard / Samsung Keyboard) can choose to send certain key presses as hardware key events (for reasons stated above). They can even send "A" as a key event if they so choose.

If so, I am curious as to whether it is possible to distinguish the KeyEvent in Flutter

I believe this is possible on Android because they have separate call paths: https://github.com/flutter/engine/blob/c6fecf65fbf385c5e9168c5b40526c9ae998045b/shell/platform/android/io/flutter/plugin/editing/InputConnectionAdaptor.java#L285-L287
But this may not be possible on other platforms. And editors typically don't need such information.

Our app has a function that operates by distinguishing between hardware (bluetooth) keyboard input and software keyboard input

This sounds like a relatively niche use case, could you elaborate?

@LongCatIsLooong Sorry for the late reply. 😓
To explain part of the function, you can set the enter (submit) action of the software keyboard and the enter action of the hardware keyboard separately in the textfield.
If you press enter on a hardware keyboard, the default action branches into two actions depending on the value you set.

When press enter, newline
When press enter, send
However, the software keyboard must always be newline.

However, flutter cannot check whether the hardware keyboard is connected and
In the case of Samsung keyboards, due to an issue, the software keyboard comes up even when the hardware keyboard is connected unless the user configures it separately.
Therefore, we need to know whether the Enter KeyEvent caught by KeyboardListener occurred in hardware or software, but there is no way to distinguish between them. This is the current problem situation.

Keeping the issue open and labeling for team's tracking.

Is https://main-api.flutter.dev/flutter/widgets/EditableText/onEditingComplete.html what you are looking for?

@LongCatIsLooong
Could you please explain in more detail?
When I checked by applying onEditingComplete, it seems that both hardware Enter and software Enter are not distinguished and are caught in callback.

Ah indeed it does, but it's disabled for multiline: https://github.com/flutter/engine/blob/557a4c622617c6c0f66b604669d14d11b8aa1cbe/shell/platform/android/io/flutter/plugin/editing/InputConnectionAdaptor.java#L304
This is a bit strange. I don't think the input connection is supposed to do that.

Tentatively marked this issue as P3. However, if you would like to see this issue fixed sooner, you are welcome to open a pull request to remove the logic that is causing this issue.

@LongCatIsLooong Very interesting. Thanks for the hint on the problem. The code you provided is engine code. Is there a way to test the engine while modifying it? In fact, onEditingComplete seems to work differently depending on SamsungKeyboard / GBoard, so if there is a problem with the code you mentioned, I would like to fix it and test it. I am wondering if there is a way to test it locally.

I think it's the same problem that I'm facing about.
I tried to handle the hardware key using onKeyEvent in focusNode, but I confirmed that the enterKey of the Bluetooth keyboard seems to be operated by TextInputAction.
I want to separate the action performed according to the enterKey of the Bluetooth keyboard and the enterKey of the screen keyboard. :cry: :cry:


Fix explorer greys out any folder/item with the word "cut"

Fixes #223791

Thanks @jeanp413.
I made some more changes to simplify the code. I verified that \x11\x12\x14\x15\x40 are covered by CSS.escape, so we don't need that anymore


Add secret managment plugin

See also
https://github.com/hashicorp/vault-examples/blob/main/examples/_quick-start/go/example.go

api-testing-vault-extension is Vault-based secret management extension.

There some other secret management tools.

Doppler


Fix missing vector dialect registration from LinalgFuse driver.

Also add some unit tests for the single tiling expert driver and
linalg fuse driver.

That'd be great. Any idea how to do that?

That'd be great. Any idea how to do that?

I will give it a try. There is probably a right way to do it or I can just call lit from python :)

IREE has some cmake macro for the tests, but might be too involved for simple testing of this sort

yes, I think it would be better to include it in the run_tests.py which is already run by a github action. Although cmake may also be a good option.

yes, I think it would be better to include it in the run_tests.py which is already run by a github action. Although cmake may also be a good option.

If we could get lit testing working with python that would be great too. The command line is pretty simple, last I looked at it seemed very complicated to do internally. Maybe we can sidestep all of that in OSS. If you add this to run_test.py. I can figure out how to add it for python


Optimize RetinaNet inference time

🚀 Feature
The postprocessing step in RetinaNet is slow, and the whole inference time for RetinaNet is almost twice slower than Faster R-CNN as of today.
In particular, https://github.com/pytorch/vision/blob/5bb81c8e008c601237e2ffd5cbea7192775130bd/torchvision/models/detection/retinanet.py#L442-L471 does a for loop over the number of classes. This for loop can be parallelized by batching operations together over all classes, which should greatly improve the inference speed.
For reference, Detectron2 has sped up inference on RetinaNet a few times already, with latest optimization present in https://github.com/facebookresearch/detectron2/commit/8999946492ae6930a4b312dbbea952e326a9f1df , and also batch inference over classes (and only does a for loop on the number of feature maps, which is much smaller than the number of COCO classes)

This has been implemented by @datumbox in #2828


URLString -> URL

Thanks @fulldecent...that was definitely wrong. I had to tweak your changes a bit and pushed them up into master in f3e250ab while keeping your attribution. This should go out shortly as part of the Alamofire 4.3.0 release.
Thanks! 🍻


Property "title" was accessed during render but is not defined on instance.

Not sure how to resolve this warning. O copied the example exactly except for using my own icomoon selection.json.

PS, this project is great! Exactly what we needed.

This is a Vue port of the react-icomoon project and is still in its early stages. I will fix this as soon as possible.
I'm glad you liked it. Thanks for your feedback.

Please check v0.2.1 version. @ctadlock

Fixed with v0.2.3 version. @ctadlock

Fixed; thank you

Looks great...


remove skydns, use inline dns instead.

remove skydns, use inline dns instead.

@rchirakk Can you update this, please? I've opened #687 to clean up the Vagrantfiles and remove the dnscontainer.tar Docker image.

@DivyaVavili PTAL


[Feature] Proxy logging improvements

Hi there!
I recently attempted to migrate from kamal version 1.9.1 to 2.2.2 and encountered a couple of issues that require some workaround configurations for kamal and rsyslog to maintain the original behavior.
1. Compliance with logging.driver
It seems that the container running kamal-proxy is not utilizing the specified logging.driver configuration (if set) and is instead writing logs to a file. This change is unexpected, as traefik adhered to the logging driver specified in the configuration.
Current Configuration:
logging:
  driver: syslog
  options:
    tag: '{{ index (split .Name "-") 1 }}'

2. Passing custom docker options to proxy
To address the logging issue, I attempted to set docker options using the boot_config command.
$ kamal proxy boot_config set --docker_options log-driver=syslog -d staging
$ kamal proxy reboot -d staging
Note: This may cause a brief outage on each host. Are you sure? [y, N] (N) y
...

However, I encountered an error:
INFO [e1b4c244] Running docker run --name kamal-proxy --network kamal --detach --restart unless-stopped --volume kamal-proxy-config:/home/kamal-proxy/.config/kamal-proxy $(cat .kamal/proxy/options || echo "--publish 80:80 --publish 443:443 --log-opt max-size=10m") basecamp/kamal-proxy:v0.8.1 on A.B.C.D
Releasing the deploy lock...
ERROR (SSHKit::Command::Failed): Exception while executing on host A.B.C.D: docker exit status: 125
docker stdout: Nothing written
docker stderr: docker: Error response from daemon: unknown log opt 'max-size' for syslog log driver.
See 'docker run --help'.

It appears that Kamal internally sets the max-size option, which conflicts with the syslog log driver. This can be resolved by manually editing .kamal/proxy/options on host to remove --log-opt max-size=10m.
3. Definition of unwanted log fields
Another useful feature would be the ability to specify fields to exclude from log entries. Currently, the log entries contain many fields that may not be necessary for certain use cases, such as:
{
  "time": "some_val",
  "level": "some_val",
  "msg": "some_val",
  "host": "some_val",
  "port": "some_val",
  "path": "some_val",
  "request_id": "some_val",
  "status": "some_val",
  "service": "some_val",
  "target": "some_val",
  "duration": "some_val",
  "method": "some_val",
  "req_content_length": "some_val",
  "req_content_type": "some_val",
  "resp_content_length": "some_val",
  "resp_content_type": "some_val",
  "client_addr": "some_val",
  "client_port": "some_val",
  "remote_addr": "some_val",
  "user_agent": "some_val",
  "proto": "some_val",
  "scheme": "some_val",
  "query": "some_val",
  "resp_x_runtime": "some_val"
}

Since we can already define proxy.logging.request_headers and proxy.logging.response_headers, I suggest adding a proxy.logging.dropped_fields array for this purpose.
Fields can be filtered out in the rsyslog configuration, but this introduces significant complexity to what is otherwise a straightforward tool.
However, this is likely a feature request for the kamal-proxy repo as logging is handled there.
Thank you for your hard work on this project! Keep rolling! 🚀 💪

In Kamal 1 we used the logging options from the app config for the proxy. But that's not something that we want to do anymore since Kamal 2 supports running multiple apps through one proxy so the apps could have conflicting settings.
If you are only deploying one app though to a server, that's not a concern and you can use kamal proxy boot_config set -y in a pre-deploy hook to force the servers to have the right settings.
RIght now though it will always try to set a max-size, so that's a bug since it's breaking things for the syslog driver.

#1152 will you allow you to remove the max size log opt, via kamal proxy boot_config set

@djmb Thanks! Your fix combined with pre-proxy-reboot hook will solve points Compliance with logging.driver and Passing custom docker options to proxy.

For anyone else wanting to make changes to the kamal-proxy docker options I would just like to point out that running a kamal proxy boot_config set ... command in the pre-proxy-reboot only runs when you do a kamal proxy reboot (duh!).
When it came time for me to kamal setup another destination I was confused as to why kamal-proxy didn't have the desired settings, then I realized that I forgot to do a kamal proxy reboot. 🤦
For me, I found that running the kamal proxy boot_config set ... command from both the docker-setup hook and the pre-proxy-reboot hook made it easier for both existing and new destinations to have the desired configuration.


Change capitalization of metaData to metadata

Relevant in Users and Groups. The java serialization uses the name metaData, which is the key used in the JSON structure, however the swagger examples use metadata, which are technically invalid examples, because case matters

Hm actually I think the java code is wrong! would you be able to change it there instead to metadata? :)

I opted to do it the other way around first to avoid not changing the actual API, but i'd prefer it this way anyway! Changed

Sweet - thank you!


Changed image size requirements and store name color

Are these colours too monochromatic? Where are the colours?

what if the user is colorblind

I like this better than the previous colors. : )

Are these colours too monochromatic? Where are the colours?

I think having simpler color scheme give more modernistic look, and using other colors might cause issues if the users are colourblind.

what if the user is colorblind

I believe there are no colorblindness for black, gray and white colors, which is why I decided to use such colors. Thank you for the consideration.


Error when adding excel file into a request

Hi, when adding an excel file into a POST request I'm getting this error:
import-items.feature:23 - could not find or read file: with_all_correct_params.xlsx
I have the test file and the excel file in the same folder, I don't understand why it cannot find it.
My request goes like this:
Given path '/api/v1/excel/snapshot/import-items'
And multipart file fileName = {read: 'with_all_correct_params.xlsx', fileName: 'with_all_correct_params.xlsx',contentType: 'application/vnd.openxmlformats-officedocument.spreadsheetml.sheet'}
And header accept = 'application/json'
And header Content-Type = 'multipart/form-data'
And headers headers
When method POST

@VictorCapitole sorry, please follow this process: https://github.com/intuit/karate/wiki/How-to-Submit-an-Issue
but most likely you will get your answer from stack overflow: https://stackoverflow.com/q/61636814/143475


PB-31 - Compilation and running on Ubuntu18 w. openssl 1.1.0

Updates to support compilation and test-completion of the internal Ad/Fin fork of Mordor on Ubuntu 18 w/openssl 1.1.0
Changes include:

Instantiating m_ctx with EVP_CIPHER_CTX_new(), and referencing appropriately (https://github.com/openssl/openssl/issues/962)
Addressing the deprecation of SHA0 in openssl1.1.0 (e.g. SHA -> SHA1 in method signatures)
Instantiating the RSA key with recommended methodology (prior approach was deprecated)
Updating SSLStream::close from Mordor's next branch, for unit test passing purposes. (This involves moving from std to boost, however boost is already used within the existing mordor project)
Including boost/utility.hpp to support compilation of boost::enable_if_c
SHA0 unit tests updated to use SHA1 strings, for test passing purposes (long term we could remove these. Goal was to get things running and passing within reason).

Changes fully pass in a separately built version of this mordor with:
> autoconf -i
> ./configre
> sudo make
> sudo make check
> ./unit-test.sh
> Tests complete.  525/525 passed, 1 skipped.

LGTM


Under load LogbackLoggingSystem fails with java.io.IOException: Stream Closed when refreshing the Spring Context

See https://github.com/spring-projects/spring-boot/issues/6831. I have a feeling this is probably a Spring Cloud issue but I'm happy to reopen the Boot one if necessary.

Hi,
When using Spring Boot 1.4 & Spring Cloud Brixton.SR5 and POSTing to the /refresh actuator endpoint under load you get the following error:
ERROR in c.q.l.c.recovery.ResilientFileOutputStream@862013521 - IO failure while writing to file [app.log] java.io.IOException: Stream Closed
    at org.springframework.boot.logging.logback.LogbackLoggingSystem.loadConfiguration(LogbackLoggingSystem.java:152)
    at org.springframework.boot.logging.AbstractLoggingSystem.initializeWithConventions(AbstractLoggingSystem.java:72)
    at org.springframework.boot.logging.AbstractLoggingSystem.initialize(AbstractLoggingSystem.java:50)
    at org.springframework.boot.logging.logback.LogbackLoggingSystem.initialize(LogbackLoggingSystem.java:106)
    at org.springframework.boot.logging.LoggingApplicationListener.initializeSystem(LoggingApplicationListener.java:289)
    at org.springframework.boot.logging.LoggingApplicationListener.initialize(LoggingApplicationListener.java:262)
    at org.springframework.boot.logging.LoggingApplicationListener.onApplicationEnvironmentPreparedEvent(LoggingApplicationListener.java:231)
    at org.springframework.boot.logging.LoggingApplicationListener.onApplicationEvent(LoggingApplicationListener.java:207)
    at org.springframework.context.event.SimpleApplicationEventMulticaster.invokeListener(SimpleApplicationEventMulticaster.java:166)
    at org.springframework.context.event.SimpleApplicationEventMulticaster.multicastEvent(SimpleApplicationEventMulticaster.java:138)
    at org.springframework.context.event.SimpleApplicationEventMulticaster.multicastEvent(SimpleApplicationEventMulticaster.java:121)
    at org.springframework.boot.context.event.EventPublishingRunListener.environmentPrepared(EventPublishingRunListener.java:68)
    at org.springframework.boot.SpringApplicationRunListeners.environmentPrepared(SpringApplicationRunListeners.java:54)
    at org.springframework.boot.SpringApplication.prepareEnvironment(SpringApplication.java:335)
    at org.springframework.boot.SpringApplication.run(SpringApplication.java:307)
    at org.springframework.boot.builder.SpringApplicationBuilder.run(SpringApplicationBuilder.java:134)
    at org.springframework.cloud.context.refresh.ContextRefresher.addConfigFilesToEnvironment(ContextRefresher.java:67)
    at org.springframework.cloud.context.refresh.ContextRefresher.refresh(ContextRefresher.java:53)
    at org.springframework.cloud.endpoint.RefreshEndpoint.refresh(RefreshEndpoint.java:46)
    at org.springframework.cloud.endpoint.RefreshEndpoint.invoke(RefreshEndpoint.java:52)

I have created a bitbucket example https://bitbucket.org/davidmelia/spring-boot-refresh-logback-bug

Check out https://bitbucket.org/davidmelia/spring-boot-refresh-logback-bug as a maven project
Run the boot app
Run the com.example.StressApp main method which stresses the app and gets log generation going.
Run curl -X POST http://localhost:8080/refresh     (the error can sometimes be immediate but you may have to do up to 15 times to get it)

Thanks
P.S. As the error seems to originate in a Spring Boot Class (LogbackLoggingSystem) I wasn't sure if to raise this with the Spring Cloud team or yourself - I can move it if needs be :-)

/cc @davidmelia

I have the same issue on Spring Boot.

Hi @philwebb
I have a similar issue, while refreshing all my log level are null and all debug logs are logged.
Did you find a workaround ?

I have the same thing if I run my tests with debug level on the root logger. It's intermittent, so workable because I normally don't run my tests at debug, but annoying nonetheless.

@davidmelia is this still an issue in Finchley or later?

Closing due to lack of requested feedback. If you would like us to look at this issue, please provide the requested information and we will re-open the issue.


Rewrite annotation causing KIC sync loop

Is there an existing issue for this?

[X] I have searched the existing issues

Current Behavior
Setup:
2 Ingress objects pointing at the same service
1 Ingress with the rewrite annotation
1 Ingress without the annotation
We see that the request transformer plugin is applied at the Service level and the configuration flip flops creating and deleting the plugin in a loop
Video attached showing the behavior:
https://drive.google.com/file/d/1FYwZaSOwT-Lvin9NzTcFN2mnFxds1UAR/view?usp=sharing
Expected Behavior
The the Ingress objects should not conflict causing a scenario where the plugin is deleted/recreated over and over
Additionally, I believe it would be better that the request transformer plugin is applied at the route level. This would allow for more granular configuration
Steps To Reproduce
1) Stand up a KIC + Proxy and enable the rewrite feature gate
  env:
    feature_gates: RewriteURIs=true

2) Stand up an echo service
3) Create 2 Ingress objects:

echo "
   apiVersion: networking.k8s.io/v1
   kind: Ingress
   metadata:
     name: echo1
     namespace: kong
     annotations:
       konghq.com/strip-path: 'true'
   spec:
     ingressClassName: kong
     rules:
     - host: kong.example
       http:
         paths:
         - path: /echo
           pathType: ImplementationSpecific
           backend:
             service:
               name: echo
               port:
                 number: 1027
   " | kubectl apply -f -

echo "
   apiVersion: networking.k8s.io/v1
   kind: Ingress
   metadata:
     name: echo2
     namespace: kong
     annotations:
       konghq.com/rewrite: /api/foo/REWRITE
       konghq.com/strip-path: 'true'
   spec:
     ingressClassName: kong
     rules:
     - host: kong.example
       http:
         paths:
         - path: /rewrite
           pathType: ImplementationSpecific
           backend:
             service:
               name: echo
               port:
                 number: 1027
   " | kubectl apply -f -

3) Verify via Kong Manager the plugin is being delete/recreated. Check the KIC logs to see repeated sync succesful messages looping

Kong Ingress Controller version
KIC 2.12 / Gateway <IP_ADDRESS>

Kubernetes version
Client Version: version.Info{Major:"1", Minor:"27", GitVersion:"v1.27.2", GitCommit:"7f6f68fdabc4df88cfea2dcf9a19b2b830f1e647", GitTreeState:"clean", BuildDate:"2023-05-17T14:20:07Z", GoVersion:"go1.20.4", Compiler:"gc", Platform:"linux/amd64"}
Kustomize Version: v5.0.1
Server Version: version.Info{Major:"1", Minor:"27", GitVersion:"v1.27.2", GitCommit:"7f6f68fdabc4df88cfea2dcf9a19b2b830f1e647", GitTreeState:"clean", BuildDate:"2023-05-17T14:13:28Z", GoVersion:"go1.20.4", Compiler:"gc", Platform:"linux/amd64"}

Anything else?
No response

Rewrite is attached in KIC code on service level instead of route level
https://github.com/Kong/kubernetes-ingress-controller/blob/9ad403fff3b440868b18167fb397e9f353fa3058/internal/dataplane/translator/subtranslator/ingress.go#L444-L474
It leads to conflicts as described https://github.com/Kong/kubernetes-ingress-controller/issues/5140#issuecomment-1805264155

@jeffrey-arndt yesterday releases

v2.12.2
v3.0.1

contain a fix for the reported bug

I'm seeing the same issue with KIC 3.2 and Kong 3.7.1 and getting the same behaviour - two Ingresses with the same backing service, the rewrite gets applied randomly on requests.
Should I open a new bug? Or will this be tracked here? Any additional data I can provide?

@herself 👋
Yes, please create a new issue specifically mentioning the version that you use. Can you also try with 3.3 if the issue persists?

Thanks - unfortunately, it seems to persist on 3.3 as well. Opened https://github.com/Kong/kubernetes-ingress-controller/issues/6542, thank you for guidance!


logoOpenSearch (OUI Icon version) should change appearance depending on light/dark mode

https://oui.opensearch.org/1.2/#/display/icons#opensearch-logos
Change within component and in OUI Docs site:

[ ] OuiHeader
[ ] OuiLoadingDashboards

OpenSearch logo? I think we'll need screenshots here to make sure we account for it everywhere it matters.

@joshuarrrr if we can control it through utilizing the logoOpenSearch if possible, I think that would resolve many issues. I am not sure if this is going to require a campaign across the feature plug-ins or not, though, since in some instances they may be using additional OpenSearch logo assets.

Oh, so this issue is just for OUI doc site? Yeah, shouldn't be a problem.

No, sorry I see how the wording might be confusing. The change is to make logoOpenSearch as an icon change depending on light or dark mode. That way when anyone in OSD uses logoOpenSearch , the change is automatic.
Ideally we would campaign all non OUI driven uses of logoOpenSearch to be OUI driven. (And also adding the full logo as well). This is how EUI served up logos in the past for Kbn.
The changes also need to update in the doc site as well (ex: the logo in the nav bar)

That makes sense to me - is there much risk to the logo being misused/ overrides giving the logo color incorrectly if we are providing it as monocrhome and compatible with the color prop?

Coloring the monochrome ones would only be able to set the entire logo into a specific color; I am having a hard time making up an abusive single color; misuse per the usage guidance for contrasting background would be possible but I don't believe OUI should concern itself with that much detail.


Refactor SoilCO2ModelParameters constructor

This PR uses climaparameters for SoilCO2ModelParameters.
This will require a patch release for climaparameters to work.
As before, the new constructors are:
import ClimaLand
import CLIMAParameters as CP
toml_dict= CP.create_toml_dict(Float32)

ClimaLand.Soil.Biogeochemistry.SoilCO2ModelParameters(Float64)
ClimaLand.Soil.Biogeochemistry.SoilCO2ModelParameters(Float64; ν = 99999)
ClimaLand.Soil.Biogeochemistry.SoilCO2ModelParameters(toml_dict)
ClimaLand.Soil.Biogeochemistry.SoilCO2ModelParameters(toml_dict; ν = 99999)

Our soilCO2 model is a combination of these two papers:
https://onlinelibrary.wiley.com/doi/abs/10.1111/j.1365-2486.2011.02546.x
for the co2 production model
and https://gmd.copernicus.org/articles/11/1909/2018/ for the diffusion model
they provide example of values for the parameters, we could pick any for the default... note that they are not in SI and need to be converted.
Happy to help more!

Thank you @AlexisRenchon !

Hi Nat, The PR looks good... is there anything in particular I should look at?

Are these defaults correct?

Yes the defaults are correct!
Maybe for porosity we could just say 0.5, if we do need a default (porosity of the soil is going to be different everywhere so it's a bit weird to have a very specific default)


[Saiku Enterprise] Bug with the Excel export for report with parameters

Is this a bug report?
Yes

Environment

java -version:
java version "1.7.0_67"
Java(TM) SE Runtime Environment (build 1.7.0_67-b01)
Java HotSpot(TM) 64-Bit Server VM (build 24.65-b04, mixed mode)

Operating system: CentOS (server where Saiku was installed), MacOS (my computer)

Browser and version (if relevant):Firefox 63.0.1 (64 bits)

Saiku plugin to Pentaho or Saiku Standalone: Saiku Standalone

Saiku CE or Saiku EE:Saiku EE

Saiku version: Saiku 3.8.3-EE

Steps to Reproduce
There are problems with the Excel generated for report having parameters. Also, the CSV generated could not easily be opened in Excel as the fields are separated by comma.

Open the "Sales 2" cube from the Foodmart examples

Configure the report as following :

If you export to Excel, you will get a document like the following
bug_saiku_7.xlsx
The document is correct.

Add parameter for year, quarter and month

We will have this kind of report :

If you export to Excel, you will get a document like the following
bug_saiku_6.xlsx

This document has a very weird content. It does not appear like it did in previous versions.

If we try to export it to CSV, it could not be easily opened in Excel as the fields are separated by comma. Instead, could the separator be semi-colon ?

This is the Excel report generated following the issue's instructions with the last Saiku version.
saiku-export.xlsx


build fails when ADD-ing while in symlinked directory

Here's a minimal example with docker 1.8.1.  Although there are maybe some hints of this in Issue #14339, I think this should narrow down at least one specific problem case.  I couldn't find this elsewhere.
ken@oblako:/tmp $ mkdir /tmp/foo
ken@oblako:/tmp $ ln -s /tmp/foo /tmp/bar
ken@oblako:/tmp $ cd /tmp/bar
ken@oblako:/tmp/bar $ touch quux
ken@oblako:/tmp/bar $ echo "FROM scratch" > dock_er_file
ken@oblako:/tmp/bar $ echo "ADD quux /" >> dock_er_file
ken@oblako:/tmp/bar $ docker build -f dock_er_file .
unable to prepare context: The Dockerfile (/tmp/bar/dock_er_file) must be within the build context (.)
ken@oblako:/tmp/bar $ cd /tmp/foo
ken@oblako:/tmp/foo $ docker build -f dock_er_file .
Sending build context to Docker daemon 3.584 kB
Step 0 : FROM scratch
 --->
Step 1 : ADD quux /
 ---> Using cache
 ---> d98f184b7fe1
Successfully built d98f184b7fe1
ken@oblako:/tmp/foo $ docker --version
Docker version 1.8.1, build d12ea79
ken@oblako:/tmp/foo $ docker info
Containers: 0
Images: 310
Storage Driver: aufs
 Root Dir: /media/r0/var/lib/docker/aufs
 Backing Filesystem: extfs
 Dirs: 330
 Dirperm1 Supported: false
Execution Driver: native-0.2
Logging Driver: json-file
Kernel Version: 3.13.0-61-generic
Operating System: Ubuntu 14.04.3 LTS
CPUs: 8
Total Memory: 15.57 GiB
[ ... some redaction ... ]
WARNING: No swap limit support

Hi!
Please read this important information about creating issues.
If you are reporting a new issue, make sure that we do not have any duplicates already open. You can ensure this by searching the issue list for this repository. If there is a duplicate, please close your issue and add a comment to the existing issue instead.
If you suspect your issue is a bug, please edit your issue description to include the BUG REPORT INFORMATION shown below. If you fail to provide this information within 7 days, we cannot debug your issue and will close it. We will, however, reopen it if you later provide the information.
This is an automated, informational response.
Thank you.
For more information about reporting issues, see https://github.com/docker/docker/blob/master/CONTRIBUTING.md#reporting-other-issues

BUG REPORT INFORMATION
Use the commands below to provide key information from your environment:
docker version:
docker info:
uname -a:
Provide additional environment details (AWS, VirtualBox, physical, etc.):
List the steps to reproduce the issue:
1.
2.
3.
Describe the results you received:
Describe the results you expected:
Provide additional info you think is important:
----------END REPORT ---------
#ENEEDMOREINFO

This was already fixed in master in #15060.

Ah, looks like it yes. Thanks @tonistiigi
I'm closing this issue, because this should be resolved in https://github.com/docker/docker/pull/15060


feat(List): Convert heading prop to component List.Heading

Possible change to List.
Changes to component API to this:
<List size="medium">
  <List.Heading>Heading</List.Heading>
  <List.Ordered>
    <List.Item>List Item 1</List.Item>
    <List.Item>List Item 2</List.Item>
  </List.Ordered>
</List>

<List size="medium">
  <List.Heading>Heading</List.Heading>
  <List.Unordered>
    <List.Item>List Item 1</List.Item>
    <List.Item>List Item 2</List.Item>
  </List.Unordered>
</List>

The new markup is pretty 😋

We might have to add .Root to our providers as its very easy misunderstand or go wrong like this.
One might think still think this would be possible with current naming:
<List size="medium">
    <List.Item>List Item 1</List.Item>
    <List.Item>List Item 2</List.Item>
</List>


Link to telemetry feedback is broken

https://github.com/ibm-telemetry/telemetry-js/blob/4740cae7841ab086c1ff63371cadb11e74f147b1/.github/ISSUE_TEMPLATE/config.yml#L7
When creating a new issue, you are first presented with a few choices, including to "Share your feedback with the Telemetry squad.", however the link it takes you to is the github discussions page for this repository which is not enabled.

@timo not sure how we missed that - thanks for reporting! We've enabled discussions for this repository: https://github.com/ibm-telemetry/telemetry-js/discussions


A docs update for incorrect import in docs/book/user-guide/starter-guide/track-ml-models.md

Checks

[x] I added a descriptive title to this issue
[x] I have searched (google, github) for similar issues and couldn't find anything
[x] I have read and followed the docs and still think this is a bug

Pre-requisites
Please ensure you have done the following:

[x]  I have read the CONTRIBUTING.md document.
[x]  If my change requires a change to docs, I have updated the documentation accordingly.
[x]  I have added tests to cover my changes.
[ ]  I have based my new branch on develop and the open PR is targeting develop. If your branch wasn't based on develop read Contribution guide on rebasing branch to develop.
[ ]  If my changes require changes to the dashboard, these changes are communicated/requested.

Types of changes

[ ]  Bug fix (non-breaking change which fixes an issue)
[ ]  New feature (non-breaking change which adds functionality)
[ ]  Breaking change (fix or feature that would cause existing functionality to change)
[ ]  Other (add details above)

Closed by #2279


remove all doc except design and cli and add README

ref #541
remove all doc except design and cli
add README to explain any further doc change

close this.
After offline discussion, we decided to move kubevela.io repo into a website/ under this repo.


Prevent FileNotFoundError: when reading an external file.

Is your feature request related to a problem? Please describe.
When running pytest --nbmake on a .ipynb file that has a path to an external file within the directory causes a FileNotFoundError: to occur.  However, if the file is from a URL the test is completed.
Describe the solution you'd like
Be able to import an external file and read it with pd.read_csv() for example so the test can be completed.
Describe alternatives you've considered
This is not an issue using in nbconvert with the Python API interface, but nbmake is better in the command line than nbconvert.
Additional context

Hi @TomBerton thanks for the report.
I reckon this issue stems from the fact that nbmake sets the current working directory to the notebook's directory.
We did this to replicate the behaviour of running a notebook through the UI.
Our options apparently are to either (a) change the paths in your notebooks to ensure they can be found or (b) have a command line parameter to set the working directory to something else e.g. --nbmake-cwd=.
Keen to hear what your take is on this.

Closing this one as stale, feel free to re-open it if still impacting.


Spyder-has-encountered-a-problem

Description
What steps will reproduce the problem?

What is the expected output? What do you see instead?
Please provide any additional information below
File "C:\Users\Alik\AppData\Local\Continuum\anaconda3\lib\site-packages\spyder\plugins\ipythonconsole.py", line 1290, in close_client
self.create_new_client()
File "C:\Users\Alik\AppData\Local\Continuum\anaconda3\lib\site-packages\spyder\plugins\ipythonconsole.py", line 1009, in create_new_client
self.connect_client_to_kernel(client)
File "C:\Users\Alik\AppData\Local\Continuum\anaconda3\lib\site-packages\spyder\plugins\ipythonconsole.py", line 1044, in connect_client_to_kernel
kc.start_channels(shell=True, iopub=True)
File "C:\Users\Alik\AppData\Local\Continuum\anaconda3\lib\site-packages\qtconsole\kernel_mixins.py", line 43, in start_channels
super(QtKernelClientMixin, self).start_channels(*args, **kw)
File "C:\Users\Alik\AppData\Local\Continuum\anaconda3\lib\site-packages\jupyter_client\threaded.py", line 209, in start_channels
self.shell_channel._inspect = self._check_kernel_info_reply
File "C:\Users\Alik\AppData\Local\Continuum\anaconda3\lib\site-packages\jupyter_client\client.py", line 143, in shell_channel
socket, self.session, self.ioloop
File "C:\Users\Alik\AppData\Local\Continuum\anaconda3\lib\site-packages\jupyter_client\threaded.py", line 202, in ioloop
self._ioloop = ioloop.IO

please help on this matter.. I was trying to run spyder markdown, after downloading   the necessary packages I go this error above

How did you install spyder-reports?

Closed due to lack of response. If you can provide more information, please re-open and do so. Thanks.


Add script purpose

I think we should also add the new type and the new methods to both all_builtins.txt and CHANGELOG.md

v0.7.7


Tech stack used for the website/book?

Hey,
which frameworks are used to produce the website, book etc?
I looked around the repo and book but could not find any info about it.
Amazing project btw...

I guess it is Vuepress?

Yes it's Vuepress. I should probably point that out in the contributing guide. Vuepress is nice since it's very straightforward and easy to customize.


Feat: webcall actions

Hi !
Iris allow lots of actions in its plans steps, like :

User
Manager
Team
Oncall-Primary
Oncall-Secondary

It could be useful to have a 'WebCall' action which perform a simple HTTP call.
Why ?

Some microservices can perfom actions on incident
Make aggregations of incidents to build globals services status pages
We can build and update services dependencies trees
finaly, we can integrate Iris with others services like statuscake, datadog, etc...

Ok, thanks for all :-)


Support returning undefined in getPlaceholderData

Allowing returning undefined lets suspense mode still work as expected. Without this ability, getPlaceholderData will always prevent the query from suspending.

@dimitropoulos Added this to fix a few non-suspending queries.


update deps, simplify, reformat

🚀 The docs preview is ready! Check it out here:     https://modal-labs-examples--frontend-preview-1a05fee.modal.run


Channel closed error when running tests with Node 9.0.0-pre

I'm making some changes to the Node vm-module and wanted to make sure they don't break Jest.
I'm having trouble running yarn jest with current Node master 1fd662c0e3 (even without my patch with breaking changes). We're cutting Node 9 this Sunday. Would anybody want to look into these problems or do you skip odd Node version numbers anyways?
See https://github.com/nodejs/node/pull/16293
yarn jest
....
 RUNS  integration_tests/__tests__/auto_clear_mocks.test.js

Test Suites: 0 of 178 total
Tests:       0 total
Snapshots:   0 total
Time:        0s, estimated 17s
████████████████████████████████████████events.js:195
      throw er; // Unhandled 'error' event
      ^

Error [ERR_IPC_CHANNEL_CLOSED]: Channel closed
    at ChildProcess.target.send (internal/child_process.js:606:16)
 at Object.send (/usr/local/google/home/franzih/code/jest/node_modules/worker-farm/lib/fork.js:24:17)
    at Farm.stopChild (/usr/local/google/home/franzih/code/jest/node_modules/worker-farm/lib/farm.js:131:11)
    at Farm.<anonymous> (/usr/local/google/home/franzih/code/jest/node_modules/worker-farm/lib/farm.js:96:10)
    at ontimeout (timers.js:478:11)
    at tryOnTimeout (timers.js:302:5)
    at Timer.listOnTimeout (timers.js:262:5)
error Command failed with exit code 1.

jest (master)$ yarn versions
yarn versions v1.2.1
warning You are using Node "9.0.0-pre" which is not supported and may encounter bugs or unexpected behavior. Yarn supports the following semver range: "^4.8.0 || ^5.7.0 || ^6.2.2 || ^8.0.0"
{ http_parser: '2.7.0',
  node: '9.0.0-pre',
  v8: '6.2.414.32-node.3',
  uv: '1.15.0',
  zlib: '1.2.11',
  ares: '1.13.0',
  modules: '59',
  nghttp2: '1.25.0',
  openssl: '1.0.2l',
  icu: '59.1',
  unicode: '9.0',
  cldr: '31.0.1',
  tz: '2017b' }
Done in 0.06s.

@fhinkel node 9 rc fails on worker-farm's test suite as well.
><EMAIL_ADDRESS>test /Users/simbekkh/repos/node-worker-farm
> node ./tests/

TAP version 13
# simple, exports=function test
ok 1 pid makes sense
ok 2 pid makes sense
ok 3 rnd result makes sense
ok 4 workerFarm ended
# simple, exports.fn test
ok 5 pid makes sense
ok 6 pid makes sense
ok 7 rnd result makes sense
ok 8 workerFarm ended
# single worker
ok 9 only a single process (by pid)
ok 10 workerFarm ended
# two workers
ok 11 only two child processes (by pid)
ok 12 workerFarm ended
# many workers
ok 13 pids are all the same (by pid)
ok 14 workerFarm ended
# auto start workers
ok 15 child has been up before the request
ok 16 child has been up before the request
ok 17 child has been up before the request
ok 18 workerFarm ended
# single call per worker
ok 19 one process for each call (by pid)
ok 20 workerFarm ended
# two calls per worker
ok 21 one process for each call (by pid)
ok 22 workerFarm ended
# many concurrent calls
ok 23 processed tasks concurrently (173ms)
ok 24 workerFarm ended
# single concurrent call
ok 25 processed tasks sequentially (304ms)
ok 26 workerFarm ended
# multiple concurrent calls
ok 27 processed tasks concurrently (277ms)
ok 28 workerFarm ended
# durability
events.js:195
      throw er; // Unhandled 'error' event
      ^

Error [ERR_IPC_CHANNEL_CLOSED]: Channel closed
    at ChildProcess.target.send (internal/child_process.js:606:16)
    at Object.send (/Users/simbekkh/repos/node-worker-farm/lib/fork.js:24:17)
    at Farm.stopChild (/Users/simbekkh/repos/node-worker-farm/lib/farm.js:131:11)
    at Farm.<anonymous> (/Users/simbekkh/repos/node-worker-farm/lib/farm.js:96:10)
    at ontimeout (timers.js:478:11)
    at tryOnTimeout (timers.js:302:5)
    at Timer.listOnTimeout (timers.js:262:5)
npm ERR! Test failed.  See above for more details.

/cc @rvagg

To follow up here as well, reverting https://github.com/nodejs/node/commit/f2b01cba7b48c2410a692fe1cb29b2e88a6c5cab makes both worker-farm's and jest's test suites pass on node master. Not sure if it's considered a bug in node or worker-farm

Do you want to report it as a separate issue on the Node tracker? We're cutting Node 9 on Sunday, would be good to have a look at that before then. Thanks!

I can do that!

https://github.com/nodejs/node/issues/16322

I guess I can check if my patch breaks anything by reverting https://github.com/nodejs/node/commit/f2b01cba7b48c2410a692fe1cb29b2e88a6c5cab. Thanks for bisecting @SimenB


Add autodetection for L530 and P110

This adds the mac address prefixes for P110 and L530. I left the hostname wildcards rather lax in hopes that other P1* and L5* devices share the same mac address space.

@sdb9696 btw, I saw you dropped this one from the PR, was that done on purpose or should I submit a new one including the information for L900?

Hmm, apologies that was an accident, I must have force pushed over it after merging.  If it's not too much trouble to re-submit a PR that would be great as I'm not sure how to generate the dhcp file. Is that done using hassfest?

Ok, no worries. Yeah, the hassfest generates that file based on the manifest contents. I'll create a new PR and include the L900-5 I have with it :-)


Add dockerfile for Docker deployments

Title says it all. Minimal Python setup that will run the script.

Working on this, including github workflow to automatically push the image to GHCR.io.
See #55 and further work in https://github.com/q1x/netbox-zabbix-sync/tree/dockertest

I think we can close this one?

Closed!


Smaller final docker image

Split the build process into 2 parts: the first part does the build in
a docker image with the full haskell toolchain, etc. The second part
copies the necessary files for actually running (a statically compiled
binary & the HLint source) into a much smaller docker image.
The engine source had to be adjusted for this a bit: HLint reads its own
source code for default configuration, and we need to change the path it
looks in.

@pbrisbin This does work for me locally. My organization is currently a bit messy, though.
There's also some interesting log messages during the build about the glibc version used for linking needing to be available on the target platform even for a static build. Not entirely sure what to make of those or how concerned to be.
The tests broke because I hard-coded the path it looks in to the path it is in the final docker image: but the tests aren't running in that image, so the path doesn't exist. I poked at determining the path to read from based on where the running executable was, but that's a bit beyond my current haskell knowledge with IO. Won't really fix the tests, anyway: seems like we might need to either copy the files explicitly for the tests (not a fan) or fall back to asking for the cabal path if the local one doesn't exist?
Anyway, this is at least progress in the right direction that we can work on.

Merged via #8


Update Conditions and Validators to Use Configs

Description
Many of the conditions and validators are configurable. These configurations should be condensed into struct's with the appropriate default values in the initializer. Then the config can be passed into the condition or validator rather than a whole slew of arguments. This will allow for easier extension in the future and keep method names short.

Closing by #40. Will be a part of the 2.0 release.


Webpack 2 treats 'stats' option inconsistently

Do you want to request a feature or report a bug?
A bug
What is the current behavior?
If you have a config like this:
module.exports = {
    stats: { modules: false },
    ... other config ...
};

... then Webpack 2 completely ignores the modules: false setting, and displays modules in stats (which it should not).
However, if you change your config to this:
module.exports = [{
    stats: { modules: false },
    ... other config ...
}];

... then it correctly honours the modules: false setting. I don't think this is by design - you shouldn't have to declare your config as a single-element array just to make it work, should you?

What is the expected behavior?
Consistency between module.exports = { ... }; and module.exports = [{ ... }]; styles.

Looks like a bug

presetsToOptions?

@SteveSandersonMS Which webpack version do you use?

@sokra Whatever version is latest (currently 2.2.1). Thanks for the fix!

@SteveSandersonMS Is this fixed now for you?

oh this is in master disregard,

Just confirming, this is still present on Version 2.2.1.

is there any ETA for this fix?

fixed in next branch