Tests fail with nightly

rustc 1.10.0-nightly (9c6904ca1 2016-05-18)
---- Connection::transaction_0 stdout ----
	<anon>:7:19: 7:23 error: cannot borrow immutable borrowed content `*conn` as mutable
<anon>:7     let tx = try!(conn.transaction());
                           ^~~~
<anon>:7:19: 7:23 note: in this expansion of try! (defined in <std macros>)
error: aborting due to previous error(s)
thread 'Connection::transaction_0' panicked at 'Box<Any>', ../src/librustc/session/mod.rs:169
note: Run with `RUST_BACKTRACE=1` for a backtrace.

---- transaction::Transaction<'conn>::savepoint_0 stdout ----
	<anon>:6:19: 6:23 error: cannot borrow immutable borrowed content `*conn` as mutable
<anon>:6     let tx = try!(conn.transaction());
                           ^~~~
<anon>:6:19: 6:23 note: in this expansion of try! (defined in <std macros>)
<anon>:9:23: 9:25 error: cannot borrow immutable local variable `tx` as mutable
<anon>:9         let sp = try!(tx.savepoint());
                               ^~
<anon>:9     let tx = try!(conn.transaction());
                 ^~
<anon>:9:23: 9:25 note: in this expansion of try! (defined in <std macros>)
error: aborting due to previous error(s)
thread 'transaction::Transaction<'conn>::savepoint_0' panicked at 'Box<Any>', ../src/librustc/session/mod.rs:169

---- transaction::Transaction_0 stdout ----
	<anon>:7:19: 7:23 error: cannot borrow immutable borrowed content `*conn` as mutable
<anon>:7     let tx = try!(conn.transaction());
                           ^~~~
<anon>:7:19: 7:23 note: in this expansion of try! (defined in <std macros>)
error: aborting due to previous error(s)
thread 'transaction::Transaction_0' panicked at 'Box<Any>', ../src/librustc/session/mod.rs:169

failures:
    Connection::transaction_0
    transaction::Transaction<'conn>::savepoint_0
    transaction::Transaction_0

test result: FAILED. 23 passed; 3 failed; 1 ignored; 0 measured

Huh, I wonder why those doctests didn't fail on stable. They're definitely wrong now. Thanks!


Translate Templates in Variant Suggestion to Utility Features When Possible

The variant suggestions allow for users / editors to specify templates for generic effects (like a sac outlet). The problem with this is there is no way to specify utility features. For example, sac outlets are listed as utility features. So when we "Add as new combo", it doesn't find the utility feature and instead reads it as an unknown template. See the below pics:

One of two ways to fix it.

Allow editors to add a specific utility feature to a variant suggestion, and then translate then when "Accept as new combo" is pressed.
Alter the program to search templates, and then search features for anything that matches the title. If it finds a feature, it can then add it. So if we put "Free Sacrifice Outlet - Creatures" in the Template field of a suggestion, the program would search for a template with that name. When it doesn't find it, it then searches for a Feature with that name. It would find it and then add it.

I have no preference on either of those options, so feel free to use your discretion on which is easier.

I'm going with 2


Airships just bob up and down.

I'm having problems with Davinci's vessels, but I think its related to the weight of the airship, because when I try to ascend it goes up a block and goes back down immediately. The weight of the ship is 595kg
Mod version 1.12.2
(first time posting)

Ok I think its weight related, but it doesn't seem to go under 1 block of the ground. The hitbox is clear of anything that would disrupt it. Is there any way to reduce the weight?


fix: turn on non-default-domain-projects by default at 2.10

这个 PR 实现什么功能/修复什么问题:
2.10默认打开3级权限，之后版本默认关闭
是否需要 backport 到之前的 release 分支:

release/2.10.0

/cc @yousong
/area keystone

/approve
/lgtm

Codecov Report

:exclamation: No coverage uploaded for pull request base (release/2.10.0@8309dd0). Click here to learn what that means.
The diff coverage is n/a.

@@               Coverage Diff                @@
##             release/2.10.0   #1974   +/-   ##
================================================
  Coverage                  ?   7.61%
================================================
  Files                     ?     410
  Lines                     ?   63169
  Branches                  ?       0
================================================
  Hits                      ?    4813
  Misses                    ?   57945
  Partials                  ?     411

Flag
Coverage Δ

#aFlag
7.61% <ø> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8309dd0...7fc9447. Read the comment docs.


[Technical] Application logic to sort glossary entries

translationn script extend to sort json arrays

Hey team! Please add your planning poker estimate with Zenhub @DimitriB01 @juli-txt @Platura


Fixing translation key for sendAppPage.ts

Wrong translation key was used in sendAppPage.ts

Thanks @arnaudpeich!


Some ADT docs to MS learn links are broken

Some ADT docs to MS learn links here are broken:
https://github.com/MicrosoftDocs/azure-docs/blob/fe9a358adbfa6e026613b69f02f6ff33d1801dab/articles/digital-twins/index.yml#L119-L134
E.g. if you go to https://docs.microsoft.com/en-us/azure/digital-twins/ and click the "learning path" link it doesn't link to a learning path page.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 411f74ce-0f28-4a74-6b67-814116d718e2
Version Independent ID: 6e373495-4e53-d9e7-17d4-93a2801f351c
Content: What is Azure Digital Twins? - Azure Digital Twins
Content Source: articles/digital-twins/overview.md
Service: digital-twins
GitHub Login: @baanders
Microsoft Alias: baanders

@cdeil Thanks for the feedback! We are currently investigating and will update you shortly.

@baanders I am unable to modify the details. Please look into this feedback and update the links according.

Thank you for raising this!
I'm replacing the outdated Learn links on that page with a link to the latest learning path, Extend IoT solutions by using Azure Digital Twins, in this PR.
I'll have Git automatically close this issue once the PR with the link fix is merged. Thank you!


[BUG]failed to open the next note automatically after reviewing another

Describe the bug
failed to open the next note automatically after reviewing another
Versions (please complete the following information):

OS: win10
Obsidian version: 1.1.9
Plugin version: 1.9.3

Additional context
I enabled this option in settings, but it sometimes works, sometimes does not work, and most of the time does not work.

+1 for this issue! It actually forces to vote twice on the same note to actually get to the next one, thus altering the score because of such double vote.

Duplicate of #424

This has been fixed in the latest release (v1.11.1). I'm closing this issue but if it's still occurring, please re-open the issue and we'll look into it further


added help to nav bar

Dear https://github.com/NoelineNalugemwa linked profile owner "NoelineNalugemwa "
If you can write the content of the contact section nicely, it can be checked.
It can also be added to all pages.
Best regards,
Berat Gökdemir


Adding missed out request/response parameter change to new version 2021-06-01 for Azure Site Recovery.

MSFT employees can try out our new experience at OpenAPI Hub  - one location for using our validation tools and finding your workflow.

Changelog
Please ensure to add changelog with this PR by answering the following questions.

What's the purpose of the update?

[ ] new service onboarding
[ ] new API version
[ ] update existing version for new feature
[ ] update existing version to fix swagger quality issue in s360
[x] Other, please clarify :
In Azure Site Recovery we raised swagger PR New Version 2021-06-01 for Azure Site Recovery. #14794. We forgot to add 2 changes: resource naming(custom target disk, NIC names) and container mapping API This PR is to add those changes.

When you are targeting to deploy new service/feature to public regions? Please provide date, or month to public if date is not available yet.
July, 2021.
When you expect to publish swagger? Please provide date, or month to public if date is not available yet.
We want to publish ASAP.
If it's an update to existing version,  please select SDKs of specific language and CLIs that require refresh after swagger is published.

[x] SDK of .NET (need service team to ensure code readiness)
[ ] SDK of Python
[ ] SDK of Java
[ ] SDK of Js
[ ] SDK of Go
[ ] PowerShell
[ ] CLI
[ ] Terraform
[ ] No, no need to refresh for updates in this PR

Contribution checklist:

[x] I commit to follow the Breaking Change Policy of "no breaking changes"
[x] I have reviewed the documentation for the workflow.
[x] Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist

[ ] Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.

Adding new API(s)
Adding a new API version
[ ] Ensure to copy the existing version into new directory structure for first commit (including refactoring) and then push new changes including version updates in separate commits. This is required to review the changes efficiently.
Adding a new service

[ ] Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

[ ] If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist
If there are following updates in the PR, ensure to request an approval from Breaking Change Review Board as defined in the Breaking Change Policy.

[ ] Removing API(s) in stable version
[ ] Removing properties in stable version
[ ] Removing API version(s) in stable version
[ ] Updating API in stable or public preview version with Breaking Change Validation errors
[ ] Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.

This PR is to add an additional commit  containing changes that were missed out in the original PR  which has been reviewed for break changes and passed by ARM team.
Tagging @chunyu3 , for FYI regarding older PR.

@prsadhu-ms-idc pls help resolve the PR conflict

@prsadhu-ms-idc pls help resolve the PR conflict

I have resolved the conflict in readme.md

Closing this PR as we have decided to change the contracts included in this commit.


Markdown support?

Is it possible to setup markdown export?

Yes, it is.

Hey guys it seems I conf.json file is setup properly to read markdown however. It is not compiling it on my side. I must be missing some details. Could someone guide me through this? Or has anybody been able to use markdown syntax.
Thanks


Leverage the Configuration Cache to Speed up the Configuration Phase of the Build

Codecov Report

Merging #586 into master will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #586   +/-   ##
=======================================
  Coverage   54.10%   54.10%
=======================================
  Files         331      331
  Lines       57734    57734
=======================================
+ Hits        31235    31237    +2
+ Misses      26499    26497    -2

Impacted Files
Coverage Δ

src/lib/profiles/security/WeaveCert.cpp
88.96% <0.00%> (+0.45%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 23f3957...9557315. Read the comment docs.


Ecommerce: open edX: Purchase a verified certificate option doesn't work from within a course

Steps to Reproduce

Enroll in a course, but don't pay for it
Go to the course in edX (see image below)

Expected Behavior

Either:

there will not be a Pursue a verified certificate section on the page
the Upgrade for $xxx button will direct the learner through the ecommerce flow to update the course

Actual Behavior

Clicking on the Upgrade for $xxx button redirects the learner to their dashboard without purchasing

Screenshot or Screencast

I think this requires the plugin Arslan wrote https://github.com/mitodl/open-edx-plugins/pull/31
Has that been deployed to production?

Note that the verified certificate link in this section is broken as well.

This should be fixed by #556 and #610.

Posting an update on a few things that are testable on RC as of now:

Course Upgrade button is only visible for the courses that have Verified course mode(In our case) added & the user is enrolled in a free mode e.g. Audit
As of now, the plugin for redirecting the user to MITxOnline so clicking the Upgrade button will take the user to the cart in MITxOnline where the user can pay.
After successful completion of payment from MITxOnline, if you visit this course in edX again you won't see any Upgrade button because the user is not enrolled in Verified Mode.

Summing up:

Clicking on the Upgrade for $xxx button redirects the learner to their dashboard without purchasing

This is now working on RC

Note that the verified certificate link in this section is broken as well.

As per https://github.com/mitodl/frontend-app-learning/pull/3 (This still needs a deployment though)
There would be no verified certificate link with the updated design
Also, there should be no price mentioned with Upgrade button in the updated design
What I enabled for testing purposes:
By default the enrollments are not visible in Django Admin so, I added a waffle switch(student.courseenrollment_admin) to look through the Enrollments here. This will help verify that once the user purchases the course through MITxOnline, he gets enrolled from Audit to Verified course mode.
FYI, @briangrossman

@arslanashraf7 do you think we can close this?

@pdpinch Yes, We can close this through https://github.com/mitodl/frontend-app-learning/pull/3, https://github.com/mitodl/ol-infrastructure/pull/903, and https://github.com/mitodl/open-edx-plugins/pull/31. Though we need to remember to set the required infra-related settings when we ship there. Or if there is a checklist I can add it there as a reminder.


Update Note markdown

@JohanFreelancer9 - kindly do the copy editor review for this PR. Thanks

@Dansimp Please merge this PR. Thanks


TaskRun Fails to Create Pod When ServiceAccount References Non-Existent Secret

Expected Behavior
When repairing a ServiceAccount that includes a reference to a non-existent secret, I expect the TaskRun to issue a warning and proceed with the creation of the Pod, similar to Kubernetes’ behavior of handling missing imagePullSecrets within a Pod’s service account configuration.
Log a warning if a ImagePullSecrets does not exist
Actual Behavior
Currently, if a ServiceAccount is referenced by a TaskRun and contains a non-existent secret, the TaskRun fails to create the associated Pod and results in an error.
Steps to Reproduce the Problem

Execute the following script:

kubectl apply -f - <<EOF
---
apiVersion: v1
kind: ServiceAccount
metadata:
  name: taskrun-sa
secrets:
- name: not-exist
---
apiVersion: tekton.dev/v1
kind: TaskRun
metadata:
  name: test-sa-has-not-found-secret
spec:
  serviceAccountName: taskrun-sa
  taskSpec:
    description: |
      A simple task that prints the date.
    steps:
      - name: echo
        image: bash:latest
        script: |
          #!/usr/bin/env bash
          echo "Hello, world!"
status:
  conditions:
  - message: 'failed to create task run pod "test-sa-has-not-found-secret": translating
      TaskSpec to Pod: secrets "not-exist" not found. Maybe invalid TaskSpec'
    reason: PodCreationFailed
    status: "False"
    type: Succeeded
EOF

Additional Info

Kubernetes version:
Output of kubectl version:

Client Version: v1.29.3
Kustomize Version: v5.0.4-0.20230601165947-6ce0bf390ce3
Server Version: v1.28.8

Tekton Pipeline version:
Output of tkn version or kubectl get pods -n tekton-pipelines -l app=tekton-pipelines-controller -o=jsonpath='{.items[0].metadata.labels.version}'

Client version: 0.35.1
Pipeline version: v0.57.0

/assign @l-qing

@l-qing I understand the idea of keeping it "consistent" with Kubernetes, but I think it may also be valid to error out. If the user specified a secret, and the secret is not present, then the "credential" handling (via service account) will fail or not work, and a warning (through events) is usually harder to find for users than their TaskRun or PipelineRun to fail…
I wonder what use-case this would cover (there is probably valid ones).
cc @tektoncd/core-maintainers

I wonder what use-case this would cover (there is probably valid ones).
cc @tektoncd/core-maintainers

In our environment, there are other controllers that synchronize secrets across multiple clusters and associate them with related service accounts. Sometimes it involves adding secrets, and sometimes it involves deleting them. I am not sure if the sequence of operations ensures that the secret exists before updating the service account, or if it removes the secret from the service account before deleting the secret.
However, the phenomenon I have encountered is that the pipeline TaskRuns intermittently fail due to the absence of certain credentials on some service accounts. This kind of problem is just a warning on the created k8s Pods and does not lead to an actual failure. I am also not sure if this issue is caused by the Tekton cache client not updating in a timely manner.


GNOME updates 2024-08-03

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

@ofborg build libshumate gnome.gnome-music gnome-builder gnome.gnome-bluetooth evolution-ews evolution-data-server evolution papers evince eog cambalache


update readme.md

On the main readme.md the link for iplug is outdated, change to this: https://github.com/sdatkinson/NeuralAmpModelerPlugin

Good call; on it


Support boost 1.69

Jenkins Build Summary
Built from this commit
Built at 20181212 - 17:04:07
Test Results

Build Type
Log
Result
Status

msvc.Debug
logfile
1141 cases, 0 failed, t: 645s
PASS :white_check_mark:

gcc.Release -Dassert=ON, MANUAL_TESTS=true
logfile
915 cases, 0 failed, t: 6m12s
PASS :white_check_mark:

docs, TARGET=docs
logfile
1 cases, 0 failed, t: 0m1s
PASS :white_check_mark:

gcc.Debug -Dcoverage=ON, TARGET=coverage_report, SKIP_TESTS=true
logfile
1144 cases, 0 failed, t: 17m16s
PASS :white_check_mark:

clang.Debug
logfile
1144 cases, 0 failed, t: 3m14s
PASS :white_check_mark:

rpm
logfile
1144 cases, 0 failed, t: n/a
PASS :white_check_mark:

msvc.Debug, NINJA_BUILD=true
logfile
1141 cases, 0 failed, t: 656s
PASS :white_check_mark:

gcc.Debug
logfile
1144 cases, 0 failed, t: 3m30s
PASS :white_check_mark:

clang.Debug -Dunity=OFF
logfile
1144 cases, 0 failed, t: 7m23s
PASS :white_check_mark:

clang.Release -Dassert=ON
logfile
1144 cases, 0 failed, t: 5m42s
PASS :white_check_mark:

gcc.Debug -Dunity=OFF
logfile
1144 cases, 0 failed, t: 11m2s
PASS :white_check_mark:

gcc.Release -Dassert=ON
logfile
1144 cases, 0 failed, t: 6m16s
PASS :white_check_mark:

msvc.Debug -Dunity=OFF
logfile
1141 cases, 0 failed, t: 1293s
PASS :white_check_mark:

gcc.Debug -Dstatic=OFF
logfile
1144 cases, 0 failed, t: 3m27s
PASS :white_check_mark:

gcc.Debug -Dstatic=OFF -DBUILD_SHARED_LIBS=ON
logfile
1144 cases, 0 failed, t: 3m28s
PASS :white_check_mark:

gcc.Debug, NINJA_BUILD=true
logfile
1144 cases, 0 failed, t: 3m3s
PASS :white_check_mark:

msvc.Release
logfile
1141 cases, 0 failed, t: 424s
PASS :white_check_mark:

clang.Debug -Dunity=OFF -Dsan=address, PARALLEL_TESTS=false, DEBUGGER=false
logfile
1144 cases, 0 failed, t: 7m37s
PASS :white_check_mark:

clang.Debug -Dunity=OFF -Dsan=undefined, PARALLEL_TESTS=false
logfile
1144 cases, 0 failed, t: 10m27s
PASS :white_check_mark:

It isn't looking good on macOS:
In file included from /Users/howardhinnant/Development/rippled/src/ripple/app/main/Main.cpp:49:
In file included from /Users/howardhinnant/Development/boost_1_69_0/boost/process.hpp:24:
In file included from /Users/howardhinnant/Development/boost_1_69_0/boost/process/async_system.hpp:22:
In file included from /Users/howardhinnant/Development/boost_1_69_0/boost/process/child.hpp:21:
In file included from /Users/howardhinnant/Development/boost_1_69_0/boost/process/detail/child_decl.hpp:30:
/Users/howardhinnant/Development/boost_1_69_0/boost/process/detail/posix/wait_for_exit.hpp:60:7: error: expected unqualified-id
    ::sigemptyset(&sigset);
      ^
/usr/include/signal.h:125:26: note: expanded from macro 'sigemptyset'
#define sigemptyset(set)        (*(set) = 0, 0)
                                ^

I've got a comment in cpplang.slack.com #boost about this.  Waiting for responses.

Pushed a commit to update FindBoost.cmake to the latest, as suggested by @mellery451

@miguelportilla I would expect that warning for cmake 3.12.4 or greater, but I don't think it has anything to do with this PR. Maybe you recently upgraded your cmake version (or visual studio if it includes CMake)? We should go ahead and explicitly set policy CMP0074 in our cmake, but I don't think it needs to be in this PR.

Fedora 30 will ship with Boost 1.69 too: https://apps.fedoraproject.org/packages/boost

Thanks for the info @MarkusTeufelberger. BTW, this PR will go into the first 1.3.0 beta;


Fix Infinite loop on timezone page when visit timezone selection page by direct link

Details

Fixed Issues

$ https://github.com/Expensify/App/issues/22813
PROPOSAL: https://github.com/Expensify/App/issues/22813#issuecomment-1642116546
Tests

Precondition: Disable "Automatically determine your location" in timezone setting for current account.

Go to timezone selection page by direct link (I.e http://localhost:8080/settings/profile/timezone/select or https://staging.new.expensify.com/settings/profile/timezone/select)
Select any other timezone
Press back arrow in the top header
Verify it backs to the Profile page

[x] Verify that no errors appear in the JS console

Offline tests

PR changes are not affected by network status
QA Steps

Same as Tests

[x] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android / native
[x] Android / Chrome
[x] iOS / native
[x] iOS / Safari
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] If we are not using the full Onyx data that we loaded, I've added the proper selector in order to ensure the component only re-renders when the data it is using changes
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[x] I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

https://github.com/Expensify/App/assets/9639873/6aa9ea99-d8a4-4273-b37c-26f35eba0d08

Mobile Web - Chrome

https://github.com/Expensify/App/assets/9639873/2ad21b2b-7eeb-4971-a3fc-7078bbe91a68

Mobile Web - Safari

https://github.com/Expensify/App/assets/9639873/f3429914-4806-4a1c-9b45-4eac4d24c207

Desktop

https://github.com/Expensify/App/assets/9639873/aa3e03df-1d4f-4ae6-a30e-454adaedf697

iOS

https://github.com/Expensify/App/assets/9639873/f16ef447-c208-4384-a5ff-b7449dc42b67

Android

https://github.com/Expensify/App/assets/9639873/20a2e752-bf99-49fb-aaa6-af53ab4575c7

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.


Use backing fields when available

It's a simplified version of what @deipax did in #22.
The way we're doing per-type clone delegate caching makes additional caching of reflection data unnecessary. So instead of using ModelInfo<T> from Deipax.Core.Common it's simply checking the fields when the clone delegate is generated, without any additional caching.
Benchmark results:
.NET Core - before
                                      Method |           Mean |         Error |        StdDev |
-------------------------------------------- |---------------:|--------------:|--------------:|
                         GetCloneSimpleClass |       132.5 ns |      1.793 ns |      1.296 ns |
                          GetCloneListOfInts |     4,751.3 ns |     67.455 ns |     52.664 ns |
       GetCloneListOfSimpleClassSameInstance |   632,354.0 ns |  8,291.360 ns |  7,350.074 ns |
 GetCloneListOfSimpleClassDifferentInstances | 1,806,829.9 ns | 27,005.394 ns | 23,939.576 ns |

.NET Core - with #22 applied
                                      Method |           Mean |         Error |        StdDev |
-------------------------------------------- |---------------:|--------------:|--------------:|
                         GetCloneSimpleClass |       133.7 ns |      2.630 ns |      3.131 ns |
                          GetCloneListOfInts |     4,721.2 ns |     91.612 ns |    105.500 ns |
       GetCloneListOfSimpleClassSameInstance |   651,762.3 ns | 10,653.091 ns |  8,895.813 ns |
 GetCloneListOfSimpleClassDifferentInstances | 1,770,150.1 ns | 31,561.661 ns | 27,978.587 ns |

.NET Core - with these changes
                                      Method |           Mean |         Error |        StdDev |
-------------------------------------------- |---------------:|--------------:|--------------:|
                         GetCloneSimpleClass |       129.1 ns |      1.655 ns |      1.548 ns |
                          GetCloneListOfInts |     4,706.9 ns |     87.409 ns |     72.991 ns |
       GetCloneListOfSimpleClassSameInstance |   665,777.9 ns |  9,338.243 ns |  8,278.109 ns |
 GetCloneListOfSimpleClassDifferentInstances | 1,811,359.6 ns | 29,407.678 ns | 26,069.138 ns |

.NET Framework 4.6.1 - before
                                      Method |           Mean |          Error |         StdDev |
-------------------------------------------- |---------------:|---------------:|---------------:|
                         GetCloneSimpleClass |       255.2 ns |       3.486 ns |       2.911 ns |
                          GetCloneListOfInts |     4,683.8 ns |      60.154 ns |      50.231 ns |
       GetCloneListOfSimpleClassSameInstance | 1,117,613.7 ns |  20,728.126 ns |  17,308.923 ns |
 GetCloneListOfSimpleClassDifferentInstances | 5,182,728.0 ns | 110,875.858 ns | 123,238.212 ns |

.NET Framework 4.6.1 - with #22 applied
                                      Method |           Mean |         Error |        StdDev |
-------------------------------------------- |---------------:|--------------:|--------------:|
                         GetCloneSimpleClass |       149.7 ns |      3.023 ns |      7.359 ns |
                          GetCloneListOfInts |     4,691.6 ns |     71.216 ns |     55.600 ns |
       GetCloneListOfSimpleClassSameInstance |   939,968.9 ns | 17,599.375 ns | 16,462.464 ns |
 GetCloneListOfSimpleClassDifferentInstances | 2,385,342.2 ns | 71,420.279 ns | 59,639.162 ns |

.NET Framework 4.6.1 - with these changes
                                      Method |           Mean |         Error |        StdDev |
-------------------------------------------- |---------------:|--------------:|--------------:|
                         GetCloneSimpleClass |       138.1 ns |      1.481 ns |      1.386 ns |
                          GetCloneListOfInts |     4,668.7 ns |     83.819 ns |     74.304 ns |
       GetCloneListOfSimpleClassSameInstance |   971,472.9 ns | 18,936.852 ns | 30,579.487 ns |
 GetCloneListOfSimpleClassDifferentInstances | 2,372,608.3 ns | 42,565.389 ns | 39,815.687 ns |

To summarize above

pretty much no changes for .NET Core
noticeable performance improvements for .NET Framework
similar performance of this code and #22

Marcin,
I really like your test output, I would be very interested in learning how you did it.
I would really like to dig into why there was no performance gain with the .Net Core ... if I had to guess, I would say that it looks like the backing fields either do not exist or were not found.
It has been quite a while since I authored the ModelInfo class, but if I recall correctly, when fetching private fields for a type it only does so for that type and none of the classes from which it inherits.  If a class has deep inheritance, I believe only the backing fields for the top class would be returned the way it is authored now.
Look for - private static IReadOnlyList GetAllFields(Type t, int depth = 0) - in the modelInfo class.   It is a recursive function that traverses the inheretance chain and builds the full list of private fields.
Once you have the full list of backing fields, the code you have should be good.

Good call. I updated the change with some extra logic to use backing fields for properties from base classes too. I validated that it works. I also validated that backing fields are used for both .NET Core and .NET Framework. I suspect there are some optimizations in .NET Core which make property access same as field access for automatic properties. That's why there is no difference.
The new benchmark results:
.NET Core
                                      Method |           Mean |         Error |        StdDev |
-------------------------------------------- |---------------:|--------------:|--------------:|
                         GetCloneSimpleClass |       128.2 ns |      2.569 ns |      3.765 ns |
                          GetCloneListOfInts |     4,531.7 ns |     60.566 ns |     56.653 ns |
       GetCloneListOfSimpleClassSameInstance |   636,932.2 ns |  6,268.455 ns |  5,556.821 ns |
 GetCloneListOfSimpleClassDifferentInstances | 1,710,996.7 ns | 17,378.553 ns | 16,255.908 ns |

.NET Framework 4.6.1
                                      Method |           Mean |         Error |        StdDev |
-------------------------------------------- |---------------:|--------------:|--------------:|
                         GetCloneSimpleClass |       135.0 ns |      1.947 ns |      1.821 ns |
                          GetCloneListOfInts |     4,531.9 ns |     57.493 ns |     50.966 ns |
       GetCloneListOfSimpleClassSameInstance |   912,664.9 ns |  3,777.194 ns |  3,154.128 ns |
 GetCloneListOfSimpleClassDifferentInstances | 2,267,383.3 ns | 21,317.802 ns | 18,897.674 ns |

These benchmarks are done using BenchmarkDotNet (see http://benchmarkdotnet.org/). It's awesome and I highly recommend it. It's really easy to use, you can see a change where I added them to this repo here: https://github.com/MarcinJuraszek/CloneExtensions/commit/63a438f503a2cc754ad3458dfb34714734626eb7

Marcin,
Good work!  That should do it.  The only thing I can see now that may cause an issue would be the this:
var backingFields = GetBackingFields(_type).ToDictionary(f => f.Name);
If, for some reason, someone used "new" on a property and named the property the same name to hide the property of a parent, this would throw an exception.  Nit picky, I know, but I thought I should mention it.
I will play with the Benchmark.Net, it looks like a solid tool.  I will revert my changes and sync from your branch to grab your most recent work.
-Jeff

That's not nit picking. That's a valid concern. I make a check that the property and backing field are both defined in the same type:
if (backingFields.TryGetValue("<" + property.Name + ">k__BackingField", out fieldInfo) && fieldInfo.DeclaringType == property.DeclaringType)

But there is still a potential exception in ToDictionary. I'll fix that tonight and merge the changes to master.

So, I fixed the exception, but turns out cloning properties that are shadowed doesn't really work that well after all with or without my change. I logged a separate issue for that (https://github.com/MarcinJuraszek/CloneExtensions/issues/25) not to block this change from being merged.


Darwin can't unpack nghttp2-0.7.13.tar.xz because there's no xz in stdenv

nix-env -u leads to the above error.
log here: gist: $nix-env -u

The relevant part will be
/nix/store/18cbyb968m1313sgxfhgyf2cc85fynmi-stdenv-darwin-boot-1/setup: line 500: xz: command not found
do not know how to unpack source archive /nix/store/262dmrsf8cnv9h915rasjsp77rwxgf49-nghttp2-0.7.13.tar.xz

Is there no xz in darwin stdenv?

nope...

well it is there. Line 108 of stdenv/darwin/defualt.nix. The question is why its not being picked up.

I think back in the days when I wrote that stdenv, there was no xz in the early bootstrap phases of the linux stdenv either, which was my model for the new darwin one. They all have an xz by the end of the bootstrapping, of course, but in the past xz wasn't needed in the earlier phases. It shouldn't be hard to add, but I don't have time to do that. Perhaps if you ask in ##nix-darwin on freenode, you'll get someone who knows what to do.

Ok. looking at this further. It looks like nghttp2 is trying to be downloaded before xz. Thats not going to work. Here is what part of my dependency list looks like.
unpacking source archive /nix/store/262dmrsf8cnv9h915rasjsp77rwxgf49-nghttp2-0.7.13.tar.xz
/nix/store/18cbyb968m1313sgxfhgyf2cc85fynmi-stdenv-darwin-boot-1/setup: line 500: xz: command not found
do not know how to unpack source archive /nix/store/262dmrsf8cnv9h915rasjsp77rwxgf49-nghttp2-0.7.13.tar.xz
builder for ‘/nix/store/23ss53g8jb0j64yv30d8711gnm05fqpk-libnghttp2-0.7.13.drv’ failed with exit code 1
cannot build derivation ‘/nix/store/8lwp3v6lk673305gqbhrqajcia0daab8-curl-7.42.1.drv’: 1 dependencies couldn't be built
cannot build derivation ‘/nix/store/1c0axs0amcwy672ap1wb4fd5m9l5w1lj-xz-5.2.1.tar.bz2.drv’: 1 dependencies couldn't be built
cannot build derivation ‘/nix/store/zp9fq4m5sqflladgvvn4ky5arf7facxb-xz-5.2.1.drv’: 1 dependencies couldn't be built

@copumpkin: early phases? Why is nghttp2 needed during bootstrapping?

Beats me! It might not be, but early bootstrap phases are the only part of the stdenv that I can think of that don't have xz. Perhaps someone added a different fetch* routine that indirectly uses nghttp2?

The patch 5e3fe391 added libnghttp2 as a dependency to curl. Curl is a dependency for pulling anything down. It seems like this is a boot strapping problem of some sort.
This is not the correct fix, but you can get around this temporarily by removing libnghttp2 from curl/default.nix.

essentially, someone made it an optional dependency of curl. However, if it is in pkgs then it tries to get built, and causes a blowup.

It's used to build curl with http2 support. We can switch it to tar.bz2 for
now, but the bootstrap phases should really support xz as applications have
been moving to xz almost exclusively.
On Wed, May 13, 2015, 10:01 Vladimír Čunát<EMAIL_ADDRESS>wrote:

@copumpkin https://github.com/copumpkin: early phases? Why is nghttp2
needed during bootstrapping?
—
Reply to this email directly or view it on GitHub
https://github.com/NixOS/nixpkgs/issues/7825#issuecomment-101747299.

That's fine, it shouldn't be hard to add xz support to the bootstrap, and the ongoing (white elephant) pure-darwin branch already has it.

I didn't realize this was needed during bootstrap. Just add xz to buildInputs of nghttp then, that's the easiest way.

Well, it's optional but used in all the curl builds now as it provides
support for fetching over http2.
On Wed, May 13, 2015, 10:03 William Kennington<EMAIL_ADDRESS>wrote:

It's used to build curl with http2 support. We can switch it to tar.bz2
for now, but the bootstrap phases should really support xz as applications
have been moving to xz almost exclusively.
On Wed, May 13, 2015, 10:01 Vladimír Čunát<EMAIL_ADDRESS>wrote:

@copumpkin https://github.com/copumpkin: early phases? Why is nghttp2
needed during bootstrapping?
—
Reply to this email directly or view it on GitHub
https://github.com/NixOS/nixpkgs/issues/7825#issuecomment-101747299.

you get a infinite recursion error then @vcunat

Oh, we do that in quite a few expressions for packages involved during bootstrap. So *.bz2 source, I guess, as we probably want http2 in fetchurl.

Fixed in 6516cc48c7082700905d23ab32b28a872fdbfa58
On Wed, May 13, 2015 at 10:08 AM Vladimír Čunát<EMAIL_ADDRESS>wrote:

Oh, we do that in quite a few expressions for packages involved during
bootstrap. So *.bz2 source, I guess, as we probably want http2 in fetchurl.
—
Reply to this email directly or view it on GitHub
https://github.com/NixOS/nixpkgs/issues/7825#issuecomment-101748732.

@wkennington will that cause a mass rebuild?

Well... looks like yes: building for more than 4 min now

@wkennington thats a fix to the symptom but not the underlying problem. That is, that is that, xz should be available earlier in the bootstrapping process. Should we open an issue for that?

Definitely
On Wed, May 13, 2015 at 11:48 AM Eric Merritt<EMAIL_ADDRESS>wrote:

@wkennington https://github.com/wkennington thats a fix to the symptom
but not the underlying problem. That is, that is that, xz should be
available earlier in the bootstrapping process. Should we open an issue for
that?
—
Reply to this email directly or view it on GitHub
https://github.com/NixOS/nixpkgs/issues/7825#issuecomment-101774013.

Fixed by the way

The host (pub.wak.io) for nghttp2-0.7.14.tar.xz in the fix https://github.com/NixOS/nixpkgs/commit/6516cc48c7082700905d23ab32b28a872fdbfa58 is 404'ing. Any ideas of a workaround?

Looks like it's working again...


Support default value of literal 'true'/'false' where paramType='boolean'

Work for this issue will begin begin on branch work-liquid-labs/question-and-answer/90.


Error XFC0000: Cannot resolve type "shades:Shadows"

Sdk version: iOS 11/Android SDK 21
Xamarin.Forms: 4.8+

I installed the NuGet and added a shadow to a label, but got the next compilation error on build:
Error XFC0000: Cannot resolve type "shades:Shadows"
Steps to reproduce the behavior:

Install nuget
Add shadow namespace inside xaml
Add shadow
Try to build
See error

Source of the page:

<?xml version="1.0" encoding="utf-8"?>
<ContentPage
    xmlns="http://xamarin.com/schemas/2014/forms"
    xmlns:x="http://schemas.microsoft.com/winfx/2009/xaml"
    xmlns:shades="http://sharpnado.com"
    x:Class="FailsInShadowsNuget.MainPage">
        <shades:Shadows>

                    <FormattedString>
                        <FormattedString.Spans>

                        </FormattedString.Spans>
                    </FormattedString>

        </shades:Shadows>
</ContentPage>

Cannot replicate your issue

@byme8  xmlns:shades="http://sharpnado.com" - change this to xmlns:shades="clr-namespace:Sharpnado.Shades;assembly=Sharpnado.Shadows"

@themronion @byme8  how do you end up with this issue ?
what IDE are you using ?

@roubachof I didn't even try to reproduce this issue, i just recommended the way i declare your plugin in xamls)

it's the new namespace attribute, it should work this way in the latest version

@themronion, with xmlns:shades="clr-namespace:Sharpnado.Shades;assembly=Sharpnado.Shadows" everything works as expected. Thanks!
@roubachof, I am using Microsoft Visual Studio Community 2019 Version 16.7.6. Also tested on VS For Mac 8.8 and got the same compilation error.

@roubachof

how do you end up with this issue?

I just installed the package and VS resolved namespace as xmlns:shades="http://sharpnado.com". That's all.

Which version of XF please ?

Same for me on version XF <IP_ADDRESS>1 the syntax only shows xmlns:shades="http://sharpnado.com" when implementing in XAML

@dansiegel do you have an idea what is causing this. I could replicate it also. If you add as a nuget package and you add a Shadows you it is fine with the intellisense but you end up with a compile error...

I'm not sure what's causing this, I know that you have your preferred prefix as sho but I tried changing the xmlns to sho and got the same result. It seems very similar to xamarin/xamarin.forms#8451 but I believe that has to do with a project not having been compiled yet which wouldn't quite be the same issue when you're working with a nuget...
Perhaps someone on the Forms team can provide some input here... to me it looks like a problem with XamlC
@redth @StephaneDelcroix @pureween

thanks to @pictos here is the deal:

To consume types from the custom namespace schema, the XAML compiler requires that there's a code reference from the assembly that consumes the types, to the assembly that defines the types. This can be accomplished by adding a class containing an Init method to the assembly that defines the types that will be consumed through XAML:

from: https://docs.microsoft.com/en-us/xamarin/xamarin-forms/xaml/custom-namespace-schemas#consuming-a-custom-namespace-schema
So for the namespace schema to work, you need to call initializer from App.xaml.cs like this:
        public App()
        {
            InitializeComponent();

            Sharpnado.Shades.Initializer.Initialize(false);
            Sharpnado.Tabs.Initializer.Initialize(true, true);
        }

Giving the control a name solved it for me, "x:name" to the shadow control

Yup cause it generates a code reference to the assembly.


[Observation] iOS 10 issue "NSPhotoLibraryUsageDescription"

There is a small observation which prompted me to add this here. The variable adds the required message efficiently but the ios.json file, which cordova makes, has a small error: there is a space after "NSPhotoLibraryUsageDescription" entry. Due to this the build is rejected as the space is added in Info.plist file as it is.
When I made the changes directly in XCode, it was auto corrected by XCode and the build was accepted.

Thanks for pointing this out.  It should be fixed in v1.1.3


⚠ Processors has degraded performance

In 8ee84fb, Processors ($STATUS_URL) experienced degraded performance:

HTTP code: 200
Response time: 70 ms

Resolved: Processors performance has improved in f9c863b.


when to use astx codemod engine?

great work @jedwards1211 here.
which use cases cannot be handled by astx?
have you heard about semgrep? (they have data flow analysis, and built on top of tree-sitter)
also grit.io is building some awesome stuff. their pattern language reminded of your work.
at intuita, we are building a community of codemod champions like you. would love to have you there and exchange notes.
also if interested, we can chat about adding astx support to our codemod.studio (we have visual codemod builder and some LLM helpers to build codemods faster)

But yeah astx was inspired by jscodeshift and is basically intended to be a much easier-to-use version of it.
Another limitation of the API is you can only search for nodes via patterns right now, I need to add a method to get all nodes of a given type (you can then .filter) so no edge cases are more tricky than using JSCodeshift's API.


controlPlaneAuthPolicy not working when using port 15010

Bug description
When I set the discoveryAddress to istiod.istio-system.svc:15010 and set controlPlaneAuthPolicy to NONE, the proxy still uses secure address.
[ ] Docs
[ ] Installation
[X ] Networking
[ ] Performance and Scalability
[ ] Extensions and Telemetry
[ ] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure
[ ] Upgrade
Expected behavior
The non-secure port 15010 can work normally.
Steps to reproduce the bug

edit the istio configmap

$ kubectl edit cm -n istio-system istio
...
  mesh: |-
    accessLogFile: /dev/stdout
    defaultConfig:
      controlPlaneAuthPolicy: NONE
      discoveryAddress: istiod.istio-system.svc:15010
      proxyMetadata:
        DNS_AGENT: ""
...

proxy errors as follows:

...
2020-11-20T09:35:13.753802Z info    xdsproxy    Envoy ADS stream established
2020-11-20T09:35:13.753960Z info    xdsproxy    connecting to upstream XDS server: istiod.istio-system.svc:15010
2020-11-20T09:35:13.757010Z warning envoy main  there is no configured limit to the number of allowed active connections. Set a limit via the runtime key overload.global_downstream_max_connections
2020-11-20T09:35:13.758873Z error   xdsproxy    failed to create upstream grpc client: rpc error: code = Unavailable desc = connection error: desc = "transport: authentication handshake failed: tls: first record does not look like a TLS handshake"
2020-11-20T09:35:13.758924Z info    xdsproxy    disconnected from XDS server: istiod.istio-system.svc:15010
2020-11-20T09:35:13.760584Z warning envoy config    StreamAggregatedResources gRPC config stream closed: 14, connection error: desc = "transport: authentication handshake failed: tls: first record does not look like a TLS handshake"
2020-11-20T09:35:13.891861Z info    xdsproxy    Envoy ADS stream established
2020-11-20T09:35:13.891999Z info    xdsproxy    connecting to upstream XDS server: istiod.istio-system.svc:15010
2020-11-20T09:35:13.897351Z error   xdsproxy    failed to create upstream grpc client: rpc error: code = Unavailable desc = connection error: desc = "transport: authentication handshake failed: tls: first record does not look like a TLS handshake"
2020-11-20T09:35:13.897395Z info    xdsproxy    disconnected from XDS server: istiod.istio-system.svc:15010
2020-11-20T09:35:13.897760Z warning envoy config    StreamAggregatedResources gRPC config stream closed: 14, connection error: desc = "transport: authentication handshake failed: tls: first record does not look like a TLS handshake"
...

Version (include the output of istioctl version --remote and kubectl version --short and helm version if you used Helm)
$ istioctl version --remote
client version: 1.8.0
control plane version: 1.8.0
data plane version: 1.8.0 (8 proxies)

How was Istio installed?
istioctl install --set profile=demo -y

seem same issue: https://github.com/istio/istio/issues/28028

seem same issue: https://github.com/istio/istio/issues/28028

Facing the same issue. I am working with istio version 1.18.2. Replicated the same as above but no luck. Would be great if someone could help.


Schema creation not working in production when used on page

Describe the bug
First of all, thank you for this module, the results (if you get them) are really very well thought out.
Unfortunately, it is not possible for me to achieve a working result in production. When I apply useSchemaOrg to the app.vue file, I get a result that is incomplete without the data that has been added from the pages. If I only use the pages, I get a suitable tag in the head in the end result (the position setting is by the way also ignored in production), but this is not filled and looks faulty:
<script type="application/ld+json" id="schema-org-graph" nodes="[object Object],[object Object],[object Object],[object Object],[object Object]"></script>
In addition, I noticed that something also occurs in development that is possibly related to it and/or is not wanted. The fact is that when I use useSchemaOrg in development both in app.vue and on the pages, I get two application/ld+json tags instead of just one. One of them is the one that is generated inside the app.vue (incomplete) and the other one that is generated in the pages (complete).
Reproduction
Not sure
System Info
Nuxt 3.0.0
nuxt-schema-org 2.0.2

Used Package Manager
yarn
Validations

[X] Follow our Code of Conduct
[X] Read the Contributing Guide.
[X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
[X] Check that this is a concrete bug. For Q&A, please open a GitHub Discussion instead.
[X] The provided reproduction is a minimal reproducible of the bug.

Hey, thanks for the issue.
I've pushed out a new version, 2.0.6. Could you try this and let me know if these problems persists?
If so, would you mind providing some of the code you're using so I can attempt to replicate it, otherwise a stackblitz would be amazing.

Hey, thank you for your quick response and sorry for my late response.
Your updated version definitely removed the duplicate entry. Unfortunately, the one that no longer exists was the right one 😬 What remains, at least for me, is the entry that is generated exclusively from the data in app.vue.
Unfortunately, I had to realize that it is probably a problem that is caused by unknown local influences. I could tell by the fact that a Stackblitz works wonderfully. Based on that, I tried switching off and/or commenting out all possible modules as a test, unfortunately without success, the problem persists.
Unfortunately I can't explain it. It may now fall out of the scheme as a bug, but I would still like to ask if you or someone reading along has an idea where such a problem could come from.

Okay, after some more filtering, I found the culprit. Unfortunately, the data from the pages is not recorded because I use a listener that waits for the page to finish loading and only then releases it via a fade animation triggered by an v-if on the parent, so that its not existing till then. This is probably quite an edge case, but is this something that should be considered to be adjusted?

Thanks for sticking with the investigation, seems like it was an annoying one to debug.
Because this data is needed on the initial server render of the HTML page I think you'd need to re-architect it in a way where you're not blocking the render of the schema / content. This is generally the best practice with working with anything you want to be indexed so I think it's out of the scope of the package.
If you want transition between pages you're better off using the classes provided by vue-router rather than not rendering the content.

I'm trying to understand if I'm facing the same issue...
https://search.google.com/test/rich-results/result?id=UTHSLuE0sAlbE5-CqZnvQw
Nothing detected, but the HTML is correct (has the ld+json, but also the nodes object issue).

This happens even on a completely static page:
<script type="application/ld+json" id="schema-org-graph" data-hid="3437552" nodes="[object Object],[object Object],[object Object]">

You're most likely not using the latest version of Unhead and/or this Nuxt module.
You should check with npm why @unhead/schema-org.
I've created a StackBlitz, please provide a reproduction if you still have issues: https://stackblitz.com/edit/nuxt-starter-z9np1t?file=.gitignore

npm why @unhead/schema-org

npm why @unhead/schema-org
<EMAIL_ADDRESS>node_modules/@unhead/schema-org
<EMAIL_ADDRESS>from the root project
<EMAIL_ADDRESS>from<EMAIL_ADDRESS>  node_modules/nuxt-schema-org
    dev<EMAIL_ADDRESS>from the root project

Yes please use the latest version of the module


can we have some screenshots?

I think that the project homepage would really need some screenshots if is not even possible to have a sample demo page so we would know what to expect.

Bumping this (sorry), but I had just the same idea. I stumbled upon this but have no clue how it looks like, so I'm not going to bother with ruby etc.

Just FYI, I don't think screenshots are forthcoming anytime soon. theunraveler last updated the README in December 2016, indicating a lack of time to maintain the code.

@PCjabber there is a new maintainer now, see #81

Screenshots have been added to the README.  Thank you @Zebradil for putting these together!


Source code pls

Hello unam can u share the silent miner latest source code and latest build link pls? cause i see the repo is removed 😭

You can find it in his comment here.

You can find it in his comment here.

tnx man


[Extensions] Shapes: Errant artifact on retrieval of config tooltip

Current Behavior
https://github.com/meshery/meshery/assets/7570704/164f3922-8a0d-4448-ad3e-e4551416f59c
Desired Behavior
Small dot should not appear.
Environment

Host OS: Mac
Browser: Safari
Meshery Server Version: stable-v0.7.0

Contributor Guides and Handbook

📚 Meshery Build and Release Strategy
🎨 UI Design For Meshery Extensions Figma in Figma (open invite)
📚 Meshery Extensibility Providers
⌨ Meshery API Docs
🙋🏾🙋🏼 Questions: Discussion Forum and Community Slack

@leecalcote while tried to solve this issue, I have come across the similar king to problems in some components.
API

In API gateway of the  black dot is arising,On click event is different not as earlier. The interface which we used to get, getting now on while duplicating the same component.

https://github.com/meshery/meshery/assets/136827623/c59abb6e-a45b-4a72-97ca-3989e391a00a

We get the resize Icon, even after deleting the component.

Same is happening with some stroage components.
https://github.com/meshery/meshery/assets/136827623/6575b1ce-fe50-4091-a54a-d2e09599edc4


android:tag="sticky" is not working on custom layouts using

I built a custom layout for a header.  From my activity layout I am using that custom layout (which is in another xml file).  I am using the layout with
< include
layout="@layout/event_item"
android:id="@+id/eventInfoHeader"
android:layout_gravity="center_horizontal"
android:layout_height="wrap_content"
android:layout_width="match_parent"
android:tag="sticky"
/>
However, it doesn't recognize the sticky.
Note: By wrapping this include layout inside a LinearLayout I was able to set the android:tag="sticky" and it worked.  However, it required this extra step and nested layouts.

I facing the same issue.


Various improvements and bug/style fixes

This checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines

[ ] The PR has modified HISTORY.rst with an appropriate description of the change (see Modifying change log).

Command Guidelines

[ ] Each command and parameter has a meaningful description.
[ ] Each new command has a test.

(see Authoring Command Modules)

/cc @DavidObando


docs(docgen): 📝  use react-docs-typescript

Used react-docgen-typescript !!
I think our current method is more customizable.
Explore futhur here.

Do you need to still look into this @anuraghazra ?

No I've explored this, it does not actually solves our main issue tho, and our current approach is already fine and is also being used for generating other composition,examples,csblink etc etc so i think we can close this for now.

Implemented an alternated approach, hence closing this.

Implemented an alternated approach, hence closing this.


fix(@angular/cli): xi18n --locale option not affecting "source-language" tag

Ah sorry, we've submitted at the same time!
Closing this one since mine (https://github.com/angular/angular-cli/pull/8862) has a better fix + tests, but thanks anyway!


added docstrings and cleaned params

Hello @mikkokotila! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:

In the file icusim/params.py:

Line 28:1: W293 blank line contains whitespace
Line 41:80: E501 line too long (104 > 79 characters)
Line 41:105: W291 trailing whitespace
Line 42:80: E501 line too long (104 > 79 characters)
Line 42:105: W291 trailing whitespace
Line 43:80: E501 line too long (97 > 79 characters)
Line 43:98: W291 trailing whitespace
Line 44:80: E501 line too long (96 > 79 characters)
Line 45:80: E501 line too long (80 > 79 characters)
Line 46:80: E501 line too long (80 > 79 characters)
Line 48:1: W293 blank line contains whitespace
Line 49:1: W293 blank line contains whitespace
Line 59:80: E501 line too long (81 > 79 characters)
Line 62:80: E501 line too long (114 > 79 characters)


Feature request: change z-order of type1000 layers after creating them

Current behavior: the creation of the layer (e.g., overlay_pipe) establishes the z-order of the layer when drawing each layer.
What we would like to do is re-order layers in the event a signal on layer 1 needs to temporarily be displayed ahead of layer 0 (0 and 1 being indices into the layer list).

@btgoodwin how does this API look: https://github.com/LGSInnovations/sigplot/blob/17b1a24ea33e8f607ef1642ef843b9e5a43fbad2/test/tests.js#L4950
If this looks good to you I will merge this onto the mainline.

Thanks, I like that.  @tplumley, FYI as we rebase against the new 2.0 master.
I haven't gone through the code, but what would happen if I set a z-order of 3 and then pushed several layers (such that 0, 1, 2, ...)? Would that next layer end up at zOrder 4, skipping 3 since that one was manually assigned?

Currently you would end up with:
Layer 1 - zOrder 3
Layer 2 - zOrder 1
Layer 3 - zOrder 2
Layer 4 - zOrder 3
But your inquiry brings up a good point.  I'm going to change that so that
new layers are always added on top of all existing layers (i.e. new layers
zOrder = max(zOrder)+1) unless a zOrder was explicitly provided.  I'll
update that tonight and push new changes to this branch.
~Michael
On Fri, May 18, 2018 at 3:52 PM, Thomas Goodwin<EMAIL_ADDRESS>wrote:

Thanks, I like that. @tplumley https://github.com/tplumley, FYI as we
rebase against the new 2.0 master.
I haven't gone through the code, but what would happen if I set a z-order
of 3 and then pushed several layers (such that 0, 1, 2, ...)? Would that
next layer end up at zOrder 4, skipping 3 since that one was manually
assigned?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/LGSInnovations/sigplot/issues/16#issuecomment-390314758,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAOCInvdcI0zDrHufSC2PSzcGvv5-_FBks5tzyaZgaJpZM4R-_qf
.


Button can be quite small

At https://biglittleliferescue.org/donate/ the "Donate Crypto" the button is quite small, why? Do we need size options?

The button is small because:

The html has font-size: 62.5%.
The button <a> and <svg> font sizes are defined using rem which is relative to the html's size.

I couldn't fix the issue by moving from rem to em and setting the button's size to 100%.
The only thing I saw that yields the same results as with html font-size 100%, is using em and adding a font-size of 16px to the button div, but is assuming that the browser's default font is 16px a strong assumption?

@santiher we will move the unit from rem to px to avoid this issue. Also I will add a way to customize the button as we can do with the function createButton so we can override the defaults of the button


feat: Reimplement expr as a class that is understood by IDEs

Related https://github.com/vega/altair/issues/2904
expr

all ConstExpressions are now read-only properties stored in a metaclass
expr subclasses ExprRef, replacing the __call__ w/ __new__

No instances of expr are ever created

All FunctionExpressions are now classmethods
Each Expression can now be referenced in autocomplete, without needing IPython/Jupyter

Docs

Docstrings have been reformatted to be compatible with sphinx
Broken links in docstrings fixed (e.g. for d3)
class-level doc for expr, with references & doctest
Added to API Reference

uses the section heading proposed in https://github.com/vega/altair/pull/3427#discussion_r1659965947

Demo

Current (IPython)
https://github.com/vega/altair/assets/125183946/8ac49a65-c6cd-4e25-9d65-632253fa0b15
Current (Static)
https://github.com/vega/altair/assets/125183946/ad30bba5-e126-41b8-910b-dc8b922ff896
Proposed (Static)
https://github.com/vega/altair/assets/125183946/3f65d5d5-a006-421e-8037-a3dbfa7d796e
Proposed (API Reference)

All tests are passing now 😀
I hope the recordings/screenshots are useful. I thought they would be clearer to understand than listing all the benefits this could have.
Happy to clarify anything if you have any questions

Hi @dangotbanned, thanks for this PR and apologies that no one has gotten back to you on it yet. This looks like a really nice quality of life improvement, and is very in line with my desire to promote the use of the expression API over using expression strings.
I'll try to get to reviewing and playing with this later in the week if no one else gets to it faster

Hi @dangotbanned, thanks for this PR and apologies that no one has gotten back to you on it yet. This looks like a really nice quality of life improvement, and is very in line with my desire to promote the use of the expression API over using expression strings.
I'll try to get to reviewing and playing with this later in the week if no one else gets to it faster

Can only second Jon's statement. Looks like a big UX improvement 🥳  but I struggle to find the time to review it. If you Jon get to it, that would be awesome! Thank you both :)

This is an awesome improvement @dangotbanned. I like the architecture, just wondering if you have thoughts on reducing the duplication of function/constant specifications between the new class methods and the current FUNCTION_LISTING and CONST_LISTING dictionaries. I think the latter are only referenced in tests now, and it would be nice to remove them so that we don't risk them getting out of sync with the class methods.
Since we don't autogenerate these definitions right now, I want to go through the functions one-by-one before merging, and I'll do this later today or over the weekend.
Not to address in this PR, but it would be nice to eventually be able to auto-generate these function definitions, but it looks like they aren't included in the Vega or Vega-Lite jsonschema definitions, so we would need to pull them directly from the Vega repo or something.

Thanks @jonmmease

This is an awesome improvement @dangotbanned. I like the architecture, just wondering if you have thoughts on reducing the duplication of function/constant specifications between the new class methods and the current FUNCTION_LISTING and CONST_LISTING dictionaries. I think the latter are only referenced in tests now, and it would be nice to remove them so that we don't risk them getting out of sync with the class methods.

Yeah I considered this and would +1 for removing them.
I was trying to make this a drop-in replacement, as I imagined it would be easier to get merged.
The related changes I'd like to see here are:

Remove expr.[funcs|consts].py modules entirely
Rewrite the tests iterate over wherever @classmethods are stored
I was going to suggest removing the doc attribute, but it looks like I already did that in altair/expr/funcs.py 😅

Since we don't autogenerate these definitions right now, I want to go through the functions one-by-one before merging, and I'll do this later today or over the weekend.

Good luck! There is a lot to read.
I think some were out of sync with the current descriptions, so I updated those that I spotted.
You may also notice markup changes I had to make - to keep sphinx happy - which would be a consideration if this were autogenerated.
Although IIRC tools/.. has some handling for this already, so maybe not an issue.

Not to address in this PR, but it would be nice to eventually be able to auto-generate these function definitions, but it looks like they aren't included in the Vega or Vega-Lite jsonschema definitions, so we would need to pull them directly from the Vega repo or something.

Yeah I looked into that as well and I couldn't see a clean way of doing so, but maybe someone more familiar with vega/vega-lite could?
They're all defined in one place here https://vega.github.io/vega/docs/expressions/
But the actual source seems to be files like:

https://github.com/vega/vega/blob/main/packages/vega-functions/src/codegen.js
https://github.com/vega/vega/blob/main/packages/vega-expression/src/functions.js
https://github.com/vega/vega/blob/main/packages/vega-expression/src/constants.js

This is an awesome improvement @dangotbanned. I like the architecture, just wondering if you have thoughts on reducing the duplication of function/constant specifications between the new class methods and the current FUNCTION_LISTING and CONST_LISTING dictionaries. I think the latter are only referenced in tests now, and it would be nice to remove them so that we don't risk them getting out of sync with the class methods.

@jonmmease all done on that front 👍
I'll hold of on my suggestion to remove, but this can now be done at any point in the future
@dangotbanned

The related changes I'd like to see here are:
Remove expr.[funcs|consts].py modules entirely

lgtm!

Thanks @jonmmease
FYI I'm working on a fix for the mypy issue that appeared on merging - will be in a new PR

https://github.com/vega/altair/pull/3485#issuecomment-2240051547
https://github.com/vega/altair/actions/runs/10020215927/job/27697611769

FYI I'm working on a fix for the mypy issue that appeared on merging

Thanks!

FYI I'm working on a fix for the mypy issue that appeared on merging

Thanks!

@jonmmease

https://github.com/vega/altair/pull/3487

Is ready and would be able to close https://github.com/vega/altair/pull/3485 once merged
Thank you again for reviewing


Release new version?

The current released version v0.13.4 dates from Nov '22 and since then over 100 commits to master have been done..
So I'm wondering if (and when) it becomes time to publish a new release?

@Hipska After smaller time new relase is planned.

@msaf1980 What do you mean with that?

Hey @msaf1980 👋  Any update on an expected release time please? :) Very interested in a fix for https://github.com/go-graphite/graphite-clickhouse/issues/178

Seems like a new version is in the making: #289

Released v0.14.0


[doc] Update artifact matrix

Update the artifact matrix here, especially for apollo-mockserver (see https://github.com/apollographql/apollo-kotlin/issues/5456)

✅


Implement process scanning support for *BSD

Mhm, I don't seem to be able to re-open #786, so here's a new PR. It really has been tested on FreeBSD 11.1-RELEASE (amd64).

I have successfully tested on OpenBSD 6.2 and NetBSD 7.1.


chore(ci): test check for content

closing since this is a POC of https://github.com/googleapis/synthtool/pull/776


Device and Rack

Would it be possible to not have rack position on a site as mandatory when you add a device to a site ?
usecase.
We want to see if we can use this great system as a documentation system for sites and equipment where no actual racks exists.
I know you could create a dummy rack that you place in the site, but it would be easier if you could skip that part.

Duplicate of #198


Error in new version(worker, core);

Hello,
I am a developer who has been creating and using the Nexrender project for the past three years. First of all, thank you for creating such a great program.
The problem is that after updating the code to the latest version, there are errors occurring in the existing JSX script. The same script works without any issues on version 1.3x.x, but after updating to the latest version, it throws a "path is not valid" error and rendering fails.
I will attach the commands I used and the error messages below. Thank you.
Here are the things I have tried:
Deleting everything and updating all related dependencies from scratch
Updating each component separately
Path encoding

I see there are some unexpected symbols around the file path which is printed in the error message from AE, is there any chance that path contains some Unicode or something like that?

There is no such possibility because I have tried encoding everything and changed the folder names several times.


Docs: First pass of README preparing for beta

Just putting this here for now - preparing a README for the beta release.
Based on discussion with Naomi, starting with the README from xmtp.js and we can pare down and adjust as necessary.

I added a bunch of comments on here and then figured it would probably just be easiest if I made the changes myself so commit incoming.

Somehow this got in a weird git state so lets close this in favor of https://github.com/xmtp/xmtp-react-native/pull/76


listener functions don't HAVE to be functions

they could also be objects with the handleEvent method defined on their prototype chain.  This check is prevents a consumer of this lib from passing an object to addEventListener.

Thank you for this issue.
Is you meaning that
typeof listener === "object" && typeof listener.handleEvent === "function"

should be allowed?

Yeah, I verified.

I'm sorry, I hadn't noticed that.
I will fix that.


Feat: Added dark theme toggle  #15

@yyjlincoln  and I have worked together on this PR. In this, we have added a toggle button that gives 3 options light mode, dark mode, and auto which displays according to the system preference.
A glimpse of our work: Demo Credit goes to @yyjlincoln for this!
Features:

The support of auto|light|dark

Smooth transition between states

No eye-blinding flash when switching pages

When set to auto, it can listen to your phone's dark mode events and adjust its color scheme automatically

Written in vanilla javascript, no additional libraries are used

Flexible/modular design with functions such as beforeModeChange and afterModeChange, meaning that you can easily add more functionality to it.

[X] My Pod Leader knows I'm working on this Pull Request

[X] I've explained what the Pull Request is adding.

[X] I've explained why this is important.

This pull request closes #15

Closing this PR as we will need to merge another commit.

Hey, why did you close this?

Hey, I've cleaned up some files which created another commit, meaning that this PR is no longer up to date. I'm also migrating all commits to the main repo - check your discord msg @Aniket762

I will be migrating our commits through #22, and then I will open another PR with reference to the latest commit soon.

#23


Add event-list mixin

Hey @shahj14 I'm making this a  PR and requesting your review because I noticed the event-box css class wasn't actually defined anywhere - but in doing this it didn't make sense to have a meeting-box and event-box style. So, I made meeting-box event-box and just use that - but more importantly, is there anything missing that you intended to be in event-box? I know we could be using imported styles from bootstrap but I doubt they have one called event-box?

Closes #42


[CI SKIP]Updated CHANGELOG.md

Closed this PR that I created from web UI as it is having issues resolving my CLA.


Webworkify + Uglify-js + Require.js not getting along

Hi, I'm trying to load up a browserify --standalone bundle that includes webworkify that been minified with uglifyjs using the --mangle and --compress options in Require.js.
Problem
Require.js fails to load the bundle:

Reproducible example
See https://gist.github.com/etpinard/8ec2c29210d5adee049d54bb427bbbe6
Observations
This line seems to be causing the issue when compressed by uglifyjs
Replacing
'var f = require(' + stringify(wkey) + ');' +
'(f.default ? f.default : f)(self);'

by
'var f = require('+stringify(wkey)+');' +
'(f.default ? f.default : f)(self);'

and running browserify and uglifyjs without the --compress option is enough to replicate the problem listed above.

I'm really puzzled by this. Why would adding spaces around + sings in webworkify code affect things in any way?

This one is definitively strange. It may be a bug with Require.js itself?

@etpinard would you mind checking if the same thing happens in https://github.com/substack/webworkify/pull/31? Just in case.

I get the same Require.js error using off mourner:no-eval .

This commit https://github.com/substack/webworkify/commit/31c27effcdc2db8378ab3b3e3fcdab649b912197 appear to fix this issue.

@etpinard but why?

Since this seems like a require+uglify bug, should we close this issue and wait for upstream fixes?

Since this seems like a require+uglify bug

I believe this is a Require.js bug, but I haven't had the time to investigate further.
For our needs, I was able to fix this issue using a dirty string .replace here and test it here. So you can close this issue if you like.
Thanks for your time.


Error in record

I tried using the record functionality but I am getting the following error. I got the same error for regardless of the benchmark.
INFO     Setting up target
INFO     Deploying gfxbench
.
.
.
INFO     Press Enter when you have finished recording TEARDOWN...

INFO     Pulling 'lahaina.teardown.revent' from device
INFO     Tearing down gfxbench
ERROR      File "/usr/local/lib/python3.10/dist-packages/wlauto-3.4.0.dev1+bf72a576-py3.10.egg/wa/framework/entrypoint.py", line 149, in main
ERROR        sys.exit(command.execute(config, args))
ERROR      File "/usr/local/lib/python3.10/dist-packages/wlauto-3.4.0.dev1+bf72a576-py3.10.egg/wa/commands/revent.py", line 129, in execute
ERROR        self.workload_record(args)
ERROR      File "/usr/local/lib/python3.10/dist-packages/wlauto-3.4.0.dev1+bf72a576-py3.10.egg/wa/commands/revent.py", line 219, in workload_record
ERROR        workload.teardown(context)
ERROR      File "/usr/local/lib/python3.10/dist-packages/wlauto-3.4.0.dev1+bf72a576-py3.10.egg/wa/framework/workload.py", line 364, in teardown
ERROR        self.gui.teardown()
ERROR      File "/usr/local/lib/python3.10/dist-packages/wlauto-3.4.0.dev1+bf72a576-py3.10.egg/wa/framework/workload.py", line 568, in teardown
ERROR        raise RuntimeError('Commands have not been initialized')
ERROR
ERROR    RuntimeError(Commands have not been initialized)

This happens after I press enter to finish recording the teardown stage. I am using the following command to run it.
wa record -a -w gfxbench
I am using the latest version.
wlauto-3.4.0.dev1+bf72a576-py3.10.egg

Hi, The revent recording mechanism was designed to run with game workloads (e.g. templerun, angrybirds) as it is not possible to automate then with UIAutomator.
The benchmark workloads e.g. gfxbench are implemented with UIAutomator as it allows for more reliable and repeatable runs.
Are you able to use the existing configuration of the workloads to execute the required tests rather than relying on revent?

I was looking into having more flexibility in terms of the executed sub-benchmarks. For example, Geekbench supports only the CPU option and GFXBench has by default a subset of all sub-benchmarks. Implementing selecting Compute as well is not as straightforward as I expected*, so I was trying to find a solution via the record-replay route.

I get errors while using UIAutomatorViewer so I have no idea the names and types of the various UI elements of the applications.

Any suggestions for broadening the options of selecting sub-benchmarks? Is there a directory/website with other people's implementations (e.g., Geekbench with Compute)?

Hmm.. I see, the main problem I see with using revent for this is that you will not have a way to extract the scores from the workload results as that can only play back inputs and cannot react to screen elements and wait for the tests to complete, detect results etc.
What errors do you face when trying to use uiautomator? Are you having problems with just the benchmark or obtaining any captures from your device?

I don't care about recording the benchmark-specific scores so that's not an issue. I'm interested in only running the benchmarks.
Regarding UIAutomatorViewer. This is the error I get while trying to capture a device screenshot (UI XML Snapshot).
Unexpected error while obtaining UI hierarchy
java.lang.reflect.InvocationTargetException

Are you having problems with just the benchmark or obtaining any captures from your device?

What exactly do you mean by that? UIAutomator scripts run fine.
In general, I'm interested in using a profiler tool (Snapdragon Profiler or ARM Streamline) to collect device data while automating the running of various benchmarks (and sub-benchmarks).

You can change what GFXBench subtests are running here: https://github.com/ARM-software/workload-automation/blob/master/wa/workloads/gfxbench/init.py#L41

Thanks for the heads up.

I found that the UiAutomatorViewer stopped working if my Android Tools were outdated by the device. Have you tried updating your tools?

Yeah. Unfortunately, I still get an error.

Yeah. Unfortunately, I still get an error.

I would be tempted to suggest doing a clean install of the latest available android tools and SDK just to check that an older version is not being picked up somehow and still causing the error.
Or worst case scenario you could always take a ux dump on the device manually and open the resultant files in uiautomator. (screencap -p > /sdcard/ui_dump.png && uiautomator dump)

I don't care about recording the benchmark-specific scores so that's not an issue. I'm interested in only running the benchmarks.

I would suggest trying to get the UIAutomator approach to work first however as a workaround, one option would be to create a new Revent version of the workload which would allow the use of the record commands. Although you would still encounter the limitations of revent i.e. only being able to measure for a fixed amount of time rather than being able to detect when a test has completed as the timings of the benchmark / revent playback may not be consistent across runs etc.
To create a new revent workload we have the following command to help with this [1]
wa create workload -k apkrevent gfxbench_revent

This will generate a workload file for you which can then be modified to add the appropriate package name (which can be taken from the existing workload) and parameters (if required).
This will allow WA to auto launch the application and you to use the record command as initially attempted.
[1] https://workload-automation.readthedocs.io/en/latest/developer_information.html#adding-a-reventapk-workload


[Bug] Multiple options with different label but same value stopped working

Having multiple options with same value in a dropdown widget used to show all the labels that have the same value, as different options in the dropdown. However, this stopped working recently and we only see a single option in the dropdown.

@sharat87 what is the expected behaviour? I think removing the duplicate option is the right behaviour.

@somangshu it's not exactly a duplicate option right? The label is a human-readable, user-friendly piece of text. But the value is for machine consumption. So it's possible to have cases where we want to show multiple different options to the user, for APIs powering it, they probably just need the value. If the APIs need to differentiate further, they can use .selectedLabel just as well.
Additionally, I also think allowing this would mean adding synonym options with the same value to improve finding items in the filter.
Nonetheless, apparently this was working previously and only started dropping the duplicate options in the latest (or last to latest) release. So it's breaking apps. :|

Actually, this should be a validation error right? @somangshu

@Nikhil-Nandagopal we can do that, But @sharat87 is talking about this being a valid case and old apps making use of this.
@sharat87 correct me if I am wrong!

Yeah I misunderstood when sharat shared this as well. I thought both labels were the same. This isn't valid

@somangshu, yep, correct.
@Nikhil-Nandagopal, I'm not sure I follow. The labels are different, but the value is same. Is such use case going to be invalid?

@sharat87 no value is meant to be unique in the dropdown

Alright. This is a change in behavior for the dropdown widget then.
Closing as won't fix.

@sharadagg thank you for explaining your use case. There needs to be a unique id to identify the selection in the dropdown, hence the value field is used for this. Since price is not unique, you can use the itemId for the value and then look up the price from your data based on the Id that is selected. Does that make sense?


Remove communication chat which failed the CI job

https://apidrop.visualstudio.com/Content CI/_build/results?buildId=194812&view=logs&j=fd490c07-0b22-5182-fac9-6d67fe1e939b&t=a04569be-1b08-5c9a-7e65-a83076350a0c

Docs Build status updates of commit 4b40e73:
:x: Validation status: errors
Please follow instructions here which may help to resolve issue.

File
Status
Preview URL
Details

:x:Error

Details

[Error-PullRequestMergeConflict] Cannot sync git repo to specified state. Please make sure the pull request is mergeable.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel

Docs Build status updates of commit 3ca758d:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs-ref-mapping/reference-unified.yml
:white_check_mark:Succeeded

package.json
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel


RayHadler initialization exception

Hi
I have a little problem. When I upgrade gdxVection from 1.9.13 to 1.9.14 I got this error:
org.lwjgl.opengl.OpenGLException: Cannot use offsets when Pixel Unpack Buffer Object is disabled
by invoking RayHandler(world)
I try to run the desktop application.

This is a libgdx problem, and was solved in 1.9.15-SNAPSHOT. Downgrade to 1.9.13 and wait for the 1.9.15 release or use the 1.9.15-SANSPHOT

Thank you for fast response. Thanks


Add http head requests

What's Changed:
Adds the ability to send and process HTTP HEAD requests.
Type of Change:

[ ] Bug fix
[ X ] New feature
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Housekeeping:

[ X ] Tests have been updated to reflect the changes done within this PR (if applicable).
[ X ] Documentation has been updated to reflect the changes done within this PR (if applicable).

Screenshots (If Applicable):

All set. Thanks!

Thanks for this!


Train on a new language static/tuned embeddings

Hi,
thank you for your great software and initial instructions for training on a new language. I am currently stuck at the step "Find a set of pre-trained word vectors in your language". The unmodified training scripts require the files in the weights directory, they load static/tuned English embeddings. Could you elaborate how these files can  be replaced with other embeddings (e.g. fasttext)? How are the tuned embeddings produced?
Are the other weight files also required for training (and also English specific)?
Many thanks in advance!

Good question,
I would like to know also. The instruction now is quite vague to me especially the static/tuned embeddings. I'm training the neuralcoref on a new language (Dutch) using the SoNar dataset. I only have the Dutch static word embedding and have no idea what the tuned embeddings is. Would be nice if you guys can share some info or a quick tip about these.
Many thanks in advance!


Swift Perfect

Progress

[x] 🏁 Fork the starter repo & post the link in this issue

[ ] 🎨 Create logo for repo & update issue status (@EricSimons)

[ ] 🔨 Implement all of Conduit's functionality per the spec & API

[ ] 👀 Move repo to main org & Peer review final codebase by admins/community (RFC)

[ ]  🎉 Tag v1 release and officially list it on the README!

Current Status
Codebase (in progress):
https://github.com/alex-kostirin/swift-perfect-realworld-example-app

Hello we are currently moving all work in progress to Github Discussions.
I'll close this issue by now, you can find instruction to open a discussion there : https://github.com/gothinkster/realworld/discussions/633
Thanks for your contribution !


[SPARK-45372][CORE] Handle ClassNotFoundException when load extension

What changes were proposed in this pull request?
Skip extension load when ClassNotFoundException encountered and log error
Why are the changes needed?
When load extension with ClassNotFoundException, SparkContext failed to initialize. Better behavior is skip this extension and log error without failing SparkContext initialization.
Does this PR introduce any user-facing change?
No
How was this patch tested?
Added UT in UtilsSuite.scala
Was this patch authored or co-authored using generative AI tooling?
No

Agree with @JoshRosen's comment - for example, these could be sql extensions or shuffle components - it is preferable to fail the application than to ignore the class loading error: users can fix the failure by making appropriate config or dependency changes.


[NUTs] Cashu NUTs - Notation, Usage, and Terminology

Totally NUTs

[x] move NUTs to own repo
[x] List NUT support for each wallet and mint
[ ] Specify a "mandatory" and "optional" tag for each NUT
[ ] NUT for cashu: URI
[ ] NUT for tok1x<JSON_b64> prefixes for token versioning
[ ] NUT for BDHKE
[ ] NUT for P2SH
[ ] NUT for wallet multimint support
[ ] NUT for transferring tokens from mint1 to mint2
[ ] NUT for /info mint endpoint
[ ] NUT for comment field in token
[ ] NUT for sender information in token

Cashu NUTs have been moved to https://github.com/cashubtc/nuts


[Bug]  wiki is gone？

Verify steps

[X] Is this something you can debug and fix? Send a pull request! Bug fixes and documentation fixes are welcome.
[X] I have read the Wiki, especially the FAQ page.
[X] I have searched on the issue tracker for a related issue.

JavTube Plugin Version
x
JavTube Server Version
x
What OS are you seeing the problem on?
No response
Description
what is happened with wiki and other help pages ？these are helpful for me，i really need these user guide
JavTube Server
No response
Jellyfin/Emby Logs
No response
JavTube Server Logs
No response
How to Reproduce
No response

Fixed

its gone now again.

Fixed

it's gone again.


how to highlight with regex

can you explain how to highlight with regular expression.

I was exploring this library and saw this question. Untested, but I would assume that if you wanted to highlight all digits /\d/ for example, you would put:
(...
computed: {
  segments() {
    return [...this.text.matchAll(/\d+/g)].map(m => ({
      start: m.index,
      end: m.index + m[0].length,
      tag: { class: "blue" }
    }))
  }
}


Cannot build against 4.3.0

820433ed2ff52993f69c055b0d6bbd0d8302986e needs to be reverted temporarily, as long as we need to continue to build against 4.3.0

Hmm. That doesn't sound like a bad idea, but it's possible there may never be a difference between the main branch and the 43s branch.

Well, to be clear, I'm proposing a 4-3-0-stable (emphasis on the 0; not 4-3-stable). We already have a difference documented here in the "temporary" nature of the revert. The plugin builds against 4.3.1/main as-is, I understand it, so this branch would just exist for the 4.3.0.x release. Without that branch, we would need to revert the revert after the <IP_ADDRESS> tag is pushed and if for whatever reason we need a <IP_ADDRESS> we would need to do it again. But that seems unlikely

I missed the 4-3-0-stable.
I see now. A new branch is fine.

Since <IP_ADDRESS> will be released from the 4-3-0-stable branch, we don't need to revert the revert anymore. The changes in #117/#118 fixed the build against iRODS 4.3.0. Closing.


Match daily build with pull_request build

Purpose

$subject.

Codecov Report

Merging #23763 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #23763   +/-   ##
=======================================
  Coverage   14.59%   14.59%
=======================================
  Files          51       51
  Lines        1411     1411
  Branches      219      219
=======================================
  Hits          206      206
  Misses       1189     1189
  Partials       16       16

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 00fbf3d...abfcfb7. Read the comment docs.


⚠ Samsung has degraded performance

In 234c1d0, Samsung (https://samsung.com) experienced degraded performance:

HTTP code: 200
Response time: 2642 ms

Resolved: Samsung performance has improved in b212754.


editor: count CJK characters

As there are no natural divisions between words in Chinese and Japanese, the word-count module used by Ghost cannot correctly count the CJK characters. This commits adds a new module cjk-character-count to extract all CJK characters from the editor using XRegExp and display the number of them beside the words label. If no CJK character is found, nothing will be added to the editor.
Before: (should be 7)

After:

After(no CJK characters):

But I do not know why Travis fails on this. Do I need to define the new helper somewhere?

anybody here?

Hey @PeterCxy! Thanks for contributing!
While this looks good from a code standpoint (although tests might be good :wink:), I'm not sure whether this is something that should be added at the moment, for a couple of reasons.

Although this helper doesn't output anything when there are no CJK characters present, it adds something to the codebase that only has a very small use case (not to discount its use case though, just thinking of the number of people who use it) - This alone isnt the reason though.
@kevinansfield is currently working on a completely new editor that drastically changes the way the editor functions. With the new editor, the idea is to add the ability for people to drop in specific "cards" or rather, different types of content (video, markdown, html, etc.) IMO, this is something better out there, and as the editor itself is in a state of flux, this probably would have to be changed/removed anyways before it even got used.
3 (not sure it applies). There is currently a move to work on il8n in the admin client. It seems like this is something that could also go with that effort?

@acburdine Thanks for your reply.

I don't think the use case is much of a problem. While I do not know much about the situation in Japan and Korea, there is now even a ghost-china website that translates every major release of Ghost and some of your official blog posts to Chinese. As can see from their forum ghost-china-forum, there should be a considerable number of people using Ghost and in need of this feature.
I have heard of that change from your update log. However, when I was working on this helper, I didn't find any code about the new editor in the lab. May I "preview" the code and adapt this helper for it?
I have read the issue about i18n, but I don't think there is a better solution. You know, even in MS Word, Aisan characters are seperately counted from Latin characters, as it is difficult to determine which language is the text in (and in many cases, articles in CJK contain some of Latin words). But I agree that adding a panel (or card) specially for displaying word count should be better. However, I am also waiting for the change in editor.

Okay that makes sense. I'd still advise waiting until the new editor. As for building it into a card, I'd also advise waiting because the new editor doesn't exist in master yet (you can follow the changes in #6255)

Then I am going to close this. I will wait for the new editor and then re-open one if still needed.


Stop deleting dist when we don't have to

Irritatingly, the dist folder gets deleted every time you run pack in dev mode even though the dev mode runs the code entirely out of memory and does not even use the on-disk dist folder.  This pull request will only delete it if you are in production mode.

I like it, thanks for the contribution!