DP-1833 First draft of the catalogue library (python 3.10)

https://github.com/ministryofjustice/data-platform/issues/1833
This PR introduces a class for interacting with the data catalogue (OpenMetadata). This is meant to be a wrapper around the OpenMetadata SDK to simplify the integration and abstract away implementation details that would change if we switched to another catalogue.
The goals of this PR is to prove that we can actually get data into the catalogue, and get some initial feedback on the proposed API.
I've based a lot of this on this guide: https://docs.open-metadata.org/v1.1.x/sdk/python
After this I will need to

create a workflow to deploy to Pypi
ensure that we can pass through all the metadata we currently have in our JSON schemas
implement deletion methods

Caveats

This does not yet support 3.11 because the OpenMetadata SDK doesn't support it. However, I asked on the slack and they said it will be fixed in upcoming releases. I suggest we temporarily downgrade lambdas to 3.10 until this is resolved.

Open questions

I'm not sure what I should be passing for the connection configuration when creating the database service. I used CustomDatabase for now as it doesn't require any special credentials.
It's possible to pass a GlueConnection here, but that means that OpenMetadata will need AWS credentials for accessing Glue databases. I didn't go down this route as it seems like it's more complicated and goes against the plan of controlling the ingestion externally via the data platform's ingestion API.
Note: we might not even need to manage services via this library at all. Since there is only one, we can just set it up in OpenMetadata directly. We will just need the lambdas to know the name of the service that is connected to the glue catalogue we're putting everything in.

Does the way I've described the hierarchy make sense? I'm assuming we can group everything under one service, and have 1 database and 1 schema per data product.

I'm not sure yet how owner metadata will work - can we assume that the data producer will be added as a user to the catalogue at the time when we grant them API access? Or should we add extra methods to add users through this library?
Working assumption:  Creating users is out of scope for this ticket, and will be looked at as part of onboarding. The owner user existing in OpenMetadata should be a prerequisite of using the API to register a data product.

In case we need it later, here is an example of creating a service with the glue connector instead of custom database:
    credentials = AWSCredentials(
        awsRegion="eu-west-1",
        awsAccessKeyId=aws_access_key,
        awsSecretAccessKey=secret_key,
        awsSessionToken=session_token,
    )

    create_service = CreateDatabaseServiceRequest(
        name="mat-test-database-service",
        serviceType=DatabaseServiceType.Glue,
        connection=DatabaseConnection(
            config=GlueConnection(
                awsConfig=credentials, databaseName="example_prison_data_product"
            )
        ),
    )

This change covers syncing of data from the ingestion component to the catalogue. However, @tom-webber pointed out that it is possible for data owners to update descriptions, owners etc. in OpenMetadata as well, which would imply a flow of metadata in the other direction as well.
If we configure the database service with a Glue connection, then OpenMetadata is able to update the Glue catalogue, but this wouldn't automatically update the schema/metadata files in s3, which is what we are currently considering the source of truth.
Syncing data in 2 directions is complex and error prone, so we would like to avoid this if possible. But it would also be nice if users could make use of OpenMetadata's built-in governance functionality, rather than forcing all updates to go via our API.
This problem would go away if we used OpenMetadata as our entity store, and got rid of the metadata bucket, but we're reluctant to do this in alpha as this will tightly couple the solution to OpenMetadata.

Database topology

creating users - For now users can be created manually. We can liaise with the app/tools team about what is plan to populate users .
E   pydantic.error_wrappers.ValidationError: 1 validation error for GlueConnection
E   awsConfig
E     field required (type=value_error.missing)

It's marked as required in this schema: https://github.com/open-metadata/OpenMetadata/blob/main/openmetadata-spec/src/main/resources/json/schema/entity/services/connections/database/glueConnection.json#L49

Can you please if you can create a connection using the auth token rather than AWS credentials

Currently the scope of the ticket is to send data to Openmetadata endpoint. we dont have to connect to glue Database in AWS account.

Possiblility for data owners to update descriptions -> resync, is out of scope of for Alpha. Again we can have discussions with apps and tools team to decide how to implement it. @julialawrence @jacobwoffenden

After some experimentation, this works:
{"name": "dp-glue3", "displayName": "data platform glue catalogue test3", "description": null, "tags": null, "serviceType": "Glue", "connection": {"config": {}}}

This doesn't:
{"name": "dp-glue4", "displayName": "data platform glue catalogue test3", "description": null, "tags": null, "serviceType": "Glue", "connection": {"config": null}}

->
{
	"code": 400,
	"message": "InvalidServiceConnectionException for service [Glue] due to [Failed to encrypt connection instance of Glue]."
}

Unfortunately, the code
        create_service = CreateDatabaseServiceRequest(
            name=name,
            displayName=display_name,
            serviceType=DatabaseServiceType.Glue,
            connection=DatabaseConnection(),
        )

generates the version with connection: null.

LGTM


Replace EncryptedSerializedCredential with EncryptedData

Previously, EncryptedSerializedCredential was a wrapper for trussed::api::reply::Encrypt.  As we whave removed the serde trait implementations for the Trussed request and reply structs, this patch replaces the EncryptedSerializedCredential struct with the new trussed_core::types::EncryptedData helper type.
See also: https://github.com/trussed-dev/trussed/issues/183

Updated to use the trussed_core::types::EncryptedData helper.


Semicolon, comma and parenthesis alignment issues

Test case
Actual output
    wire [MIG_ADDR_WIDTH-1:0] weight_addr_start;
    wire [MIG_ADDR_WIDTH-1:0] weight_addr_end;
    wire [MIG_ADDR_WIDTH-1:0] ddr_addr_start;
    wire [MIG_ADDR_WIDTH-1:0] ddr_addr_end;
    wire [              31:0] remove;
    wire [              31:0] offset;
    wire [              31:0] weight_len;
    wire [              31:0] neuron_num_in_layer;

Include any possible diagnostic messages from the formatter.
Expected or suggested output
    wire [MIG_ADDR_WIDTH-1:0] weight_addr_start     ;
    wire [MIG_ADDR_WIDTH-1:0] weight_addr_end       ;
    wire [MIG_ADDR_WIDTH-1:0] ddr_addr_start        ;
    wire [MIG_ADDR_WIDTH-1:0] ddr_addr_end          ;
    wire [              31:0] remove                ;
    wire [              31:0] offset                ;
    wire [              31:0] weight_len            ;
    wire [              31:0] neuron_num_in_layer   ;

the same with ) and ,
Expected or suggested output
    generate_ddr_addr #(
        .FLOAT_LEN        (FLOAT_LEN        ),
        .MIG_DATA_WIDTH   (MIG_DATA_WIDTH   ),
        .MIG_ADDR_WIDTH   (MIG_ADDR_WIDTH   ),
        .LAYER0_NEURON_NUM(LAYER0_NEURON_NUM),
        .LAYER1_NEURON_NUM(LAYER1_NEURON_NUM),
        .LAYER2_NEURON_NUM(LAYER2_NEURON_NUM),
        .LAYER3_NEURON_NUM(LAYER3_NEURON_NUM),
        .LAYER4_NEURON_NUM(LAYER4_NEURON_NUM),
        .MAX_WEIGHT_NUM   (MAX_WEIGHT_NUM   )
    )

This may seem strange, but in some cases (such as instantiating modules) it works quite well, do we have the relevant configuration parameters to support this effect?

I have not seen a request to align semicolons yet, but might be something that could probably be added and made configurable.
(Configuration of options in general can be done with flags. There are often different choices per flag.
https://github.com/chipsalliance/verible/tree/master/verilog/tools/formatter#systemverilog-formatter
)
As for your observation 'sometimes it works': there is a heuristic in the formatter that attempts to determine what desired indentation is wanted (you see this in the flags if the style is set to infer). That typically means that the formatter looks at the surroundings (e.g. an unusual indentation of more than one space) to infer what particular formatting was "meant". That of course does not work always, in particular if you feed a differently formatted file.

Test case
Actual output
    wire [MIG_ADDR_WIDTH-1:0] weight_addr_start;
    wire [MIG_ADDR_WIDTH-1:0] weight_addr_end;
    wire [MIG_ADDR_WIDTH-1:0] ddr_addr_start;
    wire [MIG_ADDR_WIDTH-1:0] ddr_addr_end;
    wire [              31:0] remove;
    wire [              31:0] offset;
    wire [              31:0] weight_len;
    wire [              31:0] neuron_num_in_layer;

Include any possible diagnostic messages from the formatter.
Expected or suggested output
    wire [MIG_ADDR_WIDTH-1:0] weight_addr_start     ;
    wire [MIG_ADDR_WIDTH-1:0] weight_addr_end       ;
    wire [MIG_ADDR_WIDTH-1:0] ddr_addr_start        ;
    wire [MIG_ADDR_WIDTH-1:0] ddr_addr_end          ;
    wire [              31:0] remove                ;
    wire [              31:0] offset                ;
    wire [              31:0] weight_len            ;
    wire [              31:0] neuron_num_in_layer   ;

the same with ) and , Expected or suggested output
    generate_ddr_addr #(
        .FLOAT_LEN        (FLOAT_LEN        ),
        .MIG_DATA_WIDTH   (MIG_DATA_WIDTH   ),
        .MIG_ADDR_WIDTH   (MIG_ADDR_WIDTH   ),
        .LAYER0_NEURON_NUM(LAYER0_NEURON_NUM),
        .LAYER1_NEURON_NUM(LAYER1_NEURON_NUM),
        .LAYER2_NEURON_NUM(LAYER2_NEURON_NUM),
        .LAYER3_NEURON_NUM(LAYER3_NEURON_NUM),
        .LAYER4_NEURON_NUM(LAYER4_NEURON_NUM),
        .MAX_WEIGHT_NUM   (MAX_WEIGHT_NUM   )
    )

This may seem strange, but in some cases (such as instantiating modules) it works quite well, do we have the relevant configuration parameters to support this effect?

Hi, have you found the configuration for aligning ")" and "," yet? I am also looking for how to align these symbols, as aligning them will make them look cleaner.


Doesn't understand IRC rooms

When using it with the IRC adapter, it doesn't seem to understand IRC rooms (aka channels).
IRC channels are of the form #foobar.
Example output:
[11:23:53] @docwhat:	 hubot list standups in every room
[11:23:53] hubot:	 Here's the standups for every room:
[11:23:53] hubot:	 Room: undefined, Time: 10:00
[11:23:53] hubot:	 Room: undefined, Time: 11:45

I haven't hit 11:45am yet, so we'll see if it triggers or not.

I have a pull request open for a similar room name problem, in case that helps https://github.com/hubot-scripts/hubot-standup-alarm/pulls/6

That looks correct. Cool!

Closing this, as it was fixed in https://github.com/hubot-scripts/hubot-standup-alarm/commit/d3608051d11a8df1cf8d051805f152f90e5868c4.


Update validation rules in SendTip inputs

[ ] To have an actual validation of URL ( to not have something like that http.hey.com.sdsd.......... valid)
[ ] Set up real limitations for the tip amount (right now we have options min and step, but invalid amount is still can be sent, cause validation rule on button is amount > 0 )

It will be also very userfriendly to have error messages, that will help user to undestand what is not right.

I suggest to use veeValidate for this task, but i think we need a designs for the error messages.

There is a design for error messages after submit, but it is not suitable for inline (live) validation, as it is a popup


Increase unit test coverage with mock storage

Either using mongoose mock tool or inject a mock storage intance to achieve unit testings on more components.

Legacy issue from <=0.8.1.


I was able to get the Create Experience dialog to show up twice

I just double clicked quickly

[x] VS2019 preview2


fix some comments in LOS and ZREF

Description

There is a typo in the losreader.py that states heading angle is degrees CW from north, when ISCE in reality uses CCW from east. The comment has been changed to reflect this convention.
Also fixed the default value of zref to reflect what is actually used. This should be addressed later as zref is not currently being used in ZTD calculation

@sssangha can you verify that the comment change I made in the losreader file is correct? I.e. that the direction is ccw, not cw.

Pinging @sssangha on this. Thanks!

@jlmaurer can this be closed?

@dbekaert I'm still not sure which convention for heading is actually correct. The dev branch still says cw from north, but not sure if that is actually the right one. If so then yes can be closed, if not we should just update the comment.

Can you not check isce3 documentation?


Prepare Quarkus Helm + ArgoCD demo

This issue will be done as part of the Snowdrop tasks. Closing.


Can you please add support for Series Ep and all ?

You can get the tv series data with the same endpoints as the movies.
But tv series also has seasons and episodes endpoints.
Main info: https://vidstream-api.vercel.app/movie/39549
Seasons: https://vidstream-api.vercel.app/movie/39549/seasons
Episodes: https://vidstream-api.vercel.app/movie/39549/episodes?seasonId=37
This is all documented in the documentation.

also to deploy it with click on Vercel for our own instance

I added the deploy to vercel button.
https://github.com/WBRK-dev/vidstream-api?tab=readme-ov-file#3rd-party-hosting

Thanks

How to search for ep data with this

NVM Got it with hit and trial

https://vidstream.to/, https://flixhq.to/
You can get the episodes using this endpoint:
https://vidstream-api.vercel.app/movie/39549/episodes?seasonId=37
With the season id you got in the seasons endpoint response.

Ahhh Thanks buddy can I ask you one more thing I know I have already asked somewhere else but if you can also look into it once https://plyrxcdn.site/assets/js/library_v4.0.js
https://plyrxcdn.site/v/uVzIqdhJWEv7/
I want to get the logic of its decryption of encoded string
Can you check this ?

@WBRK-dev Its showing blank

Could be that the provider is down or the encryption changed again.
Please try again in a couple of hours.

Bro as checked its working fine for some Movies/series and not working for another can you check ?

Working
https://flixhq.to/watch-movie/watch-teri-baaton-mein-aisa-uljha-jiya-107356.10375324
Teri Baaton Mein Aisa Uljha Jiya
https://vidstream-api.vercel.app/movie/107356/sources?serverId=10375324
Not working
Movie Red One https://flixhq.to/watch-movie/watch-red-one-116773.10793875
https://vidstream-api.vercel.app/movie/116773/sources?serverId=10793875
Can you also add https://vidsrc.cc/ its using same Rabbit stream looks like if can be added

I have the same issue here.
The encryption didn't change at least, since one of the two is working fine.
This will either resolve itself or there is some kind of edge case in the decryptor.
I'll have a look into this later.

Now its reverse hahahah not working is working and working not working


Fast exits

Resolves #4
Requires: https://github.com/leapdao/leap-core/pull/85

@TimDaub I've updated the PR to work with meta accounts. Most of the logic moved into leap-core: https://github.com/leapdao/leap-core/pull/85

@TimDaub I've updated the PR to work with meta accounts.

Just tested it on Firefox and it worked great! LGTM


0.11.0 dev

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@e909113). Click here to learn what that means.
The diff coverage is 100%.

@@            Coverage Diff            @@
##             master       #1   +/-   ##
=========================================
  Coverage          ?   99.27%
=========================================
  Files             ?        1
  Lines             ?      137
  Branches          ?        0
=========================================
  Hits              ?      136
  Misses            ?        1
  Partials          ?        0

Impacted Files
Coverage Δ

py_schema/py_schema.py
99.27% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e909113...2c77aae. Read the comment docs.


[5.0] Partly backport #8425

There is one tricky issue with #8425
Imagine L5.1 is out. You are a package maintainer and you want to support both 5.0 and 5.1
However it becomes a problem because on one hand createMatcher() that you've used in 5.0 no longer exists in 5.1 and on the other hand Blade::directive() does not exist in 5.0. hmm...
That's why i propose:

partly backport #8425 ito 5.0 to allow ppl use Blade::directive() here without BC breaks
encourage this usage via documentation.

A note about removing matchers is probably needed here http://laravel.com/docs/master/upgrade too
/cc @franzliedke

You should just set your version constraints correctly. Anyone that set ~5.0 in their package has screwed up, because they are marking it as compatible with all versions of L5. Changing the constraint at a later release isn't god enough, because the earlier releases are still marked as compatible. I see people doing this so often.

If there are breaking changes in 5.1, then you should release a separate version for 5.1.

You can disagree with me, but in my opinion the framework has to try its best to save package maintainers from creating and maintaining separate branches for each minor release.
Especially when it's not so hard.

We don't backport things, entirely, or partially, after the decision was taken to only put it in 5.1. Sorry.

Okay, nice to know, thx

+1 Arrilot
https://github.com/crhayes/blade-partials/issues/7

+1 @Arrilot
https://github.com/crhayes/blade-partials/issues/7

@younes0 Here is a workaround if need it https://github.com/Arrilot/laravel-widgets/blob/master/src/ServiceProvider.php#L119


Getting the information from the auth

Hi there.
First of all, thanks for this plugin, really great ;)
I'm trying to do something.
So on my Users/login, the users choose which social they want to login.. Lets imagine facebook. They click on it, authorize it and then I want it to redirect to a page where he writes extra information ( I know this is not usual, but it's how the platform is built, and we need some extra information from the user, such as VAT number and such)
I already got the redirect working properly ('hauth_return_to' => 'users/add'). Though, I don't know how in users/add.ctp get the user from social and fullfill my form with some information from
Thanks a lot!

$this->Auth->user('social_profile') will give you facebook profile. So set that info to view.

It does return null (testing it on the controller).. Doing anything wrong?


What's dataset the pretrained model use?

Hi, Bgshih,
What's dataset the pretrained model use? Is it http://www.robots.ox.ac.uk/~vgg/data/text/mjsynth.tar.gz ?[this file is too big....]
I'm confused about it.
If you have time, I hope I can receive you reply .
thanks!

@pzz2011
Yes. Answer in paper.
For all the experiments for scene text recognition, we use the synthetic dataset (Synth) released by Jaderberg et al. [20] as the training data.

[20] M. Jaderberg, K. Simonyan, A. Vedaldi, and A. Zisserman. Synthetic data and artificial neural networks for natural scene text recognition. NIPS Deep Learning Workshop, 2014. 5

What are the steps to retrain the model from the synthetic dataset? For example, what is passed in as the parameters for createDataset.py?


OP-440 Adds proper test skipping

This pull request makes the build fail.

Separate build has been started for this PR and this one passed. @Skip is working like intended.

Carlo approved via Skype


tests,schema_reader: kafka message handling error tests

About this change - What it does
We add tests to validate the possible error cases while parsing the message key:

we test for invalid JSON for key
missing keytype in the key data
we test for invalid keytype
we test for invalid config value
we test for invalid subject delete value
we test for invalid version number within schema value
we test for generic invalid protobuf schema

Why this way
This is not added via the integration tests as we are verifying the side-effects which are then handled by other components and thus the unit tests are fine just to add.
The work requires the work currently done in #936 and thus was tested locally with a rebase on that branch, some linting and added tests might fail until we merge the other PR.

Should the base branch of this PR be https://github.com/Aiven-Open/karapace/pull/936 's branch , since it depends on it?

Should the base branch of this PR be #936 's branch , since it depends on it?

Yes I totally get your point, I had already started off that work and thus the rebase, ideally when this is merged to main, the commits will be the ideal count.

Do we not log all messages associated with Errors?  If not, should we?
Also nit: "doesnt" should be "doesn't" or "does not" which I think is
clearer.
Claude
On Fri, Sep 6, 2024 at 10:59 AM Emmanuel Evbuomwan @.***>
wrote:

@.**** commented on this pull request.
In karapace/schema_reader.py
https://github.com/Aiven-Open/karapace/pull/941#discussion_r1746866964:

@@ -487,7 +487,7 @@ def _handle_msg_config(self, key: dict, value: dict | None) -> None:
def _handle_msg_delete_subject(self, key: dict, value: dict | None) -> None:  # pylint: disable=unused-argument
if value is None:
LOG.warning("DELETE_SUBJECT record doesnt have a value, should have")

       return

       raise ValueError("DELETE_SUBJECT record doesnt have a value, should have")

Yes I agree, i tried not to change most of these.
—
Reply to this email directly, view it on GitHub
https://github.com/Aiven-Open/karapace/pull/941#discussion_r1746866964,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AASTVHQKBPQOWZWRUKOHUS3ZVF4INAVCNFSM6AAAAABNKLES2GVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDEOBVG43DKMBUGM
.
You are receiving this because your review was requested.Message ID:
@.***>

--
LinkedIn: http://www.linkedin.com/in/claudewarren

Do we not log all messages associated with Errors? If not, should we? Also nit: "doesnt" should be "doesn't" or "does not" which I think is clearer. Claude
…
On Fri, Sep 6, 2024 at 10:59 AM Emmanuel Evbuomwan @.> wrote: @.* commented on this pull request. ------------------------------ In karapace/schema_reader.py <#941 (comment)>: > @@ -487,7 +487,7 @@ def _handle_msg_config(self, key: dict, value: dict | None) -> None: def _handle_msg_delete_subject(self, key: dict, value: dict | None) -> None: # pylint: disable=unused-argument if value is None: LOG.warning("DELETE_SUBJECT record doesnt have a value, should have") - return + raise ValueError("DELETE_SUBJECT record doesnt have a value, should have") Yes I agree, i tried not to change most of these. — Reply to this email directly, view it on GitHub <#941 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AASTVHQKBPQOWZWRUKOHUS3ZVF4INAVCNFSM6AAAAABNKLES2GVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDEOBVG43DKMBUGM . You are receiving this because your review was requested.Message ID: @.***>
-- LinkedIn: http://www.linkedin.com/in/claudewarren

Yes indeed, we should log all errors, we can check which ones we do not currently log and log those as a follow up task, as for the typo, I was trying my best not to change much of what already exists.


Autoplay + Pause on Hover + Stop Autoplay

If I setup a slider with the options:
...
autoplay: true,
autoplayHoverPause: true,
...
and trigger "stop.owl.autoplay" later, the autoplay will stop as wanted.
So far everything as expected, now the problem:
If I hover the slider now, the slider triggers another stop, and if I move the mouse away, it triggers another start, so the autoplay starts over again.

There seem to be a bug around the autoplayHoverPause, even the autoplay triggerable events by attaching to "mouseover" and "mouseleave" doesn't work. The "autoplayHoverPause = true" only ever work once when page reloads, after that it won't work anymore.

@apermo Your issue with hover starting autoplay again after it's been manually stopped was fixed with beta 3. Test case
@teej043 In beta 3, autoplayHoverPause works after manually triggering stop.owl.autoplay and then play.owl.autoplay again. If this isn't what you're describing, please open another issue. Test case


Wait for the N-times call the method.

I want to do the following:

(1) Wait for the N-times call the method.
(2) It does not mind being called more than N times.

OCMExpect([mock someMethod]).onReturn(0);
dispatch_async(dispatch_get_global_queue(DISPATCH_QUEUE_PRIORITY_DEFAULT, 0), ^{
    [mock someMethod];
});

OCMVerifyWithDelay(mock, 1.0f);
OCMVerifyWithDelay(mock, 1.0f); // success

This way that multiple times run OCMVerifyWithDelay is not correctly work.
id observerMock = OCMObserverMock();
[notificatonCenter addMockObserver:aMock name:SomeNotification object:nil];
[[observerMock expect] notificationWithName:SomeNotification object:[OCMArg any]];

[mock  someMethod];
[mock  someMethod]; // failed

On other hand, this way isn't correctly work.
Here exception is thrown.
I as a solution, I hope added the option that remove the exception.
if (! throughEnabled) {
    [NSException raise:NSInternalInconsistencyException format:@"%@: unexpected notification observed: %@", [self description],
    [aNotification description]];
}

You should be able to add a OCMStub call after the OCMExpect (or N calls to expect), so that additional calls won't throw exceptions.

@carllindberg
I have questioned the exception that is thrown observerMock.
If we don't use observerMock and multiple calls to the stub and expect, exception won't throw.
However, in the way we need to do to alternately the OCMExpect and the method call.
This is a difficult when it use async.


[GenericPoseGraph] Remove unused declarations.

@wally-the-cartographer merge

Merge requested by authorized user pifon2a. Merge queue now has a length of 3.

Error: exit status 1
Log:
=> handle work item: PR 1323 on googlecartographer/cartographer.
 => Switching to branch master.
 $ git reset --hard HEAD [data/cartographer]
HEAD is now at 33fcc1a3 Set client_id in LoadState(FromFile) (#1320)
 $ git clean -fd [data/cartographer]
 $ git checkout master [data/cartographer]
Already on 'master'
Your branch is up to date with 'origin/master'.
 $ git pull [data/cartographer]
Already up to date.
Current branch master is up to date.
 => Checking out mbokeloh/cleanup as local branch pr_1323.
 $ git remote add mbokeloh git@github.com:mbokeloh/cartographer.git [data/cartographer]
fatal: remote mbokeloh already exists.
 $ git fetch mbokeloh [data/cartographer]
 $ git branch --track pr_1323 mbokeloh/cleanup [data/cartographer]
Branch 'pr_1323' set up to track remote branch 'cleanup' from 'mbokeloh'.
 => Switching to branch pr_1323.
 $ git reset --hard HEAD [data/cartographer]
HEAD is now at 33fcc1a3 Set client_id in LoadState(FromFile) (#1320)
 $ git clean -fd [data/cartographer]
 $ git checkout pr_1323 [data/cartographer]
Switched to branch 'pr_1323'
Your branch is up to date with 'mbokeloh/cleanup'.
 $ git pull --force [data/cartographer]
Your configuration specifies to merge with the ref 'refs/heads/cleanup'
from the remote, but no such ref was fetched.


Weird variable value in loop in Mud component

Bug type
Component
Component name
MudText
What happened?
I've noticed a strange phenomenon that I can't explain. I don't know if it's a bug or a specificity of blazor.
When we put a MudText component in a for loop, and use a loop variable value in it (no matter if we display or using in some condition) the value of this variable is always the same and does not match the one incremented by the loop.
Expected behavior
The variable in the given example in the MudText component is displayed as the values 1, 2, 3, 4
Reproduction link
https://try.mudblazor.com/snippet/QEwFPlvYxzHsnrmZ
Reproduction steps
Just look try.mudblazor sample
Relevant log output
No response
Version (bug)
5.2
Version (working)
No response
What browsers are you seeing the problem on?
Chrome
On what operating system are you experiencing the issue?
Windows
Pull Request

[ ] I would like to do a Pull Request

Code of Conduct

[X] I agree to follow this project's Code of Conduct

var k = j;

Yeah, but why?

Sorry, a bit low on time, google for: c# loop capture closure


Jade renamed to pug

Hi! Looks like Jade templating language was foced to be renamed, so new name is Pug.
See: https://github.com/pugjs/pug/issues/2184
I m sure AllCountJs should be prepared (npm already warn you about name change on install any dependency)

Hi!
Could that cause this issue? - https://github.com/allcount/allcountjs/issues/119

@CreativeWolf : I did not see any connection - jade just got renamed, no breaking functionality

@deksden Realized that. Thanks! :)


import numpy as np

good to go from my end @qbarthelemy

aaaaah finally

thx @qbarthelemy for the quick review !


Mounting RBD as block device to POD end with error

Describe the bug
CSI generate long volume handler which leads to error in kubernetes:
Feb 21 18:22:30 kube04 systemd[1]: Failed to generate valid unit name from path '/var/lib/kubelet/plugins/kubernetes.io/csi/volumeDevices/staging/pvc-d222a0af-9908-434a-a79f-4c23323f8acb/0001-0024-ae243d8e-a3b7-4aa8-a291-f4bd1edbb692-0000000000000005-7f9798c9-92fe-11ec-b7b8-468c46dd0c5b', ignoring mount point: File name too long
Environment details

Image/version of Ceph CSI driver :
v3.5.1

Kernel version :
Linux kube04 5.10.0-11-amd64 #1 SMP Debian 5.10.92-1 (2022-01-18) x86_64 GNU/Linux

Kubernetes cluster version :
Server Version: version.Info{Major:"1", Minor:"23", GitVersion:"v1.23.3", GitCommit:"816c97ab8cff8a1c72eccca1026f7820e93e0d25", GitTreeState:"clean", BuildDate:"2022-01-25T21:19:12Z", GoVersion:"go1.17.6", Compiler:"gc", Platform:"linux/amd64"}

Ceph cluster version :
ceph version 16.2.7 (f9aa029788115b5df5eeee328f584156565ee5b7) pacific (stable)

Steps to reproduce
Kubernetes cluster with calico networking
Create RBD CSI storage like described in https://docs.ceph.com/en/latest/rbd/rbd-kubernetes/
After kubectl exec to 'pod-with-raw-block-volume' from previous sample mount command ends with:
mount: /QQ: cannot mount /dev/rbd0 read-only.
Of course filesytem is created on device and when I mount it in host, everything works
Host /var/log/daemon.log contains following error:
Feb 21 18:37:20 kube04 systemd[1]: Failed to generate valid unit name from path '/var/lib/kubelet/plugins/kubernetes.io/csi/volumeDevices/staging/pvc-d222a0af-9908-434a-a79f-4c23323f8acb/0001-0024-ae243d8e-a3b7-4aa8-a291-f4bd1edbb692-0000000000000005-7f9798c9-92fe-11ec-b7b8-468c46dd0c5b', ignoring mount point: File name too long
Expected behavior
Mounted volume
Logs

csi-rbdplugin/csi-cephfsplugin and driver-registrar container logs from
I0221 17:44:44.934976    1126 utils.go:195] ID: 6181 GRPC request: {}
I0221 17:44:44.935001    1126 utils.go:202] ID: 6181 GRPC response: {}
I0221 17:45:44.934948    1126 utils.go:191] ID: 6182 GRPC call: /csi.v1.Identity/Probe
I0221 17:45:44.935165    1126 utils.go:195] ID: 6182 GRPC request: {}
I0221 17:45:44.935231    1126 utils.go:202] ID: 6182 GRPC response: {}
I0221 17:45:53.515884    1126 utils.go:191] ID: 6183 GRPC call: /csi.v1.Node/NodeGetCapabilities
I0221 17:45:53.515982    1126 utils.go:195] ID: 6183 GRPC request: {}
I0221 17:45:53.516296    1126 utils.go:202] ID: 6183 GRPC response: {"capabilities":[{"Type":{"Rpc":{"type":1}}},{"Type":{"Rpc":{"type":2}}},{"Type":{"Rpc":{"type":3}}},{"Type":{"Rpc":{"type":5}}}]}
I0221 17:45:53.517359    1126 utils.go:191] ID: 6184 GRPC call: /csi.v1.Node/NodeGetVolumeStats
I0221 17:45:53.517483    1126 utils.go:195] ID: 6184 GRPC request: {"volume_id":"0001-0024-ae243d8e-a3b7-4aa8-a291-f4bd1edbb692-0000000000000005-7f9798c9-92fe-11ec-b7b8-468c46dd0c5b","volume_path":"/var/lib/kubelet/plugins/kubernetes.io/csi/volumeDevices/pvc-d222a0af-9908-434a-a79f-4c23323f8acb/dev/50072985-1946-47d7-8d6a-5d6719ffead5"}
I0221 17:45:53.517657    1126 utils.go:202] ID: 6184 GRPC response: {"usage":[{"total":1073741824,"unit":1}]}
I0221 17:46:44.934841    1126 utils.go:191] ID: 6185 GRPC call: /csi.v1.Identity/Probe
I0221 17:46:44.934910    1126 utils.go:195] ID: 6185 GRPC request: {}
I0221 17:46:44.934936    1126 utils.go:202] ID: 6185 GRPC response: {}

I tracked problem down to systemd on host system if you try this:
systemd-escape -p --suffix=mount "/var/lib/kubelet/plugins/kubernetes.io/csi/volumeDevices/staging/pvc-96b3a3a5-c494-4f77-87f4-05eedba25091/0001-0024-ae243d8e-a3b7-4aa8-a291-f4bd1edbb692-000000000000000a-4fd87529-95c8-11ec-ad5f-56c8229ed59b"
var-lib-kubelet-plugins-kubernetes.io-csi-volumeDevices-staging-pvc\x2d96b3a3a5\x2dc494\x2d4f77\x2d87f4\x2d05eedba25091-0001\x2d0024\x2dae243d8e\x2da3b7\x2d4aa8\x2da291\x2df4bd1edbb692\x2d000000000000000a\x2d4fd87529\x2d95c8\x2d11ec\x2dad5f\x2d56c8229ed59b.mount
It generates name which is 263 characters long and when systemd test for such file it crash with error. I found some fixes in systemd but best fix will be to generate shorter names for CSI produced volume names. Was ever somebody able to mount such volume?

Finally resolved it. You need new version of systemd. When you see following in your host log you are fine, this is only information message about mapping:

Failed to generate valid unit name from path '/var/lib/kubelet/plugins/ku....', ignoring mount point: File name too long

And for using mount command inside pod you need also privileged security context. Add to your deployment something like:
      volumeDevices:
        - name: data
          devicePath: /dev/rbd0
      securityContext:
        privileged: true

Hi there,
I'm also using provisioner: rbd.csi.ceph.com with volumeMode: Block as persistent storage. But I am unable to mount it without privilege escalation as I get the read-only permission limit. However, it works with @tavoda mentioned in his last post.
I need to know if it's intended behavior for CSI not to be able to mount RBD images without such escalation.
Thank you


Can i create a svelte version of this library

I want learn how this package work and implement to svelte, another ui framework
Of course i will put your project and all credits in readme.
Let me know, thanks

Sorry for the late response, but yes. Feel free to recreate this in any other framework.


ARROW-8243: [Rust] [Parquet] Serialize Arrow schema metadata

This will allow preserving Arrow-specific metadata when writing or reading Parquet files created from C++ or Rust.
If the schema can't be deserialised, the normal Parquet > Arrow schema conversion is performed.

Current failures will be resolved by https://github.com/alexcrichton/socket2-rs/pull/96

@nevi-me sg - I think this is stacked on another PR though: do we need to get the other one reviewed first?

... I think this is stacked on another PR though: do we need to get the other one reviewed first?

@sunchao it's a bit messy, but it's one PR.
The changes are below:

arrow_reader.rs - added a roundtrip test (https://github.com/apache/arrow/pull/7917/files?file-filters[]=.toml#diff-4c103051156d7b901fad8d9e26104932R310) to avoid importing the reader and writer into the schema.rs file. I opted to put the test in reader because it results in the fewest imports (only need the ArrowWriter).
arrow_writer.rs - implements the schema serialisation
schema.rs - implements schema deserialisation
properties.rs - change to allow mutating metadata

Let me refactor the above quickly, as I now see that I can move both serialisation and deserialisation to schema.rs

@sunchao I forgot to mention, I made the changes, so this is ready for review

@nevi-me ah OK - I'll take a look soon!

merged in the parquet branch


bump FAB to 2.3.0

CATEGORY
Choose one

[ ] Bug Fix
[ ] Enhancement (new features, refinement)
[ ] Refactor
[ ] Add tests
[ ] Build / Development Environment
[ ] Documentation

SUMMARY

CHANGELOG:
https://github.com/dpgaspar/Flask-AppBuilder/compare/v2.2.4...v2.3.0
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TEST PLAN

Tested all major views (dashboard, sqllab, explore)
Tested all database CRUD view (view, edit)

ADDITIONAL INFORMATION

[ ] Has associated issue:
[ ] Changes UI
[ ] Requires DB Migration.
[ ] Confirm DB Migration upgrade and downgrade tested.
[ ] Introduces new feature or API
[ ] Removes existing feature or API

REVIEWERS
@dpgaspar

Codecov Report

Merging #9318 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #9318   +/-   ##
=======================================
  Coverage   59.08%   59.08%
=======================================
  Files         374      374
  Lines       12205    12205
  Branches     2989     2989
=======================================
  Hits         7211     7211
  Misses       4815     4815
  Partials      179      179

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f1370c5...6f1e3ad. Read the comment docs.


Sign out when turned off Sync

When I turned off Sync, I would also expect to sign out.

Reverted.


Rename master branch to main

Is your feature request related to a problem? Please describe.
N/A
Describe the solution you'd like

Rename master branch to main.
Make the main branch the default branch.
Ensure that branch protection from master applies to main.

Describe alternatives you've considered
Main has become the new standard for default branches in git. No real reason to consider alternatives.
Additional context
This brings MinIO docs in line with modern practices for branch naming conventions.

We're planning on doing this in the near future. Should not impact anything, but raising this just in case someone out there has built scripts against our master branch.

git still creates master as default branch name, it's GitHub's decision to keep main instead of master.

Yeah, we might as well keep it consistent - docs-k8s is main anyways.
AFAIK we have no scripts relying on this, it's just docs so it shouldn't impact anything - @harshavardhana if there's something you know that we hook into that would be good to know, I don't think we have any chron jobs that auto-pull or rebuild these docs right now

Yeah, we might as well keep it consistent - docs-k8s is main anyways.
AFAIK we have no scripts relying on this, it's just docs so it shouldn't impact anything - @harshavardhana if there's something you know that we hook into that would be good to know, I don't think we have any chron jobs that auto-pull or rebuild these docs right now

there should be none.

This has been done as part of the new docs release.


Export Ar-Package support

Export a particular Ar-package maintaining its tree structure along with the parent packages in to a new arxml file.
The exported arxml shall be importable in tools like Matlab/Simulink/TargetLink

Hi @punithspal ,
Thanks for the CR and I think, it really makes sense to have this feature in place. I think, it will be better if we could do it for all packageableElements. So, basically, ArPackage as well as any elements which comes directly under ArPackage. What do you think?
Thanks!

Hi @punithspal ,
I added the support for exporting the collectableElements(which means Ar-package as well as all packageableElements which includes ApplicationSwComponentType, SR interface, Signals etc etc). The changes are pushed to the branch https://github.com/girishchandranc/autosarfactory/tree/14-issue-with-xml-serialization.
Following are the way to use it:

option1(using export function available in the node itself)

swc = autosarfactory.get_node('/Swcs/swc1')
swc.export_to_file('swc1Export.arxml', overWrite = True)

option2(using export function where you pass the node)

swc = autosarfactory.get_node('/Swcs/swc1')
autosarfactory.export_to_file(swc, 'swc1Export.arxml', overWrite = True)

Could you please check and let me know if this works for you?

@punithspal  further regarding question on importing the the dictionary(datatypes and mappings). I believe they are all packageableElements. for eg: ImplementationDataTypes, ApplciationDataTypes, DataTypeMappingSet etc etc. Can you please check once and let me know if that works for you. I have described the usage in my previous comment.
Thanks again!

The issue is successfully implemented.


Error with brand new Flutter project

Ran flutter create
Added package to pubspect.yaml
Ran application
Getting warning

Flutter Doctor output

Warning: Operand of null-aware operation '!' has type 'Set<BluetoothDevice>' which excludes null
'Set' is from 'dart:core'.
'BluetoothDevice' is from 'package:flutter_web_bluetooth/src/flutter_web_bluetooth_web.dart' ? _knownDevicesStream.value!

This is a bit of a hack so it can work with rxrxdart version 0.26.0 and 0.27.0.
In the 0.26.0 version that value is null able but in 0.27.0 it isn't so you get the warning.
The library also support 0.26.0 instead of the latest 0.27.0 because the package flutter_blue, a Bluetooth package for Android and iOS, only supports up to 0.26.0 and I want it to be compatible.
But hey wantings are there to be ignored.

I've removed RxDart as a dependency all together so it's solved.


Adding markdown drone with default rules.

In response to @vielmetti issue https://github.com/packethost/docs/issues/2
This PR contains a Drone CI for README.md coverage with default rules. README.md doesn't pass checks with the current set of rules.
New set of rules for markdown files configured specifically for Packet's /docs files will be added in the next requests. Then, Drone will be extended beyond just README.md to cover all markdown files.

@vielmetti done! please, review the changes.


zziplib doesn't build on x64-linux

zziplib doesn't compile on linux due missing configuration file. When added, it compiles.
fix_zziplib.zip
afterwards ./vcpkg install zziplib:x64-linux should work.

Hi @stoperro, thanks for reporting this issue!
I've fixed this issue. Please update vcpkg and rebuild zziplib.
Thanks.


Broken JavaScript in Safari due to use of $global.AudioContext

The experimental audio support breaks the JavaScript in the current Safari on OS X (and Mobile Safari)
TypeError: undefined is not a constructor (evaluating 'new($global.AudioContext)()')

A quick workaround (by disabling audio)
Returning directly at the start of the initialize() and start() functions of audio_js.go "solves" this issue in the desktop version of Safari, still broken in Mobile Safari though.

Made sure I could reproduce that. I'm fixing this now.

Fixed. There is still no sound on Safari, and this is another new bug.


The Heat stack hosting OpenShift cluster is highly ephemeral and requires data persistence for clusters deployed

BUG REQUEST INFO:
Environment:

Cloud provider: Openstack

OS (printf "$(uname -srm)\n$(cat /etc/os-release)\n"): any

Version of Ansible: (ansible --version): 2.3.1

Version of Jinja: (pip freeze | grep -i jinja) N/A

Version of Shade: (pip freeze | grep -i shade) 1.21, os-client-config==1.27.0

Openstack-ansible-contrib version (commit) (git rev-parse --short HEAD): 7ce0793
Copy of used inventory files and custom variables (please omit your secrets!): N/A
Command used to invoke ansible:
the provision playbook
Output of ansible run:
N/A
Anything else do we need to know:
Some stack update actions, like changing ssh keys to be sent via cloud init, destroys and recreates VMs. This makes any deployed OpenShift clusters w/o a shared storage, like Ceph, highly ephemeral. The data, like etcd keys and certificates and what else k8s/openshift needs, must be kept on persistent volumes and survive VMs recreation/migration.

@bogdando: I found an issue in persisting root volumes attached to heat hosts.
In case of a failed node, a
openstack stack resource mark unhealthy ....
openstack stack update ... --existing

The following happens:
1- heat creates a new node to replace the unhealthy one. This happens before heat removes the new one!
2- heat tries to attach the root volume to the new node
3- this fail as the root volume is attached to the old node.
If you look at the 'programmable infrastructure' paradigm, it should be preferable to programmatically replace a single node (eg while just retaining data volumes) than to attach a root volume to eg. a new flavored server.

@bogdando for further limiting host replacement, you can see restricted_actions. https://docs.openstack.org/heat/latest/template_guide/environment.html#restrict-update-or-replace-of-a-given-resource
Let me know,
R.

thanks @ioggstream !

@bogdando let us know if that works. I actually made a lot of work on the openshift-on-openstack repo and it won't be hard to backport most of that work here. You can check relevant patches there.

/close via #651

/close


As a user, I would wish to know the total amount I have spent

so that I can plan my remaining finance for the remaining days of the month

Done via the #98 and #139


fix_backbone new feature: Get canonical fasta from network if not provided

If the input_canonical_fasta argument is not provided we should create it performing a blast for each chain.

If there is no fasta provided and no network just copy the input file to the output Warning in the log but it should not crash.


Can the input be VCF file from other SV callers?

Can the input be VCF file from other SV callers?

No, because it needs supporting reads in vcf "info", which, within ny knowledge, only cuteSV has, and it needs several sharp symbols to split the read names, if u find other sv caller has similar info, u can manually add the sharp symbols and it hould be runnable


[neuralynx] add support for neuraview file header

This is an alternative implementation to #944 that introduced neuraview file header interpretation and a corresponding first simple unit test. @fccaa Can you confirm this version is working for your files?

Hello @JuliaSprenger! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:

In the file neo/test/iotest/test_neuralynxio.py:

Line 26:1: E302 expected 2 blank lines, found 1

This is an alternative implementation to #944 that introduced neuraview file header interpretation and a corresponding first simple unit test. @fccaa Can you confirm this version is working for your files?

Hi. The version here behaves the same as #944 . I have no error message to open my files. I think this version is working.

@fccaa Thanks for checking. I would prefer to have the new header format properly embedded in the existing header routines. I hope you don't mind my alternative implementation. Thanks again for pointing this out and taking the initiative.
@samuelgarcia Ready for review from your side.

OK for me.


[chore] Delete unused rendered examples

After generating examples, all of these were deleted. Let's remove unneeded examples.

@povilasv yes I'm on it, needs version bump even though we're just deleting examples

It looks the clean up might not be needed, it could have been my misconfigured dependencies, after latest changes I see everything being generated. Closing this for now.


[APPS-3371] Add a new validation method and distinguish create from update

@zendesk/wombat @zendesk/vegemite
Description
Adding a new validation method to be used in the zendesk_app_market.
Sunsetting will mean updates only and no new apps.
once this gem is bumped, I will update the app market and then write specs for it.
References

JIRA: https://zendesk.atlassian.net/browse/APPS-3371

Risks
low - breaks app updates/create

At the moment, ZAT uses the sunsetting version to check whether to display the sunsetting message.
Based on the new description of what sunsetting should be, shouldn't the sunsetting value be nil until August 1st? (If so, we'd need to update ZAT to deal with that.)

Nick, I was thinking to make those changes and not merge it until August 1st.
Should we discuss what's the best strategy? Maybe Phil would be happy to end new v1 apps right now?

@fbvilela I highly doubt we'd be able to end new v1 apps now as the August 1st date is what's been communicated for a while to developers.
Not merging it until August works for me (ZAT is working now and will work with those changes too) so as long as ZAM is happy to wait for it.

@zendesk/vegemite @zendesk/wombat . This is ready for review.
I have a branch on the zendesk_app_market project ready to bump this gem and fix failing tests.
The idea is to merge THIS PR before august 1st, bump zam and get it deployed on the 1st.

A spec would be great.

@xuebingli 💇♂


create a meaningful RomVariant identifier

Just an idea :)

looks good, thanks!

sorry, I was very busy lately.
I just (squash and) merged your changes, many thanks for the contribution!


Add new endpoint for fetching rule evaluations

Summary
Defines a new API for fetching rule evaluation results, rather than overloading GetProfileStatusByName.  Does not provide an implementation, though hopefully the implementation is straightforward.
Change Type
Mark the type of change your PR introduces:

[ ] Bug fix (resolves an issue without affecting existing features)
[x] Feature (adds new functionality without breaking changes)
[ ] Breaking change (may impact existing functionalities or require documentation updates)
[ ] Documentation (updates or additions to documentation)
[ ] Refactoring or test improvements (no bug fixes or new functionality)

Testing
make gen
make test
make build

Review Checklist:

[x] Reviewed my own code for quality and clarity.
[x] Added comments to complex or tricky code sections.
[x] Updated any affected documentation.
[ ] Included tests that validate the fix or feature.
[x] Checked that related changes are merged.

Is this in preparation for label-based profiles? Or something else?

yep

@evankanderson thinking about this further, I don't particularly have a use-case for key-value style labels. So, an array of strings is just as good in this case.

My first thought was to start with dns-style labels, but I'm wondering if that's too constricting.

My first thought was to start with dns-style labels, but I'm wondering if that's too constricting.

I'd say DNS + a minimal subset of characters like "/" and "-" should be fine to start with

Okay, I updated the comments based on our discussion about K:V maps vs "bag of strings".  We ended up going with the bag of strings approach because all our "values" ended up being singletons (e.g. "true" or "hidden", but no other value).  Also clarified max size and allowed characters for the labels.


Outstanding promises not rejected on disconnect

In Tinode.handleDisconnect:
https://github.com/tinode/tindroid/blob/master/tinodesdk/src/main/java/co/tinode/tinodesdk/Tinode.java#L449-L454
reject all outstanding promises.
But by the time it's called, the mFutures map is already empty due to
https://github.com/tinode/tindroid/blob/master/tinodesdk/src/main/java/co/tinode/tinodesdk/Tinode.java#L434

Fixed

Released in 0.15.15-rc1


Add ability to calculate tax for completed order

Through manual order tool, order can get modified after it is completed for various reasons.
We need to recalculate taxes for order in such scenario so add that state in allowed states here.

👍


Taxes settings – Esabled tax rate in OldDot is not displayed in NewDot after page reload

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: 1.4.85-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers<EMAIL_ADDRESS>Issue reported by: Applause - Internal Team
Action Performed:
Precondition: log in to NewDot and OldDot with the same account.

Go to https://staging.new.expensify.com/
Log in
Create a WS and open it settings
Click on More features and enable taxes
Navigate to taxes
Open taxes page in Old Dot
Disable tax rate in OldDot
Reload the taxes page in NewDot and verify the tax rate is disabled
Open taxes page in Old Dot again and enable the same tax rate
Reload the taxes page in NewDot

Expected Result:
Tax rate is esabled
Actual Result:
Tax rate is disabled
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android: Native
[ ] Android: mWeb Chrome
[ ] iOS: Native
[ ] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[ ] MacOS: Desktop

Screenshots/Videos
Add any screenshot/video evidence

https://github.com/Expensify/App/assets/78819774/80a74206-20a4-446a-add0-a38c6075fe1c
View all open jobs on GitHub

@anmurali  FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

We think that this bug might be related to #wave-collect - Release 1

Cannot reproduce. It did require a page refresh to show that it was in fact enabled.


docs: Update doc to reflect extended support for sso deprecated fields

What type of PR is this?
/kind documentation
What does this PR do / why we need it:
Follow up PR for https://github.com/argoproj-labs/argocd-operator/pull/911 to update doc to reflect extended support for sso deprecated fields.
Have you updated the necessary documentation?

[x] Documentation update is required by this PR.
[x] Documentation has been updated.

Which issue(s) this PR fixes:
Fixes GITOPS-2904

/ok-to-test

/test v4.12-kuttl-sequential

/retest

/retest

/test v4.11-kuttl-sequential

/test v4.11-kuttl-sequential

/retest

/retest


Add token server disclaimer

Contributing to Twilio

All third party contributors acknowledge that any contributions they provide will be made under the same open source license that the open source project is provided under.

[x] I acknowledge that all my contributions will be made under the project's license.

Pull Request Details
Description
Add token server disclaimer.
Burndown
Before review

[x] Updated CHANGELOG.md if necessary
[x] Added unit tests if necessary
[x] Updated affected documentation
[x] Verified locally with npm test
[x] Manually sanity tested running locally
[x] Included screenshot as PR comment (if needed)
[x] Ready for review

Before merge

[x] Got one or more +1s
[x] Re-tested if necessary

+1 Love this change @aaalaniz .
This is something I was wondering about when I started using this project. I wasn't sure If I could release to production using the twilio serverless functions or if I needed to self host.
Thanks for clearing this up!


First version of Databricks SCIM preview implementation.

-add support for delete and put http methods
-handle http return status CREATED and NO_CONTENT
-add dto's for SCIM entities (user and group)
-add wrappers for Databricks SCIM api
-add integration tests
-add timeout and retry configs to Databricks factory used by the integration tests

Looks like your changes failed checkstyle.
Overall, looks good!
A lot to review there and I also will run integration tests locally as unfortunately we don't have that automated. Hoping to get some updates to your PR tomorrow.
thanks for your large contribution!

I've fixed a couple of them ( a new commit) - however some of the rules should be revisited (or the project conventions should be changed) - for example on rule complains about the 'DTO' suffix "Abbreviation in name 'runParametersDTO' must contain no more than '2' consecutive capital letters.
Note that the SCIM tests should be executed with an admin token.

ok thanks for pointing that out. I have merged a fix to the checkstyle file so that abbreviations can be 3 chars long. That will mean you will only have new checkstyle issues to take care of now.

@samshuster  - thanks for modifying the checkstyle. Note that there is one more rule that should be fixed in the checkstyle ("Package name 'com.edmunds.rest.databricks.DTO.scim' must match pattern '^[a-z]+(.[a-z][a-z0-9])$'.") - or the package name should be changed to lowercase

package name being changed to lower case would be great... but it would mean that every project that depends on the classes would have to be changed. Not sure if we are ready to do that quite yet.
I am going to take the easy way out and just remove that checkstyle rule. I will push and merge it now

@samshuster @Mikhail-Ivanov @javamonkey79  - taking into account that databricks will not implement pagination soon we have two options:
-add some comments to the method ListResponseDTO listGroups(String filters, int startIndex) (and to the corresponding UserDTO) saying that for the moment startIndex is ignored
-remove the method from the interface (but leave the internal implementation) in order to prevent any confusion
wdyt? I like the second option more.

wdyt? I like the second option more.
As for me I'd also tend to second one. We can extend interface someday if Databricks introduce such possibility.

hey @cornelcreanga just making sure you saw that we are just waiting on all discussions to get to resolved state. Can you reply to all comments? Thanks a bunch!

The integration tests are no longer working, you can't delete an user from a workspace for the moment. Note that this is not related to the SDK - the DBricks UI has the same problem - it reports the user as removed  but on refresh you can see it again. I've opened a ticket to Microsoft related to that.

Integration tests are fixed, DBricks fixed the problem on Friday. I've added a new tiny commit to remove the pagination methods + replied to @javamonkey79  comment.

ok thanks @cornelcreanga! Looks like we are almost ready to merge this in.


Optionally don't fall back to ip on limit_by

We want to rate-limit on a header X-Forwarded-For. When this header
does not exist it usually is an internal service. Falling back to
source ip gives us disastrous results.
This commit adds an option to fail instead of falling back to ip. I made a
patch that does this: https://github.com/Kong/kong/pull/6836

Dear contributor,
We're closing this issue as there hasn't been any update to it for a long time. If the issue is still relevant in the latest version, please feel free to reopen it. We're more than happy to revisit it again.
Please have a look at our pledge to the community for more information.
Sincerely,
Kong Gateway Team


Create docker file to build docker easily

add this file to let others create a docker image

thanks for your contribution. i already had one Dockerfile local that had a documentation missing. So i added mine together with the docs which is basically the same as yours but uses the smaller python-alpine base image.


Google Cloud Storage uploader

Thanks! I did write it after S3 implementation.
Before we jump into testing I wonder how scalable this approach is. I mean what if we have more some XYZ uploaders. We keep adding members to store corresponding configs in hashes and allowing only a single uploader to be used at a time. While, we may say it doesn't make sense to use 2 uploaders at the same time (why would anybody need that?). I wonder if we should have a single hash with :s3 and :gcs keys on top level and make it possible to use all of them if one will? I feel like some refactoring would be necessary though...

Now I realise the S3 driver has no test

I do see a unit test for S3. I can reuse that for GCS as well.
Also I don't think end-to-end is going to be hard if we are up for it. Ingress is free and if we delete uploads, I don't think we would have to pay anything for storage. With high availability and low latency it can be done. We would want to encrypt credentials though.
I'm going to rebase my stuff meanwhile as S3 path reporting changes have been merged... it will look clean for GCS as well.

uhm… no worries on slow replies…it took me over 2 month to get back to it 😆
I think it passes some tests now. I used S3 implementation as a reference, but I had to heavily modify it. I hope it tests most if not all cases. I do not see coverage reports.

i wonder why this is not implemented using the callbacks. would be much cleaner, not clutter the base class with specifics. could also be released as a seperate gem.


Develop

https://github.com/rolling-scopes-school/tasks/tree/master/react/modules/module01

3. https://rs-school-1st.netlify.app/
4. Done: 20.03.2023 / deadline: 20.03.2023
5. score: 100/100


404 Access denied

the streaming can't be acessed.. solution please

Can you try again?

thank you, it can be accessed today
if the problem show again, i'll say it


Debug module in launch mode fails for large json messages

Whilst performing all the steps & using Curl
"curl --header "Content-Type: application/json" --request POST --data '{"inputName": "input1","data":"hello world"}' http://localhost:53000/api/v1/messages"
works perfectly for both curl and postman.
But if the "data" is json , postman failed with error "Error: socket hang up".
Curl failed with "curl: (52) Empty reply from server"
It seemed that post json , any curl would fail later:
It might be iotedgehubdev may not be equipped for json or large data.
E.g can be
curl --request POST 'http://localhost:53000/api/v1/messages'
--header 'Content-Type: application/json'
--data-raw '{
"inputName": "WRITE_API_KEY",
"data": [{
"created_at": "2018-01-30 10:26:2 -0500",
"field1": "1.0",
"field2": "2.0"
},
{
"created_at": "2018-02-02 11:27:27 -0500",
"field1": "1.1",
"field2": "2.2",
"status": "well done"
}
]
}'
Sometimes error may be "{"error":"TypeError: "string" must be a string, Buffer, or ArrayBuffer"}"
But not sure if is related.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 5a3f2f86-40bf-19f2-4f56-9dc71ed47fa2
Version Independent ID: 20e8912c-4a10-68b9-c46a-e945a62421d6
Content: Develop and debug modules for Azure IoT Edge
Content Source: articles/iot-edge/how-to-vs-code-develop-module.md
Service: iot-edge
GitHub Login: @shizn
Microsoft Alias: xshi

@sharbt -
Thank you for your question.
Can you please share with us the URL of the document that you are having issues with?
Please note that we scope issues on this repo to feedback related to the docs. If you have a product question, please post it on Microsoft QnA or Stack Overflow. Thank you for your understanding.

@MonikaReddy-MSFT
Can see similar issue being fixed https://github.com/Azure/iot-edge-testing-utility/issues/12 as reported.
But still I am using
iotedgehubdev, version 0.14.1 (where issue reported)
On Windows 10 box.
I am using integrated VS Code/Azure IoT edge tools.
Do let me know if IotEdgeHubDev needs to be upgraded and how to do.
For your information:
URL : https://docs.microsoft.com/en-us/azure/iot-edge/how-to-vs-code-develop-module
Section :Debug module in launch mode
Perform Step 3
I see it is still issue with doc as performed steps according to docs.

Adding @marianan to investigate. Thanks for reporting the issue with detailed info!

Thanks @shizn i will take over the investigations here. ETA on next update 9/28.

@marianan Is there any update on this issue?

@sharbt We investigated this. The following curl command works as expected:
curl --header "Content-Type: application/json" --request POST --data '{"inputName": <Solution_Name>,"data":[{"created_at":"2018-01-30 10:26:2 -0500","field1":"1.0","field2":"2.0"},{"created_at":"2018-02-02 11:27:27 -0500","field1":"1.1","field2":"2.2","status":"well done"}]}' http://localhost:53000/api/v1/messages
I tried the above command in Cygwin and it gives the "message accepted" response. You may be facing issues because of the newline chars in your payload.
Will be great if you can try it out and let us know

@sharbt We investigated this. The following curl command works as expected:
curl --header "Content-Type: application/json" --request POST --data '{"inputName": <Solution_Name>,"data":[{"created_at":"2018-01-30 10:26:2 -0500","field1":"1.0","field2":"2.0"},{"created_at":"2018-02-02 11:27:27 -0500","field1":"1.1","field2":"2.2","status":"well done"}]}' http://localhost:53000/api/v1/messages
I tried the above command in Cygwin and it gives the "message accepted" response. You may be facing issues because of the newline chars in your payload.
Will be great if you can try it out and let us know

Ok can close now.

Ok can close now.

@MonikaReddy-MSFT I don't have the maintainer permissions, can you please close this issue. Many thanks.

@MonikaReddy-MSFT I don't have the maintainer permissions, can you please close this issue. Many thanks.


Contacts are duplicated in the list

Hopefully self-explanatory, but the contact list shows duplicate entries for the same person. I don't get it...

any news about this issue?


"Detailed Maven documentation" not present

Version affected
4.4
Describe the bug
No site generated documentation regarding goals, etc appears to be present.  I assume the site docs are what is meant by "Detailed Maven documentation" but cannot be sure.
As an aside, changes from 4.3 (previous version) seem like non-semver breaking configuration changes, but I could be wrong about that because I don't know what those configs are, at present.
How to Reproduce

Go to https://oss.carbou.me/license-maven-plugin
Search for "Detailed Maven documentat"
Click link
Go nowhere from there

Hello,
Do you mean that ?

Please do not hesitate to propose a change through a PR to improve if you feel it should be improved.
Thanks.

@mathieucarbou I think if you drill deep enough the maven site pages portion are not showing up and getting 404s.  At least that is what I saw but not sure if that was working before or not as not looked at in some time.

Oh that's right ! I have 404 errors too. Weird because I generated the site and uploaded it.
I will anyway remove the ref to 4.4 and replace it by 4.5 this weekend after the new release.
Thanks for pointing that out!

fixed!


API diff between .NET 8 Preview 5 and .NET 8 Preview 6

Known issues:

The AsmDiff tool sometimes skips adding { or {}. Please add a GitHub suggestion to correct it. arcade#10981
The AsmDiff tool shows APIs with decorating attribute changes as removed and re-added, instead of showing only the API. Please ignore this, it might be confusing but technically it's not incorrect. I have an issue to track this: arcade#13814

Repos area owners:

ASP.NET - @dotnet/aspnet-api-review
WinForms - @merriemcgaw @dreddy-work @JeremyKuhne
WPF - @singhashish-wpf and @pchaurasia14
Libraries - @jeffhandley @karelz @ericstj @stephentoub

Libraries area owners:

System @dotnet/area-system-runtime

System.Diagnostics.CodeAnalysis no area label, tagging most recent modifiers: @RussKie @stephentoub

System.Diagnostics.Metrics @tommcdon @noahfalk

System.Diagnostics.Tracing @tommcdon @noahfalk @tarekgh

System.Formats.Asn1 @dotnet/area-system-formats-asn1

System.IO.Compression @dotnet/area-system-io-compression

System.IO.Pipes No area label, tagging most recent modifiers: @MihaZupan

System.Net @dotnet/ncl

System.Numerics @dotnet/area-system-numerics

System.Runtime.CompilerServices: @dotnet/area-system-runtime-compilerservices

System.Runtime.InteropServices @dotnet/interop-contrib

System.Runtime.Intrinsics @dotnet/area-system-runtime-intrinsics

System.Security @dotnet/area-system-security

System.Text.Json @dotnet/area-system-text-json

System.Threading.Tasks @dotnet/area-system-threading-tasks

Microsoft.Extensions.Caching @dotnet/area-extensions-caching

Microsoft.Extensions.DependencyInjection @dotnet/area-extensions-dependencyinjection

Microsoft.Extensions.Diagnostics.Metrics @tommcdon @noahfalk

Microsoft.Extensions.Hosting @dotnet/area-extensions-hosting

Microsoft.Extensions.Logging @dotnet/area-extensions-logging

Microsoft.Extensions.Options @dotnet/area-extensions-options

Microsoft.Extensions.Primitives @dotnet/area-extensions-primitives

System.Diagnostics.Metrics LGTM.
@davmason can you please have a look at System.Diagnostics.Tracing?

System.Diagnostics.Tracing looks good


addUserSignedOut is not fired

I have used like follow in the component.
  const oidcData = useAuth();
But the addUserSignedOut  is not fired.
  useEffect(()=>{
      oidcData?.userManager?.events?.addUserSignedOut(() => {
        debugger;
        console.log(`User Signed Out - Event triggred at ${new Date()}`);
        handleLogout();
      });
  },[]);

### Tasks

Could you provide a full reproduction of this?


How configuration of wascc host is handled by krustlet

wascc host needs to be configured by adding actor as well as capabilities to the host. One also needs to pass binding between the actor and the capability as shown in the tutorial.
How one can pass configurations, such as binding between the actor (via its public key) to the capabilities (such as key-value store or wascc messaging capabilities) in krustlet?

This is performed automatically via krustlet. The actor requests certain capabilities like wascc::logging or wascc::filesystem and Krustlet exposes Kubernetes's capabilities through this system. For example, volume mounts are provided as wascc::filesystem capabilities, and Services are provided as wascc::http capabilities.

FYI: the ticket on custom capabilities can be found here: https://github.com/deislabs/krustlet/issues/248


Versioning Strategy

A versioning strategy for releases. E.g. v1.0.0
MAJOR.MINOR.PATCH
Discuss if github releases are going to be used for this

I wrote a bit about it in 2.3.1 Versioning Strategy and is based on https://semver.org/spec/v2.0.0.html


Cannot input Phonetic anymore

Way to reproduce: press the following key sequence when Phonetic is enabled:

  1 (ㄅ)
  2 (ㄉ)
  Down key

Then ㄅㄉ is shown. However, if you pres Up key, the ㄅㄉ is repeated
unexpectedly. If you try to enter another symbols, it only shows symbols
instead of Chinese character. Like

  ㄕㄥㄉ  where ㄉ is what I meant to select the 2nd candidate character in list.

Original issue reported on code.google.com by<EMAIL_ADDRESS>on 4 Sep 2013 at 2:45

Fixed by kcwu
https://code.google.com/p/jscin/source/detail?r=7ba2934b192110ee18c43cf689aee41d
9d9c6376

Original comment by<EMAIL_ADDRESS>on 11 Sep 2013 at 10:14

Changed state: Fixed

Thanks!

Original comment by<EMAIL_ADDRESS>on 12 Sep 2013 at 10:30


Members prefixed "£" not loading

Good Afternoon - A Newbie here,
I'm hoping I could get some help?
Members appear in the Object Browser, but then fail to load with "The editor could not be opened because the file was not found."
I wonder if it's a CCSID problem?
This appeared mid-workday with my open members appearing red and crossed through as I worked. On trying to save:
Failed to save '£PGM.RPGLE': Unable to resolve nonexistent file 'member:/DEV/QRPGLESRC/£PGM.RPGLE?readonly=false&position='

Context
Version

Code for IBM i version
2.13.5

Visual Studio Code version
1.93.1

Operating System
win32_x64

Active extensions
COBOL (cobol): 24.10.5
Code for IBM i Walkthroughs (vscode-ibmi-walkthroughs): 0.5.0
Configuration Editing (configuration-editing): 1.0.0
Db2 for IBM i (vscode-db2i): 1.6.0
Emmet (emmet): 1.0.0
Error Lens (errorlens): 3.20.0
Git (git): 1.0.0
Git Base (git-base): 1.0.0
GitHub (github): 0.0.1
IBM i Debug (ibmidebug): 2.0.1
JSON Language Features (json-language-features): 1.0.0
Merge Conflict (merge-conflict): 1.0.0
Node Debug Auto-attach (debug-auto-launch): 1.0.0
RPGLE (vscode-rpgle): 0.26.12
Server Ready Action (debug-server-ready): 1.0.0
TODO Highlight (vscode-todo-highlight): 1.0.5
TypeScript and JavaScript Language Features (typescript-language-features): 1.0.0

Remote system

Setting
Value

IBM i OS
V7R4M0

Tech Refresh
9

CCSID Origin
1146

Runtime CCSID
1146

Default CCSID
1146

SQL
Enabled

Source dates
Disabled

Please share the contents of your Code for IBM i output channel after the doesn't work.

There's nothing here:

@ANSMAN-C
You need to select Code for IBM i in the dropdown.  You have Tasks selected.

Looks like a bug to me. I will assign and take a look on Monday.

This line right here: https://github.com/codefori/vscode-ibmi/blob/7562569637bafae651c76a399fe3cc90f33ba1f4/src/api/IBMiContent.ts#L955

Thanks for the support with this.


processing provider for QGS2 version (#41)

Adds the processing integration.
For now only the isochrones API is exposed, as this is the only API i need right now.
I might find time to add the other ORS APIs later on, but no promises.
Implemented against the QGIS2 interfaces, as explained in https://github.com/nilsnolde/OSMtools/issues/41#issuecomment-366950773.
I am not familiar with the QGIS3 API yet, so you might be faster at back-backporting this.

Thanks. I just gave it a rough read, looks pretty good! Will try it out over the next days.
Before it's not all implemented, migrating to v3 is not so sensible I find. Maybe someone else will take on implementing directions and matrix, if we don't have the time.. I'm fed up for a few weeks tbh;)

No hurry, thanks a lot for your effort to backport this so quickly!


Add deployment examples to docs

Description
Add terraform deployment examples to docs.
Fixes #581
Type of change
Please delete options that are not relevant.

[x] This change requires a documentation update

How Has This Been Tested?
Please also list any relevant details for your test configuration
Checklist

[x] Updated documentation if needed(https://www.atlassian.com/git/tutorials/rewriting-history)

This change is

For the actual documentation site, the bar for clarity is very high, hence many small things that would seem nit-like in ordinary code comments or even early GitHub README's that are not actually nits.

Agreed if we're gonna automate keeping these in-sync later we're gonna have to employ the msame standards for both. I realize these are older READMEs though


Fixes #310 "Other" IR Devices send commandOn and commandOff at reversed times

As far as I can tell this fix makes sense but I have no idea how to test it on my local setup, sorry.

I have pushed this to beta. you can test this on the latest beta version and let me know if it works for you?

Thank you, I can confirm that this works on v1.12.9-beta.23!

Great. Thank you!

@donavanbecker I found another related bug (close enough that I don't think it needs another issue) - right now the code assumes that any instruction is a toggle of the device's state, so it works fine with simple switches but may send the wrong signal when using scenes.
I can cook up a fix, but I would like to ask for your input on what the desired behavior should be before I do it.
If, for example, a device is already "off", would you prefer that:

an "off" IR signal should be sent anyway
nothing should be done

I guess we could make a config that would say do you want 1 or do you want 2 then users can choose.

Yes I have. I actually have a config called allow push for one of the other devices. But it's a SwitchBot device not Ir, so might as well add it. So we do not send, and only send when allowPush is yes in config.

@jonzhan if you wanna put a PR together. I will ad the allowPush config

@donavanbecker Sounds good. I'll get a PR over in a day or so!

No rush. Also have you upgraded to v2.0.0?

Ooh no, I didn’t realize there was a point release. Nice! Good to have the BLE fallback.

On 13 Oct 2022, at 8:38 PM, Donavan Becker @.***> wrote:

No rush. Also have you upgraded to v2.0.0?
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you were mentioned.

that was always there before but kinda changed things up on it.

I upgraded to 2.0 but unfortunately it has broken my IR devices, whoops! I'll make a separate ticket and circle back to this after that's figured out.

@jonzhan V2.1.0 should have fixed that?

hmm unfortunately not - I have also tried v2.1.1-beta.0 with no luck!

On 14 Oct 2022, at 6:59 PM, Donavan Becker @.***> wrote:
@jonzhan https://github.com/jonzhan V2.1.0 should have fixed that?
—
Reply to this email directly, view it on GitHub https://github.com/OpenWonderLabs/homebridge-switchbot/pull/311#issuecomment-1278851992, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAACK4VLPYBERSIBF6RRP2DWDE4K5ANCNFSM5TFWFX2Q.
You are receiving this because you were mentioned.

@jonzhan sorry. Okay once you open the ticket I will take a look.

No worries, wonder what it is! Created #520

I've made a bunch of changes to support allowPush in this PR - would appreciate a quick review as I mostly inferred the necessary properties and logic based on the allowPush implementation in bot.ts.

Okay latest beta should have the right change... I think.


Draw Vertices Buffer Size

Can the buffer size for vertices indices be increased? We are seeing corrupted meshes and I believe the issue is that on the engine side the indices buffer is limited to uint16_t:
https://github.com/flutter/engine/blob/4b9966f5cb412a73fa50462b3aee9082f436a62a/lib/ui/painting/vertices.cc#L81
If this is the issue, than the amount of triangles that can be drawn in one call is ~22k. So when an Int32List of more than 65535 indices are passed, there will be overflow.

To match the integer size passed into Vertices and Vertices.raw, it should be int32_t. Additionally, maybe it would be better to change the Vertices constructors to take in a Uint32List as opposed to Int32List to ensure positive indices, then DecodeInts could use uint32_t.

The uint16_t limit is actually on the Skia side, that is why DecodeInts is casting to uint16_t.
This makes the api for Vertices and Vertices.raw a little misleading by allowing an Int32List to be passed (both in size and signed form). I have opened a Skia issue here to increase the index size:
https://bugs.chromium.org/p/skia/issues/detail?id=8993&q=&sort=-id&colspec=ID%20Type%20Status%20Priority%20M%20Area%20Owner%20Summary
Apologies for the confusion caused, but I think the Vertices constructors should be altered to reflect the format Skia expects, or hopefully, Skia can increase the index limit and Flutter can change DecodeInts to use uint32_t.


update jsdom to 12.x

jsdom 12.x introduces shadow DOM support (finally).
this means we can potentially now test web components and what not, using jest.
edit:
it seems this means we wouldn't be able to support node <8 anymore as jsdom has a requirement on it.
what do you suggest we do about that?

it seems this means we wouldn't be able to support node <8 anymore as jsdom has a requirement on it.

Unfortunately, that means we won't land the upgrade for some time. In the meantime you can create your own environment using jsdom 12, similar to what was done before we upgraded to JSDOM 10: https://www.npmjs.com/package/jest-environment-jsdom-latest


MBL-766: FrequentlyAskedQuestionsViewHolderViewModel.kt to Jetpack ViewModel and RxJava2.2

📲 What
Migration to rxjava 2.2 and jetpacks viewmodel
🤔 Why
Technical Details
👀 See
No user facing changes
📋 QA

Find a project with FAQ questions (I used "Campster 2 the portable chair for everyone everywhere")
Make sure you can view the FAQ tab, that there are no crashes, formatting is okay, scrolling works, etc.

Story 📖
MBL-766: FrequentlyAskedQuestionsViewHolderViewModel.kt to Jetpack ViewModel and RxJava2.2

Looks good other than the disposables in FrequentlyAskedQuestionsViewHolder.kt dont seem to be cleared anywhere

Done! Good catch :)


Navigate through //MARK: label and //#region label with keyboard only

When adding //MARK: label in the code, a label item is added in the minimap, that's great.
What would be really nice is to be able to navigate to those MARK/regions using only the keyboard.
One place where those could be added is in Command Palette Symbol search.
There could also be keyboard shortcuts to navigate to next/previous MARK/region in the current file

I created a slight variation of this feature request - #210018 for those MARksto appear also in Outline View so you can hit Ctrl+Shift+O and search for relevant MARK.

Would like this keybind too! Even if they end in the outline, etc.

This feature request is now a candidate for our backlog. The community has 60 days to upvote the issue. If it receives 20 upvotes we will move it to our backlog. If not, we will close it. To learn more about how we handle feature requests, please see our documentation.
Happy Coding!


viz.plot_compare_evokeds() calculates RMS for all channel types, but claims to be calculating GFP

This is a similar issue to the one fixed via #8775
Currently, viz.plot_compare_evokeds()'s combine='gfp' argument makes it compute RMS, not GFP.
However, it should calculate GFP for EEG and RMS for MEG data. The combine='gfp' option should remain unchanged and simply pick the correct calculation depending on the channel type(s). This means that in case of M/EEG data, we'd have to apply different combine functions per subplot, so this is not a totally non-trivial change as far as I can tell (but might be wrong).

I can work on this!

This is actually not a super trivial issue and might require a bit of refactoring the current plotting code. I can give you a brief summary hopefully later today


Request for new task to merge OTU's

Feature or enhancement
I thought we had an open issue on this, but I can't find it.
We need a task to merge information from two or more OTU's.  For example, check out Prochiloneurus dactylopii and P. dactylopiione (the latter renamed by me to simplify telling which is which) in the UCD.  These are two taxon names with the same author and date, with two (actually three) OTU's with non-overlapping data.  There is a Merge Taxon Names task which I applied to them and which seemed to work in part but not completely.  This is a rather complicated case that would be difficult to resolve manually.
We also created numerous OTU's with identical names tied to the same taxon name when we were eliminating ghosts caused by verbatim host records in UCD.
Location
Task - merge OTU's
Screenshot, napkin sketch of interface, or conceptual description
No response
Your role
Curator of UCD project in TW

Now duplicated and covered in https://github.com/SpeciesFileGroup/taxonworks/issues/970


Fix FutureWarnings of scikit-learn

Thank you for your PR.
Could you execute autopep8 -ir . for fixing the CI failure?


Consider refactor: convert resource(s) into module

I thought we had an issue for adding "extract module", but I couldn't find it. This would be a great addition.