[Setting Sync] Lost remote settings and automatic delete local settings. Crazy

VS Code Version: 1.73.1
OS Version: macOS 13.0.1

Steps to Reproduce:

I opened the new install vscode and opened it to sync, then notified me to restart vscode. And then, I lost all remote settings. Crazy.

A new empty setting sync and replace remote settings, and I page down all synced data, all older settings are missing.

I realized something was wrong and immediately opened vscode on the second computer to copy the local configuration on the second computer, but it synced immediately, replacing the second computer's local setting. So I lost my vscode setting forever.
How can I find my settings. And why is there such a low-level bug

I opened the new install vscode and opened it to sync, then notified me to restart vscode. And then, I lost all remote settings. Crazy.

Can you please elaborate on this? Are you able to reproduce this?
You can get back your data from the history (shown in the above pictures), for eg:

I opened the new install vscode and opened it to sync, then notified me to restart vscode. And then, I lost all remote settings. Crazy.

Can you please elaborate on this? Are you able to reproduce this?
You can get back your data from the history (shown in the above pictures), for eg:

No, can't. Because my history settings all gone, I don't know why, but it's all gone. Only the nearest ones, and they're all blank settings.
Now, I find my last week settings on my another mac, I just cutting down network then open vscode, got my setting.

Can you please elaborate on this? Are you able to reproduce this? We would like to understand the issue and see if we can fix it.


Total percentage of column sizes passed to onResizeFinished is more than 100%

Something funny is going on where the total percentage of newSizes in onResizeFinished is more than 100%.

Also, setting initialSizes back to the value passed in to onResizeFinished results in the column jittering visually. There is some kind of scale difference between newSizes and initialSizes


Does not compile

On commit 7537cfb92128df82e26d14197bfdd87f8b72a0e6
Using node v14.17.4
TS2786: 'Chart' cannot be used as a JSX component.
  Its instance type 'ReactApexChart' is not a valid JSX element.
    The types returned by 'render()' are incompatible between these types.
      Type 'React.ReactNode' is not assignable to type 'import("/Users/nikunj/git/tokyo-free-white-react-admin-dashboard/node_modules/@types/react-transition-group/node_modules/@types/react/index").ReactNode'.

This is caused by dependencies that pull the latest version of types/react. Add this to your package.json at the top level
 "resolutions": {
    "@types/react": "^17.0.38"
  },


Avoid or replace all GUI elements that rely on synthesized mouse events

With multiple fingers on the screen, synthesized mouse do not work at all or are very unreliable.
Thus every gui element should handle touch events explicitly, and possibly ignore synthesized events.
The main problems are in the function menu and the circle context menu.

As of PR #383, all elements to be used by multiple people work without synthesized mouse event.


vs code "Sentinel kind: Expired" when looking at large object structure

Steps to reproduce

I have recreated the problem. you can find the code here. https://github.com/QCIPaulCardno/SentinelKindExpiredIssue2024.git. just the main.dart is all you need.
To reproduce. put a breakpoint on line 99. Run the app. Press the plus button
When it stops. Goto the variables (run and debug). Expand out globals. expand out complexObject. Expand out dicByDayOfFloorIDs, expand "0", expand values. and then you will see the message "[Sentinel kind: Expired, valueAsString: ] from invoke()"
If you reduce the size of this class by changing count from 10000 to 1000 line 113 in the for loop. and then run again it all works as expected.

Other notes

I tried beta channel but same result as stable.
here is flutter doctor -v
[✓] Flutter (Channel beta, 3.19.0-0.4.pre, on macOS 14.2.1 23C71 darwin-arm64, locale en-NZ)
• Flutter version 3.19.0-0.4.pre on channel beta at /Users/xxx
• Upstream repository https://github.com/xxx
• Framework revision b7e7d46a04 (10 days ago), 2024-02-02 08:21:06 -0600
• Engine revision 98820f0a77
• Dart version 3.3.0 (build 3.3.0-279.3.beta)
• DevTools version 2.31.0

[!] Android toolchain - develop for Android devices (Android SDK version 30.0.2)
• Android SDK at /Users/paulcardno/Library/Android/sdk
✗ cmdline-tools component is missing
Run path/to/sdkmanager --install "cmdline-tools;latest"
See https://developer.android.com/studio/command-line for more details.
✗ Android license status unknown.
Run flutter doctor --android-licenses to accept the SDK licenses.
See https://flutter.dev/docs/get-started/install/macos#android-setup for more details.
[✓] Xcode - develop for iOS and macOS (Xcode 15.2)
• Xcode at /Applications/Xcode.app/Contents/Developer
• Build 15C500b
• CocoaPods version 1.13.0
[✓] Chrome - develop for the web
• Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome
[✓] Android Studio (version 4.1)
• Android Studio at /Applications/Android Studio.app/Contents
• Flutter plugin can be installed from:
🔨 https://plugins.jetbrains.com/plugin/9212-flutter
• Dart plugin can be installed from:
🔨 https://plugins.jetbrains.com/plugin/6351-dart
• Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6222593)
[✓] VS Code (version 1.86.0)
• VS Code at /Applications/Visual Studio Code.app/Contents
• Flutter extension version 3.82.0
[✓] VS Code (version 1.83.1)
• VS Code at /Users/paulcardno/Downloads/Visual Studio Code.app/Contents
• Flutter extension version 3.82.0
[✓] Connected device (2 available)
• macOS (desktop) • macos  • darwin-arm64   • macOS 14.2.1 23C71 darwin-arm64
• Chrome (web)    • chrome • web-javascript • Google Chrome 119.0.6045.105
! Error: Browsing on the local area network for iPad_pac. Ensure the device is unlocked and attached with a cable or associated with the same local area network as this Mac.
The device must be opted into Developer Mode to connect wirelessly. (code -27)
[✓] Network resources
• All expected network resources are available.

Running on a mac
Apple M1 Max
64 GB
Macintosh HD
14.2.1 (23C71)

Expected results
I would expect to be able to view all the data in complexObject
Actual results
I expect to see all the data in the complexObject
Code sample
Code sample
[Paste your code here]

Screenshots or Video

Logs
Logs
[Paste your logs here]

Flutter Doctor output
Doctor output
[Paste your output here]

Thanks for the report @QCIPaulCardno
I think this probably will belong to dart-lang repo, as Sentinel comes from vm_service which belongs to dart. Also, it probably replicates without using flutter widgets (ie, only using dart), so you'll need to report this in dedicated repo. https://github.com/dart-lang/sdk/issues
If you disagree, or get directed here again, write in comments and I'll reopen it.


Remove six

Just a quick patch to get rid of six, as discussed in #61.

If I'm OK to push small things like this in future let me know, and I'll stop bugging everybody else.

nice.  this looks good to me
I would encourage not merging one's own pull request unless it is a trivial documentation change or something.  If it is something small like this and you are not getting feedback, I would just state something like "will merge in 2 days unless there are any objections".  I will plan to merge this one on Monday or Tuesday to give some time for other feedback.

Nice, good to get rid of six


Slipstream done, finally

Awesome investigation work. I went with a different solution in #3110 but I used the findings here to figure out what needed to be done.


Add pyproject.toml for Custom Node Registry

We are working with dr.lt.data and comfyanon to build a global registry for custom nodes (similar to PyPI). Eventually, the registry will be used as a backend for the UI-manager. All nodes go through a verification process before being published to users.
The main benefits are that authors can

publish nodes by version and users can safely update nodes knowing ahead of time if their workflows will break or not
automate testing against new commits in the comfy repo and existing workflows through our CI/CD dashboard

Action Required:

[ ] Go to the registry. Login and create a publisher id (everything after the @ sign on your registry profile).
[ ] Add the publisher id into the pyproject.toml file.
[ ] Merge the separate Github Actions PR, then merge this PR.

If you want to publish the node manually, install the cli by running pip install comfy-cli, then run comfy node publish
Check out our docs if you want to know more about the registry. Otherwise, feel free to message me on discord at haohao_81202 or join our server if you have any questions!

hey @Hangover3832, wanted to send a small nudge and ask if you had any questions!

@Hangover3832, wondering if there's any way we can support you on this PR!


more examples

[ ] line collection

We don't need this, line collection and line stack examples are in: https://github.com/fastplotlib/fastplotlib/tree/master/examples/desktop/line_collection
also in the selector example nbs


Updates for clang

PR Type

[ ] Breaking change
[ ] Feature
[x] Patch

Brief Description
Changes to get building and testing with clang working for Utilities. This also resolves #68 for both clang and GCC. Also resolves #115.
Not In Scope
PR Checklist

[x] Is documented
[x] Is tested
[x] Adheres to applicable organization standards

🚀 [bumpr] Bumped! New version:v0.1.1 Changes:v0.1.0...v0.1.1


RD dresser on core isnt RD dresser

Description
Title. It's just filled with random things
Reproduction

RD
core :agony:
no beret :(

Screenshots

Additional context

@UbaserB :trollface:

i go fix


Update CLI.md

Exchanged not supported --no-cache with correct command.
Summary
Disabling the cache.
Test plan
Running jest --no-cache throws
● Unrecognized CLI Parameter:

  Unrecognized option "noCache".

  CLI Options Documentation:
  https://jestjs.io/docs/cli

To disable cache use jest --debug --cache=false with debug output:
{
  "configs": [
    {
      "automock": false,
      "cache": false,
     ....

@Theiaz Can it be that you got that error running jest --noCache? This should throw an error.
I just tried out to be sure and it seems that --no-cache flag works as expected. It is simply a shorter version of --cache=false. You can use either of them.

Oh man, you're right. I've ran jest --noCache. Closing this PR...


Version update to 1.2.0

Coverage decreased (-0.04%) to 87.625% when pulling 82ea5e1cd4a3418ee4aed7e0634745d200087775 on jeronimoalbi:develop into 4a0d9fb72ba109b83bf6f29659e79fe03107b3b0 on kusanagi:master.


When installer fails

When an installer fails to install the package should not be put in the lib folder or be removed from the lib folder.

Migrated notes from #15:
I tried to install cUrl, but the package was not found and thus the install failed.
When running cup all, I'm getting this:
curl does not appear to be on (https://go.microsoft.com/fwlink/?LinkID=206669). You have 7.21.7 installed. Interesting...

@henningc - I did log another issue for you on what you are experiencing - https://github.com/chocolatey/chocolatey/issues/16 - I also closed it with chocolatey <IP_ADDRESS> (which you can get with cup)

Awesome, thanks
On Fri, Oct 14, 2011 at 1:57 PM, Rob Reynolds <
<EMAIL_ADDRESS>
@henningc - I did log another issue for you on what you are experiencing -
https://github.com/chocolatey/chocolatey/issues/16 - I also closed it with
chocolatey <IP_ADDRESS> (which you can get with cup)
--
Reply to this email directly or view it on GitHub:
https://github.com/chocolatey/chocolatey/issues/10#issuecomment-2405846

Yeah I just ran into this, I don't think it's fully fixed.

@mkmurray let's chat on chocolatey/choco, ensure you are on 0.9.10.x.

What you are seeing is likely a different issue and definitely not over here on the old POSH version. Https://github.com/chocolatey/choco/issues/new


Do not sent a separate request for /positions

Once this ticket is done, we can update aries-key-guardian to no longer send a separate request to get the best positions on a fingerprint match failure.

closing due to project shutdown


Deprecate Authors::users field

From the crates.io source:

It was imagined that we wold associate authors with users. This was never implemented. This complicated return struct is all that is left, hear for backwards compatibility.

To reduce confusion it would be good to deprecate the users field on Authors since it is never planned to be anything other than an empty list.

Will be removed in the next release.


feat(MeasureTheory): define semi-rings of sets

A semi-ring of sets C (in the sense of measure theory) is a family of sets containing ∅, stable by intersection and such that for all s, t ∈ C, s \ t is equal to a disjoint union of finitely many sets in C.
Co-authored-by: Peter Pfaffelhuber<EMAIL_ADDRESS>Part of the formalization of the Kolmogorov Extension theorem.

The next step is to define contents on semirings. Mathlib already has a definition MeasureTheory.Content but only for contents on compact sets.

Does this generalization make any sense?
structure IsSetSemiring (C : Set α) [CoheytingAlgebra α] : Prop where
  bot_mem : ⊥ ∈ C
  inf_mem : ∀ s ∈ C, ∀ t ∈ C, s ⊓ t ∈ C
  diff_eq_sup :
    ∀ t ∈ C, ∀ s ∈ C, ∃ I : Finset α, ↑I ⊆ C ∧ (I : Set α).PairwiseDisjoint id ∧ t \ s = I.sup id

I know about that concept of semirings of sets only from measure theory, and in that context it's only for sets. I don't know if your generalization to CoheytingAlgebra is useful for anything.

The main use would be that it would then also work for Finset, but perhaps that's of no interest. Maybe @YaelDillies has opinions.

I know of no use in this direction. Although there are a lot of similar definitions that I do need, semirings of sets are pretty specific.
Btw, I'm surprised we don't have semirings of sets already!

Also if you know another use for semirings of sets in this sense (which is not the existing SetSemiring) outside of measure theory, please tell me. If that's the case then I should place the file somewhere else.

bors r+
Thanks!


File Preview Pane Error (.pdf, .txt)

Microsoft PowerToys version
V0.71.0
Installation method
GitHub, PowerToys auto-update
Running as admin
Yes
Area(s) with issue?
File Explorer: Preview Pane
Steps to reproduce
When the option (Portable Document Format .pdf, .txt) is enabled, a problem occurs in the Preview Panel where the PDF file and TXT file is not displayed in full screen, leaving a blank area. This issue can be fixed by manually resizing the Preview Panel or resizing the window. However, when opening another file, the error occurs again.

✔ Expected Behavior
To prevent the blank space from appearing and display the complete file as shown in the "NO ERROR" image.
❌ Actual Behavior
The blank space is appearing as shown in the image "WITH ERROR".
Other Software
The only tool or software that is running together and could interfere would be the Windows Display Panel itself.

PDF and Text files are different and different viewers.  i believe you'll get a better PDF viewing experience with out using the PowerToys viewer here.
Looking at this, the preview pane handler isn't taking over the entire pane which is outside our control too.  I don't think this is anythign we can do to fix it.


[Patcher APIs] Custom React elements for icons

Reposted as an issue from #21:
Instead of just a link, you could instead do something like this:
goosemod.patcher.channelTextAreaButtons.patch("Tooltip Text", React.createElement("svg", {
        xmlns: "http://www.w3.org/2000/svg",
        height: "24",
        viewBox: "0 0 24 24",
        width: "24",
    }, React.createElement("path", {
        d: "...",
        fill: "currentColor",
    })), (props) => {});

Added in referenced commit.

Added in referenced commit.


Remove extra definitions for U+005e (^), U+0060 (`) and U+007e (~)

Fixes #4.

This disables the deadkey combinations for ^, `, and ~ with AltGr, though, right? That defeats the purpose of this keyboard layout.

No, it disables the combinations that are used to type the individual characters in the original "United States-International" layout.
They are not needed in this layout because the individual characters are always typed unless another key is pressed.
In the original layout, instead, you have to press the key two times in order to type it (and it acts as a double-press).

Sorry, I didn't realize when I tested the layout that the old DLL was still being used.
Turns out KLC automatically removes the dead-key settings if you don't set a code point...

Done: #6


Cron Jobs

Description
Changes proposed in this pull request:

Add list & details for Cron Jobs

For Jobs on CJ's details view I possibly could take (the Jobs from cronJob.status.active array) instead of (fetching and filtering all the Jobs in the namespace), but the latter are full objects, so we can see creation timestamp, labels, have entire YAML to edit etc.

Move Deployments components to folder for consistency
Use jsyaml.load instead of jsyaml.safeLoad - the latter is deprecated and throws an error now.

Testing
You can use following cronjob (the one from k8s wiki)
apiVersion: batch/v1beta1
kind: CronJob
metadata:
  name: hello
spec:
  schedule: "*/1 * * * *"
  jobTemplate:
    spec:
      template:
        spec:
          containers:
          - name: hello
            image: busybox
            imagePullPolicy: IfNotPresent
            command:
            - /bin/sh
            - -c
            - date; echo Hello from the Kubernetes cluster
          restartPolicy: OnFailure

/retest

/test pre-busola-integration-test-k3s


feat: Add interfaces for lifecycle hooks like in Angular itself

Feature Request
Ionic version:
[x] 4.x
Describe the Feature Request
Ionic's lifecycle hooks are missing interfaces describing them. This has few disadvantages:

No type checking (possibility to have typos)
No documentation available in code (compare e.g. navigating to source of OnInit)
Poor editor support

Describe Preferred Solution
Introduce the following interface somewhere in Ionic code base for it to be importable in the apps:
/**
 * A lifecycle hook that is called when the component routing to is about to animate into view.
 */
export interface ViewWillEnter {
  ionViewWillEnter(): void;
}

/**
 * A lifecycle hook that is called when the component routing to has finished animating.
 */
export interface ViewDidEnter {
  ionViewDidEnter(): void;
}

/**
 * A lifecycle hook that is called when the component routing from is about to animate.
 */
export interface ViewWillLeave {
  ionViewWillLeave(): void;
}

/**
 * A lifecycle hook that is called when the component routing to has finished animating.
 */
export interface ViewDidLeave {
  ionViewDidLeave(): void;
}

Additional Context
Angular rationale for having the interfaces available and recommended to be used.

Thanks for the issue. I am going to close this as a duplicate of https://github.com/ionic-team/ionic/issues/18043.


Login and password authentication

Good day!
What about authentication with callback answer before connecting to Room?
I haven't finded it in examples

Hey @Geppard, did you get a chance to check the auth example on colyseus-examples? Cheers

I think this is about having the opportunity to pass the login and password parameters to the "opions" and process them at the clientVerify on server, not the room.
There was an issue about colysesus.js
https://github.com/colyseus/colyseus.js/pull/41#issuecomment-433667916
So, if we look at the unity3d client, we will see that there no possibility to pass "options" (the client on first connection have no parameters)
https://github.com/colyseus/colyseus-unity3d/blob/master/Assets/Plugins/Colyseus/Client.cs#L70
{
    this.id = id;
    this.endpoint = new UriBuilder(new Uri (endpoint));
    this.connection = CreateConnection();
    this.connection.OnClose += (object sender, EventArgs e) => this.OnClose.Invoke(sender, e);
}

https://github.com/colyseus/colyseus-unity3d/blob/master/Assets/Plugins/Colyseus/Client.cs#L159
protected Connection CreateConnection (string path = "", Dictionary<string, object> options = null)


Add CompoundPluginDescriptorFinder

A POC (proof of concept) for https://github.com/decebals/pf4j/issues/143#issuecomment-332331245.

Coverage decreased (-0.2%) to 54.644% when pulling af6e3c8ecef05596efd32c6857371dede78fa918 on compound into da346cf715b98560120fd2b3c531199f3ff58d37 on master.

Coverage increased (+0.3%) to 55.196% when pulling 9b2e49666f45e77d5aea3537d64498babea368a4 on compound into da346cf715b98560120fd2b3c531199f3ff58d37 on master.

Looks nice. I can give more feedback once I try to move from my homegrown solution to this one. But that won't happen until next week or so.

Coverage increased (+0.3%) to 55.184% when pulling 8db677b614bec230e9f41429d2184ea7630bbcf9 on compound into da346cf715b98560120fd2b3c531199f3ff58d37 on master.

Coverage increased (+0.3%) to 55.184% when pulling 95d3d1e1def6b05b6640652e02ddeba48e6f8f74 on compound into da346cf715b98560120fd2b3c531199f3ff58d37 on master.

Coverage increased (+0.3%) to 55.184% when pulling 01fa88fccf0ae9f11f711e31730d7229cd2ced3c on compound into da346cf715b98560120fd2b3c531199f3ff58d37 on master.

Coverage increased (+0.4%) to 55.241% when pulling 482b32c5b57209cda61970a452c18471e268d580 on compound into da346cf715b98560120fd2b3c531199f3ff58d37 on master.

Coverage increased (+0.7%) to 55.518% when pulling 1a0b58509f4cafc28ce604573318e466dbec38ed on compound into da346cf715b98560120fd2b3c531199f3ff58d37 on master.


name format issue for Shasta County, CA on 04/02

File:  data.csv
Issue:

state listed as "CA"
country listed as "USA"
stateId and countryId iso missing

Good catch! This was the test county for fips conversion and it was using fips: code.

@lazd it's fixed in PR.


docs: add comment to duplicate DEPRECATED tag

Hello !
As stated in this issue, the documentation contains a duplicated DEPRECATED tag which prevents some systems from building the plugins correctly.
I've added a comment to one of the tags saying to configure the servers through lsp-config directly (as it had been done for previous deprecated functions).
Thank you for your work and your amazing plugin 😄

Ah, woops. Thanks! Fixed in https://github.com/williamboman/nvim-lsp-installer/commit/aee7e760d2970bf3e0e30194d5c26db355894580


What is the convention recommended for applying tooltip to multiple instances of a class?

CodePen demo

https://codepen.io/oshihirii/pen/NabOxd
Steps to reproduce the problem

var test = $(".frequency") does not work when passing to var myToolTip = new Tooltip(test, { ...
var test = $(".frequency").eq(0) does work
What is the convention recommended for applying tooltip to multiple instances of a class?  (in a jQuery environment)

What is the expected behavior?
That tooltip is applied to each instance of the class.
What went wrong?
Tooltip is not applied to each instance of the class.
Any other comments?

both Popper.js and Tooltip.js don't rely on jQuery, the most they do is to convert the jQuery element wrappers into native JS element references.
If you need to create multiple tooltips you will have to iterate through all of them:
$('.frequency').forEach(el => new Tooltip(el));


Richeditor Does not work in SliderOver and Markdown Does not work in Modals

Package
filament/filament
Package Version
3.2.115
Laravel Version
11.25.0
Livewire Version
3.5.6
PHP Version
8.3
Problem description
Hi
when you open a rich editor in a slide-over you can not add an image. it will show the image for a second but then it will disappear how every it works fine in a modal and it own page
Similarly, the markdown editor does not show in a modal but works correctly in Slideover and it own page
here a video (Rich editor in slideover)
Screencast from 2024-09-30 15-11-30.webm
Here image of Markdown in modal

Expected behavior
It should show the image and it should not disappear and in the case of markdown is should sho the markdown
Steps to reproduce
Step To Reproduces

Install a New Laravel Project
Install Filament Panels
Create a filament Resource
Remove the Create Page and Edit page so it opens in a modal & slide over respectively
Add RichEditor & Markdown to a Form
Add A ->sliderOver() to create form
you will see the image can not be uploaded to a rich editor in Create Slideover
and the Markdown editor will not be accessible in the edit Modal

Reproduction repository (issue will be closed if this is not valid)
https://github.com/sohailahmad07/filament-editors-bug
Relevant log output
No response

An update on the issue
Rich Editor
The rich editor image upload does not work because of the Grammarly extension but if you add these attributes to Trix editor tag
data-gramm="false"
data-gramm_editor="false"
data-enable-grammarly="false"
it should disable Grammarly

Fixed by https://github.com/filamentphp/filament/pull/14416.


Fix exception message (#6670)

Pull request opened by the merge tool on behalf of #6670

Merged into branches iso6 in c6b9ad84c52825f361441108bb3ecdcd974df975


ResolveDomNode for resolving links does not work correctly

@Simply007 sorry for the late reply. We've tested with your sample code in our project and I didn't work on a first try. Turned out it was related to the resolveDomNode.
resolveDomNode={(domNode, domToReact) => {           return
{domToReact([domNode])}
         }}
This piece of code broke the rendering of the links.
Meaning we can't wrap a link-element. We need to check on type of domNode and do a conditional wrapping. But still it fails to resolve the link element, even if we wrap with a p-tag.
Can you have a look at that case?
Originally posted by @ref-kboone in https://github.com/Kentico/kontent-gatsby-packages/issues/180#issuecomment-847610851

Hey @ref-kboone,
I have created a separate issue for that to keep the discussions short and clear.
Could you provide values of the props you are passing to the RichText component so that I can make the test as accurate as possible for this use case? Or you can extend rich text components tests yourself if you like to.

Hi!
This issue has gone quiet. 👻
It’s been a while since the last update here.
If we missed anything on this issue or if you want to keep it open, please reply here.
Thanks for being a part of the Kentico community!


Fix Type1 font parsing when .notdef is not at index zero

Fixes #11477
The PDF draws many space characters but the embedded fonts don't have a glyph named space, so .notdef should be drawn instead. PDF.js assumed that Type1 fonts define .notdef as the first glyph (index 0). However, now the fonts have the glyph A at index 0 and .notdef is the last one, so A appears where spaces are expected.
Because the rest of the font machinery in core/fonts.js assumes .notdef is at index zero, it's easiest to modify core/type1_parser.js so that it "repairs" fonts and makes sure .notdef is at index 0.
We are allowed to change the order of glyphs because Type1 fonts identify glyphs using glyph names instead of indices. PDF.js assigns indices to the glyphs when the Type1 parser has finished its job and returns an array of charstrings.
The Type1 Spec doesn't require that .notdef must be at index 0, so the fonts are not broken.

/botio-linux preview

/botio test

To prove that changing the order of glyphs causes no problems, I temporarily added this "shuffling" in the end of Type1Parser.prototype.extractFontProgram
if (program.charstrings.length >= 8) {
  console.log("Shuffling Type1 glyphs");
  const array = program.charstrings;
  let tmp;
  tmp = array[1]; array[1] = array[3]; array[3] = tmp;
  tmp = array[2]; array[2] = array[4]; array[4] = tmp;
  tmp = array[5]; array[5] = array[7]; array[7] = tmp;
}

The PDF from the issue still renders fine.

Thank you for fixing this!


Add a report descriptor builder

Requested in #20, cc @listentodella
This adds a new (currently draft) API to build a report descriptor programmatically. Mostly untested but there's enough to contemplate whether this is the best approach or not. Example from the patch:
use hidreport::hid::*;
use hidreport::types::*;

let mut builder = ReportDescriptorBuilder::new();
let rdesc: Vec<u8> = builder
        .append(UsagePage::from(0x1).into())
        .append(UsageId::from(0x1).into())
        .open_collection(CollectionItem::Application)
        .open_collection(CollectionItem::Physical)
        .push()
        .append(LogicalMinimum::from(0).into())
        .append(LogicalMaximum::from(1).into())
        .pop()
        .close_collection()
        .close_collection()
        .build();

To get the typechecking to work as expected there's a limit that we can only be 8 collections deep and one push/pop per collection "level" and no collection within a push/pop. That should be enough and only affects the type-safe approach as shown above, one can always manually add the collection/endcollection/push/pop to avoid those limits.
Thanks to the typestate pattern the compiler won't let us leave a collection or push/pop open. Mind you, the implementation feels like it should be possible to do this more sensibly, I just don't know how...
This also includes an API change to make things a bit nicer (will be broken out into a separate PR eventually).

really cool🎉！I'll try it when i was free

Ok, I think I'm happy with the current API, (from the module documentation) this looks like this now:
let mut builder = ReportDescriptorBuilder::new();
let rdesc: Vec<u8> = builder
       .usage_page(hut::UsagePage::GenericDesktop)
       .usage_id(hut::GenericDesktop::Mouse)
       .open_collection(CollectionItem::Application)
       .open_collection(CollectionItem::Physical)
       .push()
       .append(LogicalMinimum::from(0).into())
       .append(LogicalMaximum::from(128).into())
       .pop()
       .append(ReportCount::from(2).into())
       .append(ReportSize::from(8).into())
       .usage_id(hut::GenericDesktop::X)
       .usage_id(hut::GenericDesktop::Y)
       .input(ItemBuilder::new()
              .variable()
              .absolute()
              .input())
       .close_collection()
       .close_collection()
       .build();

This particular feature requires the hut crate from git so the usage_page and usage_id work correctly.
Does that look like a sensible API?

Ok, I think I'm happy with the current API, (from the module documentation) this looks like this now:
let mut builder = hidreport::hid::ReportDescriptorBuilder::new();
let rdesc: Vec<u8> = builder
       .usage_page(hut::UsagePage::GenericDesktop)
       .usage_id(hut::GenericDesktop::Mouse)
       .open_collection(CollectionItem::Application)
       .open_collection(CollectionItem::Physical)
       .push()
       .append(LogicalMinimum::from(0).into())
       .append(LogicalMaximum::from(128).into())
       .pop()
       .append(ReportCount::from(2).into())
       .append(ReportSize::from(8).into())
       .usage_id(hut::GenericDesktop::X)
       .usage_id(hut::GenericDesktop::Y)
       .input(ItemBuilder::new()
              .variable()
              .absolute()
              .input())
       .close_collection()
       .close_collection()
       .build();

This particular feature requires the hut crate from git so the usage_page and usage_id work correctly.
Does that look like a sensible API?
Note that this is currently a level lower than the normal ReportDescriptor parsing, it works on the per-item case - hence it's in the hid module, not the main crate. The next level could be some builder where we specify the fields one-by-one and the low-level bits are handled automatically on .build() but I haven't figured out how to best do that.

I am not sure if a more concise form will be available in the future, but at least for now, it does not appear to have complex new rules that would cause confusion. This is convenient for both the user's understanding and for learning to use it.


Can't order the entries.

I want to to able to display the entries in the order they are configured, it seems to reorder them to be Alphabetical which is not great (for me!).  Is it possible to not Alphabetise them or be able to disable the sorting?

@tomwoodhams - I've just begun to revisit looking into this module, so your suggestion was timely.
There's quite a lot of work which needs to be done to refactor and address several issues with the codebase.
However, the latest version, which I've just published does include initial support for disabling device sorting by updating to the latest version, adding sort: false, to the config options and restarting the mirror.
Let me know how you get on


Update navigationbar.md

replaced ControlState by MaterialState

Thanks for your PRs! Could you not create a new PR for every change please, but combine everything in one?

Why are you doing this @Benitmulindwa ?
MaterialState is now deprecated and has been replaced by ControlState, as I mentioned in the release of 0.23.0

@ndonkoHenri  ooh!! didn't know that,... thought I was using the latest flet version and was not getting ControlState. My bad!, I was using 0.22.0 version. 😑

Sorry for that.


add docs about Service annotation

Add more docs and examples about Service annotation which CCE CCM support.

/lgtm


Repeater validation fixes

makes custom validation always win, adds small message style for elements below a width threshold, and adds undocumented flag to suppress messages altogether
@anthonykoerber @dlasky @jcmoore

👍

IMHO - all strand-inline-messages should be set to layout=small, just to have some visual consistency... also  layout=small should probably be size=small but this is debatable (if this is an internal-only feature).
otherwise LGTM 👍

removing that index change, otherwise new patchset looks good to me.


CentOS 6.2 does not include platform family

For some reason the CentOS 6.2 json file does not include platform_family. I was under the impression that ohai would always assign a family.
https://github.com/customink/fauxhai/blob/master/lib/fauxhai/platforms/centos/6.2.json

I've recaptured all CentOS 6 releases using the latest Ohai so this will include platform_family now.  Once a new release of the gem is out you'll start to get 6.2 with platform family.


Fix controller API key header

This fixes the API key header setting being ignored, even when correctly configured, and makes the public endpoints protected.
Build and deployment configurations were also added: the files have been copied over as-is from the law-society-demo, omitting some of the default configurations that need to be tweaked for each deployment (e.g.: image namespace, route urls).

Fixes #24


HTTP: attach for file uploads does not work in the browser

Current implementation of attach does not work in the browser with File objects retrieved from <input type='file' />
The reason is that due to security reasons path and filename properties are not available to file objects:
> fileInput
<input type="file" multiple class="file">

> fileInput.files
FileList {0: File, length: 1}

>  fileInput.files[0]
File {
  name: "1324373_original.jpg",
  lastModified:<PHONE_NUMBER>000,
  lastModifiedDate: Thu Apr 07 2016 10:25:15 GMT+0200 (CEST),
  webkitRelativePath: "",
  size: 184841,
  _proto_: Blob
}

So, if we try to do this:
return {
  HTTP: Rx.Observable.just({
    url: '/upload',
    attach: [fileInput.files[0]],
    headers: {'Content-Type': 'multipart/form-data'}
  })
}

This will fail due to:
  if (attach !== null) {
    for (let i = attach.length - 1; i >= 0; i--) {
      const a = attach[i]
      request = request.attach(a.name, a.path, a.filename)
    }
  }

a.path and a.filename are undefined and will cause a crash in Superagent code.
A possible solution: allow formData in options/attach. Using code from  here
// vanilla JS

var files = document.getElementById('file_to_upload').files;
var formData = new FormData();

for (var key in files) {
    // is the item a File?
    if (files.hasOwnProperty(key) && files[key] instanceof File) {
        formData.append(key, files[key]);
    }
}

superagent.post('/some-url/')
  .send(formData)
  .end(function(err, response) {
    //upload done!
  });

Possible usage with HTTP:
return {
   HTTP: Rx.Observable.just({
      url: '/upload',
      formData: formData
   })
}

Or a five-line file upload driver :)
const makeFileDriver = (opts) => {
  const subj = new Rx.Subject()
  const xhr  = new XMLHttpRequest()
  xhr.open('POST', opts.location, true)

  xhr.onload = () => {
    if (xhr.status === 200) {
      subj.onNext({type: 'upload', success: true})
    } else {
      subj.onError({type: 'upload', success: false})
    }
  }

  return (files$) => {
    files$.map((files) => {
      const formData = new FormData()
      for (let i = 0; i < files.length; i++) {
        formData.append('files[]', files[i])
      }
      xhr.send(formData)
    }).subscribe()

    return subj
  }
}

@issuehuntfest has funded $40.00 to this issue. See it on IssueHunt

The http module works as it is when using formData,  but it is important to not set any Content-Type properties, either on the headers or type options when using multi-part files. Superagent handles content type automatically when sending files like this and setting those properties will cause the upload to fail. Just attached the extended formData object as shown below. This worked for me. The examples above showed some settings that will not work. Hope this helps.
Working Example
export function httpRequest(stateStream: Stream<State>): Stream<any> {
    return stateStream
        .map(function (state) {
            const data = new FormData()
            for (let i = 0; i < state.files.length; i++) {
                data.append('files', state.files[i])
            }
            return {
                url: 'http://localhost:3003/upload',
                method: 'POST',
                category: 'fileuploads',
                send: data,
                progress: true
            }
        })
}

@juniperchicago has submitted a pull request. See it on IssueHunt


App: High metallic values result in very dark models

glTF viewer, hdri skybox

in-app, webaverse

Metallics on models at high ranges will appear dark.
Current workaround that appears to work is to dial back metallic values to sub 0.500, and to fake the effect of reflections a bit, up the roughness. (could possibly add a seperate texture to do this, but that then goes against the ORM/RGB workflow for glTF)
With lighting and skybox support this will be less of an issue / non-issue

I wonder if adding more lights to the scene would help.

That, or intensity of existing lighting increased. The current light(s) are probably quite low, and since there's a lot of baked lighting / toon models being used at the moment, we wouldn't really notice it.

Via's engine research: https://github.com/webaverse/app/issues/1393#issuecomment-886689890


GC: Add config for using cms GET/POST and allow use with 1811

Instead of having a fallback that introduces errors and which is just a workaround, we will now use a config where the user can choose between true/false if they're using a legacy backend (1811) or the up to date one (1905+)
This will close GH-2705 and GH-2589

QA:

Make sure we can switch between POST and GET by changing the value in app.module.ts of legacy (true/false). Verify in the network tab (dev tools) if legacy is false (which is the default if not specified in app module), you will see in the network tab that the components?fields=.. is using the GET request. If it is true, then the user is saying they're using a legacy backend, such as 1811, and make sure in the network tab (dev tools), shows a POST request for the components.

Also, point your environment to an 1811 backend server, such as https://dev-com-17.accdemo.b2c.ydev.hybris.com:9002, and look at the network tab again to see that the post is being used and not failing.

PR: GH-2747

default is GET right?

Please assign to me for testing.

I am unable to confirm bug fix when deploying storefront from a linux dev-server and connecting to an 1811 backend.
I will let other team members verify as well and accept their decision.

this works for 1905, so we'll pass the ticket
i'll create a follow up for 1811

assigning to Brian for doc input

i was able to verify by pointing to dev5 and showing 'method' column in network tab, indeed we are using post when legacy = true and GEt when it's fasle
it kind of threw me because all the cms content was still appearing


Saving a snapshot command triggers a 500 error

https://www.loom.com/share/a4202db0ea984c78b73c9d21a3b64d3e

Thanks in advance :)

Fixed now - thanks.


Check for and eliminate mixed-order points in the Curve25519 implementation of OPRF

From the OPRF draft:
https://tools.ietf.org/html/draft-irtf-cfrg-voprf-04#section-2.1
It is convenient in cryptographic applications to instantiate such
prime-order groups using elliptic curves, such as those detailed in
[SEC2].  For some choices of elliptic curves (e.g. those detailed in
[RFC7748] require accounting for cofactors) there are some
implementation issues that introduce inherent discrepancies between
standard prime-order groups and the elliptic curve instantiation.  In
this document, all algorithms that we detail assume that the group is
a prime-order group, and this MUST be upheld by any implementer.
That is, any curve instantiation should be written such that any
discrepancies with a prime-order group instantiation are removed.
See Section 4 for advice corresponding to implementation of this
interface for specific definitions of elliptic curves.
=> Even though the consequences of a user providing a low or mixed order point to a server¹ are unclear to me, our "larger subgroup" curve25519 implementation of group just relies on the fact its provided generator has a codomain that's torsion-free, but does not check a user's submission is torsion-free
¹: they do reveal their pw in the low order case

Edit: I actually think small order point eviction is the main factor.


Outdated Tweepy API in "Auto-Ingest Twitter Data into Snowflake" Quickstart

Hi there,
I have tried following this quickstart which should be pretty straightforward, however I am facing issues which I believe are linked to Tweepy having updated their docs: https://docs.tweepy.org/en/stable/streaming.html as well as Twitter having updated their API version and permissions.
Following the exact instructions in twitter_local.py as they are won't work. I believe one would ened to import Stream and/or StreamingClient from tweepy, and the Twitter bearer token should be included as well, something like this:
myStream = tweepy.StreamingClient('insert bearer token')
I am not being very helpful but I am not familiar with Python at all! Hope someone can take a look at this.
Thanks!

Hey - thanks for letting us know. we will look into it

I stucked on step 6 in tutorial: https://quickstarts.snowflake.com/guide/auto_ingest_twitter_data
due to error
twitter_local.py", line 77, in <module>
    class JSONStreamProducer(tweepy.StreamListener):
AttributeError: module 'tweepy' has no attribute 'StreamListener'

Issue still exists the for Auto-Ingest Twitter Data into Snowflake" Quickstart. Please fix it.

A fix for the AttributeError: module 'tweepy' has no attribute 'StreamListener' error is to downgrade tweepy to 3.10 using: pip install tweepy~=3.10.0 instead, although even having got past that error I believe Twitter have changed their endpoints as the code returns Error: 404.
This is recommended learning for the SnowPro Advanced Data Engineering qualification in their study guide, so it's a shame it hasn't yet been resolved.

+1 on request to get this updated


Remove expression with no effects from CalculatorManager

DEP0820: The appx file 'D:_work\1\a\drop\Release\x64\CalculatorUnitTests\AppPackages\CalculatorUnitTests_Test\CalculatorUnitTests.appx' failed to install. Deployment of package 0f7457a6-1a6a-4607-b3b8-e3dd274567c8_<IP_ADDRESS>_x64__47fagdk11vkv4 was blocked because the provided package has the same identity as an already-installed package but the contents are different. Increment the version number of the package to be installed, or remove the old package for every user on the system before installing this package. [0x80073CFB]

Can the failing CI be restarted, please?

Done. Re-started the failed jobs.

All green now.


Reminder details

It might be useful to be able to get more information about a reminder using a command.
Example: ?reminderdetails 123
The output could be similar to what is displayed on the website:

ID
Datetime
Message
If it's repeated and how often
Channel

Done.


Optimize the bottom navigation

Right now I just use ViewFlipper to switch the view on bottom navigation based on this issue https://github.com/hotwired/turbo-android/issues/189. But it has some problems, for example it will render all view at once including home page, and library page when after lunched the app.  And also ViewFlipper seems isn't the proper way to handle bottom navigation. So I need to find a better way to switch view for bottom navigation.

How did this solution (so delayed loading and swapping navHostFragments) worked comparing to using ViewFlipper ?

@michalsznajder  First of all, ViewFilpper will eagerly load all child views, which means if you have multiple views based on TurboNavHostFragment, you will get multiple web page requests at once when using ViewFilpper to switch views. That's unnecessary.  And second, I think using ViewFilpper for bottom navigation isn't a standard way before navigation graphs. And I also try to use nested navigation graphs to handle bottom navigation, but it didn't work with TurboNavHostFragment, that's because we need to handle currentNavHostFragmentId for TurboActivityDelegate manually. And I didn't find a way to handle this with nested navigation graphs.
Anyway, using supportFragmentManager is the best approach I found to deal with bottom navigation with turbo-android right now. And if you find a better solution for this problem, please let me know.


app fails to launch: can't mkdir parents

% flatpak run io.lbry.lbry-app
bwrap: Can't mkdir parents for [$HOME]/.var/app/io.lbry.lbry-app/config/user-dirs.dirs: Read-only file system
.var/app/io.lbry.lbry-app/ exists and contains /cache /config /data
Version: 0.33.2

@rich-coe Have you resolved this issue? If not... do you have any steps to reproduce or further information?
Thanks.

No, I still have the issue.
I installed flatpak
I installed the app.
When I go to run it, I get the error.
It looks like the dir path should be the sandbox for the app?
It's all new to me, I couldn't find anyone else with error, or why it was happening.

We have recently pushed 0.35.0, please update to this version and try again.
If the issue persists, I'll forward this to the team.


[Fix] destructuring-assignment, no-multi-comp, no-unstable-nested-components, component detection: improve component detection

Fixes: #2956
Description:
Example code that shows incorrect error:
const columns = [
  {
    render: (val) => {
      if (val.url) {
        return (
          <a href={val.url} rel="noopener noreferrer" target="_blank">
            {val.fileName || 'PDF'}
          </a>
        );
      }
      return null;
    },
  },
];

Error shows up because getParentComponent calls getParentStatelessComponent that calls  getStatelessComponent on the ArrowFunctionExpression (val =>...) in the example code above which incorrectly returns the same ArrowFunctionExpression instead of undefined.

Codecov Report

Merging #3001 (79a7bcc) into master (faadccb) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #3001   +/-   ##
=======================================
  Coverage   97.21%   97.22%
=======================================
  Files         110      110
  Lines        7297     7305    +8
  Branches     2657     2663    +6
=======================================
+ Hits         7094     7102    +8
  Misses        203      203

Impacted Files
Coverage Δ

lib/util/Components.js
95.36% <100.00%> (+0.07%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update faadccb...79a7bcc. Read the comment docs.

Thanks for your work.

Not sure if it's caused by the changes in this PR, but after updating fro 7.24 to 7.26, I noticed a bunch of false positives showing up in my code:
.../indico/modules/events/editing/client/js/editing/timeline/util.js
  55:14  warning  Must use destructuring revision assignment  react/destructuring-assignment

.../indico/modules/rb/client/js/common/map/reducers.js
  59:9  warning  Must use destructuring action assignment  react/destructuring-assignment
  64:9  warning  Must use destructuring action assignment  react/destructuring-assignment

https://github.com/indico/indico/blob/676dc3d1fede9bd4417982e79310753691be2472/indico/modules/rb/client/js/common/map/reducers.js#L59
https://github.com/indico/indico/blob/676dc3d1fede9bd4417982e79310753691be2472/indico/modules/rb/client/js/common/map/reducers.js#L64
https://github.com/indico/indico/blob/676dc3d1fede9bd4417982e79310753691be2472/indico/modules/events/editing/client/js/editing/timeline/util.js#L55

@ThiefMaster i agree those are false positives. Can you file a new issue so we can track fixing it?


Admin Credentials

What kind of admin credentials are required, Global or SkypeForBusiness? please clarify in the text above

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: d2c88f9f-8e46-966a-30be-5c2506cf578c
Version Independent ID: 5568a567-2432-f76a-2179-daa43edf257b
Content: Plan hybrid connectivity between Skype for Business Server and Skype for Business Online
Content Source: Skype/SfbServer/skype-for-business-hybrid-solutions/plan-hybrid-connectivity.md
Product: skype-for-business-itpro
GitHub Login: @CarolynRowe
Microsoft Alias: crowe

Hi @DeanGross , thank you for your feedback.
Could you specify in what area in the text you think we should clarify this? I couldn't find references about permissions in the article, it's a plan article so I think you will find this kind of information in a "Deploy" article.

@DeanGross  Thank you for submitting this feedback.
From our understanding the issue has been resolved. If you feel it hasn't been resolved please re-open this issue.

@officedocsbot close


🌐 Website Issue | website is stuck in pre-PR2099 version

Description
The site hasn't updated since before pr #2099, so the DNS page is missing the section for Apple devices and file encryption doesn't show Kryptor etc.

It looks like this has been fixed.

https://privacytools.io/providers/dns/#appledns


[FLOC-3706]  place a 30 second timeout on a secureConnection() attempt

I've observed an ssh connection getting indefinitely stuck here.
Plus a couple of small improvements in the nearby code.

I think this looks like an obvious improvement to the current code. Any attempt to connect should conclude in 30 seconds and if it hasn't we should just retry. Thanks!
Once the tests are sufficiently green go ahead and merge.

Only two Jenkins projects are failing consistently for the same reason:

http://ci-live.clusterhq.com:8080/job/ClusterHQ-flocker/job/FLOC-3706-ssh-connect-timeout/job/run_trial_on_AWS_Ubuntu_Trusty_flocker.common/lastFailedBuild/consoleText
http://ci-live.clusterhq.com:8080/job/ClusterHQ-flocker/job/FLOC-3706-ssh-connect-timeout/job/run_trial_on_AWS_CentOS_7_flocker.common/lastFailedBuild/console

test: flocker.common.test.test_retry.TimeoutTests.test_advancing_after_failure
error: flocker.common.test.test_retry.TimeoutTests.test_advancing_after_failure [
Traceback (most recent call last):
testtools.testresult.real._StringException: Traceback (most recent call last):
ValueError: In File: /tmp/workspace/ClusterHQ-flocker/FLOC-3706-ssh-connect-timeout/run_trial_on_AWS_Ubuntu_Trusty_flocker.common/flocker/common/test/test_retry.py
TestCase.setUp was not called. Have you upcalled all the way up the hierarchy from your setUp? e.g. Call super(TimeoutTests, self).setUp() from your setUp().

]
...

The message comes from testtools.TestCase.
It seems that the problem was exposed by f278f204e6fe5a40a313f7ffce385a4e60428668


Webhook issues

I can't seem to get the webhook to work. Do I have to change any of the other files? Does it work if I use the Discord channel ID rather than the channel name?
My config file looks like this:

[
{
"nickname": "ROBOBOT",
"server": "IRC.URL.DNS",
"discordToken": "TOkeN",
"commandCharacters": ["!"],
"ircStatusNotices": true,
"ircOptions": {
"floodProtection": false,
"encoding": "utf-8"
},
"channelMapping": {
"DISCORDIDNUMBERSA": "#IRC"
},
"webhooks": {
"DISCORDIDNUMBERSA": "https://discordapp.com/api/webhooks/COPYPASTEA/COPYPASTEB"
}
},
{
"nickname": "ROBOBOT2",
"server": "IRC.URL.DNS",
"discordToken": "TOkeN",
"channelMapping": {
"DISCORDIDNUMBERSB": "#IRC2"
},
"commandCharacters": ["!"]
}
]

I'm also seeing this error:

error: Received error event from Discord Error: read ECONNRESET
at exports._errnoException (util.js:1020:11)
at TLSWrap.onread (net.js:568:26)

Everything works with the latest update in the main repo.


Fix load selection

Uploading TreeViewCollapseCount.zip…
Steps to reproduce:

Open attached repository in Gittyup
Stage folder/subfolder/file.txt
Expand all staged files
Select folder/subfolder/file.txt in staged TreeView
Commit

Gittyup v1.1.1 - Samstag, 24. September 2022 - 332164d

 It's still happening for me with d4cd8c9

Is this the unittest?

Do you see those changes?

Now it should be fine

Yep, works without issue now


Typo in completions help

Is:
For mor information...
Should be:
For more information
https://github.com/c4spar/deno-cliffy/blob/717abd89d69287375990d079b72559f5d133673f/command/completions/mod.ts#L25
Also in the same file I think it should be add the following line instead of add following line
https://github.com/c4spar/deno-cliffy/blob/717abd89d69287375990d079b72559f5d133673f/command/completions/mod.ts#L19

Thx! Is fixed.


build: Apple M1 build fixes and guide

removes -fopenmp LD flag for everything because it is not used (and Apple clang doesn't support it)
remove conditions around checking for gmp and cryptopp because configure should fail regardless of the build system
pass a minimum sdk version (11.0) to cryptopp if we're building for Darwin
patch gmp to not use arm64 register x18 because it is reserved by Apple. See https://gmplib.org/repo/gmp/raw-rev/5f32dbc41afc
add a build guide

Is this applicable into mainstream bitcoind? maybe that's the place to send the patch (upstream), and then we catchit later...

@daedalus No, this is not applicable to bitcoin. This entire patch, the original, is unique to us. The last commit about strings, might be, but we are busy working on something else.


DynamicTables component

Adds DynamicTables component which contains functionality commonly used inside the winery when working with tables.
It enables developers to quickly add new tables with automatically generated Add/Edit/Remove modals.
The generation works by supplying WineryDynamicTableMetadata objects to the component.
For example:
data:
{ key: 'someKey', type: 'float', description: 'test'}
metadata:
[new DynamicTextData('key', 'Name', ...),
new DynamicDropdownData<'integer'|'float'>('type','Type',
      [{label: 'integer', value: 'integer'},
      {label: 'float', value: 'float'},), ], ...),
  new DynamicTextData('description','Description', ..)]

Creates a table with the following rows: 'Name', 'Type', 'Description'. Furthermore, when clicking Add/Edit a modal is generated which contains two text fields and a dropdown form. The dropdown contains the options given in the constructor. Each metadata object is configurable by changing values in the constructor. It correlates to a component which contains the individual logic, templates etc.

[ ] Ensure that you followed http://eclipse.github.io/winery/dev/ToolChain#github---prepare-pull-request. Especially, we require a single commit
[ ] Ensure that the commit message is a good commit message
[ ] Ensure to use auto format in all files
[x] Ensure that you appear in NOTICE at Copyright Holders
[ ] Tests created for changes
[x] Documentation updated (if needed)
[ ] Screenshots added (for UI changes)

Can one of the admins verify this patch?

And also make sure, that you have the Signed-off-by: Felix Burk<EMAIL_ADDRESS>in the squashed commit :)

@lharzenetter pls check and approve.
@FlxB2 pls squash and sign-off.

@FlxB2 pls trigger and check the build again (we cannot merge until its green)

LGTM, @FlxB2 can you please create a single commit? Afterward, we proceed with creating a CQ.

Ping @FlxB2, pls resolve conflicts and squash the commits.

CQ: https://dev.eclipse.org/ipzilla/show_bug.cgi?id=22490

Merged as of parallel checkin.


docs: add jsdocs

Please, welcome to add ANY comment, according unnecessary comments, formatting, formulation or I missed smth. I tried to bring everything to the same view, so there were some changes in existed comments. Maybe you have other ideas. Please welcome)  Also

I removed all dots from comments ends, look how it looks) Maybe we should return them back)
I didn't correct editor.ts file, cause it was commonly changed in #430 pr

:tada: This PR is included in version 1.0.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


[FEAT] Email Notifications - Welcome Email After User Registration

Description
Implement a feature to send a personalized welcome email to new users upon successful registration. This email should offer a warm introduction and essential information for using the platform effectively.
Acceptance Criteria
Welcome Email Endpoint [POST] /api/v1/welcome-email
Welcome Email:

Given a request to send a welcome email, when the request contains valid user details, the system should send a personalized welcome email.
The email should be sent immediately after the user's registration is successful.

Purpose
The purpose of this feature is to enhance user engagement and satisfaction by providing new users with a welcoming and informative introduction to the platform immediately after they register.
Requirements

Integrate an email service to handle the dispatch of welcome emails.
Develop an endpoint to trigger the welcome email functionality.
Ensure the email content is personalized based on the user’s details.

Expected Outcome
The system should dispatch a personalized welcome email promptly upon receiving a valid request, ensuring that new users are welcomed and informed about the platform.
Request
[POST] /api/v1/welcome-email
Request Body:
{
 "userId": "String",
 "email": "String"
}

## successful response
{
 "message": "Welcome email sent successfully."
}

## error response
{
 "message": "Failed to send welcome email.",
 "error": "String",
 "statusCode": "Int"
}

###

email service is centralised

This will be handled by email service


Child node size is wrong when layout is measured by parent

Is this expected? If yes, should I check every child and measure their layout to get the correct size?

Child has flexDirection: column and align-items: stretch by default, so I think this is just stretching the cross-axis according to that.

Child has flexDirection: column and align-items: stretch by default, so I think this is just stretching the cross-axis according to that.

But there is setMeasureFunc which defines size, shouldn't it respect that? Without setMeasureFunc it's logical to stretch the child, I agree.


Add required dependencies to camera package

Motivation
Fix compilation issue in angularjs since camera didn't declare its dependencies properly

See https://github.com/feedhenry-raincatcher/raincatcher-angularjs/pull/130

Changes Unknown when pulling db3329c47d32eeaa3b61620a740607b0b8fc75c5 on camera-dependency-fix into ** on master**.


Project requirements

Prepare list of requirements for basic budget planning. Requirement description shloud include possible users features, required database informations, limitations and description of how the functionality works.

Link to documentation: https://drive.google.com/drive/folders/1HHxDOu2qunpuMLLaL-6hbuUCI95gAB89?usp=share_link

After consultation with team document was accepted.


Get Key failed: password has been cleared (PKCS12, SunJSSE compat)

Using Java 8, tried with BC versions 1.61, 1.62 and 1.63 – there appears some incompatibility between the SunJSSE and BC implementations which causes a KeyStore.getKey(alias, password) to fail when the key store is loaded with SunJSSE provider but then Bouncy Castle is the first available provider.  I'm reproducing it using the following minimal test:
//package ;

import java.io.InputStream;
import java.security.Key;
import java.security.KeyStore;
import java.security.Security;
import java.util.Collections;

import org.bouncycastle.jce.provider.BouncyCastleProvider;

public class KeyStoreTest {

    public static void main(String[] args) throws Exception {
        //Security.insertProviderAt(new BouncyCastleProvider(), 1);

        KeyStore keyStore = KeyStore.getInstance("PKCS12");
        System.out.println(keyStore.getProvider().getName()
                           + ": " + keyStore.getProvider().getInfo());

        ClassLoader cl = Thread.currentThread().getContextClassLoader();
        try (InputStream in = cl.getResourceAsStream("npoba.p12")) {
            keyStore.load(in, "password".toCharArray());
        }

        Security.insertProviderAt(new BouncyCastleProvider(), 1);

        for (String keyAlias : Collections.list(keyStore.aliases())) {
            Key key = keyStore.getKey(keyAlias, "password".toCharArray());
            System.out.println(keyAlias + ": "
                    + key.getAlgorithm() + " / " + key.getClass().getName());
        }
        System.out.println("Done.");
    }

}

currently results in:
Exception in thread "main" java.security.UnrecoverableKeyException: Get Key failed: password has been cleared
	at sun.security.pkcs12.PKCS12KeyStore.engineGetKey(PKCS12KeyStore.java:435)
	at java.security.KeyStore.getKey(KeyStore.java:1023)
	at KeyStoreTest.main(KeyStoreTest.java:28)
Caused by: java.lang.IllegalStateException: password has been cleared
	at javax.crypto.spec.PBEKeySpec.getPassword(PBEKeySpec.java:197)
	at org.bouncycastle.jcajce.provider.symmetric.util.BCPBEKey.getEncoded(BCPBEKey.java:88)
	at org.bouncycastle.jcajce.provider.symmetric.util.BaseBlockCipher.engineInit(BaseBlockCipher.java:572)
	at org.bouncycastle.jcajce.provider.symmetric.util.BaseBlockCipher.engineInit(BaseBlockCipher.java:974)
	at javax.crypto.Cipher.implInit(Cipher.java:809)
	at javax.crypto.Cipher.chooseProvider(Cipher.java:863)
	at javax.crypto.Cipher.init(Cipher.java:1538)
	at javax.crypto.Cipher.init(Cipher.java:1469)
	at sun.security.pkcs12.PKCS12KeyStore.engineGetKey(PKCS12KeyStore.java:370)
	... 2 more

npoba.p12.zip

For reference, the given example works o.k. using BC 1.52.

Complete example: bcprov-test.zip
One could try it with: mvn exec:java -Dexec.mainClass=KeyStoreTest

For reference, the given example works o.k. using BC 1.52.

Using BC 1.53 to 1.60 (incl.) I'm getting the following:
Exception in thread "main" java.security.UnrecoverableKeyException: Get Key failed: pad block corrupted
	at sun.security.pkcs12.PKCS12KeyStore.engineGetKey(PKCS12KeyStore.java:435)
	at java.security.KeyStore.getKey(KeyStore.java:1023)
	at KeyStoreTest.main(KeyStoreTest.java:28)
Caused by: javax.crypto.BadPaddingException: pad block corrupted
	at org.bouncycastle.jcajce.provider.symmetric.util.BaseBlockCipher$BufferedGenericBlockCipher.doFinal(BaseBlockCipher.java:1246)
	at org.bouncycastle.jcajce.provider.symmetric.util.BaseBlockCipher.engineDoFinal(BaseBlockCipher.java:1081)
	at javax.crypto.Cipher.doFinal(Cipher.java:2164)
	at sun.security.pkcs12.PKCS12KeyStore.engineGetKey(PKCS12KeyStore.java:371)
	... 2 more

sun.security.pkcs12.PKCS12KeyStore:
    /*
     * Generate PBE key
     */
    private SecretKey getPBEKey(char[] password) throws IOException
    {
        SecretKey skey = null;

        try {
            PBEKeySpec keySpec = new PBEKeySpec(password);
            SecretKeyFactory skFac = SecretKeyFactory.getInstance("PBE");
            skey = skFac.generateSecret(keySpec);
            keySpec.clearPassword();
        } catch (Exception e) {
           throw new IOException("getSecretKey failed: " +
                                 e.getMessage(), e);
        }
        return skey;
    }

Looks like it expects the generated SecretKey should not try to access the password from the KeySpec further (see the keySpec.clearPassword() statement above):
com.sun.crypto.provider.PBEKeyFactory.engineGenerateSecret(KeySpec) : com.sun.crypto.provider.PBEKey – doesn't hold reference to the given KeySpec
This is in contrast with BC PBEKeyFactory.engineGenerateSecret(KeySpec) : BCPBEKey – holds reference to the given KeySpec and later fails when trying to access the password from getEncoded()
For some reason with BC 1.52 SecretKeyFactory.getInstance("PBE") returns a com.sun.crypto.provider.PBEKeyFactory instance even when BC installed as first provider.

PBE doesn't exist in BC 1.52. It's since been added.

We hit quite the same incompatibility than KeyStoreTest2 in our project
It also occurs when a "JKS" keystore load a pkcs12 file, as the jdk now use a DualFormatJKS implementation to fallback from jks to pkcs12 (see KeyStoreTest3 below)
The JDK stacktrace doesn't show that BouncyCastle is involved
and as this code correctly worked before BouncyCastle was added to our classpath (some other framework add the BouncyCastle provider to the JDK unwantedly)
it was not straigthforward to find the link.
So here a slightly different test case :
import java.io.InputStream;
import java.security.KeyStore;
import java.security.Security;
import java.util.Collections;

import org.bouncycastle.jce.provider.BouncyCastleProvider;

public class KeyStoreTest3 {

    public static void main(String[] args) throws Exception {
        Security.insertProviderAt(new BouncyCastleProvider(), 1);

//        KeyStore keyStore = KeyStore.getInstance(KeyStore.getDefaultType());
        KeyStore keyStore = KeyStore.getInstance("jks"); // default is JKS

        ClassLoader cl = Thread.currentThread().getContextClassLoader();
        try (InputStream in = cl.getResourceAsStream("npoba.p12")) {
            keyStore.load(in, "password".toCharArray());
        }
        System.out.println("Keys: " + Collections.list(keyStore.aliases()));
        System.out.println("Done.");
    }

}

Which shows a slightly different stacktrace :
Exception in thread "main" java.io.IOException: keystore password was incorrect
	at sun.security.pkcs12.PKCS12KeyStore.engineLoad(PKCS12KeyStore.java:2059)
	at sun.security.provider.KeyStoreDelegator.engineLoad(KeyStoreDelegator.java:238)
	at sun.security.provider.JavaKeyStore$DualFormatJKS.engineLoad(JavaKeyStore.java:70)
	at java.security.KeyStore.load(KeyStore.java:1445)
	at bouncyCastle.KeyStoreTest3.main(KeyStoreTest3.java:18)
Caused by: java.security.UnrecoverableKeyException: failed to decrypt safe contents entry: java.lang.IllegalStateException: password has been cleared
	... 5 more

code correctly worked before BouncyCastle was added to our classpath (some other framework add the BouncyCastle provider to the JDK unwantedly)

In our case the issue prevents us from upgrading Bouncy Castle for addressing security issues in past (our current) version.

any luck in this regard ? I'm having the same issue with jdk-11.0.3+7

No luck so far.  We're just stuck at it.

@bcgit Could you estimate when 1.65 release may be expected?

We're hoping to have it out in the next few weeks.

@bcgit  When will we get the release?


shortkey

If you like the idea, it can be cool to add a quick shortkey.
maybe something like.
CTRL+ALT+H
Thank you plugin work very well.

I'm sorry, can you describe what actually it will do, please?

@mydesireiscoma  a shortcut for auto write
/html/
yes, I am an extreme laziness. :)

@djmisterjon
I'll take a look what I can do

Closed by commit d92a6ba
Extension is updated


Toggle component

Duplicates ❌

[X] I have searched the existing issues

Which Figma library is concerned?
Not related to one Figma library
Summary 💡
A toggle switch allows users to choose two mutually-exclusive states like ON/OFF.
Dependencies 📦
No response
Examples 🌈
No response
Motivation 🔦
No response
New 🆕

[ ] Validated in a grooming session

Backlog 📋

[ ] Has a good summary
[ ] Has example link(s)

Design in progress 🏗

[ ] Analysis (functional & technical)
[ ] Design refinement
[ ] Dev qualification (properties, breakpoints, tokens etc.)
[ ] Documentation refinement (inside the Figma branch)

Design review 👀

[ ] Figma branch merged
[ ] Documentation review _(and move the documentation into Vitamin Documentation Figma file)

Ready to dev 👍

[ ] Issues are created in all repositories affected (vitamin-<web,android,ios,compose>)

Dev in progress 💻

[ ] All issues are resolved (to replace with issues links)

A new ticket has been created on an inner source repository


The issue about unexpected inference result (output class and probability-value) through quantized tflite model in more than a certain number of classes

System information

Model training (VGG16) environment

OS Platform and Distribution

Windows 10

GPU

NVIDIA GTX1080

Cuda Toolkit 10.0.130
Python 3.7
Keras 2.2.4
TensorFlow 1.14.0

Model training (MobileNetV2) environment

OS Platform and Distribution

Ubuntu 18.04.4 LTS (GNU/Linux 4.15.0-99-generic x86_64)

GPU

NVIDIA Quadro P5000

Cuda Toolkit 10.1.243
Python 3.7
Keras 2.2.4
TensorFlow 1.14.0

Model convert environment

OS Platform and Distribution

Mac OS X 10.14.5 (18F132)

Python 3.6.7
Keras 2.2.4
TensorFlow 1.14.0

Target mobile device

Pixel 3 XL

Android 9 (build PQ3A.1980801.002)

Trained model information

VGG16 and MobileNetV2 model (transfer learning)
The number of classes: 10,996

This model is for classification of  the huge classes of the images of a certain category.

Abstract of the issue

In case did the tflite conversion with enable quantization option for this model, the output class (1st rank) for the input test data(about 1000-2000 jpg images files) to 10,996 class model was completely different all from the class of input test data, and I got the unexpected output (the output class did not match in all test data and the probability-value in 1st rank is about 0.4-0.5) compared with the output for 10,806 class model.
But in disabled quantization option, the output class matched the class of the input test data, the probability-value in 1st rank is 0.9 and more, and the classification accuracy for the same test data was 90% and more.
This issue did not occur in the model of less 10,806 classes

I'm investigating if this issue occurs between 10,806 and 10,996 classes.

This issue occurred on mobile device (Pixel 3 XL) but similarly reproduced on Mac too.
The method of the quantization is dynamic range quantization.

Output example

Classes

[ a_0, a_1, ... , a_10995 ]

Input test data class (expected output class)

a_1234

Output class and probability-values (Quantized)a_4952 0.49650624
a_5831 0.044097286
a_6422 0.032513995
...

Output class and probability-values (Not-quantized)a_1234 0.92802435
a_1235 0.004674452
a_13731 0.0012423205
...

Question

Is there something that is considered to be the cause of this issue?

In case a model has the huge number of classes, in internal calculation of a model, overflow or zero-division occurred by applying dynamic range quantization to a trained model, and as a result, is there a possibility that the output result is something wrong?

A similar issue occurred in CoreML:

In CoreML, when a model has the model more than 9,000 classes, this resulted in overflow with Neural Engine mode and GPU mode, but I could avoid this issue with enable CPU mode.

In Android, I couldn't avoid this issue with the same method.

Source code for model conversion
import os
import tensorflow as tf
from keras.models import load_model, model_from_json
from keras.optimizers import SGD

def convert(input_path,
            weights_file,
            output_dir,
            output_filename,
            initial_lr=2e-4,
            momentum=0.9,
            is_quantized=False):

    model = model_from_json(open(os.path.join(input_path, 'model', 'model.json')).read())
    model.load_weights(os.path.join(input_path, 'model', weights_file))
    model.summary()

    opt = SGD(initial_lr, momentum=momentum)
    model.compile(
        optimizer=opt,
        loss='categorical_crossentropy'
    )

    output_modeldir = os.path.split(input_path)[-1]
    output_dir = os.path.join(output_dir, 'models', output_modeldir)

    os.makedirs(output_dir, exist_ok=True)

    keras_file = os.path.join(output_dir, 'weights_temp.h5')
    model_ = model.save(keras_file)

    converter = tf.lite.TFLiteConverter.from_keras_model_file(keras_file)

    if is_quantized:
        converter.post_training_quantize=True
        output_filename = f'{output_filename}_quantization.tflite'
    else:
        output_filename = f'{output_filename}.tflite'

    tflite_model = converter.convert()

    tflite_file = os.path.join(output_dir, f'{output_filename}')
    with open(tflite_file, 'wb') as f:
        f.write(tflite_model)

    print(f'Saved [{tflite_file}]')

Output logs
Using TensorFlow backend.
WARNING:tensorflow:From /anaconda3/envs/py36/lib/python3.6/site-packages/keras/backend/tensorflow_backend.py:517: The name tf.placeholder is deprecated. Please use tf.compat.v1.placeholder instead.

WARNING:tensorflow:From /anaconda3/envs/py36/lib/python3.6/site-packages/keras/backend/tensorflow_backend.py:4138: The name tf.random_uniform is deprecated. Please use tf.random.uniform instead.

WARNING:tensorflow:From /anaconda3/envs/py36/lib/python3.6/site-packages/keras/backend/tensorflow_backend.py:3976: The name tf.nn.max_pool is deprecated. Please use tf.nn.max_pool2d instead.

WARNING:tensorflow:From /anaconda3/envs/py36/lib/python3.6/site-packages/keras/backend/tensorflow_backend.py:4185: The name tf.truncated_normal is deprecated. Please use tf.random.truncated_normal instead.

WARNING:tensorflow:From /anaconda3/envs/py36/lib/python3.6/site-packages/keras/backend/tensorflow_backend.py:131: The name tf.get_default_graph is deprecated. Please use tf.compat.v1.get_default_graph instead.

WARNING:tensorflow:From /anaconda3/envs/py36/lib/python3.6/site-packages/keras/backend/tensorflow_backend.py:133: The name tf.placeholder_with_default is deprecated. Please use tf.compat.v1.placeholder_with_default instead.

WARNING:tensorflow:From /anaconda3/envs/py36/lib/python3.6/site-packages/keras/backend/tensorflow_backend.py:3445: calling dropout (from tensorflow.python.ops.nn_ops) with keep_prob is deprecated and will be removed in a future version.
Instructions for updating:
Please use `rate` instead of `keep_prob`. Rate should be set to `rate = 1 - keep_prob`.
2020-10-01 11:34:43.751852: I tensorflow/core/platform/cpu_feature_guard.cc:145] This TensorFlow binary is optimized with Intel(R) MKL-DNN to use the following CPU instructions in performance critical operations:  SSE4.1 SSE4.2 AVX AVX2 FMA
To enable them in non-MKL-DNN operations, rebuild TensorFlow with the appropriate compiler flags.
2020-10-01 11:34:43.752602: I tensorflow/core/common_runtime/process_util.cc:115] Creating new thread pool with default inter op setting: 6. Tune using inter_op_parallelism_threads for best performance.
_________________________________________________________________
Layer (type)                 Output Shape              Param #
=================================================================
image_input (InputLayer)     (None, 128, 128, 3)       0
_________________________________________________________________
block1_conv1 (Conv2D)        (None, 128, 128, 64)      1792
_________________________________________________________________
block1_conv2 (Conv2D)        (None, 128, 128, 64)      36928
_________________________________________________________________
block1_pool (MaxPooling2D)   (None, 64, 64, 64)        0
_________________________________________________________________
block2_conv1 (Conv2D)        (None, 64, 64, 128)       73856
_________________________________________________________________
block2_conv2 (Conv2D)        (None, 64, 64, 128)       147584
_________________________________________________________________
block2_pool (MaxPooling2D)   (None, 32, 32, 128)       0
_________________________________________________________________
block3_conv1 (Conv2D)        (None, 32, 32, 256)       295168
_________________________________________________________________
block3_conv2 (Conv2D)        (None, 32, 32, 256)       590080
_________________________________________________________________
block3_conv3 (Conv2D)        (None, 32, 32, 256)       590080
_________________________________________________________________
block3_pool (MaxPooling2D)   (None, 16, 16, 256)       0
_________________________________________________________________
block4_conv1 (Conv2D)        (None, 16, 16,<PHONE_NUMBER>
_________________________________________________________________
block4_conv2 (Conv2D)        (None, 16, 16,<PHONE_NUMBER>
_________________________________________________________________
block4_conv3 (Conv2D)        (None, 16, 16,<PHONE_NUMBER>
_________________________________________________________________
block4_pool (MaxPooling2D)   (None, 8, 8, 512)         0
_________________________________________________________________
block5_conv1 (Conv2D)        (None, 8, 8,<PHONE_NUMBER>
_________________________________________________________________
block5_conv2 (Conv2D)        (None, 8, 8,<PHONE_NUMBER>
_________________________________________________________________
block5_conv3 (Conv2D)        (None, 8, 8,<PHONE_NUMBER>
_________________________________________________________________
block5_pool (MaxPooling2D)   (None, 4, 4, 512)         0
_________________________________________________________________
gap_vgg16gap (GlobalAverageP (None, 512)               0
_________________________________________________________________
fc1_vgg16gap (Dense)         (None, 4096)              2097152
_________________________________________________________________
bn1_vgg16gap (BatchNormaliza (None, 4096)              16384
_________________________________________________________________
relu1_vgg16gap (Activation)  (None, 4096)              0
_________________________________________________________________
do1_vgg16gap (Dropout)       (None, 4096)              0
_________________________________________________________________
fc2_vgg16gap (Dense)         (None, 4096)              16777216
_________________________________________________________________
bn2_vgg16gap (BatchNormaliza (None, 4096)              16384
_________________________________________________________________
relu2_vgg16gap (Activation)  (None, 4096)              0
_________________________________________________________________
do2_vgg16gap (Dropout)       (None, 4096)              0
_________________________________________________________________
predictions_vgg16gap (Dense) (None, 10996)             45050612
=================================================================
Total params: 78,672,436
Trainable params: 71,020,788
Non-trainable params: 7,651,648
_________________________________________________________________
WARNING:tensorflow:From /anaconda3/envs/py36/lib/python3.6/site-packages/keras/optimizers.py:790: The name tf.train.Optimizer is deprecated. Please use tf.compat.v1.train.Optimizer instead.

WARNING:tensorflow:From /anaconda3/envs/py36/lib/python3.6/site-packages/tensorflow/python/util/deprecation.py:507: calling VarianceScaling.__init__ (from tensorflow.python.ops.init_ops) with distribution=normal is deprecated and will be removed in a future version.
Instructions for updating:
`normal` is a deprecated alias for `truncated_normal`
2020-10-01 11:34:49.269923: I tensorflow/core/grappler/devices.cc:60] Number of eligible GPUs (core count >= 8, compute capability >= 0.0): 0 (Note: TensorFlow was not compiled with CUDA support)
2020-10-01 11:34:49.270019: I tensorflow/core/grappler/clusters/single_machine.cc:359] Starting new session
2020-10-01 11:34:49.759721: I tensorflow/core/grappler/optimizers/meta_optimizer.cc:716] Optimization results for grappler item: graph_to_optimize
2020-10-01 11:34:49.759743: I tensorflow/core/grappler/optimizers/meta_optimizer.cc:718]   function_optimizer: function_optimizer did nothing. time = 0.007ms.
2020-10-01 11:34:49.759750: I tensorflow/core/grappler/optimizers/meta_optimizer.cc:718]   function_optimizer: function_optimizer did nothing. time = 0.004ms.
WARNING:tensorflow:From /anaconda3/envs/py36/lib/python3.6/site-packages/tensorflow/lite/python/util.py:238: convert_variables_to_constants (from tensorflow.python.framework.graph_util_impl) is deprecated and will be removed in a future version.
Instructions for updating:
Use `tf.compat.v1.graph_util.convert_variables_to_constants`
WARNING:tensorflow:From /anaconda3/envs/py36/lib/python3.6/site-packages/tensorflow/python/framework/graph_util_impl.py:270: extract_sub_graph (from tensorflow.python.framework.graph_util_impl) is deprecated and will be removed in a future version.
Instructions for updating:
Use `tf.compat.v1.graph_util.extract_sub_graph`
/anaconda3/envs/py36/lib/python3.6/site-packages/tensorflow/lite/python/lite.py:769: UserWarning: Property post_training_quantize is deprecated, please use optimizations=[Optimize.DEFAULT] instead.
  " instead." % name)
2020-10-01 11:34:50.957910: I tensorflow/core/grappler/devices.cc:60] Number of eligible GPUs (core count >= 8, compute capability >= 0.0): 0 (Note: TensorFlow was not compiled with CUDA support)
2020-10-01 11:34:50.958019: I tensorflow/core/grappler/clusters/single_machine.cc:359] Starting new session
2020-10-01 11:34:51.559693: E tensorflow/core/grappler/grappler_item_builder.cc:637] Init node block1_conv1/kernel/Assign doesn't exist in graph
Saved [./weights_quantization.tflite]

Hi all, Is there an anything update a progressing about the solution for this issue?
Thanks.

Hi @pdkz I am still working on it. Please stay tuned. thanks!

@pdkz Hi pdkz, Sorry for belated reply. Could you please check the conversion with tf-nightly >= 2.4.0-dev20201001? I am still investigating, but I want to check it in parallel on both sides. Thanks.

Hi @jaeyoo Never mind, I'm grateful for your support.
Okay, I'll try it in the model conversion using tf-nightly 2.4.0 greater. I'd like to be helpful to you even just a little.
Thanks.

Hi @jaeyoo!
I tried to do the conversion in tf-nightly 2.5.0.
At the moment, it seems that the converted model output the expected output when I checked the accuracy. Thanks for your advice and supports!
But it's not clear what's caused it, so I'm also investigating the source code to find out the cause for this issue.
Is this issue known or latent bug in TF 1.x ? (It seems I couldn't find posts about it in issue tracker. )
Please tell me if you find out the cause or the hint.

Hi @pdkz Thank you for sharing good news! Yes... honestly speaking, I couldn't reproduce the result at the latest TF as you saw, and I tried to dig into where the cause was, but I couldn't find it yet. also, it wasn't known issue, so I was surprised at the first glance at this issue. Please let me inform you if I can find it. Thank you!


SocketException: Reading from a closed socket

Steps to Reproduce
I don't know how to reproduce this SocketException，it suddenly report an error during the application.
flutter doctor
[✓] Flutter (Channel stable, 2.2.0, on macOS 11.2.3 20D91 darwin-x64, locale zh-Hans-CN)
    • Flutter version 2.2.0 at /Users/huangsir/flutter-2.0.6/flutter
    • Framework revision b22742018b (3 months ago), 2021-05-14 19:12:57 -0700
    • Engine revision a9d88a4d18
    • Dart version 2.13.0
    • Pub download mirror https://pub.flutter-io.cn
    • Flutter download mirror https://storage.flutter-io.cn

error stack
flutter: content: Caught error: SocketException: Reading from a closed socket
flutter: content: #0      _RawSecureSocket.read (dart:io/secure_socket.dart:662:7)
dart-lang/http#1      _Socket._onData (dart:io-patch/socket_patch.dart:2159:28)
dart-lang/http#2      _rootRunUnary (dart:async/zone.dart:1362:47)
dart-lang/http#3      _CustomZone.runUnary (dart:async/zone.dart:1265:19)
dart-lang/http#4      _CustomZone.runUnaryGuarded (dart:async/zone.dart:1170:7)
dart-lang/http#5      _BufferingStreamSubscription._sendData (dart:async/stream_impl.dart:341:11)
dart-lang/http#6      _BufferingStreamSubscription._add (dart:async/stream_impl.dart:271:7)
dart-lang/http#7      _SyncStreamControllerDispatch._sendData (dart:async/stream_controller.dart:733:19)
dart-lang/http#8      _StreamController._add (dart:async/stream_controller.dart:607:7)
dart-lang/http#9      _StreamController.add (dart:async/stream_controller.dart:554:5)
dart-lang/http#10     _RawSecureSocket._sendReadEvent (dart:io/secure_socket.dart:991:19)
dart-lang/http#11     _rootRun (dart:async/zone.dart:1346:47)
dart-lang/http#12     _CustomZone.run (dart:async/zone.dart:1258:19)
dart-lang/http#13     _CustomZone.runGuarded (dart:async/zone.dart:1162:7)
dart-lang/http#14     _CustomZone.bindCallbackGuarded.<an<…>

I am having similar crash reports:
SocketException: Reading from a closed socket

[
  "_RawSecureSocket.read (dart:io/secure_socket.dart:770)",
  "_Socket._onData (dart:io-patch/socket_patch.dart:2323)",
  "_RootZone.runUnaryGuarded (dart:async/zone.dart:1586)",
  "_BufferingStreamSubscription._sendData (dart:async/stream_impl.dart:339)",
  "_BufferingStreamSubscription._add (dart:async/stream_impl.dart:271)",
  "_SyncStreamControllerDispatch._sendData (dart:async/stream_controller.dart:774)",
  "_StreamController._add (dart:async/stream_controller.dart:648)",
  "_StreamController.add (dart:async/stream_controller.dart:596)",
  "_RawSecureSocket._sendReadEvent (dart:io/secure_socket.dart:1107)",
  "Timer._createTimer.<anonymous closure> (dart:async-patch/timer_patch.dart:18)",
  "_Timer._runTimers (dart:isolate-patch/timer_impl.dart:398)",
  "_Timer._handleMessage (dart:isolate-patch/timer_impl.dart:429)",
  "_RawReceivePortImpl._handleMessage (dart:isolate-patch/isolate_patch.dart:192)"
]

I am unable to reproduce this as well, this crash is reported from some devices and the app state is always in the paused state when this happens. It happens after interacting with a chat page (using sockets with signalR client) then minimizing the app.

Same thing happens to me too. This crash really confuse me, It seem this crash comes from .../io/secure_socket.dart, when a TLS socket closed, it raw socket keep sending data to TLS handler, then tigger this crash.

Bumping priority as folks seem to run into this frequently

//cc @brianquinlan

Happy to have a go at a fix for this, if it's on the less-tricky side of hard. My suggestion in #52210 was to change from a exception to returning nil, like the other conditional checks in that method (a few lines below).
If someone can provide a steer on writing a test and/or a fix, very happy to have a go.

I was looking at adding the suggested fix, I am in the process of trying to add a regression test that will work with our test harness.

up

I met this problem too. Have no idea.

I have the same error

What platforms are people seeing this on?

I have the same error


Support adjusting log level dynamically through HTTP API (#4033)

Signed-off-by: andrisak<EMAIL_ADDRESS>
What have you changed? (mandatory)
A new endpoint was added to the StatusServer API that can be called using HTTP to change the log level during runtime. The new endpoint path is /log-level. Example invocation:
curl -X PUT -H "Content-Type: application/json" -d '{"log-level":"debug"}' http://<IP_ADDRESS>:20180/log-level
What are the type of the changes? (mandatory)
New feature.
How has this PR been tested? (mandatory)
The unit test test_change_log_level in status_server was extended to also test this endpoint.
Also ran basic integration tests by running pd-server, the updated tikv-server, and tidb-server and calling the endpoint. Monitored the tikv-server log to see if the entries had the expected level.
Does this PR affect documentation (docs) or release note? (mandatory)
This change should be documented but it's not included in this PR.
Does this PR affect tidb-ansible update? (mandatory)
No.
Refer to a related PR or issue link (optional)
Benchmark result if necessary (optional)
Add a few positive/negative examples (optional)

PTAL @breeswish

@BusyJay @overvenus PTAL

@breeswish Thanks for the feedback! To avoid re-initializing the drainers, would it be an option to use a static RwLock to hold the current log level in the logger/mod.rs? When the logging is initialized using the init_log function the log level would be set to the value that was read from configuration.
Both the drainers, TikvFormat and LogAndFuse, could read that value to determine if something should be logged or not.
The REST API would just change the value in the static RwLock to change the log level. Would that be a better implementation?

@andrisak Yes, and you can step further to use atomic variables instead of RwLocks because atomic variables are enough to hold the level and is much more efficient compare to RwLocks. By the way the implementation provided in the slog doc also uses atomics: https://docs.rs/slog/2.5.2/slog/#change-logging-level-at-runtime

Please fix the conflicts, thank you

@andrisak Sorry for the delay, this PR was overlooked. Would you like to resolve the conflicts? I'll merge it soon after that.

@andrisak Could you rebase it onto master? There is too many noise to review.

/merge

/cc @overvenus

/cc @iosmanthus

/@zhongzc

/run-all-tests

/merge

close #4033


add script to rename files recursively

Fixes #2
Before using the script please change the query and replacement in the script file accordingly.
Before

After renaming

NOTE: test.sh and rename-files.sh are same files, I renamed it later.

@nkilm I found a issue with your script. If you want to fix it, you can read up issue #4 to  know about that.
Thanks for you contribution!

@ashuvssut To fix #4 what we can do is include directories also in addition to files. i.e, find . -type d -name query.
For files, -type f and directories -type d

For files, -type f and directories -type d
@nkilm thanks man! now the script's working fine

@ashuvssut Happy to help!


Added wrapper functions for REVERSE() function to fix issue with input containing multi-byte characters.

Description
Currently for string function REVERSE() we are directly using corresponding PG function whose input and output datatype is TEXT. This leads to incorrect output for input containing multi-byte characters with nchar and nvarchar datatype. This PR will fix this issue by adding wrapper functions with correct input and return datatype for REVERSE() function.
Issues Resolved
BABEL-4839
Test Scenarios Covered

Use case based - YES

Boundary conditions - YES

Arbitrary inputs - YES

Negative test cases - YES

Minor version upgrade tests - YES

Major version upgrade tests - YES

Performance tests - NO

Tooling impact - NO

Client tests - NO

Check List

[x] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is under the terms of the Apache 2.0 and PostgreSQL licenses, and grant any person obtaining a copy of the contribution permission to relicense all or a portion of my contribution to the PostgreSQL License solely to contribute all or a portion of my contribution to the PostgreSQL open source project.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.006%) to 73.425%

Totals

Change from base Build<PHONE_NUMBER>:
0.006%

Covered Lines:
42170

Relevant Lines:
57433

💛  - Coveralls

Synced offline for the changes. LGTM.


ci: Always run test & lint workflows

This is a follow-up to:

https://github.com/dagger/dagger/pull/3897#issuecomment-1323917409

The TL;DR is that we want to keep as little logic in the GitHub Actions workflows as possible, and keep as much as we can in Dagger (especially the caching part).
The only other change that this introduces is running engine tests with race detection in parallel. We want to optimise for the entire test pipeline finishing as soon as possible, which means running everything in parallel. Before this change, regular tests would need to pass first before the tests with race detection would run. cc @vito

re: race detection tests, they used to take a very long time to run (somewhere around 25 mins) hence being broken out of the initial parallel suite - we didn't want to consider them a requirement for merge, so having them run after (or not run at all) caused no harm.
But now it takes ~4 mins, for a sneaky reason: now that we pre-build the engine and run it separately from the test suite, the engine itself never runs with -race. We should fix that if we want race detection again! We'd need to go build it with -race - maybe as a separate Mage target?

If we only run race detection tests on merge, we could miss issues introduced in PRs until after the merge. I know that this is less likely to happen, but are we OK with that risk? WDYT @aluzzardi @sipsma?
Great point on building with -race @vito! I think that testRace should depend on a Mage task which builds with -race. Does that sounds reasonable?

To clarify, we also run them on every PR, we just decided we don't have to wait on them and instead let any race issues bubble up eventually on a potentially unrelated PR rather than waiting synchronously on every PR. I think this is less frustrating than having to wait half an hour for small changes.
Adding a testRace that builds the engine with -race makes sense to me! :+1:

But now it takes ~4 mins, for a sneaky reason: now that we pre-build the engine and run it separately from the test suite, the engine itself never runs with -race.

Good catch! Yeah agree we should do that.

If we only run race detection tests on merge, we could miss issues introduced in PRs until after the merge. I know that this is less likely to happen, but are we OK with that risk?

If the above fix slows the tests down a ton again, I'd be okay with only running the -race tests after the merge. They are nice to have but it's relatively rare that they catch anything, so the tradeoff of more PR velocity seems worth it to me (but just my opinion).

Lastly, I was wondering what would happen if we ran engine tests as a single job (vs 2 jobs, as we do currently): Xm Xs. Unfortunately 💥

Are you running on macos? If so, this may be causing the problem here, just fyi: https://github.com/dagger/dagger/issues/3957

@sipsma If the above fix slows the tests down a ton again, I'd be okay with only running the -race tests after the merge. They are nice to have but it's relatively rare that they catch anything, so the tradeoff of more PR velocity seems worth it to me (but just my opinion).

OK, great, I will keep this in mind as we continue reshuffling this with time optimisations in mind.

@sipsma Are you running on macos? If so, this may be causing the problem here, just fyi: #3957

No. In that case I must have hit the 200 pull image requests in 6h for free accounts.

If this change looks good to you @sipsma @vito @aluzzardi, please go for merge.
I intend to open this follow-up PR next: mage engine:testRace uses  a binary built with -race. Based on how long those tests will take after that change, I will know what the next PR needs to be.


Update GitHub Actions' workflows

Updated steps.
Improved getting full python version from actions/setup-python@4.
set-output was deprecate.
poetry install added --sync argument.

Thank you!

Thanks @nnsnodnb. The reason this was failing was outlined and resolved in #21. If you either rebase against main or merge main into these changes then these tests should run as expected and we can get your contributions merged 😄

Thank you for resolving.
I have rebased it, so please check again.


CI: AzDO does not pick up test results properly

At the moment, our CI runs our unit test scenarios successfully. However, it appears our publish results step is incorrectly pointing to the path prior to the new build system being in place, resulting in the following warning:

##[warning]No test result files matching artifacts/build/Debug/tests/test_detail.xml were found.

As such, AzDO does not update the test run results accordingly. This occurs for all 4 build variants.

I must've broken this by accident when I rewrote the CMakeLists :upside_down_face:

I'm sure it's a straightforward fix seeing as you know where everything is better than we do atm. I'm sure you'll be fine. :D

We had a discussion in discord of moving to github actions at some point.
However, it's definitely not a priority, more of a QoL - however issues like this could definitely be helped, as github actions is (afaik) much more programmable/scriptable. There are also a few nice integration features with github itself.

AzDO support for this is fine. If you want to move to actions, I suggest opening a proposal. :D


expose action headers to UI

Currently we support overwrite the endpoint headers in the actions as JSON but this is not supported in the UI, as we currently support in settings. This will be a corner case for some scenarios and we should consider an effective real estate usage

I modified the cnc5.0_first_demo.json config in YAP Zoo to test the "headers" feature. Kindly pull the latest config before testing.

I Removed the "CNCAuth" Endpoint (previously named CNC2) which contains the headers
Content-Type: application/yang-data+json and Authorization: {{token}}

Under actions, I modified the two PATCH API objects and replaced the endpoint  with "CNC" instead of using CNCAuth and  I added the "headers" field that will override the "CNC" endpoint initial headers "Content-Type": "application/x-www-form-urlencoded"

In the UI you can check the "edit" API action modal to see the headers


How to generate data class with "no arg constructor" and setter? (or a data class with builder)

Hi, I have a data class with many data fields. I couldn't find how to configure to get a "no arg constructor" so I can set a few data fields that I'm interested later. Builder is also good.

Codegen should always generate a no arg constructor, no additional configuration needed. You also have a Builder that is generated to do set fields later.