CloudKit Protobuf definition updates

Our CloudKit protobuf definitions work well but are now quite ancient. There is a newer partial dump available obtained using Protod on Windows binaries.
I don't have access to them and I haven't tried, but using Protod on dumped iOS CloudKitDaemon framework binaries could possibly work wonders.
I now also have the reverse engineering chops to pull protobuf definitions kicking and screaming out of Windows binaries, although it takes more effort and  the field names aren't often present.

I have tried to run the script on the CloudKitDeamon framework binary extracted from iOS 10 ipws but it seems like nothing was found.

Thank you for testing and the feedback. Unfortunately binaries (decrypted) don't always have sufficient information to extract protobufs using this tool.

Yes, seems to be like that. The script is looking for '.proto' string which seems to be stripped out from the final binary. Btw, I've just extracted for my usage iOS (<IP_ADDRESS>) headers for various frameworks (e.g. CloudKit, CloudKitDeamon etc.). Let me know if you would also need them.

Hi horrorho,
I've also tried running the script on some windows iCloud binaries (AOSKit.dll, ChunkingLibrary.dll, iCloud.dll, PCS.dll) without success, although you have managed to get at least partial dump. Just wondering if you could pls tell me on which dll did you successfully run the script?

Finally, I think I had some luck with the iCloudDrive_main.dll.

Also try iCloudPhotos_main.dll.
If I recall correctly Protod gave me a few read errors at times. Rather than delve into the code, I cheated my way around and split the dll into parts which I then processed individually. Just make sure there are no proto structures sitting on the split boundaries, they are text rich so are easily recognised.

Thanks, the splitting of dlls helped to fix the errors. I had a look at the errors and tried to fix the script. You can access it from the link below:-
https://drive.google.com/file/d/0B4qEZ1jtaUaUVmZadEhoZGR0cWs/view?usp=sharing

Excellent. Thank you.

Btw, I've started converting your java code in python3. Hope, it is alright if it is at some point also on Github as an open-source. Despite that, I expect I will get stuck at some point and will need guidance from someone on reversing binaries (iOS 10).

@Jirmi Excellent. I'd almost given up on anyone porting to Python. Please ticket any questions/ issues you may have.
If you are serious I can take some time out to write up the process. Though I must warn you that English is not my first language, so it might get a bit convoluted. Then again it will probably be easier than deciphering my Java code.
Again if you are serious, as it will take up a fair amount of time, I can rewrite the necessary CloudKit API subset as a separate Java project using the newer protobuf definitions. I had been meaning to do it at some point. This should give you a foundation to work with. It will also give others a base for further research.

Thanks for the offer of help. I'm currently implementing the SRP part but have managed to block my account. Do you know pls how long it takes before it resets the counter of remaining attempts? I  will be using for time-being another testing account but I wonder if it even gets unlocked :-)

You can try to reset your iCloud password. Failing that you'll need to ring Apple. Attempts are limited to prevent brute force attacks and they don't regenerate. The rest of the API is more forgiving.
If you can, use an SRP-6a library. The verifier is of the type:
 x = SHA1(s | SHA1(I | ":" | P))

As stated in RFC 5054 Section 2.3.
BouncyCastle doesn't offer this verifier so I ended up recoding it. I also added in a fail-safe where InflatableDonkey refuses to operate on accounts with limited attempts remaining. I didn't want to be responsible for locking accounts.
I've pushed a new build that has some additional logging statements.
If you add in the logging switch to logback.xml:
    <logger name="com.github.horrorho.inflatabledonkey.crypto.srp" level="trace" additivity="false">
        <appender-ref ref="STDOUT" />
    </logger>

Then if you run InflatableDonkey a couple of times. It will dump out the SRP6-a vectors/ intermediate values which you can use to test with.

I should probably give you RFC 2945 Section 3 as a reference. RFC 5054 is more specific to the BouncyCastle implementation.
x = SHA(<salt> | SHA(<username> | ":" | <raw password>))

Thanks for the detailed info in the previous comments. The logging for the InflatableDonkey is very useful. It is also great it support proxy server configuration which also gives good inside of what's going on.
As you suggested, I have used some SRP library although had to tweak it to get finally the right result (m1). A padding seems to cause sometimes some issues but it seems to be working now.

Hi horrorho, just to provide some update. Currently, trying to understand a format of the backupBagPassword which should be encoded as DER(asn1). Based on the comments from your project it should have following format:-
BackupBagPassword format
# SEQUENCE  (6)
#      UTF8STRING             String name
#      SET  (1)               Set<PrivateKey> privateKeys
#      SET  (1)               Set<TypeData> serviceKeyIDs
#      OCTET_STRING OPTIONAL  byte[] checksum
#     ....

0x 62 82 07 15 30 82 07 11 0C 02 6B 73 31 82 06 24 30 81 D5 04 40 86 52 D0 6F BC 68 4C
Still trying to fully understand although I am not clear enough on tag value of the SET types. They seems to have tag value of 0x31 while I would expect 0x10 or 0x11 based on some resources found on internet.
(http://luca.ntop.org/Teaching/Appunti/asn1.html)

0x31 is 0x11 with bit 6 set indicating a constructed type. It is referenced in A Layman's Guide to a Subset of ASN.1, BER, and DER. I read that document too and it also took me a while to wrap my head around it. I used hate cryptography with a passion but I'm more comfortable with it now, though not an expert by any stretch of the imagination.
Unless it interests you, I would delegate as much as you can to a library. I left most of the dirty work to BouncyCastle.
Useful command:
openssl asn1parse -inform der -in FILE

Online decoders:
http://lapo.it/asn1js/
https://holtstrom.com/michael/tools/asn1decoder.php
Apple:
https://opensource.apple.com/source/Heimdal/Heimdal-453.40.10/lib/asn1/
I do have a private tool I created to rip the asn1 templates that Apple uses from it's binaries. It's not polished and not easy to use, you need to provide it with the exact offset of the asn1template. It's this tool that is responsible for the output you see in comments. I can upload it to GitHub if you like.
Also, it might be easier just to create a new issue for horrorho-jirmi discussions rather than polluting this issue.

Hi @michaljirman. I have implemented some new protobuf requests (such as RecordRetrieveChangesRequest (213) and QueryRetrieveRequest (220)) and now I am able to retrieve some additional records from other services.
But I haven't been able to download the assets included in those records, because InflatableDonkey's AuthorizeGetRequest seems to work only for the backup chunks. Do you know how could I download these assets?
Any guidance would be greatly appreciated. Thanks!


The current repo is not updated in PyPi.

People are facing the problem (especially newbie) as they can't be able to figure out where to make changes and they are also not getting a better reply from StackOverflow (reference: https://stackoverflow.com/questions/54022839/typeerror-write-argument-must-be-str-not-bytes). so update the package uploaded in Python Package Index (PyPI) with the current repo. Also if you add me as a maintainer than I will do this and also maintain it for future python releases.

I think he has unsubscribed himself from issues on this repo.


fang: subtask b Adversarial Cross-Domain MGT detection

If I want to submit the predictions.json for Subtask A using the same method, do I just need to rerun the method on the test set for Subtask A and then send another pull request?

Hi @Lalenture. If your submission contains results for both adversarial and non-adversarial data then we'll count it towards both subtasks. No need to resubmit.

Got it. My results contain both types of data. Thanks!


Restarting GPU dependant software after TaskbarX launch or restart

Every time Windows boots up whatever launched before TaskbarX disappears from the icon tray, like the Nvidia Control panel.
or whenever the screen turns off and then it turned on again, all the programs that are using GPU crash and close, like the MSI afterburner or the 3dmodeling software like Rhino. It is not something new, it is at least here from the first day of Taskbar X <IP_ADDRESS> update.
Windows 10 Pro Version	21H1 OS build	19043.985
Nvidia Studio Driver Version 462.59

To be able to focus on major/current bugs I had to close all issues. The issues section has gotten very messy to a point that I couldn't follow it anymore. Most issues are duplicates, very old or are already fixed/solved. Feel free to reopen this issue if you still have this issue on the latest version of TaskbarX to get my attention. All feature requests have been put in a list here: 💡| Feature requests #870
I hope you understand ❤


UATv0.3.3 | Error in Order Creation

Found this additional error, unable to replicate yet:

Register Case
Schedule Admission Hearing
Click on Issue Order for Notice
The order form opens up with Esign pop up open
Uploaded signed document
Order published with Order type undefined.

See:

hi @Ramu-kandimalla unable to reproduce

cc : @anirudh-0 @rajeshcherukumalli

Hi @utpalBeehyv  Please create a video of the expected functionality and the deviation if any based on that we can request client to retest

hi @Ramu-kandimalla jam video : https://jam.dev/c/c606ff5d-1c39-4799-912d-97bed5a86ebf

Unable to reproduce in QA & UAT:

cc : @Ramu-kandimalla @rajeshcherukumalli


Dead link on guidelines index page

adding a new pipeline link isn't found on the index page
Page could use a good proofreading at the same time

When guidelines don't fit should also reference subworkflows

Final section about code of conduct should have its own heading for visibility


Adds SPARQL element (closes #13)

Thanks for the input. A part of the documentation to the SPARQL end-point contains an unfinished sentence: "However8..." Maybe some thought of yours got interrupted. If it is a relict, please delete it.

Thanks for the input. A part of the documentation to the SPARQL end-point contains an unfinished sentence: "However8..." Maybe some thought of yours got interrupted. If it is a relict, please delete it.

Yes, the description was not complete, thanks for checking. I also re-adjusted the relations, as the applications will mostly (only?) use the SPARQL end-point.


[NO-TICKET] Update Hugo version

Changelog
Updated
Updated the Hugo version.
Preview This Change
To see how this change looks in production, scroll down to Deploy Preview. Select the link that looks like https://deploy-preview-<num>--cobalt-docs.netlify.app/
Variables
Help us support a “Write once, publish everywhere” single source of truth. If you see a line that looks like:
{{ % asset-categories % }}
You’ve found a shortcode that we include in multiple documents.
You’ll find the content of the shortcode in the following directory:
https://github.com/cobalthq/cobalt-product-public-docs/tree/main/layouts/shortcodes
That shortcode has the same base name as what you see in the PR, such as asset-categories.html.

I'm glad to see updates when we have them.
This is making me wonder if we can automate the process with dependabot... but first, we need to solve the issues that we already have.
Nevertheless, there might be a way with GitHub actions, as discussed here: https://discourse.gohugo.io/t/dependabot-for-hugo-modules/40258

I've set up a reminder in Slack to check the most recent versions from time to time. We should definitely set up an automated process for that. DOCS-304


Index of Persons

Please edit the columns in the index of persons: https://hanslick-online.github.io/hsl-app-dev/listperson.html?lang=de. (The other two indexes are totally fine.) (a) Please omit the column "Wikidata" from the index and replace it with a column "Lebensdaten". (b) Please order the columns from left to right the following way: Name, Name (alt), Typ, Lebensdaten, Beruf, Werke, GND, Erwähnt.

about "Lebensdaten" we should discuss the date formats you are collecting.

Thanks for the change! Absolutely, let's discuss this in person.


Missing results of solution participation

Describe the bug
The results of the solution for programming exercises is not correctly shown in Artemis.
When taking a look at Bamboo, the builds run fine, but they are apparently not correctly detected or imported by Artemis.
To Reproduce

Create a programming exercise
Change some code in either the solution or the tests ~(you might have to do this a couple of times, it does not fail every time)~
a) change the solution
b) immediately change the tests
c) immediately change the solution (tests have to be building)
Go to the results of the solution
See empty results

Expected behavior
Artemis should correctly import the results from Bamboo
Screenshots
Artemis result view:

Commits of solution:

Commits of tests:

What browsers are you seeing the problem on?
Safari
Additional context
No response
Relevant log output
No response

The issue might be related to the fact that Bamboo reports multiple commits (from the assignment and tests repo). When Artemis receives the result, it tries to map it to an existing submission, which seems to fail for some reason in some cases.

In our case, this was resolved when renaming the test methods so that they were globally unique.
So I think this was an issue with the duplicated names because I never experienced that problem anymore after that.

It's also the case for Jenkins instances.
But at least results were handled by the backend The new result for *********-SOLUTION was saved successfully

We were unable to find any behavior were results got lost or not displayed. It seems that Bamboo cancels builds that are triggered in short succession. But Artemis always creates a submission for each test and solution commit, and that seems to work reliably. Due to the merged/aborted builds, no build result is available for the corresponding Artemis submission (the number of builds in Artemis corresponds to the number of builds in Bamboo). In such cases, it makes sense to have no results for a submission.
Please close this issue or specify how we can reproduce a loss of information or other errors. Are special settings needed?


add bg image

PR title
Status
READY/IN DEVELOPMENT/HOLD
Description
A few sentences describing the overall goals of the pull request's commits.
Related PRs
List related PRs against other branches:

branch
PR

other_pr_production
link

other_pr_master
link

Todos

[ ] Tests
[ ] Documentation

Steps to Test or Reproduce
Outline the steps to test or reproduce the PR here.
git pull --prune
git checkout <feature_branch>
pytest --showlocals

Impacted Areas in Application
List general components of the application that this PR will affect:

:white_check_mark: Build ebook_homebrew 1.0.486 completed (commit https://github.com/tubone24/ebook_homebrew/commit/aa5436f1fd by @)


WIP Dom facet removal

https://github.com/facets-io/facet-extension/issues/180#issuecomment-764192442

https://github.com/facets-io/facet-extension/issues/180#issuecomment-764192442


tests, integ: Do not run test_nm_ovs_plugin_missing

When running test_nm_ovs_plugin_missing test, the NM ovs plugin is
removed. Unfortunatly it fails to be re-installed when the test ends.
Until this issue is fixed, the test is marked not to run in the suite.
Ref: https://github.com/nmstate/nmstate/issues/759

Coverage remained the same at 65.913% when pulling 05c311a990e365d11e269bea2b40e67c8443ce15 on EdDev:ovs-tests-do-not-run-missing-plugin into 7b0f97dc461407e1565323e66e8d55f6e359ed2d on nmstate:master.

Coverage remained the same at 65.913% when pulling 05c311a990e365d11e269bea2b40e67c8443ce15 on EdDev:ovs-tests-do-not-run-missing-plugin into 7b0f97dc461407e1565323e66e8d55f6e359ed2d on nmstate:master.

Rebase/merge exception: DCO job seems to be stuck but the signature is present.


discrete choice modeling blogpost

This PR adds a notebooks which will form the second Colgate client write-up blog posts.
The first post was Causal sales analytics: Are my sales incremental or cannibalistic?
NOTE: I'll be pretty aggressive about hiding most of the code cells in the final blogpost in order to maximise readability.
Current state: At this point (2024/10/31) I've basically written the first half of the blog post. It outlines the basic discrete choice model and sets up the core limitation of producing uninteresting cannibalization effects.
TODO

[ ] We might want to play with the random seed to get the synthetic data nice
[ ] We might also want to tweak the synthetic price data to allow for better parameter identiability
[ ] Potentially add a manufacturer (or benefit) effect to really show the lack of interesting cannibalization effects.
[ ] I'm hoping that either @ricardoV94 or @lucianopaz or @cluhmann will take over the reigns and continue the blog post to talk about the core innovations of what we did. We are allowed to talk about the maths of the nested logit, but we're not allowed to present code to implement it.
[ ] Hoping someone can write a nice overview of the cool new stuff that was done. I'll then come back in and wrap it up with the executive summary at the start and a conclusion summary at the end.

@drbenvincent I'm leaving some comments from your part of the blogpost, before I start on the second part:

A single intercept doesn't make sense. I assume you meant B_0_^i (one intercept per item), as you have in the model description below?
In the model description the line u_{i,t} = a = b, dosen't make math sense. You introduce a log of the price, which is clearly not equivalent to the original expression on price. Also the brackets are strange. You are not multiplying the intercept by the price, I assume?
Multinomial model is very confident because total_sales is high. We obviously had more noise in our data, and that's why we had to switch the the DirichletMultinomial model instead, as the Multinomial cannot expalin so large errors with these high total sales. May be worth mentioning?
"So this is all great, but it's the kind of output that data scientists would enjoy." Is there irony in this sentence or missing a "not"?
What-if scenario. Needs a bit more text explaining what results we can see from the 5 plots?
I don't like the plot showing the market share before and after as the distance from the x=y line. This will never show anything interesting unless you remove an item that has a sizeable portion of the market-share (which you would never do anyway). It's also mostly wasted white space on the plot. I would rather show the ratio of market share before or after as a plot-bar, which will clearly show everything going up by the same %. Conversely: imagine you remove an item with a 1% market shaere and another item takes all this market share (perfect cannibalization), it would go from x to x+1%, which would still look super boring on the plot you defined. The plot is not good to show what you want.

Obligatory message: I think overall the blog is in a pretty nice shape!

I'm going to push a second NB that uses pre-generated data according to the NLM. I think this will streamline the blogpost, showing where it fails and why the NLM can address it.


Rust analyzer doesn't like rtt_init_target

With this simple code, RA throws the error: "field up of Channels is private":
#![no_std]
#![no_main]

#[cortex_m_rt::entry]
fn main() -> ! {
    rtt_target::rtt_init_print!();
    loop {}
}

#[panic_handler]
fn panic(_info: &core::panic::PanicInfo) -> ! {
    loop {}
}

This expands to:

Full macro expansion
#![feature(prelude_import)]
#![no_std]
#![no_main]
#[prelude_import]
use core::prelude::rust_2021::*;
#[macro_use]
extern crate core;
#[macro_use]
extern crate compiler_builtins;
#[doc(hidden)]
#[export_name = "main"]
pub unsafe extern "C" fn __cortex_m_rt_main_trampoline() {
    __cortex_m_rt_main()
}
fn __cortex_m_rt_main() -> ! {
    let channels = {
        use core::mem::MaybeUninit;
        use core::ptr;
        use ::rtt_target::UpChannel;
        use ::rtt_target::DownChannel;
        use ::rtt_target::rtt::*;
        #[repr(C)]
        pub struct RttControlBlock {
            header: RttHeader,
            up_channels: [RttChannel; (1 + 0)],
            down_channels: [RttChannel; (0)],
        }
        #[used]
        #[no_mangle]
        #[export_name = "_SEGGER_RTT"]
        pub static mut CONTROL_BLOCK: MaybeUninit<RttControlBlock> = MaybeUninit::uninit();
        unsafe {
            ptr::write_bytes(CONTROL_BLOCK.as_mut_ptr(), 0, 1);
            let cb = &mut *CONTROL_BLOCK.as_mut_ptr();
            let mut name: *const u8 = core::ptr::null();
            name = "Terminal\u{0}".as_bytes().as_ptr();
            let mut mode = ::rtt_target::ChannelMode::NoBlockSkip;
            mode = ::rtt_target::ChannelMode::NoBlockSkip;
            cb.up_channels[0]
                .init(
                    name,
                    mode,
                    {
                        static mut _RTT_CHANNEL_BUFFER: MaybeUninit<[u8; 1024]> = MaybeUninit::uninit();
                        _RTT_CHANNEL_BUFFER.as_mut_ptr()
                    },
                );
            cb.header.init(cb.up_channels.len(), cb.down_channels.len());
            pub struct Channels {
                up: (UpChannel,),
            }
            Channels {
                up: (UpChannel::new(&mut cb.up_channels[0] as *mut _),),
            }
        }
    };
    ::rtt_target::set_print_channel(channels.up.0);
    loop {}
}
#[panic_handler]
fn panic(_info: &core::panic::PanicInfo) -> ! {
    loop {}
}

It seems like the complaint is likely at ::rtt_target::set_print_channel(channels.up.0); and I think a fix would be from updating the below block:
pub struct Channels {
    /* make this `pub` */  up: (UpChannel,),
}

But I'm still trying to figure out where this comes from in source.
RA is in the wrong here since it compiles correctly (and weirdly puts the squiggles in the wrong place) but it's probably easier to fix on this end.

This should be closed with #21


[Tracking] Generation of testing data

For testing of the imageCorrelation program I will need some data to test the code.
TODO

[x] Find some image data to test the code
[x] Save the image data in a matlab file format
[x] Write a first version of the imageCorrelation program
[ ] Test the first version of the program with the test data

As a start, I will use a square and move it around sinusoidally.

when testing, what happens when the shapes are small and the shifts are large? I suspect zeros gamma will happen.

I have made some simple test data, sinusoidal motion of a square and did a preliminary test of the code. It seems to be behaving as expected.


Fix "channel" warning

Fixing warning:
dotnet_install: Warning: Value "Current" is deprecated for -Channel option. Use "STS" instead

@clintcparker thank you for your contribution!


Add regression test for GP

I made a regression test for SVGP based on http://gpflow.readthedocs.io/en/latest/notebooks/multiclass.html. The core of GP computations are at conditional and log_prob, so it is not necessary to test for other models. Will add other tests in the future if I find it necessary.
I also made a small fix at matrix_triangle_solve_combat to address "torch.trtrs has support for grad on CPU in pytorch 0.4".
I have tried to benchmark the pyro GP with gpflow and observed:

With the same model as in the regression test (with num_steps=20000), same dtype (float64), and the same optimizer (Adam), it took 1m for pyro GP vs 45s for gpflow on CPU. The fact that Pytorch uses inverse to solve triangular equations in multivariate distribution might be the main reason for this slowness. These might be some reasons such as: some of our computations are redundant, gpflow uses  Gaussian-Hermite quadrature to compute likelihood, gpflow uses analytic kl divergence, pyroGP uses extra_event_dims which might be slow?
Both pyro GP and gpflow are slower when trained on GPU (this might be expected, due to the dataset is not large). Slowness: pyro GP GPU > gpflow GPU ~ pyro GP CPU > gpflow CPU
The performances (loss) on both frameworks are similar.

This pull requests will be cleaned after #987 with whiten support.

@eb8680 I thought a regression test should be in 1 minute? The time is linear with num_steps, so which number you think is fine? We are free to change it. :)


test tool found memory occupation goes up

What command(s) is the bug in?
cargo run --release --features=scroll -- --circuits sc --suite nightly --inspect Create2Recursive_d0_g0_v0，
Describe the bug
while debugging, found mpt_ciruict::assign_para costs lots of memory, and the root cause is  test of create2_recursive generating lots of mpt proofs/regions, assign_para calls halo2 mock prover  fork method,  the fork method does couple of clones operations.
Concrete steps to reproduce the bug. If it's able reproduce via testool, please share test_id from jenkins report
No response

close as PR #1144 merged.


Release 0.9

merge berkeley into main (should be quick, because mina was just merged to berkeley)
sort out the clear mina side branch that corresponds to the new main (should be compatible with testnet & snarkyjs and be able to merge to release/2.0.0
add missing stuff to changelog
bump version

Indirectly Irresponsible Individual: @mitschabaude
(Gregor, if you end up taking this work on then let me know and we'll find someone else)


ratbagctl rewrite and test suite

Well, there are still a few FIXMEs here and there, but better sending this one out before it gets too much of a beast.
The idea is to instantiate a driver-test libratbag element, and playing with unit tests to see if we messed up the parsing of rabtagctl.
This gives a good idea if ratbagctl/ratbagd works as expected.
The current test run takes roughly 21 seconds on my machine, most of the time is spent by forking, initializing the bus, and settings the devices, etc...
I have a local version that creates only one dbus connection and directly calls the parsing/function from ratbagctl. This version runs in less than a second but fails because ratbagctl python binding doesn't listen for signals and can't update its internal state. I tried playing with the GLib.MainLoop, without success.

Done. I amended according to your comments and added a .flake8 file (and fixed warnings).
flake8 circleci is still not triggered and ratbagd_device_new() still not fixed


Missing types for query() method

According to internals.d.ts, the query method has the following types:
    /**
     *
     * @param {Type<T> | string} directiveOrSelector
     * @param {{read}} options
     * @returns {T}
     */
    query<R>(directiveOrSelector: string, options?: {
        read;
    }): Element;
    query<R>(directiveOrSelector: Type<any>, options?: {
        read;
    }): R;

That means that you have to cast the return value of the query method when passing a selector before you can use it. Can't we change the API so you can do: spectator.query<HTMLElement>('a').click()?

Isn't it simply just a question of changing Element to R here? https://github.com/NetanelBasal/spectator/blob/master/src/lib/src/internals.ts#L69

In general, you are right. It's a question of what is the more common case? If you most of the times query for DOM element it's more convenient. Don't you think so?

Then perhaps change the return value to HTMLElement instead of Element so common things like .click() work without having to cast the return value?

Because i didn't know that API existed 😁

It will click and trigger change detection for you.

Excellent! Just changed my test to use that API :)

https://netbasal.gitbooks.io/spectator/api.html

I guess we can close this issue then.

I love your idea, but it means that if I changed it, everyone would get the any type. It means that you must pass a type.
spectator.query<HTMLButtonElement>("button");

You could do query<R = Element>(directiveOrSelector: string, options?: { read }): R;

lol, that's precisely what I did right now.

I'm releasing a new version with this change for all queries methods.

Great, thanks!

Thank you. Feel free to give more feedback or issues. :)


github workflows setup

Description
Summarize the changes and the related issue. Include relevant motivation and context.
Fixes # (issue)
Type of change

[ ] Bug fix
[ ] New feature
[ ] Breaking change
[ ] Documentation update

How Has This Been Tested?
Describe how the changes were tested.
Checklist:

[ ] My code follows the style guidelines of this project
[ ] I have performed a self-review of my code
[ ] I have commented my code
[ ] I have made corresponding changes to the documentation
[ ] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Fix typo and add URL to README.md

This one is actually from my fork...

Ok @ct2034 , the lint action actually did not run from forks but I just changed it so it does.

Ah, we need to only push to GHCR if not on a fork, will do that next.

Ah, we need to only push to GHCR if not on a fork, will do that next.

No I think that should be good. It will be tagged based on the branch and only main pushes as latest. That’s how I set it up anyway

Ah yes. You are right. Sorry

Can you also add the condition to the release step? Sorry I am on my phone in the keynote of Magnus egerstedt ;)


The button to 'Add more' is missing

Hello,
The video includes a button to 'add more' RIs after you have selected your first. My interface does not include that button so it is going to take ages to purchase the 20+ RIs we've decided upon.
Any reason as to why I can't add more? Does the video need to be updated?
I have a screenshot.
Sam

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: edda1fe4-6ce9-ccf2-bc1b-65e9818b1060
Version Independent ID: 5151901d-a4d3-1148-811f-8c9a959608a3
Content: Prepay for Azure virtual machines to save money
Content Source: articles/virtual-machines/windows/prepay-reserved-vm-instances.md
Service: virtual-machines-windows
GitHub Login: @yashar
Microsoft Alias: banders

@mtwelve Thanks for your question. We are checking on this and will respond to you soon.

@yashar please add your comments

@bandersmsft We see that the add more option is removed.
Please update @mtwelve with the reason and update the video in the doc.

@mtwelve I'm investigating this with the engineering team and I'll reply when I have more info.

@mtwelve Hi. Sorry for this oversight. The Add more option is only avaliable to customers with an EA subscription. I'll update the article to clarify.
#please-close


[IZPACK-1297] Linux Shortcuts not installed when run as sudo

This is a fix for https://izpack.atlassian.net/browse/IZPACK-1297.
There has been a missing override in com.izforge.izpack.util.os.Unix_Shortcut, which prevented to gather the icon filename completely in UNIX.

IzPack project » izpack #895 SUCCESS
This pull request looks good
(what's this?)


update weak ciphers/tests etc, closes #931

adds the new tests including the non-JS JA3
Stats: the code numbers are from https://dxr.mozilla.org/mozilla-central/source/security/manager/ssl/nsNSSCallbacks.cpp#903
Telemetry from SSL_CIPHER_SUITE_FULL:

go to https://telemetry.mozilla.org/
click Measurement Dashboard, etc

@rusty-snake @earthlng : get in quick so I can merge this for 78 (being an ESR release)

the numbers
e.g.
    case TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA:
      value = 3;

Go to telemetry and the value 3 shows the percentage using that cipher

if you hover over one of the orange SHA-1 thingys under Cipher Suites @ https://browserleaks.com/ssl it says:

Secure Hash Algorithm 1 (SHA). The Secure Hash Algorithm 1 has been proven to be vulnerable to collision attacks as of 2017 (cf. shattered.io). While this does not affect its usage as a MAC, safer alternatives such as SHA-256, or SHA-3 should be considered.

so AFAICT link [1] has nothing to do with this and is misplaced. The SHA-1 collision stuff that the link talks about, I think (!) only affects the aspect or use of SHA1 that we already disable in 1220.
I think we can also drop the DHE stuff now that it's disabled by default. Since Chrome and all other major browsers have apparently disabled this a long time ago, the chances that FF will re-enable it again is probably very low.

I think we can also drop the DHE stuff now that it's disabled by default

I was going to remove them when ESR68 is EOL

so AFAICT link [1] has nothing to do with this and is misplaced

You and @rusty-snake can sort the references out :) go for it

How do you like this?
/** CIPHERS [WARNING: do not meddle with your cipher suite: see the section 1200 intro]
 * These are all the ciphers still using SHA-1 and CBC which are considered weaker than the available alternatives. (see "Cipher Suites" in [1])
 * Additionally some have other weaknesses like key sizes of 128 (or lower) [2] and/or no Perfect Forward Secrecy [3].
 * [1] https://browserleaks.com/ssl
 * [2] https://en.wikipedia.org/wiki/Key_size
 * [3] https://en.wikipedia.org/wiki/Forward_secrecy
 ***/
/* 1261: disable 3DES (effective key size < 128 and no PFS)
 * [1] https://en.wikipedia.org/wiki/3des#Security
 * [2] https://en.wikipedia.org/wiki/Meet-in-the-middle_attack
 * [3] https://www-archive.mozilla.org/projects/security/pki/nss/ssl/fips-ssl-ciphersuites.html ***/
   // user_pref("security.ssl3.rsa_des_ede3_sha", false);
/* 1263: disable DHE (Diffie-Hellman Key Exchange)
 * [1] https://www.eff.org/deeplinks/2015/10/how-to-protect-yourself-from-nsa-attacks-1024-bit-DH ***/
   // user_pref("security.ssl3.dhe_rsa_aes_128_sha", false); // [DEFAULT: false FF78+]
   // user_pref("security.ssl3.dhe_rsa_aes_256_sha", false); // [DEFAULT: false FF78+]
/* 1264: disable the remaining non-modern cipher suites as of FF78 (in order of preferred by FF) ***/
   // user_pref("security.ssl3.ecdhe_ecdsa_aes_256_sha", false);
   // user_pref("security.ssl3.ecdhe_ecdsa_aes_128_sha", false);
   // user_pref("security.ssl3.ecdhe_rsa_aes_128_sha", false);
   // user_pref("security.ssl3.ecdhe_rsa_aes_256_sha", false);
   // user_pref("security.ssl3.rsa_aes_128_sha", false); // no PFS
   // user_pref("security.ssl3.rsa_aes_256_sha", false); // no PFS

I didn't include the telemetry stats data because (1) we strongly warn "to not meddle with your cipher suite", (2) all the prefs are inactive, (3) as far as I understand it it's not even very representative because it depends on the system and FF version someone uses to access a particular site and it could also come from people who visit a testing site that deliberately uses an old cipher like fe https://static-rsa.badssl.com/ etc and (4) it looks messy.
I changed ALL: use SHA1 and CBC which should be considered broken [1] [2] to something that says they're weaker instead of broken because as I said above link [1] doesn't apply and [2] is mitigated in FF since a long time according to https://en.wikipedia.org/wiki/BEAST_attack#Web_browsers:

Mitigations against POODLE attack:

Mozilla Firefox: complete (support of SSL 3.0 itself is dropped since version 39. SSL 3.0 itself is disabled by default and fallback to SSL 3.0 are disabled since version 34, TLS_FALLBACK_SCSV is implemented since version 35. In ESR, SSL 3.0 itself is disabled by default and TLS_FALLBACK_SCSV is implemented since ESR 31.3.)

I'm happy if you and @rusty-snake are happy
I wanted the stats to show that the risk is negligible. I also wanted to try and worm in a line about "if a downgrade attack is your worry, then use Tor Browser" or something. IDK, how many times do we need to say don't meddle? :) But sure, I can do without the stats (one less thing to do), and people should read. So go for it

(4) it looks messy.

Nah, it was fuckin awesome™ :) but now a moot point

 * [1] https://browserleaks.com/ssl is already listed in the section header

I changed ALL: use SHA1 and CBC which should be considered broken [1] [2] to something that says they're weaker instead of broken because as I said above link [1] doesn't apply and [2] is mitigated in FF since a long time according to

If something is weak and had already some attacks on it, IMHO it is broken, since there will come more attacks/an attacker can find new attacks. Anyway looks good.


Failed to load the atom-terminal-panel package

[Enter steps to reproduce below:]

...
...

Atom Version: 1.0.11
System: Ubuntu 15.04
Thrown From: Atom Core
Stack Trace
Failed to load the atom-terminal-panel package
At Cannot find module 'atom-space-pen-views'

Error: Cannot find module 'atom-space-pen-views'
    at Module._resolveFilename (module.js:328:15)
    at Function.Module._resolveFilename (/usr/share/atom/resources/app.asar/src/module-cache.js:383:52)
    at Function.Module._load (module.js:270:25)
    at Module.require (module.js:357:17)
    at require (module.js:376:17)
    at global.include (<anonymous>:25:9)
    at Object.<anonymous> (<anonymous>:9:13)
    at Object.<anonymous> (<anonymous>:1:1)
    at Module._compile (module.js:452:26)
    at Object.defineProperty.value [as .coffee] (/usr/share/atom/resources/app.asar/src/compile-cache.js:169:21)

Commands

Config
{
  "core": {
    "themes": [
      "one-dark-ui",
      "solarized-dark-syntax"
    ]
  },
  "editor": {
    "fontSize": 12,
    "invisibles": {}
  }
}

Installed Packages
# User
node-on-fire, v0.1.0
seti-icons, v0.4.5

# Dev
No dev packages

Go to ~/.atom/packages/atom-terminal-panel and execute npm install.

@The-Doodler How did you install the package? Looks like you probably did not use the package manager in Atom or the apm install <package> command? I recommend you install the package using either of those two approaches. If you're trying to develop against the package, you'll need to install its dependencies and in that case follow the general concept in @peduxe's comment with respect to executing apm install.

Thank you for your issue!
We haven't gotten a response to our questions in our comment https://github.com/atom/atom/issues/8687#issuecomment-138058070. With only the information that is currently in the issue, we don't have enough information to take action. I'm going to close this but don't hesitate to reach out if you have or find the answers we need, we'll be happy to reopen the issue.


bitback stuck at linux-raspberrypi-1_4.19...

Description
Every time I using bitbake i get stuck at the following line and always at 74% :
0: linux-raspberrypi-1_4.19.115+gitAUTOINC+b13fc60b52-r0 do_fetch (pid 65500)  74% |##############################################################                      | 18.24 MiB/s
I've searched the forums and it's not a matter of the task taking a long time, since i left it over night and when i woke up it did nothing.
In all my tries i never managed to pass this step

Steps to reproduce the issue:

git clone -b master git://git.yoctoproject.org/poky
git clone -b master git://git.openembedded.org/meta-openembedded
git clone -b master https://github.com/agherzan/meta-raspberrypi.git
source oe-init-build-env
Added meta-raspberrypi to BBLAYERS:

  /home/elian/Yocto/poky/meta-raspberrypi \
  /home/elian/Yocto/poky/meta-openembedded/meta-filesystems \
  /home/elian/Yocto/poky/meta-openembedded/meta-gnome\
  /home/elian/Yocto/poky/meta-openembedded/meta-initramfs\
  /home/elian/Yocto/poky/meta-openembedded/meta-multimedia\
  /home/elian/Yocto/poky/meta-openembedded/meta-networking\
  /home/elian/Yocto/poky/meta-openembedded/meta-oe\
  /home/elian/Yocto/poky/meta-openembedded/meta-perl\
  /home/elian/Yocto/poky/meta-openembedded/meta-python\
  /home/elian/Yocto/poky/meta-openembedded/meta-webserver\
  /home/elian/Yocto/poky/meta-openembedded/meta-xfce\

Added to conf/local.conf:

GPU_MEM = "16"

DISTRO_FEATURES_append = " systemd"
VIRTUAL-RUNTIME_init_manager = "systemd"
DISTRO_FEATURES_BACKFILL_CONSIDERED = "sysvinit"
VIRTUAL-RUNTIME_initscripts = ""

IMAGE_INSTALL_append = " connman connman-client "

DISABLE_SPLASH = "1"

DISABLE_OVERSCAN = "1"
HDMI_GROUP="2"
HDMI_MODE="1"
HDMI_MODE="87"
HDMI_DRIVE="1"
HDMI_FORCE_HOTPLUG="1"
DISABLE_RPI_BOOT_LOGO = "1"
ENABLE_SPI_BUS = "1"
ENABLE_I2C = "1"
KERNEL_MODULE_AUTOLOAD_rpi += "i2c-dev i2c-bcm2708"

MACHINE_FEATURES += "pitft35r"
ENABLE_DWC2_PERIPHERAL = "1"

MACHINE_FEATURES_append = "vc4graphics"
DISTRO_FEATURES_append = " bluez5 bluetooth wifi polkit "

PACKAGECONFIG_append = " gstreamer"
LICENSE_FLAGS_WHITELIST = "commercial"

Describe the results you received:
I get stuck at the following line:
Currently  8 running tasks (3838 of 4375)  87% |###################################################################################################################                 |
0: linux-raspberrypi-1_4.19.115+gitAUTOINC+b13fc60b52-r0 do_fetch (pid 65500)  74% |##############################################################                      | 18.24 MiB/s
Describe the results you expected:
After some time, the task should complete.
Additional information you deem important (e.g. issue happens only occasionally):
Run several times also left it overnight and didn't manage to get it working.
Additional details (revisions used, host distro, etc.):
Distro='poky'

It’s downloading git clone of kernel repository which is quite large (multiple gigabytes) so you might want to check you bandwidth and sometimes server side might disconnect due to glitches etc so please retry and see if that helps

hi @kraj thanks for the quick reply.
As mentioned in the bug report, i left it over night and also retried several times.
Is there a way to see what exacly it's downloading and were it get's stuck because i find it strange to get stuck every time at the same percentage 74%
Regards
Adrian.

Can you clone it without yocto
git clone https://github.com/raspberrypi/linux -b rpi-4.19.y

@Xtazyatu Have you tried to clone the repository externally as suggested above? Does the issue still persist on your machine?

Hi Andrei, Sorry for not posting a reply. Unfortunately, yes still stuck at 74%. Starting to think that this might be an issue with my configuration, although i don't see where could be there problem as it makes no sense to get stuck there everytime.
I'll try a few more things and get back to you.

So it gets stuck on your machine by just doing git clone, did I understand you correctly?

Hi Andrei, so i misread the question. Here is the correct answer. I can do a complete git clone as suggested by kraj. Everything is ok with git clone. Going back to the compiling part, i still get stuck at 74% as described above.

How long does a git clone on the same machine take?

It takes about 10 minutes, here is the terminal output:

elian@ubuntu:~/rpiImage$ sudo git clone https://github.com/raspberrypi/linux -b rpi-4.19.y
Cloning into 'linux'...
remote: Enumerating objects: 7675, done.
remote: Counting objects: 100% (7675/7675), done.
remote: Compressing objects: 100% (3012/3012), done.
remote: Total 7901591 (delta 5616), reused 5309 (delta 4653), pack-reused 7893916
Receiving objects: 100% (7901591/7901591), 2.27 GiB | 19.62 MiB/s, done.
Resolving deltas: 100% (6603051/6603051), done.
Checking out files: 100% (62373/62373), done.

Have you had any luck with it?

That's alright. I'll close this for now but feel free to comment if it persists.

Hi, I have the same problem.

@matzoius can you clone kernel sources outside yocto using plain git clone command ?

Yes, separate cloning works smoothly. Here is the log:
sudo git clone https://github.com/raspberrypi/linux -b rpi-4.19.y linux_test
Cloning into 'linux_test'...
remote: Enumerating objects: 6981, done.
remote: Counting objects: 100% (6981/6981), done.
remote: Compressing objects: 100% (2637/2637), done.
remote: Total 8380604 (delta 5019), reused 5539 (delta 4343), pack-reused 8373623
Receiving objects: 100% (8380604/8380604), 2.43 GiB | 6.69 MiB/s, done.
Resolving deltas: 100% (6998543/6998543), done.
Checking objects: 100% (16777216/16777216), done.
Updating files: 100% (62376/62376), done.
In the image below is my bitbake console. the linux-raspberrypi task will remain forever at 74%

bitbake linux-raspberrypi stops also at 74%
I tried witl all linux versions from poky-dunfell/meta-raspberrypi/recipes-kernel/linux and they all stop at 74%.

I can copy manually the git clone result on the build work folder to overcome this blocking point, but I don't know where the work folder for linux-raspberrypi is.

I think fetcher is making a bare clone so it will take a bit longer I would say leave it for longer and see if it finishes

I found this on the do_fetch log:
Connecting to downloads.yoctoproject.org (downloads.yoctoproject.org)|<IP_ADDRESS>|:80... connected.
HTTP request sent, awaiting response... 404 Not Found
2020-10-06 17:03:04 ERROR 404: Not Found.
DEBUG: Mirror fetch failure for url http://downloads.yoctoproject.org/mirror/sources/git2_github.com.raspberrypi.linux.git.tar.gz (original url: git://github.com/raspberrypi/linux.git;branch=rpi-4.19.y)
Is this s git mirror problem ?

I doubt that, since its a pre-mirror and it should time out.

I left it over night, cpu calmed down since it arrived at 75% and it is still there.

thats not looking good then. what happens if you do
bitbake -ccleanall virtual/kernel
bitbake -cfetch virtual/kernel

does it finish?

First command:
Initialising tasks: 100% |################################################################################| Time: 0:00:00
Sstate summary: Wanted 0 Found 0 Missed 0 Current 0 (0% match, 0% complete)
NOTE: No setscene tasks
NOTE: Executing Tasks
NOTE: Tasks Summary: Attempted 4 tasks of which 0 didn't need to be rerun and all succeeded.
Second command:
Initialising tasks: 100% |##################################################################################################################| Time: 0:00:00
Sstate summary: Wanted 0 Found 0 Missed 0 Current 0 (0% match, 0% complete)
NOTE: No setscene tasks
NOTE: Executing Tasks
Currently  1 running tasks (1 of 1)   0% |                                                                                |
0: linux-raspberrypi-1_4.19.126+gitAUTOINC+f6b3ac28f0-r0 do_fetch (pid 1817080)  74% |#########################################               | 13.72 MiB/s
and remains stuck at 74%


Remove unnecessary return statements

Follows #4444 up. This PR removes unnecessary return statements in the tests.

pfnCI, test this please.

pfnCI, test this please.

Jenkins CI test (for commit ce50155a7023ea3f4267ccb4a3e0dcaeed9f178c, target branch master) succeeded!

Jenkins CI test (for commit ce50155a7023ea3f4267ccb4a3e0dcaeed9f178c, target branch master) succeeded!


Added 27 | Remove Element | Python

Pull Request Template
What have you Changed(must)
Write here what you have changed in the codebase
Issue no.(must) - #686
Pr will be close and marked as spam. If issue number not found or issue was assigned to someone else.
Marking as spam can block your account from HacktoberFest.
Self Check(Tick After Making pull Request)

[x] This issue was assigned to me if not it will be marked as spam.
[x] My file is in the proper folder
[x] I am following clean code and Documentation.
[x] I have added the title and what program will do first in the file
[x] I have named the file as (Problem #). (Problem Title(in Camel Case)).(extension)
ex. 2. AddToNumbers.py

README - How to Contribute

Please Review this @SSKale1


Should m.prop() be observable?

I'm mostly neutral on it, but here's what I'm proposing: m.prop() should accept an optional second argument, a callback, that is called on each value's change with the new value. Something like this:
var prop = m.prop(undefined, function (value) {
    console.log("My new value is: " + JSON.stringify(value))
})

prop(0) // logs 'My new value is: 0'
prop("4 x 4 = 12") // logs 'My new value is: "4 x 4 = 12"'

I know a few Mithril users would appreciate that in core, and it's trivial to add. Just inviting a little discussion here to see if it should be implemented.

In case you're wondering, here's what changes would be made:
// Current version
module.exports = function(store) {
	return function() {
		if (arguments.length > 0) store = arguments[0]
		return store
	}
}

// Proposed
module.exports = function(store, callback) {
	return function() {
		if (arguments.length > 0) {
			store = arguments[0]
			if (typeof callback === "function") callback(store)
		}
		return store
	}
}

props are now streams and replace promises as the return value of m.request (i.e. promises are gone). props are now very similar to flyd streams but also have similar semantics to promises.
Streams cover the use case of observables via the same mechanism that covers promise chaining (via .map), and in addition, it provides mechanisms for combining streams and guarantees atomic updates in O(n), as well as mechanisms for error propagation and handling (like promises do). It also enables update-on-write semantics, which are generally more efficient than doing reactivity in the view (i.e. update-on-read semantics). Also, it's fantasy-land friendly.
And the rewrite branch is still smaller than 0.2.x
There's some preliminary docs here: https://github.com/lhorie/mithril.js/blob/rewrite/docs/prop.md


Update and release Cloud Tasks v2beta2

Closing this as we'll need to regenerate when codegen is fixed.


Custom ops fail when used with recent main line builds of ORT

Due to a change in the logic of when to call the V2 custom op API (https://github.com/microsoft/onnxruntime/commit/37dcefb5b7ed620b823f6638c178eac8b6e0ed9a#diff-eb59007a97532913933bd6d031e8f441215420a2e73657094e85c17a52976d17), onnxruntime-extensions custom ops break with the latest ORT. I think changes are required around https://github.com/microsoft/onnxruntime-extensions/blob/main/includes/onnxruntime_customop.hpp#L283C6-L293C6

One way of fixing this is #606


Solved: Redirecting to homepage #59

Solved #59
The logo is now clickable so that user can redirect into the homepage easily.
https://github.com/UBA-GCOEN/StichHub/assets/106610322/ba75c580-ba26-4240-bef5-400bae3dbfdc

Hello @Naresh-chandanbatve!
Thank you for submitting this pull request Your pull request will be reviewed by maintainers shortly. Meanwhile make sure you have referenced the respected issue in this pr Your pr will not be merged if it does not refer respected pr and have read our Contributing Guidelines https://github.com/UBA-GCOEN/StichHub/blob/main/CONTRIBUTING.md And Code of Conduct https://github.com/UBA-GCOEN/StichHub/blob/main/CODE_OF_CONDUCT.md


Add Haiku OS to the gallery

Hello! Is there a way to add an OS to the gallery? Specifically, I'd like to see Haiku added https://www.haiku-os.org/Created using UTMbotQuestioner: doktorzee#7701Moderator: ✿ Weeb ThatsNiceGuy#7991

I guess it should be a pull request that adds file to https://github.com/utmapp/mac.getutm.app/tree/main/_virtual_machines

With a file to upload to https://github.com/utmapp/vm-downloads/releases

I have a fresh haiku VM if anyone wants to add it.


bring appium client wrapper as well and py3.10 CI

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

41 of 53 (77.36%)  changed or added relevant lines in 5 files are covered.
40 unchanged lines in 1 file lost coverage.
Overall coverage decreased (-8.1%) to 74.165%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

stf_appium_client/cli.py
1
2
50.0%

stf_appium_client/AdbServer.py
1
3
33.33%

stf_appium_client/AppiumServer.py
9
12
75.0%

stf_appium_client/AppiumClient.py
28
34
82.35%

Files with Coverage Reduction
New Missed Lines
%

stf_appium_client/AdbServer.py
40
28.38%

Totals

Change from base Build<PHONE_NUMBER>:
-8.1%

Covered Lines:
333

Relevant Lines:
449

💛  - Coveralls


Revert "chore(deps-dev): bump husky from 8.0.3 to 9.0.6 in /src/main/resources/generator/dependencies/common"

Reverts jhipster/jhipster-lite#8749

why reverting this @qmonmert ? is it broken ?

@pascalgrimaud I had a doubt after merging manually comparing version (why we don't have 9.0.0, 9.0.1 ...)
but it must be good
https://www.npmjs.com/package/husky?activeTab=versions


Test updates event registration

Continue of https://github.com/corona-warn-app/cwa-website/pull/1456

@svengabr
I ran
npm ci
npm run test:prepare
npm run test

and the test for pages/eventRegistration.js  failed. What result do you get?

Follow-up issue https://github.com/corona-warn-app/cwa-website/issues/1503 opened.


A "Best submissions view" is required

A view which will enable the maintainer to download submissions directly, other than going to the server directory to get them.

Sounds good. Go ahead with it.
Make the view for all the submissions stored(the latest and the best) and not just the best submissions.

Resolved in PR #50


serializers: use g.identity instead of system

closes https://github.com/inveniosoftware/invenio-rdm-records/issues/958

Since all the occurrences happen at resources level it is accepted to access the g object. The current_user does not provide an identity (it provides id and roles) and we would need to build the identity from it, which is already stored in g.identity.

It doesnt let me revert the PR, maybe someone with higher powers?


bubble sort

Fix to  Issue #
===============================

===============================
Checklist

[x] I read the contributing guidelines
[ ] I structured my project as stated in the contributing guidelines
[x] My project uses dependencies
[x] I starred the repo
[x] I had fun contributing!

Project reviewed and merged.
Thank you @sulavmhrzn
Feel free to add more projects.


Fallbackid

Here is a WIP for fallback id

Coverage increased (+0.9%) to 75.697% when pulling 1c6e99b86f495cc3e2e17932dcca81738acd24d8 on fallback-id into 350b575a25e72576569712aad218364c40c1cda0 on master.

Coverage increased (+0.9%) to 75.697% when pulling 1c6e99b86f495cc3e2e17932dcca81738acd24d8 on fallback-id into 350b575a25e72576569712aad218364c40c1cda0 on master.

One point of discussion is the signature on the user supplied getObjectId. Now I guess it accepts an extra parameter for path but instead it could have the same signature as before and if it returns undefined then a generated path will be used. It would depend on if the user wants to access the path when he generates the path.

Yes that was my first idea. But I went with a non breaking solution for the first implementation.
I try to think of any possible use case for the implementor of getObjectId to use path but nothing comes to mind. Maybe we shouldn't expose it. This is the very last fallback so it makes sense to be in control of that.

I have tried different approaches regarding to performance but it is hard to get an reliable result. Sometimes the normalize is slower than denormalize, sometimes the other way around. But using less objects and more primitives should be faster so i changed path to be a string and GetObjectToId signature to be
export type GetObjectToIdResult = string | undefined;

export type GetObjectId = (
  object: {
    readonly id?: string;
    readonly __typename?: string;
  }
) => GetObjectToIdResult;

Regarding performance one idea could be to use benchmarkjs. Since benchmarking results may be different between rounds, I think this is mostly useful for comparing things. So one could make a script to compare the latest published version on npm to the current master version for example.

@jonaskello this is almost exactly what i did. I added benchmarkjs projects and have created a simple performance test. I just didn't get the package from npm, only tested with master branch and my feature branch. But the result was different from time to time. Sometimes the master branch was faster and sometimes the feature branch.

Ok, well that's interesting anyway. Did you add those scripts to package.json?

Yes just run yarn performance


Rename evp_pkey_get_EC_KEY_curve_nid to EVP_PKEY_get_curve_nid and us…

…e EVP_PKEY_get_utf8_string_param()
Note that inside EVP_PKEY_get_curve_nid() that the if (pkey->keymgmt == NULL) path
is still being hit during TLS tests.

Checklist

[ ] documentation is added or updated
[ ] tests are added or updated

NOTE: this is related to evp_pkey_get_EC_KEY_curve_nid() being undocumented currently (See #13192)

@mattcaswell - not sure if this is the right approach for this..

The biggest question with this is why do we still need the legacy path?

The biggest question with this is why do we still need the legacy path?

Possible engines?

This pull request is ready to merge

Er, that approval came as a bit of a surprise.  I object and would really want to at least have my proposed alternative tried out.

@levitte - since you objected I added the OTC hold label.

Thanks

Closing since the alternative has been merged.


Add a Portal component for rendering content outside of the current DOM element

Portals allow you to create a separation between the logical React component hierarchy and the physical DOM. See the React documentation on portals for an in-depth explanation, or see the rendered documentation for this component.
Closes #1024
Screenshots
Please provide before/after screenshots for any visual changes

Storybook story
Merge checklist

[x] Added or updated TypeScript definitions (index.d.ts) if necessary
[ ] Added/updated tests

Partial (Storybook story, no automated tests)

[x] Added/updated documentation
[x] Tested in Chrome
[x] Tested in Firefox
[x] Tested in Safari
[x] Tested in Edge

Open questions

Should portaled content be rendered with the same theme found in its logical hierarchy? If so, how?
Anyone know why the rollup build is failing? I'm getting the error: Error: 'PortalProps' is not exported by src/Portal/Portal.tsx, imported by src/Portal/index.ts.

Using a Portal with current behaviors that rely on checking for parent DOM elements such as the closeOnClickOutside behavior in SelectMenu breaks that behavior. I don't think we should add Portal to the public API until we can make sure that Portal will work seamlessly with all of our components.

My expectation is that SelectMenu (and related components) will be refactored to use Portal, useAnchoredPosition, and other yet-to-be added behaviors and components. To me, it doesn't seem that important to built in extra functionality to Portal and other behaviors to support components that will be refactored, particularly since they're not dependent on Portal.

We should add some more examples/instructions to the docs on how to position Portal components.

The Portal component and the useAnchoredPosition hook are fundamentally de-coupled, even though they can (and often will) work together. Once I add useAnchoredPosition I can add examples in docs/Storybook on how to use them together.

As you mentioned in your PR, it looks like because the Portal is registered above the ThemeProvider and BaseStyles they appear with incorrect styles:

Correct. This is currently by design, although I think changing it would be fine. Right now, the default <Portal> will render into a root that is inserted at the root of the DOM. Instead, we can attempt to insert the default Portal root into the nearest ThemeProvider if we find one, otherwise at the root of the DOM. It's not immediately obvious to me how to implement it this way, but I'm hopeful I can figure it out!
Regarding the question of whether or not to add Portal to the public API (i.e. exported from src/index.ts), I can see both arguments, but I would lean toward "yes." I've used components similar to this Portal in other apps for types of UX that will likely not be implemented in Primer Components. Portal is very much a "building block" component and should have sufficient documentation warning of such. We might want to think about the best way to document "composite" vs. "building block" components and behaviors. Perhaps the best way to document this is something like:
Trying to do XYZ? Use the ABC component!

Overall, I think we should address some of the above points, and merge this in for internal use only for now.

Just to be sure, I take this to mean:

Remove the export from src/index.ts
Remove the documentation
Keep the Storybook stories

Does that seem correct?

@T-Hugs yes that seems correct! We should also address the styling issues.
Re:

My expectation is that SelectMenu (and related components) will be refactored to use Portal, useAnchoredPosition, and other yet-to-be added behaviors and components. To me, it doesn't seem that important to built in extra functionality to Portal and other behaviors to support components that will be refactored, particularly since they're not dependent on Portal.

Totally agree, but I think we should exclude Portal from the public API until those components are refactored. How do you feel about keeping this internal only, refactoring all those components during the behaviors epic, then revisiting whether or not Portal should be public at that time? As long as we fix the styling & behavior issues I am not totally against the idea of making it public once it's ready as long as we have the correct guidance needed written up in the docs! 🙌

Great, sounds good to me!

@emplums This is ready to go with the exception of tests. Since you are adding tests in #1041 I was going to wait for that before doing tests for this PR and for #1043. Is it okay to check this in now and follow-up later with tests (particularly since this isn't going into the public API just yet)?

Thanks for the suggestions! I'm going to keep physical DOM parent over browser DOM parent since the language, along with "logical" (used elsewhere in this doc) draws parallels to other physical-vs-logical distinctions, such as physical/logical CPUs and storage devices.


Feature request: Importing from google authenticator android app DB (sqlite3 db)

Would be nice to be ablke to import directly from google authenticator DB.
I created a script for exporting android app db but I didn't found the import format (else I would had created it by myself). Still digging in code

+1
Excellent idea

{
    "<md5 hash of secret>": {
        "account": "<account>",
        "encrypted": false,
        "hash": "<md5 hash of secret>",
        "issuer": "<issuer>",
        "secret": "<secret>",
        "type": "totp"
    },
    ...
}

Did it here  https://github.com/rcoscali/googleauth_db2qr.
but of course require rooted phone for accessing the db
/data/data/com.google.apps.authenticator2/databses
copy the account.db
then:
$ googleauth_db2gr account.db
it will do many things but,  in others, generate authenticator.json U can use to import data.
The importation through QRcode also runs pretty well (a nodejs server is launched and a page with qrcode is dispalyed)

BTW: thanks man! Very good chrome extension. I really use it every day!!
;-)
If I have time I'll hack on google authenticator for sending/receiving data to my chrome and really syncing both.


Rule 7.4: Improve performance

Description
This showed slow performance in our release testing (300 minutes on OpenPilot). On review, the problem was with resolveTypeDefs*() which is very expensive on OpenPilot because it has a lot of typedefs.
I have addressed this by changing the definition of GenericCharPointerType to use recursion instead.
Note: this does not need a change note because it has not been released.
Change request type

[ ] Release or process automation (GitHub workflows, internal scripts)
[ ] Internal documentation
[ ] External documentation
[x] Query files (.ql, .qll, .qls or unit tests)
[ ] External scripts (analysis report or other code shipped as part of a release)

Rules with added or modified queries

[ ] No rules added
[ ] Queries have been added for the following rules:

rule number here

[x] Queries have been modified for the following rules:

Rule 7.4

Release change checklist
A change note (development_handbook.md#change-notes) is required for any pull request which modifies:

The structure or layout of the release artifacts.
The evaluation performance (memory, execution time) of an existing query.
The results of an existing query in any circumstance.

If you are only adding new rule queries, a change note is not required.
Author: Is a change note required?

[ ] Yes
[x] No

🚨🚨🚨
Reviewer: Confirm that format of shared queries (not the .qll file, the
.ql file that imports it) is valid by running them within VS Code.

[ ] Confirmed

Reviewer: Confirm that either a change note is not required or the change note is required and has been added.

[ ] Confirmed

Query development review checklist
For PRs that add new queries or modify existing queries, the following checklist should be completed by both the author and reviewer:
Author

[x] Have all the relevant rule package description files been checked in?
[x] Have you verified that the metadata properties of each new query is set appropriately?
[x] Do all the unit tests contain both "COMPLIANT" and "NON_COMPLIANT" cases?
[x] Are the alert messages properly formatted and consistent with the style guide?
[x] Have you run the queries on OpenPilot and verified that the performance and results are acceptable?As a rule of thumb, predicates specific to the query should take no more than 1 minute, and for simple queries be under 10 seconds. If this is not the case, this should be highlighted and agreed in the code review process.
[x] Does the query have an appropriate level of in-query comments/documentation?
[x] Have you considered/identified possible edge cases?
[x] Does the query not reinvent features in the standard library?
[x] Can the query be simplified further (not golfed!)

Reviewer

[ ] Have all the relevant rule package description files been checked in?
[ ] Have you verified that the metadata properties of each new query is set appropriately?
[ ] Do all the unit tests contain both "COMPLIANT" and "NON_COMPLIANT" cases?
[ ] Are the alert messages properly formatted and consistent with the style guide?
[ ] Have you run the queries on OpenPilot and verified that the performance and results are acceptable?As a rule of thumb, predicates specific to the query should take no more than 1 minute, and for simple queries be under 10 seconds. If this is not the case, this should be highlighted and agreed in the code review process.
[ ] Does the query have an appropriate level of in-query comments/documentation?
[ ] Have you considered/identified possible edge cases?
[ ] Does the query not reinvent features in the standard library?
[ ] Can the query be simplified further (not golfed!)

/test-performance


tf.nn.conv2d_transpose error if output-shape is tuple #25609

pr for #25609,
one line to throw error if output-shape is a tuple instead of list in python client nn_ops.py.

Why erroring for tuple instead of converting it to list?

thought it would be an unexpected behavior if I was expecting a tuple output.
https://github.com/tensorflow/tensorflow/issues/25609 proposed error, should I change it to convert to list?

Yes
On Tue, Feb 19, 2019 at 11:37 AM ryan jiang<EMAIL_ADDRESS>wrote:

thought it would be an unexpected behavior if I was expecting a tuple
output.
#25609 https://github.com/tensorflow/tensorflow/issues/25609 proposed
error, should I change it to convert to list?
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
https://github.com/tensorflow/tensorflow/pull/25803#issuecomment-465277055,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAATxRs5tDBsrQZXVgbtN3ap9mohFdY-ks5vPFJjgaJpZM4a_Wi5
.

--

Alex

changed it


set library name per target, requires webpack >= 3.1.0

Hi, this fixes #15
Starting on webpack 3.1.0, library parameter can be a dictionary, see feature at the very end of https://webpack.js.org/configuration/output/#module-definition-systems
I've updated webpack to version 3 which does not pull in any other dependency
The library name when using a script tag is set to VueTabs, using capitalisation suggested in the webpack example (instead of ‘vuetabs')
Easy testing with docs/index.html and using this code instead of app.js:
<script<EMAIL_ADDRESS><script src="../dist/index.js"></script>
<script>
var Tabs = VueTabs.Tabs;
var Tab = VueTabs.Tab;
var app = new Vue({
    el: '#app',
    components: {
      Tabs,
      Tab
    }
});
</script>

Thanks!


hi, How do you get the coordinates of the click?

Nothing here...

Do you want to get the click on the marker or anywhere in the map? Looks like you are mixing two different things. You can just use onClick on the marker if you want the former.

@khollund Yes，I want to get the coordinates of the click position。but，Use onClick can only get center coordinates,

You can call an event on Map onClick, then in that use functionname(map,evt) and then log like:
console.log('Map clicked!',evt.lngLat.lat,evt.lngLat.lng);
Works anywhere in the map, and you can show features under the click using the same functionality.

OK，thank you

Seems like the question got answered by @khollund (thanks!).


Update "Release process" docs

Update the "Release process" docs to reflect the current status.
Potentially relevant references:

https://github.com/pypa/gh-action-pypi-publish
https://packaging.python.org/en/latest/guides/publishing-package-distribution-releases-using-github-actions-ci-cd-workflows/
https://github.com/python-pillow/Pillow/blob/109c6bf6c0abc00c37b0819ebd573390647692e4/pyproject.toml#L89C7-L94
https://github.com/pypa/cibuildwheel/blob/main/examples/github-deploy.yml
https://cibuildwheel.readthedocs.io/en/stable/

here's sktime's, in case it would be helpful:
https://www.sktime.net/en/stable/developer_guide/release.html

Great reference! Thanks @fkiraly


add arg padding_free to DataCollatorForCompletionOnlyLM

add argument DataCollatorForCompletionOnlyLM(padding_free=True) to utilize https://github.com/huggingface/transformers/pull/31629

cc @kashif this is linked to https://github.com/huggingface/transformers/pull/31629 which will be in the next transformers release!

thanks @ArthurZucker

Gentle ping and info, this post covers the support in transformers: https://huggingface.co/blog/packing-with-FA2

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.


Development Setup Broken on Windows

Describe the Bug

Running npm i fails at the postinstall step which runs electron-builder install-app-deps. I've tried with a fresh installation of Windows - no success.
This is likely a result of https://github.com/camunda/camunda-modeler/issues/2114 which introduced the postinstall script.
Log:
4598 verbose stack Error<EMAIL_ADDRESS>install: `node-pre-gyp install --fallback-to-build --library=static_library`
4598 verbose stack Exit status 1
4598 verbose stack     at EventEmitter.<anonymous> (C:\Users\PhilippFromme\AppData\Roaming\nvm\v14.17.0\node_modules\npm\node_modules\npm-lifecycle\index.js:332:16)
4598 verbose stack     at EventEmitter.emit (events.js:376:20)
4598 verbose stack     at ChildProcess.<anonymous> (C:\Users\PhilippFromme\AppData\Roaming\nvm\v14.17.0\node_modules\npm\node_modules\npm-lifecycle\lib\spawn.js:55:14)
4598 verbose stack     at ChildProcess.emit (events.js:376:20)
4598 verbose stack     at maybeClose (internal/child_process.js:1055:16)
4598 verbose stack     at Process.ChildProcess._handle.onexit (internal/child_process.js:288:5)
4599 verbose pkgid<EMAIL_ADDRESS>4600 verbose cwd C:\workspace\camunda\camunda-modeler\app
4601 verbose Windows_NT 10.0.19041
4602 verbose argv "C:\\Program Files\\nodejs\\node.exe" "C:\\Users\\PhilippFromme\\AppData\\Roaming\\nvm\\v14.17.0\\node_modules\\npm\\bin\\npm-cli.js" "install" "--production" "--cache-min" "999999999"
4603 verbose node v14.17.0
4604 verbose npm  v6.14.13
4605 error code ELIFECYCLE
4606 error errno 1
4607 error<EMAIL_ADDRESS>install: `node-pre-gyp install --fallback-to-build --library=static_library`
4607 error Exit status 1
4608 error Failed at the<EMAIL_ADDRESS>install script.
4608 error This is probably not a problem with npm. There is likely additional logging output above.
4609 verbose exit [ 1, true ]

Environment

OS: Windows 10
Camunda Modeler Version: 4.8.1

I was able to reproduce it.

Debugging output:
output.txt

It seems that missing Python installation might be the root cause:
gyp ERR! find Python **********************************************************
gyp ERR! find Python You need to install the latest version of Python.
gyp ERR! find Python Node-gyp should be able to find and use Python. If not,
gyp ERR! find Python you can try one of the following options:
gyp ERR! find Python - Use the switch --python="C:\Path\To\python.exe"
gyp ERR! find Python   (accepted by both node-gyp and npm)
gyp ERR! find Python - Set the environment variable PYTHON
gyp ERR! find Python - Set the npm configuration variable python:
gyp ERR! find Python   npm config set python "C:\Path\To\python.exe"
gyp ERR! find Python For more information consult the documentation at:
gyp ERR! find Python https://github.com/nodejs/node-gyp#installation
gyp ERR! find Python **********************************************************
gyp ERR! find Python
gyp ERR! configure error
gyp ERR! stack Error: Could not find any Python installation to use

After Python installation:
output.txt

On Windows you need to take dedicated steps to get node-gyp / native compilation to work.

Installing Python (and Visual Studio Express) are two steps on the checklist.

For what it is worth, we should mention whatever we find out in the Camunda Modeler contributing guidelines, too. Will surely bite many of the potential Windows using Camunda Modeler contributors out there.

It works on my Windows machine.

What I did:

Install nvm-windows
Install Node.js 14.17.0 with nvm-windows
Install Python 3.9.5 from https://www.python.org/
Install Visual Studio 2019 Community from https://visualstudio.microsoft.com/; components:

Node.js
Python
C++
selected also additional C++ components from the list

@philippfromme How does your setup differ?

System info from Visual Studio:
Microsoft Visual Studio Community 2019
Version 16.9.5
VisualStudio.16.Release/16.9.5+31229.75
Microsoft .NET Framework
Version 4.8.04084

Installed Version: Community

Visual C++ 2019   00435-60000-00000-AA549
Microsoft Visual C++ 2019

ASP.NET and Web Tools 2019   16.9.693.2781
ASP.NET and Web Tools 2019

Azure App Service Tools v3.0.0   16.9.693.2781
Azure App Service Tools v3.0.0

C# Tools   3.9.0-6.21160.10+59eedc33d35754759994155ea2f4e1012a9951e3
C# components used in the IDE. Depending on your project type and settings, a different version of the compiler may be used.

Common Azure Tools   1.10
Provides common services for use by Azure Mobile Services and Microsoft Azure Tools.

Cookiecutter   16.9.21111.1
Provides tools for finding, instantiating and customizing templates in cookiecutter format.

IntelliCode Extension   1.0
IntelliCode Visual Studio Extension Detailed Info

Microsoft JVM Debugger   1.0
Provides support for connecting the Visual Studio debugger to JDWP compatible Java Virtual Machines

Microsoft MI-Based Debugger   1.0
Provides support for connecting Visual Studio to MI compatible debuggers

Microsoft Visual C++ Wizards   1.0
Microsoft Visual C++ Wizards

Microsoft Visual Studio VC Package   1.0
Microsoft Visual Studio VC Package

Node.js Tools   1.5.21130.2 Commit Hash:dacc0e71a5e060cdcab466a301cacea359c1b6da
Adds support for developing and debugging Node.js apps in Visual Studio

NuGet Package Manager   5.9.0
NuGet Package Manager in Visual Studio. For more information about NuGet, visit https://docs.nuget.org/

ProjectServicesPackage Extension   1.0
ProjectServicesPackage Visual Studio Extension Detailed Info

Python   16.9.21111.1
Provides IntelliSense, projects, templates, debugging, interactive windows, and other support for Python developers.

Python - Profiling support   16.9.21111.1
Profiling support for Python projects.

Test Adapter for Boost.Test   1.0
Enables Visual Studio's testing tools with unit tests written for Boost.Test.  The use terms and Third Party Notices are available in the extension installation directory.

Test Adapter for Google Test   1.0
Enables Visual Studio's testing tools with unit tests written for Google Test.  The use terms and Third Party Notices are available in the extension installation directory.

TypeScript Tools   16.0.30201.2001
TypeScript Tools for Microsoft Visual Studio

Visual Basic Tools   3.9.0-6.21160.10+59eedc33d35754759994155ea2f4e1012a9951e3
Visual Basic components used in the IDE. Depending on your project type and settings, a different version of the compiler may be used.

Visual Studio Code Debug Adapter Host Package   1.0
Interop layer for hosting Visual Studio Code debug adapters in Visual Studio

Visual Studio Tools for CMake   1.0
Visual Studio Tools for CMake

This likely does it. Windows users simply need to follow the documented steps to get compilation / node-gyp to work.

Assigned to @philippfromme to validate and fix (documentation wise).

I was missing the C++ build tools. Such an easy fix. Thanks for your effort, @barmac. 🏅 I will update the documentation. Follow-up issue: https://github.com/camunda/camunda-modeler/issues/2274


Regression with pushing down timestamp functions to Postgresql

SELECT ts_col
FROM postgresql.public.tab
WHERE ts_col >= now() - interval '1' day

In 341  filter on ts_col is pushed down to Postgresql and index on ts_col is used
In 342+  full table scan

344 brought some improvements around timestamps and PostgreSQL.
@guyco33 can you please re-verify with that version the bug still exists?

What is the type of ts_col from PostgreSQL perspective?
Can you share DESCRIBE tab from Presto, as well as EXPLAIN ... of that query?
Does the query sent to PostgreSQL have a ts_col >= ? condition, or no condition at all?

ts_col is a Postgres timestamp
create table if not exists tab
(
	id serial not null constraint tab_pkey primary key,
	ref_id integer not null,
	data jsonb,
	created_at timestamp not null,
	updated_at timestamp not null
)

In 342  The query in Postgres looks like this:
SELECT "created_at" AS "created_at" FROM "public"."tab"

without the condition at all

DESCRIBE bookkeeping.public.odrs
341:
Column	Type
id	integer
ref_id	integer
data	json
created_at	timestamp(3)
updated_at	timestamp(3)

342:
Column	Type
id	integer
ref_id	integer
data	json
created_at	timestamp(6)
updated_at	timestamp(6)

It might be that 342 doesn't pass the filter, since the value of now() - interval '1' day is not timestamp(6)

@guyco33
we hit some roadblock with a fix for this (see https://github.com/prestosql/presto/pull/5673, https://github.com/prestosql/presto/pull/5675, https://github.com/prestosql/presto/issues/5685).
As a workaround, try replacing now() function in your query with localtimestamp,
or explicitly casting RHS of the comparison to timestamp(p) [without time zone].

https://github.com/prestosql/presto/pull/5692


Recorder: Request Body saved as Response Body

Hi,
After some testing with the recorder, when checking "Save & check response bodies", it seems that the content of the *_response.txt file is the request body (the same as the *_request.txt file) instead of the response body.
I'm running gatling 2.1.5 highcharts bundled on Windows 7.
Thank you for your help.

@TheCopycat Thanks for reporting!


UI Refresh: Add an option to filter trade history by market

Feature Proposal
Add an option to filter trade history by market
Rationale
Trade history can be difficult to track with combined markets
Implementation
Add a filter option at the top of the table

Needs design


Do some docs improvements

Do a few minor improvements, note please that patch one is not just docs it introduces the rustfmt::skip trick for public re-exports. Its part of "docs improvements" because it includes adding doc(inline). The other two are trivial.

The doc inlining of public re-exports might be breaking the feature tag/flag thing in the  HTML, I need to investigate more.


RD2: Handle Installment Opportunities when an RD is closed

Handle Open Opportunity attached to a Recurring Donation when it is closed so that users do not continue to expect donations from the donor.
Critical Changes
Changes
Issues Closed
New Metadata
Deleted Metadata

**lurch: attach W-037452

Tracking W-037452

Really nice (again). I'm impressed that you were able to refactor the comment blocks in the UTIL classes so quickly. As you suspected, I do think that the new CloseActions enum should only apply to RD2 code. Even though the enum is effectively a duplicate of what exists in the RD_RecurringDonations class, it's probably safer to leave the legacy code untouched. Plus having a separate enum would give us the ability to expand the options at some point (if ever needed) without impacting the legacy RD logic.

@force2b , changes for legacy RD code have been reverted for legacy code. However, there is common code in NPSP Settings RD settings and custom settings facade. I left it to use legacy RD constants. If any change is to be made, we can apply it in this PR or resolve in W-035815. Since values are the same for both legacy and enhanced RDs, should we still have usage of different constants based on if RD2 is enabled?

Thanks @RadSFDeveloper. I'm advocating for different constants to allow us to expand behavior at some future point without requiring any changes to the legacy code. Still, as you've noted there is some shared code such as in NPSP Settings RD Controller and the CustomSettingsFacade class. Those are probably fine for now. If we do decide to change or expand the RD2 specific behavior there would only be these two places to modify change where the Enum values come from.

@force2b , can you please review merge conflict resolution and clean up applied in commits today? Thank you!

@Julian88Tex , the PR is ready for testing. Thank you!

Testing has passed for WI: https://foundation.lightning.force.com/lightning/_classic/%2Fa2x1E000001HoUqQAK


[18] Citation info and basic citation / knowledge flows

Closes #18
Collect citation info for AI + covid papers and performs cross-tab by field of study.

Great, thanks Juan.
Regarding the notebooks:

I've updated my notebook accordingly, so others can use it (using dotenv and the ipy preamble)
I've removed the API key from your new notebook so someone doesn't come across it and use it!

... and now I've migrated the keywords to model_config.yaml as requested (thanks, good idea):
https://github.com/nestauk/covid-19_research/pull/21/files#diff-c839db98b6229c56edb5166e3f6027c7R18


Fix PR commit links on submission (GitHub’s bug)

GitHub has had this really annoying bug that changes PR commit links (e.g. this one) into non-PR-related links like this: https://github.com/sindresorhus/refined-github/commit/cb44a4eb8cd5c66def3dc26dca0f386645fa29bb
This only happens to auto-linked URLS like https://...etc and not to [text](https://...etc)
We can't fix these links after they've been submitted but we can do it before submission.

This feature should should:

Listen to comment form submissions
Detect plain URLs to PR commits (and skip markdown links)
Replace plain urls with identical markdown links, like [https://...etc](https://...etc)

Step 2 is easy to implement in most places (e.g. find a URL surrounded by spaces) but it can be tripped with content like [this url https://... is the problem](https://...) (which... probably does not happen)
Test comment content:
https://github.com/sindresorhus/refined-github/pull/3/commits/cb44a4eb8cd5c66def3dc26dca0f386645fa29bb

IssueHunt Summary

 max-arias has been rewarded.
Backers (Total: $18.81)

 fregante ($18.81)

Submitted pull Requests

#3085 Added feature to stop GH from replacing Pr links to commit links

Tips

Checkout the Issuehunt explorer to discover more funded issues.
Need some help from other developers? Add your repositories on IssueHunt to raise funds.

cc @lukehefson just in case he can fix this internally.

Thanks for the ping @fregante! Did you submit a bug report to our Support team? And if so, do you think you could DM (twitter, email) me the ticket reference?

looks like this was solved?

https://github.com/sindresorhus/refined-github/pull/3/commits/cb44a4eb8cd5c66def3dc26dca0f386645fa29bb

Nope. I just posted https://github.com/sindresorhus/refined-github/pull/3/commits/cb44a4eb8cd5c66def3dc26dca0f386645fa29bb but the link points to `https://github.com/sindresorhus/refined-github/commit/cb44a4eb8cd5c66def3dc26dca0f386645fa29bb

I'll give this a shot!

Pr up: https://github.com/sindresorhus/refined-github/pull/3085

This is really cool—the find of feature that makes me proud to use Refined GitHub. Nice work everyone. The styling of the warning is especially nice.

Glad you like it, this bug annoyed me for a long time.
Some fixes to this feature are coming in #3223

This doesn't really explain why GitHub changing the link is a problem. I.e. what is wrong with the link they transform the original into?

Great feature! Minor inconsistency with GitHub:
When publishing a link in another repo, it should be like this:

Maxim-Mazurok/google-api-typings-generator@429318c

and not like this:

429318c

This doesn't really explain why GitHub changing the link is a problem. I.e. what is wrong with the link they transform the original into?

The difference is subtle, but you can open the 2 links in the first paragraph of this PR and compare them.
What the user pastes:
// https://github.com/sindresorhus/refined-github/pull/3/commits/cb44a4eb8cd5c66def3dc26dca0f386645fa29bb

What GitHub displays:
// https://github.com/sindresorhus/refined-github/commit/cb44a4eb8cd5c66def3dc26dca0f386645fa29bb

In short: The correct link shows the commit on the PR page, while GitHub drops this piece of information, showing a link to the plain commit, without any connection to the PR.
@Maxim-Mazurok I opened an issue about that, thanks!

So if you want to link to commit, it's fine to go with GitHub's version and if you want to show the commit in context of the PR then use the button to fix the link. Makes sense.
I wondered if they do that because the link in PR context can become stale, like if the commit is rebased, but I guess the direct commit link could also then become stale after GC.
Anyway, thanks for the feature and the explanation.


No type info on model query response

Hi!
I've followed the steps in README.md but got an issue with the type of model query response.
Having the table types:
interface Users {
  id: Generated<number>;
  name: string;
  email: string;
}

interface DB {
  users: Users;
};

and the model defined:
export default class User extends db.model('users', 'id') {
  static findByEmail(email: string) {
    return this.findOne('email', email);
  }
}

My query doesn't have return type info, which is breaking type-safety in queries:
import User from "./User"

async function demo() {
  const user = await User.findByEmail("aa")
  console.log(user.aaa) // should fail here, b/c User doesn't have `aaa` field?
}

Sandbox with repo
Is this expected to be working?

More info for it.

It is reproducible only for find* methods
It is reproducable only latest kysely release, 0.23.5.

I will check it with last version but I am working on something else these days.

Fixed in latest version


gamepad: enhanced native standard layout support

What issue is this addressing?
Updates #2052
What type of issue is this addressing?
feature
What this PR does | solves
Refactors native standard layout so standard axes and buttons can be implemented using any of axes, buttons or hats.
This is required to be able to implement a native standard layout mapping for Linux, as e.g. shoulder buttons can be backed either by an analog or digital input.
Precedes https://github.com/hajimehoshi/ebiten/pull/2587

Note that I had decided to only represent analog inputs in 0..1 range in the interface - which means that for an axis-to-axis mapping, we first map -1..1 to 0..1, and then back to -1..1.
Not TOTALLY nice, but do note that this loses at most one bit of accuracy as the multiplications by 0.5 or 2 are just exponent inc/dec.

Please fix the test failures.

Please fix the test failures.

Sure, am on it - have to wait for a build for each iteration, as I don't have many of these platforms easily available locally.

If you want, I can change this around and make the range of Value() always -1..1 - but that makes the threshold comparisons more ugly.

It would gain 1 bit in float64 accuracy, which I strongly doubt matters for gamepads ;)

I don't think we should do this. As you said, we should not have to care the 1bit accuracy.


Required feature: A Collection manifest, for better serialization and deserialization

From my own experience, the most frustrating part of working with the library is when it comes to send a collection hover the network, specially when transferring Redux state from server to client during server side rendering.
Everything is cool as long as you only use Map and List, you serialize with JSON.stringify() and you deserialize with Immutable.fromJS() and you are done. The problems start when you use Record, and I personally use Record almost everywhere I have an Object, because they allow me to define shape. So to reconstruct my state on the client side I have to write and maintain a very big reviver function and supply it to Immutable.fromJS().
It would be nice if we could have this:
Immutable.Serialize = (col: Collection): { json: string, manifest: string } => {}
Immutable.Deserialize = (json: string, manifest: string): Collection => {}

The Serialize() function produce an object with two keys:

json: the same output as JSON.stringify(), it might include some marker data, for keyless records
manifest: a json string representing the definition of all the records involved

Then on the client side, we will just call Deserialize() to get the Collection back, with all records.
I think this will really help.

The module transit-immutable-js is doing is a good answer to this. You still have to manually maintain the list of records, but it is a great improvement from having to write a big reviver yourself.


RFC: deriving for single field structures

Proposal
Currently the following program from our time library works and correctly derives all the instances:
def Offset : Type := UnitVal 1
  deriving Repr, BEq, Inhabited, Add, Sub, Neg, LE, LT, ToString

However if we wanted to refactor this to a single field structure to make writing instances such as Decidable for LT easier:
structure Offset : Type where
  val : UnitVal 1
  deriving Repr, BEq, Inhabited, Add, Sub, Neg, LE, LT, ToString

The following deriving handlers:
Add, Sub, Neg, LE, LT, ToString

all fail with:
default handlers have not been implemented yet, class: 'Add' types: [Std.Time.Second.Offset]

Based on some preliminary reading of the deriving framework it seems to me that we have an automated deriving mechanism for all classes for just def but this just gives up on single field structures right away. I propose that we improve this mechanism to allow such automated deriving for all single field structure's as well.
Impact
Add :+1: to issues you consider important. If others benefit from the changes in this proposal being added, please ask them to add :+1: to it.

RFC accepted!
Note that very much unlike def, we can't just rely on definitional equality but have to transform the existing instance, which in the case of dependencies might not even be possible in general. So this is a pretty complex task and it will likely take some time for us to get to it.


update action-gh-release template file to more accurate matching

What type of PR is this?
/kind flake
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?:

/approve


Improve plugin installation instructions

Example would be sufficient, atleast give an example as to how one should install this plugin in the first place ?

@anandgavai could you suggest how the two line instruction could be made clearer? Thx!

Can you make it clear for example
bin/kibana-plugin install
https://github.com/nyurik/kibana-vega-vis/releases/download/<latest_version>.zip
what does <latest_version>.zip mean ? and is it applicable to all versions
of Kibana or elasticsearch.
Can you give an example of <latest_version>.zip. I was not able to install
it on my mac !
On Thu, Mar 15, 2018 at 12:12 AM, Yuri Astrakhan<EMAIL_ADDRESS>wrote:

@anandgavai https://github.com/anandgavai could you suggest how the two line
instruction https://github.com/nyurik/kibana-vega-vis#quick-demo could
be made clearer? Thx!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/nyurik/kibana-vega-vis/issues/49#issuecomment-373205602,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AGSFlrSbtJ7_-D1618hFOhnjbnustbFkks5teaPTgaJpZM4SrTIP
.

Updated. Does that make it clearer?  You are welcome to propose changes.

Thanks !
It does make it clear as far as installation is concerned, does it depend
on specific version of kibana ?
On Fri, Mar 16, 2018 at 12:47 AM, Yuri Astrakhan<EMAIL_ADDRESS>wrote:

Updated. Does that make it clearer? You are welcome to propose changes.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/nyurik/kibana-vega-vis/issues/49#issuecomment-373558267,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AGSFlm4-f0gzXOnZcEFj9wwYa38di9o3ks5tev2tgaJpZM4SrTIP
.

Make sure you get the right plugin version that matches your Kibana version, or it won't work! -- I thought this was clear that Kibana version must match which download you get.  Please suggest alternative text.

I was using Kibana 6.2.2 it appears that I will have to downgrade by
version. But its alright.
Thanks !
On Fri, Mar 16, 2018 at 8:06 PM, Yuri Astrakhan<EMAIL_ADDRESS>wrote:

Make sure you get the right plugin version that matches your Kibana
version, or it won't work! -- I thought this was clear that Kibana
version must match which download you get. Please suggest alternative text.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/nyurik/kibana-vega-vis/issues/49#issuecomment-373815152,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AGSFllsFMIO1czyc0XvsjUFdnwMJPsyRks5tfA1EgaJpZM4SrTIP
.

@anandgavai Kibana 6.2+ has a built-in Vega support. The only limitation is that it doesn't have interactive map base layer support (config / kibana / type=map)

Alright thanks, what you suggest ? i continue using 6.2.2 ?
On Fri, Mar 16, 2018 at 9:39 PM, Yuri Astrakhan<EMAIL_ADDRESS>wrote:

@anandgavai https://github.com/anandgavai Kibana 6.2+ has a built-in
Vega support. The only limitation is that it doesn't have interactive map
base layer support (config / kibana / type=map)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/nyurik/kibana-vega-vis/issues/49#issuecomment-373838560,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AGSFliuVkBWobrO2p0o4NhM_lN4aQtHzks5tfCMSgaJpZM4SrTIP
.

@anandgavai unless you need interactive base map (a vega graph that's drawn on top of a map, that can be dragged and zoomed), continue using the latest Kibana & ES. You don't need this plugin.


Automatic Scrolling of Calculator

Related Issuse
Scroll calculator automatically on toggle down  #95
Describe the changes you've made
Now , If Any Topic is opened and if we toggle calculator if it is open than our window smoothly scroll to the calculator .

Your code is not updated, hence will create Problem after merging. So make changes to updated codebase.
I am facing problem while pulling changes from upstream to my local branch and then pushing to remote repo

Your code is not updated, hence will create Problem after merging. So make changes to updated codebase.

I am facing problem while pulling changes from upstream to my local branch and then pushing to remote repo