[Core feature request] fail-fast and max-parallel for matrix strategy

What feature do you need?
https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#jobsjob_idstrategyfail-fast
https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#jobsjob_idstrategymax-parallel
Do you have an example usage?
strategy:
    fail-fast: false
    max-parallel: 2
    matrix:
        environment:
            - windows-2019
            - windows-2022
            - windows-latest

Moving this scope to #368.


bin2llvmir: Constant offsets replaced by bogus pointers

I experimented with the following NASM program faking C++ object initialization:
  SECTION .text
  global main

main:
  push edi
  mov edi, ecx
  mov dword [edi], 0
  mov dword [edi + 4], 0
  mov dword [edi + 8], 0
  cmp edi, esi
  je .done
  mov eax, edi

.done:
  pop edi
  ret

After compiling with nasm -f elf and decompiling with RetDec, I got a rather surprising result:
int32_t g1 = 7;
int32_t g2 = 0x447c700;

int main(int argc, char ** argv) {
    int32_t v1 = 0; // ecx
    *(int32_t *)v1 = 0;
    *(int32_t *)(v1 + (int32_t)&g1) = 0;
    *(int32_t *)(v1 + (int32_t)&g2) = 0;
    int32_t result;
    if (v1 == 0) {
        // 0x0
        result = 0;
        // branch -> 0x1d
    } else {
        // 0x1b
        result = v1;
        // branch -> 0x1d
    }
    // 0x1d
    return result;
}

Where the global variables g1 and g2 came from isn't really obvious, why pointers to these are being used as offsets neither. This change is introduced by the -constants parameter to bin2llvmir and is visible in the .ll file already.

Never mind. Looked into it and the trouble is that this application has 0 as its start address - so RetDec considers 4 and 8 addresses pointing to some data. Recompiling to have a non-zero start address makes this go away.


Add support for Custom CSS

In version 2.6 there was very useful option to define our own CSS rules, but I don't see it anymore.
I really hope it will make a comeback, as there are a few (subjective) tweaks I'd love to apply to the UI.

Would a browser extension like stylish be an acceptable replacement?
When I added the "Custom CSS" field, these kind of addons didn't exist and I feel like they do the job better than I could.

I'm actually a big fan of UserStyles and am already substituting the functionality with them.
That being said, they aren't ideal solution:

aren't ubiquitous (I made the switch to CommaFeed because I wanted to have my RSS reader anywhere, be it my PC, laptop, workstation or smartphone).
there is no good (in my opinion) mechanism at the moment for synchronizing the styles between devices/browsers.
my instance isn't parked on any domain to match the style against.

If that's helpful I wouldn't mind 'Custom CSS' being on the admin side only, when configuring the server.
In fact, I'd probably be very happy with that. Simple CSS injection into generated DOM.
P.S. Don't use Stylish - it's reported spyware; Stylus is better anyway

Thank you for the detailed explanation of the need for this feature.
I think I'll add it back but maybe not for the 3.0 release.
I aim for the 3.0 version to be a drop-in replacement for 2.6 with no database and no API changes. For this to be added back, I would need to clear the custom CSS field for everybody because it will not be compatible with the new UI and may cause issues. I don't think people would be happy with their custom css disappearing as they may not have a backup, so I plan to move the existing value in another field called "Legacy custom CSS" or something so people can retrieve their css rules.


[Issue 875] - ensures a user cannot be created/updated to have a role higher than c…

…urrent users role and some ui improvements
fixes #875

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/incubator-trafficcontrol-PR/252/

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/incubator-trafficcontrol-PR-trafficops-test/209/

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/incubator-trafficcontrol-PR/253/

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/incubator-trafficcontrol-PR-trafficops-test/210/

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/incubator-trafficcontrol-PR/254/

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/incubator-trafficcontrol-PR-trafficops-test/211/


Unread count in all folders - Would like to exclude some folders like trash etc

Expected behaviour
The unread count shall only count unread messages in certain folder
Actual behaviour
Unread counts all unread messages in all folders even trash and spam
Steps to reproduce

Have two unread messages in the inbox - then unread is 2
Delete one without reading it - so 1 unread in inbox and on trash - then unread is still 2
An email that is treated as SPAM arrives - then unread is 3

Environment
K-9 Mail version: 5.010
Android version:6.0.1
Account type (IMAP, POP3, WebDAV/Exchange): IMAP and POP3

This is by design I think and probably useful to some. I can't see it being done before the wider design overhaul - adding more settings to an already confusing array of settings would be somewhat counter productive.

K@-mail has a very simple settings for this :
Inbox Only - Show unread counts and notifications for messages in inbox only.
Thats a general settings - easy to understand and I think what most people are interested in.


ABB IRB460

Hi
is possible to load in the library a 4 axis robot? ABB IRB460
i've try to follow the structure for 6 axis robot but when i put  "load robot System" component and select my 4 axis robot the component show me the message :  indices over matrix limit
best

There's no support for 4 axis robots. You might be able to 'hack' one in, but I'm not sure exactly if it would be possible as it is, without writing some code.


DataObject::setField() records NULL -> NULL as a changed field

Affected Version
4.3.0
Description
DataObject::setField() records a value change from NULL to NULL as a strict change, even though the value hasn’t actually changed.
Steps to Reproduce
$member = Member::create()->update(['FirstName' => 'Test', 'Surname' => null]);
$member->write();
$member->update(['Surname' => null]); // or $member->Surname = null;
var_dump($member->getChangedFields());

Results in
array (size=1)
  'Surname' =>
    array (size=3)
      'before' => null
      'after' => null
      'level' => int 1

Solution
Probably changing isset() to array_key_exists() in a few places here: https://github.com/silverstripe/silverstripe-framework/blob/4.3.0/src/ORM/DataObject.php#L2630-L2646

You get a similar issue if you omit the 'Surname' in the constructor - but I'd argue it's the same issue (even though you're kind of going from "undefined" to null. This is PHP not JS though).

Cool, tests pass, this is good by me now. But since I've modified it I'll let someone else merge.

Fixed in 4.4.x-dev

This is happening again for me in 4.6. From what I can see, the DataObject constructor does not include null values (or the corresponding keys) in either $this->record or $this->original, so the array_key_exists() check in setField() always returns false, and the field is marked as changed.


Fix for extensions with multiple segments

Fixes #1731 by cherry-picking commit from @larsbrinkhoff in https://github.com/github/linguist/pull/1830.

This is now live on github.com.


Adding unit tests to check the behavior of post processing rules.

Adding unit tests to show that this is not working correctly.  I will fix the issue shortly after.


TTGO T-Beam V1.1, SX1268 Supported

Hi,
The docs mention support for the "TTGO T-Beam V1 (433MHz SX1278)". Is the 1.1 version of the board also supported? Those seem to be the only ones i can buy on AliExpress. Link
Also i noticed a version of the  TTGO T-Beam V1.1 with a SX1268 chip. This one has a bit more power and lower current draw. Is this chip supported as well?
Thanks,
Regards,
PE1PUX, Erik

imho the version 1.1 should be supported because the only difference seems to be the protection against wrong insertion of the battery.
I don't know about a SX1268-version, where can I buy it?

Does it work fine on the SX1268? How to do it?

SX1268 is still not supported, but I have a board at home to test this out. please stay tune until I have the correct changes.

I tried iGate and Tracker and t-beam with SX1268 does not work.
serial monitor on Tracker:
LoRa_APRS_Tracker.cpp  384 : Starting LoRa failed!

Looks like the v1.1 also uses the AXP2101 power controller, which doesn't initialize: "AXP192 init failed!"
Seems like the fix would be to migrate to the XpowersLib which can do the new chip and the older ones.

My v1.1 SX1268 uses AXP192.

There's some mis-labeling going on with the new T-Beams.  The silkscreen on the board says "TBeam -AXP2102-v1.2".  The big shiny sticker on the end of the board says Model: T-Beam-V1.1.  It also comes with a Neo-M8N GPS module.

version of my board is T22_V1.1 20210222 (SX1268,, GPS NEO-M8N, IPEX )

Mine is like ab0oo's above, and definitely has the AXP2101 PMIC, so incompatible.   Picture Here


Equality of constructed polymorphic types in the SMT solver / hash-consing open refinement types

Aseem and I observed the following issue, where the assertion below fails.
We discussed several potential fixes, including trying to do a better job with hash-consing in the SMT encoding. But, the right fix is quite subtle ...
module Bug
type ordmap
type Good : nat -> Type
type tpar (ps:nat) = m:ordmap{Good ps}

val pstep: ps':nat -> pi:(tpar ps' * unit) -> Tot (tpar ps')
let pstep ps' pi  = MkTuple2._1 pi

let pstep_lemma (ps':nat) (pi:(tpar ps' * unit))  =  assert(pstep ps' pi = MkTuple2._1 pi)

@aseemr: Decided to not implement the fix we spoke about right now. It's not a very robust fix anyway---we cannot rely only on hash consing to get the job done for us. There will always be situations in which slight syntactic differences lead to different terms being generated for the SMT solver. We'll need to come up with a way to recover semantic equality in general ... and then hash consing is just an optimization for shorter proofs.

Sure. For reference, one workaround is to define a custom tuple. That is, instead of type (tpar ps * unit), define a custom tuple: type ctuple: nat -> Type = | Mk_t: #ps:nat -> tpar n -> unit -> ctuple n.

Regarding the workaround: yes, then it is no longer polymorphic.

Cannot reproduce anymore.

Not reproducible.


Drop "ros-image-build"

"ros-image-build" should be dropped, we have "elemental-image-build" now

This is done!


Support declaration of generic type for methods

Dart should support generic methods/functions, similar to Java:
class Foo<E> {
  E _item;
  /* ... */
  <T> T transform(T fn(E)) {
    return fn(_item);
  }
}
Currently this is supported only by omitting the type information. Additionally, some core Dart code includes the <T> annotation within comments: /<T>/. In order for proper tool/IDE support, Dart should support explicitly declaring generic types for a method.

Closed by mistake.

Hi.
Is this ever going to happen?

Yes, it's in progress.

@jodinathan that's working since quite some time already by adding generic type parameters in comments and is supported by dartanalyzer
dynamic /*=T*/ someFunc/*<T,U>*/(dynamic /*=U*/ p1) {
  return someCalc/*<MyType,T>*/() as dynamic /*=T*/;
}

where dynamic is a type that works without using generic type parameters (runtime) and /*=T*/ is the type the analyzer uses to check for type conflicts instead.
There are some issues here (some might be closed) that discuss more details that should help to figure out how to use it.
There seems to be a way to use it without the comments, perhaps a flag, but I don't know details. Just saw it mentioned in some comments.

@zoechi, thanks for the response, however, it seems a bit too hacky for me.
We are still deciding if we will use dart or not in a big project we are projecting. It is important to know where dart is going, and generics is so basic with modern languages that we really expect dart to have it soon.
We were thrilled when studying dart couple days ago, but now there are some down lows that we didn't expect.

@munificent, any information on its schedule? Just being curious.

@jodinathan I wasn't aware you are new to Dart. In this case I can understand :D
I'm using it since several months (with comment syntax) and it's working great but it's not yet released.
What about discussing your issues in https://groups.google.com/a/dartlang.org/forum/#!forum/misc ?

Last time I tried (a couple months ago), generic methods worked for me in dart2js, in Atom with Dart plugin, analyzer supported them, but DartVM still didn't. So, worked everywhere except in DartVM. I could do things like:
T id<T>(T arg) {
  return arg;
}

To enable it for analyzer, so Atom wouldn't highlight them as syntax errors, add to your .analysis_options file:
analyzer:
  language:
    enableGenericMethods: true

And to use them with dart2js, use it with --generic-method-syntax flag, like: dart2js --generic-method-syntax bin/main.dart

Right, Anton just described the options you need to use, so you can use the regular syntax (not the one using magic comments). As long as you do not run in checked mode, you should also be able to use --generic-method-syntax with the virtual machine dart.
However, you should note that the implementations in dart2js and in dart will give you the ability to parse introduction and usage of method type parameters and passing of actual method type arguments, but the runtime semantics associated with these constructs are incomplete: In dart2js, actual type arguments are parsed but then ignored (nothing is passed at runtime, bounds are not checked), and usages of formal type parameters in the body of a generic function or method are replaced by dynamic or a malformed type (so if T is a method type parameter then T t = 42 will not fail, even in checked mode, no matter whether T == int; similarly List<T> will be a List<dynamic>; and 42 is T is a runtime error whereas <int>[] is Listis true). Indart` you get a similar treatment in production mode, but it fails with 'malformed type' in checked mode as soon as you encounter a check that involves a formal type parameter (I suspect this will be changed, because it stops almost all programs using generic functions immediately; but for now you can just use production mode).
This means that you can get the "erased" semantics, which may or may not suffice for your purposes. In Java, for instance, type arguments are always erased, so it might sound fine at first to have this level of support; but as soon as you do things like return new C<T>(..) where T is a method type argument, Dart will reify T in the new object, so you will be able to detect that you got a C<dynamic>, not a C<T>.
And, as Günter mentioned, it's not yet released. ;-)

@munificent, any information on its schedule? Just being curious.

Sorry, no. In general we don't tend to commit to schedules for things since we tend to be pretty fluid about organizing our work and we don't want to set expectations and then annoy people when schedules change.

Dart 1.21 now has generic methods. (There's an informal specification linked from https://github.com/dart-lang/sdk/blob/master/CHANGELOG.md)
Should we close this?

Let's leave it open until the runtime support is there in dart2js and the VM too.

Is there a meta bug that is tracking implementation scope?
What does "runtime support in VM" mean? I thought the VM supports generic methods?

it means reified types:
class C<T> { get t => T; }
f<T>() => T;
main() {
  print(new C<int>().t); // int
  print(f<int>()); // dynamic, but should be int
}

What does "runtime support in VM" mean? I thought the VM supports generic methods?

It parses the syntax but treats all type arguments as dynamic. This does not do anything useful in the VM right now:
isOfType<T>(Object obj) {
  print(obj is T);
}

Ah, gotcha. Thanks for the clarification.

Any update on this? Is the plan to eventually fully support reified generics on methods?

The plan is to fully support reified generics on methods in strong mode and
in Dart 2 (which will be similar to strong mode).
I'm not absolutely sure where strong mode is right now - it already
supported parameters written in comments, and I think it works correctly
with the real syntax too.
We support the syntax, but ignore the actual parameters, in Dart 1
implementations to make the transition easier.
/L
On Tue, Jan 3, 2017 at 7:10 AM, Brad Jones<EMAIL_ADDRESS>wrote:

Any update on this? Is the plan to eventually fully support reified
generics on methods?
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
https://github.com/dart-lang/sdk/issues/254#issuecomment-270056514, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AEo9B_7w8Nq9d8nIfr88ubTDZ5c746LFks5rOeZSgaJpZM4E39PU
.

--
Lasse R.H. Nielsen -<EMAIL_ADDRESS>'Faith without judgement merely degrades the spirit divine'
Google Denmark ApS - Frederiksborggade 20B, 1 sal - 1360 København K

Denmark - CVR nr. 28 86 69 84

@lrhn This is the first I'm hearing of Dart 2. Is there any place I can get some information on it?

Maybe @Irhn is referring to V1.22 ???

On Tue, Jan 3, 2017 at 7:42 AM, Scott Pierce<EMAIL_ADDRESS>wrote:

@lrhn https://github.com/lrhn This is the first I'm hearing of Dart 2.
Is there any place I can get some information on it?

Currently Strong Mode is not really officially Dart (it's not in the spec),
but it is quite successful, so eventually we will nail it down and make it
officially official. We're reserving the version number 2.0 for that time :)
Adding the syntax for generic methods (which was released in v.1.21),
without actually implementing them except in strong mode, is a step towards
supporting strong mode.
/L 'When its ready!'
Lasse R.H. Nielsen -<EMAIL_ADDRESS>'Faith without judgement merely degrades the spirit divine'
Google Denmark ApS - Frederiksborggade 20B, 1 sal - 1360 København K

Denmark - CVR nr. 28 86 69 84

So is it safe to say that if you want to catch up with Dart 2 it is
recommended for you to already use strong mode once you can?
2017-01-03 6:08 GMT-02:00 Lasse R.H. Nielsen<EMAIL_ADDRESS>
On Tue, Jan 3, 2017 at 7:42 AM, Scott Pierce<EMAIL_ADDRESS>wrote:

@lrhn https://github.com/lrhn This is the first I'm hearing of Dart 2.
Is there any place I can get some information on it?

Currently Strong Mode is not really officially Dart (it's not in the spec),
but it is quite successful, so eventually we will nail it down and make it
officially official. We're reserving the version number 2.0 for that time
:)
Adding the syntax for generic methods (which was released in v.1.21),
without actually implementing them except in strong mode, is a step towards
supporting strong mode.
/L 'When its ready!'
Lasse R.H. Nielsen -<EMAIL_ADDRESS>'Faith without judgement merely degrades the spirit divine'
Google Denmark ApS - Frederiksborggade 20B, 1 sal - 1360 København K

Denmark - CVR nr. 28 86 69 84

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/dart-lang/sdk/issues/254#issuecomment-270066036, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AF6Y3qasKaR9WS_k83EfMihopGi-m96Eks5rOgHmgaJpZM4E39PU
.

--
Jonathan Rezende

So is it safe to say that if you want to catch up with Dart 2 it is recommended for you to already use strong mode once you can?

Yes, definitely. :)

any news on this?
generic method with dynamic as the type is not very useful

The limited level of support for generic methods that we call generic method syntax is what we plan to support for Dart 1.x. For full support of generic functions you'd need to switch to strong mode, including the strong mode run-time semantics, or wait for Dart 2.0 (and strong mode is essentially a preview of Dart 2.0).
Note, however, that a language like Java has had generic methods for many years at this level (because type arguments are never reified in Java), and it's not useless:
The static checks that you get with strong mode static analysis (e.g., dartanalyzer --strong ...) will reveal any inconsistencies in your invocations of generic functions/methods, and in the usage of any returned results. However, we can do things like e is T or e is List<T> in Dart, and that won't return the correct result when T is a formal type parameter of an enclosing function/method, unless and until the actual type arguments of  invocations get reified. In Java you also wouldn't get the correct result, you'd get an "unchecked cast" warning, and the non-throwing evaluation of (T)e wouldn't provide any guarantees at all about the actual type of e. So in that sense it's "no worse than Java", but, of course, we want fully reified type arguments for Dart. It just won't happen in Dart 1.x.

@eernstg, can I have full generics with strong mode?
Because I am using it with "analyzer:  strong-mode: true" and T is still dynamic.
About Java...
Personally, I try to compare Dart to more modern language like C#.

You have full generics with strong mode, but the only compiler that can
compile strong mode is DDC.
If you run with the VM or compile with dart2js, then you will get
non-strong mode semantics and no reified method type parameters.
/L
On Wed, Apr 5, 2017 at 4:17 PM, jodinathan<EMAIL_ADDRESS>wrote:

@eernstg https://github.com/eernstg, can I have full generics with
strong mode?
Because I am using it with "analyzer: strong-mode: true" and T is still
dynamic.
About Java...
Personally, I try to compare Dart to more modern language like C#.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/dart-lang/sdk/issues/254#issuecomment-291875557, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AEo9B2ZG65JJFUvgeqrdx7YZCvYHm8Skks5rs6KDgaJpZM4E39PU
.

--
Lasse R.H. Nielsen -<EMAIL_ADDRESS>'Faith without judgement merely degrades the spirit divine'
Google Denmark ApS - Frederiksborggade 20B, 1 sal - 1360 København K

Denmark - CVR nr. 28 86 69 84

Right, and I'll make Lasse's explanation a bit more explicit, because we need to make some distinctions that may not be entirely obvious.
With analyzer: strong-mode: true you'll get the strong mode static analysis; here, a formal type parameter of an enclosing generic function/method is not the same thing as dynamic, it is treated like other type arguments (so it may be known to be a subtype of a given bound, and it may have subtype relationships with other type parameters, etc). Similarly, for actual type arguments at call sites you'd get checks based on the declared bounds of the type parameters. All quite different from dynamic.
DDC will generate code that obeys the strong mode run-time semantics; e.g., it will consider a List<dynamic> to have type List<Object> but not List<int>, and it will consider int foo(Object x); to have type Object Function(int) but not int Function(int), because function type subtyping uses contravariance for parameter types. And it reifies function type parameters.
The situation where you use strong mode static analysis and then run your program using Dart 1.x semantics may seem to be a crazy hybrid that you should never even get close enough to shake a stick at. However, the situation isn't actually so bad.
There are lots of situations where strong mode static analysis will reject a program as erroneous, and Dart 1.x static analysis just emits a warning. Given that Dart 1.x warnings generally mean "this is an error, but we can fix it for you" (so you should never ignore them), this is a matter of workflow and not really language semantics. The function type subtype rules in Dart 1.x are very, very forgiving, and basically the function type subtypes in strong mode are just picking the subset of cases that will actually work. This will allow your strong-mode-checked program to continue to run in some situations where it is passing around "a bad function" (say, because an as expression succeeded, but with strong mode semantics it would have failed), but it shouldn't hurt you when running a "good" program. Finally, dynamic doesn't get to play the role as a bottom type ("the almighty type that can do all things"), and in particular you won't be able, with strong mode dynamic semantics, to pass a List<dynamic> where a List<int> is expected, and if you're actually running with Dart 1.x semantics then this won't be detected (but you may have failures, e.g., failing downcasts, later on when you are using the elements in that list).
When it comes to generic methods/functions, your strong-mode-checked program will use the value dynamic in the cases where static analysis expected the actual type argument to be available, and this may make casts succeed where they should have failed (e as T), and it may insert dynamic into newly created instances (return <T>[]; ), and downcasts may succeed where they should have failed (T x = e;), but otherwise the type parameters actually don't matter at run-time.
The List<dynamic> "will work" for all purposes except for a direct type test (it will return true for myList is List<int> in Dart 1.x), and all the other differences are strongly biased towards errors: As long as your program is "working correctly", you won't see any differences.
With this in mind, we think that it does make sense to run programs in Dart 1.x mode after checking them with strong-mode static analysis.
That said, it will be a relief and an improvement when we get strong mode semantics everywhere, too.
About Java and C#: It isn't necessarily fair to consider reification of type arguments as a modern trait, and erasure as old-fashioned. In the functional community it has been considered as an important property that polymorphic types can be handled in a parametric manner, which basically means that it must be completely impossible for the implementation of any given polymorphic programming abstraction (say, a generic function) to depend on the actual type arguments. In return for this particular restriction, we get theorems for free.
This may indeed be helpful for developers when they are reasoning about their software (e.g., about whether a particular modification preserves the meaning of the program as a whole), but it tends to conflict with another very deep force: Object orientation relies on the ability of objects to report on their type ("I'm a String!", "I'm a BankAccount!"), because this is required in order to allow method invocation to be late-bound (such that we can call the correct method implementation for the given object, which is not known statically).
Reification of type arguments is not something that was invented along with C#, it was part of BETA already in the 1970'ies (in the shape of virtual patterns, which are actually more powerful than type arguments as we know them today).
People will be quick to claim that Java uses erasure because it was impossible to reconcile reified type arguments with the installed base of Java software, and that may indeed be true, but I also think there is a connection to this ancient war between the "theorems for free" crowd and the "OO" crowd. In C#, they made a better choice at some point, at least as seen from the OO side.
In any case, we will have reified generics in Dart, and you can get the full package with strong mode and DDC, and strong-mode-checks-plus-Dart-1.x-semantics as a meaningful stepping stone.
Hope you can live with that for the limited amount of time where it's needed. ;-)
(About the notation: T Function(S) is the new function type syntax. Functional languages commonly use S -> T for the same thing.)

Can this be closed?

Can this be closed?

yup! this was fixed in https://github.com/dart-lang/sdk/issues/27501


What happens to Size/RenderSize and Offset/Margin syncing?

When I was playing with SDK 14965 and its corresponding build I was quite certain that the composition property Size is in sync with the RenderSize of a UIElement and the same goes to Offset and Margin.
But in SDK 15003 and build 15014 Size are Offset are all back to VectorX.Zero again.
Are we going to have xaml/composition property syncing in the future? What's the plan here?

Sorry abut the delay in getting to this. For the question on the future plans, reconciling visual properties and UIElement properties are major priority for the team. This will likely take a few releases as we work on this and we will be pulling in our insiders to help vette plans and test code. As far as perceived property syncing in 14965 versus 15003 and 15003 is concerned - what behavior did you see in 14965 that made it look like there was syncing happening?

@sernaj for example, in 14965 the Size.X is equal to UIElement.ActualWidth and Size.Y to UIElement.ActualHeight.

@JustinXinLiu  Okay, you should be seeing consistent  behavior between all three builds, as we did push the size down starting with the 14393 release and XAML framework layout starting sharing Offset for implicit animation triggers (creating the Offset stomping issue) and we haven't changed that in Creators update. Seeing size at 0 is 10240 behavior and a regression. I haven't seen this, and only way you could get that behavior on build 14393 is by targeting the older SDK in the VS project.  but, I'll definitely check into this. Back to your broader question, yes, we plan to keep moving in the direction of sharing and syncing.

Closing as this should have now stabilized in the builds.


mcmurrayi pub key

@mcmurrayi
Go ahead and uncomment the lines needed in the following files as well:
inventory/group_vars/all/vars
inventory/group_vars/bastion/vars

Uncommented the Petrolink references Cory.
Thanks
Ian McMurray
Chief Systems Architect
Petrolink International Ltd. | 7 Mount Pleasant | Douglas | Isle of Man, IM1 2PU | UK
Office: +44 1624 639270 | Direct: +44 1599 555466 | Cell: +44 7711 413 124
Email<EMAIL_ADDRESS>| www.petrolink.comhttp://www.petrolink.com/
From: Cory Latschkowski @.>
Sent: Wednesday, July 19, 2023 8:21 AM
To: redhat-manufacturing/edge-lab-ansible @.>
Cc: Ian McMurray @.>; Mention @.>
Subject: Re: [redhat-manufacturing/edge-lab-ansible] mcmurrayi pub key (PR #27)
CAUTION - EXTERNAL SENDER: Take extra care with any links or attachments.
@mcmurrayihttps://github.com/mcmurrayi
Go ahead and uncomment the lines needed in the following files as well:
inventory/group_vars/all/vars
inventory/group_vars/bastion/vars

Reply to this email directly, view it on GitHubhttps://github.com/redhat-manufacturing/edge-lab-ansible/pull/27#issuecomment-1641553056, or unsubscribehttps://github.com/notifications/unsubscribe-auth/BBGB57VFN3MLVYECYL4FTSLXQ6DFNANCNFSM6AAAAAA2PMK6EM.
You are receiving this because you were mentioned.Message ID<EMAIL_ADDRESS>
Confidentiality warning: This message and any attachments are intended only for the persons to whom this message is addressed, are confidential, and may be privileged. If you are not the intended recipient, you are hereby notified that any review, retransmission, conversion to hard copy, copying, modification, circulation or other use of this message and any attachments is strictly prohibited. If you receive this message in error, please notify the sender immediately by return email, and delete this message and any attachments from your system. Petrolink International Limited its subsidiaries, holding companies and affiliates disclaims all responsibility from and accepts no liability whatsoever for the consequences of any unauthorised person acting, or refraining from acting, on any information contained in this message. For security purposes, staff training, to assist in resolving complaints and to improve our customer service, email communications may be monitored and telephone calls may be recorded.


License and Readme changes

Updates

Updated link for markdown documentation, preserving legacy adoc
Added MIT license
Removed the release/stage badge for appveyor testing

We'll probably want to update the Master branch appveyor badge to point to your repo @Phil-Factor. If you want help setting up Appveyor, let me know.


Dump on clicking some of packages in zabapgit - CX_SY_RANGE_OUT_OF_BOUNDS

We get the below error when clicking on some of the packages in zabapgit transaction. I have selected the folder logic as ‘FULL’ in the settings. All packages can be seen but on clicking on some of the packages, it dumps saying too long string.
ategory               ABAP Programming Error
untime Errors         STRING_LENGTH_TOO_LARGE
xcept.                CX_SY_RANGE_OUT_OF_BOUNDS
BAP: Program          ZABAPGIT
Error Analysis
An exception has occurred which is explained in more detail below. The
exception is assigned to class 'CX_SY_RANGE_OUT_OF_BOUNDS' and was not caught
in procedure
"INDENT_LINE" "(METHOD)", nor was it propagated by a RAISING clause.
Since the caller of the procedure could not have anticipated this
exception, the current program was terminated.
The reason for the exception is:
An attempt was made in program "ZABAPGIT" to access a part of a string using
an explicitly specified length.
This length (202) was greater than the current length of the string
(200) however.
Access is not possible like this.

@ramprasad-b are you running the latest version?

Hi, This is the version.
INTERFACE zif_abapgit_ajson.
CONSTANTS version TYPE string VALUE 'v1.1.9'

@ramprasad-b thats the ajson version, latest abapGit is v1.125.0, https://github.com/abapGit/abapGit/blob/main/changelog.txt

@ramprasad-b try https://github.com/abapGit/abapGit/suites/17679104279/artifacts/1011472747 from https://github.com/abapGit/abapGit/actions/runs/6663595825?pr=6587, I think there is some other bug, but still it should not dump

@larshp Thanks. System is in version 1.124.0.

okay, please try the build from https://github.com/abapGit/abapGit/suites/17679104279/artifacts/1011472747, to see if it works

@ramprasad-b try the latest build https://raw.githubusercontent.com/abapGit/build/main/zabapgit_standalone.prog.abap

Thanks @larshp . It works with latest v1.125.

👍
closing


Submit vc-test-suite implementation report

Add an implementation report to vc-test-suite, like these:

https://github.com/w3c/vc-test-suite/pull/117
https://github.com/w3c/vc-test-suite/pull/115

As mentioned in https://github.com/spruceid/ssi/pull/153#issuecomment-811309018.

Submitted: https://github.com/w3c/vc-test-suite/pull/119

The implementation report is added and appears in the table at https://w3c.github.io/vc-test-suite/implementations/


HBASE-22808 HBCK Report showed the offline regions which belong to di…

…sabled table

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
140
Docker mode activated.

_ Prechecks _

+1
dupname
0
No case conflicting files found.

+1
hbaseanti
0
Patch does not have any anti-patterns.

+1
@author
0
The patch does not contain any @author tags.

+1
test4tests
0
The patch appears to include 1 new or modified test files.

_ master Compile Tests _

+1
mvninstall
487
master passed

+1
compile
75
master passed

+1
checkstyle
103
master passed

+1
shadedjars
370
branch has no errors when building our shaded downstream artifacts.

+1
javadoc
52
master passed

0
spotbugs
301
Used deprecated FindBugs config; considering switching to SpotBugs.

+1
findbugs
298
master passed

_ Patch Compile Tests _

+1
mvninstall
418
the patch passed

+1
compile
82
the patch passed

+1
javac
82
the patch passed

+1
checkstyle
103
the patch passed

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedjars
367
patch has no errors when building our shaded downstream artifacts.

+1
hadoopcheck
1386
Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.

+1
javadoc
45
the patch passed

+1
findbugs
342
the patch passed

_ Other Tests _

-1
unit
14351
hbase-server in the patch failed.

+1
asflicense
32
The patch does not generate ASF License warnings.

19168

Subsystem
Report/Notes

Docker
Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-465/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/465

Optional Tests
dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile

uname
Linux f597cb0e13d3 4.15.0-55-generic #60-Ubuntu SMP Tue Jul 2 18:22:20 UTC 2019 x86_64 GNU/Linux

Build tool
maven

Personality
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-465/out/precommit/personality/provided.sh

git revision
master / 547cec4078

Default Java
1.8.0_181

unit
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-465/1/artifact/out/patch-unit-hbase-server.txt

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-465/1/testReport/

Max. process+thread count
4714 (vs. ulimit of 10000)

modules
C: hbase-server U: hbase-server

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-465/1/console

versions
git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
120
Docker mode activated.

_ Prechecks _

+1
dupname
1
No case conflicting files found.

+1
hbaseanti
0
Patch does not have any anti-patterns.

+1
@author
0
The patch does not contain any @author tags.

+1
test4tests
0
The patch appears to include 1 new or modified test files.

_ master Compile Tests _

+1
mvninstall
379
master passed

+1
compile
55
master passed

+1
checkstyle
75
master passed

+1
shadedjars
271
branch has no errors when building our shaded downstream artifacts.

+1
javadoc
39
master passed

0
spotbugs
258
Used deprecated FindBugs config; considering switching to SpotBugs.

+1
findbugs
250
master passed

_ Patch Compile Tests _

+1
mvninstall
307
the patch passed

+1
compile
57
the patch passed

+1
javac
57
the patch passed

+1
checkstyle
74
the patch passed

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedjars
272
patch has no errors when building our shaded downstream artifacts.

+1
hadoopcheck
964
Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.

+1
javadoc
34
the patch passed

+1
findbugs
267
the patch passed

_ Other Tests _

-1
unit
17883
hbase-server in the patch failed.

+1
asflicense
131
The patch does not generate ASF License warnings.

21602

Reason
Tests

Failed junit tests
hadoop.hbase.client.TestFromClientSide

hadoop.hbase.master.TestAssignmentManagerMetrics

hadoop.hbase.client.TestSnapshotTemporaryDirectory

hadoop.hbase.namespace.TestNamespaceAuditor

hadoop.hbase.client.TestSnapshotDFSTemporaryDirectory

hadoop.hbase.replication.TestReplicationKillSlaveRSWithSeparateOldWALs

hadoop.hbase.master.procedure.TestSCPWithReplicasWithoutZKCoordinated

Subsystem
Report/Notes

Docker
Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-465/2/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/465

Optional Tests
dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile

uname
Linux b016921e2d3f 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux

Build tool
maven

Personality
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-465/out/precommit/personality/provided.sh

git revision
master / 547cec4078

Default Java
1.8.0_181

unit
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-465/2/artifact/out/patch-unit-hbase-server.txt

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-465/2/testReport/

Max. process+thread count
4972 (vs. ulimit of 10000)

modules
C: hbase-server U: hbase-server

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-465/2/console

versions
git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.


Add template realm as optional

Adding hawkular-realm-for-dev.json in the hawkular-dist as optional file makes easy to populate a demo user when using the hawkular-dist from nexus.
If not, a pre-process to get the UUID is needed and makes things more difficult to start using hawkular from a pom.xml

:+1: , tested both the dev build and the regular build, looks fine on both, ie, the file is available on standalone/configuration for both variants.


Nuxt UI & PurgeCSS

For what version of Nuxt UI are you asking this question?
v2.x
Description
Hello,
I've been trying to make PurgeCSS work properly with Nuxt UI and the deeper I get the more cumbersome of a process it becomes.
It seems that even though I provided the paths towards the NuxtUI components to PurgeCSS, it still removes CSS that should be used by the specified components, as well as colors which should be available out of the box (i.e yellow). I've even tried to safelist different classes, but again, the more I dig through it the more classes I eventually have to add - so I will be ending up with a never ending list of classes.
Are there any official guidelines on how PurgeCSS should be configured so that it works correctly for the NuxtUI components/colors?
Current config:
defineNuxtConfig({
...
 purgecss: {
   safelist: [... big list ...],
   paths: [
      './components/**/*.vue',
      './layouts/**/*.vue',
      './pages/**/*.vue',
      './plugins/**/*.js',
      './nuxt.config.ts',
      './app.config.ts',
<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>    ],
    content: [
      './components/**/*.vue',
      './layouts/**/*.vue',
      './pages/**/*.vue',
      './plugins/**/*.js',
      './nuxt.config.ts',
      './app.config.ts',
<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>    ],
}
});

Thanks in advance :-)

Sorry I have no knowledge of purgecss to help you but I'm linking #877 as it was discussed there if I remember correctly.

Thanks for getting back Benjamin!
I went through the linked issue, and it seems more like a general discussion with different "trials" on how to reduce the bundle/css size of NuxtUI. Is there an "official" standpoint or documentation on how to approach this?
Thanks!


"metadata.properties" file in the segment has non-deterministic order

Hi, I have a question regarding the CRC verfification process. According to current implementation, the CrcUtils will get all files in the given directory, sort them and compute the checksum for them and get the encoded CRC or MD5 value. However, in the corresponding test, CrcUtilsTest, there's a file named "metas.properties" which list the properties of the creation of segment. The order of the properties in the file is not deterministic. So my question is that is the non-determinism desired or undesired? In different environment the order of properties of the same segment could be different, leading to verification failure (different checksum computed). If it is undesired, I can create a PR to fix it and ensure the determinism.

You can also check my draft PR in my forked repo if you like: https://github.com/claudeyj/pinot/pull/2.

cc @saurabhd336 to also take a look
This is great finding! When writing the segment metadata (SegmentColumnarIndexCreator.writeMetadata()), seems there are multiple unordered maps (e.g. customProperties). I'd suggest always ordering the keys using alphabetical order. Currently the dimensions (segment.dimension.column.names) and metrics (segment.metric.column.names) field is using alphabetical order.

Thanks @Jackie-Jiang for the confirmation. I had a PR #10445 to fix this issue and you may want to take a look. Also thanks @saurabhd336 as we previously discussed on Slack. It's also a good strategy to sort the keys before writing. You can consider updating my PR or creating a new one regarding this bug.

Should we also include the indexCreator maps in this scope? i.e. https://github.com/apache/pinot/blob/master/pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/creator/impl/SegmentColumnarIndexCreator.java#L97-L106
these creator maps are HashMaps which may lead to non deterministic ordering (not in metadata.properties, but columns.psf).

Another attempt: #10468

Another attempt: #10468

This PR looks good to me but previously another developer @zhtaoxiang worries about whether replacing HashMap would lead to performance degradation. But if it's not a problem it should be fine. Looking forward to the bug being fixed.

Good call on the performance. Since the maps changed in the PR are all small maps (same size as number of columns), using TreeMap should have at least similar performance as HashMap

That's great, looking forward to the PR being merged.

Thanks for reporting the issue! Closing the ticket as the fix is merged


updated keybinding after separating snippets-menu functionality to separate script in gohan/.local/bin

Excellent! TY ଘ(੭ˊᵕˋ)੭*✩‧⁺‧˚‧₊˚ʚᗢ₊˚✧


Add collapse / expand all for card information

Enhancement
Add collapse / expand all for card information.

Expected behaviour
This collapses/expands all card information, that can be triggered individually with the "More info" button.

Implementation suggestion
https://booktower-ugent-ui.vercel.app/biblio/reviewer/publications/overview.html
Inside bc-toolbar

            <button class="btn btn-tertiary">Collapse all</button>

        <button class="btn btn-tertiary">Expand all</button>

@mietcls with the current rewrites, maybe push back this a little? Might interfere with it

@nicolasfranck sure, I put it in "To review & discuss", we can wait with the implementation until we've done our Templ refactor day.

Not for now


[?] How to visualize small AND large variations in confusion matrices

Instructions
Thank you for submitting an issue. Please refer to our
issue policy
for information on what types of issues we address.
Please fill in this template to ensure a timely and thorough response.

Place an "x" between the brackets next to an option if it applies. Example:

[x] Selected option

Please delete this section (all content above this line) before submitting
the issue

URL(s) with the issue:
Please provide a link to the documentation entry in question.
Description of proposal (what needs changing):
Provide a clear description. Why is the proposed documentation better?
Willingness to contribute
The FiftyOne Community encourages documentation contributions. Would you or
another member of your organization be willing to contribute a fix for this
documentation issue to the FiftyOne codebase?

[ ] Yes. I can contribute a documentation fix independently.
[x ] Yes. I would be willing to contribute a document fix with guidance from
the FiftyOne community.
[ ] No. I cannot contribute a documentation fix at this time.

Dear Fiftyone team,
This more of a general question regarding one of your functions and may be out of scope. The function is question is the plot_confusion_matrix function. I wanted to know how can I specify the scale used. I would like instead of count in general rather the distribution values per class. Because I work with unbalanced data therefore even if the predictions are good on a specific class I cant see it in the confusion matrix as easily.

Hi @fathyshalaby, plot_confusion_matrix() has a log_colorscale=True option that helps to visualize both small and large variations within a single confusion matrix:
import fiftyone as fo
import fiftyone.zoo as foz

dataset = foz.load_zoo_dataset("quickstart").clone()

results = dataset.evaluate_detections("predictions", eval_key="eval", classwise=False)

plot = results.plot_confusion_matrix(classes=["person", "cat", "dog"], log_colorscale=True)
plot.show()

If you would instead like another option such as the ability to row- or column-normalize the values in the confusion matrix, that should be pretty straightforward to add as an additional optional flag to plot_confusion_matrix().
A contribution would be welcome 🤗

Hi @brimoor ! Is there any news regarding row- and column-wise normalization?

No flag has been added to the library yet, but here's where results.plot_confusion_matrix() is implemented:
https://github.com/voxel51/fiftyone/blob/79fe485ae8da86a7aef156fdf466f6f7d81a7045/fiftyone/utils/eval/base.py#L262-L280
So, until a builtin flag exists, you can normalize the confusion matrix yourself like so:
import numpy as np

import fiftyone as fo
import fiftyone.core.plots as fop
import fiftyone.zoo as foz

dataset = foz.load_zoo_dataset("quickstart")

results = dataset.evaluate_detections("predictions", gt_field="ground_truth")

counts = dataset.count_values("ground_truth.detections.label")
classes = sorted(counts, key=counts.get, reverse=True)[:10]

cm, labels, ids = results._confusion_matrix(classes=classes, tabulate_ids=True)

# Manually normalize the confusion matrix
cm_sum = cm.sum(axis=1)
cm = cm.astype(float) / cm_sum[:, np.newaxis]

plot = fop.plot_confusion_matrix(
    cm,
    labels,
    ids=ids,
    samples=results._samples,
    eval_key=results.eval_key,
    gt_field=results.gt_field,
    pred_field=results.pred_field,
)

plot.show()

# Optional (in notebooks): attach to session
session = fo.launch_app(dataset)
session.plots.attach(plot)

That's great! Thank you very much for your help!


Add option to open links in Cursor

Hi, @ebetancourt I'd like to be able to use this with Cursor
It's a pretty simple change, thanks!

In the meantime, I found a workaround:
https://gist.github.com/eduwass/e04da7e635e4ef731a2148c86127d42a


UserWarning: The flag devices=-1 will be ignored

🐛 Bug

I use this configuration Trainer(accelerator="gpu", devices=-1, auto_select_gpus=False) as suggested by the doc but I get:
UserWarning: The flag devices=-1 will be ignored, instead the device specific number 1
Even if on my AWS p3.x8large I have 4 GPUs:
[2022-03-31 10:29:41,160][pytorch_lightning.accelerators.gpu][INFO] - LOCAL_RANK: 0 - CUDA_VISIBLE_DEVICES: [0,1,2,3]
Expected behavior
All the GPUs are used.
Environment
SageMaker Container:<PHONE_NUMBER>84.dkr.ecr.eu-central-1.amazonaws.com/pytorch-training:1.9.1-gpu-py38-cu111-ubuntu20.04
PyTorch Lightning Version 1.6.0
Python 3.8
NCCL version 2.7.8+cuda11.1

@mnslarcher Is it possible you used
Trainer(gpus=2, devices=-1, auto_select_gpus=False)

instead of what you wrote here? I can only reproduce it this way (did not run on sagemaker) and the warning would be appropriate here, because the numbers are conflicting each other.
The usage
Trainer(accelerator="gpu", devices=-1, auto_select_gpus=False)

is correct.

You are right @awaelchli , to simplify (aka I'm using devices=-1 and the GPU accellerator) I leaved out details that maybe are important. No, I don't use gpu=2 or another number, in this moment I have gpu=None (null below because is a YAML).
I use Hydra, this is my full config, I didn't change gpus/accelerator/devices from the command line.
_target_: pytorch_lightning.Trainer
accelerator: auto
accumulate_grad_batches: null
amp_backend: native
amp_level: null
auto_lr_find: false
auto_scale_batch_size: false
auto_select_gpus: false
benchmark: false
callbacks: ${oc.dict.values:_callback_dict}
enable_checkpointing: true
check_val_every_n_epoch: 1
default_root_dir: ${checkpoints_dir}
detect_anomaly: false
deterministic: false
devices: -1
fast_dev_run: false
gpus: null
gradient_clip_algorithm: null
gradient_clip_val: null
limit_train_batches: 1.0
limit_val_batches: 1.0
limit_test_batches: 1.0
limit_predict_batches: 1.0
logger:
  _target_: pytorch_lightning.loggers.TensorBoardLogger
  save_dir: ${checkpoints_dir}/tb_logs
  name: ${experiment_name}
  version: null
  log_graph: false
  default_hp_metric: true
  prefix: ''
  sub_dir: null
log_every_n_steps: 50
profiler: null
overfit_batches: 0.0
enable_progress_bar: true
plugins: null
precision: 32
max_epochs: ${training.max_epochs}
min_epochs: null
max_steps: ${training.max_steps}
min_steps: null
max_time: null
num_nodes: 1
num_processes: 1
num_sanity_val_steps: 2
reload_dataloaders_every_n_epochs: 0
replace_sampler_ddp: true
strategy: null
sync_batchnorm: false
tpu_cores: null
ipus: null
track_grad_norm: -1
val_check_interval: 1.0
enable_model_summary: true
weights_save_path: null
move_metrics_to_cpu: false
multiple_trainloader_mode: max_size_cycle

I found the problem... it was this old default: num_processes: 1.
Weird behavior, even if accellerator = GPU (auto) this deprecated bypasses the devices parameter, we can close the issue.

set num_processes is ok


[Chore] Use safe YAML for helm-chart-verify-rbac

Why are these changes needed?
The default PyYAML loaders are not safe for all inputs. This change switches the helm RBAC verification script from CLoader to CSafeLoader.
While I doubt this is being abused currently, there's no reason not to switch to a loader that disallows arbitrary Python object construction.
From the PyYAML documentation:

Loader supports all predefined tags and may construct an arbitrary Python object. Therefore it is not safe to use Loader to load a document received from an untrusted source.

See also the unsafe loader deprecation notice.
Related issue number
N/A
Checks

[x] I've made sure the tests are passing.
Testing Strategy

[ ] Unit tests
[x] Manual tests - I ran the rbac checker script
[ ] This PR is not tested :(

@kevin85421 can you take a look?

You are the 1000th commit! Congratulations!


Issues running with MSSQL and JRE11

I'm having issues getting it running with JRE11 and MSSQL JDBC.
Here are the errors:
[2019-04-11T10:12:52,426][ERROR][logstash.javapipeline    ] Pipeline aborted due to error {:pipeline_id=>"main", :exception=>#<Sequel::AdapterNotFound: com.microsoft.sqlserver.jdbc.SQLServerDriver not loaded>, :backtrace=>["/usr/share/logstash/vendor/bundle/jruby/2.5.0/gems/sequel-5.19.0/lib/sequel/adapters/jdbc.rb:56:in `load_driver'", "/usr/share/logstash/vendor/bundle/jruby/2.5.0/gems/logstash-filter-jdbc_streaming-1.0.5/lib/logstash/plugin_mixins/jdbc_streaming.rb:52:in `prepare_jdbc_connection'", "/usr/share/logstash/vendor/bundle/jruby/2.5.0/gems/logstash-filter-jdbc_streaming-1.0.5/lib/logstash/filters/jdbc_streaming.rb:194:in `prepare_connected_jdbc_cache'", "/usr/share/logstash/vendor/bundle/jruby/2.5.0/gems/logstash-filter-jdbc_streaming-1.0.5/lib/logstash/filters/jdbc_streaming.rb:116:in `register'", "org/logstash/config/ir/compiler/AbstractFilterDelegatorExt.java:56:in `register'", "/usr/share/logstash/logstash-core/lib/logstash/java_pipeline.rb:192:in `block in register_plugins'", "org/jruby/RubyArray.java:1792:in `each'", "/usr/share/logstash/logstash-core/lib/logstash/java_pipeline.rb:191:in `register_plugins'", "/usr/share/logstash/logstash-core/lib/logstash/java_pipeline.rb:447:in `maybe_setup_out_plugins'", "/usr/share/logstash/logstash-core/lib/logstash/java_pipeline.rb:204:in `start_workers'", "/usr/share/logstash/logstash-core/lib/logstash/java_pipeline.rb:146:in `run'", "/usr/share/logstash/logstash-core/lib/logstash/java_pipeline.rb:105:in `block in start'"], :thread=>"#<Thread:0x612bbead@/usr/share/logstash/logstash-core/lib/logstash/java_pipeline.rb:102 run>"}
[2019-04-11T10:12:52,428][ERROR][logstash.agent           ] Failed to execute action {:id=>:main, :action_type=>LogStash::ConvergeResult::FailedAction, :message=>"Could not execute action: PipelineAction::Create<main>, action_result: false", :backtrace=>nil}

And here is my config:
        jdbc_streaming {
          jdbc_validate_connection => true
          jdbc_validation_timeout => 300
          cache_expiration => 60
          cache_size => 20000
          jdbc_driver_library => '/etc/logstash/sqljdbc/mssql-jdbc-7.2.1.jre11.jar'
          jdbc_driver_class => "com.microsoft.sqlserver.jdbc.SQLServerDriver"
          jdbc_connection_string => "jdbc:sqlserver://[Connection Removed]"
          jdbc_user => '[User Removed]'
          jdbc_password => "[Password Removed]"
          statement => "[Query removed]"
          parameters => { "IPAddy" => "queryip" }
          target => "target"

Note that is does work with jre8 and the mssql-jdbc-7.2.1.jre8.jar JAR.

Same problem on jdbc_static filter and the jdbc input.
I explain the problem here.
I give a work around here.
We are working on a proper solution.

This should be fixed by #35, and released in plugin version 1.0.10


Add a link to the GitHub repo from the main site

It would be nice to show people who visit the website that the website is actually open source and give them a link so they can click through to the repo.

its beautifully done by @jordmondson.
closing this now


fix(pd): fix pdilt command

without this, the incidents from the team won't be properly displayed

/lgtm


(example) add new example

add hello server example with custom config.

#311

@untitaker thanks for your review, i change that, please review again.

Thanks!


Theme colors do not affect all input types

Are you requesting a feature, reporting a bug or asking a question?
This is maybe a bug, or maybe I am just doing something wrong.
What is the current behavior?
When I set the theme, my survey looks as shown here:

What is the expected behavior?
I expect setting the theme colors to affect the text for all the questions in the survey.
How would you reproduce the current behavior (if this is a bug)?
Set custom theme colors, as shown in the examples. The theme I am trying to set is a "dark" theme. Some of the questions have the light text and dark background I set, but many still have their default colors. Also, the dropdown ends up with light text and a light background.
Provide the test code and the tested page URL (if applicable)
Test code
let themeColors = Survey.StylesManager.ThemeColors['default'];
themeColors["$main-color"] = palette.primary.main;
themeColors["$main-hover-color"] = palette.primary.dark;
themeColors["$text-color"] = palette.text.primary;
themeColors["$header-color"] = palette.secondary.main;
themeColors["$border-color"] = palette.divider;
themeColors["$header-background-color"] = palette.secondary.main;
themeColors["$body-background-color"] = palette.background.default;
themeColors["$body-container-background-color"] = palette.background.paper;
themeColors["$inputs-background-color"] = palette.background.paper;
themeColors["$error-color"] = palette.error.main;
themeColors["$error-background-color"] = palette.error.light;
Survey.StylesManager.applyTheme('default');

My palette contains the following:
{
  "common": {
    "black": "#000",
    "white": "#fff"
  },
  "type": "dark",
  "primary": {
    "50": "#fff8e1",
    "100": "#ffecb3",
    "200": "#ffe082",
    "300": "#ffd54f",
    "400": "#ffca28",
    "500": "#ffc107",
    "600": "#ffb300",
    "700": "#ffa000",
    "800": "#ff8f00",
    "900": "#ff6f00",
    "A100": "#ffe57f",
    "A200": "#ffd740",
    "A400": "#ffc400",
    "A700": "#ffab00",
    "main": "#ffc107",
    "light": "#ffd54f",
    "dark": "#ffa000",
    "contrastText": "rgba(0, 0, 0, 0.87)"
  },
  "secondary": {
    "light": "#ff4081",
    "main": "#f50057",
    "dark": "#c51162",
    "contrastText": "#fff"
  },
  "error": {
    "light": "#e57373",
    "main": "#f44336",
    "dark": "#d32f2f",
    "contrastText": "#fff"
  },
  "grey": {
    "50": "#fafafa",
    "100": "#f5f5f5",
    "200": "#eeeeee",
    "300": "#e0e0e0",
    "400": "#bdbdbd",
    "500": "#9e9e9e",
    "600": "#757575",
    "700": "#616161",
    "800": "#424242",
    "900": "#212121",
    "A100": "#d5d5d5",
    "A200": "#aaaaaa",
    "A400": "#303030",
    "A700": "#616161"
  },
  "contrastThreshold": 3,
  "tonalOffset": 0.2,
  "text": {
    "primary": "#fff",
    "secondary": "rgba(255, 255, 255, 0.7)",
    "disabled": "rgba(255, 255, 255, 0.5)",
    "hint": "rgba(255, 255, 255, 0.5)",
    "icon": "rgba(255, 255, 255, 0.5)"
  },
  "divider": "rgba(255, 255, 255, 0.12)",
  "background": {
    "paper": "#424242",
    "default": "#303030"
  },
  "action": {
    "active": "#fff",
    "hover": "rgba(255, 255, 255, 0.1)",
    "hoverOpacity": 0.1,
    "selected": "rgba(255, 255, 255, 0.2)",
    "disabled": "rgba(255, 255, 255, 0.3)",
    "disabledBackground": "rgba(255, 255, 255, 0.12)"
  }
}

Specify your

browser: Vivaldi
browser version: 2.3.1440.48
surveyjs platform (angular or react or jquery or knockout or vue): react
surveyjs version: 1.0.66

Thank you for the reporting! I've fixed the bug. Fix will be available in the next minor update.

Very similar question but not sure it would be fixed in your existing bug fix. So, just in case: I have the exact code @awlayton has to set the default theme colors. However, take a look at the border of the textbox in the attached image. It's supposed to be the main color, which I've set to orange. However, the default green main-color is overriding it.

@Aadmaa it should be fixed by the fix above.
Could you please check the example with the latest build: https://plnkr.co/edit/PzcCjxhFRKcVw5v4heRQ?p=preview and if you find any bugs please let me know.
Thanks.

That looks right. Thanks!

It's much better now, however the inputs still do not all have the same text color. My understanding is my theme should make all of the text white, but some is still a shade of grey.

@awlayton looks like a bug for me. I will check it tomorrow. Thank you.

@awlayton  I've fixed the problem. Fix will be available in the next minor release. And I updated the plunker above https://plnkr.co/edit/PzcCjxhFRKcVw5v4heRQ?p=preview


lazily create warg registry client

Due to the change in the warg-client to support the .well-known config redirection, creating the client triggers lookups. So we need to adjust the code to lazily instantiate the registry client to avoid unnecessarily triggering usage.
Fixes #122

Thanks for the quick fix! Should this also bump the patch version to 0.2.1 so it can be released as a fix?

Thanks for the quick fix! Should this also bump the patch version to 0.2.1 so it can be released as a fix?

Technically, it changes a pub method to &mut self from &self. It might be better as 0.3.0. Is that OK, @thomastaylor312 ?

Oh yep you're right. Definitely a 0.3 in that case IMO, but really up to you


Add EmberData to the dictionary

The project has decided to standardize on EmberData instead of Ember Data. Examples are on this API page for EmberData.
I added EmberData to the local project config, but thought maybe this was common enough to be upstreamed too.

Thanks for the PR!


JS: incorrect enum hints and member dropdown when @enum on a new line

Version: 1.43.2
Commit: 0ba0ca52957102ca3527cf479571617f0de6ed50
Date: 2020-03-24T07:38:38.248Z
Electron: 7.1.11
Chrome: 78.0.3904.130
Node.js: 12.8.1
V8: 7.8.279.23-electron.0
OS: Windows_NT x64 10.0.19041
Steps to Reproduce:

Declare a JS object as "enum" in JSDoc comment, one with @enum tag on the same line and one with tag on a new line
See first enum is recognized correctly while second isn't (screenshots)

Does this issue occur when all extensions are disabled?: Yes
'use strict';

/** Enum OK @enum {Number} */
const ENUM1 =
{
	ONE: 1,
	TWO: 2
}

/**
 * Enum NOT OK
 * @enum {Number}
 */
const ENUM2 =
{
	ONE: 1,
	TWO: 2
}

ENUM1.
ENUM2.

This is happening because you have the unclosed Enum1. on the line above Enum2. This means you are actually triggering suggestions for Enum1.Enum2, not on Enum2 itself.
Once you fix that, both case work fine:


Bug fix: Allow loading of metadata for Proxies

Covers a few use cases, mainly when working with merged documents.
A similar problem (with possibly similar fix) has been reported in Doctrine ORM: http://www.doctrine-project.org/jira/browse/DDC-1441

We can do this by checking the interface with instanceof right and get rid of the reflection all together?

I tried, but it seems like "instanceof" does not work properly when the left parameter is a string classname.
Tested on PHP Version 5.3.5-1ubuntu7.4.
There is a discussion on this @ http://php.net/manual/en/language.operators.type.php

Well?

Done. Something else?

I'm still not sure about this change. We don't have anything like this in the ORM so I am not sure. Can we write a test for it so I can better understand what is happening?

This seems to be fixed in doctrine/common now so we don't have to care :)


fix [GitHubDownloads] type error on latest with pre-downloads

Fixes #3786

Messages

:book:
:sparkles: Thanks for your contribution to Shields, @calebcartwright!

  Generated by :no_entry_sign: dangerJS against e80ca2d6de3a80381d9a654efa71ab1411c8f726


Replace example grep pattern by a working pattern

The problem I was running into, with the spotify docker from dockerhub, was that I had a pattern set in my docker exclude file for (for example) ruby:
ruby:[^ ]\+
But the ruby images were getting cleaned up regardless.
It looks like an alpine kind of thing, I tested the code on a few different places (Mac, Debian) where it worked as you'd expect. However, when using Alpine Linux, [^ ]\+ did not return any IDs and cleaned up images I didn't want it to clean up.

Are you sure you were using the same version of Docker on all machines? There is a currently a bug where everything gets cleaned up regardless of exclusion patterns for Docker 1.10+ due to image signatures being now prefixed with sha256. Looks like there are a couple fixes about a month old now that haven't been accepted yet.

@ownaginatious yep! Was using docker 1.9, pretty sure this has something to do with grep on Alpine

@DeviaVir thanks for the contribution! not sure why the original contribution chose to use a less obvious example compared to this one.


Queries against Prometheus are considerably faster than against Thanos Querier -> sidecar -> Prometheus setup

Recently benchmarked the setup and noticed my query was running 7s through StoreAPI, but it took 4s on Prometheus.
We did many optimizations, but there is still a slowness to optimize. I suspect Querier potentially (we never benchmarked it fully),
Some customers notices slowness too:
The same query agains prometheus and the thanos querier.
For all queries I run a warmup query to ensure that all data are cached localy.
Prometheus take:  appr 5s to query a 2 day range
Thanos take: appr 26s  to query a 2 day range (the range Prometheus can provide)
Thanos take: appr 55s  to query a 2 day range (a range in past)

We had past mentions like https://github.com/thanos-io/thanos/issues/631 (for 1y data though).
Of course, query-push down work we planned would help, but not for all  queries, so this ticket is to benchmark that particular path (mentioned in the title)

Still an issue. I've been through all duplicate posts and i didn't find a fix.


detect when setuptools is downlevel and abort the isntall with a good error

Describe the feature
dbt requires a version of setuptools greater than v40.1.0 to install. We should check for this version and raise a useful error message if the user is downlevel.
Describe alternatives you've considered
We can just ignore this and let users get errors about not finding find_namespace_packages at install time.
Additional context
dbt requires the find_namespace_packages function from setuptools, which was introduced in v40.1.0 (see here). We currently crash with a pretty unhelpful error message about cannot import name 'find_namespace_packages'. Instead we should check and raise an error instructing users to run python -m pip install -U seuptools.
Who will this benefit?
Users trying to install dbt, especially those new to python/pip.

really good idea @beckjake - is this something we can hit for 0.15.1? I just put it in that milestone, but we can change to 0.15.2 if needed

Yeah, totally! It should be a trivial change, just a quick tweak to setup.py to catch the ImportError I would guess. If it's harder than that we can kick it out.


ipywidgets fastprogress warning when using search().to_subcatalogue()

Are we maybe missing a module in the nri-cat conda env?

This is a known issue that will hopefully be fixed soon. Not sure there's much we can do at this point unfortunately

Closing as updating ipywidgets should fix the problem. Please feel free to reopen


Update the MySQL to Postgres migration guide with the recent feedback

Summary
I am happy that (also sad about the ambiguities it caused) the guide pick up some attention recently! There are many many feedbacks submitted among the community channels and I would like to address as much as possible.
cc @jprusch

Does it make sense to publish this version right now? I still can't get the pgloader to work with a fresh setup of a Postgres 15 server on Debian. There are some issues with the public scheme, which apparently has not been created, when creating the mattermost database. mattermost scheme exists & is populated with the schema tables. mmuser has permission to use / create in public & mattermost scheme.
Current state of migration on my side:
https://community.mattermost.com/core/pl/95nam57s1pb5mgdmaytaxatzeh

Thanks for the feedback @jprusch I'll try to go over the migration steps with postgres 15 and try to identify issues you have. So far we tested with the minimum supported version but the public schema issue needs to be addressed within the docs.

@nab-77 - I've split the table (76-99) as discussed into 2 sections: actions that can be performed without consequences, and actions that may incur consequences. Please review.
@isacikgoz - Please review to ensure I've categorized correctly.

@cwarnermm looks good to me!

@cwarnermm and @isacikgoz nice update (and see we managed to incorporate more feedback).
@jlandells your feedback most welcome here.

Not sure, if the following text contains typos:
On [newer versions](https://www.postgresql.org/docs/release/15.0/) of PostgreSQL, newly created users do not have access to public schema. The access should be explicitly granted by running GRANT ALL ON SCHEMA public to mmuser'.
Check the last ' after mmuser
SELECT * FROM Configurations WHERE Active = 't';
Is it t or 1?

Thanks @jprusch, that was a typo indeed for the ' character. The other query for configuration table is correct, that's for postgres.


[RUST] ci_cpu docker image build failure.

The ci_cpu docker image fails to build cleanly.  The Dockerfile runs ubuntu_install_rust.sh which in turn executes:
cargo +nightly install rustfmt-nightly --version 1.0.1 --force
Which results in the following build error:
ubuntu_install_rust.sh
^[[0m^[[91m   Compiling scoped-tls v0.1.2
^[[0m^[[91merror[E0277]: the trait bound std::borrow::Cow<'_, str>: std::convert::From<core::str::EscapeDefault<'_>> is not satisfied^[[0m^[[91m
^[[0m^[[91m   --> /opt/rust/registry/src/github.com-1ecc6299db9ec823/rustc-ap-graphviz-306.0.0/lib.rs:551:44^[[0m^[[91m
^[[0m^[[91m    |^[[0m^[[91m
^[[0m^[[91m551 |                     (&*s).escape_default().into()^[[0m^[[91m
^[[0m^[[91m    |                                            ^^^^ the trait std::convert::From<core::str::EscapeDefault<'_>> is not implemented for std::borrow::Cow<'_, str>^[[0m^[[91m
^[[0m^[[91m    |^[[0m^[[91m
^[[0m^[[91m    = help: the following implementations were found:^[[0m^[[91m
^[[0m^[[91m              <std::borrow::Cow<'a, [T]> as std::convert::From<&'a [T]>>^[[0m^[[91m
^[[0m^[[91m              <std::borrow::Cow<'a, [T]> as std::convert::From<&'a std::vec::Vec>>^[[0m^[[91m
^[[0m^[[91m              <std::borrow::Cow<'a, [T]> as std::convert::From<std::vec::Vec>>^[[0m^[[91m
^[[0m^[[91m              <std::borrow::Cow<'a, std::ffi::CStr> as std::convert::From<&'a std::ffi::CStr>>^[[0m^[[91m
^[[0m^[[91m            and 11 others^[[0m^[[91m
^[[0m^[[91m    = note: required because of the requirements on the impl of std::convert::Into<std::borrow::Cow<'_, str>> for core::str::EscapeDefault<'_>^[[0m^[[91m
^[[0m^[[91m
^[[0m^[[91merror: aborting due to previous error^[[0m^[[91m
^[[0m^[[91m
^[[0m^[[91mFor more information about this error, try rustc --explain E0277.^[[0m^[[91m
^[[0m^[[91merror: Could not compile rustc-ap-graphviz.
warning: build failed, waiting for other jobs to finish...
^[[0m^[[91merror: failed to compile rustfmt-nightly v1.0.1, intermediate artifacts can be found at /tmp/cargo-installgw3Wp4

cc @nhynes can you help to take a look?

Huh. I don't think anything changed in rust/ lately? Maybe there was a missing lockfile somewhere. Isn't semver great? I'll take a look now.

I can confirm there is an error locally, was due to a deleted version tag in /opt/rust/sgx , perhaps in upstream

@tgchen can you elaborate a little more detail on the tag you mention above?

I'm working on this literally right now. I'll post back shortly! Super sorry for the long delay.

Ehh. This one was an unfortunate case of rust nightly being unstable (go figure). rustfmt 1.0.1 used APIs that changed since the nightly with which it was originally built. Fortunately, the fix is simple. Thanks for reporting this!


Add extern crate serde in examples/decode.rs

Even though it isn't needed, I found that having extern crate serde is an effective way to get people to include it in Cargo.toml.

👍


eject: Additionally remove react-scripts from dependencies

ATM if react-scripts is (erroneously) declared in dependencies instead of devDependencies or isn't declared at all, the eject script will fail half-way. This change makes it more robust, react-scripts will be removed from either, if present.

Thanks, this looks good!

Cool, thanks!


Fix minor issues in lab

The PR addresses 3 issues:

Users are currently unable to retrieve the OpenShift registry and push images. This PR exposes the registry during setup.
When spinning up the web container in the Containerfile section of Module 2, the host port is already in use by a container running under the root user. This PR changes the host port to an available port.
Some minor typos have been fixed in the lab text.

fix registry and spelling


MQTT not working with MOSQUITTO broker:

Describe the bug
A clear and concise description of what the bug is.
MQTT is not able to connect to test.mosquitto.org (IP address: <IP_ADDRESS>).
What have you tried to diagnose or workaround this issue?
I tried mqtt.eclipse.org (IP address: <IP_ADDRESS>), that worked and I get publish messages etc. and the client is successfully connected to the broker, but test.mosquitto.org does not seem to work.
I checked MQTT explorer, from there I get connection to even test.mosquitto.org as well as mqtt.eclipse.org but zephyr client is problematic with test.mosquitto.org as I use the IP address <IP_ADDRESS> in the configuration file.
It should be noted I am using SARA U201 modem shield with disco_l475_iot1.
To Reproduce
Steps to reproduce the behavior:

mkdir build; cd build
cmake -DBOARD=disco_l475_iot1
make
See error

Expected behavior
A clear and concise description of what you expected to happen.
I should get stable connection as I get with mqtt.eclipse.org (<IP_ADDRESS>).
Impact
What impact does this issue have on your progress (e.g., annoyance, showstopper)
I also want to test TLS client which used to work sometimes ago but I do not know what has changed on my side or on broker side.
Logs and console output
If applicable, add console logs or other types of debug information
e.g Wireshark capture or Logic analyzer capture (upload in zip archive).
copy-and-paste text and put a code fence (```) before and after, to help
explain the issue. (if unable to obtain text log, add a screenshot)
[1B][1;32muart: [1B][m[1B][8D[1B][J[1B][1;32muart: [1B][m[1B][8D[1B][J[00:02:15.608,000] [1B][0m net_mqtt_publisher_sample: mqtt_connect: -60 [1B][0m
[1B][1;32muart: [1B][m[1B][8D[1B][J[1B][1;32muart: [1B][m[1B][8D[1B][J[00:02:19.114,000] [1B][0m net_mqtt_publisher_sample: mqtt_connect: -60 [1B][0m
[1B][1;32muart: [1B][m[1B][8D[1B][J[1B][1;32muart: [1B][m[1B][8D[1B][J[00:02:22.621,000] [1B][0m net_mqtt_publisher_sample: mqtt_connect: -60 [1B][0m
[1B][1;32muart: [1B][m[1B][8D[1B][J[1B][1;32muart: [1B][m[1B][8D[1B][J[00:02:26.127,000] [1B][0m net_mqtt_publisher_sample: mqtt_connect: -60 [1B][0m
[1B][1;32muart: [1B][m[1B][8D[1B][J[1B][1;32muart: [1B][m[1B][8D[1B][J[00:02:29.634,000] [1B][0m net_mqtt_publisher_sample: mqtt_connect: -60 [1B][0m
[1B][1;32muart: [1B][m[1B][8D[1B][J[1B][1;32muart: [1B][m[1B][8D[1B][J[00:02:33.140,000] [1B][0m net_mqtt_publisher_sample: mqtt_connect: -60 [1B][0m
[1B][1;32muart: [1B][m[1B][8D[1B][J[1B][1;32muart: [1B][m[1B][8D[1B][J[00:02:36.647,000] [1B][0m net_mqtt_publisher_sample: mqtt_connect: -60 [1B][0m
[1B][1;32muart: [1B][m[1B][8D[1B][J[1B][1;32muart: [1B][m[1B][8D[1B][J[00:02:40.153,000] [1B][0m net_mqtt_publisher_sample: mqtt_connect: -60 [1B][0m
[1B][1;32muart: [1B][m[1B][8D[1B][J[1B][1;32muart: [1B][m[1B][8D[1B][J[00:02:43.660,000] [1B][0m net_mqtt_publisher_sample: mqtt_connect: -60 [1B][0m
Environment (please complete the following information):

OS: (e.g. Windows)
Toolchain (e.g Zephyr SDK 0.11.3, 2.4.0-rc1)
Commit SHA or Version used latest

Additional context
Add any other context about the problem here.
test.mosquitto.org worked perfectly fine (even with TLS) sometimes ago (1-2 months ago) with 2.3.0 with one of my custom board, but right now I do not know what has changed either on the broker side or something else.
Besides, I get the IP address of test.mosquitto.org using ping. I do not know what is the usual way of getting correct IP address of test.mosquitto.org

I've reproduced the issue with test.mosquitto.org (but not only on current master, 2.2.0 or 2.3.0 failed for me as well).
The problem turned out to be the long response time for the CONNECT message from test.mosquitto.org. By default we timeout the connection after 500 ms, but for test.mosquitto.org I've observed that it took up to 2 seconds to get a response. I think that a valid solution would be to increase the connect timeout in the sample, it should be no harm in general and will improve connectivity to slower brokers, like the aformentioned one. I will submit a fix.

Besides, I get the IP address of test.mosquitto.org using ping. I do not know what is the usual way of getting correct IP address of test.mosquitto.org

The sample was originally intended to test with a broker running in a local network, hence it uses IP addresses directly. For public servers, it's reasonable to use DNS to obtain the IP address of the server (getaddrinfo()). See for instance how http_get sample implements this:
https://github.com/zephyrproject-rtos/zephyr/blob/master/samples/net/sockets/http_get/src/http_get.c#L74

@rlubos thanks for the fix, I will check it with my board.


Single db deployments

Running 2 db migration tools on same db is recipe for disaster. Also we are not memory restricted.
Not doing it.


could you update MVVMToolkitExtensions.WPF.Demo?

could you update MVVMToolkitExtensions.WPF.Demo? thanks

The demo is no longer part of the repo. Any examples and documentation for WPF is now located here which should cover everything. If there's any issues let me know.


Deserialised application settings is null!

Acknowledgement of preliminary instructions

[X] I have read the preliminary instructions, and I am certain that my problem has not already been addressed.
[X] I have thoroughly looked through the available Wiki articles and could not find a solution to my problem.
[X] I am using the latest version of Bloxstrap.
[ ] I did not answer truthfully to all the above checkboxes.

What problem did you encounter?
i dont know what happend, yesterday was working fine but today it give me error.
i also tried to check on wiki and google how to fix it. but i found no solution.
System.AggregateException: One or more errors occurred. (Deserialised application settings is null!)
[Inner Exception]
System.Exception: Deserialised application settings is null!
Bloxstrap Log
N/A
Bloxstrap_20241009T082425Z.log

I recently have the same exact error from Bloxstrap when roblox servers was down today.
Bloxstrap_20241009T104818Z.log

https://github.com/bloxstraplabs/bloxstrap/wiki/"Deserialised-application-settings-is-null!"-when-launching-Roblox


Prop Type depreciation fix for React 16

React 15.5 will warn users that PropTypes is being moved to its own
module. This will fix the warning and should work when React 16 lands.

Thanks!

Per docs, "prop-types" should be a dep, not a dev deps. Currently we are having a fatal error until user understand the problem and install prop-types himself.

Oops, I should have checked that one a bit close. Fixed in 1.0.6.


IRC Username randomly changed

I have an IRC bridge from my slack channel to Freenode. After running for approximately 9 days, I found my bot with the name: 7YUAAYVY7. It was still working, however I don't understand where it got this name from.
I checked the logs, unfortunately I don't have debug turned on, so there was nothing to tell me what happened.
I restarted the bot and the username is now correct.
Very strange bug, but needs to be fixed.

Sounds extremely strange, as there's no code in slack-irc that ever tries to do something like changing a nick. You're sure it wasn't because you used a NickServ registered nickname without authenticating? That would probably result in Freenode changing your nickname.

@ekmartin: AFAIK Freenode doesn't do random nick's like that, AND it was using auth-on-connect via server password. I could tell by the bots hostname that it was fully authenticated, so it can't have been NickServ changing it...
If Freenode changes your nick due to something like that, it would have become "Guest12345" etc.

Hm, weird. node-irc (the IRC library slack-irc uses) doesn't even have API support for changing nicks at runtime, you have to do it by manually sending a raw NICK command to the IRC server - which isn't done anywhere in the slack-irc or node-irc code base.
I'm going to close this, but would be nice if you could run your bot with NODE_ENV=development and report back if it happens again.


Guice bindings for custom authorizer implementations

Allows overriding getAuthModule to inject custom implementations of SingularityAuthorizer

just the one nit, good beyond that 👍


Fix CMake build error on Windows platform

Description
Fixes https://github.com/ARMmbed/mbedtls/issues/1496
Edited by roneld to use github key words
Status
**READY
Requires Backporting
YES
Since this issue introduce from 2.7.x, so if some one want build it on windows platform with Cmake, this patch should be apply.
[Edit] Since this issue is introduced since 2.7.x, this PR requires bacporting to mbedtls-2.7 and mbedtls-2.16
Migrations
NO
Additional comments
Test on

Ubuntu 16.04.2  cmake version 3.10.2
Cygwin cmake version 3.11.1
Windows mingw-w6 x86_64-8.1.0-posix-seh-rt_v6-rev0 and  cmake version 3.11.1

Travis CI failure is DTLS proxy: 3d, min handshake, resumption .............................. FAIL, a known flaky test with some seeds.

I've tested this on Windows with both Cygwin and mingw. Works fine, approving.

Also, https://github.com/ARMmbed/mbedtls/pull/2286 should be closed after merging this PR.

@RonEld
Looks like your comment was addressed and then unaddresed via @geesun geesun force-pushed the geesun:development branch 3 times, most recently from 05eadc1 to 03516f9 15 days ago

I've restored the rework, which looked accidentally reverted. @geesun Could you please confirm you are happy with the PR? Was the fix suggested by @RonEld reverted by accident?

I've restored the rework, which looked accidentally reverted. @geesun Could you please confirm you are happy with the PR? Was the fix suggested by @RonEld reverted by accident?

That's ok for me.  Sorry for late reply.
I try to fix the CI issue, but still don't know why the CI failed.

Jenkins CI failure is only FreeBSD timing test, a known flaky test. Travis CI failure is due to choice of a bad seed for the DTLS proxy; the seed is fixed in development, but not this PR (and that's OK). This is considered a pass.


use docker package

@SepShr I found that there are subprocess.run() for running docker commands. Instead, I found that we can use this docker package: https://docker-py.readthedocs.io/en/stable/index.html#.
For example, you can simply get a short ID (of length 12) of a container named 'pylot' as follows:
import docker
client = docker.from_env()
id = client.containers.get('pylot').short_id

Using subprocess.run() and extracting proper information from its output seems fragile. I recommend using the official docker package. :)

This issue will be closed since the parallel simulation setup uses the docker library extensively in place of shell scripts.


The automated release is failing 🚨

:rotating_light: The automated release from the master branch failed. :rotating_light:
I recommend you give this issue a high priority, so other packages depending on you could benefit from your bug fixes and new features.
You can find below the list of errors reported by semantic-release. Each one of them has to be resolved in order to automatically publish your package. I’m sure you can resolve this 💪.
Errors are usually caused by a misconfiguration or an authentication problem. With each error reported below you will find explanation and guidance to help you to resolve it.
 You can also manually restart the failed CI job that runs semantic-release.
If you are not sure how to resolve this, here is some links that can help you:

Usage documentation
Frequently Asked Questions
Support channels

If those don’t help, or if this issue is reporting something you think isn’t right, you can always ask the humans behind semantic-release.

The release 2.24.0 on branch master cannot be published as it is out of range.
Based on the releases published on other branches, only versions within the range >=2.23.1 <2.24.0-next.1 can be published from branch master.
The following commits are responsible for the invalid release:

feat: add placeholderData to queryObserver (#1161) (3fce2ec)
docs(typescript): add note for custom hooks types (#1185) (6e30aaa)
docs(api): change manual to isEnabled (#1166) (160d1ac)
docs: update sponsors (5bfd7af)
docs: update sponsors (7f35693)
docs(examples): fix sandbox version (df4c755)
docs(examples): fix sandbox version (8001abb)
docs(examples): fix sandbox version (3073ddd)
docs(examples): fix sandbox version (40944e1)
docs(examples): fix sandbox version (a7cff10)
docs(examples): fix sandbox version (21803e3)
docs(examples): fix sandbox version (39c021c)
docs(examples): fix sandbox version (7352b8b)
docs(examples): fix codesandbox version (35060bd)
fully automate the dev setup with Gitpod. (#1155) (812f1e9)
docs: Remove unnecessary --save in install instructions (#1149) (07f06b9)
docs: GQL Blog Example (#1144) (8582a9a)
docs(nextjs-example) init (#1146) (8585a17)
Fix Typo (#1145) (0d97ece)
build: add beta builds (833f518)
docs: Elaborate on usage of queries (#1133) (8669fad)
docs: Add eslint-config-prettier to devDependencies in custom-hooks example (#1127) (6756050)
build: add building support on Windows terminal (#1129) (4a7ca0c)

Those commits should be moved to a valid branch with git merge or git cherry-pick and removed from branch master with git revert or git reset.
A valid branch could be 1.x, master or beta.
See the workflow configuration documentation for more details.

Good luck with your project ✨
Your semantic-release bot :package::rocket:

:rotating_light: The automated release from the master branch failed. :rotating_light:
I recommend you give this issue a high priority, so other packages depending on you could benefit from your bug fixes and new features.
You can find below the list of errors reported by semantic-release. Each one of them has to be resolved in order to automatically publish your package. I’m sure you can resolve this 💪.
Errors are usually caused by a misconfiguration or an authentication problem. With each error reported below you will find explanation and guidance to help you to resolve it.
 You can also manually restart the failed CI job that runs semantic-release.
If you are not sure how to resolve this, here is some links that can help you:

Usage documentation
Frequently Asked Questions
Support channels

If those don’t help, or if this issue is reporting something you think isn’t right, you can always ask the humans behind semantic-release.

The release 2.24.0 on branch master cannot be published as it is out of range.
Based on the releases published on other branches, only versions within the range >=2.23.1 <2.24.0-next.1 can be published from branch master.
The following commits are responsible for the invalid release:

fix: fix semantic release (29944da)
feat: add placeholderData to queryObserver (#1161) (3fce2ec)
docs(typescript): add note for custom hooks types (#1185) (6e30aaa)
docs(api): change manual to isEnabled (#1166) (160d1ac)
docs: update sponsors (5bfd7af)
docs: update sponsors (7f35693)
docs(examples): fix sandbox version (df4c755)
docs(examples): fix sandbox version (8001abb)
docs(examples): fix sandbox version (3073ddd)
docs(examples): fix sandbox version (40944e1)
docs(examples): fix sandbox version (a7cff10)
docs(examples): fix sandbox version (21803e3)
docs(examples): fix sandbox version (39c021c)
docs(examples): fix sandbox version (7352b8b)
docs(examples): fix codesandbox version (35060bd)
fully automate the dev setup with Gitpod. (#1155) (812f1e9)
docs: Remove unnecessary --save in install instructions (#1149) (07f06b9)
docs: GQL Blog Example (#1144) (8582a9a)
docs(nextjs-example) init (#1146) (8585a17)
Fix Typo (#1145) (0d97ece)
build: add beta builds (833f518)
docs: Elaborate on usage of queries (#1133) (8669fad)
docs: Add eslint-config-prettier to devDependencies in custom-hooks example (#1127) (6756050)
build: add building support on Windows terminal (#1129) (4a7ca0c)

Those commits should be moved to a valid branch with git merge or git cherry-pick and removed from branch master with git revert or git reset.
A valid branch could be 1.x, master or beta.
See the workflow configuration documentation for more details.

Good luck with your project ✨
Your semantic-release bot :package::rocket:


check says cask not installed though it is, as install discovers

It seems like brew bundle somehow fails to see what casks are installed. The core of the issue is this output from brew bundle install:

Installing java cask. It is not currently installed.
Warning: Cask 'java' is already installed.

This happens for all my casks, not just java.
Details
Having
# Brewfile:
cask_args appdir: "/Applications"
tap "homebrew/bundle"
tap "homebrew/cask"
tap "homebrew/cask-versions"
tap "homebrew/core"
cask "java"

and having java already installed, when I run check:
$ brew bundle check --verbose --file ./Brewfile
brew bundle can't satisfy your Brewfile's dependencies.
→ Cask java needs to be installed or updated.
Satisfy missing dependencies with `brew bundle install`.

Then running install:
$ brew bundle install --verbose --file ./Brewfile
Skipping install of homebrew/bundle tap. It is already installed.
Using homebrew/bundle
Skipping install of homebrew/cask tap. It is already installed.
Using homebrew/cask
Skipping install of homebrew/cask-versions tap. It is already installed.
Using homebrew/cask-versions
Skipping install of homebrew/core tap. It is already installed.
Using homebrew/core
Installing java cask. It is not currently installed.
Warning: Cask 'java' is already installed.

To re-install java, run:
  brew cask reinstall java
Installing java

Installing java cask. It is not currently installed.
Warning: Cask 'java' is already installed.

To re-install java, run:
  brew cask reinstall java
Installing java

Env

OSX 10.13 High Sierra
brew 1.7.3

What's the output of brew bundle dump?

I am not on my PC so can't upload it. A file with just lines like 'brew
"xyz"' plus the taps you see above, no 'cask...' entries.
On Sat, Sep 8, 2018, 10:47 AM Mike McQuaid<EMAIL_ADDRESS>wrote:

What's the output of brew bundle dump?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/Homebrew/homebrew-bundle/issues/366#issuecomment-419624437,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAmJPmlEBPHThxXfVUOi54KzlaJJsqAGks5uY4QkgaJpZM4We5GJ
.

Please upload it when you’re at your computer.

Brewfile.txt

Thank, it was indeed a problem with cask itself, as running brew cask list showed. Namely it was due to https://github.com/Homebrew/brew/issues/4494, ie.

Cask 'p4merge' is unreadable: undefined method `undent'

and was fixed by manually editing /usr/local/Caskroom/p4merge/.metadata/..../p4merge.rb and removing the .undent. Then brew cask started behaving again.


feat: Add variable fonts for OpenSans

1. Why is this change necessary?
I already implemented the same changes for Shopware 6 and thought Shopware 5 could also need some love. So this PR should potentially reduce transferred bytes, by combining multiple separate font files into one. E.g. currently if one uses two different font weights (e.g. normal and bold) on the same page two font files are downloaded, with roughly 85kb. This can be reduced, e.g. if one uses only the latin charset, only 48kb font files are downloaded. This reduction increases if more font weights are used.
2. What does this change do, exactly?
Add an variable subsetted font to Shopware 5.
3. Describe each step to reproduce the issue or behaviour.
-
4. Please link to the relevant issues (if any).
-
5. Which documentation changes (if any) need to be made because of this PR?
-
6. Checklist

[ ] I have written tests and verified that they fail without my change
[x] I have squashed any insignificant commits
[ ] This change has comments for package types, values, functions, and non-obvious lines of code
[x] I have read the contribution requirements and fulfil them.

Hello,
thank you for creating this pull request.
I have opened an issue on our Issue Tracker for you. See the issue link: https://issues.shopware.com/issues/SW-27043
Please use this issue to track the state of your pull request.

thanks for your contribution @aragon999  👍🎉💙
It was merged on the "next" branch, as we are currently in the release phase of 5.7.17


Add guide topic on debugging

Covering print statements, pdb (Python debugger), anything else we can come up with.

I have created a tmp branch/commit for this  here. This is not yet pushed because I'm waiting for other requests to go in so I can update the index at the same time without having to think about merging.
This covers prints and pdb. I don't have information on other approaches so I have added a section requesting further contribution.


Make submit save everything

Instead of having individual save buttons for each question, have the submit button (or closing the application prematurely) save everything to the database. Perhaps including a timer that auto-saves every 5 minutes may be useful, or perhaps save whenever an input loses focus (the latter may be too many saves, not sure on the performance hit). This will be made easier by implementing global state with Redux (#14).

Handled in #80


Add recipes somtoday and MDaemon

Pre-flight Checklist
Please ensure you've completed all of the following.

[X] I have read the Contributing Guidelines for this project.
[X] I agree to follow the Code of Conduct that this project adheres to.
[X] I updated the version package Updating

Description of Change

Add recipe somtoday and MDaemon's Worldclient
Update icon for recipe voetbal-nl

@all-contributors please add @richardbeumer for code


Use static analysis tools in pipeline

We could use something like SonarQube to automatically scan the code before merging pull requests

Sounds good!


V2 code editor window is blank?

Not sure what I'm doing wrong trying out the V2 branch.   I've followed the instructions and can load the site after running npm run dev.   I can drag/drop STL files and see them render, but I cannot figure out how to load or edit a JSCAD program or any of the examples.   The editor window is blank, both in Chrome and Safari.   The dev console isn't showing any errors on initial load (it was showing 404's for missing OpenSans fonts, but I corrected that).
Also not able to load anything via the "Load a JSCAD project" button.
Am I doing something obviously wrong?

https://github.com/jscad/OpenJSCAD.org/blob/1613c9119e079feb2ff8f2c9c21ca8027314d691/packages/web/src/ui/views/editor2.js#L42
Looks like it's just not implemented fully yet, yes?

The editor window is probably going to vanish, as we expect users to take advantage of projects (with multiple parts) rather then single file designs.
Try putting your design inside a directory. You should be able to “Load a JSCAD project”, and load that directory.
You can also “Enable Auto Reload”, which will detect when a file changes. (Still a little flaky)

Examples... not V2 ready yet as those require a total rewrite.

The editor window is probably going to vanish, as we expect users to take advantage of projects (with multiple parts) rather then single file designs.

Thanks.   FWIW, I think this would be unfortunate.  Having the "playground" with a built in code editor makes the 1.x OpenJSCAD highly approachable and lowers the friction a potential new user would experience in trying out JSCAD for the first time.

@TomSwift the editor window is back, and functional. 👍
the editor works for single file designs only.
if you drag-n-drop a file to the main canvas then the source code will become available in the editor. just open the editor window and click on the window.
examples are also available, and can be opened from the help (?) window. once again, the source code will become available in the editor.

@TomSwift the editor window is back, and functional. 👍
the editor works for single file designs only.
if you drag-n-drop a file to the main canvas then the source code will become available in the editor. just open the editor window and click on the window.
examples are also available, and can be opened from the help (?) window. once again, the source code will become available in the editor.


Resolve for SELinux

[x] I understand that contributing to this repository will require me to agree with the CLA

Description
This PR resolves failure on 'make start' with SELinux:
docker run -l debug
--volume /Data/Projects/any-sync-dockercompose/:/code/
generateconfig-env
python: can't open file '/code/docker-generateconfig/env.py': [Errno 13] Permission denied
make: *** [Makefile:5: generate_env] Fout 2
What type of PR is this? (check all applicable)

[ ] 🍕 Feature
[X] 🐛 Bug Fix
[ ] 📝 Documentation Update
[ ] 🎨 Style
[ ] 🧑💻 Code Refactor
[ ] 🔥 Performance Improvements
[ ] ✅ Test
[ ] 🤖 Build
[ ] 🔁 CI

Added tests?

[ ] 👍 yes
[ ] 🙅 no, because they aren't needed
[X] 🙋 no, because I need help

Added to documentation?

[ ] 📜 README.md
[ ] 📓 tech-docs
[X] 🙅 no documentation needed

I have read the CLA Document and I hereby sign the CLA

I made the necessary edits here


Custom span rendering？

Is it not supported?
like this

If not supported? Can you provide a way to modify the source code?

In v3.1.0 you can use badge prop in each node.