feat: accessibility fixes

Branch includes:

accessibility polish for the governance, grants, about and ecosystem pages

Have a few change requests:

For optimal contrast, can we use the color @emilymariahh mentioned for the FF site's focus outlines? (it's a yellow hue)
Buttons don't show that they're focused when tabbing into them (in the screenshot below, I'm tabbed into the button, but its state looks the same as untabbed)

Without altering the design, can we add a bit of padding around areas where the outline touches the element the user is tabbed into? We should have at least a few pixels, or 0.125rem clearance (particularly for larger elements and bigger font sizes, where it's more noticeable)

Cards are the biggest culprits
In-line links look fine
Magellan nav sidebar links are too close on the left side

@splumms cc @nicole-code

Have a few change requests:

For optimal contrast, can we use the color @emilymariahh mentioned for the FF site's focus outlines? (it's a yellow hue)
Buttons don't show that they're focused when tabbing into them (in the screenshot below, I'm tabbed into the button, but its state looks the same as untabbed)

Without altering the design, can we add a bit of padding around areas where the outline touches the element the user is tabbed into? We should have at least a few pixels, or 0.125rem clearance (particularly for larger elements and bigger font sizes, where it's more noticeable)

Cards are the biggest culprits
In-line links look fine
Magellan nav sidebar links are too close on the left side

@splumms cc @nicole-code

@orvn I will totally implement the new focus outline color but I am waiting for Jac to test against all backgrounds!

Also , I think the problem with the focus outline on buttons is Firefox-specific, I just noticed it myself @orvn cc @splumms

@nicole-code Ah, in that case, can you also re-check this, but cross browser? (only relevant for desktop browsers, so no mobile required)

@orvn for sure! I'm sorry, I assumed this was tested across browsers I definitely shouldn't have assumed that!


Allow for custom number formatting function in barchart

Allows a custom function to be defined when creating bar labels, useful in cases where the underlying "real" value might want to be truncated, converted to human-readable byte quantities, etc.

Can we get this merged in, if it's ready? It seems to be cropping up with ctop problems.

Is there any reason for this to not be merged in already?

Thanks!


teuthology/scrape.py: Remove empty string in _get_service_types

Problem:
the function grep returns a list contianing empty string which results in scrape.py throwing the warning "Misunderstood line: ".
Solution:
filter out empty strings, blank space and None
before getting match with regex.
Fixes: https://tracker.ceph.com/issues/62534

https://pulpito.ceph.com/ksirivad-2023-09-08_18:32:34-rados-main-distro-default-smithi/
Tried testing with the new change by checking out wip-ksirivad-fix-62534  in teuthology-server and then ran the command:
./virtualenv/bin/teuthology-suite -v --ceph-repo https://github.com/ceph/ceph-ci.git --suite-repo https://github.com/ceph/ceph-ci.git --ceph main --rerun yuriw-2023-08-17_21:18:20-rados-wip-yuri11-testing-2023-08-17-0823-distro-default-smithi -m smithi -e<EMAIL_ADDRESS>-k distro --filter-all "valgrind" -p 80
However, it doesn't seem like the problem goes away.

Think maybe I need to push to upstream, instead of my origin (forked) and put --teuthology-branch wip-ksirivad-fix-62534.
So I did just that, waiting to see the result http://pulpito.front.sepia.ceph.com/ksirivad-2023-09-27_14:03:08-rados-main-distro-default-smithi/

Does anyone plan to work on this PR?


refac; Incoming messages module

Description
References

Codecov Report
Attention: 553 lines in your changes are missing coverage. Please review.

Comparison is base (21978a1) 83.07% compared to head (a9a7d4a) 42.06%.
Report is 277 commits behind head on main.

Files
Patch %
Lines

source/B2CWebApi/Startup.cs
0.00%
65 Missing :warning:

source/Api/Program.cs
0.00%
41 Missing :warning:

...ctories/RequestAggregatedMeasureDataHttpFactory.cs
52.17%
30 Missing and 3 partials :warning:

...uration/Middleware/UnHandledExceptionMiddleware.cs
0.00%
29 Missing :warning:

...essages/RequestAggregatedMeasureMessageReceiver.cs
0.00%
28 Missing :warning:

source/B2CWebApi/Security/FrontendUserProvider.cs
0.00%
28 Missing :warning:

source/Api/EventListeners/InboxEventListener.cs
0.00%
24 Missing :warning:

...trollers/RequestAggregatedMeasureDataController.cs
0.00%
24 Missing :warning:

source/B2CWebApi/Factories/TokenBuilder.cs
0.00%
19 Missing :warning:

...ages/B2CRequestAggregatedMeasureMessageReceiver.cs
0.00%
17 Missing :warning:

... and 49 more

Additional details and impacted files
@@             Coverage Diff             @@
##             main     #618       +/-   ##
===========================================
- Coverage   83.07%   42.06%   -41.02%
===========================================
  Files         456      368       -88
  Lines       10418     7065     -3353
===========================================
- Hits         8655     2972     -5683
- Misses       1438     4000     +2562
+ Partials      325       93      -232

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


merge kubernetes-docs-ja/website

I have been trying translate documents into Japanese.
So, I want to merge this.

This PR includes many commits of kubernetes/website because kubernetes-docs-ja/website is its fork repository.
However, the commits may not be needed in this repository.
I should remove the commits?

I will recreate PR which is more simple.


Updated file read/write operation

Read the access token from array @line 45
mistake - folder was created and reading from file. @line 71

@googlebot I signed it!


Will you release the script for processing the movies?

The part described in Supplementary Material A. 3D Movies Dataset.

https://github.com/intel-isl/MiDaS/issues/13

#13

cool thanks!


Fix #110 - Add **kwargs passthrough on CUD mutations, enables "description" annotation from Strawberry.

You may now use the "description" kwarg in any of the CUD mutations to utilize Strawberry's annotations.
Example:
@strawberry.type
class Mutation:
    createTag: Tag = mutations.create(TagInput, description="Create a tag with title and description.")

Note:  Using **kwargs here may have unintended consequences, but all the tests passed.

LGTM! Thanks for the contribution :)


The set-env command is disabled starting from Nov 17 2020

Error: The set-env command is disabled. Please upgrade to using Environment Files or opt into unsecure command execution by setting the ACTIONS_ALLOW_UNSECURE_COMMANDS environment variable to true. For more information see: https://github.blog/changelog/2020-10-01-github-actions-deprecating-set-env-and-add-path-commands/

All fixed in v1.0.2. Thanks for using my little action!


[fix] form preview csrf error

Coverage increased (+0.0008%) to 82.869% when pulling 17657a8dff9434c074014f28f35f6860ec72e5a0 on itowtips:form-preview into 034031cc612ae50da114e9060219da54352aa735 on shirasagi:master.


Branch/commit ref mixup in PRs with weird side effects

Gitea version (or commit ref): 1.11-rc2
Git version: 2.20.1
Operating system: Debian 10
Database (use [x]):

[ ] PostgreSQL
[x] MySQL
[ ] MSSQL
[ ] SQLite

Can you reproduce the bug at https://try.gitea.io:

[ ] Yes (provide example URL)
[X] No (hard to reproduce)
[ ] Not relevant

Log gist:

Description
I merged this PR by rebasing :
https://codeberg.org/Freeyourgadget/Gadgetbridge/pulls/1785
(there was a duplicate message, that two people closed the PR, but that's probably unrelated)
Then there was
https://codeberg.org/Freeyourgadget/Gadgetbridge/pulls/1788
which was all of a sudden pointing to the commit from 1785 mentioned above.
You can still see the effect now when following the link to 1788, it points to the same commit "merged in ...." like 1785 which is wrong (but the branch mentioned at the top is correct). It also says that the guy who opened 1785 closed 1788 which is - wrong. Both PRs where by different people and completely unrelated. Scary....
Any idea?

When delete a branch it will try to close the pull request. It should check if the pull request has been merged or closed.

@lunny
Branches have been deleted after merging the PRs. Deletion of branches did not trigger this.
The messed PR seem to have pointed to the wrong commit ref out of nowhere.
@TaaviE
What was the fist effect you saw when you realized your PR was broken? Did you delete your branch before that?

I didn't delete my branch, just pushed a commit to replace the existing one in the PR.

@TaaviE
So you force pushed to the branch with the PR, and then it got mixed up with the other PR?
@lunny
@lafriks
Cound that be a problem? Force pushing to a PR branch?

yup force pushing to a PR branch making it align with the base branch would cause gitea to think it has been merged. (Yeah that sounds odd but if you want to allow merging of PRs by hand that's how you do it - well not quite - but that's how unkwon did it...)

Wouldn't it make sense not to claim the PR has been merged? Rather claim
it's closed and by being equal to master, a system message. Currently it
rather confusingly just sent e-mails of people doing things they haven't. I
personally would get a heart attack, thinking my account got somehow
compromised.

Yes. It would. I have an idea for how to do this properly but I haven't had a chance to do it.

@zeripath
But not only that the PR got set to merged - it is completely messed up/mixed up with another PR.
Also mpst PRs that I regularly rebase+merged via the GUI got a double close from two different users (one even from an organzation), that's completely scary.

If you click commit, with an existing PR, the PR indicates that the branch was deleted. (This pull request cannot be reopened because the branch was deleted.) Although the branch currently exists.


Allow InteractivePane.

This is useful when we want to be interactive with the command that sends to the runner, by settting g:VimuxInteractivePane = 1, it will switch to the runner pane and wait until the command is finished then return back to vim.

@xing89qs Could you describe exactly what the desired behaviour would be?


beans name conflicts during Application startup

Hi,
Another issue I met when start the application from IDE:
2015-12-17 16:16:35,310 [main] run:338 ERROR o.s.b.SpringApplication - [owner:spring] [type:springLog] [id:] [name:] Application startup failed
org.springframework.context.annotation.ConflictingBeanDefinitionException: Annotation-specified bean name 'testConfig' for bean class [com.sequenceiq.cloudbreak.service.messages.TestConfig] conflicts with existing, non-compatible bean definition of same name and class [com.sequenceiq.cloudbreak.conf.TestConfig]
	at org.springframework.context.annotation.ClassPathBeanDefinitionScanner.checkCandidate(ClassPathBeanDefinitionScanner.java:314) ~[spring-context-4.0.7.RELEASE.jar:4.0.7.RELEASE]
	at org.springframework.context.annotation.ClassPathBeanDefinitionScanner.doScan(ClassPathBeanDefinitionScanner.java:253) ~[spring-context-4.0.7.RELEASE.jar:4.0.7.RELEASE]

Could you take a look?

Sorry for the late answer. Is this issue still alive?


Special UI for OWML

Disable uninstall button and mark OWML with another color or something.

Relates to #29

Also disable disabling ;)

Closed by #40


root#l:pattern

It seems like root#l:pattern should be root#pattern. The change happened here:
https://github.com/dylanaraps/root.vim/commit/d8114b71deb6242a1b43b80f17040f86f53716c1#diff-ba351d02bc84c5cf657a458f47054adeR48

Fixed in #1


Some documentation rewriting/formatting

This chart is great but the documentation suffered from some typos and clumsy English.  I think it was an ESL contributor, and they certainly write better English than I can write their language, so I hope nobody will feel like this is a criticism of a fantastic chart!

/assign
/ok-to-test

Marking as stale.

Closing as stale. Feel free to reopen if/when you decide to work on this again.


ry2382/86

Width-to-height ratios for each room are controlled by the gene pool component in GH. The ability to take adjacency from json file from issue #85 is also implemented.

Nice, Ruisheng, I like how you implemented controlling the aspect ration with a gene pool input.


don't automatically add dependencies to package and publish

To my surprise including this plugin makes publishFooChart a dependency of publish which will by default try to publish my chart to https://kubernetes-charts.storage.googleapis.com/.
This shouldn't happen by default, or at least there should be a flag to not do it.  It's tricky to remove a dynamically generated task, you have to do something like this in your build.gradle:
afterEvaluate {
    tasks["publish"].dependsOn.remove(tasks["publishFooChart"])
}

I agree. It's a bit too opinionated.

In later versions of gradle (6+ I believe) you need to use a line like this to disable it:
tasks["publishFooChart"].enabled = false


improvement reduce memory consumption of scanner

limit scanner by memory consumptin rather than blocks.
scheduler run correcty instread of at lest 1.


Ignore FocusGained events for the current second

Fix #2062: restore g:airline_focuslost_inactive behaviour.
Instead of ignoring the next x FocusGained events whenever we do call
system(), ignore them for the current second. That allows us to put a
hard limit on the duration of the ignore.
This seems like a much better solution than the previous one because it
also prevents ignore events from building up (s:focusgained_ignored was
often greater than 5).
Test (gvim 8.2.140 on Win10)
gvim.exe ~/.vim/bundle/airline/autoload/airline/extensions/branch.vim
:Gedit HEAD
check several parents and no regression of looping behaviour from #2053.
:let g:airline_focuslost_inactive = 1
:split
alt-tab several times and statusline is correctly dimmed and restored
each time.

I still think that using a timeout of a second is an extremely arbitrary solution, but with the has('win32') it now doesn't impact users on a Mac anymore so it doesn't break my setup anymore.

The one second time out is the minimum timeout I can figure out without doing string parsing (time is measured in seconds) and the simplest way I see to ensure we release the ignore after the FocusGained event occurs.
It's possible we could do a CursorHold, but the behaviour of that will depend on the user's 'updatetime' and means defining and clearing that autocmd. Or maybe we could use timers but I'm not familiar with them.

okay thanks. Let me include it. Hopefully, this resolves all issues.


New method "setTestUrl" to allow us to set the testUrl from jest config on a per-test basis

🚀 Feature Proposal

https://jestjs.io/docs/en/configuration#testurl-string allows you to set the URL for the JSDOM environment at the jest.config.js / package.json level, but there is no way to set this attribute on a per-test basis. A setTestUrl method on the jest object would allow you to set the URL on the fly in tests (similar to setTimeout https://jestjs.io/docs/en/jest-object#jestsettimeouttimeout).
Motivation

We use jest, @testing-library/react, and Mock Service Worker to do App-level integration testing (~if I ever get around to writing a blog post about it I'll link it here~ https://hmh.engineering/want-to-increase-your-quality-and-reduce-your-deployment-times-meet-app-level-integration-testing-308a38cbb321 - it's been great in helping us slim down our expensive Selenium end to end suites) and that involves mocking data endpoints for a particular scenario, rendering an app, and performing semantic queries to emulate end user testing. The app might have a Router inside it with several different routes, so what we currently do is set the global test URL on a per-test basis before rendering the app:
describe('Testing my app on myRoute1: ', () => {
  beforeAll(() => {
    window.history.replaceState('', '', '/myRoute1');
    render(<App />);
  });

Another test for a different route might look like:
describe('Testing my app on myRoute1 with some pre-supplied query parameters: ', () => {
  beforeAll(() => {
    window.history.replaceState('', '', '/myRoute1?sort=apples');
    render(<App />);
  });

We should be able to utilise the out-of-the-box jest feature for testUrl rather than messing with the window object in these tests.
Example

Those examples above would become something like:
describe('Testing my app on myRoute1 with some pre-supplied query parameters: ', () => {
  beforeAll(() => {
    jest.setTestUrl('/myRoute1?sort=apples');
    render(<App />);
  });

Pitch
Why does this feature belong in the Jest core platform?
Common feature proposals that do not typically make it to core:

New matchers (see jest-extended)
Changes to the default reporter (use custom reporters instead)
Changes to node/jsdom test environments (use custom environments instead)

Yes this would be much cleaner. There's so much outdated jest/jsdom docs out there, its needs to be integrated as first class imo.


Wrong link pointed for Configuring Pickup Dispatch application in the Primary IS

Is your suggestion related to a missing or misleading document? Please describe.
In doc[1] under "Configuring Primary IS(Service Provider) in the Secondary IS" the third step mentioned as below.
Follow the steps in Configuring Pickup Dispatch application in the Primary IS and configure the service provider with the details given below.
Here the hyperlink redirect to a non exsting page
[1] https://is.docs.wso2.com/en/5.11.0/learn/handling-saml-single-logout-requests-from-federated-identity-providers/

Resolved with https://github.com/wso2/docs-is/pull/2224


🍒[cxx-interop] Do not try linking with swiftstd

This fixes an ld warning:
ld: warning: Could not find or use auto-linked library ‘swiftstd’

swiftstd was renamed to swiftCxxStdlib. We were still trying to link with swiftstd for some time to allow building with hosttools and to keep the CI green, however a new toolchain was released since the module was renamed, so this is no longer needed.
rdar://107412807
(cherry picked from commit 00b327f1edae2ff282755533cbd5d2dffd10dd41)

@swift-ci please test


Make own video be clear!

Thanks for your nice work and code! I want to know how to make own video be clear. It seems the test code just for the metric calculation.

Hi,
I will try to make a demo code where you can work on your own video shortly. :) Thanks for your advice!
Regards,
Kai

Hi,
I will try to make a demo code where you can work on your own video. :) Thanks for your advice!
Regards, Kai

That's so nice! Thanks a lot for that, hoping get the demo code soon.


Add support for Browserslist

Description
This PR add support for Browserslist configs.
Syntax highlighting based on https://github.com/browserslist/browserslist-vscode.
cc @ai
Checklist:

[x] I am adding a new language.

[x] The extension of the new language is used in hundreds of repositories on GitHub.com

.browserslistrc: ~360,347 results
browserslist: ~826,669 results

[x] I have included a real-world usage sample for all extensions added in this PR:

Source: browserslist/browserslist-vscode
License: MIT

[x] I have included a syntax highlighting grammar:

Preview
MIT-licensed

[ ] I have updated the heuristics to distinguish my language from others using the same extension.

Adding Browserslist config highlighting is important because it is default way to specify target browsers in Autoprefixer and Babel and it is already used in 350K public repositories.

Usage checks out (I happen to be familiar with the format, so I'm skipping the usual sample harvest routine). Just a small nit to correct and we should be good to go. 👍

@voskresla You might want to set core.ignorecase globally so it's configured for all future projects:
$ git config --global core.ignorecase false

Or add to your ~/.gitconfig file:
[core]
	ignorecase = false

The --local switch sets a config setting for one particular repository directory only (stored in .git/config). So it won't persist across other projects, including future checkouts of Linguist.

)

LGTM. 👍
@lildude, I say we :shipit:.

@ai mentioned browserslist config name is deprecated, it makes sense to drop it from samples? We should keep support for existing configs, so it's only about example file.

@wspwebben We don't judge formats on their deprecation– or recommendation-status, only their real-world distribution. Discouraging the use of a filename won't change the fact there are over a million files on GitHub using that particular format and filename.

@wspwebben We don't judge formats on their deprecation– or recommendation-status, only their real-world distribution. Discouraging the use of a filename won't change the fact there are over a million files on GitHub using that particular format and filename.

That's why we should keep support for that format in config files, so syntax highlight would still work for these files, but there's no need to keep that format as an example in samples

but there's no need to keep that format as an example in samples

There is. The samples directory isn't for human consumption—it's to train our Bayesian classifier, which disambiguates files based on the frequency of certain tokens. The more samples Linguist has, the more accurate its predictions are.

Got it, thank you for clarification :D

No problem! 😉 That's also the reason we prefer "real-world" samples instead of just "Hello, world" examples, BTW:—they need to be an accurate rendition of the sort of files Linguist will encounter in-the-wild after it starts indexing the new language.


StarRocks operator on Red Hat OpenShift as SCC (security context constraints) error.  k8s pod security standard

Issue is that the container is running as root.
Default OpenShift policy is restricted which denies access to all host features and requires pods to be run with UID, and SeLinux context that are allocated to the namespace. This is the most restrictive SCC and it is used by default for authenticated users.

create Pod starrockscluster-sample-fe-0 in StatefulSet starrockscluster-sample-fe failed error: pods "starrockscluster-sample-fe-0" is forbidden: unable to validate against any security context constraint: [provider "anyuid": Forbidden: not usable by user or serviceaccount, provider restricted: .spec.securityContext.fsGroup: Invalid value: []int64{1000}: 1000 is not an allowed group, provider "nonroot": Forbidden: not usable by user or serviceaccount, provider "hostmount-anyuid": Forbidden: not usable by user or serviceaccount, provider "machine-api-termination-handler": Forbidden: not usable by user or serviceaccount, provider "hostnetwork": Forbidden: not usable by user or serviceaccount, provider "hostaccess": Forbidden: not usable by user or serviceaccount, provider "node-exporter": Forbidden: not usable by user or serviceaccount, provider "privileged": Forbidden: not usable by user or serviceaccount]

SCC aligns with https://kubernetes.io/docs/concepts/security/pod-security-standards/ and https://access.redhat.com/articles/6973044

Another error
User "system:serviceaccount:starrocks:starrocks-sa" cannot get resource "leases" in API group "coordination.k8s.io" in the namespace "starrocks"


For undersized literals with value one: also suggest decimal.

e.g. 32'h1 now provides two suggestions

32'd1
32'h00000001

Signed-off-by: Henner Zeller<EMAIL_ADDRESS>

Question is: should this be extended to not only 1 but anything that is single-digit and also is a decimal decimal ? So for instance 32'o1 … 32'o7 and 32'h1 … 32'h9


Templates are not working

There is no cssloader so there is not loading any templates for frontend.?

I can also verify this issue, after spending an hour looking into this I did notice the .htaccess file in the root directory doesn't get downloaded if I click on the "Download ZIP" button under the "Clone or Download" tab, I manually downloaded it and put it into my directory, made sure mod_rewrite was enabled but that didn't seem to make any difference either. I have verified "mod_rewrite" is displayed under the "Loaded Modules" table on the phpinfo.php file I created to check to make sure it was indeed enabled, sorry I can't be of more help @nikhilkhot46, hopefully the main developer will be able to step in and help us, :+1:

I'm also having the same issue as @nikhilkhot46

@nikhilkhot46 @Have-a-Laugh Check your .htaccess file is there. "cssloader" is router. Or check your permissions if you use Linux

All templates work.

Please check above image and help  me


Support requestLocationUpdates

Support requestLocationUpdates method from LocationManager on both libraries.

Thanks for the library. Can you please tell if requestLocationUpdates support is there in the latest code. We are planning to use it.


Update commands.rb

Status page is nowadays https - plus it fixes the error when you try hcl status.

thank you for the patch! sorry for the long wait


Don't move pcaps from the router to moloch over the public interface

There seems to be a bandwidth limit (1Gbps) on the public interfaces, whereas I was able to achieve ~3Gbps with the internal networks of Hetzner Cloud before. During ENOWARS4 we had problems with the pcap copying taking up bandwidth which was required by the game router to function normally.

If we are certain moloch does not impair the routing, we could move a moloch node to every router

Another idea: would it help to reduce the interval time of tcpdump? Would this help to reduce peak bandwith?

in case we just want to keep things as they are, the ip can now be set in the config_bambi.yml
https://github.com/enowars/bambictf/commit/e026f2dc55f5179ddf40924bc81ac6855f6fb069

Another idea: would it help to reduce the interval time of tcpdump? Would this help to reduce peak bandwith?

At some point the router was forwarding ~500Mbit/s of traffic while copying pcaps to Moloch with the remaining ~500Mbit/s, so this would help with peaks in the beginning but not in the long run I guess.

@Trolldemorted this issue can be considered done, since the Arkime now lives on the Router anyways, right?


Date picker should be opened always

I need a date picker without having the input type or icon. it should always open. Please help me on this

Given that the position of the calendar in datepicker is absolute, it doesn't seem to work for your case, since the calendar covers other below elements.
In your case , it would be better to use an input along with calendar instead of datepicker.
Please take a look at this example and let me know if it works or not.

@shahabyazdi  Thanks a lot Man :-)

you're welcome 🙂


Is there a way to change 'timeGridWeek' to show more days then a week? Example 10-15?

Firstly, I would like to express my appreciation for your excellent library. It's been a great resource and I'm grateful for the opportunity to utilize it.
I am writing to understand the 'timeGridWeek' that displays a span of 7 days, which is indeed useful. However, for my specific use case, it would be beneficial to have an extended view that encompasses two weeks at a time for example.
If it's not feasible to directly modify the week view, perhaps there could be an alternative solution. For instance, is there a way to customize a different view and import it into the views section? This flexibility would greatly enhance the functionality of the calendar for users who need a broader overview of their schedule.
Thank you for considering this request in advance!

Hi @cmjoseph07
Is duration what you are looking for?

@vkurko
Yes! This is exactly what I was looking for. Sorry to trouble you on this and I again appreciate it!!


Creating a final snapshot is skipped by default

Description
Hi guys. After upgrading the terraform-aws-rds-aurora module version from 6 to 8 I discovered quite significant issue that might cause that people will be accidentally deleting their databases without any option to restore them. A similar scenario happened to us some time ago, due to an AWS API bug in ap-south-1 region. The bug forced cluster recreation, distracted developer didn't read the terraform plan, and we didn't have the deletion protection enabled. Luckily the terraform-aws-rds-aurora module ver 6/7 was configured to take the final snapshot, so we were able to restore the database.
The problem:
Combination of default values for: skip_final_snapshot, snapshot_identifier and deletion_protection parameters causes that the final snapshots won't be taken by default. Even if the skip_final_snapshot = false the snapshot_identifier = null by default. The TF AWS RDS provider says:

snapshot_identifier - Name of your final DB snapshot when this DB cluster is deleted. If omitted, no final snapshot will be made.

Unlike in ver 6/7, terraform-aws-rds-aurora ver 8 man needs to explicitly set the value for snapshot_identifier, otherwise the snapshot won't be taken. This might lead to a situation where someone might be under impression that the snapshots will be created automatically, because skip_final_snapshot = false.
This inconsistency/issue comes from the TF AWS RDS provider, but I think it would be wise, if the terraform-aws-modules team would be smarter than Hashicorp, and set some default value for the snapshot_identifier, as it was done in ver 6/7.
I'm aware of the snapshot_identifier and global_cluster_identifier issue, but why not providing a default value for the snapshot if the global_cluster_identifier = null? I assume there are fairly less cases of global clusters than people not reading all of the module configuration parameters.
Versions

Module version [Required]:
8.3.1

Terraform version:
1.5.1

Provider version(s):
provider registry.terraform.io/datadog/datadog v3.30.0
provider registry.terraform.io/hashicorp/archive v2.4.0
provider registry.terraform.io/hashicorp/aws v5.17.0
provider registry.terraform.io/hashicorp/local v2.4.0
provider registry.terraform.io/hashicorp/null v3.2.1
provider registry.terraform.io/hashicorp/random v3.5.1
provider registry.terraform.io/mrolla/circleci v0.6.1

Reproduction Code [Required]
Steps to reproduce the behavior:

Add bare minimum TF configuration that uses terraform-aws-rds-aurora module. Provide only the basic details you need (e.g. name, engine, version).
Leave the default values for skip_final_snapshot, snapshot_identifier and deletion_protection
Destroy your database.

Expected behavior
I expect, that due to the skip_final_snapshot = false the final snapshot will be taken.
Actual behavior
The snapshot is not taken because I wasn't aware that I need to provide a value for another parameter snapshot_identifier to take the final snapshot. I lost my database along with the backups.

Hey @antonbabenko
Do you mind removing the "stale" label from the issue? I can't control the labels unfortunately.


Add cli option to enable deep mode

Description

[ ] Non-deep mode immediately becomes the default behavior
[ ] Add a command-line switch to enable the experimental deep mode.
[ ] Add documentation about the supported resources for this experimental deep mode (all currently supported resources)

Example
$ driftctl scan
[...quickly lists resources]
$ driftctl scan --deep
[0.12 behavior]

LGTM


[Event Modification] Codeunit 22 "Item Jnl.-Post Line" – Signature modification for event “OnInsertOHValueEntryOnBeforeInsertValueEntry”

Hi
Is it possible for us to get the publisher “OnInsertOHValueEntryOnBeforeInsertValueEntry” in Function “InsertOHValueEntry” in Codeunit 22 "Item Jnl.-Post Line” changed to the below signature?:
IsHandled := false;
// >> Modification
OnInsertOHValueEntryOnBeforeInsertValueEntry(ValueEntry, ItemJnlLine, GlobalItemLedgEntry, ValueEntryNo, IsHandled);
// << Modification
if not IsHandled then

[IntegrationEvent(true, false)]
// >> Modification
local procedure OnInsertOHValueEntryOnBeforeInsertValueEntry(var ValueEntry: Record "Value Entry"; ItemJnlLine: Record "Item Journal Line"; var GlobalItemLedgEntry: Record "Item Ledger Entry"; var ValueEntryNo: Integer; var IsHandled: Boolean)
// << Modification
begin
end;

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.


plugin.rb code changes

I "cleaned" the code a little bit and changed some of the grammar and spelling of the text in this.

one more thing i changed my github username so could you change that too please


What happens when certificateIssuerThumbprint is empty?

What happens when certificateIssuerThumbprint is empty? It's empty in the example.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: d34f6d36-58e7-ab10-e659-bdd10a64deca
Version Independent ID: 25d94e4b-8c95-7423-2665-7c09d438a16b
Content: Update an Azure Service Fabric cluster to use certificate common name
Content Source: articles/service-fabric/service-fabric-cluster-change-cert-thumbprint-to-cn.md
Service: service-fabric
GitHub Login: @rwike77
Microsoft Alias: ryanwi

More importantly, why are empty certificateIssuerThumbprint values are allowed? Shouldn't it always be specified to prevent an attacker from using a certificate with the same common name but obtained from another issuer?

@aljo-microsoft could you comment on this one?

@olegsych
If your cluster certificate declared by common name, is issued by a trusted root (that is, on windows, the root certificate exists/is installed in the Trusted Root CA store) then we can validate your certificate without issuerthumbprint; by using its issuer properties Trust Root CA (though we still recommend explicitly declaring thumbprint to mitigate issues of certs that are not issued by Root CA).
Examples of Root CA are Global Sign Root, Baltimore CyberTrust Root etc; which excludes automatically self-signed certs.
When the CA whom issued your certificate that is not a Root CA, you must provide the issuer thumbprint for it to be validated.
Given we are NOT a CA that issues any certificates; x509 Common Name Property is affectively like a user name, and x509 Certificate property issuer thumbprint is affectively like a password. They are authorized by the user declaring them, and authenticate to be a non expired certificate with user declared properties.

Thanks for the explination @aljo-microsoft!
@olegsych @smflorentino let us know if that helps. Also, since I see you are both FTEs you can feel free to ping us offline if you have follow up questions.


Help with Nox

I have been looking at Nox to try and figure out why it is not working with dxwrapper when using dd7to9.  However, it seems to work with cnc-ddraw.
I am able to see the intro video.  However, once the video ends all I see are calls to GetFlipStatus() and Flip().  I am not seeing any changes to either the front buffer or the back buffer.
Any idea how Nox writes data to the screen after the intro video?

I think it was using EnumAttachedSurfaces (looking for DDSCAPS_BACKBUFFER) to get the backbuffer rather than the usual GetAttachedSurface. Other than that I don't think I had any problems with it.
I'll test run it again, been long time since last tried

Yeah, I saw that and checked that it is able to get the correct surface from EnumAttachedSurfaces().  I think that part is working.  I am just wondering how it writes the data to the screen since I am not seeing any calls to Lock(), Blt(), BltFast(), BltBatch(), GetDC() or even GetSurfaceDesc() after the intro video completes.  So I am not sure how it is writing the data to the screen.

Doesn't flip at all for me
[1848] 22:52:16.519 -> IDirectDrawSurface__Lock(This=00E8CA40, lpDestRect=00000000, lpDDSurfaceDesc=0019F978, dwFlags=00000001, hEvent=00000000) [1848] 22:52:16.519      DDLOCK_WAIT [1848] 22:52:16.519 <- IDirectDrawSurface__Lock [1848] 22:52:16.519 -> IDirectDrawSurface__Unlock(This=00E8CA40, lpRect=052E0000) [1848] 22:52:16.519 <- IDirectDrawSurface__Unlock [1848] 22:52:16.519 -> IDirectDrawSurface__IsLost(This=00E8D128) [1848] 22:52:16.519 <- IDirectDrawSurface__IsLost [1848] 22:52:16.519 -> IDirectDrawSurface__Blt(This=00E8D128, lpDestRect=0019F9C8, lpDDSrcSurface=00E8CA40, lpSrcRect=0019F9D8, dwFlags=01000000, lpDDBltFx=00000000) [1848] 22:52:16.519      DDBLT_WAIT [1848] 22:52:16.519 <- IDirectDrawSurface__Blt
I guess you probably return different values in IDirectDraw__GetCaps and the changes its behavior

Are you sure those Blts and Locks are happening after the intro video?  I am seeing all those also during the intro video.  However, after the video I don't see any of those.

I guess you probably return different values in IDirectDraw__GetCaps and the game changes its behavior

I tried returning the same Caps that cnc-ddraw returns and I am getting the same result.  I also tried with DDrawCompat and logged all calls and I am not seeing the those Blts and Locks after the intro video.  I just see them during the intro video.

Yes,
intro:
[4792] 23:03:54.122 -> IDirectDrawSurface__Unlock(This=00E8BD10, lpRect=00000000)
[4792] 23:03:54.122 <- IDirectDrawSurface__Unlock
[4792] 23:03:54.122 -> IDirectDrawSurface__Lock(This=00E8BD10, lpDestRect=00000000, lpDDSurfaceDesc=075A9838, dwFlags=00000001, hEvent=00000000)
[4792] 23:03:54.122      DDLOCK_WAIT
[4792] 23:03:54.122 <- IDirectDrawSurface__Lock
After intro:
[4792] 23:03:57.670 -> IDirectDrawSurface__Lock(This=00E8B270, lpDestRect=00000000, lpDDSurfaceDesc=0019F978, dwFlags=00000001, hEvent=00000000)
[4792] 23:03:57.670      DDLOCK_WAIT
[4792] 23:03:57.670 <- IDirectDrawSurface__Lock
[4792] 23:03:57.670 -> IDirectDrawSurface__Unlock(This=00E8B270, lpRect=06510000)
[4792] 23:03:57.670 <- IDirectDrawSurface__Unlock
[4792] 23:03:57.670 -> IDirectDrawSurface__IsLost(This=00E8BD10)
[4792] 23:03:57.670 <- IDirectDrawSurface__IsLost
[4792] 23:03:57.670 -> IDirectDrawSurface__Blt(This=00E8BD10, lpDestRect=0019F9C8, lpDDSrcSurface=00E8B270, lpSrcRect=0019F9D8, dwFlags=01000000, lpDDBltFx=00000000)
[4792] 23:03:57.670      DDBLT_WAIT
[4792] 23:03:57.671 <- IDirectDrawSurface__Blt
It starts to Blt after the intro

Maybe the problem is lock/GetSurfaceDesc, I return hardcoded flags there:
https://github.com/FunkyFr3sh/cnc-ddraw/blob/master/src/ddsurface.c#L675

BTW: I believe you have a bug in your EnumAttachedSurfaces() code here.  As far as I can tell DirectDraw does not increase the reference count.  Furthermore, if you increase the ref count there the game will not release the enum'ed surface before exiting.
I also checked the documentation and could not find any details about it increasing the ref count.
Here are comments I found:

No, the EnumAttachedSurfaces() function in DirectDraw does not increase the reference count of the surfaces it enumerates.
The purpose of the EnumAttachedSurfaces() function is to retrieve the attached surfaces of a primary or a complex surface. It allows you to iterate through the surfaces that are attached to the specified surface and obtain information about them, such as their capabilities and pixel formats.
The function takes a callback function as a parameter, which is called for each attached surface. The callback function receives a pointer to the enumerated surface as a parameter. It's up to the application to handle the surface appropriately, including managing its reference count.
If you need to increase the reference count of a surface obtained through EnumAttachedSurfaces(), you would typically do so explicitly in your application code using the appropriate DirectDraw function, such as AddRef().

Ah, yeah that's a bug. Nox is smart enough to release it anyways, but carmageddon isn't... will fix it now, thanks!

It appears that the native DirectDraw does the same thing as dxwrapper.
With cnc-ddraw if I turn Blt() into a stub (just returning DD_OK on the first line) then nothing can be seen after the intro video.
With DDrawCompat if I turn Blt() into a stub then the game runs fine and shows everything after the intro.
So it appears that the game works differently based on what it is getting.  I wonder if something (other API's) outside of the DirectDraw APIs affects this game.

Tried to play around with it a bit but didn't manage to break it. No idea what's going on with it

If I remove the DDSCAPS_FLIP flag from both the primary and backbuffer surfaces then the game works with dxwrapper the same as it does with cnc-ddraw.
It seems like the reason this game is working with cnc-ddraw is because the game thinks that cnc-ddraw does not support flipping and thus is blitting from backbuffer to the primary surface rather than flipping.  I am not yet sure what cnc-ddraw is doing that is causing the game to think that flipping is not supported.

maybe this here?
https://github.com/elishacloud/dxwrapper/blob/c9478d6baccf3d3861a5df790cc63dd1e1727413/ddraw/IDirectDrawX.cpp#L598
cnc ddraw never sets DDSCAPS_FRONTBUFFER

If I add the following lines into the dds_GetSurfaceDesc function of cnc-ddraw then the flip starts working for this game.  It seems like somehow the flip flag is getting lost in cnc-ddraw:
if ((This->caps & (DDSCAPS_PRIMARYSURFACE | DDSCAPS_BACKBUFFER)))
{
    lpDDSurfaceDesc->ddsCaps.dwCaps |= DDSCAPS_FLIP;
}

But it does not help me because even when using Flip() the game works fine with cnc-ddraw, but not with dxwrapper.  But I think this might be a bug with cnc-ddraw that the flip flag is getting lost.

Right, cnc-ddraw doesn't set DDSCAPS_FLIP on the backbuffer currently, so i guess the game is checking it there.
Maybe the game saves the pointers from a previous lock call and keeps writing to it? Did you test this with emulated surfaces? I remember dxwrapper had a setting for that, or am i wrong?

Right, cnc-ddraw doesn't set DDSCAPS_FLIP on the backbuffer currently, so i guess the game is checking it there.

Yes, good catch.  If I add the following code then it fixes both the native DirectDraw and dxwrapper.  I guess I followed the native DirectDraw too well.
if (!(lpDDSurfaceDesc->ddsCaps.dwCaps & DDSCAPS_FRONTBUFFER))
{
	lpDDSurfaceDesc->ddsCaps.dwCaps &= ~DDSCAPS_FLIP;
}

Maybe the game saves the pointers from a previous lock call and keeps writing to it? Did you test this with emulated surfaces?

Yeah, emulated surfaces don't work.  But the fact that dxwrapper is exactly replicating even the issues of the native DirectDraw is a good thing, I guess.  I just wish I knew why it did not work when trying to flip.
I am guessing that the game never triggers dxwrapper to present the new data it has written.  When using emulated surfaces I need something to trigger the data to be written from the emulated surface to the real surface before I can present it.  Currently, I use Unlock(), ReleaseDC(), or one of the Bilt functions for that.  If none of those are called then dxwrapper will never copy the data from the emulated surface to the real surface.

BTW: according to the logs (both cnc-ddraw and DDrawCompat) once it exits the intro video, if it is flipping, then it never calls Lock() or Blt() or anything like that.  It just calls GetFlipStatus() and Flip().  So I assume you are correct in that it just remembers the pointers from a previous call.

Ah, nice... Flip() does trigger the copy in cnc-ddraw. I guess it's all making sense now!

If I enable emulated surfaces in dxwrapper and I force the emulated surface to copy to the real surface on Flip() and I add the pointer to the emulated surface address into the GetSurfaceDesc() function then it works with dxwrapper when using flip also.  Thanks for your help here!

Since I understand what is happening now, I am going to close this issue.

Removing the DDSCAPS_FLIP flag from the backbuffers breaks other games when using both the native DirectDraw and dxwrapper.  It seems like the DDSCAPS_FLIP flag is supposed to be on all the surfaces that are part of the flip chain.  Games look for it in the backbuffer and use it.
So Nox is correctly detecting the missing flag from cnc-ddraw and switching to Blt() rather than Flip() since the missing flag is indicating that the surface is not part of the flip chain.

Yeah it should be on the backbuffers, I'm not going to add it for now though (I'm afraid it's going to break some games).

Removing the DDSCAPS_FLIP flag from the backbuffers breaks other games when using both the native DirectDraw and dxwrapper.

Which games does it break?

It broke Star Trek Armada (a Direct3D7 game).

I put a custom fix into dxwrapper for Nox.  This is the first custom fix in dxwrapper, but I don't like the idea of coping the emulated surface on each Blt() and I don't really want to add another option for this as I think it is unique to this game.
You can see the update here:  e7b7b7e

i've seen a few other games that would lock/unlock and use the pointer afterwards, I don't remember the names now though. But maybe you're right, using the old pointers in combination with Flip() may be unique to this game

i've seen a few other games that would lock/unlock and use the pointer afterwards

Final Liberation: Warhammer Epic 40,000 is one game that uses the pointers after unlocking them.  It crashes on native DirectDraw because of this.  Normally emulation would solve the issue.

As a final followup for this issue, I figured out that the whole issue had to do with the fact that Direct3D9 did not know the textures were dirty since they were updated out of band (not using Lock(), Blt() or GetDC()).  So actually, all I needed to do was add one line of code:
displayTexture->AddDirtyRect(nullptr);

Of course, I only do this when the game tries to present data (for example after a Flip()) and there is no call to either Lock(), Blt() or GetDC().  I am not sure if there is a way to solve this with DirectDraw, other than locking the surface, but that is very expensive.

ah, nice one 👍

@elishacloud Nox is will decrease the ref count for each EnumAttachedSurfaces call, just so you know... Someone just reported a crash, may be worth checking if everything is working as intended with dxwrapper

@FunkyFr3sh, thanks for the heads up.  I can reproduce the crash on game load when using a higher resolution and increasing the ref count does indeed solve it.  However, I noticed that you reverted the code so you no longer increase ref count.  What was the final outcome of this investigation?
BTW: I cannot see anything in the documentation about EnumAttachedSurfaces() increasing the ref count.

Ok, I see what the issue is. NOX has a bug here.  It should not be releasing the surfaces here.  However, native DirectDraw can handle this bug because all the back buffers created in a DDSCAPS_COMPLEX cannot be deleted until the root surface is deleted.  I had code to handle this already.
However, the issue that I had was that I was returning the front buffer when the game tried to query the back buffer (since the front buffer was attached to the back buffer).  All I needed to do was to exclude the front buffer from EnumAttachedSurfaces().

native DirectDraw can handle this bug because all the back buffers created in a DDSCAPS_COMPLEX cannot be deleted until the root surface is deleted.

I have been thinking about this too and it does work in this case, however, i think that's not the reason why it doesn't crash with native ddraw. I also had a similar issue with another game before and native ddraw also didn't crash there, while cnc-ddraw did, but in that case it was about a palette and not a DDSCAPS_COMPLEX surface. I may do some more testing with it later...

Ok, if you find anything out here let me know.  It is always hard to replicate DirectDraw in some of these cases since the documentation is not very thorough.


fix(metal): patch ggml-metal.m with shader code

Alternate fix to #324 (thanks for the inspiration!)
The Rust build script has the ability to create new files, and use them as fodder for the build process. We can use this to create an alternate ggml-metal.m that embeds the Metal shader source code and sidestep the issue of runtime loading entirely.
Let me know if you're OK with this @pixelspark @nightscape !

Also took the liberty of patching the calls to printf so that they wouldn't spam output in normal release mode. Happy to revert that commit if we think it's too much.

Looks great!!

Nice trick, maybe a bit brittle (although I suspect the line you replace is not going to change any time soon).
A cleaner way would be to make a trivial PR to llama.cpp that would make the code accept a GGML_METAL_SHADER_CODE #define and use that when set, or else loads from ggml-metal.m? (Assuming the length of #define contents is not limited. Otherwise we could add a #define that chooses between load-at-runtime or a #include).
I propose to merge this now but also initiate steps for a ‘clean’ version.


Fail to install Ubuntu 16.04 LTS on Joule board

Download image http://people.canonical.com/~platform/snappy/tuchuck/desktop-beta4/tuchuck-xenial-desktop-iso-20170109-0.iso and install it on Joule board. It hung at installing "grub2"...

Error disappear after update BIOS version to 174, so close this bug.


.NET 7.0

@BCSharp Are you able to reproduce the failure on macOS with .NET 7? I think it's occurring in test_re_stdlib but I don't have a macOS system to test with. If it's a bug with .NET 7 would be good to report it before they do their release.

Yes, I was able to reproduce the failure. The test crashes on test_big_codesize with a stack overflow. To be more specific, it crashes on the first match on the compiled expression. However, replacing match with re.search, which uses uncompiled expression, does not trigger the overflow. Also, the overflow only happens when run by the testrunner, not if the test is executed directly by the ipy console program. When I see an effect like this, my first suspect is IronPython code rewriting. Not that it is incorrect, but may simply generate inefficient code. For instance, reducing range(10000) to range(7000) and modifying the match patterns accordingly, is sufficient to make the test passing on my machine. On the other hand, increasing the range to, say, 20000, makes the test crash even on .NET 6.0.
All in all, I don't have a feeling that it is caused by a problem in .NET 7.0, more likely, the implementation in .NET 7.0 changed somehow that it uses more method calls on the stack than before, which, when accumulated, push the process over the edge.
To make the test pass temporarily, you may set IsolationLevel=PROCESS. Unfortunately, the root cause is elusive and will require more time to investigate, which I don't have at the moment.

Thanks for the tip. I was able to reproduce the failure on Windows by bumping the range to 25000 and on .NET 6 (with 50000). I managed to get the same stack overflow running directly in C# so that rules out an IronPython issue:
var sb = new StringBuilder();
sb.Append(0);
for(int i=1; i<25000; i++)
{
    sb.Append('|');
    sb.Append(i);
}

Regex.Match("1000", sb.ToString(), RegexOptions.Compiled);

But as you say we must be right near the limit on macOS and IronPython's stack is pushing it over the edge. I will try IsolationLevel=PROCESS to see if it helps.

Any timeline around when we can expect net7.0 support?

@DamianReeves This PR only enables the test suite. Is there a problem running the existing (.NET 6) DLLs on .NET 7?


Use MSW for the Catalog for mocking network requests

So after chatting in #1205, we decided to give msw a try to mock network requests.
Managed to get something working for one test, and this is what the changelog looks like.
:heavy_check_mark: Checklist

[ ] All tests are passing yarn test
[ ] Screenshots attached (for UI changes)
[ ] Relevant documentation updated
[ ] Prettier run on changed files
[ ] Tests added for new functionality
[ ] Regression tests added for bug fixes

Hey 👋  Thanks for adopting MSW for Backstage!
Let me know if it suits your needs, and if there's something you feel should be better. I'd love to improve the library and use your experience as a valuable feedback to do so.
Also, would it be okay with you if I included Spotify logo on the library's website as an example of an awesome integration? Of course only if you're fine with that, and feel that the library's worth it.
Thanks.


Reduced reporter filesize by 4x

Still unsure why reporter file stores 1 remaining covariance matrix (I deduce this based on size). The python object being saved didn't appear to have any references to any covariance matrices (not even through gradients).

Make sure to at least add a command line argument to save the stats

Make sure to at least add a command line argument to save the stats

Updated


A connection attempt failed

At some point in the last few months it seems like maybe the software stopped working for me. I have an LG C1
If I test with the UI the TV turns off and on ok. Checking the logs I see this:
Mon 04:06:56 > ** System requests displays OFF.
Mon 04:06:56 > Device1, spawning Thread_DisplayOff().
Mon 04:07:17 > Device1, WARNING! Thread_DisplayOff(): connect: A connection attempt failed because the connected party did not properly respond after a period of time, or established connection failed because connected host has failed to respond [system:10060 at D:\a\LGTVCompanion\LGTVCompanion\vcpkg_installed\x64-windows-static\x64-windows-static\include\boost\asio\detail\win_iocp_socket_service.hpp:632:5 in function 'connect']
Mon 04:16:16 > -daemon 1 useridle
Mon 04:16:16 > Device1, spawning Thread_DisplayOff().
Mon 04:16:37 > Device1, WARNING! Thread_DisplayOff(): connect: A connection attempt failed because the connected party did not properly respond after a period of time, or established connection failed because connected host has failed to respond [system:10060 at D:\a\LGTVCompanion\LGTVCompanion\vcpkg_installed\x64-windows-static\x64-windows-static\include\boost\asio\detail\win_iocp_socket_service.hpp:632:5 in function 'connect']
Mon 04:26:16 > -daemon 1 useridle

Hi @Tailslide the log suggests that the app cannot communicate properly with the TV. Usually an error like this indicates that you have the wrong IP configured.  Can you post the full log and config.json please and I will have a look.

I verified the IP address and MAC match.. I notice there is a second mac in the config that corresponds to the wifi network which is no longer connected not sure if that's the issue.
lgtvLog.zip
config.json

Hi @Tailslide as far as I can tell when looking over the most recent parts of the log I can see it working fairly well, so I'm not sure what you mean. Can you describe in more detail what you mean when you say "stopped working for me" please.
On a C1 it is to be expected that the app cannot communicate with the TV when it is off (the always ready feature on C2 and newer is required for that). Hence you will see log entries like the below. At 22.56.43 the system requested the display to turn off (probably due to the power saving settings turn off screen after x min). At 23.05.42 the built in user idle mode detection triggered and another "power off display" message is sent, but since the TV is already off the message will time out and the error message is logged. But it all looks normal.
Sun 22:56:43 > ** System requests displays OFF.
Sun 22:56:43 > Device1, spawning Thread_DisplayOff().
Sun 22:56:43 > Device1, [DEBUG] (SSL) OFF response 1: {"type":"registered","id":"register_0","payload":{"client-key":"eda678071598af672e4db09d15f5084d"}}
Sun 22:56:43 > Device1, [DEBUG] (SSL) OFF response 2: {"type":"response","id":37,"payload":{"returnValue":true,"state":"Active"}}
Sun 22:56:43 > Device1, [DEBUG] (SSL) OFF response 4: {"type":"response","id":38,"payload":{"returnValue":true}}
Sun 22:56:43 > Device1, power state is: OFF.
Sun 23:05:42 > -daemon 1 useridle
Sun 23:05:42 > Device1, spawning Thread_DisplayOff().
Sun 23:06:03 > Device1, WARNING! Thread_DisplayOff(): connect: A connection attempt failed because the connected party did not properly respond after a period of time, or established connection failed because connected host has failed to respond [system:10060 at D:\a\LGTVCompanion\LGTVCompanion\vcpkg_installed\x64-windows-static\x64-windows-static\include\boost\asio\detail\win_iocp_socket_service.hpp:632:5 in function 'connect']

Addiotnally, wrt the second mac-adress. both MACs will be used. I e two wake on lan packets will be sent with the configured WOL method. In your case you have configured to send the packet to the IP-adress, but only one (with the correct MAC) can actually wake the TV. So in your case it should not matter.

Ok.. when I would check in on the PC in the mornings in the past the screen would be off and now the screen is on despite me not using it all night and there being no applications running.  I assumed the 'user idle' setting would make sure it was off.  Thanks for checking the logs I assume it's some background process making it look like the user is not idle.

Hi, ok so your issue is that the TV is on in the mornings even though you've not been using the PC.
Let's break that down a bit. During the night, either the PC is awoken erroneously, or the display is awoken erroneously. The PC can be awoken for a few different reasons which depend on how it is configured. This may include installing updates, or other devices waking it. The TV can typically only be awoken with a specific wake on lan packet.
So let's try to see what we can gather from the log this morning then (see below). Just from looking at the log it looks like the PC was put to sleep just before midnight. It resumed around two hours later (~2am,), at which point the display powered on. Then not much is going on in the log until two hours later(~4pm) when the system requests the display to be powered off. At this point the request fails for unknown reasons, as mentioned previously. Furthermore, the log entries indicate a user was at the PC at this time 2am to 4am (due to the lack of user idle messages).
Maybe the TV had auto-powered off at this time. What have you set the TVs auto power of setting to (not the app, the setting in the TV settings)?
Then after 4 around am there is a bunch of user idle messages, indicating there is no user at the PC, but it is still running. The TV seem to be off as it is not responding to these messages.
At 05:05 the system suspends once again.
At 05.08 the system resumes. The display is powered on.
Then, judging by the info in the log there was a user at the PC from 05:08 to 09:07 since there are no user idle messages. Again a lack of user idle messages indicate that the PC is being used.
At 09:07 you used the test function to power the TV first off and then on.
This tells a story of a PC that keeps waking up for some reason. Since you said the PC wasn't used during the night see what you can gather from my summary of the log.  See if you can disable wake-timers and ensure that the PC cannot be awoken randomly by WOL packets on your network for example.
Sun 23:56:28 > ** System is suspending to a low power state.(or event callback is missing) Mon 01:59:34 > ** System resumed from low power state. Mon 01:59:34 > ** System requests displays ON. Mon 01:59:34 > Device1, spawning Thread_DisplayOn(). Mon 01:59:34 > Device1, repeating WOL broadcast started to MAC: B4B291B850F0 using IP address: <IP_ADDRESS> Mon 01:59:34 > Device1, Best route to IP - interface index 16 LUID<PHONE_NUMBER>741120 route protocol 2 Mon 01:59:34 > Device1, WARNING! Thread_DisplayOn(): connect: A socket operation was attempted to an unreachable host [system:10065 at D:\a\LGTVCompanion\LGTVCompanion\vcpkg_installed\x64-windows-static\x64-windows-static\include\boost\asio\detail\win_iocp_socket_service.hpp:632:5 in function 'connect'] Mon 01:59:34 > ** System resumed from low power state (Automatic). Mon 01:59:35 > Device1, WARNING! Thread_DisplayOn(): connect: A socket operation was attempted to an unreachable host [system:10065 at D:\a\LGTVCompanion\LGTVCompanion\vcpkg_installed\x64-windows-static\x64-windows-static\include\boost\asio\detail\win_iocp_socket_service.hpp:632:5 in function 'connect'] Mon 01:59:37 > Device1, [DEBUG] (SSL) ON response 1: {"type":"registered","id":"register_0","payload":{"client-key":"eda678071598af672e4db09d15f5084d"}} Mon 01:59:37 > Device1, [DEBUG] (SSL) ON response 2: {"type":"error","id":39,"error":"500 Application error","payload":{"returnValue":false,"errorCode":"-2","errorText":"com.webos.service.tvpower/power is busy"}} Mon 01:59:37 > Device1, [DEBUG] (SSL) ON response 3: {"type":"response","id":40,"payload":{"returnValue":true,"state":"Suspend","processing":"Screen On"}} Mon 01:59:37 > Device1, [DEBUG] (SSL) ON response 1: {"type":"registered","id":"register_0","payload":{"client-key":"eda678071598af672e4db09d15f5084d"}} Mon 01:59:37 > Device1, [DEBUG] (SSL) ON response 2: {"type":"error","id":41,"error":"500 Application error","payload":{"returnValue":false,"errorCode":"-2","errorText":"com.webos.service.tvpower/power is busy"}} Mon 01:59:37 > Device1, [DEBUG] (SSL) ON response 3: {"type":"response","id":42,"payload":{"returnValue":true,"state":"Suspend","processing":"Screen On"}} Mon 01:59:39 > Device1, [DEBUG] (SSL) ON response 1: {"type":"registered","id":"register_0","payload":{"client-key":"eda678071598af672e4db09d15f5084d"}} Mon 01:59:39 > Device1, [DEBUG] (SSL) ON response 2: {"type":"error","id":43,"error":"500 Application error","payload":{"returnValue":false,"errorCode":"-2","errorText":"com.webos.service.tvpower/power is busy"}} Mon 01:59:39 > Device1, [DEBUG] (SSL) ON response 3: {"type":"response","id":44,"payload":{"returnValue":true,"state":"Suspend","processing":"Screen On"}} Mon 01:59:39 > Device1, [DEBUG] (SSL) ON response 1: {"type":"registered","id":"register_0","payload":{"client-key":"eda678071598af672e4db09d15f5084d"}} Mon 01:59:39 > Device1, [DEBUG] (SSL) ON response 2: {"type":"error","id":45,"error":"500 Application error","payload":{"returnValue":false,"errorCode":"-2","errorText":"com.webos.service.tvpower/power is busy"}} Mon 01:59:39 > Device1, [DEBUG] (SSL) ON response 3: {"type":"response","id":46,"payload":{"returnValue":true,"state":"Suspend","processing":"Screen On"}} Mon 01:59:40 > Device1, [DEBUG] (SSL) ON response 1: {"type":"registered","id":"register_0","payload":{"client-key":"eda678071598af672e4db09d15f5084d"}} Mon 01:59:40 > Device1, [DEBUG] (SSL) ON response 2: {"type":"error","id":47,"error":"500 Application error","payload":{"returnValue":false,"errorCode":"-2","errorText":"com.webos.service.tvpower/power is busy"}} Mon 01:59:40 > Device1, [DEBUG] (SSL) ON response 3: {"type":"response","id":48,"payload":{"returnValue":true,"state":"Suspend","processing":"Screen On"}} Mon 01:59:41 > Device1, [DEBUG] (SSL) ON response 1: {"type":"registered","id":"register_0","payload":{"client-key":"eda678071598af672e4db09d15f5084d"}} Mon 01:59:41 > Device1, [DEBUG] (SSL) ON response 2: {"type":"error","id":49,"error":"500 Application error","payload":{"returnValue":false,"state":"Active","errorCode":"-102","errorText":"The current state must be 'Screen Off'"}} Mon 01:59:41 > Device1, [DEBUG] (SSL) ON response 3: {"type":"response","id":50,"payload":{"returnValue":true,"state":"Active"}} Mon 01:59:41 > Device1, power state is: ON Mon 01:59:41 > Device1, repeating WOL broadcast ended Mon 04:06:56 > ** System requests displays OFF. Mon 04:06:56 > Device1, spawning Thread_DisplayOff(). Mon 04:07:17 > Device1, WARNING! Thread_DisplayOff(): connect: A connection attempt failed because the connected party did not properly respond after a period of time, or established connection failed because connected host has failed to respond [system:10060 at D:\a\LGTVCompanion\LGTVCompanion\vcpkg_installed\x64-windows-static\x64-windows-static\include\boost\asio\detail\win_iocp_socket_service.hpp:632:5 in function 'connect'] Mon 04:16:16 > -daemon 1 useridle Mon 04:16:16 > Device1, spawning Thread_DisplayOff(). Mon 04:16:37 > Device1, WARNING! Thread_DisplayOff(): connect: A connection attempt failed because the connected party did not properly respond after a period of time, or established connection failed because connected host has failed to respond [system:10060 at D:\a\LGTVCompanion\LGTVCompanion\vcpkg_installed\x64-windows-static\x64-windows-static\include\boost\asio\detail\win_iocp_socket_service.hpp:632:5 in function 'connect'] Mon 04:26:16 > -daemon 1 useridle Mon 04:26:16 > Device1, spawning Thread_DisplayOff(). Mon 04:26:37 > Device1, WARNING! Thread_DisplayOff(): connect: A connection attempt failed because the connected party did not properly respond after a period of time, or established connection failed because connected host has failed to respond [system:10060 at D:\a\LGTVCompanion\LGTVCompanion\vcpkg_installed\x64-windows-static\x64-windows-static\include\boost\asio\detail\win_iocp_socket_service.hpp:632:5 in function 'connect'] Mon 04:36:16 > -daemon 1 useridle Mon 04:36:16 > Device1, spawning Thread_DisplayOff(). Mon 04:36:37 > Device1, WARNING! Thread_DisplayOff(): connect: A connection attempt failed because the connected party did not properly respond after a period of time, or established connection failed because connected host has failed to respond [system:10060 at D:\a\LGTVCompanion\LGTVCompanion\vcpkg_installed\x64-windows-static\x64-windows-static\include\boost\asio\detail\win_iocp_socket_service.hpp:632:5 in function 'connect'] Mon 04:46:16 > -daemon 1 useridle Mon 04:46:16 > Device1, spawning Thread_DisplayOff(). Mon 04:46:37 > Device1, WARNING! Thread_DisplayOff(): connect: A connection attempt failed because the connected party did not properly respond after a period of time, or established connection failed because connected host has failed to respond [system:10060 at D:\a\LGTVCompanion\LGTVCompanion\vcpkg_installed\x64-windows-static\x64-windows-static\include\boost\asio\detail\win_iocp_socket_service.hpp:632:5 in function 'connect'] Mon 04:56:16 > -daemon 1 useridle Mon 04:56:16 > Device1, spawning Thread_DisplayOff(). Mon 04:56:37 > Device1, WARNING! Thread_DisplayOff(): connect: A connection attempt failed because the connected party did not properly respond after a period of time, or established connection failed because connected host has failed to respond [system:10060 at D:\a\LGTVCompanion\LGTVCompanion\vcpkg_installed\x64-windows-static\x64-windows-static\include\boost\asio\detail\win_iocp_socket_service.hpp:632:5 in function 'connect'] Mon 05:05:58 > ** System is suspending to a low power state.(or event callback is missing) Mon 05:08:15 > ** System resumed from low power state (Automatic). Mon 05:08:15 > ** System requests displays ON. Mon 05:08:15 > Device1, spawning Thread_DisplayOn(). Mon 05:08:15 > Device1, repeating WOL broadcast started to MAC: B4B291B850F0 using IP address: <IP_ADDRESS> Mon 05:08:15 > Device1, Best route to IP - interface index 16 LUID<PHONE_NUMBER>741120 route protocol 2 Mon 05:08:15 > ** System resumed from low power state. Mon 05:08:16 > Device1, [DEBUG] (SSL) ON response 1: {"type":"registered","id":"register_0","payload":{"client-key":"eda678071598af672e4db09d15f5084d"}} Mon 05:08:16 > Device1, [DEBUG] (SSL) ON response 2: {"type":"error","id":2,"error":"500 Application error","payload":{"returnValue":false,"errorCode":"-2","errorText":"com.webos.service.tvpower/power is busy"}} Mon 05:08:16 > Device1, [DEBUG] (SSL) ON response 3: {"type":"response","id":3,"payload":{"returnValue":true,"state":"Suspend","processing":"Screen On"}} Mon 05:08:31 > Device1, WARNING! Thread_DisplayOn(): handshake: An existing connection was forcibly closed by the remote host [system:10054] Mon 05:08:31 > Device1, [DEBUG] (SSL) ON response 1: {"type":"registered","id":"register_0","payload":{"client-key":"eda678071598af672e4db09d15f5084d"}} Mon 05:08:31 > Device1, [DEBUG] (SSL) ON response 2: {"type":"error","id":4,"error":"500 Application error","payload":{"returnValue":false,"state":"Active","errorCode":"-102","errorText":"The current state must be 'Screen Off'"}} Mon 05:08:31 > Device1, [DEBUG] (SSL) ON response 3: {"type":"response","id":5,"payload":{"returnValue":true,"state":"Active"}} Mon 05:08:31 > Device1, power state is: ON Mon 05:08:32 > Device1, repeating WOL broadcast ended Mon 09:07:56 > -poweroff Device1 Mon 09:07:56 > [IPC] Force power OFF: Device1  Mon 09:07:56 > Device1, spawning Thread_DisplayOff(). Mon 09:07:57 > Device1, [DEBUG] (SSL) OFF response 1: {"type":"registered","id":"register_0","payload":{"client-key":"eda678071598af672e4db09d15f5084d"}} Mon 09:07:57 > Device1, [DEBUG] (SSL) OFF response 2: {"type":"response","id":7,"payload":{"returnValue":true,"state":"Active"}} Mon 09:07:57 > Device1, [DEBUG] (SSL) OFF response 4: {"type":"response","id":8,"payload":{"returnValue":true}} Mon 09:07:57 > Device1, power state is: OFF. Mon 09:08:10 > -poweron Device1 Mon 09:08:10 > [IPC] Force power ON: Device1  Mon 09:08:10 > Device1, spawning Thread_DisplayOn(). Mon 09:08:10 > Device1, repeating WOL broadcast started to MAC: B4B291B850F0 using IP address: <IP_ADDRESS> Mon 09:08:10 > Device1, Best route to IP - interface index 16 LUID<PHONE_NUMBER>741120 route protocol 2 Mon 09:08:11 > Device1, [DEBUG] (SSL) ON response 1: {"type":"registered","id":"register_0","payload":{"client-key":"eda678071598af672e4db09d15f5084d"}} Mon 09:08:11 > Device1, [DEBUG] (SSL) ON response 2: {"type":"error","id":9,"error":"500 Application error","payload":{"returnValue":false,"state":"Active","errorCode":"-102","errorText":"The current state must be 'Screen Off'"}} Mon 09:08:11 > Device1, [DEBUG] (SSL) ON response 3: {"type":"response","id":10,"payload":{"returnValue":true,"state":"Active"}} Mon 09:08:11 > Device1, power state is: ON Mon 09:08:11 > Device1, repeating WOL broadcast ended

The PC wakes up for a backup between 3 and 3:40 AM so that matches with your log analysis.. no one was at the PC all night and definitely not between 5 and 9am.

I just now tried turning off wake-timers and wake on lan.. I'll need WOL back eventually but it's a good debugging step thanks for your help I'll report back once I narrow things down a bit more.
Greg

So.. no use all night and morning.. checked at 2pm and screen was on again.. looks like the computer is not properly sleeping which is maybe half the issue. Not sure why LG Companion doesn't think it's idle might be the same issue. I'll try killing some tasks and services next time around.  The TV Auto Power off after four hours feature was off so not sure why it's still got unreachable host messages.
Log.txt

Hi @Tailslide did you have any more progress in troubleshooting the issue?

@JPersson77 , the problem is with the user idle detection on my system.. it was detecting me as using the computer when I wasn't.   I turned it off and everything is working good now... so I guess you can close this issue?

Hi thanks, I can't really reconcile the info . The app use a trivial api in windows to detect when the user is idle so if the app does not see you as idle then the rest of windows will not see you as idle either. Wrt the PC seemingly waking up I have one more troubleshooting tips, try to disable "wake on pattern match " in your network settings.

Wrt the PC seemingly waking up I have one more troubleshooting tips, try to disable "wake on pattern match " in your network settings.

This turned out to be an unrelated issue I tracked down to a USB device that was waking the PC.

Thanks! But I fail to see how the app can cause an issue with the screen going idle. Potentially there can be a bug which erroneously wake the screen
One thing to try, if you like, is to show the daemon status window with "lgtvdaemon.exe -show" and check the idle counter to try and determine if something is resetting the coutner

Not sure what was going on.. my screen never turned off then I disabled the user idle setting and my screen off settings in windows started working again.  Maybe some conflict between user idle and my desktop monitor sleep settings?  Like if the monitor went into sleep mode at the same time user idle fired off?
I just now tried updating to the latest lgtv companion and set user idle timeout to 1 minute and it seemed to work.. the screen went black but the monitor didn't power off.   I'll try setting it back to 10 minutes again and see if I have trouble again.

Hi, I think maybe I read that you have user idle mode and "turn monitor off after x minutes" set to the same time? User idle mode will blank the screen while the other option will turn the TV off, so having them set to the same time is a bit undefined. It's better to have user idle mode set to something like 5 minutes and then have the windows power option set to 10 minutes or so.
Maybe I misread your comment

I wasn't intentionally setting it to the same time but I also hadn't checked to ensure they were set to different times.  I just went back and checked and they were both set to 10 minutes so I changed the windows setting to 15 minutes.

Closing due to resolved. Feel free to reopen as needed


Command-line options from GNU Make

Ported over a bunch of command-line options from GNU Make, allowing the user to

mark files as new (or old), to trigger (or suppress) rebuilds
touch files instead of updating them. In biomake, "touching" also updates their MD5 hash, if applicable.

Also added a bunch more tests, thoroughly exercising the conditional Makefile syntax and a few other features.

have we lost the travis tests?

ok, got my own travis now


Note explicitly somewhere that all profile information is public on the internet

I think at one point we were intending to implement something in the way of privacy controls, but those aren't going to exist at launch; right now, if it's on the site, it's public. So this should probably be stated explicitly at the point where information is entered. Unless people think it's already sufficiently obvious from the UI?

Added this note under the sign up button

Added this note under the sign up button.

@taymonbeal close if you're happy with this

Looks good to me, at least given the current state of the tech.


MET-19588: Update rate/delta operators docs to reflect new features

Purpose of this pull request
We are introducing new features to rate and delta metrics operators. I've updated the documentation to cover these new features and also made these two pages slightly more consistent.
IMPORTANT
The features are not enabled for our customers yet, so we need to wait with merging these changes until then.
Issue number: MET-19588

Select the type of change:

[ ] Minor Changes - Typos, formatting, slight revisions
[ ] Update Content - Revisions and updating sections
[x] New Content - New features, sections, pages, tutorials
[ ] Site and Tools - Updates, maintenance, and new packages for the site, Gatsby, React, etc

This shouldn't have been merged yet - the feature is not enabled (as was stated in the PR description). Reverting it for now.


double check "and" instruction

it's probably queueing the next child, event if it doesn't need to...

closed via https://github.com/flon-io/flon/commit/7e39c12f2a2afffa1ed108d6b301db629eb70bf6


Add "Let's build a compiler" tutorial

Add "Let's build a compiler" tutorial by Jack Crenshaw.

I have mixed feelings about this tutorial. On the one hand, it's a very cool one. On the other hand, Pascal is a pretty archaic language so I'm not even sure if it will be read by anyone. @enkeyz  your thoughts?

I'd consider adding this, if not it's ancient format. It's literally a text file, with no syntax highlighting, formatting, etc.

Let's pass on this one then. Since it won't provide too much value imo


AQL performance v3.2.x vs v3.1.1

my environment running ArangoDB
I'm using the latest ArangoDB of the respective release series:

[x] 3.2

Mode:

[x] Single-Server

Storage-Engine:

[x] mmfiles

On this operating system:

[x] Linux

[x] docker - official docker library

this is an AQL-related issue:

[x] I'm using graph features

I'm issuing AQL via:

[x] web interface with this browser:     running on this OS:
[x] this Driver: arango-java-driver

I've run db._explain("<my aql query>") and it didn't shed more light on this.
The AQL query in question is:  AQL performance in v3.2.x docker takes too long when we have higher depth level. In version 3.1.1 it worked fine with same values. Is it expected behavior?
These are the steps to reproduce:

open the browser on http://<IP_ADDRESS>:8529
use database with simple graph which is relevant to query in step 5
create simple graph structure with 10 nodes
Select Queries
execute AQL

FOR vertex, e, path IN 0..2147483647 INBOUND @rootVertex GRAPH 'graph' FILTER LAST(path.vertices)._key IN @ids RETURN vertex`
// this takes **~25 seconds**

and this with depth lesser than the previous one:
FOR vertex, e, path IN 0..7483647 INBOUND @rootVertex GRAPH 'graph' RETURN vertex
// takes only **0.132970 seconds**

This happens with arango docker 3.2.X version but worked fine with 3.1.1 (without huge delay)
...

Hi,
can you post the explain() output of both versions?

Hi,
thanks for quick response. Please check explain below:
with depth 7483647
Query string:
 FOR vertex, e, path IN 0..7483647 INBOUND @rootVertex GRAPH @graph RETURN vertex

Execution plan:
 Id   NodeType        Est.   Comment
  1   SingletonNode      1   * ROOT
  2   TraversalNode      0     - FOR vertex  /* vertex */ IN 0..7483647  /* min..maxPathDepth */ INBOUND 'vertices-cccccccccccccccccccc/0001045E00040002-1303-0030319D' /* startnode */  GRAPH 'graph'
  3   ReturnNode         0     - RETURN vertex

Indexes used:
 By   Type   Collection                 Unique   Sparse   Selectivity   Fields               Ranges
  2   edge   edges-iiiiii               false    false       100.00 %   [ `_from`, `_to` ]   base INBOUND
  2   edge   edges-ddddddddddddddd      false    false       100.00 %   [ `_from`, `_to` ]   base INBOUND
  2   edge   edges-ggggggggggggg        false    false        75.00 %   [ `_from`, `_to` ]   base INBOUND
  2   edge   edges-ffffffffffffffffff   false    false        68.75 %   [ `_from`, `_to` ]   base INBOUND
  2   edge   edges-eeeeeeeeeeeeeee      false    false       100.00 %   [ `_from`, `_to` ]   base INBOUND
  2   edge   edges-hhhhhhhhhhhhhhhh     false    false        83.33 %   [ `_from`, `_to` ]   base INBOUND

Traversals on graphs:
 Id   Depth        Vertex collections                                                Edge collections                                                                                Options                                   Filter conditions
  2   0..7483647   vertices-aaaaaa, vertices-bbbbbb, vertices-cccccccccccccccccccc   edges-ddddddddddddddd, edges-eeeeeeeeeeeeeee, edges-ffffffffffffffffff, edges-ggggggggggggg, edges-hhhhhhhhhhhhhhhh, edges-iiiiii   uniqueVertices: none, uniqueEdges: path

Optimization rules applied:
 Id   RuleName
  1   optimize-traversals

with depth<PHONE_NUMBER>
Query string:
 FOR vertex, e, path IN 0..2147483647 INBOUND @rootVertex GRAPH @graph RETURN vertex

Execution plan:
 Id   NodeType        Est.   Comment
  1   SingletonNode      1   * ROOT
  2   TraversalNode      0     - FOR vertex  /* vertex */ IN 0..2147483647  /* min..maxPathDepth */ INBOUND 'vertices-cccccccccccccccccccc/0001045E00040002-1303-0030319D' /* startnode */  GRAPH 'graph'
  3   ReturnNode         0     - RETURN vertex

Indexes used:
 By   Type   Collection                 Unique   Sparse   Selectivity   Fields               Ranges
  2   edge   edges-iiiiii               false    false       100.00 %   [ `_from`, `_to` ]   base INBOUND
  2   edge   edges-ddddddddddddddd      false    false       100.00 %   [ `_from`, `_to` ]   base INBOUND
  2   edge   edges-ggggggggggggg        false    false        75.00 %   [ `_from`, `_to` ]   base INBOUND
  2   edge   edges-ffffffffffffffffff   false    false        68.75 %   [ `_from`, `_to` ]   base INBOUND
  2   edge   edges-eeeeeeeeeeeeeee      false    false       100.00 %   [ `_from`, `_to` ]   base INBOUND
  2   edge   edges-hhhhhhhhhhhhhhhh     false    false        83.33 %   [ `_from`, `_to` ]   base INBOUND

Traversals on graphs:
 Id   Depth           Vertex collections                                                Edge collections                                                                                Options                                   Filter conditions
  2   0..2147483647   vertices-aaaaaa, vertices-bbbbbb, vertices-cccccccccccccccccccc   edges-ddddddddddddddd, edges-eeeeeeeeeeeeeee, edges-ffffffffffffffffff, edges-ggggggggggggg, edges-hhhhhhhhhhhhhhhh, edges-iiiiii   uniqueVertices: none, uniqueEdges: path

Optimization rules applied:
 Id   RuleName
  1   optimize-traversals

Ok, the optimizer has the problem here, as we can already see by your explain time; We have been able to reproduce this.

Thanks for spotting and reporting it.
Fixes are available on 3.2 onwards and will be part of next releases.
Does not apply to 3.1 and earlier


static pod not support configmap or secret

Add note that static pods do not support configmap or secret.
fix: #28611

This issue is about documentation that is sourced from the website repo.  For documentation that is in comments in the code, see https://github.com/kubernetes/kubernetes/issues/103167 .

@MikeSpreitzer Thanks for the clarification. I've updated the doc with your comments.

@kbhawkey @mikedanese Could you please review the PR? Thanks a lot!

@tengqm Thanks for the review. I've updated with your comments.

/approve

/lgtm


It is not working anymore

Hello, love this but there seems to be big problem. It seems youtube removed the http://www.youtube.com/get_video_info access for everyone so it is not working anymore? Did the url change? Do you know the new url?

update:
I have updated the code in YouTubeDownloader.php file and added : html5=1&
so it looks : https://www.youtube.com/get_video_info?html5=1&....
and it seems to work for now? Let me know if this was the only problem or if I am missing something.

Hi, thanks for modifications, it's working on my side. Unfortunately, you just forgot to commit changes... so I changed directly on my copy, it's just to inform you.

Yup it seems like YouTube wants to retire that endpoint already, but adding html=1 for now still makes it work.  I've made the changes to the code, so just do composer update from your end and this should work now.
https://github.com/Athlon1600/youtube-downloader/releases/tag/v3.0.1


Persist AWS CLI configuration in .runiac directory

Proposed changes
In preparation to support a new AWS starter project.
Persist and copy the AWS CLI config directory in .runiac. This provides the same login-once experience that the Azure and GCP entrypoint.sh scripts offer.
Issues for these changes
N/A
Types of changes

[ ] Bugfix (non-breaking change which fixes an issue)
[X] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Refactor (changes to code, which do not change application behavior)

Checklist

[X] I have filled out this PR template
[X] I have read the CONTRIBUTING doc
[] I have added automated tests that prove my fix is effective or that my feature works
[X] I have added necessary documentation (README.md, CHANGELOG.md, etc. - if appropriate)

Dependencies and Blockers
N/A
Relevant Links

AWS CLI config documentation

Further comments
N/A

@mbpolan does this pull request come with a hello world starter?


problems when parsing older paper in PDF format

Hi, thanks for this great toolkit!
I tried the papermage with several PDF files. It works really well with recent papers but when I tried to parse some papers published in 1980 or 1989, papermage failed to parse the sentences.
doc = recipe.run("1980.pdf")
for sen in doc.sentences:
    print(sen.text)
'''
output:
Received
January
1978;
revised
October
1979;
accepted
December 1979
References
1.
Avery,
K.
R.
,
and
Avery,
C.
A.
Design
and
development
of an interactive
statistical
system
(SIPS).
Proc.
Comptr.
Sci.
and
Statistics: 8th
Ann.
Symp.
on
'''

Interesting! could you send me the PDF so I can have a look at it? older PDFs not something we really investigated much

1980.pdf
1989.pdf
These are the two PDF files that I have tested. Thanks!


.NET Standard 2.0

Any plans to support .NET Standard 2.0? I will take this on and submit a PR for it.

We tried to support .NET, but ran into a bunch of issues with Bazel. We also don't have anyone knowing .NET on the team.
Like PHP, I think it's best to create a separate repo, and we can help you review your design and implementation.
Please let us know if this works for you.

This is being implemented at https://github.com/elucidsoftllc/tink.net

Thanks @elucidsoft. Please reopen if you have any questions or need help from us.

That repo is not available anymore. What happened @elucidsoft ?

That repo is not available anymore. What happened @elucidsoft ?

Life happened really. I just don't have the time.

But why did you delete the repo instead of setting it to archived? Maybe somebody else wants to pick it up.


RTL fix RTL_LAND_DELAY behaviour

Fixed wing test flight reported RTL ignoring the RTL_LAND_DELAY setting and landing immediately.
https://logs.px4.io/plot_app?log=c412160a-56e3-4154-b3d8-2c582aa9b9f1
This PR introduces a helper for float comparison, uses it to fix RTL_LAND_DELAY, and changes the RTL land notification to critical so that the user is alerted and the RTL state change is a little more obvious in logs.
Tested in SITL.
@santiago3dr

Not enough flash in px4fmu-v2 for this small fix.
Minor cleanup to make room - https://github.com/PX4/Firmware/pull/8353

@dagar could you rebase?

@dagar Still failing - checking..

Making almost equals consistent and adding tests.

I'll save the new library features for after the release. Reverted to simple working RTL_LAND_DELAY check from PX4 stable.
Good to go.

Jenkins test this please.


Add connection related functionality to VisualShader (deleting, dropping/inserting a node)

To demonstrate the new connection functionality, I went ahead and implemented some UX improvements for VS.
Depends on #86158.

Add a context menu for connections in the VisualShader editor consisting of

Disconnect: Deletes the connection
Insert New Node: Opens the "Create Shader Node" dialog and inserts the chosen node by splitting the original connection.

TODO:

[x] Allow dragging fully unconnected nodes on connections to insert them
[x] Polish

Amazing! Do you think adding a knife tool would be hard to implement here?

Small update: Unconnected nodes can now be dropped on connections!

OMG YES!

Needs a rebase

Rebased, but this PR depends on #86158. That one needs to be merged first, this PR is just already based on the connections rework branch.

Okay, I'll mark it as a draft for the time being then.

Rebased after #86158 got merged.
Tested and it looks like all features still work fine.

Thanks! If there are further changes required in the VS plugin, we can do them in a follow-up.
(And I personally still want this knife tool :P )


HSOpticalFlow SYCL Migration sample - 2024.0 update

Existing Sample Changes
Description
Updated sample with changes applicable to oneAPI 2024.0 release, updated README.md .
Type of change
Please delete options that are not relevant. Add a 'X' to the one that is applicable.

[ ] Bug fix (non-breaking change which fixes an issue)
[X] New feature (non-breaking change which adds functionality)
[ ] Implement fixes for ONSAM Jiras

How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

[X] Command Line
[ ] oneapi-cli
[ ] Visual Studio
[ ] Eclipse IDE
[ ] VSCode
[X] When compiling the compliler flag "-Wall -Wformat-security -Werror=format-security" was used

@Shwetha-Selma Getting this error message:
make run_smo
make: *** No rule to make target 'run_smo'.  Stop.

Perhaps remove that line in the sample.json file?


spiegel-de.spiegel.de

spiegel-de.spiegel.de is blocked but its needed to accept the cookie banner on https://www.spiegel.de/

Thanks for reporting. I've removed the domain from the list


Add a note regarding credentials

Description
Better explain the use of AWS credentials
Code of Conduct
By submitting this pull request, I agree to follow the code of conduct.

@TheCatLady please correct spelling as you see fit 😄


Account reset fail

I'm trying to publish from a new development machine, and recreating my npm user on that machine with npm adduser. The addUser is failing as below, when I go to the user reset page I'm told "That username was not found in the repository!".
"npm user ls mocket" correctly reports my username/email (davethehat)
Thanks
David
npm WARN Incorrect username or password
npm WARN You can reset your account by visiting:
npm WARN
npm WARN     http://admin.npmjs.org/reset
npm WARN
npm ERR! Error: unauthorized Name or password is incorrect.: -/user/org.couchdb.user:davethehat/-rev/1-8daa2233a493e87efb41faa3eaf3ddc3
npm ERR!     at Request._callback (/usr/local/lib/node_modules/npm/lib/utils/npm-registry-client/request.js:180:12)
npm ERR!     at Request.callback (/usr/local/lib/node_modules/npm/node_modules/request/main.js:99:22)
npm ERR!     at Request. (/usr/local/lib/node_modules/npm/node_modules/request/main.js:361:18)
npm ERR!     at Request.emit (events.js:64:17)
npm ERR!     at IncomingMessage. (/usr/local/lib/node_modules/npm/node_modules/request/main.js:327:16)
npm ERR!     at IncomingMessage.emit (events.js:81:20)
npm ERR!     at HTTPParser.onMessageComplete (http.js:133:23)
npm ERR!     at CleartextStream.ondata (http.js:1231:22)
npm ERR!     at CleartextStream._push (tls.js:303:27)
npm ERR!     at SecurePair.cycle (tls.js:577:20)
npm ERR! Report this entire log at:
npm ERR!     http://github.com/isaacs/npm/issues
npm ERR! or email it to:
npm ERR<EMAIL_ADDRESS>npm ERR!
npm ERR! System Linux 3.0.0-15-generic
npm ERR! command "node" "/usr/local/bin/npm" "adduser" "davethehat"
npm ERR! cwd /home/david/dev/Mocket
npm ERR! node -v v0.4.12
npm ERR! npm -v 1.0.106
npm ERR!
npm ERR! Additional logging details can be found in:
npm ERR!     /home/david/dev/Mocket/npm-debug.log
npm not ok

Your email is invalid in your user account.
Delivery to the following recipient failed permanently:

<EMAIL_ADDRESS>
Technical details of permanent failure:
DNS Error: Domain name not found

It looks like a misspelling.  I forwarded the token to<EMAIL_ADDRESS>(Note the 'e' in 'technology').

Ah - . Thanks, Isaac!


Define and Implement TransactionRepository

Define TransactionRepository interface and a LevelDB implementation.

@mikiquantum removing the blocker as this is actually blocking the Status Endpoint


Upgrade to Alpine 3.10

@cpanato could you check this during the next update? :smiley:

Hello @J0WI we already using the alpine 10 here: https://github.com/mattermost/mattermost-server/blob/master/build/Dockerfile and that build the mattermost/mattermost-enterprise-edition and mattermost/mattermost-team-edition as we said in the docker channel we will deprecate this repo and the mattermost-prod-app in version 6.0 but until there we will keep building the images for this repo as well
i will update this repo to use alpine 10 :)

c1dea8605b8464d03a8150be24392c2983c424d7

@cpanato the latest tag of mattermost/mattermost-team-edition is outdated and only tags with minor releases (like 5.14.1) are available. 5or5.14` are not available, which makes it hard to maintain.


How is this installed?

Could not find any instructions on how to install this plugin.
Downloading it and telling IntelliJ to install from zip folder just returns a "Failed to load plugin descriptor" error.
It became apparent later that it was just a project structure...but that didn't help any.

Did you figure this out? @NC256

Did you figure this out? @NC256

Unfortunately I did not. I was originally using the MARS simulator and just went back to it when I couldn't find any alternatives.

Unfortunately I did not. I was originally using the MARS simulator and just went back to it when I couldn't find any alternatives.

I tried to build the plugin using the IntelliJ provided plugin template. However, I soon learned there are missing files in this project. I gave up after that.

I tried to build the plugin using the IntelliJ provided plugin template. However, I soon learned there are missing files in this project. I gave up after that.

anyone make anymore progress on this?


Problem when master node dies second time

When master pod my-cluster-mysql-0 dies, then my-cluster-mysql-[1-9] becomes master pod. Then if cluster is resized to 1 replica, then master node my-cluster-mysql-1  is deleted, and cluster stays with one my-cluster-mysql-0 pod which become master, so first time this works fine. Then when we do the same second time (resize to 2, delete master node, resize to 1), we have my-cluster-mysql-0 pod which is configured as slave.
Steps to reproduce:
% kubectl get pods -n ns
NAME                              READY   STATUS    RESTARTS   AGE
my-cluster-mysql-0                4/4     Running   0          47h
my-cluster-mysql-1                4/4     Running   0          9m34s
my-cluster-mysql-2                4/4     Running   0          8m47s

 % kubectl describe pod my-cluster-mysql-0 -n ns | grep role
              role=master

% kubectl delete pod my-cluster-mysql-0 -n ns
pod "my-cluster-mysql-0" deleted

% kubectl describe pod my-cluster-mysql-0 -n ns | grep role
              role=replica
% kubectl describe pod my-cluster-mysql-1 -n ns | grep role
              role=replica
% kubectl describe pod my-cluster-mysql-2 -n ns | grep role
              role=master

Resize cluster by changing replicas to 1:
apiVersion: mysql.presslabs.org/v1alpha1
kind: MysqlCluster
metadata:
  name: my-cluster
  namespace: ns
spec:
  replicas: 1
  ...

and apply changes:
% kubectl apply -f ./k8s/operator/mysql-cluster.yaml
mysqlcluster.mysql.presslabs.org/my-cluster configured

% kubectl get pods -n ns
NAME                              READY   STATUS        RESTARTS   AGE
my-cluster-mysql-0                4/4     Running       0          7m6s

Now everything is fine:
% kubectl describe pod my-cluster-mysql-0 -n ns | grep role
              role=master

Now resize to 2 pods:
apiVersion: mysql.presslabs.org/v1alpha1
kind: MysqlCluster
metadata:
  name: my-cluster
  namespace: ns
spec:
  replicas: 2
  ...

% kubectl apply -f ./k8s/operator/mysql-cluster.yaml
mysqlcluster.mysql.presslabs.org/my-cluster configured

% kubectl get pods -n ns
NAME                              READY   STATUS    RESTARTS   AGE
my-cluster-mysql-0                4/4     Running   0          12m
my-cluster-mysql-1                3/4     Running   0          39s

% kubectl describe pod my-cluster-mysql-0 -n ns | grep role
              role=master
% kubectl describe pod my-cluster-mysql-1 -n ns | grep role
              role=replica

And delete master node again:
% kubectl delete pod my-cluster-mysql-0 -n ns
pod "my-cluster-mysql-0" deleted

% kubectl describe pod my-cluster-mysql-1 -n ns | grep role
              role=master
% kubectl describe pod my-cluster-mysql-0 -n ns | grep role
              role=replica

Now resize to 1:
apiVersion: mysql.presslabs.org/v1alpha1
kind: MysqlCluster
metadata:
  name: my-cluster
  namespace: ns
spec:
  replicas: 1
  ...

% kubectl get pods -n ns
NAME                              READY   STATUS    RESTARTS   AGE
my-cluster-mysql-0                4/4     Running   0          117s

% kubectl describe pod my-cluster-mysql-0 -n ns | grep role
              role=replica

As the result we have non working cluster with one pod which is configured as slave and can't connect to the master:
% kubectl logs my-cluster-mysql-0 mysql -n ns
2020-09-17T13:27:37.183833Z 219 [ERROR] Slave I/O for channel '': error connecting to master 'sys_replication@//my-cluster-mysql-1.mysql.ns:3306' - retry-time: 1  retries: 331, Error_code: 2005

@AlexTr @AMecea I am also running into the same issue. Did you ever resolved this?

@munjalpatel  sorry, I wasn't able to work on in since then, so no solution so far, however I didn't test newer version yet.


Replace deprecated DeploymentConfig by Deployment

What
Dropped DeploymentConfig adding Deployment.
Why
DeploymentConfig is now deprecated.
References

Replace deprecated DeploymentConfigs with deployments: RedHat Learning Developers Docs

Co-Authored by: @DerekRoberts

@RMCampos, I would highly recommend retargeting this PR at the upstream fork of the backup container; https://github.com/BCDevOps/backup-container.  This fork is not actively maintained.


Fix lookup bindings

A couple of fixes to bindings.js. In a test that uses foreign field gates in plain Kimchi circuits in JS, these fixes are what makes compile, prove and verify run; but verify at this moment returns false

@rbonichon it's not true that we can't use code generated from proof-systems. This class definition code (in the compiled artifact) is generated from proof-systems:

This issue is that this contains no way to create instances of this class from that outside

By comparison, this is generated for the new class:

wires.rs has the following

Discussed with @rbonichon. He will update https://github.com/o1-labs/proof-systems/pull/1245/ to use constructor and we can therefore remove the WasmCLASS definitions.


Delete useless .vscode directory

Should be in .gitignore and also only contains a reiteration of the default setting

You did .gitignore wrong so this fixes it


fix uikit build in sync androidx 1.2.1

On uikit fails this code:
var textState1 by remember { mutableStateOf("text field 1") }

But work's this:
val textState1 = remember { mutableStateOf("text field 1") }

What's the error when "by" is used?

Failed with this error:
Compilation failed: no function <set-textState1> in androidx.compose.mpp.demo

CI is failing, so I think nobody will mind if I merge this PR :)


Ibex ISA Smoke Test

Initial parts of the Ibex ISA smoke test.
Instructions that are not yet checked but will be in a future PR:

c.ebreak
ecall
mret
wfi

ebreak is tested in sram_start and -dret will never be covered see https://github.com/lowRISC/opentitan/issues/20031#issuecomment-1780850909
Covers most of https://github.com/lowRISC/opentitan/issues/20031

@HU90m please could you add that missing license and run bazel run //quality:clang_format_fix?

Coming back to this, I think we've been putting the host side of SiVal tests in /sw/host/tests/chip, not /sw/host/tests/sival - would you mind moving your test over there please?

/sw/host/tests/chip only contains host side code. Where do you think I should put the chip components of the test? Ordinarily I'd use /sw/device/tests, but this test expects to be run from SRAM and is far more similar to those in /sw/device/silicon_creator/manuf/tests which would not be a good home for them.

I think you could still keep your assembly file along with your Rust half in sw/host/tests/chip/....
Actually, can I ask what the C part of the test is for? It is just to satisfy giving something to opentitan_test?