Expose way for native modules to modify JSC context

We at Realm are developing a native module that actually requires using the JavaScriptCore API to expose a custom object into the context. At the moment, we have been using swizzling in Objective-C and a patched version of React Native, but we obviously can't continue to do this when we release.
The new APIs in this PR were made to best suit the existing React Native APIs on each platform. They provide the necessary hooks for advanced native module authors to accomplish what we are doing without any hacks.

How does this interact with Chrome debugging? I imagine that your native module wouldn't work in that case? We've tried to avoid exposing details specific to any particular executor in order to give us more flexibility in the future to switch engines, etc.

@spicyj without knowing the specifics my sense is it's likely incompatible with Chrome debugging. That doesn't worry me a whole lot because the JSC debugger is getting better (slated for OS X 10.12) but your point about switching engines to something like V8 is a good one.

The iOS side of this PR looks reasonable to me, although I'd move the notification definition to RCTJSCExecutor.h, since you'd only want to have access to that symbol if you also depend on the JSC being used.

Thanks for taking the time to look at this!
@spicyj we have our own crazy solution for Chrome debugging that hopefully won't be needed for very long considering JSC debugging is coming along. I appreciate wanting future flexibility with changing JS engines, but if that ever happens, we can add an API that returns an enum describing the kind of context being returned, or otherwise alter the API so native modules can access the V8 API instead.
@javache I'll gladly move the notification to RCTJSCExecutor.h, if you prefer :+1:

Could you explain why you want to expose the JSC context directly. What are you doing against it that you cannot do with the normal bridge?

Yes, why do you "require" a custom object?

The problem here is that you expose an implementation detail of RN (that we use JSC) to native modules. If you'd explain what you actually need the context for we might be able to build an abstraction for this.

@vjeux @sahrens @lexs
Realm objects and collections are live representations of data in the Realm database. Using the JavaScriptCore APIs allows for us to expose these live objects in JavaScript where every object property access, and every index/length access on collections, consults the underlying database. All of this must be synchronous and must be done lazily. For instance, queries are lazily constructed, meaning I can query a database of million objects and immediately get back a Results object which I can then further filter or instead access any object in that collection by its index.
I wouldn't go so far to say that the JS engine is an implementation detail. It's certainly not an API most native modules should have to deal with, but for Realm to feasibly be exposed into JS, it's necessary we have direct access to the JS engine APIs. If, for instance, React Native switched to V8 on Android, that would not be a major issue for us as long as we continued to have access to the V8 context so we could instead use the V8 version of our JS bindings.
I hope that helps to explain why we need this. :smile:

I think that the best way forward here is to get in a meeting together with people involved and figure out what the next steps are, especially given the time constraint.

Basic question:

Using the JavaScriptCore APIs allows for us to expose these live objects in JavaScript where every object property access, and every index/length access on collections, consults the underlying database. All of this must be synchronous and must be done lazily.

Imagine I read a few properties on the main JS thread - this is doing I/O on that thread, potentially blocking for a long time. Is that a good idea? Why not provide async APIs like in the case of AsyncStorage for example?
In the Java documentation you show how to access properties on a background thread: https://realm.io/docs/java/latest

Realm objects and collections are live representations of data in the Realm database. Using the JavaScriptCore APIs allows for us to expose these live objects in JavaScript where every object property access, and every index/length access on collections, consults the underlying database. All of this must be synchronous and must be done lazily.

This means that a property read or write won't do I/O on the main JS thread but will update the in-memory db. The transaction has to be explicitly committed, correct?

This means that a property read or write won't do I/O on the main JS thread but will update the in-memory db. The transaction has to be explicitly committed, correct?

Since the database is a memory mapped file, I/O is handled at the kernel level (e.g. page faults). Realm is designed to perform very well on the "main" thread (in this case the JS thread) for most use cases, but some methods will optionally be asynchronous, such as for performing expensive queries. It is indeed transactional – all writes must be made inside a write transaction.

To be clear, the one thing you want to accomplish is install native, synchronous hooks to the VM, correct? I think we're going to come up with a better way to do this down the road, probably when we finish the rewrite of the Android bridge in C++. In the meantime, we will ship this, but be aware that it will be deprecated in the next 6 months-year. As such, I want to make sure these functions are properly documented making sure people understand this is a temporary escape hatch until we have a proper API.

Comments added, @astreet, @nicklockwood is this good to go? Once it's good just shipit :)

hold onto your butts
@facebook-github-bot shipit
(I actually have a feeling this is going to end in an anti-climactic import failure :P)

I guess the github bot can't handle irrelevant chatter

@facebook-github-bot shipit

@astreet the bot is currently broken unfortunately, see our internal post. @bestander and @mkonicek are looking into it

@facebook-github-bot shipit

should be fixed now

@vjeux @astreet @mkonicek @nicklockwood would you mind updating us on the status of this merge?

CPP error
react-native-github/ReactAndroid/src/main/jni/react/Bridge.cpp:61:10: error: 'm_jsExecutor' was not declared in this scope
   return m_jsExecutor->getJavaScriptContext();

@bestander sounds like an issue after merging with master because m_jsExecutor was renamed to m_mainExecutor. Shall I rebase this branch onto master, or can you fix that on your end?

I tried to fix this on the imported diff. It should land now. I'll check on
in a few minutes.
On Mon, 15 Feb 2016 18:34 Scott Kyle<EMAIL_ADDRESS>wrote:

@bestander https://github.com/bestander sounds like an issue after
merging with master because m_jsExecutor was renamed to m_mainExecutor.
Shall I rebase this branch onto master, or can you fix that on your end?
—
Reply to this email directly or view it on GitHub
https://github.com/facebook/react-native/pull/5540#issuecomment-184339118
.

This PR also broke an internal class that extended NativeModule, I've fixed that and will monitor. I'll try to make sure this lands tonight.

It landed with e5ba46c30d5db1e660911ea2aee0daead89cf181.

Thanks @lexs!


How to fuse adapter_model.bin file with base model?

After instruction tuning, I get a adapter_config.json and adapter_model.bin, how to fuse them with the base model please?

After instruction tuning, I get a adapter_config.json and adapter_model.bin, how to fuse them with the base model please?

You can refer to here or here to solve the problem.


add version alias

I think this is all that is required to fix
https://github.com/Metaxal/quickscript-extra/issues/23

Probably needs these imports:
(require version-case
         mischief/shorthand) ; for define-alias

Probably needs these imports:
(require version-case
         mischief/shorthand) ; for define-alias

Thank you

Thanks for the patch @spdegabrielle
Unfortunately I cannot make the small package search-list-box depend on the large and varied mischief (it also has failures on the pkg server). It doesn't even have a license as far as I can tell. Any other way around this issue?

In the end I simply reverted to merely define-simple-macro with  11103aa , which should fix this. I'm closing this issue

The main interface that does this seems to be make-rename-transformer. For instance, another implementation of define-alias in the adjutor library is just a thin wrapper around it. So you could alternatively use that / write the implementation in a local utils file if you prefer.
But of course define-simple-macro works as well!


Documentation Update once @arx-research/halocli is published

https://github.com/arx-research/libhalo/blob/07dced5f7c4089c9032dab38a3e9669fcde410a0/docs/desktop-gateway.md?plain=1#L16
This no longer works as of 1.5.0 due to CLI functions moving to @arx-research/halocli, however, this package still needs to be published.

Thanks for spotting, related with ##351


Fix coverity alert on use of uninitialised data (take 2)

The function ossl_blake2b_param_init should initialise only, and not read the data it is initialising
This is an alternative fix to #22103.

This pull request is ready to merge

Merged to the master branch. Thank you.


Master

I hope somebody somewhere appreciates all this work to cater for trans-spliced transcripts... This change is required because CDS features within a trans-spliced transcript can have different strands (or different seq region names, although that's not the case with fruit fly). The CDS ID is ordinarily the translation stable ID, which implies that all the CDS rows are a single feature; which cannot therefore have multiple strands...

what happens to the value field if it is not a trans_spliced transcript?
if I read this correctly, CDS objects will never reach the last else, and value will not get the so_term concatenation

Ah yes, you're quite right. I'll fix that...

looks fine now


Blog post on welcoming Lionel to RCODI

@jasminebui1225
Adding information for the RCODI 'Our People' page:
Expertise:

Machine Learning
Deep Learning
Generative Adversarial Networks
Computer Vision
Data Engineering
Data Science

Links

GitHub: https://github.com/twinblade02
Portfolio: https://twinblade02.github.io/LDPortfolio.github.io/
https://www.linkedin.com/in/dsilva-lionel/
<EMAIL_ADDRESS><EMAIL_ADDRESS>Instagram: @sierrafoxtrot10

Bio
I'm a Data Scientist, and former Airport Ops specialist; and my areas of interest are Computer Vision, Sensor Fusion, Generative Algorithms, and Cloud and Distributed Systems. I will starting my PhD at Purdue in the Fall of 2023, and am very active on LinkedIn and Instagram.
I also build track/street cars!


[7.x] throws docblocks cleanup.

This PR removes throws docblock when the exception is not thrown directly within the method.
It also adds missing throws docblocks.

Some of these are intentionally set there to note the cascading. So I don't think we should remove all of them.

To which level does this cascading apply?
Because even with exception bubbling on one extra level, it would mean that many throws docblocks are missing

There's no fixed rule.

I think those methods are the public API of the framework. Therefore, the cascading should be applied to the very last level.
Still, it's important to document what can realistically get thrown, where is an example:
public function frameworkMethod()
{
    return new \ReflectionClass(Illuminate\Database\Eloquent\Model::class);
}

The code above theoretically can throw a ReflectionException, but realistically that will never happen, so we shouldn't document it on phpdocs.


Versioning system

Would it be pertinent to add a versioning system to META Network specs? Primarily, this would facilitate future changes to specs and backwards-compatibility for earlier implementations.
For example:
metaIdentity: {
  aux: {},
  core: {},
  version: META.Identity.v0
}

Sounds good to me :+1:

Sounds sensible yeah.


ci(workflow): Check out full repository history

In the Test workflow, the pre-commit-action now runs the Commitizen action, which relies on Git tags. The official GitHub checkout action does a sparse checkout by default, which does not include tags, causing version bumps to fail.

Please let me know whether this pull request makes more sense after reviewing ScribeMD/pre-commit-action#32. If it does and you have any suggestions on what would have made this commit message clearer, that would be super helpful.

It does indeed help!


"flow-root" support

How about to support flow-root?

If this is safe why not. Can you provide link to specification and approve that is perfectly safe transformation?

The spec says that flow-root is like display: block, but creates new BFC. For now, there is no way to create new BFC without some side effects (like column-count and overflow fallbacks do). And clearfix fallback doesn't even create new BFC. So there is no perfectly safe transformation for flow-root (more on this). And some issues in current implementation (1, 2) make this transform even more unsafe.
But if issues in this plugin will be resolved than column-count may be relatively safe transform (it has minimum side effects). Or may be not. I'm not really sure. Also column-count's browser support may be not enough.

column-count may be relatively safe transform (it has minimum side effects)

In my experience this is not a safe fallback. See:

https://bugs.chromium.org/p/chromium/issues/detail?id=780733
http://jsbin.com/bexewig/4

postcss-cssnext has been deprecated in favor or postcss-preset-env. Read more at https://moox.io/blog/deprecating-cssnext/


It shows stretched/warped image especially when turning the phone diagonally.

I show some examples in this thread:
https://stackoverflow.com/questions/48004018/three-ar-js-bad-aspect-ratio-creating-stretched-image/48053103#48053103
And i use a Samsung Galaxy s8
And i am using an older commit that was suggested in this issue thread: https://github.com/google-ar/WebARonARCore/issues/44 which is the commit: https://github.com/google-ar/WebARonARCore/commit/22b75c18d4aeb4232e47556cc27f067f4115c75b

Maybe i can just wait for the DP2 version to arrive and leave this for now? No one else seems to be experiencing this problem?


[Improvement][Seatunnel-web][Hive-JDBC] Add Hive-JDBC into seatunnel-web

Search before asking

[X] I had searched in the feature and found no similar feature requirement.

Description
Add Hive Hive-JDBC into seatunnel-web.
Currently there some code available for hive jdbc but hive jdbc datasource is not listing also the functionality need to be verified
Usage Scenario
Hive JDBC
Related issues
No response
Are you willing to submit a PR?

[X] Yes I am willing to submit a PR!

Code of Conduct

[X] I agree to follow this project's Code of Conduct

Raised PR https://github.com/apache/seatunnel-web/pull/218

PR is merged
https://github.com/apache/seatunnel-web/commit/d110b97eddf8d93bc60704b328e97179824ee5a7


CRM Agreement Number for Participants

DB Migration to add new column
Updates to schema to allow the new field to be fetched and updated
New text field in Add Participant dialog to set the agreement number.
Display agreement number in approved participants table
Apply some sonarlint quick fixes

https://github.com/IABTechLab/uid2-self-serve-portal/assets/137864392/71378bfa-0aa0-4afb-9d74-892baf6cc6c1

Wrong branch name


Can't download hex file to stc chip with stcispV6.8

I compile a small example and compile with sdcc.
#include<8052.h>
#define D4 P1_3
unsigned int a;
void main()
{
	while(1)
	{
		a = 51000;
		D4 = 0;
		while(a--);
		a = 51000;
		D4 = 1;
		while(a--);
   }
}

But after generating hex file with
packihx test.ihx>test.hex

the hex file is
:03000000020006F5
:03005F0002000399
:0300030002006296
:100062007508387509C7C293AE08AF09150874FF41
:10007200B508021509EE4F70EF7508387509C7D239
:1000820093AE08AF09150874FFB508021509EE4FC3
:0400920060CE80EDCF
:06003500E478FFF6D8FD9F
:100013007900E94400601B7A0090009A780175A08A
:1000230000E493F2A308B8000205A0D9F4DAF2754C
:02003300A0FF2C
:10003B007800E84400600A790175A000E4F309D860
:10004B00FC7800E84400600C7900900001E4F0A318
:04005B00D8FCD9FAFA
:0D000600758109120096E582600302000377
:04009600758200224D
:00000001FF

but I can't open it with STC-ISP V6.8.
And the hex file is defferent from which I generate with Keil.
Do you know why?

get it.

Congratulations!

Congratulations!
大家都是中國人，可以直接用回復比較方便哈。

Congratulations!
<EMAIL_ADDRESS>


Added a new script for generating notes

Added a new script that reads in the base format along with a substitution values given in a JSON format. Check out the example files.
The base format has the place holder given in this format: $placeholder and the placeholder variable is a key in the json dictionary with a list of values. This way we can just read the base format file entirely into a string from which we can create a template.

Merged.


Compilation completed successfully with 8 warnings!!

just a few warning i found!! dont know if this is bad or not
http://puu.sh/jEApr.png

These are just warnings, not errors. You can ignore them.
JTattoo still works fine, even if it uses some old Java API code.
But thank you for your report.


A dead link in INSTALL

Hi all,
A quote from INSTALL file:

Alternately, you can use a more recent libunwind (e.g. 1.0.1) at the
cost of adding a bit of boilerplate to your code.  For details, see
http://groups.google.com/group/google-perftools/msg/2686d9f24ac4365f

However, following the link results in error 500 and google-perftools appears to be banned from google groups.
I suppose the link used to contain a solution for libunwind deadlock problem I'm facing now, so would it be possible to replace the link with an actual description of the code changes?
Thanks!
Andriy

On Fri, Feb 19, 2016 at 8:44 AM, AndriyS73<EMAIL_ADDRESS>wrote:

Hi all,
A quote from INSTALL file:
Alternately, you can use a more recent libunwind (e.g. 1.0.1) at the
cost of adding a bit of boilerplate to your code. For details, see
http://groups.google.com/group/google-perftools/msg/2686d9f24ac4365f
However, following the link results in error 500 and google-perftools
appears to be banned from google groups.
I suppose the link used to contain a solution for libunwind deadlock
problem I'm facing now, so would it be possible to replace the link with an
actual description of the code changes?
Thanks!
Andriy

Thanks for reporting the issue, Andriy.
Regarding your issue I'm very curious about details. INSTALL file merely
suggests installing later version of libunwind, but it will not necessarily
be enough.
I think it'll be best if you open fresh ticket and post as much details as
you can. Particularly:
a) backtraces of all threads in your stuck application. I'll need to know
what is deadlocked
b) post exact version of libunwind and distro that you run on
b) post exact version of gpeftools that you're using

—
Reply to this email directly or view it on GitHub
https://github.com/gperftools/gperftools/issues/770.

Hi,
So far, I didn't yet obtain the backtraces. I can only provide the distro versions at the time being.

gcc version 4.4.7 20120313 (Red Hat 4.4.7-16) (GCC)
libunwind-1.1 (configured with default options)
gperftools-2.4 (configure --enable-libunwind)

Thank you,
Andriy

I am still hoping to get that link working again.

I dropped link from install file. As for getting us archive access to gperftools, sadly it is not happening at all.
Some of gperftools ml archive can be retrieved from web archive (many thanks!). Latest version I see is here: https://web.archive.org/web/20120328080439/http://groups.google.com/group/google-perftools/topics


WindowDialog Ignores position set with Inspector

Godot Master
This works
extends Control

func _ready():
	$WindowDialog.set_position(Vector2(100,100))
	$WindowDialog.popup()

But this resets the position
extends Control

func _ready():
	$WindowDialog.popup()

Duplicate #18940


Add support for pretty-printing PHP files in wp i18n make-php command

It should resolve this issue: https://github.com/wp-cli/i18n-command/issues/395

@sovetski FYI: You can run Behat test locally easily using commands like:
WP_CLI_TEST_DBTYPE=sqlite composer behat features/makephp.feature:263

This will run behat test of given file and 263 is the line number of your new Scenario. This will be helpful for quick test in local environment. With using sqlite, you don't have to face hassle to setup MySQL.

@sovetski FYI: You can run Behat test locally easily using commands like:
WP_CLI_TEST_DBTYPE=sqlite composer behat features/makephp.feature:263

This will run behat test of given file and 263 is the line number of your new Scenario. This will be helpful for quick test in local environment. With using sqlite, you don't have to face hassle for MySQL setup.

Thank you, it helped a lot, now the test pass successfully

I don't understand. The command WP_CLI_TEST_DBTYPE=sqlite composer behat features/makephp.feature:263 was working as well, I just removed 1 space and adapted my scenario, I have this error without any explanation:

When I add -vvv it returns an unreadable PHP exception. But the returned error output matches the scenario's expected output, so very weird...

When I add -vvv it returns an unreadable PHP exception. But the returned error output matches the scenario's expected output, so very weird...

It sounds like it doesn't match exactly.
When I manually run the wp i18n command in my terminal, I get this output with lots of indentation (8 spaces):
<?php
return [
        'domain' => 'foo-plugin',
        'plural-forms' => 'nplurals=2; plural=(n != 1);',
        'language' => 'de_DE',
        'project-id-version' => 'Foo Plugin',
        'pot-creation-date' => '2018-05-02T22:06:24+00:00',
        'po-revision-date' => '2018-05-02T22:06:24+00:00',
        'messages' => [
                'Foo Plugin' => 'Foo Plugin',
                'Hello' => 'Hallo',
                'You have %d new message' => 'Du hast %d neue Nachricht' . "\0" . 'Du hast %d neue Nachrichten',
        ],
];


chore: project addition by SyedImtiyaz-1

Add a new project to the list
Hello @priyankarpal ,
I'm adding a new project of python which is Telegram Bot.
It's automate the function as a Bot using Python.
Will mention the details of the requirement in the README.md
Record

[X] I have checked the existing issues
[X] I have read the Contributing Guidelines
[X] I agree to follow this project's Code of Conduct
[X] I want to work on this issue

/assign


Winston does not play well with undefined callbacks.

Howdy! Thank you for your contribution. This PR is against the<EMAIL_ADDRESS>release line. Since<EMAIL_ADDRESS>is now out we are only accepting major bug fixes. Since this is breaking the tests I will close it. winston@3 no longer accepts a callback to the log method.


Pipeline steps are not reset when changing roots

I'm using roots to separate the login/register parts from the rest.  The login root doesn't need the auth step used in the main root.
Pipeline steps added in configureRouter are not removed when switching roots with setRoot.  Any steps added will remain and will be added again when switching back.

skeleton repro
gist.run

Something like this would fix it, but I'm not sure if it's the best way.

Pipeline steps are not managed by the router, but by a separate pipeline provider service. I would recommend that you just reference that and remove the steps you don't want as needed.

Yeah, that's fine. I'm currently using the modified fork linked in the top post.
The concern is that when switching back and forth the steps accumulate so there are multiples of the same step in the pipeline being applied when routes change.
Updated the gist.run to illustrate. Click the switch button a few times and the steps will add up. Then click the link and in the console there will be output for each duplicate step in the pipelineSlot.
This could be worked around by setting a var indicating the steps have been added, but that seems hackish.
If resetting the pipelineSlot steps isn't desirable then a check for existing steps might be needed before adding a step. If steps need to be manually removed then it might be helpful to have removeStep/clearSteps  methods.
check existing / removing
The best place to remove steps might be the root deactivate method, but that doesn't get called when switching. Perhaps adding something in the setRoot method around https://github.com/aurelia/framework/blob/master/src/aurelia.js#L118 to call the viewModel deactivate if it exists?

Perhaps we can just have a reset method on the provider to set it back to the default configuration?

That's what I'm doing now. Either way is fine, just rambling ideas. As long as there's a way to clear out unneeded/duplicate steps. Duplicates could be prevented with a simple check though.

Sounds like a nice PR opportunity. Any interest in submitting an improvement to the pipeline provider?

Sure.  Are you looking for a single method to reset everything to as it is right after construction? Or, something to reset a specific slot like https://github.com/z-brooks/router/blob/pipeline/src/pipeline-provider.js#L90?


Revert "Revert "Merge pull request #3269 from AleoHQ/feat/testnetv1""

Re-introduces https://github.com/AleoNet/snarkOS/pull/3269
Previously https://github.com/AleoNet/snarkOS/pull/3272 reverted a number of PRs to ensure they can be tested properly. The time has come to test the PRs, so we're doing a partial revert revert.
With https://github.com/AleoNet/snarkOS/pull/3269 back in place they can all be tested on Canary.
After the sister PR https://github.com/AleoNet/snarkVM/pull/2468 is merged, we should update the ref again.

Closing in favour of: https://github.com/AleoNet/snarkOS/pull/3281


Reader assumes that files in same fragment have same batch size

I don't think we enforce a certain batch size for all the files in a fragment, but our reader currently expects it.

It does seem like our existing write APIs are guaranteed to preserve this, so not an urgent issue to fix.


cannot upload from Cyberduck using azure blob API (append blob)

Environment info

Version: 2.6
Deployment: AZURE | AWS | GCLOUD | ESX | VBOX | DEV
Customer: NAME

Actual behavior

Cyberduck is using append blobs for uploads which we don't support yet.
currently we are not supporting append blocks, so all uploads from Cyberduck fails

Expected behavior

in order to support Cyberduck we need to implement append blob operations.
append blob is a specific case of block blobs, and we can support it using the functionality added for put block\blockList (https://docs.microsoft.com/en-us/rest/api/storageservices/understanding-block-blobs--append-blobs--and-page-blobs#about-append-blobs)

Steps to reproduce

upload from Cyberduck using blob API

Screenshots or Logs or other output that would be helpful

Blob API no longer supported


feat: create lib to handle file upload for Fastify-based apps

To solve this issue some solutions already exist:

@nest-lab/fastify-multer developed by one of the NestJS core team members
nest-file-fastify

@nest-lab/fastify-multer depends on fastify-multer, which is abandoned and not maintained anymore ❌
nest-file-fastify depends on fastify-multipart, and the Fastify team maintains it. But nest-file-fastify is outdated and unmaintened. ❌
This lib will fork nest-file-fastify and update the fastify-multipart dependency to the latest version.

👍


Can you please update the SAML SSO documentation with the new UI format of the Atlassian organizations?

Hello MS Team!
My name is Hector Menchaca from the Atlassian Cloud support team - Atlassian released the Multiple Identity Providers feature on August 3rd, 2022 - https://community.atlassian.com/t5/Enterprise-articles/Multiple-identity-provider-support-now-available-in-Cloud/ba-p/2093719 - and still the MS documentation has not been updated with the new UI options :(
Can you please help us to update it as per the new way to connect Azure AD and Atlassian?
Best Regards,
Thanks!

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: eb39c8bf-2709-c59d-94f8-6db76d21bcfb
Version Independent ID: f7122c2c-ef68-95b6-2273-edbc4bb89464
Content: Tutorial: Azure Active Directory integration with Atlassian Cloud - Microsoft Entra
Content Source: articles/active-directory/saas-apps/atlassian-cloud-tutorial.md
Service: active-directory
Sub-service: saas-app-tutorial
GitHub Login: @jeevansd
Microsoft Alias: jeedes

@hmenchaca
Thanks for your feedback! We will investigate and update as appropriate.

@hmenchaca
Thanks for bringing this to our attention.
I'm going to assign this to the document author so they can take a look at it accordingly
@jeevansd
Can you please check and add your comments on this doc update request as applicable.

Hello Team! I hope you are having a great day! - is there an update on this? Best Regards, Thanks!

Hello MS team! - is there any update on this?? thanks a lot!

@hmenchaca, we're working on it, will update you once published.
#please-close


Squeeze tensor while logging

What does this PR do?

Fixes #14446
Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

[x] Was this discussed/approved via a GitHub issue? (not for typos and docs)
[x] Did you read the contributor guideline, Pull Request section?
[x] Did you make sure your PR does only one thing, instead of bundling different changes together?
[ ] Did you make sure to update the documentation with your changes? (if necessary)
[ ] Did you write any new necessary tests? (not for typos and docs)
[x] Did you verify new and existing tests pass locally with your changes?
[ ] Did you list all the breaking changes introduced by this pull request?
[x] Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

[x] Is this pull request ready for review? (if not, please submit in draft mode)
[x] Check that all items from Before submitting are resolved
[x] Make sure the title is self-explanatory and the description concisely explains the PR
[x] Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?
Make sure you had fun coding 🙃
cc @borda @carmocca @edward-io @ananthsub @rohitgr7 @kamil-kaczmarek @Raalsky @Blaizzy @akihironitta

Does this remain resolved in the most recent release? I get a similarly looking error as https://github.com/Lightning-AI/lightning/issues/14446


Sometimes thread is generate too much...

Hi there.
I using rufus-scheduler + unicorn
Sometimes thread is generate too much....
I don't understand this problem.
see my below screenshot!

..after die ... XD

in Work.scheduling

the scheduler executing every 2 minute, thread explosively increase and die.
but my work doesn't need these too many threads.
I don't know why increase threads like this.
Thanks for your time :D

Hello,
your second screenshot says:
if scheduler.work_threads.size > (scheduler.max_work_threads.to_i - 50)
  scheduler.max_work_threads += 30
end

You are increasing the max threads by yourself... You are inviting the explosion on yourself.
Why do need to wrap a Rufus::Scheduler.singleton.at within the Rufus::Scheduler.singleton.every? Why don't you simply call
begin
  work.child_job.child_jobs
rescue => e
  p e
end

?
I really don't know what else Work.scheduling does, but you should write simpler, more straightforward code.

The main cause is idle threads.
the threads hasn't disappeared when they're job finished.
It bring bottleneck and soon my work server died.
so i tried to add the code that kill idle threads in every 2 minute.

resolved!
The main cause is idle threads.
the threads hasn't disappeared when they're job finished.
It bring bottleneck and soon my work server died.
so i tried to add the code that kill idle threads in every 2 minute.
scheduler =  Rufus::Scheduler.singleton(:max_work_threads => 100, :lockfile => ".rufus-scheduler.lock")
scheduler.work_threads(:vacant).each do |x|
    Thread.kill x
end

Hello,
well done.
The normal scenario would be to leave the work_threads pegged at 100 or some other positive integers and leave it like that, not adding 30 to the max whenever the max was nearing...
I think that simply removing your auto +30 should have fixed the issue in the first place.
Best regards.


Remove known issue for ticket 93998.

Ticket 93998 is working as expected in Mendix 8.6.6. The bug was likely to be introduced in 8.7.0 but it was fixed in the later version.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


AROMA

Hello,
I apologize if there is documentation on this. I could not find it but I very well may have missed it. On the xcp readthedocs site, it says that the aroma streams do not strictly follow the original implementation of aroma from the Pruim paper. From what I can tell, this is because the components are derived from smoothed data but they are removed from the unsmoothed data. Is that correct and if so, is that the only difference between the xcp implementation and the original implementation? Also, would you mind sharing how you decided to implement aroma in this way? Just asking out of curiosity.
Thanks!

Hi @shanaahall , xcp doesn't run aroma. What xcp does is only regression of selected regressors from fmriprep regressors.
The fmriprep aroma is simply base on fsl-melodic  as implemented in python : https://github.com/maartenmennes/ICA-AROMA

check https://fmriprep.readthedocs.io/en/stable/workflows.html?highlight=aroma#ica-aroma for more details


Center dropdown icons in Grade Dist

Description

Adjust styling in scss file

Screenshots
Before:

After:

Steps to verify/test this change:

[ ] Verify changes work as expected on staging instance

Final Checks:

[ ] Verify successful deployment
[ ] Delete branch

(optional)

[ ] Write tests
[ ] Write documentation

Closes #340

Sorry, but this actually has a pending fix already in #323
It was some erroneous styling being applied globally in a scss file that affected all icons.


Info guide text

Portuguese version #8: string was appearing in English in the Portuguese version transifex string #220 Jim: This is/was correct in transifex so appears to be an import error.

@JimChiazzese1 It is unclear to me what this means. Is there a problem with the guide?

The issue is on the information page - point 8 shows in English rather than Portuguese.
Identifique os visitantes florais em seus grupos mais amplos (abelhas, moscas, etc.) - qualquer um que você não reconheça deve ser contado como "outros insetos" ou "não sei".

Still an issue with this in Portuguese

FitCount_Brazil_ImageCredits.docx
@kazlauskis

Do you mean these two paragraphs being in English? This is because there is a missing translation for this in Portuguese.

@kazlauskis Apologies Karolis, that's a little embarrassing, makes perfect sense.
The Brazil team have completed the final translations, so should be able to reimport it all now
Jim

No problem, this is done now.


Disable appending of Using

How can i disable the appending of my methods with
Using<Method>

.  All methods in my swagger doc have getPartnersUsingGet or similar.  I want to get rid of that.

http://springfox.github.io/springfox/docs/current/#docket-spring-java-configuration
5.5.2. Configuring the output of operationId in a Swagger 2.0 spec

@rkaltreider There is not a way to get rid of that ... yet. I'll see how we can address that in 2.3 if possible. However keep in mind that you will end up with names like someOperation_1, someOperation_2 etc. if there are multiple endpoints with the same nickname
@gionn I'll fix the documentation to reflect that.

That sounds perfectly reasonable to me. I have taken the time to ensure all nicknames are unique and self descriptive. If I fail to solidify the uniqueness. I would expect it to make it unique however it sees fit. Thank you!
Sent from my iPhone
On Dec 1, 2015, at 10:26 AM, Dilip Krishnan <notifications<EMAIL_ADDRESS>wrote:
@rkaltreiderhttps://github.com/rkaltreider There is not a way to get rid of that ... yet. I'll see how we can address that in 2.3 if possible. However keep in mind that you will end up with names like someOperation_1, someOperation_2 etc. if there are multiple endpoints with the same nickname
@gionnhttps://github.com/gionn I'll fix the documentation to reflect that.

Reply to this email directly or view it on GitHubhttps://github.com/springfox/springfox/issues/1066#issuecomment-161000947.

Thanks @dilipkrish for the fix which I assume also fixes - #880 #990

:+1:

When do you think the next version will be released? I am anxious to upgrade!
Sent from my iPhone
On Dec 8, 2015, at 4:39 PM, Dilip Krishnan <notifications<EMAIL_ADDRESS>wrote:
[:+1:]

Reply to this email directly or view it on GitHubhttps://github.com/springfox/springfox/issues/1066#issuecomment-163025790.

Its already released see here for details 2.3.0

Apologies for resuscitating this old discussion. Is the solution to this the use of @ApiOperation to specify a differnt nickname on every operation or is there a way to disable this behavior completely? Thanks

Thank you sir!


Make printing stack trace optional and configurable

** Please describe what you would like the feature to accomplish.**
I'm updating the Quantum Katas to QDK version 0.10.2002.2610, and it looks like the cell output in case of an error became a lot bulkier. As of PR https://github.com/microsoft/qsharp-runtime/pull/79/, they include a mandatory Q# stack trace, which (for the use case of the Katas) doesn't really help the user figure out their issue, and might scare them away instead (this was the feedback we got when we had long stack trace in new Python tutorials).

I considered turning off the test output, but that won't work, since the katas rely on the output of Message and DumpMachine for conveying useful information about the test outcomes (such as the first line of task 1.1) and for allowing the user to debug their solution.
Ideally we would have an option to turn off the extra stack tracing, and then use that option in the TestTarget method of TestSuiteRunner in the katas.

I think #162 takes care of this, right @tcNickolas?

I'm not sure about #162, #157 looks more relevant to it?

@tcNickolas Could you confirm whether that is still relevant? If so, I'll assign it to an iteration shortly.

This specific behavior in the Kata notebooks was fixed, yes. I'm not sure how configurable stack trace printing is now.

@tcNickolas : SimulatorBase has public methods EnableExceptionPrinting() and DisableExceptionPrinting() which control printout in case of exception. Disabling exception printing will disable all exeption printing including words 'Unhandled exception.' and the message, I assume you want the message, but don't want stack trace. I can make printing of stack trace configurable.

@tcNickolas : SimulatorBase has public methods EnableExceptionPrinting() and DisableExceptionPrinting() which control printout in case of exception. Disabling exception printing will disable all exeption printing including words 'Unhandled exception.' and the message, I assume you want the message, but don't want stack trace. I can make printing of stack trace configurable.

To provide a bit of background from the offline discussion: currently the Q# Jupyter notebooks do not print the exception stack trace, so I'm happy with their behavior.
However, the stack trace is still present in the katas when they are executed as Q# standalone projects; here is what the overall test output looks like:

I'm trying to see how the output looks like when the tests are executed using dotnet test, as this is the way the katas are used from VS Code, but dotnet test doesn't work for me for some reason...

To provide a bit of background from the offline discussion: currently the Q# Jupyter notebooks do not print the exception stack trace, so I'm happy with their behavior.
However, the stack trace is still present in the katas when they are executed as Q# standalone projects; here is what the overall test output looks like:

I'm trying to see how the output looks like when the tests are executed using dotnet test, as this is the way the katas are used from VS Code, but dotnet test doesn't work for me for some reason...

Following an offline discussion, at this stage the error message is probably more confusing than the stack trace (in notebooks the stack trace came first so it was worse than in the VS environment). The problem is, some of the asserts that the Katas use don't allow to provide a custom message and print only the default message. Let me close this issue (since we agreed that we're not going to manipulate the stack trace) and open another one about error messages for asserts.

@tcNickolas: That feature request is already being tracked at https://github.com/microsoft/QuantumLibraries/issues/219, if you'd be willing to chime in there. Thanks!

One possible solution for projects:
https://github.com/microsoft/QuantumKatas/pull/596


enable typed func

resolve #9

Coverage decreased (-3.4%) to 96.633% when pulling 4194b4e4141f09d1b96ee9ebde43edb43a6e0545 on feature/typed_func into eeef85901c0dd7c074de79b3b4bd973e4e181c6f on master.

Coverage decreased (-4.9%) to 95.082% when pulling 820e154d1a994d17049c1fe132f7572b484352c0 on feature/typed_func into eeef85901c0dd7c074de79b3b4bd973e4e181c6f on master.

Coverage decreased (-6.4%) to 93.631% when pulling b0ab27515d1898c5d22a86ac1e44fbf891b9802d on feature/typed_func into eeef85901c0dd7c074de79b3b4bd973e4e181c6f on master.

Coverage decreased (-7.7%) to 92.26% when pulling c9d9877451f41f5959d6a5135f86c1b0bd3b9a82 on feature/typed_func into eeef85901c0dd7c074de79b3b4bd973e4e181c6f on master.

Coverage decreased (-9.1%) to 90.881% when pulling 3eebb31cb9e4dc3a7d27343bc3931e21b9ce5fba on feature/typed_func into eeef85901c0dd7c074de79b3b4bd973e4e181c6f on master.

Coverage decreased (-10.4%) to 89.645% when pulling 3bd770842191178e22efc0120d17614f81447916 on feature/typed_func into eeef85901c0dd7c074de79b3b4bd973e4e181c6f on master.

Coverage decreased (-11.6%) to 88.439% when pulling ab85f15febe4b1d2bb324adcefc1b911dd1e4f0b on feature/typed_func into eeef85901c0dd7c074de79b3b4bd973e4e181c6f on master.

Coverage decreased (-4.3%) to 95.665% when pulling f123178c582fca32d3b8d5493a16ed80c5ebd1b4 on feature/typed_func into eeef85901c0dd7c074de79b3b4bd973e4e181c6f on master.

Coverage decreased (-1.4%) to 98.555% when pulling e75ea663ae4b31c806f9d6b9303c83c170564bfe on feature/typed_func into eeef85901c0dd7c074de79b3b4bd973e4e181c6f on master.

Coverage remained the same at 100.0% when pulling 0c05fefe026481e81cbbeaf3c8825e894b6f4418 on feature/typed_func into eeef85901c0dd7c074de79b3b4bd973e4e181c6f on master.


Init

All the setup necessary for a running applications with minimal features

:tada: This PR is included in version 1.0.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Redirect for donate page on redesign go-live

A link to the current donate page is distributed via QR code so when the redesign website goes live put in place a redirect to the equivalent path in the new website.

I've done this using a plugin, so no link to a commit of course. However, I've asked the FoBV to check it in order to make sure that the URL that I think they must have distributed via their QR code is the one that they have actually distributed. So, holding this issue open until I get confirmation.

Confirmation received from the FoBV that the redirect is fine, so closing this now.


3.14.65

will this work for the current 3.14.65 (and future 3.14.*) c2 kernel release(s)?

What it does is simply download the PKGBUILD files for the current kernel and apply a tiny patch. In case the kernel version in the repository is not up-to-date just call update_linux.sh and change the spl and zfs PKGBUILD files as stated in the README.


enable NLU custom pipeline

related #171
this change is about enabling custom NLU pipeline.

@JoshuaZe Thanks for the PR 👍


Gradient for tf.sparse.reduce_max

Please make sure that this is a feature request. As per our GitHub Policy, we only address code/doc bugs, performance issues, feature requests and build/installation issues on GitHub. tag:feature_template
Describe the feature and the current behavior/state.
tf.sparse.reduce_max do not define grad. So it cannot be used in training step.
Will this change the current api? How?
Won't change current api. Just add grad in tf.sparse.reduce_max
Who will benefit with this feature?
People using sparse.reduce_max in training. If they have huge sparse matrix and cannot turn to dense array.
Any Other info.
I am working with pointnet-like model. And it will take a huge sparse matrix. If I turn this sparse matrix to dense, it will take ~60G memory. So I need do global maxpooling. Using tf sparse reduce_max. Unfortunately, it cannot be used in training right now.
Thanks

@AmadeusloveIris
Can you please elaborate about your feature and please specify the Use Cases for this feature. Thanks!


Wizard prompts lost focus when clicking away

Turns out it is not the wizard, it's the node picker. Not a regression.


Add Avatar Component

Add Avatar Component
- avatar html and css files.

Continuing from the following PR https://github.com/varun13169/delta-ui/pull/2

Continuing from the following PR #2
Resolved ,good to merge


adds retry mechanism for the installation of Maestro CLI

As I've experienced failures due to Connection reset a few times recently, I thought it might be worth adding a retry mechanism when trying to install the Maestro CLI
+ cd /bitrise/src
+ [[ -z '' ]]
+ echo 'Maestro CLI version not specified, using latest'
Maestro CLI version not specified, using latest
+ curl -Ls https://get.maestro.mobile.dev/
+ bash
* Create distribution directories...
* Downloading...
#=#=#
curl: (35) OpenSSL SSL_connect: Connection reset by peer in connection to objects.githubusercontent.com:443

I think we can do something like this instead
curl -Ls --retry 5 --retry-all-errors "https://get.maestro.mobile.dev" | bash
We have the same setup on our E2E tests @amanjeetsingh150


Dup work experiences and histories on choice

Context
To allow the user to edit the work experiences or histories we will duplicate  the experiences and histories on the application choice from the application form.
This will allow the user to edit the experiences or histories on the application_form and the edits will be applied to future application choices.
The current application_choices will have the old info
Changes proposed in this pull request
dup data in SubmitApplicationChoice service
Guidance to review
Submit an application choice and check if the work experiences and histories have been saved on the application choice. Locally or on Review
ApplicationChoice.last.work_experiences
ApplicationChoice.last.volunteering_experiences
ApplicationChoice.last.work_history_breaks

Things to check

[ ] If the code removes any existing feature flags, a data migration has also been added to delete the entry from the database
[ ] This code does not rely on migrations in the same Pull Request
[ ] If this code includes a migration adding or changing columns, it also backfills existing records for consistency
[ ] If this code adds a column to the DB, decide whether it needs to be in analytics yml file or analytics blocklist
[ ] API release notes have been updated if necessary
[ ] If it adds a significant user-facing change, is it documented in the CHANGELOG?
[ ] Required environment variables have been updated added to the Azure KeyVault
[x] Inform data insights team due to database changes
[x] Make sure all information from the Trello card is in here
[x] Rebased main
[x] Cleaned commit history
[x] Tested by running locally
[x] Add PR link to Trello card

 Edit work experiences - Change db structure to accommodate work experience edits


⚠ Processors has degraded performance

In 0b87e97, Processors ($STATUS_URL) experienced degraded performance:

HTTP code: 200
Response time: 76 ms

Resolved: Processors performance has improved in 1010376.


Some traces of cv2 remain

🐛 Bug
In 0.7.0 cv2 has been removed yet a couple of traces remain https://github.com/airctic/icevision/search?q=cv2
This may cause import errors

I think the albumentations part cannot be removed as it's that lib requires cv2

But we can remove albumentations from the minimal requirements and add it to all.
What we really need to change is the function open_img to use PIL instead of cv2

@lgvaz That should be straightforward? Do you know if cv2 converts to RGB? Or maybe open_img already takes an arg for input namespace?

That should be straightforward?
Yes (I'm actually going insane, because I swear I've done this before)... ACTUALLY, I'm going insane! Check here

I was checking vscode and it was opening an outdated file under /build, what

Okaaaay, much easier than, it seems these are the only traces left:

And since albumentations is a soft dependency, we can be sure that if the user tries to use it, opencv will be installed

Resolved.


Add support for VALARM option.

Add the possibility to add VALARM subcomponents to calendar entries.
The VALARM component must be constructed directly using the icalendar.Alarm class, this is just a minimal wrapper to be able to add it to events.
Closes #46

This should work in theory and I welcome any comments on the implementation as sub components where not supported prior to this.
I will add it to a project of mine and see if the calendar entries are working correctly.

Great stuff @malteger! Ping back once you've tested the valarms and the PR is ready for merging :)

Works as expected in two clients, so should be fine.
The only problem is that there is absolutely no documentation on the Alarm class inside of icalendar, the only example would be in the test I added...

I have added an example in the docs as it took me some time to figure the trigger settings out. I hope that this is not too much and out of scope for django-ical (might be better to include it in icalendars docs)
@aleksihakli Otherwise this works and is ready to be merged

Looks good @malteger! I think having the VALARM description in docs is nice. I'll merge this and bake a new release. Thank you for the contribution :)


(WIP) Optimize png rendering

This is a work-in-progress PR to avert performance impact of the latest tiled rendering patch.

I've implemented resizing the images during painting, here are the visual differences: http://imgur.com/a/0qTp1. In short, letters are crispier, but "jumpier".
As for performance, I've made up a simple benchmark script that employs benchmark_png function implemented in https://github.com/immerrr/splash/commit/7cd72feb802b1024fbcbe34dfd50d7a13caed2ed:
from splash.tests.stress import benchmark_png

for url in ["http://wikipedia.org",
            "http://google.com",
            "http://www.w3.org/TR/2010/REC-xhtml-basic-20101123/"]:
    for width in [None, 500, 2000]:
        try:
            print "url: ", url, "width: ", width, "result: ", benchmark_png(
                url=url, width=width)
        except Exception:
            import traceback
            print traceback.format_exc()

The results are as follows:
this-pr: ec149a5
after-fix: 7cd72fe
before-fix: 9adf4e4
| url                                             | width | this-pr | after-fix | before-fix |
|-------------------------------------------------+-------+---------+-----------+------------|
| http://wikipedia.org                            |  None |   0.128 |     0.127 |      0.113 |
| http://wikipedia.org                            |   500 |   0.090 |     0.163 |      0.127 |
| http://wikipedia.org                            |  2000 |   0.963 |     1.617 |      1.450 |
| http://google.com                               |  None |   0.030 |     0.030 |      0.030 |
| http://google.com                               |   500 |   0.020 |     0.033 |      0.030 |
| http://google.com                               |  2000 |   0.190 |     0.273 |      0.243 |
| http://w3.org                                   |  None |   0.213 |     0.213 |      0.193 |
| http://w3.org                                   |   500 |   0.163 |     0.240 |      0.193 |
| http://w3.org                                   |  2000 |   1.840 |     2.380 |      2.023 |
| http://w3.org/TR/2010/REC-xhtml-basic-20101123/ |  None |   3.490 |     3.477 |         xx |
| http://w3.org/TR/2010/REC-xhtml-basic-20101123/ |   500 |   0.763 |     2.340 |         xx |
| http://w3.org/TR/2010/REC-xhtml-basic-20101123/ |  2000 |   9.943 |    16.213 |         xx |

Looks good! New resizing provides a better image quality IMHO, and the speed boost looks great.
A few questions:

Is splash/benchmark.py still needed?
Could you please check the speed with width > TILE_MAXSIZE, e.g 2050px?
Could you please also check it on an images-heavy website like http://blog.pinterest.com/?
How did the memory consumption change?
Tests are failing - why? They shold be fixed before merging.

re:splash/benchmark.py
That file is useful to run detailed benchmarks with proper utilities.  I agree it doesn't make much sense to update it with every change to rendering workflow, but it can be useful for developers to do some hard-figure benchmarks. Can we have it stashed somewhere with a big disclaimer saying that it may get out of date?
The reason why I'm asking is because one of such benchmarks has shown that:

most of rendering time is spent serializing the image in PNG format, 70 - 90%, on all of the sites I've tested.
QImage->QBuffer serialization takes same time as QImage->PIL.Image->cStringIO.StringIO, and it is no more than 5% of total render time, decreasing when increasing image size
rendering starts to take same amount of time as png serialization at tile size of 128x128

On one hand, this means that we cannot win much cpu time fine-tuning the rendering algo, e.g. increasing tile size. On the other we can easily trade 15-50% of cpu time for 10-15% of png size by using minimum compression_level. I'd say we do that and probably add compression_level argument to query params for users to play with.
re: maxrss, re:images-heavy, re: width>2048
Here's the updated benchmark result table: https://gist.github.com/immerrr/bd0a474d538e46b24415. Note the "4.complevel" entry that denotes saving png with undocumented compression_level=1 parameter.
re: failing tests
looks like binary mismatch of resulting pngs, will look closer tomorrow

Looks great, thanks!


build: add plugin.h, export OPAEGit.cmake

add plugin.h for plugin development

Add plugin.h that includes headers that can be used in plugins
Install new plugin.h as well as adapter.h, opae_int.h, and props.h

export OPAEGit.cmake

Install OPAEGit.cmake into /lib/opae-/modules
Add the modules path to CMAKE_MODULE_PATH so that developers can
include OPAE cmake modules

Currently only OPAEGit.cmake is being installed into this module path
(as opposed to the modules being installed in RPM packages).
Eventually, we need to only install modules that make sense for
developers. Also, we need to structure modules so that they can be
consumed by other software that is importing opae cmake configuration.
For now OPAEGit.cmake is potentially installed in two places.

Coverage remained the same at 65.363% when pulling 82fb51a88c56732ea64b7acf47250822aeb3e66b on rrojo/export-plugin into 8e879d158a60e09427338dc72fd8bbdd51deb264 on master.


jackett: 0.11.457 -> 0.11.559

Semi-automatic update generated by https://github.com/ryantm/nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/jackett/versions.
meta.description for jackett is: '"API Support for your favorite torrent trackers."'.
meta.homepage for jackett is: '"https://github.com/Jackett/Jackett/"
Release on GitHub
Compare changes on GitHub

Checks done (click to expand)

built on NixOS
The tests defined in passthru.tests, if any, passed
/bin/sh passed the binary check.
1 of 1 passed binary check by having a zero exit code.
0 of 1 passed binary check by having the new version present in output.
found 0.11.559 with grep in /nix/store/vl2833c2qsi3q4rrycgs5idmg82d9a14-jackett-0.11.559
directory tree listing: https://gist.github.com/609b722a5b7e549edb8a0ca4f538f2a8
du listing: https://gist.github.com/91ad47341053425f37c476bd48cd9801

Rebuild report (if merged into master) (click to expand)

4 total rebuild path(s)
1 package rebuild(s)
1 x86_64-linux rebuild(s)
1 i686-linux rebuild(s)
1 x86_64-darwin rebuild(s)
1 aarch64-linux rebuild(s)
First fifty rebuilds by attrpath
jackett

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/vl2833c2qsi3q4rrycgs5idmg82d9a14-jackett-0.11.559 \
  --option binary-caches 'https://cache.nixos.org/ https://r-ryantm.cachix.org/' \
  --option trusted-public-keys '
  r-ryantm.cachix.org-1:gkUbLkouDAyvBdpBX0JOdIiD2/DP1ldF3Z3Y6Gqcc4c=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(r-ryantm's Cachix cache is only trusted for this store-path realization.)
Or, build yourself:
nix-build -A jackett https://github.com/r-ryantm/nixpkgs/archive/5d76be906dd097a4604cf0bc050a145e14b92353.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/vl2833c2qsi3q4rrycgs5idmg82d9a14-jackett-0.11.559
ls -la /nix/store/vl2833c2qsi3q4rrycgs5idmg82d9a14-jackett-0.11.559/bin

cc @edwtjo for testing.

@GrahamcOfBorg test jackett


Deprecate showInterface from Font initialization?

I'm not sure how desirable or immediately necessary this change is, but given that there's potential for a clean break with the roboFab implementation, I'm opening this issue as a point of discussion.
Usually when you see a boolean option for any method, it's either a signal that there is a method that is doing double duty, or domain model that hasn't been defined. I'm wondering if this isn't a place where another object might be introduced in order to better encapsulate the design space that fontParts works within:
Font('foo.ufo', showInterface=True)
# vs. proposed:
Editor().open(Font('foo.ufo'))

I'd propose introducing some kind of Editor or Application concept that would be a generic container that explicitly interacts with whichever application is the subject of a fontParts implementation.
I think that this could be a cleaner separation of responsibilities, and would allow the implementation of Font to be ignorant of the details of the manipulating the UI, which I like. There are ramifications for testing (isolating UI concerns to fewer areas), and for conceptually decoupling interface from editor (the latter of which may or may not include an interface that can be shown, but still have the concept of opening a font). It could also mean that a specialized Editor object could open different kinds of resources (e.g. just glyphs, features, etc.).
It would still be possible to maintain the old showInterface API (with a deprecation warning?).
Thoughts?

My two cents:
Most folks writing scripts will have a much easier time with:
Font('foo.ufo', showInterface=True)

I see the appeal of
Editor().open(Font('foo.ufo'))

on a higher level, but would not want the first to go away. This is based on my experience teaching typeface designers to write code, they are not out to be the world's best programmers, they just want to easily understand something and get on with it.

I guess it comes down somewhat to the philosophy of the library… Keeping both feels like it violates the Pythonic tenant of one right way, so I suppose this could be something that just can't change.

Hm, I kinda like the general idea. I think there are some gnarly backwards compatibility and environment things that we need to think through. For example, not all environments have an interface and not all environments have a no-interface way of opening a font. OpenFont("foo.ufo") in FontLab and RoboFont will show an interface. The same thing in NoneLab will not.
Let me think on it...

I was looking through the OpenFont and friends after I opened this issue. For me these have always felt like convenience functions wrapping the mid-level interfaces, to mask some of the underlying implementation details. Perhaps it's worth considering what the primary interface to the library is, and which APIs are changeable, even if this proposal goes too far in introducing new functionality.
The the case of NoneLab Editor#open could simply be a no-op.

I also don't want to imply that Editor is the most appropriate name for this—nor Application. I can think of several situations where one or the other may not be the appropriate term for the context. Interface could be general enough, or at least on the opposite end from Editor

I would agree with @benkiel. One thing to consider is that these calls are part of almost all robofab centric scripts. It would break whatever portability they have. "Clean break" is expensive.

You could kind of use the same reason against the creation of this library entirely. I guess my question is still, if portability is a goal, then which interfaces are changeable and which ones are frozen? Is there a priority among interfaces? One of the stated goals is to remove cruft, and I think that—arguably—this keyword arg is a wart, in not at least crufty.
The second question that I have would be, if these changes are not possible—or not a priority—now, is it possible they could be in the future? Is there a plan to make a long-term roadmap possible? I think that having this library versioned and available on pypi would go a long way to being about to say "now that this is v.2 here are the breaking changes" and offer deprecation warnings up to that point.

I guess my question is still, if portability is a goal, then which interfaces are changeable and which ones are frozen?

There isn't a hard and fast rule. It's more of an intuitive, "How many scripts do we think this will break?" vs, "Ugh, I can't live with this mistake from 2003 anymore so everyone can just deal with the break." kind of thing.

The second question that I have would be, if these changes are not possible—or not a priority—now, is it possible they could be in the future?

Yes. Right now the focus is on trying to get reasonable compatibility with RoboFab so we can stop answering RoboFab tech support questions. After that, we're going to need to bring the API up to date with new stuff.
All that said, we need to make sure that we keep in mind that this is supposed to be a simple scripting API for non-programmers. I've been struggling with that from time to time as evidenced by the looks I got when I proposed a couple of weird things at Typographics. 😕

I've been thinking about an Editor object a bit more. It could be useful for abstracting some of the other common interface interactions that we have needed. For example, robofab.interface.all.dialogs. <bigboldtype>This was a huge headache in RoboFab so I'm sweating a bit even bringing it up.</bigboldtype> But, I know how valuable being able to have a common API for triggering extremely simple user interactions from my experiences writing scripts that had to work equally well in RoboFont and Windows FontLab. Something like this:
app = Application()
path = app.showGetFile(...)
go = app.askYesNo(...)
# etc.

<bigboldtype>FontParts would not implement any of this. Ever. At all. It would only define the API.</bigboldtype> Still, I'm shaking a bit just thinking about it. It's a short road from here to <insert horrible "universal" windowing API name here>.

We've put UI things into fontParts.ui, this is explicitly for an implementation of fontParts to handle, fontParts is not going to make ui components. These are simple, for common things that a scripter would likely want, anything fancier can be done with something else (dialogKit, vanilla, etc). As such, I'm going to close this for now, but it may be worth coming back to the idea of an Editor object at some point.


dont transalte

this program dosent work why?

The original unofficial google translate API seems to be abandoned.

are you sure? can you show some screenshot?
it's working fine here

this program dosent work why?

which part? please upload some screenshot or error traceback call

are you sure? can you show some screenshot?
it's working fine here
please also check with command line version :

are you sure? can you show some screenshot?
it's working fine here
please also check with command line version :
https://github.com/botbahlul/autosrt


How, where and what to configure if I have to migrate this to a GPU based system??? Please help me with this

Uninstall ctransformers and install ctransformers[cuda]

https://pypi.org/project/ctransformers/#gpu


styling of dropdowns in Firefox

Firefox's native styling of select dropdowns looks very "off." If we can have the provision to wrap each select dropdown with a parent, it would make custom styling much easier.

Will release in 1.4.2, PR merged for this feature.


ECONNRESET error when publishing to existing resources

Describe the bug
Publishing from composer fails with a ECONNRESET error when attempting to publish to existing resources.  A large client is experiencing this behavior and we cannot see any information that could help debug / resolve the issue.

--- "{"name":"DEPLOY_ZIP_ERROR","message":"There was a problem publishing bot assets (zip deploy). {\"stack\":\"Error: read ECONNRESET\\n at TLSWrap.onStreamRead (internal/stream_base_commons.js:201:27)\",\"message\":\"read ECONNRESET\",\"code\":\"ECONNRESET\",\"config\":{}}","stack":"Error\n at new CustomizeError (C:\\Program Files\\Bot Framework Composer 2_1_0\\resources\\app.asar.unpacked\\extensions\\azurePublish\\dist\\extension.js:269071:25)\n at createCustomizeError (C:\\Program Files\\Bot Framework Composer 2_1_0\\resources\\app.asar.unpacked\\extensions\\azurePublish\\dist\\extension.js:269076:10)\n at BotProjectDeploy.deployZip (C:\\Program Files\\Bot Framework Composer 2_1_0\\resources\\app.asar.unpacked\\extensions\\azurePublish\\dist\\extension.js:269587:13)"}" --- --- "DEPLOY_Z11:57
Version

Version:  2.1.0
Electron: 8.2.4
Chrome: 80.0.3987.165
NodeJS: 12.13.0
V8: 8.0.426.27-electron.0
Browser

[X] Electron distribution
[ ] Chrome
[ ] Safari
[ ] Firefox
[ ] Edge

OS

[ ] macOS
[X] Windows
[ ] Ubuntu

To Reproduce
Steps to reproduce the behavior:

Create a publish profile using existing created resources
Attempt to deploy the bot

Expected behavior

The bot should deploy successfully
Screenshots

Additional context

@bradrlaw To help us understand the ticket furthur could you lets us know the size of the zipped assets being published and if its consistenly reproable. In addition, on the azure portal can you go check in the Advanced tools --> Tools --> zip Deploy UI. This interface should show real time logs as you publish the zip to azure.

@bradrlaw @srinaath I was also facing the same issue after upgrading the composer to 2.1.0.
After spending some time i was able to figure out that when we select "Import Existing resource" while creating creating publish profile, it is not updating the configuration properly under: configure your bot in composer --> Enable Advance settings view(json) --> publishTargets --> configuration

Configuration when used "Import Existing resource"
"configuration": "{"name":"name","environment":"composer","tenantId":"#####-86f1-####-91ab-#####","hostname":"App service name","runtimeIdentifier":"win-x64","resourceGroup":"resource Group","botName":"bot Name","subscriptionId":"#######-eee4-#####-935f-#######","region":"southcentralus","appServiceOperatingSystem":"windows","scmHostDomain":"","luisResource":"","settings":{"applicationInsights":{"InstrumentationKey":"","connectionString":""},"cosmosDb":{"cosmosDBEndpoint":"","authKey":"","databaseId":"botstate-db","containerId":"botstate-container"},"blobStorage":{"connectionString":"","container":""},"luis":{"authoringKey":"","authoringEndpoint":"","endpointKey":"","endpoint":"","region":"westus"},"qna":{"subscriptionKey":"","endpoint":""},"MicrosoftAppId":"App ID","MicrosoftAppPassword":"Password"}}"
I updated the configuration manually as below and it worked, i was able to deploy the bot with the profile created using "Import Existing resource"
"configuration": "{\n  "name": "Botname",\n  "environment": "composer",\n  "tenantId": "Your Tenant ID",\n  "subscriptionId": "Your subscription ID",\n  "resourceGroup": "Your resource Group",\n  "botName": " Botname ",\n  "hostname": "App service name",\n  "runtimeIdentifier": "win-x64",\n  "region": "Region",\n  "appServiceOperatingSystem": "windows",\n  "settings": {\n    "applicationInsights": {},\n    "luis": {},\n    "qna": {},\n    "MicrosoftAppId": "Your MicrosoftAppId ", \n    "MicrosoftAppPassword": "Your MicrosoftAppPassword"\n  }\n}"

Closing due to no response. Please feel free to reopen if issue persists.

Please see the other issue filed, we cannot import resources anymore.  Composer is failing with a schema error at our client site and our machines.
https://github.com/microsoft/BotFramework-Composer/issues/8523


Fix autoscalar replicas

If a clowdapp increased the minReplica count and then reduces it, the
the deployment does not reduce in kind.
This PR adds in a check to ensure that autoscaler is enabled
if it is not, it returns to the old behaviour where replicas is
always overidden.

/retest


Types cannot be provided in put mapping requests, unless the include_type_name parameter is set to true

ElasticDump version: 6.21.0
Elasticsearch version:  dump data from 6.7.0 to 7.1.1
Node.js version: v12.12.0
Full command you are having issue with (with inputs and outputs)

  elasticdump \
    --input=<input_url v.6.7.0>/<index> \
    --output=<output_url v.7.1.1>/<index> \
    --type=mapping

A data-set you can share publicly which reproduces the problem.

{
  "mappings": {
    "_doc": {
      "properties": {
        "type": { "type": "keyword" },
        "name": { "type": "text" },
        "user_name": { "type": "keyword" },
        "email": { "type": "keyword" },
        "content": { "type": "text" },
        "tweeted_at": { "type": "date" }
      }
    }
  }
}

Describe the bug
Error Emitted =>
{
  "root_cause": [
    {
      "type": "illegal_argument_exception",
      "reason": "Types cannot be provided in put mapping requests, unless the include_type_name parameter is set to true."
    }
  ],
  "type": "illegal_argument_exception",
  "reason": "Types cannot be provided in put mapping requests, unless the include_type_name parameter is set to true."
}

For data with _doc type in mapping, to export to ElasticSearch 7.0 and above, the param include_type_name need to be included. There should be a way to specify this param, or even better a way to remove _doc so that the mapping is typeless.
Ref https://www.elastic.co/guide/en/elasticsearch/reference/master/removal-of-types.html#_typeless_apis_in_7_0

Have you actually thought about editing the export ? We don’t support upgrading from one version to another. All platform (elasticsearch) quirks have to be worked out by you


Control the auto-adjustment of targetHits in ANN using post-filtering.

When searching the HNSW index in a post-filtering case, targetHits is auto-adjusted in an effort to still expose targetHits hits to first-phase ranking after post-filtering. The following formula is now used to ensure an upper bound of adjustedTargetHits, avoiding that the search in the HNSW index takes too long.
adjustedTargetHits = min(targetHits / estimatedHitRatio, targetHits * targetHitsMaxAdjustmentFactor).
The target-hits-max-adjustment-factor can be set in a rank profile and overridden per query. The value is in the range [1.0,inf], with the default being 20.0.
When setting this to 1.0, auto-adjustment of targetHits is effectively disabled.
@arnej27959 please review
@jobergum FYI

@arnej27959 ping


Fix a typo

@nfusi  Hi, Is there something wrong with this PR?  Why there is no response here?

Thanks for the PR. Sorry for taking so long to accept it, it fell off our table.


Front-end design

@KENC0DE @Chareeef kindly add your comments here and I will have a look at them

[ ]

It's an awesome work Blain.
I really loved it.
I just would prefer a more related blood donation related pictures in the home page.
And also you need to have 8 blood category options in donations request, though I need you to kindly explain how wd should handle these requests.
Login should also differentiate between log in as a donor or transfusion center. But its design is great.
You're the best.

I think that it would be better not to have any image on the landing page. Just good coloring and simple and slick design would do.

@KENC0DE @Chareeef thank you for your insight. I will check on this in my next update

@octocatblain Register page is very good. You remind me to add a phone number column to donors and transfusion centers. You only still didn't make separate spaces for donors and TC, in login and Register

@Chareeef i am working on that and the images. The changes you just merged, I worked on them yesterday and pushed today

Perfect 👌

Do you mind if we delete submit donations request section and also stations.
First we just need to display blood  bags situation in different transfusion centers in the home, with location filters.
And as Ken said, avoid gray color. For example I think the top navbar background color could be better in white, as well as forms fields background.

Pull forms branch @octocatblain


Linalg.LinearOperators do not give any performance improvement

Describe the problem
The performance gaurantees are not visible for the Linalg.LinearOperators (e.g., DiagOperator)   I have implemented a basic case below as per the documentation. Is there any reason why the performance of diag operator is same as full matrix ?
Cuda and other versions not included as the issue is reproducible across GPU and CPU modes.
System information

Have I written custom code (as opposed to using a stock example script provided in TensorFlow):

Yes, but using only preliminary Linalg operations.

OS Platform and Distribution (e.g., Linux Ubuntu 16.04):
Linux xxxx-xxxop 4.10.0-28-generic #32~16.04.2-Ubuntu SMP Thu Jul 20 10:19:48 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux
VERSION="16.04.4 LTS (Xenial Xerus)"
VERSION_ID="16.04"
VERSION_CODENAME=xenial

TensorFlow installed from (source or binary):
Binary

TensorFlow version (use command below):
== tensorflow import ============================================
tf.VERSION = 1.8.0
tf.GIT_VERSION = v1.8.0-0-g93bc2e2072
tf.COMPILER_VERSION = v1.8.0-0-g93bc2e2072
Sanity check: array([1], dtype=int32)

Python version:
Python 3.6.0 |Continuum Analytics, Inc.| (default, Dec 23 2016, 12:22:00)

Bazel version (if compiling from source):

GCC/Compiler version (if compiling from source):

CUDA/cuDNN version:

GPU model and memory:

Exact command to reproduce:
Check the source code.

Source code / logs
import numpy as np
import tensorflow as tf
rng = np.random.RandomState(1)

class Data:
    num_data = 10
    num_ind = 50
    D_in = 100
    D_out = 2

    Xmu = rng.randn(num_data, D_in)
    Xcov = rng.randn(num_data, D_in, D_in)
    Xcov = Xcov @ np.transpose(Xcov, (0, 2, 1))
    Z = rng.randn(num_ind, D_in)

N = Data.num_data
Xmu = tf.convert_to_tensor(Data.Xmu)
Xcov = tf.convert_to_tensor(Data.Xcov)

C = tf.cholesky(Xcov)

Z_tiled = tf.tile(tf.expand_dims(tf.transpose(Data.Z), 0), [N, 1, 1])

C_operator = tf.linalg.LinearOperatorLowerTriangular(C)
C_diag_operator = tf.linalg.LinearOperatorDiag(tf.matrix_diag_part(C))

def compute_matrix_solve(C, Z_tiled):
#     return tf.matrix_triangular_solve(C, Z_tiled, lower=True)  # NxDxM
    return tf.matrix_solve(C, Z_tiled)  # NxDxM

def compute_matrix_matmul(C, Z_tiled):
    mat = tf.matmul(C, Z_tiled)
    return mat

def compute_operator_solve(C_operator, Z_tiled):
    operator_value = C_operator.solve(Z_tiled)
    return operator_value

def compute_operator_matmul(C_operator, Z_tiled):
    operator_value = C_operator.matmul(Z_tiled)
    return operator_value

with tf.Session() as sess:
    mat_solve = sess.run(compute_matrix_solve(C, Z_tiled))
    op_solve = sess.run(compute_operator_solve(C_operator, Z_tiled))

    tf_mat_mul = sess.run(compute_matrix_matmul(C, Z_tiled))
    op_matmul = sess.run(compute_operator_matmul(C_operator, Z_tiled))

np.testing.assert_allclose(mat_solve, op_solve)
np.testing.assert_allclose(tf_mat_mul, op_matmul)

with tf.Session() as sess:
    %timeit sess.run(compute_matrix_solve(C, Z_tiled))
    %timeit sess.run(compute_operator_solve(C_operator, Z_tiled))
    %timeit sess.run(compute_operator_solve(C_diag_operator, Z_tiled))

69.1 ms ± 1.33 ms per loop (mean ± std. dev. of 7 runs, 10 loops each)
69.4 ms ± 515 µs per loop (mean ± std. dev. of 7 runs, 10 loops each)
73.7 ms ± 1.55 ms per loop (mean ± std. dev. of 7 runs, 10 loops each)

with tf.Session() as sess:
    %timeit sess.run(compute_matrix_matmul(C, Z_tiled))
    %timeit sess.run(compute_operator_matmul(C_operator, Z_tiled))
    %timeit sess.run(compute_operator_matmul(C_diag_operator, Z_tiled))

58.5 ms ± 447 µs per loop (mean ± std. dev. of 7 runs, 10 loops each)
60.8 ms ± 808 µs per loop (mean ± std. dev. of 7 runs, 10 loops each)
63.8 ms ± 1.78 ms per loop (mean ± std. dev. of 7 runs, 10 loops each)

Hi,
One reason for slowness is compute_* adds nodes to the graph. Generally for benchmarking, one should create the graph up front, and then benchmark the sess.runs. The sess.run(...) should also be timed for the underlying op since eval'ing the tensor can include time from the CPU / GPU copies.
What you want in the end is something like:
with tf.Session() as sess:
msolve = compute_matrix_solve(C, Z_tiled).op
....
def sess_run_msolve():
return sess.run(msolve)
print(timeit.timeit(sess_run_msolve, number=100))
Doing the aforementioned changes (and changing D_in to 500 to see the difference for larger matrices), I get on CPU (in seconds):
Matrix Solve 3.94200801849
Operator Solve 2.10899114609
Diag Solve 1.88388705254
Matrix Mul 2.18344807625
Operator Mul 2.28254699707
Diag Mul 1.86973500252
Using https://www.tensorflow.org/api_docs/python/tf/test/Benchmark is also an alternative, which would also do some burn in cycles.

Thank for your reply. I can confirm that with your suggestions I do see the improvements.
Unfortunately, I have to do this over much lower dimensions and may the gain that case is very marginal.
However, I do like this feature. I will close this issue with results confirming @srvasude  suggestions.
with tf.Session(graph=tf.get_default_graph()) as sess:
    msolve = compute_matrix_solve(C, Z_tiled).op
    opsolve = compute_operator_solve(C_operator, Z_tiled)
    diagsolve=compute_operator_solve(C_diag_operator, Z_tiled)
    def sess_run_msolve():
        return sess.run(msolve)
    def sess_run_opsolve():
        return sess.run(opsolve)
    def sess_run_diagsolve():
        return sess.run(diagsolve)
    def burn_in(msolve, opsolve, diagsolve, cycles=100):
        for _ in range(cycles):
            sess.run([msolve, opsolve, diagsolve])

    burn_in(msolve, opsolve, diagsolve)
    print(timeit.timeit(sess_run_msolve, number=500))
    print(timeit.timeit(sess_run_opsolve, number=500))
    print(timeit.timeit(sess_run_diagsolve, number=500))

28.759427453987882
15.111607366998214
10.926930371992057


feature: Implement getinfo method for new gRPC interface

Motivation
In order to get to grips with the new grpc library we want to implement a getinfo method
Specifications
No response
Complex Code or Requirements
No response
Testing
No response
Related Work
This is part of #7728

Blocked on https://github.com/ZcashFoundation/zebra/issues/8161

@oxarbitrage are we all done here with #8178 or is there follow up work?


streamCallback gets triggered randomly

I am having this strange issue with streamCallback function. Sometimes, even if there is no change in the Firebase RTDB, callback function gets called. Can anybody please help me out?

It's possible that stream was timed out,  the stream restarts then you get that response.
You may need to compare the existing data and new data before process.

It's possible that stream was timed out, the stream restarts then you get that response.
You may need to compare the existing data and new data before process.
Set the stream timeout callback to debug.

The streamTimeoutCallback doesn't get called. Only the streamCallback is getting called randomly. May be there's a problem with the database itself.

Okay, now I have a little understanding of what exactly is happening. When I modify a particular field in firebase RTDB, streamCallback gets called. Now inside streamCallback function I set a particular field in database. This is when the streamCallback gets called. I have used different FirebaseData objects for streamCallback and for setting database fields. But still I am having this issue. Can you please help me out?

You should to avoid to change data in stream path inside the stream callback.
If you intend to do this, you should check the returned event path.
The event path returns from firebase is the relative path from stream path, for example
If you set the stream path to root/myData, and if you set the data to root/myData/Sensor1.
The event path returns when stream event changes will be /Sensor1. Then you can quit stream callback function or continue to run.


How to run on CLI only (no Colab)?

Hi,
Is there a way to generate music using CLI only (without Colab) on CPU (no CUDA)?
Thanks in advance!

@fakerybakery Yes, of'course.
But you will need to change the code a bit and it will be quite slow.
See this post as an example:
https://github.com/asigalov61/Los-Angeles-Music-Composer/discussions/7#discussioncomment-7010266
And if you still need help, let me know :)
ALex

Thanks!

@fakerybakery You are welcome!
Btw, thank you for interest in my projects and for staring my repos :)
I don't know if you got my email but I could use help with web/frontend for my projects so if you interested/can do it/have time, let me know.
ALex


RFC: Use :robot: instead of [automated]

Use the 🤖 emoji instead of [automated] in the PR title, which makes the PR title shorter and look better (in my opinion). Will look like

And in the PR list:

I have no idea if just swapping it out in the string like this will work as intended, so I would not merge this hastily, unless you know that it does work (assuming you think this is a good idea in the first place).

Let's run the integration tests and see if it works

Thanks @mortenpi!


Menu.group doesn't appear to work in UI schema

Describe the bug
I was trying to move a custom action to its own fly-out menu vis the UI schema and I assumed that all I would have to do is add an entry like this:
  "PagedList.dialog": {
    "form": {
      "label": "Dialog: PagedList",
      "subtitle": "Manages interactions with a paged list"
    },
    "menu": {
      "label": "Call PagedList",
      "group": "Project dialogs"
    }
  }

The problem is the action wouldn't show up on the fly-out at all when I set the group. I finally got it to work by setting the submenu instead:
  "PagedList.dialog": {
    "form": {
      "label": "Dialog: PagedList",
      "subtitle": "Manages interactions with a paged list"
    },
    "menu": {
      "label": "Call PagedList",
      "submenu": ["Project dialogs"]
    }
  }

This got it to show up on the menu and maybe group just doesn't work as I expected but given that submenu is marked as option in the schema it seems like there's a bug here given that the action won't show up at all if you don't specify a submenu.
Version
1.1.1
Browser

[x] Electron distribution
[ ] Chrome
[ ] Safari
[ ] Firefox
[ ] Edge

OS

[ ] macOS
[x] Windows
[ ] Ubuntu

I should add that I couldn't get the action to show up at all until I tried setting "submenu": false and then it showed up as a top level action on the fly-out menu. That's what made me realize that groups aren't actually supported yet and I had to specify a submenu value of some sort to get things to show up.

Hi Steve, the group is preserved for this design. (Bot activities, Dev tools)

The confusion of submenu is a problem. @a-b-r-o-w-n Andy what's your option on the naming?

@yeze322 I'm not sure how to address this. Do you have work scheduled for the menu groups? If not, I say we remove that from the schema for the time being.

@a-b-r-o-w-n not scheduled yet, I can remove that

This seems to be resolved in 1.4 as I'm able to add actions to other flyout menus. I think this can be closed.


Coupling Graph doesn't work as expected

I was trying to create the graph.svg with the dependencies, but the command returns an error. Is it just me or does that implementation requires something more or its broken?

What's the error?

We can't do much without a screenshot of the error and your machine specs, os, cpu architecture, etc @mcerejo

These are the errors that are triggered. The popup window is for the tailwind.config.js, postcss.config.js, prettier.config.js.
I'm using yarn (v1.22.19 and v4.1.1), node v18 on a windows 10 pc.

Thanks,
I am not sure what's the issue and can't test it on windows, but there are two things that you could try:

(Must have) Install graphviz (not sure how to do that on Windows, but you you're using wsl, it should be possible), you can find the guide here https://github.com/pahen/madge#graphviz-optional and add it to the PATH manually https://github.com/pahen/madge#graphviz-optional
Try executing that command directly in the console instead of running with yarn "npx madge --extensions js,jsx,ts,tsx,css,md,mdx ./ --exclude '.next|tailwind.config.js|reset.d.ts|prettier.config.js|postcss.config.js|playwright.config.ts|next.config.js|next-env.d.ts|instrumentation.ts|e2e/|README.md|.storybook/|.eslintrc.js' --image graph.svg"  - the fact that error says something about next.config.js tells me it could be an escaping issue


Add lost sector reward to activities UI

One of the main reasons I look at the daily lost sector is to see what slot is dropping today (arms, chest, head, legs).
Currently, the UI does not display the reward for lost sectors.  It would be nice if the reward slot was listed on the detailed UI for legend/master lost sectors, something like this:

Unfortunately, it does not look like this is available in the JSON for the lost sector activity.  It has all rewards listed, not just the slot available today.  There is also not a separate field that determines which reward is active as far as I can tell.

After talking with Slif, it turns out that the lost sector code for today is already a hard-coded rotator list:

One idea would be to enhance this rotator list code to have some sort of enum/list for the reward that'll rotate through [arms, chest, head, legs] and uses the same rotationStart variables in the image above.  The number of days "today" is offset from the rotationStart modulus 4 should pick the right reward.
This rotation order is documented on the todayindestiny site (where they likely have a similar hard-coded list): https://www.todayindestiny.com/ls_calendar

This is currently only partially implemented. The legendary weapon rewards have been added as of https://github.com/rslifka/reckoner-app/commit/543a0e1ec156126b7d842b143f6acca324192e5f

It only took a year, sorry Ted 😄


MLP Training

From https://github.com/OpenGVLab/InternVL/tree/main/internvl_chat#prepare-training-datasets, Is the mlp between llm and vit is random init?

One more thing, I notice the LLava 1.6 is train all params in sft stage2, so i guess internvl-chat is trained as follow stage:
SFT Stage1: Train MLP in LLava 665k Pretrain(is v1.2/v1.2 plus use this)?
SFT Stage2 : Train Full model in LLava 665K or self collect sft data.

When conducting experiments for the paper, we initially utilized a setting akin to LLaVA-1.5, where we first trained the MLP and then trained the MLP + LLM. However, later on, we discovered that training the entire model together yielded better results. Therefore, in versions v1.1/v1.2, we adopted different settings.

In summary, for v1.2/v1.2 plus:
SFT Stage1: Trained on 8192 (batch size) x 4800 (iterations) =39.3M samples, including COYO, LAION, CC12M, CC3M, SBU, Wukong, GRIT, Objects365, OpenImages, and OCR data. Including tasks such as captioning, grounding, detection, and OCR.
SFT Stage2 : Train Full model in open-sourced 1.2M SFT data.

In summary, for v1.2/v1.2 plus: SFT Stage1: Trained on 8192 (batch size) x 4800 (iterations) =39.3M samples, including COYO, LAION, CC12M, CC3M, SBU, Wukong, GRIT, Objects365, OpenImages, and OCR data. Including tasks such as captioning, grounding, detection, and OCR. SFT Stage2 : Train Full model in 1.2M (v1.2) or 12M (v1.2 plus) SFT data.
It confuses me that in SFT Stage1 and Stage2, did you train full model all the time  ?

SFT Stage1: Train the MLP on 8192 (batch size) x 4800 (iterations) =39.3M samples, including COYO, LAION, CC12M, CC3M, SBU, Wukong, GRIT, Objects365, OpenImages, and OCR data. Including tasks such as captioning, grounding, detection, and OCR.
SFT Stage2 : Train full model in 1.2M (v1.2) or 12M (v1.2 plus) SFT data.

Thanks a lot

Thanks

What datasets are included in the 12M SFT data.

There are a lot of academic VQA datasets here, including COCO caption, VQAv2, VSR, OKVQA, AOKVQA, IconQA, AI2D, GQA, TextVQA, OCRVQA, ChartQA, DocQA, STVQA, ESTVQA, InfoVQA, LLaVAR, VisDial, CLEVR, ScienceQA...
And about 2M of open-source OCR datasets, like LSVT, RCTW, ...
Visual grounding datasets like RefCOCO and Toloka, ...
NLP dataset like ShareGPT, OpenOrca, OpenHermes2.5, ...
GPT4V long caption datasets like ShareGPT4V, SVIT, ...

Thanks a lot.


pg_scope depends on the order of chaining scopes

If multiple scopes with joins are chained it can happen that a pg_scope does trigger an sql error if not chained first. For example if search is a pg_scope and houses_city is a regular scope which joins a second model:
Person.search(:some_name).houses_city(:some_city) # works

Person.houses_city(:some_city).search(:some_name) # triggers an error

I have a test case reproducing this in the following gist: https://gist.github.com/doits/215b3b54496ea47254b8
Second test produces the following exception:
PG::UndefinedTable: ERROR:  invalid reference to FROM-clause entry for table "houses"
LINE 1: ...h ON "people"."id" = pg_search.pg_search_id WHERE "houses"."...
                                                             ^
HINT:  Perhaps you meant to reference the table alias "houses_people".

My bet is that is has something to do with table aliasing, but I am not sure.
Looks like this error is the same as in #229.

I think I've reproduced the error in a143926. I'm trying to figure out if there is a way to introduce references(:houses) somewhere into the query to make it work.
Note that in the pg_search spec suite I use my gem with_model which randomizes table names for each spec to make extra sure that we are being careful in constructing queries.

I think I got it, see my PR #239 - the subquery was modifying the original query. Avoidable by calling .dup. But now one other test is failing. I did not have a look at this, maybe it is just a test error?


terminal.integrated.env.linux does not set environment variable TERM

Issue Type: Bug
I'm trying to run a project that uses ncurses, which depends on TERM being defined. I added the following to settings.json
"terminal.integrated.env.linux": {
"TERM": "xterm-256color"
},
but it does nothing. I actually got it to work by checking if TERM is defined and then if it's not calling setenv from the C library. I ran it with all extensions off and had the same result. I've noticed other people complaining about the $PATH variable not being defined I guess this could be related but I'm not sure. Also this setting is on so it should have just done it without me having to set anything else...
"terminal.integrated.inheritEnv": true
VS Code version: Code 1.67.2 (c3511e6c69bb39013c4a4b7b9566ec1ca73fc4d5, 2022-05-17T18:23:40.286Z)
OS version: Linux x64 5.13.0-40-generic snap
Restricted Mode: No

System Info

Item
Value

CPUs
AMD Ryzen 7 5700G with Radeon Graphics (16 x 3574)

GPU Status
2d_canvas: unavailable_softwarecanvas_oop_rasterization: disabled_offdirect_rendering_display_compositor: disabled_off_okgpu_compositing: disabled_softwaremultiple_raster_threads: enabled_onoop_rasterization: disabled_offopengl: disabled_offrasterization: disabled_softwareraw_draw: disabled_off_okskia_renderer: enabled_onvideo_decode: disabled_softwarevideo_encode: disabled_softwarevulkan: disabled_offwebgl: unavailable_softwarewebgl2: unavailable_software

Load (avg)
3, 4, 4

Memory (System)
62.10GB (0.46GB free)

Process Argv
--no-sandbox --force-user-env --unity-launch --crash-reporter-id 2520b01d-a382-4aa3-993a-79aecc74d5cb

Screen Reader
no

VM
0%

DESKTOP_SESSION
ubuntu

XDG_CURRENT_DESKTOP
Unity

XDG_SESSION_DESKTOP
ubuntu

XDG_SESSION_TYPE
x11

Extensions: none
A/B Experiments
vsliv368cf:30146710
vsreu685:30147344
python383:30185418
vspor879:30202332
vspor708:30202333
vspor363:30204092
vstes516:30244333
pythonvspyl392:30443607
pythontb:30283811
pythonptprofiler:30281270
vshan820:30294714
vstes263:30335439
vscorecescf:30445987
pythondataviewer:30285071
vscod805:30301674
binariesv615:30325510
bridge0708:30335490
bridge0723:30353136
vsaa593cf:30376535
vsc1dst:30438360
pythonvs932:30410667
wslgetstarted:30449410
vscscmwlcmt:30465135
cppdebug:30492333
vsclangdc:30486549

Thanks for creating this issue! It looks like you may be using an old version of VS Code, the latest stable release is 1.68.0. Please try upgrading to the latest version and checking whether this issue remains.
Happy Coding!

I just upgraded to 1.68 and the problem persists.

we always set this on linux, so something is going on with your environment.
https://github.com/microsoft/vscode/blob/336dc4733100665bba3ff3a8096d45e806d2ca7f/src/vs/platform/terminal/node/terminalProcess.ts#L151-L157
maybe one of your startup scripts alters this? is it not set for all shell types?

This issue has been closed automatically because it needs more information and has not had recent activity. See also our issue reporting guidelines.
Happy Coding!


fix for phantom migration warning

Closes #1775
@eeintech So turns out the phantom part changes shown are the result of me forgetting to also check if a migration is run, not only if migrations are generated. This PR fixes that.

@G-Pereira this also caused the error you had

@matmair Nice find, thanks!


Is CRC available to ubuntu?

General information

OS: Linux / macOS / Windows
Hypervisor: KVM / Hyper-V / hyperkit
Did you run crc setup before starting it (Yes/No)?

CRC version
# Put the output of `crc version`

CRC status
# Put the output of `crc status`

CRC config
# Put the output of `crc config view`

Host Operating System
# Put the output of `cat /etc/os-release` in case of Linux
# put the output of `sw_vers` in case of Mac
# Put the output of `systeminfo` in case of Windows

Steps to reproduce

Expected
Actual
Logs
You can start crc with crc start --log-level debug to collect logs.
Please consider posting this on http://gist.github.com/ and post the link in the issue.

Yes, but manually steos might be needed. There is a pinned issue that explains this:

Closing as a duplicate of https://github.com/code-ready/crc/issues/549

Thanks


Allow changing post card-Image aspect ratio

Currently post/card-img aspect ratio seems to be determined by fixed height of 160pixels and variable width 100%
Practically this gives an aspect ratio that is quite wide. I would prefer being able to adjust this aspect ratio by increasing image height. Can the height be put into user configurable parameter maybe? Also the resizing height of thumbnail image (currently hardwired to 360px should change accordingly)
Thank you

It's good to have, may happen in this week.

Available since<EMAIL_ADDRESS>see #809 to detailed usage.

Please keep in mind that, for the sake of alignment and responsiveness, most of the time, the display image is incomplete.
https://github.com/hbstack/blog/assets/17720932/bcd8a480-b3e7-4492-bd99-aba5bdf04cf7
But you can add custom style to show full image all the time, but it may not look good.
.hb-blog-post-card-img {
  height: 100%;
  // or replace with the follows.
  object-fit: contain;
}


Xp purchase in skills list is not working

In the skills list there is the $ symbol on the left of the skill name. nothing happend when we click on it. And no error in the console
And the title is not tranlated (ie. SWFFG.Purchase.SkillRank)
With the tooltip the purchase works. And the label is ok ('SWFFG.Actors.Sheets.Purchase.SkillRank.ContextMenuText')
When I check the code there is no condition for the data-buy-action 'skill' (function '_buyCore' in the file starwarsffg\modules\actors\actor-sheet-ffg.js)
Expected behavior
The symbol $ is not very nice in the skills list but it is easier to use it than the context menu. So fix it or remove the symbol in skill list
Desktop (please complete the following information):

Foundry Version: v12.327
System Version:  1.903
Hosted on Forge: "No"

Thanks for the report, fixed. Will be released in 1.904.


Installation with carthage error.Swift4.0

I add
github "radex/SwiftyUserDefaults" "4.0.0-alpha.1"
in my carthage file, then I update carthage, but I get this error in console:
Build Failed
Task failed with exit code 65:
/usr/bin/xcrun xcodebuild -project /Users/SimonKss/Desktop/Test/Carthage/Checkouts/SwiftyUserDefaults/SwiftyUserDefaults.xcodeproj -scheme SwiftyUserDefaults -configuration Release -derivedDataPath /Users/SimonKss/Library/Caches/org.carthage.CarthageKit/DerivedData/9.2_9C40b/SwiftyUserDefaults/4.0.0-alpha.1 -sdk iphoneos ONLY_ACTIVE_ARCH=NO CODE_SIGNING_REQUIRED=NO CODE_SIGN_IDENTITY= CARTHAGE=YES archive -archivePath /var/folders/8t/9vypgvz93m3b4vb34ym_p9440000gn/T/SwiftyUserDefaults SKIP_INSTALL=YES GCC_INSTRUMENT_PROGRAM_FLOW_ARCS=NO CLANG_ENABLE_CODE_COVERAGE=NO STRIP_INSTALLED_PRODUCT=NO (launched in /Users/SimonKss/Desktop/Test/Carthage/Checkouts/SwiftyUserDefaults)
This usually indicates that project itself failed to compile. Please check the xcodebuild log for more details: /var/folders/8t/9vypgvz93m3b4vb34ym_p9440000gn/T/carthage-xcodebuild.n0qBN0.log
I'm using Swift4.0 and Xcode 9.2

Hey, please try again version 4.0.0-alpha.2. If you still have problems, please create new issue.