Add logger into application

Add logger into application. Learn about debug package and integrate it into app.

Resolved in https://github.com/IlonaMenkui/data-worker/pull/16


Ft delete food items 160545337

What does this PR do ?
Has endpoint for deleting a food item
Description of task
DELETE  api/v1/foods/<id>
Tests for the endpoint
How should this be manually tested
Clone the repo
git clone https://github.com/kevinene91/Fast-Food-Fast-API.git
get the  branch
git fetch origin ft-delete-food-items-160545337
Navigate to the folder
cd Fast-Food-API
create a virual env
virtualenv venv
Activate the venv
source/venv/activate
Install the required packages
pip install -r requirements.txt
Launch the program
python run.py
Use Postman to the test the endpoint
What are the relevant pivotal tracker stories
1160545337
Screenshots

Pull Request Test Coverage Report for Build 117

143 of 162 (88.27%)  changed or added relevant lines in 6 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-7.5%) to 91.48%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

app/api/v1/models/order_model.py
34
35
97.14%

app/api/v1/resources/orders.py
36
39
92.31%

app/api/v1/resources/foods.py
33
48
68.75%

Totals

Change from base Build 93:
-7.5%

Covered Lines:
204

Relevant Lines:
223

💛  - Coveralls


yukiasai/Minamo

Minamo - Simple coach mark library written in Swift.
Language - Swift.

https://github.com/vsouza/awesome-ios/pull/2306


Use oidc as e2e test authentication method

Describe your changes
Issue number
#000
Checklist before requesting a review

[ ] The pr title can be used to describe what this pr did in CHANGELOG.md file
[ ] I have executed pre-commit on my machine
[ ] I have passed pr-check on my machine

Thanks for your cooperation!

I'm merging this pr despite version upgrade test failing because it' an as expected error and would be fixed in next release.


Progress bar and indication volume

Progress bar and indication volume
Hello, from http://www.mediaelementjs.com page,
The indication of the volume level seems to be different with the video formats (dailymotion / Vimo / Facebook / Twitch)
Regarding the HLS audio file, the startup seems to take place at 30 seconds
The indication of the volume level appears to be different with the formats (soundcloud)
Under EDGE does not work:
The indication of the volume level seems different with the video format (RTMP / Dailymotion / Youtube / Vimeo / Facebook / Twitch)
The volume level indication appears different with the audio format (RTMP)
Under Chrome 58
The indication of the volume level is different according to the video formats (RTMP / HLS / FLV / M (PEG) -DAS / Vimeo / Facebook / Twich)
The indication of the volume level is different according to the formats of the audios (HLS / RTMP / Soundcloud)
The playback progress indication does not appear to start at zero
Firefox 53
Video and audio RTMP does not seem to work
The volume level indication is different depending on the video formats (HLS / FLV / M (PEG) -DAS / dailymotion / Youtube / Vimeo / Facebook / Twich)
The indication of the volume level is different according to the audio formats (HLS / Soundcloud)

As the volume goes, player initially starts at 0.8, but some of the renderers are configured to start at 1. That's why you see the difference. I can take a look and make sure it's consistent.
About the HLS audio: this is something that is part of the source itself, due its configuration to search for fragments. I'll try to research about this, but it's not a personal source so I cannot modify it.

Thank you, I understand better now :-)


Refined search

Initially I was wondering if Expect-CT should apply to all responses (if served over HTTPS) and not only text/html responses, so I used the search bar and found nothing.
Then to try out the search capabilities I searched for x-frame-options and that entire list shows links to documentation on x-content-type-options, however as I used the webhint-scanner earlier I know that x-frame-options is considered in the checks so it was just a matter of actually finding the documentation on it.
It'd be helpful if there could be improvements in this area, having the webhint.io scanner telling you that you did something wrong and how to fix it is great, amazing in fact! But being able to find documentation beforehand during development would be too.

Thanks for your feedback @Malvoz!
You are right, we should do better in this area. We are using algolia and basically use the defaults of the service for indexing and showing results. We should look into the documentation to see what can be done.


Move quantization/prototype -> prototype/quantization

Issue : https://github.com/pytorch/ao/issues/1013

thanks, this will be bc-breaking for QAT I think, will be good to import the diff and fix the torchtune stuff before landing I feel

thanks, this will be bc-breaking for QAT I think, will be good to import the diff and fix the torchtune stuff before landing I feel

If some of this code has internal callsites, should it move out of prototype?  Prototype shouldn't have any BC guarantees. cc @andrewor14

Yeah sounds good, I will submit a separate PR to move QAT out of prototype and update all internal imports. @jainapurva for now can you leave the qat/ directory in its original place so you don't run into conflicts later? You can move the rest

https://github.com/pytorch/ao/pull/1091


fix: top loader bug

Describe your changes
closes https://github.com/BearStudio/start-ui-web/issues/434
Checklist

[x] I performed a self review of my code
[x] I ensured that everything is written in English
[x] I tested the feature or fix on my local environment
[x] I ran the pnpm storybook command and everything is working
 - [ ] If applicable, I updated the translations for english and french files
(If you cannot update the french language, just let us know in the PR description)
- [ ] If applicable, I updated the README.md
 - [ ] If applicable, I created a PR or an issue on the documentation repository
[x] If applicable, I’m sure that my feature or my component is mobile first and available correctly on desktop

showSpinner={false} is properly working on the admin pages now and added ^ to make the dependency stable

Thanks a lot @tomcru ❤


Add support for thumbnail track configuration

Description
Possibility to add custom external thumbnail track configuration
Implementation possibility
At the load content
     player.load({
        ...
        thumbnailTrack: {
          url: 'https://cdn.bitmovin.com/content/assets/art-of-motion-dash-hls-progressive/thumbnails/f08e80da-bf1d-4e3d-8899-f0f6155f6efa.vtt',
          label: 'ThumbnailTrack',
        },
      });

Possible validation

I look forward to possible comments and/or suggestions, and I am happy to help in any way I can, thanks for the effort
Best

I have created PR #65 related to this implementation thank you very much.

Close #65


Allow body in DELETE method

Thank you for your contribution, your PR has been released with v1.1.8 😉


Update bicep references

Thank you for helping make the Radius documentation better!
Please follow this checklist before submitting:

[ ] Read the contribution guide
[ ] Commands include options for Linux, MacOS, and Windows within codetabs
[ ] New file and folder names are globally unique
[ ] Page references use shortcodes instead of markdown or URL links
[ ] Images use HTML style and have alternative text
[ ] Places where multiple code/command options are given have codetabs

In addition, please fill out the following to help reviewers understand this pull request:
Description

Issue reference

@sk593- Upmerge to main Bicep is officially targeted for 0.37 release right? if yes, can you update this PR to target edge branch?


Explore implementation possibilities in Wayland

I found rust wayland client, maybe it's possible after all?


CSS default styling should not allocate mem for some common defaults

Some very common CSS defaults values (e.g., "color") are inherited and therefore should always resolve to a valid value (color.Color in this case). This leads to an instantiated value for every box. That's OK for boxes which do have other styles as well, as a style type has then to be allocated anyway. But we should not allocate anything for boxes which do only have common inherited style defaults (which is presumably a very frequent case).
My current implementation idea is to have the user-agent defaults for some styles ("color", "font-family") set to "" (empty string). This will suppress creating a style container.
The flip side of this implementation is that the styling engine has to stop and think in case of empty styles.
Perhaps it would be wise to instantiate them before rendering? But then we should have done it before layout, as we will need the same mem size anyway.
Basically it's a trade-off between code-complication+performance vs memory footprint.
Affected files:

dom/style/defaults.go    (style defaults)
frame/boxtree/generate.go  (generation of box-tree)
and other files during rendering

Defined a user-agent value for non-inherited properties (like "color", "border-top-color", …) of "default".
Property color converter in

dom/style/convert.go

will treat this as a null value, wheras "" (NullProperty) will be treatet as a hint to return a UA value.
Works fine so far. Just will have to remember the semantics of "default".

Documented in dom/style/defaults.go


[Automation] Generate Fluent Lite from Swagger apicenter#package-2024-03

[Automation] Generate Fluent Lite from Swagger apicenter#package-2024-03

/azp run java - apicenter - mgmt - tests

API change check
APIView has identified API level changes in this PR and created following API reviews.
com.azure.resourcemanager:azure-resourcemanager-apicenter


Improve README layout

Make it clearer

Different "typical use" and "options for use" sections
Features section with ticks for which features already exist

Add sheilds.io labels for nicer UI

Added in v1.0.2


Don't force a component developer to use git / GitHub

We shouldn't leave the users in a half-complete state after running sapling init Add this as a check before the user can continue using the CLI.
We should only add a link to GitHub as an "extra" feature and only if a github link is provided.

Resolved in #59


applivery-ios 0.3.0

New Pull Request Checklist
Please mark the points which you did / accept.

[x] I will not move an already shared step version's tag to another commit
[x] I read the Step Development Guideline
[x] I have a test for my Step, which can be run with bitrise run test (in the step's repository)
[x] I did run bitrise run audit-this-step (in the step's repository - note, if you don't have this workflow in your bitrise.yml, you can copy it from the step template.)
[x] I read and accept the Abandoned Step policy

Bug found. Closing and requesting again...


feat: replace super-linter with custom linter list

Contributor Comments
This PR removes the super-linter and replaces it with a list of linters in etc/linters.json. Configuration files for each linter were created in etc/ and match the configs contained in the super-linter. Logic was included to allow custom arguments to be passed in for each linter in an environment variable, as well as a regex-based file exclusion list.
Pull Request Checklist
Thank you for submitting a contribution to the goat!
In order to streamline the review of your contribution we ask that you review and comply with the below requirements:

[x] Rebase your branch against the latest commit of the target branch
[x] If you are adding a dependency, please explain how it was chosen
[x] If manual testing is needed in order to validate the changes, provide a testing plan and the expected results
[x] If there is an issue associated with your Pull Request, link the issue to the PR.

I don't know how to get it to find the .editorconfig because they don't seem to have a way to pass an arbitrary location to load it from. It loads from current directory up to the root - see https://editorconfig.org/#file-location

We don't need to change cfn-lint; I made the recommended changes


[bug] Unable setup this UI for ONLY schema inspection and KC management

Describe the bug
Both SchemaRegistry and KafkaConnect do not require any connection to Kafka/Zookeeper to be able to check data in them or manage them. However this UI falls flat on the face when attempting to run this setup.
I believe this UI should be useable for configurations where we only need to view schemas or manage KafkaConnect. With this bug it is not.
Set up
Docker master branch latest
Steps to Reproduce
Steps to reproduce the behavior:

Configure a cluster with only SR configuration defined (no ZK,Kafka)

Expected behavior
Can browse schemas
Actual behavior
500 errors everywhere, even no "Schema Registry" in cluster options.
Example configuration
version: '2'

services:
  kafka-ui:
    image: provectuslabs/kafka-ui:master
    ports:
      - 8080:8080
    environment:
      SERVER_SERVLET_CONTEXT_PATH: "/kafkaui"
      SPRING_CODEC_MAX_IN_MEMORY_SIZE: "20MB"
      LOGGING_LEVEL_ROOT: "WARN"
      LOGGING_LEVEL_COM_PROVECTUS: "WARN"

      KAFKA_CLUSTERS_0_NAME: cluster_name
      KAFKA_CLUSTERS_0_READONLY: "true"
      KAFKA_CLUSTERS_0_SCHEMAREGISTRY: http://schemaregistry01:8081,http://schemaregistry02:8081,http://schemaregistry03:8081

Log errors

09:45:49.502 [parallel-2] ERROR com.provectus.kafka.ui.service.MetricsService - Failed to collect cluster cluster_name info
java.lang.NullPointerException: null
	at java.util.concurrent.ConcurrentHashMap.putVal(Unknown Source) ~[?:?]
	at java.util.concurrent.ConcurrentHashMap.put(Unknown Source) ~[?:?]
	at java.util.Properties.put(Unknown Source) ~[?:?]
	at com.provectus.kafka.ui.service.AdminClientServiceImpl.lambda$createAdminClient$2(AdminClientServiceImpl.java:38) ~[classes!/:?]
	at reactor.core.publisher.MonoSupplier.call(MonoSupplier.java:85) ~[reactor-core-3.3.2.RELEASE.jar!/:3.3.2.RELEASE]
	at reactor.core.publisher.FluxFlatMap.trySubscribeScalarMap(FluxFlatMap.java:126) [reactor-core-3.3.2.RELEASE.jar!/:3.3.2.RELEASE]
	at reactor.core.publisher.MonoFlatMap.subscribeOrReturn(MonoFlatMap.java:53) [reactor-core-3.3.2.RELEASE.jar!/:3.3.2.RELEASE]
	at reactor.core.publisher.Mono.subscribe(Mono.java:4090) [reactor-core-3.3.2.RELEASE.jar!/:3.3.2.RELEASE]
	at reactor.core.publisher.FluxSwitchIfEmpty$SwitchIfEmptySubscriber.onComplete(FluxSwitchIfEmpty.java:75) [reactor-core-3.3.2.RELEASE.jar!/:3.3.2.RELEASE]
	at reactor.core.publisher.Operators.complete(Operators.java:132) [reactor-core-3.3.2.RELEASE.jar!/:3.3.2.RELEASE]
	at reactor.core.publisher.MonoEmpty.subscribe(MonoEmpty.java:45) [reactor-core-3.3.2.RELEASE.jar!/:3.3.2.RELEASE]
	at reactor.core.publisher.Mono.subscribe(Mono.java:4105) [reactor-core-3.3.2.RELEASE.jar!/:3.3.2.RELEASE]
	at reactor.core.publisher.FluxFlatMap$FlatMapMain.onNext(FluxFlatMap.java:418) [reactor-core-3.3.2.RELEASE.jar!/:3.3.2.RELEASE]
	at reactor.core.publisher.FluxMap$MapSubscriber.onNext(FluxMap.java:114) [reactor-core-3.3.2.RELEASE.jar!/:3.3.2.RELEASE]
	at reactor.core.publisher.FluxPublishOn$PublishOnSubscriber.runAsync(FluxPublishOn.java:398) [reactor-core-3.3.2.RELEASE.jar!/:3.3.2.RELEASE]
	at reactor.core.publisher.FluxPublishOn$PublishOnSubscriber.run(FluxPublishOn.java:484) [reactor-core-3.3.2.RELEASE.jar!/:3.3.2.RELEASE]
	at reactor.core.scheduler.WorkerTask.call(WorkerTask.java:84) [reactor-core-3.3.2.RELEASE.jar!/:3.3.2.RELEASE]
	at reactor.core.scheduler.WorkerTask.call(WorkerTask.java:37) [reactor-core-3.3.2.RELEASE.jar!/:3.3.2.RELEASE]
	at java.util.concurrent.FutureTask.run(Unknown Source) [?:?]
	at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(Unknown Source) [?:?]
	at java.util.concurrent.ThreadPoolExecutor.runWorker(Unknown Source) [?:?]
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(Unknown Source) [?:?]
	at java.lang.Thread.run(Unknown Source) [?:?]

Navigating to any menu item results in:

09:45:51.317 [boundedElastic-2] WARN  com.provectus.kafka.ui.exception.ErrorCode - Multiple class com.provectus.kafka.ui.exception.ErrorCode values refer to code 4001
09:45:51.325 [boundedElastic-2] ERROR org.springframework.boot.autoconfigure.web.reactive.error.AbstractErrorWebExceptionHandler - [303296dd]  500 Server Error for HTTP GET "/kafkaui/api/clusters/cluster_name/consumer-groups"
java.lang.NullPointerException: null
	at java.util.concurrent.ConcurrentHashMap.putVal(Unknown Source) ~[?:?]
	Suppressed: reactor.core.publisher.FluxOnAssembly$OnAssemblyException:
Error has been observed at the following site(s):
	|_ checkpoint ⇢ Handler com.provectus.kafka.ui.controller.ConsumerGroupsController#getConsumerGroups(String, ServerWebExchange) [DispatcherHandler]
	|_ checkpoint ⇢ com.provectus.kafka.ui.config.CustomWebFilter [DefaultWebFilterChain]
	|_ checkpoint ⇢ com.provectus.kafka.ui.config.ReadOnlyModeFilter [DefaultWebFilterChain]
	|_ checkpoint ⇢ org.springframework.security.web.server.authorization.AuthorizationWebFilter [DefaultWebFilterChain]
	|_ checkpoint ⇢ org.springframework.security.web.server.authorization.ExceptionTranslationWebFilter [DefaultWebFilterChain]
	|_ checkpoint ⇢ org.springframework.security.web.server.authentication.logout.LogoutWebFilter [DefaultWebFilterChain]
	|_ checkpoint ⇢ org.springframework.security.web.server.savedrequest.ServerRequestCacheWebFilter [DefaultWebFilterChain]
	|_ checkpoint ⇢ org.springframework.security.web.server.context.SecurityContextServerWebExchangeWebFilter [DefaultWebFilterChain]
	|_ checkpoint ⇢ org.springframework.security.web.server.context.ReactorContextWebFilter [DefaultWebFilterChain]
	|_ checkpoint ⇢ org.springframework.security.web.server.header.HttpHeaderWriterWebFilter [DefaultWebFilterChain]
	|_ checkpoint ⇢ org.springframework.security.config.web.server.ServerHttpSecurity$ServerWebExchangeReactorContextWebFilter [DefaultWebFilterChain]
	|_ checkpoint ⇢ org.springframework.security.web.server.WebFilterChainProxy [DefaultWebFilterChain]
	|_ checkpoint ⇢ HTTP GET "/kafkaui/api/clusters/cluster_name/consumer-groups" [ExceptionHandlingWebHandler]
Stack trace:
		at java.util.concurrent.ConcurrentHashMap.putVal(Unknown Source) ~[?:?]
		at java.util.concurrent.ConcurrentHashMap.put(Unknown Source) ~[?:?]
		at java.util.Properties.put(Unknown Source) ~[?:?]
		at com.provectus.kafka.ui.service.AdminClientServiceImpl.lambda$createAdminClient$2(AdminClientServiceImpl.java:38) ~[classes!/:?]
		at reactor.core.publisher.MonoSupplier.call(MonoSupplier.java:85) ~[reactor-core-3.3.2.RELEASE.jar!/:3.3.2.RELEASE]
		at reactor.core.publisher.FluxFlatMap.trySubscribeScalarMap(FluxFlatMap.java:126) [reactor-core-3.3.2.RELEASE.jar!/:3.3.2.RELEASE]
		at reactor.core.publisher.MonoFlatMap.subscribeOrReturn(MonoFlatMap.java:53) [reactor-core-3.3.2.RELEASE.jar!/:3.3.2.RELEASE]
		at reactor.core.publisher.Mono.subscribe(Mono.java:4090) [reactor-core-3.3.2.RELEASE.jar!/:3.3.2.RELEASE]
		at reactor.core.publisher.FluxSwitchIfEmpty$SwitchIfEmptySubscriber.onComplete(FluxSwitchIfEmpty.java:75) [reactor-core-3.3.2.RELEASE.jar!/:3.3.2.RELEASE]
		at reactor.core.publisher.Operators.complete(Operators.java:132) [reactor-core-3.3.2.RELEASE.jar!/:3.3.2.RELEASE]
		at reactor.core.publisher.MonoEmpty.subscribe(MonoEmpty.java:45) [reactor-core-3.3.2.RELEASE.jar!/:3.3.2.RELEASE]
		at reactor.core.publisher.InternalMonoOperator.subscribe(InternalMonoOperator.java:55) [reactor-core-3.3.2.RELEASE.jar!/:3.3.2.RELEASE]
		at reactor.core.publisher.MonoFlatMap$FlatMapMain.onNext(MonoFlatMap.java:150) [reactor-core-3.3.2.RELEASE.jar!/:3.3.2.RELEASE]
		at reactor.core.publisher.Operators$MonoSubscriber.complete(Operators.java:1637) [reactor-core-3.3.2.RELEASE.jar!/:3.3.2.RELEASE]
		at reactor.core.publisher.MonoFlatMap$FlatMapInner.onNext(MonoFlatMap.java:241) [reactor-core-3.3.2.RELEASE.jar!/:3.3.2.RELEASE]
		at reactor.core.publisher.FluxOnErrorResume$ResumeSubscriber.onNext(FluxOnErrorResume.java:73) [reactor-core-3.3.2.RELEASE.jar!/:3.3.2.RELEASE]
		at reactor.core.publisher.FluxPeekFuseable$PeekFuseableSubscriber.onNext(FluxPeekFuseable.java:203) [reactor-core-3.3.2.RELEASE.jar!/:3.3.2.RELEASE]
		at reactor.core.publisher.FluxPeekFuseable$PeekFuseableSubscriber.onNext(FluxPeekFuseable.java:203) [reactor-core-3.3.2.RELEASE.jar!/:3.3.2.RELEASE]
		at reactor.core.publisher.Operators$MonoSubscriber.complete(Operators.java:1637) [reactor-core-3.3.2.RELEASE.jar!/:3.3.2.RELEASE]
		at reactor.core.publisher.MonoIgnoreThen$ThenAcceptInner.onNext(MonoIgnoreThen.java:296) [reactor-core-3.3.2.RELEASE.jar!/:3.3.2.RELEASE]
		at reactor.core.publisher.Operators$MonoSubscriber.complete(Operators.java:1637) [reactor-core-3.3.2.RELEASE.jar!/:3.3.2.RELEASE]
		at reactor.core.publisher.MonoFlatMap$FlatMapMain.onNext(MonoFlatMap.java:144) [reactor-core-3.3.2.RELEASE.jar!/:3.3.2.RELEASE]
		at reactor.core.publisher.Operators$MonoSubscriber.complete(Operators.java:1637) [reactor-core-3.3.2.RELEASE.jar!/:3.3.2.RELEASE]
		at reactor.core.publisher.MonoZip$ZipCoordinator.signal(MonoZip.java:247) [reactor-core-3.3.2.RELEASE.jar!/:3.3.2.RELEASE]
		at reactor.core.publisher.MonoZip$ZipInner.onNext(MonoZip.java:329) [reactor-core-3.3.2.RELEASE.jar!/:3.3.2.RELEASE]
		at reactor.core.publisher.MonoPeekTerminal$MonoTerminalPeekSubscriber.onNext(MonoPeekTerminal.java:173) [reactor-core-3.3.2.RELEASE.jar!/:3.3.2.RELEASE]
		at reactor.core.publisher.Operators$ScalarSubscription.request(Operators.java:2199) [reactor-core-3.3.2.RELEASE.jar!/:3.3.2.RELEASE]
		at reactor.core.publisher.MonoPeekTerminal$MonoTerminalPeekSubscriber.request(MonoPeekTerminal.java:132) [reactor-core-3.3.2.RELEASE.jar!/:3.3.2.RELEASE]
		at reactor.core.publisher.MonoZip$ZipInner.onSubscribe(MonoZip.java:318) [reactor-core-3.3.2.RELEASE.jar!/:3.3.2.RELEASE]
		at reactor.core.publisher.MonoPeekTerminal$MonoTerminalPeekSubscriber.onSubscribe(MonoPeekTerminal.java:145) [reactor-core-3.3.2.RELEASE.jar!/:3.3.2.RELEASE]
		at reactor.core.publisher.MonoJust.subscribe(MonoJust.java:54) [reactor-core-3.3.2.RELEASE.jar!/:3.3.2.RELEASE]
		at reactor.core.publisher.Mono.subscribe(Mono.java:4105) [reactor-core-3.3.2.RELEASE.jar!/:3.3.2.RELEASE]
		at reactor.core.publisher.MonoZip.subscribe(MonoZip.java:128) [reactor-core-3.3.2.RELEASE.jar!/:3.3.2.RELEASE]
		at reactor.core.publisher.InternalMonoOperator.subscribe(InternalMonoOperator.java:55) [reactor-core-3.3.2.RELEASE.jar!/:3.3.2.RELEASE]
		at reactor.core.publisher.MonoDefer.subscribe(MonoDefer.java:52) [reactor-core-3.3.2.RELEASE.jar!/:3.3.2.RELEASE]
		at reactor.core.publisher.MonoIgnoreThen$ThenIgnoreMain.drain(MonoIgnoreThen.java:153) [reactor-core-3.3.2.RELEASE.jar!/:3.3.2.RELEASE]
		at reactor.core.publisher.MonoIgnoreThen.subscribe(MonoIgnoreThen.java:56) [reactor-core-3.3.2.RELEASE.jar!/:3.3.2.RELEASE]
		at reactor.core.publisher.InternalMonoOperator.subscribe(InternalMonoOperator.java:55) [reactor-core-3.3.2.RELEASE.jar!/:3.3.2.RELEASE]
		at reactor.core.publisher.MonoFlatMap$FlatMapMain.onNext(MonoFlatMap.java:150) [reactor-core-3.3.2.RELEASE.jar!/:3.3.2.RELEASE]
		at reactor.core.publisher.FluxSwitchIfEmpty$SwitchIfEmptySubscriber.onNext(FluxSwitchIfEmpty.java:67) [reactor-core-3.3.2.RELEASE.jar!/:3.3.2.RELEASE]
		at reactor.core.publisher.MonoNext$NextSubscriber.onNext(MonoNext.java:76) [reactor-core-3.3.2.RELEASE.jar!/:3.3.2.RELEASE]
		at reactor.core.publisher.FluxConcatMap$ConcatMapImmediate.innerNext(FluxConcatMap.java:274) [reactor-core-3.3.2.RELEASE.jar!/:3.3.2.RELEASE]
		at reactor.core.publisher.FluxConcatMap$ConcatMapInner.onNext(FluxConcatMap.java:851) [reactor-core-3.3.2.RELEASE.jar!/:3.3.2.RELEASE]
		at reactor.core.publisher.FluxMapFuseable$MapFuseableSubscriber.onNext(FluxMapFuseable.java:121) [reactor-core-3.3.2.RELEASE.jar!/:3.3.2.RELEASE]
		at reactor.core.publisher.MonoPeekTerminal$MonoTerminalPeekSubscriber.onNext(MonoPeekTerminal.java:173) [reactor-core-3.3.2.RELEASE.jar!/:3.3.2.RELEASE]
		at reactor.core.publisher.Operators$ScalarSubscription.request(Operators.java:2199) [reactor-core-3.3.2.RELEASE.jar!/:3.3.2.RELEASE]
		at reactor.core.publisher.MonoPeekTerminal$MonoTerminalPeekSubscriber.request(MonoPeekTerminal.java:132) [reactor-core-3.3.2.RELEASE.jar!/:3.3.2.RELEASE]
		at reactor.core.publisher.FluxMapFuseable$MapFuseableSubscriber.request(FluxMapFuseable.java:162) [reactor-core-3.3.2.RELEASE.jar!/:3.3.2.RELEASE]
		at reactor.core.publisher.Operators$MultiSubscriptionSubscriber.set(Operators.java:2007) [reactor-core-3.3.2.RELEASE.jar!/:3.3.2.RELEASE]
		at reactor.core.publisher.Operators$MultiSubscriptionSubscriber.onSubscribe(Operators.java:1881) [reactor-core-3.3.2.RELEASE.jar!/:3.3.2.RELEASE]
		at reactor.core.publisher.FluxMapFuseable$MapFuseableSubscriber.onSubscribe(FluxMapFuseable.java:90) [reactor-core-3.3.2.RELEASE.jar!/:3.3.2.RELEASE]
		at reactor.core.publisher.MonoPeekTerminal$MonoTerminalPeekSubscriber.onSubscribe(MonoPeekTerminal.java:145) [reactor-core-3.3.2.RELEASE.jar!/:3.3.2.RELEASE]
		at reactor.core.publisher.MonoJust.subscribe(MonoJust.java:54) [reactor-core-3.3.2.RELEASE.jar!/:3.3.2.RELEASE]
		at reactor.core.publisher.Mono.subscribe(Mono.java:4105) [reactor-core-3.3.2.RELEASE.jar!/:3.3.2.RELEASE]
		at reactor.core.publisher.FluxConcatMap$ConcatMapImmediate.drain(FluxConcatMap.java:441) [reactor-core-3.3.2.RELEASE.jar!/:3.3.2.RELEASE]
		at reactor.core.publisher.FluxConcatMap$ConcatMapImmediate.onSubscribe(FluxConcatMap.java:211) [reactor-core-3.3.2.RELEASE.jar!/:3.3.2.RELEASE]
		at reactor.core.publisher.FluxIterable.subscribe(FluxIterable.java:139) [reactor-core-3.3.2.RELEASE.jar!/:3.3.2.RELEASE]
		at reactor.core.publisher.FluxIterable.subscribe(FluxIterable.java:63) [reactor-core-3.3.2.RELEASE.jar!/:3.3.2.RELEASE]
		at reactor.core.publisher.InternalMonoOperator.subscribe(InternalMonoOperator.java:55) [reactor-core-3.3.2.RELEASE.jar!/:3.3.2.RELEASE]
		at reactor.core.publisher.MonoDefer.subscribe(MonoDefer.java:52) [reactor-core-3.3.2.RELEASE.jar!/:3.3.2.RELEASE]
		at reactor.core.publisher.InternalMonoOperator.subscribe(InternalMonoOperator.java:55) [reactor-core-3.3.2.RELEASE.jar!/:3.3.2.RELEASE]
		at reactor.core.publisher.MonoDefer.subscribe(MonoDefer.java:52) [reactor-core-3.3.2.RELEASE.jar!/:3.3.2.RELEASE]
		at reactor.core.publisher.InternalMonoOperator.subscribe(InternalMonoOperator.java:55) [reactor-core-3.3.2.RELEASE.jar!/:3.3.2.RELEASE]
		at reactor.core.publisher.MonoDefer.subscribe(MonoDefer.java:52) [reactor-core-3.3.2.RELEASE.jar!/:3.3.2.RELEASE]
		at reactor.core.publisher.MonoDefer.subscribe(MonoDefer.java:52) [reactor-core-3.3.2.RELEASE.jar!/:3.3.2.RELEASE]
		at reactor.core.publisher.Mono.subscribe(Mono.java:4105) [reactor-core-3.3.2.RELEASE.jar!/:3.3.2.RELEASE]
		at reactor.core.publisher.FluxSwitchIfEmpty$SwitchIfEmptySubscriber.onComplete(FluxSwitchIfEmpty.java:75) [reactor-core-3.3.2.RELEASE.jar!/:3.3.2.RELEASE]
		at reactor.core.publisher.MonoFlatMap$FlatMapMain.onNext(MonoFlatMap.java:141) [reactor-core-3.3.2.RELEASE.jar!/:3.3.2.RELEASE]
		at reactor.core.publisher.FluxSwitchIfEmpty$SwitchIfEmptySubscriber.onNext(FluxSwitchIfEmpty.java:67) [reactor-core-3.3.2.RELEASE.jar!/:3.3.2.RELEASE]
		at reactor.core.publisher.FluxFilter$FilterSubscriber.onNext(FluxFilter.java:107) [reactor-core-3.3.2.RELEASE.jar!/:3.3.2.RELEASE]
		at reactor.core.publisher.FluxDefaultIfEmpty$DefaultIfEmptySubscriber.onNext(FluxDefaultIfEmpty.java:92) [reactor-core-3.3.2.RELEASE.jar!/:3.3.2.RELEASE]
		at reactor.core.publisher.MonoNext$NextSubscriber.onNext(MonoNext.java:76) [reactor-core-3.3.2.RELEASE.jar!/:3.3.2.RELEASE]
		at reactor.core.publisher.FluxConcatMap$ConcatMapImmediate.innerNext(FluxConcatMap.java:274) [reactor-core-3.3.2.RELEASE.jar!/:3.3.2.RELEASE]
		at reactor.core.publisher.FluxConcatMap$ConcatMapInner.onNext(FluxConcatMap.java:851) [reactor-core-3.3.2.RELEASE.jar!/:3.3.2.RELEASE]
		at reactor.core.publisher.Operators$MonoSubscriber.complete(Operators.java:1637) [reactor-core-3.3.2.RELEASE.jar!/:3.3.2.RELEASE]
		at reactor.core.publisher.MonoFlatMap$FlatMapMain.onNext(MonoFlatMap.java:144) [reactor-core-3.3.2.RELEASE.jar!/:3.3.2.RELEASE]
		at reactor.core.publisher.FluxMapFuseable$MapFuseableSubscriber.onNext(FluxMapFuseable.java:121) [reactor-core-3.3.2.RELEASE.jar!/:3.3.2.RELEASE]
		at reactor.core.publisher.FluxFilterFuseable$FilterFuseableSubscriber.onNext(FluxFilterFuseable.java:112) [reactor-core-3.3.2.RELEASE.jar!/:3.3.2.RELEASE]
		at reactor.core.publisher.Operators$ScalarSubscription.request(Operators.java:2199) [reactor-core-3.3.2.RELEASE.jar!/:3.3.2.RELEASE]
		at reactor.core.publisher.FluxFilterFuseable$FilterFuseableSubscriber.request(FluxFilterFuseable.java:184) [reactor-core-3.3.2.RELEASE.jar!/:3.3.2.RELEASE]
		at reactor.core.publisher.FluxMapFuseable$MapFuseableSubscriber.request(FluxMapFuseable.java:162) [reactor-core-3.3.2.RELEASE.jar!/:3.3.2.RELEASE]
		at reactor.core.publisher.MonoFlatMap$FlatMapMain.onSubscribe(MonoFlatMap.java:103) [reactor-core-3.3.2.RELEASE.jar!/:3.3.2.RELEASE]
		at reactor.core.publisher.FluxMapFuseable$MapFuseableSubscriber.onSubscribe(FluxMapFuseable.java:90) [reactor-core-3.3.2.RELEASE.jar!/:3.3.2.RELEASE]
		at reactor.core.publisher.FluxFilterFuseable$FilterFuseableSubscriber.onSubscribe(FluxFilterFuseable.java:81) [reactor-core-3.3.2.RELEASE.jar!/:3.3.2.RELEASE]
		at reactor.core.publisher.MonoJust.subscribe(MonoJust.java:54) [reactor-core-3.3.2.RELEASE.jar!/:3.3.2.RELEASE]
		at reactor.core.publisher.Mono.subscribe(Mono.java:4105) [reactor-core-3.3.2.RELEASE.jar!/:3.3.2.RELEASE]
		at reactor.core.publisher.FluxConcatMap$ConcatMapImmediate.drain(FluxConcatMap.java:441) [reactor-core-3.3.2.RELEASE.jar!/:3.3.2.RELEASE]
		at reactor.core.publisher.FluxConcatMap$ConcatMapImmediate.onSubscribe(FluxConcatMap.java:211) [reactor-core-3.3.2.RELEASE.jar!/:3.3.2.RELEASE]
		at reactor.core.publisher.FluxIterable.subscribe(FluxIterable.java:139) [reactor-core-3.3.2.RELEASE.jar!/:3.3.2.RELEASE]
		at reactor.core.publisher.FluxIterable.subscribe(FluxIterable.java:63) [reactor-core-3.3.2.RELEASE.jar!/:3.3.2.RELEASE]
		at reactor.core.publisher.InternalMonoOperator.subscribe(InternalMonoOperator.java:55) [reactor-core-3.3.2.RELEASE.jar!/:3.3.2.RELEASE]
		at reactor.core.publisher.MonoDefer.subscribe(MonoDefer.java:52) [reactor-core-3.3.2.RELEASE.jar!/:3.3.2.RELEASE]
		at reactor.core.publisher.InternalMonoOperator.subscribe(InternalMonoOperator.java:55) [reactor-core-3.3.2.RELEASE.jar!/:3.3.2.RELEASE]
		at reactor.core.publisher.MonoDefer.subscribe(MonoDefer.java:52) [reactor-core-3.3.2.RELEASE.jar!/:3.3.2.RELEASE]
		at reactor.core.publisher.Mono.subscribe(Mono.java:4105) [reactor-core-3.3.2.RELEASE.jar!/:3.3.2.RELEASE]
		at reactor.core.publisher.MonoIgnoreThen$ThenIgnoreMain.drain(MonoIgnoreThen.java:172) [reactor-core-3.3.2.RELEASE.jar!/:3.3.2.RELEASE]
		at reactor.core.publisher.MonoIgnoreThen.subscribe(MonoIgnoreThen.java:56) [reactor-core-3.3.2.RELEASE.jar!/:3.3.2.RELEASE]
		at reactor.core.publisher.Mono.subscribe(Mono.java:4105) [reactor-core-3.3.2.RELEASE.jar!/:3.3.2.RELEASE]
		at reactor.core.publisher.FluxSwitchIfEmpty$SwitchIfEmptySubscriber.onComplete(FluxSwitchIfEmpty.java:75) [reactor-core-3.3.2.RELEASE.jar!/:3.3.2.RELEASE]
		at reactor.core.publisher.FluxFilter$FilterSubscriber.onComplete(FluxFilter.java:160) [reactor-core-3.3.2.RELEASE.jar!/:3.3.2.RELEASE]
		at reactor.core.publisher.FluxSwitchIfEmpty$SwitchIfEmptySubscriber.onComplete(FluxSwitchIfEmpty.java:78) [reactor-core-3.3.2.RELEASE.jar!/:3.3.2.RELEASE]
		at reactor.core.publisher.Operators$ScalarSubscription.request(Operators.java:2201) [reactor-core-3.3.2.RELEASE.jar!/:3.3.2.RELEASE]
		at reactor.core.publisher.Operators$MultiSubscriptionSubscriber.set(Operators.java:2007) [reactor-core-3.3.2.RELEASE.jar!/:3.3.2.RELEASE]
		at reactor.core.publisher.Operators$MultiSubscriptionSubscriber.onSubscribe(Operators.java:1881) [reactor-core-3.3.2.RELEASE.jar!/:3.3.2.RELEASE]
		at reactor.core.publisher.MonoJust.subscribe(MonoJust.java:54) [reactor-core-3.3.2.RELEASE.jar!/:3.3.2.RELEASE]
		at reactor.core.publisher.Mono.subscribe(Mono.java:4105) [reactor-core-3.3.2.RELEASE.jar!/:3.3.2.RELEASE]
		at reactor.core.publisher.FluxSwitchIfEmpty$SwitchIfEmptySubscriber.onComplete(FluxSwitchIfEmpty.java:75) [reactor-core-3.3.2.RELEASE.jar!/:3.3.2.RELEASE]
		at reactor.core.publisher.MonoNext$NextSubscriber.onComplete(MonoNext.java:96) [reactor-core-3.3.2.RELEASE.jar!/:3.3.2.RELEASE]
		at reactor.core.publisher.FluxFilter$FilterSubscriber.onComplete(FluxFilter.java:160) [reactor-core-3.3.2.RELEASE.jar!/:3.3.2.RELEASE]
		at reactor.core.publisher.FluxFlatMap$FlatMapMain.checkTerminated(FluxFlatMap.java:823) [reactor-core-3.3.2.RELEASE.jar!/:3.3.2.RELEASE]
		at reactor.core.publisher.FluxFlatMap$FlatMapMain.drainLoop(FluxFlatMap.java:589) [reactor-core-3.3.2.RELEASE.jar!/:3.3.2.RELEASE]
		at reactor.core.publisher.FluxFlatMap$FlatMapMain.drain(FluxFlatMap.java:569) [reactor-core-3.3.2.RELEASE.jar!/:3.3.2.RELEASE]
		at reactor.core.publisher.FluxFlatMap$FlatMapMain.onComplete(FluxFlatMap.java:455) [reactor-core-3.3.2.RELEASE.jar!/:3.3.2.RELEASE]
		at reactor.core.publisher.FluxIterable$IterableSubscription.slowPath(FluxIterable.java:265) [reactor-core-3.3.2.RELEASE.jar!/:3.3.2.RELEASE]
		at reactor.core.publisher.FluxIterable$IterableSubscription.request(FluxIterable.java:201) [reactor-core-3.3.2.RELEASE.jar!/:3.3.2.RELEASE]
		at reactor.core.publisher.FluxFlatMap$FlatMapMain.onSubscribe(FluxFlatMap.java:363) [reactor-core-3.3.2.RELEASE.jar!/:3.3.2.RELEASE]
		at reactor.core.publisher.FluxIterable.subscribe(FluxIterable.java:139) [reactor-core-3.3.2.RELEASE.jar!/:3.3.2.RELEASE]
		at reactor.core.publisher.FluxIterable.subscribe(FluxIterable.java:63) [reactor-core-3.3.2.RELEASE.jar!/:3.3.2.RELEASE]
		at reactor.core.publisher.InternalMonoOperator.subscribe(InternalMonoOperator.java:55) [reactor-core-3.3.2.RELEASE.jar!/:3.3.2.RELEASE]
		at reactor.core.publisher.MonoDefer.subscribe(MonoDefer.java:52) [reactor-core-3.3.2.RELEASE.jar!/:3.3.2.RELEASE]
		at reactor.core.publisher.MonoFlatMap$FlatMapMain.onNext(MonoFlatMap.java:150) [reactor-core-3.3.2.RELEASE.jar!/:3.3.2.RELEASE]
		at reactor.core.publisher.Operators$MonoSubscriber.complete(Operators.java:1637) [reactor-core-3.3.2.RELEASE.jar!/:3.3.2.RELEASE]
		at reactor.core.publisher.FluxDefaultIfEmpty$DefaultIfEmptySubscriber.onComplete(FluxDefaultIfEmpty.java:100) [reactor-core-3.3.2.RELEASE.jar!/:3.3.2.RELEASE]
		at reactor.core.publisher.FluxMap$MapSubscriber.onComplete(FluxMap.java:136) [reactor-core-3.3.2.RELEASE.jar!/:3.3.2.RELEASE]
		at reactor.core.publisher.FluxMap$MapSubscriber.onComplete(FluxMap.java:136) [reactor-core-3.3.2.RELEASE.jar!/:3.3.2.RELEASE]
		at reactor.core.publisher.FluxFilter$FilterSubscriber.onComplete(FluxFilter.java:160) [reactor-core-3.3.2.RELEASE.jar!/:3.3.2.RELEASE]
		at reactor.core.publisher.FluxMap$MapConditionalSubscriber.onComplete(FluxMap.java:262) [reactor-core-3.3.2.RELEASE.jar!/:3.3.2.RELEASE]
		at reactor.core.publisher.Operators$MonoSubscriber.complete(Operators.java:1638) [reactor-core-3.3.2.RELEASE.jar!/:3.3.2.RELEASE]
		at reactor.core.publisher.MonoCacheTime$CoordinatorSubscriber.signalCached(MonoCacheTime.java:320) [reactor-core-3.3.2.RELEASE.jar!/:3.3.2.RELEASE]
		at reactor.core.publisher.MonoCacheTime$CoordinatorSubscriber.onNext(MonoCacheTime.java:337) [reactor-core-3.3.2.RELEASE.jar!/:3.3.2.RELEASE]
		at reactor.core.publisher.FluxPeek$PeekSubscriber.onNext(FluxPeek.java:192) [reactor-core-3.3.2.RELEASE.jar!/:3.3.2.RELEASE]
		at reactor.core.publisher.FluxSwitchIfEmpty$SwitchIfEmptySubscriber.onNext(FluxSwitchIfEmpty.java:67) [reactor-core-3.3.2.RELEASE.jar!/:3.3.2.RELEASE]
		at reactor.core.publisher.FluxMapFuseable$MapFuseableSubscriber.onNext(FluxMapFuseable.java:121) [reactor-core-3.3.2.RELEASE.jar!/:3.3.2.RELEASE]
		at reactor.core.publisher.FluxSubscribeOnCallable$CallableSubscribeOnSubscription.run(FluxSubscribeOnCallable.java:249) [reactor-core-3.3.2.RELEASE.jar!/:3.3.2.RELEASE]
		at reactor.core.scheduler.SchedulerTask.call(SchedulerTask.java:68) [reactor-core-3.3.2.RELEASE.jar!/:3.3.2.RELEASE]
		at reactor.core.scheduler.SchedulerTask.call(SchedulerTask.java:28) [reactor-core-3.3.2.RELEASE.jar!/:3.3.2.RELEASE]
		at java.util.concurrent.FutureTask.run(Unknown Source) [?:?]
		at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(Unknown Source) [?:?]
		at java.util.concurrent.ThreadPoolExecutor.runWorker(Unknown Source) [?:?]
		at java.util.concurrent.ThreadPoolExecutor$Worker.run(Unknown Source) [?:?]
		at java.lang.Thread.run(Unknown Source) [?:?]

Hi Alex, thanks for raising the issue. We'll consider making it possible to run the app w/o kafka in next versions.

A bit related but when you do not define a zookeeper connection string it displays zookeeper as offline which might be confusing.

Consider implementing this within #753


Works: back button goes to footer (in specific circumstances)

I THINK this happens when you select a result from half way or further down the results page, view the item, then press back. It seems to happen with some but not all images. pressing back button links back to the footer instead of where they were in the results list.

Closed until someone can show it happening.


Needless dependency on symfony/yaml

Hi,
Related to https://github.com/lezhnev74/openapi-psr7-validator/issues/65 and idea of moving this package to php league.
I personally believe that in order to spread good practices and allow as many folks as possible to use openapi validation, we should focus on having as little dependencies as possible.
Currently, this package uses cebe/php-openapi which forces installation of symfony/yaml component. This indirectly forces a minimal version of Symfony (version >=4 I believe) and cuts off some potential developers. IMO input source (json/yaml) should be separated from parsing library. It should be up to developer to parse yaml/json (symfony/yaml could be a suggestion in composer.json) and then pass array or stdClass to cebe/php-openapi. This may seem like a bit of extra effort from developer but it will result in less dependencies and higher adoption.

Or we can improve cebe/php-openapi to work with all not eoled yaml
versions, which is not so hard to do
вс, 8 сент. 2019 г., 10:58 Mieszko Malawski<EMAIL_ADDRESS>
Hi,
Related to #65
https://github.com/lezhnev74/openapi-psr7-validator/issues/65 and idea
of moving this package to php league.
I personally believe that in order to spread good practices and allow as
many folks as possible to use openapi validation, we should focus on having
as little dependencies as possible.
Currently, this package uses cebe/php-openapi which forces installation of
symfony/yaml component. This indirectly forces a minimal version of Symfony
and cuts off some potential developers. IMO input source (json/yaml) should
be separated from parsing library. It should be up to developer to parse
yaml/json (symfony/yaml could be a suggestion in composer.json) and then
pass array or stdClass to cebe/php-openapi. This may seem like a bit of
extra effort from developer but it will result in less dependencies and
higher adoption.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/lezhnev74/openapi-psr7-validator/issues/67?email_source=notifications&email_token=ABSGB3J4GWKPDNVQVJAMANLQISWEBA5CNFSM4IUSSTGKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4HJ73FIQ,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABSGB3IXGNS2I6T23IJS3Z3QISWEBANCNFSM4IUSSTGA
.

pinging @cebe
btw, speaking of dependencies. The open PR #64 adds dependency to https://github.com/dflydev/dflydev-fig-cookies which does PSR-7 cookies parsing. Do you think it is excessively?

dflydev/fig-cookies itself does not have many dependencies so I guess it's fine.
Looking at these stats https://blog.packagist.com/php-versions-stats-2019-1-edition/ about 65% people use 7.2 or above. Still 15% folks using 7.1 would be cut off. I would try to still support 7.1 if it's possible but if it means that some important feature will be blocked then I would consider abandoning 7.1

PHP 7.1 reaches end of line in 2 months and will not receive any security updates anymore (see https://www.php.net/supported-versions.php), so anybody who is still running 7.1 needs to update urgently.
Imho, PHP 7.1 should only be supported if it does not block any feature development (and also does not complicate it). In all other cases people need to upgrade their PHP version first to use new features.


Release 0.14-2

A follow-up to #767 to fix publishing to crates.io issues.

Indeed. Cyclic deps between the new storage-macro package and storage-plus.


docs: add more instructions to CONTRIBUTING.md

Fixes #891.
Fixes #894.

@ywc88 given you ran into this, I'd appreciate if you could look at this and see if it makes things clearer. Thanks!


renders are slower for like x2

Describe your bug here. If you are modding, try testing your bug in a clean version of the engine instead. Also, if you're using an older version of JSE, please try the latest version/action build. Also, be sure to check the pinned 'JS Engine: Known Issues' issue, to check if your issue hasn't already been found!
im using classic render mode and after i turn the pngs into mp4s the mp4 is just x2 slower. also i was trying to do something with speed in video editor but nothing worked
Command Prompt/Terminal/Crash logs (if existing)
no
Have you identified any steps to reproduce the bug? If so, please describe them below in as much detail as possible. Use images if possible.
classic render mode
100 fps
lossless format
Are you modding a build from source or with Lua?
Lua
What is your build target?
Windows
Did you edit anything in this build? If so, mention or summarize your changes.
no
If you use 1.12.0 or earlier, did you have Optimized Chart Loading turned on?
None
Did you check for any similar issues to what you're reporting? Check, then come back here. If there is a similar issue, then do not report the issue, otherwise it will be marked as a duplicate.
Yes

dude
it's meant to do that

for classic rendering
if it's slow on the final, speeding up

well
that's something I can't answer

close for inactivity


Hack to show that there is an issue with the session collection's logic

This PR is a hack to show that there is an issue somewhere with the collection storage/retrieval logic for session collections (I also think this affects user and resource collections, but haven't verified this yet) which is causing #1273. After applying this change the test in #1273 always adds up to the total number of requests. I arrived at this conclusion because I noticed some inconsistencies in the logging, like:
Added collection "default_SESSION" to the list as "SESSION".
....
collection_retrieve_ex: collection_retrieve_ex: Retrieving collection (name "default_SESSION", filename "/var/lib/mod_security/default_SESSION")

and that the SESSION collection never receives delta updates like the global one does:
collection_store: Delta applied for global.counter 1->2 (1): 1 + (1) = 2 [2,1]

because orig_col in re_actions.c always returns NULL for the session collection:
458     orig_col = (const apr_table_t *)apr_table_get(msr->collections_original, var_name->value);

The only difference that I see in the way that the global and session collections are handled is in the real_col_name and col_name passed into init_collection.
Obviously I don't want this to be accepted, but I wanted to get a conversation started with someone that understands mod_security better than I do and post the results of my testing thus far. I was told that a PR is the best way to do that :)

@bostrt

Oh yeah, after this change is applied you have to update the configuration to use 'default_SESSION' instead of 'SESSION' (which is why I said this is a hack) because it tries to lookup the exact name you give it there.
SecAction phase:5,id:119,nolog,pass,setvar:default_SESSION.my_counter=+1

I left the original hacky commit in the PR (reverted) to show exactly what logic I think is flawed, but the newer commit looks like a good fix to me. Feedback appreciated!

Just to add more details...
Not sure if you have noticed but the deafult_ that you are referring to, is in fact the name of the WEBAPPID. The idea behind the WebAppID is to create a namespace for the collection. There are further information about the SecWebAppId here:

https://github.com/SpiderLabs/ModSecurity/wiki/Reference-Manual#SecWebAppId
https://github.com/SpiderLabs/ModSecurity/wiki/Reference-Manual#WEBAPPID

As I've commented before, regardless of the computation of the delta, it is expected to have a conter  on the top of a collection with values that are not the exactly same amount of requests. That may differ upon to the limitations of the server vs the amount of requests.

As described at #1273, this issue has being fixed therefore we no longer need this hack to expose the problem. Thank you for the report @csutherl  :)


Slide-Deck is broken

The second slide does not work
https://githubtraining.github.io/github-slideshow-demo

agreed


Resources

Initial implementation of consolidating file/resource management.
Tasks
This PR adds a Task model and controller for consolidating how we store information about long running tasks. This will be useful to create dashboards for ourselves, access groups, and regions about things that are happening behind the scenes.

Codecov Report

Merging #237 into dev will increase coverage by 0.25%.
The diff coverage is 32.85%.

@@            Coverage Diff             @@
##                dev   #237      +/-   ##
==========================================
+ Coverage     22.75%    23%   +0.25%
- Complexity      103    105       +2
==========================================
  Files            63     66       +3
  Lines          2430   2499      +69
  Branches        220    223       +3
==========================================
+ Hits            553    575      +22
- Misses         1842   1889      +47
  Partials         35     35

Impacted Files
Coverage Δ
Complexity Δ

...om/conveyal/taui/controllers/RegionController.java
78.26% <ø> (ø)
8 <0> (ø)
:arrow_down:

...in/java/com/conveyal/taui/models/Modification.java
16.66% <ø> (-11.91%)
1 <0> (ø)

...c/main/java/com/conveyal/taui/models/Progress.java
0% <0%> (ø)
0 <0> (?)

...ava/com/conveyal/taui/persistence/Persistence.java
82.6% <100%> (+0.79%)
3 <0> (ø)
:arrow_down:

...rc/main/java/com/conveyal/taui/AnalysisServer.java
43.29% <100%> (+0.59%)
4 <0> (ø)
:arrow_down:

...c/main/java/com/conveyal/taui/models/Resource.java
27.27% <27.27%> (ø)
0 <0> (?)

.../conveyal/taui/controllers/ResourceController.java
39.47% <39.47%> (ø)
2 <2> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 225bbbf...461232e. Read the comment docs.

Related to task tracking: https://github.com/conveyal/r5/issues/461

Moved this branch over to the other repo.


Update wallet.rs rev to update to latest breaking changes

https://github.com/iotaledger/cli-wallet/pull/112


feat: charge hydration utilities in preparation for Pay button

What changed? Why?

Adds utility for making RPC calls to hydrate a charge in preparation for payment
Adds types for hydrate charge call
Adds utility and constants for handling errors from the hydrate charge call

Notes to reviewers
How has it been tested?

Going forward for all APIs, let's have them live in the api module :)

Great start!!!


Should be able to pass Type of Queue along with QueueName

I am facing latency issues with Resque. I have dedicated a VM of Redis for Resque. Only resque workers and few locks that need to be taken during the job execution are done on this redis instance. Here is the command stats of that instance:
Commandstats
cmdstat_get:calls=2111,usec=10266,usec_per_call=4.86
cmdstat_set:calls=760626,usec=5961980,usec_per_call=7.84
cmdstat_setnx:calls=11379,usec=80801,usec_per_call=7.10
cmdstat_del:calls=769892,usec=4445869,usec_per_call=5.77
cmdstat_incr:calls=1521250,usec=11125827,usec_per_call=7.31
cmdstat_rpush:calls=630726,usec=19003304,usec_per_call=30.13
cmdstat_lpush:calls=630120,usec=3318287,usec_per_call=5.27
cmdstat_lpop:calls=1390349,usec=24332154,usec_per_call=17.50
cmdstat_llen:calls=12342,usec=53727,usec_per_call=4.35
cmdstat_lindex:calls=234718953,usec=740049726,usec_per_call=3.15
cmdstat_sadd:calls=762026,usec=4995570,usec_per_call=6.56
cmdstat_smembers:calls=1976,usec=177941,usec_per_call=90.05
cmdstat_zadd:calls=130905,usec=2291260,usec_per_call=17.50
cmdstat_zrem:calls=519398,usec=3726215,usec_per_call=7.17
cmdstat_zrangebyscore:calls=126509310,usec=1107421536,usec_per_call=8.75
cmdstat_zcard:calls=3952,usec=19675,usec_per_call=4.98
cmdstat_hset:calls=129110,usec=2005137,usec_per_call=15.53
cmdstat_hget:calls=129106,usec=1364512,usec_per_call=10.57
cmdstat_select:calls=7647,usec=29785,usec_per_call=3.89
cmdstat_expire:calls=9268,usec=58640,usec_per_call=6.33
cmdstat_ping:calls=816168,usec=2510628,usec_per_call=3.08
cmdstat_type:calls=1348568645,usec=5287065002,usec_per_call=3.92
cmdstat_multi:calls=233961325,usec=545398278,usec_per_call=2.33
cmdstat_exec:calls=233961325,usec=745074070,usec_per_call=3.18
cmdstat_info:calls=4,usec=3296,usec_per_call=824.00
cmdstat_config:calls=1,usec=483,usec_per_call=483.00
cmdstat_publish:calls=2,usec=55,usec_per_call=27.50
cmdstat_watch:calls=236251945,usec=691940962,usec_per_call=2.93
cmdstat_unwatch:calls=2290227,usec=10833822,usec_per_call=4.73
As you can see there are a 1.3 billion calls for getting the type of queue. I am using long lived queues whose type will not change. Can't we allow the client to pass type as well because it is an unnecessary call in my use case.
Quick question: Does jesque favor many small queues than few large ones, because when i benchmarked jesque i found that when queue is large only few workers pick and execute task(In this test my avg job execution time was 100ms and num of workers was 50... only 4-5 workers did 90% of 10K job).

We could look into a solution that caches the type of a queue to save all those calls.
As for your large queue vs small queues, I'd have to look at your workload. If the jobs are all short-lived and CPU-bound, It would make sense that only a few workers end up doing most of the work since those threads are actively running on the CPU and will get back to fetch the next job before other threads are woken up to get a job. Maybe you can tweak the number of worker threads or do some more investigation into it. I'd be curious to see what you find!

Caching might be problematic if a user is creating a queue of different type with same name(after exhausting the original)... although that does not seem good design strategy.
I run the tests and the workload distribution was fine.... there was some problem in my old test case.

@gresrun i think we can close this now as you have implemented the lua script based solution for pop


Use default timeout for jbpm-bpmn2 tests to avoid build hanging

@mswiderski this does not fix the test, but it at least prevents the build from hanging when the tests goes havoc
Timeout 30s should I think be enough even for slower machines. If we have tests that take more than that, we should probably think about fixing them.

+1 to merge, thanks @psiroky


Bug: Only works when soundcard is set as the default

When using sbz-switch with a virtual audio cable or in conjunction with other soundcards (multiple wdm output/playback devices) and not having the soundblaster set as the windows default it will throw an error:
thread 'main' panicked at 'called `Result::unwrap()` on an `Err` value: NotSupported', src\libcore\result.rs:906:4 note: Run with `RUST_BACKTRACE=1` for a backtrace. Jul 16 18:07:33.568 INFO Setting muted to true..., module: sbz_switch::media:163 Jul 16 18:07:33.570 INFO Setting muted to false..., module: sbz_switch::media:163
It seems that it doesn't try to find the right output (wdm playback device) and only uses the default, which in this case is a virtual audio cable.
Setting the soundcard (soundblaster) as the default will remedy this of course.

Yes that would be enough and a really good solution. Thank you for answering :+1:

Try version 2.0.0.
PS> sbz-switch list-devices
[[]]
id = '{<IP_ADDRESS>00000}.{15769be7-350c-47e0-90d2-c6031d2a6cfa}'
interface = 'Sound Blaster Z'
description = 'Speakers'

[[]]
id = '{<IP_ADDRESS>00000}.{435524ef-e50a-49db-82da-2f497744325b}'
interface = 'Steam Streaming Microphone'
description = 'Speakers'

[[]]
id = '{<IP_ADDRESS>00000}.{5558cb3d-5ebb-47af-a437-2803acf7eb48}'
interface = 'Steam Streaming Speakers'
description = 'Speakers'

[[]]
id = '{<IP_ADDRESS>00000}.{cee1531a-c95a-492a-bca9-a4ca8b3dd5b7}'
interface = '2- USB Audio Device'
description = 'Speakers'

PS> sbz-switch dump -d '{<IP_ADDRESS>00000}.{15769be7-350c-47e0-90d2-c6031d2a6cfa}'
[creative."Bass Management"]
...

Tried it and it works beautifully, thank you very much :)


Updates in documentation to introduce core field editors

Put a line character limit as well.

Thanks, PTAL?


Clarify licensing of portals for Dynamics CS Pro

On the Dynamics 365 Licensing Guide it states
Customer Service Professional provides basic resources for customer service agents. It also provides a self-service customer portal and access to a knowledge base for end customers"
This makes it seem that agents, with a CS Pro license, are able to create self-service customer portals, which end customers (external users) are allowed to access without additional licensing/cost.
However, speaking with @dileepsinghmicrosoft from the PowerPages product team on Ignite, it seems that is not the case, and PowerPages licensing is required for end users to access the portal.
Right now, there seems to be no hard enforcement of this, and authenticated external users are able to login to portals created by agents with CS Pro license.
This is creating a lot of confusion, and speaking with different people at Microsoft (Sales team, Partner Team, Support Team), they also believed like me that CS Pro included rights for end customers to access customer portal, because of that phrase on the Dynamics Licensing Guide, and lack of clarification on the docs.
If this information is correct, both the Guide and docs should maybe clarify since this is causing widespread confusion.

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: a2cad5bd-4ffa-3671-0364-95e5b6f65256
Version Independent ID: 6d0cc055-b7be-02d7-3ba8-55e400ccd21b
Content: Power Platform licensing FAQs - Power Platform
Content Source: power-platform/admin/powerapps-flow-licensing-faq.md
Service: power-platform
Sub-service: admin
GitHub Login: @ChrisGarty
Microsoft Alias: cgarty

Thanks for your comment, @JMCA2. This issue has been assigned to the doc author for review.


Default formatter shows month name instead of Sunday

What's the rational behind this? I know I can set my own tickFormat, but not when dynamically changing the time range (i.e zoom). It's a minor detail, I guess, but I find it very odd. To illustrate, the time axis may show [..., Sat 02, 12 PM, Feb 03, 12PM, Mon 04, ...]

This is controlled by the scale’s tick format (in particular, time.tickFormat) not the axis component. Per the README:

Although somewhat unusual, this default behavior has the benefit of providing both local and global context: for example, formatting a sequence of ticks as [11 PM, Mon 07, 01 AM] reveals information about hours, dates, and day simultaneously, rather than just the hours [11 PM, 12 AM, 01 AM]. See d3-time-format if you’d like to roll your own conditional time format.

My bad. I found https://github.com/d3/d3-scale/issues/103, but it does not explain why show the month instead of Sunday, oh well...


Add slate bandit dataset

Overview
Add SyntheticSlateBanditDataset (based on SyntheticBanditDataset)
Tasks

[x] Implement behavior policy
[x] Test behavior policy
[x] Implement five reward structures
[x] Implement click models
[x] Test reward
[x] fix document

Remark

E203 (flake8)

@fullflu Thanks! I've looked through the slate dataset class and suggest some rephrasing as listed below.

impression_id -> slate_id
pscore_joint_above -> pscore_cascade
pscore_joint_all -> pscore
pscore_marginal -> pscore_item_position
action_set = np.arange(self.n_actions) -> unique_action_set = np.arange(self.n_actions)
you are using get sometimes which is ambiguous, I suggest you use more concrete verbs such as obtain, calc, or define
you set RIPS to reward_structure but RIPS is an estimator not an assumption. I think reward_structure should be one of cascade(=RIPS), item_position(=IIPS), or None (=SIPS, which allows any complex interaction)
def self.sample_action( -> self.sample_action_and_obtain_pscore(

[nits]

you use np.arange and range alternately. I suggest you use only np.arange (just because I use it in other parts of the package) if there is no reason to use both
https://github.com/fullflu/zr-obp/blob/46ea0ce278cab090dc589ed69743e61eeefd63b1/obp/dataset/synthetic_slate.py#L250-L254

I think you can implement the same process as follows
# calculate joint pscore
pscore_i *= score_[sampled_action_index]
pscore_joint_above[i * self.len_list + position_] = pscore_i

[ ] impression_id -> slate_id
[ ] pscore_joint_above -> pscore_cascade
[ ] pscore_joint_all -> pscore
[ ] pscore_marginal -> pscore_item_position
[ ] action_set = np.arange(self.n_actions) -> unique_action_set = np.arange(self.n_actions)
[ ] you are using get sometimes which is ambiguous, I suggest you use more concrete verbs such as obtain, calc, or define
[ ] you set RIPS to reward_structure but RIPS is an estimator not an assumption. I think reward_structure should be one of cascade(=RIPS), item_position(=IIPS), or None (=SIPS, which allows any complex interaction) -> defined five reward structures (standard_additive, standard_exponential, independent, cascade_additive, cascade_exponential)
[ ] def self.sample_action( -> self.sample_action_and_obtain_pscore(
[ ] you use np.arange and range alternately. I suggest you use only np.arange (just because I use it in other parts of the package) if there is no reason to use both
[ ] calculate joint pscore

Error: Unable to resolve action psf/black@stable, unable to find version stable

https://github.com/psf/black/issues/2079

@fullflu
Thanks! Overall, the slate stuff is great; I can't wait to see some simulations results!
Please address the following minor comments.
[must]

Please specify the output of the function. (and why does random_state come first?)
https://github.com/fullflu/zr-obp/blob/2a8b38b19698cb847eaa202b7c53f587c2ad526b/obp/dataset/synthetic_slate.py#L581

[imo]

It may be better to rephrase it as n_unique_action. We also call the number of combinatorial actions as the number of actions, so we may want to differentiate these different concepts. How do you think?
https://github.com/fullflu/zr-obp/blob/2a8b38b19698cb847eaa202b7c53f587c2ad526b/obp/dataset/synthetic_slate.py#L156

I think it is better to automatically generate exam_weight in the class (e.g./ $\theta(k) = 1/k$, $k$ is the position).
https://github.com/fullflu/zr-obp/blob/2a8b38b19698cb847eaa202b7c53f587c2ad526b/obp/dataset/synthetic_slate.py#L212-215

how about the following code?

        slot_weight_matrix = np.zeros((len_list, len_list))
        for position_ in np.arange(len_list):
            slot_weight_matrix[:, position_] = -1 / np.exp(
                np.abs(np.arange(len_list) - position_)
            )
        return slot_weight_matrix

instead of the current one below.
https://github.com/fullflu/zr-obp/blob/2a8b38b19698cb847eaa202b7c53f587c2ad526b/obp/dataset/synthetic_slate.py#L269-L278
[nits]

the error message should be updated (now it uses "-IPS")
https://github.com/fullflu/zr-obp/blob/2a8b38b19698cb847eaa202b7c53f587c2ad526b/obp/dataset/synthetic_slate.py#L210

"Calculate the marginal propensity score, i.e., the probability that an action is presented at a position."
https://github.com/fullflu/zr-obp/blob/2a8b38b19698cb847eaa202b7c53f587c2ad526b/obp/dataset/synthetic_slate.py#L283

"Actions sampled by a behavior policy."
https://github.com/fullflu/zr-obp/blob/2a8b38b19698cb847eaa202b7c53f587c2ad526b/obp/dataset/synthetic_slate.py#L324

"When n_actions and len_list are large, giving True to this parameter may lead to a large computational time."
https://github.com/fullflu/zr-obp/blob/2a8b38b19698cb847eaa202b7c53f587c2ad526b/obp/dataset/synthetic_slate.py#L314

"When True is given, actions are sampled by the uniform random behavior policy."
https://github.com/fullflu/zr-obp/blob/2a8b38b19698cb847eaa202b7c53f587c2ad526b/obp/dataset/synthetic_slate.py#L318

"when return_exact_uniform_pscore_item_position is True, behavior_policy_function must be specified"
https://github.com/fullflu/zr-obp/blob/2a8b38b19698cb847eaa202b7c53f587c2ad526b/obp/dataset/synthetic_slate.py#L495

"behavior_policy_logit_ has an invalid shape", "expected_reward_factual has an invalid shape"
https://github.com/fullflu/zr-obp/blob/2a8b38b19698cb847eaa202b7c53f587c2ad526b/obp/dataset/synthetic_slate.py#L513
https://github.com/fullflu/zr-obp/blob/2a8b38b19698cb847eaa202b7c53f587c2ad526b/obp/dataset/synthetic_slate.py#L559

Can you use np.arange(self.len_list), just to be consistent?
https://github.com/fullflu/zr-obp/blob/2a8b38b19698cb847eaa202b7c53f587c2ad526b/obp/dataset/synthetic_slate.py#L572

[must]

[ ] Please specify the output of the function. (and why does random_state come first?). Also, please explain what this function does.
https://github.com/fullflu/zr-obp/blob/2a8b38b19698cb847eaa202b7c53f587c2ad526b/obp/dataset/synthetic_slate.py#L581

[ ] "slot weighted" is very confusing. How about "reward function incorporating additive interactions among combinatorial action"?
https://github.com/fullflu/zr-obp/blob/2a8b38b19698cb847eaa202b7c53f587c2ad526b/obp/dataset/synthetic_slate.py#L601-602

[imo]

[ ] It may be better to rephrase it as n_unique_action. We also call the number of combinatorial actions as the number of actions, so we may want to differentiate these different concepts. How do you think?
https://github.com/fullflu/zr-obp/blob/2a8b38b19698cb847eaa202b7c53f587c2ad526b/obp/dataset/synthetic_slate.py#L156

[ ] I think it is better to automatically generate exam_weight in the class (e.g./ $\theta(k) = 1/k$, $k$ is the position).
https://github.com/fullflu/zr-obp/blob/2a8b38b19698cb847eaa202b7c53f587c2ad526b/obp/dataset/synthetic_slate.py#L69-L71
https://github.com/fullflu/zr-obp/blob/2a8b38b19698cb847eaa202b7c53f587c2ad526b/obp/dataset/synthetic_slate.py#L212-215

[ ] how about the following code?

        slot_weight_matrix = np.identity(len_list)
        for position_ in np.arange(len_list):
            slot_weight_matrix[:, position_] = -1 / np.exp(
                np.abs(np.arange(len_list) - position_)
            )
        return slot_weight_matrix
instead of the current one below.
https://github.com/fullflu/zr-obp/blob/2a8b38b19698cb847eaa202b7c53f587c2ad526b/obp/dataset/synthetic_slate.py#L269-L278

[ ] action_effect_matrix -> action_interaction_matrix

[ ] action_interaction_exponential_reward_function
https://github.com/fullflu/zr-obp/blob/2a8b38b19698cb847eaa202b7c53f587c2ad526b/obp/dataset/synthetic_slate.py#L709

[ ] action_interaction_matrix (which is the same wording as used in def action_effect_additive_reward_function()
https://github.com/fullflu/zr-obp/blob/2a8b38b19698cb847eaa202b7c53f587c2ad526b/obp/dataset/synthetic_slate.py#L714

[ ] the output should be named "expected_reward_factual"
https://github.com/fullflu/zr-obp/blob/2a8b38b19698cb847eaa202b7c53f587c2ad526b/obp/dataset/synthetic_slate.py#L800-L805

[ask]

[ ] I couldn't see why you are using separate words "action_effect_matrix" and "slot_weight_matrix" for the same concept. I think you should use only action_interaction_matrix for both.

[ ] I couldn't figure out why this is needed
https://github.com/fullflu/zr-obp/blob/2a8b38b19698cb847eaa202b7c53f587c2ad526b/obp/dataset/synthetic_slate.py#L263

[nits]

[ ] "... sampled based on ..."
https://github.com/fullflu/zr-obp/blob/2a8b38b19698cb847eaa202b7c53f587c2ad526b/obp/dataset/synthetic_slate.py#L64-66

[ ] the error message should be updated (now it uses "-IPS")
https://github.com/fullflu/zr-obp/blob/2a8b38b19698cb847eaa202b7c53f587c2ad526b/obp/dataset/synthetic_slate.py#L210

[ ] "Calculate the marginal propensity score, i.e., the probability that an action (specified by action_list) is presented at a position."
https://github.com/fullflu/zr-obp/blob/2a8b38b19698cb847eaa202b7c53f587c2ad526b/obp/dataset/synthetic_slate.py#L283

[ ] "Actions sampled by a behavior policy."
https://github.com/fullflu/zr-obp/blob/2a8b38b19698cb847eaa202b7c53f587c2ad526b/obp/dataset/synthetic_slate.py#L324

[ ] "When n_actions and len_list are large, giving True to this parameter may lead to a large computational time."
https://github.com/fullflu/zr-obp/blob/2a8b38b19698cb847eaa202b7c53f587c2ad526b/obp/dataset/synthetic_slate.py#L314

[ ] "When True is given, actions are sampled by the uniform random behavior policy."
https://github.com/fullflu/zr-obp/blob/2a8b38b19698cb847eaa202b7c53f587c2ad526b/obp/dataset/synthetic_slate.py#L318

[ ] "sampled_action"
https://github.com/fullflu/zr-obp/blob/2a8b38b19698cb847eaa202b7c53f587c2ad526b/obp/dataset/synthetic_slate.py#L358

[ ] "impute joint pscore"
https://github.com/fullflu/zr-obp/blob/2a8b38b19698cb847eaa202b7c53f587c2ad526b/obp/dataset/synthetic_slate.py#L393

[ ] "when return_exact_uniform_pscore_item_position is True, behavior_policy_function must be specified"
https://github.com/fullflu/zr-obp/blob/2a8b38b19698cb847eaa202b7c53f587c2ad526b/obp/dataset/synthetic_slate.py#L495

[ ] "sample actions and calculate pscores"
https://github.com/fullflu/zr-obp/blob/2a8b38b19698cb847eaa202b7c53f587c2ad526b/obp/dataset/synthetic_slate.py#L514

[ ] "behavior_policy_logit_ has an invalid shape", "expected_reward_factual has an invalid shape"
https://github.com/fullflu/zr-obp/blob/2a8b38b19698cb847eaa202b7c53f587c2ad526b/obp/dataset/synthetic_slate.py#L513
https://github.com/fullflu/zr-obp/blob/2a8b38b19698cb847eaa202b7c53f587c2ad526b/obp/dataset/synthetic_slate.py#L559

[ ] Can you use np.arange(, just to be consistent?
https://github.com/fullflu/zr-obp/blob/2a8b38b19698cb847eaa202b7c53f587c2ad526b/obp/dataset/synthetic_slate.py#L380
https://github.com/fullflu/zr-obp/blob/2a8b38b19698cb847eaa202b7c53f587c2ad526b/obp/dataset/synthetic_slate.py#L572

[ ] "muptiplied by" -> "times"
https://github.com/fullflu/zr-obp/blob/2a8b38b19698cb847eaa202b7c53f587c2ad526b/obp/dataset/synthetic_slate.py#L774

[ ] "Expected rewards given factual actions"
https://github.com/fullflu/zr-obp/blob/2a8b38b19698cb847eaa202b7c53f587c2ad526b/obp/dataset/synthetic_slate.py#L642
https://github.com/fullflu/zr-obp/blob/2a8b38b19698cb847eaa202b7c53f587c2ad526b/obp/dataset/synthetic_slate.py#L753

[ ] action_weight -> action_interaction_weight
https://github.com/fullflu/zr-obp/blob/2a8b38b19698cb847eaa202b7c53f587c2ad526b/obp/dataset/synthetic_slate.py#L791

@fullflu Thanks! Some additional comments... (WIP)
[ask]

Don't you need type hints?
https://github.com/fullflu/zr-obp/blob/18e8958509e0ce38286c16d28af7187d4e41b1b2/obp/dataset/synthetic_slate.py#L252
https://github.com/fullflu/zr-obp/blob/18e8958509e0ce38286c16d28af7187d4e41b1b2/obp/dataset/synthetic_slate.py#L263

[nits]

"Number of unique actions"
https://github.com/fullflu/zr-obp/blob/18e8958509e0ce38286c16d28af7187d4e41b1b2/obp/dataset/synthetic_slate.py#L34

"... which must be one of ..."
https://github.com/fullflu/zr-obp/blob/18e8958509e0ce38286c16d28af7187d4e41b1b2/obp/dataset/synthetic_slate.py#L50

It seems we cannot set this argument now
https://github.com/fullflu/zr-obp/blob/18e8958509e0ce38286c16d28af7187d4e41b1b2/obp/dataset/synthetic_slate.py#L106

we don't need exam_weight argument any more
https://github.com/fullflu/zr-obp/blob/18e8958509e0ce38286c16d28af7187d4e41b1b2/obp/dataset/synthetic_slate.py#L157

the function names should be like ...action_interaction_matrix(
https://github.com/fullflu/zr-obp/blob/18e8958509e0ce38286c16d28af7187d4e41b1b2/obp/dataset/synthetic_slate.py#L252
https://github.com/fullflu/zr-obp/blob/18e8958509e0ce38286c16d28af7187d4e41b1b2/obp/dataset/synthetic_slate.py#L263


Add TensorFlow support

Added TensorFlow support

Hi  @yu4u, I've added this changes in commit ccd5659, adding info about using the TensorFlow backend in the README/requirements.txt at the same time.
Thanks for helping this project!

Hi @asmith26, thank you very much for this great project and merging TensorFlow support with additional implementations!


Modal fixes needed

Modals need some reworking:

Need to support static modals (in page content) (#234)
Support rendered, but not visible modals (#242)
Rework the modal-open classname logic to use context
Support fade class
Ability to disable backdrop

Fixed in #244

Fixed in #244


IndexError in dimensionality reduction

I tried running the dimensionality reduction notebook with the LSI setting, but ran in the following error.

Tokenizing text, this will take a while...
Creating the gensim corpora, this will take a while...
Using gensim's implementation of TF-IDF, this will take a while...
Creating the LSI model, this will take a while...
Reformatting output to a 2D array, this will take a while...
---------------------------------------------------------------------------
IndexError                                Traceback (most recent call last)
 in ()
----> 1 train_x, test_x = gensim_preprocess(train, test, model_type='lsi', num_topics=500, report_progress=True, data_dir=DATA_ROOT)

~\Documents\JADS Working Files\JADS Kaggle\jads_kaggle\toxicity\preprocessing.py in wrap(*args, **kwargs)
     20     """
     21     def wrap(*args, **kwargs):
---> 22         train, test = f(*args, **kwargs)
     23         assert(train.shape[1] == test.shape[1])
     24         return train, test

~\Documents\JADS Working Files\JADS Kaggle\jads_kaggle\toxicity\utils.py in wrap(*args, **kwargs)
     16     def wrap(*args, **kwargs):
     17         start = time.time()
---> 18         ret = f(*args, **kwargs)
     19         stop = time.time()
     20         print('{} function took {:.1f} seconds to complete\n'.format(f.__name__, (stop - start)))

~\Documents\JADS Working Files\JADS Kaggle\jads_kaggle\toxicity\preprocessing.py in gensim_preprocess(train, test, model_type, num_topics, use_own_tfidf, force_compute, report_progress, data_dir, **tfidf_params)
    168     print("Reformatting output to a 2D array, this will take a while...")
    169     values = np.vectorize(lambda x: x[1])
--> 170     return values(np.array(train)), values(np.array(test))
    171
    172

~\Anaconda3\lib\site-packages\numpy\lib\function_base.py in __call__(self, *args, **kwargs)
   2753             vargs.extend([kwargs[_n] for _n in names])
   2754
-> 2755         return self._vectorize_call(func=func, args=vargs)
   2756
   2757     def _get_ufunc_and_otypes(self, func, args):

~\Anaconda3\lib\site-packages\numpy\lib\function_base.py in _vectorize_call(self, func, args)
   2829                       for a in args]
   2830
-> 2831             outputs = ufunc(*inputs)
   2832
   2833             if ufunc.nout == 1:

~\Documents\JADS Working Files\JADS Kaggle\jads_kaggle\toxicity\preprocessing.py in (x)
    167     # Transform into a 2D array format.
    168     print("Reformatting output to a 2D array, this will take a while...")
--> 169     values = np.vectorize(lambda x: x[1])
    170     return values(np.array(train)), values(np.array(test))
    171

IndexError: list index out of range

Oh I think I remember: There is a single corrupted row in test which causes this, I manually deleted it from the CSV and forgot to add it in the code. You can try to:
a) Replace lambda x: x[1] with a named function like:
def safe_get(x):
  try:
    return x[1]
  except IndexError:
    return None

b) Manually delete the bad line from the CSV (quick & dirty)

UPDATE
I tried to fix the issue and apparently it harder than I thought. the lsi module has a lot of trouble handling small documents, and many documents in our corpus contain less than 10 words.
We could exclude them but we are giving up too much information. Since I have very limited time, I propose we stick on the wider representations for now unless someone else can solve the bug.

Probably yes! The sklearn one might work out of the box

Alright, will take a look at it tonight.

UPDATE
It appears that the TF-IDF implementations were the problem. I now switched to sklearn's implementation of both TF-IDF and dimensionality reduction (TruncatedSVD, which is the same as LSA / LSI in this context) and it seems to work. It still uses the NLTK tokenizer. PR coming up, running one more test now.


Avoid loading all controllers for native interactive window

For https://github.com/microsoft/vscode-jupyter/issues/6466

Oops, need to make sure we don't register the same controllers twice

Codecov Report

Merging #6497 (52bb676) into main (e6e9257) will decrease coverage by 0%.
The diff coverage is 33%.

@@          Coverage Diff          @@
##            main   #6497   +/-   ##
=====================================
- Coverage     69%     69%   -1%
=====================================
  Files        410     410
  Lines      28241   28258   +17
  Branches    4184    4193    +9
=====================================
- Hits       19626   19623    -3
- Misses      6952    6970   +18
- Partials    1663    1665    +2

Impacted Files
Coverage Δ

...eractive-window/nativeInteractiveWindowProvider.ts
16% <0%> (-1%)
:arrow_down:

src/client/datascience/notebook/types.ts
100% <ø> (ø)

.../datascience/notebook/notebookControllerManager.ts
81% <38%> (-6%)
:arrow_down:

...ent/datascience/jupyter/pythonVariableRequester.ts
72% <0%> (-2%)
:arrow_down:

src/client/datascience/raw-kernel/rawSocket.ts
84% <0%> (-2%)
:arrow_down:

...rc/client/datascience/jupyter/debuggerVariables.ts
78% <0%> (-2%)
:arrow_down:

src/client/datascience/jupyter/jupyterNotebook.ts
75% <0%> (-1%)
:arrow_down:

src/client/datascience/baseJupyterSession.ts
70% <0%> (-1%)
:arrow_down:

...e-window/nativeInteractiveWindowCommandListener.ts
9% <0%> (-1%)
:arrow_down:

...ence/interactive-window/nativeInteractiveWindow.ts
6% <0%> (-1%)
:arrow_down:

... and 4 more


Feature Request: Be able to store config inside package.json

Thanks again for making this package!
Describe the Feature
At this time, a custom config could not (I think) be passed though CLI. You can only pass a config path (pointing to a JSON file). Why not parsed package.json and look for a sql-formatter key with config?
Why do you want this feature?
Convenience, simplicity + not having another config file...
Ex:
{
  "module": "index.ts",
  "type": "module",
  "scripts": {
    "format:sql": "npx sql-formatter  --fix some/folder/users.sql",
  },
  "devdependencies": {
    "sql-formatter": "^12.2.2",
  },
  "sql-formatter": {
    "language": "sqlite",
    "tabWidth": 3,
    "linesBetweenQueries": 3,
    "keywordCase": "upper",
    "indentStyle": "tabularLeft"
  },

Thanks again for the feature requests.
That's one of these features which on the surface seem almost trivial, but when you start digging into it, there's lots of questions to ponder:

how to locate this package.json file?
if there's no package.json in the current dir, should it look up through dir hierarchy?
if the package.json file doesn't contain an entry for sql-formatter, should one look for the next package.json upwards in dir hierarchy?

Much simpler to leave the answering of these questions to external tools, like using the formatter through a Prettier plugin, and letting Prettier handle all these concerns.
Therefore it's a feature which, although would be nice to have, is unlikely to be implemented.

Got it. Is there a prettier plugin? Thanks.


Improve test coverage.

Starting with core_tensor_product.py!

@mariogeiger what is the difference between tests/tensor_product_test.py and tests/core_tensor_product_test copy.py? Is this copy supposed to be committed?

Haha the " copy" is a mistake indeed. But the two files test different things. The "core" test the basic TP class while the other file test the subclasses made out of the basic class.


url

Generated urls are in format:
{% url post-delete post.id %}
should be:
{% url 'post-delete' post.id %}

This has been fixed.


Add unit tests for metrics::record

This PR adds unit tests for metrics::record, based on the benchmarks for the
same function. Currently, there is a test that fires a single response end event
and asserts that the metrics state is correct afterward, and a test that fires
all the events to simulate a full connection lifetime, and asserts that the
metrics state is correct afterward. I'd like to also add a test that simulates
multiple events with different labels, but I'll add that in a subsequent PR,
In order to add these tests, it was necessary to make some fields in metrics
structs pub so that the test can access them. These fields should only be
exposed within the metrics module, however. I also added some test-only
functions to metrics::Histograms, to make them easier to make assertions
about.

@olix0r, efa51aa7a5639b4e217a2271ad35116dd7c9811c and c368124e2231502a6ec2c01f4dcb95df669501ec make the changes you've requested.


Auto close stale PRs after 1 week

Uses https://github.com/probot/stale to close PRs after 1 week.

Testing automation


Reload all scenes button in editor

From the Facebook group discussion.
Please add reload all edited scenes button.
Thanks! :D

I upvote this, but would be better the reload working in individual scenes.

Why don't we have both? xD

Well, both would be even better =D

+1

Likely related to #2307.

With the various improvements made to scene and script reloading in 2.1, I believe this feature request is no longer relevant. Feel free to comment and ask me to reopen if you think it would still have an important use case.


Internal server error

Hi,
I tried to follow blog steps. when I hit to test the url http://buckect-endpoint/300x300/blue_marble.png it gives "Internal server error"
CloudWatch logs:
2017-10-18T07:27:12.465Z	bd79a0a4-b3d5-11e7-a577-a563b397b6dc	TypeError: Cannot read property '1' of null
at exports.handler (/var/task/index.js:15:31)

I had the same problem, and took me 3 hours to realize the f***ing problem.
If you follow the blog post: https://aws.amazon.com/blogs/compute/resize-images-on-the-fly-with-amazon-s3-aws-lambda-and-amazon-api-gateway/
In the test section the example url: http://YOUR_BUCKET_WEBSITE_HOSTNAME_HERE/500×500/blue_marble.jpg used unicode × character not x.
I tested by replacing only the YOUR_BUCKET_WEBSITE_HOSTNAME_HERE and copy paste everything after, so the regex in lambda code failed to match the pattern and returned null.

@mdk194 bundle of thanks. you are life saver. it worked like a charm. (Y)

That's is not the problem, in index.js  there is
  const match = key.match(/(\d+)x(\d+)\/(.*)/);   const width = parseInt(match[1], 10);   const height = parseInt(match[2], 10);   const originalKey = match[3];
for hadle url pattern, is x.

Glad you got this sorted! Must be an encoding issue on our blog.


RFC: Makefile, bash and python scripts for Validation CER plotting

See https://github.com/Shreeshrii/tesstrain-sanPlusMinus for the repo from which the sample data and plots are taken.
Currently plotting uses makefile, bash and python.

I want to change this to not use bash scripts.

There is still one problem with the Makefile.
The workflow should be:

make traineddata from all existing checkpoints
run lstmeval for traineddata below a certain threshhold for the validate list creating a validate log for each
concatenate the validate logs
plot

Currently, the traineddata is getting built from any new checkpoints since last run. I would like lstmeval to be run on these traineddata too. However, it is being run only on traineddata that were existing before the run.
Any suggestions on how to fix it.

IIUC (haven't tested this yet): You want log files based on traineddata files that are created with make -C ../ traineddata MODEL_NAME=ocrd to be included in $(FAST_VALIDATE_LOG_FILES)? The problem AFAICS is that you assign
FAST_DATA_FILES = $(sort $(wildcard ../data/$(MODEL_NAME)/tessdata_fast/*_[0-$(VALIDATE_CER)].[0-9]*.traineddata))
FAST_VALIDATE_LOG_FILES = $(subst tessdata_fast,tessdata_fast,$(patsubst %.traineddata,%.$(VALIDATE_LIST).log,$(FAST_DATA_FILES)))

at the beginning and this does not reflect the changed list of files. No ready solution but perhaps you could force reevaluation of the expanded variable by delegating to $(shell find) instead of $(wildcard)?

@kba $(shell find) instead of $(wildcard) is also giving same result. Still need to run the makefile twice.
I have added comments to the makefile and also uploaded the plots from ocrd run.
@stweil Any suggestions on how to fix the need to run make 2 times?


HDFS-17239. Remove logging of method removeReplicaFromMem which is in…

Description of PR
In method FsDatasetImpl#removeReplicaFromMem,  there exists some loggings in the range of BLOCK_POOl write lock.  We should move them out of write lock.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 39s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+0 :ok:
detsecrets
0m  1s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

-1 :x:
test4tests
0m  0s

The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
45m 26s

trunk passed

+1 :green_heart:
compile
1m 21s

trunk passed with JDK Ubuntu-<IP_ADDRESS>+1-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
compile
1m 14s

trunk passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
checkstyle
1m 11s

trunk passed

+1 :green_heart:
mvnsite
1m 34s

trunk passed

+1 :green_heart:
javadoc
1m  8s

trunk passed with JDK Ubuntu-<IP_ADDRESS>+1-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
1m 40s

trunk passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
spotbugs
3m 29s

trunk passed

+1 :green_heart:
shadedclient
36m 10s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
1m 13s

the patch passed

+1 :green_heart:
compile
1m 17s

the patch passed with JDK Ubuntu-<IP_ADDRESS>+1-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javac
1m 17s

the patch passed

+1 :green_heart:
compile
1m  9s

the patch passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
javac
1m  9s

the patch passed

-1 :x:
blanks
0m  0s
/blanks-eol.txt
The patch has 1 line(s) that end in blanks. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply

-0 :warning:
checkstyle
1m  3s
/results-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs-project/hadoop-hdfs: The patch generated 2 new + 52 unchanged - 0 fixed = 54 total (was 52)

+1 :green_heart:
mvnsite
1m 12s

the patch passed

+1 :green_heart:
javadoc
0m 56s

the patch passed with JDK Ubuntu-<IP_ADDRESS>+1-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
1m 35s

the patch passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

-1 :x:
spotbugs
3m 26s
/new-spotbugs-hadoop-hdfs-project_hadoop-hdfs.html
hadoop-hdfs-project/hadoop-hdfs generated 2 new + 0 unchanged - 0 fixed = 2 total (was 0)

+1 :green_heart:
shadedclient
35m  9s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

-1 :x:
unit
232m 52s
/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs in the patch passed.

+1 :green_heart:
asflicense
0m 48s

The patch does not generate ASF License warnings.

375m 35s

Reason
Tests

SpotBugs
module:hadoop-hdfs-project/hadoop-hdfs

Possible null pointer dereference of info in org.apache.hadoop.hdfs.server.datanode.fsdataset.impl.FsDatasetImpl.removeReplicaFromMem(ExtendedBlock, FsVolumeImpl)  Dereferenced at FsDatasetImpl.java:info in org.apache.hadoop.hdfs.server.datanode.fsdataset.impl.FsDatasetImpl.removeReplicaFromMem(ExtendedBlock, FsVolumeImpl)  Dereferenced at FsDatasetImpl.java:[line 2466]

Possible null pointer dereference of v in org.apache.hadoop.hdfs.server.datanode.fsdataset.impl.FsDatasetImpl.removeReplicaFromMem(ExtendedBlock, FsVolumeImpl)  Dereferenced at FsDatasetImpl.java:v in org.apache.hadoop.hdfs.server.datanode.fsdataset.impl.FsDatasetImpl.removeReplicaFromMem(ExtendedBlock, FsVolumeImpl)  Dereferenced at FsDatasetImpl.java:[line 2483]

Failed junit tests
hadoop.hdfs.TestFileChecksum

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6225/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/6225

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux 0ff674c3a6bf 4.15.0-213-generic #224-Ubuntu SMP Mon Jun 19 13:30:12 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / f5d4830108c4e6f9e9b6cfb734e7db46cb4369e8

Default Java
Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-<IP_ADDRESS>+1-post-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6225/1/testReport/

Max. process+thread count
3354 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6225/1/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 37s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+0 :ok:
detsecrets
0m  1s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

-1 :x:
test4tests
0m  0s

The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
45m 39s

trunk passed

+1 :green_heart:
compile
1m 21s

trunk passed with JDK Ubuntu-<IP_ADDRESS>+1-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
compile
1m 17s

trunk passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
checkstyle
1m 13s

trunk passed

+1 :green_heart:
mvnsite
1m 27s

trunk passed

+1 :green_heart:
javadoc
1m 11s

trunk passed with JDK Ubuntu-<IP_ADDRESS>+1-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
1m 37s

trunk passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
spotbugs
3m 15s

trunk passed

+1 :green_heart:
shadedclient
34m 49s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
1m 10s

the patch passed

+1 :green_heart:
compile
1m 13s

the patch passed with JDK Ubuntu-<IP_ADDRESS>+1-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javac
1m 13s

the patch passed

+1 :green_heart:
compile
1m  6s

the patch passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
javac
1m  6s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
1m  1s

the patch passed

+1 :green_heart:
mvnsite
1m 16s

the patch passed

+1 :green_heart:
javadoc
0m 54s

the patch passed with JDK Ubuntu-<IP_ADDRESS>+1-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
1m 28s

the patch passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

-1 :x:
spotbugs
3m 19s
/new-spotbugs-hadoop-hdfs-project_hadoop-hdfs.html
hadoop-hdfs-project/hadoop-hdfs generated 2 new + 0 unchanged - 0 fixed = 2 total (was 0)

+1 :green_heart:
shadedclient
35m 36s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
221m 14s

hadoop-hdfs in the patch passed.

+1 :green_heart:
asflicense
0m 51s

The patch does not generate ASF License warnings.

362m 50s

Reason
Tests

SpotBugs
module:hadoop-hdfs-project/hadoop-hdfs

Possible null pointer dereference of info in org.apache.hadoop.hdfs.server.datanode.fsdataset.impl.FsDatasetImpl.removeReplicaFromMem(ExtendedBlock, FsVolumeImpl)  Dereferenced at FsDatasetImpl.java:info in org.apache.hadoop.hdfs.server.datanode.fsdataset.impl.FsDatasetImpl.removeReplicaFromMem(ExtendedBlock, FsVolumeImpl)  Dereferenced at FsDatasetImpl.java:[line 2466]

Possible null pointer dereference of v in org.apache.hadoop.hdfs.server.datanode.fsdataset.impl.FsDatasetImpl.removeReplicaFromMem(ExtendedBlock, FsVolumeImpl)  Dereferenced at FsDatasetImpl.java:v in org.apache.hadoop.hdfs.server.datanode.fsdataset.impl.FsDatasetImpl.removeReplicaFromMem(ExtendedBlock, FsVolumeImpl)  Dereferenced at FsDatasetImpl.java:[line 2484]

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6225/3/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/6225

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux 46a2b635c24a 4.15.0-213-generic #224-Ubuntu SMP Mon Jun 19 13:30:12 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 37b4aa99e0981a18a4880d53f30de558aa7fca9d

Default Java
Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-<IP_ADDRESS>+1-post-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6225/3/testReport/

Max. process+thread count
3558 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6225/3/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.


Tutorials should be cross-referenced in the examples

Tutorials are also examples with more explanation. It would be great if they also filled the gallery for ease of searching in one common space.

Thinking about how sphinx-gallery works, I have a feeling that this will be more work than it's worth. But if we want to do it, we should implement it there. I'll close this for now, and if there is interest in doing it, I'd say open a sphinx-gallery issue and get feedback there.


add help implementation by using gulp-help-doc

add help implementation using by gulp-help-doc
Usage: gulp [task] [options]
Tasks:

@daehyunjimmy We are using gulp internal but users(some developers) will use our |absolute| command.
So, it should be displayed as "absolute" instead of "gulp".


Add ESLint configuration to create-react-app project

Issue description
The default project created with "dotnet new reactredux" contains  a number of ESLint warnings (eg: "Component definition is missing display name" in App.js) causing most of the files to be highlighted in green or red in Visual Studio (2017 Version 15.8.6).
Please review and correct the warning and errors OR add a working configuration file for ESLint that works better with the create-react-app project.
Software versions
Check the .NET target framework(s) being used, and include the version number(s).

[x] .NET Core 2.1.402
[ ] .NET Framework
[ ] .NET Standard

Re-logged in the appropriate repository: https://github.com/aspnet/Templating/issues/769


Now i really went into the rabbit hole of web development

will this rerender??????????

i think it did


zefoy.com not updated in a while

the site says it will soon be updated, the others were already updated last week.
follows, likes and shares are not working/were still not updated. while follows are most important next to views, likes too.
do you know when it willl appproximately be updated?

Clearly stated in the README that this is just an automation. I don't own anything or control anything on Zefoy.

Yes, I know, but it's just updating the same things, and I need followers 😭
I will use another bot.


Layout Names Clashes

I had a layout in my project named text_bubble.xml
Trying to instantiate ClusterManager causes an exception,
since you use a layout by the same name,

I agree that it would be a good idea to use a namespace prefix (e.g. amu_) for resources.

Fixed in #264


Add events query resolver

As discussed in https://github.com/interledger/rafiki/pull/228#issuecomment-1036244056
Support wallets handling (and/or reconciling missed) events via an events query resolver.
Support pagination as well as querying by event type.
This can allow failed webhook event delivery attempts to not be retried.

related https://github.com/interledger/rafiki/issues/382


[MOO-844]: Add a new option to rollup plugin

Checklist

Contains breaking changes ❌
Did you update version and changelog? ✅

This PR contains

[ ] Bug fix
[ ] Feature
[ ] Refactor
[ ] Documentation
[x] Other (describe)

What is the purpose of this PR?
When a new widget is created, the size of the dependencies file is quite large (more than 1MB). Most dependencies are added because of a peer dependency of pluggable-widget-tools in piw-native-utils-internal. To reduce the generated dependencies file size, provide a new option to exclude the pluggable-widget-tools dependency from the dependencies file.
Relevant changes
Provided a new option to rollup plugin to exclude dependencies from the generated dependencies list file.
What should be covered while testing?
When a widget is created using the release script, it should generate a dependencies list file that excludes the dependencies given in the option.

@UrazAkgultan Can you explain why piw-native-utils-internal needs to use pluggable-widgets-tools as a peer dependency instead of a dev dependency? No widget should ever rely on pluggable-widgets-tools at runtime.


Best strategy for caching/persisting impersonation tokens between calls?

Not really an issue, but more a question :) Was thinking to post on SO first, but decided this is a more appropriate place for such a question...
I have a code running in a loop repeatedly many times, doing some work not requiring impersonation. The result is the IO File operation that I only want to do impersonated. When I do wrap this particular operation in an impersonated call it takes a lot of time since I assume it requests a token with each loop iteration. Putting the whole loop inside the impersonation makes the whole thing look ugly, especially that it's not the only such a scenario in my code... I was hoping to do as less as possible code impersonated since it's a user with kind of elevated privileges.
I was thinking about putting the impersonator to a different dedicated thread/process and keeping it open, waiting for new tasks... Then read about problems with asynchronous tasks and found this relative fresh solution (from links in #32).
Do you have any suggestions for the best strategy in my case? What do u think about asynchronous task scheduler I posted above?

Decided to ask on SO. Closing the issue.