[CocoaPods] Add podspec

Compare with https://github.com/firebase/leveldb-library-podspec:

Why the HEADER_SEARCH_PATHS change?
Would you add a pod lib lint test to CI?

Yep, working on the CI stuff..

Why the HEADER_SEARCH_PATHS change?

This was tricky to figure out. With the old diff, the library would not build due to missing header errors.

The values passed to HEADER_SEARCH_PATHS in the podspec can be seen in the above command. I added the path with foo (via '"${PODS_ROOT}/leveldb-library/foo" ') to track down where how the PODS_ROOT gets expanded. Here's them in a formatted snippet:
<-- snip -->
-I/var/folders/hz/7v68p4h95sb2ypb614xp20jc00r7sc/T/CocoaPods-Lint-20240125-29599-16udks9-leveldb-library/Pods/leveldb-library \
-I/var/folders/hz/7v68p4h95sb2ypb614xp20jc00r7sc/T/CocoaPods-Lint-20240125-29599-16udks9-leveldb-library/Pods/leveldb-library/foo \
-I/var/folders/hz/7v68p4h95sb2ypb614xp20jc00r7sc/T/CocoaPods-Lint-20240125-29599-16udks9-leveldb-library/Pods/leveldb-library/include
<-- snip -->

But those directories do not exist:
ls: /var/folders/hz/7v68p4h95sb2ypb614xp20jc00r7sc/T/CocoaPods-Lint-20240125-29599-16udks9-leveldb-library/Pods/leveldb-library: No such file or directory

Here's the tree of that parent directory for this non-existent path:
/var/folders/hz/7v68p4h95sb2ypb614xp20jc00r7sc/T/CocoaPods-Lint-20240125-29599-16udks9-leveldb-library/Pods/
├── Headers
├── Local Podspecs
│   └── leveldb-library.podspec.json
├── Manifest.lock
├── Pods.xcodeproj
│   ├── project.pbxproj
│   └── xcuserdata
│       └── nickcooke.xcuserdatad
│           └── xcschemes
│               ├── Pods-App.xcscheme
│               ├── leveldb-library.xcscheme
│               └── xcschememanagement.plist
└── Target Support Files
    ├── Pods-App
    │   ├── Pods-App-Info.plist
    │   ├── Pods-App-acknowledgements.markdown
    │   ├── Pods-App-acknowledgements.plist
    │   ├── Pods-App-dummy.m
    │   ├── Pods-App-frameworks.sh
    │   ├── Pods-App-umbrella.h
    │   ├── Pods-App.debug.xcconfig
    │   ├── Pods-App.modulemap
    │   └── Pods-App.release.xcconfig
    └── leveldb-library
        ├── leveldb-library-Info.plist
        ├── leveldb-library-dummy.m
        ├── leveldb-library-prefix.pch
        ├── leveldb-library-umbrella.h
        ├── leveldb-library.debug.xcconfig
        ├── leveldb-library.modulemap
        └── leveldb-library.release.xcconfig

9 directories, 22 files

Interestingly, there is an empty Headers directory. But in any case, there are no product headers anywhere to be found, which explains the missing header errors.
I looked at what Firebase podspecs do, and they use the PODS_TARGET_SRCROOT macro instead, so I made that change and it worked.
On my machine, this gets resolved to -I/Users/nickcooke/Developer/leveldb which is my local clone and contains the sources.
I suspect this has something to do with the old diff pointing to sources outside of the repo containing the podspec. That was the only significant different I could think of.

Interesting.  Presumably the old podspec never tested with pod lib lint. And could be related to a difference between Pods and Development Pods. We'll need to make sure that the RTDB and Firestore leveldb references still work after staging the podspec.

Post merge, I will tag CocoaPods-1.22.3 and push to specs staging.

Pushed a tag, but ran into problems staging the pod:
pod repo push --skip-tests --use-json --skip-import-validation --verbose staging leveldb-library.podspec

<-- skip -->
[!] The `leveldb-library.podspec` specification does not validate.

/Users/nickcooke/.gem/ruby/2.7.4/gems/cocoapods-1.14.2/lib/cocoapods/command/repo/push.rb:156:in `block in validate_podspec_files'
/Users/nickcooke/.gem/ruby/2.7.4/gems/cocoapods-1.14.2/lib/cocoapods/command/repo/push.rb:140:in `each'
/Users/nickcooke/.gem/ruby/2.7.4/gems/cocoapods-1.14.2/lib/cocoapods/command/repo/push.rb:140:in `validate_podspec_files'
/Users/nickcooke/.gem/ruby/2.7.4/gems/cocoapods-1.14.2/lib/cocoapods/command/repo/push.rb:81:in `run'
/Users/nickcooke/.gem/ruby/2.7.4/gems/claide-1.1.0/lib/claide/command.rb:334:in `run'
/Users/nickcooke/.gem/ruby/2.7.4/gems/cocoapods-1.14.2/lib/cocoapods/command.rb:52:in `run'
/Users/nickcooke/.gem/ruby/2.7.4/gems/cocoapods-1.14.2/bin/pod:55:in `<top (required)>'
/Users/nickcooke/.gem/ruby/2.7.4/bin/pod:25:in `load'
/Users/nickcooke/.gem/ruby/2.7.4/bin/pod:25:in `<main>'

Will investigate tomorrow...

It appears I needed to quit Xcode 15 before xcode-selecting Xcode 14.1.

@ncooke3 I'm able to run pod spec lint leveldb-library.podspec --verbose --skip-import-validation successfully with Xcode 15.2


AnimeUnity

Source name
AnimeUnity
Source link
https://www.animeunity.tv
Language
Italian
Other details
No response
Acknowledgements

[X] I have searched the existing issues and this is a new ticket, NOT a duplicate or related to another open issue.
[X] I have written a title with source name.
[X] I have checked that the extension does not already exist on the website extensions list or the app.
[X] I have checked that the extension does not already exist by searching the GitHub repository and verified it does not appear in the code base.
[X] I will fill out all of the requested information in this form.

closed by #1188


[Epic] Load reader ASTs only when a non-null parent object is encountered

Developers should be able to mark certain parent fields that are likely to be null or certain child fields that are expensive with e.g. directives or pipes or something in isograph literals. Examples:

field User.DetailComponent @component {
  best_friend @likelyToBeNull {
    BestFriendDisplay
  }
  worst_enemy {
    WorstEnemyVideoPlayer @expensive
  }
}

The behavior in the above situation is as follows. The BestFriendDisplay and WorstEnemyVideoPlayer reader ASTs are lazily loaded (i.e. () => import(...)), i.e. not hard required in the User.DetailComponent reader AST.
Instead, the normalization artifact will have the reader ASTs we must load when we encounter a non-null best_friend/worst_enemy. Upon receiving data that makes these fields non-null, we start a network request for these readers. When complete, we write the resulting BestFriendDisplay (etc) into the store into a field that never gets GC'ed (probably).
The readers will suspend if they encounter a not-yet-loaded BestFriendDisplay etc
Readers should also be able to fall back to loading this. At minimum, readers need to also keep track of the nested components that are lazily dependent.
When we modify data in the store, we run through each subscription and get encountered records. When we re-read those fragments, we also check and potentially run the function to import.
Special __asConcreteType fields that refine to a concrete type should also be valid parents, in which case the above works iff the parent object exists and has the right type. So, we get Relay 3D.

This is doable with @loadable(lazyLoadArtifact: true) right now, but it's an annoying workaround


This PR adds support for Laravel 10.0

Upgrade "illuminate/support": "^9.0|^10.0"
Upgrade "phpunit/phpunit": "^10.0"

Thanks!


Enable SSL options

Description
Hi, I need to know if is possible add SSL cert for enable https in container.
Priority
High (App breaking feature)

Hello,
You can put homarr behind a reverse proxy service like Nginx and Traefik that will do that exactly.
Those tools allow you to do that with every app you have on your server and also protect them with security services like Authelia or authetik.

You have some example for testing ?? or example how can deploy that security.

They are installed the same way as homarr.
You may find more information about those by googling the names I provided.


Upgrade PyO3 0.21

To upgrade to pyo3 version 0.21, we need to use pyo3-async-runtime instead of pyo3-asyncio since pyo3-asyncio is not actively maintained at the moment.
Ref: https://github.com/PyO3/pyo3-async-runtimes

Now we need to upgrade to the new version of pyo3 along with pyo-async-runtimes.


Specification is out of date

The website still lists the 3.0.0 specification as the latest, which is a particular problem as 3.0.1 has important differences.

Done


Validate Token For Access

Is it possible to have a rest call to check if token is still valid?
Thanks

I think /check_token in the Spring Security OAuth framework should do that for you. The docs aren't too clear, let me know how it goes.

i tryied to use it, but without success, for now when i want to validate token i did a get rest call like this
If it returns response code 200, token is valid
"http://localhost:8083/v1.0.M1/dataPoints?schema_namespace=omh&schema_name=physical-activity&schema_version=1.0"


Nanopore 16S read preprocessing

Hello,
Thank you for this tool, its incredibly useful! I have a quick question about whether it is necessary to perform any quality control steps after basecalling before using the EMU tool.
Currently, I have been using super accurate basecalled reads from MinKNOW straight into EMU but I was wondering if you recommend any QC steps prior to using EMU that filter based on read length or polish the reads before classifying them. I was curious whether this is necessary or if this is something the tool does not need as it will be aligning the reads prior to classification.
All the best
James

Hi,
It's difficult to quantify this. In our simulated experiments, we found results to be better without any QC steps we explored. However, these simulated reads do not take into account the complications that arise with real sequences. Emu inherently does a bit of classification correction with its algorithm, but of course, the more accurate the reads and database are, the better. So, if you have a particular liking to certain QC steps/software, go for it (especially chimera detection, since Emu doesn't do anything for this). If your reads seem adequate without it (reasonable lengths/q scores), then I do not think further QC is needed.

Hi,
Thank you so much for your fast reply. I'm going to have a look at the quality of my reads and see if it looks like they would benefit from filtering before running through EMU. Is it interesting for you to know if I see a difference in the taxonomy recovered with and without QC filtering? I have sequenced the zymobiomics mock community and I'm happy to share the results of how well we recover the taxonomy if this is of interest.
Thanks again, all the best

Yes, if you generate results to share, I'm sure they would be appreciated by the community. Thank you!


kubelet balks at certain repo url formats in .dockercfg

I'm running kubernetes on a private cloud in-conjunction with my company's quay.io repository and I've noticed that kubelet was failing create my pod templates because it was having auth issues when attempting to pull down images.
This confused me, since the .dockercfg I'd made available to kubelet was indeed being picked up by the process, and was working fine externally - by this I mean I could use it to manually pull down the same images ok.
Problematic .dockercfg:
{
"https://quay.io/v1/": { ... }
}

I thought the v1 stood out so I checked quay.io's documentation, found no mention of it and so removed it
{
"https://quay.io/": { ... }
}

This .dockercfg continued to auth correctly with the docker client and also now allowed kubelet to create my pod templates. :+1:
I'd expect to see consistency here: if a .dockercfg is good for manually pulling down images, then I'd expect it to also work for kubelet. Please shout or close this issue if there is a reason why this is not the case.
I'd like to try and submit a PR for this if I find time this week; I thought I'd raise this issue incase anyone stumbled upon this discrepancy in the meantime.
Ioan

It looks like the docker client uses whatever you pass to "docker login":
https://github.com/docker/docker/blob/0f5eba68fbe4904090532a709e7f3769059bc0aa/api/client/commands.go
Quay.io seems to document "docker login quay.io" (no v1), can you confirm this changes how it is written out?
http://docs.quay.io/solution/getting-started.html
That said, the way the DockerPuller resolves images should likely be reconciled with the logic here:
https://github.com/docker/docker/blob/8b95ad230e2ee76450ceb9a80aa8e942a56bb397/registry/auth.go#L451
Feel free to assign to me, and I'll try to submit a PR in the next few days.

@mattmoor, unfortunately I cannot assign it to you directly, but thank you for looking into this, and a PR is very welcome.

@bcwaldon FYI, since this is in the code for looking up a credential on the keyring.

FYI: https://github.com/GoogleCloudPlatform/kubernetes/pull/3813

Just merged the fix for this.  Closing.

Sweet, thanks @mattmoor :bow: :star:


Fixed README file

Relevant Issue (if applicable)
n/a
Details
The README file was incorrect and has been fixed.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Cannot select Dialog content if ActionTrigger is in a Table Cell

🐛 Bug Report
When a Dialog is opened via an ActionTrigger which is inside a Table Cell (ouch...), the text content of the Dialog cannot be selected anymore.
Check https://react-spectrum.adobe.com/react-spectrum/DialogTrigger.html#fullscreen, open the Dialog, you can select the text. If the button is in a table, you cannot select the text.
🤔 Expected Behavior
Text should be selectable in any cases.
😯 Current Behavior
No error, just impossible to select.
💁 Possible Solution
Each time you click to select content, the <html> DOM element is updated with user-select: none; which kills the selection. There is a conflict somewhere between that selection logic, the Table and the Dialog. I cannot help more.
🔦 Context
I am build a debugging tool with a large table, each row has it own buttons to view more details. Since these are logs, end-user must be able to copy/paste the dialog content.
It was working fine with my app in react-spectrum-v2.
💻 Code Sample
Created a full sample here: https://github.com/kptdobe/react-spectrum-dialog
Lines of interest are: https://github.com/kptdobe/react-spectrum-dialog/blob/master/src/App.js#L21-L52
🌍 Your Environment

Software
Version(s)

react-spectrum
3.0.0

Browser
Chrome

Operating System
MacOS

🧢 Your Company/Team
Adobe - Helix team
🕷 Tracking Issue
Migrating from react-spectrum v2 to react-spectrum v3: https://github.com/kptdobe/helix-tracedebug/issues/13

I'm not too sure what would be causing this to only happen in this scenario. Probably next step would be to try it out in a storybook example so that it can be debugged within our codebase.

@dannify I created a storybook example that showcase the issue: https://github.com/kptdobe/react-spectrum/pull/1/files
<EMAIL_ADDRESS>contains a table with one single row - hitting the button in that row opens a fullscreen dialog. Once the dialog is opened, you cannot try to select its content: impossible!
Tell me if you need more and thanks for checking.

Thanks @kptdobe this is helpful. It seems to be an issue with onPress. I'll see what I can dig up.

It looks like this was addressed at some point, I cannot reproduce any longer
https://codesandbox.io/s/snowy-sun-ribu6i
If it's still happening, feel free to re-open with a sandbox demonstrating the failure.


Fix apply_patch with missing find_eol_converter

Codecov Report
Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 73.68%. Comparing base (a86043d) to head (a56a83b).

Files
Patch %
Lines

gen-pack
0.00%
1 Missing :warning:

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #62      +/-   ##
==========================================
- Coverage   73.77%   73.68%   -0.10%
==========================================
  Files           7        7
  Lines         797      798       +1
==========================================
  Hits          588      588
- Misses        209      210       +1

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Update get.sh to accept customized SDK when provided regardless of SDK_RESOURCE

Background
When we are using two labels (one for ci.adopt and another for urv) in the same Jenkins template file, we face a problem posed by SDK_RESOURCE='upstream'. For running tests with IBM SDK, we need SDK_RESOURCE='customized' and SDK_URL=<path_to_the_sdk>. However, with the way get.sh was scripted, when SDK_RESOURCE='upstream', SDK_URL is ignored. We need to update the logic in get.sh to honour SDK_URL when a value is provided in it.

https://github.com/AdoptOpenJDK/openjdk-tests/pull/260

PR merged. Closing this Issue at this point.


Excessive number of API requests

YTSM seems to be generating an excessive number of API requests for me, to the point where I cannot add any additional subscriptions as my 10000 request/day limit is quickly reached. I have my synchronization schedule set as such
0 0 * * *

Which if I understand correctly should just be triggering once a day. I only have around 30-40 subscriptions, which doesn't seem like a lot. I'm not sure what is causing the high number of requests.

I think I found the source of the bug in the synchronization code. During synchronization, one of the steps is to update the statistics of the videos (play count, ratings). The bug is at this exact line, which makes it reiterate videos more than once.
The line for video in itertools.chain(work_vids, self.__new_vids): should actually read
for video in batch:.
I will submit a fix soon. If you don't care at all about these video statistics, you can modify this file manually and set _ENABLE_UPDATE_STATS = False.

Thinking about it, I think that may not be the problem. In that for loop, there is no YtAPI call. The problem may simply be that it tries to update the statistics for a few thousand videos every day, which is the reason why you are reaching the limit.
Disabling that 'update stats' field will probably fix the issue, but you won't get any video statistics any more.
I think the solution would be to be more conservative about updating video statistics. For big channels, the general trend is that videos generate the most views in the first couple of days, after which views slow down. So I think updating statistics less frequently for older videos is probably the best approach.


alloc: update memory allocation pointer type from NonZeroUsize to NonNull in ByteAllocator trait

This pull request updates the memory allocation pointer type from NonZeroUsize to NonNull in the ByteAllocator trait of the Rust open-source operating system project.
Motivation/Improvement Reason:

The NonZeroUsize type can represent memory page numbers, allocation sizes, or offsets, which can be ambiguous in terms of semantics. Using NonNull provides a more accurate representation of returning a pointer to a memory segment.
Previously, both the tlsf and buddy libraries required conversion from NonZeroUsize to NonNull. After this change, only the slab library needs to perform the conversion.
The Rust standard library's core::alloc::Alloc also uses NonNull.

This PR modifies the ByteAllocator trait and its implementations to use NonNull as the memory allocation pointer type. The changes include updating the return type of the alloc method to AllocResult<NonNull>, and the parameter type of the dealloc method to NonNull

Thanks! Please fix CI.

After using NonNull<u8> instead of NonZeroUsize, the crate attributes #![feature(strict_provenance)] can be removed. Could you find all the attributes and remove them?


added first visitor implementation, with example & unit tests

What is missing so far:

visiting of properties
more unit tests
more docu
CI integration of examples

Remark: with this commit, VS2013 is not supported anymore,
because of some obscure bug (declaration of nested visitor class not found)
So VS2015 is the new minimum supported compiler
Additional changes has to be done (docu, CI)
The PR is not yet ready, some commits will follow

Coverage decreased (-0.3%) to 92.826% when pulling c366bf7a22719a011b6238f107c42fab3e5d3b31 on acki-m:feature-add-visitor-mechanism into 07c3c94275e2bde73f6da8e572eb463af4202721 on rttrorg:master.

Coverage decreased (-0.3%) to 92.826% when pulling c366bf7a22719a011b6238f107c42fab3e5d3b31 on acki-m:feature-add-visitor-mechanism into 07c3c94275e2bde73f6da8e572eb463af4202721 on rttrorg:master.

@ArnCarveris
Sure, you get the whole static type information. But what do you want to do with it?


Add SIG osm for overseeing changes for userdata and cloudprovider

Signed-off-by: Waleed Malik<EMAIL_ADDRESS>What this PR does / why we need it:
At the moment, machine-controller and OSM have duplications mainly for cloudprovider and userdata. In order to ensure that both of them are in-sync we have created this SIG that can take care of this synchronization.
Which issue(s) this PR fixes (optional, in fixes #<issue number> format, will close the issue(s) when PR gets merged):
Fixes #
Special notes for your reviewer:
Optional Release Note:

NONE

/hold blocked by https://github.com/kubermatic/infra/pull/1612

/unhold

/run pull-machine-controller-e2e-aws-spot-instance

/retest

/retest


fix RunCmd and ListCmd types

quick fix to the types of interfaces returned by ListCmd and RunCmd -- shouldn't affect many end users because it's mainly just handled internally by redux-loop, but options gets spread so args wouldn't exist inside of an options object here for example:
  return Object.freeze({
    [isCmdSymbol]: true,
    type: cmdTypes.RUN,
    func,
    ...options
  })

good catch!

@willisplummer forgot to mention this before, but in the future, can you use the rebase and merge option rather than create a merge commit? i feel like merge commits just make the history harder to scroll through.
doesn't matter for this time, but in general I'd rather have that be the norm.

👍 @bdwain could also enable to squash merge feature?

sweet i didn't know about that option


Remove ApplicationInsights.config from VisualStudio.gitignore

Reasons for making this change:
Commit a25589c92187674f68dcfafe8433e0c1e6069159 introduced an ignore line for ApplicationInsights.config. This change breaks builds on certain systems, namely VSTS.
The current ASP.NET 4 template adds ApplicationInsights.config to the project's .csproj file. When VSTS attempts to build the project, it will fail if it cannot find ApplicationInsights.config.
ApplicationInsights.config is a required application file and should not be ignored.
Links to documentation supporting these rule changes:
https://azure.microsoft.com/en-us/documentation/articles/app-insights-start-monitoring-app-health-usage/#ide

@aholmes thanks for this!

And thank you!


PlayerJoinEvent error

Info

Server version: Paper 1.12.2, build 1513
OldCombatMechanics version: 1.6.6
Server log file: /
OldCombatMechanics config file: https://hastebin.com/orazukoyud.bash

Problem Description

Just got this error after a player connected to the server https://hastebin.com/oliragilev.cs

Just realized that this was already reported, #208
Could the plugin TAB be the cause of this?
[21:26:47] [Server thread/INFO]: [TAB] Failed to create packet_handler for PLAYER, retrying...

Can you try #210, you can find it over on my fork of this repo, but I will attach a compiled version for you.
OCM.zip

Yup. Just from a brief testing, it seems to be fixed.

Has this issue been resolved? If so, please close this issue report.

Yup, my bad


Some Descent fixes

Removed card component references in some actions
Attack actions: all phases are iterated through, but there's not always a reaction available. Fixed to always allow ending a phase without taking another action (and this is handled correctly to move to next phase).
Added some more descriptive strings for attack actions for debugging
Removed dice references in TombleCopyDefence action that doesn't actually use the stored references, unnecessary
TriggerAttributeTest does not need to set itself in progress again after another action is done.
SwapOrder keeps action reference, should copy it properly
RerollAttributeTest needs to remove the test that was done by a figure when executing, because tests have a check for only being allowed to be done once per turn. Figure stores attribute tests in a list now, removing the last one added when a reroll is triggered to allow the test to be done again.

This removes crashes related to attribute tests and attack actions.
Still to investigate: Jain Fairwood seems to take infinite turns, something is not triggered properly, potentially in some associate ability. To check if this happens with other heroes too.

This seeems great.
I did have a fix for RerollAttributeTests but that felt a lot more 'hacky' than your solution, so I shall rectify that and implement your version instead.
Thanks again!


[question] drive list -r

what does -r=false: recursively list subdirectories flag do?
when i use, it doesn't make any changes to output :confused:
aytac@manjaro ~/grive$ drive version
drive version: 0.2.1
Commit Hash: '56c6eb5fe5c8a20f68363f3e8d67ecca463a3419'
Go Version: go1.4.2
OS: linux/amd64

aytac@manjaro ~/grive$ drive list
/foo
/bar
/baz
/qux
aytac@manjaro ~/grive$ drive list -r
/foo
/bar
/baz
/qux

btw i changed the folder names for privacy reasons :wink:

Hello @aytacyildiz, welcome to drive!
For listing subdirectories, I'd recommendusing flag -m or max-depth(recursion depth) which takes an integer so drive list -m 4 would be traversing 4 levels deep.
Please let me know if this makes sense.

@odeke-em Hımm, okey i will use it. Thank you for response.


[v0.2.x] Adding Integration Bots to the org

Since we moved the repository from docker/containerd to containerd/containerd, the docker bots in charge of CI lost access.
This is an issue since it prevents CI results to be reported back on PRs against the v0.2.x branch.
Is there any objections to give those bots access to the repo?
ping @containerd/containerd-maintainers

No issue from me regarding access for the CI bots. SGTM

Can we use travis?


border: fix an inaccurate replacement about static __used

Replacing "static" without space may cause unexpected hurt to definitions whose name or type name has "static". e.g., struct static_key.

/retest

/retest


JSDoc parser API for source code (text)

Is it possible to access API instead of CLI? I want to work with source code (text) directly and get the result in code.
Can anyone guide me? I need API like Doctrine.

I've been referencing https://github.com/jsdoc3/jsdoc/blob/master/jsdoc.js and https://github.com/jsdoc3/jsdoc/blob/master/cli.js on how to do this. It doesn't look like they have a public API; however, you could do it yourself by referencing the above. I'm just trying this myself now so if I find anything out I'll post back here.

@JustinBeaudry Thanks :D

@HamedFathi I managed to get it to work, but after reflecting I decided that it would be fragile, and is probably not a good idea. In the end, I opted for using child_process instead:
const jsdoc = () => {
  return new Promise((resolve, reject) => {
    // using locally installed jsdoc
    const jsdoc = spawn('npx', [
      'jsdoc',
      // pass jsdoc cli options here
      '-c',
      'conf.json',
      '-X'
    ]);
    let output = '';
    let err = '';
    jsdoc.stdout.on('data', data => { output += data });
    jsdoc.stderr.on('data', data => { err += data });
    jsdoc.on('close', code => { code > 0 ? reject(err) : resolve(output) });
  });
};

In this case, I wanted to write a test for my plugin so I use --explain (-X) to just have jsdoc return JSON output. Then in another function, I JSON parse the output. Not sure if that's helpful, but I honestly think this option is better than using the undocumented API's.

Duplicate of #938.


Restructure the top-level README to make the order of steps clearer.

Description

Restructure the top-level README to make the order of steps clearer.
Fixes https://github.com/opendatahub-io/ai-edge/issues/97.
Fixes https://github.com/opendatahub-io/ai-edge/issues/96.
How Has This Been Tested?

Not tested.
Merge criteria:

[x] The commits are squashed in a cohesive manner and have meaningful messages.
[ ] Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
[ ] The developer has manually tested the changes and verified that the changes work

I'm reasonably happy with the refactoring of the top level README, so marking as ready for review.
The outstanding bits that I wouldn't want to hold this PR for are

reasonable description of the observability setup;
move the Gitea steps to separate document and reference it.

Maybe we should move all of this to a different file/set of files? This makes the README really huge.

We could move it to ACM/README.md and have a short section in the top-level README.md, referencing it. But given the ACM bit is the "meat" of the PoC, I don't mind the top-level README.md having it right there.

Thanks @piotrpdev for the review. I've applied your suggestions and rebased on main -> 49aadf7f7022a32884be3d91d13200f348ad82ab.
Where I had some concerns about the suggestions, I responded left the conversations open.

Two approvals are enough. We can always re-tweak the details later.
Thanks to you both, merging.


[Feature suggestion]: Feature selection (for dependent censoring)

One of the challenges in a CPH analysis is including the right features. The simplest approach consists in selecting a feature subset using univariate Cox regression. However, this approach relies on the assumption of independent censoring (survival time and censoring time need to be statistically independent at a given feature), which quite often is not true (e.g., young patients may be more likely to quite a treatment than older patients).
Recently, Emura and Chen proposed a copula-based method for feature selection in the case of dependent censoring. They showed that this method outperformed the classical univariate approach. Moreover, they have an implementation for R (repo here).
I think lifelines would benefit greatly from having such functionality. Would this be something you are interested in adding?

Hi @arturomoncadatorres, looks very interesting. I'll give it a look later this week!


⚠ GitLab Server has degraded performance

In 64699a9, GitLab Server (https://gitlab01.its-telekom.eu) experienced degraded performance:

HTTP code: 200
Response time: 11469 ms

Resolved: GitLab Server performance has improved in b1ea928.


Docstrings not allowed in Interface subclasses.

Traceback
Traceback (most recent call last):
  File "core.py", line 7, in <module>
    class TempStore(Interface):
  File "/.../marrow/interface/core.py", line 29, in __new__
    type(value).__name__, key))
TypeError: Interfaces must only contain Attribute instances, not a str named __doc__.

Test Case
class Example(Interface):
    """Turn this into an interface?"""
    __init__ = Method(args=0)
    bob = Method(args=2, kwargs=1)
    dole = Method(args=1)

Potentially solved in 9bef125df9.


Ring tactic fix

Fixed evalConstMul (it used natLits when it shouldn't)

BTW, you're currently still working on the merged ring branch, so we're seeing all the commits here even though the original PR was merged (this is because the PR was squashed and the merged commit is hence different than the commits here).  Could you please make new branches from master from now on?


Adding an average line

I spend hours searching whether it's possible to add a horizontal line that has a y value that is based on the average of another data array. I came to this awesome plugin to the Chart.js but still couldn't find this function.
Is this somehow possible? Much appreciated!

h

Closing as duplicate of #8


modify code scan

Test the codescan component's support for pull requests

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your<EMAIL_ADDRESS>seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


feat: safe variants of eqToHom_map

eqToHom_map is notoriously not a good simp lemma, but these variants should be safe and already go a long way.

bord d+

bors r+


Add GitHub Actions CI workflow

Closes #58

@vixalien would you mind approve the workflow run?

@rffontenelle thank you very much for this!!


TLS between controller/runners

Which will help with authentication and authorization of shared resources
Depends on where the security boundary is with platform

We've opted to push transport layer security to the underlying infrastructure layer (largely targeting K8s+Istio).


Persist pg_stat informartion in PS

Problem
Statistic is saved in local file and so lost on compute restart.
Persist in in page server using the same AUX file mechanism used for replication slots
See more about motivation in https://neondb.slack.com/archives/C04DGM6SMTM/p1703077676522789
Summary of changes
Persist postal file using AUX mechanism
Checklist before requesting a review

[ ] I have performed a self-review of my code.
[ ] If it is a core feature, I have added thorough tests.
[ ] Do we need to implement analytics? if so did you add the relevant metrics to the dashboard?
[ ] If this PR requires public announcement, mark it with /release-notes label and add several sentences in this section.

Checklist before merging

[ ] Do not forget to reformat commit message to not include the above checklist

Thanks for the ping.  Can we enforce a size limit of this WAL write on the postgres side?  (i.e. check size in wallog_file_descriptor, and if it exceeds a threshold, log a warning and don't write it).
I'm thinking that since pgstat file is meant to be small, a limit shouldn't affect it, but it will protect us in case this generic "write any file to the WAL" function is misused in future.

Just check how large statistic file can be: I created 10000 tables, perform some manipulations with them and do vacuum analyze. Is it enough to force generation of large statistic file?
Size of pgstat.stat is 4Mb

To factor in the issues we've had with capacity/replay scaling, what do you think about having separate stores for "big values" (such as pgstats) and  "small values" (such as logical replication state)?
Whatever the implementation on the pageserver evolves to, I think it will be helpful to store the ~< 8KiB items separately from the ~<4MiB items.  This doesn't have to be a whole separate API, we just need some recognizable bit that the pageserver can use to store them separately.

Cross referencing with https://github.com/neondatabase/neon/pull/6874#pullrequestreview-1901765234 -- since that PR is writing image values regularly for the AuxFilesDirectory structure, it's important that we don't put the multi-megabyte stats value in the same structure, to avoid using unreasonable amounts of storage when logical replication is used on small tenants.  The scenario described in that PR was 70,000 writes, so if we were writing a 4MB image every 1000 writes, that would be 280MB of storage for a tenant that could be as small as 30MB -- the rule of thumb I'm using here is that logical replication metadata should never account for the majority of storage in a tenant.

Cross referencing with #6874 (review) -- since that PR is writing image values regularly for the AuxFilesDirectory structure, it's important that we don't put the multi-megabyte stats value in the same structure, to avoid using unreasonable amounts of storage when logical replication is used on small tenants. The scenario described in that PR was 70,000 writes, so if we were writing a 4MB image every 1000 writes, that would be 280MB of storage for a tenant that could be as small as 30MB -- the rule of thumb I'm using here is that logical replication metadata should never account for the majority of storage in a tenant.

pgstat information is saved only on systems shutdown and unlike snapshots files it is the single key.
So even if compute is restarted each 5 minutes, and there are 10k tables, still it could not cause storage bloating.
Please also notice that:

10k relations is really extreme case. It is very unlikely that any client will have such large number of relation at all. And for typical number of relations: ~100 - size of statistic is few kilobytes.
This statistic is naturally versioned: if we have some static RO replica then it should take relevant statistic at this moment of time. Providing alternative versioning mechanism is IMHO overkill
We in any case has DBDIR which contains serialised hash of all database relations. So in case of large number of relation storage bloating will be caused not by statistic but by DBDIR rewriting.

So even if compute is restarted each 5 minutes, and there are 10k tables, still it could not cause storage bloating.

It doesn't matter how often the compute is restarted, if its large stats object is written to the same AuxFileDirectory as all the logical replication keys: every 1024 writes to LR slots will trigger a large (>4MiB) image value being written.

10k relations is really extreme case. It is very unlikely that any client will have such large number of relation at all.

Let's design defensively so that we are not relying on good luck to avoid a situation where someone creates a lot of relations (big stats) and the enables logical replication (frequent updates).

We in any case has DBDIR which contains serialised hash of all database relations. So in case of large number of relation storage bloating will be caused not by statistic but by DBDIR rewriting.

dbdir is indeed an issue, but the dbdir key isn't re-written continuously as a result of logical replication slot updates, and each value in the dbdir is only a couple of bytes.  The difference is that the AuxFilesDirectory is subject to frequent, continuous writes, so we must not put anything big in that structure because the frequency of writes will lead to repetition of that big object.

dbdir is indeed an issue, but the dbdir key isn't re-written continuously as a result of logical replication slot updates, and each value in the dbdir is only a couple of bytes. The difference is that the AuxFilesDirectory is subject to frequent, continuous writes, so we must not put anything big in that structure because the frequency of writes will lead to repetition of that big object.

Yes, it is true. Size of each hash map element is only 9 bytes. But still storage size of creation of 10k relations is 4.4Gb.
I do not think that it is unacceptable, but it is 1000x larger than size of pgstat file which is written only once at compute shutdown.

Generally LGTM for the storage part of the change, but for now, AUX file v2 is not enabled for all regions, so I don't plan to get this merged for now, unless there could be a flag to control whether or not to enable this feature.
I see the Postgres-side of the pull request writes pg_stat data during shutdown checkpoint, so I assume that's not a lot of write traffic and page server should be able to handle that relatively easily. Please correct me if I'm wrong :)

Yes, pgstat data is written on shutdown checkpoint.
Normal size of this file is about 64kb.
For 10k relations - 4Mb.
As far as computes are suspended relatively rarely, I also do not expect some sigficant extra load on PS.

Also, I didn't see pg_stat-related files getting encoded in the aux file v2 mapping? What are the paths of the files produced by pg_stat, and probably we need to assign a prefix ID to that? (see encode_aux_file_key in aux_file.rs)

Sorry, I missed it.
Fixed.

@hlinnaka will do one more round of review

Was there a PR for the Postgres changes already? github won't let you add comments on the submodule diff..

To close the loop on earlier threads about size of the pg_stat structure: what is the upper bound on the size of pg_stat that compute will write to storage?

To close the loop on earlier threads about size of the pg_stat structure: what is the upper bound on the size of pg_stat that compute will write to storage?

It is now limited by neon_pgstat_file_size_limit GUC, default value is 1MB

Was there a PR for the Postgres changes already? github won't let you add comments on the submodule diff..

Sorry, add references to Postgres PR to the description of this PR

Is this required for this PR, or is this an indepdendent optimization? Maybe open a separate PR for it?

It is just optimization.
Removed.

How about we drop this change, and don't try to import the stats file in the import_timeline() function at all.

O, not importing any AUX files now.

In any case, that's not related to persisting pgstat, so let's create a separate PR for that

Excluded from this PR.

I keep circling back to the thought that we're having to make some pretty unnatural contortions to detect whether we're starting from a shutdown checkpoint or not. We've talked about it before, but it's still worth summarizing, and if we go ahead with this design, it should be explained well in comments. There are several parts to that:

In the persisted checkpoint key-value pair, we don't explicitly store whether it was a shutdown checkpoint or an online one. We have to deduce that by checking whether its REDO pointer points to the record itself.
The assumption that it's a shutdown checkpoint if its REDO pointer points to the record itself feels a bit fragile. AFAICS it is true, but it's not immediately obvious why: It relies on the assumption that in an online checkpoint, there will always be at least one WAL record in between the REDO pointer and the checkpoint record itself. In v17, we always write an XLOG_CHECKPOINT_REDO record in an online checkpoint, which satisfies that assumption. In older versions, we always write a running-xacts record, if wal_level >= replica, so that checks out too. At the very least, this should be explained in comments
Furthermore, we don't explicitly store the end of the checkpoint record anywhere, so we need to recalculate it. This relies on the fact that a checkpoint record always has the same size. That's also true today, but there's no fundamental reason for it.

We have all that information readily available when we ingest the WAL, we just don't persist it, so we have to deduce and recalculate it in send_tarball. The alternative design would be to persist that information in WAL ingestion. It's a bit tricky to add now, while maintaining backwards compatibility with existing layer files. But I think this would work:
We could abuse the checkpoint.redo field for this. Before this PR, we didn't update it anyway. We could store the record's end position in it, if it was a shutdown checkpoint, and set it to 0 for online checkpoints. That's different from upstream, where it stores the checkpoint record's start position, but as long as we know what it means and have appropriate comments on it, that seems OK. We are already not storing the original Checkpoint struct as is, we are updating the individual fields while digesting the WAL, and reconstructing it when taking a basebackup.
What do you think?
(In v18, it would be a good idea to add a version number to the on-disk format of the Checkpoint key-value pair, so that we could evolve it more easily. We've made changes in this area a few times already, with how oldestActiveXid and nextXid fields are ingested. So far, we've been lucky and have been able to make them in a backwards-compatible way, but we might not be so lucky in the future.)

What do you think?

Ok, I have reimplemented check for normal shutdown in this way.
Still leave calculate_walrecord_end_lsn` function - may be it will be useful in some other cases.

I'm a little worried if we have enough test coverage: When I put together https://github.com/neondatabase/neon/pull/10010, it passed the newly-added test on first try after I got it to compile. That's always suspicious :-). At quick glance the test seems fine, though, so maybe I was just lucky.

-1, it's not quite right as it is, and I'm not a fan of leaving dead code around.
Ok, I will remove it.

A test for the oversized stats file would be good

Added


read_char() breaks println! in other threads

use console::Term;

fn main() {
    let thread1 = std::thread::spawn(|| loop {
        println!("line");
        std::thread::sleep(std::time::Duration::from_millis(250));
    });

    let stdout = Term::buffered_stdout();
    stdout.read_char().unwrap();

    thread1.join().unwrap();
}

OUTPUT:
line
    line
        line
            line

EXPECTED:
line
line
line
line

I don't know if I'm doing something wrong, but listening for chars on one thread is breaking (carriage returns?) output on other threads.

I believe that this cannot be fixed because read_char moves the terminal into raw mode.

I have the same issue.
Is there any workaround?

Indeed the terminal is set to raw mode in read_single_key(). But this may be overkill regarding what the function actually requires. In particular cfmakeraw() also disables all output processing from the terminal.
This single line fixes the behavior reported here:
    unsafe { libc::cfmakeraw(&mut termios) };
    termios.c_oflag = original.c_oflag;

As it only changes the output attributes, I think it won't interfere with the rest of the function, but I did not test it extensively. Also it may be more elegant to actually determine the precise termios flag set required, but I'm not knowledgeable enough to terminal control attributes to really figure that out.

I have the same issue. Is there any workaround?

Sort of, I have had success by inserting a carriage return before every single printed newline. So basically instead of /n use /r/n.

I have the same issue.
Is there any workaround?

I wrote a console wrapper to solve all the raw mode issues:
https://github.com/JasonWei512/code-radio-cli/blob/cc68773b3123fb580c21dbf92ff1a1565607a7a6/src/terminal.rs


[BUG] - Active build isn't updated in the UI until environment tab is closed

Describe the bug
When you specify a new active build, some parts of the UI don't update until the environment tab is closed.
Expected behavior
I expect the UI to update views when I make changes.
How to Reproduce the problem?

Create an environment ENV1 which succeeds in building
Create another successful build of ENV1
Open a different environment tab
Open the environment tab to view the environment, note which build is Active
Go to Edit
Click on the non-active build
Click "update environment build"
Observe that the Build dropdown now says the one we selected is "Active" - this is good.
Click on a different environment tab
Click back on the ENV1 tab
Observe that the build that we just selected as "Active" is no longer listed as "Active" - that can't be right...
Close the tab for ENV1
Open the tab for ENV1
Observe that the Active build IS properly specified after all... the UI just didn't update properly.

I believe #333 is related in that I think they both are rooted in there not being a "state" for the interface. Also similar to #333 this feels very trivial and edge case, but because there are several issues like this, it makes users feel like they might be losing their mind when they are trying to debug builds 😹 .
Output
No response
Versions and dependencies used.
No response
Anything else?
No response

Adding the investigation label since I just realized this deployment is using an older version of the UI. I'll need to retest this on a new deployment.

@kcpevey  did you manage to confirm repro of this issue?

I was waiting for a deployment to test on since I moved machines, I dont have it set up locally. I'll either have to get this set up locally or wait for our internal deployment to include the latest conda-store release. I won't have time for a local setup this week, but I can check back next week.

This is still happening in 2024.1.1rc. Its definitely not behaving properly.

As I see it, the underlying issue for both #333 and this issue is that the front-end's global (Redux) store does not really support multiple forms open at the same time. If I had to guess, I would guess that the tabs functionality (i.e., being able to open multiple environments at once across different tabs) was added to the front-end app later. (However, a cursory glance at the git history does not seem to support this guess.
In other words, the state object looks roughly like this:
type GlobalState = {
  tabs: {
    // The environments which have been opened (they each have their own tab)
    selectedEnvironments: Environment[];
    // The environment in the active tab
    selectedEnvironment: Environment || null;
  };
  // The list of channels for the currently selected environment.
  // This list gets updated as the user edits the form, and it
  // gets completely replaced each time the user switches tabs.
  channels: string[];
};

This means that we store info like the environment name for each tab, but we only have one place where we store the form data for each tab, so each time a tab is switched, it loads that space with new data for the active tab, obliterating whatever the state was for the previously open tab.
So what we need is something like a dictionary of edits keyed by environment id:
type GlobalState = {
  tabs: { /* ... */ };
  environmentForms: {
    [envId: string]: {
      channels: string[];
    }
  };
};


Enhance JWT Authentication Mechanism

Refactor CookieJWTAuthentication to JWTAuthentication.
Enable token retrieval from both the Authorization header and query parameters.
Modify the login_view to return the token in the response body instead of setting it as a cookie.

/approve

/unhold


33 | Search in Rotated Sorted Array | Java

Search in Rotated Sorted Array -
Adding a new leetcode problem with optimized Java solution that utilizes binary search -
Type of Issue -
Please add/delete options that are not relevant.

[x] Adding New Code

Programming Language
Please add/delete options that are not relevant.

[x] Java

Self Check

Ask for issue assignment and wait to get assigned to it before making Pull Request.
Add your file in the proper folder
Clean Code and Documentation for better readability
Add Title and Description of the program in the file

:star2: Star it :fork_and_knife:Fork it :handshake: Contribute to it!
Discord server ✉ - https://discord.gg/CXksGdn
Happy Coding,

Could you please assign this issue to me ?

Could you assign me this issue?

Could you assign this issue to me ?

Could you please assign this issue to me?

Duplicate of issue #700


Transparency Cryptomatte Vray for 3dsmax

Hi guys,
i'm working on 3dsmax and vray and i can't figure it out how to enable transparency in cryptomatte. For example, i create a box with glass material, create some teapots behind with vray materials, and render it, the crypto doesn't see what's behind the glass !!! Some one has an idea ?
Regards.

I would ask Chaos Group support for more accurate answers, but according to the docs, VRay cannot be propagated through reflections or refractions.

You need to go to your glass material, and in the refraction section, set the parameter "Affect channels" to "All channels". This will propagate the Cryptomatte through the refractive material.

no sorry but this trick doesn't work for me... already tried of course....

Ok, you can email me and I'll try to figure out what's going on.

hummm email you... when i find your email ?

You can see it f.e. in this post:
https://forums.chaosgroup.com/forum/v-ray-next-beta-for-3ds-max/v-ray-next-beta-for-3ds-max-general/990696-vray-next-has-different-result-in-glassy-liquid-situations-than-3-60-even-in-phoenixfd-bubbles?p=991927#post991927
Best regards,
Vlado


Flatten out underlyingErrors

Currently
The current implementation of Action doesn't allow you to receive the Swift.Error when .execution is called. But we get an ActionError type which is not really useful because you always have to switch within it to the underlyingError.
Proposal
I think it would be nice for the framework to have something like var underlyingErrors: Observable<Swift.Error>  which will only emit when .execution actually has an error

That makes sense to me, I believe ReactiveSwift's Command type has something similar. Let's do it!


It would be better to have a bigger "Sign in" prompt

Hi, thank you for the invite.
I was a bit struggled at the beginning because I did not find the sign in prompt.
It is probably too small. It would be better to make it a bit more noticeable for a user.
The screenshot is from Chrome macOS
Thank you.

Hey.
We've increased size of the prompt a bit, and made it bold.
Thank you :-)


added 'blogdown' book

What does this PR do?
Add resource(s) | Remove resource(s) | Add info | Improve repo
It adds the book 'blogdown: Creating Websites with R Markdown' to the R programming language section.
For resources
Description
Why is this valuable (or not)?
Yes, it provides reading material on creating websites with R Markdown.
How do we know it's really free?
It is freely available on its official website.
For book lists, is it a book? For course lists, is it a course? etc.
Yes, it is a book.
Checklist:

[x] Read our contributing guidelines
[x] Search for duplicates.
[x] Include author(s) and platform where appropriate.
[x] Put lists in alphabetical order, correct spacing.
[x] Add needed indications (PDF, access notes, under construction)

Follow-up

Check the status of GitHub Actions and resolve any reported warnings!

Thanks, and welcome to free-programming-books!


Add error reporting to Slack messages rather than fail silently

The example fails silently when, for example, the Slack auth token is incorrect. Worse, it implies it succeeded by mentioning in the debug console that the message was sent

/lgtm
I will squash and merge


Implementing manage mentors for all states

Purpose
The purpose of this PR is to fix #45.
Goals
The admins can approve and reject a mentor as well as remove based on state of the program.
Approach
There are 7 states in a program. The view is different based on the state.

CREATED - Since none of the mentors applied, it should be blank.
MENTOR_APPLICATION - Mentors send in their application and we could remove if it was a spam
MENTOR_SELECTION - The admins will approve/reject applications based on the program criteria. They could also remove an mentor applicant for other reasons.
MENTEE_APPLICATION - All approved mentors will wait till the mentees apply for them. We could remove a mentor in this stage too.
MENTEE_SELECTION - This is similar to the previous view.
ONGOING - This is similar to the previous view.
COMPLETED - This view will be blank as there isn't any actions required.

In order to deal with the multiple views and its actions, switch statements were used to render the actions. Actions were generalized wherever possible.
Screenshots
CREATED state

MENTOR_APPLICATION state

MENTOR_SELECTION state

MENTEE_APPLICATION, MENTEE_SELECTION & ONGOING state

COMPLETED state

Checklist

[x] This PR doesn't commit any keys, passwords, tokens, usernames, or other secrets.
[x] I have read and understood the development best practices guidelines ( http://bit.ly/sef-best-practices )
[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation

Test environment
Kubuntu 16.04
Chromium 85.0.4183.121

Oh, and another thing, let's change the title of the PR and commit message to something like 'Implement' instead of putting 'Implemented'.
Your Pr and commit messages should be kind of in the narrative of, "Merge this PR/Commit to 'Implement Bla blah blah function'"

Oh, and another thing, let's change the title of the PR and commit message to something like 'Implement' instead of putting 'Implemented'.
Your Pr and commit messages should be kind of in the narrative of, "Merge this PR/Commit to 'Implement Bla blah blah function'"

Noted. Will follow them in the future.

Let's have a code review on this today


⚠ Jenkins Plugins Artifactory has degraded performance

In 94fa5ca, Jenkins Plugins Artifactory (https://get.jenkins.io/plugins/artifactory/) experienced degraded performance:

HTTP code: 200
Response time: 1267 ms

Resolved: Jenkins Plugins Artifactory performance has improved in d927098 after 12 minutes.


Final report warning if haven't submitted reports coming before.

closes https://github.com/SeedCompany/cord-field/issues/1161

This lived to the end of its lifetime and died


custom-links-sravanthi

Feature/Change Description
This update implements a feature to add custom links to the dashboard. A new "Add Link" button is added between the "Delete" button and the "Links" title. Upon clicking the "Add Link" button, a popup modal appears at the center of the screen where users can enter a link title and URL. Once the user inputs the information and clicks "Save", the link is added to the link list below, styled with green text, and changes color on hover. Each added link includes a "Delete" button that allows users to remove any unwanted links.
Developer Contributions:
@davidtso1219
Developer Contributions:

No dependencies

Screenshots:

@ChandraSravanthiKaki we should be checking to see if a URL is of proper form. Right now if I enter dummy data it will append that to our site URL and take you to that page (which would be bad in case a user was able to access a page they shouldn't be able to see)
Example:
If I enter "blah" in the URL area the link is "https://dev-sravanthi.group10-esc012.pages.dev/blah"
https://www.freecodecamp.org/news/check-if-a-javascript-string-is-a-url/

@ChandraSravanthiKaki Additionally, there should be consistency in our popovers. You have an animation set for yours while the task one does not. I think we should remove the animation
https://github.com/user-attachments/assets/d448807a-1ceb-47eb-b210-d008ef76e190

@ChandraSravanthiKaki also, it doesn't match Kayla's Figma design found here: https://www.figma.com/design/vmR73ilvmkx0uk6126HwOk/CSE-210-Design?node-id=1629-363&node-type=canvas

The delete button should be a pencil icon (the same as for edit task)
The + button should have a circle around it
There should be an option to add an icon
Please check this out and make sure that it matches!

@ChandraSravanthiKaki also, it doesn't match Kayla's Figma design found here: https://www.figma.com/design/vmR73ilvmkx0uk6126HwOk/CSE-210-Design?node-id=1629-363&node-type=canvas

The delete button should be a pencil icon (the same as for edit task)
The + button should have a circle around it
There should be an option to add an icon
Please check this out and make sure that it matches!

Addressed.

Please refer to our comments above for base functionality changes.

Done. Thanks

@ChandraSravanthiKaki Additionally, there should be consistency in our popovers. You have an animation set for yours while the task one does not. I think we should remove the animation
animation.mp4

I removed the animation

@ChandraSravanthiKaki we should be checking to see if a URL is of proper form. Right now if I enter dummy data it will append that to our site URL and take you to that page (which would be bad in case a user was able to access a page they shouldn't be able to see)
Example:
If I enter "blah" in the URL area the link is "https://dev-sravanthi.group10-esc012.pages.dev/blah"
https://www.freecodecamp.org/news/check-if-a-javascript-string-is-a-url/

Addressed

@ChandraSravanthiKaki please handle an extra case where a URL may be of form "https://github.com" or "http://github.com" or "www.github.com" or "github.com"
currently only the form https:// is handled

Pencil and + icons should be the same size.
Left justify the icons for both the added links and the create link form please. They don't look that nice toward the center.
Make the "Save Link" button the same color as David's "Save" for create task form. Same for the outlines/icons. In fact, you can probably copy his CSS for that button.
Format of the PR description is still wrong. Please refer to a merged PR for proper formatting.

I am trying to fix the pencil and + icons, but the icons vectors are of different sizes when downloaded from the figma design. So will try to fix it now.
I have tried to justify them to the left, but the problem is with scaling, as u can see when we scale the website, the whole part gets spoilt except for the links part. I felt scaling is a very big issue, but if not, let me know I will modify it. And regarding the icons in the form part, I tried to build on the design that David made, given he didn't add all this and the PR was approved, I felt u guys felt it was not needed. But if you guys want the inputs to have the icons (I feel it being synchronous thought out the website is better), let me know, I will try to add it.
I will change the Save Link color.
Regarding the PR, is the screenshot the only problem, I cant find others. I will definitely remove the screenshots. If there are others, let me know.

We see the issue with scaling. Looks like the text size isn't responsive. So forget the left-justify for now. We might try to fix it later.
You said that you didn't include the icons in the create link form? But I can see them in the preview, only for the relevant links section. Can you double check? Since David didn't include the icons, you can also remove them.
There should be a Dependencies section but you have two Developer Contributions sections. Also the Feature/Change Description section should ideally include separate bullets. And yes, please remove screenshots.

@ChandraSravanthiKaki please handle an extra case where a URL may be of form "https://github.com" or "http://github.com" or "www.github.com" or "github.com"
currently only the form https:// is handled

Addressed. I think it should work properly now.

We see the issue with scaling. Looks like the text size isn't responsive. So forget the left-justify icons for now. We might try to fix it later.
You said that you didn't include the icons in the create link form? But I can see them in the preview, only for the relevant links section. Can you double check? Since David didn't include the icons for the create task form, you can also remove them.
For the PR description, there should be a Dependencies section but you have two Developer Contributions sections. Also the Feature/Change Description section should ideally include separate bullets. And yes, please remove screenshots.
For the input fields in the create link form, the outlines seem to be the same color as the "Save Link" button (wrong color) so please fix those as well.

Hey Meghana,
I think I addressed all the comments. Please review and let me know if there is anything else to be changed.

The code does not handle "github.com" format links and returns invalid URL
Also, the "X" should be right aligned inside the cell when edit is enabled

PR description: can you remove the screenshots? Also use bullets for the feature description.
I think the pencil should be a little smaller or the + should be a little bigger for them to be the same size. You can look at the personal tasks and compare the pencil to the check circle for an example.
For some reason, we can add links with empty name fields. This should be invalid too.
I noticed that after deleting a link, it's no longer on edit mode (x's disappear). I think it should remain on edit mode so that the user can delete multiple links without having to press the edit icon multiple times. Then they would press enter or the edit button again to exit edit mode.
I also noticed that David's forms (create/edit/filter) are surrounded by a green outline. Can you replicate that for your create link form? Make sure it's the same color too, the outlines for the forms look a little lighter than the outlines for the sections of the page.
If possible, can you use the trashcan icon that David uses for tasks instead of x's to delete the links? It will look more uniform that way.
Also if possible, the create link form looks a little empty so can you add "Add Link" or something similar at the top of the form, in the same font that David uses for "Task Name" for his forms?

PR description now doesn't have the screenhots, and has the description in bullets format
I think I reduced the size as much as I can and retaining the overall structure now.
Now add links won't take empty link name, it shows Invalid title.
Yes, now the form has a very light green outline, exactly what david used.
Yes, now I'm using trash can instead of the 'X' mark.
Done, I added the titles for each input field in the link form

The code does not handle "github.com" format links and returns invalid URL
Also, the "X" should be right aligned inside the cell when edit is enabled

Hey Shayan,
Now even github.com, amazon.com will work, https will work, www. will work. Made the necessary changes.
I right aligned the trashcan.


[Bug]: demo_client can not enable mulitipath feature on two different netdevice;

What happened?
./demo_client -l e -L clog -d -k ./ckeys.log -K 60 -U https://xquic_server:443/1g -A "h3" -i eth1 -i eth0 -M
xqc_demo_cli_init_user_path ---> xqc_demo_cli_create_socket(user_path, &ctx->args->net_cfg, 0);
create  two path on eth1 dev
Steps To Reproduce
./demo_client -l e -L clog -d -k ./ckeys.log -K 60 -U https://xquic_server:443/1g -A "h3" -i eth1 -i eth0 -M
xqc_demo_cli_init_user_path ---> xqc_demo_cli_create_socket(user_path, &ctx->args->net_cfg, path_seq);
create  one path on eth1 dev, and anther path on eth0 dev
Relevant log output
No response

is there any std print log?

This issue was fixed by PR #338


Cert Manager fails/offsync from docs out of the box

https://docs.cert-manager.io/en/latest/getting-started/troubleshooting.html
Describe the bug:
Was there an update?
Running the installation in the docs works. Yet it appears different. I see
root@controller-1:~# kubectl get pods --namespace cert-manager
NAME                                       READY   STATUS    RESTARTS   AGE
cert-manager-5d5cc69d6-jtt76               1/1     Running   0          2m22s
cert-manager-cainjector-7688bf9689-g9r6h   1/1     Running   0          2m22s
cert-manager-webhook-dfcbcc64b-kplgd       1/1     Running   0          2m22s

Instead of what's specified. Additionally, applying the ClusterIssuer letsencrypt-staging and the demo provided result in webhook errors.
Error from server (InternalError): error when creating "test-resources.yaml": Internal error occurred: failed calling webhook "issuers.admission.certmanager.k8s.io": the server is currently unable to handle the request
Error from server (InternalError): error when creating "test-resources.yaml": Internal error occurred: failed calling webhook "certificates.admission.certmanager.k8s.io": the server is currently unable to handle the request

Expected behaviour:
I get the same results as the "Verifying the installation" section in https://docs.cert-manager.io/en/latest/getting-started/install/kubernetes.html#verifying-the-installation with the version referenced in the installation (2 deployments, 1 job || 3 deployments)
Steps to reproduce the bug:
https://docs.cert-manager.io/en/latest/getting-started/install/kubernetes.html
Anything else we need to know?:
Full bash history
root@controller-1:~# cat << EOF| kubectl create -n ingress -f -
> apiVersion: certmanager.k8s.io/v1alpha1
> kind: ClusterIssuer
> metadata:
>   name: letsencrypt-prod
> spec:
>   acme:
>     server: https://acme-v02.api.letsencrypt.org/directory
>     email<EMAIL_ADDRESS>>     privateKeySecretRef:
>       name: letsencrypt-prod
>     http01: {}
> EOF
Error from server (InternalError): error when creating "STDIN": Internal error occurred: failed calling webhook "clusterissuers.admission.certmanager.k8s.io": the server is currently unable to handle the request
root@controller-1:~# kubectl get pods -n cert-manager
NAME                                       READY   STATUS    RESTARTS   AGE
cert-manager-54dffbdd8b-dxl5n              1/1     Running   0          23m
cert-manager-cainjector-7688bf9689-l6f9t   1/1     Running   0          23m
cert-manager-webhook-dfcbcc64b-h6x6h       1/1     Running   0          23m
root@controller-1:~# helm list
NAME            REVISION        UPDATED                         STATUS          CHART                   APP VERSION     NAMESPACE
cert-manager    1               Sun Jul 21 05:00:17 2019        DEPLOYED        cert-manager-v0.8.1     v0.8.1          cert-manager
harbor          1               Sun Jul 21 05:15:06 2019        DEPLOYED        harbor-1.1.1            1.8.1           harbor
metallb         1               Mon Jul 15 02:53:25 2019        DEPLOYED        metallb-0.9.7           0.7.3           metallb
root@controller-1:~# helm delete --purge cert-manager
release "cert-manager" deleted
root@controller-1:~# kubectl create namespace cert-manager
Error from server (AlreadyExists): namespaces "cert-manager" already exists
root@controller-1:~# kubectl label namespace cert-manager certmanager.k8s.io/disable-validation=true
error: 'certmanager.k8s.io/disable-validation' already has a value (true), and --overwrite is false
root@controller-1:~# kubectl apply -f https://github.com/jetstack/cert-manager/releases/download/v0.8.1/cert-manager.yaml
customresourcedefinition.apiextensions.k8s.io/certificates.certmanager.k8s.io configured
customresourcedefinition.apiextensions.k8s.io/challenges.certmanager.k8s.io configured
customresourcedefinition.apiextensions.k8s.io/clusterissuers.certmanager.k8s.io configured
customresourcedefinition.apiextensions.k8s.io/issuers.certmanager.k8s.io configured
customresourcedefinition.apiextensions.k8s.io/orders.certmanager.k8s.io configured
Warning: kubectl apply should be used on resource created by either kubectl create --save-config or kubectl apply
namespace/cert-manager configured
serviceaccount/cert-manager-cainjector created
serviceaccount/cert-manager-webhook created
serviceaccount/cert-manager created
clusterrole.rbac.authorization.k8s.io/cert-manager-cainjector created
clusterrolebinding.rbac.authorization.k8s.io/cert-manager-cainjector created
clusterrole.rbac.authorization.k8s.io/cert-manager created
clusterrolebinding.rbac.authorization.k8s.io/cert-manager created
clusterrole.rbac.authorization.k8s.io/cert-manager-view created
clusterrole.rbac.authorization.k8s.io/cert-manager-edit created
clusterrolebinding.rbac.authorization.k8s.io/cert-manager-webhook:auth-delegator created
rolebinding.rbac.authorization.k8s.io/cert-manager-webhook:webhook-authentication-reader created
clusterrole.rbac.authorization.k8s.io/cert-manager-webhook:webhook-requester created
service/cert-manager-webhook created
deployment.apps/cert-manager-cainjector created
deployment.apps/cert-manager-webhook created
deployment.apps/cert-manager created
apiservice.apiregistration.k8s.io/v1beta1.admission.certmanager.k8s.io created
issuer.certmanager.k8s.io/cert-manager-webhook-selfsign created
certificate.certmanager.k8s.io/cert-manager-webhook-ca created
issuer.certmanager.k8s.io/cert-manager-webhook-ca created
certificate.certmanager.k8s.io/cert-manager-webhook-webhook-tls created
validatingwebhookconfiguration.admissionregistration.k8s.io/cert-manager-webhook created
root@controller-1:~# kubectl get pods --namespace cert-manager
NAME                                       READY   STATUS    RESTARTS   AGE
cert-manager-5d5cc69d6-jtt76               1/1     Running   0          17s
cert-manager-cainjector-7688bf9689-g9r6h   1/1     Running   0          17s
cert-manager-webhook-dfcbcc64b-kplgd       1/1     Running   0          17s
root@controller-1:~# cat <<EOF > test-resources.yaml
> apiVersion: v1
> kind: Namespace
> metadata:
>   name: cert-manager-test
> ---
> apiVersion: certmanager.k8s.io/v1alpha1
> kind: Issuer
> metadata:
>   name: test-selfsigned
>   namespace: cert-manager-test
> spec:
>   selfSigned: {}
> ---
> apiVersion: certmanager.k8s.io/v1alpha1
> kind: Certificate
> metadata:
>   name: selfsigned-cert
>   namespace: cert-manager-test
> spec:
>   commonName: example.com
>   secretName: selfsigned-cert-tls
>   issuerRef:
>     name: test-selfsigned
> EOF
root@controller-1:~#
root@controller-1:~# cat test-resources.yaml
apiVersion: v1
kind: Namespace
metadata:
  name: cert-manager-test
---
apiVersion: certmanager.k8s.io/v1alpha1
kind: Issuer
metadata:
  name: test-selfsigned
  namespace: cert-manager-test
spec:
  selfSigned: {}
---
apiVersion: certmanager.k8s.io/v1alpha1
kind: Certificate
metadata:
  name: selfsigned-cert
  namespace: cert-manager-test
spec:
  commonName: example.com
  secretName: selfsigned-cert-tls
  issuerRef:
    name: test-selfsigned
root@controller-1:~# kubectl apply -f test-resources.yaml
namespace/cert-manager-test unchanged
Error from server (InternalError): error when creating "test-resources.yaml": Internal error occurred: failed calling webhook "issuers.admission.certmanager.k8s.io": the server is currently unable to handle the request
Error from server (InternalError): error when creating "test-resources.yaml": Internal error occurred: failed calling webhook "certificates.admission.certmanager.k8s.io": the server is currently unable to handle the request
root@controller-1:~# kubectl get pods --namespace cert-manager
NAME                                       READY   STATUS    RESTARTS   AGE
cert-manager-5d5cc69d6-jtt76               1/1     Running   0          2m22s
cert-manager-cainjector-7688bf9689-g9r6h   1/1     Running   0          2m22s
cert-manager-webhook-dfcbcc64b-kplgd       1/1     Running   0          2m22s
root@controller-1:~# nano staging.yaml
root@controller-1:~# kubectl create -f staging.yaml
Error from server (InternalError): error when creating "staging.yaml": Internal error occurred: failed calling webhook "clusterissuers.admission.certmanager.k8s.io": the server is currently unable to handle the request

Edit:
This also occurs for the release 0.9 references
https://docs.cert-manager.io/en/release-0.9/getting-started/install/kubernetes.html
Environment details::

Kubernetes version 1.15.0
Cloud-provider/provisioner Self / Openstack
cert-manager version (e.g. v0.4.0): 0.8.1
Install method (e.g. helm or static manifests): Both

/kind bug

http://docs.cert-manager.io/en/latest/getting-started/troubleshooting.html#verify-all-cert-manager-pods-are-running-successfully
This section actually matches my deployment.  I believe this is some clear off synchronization between the installation documentation and the results expected.
Additionally, following the steps in troubleshooting failed.

same pb

I am having the same issue:
Environment details::

* Kubernetes version 1.13.5 (AKS)
* cert-manager version  0.8.0 and 0.9.0

I've finally disabled the webhooks and go it working on Kubernetes 1.13.5 AKS.

With webhook validation turned off everything works on my end as of k8s 1.17/cert manager 0.12.


Help Center: Update YouTube link

Per discussion during bugbash, updating youtube link to be the group of videos not the first video in the group.

Should be this link: https://www.youtube.com/playlist?list=PLfVPq9A6B0RNoQ3HTE9LQzgAdVzcb7tmt


--share stopped working..

Hello,
I am getting http://www.speedtest.net/result/0.png instead of actual share URL.
-N

Cannot reproduce.  This is working in devel

I am also getting this result when I'm on a very fast connection.
Here is the output:
Retrieving speedtest.net configuration...
Retrieving speedtest.net server list...
Testing from LeaseWeb B.V. (<IP_ADDRESS>)...
Selecting best server based on latency...
Hosted by fdcservers.net (Amsterdam) [2.87 km]: 2.956 ms
Testing download speed........................................
Download: 3159.37 Mbit/s
Testing upload speed..................................................
Upload: 541.30 Mbit/s
Share results: https://www.speedtest.net/result/0.png

Is this a known limitation on their end (maybe to prevent people from generating fake results ?)
As a proof, here is the actual output from the SSH session.

Here is now the result when I try from a server much farther away (so I can get slower speeds). We can now see that it is working.
Retrieving speedtest.net configuration...
Retrieving speedtest.net server list...
Testing from LeaseWeb B.V. (<IP_ADDRESS>)...
Hosted by TIM Brasil (Rio de Janeiro) [9579.58 km]: 227.944 ms
Testing download speed........................................
Download: 32.00 Mbit/s
Testing upload speed..................................................
Upload: 4.49 Mbit/s
Share results: https://www.speedtest.net/result/4222206614.png

I also get the same result on low latency, high speed servers.
root@ord-af0cbfe80941ec72:~# speedtest-cli --share --server 13425 --source <IP_ADDRESS>
Retrieving speedtest.net configuration...
Testing from Ordnance Networks Pty (<IP_ADDRESS>)...
Retrieving speedtest.net server list...
Selecting best server based on ping...
Hosted by IP Transit (Sydney) [1.20 km]: 2.095 ms
Testing download speed................................................................................
Download: 2498.11 Mbit/s
Testing upload speed................................................................................................
Upload: 1894.17 Mbit/s
Share results: http://www.speedtest.net/result/0.png
root@ord-af0cbfe80941ec72:~#


local view position saving lost

@tzarebczan commented on Tue Jul 06 2021
We used to store and ensure view position started where you left off (locally), it broke recently.

play a video for a few seconds
refresh the page
it should start where you were previously playing

@tzarebczan commented on Wed Jul 07 2021
This also breaks the "share at" feature and doesn't prefill the timestamp.

@tzarebczan commented on Fri Jul 16 2021
view position still broken (thought it was fixed at some point on Xander's branch, but I guess not)

@tzarebczan commented on Mon Jul 19 2021
Seems to be broke on transcoded videos, but works on non-transcoded

@tzarebczan commented on Thu Aug 19 2021
Looks like it's broken on both now (or just random where it works). Can't use the share at feature to prepopulate time, and if you do share a link with a time, it won't skip to it.
https://odysee.com/@FameFocus:b9/crazy-vfx-behind-prince-of-persia-vfx:3?r=5c3YqxEKm4urG5dwc81zNtkbXUP7BJGE&t=25

In most videos, doFileGet | Lbry.get is returning this as "file info":
{
  "streaming_url": "https://cdn.lbryplayer.xyz/api/v4/streams/free/the-final-fantasy-13-iceberg-explained/5e6ec4a7dc05c8c87691eb09bb51a6be89eed26a/c3e2cf"
}

Over at the UI, we determine the duration this way:
    const durationInSecs =
      fileInfo && fileInfo.metadata && fileInfo.metadata.video ? fileInfo.metadata.video.duration : 0;

Since fileInfo only contains streaming_url, the duration is 0 and was reset.
SDK issue or code mistake? I see another file_get api in the code.

Yea, that won't work on web - it should come from the claim resolve data. This may also be related: https://github.com/OdyseeTeam/odysee-frontend/issues/99
What's strange it as it would work sometimes...

Excuse the novel.  Just throwing in some notes from some poking around on this one.
It appears that there are multiple aspects to this bug that are interacting to make it appear somewhat random. @infinite-persistence, what you highlighted is one part.  This will nuke the video progress whenever you normally route to a video.
However, if you reload the page, it "works".  But that's actually due to another bug.  The position value in onPlayerReady in videoViewer/view.jsx is stale with the value that was initially loaded from storage.

position is not in the useCallback dependency list, but that's not sufficient as it seems that the stale version of onPlayerReady is getting executed in the useEffect of videojs.jsx.
There's likely some general refactor here that can help here.
The next layer of the bug relates to multi tab/window.  When another tab is loaded, the other tabs do not get notified about updates to the store.  So content.positions gets overwritten with whatever values that window instance had, sometimes competing back and forth.
There are a few ways to approach this one.  The value of content.store could be pulled out of the indexeddb and merged with the new values on every save.  However, that would require reconstructing a copy of the store on every save, including all middlewares and transforms.  CPU expense aside, I haven't gone through the entire thing, so I'm not sure how much the store depends on being a singleton.
Another approach could be blacklisting this piece of state from redux-persist and store it separately.  That would make it easier to read/write.  Also, it's been a while since I've used indexeddb at a low level, but using localStorage would also have access to the 'storage' event, allowing all the tabs to stay in sync.  LocalForage could also have an extension that provides that functionality as well without concern for the storage target, but not sure here.
redux-persist also has a cross-tab notification npm module available, but I think that was dependent on the "storage" event.

Re: merging
Good find on the cross-tab problem.  I think the code originally only handled the Desktop (single tab) case.
If https://github.com/OdyseeTeam/odysee-frontend/issues/168 happens and becomes a syncable setting (USER_STATE_POPULATE), then maybe it will indirectly cover the cross-tab problem.
Re: dependancies
Yeah, looks like a bug.  The following line probably shouldn't be suppressed to remind us to update the dependency list (I just ported Xander's recsys code 1:1 without checking, oops).  Also, not sure if the dependancy list needs to be a variable -- if can't figure out why, can probably just put it back inline to avoid the other lint warning.
}, playerReadyDependencyList); // eslint-disable-line


Issue 20

From @atollk, with the minor change of the suffix to make it more intuitive.

I added generation for models from the requestBodies section.
I also changed a few dependencies from testImplementation to testCompileOnly to make it clear that they're not used for actually running the tests and applied a minor change which causes the media types of annotations on controller functions to be unique (i.e. you won't have produces = ["application/json", "application/json", "application/json"] anymore)

@atollk We'll have to work on fixing the broken controller references if we want to merge this.

There is still plenty of work to do here. In particular, all of these controller functions should probably be switched to returning  the response and request body variants
https://github.com/cjbooms/fabrikt/blob/master/src/test/resources/examples/githubApi/api.yaml#L828-L858

This feature is so brittle with how it integrates with Controller interfaces and Client gen, I'm considering not implmenting it.
That, or perhaps remove client generation entirely from this code base

Could you help me understand what the purpose of your commits on this branch is? Was the code generation of my change alone errorneous or is it purely cosmetic?
If it's the latter, I agree with the underlying motivation that appending indices to the model class names in some cases isn't a great solution but I feel like it would be sufficient to resolve this issue and officially have "request bodies" supported. Also because from what I can tell, your added changes now make this PR not backwards-compatible due to different naming of response schemas.
For a general solution, I feel like model class mappings deserve a refactoring anyway. But that should be handled in a different issue imo.

If we start generating models from requestBodies or responses section, these models should be used in the Controller interfaces and client implementations.
But the logic around this is super-brittle and relies on the same name being chosen at generation time in separate code paths. I attempted to fix this, but ran out of time


Changes made for native support for position: sticky causing weirdness with WP admin bar, particularly on mobile.

I believe this is fixed with 6f6ee0817cadf470e8e8526d9b9d02f27968a800


Do you know how we can implement concurrency in elasicsearch go client? Ex: I want to create multiple objects of elastic search go client and assign each object to one thread to query elasticsearch and produce the result. I am currently using ElasticSearch V6.X

Please use the following questions as a guideline to help me answer
your issue/question without further inquiry. Thank you.
Which version of Elastic are you using?
[ ] elastic.v6 (for Elasticsearch 6.x)
[ ] elastic.v5 (for Elasticsearch 5.x)
[ ] elastic.v3 (for Elasticsearch 2.x)
[ ] elastic.v2 (for Elasticsearch 1.x)
Please describe the expected behavior
Please describe the actual behavior
Any steps to reproduce the behavior?

Do not create multiple clients. A client is thread-safe by design, so you can use it in multiple Go routines without any problems. Simple pass one instance of *elastic.Client around.
There are various reasons for that. One is that each client creates a set of goroutines that run in the background. If you create many clients, they will stand on each others foots, maybe.
If you want to use concurrency in Go with this library, use e.g. something like the pipeline example of errgroup.Group. Here's an example of bulk indexing or concurrent slicing. See also the wiki.


Entity's bounding sphere is incorrect (occasionally)

I use the viewer.dataSourceDisplay.getBoundingSphere() method to calculate the bounding sphere, and then use the viewer.camera.viewBoundingSphere() method to track the Entity, and use a red Box to indicate the size of the Entity's bounding sphere.
getBoundingSphere() is very unstable. Sometimes the calculation results are correct and sometimes incorrect. Why does this happen?
The sandcastle example may not be able to reproduce this problem, because this problem occurs occasionally.
There are 2 screenshots below, Figure 1 is correct, and Figure 2 is incorrect.
Figure 1:

Figure 2:

Sandcastle example: https://sandcastle.cesium.com/#c=rVZtb9o6FP4rFvcDqYQcoNAWRqsV6N0msVG17O7DqDqTHII1J45sh0In/vtOApQ4gTtd6fIBxT4vPuc55zw2IenPk5E2ZMnhBRS5JhG8kAFonoT0n2zPqXrZciAjw3gEqlojv6YR2f1YxENmuIy6ZM6EhtpBNGMaRmwN6p57P0GVFeaJENpTAFE/MeaYiwCkJ/1jtgsZwikrHs1lX67KAsNDEJhDWRKxJQ+yPD6CiE85NqAUYnCv5JJnUe2QwhyYgW9SCX+yVXHO9labs3fTaL/Ygu29hmLIDHuUifLABn1gyZy88bZG1H+TaqoglEu4FSJTPKnGfN85ZGEfT4VkvvP9ICb58mZw+l1S9aWXhBCZas0WLkHprPrVBq1X87LNYfH0hsYhzEIUsZIYqXZyZ2fnekzlj4yl5ttus4JELYP4Mdz/3mrUG602PW+etxqtZrPdqZF2u9msX13QK1zjV+eyRs4bFxeXnQ5uNeqXF+3OeevJymwu1QtT/t3KKBZLkbXGZB1j61Q/jkfDXKabnJ1gMxCF2OZciIEUUnWLwKpgxjDgeo002+3D35OFYiGqyKRQX8UrMko87jOCc6mlALsuC6n4azqwYqx4wNPyDO6+TO4ebDUsnuHeH5QWwIOFeYA5KIi8FIDB6Pbz/fNk/PzhYfz1y9BWj/kKxHg+12BKCb+VqblLu/4vuWqzFulpf38ajewjDKxSFG65OlGGEDmjWIZAmDkaLYyJddd1NYt8j2kjgHq7IZah+8jCWEDalm7mQ7vbscSjdl/P+EkDMfuvGOUCPcoMCNcE2UkmxnHOyPVNPvgta+DwcbNGtihMTrbPccoDMP31J9/JZibve+9hJpPI51HwGC8wTpt3+pbMsc1LlDLkOhZsnR1pG+ZR2UZsN3CBUUkhqIOknAB2OZJV4FRtE7yP7I2C5R95Zsc0M7kqdPJxrsG5PdT5B2L9117xx+lmnqXXUcGNj/WOUvLUJZHNaEVZETSqmM8TXfuf9YpqT/bGpuAn5bnukQITgk29vXWNSk7IvnHfLLqkeVx6nD73BLq/OVMl+nA3pEb21wje4Q4uXUjWYnO02T0WgmI0XRVavNxte0BIu16vn72r1Cq9jL1u9qL3PIylMiRRwqHUNYA0gy8G7c4SfBoZ6mm999Nz86Y9ny+xPa+nlcIrbFohnmBaoyR9Rj3yV5hWbnou6pdM0xse4x0j3ePQpmqLxs1ou0kp7bm4PG5ppBQzpgqefwM
Browser: Google Chrome 91.0.4472.164
Operating System: windows10

Thanks @shenliangv - at first I thought this might be related to the Bounding Sphere not being computed on time (see https://github.com/CesiumGS/cesium/blob/ffcc025a9ed8c9f54e7d7ce6cb09bf89bcdac273/Source/DataSources/DataSourceDisplay.js#L341) but this does not appear to be the case even when the center is off. I've marked this as a bug and we'll look into it when we get a chance.


Rune protection doesn't work on latest game version

The other options seem to be fine in 1.0.3 but the save runes on death stopped working, presumably because offset changed.

For some reason it's working again, not sure why it's being inconsistent.. it definitely was not working a few days ago, but I'd also been relaunching several times to adjust FOV.


Update short circuit mode test names

The current test called WithShortCircuitMode passes false to disable the short-circuit, and the test called NotShortCircuitMode uses the default value which enables short-circuit (only loads the first found env file). This PR inverses the names of these tests, as that makes more sense in my mind.
Please let me know if I have misunderstood the meaning of these test names.

Thanks. I've merged this into the 4.x series.


Questions about applying GLUE on integrating scRNA-seq data and protein data

Hi, I wonder if it is possible to apply glue to match gene expression and protein data, but it seems that we do not have chr information this time, so it would be harder for us to construct the prior graph. Is it possible? Thanks.

Constructing the prior graph among genes and proteins should also be as easy. You can just connect the proteins and their corresponding genes.

Hi, is this the best practice to go if we are working on cite-seq data?

Constructing the prior graph among genes and proteins should also be as easy. You can just connect the proteins and their corresponding genes.

I'd say this is easiest way we can think of, that uses off-the-shelf relations between proteins and genes. Given more information like empirical protein-gene correlation, we might be able to construct more informative guidance graphs, but we have yet to test that.


feat: Webfinger support

Webfinger response.
curl https://vct.com/maple2021/.well-known/webfinger
{
   "subject":"https://vct.com/maple2021",
   "properties":{
      "https://trustbloc.dev/ns/public-key":"cHVibGljIGtleQ=="
   },
   "links":[
      {
         "rel":"self",
         "href":"https://vct.com/maple2021"
      }
   ]
}

Signed-off-by: Andrii Soluk<EMAIL_ADDRESS>

Codecov Report

Merging #45 (99bd720) into main (eca8d26) will decrease coverage by 0.02%.
The diff coverage is 88.88%.

@@            Coverage Diff             @@
##             main      #45      +/-   ##
==========================================
- Coverage   85.09%   85.07%   -0.03%
==========================================
  Files          13       13
  Lines        1731     1742      +11
==========================================
+ Hits         1473     1482       +9
- Misses        147      148       +1
- Partials      111      112       +1

Impacted Files
Coverage Δ

pkg/controller/command/models.go
100.00% <ø> (ø)

pkg/controller/command/command.go
81.92% <84.61%> (-0.01%)
:arrow_down:

pkg/client/vct/client.go
90.76% <100.00%> (ø)

pkg/controller/rest/operation.go
85.95% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eca8d26...99bd720. Read the comment docs.

@soluchok Also need the ledger type property.

@soluchok Also need the ledger type property.

Added "https://trustbloc.dev/ns/ledger-type":"append-only"


Let Travis ignore changes not related to pinot code

We should not trigger Travis tests if the changes we made was not
related to pinot code or Travis config.

[Current coverage][cc-pull] is 49.76%

Merging [#140][cc-pull] into [master][cc-base-branch] will decrease coverage by 0.40%

@@             master       #140   diff @@
==========================================
  Files           703        699     -4
  Lines         38520      38295   -225
  Methods           0          0
  Messages          0          0
  Branches       6194       6163    -31
==========================================
- Hits          19324      19057   -267
- Misses        19173      19218    +45
+ Partials         23         20     -3

Powered by Codecov. Last updated by [84a0dd4...0b806a4][cc-compare]
[cc-base-branch]: https://codecov.io/gh/linkedin/pinot/branch/master?src=pr
[cc-compare]: https://codecov.io/gh/linkedin/pinot/compare/84a0dd4afc2af2ae3dcaa391d46a9bfd0404e1a1...0b806a490eba7a6250c08dab0ce795029c2f111e
[cc-pull]: https://codecov.io/gh/linkedin/pinot/pull/140?src=pr

lgtm. For security issue, seems the consensus is to store the script in our local repo.


How to automate PlugInstall without having to run it manually inside Neovim?

:version
NVIM v0.4.3
Build type: Release
LuaJIT 2.0.5
Compilation: /usr/bin/cc -march=x86-64 -mtune=generic -O2 -pipe -fno-plt -O2 -DNDEBUG -DMIN_LOG_LEVEL=3 -Wall -Wextra -pedantic -Wno-unused-parameter -Wstrict
-prototypes -std=gnu99 -Wshadow -Wconversion -Wmissing-prototypes -Wimplicit-fallthrough -Wvla -fstack-protector-strong -fdiagnostics-color=always -DINCLUDE_G
ENERATED_DECLARATIONS -D_GNU_SOURCE -DNVIM_MSGPACK_HAS_FLOAT32 -DNVIM_UNIBI_HAS_VAR_FROM -I/build/neovim/src/build/config -I/build/neovim/src/neovim-0.4.3/src
 -I/usr/include -I/build/neovim/src/build/src/nvim/auto -I/build/neovim/src/build/include
Compiled by builduser

Features: +acl +iconv +tui
See ":help feature-compile"

   system vimrc file: "$VIM/sysinit.vim"
  fall-back for $VIM: "/usr/share/nvim"

Type:

[ ] Bug
[ ] Enhancement
[ ] Feature Request
[x] Question

OS:

[ ] All/Other
[x] Linux
[x] OS X
[x] Windows

Vim:

[x] Terminal Vim
[ ] GVim
[x] Neovim

I have a dotfiles-repo/setup.sh script that I normally run in my new OS installs. I set up my .vimrc file using vim-plug. Normally when I first run nvim, I manually run :PlugInstall to get everything set up.
But I am wondering if there is a way to automate this so I don't have to open nvim and manually run the command.
For example, I tried adding
nvim +PlugInstall

to my setup script, but that drops me into Neovim and requires hands-on.
How can I automate it in my bash script?

Duplicate of https://github.com/junegunn/vim-plug/issues/948


Hover Effect Added

Hover effect on Project section has been added
Before changes

After changes

Awesome PR @SoumyadeepOSD. Could you fix the lines around the cards though? There shouldn't be any lines around them

Awesome PR @SoumyadeepOSD. Could you fix the lines around the cards though? There shouldn't be any lines around them

Okay I'm looking into that matter

Thanks @SoumyadeepOSD!! Awesome PR by the way.

Fixes #499


execute niivue code

We could create a command to send code from an open editor to the niivue extension.
For example files ending in .niivue could execute in the extension, producing a niivue output.

Maybe it would be interesting to open .nvd files in vscode


challenger: shutdown if connection to lnd is lost

Fixes the issue Deny: Invoice status mismatch: no active or settled invoice found for hash=5e0... when aperture loses its connection to lnd. For now we just shut down so an orchestrator can restart it when the connection is available again.

It seems this only happens when lnd is re-deployed or restarted. Shutting down aperture and letting it be restarted should be a matter of a second or two. If we don't restart aperture, no new LSATs can be verified which is definitely worse for the uptime of the services gated behind the proxy.


[DEP0096] DeprecationWarning

[DEP0096] DeprecationWarning: timers.unenroll() is deprecated. Please use clearTimeout instead.
on mysql/lib/protocol/Protocol.js:  Timers.unenroll(sequence);
NodeJS 10

Unless someone knows another way, it's not really fixable in Node.js 10.0. The PR in Node.js https://github.com/nodejs/node/pull/20298 is rolling and so we'll then have a non-deprecated API to use hopefully in some future 10.x release.

Node.js 10.1 came out but not with the API we need, so we're still waiting for a Node.js release.

To update this: the needed API has been merged into Node.js 10.x branch now, and so it will be available with Node.js 10.2 I presume. The code still needs to be changed in this module to use the new APIs. I'm going to take a look, but if anyone is inclined to do so, you're also welcome to open a pull request with Node.js 10.x compat 👍

@florenthagard not sure if github would have sent a notice so I'll comment here, I've created a PR that addresses nodejs 10 compatibility.  semver 10.0 | 10.1 will still produce the deprecation warning as the new API is unavailable, the new API will be used by default for >=10.2.  Compatibility is accomplished by creating a setTimeout and clearTimeout ponyfill.  Both directly use the built-in nodejs functions if .refresh() is supported, otherwise both are re-implemented based on the deprecated API's.
I also fixed the error on test/unit/connection/test-connection-ssl-ciphers.js in nodejs 10.  When I ran the test locally (using nvm on Fedora 28) RC4-SHA was not an available cipher so the test failed.

I facing the same issue.. Please tell me, when can I expect this to be updated??

Same issue here, I'm wondering why the issue was closed.

The PR was merged, which closed related issues automatically. I was mainly hoping someone would test it out. Would you be willing to test the fix to validate before release? Install instructions in the last section of https://github.com/mysqljs/mysql#install

@dougwilson run npm console install mysqljs / mysql and correct the problem

Still In Node v10.6.0
(node:25325) [DEP0095] DeprecationWarning: timers.enroll() is deprecated. Please use setTimeout instead.
(node:25325) [DEP0096] DeprecationWarning: timers.unenroll() is deprecated. Please use clearTimeout instead.

What version of this module are you using?

v2.15.0

So 2.15.0 was published before Node.js 10 existed, let alone when this was fixed :) You just need to install the current version of this module to get the Node.js 10 support :+1:

Working<EMAIL_ADDRESS>

I have updated to node v10.8.0 and mysql version 2.16.0 and i am still getting this warning.  any thoughts?

Open a new issue with full code and steps to reproduce.


Add cookie related changes onto edx-theme

Update to common cookie banner

add timeout

dont block ui thread

fix the indentation

What does this PR do? Please provide some context
This is to cherry-pick cookie related changes onto Release branch, please check https://github.com/Microsoft/edx-theme/pull/117 for further information
Where should the reviewer start?
How can this be manually tested? (brief repro steps)
What are the relevant TFS items? (list id numbers)
Definition of done:

[ ] Title of the pull request is clear and informative
[ ] Add pull request hyperlink to relevant TFS items
[ ] For large or complex change: schedule an in-person review session
[ ] This change has appropriate test coverage

Reminders BEFORE merging

Get at least two approvals
If you're merging from a feature branch into the development branch then "flatten" or "squash" commits
If merging from the development branch into master (or porting changes from upstream) then use github's UI to get review feedback, but use the git command line interface to complete the actual merge.

Reminders AFTER merging

Delete the remote feature branch
Resolve relevant TFS items
(reverse merge) If you merged from the development branch into master then check to see if there are any changes in master that can be merged down to the development branch (like hotfixes, etc). In this case, use github's UI for feedback and the git command line interface for the actual merge.

in this case: please do a "merge commit" instead of "squash"