Parallelization of xgboost_ray.train results in Error

For cross-validation, we are attempting to parallelize xgboost_ray.train using ray.remote tasks. Each remote task uses a different cross-validation split of the data. Unfortunately, parallelizing xgboost_ray.train results in the below errors. If the same tasks are run sequentially, rather than in parallel, no errors occur. Below is a reproducible example based on xgboost_ray's documentation's example. If this is run locally, it completes. It's only when parallelized on a remote Ray cluster that it results in the below errors.
from xgboost_ray import RayDMatrix, RayParams, train
from sklearn.datasets import load_breast_cancer
import ray
import numpy as np

ray.init("ray://ray-cluster-head-svc:10001")

@ray.remote
def f():
    train_x, train_y = load_breast_cancer(return_X_y=True)

    # the amount of data is increased because with small amounts of data no ConnectionError is encountered
    train_x = np.tile(train_x, (10000, 1))
    train_y = np.repeat(train_y, 10000)

    train_set = RayDMatrix(train_x, train_y)
    evals_result = {}
    bst = train(
        {
            "objective": "binary:logistic",
            "eval_metric": ["logloss", "error"],
        },
        train_set,
        evals_result=evals_result,
        evals=[(train_set, "train")],
        verbose_eval=False,
        ray_params=RayParams(
            num_actors=2,  # Number of remote actors
            cpus_per_actor=1))

    bst.save_model("model.xgb")
    print("Final training error: {:.4f}".format(
        evals_result["train"]["error"][-1]))

# The same data is used for both tasks for the sake of this example, but for cross-validation,
#  the data passed to each task would be unique
ray.get([f.remote() for i in range(2)])

Traceback:
(freenome-risk-prediction-py3.10) ➜  risk-prediction git:(main) ✗ python risk_prediction/mre.py
(autoscaler +9s) Tip: use `ray status` to view detailed cluster status. To disable these messages, set RAY_SCHEDULER_EVENTS=0.
(autoscaler +9s) Adding 2 node(s) of type main.
(autoscaler +19s) Resized to 1 CPUs.
(autoscaler +19s) Adding 1 node(s) of type main.
(autoscaler +29s) Resized to 2 CPUs.
(autoscaler +45s) Adding 1 node(s) of type main.
(f pid=61, ip=<IP_ADDRESS>) [RayXGBoost] Created 2 new actors (2 total actors). Waiting until actors are ready for training.
Log channel is reconnecting. Logs produced while the connection was down can be found on the head node of the cluster in `ray_client_server_[port].out`
2023-08-10 14:11:59,613 WARNING dataclient.py:403 -- Encountered connection issues in the data channel. Attempting to reconnect.
2023-08-10 14:12:16,715 ERROR dataclient.py:330 -- Unrecoverable error in data channel.
Traceback (most recent call last):
  File "/home/zcarrico/.virtualenvs/freenome-risk-prediction-gzgYbMUP-py3.10/lib/python3.10/site-packages/ray/util/client/worker.py", line 455, in _get
    for chunk in resp:
  File "/home/zcarrico/.virtualenvs/freenome-risk-prediction-gzgYbMUP-py3.10/lib/python3.10/site-packages/ray/util/client/worker.py", line 324, in _get_object_iterator
    for chunk in self.server.GetObject(req, *args, **kwargs):
  File "/home/zcarrico/.virtualenvs/freenome-risk-prediction-gzgYbMUP-py3.10/lib/python3.10/site-packages/grpc/_channel.py", line 475, in __next__
    return self._next()
  File "/home/zcarrico/.virtualenvs/freenome-risk-prediction-gzgYbMUP-py3.10/lib/python3.10/site-packages/grpc/_channel.py", line 881, in _next
    raise self
grpc._channel._MultiThreadedRendezvous: <_MultiThreadedRendezvous of RPC that terminated with:
        status = StatusCode.FAILED_PRECONDITION
        details = "'NoneType' object is not iterable"
        debug_error_string = "UNKNOWN:Error received from peer ipv4:<IP_ADDRESS>:10001 {created_time:"2023-08-10T14:12:17.138947014+00:00", grpc_status:9, grpc_message:"\'NoneType\' object is not iterable"}"
>

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/home/zcarrico/risk-prediction/risk_prediction/mre.py", line 32, in <module>
    ray.get([f.remote() for i in range(2)])
  File "/home/zcarrico/.virtualenvs/freenome-risk-prediction-gzgYbMUP-py3.10/lib/python3.10/site-packages/ray/_private/auto_init_hook.py", line 24, in auto_init_wrapper
    return fn(*args, **kwargs)
  File "/home/zcarrico/.virtualenvs/freenome-risk-prediction-gzgYbMUP-py3.10/lib/python3.10/site-packages/ray/_private/client_mode_hook.py", line 102, in wrapper
    return getattr(ray, func.__name__)(*args, **kwargs)
  File "/home/zcarrico/.virtualenvs/freenome-risk-prediction-gzgYbMUP-py3.10/lib/python3.10/site-packages/ray/util/client/api.py", line 42, in get
    return self.worker.get(vals, timeout=timeout)
  File "/home/zcarrico/.virtualenvs/freenome-risk-prediction-gzgYbMUP-py3.10/lib/python3.10/site-packages/ray/util/client/worker.py", line 434, in get
    res = self._get(to_get, op_timeout)
  File "/home/zcarrico/.virtualenvs/freenome-risk-prediction-gzgYbMUP-py3.10/lib/python3.10/site-packages/ray/util/client/worker.py", line 477, in _get
    raise decode_exception(e)
ConnectionError: GRPC connection failed: <_MultiThreadedRendezvous of RPC that terminated with:
        status = StatusCode.FAILED_PRECONDITION
        details = "'NoneType' object is not iterable"
        debug_error_string = "UNKNOWN:Error received from peer ipv4:<IP_ADDRESS>:10001 {created_time:"2023-08-10T14:12:17.138947014+00:00", grpc_status:9, grpc_message:"\'NoneType\' object is not iterable"}"
>

I expect the same error will be encountered when parallelizing remote tasks for nested cross-validation for HPO.
Please let me know if you have any questions and thank you for the help and the great xgboost_ray library!

Far from an expert on the Ray library, but perhaps it's possible to use Ray Tune, with the hyperparameter specifying which i'th fold to use?
i.e. All same data is send to each tune run, but with each run sorts/randomizes data exactly the same (each same random order is required inside each tune run so as to have each sample be part of the val split exactly once), and have the ray tune param_space identifying which i'th split to use as val split for each run

Thank you @Anner-deJong , and this works with customizable training functions, but ray_xgboost isn't customizable beyond argument input as far as I know. In other words, the fold values could be passed as a hyperparam, but there's no way to pass a custom callable to ray_xgboost to have xgboost_ray select data based on the fold value hyperparameter.


add csv download button

fix #106

hi guys, I have just implemented few changes which should address your observations (see last commit) - thank you.
However, I have noticed two problems. Precisely, if I download the .csv file (columns and rows only) and I try to upload the same file in a second moment, all the connections are lost (problem A).
Also, the Or Else column is named Extra Column in the INA.columnNames variable: this generates an error during the uploading phase (problem B).
For problem A, I guess we should clarify first what's the purpose of this csv download button. If the downloaded file is needed to resume the project in a second moment, then we should elaborate a solution that does not loose the info relative to the connections between statements.
For problem B, @sjvrijn please, do you remember why the column is renamed at some point in the process?
Please, let me know your idea @suvayu and @sjvrijn @OleMussmann / Cheers :)

To me, A is not a problem, since I'm expecting the CSV download to only download the data in the table, which does not include the connections. I also wouldn't know how to nicely include that in the CSV anyway. For remembering the connections, we came up with the project .json download instead. We will have to make sure that it's clear which download option has which functionality, to not confuse people expecting connections to be remembered when downloading the table.

We will have to make sure that it's clear which download option has which functionality, to not confuse people expecting connections to be remembered when downloading the table.

Why shouldn't we always download everything (i.e. project + data)?

Thanks guys. Then, let's keep it as it is and wait for a feedback from the users as discussed during the meeting.
@sjvrijn - should we plan a meeting with the users? I can do that, or, if you prefer, you do that. Ups to you. Cheers e

Hi @sjvrijn @suvayu , should we temporarly merge this PR? I think once we get a sort of UI feedback from the users then we move the button elsewhere. Cheers, E

As long as you create an issue documenting the compromise (or unresolved issue), I think it should be okay to merge.


Feature Request: Return confidence of prediction

Pretty awesome project. Thanks a lot for sharing.
One Feature that would be really valuable to me would be to get some sort of "confidence" for the predictions. Do you think that is tricky to do? I would offer my help if you think that makes sense.

I am glad you like it.  You totally can do this - just modify this line, to get the value of the logit:
https://github.com/oliverguhr/german-sentiment-lib/blob/master/germansentiment/sentimentmodel.py#L32
If you decide to change the code I would appreciate a pull request :)

I needed the same thing and I overwrite the predict method in the class:
from typing import List
import torch
from germansentiment import SentimentModel
class SentimentModel(SentimentModel):
def init(self):
super().init()
def predict_sentiment_proba(self, texts: List[str])-> List[str]:
    texts = [self.clean_text(text) for text in texts]
    # Add special tokens takes care of adding [CLS], [SEP], <s>... tokens in the right way for each model.
    # truncation=True limits number of tokens to model's limitations (512)
    encoded = self.tokenizer.batch_encode_plus(texts, padding=True, add_special_tokens=True,truncation=True, return_tensors="pt")
    encoded = encoded.to(self.device)
    with torch.no_grad():
            logits = self.model(**encoded)

    #label_ids = torch.argmax(logits[0], axis=1)
    return [[i.item() for i in r] for r in torch.nn.Softmax(dim=1)(logits[0])], self.model.config.id2label

I added an API feature that does this with version 1.1.0
from germansentiment import SentimentModel

model = SentimentModel()

classes, probabilities = model.predict_sentiment(["das ist super"], output_probabilities = True)
print(classes, probabilities)

['positive'] [[['positive', 0.9761366844177246], ['negative', 0.023540444672107697], ['neutral', 0.00032294404809363186]]]


Google search engine clone

Clone of google search engine
Assign this issue to me under GSSOC'23

Have really did this much project or currently doing projects and clones in big numbers. I guess you are just doing for sack of points in gssoc. Online all projects are available we can get that as well. Too much issues and pr you have created of clones 😂😂
Like to know your point on it.

Have really did this much project or currently doing projects and clones in big numbers. I guess you are just doing for sack of points in gssoc. Online all projects are available we can get that as well. Too much issues and pr you have created of clones 😂😂 Like to know your point on it.

Everything we can find online . if I am doing for just sake of point then definitely I am on top of leaderboard 😅😂


(2) refactor: constants settings to networkSettings state

Acceptance Criteria

Replaces network constants by the networkSettings either from app storage or redux state.

The change here should not affect the wallet's operation.
Security Checklist

[ ] Make sure you do not include new dependencies in the project unless strictly necessary and do not include dev-dependencies as production ones. More dependencies increase the possibility of one of them being hijacked and affecting us.

Regarding the lint, I also resolve it in the PR(15), see: https://github.com/HathorNetwork/hathor-wallet-mobile/pull/360/commits/6e85529c681d4b7c3dadaf94acfe82217624ba41


Colin/withdrawal delay

Addresses #42
Name Changes
Priority: A 256 bit value where the left 128 bits correspond to when the utxo is exitable. If the utxo is older than 1 week, this is the block.timestamp + 1 week, otherwise it is utxo's creation time + 2 weeks. The right 128 bits represent the utxo's position. The priority is only used for storage in the priority queue.
Position: 256 bit unique value representing the position of a utxo on the plasma sidechain. This is represented by blockFactor * blockNum + txIndex * txIndexFactor + oIndex. This is as the key value when mapping to exits. This value users will be aware of.
I was forced to change the structure of startExitTransaction slightly because I was receiving a stack too deep error since too many local variables were being used

Pull Request Test Coverage Report for Build 347

30 of 31 (96.77%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.9%) to 90.444%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

contracts/rootchain/RootChain.sol
30
31
96.77%

Totals

Change from base Build 344:
0.9%

Covered Lines:
192

Relevant Lines:
205

💛  - Coveralls

Also, are confirm sigs NEEDED if the UTXO you're trying to exit is more than a week old? Seems unnecessary @colin-axner

@AdityaSripal In theory no they are not needed. But I could see applications use confirmation signatures to their advantage in practice. For example if you have some contracting service or maybe even rent payment. By transacting on a plasma chain, you can no longer spend that money, only exit it. I could send someone money for like a contract, then send them the confirmation signature upon completion. If I didn't then I would have to exit the utxo and they could use the legal system to show that they are due the amount I am withdrawing.
I do think verifying confirmation signatures on utxos older than week can be removed, but I think that should be viewed more as a feature or enhancement and should go in a different pr. Preferably one after version 1.0 so developers could decide which feature of the rootchain contract they would prefer.


Re-add target to make it visible to Carthage

Description
Third time is a charm?
Definition of Done

[] Has changes to Public API (Requires README update)
[] Updated README

Third time is a charm?

🤞 😄


gin-logrus doesn't replace logs, just adds new ones

I'm getting all the standard GIN logs mixed in with the Logrus ones, following the example.

use gin.New() don't use gin.Default()

@Yugloocamai Can you update if that worked so that the issue can be closed ?

I had the same problem and I can confirm that gin.New() instead of gin.Default() fix the issue


Redis storage

Mnemosyne needs alternative way to store sessions. Redis storage is one of missing ones.

Hey @piotrkowalczuk! is the idea to implement the following actions for redis storage?
 Such storage would have to pass already existing set of test scenarios.


Enhancement: Logger names

Adds logger names to the log row component (trailing content)

What is the log name?

@pleek91 it's the name of the logger


How to correct share between host and the container the import folder

Dear all,
I am wondering how to correctly write and read from my host user and the docker neo4j image the import folder.
This is my docker-compose file
version: "3"
services:
  neo4j:
    image: neo4j:latest
    hostname: neo4j
    container_name: neo4j
    ports:
      - "7474:7474"
      - "7687:7687"
    volumes:
      - $VOLUMES/neo4j/data:/data
      - $VOLUMES/neo4j/plugins:/plugins
      - $VOLUMES/neo4j/logs:/logs
      - ${PWD}/import:/var/lib/neo4j/import
    environment:
      - NEO4J_AUTH=neo4j/test
    network_mode: host

When the container starts the import folder is created but from my host user I cannot write and read data in it. Is there a possible solution?
Thank you.
Cheers,
Francesco

Hi @mnd999 and @jennyowen , thank you for your replies! I will check it out and let you know :)

Linking the volume to - ${PWD}/import:/import works like a charm :) Thank you guys, you are amazing! Take care


Fix for issue when MonitoringRoleARN is required

Description
Hello this PR aims to fix #136.
This was tested setting interval to 0 and afterwards 15 with custom role and worked.

Thanks, @flmmartins !
v1.35.0 has been released for Terraform 0.11 users.


An error occured while encoding the video

Hello, Franiac
Thank you for the great software!
But I have a problem with one video:
at the end of downloading a video I get this error: "An error occured while encoding the video".
There is no problem with other videos, only for this: https://www.twitch.tv/videos/140214533
Here is log:
Download task has been started!
TWITCH LEECHER INFO
Version: 1.3.7
VOD INFO
VOD ID: 140214533
Selected Quality: 640x360@25fps
Download Url: https://www.twitch.tv/videos/140214533
Crop Start: No
Crop End: No
OUTPUT INFO
Output File: D:\ВИДЕО\Speedruns\New folder (5)\Sonic Adventure DX_ Director's Cut_SADX Knuckles Story in 10_36.98.mp4
FFMPEG Path: C:\Program Files\Twitch Leecher\ffmpeg_x64.exe
Temporary Download Folder: D:\ВИДЕО\Speedruns\TEMP\TL_1321548f-5041-4d0f-b4b2-a18083f9e123
ACCESS INFO
Token: %7B%22user_id%22%3Anull%2C%22vod_id%22%3A140214533%2C%22expires%22%3A1494735141%2C%22chansub%22%3A%7B%22restricted_bitrates%22%3A%5B%5D%7D%2C%22privileged%22%3Afalse%2C%22https_required%22%3Afalse%7D
Signature: 335e5ce7ee4a621675054bc61934060c8a23846c
Sub-Only: No
Privileged: No
Creating directory 'D:\ВИДЕО\Speedruns\TEMP\TL_1321548f-5041-4d0f-b4b2-a18083f9e123'... done!
Retrieving m3u8 playlist urls for all VOD qualities... done!
https://vod.edgecast.hls.ttvnw.net/c2132d70e9_dage4_25205160064_643992999/chunked/highlight-140214533.m3u8
https://vod.edgecast.hls.ttvnw.net/c2132d70e9_dage4_25205160064_643992999/audio_only/highlight-140214533.m3u8
Playlist url for selected quality 640x360@25fps is https://vod.edgecast.hls.ttvnw.net/c2132d70e9_dage4_25205160064_643992999/chunked/highlight-140214533.m3u8
Retrieving playlist... done!
Parsing playlist... done!
Number of video chunks: 217
Starting parallel video chunk download
Number of video chunks to download: 217
Maximum connection count: 10
Parallel video chunk download is running...
Download of all video chunks complete!
Creating local m3u8 playlist for FFMPEG... done!
Writing playlist to 'D:\ВИДЕО\Speedruns\TEMP\TL_1321548f-5041-4d0f-b4b2-a18083f9e123\vod.m3u8'... done!
Executing 'C:\Program Files\Twitch Leecher\ffmpeg_x64.exe' on local playlist...
Command line arguments: -y -i "D:\ВИДЕО\Speedruns\TEMP\TL_1321548f-5041-4d0f-b4b2-a18083f9e123\vod.m3u8" -analyzeduration<PHONE_NUMBER> -probesize<PHONE_NUMBER> -c:v copy -c:a copy -bsf:a aac_adtstoasc "D:\ВИДЕО\Speedruns\New folder (5)\Sonic Adventure DX_ Director's Cut_SADX Knuckles Story in 10_36.98.mp4"
Starting temporary download folder cleanup!
Deleting directory 'D:\ВИДЕО\Speedruns\TEMP\TL_1321548f-5041-4d0f-b4b2-a18083f9e123'... done!
Download task ended with an error!
System.AggregateException: One or more errors occurred. ---> System.ApplicationException: An error occured while encoding the video!
at TwitchLeecher.Services.Services.TwitchService.EncodeVideo(Action1 log, Action1 setStatus, Action1 setProgress, Action1 setIsEncoding, String ffmpegFile, String playlistFile, String outputFile, CropInfo cropInfo)
at TwitchLeecher.Services.Services.TwitchService.<>c__DisplayClass55_0.b__2()
at System.Threading.Tasks.Task.Execute()
--- End of inner exception stack trace ---
---> (Inner Exception #0) System.ApplicationException: An error occured while encoding the video!
at TwitchLeecher.Services.Services.TwitchService.EncodeVideo(Action1 log, Action1 setStatus, Action1 setProgress, Action1 setIsEncoding, String ffmpegFile, String playlistFile, String outputFile, CropInfo cropInfo)
at TwitchLeecher.Services.Services.TwitchService.<>c__DisplayClass55_0.b__2()
at System.Threading.Tasks.Task.Execute()<---

Version 1.3.8 - same error.
Log:
Download task has been started!
TWITCH LEECHER INFO
Version: 1.3.8
VOD INFO
VOD ID: 140214533
Selected Quality: 640x360@25fps
Download Url: https://www.twitch.tv/videos/140214533
Crop Start: No
Crop End: No
OUTPUT INFO
Output File: D:\ВИДЕО\Speedruns\New folder (5)\Sonic Adventure DX_ Director's Cut_SADX Knuckles Story in 10_36.98.mp4
FFMPEG Path: C:\Program Files\Twitch Leecher\ffmpeg_x64.exe
Temporary Download Folder: D:\ВИДЕО\Speedruns\TEMP\TL_10512f5b-3379-4284-adce-47a2bff2b992
ACCESS INFO
Token: %7B%22user_id%22%3Anull%2C%22vod_id%22%3A140214533%2C%22expires%22%3A1494745796%2C%22chansub%22%3A%7B%22restricted_bitrates%22%3A%5B%5D%7D%2C%22privileged%22%3Afalse%2C%22https_required%22%3Afalse%7D
Signature: 13156c5d1f4b3fddcb3e1fc1bcb8ea3009c256a9
Sub-Only: No
Privileged: No
Creating directory 'D:\ВИДЕО\Speedruns\TEMP\TL_10512f5b-3379-4284-adce-47a2bff2b992'... done!
Retrieving m3u8 playlist urls for all VOD qualities... done!
https://vod033-ttvnw.akamaized.net/c2132d70e9_dage4_25205160064_643992999/chunked/highlight-140214533.m3u8
https://vod033-ttvnw.akamaized.net/c2132d70e9_dage4_25205160064_643992999/audio_only/highlight-140214533.m3u8
Playlist url for selected quality 640x360@25fps is https://vod033-ttvnw.akamaized.net/c2132d70e9_dage4_25205160064_643992999/chunked/highlight-140214533.m3u8
Retrieving playlist... done!
Parsing playlist... done!
Number of video chunks: 217
Starting parallel video chunk download
Number of video chunks to download: 217
Maximum connection count: 10
Parallel video chunk download is running...
Download of all video chunks complete!
Creating local m3u8 playlist for FFMPEG... done!
Writing playlist to 'D:\ВИДЕО\Speedruns\TEMP\TL_10512f5b-3379-4284-adce-47a2bff2b992\vod.m3u8'... done!
Executing 'C:\Program Files\Twitch Leecher\ffmpeg_x64.exe' on local playlist...
Command line arguments: -y -i "D:\ВИДЕО\Speedruns\TEMP\TL_10512f5b-3379-4284-adce-47a2bff2b992\vod.m3u8" -analyzeduration<PHONE_NUMBER> -probesize<PHONE_NUMBER> -c:v copy -c:a copy -bsf:a aac_adtstoasc "D:\ВИДЕО\Speedruns\New folder (5)\Sonic Adventure DX_ Director's Cut_SADX Knuckles Story in 10_36.98.mp4"
Starting temporary download folder cleanup!
Deleting directory 'D:\ВИДЕО\Speedruns\TEMP\TL_10512f5b-3379-4284-adce-47a2bff2b992'... done!
Download task ended with an error!
System.AggregateException: One or more errors occurred. ---> System.ApplicationException: An error occured while encoding the video!
at TwitchLeecher.Services.Services.TwitchService.EncodeVideo(Action1 log, Action1 setStatus, Action1 setProgress, Action1 setIsEncoding, String ffmpegFile, String playlistFile, String outputFile, CropInfo cropInfo)
at TwitchLeecher.Services.Services.TwitchService.<>c__DisplayClass56_0.b__2()
at System.Threading.Tasks.Task.Execute()
--- End of inner exception stack trace ---
---> (Inner Exception #0) System.ApplicationException: An error occured while encoding the video!
at TwitchLeecher.Services.Services.TwitchService.EncodeVideo(Action1 log, Action1 setStatus, Action1 setProgress, Action1 setIsEncoding, String ffmpegFile, String playlistFile, String outputFile, CropInfo cropInfo)
at TwitchLeecher.Services.Services.TwitchService.<>c__DisplayClass56_0.b__2()
at System.Threading.Tasks.Task.Execute()<---

This is a common issue. FFMPEG sometimes has problems merging Twitch VODs. This often happens when the streamer dropped frames or has a bad internet connection in general.
There is nothing TL can do about this. TL only uses FFMPEG to merge the downloaded VOD parts. If this fails, well... then it fails. I am sorry, but there is nothing I can do.


import version <IP_ADDRESS>

import version <IP_ADDRESS> from divimath:

import SNEAKY_FPV 's new font
HDMI in 1080p60
Less fan noise
Show connected if RapidFire is on
Analog adjusted slightly brighter
Disabled color kill

kind off, more than half of the divimath staff is currently sick, so there are not enough resources to fully transition everybody to this new git repo (they used svn previously). There are issues and feature request that need the attention of the few remaining divimath engineers however, so we are making due with manual syncs for the time being.


Migrated to View binding

While working on the Compose News Detail screen Kotlin 1.4.10 was giving errors about Kotlin synthetic. So I had to resort to ViewBindings or wait until Kotlin 1.4.20(https://issuetracker.google.com/issues/166927559).

* Where: Build file '/home/runner/work/News/News/app/build.gradle' line: 21
Breaks during the assignment of value to NEWS_API_KEY

I think it is best to do View Binding because kotlin android extensions actually deprecated. https://youtrack.jetbrains.com/issue/KT-42121

@rohithThammaiah Don't worry about the error on CI. It's an limitation of GitHub action where forks don't have access to the secrets which causes them fail.
I have been looking for workarounds / solutions for quite some time now 😞


pipe response of request to multipart request error

Hi,
I tried to pipe the response of a request into another multipart request. However it doesn't work. I always get such an error [Error: write EPIPE] code: 'EPIPE', errno: 'EPIPE', syscall: 'write'
What does this mean?
The code is like the following:
let res = request.get('http://localhost:8090/banner.jpg');
let req = request
  .put('http://localhost:8080/test.jpg', {
    formData: {
      file: res
    }
  })
  .on('response', (response) => {
    console.log('statusCode', response.statusCode);
  })
  .on('error', (err) => {
    console.log(err);
  });

Anything else I did wrong?
I tried to use form-data module directly and it works for me. Therefore I create an issue here. I guess it might be the reason of request module.
In addition, the same code above works if I put a file stream in the formData. That's really wierd...
Bg,
Kevin

Put encoding:null in your banner.jpg request.

I also got the same issue in the following code. And I've added the encoding:null flag.
var request = require('request');
var fs = require('fs');

var upload = request.post({url:"http://localhost:3000/file-upload",
    formData: {my_file: {value: request({url:'http://localhost:3001/', encoding:null}), options: {
        filename: 'sample.zip'
    }}}
});

The output is :
Error: write EPIPE
    at Object.exports._errnoException (util.js:856:11)
    at exports._exceptionWithHostPort (util.js:879:20)
    at WriteWrap.afterWrite (net.js:764:14)
{ [Error: write EPIPE]
  code: 'EPIPE',
  errno: 'EPIPE',
  syscall: 'write',
  address: undefined }

Two services on 3000 and 3001 are like the following:
var express = require('express');
var app = express();
var fs = require('fs');

app.get('/',function(req, res) {
    var file = fs.readFileSync(__dirname + '/file_for_download.zip', 'binary');
    res.write(file, 'binary');
    res.end();
});

app.listen(3001);

var express = require('express');
var multer = require('multer');

var app = express();
app.use(multer({
    dest: "./updloads"
}));

app.post('/file-upload', function(req, res, next) {
    console.log(req.body);
    console.log(req.files);
    res.end();
});

app.listen(3000);


Error" upload to filer error: rpc error" occured when writing billions small files via s3 gateway

update:
The third error occured yesterday.I found a interesting thing. This error seems to happed on certain amount of files.
The first error： [2021-02-03 09:26:55 070][INFO] Process: 11.96%(1196347130/10000000000), Ops: 6305/1s, Bandwidth: 23.25MB/1s(3.75TB), Error: 0.00%(34/10000000000)
The second error：[2021-02-05 03:53:51 071][INFO] Process: 22.70%(2270023401/10000000000), Ops: 1969/1s, Bandwidth: 8.13MB/1s(7.50TB), Error: 0.00%(113/10000000000)
The third error：[2021-02-07 01:40:36 070][INFO] Process: 33.44%(3343713356/10000000000), Ops: 5915/1s, Bandwidth: 21.70MB/1s(11.25TB), Error: 0.00%(200/10000000000)
Sponsors SeaweedFS via Patreon https://www.patreon.com/seaweedfs
Report issues here. Ask questions here https://stackoverflow.com/questions/tagged/seaweedfs
Please ask questions in https://github.com/chrislusf/seaweedfs/discussions
example of a good issue report:
https://github.com/chrislusf/seaweedfs/issues/1005
example of a bad issue report:
https://github.com/chrislusf/seaweedfs/issues/1008
Describe the bug
I am trying to test the performance of s3 gateway when uploading small files(filesize:1k,2k,4k.)
Error" upload to filer error: rpc error" occured when writing billions small files via s3 gateway.
The first error happend when<PHONE_NUMBER> files were uploaded.
The second error happed when<PHONE_NUMBER> files were uploaded.
Here are the logs of test tool:
[2021-02-03 09:26:53 070][INFO] Process: 11.96%(1196340762/10000000000), Ops: 6248/1s, Bandwidth: 22.88MB/1s(3.75TB), Error: 0.00%(0/10000000000)
[2021-02-03 09:26:54 070][INFO] Process: 11.96%(1196340825/10000000000), Ops: 63/1s, Bandwidth: 782.00KB/1s(3.75TB), Error: 0.00%(24/10000000000)
[2021-02-03 09:26:55 070][INFO] Process: 11.96%(1196347130/10000000000), Ops: 6305/1s, Bandwidth: 23.25MB/1s(3.75TB), Error: 0.00%(34/10000000000)
[2021-02-05 03:53:49 070][INFO] Process: 22.70%(2270016831/10000000000), Ops: 6841/1s, Bandwidth: 25.04MB/1s(7.50TB), Error: 0.00%(34/10000000000)
[2021-02-05 03:53:50 072][INFO] Process: 22.70%(2270021432/10000000000), Ops: 4601/1s, Bandwidth: 17.51MB/1s(7.50TB), Error: 0.00%(37/10000000000)
[2021-02-05 03:53:51 071][INFO] Process: 22.70%(2270023401/10000000000), Ops: 1969/1s, Bandwidth: 8.13MB/1s(7.50TB), Error: 0.00%(113/10000000000)
[2021-02-05 03:53:52 070][INFO] Process: 22.70%(2270030654/10000000000), Ops: 7253/1s, Bandwidth: 26.68MB/1s(7.50TB), Error: 0.00%(113/10000000000
System Setup

List the command line to start "weed master", "weed volume", "weed filer", "weed s3", "weed mount".
OS version :centos7.2
output of weed version version 2.21
if using filer, show the content of filer.toml

Expected behavior
A clear and concise description of what you expected to happen.
Screenshots
If applicable, add screenshots to help explain your problem.
Additional context
E0203 09:26:53 59074 s3api_object_handlers.go:330] upload to filer error: rpc error: code = Unavailable desc = transport is closing
E0203 09:26:53 59074 s3api_object_handlers.go:330] upload to filer error: failed to parse master : server should have hostname:port format:
E0203 09:26:53 59074 s3api_object_handlers.go:330] upload to filer error: failed to parse master : server should have hostname:port format:
E0203 09:26:53 59074 s3api_object_handlers.go:330] upload to filer error: failed to parse master : server should have hostname:port format:
E0203 09:26:53 59074 s3api_object_handlers.go:330] upload to filer error: failed to parse master : server should have hostname:port format:
E0203 09:26:53 59074 s3api_object_handlers.go:330] upload to filer error: failed to parse master : server should have hostname:port format:
E0205 03:53:49 59074 s3api_object_handlers.go:330] upload to filer error: rpc error: code = Unavailable desc = transport is closing
E0205 03:53:49 59074 s3api_object_handlers.go:330] upload to filer error: failed to parse master : server should have hostname:port format:
E0205 03:53:49 59074 s3api_object_handlers.go:330] upload to filer error: failed to parse master : server should have hostname:port format:
E0205 03:53:49 59074 s3api_object_handlers.go:330] upload to filer error: failed to parse master : server should have hostname:port format:
E0205 03:53:49 59074 s3api_object_handlers.go:330] upload to filer error: failed to parse master : server should have hostname:port format:
E0205 03:53:49 59074 s3api_object_handlers.go:330] upload to filer error: failed to parse master : server should have hostname:port format:
E0205 03:53:49 59074 s3api_object_handlers.go:330] upload to filer error: failed to parse master : server should have hostname:port format:
2021-02-07 01:40:32 071][INFO] Process: 33.44%(3343695440/10000000000), Ops: 6098/1s, Bandwidth: 22.09MB/1s(11.25TB), Error: 0.00%(113/10000000000)
[2021-02-07 01:40:33 070][INFO] Process: 33.44%(3343701204/10000000000), Ops: 5764/1s, Bandwidth: 21.19MB/1s(11.25TB), Error: 0.00%(113/10000000000)
[2021-02-07 01:40:34 070][INFO] Process: 33.44%(3343701323/10000000000), Ops: 119/1s, Bandwidth: 1.69MB/1s(11.25TB), Error: 0.00%(196/10000000000)
[2021-02-07 01:40:35 070][INFO] Process: 33.44%(3343707441/10000000000), Ops: 6118/1s, Bandwidth: 22.61MB/1s(11.25TB), Error: 0.00%(200/10000000000)
[2021-02-07 01:40:36 070][INFO] Process: 33.44%(3343713356/10000000000), Ops: 5915/1s, Bandwidth: 21.70MB/1s(11.25TB), Error: 0.00%(200/10000000000)

can you share you code how to reproduce this?

can you share you code how to reproduce this?

Could yu leave a email address? The test tool is too big to send via attachment

My email is chris dot lu at gmail dot com

I added a possible fix for this.

I added a possible fix for this.

Thanks for the quick fix.
I'll test it again!

any updates?

seaweed.log
In spring festival , I tested it again. And the same error  occured.
6300000000 files have been uploaded, and 538 files  failed.
The attachment is the error log. Thanks!


Not getting username and password for HTTP proxies

I am using HTTP/HTTPS proxies with my GoogleScraper module. I am currently using HTTP protocol with the proxies list in the file but when the Chrome opens for scraping, it still asks for username and password for the proxy in a dialog box.
I have also tried specifying HTTPS protocol with the proxies in the file but HTTPS proxies doesn't seem to work a little bit. And I get this error for HTTPS.
sqlalchemy.exc.IntegrityError: (sqlite3.IntegrityError) CHECK constraint failed: proxy [SQL: 'UPDATE proxy SET port=?, proto=? WHERE proxy.id = ?'] [parameters: ('80', 'https', 1)]

I get the same problem. Did you find a solution for this meanwhile?

How does your proxy file look like?

like this:
<IP_ADDRESS>:1071 proxuser:freeuse


phoebemirman/ch15787/long-resolution-source-and-smaller-screens

https://app.clubhouse.io/augur/story/15787/long-resolution-source-and-smaller-screens-trade-button-gets-pushed-over

Coverage remained the same at 64.573% when pulling df46b5d97f253721948339c5eda22c6a7109db69 on market-properties-style-adjustments into ac4eb854812b9c41032c626dffe5fdf0fe920947 on master.


Added VPC module

Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement
Learn more about why HashiCorp requires a CLA and what the CLA includes

VickyWinner seems not to be a GitHub user.
You need a GitHub account to be able to sign the CLA. If you already have a GitHub account, please add the email address used for this commit to your account.
Have you signed the CLA already but the status is still pending? Recheck it.


Update starter poms and bump version after 4.0.0-beta.1 release

As title.

/azp run java - spring - tests


Marten with CockroachDB

Did anyone try this before? Seems to have API compatibility with Postgres's API specifications

@jinhong- This is very interesting. CockroachDB fully supports PostgreSQL wire protocol compatibility and also supports JSONB since v2.0. I don't think anyone in the Marten community tried this. I think it will be worth trying out...

I personally have yet to try this. Was hoping someone here already have experience with it

Just a quick update, i deployed cockroachdb and attempted to hook it up with marten. Immediately after i attempted to run it, i get the following error: unknown function: pg_get_functiondef(). So i guess it's a no go

@jinhong, can you please go ahead and close this issue?

Will do. was hoping someone with more expertise on marten could give more insights and get it working

Even though CockroachDB has wire compatibility, Marten via Npgsql uses many
pg_* functions for schema management etc which won't be available in
CockroachDB. Besides we also use JavaScript functions via plv8 extensions.
I think it will be difficult to get it working with CockroachDB.
On Wed 12 Sep, 2018, 7:46 AM Jin<EMAIL_ADDRESS>wrote:

Will do. was hoping someone with more expertise on marten could give more
insights and get it working
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/JasperFx/marten/issues/1075#issuecomment-420488895,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ACu0UJX8upzMdCp6XOHIkWg4Qcorhub0ks5uaG5xgaJpZM4WLKJK
.

https://github.com/JasperFx/weasel/issues/78


Fix id after choosing a campaign (Admin panel)

Fixed id after choosing a campain in recurring donations in Admin panel:

Before
After

The id is set in handleCampaignSelected function when the user chooses a campaign. The issue was caused by setting an initail value on sourceVault when the id is already present, so I reset it to '' in the object.

As I understand it, sourceVault: data?.sourceVault.id sets the inital value if the id is present.
The same id is set for the second time when a campaign is chosen from the dropdown in this block of code:
handleCampaignSelected={(campaign) => {
   campaigns?.forEach((c) => {
       if (c.id === campaign && c.vaults) {
           setFieldValue('sourceVault', c.vaults[0].id)
        }
   })
}}

I thought we dont need the first initail setting of the value and it should be handled in the handleCampaignSelected() function.
This approach fixes the issue and seems not to cause unwanted side effects. It may be better approuches though. If you have some concerns and other better suggestions how to fix the issue, please advice.


[feature]: Add filters to ListAssets

Description
We should add filters to the ListAssets call, so that only assets that satisfy certain criteria are returned.
Examples of such filters could be:

GroupKey: only return assets that belong to the group with this key
MinAmount: only return assets with amount greater or equal to this value
MaxAmount: only return assets with amount less or equal to this value
ScriptKey: return all assets that use this script key
AnchorOutpoint: return all assets that are currently anchored on this outpoint

+1, script_key filtering would be useful in the case of a pocket universe operator. We implemented this in a roundabout way on Tajfi-server by first calling the UTXOs RPC, filtering the response by script_key, and then reconstructing balances accordingly. (this is assuming the Tajfi-serving is responding to a user's request for their balances, whereby the user provides us their pubkey, which is used as the script_key for all their Taproot Asset vUTXOs)

@itsrachelfish  how about: start with min amount and have a commit just for that to demonstrate method

@GeorgeTsagk, @itsrachelfish plans to update the structure for ListAssetRequest in rpcserver.go to include a new filter parameter.  Will you ACK/NACK approach?


Build failed Ubuntu 18.04.2 LTS (Windows 10)

How do I fix the problem?
Build failed Ubuntu 18.04.2 LTS

Can you try the develop branch? I believe this issue is fixed there and I want to be sure before potentially backporting the fix.

Develop looks to have the issue https://buildkite.com/EOSIO/eosio-base-images/builds/272

Please see https://github.com/EOSIO/eos/issues/7490

Develop looks to have the issue https://buildkite.com/EOSIO/eosio-base-images/builds/272

I don't see anything in that build related to this issue?

Sorry, posted to the wrong issue; ignore me

closing as dupe of #7490


How can I ignore a Property with Filter?

How can I get the search filter to be selective about the object properties?
Example:
Data being iterated over:
[{
      name: "Jake",
      favoriteFood: "Banana"
},
{
      name: "Max",
      favoriteFood: "Pizza"
}]

Goal is to only have the searchFilter respond to name searches
Input -> "Ja"
Result ->[{
      name: "Jake",
      favoriteFood: "Banana"
}]

Input -> "Banana"
Result ->[]

@Jonathan002  Currently this feature is not implemented but you can create your own custom pipe to achieve the same.
Custom Pipe (Create Angular Pipe):
import { Pipe, PipeTransform, Injectable } from "@angular/core";

@Pipe({
  name: 'deepFilter',
  pure: false
})
@Injectable()
export class Ng2DeepSearchPipe implements PipeTransform {

  /**
   * @param items object from array
   * @param term term's search
   */
  transform(items: any, term: string, props?: Array<string>): any {
    if (!term || !items) return items;

    return Ng2DeepSearchPipe.filter(items, term, props);
  }

  /**
   *
   * @param items List of items to filter
   * @param term  a string term to compare with every property of the list
   *
   */
  static filter(items: Array<{ [key: string]: any }>, term: string, columnsToExclude?: Array<string>): Array<{ [key: string]: any }> {

    const toCompare = term.toLowerCase();

    function checkInside(item: any, term: string) {
      for (let property in item) {
         if (columnsToExclude.some(x=> x === property)) {
          continue;
        }
        else {
          if (item[property] === null || item[property] == undefined) {
            continue;
          }
          if (typeof item[property] === 'object') {
            if (checkInside(item[property], term)) {
              return true;
            }
          }
          if (item[property].toString().toLowerCase().includes(toCompare)) {
            return true;
          }
        }
      }
      return false;
    }

    return items.filter(function (item) {
      return checkInside(item, term);
    });
  }
}

HTML Code:
 deepFilter: searchtext: ['columns to exclude_1','columns to exclude_2']"
Here is a working demo:
https://stackblitz.com/edit/angular-t1dzgn-qtynmr

@aVolpe Do we need this feature? I mean is this required?

@prashantpimpale93 maybe with the recent change to allow nested json this is needed.
Can you  make a PR for this? I only suggest changing the some with includes and make it by default to [] (also add the parameter to the transform method).

@aVolpe yes will make a PR!


How to run successfully window.onload function on page?

Hello, I try to inejct a little eventListener javascript into the target website. I want to return a result or console log when the window is loaded fully. This function is not working, how can I do this?
await Runtime.evaluate({
    expression: `
        window.onload = () => console.log('deneme');
    `
});

Take a look at #169.

Thanks so much. But my window.onload function is not working with this piece of code.
await Runtime.evaluate({
    expression: `new Promise((fulfill, reject) => {
        window.onload = () => {
            alert('rendered');
            fulfill();
        });
    })`,
    awaitPromise: true
});

It misses my onload function. How can exactly detect the Page is fully loaded all the contents?

If your only goal is to listen for that event you can use Page.loadEventFired or Page.domContentEventFired.
The above approach is not working because (I guess) the onload event is already fired when the script is injected.


buttercup-desktop: 2.21.0 -> 2.24.3

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://repology.org/project/buttercup-desktop/versions.
meta.description for buttercup-desktop is: Cross-Platform Passwords & Secrets Vault
meta.homepage for buttercup-desktop is: https://buttercup.pw
Updates performed

Version update

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact

Checks done (click to expand)

built on NixOS
The tests defined in passthru.tests, if any, passed
found 2.24.3 with grep in /nix/store/k0cvmmgs4qypv8q5dnywrsr2vpdzqy0z-buttercup-desktop-2.24.3
found 2.24.3 in filename of file in /nix/store/k0cvmmgs4qypv8q5dnywrsr2vpdzqy0z-buttercup-desktop-2.24.3

Rebuild report (if merged into master) (click to expand)

1 total rebuild path(s)

1 package rebuild(s)

First fifty rebuilds by attrpath
buttercup-desktop

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/k0cvmmgs4qypv8q5dnywrsr2vpdzqy0z-buttercup-desktop-2.24.3 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A buttercup-desktop https://github.com/r-ryantm/nixpkgs/archive/065b96aafe63d7723ebf122e8d022c7bf011410b.tar.gz

Or:
nix build github:r-ryantm/nixpkgs/065b96aafe63d7723ebf122e8d022c7bf011410b#buttercup-desktop

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/k0cvmmgs4qypv8q5dnywrsr2vpdzqy0z-buttercup-desktop-2.24.3
ls -la /nix/store/k0cvmmgs4qypv8q5dnywrsr2vpdzqy0z-buttercup-desktop-2.24.3/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

1 package built:

buttercup-desktop

Maintainer pings
cc @WolfangAukang for testing.

Result of nixpkgs-review pr 274369 run on x86_64-linux 1

1 package built:

buttercup-desktop


Added spack package file

This is the package file that will be used to install fiber within spack.  It is good to have this in the same repo as the main code so that the spack package can be updated in sync with the code base.   The package.py is base don Piotr's previous work, but after working on it for a while I realized that the fft library would be better represented as a multi-value variant instead of separate variants for each library.  One reason this is better is that it allows us to easily iterate over the list of supported libraries to reduce redundant configs in the package definition.

Is this needed for CI? This is too early in development to have a Spack package but if CI gets simplified then why not.

It isn't needed for CI, but I don't see any reason to not store the code right now in the repo even if we aren't going to immediately submit it to upstream spack.  By writing the spack package to work with the current cmake build, it helped me to understand how the cmake may be improved to make it work better with spack.


[Chip] disableRipple causes TypeScript error "No overload matches this call."

[x] The issue is present in the latest release.
[x] I have searched the issues of this repository and believe that this is not a duplicate.

Current Behavior 😯
disableRipple works as expected, however a TypeScript error is thrown.

TypeScript error
No overload matches this call.
  Overload 1 of 2, '(props: { component: ElementType<any>; } & { avatar?:
  ReactElement<any, string | ((props: any) => ReactElement<any, string | ... |
  (new (props: any) => Component<any, any, any>)> | null) | (new (props: any)
  => Component<...>)> | undefined; ... 9 more ...; variant?: "default" | ... 1
  more ... | undefined; } & CommonProps<...> & Pick<...>): Element', gave the
  following error.
    Property 'component' is missing in type '{ label: string; onClick: () =>
    void; disableRipple: true; }' but required in type '{ component:
    ElementType<any>; }'.
  Overload 2 of 2, '(props: DefaultComponentProps<ChipTypeMap<{}, "div">>):
  Element', gave the following error.
    Type '{ label: string; onClick: () => void; disableRipple: true; }' is not
    assignable to type 'IntrinsicAttributes & { avatar?: ReactElement<any,
    string | ((props: any) => ReactElement<any, string | ... | (new (props:
    any) => Component<any, any, any>)> | null) | (new (props: any) =>
    Component<...>)> | undefined; ... 9 more ...; variant?: "default" | ... 1
    more ... | undefined; } & CommonProps<...> & Pick<...>'.
      Property 'disableRipple' does not exist on type 'IntrinsicAttributes & {
        avatar?: ReactElement<any, string | ((props: any) => ReactElement<any,
        string | ... | (new (props: any) => Component<any, any, any>)> | null)
        | (new (props: any) => Component<...>)> | undefined; ... 9 more ...;
        variant?: "default" | ... 1 more ... | undefined; } & CommonProps<...>
        & Pick<...>'.ts(2769)
OverridableComponent.d.ts(17, 7): 'component' is declared here.

Expected Behavior 🤔
No TypeScript error should be thrown.
Steps to Reproduce 🕹
Steps:

Use TypeScript and Material-UI
Add the disableRipple prop to a Chip.

https://codesandbox.io/s/divine-star-nimfs?file=/src/Demo.tsx
Your Environment 🌎

Tech
Version

Material-UI
v4.11.0 and v5.0.0-alpha12

React
v16.13.1

TypeScript
3.9.7

tsconfig.json
{
    "include": [
        "./src/**/*"
    ],
    "compilerOptions": {
        "strict": true,
        "esModuleInterop": true,
        "lib": [
            "dom",
            "es2015"
        ],
        "jsx": "react"
    }
}

disableRipple isn't part of the Chip API afaik:
https://material-ui.com/api/chip/

@enricopolanski Is right, the prop is only available in some use cases. You can dodge the issue with:
import React from "react";
import { Chip } from "@material-ui/core";

export default function Demo() {
  const more = { disableRipple: true };
  return <Chip label="Material Chip" onClick={() => {}} {...more} />;
}

@oliviertassinari this still creates the following warning:
Warning: React does not recognize the `disableRipple` prop on a DOM element. If you intentionally want it to appear in the DOM as a custom attribute, spell it as lowercase `disableripple` instead. If you accidentally passed it from a parent component, remove it from the DOM element.

@enricopolanski @oliviertassinari If it isn't part of the API, how are we meant to disable the ripple effect on the chip? The solution above still spits out warnings which in turn make Jest fail
  console.error
    Warning: React does not recognize the `disableRipple` prop on a DOM element. If you intentionally want it to appear in the DOM as a custom attribute, spell it as lowercase `disableripple` instead. If you accidentally passed it from a parent component, remove it from the DOM element.


TypeError: callback is not a function

Hi,
I'm getting error while try to send to specific room a message:
TypeError: callback is not a function     at Encoder.encode (/home/XXX/Projects/dorix/node_modules/socket.io-parser/index.js:135:5)     at RedisAdapter.broadcast (/home/XXX/Projects/dorix/node_modules/socket.io-adapter/dist/index.js:102:45)     at RedisAdapter.broadcast (/home/XXX/Projects/dorix/node_modules/socket.io-redis/dist/index.js:267:15)     at Socket.emit (/home/XXX/Projects/dorix/node_modules/socket.io/lib/socket.js:171:18)     at EventsGateway.handleLogin (/home/XXX/Projects/dorix/packages/hub/dist/events/events.gateway.js:28:43)     at /home/XXX/Projects/dorix/packages/hub/node_modules/@nestjs/websockets/context/ws-context-creator.js:43:33     at process._tickCallback (internal/process/next_tick.js:68:7)
the code the throw the error:
socket.to(payload.parentBranchId).emit('incoming_order', 'dee');

Which version are you using? Please see https://github.com/socketio/socket.io-redis#compatibility-table

Which version are you using? Please see https://github.com/socketio/socket.io-redis#compatibility-table

I have the same issue. I tested my package version also.. please help me..

I have the same issue. I tested my package version also.. please help me..

Hello,
it works on
socket.io = 2.4.1
socket.io-redis = 5.4.0
but not works on latest versions (socket.io > 3.0.0 and socket.io-redis > 6.0.0)
please help me...

Hello,
it works on
socket.io = 2.4.1
socket.io-redis = 5.4.0
but not works on latest versions (socket.io > 3.0.0 and socket.io-redis > 6.0.0)
please help me...

I'm also facing with the latest version of socket.io and socket.io-redis it response callback is not a function

I'm also facing with the latest version of socket.io and socket.io-redis it response callback is not a function

@drizzef based on the stacktrace you provided, it seems there is a mismatch between:

the version of socket.io-parser: no dist (node_modules/socket.io-parser/index.js), which would mean no TypeScript (Socket.IO v2)
the version of socket.io-adapter: with dist (node_modules/socket.io-adapter/dist/index.js), which would mean with TypeScript (Socket.IO v3)

Could you please check in your dependency tree? The compatibility should be something like

socket.io@2 / socket.io-redis@5 / socket.io-adapter@1 / socket.io-parser@3
socket.io@3 / socket.io-redis@6 / socket.io-adapter@2 / socket.io-parser@4

@drizzef based on the stacktrace you provided, it seems there is a mismatch between:

the version of socket.io-parser: no dist (node_modules/socket.io-parser/index.js), which would mean no TypeScript (Socket.IO v2)
the version of socket.io-adapter: with dist (node_modules/socket.io-adapter/dist/index.js), which would mean with TypeScript (Socket.IO v3)

Could you please check in your dependency tree? The compatibility should be something like

socket.io@2 / socket.io-redis@5 / socket.io-adapter@1 / socket.io-parser@3
socket.io@3 / socket.io-redis@6 / socket.io-adapter@2 / socket.io-parser@4

I also faced the same issue. Installing the matched version from https://github.com/socketio/socket.io-redis#compatibility-table fixed it

I guess we can close this issue then.
For future readers, please check the compatibility table here.

@darrachequesne in order to install versions under 7 I have to use the deprecated npm package socket.io-redis instead of the new @socket.io/redis-adapter? Do you confirm this?

@giovanni-bertoncelli yes, that's right :+1:


Create UCAC4 566-071844

Thanks for opening this -- you should put all of the plans for the night into a folder named for that night, e.g. 2023-06-28
The plan that is supposed to run first for the night should have a name that begins "1-". The PR will check that if it starts with that plan, all of the plans will run. It doesn't do any of the format checking that ACP does so plans should be checked there too.

Looks like you might now be able to do that within the web interface, so you may need to fork, clone, etc....which I just realized you don't know how to do.
Can you try going here and let me know if you can click on the codespace?


Chore – Add OpenAPI documentation

The best thing would be to read openapi/README.md and give it a go to see that you can generate the docs and start the Swager UI server. I have changed several variables in Docker Compose to make things more flexible and less tied in to a specific directory layout in our host machines.
@upendrakumbham I’m very interested in your thoughts regarding this solution as compared to RestDocs, which you used in your API project.
@haideriqbal @lingyun1010 Please have a look at this since I’d like to document the whole application with this approach.
Accompanied by https://github.com/ebi-gene-expression-group/atlas-web-core/pull/76.

I changed this to to a draft to move this to RestDocs combined with https://github.com/ePages-de/restdocs-api-spec.


Update Button component to work as a link when it is wrapped in a Next/Link

Reason:
Closes "Update Button component to work as a link when it is wrapped in a Next/Link"
Changes made:

Added a storybook entry wrapping the button component with Next.js's Link component

Check off the following:

[x] I have reviewed my changes and run the appropriate tests.
[ ] I have have run rush change to add the appropriate change logs.
[x] I have added/edited docs.
[x] I have added tutorials.
[x] I have double checked and DEFINITELY added docs.

Since this is just a boilerplate to test the functionality and doesn't add up any new relevant code, it can be closed


Implement a new Insert API function (commitInChunks) that allows users to insert large numbers of new RawContacts much faster than commit

Problem
As discussed in https://github.com/vestrel00/contacts-android/discussions/317#discussioncomment-7107461, using the Insert API to insert large numbers of new RawContacts (e.g. 1,000) is much slower (by a factor of 5x-10x) than what is currently possible when not using the Insert API.
The Insert API inserts a single RawContact and all associated data in a single batched operation. This allows each insertion to be atomic with respect to a single RawContact.
However, inserting multiple RawContacts and all associated data in a single batched operation proves to be MUCH faster WITH THE CAVEAT that an error in the insertion of one RawContact may cause other RawContacts in the same batch to fail!
Solution
Provide a new function in the Insert API that allows library users to perform the insertion of multiple RawContacts in a single batch.
A good name for this new function is commitInChunks 😁

[x] Update Kotlin docs
[x] Update markdown docs (insert-contacts.md)
[x] Provide documentation on commit vs commitInChunks
[x] Provide async module functions
[x] Update gh-pages

This is included in release 0.3.2.


Address Data for United States, Missouri, Kansas City

Using MapZen (which uses OPenAddresses), I was unable to find several Kansas City, MO street addresses, for example:
5400 N Oak Trafficway, Kansas City, MO
Kansas City, MO seems to publish addresses with lat/lng in multiple formats with a public domain license:
https://data.kcmo.org/GIS/Geocoded-Kansas-City-Addresses/3639-4c86
I confirmed that the address above shows up in their dataset, but I'm not at all sure how to "submit" it to this project.

Oh, nice!  We have a source for Kansas City, MO but it appears to be broken.  We'll get this taken care.  Thanks for submitting the data!


Add german translation

Replaced umlauts in german translations with alternative spelling method to avoid any encoding problems etc.

It would be really nice if you opened a pull request on my repo so that the full commit history is maintained and we have no duplication of pull requests. I will merge it into my translation branch and it will appear in the original pr. I also noticed the problem with the umlauts and was about to remove them myself but i would rather do this approach so your work is visible. After that you can close this pr and i will merge your changes so they appear in the original pr. :D

Pull request was closed and is instead included in [ClientCrash/ly-dpmgr - Replaced umlauts in german translations pull request to have no duplication of pull requests.

It would be really nice if you opened a pull request on my repo so that the full commit history is maintained and we have no duplication of pull requests. I will merge it into my translation branch and it will appear in the original pr. I also noticed the problem with the umlauts and was about to remove them myself but i would rather do this approach so your work is visible. After that you can close this pr and i will merge your changes so they appear in the original pr. :D


Speedup Cmake builds

Rough improvement per platform:

Linux CPU: ~50%

Before: 5m18s - reference
After: 2m37s - reference

Linux GPU: ~50%

Before: 12m28s - reference
After: 6m23s - reference

MacOS CPU: ~50%

Conda setup time: ~1m
Before: 7m59s - reference
After: 4m22s - reference

Windows CPU: ~15%

Conda setup time: ~2.5m
Before: 8m30s - reference
After: 7m35s - reference

Windows GPU: ~25%

Conda setup time: ~7m
Before: 15m51s - reference
After: 13m40s - reference

Unlike Linux, MacOS and Windows do not have a separate step for setting up the Conda environment. Above I provide a rough estimation for it and I deduct it from the build times. I believe on Windows it's too close to call whether there is a substantial improvement.
The above are rough estimations based on a couple or runs.

The failing tests are not related to this PR.


[Question] File Missing (libplugin_rface.so) during Installation

During installation, I couldn't find a related file, "libplugin_rface.so".
Installation step 2
   Modify line 24 in src/kbds/app/face.py (actually src/kbdes/app/face/face.py)
    related code line
I downloaded the pre trained weight and other files from the Google Drive in Pre Trained section in ReadMe, but the "libplogin_rface.so" isn't included.
Where could I find the file?
Or should I compile to generate the file at the retinaface link in the ReadMe?

@cloudlakecho Yeah, it's a decode trt plugin generated by tensorrtx. Careful it should be bound with you trt file, .engine exactly. Since u said ur platform is arch_64, I suggest you to gen a new .engine model file step by step follow tensorrtx.

@zhouyuchong Thanks for the guide.
I have two additional questions:
   So instead of using ENGINE and SO files from the Google Drive, I have to generate them?
   The repository you shared looks like parents directory of retinaface and arcface in ReadMe. Could I use these two repositories to generate files?
     Though arcface link in your TensorRTx and ReadMe looks different.

@cloudlakecho yes, you better generate them since as my test before, trt file generated on different gpu device can't be compatibility with others.
I modifyed arcface compile codes based on original tensorrtx repo so it can compile successfully. The original one's tensorrt version is too old.

@zhouyuchong Thanks for explanation. I will try to generate ENGINE, SO and others from the link.


Fix master and upgrade esp32-hal

I accidentally merged a PR that broke master. Hopefully we can't do this anymore after tweaking github. I fixed that problem by refactoring our testing approach in 898c86ea32d14357a553fa893426bb1674a060e8. We now test a lot more as well and they are much easier to develop and read.
I then included #95 on top of that and then on top of that I made a fix in 3758c253c338413e3dee3e4fe953e5e24eb8aa1f
@musdom can you confirm how you determined the heap size in b3ef7d68f6a0153f00d53e8da2fc5a1f7a864296?

We used to allocate 320kB, but this new allocator only lets us use max 314kB.

We may want to keep the heap small just so we notice when it fills up come to think of it?

I think run_until will be very useful in the future.
Nice work fixing the hacky XOnlyPublicKey conversion.
Esp-hal changes are great too, looks much cleaner.
I left some small comments while going through but looks like I accidentally added them to individual commits and aren't showing here. I'll repost them.

We may want to keep the heap small just so we notice when it fills up come to think of it?

I tried leaving it small and it panics when doing a 3of4 keygen

This patch can be used to debug memory issues onscreen, highest i saw was ~14000b in a 3-of-3

patch
diff --git a/device/src/bin/frostypede.rs b/device/src/bin/frostypede.rs
index 1e8f14f..39d6f10 100644
--- a/device/src/bin/frostypede.rs
+++ b/device/src/bin/frostypede.rs
@@ -391,6 +391,9 @@ where
                 ConnectionState::Established => Rgb565::GREEN,
             });

+        self.display
+            .set_mem_debug(ALLOCATOR.used(), ALLOCATOR.free());
+
         self.display.flush().unwrap();
     }
 }
diff --git a/device/src/st7735.rs b/device/src/st7735.rs
index 2eebba9..9881ecd 100644
--- a/device/src/st7735.rs
+++ b/device/src/st7735.rs
@@ -310,4 +310,26 @@ where

         Ok(())
     }
+
+    pub fn set_mem_debug(&mut self, used: usize, free: usize) {
+        Rectangle::new(Point::new(80, 60), Size::new(80, 20))
+            .into_styled(
+                PrimitiveStyleBuilder::new()
+                    .fill_color(Rgb565::BLACK)
+                    .build(),
+            )
+            .draw(&mut self.framebuf)
+            .unwrap();
+
+        TextBox::with_textbox_style(
+            &format!("{}/{}", used, free),
+            Rectangle::new(Point::new(80, 60), Size::new(80, 20)),
+            MonoTextStyle::new(&FONT_7X14, Rgb565::GREEN),
+            TextBoxStyleBuilder::new()
+                .alignment(HorizontalAlignment::Right)
+                .build(),
+        )
+        .draw(&mut self.framebuf)
+        .unwrap();
+    }
 }


⚠ SceneTime has degraded performance

In 82168d4, SceneTime ($ST) experienced degraded performance:

HTTP code: 200
Response time: 1331 ms

Resolved: SceneTime performance has improved in d2751a0 after 8 minutes.


www.iherb.com - Unsupported browser on tablet

First reported on https://github.com/webcompat/web-bugs/issues/51731
URL: https://www.iherb.com/
Browser / Version: Duckduckgo Web Browser 5.50.1
Operating System: Android (Tablet)
Tested Another Browser: Yes Chrome
Problem type: Something else
Description: Browser upgrade notice
Steps to Reproduce:
A pop up shows up saying that the duckduckgo browser is unsupported

Thanks for reporting this issue, sometimes this happens for some sites and we have, inside our app, an option to "report broken sites" (check the three buttons menu in our browser). In there you will be able to assign a category, "the browser is incompatible" for example. Those reports are really helpful for us, and they are digested by a different team.
Closing this issue, thanks.


Version 3.3.1 requires Swift 2.2

This really isn't a bug, but you might want to correct the README.md to indicate that with the changes made as of March 23, 2016 (to Manager.swift in particular). the use of #selector requires Swift 2.2
Swift 2.2 comes with Xcode 7.3, El Capitain.
I ran into this issue since I am still running Yosemite with Swift 2.1.1 and Xcode 7.2.1.  I just thought others might want to know...
Thanks.

It is part of the release notes for 3.3.0. But you're right, the general README and other documentation should be audited to reflect this requirement.

Apologies for not getting this updated properly with the 3.3.0 release @PattyHarris. This has been corrected in 3b1edd80.
Thanks! 🍻

Cool - this is all new to me :)   Thanks so much!


Change API name suffix from Api to Client for logging

@swcloud Can you add me as a contributor to your fork so that I can update this PR?

@quartzmo Done.

I confirm that this is my commit and I am okay with these commits being contributed to Google.

@blowmage I believe this PR is good to merge. Acceptance tests passing locally for me.


add basic implementations for user auth

replace UserProxy with UserAuthenticating
add update method
build email html again

LGTM 👍


Spike train covariance based on elephant.spike_train_correlation.corrcoef() function

This task is used to build the cross-covariance function, which should be closely related to the cross-correlation function.

Possible to make these two functions modular (e.g., corrcoef() calling covariance() for the denominator?)
Shared unit tests?

Development on branch feature/cov

Pushed first working version with unit tests -- up for testing.

Idea: Make corrcoef and covariance more module (__denominator, __enumerator())

Ready for pull request, waiting for pandas issue #33 to be fixed.

See now in NeuralEnsemble#36


[2.3]Fix China hosted k8s issue

Proposed changes

update ACK k8s version
Fix Huawei cce edit issue

Types of changes

Bugfix (non-breaking change which fixes an issue)

Linked Issues
https://github.com/rancher/rancher/issues/19148
https://github.com/rancher/rancher/issues/19147

Further comments

These are obviously going to continue to get out of date, can you just read them from the API instead of hardcoding in the UI?

@vincent99 Now we are using a sdk which only supports standard Alibaba Cloud API format.
However, the API for getting k8s version which is used in Alibaba Cloud console is not standard. And there is no document for it. So we didn't find out how to do the authentication stuff.
We have asked the Alibaba Cloud dev today if they have a standard API to get the versions.
We will track it in https://github.com/rancher/rancher/issues/19152


Add Ubuntu 22.04

WIP problems

[x] LXDE launch error

Patches

https://github.com/python-greenlet/greenlet/pull/161
https://github.com/fcwu/docker-ubuntu-vnc-desktop/pull/247

LXDE launch error
LXDE shows "Failed to close file descriptor for child process" error

Adding --security-opt seccomp=unconfined flag while launching docker container solved the problem.
https://github.com/linuxserver/docker-digikam/issues/22#issuecomment-1193147081

Pushed the pre-build docker image to the Docker Hub.
https://hub.docker.com/layers/ubuntu-desktop-lxde-vnc/tiryoh/ubuntu-desktop-lxde-vnc/jammy-amd64-20220725T0203/images/sha256-4bdbe984025685878ffd599dbbd4d9619608b331e2a96c3510dd8bc2074b471f?context=explore

Pushed the pre-built docker image to the Docker Hub.
amd64 https://hub.docker.com/layers/ubuntu-desktop-lxde-vnc/tiryoh/ubuntu-desktop-lxde-vnc/jammy-20220725T2250/images/sha256-af0faa687b71119ea0101a89fd5f754daced09d43cc272eff1957aa437d4be86?context=repo
arm64 https://hub.docker.com/layers/ubuntu-desktop-lxde-vnc/tiryoh/ubuntu-desktop-lxde-vnc/jammy-20220725T2250/images/sha256-04fd5aa9c238f1fcb7392d8f5346ff75803bac8c2d0e9befef5a0d19226ca13a?context=repo

Pushed the pre-built docker image to the Docker Hub.
amd64 https://hub.docker.com/layers/259957727/tiryoh/ubuntu-desktop-lxde-vnc/jammy-20220726T0158/images/sha256-2cf781d35528e39a9401e685c058b3e646e394b7df92c998ec917ce330d0c3dd?context=repo
arm64 https://hub.docker.com/layers/259957727/tiryoh/ubuntu-desktop-lxde-vnc/jammy-20220726T0158/images/sha256-2ff13041e8473863c134ae4391145f8734971696868ff0c71ae956193807ef90?context=repo


OCPBUGS-10492: Abandon HCP cleanup after a timeout

What this PR does / why we need it:
Sets up a timeout for hostedcontrolplane deletion after which any pending cleanup is abandoned and the finalizer on the hostedcontrolplane is removed.
This will prevent a hostedcluster delete from hanging forever if there is something preventing the deletion of resources it needs to cleanup. Currently the timeout is set at 3 hrs.
Which issue(s) this PR fixes (optional, use fixes #<issue_number>(, fixes #<issue_number>, ...) format, where issue_number might be a GitHub issue, or a Jira story:
Fixes #OCPBUGS-10492
Checklist

[x] Subject and description added to both, commit and PR.
[x] Relevant issues have been referenced.

/jira refresh

To my view this is desired behaviour and I could arg that skipping with a timeout would be a bug. Seems legit and a good thing to me that we honour AWS constraints and block the HC deletion if the cloud resources deletion is not possible because of a legit reason.
In this scenario I'd expect us to signal this better in a condition. A consumer already has the means today to make a conscious decision and they can skip deletion by tweaking the CleanupCloudResourcesAnnotation.

/close


Label Positioning

The labels show to the far right depending on the whitespace and ordering in your markup:

This example HTML file reproduces:

  <link rel="stylesheet" href="https://cdnjs.cloudflare.com/ajax/libs/materialize/0.97.7/css/materialize.min.css">

  <input id="comment" name="comment">broken

  <input id="comment" name="comment">
  working

  also working<input id="comment" name="comment">

I would credit this issue to user (my 😄 ) error, except the docs show the  tag coming after the <input>/<textarea> tag, so I expect this is a common point of confusion for new people.  For generated HTML the developer might not be able to specify the newlines.  I was using React when I noticed it.
I'm not sure if a doc fix or a code fix is more appropriate.  What do you think?

Hmm, I cant seem to reproduce the first issue. What OS and browser are you using? And have you tried on the latest master branch?

Ah sorry for the lack of detail!  I tried Chrome, Safari, and Firefox on OSX.
I'm seeing the same issue on master.  I checked it by changing the <link> tag above to a


datapath: to-netdev does not recirculate back after SNAT handling

In the bpf_host's egress section to-netdev we have the following code block https://github.com/cilium/cilium/blob/6c647ba7b06c93bf0350907255ab3c43154810b5/bpf/bpf_host.c#L1079-L1094
The problem with it is that handle_nat_fwd() does not recirculate back to to-netdev which makes the following trace notify ineffective https://github.com/cilium/cilium/blob/6c647ba7b06c93bf0350907255ab3c43154810b5/bpf/bpf_host.c#L1102
Discovered together with @gandro. cc @borkmann

I made some discussions regarding this issue with @brb and @borkmann. Below is a summary.
The Problem
Currently, WG with KPR implementation is ongoing. In that implementation, we need to redirect the packet to the WG device in to_netdev. However, before that, we need to first SNAT the packet, then redirect. If we call into handle_nat_fwd, it does tail-call and sends the packet to the network device. So that we don't have any chance to redirect the packet to the WG device. Recirculation is one of the solutions to that problem.
Recirculation is not needed?
The users of this handle_nat_fwd (SNAT) is 1) BPF Masquerade 2) Some host applications that can reach the NodePort service endpoints (https://github.com/cilium/cilium/pull/8649/commits/b6de3922afa935b77af0cbb07693993cb44c394b).
However, in both cases, we WG shouldn't be involved. The remaining case that the WG should be involved in is NodePort SNAT (and reverse NAT), but NodePort SNAT is already performed in here, so no problem.
Conclusion
In a conclusion, what we need to do is just add packet trace inside the handle_nat_fwd and that should be the scope of this issue.


Kestrel functional tests are flakier in the Win10-Universe build configuration

Not sure if this is an issue with the build configuration or the tests themselves. But http://aspnetci/viewType.html?buildTypeId=XPlat_Windows_Win10Universe&tab=buildTypeHistoryList shows recent builds have almost all failed with test failures in the Microsoft.AspNetCore.Server.Kestrel.FunctionalTests namespace.
The failures are not particularly consistent beyond their shared namespace / test project. For example AddressRegistrationTests holds many of the failing tests. But, that test class isn't among the culprits for all failed builds and the individual tests vary quite a lot.
I've also seen that some of the sometimes-failing tests are flakier in this particular configuration. For example, http://aspnetci/project.html?projectId=XPlat&testNameId=5785442856196240460&tab=testDetails shows that AddressRegistrationTests.DefaultsServerAddress_BindsToIPv4 passes 99.8% of the time in all Test build configurations. That rate drops to 98.6% when focusing only on Win10-Universe (http://aspnetci/project.html?tab=testDetails&testNameId=5785442856196240460&projectId=XPlat&buildTypeId=XPlat_Windows_Win10Universe). The success rate also looks much worse in builds from the 21st on.

@muratg @ryanbrandenburg this issue covers the remaining flaky tests I noticed over the weekend aka the "pattern" as you described it @muratg. Filed it here because so many of the failures I saw were in one place after I skipped a couple of MvcPrecompilation tests. Of course, issue may still be a quirk of this build configuration.

Looks like standard port binding failures.

Why would it be more common with Windows 10?

It could be an agent issue, there's only one Win10 agent.

This problem continues.

These address binding tests should be more reliable after 0e99235 moved the binding tests to their own test group.


Signed-off-by: Asra Ali<EMAIL_ADDRESS>
Summary

Ticket Link

Fixes

Fixes key revocation when revoking the root keys from the snapshot and timestamp roles (that are now online) https://github.com/theupdateframework/go-tuf/issues/167
Correctly sets the thresholds for root and targets (3 out of 5 keyholders) and for snapshot and timestamp (1 online key)
Increases the expires for snapshot/timestamp to 3 weeks to allow a buffer for the biweekly signing
Fixes the bug with adding signatures. AddOrUpdateSignature from go-tuf doesn't handle our placeholder signatures

Supersedes https://github.com/sigstore/root-signing/pull/35
Release Note

Approved FWIW but unfortunately I have no approval rights here 🙂


Use composable filters instead of helper filters

@bonustrack instead of switching the whole component to the CAPI, which would easily create another huge PR mess, I think we could move part by part (like I did here). This way we can focus on each part separately and keep things organized.

Wrong branch..


Default features of dependencies get pulled in for no reason

When building webrender_traits with https://github.com/servo/webrender/pull/430, even running cargo build --no-default-features --features serde_derive ends up building serde_codegen with its feature with-syntex. This should not happen.

Cc @alexcrichton

Hm what version of Cargo are you using actually? I just used cargo 0.13.0-nightly (cbe47ed 2016-09-29) locally and got:
features: {
  offscreen_gl_context v0.4.4: {"serde", "serde_serialization", "default"}
  unicode-xid v0.0.3: {"default"}
  serde v0.8.11: {"std", "default"}
  app_units v0.3.0: {"default"}
  byteorder v0.5.3: {"std", "default"}
  uuid v0.3.1: {"rand", "v4"}
  bincode v0.6.0: {"serde", "rustc-serialize", "default"}
  libc v0.2.16: {"use_std", "default"}
  serde_codegen v0.8.11: {"with-syn"}
  webrender_traits v0.6.0 (file:///home/alex/code/lol): {"serde_derive"}
  x11 v2.8.0: {"xlib"}
  log v0.3.6: {"use_std", "default"}
  syn v0.8.7: {"quote", "unicode-xid", "aster", "printing", "default", "visit", "parsing"}
}

which looks correct? Maybe we fixed this bug? (not that I remember it)

@alexcrichton
cargo 0.13.0-nightly (ebcf0a8 2016-10-03)

And in Cargo.lock:
[[package]]
name = "serde_codegen"
version = "0.8.11"
source = "registry+https://github.com/rust-lang/crates.io-index"
dependencies = [
 "quote 0.2.3 (registry+https://github.com/rust-lang/crates.io-index)",
 "serde_codegen_internals 0.9.0 (registry+https://github.com/rust-lang/crates.io-index)",
 "syn 0.8.7 (registry+https://github.com/rust-lang/crates.io-index)",
 "syntex 0.44.0 (registry+https://github.com/rust-lang/crates.io-index)",
 "syntex_syntax 0.44.0 (registry+https://github.com/rust-lang/crates.io-index)",
]

Hm it looks like there's something else in play here because it works if I use the exact Cargo.toml from webrender_traits. What Cargo.toml are you building from again to reproduce?

The one in 94437c4bbbee843e172dfc306b113a13a8a840c8, which is the tip of the PR I linked.

I wonder if that is related to https://github.com/rust-lang/cargo/issues/1197, it's certainly similar.

If the "bug" is that syntex_syntax is mentioned in Cargo.lock then that's not a bug. There exists a mode to build webrender_traits which builds the syntex_syntax crate, so it must be in the lock file.

I see! Now that makes sense. Closing this then!


Edit a line in a new page or in a popup/modal as the create feature

Hello @Mewriick
I'd like to edit lines in a new page or in a popup/modal, like in the creation of a new line is it possible ? or at least an event on modify button so i can do it myself ?

Im asking 'cause i need to include a WYSIWYG (TinyMCE) into one of the column but the table isnt wide enough to handle its textarea :/

Hello @Methraen
the edit feature is only inline. But you can create your own column with button.
For now best approach will be attach edit button in column which you want edit (you can hide button with css and show it only in hover)
Or you can add new property into your model and into this column you can render all your action buttons.
I will consider more extensiability for action buttons


Missing activation function

I think you are missing activation function in the last Dense layer of the model, which in this case should be "softmax", as you are predicting one of given classes of documents. According to the Keras documentation:

Activation function to use (see activations). If you don't specify anything, no activation is applied (ie. "linear" activation: a(x) = x).

Hey, @adamwawrzynski,
You are right that I didn't add softmax function explicitly. Instead, I have used it in hyperparameters.
https://github.com/Hsankesara/DeepResearch/blob/master/Hierarchical_Attention_Network/HAN.py#L60
You can check it out using the above link. I did it to make the model more flexible. Thanks for taking your time and go through the code. Please let me know if you have any doubt.

@Hsankesara I see, but You forgot to use this hyperparameter inside creation of your neural network. 'activation' hyperparameter is used only once, during definition. I saw this issue during my research on NLP. I am refering to and using Your implementation of HAN network in my Master's thesis (its released on MIT license).

Hey, @adamwawrzynski,
You are right I have missed it. I'll add it as soon as possible. I am glad that you're using my implementation in your thesis and wish you all the best for it.

Hey @adamwawrzynski,
I updated the model and added the activation function. Thanks for letting me know about it.

@Hsankesara now it looks correct. My Master's thesis is uploaded on my github page, if You are interested :)

I would love to check it out. Thanks and all the best for the future.


fix non-exhaustiveness bug

We will not treat a constructor that is an injection as if it makes the
match non-exhaustive if the sort injected into has no productions that
are not injections.

@dwightguth maybe add "Fixes: kframework/k#1221", unless you intend the PR into K that fixes it to be the one that you do that with.

It's better to let the issue be closed by the front end pr


[FEATURE REQUEST] add an additional overlay in the events section of the UI

Motivation
if we want to have a detailed view of en event, in the "events" section we need to scroll horizontally which is not great for UX
Feature
is there any way to add an clickable overlay so when click on a events we can have the details of it without having to scroll ?
Alternatives
so far none
Additional context
so far none

Can you paste here an example of an event you need to horizontally scroll please? It might be an issue with the small responsive feature. The details are supposed to word wrap.


fix(MsgPublish): fix cannot initialized editor jump from creation page

fix:#427

It seems works when I set a watcher to  the router changes:

It seems works when I set a watcher to  the router changes:


typeError-...is not a function in doc

Error: https://prnt.sc/K2MT1kktDS4b

I found this error while I was working on my machine. Then I solved it. This also needs to be changed in the Next.js documentation and GitHub also so that no one else has the same problem/error.

Next.js doc: https://nextjs.org/learn/basics/dynamic-routes/implement-getstaticprops
Folder directory: next-learn/basics/dynamic-routes-step-1/pages/posts/[id].js

https://github.com/vercel/next-learn/blob/master/basics/dynamic-routes-step-1/pages/posts/%5Bid%5D.js

Line no 2:
import { getAllPostIds, getPostData } from '../../lib/posts'

Replace it with this line:
import getAllPostIds, { getPostData } from "../../lib/posts";

Thank you.

I hope this will solve the error/problem.

@RaisulislamRimon this change should not be necessary. getAllPostIds is not a default export, and thus, needs to be imported with the curly brackets.


[WIP] Use multiarch Golang builder

What this PR does / why we need it:
Support ARM and be able to build Serving images in on a heterogenous cluster in CI.
Link to Slack thread where this new image was mentioned.
Note: The new image is available only in CI. If somebody wants to use those Dockerfiles and built images locally they need to have an authfile in json format (it's possible to download it from a running CI job).
Image metadata:
skopeo inspect --raw --authfile=dockerconfig.json docker://registry.ci.openshift.org/ocp/builder:rhel-9-golang-1.21-builder-multi-openshift-4.16
{
    "manifests": [
        {
            "digest": "sha256:8c44fc7f6f3fcdd844f94f7aeba3e3fabb723943ce04dfce449960bf9c71a815",
            "mediaType": "application/vnd.docker.distribution.manifest.v2+json",
            "platform": {
                "architecture": "amd64",
                "os": "linux"
            },
            "size": 922
        },
        {
            "digest": "sha256:41a80f39d422fedb68d3462db6050ec0e19b2351f956cd6f97f624f7947684fb",
            "mediaType": "application/vnd.docker.distribution.manifest.v2+json",
            "platform": {
                "architecture": "arm64",
                "os": "linux"
            },
            "size": 922
        },
        {
            "digest": "sha256:7d6f9f7dd670f9ccb87d369ea52081937faa1e18b66a3187e16ef2f2ef3fd336",
            "mediaType": "application/vnd.docker.distribution.manifest.v2+json",
            "platform": {
                "architecture": "ppc64le",
                "os": "linux"
            },
            "size": 922
        },
        {
            "digest": "sha256:21957552890abebfdc42eee30982c690aa16e0c7d5032e3c063201a29ec055e7",
            "mediaType": "application/vnd.docker.distribution.manifest.v2+json",
            "platform": {
                "architecture": "s390x",
                "os": "linux"
            },
            "size": 922
        }
    ],
    "mediaType": "application/vnd.docker.distribution.manifest.list.v2+json",
    "schemaVersion": 2
}

Which issue(s) this PR fixes:
JIRA: https://issues.redhat.com/browse/SRVKS-1024
Does this PR needs for other branches:
release-v1.13, main

/cherry-pick release-v1.13
/cherry-pick main
Does this PR (patch) needs to update/drop in the future?:

NONE

I'm not sure if the new images are used in tests running on this PR. Maybe we also need to update the CI config:https://github.com/openshift/release/blob/master/ci-operator/config/openshift-knative/serving/openshift-knative-serving-release-v1.12__414.yaml#L2

Note to self. Other repositories like Eventing, EKB use the following to generate the dockerfiles:
GO111MODULE=off go get -u github.com/openshift-knative/hack/cmd/generate

$(go env GOPATH)/bin/generate \
  --root-dir "${repo_root_dir}" \
  --generators dockerfile \
  --dockerfile-image-builder-fmt "registry.ci.openshift.org/openshift/release:rhel-8-release-golang-%s-openshift-4.16"

So, the image needs to be updated there and the generate command needs to be re-run via github action "Run Makefile target" on openshift-knative/hack

We might skip 1.12 branch correct?

We might skip 1.12 branch correct?

What do you mean by that?

@mgencur are you still working on this or can it be closed?

Let's close it. Out of date.


⚠ Mobitopup has degraded performance

In f63b971, Mobitopup (https://napcard.voz.tech) experienced degraded performance:

HTTP code: 200
Response time: 6360 ms

Resolved: Mobitopup performance has improved in badf165.


WIP: Introduce gormsupport.Versioning to auto increment a model's Version on update and set to 0 on create

TL;DR
This fictional code:
type MyModel struct {
  Version int
  Name string
  // more fields
}

model := MyModel{}

// Increment version of model that we're about to save
oldVersion := model.Version
model.Version = model.Version + 1

// Check the model we're trying to update has the correct version.
db.Where("Version = ?", oldVersion).Save(&model)

// Check the model we're trying to delete has the correct version.
db.Where("Version = ?", oldVersion).Delete(&model)

can be simplified to just:
type MyModel struct {
  gormsupport.Versioning
  Name string
  // more fields
}
model := MyModel{}
db.Save(&model)
db.Delete(&model)

This is

less error prone,
unclutters the code and
nicely automated.

About
The change is best explained with a comment from the code.
// Versioning can be embedded into model structs that want to have a Version
// column which will
//
// * automatically be incremented before each UPDATE,
// * set to 0 on CREATE,
// * and checked for compatibility on each UPDATE and DELETE.
//
// For the first creation of a model the initial version will always be
// overwritten with 0 nomatter what the user specified in the model itself. The
// model itself is not changed in any cases, just the DB query for INSERT and
// UPDATE is touched.
//
// We also add
//
//    AND version=<VERSION-OF-THE-MODEL>
//
// to the WHERE conditions of the UPDATE part.
type Versioning struct {
	Version int `json:"version"`
}

At first sight it doesn't look like this PR is helping much but we can easily forget to increment a Version field on UPDATE or to set it to 0 on INSERT. If you embed gormsupport.Versioning in your struct this cannot happen because Gorm will call the BeforeUpdate/BeforeCreate function of any model object if it exists.
We make sure that upon creation the version will be 0, no matter what the user specified. This is done with the BeforeCreate callback.
What models already embed the Versioning struct?

[x] workitem.WorkItemStorage
[x] workitem.WorkItemType
[x] link.WorkItemLinkCategory
[x] link.WorkItemLinkType
[x] link.WorkItemLink
[x] space.Space
[ ] spacetemplate.SpaceTemplate

Won't use gormsupport.Versioning here because we update the spacetemplates quite often during tests and currently this does not respect any versioning whatsoever. Will have to look into this in another PR.

[x] area.Area
[x] label.Label
[x] query.Query

This adds the gormsupport.Versioning struct as discussed in https://chat.openshift.io/developers/pl/js3udrouwidfjqwjx7zr7n6aga

Looks good to me. Are you working on the item mentioned in the description? Also how about changing other places where version is used?

Codecov Report

Merging #2263 into master will increase coverage by 0.02%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #2263      +/-   ##
==========================================
+ Coverage   69.38%   69.41%   +0.02%
==========================================
  Files         175      176       +1
  Lines       16390    16396       +6
==========================================
+ Hits        11372    11381       +9
+ Misses       3924     3922       -2
+ Partials     1094     1093       -1

Impacted Files
Coverage Δ

workitem/link/category_repository.go
33.33% <ø> (+0.36%)
:arrow_up:

workitem/workitem_repository.go
68.23% <ø> (+0.15%)
:arrow_up:

workitem/link/category.go
100% <100%> (ø)
:arrow_up:

workitem/workitem_storage.go
70.83% <100%> (ø)
:arrow_up:

gormsupport/versioning.go
100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c4f317a...3205b0b. Read the comment docs.

Looks good to me. Are you working on the item mentioned in the description? Also how about changing other places where version is used?

@baijum I have worked on the items mentioned in the description and need to finish test fixups. Not doing that today but on Friday maybe.

What is the story/task reference for this PR?

What is the story/task reference for this PR?

There is none. This is cleanup work and stabilization work. Do we have an issue for this already? I don't want to open an issue for all the cleanups I'm doing.


#86 Add Configurable Auto Pilot Days

#86

Thanks for the PR! This looks pretty good, we can add it into the next release.
This setting would also show up on / and /rebalancing pages as well as it starts with AP but unable to modify from those screens.

This setting would also show up on / and /rebalancing pages as well as it starts with AP but unable to modify from those screens.

Let me submit changes to fix that too.

LGTM


fix source folder location

otherwise project is in red on import

The editorconfig-core-java submodule does not have a "src/main/java" dir.

it has as of now, see https://github.com/editorconfig/editorconfig-core-java

OK, but it was not in referenced
https://github.com/editorconfig/editorconfig-core-java/tree/9ff6e78159540f5c305551237fcf2c7f14701b1d
I think git modules mechanism does not really fixes version for all collaborators. Or can it?

Yes, Git submodules are tied to a commit. If you run git submodule init && git submodule update then you should have 9ff6e78 checked out.

I'm not sure if we can pull the artifact from a Maven repo. Our dependencies come from the Eclipse P2 repo and the jar will need to have an OSGi manifest too.

One can consume maven dependency with maven/tycho
https://wiki.eclipse.org/Tycho/How_Tos/Dependency_on_pom-first_artifacts

@paulvi any objections to closing this PR?

this change maybe already in the repo.
This #12 is not about the change, but what the path should be.
do as you like


New version: Beeper.Beeper version 3.108.3

Created by 🥟 Dumplings in workflow run #6788.

Log
Updated: 3.107.2 → 3.108.3
No ReleaseNotes (en-US) for version 3.108.3
Submitting WinGet manifests
Creating manifests
Uploading manifests and making commits
Creating a pull request

Microsoft Reviewers: Open in CodeFlow

https://github.com/microsoft/winget-pkgs/issues/142854


ValueError : Format 'jpg' is not supported

Hello @Cartucho i confuse for this error, it never occur before

i run main.py after use convert and change name class,
can you help me please ?

It seems to be a problem with jpg and matplotlib.
I changed the format to png, should work now.

i try in my laptop now (it's work), error occur in my pc, sorry i can't try it now, i'll try it tomorrow.
Thank you so much

It's work now, thank you


Typo in README.md

Docker
docker run -d \
...
-e ADMIN_PASSWORD="admin" \
...

Missed out one quotation mark.

Thanks, and Merged :)


Cross compile modules when not on x86_64 Linux

Unfortunately not everyone accepts 🐧 power on their desktop, so this should probably cross compile modules with C extensions.
references:

http://whatschrisdoing.com/blog/2009/10/16/cross-compiling-python-extensions/
https://pypi.python.org/pypi/distutilscross

There's an Amazon Linux Docker image that may be useful for this purpose ... I've been playing around with the attached but haven't gotten to something that's completely baked yet.
rm -rf output
mkdir output
docker build -t build-native .
docker run -v $PWD/output:/output build-native /build.sh native-module1 ...

build-native.zip

Awesome @glb, Docker was one of my first thoughts too :smile:


Picture in Picture (PIP) callbacks don't fire on restoration from a full-screen PIP

Bug
When launching picture in picture in iOS, there are two modes: PIP mode directly from the current viewer, and fullscreen PIP mode where you launch into fullscreen, and then press the PIP button from there.
I've noticed some different functionality between the two:

in fullscreen PIP mode, both videos play: the PIP as well as the original video frame.
in pure PIP mode, only the PIP plays while the original video frame shows a message about PIP
in pure PIP mode, the onPictureInPictureStatusChanged callback fires appropriately
in fullscreen PIP mode, the callback never fires either on PIP start or PIP end.

I noticed someone saw this before the feature went in here: https://github.com/react-native-video/react-native-video/pull/1325#issuecomment-464998645

Platform

Which player are you experiencing the problem on:

iOS

Environment info

React native info output:
System:
    OS: macOS 10.15.7
    CPU: (12) x64 Intel(R) Core(TM) i9-8950HK CPU @ 2.90GHz
    Memory: 719.15 MB / 16.00 GB
    Shell: 5.7.1 - /bin/zsh
  Binaries:
    Node: 12.18.2 - ~/.nvm/versions/node/v12.18.2/bin/node
    Yarn: 1.22.5 - ~/.yarn/bin/yarn
    npm: 6.14.8 - ~/.nvm/versions/node/v12.18.2/bin/npm
    Watchman: 4.9.0 - /usr/local/bin/watchman
  Managers:
    CocoaPods: 1.9.3 - /usr/local/bin/pod
  SDKs:
    iOS SDK:
      Platforms: iOS 14.3, DriverKit 20.2, macOS 11.1, tvOS 14.3, watchOS 7.2
    Android SDK:
      API Levels: 23, 28, 29
      Build Tools: 28.0.3, 29.0.2, 29.0.3
      System Images: android-28 | Intel x86 Atom_64, android-28 | Google APIs Intel x86 Atom
      Android NDK: Not Found
  IDEs:
    Android Studio: 4.0 AI-193.69<IP_ADDRESS>26763
    Xcode: 12.3/12C33 - /usr/bin/xcodebuild
  Languages:
    Java: 1.8.0_232 - /usr/bin/javac
    Python: 2.7.16 - /usr/bin/python
  npmPackages:
    @react-native-community/cli: Not Found
    react: ^16.13.1 => 16.13.1
    react-native: 0.63.2 => 0.63.2
    react-native-macos: Not Found
  npmGlobalPackages:
    *react-native*: Not Found

Library version: 5.1.1
Steps To Reproduce

Play an HLS stream
Enter fullscreen
Enter PIP mode from fullscreen
Restore PIP to app

Expected behaviour

The onPictureInPictureStatusChanged callbacks fire as the PIP starts and ends from the context of the fullscreen viewer

Reproducible sample code
 <Video
          source={{ uri: 'someHlsStream.m3u8' }}
          muted
          fullscreen
          playInBackground
          ignoreSilentSwitch="ignore"
          onPictureInPictureStatusChanged={({ isActive }) => {
            console.log('PIP is', isActive );
          }}
          onRestoreUserInterfaceForPictureInPictureStop={() => {
            console.log('on restore from PIP');
            videoRef.current?.restoreUserInterfaceForPictureInPictureStopCompleted(true);
          }}
          onFullscreenPlayerWillDismiss={() => {
            console.log('player dismissing')
          }}
          onFullscreenPlayerDidDismiss={() => {
            console.log('player dismissed');
          }}
        />

Video sample
Any HLS m3u8 stream.

I am running into the exact same issue. (watching)

Same issue.
Steps to reproduce:

Enter fullscreen
Go to home screen or press PiP icon
It should fire onPictureInPictureStatusChanged event

When you manually change pictureInPicture property event is fired.


Update dependencies and make it compile

Update Dependencies and make compilable once again
core_graphics dependency did not compile, so I ended up updating everything.
Works on nightly and stable.

Thanks!


ci: Update docs-builder image for documentation workflow

Update the docs-builder image used by the CI workflow to pick-up the changes introduced in commit e4889d72f9a8 ("docs: Drop sphinxcontrib-openapi fork, switch back to upstream"), so we can get rid of our openapi fork. Thank you Joe for updating the image!
Branches v1.12 and older use images that were created before the introduction of the openapi fork (commit 4f893e8d3e0f ("docs: Switch to our own fork of sphinxcontrib-openapi")), so they don't need a backport.
We should be able to remove the fork after this PR has been merged and backported to 1.13.

Documentation workflow is passing.


When I train a 30-billion-parameter Llama model using V3-256, what configuration would be appropriate? I've tried '1, 64, 4', '1, 128, 2', and '1, 32, 8', but none of them worked."

When I train a 30-billion-parameter Llama model using V3-256, what configuration would be appropriate? I've tried '1, 64, 4', '1, 128, 2', and '1, 32, 8', but none of them worked.

Are you getting OOM for all of them? I do remember that JAX has a bug for sharding large models on TPU-v3, and we resolved this issue by moving to TPU-v4.

yes i am getting OOM for all of them
Do you have any suggestions? Or do you have any recommended solutions for dealing with v3-256 resources?

A while ago when I was playing with the v3 TPUs, there seems to be a sharding bug where the shape of the tensors in the OOM messages are global instead of local to each device. I'm not sure if the bug has been fixed ready, but if you still see that, you might want to report it to the JAX team. Other than that I don't have much suggestions about TPU v3s.

ok，thank you ~