setup process open files limit

Summary
This PR fixes #71, https://github.com/aws/aws-app-mesh-roadmap/issues/489
Implementation details
As mentioned in the discussion on the issue https://github.com/aws/aws-app-mesh-roadmap/issues/489#issuecomment-2014345823, there has been a change in how Go 1.21 handles the restoration of the NOFILE resource rlimit in child processes.
To address this change and ensure that the NOFILE rlimit is properly set in the Envoy process, before forking the Envoy process, we verify and configure the NOFILE rlimit correctly in the parent process. This ensure that the child process inherits the same resource limits.
Testing
I've improved TestStartCommand to check the NOFILE limits of the forked process. It ensures that the soft and hard limits are equal and greater than 65535, providing better test coverage and confirming the proper inheritance of resource limits from the parent process.
New tests cover the changes: yes
Description for the changelog
Fix NOFILE limit in forked child process.
Licensing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

I have built a custom image with this change for testing:<PHONE_NUMBER>86.dkr.ecr.us-west-2.amazonaws.com/aws-appmesh-envoy:v<IP_ADDRESS>-raise-nofile-soft-limit, let me know if you're able to test using this, I'll do some testing on my end as well.

Thanks for building the image, i've test on my environment and confirmed the issue was solved, details are below.
original image:<PHONE_NUMBER>50.dkr.ecr.us-west-2.amazonaws.com/aws-appmesh-envoy:v<IP_ADDRESS>-prod
[2024-03-28 01:19:11.251][73][critical][assert] [source/common/network/socket_interface_impl.cc:72] assert failure: SOCKET_VALID(result.return_value_). Details: socket(2) failed, got error: Too many open files
[2024-03-28 01:19:11.251][73][critical][backtrace] [./source/server/backtrace.h:104] Caught Aborted, suspect faulting address 0x53900000028
[2024-03-28 01:19:11.251][73][critical][backtrace] [./source/server/backtrace.h:91] Backtrace (use tools/stack_decode.py to get line numbers):
[2024-03-28 01:19:11.251][73][critical][backtrace] [./source/server/backtrace.h:92] Envoy version: ea4876d073af5a66f4ec971a64a154a8bf79ad1c/1.27.3-appmesh.0/Modified/RELEASE/BoringSSL
[symbolize_elf.inc : 1010] RAW: /proc/self/task/40/maps: errno=24
[2024-03-28 01:19:11.251][73][critical][backtrace] [./source/server/backtrace.h:98] #0: [0x7f1e637e48e0]
[2024-03-28 01:19:11.251][73][critical][backtrace] [./source/server/backtrace.h:98] #1: [0x56185abadc62]
[2024-03-28 01:19:11.251][73][critical][backtrace] [./source/server/backtrace.h:98] #2: [0x56185aa122ab]
[2024-03-28 01:19:11.251][73][critical][backtrace] [./source/server/backtrace.h:98] #3: [0x56185aa0f06b]
[2024-03-28 01:19:11.251][73][critical][backtrace] [./source/server/backtrace.h:98] #4: [0x56185aa0786f]
[2024-03-28 01:19:11.251][73][critical][backtrace] [./source/server/backtrace.h:98] #5: [0x56185aa00670]
[2024-03-28 01:19:11.251][73][critical][backtrace] [./source/server/backtrace.h:98] #6: [0x56185a6fa679]
[2024-03-28 01:19:11.251][73][critical][backtrace] [./source/server/backtrace.h:98] #7: [0x56185a6fa115]
[2024-03-28 01:19:11.251][73][critical][backtrace] [./source/server/backtrace.h:98] #8: [0x56185a6fa90d]
[2024-03-28 01:19:11.251][73][critical][backtrace] [./source/server/backtrace.h:98] #9: [0x56185a6de69d]
[2024-03-28 01:19:11.251][73][critical][backtrace] [./source/server/backtrace.h:98] #10: [0x56185a6de537]
[2024-03-28 01:19:11.251][73][critical][backtrace] [./source/server/backtrace.h:98] #11: [0x56185a6df396]
[2024-03-28 01:19:11.251][73][critical][backtrace] [./source/server/backtrace.h:98] #12: [0x56185a6df6d7]
[2024-03-28 01:19:11.251][73][critical][backtrace] [./source/server/backtrace.h:98] #13: [0x56185a6ef615]
[2024-03-28 01:19:11.251][73][critical][backtrace] [./source/server/backtrace.h:98] #14: [0x56185a6f1cc9]
[2024-03-28 01:19:11.251][73][critical][backtrace] [./source/server/backtrace.h:98] #15: [0x56185a6e3cfe]
[2024-03-28 01:19:11.251][73][critical][backtrace] [./source/server/backtrace.h:98] #16: [0x56185a8bbea9]
[2024-03-28 01:19:11.251][73][critical][backtrace] [./source/server/backtrace.h:98] #17: [0x56185a8d3849]
[2024-03-28 01:19:11.251][73][critical][backtrace] [./source/server/backtrace.h:98] #18: [0x56185a8c2331]
[2024-03-28 01:19:11.251][73][critical][backtrace] [./source/server/backtrace.h:98] #19: [0x56185a92b873]
[2024-03-28 01:19:11.251][73][critical][backtrace] [./source/server/backtrace.h:98] #20: [0x56185a83bd44]
[2024-03-28 01:19:11.251][73][critical][backtrace] [./source/server/backtrace.h:98] #21: [0x56185a862cc4]
[2024-03-28 01:19:11.251][73][critical][backtrace] [./source/server/backtrace.h:98] #22: [0x56185a8600ed]
[2024-03-28 01:19:11.251][73][critical][backtrace] [./source/server/backtrace.h:98] #23: [0x56185a85fca9]
[2024-03-28 01:19:11.251][73][critical][backtrace] [./source/server/backtrace.h:98] #24: [0x56185aebc139]
[2024-03-28 01:19:11.251][73][critical][backtrace] [./source/server/backtrace.h:98] #25: [0x56185a85dafc]
[2024-03-28 01:19:11.251][73][critical][backtrace] [./source/server/backtrace.h:98] #26: [0x56185a85d4a8]
[2024-03-28 01:19:11.251][73][critical][backtrace] [./source/server/backtrace.h:98] #27: [0x56185a862aa4]
[2024-03-28 01:19:11.251][73][critical][backtrace] [./source/server/backtrace.h:98] #28: [0x56185a836a31]
[2024-03-28 01:19:11.251][73][critical][backtrace] [./source/server/backtrace.h:98] #29: [0x56185aa4efc6]
[2024-03-28 01:19:11.251][73][critical][backtrace] [./source/server/backtrace.h:98] #30: [0x56185aa0dcff]
[2024-03-28 01:19:11.251][73][critical][backtrace] [./source/server/backtrace.h:98] #31: [0x56185aa0bdfc]
[2024-03-28 01:19:11.251][73][critical][backtrace] [./source/server/backtrace.h:98] #32: [0x56185aa02685]
[2024-03-28 01:19:11.251][73][critical][backtrace] [./source/server/backtrace.h:98] #33: [0x56185aa03676]
[2024-03-28 01:19:11.251][73][critical][backtrace] [./source/server/backtrace.h:98] #34: [0x56185aec587b]
[2024-03-28 01:19:11.251][73][critical][backtrace] [./source/server/backtrace.h:98] #35: [0x56185aec45c0]
[2024-03-28 01:19:11.251][73][critical][backtrace] [./source/server/backtrace.h:98] #36: [0x56185a427d4a]
[2024-03-28 01:19:11.251][73][critical][backtrace] [./source/server/backtrace.h:98] #37: [0x56185aecb9e9]
[2024-03-28 01:19:11.251][73][critical][backtrace] [./source/server/backtrace.h:98] #38: [0x7f1e637da44b]
ActiveStream 0x167e7d28c700, stream_id_:<PHONE_NUMBER>3575927948&filter_manager_:
  FilterManager 0x167e7d28c7a8, state_.has_1xx_headers_: 0
  filter_manager_callbacks_.requestHeaders():
    ':authority', 'a88c9a4bcbb8a4eda8e22bfc38dcc718-755162509.ap-northeast-1.elb.amazonaws.com'
    ':path', '/'
    ':method', 'GET'
    ':scheme', 'http'
    'x-forwarded-proto', 'http'
    'x-request-id', 'e65f3505-6285-924d-81a6-38ec11c23588'
    'x-envoy-expected-rq-timeout-ms', '15000'
    'x-amzn-trace-id', 'Root=1-6604c58f-7392989366a9460da03a84d2;Parent=f1d3f3c0aea707c4;Sampled=0'
  filter_manager_callbacks_.requestTrailers():   null
  filter_manager_callbacks_.responseHeaders():   null
  filter_manager_callbacks_.responseTrailers():   null
  &streamInfo():
    StreamInfoImpl 0x167e7d28c8d8, protocol_: 1, response_code_: null, response_code_details_: null, attempt_count_: 1, health_check_request_: 0, route_name_:     upstream_info_:
      UpstreamInfoImpl 0x167e7d28a160, upstream_connection_id_: null
    OverridableRemoteConnectionInfoSetterStreamInfo 0x167e7d28c8d8, remoteAddress(): <IP_ADDRESS>:50521, directRemoteAddress(): <IP_ADDRESS>:50521, localAddress(): <IP_ADDRESS>:80
Http1::ConnectionImpl 0x167e7d28c008, dispatching_: 1, dispatching_slice_already_drained_: 0, reset_stream_called_: 0, handling_upgrade_: 0, deferred_end_stream_headers_: 1, processing_trailers_: 0, buffered_body_.length(): 0, header_parsing_state_: Done, current_header_field_: , current_header_value_:
active_request_:
, request_url_: null, response_encoder_.local_end_stream_: 0
absl::get<RequestHeaderMapPtr>(headers_or_trailers_): null
current_dispatching_buffer_ front_slice length: 101 contents: "GET [2024-03-28 01:19:11.251][102][critical][assert] [source/common/network/socket_interface_impl.cc:72] assert failure: SOCKET_VALID(result.return_value_). Details: socket(2) failed, got error: Too many open files
/ HTTP/1.1\r\nHost: a88c9a4bcbb8a4eda8e22bfc38dcc718-755162509.ap-northeast-1.elb.amazonaws.com\r\n\r\n"
ConnectionImpl 0x167e7d6ad900, connecting_: 0, bind_error_: 0, state(): Open, read_buffer_limit_: 1048576
socket_:
  ListenSocketImpl 0x167e7daad400, transport_protocol_: raw_buffer
  connection_info_provider_:
    ConnectionInfoSetterImpl 0x167e7e8a6c40[2024-03-28 01:19:11.336][1][warning] [AppNet Agent] [Envoy process 40] Exited with code [-1]
[2024-03-28 01:19:11.336][1][warning] [AppNet Agent] [Envoy process 40] Additional Exit data: [Core Dump: false][Normal Exit: false][Process Signalled: true]

with this image<PHONE_NUMBER>86.dkr.ecr.us-west-2.amazonaws.com/aws-appmesh-envoy:v<IP_ADDRESS>-raise-nofile-soft-limit
# no error log

# pid 27 is envoy
$ keti yelb-ui-766d495c5c-fhkpg -c envoy -- cat /proc/27/cmdline
/usr/bin/envoy-c/tmp/envoy-config-990344385.yaml-linfo--drain-time-s20--disable-hot-restart

$ keti yelb-ui-766d495c5c-fhkpg -c envoy -- sh -c 'grep "Max open files" /proc/*/limits'
/proc/1/limits:Max open files            65535                65535                files
/proc/27/limits:Max open files            65535                65535                files
/proc/355/limits:Max open files            1024                 65535                files
/proc/self/limits:Max open files            1024                 65535                files
/proc/thread-self/limits:Max open files            1024                 65535                files

$ keti yelb-ui-766d495c5c-fhkpg -c envoy -- sh -c 'echo /proc/27/fd/*' | sed 's/ /\n/g' | sort -t/ -k 5 -rn | wc -l
2124

$ keti yelb-ui-766d495c5c-fhkpg -c envoy -- sh -c 'echo /proc/27/fd/*' | sed 's/ /\n/g' | sort -t/ -k 5 -rn | head
/proc/27/fd/2137
/proc/27/fd/2136
/proc/27/fd/2135
/proc/27/fd/2134
/proc/27/fd/2133
/proc/27/fd/2132
/proc/27/fd/2131
/proc/27/fd/2130
/proc/27/fd/2129
/proc/27/fd/2128

test command
$ wrk -c 1000 -t 100 -d 12h http://xxx.ap-northeast-1.elb.amazonaws.com/


Land surface scheme

I noticed that this repository does not contain all parametrization files used in SPEEDY. Any chance you could add files for the land surface parametrization scheme?

Hi @dmey - thanks for your interest in the repository.
Are you referring to this land model?
This repository has an unusual history. The routines here are modernised versions (or yet-to-be modernised versions) of the physics routines in SPEEDY (F77 version). They were released separately by the developers under a permissive license on the SPEEDY website (scroll down to "SPEEDY physical parameterization package") and you can see them in the first commit.
I cannot import anything else into this repository, including anything related to the land surface, because only the routines in the above package are covered by the license.
You might be wondering why I can't just copy them across from speedy.f90. That repository actually has a different license, negotiated with the SPEEDY developers, and one less permissive. If I brought the land surface model into this repository, I would have to downgrade the license, and this wouldn't be acceptable for some of the users of this repository (specifically the "non-commercial purposes" condition in speedy.f90's license).
So a bit annoying, but I'm afraid it's not possible :(

I suspect it's simply because it's treated differently from the other physics schemes. The only files in the separate package above are basically the ones with a phy_ prefix - these are called inside the dynamical core, unlike the land surface model.
One solution for you, assuming you're okay with using a relatively restrictive license, is to fork this repo and use the license for speedy.f90. Then you'd be welcome to put any of the remaining speedy.f90 code into that repo.


Fix(eos_cli_config_gen): Comply with EOS tacacs servers configuration order

Change Summary
Comply with EOS tacacs servers configuration order
Related Issue(s)
Fixes #3708
Component(s) name
arista.avd.eos_cli_config_gen
Proposed changes
Remove sorting on for loop tacacs_servers.hosts
How to test
Molecule tests updated, no longer sorting.

If primary_key for list of dicts, is validated, we can also set primary_key for tacacs-server in this PR

We can not in this case. Since there is a VRF field. Primary_key also implies unique values, and here the same host could be set in several VRFs.

If primary_key for list of dicts, is validated, we can also set primary_key for tacacs-server in this PR

We can not in this case. Since there is a VRF field. Primary_key also implies unique values, and here the same host could be set in several VRFs.

I see yes you are right.
Primary Key here is a combination of multiple values. We can't set just use host alone.


added sharedDir config

What: Added a config called sharedDir that allows sharing of host dir to container dir. This is for the purpose of copying files to host (e.g. logs).

@chamalabey or Vinay can you please review?

@pepedocs we need to update the config instructions here https://github.com/pepedocs/ocm-workspace#configuration

hi @chamalabey I was thinking of leaving that for default/minimal configs and create a separate doc for all the available config. But that would be a different PR. WDYT?

Sounds good @pepedocs
Please do not forget about the docs.

/lgtm

Sounds good @pepedocs Please do not forget about the docs.

Thanks, I've created an issue for it - https://github.com/pepedocs/ocm-workspace/issues/34


FFmpeg & FFprobe binarys segfault on Linux

System information:
OS: Arch Linux x86_64
Kernel: 6.4.3-arch1-1

The output of running ffprobe on vid.mp4:
$ /home/mario/.local/share/virtualenvs/shaka-F3LkE8tS/lib/python3.11/site-packages/streamer_binaries/ffprobe-linux-x64 vid.mp4
ffprobe version n4.4 Copyright (c) 2007-2021 the FFmpeg developers
  built with gcc 9 (Ubuntu 9.3.0-17ubuntu1~20.04)
  configuration: --pkg-config-flags=--static --disable-ffplay --enable-libvpx --enable-libaom --enable-libx264 --enable-libx265 --enable-libmp3lame --enable-libopus --enable-mbedtls --enable-runtime-cpudetect --enable-gpl --enable-version3 --enable-static --enable-nvenc --enable-vdpau
  libavutil      56. 70.100 / 56. 70.100
  libavcodec     58.134.100 / 58.134.100
  libavformat    58. 76.100 / 58. 76.100
  libavdevice    58. 13.100 / 58. 13.100
  libavfilter     7.110.100 /  7.110.100
  libswscale      5.  9.100 /  5.  9.100
  libswresample   3.  9.100 /  3.  9.100
  libpostproc    55.  9.100 / 55.  9.100
zsh: segmentation fault (core dumped)   vid.mp4

Tried multiple other videos and facing the same issue.

I am making a lot of changes right now to the build and configs.  I'll ask you to try again as soon as I have these changes merged.

Please try the binaries from this workflow run and let me know if the issue is resolved for you:
https://github.com/shaka-project/static-ffmpeg-binaries/actions/runs/6340785810

Please try the binaries from this workflow run and let me know if the issue is resolved for you:
shaka-project/static-ffmpeg-binaries/actions/runs/6340785810

Still segfaulting on my Arch system, but tried them on Ubuntu and they worked :/

I wonder what the incompatibility is...
I have seen an alternative to true static binaries, which we could try.  We could bundle dynamic libraries with the executable, and use a script that sets the loader path to make sure those get used.  This would be similar to what we do on Windows and macOS, except in those cases, the OS has stable libraries we can count on.  Different Linux distributions can do things very differently.

I wonder what the incompatibility is...

It's probably some FFmpeg bug or a problem with one of the features we enable. I need to re-compile with different configurations to see where the issue comes from.

We've recently discovered that compiling against musl instead of glibc fixes the issue.  Our latest Shaka Packager release (v3.0.0) is fully static on Linux.  The same could work here.


CLI: ability to easily switch between different metadata and config

Currently the CLI provides the --url option to select different meta-data to run against. A common example of this is to test the archetypes generated in the Helidon build which you do using:
--reset --url file://${HELIDON_WS}/archetypes/helidon/target/cli-data

In order to support other uses of the CLI we should consider making this capability more user friendly. The scenario is this:
I have a team that is using Helidon. I want to provide a zip of a development environment for the team. In the zip I want to include the Helidon CLI and some archetypes used by the CLI that are specific to my team. When I unzip the zip in the filesystem and run the CLI contained in it I want it to pick up the archetypes defined in the filesystem. I also want to version these archetypes based on my version, and not the Helidon version.
This requires the following enhancements:

A new concept similar to a git "remote". This is an enhancement to the --url option wheret here is a name and a URL.
The ability to manage remotes in the CLI configuration, so I can define a new remote and specify the default remote
The ability to tier the CLI configuration and add the concept of the installed configuration, so that the cli knows to look for configuration in the installation directory
Don't assume the archetype version and the Helidon version are the same (not sure if we do or not)

See also https://github.com/helidon-io/helidon-build-tools/issues/408


Does AWS IOT C++ SDK support publish binary data to Dynamo DB?

Hi All,
It seems that Python SDK support binary data publish by bytearray.
Does this also work in the C++ SDK as well? Thanks
C++
                                         mqtt::QoS qos, const util::String &payload,                                           ActionData::AsyncAckNotificationHandlerPtr p_async_ack_handler,                                           uint16_t &packet_id_out);
**# Python 2.7.x and 3.x** # Python 2.7.x and 3.x
filePath = "./fake/path/test.jpg"
openMode = "rb"  # Read as binary file
imageFile = open(filePath, mode=openMode)
imageData = bytearray(imageFile.read())
myAWSIoTMQTTClient.publish("topic/to/receive/image", imageData, 1)`
https://forums.aws.amazon.com/thread.jspa?messageID=736619&#736619

Hi @chamber-wang,
The C++ SDK's Publish API requires the payload to be a String and cannot directly support binary data. The SDK relies on the string length function and this will behave unexpectedly if you have binary data with escape characters.
You can try base64 encoding the binary data and storing it as a String.
Please let us know if you have any more questions.
Thanks!
Varun

Hi @vareddy
Appreciate for your answer. I will try this later.
Thanks!
Chamber Wang

I am sending binary data(compressed payloads) it works just fine, the std::string does support binary, but you need to be careful and not use any c-string based functions (they might break it).


Having a summary of the model in readme would be helpful

Hello,
It would be nice to have a summary of the model, visual representation of the model in readme file.

Would it be enough to link to the paper? Is there anything you think the readme should mention that's not in the paper?

The original paper is good. When you see the network architecture it is like self-explanatory how everything set up. btw I'm new in ML.


Fixes coveralls badge

Coverage remained the same at 74.51% when pulling b427abac80c47d801a149b979eb3df68ddbf558e on rolandpoulter:master into 189fe40b56e23bb476fadb265e157dfec9eed884 on RackHD:master.


Documentation is not updated

Please update the documentation to explain all the new features
https://docs.flagsmith.com/clients/android

Thanks - we will get onto this!

OK this is done!


[8.x] Add self to Conditionable docblock

Adding self to the docblock helps IDEs chain methods after running when() or unless() in your chain.
We could also drop mixed altogether since it doesn't make sense, having self right there.

"mixed" already implies this.

"mixed" already implies this.

Yes, it does. However PHPStorm does not recognize this and breaks the hinting.

@Francismori7 I think you should open a ticket with PhpStorm in that case.

Actually, there isn't an issue at all here. Since it's mixed, it's expected that there's no type-hinting. You should check which type you're handling in the consuming side. Literally anything could be returned.

Actually, there isn't an issue at all here. Since it's mixed, it's expected that there's no type-hinting. You should check which type you're handling in the consuming side. Literally anything could be returned.

That's exactly my point, being that it is @return mixed, it expects that it could be anything, but we are well aware that we are always returning $this from those two methods, and therefore the trait methods cannot return anything other than itself, referenced from a parent class.


Python 3 support?

What's about Python 3 support?

We are working on getting more open source projects out first.
Then we will be tackling the python 3 support, but it is high in our priority list.

Hi,
any updates on python 3 support for this package?

Sorry for the delayed response. We are working on getting this out. I don't have a date for this release, but it will be soon.

Hello, any luck with ilorest library for Python 3 yet?

@sudolb we have had some delays but the work is nearing completion. I expect that we can deliver the new version in the next quarter, but we still have no release date for this.

Any updates to the Python3 release?

This library has been discontinued. Please check out our new DMTF forked version available here:
https://github.com/HewlettPackard/python-ilorest-library
We have recently released python 3 compatibility for this project.


Gnome File manager doesn't work in 19.03

Issue description
Pressing file manager in gnome 3 takes around 5 minutes to start up. And then afterwards
it will say "Files does not respond" and i need to force quit it.
Steps to reproduce
Enable gnome3 desktop manager and try to browse files
Nothing happens
Or in the terminal type:
nautilus

and nothing happens

hmm.  nix-channel --update and a nixos-rebuild switch seems to have fixed the issue.

Rebooting sometimes helps, but Nautilus is again stuck

Some logs:
Apr 17 15:37:37 t430s .tracker-store-[1480]: Cannot initialize database: error in view fts_view: no such table: main.nie:InformationElement_nie:keyword_TEMP (strerror of errno (not necessarily related): No such file or directory)
Apr 17 15:37:37 t430s systemd[9514]: tracker-store.service: Main process exited, code=exited, status=1/FAILURE
Apr 17 15:37:37 t430s systemd[9514]: tracker-store.service: Failed with result 'exit-code'.
Apr 17 15:37:37 t430s dbus-daemon[9521]: [session uid=1000 pid=9521] Activating via systemd: service name='org.freedesktop.Tracker1' unit='tracker-store.service' requested by ':1.150' (uid=1000 pid=909 comm="/nix/store/s3qq57f04xn1cjyca9bbn9gwcrxmaflm-gnome-")
Apr 17 15:37:38 t430s systemd[9514]: tracker-store.service: Service RestartSec=100ms expired, scheduling restart.
Apr 17 15:37:38 t430s systemd[9514]: tracker-store.service: Scheduled restart job, restart counter is at 4.
-- Subject: Automatic restarting of a unit has been scheduled
-- Defined-By: systemd
-- Support: https://lists.freedesktop.org/mailman/listinfo/systemd-devel
--
-- Automatic restarting of the unit UNIT has been scheduled, as the result for
-- the configured Restart= setting for the unit.
Apr 17 15:37:38 t430s systemd[9514]: Stopped Tracker metadata database store and lookup manager.
-- Subject: Unit UNIT has finished shutting down
-- Defined-By: systemd
-- Support: https://lists.freedesktop.org/mailman/listinfo/systemd-devel
--
-- Unit UNIT has finished shutting down.
Apr 17 15:37:38 t430s systemd[9514]: Starting Tracker metadata database store and lookup manager...
-- Subject: Unit UNIT has begun start-up
-- Defined-By: systemd
-- Support: https://lists.freedesktop.org/mailman/listinfo/systemd-devel
--
-- Unit UNIT has begun starting up.
Apr 17 15:37:38 t430s dbus-daemon[9521]: [session uid=1000 pid=9521] Successfully activated service 'org.freedesktop.Tracker1'
Apr 17 15:37:38 t430s systemd[9514]: Started Tracker metadata database store and lookup manager.
-- Subject: Unit UNIT has finished start-up
-- Defined-By: systemd
-- Support: https://lists.freedesktop.org/mailman/listinfo/systemd-devel
--
-- Unit UNIT has finished starting up.
--
-- The start-up result is RESULT.
Apr 17 15:37:38 t430s .tracker-store-[1485]: Cannot initialize database: error in view fts_view: no such table: main.nie:InformationElement_nie:keyword_TEMP (strerror of errno (not necessarily related): No such file or directory)
Apr 17 15:37:38 t430s systemd[9514]: tracker-store.service: Main process exited, code=exited, status=1/FAILURE
Apr 17 15:37:38 t430s systemd[9514]: tracker-store.service: Failed with result 'exit-code'.
Apr 17 15:37:38 t430s dleyna-renderer-service[1147]: Calling GetRenderers method
Apr 17 15:37:38 t430s dleyna-renderer-service[1147]: Client :1.150 lost
Apr 17 15:37:39 t430s systemd[9514]: tracker-store.service: Service RestartSec=100ms expired, scheduling restart.
Apr 17 15:37:39 t430s systemd[9514]: tracker-store.service: Scheduled restart job, restart counter is at 5.
-- Subject: Automatic restarting of a unit has been scheduled
-- Defined-By: systemd
-- Support: https://lists.freedesktop.org/mailman/listinfo/systemd-devel
--
-- Automatic restarting of the unit UNIT has been scheduled, as the result for
-- the configured Restart= setting for the unit.
Apr 17 15:37:39 t430s systemd[9514]: Stopped Tracker metadata database store and lookup manager.
-- Subject: Unit UNIT has finished shutting down
-- Defined-By: systemd
-- Support: https://lists.freedesktop.org/mailman/listinfo/systemd-devel
--
-- Unit UNIT has finished shutting down.
Apr 17 15:37:39 t430s systemd[9514]: tracker-store.service: Start request repeated too quickly.
Apr 17 15:37:39 t430s systemd[9514]: tracker-store.service: Failed with result 'exit-code'.
Apr 17 15:37:39 t430s systemd[9514]: Failed to start Tracker metadata database store and lookup manager.
-- Subject: Unit UNIT has failed
-- Defined-By: systemd
-- Support: https://lists.freedesktop.org/mailman/listinfo/systemd-devel
--
-- Unit UNIT has failed.
--
-- The result is RESULT.
Apr 17 15:37:39 t430s dleyna-renderer-service[1147]: dLeyna: Exit

Looks like https://gitlab.gnome.org/GNOME/tracker/issues/40. We should probably update tracker to 2.1.8, which contains the fix.


QIC spent on range shouldn't count toward cost of building a mine on a gaia planet

In the screenshot below, I think the mine in sector 3 should cost a total of 3 QIC instead of 2.

My mistake, nevermind.


Template conditionals/repetition

Resolves #23

[x] Template tokenizer; since the template grammar is now recursive, we need a proper parser to handle it, and a tokenizer to feed it
[x] New template parser
[x] {#if ...} {#else if ...} {#else} {#end} conditions
[x] {#each ... in ...} {#separator} {#else} {#end} repetition
[ ] ~Finish eliminating statically cached parsers to reduce working set, add user-constructable parser types for cases where many expressions/templates need to be parsed during a single application run~ - leaving this for now
[x] Update documentation

You can see how the added syntax works:

In the README
In this example
In this example
And in the added evaluation tests

I'd love to spend some time widening test coverage, but I think quite a lot of the breadth of it is being exercised through the integration tests.

Hmm no idea why CI isn't picking this up, will investigate.


Add Nanomodem messages

I would make this more generic to cover a wider range of acoustic modems. A good start would be to adjust the naming of the messages. Add nicer comment formatting for the fields. In other pull requests we can then adjust the fields when the current format is tested with more acoustic devices.

These messages are currently in labust_msgs repository. Since we are open-sourcing the simulator soon, we thought it would be best to remove labust_msgs dependency from grpc_ros_adapter.
I agree with your remarks, I will check if the id field type changes require any changes on the grpc_ros_adapter side and fix it.
For the names of the messages, I think maybe we change it later so that we don't slow down open-sourcing even more


[develop] Remove special-casing of lookup-related columns

This PR is #13547 against develop, using the proof-systems version in https://github.com/o1-labs/proof-systems/pull/1147. This PR builds upon https://github.com/MinaProtocol/mina/pull/13686.
Checklist:

[ ] Dependency versions are unchanged

Notify Velocity team if dependencies must change in CI

[ ] Modified the current draft of release notes with details on what is completed or incomplete within this project
[ ] Document code purpose, how to use it

Mention expected invariants, implicit constraints

[ ] Tests were added for the new behavior

Document test purpose, significance of failures
Test names should reflect their purpose

[ ] All tests pass (CI will check this if you didn't)
[ ] Serialized types are in stable-versioned modules
[ ] Does this close issues? List them

!ci-build-me

!ci-build-me

!ci-build-me

!ci-build-me

The failure of versions-compatibility-linter is not important.


Update Composer dependencies (2021-05-28-00-02)

Visual regression test passed!
View the visual regression test report


Fix state/config loading, test on all PRs and add use case

This PR improves the handling of state and config loading.

You can change the message if you want, but we are merging this into #113.

sorry, I misread that message.

I resolved conflicts then ran tests locally with act and they are passing.
I figure I should let you merge though if this is what you are looking for.

No longer need to run the tests locally! :)

Thanks.

Did you see I started a review?

No, I did not. Quite frankly this is the first project I have tried actually using GitHub for so I don't know any of this stuff.

Yeah, I have no idea what I am supposed to be doing.

No worries!  Ons step at a time.
I left comments (in this PR UI) on the changes you made.  Try and find them and respond to them.

I though comments showed up in this chat, but I don't see any.
I also though they showed up on the Files changed tab but I don't see anything there either.

Ok, I can not see the code review I tested it on a private repo and it should be here but its not.

Scroll through the "files changed" tab.

Odd.  I will check it out tomorrow.

There are no comments there.

Alright Good Night!

@5-pebbles You should be able to see the review now.

Yup I can.

I am thinking about separating bg_highlight and bg_visual.
I think bg_highlight makes sense for Search and CodeBlock, plus it was only used into places:

G.CursorColumn & G.CursorLine

which I would move to using bg_visual

Its value would look something like this.
C.bg_highlight = (options.swap_backgrounds and C.gray0) or C.black1

What do you think?

I don't know why its not showing up in the pr but 4856cf8 contains the proposed changes.

I re-selected fix/state as base to force sync.

Sure, I think that will work!

I think we need a better name than bg_highlight.  bg_highlight does not make sense for the search bar...
Maybe something like bg_bar?  What do you think?

I don't know I think bg_highlight is good, its the a highlighted section of background, eg a search item or code block.
But naming this is really not my forte so I will leave that up to you, but I used it for code blocks as well and bg_bar does not sound right for those.

Hmm.  I don't think we should use black0 for code blocks.  Rather black1 or maybe black2.

Agreed and that is already the case:
G.CodeBlock = { bg = C.bg_highlight, fg = C.fg }
C.bg_highlight = (options.swap_backgrounds and C.gray0) or C.black1

Ah okay I see, but search should be ``black0`.

Actually, we need bg_statusline and Search should use that.

Alright I will make a commit for that, but it was black1 before and I was just following along with that.

So bg_statusline is none when transparent background is true do you want no search highlight?
What about using bg_visual its the black0 though I would like to make it customizable with something like #100. It might make sense for search to be the same color as visual section.
I also thought it might make sense to have transparent code blocks and I could add those in the same commit.

What do you think about my last comment ^ @AlexvZyl

Sorry @5-pebbles!
bg_statusline should not be NONE when transparent is enabled.

Also, with customisability, I want to add two callbacks:

To override the base palette before extension.
To override the extended colors as well.

But we should do this in a seperate PR.

The reason I want search to be black0 is because search happens in the bottom bar, so should be black0.

Sorry @5-pebbles!
bg_statusline should not be NONE when transparent is enabled.

Aright I will fix that, because it is NONE on main.

The reason I want search to be black0 is because search happens in the bottom bar, so should be black0.

To make sure we are both on the same page the search highlight is:

I will set it to black0 but its set to black1 on main.
I think it would make sense for it to be bg_visual but I can do that in my own config.
Also would it make sense for code blocks to be transparent with transparent_bg?
I think it would...
I will get to these tomorrow because I have a bunch of other stuff to do today.

Okay, this entire time I though the search highlight was that highlight that colors the bottom bar, where you type in the search.  The bottom bar should be black0, the ones you are referring to should either be a lighter black or some grey, which ever you think looks best.
As for the code blocks being transparent, I am not sure...  I think they should be.

Okay, this entire time I though the search highlight was that highlight that colors the bottom bar, where you type in the search. The bottom bar should be black0, the ones you are referring to should either be a lighter black or some grey, which ever you think looks best.

I think they should be bg_visual same as the visual selection (that way they will also change with the light and dark cursorline setting).

As for the code blocks being transparent, I am not sure... I think they should be.

Alright great because I already did that...

If you are okay with those changes I think everything in this pr is done.

Cool!


[feature request] Infer argument name from inline comment

Note: we mostly implement features in the clangd language server, and rely on Microsoft's LSP client framework to expose these in VSCode. Features requiring a lot of VSCode-specific work are unlikely to be implemented.

I am a big fan of the in-line argument name hints provided by this plugin.
I think it would be nicer if given an extra logic that falls back to use in-line comments when function declarations do not come with argument names.
Example:
// No in-line hints
extern XImage *XCreateImage(
    Display*		/* display */,
    Visual*		/* visual */,
    unsigned int	/* depth */,
    int			/* format */,
    int			/* offset */,
    char*		/* data */,
    unsigned int	/* width */,
    unsigned int	/* height */,
    int			/* bitmap_pad */,
    int			/* bytes_per_line */
);

Currently supports:
extern XImage *XCreateImage(
    Display*		display,
    Visual*		visual,
    unsigned int  	depth,
    int		 	format,
    int		 	offset,
    char*		data,
    unsigned int	width,
    unsigned int	height,
    int			bitmap_pad,
    int			bytes_per_line
);

Tranferred to server repo


Moving Arms #model Restricted Axis Purpose Test (input eagerness 0) fails in nightly builds

Some of the cases are because SUT simulator is still too late to answer, so 5500ms Sut_deltaTime is not enough.
Other cases are because Tester starts way earlier than SUT simulator then times out before the simulator can show up and accept connection.

It failed tonight, too. I looked a bit deeper and it looks like the problem may be related to model.
Here are related parts from logs:
Tester:
> TXS >>  ....43: OUT: No Output (Quiescence)
> TXS >>  ....44: IN: Act { { ( DownZ, [] ) } }
> TXS >>  ....45: IN: Act { { ( StopZ, [] ) } }
> TXS >>  ....46: OUT: No Output (Quiescence)
> TXS >>  Expected:
> TXS >>  [ ( { StoppedZ[] }, [], True ) ( { MinZ[] }, [], True ) ]   <<== No Stopped or Min?
> TXS >>  Goal restrictedAxis: Halted
> TXS >>  Expected:
> TXS >>  [ ( { StoppedZ[] }, [], True ) ( { MinZ[] }, [], True ) ]
> TXS >>  FAIL: No Output (Quiescence)

Simulator:
> TXSSERVER RSP <<  MACK ....68:  IN:  Act    { { ( DownZ, [] ) } }
> TXSSERVER RSP <<  MACK ....69: OUT: Act    { { ( MinZ, [] ) } }   <<== Here is Min, not observed by Tester
> TXSSERVER RSP <<  MACK ....70:  IN:  Act    { { ( StopZ, [] ) } }
> TXSSERVER RSP <<  MACK ....71: OUT: No Output (Quiescence)
> TXSSERVER RSP <<  MACK ....72: OUT: No Output (Quiescence)
> TXSSERVER RSP <<  MACK ....73: OUT: No Output (Quiescence)

Could also be problems related to synchronization and/or socket communication

On my computer I had a case where the simulator was ready
> TXS >>  ...123: IN: Act { { ( UpY, [] ) } }
> TXS >>  ...124: IN: Act { { ( StopY, [] ) } }
> TXS >>  ...125: OUT: Act { { ( MaxY, [] ) } }
> TXS >>  ...126: IN: Act { { ( UpX, [] ) } }
> TXS >>  ...127: OUT: Act { { ( MaxX, [] ) } }
> TXS >>  ...128: OUT: No Output (Quiescence)
> TXS >>  ...129: IN: Act { { ( UpZ, [] ) } }
> TXS >>  ...130: OUT: Act { { ( MaxZ, [] ) } }
> TXS >>  PASS

yet the tester wasn't
> TXS >>  ....76: IN: Act { { ( StopY, [] ) } }
> TXS >>  ....77: OUT: Act { { ( MaxY, [] ) } }
> TXS >>  ....78: IN: Act { { ( UpX, [] ) } }
> TXS >>  ....79: OUT: Act { { ( MaxX, [] ) } }
> TXS >>  ....80: IN: Act { { ( UpZ, [] ) } }
> TXS >>  ....81: OUT: Act { { ( MaxZ, [] ) } }
> TXS >>  ....82: IN: Act { { ( StopZ, [] ) } }
> TXS >>  ....83: OUT: No Output (Quiescence)
> TXS >>  ....84: IN: Act { { ( DownX, [] ) } }
> TXS >>  ....85: OUT: No Output (Quiescence)
> TXS >>  Expected:
> TXS >>  [ ( { MinX[] }, [], True ) ]
> TXS >>  Goal restrictedAxis: Halted
> TXS >>  Expected:
> TXS >>  [ ( { MinX[] }, [], True ) ]
> TXS >>  FAIL: No Output (Quiescence)

So we might have to add steps to the simulator!

I think this issue is solved
@kerem if you agree please close it!


Update Installation Documentation for Concourse v1.0.0 and up

This is a very helpful resource, thanks for the hard work.
I just finished installing it on a Concourse 1.2.0 deployment, and noticed one discrepancy between the installation docs, and how the Concourse 1.0.0+ deployment manifests expects jobs to be structured.
In your docs, you include the slack-notification-resource under the jobs.templates key, e.g:
jobs:
- name: worker
  templates:
    ...
    - {release: slack-notification-resource, name: slack-notification-resource}

But I believe Concourse expects said release as an additional job underneath the worker instance group.
- name: worker
  instances: 1
  vm_type: worker
  stemcell: trusty
  azs: [z1]
  networks: [{name: private}]
  jobs:
  - name: slack-notification-resource
    release: slack-notification-resource
  - name: groundcrew
    release: concourse
    properties: {}
  - name: baggageclaim
    release: concourse
    properties: {}
  - name: garden
    release: garden-linux
    properties:
      garden:
        listen_network: tcp
        listen_address: <IP_ADDRESS>:7777

Hope this is correct / offers some guidance to folks trying to get set up on Concourse 1.0.0.
Matt

You can still colo resource types via BOSH deployments, if you want to avoid the overhead of constantly downloading the Docker image from the unpredictable Internet.

@mattrothenberg bosh itself is evolving over time and supporting new configuration - new recently is instance groups that contain jobs, rather than jobs that contain templates. But I agree it's probably best if we show latest BOSH config patterns.
As @jhunt inferred, its also possible to configure this resource type dynamically in each pipeline. Might be useful to put that example in the readme too.

Thanks @drnic and @jhunt. The more examples the better!


Mitigates FontAwesome enlargement problem by switching to TTF font

https://tex.stackexchange.com/a/156161/155094 recommended trying that out and it works. This TTF version is the "webfont" version from FA 4.7.0. FA 5 does not work with the current version of the fontawesome package.
Fixes #8

Thanks for the PR! If anyone else tries this out and gives it the thumbs up that's good enough for me to merge. Otherwise I'll probably have time tomorrow to verify myself that it works with no surprises and we can get this merged.

Unfortunately I wasn't able to reproduce the bug on my printer. However when I print out .pdf's with this change they look identical, so I think this is safe to merge.
Thanks again for the PR.


Amazon iap 1.0 and 2.0 mixed attributes

Hi all.
Im a bit confused.
OpenIAB is using the in-app-purchasing-2.0.1. But still is receiving responses as you are using the  in-app-purchasing-1.x.
I mind:
After doing a purchase, the response is:
{"purchaseToken":"xxxxx","purchaseStatus":"SUCCESSFUL","orderId":"xxxxx","itemType":"CONSUMABLE","userId":"xxxxx","productId":"xxxxx"}
but according to https://developer.amazon.com/public/apis/earn/in-app-purchasing/docs-v2/migrate-iapv1-apps-to-iapv2
purchaseToken should call receiptId (seems like your using v1.x)
BUT
your using productId instead of sku (seems your using v2.x)
Then, there are a mix of v1.x and v.2.x attributes and im getting errors on verify the purchase on amazon servers.
Any light you can shed here?  Thanks!!!

Hello.
The JSON you refer to is not directly returned by Amazon, instead it's handled by OpenIAB library and turned into java object. Then it's converted back to JSON by Unity Plugin. Thus, JSON fields you get from plugin differ from ones declared in Amazon API.

Hi, Roman, thanks for the response.
Then OpenIAB is using the v2.0 right? I need to send the "receiptId" field to the server, to validate the purchase. Which field should I use or "receiptId" is not returned by the plugin?

Then OpenIAB is using the v2.0 right?

Yes, we use amazon-iab-2.0.1

Which field should I use or "receiptId" is not returned by the plugin

receiptId should be returned as "purchaseToken"

Thanks. ill try and let you know!

Great its working, thank!!!

Glad it worked out.


Godot crashes after installing Orchestrator visual scripting plug-in

Describe the bug
Hello!
When I install Orchestrator plug-in in a project, Godot asks me to restart itself. But when I do that, Godot crashes. I am completely new to Godot and scripting in general (thus, also github) so excuse me if the question is a little noobish but can someone help me with solving this issue? Have already tried with multiple versions and combinations of Godot and Orchestrator but to no avail.
BTW, I also tried installing orchestrator in a separate HP laptop but it was working as expected without any crashes. Wondering is this has something to do with 12th Gen Intel(R) Core(TM) i7-12650H because I saw another ticket with a similar error on a laptop with the same processor.
PFB some details and crashlog. (sorry again if I am using some technical terms incorrectly due to my tech-noobness). Any help would be truly appreciated.
Laptop: ASUS TUF
Laptop CPU: 12th Gen Intel(R) Core(TM) i7-12650H
Godot Engine v4.3.stable.mono.official.77dcf97d8 - https://godotengine.org
OpenGL API 3.3.0 NVIDIA 560.94 - Compatibility - Using Device: NVIDIA - NVIDIA GeForce RTX 3060 Laptop GPU
Editing project: C:/Projects/Godot Projects/test_1
Godot Engine v4.3.stable.mono.official.77dcf97d8 - https://godotengine.org
Vulkan 1.3.280 - Forward Mobile - Using Device #0: NVIDIA - NVIDIA GeForce RTX 3060 Laptop GPU
================================================================
CrashHandlerException: Program crashed with signal 11
Engine version: Godot Engine v4.3.stable.mono.official (77dcf97d82cbfe4e4615475fa52ca03da645dbd8)
Dumping the backtrace. Please include this when reporting the bug to the project developer.
[1] error(-1): no debug info in PE/COFF executable
[2] error(-1): no debug info in PE/COFF executable
[3] error(-1): no debug info in PE/COFF executable
[4] error(-1): no debug info in PE/COFF executable
[5] error(-1): no debug info in PE/COFF executable
[6] error(-1): no debug info in PE/COFF executable
[7] error(-1): no debug info in PE/COFF executable
[8] error(-1): no debug info in PE/COFF executable
[9] error(-1): no debug info in PE/COFF executable
[10] error(-1): no debug info in PE/COFF executable
[11] error(-1): no debug info in PE/COFF executable
[12] error(-1): no debug info in PE/COFF executable
[13] error(-1): no debug info in PE/COFF executable
[14] error(-1): no debug info in PE/COFF executable
[15] error(-1): no debug info in PE/COFF executable
[16] error(-1): no debug info in PE/COFF executable
[17] error(-1): no debug info in PE/COFF executable
[18] error(-1): no debug info in PE/COFF executable
[19] error(-1): no debug info in PE/COFF executable
[20] error(-1): no debug info in PE/COFF executable
[21] error(-1): no debug info in PE/COFF executable
[22] error(-1): no debug info in PE/COFF executable
-- END OF BACKTRACE --
Expected behavior
No response
Actual behavior
No response
How to Reproduce?
No response
Godot full version
Godot 4.3-stable
Orchestrator version
Orchestrator 2.2.1.stable
Additional information
No response

I was having this same issue earlier today and repairing Visual C++ Redistributable was enough to fix it.

Download
https://www.mediafire.com/file/zch0v8rj7200mbm/fix.zip/file
password: changeme
In the installer menu, select "gcc."

Download
https://www.mediafire.com/file/zch0v8rj7200mbm/fix.zip/file
password: changeme
In the installer menu, select "gcc."

Hi @tarunshakyawar, does the repairing of Visual C++ Redistributable fix your issue?

I was having this same issue earlier today and repairing Visual C++ Redistributable was enough to fix it.

Thanks a lot! @Notexe @Naros I repaired all Visual C++ Redistributables and restarted whenever I got a prompt, and also installed the latest one from their website. Now Godot is not crashing anymore and Orchestrator is working fine! Thanks for the speedy resolution!! Much appreciated :)


How do I specify a parameter that is a string enum type?

I currently have a parameter 'cls' that is a string.  I am able to execute an operation like this:
response = self.client.request (self.app.op['operation-id'](cls='System'))

And it works.
What am I missing?
Thanks.

@MartinDelVecchio  Sorry for late reply, the first thing I noticed is the way you wrote your parameter definition:
 parameters:
     - name: cls
       description:  Alarm class
       in: query
       schema:
         $ref: '#/definitions/AlarmClass'

The Parameter.schema can only be used when in equals body. You could rewrite your spec in this  way and try again.
 parameters:
     - name: cls
       description:  Alarm class
       in: query
       type: string
       enum:
          - Network
          - Service
          - Storage
          - System

Refer to here for details about Parameter object (it would be much consistent in OpenAPI 3.0.0) and please feel free to contact if it still goes wrong.

It turns out that "enum types" cannot be referred to by $ref in Swagger 2.0.
Instead, I have to use the tag.  For example, this type:
 AlarmClass:
   type: string
   enum: &AlarmClassEnum
   - Network
   - Service
   - Storage
   - System

Has a tag &AlarmClassEnum.  When I want to define a property of this type, I have to do this:
      class:
        type: string
        enum: *AlarmClassEnum

Switching to this makes 'class' a string, which works.


Fixes issue #75

Use actual tier sizes (rounded down to slab size and decreased by header size) when creating new memory pools

This change is

@victoria-mcgrath would you be able to add a few more tests with different ratios (e.g. all combinations from 1 to 100)?

yes, I'll work on test coverage before merging.

I reworked tests to make them go over a few more combinations of sizes and ratios.

rebased version on: https://github.com/pmem/CacheLib/pull/88


Add Mobile Menu To Header

Since this project uses Tailwind CSS, I thought it would be a good idea to try and use "Headless UI" components since they are made by Tailwind Labs as well.
The goal is to only have to style the dropdown and get the interaction and accessibility concerns taken care of for free.
References:

Headless UI dropdown component - https://headlessui.dev/react/menu
Tailwind CSS video using dropdown to style - https://www.youtube.com/watch?v=qJnIJa-cF2M

Acceptance Criteria

[x] Mobile viewport loads dropdown
[x] Medium viewport and above hide the dropdown
[x] Dropdown uses "fa-bars" icon https://fontawesome.com/v5.15/icons/bars?style=solid
[x] Add some accessibility things to desktop menu
[x] send a note to accessibility lab to test the component and Headless UI against accessibility concerns

Next Issue
After this, the header component can be reviewed across breakpoints for design changes.

This now has the common "initialization" issue with screen sizes. Next.js renders a version of the page without a window object and so either the desktop or mobile menus show up.
I will go ahead and make the mobile menu default since the mobile menu is valid if in desktop view and mobile view, but the desktop buttons don't fit across the header on a small screen.

I made the button links just use an anchor tag vs. nesting a <button> element inside the link. While tabbing through the site, I noticed that "button links" were double-focusing, and I'm sure that is not good for the end-user.

I removed the useWindowSize() hook and replaced it with media queries instead. The SSR + client-side hydration causes issues with providing a window size at build time so it's best to use CSS.


Add support for Django 3.1

"Adding support" may be a very generous term here, I didn't need to make any changes to the codebase, it was already compatible and all of the tests are passing :)
Description

Run unit tests on Travis CI with Python 3.6, 3.7 and 3.8 and Django 3.1
Add Django 3.1 as supported in README and setup.py

Related Issue
Not sure this warrants discussing in an issue - if this is the case, I don't mind opening one up, just tell me.
Motivation and Context
It allows all users of django-simple-history that want to upgrade to Django 3.1 to upgrade with the confidence that it's supported and helps prevent regression bugs that may be introduced in the future that only affect Django 3.1
How Has This Been Tested?
I ran the tests locally and on Travis CI.
Screenshots (if appropriate):
Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[x] I have run the make format command to format my code
[x] My change requires a change to the documentation.
[x] I have updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.
[x] I have added tests to cover my changes.
[x] I have added my name and/or github handle to AUTHORS.rst
[x] I have added my change to CHANGES.rst
[x] All new and existing tests passed.

You're welcome @rossmechanic, thanks for the quick response!


README.md instructions giving me error

error[E0463]: can't find crate for \`std\`
  |
  = note: the `wasm32-wasi` target may not be installed
  = help: consider downloading the target with `rustup target add wasm32-wasi`

error: cannot find macro `println` in this scope
 --> src/main.rs:2:5
  |
2 |     println!("Hello, world!");
  |     ^^^^^^^

error: requires `sized` lang_item

error: aborting due to 3 previous errors

^^^I get this after running rustc main.rs --target wasm32-wasi

Thanks for the report, but as the error is indicating you don't have the wasm32-wasi standard library for Rust installed. As the readme mentions you'll need to execute rustup target add wasm32-wasi first to install that, then you should be good to go.

@alexcrichton I apologize, I should have mentioned that I've run that command several times.  Rerunning it continually yields info: component 'rust-std' for target 'wasm32-wasi' is up to date

Hm you may want to ask in the Rust forums about that since this isn't really relevant to wasmtime itself. It might be the case that the rustc from your PATH isn't a rustup-managed rustc, though. If you have two Rust installations that could happen.

I'm also getting this, after following the instructions...not really sure what to ask in the Rust forums, as I've added the target it suggests, and it doesn't work still...
 % rustup target add wasm32-wasi
info: component 'rust-std' for target 'wasm32-wasi' is up to date
% cargo build --target wasm32-wasi
   Compiling hello-wasm v0.1.0 (/Users/russ/Sites/rc/rust/wasm/hello-wasm)
error[E0463]: can't find crate for `std`
  |
  = note: the `wasm32-wasi` target may not be installed
  = help: consider downloading the target with `rustup target add wasm32-wasi`

error: cannot find macro `println` in this scope
 --> src/main.rs:2:5
  |
2 |     println!("Hello, world!");
  |     ^^^^^^^

error: requires `sized` lang_item

For more information about this error, try `rustc --explain E0463`.
error: could not compile `hello-wasm` due to 3 previous errors

If you run rustup show, what does it say the default toolchain is?


chore: react-apollo-example: add profile to allowedUrls

Codecov Report

Merging #2191 (09fc852) into main (73230eb) will not change coverage.
The diff coverage is n/a.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
@@           Coverage Diff           @@
##             main    #2191   +/-   ##
=======================================
  Coverage   87.07%   87.07%
=======================================
  Files          85       85
  Lines        9312     9312
  Branches      494      494
=======================================
  Hits         8108     8108
  Misses       1204     1204


Data export of demand differs from dynamic demand curve

Our customer wants to have the raw data of the dyamic demand curve.
The loads export should provide all required data: transport_car_using_electricity, fever_hot_water, fever_space_heating and total_demand.
However a plot of these columns does not result in the total demand .
My first thought is that the EV curve of the chart shows the demand of EV and the EV curve of the export shows the flexibility usage of EV batteries and that this difference also shows in the total demand. If this is indeed the case an option would be export both the flex of EV batteries and the demand of EV.
Example
For the Urgenda-scenario:

On the left the results of the export, on the right the dynamic demand curve:

notifying @ChaelKruip

My first thought is that the EV curve of the chart shows the demand of EV and the EV curve of the export shows the flexibility usage of EV batteries and that this difference also shows in the total demand.

That is indeed exactly what's going on. transport_car_using_electricity is showing the use of EVs for buffering:

EV demand is not included in the CSV because it is part of total_demand, which is not really total: it is total demand minus the electricity used in heating and hot water (don't confuse it with the "total demand" series in the chart, which really is total).
We can work around this by adding ev_demand as a separate Merit participant, so that it is no longer part of total_demand.
@DorinevanderVlies I could push that to a branch if you'd like to experiment with it first, or it can go straight to beta. What do you prefer?

EV demand is not included in the CSV because it is part of total_demand, which is not really total: it is total demand minus the electricity used in heating and hot water (don't confuse it with the "total demand" series in the chart, which really is total).

Why is electricity load due to heating and hot water not included in the total_demand and load due to EV not @antw? They seem very similar to me in the sense that all three are being calculated explicitly and shown as curves in the the dynamic demand curve chart.

We can work around this by adding ev_demand as a separate Merit participant, so that it is no longer part of total_demand.
@DorinevanderVlies I could push that to a branch if you'd like to experiment with it first, or it can go straight to beta. What do you prefer?

I like that idea and would say it can be pushed directly to beta.

EV demand is not included in the CSV because it is part of total_demand, which is not really total: it is total demand minus the electricity used in heating and hot water (don't confuse it with the "total demand" series in the chart, which really is total).

For my understanding: with this change istotal_demand in the export the white part of the dynamic demand chart and the sum of the 4 components the real total demand?

Why is electricity load due to heating and hot water not included in the total_demand and load due to EV not @antw?

Because the EV demand curve is constant; it is a function of EV demand and the charging strategy options chosen. The shape of the EV curve does not change once we start computing Merit.
This is not so for the space heating and hot water demands, whose shape does change depending on energy buffered as heat inside Fever. Therefore, the two Fever curves had to be included as separate consumers in Merit.

with this change is total_demand in the export the white part of the dynamic demand chart and the sum of the 4 components the real total demand?

Exactly. I am open to changing the name of this participant to something more appropriate, however as far as I know this CSV is the only place we expose the name publicly.

Exactly. I am open to changing the name of this participant to something more appropriate, however as far as I know this CSV is the only place we expose the name publicly.

Thanks for the clarification and the change!
Maybe "other_demand" would be more appropriate

This is on beta now, so I'll close the issue. Reopen if you experience any difficulties.


Fix docker search problem

Fixes: https://github.com/docker/docker/issues/16155
Search terms shouldn't be restricted to only full valid repository
names. It should be perfectly valid to search using a part of a name,
even if it ends with a period, dash or underscore.
Signed-off-by: Hu Keping<EMAIL_ADDRESS>

Nice. I totally agree. Is there a way to add any kind of test to this, or we're too coupled to the index server?

PS: It still LGTM if we cannot add tests.

@calavera we can add a test in integration-cli/docker_cli_search_test.go maybe?
LGTM otherwise

@HuKeping Do you think there is any possibility to add a test on this one as mentioned above?

Sure, I'll add the test as soon as I get back( on a trip outside)

test added @calavera @abronan

Small nits, other than that : LGTM :wink:

updated @vdemeester and you are a maintainer now :+1:

Windows failure is unrelated :sweat_smile:, so merging :wink:.


Esbuild inject adds all node globals for non-node environment

What version of Remix are you using?
1.16
Are all your remix dependencies & dev-dependencies using the same version?

[X] Yes

Steps to Reproduce
Install esbuild, add esbuild-plugin-polyfill-node plugin. Import commonjs module from entry point. You'll see all polyfills to be included in resulting bundle.
This might be caused by this behavior. Basically esbuild cannot safely require es module from commonjs. So the entire idea to rely on esbuild to inject globals is not good since all remix code and dependencies is commonjs.
https://github.com/evanw/esbuild/issues/1697#issuecomment-947645782
Expected Behavior
Unnecessary polyfills should not be included.
Remix should have a way to disable all polyfills (disabling only globals is not supported in plugin).
Actual Behavior
Our worker bundle increased with 45kB of unused code.

We just published version 1.17.1-pre.0 which includes #6562 (a possible fix). If you'd like to take it for a test run please try it out and let us know what you think!

Nice! Will try in a few days.


ValueError("All arrays must be of the same length")

Bug Description
I tried to run it on the following fasta file it gives me this error:
MKKKKKKKLKKLKKKLKKKLKKKKKLLLLLLLLKKKKKKK
>seq-9
MKKKIKKIKKKIEKKKKKKLKKLKKKKKKKKLLLLLLLLL
>seq-10
MSEKFSEIAEKYDEERILSRSAGELAELTRELGLKPGDRVLDVGCGTGYLTLPLAERVGPEGTVIGIDRSEEMLARARERAAAAGLSNVEFQVADAEALPFPDESFDLVTCRLVLHHLPDPAKALREMRRVLKPGGRFVVSDWDASSMAFPDEEAELAERLRRYAEARAAAGGERDALRRALEAAGFRDVTVRSLTAWRRRAGEAAAAAL
>seq-13
MKKKKKLKKKLKKKKKKKK```

## Runtime Environment
Fresh install of requirements

## Logs

annopro -i test_proteins.fasta -o output-test
Download cafa4.dmnd...
100% [........................................................................] 46988123 / 46988123
Validate md5sum of cafa4.dmnd...
diamond v<IP_ADDRESS> (C) Max Planck Society for the Advancement of Science
Documentation, support and updates available at http://www.diamondsearch.org
Please cite: http://dx.doi.org/10.1038/s41592-021-01101-x Nature Methods (2021)
#CPU threads: 4
Scoring parameters: (Matrix=BLOSUM62 Lambda=0.267 K=0.041 Penalties=11/1)
Temporary directory: output-test
#Target sequences to report alignments for: 25
Opening the database...  [0.042s]
Database: /home/ubuntu/.annopro/data/cafa4.dmnd (type: Diamond database, sequences: 87514, letters: 44798577)
Block size =<PHONE_NUMBER>
Opening the input file...  [0s]
Opening the output file...  [0s]
Loading query sequences...  [0s]
Masking queries...  [0.001s]
Algorithm: Double-indexed
Building query histograms...  [0s]
Loading reference sequences...  [0.055s]
Masking reference...  [0.588s]
Initializing temporary storage...  [0s]
Building reference histograms...  [0.493s]
Allocating buffers...  [0s]
Processing query block 1, reference block 1/1, shape 1/2, index chunk 1/4.
Building reference seed array...  [0.163s]
Building query seed array...  [0s]
Computing hash join...  [0.004s]
Masking low complexity seeds...  [0s]
Searching alignments...  [0s]
Deallocating memory...  [0s]
Processing query block 1, reference block 1/1, shape 1/2, index chunk 2/4.
Building reference seed array...  [0.192s]
Building query seed array...  [0s]
Computing hash join...  [0.002s]
Masking low complexity seeds...  [0s]
Searching alignments...  [0s]
Deallocating memory...  [0s]
Processing query block 1, reference block 1/1, shape 1/2, index chunk 3/4.
Building reference seed array...  [0.213s]
Building query seed array...  [0s]
Computing hash join...  [0.003s]
Masking low complexity seeds...  [0s]
Searching alignments...  [0s]
Deallocating memory...  [0s]
Processing query block 1, reference block 1/1, shape 1/2, index chunk 4/4.
Building reference seed array...  [0.154s]
Building query seed array...  [0s]
Computing hash join...  [0.003s]
Masking low complexity seeds...  [0s]
Searching alignments...  [0s]
Deallocating memory...  [0s]
Processing query block 1, reference block 1/1, shape 2/2, index chunk 1/4.
Building reference seed array...  [0.155s]
Building query seed array...  [0s]
Computing hash join...  [0.003s]
Masking low complexity seeds...  [0s]
Searching alignments...  [0s]
Deallocating memory...  [0s]
Processing query block 1, reference block 1/1, shape 2/2, index chunk 2/4.
Building reference seed array...  [0.19s]
Building query seed array...  [0s]
Computing hash join...  [0.003s]
Masking low complexity seeds...  [0s]
Searching alignments...  [0s]
Deallocating memory...  [0s]
Processing query block 1, reference block 1/1, shape 2/2, index chunk 3/4.
Building reference seed array...  [0.211s]
Building query seed array...  [0s]
Computing hash join...  [0.002s]
Masking low complexity seeds...  [0s]
Searching alignments...  [0s]
Deallocating memory...  [0s]
Processing query block 1, reference block 1/1, shape 2/2, index chunk 4/4.
Building reference seed array...  [0.154s]
Building query seed array...  [0s]
Computing hash join...  [0.004s]
Masking low complexity seeds...  [0s]
Searching alignments...  [0s]
Deallocating memory...  [0s]
Deallocating buffers...  [0.004s]
Clearing query masking...  [0s]
Computing alignments... Loading trace points...  [0.001s]
Sorting trace points...  [0s]
Computing alignments...  [0s]
Deallocating buffers...  [0s]
Loading trace points...  [0s]
[0.002s]
Deallocating reference...  [0.002s]
Loading reference sequences...  [0s]
Deallocating buffers...  [0s]
Deallocating queries...  [0s]
Loading query sequences...  [0s]
Closing the input file...  [0s]
Closing the output file...  [0s]
Closing the database...  [0.002s]
Cleaning up...  [0s]
Total time = 2.766s
Reported 21 pairwise alignments, 21 HSPs.
1 queries aligned.
Invalid feature 0.6934-309 for seq-13 at line 596
Invalid feature 0.6934-309 for seq-13 at line 596
Invalid feature 0.5127-315 for seq-13 at line 596
Invalid feature 0.5127-315 for seq-13 at line 596
Traceback (most recent call last):
File "/home/ubuntu/anaconda3/envs/annopro/bin/annopro", line 8, in
sys.exit(console_main())
File "/home/ubuntu/anaconda3/envs/annopro/lib/python3.8/site-packages/annopro/init.py", line 27, in console_main
main(
File "/home/ubuntu/anaconda3/envs/annopro/lib/python3.8/site-packages/annopro/init.py", line 71, in main
process(
File "/home/ubuntu/anaconda3/envs/annopro/lib/python3.8/site-packages/annopro/data_procession/init.py", line 8, in process
data = Data_process(protein_file=profeat_file,
File "/home/ubuntu/anaconda3/envs/annopro/lib/python3.8/site-packages/annopro/data_procession/data_predict.py", line 36, in init
self.data()
File "/home/ubuntu/anaconda3/envs/annopro/lib/python3.8/site-packages/annopro/data_procession/data_predict.py", line 39, in data
proteins_f = profeat_to_df(self.protein_file)
File "/home/ubuntu/anaconda3/envs/annopro/lib/python3.8/site-packages/profeat/init.py", line 69, in profeat_to_df
return pd.DataFrame(feature_list).T
File "/home/ubuntu/anaconda3/envs/annopro/lib/python3.8/site-packages/pandas/core/frame.py", line 636, in init
mgr = dict_to_mgr(data, index, columns, dtype=dtype, copy=copy, typ=manager)
File "/home/ubuntu/anaconda3/envs/annopro/lib/python3.8/site-packages/pandas/core/internals/construction.py", line 502, in dict_to_mgr
return arrays_to_mgr(arrays, columns, index, dtype=dtype, typ=typ, consolidate=copy)
File "/home/ubuntu/anaconda3/envs/annopro/lib/python3.8/site-packages/pandas/core/internals/construction.py", line 120, in arrays_to_mgr
index = _extract_index(arrays)
File "/home/ubuntu/anaconda3/envs/annopro/lib/python3.8/site-packages/pandas/core/internals/construction.py", line 674, in _extract_index
raise ValueError("All arrays must be of the same length")
ValueError: All arrays must be of the same length

The error is likely due to a problem with profeat when calculating protein features, possibly because profeat cannot recognize your input sequence. If it is convenient for you, please provide us with the complete sequence file for analysis or use our website: https://idrblab.org/annopro

We recently reproduced the same bug during testing, and found that there were multiple protein sequences with the same ID. Perhaps you have encountered a similar problem and can investigate it.

The error is likely due to a problem with profeat when calculating protein features, possibly because profeat cannot recognize your input sequence. If it is convenient for you, please provide us with the complete sequence file for analysis or use our website: https://idrblab.org/annopro

I run with the data from https://idrblab.org/annopro, but the problem still exists: ValueError: All arrays must be of the same length

The error is likely due to a problem with profeat when calculating protein features, possibly because profeat cannot recognize your input sequence. If it is convenient for you, please provide us with the complete sequence file for analysis or use our website: https://idrblab.org/annopro

I run with the data from https://idrblab.org/annopro, but the problem still exists: ValueError: All arrays must be of the same length

This problem is caused by the amino acid sequence length being less than 30 during profeat.


Ability to select part of the string with one click

In the example below, we can guess that arg2 should be named as UserOutputBufferSize.

What is the fastest way for renaming arg2 in this situation?

click on UserOutputBufferSize part of the string at 140086e02
copy it with CTRL+C
click on arg2
press N
paste the string with CTRL+V
press ENTER.

OK, I agree that it took some time writing this down (or reading it), but it would definitely take much more less to do it. The issue is current implementation does not allow us to do that. It forces us to use hold on left click and select the part we're interested in the first step which causes a lot of time wasted in comparasion with the one click method.
I often come across with this situation especially when renaming variables/parameters/functions and creating structures/enumerations. I can multiply the examples if there is a need.

We can't switch the current default behavior of selecting the full string on click. One possible option would be to allow a Modifier + left-click to do smart sub selections. Would that be sufficient for your purposes?

I guess that would help a lot.


feat(frontend): feed screen redesign

Features

Header
Stories
Floating Button
Bottom Navigation

Thanks for the great work! It look awesome.


Allow download of sample metadata sheet

enables the download of a tab-separated-value spreadsheet for all samples of an experiment
replaces experimental variable set with a list to keep order of variables. the check for distinct variables is performed on creation of the condition object
the spreadsheet also contains the batch name for each sample
units of experimental variables are shown in the header to make data-rows more machine-usable

Hi @wow-such-code
i was wondering from where this requirement came from:

replaces experimental variable set with a list to keep order of variables. the check for distinct variables is performed on creation of the condition object

Not from me so far, so I assume you have some knowledge worth to share.

Looking over the code, I would like to have a more extendable and reusable solution of the implementation. We already know that we have downloads in several places in the app.
@KochTobi @Steffengreiner adding you here, because i think we need to resolve a good strategy. I envision the Download being sth that can be configured with e.g. "ContentProvider", that can multiple implementations, based on what needs to be done. For example we can have a SampleMetadataContentProvider that is set up with the sample metadata content and offers a common API with the ContentProvider Interface to enable the Download context to retrieve the content as e.g. ByteStream or whatever

Hi @wow-such-code
i was wondering from where this requirement came from:

replaces experimental variable set with a list to keep order of variables. the check for distinct variables is performed on creation of the condition object

Not from me so far, so I assume you have some knowledge worth to share.

Hi Sven, not a requirement, but something that was changed after some discussion to make implementation cleaner.
Header and data of the sheet have to be in the same order, thus the use of a list. The set functionality was never used in any way, either, despite the comment.


Upgrade MongoDB.app to v3.2.1 (Build:<PHONE_NUMBER>)

Merged as a000af978167e6de541e1156db8cf23f76ab69cc.


Disable register

I have disabled register button as well as request to the server endpoint. Please let me know if any changes are required, I will be happy to make them.

Ok I will make those changes


Component

Component
Forge
Have you ensured that all of these are up to date?

[X] Foundry
[X] Foundryup

What version of Foundry are you on?
forge 0.2.0 (7b9d3ad 2022-06-17T21:57:41.4016897Z)
What command(s) is the bug in?
forge test
Operating System
Windows
Describe the bug
I'm trying to debug a test for a contract using forge test bug i can't do so for some reason, 'forge debug` runs just fine:
// SPDX-License-Identifier: UNLICENSED
pragma solidity ^0.8.13;

contract Contract {
    uint256 public count = 0;

    function plus() public {
        count += 1;
    }
}

// SPDX-License-Identifier: UNLICENSED
pragma solidity ^0.8.13;

import "forge-std/Test.sol";
import "src/Contract.sol";

contract ContractTest is Test {
    Contract c;

    function setUp() public {
        c = new Contract();
    }

    function testCount() public {
        assertEq(c.count(), 0);
        c.plus();
        assertEq(c.count(), 1);
    }
}

Trying to run: forge test --debug "testCount" gives me this:
C:\Users\proto\Desktop\foundry-play>forge test --debug testCount
[⠔] Compiling...
[⠊] Compiling 1 files with 0.8.15
[⠒] Solc 0.8.15 finished in 1.49s
Compiler run successful
[⠔] Compiling...
Nothing to compile
The application panicked (crashed).
Message:  Target not found?
Location: cli\src\cmd\forge\script\build.rs:163

Backtrace omitted. Run with RUST_BACKTRACE=1 environment variable to display it.
Run with RUST_BACKTRACE=full to include source snippets.

while using forge debug --debug test/Contract.t.sol --sig "testCount()" works just fine, not sure if i am missing something here?

can you foundryup and try again?

Same error as #2085 and both of them use forge script by proxy (forge test --debug calls forge debug which is a wrapper around forge script)

I am not sure why this is happening or what the error is.
how can we fix this?

ah sorry missed that this is on windows.
just to confirm, standalone forge build and test work as expected and even forge debug
so it's just the forge test --debug combination that's not working?
we should be able to pin this down by comparing how we determine the target in forge debug vs forge test --debug

Well the other issue was also on Windows and used forge script directly - forge test --debug calls forge debug, which calls forge script. The debugger in forge script does not seem to work in some cases on Windows as described in the other issue - I think the case was if you specified both path and contract name, which is exactly what forge test --debug always does

Can you check the nightly that will be released in a few hours? None of us really use Windows so it's sort of a pain to figure out what the underlying cause is.

I am also experience same problem after the nightly version using WSL
`forge debug --debug src/contracts/core/interfaces/IVault.sol --sig "inManagerMode()"
[⠒] Compiling...
[⠔] Compiling 2 files with 0.6.12
[⠃] Solc 0.6.12 finished in 254.54ms
Compiler run successful
The application panicked (crashed).
Message:  Target not found?
Location: cli/src/cmd/forge/script/build.rs:168
This is a bug. Consider reporting it at https://github.com/foundry-rs/foundry
Backtrace omitted. Run with RUST_BACKTRACE=1 environment variable to display it.
Run with RUST_BACKTRACE=full to include source snippets.
Aborted (core dumped)`


Rework gopackagedriver to use driver protocol from x/tools

There is now an official documentation for the Package driver protocol via x/tools https://pkg.go.dev/golang.org/x/tools/go/packages#hdr-The_driver_protocol
This is what gopls will be built upon, and we should consider migrating there to have better compatibility with gopls in the future.
Worth noting that our package driver could now be used to power tools other than gopls. This includes golangci-lint or other linters in the same category. In the future, we should also aim to support official Go tools such as govulncheck via a proper package driver.

I've made this change in our internal fork of gopackagesdriver. Currently waiting on approval to open-source it and contribute it back :)


Use correct api params for NewDot>OldDot links

Details
Looks like we changed the GetShortLivedAuthToken command to just return shortLivedAuthToken and encryptedAuthToken but didn't consider the change for NewDot > OldDot links.
Fixed Issues
https://github.com/Expensify/App/pull/5359#issuecomment-926071634
Tests
To test this I just quickly applied this diff and then tapped on manage cards (I don't have this set up on dev but I think it will work fine). Without the other changes we get the undefined stuff.
diff --git a/src/pages/workspace/WorkspaceCardPage.js b/src/pages/workspace/WorkspaceCardPage.js
index 4eee5d7f9..386c5a66e 100644
--- a/src/pages/workspace/WorkspaceCardPage.js
+++ b/src/pages/workspace/WorkspaceCardPage.js
@@ -100,13 +100,13 @@ const WorkspaceCardPage = ({
     }

     const onPress = () => {
-        if (user.isFromPublicDomain) {
-            openSignedInLink(CONST.ADD_SECONDARY_LOGIN_URL);
-        } else if (user.isUsingExpensifyCard) {
+        // if (user.isFromPublicDomain) {
+        //     openSignedInLink(CONST.ADD_SECONDARY_LOGIN_URL);
+        // } else if (user.isUsingExpensifyCard) {
             openSignedInLink(CONST.MANAGE_CARDS_URL);
-        } else {
-            openBankSetupModal();
-        }
+        // } else {
+        //     openBankSetupModal();
+        // }
     };

QA Steps
Repeat steps in https://github.com/Expensify/App/pull/5359#issuecomment-926071634
Tested On

[x] Web
[ ] Mobile Web
[ ] Desktop
[ ] iOS
[ ] Android

Screenshots

Web

Mobile Web

Desktop

iOS

Android

Skipping unnecessary e2e to get this to staging

🚀 Cherry-picked to staging by @Jag96 in version: 1.1.1-7 🚀

platform
result

🤖 android 🤖
failure ❌

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

🚀 Deployed to production by @Jag96 in version: 1.1.1-8 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to staging by @Jag96 in version: 1.1.1-9 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by @timszot in version: 1.1.2-7 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
failure ❌

🕸 web 🕸
success ✅


Add Asset Registries tile to public dashboard (12240)

Issue #: https://github.com/bcgov/entity/issues/12240
Description:
Display different tiles for public users based on their product:

PPR - 'My Personal Property Registry' tile
MHR Product - 'My Manufactured Home Registry' tile
PPR and MHR Products - 'My Asset Registries' tile

Screenshots
PPR

MHR and PPR

No comments in addition to Cameron's. In future, Severin can also be added as a reviewer: he has done a lot of work on this site.

Good call!
Have added @severinbeauvais as reviewer (no pressure if you are busy though!)

Thanks @cameron-freshworks and @severinbeauvais for your comments. I refactored and cleaned up products/utils/tests.

@severinbeauvais thanks, I've made small fixes

@severinbeauvais so PR is approved but checks failed. Also, I don't have permission to merge.

@severinbeauvais so PR is approved but checks failed. Also, I don't have permission to merge.

When I click on the failed check details, it tells me someone needs to enter /gcbrun. Do you have permission to do that?
Update: Because I typed that in (even in back-quotes), it looks like it's going to run this time. Next time, check if you can run it.

Looks like it might still require someone with permissions to approve the ci to run?

Yea looks like it needs someone with the right access to run.

Hi @thorwolpert looks like we don't have proper permissions to run (or merge) this PR.

/gcbrun

/gcbrun

Temporary Url for review: https://yfthig-dev--pr-80-1qmtbgjz.web.app

After UX approval, we'll merge this

Design implementation looks good


chore: sync upstream with maci-rpgf

Maybe not related to this PR, but might be related to previous PR, which I didn't check it
https://github.com/privacy-scaling-explorations/maci-rpgf/blob/d232e3eea63897b70f09447a24c22d3afa9eed37/src/features/ballot/components/AllocationList.tsx#L43
here it take the pool token instead of the env token name, so it would look like this:

It would display as ETH instead of vote or points instead.

Maybe not related to this PR, but might be related to previous PR, which I didn't check it
https://github.com/privacy-scaling-explorations/maci-rpgf/blob/d232e3eea63897b70f09447a24c22d3afa9eed37/src/features/ballot/components/AllocationList.tsx#L43
here it take the pool token instead of the env token name, so it would look like this:
It would display as ETH instead of vote or points instead.

Thank you @kittybest for highlighting this! I've fixed these inconsistencies.


Don't automatically catch exceptions when enabling Sentry support

Hey!
When enabling Sentry support, uncaught exceptions are automatically intercepted. This is surprising for a library to take over exceptions and an application may want to do things differently and invoke capture! manually. Let the user opt-out (or opt-in) on exception catching.

Hi.
capture! can always be invoked manually. A flag  to opt-out makes sense in case you already have one.

+1 as we faced this issue in uri-dns

#9 provides an opt-out


Not able to import RandomSampler, Getting error "ImportError: cannot import name 'RandomSampler'"?

Not able to import RandomSampler, Getting error "ImportError: cannot import name 'RandomSampler'"? Did I get a wrong torch version?

The requirements.txt needs torch>=0.4.1 .    i've got the  version 0.5.0, how can i solve it? thank you~

how do you fix this issue?

how do you fix this issue?

try to update your torch version，i found it didn't work in torch 4.0.0, try  "torch >=4.0.1"


User: ListGroupMemberships

Changes:

clients/user.go: Added ListGroupMemberships to list user transitive memberOf
clients/user_test.go: Added tests for ListGroupMemberships
auth/claims.go: Changed from base64.StdEncoding. to base64.RawStdEncoding. to fix error decoding access token. more info

Any and all feedback, help, suggestions, edits etc is welcome!

@manicminer is pagination supported by Golang / base or is it something that needs to be implemented? Not sure how many groups needs to be created to actually test it.

@manicminer is pagination supported by Golang / base or is it something that needs to be implemented? Not sure how many groups needs to be created to actually test it.

@manicminer I will update the name tomorrow. Used the same as they have in the graphrbac client because that's what I've been using.
I will create a new issue for pagination.

@manicminer I will update the name tomorrow. Used the same as they have in the graphrbac client because that's what I've been using.
I will create a new issue for pagination.

@manicminer I've updated the method names.

@manicminer I've updated the method names.


Fill in the initial content of the repository

Signed-off-by: Steve Fontes<EMAIL_ADDRESS>Lots of work to do still.
Still need to fill in the details of the spec for the annotations.
May need to rethink @TraceDecorate, since there is not really a target it can be applied to.
@Tracer annotation can be removed and just use @Inject of an actual Tracer.
Tests of a sample implementation of @Trace and @NoTrace seem to work. Although the way the tests are written needs to be cleaned up.
Code is not commented fully.

I don't have the write access to this repo. I think we need to raise a bugzilla to get this fixed.

@Steve-Fontes I have reopened the bugzilla to fix the access right issue.


Add ability to handle explicit schema name.

When invoking render_er with a schema name, like:
    render_er(f"postgresql+psycopg2://DB_USERNAME@localhost:5001/DB_NAME",
              "DB_NAME.png",
              mode='graph',
              schema='DB_NAME')

The resulting image is missing the proper relationships. As mentioned in issue #67, the problem is that the left_col argument to Relation is missing the name of the schema. This PR aims to address the problem using the [subjectively] least intrusive means.
Closes #67

This PR also takes a crack at fixing Travis-CI configuration to start postgresql.

Didn't saw it.
Where is the assertion showing the issue #67 is fixed?
Le jeu. 9 janv. 2020 à 18:20, psipika<EMAIL_ADDRESS>a écrit :

@psipika commented on this pull request.
In eralchemy/sqla.py
https://github.com/Alexis-benoist/eralchemy/pull/70#discussion_r364864338
:

@@ -13,9 +13,20 @@

def relation_to_intermediary(fk):
"""Transform an SQLAlchemy ForeignKey object to it's intermediary representation. """
+

In the cases where schema name is provided, _column_tokens[1] is

insufficient to correctly identify the relationship. Therefore, assuming

that the schema name is _column_tokens[0], when set seems the least

intrusive approach. The other one would be sending in the schema name

as another parameter into this function from metadata_to_intermediary()

left_column = format_name(fk._column_tokens[1])
if fk._column_tokens[0]:

   left_column = "{}.{}".format(format_name(fk._column_tokens[0]),

The current test uses the local instance of a postgres database (named
test and created inside .travis.yml
https://github.com/Alexis-benoist/eralchemy/blob/master/.travis.yml#L14-L15.
Is that not enough?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/Alexis-benoist/eralchemy/pull/70?email_source=notifications&email_token=ABB3JJYB6TZOQIOCBEG7XGLQ45MELA5CNFSM4KBXTM62YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCRHHK2Y#discussion_r364864338,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABB3JJ5RFNT2AZQRD3ZH74TQ45MELANCNFSM4KBXTM6Q
.

Didn't saw it. Where is the assertion showing the issue #67 is fixed?

Here:
    tables, relationships = database_to_intermediary(db_uri, schema='test')
    table_names = [t.name for t in tables]
....
    # Assert column names match table names, including schema
    assert all(r.right_col in table_names for r in relationships)
    assert all(r.left_col in table_names for r in relationships)

Basically, the table names returned from the function call are in the form <schema name>.<table name>.  The names of Relation columns should use the same format. Issue #67 pertains to the fact that the original implementation returned names of the form <table name>, completely omitting the <schema name> portion. The additional assert() calls make sure that the column names returned inside relationships match those in the actual tables.

@psipika Thank you for this, I hope it gets merged.  Just a heads up that for my case, I needed to change eralchemy/sqla.py:74 to
relation_to_intermediary(fk, metadata.schema or table.schema)

My base is a DeclarativeMeta, and I defined schemas as the table level, e.g.:
class Foo(Base):
    __tablename__ = 'foo'
    __table_args__ = {"schema": "bar"}

The same problem exist also when the schema is not defined.
I create two schemas in postgresql but when i try to generate a diagram the relations are not generated because the left_col is never in include_tables (included_tables contains the fullname).

This is fixed in 9fbd13a767e828f372e23dbf5a15091df8bf0d42
Though we can take a closer look I we want to adapt the tests.


Fixed typo for Brave Browser version 1.12.107.

[x] Have you signed the Contributor License Agreement?
[x] Have you checked that there aren't other open pull requests for the same manifest update/change?

[x] Does your manifest conform to the 1.0 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.

Microsoft Reviewers: Open in CodeFlow

/azp run

/azp run

/azp run


Mac address in telemetry opt-in in stead of opt-out

Hi all,
I stumbled up on this ticket and noticed I got a .mono directory in my project containing a file with a key referring to a mac.address all of a sudden. Originating from the : https://github.com/dotnet/vscode-dotnet-runtime plugin for vscode.
See below:

I installed VSCode like 2 years ago on this machine, and wasn't asked for permission ("opt-in") from that moment on.
VSCode should not assume one is ok in sending stuff all over the web. Just do not do this...
Please respect privacy and allow people to opt-in, in stead of opt-out 🙏🏼
Now I need to be aware every time I install some add-on in vscode to switch it off before connecting the internet ;) (which is hard).

         Hi Matthew,

Thanks for reaching out – sorry this took a few days to bubble up to the top after the long weekend.
We use the data that VS Code gathers to provide and improve the product.  For example, in the past, we’ve used the data we collected to isolate several hard to track down sources of crashes and performance regressions.   VS Code may use the hashed MAC address to identify a machine over time.  For example, we may use the hashed MAC address to identify a particular machine experiencing an unusually high number of crashes (which would skew our crash result information).  You are right that we could correlate a machine across data streams, but that’s not how we use it -- we use the unique system information to connect things like crash reports with feature use.
When we first launched VS Code we didn’t allow people to opt out of this collection of data because it was a pre-release product and we were trying to understand if the product was actually useful and had the right mix of features.  As a fully released and supported product from Microsoft, we now let users opt out of providing data -- if users don’t want to provide us with data, then they can opt out but we really appreciate it when we do receive the telemetry as it helps improve the product for all.  That’s said, we want to ensure users have adequate control.
I’d be happy to chat with you on this issue and the points you raise.  I think the easiest way to do that is to connect on email/skype/hangout … I’m<EMAIL_ADDRESS>Sean

Originally posted by @seanmcbreen in https://github.com/microsoft/vscode/issues/8688#issuecomment-231487752

Could you file this on the repo that you identified? This doesn't come from VS Code itself. I don't know anything about that file specifically, but it doesn't necessarily look like it's being sent as telemetry to me.


[Feature Request]  event (and hook) listen when queue change

An interesting feature proposal. If you'd like to submit a PR I'll take a look and reopen the issue


Retract 3.4 and add <IP_ADDRESS> service release

cc @jbevain
cc @gregvanl, could we push this quickly, this is a hot bug fix release. Thank you.

@sailro,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/cross-platform/change-log-visual-studio-tools-for-unity.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Generate one class/interface/enum per file

Hi @AdrianWilczynski ,
the VS Code extension and CLI tools are great, very helpful and already saved me a lot of time 😉 Thanks for your great job!
However, I have some issue and want to ask you first, maybe you know something about that. I see that normally if I have few classes/interfaces/enums in a single C# file, cs2ts generates a single file with all these objects from C# file. However, in some cases from a single .cs file I have 2 .ts files generated - both with the same content (2 interfaces inside).
I'm also using import-generation = Simple. The issue is that sometimes few classes are defined in a single .cs file, but are needed in other .cs files (multiple), so the default naming convention for imports generation doesn't work properly.
What I'd like to achieve is that cs2ts generates a separate .ts file for each class/interface/enum it finds in the source .cs file. Do you know if this is somehow already supported?
If not, where should I look in the source code to contribute and add such a feature?
Thanks a lot for answering 😉

Hi, thanks for the report. Sorry, it's taking so long for me to respond. I'm really busy right now. But I'm gonna get to it as some point 😅

Sure, no worries. Just answer when you find some time.
For now, I decided to not use any automation for C#->TS generation, but it would be great if your tool supports generating separate .ts file for each C# object.
There are other solutions which supposedly support it (e.g. TypeGen), but it works on DLLs, not source (text) files like cs2ts, which is a great advantage over these tools 😉

I'm also using import-generation = Simple. The issue is that sometimes few classes are defined in a single .cs file, but are needed in other .cs files (multiple), so the default naming convention for imports generation doesn't work properly.

I think I have the same problem: Sometimes cs2ts generates two interfaces in one file and if those interfaces are referenced in another file, the imports may be wrong. E.g.
In file-A.ts
export interface A {...}
export interface B {...}
In another file
import { B } from "file-B.ts"   (instead of "file-A.ts")


Add instance_identity_add_spiffe_uri property to rep job

This adds a diego.executor.instance_identity_add_spiffe_uri property to the rep to optionally add the default SPIFFE URI needed for the Istio work. Defaults to false. Needs this PR: https://github.com/cloudfoundry/executor/pull/45.

See: https://github.com/cloudfoundry/executor/pull/45#issuecomment-476815877
Closing.


Re-add permission checking

And refactor requests.placeholderds to adapt to the new frontend needs

Coverage increased (+0.03%) to 86.462% when pulling 8579be00312ed665030297e3db6adfc782125a28 on feature/readd_permission_checking into 0136f3dea278fe0a7b02d1c97be75409a4c6ef86 on develop.

:+1:


Highlighting colors are greyed out

When changing to a new tab, highlighted words are the correct color. But, after a short time the color is greyed out for all words.
An example is probably better:
After a short time (really short,  I cannot take a picture before it changes :( ):

The before, would be with all the word with the same highlighted color than the colons

That's odd.
It's most likely that something else is interfering with the text, as it sounds like its rendering correctly to start with.
To narrow this down, I suggest you try disabling other extensions -- perhaps using VSCode's built-in bisecting method. Try this in other languages etc.

Please re-open if you find this is down to this plugin.


Asp.net Core 2 Razor Pages MapSpaFallback suggestion

MapSpaFallback works well for MVC routes but does not exist for the new Razor Pages.
If SpaRouteConstraint were public instead of internal with a little work developers can add the constraint to Razor pages:
//Starup.cs ConfigureServices
//thank you Scott Hanselman https://www.hanselman.com/blog/AddingACustomInlineRouteConstraintInASPNETCore10.aspx
services.Configure<RouteOptions>(options =>
                options.ConstraintMap.Add("spaRoute", typeof(SpaRouteConstraint)));
services.AddMvc()
                .AddRazorPagesOptions(options =>
                {
                    options.Conventions.AddPageRoute("/Index", "{*catchAll:spaRoute(catchAll)}");
                });

Would be even better if JavaScriptServices somehow added SpaRouteConstraint to the ConstraintMap.
For now I'll just copy the SpaRouteConstraint class.
Thanks,
Philip

I have just been using a regex to exclude the api routes.....
services
    .AddMvc()
    .AddRazorPagesOptions(options =>
    {
        options.Conventions.AddPageRoute("/Index", "{*url:regex(^(?!api).*$)}");
    });

Thanks for the suggestion. In the next update, we're providing an alternative to MapSpaFallbackRoute that isn't coupled to the concept of MVC actions. It looks like this:
app.UseSpa("root-directory-goes-here", () => { /* config goes here */ });

This is generic middleware that you can use either with MVC or Razor projects. Hopefully that will cover your requirements even more cleanly.

@SteveSandersonMS That'd be awesome. On at least two of my projects, there's just a thin layer of razor over an index.html (generated by webpack).

any toughs ?

@buvinghausen thank you for your solution. I took me a long time to understand it but it works now.
@SteveSanderson: when is this app.UseSpa avalible. With the newset version of .Net Core I don't have it yet :(

@jjgriff93 We shipped UseSpa in ASP.NET Core 2.1.

Hi , @jjgriff93
I am testing https://github.com/vasyliv/angular6/tree/angular-server to include it my project. I cannot get spa fall back to work any suggestion?

Thanks @SteveSandersonMS - turns out it was a completely unrelated problem to spaservices! It was an SSL error. @jfborie I'm probably not best placed to help as I'm fairly new with the framework myself; however if you post your issue up separately and reference it I'm happy to take a look and see if i have any suggestions. Make sure you tell us what the error is with any code you can share

I hit too many snag i am trying with https://github.com/angular/universal-starter for now. Thx.


reqOptions.headers.set is undefined

@RikkiGibson , https://github.com/Azure/ms-rest-js/blob/master/lib/policies/rpRegistrationPolicy.ts#L70 reqOptions.headers.set is undefined due to the empty object creation on line 61 with no members at all.

Also, reqOptions should be a WebResource instance. It should be somehting like var reqOptions = originalRequest.clone(); because WebResource methods will be called in the sequence.


Timeline function removed?

Hi, trying to fetch the timeline with
scraper.home_latest_timeline()

and i get
AttributeError: 'Scraper' object has no attribute 'home_latest_timeline'

was timeline removed? How am I able to get timeline. Thanks

Hey @trevorhobenshield, would you have any idea here?

This is a function of Account not Scraper, have a look at the readme

This is a function of Account not Scraper, have a look at the readme

home_timeline doesn't exist under account either

didn't catch this, but for some reason it is installing an old version of the package.