Outdated or incorrect build instructions for several targets

During the scripting of target build test automation for Travis CI (#2102), several issues have been identified:

[ ] ESP8266:

The apt dependencies list was overly extensive (at least compared to what Travis CI had already installed on the worker image), sometimes even erroneous (e.g., didn't have to install any libc6-dev* packages and actually couldn't install libtool-bin because such a package was not available).
The creation of the /opt/Espressif directory is described together with the dependencies step although it belongs to the crosstool-NG building step. Moreover, it should be noted that neither the building of ct-ng nor the execution of ct-ng to build a cross toolchain requires elevated privileges (it can be done somewhere in the user's home directory, not under /opt only).
Building crosstool-NG didn't work for me exactly as described, make detected recursion and bailed out.
When building the firmware with JerryScript, why must BIN_PATH be specified? Couldn't it have at least a default to be the same as BUILD_DIR?

[ ] Mbed OS 5:

The target needs heavy maintenance. As is, building an example app or a library from sources present under targets/mbedos5 with the Makefile is not possible. make all errors because there is no main in the code base, make library errors because launcher sources require jerry-targetjs.h that are explicitly not generated for libraries. Then the readme suggests to do a gulp-based build, but that build system uses a pinned JerryScript version (https://github.com/ARMmbed/mbed-js-gulp/blob/master/main.js, const JERRYSCRIPT_REVISION = '5cdb98c75ec231806677a8af0b16d508b1033eb2';) not master. So that seems never building with latest jerry. The target should always be able to test latest developments.

[ ] NuttX:

The readme doesn't mention which version of NuttX was last seen working. (7.22 worked for me, see makefile.)
The readme doesn't describe how configuration can be automated (without menuconfig that requires user interaction). Moreover, the readme suggests fetching the kconfig sources from a "3rd party" while the nuttx/tools repo contains its own kconfig sources.

[ ] Particle: I couldn't get it to build at all.
[ ] RIOT:

The readme doesn't pin the last known working version of RIOT. (2017.10 worked for me.)

[ ] Tizen RT:

The readme doesn't pin the last known working version of Tizen RT. (1.1_Public_Release worked for me but only if I adapted the romfs patch.)
PPA-based GCC6 version worked, too (readme mentions GCC4.9, but that just seems to be a lower bound, not a must).

[ ] Zephyr:

The readme doesn't pin the last known working version of Zephyr, which is quite an issue. Zephyr has changed build system on master to something cmake-based, which is completely incompatible with the code in targets/zephyr right now. For me, Zephyr 1.9.1 and Zephyr SDK 0.9.1 worked. (But even in this release, Zephyr doesn't seem to have the readme-suggested qemu make target anymore.)
Non-interactive installation required quite some recursive digging into self-extracting archives within self-extracting archives, because documentation suggests interactive installation of the SDK by "ansering all questions" (out of question on Travis).
Directory structure suggested by readme has zephyr-project, although when I clone it out from github, it will be named zephyr by default.
Calling make with ./targets/zephyr/Makefile.zephyr fails to build the JerryScript library with quite weird errors... unless you set CC to point deep within the Zephyr SDK: zephyr-sdk-0.9.1/sysroots/x86_64-pokysdk-linux/usr/bin/i586-zephyr-elfiamcu/i586-zephyr-elfiamcu-gcc. Which is not documented anywhere and was a hell to debug. Note: zephyr sets its the build environment for its own build system up by sourcing zephyr-env.sh, but JerryScript's build system will know nothing about that. And Makefile.zepyhr will use $CC which is usually still set to the native compiler.

It would be great if target maintainers could check these out.

A related issue, but not documentation related: calling make from makefiles is preferably done via $(MAKE) note make. Quote from the GNU make manual:

Recursive make commands should always use the variable MAKE, not the explicit command name ‘make’

Explanation can be found here: https://www.gnu.org/software/make/manual/make.html#MAKE-Variable
Affected makefiles: Makefile.{esp8266,mbed,particle,riot,tizenrt,zephyr}

I would like to select again official targets again to focus our resources.


CreateTeamsandSPO.ps1

Line 27 should read $teamNameSuffix = $configFile.GroupConfiguration.RoundingTeamSuffix
Original is looking for "prefix"

Resolved


There is no DotNetNuke.Web.Client <IP_ADDRESS>6 in NuGet

There is no DotNetNuke.Web.Client <IP_ADDRESS>6 in NuGet, which is strange as there is a <IP_ADDRESS>6 of the DotNetNuke.Bundle which lists the DotNetNuke.Web.Client > 9.2 as a requirement.

Are those MyGet packages actual releases or daily builds are there seemt be new releases daily or sometime even several releases each day?

@improwise they appear to be nightly builds. You'd need to match up the version number from the public release of 9.2.0. Sorry for the issues. We are working on getting all of this fixed and working much better very soon!


Id NameSpace - How can i create mulitiple groups to generate id from

Hi ,
Is there any way we can assign id Namespace and use that to generate Id from.
For example i have 4 entity type in my system like Product , Order , Customer , Account and i would like to generate id from same group for same entity .
GetId("Product");

Hi @ashishsoni
Can you explain your use case in a bit more detail? What would you expect the call GetId("product") to return you? Is it to allow the same ID to potentially be used multiple times for different namespaces?

What i want is basically have a namespace and generated ID from that namespace ...
Consider there are multiple entities in the system , Student , Course etc so when we request and unique id for a new student it should come from namespace / bucket of student and same for course.

OK, so when you have a set of IDs, you want to be able to work out if they are of the same namespace? Couldn't you just map the ID generation into another object with the namespace you require, or am I missing something?
Here's some example code that might do what you want:
class NameSpacedID {
  private final long id;
  private final long time;
  private final String namespace;

  public NamespacedId(final long id, final long time, final String namespace) {
    this.id = id;
    this.time = time;
    this.namespace = namespace;
  }

  public long getId() {
    return id;
  }

  public long getTime() {
    return time;
  }

  public String getNamespace() {
    return namespace;
  }
}

class NamespacedIdGenerator {
  private final String namespace;

  public NamespacedIdGenerator(final String namespace) {
    this.namespace = namespace;
  }

  public  generateId() {
    Optional<Id> id = icicleIdGenerator.generateId()
    if (id.isPresent) {
      return Optional.of(new NameSpacedId(id.getId, id.getTime, namespace))
    }
    return  Optional.absent()
  }
}

Closing this issue as there's been no activity - please feel free to reopen if you're still having issues. :smiley:


Work item service refactored  and tests added

Note: If there are pending changes to the PR, prefix the PR title with "WIP" and add the label "DO NOT MERGE"
Mandatory

[x] What does this PR do?

In this PR we refactored the work item services, removed most of the legacy code out of it.
Added bunch of unit tests for the work item service

[x] What issue/task does this PR references?
No reference needed
[x] Are the tests Included?
Yes

Optional

[ ] Is the documentation Included?

[ ] Are the Release Notes included?

[ ] @mention(s) to expected reviewer(s) included

[test]

@sanbornsen Your image is available in the registry. Run docker pull quay.io/openshiftio/fabric8-ui-fabric8-planner:SNAPSHOT-PR-2766 && docker run -it -p 5000:8080 quay.io/openshiftio/fabric8-ui-fabric8-planner:SNAPSHOT-PR-2766 and visit http://localhost:5000 to access it.


matplotlib.use(Agg) first

When using testflo, matplotlib plotting should be disable. (see #135)
To do that matplotlib.use('Agg') has to be called as soon as matplotlib is imported.
This PR fixes that for moe and mfk.
However, I had to add the following line :
matplotlib.pyplot.switch_backend('Agg')
at the beginning of smt/problems/tests/test_problem_examples.py to make it work on linux.
Weirdly on windows, the problem does not show up even without that PR.

Coverage decreased (-0.02%) to 77.37% when pulling 04b3f8f1c3173c980e3bdf6a25b7e1a215ae3518 on relf:fix-testflo-matplotlib into 9b61f276d3009272a29cd17b7c02e95a9d6239b4 on SMTorg:master.

:white_check_mark: Build SMT 0.2.505 completed (commit https://github.com/SMTorg/SMT/commit/aa521546ef by @relf)


Auto-resize bottom split

When linting or compile checking, the bottom window expands and takes up a lot more space than necessary. Manually dragging it down works until linting or compile checking again. Is there something wrong with my install, or is there a way to make not take up any more space than necessary?

That happens for me as well, I've always just kind of lived with it but I bet it can be fixed. I believe that the little pane is called the quickfix buffer. There is a note here overriding g:ghcmod_open_quickfix_function to customize the behavior. I'd love a pull request to tidy this up if you can figure it out!

Interested in helping out with this one?


Signature Pad with Pointer Lock

Hi, would it be cool if the signature pad had an ability to lock the cursor on the canvas?

I was trying to this myself alongside this plugin so I could essentially focus on the canvas only when a button is pressed so I can grab a graphics tablet input but haven't had much luck so far other than locking to the element (Can't get it to draw).
I did find some reading material related to the API which firefox and chrome use (no IE support yet) which might help though.
http://www.w3.org/TR/pointerlock/
https://developer.mozilla.org/en-US/docs/Web/API/Pointer_Lock_API
https://developer.mozilla.org/en-US/docs/Web/API/Element/setCapture
http://www.smartjava.org/content/html5-use-pointer-lock-api-restrict-mouse-movement-element


Caps is toggle incorrectly while using PowerToys run.

Microsoft PowerToys version
0.68.1
Installation method
PowerToys auto-update
Running as admin
Yes
Area(s) with issue?
PowerToys Run
Steps to reproduce
Steps to reproduce:
1-> open powertoys run
2-> start typing anything
3-> If capslock is on it type smallcase letter and vice-versa.
Screenshot of notepad window and powertoys run.

✔ Expected Behavior
When capslock is on it shall type uppercase not smallcase.
❌ Actual Behavior
When capslock is on it is typing letters in smallcase.
Other Software
No response

I'm facing it after updating powertoys to v0.68.1

bug report log zip
PowerToysReport_2023-03-21-11-05-51.zip

I reinstalled powertoys it is not there anymore.

Not able to repro this, going to close. Let us know if you see this again!


Added http operations sample code

@devlead can you rebase this against develop, and I will get it merged in.

Actually, @devlead I think this is covered in this PR:
https://github.com/cake-build/cake/pull/790
Since that one created first, can you review it, and if you are happy, merge that one in?

Missed that one, then I'll close this.


Add brick:Relationship superproperty

Rationale in discussion of #415 . I am adding this not for query performance but so that we have a parallel structure to brick:Entity (the root class of all Brick classes) for relationships. This only is for inter-entity relationships, so EntityProperties are not included under the brick:Relationship property hierarchy
This should be merged into a 1.3.1 should the change be accepted.

Two quick questions:

What's the relationship between the new brick:Relationship and the existing brick:EntityProperty?
Would it make sense to call it brick:Property instead of brick:Relationship?

What's the relationship between the new brick:Relationship and the existing brick:EntityProperty?

Entity Properties would be sibling to the proposed Relationship; Relationships are properties whose value is another "entity" (instance of Brick class). Entity Properties are static attributes of Brick entities.

Would it make sense to call it brick:Property instead of brick:Relationship?

I'd definitely consider that. Only reason I went with Relationship is because that is the word we've historically used in Brick publications to talk about the relationship between Brick entities.

@jbkoh thoughts?

We've been using 'relationship' for a long, long time. I wouldn't be excited about changing that term.

I like Relationship and also its distinction from EntityProperty, which is common in property graphs.


Add pg and a repository database

what do you think of using typeorm?

what do you think of using typeorm?

I would of use querys to pratice

what do you think of using typeorm?

I would of use querys to pratice


Copy 2 input availabilities-saved availabilities /Sahar

Naming Rules
Name your PR like this: ISSUENUMBER-TITLE-YOURNAME
Description
Write a summary of your change. Explain why you have made it.
Related to
Make sure you include the issue number with a hash sign # so Github can link this PR to the right issue, like this:
Fixes #1
Checklist:

[ ] My code follows the style guidelines of this project
[ ] I have carefully reviewed my own code
[ ] I have commented my code
[ ] I have updated any documentation

this pull request is based on input Availability-front-end and back end


Delete route

added styling to each new question and answer to section each set, bigger question text area rather than just text, added delete button for each new question


Pin time dependency to 0.2.7

Closes #20
Builds successfully, otherwise not tested.

Thanks, this works for me. I just threw the time = "=0.2.7" in my own Cargo.toml for now.


[INTERPRETER] Support slice, broadcast, and expand_dims.

FYI I changed the title to

[INTERPRETER] Support slice, broadcast, and expand_dims.

to better describe what this does -- we enable the tests, yes, but we also add support for the ops!


[ZEPPELIN-5155]. Add option to disable search

What is this PR for?
This introduce property zeppelin.search.enable so that user can disable search in some case (e.g. use zeppelin as job server).
What type of PR is it?
[ Improvement ]
Todos

[ ] - Task

What is the Jira issue?

https://issues.apache.org/jira/browse/ZEPPELIN-5155

How should this be tested?

CI pass

Screenshots (if appropriate)
Questions:

Does the licenses files need update? No
Is there breaking changes for older versions? No
Does this needs documentation? No

Thanks for the review @Reamer

LGTM


Issue of sys.exit(main()) in fivetran-connector-sdk package files

I have installed version fivetran_connector_sdk    <IP_ADDRESS>
I am simply testing the "hello_world" example - i.e. as in the Docs here
fivetran debug cmd works ✅ ( inc. warehouse.db is generated along with the 'hello' target table ✅ )
However, upon running a fivetran deploy command I encounter an error, which refers to fivetran-connector-sdk package files. How can I debug & pass this error?:
(fivetran-venv-3.11.8) monty.camelot on-fivetran % fivetran deploy --destination Warehouse_DevTestUAT --connection hello
WARNING: `requirements.txt` is not required as no additional Python libraries are required or all required libraries for your code are pre-installed.
Successful validation of requirements.txt
Traceback (most recent call last):
  File "/Users/monty.camelot/.pyenv/versions/fivetran-venv-3.11.8/bin/fivetran", line 8, in <module>
    sys.exit(main())
             ^^^^^^
  File "/Users/monty.camelot/.pyenv/versions/fivetran-venv-3.11.8/lib/python3.11/site-packages/fivetran_connector_sdk/__init__.py", line 1392, in main
    connector_object.deploy(args.project_path, ft_deploy_key, ft_group, ft_connection, configuration)
  File "/Users/monty.camelot/.pyenv/versions/fivetran-venv-3.11.8/lib/python3.11/site-packages/fivetran_connector_sdk/__init__.py", line 630, in deploy
    connection_id, service = self.__get_connection_id(
                             ^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/monty.camelot/.pyenv/versions/fivetran-venv-3.11.8/lib/python3.11/site-packages/fivetran_connector_sdk/__init__.py", line 728, in __get_connection_id
    return Optional[None, None]
           ~~~~~~~~^^^^^^^^^^^^
  File "/Users/monty.camelot/.pyenv/versions/3.11.8/lib/python3.11/typing.py", line 365, in inner
    return func(*args, **kwds)
           ^^^^^^^^^^^^^^^^^^^
  File "/Users/monty.camelot/.pyenv/versions/3.11.8/lib/python3.11/typing.py", line 488, in __getitem__
    return self._getitem(self, parameters)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/monty.camelot/.pyenv/versions/3.11.8/lib/python3.11/typing.py", line 712, in Optional
    arg = _type_check(parameters, f"{self} requires a single type.")
          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/monty.camelot/.pyenv/versions/3.11.8/lib/python3.11/typing.py", line 197, in _type_check
    raise TypeError(f"{msg} Got {arg!r:.100}.")
TypeError: typing.Optional requires a single type. Got (None, None).

Hi @lewisosborne,
There was a bug in version <IP_ADDRESS> that is likely causing the issue you're encountering.
Could you please update to the latest version?
You can do this by running:
pip install --upgrade fivetran_connector_sdk

Feel free to reach out if you run into any other problems! 😄


Consider moving honest profiler into an organization

I was very excited about how honest profiler will be in the future.
Honest profiler is the best free profiler that I had ever used.
I think had an organization will bring many advantage for the projects.
And thanks for your hard working on this.


Support for UMIs

Hi There,
Thanks for samblaster, it's such a great tool. I wonder if you have considered supporting unique molecular identifiers at all? bcl2fastq supports adding them to the read name. So if a standard read name was:
@M01277:231:000000000-A8KH6:1:1101:21912:1442 1:N:0:0
then it might be like this when an ID is added
@M01277:231:000000000-A8KH6:1:1101:21912:1442:TTTCCT 1:N:0:0
If there are two barcodes then they are separated by a plus, e.g.
@M01277:231:000000000-A8KH6:1:1101:21912:1442:TTTCCT+AACCTT 1:N:0:0
(I think - I only have data from one-barcode source).
The additional condition would be to check in the read signature if the putative duplicates share the ID.
Nugen have an algorithm here https://github.com/nugentechnologies/nudup/blob/master/nudup.py but it has so much overhead it would be great if samblaster supported the IDs.

hi @mjafin,
This might be offtopic but i have DigitalReadGroups that integrates the random barcodes to the readname and after sorting/adding readgroups splits them to different readgroups (for each sample) based on this insertion in the header. Read more about it on DigitalBarcodeReadgroups. Maybe you'll find some helpful suggestions.
Also my i ask how you run bcl2fastq & configure your samplesheet? I might consider supporting your usecase also.
Best MM Terpstra

Thanks @mmterpstra I'll look into that.
Actually bcl2fastq doesn't support our case out of the box. It supports UMIs that are at the start of the actual reads and then puts those into the read name. It doesn't support well UMIs that are in the index reads. We can get the UMIs out of the index reads but then we have _1, and _3 for the actual data and _2 fastq for the UMIs (if using a single UMI).
I asked Illumina if they could start supporting UMIs in indices out of the box but they just said that they "can't provide a timeline for such a request". Bummer.

Ok same experience here. The README.md from  DigitalBarcodeReadgroups describes that also. I hope my notes are readable.
Also notice my trimming by probe alignment location instead of trimming by probe sequence (because when the read still aligns to the reference after the probe seq it is likely to be a real sequence instead of artificial sequence). For now it only works with Single end seq (RNA/DNA). I hope to add Paired End support soonish.

+1

+1
UMIs can be easily added to the bam stream just before samblaster...
seqtk mergepe L2_Sigma_Set2_567_733UID.1.fastq.gz L2_Sigma_Set2_567_733UID.3.fastq.gz | \
 bwa mem -p -t 4 -R"@RG\tID:test\tSM:test"  genome.fa \
   /dev/stdin 2> test.log.bwamem | \
 fgbio AnnotateBamWithUmis \
   -i /dev/stdin -f test.2.fastq.gz  -o /dev/stdout  2> test.annotate_bam.log | \
 sambamba view -t 2 -l 0 -f sam /dev/stdin | \ #could be skipped if samblaster could take bam input,
 samblaster 2> test.dedup_log | \
 sambamba view -t 2 -S -f bam test.bam /dev/stdin

+1
UMI and cellular barcodes may be part of a SAM file as custom tags (such as CB, UB and so on). In that case it may be easy to use tags to build the read hash used to mark duplicates. More in general, it may be useful if one could specify a set of tags to be used in the duplicate detection


Decouple count from query in results workflow

The first page of results should be returned and displayed independently of the results count being displayed.

In order for this to work, the pagination components will need to be removed since the number of pages and thus the links require the count to be computed. However the resource still needs to receive the page and limit request params so it can calculate the OFFSET (so the right page is returned).
This unfortunately prevents the ability to create the page links since the size of the result set is unknown. However, there could be a parameter to invoke retrieving a fast page of results.


fix(gitbook): add plugins to dependencies

Deploy preview ready!
Built with commit 304020f5ac134bec823d0bb43768e68b6b0624a6
https://deploy-preview-334--mcs-lite-ui.netlify.com

Deploy preview ready!
Built with commit 010cfdc124bdf9187b0f465e33bbbf0fd309e420
https://deploy-preview-334--mcs-lite-introduction.netlify.com

These changes have been revert via #335 .


Install bootstrap

Do not reinvent the wheel, use bootstrap !

Main → https://getbootstrap.com
Grid layout → https://getbootstrap.com/docs/4.0/layout/grid/
Theme → https://bootswatch.com/


[$250]  Search - Receipt thumbnail becomes gray & blank after changing receipt from JPG to PDF file

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: v9.0.20-0
Reproducible in staging?: Y
Reproducible in production?: Y
Email or phone of affected tester (no customers<EMAIL_ADDRESS>Issue reported by: Applause Internal Team
Action Performed:

Go to staging.new.expensify.com
Go to FAB > Submit expense > Manual.
Submit a manual expense with JPG receipt.
Go to Search.
Click on the expense in Step 3.
Click on the receipt.
Replace the receipt with a PDF file.
Close the RHP.

Expected Result:
The receipt thumbnail in search expense list will update to show the pdf receipt.
Actual Result:
The receipt thumbnail in search expense list shows blank gray thumbnail after changing to a pdf receipt.
Workaround:
Unknown
Platforms:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

Screenshots/Videos
https://github.com/user-attachments/assets/818f63a1-e729-4239-9c20-7a6342182420

View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~0130e8b27688b14ba0
Upwork Job ID:<PHONE_NUMBER>329371979
Last Price Increase: 2024-08-14

Issue OwnerCurrent Issue Owner: @Pujan92

We think that this bug might be related to #wave-collect - Release 1

@joekaufmanexpensify  FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

cc @luacmartins

Waiting for proposals

Proposal
Please re-state the problem that we are trying to solve in this issue.
Search - Receipt thumbnail becomes gray & blank after changing receipt from JPG to PDF file
What is the root cause of that problem?
When we change the receipt to pdf file, the PDFThumbnail file doesn't handle the thumbnail image properly and seems not working, in other file like DistanceEReceipt file we use the image thumbnail for PDF provided by the BE, by invoking the
ReceiptUtils.getThumbnailAndImageURIs function
https://github.com/Expensify/App/blob/6a9a97690cd97f7f608ff9dd125ac1a7d7da3137/src/components/DistanceEReceipt.tsx#L30
https://github.com/Expensify/App/blob/6a9a97690cd97f7f608ff9dd125ac1a7d7da3137/src/components/DistanceEReceipt.tsx#L33
But in our case we not we use the PDF file link url
https://github.com/Expensify/App/blob/6a9a97690cd97f7f608ff9dd125ac1a7d7da3137/src/components/SelectionList/Search/TransactionListItemRow.tsx#L93
What changes do you think we should make in order to solve the problem?
We can use the same way used in other file i.e DistanceEReceipt
But in our case the BE for Search API doesn't return filename inside the receipt object which will be used to check if the file pdf we will get from BE for the thumbnail inside ReceiptUtils.getThumbnailAndImageURIs function.
So inside the ReceiptUtils.getThumbnailAndImageURIs function we can retrieve the filename receiptFilename from the url
What alternative solutions did you explore? (Optional)
Inside the TransactionListItemRow file we can retrieve the new transaction value from the Onyx by using the current transaction id i.e transaction_id, because the current transaction value from BE (Search API) that being pass to this function doesn't return with filename value inside receipt object

PDFThumbnail file doesn't handle the thumbnail image properly and seems not working

Why is this the case?

@luacmartins I don't know, when i see on report page it showing white background seems not working

Proposal
Please re-state the problem that we are trying to solve in this issue.
Search - Receipt thumbnail becomes gray & blank after changing receipt from JPG to PDF file
What is the root cause of that problem?
The component that renders the thumbnail is Image from React Native, which doesn't support displaying PDF files.
What changes do you think we should make in order to solve the problem?
We'll need to modify this source prop to send the correct uri using the getThumbnailAndImageURIs() function.
https://github.com/Expensify/App/blob/75f1729fc255df1792e37f9ad3e1b44d40d77f5b/src/components/SelectionList/Search/TransactionListItemRow.tsx#L93
We can apply the following logic, to check whether the file is PDF or not and pass the correct uri.
const filename = getFileName(transactionItem?.receipt?.source ?? '');
const receiptURIs = getThumbnailAndImageURIs(transactionItem, null, filename);
const isReceiptPDF = Str.isPDF(filename);
const source = tryResolveUrlFromApiRoot(isReceiptPDF ? receiptURIs.thumbnail ?? '' : receiptURIs.image ?? '');

@Pujan92 do you expect to be able to review the new proposal today?

Sorry for the delay @joekaufmanexpensify, I will review it tomorrow.

@NJ-2020 @AlfredoAlc
I see the pdf thumbnail image correctly when I revisit the page, I think TransactionListItem isn't rerendering when the pdf gets uploaded. Could you plz confirm and update your proposal accordingly if that is the case?
https://github.com/user-attachments/assets/974af70d-3471-42b3-94b4-9a60130241fb

As an fyi, going to be OOO from tomorrow - Monday. Not adding another BZ since should be nothing BZ-related till then. Please ask in slack if something comes up!

@Pujan92 Yes, when the receipt gets uploaded the file for that transaction gets updated with the new file which is a pdf. Pdf files are not rendered correctly from that Image component.
In that page we get the data via a snapshot, so when you revisit that page it gets a new snapshot which internally seems to apply a similar logic(as the proposal) to pdf files, and returns the transaction with a valid uri for the thumbnail.

@Pujan92 The PDFThumbnail seems not working it showing white background
https://github.com/user-attachments/assets/565f9e84-5991-4708-bc3e-5978878affaf
I think you can try to slow down your network to see the issue
And also we got thumbnail preview image from the BE and the PDFThumbnail will be replaced by the image thumbnail from BE

In that page we get the data via a snapshot, so when you revisit that page it gets a new snapshot which internally seems to apply a similar logic(as the proposal) to pdf files, and returns the transaction with a valid uri for the thumbnail.

Thanks @AlfredoAlc, I got your point.
@luacmartins Doesn't this need to be updated correctly from backend in the pusher event for the snapshot? I mean when we revisit the search the snapshot provides the image file for the transaction, shouldn't it do the same if we upload any new file?

We have live Onyx updates for Search, which means that if we get an Onyx update for a transaction that exists within the snapshot_ key, it should be updated accordingly. @Pujan92 do we get any Onyx update for the new receipt URL?

@luacmartins, I noticed below some cases.

If we try to add a new receipt in Search expenses, we don't get a new receipt URL

If we replace the existing receipt with the pdf, we receive an onyx update with the receipt details(Here we receive source as a pdf file contrary to the initial snapshot data where for pdf also it provides jpg as source). Attached video helps to understand.

https://github.com/user-attachments/assets/9219c923-1836-4624-8034-0e1ebe1a83fc

Pending input from @luacmartins on the above cases

@Pujan92 so the new update returns a pdf url instead of jpg one, is that right? I'm not sure we can change the type of the returned Onyx update (it might lead to bugs elsewhere in App). Can we just update the URL to match the jpg thumbnail format?

@Pujan92 so the new update returns a pdf url instead of jpg one, is that right?

Yes, that's the difference between the initial and updated snapshot.

I'm not sure we can change the type of the returned Onyx update (it might lead to bugs elsewhere in App). Can we just update the URL to match the jpg thumbnail format?

I believe, for the initial snapshot it seems transformed somewhere because in the below images you can see the transactions_ key has the receipt as pdf source whereas snapshot -> transactions_ has the jpg source.

Can we just update the URL to match the jpg thumbnail format?

Do you mean to just replace pdf extension with the jpg format? We can do that but I think better if this is first checked on the  backend side whether we can update snapshot with correct transformed URL the way we gets for initial snapshot.

@Pujan92 the snapshot url is initially a jpg because the backend returns the thumbnail version of the receipt, which is always jpg.

Do you mean to just replace pdf extension with the jpg format? We can do that but I think better if this is first checked on the backend side whether we can update snapshot with correct transformed URL the way we gets for initial snapshot.

Yes, it seems like we just replace that here when returning thumbnails. It seems like we can do that same in this case, without the additional error/local file logic in that method.

@Pujan92 @luacmartins Is any more discussion needed here before we can evaluate the proposals on the issue?

I think my latest comment should resolve the issue, maybe we need some updated proposals to account for that.

Got it. Sounds good! @AlfredoAlc @NJ-2020 could you please update your proposals?

Thanks @luacmartins.
RCA from the @NJ-2020 seems incorrect as we aren't using PDFThumbnail for the TransactionListItemRow.
@AlfredoAlc's RCA is correct and the solution makes sense to retrieve filename from the URL and based on filetype replace the extension as per the requirement. We can proceed with @AlfredoAlc's proposal.
🎀👀🎀 C+ reviewed

PR in review

PR merged

Looks like this one is due for payment but automation did not work.

I do see the second PR. Seems like that second PR was not a regression, is that right @luacmartins

Yea, it was a side effect but didn't cause a blocker

Got it. TY!

No regression penalty here then. Payment we need to issue here is:

@AlfredoAlc - $250 for PR via Upwork.
@Pujan92 - $250 for C+ review via NewDot.

Closing as all that's left is for @Pujan92 to request payment via NewDot. TY everyone!

$250 approved for @Pujan92


Feature: Axios.js

Can I use Axios.js in browsers

https://github.com/axios/axios#browser-support
Though:

Caniuse only tracks browser features, not library/frameworks. Will leave this issue open to add a search result.

Added as search result at https://caniuse.com/#search=axios


Grand Theft Auto (GTA1) crashes on start

Tested with latest release (<IP_ADDRESS>) of cnc-ddraw with the ini attached in the zip. It launched, but after a very brief black screen, it crashed and exited. Here are the log file and the dmp file created by the file in #44.
cnc-ddraw.zip

The game has all kind of bugs, I have to do some research to find out which bugs are game bugs and which ones are maybe caused by cnc-ddraw before I can actually fix it.
It lags sometimes after changing the resolution (F11) but you can keep changing the resolution a few times and eventually it will work.
If you change the resolution then the game will refuse to start the gameplay and you have to reinstall... I just switched to windowed mode with alt+enter and hit the X button in the window, this way it wouldn't save the resolution change and it started without having to re-install
Anyways, here's what i have for now:
cnc-ddraw.zip

Thank you, but with the cnc-ddraw attached above, it is still not working for me, keeping the same problem, even after reinstalling twice, and switching to windowed mode by editing ddraw.ini : ( Anyway, thank you in advance for your hard work.

How did you install the game?
I used this:
Name: GTAINSTALLER.exe
Size: 344338033 bytes (328 MiB)
SHA1: 762E03126A226E92E2F6827CA0750489595B52B2

Just tested again on a fresh windows 10 20h1 virtual machine with no runtimes or anything installed on it and it worked fine there too.
I only had a popup about missing directplay but windows installed it automatically. You could try to download dplayx.dll here and place it into the same folder as cnc-ddraw: https://github.com/CnCNet/dummy-dplayx/releases
This way we can find out if your problem is related to directplay or something else.

I used the cd image version found here: https://archive.org/details/GrandTheftAuto_201903
What you've said is freeware version I think, which seems to have even more bugs than original cd one, and thus I don't like to play that version.
As for directplay, I have installed it already and manually in control panel.
Anyway, I will try the freeware version with your fix later, and see if it still crashes.

I found it quite strange now. Neither cd version nor freeware version on my real Win10 machine worked, but on my virtual Win10 machine both version worked. I am kind of confused by this weird behavior.
This is my real Win10 machine spec:
CPU AMD FX(tm)-8300 Eight-Core Processor              3.30 GHz
Memory 16.0 GB
OS Windows 10 Pro 21H1
GPU AMD R9 370 4G
Driver version is 27.20.1034.6 shown in Device Manager.
The virtual Win10 machine one:
OS Windows 10 Pro 20H2
VMware tools are used in the virtual machine.
Hope these will help you find out the problem.

I just installed the cd version and checked your crash .dmp against it, the game is crashing because of a wndproc hook.
The bug isn't a cnc-ddraw bug but I added a patch into cnc-ddraw to fix it (I only patched the cd version, not the freeware version)
cnc-ddraw.zip

Thank you, both versions successfully launch now. Though it is far from really playable as it is very lagging during the gameplay. Hope for your later fixes! : )

You can try to change the renderer to direct3d9 or opengl, I had it set to gdi for testing and forgot to revert it.
Probably not too much more I can do to improve it

Tried the direct3d9 and opengl one, it is working with some tearing, but it can be fixed by setting vsync to true.
Ok then, I wonder some little questions. Is it possible to fix the lightning fast animation in the main menu? This problem seems only appears in cd version.
And is it possible to set the resolution to 32 bit color? It is possible to set this when not using cnc-ddraw, but when using it, only 16 bit color resolution can be chosen.

Looks like the freeware version got some bugs fixed but comes with a new bug as well, maybe it's better to just patch that one bug in the freeware version and use that one rather than the cd version?
About 32bit color: yeah, that's not supported right now. Is there actually a improvement in visual quality between 16 and 32bit? I would have to see some screenshots as comparision, if it's better I could add support for it. But I'm having my doubts about that...

Presumably, one of the advantages of using 32bit color is performance.  There is a performance hit in Windows when it has to convert a 16bit surface to a 32bit display.  It is now emulated in Windows 8 and newer.  Though I don't know how much difference that makes on newer computers.  Maybe only if you are running higher resolution like 4k, which some ddraw games can support.
Also, I think there are some ddraw games that only support 32bit color.  In the case of GTA1 it may be ok, since it supports both 32bit and 16bit color.  But for other games it might prevent them from running altogether.

Presumably, one of the advantages of using 32bit color is performance. There is a performance hit in Windows when it has to convert a 16bit surface to a 32bit display. It is now emulated in Windows 8 and newer. Though I don't know how much difference that makes on newer computers. Maybe only if you are running higher resolution like 4k, which some ddraw games can support.

Yeah that's normally the case, but with cnc-ddraw it's always 32bit and the color conversion is done with a shader so it would only get slower in this case. I don't really know what happens when you choose 32bit in this game, in the worst case the visual quality will be the same but the performance will be worse if the game does the color conversion on the CPU

Also, I think there are some ddraw games that only support 32bit color. In the case of GTA1 it may be ok, since it supports both 32bit and 16bit color. But for other games it might prevent them from running altogether.

Yeah that might be true, haven't seen one yet though

I think I just fixed the bug that was causing the freeware version to crash on the second start:
cnc-ddraw.zip

I am not very sensitive to the visual quality, so I don't see much difference between 16 bit and 32 bit mode in GTA1.
Anyway, these are the cnc-ddraw ones:

These are screenshots taken from my Winxp virtual machine without cnc-ddraw (since it is really not playable in Win10 without any wrapper, and my screen was flickering when switched to 32 bit mode in Win10, and the screenshots are always black)

I have not tested the freeware version though, these are all the cd version ones.

Tried on the freeware version with the latest cnc-ddraw above, I have not experienced any lagging yet, at least I don't think I encountered any lagging. Maybe I need to do more testing.

Yeah I think it's both the same, the 32bit is probably just 16bit converted to 32bit so it might not be a good idea to use it. I made the 32bit now working with all renderers on cnc-ddraw anyways.
The lag only happened on a virtual machine, it does work well on my win 10 (with singlecpu=false) and also works well on my XP too, so maybe it's fine now.
I removed all the workarounds now and got all fixes pushed to github, does this one here still work for you?
cnc-ddraw.zip
I can only test with the freeware version BTW, CD versions claims that I don't have the CD in my drive

The CD version is working well on my Win10 real machine using latest cnc-ddraw above. It launched with no problem and no lagging was seen during my test. BTW, CD version of GTA only supports one CD drive with the first letter. For example, if you have D, E, F CD drives, only D drive will be recognized. Kinda like C&C DOS version I think.

Cool, thanks for testing! Will try to fix my CD version and do some tests there too just to be sure

Just tested the expansion packs of GTA1, Grand Theft Auto: 1969 and Grand Theft Auto: 1961, both worked fine on my machine after copying the preset of GTA1 and editing the name to the main exe name of the expansion packs. Maybe you can just add the preset to the ddraw.ini. The main exe name of 1969 is gta_uk.exe, and the 1961 one is Gta_61.exe.

I don't know if it is legal to share GTA London 1969 here, since only GTA1 is released before as freeware. But since London 1969 is actually abandonware now, I try to give the link where I found the game: https://www.myabandonware.com/game/grand-theft-auto-mission-pack-1-london-1969-7ps If anyone think it is illegal, tell me here and I will remove the link at once.
As for London 1961, it is free, but it is just an addon to 1969 and thus depends upon 1969 to work. Link is here: https://web.archive.org/web/20200604172153/http://www.rockstargames.com:80/gtalondon/ftp/Gta1961/Gtal1961.exe

Sorry to bother you, I haven't found I have mistaken the name of expansion packs until now, they should be Grand Theft Auto: London 1969 and Grand Theft Auto: London 1961. I apologize for my oversight.

Fixed the name of the presets and just made a new release that supports GTA: https://github.com/CnCNet/cnc-ddraw/releases
I'm closing this issues here now, if you should find any more bugs then please let me know (Create a new issue then!)


Add OPTICAL_ELEMENT_NAME field for HST-STIS

The field:
  OBJECT                        = COLUMN
    NAME                        = OPTICAL_ELEMENT_NAME
    DATA_TYPE                   = CHARACTER
    COLUMN_NUMBER               = 22
    START_BYTE                  = 375
    BYTES                       = 6
    FORMAT                      = "A6"
    DESCRIPTION                 = "The name of the optical element
(grating, mirror, or prism) for the observation."
  END_OBJECT                    = COLUMN

is not currently available for searching in OPUS (it's different from FILTER_NAME, which is). This is an HSTSTIS-specific field. But for spectroscopic observations, the filter is "CLEAR" while this field gives the grating type, which I think it critical information. Right now we don't have any instrument-specific tables for HST - it's all in the one mission table. Should we add a field like this that is only valid for STIS?

From BYBTW 1/7/2020 - yes add this field as-is.


Remove blocking functionality?

@TomMelt and I haven't been able to come up with a good use case for the blocking functionality in domain_decomp. If used, there isn't any metadata that says this is the case, meaning outputs could be incorrectly interpreted.

Closed by #40.


webpack bundle error

webpack 5.66.0 compiled successfully in 3940 ms
Error [ERR_REQUIRE_ESM]: Must use import to load ES Module: xxx/node_modules/chatgpt/build/index.js
require() of ES modules is not supported.
require() of xxx/node_modules/chatgpt/build/index.js from xxx/dist/src/modules/chat/Chat.service.js is an ES module file as it is a .js file whose nearest parent package.json contains "type": "module" which defines all .js files in that package scope as ES modules.
Instead rename index.js to end in .cjs, change the requiring code to use import(), or remove "type": "module" from xxx/node_modules/chatgpt/package.json.

From the readme:
async function example() {
  // To use ESM in CommonJS, you can use a dynamic import
  const { ChatGPTAPI } = await import('chatgpt')

  const api = new ChatGPTAPI({
    sessionToken: process.env.SESSION_TOKEN
  })
  await api.ensureAuth()

  const response = await api.sendMessage('Hello World!')
  console.log(response)
}

(This project does not support commonjs exports because they are deprecated for all intents and purposes and it is a huge pain for maintainers to support.)
Here's a solid guide on other ways to use ESM modules like chatgpt.

From the readme:
async function example() {
  // To use ESM in CommonJS, you can use a dynamic import
  const { ChatGPTAPI } = await import('chatgpt')

  const api = new ChatGPTAPI({
    sessionToken: process.env.SESSION_TOKEN
  })
  await api.ensureAuth()

  const response = await api.sendMessage('Hello World!')
  console.log(response)
}

(This project does not support commonjs exports because they are deprecated for all intents and purposes and it is a huge pain for maintainers to support.)
Here's a solid guide on other ways to use ESM modules like chatgpt.

maybe that is not same as what did i say, your module is declare as a module by type: module, but, in your dependency package(expiry-map), it use require to import module ,

@PengBoUESTC ESM modules can import commonjs modules, but commonjs cannot synchronously import ESM modules.

@PengBoUESTC ESM modules can import commonjs modules, but commonjs cannot synchronously import ESM modules.

that's may be my fault, build tool transform import to require

@PengBoUESTC ESM modules can import commonjs modules, but commonjs cannot synchronously import ESM modules.

that's may be my fault, build tool transform import to require

I believe it was the case with  "vue-cli-plugin-electron-builder": "~2.1.1"
This  solved it for me!


EQ 560 gain/Q interaction problem?

I love your EQ 560 (it's probably the greatest graphic EQ there is in JS format) but I noticed that there might be a miscalculation in the max Q value.
In line 79 the maximum Q value of 5.763566 seems too large. If you divide it by 8, so that it becomes 0.72044575, the gain/Q interaction becomes pretty much identical to UAD's API 560. I don't own a real one (unfortunately) so I can't say for sure that this is how a real 560 behaves, but UAD are usually pretty close with the filter shapes in their EQs.
I did upload my own modded version to the Reaper stash, but I should ofc have asked you first. If you'd like I can remove it again!
Thanks for your great work!
(PS: Now that Reaper has native plug-in instance and FX-chain oversampling it could make sense to have a on/off control for the internal oversampling, just in case someone wants to use the FX-chain oversampling function)

Don't worry, you don't need to remove your file from the Reaper stash. 😆
This EQ is not supposed to be a direct copy of the 560, but granted, I did A/B it with a few hardware and software clones. I set the values to what I think sounded good, not to what an actual 560 sounds like.
Already at the time of uploading, I considered if it's worth renaming it to something else so it won't suffer from this "but it doesn't sound exactly like" problem. But I couldn't think of a better name, so project name 560 it was. 🤷
At some point in the future, I'll re-visit several of these plugins and update them, I'll consider the oversampling switch if I can remember. ;)


Use trace_with to start and end batches

I'm hoping to consolidate GraphQL-Ruby's many instrumentation hooks in GraphQL-Ruby 3.0 (someday). I'm hoping to add a deprecation warning to instrument(...) in the next release (https://github.com/rmosolgo/graphql-ruby/pull/4771), trace_with is sufficient for those cases.
This PR moves GraphQL-Batch's hooks to trace_with, what do you think of that?

It looks like GraphQL-Ruby doesn't support Ruby 2.4 anymore 😅

Fixed in https://github.com/Shopify/graphql-batch/pull/165

Thanks, I merged master into this branch :+1:

@swalkinshaw thank you very much. Do you plan to release this in a new version? That would be extremely helpful.


#1372 fix ssl when navigate to site with cert expiring after 2038

There aren't any 'working' SSL tests in the test suite, but I have tested a built version with my app and can confirm this fixes the issue with certs expiring > 2038

Thanks!

No problem, I don't have permission to merge this, please can you merge when convenient? Thanks!

@pete-reay-waters this is is on v2.0.1 now.

@kblok thanks very much for getting it merged and into a new version!


[measure-tools] update to itwinui v3

update to itwinui v3

only being used for 1 icon

need to update appui to minimum of 4.10 to use itwinuiv3 in appui
updated core, presentation, appui deps to latest minor to make sure no apis were deprecated

I'm unsure here why there was a need to change the peerDeps at all. Since there's no new api that are being used.
Are all of these package updates (peerDeps and devDeps) really needed in that case?
I would not want every consuming app for this package to have to update all of this right away.


Html range vs noSliderUi alignment flaw

Not sure whether it's a bug, but take a look yourself

I dont get it :/

As you can see, the two sliders are not aligned equally.

Can not reproduce it with the latest release.

This is a thing for me, too. I can confirm SHAD0WF4X's issue.
The error even occurs on the forms page, which I would assume to be the latest release. On local development I learned that the fewer steps you have on the range as a whole, the more obvious this misalignment becomes. (Example: a range that goes from 30 to 50 with steps of 10--meaning you have three steps on the whole range--has a bigger misalignment than the showcase range with 100 steps.)
Tested with FF 52.0.2 (32bit) and Chrome 56.0.2924.133 (64bit).

When did you test? (Windows 10 64bit here)

Probably related to https://github.com/Dogfalo/materialize/issues/4464

The moment I wrote my comment, on Win7 64bit.
Upon reading the reading the original post again, I see that I have misunderstood the issue here. Just saw the mispositioned blob and thought, that this is my issues, my bad.
Alignment of the range itself is fine. The big thumb is misaligned, though.

Materialize's showcase

Lokal project
Maybe that's indeed a new issue... Sorry for mixing it up.

The PR should fix this. https://github.com/Dogfalo/materialize/pull/4466/files
The PR is just in the master branch and not yet available as release.
https://github.com/Dogfalo/materialize/releases

48 commits to master since this release

Like @DanielRuf mentioned, should be fixed with #4466


BWAmem vs Mapcaller mapping stats

Hi, having a fast aligner and variant caller is very much appreciated. However I've been looking into the different map stats between BWAmem and Mapcaller and there is quite a difference in mapping rates:
samtools flagstat HZK_11-0735_S122_R1.fastq.gz.SolyntusV1.1.mapc.bam
50358636 + 0 in total (QC-passed reads + QC-failed reads)
50358636 + 0 primary
0 + 0 secondary
0 + 0 supplementary
0 + 0 duplicates
0 + 0 primary duplicates
36278106 + 0 mapped (72.04% : N/A)
36278106 + 0 primary mapped (72.04% : N/A)
50358636 + 0 paired in sequencing
25179318 + 0 read1
25179318 + 0 read2
24849642 + 0 properly paired (49.35% : N/A)
24849642 + 0 with itself and mate mapped
11428464 + 0 singletons (22.69% : N/A)
0 + 0 with mate mapped to a different chr
0 + 0 with mate mapped to a different chr (mapQ>=5)
samtools flagstat HZK_11-0735_S122_R1.fastq.gz_SolyntusV1.1.bwa.bam
52365809 + 0 in total (QC-passed reads + QC-failed reads)
50358636 + 0 primary
2007173 + 0 secondary
0 + 0 supplementary
0 + 0 duplicates
0 + 0 primary duplicates
51206861 + 0 mapped (97.79% : N/A)
49199688 + 0 primary mapped (97.70% : N/A)
50358636 + 0 paired in sequencing
25179318 + 0 read1
25179318 + 0 read2
40314272 + 0 properly paired (80.05% : N/A)
48719150 + 0 with itself and mate mapped
480538 + 0 singletons (0.95% : N/A)
6854398 + 0 with mate mapped to a different chr
3738627 + 0 with mate mapped to a different chr (mapQ>=5)
I presume this also has an effect on the variants called. What are your ideas about these differences in mapping rates ?

Maybe i should have mentioned that the sample is a tetraploid heterozygous potato, SNP density 1:20.


ui: make citesummary graph numbers more visible

INSPIR-3266

I didn't notice that, I removed it.

can you rebase @miguelgrc ?


[Issue]: The payment status is FAILED

Describe the Issue
Hi team,
We are receiving a error when hyperwallet connector is trying to pay the invoice to one of our customers. I have told with yours service department to try to check if there is a field value wrong, but they say that all is correct and recommend me to open this issue ticket.
Log error:
com.hyperwallet.clientsdk.model.HyperwalletPayment@53bf7abe[amount={amount},clientPaymentId=230202-operatorFee,createdOn=,currency=EUR,destinationToken={destinationToken},expiresOn=,links=,memo=,notes=,programToken={programToken},purpose=OTHER,releaseOn=,status=,token=,inclusions={destinationToken,programToken,amount,clientPaymentId,purpose,currency}]
Mail notification error:
Something went wrong creating payment for invoice [230202] {exceptionMessage=The client payment reference has already been used for a different transaction,error=DUPLICATE_CLIENT_REFERENCE[[code=DUPLICATE_CLIENT_REFERENCE,fieldName=,message=The client payment reference has already been used for a different transaction,relatedResources=]]}
I will contact with your partners for they can send you the log files (for security)
Thank you in advance
Environment
Live/Production
Version
4.3.2
Expected Behavior
Pay the invoice
Actual Behavior
It's not paying the invoice
Steps to Reproduce
Every 15 days Hyperwallet connector is generating the partner invoice and then it's necessary to pay it
Pre-conditions
No response
Relevant log output
No response

Hi @packs1200
Thanks for reaching out!
The error returned "The client payment reference has already been used for a different transaction" seems to be a valid error thrown by Hyperwallet. It seems that you are passing a unique ID for the invoice payment that has already been used/processed by Hyperwallet on another payment.
I would recommend to get back to David to check together on the HW side what is going on.
We keep this issue opened in the meantime in case the HMC might be at fault.
Don't hesitate to let us know if you need anything else,
Best,

Good Morning @packs1200
Another speculation of what could be happening is that the same payout request is being sent by the HMC to Hyperwallet as you are using a very old version of the HMC where things like that could happen.
Additionally to the error, are you witnessing any problem on HW or Mirakl side? I mean, is the payment going through? Is the invoice status properly updated on Mirakl side?


Added locale switcher and common info for the homepage

Problem

Added locale switcher to the layout
Translated nav menu for login and register pages
Added content to the homepage

Source https://docs.google.com/document/d/1CBD3rOz-7dhz4jSw6ASqEfXGVrzx6v0bJLZgzSJ7jx8/edit
For the English version Google Translate has been used (Needs fine-tuning)

Link to ora.pm - https://ora.pm/project/277933/kanban/task/4625775

Known issues

Mismatch between the server the clientText content did not match. Server: "Home" Client: "Начало"

Screenshots:

BG
EN

Awesome work!

Awesome work!

@arthas168 Thanks for the proofreading and the fixes. Indeed I didn't spent a lot of time on that part.

@arthas168 Thanks for the proofreading and the fixes. Indeed I didn't spent a lot of time on that part.


Is PreferencesFX compatible with JavaFX 11?

Hello.
I like to use PreferencesFX in my project. It looks really great!
Does PreferencesFX run without problems with JavaFX11 / JavaFX12, too?

I've just seen that there is a Release 11.1 which works. Great!


more readme updates

Pull Request Test Coverage Report for Build 551884035

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 94.386%

Totals

Change from base Build 551840160:
0.0%

Covered Lines:
2320

Relevant Lines:
2458

💛  - Coveralls


OpenStack SSA error NotImplementedError in type_cast

Just error in logs SSA finishes
[----] E, [2016-05-13T16:07:48.612833 #6492:32d994] ERROR -- : Q-task_id([agent_job_state_1463148463]) MIQ(MiqQueue#deliver) Message id: [14861], Error: [NotImplementedError]
[----] E, [2016-05-13T16:07:48.612923 #6492:32d994] ERROR -- : Q-task_id([agent_job_state_1463148463]) [NotImplementedError]: NotImplementedError  Method:[rescue in deliver]
[----] E, [2016-05-13T16:07:48.612984 #6492:32d994] ERROR -- : Q-task_id([agent_job_state_1463148463]) /home/Ladas/.rvm/gems/ruby-2.2.3/bundler/gems/rails-617fc389d46e/activerecord/lib/active_record/attribute.rb:84:in `type_cast'
/home/Ladas/.rvm/gems/ruby-2.2.3/bundler/gems/rails-617fc389d46e/activerecord/lib/active_record/attribute.rb:46:in `original_value'
/home/Ladas/.rvm/gems/ruby-2.2.3/bundler/gems/rails-617fc389d46e/activerecord/lib/active_record/attribute.rb:44:in `original_value'
/home/Ladas/.rvm/gems/ruby-2.2.3/bundler/gems/rails-617fc389d46e/activerecord/lib/active_record/attribute.rb:123:in `changed_from_assignment?'
/home/Ladas/.rvm/gems/ruby-2.2.3/bundler/gems/rails-617fc389d46e/activerecord/lib/active_record/attribute.rb:55:in `changed?'
/home/Ladas/.rvm/gems/ruby-2.2.3/bundler/gems/rails-617fc389d46e/activerecord/lib/active_record/attribute_mutation_tracker.rb:25:in `changed?'
/home/Ladas/.rvm/gems/ruby-2.2.3/bundler/gems/rails-617fc389d46e/activerecord/lib/active_record/attribute_mutation_tracker.rb:9:in `block in changed_values'
/home/Ladas/.rvm/gems/ruby-2.2.3/bundler/gems/rails-617fc389d46e/activerecord/lib/active_record/attribute_mutation_tracker.rb:8:in `each'
/home/Ladas/.rvm/gems/ruby-2.2.3/bundler/gems/rails-617fc389d46e/activerecord/lib/active_record/attribute_mutation_tracker.rb:8:in `each_with_object'
/home/Ladas/.rvm/gems/ruby-2.2.3/bundler/gems/rails-617fc389d46e/activerecord/lib/active_record/attribute_mutation_tracker.rb:8:in `changed_values'
/home/Ladas/.rvm/gems/ruby-2.2.3/bundler/gems/rails-617fc389d46e/activerecord/lib/active_record/attribute_methods/dirty.rb:83:in `changed_attributes'
/home/Ladas/.rvm/gems/ruby-2.2.3/bundler/gems/rails-617fc389d46e/activemodel/lib/active_model/dirty.rb:137:in `changed?'
/home/Ladas/.rvm/gems/ruby-2.2.3/bundler/gems/rails-617fc389d46e/activerecord/lib/active_record/timestamp.rb:85:in `should_record_timestamps?'
/home/Ladas/.rvm/gems/ruby-2.2.3/bundler/gems/rails-617fc389d46e/activerecord/lib/active_record/timestamp.rb:72:in `_update_record'
/home/Ladas/.rvm/gems/ruby-2.2.3/bundler/gems/rails-617fc389d46e/activerecord/lib/active_record/persistence.rb:534:in `create_or_update'
/home/Ladas/.rvm/gems/ruby-2.2.3/bundler/gems/rails-617fc389d46e/activerecord/lib/active_record/callbacks.rb:298:in `block in create_or_update'
/home/Ladas/.rvm/gems/ruby-2.2.3/bundler/gems/rails-617fc389d46e/activesupport/lib/active_support/callbacks.rb:97:in `__run_callbacks__'
/home/Ladas/.rvm/gems/ruby-2.2.3/bundler/gems/rails-617fc389d46e/activesupport/lib/active_support/callbacks.rb:750:in `_run_save_callbacks'
/home/Ladas/.rvm/gems/ruby-2.2.3/bundler/gems/rails-617fc389d46e/activerecord/lib/active_record/callbacks.rb:298:in `create_or_update'
/home/Ladas/.rvm/gems/ruby-2.2.3/bundler/gems/rails-617fc389d46e/activerecord/lib/active_record/persistence.rb:125:in `save'
/home/Ladas/.rvm/gems/ruby-2.2.3/bundler/gems/rails-617fc389d46e/activerecord/lib/active_record/validations.rb:44:in `save'
/home/Ladas/.rvm/gems/ruby-2.2.3/bundler/gems/rails-617fc389d46e/activerecord/lib/active_record/attribute_methods/dirty.rb:22:in `save'
/home/Ladas/.rvm/gems/ruby-2.2.3/bundler/gems/rails-617fc389d46e/activerecord/lib/active_record/transactions.rb:319:in `block (2 levels) in save'
/home/Ladas/.rvm/gems/ruby-2.2.3/bundler/gems/rails-617fc389d46e/activerecord/lib/active_record/transactions.rb:395:in `block in with_transaction_returning_status'
/home/Ladas/.rvm/gems/ruby-2.2.3/bundler/gems/rails-617fc389d46e/activerecord/lib/active_record/connection_adapters/abstract/database_statements.rb:230:in `transaction'
/home/Ladas/.rvm/gems/ruby-2.2.3/bundler/gems/rails-617fc389d46e/activerecord/lib/active_record/transactions.rb:211:in `transaction'
/home/Ladas/.rvm/gems/ruby-2.2.3/bundler/gems/rails-617fc389d46e/activerecord/lib/active_record/transactions.rb:392:in `with_transaction_returning_status'
/home/Ladas/.rvm/gems/ruby-2.2.3/bundler/gems/rails-617fc389d46e/activerecord/lib/active_record/transactions.rb:319:in `block in save'
/home/Ladas/.rvm/gems/ruby-2.2.3/bundler/gems/rails-617fc389d46e/activerecord/lib/active_record/transactions.rb:334:in `rollback_active_record_state!'
/home/Ladas/.rvm/gems/ruby-2.2.3/bundler/gems/rails-617fc389d46e/activerecord/lib/active_record/transactions.rb:318:in `save'
/home/Ladas/.rvm/gems/ruby-2.2.3/bundler/gems/rails-617fc389d46e/activerecord/lib/active_record/suppressor.rb:41:in `save'
/home/Ladas/.rvm/gems/ruby-2.2.3/bundler/gems/rails-617fc389d46e/activerecord/lib/active_record/persistence.rb:266:in `block in update'
/home/Ladas/.rvm/gems/ruby-2.2.3/bundler/gems/rails-617fc389d46e/activerecord/lib/active_record/transactions.rb:395:in `block in with_transaction_returning_status'
/home/Ladas/.rvm/gems/ruby-2.2.3/bundler/gems/rails-617fc389d46e/activerecord/lib/active_record/connection_adapters/abstract/database_statements.rb:232:in `block in transaction'
/home/Ladas/.rvm/gems/ruby-2.2.3/bundler/gems/rails-617fc389d46e/activerecord/lib/active_record/connection_adapters/abstract/transaction.rb:189:in `within_new_transaction'
/home/Ladas/.rvm/gems/ruby-2.2.3/bundler/gems/rails-617fc389d46e/activerecord/lib/active_record/connection_adapters/abstract/database_statements.rb:232:in `transaction'
/home/Ladas/.rvm/gems/ruby-2.2.3/bundler/gems/rails-617fc389d46e/activerecord/lib/active_record/transactions.rb:211:in `transaction'
/home/Ladas/.rvm/gems/ruby-2.2.3/bundler/gems/rails-617fc389d46e/activerecord/lib/active_record/transactions.rb:392:in `with_transaction_returning_status'
/home/Ladas/.rvm/gems/ruby-2.2.3/bundler/gems/rails-617fc389d46e/activerecord/lib/active_record/persistence.rb:264:in `update'
/home/Ladas/Projects/cfme/manageiq/app/models/job.rb:77:in `agent_state_update'
/home/Ladas/Projects/cfme/manageiq/app/models/job.rb:63:in `agent_state_update_queue'
/home/Ladas/Projects/cfme/manageiq/app/models/miq_queue.rb:347:in `block in deliver'
/home/Ladas/.rvm/rubies/ruby-2.2.3/lib/ruby/2.2.0/timeout.rb:88:in `block in timeout'
/home/Ladas/.rvm/rubies/ruby-2.2.3/lib/ruby/2.2.0/timeout.rb:32:in `block in catch'
/home/Ladas/.rvm/rubies/ruby-2.2.3/lib/ruby/2.2.0/timeout.rb:32:in `catch'
/home/Ladas/.rvm/rubies/ruby-2.2.3/lib/ruby/2.2.0/timeout.rb:32:in `catch'
/home/Ladas/.rvm/rubies/ruby-2.2.3/lib/ruby/2.2.0/timeout.rb:103:in `timeout'
/home/Ladas/Projects/cfme/manageiq/app/models/miq_queue.rb:343:in `deliver'
/home/Ladas/Projects/cfme/manageiq/app/models/miq_queue_worker_base/runner.rb:106:in `deliver_queue_message'
/home/Ladas/Projects/cfme/manageiq/app/models/miq_queue_worker_base/runner.rb:134:in `deliver_message'
/home/Ladas/Projects/cfme/manageiq/app/models/miq_queue_worker_base/runner.rb:152:in `block in do_work'
/home/Ladas/Projects/cfme/manageiq/app/models/miq_queue_worker_base/runner.rb:146:in `loop'
/home/Ladas/Projects/cfme/manageiq/app/models/miq_queue_worker_base/runner.rb:146:in `do_work'
/home/Ladas/Projects/cfme/manageiq/app/models/miq_worker/runner.rb:334:in `block in do_work_loop'
/home/Ladas/Projects/cfme/manageiq/app/models/miq_worker/runner.rb:331:in `loop'
/home/Ladas/Projects/cfme/manageiq/app/models/miq_worker/runner.rb:331:in `do_work_loop'
/home/Ladas/Projects/cfme/manageiq/app/models/miq_worker/runner.rb:153:in `run'
/home/Ladas/Projects/cfme/manageiq/app/models/miq_worker/runner.rb:128:in `start'
/home/Ladas/Projects/cfme/manageiq/app/models/miq_worker/runner.rb:21:in `start_worker'
/home/Ladas/Projects/cfme/manageiq/app/models/miq_worker.rb:346:in `block in start'
/home/Ladas/.rvm/gems/ruby-2.2.3/gems/nakayoshi_fork-0.0.3/lib/nakayoshi_fork.rb:24:in `fork'
/home/Ladas/.rvm/gems/ruby-2.2.3/gems/nakayoshi_fork-0.0.3/lib/nakayoshi_fork.rb:24:in `fork'
/home/Ladas/Projects/cfme/manageiq/app/models/miq_worker.rb:344:in `start'
/home/Ladas/Projects/cfme/manageiq/app/models/miq_worker.rb:274:in `start_worker'
/home/Ladas/Projects/cfme/manageiq/app/models/miq_worker.rb:154:in `block in sync_workers'
/home/Ladas/Projects/cfme/manageiq/app/models/miq_worker.rb:154:in `times'
/home/Ladas/Projects/cfme/manageiq/app/models/miq_worker.rb:154:in `sync_workers'
/home/Ladas/Projects/cfme/manageiq/app/models/miq_server/worker_management/monitor.rb:52:in `block in sync_workers'
/home/Ladas/Projects/cfme/manageiq/app/models/miq_server/worker_management/monitor.rb:50:in `each'
/home/Ladas/Projects/cfme/manageiq/app/models/miq_server/worker_management/monitor.rb:50:in `sync_workers'
/home/Ladas/Projects/cfme/manageiq/app/models/miq_server.rb:173:in `start'
/home/Ladas/Projects/cfme/manageiq/app/models/miq_server.rb:264:in `start'
/home/Ladas/Projects/cfme/manageiq/lib/workers/evm_server.rb:65:in `start'
/home/Ladas/Projects/cfme/manageiq/lib/workers/evm_server.rb:92:in `start'
/home/Ladas/Projects/cfme/manageiq/lib/workers/bin/evm_server.rb:4:in `<main>'
[----] I, [2016-05-13T16:07:48.613106 #6492:32d994]  INFO -- : Q-task_id([agent_job_state_1463148463]) MIQ(MiqQueue#delivered) Message id: [14861], State: [error], Delivered in [0.003717985] seconds
[----] I, [2016-05-13T16:07:48.901982 #6487:32d994]  INFO -- : Q-task_id([944aeb44-1913-11e6-9cfb-3c970e7e4812]) MIQ(MiqQueue#delivered) Message id: [14857], State: [ok], Delivered in [0.700910742] seconds
[----] I, [2016-05-13T16:07:51.326657 #6519:32d994]  INFO -- : MIQ(MiqScheduleWorker::Runner#do_work) Number of scheduled items to be processed: 6.
[----] I, [2016-05-13T16:07:51.372917 #6519:32d994]  INFO -- : MIQ(MiqQueue.put) Message id: [14862],  id: [], Zone: [default], Role: [], Server: [c7c59304-6ce1-11e5-a02b-3c970e7e4812], Ident: [generic], Target id: [], Instance id: [], Task id: [], Command: [VmdbDatabaseConnection.log_statistics], Timeout: [600], Priority: [90], State: [ready], Deliver On: [], Data: [], Args: []

EDIT @fryguy: Logs are so much easier to read in code blocks :)

@gmcculloug have you ever seen this?

@roliveri Please review

That looks like a MiqQueue error, not specific to smartstate per se.

@roliveri if it is platform issues with MiqQueue, please discuss with @gtanzillo

FYI @roliveri I see them in my log doing HyperV SSA as well.

It appears to be happening in Job.rb, in the agent_state_update method. It seems to be failing in the call to:
update_attributes(:agent_state => agent_state, :agent_message => agent_message)`

It must mean we're passing something other than a string as agent_state or agent_message.
Ultimately,  agent_state_update is called through the update_agent_state method of the ScanningMixin module. All of the calls to update_agent_state pass strings for agent_state and agent_message, except one:
In  the ScanningMixin module, the scan_via_miq_vm method contains the following line:
xml = extractor.extract(c) { |scan_data| update_agent_state(ost, "Scanning", scan_data[:msg]) }

In this context, scan_data appears to be of type ScanItemBase, which doesn't appear to implement [], so I'm not yet sure of what's exactly going on.
We'll probably have to instrument the code to help determine what's happening.

The problem comes from https://github.com/ManageIQ/manageiq/blob/master/app/models/job.rb#L61:
    job = Job.where("guid = ?", jobid).select("id, state, guid").first
    unless job.nil?
      job.agent_state_update(state, message)

The result selection is only a view of original Job record in DB and cannot be updated. It can be updated only on the whole record, like:
    job = Job.where("guid = ?", jobid).first

Not sure whether this is a new introduced limitation on rails 5 or not

@Fryguy Maybe you can help me here. The above comment explains the issue. Now we cannot create job instance from select query and use it to update record in DB anymore. I tried both:
  job = Job.where("guid = ?", jobid).select("id, state, guid").first

and
job = Job.where("guid = ?", jobid).select("id, state, guid, agent_state, agent_message").first

They all fail when calling agent_state_update(state, message) to update two fields agent_state and agent_message in the DB. But this logic works before. Is it possible the latest Rails add this limitation?

@Fryguy To summarize Hui's findings:
calling:
update_attributes(:agent_state => agent_state, :agent_message => agent_message)`

For a sparsely populated model object job where:
job = Job.where("guid = ?", jobid).select("id, state, guid").first

results in failure. Even adding the attributes in question, results in failure:
job = Job.where("guid = ?", jobid).select("id, state, guid, agent_state, agent_message").first

but using a fully populated Job object works.

@Fryguy I think we can and should work around this in our SSA code, for now.
However, if this is the result of a change in Rails, it may have introduced other bugs that we haven't found yet.
We need to determine if this new Rails behavior is intentional, or a bug. Agreed?

@roliveri @Fryguy I'm trying to recreate this in a unit test that we can try to figure out what's happening in rails 5.

Ok, I simplified the test case to this:
describe Job do
  it "blah" do
    vm = FactoryGirl.create(:vm_vmware)
    vm = Vm.where(:id => vm.id).select("name", "miq_group_id, tenant_id, location, vendor, ems_id").first
    vm.update_attributes(:ems_id => 2)
  end
end

Raises the same error:
  1) Job blah
     Failure/Error: vm.update_attributes(:ems_id => 2)

     NotImplementedError:
       NotImplementedError
     # /Users/joerafaniello/.gem/ruby/2.2.5/bundler/gems/rails-3d01d00e348f/activerecord/lib/active_record/attribute.rb:84:in `type_cast'
     # /Users/joerafaniello/.gem/ruby/2.2.5/bundler/gems/rails-3d01d00e348f/activerecord/lib/active_record/attribute.rb:46:in `original_value'
     # /Users/joerafaniello/.gem/ruby/2.2.5/bundler/gems/rails-3d01d00e348f/activerecord/lib/active_record/attribute.rb:44:in `original_value'
     # /Users/joerafaniello/.gem/ruby/2.2.5/bundler/gems/rails-3d01d00e348f/activerecord/lib/active_record/attribute.rb:123:in `changed_from_assignment?'
     # /Users/joerafaniello/.gem/ruby/2.2.5/bundler/gems/rails-3d01d00e348f/activerecord/lib/active_record/attribute.rb:55:in `changed?'
     # /Users/joerafaniello/.gem/ruby/2.2.5/bundler/gems/rails-3d01d00e348f/activerecord/lib/active_record/attribute_mutation_tracker.rb:27:in `changed?'
     # /Users/joerafaniello/.gem/ruby/2.2.5/bundler/gems/rails-3d01d00e348f/activerecord/lib/active_record/attribute_mutation_tracker.rb:11:in `block in changed_values'
     # /Users/joerafaniello/.gem/ruby/2.2.5/bundler/gems/rails-3d01d00e348f/activerecord/lib/active_record/attribute_mutation_tracker.rb:9:in `each'
     # /Users/joerafaniello/.gem/ruby/2.2.5/bundler/gems/rails-3d01d00e348f/activerecord/lib/active_record/attribute_mutation_tracker.rb:9:in `each_with_object'
     # /Users/joerafaniello/.gem/ruby/2.2.5/bundler/gems/rails-3d01d00e348f/activerecord/lib/active_record/attribute_mutation_tracker.rb:9:in `changed_values'
     # /Users/joerafaniello/.gem/ruby/2.2.5/bundler/gems/rails-3d01d00e348f/activerecord/lib/active_record/attribute_methods/dirty.rb:83:in `changed_attributes'
     # /Users/joerafaniello/.gem/ruby/2.2.5/bundler/gems/rails-3d01d00e348f/activemodel/lib/active_model/dirty.rb:146:in `changed'
     # /Users/joerafaniello/.gem/ruby/2.2.5/bundler/gems/rails-3d01d00e348f/activerecord/lib/active_record/attribute_methods/dirty.rb:127:in `keys_for_partial_write'
     # /Users/joerafaniello/.gem/ruby/2.2.5/bundler/gems/rails-3d01d00e348f/activerecord/lib/active_record/attribute_methods/dirty.rb:119:in `_update_record'
     # /Users/joerafaniello/.gem/ruby/2.2.5/bundler/gems/rails-3d01d00e348f/activerecord/lib/active_record/callbacks.rb:306:in `block in _update_record'
     # /Users/joerafaniello/.gem/ruby/2.2.5/bundler/gems/rails-3d01d00e348f/activesupport/lib/active_support/callbacks.rb:126:in `call'
     # /Users/joerafaniello/.gem/ruby/2.2.5/bundler/gems/rails-3d01d00e348f/activesupport/lib/active_support/callbacks.rb:126:in `call'
     # /Users/joerafaniello/.gem/ruby/2.2.5/bundler/gems/rails-3d01d00e348f/activesupport/lib/active_support/callbacks.rb:506:in `block (2 levels) in compile'
     # /Users/joerafaniello/.gem/ruby/2.2.5/bundler/gems/rails-3d01d00e348f/activesupport/lib/active_support/callbacks.rb:455:in `call'
     # /Users/joerafaniello/.gem/ruby/2.2.5/bundler/gems/rails-3d01d00e348f/activesupport/lib/active_support/callbacks.rb:455:in `call'
     # /Users/joerafaniello/.gem/ruby/2.2.5/bundler/gems/rails-3d01d00e348f/activesupport/lib/active_support/callbacks.rb:101:in `__run_callbacks__'
     # /Users/joerafaniello/.gem/ruby/2.2.5/bundler/gems/rails-3d01d00e348f/activesupport/lib/active_support/callbacks.rb:750:in `_run_update_callbacks'
     # /Users/joerafaniello/.gem/ruby/2.2.5/bundler/gems/rails-3d01d00e348f/activerecord/lib/active_record/callbacks.rb:306:in `_update_record'
     # /Users/joerafaniello/.gem/ruby/2.2.5/bundler/gems/rails-3d01d00e348f/activerecord/lib/active_record/timestamp.rb:81:in `_update_record'
     # /Users/joerafaniello/.gem/ruby/2.2.5/bundler/gems/rails-3d01d00e348f/activerecord/lib/active_record/persistence.rb:534:in `create_or_update'
     # /Users/joerafaniello/.gem/ruby/2.2.5/bundler/gems/rails-3d01d00e348f/activerecord/lib/active_record/callbacks.rb:298:in `block in create_or_update'
     # /Users/joerafaniello/.gem/ruby/2.2.5/bundler/gems/rails-3d01d00e348f/activesupport/lib/active_support/callbacks.rb:126:in `call'
     # /Users/joerafaniello/.gem/ruby/2.2.5/bundler/gems/rails-3d01d00e348f/activesupport/lib/active_support/callbacks.rb:126:in `call'
     # /Users/joerafaniello/.gem/ruby/2.2.5/bundler/gems/rails-3d01d00e348f/activesupport/lib/active_support/callbacks.rb:506:in `block (2 levels) in compile'
     # /Users/joerafaniello/.gem/ruby/2.2.5/bundler/gems/rails-3d01d00e348f/activesupport/lib/active_support/callbacks.rb:455:in `call'
     # /Users/joerafaniello/.gem/ruby/2.2.5/bundler/gems/rails-3d01d00e348f/activesupport/lib/active_support/callbacks.rb:455:in `call'
     # /Users/joerafaniello/.gem/ruby/2.2.5/bundler/gems/rails-3d01d00e348f/activesupport/lib/active_support/callbacks.rb:101:in `__run_callbacks__'
     # /Users/joerafaniello/.gem/ruby/2.2.5/bundler/gems/rails-3d01d00e348f/activesupport/lib/active_support/callbacks.rb:750:in `_run_save_callbacks'
     # /Users/joerafaniello/.gem/ruby/2.2.5/bundler/gems/rails-3d01d00e348f/activerecord/lib/active_record/callbacks.rb:298:in `create_or_update'
     # /Users/joerafaniello/.gem/ruby/2.2.5/bundler/gems/rails-3d01d00e348f/activerecord/lib/active_record/persistence.rb:125:in `save'
     # /Users/joerafaniello/.gem/ruby/2.2.5/bundler/gems/rails-3d01d00e348f/activerecord/lib/active_record/validations.rb:44:in `save'
     # /Users/joerafaniello/.gem/ruby/2.2.5/bundler/gems/rails-3d01d00e348f/activerecord/lib/active_record/attribute_methods/dirty.rb:22:in `save'
     # /Users/joerafaniello/.gem/ruby/2.2.5/bundler/gems/rails-3d01d00e348f/activerecord/lib/active_record/transactions.rb:319:in `block (2 levels) in save'
     # /Users/joerafaniello/.gem/ruby/2.2.5/bundler/gems/rails-3d01d00e348f/activerecord/lib/active_record/transactions.rb:395:in `block in with_transaction_returning_status'
     # /Users/joerafaniello/.gem/ruby/2.2.5/bundler/gems/rails-3d01d00e348f/activerecord/lib/active_record/connection_adapters/abstract/database_statements.rb:230:in `transaction'
     # /Users/joerafaniello/.gem/ruby/2.2.5/bundler/gems/rails-3d01d00e348f/activerecord/lib/active_record/transactions.rb:211:in `transaction'
     # /Users/joerafaniello/.gem/ruby/2.2.5/bundler/gems/rails-3d01d00e348f/activerecord/lib/active_record/transactions.rb:392:in `with_transaction_returning_status'
     # /Users/joerafaniello/.gem/ruby/2.2.5/bundler/gems/rails-3d01d00e348f/activerecord/lib/active_record/transactions.rb:319:in `block in save'
     # /Users/joerafaniello/.gem/ruby/2.2.5/bundler/gems/rails-3d01d00e348f/activerecord/lib/active_record/transactions.rb:334:in `rollback_active_record_state!'
     # /Users/joerafaniello/.gem/ruby/2.2.5/bundler/gems/rails-3d01d00e348f/activerecord/lib/active_record/transactions.rb:318:in `save'
     # /Users/joerafaniello/.gem/ruby/2.2.5/bundler/gems/rails-3d01d00e348f/activerecord/lib/active_record/suppressor.rb:41:in `save'
     # /Users/joerafaniello/.gem/ruby/2.2.5/bundler/gems/rails-3d01d00e348f/activerecord/lib/active_record/persistence.rb:266:in `block in update'
     # /Users/joerafaniello/.gem/ruby/2.2.5/bundler/gems/rails-3d01d00e348f/activerecord/lib/active_record/transactions.rb:395:in `block in with_transaction_returning_status'
     # /Users/joerafaniello/.gem/ruby/2.2.5/bundler/gems/rails-3d01d00e348f/activerecord/lib/active_record/connection_adapters/abstract/database_statements.rb:232:in `block in transaction'
     # /Users/joerafaniello/.gem/ruby/2.2.5/bundler/gems/rails-3d01d00e348f/activerecord/lib/active_record/connection_adapters/abstract/transaction.rb:189:in `within_new_transaction'
     # /Users/joerafaniello/.gem/ruby/2.2.5/bundler/gems/rails-3d01d00e348f/activerecord/lib/active_record/connection_adapters/abstract/database_statements.rb:232:in `transaction'
     # /Users/joerafaniello/.gem/ruby/2.2.5/bundler/gems/rails-3d01d00e348f/activerecord/lib/active_record/transactions.rb:211:in `transaction'
     # /Users/joerafaniello/.gem/ruby/2.2.5/bundler/gems/rails-3d01d00e348f/activerecord/lib/active_record/transactions.rb:392:in `with_transaction_returning_status'
     # /Users/joerafaniello/.gem/ruby/2.2.5/bundler/gems/rails-3d01d00e348f/activerecord/lib/active_record/persistence.rb:264:in `update'
     # ./spec/models/job_spec.rb:5:in `block (2 levels) in <top (required)>'
     # /Users/joerafaniello/.gem/ruby/2.2.5/gems/bundler-1.12.5/lib/bundler/cli/exec.rb:63:in `load'
     # /Users/joerafaniello/.gem/ruby/2.2.5/gems/bundler-1.12.5/lib/bundler/cli/exec.rb:63:in `kernel_load'
     # /Users/joerafaniello/.gem/ruby/2.2.5/gems/bundler-1.12.5/lib/bundler/cli/exec.rb:24:in `run'
     # /Users/joerafaniello/.gem/ruby/2.2.5/gems/bundler-1.12.5/lib/bundler/cli.rb:304:in `exec'
     # /Users/joerafaniello/.gem/ruby/2.2.5/gems/bundler-1.12.5/lib/bundler/cli.rb:11:in `start'
     # /Users/joerafaniello/.gem/ruby/2.2.5/gems/bundler-1.12.5/exe/bundle:27:in `block in <top (required)>'
     # /Users/joerafaniello/.gem/ruby/2.2.5/gems/bundler-1.12.5/lib/bundler/friendly_errors.rb:98:in `with_friendly_errors'
     # /Users/joerafaniello/.gem/ruby/2.2.5/gems/bundler-1.12.5/exe/bundle:19:in `<top (required)>'

From puts debugging, even if we add ems_id to the select, I'm seeing it's calling changed? on updated_on:
["id", "ems_id", "miq_group_id", "tenant_id", "name", "location", "vendor", "updated_on"]

@jrafanie Can you bisect down to what columns are required?  I'm wondering if it's something to do with AR callbacks needing a particular column.

https://gist.github.com/jrafanie/1b8d1c40eb9976840801443b70d8f92c

https://github.com/rails/rails/issues/25228

Fixed via https://github.com/rails/rails/commit/c587b636648394e33292ba8ba47d22bdad7446c3


Remove errant space

Hi @SLaks, thanks for the pull request. Before we can merge it, we need you to sign our Contributor License Agreement. You can do so electronically here: http://opensource.box.com/cla
Once you have signed, just add a comment to this pull request saying, "CLA signed". Thanks!

Thanks! We can forego the CLA since this is just a documentation change (although you're still welcome to sign it for later contributions).


License?

I cannot find a license anywhere in this project. As I understand it, the "fallback" is that a project with no license is not allowed to be used, changed or distributed by anyone (https://choosealicense.com/no-permission).
Request: Add an explicit license to the project.

@edespong a bit late but I added one :)


error in RNA report on test data: cannot open the connection

Ran RENEE v2.5.9 from the GUI on the test data:
Process errored here:
Error in file(con, "w") : cannot open the connection
Calls: <Anonymous> -> <Anonymous> -> write_utf8 -> writeLines -> file
In addition: There were 16 warnings (use warnings() to see them)
Execution halted
[Fri Jan  5 12:31:59 2024]
Error in rule rna_report:
    jobid: 0
    input: /data/sevillas2/RENEE/2.5.9_v1/DEG_ALL/RSEM.genes.expected_counts.all_samples.reformatted.tsv, /data/sevillas2/RENEE/2.5.9_v1/DEG_ALL/combined_TIN.tsv, /data/sevillas2/RENEE/2.5.9_v1/Reports/multiqc_matrix.tsv
    output: /data/sevillas2/RENEE/2.5.9_v1/Reports/RNA_Report.html
    shell:

    # Avoids inheriting $R_LIBS_SITE
    # from local env variables
    R_LIBS_SITE=/usr/local/lib/R/site-library
    # Generate RNA QC Dashboard
    workflow/scripts/rNA.R         -m workflow/scripts/rNA_flowcells.Rmd         -r /data/sevillas2/RENEE/2.5.9_v1/DEG_ALL/RSEM.genes.expected_counts.all_samples.reformatted.tsv         -t /data/sevillas2/RENEE/2.5.9_v1/DEG_ALL/combined_TIN.tsv         -q /data/sevillas2/RENEE/2.5.9_v1/Reports/multiqc_matrix.tsv         -o /data/sevillas2/RENEE/2.5.9_v1/Reports         -f RNA_Report.html

Process completed with all steps except for writing the output report:
...
label: loadings-heatmap (with options)
List of 2
 $ dpi       : num 300
 $ fig.height: num 6

  |..................................................................... |  98%
   inline R code fragments

  |......................................................................| 100%
label: session-info

Tested in R-Studio and was able to knit the report without an error.

Tested on the command line with '--mode local' and got the same error listed above.

Oddly, this fails for you, Vishal, and others, but works for me with v2.5.10.

Found a similar error: https://github.com/boxuancui/DataExplorer/issues/20
It appears because I don't have write permission to the R library location, that invocation of the rule fails to create the knit files. All of the fixes I've tried so far haven't worked though. I'm still only able to create it within R studio but cannot create it using Snakemake or just calling the R file directly.

The /output/dir/workflow directory is being set to 'read-only' by RENEE at some point. This is causing the creation of the 'knit.md' file to be unable to save and causing the pipeline to fail at this rule. I am going to test with a clean pull of the repo to ensure this fixes the issue

We need to add a line to change the permissions of the output Rmd subdir after copying it

Running test to ensure this is working with current main branch
./renee run --input .tests/*.gz --output /data/sevillas2/renee_2.5.11/ --genome hg38_30 --mode slurm

Running test to ensure this is working with current main branch
./renee run --input .tests/*.gz --output /data/sevillas2/renee_2.5.11/ --genome hg38_30 --mode slurm

Will this work on the main branch when we haven't merged #91 yet?


Email hash may not be ever displayed in account header

Email hash may not be ever shown in account header.
Props declares email hash as snake case in AccountHeader. But inside formatAccountInfo, email hash is returned in camelcase.
Worth looking in having test cases

To add an emailHash feature to the AccountHeader component, we can add a new emailHash property to the data object and define its type in the propTypes.


Vorbis error: Library error: vorbisfile error calling ov_open_callbacks: OV_ENOTVORBIS

Bug description
assets/minecraft/sounds/welcome.ogg: Vorbis error: Library error: vorbisfile error calling ov_open_callbacks: OV_ENOTVORBIS: not Vorbis data
Reproduction steps
try to compress a .ogg file
Expected behavior
no errors
Workflow logs
No response
Attached files or repository
No response
Additional context
No response

Hi, thanks for reporting the issue. Have you double checked that the assets/minecraft/sounds/welcome.ogg file on your pack is truly an audio file in the Ogg Vorbis format? PackSquash only supports those, as Minecraft: Java Edition does. You can check by using external tools like this.


MMWormhole not receiving messages when the app is launched from glance

The library works fine in the main watch application with WatchOS 2. When you go on the application glance and after you tap on the glance to return in the application, MMWormdhole don't receive any message from the iPhone (iOS 9). it's necessary to make a force touch to show the application menu and after, quit the menu to reactivate MMWormhole. After that, it works fine.
This problem exists only on the watch. There is no problem on the simulator.
Any ideas of the problem ?

I've heard about a WatchConnectivity issue that sounds very similar to this. I'm betting this is the root cause. If it is, I'm not sure what we'll be able to do to fix it without an iOS update :(
https://forums.developer.apple.com/thread/14740

I'm facing some issues. Kindly answer me to fix the issue. On iPhone app side I'm using this
let wormhole : MMWormhole = MMWormhole(applicationGroupIdentifier: "group.com.xyz", optionalDirectory: "ProjectDataDict")
wormhole.passMessageObject("message recieved or not?", identifier: "ProjectData")
Just this code on iPhone side no. And on swift side I am doing this
wormhole = MMWormhole(applicationGroupIdentifier: "group.com.xyz", optionalDirectory: "ProjectDataDict")
let messageObj = wormhole.messageWithIdentifier("ProjectData")
But it is not giving me any message. Kindly tell me the issue. . .

1 more thing If i send message can i get the same message after 1 hour or so or it will pass that message just for this time ?
Your reply will give me much hope Man!

I guess I can close this now, since glances were ultimately removed.


tests: add a scrip to create mock JSON responses

Fixes osbs-3533
Add a python script to capture and edit standard commands to turn
them into mock JSON responses needed by the test infrastructure.
Signed-off-by: Mark Langsdorf<EMAIL_ADDRESS>

I couldn't figure out the syntax for image streams.

looks good so far
still missing
create_buildconfig
imagestream
imagestreamimport

fixed created_buildconfig, still need to figure out imagestream.

Aside from the lint error that I do not know how to resolve, this seems to be complete to me.

Minor nit: first commit message says "scrip" instead of "script"

Not adding anything to release notes since this is an internal test change.


Add some general-purpose path utilities from swift-driver

This moves a couple general purpose path utilities from swift-driver to TSC

array-accepting overloads of appending(components:), to make composition easier
basenameWithoutExt for RelativePath in addition to AbsolutePath

@swift-ci please test


Swerve drive integration

@redPlover @FujiBookPro if there's a meeting before next Monday (if the CANCoders arrive), please work off of this branch to get the swerve drive running. @AlexEvergarden can help with this since this is the branch he's started

I found some inconsistencies with how we define our swerve module placement (spiral vs. book); I tried to standardize that completely. I also added TODOs around different places to look at as possible failure points for Wednesday.

@jkleiber I will unfortunately be late today (7pm). I have caught @FujiBookPro on the updates during lunch today.

@redPlover sounds good, I'll try to get there to support at 5pm or a bit after

swerve drive works now, creating a new PR to give @AlexEvergarden credit


Update jackson-databind to 2.17.2

About this PR
📦 Updates com.fasterxml.jackson.core:jackson-databind from 2.17.1 to 2.17.2
Usage
✅ Please merge!
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

⚙ Adjust future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "com.fasterxml.jackson.core", artifactId = "jackson-databind" } ]

Or, add this to slow down future updates of this dependency:
dependencyOverrides = [{
  pullRequests = { frequency = "30 days" },
  dependency = { groupId = "com.fasterxml.jackson.core", artifactId = "jackson-databind" }
}]

labels: library-update, early-semver-patch, semver-spec-patch, commit-count:1

Superseded by #125.


Test wagmi compatibility of chains

https://github.com/api3dao/chains/issues/84 has the package export chains formatted as objects that wagmi recognizes. However, we don't want to do this for chains on which wagmi doesn't work (for whatever reason). See https://github.com/api3dao/chains/pull/85#issuecomment-1728080999 for more information.
Ideally, we would have end to end tests somewhere that confirms that wagmi works with the exported object. I'm aware that this would bloat up this repo a lot, but we need it somewhere to avoid replicating in all the other frontend implementations that depend on this.

I can't think of a reason why Viem (Wagmi) wouldn't work with a given chain, other than if we messed up the configuration here somehow. In my understanding, Viem is just a simple interface between your code and the RPC provider (aka an ethers.js replacement). Wagmi is just the layer on top of Viem that provides some nice React hooks.
Currently, the ping providers script does the following for each chain:

Creates a simple Viem HTTP public client
Calls .getChainId() to check that the chain ID in the JSON file is the same as what the RPC provider is reporting
Calls .client.getBlock({ blockTag: 'latest' }) to check the the latest block is still somewhat recently produced

We could try add a .simulateContract() call (same as ethers.js .callStatic) but I'm not sure if this requires the wallet to be funded or not. Maybe each chain is different here too. Not really sure what additional benefit this adds either.
I guess it boils down to what are we really trying to test here. With the current setup we are testing that:

The RPC provider responds to requests
It reports the correct chain ID
The network is still producing blocks

Imo, these are already a pretty good guarantee that the config in this repo is good.


Use :first-child

Use :first-child instead of :nth-child(1)
:first-child == IE7/8
:nth-child == IE9
https://developer.mozilla.org/fr/docs/Web/CSS/:nth-child
https://developer.mozilla.org/fr/docs/Web/CSS/:first-child

This :first-child change will occur on a next release of a better Family.scss.
There is actually no direct mixins that uses :nth-child(1).
To make it happen, I'll use a Sass if/else statement.
Doing this right now may looks weird, since I just released the library.

fixed in 003472a51b7db3e25068c00c63121e78cca96bf2

@LukyVj just a heads-up; I can't seem to find this fix in the latest build (or I am missing it somehow 👍 )

Hey, thanks for the heads up! You're right, I added it in the sass file from the components folder, but I forgot to update the source file.
You can find it here https://github.com/LukyVj/family.scss/blob/master/source/stylesheets/vendors/_family.scss
Updating it now!

Here you go https://github.com/LukyVj/family.scss/blob/master/source/src/family.scss#L5-L16

Awesome, thanks so much!


derive: understand extension .rinja + don't panic if the extension is non-UTF-8

Makes sense, thanks!


Test compilation errors are ignored

When we run yarn test, the compile errors in the tests are discarded.

yarn tsc in run during yarn test 🤯
We need to adjust the GitHub action to run it separately.

/remove-lifecycle stale

/assign


Typo in shortcode-chart-js-plusplus.yaml

there are to much numbers in the hex code color at the default plugin configuration:
#65a0e999
enabled: true
chart:
  backgroundColor: '#65a0e999'
  borderColor: '#65a0e9'
  pointBackgroundColor: '#65a0e9'
  pointBorderColor: '#65a0e9'

#65a0e999 is still a valid hex color code. In this case, 65 is the alpha value.
I don't know where I got that from. Probably somewhere from the chart.js documentation.
Don't know if it's a typo or intended. Without Alpha probably makes more sense. So yeah, I'll change it.
Thanks for your mesage.

If you want transparency it is more easy with RGBA
With Hex its a bit comlicated
The right code Hex would be 66 for 40%, 63 for 39% or 69 for 41% :smirk:
Here you find a overview - gist.github.com

Thanks for the explanation. 👍
Fixed in 14ddd5244e23dc4bc0aacdcada61e023069f95aa


Add orography to ERA-interim cmorizer

Tasks

[x] Create an issue to discuss what you are going to do, if you haven't done so already (and add the link at the bottom)
[x] Give this pull request a descriptive title that can be used as a one line summary in a changelog
[ ] Make sure your code is composed of functions of no more than 50 lines and uses meaningful names for variables
[ ] Circle/CI tests pass. Status can be seen below your pull request. If the tests are failing, click the link to find out why.
[ ] Preferably Codacy code quality checks pass, however a few remaining hard to solve Codacy issues are still acceptable. Status can be seen below your pull request. If there is an error, click the link to find out why. If you suspect Codacy may be wrong, please ask by commenting.
[ ] Please use yamllint to check that your YAML files do not contain mistakes
[ ] (Only if really necessary) Add any additional dependencies needed for the diagnostic script to setup.py, esmvaltool/install/R/r_requirements.txt or esmvaltool/install/Julia/julia_requirements.txt (depending on the language of your script) and also to meta.yaml for conda dependencies (includes Python and others, but not R/Julia)
[ ] If new dependencies are introduced, check that the license is compatible with Apache2.0

Modified data reformatting script

[x] Test the CMORized data using recipes/example/recipe_check_obs.yml, to make sure the CMOR checks pass without errors
[ ] Tag @mattiarighi in this pull request, so that the updated dataset can be added to the OBS data pool at DKRZ and synchronized with CEDA-Jasmin

If you need help with any of the tasks above, please do not hesitate to ask by commenting in the issue or pull request.

Closes ESMValGroup/ESMValTool#1415

recipe_check_obs fails. See: #1418

Last commit message should be "remove from recipe_check_obs", as it didn't exist (anymore) in the cmorizer. Earlier (#1297), tsns was changed to tsn (using tsns was a bug in the first place).

This PR is ready for review @mattiarighi . The recipe_check_obs passes for the new variable orog, but still fails for sftlf. However, part of the sftlf issue is fixed by this PR, see https://github.com/ESMValGroup/ESMValTool/issues/1418#issuecomment-548371808

Last commit message should be "remove from recipe_check_obs", as it didn't exist (anymore) in the cmorizer. Earlier (#1297), tsns was changed to tsn (using tsns was a bug in the first place).

I already fixed this in #1402 which is now merged.


Remove Inactive Users (December 18th+)

Blocked due to dependancies outside of team i.e. waiting for it to be later in December

Removed the following inactive users from GH:
Dana-Crawford
IMA-NickyThomas
ionel95
Mikesanderson-justice-gov-uk
Philco3
Prashanthrn
YudMoJ


icons positioned too high

It looks like the button icons are positioned too high in FF 4.0.
(or is it me?)
Thanks anyway,
Duncan

I only have have firefox 7 now, but I will try to check it.

I just installed firefox 7, however I do see the same positioning as firefox 4.
I think there is a 2 pixel difference with chrome.

Looks ok to me, on win 7.

taken from ff4 and ff7 on ubuntu 11 (but also ff3.6 on ubuntu 10 shows the same behaviour).

So depends on how the font is rendered by the operating system, that's a real bummer.

Hi, can you check the new fonts that I added?

Hi,
I did checkout the updated repo.
On localhost, I see still the 2px difference on firefox.
Also http://lightglitch.github.com/bootstrap-xtra/ shows the 2px difference, did you already update this webpage?

Yes, I did it looks the maintains the same behavior. :(

I think i found the problem for this issue, the size of the icons are a little bigger that the font but the line height it's the same (so that the button didn't get bigger and to align in the middle).
If I put everything with same size I think it solves the problem.
But some icons, like the printer, when they are small don't look so good.
I will try to check it this weekend.


Bump the govuk template to 0.17.2

0.17.2

Fix a bug with the skip-to-content link and iOS Voiceover
Migrate @viewport statement from govuk_frontend_toolkit

https://raw.githubusercontent.com/alphagov/govuk_template/master/CHANGELOG.md

cc. @robinwhittleton


ack: 2.16 -> 2.22

Motivation for this change
Update ack and FileNext to the last versions
Things done

[X] Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
Built on platform(s)

[X] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[X] Tested execution of all binary files (usually in ./result/bin/)
[X] Fits CONTRIBUTING.md.

@GrahamcOfBorg build perlPackages.FileNext perlPackages.ack


How to use shard bin models in tflite

How to use shard bin models in tflite (modal_weight.bin) or how to convert it to .tflite ?

shared BIN is not TFLite, that is regular TFJS.