Router directive: Add setRoot feature

Note: If you are having problems formatting your issue please refer to this article on using markdown in Github:
https://guides.github.com/features/mastering-markdown/
Note: for support questions, please use one of these channels:
https://forum.ionicframework.com/
http://ionicworldwide.herokuapp.com/
Note: for build related issues you can open up an issue on the ionic-app-scripts repo
https://github.com/driftyco/ionic-app-scripts
Short description of the problem:
Request for a setRoot directive, similar to the navPush. As we noticed that when navPush, the pages are stacked in the DOM and what it does is to detach changes however it seems that it's not unsubscribing from Subjects. More over, when having big page this might cause a performance issue.
What behavior are you expecting?
Use setRoot instead of push as we want to destroy the page instead of creating a page on another.
Steps to reproduce:
1.
2.
3.
insert any relevant code between the above and below backticks

Other information: (e.g. stacktraces, related issues, suggestions how to fix, stackoverflow links, forum links, etc)
Which Ionic Version? 1.x or 2.x
Plunker that shows an example of your issue
For Ionic 1 issues - http://plnkr.co/edit/Xo1QyAUx35ny1Xf9ODHx?p=preview
For Ionic 2 issues - http://plnkr.co/edit/me3Uk0GKWVRhZWU0usad?p=preview
Run ionic info from terminal/cmd prompt: (paste output below)

Hello all! While this is an awesome feature request it is not something that we plan on doing anytime soon. Because of this I am going to move this to our internal feature tracking repo for now as it is just "collecting dust" here. Once we decide to implement this I will move it back. Thanks everyone for using Ionic!

This issue was moved to driftyco/ionic-feature-requests#71


testing/quick: float64 values generated by quick seems to be always with either 307 or 308 as the exponent

What version of Go are you using (go version)?

$ go version
go version go1.16.4 linux/amd64

Does this issue reproduce with the latest release?
Yes
What operating system and processor architecture are you using (go env)?
go env Output
$ go env | grep -v GOPRIVATE
GO111MODULE=""
GOARCH="amd64"
GOBIN=""
GOCACHE="/home/fishy/.cache/go-build"
GOENV="/home/fishy/.config/go/env"
GOEXE=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GOINSECURE=""
GOMODCACHE="/home/fishy/.gopath/pkg/mod"
GONOPROXY="github.snooguts.net"
GONOSUMDB="github.snooguts.net"
GOOS="linux"
GOPATH="/home/fishy/.gopath"
GOPROXY="https://proxy.golang.org,direct"
GOROOT="/usr/local/go"
GOSUMDB="sum.golang.org"
GOTMPDIR=""
GOTOOLDIR="/usr/local/go/pkg/tool/linux_amd64"
GOVCS=""
GOVERSION="go1.16.4"
GCCGO="gccgo"
AR="ar"
CC="gcc"
CXX="g++"
CGO_ENABLED="1"
GOMOD="/dev/null"
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build745604388=/tmp/go-build -gno-record-gcc-switches"

What did you do?
for this simple code (also on https://play.golang.org/p/kDpslSUu9TU):
package main

import (
	"fmt"
	"testing/quick"
)

func main() {
	f := func(f float64) bool {
		fmt.Println(f)
		return true
	}
	quick.Check(f, nil)
}

This is a sample run result:
sample run result
-8.969297190834214e+307
-7.831502607950853e+307
-1.017836961875757e+308
-1.3535751487940019e+308
-1.0076771554548313e+308
1.5997952344730588e+308
8.781329881346274e+307
-1.3977246332351983e+308
-1.751345981843834e+308
-9.631105926402765e+307
5.030474460950956e+307
3.876000984935831e+307
-1.1535064513352566e+308
1.3875544571022683e+308
-4.648007116071519e+307
7.188399232752114e+307
-1.3574878601546032e+308
1.261589184475622e+308
-1.6771816056107048e+308
-2.42151768274873e+307
1.1920696411173799e+308
-1.3300938482110913e+308
-4.086526852707076e+306
1.5138365057324555e+308
-1.7831898065982803e+308
-1.5282247902123299e+308
2.74415810998631e+307
-7.700957625830366e+307
-6.025008154543404e+307
-9.018143289448598e+307
1.7196416203371837e+308
4.437871976111745e+307
5.198598612029313e+307
1.2541837395241708e+308
-1.8320076381127488e+307
-6.794426608480807e+307
1.3939903945166529e+308
6.255768911187045e+306
-1.4041471148240002e+308
-1.0247217122729754e+307
1.0562505691933051e+308
-9.862600142373213e+307
-1.9262745415816453e+307
1.1526780768769353e+308
1.163069460741152e+308
-1.636561386523683e+308
4.2476422348216977e+307
1.4410000066850539e+308
2.860856778503435e+307
-1.5866460164755353e+308
1.6503501024802302e+308
5.426324032221941e+307
-3.603715626519023e+307
1.323903837439158e+308
5.0449013048191815e+305
9.551754924809232e+307
-1.0543348710831613e+308
-1.642940515370404e+306
1.4550744333101965e+308
8.182620662559106e+307
-8.922210718825109e+307
9.040087837966524e+307
-5.36823685782382e+307
-4.802679973452924e+307
-1.3546873332103518e+308
1.2611247332949247e+307
1.6504146962965598e+308
8.925768707654734e+307
6.060864720400443e+307
1.1301702437308016e+308
6.105902625074679e+307
-1.674967049759634e+308
8.745158550227989e+307
1.1208811120768472e+307
-1.2102992440400202e+308
1.0776478306055392e+308
5.628120988763797e+307
-1.4407082690504483e+308
4.193133448091252e+307
-5.794148903093446e+307
1.5698645197590104e+307
9.859992431318722e+307
-9.178064834795386e+307
-1.5420679636315293e+308
-1.617161482409336e+308
1.460437073524614e+308
2.8185445872762836e+306
-5.367650929597339e+306
9.609881583583266e+307
5.657253317822904e+307
-1.5686427694906407e+308
-6.783812982876687e+307
4.375877840364708e+307
1.7149998628682812e+308
-3.099088507108448e+307
-1.679346515941985e+308
1.7124637777922935e+308
1.783875652982286e+307
-1.4394015012167398e+308
1.6758357523528137e+308

As you can see from the sample result, every single one of them are either e+307 or e+308. I've noticed this from several different runs, from both local and go playground.
What did you expect to see?
Something more random? I'm not sure if this is something "expected"/"intended", or a bug.
What did you see instead?

If you run quick.Check in a loop, within a reasonable amount of time the range is between +300 and +308
e.g. https://play.golang.org/p/7jArGyIlWjk (do not run in playground due to timeouts)

testing/quick generates float64 values as
rand.Float64() * math.MaxFloat64

which of course is heavily biased towards big numbers.
0.06 * math.MaxFloat64 already has e+307 as the exponent, so in practise you only have a ~4% chance to see a number with exponent less than 306.
That's not a great way to generate random ieee-754 floats, but the testing/quick package is frozen:

The testing/quick package is frozen and is not accepting new features.

so I don't think this will be changed.

testing/quick generates float64 values as
rand.Float64() * math.MaxFloat64

which of course is heavily biased towards big numbers (because ieee-754 numbers are not uniformly spaced).
0.06 * math.MaxFloat64 already has e+307 as the exponent, so in practice you only have a ~4% chance to see a number with exponent less than 307.
That's not a great way to generate random ieee-754 floats (precisely due to this bias towards big exponents), but the testing/quick package is frozen:

The testing/quick package is frozen and is not accepting new features.

so I don't think this will be changed.

Thanks! Yes I think that explained it.
So 1e309 is actually larger than math.MaxFloat64, and 1e307 / math.MaxFloat64 is roughly 0.05562684646268004, so indeed there's only less than 6% chance random float64 generated this way has an exponent less than 307.
Feel free to close this issue.


Removed unmentioned fields from query on line 33

[x] I have read freeCodeCamp's contribution guidelines.
[x] My pull request has a descriptive title (not a vague title like Update index.md)
[x] My pull request targets the master branch of freeCodeCamp.
[x] None of my changes are plagiarized from another source without proper attribution.
[x] My article does not contain shortened URLs or affiliate links.

If your pull request closes a GitHub issue, replace the XXXXX below with the issue number.
Closes #XXXXX

@FTarfasse Awesome! Thanks! Congrats on your first open source contribution to this repository!


Time attribute missing from .LAS format

Hello,
I am trying to convert .LAS point clouds with Time attribute to .LAS potree, however, I don't seem to find a way to access that info.  Could you please support? Thanks!

What can I do to add this functionality?


GPSLatitude and GPSLongitude values don't appear to be correct

The values for the GPSLatitude and GPSLongitude attributes, don't seem valid.
The values for both of attributes are expressed in the form of "deg min sec", each of which is a rational.
The deg value for both appears to be correct, however, the min and sec values are giving me a 6-digit number, over 0 (e.g. 111111/0).

Just for reference, the min and sec values should always be within 0 and 59 (inclusive).

Okay, so, as it turns out, the values that the getAttributeValue function captures, are correct. I just have a problem with a pointer somewhere.

As of https://github.com/Gigabyte-Giant/JPEG-Meta-Extractor/commit/ce20d6624c9e4f20e7773178d77e2d25624c92df, this has been fixed.


Unstable test test_split_region::test_report_approximate_size_after_split_check

Bug Report
in ci https://ci.pingcap.net/blue/organizations/jenkins/tikv_ghpr_test/detail/tikv_ghpr_test/3549/pipeline

What version of TiKV are you using?

master
What operating system and CPU are you using?

Steps to reproduce

What did you expect?
What did happened?

also in https://ci.pingcap.net/blue/organizations/jenkins/tikv_ghpr_test/detail/tikv_ghpr_test/3538/pipeline

[2021-07-03T14:22:15.397Z] 0: <test_raftstore::util::CallbackLeakDetector as core::ops::drop::Drop>::drop

[2021-07-03T14:22:15.397Z]           at components/test_raftstore/src/util.rs:378

[2021-07-03T14:22:15.397Z] 1: core::ptr::drop_in_place<test_raftstore::util::CallbackLeakDetector>

[2021-07-03T14:22:15.397Z]           at /rustc/16bf626a31cb5b121d0bca2baa969b4f67eb0dab/library/core/src/ptr/mod.rs:192

[2021-07-03T14:22:15.397Z] 2: core::ptr::drop_in_place<test_raftstore::util::make_cb::{{closure}}>

[2021-07-03T14:22:15.397Z]           at /rustc/16bf626a31cb5b121d0bca2baa969b4f67eb0dab/library/core/src/ptr/mod.rs:192

[2021-07-03T14:22:15.397Z] 3: core::ptr::drop_in_place<alloc::boxed::Box<dyn core::ops::function::FnOnce<(raftstore::store::msg::WriteResponse,)>+Output = ()+core::marker::Send>>

[2021-07-03T14:22:15.397Z]           at /rustc/16bf626a31cb5b121d0bca2baa969b4f67eb0dab/library/core/src/ptr/mod.rs:192

[2021-07-03T14:22:15.397Z] 4: core::ptr::drop_in_place<raftstore::store::msg::Callback<engine_rocks::snapshot::RocksSnapshot>>

[2021-07-03T14:22:15.397Z]           at /rustc/16bf626a31cb5b121d0bca2baa969b4f67eb0dab/library/core/src/ptr/mod.rs:192

[2021-07-03T14:22:15.397Z] 5: core::ptr::drop_in_place<raftstore::store::fsm::apply::Proposal<engine_rocks::snapshot::RocksSnapshot>>

[2021-07-03T14:22:15.397Z]           at /rustc/16bf626a31cb5b121d0bca2baa969b4f67eb0dab/library/core/src/ptr/mod.rs:192

[2021-07-03T14:22:15.397Z] 6: core::ptr::drop_in_place<[raftstore::store::fsm::apply::Proposal<engine_rocks::snapshot::RocksSnapshot>]>

[2021-07-03T14:22:15.397Z]           at /rustc/16bf626a31cb5b121d0bca2baa969b4f67eb0dab/library/core/src/ptr/mod.rs:192

[2021-07-03T14:22:15.397Z] 7: <alloc::collections::vec_deque::VecDeque<T> as core::ops::drop::Drop>::drop

[2021-07-03T14:22:15.397Z]           at /rustc/16bf626a31cb5b121d0bca2baa969b4f67eb0dab/library/alloc/src/collections/vec_deque/mod.rs:135

[2021-07-03T14:22:15.397Z] 8: core::ptr::drop_in_place<alloc::collections::vec_deque::VecDeque<raftstore::store::fsm::apply::Proposal<engine_rocks::snapshot::RocksSnapshot>>>

[2021-07-03T14:22:15.397Z]           at /rustc/16bf626a31cb5b121d0bca2baa969b4f67eb0dab/library/core/src/ptr/mod.rs:192

[2021-07-03T14:22:15.397Z] 9: core::ptr::drop_in_place<raftstore::store::peer::ProposalQueue<engine_rocks::snapshot::RocksSnapshot>>

[2021-07-03T14:22:15.397Z]           at /rustc/16bf626a31cb5b121d0bca2baa969b4f67eb0dab/library/core/src/ptr/mod.rs:192

[2021-07-03T14:22:15.397Z] : core::ptr::drop_in_place<raftstore::store::peer::Peer<engine_rocks::engine::RocksEngine,engine_rocks::engine::RocksEngine>>

[2021-07-03T14:22:15.397Z]           at /rustc/16bf626a31cb5b121d0bca2baa969b4f67eb0dab/library/core/src/ptr/mod.rs:192

[2021-07-03T14:22:15.397Z] : core::ptr::drop_in_place<raftstore::store::fsm::peer::PeerFsm<engine_rocks::engine::RocksEngine,engine_rocks::engine::RocksEngine>>

[2021-07-03T14:22:15.397Z]           at /rustc/16bf626a31cb5b121d0bca2baa969b4f67eb0dab/library/core/src/ptr/mod.rs:192

[2021-07-03T14:22:15.397Z] : core::ptr::drop_in_place<alloc::boxed::Box<raftstore::store::fsm::peer::PeerFsm<engine_rocks::engine::RocksEngine,engine_rocks::engine::RocksEngine>>>

[2021-07-03T14:22:15.397Z]           at /rustc/16bf626a31cb5b121d0bca2baa969b4f67eb0dab/library/core/src/ptr/mod.rs:192

[2021-07-03T14:22:15.397Z] : batch_system::fsm::FsmState<N>::clear

[2021-07-03T14:22:15.397Z]           at /home/jenkins/tikv-src/components/batch-system/src/fsm.rs:152

[2021-07-03T14:22:15.397Z] : batch_system::mailbox::BasicMailbox<Owner>::close

[2021-07-03T14:22:15.397Z]           at /home/jenkins/tikv-src/components/batch-system/src/mailbox.rs:88

[2021-07-03T14:22:15.397Z] : batch_system::router::Router<N,C,Ns,Cs>::broadcast_shutdown

[2021-07-03T14:22:15.397Z]           at /home/jenkins/tikv-src/components/batch-system/src/router.rs:291

[2021-07-03T14:22:15.397Z] : batch_system::batch::BatchSystem<N,C>::shutdown

[2021-07-03T14:22:15.397Z]           at /home/jenkins/tikv-src/components/batch-system/src/batch.rs:458

[2021-07-03T14:22:15.397Z] : raftstore::store::fsm::store::RaftBatchSystem<EK,ER>::shutdown

[2021-07-03T14:22:15.397Z]           at /home/jenkins/tikv-src/components/raftstore/src/store/fsm/store.rs:1407

[2021-07-03T14:22:15.397Z] : tikv::server::node::Node<C,ER>::stop_store

[2021-07-03T14:22:15.397Z]           at /home/jenkins/tikv-src/src/server/node.rs:417

[2021-07-03T14:22:15.397Z] : tikv::server::node::Node<C,ER>::stop

[2021-07-03T14:22:15.397Z]           at /home/jenkins/tikv-src/src/server/node.rs:423

[2021-07-03T14:22:15.397Z] : <test_raftstore::server::ServerCluster as test_raftstore::cluster::Simulator>::stop_node

[2021-07-03T14:22:15.397Z]           at components/test_raftstore/src/server.rs:513

[2021-07-03T14:22:15.397Z] : test_raftstore::cluster::Cluster<T>::stop_node

[2021-07-03T14:22:15.397Z]           at components/test_raftstore/src/cluster.rs:330

[2021-07-03T14:22:15.397Z] : test_raftstore::cluster::Cluster<T>::shutdown

[2021-07-03T14:22:15.397Z]           at components/test_raftstore/src/cluster.rs:724

[2021-07-03T14:22:15.397Z] : <test_raftstore::cluster::Cluster<T> as core::ops::drop::Drop>::drop

[2021-07-03T14:22:15.397Z]           at components/test_raftstore/src/cluster.rs:1507

[2021-07-03T14:22:15.397Z] : core::ptr::drop_in_place<test_raftstore::cluster::Cluster<test_raftstore::server::ServerCluster>>

[2021-07-03T14:22:15.397Z]           at /rustc/16bf626a31cb5b121d0bca2baa969b4f67eb0dab/library/core/src/ptr/mod.rs:192

[2021-07-03T14:22:15.397Z] : failpoints::cases::test_split_region::test_report_approximate_size_after_split_check

[2021-07-03T14:22:15.397Z]           at tests/failpoints/cases/test_split_region.rs:731

[2021-07-03T14:22:15.397Z] : failpoints::cases::test_split_region::test_report_approximate_size_after_split_check::{{closure}}

[2021-07-03T14:22:15.397Z]           at tests/failpoints/cases/test_split_region.rs:668

[2021-07-03T14:22:15.397Z] : core::ops::function::FnOnce::call_once

[2021-07-03T14:22:15.397Z]           at /rustc/16bf626a31cb5b121d0bca2baa969b4f67eb0dab/library/core/src/ops/function.rs:227

[2021-07-03T14:22:15.397Z] : test_util::runner::run_test_with_hook::{{closure}}::{{closure}}

[2021-07-03T14:22:15.397Z]           at components/test_util/src/runner.rs:64

[2021-07-03T14:22:15.397Z] : core::ops::function::FnOnce::call_once{{vtable.shim}}

[2021-07-03T14:22:15.397Z]           at /rustc/16bf626a31cb5b121d0bca2baa969b4f67eb0dab/library/core/src/ops/function.rs:227

[2021-07-03T14:22:15.397Z] : <alloc::boxed::Box<F,A> as core::ops::function::FnOnce<Args>>::call_once

[2021-07-03T14:22:15.397Z]           at /rustc/16bf626a31cb5b121d0bca2baa969b4f67eb0dab/library/alloc/src/boxed.rs:1546

[2021-07-03T14:22:15.398Z] trace

[2021-07-03T14:22:15.398Z]           at library/test/src/lib.rs:576

[2021-07-03T14:22:15.398Z] : <alloc::boxed::Box<F,A> as core::ops::function::FnOnce<Args>>::call_once

[2021-07-03T14:22:15.398Z]           at /rustc/16bf626a31cb5b121d0bca2baa969b4f67eb0dab/library/alloc/src/boxed.rs:1546

[2021-07-03T14:22:15.398Z] fe<F> as core::ops::function::FnOnce<()>>::call_once

[2021-07-03T14:22:15.398Z]           at /rustc/16bf626a31cb5b121d0bca2baa969b4f67eb0dab/library/std/src/panic.rs:344

[2021-07-03T14:22:15.398Z] _call

[2021-07-03T14:22:15.398Z]           at /rustc/16bf626a31cb5b121d0bca2baa969b4f67eb0dab/library/std/src/panicking.rs:379

[2021-07-03T14:22:15.398Z] ::try

[2021-07-03T14:22:15.398Z]           at /rustc/16bf626a31cb5b121d0bca2baa969b4f67eb0dab/library/std/src/panicking.rs:343

[2021-07-03T14:22:15.398Z] nwind

[2021-07-03T14:22:15.398Z]           at /rustc/16bf626a31cb5b121d0bca2baa969b4f67eb0dab/library/std/src/panic.rs:431

[2021-07-03T14:22:15.398Z] ocess

[2021-07-03T14:22:15.398Z]           at library/test/src/lib.rs:599

[2021-07-03T14:22:15.398Z] ure}}

[2021-07-03T14:22:15.398Z]           at library/test/src/lib.rs:491

[2021-07-03T14:22:15.398Z] : test::run_test::run_test_inner

[2021-07-03T14:22:15.398Z]           at library/test/src/lib.rs:529

[2021-07-03T14:22:15.398Z] : test::run_test

[2021-07-03T14:22:15.398Z]           at library/test/src/lib.rs:555

[2021-07-03T14:22:15.398Z] : test::run_tests

[2021-07-03T14:22:15.398Z]           at library/test/src/lib.rs:304

[2021-07-03T14:22:15.398Z] : test::console::run_tests_console

[2021-07-03T14:22:15.398Z]           at library/test/src/console.rs:289

[2021-07-03T14:22:15.398Z] : test::test_main

[2021-07-03T14:22:15.398Z]           at library/test/src/lib.rs:121

[2021-07-03T14:22:15.398Z] : test_util::runner::run_test_with_hook

[2021-07-03T14:22:15.398Z]           at components/test_util/src/runner.rs:79

[2021-07-03T14:22:15.398Z] : test_util::runner::run_failpoint_tests

[2021-07-03T14:22:15.398Z]           at components/test_util/src/runner.rs:111

[2021-07-03T14:22:15.398Z] : failpoints::main

[2021-07-03T14:22:15.398Z]           at tests/failpoints/mod.rs:1

[2021-07-03T14:22:15.398Z] : core::ops::function::FnOnce::call_once

[2021-07-03T14:22:15.398Z]           at /rustc/16bf626a31cb5b121d0bca2baa969b4f67eb0dab/library/core/src/ops/function.rs:227

[2021-07-03T14:22:15.398Z] : std::sys_common::backtrace::__rust_begin_short_backtrace

[2021-07-03T14:22:15.398Z]           at /rustc/16bf626a31cb5b121d0bca2baa969b4f67eb0dab/library/std/src/sys_common/backtrace.rs:125

[2021-07-03T14:22:15.398Z] : std::rt::lang_start::{{closure}}

[2021-07-03T14:22:15.398Z]           at /rustc/16bf626a31cb5b121d0bca2baa969b4f67eb0dab/library/std/src/rt.rs:66

[2021-07-03T14:22:15.398Z] : core::ops::function::impls::<impl core::ops::function::FnOnce<A> for &F>::call_once

[2021-07-03T14:22:15.398Z]           at /rustc/16bf626a31cb5b121d0bca2baa969b4f67eb0dab/library/core/src/ops/function.rs:259

[2021-07-03T14:22:15.398Z] _call

[2021-07-03T14:22:15.398Z]           at library/std/src/panicking.rs:379

[2021-07-03T14:22:15.398Z] ::try

[2021-07-03T14:22:15.398Z]           at library/std/src/panicking.rs:343

[2021-07-03T14:22:15.398Z] nwind

[2021-07-03T14:22:15.398Z]           at library/std/src/panic.rs:431

[2021-07-03T14:22:15.398Z] ernal

[2021-07-03T14:22:15.398Z]           at library/std/src/rt.rs:51

[2021-07-03T14:22:15.398Z] : std::rt::lang_start

[2021-07-03T14:22:15.398Z]           at /rustc/16bf626a31cb5b121d0bca2baa969b4f67eb0dab/library/std/src/rt.rs:65

[2021-07-03T14:22:15.398Z] : main

[2021-07-03T14:22:15.398Z] : __libc_start_main

[2021-07-03T14:22:15.398Z] : <unknown>

[2021-07-03T14:22:15.398Z]


RFC: Configuring gateway 'root' properties from blueprints

About Me
This RFC is posted on behalf of the BBC
Use Case
We want the blueprints to own the configuration of the system.
For a MOS gateway, the ID of the gateway is defined at the root level of the gateway, which blueprints are not able to configure.
For playout gateway, there are various boolean options at the root level which control some behaviour of the gateway, these have suboptimal defaults that cannot be changed by the blueprints.
Proposal
I do not have a proposed solution, I am looking for ideas on how this should be solved.
Process
The Sofie Team will evaluate this RFC and open up a discussion about it, usually within a week.

[x] RFC created
[ ] Sofie Team has evaluated the RFC
[ ] A workshop has been planned
[ ] RFC has been discussed in a workshop
[ ] A conclusion has been reached, see comments in thread

Could this potentially be a task for system blueprints? Maybe they could provide callbacks to return defaults for a first connection of a PeripheralDevice? Or even every connection, and "onPeripheralDeviceConnected" callback - if it were async, one could imagine a sort-of DHCP setup, where the System Blueprint could query a central command server for what these settings should be, and then that system could make the decision. Perhaps it would then make sense to expose some environment variables to the System Blueprint to make identifying instances easier.

I've got a potential proposal that might solve this:
I believe the root problem lies with that the current PeripheralDevice type (see definition) contains some properties that are owned and set by the device itself (such as category, type, status, versions, token), some properties owned and set by Sofie Core (studioId, settings, connected) as well as one whose ownership is a ambiguous (name).
I propose that we rework the PeripheralDevice to be a pure "status carrier" instead, so that it'll contain only statuses and identifier info (such as token, status, connected, category, versions, nrcsName etc).
So we would:

move the settings  to be a setting on the Studio, similar to how we've done it with the sub-devices settings.
move the studioId to a new collection (PeripheralDeviceStudioMap). This is to make the lookup for Device -> Studio simple and not require a deep lookup of the Studio.
Add a blueprint method (to the system blueprints) to be able to add a PeripheralDeviceStudioMap entry.
Add a blueprint method (to the studio blueprints ) to be able to set the settings for a PeripheralDevice (similar to the sub-devices).

Please also consider the configuration API impact.
I can imagine that there may be some blueprint defaults for PeripheralDevice settings that we can define in a config-preset and provide a more limited set of settings to the API to offer simpler client implementation and allow safer parameter validation.

@nytamin I'm not opposed to that plan,
1 & 4) I think this would work. I think it would fit into the existing applyConfig method without needing a new one. I think the question then becomes, is the current strategy of having the subdevices separated from the parent device ok?
2 & 3) I am not sure I like this. Adding a collection which contains just a pair of ids feels very SQL and not very noSQL.
And will we be able to give that blueprint method enough info to make an informed decision about which studio a device should be part of?
What if the device provided the studioId as part of its init?
From a quick skim, I don't see not persisting this as making anything harder, in various places we are finding devices by studioId, but we can simply use the object on the studio document.
That moves the determination of the id to be defined in the environment, which I think makes sense. Your deployment kind of needs to know this relationship anyway so that you dont restart/delete/update the wrong one when doing maintenance. So I think it better to rely on that instead of relying on the blueprints to figure out and match this.
Of course, for installations which are a single studio this will be trivial as everything can default to studio0 unless something else is specified

I know I've pitched before that I would like to see the parent and child devices combined into one object at some point, might be worth considering doing that at the same time as the rest of this if it feels like not much more work.

What if the device provided the studioId as part of its init?

I don't think that's a good idea, because the action of "adding a device to a studio" is essentally giving that device access to that studio, so that is something that should be done by an authorized user / internally/ blueprints. Otherwise that would be a potential attack vector by a malicious actor.
Instead of having the StudioId-DeviceId-pair as a separate collection, it could be a property on the Studio? I guess if we add a db-index for that property as well, doing a lookup on Studios, to figure out which studio a Device has should be fine.

I don't think that's a good idea, because the action of "adding a device to a studio" is essentally giving that device access to that studio, so that is something that should be done by an authorized user / internally/ blueprints. Otherwise that would be a potential attack vector by a malicious actor.

I think I've said this before, but I would also really like to change the registration flow to be that the deviceId and token has to be added in Sofie by the user before the device is allowed to connect.
What I have proposed here would be leaning into that direction, but not going all the way there yet.
Also, we don't have enough functional security for the current system to do anything. Any ddp client (including a malicious client) can issue a core.ddp.ddpClient.call('/peripheralDevices/updateAsync', [{ _id: 'ExampleDevice' }, { $set: { studioId: 'studio0' } }, {}, ]) to add themselves to a studio. That is simply replicating what the ui does when attaching a device to the studio.
After #1287, if running with the new security mode enabled then that won't be possible. But it is also expected that nginx/whatever should be performing the authentication and only allowing connection to sofie if the peripheraldevice has valid credentials. Meaning the token wouldn't really do anything. And if the deviceId/studioId were specified via header instead of part of the init payload, then the proxy could enforce certain values to tighten it up even more. The result of this being that the auto-add and attach behaviour would actually be fine and desirable.

jumping back a little bit here, it sounds like @nytamin and I agree on 1 & 4, so I shall start working on those.
2 & 3 are not in the scope of what we need as part of this RFC, so I propose that we ignore those for this RFC (unless it becomes problematic while implementing) and this can be revisited later

This RFC is handled in PR #1336


How to combine model predictions?

When I perform training, models for the generator, discriminator and feature extractor are saved. When I want to perform prediction, is there a way to combine these models? How would I incorporate the loss_weights into that? Or is that not really the point, and I should just train with each model separately in different stages, and predict with a single model?

Hi, have you figured it out? I also have this question.

You train two different RRDN models, one with the discriminator off and one with both. Save both the weights to file. Then do this:
from ISR.models import RRDN
network1 = RRDN(arch_params= ...)
network2 = RRDN(arch_params= ...)
interpolated_network = RRDN(same as above)
network1.model.load_weights()
network2.model.load_weights()
vars1 = [v.numpy() for v in network1.trainable_variables]
vars2 = [v.numpy() for v in network2.trainable_variables]
for i, var in enumerate(interpolated_network.model.trainable_variables):
var.assign( (1-a)vars1[i] + avars2[i] )

Thanks!


ARROW-4882: [GLib] Add sum functions

Codecov Report

Merging #3933 into master will increase coverage by 0.82%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #3933      +/-   ##
==========================================
+ Coverage   87.74%   88.56%   +0.82%
==========================================
  Files         727      593     -134
  Lines       89499    79916    -9583
  Branches     1252        0    -1252
==========================================
- Hits        78532    70780    -7752
+ Misses      10849     9136    -1713
+ Partials      118        0     -118

Impacted Files
Coverage Δ

cpp/src/plasma/thirdparty/ae/ae.c
70.75% <0%> (-0.95%)
:arrow_down:

python/pyarrow/tests/test_convert_pandas.py
94.82% <0%> (ø)
:arrow_up:

cpp/src/arrow/util/cpu-info.cc
75% <0%> (ø)
:arrow_up:

python/pyarrow/pandas_compat.py
93.68% <0%> (ø)
:arrow_up:

go/arrow/math/uint64_amd64.go

go/arrow/memory/memory_avx2_amd64.go

js/src/enum.ts

go/arrow/array/builder.go

js/src/Arrow.node.ts

js/src/schema.ts

... and 128 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c707822...1fe8805. Read the comment docs.

Thanks!


Column dependency extraction using TableRead event of audit log

Sample Query:

with datasource as (
  select
    metadata.`@type` as type
    , c.timestamp
    , resource
    , protopayload_auditlog.servicedata_v1_bigquery.jobCompletedEvent
    , metadata.tableDataRead
    , JSON_VALUE_ARRAY(metadata.tableDataRead.fields) as fields
    , string(metadata.tableDataRead.jobName) as jobName
  from `bqmake._auditlog.cloudaudit_googleapis_com_data_access` as c
  left join unnest([struct(
    safe.parse_json(protopayload_auditlog.metadataJson) as metadata
  )])
  where
    date(timestamp) >= date(current_date() - interval 1 day)
  --  and resource.type = 'bigquery_dataset'
)
, tableReadData as (
  select
    regexp_extract(jobName, '[^/]+$') as jobId
    , to_json_string(fields) as fields
    , tableDataRead as _raw
  from datasource
  where resource.type = 'bigquery_dataset'
)
, jobCompleteEvent as (
  select
    timestamp
    , jobCompletedEvent.job.jobName.jobId as jobId
    , struct(
       jobCompletedEvent.job.jobConfiguration as config
       , jobCompletedEvent.job.jobStatistics as statistics
    ) as job
    , jobCompletedEvent as _raw
  from datasource
  where jobCompletedEvent.eventName = 'query_job_completed'
)
, lineage as (
  select *
  from jobCompleteEvent
  left join tableReadData using(jobId)
  order by timestamp desc
)

select * from lineage

Resolved by v0.clineage__ prceedures


Add support for Symfony 5

Adds support for Symfony 5 and thus Laravel 7 as well.

@RoccoHoward any chance you could merge this so I can stop maintaining a fork? Thanks!

Thanks @GenieTim


Remove Bosh Deployment Checker from Docs

The Bosh Deployment Checker setting in this document no longer exists, at least as of the 2.0.2 tile, it should be removed from the document to avoid confusion.

Thank you, @Ty-Torregrosa!

Thank you, @Ty-Torregrosa!


MIC-406 - update to use uuid as primary key

Update data model documentation
Update data model to use the uuid as the primary key
Add version column to help SB determine persist vs merge (better efficiency - but also preps for future update validation)
Added repositories for entities that can be updated, ready for future work but helps simplify testing code in the meantime
remove use of transaction template where no longer necessary
remove calls to csip repository save where no longer necessary
updated username field/length validation to allow longer usernames and make consistent across entities/tables

Codecov Report
Attention: Patch coverage is 88.23529% with 10 lines in your changes missing coverage. Please review.

Project coverage is 87.42%. Comparing base (88378e1) to head (e90389d).

Files
Patch %
Lines

...nplanapi/config/CsipRequestContextConfiguration.kt
0.00%
0 Missing and 1 partial :warning:

...ngesupportinterventionplanapi/entity/CsipRecord.kt
87.50%
1 Missing :warning:

...rtinterventionplanapi/entity/DecisionAndActions.kt
66.66%
1 Missing :warning:

...supportinterventionplanapi/entity/Investigation.kt
66.66%
1 Missing :warning:

...challengesupportinterventionplanapi/entity/Plan.kt
66.66%
1 Missing :warning:

...lengesupportinterventionplanapi/entity/Referral.kt
83.33%
1 Missing :warning:

...tionplanapi/entity/SaferCustodyScreeningOutcome.kt
66.66%
1 Missing :warning:

...planapi/repository/ContributoryFactorRepository.kt
0.00%
0 Missing and 1 partial :warning:

...tionplanapi/repository/IdentifiedNeedRepository.kt
0.00%
0 Missing and 1 partial :warning:

...erventionplanapi/repository/InterviewRepository.kt
0.00%
0 Missing and 1 partial :warning:

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #108      +/-   ##
============================================
+ Coverage     87.29%   87.42%   +0.13%
+ Complexity      582      575       -7
============================================
  Files           117      120       +3
  Lines          1755     1710      -45
  Branches        100       95       -5
============================================
- Hits           1532     1495      -37
+ Misses          178      168      -10
- Partials         45       47       +2

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


crow::json::get_type_str should be inline

Hello!
Got problem when included crow.h in multiple files
multiple definition of `crow::json::get_type_str(crow::json::type)'

crow::json::get_type_str should be inline.
https://github.com/ipkn/crow/blob/master/include/json.h#L85

After submitting found https://github.com/ipkn/crow/pull/113

@shahmuratov then close this issue, please

This issue is also resolved as of yesterday.


Implement Default for iterators

See rust-lang/rust#128261 for a similar PR for some libstd iterators. In order to do a similar PR for the HashSet and HashMap types, we need to make these changes to hashbrown first to actually implement them.
One small caveat is that I chose to only implement Default for RawIter and not RawIterRange, since it really exists as an implementation detail anyway, and the best implementation would involve just using the RawIter implementation anyway.

As far as I remember, parallel iterator (rayon) uses RawIterRange directly, so maybe it would be nice to implement Default for RawIterRange too.

That would be a bit difficult for a pub(crate) iterator.

@bors r+

:pushpin: Commit abd706ec35e699653cd176a7a817bd3100e71c00 has been approved by Amanieu
It is now in the queue for this repository.

:hourglass: Testing commit abd706ec35e699653cd176a7a817bd3100e71c00 with merge f677701e261d497ad72216cefa69fd89b73164cc...

:sunny: Test successful - checks-actions
Approved by: Amanieu
Pushing f677701e261d497ad72216cefa69fd89b73164cc to master...


Carla Command Issue in Matlab

CARLA version: 0.9.13
Matlab version: 2020b
Platform/OS: Windows 10
While running CARLA in a Matlab Script I got the error message "Unable to resolve the name py.carla.command.ApplyTargetVelocity". Althought vehicle.set_target_velocity(py.carla.Vector3D(8.3333333333, 0, 0)); works without a problem.
Has anyone worked with Carla commands in Matlab before and got some experience?
I excected the vehicle to start driving at a speed of 30 km/h like it would do with set_target_velocity. In VS Code in Python Carla commands worked fine as well.
Thats the matlab code where the error occured:
% get client, load world
client = py.carla.Client('localhost', int16(2000));
client.set_timeout(10.0);
world = client.load_world("Town02");

% set time settings
settings = world.get_settings();
settings.fixed_delta_seconds = 0.01;
settings.synchronous_mode = true;
world.apply_settings(settings);

% move spectator
spectator = world.get_spectator();
spectator.set_transform(py.carla.Transform(py.carla.Location(160, 250, 10), py.carla.Rotation(-30, -90, 0)));

% walker setup
walker_bp = world.get_blueprint_library().find("walker.pedestrian.0014");
walker_spawn_point = py.carla.Transform(py.carla.Location(160, 245.491811, 0.5), py.carla.Rotation(0, 0, 0));
walker = world.spawn_actor(walker_bp, walker_spawn_point);

% vehicle setup
vehicle_bp = world.get_blueprint_library().find("vehicle.audi.etron");
vehicle_spawn_point = py.carla.Transform(py.carla.Location(128.072146, 240.983622, 0.5), py.carla.Rotation(0, 0, 0));
vehicle = world.spawn_actor(vehicle_bp, vehicle_spawn_point);

batch = [];

% vehicle setup
vehicle_id = vehicle.id.int64;
batch.append(py.carla.command.ApplyTargetVelocity(vehicle_id, py.carla.Vector3D(8.3333333333, 0, 0)));

% walker setup
walker_id = walker.id.int64;
walker_control = py.carla.WalkerControl(py.carla.Vector3D(0, -1, 0), 1.3888888888, false);
batch.append(py.carla.command.ApplyWalkerControl(walker_id, walker_control));

client.apply_batch_sync(batch, true);

and the same in VS Code in Python but working:
import glob
import sys
try:
    sys.path.append(glob.glob('..\CARLA_0.9.13\WindowsNoEditor\PythonAPI\carla\dist\carla-0.9.13-py3.7-win-amd64.egg')[0])
except IndexError:
    pass
import carla

client = carla.Client('localhost', 2000)
client.set_timeout(10.0)
world = client.load_world("Town02")

settings = world.get_settings()
settings.fixed_delta_seconds = 0.01
settings.synchronous_mode = True
world.apply_settings(settings)

spectator = world.get_spectator()
spectator.set_transform(carla.Transform(carla.Location(195, 233, 7), carla.Rotation(-30, 145, 0)))

vehicle_bp = world.get_blueprint_library().find("vehicle.audi.etron")
vehicle_spawn_point = carla.Transform(carla.Location(47.65, 240.983622, 0.5), carla.Rotation(0, 0, 0))
vehicle = world.spawn_actor(vehicle_bp, vehicle_spawn_point)

walker_bp = world.get_blueprint_library().find("walker.pedestrian.0014")
walker_spawn_point = carla.Transform(carla.Location(190, 240.983622, 0.5), carla.Rotation(0, 180, 0))
walker = world.spawn_actor(walker_bp, walker_spawn_point)

batch = []

vehicle_id = vehicle.id
batch.append(carla.command.ApplyTargetVelocity(vehicle_id, carla.Vector3D(8.3333333333, 0, 0)))

walker_id = walker.id
walker_control = carla.WalkerControl(carla.Vector3D(0, -1, 0), 1.3888888888, False)
batch.append(carla.command.ApplyWalkerControl(walker_id, walker_control))

client.apply_batch_sync(batch, True)

Does anyone have a suggestion?
I am grateful for any support, thanks.

Hi,
I can't say if the "py.carla" could be a problem.
You can try installing the .whl file of Carla in the python environment you are using.
path/to/python.exe -m pip install path/to/carla//PythonAPI/carla/dist/carla-0.9.13-cp37-cp37--win-amd64.whl

after that, you can remove the path to the egg file.


Russian language please add

https://mcraft.pw/ru_ru.ini unicode utf-8

Thank you for submitting the file. It'll be implemented in the next patch update (v3.4.2).


WIP - Rerun tests if client reloads

If Meteor triggers a client-side reload, we are informed about it and can rerun the tests for the client.
This pull-request is a work-in-progress, tracking our status on this feature. Feel free to drop in and help out.

[x] Find a way to detect a client reload
[x] Run the client tests again if meteor sends the signal
[ ] Forcefully close the browser before rerunning the tests (requires https://github.com/meteortesting/meteor-browser-tests/issues/29 to be resolved first)

The current version reports that it skips the reload if the tests are already running. This brings us into the odd state of having to wait until the tests are finished before a person can trigger a rerun.

Thank you for your work. I shortly tested your branch locally as a package in my app and it seems to work well.
I tested watch mode for TEST_SERVER=0 npm run test-watch and TEST_CLIENT=0 npm run test-watch
I was changing the meteor code running on the client and server and also the test file which I watched with describe.only. Every time meteor reloaded and mocha re-run the tests.

Hi, @SimonSimCity I saw that the lint job fails only because of a missing semicolon.
It would be great if you would find some time to merge this PR and release the 2.0.2 version with this fix.
In my meteor project, I am using this package locally with this exact PR. Still, after some time it worked fine with no issues.

@jirikrepl I can understand your excitement about this so much asked for feature, but I wouldn't release it without having the case fixed that you have to wait for all the tests to run through before restarting the client-test-suite. I'm not actively using meteor anymore which makes it hard for me to set time off for further development on this feature.
You should feel encouraged to look at the codebase yourself - it's not complicated and I and the other maintainers would love to see your contribution.


YAML support for complex dimension links and metric metadata

Summary
This PR adds YAML support for various types of dimension links and metric metadata.
Dimension Links
Supports the following dimension link variants to be defined with YAML:

join dimension links, with the option to customize the join on clause for complex joins
reference dimension links
dimension links with roles

Metric Metadata
Supports the following pieces of metric metadata to be defined with YAML:

Required dimensions
Metric unit
Metric direction

It also adds documentation on how to setup YAML projects, along with detailed docs for the available fields.
Test Plan

[x] PR has associated issues:

#1201
#1233

[x] make check passes
[x] make test shows 100% unit test coverage

Deployment Plan

Thanks @shangyian ! This PR is super cool.


fix 404s

fixing a few url path typos

bypassing the version bump for now in the GH action, merging anyways


Inspector retains content when detached and when docked

Inspector now retains its contents when it's turned into a floating window and when it's docked again (fixed #45749).
https://user-images.githubusercontent.com/18116695/151673447-76aef34f-1d56-4ce6-ae47-873ed39c8bdc.mp4

Thanks!


Swap: Allow cancel for alice refundsig before arb lock

Alice should be able to cancel the swap up until the point where Bob's lock has confirmed.

Codecov Report

Merging #518 (cfff1f5) into main (482985f) will decrease coverage by 0.0%.
The diff coverage is 0.0%.

@@           Coverage Diff           @@
##            main    #518     +/-   ##
=======================================
- Coverage   12.4%   12.4%   -0.0%
=======================================
  Files         34      34
  Lines       9995   10017     +22
=======================================
  Hits        1238    1238
- Misses      8757    8779     +22

Impacted Files
Coverage Δ

src/swapd/runtime.rs
0.0% <0.0%> (ø)

src/swapd/swap_state.rs
0.0% <0.0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 482985f...cfff1f5. Read the comment docs.


PR and Issue Template

Current situation
Currently we don't have any specific issue/PR template that we would be following for this project.
Suggested changes
Create a specific template that we would be following for creating an issue and PR.

This had been fixed via this commit.


Add catapult publish to .drone.yml

For context, see https://clever.atlassian.net/browse/INFRA-1165.
This PR was autogenerated. You were assigned this PR as the most active committer to this repo (or because @xavi- chose you). Congrats!

lgtm


dbtcloud_environment_variable resource appears to have a caching issue, preventing re-creation of named environment variable.

Describe the bug
I am attempting to create, delete, then re-create a dbt environment variable.  The create apply works successfully.  The delete (destroy) apply works successfully.  The subsequent create apply fails.
Error message
The request was invalid.  Please double check the provided data and try again.  An environment variable by this name already exists in this project and account.
Resource configuration
resource "dbtcloud_environment_variable" "deploy-environment-variable-dbt-test" {
name = "DBT_TEST"
project_id = data.aws_ssm_parameter.project-id.value
environment_values = {
"project" : "test_project_default",
"test" : "test_value"
}
Expected behavior
After creating the dbt environment variable, then deleting the variable, I expect another creation apply to succeed.
Config (please complete the following information):
dbtcloud = {
source  = "dbt-labs/dbtcloud"
version = ">=0.2.1"
}
Additional context
Add any other context about the problem here.

Hi @BrianMcGrathCox , I just tried to replicate it locally and it didn't fail. I did the following:

add an env var from Terraform and apply: the env var is created
after it is created, comment the Terraform code for the env var and apply: the env var is deleted
Uncomment the code of the env var and apply: the env var is created

I also did the following and the resource got deleted and recreated
terraform apply -replace=dbtcloud_environment_variable.deploy-environment-variable-dbt-test

Could you check if the env var in question has really been deleted from dbt Cloud?
And/or if someone has recreated it manually via the dbt Cloud UI?
If it has been created manually, it will need to be either deleted from the UI or imported into the Terraform state before it can be managed via Terraform.
The import instructions are in the docs.

Benoit,
Thanks for testing this.
Yes, we did verify that the environment variable was deleted before creating/adding back the environment variable.
I removed the environment variable from dbt cloud project.
I deployed (plan/apply) terragrunt module without the environment variable.  This was successful.
I verified the environment variable is not in dbt cloud project.
I added the environment variable to the terragrunt module.
I deployed (plan/apply) terragrunt module.  This was not successful.
Error: POST url: https://cloud.getdbt.com/api/v3/accounts/97616/projects/223007/environment-variables/bulk/, status: 400, body: {"status":{"code":400,"is_success":false,"user_message":"The request was invalid. Please double check the provided data and try again.","developer_message":""},"data":{"reason":"An environment variable by this name already exists in this project and account"}}
│
│   with dbtcloud_environment_variable.deploy-environment-variable-dbt-test,
│   on dbt-deploy-environment-variable-dbt-test.tf line 1, in resource "dbtcloud_environment_variable" "deploy-environment-variable-dbt-test":
│    1: resource "dbtcloud_environment_variable" "deploy-environment-variable-dbt-test" {
Following is my resource file (dbt-deploy-environment-variable-dbt-test.tf)
resource "dbtcloud_environment_variable" "deploy-environment-variable-dbt-test" {
name = "DBT_TEST"
project_id = data.aws_ssm_parameter.project-id.value
environment_values = {
"project" : "test_project_default",
"test" : "test_value"
}
depends_on = [
dbtcloud_environment.deploy-environment-test,
dbtcloud_job.deploy-job-test
]
}
From: Benoit Perigaud @.>
Date: Monday, November 13, 2023 at 7:25 AM
To: dbt-labs/terraform-provider-dbtcloud @.>
Cc: McGrath, Brian (CAI - Carmel) @.>, Mention @.>
Subject: Re: [dbt-labs/terraform-provider-dbtcloud] dbtcloud_environment_variable resource appears to have a caching issue, preventing re-creation of named environment variable. (Issue #213)
Hi @BrianMcGrathCoxhttps://urldefense.com/v3/__https:/github.com/BrianMcGrathCox__;!!Gh9pqc0J0AYYLQ!ORcdwAIrPql84z1j-6VNR8nWr31tIBugZ7t1f02uKocyZ0pOU2oQxWuQ_tO0B7nvsRT2m3RNCANg3ZHqGcGQMQrbuVETK_4$ , I just tried to replicate it locally and it didn't fail. I did the following:

add an env var from Terraform and apply: the env var is created
after it is created, comment the Terraform code for the env var and apply: the env var is deleted
Uncomment the code of the env var and apply: the env var is created

I also did the following and the resource got deleted and recreated
terraform apply -replace=dbtcloud_environment_variable.deploy-environment-variable-dbt-test

Could you check if the env var in question has really been deleted from dbt Cloud?
And/or if someone has recreated it manually via the dbt Cloud UI?
If it has been created manually, it will need to be either deleted from the UI or imported into the Terraform state before it can be managed via Terraform.
The import instructionshttps://urldefense.com/v3/__https:/registry.terraform.io/providers/dbt-labs/dbtcloud/latest/docs/resources/environment_variable*import__;Iw!!Gh9pqc0J0AYYLQ!ORcdwAIrPql84z1j-6VNR8nWr31tIBugZ7t1f02uKocyZ0pOU2oQxWuQ_tO0B7nvsRT2m3RNCANg3ZHqGcGQMQrbnlu5Qio$ are in the docs.
—
Reply to this email directly, view it on GitHubhttps://urldefense.com/v3/__https:/github.com/dbt-labs/terraform-provider-dbtcloud/issues/213*issuecomment-1808069433__;Iw!!Gh9pqc0J0AYYLQ!ORcdwAIrPql84z1j-6VNR8nWr31tIBugZ7t1f02uKocyZ0pOU2oQxWuQ_tO0B7nvsRT2m3RNCANg3ZHqGcGQMQrbz72BJt0$, or unsubscribehttps://urldefense.com/v3/__https:/github.com/notifications/unsubscribe-auth/AVSD6B35RFEHEKTP2SJEAGDYEIGRRAVCNFSM6AAAAAA7BQN4KCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMBYGA3DSNBTGM__;!!Gh9pqc0J0AYYLQ!ORcdwAIrPql84z1j-6VNR8nWr31tIBugZ7t1f02uKocyZ0pOU2oQxWuQ_tO0B7nvsRT2m3RNCANg3ZHqGcGQMQrbsUnkXRE$.
You are receiving this because you were mentioned.Message ID: @.***>

dbtcloud_job.deploy-job-test makes me think of something...
Would you by any chance overwrite the specific env var in some jobs? (and/or maybe at the developer profile level)
And if you overwrite the env var for the job, do you do it via the UI? (I don't think that the provider supports it yet)

I tried another test case.
I removed deploy for dbt environment and dbt job.  So, my deployment only consists of a single dbt environment variable.
I confirmed the dbt environment variable is not in dbt project.
The deployment failed with the below error.  It appears like the environment variable is cached in dbt or there is something reference it that triggers the error.
Error: POST url: https://cloud.getdbt.com/api/v3/accounts/97616/projects/223007/environment-variables/bulk/, status: 400, body: {"status":{"code":400,"is_success":false,"user_message":"The request was invalid. Please double check the provided data and try again.","developer_message":""},"data":{"reason":"An environment variable by this name already exists in this project and account"}}
│
│   with dbtcloud_environment_variable.deploy-environment-variable-dbt-test,
│   on dbt-deploy-environment-variable-dbt-test.tf line 1, in resource "dbtcloud_environment_variable" "deploy-environment-variable-dbt-test":
│    1: resource "dbtcloud_environment_variable" "deploy-environment-variable-dbt-test" {
│
From: Benoit Perigaud @.>
Date: Tuesday, November 14, 2023 at 3:04 AM
To: dbt-labs/terraform-provider-dbtcloud @.>
Cc: McGrath, Brian (CAI - Carmel) @.>, Mention @.>
Subject: Re: [dbt-labs/terraform-provider-dbtcloud] dbtcloud_environment_variable resource appears to have a caching issue, preventing re-creation of named environment variable. (Issue #213)
dbtcloud_job.deploy-job-test makes me think of something...
Would you by any chance overwrite the specific env var in some jobs? (and/or maybe at the developer profile level)
And if you overwrite the env var for the job, do you do it via the UI? (I don't think that the provider supports it yethttps://urldefense.com/v3/__https:/github.com/dbt-labs/terraform-provider-dbtcloud/issues/99__;!!Gh9pqc0J0AYYLQ!Kk_WFBDVbx0n8PkGB0lvRmwmjHkkJ_IF-iQccMdJHbszaCnQbS3kLhWVwMFP_sHuBXt8oGHTPtHwppRkftCiEMBhGIso-dU$)
—
Reply to this email directly, view it on GitHubhttps://urldefense.com/v3/__https:/github.com/dbt-labs/terraform-provider-dbtcloud/issues/213*issuecomment-1809711780__;Iw!!Gh9pqc0J0AYYLQ!Kk_WFBDVbx0n8PkGB0lvRmwmjHkkJ_IF-iQccMdJHbszaCnQbS3kLhWVwMFP_sHuBXt8oGHTPtHwppRkftCiEMBh0gjwHeo$, or unsubscribehttps://urldefense.com/v3/__https:/github.com/notifications/unsubscribe-auth/AVSD6BZVN6DV6RKYD2LWYETYEMQ2NAVCNFSM6AAAAAA7BQN4KCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMBZG4YTCNZYGA__;!!Gh9pqc0J0AYYLQ!Kk_WFBDVbx0n8PkGB0lvRmwmjHkkJ_IF-iQccMdJHbszaCnQbS3kLhWVwMFP_sHuBXt8oGHTPtHwppRkftCiEMBhDQHuITk$.
You are receiving this because you were mentioned.Message ID: @.***>

Hi @BrianMcGrathCox
I have tried again to replicate the issue but can't do it.
The next course of action would be to raise a support ticket from dbt Cloud and mention that issue in the ticket. From my perspective, it doesn't seem to be an issue with the provider itself (which I could help with) but might be a problem with the API and/or some dangling config in your account and project (which the support team should be able to help with).
If you can, please mention the ticket number here once raised so I can follow up with the Support team.

Thank you.
Can you send me the resource file you used in your test case(s)?
From: Benoit Perigaud @.>
Date: Wednesday, November 15, 2023 at 3:54 AM
To: dbt-labs/terraform-provider-dbtcloud @.>
Cc: McGrath, Brian (CAI - Carmel) @.>, Mention @.>
Subject: Re: [dbt-labs/terraform-provider-dbtcloud] dbtcloud_environment_variable resource appears to have a caching issue, preventing re-creation of named environment variable. (Issue #213)
Hi @BrianMcGrathCoxhttps://urldefense.com/v3/__https:/github.com/BrianMcGrathCox__;!!Gh9pqc0J0AYYLQ!JdX7Qgxw7LjVX6Pznkc90WIaNEL1R-IozYGPSywX3clQAGAuAoe9o670-iwz6ach6vQ5USGqsdt_pYSITzzOqe8nvEj1uLQ$
I have tried again to replicate the issue but can't do it.
The next course of action would be to raise a support ticket from dbt Cloud and mention that issue in the ticket. From my perspective, it doesn't seem to be an issue with the provider itself (which I could help with) but might be a problem with the API and/or some dangling config in your account and project (which the support team should be able to help with).
If you can, please mention the ticket number here once raised so I can follow up with the Support team.
—
Reply to this email directly, view it on GitHubhttps://urldefense.com/v3/__https:/github.com/dbt-labs/terraform-provider-dbtcloud/issues/213*issuecomment-1812040869__;Iw!!Gh9pqc0J0AYYLQ!JdX7Qgxw7LjVX6Pznkc90WIaNEL1R-IozYGPSywX3clQAGAuAoe9o670-iwz6ach6vQ5USGqsdt_pYSITzzOqe8nr7VlkWw$, or unsubscribehttps://urldefense.com/v3/__https:/github.com/notifications/unsubscribe-auth/AVSD6B73IOBYJ7T2FHAP35LYER7M5AVCNFSM6AAAAAA7BQN4KCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMJSGA2DAOBWHE__;!!Gh9pqc0J0AYYLQ!JdX7Qgxw7LjVX6Pznkc90WIaNEL1R-IozYGPSywX3clQAGAuAoe9o670-iwz6ach6vQ5USGqsdt_pYSITzzOqe8nADMP3Ro$.
You are receiving this because you were mentioned.Message ID: @.***>

Sure, here is an example:
resource "dbtcloud_environment_variable" "dbt_my_env_var" {
  name       = "DBT_TF_ENV_VAR"
  project_id = 2570
  environment_values = {
    "project" : "1",
    "DEV" : "2",
    "PROD": "4"
  }
}

I am able to create it, destroy it, recreate it and it works fine

Thanks,
Can you try one more case for me?
Please remove “DEV” : “2” from environment values, then redeploy.
Please validate in dbt project after deploying.
I am testing this case, terraform says 1 resource updated successfully. However, in dbt, the resource did not get updated.
Thanks,
Brian
From: Benoit Perigaud @.>
Date: Wednesday, November 15, 2023 at 8:42 AM
To: dbt-labs/terraform-provider-dbtcloud @.>
Cc: McGrath, Brian (CAI - Carmel) @.>, Mention @.>
Subject: Re: [dbt-labs/terraform-provider-dbtcloud] dbtcloud_environment_variable resource appears to have a caching issue, preventing re-creation of named environment variable. (Issue #213)
Sure, here is an example:
resource "dbtcloud_environment_variable" "dbt_my_env_var" {
name       = "DBT_TF_ENV_VAR"
project_id = 2570
environment_values = {
"project" : "1",

"DEV" : "2",

"PROD": "4"

}
}
I am able to create it, destroy it, recreate it and it works fine
—
Reply to this email directly, view it on GitHubhttps://urldefense.com/v3/__https:/github.com/dbt-labs/terraform-provider-dbtcloud/issues/213*issuecomment-1812558135__;Iw!!Gh9pqc0J0AYYLQ!JGSlIWmrQx8mCNV7-BadZgBr4K9E0uxiE0qDKzL8FNA99kXCNn3QJDBg9cuPjWv9vuhDmg1vKelhFsjaQePvl5hqKdbHODs$, or unsubscribehttps://urldefense.com/v3/__https:/github.com/notifications/unsubscribe-auth/AVSD6B5FXJOOFJFY3USHWJLYETBDHAVCNFSM6AAAAAA7BQN4KCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMJSGU2TQMJTGU__;!!Gh9pqc0J0AYYLQ!JGSlIWmrQx8mCNV7-BadZgBr4K9E0uxiE0qDKzL8FNA99kXCNn3QJDBg9cuPjWv9vuhDmg1vKelhFsjaQePvl5hqbpuDJBs$.
You are receiving this because you were mentioned.Message ID: @.***>

I was able to reproduce this second case 👍
I will raise an issue about it to track them separately as I couldn't reproduce the first one.

Benoit,
Have you added the second case for tracking?
From: Benoit Perigaud @.>
Date: Thursday, November 16, 2023 at 10:33 AM
To: dbt-labs/terraform-provider-dbtcloud @.>
Cc: McGrath, Brian (CAI - Carmel) @.>, Mention @.>
Subject: Re: [dbt-labs/terraform-provider-dbtcloud] dbtcloud_environment_variable resource appears to have a caching issue, preventing re-creation of named environment variable. (Issue #213)
I was able to reproduce this second case 👍
I will raise an issue about it to track them separately as I couldn't reproduce the first one.
—
Reply to this email directly, view it on GitHubhttps://urldefense.com/v3/__https:/github.com/dbt-labs/terraform-provider-dbtcloud/issues/213*issuecomment-1814692117__;Iw!!Gh9pqc0J0AYYLQ!ODwkyJP-EI2-HfTUsfPOBGZVVMKCfts_dgfiaZHy-hY_Kam1ePytsS9_hY1JXqlDQi43bSQAi95_j7C5V_PpLSTMnNh7Bp0$, or unsubscribehttps://urldefense.com/v3/__https:/github.com/notifications/unsubscribe-auth/AVSD6BZIW2JXL5U6BYMLBL3YEYW3HAVCNFSM6AAAAAA7BQN4KCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMJUGY4TEMJRG4__;!!Gh9pqc0J0AYYLQ!ODwkyJP-EI2-HfTUsfPOBGZVVMKCfts_dgfiaZHy-hY_Kam1ePytsS9_hY1JXqlDQi43bSQAi95_j7C5V_PpLSTMkNOGKWI$.
You are receiving this because you were mentioned.Message ID: @.***>

Yes, for the second case, I have raised #221 and added info on how to potentially fix it.
As an immediate workaround, you could just do a terraform apply -replace=dbtcloud_environment_variable.dbt_my_env_var  . With the current resource we just need to destroy and recreate the env var whenever we want to delete the value for 1 env.
For the other case, please share the support ticket number if you had a chance to raise it.

I actually just did a new release to fix the second use case tracked in #221

I will validate the fix for #221.
The first case I raised is #213.
Thanks,
Brian
From: Benoit Perigaud @.>
Date: Wednesday, November 22, 2023 at 11:58 AM
To: dbt-labs/terraform-provider-dbtcloud @.>
Cc: McGrath, Brian (CAI - Carmel) @.>, Mention @.>
Subject: Re: [dbt-labs/terraform-provider-dbtcloud] dbtcloud_environment_variable resource appears to have a caching issue, preventing re-creation of named environment variable. (Issue #213)
I actually just did a new release to fix the second use case tracked in #221https://urldefense.com/v3/__https:/github.com/dbt-labs/terraform-provider-dbtcloud/issues/221__;!!Gh9pqc0J0AYYLQ!JpboIJZl2x_3StEAaau-c9zKsbo1Xa0hWLBikgkRkzKeIh5VxOrphXH7_ZKp5n_6WiNRBe4X6XExWTJBL1TlRmnQ9jPX-6o$
—
Reply to this email directly, view it on GitHubhttps://urldefense.com/v3/__https:/github.com/dbt-labs/terraform-provider-dbtcloud/issues/213*issuecomment-1823148661__;Iw!!Gh9pqc0J0AYYLQ!JpboIJZl2x_3StEAaau-c9zKsbo1Xa0hWLBikgkRkzKeIh5VxOrphXH7_ZKp5n_6WiNRBe4X6XExWTJBL1TlRmnQrikmq2k$, or unsubscribehttps://urldefense.com/v3/__https:/github.com/notifications/unsubscribe-auth/AVSD6B46NDJ2D7VGXHCBMJ3YFYVLTAVCNFSM6AAAAAA7BQN4KCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMRTGE2DQNRWGE__;!!Gh9pqc0J0AYYLQ!JpboIJZl2x_3StEAaau-c9zKsbo1Xa0hWLBikgkRkzKeIh5VxOrphXH7_ZKp5n_6WiNRBe4X6XExWTJBL1TlRmnQULvDyFk$.
You are receiving this because you were mentioned.Message ID: @.***>

Hi @BrianMcGrathCox
Great, let me know about #221.
I am not sure if I was clear when I mentioned the support ticket, but I meant raising the ticket from dbt Cloud directly

I am not on the support team myself and won't be able to troubleshoot further.
Once you have created the support ticket, you should get a ticket number back, and if you share it here I can then have a look at the discussion between you and our support team.

Benoit,
I created the dbt cloud support ticket for the first case #213.   Please let me know if I can be of further assistance.
Your request (58204) has been updated. To add additional comments, reply to this email.
58204 is the ticket number.
From: Benoit Perigaud @.>
Date: Thursday, November 23, 2023 at 3:55 AM
To: dbt-labs/terraform-provider-dbtcloud @.>
Cc: McGrath, Brian (CAI - Carmel) @.>, Mention @.>
Subject: Re: [dbt-labs/terraform-provider-dbtcloud] dbtcloud_environment_variable resource appears to have a caching issue, preventing re-creation of named environment variable. (Issue #213)
Hi @BrianMcGrathCoxhttps://urldefense.com/v3/__https:/github.com/BrianMcGrathCox__;!!Gh9pqc0J0AYYLQ!JlbLKJBlrG9b6kIALiiHiSDQ58isdCHpMmnqcA7OnFYO5vOhtJffODdBWjMo8P_taJAjf67oI8mlASZQAEc-pYVh8z9ibS4$
Great, let me know about #221https://urldefense.com/v3/__https:/github.com/dbt-labs/terraform-provider-dbtcloud/issues/221__;!!Gh9pqc0J0AYYLQ!JlbLKJBlrG9b6kIALiiHiSDQ58isdCHpMmnqcA7OnFYO5vOhtJffODdBWjMo8P_taJAjf67oI8mlASZQAEc-pYVhyoeGCuU$.
I am not sure if I was clear when I mentioned the support ticket, but I meant raising the ticket from dbt Cloud directly
[Image removed by sender. image]https://urldefense.com/v3/__https:/user-images.githubusercontent.com/8754100/285143034-b77b4ff5-cb4c-4469-ab56-f411b58eabd6.png__;!!Gh9pqc0J0AYYLQ!JlbLKJBlrG9b6kIALiiHiSDQ58isdCHpMmnqcA7OnFYO5vOhtJffODdBWjMo8P_taJAjf67oI8mlASZQAEc-pYVhsIintgE$
I am not on the support team myself and won't be able to troubleshoot further.
Once you have created the support ticket, you should get a ticket number back, and if you share it here I can then have a look at the discussion between you and our support team.
—
Reply to this email directly, view it on GitHubhttps://urldefense.com/v3/__https:/github.com/dbt-labs/terraform-provider-dbtcloud/issues/213*issuecomment-1824015505__;Iw!!Gh9pqc0J0AYYLQ!JlbLKJBlrG9b6kIALiiHiSDQ58isdCHpMmnqcA7OnFYO5vOhtJffODdBWjMo8P_taJAjf67oI8mlASZQAEc-pYVhH_hVGYA$, or unsubscribehttps://urldefense.com/v3/__https:/github.com/notifications/unsubscribe-auth/AVSD6B6KUSUTZRP5MOJUNCDYF4FQVAVCNFSM6AAAAAA7BQN4KCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMRUGAYTKNJQGU__;!!Gh9pqc0J0AYYLQ!JlbLKJBlrG9b6kIALiiHiSDQ58isdCHpMmnqcA7OnFYO5vOhtJffODdBWjMo8P_taJAjf67oI8mlASZQAEc-pYVhoqc6dl4$.
You are receiving this because you were mentioned.Message ID: @.***>

Thanks! I will keep an eye on the support ticket.

Benoit,
I validated the fix for #221https://urldefense.com/v3/__https:/github.com/dbt-labs/terraform-provider-dbtcloud/issues/221__;!!Gh9pqc0J0AYYLQ!JlbLKJBlrG9b6kIALiiHiSDQ58isdCHpMmnqcA7OnFYO5vOhtJffODdBWjMo8P_taJAjf67oI8mlASZQAEc-pYVhyoeGCuU$.
All the test passed.  This is good to go.
Thanks,
Brian
From: Benoit Perigaud @.>
Date: Thursday, November 30, 2023 at 4:30 AM
To: dbt-labs/terraform-provider-dbtcloud @.>
Cc: McGrath, Brian (CAI - Carmel) @.>, Mention @.>
Subject: Re: [dbt-labs/terraform-provider-dbtcloud] dbtcloud_environment_variable resource appears to have a caching issue, preventing re-creation of named environment variable. (Issue #213)
Thanks! I will keep an eye on the support ticket.
—
Reply to this email directly, view it on GitHubhttps://urldefense.com/v3/__https:/github.com/dbt-labs/terraform-provider-dbtcloud/issues/213*issuecomment-1833395351__;Iw!!Gh9pqc0J0AYYLQ!MusCmloqt2rwHmRreFgKtWe67xJbnR4R5zQFU7GdoUb5kXsKdbhQsmcND0tJiS3Z2tir_we3L5Ft2zZ47LjhJmHMxYFJsZw$, or unsubscribehttps://urldefense.com/v3/__https:/github.com/notifications/unsubscribe-auth/AVSD6BY5JH2Z6ZH2GKJXTTLYHBGZRAVCNFSM6AAAAAA7BQN4KCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMZTGM4TKMZVGE__;!!Gh9pqc0J0AYYLQ!MusCmloqt2rwHmRreFgKtWe67xJbnR4R5zQFU7GdoUb5kXsKdbhQsmcND0tJiS3Z2tir_we3L5Ft2zZ47LjhJmHMtQLaWeA$.
You are receiving this because you were mentioned.Message ID: @.***>


sh:severity not supported ?

Current Behavior
~ShaclValidator~ SHACL Sail warns about  sh:severity not being supported, while code and test cases suggest otherwise
WARN org.eclipse.rdf4j.sail.shacl.ast.ShaclProperties - Unsupported SHACL feature detected sh:severity in statement
Expected Behavior
No warning on sh:severity
Steps To Reproduce
No response
Version
4.3.0-M1
Are you interested in contributing a solution yourself?
Perhaps?
Anything else?
Also happening in test cases
WARN org.eclipse.rdf4j.sail.shacl.ast.ShaclProperties - Unsupported SHACL feature detected sh:severity in statement (http://datashapes.org/sh/tests/core/misc/severity-002.test#TestShape2, http://www.w3.org/ns/shacl#severity, http://www.w3.org/ns/shacl#Info) [http://rdf4j.org/schema/rdf4j#SHACLShapeGraph

ShaclValidator hasn't been merged into develop yet. I'm still working on it here: https://github.com/eclipse/rdf4j/pull/3951

I could be wrong of course, but it looks like severity actually isn't supported (i.e. report always returns default sh:Violation, even if sh:severity is set to e.g. sh:Warning on a NodeShape)

I've implemented support for it in https://github.com/eclipse/rdf4j/pull/3951 . Could you test that branch to see if it works for you?

Great, I was working on pretty much the same thing, so I guess this ticket can be closed.
Only suggestion perhaps is to also list SHACL.SEVERITY_PROP in the ShaclSail.getSupportedShaclPredicates()

Closing since being developed in #3951


Fix filtering for tagExpression option

tagExpression option is no longer working after change in: https://github.com/webdriverio/wdio-cucumber-framework/commit/0b7e63032f7234dfa5f6383c9762d8c7288f2d26

It seems to be that tags is the preferred name for tag filtering in cucumber.js in the recent versions (see https://github.com/cucumber/cucumber-js/blob/master/docs/cli.md#tags), so I am not sure what is better: keeping the compatible setting (tagExpression) but get out of sync with cucumber.js or make the breaking change and be in sync with cucumber.js...

@gasparnagy could you please create separate issue to discuss and handle in?
Thanks!


device_map dictionary corruption in diffusers tests possibly caused by accelerate?

I suspect, but am not sure, that this is an accelerate bug
https://github.com/huggingface/diffusers/issues/790
Running the following series of pytests in the diffusers head, triggers the last two of the accelerate tests to fail, due to a corrupted device_map dictionary.
pytest ./tests/test_layers_utils.py::AttentionBlockTests::test_attention_block_default ./tests/test_models_unet.py::UNetLDMModelTests::test_from_pretrained_hub ./tests/test_models_unet.py::UNetLDMModelTests::test_from_pretrained_accelerate ./tests/test_models_unet.py::UNetLDMModelTests::test_from_pretrained_accelerate_wont_change_results
eliminating the AttentionBlockTest and all three pass.  If I eliminate test_from_pretrained_hub, then the test_from_pretrained_accelerate passes, and test_from_pretrained_accelerate_wont_change_results fails.
Deleting device_map="auto" from
>       model, _ = UNet2DModel.from_pretrained(
            "fusing/unet-ldm-dummy-update", output_loading_info=True, device_map="auto"
        )

also passes.
This occurs on Windows 11 in conda, and WSL (Windows Subsystem for Linux) Debian with current head diffusers and current head accelerate on a 3060 NVidia GPU, CUDA 11.8.  They have different pytorches, and other different libraries.
Information

[X] The official example scripts
[ ] My own modified scripts

Tasks

[X] One of the scripts in the examples/ folder of Accelerate or an officially supported no_trainer script in the examples folder of the transformers repo (such as run_no_trainer_glue.py)
[ ] My own task or dataset (give details below)

Reproduction
This is actually the testing folder for diffusers, but presumably close enough.  To reproduce run
pytest ./tests/test_layers_utils.py::AttentionBlockTests::test_attention_block_default ./tests/test_models_unet.py::UNetLDMModelTests::test_from_pretrained_hub ./tests/test_models_unet.py::UNetLDMModelTests::test_from_pretrained_accelerate ./tests/test_models_unet.py::UNetLDMModelTests::test_from_pretrained_accelerate_wont_change_results
in the root of the diffusers checkout.
Note that @patrickvonplaten was not able to reproduce the bug on whatever system he is using.
Here is the pytest output,
fail if run after attention block test.txt
Expected behavior
The tests should run with out failing/corruption of the device_map dictionary, regardless of order of tests or specific inclusion or exclusion of tests.

The bug indicates you are trying to run with device_map="auto" on a setup that does not have a GPU (or not enough GPU memory to accommodate one layer of the model). Give your report, I think the reason is that pypi does not release the CUDA memory between each tests, or maybe tries to run them in parallel automatically.

the tests aren't being ran in parallel AFAIK (there is a pypi variant that does, but not the default pypi), and the GPU is a Nvidia 3060 (mobile) with 6GB so should be plenty for the test.
Adding
torch.cuda.empty_cache()
gc.collect()

after the functions results in the tests passing.  So your theory seems to be correct.  Three of the functions are in the same submodule, so it isn't clear why the other function is interfering.


ChatDBG Success Stories

We want to hear how you use ChatDBG to debug, how it's worked for you or helped you on your various projects!
Whether it's finding tricky bugs, helping to speed up your workflow, or just making the programming process easier as a whole, let us know how ChatDBG has been able to help you.
Tell us all about your very own ChatDBG success stories right here!

I think you can consider integrating data flow to the process of trace fetching. In most cases the variable related to the root cause is not even included in the prompt sent to GPT and GPT is still not smart enough to use pdb to find this problem variable.
Anyway I like your work :) If the program runs faster, I would definitely choose ChatDBG as the upward substitution of pdb.


Investigate how to setup and document Rancher integration with new PingFederate server

We need to get ping identity server up and running to be able to validate ping still works as an auth provider for rancher 2.5.x

With the new release of rancher there is some changes to the auth configuration form than documented before.
Also pingFederate release 10.x has a changed interface
Task is to setup new ping server and figure out the steps needed to integrate a rancher setup with it.
Update the docs

This task has been completed and steps are documented on Confluence site, provided to @izaac


solves #22: add's support for Experience Fragment classes

Fixes #22

@royteeuwen thanks for the contribution!
i've done some cosmetic touches to the code to format it according to our guidelines and decreased the visibility of the classes, as they are only accessed via adaptTo() and not directly.
please have a look at the sonarcloud analysis and check if you can increase the coverage a bit to comply with the quality gate, and have a look at the two code smells:
https://github.com/wcm-io/io.wcm.testing.aem-mock/pull/23/checks?check_run_id=17642665908


Alpha SPDX 3.0 Serializer

This commit adds the beginning of an SPDX 3.0 serializer.
It is not enabled by default, applications wishing to use it need to purposedly include the package and it will auto-register with the protobom writer. Here is a sample program that converts one of the example SBOMs to SPDX3:
package main

import (
	"fmt"
	"os"

	"github.com/bom-squad/protobom/pkg/formats"
	_ "github.com/bom-squad/protobom/pkg/native/serializers/beta"
	"github.com/bom-squad/protobom/pkg/reader"
	"github.com/bom-squad/protobom/pkg/writer"
)

func main() {
	r := reader.New()
	bom, err := r.ParseFile("examples/curl.spdx.json")
	if err != nil {
		fmt.Fprint(os.Stderr, err)
		os.Exit(1)
	}

	w := writer.New()
	w.Options.Format = formats.Format("text/spdx+json;version=3.0")

	if err := w.WriteStream(bom, os.Stdout); err != nil {
		fmt.Fprint(os.Stderr, err)
		os.Exit(1)
	}
}

This package is not intended to be accurate yet, the custom SPDX3 types are private and are intended to only cover the fields needed by protobom to render its data structures. The data assignments are not yet complete and we may need to define additional elements.
This serializer will produce a nested JSON-LD document. My plan is to add an option that configures the serializer to output the SBOM in framed JSON-LD mode.
Signed-off-by: Adolfo García Veytia (Puerco<EMAIL_ADDRESS>

Here is a fragment sample of the output. Again, don't expect it to be correct yet:
{
    "type": "Sbom",
    "creationInfo": {
        "type": "CreationInfo",
        "specVersion": "3.0.0",
        "created": "2023-09-01T19:33:56.27200241-06:00",
        "dataLicense": "https://spdx.org/licenses/CC0-1.0"
    },
    "element": [
        {
            "type": "Package",
            "SpdxId": "Package-sha256-47fed8868b46b060efb8699dc40e981a0c785650223e03602d8c4493fc75b68c",
            "name": "sha256:47fed8868b46b060efb8699dc40e981a0c785650223e03602d8c4493fc75b68c",
            "description": "apko container image",
            "downloadLocation": "NOASSERTION",
            "packageUrl": "pkg:oci/curl@sha256:47fed8868b46b060efb8699dc40e981a0c785650223e03602d8c4493fc75b68c?arch=amd64\u0026mediaType=application%2Fvnd.oci.image.manifest.v1%2Bjson\u0026os=linux",
            "verifiedUsing": [
                {
                    "Type": "Hash",
                    "Algorithm": "SHA256",
                    "hashValue": "47fed8868b46b060efb8699dc40e981a0c785650223e03602d8c4493fc75b68c"
                }
            ]
        },
        {
            "type": "Package",
            "SpdxId": "Package-sha256-c6580b9a4fded304babd53a027a183c3f9d11863ba1c847971793a139801f707",
            "name": "sha256:c6580b9a4fded304babd53a027a183c3f9d11863ba1c847971793a139801f707",
            "description": "apko operating system layer",
            "packageVersion": "20230201",
            "downloadLocation": "NOASSERTION",
            "packageUrl": "pkg:oci/curl@sha256:c6580b9a4fded304babd53a027a183c3f9d11863ba1c847971793a139801f707?arch=amd64\u0026mediaType=application%2Fvnd.oci.image.layer.v1.tar%2Bgzip\u0026os=linux"
        },
        {
            "type": "Package",
            "SpdxId": "Package-ca-certificates-bundle-20230506-r0",
            "name": "ca-certificates-bundle",
            "packageVersion": "20230506-r0",
            "downloadLocation": "NOASSERTION",
            "packageUrl": "pkg:apk/wolfi/ca-certificates-bundle@20230506-r0?arch=x86_64"
        },

oh nice!  Is there an official library with SPDX3 support?  Or do we need to add that ourselves?

I don't think there is one yet. The official go module doesn't support it yet.  In fact, this is the first generator I've seen :)Adolfo García Veytia


chore(master): release 1.6.0

:robot: I have created a release beep boop
1.6.0 (2023-01-29)
Features

problem: 2315. 统计星号 (cd0a1f8)

This PR was generated with Release Please. See documentation.

:robot: Release is at https://github.com/gofromzero/leetcode/releases/tag/v1.6.0 :sunflower:


Managed Identity Azure Function

How can I use A Managed Identity from an Azure AppService to call a Azure Function (should be one of the most fundamental things)

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: f57d3177-ce9e-ebfa-03a7-45beb8ca3212
Version Independent ID: a59df23d-f3ac-9809-61d3-5741e31f020a
Content: Managed identities - Azure App Service
Content Source: articles/app-service/overview-managed-identity.md
Service: app-service
GitHub Login: @mattchenderson
Microsoft Alias: mahender

@Console32, Thanks for posting this question!
Managed identities for Azure resources is a feature of Azure Active Directory and both Azure App Service and Azure Functions are supported service. The Azure doc you're referring to outlines steps for both Azure App Service WebApp and Azure Function; so it should work with either plans.
A managed identity from Azure Active Directory (Azure AD) allows your app to easily access other Azure AD-protected resources and that identity is managed by the Azure platform.
Just to clarify, Azure Functions has three kinds of pricing plans. You can choose the one that best fits your needs: Consumption plan, Premium plan, Dedicated (App Service) plan. The hosting plan defines the features for your Function App, I would suggest you take a look into this Azure document 'Azure Functions scale and hosting' for more details on this topic.
Kindly let us know if you're looking for something else. Much appreciate your feedback.

I am not sure how this relates to my Problem.
I want to call an azure function (launch it) from inside a azure AppService (using a (non SystemAssigned) Managed Identity on the AppService side). How can this be done?

Thanks for sharing additional details. Sorry! I misunderstood the scenario.
If its just a HTTP Trigger Function, you could simply call it from App Service.
What specific triggers are you intending leverage? Or do you want to launch the Function app using the ARM API?
Just highlighting these terminologies for some additional clarify:
App Service – Service which enables you to build and host web apps, mobile back ends, and RESTful APIs.
Apps– Your individual Apps (WebApps), these apps run in App Service Plan.
App Service Plan - An App Service plan defines a set of compute resources for a web app to run.
When you choose the App Service Plan, you run the Function App just like any other App Service.

@Console32, Just checking if you have had a chance to see my above response, please let us know if you need further help/share requested detailed. Thanks!

@AjayKumar-MSFT Thanks for investigating we dropped the Idea of using a managed identity to authenticate the AppService against the AzureFunction and just use a Function Key for authentication


Creating a new primary Affiliation is not changing prior Affiliation Status to Former or adding End Date value

Case
Creating a new primary Organization Affiliation record on a Contact is not updating the existing primary Affiliation record to Former status and adding End Date value as documented.
Steps to Repro:

Navigate to a Contact Record.
If not existing, create an Organization Affiliation record (Affiliation #1). Make Primary checkbox = True and Status = Current. Set Start to a date in the past and leave End Date empty.
Once created, notice the Primary Affiliation field is populated on the Contact with that Organization name (Affiliation #1).
Create a second Organization Affiliation on the Contact record, for a different Organization (Affiliation #2). Make Primary checkbox = True and Status = Current. Set Start date to today and leave End Date empty.
Once created, notice the Primary Affiliation field is populated on the Contact with that new Organization name as expected (Affiliation #2).
View Affiliation #1 record.

What is expected:

Primary Checkbox = False
Status = Former
End Date = Today's date

What is happening:

Primary Checkbox = False (as expected)
Status = Current
End Date = blank

Affiliation #2 (Current):

Affiliation #1 (Former):

Documentation reference to changing both Status and End Date values:

**Lurch: Add

Tracking W-030243


customer-admin-fe: sub account search not persisted

A customer has reported that when searching for a sub account from the payments list, the search term is not always persisted.
Additionally, the 'Enter' key does not trigger the search - the sub account has to be clicked on (this might be solved by using a native select instead of the "fake" mui select)
Watch the video for repro steps: https://video.projul.com/watch/ZqDLs6exFYfLfkM7RVz8kD

This has since been tested by about 4 individuals including the original reporter (customer) and is not reproducible anymore. Closing.


Curious dedup failure

When run in combination with other tests, the chisel DedupSpec test passes. When run by itself sbt "testOnly chiselTests.DedupSpec", the test fails:
[info] DedupSpec:
[info] Deduplication
[info] - should occur *** FAILED ***
[info]   3 did not equal 2 (DedupSpec.scala:50)
[info] - should properly dedup modules with deduped submodules
[info] ScalaTest
[info] Run completed in 3 seconds, 2 milliseconds.
[info] Total number of tests run: 2
[info] Suites: completed 1, aborted 0
[info] Tests: succeeded 1, failed 1, canceled 0, ignored 0, pending 0
[info] *** 1 TEST FAILED ***
[error] Failed: Total 2, Failed 1, Errors 0, Passed 1
[error] Failed tests:
[error] 	chiselTests.DedupSpec
[error] (chisel3/test:testOnly) sbt.TestsFailedException: Tests unsuccessful
[error] Total time: 16 s, completed Oct 11, 2017 11:32:47 AM

The only differences in the generated firrtl in the two cases are the names of temporaries. The corresponding Verilog files differ in that the failing case contains two queue definitions where again, the only differences are in the names of temporaries.

Actually, hold off on addressing this. There may be more to it. I'm having trouble duplicating it with master branches on Linux.

This appears to be due to the differences in generating temporaries in the chisel3 invalidateapi branch. I'm closing this and opening a chisel3 issue - freechipsproject/chisel3#705


Add Placeholder to ViewModelBrick

Add the concept of a placeholder view to the ViewModelBrick
Add Tests
Add new XML for test

Codecov Report

Merging #89 into master will increase coverage by 0.54%.
The diff coverage is 100%.

@@             Coverage Diff              @@
##             master      #89      +/-   ##
============================================
+ Coverage      88.6%   89.15%   +0.54%
- Complexity      471      480       +9
============================================
  Files            29       29
  Lines          1369     1383      +14
  Branches        223      223
============================================
+ Hits           1213     1233      +20
+ Misses           76       65      -11
- Partials         80       85       +5

Impacted Files
Coverage Δ
Complexity Δ

...ava/com/wayfair/brickkit/brick/ViewModelBrick.java
89.41% <100%> (+7.72%)
25 <4> (+6)
:arrow_up:

...ain/java/com/wayfair/brickkit/brick/ViewModel.java
66.66% <0%> (ø)
8% <0%> (+1%)
:arrow_up:

...ain/java/com/wayfair/brickkit/brick/BaseBrick.java
85.1% <0%> (+1.06%)
43% <0%> (+1%)
:arrow_up:

...ain/java/com/wayfair/brickkit/brick/DataModel.java
87.5% <0%> (+6.25%)
7% <0%> (+1%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 716118f...76d1e0c. Read the comment docs.


interpolate line chart

Hi,
Is it possible to add
interpolate: "linear"
to these charts in some way?
I have sparse data and want to just smooth the line chart a bit...
Thanks

sorry.. figured it out..  please ignore.

apologies.


Having more than one instance behind a load balancer w/o stickiness breaks API pagination

Affected module
backend
Describe the bug
Having more than one instance behind a load balancer w/o stickiness breaks API pagination. The discussion in this thread https://openmetadata.slack.com/archives/C02B6955S4S/p1647544415140009 yielded, that the cryptographic pagination token for the API is created with a random seed per instance. In a load balanced environment that does not use session stickiness, this breaks the pagination and results in not being able to decrypt the token for every other instance.
The exception thrown by the server in my particular case is:
ERROR [2022-03-17 19:22:15,890] org.openmetadata.catalog.resources.databases.TableResource: Got exception: [BadPaddingException] / message [Given final block not properly padded. Such issues can arise if a bad key is used during decryption.] / related resource location: [org.openmetadata.catalog.resources.databases.TableResource.list](TableResource.java:179)

To Reproduce

create a load balanced environment with round robin distribution using at least two independent app instances2.
start an ingestion process that relies on pagination3.
wait for a pagination request being generated by one instance and then received by the other instance 4.

Expected behavior
The token should work on any instance of the app of the same cluster.
Version:

OS: alpine linux on docker, using AWS fargate
Python version: 3.9.10
OpenMetadata version: 0.9
OpenMetadata Ingestion package version: openmetadata-ingestion[redshift]==0.9.1

@xenji, thank you for reporting the bug. This will be released in 0.9.1.


Added some string untranslated "Export", "with" and "by"

I guess we should convert all these commits to 1 commit before merge


feat: simple logging

What type of pull request is this?

[x] Non-breaking code change
[ ] Breaking code change
[ ] Documentation change/addition
[ ] Tests change

Description

Introduces a simple logging config that allows an end-user to quickly get logging to console without understanding the logging library.
Changes

Add basic_logging client arg to activate logging.basic_config
Add logging_level client arg to configure the logging level

Checklist

[x] I've formatted my code with Black
[x] I've ensured my code works on Python 3.10.x
[x] I've tested my code

Better yet, how about a client arg where users can pass their own logger which we would use. Makes it especially nice for people like me who like using rich.Logger

That's not easily possible. All the files with logging would need to somehow reference your custom logic class, which will cause nightmares of circular imports.
The alternative is to just have it affect logging in the client or error handler, which seems redundant as you'd now have 2 loggers
Note: never used this rich logging thing, if I'm missunderstanding its usage lmk

Iirc I believe that was pred before and it was rejected by vote, also


Include anaconda based notebook in workbench

Support a notebook image that is derived based on the Anaconda-type install.
The notebook would support the following:

Python version: 3.8
OS: ubi
Packages: data-science + pytorch + tensorflow (all inclusive)

Related PRs:

https://github.com/openshift/release/pull/40381
https://github.com/opendatahub-io/notebooks/pull/121
https://github.com/red-hat-data-services/notebooks/pull/41


@zenstackhq/openapi: the example generated specification in the documentation is out of date and provides incorrect syntax

Description and expected behavior
The documentation for @zenstackhq/openapi should include up-to-date examples that match the documentation.
In the "Generated API paths" section of the documentation (https://zenstack.dev/docs/reference/plugins/openapi#generated-api-paths), the following syntax is mentioned:

For GET/DELETE operations, the query args is passed as JSON-stringified text in the query parameter q.

This conforms with the functionality of the plugin.
However, below that statement, an example is provided:

Check here for the generated specification for a blogging app.

This example appears to have used an older specification with a different syntax than what the current version of @zenstackhq/openapi. The generated specification does not mirror the GET syntax as described in the documentation.
In the linked example, the OpenAPI document has specified different parameters than what currently get generated, under the paths section for each get method:
      parameters:
        - name: q
          in: query
          required: true
          schema:
            $ref: "#/components/schemas/UserFindUniqueArgs"

What is currently generated by the plugin is:
      parameters:
        - name: q
          in: query
          required: true
          content:
            application/json:
              schema:
                $ref: "#/components/schemas/UserFindUniqueArgs"

The example is thus misleading as the actual code samples (as provided by Swagger UI) do not provide working syntax for the plugin's generated GET endpoints, at least with only basic configuration for the latest version (alpha.87).
Screenshots
If applicable, add screenshots to help explain your problem.
Environment (please complete the following information):
"@zenstackhq/openapi": "^1.0.0-alpha.87",
"@zenstackhq/runtime": "^1.0.0-alpha.87",
"@zenstackhq/server": "^1.0.0-alpha.87",
"zenstack": "^1.0.0-alpha.87"

"prisma": "^4.11.0",
"@prisma/client": "^4.11.0"

v18.15.0

PostgreSQL 15

Fixed with a new sample link!
https://editor.swagger.io/?url=https://gist.githubusercontent.com/ymc9/2888fae6fa60f1c7b26a8c226e6bab2f/raw/a4c78732a158a3436b6d5779695b6ab11a6edcf5/petstore.api.yaml


Improve rendering of neuron paths

Some double back on themselves (this is because their initial direction is opposite of what it should be).
Straight connections would look better with curvature at their ends.

This is in fact to do with mapmaker (AnatomicMaps/flatmap-maker#24) so closing.


Paperwork update

See https://github.com/NixOS/nixpkgs/pull/81921, which I closed involuntarily.

@symphorien: Currently on the road, will review tomorrow. Thanks for the pull request.

And now that I once again failed at git, I have to close this pull request and reopen a new one. Sorry for the inconvenience.


Remove deprecated automanagedNamespaces

AutomanagedNamespaces has been deprecated but is still being used in node-throughput and windows-tests configs. These configs are used in sig-scalability periodic jobs and sig-windows tests.

Thanks!
/good-first-issue
/help-wanted

Hi!  I'm a new contributor, and I'd love to work on this as my first issue.  Thanks!

@Palerion Please go ahead :)
In https://github.com/kubernetes/perf-tests/pull/1694 I've marked the places where automanaged namespaces could be removed.
Based on what I observed on testgrid, these jobs are still being run today:

ci-kubernetes-e2e-gce-node-throughput
ci-kubernetes-e2e-gce-node-containerd-throughput
ci-kubernetes-e2e-windows-node-throughput
ci-kubernetes-e2e-windows-node-throughput-iis

So we may want to port them over to the Namespaces api.

@Palerion Not sure if you are actually working on this since I don't see this issue assigned. If not, I would like to pick it up.

@lyzs90 I am a new contributor, can I assign this to myself since it's not assigned.

@lyzs90 I have located:
ci-kubernetes-e2e-gce-node-throughput
ci-kubernetes-e2e-gce-node-containerd-throughput
ci-kubernetes-e2e-windows-node-throughput
ci-kubernetes-e2e-windows-node-throughput-iis
in kubernetes/test-infra/config/jobs
Can you provide some hints or examples regarding how I should port them to Namespaces api?

@sgirem463 You can go ahead and assign yourself :)

These are the two configs where automanaged namespaces is still being used:

https://github.com/kubernetes/perf-tests/blob/master/clusterloader2/testing/node-throughput/config.yaml#L12
https://github.com/kubernetes/perf-tests/blob/master/clusterloader2/testing/windows-tests/config.yaml#L12

The jobs I mentioned above run off these configs. For example https://github.com/kubernetes/test-infra/blob/master/config/jobs/kubernetes/sig-scalability/sig-scalability-periodic-jobs.yaml#L47 references the node throughput config.
So the change you need to do is to switch over to use namespace instead i.e. https://github.com/kubernetes/perf-tests/blob/master/clusterloader2/testing/load/config.yaml#L97. More details of the Namespace api can be found here: https://github.com/kubernetes/perf-tests/blob/master/clusterloader2/api/types.go#L48
To verify your changes, we just need to make sure the jobs pass

So the change you need to do is to switch over to use namespace instead i.e. https://github.com/kubernetes/perf-tests/blob/master/clusterloader2/testing/load/config.yaml#L97

EDIT: the new location for reference is: https://github.com/kubernetes/perf-tests/blob/acaa23004ac96087cc7e12e2428a12b76be53e53/clusterloader2/testing/load/config.yaml#L80

/assign

Hi @lyzs90 , so the automanagedNamespaces should be replaced with namespace in a similar manner to  https://github.com/kubernetes/perf-tests/blob/master/clusterloader2/testing/load/config.yaml#L80 ?

@rahulii Yep that's right

@lyzs90 , so after making changes how do I verify those changes ?

As a new clusterLoader2 user, I'm suprised by the removal of automanagedNamespaces.  I thought it was a great feature.  Do understand correctly that it's being totally removed?  If so, why?

Also, it this feature really is to be totally removed, then docs/README.md should be updated as part of this PR, since that document still quite clearly tells new users to rely on automanaged namespaces.


DO_REPOSITION command not working

I'm controlling a drone from QGC first telling it to takeoff and then telling it to rotate to a heading of 0. The takeoff works fine, but the rotate using DO_REPOSITION does not rotate the vehicle. Flight logs are here: https://review.px4.io/plot_app?log=0704e9d3-04ac-49fb-82d1-ee6e46bed798. I can tell from QGC and replaying the flights logs that the DO_REPOSITION command does change the flight mode to HOLD. But it never rotates the vehicle.
All of the above works flawlessly in Gazebo SITL testing.

@bkueng @RomanBapst Could you please help to unblock Don? Thanks!

Also just to add more detail, these commands are sent via COMMAND_LONG, I'm not running a mission.

YOu can also use the same QGC I'm using if you want: https://github.com/DonLakeFlyer/VHFCollarTracker. Switch the instrument panel to the Tracker page. Enter in the altitude you want to takeoff to. Click Start. Vehicle will takeoff to specified altitude, then start a rotate/delay loop for a full 360 degrees based on the number of divisions you specify. And then RTL when done 360 degrees.

@DonLakeFlyer I checked the log and verified that the command arrived correctly in the firmware.
From what I see it looks like the yaw setpoint is updated in the position setpoint triplet but the yaw_valid flag is set to false. Could you also share the SITL log so that I can quickly compare the two?
@dagar Any idea, I'm not that much up to date on this navigator stuff?

Generating a SITL log. But I just realized I am not flying a completely clean master. There is a small hack in there for command routing from QGC->rPi.. It shouldn't have an affect, and the command does seem to get to the right place but let me get a log from a clean master flight. Let me make sure I didn't screw this up msyelf first. Sorry for not realizing this ahead of time.

@DonLakeFlyer If you want to try a shot in the dark you could add
rep->current.yaw_valid = true;

just after this line
https://github.com/PX4/Firmware/blob/master/src/modules/navigator/navigator_main.cpp#L341

This is failing for me in SITL now as well on clean master. So my change was not causing thing. I think I was running an older master when I was SITL testing. I'll try your change and fly SITL.

rep->current.yaw_valid = true;
That makes it work. Is it safe to try flying for real with that? Would seem so?

From doing a simple search on yaw_valid it may have a free floating value from random memory. Can't find a set for it. So it may just be lucky that it worked for me in SITL before.

@dagar @bkueng Can we get a quick fix in for that?

@DonLakeFlyer Should be safe, yes.

@DonLakeFlyer I think it might have to do something with the new flight task interface. Before using the yaw setpoint we check explicitly if it's valid or not. Probably this check was not there in the old version, but it might be something else. I think it's safe but I will follow up with a fix.

I'm going to got out a fly a current master with this change in it.

@DonLakeFlyer Good luck and good night!

Big thanks to folks for helping out so fast.

Back from flying. Worked perfectly. Thanks

@DonLakeFlyer Could you send a PR or @RomanBapst did you already put one up?

I was assuming that rep->current.yaw_valid = true; was just a hack and that somewhere the code should be also checking that yaw was actually valid. Otherwise it would not be needed at all and should be removed?

@LorenzMeier @DonLakeFlyer I did not get to it yet. I don't think it's actually a hack since other valid flags are also set just a few lines below that. The only thing I still need to check if there is a problem with uninitialized memory.

Let me just push it, if others have a better idea they can comment.

See #10294

No idea if this has been fixed for not?


[BUG]: Failed registering item game:stackrandomizer-armor:

Mod Version
BetterRuinsv0.4.2.
Game Version
v1.20.0-rc.6 (Unstable)
Platform
Linux
SP/MP
Multiplayer
Description
25.12.2024 00:37:47 [Error] Failed registering item game:stackrandomizer-armor:
25.12.2024 00:37:47 [Error] Exception: Attempted to register Item with code game:stackrandomizer-armor, but an item with such code already exists. Must use a unique code
at Vintagestory.Server.ServerMain.RegisterItem(Item item) in VintagestoryLib\Server\ServerMain.cs:line 1762
at Vintagestory.Server.ServerCoreAPI.RegisterItem(Item item) in VintagestoryLib\Server\API\ServerCoreAPI.cs:line 126
at Vintagestory.ServerMods.NoObf.ModRegistryObjectTypeLoader.b__14_0(List`1 variants) in VSEssentials\Loading\RegistryObjectTypeLoader.cs:line 239
How to reproduce
No response
Screenshots
No response
Logs
Log

Interesting thanks for the bug report here 👍.
I will take a look from remote today and prob fix it after Christmas 😅
Thanks and have nice holidays.

Okay seems that vanilla added a randomizer with the same name as betterruins so I will adjust that and patch onto the vanilla one. Will keep you updated when the update comes out but not earlier than tomorrow evening.

Thank you very much I have fixed it and it will be in the next update.
Fixed with https://github.com/AreYSerious/betterruins/commit/66976676ba3cbe741f05f35c027aa06398fc5a0d


fix(*): Updated kubefiles to match 4.12 security standards

Converting to draft until we remove all classes that use OCP 4.10

Pilot classes are removed; we should be good to go


DF Quality of Life: Advanced Spell Effects

Conflicting Module(s)
Advanced Spell Effects
Describe the conflict
The following error message shows when I startup my world.

The console shows:

Expected behavior
No conflict error message should appear.
Screenshots (Optional)
If applicable, add screenshots to help explain your problem.
Additional context (Optional)
Foundry 9.245
D&D 5E 1.5.7
The following modules were active:

This happened just this evening. This afternoon, all was working well, so it's a recent change.
From the error message, it looks like the problem is with ASE, but I'm not the best judge of that, so I thought I'd let you know as well.  Thanks!
Morgan

I just looked into Advanced Spell Effects and it appears to be that they have changed their Override to a Wrapper for the template highlight.
I'm going to close this ticket, but let me know if you still have any issues.