Templating engine woes

Our templating engine, pystache, is causing us some trouble. It breaks our readthedocs builds and other things (more here). The way it fails is configuration-dependent but it manages to fail in interesting ways no matter what.
@hategan mentioned a few options we have:

There is a promising fork of pystache whose maintainer is attempting to take over the pypi package (see pypa/pypi-support#1422). We could point to that github repo until the issue gets sorted.
There is also a newer implementation of mustache, https://github.com/noahmorrison/chevron, but it seems less used/tested. However, if the situation above does not resolve in a timely manner, this may end up being the better solution.

I wonder though if we might consider using jinja instead?

I wonder though if we might consider using jinja instead?

We want a cross-language engine and it seems like an implementation of mustache is the only available choice.

I can fork an updated version, tag, and we can use that until we either move to a different implementation, different engine, or the one currently on pypi gets fixed. Does that sound reasonable?

If you want to take on the responsibility yourself, whatever you want to do to get things working is fine by me. I just want things to work, and I would love to get the readthedocs build to pass so our CI will actually turn green.
Our mustache options don't seem great to me at first glance, although they might turn out well upon testing. We could always just try out chevron or the new pystache and see how it goes, and whether the developers are responsive, and then decide if we want to use one of them.
I'm not convinced that we should really care that much about a cross-language solution. We're not using our templating libraries for anything very complicated so it's generally a pretty straightforward translation from one templating library to another (are the delimiters {% or {{ or %%?). My guess is that re-writing the templating stuff would be like 5% of the work of a new PSI/J language implementation.
But mustache is what we have now and I like your plan.

I'm not convinced that we should really care that much about a cross-language solution. We're not using our templating libraries for anything very complicated so it's generally a pretty straightforward translation from one templating library to another

It's an unnecessary step for users on a system that needs customized templates to have to do so for every language implementation and test such copy separately. We may never really get to that point, but, if we do, I'd rather not be in that situation because of a temporary snag with a library. It may be useful to recognize that we cannot, in general, guarantee that any of our dependencies will always be nice and dandy.

A recent version of pystache is now available and PR #100 switches to it.

#100 was merged into main, so this should be fixed now.


ConfigParser issue

First of all thank you for the script. Works like a charm, saving me a lot of time.
I just have one recommendation. I'm using this script on Centos 7.5 and initially I had some issues with ConfigParser. Seems Centos/Red Hat doesn't like how config data being parsed using ConfigParser.
# ./zabbix-ldap-sync --verbose -f zabbix-ldap.conf
'%' must be followed by '%' or '(', found: '%^Geks281%^'
Traceback (most recent call last):
  File "/root/zabbix-ldap-sync/lib/zabbixldapconf.py", line 43, in __init__
    self.ldap_passwd = parser.get('ldap', 'bindpass')
  File "/usr/lib64/python3.6/configparser.py", line 799, in get
    return self._interpolation.before_get(self, section, option, value, d)
  File "/usr/lib64/python3.6/configparser.py", line 394, in before_get
    self._interpolate_some(parser, option, L, value, section, defaults, 1)
  File "/usr/lib64/python3.6/configparser.py", line 444, in _interpolate_some
    "found: %r" % (rest,))
configparser.InterpolationSyntaxError: '%' must be followed by '%' or '(', found: '%^Geks281%^'
Configuration issues detected in zabbix-ldap.conf`

So probably is a good idea changing the way config data beaing parsed with RawConfigParser.

solved


khard: 0.18.0 -> 0.19.0

Description of changes
https://github.com/lucc/khard/blob/develop/CHANGES
Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Priorities
Add a :+1: reaction to pull requests you find important.

Result of nixpkgs-review pr 270156 run on x86_64-linux 1

3 packages built:

khard
khard.dist
lbdb


DiscoJuice fails

At CLARIN.SI we have users from Croatia that would wish to submit an item, but they cannot find their identity provider on the DiscoJuice Log-in. It might be that for some reason there in fact aren't any, but I tried using DiscoJuice to verify this, and found that its behaviour is very, hm, strange.  I tried, first, at CLARIN.SI, and then at lindat.mff.cuni.cz, and the behaviour is in both cases the same:

if you type in Croatia into the "Show providers in", the list of providers does not change at all, as far as I can see, rathen than it becoming empty, which would be the expected behaviour
if you type in Czech republic into the "Show providers in",  the list does change, but in a very strange fashion: there iz Charles on the first place, but then the next IdP from CZ is on the 7th place, before that you have IdPs mostly from the US, then 8th and 9th place are again some other IdPs, then comes again somebody from CZ, then again some other etc. So, those from CZ are not on the top as one would expect, but "scattered somewhere towards the top"

The "Locate me" button does not work either: it does put Jožef Stefan Institute at the top (but this might be because I have previously logged in via this IdP), but in the second place there is one from France, then Germany, then USA, i.e. some random list, even though there are lots of IdPs in Slovenia.
Finally, if I click on DiscoJuice at the foot of the log-in page, I get "Version: 2.1 (2012-02-07 19:18)" which is scary, even more scary is if I click there on "Read more about DiscoJuice" i.e. https://discojuice.org/ it turns out this domain is dead.
So, if DiscoJuice has been discontinued, and does not work properly, is there an alternative?
It could well be that you are aware of this problem, but maybe it is good to have an issue about it here as well, and I couldn't find a previous one.

Hi the same with flags icons. Dieter warned us that discojuice was going to meet its end of life. It's domain seems for sale. Dieter also suggests to use http://discovery.clarin.eu/. EURAC did something. I think this should be fixed.


Missing .json file and typo on inference code

Hi team,
Loving the paper – really cool stuff! I'm getting set up to try out the inference code, but I've noticed the .json config file is missing in the checkpoint download. Could you kindly provide it?
Also, a small thing – there could be a typo in the inference script.
python3 separate.py --input-signal /path/to/file.wav --clusters 5 --scheduler 4

The readme says --input-signal, on separate.py suggests it should be --input_signal.
Appreciate your time and help. I look forward to diving into your model!

Hello! Sorry for the late reply and thanks for your interest on our work :)
First, in the README you can find a link to download the weights. I am attaching it right here as well. Other than that, you can use the model for inference through compIAM: https://github.com/MTG/compIAM. Weights should be automatically downloaded in this case.
About the typo... actually to execute the code through terminal you cannot use _, but then in the python code, the symbol - cannot be used for variable names, so argument names get the symbol - converted to _ for the variable names. Running it like specified in the README should work... otherwise please let us know!


Integration Test - Release - 2018/07/17 03:11:01

Auto create for integration test. AnotherAuthorUpdatedArticleFlow

@PRMergerTest1 : Thanks for your contribution! The author, @v-caxian, has been notified to review your proposed change.

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

csidevdocs-public/IntegrationTest/BuildIntegartionTestFiles/ChangeSentToAuthor.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Execute cells FAILED on Kubernetes pod

Issue Type: Bug
When running a cell in an existing notebook (i.e. one that is saved somewhere) on a Kubernetes pod, the cell does not execute. The following is logged to Remote Extension Host:
[2021-06-29 04:51:14.316] [exthost] [error] NotebookController[1] execute cells FAILED {}

Furthermore, the output in developer tools shows:
Error: duplicate execution for vscode-notebook-cell://k8s-container...

I can provide the full output if that would be helpful.
Note: In a fresh, unsaved notebook created using Jupyter: Create new blank notebook, the cells execute without problem. The problem only manifests once the notebook is saved.
Steps to reproduce:

Open VSCode on a Kubernetes pod
Create a blank notebook
Save the notebook to disk somewhere
Attempt to run the first cell

Extension version: 2021.6.999662501
VS Code version: Code 1.57.1 (507ce72a4466fbb27b715c3722558bb15afa9f48, 2021-06-17T13:28:32.912Z)
OS version: Darwin x64 20.5.0
Restricted Mode: No
Remote OS version: Linux x64 5.4.89+

System Info

Item
Value

CPUs
Intel(R) Core(TM) i7-8850H CPU @ 2.60GHz (12 x 2600)

GPU Status
2d_canvas: enabledgpu_compositing: enabledmetal: disabled_offmultiple_raster_threads: enabled_onoop_rasterization: enabledopengl: enabled_onrasterization: enabledskia_renderer: disabled_off_okvideo_decode: enabledwebgl: enabledwebgl2: enabled

Load (avg)
2, 2, 3

Memory (System)
16.00GB (0.02GB free)

Process Argv
--crash-reporter-id 3253bfa9-f4f2-4dc6-9afe-91a2465ce2f7

Screen Reader
no

VM
0%

Item
Value

Remote
pod-sabri in pod-sabri (gcr.io/hai-gcp-fine-grained/default)

OS
Linux x64 5.4.89+

CPUs
Intel(R) Xeon(R) CPU @ 2.20GHz (8 x 2199)

Memory (System)
29.40GB (12.80GB free)

VM
0%

A/B Experiments
vsliv368:30146709
vsreu685:30147344
python383cf:30185419
pythonvspyt700cf:30270857
pythonvspyt602:30300191
vspor879:30202332
vspor708:30202333
vspor363:30204092
pythonvspyt639:30300192
pythontb:30283811
pythonvspyt551cf:30311713
vspre833:30321513
pythonptprofiler:30281270
vshan820:30294714
pythondataviewer:30285071
vscus158:30321503
pythonvsuse255cf:30323309
vscorehov:30309549
vscod805cf:30301675
vscextlangct:30322307
binariesv615:30325510

I'm having this issue too

@seyuboglu Could you actually pull the logs from the Jupyter tab of the VS Code output window? That as well as the rest of the output from the developer tools would be helpful. Odd that it's not having an issue until after it's saved.

Here are the logs:
jupyter_output_logs.txt
dev_tools_log.txt
Other things to note:
I have the following in my workspace settings:
"jupyter.jupyterCommandLineArguments": [
			"--no-browser",
			"--allow-root",
			"--config=/home/sabri/.jupyter/jupyter_notebook_config.py",
		],

and I updated my Jupyter config via
jupyter notebook --generate-config

echo "c = get_config()
c.NotebookApp.ip = '*'
c.NotebookApp.open_browser = False
c.NotebookApp.port = 8004" >> /home/sabri/.jupyter/jupyter_notebook_config.py

Thanks for the logging. It does look to me like it's failing to find an open port at the port specified (rolling from 8004 to 8011):

http://pod-sabri-t4-4:8011/

I don't believe that's the issue though. It looks to me like this is the relevant error:
Info 2021-06-30 02:06:22: Cell Index:0, state:undefined, exec: 17. Ready to execute
Info 2021-06-30 02:06:22: Cell Index:0, state:undefined, exec: 17. Before Execute individual cell
Info 2021-06-30 02:06:22: Cell Index:0, state:undefined, exec: 17. Start execution
Info 2021-06-30 02:06:22: Cell Index:0, state:undefined, exec: 17. After Execute individual cell undefined
Error 2021-06-30 02:06:22: Failed to execute cells in CellExecutionQueue Error: Can't apply edits to unknown notebook model: vscode-remote://k8s-container%2Bcontext%3Dgke_hai-gcp-fine-grained_us-west1-a_cluster-1%2Bpodname%3Dpod-sabri-t4-4%2Bnamespace%3Ddefault%2Bname%3Dpod-sabri%2Bimage%3Dgcr.io%252fhai-gcp-fine-grained%252fdefault/home/sabri/code/domino/scratch/sabri/Untitled.ipynb
    at xr.$applyEdits (file:///Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:2524:13873)
    at r._doInvokeHandler (file:///Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:1832:11905)
    at r._invokeHandler (file:///Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:1832:11597)
    at r._receiveRequest (file:///Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:1832:10259)
    at r._receiveOneMessage (file:///Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:1832:9062)
    at file:///Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:1832:7166
    at n.fire (file:///Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:60:1835)
    at a.fire (file:///Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:76:16288)
    at i._receiveMessage (file:///Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:76:21546)
    at file:///Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:76:18432
    at n.fire (file:///Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:60:1835)
    at u.acceptChunk (file:///Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:76:13649)
    at file:///Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:76:12997
    at file:///Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:634:139050
    at n.fire (file:///Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:60:1835)
    at FileReader._fileReader.onload (file:///Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:634:137667)
Info 2021-06-30 02:06:22: Cancel pending cells
Info 2021-06-30 02:06:22: Install Missing Dependencies, Class name = w, completed in 450ms, has a falsy return value, Return Value: undefined

Looks very similar to this issue:
https://github.com/microsoft/vscode/issues/119891
That URI looks a touch odd to me for the file:
vscode-remote://k8s-container%2Bcontext%3Dgke_hai-gcp-fine-grained_us-west1-a_cluster-1%2Bpodname%3Dpod-sabri-t4-4%2Bnamespace%3Ddefault%2Bname%3Dpod-sabri%2Bimage%3Dgcr.io%252fhai-gcp-fine-grained%252fdefault/home/sabri/code/domino/scratch/sabri/Untitled.ipynb
@roblourens Looks like you had some context on the linked issue. Anything look off on this URI here?

There's another issue with that sort of URI https://github.com/microsoft/vscode-remote-release/issues/5250. It's possible that the weird URI format could cause an issue like this too. Sounds like it will be fixed in the Containers extension

Looks like this has been fixed with the most recent VS Code + Containers Extension release. Please ping here if you are still seeing it with everything updated.


triangle: incorrect test in some tracks

Please check if there's a test that states that a triangle with sides 2, 4, 2 is invalid. The triangle inequality states that for any triangle, the sum of the lengths of any two sides must be greater than or equal to the length of the remaining side. If this doesn't affect this track, go ahead and just close the issue.

Tested and legal in this track.

nice! thanks


Fix handling of viss-address parameter

This should fix #64
Now the parameter has an effect, and bind adresses for GRPC API and VISS server can be different, in case you want to expose these services on different interfaces.

Anyone?


Code reproduction

Hello, thank you very much for your excellent work, I am going to reproduce your work in the near future, I see that you are training on 4 A6000GPU with 48GB video memory, I have an A5000 server, can I reproduce it successfully

Yes, you can decrease the size in the scale_batch_map. Please note that the size in the scale_batch_map should be divisible by the batch size."


do animixplay and  gogoanime

animix play?

also i challenge you to make a quick and reliable color picker /screen capture/snip  with cli  commands on windows
Ill even pay ya

also i challenge you to make a quick and reliable color picker /screen capture/snip with cli commands on windows
Ill even pay ya

i think there is probably already a solution for this out. and if not, you can try using ffmpeg. it can dp all of your requested things besides the color picking

gogoanime support is partially given. If you choose a video provider which is supported by this addon, it works as it should. I nearly all of the newer gogoanime episodes have doodstream as a video provider, which will be supported in the next version.
animixplay won't get support (in the near future) since it's simply too complex. Multiple streaming providers (it uses gogoanime as well as crunchyroll, probably some more which I haven't noticed too), multiple stream resolutions, ... .


[Task] Support redirect to external fallback URIs instead of URIs in bootstrap for sentinel plugin.

Description
Same as #2937 , sentinel plugin also has the same issue that it doesn't work when setting fallback URIs not in bootstrap. The goal of this task is to support the same feature in sentinel plugin, as well as doing some refactor to reduce duplicated codes.
Task List

support redirect to URIs not in bootstrap.
refactor to reduce dup codes in resilience4j and sentinel plugin.
add related unit test.
add related integrated test.

Please assign it to me and I'll finish it later, thanks~


Being implementing challenge and claim methods on the SmartContractWallet

If either party wants to end the relationship, they:

stop transacting off chain

call challenge.
(optional) the other party calls challenge() with a later state
providePreimage()
someone calls claim(). the intermediary is ejected with their money.

challenge(state)

set contract.Status == Challenge
start timeout
owner and intermediary have opportunity to set latest TurnNumber. fingerprint
after timeout expires, move status to Finalized

claim()

require status == Finalized
loop over any remaining HTLCs, compute moneyFromHTLCForMe, moneyFromHTLCForThem
compute netPayout = state.intermediaryBalance + moneyFromHTLCForThem - moneyFromHTLCForMe
execute payout
set intermediary = 0

This functionality has been implemented but only lightly tested. I'll create a separate issue for testing.


Fix coverage computation

Closes #2266. This time hopefully for real!

Coveralls is back in the PR checks again! Merging without review since this is just about the Travis build process.


Yeoman generator

It is possible to have a yeoman generator(or update the templates of the official generator-angular) to scaffold or update Angular projects, based on this styleguide?

generator is here http://jpapa.me/yohottowel

do you have a grunt version?


ciao-cli: use correct identity endpoint for unscoped token

When using an unscoped token, you need to use a different
endpoint to list projects than when you have a scoped token.
Fixes: #864
Signed-off-by: Kristen Carlson Accardi<EMAIL_ADDRESS>

Coverage decreased (-0.03%) to 64.865% when pulling 3d69c236950f2210d238090b6de8fe4992f4d996 on kaccardi:topic/keystone-container-singlevm into 7140076e4f19aa09e878d45192b405c5f8bad931 on 01org:master.

This patch works fine in conjunction with the Single VM Keystone changes #813 but does not work without them.  The BAT tests fail on Single VM when just this patch is merged.  So we need to delay merging until #813 gets merged.


Can't load widget view

Brief bug description
I chose the bug template, but I think there's a good chance this is an error on my part. I have been using the Rich Text Widget from the NuGet package on my site. I received new requirements to add a couple options to the widget configuration. I can’t do that with the package, so I removed the package and downloaded the source, but I can't get it to run after I build it.
Repro steps

Download v1.2.1-richtext.
Copy files into my solution directory.
Build Kentico.Components.sln
In my project, add references to the just-built Kentico.InlineEditor.RichText.dll,Kentico.Widget.RichText.dll, and Kentico.Widget.RichText.Views.dll
Build my project.
View a page with a previously existing Rich Text widget on it.
Get an exception (stack trace below)

I attempted to create a new page to test if a new instance of the widget would work, but I can't create a page; I get the same exception.
Expected behavior
Rich Text widgets should work as they did with the package installed.
Test environment
Kentico Xperience 12.0.90 MVC
Additional context
Exception information:
Exception type: InvalidOperationException
Exception message: Embedded view type was not found for view path '~/Views/Shared/Kentico/Widgets/_RichTextWidget.cshtml'.
at Kentico.Web.Mvc.EmbeddedViewLoader.LoadMappingTable()
at Kentico.Web.Mvc.EmbeddedViewMapping.LoadMappping()
at System.Lazy1.CreateValue()    at System.Lazy1.LazyInitValue()
at Kentico.Web.Mvc.EmbeddedViewBootstrapper.EmbeddedViewModuleInitializer.Init(HttpApplication context)
at System.Web.HttpApplication.RegisterEventSubscriptionsWithIIS(IntPtr appContext, HttpContext context, MethodInfo[] handlers)
at System.Web.HttpApplication.InitSpecial(HttpApplicationState state, MethodInfo[] handlers, IntPtr appContext, HttpContext context)
at System.Web.HttpApplicationFactory.GetSpecialApplicationInstance(IntPtr appContext, HttpContext context)
at System.Web.Hosting.PipelineRuntime.InitializeApplication(IntPtr appContext)

Hi @JBratteli, sorry for the delayed response, I've just tested the rich text widget built from the source files on the same instance v12.0.90 and had no issues.
This is what i did:

Downloaded and extracted this repository
Open the solution in VS and build it
Open the solution folder in powershell and run npm run i and then npm run build
Go into the ~\SandboxSite\bin folder and copy the Kentico.InlineEditor.RichText.dll, Kentico.Widget.RichText.dll and Kentico.Widget.RichText.Views.dll into my MVC site project's bin folder
Go to ~\SanboxSite\App_Data\Global\Resources and copy Kentico.InlineEditor.RichText.resx and Kentico.Widget.RichText.resx to the same path in the MVC project ~\MyMvcSite\App_Data\Global\Resources
Copy the content files from ~\Kentico.InlineEditor.RichText\Content and ~\Kentico.Widget.RichText\Content to the corresponding content folder in my MVC project ~\MyMvcSite\Content

I got it working, thank you.


fix: console error old-dot to new-dot new workspace transition

Details

Creating workspace from OldDot to NewDot generates console errors, as we are trying to store React elements into Onyx. Another console error is for an initial param openOnAdminRoom where we are passing prop as 'true' instead of boolean true. So we are fixing this two errors in this PR.

Fixed Issues

$ https://github.com/Expensify/App/issues/28262
PROPOSAL: https://github.com/Expensify/App/issues/28262#issuecomment-1735724144
Tests

This PR can be tested on Web only.
Open www.expensify.com then login with user A.
Open staging.new.expensify.com then login with user B.
Now goto Settings Tab > Workspaces.
Now in Workspaces goto Group tab and press New Workspace on top right.
Select Free workspace type.
Now as new tab opens up copy the exisiting URL and change its domain to staging.new.expensify.com / http//localhost:8080.
Now open inspect options and go to Console's tab verify no console are visible.

[X] Verify that no errors appear in the JS console

Offline tests

There won't be no Offline Steps as website won't open in Offline

QA Steps

This PR can be tested on Web only.
Open www.expensify.com then login with user A.
Open staging.new.expensify.com then login with user B.
Now goto Settings Tab > Workspaces.
Now in Workspaces goto Group tab and press New Workspace on top right.
Select Free workspace type.
Now as new tab opens up copy the exisiting URL and change its domain to staging.new.expensify.com / http//localhost:8080.
Now open inspect options and go to Console's tab verify no console are visible.

[X] Verify that no errors appear in the JS console

PR Author Checklist

[X] I linked the correct issue in the ### Fixed Issues section above
[X] I wrote clear testing steps that cover the changes made in this PR

[X] I added steps for local testing in the Tests section
[X] I added steps for the expected offline behavior in the Offline steps section
[X] I added steps for Staging and/or Production testing in the QA steps section
[X] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[X] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[X] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[X] I included screenshots or videos for tests on all platforms
[X] I ran the tests on all platforms & verified they passed on:

[X] Android: Native
[X] Android: mWeb Chrome
[X] iOS: Native
[X] iOS: mWeb Safari
[X] MacOS: Chrome / Safari
[X] MacOS: Desktop

[X] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[X] I followed proper code patterns (see Reviewing the code)

[X] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[X] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[X] I verified that comments were added to code that is not self explanatory
[X] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[X] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[X] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[X] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[X] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[X] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[X] I verified the JSDocs style guidelines (in STYLE.md) were followed

[X] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[X] I followed the guidelines as stated in the Review Guidelines
[X] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[X] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[X] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[X] I verified that if a function's arguments changed that all usages have also been updated correctly
[X] If a new component is created I verified that:

[X] A similar component doesn't exist in the codebase
[X] All props are defined accurately and each prop has a /** comment above it */
[X] The file is named correctly
[X] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[X] The only data being stored in the state is data necessary for rendering and nothing else
[X] If we are not using the full Onyx data that we loaded, I've added the proper selector in order to ensure the component only re-renders when the data it is using changes
[X] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[X] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[X] All JSX used for rendering exists in the render method
[X] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[X] If any new file was added I verified that:

[X] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[X] If a new CSS style is added I verified that:

[X] A similar style doesn't already exist
[X] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))

[X] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[X] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[X] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[X] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[X] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[X] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[X] I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

https://github.com/Expensify/App/assets/78416198/de972d5c-f1b0-4f38-8584-f9e9b9067cd9

MacOS: Desktop

@ArekChr I won't be able to add video's for other platforms as this can only be tested on Web Platform.

@mollfpr I believe there may have been a mix-up in assigning me as a reviewer for this PR. Would you prefer to take over the review, or would you like me to proceed with it?

Reviewer Checklist

[ ] I have verified the author checklist is complete (all boxes are checked off).
[ ] I verified the correct issue is linked in the ### Fixed Issues section above
[ ] I verified testing steps are clear and they cover the changes made in this PR

[ ] I verified the steps for local testing are in the Tests section
[ ] I verified the steps for Staging and/or Production testing are in the QA steps section
[ ] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[ ] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[ ] I checked that screenshots or videos are included for tests on all platforms
[ ] I included screenshots or videos for tests on all platforms
[ ] I verified tests pass on all platforms & I tested again on:

[ ] Android: Native
[ ] Android: mWeb Chrome
[ ] iOS: Native
[ ] iOS: mWeb Safari
[ ] MacOS: Chrome / Safari
[ ] MacOS: Desktop

[ ] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[ ] I verified proper code patterns were followed (see Reviewing the code)

[ ] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[ ] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[ ] I verified that comments were added to code that is not self explanatory
[ ] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[ ] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[ ] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[ ] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[ ] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[ ] I verified the JSDocs style guidelines (in STYLE.md) were followed

[ ] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[ ] I verified that this PR follows the guidelines as stated in the Review Guidelines
[ ] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[ ] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[ ] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[ ] If a new component is created I verified that:

[ ] A similar component doesn't exist in the codebase
[ ] All props are defined accurately and each prop has a /** comment above it */
[ ] The file is named correctly
[ ] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[ ] The only data being stored in the state is data necessary for rendering and nothing else
[ ] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[ ] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[ ] All JSX used for rendering exists in the render method
[ ] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[ ] If any new file was added I verified that:

[ ] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[ ] If a new CSS style is added I verified that:

[ ] A similar style doesn't already exist
[ ] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)

[ ] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[ ] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[ ] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[ ] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[ ] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[ ] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[ ] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

@Li357 @mollfpr when are we planning to merge this. As i would want the bonus if its under our reach.

Any updates here ?

Friendly bump @Li357 for final review

@Li357 are we holding onto this PR for something?

Merged, sorry for the delay since I'm working part-time. You'll still get the bonus if that applies, we'll exclude any extra days it took me to get to this.

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to staging by https://github.com/Li357 in version: 1.3.94-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
failure ❌

🕸 web 🕸
success ✅

🚀 Deployed to staging by https://github.com/Li357 in version: 1.3.94-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
failure ❌

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/Beamanator in version: 1.3.94-2 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to staging by https://github.com/Li357 in version: 1.3.95-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/puneetlath in version: 1.3.95-9 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


Deprecated configfile param without explanation in the doce

While the deprecation of the `init_app(configfile) param  has render it non-functional, the documentation of thios project does not mention that fact.  Actually the examples in README still include it.  Also no explanation is given as to why this change was needed.  Finally, no PyPi-release exists (correct?).

While the deprecation of the `init_app(configfile) param has render it non-functional, the documentation of thios project does not mention that fact.

Sorry about that!

Finally, no PyPi-release exists (correct?).

That should not be the case - appconfig is released exclusively on PyPI: https://pypi.python.org/pypi/flask-appconfig . Is there something broken I am not aware of?

Is there something broken I am not aware of?

But that is from v0.11.1 from Oct 2015,.
So the deprecation has not been officially publish, correct?


loremIpsum method does not exists

loremIpsum method does not exists albeit explained in readme.md

Hey @kursatturkay, thank you for reporting, and sorry for the delay.
I've open a PR to fix it, could you make a review ?
PR:3

Fixed #3


Update account description and transaction type description to pull from MDM

Definition of Ready

[x] Does this meet the INVEST criteria?
[x] Does this have a clearly defined user?
[x] Does this have an estimate?
[x] Does this have acceptance criteria?
[x] Does this have sufficient context for the specific functionality being developed (design, business rules, etc.)
[x] Does this have a dev link been provided in the design?
[x] Is this traceable to a feature, epic, or PI?

User Story
As a CAMPD user I want the account description to pull from the MDM table so that the data is consistent
Acceptance Criteria
Given that a user has made a GET request to the allowance holdings, account info, or allowance transactions endpoint
When the request is executed
Then the system returns the appropriate data elements
AND the data elements adhere to the Master data dictionary
Development Notes
Update the allowance holdings, account info, and  transactions endpoint account descriptions field to be pulled from the MDM table instead of the account fact/transaction fact tables
Update transaction type for allowance transactions. For testing ensure that the endpoints are still returning the correct data elements and that OTC and NBP data is returning
Dependency: Need to wait on the database to be refreshed. The db will be refreshed during the weekend of 1/21. Cannot conduct manual testing until the db has been refreshed
Does this Story require 508 Testing?

[ ] Implementing a new authoring tool that will produce code / content for the application
[ ] Implementing a 3rd party widget that will be part of the application
[ ] Adding new / updating custom functionality
[ ] Adding new / updating a page template
[ ] Adding new / replacing existing functionality (unless the replacement has already passed 508 testing)
[ ] Full Site Review prior to a scheduled EPA 508 review
[ ] Planning a video that will appear on the application
[ ] Producing a video that will appear on the application
[ ] Producing Training materials
[ ] Producing documents

Context
Testing
Test Case:
Tester:
Definition of Done

[ ] Have all Acceptance Criteria been agreed to and validated by the scrum team?
[ ] Has the code been unit tested and peer reviewed?
[ ] Have the functional tests been executed?
[ ] Have all defects been reviewed and dispositioned, resolved, or deferred?
[ ] Is the user story ready to be deployed to the test/staging environments?

Allowance Transactions
https://api.epa.gov/easey/dev/account-mgmt/allowance-transactions?api_key=T8r7OW4f12XtWKLY7CPgKmKu1WoP3TVG0x4eqmlB&page=3000&perPage=50&programCodeInfo=NBP|OTC&transactionBeginDate=1993-03-23&transactionEndDate=2018-03-30
https://api.epa.gov/easey/dev/account-mgmt/allowance-transactions?api_key=T8r7OW4f12XtWKLY7CPgKmKu1WoP3TVG0x4eqmlB&page=1&perPage=50&programCodeInfo=NBP|OTC&transactionBeginDate=1993-03-23&transactionEndDate=2018-03-30


Laravel - update() function always return true

Laravel Version: 5.6
PHP Version: 7.2
Database Driver & Version: Mysql

Description:
If I use
User::find($id)->update(['column'=>'value']);
I always get true, even when I don't have this column in database.
If I use
where('id',$user_id)
instead of find($id), I will get error like "Column not found"
Shouldn't ::find() do the same as where()?
Same problem (3 years ago):
https://stackoverflow.com/questions/33053282/laravel-eloquent-update-function-always-return-true

the difference between find and where is find will return an instance of your user model, where returns a query builder
in 1st example i expect that fillable/guarded attributes are causing the parameter to get discarded, so you are essentially calling update on an unchanged model
column not found error on the query builder update suggests it did actually try to set the column, which if it isnt in your fillable fields seems like an issue.

@rs-sliske I added question - I think that ::find() should do the same as ::where()

find is basically just an alias for where('id', $id)->first()

@rs-sliske but with connect to update() i think it should check for existing columns etc too, if it's possible

User::find($id)->update(['column'=>'value']) will return exception if column doesn't exist, however seems like your model attributes are guarded which will make the query not even run.
when using where it's different, you're not using an instance of the model and thus no guarded attributes are considered.
Hope this clears everything.


[chore] Minor readability in maintainers & contributors

Thanks a lot, @franklinchou. It is great to have someone reading and improving the documentation.


link to codelcimate docs in readme

cc @codeclimate/review

nice :+1:
FWIW, you might want to extract the docs URL to a named markdown URL at the bottom of the page or something. If we ever ended up changing that URL for any reason, there's an excellent chance we'd remember to change one of these & not the other.
I believe the syntax works like this:
[RuboCop engine documentation][cc-docs-rubocop]

[cc-docs-rubocop]: https://docs.codeclimate.com/docs/rubocop

@wfleming thanks great idea!
Added link

:shipit:


gather_nd result seems not correct

with data shape [6, 4, 3] , indices shape [6, 2], gather_nd will throw error.
with data shape [1, 4, 1],  indices shape [3, 2], result shape is [2].

cc @kazum @icemelon9

gather_nd in relay follows the mxnet semantics where each column indicates the indices in the data.

Close for now then, please feel free to open new thread on https://discuss.tvm.ai/ for followup discussions :)


bug:

Describe the bug
TFSec reports that IAM policy document uses sensitive action on wildcarded resource for actions that cannot be restricted to a specific ARN:

logs:ListLogDeliveries
logs:CreateLogDelivery
logs:GetLogDelivery
logs:GetLogDelivery
logs:UpdateLogDelivery
logs:DeleteLogDelivery

To Reproduce
Steps to reproduce the behavior:

Create a policy like this including actions such as logs:CreateLogDelivery on a wildcarded resource (for full code see Example Code below)
Run tfsec
The following issue is detected: Result #1 HIGH IAM policy document uses sensitive action 'logs:ListLogDeliveries' on wildcarded resource '*'

Expected behavior
tfsec shouldn't report on these since they can only be used with wildcard resources. We contacted AWS support to confirm, and they also linked the relevant documentation page: https://docs.aws.amazon.com/service-authorization/latest/reference/list_amazoncloudwatchlogs.html#amazoncloudwatchlogs-actions-as-permissions
Quote from this page:
The Resource types column indicates whether each action supports resource-level permissions. If there is no value for this column, you must specify all resources ("*") in the Resource element of your policy statement.
This is indeed the case for each of the actions reported above.
Output of your tfsec command with --debug flag
N/A
System Info

tfsec version: v1.28.1
terraform version: v1.3.6
OS: Manjaro Linux

Example Code
data "aws_iam_policy_document" "test" {
  statement {
    actions = [
      "logs:ListLogDeliveries",
      "logs:CreateLogDelivery",
      "logs:GetLogDelivery",
      "logs:UpdateLogDelivery",
      "logs:DeleteLogDelivery",
    ]
    resources = [
      "*"
    ]
  }
}

resource "aws_iam_policy" "test" {
  name = "test"
  policy = data.aws_iam_policy_document.test.json
}

This is a problem and should be fixed


Fix the link to LLDB installation instructions

Fix the link to LLDB installation instructions in "Prerequisites"
section to correctly lead to the relevant wiki page. Current link
refers to a non-existing "Installing LLDB" section in README.md.

Thanks!


Bump up contiv/libOpenflow version

Bump up contiv/libOpenflow version to fix a race issue in creating MatchField.
The fix in contiv/libOpenflw is https://github.com/contiv/libOpenflow/pull/10
Fixes #285

/test-all

@wenyingd is the e2e failure related?

/test-e2e

@tnqn  It seems the e2e failure is none busyness of this change.
It is the known failure in TestIPBlockWithExcept case, and the cause should be the traffic might be sent out before Openflow entries are completed.


Update many files to PEP8

Updated nltk/tokenize/moses.py, regexp.py, simple.py, stanford.py, treebank.py, util.py, and sexpr.py to PEP8. Updated nltk/test/* as well. Also updated nltk/grammar.py and featstruct.py. Also twitter/common.py and twitter/util.py.

Thanks @wardbradt - this is great!


unable to install cloudfare resource

I have following dependencies in our package json
{

  "dependencies": {
     "@pulumi/aws": "2.12.0",
     "@pulumi/awsx": "0.20.0",
     "@pulumi/cloudflare": "2.6.0",
     "@pulumi/pulumi": "2.7.0"
  }

}

i got the following error when pulumi up is issued
Diagnostics:
  pulumi:providers:cloudflare (default_2_12_0):
    error: no resource plugin 'cloudflare-v2.12.0' found in the workspace or on your $PATH, install the plugin using `pulumi plugin install resource cloudflare v2.12.0`

So i tried the above suggested command pulumi plugin install resource cloudflare v2.12.0 but it threw HTTP 403 error.
error: [resource plugin cloudflare-2.12.0] downloading from : 403 HTTP error fetching plugin from https://get.pulumi.com/releases/plugins/pulumi-resource-cloudflare-v2.12.0-darwin-amd64.tar.gz

I tried this command with several previous versions and the last version it seems to work is v2.7.0.
I wonder if the plugin files are not pushed or made available to public.
Node version: v12.16.3
Pulumi CLI version: v2.13.0

Hey @koneru9999
Sorry about this issue you are getting - I am not sure why this is and will need to look into it
The latest release of cloudflare is v2.7.0 so that message is incorrect to download v2.12.0
Paul

@stack72
I had the same concern initially and it seems the version seems to be getting from @pulumi/aws dependency.
If i change my @pulumi/aws dependency to 2.11.0, then it tries to install resource plugin 'cloudflare-v2.11.0'
Hope this helps in troubleshooting.

@stack72 so is this going to be looked at anytime soon? We had to downgrade our @pulumi/aws plugin so that we can use it with this plugin, which introduced other issues into our stack.
We would appreciate it if you can let us know whether there is any plans to resolve this issue or if we should remove it from our implementation. Thanks.

Trying this with the latest version of the CLI and the above mentioned package versions, I'm unable to reproduce this. I also cannot reproduce this with the latest versions of @pulumi/aws and @pulumi/cloudflare
Happy to re-open and take a look if anyone is able to provide a reliable repro.


Handle new git behavior requiring count parameter

@paulirish
I ran into an issue today with git-recent where it was giving me an error:
error: option `count' expects a numerical value

I believe my build environment upgraded git with a new constraint on the --count parameter, as shown in this commit:
https://github.com/git/git/commit/20aa7c594fbc2e36476daae2f53d7c020306c62c#diff-15a33e465ac44642a84b00186e663b7f
Passing a count of 0 appears to behave the same way it used to when the count was missing. It does still render some strange (null) values (with or without the -n parameter), but I suspect that's yet another fix that may need to happen in addition to this one.

I just realized that the (null) is the branch name - I'll look into another update to get that fix into this PR as well.  Will update you when ready.

@timjim-kr oh thanks for digging into this!  i'll await your update.
@KevinRamsunder heads up.

Hi @paulirish - sorry for the delay.
I am not sure why I was getting (null) as a branch name on Friday, as I can no longer reproduce that. I think I must have had some awkward intermediate version of the script on my local filesystem that did not reflect the diff in this PR.
Applying just this patch as it is in this PR works correctly for me. So, if you'd like to merge, feel free.

pushed in v1.1.1


Pass webpack.config.babel.js to karma-webpack

Is there any way to pass webpack.config.babel.js written in ES2015 (ES6) to karma-wepack plugin? AFAIK you can't write karma.conf in ES6. So when I want to require my config it breaks on unknown syntax. It would be great if I could pass only the path to the config or if the plugin would use Webpack's default mechanism to detect configuration inside a project.

:+1:

Just import babel-register, that's what webpack does under the hood

Works fine. Thanks!


For have_selector, count option is treated as "at least N" instead of "exactly N"

Situation: On JavaScript form submission, Rails responds with a js.erb template which currently adds an .error element to the DOM.  On subsequent form submissions, the elements stack.
Capybara's Selenium JavaScript driver successfully notices the span.error duplicates.  Webkit doesn't.  Here's the code:
submit_the_form "once"   # adds an .error element
submit_the_form "twice"   # adds another .error element
find('#edit_event_1').should have_selector('.error', count: 1)   # should fail

Turns out the webkit driver lets the example pass for count: 2, too.  Only when I test for count: 3 or higher does it fail:
1) Editing Events Ajax editing test shows the error only once
   Failure/Error: find('#edit_event_1').should have_selector('.error', count: 3)
   Capybara::ExpectationNotMet:
     expected to find css ".error" 3 times, found 2 matches: "is not a number", "is not a number"

Seems like have_selector('.error', count: 1) isn't testing for exactly 1 but at least 1 match with the webkit driver.

I'll close this due to the long time of inactivity.


CUDA-less Pytorch

Installed the CUDA-less Pytorch,
... I'm getting
File "C:\Users\Chip\anaconda3\lib\site-packages\pytorch_lightning\trainer\distrib_parts.py", line 317, in sanitize_gpu_ids
raise MisconfigurationException(f"""
pytorch_lightning.utilities.exceptions.MisconfigurationException:
You requested GPUs: [0]
But your machine only has: []
I thought I would try it with the "no CUDA" pytorch lightning but I guess I was too optimistic?

Try to change 14th line in train.py:
max_epochs=args.max_epochs, gpus=args.gpus, row_log_interval=100
to:
max_epochs=args.max_epochs, row_log_interval=100
it works for me on free colab account when there are no gpu/tpu available.

Yes that should work, but I’ll also add a cpu flag to make it selectable from the command line.

That seems to be working.
I'm getting
d.py:37: UserWarning: Unsupported ReduceOp for distributed computing.
warnings.warn(*args, **kwargs)
But it appears some epochs go to 100%, others not at all - I'm presently presuming that is to be expected?
The warnings above seem to be innocuous?
Thanks!

That seems to be a common problem people are having, try removing and adding back the plugin in the FX window and check if they show up.  If not, I'll need more details to try to reproduce the error (Reaper install location and version, operating system (assuming Windows 10?) and anything else you might think is relevant). Thanks!
FYI -  a "cpu" flag has been added to PedalNetRT, enter "--cpu=1" with train.py to use.

Thanks.  Default reaper install path, Win10 X64.   I've tried adding/removing SmartPedal from a track to no avail.  Tried moving SmartPedal.vst3 to a different directory, put my .json in there with it - Reaper finds the plugin.  It must be something with my .json file...

I added a work around that will hopefully work for you, as of release 1.2 there’s a load model button that will allow you to select the json file from a file select dialog. If that doesn’t work try the default ts9 model in the repo, and if the default works then it’s probably your json file, which I can take a look at if you’d like.

CPU flag added for easy way to force cpu training in PedalNetRT, closing issue


Misleading translation of 'reverse' in Dutch

Preflight Checklist

[x] I agree to follow the Code of Conduct that this project adheres to.
[x] I have searched the issue tracker for a feature request that matches the one I want to file, without success.

You must agree to search and the code of conduct. You must fill in this entire template. If you delete part/all or miss parts out your issue will be closed.
If you are technical, you should reporting bugs along the lines of https://marker.io/blog/how-to-write-bug-report. If you are not technical, we will make allowances, please try to make an effort to understand the process.
Describe the bug
The translation of "reverse" to Dutch is currently "Ongedaan maken" which has the very misleading meaning of "Undo". In the context of drawio "reverse" is used as "turn around in opposite direction" which in Dutch should be translated to "Omdraaien"
To Reproduce
Steps to reproduce the behavior:

Go to 'https://draw.io' in a Browser set to Dutch language
Click on 'Nieuw diagram aanmaken', create "Blanco Diagram"
Add a single direction arrow, click tab "Ordenen"
A button "Ongedaan maken" (meaning "Undo") appears

Expected behavior
A button "Omdraaien" should appear
draw.io version (In the Help->About menu of the draw.io editor):

draw.io version x.y.z
23.0.1

Desktop (please complete the following information):

OS: Windows 11
Browser Chrome
Browser Version 122.0.6261.95

I tested the problem in incognito/private mode with all browser extensions switched off, write "yes" below:

yes

Thanks for the report. This will be fixed in the next release.


Set up repository on Github

[x] Create repository
[x] Add collaborators
[x] Set up Milestones
[x] Set up Labels
[x] Associate with Project

"easy", "medium", "hard" are for difficulty levels.
"software", "testing", "hardware", "design", "documentation" are for types of tasks.
"bug" is for when something is not  working.
"duplicate" is for when it's already exist.
"enhancement" is when there is new feature or request.
"help wanted" is when it need extra attention.
"invalid" is when something went wrong.
"question" is when further information is requested.
"wont fix" is when this will not be worked on.

Everything in this issue is checked

@ffund Please review our project!


count is not considered when doing the check for actual_num_validators

{
  "participants": [
    {
      "el_client_type": "geth",
      "el_client_image": "ethpandaops/geth:master",
      "cl_client_type": "teku",
      "cl_client_image": "consensys/teku:develop",
      "el_max_mem": 1000,
      "count": 10
    },
    {
      "el_client_type": "geth",
      "el_client_image": "ethpandaops/geth:master",
      "cl_client_type": "lighthouse",
      "cl_client_image": "sigp/lighthouse:latest",
      "el_max_mem": 1000,
      "count": 10
    },
    {
      "el_client_type": "geth",
      "el_client_image": "ethpandaops/geth:master",
      "cl_client_type": "lodestar",
      "cl_client_image": "chainsafe/lodestar:latest",
      "el_max_mem": 1000,
      "count": 10
    },
    {
      "el_client_type": "geth",
      "el_client_image": "ethpandaops/geth:master",
      "cl_client_type": "prysm",
      "cl_client_image": "prysmaticlabs/prysm-beacon-chain:latest,prysmaticlabs/prysm-validator:latest",
      "el_max_mem": 1000,
      "count": 10
    },
    {
      "el_client_type": "geth",
      "el_client_image": "ethpandaops/geth:master",
      "cl_client_type": "nimbus",
      "cl_client_image": "statusim/nimbus-eth2:amd64-latest",
      "el_max_mem": 1000,
      "count": 10
    }
  ],
  "network_params": {
    "network_id": "3151908",
    "deposit_contract_address": "0x4242424242424242424242424242424242424242",
    "seconds_per_slot": 12,
    "slots_per_epoch": 32,
    "genesis_delay": 1800,
    "capella_fork_epoch": 2,
    "deneb_fork_epoch": 1000,
    "num_validator_keys_per_node": 10,
    "preregistered_validator_keys_mnemonic": "giant issue aisle success illegal bike spike question tent bar rely arctic volcano long crawl hungry vocal artwork sniff fantasy very lucky have athlete"
  },
  "launch_additional_services": true,
  "wait_for_finalization": false,
  "wait_for_verifications": false,
  "verifications_epoch_limit": 5,
  "global_client_log_level": "info"
}

Evaluation error: fail: required_num_validtors - 64 is greater than actual_num_validators - 50
	at [github.com/kurtosis-tech/eth2-package/main.star:27:77]: run
	at [github.com/kurtosis-tech/eth2-package/src/package_io/parse_input.star:106:7]: parse_input
	at [0:0]: fail

Error encountered running Starlark code.```

I was able to reproduce this error, continuing to look into it.

Its probably this line that needs adjusting, to use the count also: https://github.com/kurtosis-tech/eth2-package/blob/main/src/package_io/parse_input.star#L104

@barnabasbusa I'm not sure what you mean about it shoud use the count as well? As I see it the immediate issue looks to be that slots_per_epoch is set to 32. Would it make sense to lower it? When I do it seems to run. But not sure what the best value is.

this has nothing to do with slots_per_epoch. The count is a new participant parameter that can be configured.
Its basically requests that many sets of client pairs of a certain kind.
For example, it will create
teku-geth-01
teku-geth-02
...
teku-geth-10

lighthouse-geth-01
...

...
But instead it assumes that there is one occurrence of each, and thus, actual_num_validators is 5x10 = 50.

@barnabasbusa Got it! What would be the correct way?

sum of all counts (default to 1 if count is not present) * num_validator_keys_per_node

@barnabasbusa made a PR. I was unable to test it with count=10 for each participant as my laptop just doesn't have enough memory. But ran it with count=2 and it seems to be working. Let me know if you have any issues!


Fixes Type conversion

Follow-up to https://github.com/microsoft/Power-Fx/pull/1827

✅ No public API change.


Don't crash if subcommand has no commands of its own

Adding a subcommand parser and then defining no commands on it can crash
estimatedCommands() since cmdnames is empty but the code assumes it is
at least one element long. This patch adds an explicit check for that.
Signed-off-by: Zygmunt Krynicki<EMAIL_ADDRESS>

Thanks!


chore(text): migrate to fast

Codecov Report

Merging #243 (5d7da89) into main (92fb6ed) will increase coverage by 2.10%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #243      +/-   ##
==========================================
+ Coverage   93.88%   95.98%   +2.10%
==========================================
  Files          27       33       +6
  Lines         278      349      +71
  Branches        4        5       +1
==========================================
+ Hits          261      335      +74
+ Misses         15       12       -3
  Partials        2        2

Flag
Coverage Δ

unittests
95.98% <100.00%> (+2.10%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

libs/components/src/lib/text/index.ts
100.00% <100.00%> (ø)

libs/components/src/lib/text/text.template.ts
100.00% <100.00%> (ø)

libs/components/src/lib/text/text.ts
100.00% <100.00%> (ø)

...bs/components/src/lib/sidenav-item/sidenav-item.ts
100.00% <0.00%> (ø)

libs/components/src/lib/sidenav-item/index.ts
100.00% <0.00%> (ø)

...ents/src/lib/sidenav-item/sidenav-item.template.ts
100.00% <0.00%> (ø)

libs/components/src/shared/patterns/affix.ts
100.00% <0.00%> (+16.66%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 92fb6ed...5d7da89. Read the comment docs.


SOFT folder is no longer needed

:warning: Please install the  to ensure uploads and comments are reliably processed by Codecov.
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 77.97%. Comparing base (1705508) to head (b70ad60).

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@           Coverage Diff           @@
##             main      #55   +/-   ##
=======================================
  Coverage   77.97%   77.97%
=======================================
  Files           5        5
  Lines         917      917
=======================================
  Hits          715      715
  Misses        202      202

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Fix clicking on update card button if the session is expired leading to server error.

@amanagr @timabbott I might be just missing some context on this issue, but why is this only relevant for authenticated_remote_realm_management_endpoint? Don't we need the same thing for the server-based flow endpoints? (authenticated_remote_server_management_endpoint)

Yeah, opened #29013 for the server part. Thanks for noticing.


Relevance and other composer tweaks

Several things to make composer easier to use:

When searching in palette, it now sorts by "Relevance" as primary order; relevance formula is a bit complicated, poor-man's AI :), but works pretty damn well (!)
Sort is always multi-sort, and dropdown shows the sort order (this could do with more UI goodness to make that obvious, but it does the right thing if you interact with it; "relevance" above obviously has no effect when not searching so "name" as second-order search order is what you normally get)
Default palette now shows 3 wide; with more height and longer names this seems better (4 wide aka "Compact" is an option)
the Quick Info pane from the palette is now toggleable, and showing this is the default action if you click on a tile (not adding to the root of the application which was a bit surprising!); it has buttons for the previous "selection" action, and also a button to open in catalog
selecting from palette adds to a focus entity if there is a focus entity
extensible in several places, including the spec editor sections can be customized or removed

Below is a sample screen shot, for a downstream project that uses the UI (and has a lot of types), but the mods all apply to the stock brooklyn UI (though only really useful with a big catalog!):

LGTM. There are couple of thing I want to change but I'll do this in a separate PR shortly. Merging this in the meantime


Alignment file & CTF fields

Context: The current tomograms provided in the portal may not fit the needs of every user. We need to integrate and surface alignment file and CTF information in the metadata to allow users to create their own tomograms using the tilt series provided.  See more on the context in one pager here
On the single runs summary section, add:

Defocus Value
Alignment File

On the runs metadata panel, add in the following fields:

Defocus Value
Alignment File
Alignment Type

Dependency:  backend work captured here  (LINK ONCE TICKET IS CREATED)
Link to designs: https://www.figma.com/design/q7c7Efv7BdbpVsLcVA2FVS/Alignment-File-%2F-CTF?node-id=0-1&t=ZqdgrCb9Kf8TlEYk-0

note: this will be grouped into the multiple tomograms work. can close this ticket once multiple tomogram tickets are created

grouped in multiple tomograms work


Create .cloner.sh

Please create a directory github and move the script there. Call it clone-all-repositories.sh or something like this.

@tibeer Move it into a github directory.

Will create a new one.


Request: kernel 6.8 for Ubuntu 24.04?

Hi,
Ubuntu 24.04 lts, it’s releasing soon, and comes with kernel 6.8.. will wsl include it by default, once 24.04 released?..
I say, because we are at 5.15 , and there was some wsl beta release with a 6.1 kernel but was scrapped..
https://github.com/microsoft/WSL2-Linux-Kernel/tree/linux-msft-wsl-6.1.y
Thanks..

Is there a specific feature in Ubuntu 24.04 that you want included in WSL2?

@oscarbg the Linux kernel released by WSL team has code that's not in the main kernel, and it might  never be mainlined. That's something to consider!

Considering WSL sticks to LTS kernels historically 5.15 is probably the version for the foreseeable future. You can always use a community build with the WSL patches, i.e.: https://github.com/Nevuly/WSL2-Linux-Kernel-Rolling
That's very much unsupported though.

LTS Kernels shouldn't really be something holding them to 5.15 considering 6.1 and 6.6 are also LTS. In addition, the shrinking of the LTS window to 2 years will probably force Microsoft's hand a bit.
That said, having 6.8 available would be outstanding. It is a big release.

LTS Kernels shouldn't really be something holding them to 5.15 considering 6.1 and 6.6 are also LTS.

Fair point

Updating the kernel would also fix at least these issues, that I personally have and are very annoying for me, and probably a lot of other issues as well.

https://github.com/microsoft/WSL/issues/5694 (This still happens for me and spams the journal log a lot)
https://github.com/microsoft/WSL/issues/8203

The first issue was fixed for me in WSL 1.1.7, when Microsoft briefly switched to kernel 6.1 https://github.com/microsoft/WSL/releases/tag/1.1.7 a year ago, but for some reason they switched back https://github.com/microsoft/WSL/releases/tag/1.2.0 (Revert to the <IP_ADDRESS> version of the kernel while we debug a few issues). And newer upgraded again.
6.1, and I think some optimizations after that should also probably make it possible to optimize the file system performance https://www.phoronix.com/news/Linux-9p-10x-Performance, but I believe that it also needs some kind of Windows side implementation to be effective.

For optimal performance with new features like multi-shot accept or ring-mapped buffers in io-uring or liburing, it is advisable to use a newer kernel version. Therefore, I recommend using a newer kernel version in WSL, such as Ubuntu 22.04 with kernel 6.8.

Do not update to Ubuntu 24.04, I made that mistake yesterday.
https://twitter.com/stanzillaz/status/1783274242995290244

WSL was updated to the Linux 6.6 LTS kernel yesterday. Considering that this is the latest LTS version of Linux, it seems that there is nothing that can be done about the current issue. Refer to https://github.com/microsoft/WSL2-Linux-Kernel/releases/tag/linux-msft-wsl-<IP_ADDRESS> .

Looks like it's now a bit easier to see what they changed: https://github.com/microsoft/WSL2-Linux-Kernel/commits/linux-msft-wsl-<IP_ADDRESS>/
Could try a rebase onto a newer version.


fix: add source replacement info when no matching package found

What does this PR try to resolve?
Fixes #14697
I updated error message in resolver/errors with Registry::describe_source

Use message from Registry::describe_source as default message
If the message is empty, use SourceId message

and I also updated related test cases.
How should we test and review this PR?

Run following test cases:

resolver-tests
source_replacement
build
directory
local_registry
offline
package
publish
registry
update

Run cargo-bug.zip

Unpack the zip archive
Run cargo build in the root

following message should be seen:
error: no matching package named `ahasha` found
location searched: directory source `/home/foo/Desktop/cargo-bug/vendor` (which is replacing registry `crates-io`)
required by package `example v0.1.0 (/home/foo/Desktop/cargo-bug)`

Thanks!
@bors r+

:pushpin: Commit 11f84a964cb6a403a952f1d666a64d77d124b82a has been approved by epage
It is now in the queue for this repository.

:hourglass: Testing commit 11f84a964cb6a403a952f1d666a64d77d124b82a with merge 7571e924f05322730a14bc5dfe015b799e944651...

:sunny: Test successful - checks-actions
Approved by: epage
Pushing 7571e924f05322730a14bc5dfe015b799e944651 to master...

:eyes: Test was successful, but fast-forwarding failed: 422 Changes must be made through a pull request.

Thanks @chentodd!


Type of withKnobs

Describe the bug
The type of withKnobs is not valid for the addDecorator function. Looks like the @types/storybook_addon-knobs is out of date maybe?
To Reproduce
Using the following relevant libraries:
    "@babel/core": "^7.2.2",
    "@storybook/addon-knobs": "^4.1.13",
    "@storybook/vue": "^4.1.11",
    "@types/node": "^11.9.4",
    "@types/react": "^16.8.4",
    "@types/storybook__addon-knobs": "^4.0.1",
    "@types/storybook__vue": "^3.3.2",
    "babel-core": "^6.26.3",
    "babel-loader": "^8.0.5",
    "babel-preset-vue": "^2.0.2",
    "ts-loader": "^5.3.3",
    "typescript": "^3.3.3",
    "vue-template-compiler": "^2.6.6",
    "vue": "^2.6.6"

Not exactly sure the @types/react is needed, but it's part of the docs for using knobs with TypeScript.
Component.stories.ts
import { storiesOf, Story } from '@storybook/vue'
import { withKnobs, text } from '@storybook/addon-knobs'
import MyComponent from './MyComponent.vue'

const stories: Story = storiesOf('MyComponent.vue', module)

// This throws a type checking error
stories.addDecorator(withKnobs)

// This compiles and works as expected
stories.addDecorator(<any>withKnobs)

stories.add('as component', () => ({
  components: { MyComponent },
  props: {
    text: {
      default: text('Text', 'some text')
    }
  },
  template: '<my-component></my-component>'
})

System:

OS: Windows10
Device: Toshiba Satellite
Browser: N/A
Framework: Vue
Addons: knobs
Knobs Version: 4.1.13
Knobs Types Version: 4.0.1 (This is latest)
Storybook Version: 4.1.11

Additional context
This isn't a huge deal, just a minor annoyance as I cringe any time I have to use the any type.

Thanks for the bug! Unfortunately, we don't maintain the types on DefinitelyTyped and I'm not sure about what's the procedure for getting those updated.
The good news is that we're in the process of converting our codebase into Typescript, so you should be seeing those types defined "in house" in an upcoming release. You can check the progress and contribute yourself here: https://github.com/storybooks/storybook/issues/5030
Closing this for now! 🙇

Awesome, that will be great! Thanks @shilman


Django app support

Hello and thank you for your greatttt module <3
My question is about rendering bundles from INSTALLED_APPS which have bundles to provide.
For example, a django-ajaxsomething app could provide entry points to support their own widgets.
Then, could it be possible to do render_bundle to render bundles provided by INSTALLED_APPS ?
Keep up the great work this apps works flawlessly for me <3

Any updates on this?

I'm wondering if we could just have a JS one liner to execute a manage command to get the apps entry points and generate paths but i'm working on something else for now ;)

See if it would be possible to take an approach similar to cubicweb.
Add the ability in view to add a bundle to render: request.webpack.add_bundle()
Ideally we could add bundles from other django apps that will have a webpack.config.js in it :joy:
Do you think that would work ?

Great stuff !

FTR, I publish a generic solution as I'm testing other builders: https://pypi.org/project/django-appwatch/


Pulumi preview crashes starting from aws v6

What happened?
We recently upgraded our code to use v6 of @pulumi/aws and started seeing errors when previewing the creation of new resources. We were able to create the below minimal reproduction. The problem is that pulumi preview crashes when executing this code.
While the code itself doesn't make a lot of sense in the current state, it is a simplification of a much more complex business logic that worked in the previous versions.
It could be a problem in one of the underlying providers that the aws package uses, but we can't be certain since the error is very cryptic.
Please note the following:

This code works fine in v5.43.0 of the Node SDK.
It only fails if the resources don't exist yet. It doesn't crash if the resources already exist (created with v5.43.0 and then upgraded).

The error is as follows:
❯ pulumi preview
Previewing update (dev):
     Type                      Name            Plan       Info
 +   pulumi:pulumi:Stack       test-stack-dev  create     1 error; 40 messages
 +   ├─ aws:ec2:SecurityGroup  myGroup         create
 +   └─ aws:ec2:SecurityGroup  myGroup2        create     1 error

Diagnostics:
  aws:ec2:SecurityGroup (myGroup2):
    error: Preview failed: error reading from server: EOF

  pulumi:pulumi:Stack (test-stack-dev):
    panic: value has no attribute of that name
    goroutine 158 [running]:
    github.com/zclconf/go-cty/cty.Value.GetAttr({{{0x1135095e0?, 0x1400c9717b0?}}, {0x111815560?, 0x1400c90f920?}}, {0x10ed48884, 0x6})
        /home/runner/go/pkg/mod/github.com/zclconf/go-cty@v1.14.1/cty/value_ops.go:808 +0x270
    github.com/pulumi/pulumi-terraform-bridge/v3/pkg/tfshim/sdk-v2/internal/tf/plans/objchange.proposedNewAttributes(0x1400c90f470, {{{0x1135095e0?, 0x1400c971660?}}, {0x111815560?, 0x1400c90f6b0?}}, {{{0x1135095e0?, 0x1400c9717b0?}}, {0x111815560?, 0x1400c90f920?}})
        /home/runner/go/pkg/mod/github.com/pulumi/pulumi-terraform-bridge/v3@v3.67.0/pkg/tfshim/sdk-v2/internal/tf/plans/objchange/objchange.go:289 +0x170
    github.com/pulumi/pulumi-terraform-bridge/v3/pkg/tfshim/sdk-v2/internal/tf/plans/objchange.proposedNew(0x1400c90f440, {{{0x1135095e0?, 0x1400c971660?}}, {0x111815560?, 0x1400c90f6b0?}}, {{{0x1135095e0?, 0x1400c9717b0?}}, {0x111815560?, 0x1400c90f920?}})
        /home/runner/go/pkg/mod/github.com/pulumi/pulumi-terraform-bridge/v3@v3.67.0/pkg/tfshim/sdk-v2/internal/tf/plans/objchange/objchange.go:89 +0xe0
    github.com/pulumi/pulumi-terraform-bridge/v3/pkg/tfshim/sdk-v2/internal/tf/plans/objchange.ProposedNew(0x113509420?, {{{0x1135095e0?, 0x1400c971660?}}, {0x111815560?, 0x1400c90f6b0?}}, {{{0x1135095e0?, 0x1400c9717b0?}}, {0x111815560?, 0x1400c90f920?}})
        /home/runner/go/pkg/mod/github.com/pulumi/pulumi-terraform-bridge/v3@v3.67.0/pkg/tfshim/sdk-v2/internal/tf/plans/objchange/objchange.go:46 +0xec
    github.com/pulumi/pulumi-terraform-bridge/v3/pkg/tfshim/sdk-v2.proposedNew(0x1400c90e270?, {{{0x113509420?, 0x1400079e7c8?}}, {0x111815560?, 0x1400c90eba0?}}, {{{0x113509420?, 0x1400079e730?}}, {0x111815560?, 0x1400c7cb680?}})
        /home/runner/go/pkg/mod/github.com/pulumi/pulumi-terraform-bridge/v3@v3.67.0/pkg/tfshim/sdk-v2/proposed_new.go:34 +0x104
    github.com/pulumi/pulumi-terraform-bridge/v3/pkg/tfshim/sdk-v2.simpleDiffViaPlanState({0x113509018, 0x11bc99700}, 0x1400079e730?, 0x111815560?, {{{0x113509420?, 0x1400079e730?}}, {0x111815560?, 0x1400c7cb680?}}, {0x11333c3e0, 0x140000691d0})
        /home/runner/go/pkg/mod/github.com/pulumi/pulumi-terraform-bridge/v3@v3.67.0/pkg/tfshim/sdk-v2/provider_diff.go:154 +0xac
    github.com/pulumi/pulumi-terraform-bridge/v3/pkg/tfshim/sdk-v2.v2Provider.simpleDiff({0x1118180e0?, {0x1400c7ca990?, 0x10edae543?, 0x12?}}, 0x14001e63e30?, 0x1046fee0c?, 0x110cfaf00?, 0x1400c7ca660?, {{{0x113509420?, 0x1400079e730?}}, ...}, ...)
        /home/runner/go/pkg/mod/github.com/pulumi/pulumi-terraform-bridge/v3@v3.67.0/pkg/tfshim/sdk-v2/provider_diff.go:103 +0x62c
    github.com/pulumi/pulumi-terraform-bridge/v3/pkg/tfshim/sdk-v2.v2Provider.Diff({0x14000c4cd80?, {0x1400079e478?, 0x7a?, 0x14008b15558?}}, {0x10edae543, 0x12}, {0x0?, 0x0}, {0x1133cd040, 0x1400c7ca990})
        /home/runner/go/pkg/mod/github.com/pulumi/pulumi-terraform-bridge/v3@v3.67.0/pkg/tfshim/sdk-v2/provider_diff.go:63 +0x1fc
    github.com/pulumi/pulumi-terraform-bridge/v3/pkg/tfbridge.(*Provider).Create(0x14000a75980, {0x113508f38?, 0x1400c7ca570?}, 0x1400c75d8b0)
        /home/runner/go/pkg/mod/github.com/pulumi/pulumi-terraform-bridge/v3@v3.67.0/pkg/tfbridge/provider.go:842 +0x468
    github.com/pulumi/pulumi-terraform-bridge/x/muxer.(*muxer).Create.func1({0x11353c708?, 0x14000a75980?})
        /home/runner/go/pkg/mod/github.com/pulumi/pulumi-terraform-bridge/x/muxer@v0.0.7-0.20231130182140-6385710fcbc4/muxer.go:361 +0x3c
    github.com/pulumi/pulumi-terraform-bridge/x/muxer.resourceMethod[...](0x14004df4dc0?, 0x14008b15728, 0x14008b15708?)
        /home/runner/go/pkg/mod/github.com/pulumi/pulumi-terraform-bridge/x/muxer@v0.0.7-0.20231130182140-6385710fcbc4/muxer.go:320 +0xc4
    github.com/pulumi/pulumi-terraform-bridge/x/muxer.(*muxer).Create(0x14008b15768?, {0x113508f38?, 0x1400c7ca570?}, 0x110e142e0?)
        /home/runner/go/pkg/mod/github.com/pulumi/pulumi-terraform-bridge/x/muxer@v0.0.7-0.20231130182140-6385710fcbc4/muxer.go:360 +0x5c
    github.com/pulumi/pulumi/sdk/v3/proto/go._ResourceProvider_Create_Handler.func1({0x113508f38, 0x1400c7ca570}, {0x112c01a80?, 0x1400c75d8b0})
        /home/runner/go/pkg/mod/github.com/pulumi/pulumi/sdk/v3@v3.95.0/proto/go/provider_grpc.pb.go:593 +0x74
    github.com/grpc-ecosystem/grpc-opentracing/go/otgrpc.OpenTracingServerInterceptor.func1({0x113508f38, 0x1400c7ca390}, {0x112c01a80, 0x1400c75d8b0}, 0x1400c781740, 0x1400c777ba8)
        /home/runner/go/pkg/mod/github.com/grpc-ecosystem/grpc-opentracing@v0.0.0-20180507213350-8e809c8a8645/go/otgrpc/server.go:57 +0x2e8
    github.com/pulumi/pulumi/sdk/v3/proto/go._ResourceProvider_Create_Handler({0x1131b7b40?, 0x14004df4dc0}, {0x113508f38, 0x1400c7ca390}, 0x14008981c00, 0x14005d3e720)
        /home/runner/go/pkg/mod/github.com/pulumi/pulumi/sdk/v3@v3.95.0/proto/go/provider_grpc.pb.go:595 +0x12c
    google.golang.org/grpc.(*Server).processUnaryRPC(0x14000016b40, {0x113508f38, 0x1400c7ca300}, {0x11351dd00, 0x1400c0a3520}, 0x1400c7c4ea0, 0x1400c2e6f30, 0x11bc434e0, 0x0)
        /home/runner/go/pkg/mod/google.golang.org/grpc@v1.59.0/server.go:1343 +0xb8c
    google.golang.org/grpc.(*Server).handleStream(0x14000016b40, {0x11351dd00, 0x1400c0a3520}, 0x1400c7c4ea0)
        /home/runner/go/pkg/mod/google.golang.org/grpc@v1.59.0/server.go:1737 +0x988
    google.golang.org/grpc.(*Server).serveStreams.func1.1()
        /home/runner/go/pkg/mod/google.golang.org/grpc@v1.59.0/server.go:986 +0x88
    created by google.golang.org/grpc.(*Server).serveStreams.func1 in goroutine 81
        /home/runner/go/pkg/mod/google.golang.org/grpc@v1.59.0/server.go:997 +0x160

    error: preview failed

Example
import * as aws from '@pulumi/aws';

const myGroup = new aws.ec2.SecurityGroup('myGroup', {});

new aws.ec2.SecurityGroup('myGroup2', {
  ingress: myGroup.ingress,
});

Another example:
import * as pulumi from '@pulumi/pulumi';
import * as aws from '@pulumi/aws';

function getIngress(
  arg: pulumi.Input<string>,
): pulumi.Output<aws.types.input.ec2.SecurityGroupIngress[]> {
  return pulumi.all([arg]).apply(() => {
    return [];
  });
}

const myGroup = new aws.ec2.SecurityGroup('myGroup', {});

new aws.ec2.SecurityGroup('myGroup2', {
  ingress: getIngress(myGroup.id),
});

Output of pulumi about
❯ pulumi about
CLI
Version      3.95.0
Go Version   go1.21.4
Go Compiler  gc

Plugins
NAME    VERSION
aws     6.13.1
nodejs  unknown

Host
OS       darwin
Version  13.4.1
Arch     arm64

This project is written in nodejs: executable='/Users/stiller/.nvm/versions/node/v20.9.0/bin/node' version='v20.9.0'

Current Stack: organization/test-stack/dev

Found no resources associated with dev

Found no pending operations associated with dev

Backend
Name           << REDACTED >>
URL            s3://<< REDACTED >>
User           stiller
Organizations
Token type     personal

Dependencies:
NAME            VERSION
@pulumi/aws     6.13.1
@pulumi/pulumi  3.95.0
@types/node     20.10.0

Pulumi locates its logs in /var/folders/8j/5yn5f8rs1_xf0p5krs5dq17w0000gn/T/ by default

Additional context
No response
Contributing
Vote on this issue by adding a 👍 reaction.
To contribute a fix for this issue, leave a comment (and link to your pull request, if you've opened one already).

I updated the example with an even more minimal reproduction and updated the title accordingly.

Curiously this success for me on the smaller repro: pulumi up --skip-preview --yes so the issue is affecting Create preview specifically.

https://github.com/pulumi/pulumi-aws/pull/3109 gets past this issue for me. I'll make a release here as soon as possible, apologies; waiting on https://github.com/pulumi/pulumi/issues/14781 to get released to unblock our test+CI pipeline.

This should be fixed in v6.13.2. Please let us know if you are running into any more unexpected behavior by opening new issues in this repo. Thank you!

Thanks! We'll give it a try. 🎉


feat: add support for more than just circleci as a provider

BREAKING CHANGE: This is a change in configuration types
This module still just supports circleci after this change, but this lays the group work for future services to be supported in semver/minor bumps in a relatively lightweight way.
To prove this works / supports "multiple" this PR does land an invalid config type which maps to 0 secrets every time, but demonstrates how one would add another service to this exchange tool

@MarshallOfSound, this landed as v1.6.0, but given your description it seems like it should have landed as v2.0.0?


AMD MIGraphX Support

Would love to have AMD MIGraphX support. There is currently an open PR for Windows support over on the ONNX runtime repo.
https://github.com/microsoft/onnxruntime/pull/21084#issuecomment-2179952511

Added in https://github.com/pykeio/ort/commit/19d66de302fa7bfc065555fec3815e81c6d7e28e, please let me know if it works without issue.


[FLINK-13273][sql-client] Allow switching planners in SQL Client

What is the purpose of the change
This allows to switch planners in SQL Client. A user can specify execution.planner=blink to activate it. The SQL Client E2E tests as well as integration tests have been updated for verifying the behavior.
This PR is based on #9263.
Brief change log
See commit messages.
Verifying this change
This change is already covered by existing tests, such as LocalExecutorITCase.
Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): yes
The public API, i.e., is any changed class annotated with @Public(Evolving): no
The serializers: no
The runtime per-record code paths (performance sensitive): no
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: no
The S3 file system connector: no

Documentation

Does this pull request introduce a new feature? yes
If yes, how is the feature documented? docs

+1 for this PR. I think though we need to change the #9263 first a bit.

Thanks for the feedback @dawidwys and @docete. I updated the PR. It was also possible to make the SQL Client work without changes to the factories. Please take another look.

@twalthr Thank you for solving the factories PR. I think now this PR is good to be merged.


[FEATURE] Automatically update copyright year

Description
Hello @SauravMukherjee44 , I feel the code to update the copyright year can be included to avoid having to manually do this from the code base in subsequent years, I could work on it if approved and assigned, thank you
Screenshots
No response

Hi instead of setting it manually we can set it automatically using javascript date function
Should i open a pull request for this?


Upgrade a bunch of node packages, upgrade node to v16

Update js code formatting to adhere to updated prettier rules
Update css code formatting to adhere to updated stylelint rules
Update all devDependencies except webpack and webpack-related devDependencies
Update all dependencies that are not marked as "Major Update backward-incompatible updates" by yarn upgrade-interactive --latest

Wanted to get all dependencies updated before merging this pr, but I most likely won't have any time for dependencies for the next two weeks so I'm uploading this so this work is already merged if anyone else wants to take a look at it in the meantime.
Got stuck on one of many breaking changes in webpack 5 and its dependencies. Pushing a commit with my work so far soon in another branch if anyone wants to have a look(:

Nice! Should get the node 10 changed in the Dockerfile as well. 😳

@SmithPeder anywhere else it has to be changed / any other changes needed?


Bump go version to 1.18

cc @axetroy

Seems golangci-lint can't work properly with go 1.18

Seems golangci-lint can't work properly with go 1.18

https://github.com/golangci/golangci-lint/pull/2438

Still blocking https://github.com/golangci/golangci-lint/issues/2649 with v1.45

Still blocking golangci/golangci-lint#2649 with v1.45

It works after adding the below config e580111:
run:
    go: 1.18

You can do the review now @axetroy


feat/Binance Spot Testnet

Before submitting this PR, please make sure:

[x] Your code builds clean without any errors or warnings
[x] You are using approved title ("feat/", "fix/", "docs/", "refactor/")

A description of the changes proposed in the pull request:
Modified the Binance connector to support Binance Spot testnet (https://testnet.binance.vision/)
The reason why this would be nice to have is that the paper-trade sometimes fail with TypeError on such cases when you would like to buy and sell big amounts of assets. The amount has to be a decimal type however the papertrade fill script is trying to do some math which coded as float, so therefore it will throw TypeError.
Also other cases might benefit from a direct connector to the Binance Spot Testnet.
Tests performed by the developer:
Buying/Selling script has been running using the testnet api throughout the day.
Tips for QA testing:

hi @bncmajor
please review
https://hummingbot.org/governance/proposals/#new-connector-proposals
New Connector Proposals (NCP) let HBOT holders approve new connectors for merge and inclusion into the Hummingbot codebase.
https://hummingbot.org/developers/contributions/
https://hummingbot.org/developers/contributions/#checklist


WIP 24166 handle filter and mapping of the fss event to fss notification

PR Contain code changes ,unit test cases & function test case is IN progress.

@ganpat-tech if this is ready for review could you remove the WIP from the title please.


structure: Expected ENDFUNCTION at beginning of function module

Error:
 ./src/isu/#redwood#2isu.fugr.#redwood#ma_structure_data.abap[1, 1]      - Expected ENDFUNCTION (structure)
Code:

The "expected" something errors are not super helpful, there is typically some kind of error somewhere else in the include

the easiest way to find the right error is to copy paste the code into https://playground.abaplint.org, to find a smaller example reproducing the issue

Used 2.38.4
Issue is resolved. Thanks again.


XDA bridge for last posts in a thread #1546

A simple bridge for this request https://github.com/RSS-Bridge/rss-bridge/issues/1546

XDA is moving to new Forum software, probably making this not work anymore.

Can confirm they swapped forum software.

FYI: the new software has an rss feed, maybe you can use that: https://www.xda-developers.com/feed/


Why was the AQL tutorial removed?

Why was the AQL tutorial removed from ArangoDB docs in 3.10? All links now point to Aranagodb Universty. What if don't want to join this "university" and just want to read this tutorial in text format without any registartion?

Hi @Igorgro,
We have moved several pages from the documentation and to the ArangoDB University because an interactive course format fits tutorial content well, and we have created an integration with our ArangoGraph Insights Platform, allowing users to try out examples immediately instead of having to download and install ArangoDB first. We are not quite there yet in terms of interactivity, but we did the first step in this direction, and we hope that this lowers the entry barrier. That said, you can still access the AQL tutorial in one of the older versions of the documentation: https://www.arangodb.com/docs/3.9/aql/tutorial.html. There are also other pages to learn AQL, although different to the tutorial, e.g. https://www.arangodb.com/docs/stable/aql/data-queries.html and https://www.arangodb.com/docs/stable/aql/examples.html.


[BACKPORT] [RHEL/CentOS] Elasticsearch v6 stops working after epicli upgrade - 0.6.x backport

We need to backport task #922 to version 0.6.x

#1751 has to be done to allow tests of this task. Unfortunately this task hangs are already merged and released as 0.6.1 and another one is still not started and planned for 0.6.2.

Test OK (tested half-manually without upgrading K8s)


Media Library Permission asked after accessing media.

Bug - iOS

We can see contents of Media Library without permissions provided. And the request for permission is asked afterwards. You can see it in action:

Environment info

React native info output:
System:
    OS: macOS Mojave 10.14.6
    CPU: (12) x64 Intel(R) Core(TM) i7-8850H CPU @ 2.60GHz
    Memory: 1.40 GB / 16.00 GB
    Shell: 5.3 - /bin/zsh
  Binaries:
    Node: 10.16.3 - /usr/local/bin/node
    Yarn: 1.17.3 - /usr/local/bin/yarn
    npm: 6.9.0 - /usr/local/bin/npm
    Watchman: 4.9.0 - /usr/local/bin/watchman
  SDKs:
    iOS SDK:
      Platforms: iOS 13.0, DriverKit 19.0, macOS 10.15, tvOS 13.0, watchOS 6.0
    Android SDK:
      API Levels: 23, 25, 26, 27, 28
      Build Tools: 26.0.0, 27.0.0, 28.0.0, 28.0.3, 29.0.2
      System Images: android-25 | Intel x86 Atom, android-26 | Intel x86 Atom, android-27 | Intel x86 Atom, android-28 | Google APIs Intel x86 Atom, android-28 | Google Play Intel x86 Atom
  IDEs:
    Android Studio: 3.5 AI-191.8<IP_ADDRESS>91312
    Xcode: 11.0/11A420a - /usr/bin/xcodebuild
  npmPackages:
    react: 16.9.0 => 16.9.0
    react-native: 0.61.2 => 0.61.2
  npmGlobalPackages:
    create-react-native-module: 0.10.2
    react-native-cli: 2.0.1
    react-native-git-upgrade: 0.2.7
    react-native-rename: 2.4.1

Library version: 1.1.0
Describe what you expected to happen:

Should Request Permission first
Then show the Media Library.

Reproducible sample code

Here is repo with this issue: https://github.com/ziyoshams/image-picker-issue

Duplicate of #1187. #1159 assumes the images could be used without a permission, yet the system prompts for a permission if built with the newest SDK.

Any solution ?

Any solution ?

See the @Jazqa 's reply, and go to those linked issues. You will see the "solution".

+1


Fix typo in README

There is typo in the README file preventing users to view the example PDF file by clicking on the link.

Thank you for spotting and fixing this :)


order of permutations

permutations.t priviledges a particular order.  That prevents the use of a possibly more efficient algorithm returning its results in a different order.
I suggest sorting the output before comparing it.
is (1, 2, 3).permutations.list.sort(:by(*.join)).perl, ((1, 2, 3), (1, 3, 2), (2, 1, 3), (2, 3, 1), (3, 1, 2), (3, 2, 1)).perl, "permutations method";
is permutations(3).list.sort(:by(*.join)).perl, ((0, 1, 2), (0, 2, 1), (1, 0, 2), (1, 2, 0), (2, 0, 1), (2, 1, 0)).perl, "permutations function";

As mentioned this would allow other algorithm such as this one (notice the credits, the author gave me autorisation via email):
sub permutations(int $n) {
    # Credits for the following code goes to Phillip Paul Fuchs,
    # who authorized its use here in november 2015.
    # See his website, L<http://www.quickperm.org/>,
    # for more information.
    Seq.new:
        class :: does Iterator {
        has int $!n;
        has     @!a;
        has int $!i;
        has     @!p;
        submethod BUILD(:$n) { $!n = $n; self }
        method pull-one {
            if !@!a { @!a = ^$!n; $!i = 1; @!p = 0 .. $n; @!a; }
            elsif $!i < $!n {
                @!p[$!i]--;
                @!a[$!i !%% 2 ?? @!p[$!i] !! 0, $!i].=reverse;
                $!i = 0;
                @!p[$!i] = $!i while @!p[++$!i] == 0;
                @!a;
            }
            else { IterationEnd }
         }
        method count-only { [*] 1..$!n }
    }.new(:$n)
}

From my experiments, it seems to me that this algorithm is about twice as fast.

:+1: on the sorting. also, there really ought to be more tests. tests for 0 or negative numbers, tests for other stuff in lists, tests for other kinds of list (ranges for example. Buf/Blob perhaps?)

I'm not sure how permutations is supposed to behave for zero or negative numbers.  I don't think such values should be allowed.
Also permuting lists only uses slices made from permutations(Int $), so it really is the only thing that really needs testing.

There should be 1 permutation of 0 things, as there is exactly one way to order it.
This should hold true for all $n >= 0
+permutations($n) == factorial($n)

factorial 0 is defined as returning 1
I think the only thing that makes sense is for it to return a sequence containing a single empty list. ((),).Seq or possibly (Nil,).Seq


fix: Windows interop

Get running on windows.

@diasdavid build is failing with new latest aegir and no timeout specified.  Shall I revert, or do u have another idea.

@richardschneider you can increase the timeout of that specific batch of tests. I just meant to avoid global timeouts, it is important that we know which tests are really slow.

@diasdavid ready for review


OctopOS Prime Mascot Design-44

Design the OctopOS Prime character in a fantasy theme of your choice.
For example: Wizard, Witch, Healer
The design size should be 1080x1080.

OctoFairy


README typo fix

Though hungry, innocent musicians might be what was intended 😝

haha. Thanks for the patch!