Service discovery endpoint displays "Pool Member cannot be assigned to node" error when nodes with "id" field assigned as Node IP address are posted to the SD endpoint pool

Environment

AS3 Version: 3.37.0
BIG-IP Version: 16.0.1

Summary
I have setup an AS3 Service Discovery Application by posting the below configuration to the AS3 endpoint.
{
    "class": "ADC",
    "schemaVersion": "3.0.0",
    "Sample_sd_01": {
        "class": "Tenant",
        "A1": {
            "class": "Application",
            "service": {
                "class": "Service_HTTP",
                "virtualAddresses": [
                    "<IP_ADDRESS>%1"
                ],
                "pool": "web_pool"
            },
            "web_pool": {
                "class": "Pool",
                "monitors": [
                    "http"
                ],
                "members": [
                    {
                        "servicePort": 80,
                        "serverAddresses": []
                    },
                    {
                        "addressDiscovery": "event",
                        "servicePort": 80,
                        "routeDomain": 1
                    }
                ]
            }
        }
    }
}

This AS3 configuration contains a routeDomain property under the addressDiscovery field. With this routeDomain field, the Virtual IP Addresses & the Pool members are expected to be created under the specified routeDomain. This AS3 configuration, when posted, creates a SD task which can be viewed using this link https://[big-ip-address]/mgmt/shared/service-discovery/task/~Sample_sd_01~A1~web_pool/. I tried 2 configurations for posting Endpoints/Nodes to this pool - please refer to the configurations mentioned below
(1)  POST the nodes to the service discovery endpoint with "id" as any regular string in data payload:
[
    {
        "id": "newNode1",
        "ip": "<IP_ADDRESS>"
    },
    {
        "id": "newNode2",
        "ip": "<IP_ADDRESS>"
    }
]

With this, the endpoints (Nodes) get created in the Route domain with correct %RD suffix. And the pool members also get added to the web pool
(2) POST the nodes to the service discovery endpoint with "id" as the IP of the endpoint in data payload
 [
    {
        "id": "<IP_ADDRESS>",
        "ip": "<IP_ADDRESS>"
    },
    {
        "id": "<IP_ADDRESS>",
        "ip": "<IP_ADDRESS>"
    }
]

With this, an error is observed on the service discovery endpoint : "Pool Member cannot be assigned to node". Even though the Node gets created, it does not get added as a Pool member on the BIG-IP with such a configuration. Please refer to the images below for reference.

Steps To Reproduce

POST the above AS3 configuration to create a Service Discovery Application
On the following SD Endpoint, https://[big-ip-address]/mgmt/shared/service-discovery/task/~~~web_pool/, POST the nodes with "id" field set to IP of the Endpoint

Expected Behavior
When Nodes are posted to the SD task pool, the Nodes should be added to the BIG-IP Pool when "id" field is set to IP of the Endpoint in data payload.
Actual Behavior
When Nodes are posted to the SD task pool, the Nodes are not added to the BIG-IP Pool when "id" field is set to IP of the Endpoint in data payload and SD Endpoint displays "Pool Member cannot be assigned to node" error.

You cannot use IP address as a node name if node's address includes route domain. Here is KB: K17482. AS3 works as expected.

Adding +Jennifer Yeung @.***>
On Wed, Oct 26, 2022 at 12:42 AM Suntiha Ronanki @.***>
wrote:

Closed #614
https://github.com/F5Networks/f5-appsvcs-extension/issues/614 as
completed.
—
Reply to this email directly, view it on GitHub
https://github.com/F5Networks/f5-appsvcs-extension/issues/614#event-7666497152,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AVEZ6O3ITMEZIFZZ64PCEFLWFAWKVANCNFSM5XX3OBIQ
.
You are receiving this because you authored the thread.Message ID:
@.***
com>

--
Regards,
Selina V Arokiaswamy
Software Engineer | +91<PHONE_NUMBER>
Great Software Laboratory | www.gslab.com

Adding +Jayant Seth @.> , +Anaya Bakshi
@.>
On Wed, Oct 26, 2022 at 12:40 PM Selina Arokiaswamy <
@.***> wrote:

Adding +Jennifer Yeung @.***>
On Wed, Oct 26, 2022 at 12:42 AM Suntiha Ronanki @.***>
wrote:

Closed #614
https://github.com/F5Networks/f5-appsvcs-extension/issues/614 as
completed.
—
Reply to this email directly, view it on GitHub
https://github.com/F5Networks/f5-appsvcs-extension/issues/614#event-7666497152,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AVEZ6O3ITMEZIFZZ64PCEFLWFAWKVANCNFSM5XX3OBIQ
.
You are receiving this because you authored the thread.Message ID:
@.***
com>

--
Regards,
Selina V Arokiaswamy
Software Engineer | +91<PHONE_NUMBER>
Great Software Laboratory | www.gslab.com

--
Regards,
Selina V Arokiaswamy
Software Engineer | +91<PHONE_NUMBER>
Great Software Laboratory | www.gslab.com

This has been resolved in the 3.41.0 release of AS3.

Thanks @sunitharonan


Expose more options to OpenSearch image

I will give this a second try after #1466 got closed because of inactivity. I have rebased and updated this PR accordingly.
This PR exposes some more options of the fluent-plugin-opensearch plug-in as environment variables to the Dockerfile, to be more in line with what the Elasticsearch images offer. This should make the transition from Elasticsearch to OpenSearch easier.
It only changes the fluentd.conf file for OpenSearch images. The fluentd.conf is generated using the Makefile, so it based on the template change included in this PR.
Please let me know if any changes are necessary to get this merged.

Could you modify only templates/conf/fluent.conf.erb? Files under docker-image/ are genegeted automatically.

Done!


[SCB-562] fix NPE when had empty interface (not have any method)

Signed-off-by: zhengyangyong<EMAIL_ADDRESS>Follow this checklist to help us incorporate your contribution quickly and easily:

[x] Make sure there is a JIRA issue filed for the change (usually before you start working on it).  Trivial changes like typos do not require a JIRA issue.  Your pull request should address just this issue, without pulling in other changes.
[x] Each commit in the pull request should have a meaningful subject line and body.
[x] Format the pull request title like [SCB-XXX] Fixes bug in ApproximateQuantiles, where you replace SCB-XXX with the appropriate JIRA issue.
[x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
[x] Run mvn clean install to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
[x] If this contribution is large, please file an Apache Individual Contributor License Agreement.

do not init operations if there are no path (empty interface) in swagger(prevent NPE)

Coverage increased (+0.0007%) to 87.526% when pulling db4676c71572507f20d1f407b2ca92a4ec47dbdf on zhengyangyong:SCB-562 into 6ce5280969d1949fff9cb26c6925a1774a409af8 on apache:master.


Index predicates: allow more than just astzed.Primitive

Currently you can create an index rule that will index a non-primitive value. However when querying on an indexed field, for example, for non-primitive value, the value will not be searched for in the index pass of the query. This is because the compiler optimize pass, which decides which expressions in a filter to lookup in the index, ignores any value that is not an astzed.Primitive.
This functionality should be extended to include the other zed complex types (e.g. Record, Map, Arrays, etc). There's a catch here; the compiler SHOULD ignore values in a zed complex type that has child expressions that cannot be resolved by the compiler to a zed.Primitive. For example, the filter foo == {bar:baz+1} should be ignored by the index since the value of bar is dependent on the adjacent record value baz that we'll only know once the record is retrieved. However the filter expression foo == {bar:1} should be used. Bonus points if foo=={bar:1+1} also gets recognized as an indexable predicate.

Closing because #4972 removed the index package.


Legacy Update crashes mid-install. Can't be opened anymore.

Another problem I got, this time with Legacy Update crashed for some reason after restarting and trying to install the updates, it showed a "stopped working" message and once i clicked on close application, it takes me to the desktop.
I tried running Legacy Update again, but it doesn't work anymore.

Funnily enough, this problem is similar to what Michael MJD encountered when he tried to install Legacy Update on a WIndows XP VM, only this time I didn't even install ANY Service Packs on the Windows 7 VM. I don't know, for some reason this 1.8 version causes more problems than i had in the past versions.

Sorry for the issue, it's specifically a bug with the Enable Microsoft Update feature. You can try again with that unchecked and it'll work.
Closing this issue since it's a duplicate of #186.


List Features/ Bug resolutions/ Payment methods present in web but not in mobile

list of Features/ Bug resolutions/ Payment methods present in web but not in mobile
https://docs.google.com/spreadsheets/d/1Y9jP7nsoyYgOugPKN-CqTXWUFCiqrjOsfLOZLhJDwQg/edit?gid=0#gid=0


Add Nodes to Trees

Allow users to add nodes to trees.
Considerations

Provide path
Provide conditional/function?

Creating sorted trees

Currently, values can be added to trees with a path syntax. However, I will keep this issue open for now and consider other ways of adding nodes to trees.

Trees have been removed as part of language redesign.


Add 'Focus to terminal X' action

Fixes #20133

@hun1ahpu tests are failing on Travis:
out-build/vs/workbench/parts/terminal/electron-browser/terminalActions.nls.js:13
	`Focus Terminal ${n}`,
	                  ^
ReferenceError: n is not defined
    at Object.<anonymous> (out-build/vs/workbench/parts/terminal/electron-browser/terminalActions.nls.js:13:20)
    at NodeScriptLoader._loadAndEvalScript (evalmachine.<anonymous>:696:15)
    at evalmachine.<anonymous>:643:31
    at tryToString (fs.js:455:3)
    at FSReqWrap.readFileAfterClose [as oncomplete] (fs.js:442:12)
The command "gulp optimize-vscode --silent --max_old_space_size=4096" exited with 1.

https://travis-ci.org/Microsoft/vscode/jobs/203133143#L3225
Maybe make it a regular static function instead of an variable storing an inline function? Also changing it to getLabel/getId is probably a good idea.

Thanks @hun1ahpu!


Error: Unbound value json_of_Datetime

Since the upgrade to<EMAIL_ADDRESS>and<EMAIL_ADDRESS>all scalar types stopped working.
Compiler crashes with an error like The value json_of_ScalarType can't be found.

I'm guessing 0.2.6 brought a regression, because pinning to<EMAIL_ADDRESS>helps.

It unfortunately sounds like custom scalar encoding might be broken in the latest release, yes. I'll try to get a fix released as soon as possible.

I thought this is a feature. Haha. I have a lot of scala and the previous verisons, I have to cast the type with %identity hack. this time, I just provide a function in scope

Yeah, I thought of adding those functions myself, but was unsure.

This issue is fixed in 0.2.7.
I suggest using Js.Json.string or whatever function you want to produce a Js.Json.t out of your native type, rather than relying on the %identity hack though.


[Fixes #1184] Formatting issues in requests should not cause a 500 respo...

...nse
@yishaigalatzer @rynowak @harshgMSFT

:shipit: after a quick discussion about the feedback

Updated. @rynowak


Update offline books - FY24Q3

(Move to July project when available.)
Update offline books for .NET:

[ ] .NET API reference
[x] .NET Framework Guide
[x] .NET Guide
[x] Visual C#
[x] Visual F#
[x] Visual Basic
[x] .NET MAUI
[x] .NET MAUI API reference
[ ] (.NET Desktop Guide)

Consider also adding books for these TOCs:

https://learn.microsoft.com/en-us/dotnet/core/compatibility/
https://learn.microsoft.com/en-us/dotnet/iot/
https://learn.microsoft.com/en-us/dotnet/azure/
https://learn.microsoft.com/en-us/dotnet/standard/linq/
https://learn.microsoft.com/en-us/dotnet/machine-learning/
https://learn.microsoft.com/en-us/dotnet/standard/data/xml/
https://learn.microsoft.com/en-us/dotnet/framework/configure-apps/
https://learn.microsoft.com/en-us/dotnet/fundamentals/networking/overview
etc.

Associated WorkItem - 199397

.NET API reference book is currently broken, so closing this issue without it.


Fix broken @fieldParentPtr

Fix breakage introduced by https://github.com/ziglang/zig/pull/19470

oops, the test failed, seems like the ci doesn't have the latest build of master branch... probably gonna wait for a new https://github.com/ziglang/www.ziglang.org/actions/workflows/build-tarballs.yml job to be triggered

Yes, lets merge it when that happens. Thanks for the quick work :)

i see new nightly tarball is on the website, would you mind retrigger the ci?


Don't work in web server

In debugging, it works in ide idea, but after building and launching it, it doesn't work on the server.
I run it via python http server.
2:8001/#/:1 Unchecked runtime.lastError: QUOTA_BYTES_PER_ITEM quota exceeded :8001/#/:1 Uncaught (in promise) DOMException: Failed to register a ServiceWorker for scope ('http://localhost:8001/') with script ('http://localhost:8001/flutter_service_worker.js?v=500132782'): The script has an unsupported MIME type ('text/plain'). main.dart.js:2744 Uncaught TypeError: Cannot read property 'B' of null     at Object.iZ (main.dart.js:3973)     at WL.$1 (main.dart.js:47205)     at r0.p (main.dart.js:22895)     at Object.WJ (main.dart.js:13642)     at main.dart.js:47256     at X0.a (main.dart.js:4115)     at X0.$2 (main.dart.js:23581)     at Object.ak (main.dart.js:4101)     at fv.QV (main.dart.js:47297)     at fv.oy (main.dart.js:47245)

Me also not working
Cannot read property 'V' of null

Same here, its its throwing :
js_helper.dart:1129 Uncaught TypeError: Cannot read property 'T' of null     at Object.v6 (main.dart.js?v=2087526842:4045)     at bQU.$1 (keyboard_shortcuts.dart:51)     at o0.v (iterable.dart:442)     at Object.bQS (keyboard_shortcuts.dart:55)     at keyboard_shortcuts.dart:135     at bRh.a (async_patch.dart:315)     at bRh.$2 (async_patch.dart:340)     at Object.y (async_patch.dart:245)     at rd.aq2 (keyboard_shortcuts.dart:130)     at rd.BG (keyboard_shortcuts.dart:130)

Cannot read Property 'G'  of null in webserver

now working

now working


duo gallery should be 150 x 150

placeholder images are correct size but campaign page thumbnails don't seem to be:

also should we update duo on closed campaigns as part of the refactor? (probably should be a separate issue if we want to do that now)

closing as it's a duplicate of https://github.com/DoSomething/dosomething/issues/3758


refactor realm name length in backend

Fix #4211

Replace maxlength value of realm-name in frontend with constant value from backend.

Automated message from Dropbox CLA bot
@baoqchau, thanks for the pull request! It looks like you haven't yet signed the Dropbox CLA. Please sign it here.

@baoqchau while you're at it can you do something similar for the other constants (string_id length, name length, etc.)?
One commit for each all in the same PR is a good model for this.

Automated message from Dropbox CLA bot
@baoqchau, thanks for signing the CLA!

Hi @timabbott. I can do additional refactor works as you want. However, is my work good? Because I did not go through zerver/context_processors.py as you suggest in the issue but just passing it as a constant of Realm model. Just want to make sure before I move on.

Yep, that strategy is great for the /register form, since that's the only place where we render the form.  If we'd need to handle this in 5 different call points, context_processors would be better.

Squashed and merged as 9b6e648acb503eac6f95742c89f20081a7b74480, thanks @baoqchau!


GL_INVALID_OPERATION error when using 'path = screenshot' option

When using the 'path = screenshot' option, I'm getting the following error for each monitor:
LOG] [gl] GL_INVALID_OPERATION error generated. <image> and <target> are incompatible
This results in no screenshot being shown, but instead a completely black background.
Full log:
[LOG]   | got iface: wl_shm v1
[LOG]   | got iface: wl_drm v2
[LOG]   | got iface: zwp_linux_dmabuf_v1 v4
[LOG]    > Bound to zwp_linux_dmabuf_v1 v4
[LOG]   | got iface: wl_compositor v6
[LOG]    > Bound to wl_compositor v6
[LOG]   | got iface: wl_subcompositor v1
[LOG]   | got iface: wl_data_device_manager v3
[LOG]   | got iface: zwlr_export_dmabuf_manager_v1 v1
[LOG]   | got iface: zwlr_data_control_manager_v1 v2
[LOG]   | got iface: zwp_primary_selection_device_manager_v1 v1
[LOG]   | got iface: wp_viewporter v1
[LOG]    > Bound to wp_viewporter v1
[LOG]   | got iface: zwlr_gamma_control_manager_v1 v1
[LOG]   | got iface: zwlr_output_power_manager_v1 v1
[LOG]   | got iface: xdg_wm_base v6
[LOG]   | got iface: wl_seat v9
[LOG]    > Bound to wl_seat v9
[LOG]   | got iface: wp_presentation v1
[LOG]   | got iface: ext_idle_notifier_v1 v1
[LOG]   | got iface: zwlr_layer_shell_v1 v4
[LOG]   | got iface: org_kde_kwin_server_decoration_manager v1
[LOG]   | got iface: zxdg_decoration_manager_v1 v1
[LOG]   | got iface: zwlr_output_manager_v1 v4
[LOG]   | got iface: zwp_keyboard_shortcuts_inhibit_manager_v1 v1
[LOG]   | got iface: zwp_pointer_constraints_v1 v1
[LOG]   | got iface: zwp_relative_pointer_manager_v1 v1
[LOG]   | got iface: zwp_virtual_keyboard_manager_v1 v1
[LOG]   | got iface: zwlr_virtual_pointer_manager_v1 v2
[LOG]   | got iface: zwlr_foreign_toplevel_manager_v1 v3
[LOG]   | got iface: wp_drm_lease_device_v1 v1
[LOG]   | got iface: zwp_tablet_manager_v2 v1
[LOG]   | got iface: zwp_idle_inhibit_manager_v1 v1
[LOG]   | got iface: zxdg_exporter_v1 v1
[LOG]   | got iface: zxdg_importer_v1 v1
[LOG]   | got iface: zxdg_exporter_v2 v1
[LOG]   | got iface: zxdg_importer_v2 v1
[LOG]   | got iface: zwp_pointer_gestures_v1 v3
[LOG]   | got iface: zwp_text_input_manager_v3 v1
[LOG]   | got iface: zwp_input_method_manager_v2 v1
[LOG]   | got iface: xdg_activation_v1 v1
[LOG]   | got iface: ext_session_lock_manager_v1 v1
[LOG]    > Bound to ext_session_lock_manager_v1 v1
[LOG]   | got iface: wp_cursor_shape_manager_v1 v1
[LOG]    > Bound to wp_cursor_shape_manager_v1 v1
[LOG]   | got iface: wp_tearing_control_manager_v1 v1
[LOG]   | got iface: wp_single_pixel_buffer_manager_v1 v1
[LOG]   | got iface: xwayland_shell_v1 v1
[LOG]   | got iface: hyprland_toplevel_export_manager_v1 v2
[LOG]   | got iface: wp_fractional_scale_manager_v1 v1
[LOG]    > Bound to wp_fractional_scale_manager_v1 v1
[LOG]   | got iface: zwp_text_input_manager_v1 v1
[LOG]   | got iface: hyprland_global_shortcuts_manager_v1 v1
[LOG]   | got iface: zwlr_screencopy_manager_v1 v3
[LOG]    > Bound to zwlr_screencopy_manager_v1 v3
[LOG]   | got iface: zxdg_output_manager_v1 v3
[LOG]   | got iface: wl_output v4
[LOG]    > Bound to wl_output v4
[LOG]   | got iface: wl_output v4
[LOG]    > Bound to wl_output v4
[LOG]   | got iface: wl_output v4
[LOG]    > Bound to wl_output v4
[LOG] [core] dmabufFeedbackMainDevice
[LOG] output 49 make BNQ model BenQ BL2480
[LOG] output 49 name HDMI-A-1
[LOG] output 49 description BNQ BenQ BL2480 ABK0159501Q (HDMI-A-1)
[LOG] output 50 make Acer Technologies model XV272U
[LOG] output 50 name DP-2
[LOG] output 50 description Acer Technologies XV272U 0x9481392D (DP-2)
[LOG] output 51 make BNQ model BenQ BL2480
[LOG] output 51 name DP-3
[LOG] output 51 description BNQ BenQ BL2480 ABK0119301Q (DP-3)
[LOG] Locking session
[LOG] eglQueryDmaBufModifiersEXT found 13 mods
[LOG] bo chose modifier 300000000e08014
[LOG] eglQueryDmaBufModifiersEXT found 13 mods
[LOG] bo chose modifier 300000000e08014
[LOG] eglQueryDmaBufModifiersEXT found 13 mods
[LOG] bo chose modifier 300000000e08014
[LOG] onLockLocked called
[LOG] got fractional 1
[LOG] configure with serial 76
[LOG] Configuring surface for logical [Vector2D: x: 1920, y: 1080] and pixel [Vector2D: x: 1920, y: 1080]
[LOG] got fractional 1
[LOG] configure with serial 77
[LOG] Configuring surface for logical [Vector2D: x: 2560, y: 1440] and pixel [Vector2D: x: 2560, y: 1440]
[LOG] got fractional 1
[LOG] configure with serial 78
[LOG] Configuring surface for logical [Vector2D: x: 1920, y: 1080] and pixel [Vector2D: x: 1920, y: 1080]
[LOG] [gl] GL_INVALID_OPERATION error generated. <image> and <target> are incompatible
[LOG] [gl] GL_INVALID_OPERATION error generated. <image> and <target> are incompatible
[LOG] [gl] GL_INVALID_OPERATION error generated. <image> and <target> are incompatible
[LOG] Framebuffer created, status 36053
[LOG] Framebuffer created, status 36053
[LOG] Framebuffer created, status 36053
[LOG] Framebuffer created, status 36053
[LOG] Framebuffer created, status 36053
[LOG] Framebuffer created, status 36053
[LOG] Framebuffer created, status 36053
[LOG] Framebuffer created, status 36053
[LOG] Framebuffer created, status 36053
[LOG] Authenticating
[LOG] Unlocking session
[LOG] Unlocked, exiting!
[LOG] Reached the end, exiting
Segmentation fault (core dumped)

My config file (which is basically just the example config):
general {
    grace = 3
}

background {
    monitor =
    path = screenshot

    # all these options are taken from hyprland, see https://wiki.hyprland.org/Configuring/Variables/#blur for explanations
    blur_passes = 3 # 0 disables blurring
    blur_size = 7
    noise = 0.0117
    contrast = 0.8916
    brightness = 0.8172
    vibrancy = 0.1696
    vibrancy_darkness = 0.0
}

input-field {
    monitor =
    size = 200, 50
    outline_thickness = 3
    dots_size = 0.33 # Scale of input-field height, 0.2 - 0.8
    dots_spacing = 0.15 # Scale of dots' absolute size, 0.0 - 1.0
    dots_center = false
    outer_color = rgb(151515)
    inner_color = rgb(200, 200, 200)
    font_color = rgb(10, 10, 10)
    fade_on_empty = true
    placeholder_text = <i>Input Password...</i> # Text rendered in the input box when it's empty.
    hide_input = false

    position = 0, -20
    halign = center
    valign = center
}

label {
    monitor =
    text = Hi there, $USER
    color = rgba(200, 200, 200, 1.0)
    font_size = 25
    font_family = Noto Sans

    position = 0, 80
    halign = center
    valign = center
}

Not sure if it's relevant, but I'm using the nvidia-dkms driver (version 535) with an RTX 2070 Super on Arch.

Not sure how I didn't see #59 when looking through the open issues, my bad.


Allow overriding _URL

From issue #316
Allowed 'url' kwarg in base.py:MultipleResultsQuery to override _URL easily for any provider.
Example if you want to use geonames paid service:
geocoder.geonames(location, url='http://ws.geonames.org/searchJSON', key=<YOUR KEY>)

🤔 ipinfo failing from rate limiting, i'll merge this PR 👍
=================================== FAILURES ===================================
_________________________________ test_ipinfo __________________________________
    def test_ipinfo():
        g = geocoder.ipinfo(location)
>       assert g.ok
E       assert False
E        +  where False = <[ERROR - 429 Client Error: Too Many Requests for url: http://ipinfo.io/<IP_ADDRESS>/json] Ipinfo - Geocode [empty]>.ok
tests/test_ipinfo.py:11: AssertionError
----------------------------- Captured stderr call -----------------------------
No handlers could be found for logger "geocoder.base"
===================== 1 failed, 90 passed in 20.30 seconds =====================


How to handle the attribute attribute_entries?

@ysb33r realized while writing table support for his leanpub converter that AbstractNode.getAttributes().toString() fails because the attributes hash contains the key :attribute_entries (a symbol) and this is not expected at the moment.
The value for this key is a hash that again contains attributes.
In this case it's the counters for tables, figures etc. that are stored in this subhash.
But also if attributes are declared before a table they will appear nested in this subhash:
:attr: value
|===
...
|===

In this case AbstractNode#attributes[:attribute_entries] contains the key attr.
(Does that make any sense at all to do so? I am unsure, I just realized it while playing with it.)
What I'd like to discuss as part of this issue is how we want to handle this entry.
Options that come to my mind at the moment are:
A. Ignore this entry as the AbstractNode#attr also does not handle this key. Downside would be that there would be no other way to access these values if required.
B. Flatten the nested map so that the content of the nested map. Downside would be that there would be no way to distinguish real attributes from the nested ones.
C. Like A but add a new accessor to the Java interface AbstractNode to give access to the subhash.
D. Like A but only add an accessor for the counter. Downside would be that there would be no way to access the other nested attributes.
Another problem I realized is that if you add a positional attribute to a table the (top-level) attributes contains a key 1 (the number, not the string).
How should we handle that?
Add an own accessor List<String> AbstractNode.getPositionalAttributes()?

I'm inclined to say we should not yet expose this in AsciidoctorJ. This subhash is an artifact of the internal implementation of core and something we've been meaning to change.
For more background, see this issue: https://github.com/asciidoctor/asciidoctor/issues/692
Long story short...document-level attributes need to be nodes in the tree so we don't have to hang them off the side of the next block like we currently do. There are historical reasons for why it is the way it is, but suffice to say we really need to fix this behavior.

Committed change to ignore all attributes whose key is not a string.

:+1:


Reorganize structure of meeting minutes (OneNote)

OneNote section of Notes - Subtab meeting meetings.

links to issue #310. will close and refer to #310


HELP: Performance Issues in JobShop like problem

Hi,
I'm trying to solve a jobShop like problem for a factory floor operations scheduling. I'm using CP-SAT solver.
Now we are facing a performance problem. Seems we spotted a weird behaviour in the solver that we are trying to understand whats is happening under the hood. So maybe you can help me.
We are reading chunks of data from a CSV file like this, each time in larger pieces always starting from the first task (excluding the header) to the length defined:

So for example if I run a chunk of length 25, means I read from the file the range (2, 26) of tasks and so on.

The weird behaviour I noticed is that, when I run the first 200 or 800 tasks the average time is 00:02:30 minutes before I stop the solver without completion. But then when I run the first 900 or 1200 the solving time is 00:00:19.11 and 00:00:42.81 respectively. That's shorter than the 00:02:30 as the average for the above example that not even finished.
So the solver solved faster a large amount of data. That make me wonder if there is something related to the composition of data, some sort of intrinsic order or dependency that must be preprocessed before sending it to the solver. You have any idea of what can be causing this?
Other issue is, I handled to solve 8.000 tasks running with 2 workers in my dual core cpu. It was solved in time 03:30:36.20. How can we solve this in 2 minutes instead of 3 hours? You think running this in a server with 20 - 40 cores could improve the solving time? Or maybe applying some other strategy?
Below I show some of the results I had.
150 tasks

200 - 800 tasks
Solving Time >~ 00:02:30
900 tasks

1.000 tasks

1.200 tasks

1.500 tasks

1.700 tasks

I would say it depends on the data.
Imagine a simple jobshop with one very large job. Without this job, proving optimality is hard.
With this job, just pack it with the highest priority, All the other jobs are easier to pack around the long job (before or after the tasks of the long job), and the optimal is found easily.
I am not sure this is what is happening, but I know the for the same size of problem, data sets can make them ridiculously hard or trivial to solve.

Ok, I'll try to do some analysis and find a way to deal with the data. How about the speedups? There is something I can do to speedup the calculation time? Maybe something built-in inside ORTools? Like the GPU enable in TensorFlow for example.
I tried to use multiple workers. But that only replicates the solver with different start seeds over the multi-threads right? Increasing the chance to find a optimal solution faster in some of the threads. But not actually speedup the calculation process. Correct?
I imagine that internally, at the end, you guys end up with several matrices operations right? Maybe it could be made in parallel multicores or even in GPUs?
Please, give me some light on this issue.

The workers in // are vastly different.
worker 0: default search
worker 1: fixed search if defined, else pseudo cost search
worker 2: simplex off
worker 3: maximum linearization
worker 4: core based search
then lns with different seeds for each additional worker.
Laurent Perron | Operations Research |<EMAIL_ADDRESS>| (33) 1 42 68 53
00
*De : *gustavo-barros<EMAIL_ADDRESS>*Date : *lun. 13 mai 2019 à 13:43
*À : *google/or-tools
*Cc : *Laurent Perron, Comment
Ok, I'll try to do some analysis and find a way to deal with the data. How

about the speedups? There is something I can do to speedup the calculation
time? Maybe something built-in inside ORTools? Like the GPU enable in
TensorFlow for example.
I tried to use multiple workers. But that only replicates the solver with
different start seeds over the multi-threads right? Increasing the chance
to find a optimal solution faster in some of the threads. But not actually
speedup the calculation process. Correct?
I imagine that internally, at the end, you guys end up with several
matrices operations right? Maybe it could be made in parallel multicores or
even in GPUs?
Please, give me some light on this issue.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/google/or-tools/issues/1261?email_source=notifications&email_token=ACUPL3LF5BAN4THJCNI4FRTPVFH57A5CNFSM4HL2VED2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODVIBTNY#issuecomment-491788727,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ACUPL3JWT5DPACCJY3DOUPTPVFH57ANCNFSM4HL2VEDQ
.

Hmmm I see, so the workers actually refer to the way they will search? Thats no multi-threading then?
How can I speedup my application then?

This is multithreading, but not search tree splitting.
As proved here in the parallel section:
https://www.minizinc.org/challenge2018/results2018.html
I believe this is the best way to speed up search.
Laurent Perron | Operations Research |<EMAIL_ADDRESS>| (33) 1 42 68 53
00
*De : *gustavo-barros<EMAIL_ADDRESS>*Date : *mer. 15 mai 2019 à 13:36
*À : *google/or-tools
*Cc : *Laurent Perron, Comment
Hmmm I see, so the workers actually refer to the way they will search?

Thats no multi-threading then?
How can I speedup my application then?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/google/or-tools/issues/1261?email_source=notifications&email_token=ACUPL3LNZXJSH3KNORFOGOLPVPYS7A5CNFSM4HL2VED2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODVOMEKQ#issuecomment-492618282,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ACUPL3JHICA2IPA6KDEWNW3PVPYS7ANCNFSM4HL2VEDQ
.

Hey Laurent,
Could you explain to me how each worker works?

worker 0: default search
worker 1: fixed search if defined, else pseudo cost search
worker 2: simplex off
worker 3: maximum linearization
worker 4: core based search

Or give me some reference to the mathematical/algorithm theory?

You are presuming much.
0 is a variation over vsids.
1 is fixed search if defined, or pseudo cost search from the MIP world
2 is like 0, but with the linearization off,
3 is like 0, but with a maximum linearization
4 is core based search from the sat world.
Actually there is one more called lp_branching.
You can look them up.
I would suggest you look at the code.
Thread specific parameters are defined in cp_model_search.cc, linearization
in the linear* files. Search is in integer_search and in optimization.
These are our theory. We use them because it seems to work.
Le ven. 24 mai 2019 à 19:37, gustavo-barros<EMAIL_ADDRESS>a
écrit :

Hey Laurent,
Could you explain to me how each worker works?

worker 0: default search
worker 1: fixed search if defined, else pseudo cost search
worker 2: simplex off
worker 3: maximum linearization
worker 4: core based search

Or give me some reference to the mathematical/algorithm theory?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/google/or-tools/issues/1261?email_source=notifications&email_token=ACUPL3LQGGUGEDXMHHNGBETPXARVBA5CNFSM4HL2VED2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODWGCO6Q#issuecomment-495724410,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ACUPL3I7CDHZTMJ7AQVFMX3PXARVBANCNFSM4HL2VEDQ
.


[$250]  Android - Review duplicate - App crashes when tapping "Keep all" on modified chat link

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: 9.0.1-0
Reproducible in staging?: y
Reproducible in production?: no new feature
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause internal team
Slack conversation:
Action Performed:

Go to staging.new.expensify.com
On web, open DM with mobile user, copy the report link and add /duplicates/review to the end of the link. (Example - https://staging.new.expensify.com/r/4796612456700465/duplicates/review
)
Send it to mobile user.
As mobile user (Android or iOS), open the DM.
Tap on the link.
Tap Keep all.

Expected Result:
App will not crash.
Actual Result:
App crashes on Android and iOS app.
On web, it shows console error.
Workaround:
unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[x] Android: Native
[ ] Android: mWeb Chrome
[x] iOS: Native
[ ] iOS: mWeb Safari
[x] MacOS: Chrome / Safari - Console error
[ ] MacOS: Desktop

Screenshots/Videos
https://github.com/Expensify/App/assets/38435837/968d59df-4bc4-4d1e-910e-67cccd126b43
https://platform.utest.com/services/links/v1/internal/51927148?.log

View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01e59eefc454d9599a
Upwork Job ID:<PHONE_NUMBER>791543526
Last Price Increase: 2024-06-24
Automatic offers:

bernhardoj | Contributor | 102859572

Issue OwnerCurrent Issue Owner: @allroundexperts

Proposal
Please re-state the problem that we are trying to solve in this issue.
App crashes when pressing Keep all when reviewing duplicates.
What is the root cause of that problem?
transactionIDs can be '-1' here
https://github.com/Expensify/App/blob/425804aa005c6299ff0f59ff596764c429e19abd/src/pages/TransactionDuplicate/Review.tsx#L29
and when they are mapped over here they are added as undefined in the mapped array here
https://github.com/Expensify/App/blob/425804aa005c6299ff0f59ff596764c429e19abd/src/libs/actions/Transaction.ts#L294-L295
and accessing reportID on undefined crashes the app.
What changes do you think we should make in order to solve the problem?
Filter the undefined in the mapped array by modifying this
https://github.com/Expensify/App/blob/425804aa005c6299ff0f59ff596764c429e19abd/src/libs/actions/Transaction.ts#L295
to
const currentTransactions = transactionIDs.map((id) => allTransactions?.[id]).filter((transaction) => transaction);

What alternative solutions did you explore? (Optional)

@OfstadC FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

We think that this bug might be related to #wave-collect - Release 2

Proposal
Please re-state the problem that we are trying to solve in this issue.
App crash when choose Keep all in review duplicates page of a DM chat.
What is the root cause of that problem?
When we open a DM chat and manually append the link with /duplicates/review, it will open the duplicate review page for the DM. But because it's a DM, the transactionID here defaults to -1.
https://github.com/Expensify/App/blob/017605269c9f3a351522784aec04dd12644ec564/src/pages/TransactionDuplicate/Review.tsx#L29
https://github.com/Expensify/App/blob/017605269c9f3a351522784aec04dd12644ec564/src/pages/TransactionDuplicate/Review.tsx#L35
duplicateTransactionIDs is an empty array because there is no duplicate. When we press keep all, it will map the transaction IDs and get the reportID here which will crash the app because there is no transaction with id of -1.
https://github.com/Expensify/App/blob/017605269c9f3a351522784aec04dd12644ec564/src/pages/TransactionDuplicate/Review.tsx#L40
https://github.com/Expensify/App/blob/017605269c9f3a351522784aec04dd12644ec564/src/libs/actions/Transaction.ts#L294-L295
What changes do you think we should make in order to solve the problem?

I think we can show not found page (or any other view, like an empty view saying there is no transaction found) when there is no linked transaction of a report by wrapping the page with FullPageNotFoundView.
<FullPageNotFoundView shouldShow={transactionID === '-1'}>
or
<FullPageNotFoundView shouldShow={!TransactionUtils.getTransaction(transactionID)}>
If we still want to show the page, then we can include the transactionID to the array here only if it's not -1.
https://github.com/Expensify/App/blob/017605269c9f3a351522784aec04dd12644ec564/src/pages/TransactionDuplicate/Review.tsx#L35

@allroundexperts can you please review the proposals for this blocker?

Yep. I'll finalise in an hour or so.

@c3024's proposal looks good to me. Since showing a not found page is something we can decide on while creating the PR, I would go with the first proposal with the correct RCA.
C+ reviewed 🎀 👀 🎀

I'm going to go with @bernhardoj's proposal instead because it's the only one that fully solves the issue. Showing a not found page is the right approach. If we went with the other proposal it wouldn't solve the issue completely, so I think it's most fair to go with the next proposal.

I'm going to fix this myself since it's a blocker and Bernhard isn't around right now.

Either way, thank you so much for fixing it!

@allroundexperts Could you provide an update on this checklist by EOD? Thank you!

Checklist

https://github.com/Expensify/App/pull/41093
https://github.com/Expensify/App/pull/41093/files#r1660187883
N/A
A regression test would be helpful. Steps given in the OP look good to me!

@allroundexperts Could you please mark off each item completed on the checklist 😃 ? Thanks so much!
Payment Summary:
Contributor:  @bernhardoj paid $250 via Upwork
Contributor+: @allroundexperts due $250 via NewDot

@OfstadC I can't edit or mark as complete the checklist message. Usually, the C+ just writes the checklist as I did here.

This was already paid 🤔  - Asking about this here

Already paid - closing

$250 approved for @allroundexperts


Template globals not visible in {% import %}'ed file when it's {% include %}'ed by another file

I've come up with the following minimal repro steps.
Python script:
$ cat test.py
#!/usr/bin/env python3

import jinja2 as j2
import os, sys

print(f'jinja2 version: {j2.__version__}')

env = j2.Environment(loader=j2.FileSystemLoader('.') )
tmpl = env.get_template(sys.argv[1], globals={ 'ENV': os.getenv })
print(tmpl.render() )

Data files:
$ cat common
{% set var1 = ENV('HOME') %}
$ cat file1
{% include 'file2' %}
$ cat file2
{% import 'common' as COMMON %}
{{ COMMON.var1 }}

To repro the issue:
$ python3 test.py file2
jinja2 version: 3.1.3

/root
$ python3 test.py file1
jinja2 version: 3.1.3
Traceback (most recent call last):
  File "/root/void/python/jinja/t1/test.py", line 10, in <module>
    print(tmpl.render() )
          ^^^^^^^^^^^^^
  File "/usr/local/py3/lib/python3.11/site-packages/jinja2/environment.py", line 1301, in render
    self.environment.handle_exception()
  File "/usr/local/py3/lib/python3.11/site-packages/jinja2/environment.py", line 936, in handle_exception
    raise rewrite_traceback_stack(source=source)
  File "file1", line 1, in top-level template code
    {% include 'file2' %}
    ^^^^^^^^^^^^^^^^^^^^^^
  File "file2", line 1, in top-level template code
    {% import 'common' as COMMON %}
    ^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/py3/lib/python3.11/site-packages/jinja2/environment.py", line 1405, in make_module
    return TemplateModule(self, ctx)
           ^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/py3/lib/python3.11/site-packages/jinja2/environment.py", line 1535, in __init__
    body_stream = list(template.root_render_func(context))
                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "common", line 1, in top-level template code
    {% set var1 = ENV('HOME') %}
    ^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/py3/lib/python3.11/site-packages/jinja2/utils.py", line 83, in from_obj
    if hasattr(obj, "jinja_pass_arg"):
       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
jinja2.exceptions.UndefinedError: 'ENV' is undefined

As we can see, python3 test.py file2 works but python3 test.py file1 fails.

Working on this issue for PyCon sprint

@clarkwang The error occurs because globals is being incorrectly passed to get_template. The correct way to add globals to the Jinja2 environment is to set them on the Environment object itself.
#!/usr/bin/env python3

import jinja2 as j2
import os
import sys

print(f'jinja2 version: {j2.__version__}')

# Set up Jinja2 environment and add the global function
env = j2.Environment(loader=j2.FileSystemLoader('.'))
env.globals['ENV'] = os.getenv

# Load the template specified by the first command line argument
tmpl = env.get_template(sys.argv[1])

# Render the template
print(tmpl.render())

get_env_variable Function: You use the os.getenv directly without wrapping it in another function. This makes the template code {% set var1 = ENV('HOME') %} work correctly, as ENV now maps directly to os.getenv.
Setting Global in Environment: By setting env.globals['ENV'] = os.getenv, the environment variable access function is globally available in all templates rendered by this environment.

@j7an adding globals to a template is supported: https://jinja.palletsprojects.com/en/3.1.x/api/#the-global-namespace. That said, you're correct that they're not setting the globals in the correct place. In their example, they set the globals on file1, but it's common that needs access. They should either set the globals on common, or on the environment as you showed.


Schema incompatibility issues

Is the schema in question the DB tables and contents? (https://github.com/lbryio/herald.go/blob/master/db/prefixes/prefixes.go)
...or something else?


precision testing of demanded bits

@zhengyangl Adding you as a reviewer as well because you've worked on this stuff.

I will create a separate PR for souper2llvm script to handle demanded bits and a demanded bits precision testing script that uses s2l.

LGTM, thanks!


[Request] Add 4k, 8k options

Add to this list 2k, 4k, 8k options

The addon is not really being updated anymore so probably won't be added.


JSON-LD Writer Does Not Write @type when Subject is owl:Class

I have a use case where I use an ontology with the triple <http://www.w3.org/2002/07/owl#Class> a <http://www.w3.org/2002/07/owl#Class> .. Starting in RDF4j 2.5.0 through to 3.x the JSON-LD writer does not properly convert this triple. It fully spells out the type predicate instead of using "@type".
[ {
  "@id" : "http://www.w3.org/2002/07/owl#Class",
  "http://www.w3.org/1999/02/22-rdf-syntax-ns#type" : [ {
    "@id" : "http://www.w3.org/2002/07/owl#Class"
  } ]
} ]

I created a sample repo to demonstrate this: https://github.com/daltontc/rdf4jTest
If the runtime version is set to 2.4.6, the JSON-LD is formatted as expected.

Hmz, I'll have to look into this, probably related to an upgrade of the JSON-LD library: RDF4J 2.4.6 uses jsonld-java 0.12.0, while 2.5 uses 0.12.3...

Same in RDF4J 3.5, setting USE_RDF_TYPE to true or false does not make a difference, and not limited to owl:Class (seems like generic issue when subject and object are the same)

It's indeed a jsonld-java issue...

Any chance the fix will be available for 2.x? Or will it only be a 3.x fix?

Well, if you need a solution quickly, you may want to exclude the jsonld-java 0.13 from your project pom.xml, and include the older jsonld-java 0.12.2 instead... That should do the trick...
If it gets fixed in jsonld-java, it will most likely be a rdf4j 3.x -only fix.
Is there a specific reason why you'd prefer a 2.x version as well ?
For most projects, 3.x provides many enhancements and useful features (and in addition, 3.x is tested with JDK 11+), so in general we don't release 2.x versions anymore, unless it's really really needed...

Fixed in the upcoming jsonld-java v0.13.3

@daltontc fixed in the upcoming 3.7.0 release
In the mean time, explicitly adding the recently released jsonld-java v 0.13.3 dependency to the pom / gradle file might do the trick


open /mnt/sda1/var/lib/docker/tmp/GetImageBlob333749989: read-only file system

Expected behavior
Actual behavior
Information about the Issue
Steps to reproduce the behavior

...
...

No information provided or steps to replicate - Closing


Support new loaders logic for group control

Related to https://github.com/datalens-tech/datalens/issues/89


Color Not Showing on Some Geometry

Hello,
I am using Maya 2018 and exported out a glTF file with a character. For the materials, I am using the glTF_PBR.ogsfx shader. Most of the materials simply have a color and normal map plugged in.
However, when I bring in the glTF into several different viewers, they all show the same thing.

Here is a screenshot from Maya.

As you can see, I have some primitive spheres and planes showing the same materials as the materials on the character. The spheres appear to be rendering properly, but not the character.
For another test, I applied a single material to the entire character and just changed the Base Color Factor. No maps were used. I still got a similar issue...

In addition, when the mesh is animated, some faces appear to be flat shaded? I'm not sure if this issue is related.

The normal maps appear to be showing properly, but why are some pieces of geometry not showing color?

Are you using the downloadable released version, or did you build from the develop branch source?
Can you paste the log from the output window and history window, maybe some errors or warnings appear. For example, tangent vectors could be broken.

Hi thanks for the response.
I'm using the downloadable released version. I downloaded the .zip from this page
https://github.com/WonderMediaProductions/Maya2glTF/releases
and executed the deploy.bat file.
Here's the log from Maya's Script Editor.

Is there another output window I should be aware of?

Sorry, I missed your reply.
Yes, it's really the output of the native Maya output window, it looks like:

If you have Maya 2019 installed, you could try the upcoming 1.0 release:
https://github.com/WonderMediaProductions/Maya2glTF/files/4103175/maya2gltf_1.0_a6a059d_maya_2019.zip

Thanks, here is the Output log for Maya 2018. I used the glTF_PBR.ogsfx shader, changed the "Base color factor" to blue, and applied it to every object, so no texture maps were used.
outputLog_blue_farah_static.txt
The resulting glTF export looks like this:

I'll try out the 2019 version, thank you for providing that.

Very strange. Can you also try exporting with the -mts flag?
If you can send me your scene (or just a single polygon from your mesh that has the problem), I will take a look at this.

Okay, so a few things:

I tried the 2019 version of the exporter. For some reason the shader properties were not showing up for me.

Went back to 2018 and tried using the -mts flag. It successfully exported, BUT it still showed the same weird results.

In 2018, I exported out an OBJ with the following settings.

And just to double check, I brought that OBJ back into Maya, applied the same blue material, re-exported as a glTF, and it shows up blue as it should in a glTF viewer!

I then re-exported out as an FBX with the following settings.

I brought this FBX back into Maya, applied the blue material, re-exported as a glTF, and it shows up incorrectly. Still gray.

I've attached the FBX here.
shirt_Binary_2018.zip

If I export out the geometry from Zbrush manually as OBJs (without using GoZ) and re-assign the same materials, I can see the texture maps properly.

I guess this can be a workaround for future models coming from Zbrush to glTF, in case the issue becomes too difficult to find.

Thanks for sharing your model.
Something is really broken with this model, because I import your model, open the UV Set editor, and then clickon the map1 set in Maya, I get the error:
Error: file: C:/Program Files/Autodesk/Maya2018/scripts/others/texturePanel.mel line 1001: No object matches name: Shirt_RENShape.uvSet //
I'm not a Maya expert myself, but it seems somehow the uvSet relationship is broken...
If you pass the following flags: -mpa POSITION|NORMAL|TANGENT to the exporter, it will export without UVs, and then the GLTF will work, but that's not what you want of course.
I think first the error needs to be solved in Maya...

Ah ok. Thank you so much for looking into this!

Nevertheless, I will look into this as soon as I find some time. Indeed, exporting and reimporting as OBJ  fixes the problem.
I noticed that when importing the corrupt GLTF, I get validation warnings that the texture coordinates are not used. I'm curious what is going wrong here...


HOCS-4496 INC2225821: PDF text bleeding off the side

Currently we are "converting" PDF files into PDF files. This serves no purpose and is creating issues: the right edges are being cut off and elements like mathematical formulae can be scrambled.

Skip conversion of PDFs

Let's Smoke test this on QAX on Monday, then I think it's a good candidate for a Monday/Tuesday release


[SPARK-13302][PYSPARK][TESTS] Move the temp file creation and cleanup outside of the doctests

Some of the new doctests in ml/clustering.py have a lot of setup code, move the setup code to the general test init to keep the doctest more example-style looking.
In part this is a follow up to https://github.com/apache/spark/pull/10999
Note that the same pattern is followed in regression & recommendation - might as well clean up all three at the same time.

Test build #51245 has started for PR 11197 at commit bbd8287.

Test build #51245 has finished for PR 11197 at commit bbd8287.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/51245/
Test PASSed.

cc @mengxr who was interested in this cleanup

@holdenk I like this cleanup, thanks for the effort.

LGTM

great :)

maybe @mengxr if you've got a chance to take a look at this?

or @davies or @jkbradley maybe?

Test build #51486 has started for PR 11197 at commit 885210f.

Test build #51486 has finished for PR 11197 at commit 885210f.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/51486/
Test PASSed.

Merged to master


actually tested code cleanup of gamegen.js

Sanity checked [too many times], locally checked, nothing broke, and Developer Tools doesn't report anything bad so, I'mma approve this.


Use dynamic ports for all deployers

@Tratcher @troydai

:shipit:  once the comments are addressed.

:up: :date:

Are you going to update the tests in IISIntegration, ServerTests, and MusicStore to remove the hardcoded urls?

I wasn't going to, current implementation would try to start server on requested url, and only if it's unavailable will assign another port, so these test should be fine.

What happens if the test doesn't specify one? Is there a default?


Extension for size string

Resolved / Related Issues
The code for displaying a size in a localized string is duplicated in many places.
Details of Changes
This pr adds the ToSizeString and ToLongSizeString extensions and uses them wherever possible. This pr is a refactoring without adding any functionality or improving performance, only a more maintainable and centralized code.
Validation
How did you test these changes?

[ ] Built and ran the app
[ ] Tested the changes for accessibility

@yaichenbaum @winston-de Merge fixed.


Warp Sync market design assets

Fleshed out the basic design assets with Tom for this.
https://www.figma.com/file/aAzKHh4cA6OT2t7WFv2BQ7fB/Reporting-and-Disputing?node-id=3782%3A504
todo:

[x] warp sync market needs to be identified, SDK to add a flag
reporting/disputing form, need to not show min/max prices
for open reporting need to populate outcome input from sdk call to get hash
for disputing need to populate outcome input from sdk call, just like open reporting.
need to convert hash to unsigned 256 int for contract call.
[x] hide warp sync market on market list page. SDK needs to filter it out of getMarkets getter

closing moved todos to https://github.com/augurproject/augur/issues/5986


Cheatsheet

Coverage remained the same at 97.038% when pulling 1dfc6c2e8a62132573d90ef894e6d6f2c5fe68ad on cheatsheet into 633cf3ef9ebaf4f24aaf4f07fb5c8f0b1260a4e1 on master.


Update monitoring guide as dependencies are outdated

New versions of Kubernetes can't run the charts anymore.
Upgrading charts version is not enough to make it work since prometheus StatefulSet crashes (kube-prometheus-stack:57.2.1)
Tested on AWS-powered cluster created with eksctl folllowing AWS setup guide.

Hi @nicolopicasso
thank you for pointing this out 🙌
Could you open up a PR to increment the version numbers?

@J12934 Just updating the numbers is not enough. As OP said, the monitoring charts are broken right now.
From my testing:

kube-prometheus-stack 57.2.1 works

web UI accessible
Juiceshop panel loads but has no data obv.

promtail 6.5.15 works

pod starts fine, didn't do more tests

loki 6.5.0 does not work:

Error: template: loki/templates/write/statefulset-write.yaml:50:28: executing "loki/templates/write/statefulset-write.yaml" at <include (print .Template.BasePath "/config.yaml")
...
error calling include: template: loki/templates/_helpers.tpl:228:19: executing "loki.commonStorageConfig" at <$.Values.loki.storage.bucketNames.chunks>: nil pointer evaluating interface {}.chunks

any progress on this?


Update documentation to include import settings

Is your feature request related to a problem? Please describe.
The documentation does not include any explanations about the available (new and old) import settings.
Describe the solution you'd like
Add an additional section to the README.md
Describe alternatives you've considered
None
Additional context
N/A

Implemented in 35bcff611452e68469adcda10461e18bca7a19d3


[Compute] Fix issue #18633: az sig image-version create does not support mixing disks, snapshots, and vhd

Description

Fix issue #18633
Testing Guide

History Notes

[Component Name 1] BREAKING CHANGE: az command a: Make some customer-facing breaking change.
[Component Name 2] az command b: Add some customer-facing feature.

This checklist is used to make sure that common guidelines for a pull request are followed.

[ ] The PR title and description has followed the guideline in Submitting Pull Requests.

[ ] I adhere to the Command Guidelines.

[ ] I adhere to the Error Handling Guidelines.

Compute


opae-sdk: change version to 2.0.11

Signed-off-by: anandaravuri<EMAIL_ADDRESS>

Coverage increased (+0.06%) to 65.645% when pulling 6a8661cbb4523b92062b25d1526a6626b1caa6c1 on aravuri/rev_2_0_11 into de1e57abda1aa71221391ead08e7f864e6e280bc on master.


What is the relationship between shards and minibatches in the wmt example?

Do shards work as minibatching at a higher level? If my training data for MT is pretty small (~100k sentences), can I do 1 shard at all? Thanks.

When we say shards in data generator (t2t-datagen) it just means that we split large files into a number of smaller files. It's usually better to not have gigabyte-sized files, and reading from multiple files can be faster, that's why we do it. And yes, you can use 1 shard for 100k sentences, though I think having 10 is still fine too.

@lukaszkaiser is there any utility for taking a single .record file and splitting it into multiple?


Close missing meminfo stream (Related #12)

Looks like I forgot to add the meminfo class to the commit. Big sorry for that.

No problem. I did not have created the release yet.
Thanks again


The two papers have inconsistencies in their explanations of DC

Hi，author！thanks your contribution on the PPFP! when i was reading “Privacy-Preserving Face Recognition with Learnable Privacy Budgets in Frequency Domain”， it mentioned that when we remove the DC component, it is impossible to reconstruct the image without knowing the DC component.But in this paper "Privacy-Preserving Face Recognition Using Random Frequency Components",the article states that it is possible to reconstruct the original image using only high-frequency information.Could you please explain how to reconstruct using only high-frequency information?

Hi! For the attacker, successful reconstruction depends on various factors, such as training resources (e.g., the amount of training data) and strategy (e.g., loss, optimizer, learning rate). In PartialFace (the "random component" paper), we examine a more advanced attacker that uses a smaller learning rate and leverages a larger training dataset compared to DCTDP (the "learnable budget" paper) and DuetFace (another paper). Empirically, this leads to a more successful recovery.


仓库不包含fer2013.csv数据

please download from: https://www.kaggle.com/c/challenges-in-representation-learning-facial-expression-recognition-challenge/data


DevOps Mutualization SIG Meeting - November 18, 2021

Date
18 NOV 2021 - 12pm ET / 5pm BST
Untracked attendees

Name
Firm
Comment

Meeting notices

FINOS Project leads are responsible for observing the FINOS guidelines for running project meetings. Project maintainers can find additional resources in the FINOS Maintainers Cheatsheet.

All participants in FINOS project meetings are subject to the LF Antitrust Policy, the FINOS Community Code of Conduct and all other FINOS policies.

FINOS meetings involve participation by industry competitors, and it is the intention of FINOS and the Linux Foundation to conduct all of its activities in accordance with applicable antitrust and competition laws. It is therefore extremely important that attendees adhere to meeting agendas, and be aware of, and not participate in, any activities that are prohibited under applicable US state, federal or foreign antitrust and competition laws. Please contact<EMAIL_ADDRESS>with any questions.

FINOS project meetings may be recorded for use solely by the FINOS team for administration purposes. In very limited instances, and with explicit approval, recordings may be made more widely available.

Agenda

[ ] Convene, roll call, welcome new people
[ ] Display FINOS Antitrust Policy summary slide
[ ] Approve previous meeting minutes
[ ] Anders Wallgren resignation as DevOps Mutualization Secretary
[ ] Robb Keayes appointment as DevOps Mutualization Secretary - Discussion, nomination and second required
[ ] Robb Keayes (5-10m) summary of the FINOS NYC member meeting last week
[ ] Toby Weston (10-15m) discussion on SDLC policy as code
[ ] @benjGenesis Question : https://github.com/finos/devops-mutualization/issues/37#issuecomment-970339272
[ ] AOB, Q&A & Adjourn (5mins)

Decisions Made

[ ] Decision 1
[ ] Decision 2
[ ] ...

Action Items

[ ] Action 1
[ ] Action 2
[ ] ...

WebEx info
Webex:
https://finos.webex.com/finos/j.php?MTID=md62056638ba05fbea86b9582df94f807
Dial-in

US +1-415-655-0003 US Toll
UK +44-20319-88141 UK Toll
Access code:<PHONE_NUMBER>

Github Repo: https://github.com/finos/devops-mutualization/
Mailing List: Email<EMAIL_ADDRESS>to subscribe to our mailing list

Hi all - quick intro - I'm Ben from Genesis Global (FINOS member). James M has pointed me to this SIG as I'm looking to tap into some community thinking about how firms, particularly vendors like Genesis, can work together on improving how we approach infosec and devops best practice etc. How are firms organising themselves to deal with this ever growing challenge? Can we learn things from each other? Additionally, it would be great as a community if we could work together to find better and more efficient ways to work together on how we address these challenges.

Richard - Codethink

Hello

Hello!

Hi!

I'm here - Ben Jefferys, Genesis Global

hello :smile:

Hello everyone, Robb Keayes, Nomura

On behalf of the DevOps Mutualization SIG, I'd like to thank @awallgren for his contributions to the SIG in his secretary role over the past year. We look forward to continue working with him in the SIG in the future

@robbkeayes nominated as SIG Secretary by @ashukla13 of Morgan Stanley and seconded by @tobyweston of Deutsche Bank.
@robbkeayes - Welcome to the role of DevOps Mutualization SIG Secretary 👏🏻


Make Example Code to Extract Get INDRA Interactions for a Publication

INDRA currently extracts interactions using various tools. How does GPT-extracted interactions compare? You need to be able to convert either your format to the INDRA format or vice versa. Best to use a format for your summer work that is also compatible with INDRA: https://indra.readthedocs.io/en/latest/modules/assemblers/index.html
Example: https://gist.github.com/cannin/949db7c5a0bbce873704fe90cc58de5a
INDRA accepts either PMC or PMID IDs
https://indra.readthedocs.io/en/latest/_modules/indra/sources/indra_db_rest/api.html

Completed


Header wishlist integration

Task https://app.asana.com/0/1202525679663009/1202720801120417
One model in wishlist:

Empty wishlist

We mustn't show empty lists like that:

I should be either the explicit message: "Nothing is in wishlist" or the emptiness

Please choose the branch from which you started the current one as the merge target. In this way, the change diff will be much smaller

We mustn't show empty lists like that:  It should be either emptiness or an explicit message like "Nothing is in wishlist". I would prefer to the latter

If nothing is in favorites:


install per user without elevated privilege

I'm using AdoptOpenJDK's MSI installer. For some reason, I don't have elevated privilege of the windows machine.
Is there any way (besides extracting ZIP by my own) to install it?

Is there any way (besides extracting ZIP by my own) to install it?

The installation currently runs with ALLUSERS=1 to install in a per-machine context, meaning only one installation of the MSI is allowed on the machine for all users.
No, MSI is designed to install in a per-machine context, meaning only one installation of the MSI is allowed on the machine for all users.
Main installation write to HKLM registry keys to remember folder to remove on uninstall

@douph1 Is there a reason why we went for the per machine as opposed to per user installation?

I don't know, I have just write down the actual state.
All is designed to work per machine from begining.
some interesting hint
https://www.indigorose.com/webhelp/sufwi/Concepts/Per-Machine_vs._Per-User_Installations.htm
If really needeed, there is a lot to re-think..
MSI Upgrade ( will work or not ? )
Per user PATH and JAVA_HOME .. and what to do if installer by administrator ..
Per user jar file association
I think JavaSoft key don't exist per user.
and comming
ITW integration per user
Update notifier per user
Actually the only real possibility is : be admin or use zip file and set PATH/JAVA_HOME yourself
PS: we don't provide .deb ou macOsX installer per user I think :)


streamlink: 6.10.0 -> 6.11.0

Release notes: https://github.com/streamlink/streamlink/releases/tag/6.11.0
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Result of nixpkgs-review pr 346236 run on aarch64-darwin 1

3 packages built:

streamlink
streamlink.dist
wtwitch

Maybe pytest-asyncio could be removed from check inputs? Changelog mentions that it's no longer needed

Oh yeah, thanks, dropped pytest-asyncio.


Problem with operator 'in'

I'm having trouble implementing angular-cache. I get this error:
TypeError: Cannot use 'in' operator to search for '/services/api/public/promotions?page=0&size=2' in null
    at Object.get (angular-cache.js:374)
    at sendReq (angular.js:10295)
    at status.$get.serverRequest (angular.js:10037)
    at processQueue (angular.js:14551)
    at angular.js:14567
    at Scope.parent.$get.Scope.$eval (angular.js:15830)
    at Scope.parent.$get.Scope.$digest (angular.js:15641)
    at Scope.parent.$get.Scope.$apply (angular.js:15935)
    at bootstrapApply (angular.js:1624)
    at Object.invoke (angular.js:4443)

I'm using AngularJS 1.4.1 and JQuery 2.1.4. Could you help me?

Did you destroy the cache and then try to use it?

Thank You. Sorry for the inconvenience.


transform_from_ntt for Plaintext

Why does this not exist? The justification is as follows:
Suppose we have a database of plaintexts, such as in PIR. Because transform_to_ntt is a fairly expensive operation, we pre-process the entire database to convert all plaintexts to ntt form. But if we ever need the content of a plaintext, before doing any cryptographic operations, we essentially have to either 1) store a duplicate database in raw form or 2) multiple by a ciphertext of 1 and then decrypt (or some equally contrived technique).

In BFV or BGV, the NTT form of a plaintext is much larger in size compared to its non-NTT form.


Unable to override part of the configuration

Using version 2.6.3-alpine on kubernetes 1.11, I'm not able to override with this snippet:
apiVersion: v1
kind: ConfigMap
metadata:
  name: tls-config
  namespace: rtf
data:
  broker-01.xml: |
    <?xml version="1.0" encoding="UTF-8" standalone="no"?>
    <configuration xmlns="urn:activemq" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="urn:activemq /schema/artemis-configuration.xsd">
       <!-- from 1.0.0 to 1.5.5 the following line should be : <core xmlns="urn:activemq:core"> -->
       <core xmlns="urn:activemq:core" xsi:schemaLocation="urn:activemq:core ">
          <acceptors>
            <acceptor name="netty-ssl-acceptor">
              tcp://<IP_ADDRESS>:5672?protocols=AMQP,CORE;handshake-timeout=0;sslEnabled=true;needClientAuth=true;keyStorePath=/code/transport/data/keyStore.jks;keyStorePassword=helloworld;trustStorePath=/code/transport/data/trustStore.jks;trustStorePassword=helloworld
            </acceptor>
          </acceptors>
       </core>
    </configuration>

I tracked it down to a bug in the entrypoint.
Output of find /var/lib/artemis/etc-override -name "broker*" -type f before cut:
/var/lib/artemis/etc-override/..2019_06_13_17_45_20.235777075/broker-01.xml

And after the cut:
/var/lib/artemis/etc-override/

Instead the script is expecting:
/var/lib/artemis/etc-override/..2019_06_13_17_45_20.235777075/broker-01

This is confirmed, the usage of cut is very weak here. I recall I used it for compatibility alpine/debian but seems that it didn't work as expected.


504 Gateway Time-out

${voffset 81}${texeci 300 curl -A "Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/74.0.3729.131 Safari/537.36" http://wttr.in/Kyiv_0pq_transparency=200_lang=ua.png -o $HOME/.conky/out.png}
${image $HOME/.conky/out.png -p 0,0}

I can't reproduce it. Do you still have the problem?

But "russian style Kiev" works...

Try 'curl http://wttr.in/Kyiv_0pq_transparency=200_lang=ua.png -o $HOME/.conky/out.png'
And what you`ll get in out.png ?
Already had similar problems (Kyiv not Kiev)

Thank you. It works.


Hot Reload: Subscription

Adds support for Subscription Hot Reloading.
If the Hot Reloading preview feature is enabled, create, update and
delete events to declarative Subscriptions will be reflected in the
Subscriptions runtime without needing to restart the Dapr runtime. Works
in both self-hosted and Kubernetes modes.
Note that, because topic routes and not indexed by Subscription
resources, all Subscriptions will be cancelled and topic routes re-built
and re-subscribed when a Subscription event occurs. A possible
improvement would to only cancel all topic route subscriptions which are
related to the Subscription pubsub or include an index of the
Subscription which a topic is routed for, however this is out of scope
of this change.
Closes https://github.com/dapr/dapr/issues/7139
Docs https://github.com/dapr/docs/pull/4116

@holopin-bot @JoshVanL


[Snyk] Security upgrade System.IdentityModel.Tokens.Jwt from 6.29.0 to 6.34.0

This PR was automatically created by Snyk using the credentials of a real user.Snyk has created this PR to fix one or more vulnerable packages in the `nuget` dependencies of this project.
Changes included in this PR

Changes to the following files to upgrade the vulnerable dependencies to a fixed version:

backend/notifications/Pims.Notifications.csproj

Vulnerabilities that will be fixed
With an upgrade:

Severity
Priority Score (*)
Issue
Breaking Change
Exploit Maturity

626/1000  Why? Recently disclosed, Has a fix available, CVSS 6.8
Resource Exhaustion SNYK-DOTNET-SYSTEMIDENTITYMODELTOKENSJWT-6148655
No
No Known Exploit

(*) Note that the real score may have changed since the PR was raised.
Check the changes in this PR to ensure they won't cause issues with your project.

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.
For more information:
🧐 View latest project report
🛠 Adjust project settings
📚 Read more about Snyk's upgrade and patch logic

Learn how to fix vulnerabilities with free interactive lessons:
🦉 Resource Exhaustion

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (ac38ed0) 64.70% compared to head (cc0c3ea) 64.70%.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files

@@           Coverage Diff           @@
##              dev      #30   +/-   ##
=======================================
  Coverage   64.70%   64.70%
=======================================
  Files         419      419
  Lines       13397    13397
  Branches     1278     1278
=======================================
  Hits         8668     8668
  Misses       4303     4303
  Partials      426      426

Flag
Coverage Δ

unittests
64.70% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Vue-Router seeks and makes use of the first anchor element inside the component

Version
3.0.1
Reproduction link
https://jsfiddle.net/50wL7mdz/250344/
Steps to reproduce
Make a router-link whose tag attribute is not a, and place an anchor element inside it.
What is expected?
The click listener should bind to self.
What is actually happening?
The click listener binds to the first inner anchor element, disregarding self.

There are several things at play here:

I want the whole card to be user-clickable.
I prerender my pages using prerenderer-spa-plugin and I want only the title of the card to be an anchor element for SEO reasons.
Again for SEO reasons, I don't want the whole card to be an anchor element since it will also contain Content and More content as anchor text.

Now I understand where this behavior is coming from, it's trying to prevent a child anchor from triggering a full page navigation. Without using router-link I can get the best of both worlds by making a clickable div whose event does not propagate and trigger the inner anchor while web crawlers still relate /route/3 to I am a good link:

I am a good link

Content

More content

These lines are responsible for this behavior:
https://github.com/vuejs/vue-router/blob/9880cbda8dd299315a253abaab69da00eecdf635/src/components/link.js#L86-L99
Note a shortcoming of this implementation: should the user place more than one anchor element inside the router-link, only the first one will get enhanced while the other ones will still trigger a full page reload. To me that scenario makes little sense and I have no idea of any real use case, but perhaps it should raise a warning.
Is there any 'official' stance on my workaround?

this was intended behaviour, so for the moment, you will have to handle the click yourself on the card, using a .stop and still use router-link (I know, it's one year later)
For the current version of vue-router, a prop could be enough to apply the click behaviour to the root element instead but I'm thinking we might also need a way to disable the click to trigger navigation on the router-link

This can now be solved with the v-slot api of router-link


fix(pie): pie chart avoidLabelOverlap hides label. close #13938

Brief Information
This pull request is in the type of:

[x] bug fixing
[ ] new feature
[ ] others

What does this PR do?

fix chart avoidLabelOverlap hides label even when there are lot's of free space.
Fixed issues

#13938: Pie chart avoidLabelOverlap hides label even when there are lot's of free space

Details
Before: What was the problem?

dx has the direction(1/-1) presentation, if dx < 0; then dx < rA always be true;
But if (-dx) > rA, there would be square root of negative number.
Math.sqrt(dy * dy / (1 - dx * dx / rA / rA))
rB will get NaN.

After: How is it fixed in this PR?

When comparing, dx => Math.abs(dx)

Usage
Are there any API changes?

[ ] The API has been changed.

Related test cases or examples to use the new APIs
NA.
Others
Merging options

[ ] Please squash the commits into a single one when merge.

Other information

Wow thanks for the fix!

Wow thanks for the fix!


Refactor Autotools build

Use non-recursive make.

DO NOT MERGE YET.
This needs a review and testing of the Autotools build on all platforms including training tools and various configure options.

@stweil, can you review and test it?

@stweil, I asked you to test it, not to break it... :-)

I'm sorry. That breakage was not intentional of course. With 16 files involved, chances for a conflict are not so low.
As I am not an expert for autotools, I wonder what could be the advantage of a non-recursive make. Do you have some documentation or examples how projects like Tesseract should use autoconf / automake?

The main advantage is that IMO it is much more readable and easier to understand in that way.
Also I fixed the non-working as intended debug-mode.

include api/Makefile.am
+include arch/Makefile.am
+include ccmain/Makefile.am
+include ccstruct/Makefile.am
include ccutil/Makefile.am
include classify/Makefile.am
include cutil/Makefile.am
include dict/Makefile.am
include lstm/Makefile.am
include opencl/Makefile.am
include textord/Makefile.am
include viewer/Makefile.am
include wordrec/Makefile.am

All these am files now include only list of source files.
The include here is like C/C++ #include - it is equivalent to pasting the content of the included files in the file that includes them.
It's possible to just put the list of source files in the top Makefile.am, or to include just one file that will contain the list of source files.

So all compilations are now using the same compiler flags? That has some disadvantages (unnecessary long include paths) and breaks portability of the generated binaries: if all files are compiled with AVX support, the resulting code will crash on CPUs without AVX.

So all compilations are now using the same compiler flags?

All the library files are using the same flags. I see no problem with that.
I believe that the norm with projects that use other build system like CMake.

If all files are compiled with AVX support, the resulting code will crash on CPUs without AVX.

I don't think so. The 'logic' of the build is in the top Makefile.am. The SIMD flags are still added conditionally.

The condition is based on compiler support, so as soon as my compiler supports AVX or SSE 4.1, those flags are enabled. Now they are used for each compilation. The compiler will generate code with AVX or SSE instructions. That code will crash on a host without AVX or SSE.
I made a branch with your patch at https://github.com/stweil/tesseract/tree/nonrecursivemake and resolved the conflicts.

I can confirm that the debug mode uses -O0 as intended (instead of -O2) with this patch.

If what you say is true, there will be a crash with the current implementation too.

An Alternative Approach to Subdirectories
https://www.gnu.org/software/automake/manual/automake.html#Alternative
Include
https://www.gnu.org/software/automake/manual/automake.html#Include
Non-recursive Automake
https://autotools.io/automake/nonrecursive.html
http://karelzak.blogspot.co.il/2013/02/non-recursive-automake.html

CC: @jbreiden (In your Debian/Ubuntu maintainer hat)

@stweil , I'm sorry about the typo in your name in the commit message!

@stweil,  you seem to like the non-recursive (auto)make idea now.
Should I send a new PR?
The arch directtory will still build an internal automake library that has the simd flags. This should fix the issue you raised here.

Indeed, I now see the advantages of using non-recursive builds.
Maybe you can start with a PR which eliminates a single subdirectory. Then the review is easier, and we can nevertheless discuss whether the principal changes are fine or whether something should be made differently. One example:
I think that code like this:
NAME := n1
NAME += n2
NAME += n3

is easier to maintain than
NAME := n1 \
  n2 \
  n3

Maybe you can start with a PR which eliminates a single subdirectory, for example src/api. Then the review is easier, and we can nevertheless discuss whether the principal changes are fine or whether something should be made differently. One example:

I'll do it.
I'll choose the style you like, shown in your comment.

There's another thing I want to ask you.
Here are 4 ways I can organize this task.

Put all flags and sources in the top Makefile.am.
Put all flags in the top Makefile.am. The list of source files will stay in subdirs.
The top Makefile.am will use 'include...' statements.
See https://github.com/tesseract-ocr/tesseract/pull/974#issuecomment-306538821
Put all flags in the top Makefile.am. The complete list of source files will be in a separate file: Sources.am. No am files in subdirs.
Same as 3, but two files for the source list: Sources.am and  SourcesLegacy.am.

In any case, arch, training and unittest will stay the same as they are now.
All these options will have the same efficiency. All of them will be non-recursive.
What's your preference?

I prefer variant 1. The current files src/*/Makefile.am have 1044 lines in total. That's a size which can be handled easily in a single file. Just make sure that things are in some reasonable order, for example sorted alphabetically.

@amitdo, did you already start working on the non-recursive make, or should I send a pull request?

I didn't, so you can send it.


Upgrade Spotbugs Versions to 4.2.0

Fixes #18990
Upgrades our Spotbugs dependency versions to align on 4.2.0.

@kushagraThapar, do the changes of Double.valueOf to Double.parseDouble look good to you? I did those as SpotBugs was complaining about boxing to a primitive to unbox it on return.


Specified versions of Yamllint and AnsibleLint (fix #641)

Specified the versions of linters -- to avoid unexpected build failures because of linters' updates

Is this because an update to the tool is no longer processing the configuration file with some of the overrides?

I'm going to allow this through again because not having the checks working is causing difficulty in accepting PRs but would be good to make this work with the latest version somehow isntead of being locked to an older one.


Android: "Title only" should show full story title

See this thread:
https://forum.newsblur.com/t/android-show-full-story-title-instead-of-cutting-it-off/9169
Basically there should be a way for titles to not be cut off, and I think if a user is willing to turn off story previews, they should get the full title. At least ~6 lines max (unlike the 2 max we have now).

I think if a user is willing to turn off story previews
But I don't want to turn off.

Only so tall a story can get. I suspect we might want to experiment with a max of 3 lines for story titles by default then.

Sorry I misunderstood you

Please make a maximum of 6 in any variation. And about the preview, everyone will choose what is best for him, 6 or "Title only"

Usually you read the title, and you will be guided by it whether you will read the full content or not.

I suspect we might want to experiment with a max of 3 lines for story titles by default then.

3 is not enough, 6 is just right

And even better to do as in the web version. Automatically increase the number of lines depending on the length of the title.

@samuelclay What is the final request here?

Wrap the title text to max 6 lines when the content preview is disable?
Create a separate settings for title max lines?
Increase default max story title lines to 3.

Currently the app will show 3 lines of text for the story title if the text size is > M.
I'd set the default max story to 3 lines and to 6 lines when the content preview if disable.

Automatically increase the number of lines depending on the length of the title?

I'd set the default max story to 3 lines and to 6 lines when the content preview if disable.

Agreed


Move some commonly used keybinds to common keybinds

Move ctrl+d keybinding from emacs to common keybinds
Move ctrl+w keybinding from emacs to common keybinds

Thanks, Ctrl-d missing was annoying me whenever I tried vi-mode. I think there are some additional quirks that may need to be addressed but let's land that first (e.g. CutWordLeft will place it in the same cut buffer as dw e.g.)


fix: Tranform custom js plugins to es2015

:tada: This PR is included in version 1.5.1 :tada:
The release is available on:

GitHub release
npm package (@latest dist-tag)

Your semantic-release bot :package::rocket:


Conflicts with ESLint & Prettier rules

Describe the bug
After upgrading to the latest versions of ESlint & Prettier which has new rules set, specially large number of multiple class on an element now gets formatted one per line.
<div
      class="
        font-bold
        text-gray-500
        px-4
        py-3
        mx-auto
        flex
        items-center
        justify-center
        custom-class-name
      "
      />

Headwind does it's job & set the classes in one line. That makes the linter add some red lines.
To Reproduce
Steps to reproduce the behavior:

yarn create nuxt-app example-headwind
Choose TailwindCSS / WindiCSS as the UI framework
Choose Eslint & Prettier
Write a long list of classes on an element
Use Headwind

Expected behavior
Headwind needs to respect the linters.
Desktop (please complete the following information):

OS: Arch Linux
Browser: Chrome
Version: Latest (at the time of writing)

Additional Info:
Related dependencies:
"eslint": "^7.22.0",
"eslint-config-prettier": "^8.1.0",
"eslint-plugin-nuxt": "^2.0.0",
"eslint-plugin-prettier": "^3.3.1",
"eslint-plugin-vue": "^7.7.0",
"nuxt-windicss": "^0.4.4",
"prettier": "^2.2.1",

any solution to this?

**Quick-Fix: **

set "headwind.runOnSave" : false

trigger Headwind manually by:

Pressing CMD + Shift + T on Mac
Pressing CTRL + ALT + T on Windows

only run Eslint & Prettier on Save

For me this is currently the best solution, until this problem is really solved

I have replaced this plugin with https://github.com/Acidic9/prettier-plugin-tailwind

I've been using this plugin, https://github.com/Acidic9/prettier-plugin-tailwind for now

@iKlsR are all the classes in one line or are they separated by their own line?

@iKlsR I have done it by disabling prettier but it gives me some problem formatting .js files, in order to keep all my classes in one line
 plugins: ['prettier'],
  // add your custom rules here
  rules: {
    'prettier/prettier': 'off',
  },

Other files like .vue and .jsx work just fine. I know this is not the best solution but I am still figuring out how to solve the problem

Unfortunately I had to uninstall headwind cause of Prettier 2.3.0
Let's see how people respond to suggestion by @adamwathan
https://github.com/prettier/prettier/issues/10918#issuecomment-851049185

Not exactly the best solution, but downgrading to version 2.1.1 of prettier prevented the newline class attributes for me and headwind formatting works as expected. If you can live without v2.2.x, this might be the solution for you.
Note I had to restart VSCode for this to take effect.
Here are my eslint and prettier dependencies:
"eslint": "^7.8.1",
"eslint-config-prettier": "^6.11.0",
"eslint-plugin-prettier": "^3.1.4",
"eslint-plugin-vue": "^6.2.2",
"prettier": "2.1.1",

This is fixed in Prettier 2.5


pipeline: explicitly import importlib.util

Causes a problem with ostree-osbuild on CI (travis) otherwise:
Traceback (most recent call last):
  File "osbuild-ostree", line 345, in <module>
    sys.exit(main())
  File "osbuild-ostree", line 337, in main
    return build(args)
  File "osbuild-ostree", line 257, in build
    output_id, commit_id = build_commit(builddir, args)
  File "osbuild-ostree", line 162, in build_commit
    r = pipeline.run(store.store,
  File "/home/travis/build/gicmo/ostree-osbuild-demo/osbuild/osbuild/pipeline.py", line 358, in run
    r = self.assemble(object_store,
  File "/home/travis/build/gicmo/ostree-osbuild-demo/osbuild/osbuild/pipeline.py", line 314, in assemble
    r = self.assembler.run(input_dir,
  File "/home/travis/build/gicmo/ostree-osbuild-demo/osbuild/osbuild/pipeline.py", line 148, in run
    osbuild_module_path = os.path.dirname(importlib.util.find_

This is weird. Do you have the full stacktrace? The one you posted is truncated.
I am fine with this, but we might run into this again.. sigh

This is weird. Do you have the full stacktrace? The one you posted is truncated.

Sorry about that. Found the old travis log. Will fix the commit message.

I am fine with this, but we might run into this again.. sigh

I think this must be something special to importlib.


Criteria for Unstructured Feedback

Is your feature request related to a problem?
Praktomat 1/2 support the definition of categories a feedback from manual assessments can then be sorted into. Artemis currently only allows a similar approach for inline feedback as part of the structured grading criteria.
At Uni Passau we would like to also be able to sort the ‘unreferenced Feedback’ into criteria.
Describe the solution you'd like
In discussions with @krusche and @fde312 a possible solution for programming exercises has been proposed:

The implementation could be an extension of the already present structured grading.
The unreferenced feedback should get a drop-down menu where a grading criterion from the list of structured grading criteria can be selected.
Mockup: Manual assessment page, adding a unreferenced Feedback:

The selection of a criterion should be optional to still allow for additional, more general remarks.

@krusche remarked that sorting Feedback into criteria could also be of interest for other exercise types. Modeling and Text exercises seem to use the same structured grading approach, a possible implementation should be made flexible to also work for those exercise types.
Additional context
Praktomat 1/2 also allow for a custom grading scale per criterion. However, such adaptability is not required for our use case. The current invariant of result.score = (Σ feedback.points) / exercise.points or any part of the score calculation does therefore not have to be changed in any way.

Structured grading criteria can now be dragged into those kinds of feedbacks as well. This solves this issue.


Add more format buttons

Resolves https://github.com/zulip/zulip/issues/20302
Added the following format buttons:

Inline code
Quote
Spoiler
Code block
Strikethrough
Latex

This is awesome! I really appreciate the thoughtfulness of choosing between $$ $$ and ```math, depending on the selection.
A couple of pieces of feedback from playing around with this:

For spoilers, let's put the cursor at the end of the ```spoiler line (after a space), so that the user can add a title for the spoiler.
Quotes, spoilers and ``` code blocks should insert a leading and/or following line break as needed at the beginning/end. The formatting doesn't work properly if they don't start/end on their own line.

Otherwise, after the conflicts are resolved, I think this will be ready for code review. Perhaps @amanagr could take a look when the PR ready?

Sure!

@juliaBichler01  Thanks for working on this! My review:

Quote / unquote doesn't work properly.
For spoiler and link buttons, I was wondering it would be great if the formatting for them was mentioned in the tooltip itself.
Commits are not proper but they can be improved at the end. See https://zulip.readthedocs.io/en/latest/contributing/version-control.html
I like the extraction of add_formatting.

@amanagr thanks for the review! However, i have some questions about it:

What do you mean with "quote/unquote doesn't work properly"? What exactly is not working properly?
For the spoiler and link buttons: Do you mean having "" and "spoiler ... " in the tooltip?

What do you mean with "quote/unquote doesn't work properly"? What exactly is not working properly?

I mean click on quote icon again should unquote it with the selection remaining the same, even for multiple lines.

For the spoiler and link buttons: Do you mean having  and spoiler ...  in the tooltip?

Yeah, in a more understandable way, so that those who don't know the syntax can understand.

@amanagr Like this?

Because in my opinion, having the format in the tooltip isn't very helpful, because it just looks like a bunch of text without any explanation for the user (if the user is confused by the format, they would probably have to look at the help anyway)
Also i think having the format in two tooltips, but the explanation/name in the other ones, looks a bit inconsistent?

Yeah, I also don't think putting the formatting into the tooltip is working.

I was thinking more along these lines:

But if you guys think it's not working, then cool!

Yeah, I think we can keep the tooltips brief, but this discussion inspired me to file #20868. :)

I tagged this as a release goal, since I think we're getting close, and it would be great to get it done for the 5.0 release.
@juliaBichler01 I think you can skip adding @-mentions for now. @terpimost has suggested that this may be unnecessary, and in any case it would be fine to leave that as a follow-up. I'd prefer to focus on resolving the last bit of feedback regarding  the quote-unquote behavior and getting this PR merged.
Thanks!

@alya i made some progress on the mentions in the last two days, but i could move that to a separate pull request and focus on the feedback first :)

@alya i made some progress on the mentions in the last two days, but i could move that to a separate pull request and focus on the feedback first :)

I think you can just keep the @-mention work in a separate commit in this PR while you focus on addressing the feedback. That way, the rest of the PR can be merged whenever it's ready. Thanks!

@alya but if i have two commits like this:
-> format-buttons -> mentions-button
How can i add more changes to the commit for the format buttons? because if i commit something new and squash this, it gets merged with the last commit, which would be mentions-button?

@alya but if i have two commits like this: -> format-buttons -> mentions-button How can i add more changes to the commit for the format buttons? because if i commit something new and squash this, it gets merged with the last commit, which would be mentions-button?

@juliaBichler01 for help with Git, please post in #git help on chat.zulip.org.

@juliaBichler01 thanks for working on this!  This is good work, and I really appreciate all the tests, but the current commit structure makes it difficult to review, since it combines a large amount of refactoring with adding new features.  Check out our GitHub guide and commit guidelines for background.
I think strategically, what we want do is start with a series of commits that does any required refactoring to the existing implementation (being careful to avoid changing functionality), such that the new features we'll add can call those functions.  E.g. perhaps a strikethrough toggler function could share code with either the LaTeX toggler or the existing bold/italics ones (The latter are hard because of how their syntax is related, though).  And then we potentially can have a block of 3 commits that adds the block syntax elements, and another of 3 commits that does the inline elements, etc., so that we can potentially merge pieces of this that we're fully satisfied with while reviewing the rest, and in any case it'd be possible to just see all the pieces of a given feature.
Doing this will probably require getting more skilled with using tools like git rebase -i and git checkout -p to modify commits, but those are some of the most valuable skills for doing complex software engineering in open source, so it's well worth spending significant time on such a project.

@juliaBichler01 looks very promising. Left a few comments.

@amanagr i implemented your comments, it would be great if you could review this again :)

@juliaBichler01 can you fix the linting errors? Looks go to me for a deploy otherwise.

I did another round of manual QA, and noticed that the | separators disappear inside the three-dot menu. It would be great to fix that as well.

Super excited to see this test-deployed!

@alya just FYI, i fixed the issue with the dividers

@amanagr i fixed the linting error, but the code scanning check is failing because of "incomplete" string escaping, which is supposed to be this way.
Do you know how i can fix this?

You don't need to fix the codeql failure, LGTM.

@alya just FYI, i fixed the issue with the dividers

Cool, thanks! Could you please post a screenshot?

I'm hoping we can test-deploy this on CZO shortly after the 5.0 release.

@alya test deploying sounds great! When exactly is the 5.0 release supposed to happen?
Also, the requested screenshot:

@alya @timabbott hey, i just wanted to ask about the current status of this :)

I believe it's waiting on @timabbott to review and test-deploy on CZO if ready.

Thanks for your work here, @juliaBichler01! I am updating and continuing this work (credited to you) in #26783, to get it integrated.

Closing in favor of #26783, thanks @juliaBichler01!


Support for Postgres unlogged tables when copying tables

Currently CopyTable does not yet support Postgres unlogged tables. Support should be added for unlogged tables to be created consistently when the unlogged materialization_detail is set.

@nicolasmueller is this issue testable by combining this unlogged test with a cache invalidation test that partially invalidates some tables in a stage? https://gist.github.com/windiana42/aae986b9d0b2c1a4fdde43eab6fc2c49#file-test_postgres-py-L14