Patching a role with "add" operation is replacing the tenant patterns

Hi everyone,
I am trying to implement an API call to add tenant patterns to a specific role that is mapped to multiple users and then remove it once the troubleshooting is done.
When sending a request to https://localhost:9200/_opendistro/_security/api/roles/somerole?pretty with the body of:
`[
  {
    "op": "add", "path": "/tenant_permissions/0/tenant_patterns", "value": ["test"]
  }
]`

The tenant patterns are changing from:
` "tenant_permissions" : [
      {
        "tenant_patterns" : [
          "global_tenant"
        ],
        "allowed_actions" : [
          "kibana_all_write"
        ]
      }
    ],`

To this :
` "tenant_permissions" : [
      {
        "tenant_patterns" : [
          "test"
        ],
        "allowed_actions" : [
          "kibana_all_write"
        ]
      }
    ],`

Expected: I would expect the call to add the new pattern to the list instead of acting the same way as the "replace" operation.
Appreciate any help.

IS there anyone that can help ?

Hi @JohnMops, thanks for reporting. This looks like a bug to me. I've reported it over at the security repository as https://github.com/opendistro-for-elasticsearch/security/issues/1099.

Any news on this one? @aetter

Hi @JohnMops, nothing to report. I'm reopening this issue so that we can fix the link (which now 404s) whenever the security team finishes their housekeeping, though.

Hi @JohnMops, nothing to report. I'm reopening this issue so that we can fix the link (which now 404s) whenever the security team finishes their housekeeping, though.

Thank you very much

Hi @JohnMops, I'm going to close this out again in favor of https://github.com/opensearch-project/security/issues/1099


Metacom client-side

Refs: https://github.com/metarhia/Contracts/blob/master/doc/Metacom.md

Landed in https://github.com/metarhia/StarterKit/commit/af55d856ae06b07761f88c19ba5b2e265e6e94d7, https://github.com/metarhia/StarterKit/commit/9957bf081c225881584926657b2ccef6965521d7 and https://github.com/metarhia/StarterKit/commit/6ca52ed450ede3c44ae6b0d9328be15b7dfc6191


[VSCode] Update VS LSP protocol version (feature branch)

This a breaking change which includes updates to fix the VS Code semantic colorization issues we were seeing.

Code looks fine, but it seems like there are 10 other commits coming along for the ride?

Lol yeah, not sure what happened with the commit history but I'm squashing the commits so all should be fine 😄


Create a new file for the brand myslied

this is the first file I added to the brand .
add a file  ,a brand,a pull request

update


[New Plugin]: Auto Enum

Plugin Description
IDA/Binary Ninja Plugin to automatically identify and set enums for standard functions
Plugin Repository URL
Repo URL: https://github.com/junron/auto-enum
Real Release

[X] I have made a real release

Ignore that, the validator script doesn't know how to handle subdirectories.

Sorry for the delay, finally got around to fixing an unrelated issue and ran into the fact that the version string doesn't match. Please either use a release name like "0.1.0" instead of "v0.1.0", or change the field in the plugin.json to match. Preference toward removing the "v" but you can technically do either. Note you might also find this script helpful though I don't know if I've tested it on a subdirectory plugin before:
https://github.com/Vector35/release_helper

Thanks, added!


[v4] Content.ionScroll is missing

Bug Report
Ionic Info
Ionic:

   ionic (Ionic CLI)          : 4.0.6 (/opt/npm/lib/node_modules/ionic)
   Ionic Framework            : @ionic/angular 4.0.0-beta.2
   @angular-devkit/core       : 0.7.3
   @angular-devkit/schematics : 0.7.3
   @angular/cli               : 6.1.3
   @ionic/ng-toolkit          : 1.0.6
   @ionic/schematics-angular  : 1.0.4

Capacitor:

   capacitor (Capacitor CLI) : 1.0.0-beta.4
   @capacitor/core           : 1.0.0-beta.4

System:

   NodeJS : v8.9.1 (/usr/local/bin/node)
   npm    : 6.3.0
   OS     : Linux 4.17

Describe the Bug
There is no ionScroll event emitter on class Content. (There is no ionScrollStart or ionScrollEnd either).
src/app/toolkit/directives/scroll-to-top.ts(52,20): error TS2339: Property 'ionScroll' does not exist on type 'Content'.

Steps to Reproduce
Steps to reproduce the behavior:

import Content
add private content: Content to your component's constructor to get it by injection
try to access to the ionScroll event emitter : this.content.ionScroll
See error

Expected Behavior
We should be able to access the ionScroll event emitter programatically.

This is already fixed in master, next beta.3 (scheduled for this wednesday) will include the fix

@manucorporat Thanks.

@manucorporat Unfortunately, the ionScroll, ionScrollStart and ionScrollEnd properties are now defined on beta.3 but they are non-functional.
The events are correctly triggered when (ionScroll) is used on the <ion-content> element directly. However, nothing is streamed in the content.ionScroll EventEmitter... :(
My code:
this.content.scrollEvents = true;
this.content.ionScrollEnd.subscribe(
  e => console.log('In ScrollToTop-bis: ' + JSON.stringify(e))
);

Would you mind reopening this ticket or should I open a new ticket ?
Also when do you expect to do the next release ?

@manucorporat I suspect that the problem comes from https://github.com/ionic-team/ionic/blob/master/angular/src/directives/proxies.ts#L14 where the proxyOutputs function only creates the EventEmitter but does not proxy the events themselves. Maybe a call to the proxyEvent function from https://github.com/ionic-team/ionic/blob/master/angular/src/util/util.ts#L11 should be added.
Something along the lines:
import { proxyEvent } from '../util/util';

export function proxyOutputs(instance: any, el: ElementRef, events: string[]) {
  events.forEach(eventName => {
    instance[eventName] = new EventEmitter();
    proxyEvent(instance[eventName], el.nativeElement, eventName);
  });
}

Am I wrong ?

@manucorporat I opened a ticket in Stencil (https://github.com/ionic-team/stencil/issues/1025) and a corresponding PR to fix all the event emitters in Angular proxies.

Thanks for reporting this issue! it's already fixed in master of stencil:
https://github.com/ionic-team/stencil/commit/dabcf5ee74cb14c2a7a9f4801ee64b3f20fd48e5
Next version of IOnic will have this fixed!


Fix breadcrumbs on lots with a limit of one service

If a lot has a limit of one service it doesn’t make sense to link to the lot from the service page—it just links to the current page, which we don’t do anywhere else.
This commit adds a condition to hide the link.
Fixes 109072944.

Yep - nice one :+1:


Failing build

Summary
https://travis-ci.org/joel-costigliola/assertj-core/jobs/438379689
ERROR] Errors:
[ERROR]   ObjectArrayAssert_extractingResultOf_Test.extractingResultOf_should_keep_assertion_state:115 » Introspection
[ERROR]   ObjectArrayAssert_extractingResultOf_Test.strongly_typed_extractingResultOf_should_keep_assertion_state:139 » Introspection
[ERROR]   ObjectArrayAssert_extracting_Test.extracting_by_multiple_names_should_keep_assertion_state:402 » Introspection
[ERROR]   ObjectArrayAssert_extracting_Test.extracting_by_name_should_keep_assertion_state:356 » Introspection
[ERROR]   ObjectArrayAssert_extracting_Test.extracting_by_several_functions_should_keep_assertion_state:333 » Introspection
[ERROR]   ObjectArrayAssert_extracting_Test.extracting_by_single_extractor_should_keep_assertion_state:425 » Introspection
[ERROR]   ObjectArrayAssert_extracting_Test.extracting_by_strongly_typed_name_should_keep_assertion_state:379 » Introspection
[ERROR]   ObjectArrayAssert_extracting_Test.extracting_by_throwing_extractor_should_keep_assertion_state:448 » Introspection
[INFO]

All the errors above comes from this one:
[ERROR] extracting_by_name_should_keep_assertion_state  Time elapsed: 0.002 s  <<< ERROR!
org.assertj.core.util.introspection.IntrospectionError:

Can't find any field or property with name 'comparatorsByType'.
Error when introspecting properties was :
- No public getter for property 'comparatorsByType' in org.assertj.core.api.ListAssert
Error when introspecting fields was :
- Unable to obtain the value of the field <'comparatorsByType'> from <org.assertj.core.api.ListAssert@1>, check that field is public.
	at org.assertj.core.api.objectarray.ObjectArrayAssert_extracting_Test.extracting_by_name_should_keep_assertion_state(ObjectArrayAssert_extracting_Test.java:356)
Caused by: org.assertj.core.util.introspection.IntrospectionError: Unable to obtain the value of the field <'comparatorsByType'> from <org.assertj.core.api.ListAssert@1>, check that field is public.
	at org.assertj.core.api.objectarray.ObjectArrayAssert_extracting_Test.extracting_by_name_should_keep_assertion_state(ObjectArrayAssert_extracting_Test.java:356)
Caused by: java.lang.IllegalAccessException: can not accesscomparatorsByType because it is not public
	at org.assertj.core.api.objectarray.ObjectArrayAssert_extracting_Test.extracting_by_name_should_keep_assertion_state(ObjectArrayAssert_extracting_Test.java:356)

is it due to Travis bumping JDK version ?
java version "1.8.0_181"

I do not think it is related to the java 8 version, because the build fails on every java version (9, 10, 11).
I guess the order in which tests are executed is different on travis and some test before the failing tests disables accessing private fields.

fixed by https://github.com/joel-costigliola/assertj-core/commit/905cfdeeb9b01f35bab76377792eaca121146835

Good catch @PascalSchumacher, many thanks !


DB2：Exported Data of Table Missing AutoIncrement Primary key

Info:
dbeaver Version：6.3.0
system OS:            win7
dataBase:              db2
driver:  db2driver_for_jdbc_sqlj_V11.1 /db2jcc.jar
db2driver_for_jdbc_sqlj_V11.1 /db2jcc4.jar
Description: when I use dbeaver export data of a table with 'SQL' format(right click table->export data->"SQL"format  ) .The Output file seems like using the dbeaver's own format ,and The primary key of this table is lost(Output file),then I seek for the result of excuting sql like this  :“select *  from $tablename ”, and generating "INSERT SQL" ,this works . the result contains the primary key,that is to say ,contains ID.But I found the rows of my table was so many that the result can't show and export all. well.I have to report this bug to asking if you guys has found that?

nothing  was responsed,have to close.


Update octokit family with their ESMnized

#716
Passed the test, but there is warning 🤔
><EMAIL_ADDRESS>build
> tsx scripts/build.ts

▲ [WARNING] Import "paginateGraphQL" will always be undefined because the file<EMAIL_ADDRESS>has no exports [import-is-undefined]

    src/github-api.ts:2:9:
      2 │ import { paginateGraphQL } from '@octokit/plugin-paginate-graphql';
        ╵          ~~~~~~~~~~~~~~~

Now reported in upstream: https://github.com/octokit/plugin-paginate-graphql.js/issues/177


[silicon_creator] add OTP DAI read functions to driver lib

This adds several functions to the OTP silicon_creator driver library to enable reading data from non-memory mapped, readable, partitions. This is required to enable measuring said OTP partitions for attestation key and cert generation purposes.

Merging this as the failures are unrelated.


format_aws: Add test coverage

This takes us to 💯 test coverage on format_aws.

@miyunari I'll go ahead and merge this one since it's just tests.


Make Drop fetch response internal method

The keyword is not useful at all and should be made internal only.

Now I remember why I added that keyword: there are usecases when developers do not use the keyword sequence from CamundaLibrary:

fetch workload
complete task | throw bpm error | notify failure | unlock

When the keywords do not fully support the developers use case a developer can still call Camunda REST API directly. Thus it may be convenient to tell CamundaLibrary to forget about the cached process instance.


Fix faq

Description of changes
JSON-passed text for the /faq page includes HTML elements that do not render properly. This change uses dangerouslysetHTML to render as HTML instead of escaped text.
Issue Resolved
Fixes #255

This one is out of my expertise area. I've assigned some more experienced devs to review your work - thanks so much for all of your contributions today!

Of course! It was fun making the tweaks 👍
I did want to leave this here:
https://shripadk.github.io/react/docs/jsx-gotchas.html
It does admittedly use something potentially dangerous, but on the other hand the json in this case is not and never will be user-input?
Alternatively, something like this could be used:
https://github.com/noraesae/react-render-html
I don't know if I'd rather use dangerouslysetHTML or add another dependency. Anyone have thoughts?

Yes use this https://github.com/noraesae/react-render-html

Can you provide more details on why we want to use react-render instead of dangerouslySetInnerHTML?

Nope I was wrong. I just got home so I was able to further research it. This is the way to do it. https://discuss.reactjs.org/t/better-way-to-generate-html-than-to-use-dangerouslysetinnerhtml/298/2

Looks good to me then. Might need to fix up the linter to allow "dangerous" code.

Allow for build to pass by disabling eslint rules for this use case.
eslint-disable-next-line react/no-danger react/prop-types: 0

FYI This build is still failing.

That ESLint Ignore is applied to the wrong line.
You can cordone it off to a section or the whole file.

@Jonchun - Can you move the eslint line (// eslint-disable-next-line react/no-danger react/prop-types: 0) right above the call to dangerouslySetInnerHtml`?
You'll also have to enclose it in {}s (see http://wesbos.com/react-jsx-comments/).
I'm not 100% sure if that will work. If the build is still failing we can just cordon off the entire class: http://eslint.org/docs/user-guide/configuring#disabling-rules-with-inline-comments

@Jonchun sorry about the back-and-forth on this. We're all learning a lot about this situation and are coming from different perspectives. My bad on not keeping communication to this issue - I get in the habit of discussing this repo on Slack.
Anyways!
The PM and I agree that we should just cordon of the whole Class to ensure that the comment syntax makes sense. You've made a lot of contributions to our repository, I hope you'll consider joining us at operationcode.org/join and jumping into the #oc-projects channel to continue making contributions!

Closed because #284 implements fix and will be merged shortly.
@sethbergman let's make sure that we assign ourselves issues so that we don't work on the same issues simultaneously!


How to configure to work with scrollable child element

Bug report/feature request/question:
Is there a way to configure this to show all content in a scrollable child element? for example, all the content inside this box:

I've tried many different combinations of options but they all end up with the same result: only what is scrolled into view within the 500px of the box height shows up in the generated canvas.
The library seems to work fine with scrollable content on the whole page with this configuration:
const options = {
  scrollX: 0,
  scrollY: -window.scrollY,
  windowWidth: document.documentElement.offsetWidth,
  windowHeight: document.documentElement.offsetHeight,
};

But the same options don't work when rendering a canvas for a specific scrollable child element.
Specifications:

html2canvas version tested with: 1.4.1
Browser & version: Chrome 98.0.4758.109
Operating system: MacOS monterey 12.0.1

did you find anything?


Rustup to rustc 1.19.0-nightly (2d4ed8e0c 2017-05-03)

@bors r+

For the sake of easy cross-reference, it looks like this is the pertinent rustc changeset: https://github.com/rust-lang/rust/pull/41625


Exit on rodeos filter wasm error

Change Description

Report filter wasm exceptions as errors so it is clear exception is from the filter wasm.
Shutdown rodeos on error since there is no retry logic. This should make it easier to monitor the executable.

Consensus Changes

[ ] Consensus Changes

API Changes

[ ] API Changes

Documentation Additions

[ ] Documentation Additions

Is retry logic scoped for rodeos before a public alpha/beta release?  or is the long-term expectation that failure equates to "halt and catch fire"

Is retry logic scoped for rodeos before a public alpha/beta release? or is the long-term expectation that failure equates to "halt and catch fire"

@tbfleming

If a wasm fails, retrying it would get the same result, so it doesn't. Unless there's a determinism bug...
It retries when there's a ship connection failure.


add a command that runs a list of commands in parallel and aggregates results

Input should be a csv file with columns:

name
bash command to run
output files to save

Run it with something like:
./kubeface-run-commands commands.csv --out-dir /path/to/results

Results should be written to outdir as directories for each command (named by name), with the output files for the corresponding command in each directory.
Consider

Is there an existing standard interface for this kind of thing that should be supported? Perhaps gnu parallel?
Other output formats that may be more convenient for common cases, like a flat directory of files if there is only one output file to collect per command

What is an example of the commands.csv @timodonnell ?

Thinking of something like this:
name,command,input_files,output_files
run1,wc -l $1 > result.txt,/path/to/some/text/file.txt,result.txt
run2,wc -l $1 > result.txt,/path/to/another/text/file.txt,result.txt

Can discuss in person

The result from running the above would be a directory with run1/result.txt and run2/result.txt

GNU parallel can do that for you:
https://www.gnu.org/software/parallel/parallel_tutorial.html#Remote-execution
Wouldn't try to implement something from scratch since I have been trying out different options to do this in a nice and tidy way and can't stress the number of edge cases to be dealt with for a ground-up solution.
Assuming that you don't want to turn this into an advanced task scheduler project, I would just wrap parallel and call it a day ;)


max_age property of the cookie component is not respected

Here are response header :
HTTP/1.1 302 Found
content-length: 0
set-cookie: session=stFQ86rHXM3WaR6NLzw3N17pEYVx5Cae; HttpOnly; SameSite=Strict; Path=/
location: admin.sql
content-security-policy: script-src 'self' https://cdn.jsdelivr.net
content-type: text/html; charset=utf-8
server: sqlpage v0.24.0
date: Fri, 12 Jul 2024 19:53:46 GMT

Originally posted by @anayrat in https://github.com/lovasoa/SQLpage/discussions/498#discussioncomment-10035358

Reproduction:
select 'cookie' AS component,
    'session' AS name,
    'xxxvaluexxx' AS value,
    3600 AS max_age;


In progress: "Reduced Fat" start_paper

By request, this branch has not been called "lite".
Will address #58, among other things.
Cookiecutter is a pain. Let's see if we can do without it, and make start_paper easier to use in the process. In addition, we're planning to move the documentation of how to write notes in various formats elsewhere.

[x] Remove demo note
[x] Reorganize files
[x] Eliminate cookiecutter variables
[x] Exchange texmf for desc-tex
[x] Get the latex note to work again
[x] Devise alternative deployment mechanism (probably bash-based, but let's see)
[ ] Do something about metadata and travis files
[ ] New README
[ ] Reduce to a minimal working example? (Not before external documentation exists, probably.)

As discussed with each of you at the last meeting, I have attempted to eliminate the use of cookiecutter in order to simplify deployment. I seem to remember that some of the trouble that CCL has had is with mkauthlist, but haven't done anything with that (except for making it run only when authors.csv changes). It would be nice to have a default authors.tex to avoid mkauthlist initially, but I'm not sure what it would need to contain to satisfy all the possible docswitch options (or if that's even possible).
As for deployment, I think the solution is just to use GitHub's "Download zip" option, which can of course be wrapped in shell if we want to (details would change if this goes into the master branch)
wget https://github.com/LSSTDESC/start_paper/archive/reduced_fat.zip
unzip reduced_fat.zip
cd start_paper-reduced_fat

At least on my system, I can download and make main without any trouble. On the first call, desc-tex will be auto-cloned, and mkauthlist gets run.
There are numerous changes in the Makefile, mostly to do with the use of desc-tex, but have a look.

The issues with mkauthlist were mostly related to pip installation without root access and adding the proper binary directories to the users path.

Ok. So, if we can provide a default authors.tex that lets the paper compile w/o calling mkauthlist, that would help a bit (without actually solving anything long-term).

We could provide an author list for the descnote class, but it isn't possible to provide a file that would work with all classes.

Surely there's a countable number of commands that one would need -
presumably just \author{placeholder} in most cases.
But if it's really that bad, I'd be ok with one that just works with Note
(and plain latex).

Another idea: could we grab the mkauthlist source from github the same
way we do for desc-tex and do a local install from source? Maybe that
would bypass any permissions-related issues.

Yeah, the local install was my plan (don't even need to grab any source code, just pip install with the right prefix). You can try to simplify the author list file, but you don't get affiliations, collaboration, or contributions. If things were simple to do generally, mkauthlist wouldn't exist...

I think we should discuss how flexible we want to be with creating author lists. Maybe we want to have separate make commands for the author list and the full pdf.

We effectively already do, in this branch. One can make authlist (or similar). When compiling tex, mkauthlist is only called if authors.tex does not exist, or if authors.csv is newer. This would accomplish a full separation of the two tasks if there were such a thing as a generic working authors.tex, but as you've pointed out there isn't.
One (tiny) advantage to grabbing mkauthlist from github is that in principle it never need be installed at all, just imported from the local directory (assuming it's pure python). That means the user doesn't even need pip, just git and python.

I would say that it is a "trade" rather than "advantage". You lose all the things pip does to version control and check dependencies. In the long term, I don't think we want make update to grab the master, we want it to grab the latest released version of desc-tex, mkauthlist, start_paper, etc.

Re: generic version of authors.tex. Why not just distribute a blank file? That should be compatible with every tex class.

Why not just distribute a blank file? That should be compatible with every tex class.

Good thought. I will try this.
As for mkauthlist, how about the following:

If it's not installed, get it.
If it is installed use it.
Look for an update only when making update, rather than every time.

I'm tempted to include all updates in update (desc-tex, mkauthlist and templates) as well.

If it's not installed, get it.

Yep. I think there are two parts to this.

Determine whether it is installed. This could be done with a shell command (which mkauthlist) or through pip (don't know off hand how to tell pip to only install if doesn't exist , but it must exist).
For the install I would use pip with something like  pip install mkauthlist --prefix=$PWD (pseudo code). We also don't want to upgrade dependencies if we can avoid it (i.e., numpy).

If it is installed use it.

Yep. In order to use it, we need to make sure the Makefile to adds the necessary items to the PATH (the mkauthlist bin directory) and PYTHONPATH (the mkauthlist source directory)

Look for an update only when making update, rather than every time.

Yep. I agree completely. This was actually my intent originally, but I didn't realize that pip would try to upgrade every time.

I think the latest commits cover all of this. Pass localpip=T on the command line for the local install option (I left it as F by default because the bin/ and lib/ directories it creates seem untidy).

Installing the package to the local directory should be more robust than using --user. They only need write permission to the CWD, which I think we can assume they have. The Makefile then looks for ./bin/mkauthlist to run it, and identifies the directory that needs to be on PYTHONPATH on the fly (in a slightly dangerous, but probably acceptable way).
Based on this, I think only-if-needed is what we want. It should prevent numpy from being updated, unless the requirements info for mkauthlist said that it needs a more recent version (which will probably never happen, but if so we should do the update). In the unlikely event that the user doesn't have numpy, it still needs to be installed, which --no-deps will not do. (--upgrade-strategy only applies to dependencies - I think the package you've asked to update is always updated only if there's a newer version.)

Oh, I now realize that your first comment was aimed at the localpip=F case. I was thinking that if people have trouble with a sitewide installation, they would just go straight to the CWD installation.

Ok, sounds fine. I'm not sure you will ever be able to remove mkauthlist completely, unless Brian is going to design an entire web frontend to do explicit author list ordering (this was never done for DES or Fermi).

I added a bash script for downloading as ZIP, unzipping and renaming a repo from GitHub. The idea would be for people to get it manually if they want to, and use it to deploy a non-versioned start_paper. (The whole thing can be done manually, of course.)
Anyway, it seems like we're ready for someone else to test the changes so far, if you're up for it. The default in the script is to get the master branch, so you'd need to specify reduced_fat for the moment.
@drphilmarshall , I think it would make sense to remove the metadata.json file from this branch, since it's no longer used. I don't know about travis, but it would need to be somehow de-cookified to be consistent with the rest of the branch.

Just reiterating that this branch is ready for independent testing. See the new README for instructions. If using the deploy script, the invocation is
./deploy_from_github_zip.bash MyNewPaper LSSTDESC/start_paper reduced_fat
(so that it knows not to get the master branch).
@drphilmarshall , following our chat just now, I verified that invocations like make apj still work. I also still do not have write permissions (not that we're ready to merge this second). I don't think this is a matter of the master branch being locked; the message says:
"This pull request can be automatically merged by project collaborators.
Only those with write access to this repository can merge pull requests."

Hmm - I checked the paper_starters team and you're on it, @abmantz . I think the problem was the master branch protection - I just gave you push permissions to master, so you should be OK to merge things now, when we're ready.

Yes, that appears to have done it. Strange that the message was so misleading.

It was only testing the Note about start_paper, not actually running
start_paper. It's a good idea to have start_paper under continuous
integration, but I think this can be issued for the future. (I'll try to
remember to keep a copy of the .travis.yml file.)

Indeed. We were talking offline about eventually having the Note about start_paper live in master and the actual files people would download in a different branch. It would be fine for master to use CI, which would also serve as an example of how to do it, but the deployed start_paper files don't assume the use of git/github. If there's demand, we could always add a useable travis file back in, but the current version had cookiecutter variables in it, so it would need some work.

Just for context, this review had been sitting around unclosed for more than a month. I stumbled across it and figured it would be good to submit in case anything was useful. Sounds like everything had been considered.


Is there a way to resize map?

Hi @dburles,
I'm trying to implement google maps in a modal. The issue I'm having now is I'm unable to refresh the map after the modal has loaded. I did some googling and doing that in normal javascript is by calling google.maps.event.trigger(map, "resize"); Is there a way I can do that through your package?

Fixed it... the problem was from my map instance. Got it to work by using..
google.maps.event.trigger(GoogleMaps.maps.propertyMap.instance, 'resize');


full Ru guide book translation. Plus some minor fixes in items to match the book

Could you resolve the merging conflicts? @caffeineggs

Could you resolve the merging conflicts? @caffeineggs
It doesn't like one of the names i've changed. No idea why


Update logic for Increment Version Number

Problem
If you define the repoVersion in .github/AL-Go-Settings.json it isn't updated when running the Increment Version Number workflow. In our case, the would like to keep the repoVersion the same across all Al-Go projects so having repoVersion defined on repo level makes sense for us (even if it is a project setting)
Proposed Solution

If repoVersion exists on project level (recommended), we only update it there.
If repoVersion doesn't exist in project level but exists on repo level, we update it on repo level (what we want in our case)
if repoVersion is neither defined on project level or repo level, force create it on repo level
if projects is * then we update the repoVersion both on project level and repo level (if they already exist)

Fixes #1105

Looking at the PR description:

if repoVersion is neither defined on project level or repo level, force create it on repo level
if projects is * then we update the repoVersion both on project level and repo level (if they already exist)

According to the code - it looks like it is force created on the project level if it doesn't exist (which I think is correct) - meaning that the description is wrong, right?
On the last line - I don't think we are updating the repoversion on the repo level if it exists in all projects - do we?

Looking at the PR description:

if repoVersion is neither defined on project level or repo level, force create it on repo level
if projects is * then we update the repoVersion both on project level and repo level (if they already exist)

According to the code - it looks like it is force created on the project level if it doesn't exist (which I think is correct) - meaning that the description is wrong, right?
On the last line - I don't think we are updating the repoversion on the repo level if it exists in all projects - do we?

You're right :) The description was wrong. It should reflect the code now.


Enums with different multiple casings generate invalid typescript

Describe the bug
GraphQL schemas with multiple differently-cased enum values generates invalid typescript.
Using Braintree graphql schema https://github.com/braintree/graphql-api/blob/master/schema.graphql
To Reproduce
Steps to reproduce the behavior:
https://codesandbox.io/s/gifted-mirzakhani-dc4px?file=/types.ts

My GraphQL schema:

enum ClientConfigurationEnvironment {
  DEVELOPMENT
  PRODUCTION
  QA
  SANDBOX
  TEST
  development
  production
  qa
  sandbox
  test
}

My GraphQL operations: N/A

My codegen.yml config file:

schema: schema.graphql
generates:
  types.ts:
    plugins:
      - typescript

Expected behavior
Typescript output:
enum ClientConfigurationEnvironment {
  "DEVELOPMENT",
  "PRODUCTION",
  "QA",
  "SANDBOX",
  "TEST",
  "development",
  "production",
  "qa",
  "sandbox",
  "test",
}

Actual Behavior
export enum ClientConfigurationEnvironment {
  Development = 'DEVELOPMENT',
  Production = 'PRODUCTION',
  Qa = 'QA',
  Sandbox = 'SANDBOX',
  Test = 'TEST',
  Development = 'development',
  Production = 'production',
  Qa = 'qa',
  Sandbox = 'sandbox',
  Test = 'test'
}

It looks like there are already configuration options in place to deal with this sort of thing.
generates:
  src/sdk.ts:
    plugins:
      - typescript
    config:
      namingConvention: keep


Bumped cryptography from 3.3.2 to 39.0.1

Change(s):

Bumped cryptography from 3.3.2 to 39.0.1

Reason for Change(s):

Updated cryptography from 3.3.2 to 39.0.1

Version Updated:

No

Testing Completed:

Yes

Hi @v-rucdu, please provide your feedback on this. Thanks

Closing this PR, as informed partner to update their cryptography to latest version... Thanks!!!

@v-atulyadav : Changes have been committed. Kindly review and let me know you if anything else is still required.

Hi @dhara-shah-sp, could we have a call to discuss this? We will correct these changes over the call. We work in IST timezone.

Sure. What is your good email address where we can discuss further about setting up a meeting?
I can be reached out via email at<EMAIL_ADDRESS>. I work in CST timezone
Regards,
Dhara Shah
Software Engineer II
<EMAIL_ADDRESS>From: v-atulyadav @.>
Date: Wednesday, June 7, 2023 at 05:44
To: Azure/Azure-Sentinel @.>
Cc: Dhara Shah @.>, Mention @.>
Subject: Re: [Azure/Azure-Sentinel] Bumped cryptography from 3.3.2 to 39.0.1 (PR #8054)
Hi @dhara-shah-sp, could we have a call to discuss this? We will correct these changes over the call. We work in IST timezone. — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you were
ZjQcmQRYFpfptBannerStart
This Message Is From an External Sender
This message came from outside your organization.
ZjQcmQRYFpfptBannerEnd
Hi @dhara-shah-sphttps://urldefense.com/v3/__https:/github.com/dhara-shah-sp__;!!MsNKLpFGsw!Lrbs6mIXoRNWncHj9-5ZbbK7d_xxPTAQkDBWcJynOXH8Bgmyd0CNKgfBNiDhixanqHYTfUS5dCXT3fmBF-HTMtg201s$, could we have a call to discuss this? We will correct these changes over the call. We work in IST timezone.
—
Reply to this email directly, view it on GitHubhttps://urldefense.com/v3/__https:/github.com/Azure/Azure-Sentinel/pull/8054*issuecomment-1580492160__;Iw!!MsNKLpFGsw!Lrbs6mIXoRNWncHj9-5ZbbK7d_xxPTAQkDBWcJynOXH8Bgmyd0CNKgfBNiDhixanqHYTfUS5dCXT3fmBF-HTwTqPYHQ$, or unsubscribehttps://urldefense.com/v3/__https:/github.com/notifications/unsubscribe-auth/AMSEXURYDPZBPIO5MLS5LE3XKBLSJANCNFSM6AAAAAAYD57XPM__;!!MsNKLpFGsw!Lrbs6mIXoRNWncHj9-5ZbbK7d_xxPTAQkDBWcJynOXH8Bgmyd0CNKgfBNiDhixanqHYTfUS5dCXT3fmBF-HTO8wyaao$.
You are receiving this because you were mentioned.Message ID: @.***>

<EMAIL_ADDRESS>is my email id, please schedule a call. Thanks

@microsoft-github-policy-service agree [company="{SailPoint}"]

@microsoft-github-policy-service agree company="SailPoint"

Hi @dhara-shah-sp, please attach screenshots of the successful running connector logs and also make sure the folder structure is correct as we discussed. The first level is SearchEvent.zip and the second level is all files contained within it. please refer below correct folder structure screenshots

Hi @dhara-shah-sp, waiting for your response. Thanks

Hi @v-atulyadav : I will be submitting the changes by end of the week. Thank you!

@v-atulyadav kindly review the recent changes and let me know your feedback. Thank you!

Hi @dhara-shah-sp, please download below attached zip and include in path Solutions/SailPointIdentityNow/Data Connectors/ and then share successful running data connector/invocation log screenshots.
SeachEvent.zip
For dataconnector invocation log screenshots, please click on function name then select monitor tab. Refer below example screenshots

Hi @dhara-shah-sp, looking forward to your response. Thanks

Hi @dhara-shah-sp, if you are experiencing any challenges with changes, please contact me. Thanks

@v-atulyadav  Kindly find the attached successful running data connector/invocation log screenshot

Hi @dhara-shah-sp,
There is still a problem with the folder structure. We need to schedule a call to discuss this.
Thanks

Hello @v-atulyadav : Can you please elaborate on what the issue is ? Because I exactly followed the steps you mentioned earlier. I am unsure of what more is to be done here.

Hi @dhara-shah-sp, I have attached a zip file with proper folder structure above, please include this zip in the suggested path below.

Your zip file has the following folder structure

Hi @dhara-shah-sp, waiting for your response. Thanks


Gate js-sys dependency behind 'wasm-bindgen' feature (#496)

This just broke a handful of builds for us as well. Commenting here to keep the issue bumped.

I'm getting a build error
   |
59 |     pub fn now_utc() -> Self {
   |            -------      ^^^^ expected struct `OffsetDateTime`, found `()`
   |            |
   |            implicitly returns `()` as its body has no tail or `return` expression

No build errors here but I was wondering why my time-using crate suddenly started pulling in js-sys:
 [[package]]
 name = "time"
-version = "0.3.11"
+version = "0.3.12"
 source = "registry+https://github.com/rust-lang/crates.io-index"
-checksum = "72c91f41dcb2f096c05f0873d667dceec1087ce5bcf984ec8ffb19acddbb3217"
+checksum = "74b7cc93fc23ba97fde84f7eea56c55d1ba183f495c6715defdfc7b9cb8c870f"
 dependencies = [
  "itoa",
+ "js-sys",
  "libc",
  "num_threads",
  "time-macros",

@brooksmtownsend The PR has only been open a couple days. I will review it when I get the chance. I am well aware that this broke some things.

Thanks @xy2iii that latest change works for wasm32-unknown-unknown.


Prototyping a fix for: Pipenv Does Not Respect Index Specified For A Package

Code changes that fix the indexes not being respected into the CI to see if any other tests are failing (locally they are in a good spot).   Acknowledged that this modifies code in pip, and so I will need extra considerations on how to proceed.   Yet without this logic, there is no way to enforce the index specifications are abided by during resolution and installation.   After several iterations of trying to understand this code and how to fix it, it feels like the LinkCollector''s SearchScope should have the knowledge it needs to return the right indexes at the right times.
The issue
Pipenv Lock (Or Install) Does Not Respect Index Specified For A Package  https://github.com/pypa/pipenv/issues/4637
The fix
Without this or similar logic, there is no way to enforce the index specifications are abided by during resolution and installation.   After several iterations of trying to understand this code and how to fix it, it feels like the LinkCollector''s SearchScope should have the knowledge it needs to return the right indexes at the right times.  Otherwise the pipenv resolver is totally disconnected from the pip resolver in terms of these specifications.
The checklist

[X] Associated issue
[ ] A news fragment in the news/ directory to describe this fix with the extension .bugfix, .feature, .behavior, .doc. .vendor. or .trivial (this will appear in the release changelog). Use semantic line breaks and name the file after the issue number or the PR #.

Note:  There appears to be 1 failing test when they are run together, but that test passes in isolation.   I'll have to find more time to investigate that.
(pipenv) matteius@matteius-VirtualBox:~/pipenv$ python -m pytest -sv -k test_install_specifying_index_url
======================================================= test session starts ========================================================
platform linux -- Python 3.10.2, pytest-6.2.5, py-1.11.0, pluggy-1.0.0 -- /home/matteius/.virtualenvs/pipenv-wR0g04D--3.7/bin/python
cachedir: .pytest_cache
rootdir: /home/matteius/pipenv, configfile: setup.cfg, testpaths: tests
plugins: flaky-3.7.0, forked-1.3.0, xdist-2.4.0, timeout-2.0.1, pypi-0.1.1
collected 282 items / 281 deselected / 1 selected

tests/integration/test_install_uri.py::test_install_specifying_index_url $ pipenv install pipenv-test-private-package --index https://test.pypi.org/simple
Installing pipenv-test-private-package...
Installing dependencies from Pipfile.lock (b8219d)...
To activate this project's virtualenv, run pipenv shell.
Alternatively, run a command inside the virtualenv with pipenv run.

Creating a virtualenv for this project...
Pipfile: /tmp/pipenv-a70hf424-project/Pipfile
Using /home/matteius/.virtualenvs/pipenv-wR0g04D--3.7/bin/python3 (3.10.2) to create virtualenv...
created virtual environment CPython3.10.2.final.0-64 in 811ms
  creator CPython3Posix(dest=/tmp/pipenv-a70hf424-project/.venv, clear=False, no_vcs_ignore=False, global=False)
  seeder FromAppData(download=False, pip=bundle, setuptools=bundle, wheel=bundle, via=copy, app_data_dir=/tmp/pipenv-2zxclxjk-test/home/.local/share/virtualenv)
    added seed packages: pip==21.3.1, setuptools==58.3.0, wheel==0.37.0
  activators BashActivator,CShellActivator,FishActivator,NushellActivator,PowerShellActivator,PythonActivator

Successfully created virtual environment!
Virtualenv location: /tmp/pipenv-a70hf424-project/.venv
Adding pipenv-test-private-package to Pipfile's [packages]...
Installation Succeeded
Pipfile.lock not found, creating...
Locking [dev-packages] dependencies...
Locking [packages] dependencies...
Building requirements...
Resolving dependencies...
Success!
Updated Pipfile.lock (b8219d)!

PASSED

================================================ 1 passed, 281 deselected in 21.85s ================================================

I narrowed down the test failure:  specifically which other test cannot be run with the failing test, if you run this pytest command, the current suite fails and I suspect it is because both of these tests pass in --index and that ends up contaminating something (the tests are not fully isolated)  However if you reverse the order of these two tests they both pass, which I find very odd.
python -m pytest -sv tests/integration/test_install_uri.py::test_install_named_index_alias tests/integration/test_install_uri.py::test_install_specifying_index_url

Need to update the patch files as well.

@frostming Thanks for checking on this 💯   I just opened a PR against Pip -- any idea how that group will react?  I am willing to make this into a patch but it seems like it would be better if it gets accepted upstream.   If it does not gain traction and needs to be patched instead, we might want to do it once 22.0.4 vendoring branch is merged in since the patches changed a lot between now and then.

it would be better if it gets accepted upstream

It isn't likely to be accepted since it isn't useful for pip.

Thanks @frostming the patch file has been added.


More clarity with encodings of SplashRequest

Problem is middleware treat any body as utf-8 text, this is not always a case. Added detection of body encoding using standard scrapy mechanism.
By the way fixes:
We copy headers of base response and we can get something like this "Content-Type":"text/html;charset=cp1251" after processing by middleware for SplashResponse. It is wrong as body of SplashResponse is always a utf-8 text.
Added this for both cases - when we get "body" and "html" from lua script.

Close/open request to trigger travis build( they have network problems during last run)

Added detailed description for proposed changes

Thanks for detailed description, I think I'm getting it now. As far as I understand, this fix will simplify handling of scripts which return splash:http_get result, where body has original encoding which should match encoding declared in headers.
I'm a little worried if this could break someone's script... but so far I don't have a realistic case in mind. Original headers are changed, and encoding declaration is added even if there was no such declaration - I see that this could possibly break something, but I'm not sure.
Another question is why do we decode body into utf-8 in the first place, why can't we just keep it in binary and leave headers as is. @kmike do you know?

Added this for both cases - when we get "body" and "html" from lua script.

@whalebot-helmsman I don't see how this changes "html" handling - I don't think we should change it, but maybe I'm missing something?

For html case only headers are changed

Re _replace_charset, I wonder if it could be simplified with a simple re.sub, and maybe we don't need to add encoding declaration if there was no such declaration in the first place, but I'd like to get feedback from @kmike first.

Old behaviour:

Hey! I think the PR fixes a real issue: we shouldn't decode 'body' using utf-8, we should use Scrapy's encoding detection features instead.

why can't we just keep it in binary and leave headers as is

Do you mean that we can leave ._cached_ubody creation to standard Scrapy features (lazy-decode it in .text attribute), and just make sure headers and body are set properly for such detection? It makes sense to me. I don't understand why do we have to replace Content-Type header.

It'd be also good to have an integration test for it (use a script with splash:http_get), instead of low-level tests which check middleware behavior. These middleware tests are

hard to maintain,
unreadable: it is hard to understand if the behavior is correct, and
unreliable - they don't emulate all components, and don't check concrete use cases, which is important, as there is a lot of interactions between different components.

It is my fault we have a lot of them, integration tests were added only recently. Tests in this PR are not as bad as some of other existing tests, but I'd trust an integration test much more.

This PR is also a good chance to clarify "html" vs "body" in README: if html is returned, there is no encoding detection (meta declarations and Content-Type headers are ignored, as html is already unicode; response.body is always utf-8 - though I'm not sure it is always great), while with "body" we assume that meta tags and http headers match the content.

why can't we just keep it in binary and leave headers as is

Do you mean that we can leave ._cached_ubody creation to standard Scrapy features (lazy-decode it in .text attribute), and just make sure headers and body are set properly for such detection? It makes sense to me. I don't understand why do we have to replace Content-Type header.

Yes - if this is possible for scrapy-splash, it seems that this would allow to remove header replacement and calling encoding detection.

Yes - if this is possible for scrapy-splash, it seems that this would allow to remove header replacement and calling encoding detection.

Encoding for every SplashJsonResponse is set to utf-8 at same time


Should I exclude certain elements (esp. radioactive elements) from the data snapshot?

e.g.
    with MPRester(api_key) as mpr:
        results = mpr.summary.search(
            nsites=nsites, exclude_elements=exclude_elements, fields=fields, **search_kwargs
        )

Xie et al. said there were 89 unique elements in MP-20 dataset. Probably that certain elements were explicitly excluded.


Usage of redux connect and react-dnd

I'm having an issue where I have a component that needs to be aware of the app state tree using the connect function and it also needs to implement react-dnd. I'm noticing that both need to export default; however, can only be done once. Would there be a workaround so that a component can be connected to redux and have dragdropcontext, while not using decorator syntax?

Yes, you can do it like this:
class Card extends component {
  ...
}

Card = DropTarget(...)(Card);
export default class connect(mapStateToProps)(Card);

ah I will try that way as well. Would using flow also be another acceptable method as well?
import { DragDropContext } from 'react-dnd'
import HTML5Backend from 'react-dnd-html5-backend'
import flow from 'lodash/flow'

export default flow(
  connect(selector),
  DragDropContext(HTML5Backend)
)(ExperienceEditor);

                                                                                Yes, that would also work!                                                                                From: Joon HeoSent: Thursday, May 19, 2016 01:13To: gaearon/react-dndReply To: gaearon/react-dndCc: froatsnook; State changeSubject: Re: [gaearon/react-dnd] Usage of redux connect and react-dnd (#461)ah I will try that way as well. Would using flow also be another acceptable method as well?

import { DragDropContext } from 'react-dnd'
import HTML5Backend from 'react-dnd-html5-backend'
import flow from 'lodash/flow'
export default flow(
connect(selector),
DragDropContext(HTML5Backend)
)(ExperienceEditor);
—You are receiving this because you modified the open/close state.Reply to this email directly or view it on GitHub

It seems that it doesn't work for touch back end...
I tried
App = DragDropContext(TouchBackend({ enableMouseEvents: true }))(App);
export default connect(mapStateToProps, mapDispatchToProps)(App);
I am not sure if I should post this issue here. Thanks.

@longmfe how are you importing App?

@jnrepo Thanks for replay.
I just import it
import App from ../../somepath/App.js
should I add something when I using it?
BTW, I create App like this
`import {connect} from 'react-redux'
import {bindActionsCreators} from 'redux'
class App extends Component {
}
App = DragDropContext(TouchBackend({ enableMouseEvents: true }))(App);
export default connect(mapStateToProps, mapDispatchToProps)(App);`
Thanks a lot. Have a nice day.

I am having an issue wrapping my root component with the DragDropContext. In the console I get:
Invariant Violation: addComponentAsRefTo(...): Only a ReactOwner can have refs. You might be adding a ref to a component that was not created inside a component's render method, or you have multiple copies of React loaded (details: https://fb.me/react-refs-must-have-owner).
Any clues as to what might be causing this issue? I do not think I am including multiple copies of React. This was working perfectly before wrapping the root component with DragDropContext. Thanks!
I have root.js configured as:
`
import { Component } from 'react';
import { DragDropContext } from 'react-dnd';
import HTML5Backend from 'react-dnd-html5-backend';
class Root extends Component {
render() {
return
{React.cloneElement(this.props.children, this.props)}
;
}
}
export default DragDropContext(HTML5Backend)(Root);
`
And App.js as:
`
import { bindActionCreators } from 'redux';
import { connect } from 'react-redux';
import Root from './root';
function mapStateToProps(state) {
return {
...
}
}
function mapDispatchToProps(dispatch) {
return bindActionCreators({
...
}, dispatch)
}
const App = connect(mapStateToProps, mapDispatchToProps)(Root);
export default App;
`
The React console lays out the components in this way...


Add support for spell checking

This PR adds an webFrame.setSpellCheckProvider API to set a provider for spell checking in input fields and text areas.
Example:
require('web-frame').setSpellCheckProvider("en-US", true, {
  spellCheck: function(text) {
    return !(require('spellchecker').isMisspelled(text));
  }
});

Fixes #724.

Hi @zcbenz and @drikin
I don't manage to get this spellchecker working, even after reading the documentation about it and trying to understand what is a provider. Maybe one of you can explain with the simple example below. Also, I precise that am new to electron.
For the example I am simply using https://github.com/atom/electron/blob/master/docs/tutorial/quick-start.md with an input element in index.html file.
Thing is, I don't understand where to insert this code https://github.com/atom/electron/blob/master/docs/api/web-frame.md#webframesetspellcheckproviderlanguage-autocorrectword-provider
If I add it to main.js then when I try to run this electron app I will have : Error: Cannot find module 'web-frame'
But when I try to npm install it, it states that there is no such module.
Beside this, on the renderer, do I have to make a call of this spellCheck function and changed the result accordingly to the returned value ?
As you can see, I obviously lack of knowledge about electron and web application coding.
By any chance, someone could lead me to more documentation about what is a provider / how it is supposed to be used in such case please ?

Looking through the code I don't see any way to pass back alternate spellings like so to populate a context menu. Am I missing something, or has that not been enabled?

@aggregatejeff You have to do it yourself via the Context Menu API :(

Thanks @paulcbetts! At least a) I'll stop banging my head against a wall, and b) a work-around is possible.

@francoisMinette how did you solve the Error: Cannot find module 'web-frame'?

Hi, I did not solve it. I was learning about electron at the time, but I
had to change technology for some reason so I did not continue further.
Hope you will solve it.
Le 21 déc. 2015 10:05 AM, "Nathan Hazout"<EMAIL_ADDRESS>a
écrit :

@francoisMinette https://github.com/francoisMinette how did you solve
the Error: Cannot find module 'web-frame'?
—
Reply to this email directly or view it on GitHub
https://github.com/atom/electron/pull/942#issuecomment-166228460.

@paulcbetts I finally got around working on this, and have made some progress. I can get spellchecker to check a word, return suggestions, and populate the context menu with those suggestions. But I'm stumped on how to pass back to spellchecker the word that was clicked on, and then how to tell the webview what to replace.
The latter seems like it can be solved through .replace(text), but getting the word clicked upon doesn't seem very simple. Do you know if there's a way to do this through electron, or do I need to write some custom javascript?
I'm happy to share my results when it works, and any help would be greatly appreciated.

So... I build this. It took some digging, but here's what I found:

spellCheck: function(text) is called with context when an item is clicked on, so there's no need to look through the whole dom for the item
it's called a lot, basically whenever anyone does anything with text in rendered window

I combined the scripts for spellchecking and context menu building into one file for ease of use:
checker = require('spellchecker');
var remote = require('remote');
var webContents = remote.getCurrentWebContents();
var Menu = remote.require('menu');
var menu = new Menu();
// set the initial context menu so that a context menu exists even before spellcheck is called
var template = [
{
label: 'Select All',
selector: 'selectAll:'
}
];
menu = Menu.buildFromTemplate(template);
webFrame.setSpellCheckProvider("en-US", false, {
spellCheck: function(text) {
// if spellcheck is being called, we're dealing with text, so add text functions to the context menu template
template.unshift(
{
label: 'Undo',
selector: 'undo:'
},
{
label: 'Redo',
selector: 'redo:'
},
{
type: 'separator'
},
{
label: 'Cut',
selector: 'cut:'
},
{
label: 'Copy',
selector: 'copy:'
},
{
label: 'Paste',
selector: 'paste:'
}
);
switch (text) {
//prevent checker from showing contractions as errors
case 'ain':
case 'couldn':
case 'didn':
case 'doesn':
case 'hadn':
case 'hasn':
case 'mightn':
case 'mustn':
case 'needn':
case 'oughtn':
case 'shan':
case 'shouldn':
case 'wasn':
case 'weren':
case 'wouldn':
return checker.isMisspelled(text);
default:
if (checker.isMisspelled(text)) {
//if this is a misspelling, get suggestions
var options = checker.getCorrectionsForMisspelling(text);
// get the number of suggestions if any
var numSuggestions = options.length ? options.length : 0;
// restrict it to 3 suggestions
var maxItems = numSuggestions > 3 ? 3 : numSuggestions;
var lastSuggestion = null;
// if there are suggestions
if (maxItems > 0) {
for (var i = maxItems-1; i >= 0; i--) {
var item = options[i];
template.unshift({ label: item, click: function(menuItem, browserWindow)
{
webContents.replaceMisspelling(menuItem.label);
}
});
}
lastSuggestion = maxItems;
template.splice(lastSuggestion,0,{type: 'separator'});
} else {
// no suggestions found
template.unshift({ label: 'no suggestions', click: function() { } })
lastSuggestion = maxItems + 1;
template.splice(lastSuggestion,0,{type: 'separator'});
}
}
// build the new template for the context menu
menu = Menu.buildFromTemplate(template);
//reset the template object
template = [
{
label: 'Select All',
selector: 'selectAll:'
}
];
    return !checker.isMisspelled(text);
}

}
});
// on right click.....
window.addEventListener('contextmenu', function(e){
// use current menu, probably the one that was built the last time spellcheck ran
menu.popup(remote.getCurrentWindow());
// build a new one with only select all in it
menu = Menu.buildFromTemplate(template);
}, false);

@aggregatejeff So I've got the set-up that you've outlined here working, but I've noticed an issue and I was wondering if you (or someone else) had come up with a workaround.
When the spellcheck function runs, it builds out the menu. If you then right-click somewhere in the text area that is whitespace, it still shows the menu with the list of misspelled words, but selecting one won't trigger the replacement (since you did not click on top of the misspelled word). Conversely, if you right-click on a misspelled word twice, the replacement menu will be empty the second time. This all has to do with the mismatch between when the spell-checker runs and when the pop-up menu is shown. I'm not enough of a javascript expert to figure out how to reconcile those two states. Ideally it seems like you would want to query if there is currently a misspelled word under the mouse when creating the pop-up menu and build the context menu if there is.

For people brought here by google or elsewhere and looking for a simple solution to this, electron-editor-context-menu fixes the bugs pointed out by @crimsoncor and is based on the gist provided by @aggregatejeff . It's been working for me thus far.

I fixed this issue by figuring out how to get the currently highlighted word on a right-click event and then generating the spell-check menu directly in the eventListener function. Meant to come back and add a note on that and it just slipped my mind. But it has been working great.

And my apologies for not noticing the question, but as suggested, I continued to iterate and improved the above using getSelection(), and a few other tweaks.

Is there any plans to improve the context menu stuff? Would be nice if we didn't have to implement that ourselves.

It's very surprising this hasn't been implemented already. Any updates on native spell checking functionality without manually implementing context menu behavior?


Fix more typos

Fix typos on PUSHNOTIFICATIONS.md and BUILD.md

@shprink fixed the -- mistake. Hope everything else is ok

Thanks very much :)


Pack ingredients with variable counts drawn from a distribution

Use Case
While running multiple packings, we would like to add an option to vary the count of an ingredient based on a provided distribution.
E.g., for a sphere, the count can be drawn from a uniform distribution with a minimum of 5 and a maximum of 15.
Options can be specified in the composition for an object as follows:
"count_options": {
    "distribution": "uniform",
    "min": 5,
    "max": 15
}

We would like to have the option to use uniform, normal and specified discrete list to draw counts from.
Solution
Before packing, run a function update_count in environment that resets ingr.count and ingr.left_to_place based on values drawn from the specified options.

[ ] Create MetaEnum class for count_options
[ ] Add tests for count_options


Localize lang selectors according to the app language

There are two main things that are not yet translatable in Bluesky's UI:

Default feed names and descriptions (but this may be a can of worms to open, apart from the specific case of Following);
Language selectors, in the composer and in the settings screens.

As the second one is quite ironic (don't you think? 🎶) and quite visible on a daily basis, nagging at me as the main translator of Bluesky's app into French with @surfdude29, I thought it would be great to help you out and fix it myself, so you don't have to take time away from your heavy roadmap 😅

In this pull request, I use Intl.DisplayName to offer a best-effort translation of the language names, if the browser or target provides it.

:arrow_up: Here, notice the Français language name. It would show French on main.
Of course, I took the time to fix the same problem in the Languages screen:

:arrow_up: This screen always offered a translation for the app language, and I don't touch it to help anyone revert an unwanted change of app language settings.
Note: This is a best-effort fix: if Expo's runtime on the mobile apps do not support the Intl.DisplayNames, it will not do anything, and simply show English names as of today.

I tested Chinese, Japanese and Korean and they work perfect for me👍

I haven't tested it exhaustively, but I gave it a quick run in Firefox and it looks good. Because Hermes engine ,iOS and Android use, doesn't seem to support Intl.DisplayNames API, polyfilling @formatjs/intl-displaynames might be a option.

This is a great idea @Signez 👌

not gonna do right now but please remind me to look next week

Just rebased on main, pinging you this week @gaearon as you suggested ✨

Rebased on main, with a nasty bug (caught by @c960657) fixed.

Thanks! It was indeed what @tkusano spotted; they suggested that we could use @formatjs/intl-displaynames (and it would work), but it would be a waste to package it in every installation when there is native API that would allow us to use the ones already stored by the system: getDisplayLanguage(Locale locale) on a java.util.Locale on Android, and localizedString(forLanguageCode: string) on Fondation's Locale on iOS.
I thought it would be a good follow-up PR in the future, maybe contributing an Expo package (or an improvement to expo-localization) to offer this to other projects too!


Remove Progress Window to Fix 2024 Not Loading

[X] This contribution adheres to CONTRIBUTING.md.

What does this Pull Request accomplish?
In VS 2024 the DSF custom device fails to load the system explorer pages.  Removing the Progress Window VI and its uses causes the system explorer page to load.
Why should this Pull Request be merged?
Changes to LV 2024 broke the progress window and since it is not an essential piece of the custom device we can remove it.
What testing has been done?
Validation manually:

Please update the README.md to say the source is now LabVIEW 2021 as part of this change and create an issue to mass compile to 2021 in the near future.

Updated in commit 809a5f34b6


BDC with AD mode wizard  hasn't implemented the newly introduced  activeDirectory Node under security config.

ADS hasn’t implemented AD the new security config node activeDirectory,
Control.json generated by AD and see activeDirectory  node is empty and the variables were added under security node directly similar to CU1
"security": {
    "activeDirectory": {
        "ouDistinguishedName": "",
        "dnsIpAddresses": [],
        "domainControllerFullyQualifiedDns": [],
        "domainDnsName": "",
        "clusterAdmins": [],
        "clusterUsers": []
    },
    "ouDistinguishedName": "OU=bdc, DC=contoso, DC=com",
    "dnsIpAddresses": [
        "<IP_ADDRESS>"
    ],
    "domainControllerFullyQualifiedDns": [
        "DC1.CONTOSO.COM"
    ],
    "domainDnsName": "contoso.com",
    "realm": "CONTOSO.COM",
    "clusterAdmins": [
        "bdcadmins"
    ],
    "clusterUsers": [
        "bdcusers"
    ]
}

This deployment is failing with this error
Creating SQL Server 2019 Big Data Cluster: mssql-cluster using configuration ads-bdc-custom-profile
If you don't see output produced by azdata, you can run the following command in a terminal window to check the deployment status:
C:\Users<user>\AppData\Local\Programs\Python\Python37\kubectl.exe get pods -n mssql-cluster
Executing: azdata bdc create -c ads-bdc-custom-profile
The privacy statement can be viewed at:
https://go.microsoft.com/fwlink/?LinkId=853010
The license terms for SQL Server Big Data Cluster can be viewed at:
Enterprise: https://go.microsoft.com/fwlink/?linkid=2104292
Standard: https://go.microsoft.com/fwlink/?linkid=2104294
Developer: https://go.microsoft.com/fwlink/?linkid=2104079
Cluster deployment documentation can be viewed at:
https://aka.ms/bdc-deploy
ERROR: Failed to set security configuration. Please check the deployment documentation https://aka.ms/bdc-deploy . Security configuration parameter 'clusterAdmins' must contain a single domain group. Values specified:
An exception has occurred, use %tb to see the full traceback.
SystemExit: Command execution failed with exit code: 1.
azdata bdc create -c ads-bdc-custom-profile
c:\users<user>\azuredatastudio-python\0.0.1\lib\site-packages\IPython\core\interactiveshell.py:3334: UserWarning: To exit: use 'exit', 'quit', or Ctrl-D.
warn("To exit: use 'exit', 'quit', or Ctrl-D.", stacklevel=1)
ADS version
Version: 1.16.0-insider (user setup)
Commit: 506c6a5e5f8423d3249670f55b1466b1980a5f03
Date: 2020-02-17T05:43:18.399Z
VS Code: 1.42.0
Electron: 7.1.11
Chrome: 78.0.3904.130
Node.js: 12.8.1
V8: 7.8.279.23-electron.0
OS: Windows_NT x64 10.0.18363

@rl-msft Thanks for reporting the issue, I have fixed it and please try the latest insider build.


[helm] Tokens ERC1155 Deployment

TODOs

[ ] https://github.com/hyperledger/firefly-tokens-erc1155/pull/50 merged
[x] https://github.com/hyperledger/firefly/pull/359 merged
[ ] docs
[ ] testing

Codecov Report

Merging #372 (5aaec2b) into main (4f43903) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##              main      #372   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files          239       239
  Lines        12886     12886
=========================================
  Hits         12886     12886

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4f43903...5aaec2b. Read the comment docs.

Closing in favor of https://github.com/hyperledger/firefly-helm-charts/pull/4


42!

Sudo for Windows version
1.0.0
Windows build number
1.0.0
Other Software
Windows 11
Steps to reproduce
I would like to camp nice round number issues like this one, for future use.
Expected Behavior
I would like to camp nice round number issues like this one, for future use.
Actual Behavior
I would like to camp nice round number issues like this one, for future use.

****@DHowett @ ****


Show source files tree

Brief Issue Summary

When CMakeLists.txt uses source files outside workspace (from let's say library repository somewhere on disk), it would be good to automatically show files in browser in VSCode.
Similar well-done job is integration of this plugin with Cpp-Tools where include paths and symbols are well provided directly from CMake.

Debug Log

<!-- Paste the debug log contents HERE -->

Are you asking to show files in the File Explorer?  Unfortunately, we are unable to do that.  But if you open the CMake Project Outline, you should be able to see all files references by your targets.  Click on this icon in the sidebar:

How cool, that's exactly I have been looking for! Thank you for your fast help
Cheers
Tilen


Fix a bug with inlining self-conformances

@swift-ci Please smoke test.

Thanks!

@rjmccall I think this needs a test case though.

It's in #20629.  There are no self-conformances that don't satisfy this isObjCExistentialType() without that.


Add zero-prefixed version test in L0_lifecycle

@jobegrabber I modified the code to log and ignore version directories that has zero-prefixed, so that the server will try to load the model as long as there is at least one well-formed version directory.


TimeDistributed() and integration with a tf.data.Dataset

Note, potentially related to and/or duplicate of: https://github.com/keras-team/keras/issues/18941
In the above ticket, the original author was receiving an error along the lines of:
Epoch 1/3
Traceback (most recent call last):
  File "/home/dryglicki/code/science_projects/projects/ONR/src/layers/tests/test_simple_lstm.py", line 269, in <module>
    main()
  File "/home/dryglicki/code/science_projects/projects/ONR/src/layers/tests/test_simple_lstm.py", line 264, in main
    model.fit(ds, epochs = 3)
  File "/ssd0/miniforge3_2024-04/envs/tensorflow_2d16/lib/python3.11/site-packages/keras/src/utils/traceback_utils.py", line 122, in error_handler
    raise e.with_traceback(filtered_tb) from None
  File "/ssd0/miniforge3_2024-04/envs/tensorflow_2d16/lib/python3.11/site-packages/keras/src/backend/common/variables.py", line 521, in standardize_dtype
    raise ValueError(f"Invalid dtype: {dtype}")
ValueError: Exception encountered when calling TimeDistributed.call().

Invalid dtype: NoneType

Arguments received by TimeDistributed.call():
  • inputs=tf.Tensor(shape=(4, None, None, None, None), dtype=float32)
  • training=True
  • mask=None

The solution at the time was to use run_eagerly=True. I believe I have found an extension of this bug. This bug still exists for me if I try to ingest from the Tensorflow Dataset API. The examples provided will build a TFRecords dataset but I can confirm that this bug also exists for a separate dataset pathway using a NetCDF file reader wrapped in tf.py_function logic. Relevant version information:
Tensorflow version: 2.16.1
Keras version: 3.3.3
Gist to create dummy TFRecords files
Gist for running/training model
To recap, to reproduce the NoneType issue:

Build a model that contains a TimeDistributed construct (wrapped layer is irrelevant)
Build a dataset using the Tensorflow dataset API
Call model.compile(run_eagerly=False)
Call model.fit()

I am unsure if I need to call dataset.set_shape() on the tensors (based on https://www.tensorflow.org/guide/data#applying_arbitrary_python_logic), or if I'm doing something else wrong. In the NetCDF pipeline, which is far more complicated than this, I do manually issue set_shape() commands on the dataset, and I still receive a similar error.

Hi @dryglicki -
Thanks for reporting the issue. I have tested code Gist to create dummy TFRecords files
Gist for running/training model and reproduces the reported behaviour.
We will look into the issue and update you the same.

This is now fixed, thanks for the report.


startTrackEvent is not stubbed/queued

Moved from: https://github.com/Microsoft/ApplicationInsights-aspnetcore/issues/252 (reported by @dfederm)

It looks like in the JavaScriptSnippet, these events are stubbed out with an implementation that basically queues up the invocation until the real appInsights impl is on the page:
["Event","Exception","Metric","PageView","Trace","Ajax"]

However, this does not encompass all functions on the appInsights object. For example startTrackEvent.

This can cause lost instrumentation, as well as JS errors when the AI js fails to load (or is blocked by an adblocker in my case).

Here is an example of the JS error as well as an example of the "trackEvent" function being stubbed out which avoids the JS error (although still loses the instrumentation due to the adblocker):

FYI, I was able to mitigate this by adding this just under the @Html.ApplicationInsightsJavaScript(TelemetryConfiguration) call:
    <script>
        (function(t){function r(f){if(!t[f])t[f]=function(){var i=arguments;t.queue.push(function(){t[f].apply(t,i)})}};r("startTrackEvent");r("stopTrackEvent")})(appInsights)
    </script>


2019-11-13 image on buster error

I am using the latest image from 2019-11-13 Raspberry Buster on both a Raspi 4 and 3b+. No matter what i do i cannot get past authentication.

i tried using my previous working assistant.json file installed in /home/pi which worked with Stretch on a 3b+. I also tried creating a new project with new oath creds and new auth screen. On any of these i get the following when i run a demo: for example  ./assistant_library_demo.py
or python3 assistant_library_demo.py

Traceback (most recent call last):
File "./assistant_library_demo.py", line 71, in
main()
File "./assistant_library_demo.py", line 64, in main
credentials = auth_helpers.get_assistant_credentials()
File "/home/pi/AIY-projects-python/src/aiy/assistant/auth_helpers.py", line 151, in get_assistant_credentials
return _try_to_get_credentials(credentials_file)
File "/home/pi/AIY-projects-python/src/aiy/assistant/auth_helpers.py", line 123, in _try_to_get_credentials
credentials = _credentials_flow_interactive(client_secrets)
File "/home/pi/AIY-projects-python/src/aiy/assistant/auth_helpers.py", line 75, in _credentials_flow_interactive
webbrowser.register('chromium-browser', None, webbrowser.Chrome('chromium-browser'), -1)

i forgot to add these lines:
File "/home/pi/AIY-projects-python/src/aiy/assistant/auth_helpers.py", line 75, in _credentials_flow_interactive
webbrowser.register('chromium-browser', None, webbrowser.Chrome('chromium-browser'), -1)
TypeError: register() takes from 2 to 3 positional arguments but 4 were given

You have to edit the auth_helpers.py file at line 75 as below:
webbrowser.register('chromium-browser', None, webbrowser.Chrome('chromium-browser'))

i did that, ran ./assistant_library_demo.py  , then got the auth screen,
and it completed authorization:  Then it exited and and left output:
Segmentation fault.
here is the outpu:
./assistant_library_demo.py
Please visit this URL to authorize this application:
https://accounts.google.com/o/oauth2/auth?response_type=code&client_id=23695939617-49irrcmkf3d8vms7i1n2si1u4g8ne3vs.apps.googleusercontent.com&redirect_uri=http%3A%2F%2Flocalhost%3A8080%2F&scope=https%3A%2F%2Fwww.googleapis.com%2Fauth%2Fassistant-sdk-prototype&state=LfjzwuQuw7vvFRlsv9RU8Dfve3480k&access_type=offline
INFO:google_auth_oauthlib.flow:"GET
/?state=LfjzwuQuw7vvFRlsv9RU8Dfve3480k&code=4/twGkL37URqEY3XwdNzYVuKSqgMS0XRgMAi6dGa1G_XtIdm0JQ6TUxk0sAJQ1VpPs7RCtj4NzuqiVrmLDuDGOwG4&scope=
https://www.googleapis.com/auth/assistant-sdk-prototype HTTP/1.1" 200 65
INFO:root:OAuth credentials initialized:
/home/pi/.cache/voice-recognizer/assistant_credentials.json
Segmentation fault
On Sat, Nov 30, 2019 at 6:38 AM Alessandro Baldassari <
<EMAIL_ADDRESS>wrote:

You have to edit the auth_helpers.py file at line 75 as below:
webbrowser.register('chromium-browser', None,
webbrowser.Chrome('chromium-browser'))
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/google/aiyprojects-raspbian/issues/654?email_source=notifications&email_token=AJLICWLUAXXSGVXY52UWGRTQWJGD5A5CNFSM4JTD3HQKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEFQDLIY#issuecomment-559953315,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AJLICWNOQWXOHIXJMRGNZXTQWJGD5ANCNFSM4JTD3HQA
.

Any idea on why segmentation fault?
INFO:root:OAuth credentials initialized:
/home/pi/.cache/voice-recognizer/assistant_credentials.json
Segmentation fault

I have the sane issue
Cordiali saluti,
Alessandro Baldassari
+39<PHONE_NUMBER>
<EMAIL_ADDRESS>
From: rickmini<EMAIL_ADDRESS>Sent: Wednesday, December 4, 2019 3:14:45 PM
To: google/aiyprojects-raspbian<EMAIL_ADDRESS>Cc: Alessandro Baldassari<EMAIL_ADDRESS>Comment<EMAIL_ADDRESS>Subject: Re: [google/aiyprojects-raspbian] 2019-11-13 image on buster error (#654)
Any idea on why segmentation fault?
INFO:root:OAuth credentials initialized:
/home/pi/.cache/voice-recognizer/assistant_credentials.json
Segmentation fault
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHubhttps://github.com/google/aiyprojects-raspbian/issues/654?email_source=notifications&email_token=ADTMZKTIXSXC665ISLHFLUDQW63NLA5CNFSM4JTD3HQKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEF5E5KI#issuecomment-561663657, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ADTMZKUTSSMWKC3UL6OVR6DQW63NLANCNFSM4JTD3HQA.

Alessandro
I had assumed you were a google tech helping me. But i guess that you and I are just suffering the same frustration.
Does google ever respond to issues with their code?

@rickmini Assistant library SDK has been deprecated and assistant_library_demo is broken at backend now. assistant_grpc_demo is running fine though.

Check out my writeup on how to get it working and update stretch. https://medium.com/@michaeldbrewer/aiy-voice-deprecation-workaround-bd07559403df

pip3 install google-assistant-library==1.0.0
use that to update the Library

This seems to be a duplicate of #660, please comment there.


Context contract composition error.

Nested collision detector doesn't support identity checks for neighbor substories.  Only parent-child for now.
class Subs
  @story
  def foo(I):

  @story
  def bar(I):

  @contract_in(Subs)
  class Context:
    bar: int

class Parent:
  @story
  def quiz(I):
    I.foo
    I.bar   <--- `bar` will be treated as repeated variable.

We removed ability to use same contract for neighbor stories, and neighbor stories were removed from documentation as a consept.

We removed ability to use same contract for neighbor stories, and neighbor stories were removed from documentation as a consept.


SSO?

Does this work with SSO sources?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 29bfbd4c-5149-93be-3982-81af6852a5dd
Version Independent ID: 75460ed0-c7d9-fe67-8010-b843661dc66e
Content: Connect to an OData feed in Power BI Desktop - Power BI
Content Source: powerbi-docs/desktop-connect-odata.md
Service: powerbi
GitHub Login: @davidiseminger
Microsoft Alias: davidi

Thanks for posting – note that we can only answer feedback related to the documentation, and can’t provide direct support or respond feature requests.
Your best venue for getting an answer or feedback on your question is from the community (https://community.powerbi.com) or from support at https://support.powerbi.com. You can also provide feedback using the Give Product Feedback button at the bottom of the article page.


Fix TypeError

Fixes #2

Note: Not actually tested, just done in GitHub editor.

Closing this in favour of #5


You must start with a clean working directory –– but as far as I know it is clean?

I've installed ember update ^0.6.1 as an addon, committed updates to my yarn.lock and package.json files, but now ember update is returning
You must start with a clean working directory

when I run git status I'm seeing:
On branch master nothing to commit
working directory clean

Hmm. That's a mystery to me. Maybe @rwjblue has an idea. Maybe we want to add an option that opts out of dirty checking while we iron out the kinks of this tool. That way you can still update even though there may be a bug somewhere.

@kellyselden Wondering if this may be somewhat unrelated to ember-cli-update –– I have a Yarn/node/sass issue that I have not yet sorted out where I need to run
npm rebuild node-sass

regularly when installing addons – it doesn't affect git status but perhaps it could be affecting ember-cli-update

I've this same problem. Cannot update with ember update.

Looks like Git 2.9.1 changed working directory to working tree, so the isGitClean regex is not working for Git < 2.9.1  –– I see that  @rwjblue has already proposed a change to git-diff-apply that looks like it would this.

OK I'll get that merged in. Thanks for the help.

Released in v0.6.3

Having this very same issue in 0.6.4 (Git 2.14.1 / Node 8.4.0) trying to migrate Ember 2.14 to 2.15

@alexandremjacques mind filing a new issue, you might have discovered a new case because the old trigger should have been fixed.


Sypder 3.0.0 crashes on OS X 10.11.6 after browsing with firefox

Description of your problem
Spyder 3. crashes often after browsing on websites with firefox. The programm is frozen and Mac shows the rainbow ball. A hard close of spyder solves the problem (using closing immedaitly in the dock or killing the process in the taskmanager) and afterwards restarting.
What steps will reproduce the problem?

Coding / Running stuff in spyder
Browsing with firefox
Spyder is frozen sometimes

What is the expected output? What do you see instead?
May it is related to more complex websites, but I can't figure out that. The problem does not occur every time using firefox only sometimes (may about every third time switching back from firefox to spyder).
Expected: No problems when switching between the two programs
Instead: get frozen spyder app
Please provide any additional information below
Versions and main components

Spyder Version: Spyder 3.0.0.dev0
Python Version: Python 3.5.1 64bit
Operating system: OS X 10.11.6
Qt 5.6.0, PyQt5 5.6 on Darwin
Firefox 48.0.2

Dependencies
jedi >=0.8.1    :  0.9.0 (OK)
matplotlib >=1.0:  1.5.1 (OK)
nbconvert >=4.0 :  4.2.0 (OK)
numpy >=1.7     :  1.10.4 (OK)
pandas >=0.13.1 :  0.17.1 (OK)
pep8 >=0.6      :  1.7.0 (OK)
psutil >=0.3    :  4.2.0 (OK)
pyflakes >=0.6.0:  1.2.3 (OK)
pygments >=1.6  :  2.1.3 (OK)
pylint >=0.25   :  1.5.6 (OK)
qtconsole >=4.0 :  4.2.1 (OK)
rope >=0.9.4    :  0.9.4-1 (OK)
sphinx >=0.6.6  :  1.4.1 (OK)
sympy >=0.7.3   :  <IP_ADDRESS> (OK)

Very odd bug. I doubt we can address it in any way, sorry.


Test out GH Action to setup a fake SLURM cluster [MT-34]

Codecov Report
Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (987a516) 55.74% compared to head (1d3b8ab) 55.23%.
Report is 1 commits behind head on master.

Files
Patch %
Lines

milatools/cli/remote.py
92.30%
1 Missing :warning:

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #84      +/-   ##
==========================================
- Coverage   55.74%   55.23%   -0.51%
==========================================
  Files           9        9
  Lines        1202     1204       +2
==========================================
- Hits          670      665       -5
- Misses        532      539       +7

Flag
Coverage Δ

unittests
55.23% <92.30%> (-0.51%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Upload package to npm so contract can be imported from other projects

Summary
Publish the package to npm so Smart Contracts can be imported from Solidity without having to clone the repo.
Acceptance Criteria

[x] Create package on npm
[ ] Set-up CI/CD pipeline to publish to npm

Reference

OpenZeppelin doc

NPM https://www.npmjs.com/package/permissioning-smart-contracts

published to https://www.npmjs.com/package/@consensys-software/permissioning-smart-contracts
and can be imported like so:
import<EMAIL_ADDRESS>import<EMAIL_ADDRESS>

contract Alice is Ingress {

How to publish:
https://www.npmjs.com/package/@consensys-software/permissioning-smart-contracts
Prerequisites

You need an npmjs account
You need to be a collaborator ie member of consensys-software org

Note this project uses yarn not npm but it works much the same:
yarn login
yarn publish --access public


Add recommended sgminer/ccminer build links

Please, could you add recommended sgminer/ccminer build links, or even better, make possible to auto download them if missing?

Sounds good, where would you suggest putting the links? In the readme? When you launch the app for the first time?

Probably both:

in README as a requirement in Instructions
in the app a button for downloading the latest version from Github

Info added to readme and link to readme added below the title in the app,
Thanks for the suggestion


fix_schematics

Fixes https://github.com/google/gf180mcu-pdk/issues/17
Fixes https://github.com/google/gf180mcu-pdk/issues/20

Fixed broken schematics

Reformatted them as svg instead of png

[x] Built locally with no warnings.

[x] Checked empty images if they 0 bytes.

The title of this pull request needs to be improved.


Tracking: Support using Tencent COS as the underlying object store

Integrating with Tencent COS is useful for some of our use cases. Since Tencent COS can already support S3 protocol, we should be able to support it.

[ ] Support communicate with COS in s3 object store and test with actual deployment
[ ] Understand the performance limitation of COS and conduct micro-benchmark
[ ] Conduct e2e testing

Reference:
https://www.tencentcloud.com/document/product/436/32537
https://github.com/datafuselabs/opendal

Looks like aliyun OSS is also compatible with S3 interface. Should we add support for that as well?


Add test case for unsound map reassignment handling

It might be useful to have a suite of test cases showing where NullAway is unsound, for documentation purposes.  Here I just add one for re-assigning a Map variable, but we could easily add more in the future.

Pull Request Test Coverage Report for Build #676

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 89.672%

Totals

Change from base Build #674:
0.0%

Covered Lines:
4107

Relevant Lines:
4580

💛  - Coveralls

Makes sense. We could handle this by invalidating APs when assignments happen to their subpaths, could we not? But I think that's less the point of this PR than just documenting an example of the kinds of things we don't check for.

Yes, the point was for documentation.  It came up because when writing https://github.com/uber/NullAway/issues/535#issuecomment-1006811236 I couldn't remember if we handled this case or not.
We could relatively easily invalidate APs when a root local variable is re-assigned (though I don't know what the performance cost would be).  Invalidating longer access paths could be done heuristically, but gets very hard to do soundly in the presence of aliasing and procedure calls.  Personally, I don't think we really want to go down this path until we have evidence that we are missing real bugs due to this unsoundness.


wip(fastsim): fast sim fails when using InstrumentContext.pair_with function

Overview
The paired pipette feature was completely neglected by the fast simulation refactor. This PR aims to remedy that by having PairedInstrumentContext initialized with an AbstractPairedInstrument. For normal cases, we will use PairedInstrument just like now. But for fast simulation, we will use an AbstractPairedInstrument that does not communicate with the hardware controller at all.
closes #8222
Changelog

Create AbstractPairedInstrument
Have PairedInstrument inherit from AbstractPairedInstrument
Create AbstractInstrument.pair_with in order to specialize in InstrumentContextSimulation.
AbstractPairedInstrument is supplied to PairedInstrumentContext's constructor.

Review requests
Risk assessment
High in that it impacts a documented feature of our protocol api, but it's a very rarely used feature.

Can you provide a summary of what changes you made and why you made them?
I took a look at the code and I see a ton of changes but I am not sure what part/s fixed the issue.

Can you provide a summary of what changes you made and why you made them?
I took a look at the code and I see a ton of changes but I am not sure what part/s fixed the issue.

It's still in draft and labeled WIP. Not ready to be looked at.

Can you provide a summary of what changes you made and why you made them?
I took a look at the code and I see a ton of changes but I am not sure what part/s fixed the issue.

It's still in draft and labeled WIP. Not ready to be looked at.

Oh. Duh. Ignore me


Porting Deployment Status update failure fix to M98

Porting Deployment Status update failure fix to M98

@anaggar can you review this once?
The changes look fine from my end.

looks fine


[Backport into 5.15] Namespace store stuck in rejected state

Explain the changes

[Backport into 5.15] Namespace store stuck in rejected state

Issues: Fixed #xxx / Gap #xxx

https://issues.redhat.com/browse/DFBUGS-859

closed in favor of https://github.com/noobaa/noobaa-core/pull/8587


[New] List contents of KML file

Description
This PR implements List contents of KML file in Edit and Manage Data category.
URL to README: List contents of KML file
Linked Issue(s)

swift/issues/6193

How To Test

Tap on a disclosure to reveal a node's children. Tap on a node to open it in a scene zoomed to that node.

Screenshots

Removed Mark since he is out Monday.

@zkline101 Could you take look at this before Destiny leaves on vacation please? Thank you

Whoops missed this. I'll review now.

Thank you both!


Can I use your OpenSync?

I'd like to clone your project and add my own front. Can I do it?

Yes of course 😄
https://github.com/brasky/OpenSync/blob/master/LICENSE


[CLI] wandb.cli.cli.sweep name parameters requires a boolean

Description
The default option for --name seems to be False, this cause the type of the name argument for the sweep cli command --name to be boolean. It appears that this might refuse any other non boolean type for the --name argument, for example a string.
https://github.com/wandb/client/blob/5a65037a435cbc8a885ab78fe5f23b8d7e10f5d2/wandb/cli/cli.py#L639
Wandb features
wandb sweep
How to reproduce
wandb sweep --name 'hello' sweep.yml
Usage: wandb sweep [OPTIONS] CONFIG_YAML_OR_SWEEP_ID
Try 'wandb sweep --help' for help.

Error: Invalid value for '--name': 'hello' is not a valid boolean.

Environment

python 3.8.6
wandb 0.10.32
ubuntu

Hey @d3sm0 , I just tried the line below (with wandb 0.10.32), and it worked just fine:
wandb sweep --name "sweep_name" config.yaml
Can you try changing the single quotes around your sweep name to double quotes? Maybe that's causing the issue?

I have exactly the same issue. Changing the default=False to default=None solved it. I was running wandb 0.10.32, python 3.9, manjaro linux.

@RobertCsordas  you're right! Mine was click==7.1.2, and after upgrading to 8.0.1 I got the same error.
I'm sharing this with the team, so we can get a fix for this.

This is fixed in 0.10.33

From: Artyom Hakobyan @.>
Sent: Thursday, July 1, 2021 9:11:40 AM
To: wandb/client @.>
Cc: Subscribed @.***>
Subject: Re: [wandb/client] [CLI] wandb.cli.cli.sweep name parameters requires a boolean (#2296)
@RobertCsordashttps://github.com/RobertCsordas you're right! Mine was click==7.1.2, and after upgrading to 8.0.1 I got the same error.
I'm sharing this with the team, so we can get a fix for this.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHubhttps://github.com/wandb/client/issues/2296#issuecomment-872373954, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AAVEFYEA6MYUUUPLJODMIADTVSHTZANCNFSM46X6LL2A.

Fix here: https://github.com/wandb/client/pull/2328


New package: HermannSchinagl.LinkShellExtension version <IP_ADDRESS>

[x] Have you signed the Contributor License Agreement?
[x] Have you checked that there aren't other open pull requests for the same manifest update/change?

[x] Does your manifest conform to the 1.1 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.

Author's note: SilentWithProgress is not available according to the arguments described here.
Microsoft Reviewers: Open in CodeFlow

Can't find a way to add PackageDependencies; only MinimumVersion
Closing.

Read that a manifest must support SilentWithProgress - closing again.

Reopening with the required switches specified - although progress is NOT shown as described in the beginning.
If that won't fly, well, close it - however, consider if having progress available as a mode should continue to be absolutely mandatory, and by all means educate me if I'm missing a very important reason for this.

Close with reason: Duplicate of https://github.com/microsoft/winget-pkgs/pull/49982;
Dependency support will likely be coming to the Validation Pipeline somewhere in 2023 (?).

Apologies for missing the duplicate.


QUIC: Assign thread before call QUICNetVConnection::start

[approve ci ubuntu]

@masaori335 clang-format doesn't like your code too :)

@maskit oops, fixed

[approve ci ubuntu clang-format]

[approve ci ubuntu]

[approve ci clang-format]

@masaori335 UnixNetProcessor may not use it, but who is responsible for setting `vc->thread' ? Setting it in different places doesn't make sense. Is there a reason we should not do the same thing?


Try running in Heroku without a Gemfile.lock

Temporary PR to try out Heroku running without Gemfile.lock - as we're expecting challenges

This didn't work.


⚠ Bofrost.com has degraded performance

In 4c4b5f4, Bofrost.com (https://www.bofrost.com) experienced degraded performance:

HTTP code: 200
Response time: 867 ms

Resolved: Bofrost.com performance has improved in 25f7e4c after 6 minutes.


Upgraded ruby to 3.3.0.

Merge Checklist

All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)

[X] The toolchain has been rebuilt successfully (or no changes were made to it)
[X] The toolchain/worker package manifests are up-to-date
[X] Any updated packages successfully build (or no packages were changed)
[X] Packages depending on static components modified in this PR (Golang, *-static subpackages, etc.) have had their Release tag incremented.
[X] Package tests (%check section) have been verified with RUN_CHECK=y for existing SPEC files, or added to new SPEC files
[X] All package sources are available
[X] cgmanifest files are up-to-date and sorted (./cgmanifest.json, ./toolkit/scripts/toolchain/cgmanifest.json, .github/workflows/cgmanifest.json)
[X] LICENSE-MAP files are up-to-date (./SPECS/LICENSES-AND-NOTICES/data/licenses.json, ./SPECS/LICENSES-AND-NOTICES/LICENSES-MAP.md, ./SPECS/LICENSES-AND-NOTICES/LICENSE-EXCEPTIONS.PHOTON)
[X] All source files have up-to-date hashes in the *.signatures.json files
[X] sudo make go-tidy-all and sudo make go-test-coverage pass
[X] Documentation has been updated to match any changes to the build system
[X] Ready to merge

Summary

Upgraded ruby to 3.3.0. Also switching back to using the bigdecimal gem from the default gems in ruby instead of using a separate spec as we now have the ability to do so. In 2.0 we had a separate spec for bigdecimal with a version higher than what the default gem offered, so we had to keep maintaining it. With this update, this is no longer necessary. Thanks, @neha170 for pointing this out!
The racc gem has been removed from the default Ruby packages but still exists as a standalone. It is a a LALR(1) parser generator, which is a feature unlikely used by Azure Linux users, so I decided to not pro-actively re-add it as a separate package and take the responsibility of adding it in future in case I was wrong.
Change Log

Bumped ruby to version 3.3.0.
Removed the standalone rubygem-bigdecimal package.

Does this affect the toolchain?

No.
Test Methodology

Local build with tests.
Buddy build.

Looks good to me. Just fyi, we are removing rubygem-racc and rubygem-readline-ext as they are no longer being provided as 'default' gems with the updated ruby v3.3.0. If there is anyone using these gems already, this change might break their setup.

You're right, @neha170. The rubygem-readline-ext gem was deprecated, so it's just not there in the new versions of Ruby.
When it comes to racc, it is a a LALR(1) parser generator, which is a feature unlikely used by Azure Linux users, so I decided to not pro-actively re-add it as a separate package and take the responsibility of adding it in future in case I was wrong. I should have, however, mentioned that in the summary (now updated).


Todo-mvp-dagger and constructor injection

I am trying to understand Dagger 2, I have researched it in several articles and examples on Gibhub, but still don't understand why there are constructor injections in the presenters. For example, in order to make a field injection in the TaskActivity we make:
DaggerTasksComponent.builder()
                .tasksRepositoryComponent(((ToDoApplication) getApplication()).getTasksRepositoryComponent())
                .tasksPresenterModule(new TasksPresenterModule(tasksFragment)).build()
                .inject(this);

and with that, we inject:
 @Inject TasksPresenter mTasksPresenter;
I thought these lines of code were enough to create a TaskPresenter object. But when I go to TaskPresenter I see the following lines.
 @Inject
    TasksPresenter(TasksRepository tasksRepository, TasksContract.View tasksView) {
        mTasksRepository = tasksRepository;
        mTasksView = tasksView;
    }

This is what I don't understand. According to this example(https://github.com/CasterIO/simplemvp) there is no such constructor injection in the Presenter.
Thanks in advance.

We can provide dependencies in two ways :
By Using Provides annotation in module
@Provides
    TasksPresenter provide TasksPresenter(TasksRepository tasksRepository, TasksContract.View tasksView) {
        return new TasksPresenter(tasksRepository,tasksView);
}

By Using Consrtuctor Injection
 @Inject
    TasksPresenter(TasksRepository tasksRepository, TasksContract.View tasksView) {
        mTasksRepository = tasksRepository;
        mTasksView = tasksView;
    }

One thing to observe here is Consrtuctor Injection solve two thing

Instanite object
Provides the object by adding it in Object graph.

So in https://github.com/CasterIO/simplemvp example they might be using first approach.

Thanks for the answer!

@cahegi we can use constructor Injection  when the class is defined by our self  like in this case TasksPresenter


flow page: add user exit

as separate user exit, because

dont want to couple the backend user exit to UI
expecting this exit to be unstable for a while

allows adding more actions to the toolbar

wondering if we should make these more generic for any UI (zif_abapgit_ui_exit) and move the existing enhance_repo_toolbar, on_event, and wall... over to that one.

yea, tho not sure how

merge?


[BAD-290] Error appears if variables is used in both named cluster and

Hadoop Copy Files step.

@kcruzada Please Sir!


List for Publications whose file versions are all determined but the wrong version

We'll want to keep these in their own list separate from #688.  At this point in the workflow there's the chance the author will need to re-upload a file with the proper version.  We haven't entirely figured out how this will happen and what automation we can do with it (#692), but we do know that we want the admins to have a list to view these publications and their files.  The list should probably include the publication's title, its preferred version, the file locations (with a link to view the file or edit the file record), and the version of each file.  We'll also want a link to edit the publication in case an admin wants to view other metadata for the publication or change some metadata.

Take a look here for more details on how we want to implement this list: https://github.com/psu-libraries/researcher-metadata/issues/692#issuecomment-1679413809

@ajkiessl I am getting error messages right now if I click the "Send email" button for this list on QA. "Send batch email" does not give an error.

@anaelizabethenriquez This will be fixed in #841


Feature/issue 150 subpackage scanning

Coverage decreased (-0.3%) to 93.77% when pulling 5c0765106dbd5f7832659d119c20f6c3c274c81f on feature/issue-150-subpackage-scanning into 83fa9c7a220d2f10b2e2145468aae91e79434995 on develop.

finished #151