Less buggier in description should be "less buggy"

Small nit, just thought I would make you aware 😸

Whoops, thanks for pointing out! I didn't realize that "buggier" was not sounding correct in that sentence.

No worries! 👍


build / test setup

to work on this module involves reading through the Makefile and trying to work out which tasks you need to run in which order.
consider moving the npm dependencies into the 'devDependencies' field? or make some tasks dependencies of others, so running 'make test' or 'make build' works.
basically i don't really know how to run the tests. after running make dependencies, make build exits with errors and make test outputs nothing to the console.

hope it's OK if I close it since the described work around works fine here. Will put a reference to the README soon though.


Color space "fake" conversion

Describe the bug
rgb_to_hed and rgb_to_hsv convert the color in an RGB image correctly, however the color space (mode) is not converted but remains RGB because it is the default mode of np_to_pil.
To Reproduce
Steps to reproduce the behavior:

from histolab.filters.image_filters import RgbToHed
from PIL import Image
image = Image.open("/Users/nicole/Desktop/medium_score.png")
rgb_hed = RgbToHed()
rgb_hed(image)
rgb_hed(rgb_hed(image))

Expected behavior
4. should raise the Exception "Input image must be RGB." Instead, it will simply convert the color again.

After discussion, we have decided it is not a bug but it is user's responsibility to use filters correctly


Add Zeebe Deploy & Run Plugin

Which issue does this PR address?
Closes #2088
Prepares the Modeler to use these plugins with upcoming Zeebe Diagrams support (#2029).

Move over from Zeebe Modeler to prepare for the time we have Zeebe Diagrams in the Modeler.

[x] app/zeebe-api
[x]  client/ZeebeApi
[x] client/ZeebePlugin (disabled for the time being)

Fixed Run Plugin to be run with new global endpoint behavior (1af39656a6e1e5fdf9e8add5c0cf4dd02b3e19e7).
Refactorings made on the fly (Happy to share this in the Hour of Code 🎸 )

Acceptance Criteria

[ ] Corresponds to the concept
[ ] Corresponds to the design

Definition of Done

[ ] corresponds to the design principles
[ ] corresponds to the code standards
[ ] passes Continuous Integration checks
[ ] available as feature branch on GitHub

[ ] contains the cleaned up commit history
[ ] commit messages satisfy our commit message guidelines
[ ] a single commit closes the issue via Closes #issuenr

Let's merge it then and finish the integration with https://github.com/camunda/camunda-modeler/issues/2029.

Let's merge it then and finish the integration with https://github.com/camunda/camunda-modeler/issues/2029.


LoginSheet appears below tab navigation

This is a known issue when using bottom sheet combined with a tab navigator. It looks like we might be able to use BottomSheetModal instead as a workaround. There's a long thread about this here.

[ ] LoginSheet should appear above Tab Navigation bar so the bar is no longer visible

this looks like it should be closed? potentially by https://github.com/inaturalist/iNaturalistReactNative/commit/01099be1ce269cca428e158e4708bcbcf7322492

Correct, thanks.


Revert 2.20.1

Instructions

PR target branch should be against development
PR title name should follow this format: https://github.com/mParticle/mparticle-workflows/blob/main/.github/workflows/pr-title-check.yml
PR branch prefix should follow this format: https://github.com/mParticle/mparticle-workflows/blob/main/.github/workflows/pr-branch-check-name.yml

Summary
Reverting all commits since 2.20.0. An issue was discovered with the platform that approximately lined up with the timing of the web SDK release, though it may be unrelated.  We are reverting this as a precaution to reduce the code change footprint to remove the web SDK release as a possible culrpit.
Testing Plan

[ ] Was this tested locally? If not, explain why.
Ran unit tests which passed

Reference Issue (For mParticle employees only.  Ignore if you are an outside contributor)

Closes https://go.mparticle.com/work/REPLACEME

:tada: This PR is included in version 2.20.2 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

Note that on 4/5 the issue was discovered to be unrelated to the Web SDK release.  This Web SDK release will be re-released as version 2.20.3 on Monday, 4/10/2023.


Remove unnecessary null pointer checks

An extra null pointer check is not needed in functions like the following.

AsyncProcThread
TC_Epoller::create
TC_ThreadPool::destructor

Thanks for your advice.
Yes, delete null pointer is fine.

How do you think about to use a development tool like “clang-tidy” for corresponding source code adjustments?

You can use clang-tidy to check and standardize your source code.


Add support for Django 4.1 and Python 3.11 - tox

Hi there :)
Here's a small PR for this lib to stay compatible with recent Pythons & Djangos. Cheers.

Thanks ! Feel free to release, now :)


Stop using regular expressions for tokenizing and validating URIs

They are error-prone because they are difficult to read and change.
These libraries are useful:
https://validators.readthedocs.io/en/latest/#validators.url.url
https://docs.python.org/2/library/urlparse.html
https://docs.python.org/3/library/urllib.parse.html

https://github.com/EMBL-EBI-TSI/tesk-core/commit/393d3b62f8d3d63ec364b10608b4e8036dc71603


dealt with issue 22

dealt with issue 22 so now we are parsing county names from the top of each page

Looks good to me. Nice work!


Blocks options can't change with react

Hi, I'm trying to make an field for inputting a percentage value. using these options:
{ delimiters: ['.'], blocks: [2, 2], numericOnly: true }
Using it works just fine, until someone try to input 100% in it...
by typing 100, cleave shows 10.0, so i made a code in wich:
If the input is 10.0, the user is probably trying to input 100, calling a function by onChange and then setting a new state.
Then my options looked like this:
{ delimiters: ['.'], blocks: [this.state.fullSplitOpt, 2], numericOnly: true }
I tried almost everything, but the input text won't change, it remains 10.0 or 10.00, i checked if my state was changing and it does, also not using a state and using a global variable instead didn't do the trick.
So, I'm looking for a way to change my options on the fly, can anyone help me?
*Sorry for bad english...

Unfortunately, cleave doesn't support changing options on the fly.
Also how would you know if the use is trying to enter 10.05 or 100?


Implement file metadata, read, and write APIs.

This also improves how HANDLEs are, well, handled a bit. STDIN/ERR/OUT are now proper pseudo-handles. The invalid handle is added and encode/decodes to exactly 0xFFFFFFFF correctly.
Unix shims require changes to hoist FdTable up, so that Windows can share most of its implementation.

Thanks for the PR!
This is a huge PR. It will take a while until I have enough time to take a look at such a big change. If there is any way to stage this as a series of smaller changes, that would be much appreciated.

I could possibly further split this down by first PRing the FdMap move, and the handle changes, as their own PRs. In that format, both of those would basically be refactors with no/minimal functional changes, then this PR would just add the shims. It would still be a good bit of stuff, just because even a minimal test needs 4 or 5 shims, but it would be notably smaller hopefully.

That sounds like a good plan. You can keep this PR open (maybe mark it as draft); it can serve as good context for why you want to refactor things the way you suggest.

Also, I know very little about the Windows API... @ChrisDenton @beepster4096  if you have any chance at taking a look at the windows-specific parts here and check whether they look sensible, that would be great. :)

@sivadeilra - here's one of the PRs related to adding Miri support for Windows FS APIs, RE: https://github.com/rust-lang/miri/issues/3482

:umbrella: The latest upstream changes (presumably #4046) made this pull request unmergeable. Please resolve the merge conflicts.

Rebased on top of #4045

:umbrella: The latest upstream changes (presumably #4045) made this pull request unmergeable. Please resolve the merge conflicts.


Rework docs for Prosopo

Make the Astro docs template work with Prosopo documentation

Hello! Thank you for opening your first PR to Astro’s Docs! 🎉
Here’s what will happen next:

Our GitHub bots will run to check your changes.
If they spot any broken links you will see some error messages on this PR.
Don’t hesitate to ask any questions if you’re not sure what these mean!

In a few minutes, you’ll be able to see a preview of your changes on Vercel 🥳

One or more of our maintainers will take a look and may ask you to make changes.
We try to be responsive, but don’t worry if this takes a few days.


Updates to 526EZ Confirmation Email

Value Statement:
As a Veteran
I want to view the 526EZ email
So that I have accurate data and updated content
Acceptance Criteria
1. Updated Content
GIVEN I receive the 526EZ confirmation email
WHEN I review the email
THEN I view the updated content (form 21-526EZ removed from claim details, add last two sentences in email footer, add analytics to the link)
2. Updated time and time zone for date submitted
GIVEN I receive the 526EZ confirmation email
WHEN I review the email
THEN I view the time and time zone (time in UTC)
3. Updated subject line
GIVEN I receive the 526EZ confirmation email
WHEN I review the subject line
THEN I view the update subject line (We’ve received your application)
Checklist:

[x] Content updated - form 21-526EZ removed from claim details)
[x] Content updated - add last two sentences in email footer)
[x] Content updated - display link - 'https://www.va.gov/claim-or-appeal-status/' embed link - (https://www.va.gov/claim-or-appeal-status/?utm_source=VANotify&utm_medium=email&utm_campaign=526EZ)
[x] Time and Time zone updated
[x] Subject line updated (We’ve received your application)

Assumptions:

Additional Info/Resources:

Please review mockup for the changes

Out of Scope:

Open Questions:

Current template subject is: 'Form 526 submission confirmation". Should it be updated to say 'Disability Compensation Application' instead of 'Form 526' ?- Added AC 3
Question from Todd on the last sentence not displaying - Added to AC 1
Question on adding analytics to the link (?utm_source=VANotify&utm_medium=email&utm_campaign=526EZ) - Added to AC 1

Mockup:

Reviewed Litmus and the following issues -

Apple Mail 12
https://litmus.com/folders/unsorted_emails/emails/1591409/checklist#appmail12

Apple Mail 13
https://litmus.com/folders/unsorted_emails/emails/1591409/checklist#appmail13

Outlook 2016 + Mac OS 10.12
https://litmus.com/folders/unsorted_emails/emails/1591409/checklist#ol2015

Verified changes in Litmus.


node: Adding WithCoreClient option

Depends on #292 and #301
Adding CoreClient option for node
Closes #302

@Bidon15 pls resolve merge conflict 🙏🏻


[NPC Gyms] Highrift causing server crash

Battling Highrift NPC Gym causing server crash.
I have managed to create the exact same circumstances twice now to cause this:

Lead Koraidon w/ choice band Flare Blitz to one-shot the gym's lead Corviknight
NPC will send in Scizor and use Bullet Punch
Battle chat will read "Scizor used Bullet Punch" but before effects of Bullet Punch can take place, I get stuck on "waiting..."
After about 30 seconds of waiting, server crashes.

I've added a video link here where i used a completely different strategy and the same bug occurs, just later (turn 13 Corviknight uses Defog).
https://www.dropbox.com/scl/fi/djtumfpip2gw33o69gnuo/Screen-Recording-2023-11-01-at-11.43.21-AM.mov?rlkey=uxsndjahwygqjzh3r3ottqjay&dl=0
Also took this screenshot of the beta servers console, which occured immediately after I sent the challenge to the NPC gym

Issue cannot be reproduce if the player uses Bullet Punch on Scizor in a normal battle.

Fixed by Pixelmon, closing


DBZ-3124 Update Vitess documentation of ENUM limitation for Vitess 8.0.0

https://issues.redhat.com/browse/DBZ-3124
Related PRs:

Feature implementation: https://github.com/debezium/debezium-connector-vitess/pull/20
Website: https://github.com/debezium/debezium.github.io/pull/641

Added the issue key to the commit message.

Yes, please. Each (non-trivial) commit should be attributed to an issue for the sake of later reference. There's a check in place which fails builds if no key is present. We deviate from that rule for trivial commits e.g. for fixing a single typo (accepting and ignoring the build failure in this case). But for an actual change like this one here, each commit should have a reference.

Thx!

Yes, please. Each (non-trivial) commit should be attributed to an issue for the sake of later reference. There's a check in place which fails builds if no key is present. We deviate from that rule for trivial commits e.g. for fixing a single typo (accepting and ignoring the build failure in this case). But for an actual change like this one here, each commit should have a reference.

Great. Thank you for the explanation :)


Remove permitsRequestBody in HTTP Methods

Remove permitsRequestBody in HTTP Methods to allow custom method with the body.
https://github.com/square/okhttp/issues/229

@swankjesse I have changed the code same as #229 but two tests are failed
URLConnectionTest.response308WithHead:2334->testRedirect:2373 expected:<[]> but was:<[Page 2]>
 URLConnectionTest.response307WithHead:2318->testRedirect:2373 expected:<[]> but was:<[Page 2]>

For further discussion: I don't think removing this check is the right approach.  It might be that we should blacklist instead of whitelisting the special cases.
Overall given the support for WEBDAV verbs, supporting previously unknown HTTP verbs seems appropriate, so I'm not against the sentiment of the change.

@yschimke  We are using lots of custom HTTP method in our projects, I have not seen any problem with using any custom verb with the body. Other rest clients like Alamofire in ios can do it now. Any plan for removing this restriction in a new version?

My point wasn't around unknown custom verbs.  It was that allowing body for a GET request seems like a step back.


Disable interaction with the content of the "home" tab while capturing

It should not be possible to switch process, load sessions, load modules, etc.,
while taking a capture, as this can cause crashes, inconsistencies, and other
bugs.
Note that the content of the tab doesn't visually change.
Bug: http://b/157641797

From the code side this looks good but I don't want to make an argument on the visual-side.
I guess it would be more visible to the user by disabling ProcessesList, SessionList, ModulesList?

I guess it would be more visible to the user by disabling ProcessesList, SessionList, ModulesList?

Yes, it would be great if we could visually indicate that these are actually disabled (unless I misunderstand and this is already done.)

I think it is better to fix the crash - because until it is root-caused and fixed something else can trigger it.

I guess it would be more visible to the user by disabling ProcessesList, SessionList, ModulesList?

From what I've been able to see, disabling the single lists also has no visual effect on them.

I guess it would be more visible to the user by disabling ProcessesList, SessionList, ModulesList?

From what I've been able to see, disabling the single lists also has no visual effect on them.

Ahh, right. We are overwriting the "disabled"-style in main.cpp by forcing a custom QPalette. I guess there is no quick fix to this. So once again, sorry for the noise.
In the long run we should rely on a fully prepared dark style like this one: https://github.com/Alexhuszagh/BreezeStyleSheets (based on QDarkStyleSheet, MIT-licensed)

I think it is better to fix the crash - because until it is root-caused and fixed something else can trigger it.

Even if the root caused was fixed, trying to select a different process or to load a session or module while capturing would still not make sense. I agree that the root cause should also be fixed, but I think that's quite a bigger task, that requires completely separating the "live" part of Orbit (processes, modules, etc.) from the data needed by a capture.

Ahh, right. We are overwriting the "disabled"-style in main.cpp by forcing a custom QPalette. I guess there is no quick fix to this. So once again, sorry for the noise.
In the long run we should rely on a fully prepared dark style like this one: https://github.com/Alexhuszagh/BreezeStyleSheets (based on QDarkStyleSheet, MIT-licensed)

The noise is helpful, because now I know that I can comment out the styling and I can see the real effect of disabling different parts of the ui. Disabling the entire content of the tab also causes the components to look disabled. So unless we have specific parts of the tab that we want to leave enabled, I think it's fine the way it is.
Screenshot while capturing:


Initially saml2 authentication working for my app but suddenly it stops working(I did not change any file).

Following steps are happening while authentication
1)User is hitting below url
https://{our_domain}/forcelogin/{appId}/direct"
2)After hitting above url user will be redirected to below site
https://login.microsoftonline.com/{our_tenantId}/saml2?SAMLRequest={autogenerated code after hitting above url}
3)After entering credentials user is redirecting to below url
https://login.microsoftonline.com/{our_tenantId}/login
4)For 2 min, we can see above url in browser then it show timeout error and gives below url
https://{our_domain}/authreturn
We are using below npms
Passport Modules:
"passport": "0.4.0"
"passport-azure-ad": "3.0.10"
"passport-saml": "0.15.0"

If you've believe you've found a bug in passport-saml, add a test case to the test suite which triggers it.


Adding error bar to points

Hello!
I've been trying to add error bars to the individual points (for technical replicates in an experiment). It seems the plot function generates a ggplot2 object but it's not mantaining the original variable names maybe?
require(dabestr)
require(dplyr)
require(ggplot2)

GroupCtrl = rnorm(n = 5, mean = 5000000, sd = 500000)
GroupTest = rnorm(n = 5, mean = 4500000, sd = 450000)

SimulatedData = data.frame(Group = factor(c(rep(0,15),rep(1,15))),
                      Replicate = factor(rep(rep(c(1,2,3,4,5), each = 3),2)),
                      PeakArea = c(sapply(GroupCtrl, function(x){x + rnorm(n = 1, mean = 0, sd = 35000)}),
                                     sapply(GroupCtrl, function(x){x + rnorm(n = 1, mean = 0, sd = 45000)}),
                                     sapply(GroupCtrl, function(x){x + rnorm(n = 1, mean = 0, sd = 15000)}),
                                     sapply(GroupTest, function(x){x + rnorm(n = 1, mean = 0, sd = 25000)}),
                                     sapply(GroupTest, function(x){x + rnorm(n = 1, mean = 0, sd = 20000)}),
                                     sapply(GroupTest, function(x){x + rnorm(n = 1, mean = 0, sd = 30000)})))
levels(SimulatedData$Group) = c('Control', 'Treatment')

SEM = function(x){return(sd(x)/sqrt(length(x)))}

GroupedData = SimulatedData %>% group_by(.dots = c('Group','Replicate')) %>% summarize(AvrgPA = mean(PeakArea),SEM = SEM(PeakArea))
unpaired_mean_diff <- dabest(GroupedData, Group, AvrgPA,
                             idx = c("Control", "Treatment"),
                             paired = FALSE)

p = plot(unpaired_mean_diff)
p

So far so good, but if I try to add error bars..
p + geom_pointrange(aes(ymin=AvrgPA-SEM, ymax=AvrgPA+SEM))

Error in FUN(X[[i]], ...) : object 'AvrgPA' not found

Any workaround this?
Thank you so much!

Hi! You've got two issues here: technical replicates, and handling the output of plot.dabestr().
1. Technical replicates
dabestr does not currently have the ability to handle multilevel models, which in your case represents technical replicates of the same sample. So the bootstrap curve
Using your example code above, with
set.seed(12345)

for reproducibility, you get the following Gardner-Altman plot:

We've deliberately designed the Gardner-Altman plot to not display the individual groups' mean±SD, because the presence of multiple (potentially overlapping) horizontal and vertical lines is aesthetically jarring, and likely to be distracting.
One way around it is to use
plot(unpaired_mean_diff, float.contrast=FALSE)

to obtain a Cumming plot instead.

BUT, as noted, these are TECHNICAL REPLICATES, so the effect size is actually not correct as they are not independent samples from the same population. I'm not sure what your experimental design is, but I would suggest obtaining multiple samples (with Ns to give you sufficient power) and computing the effect size.
PS If you have multilevel modelling code for bootstrap effect sizes sitting around, please feel free to do a pull request and add it to dabestr!
2. Output of plot.dabestr()
The output of plot.dabestr() might look like a ggplot2 object, but we've used cowplot to stitch together two separate plots. I'm not sure if one can replot in the ggplot style of adding to the grob with a cowplot object.... You might have more luck on that package's Github issue tracker!
Hope this helped!

Hello Joses!
Thank you for your detailed answer. I am aware of the multilevel design issue, but in biology most of the time the technical replicates are reduced to 3: they are mainly interpreted as a quality metric and they are too few to perform bootstrap on them. I didn't want to overcomplicate the analysis, and I will just try to plot the average as a representative measure of all the technical replicates together with the SEM of each biological sample (group of replicates) to put in context the small relative error of the technical process in comparison to the biological variance.
I'll try to play a little bit with the code and see what I can make.
Thanks.

Hello Again,
I made some progress (see below) but I am a bit stuck trying to find the variable add the jitter to the geom_pointrange.

Regarding the presence of multiple vertical lines and the jarring / swamp effect, this is just a proof of concept with simulated data: In the kind of data I am planning to plot the error bars should be much smaller and the sample size is still relatively small, so it should be ok.
Thanks!

Ok, I figured out how to make a proof of concept..

Basically I modified the function plot.dabest :
if (rawplot.type == 'swarmplot') {
    rawdata.plot <-
      rawdata.plot +
      do.call(ggbeeswarm::geom_quasirandom, swarmplot.params)

I commented rawdata.plot <- rawdata.plot + do.call(ggbeeswarm::geom_quasirandom, swarmplot.params)
and substituted it for
  rawdata.plot <-
        rawdata.plot +
        ggplot2::geom_pointrange(alpha = 0.75, size = 0.5,
                               aes(!!x_enquo, !!y_enquo, color = Group,
                                   ymin= AvrgPA - SEM,
                                   ymax= AvrgPA + SEM),
                               position = position_dodge2(width = 1.25, padding = 0))

It took me a while to fix the dodge. I am not very proficient with R. It would be really cool if you could add a more consistent version of this to the package (as an alternative to the swarmplot and sineplot, making the function request for a sd/sem column, maybe?).
Thanks again!

This looks interesting.... Could you start a pull request, and we can see how to finesse this? (You will be listed as a contributor if you start a pull request, which would be more favourable than if I copy-pasted your code.)

Ok, pull request opened! I'll be taking a look on the code to see how do you want to organize the function, and I'll try to contribute further.
I've noticed that the webpage plotting tool actually have some more features in terms of size effects?  Aren´t those metrics implemented yet in the R package?
Best regards,

Thanks for the PR!
Re: standardized effect sizes—these are in the pipeline (see #31 and #32). The webapp uses the Python DABEST package as the backend; this has the standardized effect sizes implemented already.


Improve analysis: try modelling interaction terms for LinearRegressor

[ ] Add some relevant interaction terms (e.g., neighborhoood x property type)
[ ] Re-run linear regressor model
[ ] Report MSE and residual plot to see if predictions improved

Not addressed in milestone 3


feat(ui): add LightningInvoiceInput component

Description:

Implement a new form field component to handle input and validation of lightning invoices and bitcoin addresses.
Validates data according to BOLT standards.
Support Bitcoin and Litecoin address formats.

Note: This PR builds on the work done in #862 which should be merged first.
Motivation and Context:

Preparation for revamp of Pay/Request forms
DRY up codebase

How Has This Been Tested?

yarn storybook and navigate to Components / Form / Lightning Invoice Textarea.
Also see examples added to the Components / Form / Example form

Try entering valid/invalid values for each field and see validation pass/fail accordingly.
Screenshots (if appropriate):

Types of changes:
New feature
Checklist:

[x] My code follows the code style of this project.
[x] I have reviewed and updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.
[x] I have added tests to cover my changes where needed.
[x] All new and existing tests passed.
[x] My commits have been squashed into a concise set of changes.

Coverage decreased (-0.2%) to 17.486% when pulling 0b4fd201a366589cefe59f6dd21f8ddb7e32db59 on mrfelton:feat/ui-lightning-invoice into 5ae8b67a17c92cdd262a7d74a09321fac0860449 on LN-Zap:master.

@mrfelton Weird. I'm getting:
ERROR in ./.storybook/config.js
Module build failed (from ./node_modules/babel-loader/lib/index.js):
SyntaxError: /Users/jmow/Projects/bolt/bolt-desktop/.storybook/config.js: Unexpected token, expected "," (15:24)

was a rebasing conflict. resolved now @JimmyMow

@mrfelton can you rebase?

Tested ACK 8b203f1


Dependencies - unknown_types

Hi. Either I don't understand how dependecies work or there is an issue. I bet on the first one 😝
I ran SAPRSEUB and SAPRSEUC reports in the background and when they completed I ran ZABAPLINT_DEPENDENCIES providing a seperate repository.
Then I added to my abaplint.json these lines:
"dependencies": [
        {
            "files": "/src/**/*.*",
            "folder": "/lint_deps",
            "url": "https://github.com/abaplint/deps"
        },
        {
            "files": "/src/**/*.*",
            "folder": "/lint_deps2",
            "url": "https://git.hicron.com/abap/ksef/ksef-deps"
        }
    ],

I don't understand the folder meaning. I modeled it after configs in some issues and the one in abapgit repo.
Here is my problem. When I run pipeline it checks my primary repository AND dependencies repo. Why?
If it is correct behaviour then why ZABAPLINT_DEPENDENCIES didn't also extracted /HCR/TRE_RESTCLS if it is used by /hcr/cl_rest_base?

folder: if folder is specified, the code will look for the folder locally, if it does not exist, it clones the url
this is very useful for testing locally, or if some dependencies are only local to the repository
the combinations are:

only folder
only url
folder and url

Ok, thank you for folder meaning explanation. What about the second part? Is this an expected behaviour? Dependencies should also be checked by abaplint?

closing


Any solution to improve the quality of lipsyncronized video?

Hello, I have generated lipsync video from video and audio using smirk and other models.
https://github.com/user-attachments/assets/acdeeeaf-116f-4699-a7e0-259036b013bd
Video as input:
https://github.com/user-attachments/assets/a4fe31a3-0f85-45ef-abed-3c700646fe5d

Hi @airpdev , is the first video generated by smirk? I tried on input video you provided, but the output vid has much flickering. Did you add extra steps or other models?
Thank you!

Hi, the smirk generator is not temporally stable and not trained to do so, so what you are seeing is normal (the generator is a byproduct of our training of the encoder).
One solution to obtain results would be to train a personalized generator on only a person and video, keeping the encoder frozen. Some relevant resources:
https://foivospar.github.io/NED/
https://github.com/michaildoukas/head2head


Language changed by one user in the room isn't reflected to other users.

Describe the bug
If a user in a room changes the language, this change is not being reflected in other users.
To Reproduce
Steps to reproduce the behavior:

Create a room.
Join from another browser.
Change language in one web client.
This change is not sent to other web clients in the session.

Expected behavior
The language selected by one user should also be passed to other web clients in the room because when they run the code it might show compilation errors as their language selection is not the same...

Thank you @Aksh-Konda , yea this seems like an oversight, it could be very easily implemented using socket-io, I'll look when I can do this because currently I'm really occupied with preparing for coding interviews and grinding leet code  D:


Use AxonThreadFactory instead of default

use AxonThreadFactory instead of default so thread pools and thread created by axon have non-default names (e.g.: useful for troubleshooting stuck threads)

Hi @fransguelinckx!
Thanks for this, sounds like a logical thing to do as well...but I got one question for you.
Does it have to be against 3.2.x?
Is it possible for you guys to get this to 3.3.x?

Upgrading to axon 3.3.x. is on our roadmap for 2018, but not in the near future. I guess 3.3.x is workable for us, we could try it out with this fix and determine priority of upgrade based on the result.

Nice, that's good to hear @fransguelinckx :-)
Would you mind branching this fix off of 3.3.x once you've got the time for that?

Will do. Close this pull request and open a new one?

That sounds like the most pragmatical approach ;)
I'll close it for you, thanks for the effort so far @fransguelinckx!


Support for arbitrary data type (non array)

We have been asked to consider ZARR container format for our data which includes/consist of not geospatial/non-array data but we have problems as it is clear that the "array" heritage of the format has resulted in non flexible choices and ZARR is not well suited. We need

natural support of arbitrary non-array data in they native format
direct semantically meaningful mapping to filesystem of the data allow data manipulation without any API

Until now we used simpler containers (SAFE format) which directly mapped on the filesystem as a collection of arbitrary files in a set of directories (both data and metadata) which allowed us total freedom to store data files in they native format maintaining a direct relation at filesystem level. We fundamentally want to be able to store some of our externally generated files in the original format with the original filename. Data could be sparse data, poligons, documentation, code, bitstreams, algorithms.  Direct identification and management of these file at filesystem level with semantically meaningful names is critical for our workflow. So if we unzip the product and navigate in the directory structure we would recognise our files directly and would be able to manipulate/copy/edit them directly.  Having the data chucked and put blindly in files called 0.0,   0.1, etc  is silly and would not work for us.
btw We are having a similar discussion with the use of STAC  catalogue that also does not support this type of data. For that we are considering OGC Record API that allows arbitrary catalogue data (could be a catalogue of books instead of satellite images).
Is there any clean way to do it in ZARR ?

It sounds like you just want a filesystem or key-value/object store.  What are you hoping to achieve from zarr?  Do you just want some way to mark a zarr group/ directory as containing arbitrary files?

Welcome @mzundo! 👋

We

Who is "we"?

have been asked

By whom?

to consider ZARR container format for our data

What sort of data?

Data could be sparse data, poligons, documentation, code, bitstreams, algorithms.

Sparse array support has been discussed and is feasible in Zarr but not implemented
Polygons can definitely be supported. We use CF encoding for this
Documentation - sounds like a good fit for Zarr metadata
bistreams - Zarr can store raw byte arrays
code & algorithms - why would you want to but code and algorithims inside a data format? doesn't sound like a good idea

Zarr is meant for storing structured array data and associated metadata. It is often beneficial for users to use a structured data model, rather than distributing opaque files.
But if you really want a container to distribute arbitrary code, files, etc. together, zip file or tar.gz would be a good fit I guess.

So summarizing the answer Zarr is not, like I suspected, adequate for the purpose of being a generic data format to support in a standardized way both geospatial information and associated non geospatial data.
If like I understand there is no plan ir way to make it more than a transport for arrays I will recommend not to use it.   Thanks for the answers.
I

Zarr is not, like I suspected, adequate for the purpose of being a generic data format to support in a standardized way both geospatial information and associated non geospatial data.

That's not what we said.
You arrived here with the assumption that Zarr was not a good fit for your application, asked some biased questions, declined to provide any details about your use case or requirements in response to our follow-up questions, and have now reached the predetermined conclusion you wished for. This doesn't feel like a constructive conversation.
Nevertheless, we wish you luck with you project. We're still curious to hear more details about your project and what file format you ultimately settle on if you care to share.


Add testing of Push Jobs add-on

Description
This adds Push Jobs add-on testing in each terraform scenario after an
initial Chef Infra Server install and smoke test.
Signed-off-by: Christopher A. Snapp<EMAIL_ADDRESS>Issues Resolved

#1803

Check List

[ ] New functionality includes tests
[ ] All buildkite tests pass
[ ] Full omnibus build and tests in buildkite pass
[x] All commits have been signed-off for the Developer Certificate of Origin. See https://github.com/chef/chef/blob/master/CONTRIBUTING.md#developer-certification-of-origin-dco
[ ] PR title is a worthy inclusion in the CHANGELOG

After a brief discussion with @tduffield, it was decided to remove the requirement for them to approve every terraform change.
As such, I've removed them from the terraform rule in .github/CODEOWNERS.


Add beta column modification

Is is a mistake that
https://github.com/cortezaproject/corteza-server/blob/865ee431c15f4f360dd7f1f87770aec2b479e75a/store/adapters/rdbms/dal/connection.go#L154-L178
calls UpdateModel? Why would a creation call an update? As part of this PR I've removed the call to UpdateModel and pulled up potential errors into the CreateModel function. This is not necessary for the PR.
Why does rdbms/ddl/dal_model.go:UpdateModel iterate over model attributes instead of
https://github.com/cortezaproject/corteza-server/blob/865ee431c15f4f360dd7f1f87770aec2b479e75a/store/adapters/rdbms/ddl/dal_model.go#L47-L55
rdbms.dal/connection.go:UpdateModelAttribute?
pkg/dal/driver.go:UpdateModel note says not to update attributes, only metadata.
https://github.com/cortezaproject/corteza-server/blob/865ee431c15f4f360dd7f1f87770aec2b479e75a/pkg/dal/driver.go#L80
However it looks like store/adapters/rdbms/ddl/dal_model.go:UpdateModel is preparing to do just that.
Is this just an unfortunate naming coincidence? I see that the dal_model:UpdateModel is not part of the implementation of the aforementioned UpdateModel's interface.
Also store/adapters/rdbms/dal/connection.go:UpdateModel which is part of the interface that says not to use UpdateModel to update attributes has a todo saying "check if column exists and if it can be removed".
https://github.com/cortezaproject/corteza-server/blob/865ee431c15f4f360dd7f1f87770aec2b479e75a/store/adapters/rdbms/dal/connection.go#L223-L230
Why would it need to do that if it's not supposed to update attributes?
Why is there dal specific code in compose/service/module.go ?
What does Asserted mean in pkg/dal/diff.go? Was that meant to be "Inserted"?
https://github.com/cortezaproject/corteza-server/blob/865ee431c15f4f360dd7f1f87770aec2b479e75a/pkg/dal/diff.go#L12
store/adapters/rdbms/dal/connection.go:UpdateModelAttribute says it's not raising unsupported errors since it doesn't want to break "DAL service model adding procedure". What is it referring to by the adding procedure?
What tests would you like?
How do you do sqlite testing? It doesn't save the data inside the file I give it
I've tested manually on mysql,postgres and sqlite.
Tests I've completed:

Add column
Delete column
Attempt to add required column with records and get error
Attempt to modify existing physical column and get error
Attempt to change schema of compose_record and get error
Attempt to modify json type column and succeed
Attempt to make any physical changes when DB_ALLOW_DESTRUCTIVE_CHANGES is not set and get a not-supported error

I see I have some tests to modify. I'd be interested in getting if I'm going in the right direction on this PR before fixing those.

Hey @darh ,
I'm travelling over the next 1.5 days so I'll have time to put fixes in if it gets reviewed today.

Ack, will try to review all of them in next couple of hours. Travel safe:)

I've made the changes requested.
I also tested that provisioning works on empty DB's for  mysql,postgres, and sqlite.
I'll fix the broken tests later today or tomorrow.
Some unanswered questions from my original PR comment:
Can I change from Assert to Insert?^1
How do you check test sqlite data? It's in memory and I can't see the data. Are you using shared memory or something like that to test?

Some unanswered questions from my original PR comment:
Can I change from Assert to Insert?1

Sure.

How do you check test sqlite data? It's in memory and I can't see the data. Are you using shared memory or something like that to test?

DB_DSN=sqlite3://path-to-db.db

@darh ,
Sorry for the long hiatus. I was travelling for a week and a half and had less time than I'd imagined. I'm back to it full force for the next month though.
I see that you migrated to a mono-repo structure. This is great!
Besides for the conflicts to resolve, are there any other changes I should make given the new repo architecture?

Glad to have you back 👋

Besides for the conflicts to resolve, are there any other changes I should make given the new repo architecture?

Not really. There is a bash script on the root that should help you migrate your branch if you care about your commits.
We've just migrated, and there might be things we overlooked. Patience, please :)

Patience you will have! I was thinking of making some cross repo PR's since one of the changes I had in mind was frontend but I was too overwhelmed. This will ease the process of making full stack changes by a landslide. Great job guys!


Use custom ping code

Because wait-on seems to time out, wrote my own using got

closes #41
closes #42

Tested in https://github.com/bahmutov/cypress-gh-action-monorepo/commit/55155a9aa163741e24d31f68abc67573c24526db/checks?check_suite_id=327723204


Fix error when picking supplemental files.

This PR resolves issue #7
The error was caused when there are no supplemental files in the local directory to load. If you try to inquire with a checkbox type without any options then it causes the crash.
I also put all of the code inside of a walker.on('end' ... event listener so that we are sure all of the files have been loaded before we ask the user for any details about the assignment.

:+1:

:+1:


Add method to_boolean to String, NilClass, TrueClass, FalseClass

Utility for script params (and maybe others) where the params have to be strings, but we want to evaluate as Booleans, e.g. "false".

coverage: 94.386% (-0.02%) from 94.402%
when pulling 5419f653afe6d65b3ebfeb7f855df97c129ee6dc on extensions-to-boolean
into 3c8a36ac81c5ffe977b4d89c067da2614b72eee0 on main.


Prevent tests from using "real" filesystem

This addresses ticket 3414. It modifies the base class for most datatracker test cases (ietf.utils.test_utils.TestCase) to automatically replace a number of paths in the settings with temporary directories. Subclasses can modify the list as needed, which is used to reduce repeated code in setUp() and tearDown() methods. The temporary directories are created and destroyed for each test, avoiding the possibility of cross-talk between test cases.
The first commit (389245c) is the change to TestCase. The second commit (f77291b) is updates to test classes that made use of setUp() and tearDown(). These were modified to call superclass methods and eliminated if they did not do anything other than what is now provided by the superclass.
Additionally, in a number of places I replaced old-fashioned path and directory library calls with the pathlib.Path class.

Committed as svn r19555


Add filters to online results list

We need to add a button for search/filtering of online results, and modify firebase functions API to support it.
Child tasks:

Add filtering by OS type

https://github.com/mlcommons/mobile_app_open/issues/505

Add filtering by backend

https://github.com/mlcommons/mobile_app_open/issues/506

Add filtering by date

https://github.com/mlcommons/mobile_app_open/issues/546
Only available when sorting by date

Add filtering by manufacturer

https://github.com/mlcommons/mobile_app_open/issues/542
You can only choose one
Also need to maintain a list of known manufacturers

Add filtering by exact device model

https://github.com/mlcommons/mobile_app_open/issues/543
You can only choose one
Also need to maintain a list of known models

Add filtering by SoC/CPU

https://github.com/mlcommons/mobile_app_open/issues/547
You can only choose one
Also need to maintain a list of known models

We may need to cut some of the filters because of the Firebase limitations.

Firebase limitations

Support for logical operators OR and != is very limited

OR is only possible once per query and is limited by 10 values in one array field
!= is only possible once per query
OR and != are mutually exclusive

You need to create an index for everything

At the very least you need a special index for each queried field and for each sorting option
We need 8 possible sorting options: newest first, oldest first, and 6 fastest <task> first (now we have 5 tasks but we expect to add a new one for super resolution)

For each field that we add we must add 8 indices

Total number of indices is limited by 200
It's possible to create indices programmatically

What this means for us

Filters of type "select X values from Y possible values" are generally forbidden

You can still create such filters provided the number of possible values is known beforehand and is small enough

I tried doing this for OS type filter, where we only have 3 values

Manufacturer, Model, SoC/CPU filters must be of type "Select one value from Y possible values"
We may have up to 25 indexed fields

If we add more sorting options this number will decrease

Adding a new task adds a sorting option

"select 1 from Y" filter adds 1 indexed field
"select X from N" filter adds N indexed fields

@mkankana for your information, the limitation of Firebase

We may have up to 25 indexed fields

If we want to update our database scheme without killing old version(s) of the app, we will also need to keep indices for several database schemes. Alternatively we will need to create several Firebase projects.

mostly we are destined to run into the limitations of Firebase, so we need an alternative.
we need either NoSQL, such as MongoDB, or embedded SQL, such as sqlite. Please add some more information of available either NoSQL or SQL DB services.

I case we need to change to another DB, we should also think about this related issue https://github.com/mlcommons/mobile_app_open/issues/550 at the same time.
So we actually need a local DB for storing benchmark results and an online DB for storing uploaded results. It would be beneficial to have both local and online DB of the same type.
I have worked a lot with DB, so here are some of my thoughts:

We should use a DB as a service for the online DB since maintaining a DB server requires great effort.
I, personally, would choose SQL over NoSQL because querying with SQL is standardized, and many developers should already be familiar with it. My favorite choice is PostgreSQL.
Either NoSQL or SQL, we should always think carefully about the DB schema.

A fully-fledge DB on mobile devices sounds weird to me, that's why I mentioned embedded DB such as sqlite, which is supported by Android and iOS. I don't know how hard it is to have sqlite on google cloud, though.

It would be beneficial to have both local and online DB of the same type.

With the same type I mean either SQL or NoSQL. If PostgreSQL is for the server (the online DB), then the client can use SQLite (the local DB).
I never tried to use SQLite on the server-side. I think it's better to use one of the available managed databases (e.g. on Google Cloud).

SQL is available as a service in GCP, including PostgreSQL.
NoSQL options in GCP are Firestore and Bigtable.
We already know that Firestore doesn't fit our needs.
Bigtable is a low level database, it seems to be oriented toward streams of data, so it also wouldn't work for us.
GCP also has a partnership with other services.
Particularly there are MongoDB Atlas and Elastic Cloud, which provide MongoDB and ElasticSearch as a service respectively.
I'm not sure how deep the integration is, but the billing will be through GCP.

It would be beneficial to have both local and online DB of the same type.

I don't think we would really benefit from it.
We have very different needs for local and for online results.

Requirements for online results:

Ability to add a new entry
List entries
Sort results by time or score
Filter sorted results via several criteria
Handle pagination
Handle 1000s of entries in the near future, and handle possibly 100k+ in far future

Requirements for local results:

Ability to add a new entry
Ability to delete an entry
List all entries
Maybe sort entries by creation time or by score in different benchmarks
Handle 1000s entries in the worst case. End users will most likely have no more than 100 entries, and developers will maybe have 1000s

Most of the filters are just invalid for local results. OS and hardware is not expected to change on a device.
Even if we decide to add some sort and filters for local results, the amount of entries in the history is small enough to load everything into memory and sort/filter them manually without performance concerns.
Right now we use JSON with a list of results as a kind "database" for local results, and it works fine.
The reason to have a proper database for local history is to avoid rewriting megabytes of data on disk each time when we add or delete a result, and also I don't really like the fact that user can open the text file and edit anything.
Also we use different languages in the app and on the server side. Even if we use the same database, we will need to have different libraries to access the database and different bindings to data classes.
So, overall, I don't think our local database should affect our server-side database in any way.

Our data structure is a document in a form of JSON.
We don't need to modify these documents after they are generated, but we do need to read some of the values in them for filtering and sorting.
So, our database for results must support the following:

List results
Filter and sort results based on several selected fields
Return source data

In SQL implementation would look like this:
One table.
Several columns, one for each of the required filters.
One column with serialized JSON.
But also the same scheme will work for NoSQL databases, except JSON serialization may be optional.
We don't need any of the SQL advanced features, we only need to search within a single table. So a NoSQL solution would work fine.
We also don't expect to have millions of users accessing the database at the same time, so I guess we shouldn't face any performance issues with SQL.

I prefer that both local results and online results sharing the same code and the same UI, maybe with the only different is a boolean flag "isLocalResult". So reusing UI elements and querying logic would be a big benefit. So, it should use the same type of DB.

in the old days when I learned to use DB on PCs decades ago. There is something called ODBC, which was intended to serve as a universal API to all relational DBs. Do we have something like for Flutter.

Another solution as mentioned in the meeting:
If the number of results is not big, we can just query all the results from Firebase then do the filtering locally on-device using the Dart programming language. So we can still use Firebase for now and have the feature with the least effort.
Later if the data grows big enough, we can transition to use another solution which is suitable for large-scale data (which requires much more effort to design and implement). The existing data from Firebase will be imported to the new DB.

Closing this in favor of https://github.com/mlcommons/mobile_app_open/issues/641


[BEAM-13995] Bump numpy bound to include 1.22 and regenerate container deps.

R: @TheNeuralBit @chamikaramj


Update ng-quill.js

console.log in a release version? really?

Thanks. I missed this. I thought uglify removes Logs per Default during minify.
I will create a new Release tomorrow.

thank you!


Bookmarker using JavaScript

Bookmarker_In_JavaScript_With_Source_code.zip

sure, could you please accept my pull request first.
On Sat, 17 Oct 2020 at 09:32, Krishna Vishwakarma<EMAIL_ADDRESS>wrote:

@thinkswell requested changes on this pull request.
Hey @jasmine-k05 https://github.com/jasmine-k05, the app works great,
But can you please add it to the directory: BookmarkApp/USERNAME,
instead of using a zip file.
Bonus Changes (If you enjoy doing it!!) 🎉🎉,

You can also make input site works either I enter "example.com" or "
www.example.com"
currently, it only works on "https://www.example.com"
You can use windows local storage to make it persistent.
Thank You!

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/thinkswell/javascript-mini-projects/pull/54#pullrequestreview-510871927,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/APNTV7CKJ6RX2OEFD6R6LVDSLEJNFANCNFSM4STXUROQ
.

I will be happy then to accept your pull requests.
Thank You. 😄

Hey, just give you PR again whenever you are done, will review quick.
Thank You!


Lazy load third party modules

Hi,
Is there a way to use this library to lazy load a third party module coming from npm?
An example can be ngx-quill that is a wrapper of the famous quill editor.
How can I lazy load the quill editor component declared in Quill module? (that coming from a library?)

I would like to know something similar to what @notarnet asked - I do have 2 libraries packaged with ng-packagr and available via CDN only - they are in a different repository from the main app and the main app doesn't know about them (except for a bit 😊)


Add option to intoduce system message to Google germini Model

By default, google Gemini doesn't support system messages, can we add that to the Gemini model when using it to power Agents.
From Langchain:
from langchain_core.messages import HumanMessage, SystemMessage

model = ChatGoogleGenerativeAI(model="gemini-pro", convert_system_message_to_human=True)
model(
    [
        SystemMessage(content="Answer only yes or no."),
        HumanMessage(content="Is apple a fruit?"),
    ]
)

Why not just add it to the task prompt? if it's being converted into a human message already


Integrated stripe payment into wix but while testing it i am getting Charge ID - Undefined error

I am not coder i am new to coding, i wanted to add stripe payment integration into my wix website, so i came around few videos on youtube and i decided to do myself and i integrated stripe payment into wix but while testing it i am getting Charge ID - undefined Error
below i have given my Home Page Code, Public/Frontend Code and Backend Code so please have a look and advise any help would be appreciated Thanks in advance
Home Page code -
import {createToken, encodeCard} from "public/stripeAPI.js";
import {charge} from 'backend/stripeProxy';
var payment;
export function payNow(event) {
createToken(encodeCard(createCard()))
.then((token) => {
console.log("Card token: " + token);
charge(token, payment)
.then((chargeResponse) => {
console.log("Charge ID: " + chargeResponse.id); -THIS IS CHARGE ID ERROR I AM GETTING
});
});
}
function createCard() {
return {
"name": $w("#cname").value,
"nuumber": $w("#cnumber").value,
"exp_month": $w("#month").value,
"exp_year": $w("#year").value,
"cvc": $w("#cvc").value,
};
}
function chnageState() {
payment = {
"amount": ($w("#amt").value*100),
"currency":"INR",}
}
export function chargeCard_click(event) {
payNow(); }
FrontEnd/Public Code -
import {fetch} from 'wix-fetch';
export async function createToken(card) {
//Go to stripe.com to create a test key and replace the one in the example
const apiKey = "YOUR_API_HERE";
const response = await fetch("https://api.stripe.com/v1/tokens", {
method: 'post',
headers: {
"Content-Type": "application/x-www-form-urlencoded",
"Authorization": "Bearer " + apiKey
},
body: card
});
if (response.status >= 200 && response.status < 300) {
const json = await response.json()
return json.id;
}
const responseText = await response.text();
console.log(responseText);
return response.status;
}
export function encodeCard(card){
let encoded = "";
for (let [k, v] of Object.entries(card)) {
encoded = encoded.concat("card[", k, "]=", encodeURI(v), "&");
}
return encoded.substr(0, encoded.length - 1);
}
BackEnd Code -
import {fetch} from 'wix-fetch';
export async function charge(token,payment) {
const cart = payment;
//Go to stripe.com to create a test key and replace th eone in the example
const apiKey = "YOUR_API_HERE";
const response = await fetch("https://api.stripe.com/v1/charges", {
method: 'post',
headers: {
"Content-Type": "application/x-www-form-urlencoded",
"Authorization": "Bearer " + apiKey
},
body: encodeBody(token, cart)
});
if (response.status >= 200 && response.status < 300) {
return await response.json();
}
return await response.text();
}
function encodeBody(token, cart){
let encoded = "";
for (let [k, v] of Object.entries(cart)) {
encoded = encoded.concat(k,"=", encodeURI(v), "&");
}
encoded = encoded.concat("source=", encodeURI(token));
return encoded;
}

closing as duplicate of #640


fix: user join read-only group response timeout

这个 PR 实现什么功能/修复什么问题:
修正：用户加入LDAP组未报错，响应超时
是否需要 backport 到之前的 release 分支:

release/2.11
release/2.12
release/2.13

/area apigateway
/cc @zexi @yousong

Codecov Report

Merging #3848 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master   #3848   +/-   ##
======================================
  Coverage    6.94%   6.94%
======================================
  Files         499     499
  Lines       84348   84348
======================================
  Hits         5854    5854
  Misses      77998   77998
  Partials      496     496

Flag
Coverage Δ

#aFlag
6.94% <ø> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3b50982...863fe14. Read the comment docs.

/lgtm

/approve

/approve
/lgtm


Test can now run on stable prs

About the PR

AWA
Why / Balance

We need it :3
Requirements

[x] I have read and am following the Pull Request and Changelog Guidelines.
[x] I have added media to this PR or it does not require an ingame showcase.

github why did you... change my title

github why did you... change my title

I think I have seen that happen before today. Github is acting funny for some reason.


Global Schedulers have no attribute 'write_batching_history'

Set 'MetricsConfig' write_json_trace default=True
Fix bug in simulator.py method '_write_event_trace'
Then I get: self._scheduler.write_batching_history()
AttributeError: 'RoundRobinGlobalScheduler' object has no attribute 'write_batching_history'

There is no any method 'write_batching_history' in Global Schedulers, only 'schedule'

Now I can successfully run again by commenting:
    if self._config.metrics_config.write_json_trace:
        self._write_event_trace()
        # self._scheduler.write_batching_history()
        logger.info("Json event trace written")


Support StartingDeadlineSeconds

Specifies the duration (in seconds) since startTime during which the job can remain pending before it is terminated.

/lgtm
/approve


Updating std::hast<EntityId_t> to get a better unordered containers distribution

Internally STL implementation of hash tables (unordered_map and set) use modulus operation to choose in which bucket put each element. Using an uniform distributed hash guarantees that the buckets get evenly filled and access time is minimum.
Until now we were using the whole EntityId_t interpret as a number as hash. That led to a non-uniform, unsuitable distribution because within each EntityId_t are kept flags not merely a counter. Now, only the counter value is used solving the speed issue.
This pull request contents has already been updated on 1.9.x (see #868).

Build status:

Linux
Mac
Windows
Performance

Failed test is known to be flaky.


List not updating after reloading while offline

First, I would like to say thank you very much, I think your work is amazing.
Cache is not working properly when you reload while offline. This can be reproduced in the official demo.
Steps to reproduce

While ONLINE, load the write-list demo
Add some items to the list -> Items are added and shown
Go OFFLINE
Add more items to the list -> Items are added and shown
Reload the page while OFFLINE -> Previous items are shown
Add more items to the list -> Items are added and shown
Reload again while OFFLINE -> You can see same items as in step 5, but not items added in step 6.
Add more items -> Items are added and shown (items from step 6 still hidden)
Go ONLINE -> Cache is synced. Items from step 6 are added back to the list!!!

The funny part is that write cache is working rightly almost always (updates are synced back even when not appearing in UI), but read cache don't. Maybe this is not a bug and is just how the firebase offline sync mechanism works.
If you watch the localforage db, you can see how write node is updating properly but read/object and read/list nodes don't.
Reloading twice while offline may not be very smart in a web page, but it is pretty common in a (hybrid) phone APP or PWA.
BTW, I have reproduced it in my environment as well:

Ionic: ionic-angular 3.4.2
Angular: 4.1.3
Node: v6.7.0
OS: Linux 4.4
npm: 4.6.1
angularfire2-offline: 4.1.5

Sorry for my English.

BTW, I have reproduced it in my environment as well:

Ionic: ionic-angular 3.4.2
Angular: 4.1.3
Node: v6.7.0
OS: Linux 4.4
npm: 4.6.1
angularfire2-offline: 4.1.5

Hi @gartorware, thanks for reporting this issue! I can confirm that this is a bug and I'll be working on fixing it.

Is there an update on this issue? I have added an SO question for this issue before stumbling upon this page.
https://stackoverflow.com/questions/45394489/angular2offline-does-not-sync-data-if-ionic-app-is-closed-without-ever-connectin
Thank you for your help and good work

Hi Adrian, any thoughts on the above bug?

Hi @gartorware and @pomifm, I've done a bit of research and I'm able to reproduce the bug with fewer actions:

Visit: https://angularfire2-offline.firebaseapp.com/write-list
Go offline
Refresh while offline
Add "Apples" to list
Refresh (item will be missing)
Go online (item will reappear)

Also, I can see this data inside IndexedDB at step 5:

I'm thinking the issue may be related to the processWrites method. This issue is a bit tricky, but hopefully we're a few steps closer to solving it!

database.ts
potentialListRef was being set to '//groceries' instead of  '/groceries'.
  private addToEmulateQue(cacheItem: CacheItem) { // add matches to que
    // Check if root level reference
    console.log('addToEmulateQue');
    const refItems: string[] = cacheItem.ref.split('/');
    console.log('addToEmulateQue:refItems1>', refItems);
    refItems.pop();
    console.log('addToEmulateQue:refItems2>', refItems);
//    const potentialListRef: string = '/' + refItems.join('/');
    const potentialListRef: string = refItems.join('/'); <=======
    if (potentialListRef !== '/') {
      // Add
      console.log('addToEmulateQue:Add>', potentialListRef);
      if (!(potentialListRef in this.emulateQue)) {
        this.emulateQue[potentialListRef] = [];
      }
      console.log('addToEmulateQue:emulateQue>', this.emulateQue);
      this.emulateQue[potentialListRef].push(cacheItem);
    }
  }

hth
Tim

This should be fixed in version 4.2.2! 🎉 🎉 🎉
You can test it out using the demo
@tja4472 let me know if you still see //groceries showing up with the new version.. I haven't spotted the same issue so far. Thanks! 👍


Implement a propagation module inducing charges using the weighting field

In gitlab by @simonspa on Jul 24, 2017, 16:02
In order to properly simulate radiation damage and time distributions (very detailed), we need a new InductionPropagation module which, instead of "collecting" charge carriers does

[ ] read a weighting field for one pixel in addition to the electric field
[ ] calculate the integral of this field for every time step
[ ] calculate the induced charge on the pixels above and around (configurable)
[ ] outputs a charge-over-time distribution per pixel (probably in the same format as now: charges which timestamps attached)

Then, radiation damage models can be implemented by

[ ] providing a list of traps with their probabilities
[ ] checking after every time step these probabilities and trap charge carriers

This is not meant for v1.0 but as notes for a future project to be tackled after the release.

In gitlab by @simonspa on Jul 25, 2017, 16:16
mentioned in merge request !32


feat: add spark history server api

PR summary

Add api methods for managing spark history server. Add submissionTime and autoTerminationTime fields to Application response models.
BREAKING CHANGE: Type of timestamp fields in Application response models has been changed to Date.
The type of timestamp fields like startTime, endTime in ApplicationGetStateResponse and Application models has been changed from String to Date.
Signed-off-by: Subin Shekhar<EMAIL_ADDRESS>Fixes: <! -- link to issue -->
PR Checklist
Please make sure that your PR fulfills the following requirements:

[x] The commit message follows the Angular Commit Message Guidelines.
[x] Tests for the changes have been added (for bug fixes / features)
[x] Docs have been added / updated (for bug fixes / features)

PR Type

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] New tests
[ ] Build/CI related changes
[ ] Documentation content changes
[ ] Other (please describe)

What is the current behavior?

What is the new behavior?

Does this PR introduce a breaking change?

[x] Yes
[ ] No

The type of timestamp fields like startTime, endTime in ApplicationGetStateResponse and Application models has been changed from String to Date.
Review the code referencing these fields and update as required.
Other information

Unit test:
 % mvn test
[INFO] Scanning for projects...
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Build Order:
[INFO]
[INFO] IBM Cloud Analytics Engine Service API Java SDK                    [pom]
[INFO] IBM Analytics Engine Services Common Library                       [jar]
[INFO] IBM Analytics Engine Service                                       [jar]
[INFO] IBM Analytics Engine Services Coverage Reports                     [jar]
[INFO] IBM Analytics Engine Service Code Examples                         [jar]
[INFO]
[INFO] ------------------------< com.ibm.cloud:iaesdk >------------------------
[INFO] Building IBM Cloud Analytics Engine Service API Java SDK 99-SNAPSHOT [1/5]
[INFO] --------------------------------[ pom ]---------------------------------
[INFO]
[INFO] --- buildnumber-maven-plugin:3.0.0:create (default) @ iaesdk ---
[INFO] ShortRevision tag detected. The value is '8'.
[INFO] Executing: /bin/sh -c cd '/Users/subin/Documents/gitworkspace/ibm-iae-java-sdk' && 'git' 'rev-parse' '--verify' '--short=8' 'HEAD'
[INFO] Working directory: /Users/subin/Documents/gitworkspace/ibm-iae-java-sdk
[INFO] Storing buildNumber: 9201b7da at timestamp: 20230105-150408
[INFO] Storing buildScmBranch: v3-sdk-spark-history
[INFO]
[INFO] --- jacoco-maven-plugin:0.8.8:prepare-agent (prepare-agent) @ iaesdk ---
[INFO] argLine set to -javaagent:/Users/subin/.m2/repository/org/jacoco/org.jacoco.agent/0.8.8/org.jacoco.agent-0.8.8-runtime.jar=destfile=/Users/subin/Documents/gitworkspace/ibm-iae-java-sdk/target/jacoco.exec
[INFO]
[INFO] --- jacoco-maven-plugin:0.8.8:report (report) @ iaesdk ---
[INFO] Skipping JaCoCo execution due to missing execution data file.
[INFO]
[INFO] --- maven-checkstyle-plugin:3.2.0:check (verify-style) @ iaesdk ---
[WARNING] File encoding has not been set, using platform encoding UTF-8, i.e. build is platform dependent!
[INFO] Starting audit...
Audit done.
[INFO] You have 0 Checkstyle violations.
[INFO]
[INFO] --------------------< com.ibm.cloud:iaesdk-common >---------------------
[INFO] Building IBM Analytics Engine Services Common Library 99-SNAPSHOT  [2/5]
[INFO] --------------------------------[ jar ]---------------------------------
[INFO]
[INFO] --- buildnumber-maven-plugin:3.0.0:create (default) @ iaesdk-common ---
[INFO]
[INFO] --- jacoco-maven-plugin:0.8.8:prepare-agent (prepare-agent) @ iaesdk-common ---
[INFO] argLine set to -javaagent:/Users/subin/.m2/repository/org/jacoco/org.jacoco.agent/0.8.8/org.jacoco.agent-0.8.8-runtime.jar=destfile=/Users/subin/Documents/gitworkspace/ibm-iae-java-sdk/modules/common/target/jacoco.exec
[INFO]
[INFO] --- maven-resources-plugin:2.6:resources (default-resources) @ iaesdk-common ---
[WARNING] File encoding has not been set, using platform encoding UTF-8, i.e. build is platform dependent!
[WARNING] Using platform encoding (UTF-8 actually) to copy filtered resources, i.e. build is platform dependent!
[INFO] Copying 1 resource
[INFO]
[INFO] --- maven-compiler-plugin:3.10.1:compile (default-compile) @ iaesdk-common ---
[INFO] Nothing to compile - all classes are up to date
[INFO]
[INFO] --- maven-resources-plugin:2.6:testResources (default-testResources) @ iaesdk-common ---
[WARNING] Using platform encoding (UTF-8 actually) to copy filtered resources, i.e. build is platform dependent!
[INFO] skip non existing resourceDirectory /Users/subin/Documents/gitworkspace/ibm-iae-java-sdk/modules/common/src/test/resources
[INFO]
[INFO] --- maven-compiler-plugin:3.10.1:testCompile (default-testCompile) @ iaesdk-common ---
[INFO] Nothing to compile - all classes are up to date
[INFO]
[INFO] --- maven-surefire-plugin:3.0.0-M7:test (default-test) @ iaesdk-common ---
[INFO] Using auto detected provider org.apache.maven.surefire.testng.TestNGProvider
[INFO]
[INFO] -------------------------------------------------------
[INFO]  T E S T S
[INFO] -------------------------------------------------------
[INFO] Running com.ibm.cloud.iaesdk.test.SdkCommonTest
User-Agent: ibm-iae-java-sdk/99-SNAPSHOT (lang=java; java.vendor=IBM Corporation; java.version=11.0.15; os.arch=x86_64; os.name=Mac OS X; os.version=13.1)
[INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.461 s - in com.ibm.cloud.iaesdk.test.SdkCommonTest
[INFO]
[INFO] Results:
[INFO]
[INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0
[INFO]
[INFO]
[INFO] --- jacoco-maven-plugin:0.8.8:report (report) @ iaesdk-common ---
[INFO] Skipping JaCoCo execution due to missing execution data file.
[INFO]
[INFO] --- maven-checkstyle-plugin:3.2.0:check (verify-style) @ iaesdk-common ---
[WARNING] File encoding has not been set, using platform encoding UTF-8, i.e. build is platform dependent!
[INFO] Starting audit...
Audit done.
[INFO] You have 0 Checkstyle violations.
[INFO]
[INFO] ---------------< com.ibm.cloud:ibm-analytics-engine-api >---------------
[INFO] Building IBM Analytics Engine Service 99-SNAPSHOT                  [3/5]
[INFO] --------------------------------[ jar ]---------------------------------
[INFO]
[INFO] --- buildnumber-maven-plugin:3.0.0:create (default) @ ibm-analytics-engine-api ---
[INFO]
[INFO] --- jacoco-maven-plugin:0.8.8:prepare-agent (prepare-agent) @ ibm-analytics-engine-api ---
[INFO] argLine set to -javaagent:/Users/subin/.m2/repository/org/jacoco/org.jacoco.agent/0.8.8/org.jacoco.agent-0.8.8-runtime.jar=destfile=/Users/subin/Documents/gitworkspace/ibm-iae-java-sdk/modules/ibm-analytics-engine-api/target/jacoco.exec
[INFO]
[INFO] --- maven-resources-plugin:2.6:resources (default-resources) @ ibm-analytics-engine-api ---
[WARNING] Using platform encoding (UTF-8 actually) to copy filtered resources, i.e. build is platform dependent!
[INFO] skip non existing resourceDirectory /Users/subin/Documents/gitworkspace/ibm-iae-java-sdk/modules/ibm-analytics-engine-api/src/main/resources
[INFO]
[INFO] --- maven-compiler-plugin:3.10.1:compile (default-compile) @ ibm-analytics-engine-api ---
[INFO] Nothing to compile - all classes are up to date
[INFO]
[INFO] --- maven-resources-plugin:2.6:testResources (default-testResources) @ ibm-analytics-engine-api ---
[WARNING] Using platform encoding (UTF-8 actually) to copy filtered resources, i.e. build is platform dependent!
[INFO] skip non existing resourceDirectory /Users/subin/Documents/gitworkspace/ibm-iae-java-sdk/modules/ibm-analytics-engine-api/src/test/resources
[INFO]
[INFO] --- maven-compiler-plugin:3.10.1:testCompile (default-testCompile) @ ibm-analytics-engine-api ---
[INFO] Nothing to compile - all classes are up to date
[INFO]
[INFO] --- maven-surefire-plugin:3.0.0-M7:test (default-test) @ ibm-analytics-engine-api ---
[INFO] Using auto detected provider org.apache.maven.surefire.testng.TestNGProvider
[INFO]
[INFO] -------------------------------------------------------
[INFO]  T E S T S
[INFO] -------------------------------------------------------
[INFO] Running TestSuite
[INFO] Tests run: 207, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 3.833 s - in TestSuite
[INFO]
[INFO] Results:
[INFO]
[INFO] Tests run: 207, Failures: 0, Errors: 0, Skipped: 0
[INFO]
[INFO]
[INFO] --- jacoco-maven-plugin:0.8.8:report (report) @ ibm-analytics-engine-api ---
[INFO] Skipping JaCoCo execution due to missing execution data file.
[INFO]
[INFO] --- maven-checkstyle-plugin:3.2.0:check (verify-style) @ ibm-analytics-engine-api ---
[WARNING] File encoding has not been set, using platform encoding UTF-8, i.e. build is platform dependent!
[INFO] Starting audit...
Audit done.
[INFO] You have 0 Checkstyle violations.
[INFO]
[INFO] ---------------< com.ibm.cloud:iaesdk-coverage-reports >----------------
[INFO] Building IBM Analytics Engine Services Coverage Reports 99-SNAPSHOT [4/5]
[INFO] --------------------------------[ jar ]---------------------------------
[INFO]
[INFO] --- buildnumber-maven-plugin:3.0.0:create (default) @ iaesdk-coverage-reports ---
[INFO]
[INFO] --- jacoco-maven-plugin:0.8.8:prepare-agent (prepare-agent) @ iaesdk-coverage-reports ---
[INFO] argLine set to -javaagent:/Users/subin/.m2/repository/org/jacoco/org.jacoco.agent/0.8.8/org.jacoco.agent-0.8.8-runtime.jar=destfile=/Users/subin/Documents/gitworkspace/ibm-iae-java-sdk/modules/coverage-reports/target/jacoco.exec
[INFO]
[INFO] --- maven-resources-plugin:2.6:resources (default-resources) @ iaesdk-coverage-reports ---
[WARNING] Using platform encoding (UTF-8 actually) to copy filtered resources, i.e. build is platform dependent!
[INFO] skip non existing resourceDirectory /Users/subin/Documents/gitworkspace/ibm-iae-java-sdk/modules/coverage-reports/src/main/resources
[INFO]
[INFO] --- maven-compiler-plugin:3.10.1:compile (default-compile) @ iaesdk-coverage-reports ---
[INFO] No sources to compile
[INFO]
[INFO] --- maven-resources-plugin:2.6:testResources (default-testResources) @ iaesdk-coverage-reports ---
[WARNING] Using platform encoding (UTF-8 actually) to copy filtered resources, i.e. build is platform dependent!
[INFO] skip non existing resourceDirectory /Users/subin/Documents/gitworkspace/ibm-iae-java-sdk/modules/coverage-reports/src/test/resources
[INFO]
[INFO] --- maven-compiler-plugin:3.10.1:testCompile (default-testCompile) @ iaesdk-coverage-reports ---
[INFO] No sources to compile
[INFO]
[INFO] --- maven-surefire-plugin:3.0.0-M7:test (default-test) @ iaesdk-coverage-reports ---
[INFO] No tests to run.
[INFO]
[INFO] --- jacoco-maven-plugin:0.8.8:report (report) @ iaesdk-coverage-reports ---
[INFO] Skipping JaCoCo execution due to missing execution data file.
[INFO]
[INFO] --- maven-checkstyle-plugin:3.2.0:check (verify-style) @ iaesdk-coverage-reports ---
[WARNING] File encoding has not been set, using platform encoding UTF-8, i.e. build is platform dependent!
[INFO] Starting audit...
Audit done.
[INFO] You have 0 Checkstyle violations.
[INFO]
[INFO] ----------< com.ibm.cloud:ibm-analytics-engine-api-examples >-----------
[INFO] Building IBM Analytics Engine Service Code Examples 99-SNAPSHOT    [5/5]
[INFO] --------------------------------[ jar ]---------------------------------
[INFO]
[INFO] --- buildnumber-maven-plugin:3.0.0:create (default) @ ibm-analytics-engine-api-examples ---
[INFO]
[INFO] --- jacoco-maven-plugin:0.8.8:prepare-agent (prepare-agent) @ ibm-analytics-engine-api-examples ---
[INFO] argLine set to -javaagent:/Users/subin/.m2/repository/org/jacoco/org.jacoco.agent/0.8.8/org.jacoco.agent-0.8.8-runtime.jar=destfile=/Users/subin/Documents/gitworkspace/ibm-iae-java-sdk/modules/examples/target/jacoco.exec
[INFO]
[INFO] --- maven-resources-plugin:2.6:resources (default-resources) @ ibm-analytics-engine-api-examples ---
[WARNING] Using platform encoding (UTF-8 actually) to copy filtered resources, i.e. build is platform dependent!
[INFO] skip non existing resourceDirectory /Users/subin/Documents/gitworkspace/ibm-iae-java-sdk/modules/examples/src/main/resources
[INFO]
[INFO] --- maven-compiler-plugin:3.10.1:compile (default-compile) @ ibm-analytics-engine-api-examples ---
[INFO] Nothing to compile - all classes are up to date
[INFO]
[INFO] --- maven-resources-plugin:2.6:testResources (default-testResources) @ ibm-analytics-engine-api-examples ---
[WARNING] Using platform encoding (UTF-8 actually) to copy filtered resources, i.e. build is platform dependent!
[INFO] skip non existing resourceDirectory /Users/subin/Documents/gitworkspace/ibm-iae-java-sdk/modules/examples/src/test/resources
[INFO]
[INFO] --- maven-compiler-plugin:3.10.1:testCompile (default-testCompile) @ ibm-analytics-engine-api-examples ---
[INFO] No sources to compile
[INFO]
[INFO] --- maven-surefire-plugin:3.0.0-M7:test (default-test) @ ibm-analytics-engine-api-examples ---
[INFO] No tests to run.
[INFO]
[INFO] --- jacoco-maven-plugin:0.8.8:report (report) @ ibm-analytics-engine-api-examples ---
[INFO] Skipping JaCoCo execution due to missing execution data file.
[INFO]
[INFO] --- maven-checkstyle-plugin:3.2.0:check (verify-style) @ ibm-analytics-engine-api-examples ---
[WARNING] File encoding has not been set, using platform encoding UTF-8, i.e. build is platform dependent!
[INFO] Starting audit...
Audit done.
[INFO] You have 0 Checkstyle violations.
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary for IBM Cloud Analytics Engine Service API Java SDK 99-SNAPSHOT:
[INFO]
[INFO] IBM Cloud Analytics Engine Service API Java SDK .... SUCCESS [  1.740 s]
[INFO] IBM Analytics Engine Services Common Library ....... SUCCESS [  1.892 s]
[INFO] IBM Analytics Engine Service ....................... SUCCESS [  4.998 s]
[INFO] IBM Analytics Engine Services Coverage Reports ..... SUCCESS [  0.143 s]
[INFO] IBM Analytics Engine Service Code Examples ......... SUCCESS [  0.194 s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  9.080 s
[INFO] Finished at: 2023-01-05T15:04:17+05:30
[INFO] ------------------------------------------------------------------------

Integration test:
% mvn test -Dsurefire.failIfNoSpecifiedTests=false -Dtest=IbmAnalyticsEngineApiIT
[INFO] Scanning for projects...
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Build Order:
[INFO]
[INFO] IBM Cloud Analytics Engine Service API Java SDK                    [pom]
[INFO] IBM Analytics Engine Services Common Library                       [jar]
[INFO] IBM Analytics Engine Service                                       [jar]
[INFO] IBM Analytics Engine Services Coverage Reports                     [jar]
[INFO] IBM Analytics Engine Service Code Examples                         [jar]
[INFO]
[INFO] ------------------------< com.ibm.cloud:iaesdk >------------------------
[INFO] Building IBM Cloud Analytics Engine Service API Java SDK 99-SNAPSHOT [1/5]
[INFO] --------------------------------[ pom ]---------------------------------
[INFO]
[INFO] --- buildnumber-maven-plugin:3.0.0:create (default) @ iaesdk ---
[INFO] ShortRevision tag detected. The value is '8'.
[INFO] Executing: /bin/sh -c cd '/Users/subin/Documents/gitworkspace/ibm-iae-java-sdk' && 'git' 'rev-parse' '--verify' '--short=8' 'HEAD'
[INFO] Working directory: /Users/subin/Documents/gitworkspace/ibm-iae-java-sdk
[INFO] Storing buildNumber: 9201b7da at timestamp: 20230105-150457
[INFO] Storing buildScmBranch: v3-sdk-spark-history
[INFO]
[INFO] --- jacoco-maven-plugin:0.8.8:prepare-agent (prepare-agent) @ iaesdk ---
[INFO] argLine set to -javaagent:/Users/subin/.m2/repository/org/jacoco/org.jacoco.agent/0.8.8/org.jacoco.agent-0.8.8-runtime.jar=destfile=/Users/subin/Documents/gitworkspace/ibm-iae-java-sdk/target/jacoco.exec
[INFO]
[INFO] --- jacoco-maven-plugin:0.8.8:report (report) @ iaesdk ---
[INFO] Skipping JaCoCo execution due to missing execution data file.
[INFO]
[INFO] --- maven-checkstyle-plugin:3.2.0:check (verify-style) @ iaesdk ---
[WARNING] File encoding has not been set, using platform encoding UTF-8, i.e. build is platform dependent!
[INFO] Starting audit...
Audit done.
[INFO] You have 0 Checkstyle violations.
[INFO]
[INFO] --------------------< com.ibm.cloud:iaesdk-common >---------------------
[INFO] Building IBM Analytics Engine Services Common Library 99-SNAPSHOT  [2/5]
[INFO] --------------------------------[ jar ]---------------------------------
[INFO]
[INFO] --- buildnumber-maven-plugin:3.0.0:create (default) @ iaesdk-common ---
[INFO]
[INFO] --- jacoco-maven-plugin:0.8.8:prepare-agent (prepare-agent) @ iaesdk-common ---
[INFO] argLine set to -javaagent:/Users/subin/.m2/repository/org/jacoco/org.jacoco.agent/0.8.8/org.jacoco.agent-0.8.8-runtime.jar=destfile=/Users/subin/Documents/gitworkspace/ibm-iae-java-sdk/modules/common/target/jacoco.exec
[INFO]
[INFO] --- maven-resources-plugin:2.6:resources (default-resources) @ iaesdk-common ---
[WARNING] File encoding has not been set, using platform encoding UTF-8, i.e. build is platform dependent!
[WARNING] Using platform encoding (UTF-8 actually) to copy filtered resources, i.e. build is platform dependent!
[INFO] Copying 1 resource
[INFO]
[INFO] --- maven-compiler-plugin:3.10.1:compile (default-compile) @ iaesdk-common ---
[INFO] Nothing to compile - all classes are up to date
[INFO]
[INFO] --- maven-resources-plugin:2.6:testResources (default-testResources) @ iaesdk-common ---
[WARNING] Using platform encoding (UTF-8 actually) to copy filtered resources, i.e. build is platform dependent!
[INFO] skip non existing resourceDirectory /Users/subin/Documents/gitworkspace/ibm-iae-java-sdk/modules/common/src/test/resources
[INFO]
[INFO] --- maven-compiler-plugin:3.10.1:testCompile (default-testCompile) @ iaesdk-common ---
[INFO] Nothing to compile - all classes are up to date
[INFO]
[INFO] --- maven-surefire-plugin:3.0.0-M7:test (default-test) @ iaesdk-common ---
[INFO]
[INFO] --- jacoco-maven-plugin:0.8.8:report (report) @ iaesdk-common ---
[INFO] Skipping JaCoCo execution due to missing execution data file.
[INFO]
[INFO] --- maven-checkstyle-plugin:3.2.0:check (verify-style) @ iaesdk-common ---
[WARNING] File encoding has not been set, using platform encoding UTF-8, i.e. build is platform dependent!
[INFO] Starting audit...
Audit done.
[INFO] You have 0 Checkstyle violations.
[INFO]
[INFO] ---------------< com.ibm.cloud:ibm-analytics-engine-api >---------------
[INFO] Building IBM Analytics Engine Service 99-SNAPSHOT                  [3/5]
[INFO] --------------------------------[ jar ]---------------------------------
[INFO]
[INFO] --- buildnumber-maven-plugin:3.0.0:create (default) @ ibm-analytics-engine-api ---
[INFO]
[INFO] --- jacoco-maven-plugin:0.8.8:prepare-agent (prepare-agent) @ ibm-analytics-engine-api ---
[INFO] argLine set to -javaagent:/Users/subin/.m2/repository/org/jacoco/org.jacoco.agent/0.8.8/org.jacoco.agent-0.8.8-runtime.jar=destfile=/Users/subin/Documents/gitworkspace/ibm-iae-java-sdk/modules/ibm-analytics-engine-api/target/jacoco.exec
[INFO]
[INFO] --- maven-resources-plugin:2.6:resources (default-resources) @ ibm-analytics-engine-api ---
[WARNING] Using platform encoding (UTF-8 actually) to copy filtered resources, i.e. build is platform dependent!
[INFO] skip non existing resourceDirectory /Users/subin/Documents/gitworkspace/ibm-iae-java-sdk/modules/ibm-analytics-engine-api/src/main/resources
[INFO]
[INFO] --- maven-compiler-plugin:3.10.1:compile (default-compile) @ ibm-analytics-engine-api ---
[INFO] Nothing to compile - all classes are up to date
[INFO]
[INFO] --- maven-resources-plugin:2.6:testResources (default-testResources) @ ibm-analytics-engine-api ---
[WARNING] Using platform encoding (UTF-8 actually) to copy filtered resources, i.e. build is platform dependent!
[INFO] skip non existing resourceDirectory /Users/subin/Documents/gitworkspace/ibm-iae-java-sdk/modules/ibm-analytics-engine-api/src/test/resources
[INFO]
[INFO] --- maven-compiler-plugin:3.10.1:testCompile (default-testCompile) @ ibm-analytics-engine-api ---
[INFO] Nothing to compile - all classes are up to date
[INFO]
[INFO] --- maven-surefire-plugin:3.0.0-M7:test (default-test) @ ibm-analytics-engine-api ---
[INFO] Using auto detected provider org.apache.maven.surefire.testng.TestNGProvider
[INFO]
[INFO] -------------------------------------------------------
[INFO]  T E S T S
[INFO] -------------------------------------------------------
[INFO] Running TestSuite
WARNING: An illegal reflective access operation has occurred
WARNING: Illegal reflective access by org.powermock.reflect.internal.WhiteboxImpl (file:/Users/subin/.m2/repository/org/powermock/powermock-reflect/2.0.9/powermock-reflect-2.0.9.jar) to method java.io.File.isInvalid()
WARNING: Please consider reporting this to the maintainers of org.powermock.reflect.internal.WhiteboxImpl
WARNING: Use --illegal-access=warn to enable warnings of further illegal reflective access operations
WARNING: All illegal access operations will be denied in a future release
>>> Configuration file /Users/subin/Documents/gitworkspace/ibm-iae-java-sdk/ibmanalyticsengine-service.env not found, skipping tests.
Setup complete.
Clean up complete.
[WARNING] Tests run: 71, Failures: 0, Errors: 0, Skipped: 49, Time elapsed: 40.667 s - in TestSuite
[INFO]
[INFO] Results:
[INFO]
[WARNING] Tests run: 39, Failures: 0, Errors: 0, Skipped: 17
[INFO]
[INFO]
[INFO] --- jacoco-maven-plugin:0.8.8:report (report) @ ibm-analytics-engine-api ---
[INFO] Skipping JaCoCo execution due to missing execution data file.
[INFO]
[INFO] --- maven-checkstyle-plugin:3.2.0:check (verify-style) @ ibm-analytics-engine-api ---
[WARNING] File encoding has not been set, using platform encoding UTF-8, i.e. build is platform dependent!
[INFO] Starting audit...
Audit done.
[INFO] You have 0 Checkstyle violations.
[INFO]
[INFO] ---------------< com.ibm.cloud:iaesdk-coverage-reports >----------------
[INFO] Building IBM Analytics Engine Services Coverage Reports 99-SNAPSHOT [4/5]
[INFO] --------------------------------[ jar ]---------------------------------
[INFO]
[INFO] --- buildnumber-maven-plugin:3.0.0:create (default) @ iaesdk-coverage-reports ---
[INFO]
[INFO] --- jacoco-maven-plugin:0.8.8:prepare-agent (prepare-agent) @ iaesdk-coverage-reports ---
[INFO] argLine set to -javaagent:/Users/subin/.m2/repository/org/jacoco/org.jacoco.agent/0.8.8/org.jacoco.agent-0.8.8-runtime.jar=destfile=/Users/subin/Documents/gitworkspace/ibm-iae-java-sdk/modules/coverage-reports/target/jacoco.exec
[INFO]
[INFO] --- maven-resources-plugin:2.6:resources (default-resources) @ iaesdk-coverage-reports ---
[WARNING] Using platform encoding (UTF-8 actually) to copy filtered resources, i.e. build is platform dependent!
[INFO] skip non existing resourceDirectory /Users/subin/Documents/gitworkspace/ibm-iae-java-sdk/modules/coverage-reports/src/main/resources
[INFO]
[INFO] --- maven-compiler-plugin:3.10.1:compile (default-compile) @ iaesdk-coverage-reports ---
[INFO] No sources to compile
[INFO]
[INFO] --- maven-resources-plugin:2.6:testResources (default-testResources) @ iaesdk-coverage-reports ---
[WARNING] Using platform encoding (UTF-8 actually) to copy filtered resources, i.e. build is platform dependent!
[INFO] skip non existing resourceDirectory /Users/subin/Documents/gitworkspace/ibm-iae-java-sdk/modules/coverage-reports/src/test/resources
[INFO]
[INFO] --- maven-compiler-plugin:3.10.1:testCompile (default-testCompile) @ iaesdk-coverage-reports ---
[INFO] No sources to compile
[INFO]
[INFO] --- maven-surefire-plugin:3.0.0-M7:test (default-test) @ iaesdk-coverage-reports ---
[INFO] No tests to run.
[INFO]
[INFO] --- jacoco-maven-plugin:0.8.8:report (report) @ iaesdk-coverage-reports ---
[INFO] Skipping JaCoCo execution due to missing execution data file.
[INFO]
[INFO] --- maven-checkstyle-plugin:3.2.0:check (verify-style) @ iaesdk-coverage-reports ---
[WARNING] File encoding has not been set, using platform encoding UTF-8, i.e. build is platform dependent!
[INFO] Starting audit...
Audit done.
[INFO] You have 0 Checkstyle violations.
[INFO]
[INFO] ----------< com.ibm.cloud:ibm-analytics-engine-api-examples >-----------
[INFO] Building IBM Analytics Engine Service Code Examples 99-SNAPSHOT    [5/5]
[INFO] --------------------------------[ jar ]---------------------------------
[INFO]
[INFO] --- buildnumber-maven-plugin:3.0.0:create (default) @ ibm-analytics-engine-api-examples ---
[INFO]
[INFO] --- jacoco-maven-plugin:0.8.8:prepare-agent (prepare-agent) @ ibm-analytics-engine-api-examples ---
[INFO] argLine set to -javaagent:/Users/subin/.m2/repository/org/jacoco/org.jacoco.agent/0.8.8/org.jacoco.agent-0.8.8-runtime.jar=destfile=/Users/subin/Documents/gitworkspace/ibm-iae-java-sdk/modules/examples/target/jacoco.exec
[INFO]
[INFO] --- maven-resources-plugin:2.6:resources (default-resources) @ ibm-analytics-engine-api-examples ---
[WARNING] Using platform encoding (UTF-8 actually) to copy filtered resources, i.e. build is platform dependent!
[INFO] skip non existing resourceDirectory /Users/subin/Documents/gitworkspace/ibm-iae-java-sdk/modules/examples/src/main/resources
[INFO]
[INFO] --- maven-compiler-plugin:3.10.1:compile (default-compile) @ ibm-analytics-engine-api-examples ---
[INFO] Nothing to compile - all classes are up to date
[INFO]
[INFO] --- maven-resources-plugin:2.6:testResources (default-testResources) @ ibm-analytics-engine-api-examples ---
[WARNING] Using platform encoding (UTF-8 actually) to copy filtered resources, i.e. build is platform dependent!
[INFO] skip non existing resourceDirectory /Users/subin/Documents/gitworkspace/ibm-iae-java-sdk/modules/examples/src/test/resources
[INFO]
[INFO] --- maven-compiler-plugin:3.10.1:testCompile (default-testCompile) @ ibm-analytics-engine-api-examples ---
[INFO] No sources to compile
[INFO]
[INFO] --- maven-surefire-plugin:3.0.0-M7:test (default-test) @ ibm-analytics-engine-api-examples ---
[INFO] No tests to run.
[INFO]
[INFO] --- jacoco-maven-plugin:0.8.8:report (report) @ ibm-analytics-engine-api-examples ---
[INFO] Skipping JaCoCo execution due to missing execution data file.
[INFO]
[INFO] --- maven-checkstyle-plugin:3.2.0:check (verify-style) @ ibm-analytics-engine-api-examples ---
[WARNING] File encoding has not been set, using platform encoding UTF-8, i.e. build is platform dependent!
[INFO] Starting audit...
Audit done.
[INFO] You have 0 Checkstyle violations.
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary for IBM Cloud Analytics Engine Service API Java SDK 99-SNAPSHOT:
[INFO]
[INFO] IBM Cloud Analytics Engine Service API Java SDK .... SUCCESS [  1.638 s]
[INFO] IBM Analytics Engine Services Common Library ....... SUCCESS [  0.547 s]
[INFO] IBM Analytics Engine Service ....................... SUCCESS [ 41.588 s]
[INFO] IBM Analytics Engine Services Coverage Reports ..... SUCCESS [  0.218 s]
[INFO] IBM Analytics Engine Service Code Examples ......... SUCCESS [  0.307 s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  44.414 s
[INFO] Finished at: 2023-01-05T15:05:41+05:30
[INFO] ------------------------------------------------------------------------

:tada: This PR is included in version 1.0.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


rename interface to base

Summary
To clarify the role of class, we should rename the class as follows:
InterfaceTimeSeriesMetrics -> BaseTimeSeriesMetrics

This issue will be assigned after all implementations of the interface class are finished.
Goal
Refactor all corresponding codes.
Todo

[x] rename class name
[x] rewrite the code which is using the interface class
[x] check if all unit tests are passed

Deadline
yyyy / mm / dd
Parent issue
If the parent issue exists, post a link here.
References
If there are any reference links, they are described here.
Notes
Other comments.

@ryoherisson LGTM!


Improve docstrings

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (570fd6a) 100.00% compared to head (d1113af) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #143   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files           10        10
  Lines          284       284
  Branches        61        61
=========================================
  Hits           284       284

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


cargo vendor outputs directory with \?\ on Windows if it previously existed

To reproduce

cargo new cargo_vendor_is_broken
cd cargo_vendor_is_broken
cargo vendor
cargo vendor

Expected result
Steps 3 and 4 should produce the same output.
Actual result
>cargo vendor
To use vendored sources, add this to your .cargo/config for this project:

[source.vendored-sources]
directory = "vendor"

>cargo vendor
To use vendored sources, add this to your .cargo/config for this project:

[source.vendored-sources]
directory = "\\\\?\\C:\\temp\\rust_playground\\cargo_vendor_is_broken\\vendor"

Version info
Windows

>cargo version
cargo 1.39.0-nightly (3f700ec43 2019-08-19)

Is there a particular reason why you consider this to be broken? It's true that it's odd that there's two values here, but I think they both work?

Coming from the other issue, a problem is that cargo-vendor would always use the "normal" path style ("C:\\temp\\rust_playground\\cargo_vendor_is_broken\\vendor"), so it's not a drop-in replacement without some work (Python's os.path doesn't like mixing \\?\ with the other kind, ref mach vendor rust fails on Windows).
This issue came up previously in cargo-vendor: https://github.com/alexcrichton/cargo-vendor/pull/71#issuecomment-387314630

This seems to be fixed by #7629.


chore(main): release 1.2.0

:robot: I have created a release beep boop
1.2.0 (2024-03-10)
Features

add .env.template (3b1a0a0)
add DOCKERHUB_REPO configure when run _install.sh, add search test (1f33cac)
add prometheus and grafana support (c9e3f08)
add ssdb support (7eb25ab)
move SSDB's codes to app (ecd2d86)

Docs

make doc better - add DOCKERHUB_REPO concept (d31d8d3)
update daoc (130db40)
update doc (022df2c)
update doc (48ec95c)

Tests

add search test (4783e8d)
add search test (8622f0c)

This PR was generated with Release Please. See documentation.

:robot: Release is at https://github.com/WGrape/sparrow/releases/tag/v1.2.0 :sunflower:


Scope on Wherehas not working

Larastan Version: 2.1.4
--level used:  5
Pull request with failing test: Sorry, I would love to do this, but I don't know how to test it.

Description
Hello,
similar to the error described in https://github.com/nunomaduro/larastan/issues/1216 it seems, that the whereHas function can not handle scopes of the related model. The error message is exactly the same. I tried all the things described in https://github.com/nunomaduro/larastan/issues/1216 but nothing worked out. Did I miss something?
Error message (changed function name to sync with the example):
Call to an undefined method Illuminate\Database\Eloquent\Builder::forTestingFirstFunction().

Laravel code where the issue was found
use Illuminate\Database\Eloquent\Builder;
use Illuminate\Database\Eloquent\Model;
use Illuminate\Database\Eloquent\Relations\HasMany;

class TestClassA extends Model
{
  public function testClassB(): HasMany
  {
    return $this->hasMany(
      TestClassB::class,
      'test_class_b_id'
    );
  }
}

/**
 * @method static Illuminate\Database\Eloquent\Builder|TestClassA forTestingFirstFunction(bool $someParameter = true)
 */
class TestClassB extends Model
{
  public function scopeForTestingFirstFunction(Builder $builder, bool $someParameter = true): Builder
  {
    return $builder->where('some_column', '=', $someParameter);
  }
}

/** This is a service class in my case */
class TestClassC
{
  TestClassA::whereHas('testClassB', function (Builder $query) {
    $query->forTestingFirstFunction(false);
  })
  ->get();
}

Hi,
You found the edge case 😄 Generic builder for whereHas (and some relation related methods)  are not supported because inside the closure the type of $query would be Builder<TestClassB> not Builder<TestClassA> And currently PHPStan does not have any way to support this.
What you can do is maybe overwrite the type inside the closure with /** @var Builder<TestClassB> $query */
If you want to keep track of the process for the issue, you can subscribe to #1110