Add explicit audit criteria definitions to google3-audits.toml.

Fixes https://github.com/google/rust-crate-audits/issues/12.
After this commit google3-audits.toml becomes usable on its own (i.e. this commit allows direct import of google3-audits.toml - such a direct import may be important for projects that are in the sources.list).
The criteria descriptions comes from the following sources:

ub-risk-N: Criteria descriptions have been copied from https://fuchsia-review.git.corp.google.com/c/fuchsia/+/995606
crypto-safe and does-not-implement-crypto: Criteria descriptions have been copied from https://chromium.googlesource.com/chromiumos/third_party/rust_crates/+/refs/heads/main/cargo-vet/audits.toml
ub-risk-N-thorough: Criteria descriptions have been authored from scratch - this is okay, because these criteria are not currently used in other audits.toml files (i.e. are not used by ChromiumOS nor Fuchsia).

@Manishearth, can you PTAL?


Question about networks for cifar100.

What networks are suitable for cifar100 with relatively high testing accuracy?

This issue is closed due to lack of activity in the last 90 days. Feel free to ping me to reopen if this is still an active issue. Thanks!
Also, do please check out our forum (and Chinese version) for general "how-to" questions.


Issues with kibana5.5.1 image

Hi team,
I have pulled kibana 5.5.1 image docker.elastic.co/kibana/kibana:5.5.1.
When i'm strating conatiner locally i'm not getting webui for kibana Dashboard, Please help

This isssue is with kibana 5.5.1 only, latest version is working fine.
But we need to use kibana 5.5.1 only please help

Looking at your output it seems you are not using Elastic's own docker.elastic.co/elasticsearch/elasticsearch:5.5.1 image but rather the one from Docker Hub. Please switch to that one and try again.

With docker.elastic.co/elasticsearch/elasticsearch:5.5.1 now even ES is not starting.. conatiner get started but automatically Exited after few sec:

Hi @rkumr456
Some few questions so that we can help you more efficiently:

Do you have set the vm.max_map_count setting as explained in the official Elastic documentation about Docker configuration
Can you give us the logs for the containers that died:

docker logs <container_id>

The docker events can be useful if there is no relevant information in the logs

run the docker events command in a separate terminal
execute the docker command: docker run  --name ES -P -d  docker.elastic.co/elasticsearch/elasticsearch:5.5.1
then if this container has died, the docker events command should give you more information about what is going on

Please find docker logs for container that died

Do you have set the vm.max_map_count setting as explained in the official Elastic documentation about Docker configuration

Looking at the latest lines of your log, it seems that the answer is in the link above ;)

i tried to run ES container in Development mode using below command
docker run -p 9200:9200 -p 9300:9300 -e "discovery.type=single-node" docker.elastic.co/elasticsearch/elasticsearch:5.5.1
Container running fine now , but when i'm trying to open webui it is asking for username & password , so what will be user id & password is there some default user id & password i need to pass?

@mgreau Elastic Search is up now working.
Now i want to run kibana & connect to this elastic search , i have already pulled kibana image
and trying to run but form me kibana Dashboard webui is not coming. Below command i'm using:

@mgreau Elastic Search is up now working.

good news.

kibana Dashboard webui is not coming

What do you mean? Did you try to access to http://<your-ip>:5601 in a browser? (then connect with elastic or kibana users with changeme as default password)

Yes i tried with https://<IP_ADDRESS>:5601 but Dashboard is not opening.
I'll paste kibana container logs fyi:

Can you execute the following command please to see the ELASTICSEARCH_URL value:

docker inspect --format='{{.Config.Env}}' kibana-dev

@mgreau It worked Now i was passing http instead of http:. Thankyou!!

@rkumr456 If you don't specify a user defined network the containers use the default bridge network.
With the default bridge network you can't use the container name as an network alias, so you'll need to docker inspect bridge to see what's the IP address for the elasticsearch container and use that for your ELASTICSEARCH_URL.
This would be done like so:
$ docker run -d --name es1 -p 9200:9200 -p 9300:9300 -e "discovery.type=single-node" docker.elastic.co/elasticsearch/elasticsearch:5.6.2
8525c36c47c6350395a900eb399d2ab9aeaf300ebe9ee8be835b605eb793ba4e

$ docker inspect bridge | grep -A5 es1
                "Name": "es1",
                "EndpointID": "9c960d5b9b36d2f4a9451e51d8173cc488febb9030d1c0de46cc0069099d5832",
                "MacAddress": "02:42:ac:11:00:02",
                "IPv4Address": "<IP_ADDRESS>/16",
                "IPv6Address": ""
            }

$ docker run --rm --name kibana1 -p 5601:5601 -e "ELASTICSEARCH_URL=http://<IP_ADDRESS>" docker.elastic.co/kibana/kibana:5.6.2

$ curl -u elastic:changeme localhost:5601
<script>var hashRoute = '/app/kibana';
var defaultRoute = '/app/kibana';

var hash = window.location.hash;
if (hash.length) {
  window.location = hashRoute + hash;
} else {
  window.location = defaultRoute;

All this becomes much easier with user defined networks, e.g. consider the following docker-compose.
As kibana, by default, is looking for http://elasticsearch:5601, here by naming our service as "elasticsearch" the Docker defined network elasticnet will automatically create an IP alias with the name elasticsearch, which kibana will use to connect to.
version: '2.2'
services:
  elasticsearch:
    image: docker.elastic.co/elasticsearch/elasticsearch:5.6.2
    environment:
      - discovery.type=single-node
    ports:
      - 9200:9200
    networks:
      - elasticnet
  kibana:
    image: docker.elastic.co/kibana/kibana:5.6.2
    ports:
      - 5601:5601
    networks:
      - elasticnet

networks:
  elasticnet:

$ docker-compose up -d

$ curl -iu elastic:changeme localhost:5601
HTTP/1.1 200 OK
kbn-name: kibana
kbn-version: 5.6.2
kbn-xpack-sig: 2f97a446bb70fc8ba712f2360fa59b88
cache-control: no-cache
content-type: text/html; charset=utf-8
content-length: 217
accept-ranges: bytes
Date: Thu, 05 Oct 2017 11:17:36 GMT
Connection: keep-alive

<script>var hashRoute = '/app/kibana';
var defaultRoute = '/app/kibana';

var hash = window.location.hash;
if (hash.length) {
  window.location = hashRoute + hash;
} else {
  window.location = defaultRoute;

Note that in all the above cases there's no volume defined for the elasticsearch data, so killing the container will wipe away your storage. Please refer to the elasticsearch docker documentation. You can also find some full stack examples in this repo.

@dliappis @mgreau
Thanks for this information.
I have another question while running the kibana container above we are always passing ELASTICSEARCH_URL in command Line.
What if i want to pass kibana.yml  config file & pem certificates to this kibana 5.5.1 image how i can do this??
Kibana.yml contains ES Url, Username, Password, SSL CA.
One of way i'm trying to do is Creating Below Dockerfile.
FROM docker.elastic.co/kibana/kibana:5.5.1
COPY all_w3-969cert.pem /usr/share/kibana/config/
ADD kibana.yml /usr/share/kibana/config/
From my understanding this docker file will create kibana image with SSL_CA certificates & kibana.yml already in it. So when i run this container there is no need to pass ES Url as argument in cmd becasue all config info is present in kibana.yml
I have done all these steps and ran kibana5.5.1 using below command.
docker run --name kibana-dev -p 5601:5601  -d  kibanacustom ( Here i didn't pass ES URL)
kibanacustom : It is image created by above docker file:
Screen Shot 1 Running Conatiner:

Screen Shot2 : Conatiner Logs; From here it seems kibana image is running Successfully.

But i'm not able to see kibanaDashboard on localhost:5601 i tried <IP_ADDRESS>:5601(Adress of my VM)
I checked for ip with below command but here instead of ip i can see path. Some thing is wrong here. Can you please help here

Creating a custom image is fine, there's nothing wrong with that. It's likely that your configuration is not correct, however. You didn't paste your kibana.yml, so it's difficult to tell, but I suspect that you may be missing this line, which binds the listening socket to all interfaces/addresses. Without that line, Kibana will only respond to requests on the loopback interface, which in this case means that it will only accept requests that originate from inside the container.
Next, a few requests. Please:

Don't paste images of terminals. Text is easier to read, is searchable, and can be used to replicate things for testing. Please just paste the text from your terminal, surrounded by "triple-backticks". Like these -> ```
Use discuss.elastic.co for this kind of configuration advice. The GitHub issues system is for tracking and fixing bugs that affect the whole community. Nothing that's happening here is a bug.

Thanks for looking into this & your Guidance : I have already posted this thing in community but didn't get any feedback so i posted it here.
In my kibana.yml i have added below properties only:
Elastic_Url
UserName
Password
SSl_CA path
The missing line which u pointed is not there in ny kibana.yml.
So what value i should keep for server.host=0 or My VM address (<IP_ADDRESS>) Here is my kibana.yml
kibana.txt

Why not experiment?

Worked with 0.  Thankyou so much!!


Rangy initialization fails when loaded in iframe on firefox

Load latest rangy core and runs into a issue on firefox
Same error as explained in issue #138.

Ignore that commit. I got the issue number wrong.

The question is what to do about it. Rangy can't initialize if it can't get hold of a selection, so I think it is correct to fail. I've improved the error handling so that it fails with a more informative message.
If you need to load Rangy in an iframe which is initially hidden and later displayed, I suggest setting rangy.config.autoInitialize = false; and initializing Rangy manually when you display the iframe with rangy.init().

Actually I wasn't loading Rangy in an iframe. Any way the suggestion might be helpful. Will try this option and update you.
Thanks once again for the help.

OK. Can you let me know how to replicate the error? Rangy loads without error for me in a regular page in Firefox.


Document Shortcut for Detect Merge Conflicts in Menu Entry

Most plugins show keyboard shortcuts in the menu Packages->Plugin Name->Feature Name + Corresponding Shortcut.
What it be possible to add this to Packages->Merge Conflicts->Detect Alt+m d?

:wave: Thanks for taking the time to file an issue here! Unfortunately, this repository is being deprecated, so I won't be getting to this one here.
I don't think this one applies to the new git and GitHub package for Atom. If you see something similar, please file an issue there to let us know. Thanks 🙇


Unable to break end portals

My issue is that I am unable to break end portals I tried water but that only removed the blocking placement thing pls help.

I also lag most of the times I go in a nether portal

Use /portal delete_portal to remove the end portal

About the lag, are you using other mods?

About the lag, are you using other mods?

no I am not
Im just using the mod and now every 1-2 seconds i get 0 fps
these are my specs https://prnt.sc/100yle6 https://prnt.sc/100ylpi

I usually get 300 something fps

About the lag, are you using other mods?

no I am not
Im just using the mod and now every 1-2 seconds i get 0 fps
these are my specs https://prnt.sc/100yle6 https://prnt.sc/100ylpi

this is fixed now but the nether portal lag is still there

and this usually happens https://prnt.sc/100ywnr

random question no relation to the problem you made this??? https://prnt.sc/100z0xk
that's epic

It's very weird that it lags. To debug this, I need you to 1. only install IP and uninstall other mods 2. Enter game, press shift+F3  3. experience lag  4. post the log (logs/latest.log)

latest.log

here this is maybe better
latest.log

It mainly lags in root.gameRenderer.level.render_portal_total.render_portal_content.terrain which contains the solid block rendering,
IP cross portal entity rendering and IP render list prune.
The performance is affected by many factors. Does it lag after playing the game for 5 minutes? Does it lag with my sodium fork?

im a bit confused but sure i will try the 5 min thing and your fork. any tips on uninstalling normal fabric?

also sorry for the late responses i think we are on completely different timezones...

Why do you want to uninstall faric


Unable to render child elements inside my component

Hi, I'm having a hell of a time trying to get the content of my custom component in the HTML side to render in the component. I've broken it down to a very small example, and it's still not working. There don't appear to be any logs in the JS side, so I want to check I'm using this properly.
import { define } from 'preactement';
import PropTypes from 'prop-types';

export default function CFPost({ title, children }) {
	return <>

{ title }

		        {children}

	</>;
}

CFPost.tagName = 'cf-post';
CFPost.propTypes = {
	title: PropTypes.string.isRequired,
}
CFPost.attributes = ['title'];

define(CFPost.tagName, () => CFPost, { attributes: CFPost.attributes });

  <cf-post
  title="Guests of Honour"
  datetime="2018-09-15T15:56:00+00:00"
  posttype="page">

 Hello there

  </cf-post>

I'd expect an output of:

Guests of Honour

 Hello there

but the
 is missing entirely. Is there something obvious I need to do to enable child element rendering? I did also try with named slots with no success.

Hey @Half-Shot,
Thanks for reaching out. Sorry to hear your having some issues.
I can't see anything super obvious in your code snippets, at least nothing that jumps out at me as being wrong.
You can find a simple example usage of children and slots below, which is working correctly:
https://github.com/jahilldev/preactement-htmlslots
Ideally, if you could provide a minimal repo illustrating the issue, I can more easily diagnose the issue and run it myself.
Sorry I can't be of more help at this time, let me know when you've got a runnable repro 👍
All the best

Hiya, yeah I trawled the examples for a few hours but it wasn't working out for me. I'll try to run that example locally and see if it works, and then, hopefully something will become obvious. Will give you a shout when I figure it out!
(And yep, using preact)

Sounds good, if you need any pointers or further help, let me know 👍

Example worked locally, but copying the exact same component and HTML into my project yielded the same bug: I'm now wondering if there is something wrong with how we're using webpack that's omitting a dependency...silently and causing the DOM not to be rendered.

Right, figured it out and oh my god I am both relieved and annoyed:
Having set up debug statements all over preactement and testing, I found that define.ts#onConnected was being called twice on my component. Huh, weird. As it turns out, it was being called twice. Once with __mounted = false, with NO innerHTML content, and once with __mounted = true, with the expected innerHTML content. Obviously by the point of it being mounted, it wasn't interested in the inner contents so the result would be missing contents.
We have a plugin on our site called mmenu. It's a bit legacy and we're on the way to replacing it (moving to a more preact world). I noticed that in our lifecycle, the custom element would render once, then mmeenu would run a bunch of triggers on init that would call it's setPage function which seemingly moves the DOM around a lot.
Anyway, I found that by disabling mmenu, the code now works. What a frustrating yet enlightening journey. I hope this makes some sort of sense to whoever reads this, as my brain is fried :)

Spoke way too soon, it's now rendering the HTML yes, but it's ignoring named slots or children and just appending it to the end of the element.

The answer was to run the define after DOMContentLoaded has fired, otherwise the browser may not have loaded the HTML content yet.

Hey @Half-Shot, glad to hear you've got it working 👍
It sounds like the issue you were having was caused by your app code's execution order, which is always tricky to debug, especially within a legacy codebase.
Either way, great to hear it's all working.
Feel free to reach out if you run into any more issues 👍


How can I generate a pcd map without pose point on it?

Hello! thanks for you wonderful algorithms . I have saved a pcd map successfully. since I want to generate a Occupancy grid map through this pcd . so I want to remove pose(trajectory points) from the pcd.
for example, as the picture following:

thanks for your answering!

@koide3

Maybe these are points of your robot.


Impossible to use ng-inspector with ui-calendar

Hello,
When i try to use ng-inspector, it opens with the following error:
 ng-inspector.js:1093
NGI.ModelMixin.ModelMixin.update ng-inspector.js:1093
Model.setValue ng-inspector.js:1323
Model ng-inspector.js:1357
NGI.Model.Model.instance ng-inspector.js:1364
NGI.ModelMixin.ModelMixin.update ng-inspector.js:1112
Model.setValue ng-inspector.js:1323
Model ng-inspector.js:1357
NGI.Model.Model.instance ng-inspector.js:1364
NGI.ModelMixin.ModelMixin.update ng-inspector.js:1112
Model.setValue ng-inspector.js:1323
Model ng-inspector.js:1357
NGI.Model.Model.instance ng-inspector.js:1364
NGI.ModelMixin.ModelMixin.update ng-inspector.js:1112
Model.setValue ng-inspector.js:1323
Model ng-inspector.js:1357
NGI.Model.Model.instance ng-inspector.js:1364
NGI.ModelMixin.ModelMixin.update ng-inspector.js:1112
Model.setValue ng-inspector.js:1323
Model ng-inspector.js:1357
NGI.Model.Model.instance ng-inspector.js:1364
NGI.ModelMixin.ModelMixin.update ng-inspector.js:1112
Model.setValue ng-inspector.js:1323
Model ng-inspector.js:1357
NGI.Model.Model.instance ng-inspector.js:1364
NGI.ModelMixin.ModelMixin.update ng-inspector.js:1112
Model.setValue ng-inspector.js:1323
Model ng-inspector.js:1357
NGI.Model.Model.instance ng-inspector.js:1364
NGI.ModelMixin.ModelMixin.update ng-inspector.js:1112
Model.setValue ng-inspector.js:1323
Model ng-inspector.js:1357
NGI.Model.Model.instance ng-inspector.js:1364
NGI.ModelMixin.ModelMixin.update ng-inspector.js:1112
Model.setValue ng-inspector.js:1323
Model ng-inspector.js:1357
NGI.Model.Model.instance ng-inspector.js:1364
NGI.ModelMixin.ModelMixin.update ng-inspector.js:1112
Model.setValue ng-inspector.js:1323
Model ng-inspector.js:1357
NGI.Model.Model.instance ng-inspector.js:1364
NGI.ModelMixin.ModelMixin.update ng-inspector.js:1112
Model.setValue ng-inspector.js:1323
Model ng-inspector.js:1357
To my knowledge, this is barely impossible to troubleshoot.
All i found on google is the angular-google-maps directive has the same issue (https://github.com/allenhwkim/angularjs-google-maps/issues/63)
If anyone has any idea, i am all ears,
Mehdi-Loup

This issue was related to ng-inspector's inability to handle circular references, not an issue with ui-calendar. The latest version of ng-inspector works correctly with the example at http://angular-ui.github.io/ui-calendar/

thanks @rev087


Fixed and improved Keyboard behaviour in SaveCustomRpc series.

Closes #3475
Testing
Pre-test
On the main screen, tap the "Settings" tab option followed by the "Select Active Networks" option.
delete "Expanse Network" if it exists.
Testing

Tap the add button in the upper right corner.
Expects Add Custom RPC screen to appear with Network name field as first responder and an alphabetical keyboard at the bottom. The enter key should read "next". There should be a "<" and ">" button on top of the keyboard.
Enter "expanse network" and tap the ">" button.
Expects RPC URL field to be first responder. A url keyboard should appear.  The enter key should read "next". There should be  "<", ">", "https://" buttons on top of the keyboard.
Enter "node.expanse.tech" and tap the "https://" button.
Expects RPC URL field to display "https://node.expanse.tech".
Tap the "https://" button again.
Expects no change.
Tap the ">" button.
Expects Channel ID field to be first responder. A decimal pad keyboard should appear. There should be "<", ">" buttons on top of the keyboard.
Enter "2" and tap ">".
Expects Symbol field to be first responder. An alphabetical keyboard should appear.  The enter key should read "next". There should be "<", ">" buttons on top of the keyboard.
Enter "exp" and tap ">".
Expects Block Explorer URL field as first responder. A url keyboard should appear.  The enter key should read "done". There should be "<", ">", "https://" buttons on top of the keyboard.
Enter "https://expanse.tech" and tap "https://".
Expects the block explorer url field not to change.
tap "<".
Expects Symbol field to be first responder.
tap "<".
Expects Chain ID field to be first responder.
tap "<".
Expects RPC URL field to be first responder.
tap "<".
Expects Network Name field to be first responder.
tap "<".
Expects Block Explorer URL field to be first responder.
tap ">".
Expects Network Name field to be first responder.
Delete the text of the Network Name field.
Scroll the screen down until you see the big green button.
Tap the big green button.
Expects Network Name field to be first responder and error status showing the error in the text field.
Enter "expanse network" in Network Name field and tap ">".
Expects RPC URL field to be first responder.
Tap ">".
Expects Chain ID to be first responder.
Delete the text of Chain ID field.
Tap ">".
Expects Symbol field to be first responder.
Scroll down and tap the big green button.
Expects Chain ID field to be first responder and error status showing the error in the text field.

Side note:
When all the fields are valid but the rpc url does not point to a valid location, the app gives a long error which is cryptic to normal people.

When all the fields are valid but the rpc url does not point to a valid location, the app gives a long error which is cryptic to normal people.

Can you create a followup PR for this? We should already have an error message for this already to highlight it in the screen in red. Maybe it's somehow not used?


Rename and replace subfolders for consistency and comprehensibility

The hierarchical organization of various subfolders in the project follows a certain logic: module type --> dlt type --> language. Several subfolders that were imported from different repositories earlier retain unnecessary prefixes or suffixes. We need to rename several folders and also move a few of them to different levels for consistency. Once renamed, we need to:

Update scripts throughout the repository and run all the tests (manual and Github workflows) to verify correctness
Update all documentation (folder references as well as URLs) in the project README, OVERVIEW, RFCs, and tutorial docs.

The following is the rename list:

sdks/corda -> sdks/corda/java-kt
sdks/fabric/go-sdk -> sdks/fabric/go
sdks/fabric/interoperation-node-sdk -> sdks/fabric/node
samples/fabric/fabric-cli -> samples/fabric/node-cli
samples/corda/corda-simple-application -> samples/corda/simple-app
samples/besu/besu-cli -> samples/besu/node-cli
core/drivers/corda-driver -> core/drivers/corda
core/drivers/fabric-driver -> core/drivers/fabric
core/network -> core/interoperation-modules
core/network/corda-interop-app -> core/interoperation-modules/corda
core/network/fabric-interop-cc -> core/interoperation-modules/fabric
core/network/fabric-interop-cc/contracts/interop -> core/network/fabric-interop-cc/contract
common/protos -> common/protos/types
common/protos-go -> common/protos/go
common/protos-java-kt -> common/protos/java-kt
common/protos-js -> common/protos/node

We can do the renaming in stages too, in multiple PRs, each time noting on this thread the tasks that are remaining.


Install-Module -Name AzureRm.BootStrapper ???

hasn't AzureRM bootstrapper been retired?  With the update schedule of 3  versions behind I believe I followed a guide that told me to delete all my AzureRM cmdlets and this SQL RP is still to be installed with AzureRM?

@lucidqdreams thanks for reaching out and closing out the issue. If we can assist further just let us know.


asm.cond doesn't evaluate expressions

cond function description says "All arguments must be array of two elements. The first element must evaluate to a boolean", but it doesn't evaluate provided expression. We can take a line from cond_test:
..
[set $.asm.a [cond [true abc]]]
..

and replace it with
..
[set $.asm.a [cond [[not false] abc]]]
..

test will fail because not expression will not be evaluated (can be checked in debbuger)

"local variable" workaround can be used. Instead of
...
[set $.asm.a
   [cond
      [long_logical_expression value_on_true]
   ]
]

the following plan can be used:
[set $.local.check long_logical_expression]
[set $.asm.a
   [cond
      ['$.local.check' value_on_true]
   ]
]

I'll update the tests and get it fixed. Travelling now so it might take a few days.

Please try the "cold-eval" branch. It needs a few more tests but seems to work so far.

It works now. Thanks a lot.

Released v1.19.3 with the fix.


[User Bug] qMRLab fails to load GUI for user

@ravenep encountered this bug when trying to load qMRLab (master – downloaded via the 'Clone or download' button)

She says that she does not receive this error if she downloads Release # 2.1.0, which is 20 commits behind.
Operating system:
NAME="CentOS Linux”
VERSION="7 (Core)”
ID="centos”
ID_LIKE="rhel fedora”
VERSION_ID="7" PRETTY_NAME="CentOS Linux 7 (Core)"
MATLAB version (to be updated soon I hope) - 2015a

I'm able to open the qMRLab GUI with no issue on:

OSX Sierra 10.12.6 & MATLAB 2017a
OSX El Capitan 10.11.6 & MATLAB 2015b

@ravenep I'm going to try and create a VirtualBox with your specific OS and try to install MATLAB on it to see if I can reproduce your issue.
@tanguyduval you played around with this file for the recent GUI-fixes PR (see here for file history), do you have any insight on why Erika might be encountering this issue on this line on master? @gab-berest too?

I'll try to recreate the error later tonight. However, I don't understand when does it happen. When you try to run the main GUI?

I just tried to reproduce the error on Windows and it doesn't appear to be a problem. Is there something that is done when booting up the program or is it just by trying to run it?

@mathieuboudreau I think I've found the problem. When using the fields(i) in Matlab earlier versions, it returns a cell array of character instead of a character array and the strfind cannot take this argument. Before changing anything, I would like a a feedback. Changing the line to 133 in iqmr_header.header_parse to:
finds = strfind(lower(line),lower(char(fields(i))));
To change the cell array to a character array. It works on my end, but I'm not sure that it's the problem and I cannot reproduce it. Can you confirm what I'm saying?

Thanks for looking into this @gab-berest !
This isn't a problem I experienced myself; it's one that Erika emailed me about experiencing on her end. I'll paste the email exchange I had with her below.
I haven't reproduced the error myself yet; I created a VirtualBox image of CentOS 7 and am installing Matlab 2015a at the moment (slowly...) to test it using her setup. I'll let you know if I'm able to reproduce it and/or solve it with your info.
Hi Mathieu,

I stepped away from the MT analysis for awhile, but came back to it this weekend and immediately got an error… It could be something simple, but I just wanted to ask if you’ve seen a similar error (pic below). I am using qMRLab-2.1.0 and the qmt_spgr module. I was able to run the fitting before, but unfortunately lost my previous software download and had to replace. The newest GitHub version did not open for me, so I have this one.

As FYI, I had a data set with a singleton dimension for the slice (x,y,z,mtvol), and tried it with and without this. Still got the same error.

Cheers,
-e

Hi Erika,

I haven't seen this error before – do you mind posting this in a GitHub issue?

> The newest GitHub version did not open for me, so I have this one.

Could you clarify on this latter point? You downloaded the latest GitHub version and the GUI didn't open?

Best,

Mathieu

Hi Mathieu,

RE: the latest version - I downloaded the ZIP via ‘clone or download’ button on the main page. Added the qMRLab-master to path w/ subfolders. Typed ‘qMRLab’ in Matlab command window to load GUI. Then got the error below. This did not happen with 2.1.0 so have been using that (but with other issue)

Thanks Erika! I just tried opening the qMRLab GUI by downloading via the 'clone or download' button myself, but did not encounter that error.

Would you mind sharing your operating system information (name & version) as well as your MATLAB version?

Best,

Mathieu

Hi Mathieu,

Operating system:

NAME="CentOS Linux”
VERSION="7 (Core)”
ID="centos”
ID_LIKE="rhel fedora”
VERSION_ID="7" PRETTY_NAME="CentOS Linux 7 (Core)"

MATLAB version (to be updated soon I hope) - 2015a

-e

No problem. When you have tested it you can update me so I'll make the changes if it is this issue.

@mathieuboudreau cool pick out, I was not expecting that! qMRLab is lucky to have someone who has nerves to test it across platforms and MATLAB versions: Mathieu CI :)

@agahkarakuzu ahahaha. I'm just lucky that McGill's MATLAB license allowed me to download any previous version that I wanted/needed ;)
So odd though that 2015b (which was on my old MacBook, that I tested this morning) was that one version that changed the strfind() functionality lol.
@gab-berest great fix suggestion! Wrapping the second argument of strfind() did the trick. This function is called in several other locations in the file, but repeating the fix everywhere in that file allowed me to finally open the GUI on CentOS Linux 7 and MATLAB 2015a. I'll commit those changes, but test fitting few of the demo data and maybe simulations before making the pull request.

Working on branch: bug_matlab2015a

@mathieuboudreau Because my version is.. wait for it.. R2015b 😀 I remember dealing with many string vs cell issues those makes no sense by definition but affects the functionality. Is this what you mean by

Wrapping the second argument of strfind() did the trick.

You wrapped thisJoker with curly braces to make it a cell, but this in fact breaks for version <2015b (see all the way on top here for example of error message).

Interestingly, I've never run into an error because of this on my local. If it is truly trivial irrespective of the OS/MATLAB version combinations, then they were my scare curly braces (unnecessary placed in that case) because of the issues I was dealing with the proper string replacement in absence of 'contains' function.  In addition, I was trying to give robustness against the casting heterogeneity in the MRIinputs attribute, which sometimes was a string. Which is why I added:

MRIinputs is a 1xN cell array for N input files.

And I remember that at I was getting different empty cell definitions caused by a variable's being casted as char. Although it was not giving me a runtime error, it was hampering the output.

Ahh I see, that makes sense!
A+

Hi everyone, I downloaded the most recent qMRLab and the GUI works! Thanks @mathieuboudreau @agahkarakuzu @gab-berest et al for working on this issue. I can't imagine how you deal with all these combinations of platforms.
Happy user here!

Another update -  using the new version (that was made compatible with 2015a) has bypassed the other issue where the fitting output was not being saved.
I am now even more happy. Thanks all

Excellent! This bug fix was a 2-for-1 deal, I'm happy it's working for you!


Don't crash if a secondary attribute can't be stored, but log the error

We can still authenticate the user if we have at least the username in his record.  If there is an error filling the extra fields, we want to keep going, but log the error so the admin can do something about this user's extra fields.

Great, thank you!


feat(volume) Change the prompt text of the delete operation according…

image: wangsiye/longhorn-ui:bd573fe
https://github.com/longhorn/longhorn/issues/520
Signed-off-by: Siye Wang<EMAIL_ADDRESS>

https://github.com/longhorn/longhorn/issues/1447

@ttpcodes can you file a separate issue regarding the review comment that hasn't been addressed? I want to include the functionality in v1.0.1-rc1 first.

I've filed longhorn/longhorn#1561 with the unaddressed review comment.

Thanks @ttpcodes


Fix general mobile & search issues

Display a short version of the app name in the Navbar - To be replaced with a new logo.
Move tables border to the outside while keeping tables horizontally scrollable for small screens.
Instruct reactivity for search & fix mutable behavior of sorting masjids.

Awesome, thanks a lot!


Add k3s import to ontag job

Include k3s cluster import automation in ontag job

Both CentOS and Ubuntu

PR: https://github.com/rancher/rancher/pull/25283


A quick glance review

Hey, Darren mentioned you were interested in getting some extra eyes on this project. I did a quick glance over and found a couple of things that might be worth changing, but it's nothing major. if you feel like you might benefit from a more in-depth look i'm happy to spend a bit more time on it.

You've got a few instances of repeating the type you use for HashMap<String, JsonSchema>. This is probably a good candidate for a type alias to keep your function signatures a bit cleaner.
Defining it like this will help you avoid some of the guff in your functions:

type SchemaMap = HashMap<String, JSONSchema>;

You've got a lot of qualified imports inline. This might be a stylistic choice so fair play if that's the case. But if you throw things like jsonschema::ValidationError and jsonschema::ErrorIterator into the use at the top, you might find things a little cleaner.
You've also got a few redundant imports. You can remove use log; and use serde_json;

As far as I can reasonably tell, dereferencing and then borrowing self in the display impl for LoadError is unecessary. Changing match &*self to match self seems to work just fine.

The parameter types for load_schemas feels a bit off to me. You use the trait and associated type for an input iterator when you can just use Vec<String>, especially as that's the only type that's actually provided to the function. You don't need to specify that trait bound as the compiler knows that a Vec implements IntoIterator.

fn load_schemas<'a>(paths: impl IntoIterator<Item = String>)

fn load_schemas<'a>(paths: Vec<String>)

On the topic of load_schemas, you've defined it as returning Result<HashMap<String, JSONSchema>, LoadError<'a>> which probably isn't necessary given that it always returns Ok(SchemaMap). This might be because you havent implemented any error handling on it yet, or it might just be an oversight. But if this always returns a hashmap, whether it's full or not, with no error handling other than logging, then you can just change this.  You can then avoid checks to expect this value later down the line.

fn load_schemas<'a>(paths: Vec<String>) -> SchemaMap

Also, you don't need a lifetime specifier in load_schemas. So it can be even further simplified:

fn load_schemas(paths: Vec<String>) -> SchemaMap {

Also, this is bikeshed as fuck, but apparently the linter doesn't like variant names including the enum name itself. I guess this applies to LoadError having ReadError, ParseError, CompileError. It could be considered cleaner to just use the following, but that's super nitpicky 🤷

enum LoadError<'a> {
    Read(&'a str, std::io::Error),
    Parse(&'a str, serde_json::Error),
    Compile(&'a str, std::string::String),
}

Good feedback, thanks! 🙇 ❤
Some of the stuff you mentioned was indeed wip, but the majority of your comments were super helpful! Thanks man, I owe you a beverage of your choice. 🍺


Restrict only images to be uploaded instead of all file types using multer and multer-cloudinary-storage

Driwwwle has a feature of adding images to each post. Currently, the user can upload any type of file but I want only the image file types to be accepted. The relevant backend code is present in this file. I am using multer and multer-storage-cloudinary packages for image upload purposes.
Backend route for creating a new post including the image: Here
Frontend React component for new post: Here

Hi Nitin,
Please assign this issue to me.
Thanks, Anat


Adding kubescape Discord to DevOps/Communities folder

Which field of community (DevOps/Opensource/Web/Web3/Android/Devrel) you want to add, drop the links?
DevOps community
kubescape Discord link here: https://discord.com/invite/WKZRaCtBxN
For adding Job Posting, add links here.
No response
For adding OpenSource Projects, add links here.
No response

Hey @kaiwalyakoparkar ,
Can you assign it to me? :)

Hey @Omkar0114, feel free to make a PR for this, and link this issue as well 😄

Yep


'r2dbc-postgresql' Test Dependency Scope

I just noticed that a 'r2dbc-postgresql' dependency was added to the pom recently for a test example, but the scope wasn't set to test like with the other related dependencies. It seems like that wasn't intentional.

Great catch @jawaff! (not sure how I missed that)


Adding time-invariant covariates

Hey! Continuing this project is a great idea. I think a nice addition is to work on merging the open PR for time-invariant covariates https://github.com/CamDavidsonPilon/lifetimes/pull/342 by @meremeev It seems the core and tests are already there.

Hey @juanitorduz ,
I do hope you can join the Zoom kickoff call for this project next Sunday. Information to join is in a Discussion post in this repo as well as here:
https://github.com/CamDavidsonPilon/lifetimes/issues/414#issuecomment-1073247582
I've sent a collaboration invite to @meremeev. Before merging the PR I would prefer to bring the syntax up-to-date and add type hinting per Python PEP 484 standards. Fortunately this can be mostly automated with a MonkeyType pre-commit line.
I do agree merging this PR ASAP for the next package release is a good idea, but thinking more long-term, I'm inclined to deprecate all MLE implementations for model fitting and make this library exclusive to MCMC or ADVI estimations. Why? MLE calculations are currently done with the autograd library, which was deprecated several years ago. Most of the development team moved over to the JAX project, which is a Just-In-Time (JIT) autodifferentiation library and should be considerably more performant. However, it is still in beta and until a 1.x.x version is released, it will experience glitches and other unstable behavior.
Also, the way MLE works is that it estimates the mode (ie, peak of the PDF bell curve) of the likelihood distribution. Only considering a single point in the distribution is missing the forest for the trees, and if the customer data violates the statistical assumptions of the model, both these factors combined makes for convergence issues and poor performance. In fact, MLE is completely intractable for the data I'm working with in a company project; I can't proceed any further without a Bayesian approach.

@juanitorduz I've recreated and merged this PR from the base lifetimes repo and am now closing this issue. I look forward to any future notebooks you decide to publish that reference this new covariates model!

I will definitively check it out! Awesome job!


[empy commit] pull request for #2477

⚠⚠⚠ Since we do not accept all types of pull requests and do not want to waste your time. Please be sure that you have read pull request rules:
https://github.com/louislam/uptime-kuma/blob/master/CONTRIBUTING.md#can-i-create-a-pull-request-for-uptime-kuma
Tick the checkbox if you understand [x]:

[x] I have read and understand the pull request rules.

Description
I would like to develop a new feature for #2477
Maybe we can create a UI like this.

Type of change
Please delete any options that are not relevant.

User interface (UI)
New feature (non-breaking change which adds functionality)
This change requires a documentation update

Checklist

[ ] My code follows the style guidelines of this project
[ ] I ran ESLint and other linters for modified files
[ ] I have performed a self-review of my own code and tested it
[ ] I have commented my code, particularly in hard-to-understand areas
(including JSDoc for methods)
[ ] My changes generate no new warnings
[ ] My code needed automated testing. I have added them (this is optional task)

Screenshots (if any)
Please do not use any external image service. Instead, just paste in or drag and drop the image here, and it will be uploaded automatically.

Great, but currently I am still focusing on 2.0.0 and there are quite a lot of pull requests that are still waiting for review.
It may take a longer time to be merged. Probably 2.2.0 or 2.3.0


Presence channel inconsistencies

Reverb Version
1.0.0-beta13
Laravel Version
11.8.0
PHP Version
8.2.18
Description
We are trying to migrate from Pusher to Laravel Reverb with Laravel Echo and encountered some inconsistent behavior.
In Pusher, the member_added event is triggered whenever a user joins a channel. However, if the same user has multiple tabs open, this event triggers only for the first tab. Likewise, the member_removed event only triggers once a user has closed all their connections. See the Pusher documentation where this behavior is documented.
In Reverb, however, these events seem to trigger each time a user connects or disconnects to a presence channel. This makes it impossible to keep track of who is present. For example, if user A has one tab open, and user B two tabs, and user B closes one of the two tabs, user A receives a message that user B left. When user A refreshes the page, they do see that user B is present again.
Is this change of behavior intentional? If so, what would be the right way of keeping track of users with multiple tabs?
Steps To Reproduce
Echo.join(nameOfPresenceChannel)
    .here((users) => {
        console.log(users);
    })
    .joining((user) => {
        console.log(user.name + ' has joined');
    })
    .leaving((user) => {
        console.log(user.name + ' has left');
    })

Open one tab as user A and open the console log
Open two tabs as user B. User A will see that user B has joined.
Close one tab as user B. User A will see that user B has left (even though user B still has a tab open)
Refresh the tab with user A. User A will see that user B is actually still there.

I realized that the behavior of the subscription_succeeded event is also different.
On the Pusher side, the message contains a array of unique user IDs. On the Reverb side, the same user ID can appear multiple times if that user has multiple connections open.

Just had a quick glance and think I can see where this is happening. I will try and take a look into this next week.

Hey @stefanvdlugt would you mind taking this PR for a spin and seeing if it resolves your issue?
https://github.com/laravel/reverb/pull/216


[$1000] PDF preview shows blank white area

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:

Open any chat
Send attached PDF attached in this OP

Expected Result:
PDF preview should be shown properly
Actual Result:
PDF preview shows blank white area
Workaround:
Can the user still use Expensify without this being fixed? Have you informed them of the workaround?
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android / native
[ ] Android / Chrome
[ ] iOS / native
[x] iOS / Safari
[ ] MacOS / Chrome / Safari
[ ] MacOS / Desktop

Version Number: 1.3.42-6
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
https://github.com/Expensify/App/assets/43996225/d27abede-a714-49dd-98b8-7199f93446d5
https://github.com/Expensify/App/assets/43996225/c1104b82-7f70-4f3c-9d07-5491b3b182e1
International_Money_Transfer__Send_Money_Abroad_with_Wise__ex-TransferWise_.pdf
Expensify/Expensify Issue URL:
Issue reported by:  @DinalJivani
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1689772959912119
View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01371d83289588168c
Upwork Job ID:<PHONE_NUMBER>921218048
Last Price Increase: 2023-08-14

Jumping in to test this now.

I'm able to reproduce this one, so I'll triage it. Note: The white space is only visible in the preview, and I wasn't able to reproduce the same issue on native iOS.

I don't know what you are using for rendering, but the sample file has a page of 414 x 12454 points.
The page height is equal to 173 inch or 4.4 meters.
Pages that big will likely overflow all the buffers. perhaps, "won't fix" is the most appropriate resolution.

Contributor details
Your Expensify account email<EMAIL_ADDRESS>Upwork Profile Link: https://www.upwork.com/freelancers/~01b1743757f2e29b3d

Pages that big will likely overflow all the buffers. perhaps, "won't fix" is the most appropriate resolution.

@alexcherut, but it's displayed correctly in preview and in other apps, there definately is a way to render this properly

Issue not reproducible during KI retests. (First week)

Let's close if not reproducible again.

Thanks for confirming! Alright, in that case let's keep this issue open for proposals.

Proposal
Please re-state the problem that we are trying to solve in this issue.
With big pdf the preview is blank on Safari
What is the root cause of that problem?
The root cause of the problem is that the canvas has a pixel limits on safari, the limit is 16.777.216 pixels so it is not able to display the pdf that are above this size.
This is known bug of the library we are using:
https://github.com/wojtekmaj/react-pdf/issues/1149
What changes do you think we should make in order to solve the problem?
We can reduce the numbers of pixels used to render the pdf by using the prop devicePixelRatio created for this purpose:
https://github.com/wojtekmaj/react-pdf/issues/1149#issuecomment-1323541137
We can consider setting it this ratio to 1 only when the size of the pdf is big or when we are on safari because apparently it can make the pdf look more blurry.
Result with devicePixelRatio equal to 1:

What alternative solutions did you explore? (Optional)

We could use the tips of the author of react-pdf and use Math.min(2, window.devicePixelRatio) but I haven't tried it
Alternatively we could limit the ulpoad of  the pdf above a certain size

@ShogunFire, awesome, thanks for linking the react-pdf issue!
There are a number of  solutions listed in that thread we could apply, but all of them are ultimately workarounds, while the actual root cause persists.
Is the maximum canvas size limitation imposed by react-pdf library or is it a Safari limitation? Is there a way we could override it?

I think it's a safari limitation https://pqina.nl/blog/canvas-area-exceeds-the-maximum-limit/ , I feel like even increasing the limit would be a workaround since there will always be a size for which it will stop working.

Do you want to calculate the ratio as a decimal value ? And since the limits are different for each platform, should we only do this for safari or should we take the limit of safari for all platform (it looks like if it works on safari it will work on others)
I think to calculate the number of pixels we can do this:
(width * 72) * (height * 72)
This gives us the number of pixel for a devicePixelRatio of 1 so we can divide the max limit by this number to obtain the max devicePixelRatio  that we can set.
For example, in our case:
(6 inch * 72) * (183 inch  * 72) = 5 692 032 pixels
Max ratio that we can set:  16 777 216 / 5 692 032 = 2.9
Since it was 3 it was crashing
I will verify this

You mean just using this consts ?

Or using the library at runtime ?
By the way I try with 2.9 and it wasn't working so my calcul must be wrong, 2 was not working either, 1.5 was working.
It's hard for me to debug because the pdf preview seem to have a bug on chrome on latest main

I mean using the library at runtime
Ideally, this would be added to react-pdf library in the future

Humm, adding a library just to get the max canvas size for each platform seems like a lot. Do we need to be that precise ? Having those kind of big pdf pages is probably not that common, and even with devicePixelRatio to 1 it didn't look blurry.

Humm, adding a library just to get the max canvas size for each platform seems like a lot. Do we need to be that precise ? Having those kind of big pdf pages is probably not that common, and even with devicePixelRatio to 1 it didn't look blurry.

But how do we check if we should drop pixel ratio? In other words, how do we check that the document is rendered/will be rendered?

I would just take safari's limit since this is the lowest and calculate the max ratio using this limit for each platform.

I would just take safari's limit since this is the lowest and calculate the max ratio using this limit for each platform

We can't be sure it's the lowest limit. Previously max canvas size was dependent on the device's RAM size, there is no info on how it's done now, but we can't be sure it's the lowest limit for all the devices. Moreover, if the limit was to be changed in the future (by a Safari update or simply because a new phone has twice the RAM), our solution wouldn't adapt to that

Makes sense, so I managed to use canvas size library it's pretty simple, now I just need to understand the calcul that we need to make, I thought having a dpr of 3 would result in having 3 times more pixels but since there is width and height it actually works like this:
dpr 1 ->1 pixel
dpr 2 -> 4 pixels
dpr 3 -> 9 pixels
But in our example the size of the pdf was 15 091 000 and the limit was 16 777 216 so the dpr should be very close to 1 but it was working at 1.5 which seems weird because that would make 33 954 750 pixels (size * 1.5*1.5)

Proposal
Updated
Actually it's working, I got confused because the size of the pdf is different on chrome and on safari for ome reason. On safari the number of pixel was like 5 millions. max size 16 million. square root of the ratio gives 1.7 which is what I tested to be the limit value that we can set

I think the only thing that is lacking in my proposal is a way to store the max canvas size once to not have to calculate it all the time we open a pdf, I am still a beginner in react native, is there an easy way to do that when the user launches the app ?

Issue not reproducible during KI retests. (First week)

Still reproductible on <IP_ADDRESS>

Issue not reproducible during KI retests. (First week)

If possible can you attach video of same because I'm still able to reproduce this issue and I see @ShogunFire also confirmed same.

Hello @eVoloshchak can you review my proposal, if needed I can send you my brancj or make a test version as I agree this is not easy to verify. Can you confirm if this looks good and I can for example make a version where the expected mac devicePixelRatio is displayed and where the user can change the devicePixelRatio with a textinput to check if the pdf display with different values

@ShogunFire's proposal looks good to me
There are a couple of issues we should iron out in the PR stage (we should set devicePixelRatio prop only if pdf doesn't fit, for instance), but the approach is correct, it should resolve this for all possible device/browser combinations
🎀👀🎀 C+ reviewed!

Oups sorry I should have waited before creating the PR

Awesome, solution sounds good taking into account it is not our bug and they have those parameters to fix these problems.

Thanks, @eVoloshchak can you help me here when you have time https://github.com/Expensify/App/pull/25721#issuecomment-1688945521

@eVoloshchak
Just here to mention I didn't received Upwork job offer automatically!

PR ready for review

The PR that introduced the bug has been identified. Link to the PR: Not applicable, this is an issue with Safari mobile itself
The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: N/A
A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: this is an edge case that is present only for extremely large PDF files, I don't think an additional discussion is needed
Determine if we should create a regression test for this bug.
Is it easy to test for this bug? Yes
Is the bug related to an important user flow? Yes
Is it an impactful bug? No
While the bug isn't preventing users from using the app, this is a user-facing and commonly used flow, so I think a small regression test is needed here. In addition to that, the PDF limits that were causing the bug can and will change with new devices/OS/Browser versions, so it's important we test this periodically

Regression Test Proposal

Open any chat
Click "+" -> "Add attachment"
Select this PDF file
Verify that PDF preview isn't blank

Do we agree 👍 or 👎

@eVoloshchak Just here to mention I didn't received Upwork job offer automatically!

bump ^^ @eVoloshchak @JmillsExpensify

@JmillsExpensify Can you make the paiement thanks

I didn't received Upwork job offer automatically!

@JmillsExpensify Can you please check if possible

You're not eligible for payment.

Oh sorry, one sec. You're the issue reporter.

Agree with the regression test. I'll get that added. In the meantime, here's the payment summary:

Issue reporter: @DinalJivani $250 (created before Sept 1)
Contributor: @ShogunFire $1,000
Contributor: @eVoloshchak $1,000

@ShogunFire I see you have a thumbs down on the automated message that the urgency bonus doesn't apply. If you disagree, please explain why.

Upwork job is here: https://www.upwork.com/jobs/~01371d83289588168c. Please apply if not automatically assigned.

@JmillsExpensify Ahah sorry I don't disagree, I was just not happy about it

@JmillsExpensify
applied on Upwork job.

Ok thanks all!
@DinalJivani Just sent an offer.
@ShogunFire Just issued payment.
@eVoloshchak I believe you'll create a payment request separately.

Everyone paid in Upwork is processed. Keeping open for the regression test and @eVoloshchak's payment.

Not overdue!

@eVoloshchak Don't forget to finish the regression so we can finish the payment and close this

Huh, I thought I already requested the payment for this, but can't find it, looks like I didn't
Requested the payment right now, please double-check it isn't a duplicate
@pecanoro, the regression test proposal is here

@JmillsExpensify All ready for you to finish any payments left and close it!

Regression test is created and confirmed that there is a NewDot payment. Closing.

$1,000 payment approved for @eVoloshchak based on BZ summary.


Hook verification buttons

Motivation
https://issues.jboss.org/browse/AEROGEAR-7755
What
Allow the user to test a pre/post hook endpoint
Why
So they know it is valid when creating a resolver
How
send the url entered to a route on the server and test it from there
Verification Steps
Go to create  resolver and enter a pre/post hook url to test
A valid one should go green and an invalid one should go red
Checklist:

[x] Code has been tested locally by PR requester
[ ] Changes have been successfully verified by another team member

Progress

[x] Finished task

Additional Notes

👀

Addressed feedback and @psturc Ive updated the error object also. The build broke due to some dependency issues but I think all is ok now.

@cfoskin re-reviewing now, two questions:

Verifying http://asdasdda takes forever, would it be good idea to add a timeout here?
Is axios.post(hook) correct, or should it be get?

@josemigallas  Have to use axios.post as @darahayes  said thats to match what we have in the server. reasoning is if the hook is a POST endpoint then the GET will fail as not found.

@josemigallas I will merge once the conflicts on the other pr are sorted and that is merged

@josemigallas I verified everything still works after merging your pr, still cant merge yet, maybe you need to approve again?


TagBot trigger issue

This issue is used to trigger TagBot; feel free to unsubscribe.
If you haven't already, you should update your TagBot.yml to include issue comment triggers.
Please see this post on Discourse for instructions and more details.
If you'd like for me to do this for you, comment TagBot fix on this issue.
I'll open a PR within a few hours, please be patient!

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/67096

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/68370

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/78267

Triggering TagBot for merged registry pull request
This extra notification is being sent because I expected a tag to exist by now, but it doesn't.
You may want to check your TagBot configuration to ensure that it's running, and if it is, check the logs to make sure that there are no errors.

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/82307

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/82443

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/83674

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/85674

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/85825


Update page to 1.11.5

NOTE: this is a work in progress PR attempting to fix #74 , since there are multiple issues to address. Not all issues may have been detected yet and regression needs to be tested as well.
Currently detected issues:

[x] _basePath is chained infinitely

This isse is fixed by always transforming the path to a /name pattern. I am not 100% if the page package now won't accept other path variations as base anymore or has a bug or something.

[x] _basePath is stripped. after initialize is called

This is fixed by setting the dispatch option in the page(options) call to false. This fixes the Client - Router - base path tests. However, there is no regression-test added yet.

[ ] exit triggers are fired twice

We first need to find out, why the exit trigger is fired twice now, while before once

@jankapunkt do you want to try update page on the latest release? I have couple of things fixed

@dr-dimitru does it make sense to continue this one, since Meteor3 upgrade is breaking anyway?

@dr-dimitru also, it looks like page is abandoned and people look for a fork.

@jankapunkt I'll jump on full rewrite sometimes soon, dropping all dependencies. We can close this one for now.
Latest release works with meteor@3 as expected, right?


Show / Edit mode no longer functions on newest update of Companion

Show / Edit mode no longer functions on newest update of Companion

Which version of QLab ?

Which version of QLab ?

5.3.3 on mac os Sonoma 14.3

Found a typo. Should have a fix later today. Apparently I had help last week.

Thanks for Your Efforts!!!

PR #113

BTW this has fixed setting Show mode and Arm Cue on and off, but there is an issue with the 'toggle' option.
For arming cues, it can toggle the armed state 'off', but then won't toggle to 'on'.
For show mode, the arm state will toggle to edit mode, but won't toggle back to show.
I'll update if/when I find more.

Should be fixed today, PR #114

Awesome. While I've got your attention, is it possible to get feedback for armed state of a cue?


Hostname field is null

Hi,
   Can anyone help after running I am getting Hostname null. Please check screenshot attached.

Hi @softuvo!, I've re-implemented this project and extended it with new features. You can check it out at https://github.com/bugfest/tor-controller -  Happy to assist if you find any issues.


Scaling the SVGImageView the svg content (sometimes) disappears

Steps to reproduce the issue
I have built a drawing editor where I can put an svg image object using PocketSVG library.
When I zoom in/out my virtual canvas, the the svg object is scaled using the CGAffineTransform sometimes
it happens that the svg is not drawn.
I tried setting the backgroundColor to the SVGImageView object, but all the view seems to disappear, not only the CGPaths drawn in its layer.
This is the result at 32% zoom factor:

This is the result at 25% zoom factor:

Specifications

PocketSVG Version: 2.6.0
Xcode Version: 12.1 (12A7403)
iOS/macOS Version: iOS 14.1

@NeedNap I've haven't been able to reproduce this on my end.. Could you please provide a link to a small repo with a reproducible example?

I get this strange behaviour in a huge project which I can't share. It's not easy to reproduce it on a separate repo. It seems to be related to the settings of the contentScaleFactor that I use to prevent the antialiasing blurred effect on zoom in. I saw that if I color the background of the SVG view it is visible but not the svg path.
I hope this further info will help you to understand the problem, otherwise I'll try to create a small repo (I can't guarantee to that shortly).

Sounds good, please let me know when you have a reproducible example.

Closing this due to inactivity. Feel free to reopen if needed.


Process component of Symfony has a bug on version < 3.3.4

Laravel Version: 5.4.32
PHP Version: 7.0.18-0ubuntu<IP_ADDRESS>
Database Driver & Version: Not applicable

Description:
Process converts an empty string argument to " sometimes
Steps To Reproduce:
$forSearch = 'some process';

$ps = new Process('ps aux|grep '.$process.'| grep -v grep');
$ps->run();

 if ( ! $ps->isSuccessful()) {
     Log::error("search process failed by Process command");
    dd($ps->getOutput());  // Not show anything. It's empty
 } else {
     // DO something for process $ps->getOutput()
}

After hours,  try search... and get--> https://github.com/symfony/symfony/pull/23477
I've tried update Process component but I don't know well to do.
After several tests, I see

Sometimes, code work and return string with process filtered
Sometimes, not work and return empty

Laarvel uses 3.2 version of Process

@abkrim unless you're doing something else before, the code above may have a serious security issue: by concatenating the unescaped $process, one might inject any command here.
If you're using Process 3.3, I encourage you to use the new way for creating them, see description here:
https://github.com/symfony/symfony/issues/23778 (not the RFC itself, but the hint give in the description about how it works today.)
On 3.2, you have to use escaleshellarg() or ProcessUtils::escapeArgument().
Not doing so is unsupported I'd say.

This is not a laravel issue.


[docs] Fix casing

Apply the MUI's writing style convention.

👍 thanks. Almost feels like we should be able to lint for this.I see X uses vale. Worth looking deeper into this?

Yeah, I think that Vale could make sense, at minimum to scale from MUI X to https://github.com/mui/material-ui.


Multiple policies in MOA training

As I understand it, in the initial experiments in the paper only a limited number of agents are trained with the MOA/causal influence reward. In the implementation (train_moa.py), it looks all agents are equipped with the MOA model and receive a causal influence reward. It isn't immediately clear to me how to alter this to allow for variation in agent policies/models, since the Trainers postprocess and incorporate the causal rewards. Does anyone have any insight or suggestions into how this might be done?

Right, thanks for the clarification.


Model test framework selection as a "tool" selected by a spec

I'm going to say what was introduced in https://github.com/gradle/gradle/pull/18308 is good enough for now


Ruby Version 2 > 3

Please fix
https://github.com/cyborgway-org/cyborgway-org/actions/runs/7285986354/job/19853876025

We fixed with
          bundler_ver: '<= 2.4.22'             # Default is latest bundler version


FDP_CER_EXT.2 Use Case

FDP_CER_EXT.2.1 says, "establish a linkage from certificate requests from a supported TOE function to issued certificates" This sounds like it is specifying end-entity FIA_X509_EXT.3 functionality for matching a signed certificate to a generated request.
FDP_CER_EXT.2.2 says, "The TSF shall [selection: revoke, not issue ] certificates that cannot be associated with..." This sounds more like a CA function (which is consistent with FIA_XCM_EXT.2); however, it's not clear when "revoke" would be applicable.
It appears FDP_CER_EXT.2.1 should be removed and FDP_CER_EXT.2.2 should be updated so it only specifies "not issue."

Both of these are intended to be CA functionality. FDP_CER_EXT.2.1 is the CA end of the request checking and is part of the accountability requirement for a CA to issue only authorized certificates. No change made. Believe can be closed.


WIP Quickopen Enhancements

Progress Made
Can select more than one item now

c-i increments/decrements
On enter/c-v/c-s opens all the incremented in buffers and whichever you enter/c-v/c-s on it will give that one focus.

Can quickopen for colorschemes

recaches each request due to not having a way to check if it updated outside of vim, it's fast so... I don't see this being a problem.

Fixed quickopen overflow with small windows

Max width to cap at 600px (width before)
width defaults to 70%
details overflow-x: hidden so they aren't floating in random space...

Force open bookmarks

Sometimes I want to open them even if I'm in a cwd other than home/install.

TODO

[x] Force open bookmark/select folder
[x] Colorschemes activate on select instead of actually having to hit enter, this way you get a live preview of the colorscheme and you don't have to reopen each and everytime.
[x] Ignore binary files for all file gathering.
[x] Work on speed improvements
[x] Async files for things other than git folders
[x] State bg/fg colors for neovim to have for oni QO menus
[x] Cache files on directory change/construction
[x] Update ignore (we will use .gitignore kind of ignore)
[x] Be able to type as things load...
[x] Refine input field typing experience.
[x] Make incrementing only available for certain QuickOpenTypes, currently this would be files.

Future TODO

Cache files when we figure out projections/workspaces.
Searching through search results
Implement loc list with incrementing buffer lines and search results.
Buffer lines for ALL active buffers.
Preview and silent loading of buffers
* [ ] Make editing shortcuts for (nvim temporary buffer/instance)

[ ] State popup bg/fg colors for neovim to have for oni AutoComplete menus

[ ] Merge #633 changes once they are done.

Gif Showing Basics Done so far.

[ ] Scrollbar... this is going to be fairly complex due to us only using 10 items right now, but... it shouldn't be that bad.
[ ] Figure out what color to make the highlighting. (Use a light bg you'll see what I mean.
[ ] Make incrementing loading play with tabs better so it's not slow on many file selections.
[ ] Quick Open support for buffers
[ ] Have an option to ignore hidden files/folders
[ ] Prefix support

: - vim command mode for current window
/ - buffer search (integrate with the buffer search you added)
! - oni command mode (same commands shown in Ctrl+Shift+P)
'`' - show available vim marks
& - show available buffers
Others....

Wow, really cool stuff in the gif! I like the colorscheme switching a lot 😄
And cool list - it's neat to see the progress indication on the PR.

Make editing shortcuts for ease

One thing I was thinking about this - is I think there are going to be a few places in Oni where we will have a 'lightweight' edit experience (like a small textbox). A few scenarios I had in mind for this:

QuickOpen (obviously)
Rename experience in the file explorer (press 'F2' or some bound key to trigger a rename, and a small textbox opens over the folder)
Snippet editing - tracked by #55

But for all these cases, it'd be nice to have a the full set of neovim key bindings I have configured (, , etc). I was thinking, potentially, of having these textboxes essentially be tiny neovim windows - so that we could use neovim to process the keybindings.
That would be a bigger chunk of work, and depend on some of the initial multiplexing changes, so it might make sense to defer that piece (if that approach makes sense).

Scrollbar... this is going to be fairly complex due to us only using 10 items right now, but... it shouldn't be that bad.

We might be able to remove the '10-item' limit and use something like https://github.com/bvaughn/react-virtualized to only render a subset.
There were a couple of other things I was thinking top-of-mind too:

Having the Menu use the current color schemes background / foreground colors - I noticed I had to darken up the background fade a bit, but it looked really nice - and might look even cooler with your colorscheme switcher!
Have an incremental-loading experience. Like right now, if there is a big folder, we show "Loading..." but then don't show any results until everything is available. Most fuzzy-finders start showing files/results as soon as they can - that would be a huge experience improvement.

Looking awesome!

And cool list - it's neat to see the progress indication on the PR.

Didn't realized it did progress I just wanted a nice list :).

But for all these cases, it'd be nice to have a the full set of neovim key bindings I have configured (, , etc). I was thinking, potentially, of having these textboxes essentially be tiny neovim windows - so that we could use neovim to process the keybindings.
That would be a bigger chunk of work, and depend on some of the initial multiplexing changes, so it might make sense to defer that piece (if that approach makes sense).

If we use the single neovim instance strategy we could use a temporary hidden buffer that the user doesn't have to know about (i.e. we don't show hidden buffers and unless they open it with buffers! they won't ever know, if they close it we can just open it again...) and so we can use this temporary buffer, use setline()/getline() and that will be our input field, this way we don't have to wait for a new spin each and every time, we can just edit the buffer as the text field tied to it, and then we can edit just like any other neovim buffer... it's a bit complex but it's a wildy awesome idea and I would enjoy this a lot, but I don't even know how it's hooked up to begin with but, yeah.

We might be able to remove the '10-item' limit and use something like https://github.com/bvaughn/react-virtualized to only render a subset.

I will look into that.

Having the Menu use the current color schemes background / foreground colors - I noticed I had to darken up the background fade a bit, but it looked really nice - and might look even cooler with your colorscheme switcher!

I plan on adding a bg/fg color to the state by using &bg/&fg, if these are null then use default (i'm not sure what this is in nvim I've never looked at it honestly without a color for normal...)
On source/color scheme loaded recache these values, that way we can use them for our menus.

Have an incremental-loading experience. Like right now, if there is a big folder, we show "Loading..." but then don't show any results until everything is available. Most fuzzy-finders start showing files/results as soon as they can - that would be a huge experience improvement.

We need a solution, I can use my binary to do this but there is not a good way in typescript without writing an algorithm or porting a library and their dependencies, however I think a solution implemented in typescript may not be the best solution but using something like ag/ripgrep/etc that way we can stream async and we don't use a scripting language that can't optimize as other coding bases.

https://github.com/gjtorikian/nak

currently writing a manual find, it's working pretty nice, almost done.

typescript, only dependency is fs and ignore

going to add support for a config ignore and config use global ignore ~/.gitignore

These will be awesome enhancements, but could you add "update README" to your list of todo's?  We need to be sure to track all the various key combos we're introducing, especially when there isn't a (neo)vim equivalent.

These will be awesome enhancements, but could you add "update README" to your list of todo's? We need to be sure to track all the various key combos we're introducing, especially when there isn't a (neo)vim equivalent.

Once I have a concrete list :)

Sorry I'm a bit late to the party here!  Was (finally) reading through the comments 😄
I really liked this:

If we use the single neovim instance strategy we could use a temporary hidden buffer that the user doesn't have to know about (i.e. we don't show hidden buffers and unless they open it with buffers! they won't ever know, if they close it we can just open it again...) and so we can use this temporary buffer, use setline()/getline() and that will be our input field, this way we don't have to wait for a new spin each and every time, we can just edit the buffer as the text field tied to it, and then we can edit just like any other neovim buffer... it's a bit complex but it's a wildy awesome idea and I would enjoy this a lot, but I don't even know how it's hooked up to begin with but, yeah.
Optionally we can have an entire nvim instance to itself... and other things we might want nvim to use but the user never interact directly, that might be an even better plan.
We could have nvim multiplexing or a neovim singleton, and then a nvim singleton for temporary operations like text inputs.
This kind of goes inline with #633

Sounds like we're exactly on the same page here! That's exactly how I was thinking of using it. I forgot to call out one use case I want to pursue also - I'd like to have an embedded browser in Oni (which is basically free, because Electron), and then use Neovim to manipulate text inputs. I think it'd be really helpful, at least for me, to be able to pop open github and use the keyboard to navigate around  (#361) and use all the neovim-power I have to write text in the issues. Lots of cool possibilities!

Sounds like we're exactly on the same page here! That's exactly how I was thinking of using it. I forgot to call out one use case I want to pursue also - I'd like to have an embedded browser in Oni (which is basically free, because Electron), and then use Neovim to manipulate text inputs. I think it'd be really helpful, at least for me, to be able to pop open github and use the keyboard to navigate around (#361) and use all the neovim-power I have to write text in the issues. Lots of cool possibilities!

Glad we agree! Getting it to work I'm not sure, that's probably better for you to do because I haven't tried connecting to neovim and since you spun it it's make sense but I can give it a go after I'm done with Fuzzy finder, a lot of people have been negatively affected by the slowness so I am killing that by caching and our own manual walker.
If you don't care test it out, it works great for me, however like my commit says the overridden command doesn't seem to work.

@extr0py
Also, this is the plugin I've been working on.
It might be buggy, if you find anything please let me know!
https://github.com/cyansprite/Extract

Nice gif for progress being made

Wow, that's awesome! Can't wait to have that integrated. It's so cool to see the changes to setting & configuration made real-time

And thanks for linking the plugin, I'll check it out in a bit! I read through the README and it sounds interesting. I need to test it out / see how to map in my workflow. Yanking into a list and being able to grab from the list in a convenient manner sounds interesting, especially when you are juggling multiple items you want to store.

Wow, that's awesome! Can't wait to have that integrated. It's so cool to see the changes to setting & configuration made real-time

Yeah I was super happy with the color-scheme outcome.

And thanks for linking the plugin, I'll check it out in a bit! I read through the README and it sounds interesting. I need to test it out / see how to map in my workflow. Yanking into a list and being able to grab from the list in a convenient manner sounds interesting, especially when you are juggling multiple items you want to store.

Thanks, from when I use it it's pretty useful, I haven't found any bugs since the initial commits ( I think 14 while demoing? )
However, there are a few improvements I can think of, let me know how it goes!
As far as I can tell it works with Oni, as it should since it works in vanilla neovim as well.

@cyansprite: I don't know how familiar you are with helm, or if this is within your skillset/goal here, but do you think you could generalize the quickOpen?
I could imagine this replacing wildmenu/cmdline pretty easily, all we'd have to do is have the user give us an activation action, a list of things to choose from, and a final behavior
just a thought

@Bretley Feel free to take it over, I'm not working on this anymore, it's more of just staying here until @bryphe decides it's no longer necessary, I don't have time to work on Oni anymore fortunately.

@bryphe since I haven't been here for a while, is this a Proof Of Concept or is this something wand merged in? I'm not saying I'd be able to do it, but I could try!

@Bretley I think there are a lot of really great ideas in this PR from @cyansprite  (and great discussion too!), so I've been using it as a reference. There are a few things that are top-of-mind for me in the menu space:

Asynchronous loading + general menu API (I started doing some work on this in #764)
Using a binary by default (both the default strategies can be replaced by ripgrep, so I have that prototyped in #762)

The most important gap we have today, though (in my opinion), is the 'first-run' experience - the first time you open Oni up, and open the quick open experience - it's a bit confusing and unintuitive. I like the experience VSCode has, where you can type ? and see some of the available options - figuring out a way to ease the user in and show them the capabilities in an intuitive way is important here. Having the command prefixes would certainly help a lot. I think there's still some design / thinking we need to do here.
Long-term, too, I'd like to see if it is possible to consolidate the Oni commands & Vim ex commands together too (I think you mentioned this a bit in #776). It'd be nice if users didn't have to think too hard about whether they need to : or <C+S+P> to get where they need to go 😄
It might be a challenge to bring this PR in as-is giving that the menu API surface is changing, but if there are any parts that interest you that could be split out, I'm definitely open to that! Some ideas for chunks to split out could be the multi-selection (extending the new menu API to handle that), or create the colorscheme chooser - that was a really cool part of this PR too 👍
Otherwise, thinking about how we can smooth out that first-open experience would be awesome.


Type hints & PEP 561 packaging

Add type hints to all (public API) code make the distribution PEP 561 compliant. This allows mypy (and other tools?) to find the type hints and use them in linting.
In practice, add py.typed file to statsd package, and include it in the package:
setup(
    package_data={'statsd': ['py.typed']},
    zip_safe=False,  # not needed with wheels, AFAIK
)

PEP 561: https://www.python.org/dev/peps/pep-0561/

I want to give it a try but with dropping support for Python 2.7. Writing all type annotations as stubs or comments is a bit painful and hard to maintain.

Python 2.7 is officially dropped!


ESP8266 data output pin is RX0, not RX1

I'm running this with an ESP-01 with the LED strip connected to RX0 and it works!
I first suspected this when I looked at a pinout for the NodeMCU v3, and it appeared the pin circled in the README was actually RX0, not RX1. (See https://frightanic.com/iot/comparison-of-esp8266-nodemcu-development-boards/#v3)
The ESP8266EX datasheet does say that the I2S data out pin is RX0 (the datasheet calls it U0RXD). See section 4.5: https://espressif.com/sites/default/files/documentation/0a-esp8266ex_datasheet_en.pdf

Hi, did to have to change something in code ?
Or I can use this as it is for ESP8266-01?

I don't think I changed anything in the code, it just worked as is.


test: use AL2 for nvidia E2E test

Fixes #N/A
Description
Updates the nvidia scheduling test to use AL2 over AL2023. This needed to be changed in light of #6726 since we will no longer use non-accelerated AMIs for GPU workloads with AL2023.
How was this change tested?
make e2etests
Does this change impact docs?

[ ] Yes, PR includes docs updates
[ ] Yes, issue opened: #
[x] No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>2
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 79.322%

Totals

Change from base Build<PHONE_NUMBER>3:
0.0%

Covered Lines:
5919

Relevant Lines:
7462

💛  - Coveralls


torchvision.utils.make_grid modifies input tensor in place

Was using torchvision.utils.make_grid to view model weights, but turns out this function modifies the input tensor in-place, causing weirdness during training.
Would be great if this behaviour was commented (if this is the desired behaviour for normalising it), or changed to only modify output grid & not use in-place normalisation.

Indeed, this doesn't look like a good default behaviour. Could you send a PR? Maybe just adding a .clone() in the beginning of the function?

I sent a PR addressing this issue in #241.


PostgreSQL 12 DDL Issue (new "GENERATED"  statement)

Hi
I'm using a PostgreSQL 12.1 Instance
If i execute the follow DDL command:
CREATE TABLE ts_test (
	f1 int4 NOT NULL GENERATED ALWAYS AS IDENTITY,
	f2 int4 NULL,
	ts timestamptz GENERATED ALWAYS AS (fn_current_timestamp()) STORED,
	CONSTRAINT pk_ts_test PRIMARY KEY (f1)
);

... when I use "GENERATE SQL" I obtain:
CREATE TABLE ts_test (
	f1 int4 NOT NULL GENERATED ALWAYS AS IDENTITY,
	f2 int4 NULL,
	ts timestamptz NULL DEFAULT fn_current_timestamp(),
	CONSTRAINT pk_ts_test PRIMARY KEY (f1)
);

The problem is with the statement: GENERATED ALWAYS AS (fn_current_timestamp()) STORED
Again: using "GENERATED ALWAYS AS IDENTITY"  (instead of "SERIAL") the sequence objects are managed "internally" .... so, other tools (for example pgadmin4), don't list them in the "Sequences" tab.
Regards.

https://www.postgresql.org/docs/current/ddl-generated-columns.html table for tests can be taken from here.

Fixed in 21.0.1

verified


[question] ALB instead of ELB?

Are there any strong reasons not to use the ALB for the services instead of an ELB? If not I'm happy to submit a PR which changes this.

The main reason was that the ALB did not exist when we initially released stack.
Internally we migrated all our load balancers to ALBs at Segment but we ran into issues for public facing services that receive requests from web pages that have large cookies because the ALB has lower limits than the ELB on HTTP header sizes (8kb per header field).
The best feature of the ALB is the ability to register ECS services with dynamic port binding, it gives so many opportunities for autoscaling and smoother deployments, but it's not a drop in replacement for the ELB.
Besides those facts, any changes to stack to introduce support for the ALB must be done in a backward compatible manner or it will be a pain for anybody relying on stack (its unlikely that TF will be able to make a zero-downtime transition).
Feel free to submit a pull request and we can discuss the details then.

I'm also looking into using an ALB. If I understand ECS auto-scaling correctly, this stack will only auto-scale the number of containers running on the instances, but not the instances themselves. Is that right? If you don't have enough instances running you will eventually max-out how many containers you can autoscale to and will need to add more to the pool.
My understanding is that you need to make a separate set of auto-scaling rules via aws_appautoscaling_policy and tie them to the ALB target. This will allow you to scale both the number of instances and the number of containers up based on the same alarms. It seems a little clunky to have to scale both the desired count of the instances and the containers up at once. The container count will have to wait for a new instance to spin up before it can actually scale to that count and it just seems prone to desyncing.
Am I right that this stack will not handle the case I described? Is there a better way to handle this than making two separate autoscaling policies, one for EC2 instances and one for the ECS service?

Actually it doesn't do service autoscaling, at the time we released stack ECS service autoscaling did not exist yet and we haven't added it since.

I'm gonna close this issue, feel free to re-open if you have follow up questions or comments.


Added response coding

Fixes #
Proposed Changes
I added a new encoding method to thet set of categorical encoders that are already there. The method is the response coding.

Hi @Khaled-Issa
thanks for your contribution. This encoder to me seems to do pretty much the same as the target encoder except that target encoders has regularization in order to avoid over-fitting in case categories are small. So I'm wondering if there is an added-value in the response coding? Do you have any academic reference or a good argument why this can be better (in some situations) than target encoding?

Hi @PaulWestenthanner,
I got the idea of response coding from this medium article:
<EMAIL_ADDRESS>I agree with you that it acts like the target encoding, the only difference is it calculates the probabilities not just for the label =1 but for the label =0 too and adds a two columns instead of one to the dataframe. one for the probs = 1, the other =0.
Do you think it'll be valuable to add a parameter in the target encoding that if set to true adds the probs=0 too to the encoded dataframe or that will be redundant?


Clicking autocomplete field after clear doesn't show dropdown list

What is the expected behavior?
Clicking the cleared autocomplete input field should show the dropdown list.
What is the current behavior?
After clearing the autocomplete field using a clear button that sets the input value to null or '', clicking the cleared input field will not show the dropdown list. The dropdown list will show if the user clicks the label above the input field, clicks very close to the top side of the input line, or clicks away from the input then back into the input field.
What are the steps to reproduce?
https://stackblitz.com/edit/angular-srhd19?embed=1&file=app/autocomplete-simple-example.html

Select an item from the list.
Use the clear button to clear the input.
Click in the middle of the input field, then notice nothing happen.

Which versions of Angular, Material, OS, TypeScript, browsers are affected?
Angular6, Material 6.4.7 and 7.2.0, Windows 7 and Linux, Firefox 60.5.2, Chrome 72.0.3626.121
Is there anything else we should know?
The user can enter a character or select up or down arrows to force the dropdown list to open after input has been cleared.

It works if $event.stopPropagation() is added after the variable is set to null
https://angular-material-autocomplete-clear.stackblitz.io

@lnu
Thanks, using  $event.stopPropagation()  worked for me.
(click)="inputProcess = null ; $event.stopPropagation() "


WARNING:poretools:Could not extract template events for read:

Here you can see, I am not sure whether the new fast5 puts the events in the summary folder rather than the BaseCalled_template folder
Do you have any solution for that?
Thanks

have the same issue. Is there a workaround?


[BUG] conflict with templater

after the last update, I face conflict with templater
template

quickadd template settings

result the same template not changes to values

errors:

console

quickadd v0.4.8
templater v1.9.9
obsidiab v0.12.15

Hi, @chhoumann
It affects me so I can't use templater or quickadd
Same problem with both
I'll wait for a future update to fix this
I appreciate your trouble, no problem


Invalid window id when trying to edit files in floating window with codewindow.nvim open

I got the following error message when I try to edit a buffer:
Error executing vim.schedule lua callback: ...k/packer/start/codewindow.nvim/lua/codewindow/window.lua:67: Invalid window id: 1026
stack traceback:
        [C]: in function 'nvim_win_get_buf'
        ...k/packer/start/codewindow.nvim/lua/codewindow/window.lua:67: in function ''
        vim/_editor.lua: in function ''
        vim/_editor.lua: in function <vim/_editor.lua:0>

Screencast:

I just worked around this by calling close_minimap() before creating the floating window and open_minimap() again when the floating window did get created. There is another related issue that I need to add
vim.api.nvim_feedkeys('jk', 'n', true)

so that the minimap will move to the right position of the floating window.

I'm seeing this too when using https://github.com/linty-org/key-menu.nvim and it opens a floating window.

Please check if this works now after the fix for #9

Working for me now. Thanks for the fix!


Improvements to class generation for complex polymorphism

Support for multiple discriminator keys pointing to the same class
Preventing the top-level use of oneOf anyOf or allOf in a schema of type object as OpenApi3 is vague on how to interpret this. Providing a good warning message when this happens

👍


Fix issue on incorrect import

Added modules to __init__.py
Fixed import of utils in nmi_mysql.py
Moved tests to a separate folder
Update travis and requirements

@sibayanjasper check mo na..nadeploy ko na..

#15


Supporting PE for kusto clusters

Description

added pe support for kusto clusters

added pe test for kusto clusters

Co-authored-by: Ohad Tayler<EMAIL_ADDRESS>Testing Guide

History Notes

[Component Name 1] BREAKING CHANGE: az command a: Make some customer-facing breaking change
[Component Name 2] az command b: Add some customer-facing feature

This checklist is used to make sure that common guidelines for a pull request are followed.

[ ] The PR title and description has followed the guideline in Submitting Pull Requests.

[ ] I adhere to the Command Guidelines.

[ ] I adhere to the Error Handling Guidelines.

kusto

@ohaty, please refine the PR title via: https://github.com/Azure/azure-cli/tree/dev/doc/authoring_command_modules#format-pr-title, and make sure the testing recordings are working.

Hey, I have changed the PR title. As well I have tested the recording locally

/azp run


Support socks5 proxy username and password

Support socks5 proxy username and password
support tcp fastopen

use mvn spotless:check to format the code first

Thanks, Already formatted @wcy666103

@AlbumenJ  Hello, can you help me merge this pr?


support absolute path in vault

file and link settings are not relative paths, but absolute paths in vault, and I cannot render images properly in MARP

Thank you for your interest in our project and for taking the time to report this issue. To better understand the issue and assist you in resolving it, could you please provide some additional details?

Thank you for your interest in our project and for taking the time to report this issue. To better understand the issue and assist you in resolving it, could you please provide some additional details?

My settings in OBSIDIAN are as follows. Can I support this type of link

obsidianfold（vault）

Afolder
Bfolder

assets

example.png

test.md

Cfolder

in test.md，the example.png is imported by this link
![example.png](Bfolder/assets/example.png)


do not copy vectors and support mmap files

I see a huge potential of improvement at a very low cost.
Currently indexes are very optimized in size (and one can control it with parameters) but we still have to copy all data.
My proposal has two steps:

add an option to avoid copying data when adding it to the index. Instead we just store a reference / pointer. This should be an experimental feature because it makes the user responsible of memory management. It can be tricky to interface with C++ but numpy works well IMO. The gain would be a factor 2 for free (currently it's still possible to add items in batches to avoid duplication).
support numpy's memmap / POSIX's mmap. This is where the real gains come in because it allows one to only store the index in the RAM and keep the much larger data on the disk. The index could also be on disk but it could decrease performance too much (I don't recall the paper well enough to be confident). It will make queries slower but allows much larger databases so it's a time/memory trade-off that can come in handy in a lot of cases (large databases and limited RAM with non critical access time).

I can help to implement this but I first need to know:

if it seems doable
where I should start

Let me chime in on this, though it's Yura's package. It seems to me that copying data and even indexing it has a negligible cost nowadays compared to the effort spent on generating these vectors.

That's good news since it means the performance won't be affected too much. Note that my focus is really on decreasing RAM usage.
HNSW is my go-to ANN package but it lacks an option to index large datasets on a machine with limited RAM, like annoy proposes.

But Annoy would still be slow if index doesn't fit into RAM?

It's acceptable thanks to mmap, especially on a SSD.
I'm just curious how hard it would be to do in HNSW and how that would compare in terms of speed.

Hi @louisabraham

One thing that comes to my mind is that if we access the python data from hnswlib it seems to require getting a GIL lock, making the code effectively single-threaded. We can store the C array memory references, but not sure it will work with numpy mmap (in that case it is not as useful for the scenario).
If those problems can be solved it would be an interesting addition and probably can done as a separate space in C++ library (and some changes in bindings).
It seems interesting and worth adding. Probably, the easiest option is to use unix mmap instead of malloc for the lower layer (there was a PR #227 which already looked at it, but had many changing including the api, maybe we can reuse it), though it will not work on windows without additional effort.

Concerning what to store - for each read of the data there is a corresponding read of the link list during the search and, in addition, they can be collocated (in case mmap is done within the index), so probably putting them together would not slow down index that much. Something similar (storage of both links and data in the lower level) was studied in [https://proceedings.neurips.cc//paper/2020/file/788d986905533aba051261497ecffcbb-Paper.pdf] (and overall IMO it makes sense to bother insights from the paper).

@louisabraham @yurymalkov
I think both of these features would be extremely useful!!
I have recently added pickle support to the python bindings, and the internal data storage of the HierarchicalNSW (NHSW) class, implemented in hnswlag.h, is fresh in my head. Maybe, I can offer some insights here as well.
Data points are stored in data_level0_memory_ array, defined on line 120. The points are stored together with external labels, and links for the first layer (level 0). They are copied into data_level0_memory_ by HNSW methods addPoint and updatePoint on lines 1030 and 833. Access to points in data_level0_memory_ is encapsulated with  inline method getDataByInternalId defined on line 151.
One option could be to store point id's in data_level0_memory_, instead of actual data points. These id's would then be used by getDataByInternalId to load points from some external table. In this case, signatures for addPoint and updatePoint would have to change from
void addPoint(const void *data_point, labeltype label) ;
void updatePoint(const void *dataPoint, tableint internalId, float updateNeighborProbability) ;

to something like
void addPoint(pointtype point_id, labeltype label);
void updatePoint(pointtype point_id, tableint internalId, float updateNeighborProbability);

I think as long as points are not modified after insertion into the table, synchronization logic from HNSW should work for this case as is. So, maybe the original HNSW class can be extended to implement both features.

Loading table from memory-mapped files should be fairly straight-forward. File path can be passed to the constructor (and no issues with serialization). Not sure about the choice between numpy's memmap and POSIX's mmap here though.

I dont see a clean way for the case when the table is defined in main memory, and passed to HNSW as a pointer or a numpy array. I can check pybind11 docs, maybe there is something that can be leveraged here.

@dbespalov @yurymalkov @louisabraham
This is an incredibly interesting thread and very relevant to a use case that I am looking into where I am hoping to use an ANN algorithm on a machine with limited RAM. I was wondering if anything ever came of this thread in terms of allowing for memory-mapped files? Thanks in advance for more info!
I am also curious @louisabraham if since creating this thread you have worked with other ANN libraries that accomplish this with similar performance to HNSW (which is pretty sweet!)?

Did you have a look at Annoy?

I have a bit, but will certainly look more! Were you using the Spotify annoy library?
From looking at the ANN Benchmarks, I was hoping to find one of the stronger performing benchmarks - annoy seems relatively low performing in (Recall/Query speed) and generates a very large on disk index; however, maybe we get these performance hits because annoy is optimized for memory mapping and production characteristics. Eager to dig more into this, thanks @louisabraham!