Git add of file with unicode name fails in Git panel

VSCode Version: Code 1.19.1 (0759f77bb8d86658bc935a10a64f6182c5a1eeba, 2017-12-19T09:46:02.926Z)
OS Version: Windows_NT ia32 10.0.16299
Extensions:

Extension
Author (truncated)
Version

vscode-base64
ada
0.0.1

vscode-database
baj
1.2.0

toml
be5
0.0.3

vscode-markdownlint
Dav
0.12.0

createuniqueid
don
0.0.3

githistory
don
0.2.3

EditorConfig
Edi
0.11.1

git-project-manager
fel
1.4.0

mdmath
goe
2.1.0

vscode-wordcount-cjk
hol
1.0.0

Ionide-FAKE
Ion
1.2.3

Ionide-fsharp
Ion
3.15.7

Ionide-Paket
Ion
1.8.1

copy-markdown-as-html
jer
1.0.0

golang-tdd
joa
0.0.9

Go
luk
0.6.71

reflow-markdown
mar
1.3.0

azure-account
ms-
0.2.2

csharp
ms-
1.13.1

vscode-docker
Pet
0.0.23

vscode-icons
rob
7.19.0

go-test-outline
Rom
0.1.4

rust
rus
0.3.2

vscode-autohotkey
sle
0.2.1

vscode-helm
tec
0.3.0

vscode-lldb
vad
0.7.3

vim
vsc
0.10.8

debug
web
0.21.2

Steps to Reproduce:

Initialize a git repository and open the folder in VSCode.
Create a new file named defaŭlto.html.
From the VSCode Git panel, use the "+" icon to stage the new file.
Error reported: fatal: pathspec 'c:\…\defaulto.html' did not match any files

Git log reports that it ran the following command: "git add -A -- c:\…\defaŭlto.html"
Running the same command from the git command line in Powershell works without a problem, but also fails from the normal Windows command prompt. Reviewing StackOverflow and other locations, it appears that this is a limitation of the Windows command prompt, but I thought I would document it here since it has a knock-on effect for the Git panel.

Reproduces without extensions: Yes

Had a similar issue in #47677 which was closed as duplicate. Looking forward to the fix to this one.

@neoeinstein Do you confirm this?

I can confirm that this appears to be working now with 1.28.2. Thanks!

I can confirm you can add files with unicode names, but:

Had a similar issue in #47677 which was closed as duplicate. Looking forward to the fix to this one.

When the unicode characters are in folder names, it still fails.
Just in case it's relevant, I'm on 1.34.0, macOS 10.14.5.

This is still happening for me in 1.46.1 on macOS 10.15.5

Git: fatal: /Users/pepelsbey/Projects/Пепелсбей.net/Блог/playground/28/.editorconfig: '/Users/pepelsbey/Projects/Пепелсбей.net/Блог/playground/28/.editorconfig' is outside repository

As you can see I have Cyrillic folder names.

@pepelsbey You have a different issue. Please update to Git 2.27 and it will be fixed.

@joaomoreno I have Git 2.27 installed on my system. I believe that’s the one VS Code uses.
$ git --version
git version 2.27.0

But I still have this problem.

I managed to reproduce it with the minimal setup:

mkdir й && cd й
git init
touch file.md
Open the folder in VS Code (1.46.1)
Go to Source Control panel
Try to stage file.md

It works fine if the folder is named q instead of й.

What exact keyboard combination do you press to write й?

It’s a single letter on the same key as q.
й
CYRILLIC SMALL LETTER SHORT I
Unicode: U+0439, UTF-8: D0 B9

BTW, sometimes macOS (for some reason) uses two symbols to reproduce it: и plus combining top character (not sure which one).

I have the same problem with Japanese path name and git version 2.29.2.

It works for me now as expected in 1.51.1 on macOS 11.0.1 with git 2.29.2

I managed to reproduce it with the minimal setup:
1. `mkdir й && cd й`
2. `git init`
3. `touch file.md`
4. Open the folder in VS Code (1.46.1)
5. Go to Source Control panel
6. Try to stage file.md

It works fine if the folder is named q instead of й.

Just testet and it works:

git version 2.29.2
vscode 1.51.1, e5a624b788d92b8d34d1392e4c4d9789406efe8f, x64
macOS 10.15.7

@pepelsbey

BTW, sometimes macOS (for some reason) uses two symbols to reproduce it: и plus combining top character (not sure which one).

Look up dead keys. After YEARS suffering with them I could finally disable them on Windows. (Using Microsoft Keyboard Layout Creator.)
Sorry if my reply is off topic. 😅

Unfortunately it’s still broken in 1.59.1. Here’s another way to reproduce:

Finder: File > New Folder > й
cd й enter the folder
git init init repository
touch file.md create a file
code . open the folder in VS Code
Go to Source Control panel

And you’ll see that repository doesn’t exist:

But it works fine with и letter for the folder name:

Now I know what is going on. If the folder is created via shell with mkdir it works. If the folder is created or renamed via Finder it fails.

Unfortunately I cannot reproduce that.

Unfortunately it’s still broken in 1.59.1. Here’s another way to reproduce:

Finder: File > New Folder > й
cd й enter the folder
git init init repository
touch file.md create a file
code . open the folder in VS Code
Go to Source Control panel

And you’ll see that repository doesn’t exist:

But it works fine with и letter for the folder name:

If I follow those steps, I see the repository as not initialized for a few seconds, then it shows up normally. But it still won't stage any file.

This is the output from the git log:
Looking for git in: /usr/local/bin/git
Using git 2.31.1 from /usr/local/bin/git
> git rev-parse --git-dir
Open repository: /Users/gabriel/Downloads/test/ú
> git status -z -u
> git symbolic-ref --short HEAD
> git for-each-ref --format=%(refname)%00%(upstream:short)%00%(objectname)%00%(upstream:track) refs/heads/main refs/remotes/main
> git for-each-ref --sort -committerdate --format %(refname) %(objectname) %(*objectname)
> git remote --verbose
> git config --local branch.main.github-pr-owner-number
> git config --get commit.template
> git config --local branch.main.github-pr-owner-number
> git check-ignore -v -z --stdin
> git config --global user.email
> git config --global user.name
> git status -z -u
> git symbolic-ref --short HEAD
> git for-each-ref --format=%(refname)%00%(upstream:short)%00%(objectname)%00%(upstream:track) refs/heads/main refs/remotes/main
> git for-each-ref --sort -committerdate --format %(refname) %(objectname) %(*objectname)
> git remote --verbose
> git config --get commit.template
git.stage 1
git.stage.scmResources 1
> git add -A -- /Users/gabriel/Downloads/test/ú/file.md
fatal: /Users/gabriel/Downloads/test/ú/file.md: '/Users/gabriel/Downloads/test/ú/file.md' is outside repository at '/Users/gabriel/Downloads/test/ú'

Now I know what is going on. If the folder is created via shell with mkdir it works. If the folder is created or renamed via Finder it fails.

Unfortunately I cannot reproduce that.

I could and can confirm. Using mkdir it works as it should. As soon as I rename it on Finder, it breaks again. It doesn't seem to be a problem with git, as I can git add file.md and git rm --cached file.md from a terminal without problem, and even vscode reflects changes correctly.

It doesn't seem to be a problem with git

Yes, that’s the point. When GUI fails to stage files I open VS Code’s terminal to do it via CLI using the same git binary.

I have the same issue now. Have anyone solved this?

I have exactly the same issue with éèà letters, in French. But this is come from git. not from Vscode.
try this in terminal : git add -A -- /Users/me/Documents/Activités/index.html
any solution? thank you

Even though this issue looks similar to #135257 #134696, why hasn't it been resolved for over four years since 2018?

Hello everyone, idk why this issue is not fixed, but @cosmicbeamer - THANK YOU!
System:

Mac OS 12.5.1
VS Code 1.76.1
git version 2.37.1 (Apple Git-137.1)

Problem:

I have directory "Программа" (created by finder) with my code files, and I get fatal error (can't stage changes and push to repo) |

Solution:

Rename "Программа" to "Программа2"
mkdir Программа
Transfer all files from "Программа2" dir to "Программа" dir (created by mkdir)
Stage changes, commit, push - and IT WORKS!

P.S. Maybe u should restart vs code if it's not working
P.S.S. It works for me, but it may not work for you, just try)

Same issue. This has been going on since 2018, how is it possible that there is no working solution?

This is still relevant as of 02/2024. Would there be a way to look at/change which commands are run in the background when the Git GUI is used?

@johannes-langer, could you please share the steps that you have followed to reproduce this? I have spent some time trying to create folders/files using Finder, VS code, terminal and I am unable to reproduce the issue using the latest version of VS Code Insiders and git version 2.42.0.

@johannes-langer, could you please share the steps that you have followed to reproduce this? I have spent some time trying to create folders/files using Finder, VS code, terminal and I am unable to reproduce the issue using the latest version of VS Code Insiders and git version 2.42.0.

I can still reproduce the issue as mentioned on https://github.com/microsoft/vscode/issues/41246#issuecomment-908688963

@MDKi, could you please share a recording (https://gifcap.dev) with the repro steps? Thanks!


Allow "x-ua-compatible: ie=edge"

Fixes #259.

Coverage remained the same at 100.0% when pulling 50234ce5b88a49a0e60b62b10ccc0bc4b873b72b on fix-259 into 432e506f2ba7160886fbdc1905b9be5804aaa5b9 on master.


What am i doing wrong?

Hello. I'm new to sass :|
Currently i'm trying to compile Foundation framework scss files with your sass-autocompile for Atom. Don't know why, but foundation.scss always compiles into empty foundation.css.
What am i doing wrong?
node.js & node-sass are both installed (globaly)
foundation scss files

No, you are not doing anything wrong. I had a quick look at Foundation framework and -- the name tells us ;) -- it's only a framework. This framework is a collection of mixins and functions, which are not used in any file, so there cannot be any output. It's up to you to write SASS "code" which use these.
I added the following "code" at the end of foundation.scss which uses the foreground function defined in util/_color.scss -- it was only a test, please do not add anything to this file ;)
body {
    color: foreground(red);
}

After I compiled the foundation.scssfile, the content of the minified file was:
body{color:#fefefe}


When I import other proto files in the proto file and publish the data, the monitor will report the following error

Problem Description
When I import other proto files in the proto file and publish the data, the monitor will report the following error：

my image proto:
syntax = "proto3";
package eon.proto.sensor;

import "eon/proto/common.proto";

message Image
{
  eon.proto.common.Header header = 1;

   ...
}

my common.proto file, using import public "xxx.proto";，this can't work
syntax = "proto3";
package eon.proto.common;

import public "header.proto";   // public

When I write directly in the image proto file like this, can work
syntax = "proto3";
package eon.proto.sensor;

import "header.proto";    // not public

message Image
{
  eon.proto.common.Header header = 1;

   ...
}

This error only occurs when proto imports an intermediate file.
How to reproduce

Import other proto in a proto file
compile and run
run ecal monitor

How did you get eCAL?
Ubuntu PPA (apt-get)
Environment

eCAL Version: 5.11.2
Operating System: Ubuntu 20.04
CMake and compiler version: 3.25

eCAL System Information
------------------------- SYSTEM ---------------------------------
Version                  : v5.11.2 (2023-01-20 08:09:14 +0100)
Platform                 : linux

------------------------- CONFIGURATION --------------------------
Default INI              : /etc/ecal/ecal.ini

------------------------- NETWORK --------------------------------
Host name                : dev
Network mode             : local
Network ttl              : 2
Network sndbuf           : 5 MByte
Network rcvbuf           : 5 MByte
Multicast group          : <IP_ADDRESS>
Multicast mask           : <IP_ADDRESS>
Multicast ports          : 14000 - 14010
Multicast join all IFs   : off
Bandwidth limit (udp)    : not limited

------------------------- TIME -----------------------------------
Synchronization realtime : "ecaltime-localtime"
Synchronization replay   :
State                    :  synchronized
Master / Slave           :  Master
Status (Code)            : "everything is fine."
Do you have a regular eCAL::protobuf::CPublisher<eon::proto::sensor::Image> which is sending the data?
We do work a lot with nested protobuf's (see also the person example, it's distributed over 3 different proto files here), and haven't had any problems so far.
Things get a little more interesting when the proto files are also in a directory structure: We usually use this CMake function to generate the protobufs pb.h and pb.cc files.
So how (with which protoc invocation) do you generate the files?
Is it possible that you can create a minimal sample (e.g. CMakeLists.txt, main.cpp, and 2 proto files) where this occurs , so we can take a look?

Closing due to inactivity.


Uncaught TypeError: Cannot read property 'remove' of undefined

[Enter steps to reproduce:]

...
...

Atom: 1.45.0 x64
Electron: 4.2.7
OS: Microsoft Windows 10 Home Single Language
Thrown From: script package 3.25.0
Stack Trace
Uncaught TypeError: Cannot read property 'remove' of undefined
At C:\Users\zzter\.atom\packages\script\node_modules\atom-message-panel\lib\MessagePanelView.js:189

TypeError: Cannot read property 'remove' of undefined
    at ScriptView.MessagePanelView.remove (/packages/script/node_modules/atom-message-panel/lib/MessagePanelView.js:189:30)
    at ScriptView.detach (/packages/script/node_modules/jquery/dist/jquery.js:5357:15)
    at ScriptView.removePanel (/packages/script/lib/script-view.js:89:10)
    at Object.closeScriptViewAndStopRunner (/packages/script/lib/script.js:161:21)
    at HTMLElement.scriptCloseView (/packages/script/lib/script.js:94:39)
    at CommandRegistry.handleCommandEvent (~/AppData/Local/atom/app-1.45.0/resources/app/static/<embedded>:11:349290)
    at CommandRegistry.dispatch (~/AppData/Local/atom/app-1.45.0/resources/app/static/<embedded>:11:347765)
    at ScriptView.close (/packages/script/lib/script-view.js:99:19)
    at /packages/script/node_modules/space-pen/lib/space-pen.js:220:36)
    at HTMLDivElement.dispatch (/packages/script/node_modules/jquery/dist/jquery.js:4435:9)
    at HTMLDivElement.elemData.handle (/packages/script/node_modules/jquery/dist/jquery.js:4121:28)

Commands
     -4:45.9.0 core:paste (input.hidden-input)
     -4:43.6.0 core:undo (input.hidden-input)
 19x -3:31 core:backspace (input.hidden-input)
     -2:22.2.0 core:paste (input.hidden-input)
     -2:17.6.0 script:run (input.hidden-input)
     -2:10.4.0 grammar-selector:show (atom-text-editor.editor.is-focused)
  4x -2:01.6.0 core:backspace (input.hidden-input)
  3x -0:45.6.0 script:close-view (atom-workspace.workspace.scrollbars-visible-always.theme-solarized-dark-syntax.theme-one-dark-ui)
  4x -0:40.4.0 core:cancel (div.am-panel.tool-panel.panel-bottom.native-key-bindings.script-view)

Non-Core Packages
javascript-snippets 1.2.1
script 3.25.0

same error I am getting too

I get this just pressing the escape key in Atom if script is installed.

what can i do? install again atom? or what?

Has this been solved?

did someone solve this or no?

I've just uninstalled "script" and am using "Hydrogen" instead for my python needs. I honestly like the notebook style interface better than running the whole script at once. I can't comment on if this has been resolved or not, but no devs have commented here as far as I can tell.

I can use it again after commented the whole "MessagePanelView.prototype.remove()" function in MessagePanelView.js


Added an alternative S2T2 community template

Changes
Added an alternative S2T2 - Snowpack + Svelte + Typescript + TailwindCSS community csa-template, app-template-s2t2, why?

Less dependency and better build time
Purged TailwindCSS at build time

See more verdicts on the Medium article
Testing

Docs

Thank you!


First draft of "integration tests" for Cesium3DTiles

This is a draft for some "integration tests". These are supposed to be at a higher level of abstraction than real unit tests, but a lower level than booting up the Unreal Engine and visually inspecting the rendered result.
The idea is to have some "dummy" classes that can be fed into the TilesetExternals - namely, a FileAssetAccessor that allows accessing files with assets (hence the name...), a NullResourcePreparer that does nothing, and a SimpleTaskProcessor that simply runs tasks in an arbitrary thread. This allows loading a Tileset from disc, setting up the ViewState, and call updateView programmatically.
This might come in handy in order to be able to debug-step into the updateView call, without having the burden of the UE being wrapped around this. In view of performance testing and optimization, it could offer an entry point with predefined settings, without the overhead and threading intricacies of the UE, and where an actual profiler run from Visual Studio could focus on a certain code path that is supposed to be profiled and analyzed, with different tilesets for testing (maybe https://github.com/CesiumGS/swayze/tree/master/specs/data or https://github.com/CesiumGS/cesium/tree/master/Specs/Data/Cesium3DTiles ...)
There is a single example at the moment. (It is added as a TEST_CASE, but it could as well be a standalone executable with a set of tests, with the appropriate CMake magic). This example loads a Tileset from a local file that is part of this PR. (NOTE: I still have to figure out the right file path. For now, I used an absolute path for my setup - ouch...). The example is a simple tileset with discrete LODs (similar to the TilesetWithDiscreteLOD sample, but with B3DMs that contain glTF 2.0 assets - cesium-native currently does not support glTF 1.0 ones, and that shouldn't be necessary). The test then consists of the camera moving towards the rendered object, which should cause the higher LODs to be requested, as in this image:

It prints some logging information during that, along the lines of
[2021-02-06 23:36:40.959] [info] [TestCesium3DTilesIntegration.cpp:48] Camera at dvec3(0.000000, 0.000000, 100.000000)
[2021-02-06 23:36:43.461] [info] [Cesium3DTilesTestUtils.cpp:105] ViewUpdateResult:
          tilesToRenderThisFrame : 1
                                     ID c:/Develop/CesiumUnreal/Code/cesium-cpp/Data/Icospheres/icosphere0.b3dm error 3 height 1
  tilesToNoLongerRenderThisFrame : 0
         tilesLoadingLowPriority : 0
      tilesLoadingMediumPriority : 1
        tilesLoadingHighPriority : 0
                    tilesVisited : 1
                     tilesCulled : 0
                 maxDepthVisited : 0

[2021-02-06 23:36:43.462] [info] [TestCesium3DTilesIntegration.cpp:48] Camera at dvec3(0.000000, 0.000000, 20.000000)
[2021-02-06 23:36:45.968] [info] [Cesium3DTilesTestUtils.cpp:105] ViewUpdateResult:
          tilesToRenderThisFrame : 1
                                     ID c:/Develop/CesiumUnreal/Code/cesium-cpp/Data/Icospheres/icosphere0.b3dm error 3 height 1
  tilesToNoLongerRenderThisFrame : 0
         tilesLoadingLowPriority : 0
      tilesLoadingMediumPriority : 0
        tilesLoadingHighPriority : 0
                    tilesVisited : 1
                     tilesCulled : 0
                 maxDepthVisited : 0

[2021-02-06 23:36:45.969] [info] [TestCesium3DTilesIntegration.cpp:48] Camera at dvec3(0.000000, 0.000000, 10.000000)
[2021-02-06 23:36:48.485] [info] [Cesium3DTilesTestUtils.cpp:105] ViewUpdateResult:
          tilesToRenderThisFrame : 1
                                     ID c:/Develop/CesiumUnreal/Code/cesium-cpp/Data/Icospheres/icosphere0.b3dm error 3 height 1
  tilesToNoLongerRenderThisFrame : 0
         tilesLoadingLowPriority : 1
      tilesLoadingMediumPriority : 1
        tilesLoadingHighPriority : 0
                    tilesVisited : 3
                     tilesCulled : 0
                 maxDepthVisited : 2

[2021-02-06 23:36:48.485] [info] [TestCesium3DTilesIntegration.cpp:48] Camera at dvec3(0.000000, 0.000000, 3.000000)
[2021-02-06 23:36:51.013] [info] [Cesium3DTilesTestUtils.cpp:105] ViewUpdateResult:
          tilesToRenderThisFrame : 1
                                     ID c:/Develop/CesiumUnreal/Code/cesium-cpp/Data/Icospheres/icosphere2.b3dm error 1 height 3
  tilesToNoLongerRenderThisFrame : 1
         tilesLoadingLowPriority : 0
      tilesLoadingMediumPriority : 1
        tilesLoadingHighPriority : 0
                    tilesVisited : 4
                     tilesCulled : 0
                 maxDepthVisited : 3

showing that it indeed does request the highest LOD at some point. It does seem to skip the intermediate ones, though. I tried to figure out why, and printed the SSE for each step, but could not yet make sense of it... some more debug-stepping may be necessary here.

Is this something that could be worth being pursued further?

since we haven't worked on this, I will close the PR for now. But feel free to reopen it if it's necessary


Nearby screen flashes in a particular case when denying permission

Summary:
When the location permission is denied for the app in a specific way the app screen keeps flashing with the "Requesting Location Permission" dialog being visible.
Steps to reproduce:

Ensure the device's location is turned off
Use a fresh installation of the app
Log-in to the app
Tap on "Nearby".
You'll see the location permission request
Tap outside the permission dialog.
You're shown the location permission request again (twice). Tap on "Don't allow" in both cases.

System logs:
Let me know if this is necessary.
Device and Android version:
OnePlus Nord running Android 11
Commons app version:
3.1.1~1c9267ca0
Screen-shots:
Here's a screen recording:
https://user-images.githubusercontent.com/12448084/150677090-177d9b2d-1196-4223-8b79-5dc681eda369.mp4
Would you like to work on the issue?
Prefer not.

It's a problem that changes from device to device and is created by the system launcher of the device itself. My MIUI12 version of android works perfectly and doesn't cause any issue here

It's a problem that changes from device to device and is created by the system launcher of the device itself. My MIUI12 version of android works perfectly and doesn't cause any issue here

I'm confused. This bug speaks about screen flashing that happens with a sequence of actions that are all within the app. How does the system launcher come into picture here? 🤔

I don't observe this anymore (possibly after the fix for #5182). Do feel free to reopen if you observe it.


Out of memory on binary extract

fatal error: runtime: out of memory

runtime stack:
runtime.throw(0xca965f, 0x16)
	/usr/local/go/src/runtime/panic.go:774 +0x72
runtime.sysMap(0xc004000000, 0x1210000000, 0x1326c38)
	/usr/local/go/src/runtime/mem_linux.go:169 +0xc5
runtime.(*mheap).sysAlloc(0x130e300, 0x1210000000, 0x70109b, 0x1c0020f245)
	/usr/local/go/src/runtime/malloc.go:701 +0x1cd
runtime.(*mheap).grow(0x130e300, 0x908000, 0xffffffff)
	/usr/local/go/src/runtime/mheap.go:1252 +0x42
runtime.(*mheap).allocSpanLocked(0x130e300, 0x908000, 0x1326c48, 0x42cb5c)
	/usr/local/go/src/runtime/mheap.go:1163 +0x291
runtime.(*mheap).alloc_m(0x130e300, 0x908000, 0x7f3458be0100, 0x7f3456897980)
	/usr/local/go/src/runtime/mheap.go:1015 +0xc2
runtime.(*mheap).alloc.func1()
	/usr/local/go/src/runtime/mheap.go:1086 +0x4c
runtime.(*mheap).alloc(0x130e300, 0x908000, 0xc000010100, 0x7f34568c5180)
	/usr/local/go/src/runtime/mheap.go:1085 +0x8a
runtime.largeAlloc(0x1210000000, 0x1320001, 0x7f34568c5180)
	/usr/local/go/src/runtime/malloc.go:1138 +0x97
runtime.mallocgc.func1()
	/usr/local/go/src/runtime/malloc.go:1033 +0x46
runtime.systemstack(0x0)
	/usr/local/go/src/runtime/asm_amd64.s:370 +0x66
runtime.mstart()
	/usr/local/go/src/runtime/proc.go:1146

goroutine 44 [running]:
runtime.systemstack_switch()
	/usr/local/go/src/runtime/asm_amd64.s:330 fp=0xc0003bda58 sp=0xc0003bda50 pc=0x45a5e0
runtime.mallocgc(0x1210000000, 0xc0f900, 0x1, 0x4)
	/usr/local/go/src/runtime/malloc.go:1032 +0x895 fp=0xc0003bdaf8 sp=0xc0003bda58 pc=0x40df15
runtime.newarray(0xc0f900, 0x11000000, 0xc62f60)
	/usr/local/go/src/runtime/malloc.go:1173 +0x63 fp=0xc0003bdb28 sp=0xc0003bdaf8 pc=0x40e353
runtime.makeBucketArray(0xb8dc00, 0xc0003ec21c, 0x0, 0x4, 0xb5a1e0)
	/usr/local/go/src/runtime/map.go:362 +0x183 fp=0xc0003bdb60 sp=0xc0003bdb28 pc=0x40f243
runtime.makemap(0xb8dc00, 0x61633339, 0xc0003ec210, 0x1324c70)
	/usr/local/go/src/runtime/map.go:328 +0xf8 fp=0xc0003bdba8 sp=0xc0003bdb60 pc=0x40efd8
github.com/uber/jaeger-client-go.(*BinaryPropagator).Extract(0xc0002df170, 0xc7dac0, 0xc0003ec1e0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, ...)
	/go/pkg/mod/github.com/uber/jaeger-client-go@v2.25.0+incompatible/propagation.go:249 +0x393 fp=0xc0003bdcb8 sp=0xc0003bdba8 pc=0x8a67b3
github.com/uber/jaeger-client-go.(*Tracer).Extract(0xc000374000, 0xb58fe0, 0x12b2f20, 0xc7dac0, 0xc0003ec1e0, 0x1, 0x1, 0x0, 0x0)
	/go/pkg/mod/github.com/uber/jaeger-client-go@v2.25.0+incompatible/tracer.go:360 +0xe4 fp=0xc0003bddd8 sp=0xc0003bdcb8 pc=0x8b5494
	```

because it is an extract from binary, it's also possible that the binary was malformed and contained a size value that was too large (similar to the thrift bug we recently discovered)
https://github.com/jaegertracing/jaeger-client-go/blob/9a2c34e98c9fcaeb7f124edf0ed60e072d290414/propagation.go#L243-L249
We could add a check if that number is greater than say 128 (which iirc is the limit that W3C imposes on the number of baggage entries) and fail the parsing, but it's unlikely to precisely catch malformed binary headers

because it is an extract from binary, it's also possible that the binary was malformed and contained a size value that was too large (similar to the thrift bug we recently discovered)
https://github.com/jaegertracing/jaeger-client-go/blob/9a2c34e98c9fcaeb7f124edf0ed60e072d290414/propagation.go#L243-L249
We could add a check if that number is greater than say 128 (which iirc is the limit that W3C imposes on the number of baggage entries) and fail the parsing, but it's unlikely to precisely catch malformed binary headers

My os was not under low memory issue. I will try to do an exemple to reproduce it. I seem to happen when I try to extract binary content from carrier which not contains any jaeger informations. I will check @yurishkuro. I am interested by thrift bug you disvovered.

My os was not under low memory issue. I will try to do an exemple to reproduce it. I seem to happen when I try to extract binary content from carrier which not contains any jaeger informations. I will check @yurishkuro. I am interested by thrift bug you disvovered.

https://github.com/apache/thrift/pull/2292

https://github.com/apache/thrift/pull/2292

Are you using Tracer().Inject() by any chance?
We just had the issue on one of our binary where opentracing.SetGlobalTracer(tracer) was not called, making our span a noopSpan and therefore not injecting the proper binary data before our payload. When the payload was read by our worker using the Extract() function, the Extract() was actually reading binary inside our payload making a very large memory allocation resulting in an OOM.

Have the same problem https://github.com/nats-io/not.go/issues/6

Similar issue on the server side when receiving spans https://github.com/jaegertracing/jaeger/issues/2638. We're going to use a patched version of Thrift on the server.
Since client has explicit code for parsing binary header, one simple fix is to do what Thrift did and just have an upper bound for the size param being read from incoming request - values larger than the limit should be treated as invalid header. The threshold could be configurable if necessary.

Having an upper bound would fix the out-of-memory but it won't prevent the Extract() function from reading garbage and possibly creating random, unrelated, traces.

https://github.com/jaegertracing/jaeger-client-go/pull/529 must fix your problem. Waiting for version bump

2.26 was released


Decoupled waitForFundingConfirmation with channel announcement

This PR is not complete.  This PR should fix #305.
My main concerns:

If I decoupled waitForFundingConfirmation into waitForFundingConfirmation and announceChannelAfterConfirmations correctly.  I use a new chan *chainntnfs.TxConfirmation to pass confirmation details to the latter function once the funding tx is confirmed.

The issue mentions waiting until the funding transaction has at least 6 confirmations.  If the user's *fundingConfig.NumRequiredConfs function gives less than 6 confirmations, should waitForFundingConfirmation wait for max(numConfs, 6) confirmations?  And what if the user specifies greater than 6 confirmations?

That said, all of the tests in fundingmanager_test.go pass.

Thanks for the comments, especially re: confirmations stuff.  I was a bit confused by the mention of confirmations for different messages, but I get it now.  I'm going to rework it and update the PR today most likely.

I believe that I have successfully decoupled waitForFundingConfirmation from the channel announcement.  Adding the channel to the ChannelRouter immediately after the fundingLocked message has been sent is still TODO.
I still have some concerns:

Do I need to wait for 6 confirmations here before sendChannelAnnouncement is called (https://github.com/lightningnetwork/lnd/blob/master/fundingmanager.go#L461)?

As I was testing my new code with the TestFundingManagerNormalWorkflow test in fundingmanager_test.go, it did not pass successfully.  It was not until I duplicated lines 531 & 532, and adjusted mockNotifier.confChannel to have a capacity of 2 that the test worked (https://github.com/lightningnetwork/lnd/blob/master/fundingmanager_test.go#L531).  Looking [here] (https://github.com/lightningnetwork/lnd/blob/master/chainntnfs/interface.go#L33), I noticed that the tuple (txid, numConfs) had to be identical for it to be dispatched to ALL clients.  However, I tried setting numConfs in waitForFundingConfirmation to 6, but this still resulted in failure.

My recent changes also include the first steps to a fix for issue #306.  I added ChannelFlags to the OpenChannel struct and have specific methods for putting, fetching, & deleting ChannelFlags in channel.go.

Immediately after the FundingLocked message is sent, a *LightningNode is added to the ChannelRouter.  I have several TODOs left such as a command-line option for channelFlags / "stealth channel", and handling confirmations here.

My main obstacle that I must tackle before this is completed is that to have a functional channel graph where users can send payments to one another, both edges in a channel must be defined.  Channels are bidirectional.  It is trivial to send OUR data (ChannelEdgeInfo & ChannelEdgePolicy) to the ChannelRouter before any announcements are made.  However, it is not trivial to send our peer's ChannelEdgePolicy to the ChannelRouter before announcements happen.  Is some sort of exchange of ChannelEdgePolicys made at the TODO here?
Additionally, what channel info is added in the case of ChannelFlags LSB being set to 0 and when it's set to 1?  Do we need to add our peer's ChannelEdgePolicy when the LSB is 1 (since it will get added anyways during the announcement phase...)?  In the case of the LSB being 0, I'm thinking that ChannelEdgeInfo, ChannelEdgePolicy, our peer's ChannelEdgePolicy must all be added at that TODO.

@halseth suggested splitting this PR into multiple PRs.  The current PR now only contains the decoupling of sending the fundingLocked message and the sending of the channel announcement from waitForFundingConfirmation.

fad92ce is a merge. I think it might be preferred to rebase onto master instead (https://github.com/lightningnetwork/lnd/blob/master/docs/code_contribution_guidelines.md#53-acceptance).


Getters that use route are not working properly in setup stores

Reproduction
https://codesandbox.io/p/sandbox/sad-lake-cjxzvt?file=/stores/test.ts:10,6
Steps to reproduce the bug

Visit the reproduction link
Click on any /?id=1..n button to change the id value on the route URL.
The value of currentData getter is updated correctly ✅
Click the /home link.
At the home page, click on any /?id=1..n button to navigate back to the index page.
Repeat step no. 2, but this time, the value of getter will not be updated ❌

Expected behavior
The Getter value should be updated same as before.
Actual behavior
The Getter value not updated after navigating.
Additional information

This happen when navigate to the page in client side. If you enter the page from URL, the getter still working.
If I turn of the ssr from the nuxt config. And move the useRoute statement inside the computed/getter, it works.

- const route = useRoute();
  const currentData = computed(() => {
+   const route = useRoute();
    const index = Number(route.query.id || 1);
    return data.value[index];
  });

However this code never working on server side, cuz the useRoute() is call outside the setup context.

You need to update the version of the packages you are using, namely pinia, its Nuxt plugin and ensure you are using Vue 3.3 (Nuxt should be already be doing this)

@posva Thanks for replying.
I did upgraded the<EMAIL_ADDRESS><EMAIL_ADDRESS>vue was 3.3.4 already. All the packages are now latest version, but the bug still happen. This issue should not been closed.

I tried locally just in case but it works correctly. Could be something with Codesandbox.

@posva You are right, it works on local in dev mode. However, it's not working in production build.
please run following commands and reproduce
npx nuxi generate
npx nuxi preview

It seems to only happen in Nuxt context with the automatic import of useRoute(), adding a manual import from vue-router fixes it:
import { useRoute } from 'vue-router'

You should report this to the Nuxt team


Can I use cameraextension with C++?

Hi,
From my understanding cameraextension , as its name suggests, is the one that handles low level stuff and I don't need to make changes on this part. My problem is I simply want to read a video frame by frame and push them to virtual camera. However, I need to do this because in C++ because I will do some operations on the frame and my framework is written in C++. I have a few questions, just to confirm:

Does cameraextension creates a virtual camera such as width, height, format etc. and has nothing to do with client side(zoom etc). It just creates a virtual camera and sends the incoming frame to whatever app wants at that moment.

The way you push the frame to virtual camera from samplecamera. Should I call enqueue function for each frame? Assume I successfully converted the code in C++ read frames from hardware camera, then after reading and operation I will call enqueue function with my result frame and it will call virtual camera and frame will be shown on the screen, cycle completed. Am I right?

 Writing one frame takes 500ms so around 2FPS, which is terrible. Have you made any test to estimate performance..

Thanks a lot!
Halil

Hi @halilkarab
The performance is good (I use this exact code for my macOS app Screegle)

yes the camera extension can be called to create a virtual camera. at the moment these parameters are fixed in Config
in your main code (not the extension), you create the virtual camera, see here
you then connect to this camera using code from connectToCamera
In that code you'll see initSink called. This is where we create the sink queue, used by our main code to enqueue the frames.
In the same code, a timer fires at 30 FPS to enqueue frames. Notice that it checks the readyToEnqueue flag because we don't want to enqueue too many frames. This logic could probably be changed since more than one frame could potentially be enqueued.

Hope this helps.

Thanks a lot! Also do you think that can camerasample example be written in C++? I think that I don't need to convert cameraextension itself to C++, but will I be able to communicate with the virtual camera from C++?

I believe to because the Swift version uses the low level APIs to access the camera sink anyway.

So, now I have another question. What if I want to just create a virtual camera not use the samplecamera, what happens to it. I mean can I do that, if so can you please explain. I am not familiar with Swift and it is compelling to translate the code that I don't know what it does.  I hope I am not bothering you, thanks a lot.

okey. i almost done it, the only problem is how should i deactivate all the virtual cameras? for example now i have 1 activaetd camera and 1 physical usb cam, but it seems i  have 3 cameras on the extension. (my computer crashed during a test and i couldnt deactivate it had to turn off by pressing power button)

Hi! You might need to reset your virtual cameras following these steps
https://gist.github.com/ldenoue/ec4f1b5d2196835ba89de2020fd4ed7a


Monitor a single file on a single device

Monitor a single file on a single device, trigger the output if the input changes.
If we can do this simple setup, it should be easy to extend to other, more involved cases.
Setup; steps:

monitor a single file via the sysfs interface; run in a dedicated thread, communicate over a channel
take the event and have it a call another service that toggles the output file

We can extend this later on with e.g.:

a config in yaml format
entity models to capture the format
go beyond a single device
...


Improve JSON serialization flexibility

Currently JSON serialization does not handle the ubiquitous datetime. I believe Flask's jsonify does.
It would be beneficial for the json method to handle serializing datetimes for the developer and avoid asking them to do handle this transformation logic themselves.

In v0.2.0 the Flask "jsonify" JSON serialization method (dumps) is imported and used.


Add visual feedback to resource delete button.

The current resource delete button does not show any visual feedback for mouse hover, click events. Also the delete action does not seems noticeable.

This behavior is changed in AM 3.0.0 beta. now there is an option to undo this.  saving it to the api is done at the end. (not during the resource removing time)


Update Post “jamaica-blue”

Automatically generated by Netlify CMS

👷 Deploy Preview for chic-shortbread-66a66b processing.

Name
Link

🔨 Latest commit
4bff11b2421ff93f934b740e93d5a64338501b7a

🔍 Latest deploy log
https://app.netlify.com/sites/chic-shortbread-66a66b/deploys/65487c838b76bb00089f8df5


housekeeping after 145

Now that #145 is merged combinators can follow.

All combinators taking &mut self should imply Self: Pin.
Trait bounds are to Stream
Cleans up docs and Debug derives.

bors r+


release: update manifest and helm charts for v1.2.1

update manifest and helm charts for v1.2.1

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 51.66%. Comparing base (cc6040e) to head (410477c).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1279   +/-   ##
=======================================
  Coverage   51.66%   51.66%
=======================================
  Files          53       53
  Lines        2938     2938
=======================================
  Hits         1518     1518
  Misses       1378     1378
  Partials       42       42

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


[Core][Perf] General performance optimizations needed

Slow as hell on rMBP / Safari. It provides very bad user experience.
Anything we can do about it?

@jfbaro @paulmillr can you guys test it again with this changes? I'd love your feedback.

I was testing the demo website from my nexus 6 and is a bit lagged...
Specially the sliders and menus.

@krik thanks for video, it Does seem whacky on Mobile. I opened demo page on iPhone, and it seems like the buttons are getting clicked twice...

Hi...maybe naive question here.
What is the purpose of recursive settimeout call to _pulsate in focus-ripple?
On an older android (Chrome on Samsung S3), I noticed that for any list (using ListItem) the scroll bar would flash over and over, as if the page was resizing a bit, again over and over.
On desktop, if you inspect a list you can see in Chrome all the ripple elements flashing in Dev Tools, one per ListItem. You can see this here inspecting a row: http://material-ui.com/#/components/lists
here is the call: https://github.com/callemall/material-ui/blob/b755b19a6652f9b484e0211f1c186b5acae6cfb5/src/ripples/focus-ripple.jsx#L107
If I disable this line locally (comment out), this scroll bar flashing effect goes and the list is a bit smoother.
But I don't see any noticeable UI change disabling this recursive pulsate.
Anyone understand the need for the recursive settimeout pulsate call?

@michelob This is to animate the keyboard focus ripple. I recently added a fix that would only render focus ripples if the component had keyboard focus - seen here: https://github.com/callemall/material-ui/commit/0f61f9e081c99137cd6f8cc4e29b282a9a9d7045. This fix will go up in the next release, and the problem you're describing will go away.

@hai-cea nice!
I also see 10.2 is up. I've taken that and see improvements especially with leftnav. Thank you!

Most of demos are slow in Chrome

@hai-cea In 0.10.4, and as reported above at various moments, ripple animations are still slow on Mobile Safari. Interestingly, in 0.10.1, they are silky smooth (!) on my iDevices.
I am using the exact same code for my application, only switched out versions. For now, I'm reverting to 0.10.1 but wouldn't mind seeing a more permanent solution. ;-)

Found the cause of this issue pretty quickly. TouchRipple listens to both onTouch and onMouse events. Problem is that Mobile Safari usually fires onMouseDown after onTouchEnd. This usually, but not always, generates two distinctly different ripples.
To prevent this, there is some logic in TouchRipple's start() function to prevent double firing of these CircleRipples, but it doesn't function well on Mobile Safari:
    if (!isRippleTouchGenerated) {
      for (var i = 0; i < ripples.length; i++) {
        if (ripples[i].props.touchGenerated) return;
      }
    }

A quick timeline of what happens (most of the time) on Mobile Safari:

touch event fires; start() is called on the TouchRipple. CircleRipples are added in an immutable array into the components' state. Each CircleRipple obj has a prop containing "isTouchGenerated" which is, I assume, supposed to prevent these "double" ripples.
the ripple effect finishes a bit later and TouchRipple's end() function is called. This removes the CircleRipple array from TouchRipple's state.
mobile safari fires onMouseDown. TouchRipple's start() function checks for existing ripples, but since these have already finished, none are found. A new set of CircleRipples is generated.

I worked around this for now by calling e.preventDefault() at the end of start() but this is of course just a stopgap solution. I can't commit the time for a proper fix right now so just wanted to share this.
Note that this is a little trickier to debug due to event propagation not working well while using breakpoints.

is this still an issue? Seems ok on iphone 6. however, the ripples are firing twice, i assume because the second time is ontouchup

same problem still..

@arush You're right; firing twice is an issue on iOS, see my previous posts. I have another quick fix running but it is not applicable for general production purposes outside our use cases, so I won't run it through a PR at this time.

@hilkeheremans did you manage to figure out why 0.10.1 is so much smoother?

@hilkeheremans FYI I have submitted a pull request to fix the issue of double ripple (due to compat mouse down firing, as you say).

for me it was so slow, that i have implemented some components myself. If you would turn on chrome's dev option: flash on redraw, you will see, that most animations are causing to redraw random stuff that are not connected to clicked on. I've noticed flashing on left top conner all the time with material-ui.com text fields and some other animated elements.
You can see slowness causes in action: https://www.youtube.com/watch?v=S9bciD20u8Q
Just don't make your animations cause global redraws and it will already be a lot faster. At least it helped me. You can see production-ready app with material-ui and react here: http://arcchat.com/
it's fast now.

You can see production-ready app with material-ui and react here: http://arcchat.com/

We''d love if you could submit a PR to add that to the showcase! :heart:

it's fast now.

Any help you can give with improving Material-Ui performance based on your experience would be appreciated!! :+1:

Main thing is to animate things without page repaints, just open dev console (chrome) and click esc. select "rendering" and check "enable pant flashing"

and then go test your site's animations. Remove all the things that cause repaints and it will be a lot faster. Of course, if you have less DOM elements, you should not "feel" anything, but when i do have some DOM elements + several iframes and those iframes begin to repaint because user clicked some text field or icon with ripple it becomes an issue.
Here's live demo. Go to docs:
http://www.material-ui.com/#/components/text-field
enable that flashing option and click on text field, click somewhere else, click on text again. Notice flashing on left top corner? Waaay out of text field? That flashing makes some DOM elements to repaint and that causes slowness for all app.
I really like this lib, it's best what i could found. It had terrible documentation, but i see it's getting better now. I had no time to submit PR for every issue i had on the way, just cloned copy of whatever newest version was available (it happened to be v0.13.4) and built with it, so i can't really share my code, it's coupled with my app. You can see some code here: https://github.com/callemall/material-ui/issues/3295 with my fixes for dialog component.
Thanks for inviting to showcase, I'll make PR :+1:

I really like this lib, it's best what i could found.

Thanks to the contributions of many talented individuals. :+1: This project is almost entirely volunteer run.

I had no time to submit PR for every issue i had on the way

Well if you do ever have a chance to contribute it would be appreciated.  It wont improve by itself. :wink:

I've been attempting to use react and material-ui in an Electron (chromium) based app to remake my player with better tech.
My player renders the video on a <canvas> with .requestAnimationFrame() at 24 fps (usually, depending on the video) and whenever I click any material-ui element and a CSS animation begins the FPS of the entire app drops like it got hit by a bomb.
I've done numerous tests by overwriting the transition effect of the entire app to none, tested using the material-ui elements again (this time with no css effects) and the issue was gone.
Decreasing the transition FPS with steps also improved the performance a lot, but overwriting transition for the entire app is definitely not a usable solution..
I also found a video that largely resembles my own findings when testing with a .requestAnimationFrame() FPS meter and Chrome's internal FPS meter:
http://greensock.com/css-performance
The article is vast and it includes comments by @paulirish (from chrome, I'm really sorry for pinging you but I'm also hoping that you might be the right person to shed some light on this 1.5 year old performance issue on an amazingly popular CSS framework).
The issue (as the author of that article mentions) is related to CSS animations on nested elements:

When nesting could be avoided, pure CSS animation of only transforms did appear smoother on webkit browsers under heavy pressure and it was basically indistinguishable from optimized JS animations under all other levels of pressure.

Thank you for all the great work your doing here, I really hope to see the animations optimized for performance at one point, as in it's current state it is unusable to me in a video player as stuttering and freezes lead to a very bad UX.

@jaruba if you want to capture a timeline recording, i'd be able to spot what's happening a lot easier: https://www.chromium.org/devtools/capturing-a-timeline-trace

@paulirish definitely!
http://powder.media/timeline_recordings.zip
The archive includes timeline recordings of various actions, some of which (like clicking a toggle switch) should obviously not create stutters, although all do, some more then others.
Thanks so much for answering, and sorry again for dragging you into this..

I'm also a bit baffled by the mixed signals I am getting about material-UI in a new project. It is by far the most popular material framework specifically for React (17k + stars) yet I keep running into people complaining about performance being sub-par. Is the performance only an issue in specific cases where for example more than x amounts of a specific component is used with animations, cases that might be avoided? In that case it might be handy to have some kind of 'use material-ui for these kind of applications but avoid it for that kind of applications because of the performance issues that will occur" ?
Because it would seem strange that a framework with performance issues would be so popular?
Anyone care to shed some light on this?
The framework looks great but I would like to prevent having to switch over to a different framework because of performance issues half-way in a project.
Kind regards,

@jeroennelen wait for 0.16

@nathanmarks do you happen to know what the timeline is looking like for 0.16?
I would love to use this library, but it's extremely slow on my phone

I really loved Material-UI the moment I came across it and immediately decided to try it out for my first React-based app. Unfortunately, I went too far with it, before discovering the performance issues around the List component. When the page has more than 30 odd items in the List, the performance lag starts to become noticeable, particularly on the mobile (iP6+). Above 100 items, the list becomes almost unusable on the mobile.
The performance problem exists even if I'm using a simple grid of 50 Buttons (5 buttons x 10 rows). It's a bummer that such a stunning framework has huge performance issues.
@JeroenNelen if an application relies on lists or a grid of components with more than 50 items, stay away until the performance issues are fixed.
Moreover, the touch tap still fires 2 events (as discussed earlier on the thread). In my application, tapping on the first list item brings up another list. But due to double firing of events on the first tap, it records a click on the second list also and the entire flow messes up.
I'm really hoping that 0.16 would address some of these issues. Looking forward to it.

now I use this lib to launch faster and then replacing elements with basic
versions that I write myself to have same look and a lot less event
handlers and dom elements. buttons, switch, table, input, icon, fab were
already redone. this is great framework, but please check performance of
all elements.. add some CSS file, it's OK to use CSS when it's performance
is so much better e.g. for such events as hover. you don't have to support
old crappy IEs anymore, you can do a lot with CSS faster then JS, leaving
JS busy with all react stuff
On Jul 30, 2016 08:08, "deepfriedbrain"<EMAIL_ADDRESS>wrote:

I really loved Material-UI the moment I came across it and immediately
decided to try it out for my first React-based app. Unfortunately, I went
too far with it, before discovering the performance issues around the List
component. When the page has more than 30 odd items in the List, the
performance lag starts to become noticeable, particularly on the mobile
(iP6+). Above 100 items, the list becomes almost unusable on the mobile.
The performance problem exists even if I'm using a simple grid of 50
Buttons (5 buttons x 10 rows). It's a bummer that such a stunning framework
has huge performance issues.
@JeroenNelen https://github.com/JeroenNelen if an application relies on
lists or a grid of components with more than 50 items, stay away until the
performance issues are fixed.
Moreover, the touch tap still fires 2 events (as discussed earlier on the
thread). In my application, tapping on the first list item brings up
another list. But due to double firing of events on the first tap, it
records a click on the second list also and the entire flow messes up.
I'm really hoping that 0.16 would address some of these issues. Looking
forward to it.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/callemall/material-ui/issues/42#issuecomment-236343340,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ACm3Jsnpjuz0vWaKIOcCyvM8ogQoDaZVks5qatxAgaJpZM4C5Mwh
.

@deepfriedbrain I too wish I knew and considered that when I used this library.
I'm almost finished writing all the basic functionality. But I have two 409 row tables containing 1632 radio buttons each.

@dantman In the next version I'm looking into creating a material data grid with virtualized scrolling (in addition to a regular table, which will also be more performant than the current with checkboxes etc)

I'm using react, redux and material-ui (v0.15.4) with Cordova. Grid and List performance on iOS is really a killer for the framework. Even scrolling seems to be a big issue, while quite acceptable on Android it is horrible on iOS.
Focusing on performance  improvement should be really a high priority.

@bardu
This is in progress

Looking forward to any improvements in this area. We have a fairly simple form, but just tabbing through it entering values is very noticeably sluggish. Example: enter "200" in one textbox, press tab, enter "300" in the next one: tab takes half a second (!), so the first couple of digits of "300" are swallowed.

@nathanmarks is there any way to see an ETA or timeline for version 16? (would be nice to know if we're talking about weeks/months/years)
Kind regards and thanks for the hard work!

@jeroencoumans 0.16.0 is going to be a regular release for some other breaking changes very soon. next will come in a couple of months.

Simulator IOS animations look fine in my app.  Very responsive on text box tabbing.  Not sure if the simulator is throttling a slower CPU though to a true iphone 4s for the slowest experience.  I sold my iphone 4s which is very slow on most web pages in safari.
Clicking buttons is also extremely fast with the highlight animation onclick of a raised button.

Sorry to barge in like that, but do you plan to replace the inline styles with CSS in the next version? I could not find a road map for the version labeled next..

@kenjiru You can read about it here
Next version seems to be using JSS

I'm closing. I think that the #5868 as well has the new styling approach of the next branch is addressing the overall issue.


GPL: generating different results when using multiple threads

Describe the bug
In PR https://github.com/The-OpenROAD-Project/OpenROAD/pull/5357, I notice that when moving set_thread_count [exec getconf _NPROCESSORS_ONLN] to the beginning of the flow.tcl script, the results started to change, leading to metric failures in the CI. Specifically, the first tool with divergence was GPL.
Note: the divergence didn't happen in every pipeline. The PR-head pipeline failed, but the PR-merge was passing. So, this might be platform-dependent.
Expected Behavior
GPL results should not change when using multi threading.
Environment
Git commit: 12dc4c35131fcfd7dc3a4dfb3963ae45479b502a
kernel: Linux 6.5.0-1023-gcp
os: Ubuntu 22.04.4 LTS (Jammy Jellyfish)
cmake version 3.24.2
-- The CXX compiler identification is GNU 11.4.0
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Check for working CXX compiler: /usr/bin/c++ - skipped
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- OpenROAD version: v2.0-14495-g12dc4c351
-- System name: Linux
-- Compiler: GNU 11.4.0
-- Build type: RELEASE
-- Install prefix: /usr/local
-- C++ Standard: 17
-- C++ Standard Required: ON
-- C++ Extensions: OFF
-- The C compiler identification is GNU 11.4.0
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Check for working C compiler: /usr/bin/cc - skipped
-- Detecting C compile features
-- Detecting C compile features - done
-- Found Python: /usr/bin/python3.10 (found version "3.10.12") found components: Interpreter
-- Performing Test CMAKE_HAVE_LIBC_PTHREAD
-- Performing Test CMAKE_HAVE_LIBC_PTHREAD - Success
-- Found Threads: TRUE
-- Performing Test C_COMPILER_SUPPORTS__-Wall
-- Performing Test C_COMPILER_SUPPORTS__-Wall - Success
-- Performing Test CXX_COMPILER_SUPPORTS__-Wall
-- Performing Test CXX_COMPILER_SUPPORTS__-Wall - Success
-- Performing Test C_COMPILER_SUPPORTS__-Wno-array-bounds
-- Performing Test C_COMPILER_SUPPORTS__-Wno-array-bounds - Success
-- Performing Test CXX_COMPILER_SUPPORTS__-Wno-array-bounds
-- Performing Test CXX_COMPILER_SUPPORTS__-Wno-array-bounds - Success
-- Performing Test C_COMPILER_SUPPORTS__-Wno-nonnull
-- Performing Test C_COMPILER_SUPPORTS__-Wno-nonnull - Success
-- Performing Test CXX_COMPILER_SUPPORTS__-Wno-nonnull
-- Performing Test CXX_COMPILER_SUPPORTS__-Wno-nonnull - Success
-- Performing Test C_COMPILER_SUPPORTS__-Wno-maybe-uninitialized
-- Performing Test C_COMPILER_SUPPORTS__-Wno-maybe-uninitialized - Success
-- Performing Test CXX_COMPILER_SUPPORTS__-Wno-maybe-uninitialized
-- Performing Test CXX_COMPILER_SUPPORTS__-Wno-maybe-uninitialized - Success
-- Performing Test C_COMPILER_SUPPORTS__-Wno-format-overflow
-- Performing Test C_COMPILER_SUPPORTS__-Wno-format-overflow - Success
-- Performing Test CXX_COMPILER_SUPPORTS__-Wno-format-overflow
-- Performing Test CXX_COMPILER_SUPPORTS__-Wno-format-overflow - Success
-- Performing Test C_COMPILER_SUPPORTS__-Wno-unused-variable
-- Performing Test C_COMPILER_SUPPORTS__-Wno-unused-variable - Success
-- Performing Test CXX_COMPILER_SUPPORTS__-Wno-unused-variable
-- Performing Test CXX_COMPILER_SUPPORTS__-Wno-unused-variable - Success
-- Performing Test C_COMPILER_SUPPORTS__-Wno-unused-function
-- Performing Test C_COMPILER_SUPPORTS__-Wno-unused-function - Success
-- Performing Test CXX_COMPILER_SUPPORTS__-Wno-unused-function
-- Performing Test CXX_COMPILER_SUPPORTS__-Wno-unused-function - Success
-- Performing Test C_COMPILER_SUPPORTS__-Wno-write-strings
-- Performing Test C_COMPILER_SUPPORTS__-Wno-write-strings - Success
-- Performing Test CXX_COMPILER_SUPPORTS__-Wno-write-strings
-- Performing Test CXX_COMPILER_SUPPORTS__-Wno-write-strings - Success
-- Performing Test C_COMPILER_SUPPORTS__-Wno-sign-compare
-- Performing Test C_COMPILER_SUPPORTS__-Wno-sign-compare - Success
-- Performing Test CXX_COMPILER_SUPPORTS__-Wno-sign-compare
-- Performing Test CXX_COMPILER_SUPPORTS__-Wno-sign-compare - Success
-- Performing Test C_COMPILER_SUPPORTS__-Wno-deprecated
-- Performing Test C_COMPILER_SUPPORTS__-Wno-deprecated - Success
-- Performing Test CXX_COMPILER_SUPPORTS__-Wno-deprecated
-- Performing Test CXX_COMPILER_SUPPORTS__-Wno-deprecated - Success
-- Performing Test C_COMPILER_SUPPORTS__-Wno-c++11-narrowing
-- Performing Test C_COMPILER_SUPPORTS__-Wno-c++11-narrowing - Failed
-- Performing Test CXX_COMPILER_SUPPORTS__-Wno-c++11-narrowing
-- Performing Test CXX_COMPILER_SUPPORTS__-Wno-c++11-narrowing - Failed
-- Performing Test C_COMPILER_SUPPORTS__-Wno-register
-- Performing Test C_COMPILER_SUPPORTS__-Wno-register - Failed
-- Performing Test CXX_COMPILER_SUPPORTS__-Wno-register
-- Performing Test CXX_COMPILER_SUPPORTS__-Wno-register - Success
-- Performing Test C_COMPILER_SUPPORTS__-Wno-format
-- Performing Test C_COMPILER_SUPPORTS__-Wno-format -CMake Warning (dev) at src/sta/CMakeLists.txt:33 (option):
  Policy CMP0077 is not set: option() honors normal variables.  Run "cmake
  --help-policy CMP0077" for policy details.  Use the cmake_policy command to
  set the policy and suppress this warning.

  For compatibility with older versions of CMake, option is clearing the
  normal variable 'USE_TCL_READLINE'.
This warning is for project developers.  Use -Wno-dev to suppress it.

 Success
-- Performing Test CXX_COMPILER_SUPPORTS__-Wno-format
-- Performing Test CXX_COMPILER_SUPPORTS__-Wno-format - Success
-- Performing Test C_COMPILER_SUPPORTS__-Wno-reserved-user-defined-literal
-- Performing Test C_COMPILER_SUPPORTS__-Wno-reserved-user-defined-literal - Failed
-- Performing Test CXX_COMPILER_SUPPORTS__-Wno-reserved-user-defined-literal
-- Performing Test CXX_COMPILER_SUPPORTS__-Wno-reserved-user-defined-literal - Failed
-- Performing Test C_COMPILER_SUPPORTS__-fpermissive
-- Performing Test C_COMPILER_SUPPORTS__-fpermissive - Failed
-- Performing Test CXX_COMPILER_SUPPORTS__-fpermissive
-- Performing Test CXX_COMPILER_SUPPORTS__-fpermissive - Success
-- Performing Test C_COMPILER_SUPPORTS__-x
-- Performing Test C_COMPILER_SUPPORTS__-x - Failed
-- Performing Test CXX_COMPILER_SUPPORTS__-x
-- Performing Test CXX_COMPILER_SUPPORTS__-x - Failed
-- Performing Test C_COMPILER_SUPPORTS__c++
-- Performing Test C_COMPILER_SUPPORTS__c++ - Failed
-- Performing Test CXX_COMPILER_SUPPORTS__c++
-- Performing Test CXX_COMPILER_SUPPORTS__c++ - Failed
-- Performing Test C_COMPILER_SUPPORTS__-std=c++17
-- Performing Test C_COMPILER_SUPPORTS__-std=c++17 - Failed
-- Performing Test CXX_COMPILER_SUPPORTS__-std=c++17
-- Performing Test CXX_COMPILER_SUPPORTS__-std=c++17 - Success
-- Performing Test C_COMPILER_SUPPORTS__-Wno-unused-but-set-variable
-- Performing Test C_COMPILER_SUPPORTS__-Wno-unused-but-set-variable - Success
-- Performing Test CXX_COMPILER_SUPPORTS__-Wno-unused-but-set-variable
-- Performing Test CXX_COMPILER_SUPPORTS__-Wno-unused-but-set-variable - Success
-- TCL library: /usr/lib/x86_64-linux-gnu/libtcl.so
-- TCL header: /usr/include/tcl/tcl.h
-- TCL readline library: /usr/lib/x86_64-linux-gnu/libtclreadline.so
-- TCL readline header: /usr/include/x86_64-linux-gnu
-- Found SWIG: /usr/local/bin/swig (found suitable version "4.1.0", minimum required is "4.0")
-- Using SWIG >= 4.1.0 -flatstaticmethod flag for python
-- Found Boost: /usr/local/lib/cmake/Boost-1.80.0/BoostConfig.cmake (found version "1.80.0")
-- boost: 1.80.0
-- Found Python3: /usr/include/python3.10 (found version "3.10.12") found components: Development Development.Module Development.Embed
-- Found ZLIB: /usr/lib/x86_64-linux-gnu/libz.so (found version "1.2.11")
-- spdlog: 1.8.1
-- Found BISON: /usr/bin/bison (found version "3.8.2")
-- Could NOT find Doxygen (missing: DOXYGEN_EXECUTABLE)
-- STA version: 2.5.0
-- STA git sha: 1c7f022cd0a02ce71d047aa3dbb64e924b6efbd5
-- System name: Linux
-- Compiler: GNU 11.4.0
-- Build type: RELEASE
-- Build CXX_FLAGS: -O3 -DNDEBUG
-- Install prefix: /usr/local
-- Found FLEX: /usr/bin/flex (found version "2.6.4")
-- TCL library: /usr/lib/x86_64-linux-gnu/libtcl.so
-- TCL header: /usr/include/tcl/tcl.h
-- SSTA: 0
-- Found SWIG: /usr/local/bin/swig (found suitable version "4.1.0", minimum required is "3.0")
-- STA executable: /home/emonteiro_openroad_tools/OpenROAD/src/sta/app/sta
-- Found re2: /opt/or-tools/lib/cmake/re2/re2Config.cmake (found version "9.0.0")
-- Found Clp: /opt/or-tools/lib/cmake/Clp/ClpConfig.cmake (found version "1.17.7")
-- Found Cbc: /opt/or-tools/lib/cmake/Cbc/CbcConfig.cmake (found version "2.10.7")
-- Found SCIP: /opt/or-tools/lib/cmake/scip/scip-config.cmake (found version "8.0.1")
-- Found OpenMP_CXX: -fopenmp (found version "4.5")
-- Found OpenMP: TRUE (found version "4.5")
-- GPU is not enabled
-- TCL library: /usr/lib/x86_64-linux-gnu/libtcl.so
-- TCL header: /usr/include/tcl/tcl.h
-- Found OpenMP_C: -fopenmp (found version "4.5")
-- Found OpenMP: TRUE (found version "4.5")
-- Found OpenMP: TRUE (found version "4.5")
-- GUI is enabled
-- Charts widget is not enabled
-- Found Boost: /usr/local/lib/cmake/Boost-1.80.0/BoostConfig.cmake (found version "1.80.0") found components: serialization
-- Could NOT find VTune (missing: VTune_LIBRARIES VTune_INCLUDE_DIRS)
-- Found Boost: /usr/local/lib/cmake/Boost-1.80.0/BoostConfig.cmake (found suitable version "1.80.0", minimum required is "1.78")
-- TCL library: /usr/lib/x86_64-linux-gnu/libtcl.so
-- TCL headeNumber of processor cores: 32
r: /usr/include/tcl/tcl.h
-- Found Boost: /usr/local/lib/cmake/Boost-1.80.0/BoostConfig.cmake (found version "1.80.0") found components: serialization system thread
-- Found Boost: /usr/local/lib/cmake/Boost-1.80.0/BoostConfig.cmake (found version "1.80.0")
-- Found Eigen3: /usr/local/share/eigen3/cmake/Eigen3Config.cmake (found version "3.4.1")
-- TCL readline enabled
-- Tcl Extended disabled
-- Python3 enabled
-- Configuring done
-- Generating done
-- Build files have been written to: /tmp/tmp.zROPCN1K8L

To Reproduce
Use the regression tests of the OpenROAD repository, specifically:

aes_sky130hd
ibex_sky130hd
jpeg_sky130hd

Relevant log output
No response
Screenshots
No response
Additional Context
No response

Fixed in OR https://github.com/The-OpenROAD-Project/OpenROAD/pull/5512, and enabled gpl multi-threading in ORFS  https://github.com/The-OpenROAD-Project/OpenROAD-flow-scripts/pull/2217


Generate Sbom for VS insertion

Summary of the changes

Generate SBOM for vs insertions

Fixes:
Test -> https://dnceng.visualstudio.com/internal/_build/results?buildId=1834982&view=results

@allisonchou

/azp run

/azp run

Taking a look

Why is the CI still waiting?

/azp run

@epananth It looks like CI is running into the same problem as before: https://dev.azure.com/dnceng/public/_build/results?buildId=1852875&view=results
Not sure why it's still running on public CI despite being under the internal build section...

why isn't CI picking up my latest changes? https://github.com/dotnet/razor-tooling/pull/6545/commits/c2f554bb987f323d482b1ec3c1cb38b8108cf0bc

@JoeRobich would you have any idea what's going on here?  This is the most recent CI run for the PR: https://dev.azure.com/dnceng/public/_build/results?buildId=1855013&view=results
and it's based off this commit: https://github.com/dotnet/razor-tooling/commit/87a3e84e48fb9fbf0d19dd0a25b83b9d444889fe
Looking again, I think Joey's suggestion might fix the issue? I don't know if the condition on line 158 applies to the restore-internal-tools yml file, it might be a level too high. I'll try applying Joey's fix and if it doesn't work will revert.

Looks like CI passes now, so merging in. Thanks @epananth and @JoeRobich !


Using proxy in Jenkins environment

Parent issue #32

using proxy does not improve builds because distribution's mirrors often forbid caching. it is possible to ignore the caching policy, however, that would create another issue, stale cache.
my conclusion is that, HTTP proxy does not help, sharing local cache directory for packages might be a better workaround. hosting the whole package tree will certainly solve the issue, but building the whole tree and hosting all the packages are expensive.
close for now.


list-versions: Add command to list enabled versions

When creating a cluster, the user is able to pass a parameter with the
version of OpenShift to use. Unless the user goes through the
interactive flow, they won't be able to see which versions are
available. This command allows a user to view a list of all enabled
versions in the current environment.
https://asciinema.org/a/3G1EgphgPxmcD5hK2M1XVTuuE

/retest


Problem with camera permission

Hello. I have some problems with camera permission. On ios and android doesn't show permission after app installing and may be cause of I can't agree camera permission "await availableCameras()" calls crash like "Unhandled Exception: Unhandled error MissingPluginException(No implementation found for method availableCameras on channel plugins.flutter.io/camera) occurred in Instance of". Specified permissions in info.plist and androidManifetst.xml. If you had problem like that can you give some advices how can I fix this. Thank you.

@aytoku Can you check #106236 and try the fixes mentioned there?


Large idle times (>95% of frame time) when using Godot's drag-and-drop built-in functions

Godot version
3.4.2 Stable
System information
OS: Windows 10,PROCESSOR: 8x Intel(R) Core i7-6700 CPU @3.4GHz, Graphics card: NVIDIA GeForce GTX 1070,
Issue description
When I drag and drop items using godot's built in functions (get_drag_data, can_drop_data and drop_data), the idle time per frame is too high and results in big lag spikes. At first, it is smooth and the longer I drag an item, the choppier it gets. The dragging should stay smooth all throughout.
For a detailed post, see https://www.reddit.com/r/godot/comments/s981js/huge_idle_times_when_using_godots_builtin/
Steps to reproduce
Reproducible 100% of the time on my computer.
Create a control node, with 2 textureRect children (one of them is just for the background, the other is an image of whatever)
attach script to the image and use the following code:
extends TextureRect

var non = TextureButton.new()

func get_drag_data(position):
	var data = {}
	data["oui"] = "plop"
	data["ok"] = non
	var drag_texture = TextureRect.new()
	drag_texture.expand = true
	drag_texture.texture = texture
	drag_texture.rect_size = Vector2(100,100)
	var control = Control.new()
	control.add_child(drag_texture)
	drag_texture.rect_position = -0.5 * drag_texture.rect_size
	set_drag_preview(control)
	return data

func can_drop_data(position, data):
	return false

func drop_data(position, data):
	pass

Run the project using this scene as the root, and drag the image for a few seconds. The longer you drag, the choppier the preview gets and the mode idle time can be observed in the debugger
Minimal reproduction project
drag drop test.zip

@zoisus Please surround large blocks of text with triple backticks like this:
text here

This prevents them from taking too much space and also makes sure issue references aren't accidentally created. I edited your comment, but remember to do this next time :slightly_smiling_face:

Can't confirm, tested on 3.4.2 official build.

Can't confirm, tested on 3.4.2 official build.

Which operating system did you test this on? I didn't test this locally yet, but this may be OS-specific.

Tested on Windows 11

I'm having the same problem as well in my own project. I'm dragging a PanelContainer around and it's really choppy/jerky/laggy.
I downloaded your test project and can confirm, it happens there as well.
I'm using Godot 3.5 rc4. I'm on Windows 10, nVidia RTX 3070.

If it's of any help, I'd like to add that while you are dragging, the mouse cursor is constantly flickering between the regular arrow cursor and the red "drop-not-allowed" icon. This happens for me whether I use set_drag_preview or not.
# Insert this into a script attached to whatever control node,
and start dragging that node. Mouse cursor will switch back
and forth between arrow and no parking sign all the time
while you're moving the mouse.
func get_drag_data(position: Vector2):
	var data = {}
	return data

I have investigated this a bit more. It's on Godot version 3.4 the issue has started. I tried version 3.3.4, 3.3 and 3.2 and the dragging is butter smooth there. And on 3.4, 3.4.1, 3.4.2, 3.4.3, 3.4.4 and 3.5 (I tried them all), the dragging is choppy, just like the OP (and myself) experienced.
I've scanned through the 3.4 change log in order to see if there's some change according to drag and drop that can be the cause of this, and found this that may or may not be of some help:
Prevent accidental drags by adding drag distance threshold
Removing bounding box calculations from 3D scene drag and drop and collide against physics rather than visual geometry.
Fix EditorPropertyEasing capturing drag events originated outside of it
Any devs looking into this?

@tufduckhotmailcom Can you try all 3.4 betas and RCs to give us a more precise idea of when the regression started?

@Calinou Sure, no problem! I'm just glad I can be of some help. So, I've done what you said and tried all the versions. Here you go:
3.4 beta 1 = smooth
3.4 beta 2 = smooth
3.4 beta 3 = smooth
3.4 beta 4 = choppy !   <= found it!
3.4 beta 5 = choppy
3.4 beta 6 = choppy
3.4 rc1 = choppy
3.4 rc2 = choppy
3.4 rc3 = choppy

Possibly another consequence of #55037 where input event accumulation was mistakenly turned off.
Could you add Input.use_accumulated_input = true in e.g. _ready() of your main scene and see if that fixes the issue?

Thanks, closing as duplicate of #55037 then (same cause).


Trying again.

For actual commit details, see #3

And now it doesn't have conflicts, even though there were no changes.
Good job GitHub.


do not throw error in case file size exceeds limit or type mismatch

Hello,
As far as I know throw new Error should be used to raise an error in case there is something wrong with the flow, not for the scenario of user input.
I have removed the lines that throw new Error for  file size exceeds limit & type mismatch as the events are to handle those situations.
I hope make sense.
Saludos!

@pendexgabo You are right but it's better to replace it with a return statement so that the rest of the flow will not execute.

Alright. I will add a return false; instead.

done. Thanks

Will release the new build soon. Thanks for your contribution.


fix dragging invalid window

function! s:bwipe(...)
  bwipe!
endfunction

new
call timer_start(5000, function('s:bwipe'))

If dragging window bar for 5 seconds, Vim crash.

Codecov Report

Merging #1979 into master will decrease coverage by <.01%.
The diff coverage is 45.45%.

@@            Coverage Diff             @@
##           master    #1979      +/-   ##
==========================================
- Coverage   74.68%   74.67%   -0.01%
==========================================
  Files          77       77
  Lines      125798   125815      +17
  Branches    28150    28157       +7
==========================================
+ Hits        93952    93955       +3
- Misses      31842    31856      +14
  Partials        4        4

Impacted Files
Coverage Δ

src/gui.c
45.45% <0%> (-0.21%)
:arrow_down:

src/normal.c
71.65% <0%> (-0.06%)
:arrow_down:

src/edit.c
84.59% <100%> (+0.01%)
:arrow_up:

src/ui.c
44.7% <50%> (-0.02%)
:arrow_down:

src/evalfunc.c
82.6% <50%> (-0.02%)
:arrow_down:

src/version.c
79.18% <0%> (-1.02%)
:arrow_down:

src/if_xcmdsrv.c
85.18% <0%> (-0.19%)
:arrow_down:

src/libvterm/src/screen.c
73.32% <0%> (-0.12%)
:arrow_down:

src/channel.c
81.84% <0%> (-0.05%)
:arrow_down:

... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a9f8ee0...d9b5dc5. Read the comment docs.


no data in h5 file from Log data extension

Hi
Running the "Log data" extension on a newly written plugin I end up with a h5 file which seems not to contain any data. The problem can be reproduced performing a "Log data" on a generic mock plugin. All initializes correctly, data is show during acquisition. However, inspecting the resulting file with the h5browser, only the entry "Logger" contains string data in form of the message that acquisition has started. The entry "Detector000" is empty. Idem when firing up the python shell, importing h5py and inspecting the file manually. Am I missing something? Thanx for help!

Hi @bernhardlang
You didn't miss anything, there is indeed a bug, I just patched this into PR #251 This should solve your issue. I'll do the PR on both 4.1.x and 4.2.x_dev branch. I will also published a patch release as this is a hotfix! Make sure to test it and close the issue if satisfied

Thanks for the quick fix! Tested with mock plugin and my own plugin. Data now stored correctly.
Most probably unrelated, however and FYI: when closing the browser after viewing data from the mock plugin, it crashed. log file attached.
pymodaq.log


Update to latest version of plupload.

In addition to updating the files to the latest version (while keeping the asset path ERB stuff in the old files), I've added a note to get this working on Rails 4. Now that I think about it, this might be necessary for all versions of Rails.

can this be merged?


Lime-118, Issue 134: Yearn token <> shares conversion decimal issue

Description
The yearn strategy YearnYield converts shares to tokens by doing pricePerFullShare * shares / 1e18:
function getTokensForShares(uint256 shares, address asset) public view override returns (uint256 amount) {
    if (shares == 0) return 0;
    // @audit should divided by vaultDecimals
    amount = IyVault(liquidityToken[asset]).getPricePerFullShare().mul(shares).div(1e18);
}

But Yearn's getPricePerFullShare seems to be in vault.decimals() precision, i.e., it should convert it as pricePerFullShare * shares / (10 ** vault.decimals()).
The vault decimals are the same as the underlying token decimals
Integrations Checklist

[x]  Have any function signatures changed? If yes, outline below.
[ ]  Have any features changed or been added? If yes, outline below.
[ ]  Have any events changed or been added? If yes, outline below.
[ ]  Has all documentation been updated?

Changelog

Adding the correct precision for the token to share conversion (and vice versa) functions in YearnYield.sol(Issue 134: Yearn token <> shares conversion decimal issue
Ref: https://github.com/code-423n4/2021-12-sublime-findings/issues/134)
Added the decimals() function definition in IyVaultsol contract.

Event Signature Changes
Function Signature Changes

function decimals() external view returns (uint256); (Added)

Features
Events

Codecov Report

Merging #218 (e85d7a1) into master (6aaf59a) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master     #218      +/-   ##
==========================================
- Coverage   15.95%   15.93%   -0.02%
==========================================
  Files          16       16
  Lines        1736     1738       +2
  Branches      321      321
==========================================
  Hits          277      277
- Misses       1459     1461       +2

Impacted Files
Coverage Δ

contracts/yield/YearnYield.sol
10.52% <0.00%> (-0.29%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6aaf59a...e85d7a1. Read the comment docs.

Yearn is not being used. Hence closing the PR


Global button issues

There are several issues relating to global buttons that have been brought up, either through issues or the GuideMe forum thread:

EroticDevelopment/GuideMe#17 (Name self-explanatory.)
EroticDevelopment/GuideMe#16 (Button removal behaves differently depending on which method of xml or javascript was used for both the creation and removal.)
Putting buttons in the order that you want them is a hassle.
Debug window only shows global buttons created with javascript, and will sometimes show buttons that have been removed.

These problems are for the most part all linked to the same thing in the code - buttons are stored in two different locations, and MainLogic.ProcessButtons handles first one and then the other.

When you get right down to it, the global button system is a bit clunky. Button objects are added to a list... and may never actually get removed, it just gets new entries added saying "no wait, don't display that after all". While the performance aspect is probably negligible, it's awkward and seems like it'd make adding some of the requested 'optionally able to act more like EOS notifications' features difficult.
In the long run, the current arrangement should probably be replaced with a more robust and intuitively-organized data structure... although of exactly what kind and where to have it live is something I'm less certain about.

Initial set of issues resolved by #10, but fixing the backend is going to be a longer term project.


Event date

How do you create :
start: '20200702T080000Z',
end: '20200702T2030000Z',

Everyone uses carbon or moment so i am curious as to what method / format are you using to get these dates?

It's just a text, maybe you confused that is the month placed before or after the day, right?
This date formatted by year-month-day hour-min-sec, i think. You guys can use any format you want, it's just the text that the device can detect is a valid date.

cant get any dates to read
scan via iPhone 12 and results in QR code error when scanned
....
allDay: false,
start: '2022-04-13 00:00:00',
end: '2022-04-13 23:59:59',

I think you need to research about date format work with QR Code in iphone devices. Cause currently in this package i did not support to fix format (because I think it’s freely to users can set format by their self)
So you can see this article to fix it by yourself:
https://stackoverflow.com/questions/56818818/how-to-add-event-in-calendar-when-scanned-by-qr-scanner-in-swift-ios https://stackoverflow.com/questions/56818818/how-to-add-event-in-calendar-when-scanned-by-qr-scanner-in-swift-ios
You can keep reply this issue, i’ll here to help. If it’s hard to work, i’ll fix it to be right format we need to scan.


Could the Docker container for bosun have a text editor in it?

I cannot find out how to get any kind of editor to install in my bosun container.  I am trying to follow the Quick Start but without an editor I can't edit the bosun.conf file.
I'm new to docker and trying to figure it out but so far I can't.
I tried >> to the file the changes but when I restarted the container it failed and I had to revert to the backup I made.

This should be in the Quick Start documentation.

I plan creating a new docker page at some point and will make sure these details get in there


Bug in Range Breakdown Displayed (Zone Type: Census Tract && Data Choices: Crime Rate: Violent 12 months)

Ex:
http://housinginsights.org/tool/#/HI/ml=census_tract&sb=bdng&pu=4_717&ol=cv&cv=1_107
Range defaults to 1..107; in the map view the following ranges are given:
0 - 0
0 - 0
0 - 100
100 - 100
100 - 100
100
The census-tract-based map view shown implies that the underlying data set is being read and range-partitioned correctly into the chloropleth display but the correct range breakdown is not being displayed in the key overlaying the map.
On a related note, if one switches to Neighborhood Cluster (http://housinginsights.org/tool/#/HI/ml=neighborhood_cluster&sb=bdng&pu=4_717&ol=cv),, the range key overlay on the map also shows quirks:
0 - 100
100 - 100
100 - 200
200 - 300
300 - 300
300
This should of course be:
0 - 100
101 - 200
.
.
.
I'll take a look at the frontend code and see if anything jumps out; obviously it can't be as simple a fix as something rudimentary like this:
for (i=0; i < Math.ceil(max/range); i++) {
    range_start = (i>0 ? i*range+1 : i);
    range_end = Math.min((i+1)*range, max);
   // use each (range_start, range_end) to render any colored partitions
    // in the map and for the range key overlay
}
That's old-fashioned straightforward functional-style JS whereas I'm betting most of the frontend code is OO.

Sorry.  I can't. anymore
I'm exhausted


Add dark/light modes from Clarity for the Flo canvas/components

Relates to https://github.com/spring-cloud/spring-cloud-dataflow-ui/issues/1409

Moved to https://github.com/spring-cloud/spring-cloud-dataflow-ui/issues/1423


Fix documentation: show_status should be show_state

The documentation in the README lists show_status as an option, however the option name is actually show_state

Thanks for contributing!


v4 - Missing former panel style for cards

Here are my suggestions for the former panel style:

1. Split classes into card-primary-outline and card-primary-fill
SCSS
$primary: #0275d8;
$warning: #f0ad4e;

.card-primary {
  &-outline {
    border-color: $primary;
  }
  &-fill {
    background-color: $primary;
    color: #FFF;
  }
}

.card-warning {
  &-outline {
    border-color: $warning;
  }
  &-fill {
    background-color: $warning;
    color: #FFF;
  }
}

Example https://jsbin.com/kifejew/edit?html,css,output

		Featured

Special title treatment

With supporting text below as a natural lead-in to additional content.

		Go somewhere

		2 days ago

		Featured

Special title treatment

With supporting text below as a natural lead-in to additional content.

		Go somewhere

		2 days ago

2. Split classes into card-primary-outline and card-primary-fill and add class card-primary-header
card-primary-fill can be added to every color class (like primary, warning etc.) and applies the right color.
SCSS
$primary: #0275d8;
$warning: #f0ad4e;

.card-primary {
  &-outline {
    border-color: $primary;
  }
  &-header {
    background-color: $primary;
    color: #FFF;
  }
  &-fill {
    border-color: $primary;
    background-color: $primary;
  }
}

.card-warning {
  &-outline {
    border-color: $warning;
  }
  &-header {
    background-color: $warning;
    color: #FFF;
  }
  &-fill {
    border-color: $warning;
    background-color: $warning;
  }
}

Example https://jsbin.com/jixuyo/2/edit?html,css,output

      Featured

Special title treatment

With supporting text below as a natural lead-in to additional content.

      Go somewhere

      2 days ago

      Featured

Special title treatment

With supporting text below as a natural lead-in to additional content.

      Go somewhere

      2 days ago

These are just suggestions.
Open for discussion :)

BTW, in the current v4 code there are some issues, if you use card-primary with card-headeror card-footer:

Similar to/extending my suggestion #17243 :+1:
I also reported that .text-inverse behavior to #17244

This is something I've been concerned about as well, having contextual colors just for the "card title" (as was possible with panels). :+1:

Outlines were added in the second v4 alpha. Definitely have more things to improve, but closing this one out for now as other issues are open to address some of that.

@mdo Are there any docs for that?

@TheZoker https://github.com/twbs/bootstrap/blob/v4-dev/docs/components/card.md#outline-variants

any way to achieve this in alpha-4?


Use semantic HTML elements for Git version command

While keeping selecting the whole command on click.

An even better solution

An even better solution

@ugultopu Yeah, that is nice, provided we do it with a class  or something. If you think it's worth doing, open up a PR.

@ugultopu Yeah, that is nice, provided we do it with a class  or something. If you think it's worth doing, open up a PR.


fix(auth): Allow access to aop-prometheus IF prometheus enabled...

Pull Request Test Coverage Report for Build #49

0 of 0   changed or added relevant lines in 0 files are covered.
4 unchanged lines in 1 file lost coverage.
Overall coverage decreased (-1.5%) to 95.294%

Files with Coverage Reduction
New Missed Lines
%

file:/home/runner/work/armory-observability-plugin/armory-observability-plugin/common/src/main/java/io/armory/plugin/observability/model/PluginConfig.java
4
33.33%

Totals

Change from base Build #48:
-1.5%

Covered Lines:
243

Relevant Lines:
255

💛  - Coveralls


Grafana Is  Not installed

What did you do?
Installer In centrol.installer.v1.20.0-beta.2.yaml lacks The Install Of Grafana
What did you expect to see?
What did you see instead? Under which circumstances?
Environment

System information:
insert output of uname -srm here

Kubegems version:
insert output of kubegems --version here

Kubernetes version:
insert output of kubectl version here (if relevant to the issue)

Logs:

insert Kubegems logs relevant to the issue here

we  had no longer support grafana on installer-operator v1.20.0, maybe you can install it by helm.


Validation error when union contains stdlib dataclass and it's subclass

Initial Checks

[X] I have searched GitHub for a duplicate issue and I'm sure this is something new
[X] I have searched Google & StackOverflow for a solution and couldn't find anything
[X] I have read and followed the docs and still think this is a bug
[X] I am confident that the issue is with pydantic (not my code, or another library in the ecosystem like FastAPI or mypy)

Description
When a union is used which contains a stdlib dataclass (DC) and a subclass of that dataclass (S) in that order, the validators for DC are used when validating S. This is because DCs __get_validators__ is accessible on S, and so S is never processed by the dataclass machinery (find_validators is not called on S).
Example Code
import dataclasses
from typing import Union

@dataclasses.dataclass
class DC:
    a: int

@dataclasses.dataclass
class S(DC):
    b: int

import pydantic
import pydantic.dataclasses

class ForbidExtraKeywordDataclassConfig:
    extra = pydantic.config.Extra.forbid

@pydantic.dataclasses.dataclass(config=ForbidExtraKeywordDataclassConfig)
class Base:
    x: Union[DC, S]

# And trigger the bug
Base(x=S(a=1, b=2))

# Output is:
# Traceback (most recent call last):
#   File "c:/Users/matthew.joyce/Repos/manufacture_tools/pydantic_test.py", line 29, in <module>
#     Base(x=S(a=1, b=2))
#   File "pydantic\dataclasses.py", line 319, in pydantic.dataclasses._add_pydantic_validation_attributes.new_init
#     # function whose type depends on its parameters.
#   File "pydantic\dataclasses.py", line 422, in pydantic.dataclasses._dataclass_validate_values
#     # given, use it.  If not, call the factory.
# pydantic.error_wrappers.ValidationError: 2 validation errors for Base
# x -> b
#   extra fields not permitted (type=value_error.extra)
# x -> b
#   extra fields not permitted (type=value_error.extra)

Python, Pydantic & OS Version
pydantic version: 1.10.4
            pydantic compiled: True
                 install path: C:\Users\matthew.joyce\Repos\manufacture_tools\venv\env_venv\Lib\site-packages\pydantic
               python version: 3.8.7 (tags/v3.8.7:6503f05, Dec 21 2020, 17:59:51) [MSC v.1928 64 bit (AMD64)]
                     platform: Windows-10-10.0.19041-SP0
     optional deps. installed: ['typing-extensions']

Affected Components

[ ] Compatibility between releases
[ ] Data validation/parsing
[ ] Data serialization - .model_dump() and .model_dump_json()
[ ] JSON Schema
[X] Dataclasses
[ ] Model Config
[ ] Field Types - adding or changing a particular data type
[ ] Function validation decorator
[ ] Generic Models
[ ] Other Model behaviour - model_construct(), pickling, private attributes, ORM mode
[ ] Plugins and integration with other tools - mypy, FastAPI, python-devtools, Hypothesis, VS Code, PyCharm, etc.

Humm, weird.
Does it happen if Base is a model? Does the order of args to the union affect the result?

Using a model instead (rest of the code is the same):
class Base(pydantic.BaseModel):
    class Config:
        extra = pydantic.config.Extra.forbid

    x: Union[DC, S]

results in
Traceback (most recent call last):
  File "c:/Users/matthew.joyce/Repos/manufacture_tools/pydantic_test.py", line 27, in <module>
    Base(x=S(a=1, b=2))
  File "pydantic\main.py", line 342, in pydantic.main.BaseModel.__init__
pydantic.error_wrappers.ValidationError: 2 validation errors for Base
x -> b
  extra fields not permitted (type=value_error.extra)
x -> b
  extra fields not permitted (type=value_error.extra)

If the order of the union args is flipped, then the problem does not occur, because pydantic sees the subclass first.

For what it's worth, this seems fixed in v2
import dataclasses
from typing import Union

@dataclasses.dataclass
class DC:
    a: int

@dataclasses.dataclass
class S(DC):
    b: int

import pydantic
import pydantic.dataclasses

@pydantic.dataclasses.dataclass(config=dict(extra='forbid'))
class Base:
    x: Union[DC, S]

# No longer triggers the bug
Base(x=S(a=1, b=2))

I will close the issue as we probably won't be making any more changes to v1 dataclasses (due to the potential for unexpected new problems, since our efforts are focused on v2 now).


WiFi hostname of 18 characters causes DHCP OPTIONS assert due to VCI default value (IDFGH-6059)

Environment

Development Kit:      ESP32-S3 (any ESP32 should reproduce this though)
Kit version (for WroverKit/PicoKit/DevKitC): v1
Module or chip used:  ESP32-S3 WROOM 8mb / 2mb
IDF version:  v4.4-dev-3540-g4e03a9c34c
Build System:         idf.py
Compiler version: xtensa-esp32s3-elf-gcc (crosstool-NG esp-2021r1) 8.4.0
Operating System:     Linux
Using an IDE?: No
Power Supply:         USB

Problem Description
After https://github.com/espressif/esp-idf/issues/6786 was merged via https://github.com/espressif/esp-lwip/commit/ae7edc2a93f7163e9858c6a6b03ff3aa077bd928 it introduced a new vendor class identifier which defaults to the hostname of the device.  This commit to esp-lwip was picked up via https://github.com/espressif/esp-idf/commit/e451a9b2e16c2607a6f84eef015ce4afc2ebdb8f.
When the hostname is 17 characters or shorter this works fine but when the hostname is 18 characters it causes an assert as seen below.
Since this optional functionality is not required by all users it would be better to make this optional via sdkconfig so those that require this functionality can enable it selectively. Additionally it would be better to have no default payload when the user does not provide one and instead skip the inclusion entirely.
Expected Behavior
Hostname length of up to 32 characters should be supported still.
Actual Behavior
[WiFi] Setting ESP32 hostname to "esp32cs_5020103fff".
[WiFi] MAC Address: 7c:df:a1:e0:59:90
[DHCP] Starting DHCP Client.
[WiFi] Station started, attempting to connect to SSID: XXXXXXX.
Allocating new alias 436 for node 05020103fffe

assert failed: dhcp_option_vendor_class_identifier IDF/components/lwip/lwip/src/core/ipv4/dhcp.c:1857 (DHCP: hostname is too long!)

Backtrace:0x40375d8a:0x3fce9e600x4037da79:0x3fce9e80 0x40385521:0x3fce9ea0 0x420a6fb2:0x3fce9fd0 0x420a723a:0x3fce9ff0 0x420a7ecf:0x3fcea020 0x420a8199:0x3fcea040 0x4209a4b1:0x3fcea060 0x4209a442:0x3fcea080 0x4209f4cd:0x3fcea0a0 0x4209f570:0x3fcea0c0 0x40381135:0x3fcea0f0
0x40375d8a: panic_abort at esp-idf/components/esp_system/panic.c:402

0x4037da79: esp_system_abort at esp-idf/components/esp_system/esp_system.c:129
0x40385521: __assert_func at esp-idf/components/newlib/assert.c:85
0x420a6fb2: dhcp_option_vendor_class_identifier at esp-idf/components/lwip/lwip/src/core/ipv4/dhcp.c:1857 (discriminator 1)
0x420a723a: dhcp_reboot at esp-idf/components/lwip/lwip/src/core/ipv4/dhcp.c:1547
0x420a7ecf: dhcp_network_changed at esp-idf/components/lwip/lwip/src/core/ipv4/dhcp.c:1018
0x420a8199: dhcp_start at esp-idf/components/lwip/lwip/src/core/ipv4/dhcp.c:935
0x4209a4b1: esp_netif_dhcpc_start_api at esp-idf/components/esp_netif/lwip/esp_netif_lwip.c:1092
0x4209a442: esp_netif_api_cb at esp-idf/components/esp_netif/lwip/esp_netif_lwip.c:124
0x4209f4cd: tcpip_thread_handle_msg at esp-idf/components/lwip/lwip/src/api/tcpip.c:168
0x4209f570: tcpip_thread at esp-idf/components/lwip/lwip/src/api/tcpip.c:154
0x40381135: vPortTaskWrapper at esp-idf/components/freertos/port/xtensa/port.c:130

Steps to reproduce

Use https://github.com/espressif/esp-idf/tree/master/examples/wifi/getting_started/station example configure the default hostname to be at least 18 characters or even up to 32 characters.
Connect to AP that supports VCI and wait for connection to complete.

Arduino-esp32 users don't have menu config. So the effective hostname length is now 17 characters and not the documented 32.
Either the default limit for this should be updated or disable VCI by default since that also is not needed/appropriate for all users.

@ESP-YJM
I think this is a regression: enable VCI has unexpected side-effect and now VCI is enabled by default.

Thank you, it seems like a great feature to have. Perhaps move it to disabled by default and enable it via menu config and when enabled bump the options length by 32 (Max hostname length).

This should be fixed by 89873937eb7e36abc8e94071e67c9771b71d3625

@AxelLin Yes, that would appear to fix it. They did not link that commit to this issue unfortunately.