gosec runs out of memory

https://travis-ci.org/jaegertracing/jaeger/jobs/525047625
gosec -quiet -exclude=G104,G107 ./...
fatal error: runtime: out of memory

Possibly relevant issue: https://github.com/securego/gosec/issues/303

I am going to try to pin gosec to 1.3.0


Addition of generic workflows from ACCESS-NRI/reproducibility

In this PR:

Add config-generate-checksums.yml, config-pr-checks.yml from ACCESS-NRI/reproducibility#29

References #23

I'll be taking inspiration from them, yes. I'm not certain of their final form as maybe certain parts of the reusable workflows can be more tightly integrated in the other workflows. See https://github.com/ACCESS-NRI/model-config-tests/pull/24 for the final form of these things


feat(material-experimental/theming): add M3 tree support

Its a feature for experimental, so patch is fine

Merged as part of #28105


Can not select start date before today

react-dates version
<EMAIL_ADDRESS>Describe the bug
Days before today are disabled
Source code (including props configuration)
<SingleDatePicker
    date={value ? moment(value) : null}
    onDateChange={(date) => handleValueChange(date.toDate())}
    focused={focused}
    placeholder="Select date"
    onFocusChange={({ focused }) => toggleFocused(focused)}
    id="StartDate"
    numberOfMonths={1}
    hideKeyboardShortcutsPanel
/>

Desktop (please complete the following information):

OS: MacOS
Browser chrome
Version

Smartphone (please complete the following information):

Device: [e.g. iPhone6]
OS: [e.g. iOS8.1]
Browser [e.g. stock browser, safari]
Version 83

Is the issue reproducible in Storybook?
http://airbnb.io/react-dates/?path=/story/singledatepicker-sdp--default

Duplicate of #1719, #1124, #1519, #1392, #1117, #1073, #985, #801, #718, #714, etc.
isOutsideRange: () => false


fix: empty space in en10168 pdf

Description
What keywords did you search in schema-tools issues before filing this one ?
space
Is this a BUG REPORT or FEATURE REQUEST ?
BUG REPORT
Environment :
local
What you expected to happen :
I expect the pdf to render without extra unnecessary spaces.
How to reproduce it :
Render valid_cert.json in the en10168/fixtures/v0.3.0 directory.

Turns out this is due to the updated structure of the JSON certificate. Before, there would be a single Inspection object, and after it is rendered on the PDF, bottom margin would be added to separate the Inspection section from the next section. As we now can have multiple Inspection objects, each of these gets the bottom margin added automatically as if it were a separate section.


Update jline to 3.20.0

Updates org.jline:jline from 3.19.0 to 3.20.0.
Changelog
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "org.jline", artifactId = "jline" } ]

labels: library-update, semver-minor

+1

[X] Do all automated continuous integration checks pass?
Yes
[X] Is the update a patch, minor, or major update?
Patch update, numerous bugs fixed, nothing that jumps out that might effect Daffodil's. No issues with CLI debugger and completions after a quick manual test
[X] Is the license still compatible with ASF License Policy?
Yes, still BSD-3
[X] Have any changes been made to LICENSE/NOTICE files that need to be incorporated?
No changes to LICENSE, not NOTICE file
[X] Have any transitive dependencies been added or changed?
No changes


Implement "smart context based filtering" of static deprecation warnings

... to be able to dynamically filter out packages from reports like drupal/variationcache which is only deprecated if the site is running on drupal/core:>=10.2.0.

Closed via https://github.com/mxr576/ddqg-composer-audit/commit/ff89d75dda29c96da1c1934cc52d359e7718ce45


[error] BlueZ Permission Error

Hi, hope you can help.
I have followed the details in the https://flows.nodered.org/node/node-red-contrib-generic-ble installaton notes but I just cannot seem to get this working.
Scanning immediately gives me the Error.
cat /etc/group | grep bluetooth
returns
bluetooth:x:112:pi
NODE-Red is started with
node-red-start

Did you run sudo reboot after usermod? Reboot is required after changing the group.
If yes, check if your board has BLE. Only RPi3A+, RPi3B+ and RPi4 have BLE. See the raspberrypi.org products list for detail.

Indeed, I have done all these things.
I can use *gatttool *to read and write to my device from the command line
and all other bluetooth tools work as expected.. But Node-Red is always
giving the permissions error.
Thanks for getting back to me, if I can get this resolved, I will be
overwhelmingly happy!. It's the last piece in our puzzle.
Regards
On Tue, Nov 17, 2020 at 4:58 PM Daisuke Baba<EMAIL_ADDRESS>wrote:

Did you run sudo reboot after usermod? Reboot is required after changing
the group.
If yes, check if your board has BLE. Only RPi3A+, RPi3B+ and RPi4 have
BLE. See the raspberrypi.org products list
https://www.raspberrypi.org/products/ for detail.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/CANDY-LINE/node-red-contrib-generic-ble/issues/42#issuecomment-728786360,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AEYHB5CX3BH23QYUE5BL2MLSQI3LVANCNFSM4TYFUV2Q
.

--
John Anderson
Fungusware
http://fungusware.com
http://www.xenserver-backup.com

mmm...
Can you please post the actual error message? And /var/log/syslog as well, which probably contains the more precise error message.
The permission error is caused by wrong bluetoothd configuration. I'd say you're running NR by other user than pi but I'm not sure if it is. In order to identify the error cause, give me the above info.

Hi,
Sure can.
Error Message in the console - http://<IP_ADDRESS>:188018
http://<IP_ADDRESS>:188018 Nov 00:43:16 - [error] BlueZ Permission
Error. See 'Installation Note' in README at
https://flows.nodered.org/node/node-red-contrib-generic-ble
https://flows.nodered.org/node/node-red-contrib-generic-ble for
addressing the issue.
I have attached a few of the logs
On Wed, Nov 18, 2020 at 8:39 AM Daisuke Baba<EMAIL_ADDRESS>wrote:

mmm...
Can you please post the actual error message? And /var/log/syslog as well,
which probably contains the more precise error message.
The permission error is caused by wrong bluetoothd configuration. I'd say
you're running NR by other user than pi but I'm not sure if it is. In order
to identify the error cause, give me the above info.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/CANDY-LINE/node-red-contrib-generic-ble/issues/42#issuecomment-729300827,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AEYHB5EDJEC3KYREY4ZKOZDSQMJSTANCNFSM4TYFUV2Q
.

--
John Anderson
Fungusware
http://fungusware.com
http://www.xenserver-backup.com

Thanks. Need more precise info.
Can you please change the log settings as shown below?
The following setting outputs only this node logs. NR logs are disabled.
$ sudo nano /lib/systemd/system/nodered.service
# Insert the following line under `Nice=5` then save the file and exit
Environment="DEBUG=node-red-contrib-generic-ble:*"

$ sudo systemctl daemon-reload
$ node-red-start
# This will not output anything but NR will be running normally

Then try to cause the above error. The console shows precise log info, so you can post it in this thread.
In order to revert the change, just remove the appended line from /lib/systemd/system/nodered.service file.

Hi,
Sorry, this doesn't seem to report any further information to the Console.
The file is edited as shown below.
[image: image.png]
[image: image.png]
I could setup a remote session if you are willing, as your help is very
much appreciated.
Regards
On Wed, Nov 18, 2020 at 10:07 AM Daisuke Baba<EMAIL_ADDRESS>wrote:

Thanks. Need more precise info.
Can you please change the log settings as shown below?
The following setting outputs only this node logs. NR logs are disabled.
$ sudo nano /lib/systemd/system/nodered.service
Insert the following line under Nice=5 then save the file and exit
Environment="DEBUG=node-red-contrib-generic-ble:*"
$ sudo systemctl daemon-reload
$ node-red-start
This will not output anything but NR will be running normally
Then try to cause the above error. The console shows precise log info, so
you can post it in this thread.
In order to revert the change, just remove the appended line from
/lib/systemd/system/nodered.service file.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/CANDY-LINE/node-red-contrib-generic-ble/issues/42#issuecomment-729328999,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AEYHB5EI27TP7VCI6FUVIVDSQMT7TANCNFSM4TYFUV2Q
.

--
John Anderson
Fungusware
http://fungusware.com
http://www.xenserver-backup.com

Unfortunately, no image is available. Can you upload the image files from the github site with the browser?

Thanks. I've published the revised version of this node in order to provide more error info on the console.
Could you please upgrade the node to v4.0.3 and post the error info here?

Yes, much more information now. See attached.

Well, the error is just a permission error...
It should be resolved by adding pi user group to bluetooth group.
Again, let me check your environment. Can you please provide the following command results?
$ group pi
# will show the pi user's group
$ uname -a
# will show the linux OS info
$ dpkg -l | grep dbus
# will list dbus related package info

Mine is as follows.
$ groups pi
pi : pi adm dialout cdrom sudo audio video plugdev games users input netdev bluetooth spi i2c gpio

$ uname -a
Linux raspberrypi 5.4.51-v7+ #1333 SMP Mon Aug 10 16:45:19 BST 2020 armv7l GNU/Linux

$ dpkg -l | grep dbus
ii  dbus                           1.12.20-0+deb10u1                   armhf        simple interprocess messaging system (daemon and utilities)
ii  libdbus-1-3:armhf              1.12.20-0+deb10u1                   armhf        simple interprocess messaging system (library)
ii  python3-dbus

So far, I cannot reproduce the error with the latest OS image (Raspberry Pi OS Lite, Release date: August 20th 2020).
So using the latest lite image may resolve the issue.

Sure,
He is the information
pi@pi-gpt:~ $ groups pi
pi : pi adm dialout cdrom sudo audio video plugdev games users input netdev
bluetooth spi i2c gpio
pi@pi-gpt:~ $ uname -a
Linux pi-gpt 5.4.51-v7+ #1333 SMP Mon Aug 10 16:45:19 BST 2020 armv7l
GNU/Linux
pi@pi-gpt:~ $ dpkg -l | grep dbus
ii  dbus                           1.12.20-0+deb10u1
armhf        simple interprocess messaging system (daemon and utilities)
ii  libdbus-1-3:armhf              1.12.20-0+deb10u1
armhf        simple interprocess messaging system (library)
ii  libdbus-1-dev:armhf            1.12.20-0+deb10u1
armhf        simple interprocess messaging system (development headers)
pi@pi-gpt:~ $
On Wed, Nov 18, 2020 at 2:29 PM Daisuke Baba<EMAIL_ADDRESS>wrote:

Well, the error is just a permission error...
It should be resolved by adding pi user group to bluetooth group.
Again, let me check your environment. Can you please provide the following
command results?
$ group pi
will show the pi user's group
$ uname -a
will show the linux OS info
$ dpkg -l | grep dbus
will list dbus related package info
Mine is as follows.
$ groups pi
pi : pi adm dialout cdrom sudo audio video plugdev games users input netdev bluetooth spi i2c gpio
$ uname -a
Linux raspberrypi 5.4.51-v7+ #1333 SMP Mon Aug 10 16:45:19 BST 2020 armv7l GNU/Linux
$ dpkg -l | grep dbus
ii  dbus                           1.12.20-0+deb10u1                   armhf        simple interprocess messaging system (daemon and utilities)
ii  libdbus-1-3:armhf              1.12.20-0+deb10u1                   armhf        simple interprocess messaging system (library)
ii  python3-dbus
So far, I cannot reproduce the error with the latest OS image (Raspberry
Pi OS Lite, Release date: August 20th 2020).
So using the latest lite image may resolve the issue.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/CANDY-LINE/node-red-contrib-generic-ble/issues/42#issuecomment-729462636,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AEYHB5C5JYAR7ZMOEJINMRTSQNSURANCNFSM4TYFUV2Q
.

--
John Anderson
Fungusware
http://fungusware.com
http://www.xenserver-backup.com

pi user is belonging to bluetooth group
OS seems to be identical to mine
dbus version is same

Unfortunately, I have no idea to resolve the issue.
Can you please use the fresh OS image without adding ANY packages/programs except Node-RED and this node?
I tried the fresh OS image(Raspberry Pi OS Lite) and I confirmed it worked without any issues.

hi, plz help how use this node in "docker nodered/node-red:latest-minimal"
23 Jan 20:57:05 - [error] [GenericBLE:ERROR] The name org.bluez was not provided by any .service files, DBusError: The name org.bluez was not provided by any .service files,
    at _methodReturnHandlers.(anonymous function) (/data/node_modules/dbus-next/lib/bus.js:339:27),
    at handleMessage (/data/node_modules/dbus-next/lib/bus.js:98:11),
    at EventEmitter.MessageBus.conn.on (/data/node_modules/dbus-next/lib/bus.js:147:9),
    at EventEmitter.emit (events.js:198:13),
    at /data/node_modules/dbus-next/lib/connection.js:112:14,
    at Socket.<anonymous> (/data/node_modules/dbus-next/lib/message.js:63:9),
    at Socket.emit (events.js:198:13),
    at emitReadable_ (_stream_readable.js:555:12),
    at process._tickCallback (internal/process/next_tick.js:63:19),

node-red run from user 'node-red' in Alpine Linux

hi, plz help how use this node in "docker nodered/node-red:latest-minimal"
23 Jan 20:57:05 - [error] [GenericBLE:ERROR] The name org.bluez was not provided by any .service files, DBusError: The name org.bluez was not provided by any .service files,
    at _methodReturnHandlers.(anonymous function) (/data/node_modules/dbus-next/lib/bus.js:339:27),
    at handleMessage (/data/node_modules/dbus-next/lib/bus.js:98:11),
    at EventEmitter.MessageBus.conn.on (/data/node_modules/dbus-next/lib/bus.js:147:9),
    at EventEmitter.emit (events.js:198:13),
    at /data/node_modules/dbus-next/lib/connection.js:112:14,
    at Socket.<anonymous> (/data/node_modules/dbus-next/lib/message.js:63:9),
    at Socket.emit (events.js:198:13),
    at emitReadable_ (_stream_readable.js:555:12),
    at process._tickCallback (internal/process/next_tick.js:63:19),

node-red run from user 'node-red' in Alpine Linux


Add config file for search scraper

Config for docs-scraper, which populates the search index.
QA Steps: n/a
No related task.
PR Template and Checklist
Please complete as much as possible to speed up the reviewing process.
Readiness and adding reviewers as appropriate is required.
All PRs should be reviewed by a technical writer/documentation team and a peer.
If effecting customers—which is a majority of content changes—a member of Customer Success must also review.
Readiness

[x] Merge (pending reviews)
[ ] Merge after date or event
[ ] Draft

Checklist

[x] follow best practices for commits.

[x] Descriptive title written in the imperative.
[x] Include brief overview of QA steps taken.
[x] Mention any related issues numbers.
[x] End message with sign off/DCO line (-s, --signoff).
[x] Sign commit with your gpg key (-S, --gpg-sign).
[x] Squash commits if needed.

[x] Request PR review by a technical writer and at least one peer.

Docs for 46d98eaae6db15ce2e6a8c501932203bbc78f572 are browsable at: https://ci.foundries.io/projects/fio-docs/builds/2722/docs/artifacts/html/index.html


block-break-value

We have:
loop {
    break value;
}

'label: loop {
    break 'label value;
}

'label: {
    break 'label value;
}

It would be nice to extend this to other blocks:
'label: if cond {
    break 'label value;
} else {
    break 'label value;
}

'label: if let pat = expr {
    break 'label value;
} else {
    break 'label value;
}

'label: match expr {
    pat => {},
}

'label: try {
    break 'label value;
}

As opposed to:
'label: {
    if cond {
        break 'label value;
    } else {
        break 'label value;
    }
}

'label: {
    if let pat = expr {
        break 'label value;
    } else {
        break 'label value;
    }
}

'label: {
    match expr {
        pat => {},
    }
}

'label: {
    try {
        break 'label value;
    }
}

This avoids a whole level of indentation and an unnecessary pair of {}.
Note that while let and while wouldn't be changed because those can't return values.

(Note that IDEs/rustfmt are unable to cope with:
'label: { if cond {
    break 'label value;
} }

Instead, they rewrite it to:
'label: {
    if cond {
        break 'label value;
    }
}

)

Do you have a specific use case for this? (I'm not asking for hypotheses on how this could be used; do you have something specific you want to use this for?)
Much of the motivation for introducing labeled break was for macro authors, and the extra level of indentation doesn't really matter there. And the ability to break from multiple branches of an if, for instance, seems like it will increase the tendency to produce spaghetti code with non-obvious control flow.

Mainly combining 'label and try, to avoid nesting.
See:
// as part of a very complex function, like a game loop
let x = try {
    if self.ready {
        let a = do_complex_thing?;
        more_complex_things(a)
    } else {
        Err(NotReady)
    }
}

// Vs:

let x = 'label: try {
    if !self.ready {
        break 'label Err(NotReady);
    }
    // avoids nesting
    let a = do_complex_thing?;
    more_complex_things(a)
}

(I find the latter much more readable, as the "normal" case is at the bottom of the block, not nested, and the "exceptional" case is out of the way. and yes I know about "omg please split your functions" but uh... no?)

Or just using throw (cc #2426):
let x = try {
    if !self.ready { throw NotReady; }
    let a = do_complex_thing?;
    more_complex_things(a)
}

I'm glad label-break-value was accepted, but hope it's only rarely seen outside of macros offering interesting control flow constructs.  I see it and loop as the very bottom level of intraprocedural control flow constructs -- while, for, loop-break, continue, return, etc are all just sugar for some combination of those two.
Any time LBV is actually used the control flow is already unusual, so I actually appreciate the explicitness that comes from having a dedicated {} pair just for the label scope.  It avoids confusion like "is it doing 'label: try { or try 'label: { or can I do 'foo: try 'bar?".  I definitely never want to see the last of those, nor something like else 'label: {.

Closing since this doesn't seem to be going anywhere. If you want to continue with this proposal, please open a topic on internals.rust-lang.org, or write up a formal RFC proposal.


Sidebar not full

if the content is small, the sidebar is not full

That's a bug from AdminLTE itself and will fixed with the next release (v3.0.5).

I've published a new version of AdminLTE with this bug fixed, you can simply update it via composer and then run php artisan adminlte:update.

@REJack After follow updating procedure, I can confirm that bug is fixed (at least on my local environment). However, I have noted that the user menu or any dropdown menu on the navbar don't work when boxed_layout option is enabled (I really don't know if this previously existed).


Release version 0.0.8

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (1bae454) 100.00% compared to head (9dd5c14) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #257   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files           95        95
  Lines         3123      3123
  Branches       255       255
=========================================
  Hits          3123      3123

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Added rust directory and a fizzbuzz.rs

This solution has the advantage that any "sound" can be added by adding a tuple (Int, String) to the sound array. This means when someone tells you they want to also see you print "hogwash" when n is divisible by 42, it's just a oneliner to get it updated.

Interesting! Thank you :)


Add method to get person birthdate (if available)

Resolves #53

Codecov Report

Merging #54 (8693178) into v2.1 (3d4773f) will decrease coverage by 3.86%.
The diff coverage is 44.56%.

@@             Coverage Diff              @@
##               v2.1      #54      +/-   ##
============================================
- Coverage     94.58%   90.72%   -3.87%
- Complexity      466      481      +15
============================================
  Files            59       61       +2
  Lines          1090     1175      +85
  Branches         55       62       +7
============================================
+ Hits           1031     1066      +35
- Misses           41       86      +45
- Partials         18       23       +5

Impacted Files
Coverage Δ

...a/ee/sk/smartid/util/CertificateAttributeUtil.java
20.00% <20.00%> (ø)

...ee/sk/smartid/util/NationalIdentityNumberUtil.java
44.44% <44.44%> (ø)

...ain/java/ee/sk/smartid/AuthenticationIdentity.java
93.10% <81.81%> (-6.90%)
:arrow_down:

...ee/sk/smartid/AuthenticationResponseValidator.java
88.00% <90.00%> (+0.50%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3d4773f...8693178. Read the comment docs.


UnhandledPromiseRejectionWarning in the agent

While running systemtests (io.enmasse.systemtest.isolated.bridging.ConnectorsTest), I found the following entries in the "agent" logs:
Failed to retrieve router stats: disconnected
Failed to retrieve router stats: disconnected
Failed to retrieve router stats: disconnected
Failed to retrieve router stats: disconnected
Failed to retrieve router stats: disconnected
Failed to retrieve router stats: disconnected
Failed to retrieve router stats: disconnected
Failed to retrieve router stats: disconnected
Failed to retrieve router stats: disconnected
Failed to retrieve router stats: disconnected
Failed to retrieve router stats: disconnected
Failed to retrieve router stats: disconnected
(node:1) UnhandledPromiseRejectionWarning: disconnected
(node:1) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). (rejection id: 1)
(node:1) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.

Terminating the NodeJS process sounds like a serious issue, so I guess it should be fixed.

:1st_place_medal:


Functions missing in structure panel

plugin version: 0.58.1
Description
A number of functions are missing from the structure panel.  For example, for the following file, the second function doesn't appear in the list.  In my original file, it omits about 10 in a row but not the entire file.  Removing the "Pp.(...)" idiom makes the subsequent functions appear.
let can_enable_diffs () =
  CErrors.user_err Pp.(str "Error: Color must be enabled (\"-color on\" in the command line) to show diffs")

let write_diffs_option () = true

should be fixed in 0.60.1


converted mace-models/squeezenet.v10.yml with “data_type: fp16_fp32” or “data_type: fp32_fp32” , get totaly completely different result for same input   on PowerVR Rogue GX6650 GPU, why?

Before you open an issue, please make sure you have tried the following steps:

Make sure your environment is the same with (https://mace.readthedocs.io/en/latest/installation/env_requirement.html).
Have you ever read the document for your usage?
The form below must be filled.

System information

OS Platform and Distribution (e.g., Linux Ubuntu 16.04): Linux Ubuntu 16.04
NDK version(e.g., 15c):    cross compile
GCC version(if compiling for host, e.g., 5.4.0):   gcc version 7.3.0 (GCC)
MACE version (Use the command: git describe --long --tags):  MACE version: v0.9.0-213-g68518b9-20180928
Python version(2.7):  2.7
Bazel version (e.g., 0.13.0):
0.13.0

Model deploy file (*.yml)
...... mace-models/squeezenet.v10.yml

with different "data_type: fp32_fp32" and "data_type: fp16_fp32" at the end of the .yml file
Describe the problem
A clear and concise description of what the bug is.
runing  mace-models/squeezenet.v10.yml converted with different data_type options ,fp16_fp32  and fp32_fp32 , but got totoaly different result for the same input. 227x227x3 buffer subtract the channel-mean value.
To Reproduce
Steps to reproduce the problem:
1. cd /path/to/mace
2. python tools/converter.py convert --config_file=/path/to/your/model_deployment_file

runing  mace-models/squeezenet.v10.yml converted with different data_type options ,fp16_fp32  and fp32_fp32 , but got totoaly different result for the same input. 227x227x3 buffer subtract the channel-mean value formated in NHWC.
Error information / logs
Please include the full log and/or traceback here.
LOGs

Additional context
Add any other context about the problem here, e.g., what you have modified about the code.
mace/models/mobilenet-v2 converted with data_type options ,fp16_fp32  and fp32_fp32 get approximately the same results,  but all the other caffe model  i tested on mace get the same phenomenon.  the performace are also different. fp16_fp32 mace model is faster than fp32_fp32.
what‘s wrong？？  Any suggestion will be appreciate!

fp16_fp32 stands for the tensor storage type with float16 and calculation with float32, which is faster than fp32_fp32, and a little difference is also reasonable.


build: add -buildid='' so that the binaries are reproducible

ideally, this should be tested by the CI so that it doesn't break.

This change is

so, buildid is stable on the same host, but not sure about different hosts.
it's being discussed on https://github.com/ethereum/go-ethereum/pull/23527
marking it as draft until clarified.

let's reopen this once we have more concrete idea whether this solves the problem or not


including updated from beta

@JakubMatejka please, review it so it can go live. Thanks.

@JakubMatejka I need 2 approving reviews, who should I ask next when Michal is not available, please?

I changed the rule so that one review is enough now. 🙂


Add translations

I'm german and I need to lookup the german names everytime I'm using pogo-cruncher.

Will add that, but other features are having priority right now. Anybody who is capable of delivering a pull-request with translations, can feel free to do so. :)

What would be the best way to add them?
Add them as attribute to pogo-cruncher/frontend/src/cruncher/data/pokemon.cljs?
:name                        "Bulbasaur"
:name-de                   "Bisasam"

Yeah, that would be a good variant, that doesn't break anything. :)

I realised it would be some work to merge the translations into the file. But I've found translations that are ready to use here https://github.com/AHAAAAAAA/PokemonGo-Map/tree/master/static/locales

Thanks, that makes it possible to merge them in with an automated script. I'll write it over the weekend I think. :)


feat(triton): add triton server config generator

What this PR does / why we need it:
feat(triton): add triton server config generator
// TODO:
Still needs more tests.
The original ormbfile
format: SavedModel
framework: TensorFlow
signature:
  inputs:
  - name: serving_default_Conv1_input:0
    size:
    - -1
    - 28
    - 28
    - 1
    dtype: float32
  outputs:
  - name: StatefulPartitionedCall:0
    size:
    - -1
    - 10
    dtype: float32
  layers:
  - name: VarHandleOp
  - name: ReadVariableOp
  - name: NoOp
  - name: Const
  - name: Placeholder
  - name: StatefulPartitionedCall

The generated config.pbtxt
name: "savedmodel:v1"
platform: "tensorflow_savedmodel"
max_batch_size: "0"
input [
  {
    name: "serving_default_Conv1_input:0"
    data_type: TYPE_FP32
    dims: [-1, 28, 28, 1]
  }
]
output [
  {
    name: "StatefulPartitionedCall:0"
    data_type: TYPE_FP32
    dims: [-1, 10]
  }
]

Which issue(s) this PR is related to (optional, link to 3rd issue(s)):
Fixes #
Reference to kleveross/ormb#92

Special notes for your reviewer:
/cc @simon-cj @gaocegege

Release note:

NONE

/hold


obs: Seems like obs is redirecting to release url

Today we started seen an error on the CI when trying to add the Kata OBS repository:
Install Kata Containers OBS repository
Loaded plugins: fastestmirror
adding repo from: http://download.opensuse.org/repositories/home:/katacontainers:/release/CentOS_7/home:katacontainers:release.repo
grabbing file http://download.opensuse.org/repositories/home:/katacontainers:/release/CentOS_7/home:katacontainers:release.repo to /etc/yum.repos.d/home:katacontainers:release.repo
Could not fetch/save url http://download.opensuse.org/repositories/home:/katacontainers:/release/CentOS_7/home:katacontainers:release.repo to file /etc/yum.repos.d/home:katacontainers:release.repo: [Errno 14] HTTP Error 404 - Not Found
Build step 'Execute shell' marked build as failure

From: http://jenkins.katacontainers.io/job/kata-containers-runtime-centos-7-4-PR/1253/console
I verified that our CI scripts use the releases URL:
https://github.com/kata-containers/tests/blob/master/.ci/lib.sh#L29
So it seems strange that for some reason, we are being redirected to the release url. Might this be a problem in the OBS mirrors?

/cc @marcov @jcvenegas

to me it looks like it is cloning an old version of the tests repository instead of master, and that version still contains the old URL.
The repo_file is now named master.repo, while in the logs it is still being called release.repo.

Thanks @marcov
yeah, sorry for the noise. This happened on stable branches 1.4 and 1.5. Opened a couple of PRs to fix this.
Related
https://github.com/kata-containers/tests/pull/1229
https://github.com/kata-containers/tests/pull/1230

closing issue.


Pen cursor way off

when my pen as at the right side of the side its fine but as i move it to left left an moves further and further it doesn't do this when i have my monitor unplugged i'm running manjaro with a huino kamvas 13 pro(gt133)

Do you have multi monitors plugged into your system?

Do you have multi monitors plugged into your system?

if the drawing tablet counts as one then yes i have my main monitor then my drawing tablet i have tried enabling multi monitor and nothing changes set the resolotuion etc maybe its because my main monitor 1920x1200 wich is wierd idk

Try forcing mirror mode on your screens. You might have top/bottom margins on your tablet, due to the difference in resolution, or just force your main monitor to display in 1920x1080p.
I currently have the same issue, except that my main monitor has the same resolution than the tablet. I couldn't get multi monitor to work, so I got used to it and just use the tablet in mirror mode for now, waiting for a multi monitor fix.

Try forcing mirror mode on your screens. You might have top/bottom margins on your tablet, due to the difference in resolution, or just force your main monitor to display in 1920x1080p.
I currently have the same issue, except that my main monitor has the same resolution than the tablet. I couldn't get multi monitor to work, so I got used to it and just use the tablet in mirror mode for now, waiting for a multi monitor fix.

that works but the only reason i want my main monitor on is to have refrences is there anyway to make it work with them not being mirrored

Yeah, I know, it's kinda annoying, but multi-monitor don't work for now.
For now, I've set up my laptop next to me on my desk when I need a second monitor but it's annoying, yes.
I've opened an issue because it made the driver crash for me, maybe you can contribute to that one : issue https://github.com/joseluis/huion-linux-drivers/issues/75

If you manually use xrandar you may be able to fix these issues.
xrander uses monitors in a way you probably wouldn't expect, the basic concept is that it creates the 'total screen' area first and then positions your monitors 'screens' over that area to determine what they are actually outputting and displaying on the monitors.
For your use-case I recommend you overlap the tablet 'screen' output over the external monitors 'screen' output and set the digitizer to match the tablets 'screen' position. Whatever extra difference in 'visual space' there is between the two monitors will simply just be cropped off from the tablets 'screen' leaving roughly 1:1 scale in dimensions between the tablets 'screen' and external monitors 'screen'. If you use some other preset 'mirroring' setting the dimensions could be slightly out of proportion making your pens input feel off.
Using the 'mirroring' mode available in some desktop environments may mess up the dimensions between the screens because they might scale certain things differently to make the environment more consistent for the majority of users, at the cost of some almost un-noticeable precision. Which wouldn't normally be an issue but we have an extreme use-case here where were trying to precisely match 2 varying monitors and a digitizer for precision raster drawing.
For example here are my current settings:
[monitor_2+1]
# 3 monitors. But 2 and 3 share the same view

screen_1W = 1920
screen_1H = 1080
screen_2W = 1920
screen_2H = 1200
screen_3W = 1920
screen_3H = 1080

total_screen_width   = ${screen_1W} + ${screen_2W}
total_screen_height  = ${screen_2H}
tablet_offset_x      = ${screen_1W}
tablet_offset_y      = 60

xrandr_output1 = --output DisplayPort-0 --mode ${screen_1W}x${screen_1H} --pos 0x0 --rotate normal
xrandr_output2 = --output DisplayPort-1 --mode ${screen_2W}x${screen_2H} --pos ${screen_1W}x0 --rotate normal
xrandr_output3 = --output HDMI-A-0 --mode ${screen_3W}x${screen_3H} --pos ${screen_1W}x60 --rotate normal
xrandr_args    = ${xrandr_output1} ${xrandr_output2} ${xrandr_output3}

I have 3 monitors but I centered my Huion kamvas 12 pro's monitor [HDMI-A-0] in the center of my 1920x1200 wide gamut monitor [DisplayPort-1], and since this script sets the digitizer area to match the tablets hardware I only had to position it to match the tablets screen position.
@zachattackrandom You'd want to try doing something similar, like this for example:
[monitor_2in1]
# 2 monitors. But 2 is centered in 1

screen_1W = 1920
screen_1H = 1200
screen_2W = 1920
screen_2H = 1080

total_screen_width   = ${screen_1W}
total_screen_height  = ${screen_1H}
tablet_offset_x      = 0
tablet_offset_y      = 60

xrandr_output1 = --output DisplayPort-0 --mode ${screen_1W}x${screen_1H} --pos 0x0 --rotate normal
xrandr_output3 = --output HDMI-A-0 --mode ${screen_2W}x${screen_2H} --pos 0x60 --rotate normal
xrandr_args    = ${xrandr_output1} ${xrandr_output2}

Thanks for the help but I ended up just setting up a windows vm to use my drawing tablet with since it's easier and the driver is better than anything we have on Linux


Add support for multiple running actions

Tweak the ActionContext context to add an array of actions and organize the action page in tabs.
The actions should be canceled by the user and switch between them

Fixed in #78


Fix or delete mappers for ORM v2

These mappers are not compatible with ORM v2
They should be updated or deleted.
Code for update can be copied from here:
https://github.com/cycle/orm/blob/2.0/tests/ORM/Fixtures/TimestampedMapper.php
https://github.com/cycle/orm/blob/2.0/tests/ORM/Fixtures/SoftDeletedMapper.php

I think these mappers should be deleted because in the Cycle ORM v2 we will have new features for this case

Even some kind of target is galimy. It's unclear what's going on!!!

@roxblnfk, shouldn't it be closed due to #127?


PMID:19933844

sensitive to phosphate starvation
abnormal regulation of adenine biosynthetic process
normal RNA level during cellular response to hydroxyurea
decreased cellular dATP level
normal cellular dCTP level
normal cellular dGTP level
decreased protein localization to chromatin during cellular response to phosphate starvation

sensitive to phosphate starvation FYPO:0006200
abnormal regulation of adenine biosynthetic process FYPO:0006201
normal RNA level during cellular response to hydroxyurea FYPO:0006202
decreased cellular dATP level FYPO:0006203
normal cellular dCTP level FYPO:0006204
normal cellular dGTP level FYPO:0006205
decreased protein localization to chromatin during cellular response to phosphate starvation FYPO:0006206
edit file: ed18a52546be223011a2ddcbf812d4b7cc849a58
release: 3aac9bc135fb6485f1499ae7448ce3b508c96983


Style guide changes to http-metrics.md

Test PR to see if you're interested in a professional writer applying the the style guide aimed at:

Easier to Machine Translate (MT) to help folks in any language.
Long sentences are the most difficult to MT and are difficult for native speakers to parse.
Easier to read, even for native speakers.
Shorter is always better.
Avoid future tense as it's more difficult to reason about and doesn't MT great.
Avoid parenthetical statements, they're difficult to MT.
Remove random newlines in text which make it more difficult to edit.

Test PR to see if you're interested in a professional writer applying the the style guide aimed at:

Easier to Machine Translate (MT) to help folks in any language.
Easier to read, even for native speakers.
Shorter is always better.
Avoid future tense as it's more difficult to reason about and doesn't MT great.
Avoid parenthetical statements, they're difficult to MT.

This is awesome @Rick-Anderson, I like it!

This is awesome @Rick-Anderson, I like it!

Great, I'll push some more commits to this PR. I might create an issue with more aggressive style changes to consider.

@chalin FYI you might like this.

@reyang better retract approval until I finish. I'm not 100% confident of my changes.

cc @lmolkova

Overall, nice copyedits.
Just curious, which style guide are you referring to?
Also, I think that the doc pages could benefit from being formatted with Prettier before making more copyedits like these -- see #189.

Just curious, which style guide are you referring to?

Multiple where they agree. Most of my style guide changes were for MT (machine translation). MSFT has done extensive research on making it easier to MT and I'm focusing on the MT style guide.

Also, I think that the doc pages could benefit from being formatted with Prettier before making more copyedits like these -- see #189.

Don't you want to apply Prettier first so only formatting is changed? If not for the random newlines in this file, rich diff would be fine to see what's changed.

Don't you want to apply Prettier first so only formatting is changed?

Yes, that would be the idea -- for a start on this, see #192.

@Rick-Anderson This is a very nice change!
Are you able to make the changes to the underlying YAML that generates the content and recreate the tables? Generated content is denoted in Markdown with <--semconv ... --> comments.

Where is the underlying YAML?

@Rick-Anderson Would you be willing to contribute your style guide to this repository?  I'm going to close this PR as stale, but I think our group is still interested in the more general style guide we could include and enforce in future PRs.
Thanks!

@Rick-Anderson Would you be willing to contribute your style guide to this repository? I'm going to close this PR as stale, but I think our group is still interested in the more general style guide we could include and enforce in future PRs.
Thanks!

Sure, now that I've figured out generated files. I'll look for an open source style guide. The mantra should be Smart Brevity: The Power of Saying More with Less
There are basic things to make content easier to MT (machine translate) that also benefit native speakers.


Could i have the setup for a vps on q bot, my membership ended but my projects got deleted so i wanna rehost on a vps

https://github.com/yogurtsyum/qbot/wiki/vps-hosting-setup

Please could you close this issue if this has helped


HBASE-23939 Remove unused variables from HBaseSaslRpcServer

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 12s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

-0 :warning:
test4tests
0m  0s
The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ master Compile Tests _

+1 :green_heart:
mvninstall
6m  7s
master passed

+1 :green_heart:
compile
1m  3s
master passed

+1 :green_heart:
checkstyle
1m 16s
master passed

+1 :green_heart:
shadedjars
5m 12s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 37s
master passed

+0 :ok:
spotbugs
5m 44s
Used deprecated FindBugs config; considering switching to SpotBugs.

+1 :green_heart:
findbugs
5m 40s
master passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
5m 35s
the patch passed

+1 :green_heart:
compile
1m  1s
the patch passed

+1 :green_heart:
javac
1m  1s
the patch passed

+1 :green_heart:
checkstyle
1m 18s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
shadedjars
5m 15s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
hadoopcheck
17m 44s
Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.

+1 :green_heart:
javadoc
0m 35s
the patch passed

+1 :green_heart:
findbugs
5m 51s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
99m 21s
hbase-server in the patch passed.

+1 :green_heart:
asflicense
0m 27s
The patch does not generate ASF License warnings.

165m 13s

Subsystem
Report/Notes

Docker
Client=19.03.7 Server=19.03.7 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1239/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/1239

Optional Tests
dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile

uname
Linux c4431e8a2e06 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 GNU/Linux

Build tool
maven

Personality
/home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-1239/out/precommit/personality/provided.sh

git revision
master / 9bd39786df

Default Java
1.8.0_181

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1239/1/testReport/

Max. process+thread count
7359 (vs. ulimit of 10000)

modules
C: hbase-server U: hbase-server

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1239/1/console

versions
git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.


The form-check field classes are lost

After submitting and returning a form with errors, classes are lost.
form-check-label
form-check-input

  <input checked="" class="is-valid" id="id_symptom_22_0" name="symptom_22" required="" title="" type="radio" value="0">
   None

To convert to Radio, I use the widget in the ModelForm class
forms.RadioSelect()

Same with CheckboxInput

asdd


CVE-2021-27290 due to using old version of ssri

Bug report

What is the current behavior?
CVE-2021-27290

ssri 5.2.2-8.0.0, fixed in 8.0.1, processes SRIs using a regular expression which is vulnerable to a denial of service. Malicious SRIs could take an extremely long time to process, leading to denial of service. This issue only affects consumers using the strict option.

The fix is to bump ssri to 8.0.1.
The dependency path to ssri is webpack > terser-webpack-plugin > cacache > ssri
I've reported this issue in terser-webpack-plugin at https://github.com/webpack-contrib/terser-webpack-plugin/issues/388
If the current behavior is a bug, please provide the steps to reproduce.

What is the expected behavior?
There shouldn't be any CVE's found when evaluating Webpack :)

Other relevant information:
webpack version:  4.46.0
Node.js version: all
Operating System: all

Do not duplicate issues

Do not duplicate issues

What issue is this one a duplicate of?

https://github.com/webpack-contrib/terser-webpack-plugin/issues/388

Don't know why you spam it in multiple repos and no one from these repos can fix it directly

Don't know why you spam it in multiple repos and no one from these repos can fix it directly

I'm not spamming.
Each project has this problem and to fix it, each has to do something.
For example, webpack could fix it by overriding the ssri version. Or, it could fix it by updating to a later version of terser-webpack-plugin when (if?) it becomes available. But it has to do something in order to fix the problem - doing nothing won't fix the problem. And since action is required to fix the problem, it seems like an issue should exist.

For example, webpack could fix it by overriding the ssri version.

No, you need read how package manager works

Nothing to fix on CRA/webpack side

Or, it could fix it by updating to a later version of terser-webpack-plugin when (if?) it becomes available.

terser-webpack-plugin v5 doesn't use cacache, so nothing to fix for webpack v5 too

react-script still uses webpack 4. "webpack": "4.44.2". Could someone please release a patch as it is affecting multiple projects using react-script.

Not sure when this will be resolved but for all of you who are struggling with vulnerability requirements you can modify the  package.lock and adding the specific version of the ssri dependency instead of the standard one required by react scripts.
For more info see this stackoverflow issue: https://stackoverflow.com/questions/15806152/how-do-i-override-nested-npm-dependency-versions


OTG drops out / disconnects if 2 Partitions on USB - URGENT!!

This problem exists in AnExplorer but not Amaze Explorer, however AnExplorer is required due to its other capabilities.
If an OTG / external USB drive thas just one partition it seems to function Ok. It attaches and stays attached when accessing it.
However if an external USB has Two partitions AnExplorer disconnects from it. Thus that device cannot be used. This is an issue as we are unable to use this product for our many users/staff as the USB required for the project has two partitions.
As mentioned Amaze does not kick the external USB drive however AnExplorer does.
Would appreciate a fix on this please.

This is fixed in the upcoming version 4.0.0


Repeatable jobs do not work properly

Repeatable jobs could not be added correctly via "Add Job".
The job is placed in the "delayed" state and is also executed at the specified time, but never again afterwards. If I create the job directly via the Bull library with the exact same parameters, it remains in the "delayed" state until (if) an end condition occurs.
My concrete example (without end condition):
Job
{   "payload": ... }
Options
{     "repeat": {       "every": 60000     }   }
The job is even given an ID that indicates that it is a "repeatable job", but it is not executed again.

i just copypasted your job config and it looks like everything works as expected. fyi there is no magic under the hood: bull-monitor just passes your job config directly to bull or bullmq  without any preprocessing (except, of course, json parsing)


Fleet Boss Battles Combo Wizard

My first attempt at using the fleet boss battles info directly from player data. Click the red phaser button next to the traits dropdown on the crew player tool to open up the Combo Wizard, which will show open boss nodes and then auto populate fields in the table to find crew that match the desired trait.
Note: this also incorporates #397 to hopefully test Cloudflare page building and to ensure that the removal of the pages doesn't break anything else.

Closing this now. Please use #413, which effectively replaces the combo wizard with a full tool.


Add missing ADC pins for ATSAMD11D

Summary
The ATSAMD11D has 20 or 24 pins. Some of them are also ADC pins, however the traits were not implemented for them.
Checklist

[x] CHANGELOG.md for the BSP or HAL updated
[x] All new or modified code is well documented, especially public items
[x] No new warnings or clippy suggestions have been introduced (see CI or check locally)

@Tremoneck Just took a quick look at the datasheet. Unless I'm missing something, the pin multiplexing table calls out for PA02, PA03, PA04, PA05, PA06, PA07, PA10, PA11, PA14 and PA15 as ADC pins?

@jbeaurivage Sorry for the delay.
While they are ADC pins, they are also available with the C variant. the Traits for these pins is implemented when the feature samd11 is available. That part is right above the code added in this PR.

Right, I should've looked closed. My mistake! Looks good then.


What is deprecated in ServiceOrchestration?

@bzwei https://github.com/ManageIQ/manageiq/blob/master/app/models/service_orchestration.rb#L38
What does this comment apply to?  I'm assuming it applies to the rest of the methods in the model, but I'm questioning it because that seems like a lot of things being deprecated.  Can you let me know if it is just the one method or everything else?
Thanks,
Brandon

@bdunne Only this method is deprecated. Before we had to store the ems_ref of the stack explicitly because the stack object has not yet created in VMDB. Now the object is created beforehand so the ems_ref is always available through orchestration stack object.

Thanks @bzwei


Add Sidecar Technologies to list of who uses Argo

Add Sidecar to the list of organizations that use Argo Workflows.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Can I set an interval time?

I use indicators in a Computationally intensive task, I find using the indicators will make the task slower. if I do not use the indicators, it will take 1min. If I use the indicators, it will take 22min.
I want the tick() not print the bar. Can I set an interval time? Such as print the bar every 5 seconds. I don't kown how to config it.

This can be achieved using IndeterminateProgressBar and threading:

Create a thread that ticks every N seconds, e.g., N = 2 in this example
Once the thread is started, the bar will ticked every 2 seconds in the thread function
Meanwhile, in the main thread, you can do your work
When the work is done, mark the bar as completed - At this point, the thread function will exit

#include <chrono>
#include <indicators/indeterminate_progress_bar.hpp>
#include <thread>

int main() {

  indicators::IndeterminateProgressBar bar{
      indicators::option::BarWidth{40},
      indicators::option::Start{"["},
      indicators::option::Fill{"·"},
      indicators::option::Lead{"<==>"},
      indicators::option::End{"]"},
      indicators::option::PostfixText{"Working"},
      indicators::option::ForegroundColor{indicators::Color::yellow},
      indicators::option::FontStyles{
          std::vector<indicators::FontStyle>{indicators::FontStyle::bold}}
  };

  // This thread will tick the bar every N seconds (N = 2 in this example)
  auto tick_thread = std::thread([&bar](std::chrono::seconds period) {
    while (true) {
      bar.tick();
      if (bar.is_completed())
        break;
      std::this_thread::sleep_for(period);
    }
  },
  std::chrono::seconds(2));

  // do work here
  std::this_thread::sleep_for(std::chrono::seconds(10));
  // when done, stop ticking
  bar.set_option(indicators::option::PostfixText{"Done"});
  bar.mark_as_completed();

  tick_thread.join();

  return 0;
}

But if I use IndeterminateProgressBar, I don't known current progress of task. Maybe the only way is using set_progress  function in a thread.


Add mix, hex2rgb, hex2rgba and alpha.

Hope it help :)

Codecov Report

:exclamation: No coverage uploaded for pull request head (master@d0e02cb).

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e28933d...d0e02cb. Read the comment docs.

Thanks for the PR @ahmed3mar. I will take a look at it this weekend.

@bhough Thanks ^^
@nikgraf Yup i'll try to spit my PR to use it for minimal API and add more testing too =D

@ahmed3mar I'm closing this PR. I would be still happy if you contribute 👍


Search for the exact word

If I search lidar the bot retrieves words like soLIDARietà. Find a way to select the exact word (maybe double quotes?)

😅  I never noticed this, I would actually suggest to change the default to search for words (your suggestion) instead of substrings (current behavoiur) by default


Failed assertion: line 4531 pos 14: 'owner!._debugCurrentBuildTarget == this': is not true.

Steps to Reproduce

Execute flutter run on the code sample
...
...

Expected results:
Actual results:

Code sample

Logs

======== Exception caught by widgets library =======================================================
The following assertion was thrown building AnimatedPhysicalModel(duration: 200ms, shape: rectangle, borderRadius: BorderRadius.zero, elevation: 0.0, color: Color(0xff333739), animateColor: false, shadowColor: Color(0xff000000), animateShadowColor: true, state: _AnimatedPhysicalModelState#9d149(ticker inactive)):
'package:flutter/src/widgets/framework.dart': Failed assertion: line 4531 pos 14: 'owner!._debugCurrentBuildTarget == this': is not true.
Either the assertion indicates an error in the framework itself, or we should provide substantially more information in this error message to help you determine and fix the underlying cause.
In either case, please report this assertion by filing a bug on GitHub:
https://github.com/flutter/flutter/issues/new?template=2_bug.md
The relevant error-causing widget was:
Scaffold Scaffold:file:///C:/Users/helal/Desktop/GitHub/News_App/lib/webview/webview.dart:12:12
When the exception was thrown, this was the stack:
#2      Element.rebuild. (package:flutter/src/widgets/framework.dart:4531:14)
#3      Element.rebuild (package:flutter/src/widgets/framework.dart:4534:6)
#4      ComponentElement._firstBuild (package:flutter/src/widgets/framework.dart:4787:5)


App and DB structure initialization

Initialized server and app and created basic tests w/ 100% coverage.

After removing my template routes, no conflicts with main


As a CIF user, I only want to have one project revision per project in progress in the system, so that my team can collaborate on it

Description:
Right now revisions are owned by individual users and invisible to other users.
We want the system to allow only one revision per project at a time
Acceptance Criteria:
Given
When
Then
Development Checklist:

[ ] Checklist item
[ ] Checklist item
[ ] Checklist item
[ ] Meets the DOD

Definition of Ready (Note: If any of these points are not applicable, mark N/A)

[ ] User story is included
[ ] User role and type are identified
[ ] Acceptance criteria are included
[ ] Wireframes are included (if required)
[ ] Design / Solution is accepted by Product Owner
[ ] Dependencies are identified (technical, business, regulatory/policy)
[ ] Story has been estimated (under 13 pts)

·Definition of Done (Note: If any of these points are not applicable, mark N/A)

[ ] Acceptance criteria are tested by the CI pipeline
[ ] UI meets accessibility requirements
[ ] Configuration changes are documented, documentation and designs are updated
[ ] Passes code peer-review
[ ] Passes QA of Acceptance Criteria with verification in Dev and Test
[ ] Ticket is ready to be merged to main branch
[ ] Can be demoed in Sprint Review
[ ] Bugs or future work cards are identified and created
[ ] Reviewed and approved by Product Owner

Notes:

Team determined this was not the appropriate behaviour for the system


add aside section

Added a side section. Needed to adjust the scope of some of the css to allow for multiple elements of the same type to not be affected.

Looks great!

Thank you, Maxim. 😁This is my first contribution to another project on GitHub! 🤖 I have used GitLab in a software development cohort during another program but, this is special. Thank you for the opportunity. 💪🏽


Document rbenv exec

I'm a Rubynewbie.
In trying to get an existing project set up on my local system, I installed rbenv according to the instructions (I think -- I had a few bits of trouble but ended up in a state where I think it's working correctly), installed the version I need, set it as local, installed bundler, then got stuck trying to run bundle.
It was running the systemwide version, not the local version. I considered adding the local ruby version's gem bin path to my PATH variable but that felt wrong -- isn't rbenv supposed to let me use different versions in different places and not worry about that sort of thing?
Eventually I wondered if there was equivalent of node's npx, and looked at rbenv help and didn't see anything which looked right.
It wasn't until I used the tab-completion rbenv installed on my shell that I saw the exec command. Then I tried rbenv exec and lo and behold, that looks exactly like what I want. So rbenv exec bundle install did what I wanted.
That took me far too long to find. It's not in rbenv help, and it's not in the https://github.com/rbenv/rbenv#command-reference or in the readme at all.
Is this an oversight? Or is it possible I set something up wrong, and I shouldn't need to do this at all?

rbenv-exec is an internal command and, as such, we're trying to discourage interfacing with it directly. That's why it's not clearly documented.
Our philosophy is that you should never need to run rbenv exec bundle yourself. You should only ever run bundle, and that should activate the Bundler version that belongs to the Ruby version selected for the current project. The rbenv project doesn't have nor need an npx equivalent.
If that didn't work for you, it's possible that ~/.rbenv/shims/bundle didn't exist for you, or that the ~/.rbenv/shims isn't prepended to your PATH (see https://github.com/rbenv/rbenv-installer#rbenv-doctor).
In short:

Ensure that the current project has a local version selected, e.g. rbenv local 2.5.5;
Ensure that Bundler is installed for that version, e.g. gem install bundler;
Running bundle should now execute Bundler in Ruby 2.5.5.

OK. I'm not sure what I was doing wrong, but I was certain at least at the time that I had followed all steps correctly, and I know how PATH and which etc work. (Or at least I thought I did.) Anyway, it's working just fine now, finding bundle via the shims. Sorry for the noise.


Require EDIT role for editing metadata in Admin UI

Commit 35af6fe9d780edcccb10267e7b055dae3c1ec1f1 introduced a new modal
where the episode/dublincore metadata of multiple events can be updated simultaneously.
However, editing event metadata should be restricted to those users who have the role
ROLE_UI_EVENTS_DETAILS_METADATA_EDIT
Those with ROLE_UI_EVENTS_DETAILS_METADATA_VIEW do not need POST-Access
to the new multi-edit functionality.
Please double-check but I didn't see how a user who is not supposed to edit meta data
would need access to /admin-ng/event/events/metadata.json
Your pull request should…

[x] have a concise title
[x] close an accompanying issue if one exists
[x] be against the correct branch
[x] include migration scripts and documentation, if appropriate
[x] pass automated tests
[x] have a clean commit history
[x] have proper commit messages (title and body) for all commits

@KatrinIhler can you have a look? It looks like this was an oversight when introducing MH-13718


Can't see Show deprecated Kubernetes patch version for an imported RKE2 clusters

Internal reference: SURE-6772
Reported in 2.7.5
Issue description:
Someone can't see the "Show deprecated Kubernetes patch version" checkbox for an imported RKE2 cluster and as such, one of their users can't upgrade to 1.24.15 that they want. The next available is 1.24.16
Business impact:
The user can't upgrade the prod downstream cluster to the desired version
Troubleshooting steps:
We suggested that option as the troubleshooting step, but it is not available
Repro steps:

Create an RKE2 downstream with version 1.24.9
Import into to Rancher
Attempt to upgrade to 1.24.15

Workaround:
none
Actual behavior:
The checkbox "Show deprecated Kubernetes patch version" is not available
Expected behavior:
The checkbox "Show deprecated Kubernetes patch version" should be available

Will be done as part of the port of this page over to Vue.

This will be fixed once we migrate UI from ember which is currently blocked by BE issue https://github.com/rancher/rancher/issues/43191

Backend should have unblocked this for UI and now we're blocking them. Moving to Next Up.

Upon discussion with product, we won't track this work specifically as a requirement. If it gets fixed as the result of migration, then that's fine.


Upload speed per file is not accurate

rclone version: rclone v1.34-DEV

OS: Ubuntu 16.10 64 bit

cloud storage system: Google Drive

command I was trying to run (removed personal details): rclone copy /local/path/ Cloud:cloud/path --include something

As described in the title the upload speeds per file vary a lot, while I get a pretty constant overall upload speed displayed, for example Transferred:   1.305 GBytes (584.462 kBytes/s)
Here is a screenshot of the problem:

As you can see the sum of the individual speeds does not result in the overall speed. Also the ETA is alternating alot and probably also not very accurate.
Maybe the smothing algorithm could be improved.

It's not an overall speed but an average speed over the last 5 minutes. The individual speeds is at that exact moment. If you transfer speeds wildly fluctuate as yours appear to be doing then you would expect the average will be a lot different.
Looks fine to me.

This is why I asked to also use average speeds for individual speeds for better ETAs and better information.

well I guess 'better' is subjective. No program I use [winscp, filezilla, chrome, windows transfers as examples] average the speed of individual file copy speeds.

That is true, but I think an ETA should not be calculated based on such unreliable data.
And since this program only displays speed in certain intervalls an average speed would make sense here.

Assuming these are big files (> 8MB) then #968 will fix this problem.

Here's a fresh beta with this fixed, give it a try:
https://www.breunig.xyz/share/rclone-beta/v1.36-232-gb2b5c629-drive-accountingβ/
This makes the reported upload speeds for individual files much more accurate. It's still a bit off from the reported global speed, but I guess that's either due to rounding or timing issues. In any case, it's now definitely in the same ball park, unlike before. Turned out this was really easy to fix, too, thanks to @yonjah's work.

Nice one @breunigs :-)


[Feature]: Test running uplift through docker on the top CI providers

Describe your feature
Uplift has recently been published as a docker container, but needs to be tested against the top CI providers, to ensure it can be offered as a potential solution.
List of current identified providers:

[x] - Circle CI
[x] - Drone
[x] - GitLab
[x] - Semaphore CI
[x] - Travis CI
[x] - Cirrus CI
[ ] - Azure
[ ] - Google CloudBuild
[x] - AWS CodeBuild
[x] - AWS CodePipeline
[x] - Codefresh

Uplift will no doubt required permissions on these providers to modify and push changes back to any cloned repository.
Your potential solution
Test uplift on all of the mentioned CI providers and determine what changes, if any, are needed to ensure uplift can run on those providers. Create new issues per provider if required.
Any additional information?
No response
Code of Conduct

[X] I agree to follow this project's Code of Conduct

Raise dedicated tickets to handle Azure and Google CloudBuild testing


Try to use Sancov tables when recording Windows coverage

Includes #842, #843, merge after.

Add Sancov table discovery for Windows modules with debug info
When recording coverage, try to recover coverage blocks from Sancov tables
Not tested against x86-32 targets, but should be close

This PR needs #847 merged to fix the build.


Any plan to enable auto suggest or auto complete when user typing

Hi,
One of the good features for web chat if it can support auto suggestion when user is typing. This kind of feature really benefit to guide user what type of questions can be asked in general.

How would that work? Where do the suggestions come from? Where do they go?

the suggestions can come from external data source(database) access through web api, Let say for close domain chat bot that handle trouble shooting network answer, we can predefined suggestion questions that can be asked by users.

Can you be more specific? You seem to have a clear picture in your mind but I'm not really sure what you're suggesting. As a piece of user experience what does this look like? When are suggestions proffered? Where do they appear?
Most bots do suggestions as messages to the user, e.g. "you can say 'sell stock' or 'buy stock". We can already show suggested answers to questions, e.g. "What would you like to do  ". How does what you're suggested differ from these and (presumably) improve upon them?

Something like this ...

That's an interesting mashup of bots and autocomplete. I'm not sure how to have a bot easily generate a list of possible questions. I suppose, as you say, it could just be a list of predefined questions in a database. I'd be interested in what others had to say about this proposed feature.

I have a set of questions to train in LUIS . Let say i train this question - "What is the weather in Paris?" as get weather intent. User can ask for example "Give me the current weather in Sydney" or "What is the weather tomorrow?" which is also have same intent as get weather intent, so once the intent is correct then we will save it into database as possible questions.
When user type "What is the" , bot can perform auto suggest "What is the weather in Paris?" , "What is the weather tomorrow?"

There is this new API (in preview) Web Language Model (WebLM) API that can be used to automate a variety of natural language processing tasks, such as word frequency or next-word prediction, using advanced language modeling algorithms.
Maybe this could help you achieve this...
https://westus.dev.cognitive.microsoft.com/docs/services/55de9ca4e597ed1fd4e2f104/operations/55de9ca4e597ed19b0de8a50

I don't think the blocker here is the underlying autocomplete technology. It's more to do with who the client is communicating with, and how. Is it talking to LUIS? The bot? A third thing?
I don't think it makes sense to define any of that. Let the developer decide where the responses are coming from, and how.
I think the right solution would be to add a new property to ChatProps called suggestResponses which is a callback returning a Promise. Then a new epic would be added which hooks on to Update_Input actions, and calls suggestResponses. The responses, if any, would then be displayed to the user. The latter is the "hard" part, in that it would require adding a new component and getting the lifecycle right for making it appear, disappear, etc.
However to date @ryzam is the only person asking for this feature.

Agree with you on that @billba, it should be a developer's call. It is a good to have feature as it would ease the user from typing and more importantly guide the user for apt inputs so that the bot can actually narrow down the intent more quickly and precisely... So voting in for this feature too..

I could use this feature in the current bot I'm creating where I need to ask the user what school they need contact information for.

This is an interesting UX question. On the one hand we have cards that let you suggest options to the user. But I can see that when the potential result set is large - e.g. thousands of schools - then autocomplete is the only way to go.

If people are implementing their own autocomplete solutions, we may need to provide a way for them to programmatically populate the textbox.

I would also be interested in seeing autocomplete feature implemented into the WebChat.

Would there be any update on this feature request? or maybe directions on how to achieve it?

(First of all, please let me give you some advice: across all repos everywhere, no updates to an issue means "no updates to report". Not helpful to keep asking if there are any updates.)
As for how to achieve it, there are many ways such a feature could be exposed.
I'm sure there are multiple React components that plug replace a text input with an identical-but-autosuggest-enhanced version. If so, the hard/interesting part of this is probably how it gets the suggestions.
We could probably learn something from MS Teams' great compose extension feature. This is a more structured approach on both the client and server, and it has different strengths and weaknesses than classic autocomplete.
I suspect their approach of using an "invoke" activity to fetch suggestions is the right one, because by definition you would want suggestions to have as much context as possible, and "invoke" is essentially "make an arbitrary query of the the current user context in the bot".
This is potentially a powerful feature but probably not a super urgent one for the product team. This is a great opportunity for a motivated developer to make a big impact to this project.

Hi @billba & @danmarshall . Hi All.
+1 for this request!
Im my experience one of the most commons scenarios nowadays in bots is the FAQ-scenario. This feature would be great benefit for users and successful bot conversations, as it reduces the failure rate of users not asking the questions in the "right way", so in the exact way LUIS (trained utterances of the FAQ intent) and underlying knowledge DB (e.g. QNAMaker or using Azure Search with some DB) need it to have a correct match with highest score. In projects we spend a lot of time of defining questions, and many alternative questions, to a particular answer, and testing all that E2E.
I think the autocomplete approach would largely impact the probability of enabling users to ask the "right" question and find their answer quickly. Also it helps to guide the user and manage his expectations in terms of what QNAs the bot can actually handle (closed world scenario).
Regarding how this could be done:
The following article looks promising, using a combination of Azure Search and Twitters typeahead.js library: https://azure.microsoft.com/de-de/blog/azure-search-how-to-add-suggestions-auto-complete-to-your-search-applications/
However, this is designed for the web, not sure about integration into Microsofts Botframework WebChat?
Also I am wondering if in terms of performance doing a REST API call for every character or word being typed in by the user is feasible.
Thanks and best regards
Jan

I would LOVE to see this feature implemented ASAP - otherwise, we will either implement it ourselves or switch to different bot framework ...

That is a feature of Teams. This proposal is about adding similar functionality to Web Chat.

I was working on implementing this in my fork. Here is an initial change (based on @billba's original suggestion): https://github.com/eklavyamirani/BotFramework-WebChat/pull/1

Here's the exposed hook to fetch suggestions:
samples/fullwindow/index.html#L58
I am still far from done (i.e. not PR ready) but just wanted to throw it out for some initial feedback.

@eklavyamirani in terms of the exposed hook:

What if I had a few different dialogs, where the auto-completion needs are different. I think the hook needs to have an additional 'context' parameter, that tells the completion service provider what kind of auto-completion is requested.
Typically, when a certain form of interaction is needed, this is indicated on the chatbot side as part of the dialog. For instance, I may want to indicate that I want an input with the 'country' auto-completion context, so that when the user types something, the hook gets the correct context, and can do the right thing.
If the eventual goal is to use a REST service to serve the auto-completions, then how do you make sure that the auto-completion request came from a legitimate conversation? There needs to be some mechanism that enables the hook to validate that the request came in from an active conversation.

@bgedik Your questions makes sense. :)
I have been thinking about this, and (in fact, another comment also points to this), it makes sense to keep this as a different kind of interaction that we (debounce and) send via the conversation channel. I'll modify the PR accordingly.
Thank you!

I think that this feature can benefit by the use of Event Activity (or backchannel?)
The bot is the best way to source suggestions as suggestions have to be context specific or else it won't make sense and the bot and client can communicate with each other by passing event activities to and fro.
Let's say the Bot is in a particular action in a Dialog where it is expecting the user to input a country.  that we send, we also send an event with name 'RequestSuggestions' and value "{'context': 'country'}" to the client.
On the client side on receiving the above event, we send a 'SendSuggestions' event with value "{'context': 'country', 'input': 'in'}"
On the bot side (in the MessagesController in C#), we handle the event activity and send the suggestions with another event 'Suggestions' with value being the string array.
When we are in an action where suggestions are not required, the 'RequestSuggestions' event's value "{'context': 'none'}" or can be null to indicate to the client that it doesn't need to ask for suggestions.
Now I do not know how this approach can be translated into React or in what way this can be done or if it can be done in the WebChat.
Probably a new Activity type called 'Suggestions' can be created in Bot Builder but I guess this is too much of an ask.
Please let me know if I am missing something.

We are currently working on a customer project where we have added a custom written autocomplete component to the WebChat.

The C# bot sends an event to the GUI so that it knows at which points in the flow the autocomplete component is expected to become visible. The tricky part was to make the user's speech bubble appear when clicking on a suggestion. For now, I used the hack described in #680 to solve this but would appreciate if this feature finds it way into the official API.

@eklavyamirani Did you have a chance to find an approach that uses the 'conversation channel'?

@bgedik I haven't yet. Unfortunately, I am tied up for a bit and I will pick this up after 2 weeks.

Is there any update on autocomplete @eklavyamirani ?

Is this possible for Teams?

Is there any way to achieve auto suggest or auto complete in Bot framework(Web chat) V3 and nodejs.

Hi, I achieved basic auto suggest using HTML5 and datalist(HTML5 feature) or we can use Jquery Flexdatalist for basic auto suggest.

Looks like this is old topic.. Must have context management framework in the backend, without that the chatbot frameworks is more of rule engine waiting to bomb at some or the other point of time... And if complete site map is not fed properly in the rule engine, there are chances user will not waste time to probe site ( visually ) if autosuggestions didn't give informative results..

Hi @sivanandh, do you have a link to your code?
@tdurnford found a -yet not perfect- approach on Stackoverflow

I managed to replace the original sendBox with my own react-select element on Stackoverflow, using #1826 and @tdurnford response on my post.

We're going to close this issue for now - there is no plans in the roadmap to implement this functionality. Please reference the stack overflow links above to workarounds. Thank you!

I recently implemented an auto-complete feature on the bot creation tool that I am working on. I was wondering if I am one who invented it actually because I have never seen this feature in any other chatbot platform before. If you are interested you can check it here https://botmake.io/page/faq-chatbot

New to msbot framework, but is that possible on the emulator ?  How are you doing this? Is this written in the waterfall steps ?  Can you share ? thanks


fix testtypeid.d for changes to TypeInfo_Const in object.di

temporarily allow both next and base as fields of TypeInfo_Const
Needed for https://github.com/D-Programming-Language/druntime/pull/1182/files and https://github.com/D-Programming-Language/druntime/pull/1222

Auto-merge toggled on


Start timers from Tasks/Tags page

I'm thinking of two different ways to use the App.
One is to be on the time entry page and start/stop timers from there - going into the detail page to edit.
Another is to see it as "Task based" so you're watching a task and starting/stopping timers for different tasks.
Either way, it might be nice to be able to start a timer from those pages.
Possibly having the running timer available on all pages, so you can edit the description, and interact with it.

A timer has been added to the Task page.
Next up is the tag page.


[FEATURE] Add Snyk to Heroku

Describe the solution you'd like
Add Snyk to Heroku, it's free!

Done


Date is getting out of the bound in some months inside downloaded pdf calendar

After downloading calendar as pdf, some dates are getting out of the bound. It might be an issue with css or something auto adjustable problem.
Hint

R & D why the problem is occurring and update required code changes.

Example image of broken calendar getting out of the bound:

Please see PR #24

It's fixed now, I'm closing it.


Samples Repo

Would it be a good idea to have a Get(X) samples repository for flows like I reported?
Seeing full sample code always is a good starting point for using a library.

i agree. Since i didn't understand very well the concepts of bindings and dependency injection, i had trouble in understand. However, by simply reading issues people post here and seeing so many little pieces of code helped me a lot to understand, now it is way clearer.
But what examples would be good? Maybe an app that consumes an API, and other app that use some king of persistent sotrage, like Hive or SharedPreferences
But before doing this, we must wait to see how GetX will be in 3.0, so we can make examples accordingly

I really need to do this!

There is friction in the community about the validity of using GetX. The reality is does it work as expected or are there any hidden issues? Being FREE and open sourced has it's benefits and drawbacks.
By using the GetX package you should know exactly what you are getting from day 1.
Why not have a GetX repository for common, real-world, functional use cases and complete app examples ?
The problem for newcomers is knowing which method will work as expected. It's far easier to search for code snippets and integrate them into your development than to learn and write them from scratch.
Each method can be explained in detail with screenshots to demonstrate exactly what's going on and comparative code through using other methods so that the benefits of GetX are evident.
Take a 'better by design' approach so that once a preferred method is defined it can be refined and completely integrated into an existing framework at any time in the future. This way user will know that it works straight away and that it can only GetX better as the method becomes the de-facto way of implementing the use case. Then it will only become necessary to re-invent the wheel if there is a genuine requirement or operational efficiency.

@jonataslaw, happy to help where I can

I'd love one for initing FCM and Flutter local messages in a bigger MVC app like the current example arch.

i agree. Since i didn't understand very well the concepts of bindings and dependency injection, i had trouble in understand. However, by simply reading issues people post here and seeing so many little pieces of code helped me a lot to understand, now it is way clearer.
But what examples would be good? Maybe an app that consumes an API, and other app that use some king of persistent sotrage, like Hive or SharedPreferences
But before doing this, we must wait to see how GetX will be in 3.0, so we can make examples accordingly

Maybe it's easier if you've come from BLoC, which I was just about to start to learn as it'siin the Manning Flutter book, but came here from Dark Themes Medium post.

Something that has no statefulwidget at all that also maintains state of bottomnavigationbar too. I want to try and get rid of statefulwidget in my app.

I said something like that in gitter... the lack of documentation and samples is pretty huge. :/

What is needed is something like this https://proandroiddev.com/flutter-passwordless-authentication-a-guide-for-phone-email-login-6759252f4e  and https://github.com/hajola/passwordless_flutter THEN refactor using GetX to show the benefits. The example is a well structured, real-world use case has interaction with Firebase, snackbar, Get.to, obx, .value, the only deprecation I've found so far is in an inherited widget. You may be able to see additional functionality within GetX that I'm not aware of that can also be showcased.

+1 to @CHR15TOV 's comment

A todo app? https://github.com/loicgeek/todo_getx , @jonataslaw  if you can check if it is the right way

@jonataslaw Hi, did you get my private message on gmail about Slack? I used email address that's on pub.dev (maybe wrong?)

I would love to get short samples, better sorted. But to write real-world-apps is wasting time. Instead, better sort the docs.

If someone mirrored the flutter samples in a meaningful way, say:
-getx_bolierplate  how to wire it up for app exceptions, logging, zones
-getx_platform_design  all the platform aware both Material and Cupertino
then say some demo apps showing HTTP, persistence etc
As it so happens I have to do this type of pattern demo code for a book series I am writing.
What will aid me in pushing it out is info on how the null-safety of get_test is progressing.
Where might the updated info on that reside at?
I Will open an issue when I have the code finished and the companion site up to give out the URL and info as I am convinced that the get plugin approach to reactive is the right way to teach flutter and so I am focusing my dev book series around it.
Thanks to all the plugin contributors as this plugin is very useful!
And Hello from the United States.
Peace and happy hacking and app designing

GetX template
https://github.com/EmadBeltaje/flutter_getx_template


Introduce asynchronous message processing

This PR fixes #648, #587 and #829 by introducing asynchronous message processing.
The current code calls the ApplicationMessageReceivedHandler synchronously in the packet receiver loop. This blocks KeepAlive and Ack packets from being processed while a message is still being processed.
This PR also fixes the test MQTTnet.Tests/Server_Tests/Same_Client_Id_Connect_Disconnect_Event_Order as it failed on my machine due to a race condition in the MqttClientSessionsManager.
Fixes #648
Fixes #587
Fixes #829

I also tried to fix the UnitTest at the same time so that my change is already there since a couple of minutes 😄 Please merge master into your branch. I am not sure which fix is better but I think your strategy might be better. I added a comment which describes the problem at the SpinWait.
Regarding async processing. There is already an open pull request with that feature. In the comments I proposed to add some parameter in the context of the message handler like other SDKs do in Azure (AcknowlegeMode = Auto|Manual etc.).

@chkr1011 Interesting approach :smile:
I think the strategy without the SpinWait is cleaner. It is also possible that you would need to declare the IsFinalized property as volatile, because it is accessed from different Threads in parallel. (Not sure how often this would cause issues in the real world.)
Regarding PR #875: I think that PR is related but does not fully solve the issue I try to solve in this PR. PR #875 tries to implement concurrent processing which can violate the order of message processing. This might be ok in some use cases, but I think the default should be to maintain the order of message processing.
This PR maintains the order of message processing and just starts one additional Task which dequeues messages from an AsyncQueue. Inside the packet receiver loop the publish packets are just getting enqueued and then the loop continues. This solves the issues I mentioned.
I will rebase this PR onto the master and keep the strategy of this PR for the unit test fix.

Ah OK so only processing of incoming application messages is moved to a dedicated thread right? That is OK for me because as you already said the order of messages is important.
So we have to update the other pull request as discussed there. But this will not affect this PR.
I never used the volatile keyword so I have to read some docs first 😄 But for that special case I do not think it is required because the unit test is running successful and the SpinWait only may run a little bit longer than required.

@PSanetra Please let me know if this pull request is fully updated. Then I will start my review.

@chkr1011 yes I have rebased it again onto the current master. It should now be ready for review.

@chkr1011 the messages in the queue are not lost if they are received via a QoS 1 or QoS 2 subscription as they would be resend after a client restart. QoS 0 messages are semantically allowed to get lost.
Regarding the unbound queue and possible memory leak due to too many messages:
I think in MQTT 3.1.1 there is no mechanism in the protocol which limits the maximum in-flight messages a broker should send to the client. But I guess there should always be a way to configure this in the broker even if this is not part of the MQTT 3.1.1 specification. (E.g. there is such an option in vernemq for QoS 1 and 2 messages which defaults to 20 in-flight messages)
With MQTT 5 it is possible to configure a receive maximum for the connection. The default is 65535. Sadly this is only specified for QoS 1 and QoS 2 publications, too.
Maybe it would be an option to keep processing QoS 0 messages synchronously and QoS 1 and 2 messages asynchronously?! Otherwise this would mean that the issues #648 and #829 will still apply to processing of QoS 0 messages. Another question: Isn't the broker sending the packets anyway even if the client is not handling them? I guess that would mean that the packets are queued by the OS and could maybe result in such a client crash, too?
Another option would be to just drop new messages if the queue would be getting too big. This would be semantically ok for QoS 0 messages. QoS 1 and QoS 2 messages would be resend by the broker as the client would not send PUBACK and PUBREC packets for those messages back to the broker. I think this option is my favorite one.

You are right. I was only thinking about QoS 0. So QoS 1 and 2 are covered. Regarding the flooding of the inflight queue: In my opinion the receival will stop if the receive buffer is full. When I am not wrong this is handled by TCP automatically so sending will stop because the buffer on the other side is full. So there is already a change for package loss even with the current implementation.
I agree that we have to add some limit at broker level. Either a general broker setting (MQTT <= 3.1.1) or an individual value per connection/session (MQTT >= 5.0.0).
TLDR: I think we can proceed with your changes...

One last thing. Please add a one liner in the nuspec describing the change like the already existing entries.

@chkr1011 I have added release notes to the nuspec file.
Should I begin with implementing a packet drop mechanism for the _publishPacketReceiverQueue or should we just rely on the broker to not send more in-flight messages than the client could handle?

@PSanetra In my opinion we need such thing at client and server. Then the users have full control.

@PSanetra Please check the master branch. After merging this PR I get errors in some unit tests like:
Test method MQTTnet.Tests.Client_Tests.Send_Reply_In_Message_Handler threw exception:
System.Exception: Client(s) had 1 errors ($[2020-04-04T21:39:36.9102228Z] [client] [12] [MqttClient] [Error]: Error while handling application message.
System.NullReferenceException: Object reference not set to an instance of an object.
at MQTTnet.Client.MqttClient.PublishAtLeastOnceAsync(MqttPublishPacket publishPacket, CancellationToken cancellationToken) in C:\projects\mqttnet\Source\MQTTnet\Client\MqttClient.

@chkr1011 I can not reproduce the failing test locally and it seems like the test does not fail anymore in the current build. Did you find the cause?

I ended up avoiding to set the adapter to null when disconnecting. It might happen that a running task (especially for strange scenarios in unit tests) is finishing after disconnect and dispose. This thread will access the adapter  for result conversion but it is already set to null.
But there are still other errors in the build log. They do not happen on my machine but often at the build server.


Python example function name typo

The python example won't work with webui.wait(), but with the old name which is webui.loop()

Fixed, I updated https://pypi.org/project/webui2/ to v2.0.3.
Thank you for your report.


Update documentation for Scanner "platform" value

The scanner values.yaml file contains
#Define this variable for openshift platform
platform: ""

This implies that the platform value is optional.  However, this value must be set as per templates/_helpers.tpl:
{{- define "platform" }}
{{- printf "%s" (required "A valid .Values.platform entry required" .Values.platform ) | replace "\n" "" }}
{{- end }}

If the platform value is required then the comment in values.yaml needs to be updated, as well as the assertion in templates_helpers.tpl.  In both cases documentation needs to be provided as to valid values for this key.

Same issue here