Casing of "Id" changed to "ID"

Hi there,
Using protoc-gen-swift 1.2.0 on Mac, I'm compiling the following Example.proto:
syntax = "proto3";

message Example {
    string requestedOfUserId = 1;
}

And I get the following output:
// DO NOT EDIT.
//
// Generated by the Swift generator plugin for the protocol buffer compiler.
// Source: Example.proto
//
// For information on using the generated types, please see the documenation:
//   https://github.com/apple/swift-protobuf/

import Foundation
import SwiftProtobuf

// If the compiler emits an error on this type, it is because this file
// was generated by a version of the `protoc` Swift plug-in that is
// incompatible with the version of SwiftProtobuf to which you are linking.
// Please ensure that your are building against the same version of the API
// that was used to generate this file.
fileprivate struct _GeneratedWithProtocGenSwiftVersion: SwiftProtobuf.ProtobufAPIVersionCheck {
  struct _2: SwiftProtobuf.ProtobufAPIVersion_2 {}
  typealias Version = _2
}

public struct Example {
  // SwiftProtobuf.Message conformance is added in an extension below. See the
  // `Message` and `Message+*Additions` files in the SwiftProtobuf library for
  // methods supported on all messages.

  public var requestedOfUserID: String = String()

  public var unknownFields = SwiftProtobuf.UnknownStorage()

  public init() {}
}

// MARK: - Code below here is support for the SwiftProtobuf runtime.

extension Example: SwiftProtobuf.Message, SwiftProtobuf._MessageImplementationBase, SwiftProtobuf._ProtoNameProviding {
  public static let protoMessageName: String = "Example"
  public static let _protobuf_nameMap: SwiftProtobuf._NameMap = [
    1: .same(proto: "requestedOfUserId"),
  ]

  public mutating func decodeMessage<D: SwiftProtobuf.Decoder>(decoder: inout D) throws {
    while let fieldNumber = try decoder.nextFieldNumber() {
      switch fieldNumber {
      case 1: try decoder.decodeSingularStringField(value: &self.requestedOfUserID)
      default: break
      }
    }
  }

  public func traverse<V: SwiftProtobuf.Visitor>(visitor: inout V) throws {
    if !self.requestedOfUserID.isEmpty {
      try visitor.visitSingularStringField(value: self.requestedOfUserID, fieldNumber: 1)
    }
    try unknownFields.traverse(visitor: &visitor)
  }

  public static func ==(lhs: Example, rhs: Example) -> Bool {
    if lhs.requestedOfUserID != rhs.requestedOfUserID {return false}
    if lhs.unknownFields != rhs.unknownFields {return false}
    return true
  }
}

Note that Example.requestedOfUserID has a capital "D" at the end.
Is this expected behavior?  I'd prefer to keep my specified capitalization, and couldn't find an option to do that.
Thanks!

You may be right.  Unfortunately, given that a lot of people are now using this, changing it seems impractical (it would potentially break a lot of code).
Maybe if/when we do a version 2, we'll consider changing this behavior at that time.

I have encountered the issue. The problem is that the name map when using the .standard enum value, will use lowerCamelCase instead and expose a different string than the property. In the example, it would be requestedOfUserId. This create a problem because we have a custom protobuf implementation that looks at this string to determine a default value to use for JSON serialization (which is not available yet https://github.com/apple/swift-protobuf/issues/861). We use Sourcery with a stencil to generate this default values that parses the swift output of the protobuf code generation which is exposing ID instead of Id. The result is that there's a mismatch. I guess we could modify our stencil to convert ID to Id instead ...


Clarify note in pattern-matching-destructuring.mdx

Clarify the note regarding when clauses versus if clauses regarding ReScript 9.0.
I found the old wording to be confusing, so I tried to improve it.  Please let me know if you want an explanation of what exactly I found to be confusing.

Yeah that might be easier to understand for non-native speakers / language devs. Thanks!


THRIFT-3650 union (and optionals) serialization

Contains all fixes for THRIFT-3650, 3652, 3654 and 3656 (4 patches)

+1 on the Dart fix, thanks


Error running tutorial

The tutorial uses a numba method for binning which gives out an error
---------------------------------------------------------------------------
TypingError                               Traceback (most recent call last)
File <timed exec>:1, in <module>

File ~/sed/sed/binning.py:83, in bin_partition(part, binDict, binAxes, binRanges, nBins, hist_mode, jitterParams, return_edges)
     [80](file:///home/zains/sed/sed/binning.py?line=79) vals = part.values[:, binColumns]
     [82](file:///home/zains/sed/sed/binning.py?line=81) if hist_mode == "numba":
---> [83](file:///home/zains/sed/sed/binning.py?line=82)     hist_partition, edges = numba_histogramdd(
     [84](file:///home/zains/sed/sed/binning.py?line=83)         vals,
     [85](file:///home/zains/sed/sed/binning.py?line=84)         bins=nBins,
     [86](file:///home/zains/sed/sed/binning.py?line=85)         ranges=binRanges,
     [87](file:///home/zains/sed/sed/binning.py?line=86)     )
     [88](file:///home/zains/sed/sed/binning.py?line=87) elif hist_mode == "numpy":
     [89](file:///home/zains/sed/sed/binning.py?line=88)     hist_partition, edges = np.histogramdd(
     [90](file:///home/zains/sed/sed/binning.py?line=89)         vals,
     [91](file:///home/zains/sed/sed/binning.py?line=90)         bins=nBins,
     [92](file:///home/zains/sed/sed/binning.py?line=91)         range=binRanges,
     [93](file:///home/zains/sed/sed/binning.py?line=92)     )

File ~/sed/sed/binning.py:435, in numba_histogramdd(sample, bins, ranges)
    [431](file:///home/zains/sed/sed/binning.py?line=430)     edges[i] = np.linspace(*ranges[i, :], bins[i] + 1)
    [433](file:///home/zains/sed/sed/binning.py?line=432)     nbin[i] = len(edges[i]) + 1  # includes an outlier on each end
--> [435](file:///home/zains/sed/sed/binning.py?line=434) hist = _hist_from_bin_ranges(sample, bins, ranges)
    [437](file:///home/zains/sed/sed/binning.py?line=436) if (hist.shape != nbin - 2).any():
    [438](file:///home/zains/sed/sed/binning.py?line=437)     raise RuntimeError("Internal Shape Error")

File ~/.cache/pypoetry/virtualenvs/sed-GVhCdIOu-py3.10/lib/python3.10/site-packages/numba/core/dispatcher.py:468, in _DispatcherBase._compile_for_args(self, *args, **kws)
    [464](file:///home/zains/.cache/pypoetry/virtualenvs/sed-GVhCdIOu-py3.10/lib/python3.10/site-packages/numba/core/dispatcher.py?line=463)         msg = (f"{str(e).rstrip()} \n\nThis error may have been caused "
    [465](file:///home/zains/.cache/pypoetry/virtualenvs/sed-GVhCdIOu-py3.10/lib/python3.10/site-packages/numba/core/dispatcher.py?line=464)                f"by the following argument(s):\n{args_str}\n")
    [466](file:///home/zains/.cache/pypoetry/virtualenvs/sed-GVhCdIOu-py3.10/lib/python3.10/site-packages/numba/core/dispatcher.py?line=465)         e.patch_message(msg)
--> [468](file:///home/zains/.cache/pypoetry/virtualenvs/sed-GVhCdIOu-py3.10/lib/python3.10/site-packages/numba/core/dispatcher.py?line=467)     error_rewrite(e, 'typing')
    [469](file:///home/zains/.cache/pypoetry/virtualenvs/sed-GVhCdIOu-py3.10/lib/python3.10/site-packages/numba/core/dispatcher.py?line=468) except errors.UnsupportedError as e:
    [470](file:///home/zains/.cache/pypoetry/virtualenvs/sed-GVhCdIOu-py3.10/lib/python3.10/site-packages/numba/core/dispatcher.py?line=469)     # Something unsupported is present in the user code, add help info
    [471](file:///home/zains/.cache/pypoetry/virtualenvs/sed-GVhCdIOu-py3.10/lib/python3.10/site-packages/numba/core/dispatcher.py?line=470)     error_rewrite(e, 'unsupported_error')

File ~/.cache/pypoetry/virtualenvs/sed-GVhCdIOu-py3.10/lib/python3.10/site-packages/numba/core/dispatcher.py:409, in _DispatcherBase._compile_for_args.<locals>.error_rewrite(e, issue_type)
    [407](file:///home/zains/.cache/pypoetry/virtualenvs/sed-GVhCdIOu-py3.10/lib/python3.10/site-packages/numba/core/dispatcher.py?line=406)     raise e
    [408](file:///home/zains/.cache/pypoetry/virtualenvs/sed-GVhCdIOu-py3.10/lib/python3.10/site-packages/numba/core/dispatcher.py?line=407) else:
--> [409](file:///home/zains/.cache/pypoetry/virtualenvs/sed-GVhCdIOu-py3.10/lib/python3.10/site-packages/numba/core/dispatcher.py?line=408)     raise e.with_traceback(None)

TypingError: Failed in nopython mode pipeline (step: nopython frontend)
No implementation of function Function(<built-in function zeros>) found for signature:

 >>> zeros(array(int64, 1d, C), class(uint32))

There are 4 candidate implementations:
   - Of which 4 did not match due to:
   Overload in function '_OverloadWrapper._build.<locals>.ol_generated': File: numba/core/overload_glue.py: Line 131.
     With argument(s): '(array(int64, 1d, C), class(uint32))':
    Rejected as the implementation raised a specific error:
      TypingError: Failed in nopython mode pipeline (step: nopython frontend)
    No implementation of function Function(<intrinsic stub>) found for signature:

     >>> stub(array(int64, 1d, C), class(uint32))

    There are 2 candidate implementations:
      - Of which 2 did not match due to:
      Intrinsic of function 'stub': File: numba/core/overload_glue.py: Line 35.
        With argument(s): '(array(int64, 1d, C), class(uint32))':
       No match.

    During: resolving callee type: Function(<intrinsic stub>)
    During: typing of call at <string> (3)

    File "<string>", line 3:
    <source missing, REPL/exec in use?>

  raised from /home/zains/.cache/pypoetry/virtualenvs/sed-GVhCdIOu-py3.10/lib/python3.10/site-packages/numba/core/typeinfer.py:1086

During: resolving callee type: Function(<built-in function zeros>)
During: typing of call at /home/zains/sed/sed/binning.py (344)

File "../sed/binning.py", line 344:
def _hist_from_bin_ranges(
    <source elided>

    H = np.zeros(bins, np.uint32)
    ^

secondly, the tutorial requires matplotlib. Should this be part of the poetry package dependencies or an optional one?

Hi @zainsohail04 thanks for reporting this.
I can not replicate the error you're getting in the machine I'm using (a node in maxwell) using a venv I set it up for testing.
My suspicion is you're getting that error due to some missing dependencies. I'll try to replicate the error from a clean venv where only the dependencies from poetry are installed. We should be able to run everything installing only those.
Regarding your second question, you're right. Do you want to make a PR :)?
I didn't check the tutorial itself, but I guess as this library will also have some methods for plotting, it's a good idea to include it. Any thoughts against this @steinnymir ?

Nothing against! Matplotlib is pretty basic, so adding it as dependency shouldn't create issues.
I cannot test the code at the moment, but I might take a look next week...

Please check https://github.com/OpenCOMPES/sed/pull/47


Fix unsafe lifecycle implementation

Fix unsafe lifecycle initial implementation changed updating state from props before component is rendered to after component is rendered. This commit uses getDerivedStateFromProps to restore updating state from props back to before render.

yarn test passes on both Windows and macOS but not Travis-CI, any idea how to get same results locally?


Fix indentation

[x] npm run test succeeds.
[x] npm run lint succeeds.
[x] Appropriate changes to README are included in PR.

We should also add a lint rule to stop Thisbe from happening again.


Setup development environment for streaming job

Synopsis
As a Databricks developer
I want a good developer experience
So that I can be productive and efficient when developing
Supporting Information
Team Joules has quite some experience setting up these kind of things and are happy to help.
Joules has a setup supporting debugging using F5 in VSCode.
Joules has documented at least parts of there knowledge in their repo.
Acceptance Criteria
AC1: A developer has a stable development environment (this probably excludes CodeSpaces and suggests Docker)
AC2: A developer can easily execute the pytest testsuite successfully
AC3: A developer can easily debug any pytest test
AC4: A developer can easily execute the streaming job
AC5: A developer can easily debug the streaming job
AC6: All previous ACs has suitable public documentation
Nice to have:
AC7: A developer can use the same filesystem in the (devcontainer) environment as on the local machine
(this enables more flexible file/folder manipulation operations without having to e.g. push/pull a branch)

@BjarkeMeier, it might be implicit but we have struggled a lot with IntelliSense and the possibility to navigate between methods etc. This part would be nice to have represented as an AC as well as we still struggle to have a consistent environment where IntelliSense works every time.

Great suggestion @mknic. Thanks, added.

Remarks for review and test:
In general: We have chosen Visual Studio Code and Docker containerization as development environment in the Time Series domain. The use of various VS Code extensions are essential for fulfillment of several AC's.
AC1: A stable development environment is established using Docker
AC2 and 3: Easy execution of the pytest test suite can be carried out with Python Test Explorer
AC4 and 5: With the combination of VS Code and Docker a developer can easily run (Ctrl + F5) and debug (F5) code
AC6: All other ACs have been documented in the Time Series Streaming Job readme.md file
AC7 and 7: Handled by Python and Pylance extensions
Nice to have:
AC9: With Docker and VS Code a developer can easily write new code, run and debug without the push/pull-task. Some operations, like manipulation of container settings require a rebuild of the docker container but this can be performed easily using the Remote - Containers extension.


wasi-sdk-11 release: 18.04 deb missing?

I don't see a 18.04 deb in https://github.com/WebAssembly/wasi-sdk/releases/tag/wasi-sdk-11. Is 16.04 mislabeled?

Sounds good to me. I am hesitant to rename the files currently in the release because I (and maybe others?) already download them in CI scripts. We could instead re-upload the 16.04 one with the suffix dropped, and stick to that process in the future.


RuntimeError: Expected 3-dimensional tensor

When I use this model file: whisper_frontend_mesonet_mfcc.yaml, the following error occurs.
RuntimeError: Expected 3-dimensional tensor, but got 2-dimensional tensor for argument #1 'self' (while checking arguments for adaptive_avg_pool1d)

Hi,
can you please provide command you run, along with the related config and error stack trace?
Does this problem occurs when you run src/models/whisper_meso_net.py?

Hi, I have the same issue whenever I use every type of model with mesonet (whisper_mesonet, mfcc_mesonet,  whisper_mfcc_mesonet). The problem occurs in file  https://github.com/piotrkawa/deepfake-whisper-features/blob/main/src/models/meso_net.py  in the 110 line. I will be grateful for help :)

You can try these
￼

2024年6月25日 19:10，JGajewska @.***> 写道：
Hi, I have the same issue whenever I use every type of model with mesonet (whisper_mesonet, mfcc_mesonet, whisper_mfcc_mesonet). The problem occurs in file https://github.com/piotrkawa/deepfake-whisper-features/blob/main/src/models/meso_net.py in the 110 line. I will be grateful for help :)
—
Reply to this email directly, view it on GitHub https://github.com/piotrkawa/deepfake-whisper-features/issues/11#issuecomment-2188649271, or unsubscribe https://github.com/notifications/unsubscribe-auth/AJCDH6MAOEPRRUN7QW2XFL3ZJFFZJAVCNFSM6AAAAABJ3TQSMGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCOBYGY2DSMRXGE.
You are receiving this because you authored the thread.

In my case, the issue was incorrectly configured in the conda environment.  Theoretically "conda list" showed loaded correct versions of packages (especially torch, and torchaudio), but in practice, python saw different versions. When I created carefully once again my virtual environment and made sure that Python saw the correct versions, everything started working well. :)


Add predict model, random_search_cv_scores.csv, environment file

Added random_search_cv_scores.csv which contains scores of cross validation folds in randomized search.

Okay I actually need to clarify something, in your random search code, you test for these values of C: [0.001, 0.01, 0.1, 1, 10, 100, 1000], but in the random_scores_cv data set, the splits are only seen for values up until 100, it that because random search does not necessarily test for all values of C provided?

@Arushi282 Yes, I think randomized search doesn't go over each value in the range plus I also set the max_iter i.e. maximum iterations so it's possible that iterations were exhausted by C = 100. Hope this clarifies.

Please let me know, if it is ready for the merge. I think @Arushi282 needs to confirm, as this merge can cause conflicts for her PR. @karanpreetkaur if she is okay, I can merge it as well.


HHH-15514 EntityTestCase Test failures with Hibernate ORM when run under security manager

https://hibernate.atlassian.net/browse/HHH-15514
https://issues.redhat.com/browse/WFLY-16974
Signed-off-by: Scott Marlow<EMAIL_ADDRESS>

The code changes are a result of bringing some changes from ORM 5.3 into ORM 6.1.
https://gist.github.com/scottmarlow/28215540cb43ecc31c65f80a01ca8577 shows the  ORM 6.1 generated proxy bytecode with this pull request in use.
https://gist.github.com/scottmarlow/2c602fcfa8512b904c4c0776a88b8152 shows the ORM 6.1 generated proxy bytecode without this pull request.
Some bytecode differences are shown below.
Without this pull request, the constructor contained:
static {};
    descriptor: ()V
    flags: (0x0008) ACC_STATIC
    Code:
      stack=6, locals=0, args_size=0
         0: ldc           #4                  // class org/jboss/as/test/integration/jpa/hibernate/entity/Flight
         2: ldc           #129                // String setId
         4: iconst_1
         5: anewarray     #131                // class java/lang/Class
         8: dup
         9: iconst_0
        10: ldc           #110                // class java/lang/Long
        12: aastore
        13: invokevirtual #135                // Method java/lang/Class.getMethod:(Ljava/lang/String;[Ljava/lang/Class;)Ljava/lang/reflect/Method;
        16: putstatic     #68                 // Field cachedValue$46XiMV0y$m7ui7t3:Ljava/lang/reflect/Method;

Note that the invokevirtual call above is using Java Reflection which is corrected below to instead use existing org/hibernate/bytecode/internal/bytebuddy/HibernateMethodLookupDispatcher.getMethod.
After this pull request is applied, the constructor contains:
static {};
    descriptor: ()V
    flags: (0x0008) ACC_STATIC
    Code:
      stack=6, locals=0, args_size=0
         0: ldc           #4                  // class org/jboss/as/test/integration/jpa/hibernate/entity/Flight
         2: ldc           #129                // String setId
         4: iconst_1
         5: anewarray     #131                // class java/lang/Class
         8: dup
         9: iconst_0
        10: ldc           #110                // class java/lang/Long
        12: aastore
        13: invokestatic  #137                // Method org/hibernate/bytecode/internal/bytebuddy/HibernateMethodLookupDispatcher.getMethod:(Ljava/lang/Class;Ljava/lang/String;[Ljava/lang/Class;)Ljava/lang/reflect/Method;
        16: putstatic     #83                 // Field cachedValue$C57bfeB4$m7ui7t3:Ljava/lang/reflect/Method;

I looked at the code and it seems to me that you only moved code from static inner class SecurityManagerClassRewriter into ByteBuddyState. I'm having a hard time understanding how this can affect the generated byte code. Can you help me understand this?
From the bytecode you posted, I understand that the constructor rewriting didn't happen. The only explanation that would make sense is that ByteBuddyState is initialized at a point in time when no security manager is installed yet. Is that the case?

I looked at the code too and may be we are just missing something but as @beikov I was not able to understand how this change can affect the generated code

I verified locally that testing wildfly with Hibernate ORM 6.1.3.Final sees the failure.  I then verified that switching to my local build of Hibernate ORM 6.1.4-SNAPSHOT, the test passes.

I looked at the code and it seems to me that you only moved code from static inner class SecurityManagerClassRewriter into ByteBuddyState. I'm having a hard time understanding how this can affect the generated byte code. Can you help me understand this?

https://github.com/hibernate/hibernate-orm/pull/5328/files#diff-0916713f1d03407fd545d95b4d8b75fbf3e5ace094c609837db7958423981e45R249 contains one of the important changes which replaces the application calling java.lang.Class#getMethod directly, to instead call the Hibernate ORM HibernateMethodLookupDispatcher#getDeclaredMethod which is more trusted (by the WildFly Security Manager) than the application code.  In order for the application code to be trusted, the application has to include a custom permissions.xml stating that application code can be trusted to [accessDeclaredMembers](https://docs.oracle.com/javase/8/docs/api/java/lang/RuntimePermission.html).

From the bytecode you posted, I understand that the constructor rewriting didn't happen. The only explanation that would make sense is that ByteBuddyState is initialized at a point in time when no security manager is installed yet. Is that the case?

I did single step through the Hibernate ORM proxy generating code a few times and verified that the security manager is installed (it gets setup during WildFly server startup before any applications are deployed).

I looked at the code too and may be we are just missing something but as @beikov I was not able to understand how this change can affect the generated code

Should we add a comment around the HibernateMethodLookupDispatcher reference?  Perhaps something like:
// Instead of the application calling java.lang.Class#getMethod directly, call the Hibernate ORM HibernateMethodLookupDispatcher#getDeclaredMethod which is more trusted (by the Security Manager) than the application code.

Superseded by https://github.com/hibernate/hibernate-orm/pull/5334


Add new resources

zypper_repository
apt_preference
launchd
osx_profile
powershell_package
systemd_unit
windows_path
windows_task

Adds new resources we've added to core chef. It would be great to get a release out with these to help out cookbook authors.

LGTM merged.


:bug: fix: slove loading was not stop

💻 变更类型 | Change Type

[ ] ✨ feat
[x] 🐛 fix
[ ] 💄 style
[ ] 🔨 chore
[ ] 📝 docs

🔀 变更说明 | Description of Change

📝 补充信息 | Additional Information

link: https://github.com/ant-design/pro-chat/issues/119


chore(deps): update common-dev-assets digest to 96f7642

This PR contains the following updates:

Package
Update
Change

common-dev-assets
digest
aab307f -> 96f7642

Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.

[ ] If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

/run pipeline

/run pipeline

/run pipeline

:tada: This PR is included in version 1.0.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


chore(deps): upgrade dependencies

Upgrades project dependencies. See details in workflow run.

Automatically created by projen via the "upgrade-main" workflow

Codecov Report

Merging #673 (9853cfc) into main (b699000) will not change coverage.
The diff coverage is n/a.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
@@           Coverage Diff           @@
##             main     #673   +/-   ##
=======================================
  Coverage   95.69%   95.69%
=======================================
  Files           1        1
  Lines         395      395
  Branches       53       53
=======================================
  Hits          378      378
  Misses         17       17


UVVM code compiled in Questasim generates a lot of warnings

Please see attached list of warnings.
uvvm_warnings.txt
Versions:
This project uses the following versions:
uvvm_vvc_framework, version v2.5.0
uvvm_util, version v2.9.0
bitvis_vip_sbi, version v2.2.0
bitvis_vip_uart, version v2.2.0
bitvis_uart, version v1.1.4
bitvis_irqc, version v1.0.8
bitvis_vip_axilite, version v2.2.0
bitvis_vip_axistream, version v4.2.0
bitvis_vip_avalon_mm, version v2.2.0
bitvis_vip_i2c, version v2.2.0
bitvis_vip_spi, version v3.3.0
bitvis_vip_gpio, version v1.3.0
bitvis_vip_scoreboard, version v2.0.0
bitvis_vip_clock_generator, version v1.1.0

Hi,
You can simply use the following directive to remove the warnings when you compile the code:
-suppress 1346,1236,1090,1515
Best regards,
Erick

Thanks Erick for the suggestion. I of course thought of it too. I believe there is no easy solution to fix those issues on UVVM level due to VHDL being most annoying language?


Update containerd tarball download

Update to latest release, especially due to runc CVE patch and delivery
in latest release.
Signed-off-by: Phil Estes<EMAIL_ADDRESS>

This should be fixed on master.


Log in - Apple icon is not present

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Issue found when executing PR https://github.com/Expensify/App/pull/16723
Action Performed:

Open https://staging.new.expensify.com/

Expected Result:
Apple icon is present and clickable, user is able to login using Apple ID
Actual Result:
Apple icon is NOT present and space under "Sign in with" is not clickable
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android / native
[ ] Android / Chrome
[ ] iOS / native
[x] iOS / Safari
[x] MacOS / Chrome / Safari
[ ] MacOS / Desktop

Version Number: <IP_ADDRESS>
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

:wave: Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

Identify the pull request that introduced this issue and revert it.
Find someone who can quickly fix the issue.
Fix the issue yourself.

Yep!

We're working on it here: https://github.com/Expensify/App/pull/16723#issuecomment-1642724913

Hey gonna keep this open until a fix is CP'd

Apple sign-in PR reverted


Handle invalid Unicode characters during import CSV upload

Currently, if you pass in a CSV file with an invalid unicode character during import (see this article for more details) it just throws an exception (ArgumentError (invalid byte sequence in UTF-8)) and sends back a 500 error, so the user has no idea what's going on. We should either sanitize our inputs (see the previously linked article) or rescue the exception.

I'm having trouble replicating this issue -- I'm uploading a CSV with several invalid unicode characters, but they're not being processed properly. For instance, having Amazon Basics 60-inch \255 in the CSV simply turns into "Amazon Basics 60-inch \255", with no errors (gsub works and everything).

I don't know if that will work - the CSV file itself is probably unicode-encoded, so I'm not sure that \255 is read by Ruby as that unicode character, as compared to that set of four characters. I'm not sure exactly how you'd go about entering one of those characters; I'm sure there's a way to enter a custom character in vim but I wouldn't know it off the top of my head. Hope that helps!
P.S. While looking into this I remembered the bug that prompted this; a user tried to upload a CSV file with spaces between the headers (e.g. name, max_per_user, max_checkout_length,... vs name,max_per_user,max_checkout_length,...). Since this seems like a common user error, adding this to our CSV validations would be awesome :smile:!

oh okay that makes sense.
I'll add that to the validations!

for posterity: here's how to insert characters by value in vim.


About mdc-1200

Can this firmware communicate with other brands of radios in MDC? Decode and encode Motorola's MDC-ID (four digit number).

If you're too lazy to read the code to find out, I'm not going to do it for you.


getkubeshark.io doesn't exist

Describe the bug
kubeshark install points to getkubeshark.io which doesn't exist
To Reproduce
kubeshark install
Hello! This command can be used to install Kubeshark Pro edition on your Kubernetes cluster.
Please run:
kubeshark install -o | kubectl apply -n kubeshark -f -
or use helm chart as described in **https://getkubeshark.io/**docs/installing-kubeshark/centralized-installation
whois getkubeshark.io
Domain not found.
Expected behavior
Pointed to an existing domain
Desktop (please complete the following information):

OS: Linux

Additional context
Also I can't really find any info on Kubeshark Pro edition...

Also:
kubeshark install -o | kubectl apply -n kubeshark -f -
Failed getting install template, err: got response with status code: 404, body: NoSuchKeyThe specified key does not exist.No such object: static.up9.io/kubeshark/helm-template/helm-template.yaml
error: no objects passed to apply

Hi ! Is there any way to use the install command or find the helm chart somewhere at the moment ? Thanks for the amazing tool it's really great !


Which events are being fired when an ad is paused due to loading difficulties?

When an ad starts but not completely loaded, sometimes the ad's progress time reach the end of the loaded time. I want to have an indication for that, because it is important for me to know when an ad paused.
I know the AdPaused event is fired when the user intentionally pause the ad, but is there an event that is being fired when the ad is paused due to other difficulties?
If there is not, is it possible to add an event like that?

Looking at the spec:
http://www.iab.com/wp-content/uploads/2015/06/VPAID_2_0_Final_04-10-2012.pdf
3.3 Dispatched Events...
I don't see any event from VPAID that would give that...
What you can use is the getAdRemainingTime() to see if the time is progressing or not:
from the documentation:
"If the property is not implemented, the ad unit returns a value of -1. A value of -2 is returned
when time remaining is unknown. Unknown remaining time usually indicates that a user is
actively engaged with the ad."

Thanks for the response.
I have implemented something similar to what you suggested.


Question: How do I filter and compare for azp claim in JWT token

If you are reporting any crash or any potential security issue, do not
open an issue in this repo. Please report the issue via emailing
<EMAIL_ADDRESS>where the issue will be triaged appropriately.
Title: How do I filter and compare for azp claim in JWT token?
Description:

Describe the issue.
I have the following config: for the JWT Authentication Filter

providers:
    keycloak:
        issuer: https://<keycloak_host>/auth/realms/<keycloak_realm>
        audiences: # this allows me to check that `aud` claim is equal to `my-audience`
            - my-audience
        ... # remote_jwks configuration omitted
    rules:
      - match:
            prefix: /
        requires:
            provider_name: keycloak

How can I add config to verify that the azp claim is equal to my-azp, for example?
Saw that Istio has this request.auth.presenter condition, is this possible to do in envoy?
Any help is much appreciated, thank you!
[optional Relevant Links:]

Any extra documentation required to understand the issue.

@qiwzhang

Sorry, we currently don't check other claim fields beside "aud".   Checking claim fields is part of "authorization", it seems it should not be here.   You can add RBAC filter for that.

Okie, thanks for clarifying!


Update the description of the github page and other info

See: https://github.com/lfenergyarchitecturemodel/.github/pull/6


fontFace settings reset to default after upgrading to 0.11.1072.0

Environment
Windows build number: 10.0.19608.0
Windows Terminal version (if applicable): 0.11.1072.0

Any other software? Lots, but nothing relevant to this issue

Steps to reproduce
I dont think its a reliable repro, but updating to 0.11.1072.0 through the Microsoft Store on my laptop this morning seems to have been what caused this. I am happy to provide logs if they exist, but I couldnt find any. After this happened, I updated on my desktop (which is on 19H2/non-insider, as opposed to my insider fast laptop) and this did not repro. However, while backing up my settings on my desktop, I noticed that the settings path did change during the upgrade - it went from profiles.json to settings.json transparently. Perhaps there was some data migration going on that was successful on my desktop but not on my laptop?
Expected behavior
fontFace setting is not reset to default
Actual behavior
fontFace setting is reset to default. I had only made two modifications to my terminal settings, and the other (the default profile guid) was unimpacted by the update.

I don't think reseting custimizations after upgrading in a prerelease can be considered an issue. It's just what happens when using alpha/beta builds.

Ah, this was likely caused by https://github.com/microsoft/terminal/pull/5190, and thus probably intentional. With that being said, I dont think its fair to say that you should expect settings to be lost in a beta build -- I am fine with losing settings, but losing them without knowing ahead of time means it might be a bug that needs fixing, hence the issue.


reimplement find_solid_bc searching algorithm as a seperate function

move the searching algorithm outside the find_solid_bc function so the code is cleaner and reusable. Notice that now the function has to return int instead of unsigned int to handle points that are outside fluid box.

+1


Store Album Art URLs when you call GetTopAlbums.

GetTopAlbums returns AlbumArt information alongside the TopAlbums.
We should store this in the Album() info variable, so we don't have to follow up with an additional GetInfo() call if we want the Album Art.
This change means that calling both user.get_top_albums(), and then album.get_cover_image(), only requires a single API Call.
Changes proposed in this pull request:

_extract_top_albums() now extracts Image URLs from the returned GetTopAlbumResponse
This is saved to a dict, which is passed to an Album() constructor as info.

Thanks for the contribution!
Sounds reasonable, we already have info to save images (from https://github.com/pylast/pylast/pull/264).
How about also storing the SIZE_MEGA image?
Or, rather than hardcoding the sizes, do something similar to get_cover_image...
    def get_cover_image(self, size=SIZE_EXTRA_LARGE):
        """
        Returns a URI to the cover image
        size can be one of:
            SIZE_EXTRA_LARGE
            SIZE_LARGE
            SIZE_MEDIUM
            SIZE_SMALL
        """
        if "image" not in self.info:
            self.info["image"] = _extract_all(
                self._request(self.ws_prefix + ".getInfo", cacheable=True), "image"
            )
        return self.info["image"][size]

... extract all in a single call. For example (I've not tested this):
        info = {"image": _extract_all(node, "image")}

And maybe add a test or update test_user_top_albums?

Sounds good!
I moved it over to using _extract_all, and added an assert into test_user_top_albums

Thanks!


Error in my camera button state

The way the mute of own camera button works, has been destroyed in the last commits.
I enter a room with audio and video. I see my video. Now I go into settings and change my camera. The camera changes, but the button on my camera turns to red. Now I can click it as many times I want but it stays red although I'm seeing the video.

I see that in the store.settings I have videoMuted = true. Maybe it is the problem with the store? @so010

Found it, in RoomClient.js in1458 we must add the following line
store.dispatch(settingsActions.setVideoMuted(false));


enhance: Change night  and day mode icon

Closes #61

Description

Screenshots (if applicable)
original screenshot

updated screenshot

Checklist

[x] My code adheres to the established style guidelines of the project.
[x] I have included comments in areas that may be difficult to understand.
[x] My changes have not introduced any new warnings.
[x] I have conducted a self-review of my code.

Hey @BamaCharanChhandogi,
Thanks for the patch but this will not be considered for IWOC.

Okay, 👍


Improved uml modelling editor

Is your feature request related to a problem?
We've been using the uml modelling tools internal to Artemis at uni in passau, e.g. the apollon editor to complete homework assignments. The editor obviously has many flaws that could be addressed, for example the lack of zoom in/out, no rectangular selections and Actor stickfigures in UseCase Diagrams don't respond to clicks in their entire bounding box. And the list goes on.
Describe the solution you'd like
I'd like to use a thought through editor that supports the most common kinds of uml diagrams well and is reasonably usable.
Is there an ongoing effort to get the editor to be good and if there is none: Can people like me contribute by coding up a new editor from scratch that actually works well and integrates with Artemis? And will that pull-request be accepted?
Describe alternatives you've considered
No response
Additional context
No response

We keep Apollon intentionally simple to use to avoid a completely crowded experience as in other UML editors, however zoom options and rectangular selection are definitely features we want to implement in the future. Additional usability improvements are welcome as well.
There is a separate Apollon repository and I would suggest that you create concrete issues with improvement suggestions there and consider contributing a pull request there. Such contributions are highly welcome
However, please keep in mind that implementing such features in a good quality can be quite challenging. So don't underestimate the effort.

Thank you for the quick answer.

Relevant issues have been/will be created in https://github.com/ls1intum/Apollon.
Therefore closing this issue here.


AttributeError: 'FileUnicodeMap' object has no attribute 'add_code2cid'

I am getting an exception when I try to process_page on the following PDF:
https://www.docketalarm.com/cases/PTAB/IPR2014-00396/Inter_Partes_Review_of_U.S._Pat._7310111/docs/02-20-2014-POR-1773/Power_of_Attorney-5-Power_of_Attorney.pdf
The PDF is digitally signed and I bet that has something to do with it.  I don't understand digital signatures or this code well enough to debug it. If you can spot the issue quickly, that would be great.
Stack trace:
 File "..\libs\pdfminer\pdfinterp.py", line 757, in process_page
    self.render_contents(page.resources, page.contents, ctm=ctm)
  File "..\libs\pdfminer\pdfinterp.py", line 770, in render_contents
    self.execute(list_value(streams))
  File "..\libs\pdfminer\pdfinterp.py", line 795, in execute
    func(*args)
  File "..\libs\pdfminer\pdfinterp.py", line 733, in do_Do
    interpreter.render_contents(resources, [xobj], ctm=mult_matrix(matrix, self.ctm))
  File "..\libs\pdfminer\pdfinterp.py", line 768, in render_contents
    self.init_resources(resources)
  File "..\libs\pdfminer\pdfinterp.py", line 339, in init_resources
    self.fontmap[fontid] = self.rsrcmgr.get_font(objid, spec)
  File "..\libs\pdfminer\pdfinterp.py", line 193, in get_font
    font = self.get_font(None, subspec)
  File "..\libs\pdfminer\pdfinterp.py", line 184, in get_font
    font = PDFCIDFont(self, spec)
  File "..\libs\pdfminer\pdffont.py", line 637, in __init__
    CMapParser(self.unicode_map, StringIO(strm.get_data())).run()
  File "..\libs\pdfminer\cmapdb.py", line 292, in run
    self.nextobject()
  File "..\libs\pdfminer\psparser.py", line 584, in nextobject
    self.do_keyword(pos, token)
  File "..\libs\pdfminer\cmapdb.py", line 354, in do_keyword
    self.cmap.add_code2cid(x, cid+i)
AttributeError: 'FileUnicodeMap' object has no attribute 'add_code2cid'

I was hitting this bug and would like to ask a favor, I hope that's ok.
To help prevent everyone from needing to run setup.py install from the source, it would be awesome if you could update the PyPI package (to have this fix and others).
The latest on PyPI claims to be from 2014-03-28 uploaded by user @euske , and other users do not have permission to update it. The fix you mention, 6b6fc264ffd58cd1c305e8c23990b85e846964e9, was committed 2014-04-16.
Not being familiar with PyPI, I wanted to see what would happen if I tried to update the package. Gladly, and as expected, it wouldn't let me.

Registering pdfminer to https://pypi.python.org/pypi
Server response (403): You are not allowed to store 'pdfminer' package information

Same here, it would be great if the author could upload the package. I got the same error with 20140328 packages.
Although I directly reference to the git to get it installed and fixed, I would be great if we could have a bug free version.


Win10Ent Failing Validation

I'm trying to setup the Windows 10 lab, and all goes well until the validation, and it gets stuck.  Looking at the log referenced in another post it appears the VM is waiting for a reboot, i have however rebooted it several times. So i'm kinda stuck as to what to do.
Any thoughts? thanks in advanced for the help
Bootstrap-20190130-100437.log

This project is now under new ownership. The 3.x version line is obsolete. Version 4.0.0 has been published to the PowerShell Gallery with new updates, configuration, and documentation. It is expected that this version will resolve most if not all of the problems you were experiencing. Read Updating for more information.
No further action will be taken on this issue and it will most likely be closed at some point. If you still have the same issue with the new version, then go ahead and open a new issue.


Omnibus dependency upgrades

Keep our dependencies current.

I didn't have to change any code, and we've had people patiently waiting for 0.14.0.  I'm going to assume this one is not highly controversial and merge it.

[Current coverage][cc-pull] is 60.06%

Merging [#638][cc-pull] into [master][cc-base-branch] will increase coverage by 0.64%

@@             master       #638   diff @@
==========================================
  Files           196        196
  Lines          4330       4330
  Methods        4021       4021
  Messages          0          0
  Branches        307        307
==========================================
+ Hits           2573       2601    +28
+ Misses         1757       1729    -28
  Partials          0          0

Powered by Codecov. Last updated by [d5428a8...4602fa2][cc-compare]
[cc-base-branch]: https://codecov.io/gh/http4s/http4s/branch/master?src=pr
[cc-compare]: https://codecov.io/gh/http4s/http4s/compare/d5428a8a532c4d7eb0fe40cc0e84b7a70f20fac3...4602fa21390d0611f47ddabf1885f1ffdd5cfe42
[cc-pull]: https://codecov.io/gh/http4s/http4s/pull/638?src=pr


Async job failed: request timed out when using open workspace symbol picker in Helix

I have a directory full of all sorts of random things, including markdown files. It has a .git repo initialized at the root.
If I cd into it and open a markdown file with headings, the space e - open symbol picker works like a charm with the headings!
Unfortunately if I choose space E - open workspace symbol picker then the language server hangs, and I get Async job failed, request timed out appearing randomly in red at the bottom of the screen. I need to restart Helix to get marksman working again.

@David-Else thanks for reporting this!

Is it Helix specific or you observe the same behavior in neovim?
Do you have .gitignore that ignores e.g. node_modues and other sorts of unwanted stuff?
How many .md files do you have inside the repository?

Oh, totally forgot! @David-Else what's marksman --version you have?

marksman --version
1.0.0

but I don't think this is true? I downloaded 2022-08-19

There is no .gitignore or node_modules
only 2 .md files

I don't think Neovim can show symbols? I don't have any plugin that does that, if there is a command I can run that is no problem to report the result.

Thanks @David-Else! Would you try a new release https://github.com/artempyanykh/marksman/releases/tag/2022-08-24?
Since there's just 2 files files it's unlikely a performance problem. If the newer version doesn't fix the problem, one thing you could try is to change the extension of one of the 2 .md files to something non-.md to see if it's any particular file causing the trouble.

I don't think Neovim can show symbols?

Yeah, you're right. I use Telescope for this:
  vim.keymap.set("n", "<leader>i", '<cmd>Telescope lsp_document_symbols<CR>', { buffer = bufnr })
  vim.keymap.set("n", "<leader>I", '<cmd>Telescope lsp_workspace_symbols<CR>', { buffer = bufnr })

Let's scratch neovim. I can build Helix from master.

The new version works, you are a genius! :)

@David-Else happy to hear that! So, the problem seems to be that

Marksman 2022-08-19 actually didn't have support for workspace symbols. I added workspace symbols a couple days ago and pushed a new release earlier today.
LSP client (neovim, helix, emacs) is not supposed to send requests that the server didn't advertise as supported. But helix doesn't seem to honor server capabilities. So, when it sent workspace symbols request to Marksman 2022-08-19 it triggered a notImplemented code path which caused the problem.

2. LSP client (neovim, helix, emacs) is not supposed to send requests that the server didn't advertise as supported. But **`helix` doesn't seem to honor server capabilities**. So, when it sent workspace symbols request to Marksman 2022-08-19 it triggered a `notImplemented` code path which caused the problem.

I am sure team Helix would love to hear about this problem and fix it :)


Fix radix sort perf regression.

The new tuning parameters for radix sort are causing a performance
regression (2MiB input, 16-bit keys, GV100, 21.62 -> 16.01 GiB/sec).
See referenced NVBug for details.
Bug 200676467

These parameters were changed here for reference.

DVS CL: 29316822


fix failed modal cross component tests in ci env

Description
fix failed modal cross component tests in ci env
Issues Resolved

Screenshot

Testing the changes

Check List

[ ] All tests pass

[ ] yarn test:jest
[ ] yarn test:jest_integration

[ ] New functionality includes testing.
[ ] New functionality has been documented.
[ ] Update CHANGELOG.md
[ ] Commits are signed per the DCO using --signoff

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 55.38%. Comparing base (540114b) to head (84171b5).

Additional details and impacted files
@@                   Coverage Diff                    @@
##           workspace-pr-integr     #299       +/-   ##
========================================================
- Coverage                66.91%   55.38%   -11.53%
========================================================
  Files                     2598     1193     -1405
  Lines                    49149    24121    -25028
  Branches                  8890     4058     -4832
========================================================
- Hits                     32889    13360    -19529
+ Misses                   14091    10118     -3973
+ Partials                  2169      643     -1526

Flag
Coverage Δ

_2
55.38% <ø> (ø)

_3
?

_4
?

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Something strange in transaction()

Node version:
Sails version (sails): 1.2.3
ORM hook version (sails-hook-orm): 2.1.1
Sockets hook version (sails-hook-sockets):
Organics hook version (sails-hook-organics):
Grunt hook version (sails-hook-grunt):
Uploads hook version (sails-hook-uploads):
DB adapter & version (e.g. sails-mysql@5.55.5): sails-postgresql 1.0.2
Skipper adapter & version (e.g. skipper-s3@5.55.5):

Steps to recreate:
git clone git@github.com:alxndrsn/sailsjs-bug-6805.git
cd sailsjs-bug-6805
yarn
yarn start &
curl localhost:1337

Observed:
Transaction never completes for this controller:
const fn = function() {};

module.exports = {
  fn: async function (inputs, exits) {
    await sails.getDatastore()
      .transaction(async db => {
        fn(true, true);
      });

    return exits.success();
  }
};

Adding a console.log() inside the controller allows the transaction to complete:
const fn = function() {};

module.exports = {
  fn: async function (inputs, exits) {
    await sails.getDatastore()
      .transaction(async db => {
        console.log();
        fn(true, true);
      });

    return exits.success();
  }
};

Another way of fixing the problem is to remove one of the arguments from fn(...):
const fn = function() {};

module.exports = {
  fn: async function (inputs, exits) {
    await sails.getDatastore()
      .transaction(async db => {
        fn(true);
      });

    return exits.success();
  }
};

or, changing the argument to a string:
const fn = function() {};

module.exports = {
  fn: async function (inputs, exits) {
    await sails.getDatastore()
      .transaction(async db => {
        fn(true, '');
      });

    return exits.success();
  }
};

Another fix is to remove the argument for the transaction callback:
const fn = function() {};

module.exports = {
  fn: async function (inputs, exits) {
    await sails.getDatastore()
      .transaction(async () => {
        fn(true, true);
      });

    return exits.success();
  }
};

?!?!?!?!?!
Conclusion
If there is a single function call inside a transaction with two or fewer arguments of certain values, then the transaction is never completed.

@alxndrsn Thanks a lot for bringing this attention to this logic curiosity / anomaly. Will bring it up with the team for the best approach to have transaction() complete.

If there is a single function call inside a transaction with two or fewer arguments of certain values, then the transaction is never completed.

I've just run into this again with a three-argument function preceded by await.

This can be mitigated by replacing:
await sails.getDatastore().transaction(

with
await withDbTx(

and defining the additional function:
function withDbTx(fn) {
  return sails
      .getDatastore()
      .transaction(db => fn(db));
}

https://github.com/balderdashy/sails-hook-orm/blob/86e431ec88aad828e4aaa0b9a9eea3b13bd405a7/lib/datastore-method-utils/help-run-transaction.js#L70-L78

:scream:
@mikermcneil what's that code doing?  Checking if the during function has more than one arguments?  Could you just use:
var seemsToExpectCallback = options.during.length > 1;

?

For reference if facing similar mysteries, this code's repeated in:

waterline/lib/waterline/methods/stream.js
sails/lib/hooks/index.js
sails/lib/app/private/bootstrap.js
sails-hook-orm/lib/datastore-method-utils/help-run-transaction.js (linked above)
sails-hook-orm/lib/datastore-method-utils/private/do-with-connection.js

Example PR for the core sails instances: https://github.com/balderdashy/sails/pull/7017


How many rules can be created in rule collection?

Is there an upper limit on how many rules can be created in a rule collection?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 6392b4a0-fa1e-fe5e-a31b-1eee48b860ef
Version Independent ID: 551028da-b651-30ac-0e77-9ee5eebf6bb0
Content: Azure Firewall rule processing logic
Content Source: articles/firewall/rule-processing.md
Service: firewall
GitHub Login: @vhorne
Microsoft Alias: victorh

@RonnieQuan  Thanks for your comment. We will review the issue and get back to you.

@RonnieQuan , Appreciate your patience. Azure Firewall supports 10,000 rules. All rule types combined.
Maximum DNAT rules - 298 (If a rule's protocol is configured for both TCP and UDP, it counts as two rules.)
We are closing this issue for now. If there are further questions regarding this matter, please reply and we will gladly continue the discussion.


[SPARK-34741][SQL] MergeIntoTable should avoid ambiguous reference in UpdateAction

What changes were proposed in this pull request?

This PR proposes to deduplicate the source table when there're conflicting attributes between the target table and the source table.
Why are the changes needed?

When resolving the UpdateAction, which could reference attributes from both target and source tables,  Spark should know clearly where the attribute comes from when there're conflicting attributes instead of picking up a random one.
Does this PR introduce any user-facing change?

No.
How was this patch tested?

Added a unit test and updated existing tests.

cc @cloud-fan @xianyinxin please take a look, thanks!

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/40634/

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/40634/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/40634/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/136051/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/40640/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/136057/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/136061/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/40644/

cc @aokolnychyi

LGTM. It would be great to have a test for the use case we actually trying to cover.

@aokolnychyi @dongjoon-hyun The use case mentioned by @cloud-fan is a good example. However, testing it only at the analysis phase is not enough. Because, IIUC, reference binding happens during the execution phase. But, unfortunately, the MergeIntoTable only implemented the logical node yet. So we don't have a way to do an end-to-end test for now.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/136151/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/40733/

thanks, merging to master!


can't import callback manager

from langchain.callbacks.manager import CallbackManager
generates:
`ModuleNotFoundError: No module named 'langchain.callbacks.manager'
Source code:
https://python.langchain.com/en/latest/modules/models/llms/integrations/llamacpp.html

Problem solved. Solution: langchain re-installation

Another note: python version > 3.9. I used Python 3.7, it will keep showing ModuleNotFoundError: No module named 'langchain.callbacks.manager' if you don't upgrade.


sort fields: name, description, user, password

#9

Seems like a quick and dirty code, but I guess it's only a temp solution

Indeed. The ideal scenario is Omnistrate to add a new field for order, which will be configured in the dashboard. That is why I didn't open a PR for their repo.


what version of python should I use?

BEWARE: your OS is not officially supported by Playwright; downloading fallback build for ubuntu20.04-x64.
BEWARE: your OS is not officially supported by Playwright; downloading fallback build for ubuntu20.04-x64.
BEWARE: your OS is not officially supported by Playwright; downloading fallback build for ubuntu20.04-x64.
BEWARE: your OS is not officially supported by Playwright; downloading fallback build for ubuntu20.04-x64.
You are using a frozen webkit browser which does not receive updates anymore on ubuntu20.04-x64. Please update to the latest version of your operating system to test up-to-date browsers.
BEWARE: your OS is not officially supported by Playwright; downloading fallback build for ubuntu20.04-x64.
Playwright Host validation warning:
╔══════════════════════════════════════════════════════╗
║ Host system is missing dependencies to run browsers. ║
║ Please install them with the following command:      ║
║                                                      ║
║     playwright install-deps                          ║
║                                                      ║
║ Alternatively, use apt:                              ║
║     apt-get install libatk-bridge2.0-0\              ║
║         libxkbcommon0\                               ║
║         libatspi2.0-0                                ║
║                                                      ║
║ <3 Playwright Team                                   ║
╚══════════════════════════════════════════════════════╝
at validateDependenciesLinux (/root/miniconda3/lib/python3.10/site-packages/playwright/driver/package/lib/server/registry/dependencies.js:216:9)
at process.processTicksAndRejections (node:internal/process/task_queues:105:5)
at async Registry._validateHostRequirements (/root/miniconda3/lib/python3.10/site-packages/playwright/driver/package/lib/server/registry/index.js:753:43)
at async Registry._validateHostRequirementsForExecutableIfNeeded (/root/miniconda3/lib/python3.10/site-packages/playwright/driver/package/lib/server/registry/index.js:851:7)
at async Registry.validateHostRequirementsForExecutablesIfNeeded (/root/miniconda3/lib/python3.10/site-packages/playwright/driver/package/lib/server/registry/index.js:840:43)
at async t. (/root/miniconda3/lib/python3.10/site-packages/playwright/driver/package/lib/cli/program.js:137:7)

@LinXin04 Plz first share more about your environment specs. Also, this message indicates that your current OS environment does not meet Playwright’s officially supported requirements. It’s not an issue with the code itself but rather with missing dependencies on your system or Docker image.
Try running:
playwright install-deps

or install the recommended packages:
apt-get install libatk-bridge2.0-0 libxkbcommon0 libatspi2.0-0

If you’re building a Docker image, add these dependencies to your Dockerfile’s build steps. Also consider using a newer Ubuntu base image so Playwright can run its browsers without fallback builds.
Once you have these dependencies in place, the warnings should disappear. I also updated my Dockerfile for the next version to consider this by default.


DefinitionResponse selects full type range

When sending a definition request to the tsserver, the response contains a range selection of the whole type. For UX proposes it would be better to either select only the identifying portion, like a type name, or additional include such an identifying range.
See https://github.com/Microsoft/vscode/issues/6772 for some background.

@mhegazy ping

I do not see why not. @CyrusNajmabadi any objections to changing DefinitionInfo.textSpan to be the declaration name span instead of the whole declaration span?

There shouldn't be any problem doing this.  That said, i'm somewhat surprised that things work this way.  When we goto-def on a type in TS today, we don't go to the identifier?

we don't go to the identifier?

nope. the beginning of the declaration. usually that is not too far from the identifier anyways.


[BEAM-11262] Remove numSleeps assertion in SpannerIOWriteTest

We shouldn't make an assertion about the number of times the writer slept, this is verifying the backoff policy which is an implementation detail. The test already verifies the total amount of time slept, which is more appropriate.

GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI.

R: @apilloud

Run Java PreCommit

Run Java PreCommit

Run Java PreCommit

Run Java PreCommit


Volume control is unavailable with new M2 Pro chip

Before opening the issue, have you...?

[X] Searched for existing issues
[X] Looked through the wiki
[X] Updated MonitorControl to the latest version (if applicable)

Describe the bug
Hi, I'm having some problems with m2 Pro chip on my new MacBook Pro 2023. The volume control bar is not displayed in the software, and it is useless to use shortcut keys to control the volume. In addition, the DDC switches in the software cannot be enabled. Replace the m1 MacBook Pro and everything will be fine. Is it because of incompatibility with the new chip?
Steps to reproduce
111
Expected behavior
111
Anything else?
no
Environment Information (please complete the following information)
- macOS version:13.2
- Mac model:14 inch MacBook Pro 2023
- MonitorControl version:latest
- Monitor(s):
- Apple Silicon/M1 (yes or no): yes

MC will be updated sometime in the future. Until that time check out this post for more info/alternatives:
https://github.com/MonitorControl/MonitorControl/discussions/1299

Since this is the same as https://github.com/MonitorControl/MonitorControl/issues/1301, I'll close this one.


<ctype.h> is*() and to*() functions are being used unsafely

Steps to reproduce
There is no easily reproducible bug on most platforms.
The is*() and to*() standard functions declared in <ctype.h> require an argument that either is equal to EOF (typically -1) or is in the range of unsigned char.
If plain char is signed, as it is on many systems, a character extracted from a command line argument, from user interactive input, or from a file can have a negative value, resulting in undefined behavior. Typically this applies only to non-ASCII characters.
In most implementations, these functions behave reasonably sanely for negative values, so in spite of the undefined behavior, the observed behavior is likely to be benign.
One exception: Microsoft's C implementation (I used Visual Studio 2022 on Windows 11) aborts on an invalid argument to these functions, but only when an application is built in Debug mode. I've built xxd.c as a standalone application under Visual Studio. The resulting executable crashes when invoked as follows (I named the source file c.c for this quick-and-dirty test):
Release\c.exe -i héllö.txt

I've created a fork of this repo and a branch with a proposed fix for this issue:
https://github.com/Keith-S-Thompson/vim/tree/ctype-fix
I have not yet created a pull request. I'll be glad to do so.
The fix adds a number of macros, such as:
#define SAFE_isalnum(c)  (isalnum ((unsigned char)(c)))

and replaces most calls to the standard functions with invocations of these macros.
Note that there is already some code that's designed to avoid problems calling these functions with negative arguments. This existing code does not cover all cases; my update is intended to do so. For now, I've left most such code in place, though it's probably unnecessary.
(An aside: vim has code that works around implementations where toupper() and tolower() operate incorrectly on arguments that are not respectively lowercase or uppercase letters. I'm skeptical that there are any existing implementations that (a) have this bug and (b) are able to compile vim, since toupper() and tolower() have been required to operate correctly since the 1989 ANSI C standard. This is not directly related to this issue, but it's a potential opportunity for some cleanup.)
Expected behaviour
Calls to is*() and to*() functions declared in <ctype.h> should behave correctly -- which is in fact what currently happens 99% of the time. (Behaving correctly is just one possible consequence of undefined behavior.)
Version of Vim
9.0.2018
Environment
OS: Ubuntu 22.04.3 ; Windows 11
Terminal: xterm, tmux ; cmd.exe
$TERM: tmux-256-color ; N/A
shell: bash 5.3.0 ; cmd.exe
Logs and stack traces
No response

I ran make test with my version. I saw some test failures, but only ones that also occur with the unmodified version 9.0.2018.

thanks, I am a bit worried that this may have unwanted consequences on other platforms. Perhaps we can start with a small change in some central place and if this doesn't cause problems, we can include this for the whole repository.
I suppose changing everything in once commit is too messy, so I'll prefer some more granular changes. In any case, that is something for after the Vim9.1 release.

Since there are no visible symptoms, I understand the desire for caution.
I don't see how applying the entire patch could break anything, but of course that means that any problems would be unanticipated ones.
FWIW, I took a quick look at the neovim sources.  Arguments to the is*() and to*() functions are generally cast to uint8_t. (unsigned char* is IMHO cleaner, but they're almost certain to be equivalent.)
I'll leave my repo and branch in place. Feel free to apply it at your convenience.

okay thanks. Can you make a PR out of your repo please?

Done.
(I didn't see a way to tie the PR to the issue, so I just linked to the issue in the PR.)

There were some test failures. I think I have a good idea how to fix them. I'll update the branch soon.

I am including this now, except for the change in iscygpty.c, which should have been fixed since commit https://github.com/vim/vim/commit/ac709e2fc0db6d31abb7da96f743c40956b60c3a
Please verify.
Thanks!


a11y does not support opacity

The a11y plugin doesn't support opacity. It would be great if it did.
Black on white = 21
colord('#000000').contrast('#FFFFFF')
Transparent black on white = 21, even though the text is invisible.
colord('#00000000').contrast('#FFFFFF')
Black on white is readable
colord('#000000').isReadable('#FFFFFF')
Transparent black on white is readable, even though the text is invisible.
colord('#00000000').isReadable('#FFFFFF')

I think an important consideration to make when implementing such a feature (and the reason why colord may not support it yet) is that the computation of contrast/readability should take into account also the underlying "background" color.
For example:
colord("#ffffff").isReadable("#ff000080"); // true (white on 50% transparent red)
should return very different results if the color "underlying" the transparent red is black or white.
In short, the contrast calculation should be done against the equivalent "compound" solid color

Update: as @t-hamano pointed out in https://github.com/WordPress/gutenberg/pull/47373#issuecomment-1404555650 , the mix plugin could be used to calculate the compound color, which can then be fed to the relevant a11y util


Roads

安和路 安和路 [An1 he2_Lu4] /Anhe Road/
建國路 建国路 [Jian4 guo2_Lu4] /Jianguo Road/
References:
https://flexiclasses.com/chrome-extensions/#:~:text=安和路
https://flexiclasses.com/chrome-extensions/#:~:text=建国路

Yes these are major roads in 台中 and 高雄 , well worth putting in


add: calculator play

First thing, PLEASE READ THIS: ReactPlay Code Review Checklist

Description
This is a calculator app play which would be able to perform basic arithmetic operations
Fixes # (issue)
Type of change
Please delete options that are not relevant.

[ ] New Play (non-breaking change which adds functionality)

How Has This Been Tested?
e2e and local testing
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.

this is most likely a javascript play not react play.

this is most likely a javascript play not react play.

Can you explain a bit more?. Because this play uses JSX and hooks.

this is most likely a javascript play not react play.

Can you explain a bit more?. Because this play uses JSX and hooks.

no its fine. its good. but i see calling document object and modifying realdom at several places.

this is most likely a javascript play not react play.

Can you explain a bit more?. Because this play uses JSX and hooks.

no its fine. its good. but i see calling document object and modifying realdom at several places.

Got it @Angryman18 !, but I guess this should work as well

@Angryman18 are you good with this PR?

any update @harshsinghatz


XmlTest is null when read via IInvokedMethodListener

Closes #1029
Fixes #1029  .
Did you remember to?

[X] Add test case(s)
[X] Update CHANGES.txt

We encourage pull requests that:

Add new features to TestNG (or)
Fix bugs in TestNG

If your pull request involves fixing SonarQube issues then we would suggest that you please discuss this with the
TestNG-dev before you spend time working on it.

ping @juherr - Please help take a look


Wrap with a for loop while sending&receiving header

Sometimes the stream socket might input or output fewer bytes than requested due to the buffer limits or interruption.Normally we would wrap the read & write socket methods within a loop to remedy the problem of "ERROR: Read partial messageheader" which would be triggered occasionally while running CaffeOnSpark via tcp on 8 nodes.

Thank you for submitting this pull request, however I do not see a valid CLA on file for you. Before we can merge this request please visit https://yahoocla.herokuapp.com/ and agree to the terms. Thanks! :smile:

CLA is valid!

Will need to check as we haven't got a problem unless your network has
issues. Anyway thanks for the pull request, will take a look
On Tue, Jun 28, 2016 at 12:09 AM, li,zhichao<EMAIL_ADDRESS>wrote:

Sometimes the stream socket might input or output fewer bytes than
requested due to the buffer limits or interruption.Normally we would wrap
the read & write socket methods within a loop to remedy the problem of
"ERROR: Read partial messageheader" which would be triggered occasionally
while running CaffeOnSpark via tcp on 8 nodes.
You can view, comment on, or merge this pull request online at:
https://github.com/yahoo/CaffeOnSpark/pull/98
Commit Summary

wrap read and write with for loop

File Changes

M caffe-distri/src/main/cpp/util/socket.cpp
https://github.com/yahoo/CaffeOnSpark/pull/98/files#diff-0 (40)

Patch Links:

https://github.com/yahoo/CaffeOnSpark/pull/98.patch
https://github.com/yahoo/CaffeOnSpark/pull/98.diff

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/yahoo/CaffeOnSpark/pull/98, or mute the thread
https://github.com/notifications/unsubscribe/ACCTVToZktXjkgNJ31ZLZhpUBM9Mz_5Gks5qQMjEgaJpZM4I_zgi
.

+1


ENYO-5589: added spotlightRestrict knob to Multiple Containers sample

Checklist

[x] I have read and understand the contribution guide

[ ] A CHANGELOG entry is included

[ ] At least one test case is included for this feature or bug fix

[x] Documentation was added or is not needed

[ ] This is an API breaking change

Issue Resolved / Feature Added
Resolution
Additional Considerations
Links
Comments

Closing, since an existing sample (qa sample: spotlight > popup navigation) already meets the needs of the test use-case.


Complete quoting for parameters of some CMake commands

Some parameters (like "${LEAN_SOURCE_DIR}" and "${CMAKE_CURRENT_BINARY_DIR}/lean") are passed to CMake commands in your build scripts without enclosing them by quotation marks. I see that these places will result in build difficulties if the contents of the used variables will contain special characters like semicolons.
I would recommend to apply advices from a wiki article.

Thanks for your improvement of the build scripts.


Generated from 0bc892729baf0d049695c873e9afe139211c259d

Add areaOfInterest and detectObject

Replace the current swagger with an auto-generated one.
Add example files for areaOfInterest and detectObject.
Fix example validation errors for analyze and describe.
A few fixes for generating java sdk

Can one of the admins verify this patch?


Basic file system commands not supported in Alluxio Fuse

Alluxio Version:
Alluxio 2.6.2
Describe the bug
We are running a 1 master/1 worker EMR cluster:
master: m5.xlarge
worker: i3en.3xlarge (7TB SSD)
Our application is writting in C/C++. It uses Alluxio/Fuse to mount the TPCDS dataset (our tests) and also a file block cache. We expect Alluxio/Fuse to provide a much larger/faster cache than is provided by a non-Alluxio cluster.
There are two issues related to basic Posix command operations:

The "rewind" command does not appear to work. After executing it, subsequent reads fail because eof has been reached. We work around this issue by closing the file and opening it again for read access.
The "cat" command is run by using the C "system" call (system(cat )). This call fails to read the target file due to a permissions error. The complete file path has 777 permissions. We worked around this issue by writing the files in question to /tmp.

To Reproduce

Create an Alluxio/Fuse mount.
Chmod the entire path 777.
Run the following tests as a non-Alluxio user.
Write to a file and rewind the file pointer.
Attempt to read the file. No data should be returned as the file is at EOF.
Run a "cat" command using the "system" call. Attempt to read the created file. This should fail on a permissions error.

Expected behavior
The Posix commands should work.
Although perhaps "rewind" breaks the write-once rule?
Urgency
These problems are of moderate concern at the moment, but in the future, they could become important.

/assign @yabola

I am not sure if I understand it correctly. But I can't reproduce your issue with codes below .
I  already used  system("cat  /Users/lcl/fuse_data/hive-site.xml");  rewind(fp);
`#include
#include <stdio.h>
int main()
{
FILE *fp;
int ch;
system("cat  /Users/lcl/fuse_data/hive-site.xml");

fp = fopen( "/Users/lcl/hive-site.xml" , "r" );
while(1)
{
    ch = fgetc(fp);
    if( feof(fp) )
    {
        break ;
    }
    printf("%c", ch);
    fflush(stdout);
}

rewind(fp);

printf("\n");
while(1)
{
    ch = fgetc(fp);
    if( feof(fp) )
    {
        break ;
    }
    printf("%c", ch);

}
fclose(fp);

return(0);

}`

We have only seen this error when the system is under load. That is, there is a lot of FUSE file activity.


Maintain sets of possible types in CC, not just one

Sometimes we can deduce possible types that aren't unit: e.g., when faced with
[?x _ ?y]
[(> ?y 10)]

we know that ?y must be numeric — long or double. In the future that might also grow to include instants. This is, of course, unrepresentable if known_types is BTreeMap<Variable, ValueType>.
This issue tracks generalizing this constraint tracking a teensy bit to include ever-shrinking sets of potential types.

7024978517435c8124ff45dda7e643d0da2d3bb2


adding value property to Param class

As discussed in #81

Looks good James, did you just want me to sign off on the merge? Or did you also want me to look into the issue of setting _needs_recompile on a new Param object assignment?
Currently, I don't think assigning a new Param object will trigger a recompile. What would be a good way to do this? I can only think of the solution of writing a getter and setter for each attribute, which may be a bit verbose...

Well, now that you mention it, perhaps this would be a good opportunity to fix that. Working on it now!

Okay, I added a functionality so that when you replace a Param with a new Param,

The old parameter gets unlinked from the tree (i.e. it can no longer reference a 'parent')
The new parameter gets linked to the tree (this happened anyway)
The model gets told to recompile (if there is a model to recompile, of course)

@jameshensman @markvdw What will be the behaviour of the functionality with arrays. Do we want to make .value give a copy? Something to think about.

I think we do, otherwise if the user does something interesting to the result, it will change the model. Example (using curent code):
m = GPflow.model.Model()
m.p = GPflow.param.Param(np.arange(3))
# m.optimize, whatever

result = m.p.value
print m

# model.p transform:(none) prior:None
# [ 0.  1.  2.]

result += 4
print m
# model.p transform:(none) prior:None
# [ 4.  5.  6.]

I really like the fix to setting the _needs_recompile flag. Essentially this relies on the fact that Model inherits from Param right? Hadn't looked at this code yet, but I think it's really elegant.
Ok, so the current situation as I see it:

Can read parameter values using Param.value
Can set the values of the parameter using .param_name = some_value (does not trigger re-compilation)
Can re-set the whole parameter by assigning a new Param object (triggers re-compilation)

Looks ideal to me! Just needs fixing of the typo FailIf in the test. Shouldn't that be failIf?
Also, failIf seems to be deprecated. It should be assertFalse [https://docs.python.org/2.7/library/unittest.html].

Ok I uploaded a small fix. I couldn't merge into master though due to some conflicts. Could someone else look at this? I don't want to erase anybody else's changes.

Taking a look now.

Turns out git doesn't like merging things if you rename methods. All fixed now.


chore: differentiate action popup and popup, improve responsiveness a…

Try out Leather build f327eac — Extension build, Test report, Storybook, Chromatic

This PR fixes responsive issues in approval popups:

I re-instated a different file for the action popup - now called action-popup.html
the popup.html file is then used for standard approval popups (Previously, we had a file called popup-center.html for approval popup )

You can see the windows behaving more responsively here:
https://github.com/user-attachments/assets/d458d995-9a21-4907-9ec8-5894a634c6f3
As part of this I also:

refactored Card footers to fix and simplify by having a separate card footer
updated the popup to have a max width of 640px as per
fixed https://github.com/leather-io/issues/issues/235

I made another small change to BTC choose fee to put Available Balance into a footer and stop the whole screen scrolling in the action popup view:
https://github.com/user-attachments/assets/16128ef4-476d-4a69-bc1a-c8a98e7cd94f

These changes seem good in that they resolved the outstanding responsiveness issues. However, it's not clear to me that we want to treat the design differently between the two types of popups (and the full page view). These three types of viewports should presumably all behave the same?
E.g. I see in the video here that the settings menu disappears in the action popup, in addition to placing fixed top and bottom elements (i.e. app nav and available balance). But if we're going to show the settings menu or fix these elements in one viewport type, don't we want to do so in all types?
Note that the need to keep things consistent will grow when we support the sidebar like Phantom below, which can be resized as well (both vertically and horizontally).
cc @fabric-8 @mica000 for input

These changes seem good in that they resolved the outstanding responsiveness issues. However, it's not clear to me that we want to treat the design differently between the two types of popups (and the full page view). These three types of viewports should presumably all behave the same?
E.g. I see in the video here that the settings menu disappears in the action popup, in addition to placing fixed top and bottom elements (i.e. app nav and available balance). But if we're going to show the settings menu or fix these elements in one viewport type, don't we want to do so in all types?
Note that the need to keep things consistent will grow when we support the sidebar like Phantom below, which can be resized as well (both vertically and horizontally).
cc @fabric-8 @mica000 for input

Thanks @markmhendrickson. We are intentionally removing the Settings menu in this Action Popup view as we do that on the other screens and its how we have designed it.  I can change it so that we show the settings menu if desired.
I moved Available Balance and the top nav into fixed elements to match the other screens and to stop the header scrolling out of view.
You can see there is a discrepancy with the settings menu on the action popup but the header and footer (available balance) adapt to screen height where available
https://github.com/user-attachments/assets/6dbcb8a7-5fad-40ce-9a76-ffe2a22b7b2f
I am happy to make more adjustments here and to start investigating sidebar support which could help direct us to a more uniform approach.


Feature request: allow to retain some empty lines

Imagine I have this file:
---
# https://taskfile.dev/styleguide/

version: "3"

env:
  PYTHON_VERSION: "3.11.2"

tasks:
  setup-python-interpreter:
    cmds:
      - pyenv install --skip-existing {{.PYTHON_VERSION}}
      - pyenv local {{.PYTHON_VERSION}}
    desc: uses pyenv to locally install python

  setup-venv:
    cmds:
      - python -m venv venv
    desc: sets up python venv

As far as I understand, I can do one of two things:

Either set retain_line_breaks to true, which means I could end up with extra lines even after formatting, for example:

---
# https://taskfile.dev/styleguide/

version: "3"

env:
  PYTHON_VERSION: "3.11.2"

tasks:
  setup-python-interpreter:
    cmds:
      - pyenv install --skip-existing {{.PYTHON_VERSION}}
      - pyenv local {{.PYTHON_VERSION}}
    desc: uses pyenv to locally install python

  setup-venv:
    cmds:
      - python -m venv venv
    desc: sets up python venv

Or I could set retain_line_breaks to false, which means I only end up with:

---
# https://taskfile.dev/styleguide/
version: "3"
env:
  PYTHON_VERSION: "3.11.2"
tasks:
  setup-python-interpreter:
    cmds:
      - pyenv install --skip-existing {{.PYTHON_VERSION}}
      - pyenv local {{.PYTHON_VERSION}}
    desc: uses pyenv to locally install python
  setup-venv:
    cmds:
      - python -m venv venv
    desc: sets up python venv

I would like to be able to set retain_line_breaks to a number, for example, 1, so that I can have a clear separation of one line, but never more, like the Taskfile style guide suggests, and I personally agree.
If this is something relevant I could try to have a look if you are accepting contributors :slightly_smiling_face:

Thanks for the feature request!
This might be doable; in internal/hotfix is where the hack for retaining line breaks is. It might work by just adding something that chomps continuous line breaks down to some minimum, so if there's 3 line breaks in a row then it only replaces it with one magic string.
If you are interested in contributing this I would be happy to accept it! If the PR contains the following things:

The functionality like I mentioned above
A new configuration parameter for this (can't mess with retain_line_breaks itself as that would be a breaking change; would need to be an additional option users can set)
An integration test, which would involve making a new folder testing this functionality with the new configuration option. The integration tests are new so you would be the first person other than me to use them, you can let me know if you run into any problems.

That would be great if you are willing to contribute this, and you can let me know if you run into any problems.

Thanks for the reply and the information! I'll try to tackle this and I'll let you know :slightly_smiling_face:

Hey @doublethink13 I am going to implement this as part of v0.11.0 since I got a couple direct requests for it. Hopefully I don't steal your thunder if you had something going.

hey @braydonk
sure go ahead :wink:
i'm very sorry, life got in the way and eventually i forgot about this :slightly_frowning_face:

That's no problem, it happens. I should be getting this together before next week!


create and link to a demo of the theme

It feels a little silly not to, as it's hard to gauge whether it's worth installing without having some sort of preview

@GeorgeWL, there used to be a hosted version of the theme on https://themes.gohugo.io, but I guess they stopped doing that? I could cobble something together and run it off of my personal server.

Seems many still have
Maybe they changed the method of doing it and didn't properly inform folks?  Cause yours isn't the only one with this issue.

Closing this as the theme works under https://themes.gohugo.io/theme/grid-side


improvement on job level SLA

filter SLA options based on job ID
We should filter SLA options based on job ID when deriving them from an executable flow.
refactor by save plugin

@chengren311 what's your plan for this change?

Could you include unit tests?


Infinite reconnect in case of DNS resolution failure

It looks like the Sync Client goes into an infinite reconnect loop if there is DNS resolution failure. We need to figure out if this is a problem in the Sync Client or in Object Store. Either way, the behaviour is undesirable.  As a minimum, there should be exponential backoff applied.
2020-04-29 15:36:51.641 29277-29319/io.realm.test D/REALM_SYNC: Connection[2]: Connecting to endpoint '<IP_ADDRESS>:443' (1/2)
2020-04-29 15:36:51.912 29277-29319/io.realm.test I/REALM_SYNC: Connection[2]: Connected to endpoint '<IP_ADDRESS>:443' (from '<IP_ADDRESS>:37910')
2020-04-29 15:36:52.054 29277-29319/io.realm.test E/REALM_SYNC: Connection[2]: SSL handshake failed: Connection reset by peer
2020-04-29 15:36:52.054 29277-29319/io.realm.test I/REALM_SYNC: Connection[2]: Connection closed due to error
2020-04-29 15:36:52.054 29277-29319/io.realm.test I/REALM_JAVA: Session Error[wss://realm-dev.mongodb.com/]: CONNECTION_RESET_BY_PEER(realm.basic_system:104): Connection reset by peer
2020-04-29 15:36:52.054 29277-29319/io.realm.test D/REALM_SYNC: Connection[2]: Allowing reconnection in 453 milliseconds
2020-04-29 15:36:52.509 29277-29319/io.realm.test D/REALM_SYNC: Connection[2]: Resolving 'realm-dev.mongodb.com:443'
2020-04-29 15:36:52.510 1614-29405/? E/ResolverController: No valid NAT64 prefix (113, <unspecified>/0)
// This just repeats as fast as possible

Moved to https://github.com/realm/realm-core/issues/4192


tests-ci : libraries: spsc_pbuf_nocache:  test Failed

Describe the bug
test is Failed on zephyr-v3.4.0-3926-g4ba97c22555e on lpcxpresso54114_m4
testcase path is libraries/spsc_pbuf_nocache/stress
see logs for details
To Reproduce
1.
scripts/twister --device-testing --device-serial /dev/ttyACM0 -p lpcxpresso54114_m4  --sub-test libraries.spsc_pbuf_nocache

or
# cd tests/libraries/spsc_pbuf_nocache/stress
# west build -b lpcxpresso54114_m4
# west flash

See error

Expected behavior
test pass
Impact
Logs and console output
START - test_stress
Reading from an interrupt, writing from a thread
0% remaining:14000 ms
0% remaining:13000 ms
0% remaining:12000 ms
0% remaining:11000 ms
0% remaining:10000 ms
0% remaining:9000 ms
0% remaining:8000 ms
0% remaining:7000 ms
0% remaining:6000 ms
0% remaining:5000 ms
0% remaining:4000 ms
0% remaining:3000 ms
0% remaining:2000 ms
0% remaining:1000 ms
Ztress execution report:
context 0:
- executed:36287, preempted:0
- ticks initial:4, optimized:4
context 1:
- executed:23699, preempted:2000
- ticks initial:4, optimized:4
Average CPU load:18%, measurements:145
Writes:35607 failures: 5
Writing from an interrupt, reading from a thread
100% remaining:14000 ms
100% remaining:13000 ms
100% remaining:12000 ms
100% remaining:11000 ms
Assertion failed at WEST_TOPDIR/zephyr/tests/lib/spsc_pbuf/src/main.c:439: stress_read: check_buffer(buf, len, ctx->read_cnt) is non-zero

FAIL - test_stress in 19.283 seconds

Environment (please complete the following information):

OS: (e.g. Linux )
Toolchain (e.g Zephyr SDK)
Commit SHA or Version used: zephyr-v3.4.0-3926-g4ba97c22555e

does not reproduce on the latest main 61f065230ad9bca91633cd57b9dcd5e90c5d8bc7


types(jest-haste-map): Expose a minimal public API to TypeScript

Summary
Currently, jest-haste-map exposes a large API surface, most of which is unused by Jest and none(?) of which is documented. Some of this is a legacy of internal FB usage.
This is a conservative type-only change to minimally define the interfaces actually used by Jest itself. It's intended to be particularly useful to users of hasteMapModulePath, to reduce and clarify the API they're required to implement, and at Meta it will help us flag uses of APIs Jest doesn't need.
(This also paves the way for upstreaming some of the work we're doing/intend to do on metro-file-map (context: https://github.com/facebook/metro/pull/812) to extract and decouple some Meta-specific stuff)
Test plan
No runtime changes, TS build passes.

oops!😅 solving the same wheel closing mine ?

@robhogan sorry, missed this one! feel free to ping me, I'm always up for reviewing PRs from Meta peeps 🙂
I merged in main and resolved the conflicts, so let's see what CI says 👍

Thanks for looking at this @SimenB (but have a good weekend! 😄)

https://github.com/facebook/jest/releases/tag/v29.0.3

have a good weekend! 😄

same to you! 👍


router.js - Updating require path for buildModule

Updated conf require statement to handle both ES6 (export default) and CommonJS (module.exports)

@madhusudanbabar could you merge this?

Yes, I was waiting for the some other changes but will merge this one and optional chaining for the paths and release an update


[HUDI-6315] Feature flag for disabling optimized update/delete code path.

Change Logs
For SQL update and delete operations, prepped writes are enabled by default. This PR adds feature flags (hoodie.enable.spark.sql.optimized.update and hoodie.enable.spark.sql.optimized.delete) to disable prepped update and delete.
Impact
Added two feature flags that can be enabled or disabled as shown below:
        spark.sql("set hoodie.enable.spark.sql.optimized.update=false")
        spark.sql("set hoodie.enable.spark.sql.optimized.delete=false")

Risk level (write none, low medium or high below)
None
Documentation Update
Contributor's checklist

[X] Read through contributor's guide
[X] Change Logs and Impact were stated clearly
[X] Adequate tests were added if applicable
[X] CI passed

just one flag would suffice.

why the patch is in draft state ?

@hudi-bot run azure


Errors in /website/learn/routing: s/external/internal/.

The /learn/routing documentation page has two examples beginning:
# external.py
import hug

import external

I believe import external should be import internal to invoke the "Internal API" defined previously.  Likewise, the calls to external.root should be internal.root, because that is where root is defined.
I also noticed two simple typos in the main text:

extreamly -> extremely
convience -> convenience

I tried a quick git clone but I don't think these docs are in git, and something wasn't right with my environment, so I'm just filing this ticket.

Thanks for reporting these issues! They are now all resolved on the live website.
Thanks!
~Timothy


make dev build process work with code generation

At the moment building locally inplace doesn't work unless you first run  dwave/gate/simulator/operation_generation.py, this makes it so that the documentation is right and python setup.py build_ext --inplace should work. I don't think it's the most clean solution, but I couldn't get a solution with a custom build_py class as a command python setup.py generate_gates to work because of the cythonize() causing a build failure before the gates could be generated.

Closing this due to staleness. Can bring it up again if we decide to update the build process.


[fix] user files 500 error when validation error occurred

Coverage decreased (-2.1%) to 60.794% when pulling 4201fc7240055ced6f7d9ff6b42c9e01926fb85f on itowtips:fix-user-files into b83c612c5ef9ea5d0d87e0026411dbba81b779e0 on shirasagi:master.


 This fixes that.

Thanks!


0.1 - Scrape Program details (Job 0)

Using the json file (programs.json), I will Implement the functions to scrape the program details (title and credits) from the program URL.

[ ] #26
[ ] Add cheerio yarn add cheerio
[ ] For each program, scrape the Title and Credits. (See details on Notion)
[ ] Use the Program type

On hold, on pourrait potentiellement utiliser l'api de l'ets


Smart contract improvement for gas efficiency.

What would you like to share?
I want to improve the BasicBanking.sol file to increase gas efficiency as a part of Hacktoberfest contribution.

Thanks for this issue.

Can you merge this now @Vikash-8090-Yadav ?
Then I can look for either contract modifications.


cannot reuse the folder that mount with weed though the webdav

when i use the webdav function with the following steps:

start a weed filer with webdav in the commond console
weed mount -filer=<IP_ADDRESS>:8888 -dir=/tidb/seaweed
go to the console, press Control + C
weed mount again as same as step 2
will print: can not stat /tidb/seaweed

the /tidb/seaweed can not reuse for the weed mount command

ll -ah the folder (on centos), it look like this:
[root@localhost tidb]# ll -ah
ls: 无法访问seaweed: 传输端点尚未连接
总用量 0
drwxr-xr-x.  6 tidb tidb  76 10月 26 11:58 .
dr-xr-xr-x. 18 root root 256 9月  23 19:23 ..
d??????????  ? ?    ?      ?            ? seaweed

Not clear about the issue description. Screenshots would help.

my last comment is the Screenshots i copied
the issue is:
after i use "weed mount" command on the folder "seaweed", i press Ctrl+C to stop the command, then the folder "seaweed" cannot reuse and the status be shown on the last comment

thanks for reading and replaying


What parameters should I change to achieve a better mIoU when training spconv on a photogrammetric dataset?

Hi, may I know what parameters in the config file or in your code are sensitive to different datasets?
Currently, I have a photogrammetric dataset capturing city objects at the urban scale. I want to modify the parameters that you provided for S3DIS to train the spconv model. But I'm not sure what parameters I shall finetune, and to what extent should I change?
Your suggestions would be much appreciated.
Cheers,
Eric

Hi, here are my suggestions:

Tuning voxel size in Voxelization to make sure the input scale is fit your GPU memory;
Tuning learning rate;
Turning other augmentation;

Yes, initial grid sampling, similar to resolution of image.


Spleeter 4 stem model

Hey!
First off, amazing work. I was able to get a version of the 2 stem ml model working.
I'm wondering if you ever got a 4 stem version of the pytorch implementation working?
I tried using the 4 stem model with 4 instruments, but it just produces garbage.
Did you ever get this working? Do you have any pointers on how to get this working?

Hello, thatcherclough.
4stems can be converted into a Core ML model and work correctly;
I have already tried successfully.
Although there might be a few minor flaws, you can still distinguish the drums, bass, piano, and vocals.
To convert 4stems, you should refer to  spleeter 4stems config to update your up_block/down_block in unet.py , note that 4stems use nn.ELU conv_activation