Add warnings to invalid target

Create missing target warnings in js console

This looks great @gomayonqui, ship it when you're ready.

:+1: Code review looks good @gomayonqui. I just want to try it out in the browser as a UI test before merging.

A test in the browser

Try it out and let me know when it's ready to merge :+1:

:+1: ship it!

@gomayonqui looks great, thanks for adding that. It looks like all you need to do now is correct the warning strings in the jasmine specs and you should be ready to ship.


The null-deref property is missing

Hi,
the usage message mentions the null-deref property, but Symbiotic fails to recognise it:
$ symbiotic --prp=null-deref test.c
7.0.0-dev-llvm-9.0.1-symbiotic:44b91251-dg:e89761ff-sbt-slicer:fff6245c-sbt-instrumentation:2db331fb-klee:59f3e288
ERROR: Could not derive the right property

Yes, we haven't maintained this property for quite some time. We should either remove it from the message or fix it. Do you need it promptly?

I do not think we need null-deref specifically.  If NULL dereferences are already checked with --prp=memsafety, it will work for us.

Yes, NULL dereferences are checked with --prp=memsafety, however, there are cases (at least for us), where we would like to check only for null-dereferences, so I fixed this property instead of removing the message.

Thanks!


Does not work with 64 bit version.

Please make a 64 bit version.

64bit version is already available here. http://phdesign.com.au/npptoolbucket/
Regards,
Paul


Feature request: IMAP server

I've been a happy pytest-localserver for a while now. It works great for SMTP. Since we moved from GSuite to self-hosted email, it became clear to me that sent emails are no longer automatically appearing in the Sent folder. So I now had add code to connect to the IMAP server and append the message to the Sent folder. It'd be useful if pytest-localserver would also provide support for IMAP.

Hi @kvdb, thanks for your message!
In principle I'd be totally happy to add IMAP support (and I'm sure @redtoad would agree). We would need a Python implementation of an IMAP server; after a quick search I found https://github.com/scanner/asimap (but I can't tell if that's installable through pip) and https://pypi.org/project/localmail/ (but that may not be maintained anymore, and is also GPLv3 which would be incompatible with this project's own license). If you (or anyone) can suggest a better option for an IMAP server, that would be great.
Also, if you haven't seen it, I'd suggest reviewing the discussion about whether pytest-localserver should be retired. The unfortunate truth is that this package's support for SMTP is pretty shaky, since both Python's own smtpd module and the aiosmtpd package which was supposed to replace it are basically unmaintained and may not have much life left in them; and without SMTP, pytest-localserver is little more than a simpler version of pytest-httpserver. In general, things seem to be moving in the direction of having separate packages for testing different protocols, rather than pytest-localserver's approach which is one package that handles multiple server protocols; the separate protocol-specific packages are much more actively developed. So we'd have to take that into account when deciding whether to add IMAP support here. If we don't, it could always be a separate package.

Just wanted to reaffirm that the blocker to this is finding a suitable IMAP server library which is stable, maintained, and installable from PyPI. If we find a library meeting those criteria, I'm happy to implement this, but honestly, unless somebody can suggest one it's unlikely that this improvement is going to happen. I'll leave the issue open just in case, but if it doesn't get any further activity, that's why.


the "text" property of quill does not include selected @ and # values

for example. the quill editor shows
this is @Fredrik Sundqvist with #Patrik
but text property is
this is  with
Note that both @Fredrik Sundqvist and #Patrik are missing in the text property
In html property, these values can be seen inside spans

im having a similar problem, if i manually type the {hello} in the editor, it will take it normally with the text property.
however if i click or tab to any of the suggested result (even if using the same {hello} recommendation from quill) it will textContent wil omit the pasted contents

Did you guys find a workaround for this? I'm struggling to parse the mentions data because I when I use editor.getText(), I don't get the mentions in the returned text.

Any solution yet?

According to the original implementation, editor.getText() just joins the result of editor.getContents() .
https://github.com/quilljs/quill/blob/master/core/editor.js#L143
implementing your own getText() function might work:
editor.getContents().ops
      .map((op) => {
        if (typeof op.insert === 'string') {
          return op.insert;
        }
        if (op.insert.mention) {
          return op.insert.mention.denotationChar + op.insert.mention.value;
        }
      })
      .join('');


FileStorage.name should be the filename

Uploaded files on flask (request.files) have .name and .filename, but the standard python BytesIO sets the full path into .name and werkzeug breaks functions depending on the .name from file-like-objects to have the filename.
Since .name from werkzeug file-objects has the form-input-name.
import deepl
from io import BytesIO
from flask import Flask
from flask import request
from flask import send_file
import conf

app = Flask(__name__)
translator = deepl.Translator(conf.token)

@app.route('/', methods=['GET', 'POST'])
def index():
    if request.method == 'POST':
        source_file = request.files['file']
        target_lang = 'EN-US'
        if source_file.filename:
            result = BytesIO()
            #source_file.name = source_file.filename  # This is the current workaround
            translator.translate_document(input_document=source_file, output_document=result, target_lang=target_lang, filename=source_file.filename)
            result.seek(0, 0)
            return send_file(result, download_name=source_file.filename, as_attachment=True)
    return '''
    <!doctype html>
    <title>Upload new File</title>

Upload new File

    <form method=post enctype=multipart/form-data>
      <input type=file name=file>
      <input type=submit value=Upload>
    </form>
    '''

[2024-02-21 16:58:16,388] ERROR in app: Exception on / [POST]
Traceback (most recent call last):
  File "venv/lib/python3.11/site-packages/flask/app.py", line 1463, in wsgi_app
    response = self.full_dispatch_request()
               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "venv/lib/python3.11/site-packages/flask/app.py", line 872, in full_dispatch_request
    rv = self.handle_user_exception(e)
         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "venv/lib/python3.11/site-packages/flask/app.py", line 870, in full_dispatch_request
    rv = self.dispatch_request()
         ^^^^^^^^^^^^^^^^^^^^^^^
  File "venv/lib/python3.11/site-packages/flask/app.py", line 855, in dispatch_request
    return self.ensure_sync(self.view_functions[rule.endpoint])(**view_args)  # type: ignore[no-any-return]
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "test.py", line 20, in index
    translator.translate_document(input_document=source_file, output_document=result, target_lang=target_lang, filename=source_file.filename)
  File "venv/lib/python3.11/site-packages/deepl/translator.py", line 604, in translate_document
    handle = self.translate_document_upload(
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "venv/lib/python3.11/site-packages/deepl/translator.py", line 680, in translate_document_upload
    self._raise_for_status(status, content, json)
  File "venv/lib/python3.11/site-packages/deepl/translator.py", line 203, in _raise_for_status
    raise DeepLException(
deepl.exceptions.DeepLException: Bad request, message: Failed to get the document_type from the file extension (file).

The workaround is a easy one, but still required me to debug and compare a python BytesIO with a werkzeug FileStorage.
Environment:

Python version: 3.11
Werkzeug version: 3.0.1

I see what you're saying, file.name is the "filename", but we set it to the form field name. However, I don't see a way to change this. filename is not a required field in form uploads. File names are "arbitrary", and the file could just have easily actually been called "data" without an extension already. It seems like this is better reported to the library you're using that expects the filename to be in a specific format. Either they should not be doing that (since names are arbitrary), or offer a way to override whatever it is that they're trying to do.

Yes, they should offer an override.
But my point is, this is not true:

It basically behaves like a standard file object you know from Python, with the difference that it also has a save() function that can store the file on the filesystem.


Installing BinSync seems to interfere with Qt usage in other plugins (e.g. snippets editor)

Description
Installing BinSync via Binary Ninja's plugin manager appears to interfere with Qt usage in other plugins:
Failed to import python plugin: official/Vector35_snippets: DLL load failed while importing QtCore: The specified procedure could not be found.
Failed to load plugin: Vector35_snippets

(I'm not sure if there's a way to get a more... actionable error message here.)
Steps to reproduce the bug
Just for good measure, I ensured that BN is using its bundled Python for everything, and then nuked all installed plugins and site-packages. After that, I installed just the snippets editor plugin and the BinSync plugin.
Environment
Binary Ninja 3.5.4311-dev Personal (ff27871c)
Additional context
No response

Also, oddly, just installing BinSync via the plugin manager (and nothing else) on a clean BN gets me:
[!] BinSync is not installed, please `pip install binsync` for THIS python interpreter

Isn't that literally what the plugin manager does?

If I had to hazard a total guess here, it seems like BinSync's PySide6 dependency (resulting in 6.5.1) might be what breaks things since BN ships with its own PySide6 (6.4.3). But I'm mostly clueless on Python stuff, so what do I know. 🤷

@alexrp I think you're right on the money with your guess. The only new thing on the BinSync side in the last few updates has been our addition of the PySide6 requirement. This is a problem, is seems, for Binja. The best solution would probably be to figure out on the Binja side what PySide6 version is allowed. Otherwise, we may need to do some dependency management and remove PySide6 while adding it as a special dependency for the Ghidra installs (which requires 6).

Also, oddly, just installing BinSync via the plugin manager (and nothing else) on a clean BN gets me this after restarting BN:
[!] BinSync is not installed, please `pip install binsync` for THIS python interpreter

Isn't that literally what the plugin manager does? Also, it's very strange that BinSync appears to be working fine before I restart BN, but not after.

This could be better. This gets printed if ANY import error happens. If I had to guess, it tried to import something PySide-specific. This installer in Binja actually does two things:

Copies the stub into Binja
Pip installs binsync, which could potentially fail

If BinSync is installed correctly, any ImportError could still trigger this.

I can try to figure out which PySide6 version works on the BN side, but as I mentioned, Python is not my forte. Is there an easy way that I can install a specific PySide6 version for BinSync?

OK, well, taking the cave man approach of just nuking PySide6 and Shiboken packages from my BN user site-packages directory seems to work, at least.

Next, trying to install the PySide6 version used by BN like so:
C:\Program Files\Vector35\BinaryNinja\plugins\python
$ ./python -m pip install  --upgrade --isolated PySide6==6.4.3 -t "C:\Users\alex\AppData\Roaming\Binary Ninja\python310\site-packages"

Once again breaks things. So it seems the dependency is a problem regardless of version... 🤔

Just confirming on my end that after #289, things are working.


version in package.json is not updated

It currently says 1.0.5
https://github.com/actions/create-github-app-token/blob/35d8ea9fdbb6820e6377ef8ec809b2e7e38203eb/package.json#L5
but latest version is 1.1.4 at this point.

ah it's because we don't use the npm plugin


ARROW-7171: [Ruby] Pass Array for Arrow::Table#filter

This PR includes the following changes.

Support Arrow::Table#filter(Array<Boolean>).
Refactor Arrow::Table#slice using Arrow::Table#filter.

Thanks!
Yes. I'll work on them.


[Feat]: Add Contribution Page

If we add a dedicated page for all the contributors, I think that will give this project another dimension.
I would like to work on this issue under GSSOC'23

Hey, @suzy-g38  thank you for your contribution and patience, I will be reviewing your pr soon. If you liked the project, don't forget to give it a star.

Hey, @suzy-g38 thank you for your contribution and patience, I will be reviewing your pr soon. If you liked the project, don't forget to give it a star.

Hey, @AKD-01 No issue, if you have any other work in your mind I would love to help you.


[REEF-659]  Adding IsManagedBinary for CLR

The change is part of the change in tlc branch.
JIRA: REEF-659(https://issues.apache.org/jira/browse/REEF-659)
This closes #

I will test and merge.


fix minor issues with pn hello

Codecov Report
Base: 91.47% // Head: 91.56% // Increases project coverage by +0.08% :tada:

Coverage data is based on head (55d46b0) compared to base (ddb08ee).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #48      +/-   ##
==========================================
+ Coverage   91.47%   91.56%   +0.08%
==========================================
  Files          10       10
  Lines         387      391       +4
==========================================
+ Hits          354      358       +4
  Misses         33       33

Impacted Files
Coverage Δ

src/awesome_panel_cli/cli/create.py
88.07% <ø> (ø)

src/awesome_panel_cli/__init__.py
100.00% <100.00%> (ø)

src/awesome_panel_cli/hello.py
93.75% <100.00%> (+0.56%)
:arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


L&S - "MacGuffin" block for each side (capture the flag style)

Each side needs a "flag" of some sort in the very center of their base. A "MacGuffin" is some arbitrary object the other side really REALLY wants, not necessarily for any obvious reason. This could be as simple as a flag block, a shaped block (a big card symbol for each side?) or something more fanciful.
Ideally it should be a single block, optionally shaped. That allows the player to break the block and pick it up, triggering the quest module @nh-99 is working on

---
Want to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/486299-l-s-macguffin-block-for-each-side-capture-the-flag-style?utm_campaign=plugin&utm_content=tracker%2F5279&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F5279&utm_medium=issues&utm_source=github).

Moved to https://github.com/Terasology/LightAndShadow/issues/22.


Option to compose and send message from external source

I don't see any mention of an option to tap into, like Graph API, that would allow me to compose and send a message outside of the Teams app UI.  I might have missed something, but please let me know if there is an option to do something along those lines.
We have a WebUI that is used with other alert-type services, so they are asking if we can tie this same feature (Company Communicator) into that single interface.
Thanks!

Hi @GhustintheWizard ,
Thanks for raising the query. We will check with our team and get back to you with proper response soon.

Hi @GhustintheWizard ,
Currently, we don't have the option to send the messages to outside of Teams app. We will consider this as a enhancement and depending on bandwidth, priority we will take it for future releases post the discussion with the internal team.
Thank you.


Add nil check to Dtrie.Get()

Dtrie.Get() currently panics if called with a key that does not exist (due to calling nil.Value() in this case). Adding a nil check here will prevent this panic from happening, and ensure that the behaviour is as described in documentation.

Security Insights
No security relevant content was detected by automated scans.
Action Items

Review PR for security impact; comment "security review required" if needed or unsure
Verify aviary.yaml coverage of security relevant code

Questions or Comments? Reach out on Slack: #support-infosec.

@dustinhiatt-wf

Fix tabs and spaces inconsistency.

RM +1 dependencies verified when consumed in tier 1 repo


Access to all the existing fields with keys outside the schema

Description
Currently all data is standardized to include raw counts and a common vocabulary for gene and cell metadata. There is too much information in the dataset that is being overlooked. Is it possible to allow users to display additional annotations that are not included in the schema.
Context
We are working on to add new terms to Cell Ontology. Users make new term requests and our curators tries to validate the term request by checking multiple data source. We use CZ CELLxGENE as one of our data source. Gene and cell metadata annotations are sufficient in the most cases, but we would like to explore the effect free text annotations.
Impact
We would like to explore free text annotation affects on Cell Ontology hierarchy.
Ideal behavior
Give users the ability to explore schema annotation and/or free text annotations with a new parameter or a flag.

See also [Discussion/investigation] New schema field "author contributed cell type label".

Suggestion:  These fields should be made available as JSON blobs on each cell under a single 'additional field' key.

A BIG ➕ from curation use cases. Downloading just the cell metadata for a Dataset (schema & non-schema) would make it much more efficient to compare metadata across datasets to understand data overlap (for is_primary_data curation), compare barcodes in the index values against 10x lists to curate assay, review annotation of tissue/cell_type terms relative to author-contributed fields, etc.
I would also think this facilitates the main use cases for the upcoming observation_joinid. A Census user wants to pull data/metadata via Census API and then join that with additional metadata in the Dataset.

This workflow now possible with the addition of observation_joinid to obs. The current workflow is demonstrated here with two datasets.
Demonstration Code with two datasets https://colab.research.google.com/drive/1-qIZJnDcwOfygTxr4069s96-Js7LoB_p
We need to make a decision as to whether this is sufficient to close the ticket.


Copying images from Discord context menu is not working

When you right click an image on discord and select the option to copy image, it doesn't get copied into the clipboard.
Expected Behavior:
-The image should be copied to the clipboard
Current Behavior:
-The image doesn't get copied to the clipboard
Screenshots:

I click to copy this image

When trying to paste, it's pasting the image that i had previously put on my clipboard

Steps to Reproduce:

Enter any server that lets you upload images in Discord while using Franz
Right click an image in the chat, and select the 'Copy image' option
Paste it into the chat input
It will paste what you previously had on the clipboard, proving that the image wasn't saved

Context:
-It affects everyday use of Discord
Environment:

Franz Version used: 5.0.0-beta.18
Operating System and version: Windows 10 Pro

Also fails on Ubuntu 18.04 with 5.1.0 version. I can't paste images from clipboard on Hangouts Chat


.objrefs problem with so -bf imd

Hi,
I'm trying to use impact analisys, but if I put inside .objrefs some object outside  my repo source orbit crash.
so.log
If I try only with so it works correct, and the .objrefs is used.

Are you also able to share your .objrefs file?

If I simply put:
QSNDDTAQ.PGM
QRCVDTAQ.PGM
it breaks.
Let me know if I can help.

@pabloto Can you please just share the entire file here instead of the contents? We've had issues before where users wrote odd characters to the file - thanks!

I had to zip it because it doesn't let me attach directly the .objrefs
objrefs.zip

@pabloto The zip is empty 😆

It is not empy for me:

I compress from mac finder

@pabloto Yup - I've got it!

@pabloto I still am not able to recreate this. Is this still an issue for you?

Hi @worksofliam ,
yes the issue still was there...
so -bf imd

log.txt


Add support for complex secrets

The issue #77 is in the K8 go client, the merge logic does not work with complex values.
Using a secret update instead of a patch solve the issue.
I don't have much time to update your unit tests / integration tests so you can close this PR and maybe it'll at least help you to fix the issue faster.
I did my tests with a complex json document and an ssh key

Hey @saprette, thanks for this contribution! It's going to take us a couple of days to review, but in the meantime can you please make sure you have reviewed our contributor license agreements, and either submitted a signed CLA or amended your commit with the --signoff flag?

Hey @saprette, thanks for this contribution! It's going to take us a couple of days to review, but in the meantime can you please make sure you have reviewed our contributor license agreements, and either submitted a signed CLA or amended your commit with the --signoff flag?
ETA: if we have concrete ideas for simple ways to update the unit / integration tests, we will try to explain them in some detail so we can integrate them with your PR. It would be great to get this change in so that others can also benefit from it!

Hello,
OK I'll loop you in some emails between my company and your colleagues to see what to do with the CLA as I cannot sign it on my own.

amended your commit with the --signoff flag

My commit has been amended with the --signoff flag

Hey @saprette ! Thanks a lot for this contribution!
I'll take a look at the code, but first please do the following:

Add some context to the commit description for git history. Please explain why this commit is needed (an example for a secret that didn't work before and works now will be great). Also please explain (if you can) why you replaced the PATCH method with UPDATE. I remember there was a reason that we used PATCH so i'll need to look into it. Maybe your explanation can help me understand. Also explain why you deleted the generateStringDataEntry method.
Verify that the project can be built by running ./bin/build. It seems that it doesn't pass so please find the issue and fix it.
Verify that UTs are passing by running ./bin/test_unit. Hint: they won't :) You deleted the generateStringDataEntry method but there is a method that tests that method.
You can't actually run integration tests so I'll do it for you and add an integration test to verify that we can provide complex secrets with your fix. The example of the secret that you will add to the commit description will help me in building one (the test itself won't be hard to implement). Once your branch will pass the build and UTs I will add a commit with the integration test.

Thanks a lot again! It is very much appreciated!

Hello @orenbm , what issue did you get for the build ?
docker --version
Docker version 19.03.6, build 369ce74a3c

~/go/src/github.com/saprette/secrets-provider-for-k8s$ ./bin/build
Sending build context to Docker daemon  45.64MB
Step 1/8 : FROM golang:1.12
 ---> ffcaee6f7d8b
Step 2/8 : MAINTAINER Conjur Inc
 ---> Using cache
 ---> a50259713b55
Step 3/8 : RUN apt-get update && apt-get install -y jq
 ---> Using cache
 ---> 0188ce90d12d
Step 4/8 : RUN go get -u github.com/jstemmer/go-junit-report &&     go get github.com/smartystreets/goconvey
 ---> Using cache
 ---> 380a4951aba2
Step 5/8 : ENV GOOS=linux
 ---> Using cache
 ---> 11466cbe1b8e
Step 6/8 : ENV GOARCH=amd64
 ---> Using cache
 ---> d543edd513e8
Step 7/8 : WORKDIR /opt/secrets-provider-for-k8s
 ---> Using cache
 ---> adf4061b4983
Step 8/8 : EXPOSE 8080
 ---> Using cache
 ---> d23b89addf2b
Successfully built d23b89addf2b
Successfully tagged secrets-provider-for-k8s-go:builder
go: finding github.com/cyberark/conjur-api-go v0.6.0
go: finding github.com/modern-go/reflect2 v1.0.1
go: finding github.com/cenkalti/backoff v2.2.1+incompatible
go: finding github.com/googleapis/gnostic v0.3.1
go: finding github.com/gogo/protobuf v1.3.1
go: finding github.com/json-iterator/go v1.1.9
go: finding k8s.io/api v0.0.0-20190313235455-40a48860b5ab
go: finding k8s.io/klog v1.0.0
go: finding golang.org/x/oauth2 v0.0.0-20191202225959-858c2ad4c8b6
go: finding gopkg.in/inf.v0 v0.9.1
go: finding k8s.io/utils v0.0.0-20191218082557-f07c713de883
go: finding github.com/cyberark/conjur-authn-k8s-client v0.16.1
go: finding k8s.io/apimachinery v0.0.0-20190313205120-d7deff9243b1
go: finding golang.org/x/net v0.0.0-20190108225652-1e06a53dbb7e
go: finding github.com/modern-go/concurrent v0.0.0-20180228061459-e0a39a4cb421
go: finding github.com/google/gofuzz v1.0.0
go: finding google.golang.org/appengine v1.4.0
go: finding sigs.k8s.io/yaml v1.1.0
go: finding github.com/go-logr/logr v0.1.0
go: finding golang.org/x/sync v0.0.0-20181221193216-37e7f081c4d4
go: finding github.com/stretchr/testify v1.3.0
go: finding github.com/gopherjs/gopherjs v0.0.0-20181103185306-d547d1d9531e
go: finding github.com/kisielk/gotool v1.0.0
go: finding golang.org/x/crypto v0.0.0-20180621125126-a49355c7e3f8
go: finding gopkg.in/yaml.v2 v2.2.4
go: finding github.com/golang/protobuf v1.2.0
go: finding github.com/golang/protobuf v1.3.2
go: finding github.com/modern-go/reflect2 v0.0.0-20180701023420-4b7aa43c6742
go: finding k8s.io/klog v0.3.0
go: finding golang.org/x/sys v0.0.0-20180709060233-1b2967e3c290
go: finding github.com/smartystreets/goconvey v0.0.0-20190731233626-505e41936337
go: finding github.com/spf13/afero v1.2.2
go: finding k8s.io/client-go v11.0.0+incompatible
go: finding github.com/stretchr/objx v0.1.0
go: finding github.com/davecgh/go-spew v1.1.0
go: finding golang.org/x/net v0.0.0-20180724234803-3673e40ba225
go: finding golang.org/x/text v0.3.0
go: finding github.com/sirupsen/logrus v1.0.5
go: finding gopkg.in/yaml.v2 v2.2.2
go: finding github.com/smartystreets/assertions v0.0.0-20180927180507-b2de0cb4f26d
go: finding github.com/jtolds/gls v4.20.0+incompatible
go: finding gopkg.in/check.v1 v0.0.0-20161208181325-20d25e280405
go: finding github.com/docopt/docopt-go v0.0.0-20180111231733-ee0de3bc6815
go: finding github.com/smartystreets/assertions v0.0.0-20190215210624-980c5ac6f3ac
go: finding github.com/kisielk/errcheck v1.2.0
go: finding github.com/pmezard/go-difflib v1.0.0
go: finding gopkg.in/yaml.v2 v2.2.1
go: finding github.com/bgentry/go-netrc v0.0.0-20140422174119-9fd32a8b3d3d
go: finding cloud.google.com/go v0.34.0
go: finding golang.org/x/tools v0.0.0-20190328211700-ab21143f2384
go: finding github.com/fullsailor/pkcs7 v0.0.0-20190404230743-d7302db945fa
go: finding github.com/jtolds/gls v4.2.2-0.20181110203027-b4936e06046b+incompatible
go: finding github.com/davecgh/go-spew v1.1.1
go: finding golang.org/x/time v0.0.0-20191024005414-555d28b269f0
go: finding github.com/smartystreets/goconvey v0.0.0-20190222223459-a17d461953aa
go: finding github.com/gopherjs/gopherjs v0.0.0-20181017120253-0766667cb4d1
go: finding golang.org/x/tools v0.0.0-20181030221726-6c7e314b6563
go: finding github.com/jtolds/gls v4.2.1+incompatible
go: finding golang.org/x/net v0.0.0-20190311183353-d8887717615a
go: finding golang.org/x/crypto v0.0.0-20190308221718-c2843e01d9a2
go: finding golang.org/x/sys v0.0.0-20190215142949-d0b11bdaac8a
go: downloading github.com/cyberark/conjur-authn-k8s-client v0.16.1
go: downloading github.com/cenkalti/backoff v2.2.1+incompatible
go: downloading gopkg.in/yaml.v2 v2.2.4
go: downloading k8s.io/apimachinery v0.0.0-20190313205120-d7deff9243b1
go: downloading k8s.io/client-go v11.0.0+incompatible
go: downloading github.com/cyberark/conjur-api-go v0.6.0
go: extracting github.com/cenkalti/backoff v2.2.1+incompatible
go: extracting github.com/cyberark/conjur-authn-k8s-client v0.16.1
go: downloading github.com/fullsailor/pkcs7 v0.0.0-20190404230743-d7302db945fa
go: extracting github.com/cyberark/conjur-api-go v0.6.0
go: downloading github.com/sirupsen/logrus v1.0.5
go: downloading github.com/bgentry/go-netrc v0.0.0-20140422174119-9fd32a8b3d3d
go: extracting gopkg.in/yaml.v2 v2.2.4
go: extracting github.com/fullsailor/pkcs7 v0.0.0-20190404230743-d7302db945fa
go: extracting github.com/bgentry/go-netrc v0.0.0-20140422174119-9fd32a8b3d3d
go: extracting github.com/sirupsen/logrus v1.0.5
go: downloading golang.org/x/sys v0.0.0-20190215142949-d0b11bdaac8a
go: downloading golang.org/x/crypto v0.0.0-20190308221718-c2843e01d9a2
go: extracting k8s.io/apimachinery v0.0.0-20190313205120-d7deff9243b1
go: downloading github.com/gogo/protobuf v1.3.1
go: downloading k8s.io/klog v1.0.0
go: downloading github.com/google/gofuzz v1.0.0
go: downloading gopkg.in/inf.v0 v0.9.1
go: downloading golang.org/x/net v0.0.0-20190311183353-d8887717615a
go: extracting gopkg.in/inf.v0 v0.9.1
go: extracting k8s.io/klog v1.0.0
go: extracting github.com/google/gofuzz v1.0.0
go: extracting k8s.io/client-go v11.0.0+incompatible
go: extracting golang.org/x/crypto v0.0.0-20190308221718-c2843e01d9a2
go: downloading k8s.io/api v0.0.0-20190313235455-40a48860b5ab
go: extracting golang.org/x/sys v0.0.0-20190215142949-d0b11bdaac8a
go: extracting golang.org/x/net v0.0.0-20190311183353-d8887717615a
go: extracting k8s.io/api v0.0.0-20190313235455-40a48860b5ab
go: downloading github.com/modern-go/reflect2 v1.0.1
go: downloading github.com/json-iterator/go v1.1.9
go: downloading golang.org/x/text v0.3.0
go: downloading github.com/golang/protobuf v1.3.2
go: downloading github.com/googleapis/gnostic v0.3.1
go: downloading sigs.k8s.io/yaml v1.1.0
go: extracting github.com/modern-go/reflect2 v1.0.1
go: downloading github.com/modern-go/concurrent v0.0.0-20180228061459-e0a39a4cb421
go: extracting sigs.k8s.io/yaml v1.1.0
go: downloading golang.org/x/time v0.0.0-20191024005414-555d28b269f0
go: extracting github.com/modern-go/concurrent v0.0.0-20180228061459-e0a39a4cb421
go: downloading k8s.io/utils v0.0.0-20191218082557-f07c713de883
go: extracting github.com/json-iterator/go v1.1.9
go: extracting golang.org/x/time v0.0.0-20191024005414-555d28b269f0
go: downloading github.com/davecgh/go-spew v1.1.1
go: downloading golang.org/x/oauth2 v0.0.0-20191202225959-858c2ad4c8b6
go: extracting k8s.io/utils v0.0.0-20191218082557-f07c713de883
go: extracting github.com/davecgh/go-spew v1.1.1
go: extracting golang.org/x/oauth2 v0.0.0-20191202225959-858c2ad4c8b6
go: extracting github.com/golang/protobuf v1.3.2
go: extracting github.com/googleapis/gnostic v0.3.1
go: extracting github.com/gogo/protobuf v1.3.1
go: extracting golang.org/x/text v0.3.0
Building secrets-provider-for-k8s:0.4.0-6e56e3d Docker image
Sending build context to Docker daemon  80.26MB
Step 1/15 : FROM busybox
 ---> 83aa35aa1c79
Step 2/15 : FROM scratch
 --->
Step 3/15 : MAINTAINER Conjur Inc
 ---> Using cache
 ---> 3d38a959c79b
Step 4/15 : COPY --from=0 /bin/tar /bin/tar
 ---> Using cache
 ---> a2bb9c8b0815
Step 5/15 : COPY --from=0 /bin/sleep /bin/sleep
 ---> Using cache
 ---> 77864982ab8c
Step 6/15 : COPY --from=0 /bin/sh /bin/sh
 ---> Using cache
 ---> 2aae3e4f46d3
Step 7/15 : COPY --from=0 /bin/ls /bin/ls
 ---> Using cache
 ---> 2a7915f13174
Step 8/15 : COPY --from=0 /bin/id /bin/id
 ---> Using cache
 ---> 55d2ab721d55
Step 9/15 : COPY --from=0 /bin/whoami /bin/whoami
 ---> Using cache
 ---> 082c30085dbf
Step 10/15 : COPY --from=0 /bin/mkdir /bin/mkdir
 ---> Using cache
 ---> 882401f10693
Step 11/15 : COPY --from=0 /bin/chmod /bin/chmod
 ---> Using cache
 ---> e8a8e046f6be
Step 12/15 : COPY --from=0 /bin/cat /bin/cat
 ---> Using cache
 ---> 60d05c2bd2c5
Step 13/15 : RUN mkdir -p /etc/conjur/ssl && chmod 777 /etc/conjur/ssl
 ---> Using cache
 ---> 95b7fb9f3557
Step 14/15 : ADD secrets-provider /bin
 ---> Using cache
 ---> b5ffe3f302bd
Step 15/15 : CMD ["secrets-provider"]
 ---> Using cache
 ---> 176c7002a5ae
Successfully built 176c7002a5ae
Successfully tagged secrets-provider-for-k8s:dev
Successfully tagged secrets-provider-for-k8s:0.4.0-6e56e3d
Successfully tagged secrets-provider-for-k8s:latest
---

Well I got
go<EMAIL_ADDRESS>unknown revision v1.2.2
go<EMAIL_ADDRESS>unknown revision v1.0.5
go: error loading module requirements

But now I re-ran and it passed. thanks :)

thanks @saprette for the thorough description in the comments. However, this is a bit too much :)
I think that something like this will be better:
Add support for complex secrets

The secrets-provider had as issue with providing complex secrets to k8s. For example, the secret `<add-secret-here>` failed to be provided from Conjur.

Changing the method from PATCH to UPDATE while pushing the secret into k8s solved the issue

The description you have now in the commit can be very helpful for reviewing this so I would add it as a comment here in the PR. The commit, however, should be concise to maintain a good git history.
Also - can you please squash your commits into just one so it is easier to review it?
Thanks!

@saprette when you run conjur variable values add someenv/hf333ocp/artifactory-pull-secret/dockerconfigjson {"auths":{"someurl":{"auth":"sometoken="}}} what are you expecting to be saved in Conjur?
If you run the command above, the quotes will be omitted:
root@9db387f8bfdb:/# conjur variable values add var {"auths":{"someurl":{"auth":"sometoken="}}}
Value added
root@9db387f8bfdb:/# conjur variable value var && echo
{auths:{someurl:{auth:sometoken=}}}
root@9db387f8bfdb:/#

If you want the quotes to be in the Conjur secret (and then be passed on to the K8s secret) you need to escape the quotes:
root@9db387f8bfdb:/# conjur variable values add var {\"auths\":{\"someurl\":{\"auth\":\"sometoken=\"}}}
Value added
root@9db387f8bfdb:/# conjur variable value var && echo
{"auths":{"someurl":{"auth":"sometoken="}}}
root@9db387f8bfdb:/#

@saprette as a side-note, when you run conjur variable values add someenv/hf333ocp/artifactory-pull-secret/dockerconfigjson {"auths":{"someurl":{"auth":"sometoken="}}} what are you expecting to be saved in Conjur?
If you run the command above, the quotes will be omitted:
root@9db387f8bfdb:/# conjur variable values add var {"auths":{"someurl":{"auth":"sometoken="}}}
Value added
root@9db387f8bfdb:/# conjur variable value var && echo
{auths:{someurl:{auth:sometoken=}}}
root@9db387f8bfdb:/#

If you want the quotes to be in the Conjur secret (and then be passed on to the K8s secret) you need to escape the quotes:
root@9db387f8bfdb:/# conjur variable values add var {\"auths\":{\"someurl\":{\"auth\":\"sometoken=\"}}}
Value added
root@9db387f8bfdb:/# conjur variable value var && echo
{"auths":{"someurl":{"auth":"sometoken="}}}
root@9db387f8bfdb:/#

Thanks, in fact I just did that to document it because on my side I have a Helm Chart with a Job doing everything (load policies + init some variables) but it was too much for the example.
It does something like that
add_value 'conjur/authn-k8s/kubernetes_authenticator/ca/key' "$(cat /tmp/conjur-config-k8-authenticator-ca/tls.key)"
add_value 'conjur/authn-k8s/kubernetes_authenticator/ca/cert' "$(cat /tmp/conjur-config-k8-authenticator-ca/tls.crt)"
add_value 'clearstream/hf333ocp/git-credentials/ssh-privatekey' "$(cat /tmp/conjur-config-git-ssh-key/ssh-privatekey)"
add_value 'clearstream/hf333ocp/artifactory-pull-secret/dockerconfigjson' "$(cat /tmp/conjur-config-dockerconfigjson/.dockerconfigjson)"

With this function
function add_value() {
  key=${1:?Missing key parameter}
  value=${2:?Missing value parameter}

  INFO "Set value of variable [${key}]"

  conjur variable values add "${key}" "${value}"

  returnCd=$?
  if [[ ! $returnCd -eq 0 ]]; then
    ERROR "Failed to set value of variable [${key}]"
    exit $returnCd
  fi
}

Your commit with the change of the permission to update got into the squash I hope you don't mint (I included your comment)

Yeah, it's fine. I am working now on an integration test for your work.
Great job! This really makes the code better! not only in functionality but also in the implementation itself. Moving to update cleaned the code :)

@saprette I added an integration test for complex secrets and verified all the tests are passing. Great Job!
I'll get someone from my team to review this as I also added some code. Hopefully it will be merged to master in the next few days.
Thanks a lot for this!

Changed the base branch to provide-complex-secrets and created a PR to merge it into master.
Thanks @saprette for this contribution! Please follow the other PR to see it merged into master.

@saprette your change is being reviewed and will be merged to master once it is ready.
It will be available in our next release. thanks :)


[NPM-3114] Remove randomness in picking ports in tests

What does this PR do?
This PR changes tests to let the OS pick an open port instead of relying on the math/rand library to pick one randomly.

Motivation
https://datadoghq.atlassian.net/browse/NPM-3114

Additional Notes

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

Reviewer's Checklist

[x] If known, an appropriate milestone has been selected; otherwise the Triage milestone is set.
[ ] Use the major_change label if your change either has a major impact on the code base, is impacting multiple teams or is changing important well-established internals of the Agent. This label will be use during QA to make sure each team pay extra attention to the changed behavior. For any customer facing change use a releasenote.
[x] A release note has been added or the changelog/no-changelog label has been applied.
[ ] Changed code has automated tests for its functionality.
[x] Adequate QA/testing plan information is provided. Except if the qa/skip-qa label, with required either qa/done or qa/no-code-change labels, are applied.
[x] At least one team/.. label has been applied, indicating the team(s) that should QA this change.
[ ] If applicable, docs team has been notified or an issue has been opened on the documentation repo.
[ ] If applicable, the need-change/operator and need-change/helm labels have been applied.
[ ] If applicable, the k8s/<min-version> label, indicating the lowest Kubernetes version compatible with this feature.
[ ] If applicable, the config template has been updated.

/merge


v2 work

[x] deprecated data_frame()
[x] catch bad LaTex?
[x] double click to select node

[x] select parent node
[x] single click to select child node
[x] single click to move node

[x] Add "new node" button to nodes
[x] Get daggity review to work
[x] Remove search bar for easier button inputs
[x] Add context-specific help text about click pad clicking
[x] Profile speed when number of nodes/edges increases
[x] Ensure edit LaTeX works
[x] Fix image properties
[ ] Pre-populated examples
[x] Disable undo/redo UI when app is busy

Edge aesthetics UI issues
https://apps.gerkelab.com/dev/shinyDAG/?_state_id_=732a801b3f310f80

View edge UI
Go back to Tweak and drag a node into staging area
View edge UI and maybe it updates 🤷♂

[ ] longer debounce on the text input

basically just the examples left now...


Nav editor in admin is broken (missing template)

This is probably a result of my theme/pathing re-org the other day.

Navigation in general is still on shaky ground.  Sorting was broken last I checked.


Override validation for submission 6407433ed51a04000156b5b5 to allow files with <100k rows

Submission page:
https://www.ebi.ac.uk/gwas/deposition/submission/6407433ed51a04000156b5b5

@jdhayhurst should this be complete now, or is there still another step? (It's still showing as invalid on the submission page https://www.ebi.ac.uk/gwas/deposition/submission/6407433ed51a04000156b5b5)

this is done, so closing ticket


Extend storage timeout for init store calls.

Init store code path does not need to run with small storage timeout.

Looks like one of our recent tests is being flaky.    I'll address that separately but I think just rerunning the failed legs should clear it.


Now working

is this still working
not giving any result ?

broke due to a change on the immunefi website. just fixed with with https://github.com/tintinweb/bugbounty-companion/commit/87235e067b5bff84fd53908b84a4893516c772b0
cheers 🙌


tensorboard can only show one log

i start 4 same run under same work_dirs but my tensorboard only show one one logfile. what is happening?i run tensorboard --logdir /data/zhaozhiyuan/mmdetection_checkpoints/6_2/split1_1way_cctv/logo_faster_rcnn_r50_fpn_1x_coco_attention_detector_bce/tf_logs
under the workdir there are 4 runs(/data/zhaozhiyuan/mmdetection_checkpoints/6_2/split1_1way_cctv/logo_faster_rcnn_r50_fpn_1x_coco_attention_detector_bce/tf_logs)

problem lies in work_dirs.... When 4 events under same dir my tensorboard thinks they are one events...


Components do not render children

Components that have children seem do not actually render their children.
I've created a gist demonstrating the behavior.
Here is the output I get when I run ospec on the code from the gist:
parent component:
"

"
should equal
"
howdy
"

    at o (C:\Users\Ben\Code\bc9205a33538e025f1e503dc0211b171\index.js:24:50)

parent component:
"

"
should equal
"
howdy
"

    at o (C:\Users\Ben\Code\bc9205a33538e025f1e503dc0211b171\index.js:25:61)

4 assertions completed in 24ms, of which 2 failed

It seems like adding children: copy(view.children) to the component vnode creation fixes things, but I'm not sure if that's the proper fix?

I would assume this is a proper fix
Could you provide a PR with test plz?
Am 13.12.2016 18:48 schrieb "Ben Chauvette"<EMAIL_ADDRESS>
Components that have children seem to not actually render their children.
I've created a gist demonstrating the behavior
https://gist.github.com/bdchauvette/bc9205a33538e025f1e503dc0211b171.
Here is the output I get when I run ospec on the code from the gist:
parent component:
""
should equal
"howdy"
at o (C:\Users\Ben\Code\bc9205a33538e025f1e503dc0211b171\index.js:24:50)

parent component:
""
should equal
"howdy"
at o (C:\Users\Ben\Code\bc9205a33538e025f1e503dc0211b171\index.js:25:61)

4 assertions completed in 24ms, of which 2 failed
It seems like adding children: copy(view.children) to the component vnode
creation fixes things, but I'm not sure if that's the proper fix?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/StephanHoyer/mithril-node-render/issues/49, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AADVrfHXxkDh3PSAGhXDSoB0yFb6pEkuks5rHtpxgaJpZM4LMBxj
.

fixed with #50

fyi just released<EMAIL_ADDRESS>Now we also support component child rendering

Awesome, thanks! :+1:


Support channel affinity batch binding.

For cases in which bound objects are created in batch and need to be bound to the same channel that they were created in.
Will submit a PR with required changes shortly.

Closing as this was addresses in #26 and released in v1.2.0


proper way to sign with header

Quick question, if i needed to sign something with the following header:
{
  "alg": "HS256",
  "typ": "JWT",
  "dd-ver": "AA-JWT-V1"
}

What would be the proper way to go about doing this with your package...i seem to be failing.
Thanks!

Reading through your code it seems this would not be possible :/


[🚮] KSR10

What ❓
KSR10 is over. This PR gets rid of the unused code.
How to QA? 🤔
Run the app; there should be no easter eggs even if you change the date of the device.
Story 📖
Trello Story

 Remove KSR10 Code


Detect commit channel instead of assuming nightly

At the moment, the tool can't download commits like 0c8ba60c6e4b2dbd83404d22ccaad4fe33a3a129 because they're from the beta branch, which sets the channel name to beta instead of nightly.
This PR automatically detect the channel of each commit by looking for a rust-src-{channel}.tar.xz file, trying nightly, beta and stable. If no channel is found an error is shown as usual.
This is blocking the Crater run in https://github.com/rust-lang/rust/pull/55884.
cc @petrochenkov

Could you just add a --channel flag instead of guess-and-try?

Hmm, I'd prefer if the tool just works without specifying which channel the commit is in, since it's a big usability improvement. The tool already automatically detects the latest commit if you don't provide one anyway. If you want I can add an optional --channel flag to manually override it though.

I'd prefer being able to opt-out of magic.
Also, could you remove the rustfmt commit to make it easier to review? I could do the format after the PR.

Thanks!


Drop animation regression in<EMAIL_ADDRESS>

Hi there!
I just tried upgrading to the latest release and noticed a regression in drop animation. When the drop animation finishes, the drag overlay flashes where it was before the item was released, and this flicker is quite noticeable.
https://user-images.githubusercontent.com/64441155/169637661-000139b3-0470-4cf6-8f8f-d104531908e9.mov
Codesandbox: https://codesandbox.io/s/condescending-mayer-kqm4to?file=/src/App.tsx
Codesandbox using<EMAIL_ADDRESS>that doesn't experience this issue: https://codesandbox.io/s/github/igordanchenko/react-photo-album/tree/main/examples/sortable-gallery

I am experiencing the exact same issue after updating to latest and had to roll back to the previous version to fix it.

Will release a fix in a patch release soon, thanks for the detailed report.

Thanks! Looks good now.


Error

An error appears while trying to input data of the wishes, reloading the page doesn't help

Press ctrl+F5 or ctrl+shift+r


Asterism’s background image quality is impacted by KFX’ rasterization

Amazon has chosen to rasterize SVG for KFX, which impacts the background-image for hr.asterism.

Quality is not great at larger font-sizes, which defeats the purpose of using SVG. In addition, the background-color is slightly off.
Must do some checks first but enlarging the viewport in the SVG file may solve this issue… (see related script)

Changing the SVG’s viewport makes absolutely no difference at all.
Gave the rasterising script a very quick look and it seems the logic is flawed – and some “software engineers” didn’t get the memo that you can increase font-size in reflowable text, and won’t rasterise SVG to a big-enough image – but only one meeting default font-size requirements.
Wontfix.
¯\(ツ)/¯


Editing for task 1623158

In particular, see my changes to the list of allowable file name characters. I made it user friendly, but for example if Azure says "digits" instead of "numbers" it would be better to use what Azure users are used to.


docs: pointers to plugins blog post

This is definitely useful content to share! Awesome work and thanks for putting this together, @evans !
Two questions:

The blog post seems to be encouraging people to share their plugins, but CONTRIBUTING.md still kind of discourages it.
Blog post:

If your (typo here BTW) your plugin is something you think the entire Superset community can make use of, feel free to open a pull request to superset-ui! For plugins that are more experimental, or for specialized/rare use cases, we plan to provide a better means to publish such viz plugins in the near future (and let you know about it here!).

incubator-superset/CONTRIBUTING.md:

Superset is working towards a plugin system where new visualizations can be installed as optional npm packages. To achieve this goal, we are not accepting pull requests for new community-contributed visualization types at the moment. However, bugfixes for current visualizations are welcome.

While they do not necessarily conflict with each other, do you think there's a need to reconcile the tones?

The FAQ page already has a section two questions about creating new visualizations. Maybe merge and update?

I'm also a little concerned about adding links to an external resource that is not part of the Superset project. Apart from the risk of content being outdated, permlinks moved, etc, there also seems to be a conflict of interest that I simply couldn't overlook. Are we comfortable this is how we wanna manage the docs (and potentially new feature releases---there's language like "let you know about it here" in the blog post)? What about other contents Preset may create in the future? And what if some other people want to add their own tutorial posts to the official docs?
Don't get me wrong, Preset has done a great deal of valuable work for viz plugins and we must give credit where credit's due---just wanted to make sure our practice is prudent and future-proof here.

@rusackas ^

This is one of the most common questions on our Slack / GitHub issues and it seems like a shame not to provide that pointer.
I think we're committed to keeping the blog post alive and up to date, but I agree that it may belong closer to the docs. Maybe we bring that back to the Superset docs in the future as it settles?

@ktmud I did (and do!) intend to bring alignment to the messaging here. We're still working on a path toward dynamic imports, which will really open the floodgates, but in the interim, I'm hoping to propose some changes to CONTRIBUTING.md to slightly soften the restriction. Something along the lines that the community can be open to reviewing PRs for new plugins on Superset-UI if they're applicable to the broader community, but that we might not necessarily accept PRs to add them as default plugins in incubator-superset`. Do you think that would be a reasonable compromise for the time being?
As for the conflict of interest, I completely understand where you're coming from, and have no intention of ruffling feathers with the community or Apache. I/we do intend to maintain the blog post as needed, while continuing to improve the process. When things are a little further along (both the plugins and the docs), I'm hoping to migrate the content/process into the official Superset documentation, thus replacing the link.

Oh, and thanks for catching that typo, @ktmud :)

Added some copy changes (and random markdown auto-formatting) on this PR to your branch, @mistercrunch

Didn't realize we already have a Resources section in the README already. I think it makes sense to include these type of resources as they are super useful to the community. It's probably even OK to keep them as external links as they are just nice-to-have learning materials.
I do really hope we can create the new doc site as soon as possible though so that Roadmap/Feature Announcement type of content can have a better home.

2. The FAQ page already has a section two questions about creating new visualizations. Maybe merge and update?

^ Also want to make sure you saw this.
https://github.com/mistercrunch/superset/blob/readme_plugins/docs/faq.rst#how-do-i-create-my-own-visualization
https://github.com/mistercrunch/superset/blob/readme_plugins/docs/faq.rst#how-do-i-go-about-developing-a-new-visualization-type
Can we remove these two questions with outdate examples?

@ktmud Thanks for pointing out those two links. I'll update those in a separate PR if that's OK. Maybe this one could be pushed through otherwise, and I'll pick it up from there?
@mistercrunch looks like this needs a rebase :/

Could you update to include my last name?
https://preset.io/blog/2020-07-02-hello-world/

Could you update to include my last name?
https://preset.io/blog/2020-07-02-hello-world/

Of course! Sorry I missed that!

This one seems to be kind of lingering. @mistercrunch would you mind a quick rebase on this, and @ktmud mind if I address the docs wording in a separate PR?

rebased!


HSEARCH-1825

Needs to be merged both in branch 5.1 and master
Evolves on PR#801, thanks @torkis !

https://hibernate.atlassian.net/browse/HSEARCH-1825

I've merged this, will be included in 5.1.1.Final and 5.2+


Missing Object.assign() for _.extend/assign

Doesn't match behaviour exactly IIRC, but matches close enough for most people's use cases

@kotarou3 That sounds good. Welcome PR. :smile:

Looks like this is done so it can be closed.

thank you!


Thoughts on calling a command / sending a message when a specific route is loaded

For example:
When a user navigated to /product/123, call a command (or send a message) that effectively loads the product with ID 123.
There are many examples of how to achieve this via a user action (e.g. on clicking a button) but not for achieving this on load of a specific view (without having that view as a child component that uses its own init function, which I'm trying to avoid in favor of the flatter architecture outline in this repo).
By the way, I've found this repo super useful for helping simplify the otherwise overly complex approaches to SPAs in Elm. Thank you!

Figured out what seems to be a nice approach to this (sharing here in case it's helpful for others).
Essentially, add a command that case matches on the current route and then sends a message. Something like:
-- Used for changing a `Msg` into a `Cmd Msg`

onUrlChange : Route -> Cmd Msg
onUrlChange route =
    case route of
        HomeRoute ->
            send OnHomeInit

        NotFoundRoute ->
            Cmd.none

-- Helpers

send : msg -> Cmd msg
send =
    Task.succeed >> Task.perform identity

Then, call this command in 2 places:

On the app's initial init.
In the update handler for handling url changes (which seems to be commonly named ChangedUrl).

Example:
-- In E_Init.elm

init : () -> Url -> Nav.Key -> ( Model, Cmd Msg )
init flags url navKey =
    ( model url navKey
    , onUrlChange (urlToRoute url)
    )

-- In F_Update.elm

ChangedUrl url ->
   let
         route =
            urlToRoute url
   in
   ( { model | route = route }, onUrlChange route )


background: added registry event handling

From now on, registry notifications (image got pushed, image deleted)
will be handled entirely in the background. Portus itself will only
create the event on the DB, and it will expect for it to be handled
automatically by the background process.
Fixes #940
See #1353 and #1526
Signed-off-by: Miquel Sabaté Solà<EMAIL_ADDRESS>

Let me check those flaky tests...


Fixes Q logo for documentup

The documentation on documentup is rendering html attributes on the page. I believe this is because of how it is parsing the line break in the readme doc, which should be fixed by this PR.

Even though this got merged, it's not reflected on documentup.com... I think you might need to pull the commit into the gh-pages branch for this?

The commit hook might be amiss. I forced a recompile with the manual hook http://documentup.com/kriskowal/q/__recompile and it looks fine to me.

Ah, yes -- better now. Thanks!


Add support for qual pushdown on the form WHERE col=val1 OR col=val2 OR col=val3 OR ...

This PR adds support for qual pushdown when there is a WHERE condition of the form
SELECT *
...
WHERE col=val1 OR col=val2 OR col=val3 OR ...

where col is a column that is marked as a (possibly optional, but especially required) qual. WHERE conditions of that shape are converted into a qual with the same form as that generated by conditions of the form WHERE col IN(val1, val2, val3, ...), which is already supported by all plugins due to the SDK automatically unrolling a single qual with a list value into repeated List calls.
Currently, such conditions aren't interpreted since OR is a BoolExpr, and the only supported BoolExpr is NOT col. This means that, for queries with a list of quals separated by ORs, that condition isn't pushed down to the plugin, thus causing a qual-less List call, which can fail if the column is a required qual.
Slack thread: https://turbot-community.slack.com/archives/C01UECB59A7/p1712277130098689

@jreyesr this looks good. Have you tested what happens when you have complex combinations of AND and OR?

Have you tested what happens when you have complex combinations of AND and OR?

Yes, I have tested both cases where ANDs are inside an OR and ORs are inside an AND. If you have any more ideas about complex conditions that may trip this up, let me know and I'll test them.
For ORs inside ANDs, e.g. x AND (y OR z), that is handled already because Postgres already presents those as separate elements on plan.fdw_exprs, so nothing new needs to happen. x on the one hand and y OR z on the other are converted into separate Quals and sent to the plugin: from what I can see, plugins have an implicit AND of all the quals that they receive, so that is handled already.
For ANDs inside ORs (e.g. (x=1 AND y=1) OR (x=1 AND y=2), which you could also think of as encoding two points in a 2D plane, (1, 1) and (1, 2)), it depends on the exact form of the expression:

If all but one of the conditions inside each OR member are the same, which geometrically would represent fetching points in a 2D space that lie on the same horizontal/vertical line, or on a 3D space that lie on the same orthogonal line (e.g. above, where x=1 is repeated on each member), then that is optimized by Postgres, before it even reaches the FDW, into the form x=1 AND (y=1 OR y=2). AFAICS, this is documented and reliable behavior, see the Postgres optimizer, particularly the find_duplicate_ors function and its called functions. Postgres code calls it the "inverse OR distributive law". This will be handled as the case above, ORs inside ANDs, and will result in two Quals: one for x=1 and another for y=1 OR y=2, which generates the same Qual and is therefore processed by plugins in the same way as if it had been y IN(1, 2)
Otherwise (e.g. (x=1 AND y=1) OR (x=2 AND y=2), which geometrically would be fetching completely independent points, that don't lie on the same line), if there are no shared expressions inside each OR member, that won't be processed, much like no ORs are processed now. The entire OR condition will be ignored and added to the unhandledRestrictions counter, and the FDW will try to list the entire table. It may be possible to make those expressions work too, and in general any OR conditions, by making repeated calls to the plugin, in a way that would emulate a UNION statement, passing a different member of the OR on each call (e.g. split that condition into two separate plugin calls, one with the Quals for WHERE x=1 AND y=1 and another one for WHERE x=2 AND y=2. However, that would require many more changes and a lot of care, such as correctly handling repeated statements (i.e. the difference between UNION and UNION ALL), so I didn't implement it here

@kaidaguerre Done!


LazyConnection failed to use password with special characters

I had problems with LazyConnection regarding password with special characters that broke with the parse_url function, for example:
$uri = "dbuser:xpto123?otpx$xpo88#>@<IP_ADDRESS>:3306/dbname?idle=20.0&timeout=-1";
In the LazyConnection.php class constructor, at line 37, the parse_url function will break the URI in the wrong way because of the "?" Character.
In a palliative solution, when I pass the password I used the function rawurlencode() and in the constructor of the AuthenticateCommand class, I made the following adaptation:
Line 23: $this->passwd = addslashes(rawurldecode($passwd));
Could they solve this problem for good?

@BragaDevOps That's a good question!
I don't think this is currently covered by the documentation, but if your credentials contain special characters, you can simply pass them in percent-encoded like this:
$user = 'n@me';
$pass = '$3cr37';
$host = 'localhost';
$db = 'test';

$uri = rawurlencode($user) . ':' . rawurlencode($pass) . '@' . $host . '/' . rawurlencode($db);
$connection = $factory->createLazyConnection($uri);

I hope this helps :+1:
Also, we should totally add this to the documentation. Does anybody feel like filing a PR? :shipit:


Suggestion: Add the ability to format min and max values on a gauge.

At the moment there is no way to format the min and max labels of a gauge chart. I think that it would be beneficial to have a configuration option that, when set, would use the same format function as the main gauge label.

:+1:

It looks like #1354 fixes this 👍


Add  auc_u_test to performance_metrics.py

Fixes https://github.com/FunctionLab/selene/issues/70
Faster implementation of AUC calculation. Performs about 10x faster than previously used implementation: sklearn's roc_auc_score, which is currently offered as the default metric. Calculates the same values as roc_auc_score up to the same precision.

Hi @bmacedo-lgtm, thanks for this! :)
Could you fill out the PR template (just copy and paste the questions from here: https://github.com/FunctionLab/selene/pull/126) so that we have that information consistently across the pull requests?
Also, you can add me as a reviewer to this PR


Added Cache Util Package

Signed-off-by: RJ Garcia<EMAIL_ADDRESS>

Question
Answer

Bug fix?
no

New feature?
yes

BC breaks?
no

Deprecations?
no

Tests pass?
no

Fixed tickets
php-cache/issues#121

License
MIT

Doc PR
reference to the documentation PR, if any

Description

Created new Util repo
Add remember function

TODO

[ ] Add documentation

ping @Nyholm

Here you go: https://packagist.org/packages/cache/util

Dude you rock! Thanks man!


Embedding echosign docs with iframes

Addresses:

https://jira.numenta.com/browse/WEB-472
https://jira.numenta.com/browse/WEB-474
https://jira.numenta.com/browse/WEB-476

Added better instructional text on both pages with embeddings,
explaining what to do if there is no Flash, and how to get to the direct
signing page if the embedding doesn't load.
Switched from javascript embed (not loading on localhost or staging) to
an iframe embed, which loaded in all environments.

@lscheinkman please review
cc @cbaranski @cmaver

👍 LGTM


Adding read-nodes permission to project owner

Requested by the windows team to help resolve #36432 .
When attempting to exec into a pod, the UI now needs to know if that pod represents a windows container or a linux container. Presumably this is because it needs to know which shell command (cmd vs sh) to use to exec into the container. @phillipsj correct me if I am wrong there.
It attempts to do this by looking at the node. Project owners, in the current state, can't see nodes, and as such can't tell if this is a windows/linux container. This adds the permissions to the project owner to see the node, and adds the node resource to the list of objects that is created in the project-owner-promoted cluster role (i.e. permissions granted by a cluster role binding which represents non-namespaced resources).
The security concern here would be if we want, in the long term, project owners to be able to see nodes.

@rmweir

Because of this are project owners privy to the nodes ssh keys or can now do a node exec?

I'm not 100% sure what you mean here.
I think that you were thinking of node objects in the management.cattle.io api group. This change does not grant access to those resources.
This grants access to node objects in the core api group (i.e. the default node object in k8s). I don't see a ssh key in the api spec or in an example object. I also don't see how you would exec into a node without the ssh key/ permission to deploy a daemonset - if you could elaborate there I would appreciate it.

@thedadams One of the questions that came up here was surrounding potential sensitive data in the node objects (keep in mind these are nodes from k8s core api group, not our CRD defined nodes). Would you happen to see any potential issues with giving read (get, list, watch) permissions to project-owners for nodes of clusters that they own projects in?

@MbolotSuse I just tested the following and it all now works as expected. I created a project and namespace deploying the
daemonset we have here. I was able to exec into both OSes with the following account types.

exec shell on linux workload:

as admin -- pass
as standard user, cluster owner -- pass
as standard user, project owner -- pass

exec shell on windows workload:

as admin -- pass
as standard user, cluster owner -- pass
as standard user, project owner -- pass

This a screenshot while being a standard user that is a project owner. The failed node call is now fixed and you can exec into a Windows pod just fine.

@phillipsj Ok - looks like we are good on our side from a permissions perspective. I need to run a couple of checks to make sure that this doesn't have any negative side effects, but once I make that confirmation we should be clear to merge this in and close out your issue.
The other thing that we will need to do here is have to docs updated so that people know they need read permissions on nodes if they want to exec into windows pods on those nodes. Not everyone uses the standard RBAC roles so this will need to be published so that people who roll their own RBAC setups can deal with this too.


[WIP] Generic topology construction

@miq-bot add_label providers/containers, refactoring, wip
wip, needs more work and tests fixing, and depends on #6661

Very interesting...looking forward to this.  One big concern is that this could be a painful N+1 (which you might even have already with the present topology), but should be easily mitigated with some includes, which will be a lot easier with the extraction of the tree in question.
In my view, there really is a lot of overlap with explorer trees and topology maps, particularly with querying the data and with assignment of node ids.  I think we can probably learn a lot from our performance issues in the Explorer side, and perhaps set it up so both share the same backend code.  This way, we can write the backend once, but present twice, if necessary.
cc @chessbyte @dmetzger57 @matthewd @jrafanie

Very interesting...looking forward to this. One big concern is that this could be a painful N+1 (which you might even have already with the present topology), but should be easily mitigated with some includes, which will be a lot easier with the extraction of the tree in question.

the structure of the topology remains the same, hence I believe the complexity problem also remains the same.
not sure which includes you are talking about - can you elaborate?

In my view, there really is a lot of overlap with explorer trees and topology maps, particularly with querying the data and with assignment of node ids. I think we can probably learn a lot from our performance issues in the Explorer side, and perhaps set it up so both share the same backend code. This way, we can write the backend once, but present twice, if necessary.

I'm not very familiar with explorer trees pains and implementation, so I cannot comment on that.
regardless, topology is a graph where a lot of entities are interconnected, while explorer are several flat trees iiic, so from a brief look and functional differences I don't see how the code can/should be shared, but I'm open to hear ideas.

not sure which includes you are talking about - can you elaborate?

ActiveRecord includes: http://apidock.com/rails/ActiveRecord/QueryMethods/includes
Basically, preloading the data so it doesn't end up fetching one by one (a.k.a. the N+1 problem).  Try the following in console and watch the SQL it generates to illustrate the problem (note this is presently broken on master for other reasons):
Vm.all.collect(&:host)
# With 1000 VMs, Creates 1001 SQL statements
# vs
Vm.includes(:host).collect(&:host)
# With N VMs, Creates 2 SQL statements

regardless, topology is a graph where a lot of entities are interconnected, while explorer are several flat trees iiic, so from a brief look and functional differences I don't see how the code can/should be shared, but I'm open to hear ideas.

A tree is just a specific type of graph (specifically a directed acyclic graph with single parent).  As such, parts of the graph you are generating are really trees, and those trees are linked together in specific places.  Looking up trees in a relational database is expensive if you have to walk all the nodes all the way down.  So, some of the simpler topologies that go only one level deep aren't really a problem, but as soon as you introduce more levels, it gets exponentially expensive.  As such, we've found ways to make that lookup simpler by using things like the ancestry gem and using ActiveRecord includes.  Addtionally, the TreeBuilders already handle things like RBAC and prefiltering of data.
So, for example, if we wanted to show the EMS -> Folders -> VMs as a topology, I don't think it's a stretch to call TreeBuilderVmsAndTemplates.new(root).relationship_tree (the backend call for the explorer tree that gets the data), and then write a method that converts that relationship tree to the structure needed for the topology viewer.  This method would be similar to the method TreeBuilderVmsAndTemplates#convert_to_ui_tree that coverts the relationship tree to the JSON structure needed for the explorer widget.

So, for example, if we wanted to show the EMS -> Folders -> VMs as a topology, I don't think it's a stretch to call TreeBuilderVmsAndTemplates.new(root).relationship_tree (the backend call for the explorer tree that gets the data), and then write a method that converts that relationship tree to the structure needed for the topology viewer. This method would be similar to the method TreeBuilderVmsAndTemplates#convert_to_ui_tree that coverts the relationship tree to the JSON structure needed for the explorer widget.

@Fryguy I cannot find anywhere in the source code the method convert_to_ui_tree. perhaps it was deleted?

@Fryguy I tried to follow the tree builders code, it is really hard to follow and understand it - are you well familiar with it to walk me through it? also, there's no tree builder for containers.

@miq-bot add_label topology

@miq-bot rm_label wip

@Fryguy @blomquisg could you guys review? Looks ready to merge for me. :+1:

@Ladas will have a fix for the typo in #7626.


deprecation warning

Users/buzz/.rvm/gems/ruby-2.2.0/gems/chatterbot-1.0.1/lib/chatterbot/tweet.rb:29:in `reply': [DEPRECATION] #[:id] is deprecated. Use #id to fetch the value.
I'm using streaming with the reply functionality. I would love to take a stab at fixing it.. where should i look?

There's a good chance this is already fixed in master, I've been cleaning these up bit-by-bit. Basically any reference to tweet[:id] needs to be replaced with tweet.id.

Great bot builder! I recently forked from master and this is still here (tweet.rb:29). Just FYI. Keep up the great work

This is in master now, I wrote the code and never committed it :(

Some reason I am still getting the same error as OP


mark transaction for rollback only after rejection of parallel use

pull fixes #156

Changes look good but was there a particular reason why the tests don't always call rollback for the finally step.
No reason that I know of.   It would certainly be valid to do that, and a bit simpler because we wouldn't need it to track whether or not the attempt to run in parallel was rejected. Would you prefer that I change it to that?

No need to make any changes to the PR, it was just a query and you have answered it, thanks.


Remove dependency on git being installed on host

At present the git_dir() helper is called (which in turn runs a git command) on every command even when a git path is provided. This change moves the default to only being called when --git-dir is not specified, it is fully backwards compatible.
This is helpful because in a containerised environment git may not be available as the developer uses git on their local machine.
Before:
sam:~$ vendor/bin/cghooks update --git-dir=".git"
sh: git: not found
sh: git: not found
sh: git: not found
sh: git: not found
Updated pre-commit hook
Updated post-merge hook

After:
sam:~$ vendor/bin/cghooks update --git-dir=".git"
Updated pre-commit hook
Updated post-merge hook

The tests were failing due to an issue with the working tree test. Specifically, the working tree test was depending upon git_dir() running before the working tree was changed which failed now that we are calling git_dir later. I have resolved this issue by changing from git-dir to git-common-dir which is...

GIT_COMMON_DIR
If this variable is set to a path, non-worktree files that are normally in $GIT_DIR will be taken from this path instead. Worktree-specific files such as HEAD or index are taken from $GIT_DIR. See gitrepository-layout[5] and git-worktree[1] for details. This variable has lower precedence than other path variables such as GIT_INDEX_FILE, GIT_OBJECT_DIRECTORY…

https://git-scm.com/docs/git-rev-parse

Hi @shrink thanks for the contribution! This looks very good, especially the common dir part. Nice find


refactor: Separating statement parse func

I hereby agree to the terms of the GreptimeDB CLA
What's changed and what's your intention?
split show ,describe,explain,dropstatement parsing into separate *_parser.rs file and place it in the sql/parsers directory, just like other statements.
Checklist

[ ]  I have written the necessary rustdoc comments.
[ ]  I have added the necessary unit tests and integration tests.

Refer to a related PR or issue link (optional)
https://github.com/GreptimeTeam/greptimedb/issues/1914

I only refactor the show statement parsing now,and i want to know if do the right thing?If i do,i will continue refactoring the left statement parsing,thx!

@Gump9 you're doing it right. Just delete codes instead of comment them out.

@waynexia Hi,I have done this refactor😈


tests: add test harness for loader

Fixes #1
Mock out the following callbacks:

[x] getc: not implemented
[x] putc: not implemented
[x] poll: not implemented
[x] open: copy from bhyveload
[x] close: copy from bhyveload
[x] isdir: copy from bhyveload
[x] read: copy from bhyveload
[x] readdir: copy from bhyveload
[x] seek: copy from bhyveload
[x] stat: copy from bhyveload
[x] diskread: not implemented
[x] diskioctl: not implemented
[ ] copyin
[ ] copyout
[ ] setreg
[ ] setmsr
[ ] setcr
[ ] setgdt
[ ] exec
[ ] delay
[x] exit: mock out
[x] getmem: mock out
[x] getenv: copy from bhyveload
[ ] vm_set_register
[ ] vm_set_desc

It seems like strlcpy and strlcat are not portable:
mock/bhyveload.c:87:2: warning: implicitly declaring library function 'strlcpy'
      with type 'unsigned long (char *, const char *, unsigned long)'
      [-Wimplicit-function-declaration]
        strlcpy(path, host_base, PATH_MAX);
        ^
mock/bhyveload.c:87:2: note: include the header <string.h> or explicitly provide
      a declaration for 'strlcpy'
mock/bhyveload.c:90:2: warning: implicitly declaring library function 'strlcat'
      with type 'unsigned long (char *, const char *, unsigned long)'
      [-Wimplicit-function-declaration]
        strlcat(path, filename, PATH_MAX);
        ^


Adding Unit Test Cases using Jest Testing Library

Subject: Request for Jest integration in ReactJS projects on GitHub
Hi there !!
I am writing to request the integration of Jest, a popular JavaScript testing library, into your project that uses ReactJS. This would allow developers to write and run unit tests for their React components directly on the platform. Jest's simplicity and power would greatly improve the development experience and increase the reliability of code.
And the good thing is Jest testing files wouldn't add any memory consumption to the project when we make a build or it is on production.
Please add hard level label under JWoC to this or you can decide it while merging or reviewing PR request.
Thank you for considering this request. I look forward to your response.
Best regards,
Jagroop

@Jagroop2000 i have never used jest first let me gain knowledge about jest and try it
then after that i can assign this issue to you till then you can work on other issues

I want to work on this under JWOC

@mnnkhndlwl Can I build an overall test suite using Cypress for client? And if yes then, you can assign it to me. Under JWOC


soft-delete 'setDeleted' feature

soft delete can now take a string or an object as configuration,
exposing an additional field: setDeleted
setDeleted allows you to specify a function that returns a value that
will be used when a record is soft deleted
use case examples would be a date object or the id of a user that
triggered the deletion.
setDeleted checks to ensure the value returned is truthy, and may be
asynchronous.
Other notes:

tests refactored, no longer throw promise warnings.
removed deprecated babel-preset-es2015 in favour of babel-preset-env.
I'm aware that feathers.js is planning on removing babel, but for the
time being this prevents another deprecation warning.
soft-delete now tries to look for a custom authentication entity
field before defaulting to 'user' in the 'throwIfDeleted' subroutine.

(made a mistake, i'll re submit later)


More documentation.

Codecov Report

Merging #96 (2dbc051) into main (e82fca2) will decrease coverage by 0.14%.
The diff coverage is n/a.

:exclamation: Current head 2dbc051 differs from pull request most recent head d5aa3eb. Consider uploading reports for the commit d5aa3eb to get more accurate results

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
@@            Coverage Diff             @@
##             main      #96      +/-   ##
==========================================
- Coverage   77.75%   77.61%   -0.14%
==========================================
  Files          31       31
  Lines        1196     1193       -3
  Branches      202      202
==========================================
- Hits          930      926       -4
- Misses        203      204       +1
  Partials       63       63

Flag
Coverage Δ

unittests
77.61% <ø> (-0.14%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

belay/cli/cache.py
30.43% <0.00%> (-4.35%)
:arrow_down:

belay/executers.py
82.65% <0.00%> (-0.18%)
:arrow_down:

belay/hash.py
100.00% <0.00%> (ø)

belay/cli/identify.py
28.00% <0.00%> (+1.07%)
:arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

This looks great.


ng update don't work with local modules

Bug Report or Feature Request (mark with an x)
- [x ] bug report -> please search issues before submitting
- [ ] feature request

Command (mark with an x)
- [ ] new
- [ ] build
- [ ] serve
- [ ] test
- [ ] e2e
- [ ] generate
- [ ] add
- [x ] update
- [ ] lint
- [ ] xi18n
- [ ] run
- [ ] config
- [ ] help
- [ ] version
- [ ] doc

Versions

➜  ~ node --version
v10.12.0
➜  ~ npm --version
6.4.1
➜  ~ ng --version
 _                      _                 ____ _     ___
/ \   _ __   __ _ _   _| | __ _ _ __     / ___| |   |_ _|

/ △ \ | '_ \ /  | | | | |/ _ | '__|   | |   | |    | |
/ ___ | | | | (| | || | | (| | |      | || | | |
//   __| ||_, |_,||_,||       _|||
|___/
Angular CLI: 6.2.5
Node: 10.12.0
OS: darwin x64
Angular:
...
Package                      Version
@angular-devkit/architect    0.8.5
@angular-devkit/core         0.8.5
@angular-devkit/schematics   0.8.5
@schematics/angular          0.8.5
@schematics/update           0.8.5
rxjs                         6.2.2
typescript                   2.9.2
Repro steps

I added module to package.json from local path (https://docs.npmjs.com/files/package.json#local-paths)
For example:
"my-module": "file:../modules/my-module",
Run command ng update

The log given by the failure

➜  ~ ng update
Not found : my-module
Desired functionality

Mention any other details that might be useful

Relates to https://github.com/angular/angular-cli/issues/12263

Hey @alan-agius4 I could give this a shot. Any pointers?

@rsarky this should be fixed by https://github.com/angular/angular-cli/pull/12526

Fixed by #12526


Fix RN 0.44 compatibility

BackAndroid is deprecated.  Please use BackHandler instead.
https://github.com/facebook/react-native/commit/b7e9374c649a8e08108ec3165d68d009b88f0dec

@kesha-antonov Hi! I want to use your PR in my project. I have react-native-router-flux in my project but without your changes. Is the way to do this?

What about compatibility with old versions?

@inferusvv Do you have any ideas?

@zalesky I am looking for answer on this question :)

Fixed here: https://github.com/aksonov/react-native-router-flux/issues/1842#issuecomment-313804400


DRF addition break integration with Django Simple Captcha

Since https://github.com/jazzband/django-axes/commit/ae49f3bdae26b9404f83cd7023f3cb39b8b75278 the integration with Django Simple Captcha broken. This forces me to stay on 3.7.x for now.
I have project that contains DRF for certain urls but also contains "normal" django requests. When the lockout is triggered the user is redirected to /locked and normally they see the captcha, but now this piece of code is activated and is detected that a lockout has occured, redirecting the user to /locked even though that is the page we are currently at! Causing a infinite loop.

Hey @jeroenmaas! The simplest way to implement support would be to add your own middleware class that supports your particular setup.

Thank you for the reply @aleksihakli. Guess my use case is a bit special. I'll make my own middleware class that reverts the mentioned commit.


Feature/altitude support for Point, LinearRing, LineString

Hello Justin,
as you proposed, I have updated the three classes Point, LinearRing, LineString to support altitude values.
In addition, I have modified the project file to include unit test support. All three classes are unit tested. However, the white space exception in LinearRing and LineString was not possible to test. Looks like the code is removing the white spaces before checking.
Kindly check my changes. I would be great, if you can take them into Simpe-KML.
I could even help developing:

more unit tests
porting to MacOSX

Cheers,
Markus

Sorry, this branch is no longer mergeable - feel free to rebase against current master and re-submit.


Update to Minecraft 1.20.2

This is a configuration update to Minecraft Normal Edition 1.20.2 - It does not work with 1.19.3, which means this PR isn't ready to go in immediately.
This may need a new version to accommodate.

Does it even make sense to update to 1.20.2? What I mean is - the new villager update fixes the brute forcing. Also, with predefined enchantments from librarians, I would not think, that the 1.20.2 port is just adjusting the version number, I believe the Villager class may have been modified and needs adjustment in the code as well.

The new villager update is not on 1.20.2 (thankfully)

Alright, I will look into it then

Also works with 1.20.3 if you change the fabric.mod.json file :)

It seems, 1.20.2 and Warden are compatible, so I am closing this PR now


css not optimized in production build

Version
@nuxtjs/tailwindcss: ^4.0.3
nuxt: ^2.15.4
Reproduction Link
Sample Repository

Simply create a project using npx create-nuxt-app with TypeScript and Tailwind framework.
Font style isn't necessary, just for presentation.

Steps to reproduce
Build the project
What is Expected?

Title with Google fonts correctly applied in development environment
What is actually happening?

@import rules not working in production environment

And styles are not optimized and minified (@import rules should be moved to the top of style)
Workaround
Configure nuxt.config.js with extractCSS: true (is this intended purpose?)

Actually I don't recommend to use extractCSS for best performances since the CSS is code-splitted with the pages already.

I’m prefer not using extractCSS: true too, though it’s irrelevant to the issue.

Regarding css optimization and minification you are not the only one with troubles. See #361

Please see my solution and let me know if it helped: https://github.com/nuxt-community/tailwindcss-module/issues/361#issuecomment-872897501
And also enable JIT!


[AutoPR] resources/resource-manager

Created to accumulate context: resources/resource-manager

(message created by the CI based on PR content)


Resetting animations

Currently it does not seem possible to reset animations on an entity (neither reset in-progress animations, nor restart animations that ended). It looks like this could be done by making SpritesheetAnimator public and adding a reset_animation(entity) method.

There's now a reset() method on the

https://github.com/merwaaan/bevy_spritesheet_animation/commit/0f1b3ba0a3bc8b7fa644fc6fe601f52d3e8d2914 added a reset() method on the SpritesheetAnimation component following your request :)


Simplify and solidify subscriptions, allow multiple listeners

The Carina socket was based around the socket in beam-client-node. The node client was built around the idea that individual RPC calls (chat messages) are important to send, but this doesn't really matter for Carina, and in fact the queuing to make sure that every call went out actually has lead to some weird bugs/edge cases. Rather, Carina's use case is oriented around tying state to one socket session.
In this PR, I've simplified things a bit. I've exorcised the queue from the socket -- packets can only be sent while the socket is open, otherwise they'll fail. We have Subscription objects that track the state and add themselves to new sockets. This also adds a little feature that lets you add and remove multiple listeners, where previously remove() would remove all listeners for an event.
No breaking changes.

Oh, also, relevant card: https://trello.com/c/PWzLTP95/34-packet-was-cancelled-or-carina-was-closed-noisy-console-error
Pretty sure the issue was that we weren't halting pings when the socket closed


Cannot create IVT / XMPP Configuration

I cannot create a working XMPP Configuration, as can be seen on the screenshot.
I can't change my Password to a short version, as the Buderus Site only accepts 10 characters with capital letters and special characters.
Screenshots

HA version 2022.8.1
HA Bosch component version 0.18.3

bosch.debug_scan doens't work :/

Any ideas?

it's not password to Buderus portal but to your device.

?

last one is password for Bosch device you set during initial setup.

Initial Setup on the Buderus heater (RC310?)

what app do you use?

Oh man i deleted the MyBuderus App and connected the Heater again, set the Password and boom, it works.
Sorry for the cicumstances!


Remove MSVC 2017 builds from CI

This PR removes the MSVC 2017 build from CI.
VS 2017 is no longer in support and GitHub Actions does not provide a virtual environment for this compiler any longer (i.e., windows-2016 has been deprecated and removed).
Signed-off-by: The MathWorks, Inc<EMAIL_ADDRESS>

Codecov Report

Merging #650 (f79f736) into development (43f36a6) will decrease coverage by 0.96%.
The diff coverage is n/a.

@@               Coverage Diff               @@
##           development     #650      +/-   ##
===============================================
- Coverage        90.56%   89.60%   -0.97%
===============================================
  Files              250       90     -160
  Lines            13471     6126    -7345
===============================================
- Hits             12200     5489    -6711
+ Misses            1271      637     -634

Impacted Files
Coverage Δ

...rk/include/cppmicroservices/detail/WaitCondition.h
71.42% <0.00%> (-23.02%)
:arrow_down:

framework/src/bundle/BundleRegistry.cpp
79.29% <0.00%> (-12.68%)
:arrow_down:

framework/src/service/ServiceEvent.cpp
71.79% <0.00%> (-5.76%)
:arrow_down:

framework/src/util/FrameworkPrivate.cpp
70.96% <0.00%> (-5.67%)
:arrow_down:

.../cppmicroservices/detail/BundleAbstractTracked.tpp
82.30% <0.00%> (-4.88%)
:arrow_down:

framework/src/service/ServiceRegistrationBase.cpp
77.90% <0.00%> (-4.75%)
:arrow_down:

...mework/src/service/ServiceReferenceBasePrivate.cpp
88.70% <0.00%> (-4.25%)
:arrow_down:

framework/src/util/FrameworkEvent.cpp
61.81% <0.00%> (-3.94%)
:arrow_down:

framework/src/bundle/BundleResourceBuffer.cpp
67.34% <0.00%> (-3.86%)
:arrow_down:

framework/src/service/ServiceListeners.cpp
96.15% <0.00%> (-3.85%)
:arrow_down:

... and 230 more


add a nag to list all recent dups

We can build #1184 on top of this script

If we don't want to restrict to defects, maybe we should at least skip meta bugs.
And maybe we should skip bugs about intermittent tests, wdyt?

good ideas, fixed


Checksum mismatch Resource Hacker

Latest version of Resource Hacker is 5.1.6 - 4 June 2018.
Error:
...
Error - hashes do not match. Actual value was 'DE24309105F589D0C4F6D19C85D0354C0C8FFE9A2F34054AB2028B4A380C664D'.
ERROR: Checksum for 'C:\Users\2xyo\AppData\Local\Temp\chocolatey\reshack.portable\5.1.1\resource_hacker.zip' did not meet '0b1b42a3e5d97dcaa838cc492e0233ff3d0a5c6b3389327e6418cef338c75a17' for checksum
 type 'sha256'. Consider passing the actual checksums through with --checksum --checksum64 once you validate the checksums are appropriate. A less secure option is to pass --ignore-checksums if necessary.
...

Changes since 5.1.1:

Changes in 5.1.6

Bugfix:  Commandline syntax bug (some commas required trailing spaces)

Changes in 5.1.5

Bugfix:  Comments within some resource definitions would not compile

Changes in 5.1.4

Bugfix:  Editor font preferences not being applied on restart
Bugfix:  Minor buges in commandline processing

Changes in 5.1.2

Update:  Update to commandline sytax and & bugfixes

Thanks @htnhan for the feedback.
After another cup all, reshack.portable has been updated. Now, I have 2 versions on my VM:
reshack.portable v5.1.6 is the latest version available based on your source(s).
resourcehacker.flare v5.1.1 is the latest version available based on your source(s).

According to flarevm_malware.ps1#L193, there is also a "flare" version of the package.

Fixed.
resourcehacker.flare uses an older version 5.1.1 which is more stable.


Can -pull work with non-public images?

I have an image that is not publicly accessible.  I can pull it via gcloud docker -- pull blah, which is probably translated to docker login under the covers.  Is there a way to make this work with the structure test -pull flag?
If so, maybe document how do that.  Maybe I need to fiddle with permissions or environment variables.
If not, maybe document that, because the error message is really vague (Step #0:     	docker_driver.go:241: Error creating container: no such image) and doesn't log the actual image name it's trying.
Luckily, the workaround is fairly easy -- for my case, where I'm invoking from a cloudbuild.yaml, I add a cloudbuild step before the structure test step, that explicitly pulls the image and runs /bin/true in it.
Repro:
$ gcloud container builds submit --config=cloudbuild_test.yaml --substitutions=_DOCKER_NAMESPACE=gcr.io/cloud-python-runtime-qa,_TAG=2018-03-08-174800-ubuntu16 .
<snip>
Step #0: e116a9187528: Pull complete
Step #0: Digest: sha256:3e6162829f0adafeb764883a715628c91c09a5a01c5bb5a25f1662ac76bb173b
Step #0: Status: Downloaded newer image for gcr.io/gcp-runtimes/container-structure-test:v0.2.1
Step #0: Error pulling remote image gcr.io/cloud-python-runtime-qa/python:2018-03-08-174800-ubuntu16: API error (404): {"message":"pull access denied for gcr.io/cloud-python-runtime-qa/python, repository does not exist or may require 'docker login'"}

cloudbuild_test.yaml:
steps:
- name: gcr.io/gcp-runtimes/container-structure-test:v0.2.1
  args: [
   '-pull',
    '-test.v',
    '-image', 'gcr.io/cloud-python-runtime-qa/python:2018-03-08-174800-ubuntu16',
    '/workspace/tests/virtualenv/virtualenv_default.yaml',
    ]

This is definitely a credentials issue. Our container-structure-test binary supports docker-credential-gcr but the docker image currently doesn't (I opened #84 do support that). Currently your best workaround would be to do a docker pull into your local daemon then use the daemon prefix when referencing it.

I know this issue is ancient, but can this tool really not pull from private registries other than those that can be authenticated via gcr helper? I'm have my ~/.docker/config.json with the proper .auths["<registry>"].auth setup and can docker pull the image but container-structure-test fails indicating I need to run docker login.


New access control interface

I will be revamping the access control interface with one that looks similar to google drive's sharing interface.

This was deployed as part of 1.6.1


How Can I load the library using AMD style ?

Hi,
I tried to use the library using the AMD style.
I uploaded the index,js in my Modules Folder, and I included the path in my define method as following:

define(['Modules/index.js'],
    function (index) { } );

But it is not working at all.
Can you please explain or guide me how to load it ?
Note; I'm using Suitescript, it is framework for Netsuite ERP system. It uses the RequireJs to handle the module loading. In order to load a module in suitescript, it must be AMD-Formatted.
Is the library AMD-Formatted or I'm doing something wrong ?
Any help or explanation would be so much appreciated,

The library is not currently compatible with AMD. I could add support for AMD, but I cannot make a promise as to when I will have time to do so.

Thank You david or your quick response.
Actually, I'm not experienced in Javascript world. But when I looked into the code inside index.js I found this piece of code:
if (typeof module !== 'undefined') {
    module.exports = format;
  } else if (typeof define === 'function' && define.amd) {
    define (function() { return format; });
  } else {
    global.format = format;
  }

I expected that it is compatible with AMD. Can you please just tell me what is that code for  ?
Thank you so much.

You are quite right, Nadeem. Please share the results of evaluating the following expressions in your environment:

typeof module
typeof define
typeof define === 'function' && define.amd


[XR] make sure setTarget works as expected in WebXR.

This will calculate the new rotation in the Y axis and apply it to the already-existing rotation to avoid losing the up-direction when using setTarget.

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

Snapshot stored with reference name:
refs/pull/13553/merge
Test environment:
https://babylonsnapshots.z22.web.core.windows.net/refs/pull/13553/merge/index.html
To test a playground add it to the URL, for example:
https://babylonsnapshots.z22.web.core.windows.net/refs/pull/13553/merge/index.html#WGZLGJ#4600
Links to test babylon tools with this snapshot:
https://playground.babylonjs.com/?snapshot=refs/pull/13553/merge
https://sandbox.babylonjs.com/?snapshot=refs/pull/13553/merge
https://gui.babylonjs.com/?snapshot=refs/pull/13553/merge
https://nme.babylonjs.com/?snapshot=refs/pull/13553/merge
To test the snapshot in the playground with a playground ID add it after the snapshot query string:
https://playground.babylonjs.com/?snapshot=refs/pull/13553/merge#BCU1XR#0


rainloop cannot open mail folders with large quantities of messages

RainLoop version, browser, OS:
1.12.0, Chrome, Windows 10 Pro
Expected behavior and actual behavior:
Expected:
i would click on my folder containing 26,243 messages, often with 3k+ unread messages or more, and it would open it and show me my messages.
Actual:
rainloop produces an error for that folder stating: "can't get message list"
Steps to reproduce the problem:
1.> have mail folder containing large # of messages in total (unread count does not matter I feel because i can open the folder fine in roundcube mail and "read" all unread messages and rainloop still fails to list the folder contents).
2.> try to access said folder.
Logs or screenshots:

I have 200.000 unread messages in my inbox, and 1million+ emails in my inbox,, and rainloop works fine.

ok, what's your imap server?
--
Fabian A. Santiago
OpenPGP:
0x643082042dc83e6d94b86c405e3daa18a1c22d8f
Sent from my mobile.
---- On Sat, 20 Apr 2019 05:33:59 -0400 bschelst<EMAIL_ADDRESS>wrote ----

I have 200.000 unread messages in my inbox, and 1million+ emails in my inbox,, and rainloop works fine.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.

I was also seeing this with my Nextcloud instance on my home server, using Dovecot for IMAP.  Since I mostly use KMail and only use Rainloop from my laptop when I'm traveling, it took me a while to research the issue properly, but I finally did.
In my case the problem turned out to be that the default vsz_limit was too low for mmap() to open the large mail folder's dovecot.index.cache file.  Because of that, Rainloop was waiting for dovecot to scan through all of the folder's emails (>100000), causing it to time out with the error message shown in the screenshot above (if I waited for Dovecot's CPU usage to go back down I could usually reload the folder successfully).  After increasing default_vsz_limit the error disappeared, and Rainloop performs much better now.
For comparison, here's some information on my setup:

Rainloop 6.1.0 (run from inside Nextcloud 18.0.1, based on Rainloop 1.13.0)
Dovecot <IP_ADDRESS> using the maildir mailbox format
Gentoo Linux with a 5.4.20 kernel
The server is a (used) Fujitsu Primergy TX140 S1 with 16 GiB of RAM, the hard drive on which the mailbox resides is, however, even older than the server.
BTRFS with LZO compression and the autodefrag mount option (no qgroups).