Added loadBase64Data feature

I added the loadBase64Data feature. So now, it's not limited to save the data to local file system.
You could save the data from getBase64Data and save it somewhere else like database.
Then, load the data using loadBase64Data.
Example
try {
    await controller.loadBase64Data(base64Data);
    // handle success
} catch (e) {
    // handle error
}

Thanks I'll merge it soon


payinvoice is ignoring --amt

When paying an invoice with an amount, but providing the --amt flag, I would have expected it to override the invoice. If this is not the intended behavior, I think it'd be safer to just throw a hard error ("error: trying to pay an invoice that already has an amount") or something.
lncli --no-macaroons payinvoice lntb132u1pdwvgp7pp5up5ztqwgx3udtzwhcn4khhf3cjr7r2h9ns4zzsu7r6dsp7k4aesqdplx5syymr0vd4kzcmrd9hx7tpqxvs9xcmpd3sjqsmgd9czq3njv9c8qatrvd5kumccqp23nylvgl5s6p0jswtt84ux23vnqhsq8k074znz5swnhmpgmjprpl58te4j7mryzk8mecv2jk0mx4qad2yh2mkyk2ypp65gqr0nxqndfqqamzgll --amt 1000
{
	"payment_error": "",
	"payment_preimage": "cf8b9092beb938b319b0cc1d48e8b611762e10dd75ada9d9f35d3001f38ebf2d",
	"payment_route": {
		"total_time_lock": 1295566,
		"total_fees": 3,
		"total_amt": 13203,
		"hops": [
			{
				"chan_id":<PHONE_NUMBER>111473664,
				"chan_capacity": 16777216,
				"amt_to_forward": 13202,
				"fee": 1,
				"expiry": 1295422,
				"amt_to_forward_msat": 13202320,
				"fee_msat": 1013
			},
			{
				"chan_id":<PHONE_NUMBER>063704577,
				"chan_capacity": 8155553,
				"amt_to_forward": 13200,
				"fee": 2,
				"expiry": 1295278,
				"amt_to_forward_msat": 13200000,
				"fee_msat": 2320
			},
			{
				"chan_id":<PHONE_NUMBER>692047872,
				"chan_capacity": 15000000,
				"amt_to_forward": 13200,
				"expiry": 1295278,
				"amt_to_forward_msat": 13200000
			}
		],
		"total_fees_msat": 3333,
		"total_amt_msat": 13203333
	}
}

It's not the intended behavior. The value is only observed if the passed invoice doesn't explicitly specify an amount.


feat(pixels): added y:42,x:45

Checklist

[x] I ran npm test locally and it passed without errors.

[x] I only edited the _data/pixels.json file.

[x] I entered the username in the pixels.json that I'm also using to create this pull request.
[x] I acknowledge that all my contributions will be made under the project's license.

Thank you for your time


FIX: REVIEW AND CORRECT CLASS ENDPOINTS

Proposed Changes in Class Endpoints
Description of Changes
In this pull request, I've made changes and revisions to the endpoints related to classes. The key modification is the addition of a specific middleware that uses JSON Web Token (JWT) to authorize the user before granting access to certain resources.
Details of Changes

Added a JWT authorization middleware to each class endpoint.
Changes include verification of the JWT token to ensure the user is authenticated before processing the request.

Actions for Reviewer
Before approving the pull request, please follow this checklist to ensure the changes work correctly in Postman:

[x] Authentication: Verify that JWT authorization is correctly implemented.
[x] Endpoints: Run Postman requests for each modified endpoint.
[x] Valid Requests: Ensure valid requests with a valid token are properly authorized.
[x] Invalid Requests: Confirm that invalid requests without a token or with an invalid token are appropriately rejected.
[ ] Error Handling: Check that authorization errors are handled appropriately.

Additional Notes
Please provide specific feedback on any issues you may identify during the review. Thank you.

I apologize for the initial commit, I confused the task number.

Thank you for the feedback @migromarj! Currently, I'm unable to implement the handling of 403 errors as it requires communication with the courses microservice, which is not yet in place. Once the necessary integration is completed, I'll ensure to incorporate proper handling for the 403 status code. Appreciate your understanding!

Thank you for the feedback @migromarj! Currently, I'm unable to implement the handling of 403 errors as it requires communication with the courses microservice, which is not yet in place. Once the necessary integration is completed, I'll ensure to incorporate proper handling for the 403 status code. Appreciate your understanding!

You're absolutely right, I'll bear that in mind!


addText with hyperlink and addImage on different slide brakes image

I create a PPT consisting of a slide with an image and another slide with a hyperlink and an image. In this case, the image on the second slide is broken.
I can reproduce the issue with the latest 2.5.0 release.
This issue is likely related to https://github.com/gitbrent/PptxGenJS/issues/465 (which covers hyperlink and image on the same slide). I verified that the test case for https://github.com/gitbrent/PptxGenJS/issues/465 works with my 2.5.0 release, i.e. this issue is a different problem.
Reproduce
This code reproduces the issue:
var PptxGenJS = require("pptxgenjs");

var IMAGE = 'image/gif;base64,R0lGODlhEAAQAMQAAORHHOVSKudfOulrSOp3WOyDZu6QdvCchPGolfO0o/XBs/fNwfjZ0frl3/zy7////wAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAACH5BAkAABAALAAAAAAQABAAAAVVICSOZGlCQAosJ6mu7fiyZeKqNKToQGDsM8hBADgUXoGAiqhSvp5QAnQKGIgUhwFUYLCVDFCrKUE1lBavAViFIDlTImbKC5Gm2hB0SlBCBMQiB0UjIQA7';

var pptx = new PptxGenJS();

var slide1 = pptx.addNewSlide();
slide1.addImage({ data: IMAGE });

var slide2 = pptx.addNewSlide();
slide2.addText([
    {
        text: 'Link',
        options: {
            hyperlink: { url: 'https://www.github.com' }
        }
    }
]);
// This image will be broken
slide2.addImage({ data: IMAGE, y:1 });

pptx.save('reproduce-issue-465');

The code generates the following output:

@gitbrent this bug no longer appears present in the latest build. Here's the v3 updated code I used to test on the 3.2.1 JS Fiddle.
let pptx = new PptxGenJS();
let IMAGE = 'image/gif;base64,R0lGODlhEAAQAMQAAORHHOVSKudfOulrSOp3WOyDZu6QdvCchPGolfO0o/XBs/fNwfjZ0frl3/zy7////wAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAACH5BAkAABAALAAAAAAQABAAAAVVICSOZGlCQAosJ6mu7fiyZeKqNKToQGDsM8hBADgUXoGAiqhSvp5QAnQKGIgUhwFUYLCVDFCrKUE1lBavAViFIDlTImbKC5Gm2hB0SlBCBMQiB0UjIQA7';

let slide1 = pptx.addSlide();
slide1.addImage({ data: IMAGE });

let slide2 = pptx.addSlide();
slide2.addText([
    {
        text: 'Link',
        options: {
            hyperlink: { url: 'https://www.github.com' }
        }
    }
]);
// This image will be broken
slide2.addImage({ data: IMAGE, y:1 });
pptx.writeFile('reproduce-issue-465');

Thanks @ReimaFrgos !


Segregate logically Portainer resources using projects

I am looking for a way to declare access privileges in the compose file or from docker CLI.  Because, when you recreate a container, it removes the privileges so you have to redefine every time the restriction.
I would like to define a new concept project.
Teams --has--> Users
   |             |----has-->projects
   |----has-->projects

The resource (container, network, volume, etc.) will have one project. The resource project will be defined with the label io.portainer.project. Example: if the resource has label io.portainer.project=dev, then, each team or user will have the access privileges if it belongs to the dev project.
Related #1257

Sounds like what UCP is doing with collections, thoughts @ncresswell ? We might go further than simply managing UAC with projects, we could also give the ability to remove all the resources associated to a project via the UI, for example.

UCP’s collections are somewhat similar, but they go one step further and can restrict the execution of a collection to a specified node or nodes in the cluster. This is how they achieve their multi-tenancy.
I want to do something similar, but not through the assignment to a host, but with the creation of resource pools.
We already know the total capacity of the cluster (CPU/RAM) so we should be able to define a model whereby when a resource pool is defined, we can set the maximum resources able to be consumed by all containers running within that pool (which means we force the use of CPU/Memory constraints).
This is a little different from what you are asking though; it seems you are after a way to logically group/visualise all created stacks/services/containers/networks/volumes/secrets/configs for a particular team into a “project”. Given this is primarily a visualisation / human aid, it shouldn’t be too hard to add. We do need to ensure that access control can be set at the project level and it automatically propagate through.
From: Anthony Lapenna<EMAIL_ADDRESS>Sent: Tuesday, 21 August 2018 3:13 AM
To: portainer/portainer<EMAIL_ADDRESS>Cc: Neil Cresswell<EMAIL_ADDRESS>Mention<EMAIL_ADDRESS>Subject: Re: [portainer/portainer] Segregate logically Portainer resources using projects (#2190)
Sounds like what UCP is doing with collections, thoughts @ncresswellhttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_ncresswell&d=DwMCaQ&c=euGZstcaTDllvimEN8b7jXrwqOf-v5A_CdpgnVfiiMM&r=0fx0h4vB56iTLpw2McH1ZD6TqG_QGpbggVOB-PfMJpM&m=A78sjh5vpYB9-pewAN-vDsbn5Ln8Z9P1bbVOULcDY3s&s=ts7BF1GZzWJQBG0ag_8JpPvVQmx8Z2dMebv8M5GAvNg&e= ? We might go further than simply managing UAC with projects, we could also give the ability to remove all the resources associated to a project via the UI, for example.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_portainer_portainer_issues_2190-23issuecomment-2D414352353&d=DwMCaQ&c=euGZstcaTDllvimEN8b7jXrwqOf-v5A_CdpgnVfiiMM&r=0fx0h4vB56iTLpw2McH1ZD6TqG_QGpbggVOB-PfMJpM&m=A78sjh5vpYB9-pewAN-vDsbn5Ln8Z9P1bbVOULcDY3s&s=MYdTva9tQW4bmn0mwXelD3L07hHi-sRLCiLnAdkK4YA&e=, or mute the threadhttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_notifications_unsubscribe-2Dauth_AWGrlWQRqCA14XrdInqhrCLqrh36oLP5ks5uStHjgaJpZM4WEMO1&d=DwMCaQ&c=euGZstcaTDllvimEN8b7jXrwqOf-v5A_CdpgnVfiiMM&r=0fx0h4vB56iTLpw2McH1ZD6TqG_QGpbggVOB-PfMJpM&m=A78sjh5vpYB9-pewAN-vDsbn5Ln8Z9P1bbVOULcDY3s&s=WKCCNigy7b1Q5-QD6qTqLdpEqDmj-NRYfQAOL-740xo&e=.

Link to the resource pool issue: https://github.com/portainer/portainer/issues/1664


isort not sorting imports

Describe the bug

@CBROWN-ONS has noticed differences in sorting of import statements when reviewing my recent PR. Possibly a configuration issue as isort is not responding to non-standard import arrangements.

Completed in #267


dependence  conflict of protobuf

ERROR: pip's dependency resolver does not currently take into account all the packages that are installed. This behaviour is the source of the following dependency conflicts.
google-api-core 2.11.1 requires protobuf!=3.20.0,!=3.20.1,!=4.21.0,!=4.21.1,!=4.21.2,!=4.21.3,!=4.21.4,!=4.21.5,<5.0.0.dev0,>=3.19.5, but you have protobuf 3.20.0 which is incompatible.
google-cloud-bigquery 3.10.0 requires protobuf!=3.20.0,!=3.20.1,!=4.21.0,!=4.21.1,!=4.21.2,!=4.21.3,!=4.21.4,!=4.21.5,<5.0.0dev,>=3.19.5, but you have protobuf 3.20.0 which is incompatible.
google-cloud-bigquery-connection 1.12.1 requires protobuf!=3.20.0,!=3.20.1,!=4.21.0,!=4.21.1,!=4.21.2,!=4.21.3,!=4.21.4,!=4.21.5,<5.0.0dev,>=3.19.5, but you have protobuf 3.20.0 which is incompatible.
google-cloud-bigquery-storage 2.22.0 requires protobuf!=3.20.0,!=3.20.1,!=4.21.0,!=4.21.1,!=4.21.2,!=4.21.3,!=4.21.4,!=4.21.5,<5.0.0dev,>=3.19.5, but you have protobuf 3.20.0 which is incompatible.
google-cloud-datastore 2.15.2 requires protobuf!=3.20.0,!=3.20.1,!=4.21.0,!=4.21.1,!=4.21.2,!=4.21.3,!=4.21.4,!=4.21.5,<5.0.0dev,>=3.19.5, but you have protobuf 3.20.0 which is incompatible.
google-cloud-firestore 2.11.1 requires protobuf!=3.20.0,!=3.20.1,!=4.21.0,!=4.21.1,!=4.21.2,!=4.21.3,!=4.21.4,!=4.21.5,<5.0.0dev,>=3.19.5, but you have protobuf 3.20.0 which is incompatible.
google-cloud-functions 1.13.2 requires protobuf!=3.20.0,!=3.20.1,!=4.21.0,!=4.21.1,!=4.21.2,!=4.21.3,!=4.21.4,!=4.21.5,<5.0.0dev,>=3.19.5, but you have protobuf 3.20.0 which is incompatible.
google-cloud-language 2.9.1 requires protobuf!=3.20.0,!=3.20.1,!=4.21.0,!=4.21.1,!=4.21.2,!=4.21.3,!=4.21.4,!=4.21.5,<5.0.0dev,>=3.19.5, but you have protobuf 3.20.0 which is incompatible.
google-cloud-translate 3.11.3 requires protobuf!=3.20.0,!=3.20.1,!=4.21.0,!=4.21.1,!=4.21.2,!=4.21.3,!=4.21.4,!=4.21.5,<5.0.0dev,>=3.19.5, but you have protobuf 3.20.0 which is incompatible.
googleapis-common-protos 1.60.0 requires protobuf!=3.20.0,!=3.20.1,!=4.21.1,!=4.21.2,!=4.21.3,!=4.21.4,!=4.21.5,<5.0.0.dev0,>=3.19.5, but you have protobuf 3.20.0 which is incompatible.
grpc-google-iam-v1 0.12.6 requires protobuf!=3.20.0,!=3.20.1,!=4.21.1,!=4.21.2,!=4.21.3,!=4.21.4,!=4.21.5,<5.0.0dev,>=3.19.5, but you have protobuf 3.20.0 which is incompatible.
tensorflow 2.12.0 requires protobuf!=4.21.0,!=4.21.1,!=4.21.2,!=4.21.3,!=4.21.4,!=4.21.5,<5.0.0dev,>=3.20.3, but you have protobuf 3.20.0 which is incompatible.
tensorflow-metadata 1.14.0 requires protobuf<4.21,>=3.20.3, but you have protobuf 3.20.0 which is incompatible.
Successfully installed Mako-1.2.4 accelerate-0.22.0 aiofiles-23.2.1 aiolimiter-1.1.0 alembic-1.11.3 autofaiss-2.15.8 bert-score-0.3.13 cbor-1.0.0 cbor2-5.4.6 cmaes-0.10.0 colorama-0.4.6 colorlog-6.7.0 cramjam-2.7.0 datasets-2.14.4 dill-0.3.7 embedding-reader-1.5.1 evaluate-0.4.0 faiss-cpu-1.7.4 fastapi-0.103.0 fastparquet-2023.7.0 ffmpy-0.3.1 fire-0.4.0 gradio-3.41.2 gradio-client-0.5.0 h11-0.14.0 httpcore-0.17.3 httpx-0.24.1 huggingface-hub-0.16.4 ijson-3.2.3 indxr-0.1.4 inscriptis-2.3.2 ir-datasets-0.5.5 krovetzstemmer-0.8 latex2mathml-3.76.0 lz4-4.3.2 mdtex2html-1.2.0 multipipe-0.1.0 multiprocess-0.70.15 oneliner-utils-0.1.2 openai-0.27.10 optuna-3.3.0 orjson-3.9.5 portalocker-2.7.0 prompt2model-0.0.4 protobuf-3.20.0 pyautocorpus-0.1.12 pydub-0.25.1 pyfiglet-0.8.post1 pystemmer-2.0.1 python-multipart-0.0.6 ranx-0.3.16 responses-0.18.0 retriv-0.2.3 sacrebleu-2.3.1 safetensors-0.3.3 semantic-version-2.10.0 sentencepiece-0.1.99 starlette-0.27.0 tevatron-0.1.0 tiktoken-0.4.0 tokenizers-0.13.3 transformers-4.32.1 trec-car-tools-2.6 unidecode-1.3.6 unlzw3-0.2.2 uvicorn-0.23.2 warc3-wet-0.2.3 warc3-wet-clueweb09-0.2.5 websockets-11.0.3 xxhash-3.3.0 zlib-state-0.1.5
WARNING: The following packages were previously imported in this runtime:
[google]
You must restart the runtime in order to use newly installed versions.

Thanks for reporting this! A few comments:

Most importantly: this should not be a blocking error. Please try to just continue using prompt2model and it should work.
This pinned dependency was introduced due to an issue with Hugging Face models that required protobuf version 3.20.0. It might be fixed though, so we can experiment with unpinning the version: https://github.com/huggingface/transformers/pull/24599

Fixed by #372


Organize Classes into sensible Packages

The code needs to be organized better.
Break it up into sensible packages.  Maybe:

com.manheim.pipelines.terraform.commands

TerraformInitCommand
TerraformApplyCommand

com.manheim.pipelines.terraform.stages

TerraformValidateStage
TerraformEnvironmentStage

com.manheim.pipelines.terraform.plugins

AnsiColorPlugin
CrqPlugin

This seems a little more hairy than initially thought.

Users (team) will now have to explicitly import terraform stages in their Jenkinsfile.  Not terrible, but it's one more line of boilerplate code that's not currently there.  Eg:

@Library('terraform-pipeline@v1.4')_
import com.manheim.pipelines.terrraform.stages.* // One more boilerplate line

def qa = new TerraformEnvironment('qa')
...

Customization of any of the commands will now require explicit imports, in order to customize the various plugins/commands/stages.
There's some compilation weirdness happening that I'm not currently devoting time to investigating:
https://vipar-bento.aws-dev.manheim.com/job/infrastructure/job/SetIdDb/job/plan_only/8/console

Consider not putting Stages into a package.  This would remove the boiler-plate import statement.
Plugins and Commands won't be so bad.  Users should avoid importing plugins directly anyhow - that should be done in the Customizations library.


NoSuchFileException during record task

Expected behaviour
Screenshots are recorded without any error
Actual behaviour
the gradle task ./gradlew executeScreenshotTests -Precord is crashing with a NoSuchFileException

Execution failed for task ':libs:lego:executeScreenshotTests'.
java.nio.file.NoSuchFileException: C:\R\project\root\libs\lego\screenshots\screenshots-default\com.company.android.ui.components.screenshot.JustAtest_theActivityIsShownProperly.png

Steps to reproduce
execute gradle command
Version of the library
0.2.0
Notes
After checking the folder, the file is not there, but I figured out that there is another folder called "screenshots-default" inside the "screenshots-default" which actually includes the file. So the correct to the file would be C:\R\project\root\libs\lego\screenshots\screenshots-default\screenshots-default\com.company.android.ui.components.screenshot.JustAtest_theActivityIsShownProperly.png

Hi @Fishfield this issue could be related with your shot configuration inside your build.gradle. When you configure shot as follows:
shot {
    appId = 'YOUR_APPLICATION_ID'
}

The appId value is used to search your screenshots and maybe there is something wrong with your configuration 😃  Could you share your build configuration?

Hey @pedrovgs sorry for the late response, but I only have time once every 2 months to work on stuff which is not related to our daily business in the company. I attached the build gradle so you can have a look at it.
build_gradle.txt
It seems if I add the configuration for the facebook lib:
screenshots { 	screenshotTestPackage "com.runtastic.android.ui.components.screenshot" }
I get the error. If I don't add this line, I get a different one:
com.android.builder.testing.ConnectedDevice > No tests found.[Pixel - 8.0.0] FAILED  No tests found. This usually means that your test classes are not in the form that your test runner expects (e.g. don't inherit from TestCase or lack @Test annotations). :libs:lego:connectedDebugAndroidTest FAILED
Here is the test test.txt
So do you have any glue, where this weird package is coming from (com.android.builder.testing)? What does the appId actually mean, is it the package where the tests are located at?

Hi @Fishfield the error you are facing seems could be derived from different errors:

The instrumentation test runner is not properly configured.
The tests you've written are not inside the androidTests folder where the instrumentations should be placed.
Your app has configured different flavors but you are not configured shot properly using indicating the flavor you use to run your tests:

  shot {
    appId = 'YOUR_APPLICATION_ID'
    instrumentationTestTask = 'connected<FlavorName><BuildTypeName>AndroidTest'
    packageTestApkTask = 'package<FlavorName><BuildTypeName>AndroidTest'
  }

I've seen you've configured the original plugin and the error is now different and the error is different now so I guess it's related to your project configuration.
The error com.android.builder.testing is related to the Android Gradle plugin trying to execute your instrumentation tests using ADB.
If you could create a simple repository reproducing the error that could help us to reproduce and fix the issue. We are using this plugin in several projects and we can't reproduce this issue. Here you have a repository using this plugin

@Fishfield did my previous comment help you to fix the issue you were facing?

I may have a workaround:
-delete the app->build->reports->shot and app->screenshots folders.
-In Android Studio do file->invalidate caches and restart.
I was getting the same error when the task was looking for metadata.xml inside screenshots-default folder. Somehow things were being saved to screenshots-default/screenshots-default so that is where metadata.xml was. I had several successful runs with no problems prior to encountering this.


Replace highlightjs with prism

Hi @robert-henke,
I used this as an opportunity to remove highlightjs and shorten the markdown descriptions a bit.
Thank you for this great contribution and idea.
Give me/us another week to think about the mermaid dependency. It increases the size from 1.5MB to 3MB (due to prism) and then to 6MB when mermaid is added as well.

Hi @timonback,
very nice, that you could replace hightlightjs that fast! I just started the kafka example with your changes and it seems like everything is working so far, except for the headers section. Maybe there are some more adjustments needed:

I can absolutely understand your hesitation regarding mermaid. Take your time to decide whether the benefits of a better visual documentation with mermaid justifies the increase in size for the ui.

Good catch, I simplified the json-component.


[BUG] null values in body are not serialised into json

System info

Playwright Version: [v1.36.0]
.NET 7.0
Operating System: [Windows 10]
Browser: [All, Chromium, Firefox, WebKit]

I am trying to send a post request with the following body
{     "projectId": null,     "companyCode": null }
In my code I am doing the following:
data.Add("projectId", null!);
data.Add("companyCode", null!);

_context.Response!.Value = await _context.Page!.APIRequest.PostAsync($"{TestContext.Parameters["BaseUrlApi"]!}{url}", new APIRequestContextOptions()
                    {
                        Headers = Header(headerType),
                        DataObject = data
                    });

Unfortunatelly those above are not sent as null, and are excluded from the request.
When trying to pass a class object as the request to be sent in Playwright, nulls are excluded from the request.

I tried the following which was working for me, what do you do differently?
using Microsoft.Playwright;

using var playwright = await Playwright.CreateAsync();
await using var browser = await playwright.Chromium.LaunchAsync();
var page = await browser.NewPageAsync();

var myDict = new Dictionary<string, string?>();
myDict.Add("foo", null);

var response = await page.APIRequest.PostAsync("https://httpbin.org/post", new () {
    DataObject = myDict,
});
Console.WriteLine(await response.TextAsync());

Make sure to use v1.36, since we had some related fixes in previous versions if I remember correctly.

Thanks for the quick help @mxschmitt, you are totally right, there was a bug in our application, which kind of mislead me.
I checked the trace viewer and saw the expected response body, closing the ticket.


ReviewZoneWidget makes duplicate calls to show() + hide()

Does this issue occur when all extensions are disabled?: Yes

VS Code Version: 1.76.0
OS Version: macOS

Steps to Reproduce:

Click on a line gutter icon for an expanded comment thread.
ReviewZoneWidget.toggleExpand() sets the comment thread's collapsibleState to Collapsed: https://github.com/microsoft/vscode/blob/e282742d2be62465bf1dfd84c01e60004747737b/src/vs/workbench/contrib/comments/browser/commentThreadZoneWidget.ts#L278
This causes the widget's listener on the thread's collapsible state to fire synchronously and call hide(): https://github.com/microsoft/vscode/blob/e282742d2be62465bf1dfd84c01e60004747737b/src/vs/workbench/contrib/comments/browser/commentThreadZoneWidget.ts#L377
toggleExpand() follows this up with an explicit, duplicate call to hide(): https://github.com/microsoft/vscode/blob/e282742d2be62465bf1dfd84c01e60004747737b/src/vs/workbench/contrib/comments/browser/commentThreadZoneWidget.ts#L279

For the other direction, the problem is the same and show() is called twice with identical parameters on every change.
I am not sure if these duplicate calls cause unnecessary rendering or similar elsewhere in the stack, but they seem redundant. I think relying on the listener for onDidChangeCollapsibleState is probably sufficient, but I am not that familiar enough with the code base to have a confident opinion here.

Thanks for creating this issue! It looks like you may be using an old version of VS Code, the latest stable release is 1.75.1. Please try upgrading to the latest version and checking whether this issue remains.
Happy Coding!

Thanks triage bot, but I wish you handled "freshly built from HEAD" a bit better!

Looking a bit further, it seems to be the case that ZoneWidget.show() through ZoneWidget._showImp() does indeed discard and recreate the overlay widget unconditionally, causing ReviewZoneWidget._doLayout() to run, which calls CommentThreadWidget.layout(). However ReviewZoneWidget.show() also explicitly calls its own _refresh() method which makes another call to CommentThreadWidget.layout(), so in total for every click to expand a comment thread in the line gutter, the corresponding CommentThreadWidget runs through four layout() passes.

Hm, it actually seems a bit worse still regarding the number of calls to CommentThreadWidget.layout() (although a few of them return pretty instantly): ReviewZoneWidget.show() also sets collapsibleState, so that listener fires again; within ReviewZoneWidget it's a no-op, but it causes another layout() call, so for every call to ReviewZoneWidget.show(), CommentThreadWidget.layout() is called four times, and for every click on the line gutter icon to show the thread, it's called eight times; actually nine, but I haven't looked yet where that last call comes from.
This is not a performance problem right now but it seems like a spot with potential to multiply any future slowdown on the layout path.

For the slightly excessive firing of onDidChangeCollapsibleState I wonder if the right approach would be to suppress events currently fired for setting collapsibleState to the value it already has: https://github.com/microsoft/vscode/blob/e282742d2be62465bf1dfd84c01e60004747737b/src/vs/workbench/api/browser/mainThreadComments.ts#L113


Large slices slow to display

surprisingly many issues here!  in the course of tracking this down:

ki Tree traversal sped up by 10x by using non-recursive methods
ki: better documented *Fast ways of adding elements, and cleaned that code up significantly (wasn't an issue here as we were using SetChild which is VERY fast.. though there were still a few minor things)
copying icons was very slow -- now have hand-written 10x faster copying of gi nodes

more details here:
https://docs.google.com/spreadsheets/d/1WWorjrVao6sLRuwKguyRnnuY51DxsZOpokZHzGtmnbE/edit?usp=sharing
but wait, there's more!  still major slowness present and will keep tracking it down..

Slice display much better and overall everything feels “snappier”, but yes still some slowness in slice display.

John

On May 18, 2019, at 1:37 AM, rcoreilly <notifications<EMAIL_ADDRESS>wrote:
surprisingly many issues here! in the course of tracking this down:

ki Tree traversal sped up by 10x by using non-recursive methods
ki: better documented *Fast ways of adding elements, and cleaned that code up significantly (wasn't an issue here as we were using SetChild which is VERY fast.. though there were still a few minor things)
copying icons was very slow -- now have hand-written 10x faster copying of gi nodes

more details here:
https://docs.google.com/spreadsheets/d/1WWorjrVao6sLRuwKguyRnnuY51DxsZOpokZHzGtmnbE/edit?usp=sharing
but wait, there's more! still major slowness present and will keep tracking it down..
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://github.com/goki/gi/issues/275?email_source=notifications&email_token=AFKQXQY77VWFFLGV6NWZXLTPV6W2TA5CNFSM4HMJFRN2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODVWJSJI#issuecomment-493656357, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AFKQXQZ3CRYN3TQEX4LSHUDPV6W2TANCNFSM4HMJFRNQ.

Much of the rest of the time was expensive styling operations redundantly applied repeatedly on each element -- now caching that using a Template name that views set, and which widgets propagate appropriately to their sub-parts (otherwise it has limited benefits).  really are a ton of parts by the time it all gets rendered out, so even small ops repeated so many times really adds up.
opening time on the gi/examples/views SliceTest button is now reasonable, even for 10k elements in the slice, and rendering speed remains quite good.  now just need to fix the editing speed.

The slice test in the latest "checked in" code has 2880 items and the time to display/scroll is about 4 seconds. My 3640 item slice is 5 seconds so that make sense. My slice of 26496 takes 35 seconds which is a pretty linear result. I don't actually need to look at a slice that large but when we have an etensor viewer I might.

I added precise elapsed time timing and now am down to 1.8 sec for initial render -- added back 2nd full render which gets focus working and ensures dynamic sizing is better, but that 1.8 is comparable.
6 sec for 10k.
even though this has done great things for finding all the major bottlenecks in rendering, it probably does still make sense to add a smarter logic for these things -- it is kinda crazy to be rendering all this stuff instead of just re-using only visible widgets and scrolling those in data space instead of gui space...

Having a window over the data will probably be a pain to implement but it would certainly make it much faster and probably is what needs to be done.

Not slow anymore!!!


Enable managed draining for autoscaling_capacity_providers in ecs cluster

Is your request related to a new offering from AWS?
Amazon recently announced managed instance draining

a new capability that facilitates graceful shutdown of workloads deployed on Amazon Elastic Compute Cloud (Amazon EC2) instances by safely stopping and rescheduling workloads to other, non-terminating instances.

Is this functionality available in the AWS provider for Terraform?

Yes ✅:
Support for this was added to the terraform aws provider in release v5.34.0 and its use is documented here.

Is your request related to a problem? Please describe.
This feature is available by setting the managed_draining property on aws_ecs_capacity_provider but is not exposed in auto_scaling_group_provider
Describe the solution you'd like.
Amend the implementation of how variable "autoscaling_capacity_providers"  gets passed down to this block to propagate the managed_draining setting in the same way as is done for managed_termination_protection. This will need to be gated so that it is only set for aws provider 5.34.0 and above.
Describe alternatives you've considered.

Additional context

Hey there, it sounds like the changes coming up in v6 may address your issue here. Here's the relevant PR: https://github.com/terraform-aws-modules/terraform-aws-ecs/pull/158

Thanks @easterbonbon, was just about to open a pr for that myself as I hadn't spotted that one.


Feature/entropy diagnostic

This PR adds a feature to the model class for calculating and reporting the mathematical entropy function for a model. By default, the calculate routine returns zero. When developing a specific model, users need to override the CalculateEntropy method to define a mathematical entropy function specific to their model.

/gcbrun

/gcbrun

/gcbrun


Misleading test

In test R2RMLTC0002a, you are testing the use of two columns in a IRI. The test case also assumes that datatype conversions are correct (test R2RMLTC0016a). With a mistake there, the test fails even when the IRI generated is correct. Maybe use constants for a predicate and an object to do this test?

There are a couple of other tests that "suffer" from this issue (e.g., R2RMLTC0009d). It would be good to go over each of these mappings and ensure that the test is minimal enough.

There are a couple of other tests that "suffer" from this issue (e.g., R2RMLTC0009d). It would be good to go over each of these mappings and ensure that the test is minimal enough.

100% agree

As we have recently discussed, I would suggest to not modify this test-case but taking into account these issues during the creation of the atomic test-cases.  What do you think? @chrdebru

I agree. This one should remain. But a good exercise would be to revise the R2RML cases and render those more atomic. We all know R2RML, and having those foundations right from the start will help us for the other test cases. What do you think?

Totally agree, I and @jatoledo will prepare an initial analysis of the R2RML test-cases and give an overview during the next meeting

We will start in this spreadsheet: https://docs.google.com/spreadsheets/d/1zVHwSpzzhLWZCX5T75HP-7EW7DLnNKN7mJYsiX9s8yg/edit#gid=990981462

I agree. This one should remain. But a good exercise would be to revise the R2RML cases and render those more atomic. We all know R2RML, and having those foundations right from the start will help us for the other test cases. What do you think?

What about 'R2RML Test Cases 1.1' or 'Revised R2RML Test Cases'?
This way we keep the original test cases as they are now and publish the revised set against which we test.

yes, I liked the idea!


Tower Of Hanoi using Python

🚀 Feature
I want to add the implementation for Tower Of Hanoi  algorithm in PYTHON as it has not been added in python language according to the issue #793  . Please assign this issue to me[GSSOC'21]
Have you read the Contributing Guidelines on Pull Requests?
(Write your answer here.)
Yes
Motivation
(Please outline the motivation for the proposal.)
Not yet added in Python.

/assign


Candidates taken to Sign In page when already signed in

Describe the bug
Candidates with incomplete applications receive an automated reminder email via Notify, 1 week prior to the application deadline. The email contains a link to log back in to the platform, however, when you click on the link and you are already logged in, you are taken to the Sign In page (see image below.)

To Reproduce
Steps to reproduce the behaviour:

Click the link included in the Notify email
Note that you are on the Sign In page but you are already signed in

Expected behaviour
When clicking the link, candidates should be taken to the Sign In page only if they are not signed in. However, if they are signed in, they should be taken to the Applications page.

Hey team! Please add your planning poker estimate with Zenhub @drieJAC @HalcyonJAC @tomlovesgithub @warrensearle


Newtonsoft.Json [8.0.3, )' does not exist in project

Although Newtonsoft.Json <IP_ADDRESS> is installed I get this error when try to install Push Notification
Here is what I get:
Attempting to gather dependency information for package 'Xam.Plugin.PushNotification.1.2.2' with respect to project 'App.Main', targeting '.NETPortable,Version=v4.5,Profile=Profile78'
Attempting to resolve dependencies for package 'Xam.Plugin.PushNotification.1.2.2' with DependencyBehavior 'Lowest'
Resolving actions to install package 'Xam.Plugin.PushNotification.1.2.2'
Resolved actions to install package 'Xam.Plugin.PushNotification.1.2.2'
For adding package 'Xam.Plugin.PushNotification.1.2.2' to project 'App.Main' that targets 'portable45-net45+win8+wp8'.
For adding package 'Xam.Plugin.PushNotification.1.2.2' to project 'App.Main' that targets 'portable45-net45+win8+wp8'.
Adding package 'Xam.Plugin.PushNotification.1.2.2' to folder '/Users/samir/Documents/projects/xamarin/packages'
Added package 'Xam.Plugin.PushNotification.1.2.2' to folder '/Users/samir/Documents/projects/xamarin/packages'
Removed reference 'PushNotification.Plugin.Abstractions' from project 'App.Main'.
Added reference 'PushNotification.Plugin.Abstractions' to project 'App.Main'.
Removed reference 'PushNotification.Plugin' from project 'App.Main'.
Added reference 'PushNotification.Plugin' to project 'App.Main'.
Install failed. Rolling back...
Package 'Xam.Plugin.PushNotification.1.2.2 : Newtonsoft.Json [8.0.3, )' does not exist in project 'App.Main'
Removing package 'Xam.Plugin.PushNotification.1.2.2 : Newtonsoft.Json [8.0.3, )' from folder '/Users/samir/Documents/projects/xamarin/packages'
Removed folder '/Users/samir/Documents/projects/xamarin/packages/Xam.Plugin.PushNotification.1.2.2/content/portable-net45+wp8+wpa81+win8+MonoAndroid10+MonoTouch10+Xamarin.iOS10/Helpers'.
Removed folder '/Users/samir/Documents/projects/xamarin/packages/Xam.Plugin.PushNotification.1.2.2/lib/portable-net45+wp8+wpa81+win8+MonoAndroid10+MonoTouch10+Xamarin.iOS10+UAP10'.
Removed folder '/Users/samir/Documents/projects/xamarin/packages/Xam.Plugin.PushNotification.1.2.2/content/portable-net45+wp8+wpa81+win8+MonoAndroid10+MonoTouch10+Xamarin.iOS10'.
Removed folder '/Users/samir/Documents/projects/xamarin/packages/Xam.Plugin.PushNotification.1.2.2/content/MonoAndroid10'.
Removed folder '/Users/samir/Documents/projects/xamarin/packages/Xam.Plugin.PushNotification.1.2.2/content/Xamarin.iOS10'.
Removed folder '/Users/samir/Documents/projects/xamarin/packages/Xam.Plugin.PushNotification.1.2.2/content/MonoTouch10'.
Removed folder '/Users/samir/Documents/projects/xamarin/packages/Xam.Plugin.PushNotification.1.2.2/lib/MonoAndroid10'.
Removed folder '/Users/samir/Documents/projects/xamarin/packages/Xam.Plugin.PushNotification.1.2.2/lib/Xamarin.iOS10'.
Removed folder '/Users/samir/Documents/projects/xamarin/packages/Xam.Plugin.PushNotification.1.2.2/lib/MonoTouch10'.
Removed folder '/Users/samir/Documents/projects/xamarin/packages/Xam.Plugin.PushNotification.1.2.2/lib/UAP10'.
Removed folder '/Users/samir/Documents/projects/xamarin/packages/Xam.Plugin.PushNotification.1.2.2/lib/wpa81'.
Removed folder '/Users/samir/Documents/projects/xamarin/packages/Xam.Plugin.PushNotification.1.2.2/lib/win8'.
Removed folder '/Users/samir/Documents/projects/xamarin/packages/Xam.Plugin.PushNotification.1.2.2/content'.
Removed folder '/Users/samir/Documents/projects/xamarin/packages/Xam.Plugin.PushNotification.1.2.2/lib'.
Removed file 'Xam.Plugin.PushNotification.1.2.2.nupkg' from folder '/Users/samir/Documents/projects/xamarin/packages/Xam.Plugin.PushNotification.1.2.2'.
Removed folder '/Users/samir/Documents/projects/xamarin/packages/Xam.Plugin.PushNotification.1.2.2'.
Removed package 'Xam.Plugin.PushNotification.1.2.2 : Newtonsoft.Json [8.0.3, )' from folder '/Users/samir/Documents/projects/xamarin/packages'
Could not load file or assembly or one of its dependencies.

Any idea?

What platform are you tesitng on?

I am on Mac
On 11 Jul 2016 17:49, "Rendy Del Rosario"<EMAIL_ADDRESS>wrote:

What platform are you tesitng on?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/rdelrosario/xamarin-plugins/issues/70#issuecomment-231757297,
or mute the thread
https://github.com/notifications/unsubscribe/ABAxJRfI7m2Tu6DSk6I5nl3hb5zf-Qsxks5qUlfggaJpZM4JI1wN
.

But I mean the project is iOS, Android or UWP? were you are installing the package?

Ah, its Android

Still getting this issue?

After lots of errors, we decided to build the app natively..


Can't install using npm

node -v v0.4.12
npm -v 1.0.27
Command:
npm install zookeper
Results in:
https://gist.github.com/1370181
Somehow it doesn't download the zookeeper.

Here's your problem:
/bin/sh: [[: not found
/bin/sh: [[: not found
Normally, that program is located at /bin/[ ....
The build script must use it in a test like:
if [ -f foo.js ]; then
echo true;
else
echo false;
fi

Following what you wrote, I couldn't build this using node-waf configure build but I can.

hmm. ok, but you should still debug your environment a bit.  Since you have a narrow pass/fail repro, this should be easy.  It seems unlikely that "/bin" wouldn't be in your PATH variable, but add a line in the wscript to print $PATH just to be sure.  what else?  you should also verify which shell is running in each environment (npm vs node-waf).  NPM just runs node-waf, so there MUST be some sort of environmental difference that is causing problems for you.  Try just dumping "env" in each environment to compare....  dunno.  Good luck and good (bug) hunting.

p.s., I wrote that as if you needed help figuring out how to debug.  Please forgive me if I come off as patronizing.  Poking around your commits, you clearly know what you are doing... :).

Finally I found out what is wrong, the version in npm is outdated with what is in master branch.

The npm version is outdated, it tries to download zookeeper from http://apache.mirrors.tds.net/zookeeper/zookeeper-3.4.0/zookeeper-3.4.0.tar.gz which gives 404.

I updated it.

tested install from npm, and works for me.

For posterity, a snap of "npm info zookeeper":
{ name: 'zookeeper',
description: 'apache zookeeper client (zookeeper async API >= 3.4.0)',
'dist-tags': { latest: '3.4.1' },
versions:
[ '3.3.2-1',
'3.3.2-2',
'3.3.2-3',
'3.3.2-4',
'3.3.3-0',
'3.4.1',
'4.1.0' ],
maintainers:
[ 'woodya<EMAIL_ADDRESS>'ddopson<EMAIL_ADDRESS>],
time:
{ '3.3.2-1': '2011-01-06T09:21:28.100Z',
'3.3.2-2': '2011-01-10T01:31:17.466Z',
'3.3.2-3': '2011-02-20T18:54:57.806Z',
'3.3.2-4': '2011-04-11T03:47:10.824Z',
'3.3.3-0': '2011-04-11T04:19:38.843Z',
'4.1.0': '2011-12-16T21:18:28.801Z',
'3.4.1': '2012-01-06T22:51:12.830Z' },
author: 'Yuri Finkelstein<EMAIL_ADDRESS>repository:
{ type: 'git',
url: 'git://github.com/yfinkelstein/node-zookeeper.git' },
notes: 'support for Node v0.6.x',
version: '3.4.1',
contributors:
[ 'Yuri Finkelstein<EMAIL_ADDRESS>'Woody Anderson<EMAIL_ADDRESS>'Dave Dopson<EMAIL_ADDRESS>],
keywords: [ 'apache', 'zookeeper', 'client' ],
dependencies: { webworker: '>=0.8.2', underscore: '*' },
main: 'lib/zookeeper',
'directories.lib': 'build/default/',
scripts:
{ build: 'node-waf configure build',
test: 'node-waf test',
doc: 'node-waf doc',
preinstall: 'node-waf clean || (exit 0); node-waf configure build' },
engines: { node: '>= 0.3.0' },
devDependencies: {},
dist:
{ shasum: 'd61467c82f20a9df254236c11e8c462a0acdfc6d',
tarball: 'http://registry.npmjs.org/zookeeper/-/zookeeper-3.4.1.tgz' },
directories: {} }


CLI command issues

When I try to use the calamr aligncorp liu-example -f txt -d example command from the examples I get the following error:
calamr: error: action 'aligncorp' expects 1 argument(s) but got 2: liu-example, example

The CLI's -d changed to -o and I forgot to update the docs on GitHub, which is now fixed.  Thank you for noticing.


Sub application routes being picked up in Sveltekit

Describe the bug
I have a sveltekit app that loads sub applications that are pure web components (built in Angular). The Angular WC has it's own routing. The WC loads fine and Angular WC app works fine. However, when it's routes change, it updates the browser URL. This cases a problem on reload of page. The internal sub route from Angular route is not know to the parent Sveletkit app.
How can I prevent these Angular sub routes from updating browser URL. Note: I just moved the parent app from a Svelte app to Sveltekit app recently. Prior to this move, the WC sub routing from Angular app did not surface in browser URL, so it's not an Angular app issue.
Reproduction
An example sveltekit app, with a test Web Component loaded
https://github.com/malindsay/sveltekit-loading-wc/
Logs
No response
System Info
Run sample app to see details

Severity
blocking all usage of svelte

We need to know what options in sveltekit can stop this behavior or how to swap out default router. As mentioned, this was working fine with just using Svelte (as SPA), which we were using the "@roxi/routify" router.


SlackApiError cannot be unpickled

SlackApiError raises an error when trying to unpickle it.
This is particularly annoying in a Celery task since another bug in celery will cause the whole worker node to fail.
The Slack SDK version
2.9.4
Python runtime version
3.11.0
OS info
ProductName:		macOS
ProductVersion:		13.0
BuildVersion:		22A380
Darwin Kernel Version 22.1.0: Sun Oct  9 20:15:09 PDT 2022; root:xnu-8792.41.9~2/RELEASE_ARM64_T6000
Steps to reproduce:
import pickle
from slack.errors import SlackApiError

e = SlackApiError("Internal server error", "<response>")

dumped = pickle.dumps(e)
pickle.loads(dumped)

Expected result:
No error.
Actual result:
Traceback (most recent call last):
  File "/private/tmp/pickle_exc/bug.py", line 7, in <module>
    pickle.loads(dumped)
TypeError: SlackApiError.__init__() missing 1 required positional argument: 'response'

Solution
The SlackApiError could be implemented in such a way that the constructor accepts only the message, and the response defaults to None. Then the string representation can be delegated to __str__:
class SlackApiError(Exception):

    def __init__(self, message, response=None):
        super().__init__(message)
        self.response = response

    def __str__(self):
        return f"{self.args[0]}\nThe server responded with: {self.response}"

Hi @youtux, thanks for writing in!
First off, I would suggest catching the exception in your async code and generate some object or your own exception, which is serializable instead. The response object has its state for pagination (more specifically, reference to WebClient instance). So, we don't recommend trying to enable the object pickle-ready to avoid potential misbehavior.
Also, even if we decide to enhance this SDK for this use case in the future, the change won't come to slackclient v2. The reason is that, unfortunately, we are no longer actively working on the v2 SDK (except critical security fixes). It'd be appreciated if you could understand this.

First off, I would suggest catching the exception in your async code and generate some object or your own exception, which is serializable instead. The response object has its state for pagination (more specifically, reference to WebClient instance). So, we don't recommend trying to enable the object pickle-ready to avoid potential misbehavior.

I understand that, still it would greatly help if this exception was picklable, even if that means to lose pagination (you can remove the reference to the WebClient instance by overriding SlackApiError.__reduce_ex__) so that users that don't need to use pagination can have this behaviour fixed.

Also, even if we decide to enhance this SDK for this use case in the future, the change won't come to slackclient v2. The reason is that, unfortunately, we are no longer actively working on the v2 SDK (except critical security fixes). It'd be appreciated if you could understand this.

That wouldn't be a problem, I can upgrade to v3.

First off, I would suggest catching the exception in your async code and generate some object or your own exception, which is serializable instead. The response object has its state for pagination (more specifically, reference to WebClient instance). So, we don't recommend trying to enable the object pickle-ready to avoid potential misbehavior.

I understand that, still it would greatly help if this exception was picklable, even if that means to lose pagination (you can remove the reference to the WebClient instance by overriding SlackApiError.__reduce_ex__) so that users that don't need to use pagination can have this behaviour fixed.

Also, even if we decide to enhance this SDK for this use case in the future, the change won't come to slackclient v2. The reason is that, unfortunately, we are no longer actively working on the v2 SDK (except critical security fixes). It'd be appreciated if you could understand this.

That wouldn't be a problem, I can upgrade to v3.

I can open a PR if you agree.

Still an issue

Hi @youtux, I've excluded this issue from the auto-triage process to repeat the same one month later. With that being said, we won't make the changes that you suggested at least in the short term (for the reason I mentioned above, plus due to your priorities as the whole team -- we're focusing on the next-generation platform project now). As I mentioned in my first rely, please consider a different approach for your use case.


FIAM: Remove extraneous foo constant in Swift preview helpers

Removed an unintentional constant named "foo" from the Firebase In-App Messaging Swift API. This constant is not of use to developers (simply containing UIColor.black) and was only added accidentally. Closes #9998.

Wouldn't hurt to have a changelog just in case someone was accidentally using it.

Good idea. I could see myself using it as a joke or thinking it's an Easter egg.


System cannot find file specified

Hello!
I was trying to implement the code as shown below.
from aeropy.xfoil_module import find_coefficients
find_coefficients(airfoil='naca0012',alpha=12.)
Whenever I try using any of the modules I get the error [WinError 2] The system cannot find the file specified. Could you explain as to what the problem is?

Hello!Has your problem been solved? I have the same problem as you. Can you teach me how to solve it?


Error: Dynamic require of "stylelint" is not supported

pnpm create vite my-vue-app --template vue-ts
pnpm install stylelint@^14 -D
pnpm install vite-plugin-stylelint -D
plugins: [vue(), StylelintPlugin()]
pnpm run dev
details:

I'm not sure if it's a problem with upgrading vite to 3.0.0

I have updated 5 projects to vite 3 but haven't seen such error. I need some time to research.

Removing type: "module" in package.json should be a solution.

This package is bundled by tsup (esbuild underhood) and targets at node12. Please track https://github.com/evanw/esbuild/pull/2067, https://github.com/evanw/esbuild/issues/1921 and https://github.com/evanw/esbuild/issues/2111.
Maybe change to unbuild in the future. Maybe just in some days.

I understand, thank you for your support

Please change to unbuild!!!

I don't have much time to change to unbuild recently. PR welcome.

type: "module" support should be fixed in v3.0.3. Please have a try.
I don't have much time to change to unbuild recently. PR welcome.


 Are you using console.log or process.stdout.write?

@eric-love The react-native extension doesn't log to the output pane, if this is what you are struggling with. In fact, react-native itself doesn't do this either.
But you can simply start a new integrated terminal and type react-native logs to see the console output of the simulator.

Please create an issue against the react-native extension.


[SONARMSBRU-212] Added installer caching tests

LGTM

FYI the AppyVeyor builds that use MSBuild 12 are failing because of the use of "nameof" in one of the tests. I removed this in a later checkin.

LGTMT (slightly late)


feat-range-parser

Adds content range header parser and relevant getters to get the content range start, content range end, content range size and content range unit

Would you like to add support for the range header as well? does it have the same syntax?

It has totally different format and I'll add it later in separate PR

I can merge this and release a version once we have the new assertions.


Remove unused npm dependencies

It looks like the resolve and builtin-modules dependencies aren't actually used anywhere, so stop depending on them.
The motivation for this change is that the dependency on resolve causes errors to be logged in logs during plugin discovery, because the package includes tests that have malformed package.json files. If we don't actually need the dependency it'd be nice to remove it so those errors are no longer logged (so users don't ask us about them).
Also remove the builtin-modules dependency while cleaning this up, since it doesn't appear to be used either AFAICT.
Similar to https://github.com/pulumi/pulumi-aws/pull/3238
Reference: https://github.com/pulumi/pulumi/issues/17578

What's going on with the failing waf test? Something we need to clean up in a test account?
=== NAME  TestAccWAFRuleGroup_basic
    rule_group_test.go:34: Step 1/2 error: Error running apply: exit status 1

        Error: creating WAF Rule Group (tfaccze0ep): operation error WAF: CreateRuleGroup, https response error StatusCode: 400, RequestID: ac6aaf1f-be43-45b9-8044-589560f4e5b7, WAFLimitsExceededException: Operation would result in exceeding resource limits.

          with aws_waf_rule_group.test,
          on terraform_plugin_test.tf line 17, in resource "aws_waf_rule_group" "test":
          17: resource "aws_waf_rule_group" "test" {

--- FAIL: TestAccWAFRuleGroup_basic (15.67s)

Yeah I think so. Having a quick look.

=== NAME  TestAccWAFRuleGroup_changeNameForceNew
    rule_group_test.go:75: Step 1/3 error: Error running apply: exit status 1

        Error: creating WAF Rule Group (tfaccyzotq): operation error WAF: CreateRuleGroup, https response error StatusCode: 400, RequestID: fcb7db05-54ed-4ab1-8a3b-cecdb02574fb, WAFLimitsExceededException: Operation would result in exceeding resource limits.

          with aws_waf_rule_group.test,
          on terraform_plugin_test.tf line 17, in resource "aws_waf_rule_group" "test":
          17: resource "aws_waf_rule_group" "test" {

ForceNew may be trying to create two of these. Scrolling back a little I think our intent with this test was to smoke-test upstream post-patching with their own tests, somehow we selected waf instead of the newer wafv2 module for this purpose. Rather than raising our account waf quotas we can disable this test or switch to wafv2.

https://github.com/pulumi/pulumi-aws/pull/5001 I'll land that first and rebase this to get it in.

Thank you for getting this in!


Pushing a page inside super-tabs causes it to stay within the tabs

Greetings,
I have a situation where I want to push the navigation of specific pages to take full width and height of the entire application. (This is for some specific pages only).
Currently when I push any page on top of the stack that is inside of super-tabs, it will stay inside of the super tabs making the page still swipeable to other super-tabs. I would like to have specific pages to be pushed to a fullscreen layout rather then having it stay inside the super-tabs. Is there any way I can accomplish this?
Suppose for example that I have a page with google maps opening from the navigation stack. Whenever this page is inside of super-tabs, it would make it impossible to use swipe gestures on the google maps page because it would swipe to the next super-tabs tab.
Here is an example of what I mean:

I would like this "kaart" page to be pushed on top of the root page containing the super-tabs, so that swiping won't be an issue...
Any idea how I could accomplish this without losing the navigation stack? Like pop?
EDIT: I fixed it by using: this.app.getRootNavs()[0].push this issue can be closed. It now works as intended...
Example:

Are you able to use the "swipeBack" gesture?

@ihadeed  how to ?? use rootNavCtrl

@senturkzuhtu11 try this this.appCtrl.getRootNav().push(page);

How do you solve this in Ionic 4?


Make human_review available in ask_ml

This is counterintuitive, having a function named ask_ml have a parameter called human_review. This might tell us we may need to review the intended mental model for sdk users

Chatted more with Sunil, I'll leave this PR open in case have strong reason to make this change to unblock key users. But this process feels like it adds a level of complexity that undermines the goal of having simple ask_* methods. While this change exposes new functionality to ask_ml, this doesn't add novel functionality to the sdk as equivalent behavior can be obtained with other functions in the SDK


Ichimoku with pandas-ta

Hi,
Who can help me? The Ichimoku indicator is one of my favorites for market analysis. I found excellent Pandas TA - A Technical Analysis Library in Python 3, but there is a problem with the Ichimoku indicator , in the formula. For Tenkan Sen and Kijun Sen the values used are "High", "Low", but in this Library the formula includes the "Close" (which is used only in Chikou Span, one of the technical lines of the Ichimoku), therefore the values do not match with the values of the graphics. Who knows how to modify this indicator inside the library? or any suggestions... Thanks
ichimoku = ta.ichimoku(df['high'], df['low'], df['close'])
df1 = pd.concat([df, ichimoku[0],ichimoku[1]], axis=1)

Hello @tebrich,
Unfortunately, saying it is incorrect without justification is insufficient to look into the issue. You have provided no numerical data (preferably as a csv), your ohlcv data with ichimoku applied on that data, so there is no way to confirm that your claim is correct. Please provide said csv so it can be test against Pandas TA.
Kind Regards,
KJ


Added <^...> start states to exclude the given staties. Cannot be nested

I didn't see any tests for start states.
I didn't change the documentation, since I don't know if you want me to.

The flex documentation on nested start condition scopes is very sparse (only stating that "Start condition scopes may be nested."). So I spent time reverse engineering nested scopes in flex, which differs in RE/flex somewhat. This should not be the case as RE/flex should be backward compatible to flex. Let me first work on fixing that problem, which means that get_starts() will change and should take as argument the current scope of start conditions to create a new scope that is returned.


Kafka conf changed to more generic, added examples and docker compose…

Description
doge_datagen:

Add configuration dictionary as a variable for Kafka Sink Faktory objects (KafkaSinkFactory,  KafkaAvroSinkFactory). This way it would be more general

examples:

All examples was changed accordingly
Docker folder was added with local setup for Kafka, MySQL and akhq

@datasqr I have fixed build process. It seems support for requirements.txt was dropped from pyenv. https://github.com/getindata/doge-datagen/pull/21
Could I ask you to rebase on top of latest develop?

Looks good, there is small typo.
Could I also ask you to remove requirements.txt? Repository is using Pipfile for dependency tracking.
Please also modify CHANGELOG.md
If you want you can squash commits your self or I will do it when merging.

Looks good, there is small typo.
Could I also ask you to remove requirements.txt? Repository is using Pipfile for dependency tracking.
Please also modify CHANGELOG.md
If you want you can squash commits your self or I will do it when merging.

@datasqr Hi, please modify CHANGELOG.md and its good to merge.

@datasqr please rebase on latest develop and resolve conflicts.

git pull origin develop
Already up to date.
git rebase develop
Current branch kafkaconf is up to date.

@datasqr you need to checkout your branch before executing git rebase develop.


[I2C/DV] Target Cfg

Added Addr0 Addr1 Cfg
Added Tasks Program Txdata And Read Acqdata
Added Checks Read Acqdata and Task Program Stretch Ctrl
Added Dut Target Intrs Process

@jdonjdon @cindychip are these CI failures related to pushed code or something else?...it isnt clear for me from the details of failure ...can you help me with it

It got rejected by lint bot.
Can you clean up all issue 'bot' found?

@jdonjdon @cindychip are these CI failures related to pushed code or something else?...it isnt clear for me from the details of failure ...can you help me with it

It got rejected by lint bot. Can you clean up all issue 'bot' found?

@jdonjdon I have fixed them already and then i see these errors. They dont point to any issues in files either so i was confused.
Errors relate to Bazel coding style and test software with bazel...what could be these ?

@jdonjdon @cindychip are these CI failures related to pushed code or something else?...it isnt clear for me from the details of failure ...can you help me with it

It got rejected by lint bot. Can you clean up all issue 'bot' found?

@jdonjdon I have fixed them already and then i see these errors. They dont point to any issues in files either so i was confused. Errors relate to Bazel coding style and test software with bazel...what could be these ?

I see this from (https://dev.azure.com/lowrisc/4c50229e-f6cb-4f39-8522-585bb3841438/_apis/build/builds/80515/logs/106) "https://releases.bazel.build/5.1.1/release/bazel-5.1.1-linux-x86_64": x509: certificate has expired or is not yet valid: current time 2022-05-18T09:56:09Z is after 2022-05-18T09:43:13Z 2022-05-18T09:56:09.9276005Z ##[error]Bash exited with code '1'. Let me re-trigger it.

@visbaz looks much better now, I will re-trigger private CI once this is done

@jdonjdon @cindychip are these CI failures related to pushed code or something else?...it isnt clear for me from the details of failure ...can you help me with it

It got rejected by lint bot. Can you clean up all issue 'bot' found?

@jdonjdon I have fixed them already and then i see these errors. They dont point to any issues in files either so i was confused. Errors relate to Bazel coding style and test software with bazel...what could be these ?

I see this from (https://dev.azure.com/lowrisc/4c50229e-f6cb-4f39-8522-585bb3841438/_apis/build/builds/80515/logs/106) "https://releases.bazel.build/5.1.1/release/bazel-5.1.1-linux-x86_64": x509: certificate has expired or is not yet valid: current time 2022-05-18T09:56:09Z is after 2022-05-18T09:43:13Z 2022-05-18T09:56:09.9276005Z ##[error]Bash exited with code '1'. Let me re-trigger it.

@visbaz looks much better now, I will re-trigger private CI once this is done

@jdonjdon looks like all checks have passed. thanks for triggering CI. please post your reviews on PR.

LGTM

@jdonjdon or @cindychip please merge to master


Cannot set breakpoints on debugger mode

Steps to reproduce:

Run make clean install on Elyra's master branch
Run jupyterlab
Open a python notebook
Select the xpython kernel
Enable debugger on the toggle button in the notebook toolbar
Try to set a breakpoint by clicking next a number line in your notebook code cell

Issue: Can't add breakpoints
Browser console error: Cannot read 'sourcePath' of undefined, pointing to this debugger code line in lab

Trying out a few package combinations I noticed that, for both elyra and lab3 only environments, the requirements are:
For python 3.7, xeus-python >=0.8.0,<0.9.0
For python 3.8, xeus-python=0.9.0
We need to fix Elyra's clean-jupyterlab script to install the appropriate xpython version.
This can issue also be raised in lab.

Please raise this with labs, as they are closing the release.

Lab issue https://github.com/jupyterlab/jupyterlab/issues/9414


Fix issue #95 userLevel caches are wrong

Fixes #95 by removing cacheKeyFn.
The input of userLevelLoader will be userId, so we can just use default cache mechanism here.

Here are my test logs and diff files.
before-fix.diff (just add some logs)

after-fix.diff (equals to default cache)

Coverage decreased (-0.02%) to 89.011% when pulling d787f0ab634ad8d3f633ddd2ff20e1ede6aab497 on 95-userlevel-cache into daf4a41efb48acfc030d57ecef10722915afb123 on master.


Backport: (macos_userdefaults) fix for user attr bug

Description

Backporting the fix made in #12791 to chef-17

user property was not being used when host isn't passed. This is because how the native corefoundation APIs work where we can either pass both to CFPreferencesSetValue or pass none to CFPreferencesSetAppValue. This PR sets default values for user and host as current user and any host.

Related Issue

https://github.com/chef/customer-bugs/issues/657
Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Chore (non-breaking change that does not add functionality or fix an issue)

Checklist:

[x] I have read the CONTRIBUTING document.
[x] I have run the pre-merge tests locally and they pass.
[x] I have updated the documentation accordingly.
[x] I have added tests to cover my changes.
[ ] All new and existing tests passed.
[x] All commits have been signed-off for the Developer Certificate of Origin.

@rishichawda can you rebase and try again please? We updated the certs and just merged the code to fix the windows certs issues. This should pass now.

Sorry about that, I lied - NOW do a rebase and try it again. My stuff just got merged into Chef-17

@rishichawda Is this still important? Can you rebase once more and we'll merge it

Is this still important?

@johnmccrae I'm not sure. I backported these changes as asked in https://github.com/chef/chef/pull/12791#issuecomment-1110161522 . @PrajaktaPurohit can probably answer this.
If this is still needed, I can rebase and push the changes again.


Limit composing styles to layout

When component styles are openly extensible, every style declaration becomes part of an undocumented public API. In a large development environment, consumers of components can make poor decisions. For instance, if a developer modifies padding on a button, this would break if the component moves padding to a child element. This may prevent us from improving components or supporting semantic versioning. It's extremely hard to track down these sorts of impacts. Documenting every css change is not practical.
However, we still need extensible component styles to place components within a layout. An ability to limit the composing styles to the following would be helpful:

width
min-width
max-width
height
min-height
max-height
flex
flex-basis
flex-grow
flex-shrink
align-self
order
justify-self
place-self
visibility
position
top
right
bottom
left
margin-left
margin-right
margin-top
margin-bottom
grid-column-start
grid-column-end
grid-row-start
grid-row-end
grid-column
grid-row
grid-area

Suggestions for API:
const Button = styled.button`
        ...styles…
    `.placeable();

-- or ---

const Button = placeable.button`
        ...styles…
    `;

Ideally, this would include further configurable, as some components should not support styles at all or may be restricted in the types of size properties.
const Button = styled.button`
        ...styles…
    `.placeableExcept(['height', 'min-height']);

Menu.Item = styled.button`
        ...styles…
    `.fixed();

I've been evaluating this as a fork or wrapper, but I thought I should raise it here for discussion.
One item I left out is display, which enables users to switch between a block and inline-block/flex without consideration of the internal layout. After evaluation, it appears this is best handled with an inline-block wrapper, a flexbox layout, or a separate react prop.

@mxstbr Max, I've got a functioning POC working in my fork. Any feedback would be appreciated, particularly on the API and problem space. First few sections of Read Me covers it. Sandbox works too.
It's not something that could be merged due to the API changes. The implementation is a hack, but hey, POC!
https://github.com/studiosciences/placed-components
Digging into the code base really made me appreciate the extraordinary amount of work that went into this project. Well done and thank you (et al) for your efforts.


aggregate cluster extension failover not working as expected

Title: aggregate cluster extension failover not working as expected
Description:
To feature IPv4/IPv6 dual stack support, Envoy's aggregate cluster functionality is used, so that the traffic can go through either the IPv4 or IPv6 networks, where the priority is defined using a cm-configurable option where we can set the preferred IP-version network.
The normal scenario works as expected, where the traffic is going through what is set to be the primary cluster in the aggregate cluster setup. However, when the primary cluster fails to connect, the secondary cluster (which should normally connect) is not being routed any traffic, and a 503 error is returned:
[debug][upstream][source/common/upstream/cluster_manager_impl.cc:1235] no healthy host for HTTP connection pool
[debug][http][source/common/http/conn_manager_impl.cc:1475] [C111][S15900032332570351549] Sending local reply with details no_healthy_upstream

Here is a sample of the aggregate cluster configuration :
{
     "version_info": "3",
     "cluster": {
      "@type": "type.googleapis.com/envoy.api.v2.Cluster",
      "name": "UI-Nudm_NF-udm_instance_1_FQDN-udm01.udm.5gc.mnc03.mcc262.3gppnetwork.org_<IP_ADDRESS>",
      "type": "EDS",
      "eds_cluster_config": {
       "eds_config": {
        "ads": {}
       }
      },
      "connect_timeout": "5s",
      "lb_policy": "LEAST_REQUEST",
      "circuit_breakers": {
       "thresholds": [
        {
         "max_requests": 10000,
         "max_retries": 3
        },
        {
         "priority": "HIGH",
         "max_requests": 10000,
         "max_retries": 3
        }
       ]
      },
      "http2_protocol_options": {
       "hpack_table_size": 4096
      },
      "upstream_bind_config": {
       "source_address": {
        "address": "<IP_ADDRESS>",
        "port_value": 0
       },
       "socket_options": [
        {
         "name": "1",
         "int_value": "252"
        }
       ]
      },
      "transport_socket": {
       "name": "tls",
       "typed_config": {
        "@type": "type.googleapis.com/envoy.api.v2.auth.UpstreamTlsContext",
        "common_tls_context": {
         "alpn_protocols": [
          "h2"
         ]
        }
       }
      }
     },
     "last_updated": "2020-06-12T13:51:04.562Z"
    },
    {
     "version_info": "301",
     "cluster": {
      "@type": "type.googleapis.com/envoy.api.v2.Cluster",
      "name": "UI-Nudm_NF-udm_instance_1_FQDN-udm01.udm.5gc.mnc03.mcc262.3gppnetwork.org_aggregate",
      "connect_timeout": "5s",
      "lb_policy": "CLUSTER_PROVIDED",
      "http2_protocol_options": {
       "hpack_table_size": 4096
      },
      "cluster_type": {
       "name": "envoy.clusters.aggregate",
       "typed_config": {
        "@type": "type.googleapis.com/envoy.config.cluster.aggregate.v2alpha.ClusterConfig",
        "clusters": [
         "UI-Nudm_NF-udm_instance_1_FQDN-udm01.udm.5gc.mnc03.mcc262.3gppnetwork.org_<IP_ADDRESS>",
         "UI-Nudm_NF-udm_instance_1_FQDN-udm01.udm.5gc.mnc03.mcc262.3gppnetwork.org_fc00::192:168:5:e"
        ]
       }
      }
     },
     "last_updated": "2020-06-16T11:48:36.453Z"
    },
    {
     "version_info": "3",
     "cluster": {
      "@type": "type.googleapis.com/envoy.api.v2.Cluster",
      "name": "UI-Nudm_NF-udm_instance_1_FQDN-udm01.udm.5gc.mnc03.mcc262.3gppnetwork.org_fc00::192:168:5:e",
      "type": "EDS",
      "eds_cluster_config": {
       "eds_config": {
        "ads": {}
       }
      },
      "connect_timeout": "5s",
      "lb_policy": "LEAST_REQUEST",
      "circuit_breakers": {
       "thresholds": [
        {
         "max_requests": 10000,
         "max_retries": 3
        },
        {
         "priority": "HIGH",
         "max_requests": 10000,
         "max_retries": 3
        }
       ]
      },
      "http2_protocol_options": {
       "hpack_table_size": 4096
      },
      "upstream_bind_config": {
       "source_address": {
        "address": "fc00::192:168:5:e",
        "port_value": 0
       },
       "socket_options": [
        {
         "name": "1",
         "int_value": "252"
        }
       ]
      },
      "transport_socket": {
       "name": "tls",
       "typed_config": {
        "@type": "type.googleapis.com/envoy.api.v2.auth.UpstreamTlsContext",
        "common_tls_context": {
         "alpn_protocols": [
          "h2"
         ]
        }
       }
      }
     },
     "last_updated": "2020-06-12T13:51:04.593Z"
    },

Thanks !

I don't see any health checking config - how are you expecting Envoy to notice that the first endpoint is unreachable? There might be something else going on here.
Mind including the output of the /clusters admin endpoint and the cluster stats for the clusters involved here?

Hello @snowp,
Thanks for the help!
We're working together on this with @vinzo99.

I don't see any health checking config - how are you expecting Envoy to notice that the first endpoint is unreachable? There might be something else going on here.

We've been relying on the passive health checking using the circuit breaking functionality for that. Do we also need active health checking for this to work?
We've also been experimenting with the front-envoy example to see how the aggregate cluster and its failover funcionality works, and the following example seems to be working for the aggregated clusters where the docker of service1 is stopped and the traffic is routed to service2.

Mind including the output of the /clusters admin endpoint and the cluster stats for the clusters involved here?

We've been using the following testcase, as we're trying to use the aggregate cluster feature to be able to failover between two different networks. One IPv4 and one IPv6. In both cases the target host is only reachable through IPv4. When the first cluster defined in the aggregate cluster is IPv4, then we get traffic to pass. When the first cluster is IPv6 (which is expected to fail and then use the secondary cluster) we can't get any traffic through.
Passing TC

test_cluster_aggregate::default_priority::max_connections::1024
test_cluster_aggregate::default_priority::max_pending_requests::1024
test_cluster_aggregate::default_priority::max_requests::1024
test_cluster_aggregate::default_priority::max_retries::3
test_cluster_aggregate::high_priority::max_connections::1024
test_cluster_aggregate::high_priority::max_pending_requests::1024
test_cluster_aggregate::high_priority::max_requests::1024
test_cluster_aggregate::high_priority::max_retries::3
test_cluster_aggregate::added_via_api::true

test_cluster_<IP_ADDRESS>::default_priority::max_connections::1024
test_cluster_<IP_ADDRESS>::default_priority::max_pending_requests::1024
test_cluster_<IP_ADDRESS>::default_priority::max_requests::10000
test_cluster_<IP_ADDRESS>::default_priority::max_retries::3
test_cluster_<IP_ADDRESS>::high_priority::max_connections::1024
test_cluster_<IP_ADDRESS>::high_priority::max_pending_requests::1024
test_cluster_<IP_ADDRESS>::high_priority::max_requests::10000
test_cluster_<IP_ADDRESS>::high_priority::max_retries::3
test_cluster_<IP_ADDRESS>::added_via_api::true
test_cluster_<IP_ADDRESS>::<IP_ADDRESS>:443::cx_active::0
test_cluster_<IP_ADDRESS>::<IP_ADDRESS>:443::cx_connect_fail::0
test_cluster_<IP_ADDRESS>::<IP_ADDRESS>:443::cx_total::1
test_cluster_<IP_ADDRESS>::<IP_ADDRESS>:443::rq_active::0
test_cluster_<IP_ADDRESS>::<IP_ADDRESS>:443::rq_error::1
test_cluster_<IP_ADDRESS>::<IP_ADDRESS>:443::rq_success::2
test_cluster_<IP_ADDRESS>::<IP_ADDRESS>:443::rq_timeout::0
test_cluster_<IP_ADDRESS>::<IP_ADDRESS>:443::rq_total::3
test_cluster_<IP_ADDRESS>::<IP_ADDRESS>:443::hostname::
test_cluster_<IP_ADDRESS>::<IP_ADDRESS>:443::health_flags::healthy
test_cluster_<IP_ADDRESS>::<IP_ADDRESS>:443::weight::1
test_cluster_<IP_ADDRESS>::<IP_ADDRESS>:443::region::
test_cluster_<IP_ADDRESS>::<IP_ADDRESS>:443::zone::
test_cluster_<IP_ADDRESS>::<IP_ADDRESS>:443::sub_zone::
test_cluster_<IP_ADDRESS>::<IP_ADDRESS>:443::canary::false
test_cluster_<IP_ADDRESS>::<IP_ADDRESS>:443::priority::0
test_cluster_<IP_ADDRESS>::<IP_ADDRESS>:443::success_rate::-1.0
test_cluster_<IP_ADDRESS>::<IP_ADDRESS>:443::local_origin_success_rate::-1.0

test_cluster_fc00::192:168:5:e::default_priority::max_connections::1024
test_cluster_fc00::192:168:5:e::default_priority::max_pending_requests::1024
test_cluster_fc00::192:168:5:e::default_priority::max_requests::10000
test_cluster_fc00::192:168:5:e::default_priority::max_retries::3
test_cluster_fc00::192:168:5:e::high_priority::max_connections::1024
test_cluster_fc00::192:168:5:e::high_priority::max_pending_requests::1024
test_cluster_fc00::192:168:5:e::high_priority::max_requests::10000
test_cluster_fc00::192:168:5:e::high_priority::max_retries::3
test_cluster_fc00::192:168:5:e::added_via_api::true

-------------------------------------------------------------------------------------------------------------------------------

Failing TC

test_cluster_aggregate::default_priority::max_connections::1024
test_cluster_aggregate::default_priority::max_pending_requests::1024
test_cluster_aggregate::default_priority::max_requests::1024
test_cluster_aggregate::default_priority::max_retries::3
test_cluster_aggregate::high_priority::max_connections::1024
test_cluster_aggregate::high_priority::max_pending_requests::1024
test_cluster_aggregate::high_priority::max_requests::1024
test_cluster_aggregate::high_priority::max_retries::3
test_cluster_aggregate::added_via_api::true

test_cluster_<IP_ADDRESS>::default_priority::max_connections::1024
test_cluster_<IP_ADDRESS>::default_priority::max_pending_requests::1024
test_cluster_<IP_ADDRESS>::default_priority::max_requests::10000
test_cluster_<IP_ADDRESS>::default_priority::max_retries::3
test_cluster_<IP_ADDRESS>::high_priority::max_connections::1024
test_cluster_<IP_ADDRESS>::high_priority::max_pending_requests::1024
test_cluster_<IP_ADDRESS>::high_priority::max_requests::10000
test_cluster_<IP_ADDRESS>::high_priority::max_retries::3
test_cluster_<IP_ADDRESS>::added_via_api::true
test_cluster_<IP_ADDRESS>::<IP_ADDRESS>:443::cx_active::0
test_cluster_<IP_ADDRESS>::<IP_ADDRESS>:443::cx_connect_fail::0
test_cluster_<IP_ADDRESS>::<IP_ADDRESS>:443::cx_total::1
test_cluster_<IP_ADDRESS>::<IP_ADDRESS>:443::rq_active::0
test_cluster_<IP_ADDRESS>::<IP_ADDRESS>:443::rq_error::1
test_cluster_<IP_ADDRESS>::<IP_ADDRESS>:443::rq_success::2
test_cluster_<IP_ADDRESS>::<IP_ADDRESS>:443::rq_timeout::0
test_cluster_<IP_ADDRESS>::<IP_ADDRESS>:443::rq_total::3
test_cluster_<IP_ADDRESS>::<IP_ADDRESS>:443::hostname::
test_cluster_<IP_ADDRESS>::<IP_ADDRESS>:443::health_flags::healthy
test_cluster_<IP_ADDRESS>::<IP_ADDRESS>:443::weight::1
test_cluster_<IP_ADDRESS>::<IP_ADDRESS>:443::region::
test_cluster_<IP_ADDRESS>::<IP_ADDRESS>:443::zone::
test_cluster_<IP_ADDRESS>::<IP_ADDRESS>:443::sub_zone::
test_cluster_<IP_ADDRESS>::<IP_ADDRESS>:443::canary::false
test_cluster_<IP_ADDRESS>::<IP_ADDRESS>:443::priority::0
test_cluster_<IP_ADDRESS>::<IP_ADDRESS>:443::success_rate::-1.0
test_cluster_<IP_ADDRESS>::<IP_ADDRESS>:443::local_origin_success_rate::-1.0

test_cluster_fc00::192:168:5:e::default_priority::max_connections::1024
test_cluster_fc00::192:168:5:e::default_priority::max_pending_requests::1024
test_cluster_fc00::192:168:5:e::default_priority::max_requests::10000
test_cluster_fc00::192:168:5:e::default_priority::max_retries::3
test_cluster_fc00::192:168:5:e::high_priority::max_connections::1024
test_cluster_fc00::192:168:5:e::high_priority::max_pending_requests::1024
test_cluster_fc00::192:168:5:e::high_priority::max_requests::10000
test_cluster_fc00::192:168:5:e::high_priority::max_retries::3
test_cluster_fc00::192:168:5:e::added_via_api::true

Hello,
Is info provided by @ChristosKa sufficient for you to troubleshoot this issue ?
Is there anything more we can do to help on this ?
Thanks

In both those cases there only seems to be IPv4 addresses present? The Ipv6 cluster doesn't appear to have any endpoints.
Re passive health checking and circuit breaking: hitting circuit breakers does not mark endpoints as unhealthy, and so they wouldn't trigger failover. If you're using the outlier detection mechanism to do passive health checking that should work, though might not be perfect (endpoints could be returned to healthy at times causing more failures).
An option to test out (assuming you can ensure that the Ipv6 cluster has endpoints) is to use TCP active health checking, in which case it will treat endpoints as unhealthy unless it can maintain a TCP connection to them. This would be a bit more robust, though I'm not sure if that's your problem here.

Thank you for the reply @snowp!
We'll give active health check a try and see if it works.
Could this be related to https://github.com/envoyproxy/envoy/issues/11498 ?
As we're using the go-control-plane's xds_server to dynamically change the cluster order in the aggregate cluster.


Vickel: Watch plagfreecontent.com

Vickel requests the watch of the watch_keyword plagfreecontent\.com. See the MS search here and the Stack Exchange search in text, in URLs, and in code.

plagfreecontent\.com has been seen in 1 true positive, 0 false positives, and 0 NAAs.

Approved by Spevacus in Charcoal HQ


Element Facets ID

Hi,
geometry_controller.get_element_facets(elemen_id) returns a nested list of 3d_points.
Please double check the function, if a return of the face_id is possible.
Thanks

It's possible to create a surface from the point list.
ec.create_surface([p1, p2, ...])


Add openssl_csr resource

Add a resource for creating cert signing requests with openssl to core.

Fixed by #7513


League\Flysystem\FileNotFoundException for existing files

Sometimes I get said exception regardless of the files being accessible.
The only thing that helps is to clear the cache php artisan cache:clear.
This is extremely annoying for my customers, since they need to notice it and to inform me to get access to their files.
I there anything I can do to avoid this?
I'm using league/flysystem-aws-s3-v3:^1

If the Laravel cache reset fixes it, I don’t see how that is a Flysystem issue.

Ok. Sorry for the noise then. What would you suggest? Ticket at laravel?

That sounds like a good idea 👍


Matrix keypad library

Is there a library implementing 4x4 matrix keypads somewhere? We need single click, double click, long press, etc -- just like the ESP IOT Button library but using a keypad matrix.  I expected this to be in the ESP IOT solution but I don't see it there.
Like how this is wired...
https://programmer.ink/think/stm32-4-4-matrix-keyboard-external-interrupt-trigger-mode.html
Could you please ask the IOT people to add keypad matrix support so that we don't have to write our own?
https://espressif-docs.readthedocs-hosted.com/projects/espressif-esp-iot-solution/en/latest/input_device/button.html
It should be able to handle any config up to 4x4  like 2x4, 3x3, 3x4, etc.
Looks like the Arduino library has this and the Espressif one doesn't.

Here is the Arduino Keypad library, it is GPL
https://github.com/Chris--A/Keypad
But it needs clean up to be compatible with the Espressif IOT package

This library needs to be interrupt based, the Arduino one is polled.  The stm example linked above is interrupt based.

The way the current Espressif IOT_Button code is designed this has to be polled. So I implemented keypad support using polling.  For example if you have a 3x3 matrix connected to GPIOs (2, 3, 10,    6, 1, 0)  the example sets up button 1 at (2,6). You can have this code and please add it to the Espressif library. It actually ended up being pretty simple to do.  There is no limit on the size of the matrix until you run out of GPIO pins.  Of course it gets exponential slower as the keypad size grows so you might want an interrupt based solution.
It works by keeping all six GPIOs in input mode.  The ones that are gpio_in_num have pull up turned on. When you read the key I set the gpio_out_num pin to output mode with a zero and then read from gpio_in_num. If key not pressed this reads as a 1, key is pressed reads as a zero.  Then set gpio_out_num back to input mode to not interfere with the other keys on keypad.
Melding it in with IOT_Button makes all of the single click, double click, long press, etc logic work.
You need to add documentation and test cases.
    button_config_t cfg = {
        .type = BUTTON_TYPE_MATRIX,
        .matrix_button_config = {
            .gpio_in_num = 2,
            .gpio_out_num = 6,
        },
    };
    button_handle_t matrix = iot_button_create(&cfg);

matrix.zip

This technique has electrical issues. I am getting cross talk between the buttons due to the high frequency scanning.  It may not be workable.

I deleted the previous code, it did not work for more than 2x2 due to cross talk issues on the wires. I am implementing a different technique using interrupts that does not rely on high frequency scanning.

This is my second attempt at matrix keypad support. This is diff off from the espressif_button component (IOT Button). This version is interrupt based. It has a problem with occasionally losing edge interrupts, but it detects that condition and recovers.  Please test, improve code, etc. You have my full permission to add this code to IDF which I recommend doing. Arduino, ST, NXP, etc all include matrix keypad support in their IDF.
matrix.zip
static uint8_t key;

static void button_down(void *arg) {
    ESP_LOGI(TAG, "button_down %x", key);
}
static void button_up(void *arg) {
    ESP_LOGI(TAG, "button_up %x", key);
}
static void button_repeat(void *arg) {
    ESP_LOGI(TAG, "button_repeat %x", key);
}
static void button_single(void *arg) {
    ESP_LOGI(TAG, "button_single %x", key);
}
static void button_double(void *arg) {
    ESP_LOGI(TAG, "button_double %x", key);
}
static void button_long_start(void *arg) {
    ESP_LOGI(TAG, "button_long_start %x", key);
}
static void button_long_hold(void *arg) {
    ESP_LOGI(TAG, "button_long_hold %x", key);
}

app_driver_handle_t app_driver_switch_init()
{
    button_config_t cfg = {
        .type = BUTTON_TYPE_MATRIX,
        .matrix_button_config = {
            .row = {4, 5, 7, 0xff},
            .column = {1, 2, 3, 0xff},
            .pKey = &key,
        },
    };
    button_handle_t matrix = iot_button_create(&cfg);
    iot_button_register_cb(matrix, BUTTON_PRESS_DOWN, button_down);
    iot_button_register_cb(matrix, BUTTON_PRESS_UP, button_up);
    iot_button_register_cb(matrix, BUTTON_PRESS_REPEAT, button_repeat);
    iot_button_register_cb(matrix, BUTTON_SINGLE_CLICK, button_single);
    iot_button_register_cb(matrix, BUTTON_DOUBLE_CLICK, button_double);
    iot_button_register_cb(matrix, BUTTON_LONG_PRESS_START, button_long_start);
    iot_button_register_cb(matrix, BUTTON_LONG_PRESS_HOLD, button_long_hold);

Thank you for your suggestion.
We'll mark it TODO.

I have solved this locally. I just gave up on using interrupts and resorted polling. That is easy to implement.


[MINOR][SparkR] update sparkR DataFrame.R comment

What changes were proposed in this pull request?
update sparkR DataFrame.R comment
SQLContext ==> SparkSession
How was this patch tested?
N/A

Test build #61382 has started for PR 13946 at commit 41f821a.

Test build #61382 has finished for PR 13946 at commit 41f821a.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/61382/
Test PASSed.

LGTM
@shivaram

merging this to master and branch-2.0


hide Categorys

@shang1219178163 can you explain why we should add this when you can do the same by using emojiSet ?

Please make a new PR if you still think it is necessary. Thanks for your contribution 🙏


nfs: fix nfs with external ceph cluster support (bp #5169)

This commit refact and fix the nfs deployment with external ceph cluster
support.
Closes: https://bugzilla.redhat.com/show_bug.cgi?id=1814942
Signed-off-by: Guillaume Abrioux<EMAIL_ADDRESS>(cherry picked from commit cc28d9ec2669f14fa2e75627093aa65905af969f)

jenkins test centos-non_container-lvm_osds


Repo sync for protected CLA branch

The pull request is created from master637358725118148409 to master to fix git push error for protected CLA branch

@cmcclister : Thanks for your contribution! The author(s) have been notified to review your proposed change.


Documentation on independence of algorithm realizations across GPUs

Currently when a seed is passed into the trainer the following occurs:
seed += dist.get_global_rank()
reproducibility.seed_all(seed)
self.seed = seed

This means that each process uses a different (but deterministic) seed. This has two implications:

Stochastic algorithms that are applied individually in a process/gpu are independent realizations. For example, the image patches that are cut out by CutOut will be independently sampled (and likely different) on each GPU.

Results will change depending on the number of processes/devices used during training.

Having different seeds (and hence independent sampling) for different GPUs is desirable because it increases the diversity of data generated by stochastic transformations. However, this affects replicability, and users should be very aware of this behavior. The documentation of all affected methods should be updated to make this very clear. There are also probably other places where we want to mention this.
cc @ajaysaini725 @hanlint @coryMosaicML @jbloxham

Closing. Tracking elsewhere as low pri


Update TouchableOpacity.js

Touchable element with user interface feedback need to update status immediately.Improve pressing dull feeling.

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@Obooman updated the pull request.

@Obooman updated the pull request.

This isn't right -- the opacity shouldn't instantaneously change if you drag your finger out of the button's hit box and back in. Making this change requires change to the TouchableMixin library and is a lot more than 1 line.

@ide You are right.The button opacity change immediately ONLY on the first hit to the hit box.when drag finger out and in it changes with transition.I'll update this.

@ide I find that when touchable mixin dispatch hit event there's a payload with registrationName.I think this is a user Interactive problem so distinguishing event types is a better solution,we only need to modify TouchableOpacity.js.I'll update the pr later.

@Obooman updated the pull request.

@Obooman updated the pull request.

@Obooman updated the pull request.

@Obooman updated the pull request.


Removes all stdout/err logs while testing

@drew-gross I belive you're gonna like that one :)

Current coverage is 93.02%

Merging #1268 into master will increase coverage by +0.02% as of 447f0dc

@@            master   #1268   diff @@
======================================
  Files           84      84
  Stmts         5275    5279     +4
  Branches       960     960
  Methods          0       0
======================================
+ Hit           4906    4911     +5
+ Partial         11       9     -2
- Missed         358     359     +1

Review entire Coverage Diff as of 447f0dc

Powered by Codecov. Updated on successful CI builds.


update pacakge version with npm audit support

before:
[!] 371 vulnerabilities found [9670 packages audited]
    Severity: 357 Low | 10 Moderate | 4 High
    Run `npm audit` for more detail

with $ npx npm@next audit fix:
added 167 packages from 122 contributors, removed 6 packages, updated 37 packages and moved 4 packages in 68.023s
fixed 371 of 371 vulnerabilities in 9665 scanned packages

Holy crap.  TIL npm audit is a thing.

 TIL npm audit is a thing.

then why not merge this :)

I will as soon as I have the bandwidth to test it. 🐢


Remove version: Microsoft.Edge.Beta version 123.0.2420.51

[Automated] It returns code over 400 in all urls
Microsoft Reviewers: Open in CodeFlow

For moderators or/and anyone else

[!Caution]
As a result of several personal problems I've had over the last few months + my final exams coming up very soon, I'm currently unable to look at my GitHub notifications every day and maintain my executions correctly.
If you detect a certain problem on a certain pul request:

Either you can close the pull request directly without mentioning me.
Or you can send me a message on X (Twitter): @Exorcism0666

Thank you for your understanding, and I'm sorry if some pull requests can't be approved due to the situation I'm in.

This account is automated by Github Actions and the source code was created by CoolPlayLin. If you have any questions about any pull request, don't hesitate to ping Exorcism0666.

[!warning]
With the new version of Komac, numerous Pull Requests may contain bugs or unwanted elements. If such issues arise, please tag russellbanks so that these bugs can be addressed in future updates.

[!important]
Please carefully review these Pull Request before merging. If it is a Pull Request for removing incorrect content and the URLs are issue, free upon manual checking, please close this Pull Request directly. (It is best to inform Exorcism0666 of the closure.)

良い一日をお過ごしください！

URL: https://msedge.sf.dl.delivery.mp.microsoft.com/filestreamingservice/files/e53bb1c4-7824-4552-bbd7-77ead35102c5/MicrosoftEdgeBetaEnterpriseX86.msi
Response Error: The remote server returned an error: (404) Not Found.
(Automated message - build 912)


IndexSelect and maybe various other oddball issues with 2D structured grids as 3D surfaces

Describe the bug
With #17704, we have ability to handle 2D structured grids as surfaces in 3 dimensions. But, in so doing, I am not sure our pipelines have seen this kind of object very often and would not be surprised if we don't handle it quite right in a variety of places. One I know if is IndexSelect. If you look at the (currently incorrect) baseline for test/baseline/databases/silo/silo_curvilinear_3d_surface_3.png you will see that it seems to have dropped all y-oriented edges (that is y within the context of the 2D *topological space of the input mesh).
I suspect there are other situations that could not work quite right either.
Helpful additional information

Did VisIt crash:
Did you get wrong results:

To Reproduce
Run curvilinear_3d_surface test func in silo.py test (you can disable a lot of the eary code there).
Expected behavior
Plot the correctly index selected mesh.
Desktop

OS and version: observed on macOS but suspect it fails on all OSs
VisIt Version: 3.3

Additional context
I don't think this is urgent. But there have been users occasionally wanting to handle 3D surfaces this way.

This may be the result of having arbitrarily selected the 2nd of the three dimensions of the Quadmesh in Silo (e.g. the y dimension) as the size 1 dimension. If I choose a mesh dimensionaly of [nx][ny][1] instead of [nx][1][nz], I think Index Select works fine.
It just isn't obvious to me if we restrict our support to only [nx][ny][1] type meshes that we wind up preventing certain kinds of 2D structured surfaces in 3D.


Only one or operator is identified

 Issue by prabushi
Wednesday Mar 10, 2021 at 08:45 GMT
Originally opened as https://github.com/ballerina-platform/plugin-vscode/issues/271

Description:

Suggested Labels:

Suggested Assignees:

Affected Product Version:
OS, DB, other environment details and versions:
Steps to reproduce:
https://github.com/ballerina-platform/ballerina-distribution/blob/master/examples/mysql-execute-operation/mysql_execute_operation.bal#L26
Related Issues:

 Comment by prabushi
Wednesday Mar 10, 2021 at 13:55 GMT

This behavior is observed because the positive look behind is not supported by TextMate.


Is PDB File Required for Attestation Signing?  CAT?

In the "Create the CAB File Section" of this page it is stated, "A typical CAB file submission must contain the following:  ...  The symbol file that is used for debugging information ...".
Each of the examples that follow on the page do not contain PDB files in the CAB submission, only the INF and SYS files.  I would expect that the CAB submission would require the CAT file, not included in the examples.  However, I would not expect the PDB file to be included in the CAB submission unless it was normally included as part of the INF package.

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 674c6417-5a69-8fd5-be62-e4e06ba465be
Version Independent ID: 674c6417-5a69-8fd5-be62-e4e06ba465be
Content: Attestation sign Windows 10+ drivers - Windows drivers
Content Source: windows-driver-docs-pr/dashboard/code-signing-attestation.md
Product: windows-hardware
Technology: dashboard
GitHub Login: @anaharris-ms
Microsoft Alias: anaharris

This issue with the PDB was raised a few weeks ago.  To remove the ambiguity, I think that the examples need to be updated, and an explanation for the requirements added.

Hi @dwkaiser, thanks for contacting Microsoft.
I will update the document with the explanation as given here:
https://github.com/MicrosoftDocs/windows-driver-docs/issues/3372

Updated in https://github.com/MicrosoftDocs/windows-driver-docs-pr/pull/1893

@anaharris-ms, I am not able to view the specific PR link you referenced above; therefore, I cannot "review it".
I do think that requiring symbol files will create concerns for OEM's and their need to protect proprietary intellectual property.  I hope that the documentation will address this concern.
Thank you.


is_installed return false on windows 11

is_installed return false on windows 11
local env_path = os.getenv("PATH") local base_paths = vim.split(env_path, ":", true)
The env_path is using ";" not ":" on my windows 11 system.  Is this the reason that is_installed always return false?

I am using linux and mac only. I pushed a change as you suggested. Could you check if it works for you?

Thank you @ray-x  @djdv ! Looks like @djdv  is right.

It works now. Thanks!


[dotnet] latest STS version is stuck on 7.0.410

Hi,
It appears that the latest.version (STS) version is no longer being updated, it should report 9.0.101 but it's still on 7.0.410 three weeks after .NET 9 was released. As a result, the dotnet feature still defaults to installing the latest.version (LTS) version (currently 8.0.403) .
Since the latest.version file above is more of a private API used by the dotnet-install script, maybe now is a good time to rewrite this code to use the releases-index.json. More info: README.

Hi @sliekens
The existing URL's have already been updated to point to the versions 9.0.101 for STS and 8.0.404 for LTS

Ok interesting, was it coincidence? 😁
Regardless, I still think it's a good idea to use the releases index rather than the semi-private URL. I could draft a PR for it.

Yes sort of a coincidence, had been promptly updated by the dotnet team
The URL's that are present in the feature are maintained by dotnet team only

@gauravsaini04 this just appeared on my feed: https://github.com/tonybaloney/Pyjion/pull/526
"new CDN link for dotnet"
It looks like the devcontainer feature might break after 15 Jan because of this change.

Yes, the files in this folder will need to change: https://github.com/devcontainers/features/tree/main/src/dotnet
Might it be time for the repo to snap a new copy of the install script? Or is it really necessary for this repo to keep its own copy with this logic?
https://github.com/dotnet/install-scripts/tree/main/src

@richlander the dotnet-install.sh script in this repo is updated weekly via GitHub Actions (update-dotnet-install-script.yml), so that will get resolved as soon as the action runs and the resulting PR is merged.
The thing that won't resolve itself is the use of latest.version (STS) and latest.version (LTS) to detect which channel has the absolute greatest version. I understand using these files for any purpose is not endorsed.

I raised #1230 to stop using azureedge.net

I asked for the advice on the special files. Naturally, we're a bit short-staffed at the moment. We're going to publish guidance  on the various URL types, including the ones you've asked about.

My team got back to me. Those URLs are fine to use. They will be included in the guidance document.


Production DR Test

User Story

So that I know the system can recover from data loss, as a Data Maintainer, I want to see results from a production-like DR test.

Acceptance Criteria

[ ] Given  [a pre-condition], when [an event happens], then [an expected outcome occurs]
[ ] Given [a pre-condition], when [an event happens], then [an expected outcome occurs]

Additional context

Tasks

[ ] ...
[ ] ...

Definition of Ready

[ ] This story is ready to work on, according to the team's definition

Definition of Done

[ ] This story is done, according to the team's definition

Not needed.