S-nitrosoglutathione reductase activity (GO:0080007)

I was reviewing the changes to GO:0080007 in #23357 as they affected a fly gene (Fdh, FBgn0011768).
Current GO:0080007 term entry is:
id: GO:0080007
name: S-nitrosoglutathione reductase activity
namespace: molecular_function
def: "Catalysis of the reaction: glutathione N-hydroxysulfenamide + NADH + H+ = S-nitrosoglutathione + NAD+." [PMID:11260719, PMID:27094420, PMID:30795534]
is_a: GO:0004022 ! alcohol dehydrogenase (NAD+) activity
is_a: GO:0051903 ! S-(hydroxymethyl)glutathione dehydrogenase activity

Meaning the current tree looks like this:
oxidoreductase activity, acting on the CH-OH group of donors, NAD or NADP as acceptor (GO:0016616) [EC:1.1.1.-]
|__alcohol dehydrogenase [NAD(P)+] activity (GO:0018455) [EC:<IP_ADDRESS>]
    |__alcohol dehydrogenase (NAD+) activity (GO:0004022) [EC:<IP_ADDRESS>]
        |__*S-nitrosoglutathione reductase activity (GO:0080007) [no EC/RHEA]*
|__S-(hydroxymethyl)glutathione dehydrogenase activity (GO:0051903) [EC:<IP_ADDRESS>4]
    |__S-(hydroxymethyl)glutathione dehydrogenase NAD activity (GO:0106322) [EC:<IP_ADDRESS>4, RHEA:19985]
    |__S-(hydroxymethyl)glutathione dehydrogenase NADP activity (GO:0106321) [EC:<IP_ADDRESS>4, RHEA:19981]
    |__*S-nitrosoglutathione reductase activity (GO:0080007) [no EC/RHEA]*

As noted in the previous ticket, the different activities ascribed to the GSNOR (aka FDH, ADH5-class III) enzyme are complicated, but the recent PMID:30795534 review sums up the situation well - from Fig 1 legend:
"Reaction mechanisms of alcohol dehydrogenase/S-nitrosoglutathione reductase (ADH3/GSNOR) in formaldehyde and S-nitrosoglutathione catabolism.
(A) In the dehydrogenase mode, GSNOR using NAD+ as a coenzyme catalyzes the oxidation of S-hydroxymethylglutathione (HMGSH), spontaneously formed from formaldehyde and glutathione to S-formylglutathione, which was further hydrolyzed to glutathione and formate by S-formylglutathione hydrolase.
(B) In the reductase mode, GSNOR catalyzes the reduction of S-nitrosoglutathione (GSNO) using NADH to an unstable intermediate N-hydroxysulfinamide (GSNHOH). Depending on the local concentration of GSH, GSNHOH is either decomposed to glutathione disulfide (GSSG) and hydroxylamine at high GSH levels, or at low GSH levels spontaneously converts to glutathione sulfinamid (GSONH2), which can be hydrolyzed to glutathione sulfinic acid (GSOOH) and ammonia."
Reaction A is GO:0106322 "S-(hydroxymethyl)glutathione dehydrogenase NAD activity" (EC:<IP_ADDRESS>4/RHEA:19985), def: "Catalysis of the reaction: S-(hydroxymethyl)glutathione + NAD+ = S-formylglutathione + NADH + H+."
Reaction B is GO:0080007 "S-nitrosoglutathione reductase activity", which, as shown above, has no RHEA.
However, there is a RHEA for the NADP version of this reaction (RHEA:63500), and I have just requested they also make the NAD version.
Importantly, the EC:<IP_ADDRESS>4 entry (which of course represents the enzyme, not the activities), says:
Name: S-(hydroxymethyl)glutathione dehydrogenase
Reaction: NADP(+) + S-(hydroxymethyl)glutathione <=> H(+) + NADPH + S-formylglutathione
Reaction: NAD(+) + S-(hydroxymethyl)glutathione <=> H(+) + NADH + S-formylglutathione
Comment: Also specifically reduces S-nitrosylglutathione*

Seems 'S-nitrosylglutathione' is a old synonym for S-nitrosoglutathione (GSNO) - e.g. see PMID:8284942 - so, this EC corresponds to both Reaction A and B mentioned above.

So I think we need to make the following changes:

[x] Change GO:0080007 name to "S-nitrosoglutathione reductase (NADH) activity"
[x]  Remove both current is_a parents on GO:0080007 and replace with "is_a: GO:0016616 ! oxidoreductase activity, acting on the CH-OH group of donors, NAD or NADP as acceptor" (EC:1.1.1.-)
[x] Rewrite GO:0080007 def to use the chemical names in the related RHEA:63500 entry and put the NAD/NADH on the correct sides of the equation (!). That is: "Catalysis of the reaction: S-nitrosoglutathione + NADH + H(+) = sulfinamide glutathione + NAD(+). [PMID:11260719, PMID:27094420, PMID:30795534]"
[x] Add this comment GO:0080007: "Sulfinamide glutathione (GSNHOH) is an unstable intermediate. At high GSH levels, it is decomposed to glutathione disulfide (GSSG) and hydroxylamine. At low GSH levels, GSNHOH  spontaneously converts to glutathione sulfinamid (GSONH2), which can be hydrolyzed to glutathione sulfinic acid (GSOOH) and ammonia. (PMID:30795534)"
[x] Make new GO term for the NADP reaction (RHEA:63500) - annotated to 319 proteins in UniProt. Name = "S-nitrosoglutathione reductase (NADPH) activity"
[ ] Add newly requested RHEA to GO:0080007 when available.
[x] Tweak name of "S-(hydroxymethyl)glutathione dehydrogenase activity" to "S-(hydroxymethyl)glutathione dehydrogenase [NAD(P)H] activity"
[x] Make EC:<IP_ADDRESS>4 a BroadMatch xref on all these terms.

Final tree would look like this:
oxidoreductase activity, acting on the CH-OH group of donors, NAD or NADP as acceptor (GO:0016616) [EC:1.1.1.-]
|__S-(hydroxymethyl)glutathione dehydrogenase  [NAD(P)H] activity (GO:0051903) [EC:<IP_ADDRESS>4]
    |__S-(hydroxymethyl)glutathione dehydrogenase NAD activity (GO:0106322) [EC:<IP_ADDRESS>4, RHEA:19985]
    |__S-(hydroxymethyl)glutathione dehydrogenase NADP activity (GO:0106321) [EC:<IP_ADDRESS>4, RHEA:19981]
|__S-nitrosoglutathione reductase (NADH) activity (GO:0080007) [EC:<IP_ADDRESS>4, new RHEA]
|__S-nitrosoglutathione reductase (NADPH) activity (NTR) [EC:<IP_ADDRESS>4, RHEA:63500]

Note: I don't know if we also want/need a "S-nitrosoglutathione reductase [NAD(P)H] activity" grouping term here?

Hi @sjm41
As described in the doc here: https://wiki.geneontology.org/Guidelines_for_new_Molecular_Functions#NAD/NADP_cofactors
'NAD(P)H' terms should be used for cases where the cofactor is not known. If we always know the cofactor, them we dont add the grouping term.  Is this the case here?

OK. Given that (i) we currently only have one "S-nitrosoglutathione reductase activity" term in the GO, which is for NAD; and (ii) there's no EC/RHEA corresponding to NAD(P) reaction that could potentially use either, I conclude that we don't need a "S-nitrosoglutathione reductase [NAD(P)H] activity" grouping term here. (At least, not at the moment.)

+[Term]
+id: GO:0160163
+name: S-nitrosoglutathione reductase (NADPH) activity
+namespace: molecular_function
+def: "Catalysis of the reaction: H(+) + NADPH + S-nitrosoglutathione = NADP(+) + sulfinamide glutathione." [RHEA:63500]
+xref: EC:<IP_ADDRESS>4 {source="skos:broadMatch"}
+xref: RHEA:63500
+is_a: GO:0016616 ! oxidoreductase activity, acting on the CH-OH group of donors, NAD or NADP as acceptor
+property_value: term_tracker_item "https://github.com/geneontology/go-ontology/issues/27135" xsd:anyURI
+created_by: rynl
+creation_date: 2024-02-28T01:46:34Z

Thanks @raymond91125. I'll comment here when RHEA have made the new term.

Just received an email from Anne at RHEA:

RHEA:78371 H+ + NADH + S-nitrosoglutathione = NAD+ + sulfinamide glutathione
(available soon).
So we should be able to add RHEA:78371 to GO:0080007 soon.

Hold on - Anne has also pointed out some confusion about these reactions on my part.  I'll sort this out and post another comment about the final resolution later on today.

Hi @raymond91125
So I'd been confusing 'S-(hydroxysulfenamide)glutathione (CHEBI:229723), aka GSNHOH' with 'sulfinamide glutathione (CHEBI:145547)', which are related but different chemicals....
I've sorted this out with Anne at RHEA, and they have updated RHEA:63500 & RHEA:78371 to have the following equations:
RHEA:63500 H+ + NADPH + S-nitrosoglutathione = NADP+ + S-(hydroxysulfenamide)glutathione
RHEA:78371 H+ + NADH + S-nitrosoglutathione = NAD+ + S-(hydroxysulfenamide)glutathione
(RHEA:78371 is mapped to MetaCyc:RXN-17884)
So, the remaining tasks on the GO side are:

[ ] Update defs (and comment) of GO:0080007 and GO:0160163 to use 'S-(hydroxysulfenamide)glutathione' rather than 'sulfinamide glutathione'.
[ ] remove EC:<IP_ADDRESS>4 xref from GO:0080007 and GO:0160163
[ ] add  RHEA:78371 and  MetaCyc:RXN-17884 xrefs to GO:0080007
[ ] make EC:<IP_ADDRESS>4 an exact match xref on S-(hydroxymethyl)glutathione dehydrogenase  [NAD(P)H] activity (GO:0051903)

I can take care of these last bits myself, so I'll reassign the ticket to me and take care of them.  Thanks!


Don't request for write storage permissions for android 11 and above.

Fixes #2268

For android 11 and above, the app already has permissions to read/write storage for shared data (including the data created by the app itself). Explicitly requesting for write permission always returns denied.

Verified the changes by creating an emulator (Android 12 and Android 14) and opening the photo task.
@gino-m  PTAL?

@shobhitagarwal1612 Checks failed because Gradle daemon disappeared again. Could this be related to JDK version or heap size?

@shobhitagarwal1612 Checks failed because Gradle daemon disappeared again. Could this be related to JDK version or heap size?

I'll have to check. I'm not sure what's causing it.


Ankur's Card

My contribution please accept, Thank you.

thanks for contributing.Hope it helps a bit in your open source contribution journey :)

Hi,
Thank you for accepting my work, I just want to ask your permission if I could screenshot this message and use it in my university project as they need the proof of my work.
Thank you.
From: Rocktim<EMAIL_ADDRESS>Sent: 29 March 2019 16:18
To<EMAIL_ADDRESS>Cc: Ankur Vithoba<EMAIL_ADDRESS><EMAIL_ADDRESS>Subject: Re: [RocktimSaikia/Contribute-101] Ankur's Card (#4)
thanks for contributing.Hope it helps a bit in your open source contribution journey :)
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://eur02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FRocktimSaikia%2FContribute-101%2Fpull%2F4%23issuecomment-478059504&data=02|01|ak1915%40live.mdx.ac.uk|893830c87aca464940f808d6b4623751|38e37b88a3a148cf9f056537427fed24|0|0|636894731260357005&sdata=0asWSGjCFjykiIYwypo89ddCbSINRoU3hs7NsApnxpo%3D&reserved=0, or mute the threadhttps://eur02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAqrYOWgRCQNbStiOdWV3d_XVzTB9CCvgks5vbjzigaJpZM4cShVw&data=02|01|ak1915%40live.mdx.ac.uk|893830c87aca464940f808d6b4623751|38e37b88a3a148cf9f056537427fed24|0|0|636894731260367015&sdata=VYBDqNHyT9teeqv8EJlxv%2FFWnxHYNLHaCX8mOPPrmh8%3D&reserved=0.

@ankurkalambe sure no problem.


Support for custom types in PostgreSQL

Describe the feature
Support for object types in Postgresql
Example:
create type prod.log_level as enum ('error', 'warn', 'debug', 'info');
Describe alternatives you've considered
Currently the only way to work this is with a cast to text type column
Additional context
Postgresqlspecific feature:
https://www.postgresql.org/docs/12/sql-createtype.html
Who will this benefit?
I'd like to perform additional validation and even tests based around specific custom type values. Etc.
This is relatively low priority since it only impacts data warehouses built in true postgresql.

@sgoley Interesting idea! I think this is totally possible with existing dbt functionality.
If I understand correctly, you could code up a macro to template out the create type DDL, and call it in a hook or operation.
I'm going to close this issue, but feel free to re-open if you have a specific dbt code change in mind.

@jtcohen6 What would be the appropriate way to contribute this if I was able to successfully develop it?
I was thinking this was something that should be contributed to this document:
https://github.com/fishtown-analytics/dbt/blob/dev/marian-anderson/plugins/postgres/dbt/include/postgres/macros/adapters.sql ?
Thanks.

Got it. The functions in that file are:

Building blocks that dbt needs to execute its standard behavior (creating schemas, tables, views, etc).
Postgres-specific implementations of those core building blocks (hence the postgres__ prefix), with the expectation that other databases implement the same functionality differently.

I don't see a hypothetical create_type macro fitting those criteria:

Not an essential building block for standard dbt behavior
Unique to Postgres (as far as I'm aware)

That is to say, it's an additive feature. You should absolutely leverage a custom macro/hook/operation in your own project, and you don't need to wait for a dbt code change to do so.
If, after writing that macro in your own project, you want to open source your work, here are two places I could imagine:

A package for Postgres-specific functionality, e.g. postgres-utils (a la snowflake-utils). I don't think such a package exists yet.
Written up in a Discourse post!

The package-based approach makes sense if the code powering your macro is so tangled that users would want to install and run it directly, without needing to copy-paste, alter, or deeply understand the code.
As it is, I don't think that applies here; I think the code for this macro would be quite concise. What's much more interesting is the context and strategy surrounding this: When would you want to leverage custom types in Postgres? What does it get you, what are the trade-offs?

Thanks Jeremy - Going to give it my best shot!
https://github.com/sgoley/dbt-postgres-utils


⚠ Bofrost.lu has degraded performance

In f7169cd, Bofrost.lu (https://www.bofrost.lu) experienced degraded performance:

HTTP code: 200
Response time: 1465 ms

Resolved: Bofrost.lu performance has improved in 8ede113.


Create the REST api get all the teams available currently

Already added https://cmsweb.cern.ch/wmstatsserver/data/teams
Need to be adjusted after thread monitor which allow empty team name. #7641


install on kibana 5.0 fails

I've followed the instrunctions (clone+zipped) and got the following error
root@master1:~/amihay# /data/elasticsearch50/kibana-5.0.0-linux-x86_64/bin/kibana-plugin install file:///tmp/kibana_health_metric_vis.zip Attempting to transfer from file:///tmp/kibana_health_metric_vis.zip Transferring 216517 bytes.................... Transfer complete Retrieving metadata from plugin archive Plugin installation was unsuccessful due to error "No kibana plugins found in archive"

@agonen  Hi. It's normal, my plugin does not work on Kibana 5. A future release on Kibana 5 will soon be available.

@agonen Hi! The plugin for kibana 5 is complete. Leave me a star if my project appeals to you.


Added type annotation to some functions to make the code more readable.

Added type annotations to make the code more readable. Knowing the data types to be returned will make it easier for the developer using the client.

thank you for the contribution!


Update docs and fix 404 issue due to duplicate slash

it works, please merge

I've also validated this. The 404 issue is fixed and everything appears to be in working order again.

confirm pull request https://github.com/nicohaenggi/SafariBooks-Downloader/pull/40  fixed 404

Hi @yaasin12.
The 404 issue should be fixed Indeed.
If not, you can either discuss it here or on my forked project hypr2771/SafariBooks-Downloader.
Sorry for not linking directly to projects, phone is really a pain when it comes to multi tabs.
Thanks @yaasin12 !

@nicohaenggi
404 is fixed.
I suggest you to review and test the solution and merge this pull asap (you can see lots of people are getting results!) :hourglass_flowing_sand:
@hypr2771
Thanks for the solution :1st_place_medal:

glad to see someone already had a fix for my 404 issue!   thanks @hypr2771


Restarts are slow

Restarting my node process with watchify is slow, because I'm generating lots of bundles. Is it possible to have it store ASTs and/or compiled file strings in some kind process-external cache? Maybe something I can implement/override for the caching piece, in order to store in redis or whatever rather than in memory? Or does this exist already and I just missed it? Thanks.

You can implement another caching strategy same way watchify implements an in-memory cache

@greim you can give it a try to persistify which implements a cache that can be persisted to disk, reducing the time for builds. It is a wrapper over watchify/browserify, so the cli commands should be interchangeable.

@royriojas - Thanks!


add cni feature

resolve: https://github.com/istio/istio/issues/16955

@morvencao: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

lint_operator
64709ffa05e5be020044bca18a30787d52d71259
link
/test lint

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@morvencao: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

lint_operator
64709ffa05e5be020044bca18a30787d52d71259
link
/test lint

manifest-apply_operator
64709ffa05e5be020044bca18a30787d52d71259
link
/test manifest-apply

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@morvencao: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

manifest-apply_operator
64709ffa05e5be020044bca18a30787d52d71259
link
/test manifest-apply

mandiff_operator
6ced1f94851ae9eaacb2d2522536e88d4053c0a2
link
/test mandiff

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@morvencao: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

manifest-apply_operator
64709ffa05e5be020044bca18a30787d52d71259
link
/test manifest-apply

mandiff_operator
6ced1f94851ae9eaacb2d2522536e88d4053c0a2
link
/test mandiff

mesh_operator
6ced1f94851ae9eaacb2d2522536e88d4053c0a2
link
/test mesh

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@morvencao: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

manifest-apply_operator
64709ffa05e5be020044bca18a30787d52d71259
link
/test manifest-apply

mandiff_operator
6ced1f94851ae9eaacb2d2522536e88d4053c0a2
link
/test mandiff

mesh_operator
6ced1f94851ae9eaacb2d2522536e88d4053c0a2
link
/test mesh

lint_operator
6ced1f94851ae9eaacb2d2522536e88d4053c0a2
link
/test lint

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@morvencao: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

manifest-apply_operator
64709ffa05e5be020044bca18a30787d52d71259
link
/test manifest-apply

mandiff_operator
6ced1f94851ae9eaacb2d2522536e88d4053c0a2
link
/test mandiff

mesh_operator
6ced1f94851ae9eaacb2d2522536e88d4053c0a2
link
/test mesh

lint_operator
6ced1f94851ae9eaacb2d2522536e88d4053c0a2
link
/test lint

test_operator
6ced1f94851ae9eaacb2d2522536e88d4053c0a2
link
/test test

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@morvencao: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

manifest-apply_operator
64709ffa05e5be020044bca18a30787d52d71259
link
/test manifest-apply

test_operator
86284284cee47d476e46fb7673e9a0f48e3cfe2b
link
/test test

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@morvencao: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

manifest-apply_operator
64709ffa05e5be020044bca18a30787d52d71259
link
/test manifest-apply

test_operator
0337e5dd96dd703b80d4c5e9b136d05b54b52ba8
link
/test test

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.


Fix typo in Advanced.md

Checklist

[x] I've run bundle exec rspec from the root directory to see all new and existing tests pass
[x] I've followed the fastlane code style and run bundle exec rubocop -a to ensure the code style is valid
[x] I've read the Contribution Guidelines

Description

fix typo in docs/Advanced.md.

Great catch! Thanks @colorbox ! 🚀


Error that return in model callbacks won't be displayed in Qor admin UI

From user point of view, He don't know what happened.

@jinzhu Deleting record callback errors didn't have a place to show up.


Create pt.ps1

Portuguese translation for SpotX installer

Thanks
only you forgot to add yourself
could you translate the string "Translation author:"

Thanks only you forgot to add yourself could you translate the string "Translation author:"

Translation is "Autor da tradução:"
;)

added


Update MD file on new branch 2017-33-30_17-11-43

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

split/updateTestRef.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Better statistics calculation

Currently, we calculate statistics regarding classes and classifications. For classes, the results are grouped into three categories: totally unknown classes, partially known classes, totally known classes.
Considering X the number of classifications available, and K the number of known classifications, the categories are:

totally unknown classes (TU): K = 0
partially known classes (PK): 0 < K < X
totally known classes (TK): K = X

As can be seen, classes with a single known classification and classes with a single unknown classification are both registered as PK classes.
Considering this, we could create a new statistics for classes indicating the % of information (number of known classifications/number of classifications available) that this every class have.
By implementing this, it would be possible to discover the average amount of information discovered for classes. E.g., the average known percentage starts in 10% and ends in 90%, then 80% were increased.

Problem solved with the creation of the knowledge_matrix in commit caeb012d2478c9c376dabc75a9b60ce8a10a91cb.


Excuse me,When I reboot my consumer,I cat get the kafka message which remain in kafka,What can I do to maintain the message's offset?

Versions
Sarama Version: 1.12.0
Kafka Version: docker hub
Go Version: 1.7
Configuration
config := sarama.NewConfig()
config.Producer.Return.Successes = true
Problem Description
Excuse me,When I reboot my consumer,I cat get the kafka message which remain in kafka,What can I do to maintain the message's offset? This is the first time I have used kafka,Also please see understanding。

partitionConsumer, err := consumer.ConsumePartition("datacenter", 0, sarama.OffsetNewest) 	if err != nil { 		panic(err) 	}
This is my consumer code.

You basically have to store the last offset you have consumed for every topic/partition somewhere, and use that to resume where you left off when you restart. In your example, you'd use the third  parameter rather than OffsetNewest.
You may be interested in a high-level consumer which manages this for you. See https://github.com/Shopify/sarama/wiki/Frequently-Asked-Questions#consuming for more info.

It worked for me!Thank you


Typo in the topology file

In the topology file, following typo needs to be fixed.
ipv4-subnet -> ipv4_subnet
mgmt-ipv4 -> mgmt_ipv4

Hi. This is not a typo. We use dashes not underscores in the past releases


lint: fix unhandled errors

Codecov Report

Merging #1245 (203191e) into main (388722b) will decrease coverage by 0.29%.
The diff coverage is 31.06%.

@@            Coverage Diff             @@
##             main    #1245      +/-   ##
==========================================
- Coverage   57.48%   57.19%   -0.30%
==========================================
  Files         127      127
  Lines       21348    21497     +149
==========================================
+ Hits        12272    12295      +23
- Misses       7583     7710     +127
+ Partials     1493     1492       -1

Impacted Files
Coverage Δ

cmd/mount_unix.go
49.12% <0.00%> (ø)

cmd/profile.go
11.20% <0.00%> (-0.05%)
:arrow_down:

pkg/chunk/disk_cache.go
34.23% <0.00%> (ø)

pkg/chunk/disk_store.go
64.58% <0.00%> (ø)

pkg/gateway/gateway.go
46.44% <0.00%> (+0.07%)
:arrow_up:

pkg/object/b2.go
2.17% <0.00%> (ø)

pkg/object/file.go
57.94% <0.00%> (ø)

pkg/object/hdfs.go
56.50% <0.00%> (ø)

pkg/object/oss.go
0.84% <0.00%> (ø)

pkg/object/s3.go
43.89% <0.00%> (-0.34%)
:arrow_down:

... and 15 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d58d73b...203191e. Read the comment docs.


set MALLOC_ARENA_MAX to a lower dynamic value to prevent OOM

The default behavior is 8x the number of detected CPUs . As Cloud
Foundry typically uses large host machines with smaller containers,
and the Java process is unaware of the difference in allocated CPUs,
the numbers are way off. This often leads to high native memory usage,
followed by a cgroup OOM killer event.
We go with Heroku's recommendation of lowering to a
setting of 2 for small instances. We also grown the setting linearly
with memory to be more in line with the default setting in Mendix
Cloud v3.
References:

https://github.com/cloudfoundry/java-buildpack/issues/163
https://devcenter.heroku.com/articles/testing-cedar-14-memory-use
https://github.com/cloudfoundry/java-buildpack/issues/320

@hansthen in CF, the amount of CPU shares (not cores) scales linearly with the amount of memory. See also CLD-2455. I would also be fine with hard-coding to 2 for now.

Since we don't have any real life measurements of actual usage of these memory areas (as opposed to allocation of them) and/or malloc/free and lock contention rates in hosted applications, it makes sense to do anything to at least take the first step to lower the limits to sensible levels that correspond to cpu/memory sizing of the container limits, compared with running the same in a normal OS.

What @knorrie said, +1 that.

discussed offline, we agreed on the current calculation


Add WTF character account copy

When creating a new character or changing a name you have to reset everything. Create a flag to perform a copy of a character account

Need to set ElvPrivateDB to "Default" before init login to set proper Private profile as ElvUI doesn't automatically default to default? Need to ask in their Discord

XFaction also sets the profile to char_name - server_name. Asked dev in https://github.com/Chalsean/XFaction/issues/331

We could create a WTF template that's scrubbed - probably the best bet for this


We need Metadata also.

Metadata about unique keys, auto increment, default value, base table name, data provider, data relations etc is ignored

Hi @softboy99, protobuf-net-data is a library for seriaizing portable tabular data. It is not intended to be a full serialization of all of ADO.NET's features. You can use the built-in CLR binary serialization or XML for that.

Hi,
your answer is so officail, of course, we can sue built-in on. Howerver, if there is no other technichal considrations, where there's so many third party libray? Just for money? Of cause not.


AV-427 Frontpage cache issues with recent, new and popular datasets

Information about recent, new and popular datasets visible in the front page is not cached anymore. Instead, the information is fetched using Drupal lazy_builder function.

Table row HTML generation is moved to the Drupal module file, because this was required to make the lazy_builder feature work.

If there are no datasets, an empty table is shown instead of a message about not having datasets to show. This way it was possible to have all the translatable content within Twig template and the Twig template has no way to know how many datasests the table will contain.

Otherwise fine but, codesniffer errors need to be fixed. Ansible lint check probably passes if you merge master.


[Feature][UI Next]Refactor Login to better match the composition API implementation

Purpose of the pull request
close #7518

Brief change log

Verify this pull request

This pull request is code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:

LGTM

CI failed and I restart it. Our PR could not be merged unless CI UT and Backend pass.

CI failed and I restart it. Our PR could not be merged unless CI UT and Backend pass.

Thx,done


Contract interaction with tuples not working

Title/Description
Contract interaction with tuples no working. (It works in the tx builder though)
Environment

Browser: Firefox
Safe: https://rinkeby.gnosis-safe.io/app/#/safes/0xaE3c91c89153DEaC332Ab7BBd167164978638c30/transactions
Wallet: Metamask
App Version: 2.17.0
Environment:

production (rinkeby)

Steps to reproduce

Open safe
Click contract interaction
Enter 0x36292b627eb637696c90edd460e49300b099d045 as target
Select func1
Enter [1,2]
Click "review"

Expected result
I end up on review screen and can send the tx
Obtained result
Error (see screenshot)
Screenshots
There is a nice screencase on here: https://github.com/gnosis/safe-react/issues/1028#issuecomment-756740584
Also:

So this is working for me, but if there is an error it is shown in the wrong field apparently

Abi used was
[
    {
      "anonymous": false,
      "inputs": [
        {
          "components": [
            {
              "internalType": "address",
              "name": "facetAddress",
              "type": "address"
            },
            {
              "internalType": "enum IDiamondCut.FacetCutAction",
              "name": "action",
              "type": "uint8"
            },
            {
              "internalType": "bytes4[]",
              "name": "functionSelectors",
              "type": "bytes4[]"
            }
          ],
          "indexed": false,
          "internalType": "struct IDiamondCut.FacetCut[]",
          "name": "_diamondCut",
          "type": "tuple[]"
        },
        {
          "indexed": false,
          "internalType": "address",
          "name": "_init",
          "type": "address"
        },
        {
          "indexed": false,
          "internalType": "bytes",
          "name": "_calldata",
          "type": "bytes"
        }
      ],
      "name": "DiamondCut",
      "type": "event"
    },
    {
      "inputs": [
        {
          "components": [
            {
              "internalType": "address",
              "name": "facetAddress",
              "type": "address"
            },
            {
              "internalType": "enum IDiamondCut.FacetCutAction",
              "name": "action",
              "type": "uint8"
            },
            {
              "internalType": "bytes4[]",
              "name": "functionSelectors",
              "type": "bytes4[]"
            }
          ],
          "internalType": "struct IDiamondCut.FacetCut[]",
          "name": "_diamondCut",
          "type": "tuple[]"
        },
        {
          "internalType": "address",
          "name": "_init",
          "type": "address"
        },
        {
          "internalType": "bytes",
          "name": "_calldata",
          "type": "bytes"
        }
      ],
      "name": "diamondCut",
      "outputs": [],
      "stateMutability": "nonpayable",
      "type": "function"
    }
  ]

Input value for the tuple array was
[["0x94D998c2Cb35bD4388D1D5Ed71992bF4a802d7a9", 0, ["0x00baddad", "0x00baddad", "0x00baddad"]]]

So this is working for me, but if there is an error it is shown in the wrong field apparently

Abi used was
[
    {
      "anonymous": false,
      "inputs": [
        {
          "components": [
            {
              "internalType": "address",
              "name": "facetAddress",
              "type": "address"
            },
            {
              "internalType": "enum IDiamondCut.FacetCutAction",
              "name": "action",
              "type": "uint8"
            },
            {
              "internalType": "bytes4[]",
              "name": "functionSelectors",
              "type": "bytes4[]"
            }
          ],
          "indexed": false,
          "internalType": "struct IDiamondCut.FacetCut[]",
          "name": "_diamondCut",
          "type": "tuple[]"
        },
        {
          "indexed": false,
          "internalType": "address",
          "name": "_init",
          "type": "address"
        },
        {
          "indexed": false,
          "internalType": "bytes",
          "name": "_calldata",
          "type": "bytes"
        }
      ],
      "name": "DiamondCut",
      "type": "event"
    },
    {
      "inputs": [
        {
          "components": [
            {
              "internalType": "address",
              "name": "facetAddress",
              "type": "address"
            },
            {
              "internalType": "enum IDiamondCut.FacetCutAction",
              "name": "action",
              "type": "uint8"
            },
            {
              "internalType": "bytes4[]",
              "name": "functionSelectors",
              "type": "bytes4[]"
            }
          ],
          "internalType": "struct IDiamondCut.FacetCut[]",
          "name": "_diamondCut",
          "type": "tuple[]"
        },
        {
          "internalType": "address",
          "name": "_init",
          "type": "address"
        },
        {
          "internalType": "bytes",
          "name": "_calldata",
          "type": "bytes"
        }
      ],
      "name": "diamondCut",
      "outputs": [],
      "stateMutability": "nonpayable",
      "type": "function"
    }
  ]

Input value for the tuple array was
[["0x94D998c2Cb35bD4388D1D5Ed71992bF4a802d7a9", 0, ["0x00baddad", "0x00baddad", "0x00baddad"]]]

Hey @rmeissner thanks for the inputs, could you send me the contract address that you used for testing those input values?

Hey @rmeissner thanks for the inputs, could you send me the contract address that you used for testing those input values?

I didn't use any contract address, why would this be required? You can just paste the abi into the abi field and set any address. The tx would fail if you try to execute it, but that should not be required to test this anyways.

I didn't use any contract address, why would this be required? You can just paste the abi into the abi field and set any address. The tx would fail if you try to execute it, but that should not be required to test this anyways.

I didn't use any contract address, why would this be required? You can just paste the abi into the abi field and set any address. The tx would fail if you try to execute it, but that should not be required to test this anyways.

Just asked because I would like to have a real example to test if it's working or not (including sending the data to the contract) :)

I didn't use any contract address, why would this be required? You can just paste the abi into the abi field and set any address. The tx would fail if you try to execute it, but that should not be required to test this anyways.

Just asked because I would like to have a real example to test if it's working or not (including sending the data to the contract) :)

including sending the data to the contract

Won't web3 throw an error in case it's invalid? (Just curious)

including sending the data to the contract

Won't web3 throw an error in case it's invalid? (Just curious)

Yes that's correct, just wanted to improve the validation client side

Yes that's correct, just wanted to improve the validation client side

Yes that's correct, just wanted to improve the validation client side

Might try digging in web3.js code

Yes that's correct, just wanted to improve the validation client side

Might try digging in web3.js code

Ok, this was confusing to test until I read the contract itself, the one provided in the issue
https://rinkeby.etherscan.io/address/0x36292b627eb637696c90edd460e49300b099d045#code
Technically a "tuple" is a collection of values, that can be any type of values and any amount of values, but in this case it seems that the contract expect a specific tuple to be introduced depending on the function you use, so is not just "enter a tuple of what ever you want" since it was what the place holder implies since it doesn't tell you the types of values you can enter.
For that contract in specific the tuples are:
func1: [uint16, uint16]
func2: [address, uint16]
func3: [address, address]
So I tried all 3 examples and it worked fine
https://pr1787--safereact.review.gnosisdev.com/rinkeby/app/#/safes/0x4B1b5434168e37C3af3c32Ed176E07Cdd02f3cA0/transactions

Ok, this was confusing to test until I read the contract itself, the one provided in the issue
https://rinkeby.etherscan.io/address/0x36292b627eb637696c90edd460e49300b099d045#code
Technically a "tuple" is a collection of values, that can be any type of values and any amount of values, but in this case it seems that the contract expect a specific tuple to be introduced depending on the function you use, so is not just "enter a tuple of what ever you want" since it was what the place holder implies since it doesn't tell you the types of values you can enter.
For that contract in specific the tuples are:
func1: [uint16, uint16]
func2: [address, uint16]
func3: [address, address]
So I tried all 3 examples and it worked fine
https://pr1787--safereact.review.gnosisdev.com/rinkeby/app/#/safes/0x4B1b5434168e37C3af3c32Ed176E07Cdd02f3cA0/transactions


[BUG]the Dingtalk link is error in the kubedl docs

https://kubedl.io/docs/help

clicking this link is error.
thanks

@d821776892 hi, it seems dingtalk link has expired, I will refresh a new one.

@d821776892 hi, the latest dingtalk QR code has been uploaded, please checkout


Routed .tree 'comments' input through talk

Requires %eyre reload
Wants further testing before being announced / used in public-facing material

What does that mean? Keep it off the network, keep it off urbit.org?

Keep md files with

comments: y
off urbit.org, as previously when this functionality lived purely in
/+write. @galenwp this should otherwise be deployed yes?
On Monday, 29 February 2016, Raymond Pasco<EMAIL_ADDRESS>wrote:

What does that mean? Keep it off the network, keep it off urbit.org?
—
Reply to this email directly or view it on GitHub
https://github.com/urbit/arvo/pull/36#issuecomment-190407142.

There’s no risk of deploying this to anything public accidentally.  This is good to go, as far as I know.

On Feb 29, 2016, at 1:39 PM, Anton Dyudin<EMAIL_ADDRESS>wrote:
Keep md files with

comments: y
off urbit.org, as previously when this functionality lived purely in
/+write. @galenwp this should otherwise be deployed yes?
On Monday, 29 February 2016, Raymond Pasco<EMAIL_ADDRESS>wrote:

What does that mean? Keep it off the network, keep it off urbit.org?
—
Reply to this email directly or view it on GitHub
https://github.com/urbit/arvo/pull/36#issuecomment-190407142.

—
Reply to this email directly or view it on GitHub https://github.com/urbit/arvo/pull/36#issuecomment-190407637.


CLI session closed when using a derivation path with "" or '' with Trezor hardware wallet

Describe the bug
Small issue where the CLI will crash when either "" or '' are used when trying to load an address from a derivation path on Trezor.
To Reproduce
Example command:
load_trezor_cli_owners --legacy-accounts --derivation-path "44'/60'/0'/0"

Expected behavior
Return an error, same as with ledger:
load_ledger_cli_owners --legacy-accounts --derivation-path "44'/60'/0'/0"
HwDevice exception: The provided derivation path is not valid

Current behaviour
The CLI crashes

The CLI is not crashing but I'm still adding support for double quoting because looks like the natural behavior of an user.
#414

Working like a charm, thank you caballero


Document that telemetry measures are reported in nanoseconds?

Environment

Elixir version (elixir -v): 1.8.2
Database and version (PostgreSQL 9.4, MongoDB 3.2, etc.): PostgreSQL 11.2
Ecto version (mix deps): 3.1.6
Database adapter and version (mix deps): ecto_sql 3.1.1 and postgrex 0.14.0
Operating system: MacOS 10.14

Current behavior
I'm using ecto 3.1.6, ecto_sql 3.1.1 and postgrex 0.14.0 with PostgreSQL 11.2.
When I add an IO.inspect here, a particular query shows :query_time of 2587 μs. But the telemetry measurements reported to my handler show query_time: 2587000. So it appears to me that the times are being reported in nanoseconds. I don't see this documented anywhere.
Expected behavior
I would like to document somewhere that the measurements are in nanoseconds, as it took me some puzzling to figure this out. Can someone advise me on where that documentation should go? So far I don't see where these numbers are actually generated.

The measurements are in a closer unspecified "native" units, that offer the highest resolution on a particular system. You have to convert to real units with System.convert_time_unit/3. FWIW this is how almost everything reports time measurements in Elixir, but I agree we should improve the documentation to mention this.

Is ecto_sql the right project to document this on, or should the docs go on postgrex?

While I'm at it, I'd also like to document the meaning of the keys: :decode_time, :query_time, :queue_time, :total_time. I think that:

:decode_time would be the time required for Ecto to build the SQL query
:queue_time, the amount of time waiting to check outon a database connection from the pool
:query_time would be the amount of time to actually run that query once we have a connection
:total_time would be all of the above added up

A PR is welcome! We document those events in Ecto.Repo in the ecto repo!

Only one correction: decode_time is the time to decode the data received from the database

Thanks! I will make a PR to add detail on Ecto.Repo

We could probably largely re-use the documentation of the deprecated Ecto.LogEntry struct - most things stayed similar https://hexdocs.pm/ecto/3.0.9/Ecto.LogEntry.html#content

See PR above


scm_hosts plugin: hosts detecting improved by also checking 'ansible_fqdn'…

… (can be different than 'inventory_hostname' p.eg. on AWS hosts)

LGTM - thanks @lhoss


Add 'metadata' option to include @metadata field in output

Just like the rubydebug codec, being able to include the @metadata field in the output of the json_lines codec can be useful, for example for debugging or test tools that prefer machine-readable output. Fixes #23.
I'm not sure exactly when the .to_json_with_metadata method was added and whether we need to bump any gem dependencies so please have a look at that.
Added a minor version bump in the hopes that you'll be able to make a new release soon.

I'm kind of uncertain about this change. The intent of event metadata was for having things that only live within a single Logstash instance and would never be shipped externally. Shipping metadata externally breaks this expectation.
Can you help me understand your use case? Beyond that, my questions about this would start with this one: Why do you need to ship @metadata-- why not name the field something else?

For clarification on the rubydebug codec: rubydebug can include metadata because the intent of that codec is to output an event for debugging purposes, so in debugging an event, it can be useful to have the metadata.

The use case is any non-human debugging or testing tool that doesn't find the rubydebug output very compelling to parse. Specifically, I want to be able to use Logstash Filter Verifier to verify that @metadata fields get the correct values. Those fields are frequently used to e.g. set options in outputs so it's relevant to be able to verify their contents.

@magnusbaeck @jordansissel FWIW I really like this idea.
I don't see how making it a non-default option would be problematic.

If everyone's happy with this change I can rebase my branch and make it ready for merging.

@magnusbaeck I'd like to get an LGTM for @jordansissel before proceeding.

I agree with the usefulness in debugging, and the use case here makes sense if there's no other way to debug a filter configuration.
On the other hand, I am trying to remove to_json_with_metadataand its hash friendto_hash_with_metadata` from Logstash 5.0 and onward, so this feature, as it stands, won't work in 5.0. If anything, it'll be deprecated in 5.0 and removed later because the API ("to json with metadata") feels wrong to me.
Given I want to remove the APIs mentioned, I try to think about what could be next for your verifier -- This verifier could be an output plugin, or a custom pipeline implementation, instead of an external tool, which would give you access to the Event object and its metadata. I'm mostly brainstorming here ... Thoughts?

So.. Ehhh. I'm on the fence. I really want to_json_with_metadata to disappear, but I like your use case and want to support it.
If we can make to_json_with_metadata (or to_hash_with_metadata) deprecated on 5.0, and figure out how to keep supporting this use case without those methods, does that sound like an OK plan to you, @magnusbaeck? If so, I am +1 on this PR.

FWIW, I am a +1 for this particular use case because at some point, I'd love to use Logstash Filter Verifier in our test suite :)

@suyograo I think we can achieve verification without outputting @metadata, but I want to keep @magnusbaeck's work alive until we come up with that solution <3

Okay, so it sounds like it'd be worthwhile for me to rebase the branch then. How about merging #25 first so that I can include that change in this PR's changelog update?

Alright, so to_json_with_metadata is already gone in the master branch of elastic/logstash.git so this patch won't work after a rebase. Should that method be reinstated then (but marked as deprecated)? And will you do that so that we can move forward?

@magnusbaeck sorry for the delays.
We have Event#to_hash_with_metadata that you could call and take that object and serialize it to json.

I really would like to see this PR to make progress to be able to finally have access to the @metadata in Logstash Filter Verifier (see https://github.com/magnusbaeck/logstash-filter-verifier/issues/5).


Postgres connection error

I'm trying to set up an Ambiverse REST endpoint on one of our servers so we can query it locally. So far the setup is rather easy, the Postgres database is running with the imported AIDA dump and the maven build succeeded.
However, when starting the web_service.sh, ambiverse fails to establish a connection ( it logs timeout warnings ).
2019-03-18 16:17:01,577 [main] INFO nlu.entitylinking.EntityLinkingManager:206  - Postgres DB seems unavailable. This is expected during first startup using Docker. Waiting for 60s in addition (already waited 0s, will wait up to 10800s in total).

To figure out what's going on, I checked whether all config parameters are used by the code correctly and also added prop.put("dataSource.logWriter", new PrintWriter(System.out)); to get a more verbose log of the database connection library. Everything seems fine, however loginTimeout=0 and socketTimeout=0 seems odd. Changing it to a non-zero value doesn't change the behaviour, where the library quickly logs a lot of connection attempts.
To check if anything gets to the postgres server, I configured it to log everything:
2019-03-18 16:16:52.753 CET [5573] [unknown]@[unknown] LOG:  00000: connection received: host=<IP_ADDRESS> port=40314
2019-03-18 16:16:52.753 CET [5573] [unknown]@[unknown] LOCATION:  BackendInitialize, postmaster.c:4205
2019-03-18 16:16:52.754 CET [5573] ambiverse@aida_20180120_cd_de_en_es_ru_zh_v18 LOG:  00000: connection authorized: user=ambiverse database=aida_20180120_cd_de_en_es_ru_zh_v18
2019-03-18 16:16:52.754 CET [5573] ambiverse@aida_20180120_cd_de_en_es_ru_zh_v18 LOCATION:  PerformAuthentication, postinit.c:279
2019-03-18 16:16:52.757 CET [5573] ambiverse@aida_20180120_cd_de_en_es_ru_zh_v18 LOG:  00000: disconnection: session time: 0:00:00.004 user=ambiverse database=aida_20180120_cd_de_en_es_ru_zh_v18 host=<IP_ADDRESS> port=40314
2019-03-18 16:16:52.757 CET [5573] ambiverse@aida_20180120_cd_de_en_es_ru_zh_v18 LOCATION:  log_disconnections, postgres.c:4614
2019-03-18 16:16:53.760 CET [5593] [unknown]@[unknown] LOG:  00000: connection received: host=<IP_ADDRESS> port=40316
2019-03-18 16:16:53.760 CET [5593] [unknown]@[unknown] LOCATION:  BackendInitialize, postmaster.c:4205
2019-03-18 16:16:53.762 CET [5593] ambiverse@aida_20180120_cd_de_en_es_ru_zh_v18 LOG:  00000: connection authorized: user=ambiverse database=aida_20180120_cd_de_en_es_ru_zh_v18
2019-03-18 16:16:53.762 CET [5593] ambiverse@aida_20180120_cd_de_en_es_ru_zh_v18 LOCATION:  PerformAuthentication, postinit.c:279
2019-03-18 16:16:53.767 CET [5593] ambiverse@aida_20180120_cd_de_en_es_ru_zh_v18 LOG:  00000: disconnection: session time: 0:00:00.006 user=ambiverse database=aida_20180120_cd_de_en_es_ru_zh_v18 host=<IP_ADDRESS> port=40316
2019-03-18 16:16:53.767 CET [5593] ambiverse@aida_20180120_cd_de_en_es_ru_zh_v18 LOCATION:  log_disconnections, postgres.c:4614
2019-03-18 16:16:54.770 CET [5635] [unknown]@[unknown] LOG:  00000: connection received: host=<IP_ADDRESS> port=40318
2019-03-18 16:16:54.770 CET [5635] [unknown]@[unknown] LOCATION:  BackendInitialize, postmaster.c:4205
2019-03-18 16:16:54.772 CET [5635] ambiverse@aida_20180120_cd_de_en_es_ru_zh_v18 LOG:  00000: connection authorized: user=ambiverse database=aida_20180120_cd_de_en_es_ru_zh_v18
2019-03-18 16:16:54.772 CET [5635] ambiverse@aida_20180120_cd_de_en_es_ru_zh_v18 LOCATION:  PerformAuthentication, postinit.c:279
2019-03-18 16:16:54.777 CET [5635] ambiverse@aida_20180120_cd_de_en_es_ru_zh_v18 LOG:  00000: disconnection: session time: 0:00:00.006 user=ambiverse database=aida_20180120_cd_de_en_es_ru_zh_v18 host=<IP_ADDRESS> port=40318
2019-03-18 16:16:54.777 CET [5635] ambiverse@aida_20180120_cd_de_en_es_ru_zh_v18 LOCATION:  log_disconnections, postgres.c:4614

(yes, my user isn't ambiversenlu, it's just ambiverse).
Connecting to the server from pgadmin looks exactly the same in the logs, except that it doesn't immediately disconnect again.
I have tried a lot, but I guess it boils down to the scenario described above, where the database connection isn't staying alive. I have tried the git version tagged 1.0 and 1.1 as well as current master.
% cat /etc/lsb-release
DISTRIB_ID=Ubuntu
DISTRIB_RELEASE=18.04
DISTRIB_CODENAME=bionic

% psql --version
psql (PostgreSQL) 11.2 (Ubuntu 11.2-1.pgdg18.04+1)

% mvn -version
Apache Maven 3.5.2
Maven home: /usr/share/maven
Java version: 1.8.0_201, vendor: Oracle Corporation
Java home: /usr/lib/jvm/java-8-oracle/jre
Default locale: en_US, platform encoding: UTF-8
OS name: "linux", version: "4.15.0-32-generic", arch: "amd64", family: "unix"

I'm not using Docker but used the Dockerfiles as setup instructions. Not sure what the error is, the project compiles without errors, it runs without errors until it get's caught in the loop waiting for a DB connection. The connection is established (as logs suggest) but immediately closed. Using Docker wouldn't fix that I guess...

Could it be a typo? The db is called aida_20180120_cs_de_en_es_ru_zh_v18 (note the cs not cd)

@hoffart thanks for the sharp eye. unfortunately the typo already happened when I created the database. so in this case it is spelled correctly.

One thing that I can think of is that maybe the driver version we use in the .pom is not compatible with the server version. We use postgresql 9.4 and I see you are using 11.2. Try changing the driver version (not sure what other changes might this require) or downgrade the server version (if you are using docker).

When you use the command from the README, the Postgres container does not start correctly, because it cannot download the dump files:
docker run -d --name nlu-db-postgres \
  -p 5432:5432 \
  -e POSTGRES_DB=aida_20180120_b3_de_en_v18_db \
  -e POSTGRES_USER=ambiversenlu \
  -e POSTGRES_PASSWORD=ambiversenlu \
  ambiverse/nlu-db-postgres

The container trys to do download the dump from:

http://ambiversenlu-download.mpi-inf.mpg.de/postgres/aida_20180120_b3_de_en_v18_db.sql.gz
correct is (with out _db): http://ambiversenlu-download.mpi-inf.mpg.de/postgres/aida_20180120_b3_de_en_v18.sql.gz

I fixed this by changing the Postgres database name to aida_20180120_b3_de_en_v18:
docker run -d --name nlu-db-postgres \
  -p 5432:5432 \
  -e POSTGRES_DB=aida_20180120_b3_de_en_v18 \
  -e POSTGRES_USER=ambiversenlu \
  -e POSTGRES_PASSWORD=ambiversenlu \
  ambiverse/nlu-db-postgres

Also, I changed the database hostname <IP_ADDRESS> in the corresponding config file src/main/config/aida_20180120_b3_de_en_v18_db/database_aida.properties. Sometimes containers are not reachable with localhost.

Using the database name aida_20180120_b3_de_en_v18 works as mentioned by @malteos but for the database aida_20180120_cs_de_en_es_ru_zh_v18 I still get the postgres connection error.

2019-04-29 19:13:17,642 [main] WARN  hadoop.util.NativeCodeLoader:62  - Unable to load native-hadoop library for your platform... using builtin-java classes where applicable
2019-04-29 19:13:17,981 [main] INFO  internal.logging.Slf4JLogger:101  - Your platform does not provide complete low-level API for accessing direct buffers reliably. Unless explicitly requested, heap buffer will always be preferred to avoid potential system unstability.
2019-04-29 19:13:18,620 [sparkDriverActorSystem-akka.actor.default-dispatcher-3] INFO  event.slf4j.Slf4jLogger$$anonfun$receive$1$$anonfun$applyOrElse$3:74  - Starting remoting
2019-04-29 19:13:18,859 [sparkDriverActorSystem-akka.actor.default-dispatcher-3] INFO  event.slf4j.Slf4jLogger$$anonfun$receive$1$$anonfun$applyOrElse$3:74  - Remoting started; listening on addresses :[akka.tcp://sparkDriverActorSystem@<IP_ADDRESS>:33687]
2019-04-29 19:13:23,651 [sparkDriverActorSystem-akka.actor.default-dispatcher-4] INFO  event.slf4j.Slf4jLogger$$anonfun$receive$1$$anonfun$applyOrElse$3:74  - Shutting down remote daemon.
2019-04-29 19:13:23,653 [sparkDriverActorSystem-akka.actor.default-dispatcher-4] INFO  event.slf4j.Slf4jLogger$$anonfun$receive$1$$anonfun$applyOrElse$3:74  - Remote daemon shut down; proceeding with flushing remote transports.
2019-04-29 19:13:23,764 [sparkDriverActorSystem-akka.actor.default-dispatcher-4] INFO  event.slf4j.Slf4jLogger$$anonfun$receive$1$$anonfun$applyOrElse$3:74  - Remoting shut down.
2019-04-29 19:13:58,194 [main] INFO  nlu.entitylinking.EntityLinkingManager:206  - Postgres DB seems unavailable. This is expected during first startup using Docker. Waiting for 60s in addition (already waited 0s, will wait up to 10800s in total).
2019-04-29 19:15:28,196 [main] INFO  nlu.entitylinking.EntityLinkingManager:206  - Postgres DB seems unavailable. This is expected during first startup using Docker. Waiting for 60s in addition (already waited 60s, will wait up to 10800s in total).
2019-04-29 19:16:58,198 [main] INFO  nlu.entitylinking.EntityLinkingManager:206  - Postgres DB seems unavailable. This is expected during first startup using Docker. Waiting for 60s in addition (already waited 120s, will wait up to 10800s in total).

aida_20180120_cs_de_en_es_ru_zh_v18 is much larger database than aida_20180120_b3_de_en_v18.
I am able to connect manually through psql manually using the correct database credentials and server hosts (both as <IP_ADDRESS>, <IP_ADDRESS>) but it fails when I run the start_webservice.sh
Could someone help triage this? It seems like start_webservice.sh is broken when we use a larger database specified above, but it works for all other smaller configurations. As I see in the following issue: https://github.com/ambiverse-nlu/ambiverse-nlu/issues/4 only way to replicate the behaviour at https://ambiversenlu.mpi-inf.mpg.de/ is to use the aida_20180120_cs_de_en_es_ru_zh_v18. FYI I am unable to simulate the behaviour in the above demo page by using the small database dump at aida_20180120_b3_de_en_v18 (I got some entities missing when I compared to the demo)
Any thoughts?

The demo is using the full database, so results are not replicable using the small database.
How long did you wait in total for the database? It is downloading/unpacking/importing/indexing a 100GB data file, this can take a couple of hours.

I downloaded the database dump and imported it to Postgres. So the import and db startup is already done before starting the ambiverse scripts. Importing did take quite a while but I didn't stop the time. I started it on the server and let it run over night.
Changing the driver version doesn't fully work straight away unfortunately - I'd have to fix some deprecation. Once I have time to look into this again, I'll make sure to push the updated sources if I manage to fix it.

I meet the same problem with you, have u got any solution for this issues now?

Hi @dylanhouxinglin ,
actually, I did not. I kept on trying for a while, gave up, and used their demo server by spreading requests over a few days.

What is the request looks like?


[Bug]: Doesn't show the body of popover

Is there an existing issue for this?

[X] I have searched the existing issues

Current Behavior
There were existing bugs on this, but none were from the body of the scaffold. This is happening even in the body of a scaffold. When, I am clicking the button, I just see the app becoming grayish and that's all. No popup menu. This happens with my code only. How ever I try. Even if I just copy paste the code from the example folder. But, when I run from the example folder everything is fine.
Expected Behavior
There should be a popup.
What operating system are you seeing the problem on?
Linux, Android
Relevant log output
import 'package:flutter/material.dart';
import 'package:popover/popover.dart';

void main() {
  runApp(const MyApp());
}

class MyApp extends StatelessWidget {
  const MyApp({super.key});

  // This widget is the root of your application.
  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      title: 'Flutter Demo',
      theme: ThemeData(
        // This is the theme of your application.
        //
        // TRY THIS: Try running your application with "flutter run". You'll see
        // the application has a purple toolbar. Then, without quitting the app,
        // try changing the seedColor in the colorScheme below to Colors.green
        // and then invoke "hot reload" (save your changes or press the "hot
        // reload" button in a Flutter-supported IDE, or press "r" if you used
        // the command line to start the app).
        //
        // Notice that the counter didn't reset back to zero; the application
        // state is not lost during the reload. To reset the state, use hot
        // restart instead.
        //
        // This works for code too, not just values: Most code changes can be
        // tested with just a hot reload.
        colorScheme: ColorScheme.fromSeed(seedColor: Colors.deepPurple),
        useMaterial3: true,
      ),
      home: const MyHomePage(title: 'Flutter Demo Home Page'),
    );
  }
}

class MyHomePage extends StatelessWidget {
  const MyHomePage({super.key, required this.title});

  // This widget is the home page of your application. It is stateful, meaning
  // that it has a State object (defined below) that contains fields that affect
  // how it looks.

  // This class is the configuration for the state. It holds the values (in this
  // case the title) provided by the parent (in this case the App widget) and
  // used by the build method of the State. Fields in a Widget subclass are
  // always marked "final".

  final String title;

  @override
  Widget build(BuildContext context) {
    // This method is rerun every time setState is called, for instance as done
    // by the _incrementCounter method above.
    //
    // The Flutter framework has been optimized to make rerunning build methods
    // fast, so that you can just rebuild anything that needs updating rather
    // than having to individually change instances of widgets.
    return Scaffold(
      appBar: AppBar(
        // TRY THIS: Try changing the color here to a specific color (to
        // Colors.amber, perhaps?) and trigger a hot reload to see the AppBar
        // change color while the other colors stay the same.
        backgroundColor: Theme.of(context).colorScheme.inversePrimary,
        // Here we take the value from the MyHomePage object that was created by
        // the App.build method, and use it to set our appbar title.
        title: Text(title),
      ),
      body: Center(
        // Center is a layout widget. It takes a single child and positions it
        // in the middle of the parent.
        child: Center(
          // Column is also a layout widget. It takes a list of children and
          // arranges them vertically. By default, it sizes itself to fit its
          // children horizontally, and tries to be as tall as its parent.
          //
          // Column has various properties to control how it sizes itself and
          // how it positions its children. Here we use mainAxisAlignment to
          // center the children vertically; the main axis here is the vertical
          // axis because Columns are vertical (the cross axis would be
          // horizontal).
          //
          // TRY THIS: Invoke "debug painting" (choose the "Toggle Debug Paint"
          // action in the IDE, or press "p" in the console), to see the
          // wireframe for each widget.

          child: IconButton(
            onPressed: () {
              showPopover(
                backgroundColor: Colors.red,
                height: 100,
                width: 100,
                context: context,
                bodyBuilder: (context) => const Dialog(
                  backgroundColor: Colors.red,
                ),
              );
            },
            icon: const Icon(Icons.add),
          ),
        ),
      ),
    );
  }
}

Anything else?
My pubspec.yaml file
name: test
description: "A new Flutter project."
# The following line prevents the package from being accidentally published to
# pub.dev using `flutter pub publish`. This is preferred for private packages.
publish_to: 'none' # Remove this line if you wish to publish to pub.dev
version: 1.0.0+1

environment:
  sdk: '>=3.2.3 <4.0.0'

dependencies:
  flutter:
    sdk: flutter
  cupertino_icons: ^1.0.2
  popover: ^0.2.8+2

dev_dependencies:
  flutter_test:
    sdk: flutter
  flutter_lints: ^2.0.0

flutter:
  uses-material-design: true

And my flutter doctor output
Doctor summary (to see all details, run flutter doctor -v):
[✓] Flutter (Channel stable, 3.16.3, on Ubuntu 23.10 6.5.0-13-generic, locale
    en_US.UTF-8)
[!] Android toolchain - develop for Android devices (Android SDK version 34.0.0)
    ✗ cmdline-tools component is missing
      Run `path/to/sdkmanager --install "cmdline-tools;latest"`
      See https://developer.android.com/studio/command-line for more details.
    ✗ Android license status unknown.
      Run `flutter doctor --android-licenses` to accept the SDK licenses.
      See https://flutter.dev/docs/get-started/install/linux#android-setup for
      more details.
[✓] Chrome - develop for the web
[✓] Linux toolchain - develop for Linux desktop
[✓] Android Studio (version 2023.1)
[✓] Connected device (2 available)
[✓] Network resources

! Doctor found issues in 1 category.

Code of Conduct

[X] I agree to follow this project's Code of Conduct

I have no idea why is this bug even happening. I am kinda newbiew. So, atleast guide me on the debugging. Are you atleast able to reproduce it?

@soumyaDghosh I don't have a Linux machine now. On the macOS example, the project works as expected for all targets.
Can you run it on your machine, please? Could you make sure that you're on a stable channel?

As I said in my issue, the example works but not after I copy paste the code to my project. Kindly check if you can run this given test code.

I am facing the same issue @soumyaDghosh , did you fix this?

I am facing the same issue @soumyaDghosh , did you fix this?

Nah.. I just left this for now

@minikin fix this bug.

I understand this bug can be frustrating. Unfortunately, I can't commit to a fix due to limited resources or other priorities. However, I encourage you or others to contribute a fix via a pull request.

I think the problem is that you are using the context of the build method of your home page. Try wrapping your button in a stateless widget and using the context of that widget. @soumyaDghosh

I think the problem is that you are using the context of the build method of your home page. Try wrapping your button in a stateless widget and using the context of that widget. @soumyaDghosh

Thank you... I'll get it a look

I think the problem is that you are using the context of the build method of your home page. Try wrapping your button in a stateless widget and using the context of that widget. @soumyaDghosh

Thanks, this solves the issue perfectly.

I think the problem is that you are using the context of the build method of your home page. Try wrapping your button in a stateless widget and using the context of that widget. @soumyaDghosh

This solution is working flawlessly, thank you.


Add a test that fails

Description
Problem
Resolves #6588
Summary
There's no fix yet, but at least with @aakoshh we were able to narrow down the issue.
Additional Context
Documentation*
Check one:

[ ] No documentation needed.
[ ] Documentation included in this PR.
[ ] [For Experimental Features] Documentation to be submitted in a separate PR.

PR Checklist*

[ ] I have tested the changes locally.
[ ] I have formatted the changes with Prettier and/or cargo fmt on default settings.

Nice! Good find.

@asterite @aakoshh Can you pull these fixes into https://github.com/AztecProtocol/aztec-packages/pull/9972?


feat(package): Remove yarn with npm

Summary

Test plan

Snuck this change in to React Boilterplate PR


Dab miniv3 not updating data

After the update tp2024.3.2 the data isn't updating.
New error
Logger: homeassistant.components.sensor
Source: helpers/entity_platform.py:352
Integration: Sensor (documentation, issues)
First occurred: 12:07:47 pm (1 occurrences)
Last logged: 12:07:47 pm
Error while setting up dabpumps platform for sensor
Traceback (most recent call last):
File "/usr/src/homeassistant/homeassistant/helpers/entity_platform.py", line 352, in _async_setup_platform
await asyncio.gather(*pending)
File "/usr/src/homeassistant/homeassistant/helpers/entity_platform.py", line 533, in async_add_entities
await asyncio.gather(*tasks)
File "/usr/src/homeassistant/homeassistant/helpers/entity_platform.py", line 782, in _async_add_entity
await entity.add_to_platform_finish()
File "/usr/src/homeassistant/homeassistant/helpers/entity.py", line 1325, in add_to_platform_finish
self.async_write_ha_state()
File "/usr/src/homeassistant/homeassistant/helpers/entity.py", line 989, in async_write_ha_state
self._async_write_ha_state()
File "/usr/src/homeassistant/homeassistant/helpers/entity.py", line 1110, in _async_write_ha_state
state, attr, capabilities, shadowed_attr = self.__async_calculate_state()
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/src/homeassistant/homeassistant/helpers/entity.py", line 1047, in __async_calculate_state
state = self._stringify_state(available)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/src/homeassistant/homeassistant/helpers/entity.py", line 995, in _stringify_state
if (state := self.state) is None:
^^^^^^^^^^
File "/usr/src/homeassistant/homeassistant/components/sensor/init.py", line 558, in state
raise ValueError(
ValueError: Sensor sensor.esybox_mini_v3_samplerate has a unit of measurement and thus indicating it has a numeric value; however, it has the non-numeric device class: enum

Lucklily an easy fix. Now available in release v2024.03.3
I've had to change a lot of code to support new functionaly for PowerShower and SleepMode. So more bugs may popup for other pumps that I did not find with my ESybox.
Just keep reporting them as they come up and I'll fix them as soon as possible.


Remove Stock text snippet from satellite sites

Can we please remove the "Stock API: NYSE time delay message" text snippet' from satellite sites. It is only relevant for the stock graphs, which only is in use on our investors page (in the global site).

@fernandolucchesi @padms @millianapia
This is ready for review. I could have solved this with existing flags like IS_GLOBAL_PROD || IS_DEV - but this seemed more elegant and may be useful in the future.

left a comment :d

Fixed!

Looks good! :)


Support for per-message duration

Hi
It would be cool if the module would support configuring the duration for a message individually. At the moment one can only set the duration globally for any message. Adding duration as an optional property to the objects argument of notify(), that, if set, overwrites the global duration, seems to be what is needed to enable this.
Thanks

I came across the same issue and therefore forked the repository and added it myself.
You can find the changes in my pull request to this repositoy: https://github.com/cgross/angular-notify/pull/15
If you need it immediately before my changes get pulled, then simply use my fork: https://github.com/snrlx/angular-notify
If you encounter any problems, please let me know :)

+1


Console: Alerts refactoring

The code is less fragmented, is using  shared services/directives/controllers and is much more clear in general. + contains several bug fixes.

I have made my comments. Merging since there are many changes that might conflict with what I'm working on.


Fix: 1. should not trim Config's empty line;     2. if no registry dir exist in AppImage, should skip scp it.

should not trim Config's empty line;
if no registry dir exist in AppImage, should skip scp it.

Signed-off-by: huaiyou<EMAIL_ADDRESS>
Describe what this PR does / why we need it
Does this pull request fix one issue?

Describe how you did it
Describe how to verify it
Special notes for reviews

/LGTM


Todoist MVP Implementation

Objective : link Todoist to the board and have a consolidate vision of the project we want / need.
Features :
1 -  Link account to Todoist with oAuth2
2 - Add a panel with the upcoming task
3 - Add the possibility to close the task if completed or to open it as a target blank page for more changes.
4 - Add a panel with a custom query (project / date / filterId ...)

Sounds like a good MVP-route - from a most basic implementation (upcoming tasks) to a more advanced one (custom query) 👍


Cannot retrieve model versions in the Model Registry

I'm unable to retrieve the versions of an artifact on the Model Registry. The same code works in a regular wandb projects but doesn't work for the model-registry. It doesn't understand the model_type to be valid.
Within the original project where this model has been linked from, the command does work (with the same model type).

Trace:
ValueError                                Traceback (most recent call last)
/databricks/python/lib/python3.8/site-packages/wandb/apis/normalize.py in wrapper(*args, **kwargs)
     24         try:
---> 25             return func(*args, **kwargs)
     26         except requests.HTTPError as err:

/databricks/python/lib/python3.8/site-packages/wandb/apis/public.py in artifact_versions(self, type_name, name, per_page)
    892         artifact_type = ArtifactType(self.client, entity, project, type_name)
--> 893         return artifact_type.collection(collection_name).versions(per_page=per_page)
    894

/databricks/python/lib/python3.8/site-packages/wandb/apis/public.py in collection(self, name)
   3718     def collection(self, name):
-> 3719         return ArtifactCollection(
   3720             self.client, self.entity, self.project, name, self.type

/databricks/python/lib/python3.8/site-packages/wandb/apis/public.py in __init__(self, client, entity, project, name, type, attrs)
   3735         if self._attrs is None:
-> 3736             self.load()
   3737

/databricks/python/lib/python3.8/site-packages/wandb/apis/public.py in load(self)
   3790         ):
-> 3791             raise ValueError("Could not find artifact type %s" % self.type)
   3792         self._attrs = response["project"]["artifactType"]["artifactSequence"]

ValueError: Could not find artifact type model

During handling of the above exception, another exception occurred:

CommError                                 Traceback (most recent call last)
<ipython-input-115-d4f262d7ee43> in <module>
      4 artifact_type = "model"
      5
----> 6 artifact_vers = api.artifact_versions(artifact_type, 'util-co/model-registry/relationship-classification')
      7
      8 for version in artifact_vers:

/databricks/python/lib/python3.8/site-packages/wandb/apis/normalize.py in wrapper(*args, **kwargs)
     59                 raise
     60             else:
---> 61                 raise CommError(message, err).with_traceback(sys.exc_info()[2])
     62
     63     return wrapper

/databricks/python/lib/python3.8/site-packages/wandb/apis/normalize.py in wrapper(*args, **kwargs)
     23         message = "Whoa, you found a bug."
     24         try:
---> 25             return func(*args, **kwargs)
     26         except requests.HTTPError as err:
     27             raise CommError(err.response, err)

/databricks/python/lib/python3.8/site-packages/wandb/apis/public.py in artifact_versions(self, type_name, name, per_page)
    891         entity, project, collection_name = self._parse_artifact_path(name)
    892         artifact_type = ArtifactType(self.client, entity, project, type_name)
--> 893         return artifact_type.collection(collection_name).versions(per_page=per_page)
    894
    895     @normalize_exceptions

/databricks/python/lib/python3.8/site-packages/wandb/apis/public.py in collection(self, name)
   3717
   3718     def collection(self, name):
-> 3719         return ArtifactCollection(
   3720             self.client, self.entity, self.project, name, self.type
   3721         )

/databricks/python/lib/python3.8/site-packages/wandb/apis/public.py in __init__(self, client, entity, project, name, type, attrs)
   3734         self._attrs = attrs
   3735         if self._attrs is None:
-> 3736             self.load()
   3737
   3738     @property

/databricks/python/lib/python3.8/site-packages/wandb/apis/public.py in load(self)
   3789             or response["project"]["artifactType"].get("artifactSequence") is None
   3790         ):
-> 3791             raise ValueError("Could not find artifact type %s" % self.type)
   3792         self._attrs = response["project"]["artifactType"]["artifactSequence"]
   3793         return self._attrs

CommError: Could not find artifact type model

Originally posted by @kayvane1 in https://github.com/wandb/wandb/issues/4359#issuecomment-1323596975

Hi @kayvane1, happy to help.  This doesn’t exist currently in the same way that it would for a standard Artifact. You can use wandb.use_artifact() which will return an Artifact object you can then check the version of. Please let me know if you have any questions.

Hi @MBakirWB , what I'm trying to do here is:

Check all the models are currently in production, or have ever been in production (i.e. the versions prior to :latest )
Within each one of the artifacts, I can look at the logged_by and used_by runs to get all the runs and artifacts that are linked to my production lineage over time
I can then use this list, to prune the runs and artifacts that I no longer want to keep in my W&B account / in the remote S3 storage to free up space.

To my knowledge, the Artifact class that the wandb.use_artifact() method would give me, doesn't have a method to check previous versions of the artifact.

Hi @kayvane1, thanks for flagging! We'll get a fix out for this.

Thanks @vwrj @MBakirWB !

Same issue here :wave:
Currently working on a project that uses the wandb model registry as a model zoo for different pretraining versions of the same model in the context of a research project. We went with the model registry as we currently do not plan to make our wandb project with the runs, that created the models, public. I need to access the different model versions, filter by some metadata and download the corresponding model.
All this currently fails on is the model type bug described above.

Hi All, This has now been fixed. Please do let us know if you run into other issues.

Thanks for implementing the fix! It works on 2 of the 3 models I've currently got on the model registry. The third model raises the same error as previously. They're all set-up in the same way so unsure why this hasn't worked across the board.

@kayvane1, thank you for the update and informing us the fix worked. Wandb release cycles are typically every 2-3 weeks.


Improvements to same-different plugin

Reopening against dev per comment on #165:

Hi! I made some minor tweaks to the same-different plugin when I was using it for a project and figured I'd share them back. So here you go!
Let me know what you think.

Thanks!

Awesome. Thanks! Glad you like it.

Thanks for merging! :-)


SDK 1.2.11 (go-textile 0.2.6)

This only updates the ios side of the sdks since bintray is down. Will try android again in the morning.


New rec document fragments

Follows up #172
Rough draft of some documentation for fragments. This example may not be particularly clear, and more examples or explanations are probably needed.
Checklist before submitting:

[x] Added entry to CHANGELOG.md
~Added/updated relevant tests~
[x] Added/updated documentation

Hmm, not understanding what I'm seeing as the list of commits here. 60% of these commits don't make sense and should be already incorporated... I'll see if I can fix it.


Breaking change in version 2.12.0 hinders communications with non-HTTPS servers

Summary
The change introduced in commit edef4ec breaks communications with non-HTTPS servers by changing the value of "NSAllowsArbitraryLoads" to false in Info.plist.   If this change was intentional we can no longer use Mattermost in our organization and it should have been made prominent in the Release Notes.
Environment Information

Device Name: N/A
OS Version: iOS 17.3
Mattermost App Version: 2.12.0
Mattermost Server Version: 9.4.1

Steps to reproduce
Using any Mattermost iOS client later than 2.12.0 try to connect to a server that is NOT utilizing HTTPS.
Expected behavior
It used to, always has, and always should work unless a "ONLY HTTPS from now on" decision has been made, in which case that should have been made public.
Observed behavior (that appears unintentional)
The app will appear to connect but no messages can be retrieved or sent, but the notifications still work (since the NotificationService module did not get this change).
Possible fixes
Change "NSAllowsArbitraryLoads" back to true in the Info.plist file.

Opened https://mattermost.atlassian.net/browse/MM-56725.


Mark Trezor firmware before 1.3.3. as not supported

It is maked as deprecated now but needs to be marked as 'Not supported' as it is a mandatory security update.

Updated multibit-hardware to mark earlier than Trezor 1.3.3 as unsupported.
Checked with Trezors version 1.3.1 and 1.3.3
Ready for review and closing

Verified working with MultiBit Hardware 0.4.0.
Closing.


Do you plan to update to ROS2?

Hi, I was wondering if you have any plans to update this to ROS2 eventually as ROS1 will eventually become deprecated. Thanks!

Check out the ROS2 branch! Everything there should be stable for 0.3.4 nerfstudio. I've been hoping to push a big update to that branch to upgrade to nerfstudio 1.0 and add gaussian splatting, but I haven't had a chance to upgrade the docs and do more thorough testing so that will take a couple more days.

That's awesome! I will check it out.


updating to v5.12.0 results in a timeout error

Expected behaviour: v5.12.0 should work like v5.11.0

What actually happens:

...
loading Lambda config	sts.optInRegionalEndpoint
Error: connect ETIMEDOUT <IP_ADDRESS>:80
    at TCPConnectWrap.afterConnect [as oncomplete] (net.js:1129:14) {
  message: 'Missing credentials in config',
  errno: 'ETIMEDOUT',
  code: 'CredentialsError',
  syscall: 'connect',
  address: '<IP_ADDRESS>',
  port: 80,
  time: 2020-01-20T07:45:09.471Z,
  originalError: {
    message: 'Could not load credentials from any providers',
    errno: 'ETIMEDOUT',
    code: 'CredentialsError',
    syscall: 'connect',
    address: '<IP_ADDRESS>',
    port: 80,
    time: 2020-01-20T07:45:09.471Z,
    originalError: {
      message: 'EC2 Metadata roleName request returned error',
      errno: 'ETIMEDOUT',
      code: 'ETIMEDOUT',
      syscall: 'connect',
      address: '<IP_ADDRESS>',
      port: 80,
      time: 2020-01-20T07:45:09.470Z,
      originalError: [Object]
    }
  }
}

Steps to reproduce the problem: updated from v5.11.0 to v5.12.0, a downgrade fixes the problem

Hello All,
I am new using claudia and start following this tutorial:
https://claudiajs.com/tutorials/hello-world-api-gateway.html
Also create a IAM Group like the image below, following the permissions from here: https://claudiajs.com/tutorials/installing.html

And I am getting the exact same problem mention on the first post... Any ideas in how to fix it?


Add RIZZARR Logo

A link to your logo: http://ashleymwilliams.com/rizzarr/
The city your org is based in: Detroit, MI + Los Angeles, CA
Website link: https://rizzarr.com/
The type of supporter you are: Startup

Thanks for the contribution! I've added the logo to the site: http://startupdetroit.co/
Highly encourage you to use #startupdetroit along with any social media post related to the Detroit startup scene and also encourage you to join/share the Slack community we have: http://invite.detroitstartup.community/


Accept script output as JSON instad of raw text

Needed for #2, #3

closing in favor of attributes passed in additional lines


do not register components with empty schemas

Description
This PR fixes #
Notes for Reviewers
Signed commits

[ ] Yes, I signed my commits.

@Revolyssup How many will we lose?

Bad news: In total 205 components ranging around 55 models.
Good news: For each of the 55 models, it isn't the case that all components have missing schema. Only few do. So all these 55 models are a mix of schema-less and schema-having components.


Adopt OpenAPI Specification for describing the DSpace REST API

Description of Improvement Request
The current DSpace REST API is described informally using a free-text document (RestContract, https://github.com/DSpace/RestContract). While this approach provides a basic overview of available endpoints, it lacks a formal (machine-readable), standardized structure.
This proposal suggests formally documenting the DSpace REST API using the OpenAPI Specification (https://www.openapis.org/). This will enhance usability, consistency, and integration capabilities for developers and external systems.
Formalizing the API using OpenAPI Specification comes with several benefits, e.g.,

Enforcing a standard structure for API definitions
Providing auto-generated, always-up-to-date documentation
Supporting client library generation in multiple languages

While I'm definitely in favor of some sort of automated description for the DSpace REST API, we had previously discussed using ALPS simply because it's supported by Spring Data REST (which is what we model our API against): https://docs.spring.io/spring-data/rest/reference/metadata.html   See also #2863
So, we would need to likely choose between this ticket and #2863 .  In any case, we've yet to find a volunteer to implement ALPS support


fix: prefix cacheKey

Q
A

Bug fix?
y

New feature?
n

BC breaks?
n

Deprecations?
n

Fixed tickets
n

You forgot to mention blame @Davidmattei in the commit ;)


fixes for wp 7.4.1

Fixed following parts:

[x] Inline image insert
[x] Use only widget jQuery

надо проверить на последней верии WP, и соответственно обновить

[x] readme.txt
[ ] uploadcare.php
[x] changelog.md

надо проверить на последней верии WP, и соответственно обновить

[ ] readme.txt
[ ] uploadcare.php
[ ] changelog.md

Внес изменения в соответсвии с коментариями.

I'm suggesting to review fixes and perform plugin update on Wordpress.com, without waiting for  #18  to be in place.

@ZNick1982 see checklist in my prev comment

moved checklist to PR description

Checklist updated.

?

didn't found place for update in uploadcare,php
probably this one:
define('UPLOADCARE_PLUGIN_VERSION', '2.5.1');
but confused current version: '2.5.1'
The updated version is '2.4.1'

theres meta data in the header comments that WP looks at

https://developer.wordpress.org/plugins/the-basics/header-requirements/

Yes, but also confused the current version, it is does not match with version in changelog.md
Anyway I fixed to the correct one according version on the https://wordpress.org/plugins/uploadcare/

https://github.com/uploadcare/uploadcare-wordpress/blob/master/readme.txt#L6

Yes, this one missed.
Fixed.


Suggest widget does not resize properly when number of suggestions increases.

Issue Type: Bug
When there is a small number of suggestions a small suggest widget is shown. If later a larger number of suggestions is given then the box remains at the small size and it isn't obvious that the rest of the suggestions gets cut off. The size seems to be based on the first box in a sequence of suggestions.
As an example here is a case using the codeql extension. Typing m.  in the following ends up first suggesting m and then tries to suggest methods on Bar (foo, toString, getAQlClass) but with a small box which only shows foo (although you can get the rest by scrolling.
newtype TFoo = Foo()
select "test"
class Bar extends Foo { predicate foo() {any()} string toString() {any()}}

predicate foo(Bar m) {
  m.
}

I would expect to see the same size box as I get with Ctrl-Space the second time around.
It seems like all of the default providers always show many suggestions or never end up showing more suggestions so I couldn't find a case to reproduce.
This seems to be a regression since 1.50.1 where a full sized suggestion widget was shown for the second set of suggestions
It seems to happen on macos and linux (windows not tested).
VS Code version: Code 1.51.1 (e5a624b788d92b8d34d1392e4c4d9789406efe8f, 2020-11-10T23:31:29.624Z)
OS version: Linux x64 4.19.0-12-amd64

System Info

Item
Value

CPUs
Intel(R) Core(TM) i7-4810MQ CPU @ 2.80GHz (8 x 3219)

GPU Status
2d_canvas: enabledflash_3d: enabledflash_stage3d: enabledflash_stage3d_baseline: enabledgpu_compositing: enabledmultiple_raster_threads: enabled_onoop_rasterization: disabled_offopengl: enabled_onprotected_video_decode: unavailable_offrasterization: disabled_softwareskia_renderer: enabled_onvideo_decode: unavailable_offvulkan: disabled_offwebgl: enabledwebgl2: enabled

Load (avg)
2, 2, 2

Memory (System)
31.02GB (13.21GB free)

Process Argv
--no-sandbox --unity-launch --crash-reporter-id 66c77ce2-2dd6-4bac-9c9c-633de1e518e9

Screen Reader
no

VM
0%

DESKTOP_SESSION
gnome

XDG_CURRENT_DESKTOP
GNOME

XDG_SESSION_DESKTOP
gnome

XDG_SESSION_TYPE
wayland

Extensions (19)

Extension
Author (truncated)
Version

vscode-eslint
dba
2.1.13

gitlens
eam
11.0.1

tsfmt-vscode
ete
0.3.3

vscode-codeql
Git
1.3.6

vscode-test-explorer
hbe
2.19.3

vscode-graphviz
joa
0.0.6

csharp
ms-
1.23.6

python
ms-
2020.11.367453362

jupyter
ms-
2020.11.358541065

vscode-groovy-lint
Nic
1.3.0

java
red
0.71.0

rust
rus
0.7.8

vscode-lldb
vad
1.6.0

vscodeintellicode
Vis
1.2.10

vscode-java-debug
vsc
0.29.0

vscode-java-dependency
vsc
0.15.0

vscode-java-pack
vsc
0.10.0

vscode-java-test
vsc
0.26.0

vscode-maven
vsc
0.25.0

I have managed to make a small typescript reproducing case

const foobar = {
  foo: 1,
  bar: 2
};

foobar

Triggering suggestions at the end there gives just foobar, then typing . gives a small 1 line suggestion widget despite the fact that it contains foo and bar.
Also the ui is particularly bad as the scrollbar is the entire height of the widget so it doesn't look like a scrollbar and hence the box doesn't look scrollable.

Just came across something similar and was gonna come to see if someone had opened an issue regarding this. Just curious, @alexet  does this StackOverflow answer fix your case, as in you're able to drag to increase the size of the suggestions widget?

It does fix it locally. I still think it is a bug as this is still the default behaviour.

Did you resize the widget before? Just by itself the widget has no "custom" size and always shows 12 items. Once you have resized it the custom size will be reused.

In my case, I had never resized the widget, in fact I didn't even realize it was a thing until I was looking into why I was only seeing one suggestion from intellisense. I vaguely remember reading somewhere about a bug that when the feature was released that it automatically made the widget be sized to the smallest height.
I see that there's a Reset Suggest Widget Size action, but didn't know about that at the time. Perhaps there can be some styling done to indicate that the widget is re-sizeable or maybe a setting that's like suggestions-to-show and then by default that'd be 10.

Running Reset Suggest Widget Size re-enables the bug the bug after resizing the window to prevent it from happening.
The problem is that the default widget size no-longer resizes itself bigger when new items appear after initially starting small.
A major problem is that the scroll bar is the height of a single item so it doesn't look like a scroll bar. With it looking like a scroll bar it would be much better as then at least it would not seem like a bug with missing suggestions.

The problem is that the default widget size no-longer resizes itself bigger when new items appear after initially starting small.

So, you are saying that you manually resize the widget to a smaller size and don't expect that size to be used when having different/more completions?

This is all using the default size after resetting the widget size
Taking the type script example we start with
const foobar = {
  foo: 1,
  bar: 2
};
fooba

I then ask for suggestions via Ctrl-Space. The only suggestion is foobar and a suggestion window with only one element is shown as expected. Then I type .. This updates the suggestions to now contain foo and bar but the suggestion window remain small. If I then move away and ask for suggestions again. I get the two I expected. This worked with previous versions.
Here is a gif showing the behaviour described

That's what I see

That is what I used to see before I updated.

This latest. In order to help you I need steps to reproduce. Please try again the sequence that you described and let me know if you reproduce or not

reset suggest widget size (F1 > Reset Suggest Widget Size)
use above sample

I've also encountered this several times lately. I'll try and get good repro steps, but what usually happens is I'll manually resize the widget to be a tad smaller (just a few pixels) and then layer as I intelligence comes up the widget gets resized to only show a single item and gets stuck there.

but what usually happens is I'll manually resize the widget to be a tad smaller (just a few pixels) and then later as intellisense comes up, the widget gets resized to only show a single item and gets stuck there.

In the last week I did fix a bug where you would get the "wrong" height persisted easily. This should be better now but I am curious to see if there is anything else. Tho, in all strictness what stated here (https://github.com/microsoft/vscode/issues/110971#issuecomment-734255238) is different, e.g that the widget doesn't grow with being resized

This latest. In order to help you I need steps to reproduce. Please try again the sequence that you described and let me know if you reproduce or not
* reset suggest widget size (F1 > Reset Suggest Widget Size)

* use above sample

I had the same issue that the intellisense only showed 1 response in the dropdown. Struggled with this for a while and was going to move away from Vscode to  jupyter notebook, until I saw this fix after days of searching.
Thanks for the help. Makes the experience so much better.
Now sure how I got into this since on my windows box it works as expected but on Ubuntu it was not working.


TypeScript support

Hello, thanks for your work. Could you add TypeScript support by adding declaration file?

Hello, @stmegabit
It is a good suggestion
I'll try to figure this out in a week, but if you can contribute – it would be great!

Let's close it for now 😢


Updating special_dm_cut and date_cut to account for the case that DCU…

…TDTM (datacut date) is null.
Thank you for your Pull Request! admiraldev have developed this task checklist from the Development Process Guide to help with the final steps of the process. Completing the below tasks helps to ensure our reviewers can maximize their time on your code as well as making sure the datacutr codebase remains robust and consistent.
Please check off each taskbox as an acknowledgment that you completed the task or check off that it is not relevant to your Pull Request. This checklist is part of the Github Action workflows and the Pull Request will not be merged into the devel branch until you have checked off each task.

[x] Place Closes #<insert_issue_number> into the beginning of your Pull Request Title (Use Edit button in top-right if you need to update)
[x] Code is formatted according to the tidyverse style guide. Run styler::style_file() to style R and Rmd files
[x] Updated relevant unit tests or have written new unit tests - See Unit Test Guide
[x] If you removed/replaced any function and/or function parameters, did you fully follow the deprecation guidance?
[x] Update to all relevant roxygen headers and examples
[x] Run devtools::document() so all .Rd files in the man folder and the NAMESPACE file in the project root are updated appropriately
[x] Address any updates needed for vignettes and/or templates
[x] Update NEWS.md if the changes pertain to a user-facing function (i.e. it has an @export tag) or documentation aimed at users (rather than developers)
[x] Build datacutr site pkgdown::build_site() and check that all affected examples are displayed correctly and that all new functions occur on the "Reference" page.
[x] Address or fix all lintr warnings and errors - lintr::lint_package()
[x] Run R CMD check locally and address all errors and warnings - devtools::check()
[x] Link the issue in the Development Section on the right hand side.
[x] Address all merge conflicts and resolve appropriately
[x] Pat yourself on the back for a job well done! Much love to your accomplishment!

FYI @barnett11 and @reesnj, I had a look through and made a couple of minor changes to special_dm_cut() and date_cut to account for DCUTDTC being null. I've put in some temporary code to add a message to the console if any records of DCUTDTC are null, but it'd be good to see what you both think. Anyway, can discuss more when we meet tomorrow. Thanks!

Thanks @reesnj, I didn't think about create_dcut actually, although would they use this function if they were creating a DCUT dataset with a missing cut date as we're comparing to a condition in DS?


Revert "Add Label to FabricDescriptorStruct and hook up logic with UpdateFabricLabel (#6670)

This reverts commit e1cb60847fdb66d2330dfb1a8bde8769d6e36c95 because
that breaks Darwin tests: it changes StorableAdminPairingInfo but
something is setting up admins in kvs without going through
AdminPairingInfo::StoreIntoKVS so our code and our stored data end
up out of sync.
Problem
What is being fixed?  Examples:
darwin tests fail, at least when running locally.
Change overview
Revert #6670
Testing
Ran darwin tests locally after revert and they pass.

In particular, in AdminPairingInfo::FetchFromKVS we end up reading 32 bytes too few when we do:
SuccessOrExit(err = kvs->SyncGetKeyValue(key, info, infoSize));

and then some of the struct fields of info end up as garbage and some of the following deserialization likely fails.

@shana-apple