WIP - W-033110 Opportunity Amount Sync

Critical Changes
Changes
If Enforce Accounting Data Consistency is enabled, it will:

If Opportunity is Finalized: Prevent changes to the Opportunity Amount that differ from the Sum of Paid Payments
If Opportunity is Not Finalized: Prevent the Opportunity Amount from being lowered below the Sum of the Paid Payments
If the Opportunity is not Finalized: Increase the Opportunity Amount to the Sum of the Paid Payments, as changes to Payments occur
If the Opportunity becomes Finalized (e.g. the Opportunity Stage is changed to a Finalized State): Change the Opportunity Amount to the sum of the Paid Payments, raising OR lowering it.  It will continue to be updated/recalculated if additions or changes to the Paid Payments occur

Definition of Finalized:  A closed Opportunity Stage with a corresponding Opportunity Stage to State Mapping of "Finalized".
Issues Closed
Fixes #4461
New Metadata
Custom Labels:

Opp_Amount_Is_Less_Error
Opp_Amount_Not_Equal_Error

Deleted Metadata

This one is on hold for the moment.

@vmartinov-sforg - Hey, Vlad, Pedro and I connected briefly.  There is one other thing we need to do with this.  This functionality should only be enabled if the Custom Setting Enforce Accounting Data Consistency is enabled/true.  I believe there is already a variable present in the PMT_Payment_TDTM trigger for this called isEnforceAccountingDataConsistency.  So you can wrap these in blocks with that if (isEnforceAccountingDataConsistency) { ... }

@jbrandolinisf The methods runForPayments() and runForOpportunities()  already have checks for if (isEnforceAccountingDataConsistency) {..}. Is that what you meant?

Yeah, I just wanted to make sure it was behind that, meaning if that is false neither the validation nor the Amount update will occur.  I didn't look closely to see whether it was/wasn't so if I missed it in the 3rd pass over, I apologize!

@vmartinov-sforg - I confirmed with Pedro that we do need to recalculate the Opportunity Amount on Opportunity Update (if the Stage changes from a non Finalized to a Finalized State).  So we would call isFinalized on both the old and the new opportunity records from the trigger map.  If it was not finalized, but now is.  We should recalculate the amount.  Again, this too should be behind the Enforce Accounting Data Consistency setting.

@jbrandolinisf Can we chat about the latest change request from Pedro?

Sure.  Let me know when.

@vmartinov-sforg  - There is a pending merge for this.  Can you fix that and I will review?

@jbrandolinisf I don't see this branch being out-of-sync with master. Where do you see that?

@vmartinov-sforg - Never mind, I think I misread the status after I told it to go ahaed and do it's thing.  I will review now!


Analytics | Remove all code related to tracking

Remove all code related to Mixpanel and to track users (i.e. changes added on #7) so we can re-build and finally deploy v5.1

@Saidmurod1996 Please note that currently only the Mixpanel ID is on the environment files, so you may be tempted to remove these files, however on this files we should have the browser names and the update URL, which currently are hardcoded in the webpack file.
So instead of doing:
new HtmlReplaceWebpackPlugin([
  {
    pattern: "@@browserName",
    replacement: env.mode === "edge" ? "Edge" : "Chrome"
  },
]),
....
.replace(
  "process.env.update_url",
  env.mode === "edge"
    ? "https://edge.microsoft.com/extensionwebstorebase/v1/crx"
    : "https://clients2.google.com/service/update2/crx"
)

We should do:
new HtmlReplaceWebpackPlugin([
  {
    pattern: "@@browserName",
    replacement: env.BROWSER_NAME
  },
]),
....
.replace(
  "process.env.update_url",
  env.UPDATE_URL
)


e04

[ ] When bullet is deleted, notify the object that is hit (body)
[ ] We'll create a Stats node and place it on anything in our game that has hit points and can be damaged.
[ ] Then the bullet can just check if that body has that "Stats" node:

Bullet
func _on_Area_body_entered(body: Node):
#	print("I hit you! ", body)
	queue_free()

	if body.has_node("Stats"):
		var stats_node = body.find_node("Stats") as Stats
		stats_node.take_hit(damage)

Stats Node

[ ] take_hit method
[ ] Check if we're dead

extends Node

class_name Stats

export var max_HP = 10
var current_HP = max_HP

func take_hit(damage):

	current_HP -= 1  # current_HP = current_HP - 1
	print("I'm HIT! ",  current_HP, "/", max_HP)

	if current_HP <= 0:
		die()

func die():
	queue_free()

Problem... deletes the Stats node only, so can't take damage, but enemy still exists!

[ ] Dont' want to delete out parent, in fact, generally we only want parent nodes to manipulate its child nodes.  When we have a child node like Stats that we want to do something to the parent, we'll send a signal and let the parent node deal with it however they want.  For example, we may want to queue_free() the enemies, but something different might happen to out player when it dies.
[ ] Doesn't have a signal for dying, obviously, so we'll create one! And Godot makes this super easy

Stats
signal you_died_signal
func die():
	emit_signal("you_died_signal")


Remove parentheses during Excel to XML conversion

Hi Eng Swee,
One of our files to be converted failed because the column header contained parentheses:
class javax.script.ScriptException java.lang.Exception: com.equalize.converter.core.util.ConverterException: Invalid character in XML element name: Salary(Sep24)@ line 115 in groovy_formatConversion.groovy
Is there a way to remove the parentheses during the conversion, e.g. replaceAll? If it was already in text or csv format, I could easily do it, but I'm not sure how I can do it as part of the Excel to XML conversion.
Or is there a way to convert from Excel to csv, then I can manage it myself using Groovy / CSV to XML converter?
Many thanks,
AJ

You can try using onlyValidCharsInXMLName = Y.
Reference - https://community.sap.com/t5/technology-blogs-by-members/exceltransformbean-part-1-convert-various-excel-formats-to-simple-xml/ba-p/13274900
PS: Unfortunately, the blog has not really survived the multiple migrations of the SAP Community platform 😰

Hi Eng Swee, this worked perfectly. Sorry, I must have missed that parameter when reviewing the blog.
Thank you so much for your help 😊


druid.historical.cache.numBackgroundThreads documentation

See:
https://github.com/druid-io/druid/pull/936
and https://groups.google.com/forum/#!topic/druid-user/WC8Vo0a3UK0
druid.historical.cache.numBackgroundThreads need some documentation considering it is really useful !
Thanks,
Ben

This feature actually needs more testing. We encountered some buffer clobbering when we tested it out under certain configurations.


unathorized

Error: error creating Kafka Topic: 401 Unauthorized: Unauthorized
with confluent_kafka_topic.tf-poc-topic,
│   on main.tf line 15, in resource "confluent_kafka_topic" "tf-poc-topic":
│   15: resource "confluent_kafka_topic" "tf-poc-topic" {

Thanks for opening an issue @ERahman-RH!
It's a little bit hard to tell without looking at your TF config but it looks like Kafka API Key you provided is invalid so you might want to double check credentials block
resource "confluent_kafka_topic" "orders" {
  kafka_cluster {
    id = confluent_kafka_cluster.basic-cluster.id
  }
  ...
  credentials {
    key    = confluent_api_key.app-manager-kafka-api-key.id
    secret = confluent_api_key.app-manager-kafka-api-key.secret
  }
}

or kafka_api_key / kafka_api_secret if you're using managing-single-cluster
# Option #2 when managing a single cluster in the same Terraform workspace
# See https://github.com/confluentinc/terraform-provider-confluent/tree/master/examples/configurations/managing-single-cluster for more details
provider "confluent" {
  cloud_api_key       = var.confluent_cloud_api_key    # optionally use CONFLUENT_CLOUD_API_KEY env var
  cloud_api_secret    = var.confluent_cloud_api_secret # optionally use CONFLUENT_CLOUD_API_SECRET env var

  kafka_rest_endpoint = var.kafka_rest_endpoint        # optionally use KAFKA_REST_ENDPOINT env var
  kafka_api_key       = var.kafka_api_key              # optionally use KAFKA_API_KEY env var
  kafka_api_secret    = var.kafka_api_secret           # optionally use KAFKA_API_SECRET env var
}

Let me know if that helps!
In order to check whether Kafka API Key is valid I'd recommend trying to send a curl (for example, to list topics).

resource "confluent_kafka_topic" "tf-poc-topic" {
kafka_cluster {
id = var.kafka_cluster_id
}
topic_name         = "tf-poc-topic"
rest_endpoint      = var.kafka_rest_endpoint
credentials {
key    = var.kafka_api_key
secret = var.kafka_api_secret
}
}

@ERahman-RH did you manage to list all the topics using that Kafka API Key by sending a curl?

not yet i will try now

i got could not resolve host

i think i may have found the error i have been using my confluent cloud api key for the credentials and have not added my kafka api key yet would that be my problem


Dogfood

This creates witness attestations when running tests

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 47.674%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
994

Relevant Lines:
2085

💛  - Coveralls


make_error is not throwing error in the frontend

When calling he method make_error, we still use the callback onSuccess for the Frontend. Ideally, it would be best to throw an error so we can display information to the user that something went wrong.

Check where it's used and what consequences it has to "fix" not sending an error.


[SMALLFIX] minor refactor

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/15074/
Test PASSed.

Merged build finished. Test PASSed.


SkeletonIK not updating after the first time when Skeleton Animation is playing

Godot version:
Godot 3.2.1 Stable official
OS/device including version:
Win10
Issue description:
SkeletonIK should update the pre solver skeleton bone positions after the first time it is created. It does not.

See video for example (root bone of SkeletonIK is upper left arm, and it's static, not following the animation, or any new anim/anim change in fact): https://youtu.be/anBwEMyRU-M
Steps to reproduce:
Just a regular SkeletonIK that is working together with AnimationPlayer (and or tree)

Additionally, start() and stop() of SkeletonIK should be created in AnimationPlayer for every animation where SkeletonIK should run.

Minimal reproduction project:
godot-3d-mannequin-SkeletonIK_Bug.zip
This minimal reproduction project is also awailable here, SkeletonID_bug branch:
https://github.com/Griefchief/godot-3d-mannequin/tree/SkeletonIK_bug

Seems fixed in 3.2.2 after I checked, was only released 6 days ago officially.
https://youtu.be/Ny4_8EJnVxQ

it has fixed in 3.2.2

Regression fixed by this commit. I suspect that updating the items pointer here updates the pointer of the bones, as this is the only change in SkeletonIK _update() function:
https://github.com/godotengine/godot/commit/277696d6c50eba68ca11cf3c0988be0213e5c65d#diff-33142f6c0baba2d89d20429c9ede7a44R147
Author: Andrea Catania<EMAIL_ADDRESS>Date:   Tue Mar 24 09:59:32 2020 +0100
Fixed IK rotation issue

(cherry picked from commit 277696d6c50eba68ca11cf3c0988be0213e5c65d)

git bisect log
git bisect start
new: [6a9fbafcbbd7954761fb17554ed08fb62e3554dd] Bump version to 3.2.2-stable
git bisect new 6a9fbafcbbd7954761fb17554ed08fb62e3554dd
old: [b0eca5828ccd3a5c07b77e82e567c45937de9056] Bump version to 3.2.1-stable
git bisect old b0eca5828ccd3a5c07b77e82e567c45937de9056
new: [c1cf8a5068f6dbe511210a4855fdd10f2f63ca7b] Tweak the editor log selection color to match the current editor theme
git bisect new c1cf8a5068f6dbe511210a4855fdd10f2f63ca7b
skip: [ade57c4bf0c54a04691797880dd0f0136a817ea6] Merge pull request #38099 from clayjohn/GLES2-skeleton-rebind
git bisect skip ade57c4bf0c54a04691797880dd0f0136a817ea6
skip: [3b44f34166a5efa068305a3160caa3415064990a] Merge pull request #38114 from lawnjelly/kessel_rulerfix
git bisect skip 3b44f34166a5efa068305a3160caa3415064990a
old: [36a30f681fc8c3256829616f32ee452b15674752] Merge pull request #37825 from qarmin/leak_with_drives
git bisect old 36a30f681fc8c3256829616f32ee452b15674752
new: [78f0cf40cb4a37b54a27da25349718d1c4b324e5] Merge pull request #38257 from RandomShaper/imvu/fix_variantrc_gdnative
git bisect new 78f0cf40cb4a37b54a27da25349718d1c4b324e5
new: [008e0748c158a3f9e307706ba5ffeb2c5a3f8a12] Merge pull request #37349 from lawnjelly/kessel32_1
git bisect new 008e0748c158a3f9e307706ba5ffeb2c5a3f8a12
new: [c0047023e6c1f3ca95f03371ddf9de716a466e97] NoiseTexture: prevent race condition because of Ref::unref()
git bisect new c0047023e6c1f3ca95f03371ddf9de716a466e97
new: [94f451e0702a6b4776abd5e013d514b5aaa7e2e2] Ensure COWData does not reallocate on push back, fixes #22561
git bisect new 94f451e0702a6b4776abd5e013d514b5aaa7e2e2
old: [373db277885606f493acae5faa86011c59442f9c] Migrate legacy apache dependency to the GodotPayment plugin
git bisect old 373db277885606f493acae5faa86011c59442f9c
new: [219ce2f14958321947073c1c78bc7eb429abaf79] Fix volume interpolation in positional audio nodes
git bisect new 219ce2f14958321947073c1c78bc7eb429abaf79
new: [a51e78528f20c410880b71c978f4038532d99659] Fixed IK rotation issue
git bisect new a51e78528f20c410880b71c978f4038532d99659
old: [96e381ac0371d129719b02140a06869c8063ae46] Validate supported architectures when exporting to Android
git bisect old 96e381ac0371d129719b02140a06869c8063ae46
first new commit: [a51e78528f20c410880b71c978f4038532d99659] Fixed IK rotation issue


PHP Fatal error:  Allowed memory size of 134217728 bytes exhausted

Issue description:
When using the Number control I get a server 500. This happens when I go up or down.
PHP Fatal error:  Allowed memory size of 134217728 bytes exhausted (tried to allocate 32 bytes) in plugins/kirki/field/class-kirki-field-number.php on line 69, referer: wp-admin/customize.php?return=%2Fembark%2Fwp-admin%2Fplugins.php&changeset_uuid=98e6aa69-3c26-4f60-a360-a32ff2a83e5d
Version used:
3.0.3
Using theme_mods or options?
Code to reproduce the issue (config + field(s))
Embark_Kirki::add_field( 'embark_theme', array(
    'type'        => 'number',
    'settings'    => 'themo_nav_top_margin',
    'label'       => esc_html__( 'Navigation Top Margin', 'embark' ),
    'description' => esc_html__( 'Set top margin value for the navigation bar', 'embark' ),
    'section'     => 'menu',
    'default'     => 19,
    'choices'     => array(
        'min'  => '0',
        'max'  => '300',
        'step' => '1',
    ),
    'output' => array(
        array(
            'element'  => '.navbar .navbar-nav',
            'property' => 'margin-top',
            'units'    => 'px',
        ),
        array(
            'element'  => '.navbar .navbar-toggle',
            'property' => 'top',
            'units'    => 'px',
        ),
        array(
            'element'  => '.themo_cart_icon',
            'property' => 'margin-top',
            'value_pattern' => 'calc($px + 12px)'
        ),
    ),
) );

That's weird...
That last commit (https://github.com/aristath/kirki/commit/16c1d05fa9e512eddf1a9e4a1aafc3189fa7eee6) should fix your issue, can you please test it?

That worked! Thanks!!

Better fix for this was added in https://github.com/aristath/kirki/commit/cdccd553c05fc22b1750d40b551f385b1e0206c6
Will be included in 3.0.4 later today.


Update bundle version from 4.3.0 to 4.3.1

retest this please.

retest this please.

retest this please

Putting this as WIP since this is having issue with crictl side on CI.


change amd to and in readme

Thanks for this @bot2600, our clientlib is auto generated so we can't merge this PR, but we'll fix this typo!


Foreman exits with code 1 after hitting ctrl-c when using bash script for web worker

Hi,
My Procfile used to be:
web: bundle exec shotgun -I . -I ./lib -p $PORT -E $RACK_ENV
redis: redis-server /usr/local/etc/redis.conf --port $PORT

Things worked fine and when I would hit ctrl-C, both web and redis would exit with code 0.
Then, based on https://github.com/ddollar/foreman/wiki/Environment-specific-Behavior , I created an executable bash file run_web.sh with the contents of that link and changed by Procfile to be
web: ./run_web.sh
redis: redis-server /usr/local/etc/redis.conf --port $PORT

Now, whenever I hit ctrl-C I get:
18:15:50 system  | sending SIGTERM to all processes
18:15:50 web.1   | exited with code 1
18:15:50 redis.1 | exited with code 0

Notice how web.1 is now exiting with code 1 instead of code 0.  What's the best way to fix this?
I tried adding a trap to the run_web.sh but that didn't seem to work.
Somehow, foreman is not getting along well with the bash script ...
Thanks!

If anyone that is being affected by this would like to submit a PR I would be grateful. Thank you! My time is currently quite limited so I will likely not be addressing non-critical issues for quite some time.


OffsetPaging. The compilation is unable to resolve cyclic dependencies

We are in the process of moving our preproduction services to v11. And we're facing a really big issue which is a blocker for us.
Suppose, we have a collection of Users but each user has its own collection of users, say 'Parents'. It's enough to get the compilation failed.
@michaelstaib this is a really critical issue so I kindly ask you to give enough priority to that issue to fix it ASAP. I've made a complete test reproducing that error.
public class Issue2883Reproducing
    {
        private readonly ITestOutputHelper _testOutputHelper;

        public class User
        {
            public string? FirstName { get; set; }

            public List<User> Parents { get; set; }
        }

        public class UserType : ObjectType<User>
        {
            protected override void Configure(IObjectTypeDescriptor<User> descriptor)
            {
                descriptor.Field(i => i.Parents).UseOffsetPaging<UserType>().Resolve((_1, _2) => new[] { new User { FirstName = "Mother" }, new User { FirstName = "Father" } });
            }
        }

        public class Query
        {
            public List<User> Users => new()
            {
                new User()
            };
        }

        public class QueryType : ObjectType<Query>
        {
            protected override void Configure(IObjectTypeDescriptor<Query> descriptor)
            {
                descriptor.Field(t => t.Users)
                    .UseOffsetPaging<UserType>();
            }
        }

        public Issue2883Reproducing(ITestOutputHelper testOutputHelper)
        {
            _testOutputHelper = testOutputHelper;
        }

        [Fact]
        public async Task Test()
        {
            IRequestExecutor executor =
                await new ServiceCollection()
                    .AddGraphQL()
                    .AddQueryType<QueryType>()
                    .SetPagingOptions(new PagingOptions { DefaultPageSize = 50 })
                    .Services
                    .BuildServiceProvider()
                    .GetRequestExecutorAsync();

            IExecutionResult executionResult = await executor
                .ExecuteAsync(@"
                {
                    users {
                        items
                        {
                            parents
                            {
                                items
                                {
                                    firstName
                                }
                            }
                       }
                    }
                }");

            foreach (IError error in executionResult.Errors ?? new IError[0])
                _testOutputHelper.WriteLine(error.Message);

            Assert.Equal(0, executionResult.Errors?.Count ?? 0);
        }
    }

This one is on our list and will be fixed with 11.0.9 probably end of next week

This one is on our list and will be fixed with 11.0.9 probably end of next week

@michaelstaib, any updates on that blocker issue?

@michaelstaib, any updates on that blocker issue?

@michaelstaib , I have downloaded version 11.0.9 and run the test above. Nothing has changed. The version remains absolutely broken and unusable. It has taken 2 weeks already and that critical bug still exists leaving us in the middle of moving to v.11 process.
Do you have any real estimates about fixing that?

@michaelstaib , I have downloaded version 11.0.9 and run the test above. Nothing has changed. The version remains absolutely broken and unusable. It has taken 2 weeks already and that critical bug still exists leaving us in the middle of moving to v.11 process.
Do you have any real estimates about fixing that?

Hi @ademchenko we have moved the fix to 11.0.10.
I cannot give you an exact date as we are at the moment fully focused on strawberry shake. But a rough timeframe for 11.0.10 is in the next 14 days.

Hi @ademchenko we have moved the fix to 11.0.10.
I cannot give you an exact date as we are at the moment fully focused on strawberry shake. But a rough timeframe for 11.0.10 is in the next 14 days.

Hi, @michaelstaib, thanks, it works in v11.1.0-preview.59. Hope it will be brought into the production shortly.


Add Simple Mint to the Statemine integration

Currently only Classic mint is working on the Statemine.
It would be cool to allow people to mint collections like BirdBoy
eg:
Same image, same meta, we can also skip metadata for the NFT (e.g fetch meta from the collection)

Ref #1346

Meanwhile Polkadot AssetHub minting


DCOS-12640: Remove network name if not available review screen

close DCOS-12640

Looks good! ✨ 💯


added overloading for upsert and insertOrUpdate

Hi there,
I'm not super familiar with sequelize-typescript, but I noticed that upsert/insertOrUpdate actually return a tuple inside a Promise, when return: true is used. This can probably be typed correctly with overloading.
In my case A is a model. Not sure if this covers all cases, though.

Codecov Report

Merging #374 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #374   +/-   ##
=======================================
  Coverage   96.09%   96.09%
=======================================
  Files         119      119
  Lines        1024     1024
  Branches      132      132
=======================================
  Hits          984      984
  Misses         21       21
  Partials       19       19

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8c37a59...4a1022a. Read the comment docs.

Great! Thanks for fixing.


XamarinForms extensions have no ref and shell properties

See:
https://github.com/fsprojects/Fabulous/blob/13b2a75521589629da7eaf0585741232f62e450c/Fabulous.XamarinForms/extensions/OxyPlot/OxyPlot.fs#L20-L26
There are no ref nor shell* properties.
Need to update the Generator to regenerate properties for extensions when base views are updated.

I think the extensions are currently written per hand and not auto generated.
I think this will be different in the future.

@SergejDK is right.
The extensions are currently written by hand, so we can easily fix this issue.

I will fix this the next days.


Prepare examples (minus examples/api) for use_super_parameters

https://github.com/flutter/flutter/issues/100575
Excludes examples/api, see https://github.com/flutter/flutter/issues/100575#issuecomment-1081037991.

this seems to have caused red dart-flutter hhh bot https://logs.chromium.org/logs/dart/buildbucket/cr-buildbucket/8818318172012638753/+/u/flutter_test_framework_coverage/stdout
27:55 +5519 ~13: loading /b/s/w/ir/cache/builder/flutter/packages/flutter/test/painting/continuous_rectangle_border_test.dart
../../examples/layers/rendering/src/sector_layout.dart:623:34: Error: The argument type 'dynamic' can't be assigned to the parameter type 'HitTestResult'.
 - 'HitTestResult' is from 'package:flutter/src/gestures/hit_test.dart' ('lib/src/gestures/hit_test.dart').
  SectorHitTestResult.wrap(super.result) : super.wrap();
                                 ^
../../examples/layers/rendering/src/sector_layout.dart:635:41: Error: The argument type 'dynamic' can't be assigned to the parameter type 'HitTestTarget'.
 - 'HitTestTarget' is from 'package:flutter/src/gestures/hit_test.dart' ('lib/src/gestures/hit_test.dart').
  SectorHitTestEntry(RenderSector super.target, { required this.radius,  required this.theta })
                                        ^

@aam looks like that bot is not running with the super parameter experiment enabled (available starting with SDK 2.17.0-0). I am not familiar with the bot, but somewhere you'll need to bump the lower SDK constrains to be at least 2.17.0-0.
/cc @mit-mit

current hypothesis is that it was caused by https://dart-review.googlesource.com/c/sdk/+/239081 that landed in dart sdk, has not reached flutter repo yet.


chore(deps): :arrow_up: update nrwl workspace

This PR contains the following updates:

Package
Change
Age
Adoption
Passing
Confidence

@angular-eslint/eslint-plugin
15.0.0 -> 15.1.0

@angular-eslint/eslint-plugin-template
15.0.0 -> 15.1.0

@angular-eslint/template-parser
15.0.0 -> 15.1.0

@angular/cli
~15.0.0 -> ~15.0.4

@angular/common
^14.2.0 -> ^14.2.12

@angular/core
^14.2.0 -> ^14.2.12

tslib (source)
^2.3.0 -> ^2.4.1

tslib (source)
^2.3.0 -> ^2.4.1

zone.js (changelog)
~0.11.4 -> ~0.12.0

Release Notes

angular-eslint/angular-eslint (@angular-eslint/eslint-plugin)
v15.1.0
Compare Source
Bug Fixes

eslint-plugin: [no-input-rename] do not report on directive composition API (#1231) (119fba7)
update typescript-eslint packages to v5.44.0 (#1222) (5750e3a)

angular-eslint/angular-eslint (@angular-eslint/eslint-plugin-template)
v15.1.0
Compare Source
Bug Fixes

eslint-plugin-template: [accessibility-valid-aria] use Number() to parse numeric values (#1218) (6fe40d6)
eslint-plugin-template: [i18n] allow more attributes by default (#1220) (4232b1c)
update typescript-eslint packages to v5.44.0 (#1222) (5750e3a)

Features

eslint-plugin-template: [no-call-expression] add allowList option (#1217) (a69c809)

angular-eslint/angular-eslint (@angular-eslint/template-parser)
v15.1.0
Compare Source
Note: Version bump only for package @angular-eslint/template-parser

angular/angular (@angular/common)
v14.2.12
Compare Source
Breaking Changes
core

Existing iframe usages may have security-sensitive attributes applied as an attribute or property binding in a template or via host bindings in a directive. Such usages would require an update to ensure compliance with the new stricter rules around iframe bindings.

core

Commit
Type
Description

54814c8e9b
fix
hardening attribute and property binding rules for  elements (#48028)

Special Thanks
Andrew Kushnir

v14.2.11
Compare Source
router

Commit
Type
Description

aef353c143
fix
Ensure renavigating in component init works with enabledBlocking (#48066)

Special Thanks
Alan Agius, Andrew Scott and Mujo Osmanovic

v14.2.10
Compare Source
core

Commit
Type
Description

a4312e1be5
fix
add zone.js version 0.12.x as a valid peer dependency (#48002)

router

Commit
Type
Description

db867fee77
fix
fix redirectTo on named outlets - resolves #33783 (#47927)

Special Thanks
Alan Agius, Albert Szekely, Andrew Scott, Doug Parker, Kristiyan Kostadinov, Markus Eckstein, Peter Scriven and abergquist

v14.2.9
Compare Source
platform-browser

Commit
Type
Description

92d28bdd99
perf
resolve memory leak when using animations with shadow DOM (#47903)

platform-server

Commit
Type
Description

d2d9bbf5ce
fix
call onSerialize when state is empty (#47888)

Special Thanks
Alan Agius, Kristiyan Kostadinov, Virginia Dooley and mgechev

v14.2.8
Compare Source
Special Thanks
Andrew Scott, Balaji, Paul Gschwendtner, WD Snoeijer, onrails and vyom1611

v14.2.7
Compare Source
Special Thanks
Bob Watson, Charles Barnes, Joey Perrott, Virginia Dooley, WD Snoeijer, abergquist and urugator

v14.2.6
Compare Source
compiler-cli

Commit
Type
Description

3fd176a905
fix
add missing period to error message (#47744)

c3821f5ab5
perf
minimize filesystem calls when generating shims (#47682)

Special Thanks
Alan Agius, Andrew Kushnir, Andrew Scott, Aristeidis Bampakos, Bob Watson, Charles Lyding, Joey Perrott, Joshua Morony, Mathew Berg, Paul Gschwendtner, Peter Dickten, Renan Ferro, Sri Ram, WD Snoeijer, markostanimirovic and Álvaro Martínez

v14.2.5
Compare Source
This release contains various API docs improvements.
Special Thanks
Alexander Wiebe, Ciprian Sauliuc, Dmytro Mezhenskyi, George Kalpakas, Joe Martin (Crowdstaffing), Jordan, Ole M, Paul Gschwendtner, Pawel Kozlowski and mgechev

v14.2.4
Compare Source
compiler-cli

Commit
Type
Description

a4b66fe1e5
perf
cache source file for reporting type-checking diagnostics (#47508)

core

Commit
Type
Description

2c46b5ab24
fix
correctly check for typeof of undefined in ngDevMode check (#47480)

Special Thanks
Alan Agius, Ashley Hunter, Doug Parker, Jessica Janiuk, JoostK, Kristiyan Kostadinov, Rokas Brazdžionis and Simona Cotin

v14.2.3
Compare Source
animations

Commit
Type
Description

bba2dae812
fix
make sure that the useAnimation function delay is applied (#47468)

Special Thanks
AleksanderBodurri, Andrew Kushnir, Andrew Scott, Bob Watson, George Kalpakas, Joey Perrott, Mauro Mattos, dario-piotrowicz, fabioemoutinho and famzila

v14.2.2
Compare Source
animations

Commit
Type
Description

937e6c5b3d
fix
make sure that the animation function delay is applied (#47285)

common

Commit
Type
Description

c9bdf9bab1
fix
rename rawSrc -> ngSrc in NgOptimizedImage directive (#47362) (#47396)

core

Commit
Type
Description

a3e1303f04
fix
imply @Optional flag when a default value is provided (#47242)

forms

Commit
Type
Description

80c66a1e57
fix
don't prevent default behavior for forms with method="dialog" (#47308)

Special Thanks
Abhishek Rawat, Andrew Kushnir, Benjamin Chanudet, Bob Watson, George Kalpakas, Ikko Ashimine, Kristiyan Kostadinov, Marc Wrobel, Mariia Subkov, Pawel Kozlowski, Sebastian, abergquist, dario-piotrowicz, onrails and vyom1611

v14.2.1
Compare Source
Breaking Changes
core

Existing iframe usages may have security-sensitive attributes applied as an attribute or property binding in a template or via host bindings in a directive. Such usages would require an update to ensure compliance with the new stricter rules around iframe bindings.

core

Commit
Type
Description

54814c8e9b
fix
hardening attribute and property binding rules for  elements (#48028)

Special Thanks
Andrew Kushnir

Microsoft/tslib
v2.4.1: tslib 2.4.1
Compare Source
This release contains fixes for early returns and throws invoked on generators.
v2.4.0: tslib 2.4.0
Compare Source
This release includes the __classPrivateFieldIn helper as well as an update to __createBinding to reduce indirection between multiple re-exports.
v2.3.1: tslib 2.3.1
Compare Source
This release updates the __spreadArray helper for TypeScript 4.4 to correctly operate on collections that are not "concat-spreadable" such as the DOM's NodeLists and HTMLCollections.

angular/angular (zone.js)
v0.12.0
Compare Source
Bug Fixes

zone.js: cancel tasks only when they are scheduled or running (#46435) (b618b5a), closes #45711
zone.js: Fix ConsoleTask interface typo (#47090) (91954cf)

0.11.8 (2022-08-08)
Features

zone.js: Update to the simpler Async Stack Tagging v2 API (#46958) (f23232f)

0.11.7 (2022-07-20)
Bug Fixes

zone.js: do not invoke jasmine done callback multiple times with waitForAsync (4e77c7fbf38)

Features

zone.js: add AsyncStackTaggingZoneSpec implementation (#46693) (848a009)
zone.js: include jasmine describe block name when raising unexpected task error (de86285)
zone.js: include zone name when sync-test zone reports tasks (72c2567)

0.11.6 (2022-06-02)
Bug Fixes

zone.js: check if process is defined when patching the GlobalErrors.install (#45392) (c7bcc1b), closes #42260
zone.js: in TaskTrackingZoneSpec track a periodic task until it is cancelled (#45391) (f19b36f)
zone.js: read Symbol.species safely (#45369) (e2eaac3)
zone.js: should ignore multiple resolve call (#45283) (aebf165), closes #44913
zone.js: swallow the error when the element callback is not patchable (#45400) (4ea70e3), closes lwc/engine-core/src/framework/base-bridge-element.ts#L180-L186 #42546

BREAKING CHANGES

zone.js: in TaskTrackingZoneSpec track a periodic task until it is cancelled

The breaking change is scoped only to the plugin
zone.js/plugins/task-tracking. If you used TaskTrackingZoneSpec and
checked the pending macroTasks e.g. using (this.ngZone as any)._inner ._parent._properties.TaskTrackingZone.getTasksFor('macroTask'), then
its behavior slightly changed for periodic macrotasks. For example,
previously the setInterval macrotask was no longer tracked after its
callback was executed for the first time. Now it's tracked until
the task is explicitly cancelled, e.g with clearInterval(id).
0.11.5 (2022-03-03)
Bug Fixes

zone.js: async-test should only call done once (#45025) (dea7234)
zone.js: defineProperties should also set symbol props (#45098) (b437d12), closes #44095
zone.js: fix several test cases which trigger done() multiple times (#45025) (d5565cc)
zone.js: only one listener should also re-throw an error correctly (#41868) (299f92c), closes #41867 /github.com/angular/angular/pull/41562#issuecomment-822696973
zone.js: patch global instead of Mocha object (#45047) (8efbdb5), closes #42834
zone.js: should continue to executue listeners when throw error (#41562) (008eaf3), closes #41522
zone.js: update several flaky cases (#41526) (25a83eb), closes #41434

Features

zone.js: add Promise.any() implementation (#45064) (4d494d2), closes #44393
zone.js: update electron patch to support electron/remote 14 (#45073) (d65706a), closes #43346

0.11.4 (2021-02-10)
Bug Fixes

zone.js: fesm2015 bundle should also be strict module. (#40456) (f35f7c6), closes #40215 #40215
zone.js: fix typo in zone_externs (#40348) (8116edb)
zone.js: patch child method that overrides an already patched method (#39850) (82e3f54)
zone.js: setTimeout patch should clean tasksByHandleId cache. (#40586) (0652b29), closes #40387
zone.js: update build tooling for latest changes in rules_nodejs (#40710) (2827845)

Features

zone.js: monkey patches queueMicrotask() (#38904) (27358eb), closes #38863

0.11.3 (2020-10-27)
Bug Fixes

zone.js: remove global declaration (#37861) (90c0772), closes #37531

0.11.2 (2020-09-19)
Bug Fixes

zone.js: jest getRealSystemTime should return native time (#39127) (ffc3332)
zone.js: add missing types field in package.json (#38585) (27cc56b), closes #38584
zone.js: defineProperty patch should not swallow error (#37582) (45a73dd), closes #37432
zone.js: run tests in umd format (#37582) (40096be)
zone.js: should have better backward compatibilities (#38797) (a33d630), closes #38561 #38669
zone.js: should invoke xhr send task when no response error occurs (#38836) (d92a0dd), closes #38795
zone.js: zone.js toString patch should check typeof Promise is function (#38350) (18e474f), closes #38361

Features

zone.js: add jest fakeTimers support (#39016) (82d54fe), closes #38851

Refactor

zone.js: refactor(zone.js): rename several internal apis in fake async zone spec (#39127) (8a68669)

Build

zone.js: build(zone.js): zone.js should output esm format for fesm2015 bundles (#39203) (822b838)

BREAKING CHANGES

zone.js: ZoneJS no longer swallows errors produced by Object.defineProperty calls.

Prior to this change, ZoneJS monkey patched Object.defineProperty and if there is an error
(such as the property is not configurable or not writable) the patched logic swallowed it
and only console.log was produced. This behavior used to hide real errors,
so the logic is now updated to trigger original errors (if any). One exception
where the patch remains in place is document.registerElement
(to allow smooth transition for code/polyfills that rely on old behavior in legacy browsers).
If your code relies on the old behavior (where errors were not thrown before),
you may need to update the logic to handle the errors that are no longer masked by ZoneJS patch.
0.11.1 (2020-08-19)
Bug Fixes

zone.js: zone.js package.json should not include files/directories field (#38528) (6b662d1), closes #38526 #38516 #38513

Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Enabled.
♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.
👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.

[ ] If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

⚠ Artifact update problem
Renovate failed to update an artifact related to this branch. You probably do not want to merge this PR as-is.
♻ Renovate will retry this branch, including artifacts, only when one of the following happens:

any of the package files in this branch needs updating, or
the branch becomes conflicted, or
you click the rebase/retry checkbox if found above, or
you rename this PR's title to start with "rebase!" to trigger it manually

The artifact failure details are included below:
File name: package.json
Command failed: [ -f migrations.json ] && npx --no-install nx migrate --run-migrations=migrations.json


Update connection.json

Added the credentials for enabling access to Snowflake Account

Should not commit connection.json


deprecate the unused validPlutusdata function

At one point in the design of the Alonzo specification, we imposed a sixty-four byte limit on Plutus Data bytestrings, which the
validPlutusdata function enforced.
This was later relaxed, see:
https://github.com/input-output-hk/plutus/blob/fd927b1b9cb3292ed3409b0d40f0dcf627e13323/plutus-core/plutus-core/src/PlutusCore/Data.hs#L84
We now deprecate the validPlutusdata function and remove it from the Alonzo ledger specification (it was also unused in the spec).
resolves #2940

Worth adding a changelog entry?


docs(website): Clarify the Installer docs section

This fixes a small typo and adds more explicit details on how to get MLAPI installed (even though the gif is fairly detailed already, to have the supporting text be just as much).
Not entirely sure what changed in the last Installation line, quickly edited this using the web-based Github editor so I imagine there's some linebreak difference? (\r\n vs \n or something)

:tada: This PR is included in version 9.1.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


IOS 13.3 TextStyle FontWeight being completely Ignored

Hi, after upgrade my ios to 13.3, my flutter app cannot display bold (compare to before upgrade and in android)
Is it problem with ios 13.3 ? Or there's breaking changes in flutter for ios ? Android works fine

This isn't exclusive to iOS. I don't know if it's a problem with my phone, but when the apk is installed on my phone, fontWeight is completely ignored and my Text widgets don't look the same as they do on the simulator.

Same here. FontWeight is not working properly on iOS

The issue has made it to the beta channel, not just in master or dev channels @iapicca

I'm also facing this problem.
But I didn't figure it was related to the iOS version. I thought it was a problem with device models.
Newer devices doesn't show bold and older devices do.
I created a test app for that if needed.

Just build and run. It shows bold on iPhone 6 but not on 11.

11 Pro Max and SE4 the same issue

I can confirm this is related to the flutter version, with the latest flutter version all my headings are no longer bold. My previous build, with an older flutter version, works as it should on an iPhone 11 pro with the latest iOS version.

Same issue for me - nothing is bold on iOS anymore. Running the app on an iPhone 8.
Doctor summary (to see all details, run flutter doctor -v):
[✓] Flutter (Channel beta, v1.14.6, on Mac OS X 10.15.2 19C57, locale en-CA)

[✓] Android toolchain - develop for Android devices (Android SDK version 28.0.3)
[✓] Xcode - develop for iOS and macOS (Xcode 11.3.1)
[✓] Android Studio (version 3.5)
[✓] VS Code (version 1.41.1)
[✓] Connected device (1 available)

@x4080 Probably should just change the title to “TextStyle FontWeight being completely Ignored”

Same issue, faced in beta channel.

Poor iOS.  Seems no one ran an app one time on iOS for this build, bc its a pretty dramatic UI change when all the font weights are dropped from your app.

I guess the flutter team have moved on to better things 🤷♂

Is there a single dev from the flutter team following this?
This is not a critical bug but I consider it major. Should be addressed with urgency.

Seems like a pretty severe regression. @GaryQian could you take a swing at this one?
@ others, is this specifically an iOS 13.3 issue that's not reproducible in other iOS versions?

This regressed due to a change in Skia: https://github.com/google/skia/commit/d5eebba99ee2a20b9f812094614b401440b2132f

Thanks for the quick find. Can we start a rollback in the meantime?

There's some chat going on now with the Skia team about how to properly resolve this.

Quick update - apparently we can't revert the offending commit because it's necessary for Chrome.  Still trying to figure out right way to fix this.

@ others, is this specifically an iOS 13.3 issue that's not reproducible in other iOS versions?

Yes. Not sure if it is specifically 13.3 that introduces the issue, but definitely not there in 12.4 I just tested on the simulators

@ others, is this specifically an iOS 13.3 issue that's not reproducible in other iOS versions?

Yes. Not sure if it is specifically 13.3 that introduces the issue, but definitely not there in 12.4 I just tested on the simulators

Yes I think it effects all iOS versions, looks like a issue with the flutter engine.
I have tested it on these devices:
iPhone 11 Pro (13.4)
iPhone 7 (13.3)
iPhone 5s (12)

@bungeman believes he has a fix for this that will be ready in the next day or two.

Thanks for following up @dnfield. Can someone confirm that https://github.com/google/skia/commit/d5eebba99ee2a20b9f812094614b401440b2132f was the cause of the font weight issue on all iOS versions (and that this problem indeed affects all versions)?

@xster - according to Ben, we cannot revert that PR because it fixes something essential for Chrome. We're fairly sure that it is the cause, but we need a different work around landed than reverting it.
Perhaps Ben will be able to update this issue with more details.

Any news ?

Hello guys.
Isn't it about time to find a temporary fix for this? This is a pretty relevant bug and it has been around for weeks already.
If skia can't rollback, then can't flutter rollback on the skia version?
Or add an if(CHROME) or something? It isn't pretty but we need a workaround for this until a permanent fix is found.
I'm getting pretty bad reviews and complains because of this and as we all know, this hurts badly.

There is a patch for Skia that should fix this being reviewed now.
Unfortunately, the internals of this involve a bunch of strangeness around the way CoreText handles fonts.  It's not a trivial thing to manage or just ifdef out.  And unfortunately, the severity of this bug did not come to the attention of anyone who could act on it until well after it had been reported.
This is very actively being worked on, and should have a resolution soon.  For now, your best bet is to use the stable channel of Flutter, and avoid beta until this is resolved.

Thanks for the reply @dnfield.
Im using masterbecause thestable were giving me other problems. Maybe its fized now, I`ll give it a try.

@dpedrinha Is it fix now in master ? I'm using master too

https://skia-review.googlesource.com/c/skia/+/272116 Is the latest attempt.
No, this is still not fixed on master.

I tried using the stable channel but then I get Error: No named parameter with the name 'bodyText2'. and I can't compile. If I use body2, I keep getting a warning of it being deprecated and that I should use bodyText2. But, it doesn't work.
So the stable channel is not that stable.

I have a couple projects that are backed into a corner because of this. We're using the new Material textTheme on dev so we cannot revert to stable because these new properties are missing.

Can someone provide an ETA on this landing on dev, much appreciated.

Please can you advise what version I can revert to, to mitigate this issue? I assume this is possible? Thx

Please can you advise what version I can revert to, to mitigate this issue? I assume this is possible? Thx

Stable version is working.
flutter channel stable does the trick.

Stable works but it’s missing the new material theme properties which one of our apps depends on heavily.

https://skia-review.googlesource.com/c/skia/+/272116 landed upstream in Skia. It'll take a day or 2 for it to percolate through to Flutter master.

This should be fixed on master now, after https://github.com/flutter/flutter/pull/51480
Can anyone experiencing this pleast test on master and verify?

I can verify the fix is working.
Upgrading from beta to master wasn't easy due to some recent breaking changes I ran into https://github.com/flutter/flutter/pull/48346, https://github.com/flutter/flutter/pull/44930, https://github.com/flutter/flutter/pull/51435

Verified too, on master commit 1cc8cc299

I confirm, fixed.

Will this be expedited to the beta channel, or are the dependencies too big to allow it?

@tvolkert

@scopendo it should make it to the beta channel in the next beta release, but it won't be cherry-picked, so the next beta release will also contain the API-breaking changes you see on master.

Hey @tvolkert. I'm new to flutter dev so sorry if this is an obvious question. But are there periodic releases to beta channel or is it just "whenever it happens"? Just trying to figure out if I can wait for this or find an alternative. Thank you!

@jlubeck see https://github.com/flutter/flutter/wiki/Release-process#rolling-the-beta-channel.  tldr: beta releases are generally once a month early in the month (will likely be early next week).
Side-note: we're in the process of defining a new release process that should allow us to publish a calendar so people can plan on our beta and stable releases.  Stay tuned 🙂

Nice, thank you @tvolkert !

Nice, beta was published and this is now fixed on beta channel


Transition from bazel-genfiles to bazel-bin

@keith mentioned today that bazel-genfiles will soon unified with bazel-bin. XCHammer will have to be updated accordingly. See

https://github.com/bazelbuild/bazel/issues/6761
--incompatible_merge_genfiles_directory in https://docs.bazel.build/versions/master/command-line-reference.html

There's bazel info bazel-genfiles and bazel info bazel-bin which could be used to aid transition.


'sudo' is not recognized as an internal or external command, operable program or batch file.

Hi, well I have an issue
when I tried to execute this line in windows 8.1
sudo apt-get install python3-pyqt5.qtwebengine
sudo' is not recognized as an internal or external command,
operable program or batch file.
What should i do?

How do I say this...
sudo and apt-get are Linux commands. They simply will not work in windows.


Smart Screen SDK goes from listening to idle

IMPORTANT: Before you create an issue, please take a look at our Issue Reporting Guide.
Briefly summarize your issue:

I have alexa smart screen sdk running on a raspberry pi 4.
The smart screen sdk installed without any errors.
When i open the index.html file in the browser it shows alexa is idle.
Whenever i press A and ask a command the status directly goes from idle to listening to idle again.
I think it is not capturing any audio please check
What is the expected behavior?

Status should go from listening to thinking to speaking.
What behavior are you observing?

Whenever i press A and ask a command the status directly goes from idle to listening to idle again.
I think it is not capturing any audio please check
Provide the steps to reproduce the issue, if applicable:

#################################
ALEXA STATE: IDLE
#################################
######################################
ALEXA STATE: LISTENING
######################################
2020-06-27 09:32:14.240 [  2] I DirectiveProcessor:setDialogRequestIdLocked:oldValue=d888d6e3-e638-4417-a069-15b92ac6d520,newValue=cb2273bf-2b35-4741-bc98-c9c221d31708
2020-06-27 09:32:14.720 [  2] E AudioInputProcessor:executeRecognizeFailed:reason=Barge-in is not permitted while busy
2020-06-27 09:32:14.805 [  2] E AudioInputProcessor:executeRecognizeFailed:reason=Barge-in is not permitted while busy
2020-06-27 09:32:14.806 [  2] E AudioInputProcessor:executeRecognizeFailed:reason=Barge-in is not permitted while busy
2020-06-27 09:32:14.899 [  2] E AudioInputProcessor:executeRecognizeFailed:reason=Barge-in is not permitted while busy
2020-06-27 09:32:14.901 [  2] E AudioInputProcessor:executeRecognizeFailed:reason=Barge-in is not permitted while busy
2020-06-27 09:32:14.985 [  2] E AudioInputProcessor:executeRecognizeFailed:reason=Barge-in is not permitted while busy
2020-06-27 09:32:14.987 [  2] E AudioInputProcessor:executeRecognizeFailed:reason=Barge-in is not permitted while busy
2020-06-27 09:32:15.043 [  e] W Channel:notifyActivitiesFailed::No Associated Activities Found
2020-06-27 09:32:15.067 [  2] I DirectiveProcessor:setDialogRequestIdLocked:oldValue=cb2273bf-2b35-4741-bc98-c9c221d31708,newValue=9919c1a5-303d-4fef-b454-a84dc7448c92
2020-06-27 09:32:15.148 [  2] E AudioInputProcessor:executeRecognizeFailed:reason=Barge-in is not permitted while busy
2020-06-27 09:32:15.153 [  2] E AudioInputProcessor:executeRecognizeFailed:reason=Barge-in is not permitted while busy
2020-06-27 09:32:15.224 [  2] E AudioInputProcessor:executeRecognizeFailed:reason=Barge-in is not permitted while busy
2020-06-27 09:32:15.227 [  2] E AudioInputProcessor:executeRecognizeFailed:reason=Barge-in is not permitted while busy
2020-06-27 09:32:15.305 [  2] E AudioInputProcessor:executeRecognizeFailed:reason=Barge-in is not permitted while busy
2020-06-27 09:32:15.308 [  2] E AudioInputProcessor:executeRecognizeFailed:reason=Barge-in is not permitted while busy
2020-06-27 09:32:15.403 [  2] E AudioInputProcessor:executeRecognizeFailed:reason=Barge-in is not permitted while busy
2020-06-27 09:32:15.408 [  2] E AudioInputProcessor:executeRecognizeFailed:reason=Barge-in is not permitted while busy
2020-06-27 09:32:15.478 [  2] E AudioInputProcessor:executeRecognizeFailed:reason=Barge-in is not permitted while busy
2020-06-27 09:32:15.481 [  2] E AudioInputProcessor:executeRecognizeFailed:reason=Barge-in is not permitted while busy
2020-06-27 09:32:15.560 [  2] E AudioInputProcessor:executeRecognizeFailed:reason=Barge-in is not permitted while busy
2020-06-27 09:32:15.564 [  2] E AudioInputProcessor:executeRecognizeFailed:reason=Barge-in is not permitted while busy
2020-06-27 09:32:15.635 [  e] W Channel:notifyActivitiesFailed::No Associated Activities Found
2020-06-27 09:32:15.645 [  2] I DirectiveProcessor:setDialogRequestIdLocked:oldValue=9919c1a5-303d-4fef-b454-a84dc7448c92,newValue=54b422ad-9f35-4abe-a829-c794fcd961f1
2020-06-27 09:32:15.725 [  2] E AudioInputProcessor:executeRecognizeFailed:reason=Barge-in is not permitted while busy
2020-06-27 09:32:15.728 [  2] E AudioInputProcessor:executeRecognizeFailed:reason=Barge-in is not permitted while busy
2020-06-27 09:32:15.821 [  2] E AudioInputProcessor:executeRecognizeFailed:reason=Barge-in is not permitted while busy
2020-06-27 09:32:15.824 [  2] E AudioInputProcessor:executeRecognizeFailed:reason=Barge-in is not permitted while busy
2020-06-27 09:32:15.903 [  2] E AudioInputProcessor:executeRecognizeFailed:reason=Barge-in is not permitted while busy
2020-06-27 09:32:15.906 [  2] E AudioInputProcessor:executeRecognizeFailed:reason=Barge-in is not permitted while busy
2020-06-27 09:32:15.987 [  2] E AudioInputProcessor:executeRecognizeFailed:reason=Barge-in is not permitted while busy
2020-06-27 09:32:15.989 [  2] E AudioInputProcessor:executeRecognizeFailed:reason=Barge-in is not permitted while busy
2020-06-27 09:32:16.071 [  2] E AudioInputProcessor:executeRecognizeFailed:reason=Barge-in is not permitted while busy
2020-06-27 09:32:16.074 [  2] E AudioInputProcessor:executeRecognizeFailed:reason=Barge-in is not permitted while busy
2020-06-27 09:32:16.162 [  2] E AudioInputProcessor:executeRecognizeFailed:reason=Barge-in is not permitted while busy
2020-06-27 09:32:16.164 [  2] E AudioInputProcessor:executeRecognizeFailed:reason=Barge-in is not permitted while busy
2020-06-27 09:32:16.232 [  2] E AudioInputProcessor:executeRecognizeFailed:reason=Barge-in is not permitted while busy
2020-06-27 09:32:16.234 [  2] E AudioInputProcessor:executeRecognizeFailed:reason=Barge-in is not permitted while busy
2020-06-27 09:32:16.313 [  2] E AudioInputProcessor:executeRecognizeFailed:reason=Barge-in is not permitted while busy
2020-06-27 09:32:16.316 [  2] E AudioInputProcessor:executeRecognizeFailed:reason=Barge-in is not permitted while busy
2020-06-27 09:32:16.389 [  2] E AudioInputProcessor:executeRecognizeFailed:reason=Barge-in is not permitted while busy
2020-06-27 09:32:16.391 [  2] E AudioInputProcessor:executeRecognizeFailed:reason=Barge-in is not permitted while busy
2020-06-27 09:32:16.471 [  2] E AudioInputProcessor:executeRecognizeFailed:reason=Barge-in is not permitted while busy
2020-06-27 09:32:16.473 [  2] E AudioInputProcessor:executeRecognizeFailed:reason=Barge-in is not permitted while busy
2020-06-27 09:32:16.557 [  2] E AudioInputProcessor:executeRecognizeFailed:reason=Barge-in is not permitted while busy
2020-06-27 09:32:16.562 [  2] E AudioInputProcessor:executeRecognizeFailed:reason=Barge-in is not permitted while busy
2020-06-27 09:32:16.648 [  2] E AudioInputProcessor:executeRecognizeFailed:reason=Barge-in is not permitted while busy
2020-06-27 09:32:16.651 [  2] E AudioInputProcessor:executeRecognizeFailed:reason=Barge-in is not permitted while busy
2020-06-27 09:32:16.726 [  2] E AudioInputProcessor:executeRecognizeFailed:reason=Barge-in is not permitted while busy
2020-06-27 09:32:16.730 [  2] E AudioInputProcessor:executeRecognizeFailed:reason=Barge-in is not permitted while busy
2020-06-27 09:32:16.811 [  2] E AudioInputProcessor:executeRecognizeFailed:reason=Barge-in is not permitted while busy
2020-06-27 09:32:16.814 [  2] E AudioInputProcessor:executeRecognizeFailed:reason=Barge-in is not permitted while busy
2020-06-27 09:32:16.867 [  c] W Channel:notifyActivitiesFailed::No Associated Activities Found
2020-06-27 09:32:16.899 [  2] I DirectiveProcessor:setDialogRequestIdLocked:oldValue=54b422ad-9f35-4abe-a829-c794fcd961f1,newValue=e8c6a6cd-ffeb-4d17-8883-35fd648fd864
2020-06-27 09:32:17.006 [  2] E AudioInputProcessor:executeRecognizeFailed:reason=Barge-in is not permitted while busy
2020-06-27 09:32:17.010 [  2] E AudioInputProcessor:executeRecognizeFailed:reason=Barge-in is not permitted while busy
2020-06-27 09:32:17.075 [  2] E AudioInputProcessor:executeRecognizeFailed:reason=Barge-in is not permitted while busy
2020-06-27 09:32:17.078 [  2] E AudioInputProcessor:executeRecognizeFailed:reason=Barge-in is not permitted while busy
2020-06-27 09:32:17.148 [  2] E AudioInputProcessor:executeRecognizeFailed:reason=Barge-in is not permitted while busy
2020-06-27 09:32:17.150 [  2] E AudioInputProcessor:executeRecognizeFailed:reason=Barge-in is not permitted while busy
2020-06-27 09:32:17.232 [  2] E AudioInputProcessor:executeRecognizeFailed:reason=Barge-in is not permitted while busy
2020-06-27 09:32:17.232 [  2] E AudioInputProcessor:executeRecognizeFailed:reason=Barge-in is not permitted while busy
2020-06-27 09:32:17.310 [  2] E AudioInputProcessor:executeRecognizeFailed:reason=Barge-in is not permitted while busy
2020-06-27 09:32:17.312 [  2] E AudioInputProcessor:executeRecognizeFailed:reason=Barge-in is not permitted while busy
2020-06-27 09:32:17.388 [  2] E AudioInputProcessor:executeRecognizeFailed:reason=Barge-in is not permitted while busy
2020-06-27 09:32:17.391 [  2] E AudioInputProcessor:executeRecognizeFailed:reason=Barge-in is not permitted while busy
2020-06-27 09:32:17.471 [  2] E AudioInputProcessor:executeRecognizeFailed:reason=Barge-in is not permitted while busy
2020-06-27 09:32:17.474 [  2] E AudioInputProcessor:executeRecognizeFailed:reason=Barge-in is not permitted while busy
2020-06-27 09:32:17.484 [  2] E SdsReader:seekFailed:reason=seekBeyondCloseIndex,position=7742464,readerCloseIndex=7742336
2020-06-27 09:32:17.485 [  c] W Channel:notifyActivitiesFailed::No Associated Activities Found
2020-06-27 09:32:17.561 [  2] I DirectiveProcessor:setDialogRequestIdLocked:oldValue=e8c6a6cd-ffeb-4d17-8883-35fd648fd864,newValue=fd460efe-6c84-4279-94a2-7625adc108a8
2020-06-27 09:32:17.669 [  2] E AudioInputProcessor:executeRecognizeFailed:reason=Barge-in is not permitted while busy
2020-06-27 09:32:17.672 [  2] E AudioInputProcessor:executeRecognizeFailed:reason=Barge-in is not permitted while busy
2020-06-27 09:32:17.726 [  2] E AudioInputProcessor:executeRecognizeFailed:reason=Barge-in is not permitted while busy
2020-06-27 09:32:17.728 [  2] E AudioInputProcessor:executeRecognizeFailed:reason=Barge-in is not permitted while busy
2020-06-27 09:32:17.821 [  2] E AudioInputProcessor:executeRecognizeFailed:reason=Barge-in is not permitted while busy
2020-06-27 09:32:17.824 [  2] E AudioInputProcessor:executeRecognizeFailed:reason=Barge-in is not permitted while busy
2020-06-27 09:32:17.899 [  2] E AudioInputProcessor:executeRecognizeFailed:reason=Barge-in is not permitted while busy
2020-06-27 09:32:17.902 [  2] E AudioInputProcessor:executeRecognizeFailed:reason=Barge-in is not permitted while busy
2020-06-27 09:32:17.986 [  2] E AudioInputProcessor:executeRecognizeFailed:reason=Barge-in is not permitted while busy
2020-06-27 09:32:17.989 [  2] E AudioInputProcessor:executeRecognizeFailed:reason=Barge-in is not permitted while busy
2020-06-27 09:32:18.066 [  2] E AudioInputProcessor:executeRecognizeFailed:reason=Barge-in is not permitted while busy
2020-06-27 09:32:18.078 [  2] E AudioInputProcessor:executeRecognizeFailed:reason=Barge-in is not permitted while busy
2020-06-27 09:32:18.089 [  c] W Channel:notifyActivitiesFailed::No Associated Activities Found
2020-06-27 09:32:18.151 [  2] I DirectiveProcessor:setDialogRequestIdLocked:oldValue=fd460efe-6c84-4279-94a2-7625adc108a8,newValue=e43f1272-f49a-49fa-9a8c-0c96923a346d
2020-06-27 09:32:18.247 [  2] E AudioInputProcessor:executeRecognizeFailed:reason=Barge-in is not permitted while busy
2020-06-27 09:32:18.249 [  2] E AudioInputProcessor:executeRecognizeFailed:reason=Barge-in is not permitted while busy
2020-06-27 09:32:18.312 [  2] E AudioInputProcessor:executeRecognizeFailed:reason=Barge-in is not permitted while busy
2020-06-27 09:32:18.313 [  2] E AudioInputProcessor:executeRecognizeFailed:reason=Barge-in is not permitted while busy
2020-06-27 09:32:18.322 [  2] E AudioInputProcessor:executeRecognizeFailed:reason=Barge-in is not permitted while busy
2020-06-27 09:32:18.821 [  c] W Channel:notifyActivitiesFailed::No Associated Activities Found
#################################
ALEXA STATE: IDLE
#################################
Tell us about your environment:

What version of the AVS Device SDK are you using?
  <x.y.z>

Tell us what hardware you're using:

[x] Raspberry Pi

Tell us about your OS (Type & version):

[ ] Linux
[ ] MacOS
[ ] Raspbian Stretch
[ ] Raspbian Jessy
[ ] Other - tell us more:

Have you tried the same use case with AVS Device SDK SampleApp?

[x] The issue is not applicable to the AVS Device SDK SampleApp.
[ ] The issue is not reproducible on the AVS Device SDK SampleApp.

@rahilranka
Thank you for reporting the issue to us.
Please provide the information below

How are you interacting with your Pi? Are you having a physical keyboard connected to the Pi or are you controlling it through VNC?
Can you share your SmartScreenSDK configuration with us?

Mike

I tried using both a physical keyboard and a vnc connection
Nothing seems to work.
How to share the configuration?

@rahilranka
So the issue happens even when you have a physical keyboard connected to your Pi, and you press A on the keyboard?
The smart screen configuration is the second file that you pass in when you run your SampleApp.
Mike

@rahilranka
This is a known issue when using VNC, as VNC sends multiple keystrokes when holding a key.
Closing this issue due to inactivity,  if you are seeing the same issue with a physical keyboard plugged directly into the pi, please attach your smart screen configuration file and reach out again.

Yes, the issue was with a VNC connection, using an onscreen keyboard worked for me!
Is there a way to add the wake word to the smart screen sdk instead of pressing a button


MCLeaks accounts work.

Version 5.11.37
Is there anything that must be done to activate the MCLeaks protection?
I see the API is option...
Without an API key, it seems MCLeaks accounts login to the server. Is this perhaps a bug, or is an API key required to activate this protection?

The API Anti-VPN uses to check is available on Github here. There are API keys available, but you'll have to follow the directions pointed out in the config here.
MCLeaks detection is an art of black magic, much as VPN detection is. It might not be perfect, but I tested a few accounts and it seems to work well enough to make it difficult for players.

Yes, it seems after adding the API key I was provided with from the owner, everything started to work correctly.
Forgot to close this issue, my bad :P

Strange. The main Github page says API keys are option, but maybe you have enough players that you reached a quota and it was required for you. Either way, thanks for reporting!


[Bug Report] Error in new version

What is the issue you are having?
Updated to version 4.95. An error occurs when inviting a party or accepting a party
What is the expected behavior?
There should be no errors.
What actually happened?
I get an error message
Suggested Solution/Workaround
/muierror command
Only ElvUI (v12.79), ElvUI_MerathilisUI (v4.95)
Errors
5x ...\ElvUI_MerathilisUI\Mainline\Modules\Misc\Alerts.lua:100: Usage: RegisterEvent("eventname", "methodname"): 'methodname' - method 'UNIT_SPELLCAST_SUCCEEDED' not found on self.
[string "=[C]"]: ?
[string "@ElvUI\Libraries\Core\Ace\CallbackHandler-1.0\CallbackHandler-1.0-7.lua"]:112: in function `RegisterEvent'
[string "@ElvUI_MerathilisUI\Mainline\Modules\Misc\Alerts.lua"]:100: in function <...\ElvUI_MerathilisUI\Mainline\Modules\Misc\Alerts.lua:98>
[string "=[C]"]: ?
[string "@ElvUI\Libraries\Core\Ace\CallbackHandler-1.0\CallbackHandler-1.0-7.lua"]:29: in function <...Core\Ace\CallbackHandler-1.0\CallbackHandler-1.0.lua:25>
[string "@ElvUI\Libraries\Core\Ace\CallbackHandler-1.0\CallbackHandler-1.0-7.lua"]:64: in function `Fire'
[string "@ElvUI\Libraries\Core\Ace\AceEvent-3.0\AceEvent-3.0-4.lua"]:120: in function <...vUI\Libraries\Core\Ace\AceEvent-3.0\AceEvent-3.0.lua:119>

ElvUI Changelog/Troubleshooting

[X] I have confirmed that I have read the Changelog and done the Troubleshooting Steps.

Already been addressed in commit 2de2a62  He just hasnt done a release yet with it

Thanks for reporting it, preparing a release.


Progress bar disappears after processing one of many files

This is caused by using the max_files argument on the uploader object.
-The files are all uploaded
-The progress  bar loads onto the screen
-The bar fills until one file is processed then it disappears
-The bar fills to the proper amount before it disappears, i.e. there are 4 files total it will fill to 1/4 full then disappear
The max_files feature is WIP, so I wasn't sure if this was a defect that was logged.

Hi Luke, did you try the dev branch version? It should be working properly, although there might be some changes to it before publishing dash-uploader 0.7.0 to PyPi.

What's the best way to install the dev branch? Can I use pip to install it?

You could clone this repository, switch to dev branch and pip install -e <path_to_folder_with_setup.py>, or pick a solution from pip install from git repo branch. If I have some time, I could add some pre-release to PyPI.

@LukeDev42 , I uploaded a pre-release version (0.7.0a1) to PyPI! You can install it with:
python -m pip install dash-uploader --pre

It is a build from the dev branch. Note that this has a bit different callback syntax. See this comment.

Also, my apologies, the methods in the previous comment would not work as you'd also need to build the JS with npm. (There are instructions in the CONTRIBUTING.md for this but you can now just use the PyPI pre-release)

The uuid ensures that for every user, the upload_id of the du.Upload is different. It is just an easy way of giving different session ids to users. The usage of unique upload_ids will ensure that users will not accidentally upload files with same name to same folder, which would lead overwriting files and also mixing up files from different users, or same user with different session.

You can try it our yourself: putting any value to the upload_id and uploading a file will make the file to be uploaded to C:\somerootfolder\<upload_id>\somefile.csv.

I'm glad it worked for you! I'm going to close this now.  Feel free to reopen if you still have issues.


Fix for beta5

Thanks for sending in this PR; I've already prepared one with the same goal which I merged before releasing 0.2.0. Thanks anyway.


feat(test): add etcd simulator

I hereby agree to the terms of the Singularity Data, Inc. Contributor License Agreement.
What's changed and what's your intention?
This PR adds an etcd simulator to deterministic e2e test, and switches the meta backend from 'mem' to 'etcd'.
The implementation of this simulator is very similar to the MemStore in risingwave. But it's running behind the 'network' and follows the etcd API. This will help us check whether we are correctly using these API, and more importantly, handling the unexpected behavior from network and etcd server.
For instance, it can simulate the "etcdserver: request timed out" as we encountered earlier at #4919. This feature is not enabled by default since we have not fixed the bug yet. If you turn this on you will find the meta node panics somewhere. Hope it would be helpful with debugging.
This PR also updates madsim, which fixes memory leak in recovery test and forbids creating system thread.
Checklist

[x] I have written necessary rustdoc comments
[x] I have added necessary unit tests and integration tests
[x] All checks passed in ./risedev check (or alias, ./risedev c)

Refer to a related PR or issue link (optional)
#4919

Nexmark_q7 failed after etcd timeout enabled:
thread '<unnamed>' panicked at 'called `Result::unwrap()` on an `Err` value: test error at e2e_test/streaming/nexmark_endless.slt:10: query result mismatch:
--
  | [SQL] select count(*) > 0 as has_results from nexmark_q7;
  | [Diff]
  | t
  | f

Is this a known issue? cc @BugenZhao

Nexmark_q7 failed after etcd timeout enabled: https://buildkite.com/risingwavelabs/pull-request/builds/7618#01830c5a-65e3-4caf-8398-866600185b9a/812-839
thread '<unnamed>' panicked at 'called `Result::unwrap()` on an `Err` value: test error at e2e_test/streaming/nexmark_endless.slt:10: query result mismatch:
--
  | [SQL] select count(*) > 0 as has_results from nexmark_q7;
  | [Diff]
  | t
  | f

Is this a known issue? cc @BugenZhao

This case tests the generation of nexmark source and it's unstable these days. cc @fuyufjh
However, does the system trigger recovery? If so, It may also be caused by source not correctly recovered.

However, does the system trigger recovery?

No. The only thing is the etcd request may block for 5~15s and then get timeout with a 1% probability.

BAD NEWS: I've found several problems for the following test on my mac:
./risedev sslt --release -- "e2e_test/streaming/**/*.slt"

MADSIM_TEST_SEED=2,3,4,16,19
thread '<unnamed>' panicked at 'Failed to connect to database: Error { kind: Connect, cause: Some(Custom { kind: ConnectionRefused, error: "connection refused" }) }', src/tests/simulation/src/main.rs:365:14

MADSIM_TEST_SEED=9
thread '<unnamed>' panicked at 'no entry found for key', src/meta/src/stream/scheduler.rs:98:23

MADSIM_TEST_SEED=1,15
thread '<unnamed>' panicked at 'called `Result::unwrap()` on an `Err` value: test error at e2e_test/streaming/datagen.slt:18: query result mismatch:
[SQL] select v1, v2 from s1 where v1 is not null limit 15;
[Diff]
1 11
10 20
2 12
3 13
4 14
5 15
6 16
7 17
8 18
9 19

MADSIM_TEST_SEED=17
thread '<unnamed>' panicked at 'called `Result::unwrap()` on an `Err` value: test error at e2e_test/streaming/datagen.slt:48: query result mismatch:
[SQL] select v1 from s1 order by v1 limit 10;
[Diff]
1
2
3
4
5
6
7
8
9
10

MADSIM_TEST_SEED=6,8,10,11,12,13,18
thread '<unnamed>' panicked at 'called `Result::unwrap()` on an `Err` value: test error at e2e_test/streaming/nexmark_endless.slt:10: query result mismatch:
[SQL] select count(*) > 0 as has_results from nexmark_q7;
[Diff]
t
f

MADSIM_TEST_SEED=5,7,14,20
Pass


Evaluation

Can you provide the code to evaluate VFID I3D and VFID ResNext?

Hi, this script Disco can evaluate some commonly used metrics. Note that the concept of FVID here is somewhat different from the usual one, see vid2vid

I have already checked this Disco script, but it provides FID-VID, FVD? Any differences in the implementation of VFID reported in your paper compared to this? Thanks!


Build error - import cycle not allowed

frank@franktop:~/src/etcd-dashboard$ ./build
import cycle not allowed
package github.com/AdoHe/etcd-dashboard
	imports fmt
	imports errors
	imports runtime
	imports runtime/internal/atomic
	imports runtime

@frankscholten I will take a look today.

@frankscholten I tried this on my laptop, it's ok. What's your golang version?


Contact Page

We have no time for the correct model of a contact page, so for now we will do the following:
-[ ] take the code used in the Help button at the bottom of the current crisis cleanup page and add it to the Contact link as the only way to get in touch with us.

that link goes inside the "contact" link.

covered in #425


Recognize form feed and vertical tab as whitespace

Form feed and vertical tab are sometimes used as section separators in source code. This practice is obsolete, and can be seen mostly in old code. I recently opened an old file that uses form feed characters to separate function definitions, and I thought that vim-paragraph-motion should be able to deal such cases.

Nice improvement!

@dbakker
:sweat: There is a typo ... On line 37, '\m\[^[:space:]]' is supposed to be '\m[^[:space:]]'. Sorry about that.

Whoops, the first time I also didn't check it. Fixed!


Add doc on new GKE Stackdriver agents

how to enable
how to view logs, filtered by user labels
how to view metrics in new UI

/assign

We now have this doc:
https://www.kubeflow.org/docs/gke/monitoring/
I think that covers this issue, so I'm going to close the issue. Please do re-open it if there's still doc work to be done.
/close


fixed analyte to be parathyroid hormone

analyte was wrong so corrected and imported parathyroid hormone from PRO. updated OBO_imports with Ontofox

Discussed on 2021-03-29 call: The OBO_output.owl has problems. I will fix them manually this time and merge. Then I will try to fix the larger problem by breaking the imports into smaller pieces.


Fix upgrade from 0.5.3

Problem

Upgrade from 0.5.3 did not work

Solution

Adapted the upgrade script

PR Status

[x] Code finished and ready to be reviewed/tested
[x] The fix/enhancement were manually tested (if applicable)

Automatic tests
Automatic tests can be triggered on https://ci-apps-dev.yunohost.org/ after creating the PR, by commenting "!testme", "!gogogadgetoci" or "By the power of systemd, I invoke The Great App CI to test this Pull Request!". (N.B. : for this to work you need to be a member of the Yunohost-Apps organization)

!testme


lom204

I got this message in wisol module

is it a progress ?

Yes, that's progress. This event indicates that the module booted
correctly. You should be able to issue AT commands to it now.
On Mon, Oct 17, 2022, 12:06 PM tcpipchip @.***> wrote:

I got this message in wisol module
[image: image]
https://user-images.githubusercontent.com/11488460/196227457-bcdc032c-3d11-4765-95aa-87fb6dd5aaf8.png
is it a progress ?
—
Reply to this email directly, view it on GitHub
https://github.com/hardwario/lora-modem-abz/issues/111, or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAEMMA2Y4JXFEGNCYOHEDS3WDV2QRANCNFSM6AAAAAARHHFXC4
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

yeah, i hope soon test  it if all going well we can include lom204 in the board list, right ?
and i intend a blog :)

Yes, we can include it in the list of supported boards if it works. Do you
have the datasheet or schematic for that board?
On Mon, Oct 17, 2022, 12:13 PM tcpipchip @.***> wrote:

yeah, i hope soon test it if all going well we can include lom204 in the
board list, right ?
and i intend a blog :)
—
Reply to this email directly, view it on GitHub
https://github.com/hardwario/lora-modem-abz/issues/111#issuecomment-1281119621,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAEMMAY72YPDZVGFCQPHOULWDV3J7ANCNFSM6AAAAAARHHFXC4
.
You are receiving this because you commented.Message ID:
@.***>

Please use the Discussions tab for general questions like this. I would like to use Issues only for reporting bugs and problems with the software itself.


Prevent adding duplicate markers

ZenHub Information
This information is updated automatically. To modify it, please use ZenHub.

@hajarNasr - Please do fix on branch from staging.  Shayan has details on the code.  See code under /functions.  "yarn" to install code and "yarn serve" to start up.


feat(frontend): add Buy button [GIX-2854]

Motivation
As initial step for OnRamper onbarding, we create the Buy button and a related modal. The modal will be empty for now and the button visible only through a custom env flag VITE_ONRAMPER_ENABLED.

Unsolicited feedback: I'm not that convinced by the display on mobile devices

For what I understood we will simplify that and maybe remove the last one, the context menu, to move it somewhere else


Unclear Audience configuration option for Blazor WASM Hosted with AAD

The Audience configuration option mentioned in Modify the Server appsettings.json configuration is not explained properly and actually breaks the project.

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 3039ff79-ee86-20b1-0082-d3899a84c823
Version Independent ID: af4a3a75-ae52-5f6d-2120-737bc2fefb07
Content: Secure a hosted ASP.NET Core Blazor WebAssembly app with Azure Active Directory
Content Source: aspnetcore/blazor/security/webassembly/hosted-with-azure-active-directory.md
Product: aspnet-core
Technology: aspnetcore-security
GitHub Login: @guardrex
Microsoft Alias: riande

(Will be happy to submit a PR if you approve to remove it from doc.)

Hello @hakenr ... I'll take a look at this first thing in the morning.

Supply more information because it doesn't break the app here. The configuration described was supplied by the product unit and extensively checked by me. Of course, a sneaky 😈 can certainly get into these docs and wreak havoc! 😆 What do you think isn't correct or explained properly about the configuration? What error are you seeing?

Although it's late here ... I'm just about to hit the 🛌💤 ... I just had to know what happens here if that config is removed. The user can still sign into the app, but they can't submit a valid API request thereafter ... it goes 401 💥 on the FetchData component with an invalid audience.
Check that you followed all of the steps and confirm that the rest of the client and server config is correct. This guidance has been like this for some five years now, and I think it's accurate.
If you figure out what the problem is with your app, please post back here what was wrong. It might be something that the topic can remark on to head off other devs hitting the same problem.
I'm going to close this now because there's not enough information to make this actionable, but feel free to post back here with more information. I certainly will re-open the issue if we need to discuss this further.

Hello @guardrex,
although I do not consider myself an OAuth/OIDC expert, I tried to further investigate the scenario.
Hosted with ADD
My observations:

My App ID URI has a form of api://41451fa7-82d9-4673-8fa5-69eff5a761fd (you refer to this variant as trusted in the documentation page we are discussing).
The aud claim for access tokens (JWT) issued in this scenario has api://41451fa7-82d9-4673-8fa5-69eff5a761fd value.
The Audience configuration element in Server app, which works for me in this situation, is

"Audience": "api://41451fa7-82d9-4673-8fa5-69eff5a761fd"

(Omitting the Audience configuration element completely also works, but the audience is not validated in such case, I think.)
Current documentation state

The Modify the Server appsettings.json configuration paragraph currently instructs you to set the Audience element to the  "https://{TENANT DOMAIN}/{SERVER API APP CLIENT ID}", which is probably valid only for App ID URI you refer to as untrusted.
The same instructions are in later in appsettings.json configuration paragraph.

Expected documentation state

Both paragraphs should take into account the different forms of App ID URI and instruct the users to use the appropriate form for all trusted, untrusted (and custom?) variant.

Hosted with ADD B2C
I found similar confusion also in the Secure a hosted ASP.NET Core Blazor WebAssembly app with Azure Active Directory B2C page.
Current documentation state
The appsettings.json configuration paragraph says

Add the following audience entry to the AzureAdB2C configuration:
{
 "AzureAdB2C": {
   "Instance": "https://{TENANT}.b2clogin.com/",
   "ClientId": "{SERVER API APP CLIENT ID}",
   "Domain": "{TENANT DOMAIN}",
   "Scopes": "{DEFAULT SCOPE}",
   "SignUpSignInPolicyId": "{SIGN UP OR SIGN IN POLICY}"
 }
}

But the configuration sample does not include Audience et al, and the "Add the following audience entry to the AzureAdB2C configuration" sentence probably originates from the Hosted with AAD article and does not make full sense for Hosted with AAD B2C article.
Expected documentation state
The Add the following audience entry to the AzureAdB2C configuration: sentence should be replaced with something appropriate not referring to audience or removed completely.

I can submit a pull-request for the suggested changes, but as you mentioned, the part of the documentation in question should be reviewed by the appropriate product unit.

Thanks for the additional information. The trusted and untrusted publisher domains were tested, albeit several years ago, and the guidance I thought from that time worked in both scenarios.
Yes, I think Javier from the product unit should look, but I suspect that he won't have additional light to shed on trusted versus untrusted publisher domains because the original content that he sent over to publish these articles had no information on trusted and untrusted publisher domains. I added all of that content based on testing and discussion with another product unit engineer later, Jean-Marc, and the updates were focused on setting the scopes, not the audience. IIRC, all of the Azure docs on trusted/untrusted publisher domains don't (or didn't) say anything about the audience changing. I'll need to double-check that content tho.
No, don't send a PR at this point. We'll need to investigate this further before changes are made. I'll also probably want to take this on myself due to the complex nature of these articles and because the changes span several articles, perhaps also reaching into the standalone WASM group.
For now, let me ping @jmprieur ... Jean-Marc, you may recall that we discussed the subject of trusted/untrusted publisher domains several years ago for the Blazor security articles. At the time, I worked out that the scopes changed based on the behavior of Azure and my test apps, but I didn't understand why Azure insisted on a different scope format for trusted publisher domains. You clued me into the trusted/untrusted publisher domain situation. From there, I worked with the Azure docs, tested with a trusted publisher domain, and thought that I fixed up the documents sufficiently to deal with the two scenarios. I focused on the setting the scopes and cross-linking to the Azure docs on the subject. IIRC, both my trusted and untrusted domain test apps worked using the guidance here. @hakenr is saying that in addition to the scopes, the audience also changes. I didn't think that was the case from testing several years ago. Can you shed any light on the audience also changing between trusted and untrusted publisher domains?
cc: @javiercn

The Add the following audience entry to the AzureAdB2C configuration: sentence should be replaced with something appropriate not referring to audience or removed completely.

Agreed! I think you're correct. That might be due to a blown copy-paste 😈. I'll take care of that bit right now.

I have time to work on this right now, so let me see if I run through it with a trusted publisher domain if I can repro this.
I see my test registrations in Azure are still there, but I don't see them for the Server app of a hosted scenario. I see the registrations for standalone apps with a trusted publisher. I'll create new registrations and walk the entire process.

@hakenr ... What authority did you use in the Client app (wwwroot/appsettings.json)? Did you use https://{TENANT DOMAIN}/{SERVER API APP CLIENT ID} format, or did you use the api://41451fa7-82d9-4673-8fa5-69eff5a761fd format?

Oops, sorry, now I see I'm not sure what you were asking:

@hakenr ... What authority did you use in the Client app (wwwroot/appsettings.json)? Did you use https://{TENANT DOMAIN}/{SERVER API APP CLIENT ID} format, or did you use the api://41451fa7-82d9-4673-8fa5-69eff5a761fd format?

The Authority element in my Client app is https://login.microsoftonline.com/8a985c51-849c-4529-b45f-47c54c81b751:
{
	"AzureAd": {
		"Authority": "https://login.microsoftonline.com/8a985c51-849c-4529-b45f-47c54c81b751",
		"ClientId": "85ea08a8-5acd-4fb2-858b-397003778ea5",
		"ValidateAuthority": true
	},
	"Auth": {
		"WebServerScope": "api://d698d677-01b0-489a-b617-0fe57a4397a0/API.Access"
	}
}

Note that I'm going OOF outside of some unrelated communication with management on some other PRs. I'll get back to this issue on Monday.
I'm waiting to hear back from them on the general direction to take here because they might tell me to punt all of this publisher domain/custom domain business to the Azure docs ... i.e., it's an Azure thing, and the Azure docs should cover it. Or ... indeed ... they might tell me to work on this and try to flesh out this audience problem.
WRT your latest comment ...

"Authority": "https://login.microsoftonline.com/8a985c51-849c-4529-b45f-47c54c81b751",

I see. That's interesting. Well ... I'll need to get back to this on Monday I think. If they tell me to work on this further for our docs, then I'm going to need to proceed with full testing of a custom+verified domain that's then a trusted publisher for the app registration. I'll need to see what's what in testing before trying to cover anything on this.
Javier was pinged on that email message, too. He didn't address these thornier aspects in his original content for this group of articles. I'm not sure if he'll have a suggestion to management on if I should punt or cover it. We'll just need to see how it plays out. I'll place a message here as soon as I hear back. Given that today is Friday 🎉, it wouldn't surprise me if I hear back sometime early next week.

The public repo which demonstrates my setup: https://github.com/havit/NewProjectTemplate-Blazor
The Audience configuration element we are discussing:
https://github.com/havit/NewProjectTemplate-Blazor/blob/a73ac0d323dbd335e5db5700c9d195333988c055/Web.Server/appsettings.WebServer.Development.json#L31-L34
The parent configuration file with rest of AzureAD elements configured:
https://github.com/havit/NewProjectTemplate-Blazor/blob/a73ac0d323dbd335e5db5700c9d195333988c055/Web.Server/appsettings.WebServer.json#L40-L47
Feel free to ask for any further details (e.g. AAD configuration).
(Of course, it's possible that I'm using it all wrong, and I'll be happy with even that finding if it puts me on the right track.)

The audience of a web API needs to match the aud claim in the access token that will be used to call the web API (and that the web API will validate). This claim is the GUID of the web API when the AAD v2.0 endpoint is used, and the App ID URI when the AAD v1.0 endpoint is used.
So I suppose that having the GUID all the time would work?

Thanks @jmprieur ...
The App ID URI is for AAD v1.0 endpoints, except that when I'm not in my default directory it defaults to (and demands that I use) https://{TENANT DOMAIN}/{SERVER API APP CLIENT ID}. When I'm in the default directory, it defaults to the format (api://{APP CLIENT ID GUID}† and can be changed to any valid URI (the Azure portal lists the valid schemes).
†"APP CLIENT ID GUID" in this case is the server API Application (client) ID just to be clear, not the "client" as in the client ID for the client app making the request.
That's the main problem for the audience/App ID URI coverage: At least a few years ago, Azure AD and Azure docs aren't clear on why these two different App ID URIs are being used. There's been a lot of churn in the Azure docs since then, and I'll read the latest versions of everything. I hope I find an explanation over there.
When we discussed this a few years ago, I adopted the reason for this difference in App ID URI as due to the domain being trusted or not, but now it looks more like it has to do with whether or not the app registration is in the default directory. It doesn't look like its due to the XXXX.onmicrosoft.com domain being "trusted" because it has a ⚠ next to it and says, "The application’s consent screen will show ‘Unverified’." That's not trusted AFAICT, so why do I receive a default of "api://{GUID}` as the App ID URI? It looks like it's due to the app being in the default directory ... or some other reason.
I'm inclined to try and cover the whole subject of what App ID URI to use along the lines of what you just said ... the dev must match the aud claim of the access token (in the scope provided in the client app) to the audience of the server API. If I can work out the text and examples in a generic way, I think I can resolve this problem with the guidance.
I'm going to dig into this on Monday morning and see what I can come up with.
Thanks again for your help, @jmprieur.

@jmprieur ... I've investigated further, and I've noticed a version difference, but it doesn't seem relevant to how the AAD registration is behaving. Just to recap, we're looking at why the Azure portal is defaulting two different App ID URIs ...

https://{TENANT DOMAIN}/{SERVER API APP CLIENT ID} - Where only the {SERVER API APP CLIENT ID} is under dev control.
api://{SERVER API APP CLIENT ID GUID} - Where the entire App ID URI is under dev control with some scheme limitations that the portal mentions when one edits the value.

Prior to just a few minutes go, the only obvious difference is that the former App ID URI is registered in a non-default AAD directory, and the latter is registered in the default AAD directory. Every app registration between these two directories default the App ID URI based on non-default and default directory where the app registration occurs.
A test app registered in the non-default directory, where I'm forced to use the https://{TENANT DOMAIN}/{SERVER API APP CLIENT ID} format, makes an OpenID config request at ...
https://login.microsoftonline.com/d7b22ce5-9645-4b38-9f0f-957d01b2a155/v2.0/.well-known/openid-configuration

... with the response including ...
"token_endpoint":"https://login.microsoftonline.com/d7b22ce5-9645-4b38-9f0f-957d01b2a155/oauth2/v2.0/token"

BUT ... when that app later makes a request to a server API endpoint (in my test case, it's just with the OOB FetchData component for weather forecast data from the WeatherForecastController), the access token includes ...
"ver": "1.0"

... which I think means the v1.0 endpoint. I think following our guidance at ...
https://learn.microsoft.com/en-us/aspnet/core/blazor/security/webassembly/additional-scenarios?view=aspnetcore-7.0#use-openid-connect-oidc-v20-endpoints
... that I can change that. However, the weather forecast data request (and its ver with 1.0 entry) is a downstream behavior of what AAD's app registration is defaulting to and forcing me to use for the App ID URI in the first place. There is still some factor at the app registration level that's controlling the App ID URI default. It could somehow be hidden from me that the app is somehow tied to v1.0 in the portal, but it's not obvious if that's the case, including by looking at app registration manifest files across the two directories.
I think I can write around the problem by not specifically mentioning/showing exact values for the App ID URI. Readers will use whichever format the portal provides. I'll word it along the lines of what you said ... the audience must match. I can at least take this approach with the guidance until I have a better answer on the AAD registration behaviors.

NOTE TO SELF: I'm placing some Azure docs resources that should be helpful here, possibly to include as cross-links for the coverage changes. There are about 20-30 articles in Azure docs that mention "App ID URI," and I'm going to look at all of them and see what I can dig up ⛏ ...

Scopes the possible values but doesn't say why the Azure portal would default to a particular one: https://learn.microsoft.com/en-us/azure/active-directory/develop/reference-app-manifest#identifieruris-attribute

Ok ... I might have drawn a valid conclusion on it 😅 ...

"Azure Active Directory" tenant type: Uses a default "tenant-verified" publisher domain as far as the App ID URI is concerned, BUT it's still described as an "unverified" (not trusted) publisher domain in the portal's Branding & properties UI.
"Azure Active Directory B2C" tenant type: Uses a publisher domain that isn't "tenant-verified." It's also "unverified" (not trusted) as a publisher domain in the portal.

So, the format of App ID URI doesn't default to a format on the concept of "trust" (or verification) for the publisher domain. The tenant type in use where the app is registered is what controls the format.
The Azure portal is conflating "verification" concepts AFAICT. The "tenant verification" part for dictating the App ID URI seems like a separate Azure concept from the "publisher domain verification" part for dictating trust of the domain.
@jmprieur ... Does that sound right to you?

@guardrex Yes, my tenant type is "Azure Active Directory" (the so called B2B).

I thought so. I think that's ☝ the right way to look at this.
Still tho ... the way to cover this isn't to get too deep into the weeds on it here ... in the Blazor docs. These are Azure concepts to be mostly covered by the Azure docs.
What I'd like to do is cross-link that last resource that I mentioned earlier and try to mention this difference in the App ID URI briefly in passing here. I'd like to angle the coverage on how to set up the apps in the direction of the dev taking what the portal defaults to (or what they set in the case of an AAD-type tenant) and get that into the default access token scope and in the server API authority without confusion so that they match.
I've already started the PR. Unless @jmprieur comes on say that I've gone 😵 sideways, I should have the PR up within a few hours, and I'll ping u (and him) on that to see how it plays out.

Notice how that author described it ...

depends on where the app is registered

I wouldn't use "where" there ... "where" where??!! That's confusing.

depends especially on whether the app is registered in a tenant

I thought ALL Azure AD apps had to be registered in a tenant. That's confusing.

whether the tenant has tenant-verified domains

Doesn't say what that means ... it apparently means AAD vs. AAD B2C tenant types ... the former uses "tenant-verified domains" and the other doesn't. That's confusing.
I'm going to continue checking all 20-30 Azure doc resources to make sure I'm getting the best cross-link, but thus far the best is that (confusing) bit in ...
https://learn.microsoft.com/en-us/azure/active-directory/develop/howto-configure-publisher-domain

It looks like, as you said @hakenr, that if the NON-tenant-verified domain is used (i.e., Azure Active Directory B2C tenant type; e.g., https://{TENANT DOMAIN}/{SERVER API APP CLIENT ID}) that the Authority in the server app settings is required ... the app 401's 💥 if it isn't present. If the tenant-verified domain is used (i.e., Azure Active Directory tenant; e.g., api://{SERVER API APP CLIENT ID GUID}) that the Audience in the server app is not required.
I can't say, @hakenr, if there is a validation, per se, that doesn't take place without that server API app config setting because of course if the wrong value were set for the Audience in the server API app, it certainly wouldn't match what the client has in the aud claim of a request.
Apparently, I can only say at this point that it's required in the non-tenant-verified domain case. I'll see if I can incorporate guidance on the Audience setting on this basis.

More info on that ............
It assumes api://{GUID}. When I changed the App ID URI to a non-default URI of urn://custom-app-id-uri without setting the Audience for the server API app, it 💥 with a 401 until I added to the server API config ...
"Audience": "urn://custom-app-id-uri"

... then it was happy 😄.


Add design kits to library/asset detail pages

Questions

[x] Do design kits belong to libraries and assets? Or are design kits a third resource type (libraries, assets, kits) that we index, then reference across libraries and assets?

Third resource type

[x] If we create a new resource to index kits, would we want these exposed in a catalog of kits?

No, we'll just have a markdown page for design kits "getting started" but with a new MDX component to represent a kit

[x] Would each indexed design kit needs its own detail page? Or would we link out to it (link or action)?

Detail pages are not needed

To do

[x] Add schema

[x] Resource
[x] Relationships

[ ] Add schema validation
[x] Add indexes
[ ] Add relationships
[ ] Create issue for new MDX component

@aubrey-oneal

[x] Design kit type values and definitions
[ ] Review indexed statuses and determine if any need notes and license... really everything indexed

Hey team! Please add your planning poker estimate with ZenHub @jdharvey-ibm @alisonjoseph @francinelucca

Here are the 'core' kits:

Outstanding questions:

Do we need detail pages per kit?
Do we need a catalog of kits that only shows structured data? Or a markdown "getting started" type of page that has body copy inline with resource cards that have data coming form our indexed kits (to show real-time status, etc.)
Would we want to show compatible/applicable kits per library? Per asset too? Or both?

Met with @jeanservaas and Anna to discuss definition of design kits.

Based on our conversation, a design kit is a file that contains elements or components or other utilities. For example, White Theme is a design kit that contains components. Color styles and text styles are design kits (plural) that contain elements.
From this we can have the following data in our Schema that is surface in Get Started.

Type: universal, local
Tool availability: Figma, Sketch, Adobe XD, Axure
Contains: Elements, Components, Utility, etc.

We decided on Universal design kits as a term to refer to all the 'cannon' or 'core' kits designers should get started with. And local to refer to any PAL libraries or other add-ons.
We will still need to exchange 'Design kit' for 'Library' in tool tutorials if that is the term the tool uses.

Here is an example of how it might surface in Getting started.
Step 3: Get universal design kits

Step 5: Get local design kits

@aubrey-oneal the type (elements, components, utility) can we have it so a kit only has one type? Or are there examples where a kit has elements and components so it needs both stated?
Side note, I think we'll want to save global vs local in a consistent manner as libraries/assets that I can show an example of.

@mattrosno I can't think of a situation where a design kit has multiple types. I think we should aim for one type per kit. The point is to set an expectation for what the designer is installing/downloading.
Not following your second point. Do you mean it would be good practice for us to have playbacks that include one universal design kit and one local design kit example to help our audience see the big picture-- and the same for Libraries?

@aubrey-oneal I'll show in an example of how we can treat local design kits. I don't think we should show local design kits in the global design kits page, just like we don't show local components in the global asset catalogs.
That is a v2 thing when we're able to offer team-specific catalogs and guidance (so teams have consolidated global and local assets/kits.)

@mattrosno let's try out the following definitions for types. Feel free to wordsmith.
Components: These design kits contain high fidelity components which have guidance and code on the Carbon platform.
Elements: These design kits implement part of the IBM Design Language. Elements include color, icons, pictograms, text, the Grid template, and UI Shell template.
Wireframes: These design kits contain low fidelity and mid fidelity wireframes, allowing designers to prototype concepts before committing to high fidelity components.
Guidelines: These kits contain bite sized guidance and tools to help with handoff to developers.

Anna helped me better understand the relationship between kits:

Here is an example of the dependencies in Figma for dotcom (via Rich Kummer)
We have a few dependencies in our Figma libraries:
Type tokens from Text Styles - IBM Design Language
Color styles from White theme - Carbon Design System
Icons from Icons - IBM Design Language
Pictograms from Pictograms - IBM Design Language

@mattrosno after talking to Tracey and Jeannie we want the notes on any design kit to be very short (perhaps structured in the future). For now the only notes we found to include are
'Not symbolized' for data-viz-sketch
'Design only' for the four mobile kits