Add more CI

run mvn commands from python tests
throw error on mvn warnings
add test to compile and check _protocol_definitions.py file

This build will fail since #292 has not been resolved.  I will rebase this on top of master after that branch is merged in.  After this commit is merged into master, no branch should be merged into master that does not pass the tests.

Looks good @dcolligan, thanks.
I wonder if we need to do the third part of this: do we gain much extra by generating a _protocoldefinitions.py? It's going to be a bit of a maintenance headache if we need to keep two copies of this schema generation code in sync.

@dcolligan, @jeromekelleher  The following will fix it by making the changes to lines 92 to 100 in process_schemas.py and should make it more Avro-compatible - though we should update it for unlimited sized unions:
                elif isinstance(field.type, avro.schema.UnionSchema):
                    t0 = field.type.schemas[0]
                    t1 = field.type.schemas[1]
                    if (isinstance(t0, avro.schema.PrimitiveSchema) and
                            t0.type == "null"):
                        if isinstance(t1, avro.schema.RecordSchema):
                            ret.append((field.name, t1.name))
                    elif (isinstance(t1, avro.schema.PrimitiveSchema) and
                            t1.type == "null"):
                        if isinstance(t0, avro.schema.RecordSchema):
                            ret.append((field.name, t0.name))
                    else:
                        raise Exception("Schema union assumptions violated")

Below is the output that returns without errors:
(testenv)[schemas]$ flake8 scripts tests
(testenv)[schemas]$ nosetests -v tests
testMaven (test_maven.TestMaven) ... ok
testProcessSchemas (test_protocol.TestProcessSchemas) ... ok

----------------------------------------------------------------------
Ran 2 tests in 34.729s

OK
(testenv)[schemas]$

Hope it helps,
Paul

@pgrosu please make proposed code changes as pull requests against the appropriate repository.
Paul Grosu<EMAIL_ADDRESS>writes:

@dcolligan, @jeromekelleher The following will fix it by making the changes to
lines 92 to 100 in process_schemas.py and should make it more Avro-compatible -
though we should update it for unlimited sized unions:
            elif isinstance(field.type, avro.schema.UnionSchema):
                t0 = field.type.schemas[0]
                t1 = field.type.schemas[1]
                if (isinstance(t0, avro.schema.PrimitiveSchema) and
                        t0.type == "null"):
                    if isinstance(t1, avro.schema.RecordSchema):
                        ret.append((field.name, t1.name))
                elif (isinstance(t1, avro.schema.PrimitiveSchema) and
                        t1.type == "null"):
                    if isinstance(t0, avro.schema.RecordSchema):
                        ret.append((field.name, t0.name))
                else:
                    raise Exception("Schema union assumptions violated")

Below is the output that returns without errors:
(testenv)[schemas]$ flake8 scripts tests
(testenv)[schemas]$ nosetests -v tests
testMaven (test_maven.TestMaven) ... ok
testProcessSchemas (test_protocol.TestProcessSchemas) ... ok

Ran 2 tests in 34.729s
OK
(testenv)[schemas]$
Hope it helps,
Paul
—
Reply to this email directly or view it on GitHub.*

@diekhans I think @pgrosu is suggesting an improvement to the code added in this PR. @pgrosu you can PR your changes against @dcolligan's branch.

It's a bit ambiguous which repo that PR should be made in, since I basically just copied the process_schemas.py code from the server repo to this repo.  So that code's real home is in server.  On the other hand, I'm checking a modified version in here and the code does have to do with validating schemas... I'd say, for now, make the PR against server/ga4gh/scripts/process_schemas.py.
@jeromekelleher yes, that last part is necessary.  If you think that is a headache, compare that to the headache of trying to generate the schemas when you're trying to work on something else in the server repo and finding out that an invalid _protocol_definitions.py file is spit out.
I think all of this discussion is getting at the question of where the code that compiles _protocol_definitions.py should be since, yeah, having two copies of that code does suck.  I propose we migrate any code that does schema compiling/validation/processing/etc. into schemas, but only check in _protocol_definitions.py into the server repo.  The server's process_schemas.py (or whatever it ends up being called) will just invoke code in the schema repo to generate the  _protocol_definitions.py file.  Thoughts?

@diekhans, @fnothaft, @dcolligan  Sorry to reply so late, since I tried several things but I seem to have some Github issues when trying to perform the pull request.  Regarding the updated code, it would be just a quick fix with something more extensive in the future.  So I performed the following steps, but it says that I've been blocked from @dcolligan's repository.  Did I do something incorrectly in the following steps?

First I cloned my repository of schemas:

git clone https://github.com/pgrosu/schemas.git

Then I entered the directory with:

cd schemas

Then I added a remote:

git remote add dcolligan https://github.com/dcolligan/schemas.git

Then I listed the branches:

C:\git_ga4gh\schemas> git branch -r
  dcolligan/more_ci
  origin/AddFragmentToReads
  origin/HEAD -> origin/master
  origin/IncludeRawDataLinks
  origin/master

Next I fetched the more_ci branch:

C:\git_ga4gh\schemas> git fetch dcolligan more_ci
remote: Counting objects: 166, done.
remote: Compressing objects: 100% (58/58), done.
remote: Total 166 (delta 45), reused 9 (delta 9), pack-reused 98Receiving object

Resolving deltas:  11% (6/51)
Resolving deltas: 100% (51/51), done.
From https://github.com/dcolligan/schemas
 * branch            more_ci    -> FETCH_HEAD
 * [new branch]      more_ci    -> dcolligan/more_ci

Then I performed checkout:

C:\git_ga4gh\schemas> git checkout --track dcolligan/more_ci
Branch more_ci set up to track remote branch more_ci from dcolligan.
Switched to a new branch 'more_ci'

Next I added the changes to the process_schemas.py file.

Then I checked the status:

C:\git_ga4gh\schemas>git status
On branch more_ci
Your branch is up-to-date with 'dcolligan/more_ci'.

Changes not staged for commit:
  (use "git add <file>..." to update what will be committed)
  (use "git checkout -- <file>..." to discard changes in working directory)

        modified:   tests/process_schemas.py

no changes added to commit (use "git add" and/or "git commit -a")

Next I performed the commit of the changes:

C:\git_ga4gh\schemas>git commit -am "Update schema validation for union type"
[more_ci 9b67b24] Update schema validation for union type
 1 file changed, 4 insertions(+)

Then I pushed the changes:

C:\git_ga4gh\schemas>git push origin more_ci
Username for 'https://github.com': pgrosu
Password for<EMAIL_ADDRESS>Counting objects: 223, done.
Delta compression using up to 2 threads.
Compressing objects: 100% (71/71), done.
Writing objects: 100% (170/170), 169.47 KiB | 0 bytes/s, done.
Total 170 (delta 68), reused 149 (delta 51)
To https://github.com/pgrosu/schemas.git
 * [new branch]      more_ci -> more_ci

Then initiated a pull request that looked like this:

But after clicking the "Create pull request" button I got the following message:

Any ideas of what I should try next?
Thanks,
Paul

@dcolligan OK, agreed. This is all rather tricky though, as we're creating a lot of coupling between the two repos. There's a lot of stuff in there which really only does affect us in the server, which would be very confusing to an outsider coming in fresh.
What if we just verified the assumed structure in this script (calling it verify_schemas.py), and left our process_schemas as-is in the schemas repo? There is some duplication of effort here, but hopefully check_schemas.py will not need much updating afterwards (except to add more checks, keeping tabs on naming conventions, etc). We are then free to evolve process_schemas.py as we see fit in the server repo.

@jeromekelleher   I think "creating" this coupling is fine since that coupling already exists.  The server repo already crucially depends on the schemas repo.  We are just checking if that coupling is not broken at the source.
It seems like we have three choices:

having 2 similar process_schemas files in both repos
only having a process_schemas file in the schemas repo, and having a script in the server repo that is a front end to that functionality
your plan, which I don't really understand since verification and processing involve the same steps.  Also I think it's safe to assume that how we process and check the schemas will evolve over time.

I prefer number 2

I think it would be a mistake to have code that we depend on  in the server repo (other than the schema itself, obviously) end up in here, because (a) it doesn't belong here; (b) it will make updating the schema processing code unnecessarily difficult (PRs can move very slowly on this repo).
Anyway, they are different tasks. One is to generate the Python code that we use, and the other is to check that the schema has some properties that we all agree are important. The checking code should evolve over time to include a lot more stuff. An example would be checking for trailing whitespace: we can easily build this in to a schema checker, but it has no purpose in a code generator.

@jeromekelleher, @dcolligan Don't worry there will be a validation structure that I'm working on to make things a little simpler.  For now it would be nice to have it in one place, but feel free to implement what makes it easier for you guys.
On another note, regarding the error message I got above, I had a chance to read up on Github's documentation what might be happening and I'll just wait until it gets merged, and then I'll do a PR here afterwards against the code.
Paul

After conversations with @jeromekelleher I've decided to go with a new design.  This new code contains import_schemas.py which is only the functionality from process_schemas.py that compiles the schemas into python objects, and none of the code that does the writing of the _protocol_schemas.py file.  Writing and verifying _protocol_schemas.py will be the domain of the server repo code.  This design features minimal code duplication across both repos.

At one point, I create
https://github.com/ga4gh/server/issues/81
generalize python code generation from schema #81
assigned it to myself and never got back to it.
The thinking was that the class creator should be a program
independent of checking out a tree, etc.  Avro file input, class
output.  Worthy of submitting to Avro project on day.
Danny Colligan<EMAIL_ADDRESS>writes:

After conversations with @jeromekelleher I've decided to go with a new design.
This new code contains import_schemas.py which is only the functionality from
process_schemas.py that compiles the schemas into python objects, and none of
the code that does the writing of the _protocol_schemas.py file. Writing and
verifying _protocol_schemas.py will be the domain of the server repo code. This
design features minimal code duplication across both repos.
—
Reply to this email directly or view it on GitHub.*

Looks good @dcolligan, thanks. I think this is definitely the way to go. However, I think we can simplify what we're doing here a great deal. There's still a lot of stuff left over from the context of generating Python code which we should remove. I think the majority of this is just deleting things though.

I agree with Jerome. It needs a pass through of renaming things.

@jeromekelleher pushed a new commit addressing your concerns

@dcolligan I think that if we want to make this script the basis of the CI testing on this repo, we need to make it a lot simpler and more focused. There is too much stuff here which doesn't do anything and doesn't make any sense.

@jeromekelleher okay, gave it another pass.  let me know what you think.

Build is failing. @dcolligan can you take a look?
======================================================================
ERROR: testSchemaProperties (test_protocol.TestValidateSchemas)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/travis/build/ga4gh/schemas/tests/test_protocol.py", line 48, in testSchemaProperties
    self._checkProperties(schemaClass)
  File "/home/travis/build/ga4gh/schemas/tests/test_protocol.py", line 63, in _checkProperties
    schemaClass.name, field.name))
Exception: Schema union assumptions violated: ReadAlignment.duplicateFragment
-------------------- >> begin captured logging << --------------------
requests.packages.urllib3.connectionpool: INFO: Starting new HTTP connection (1): www.carfab.com
requests.packages.urllib3.connectionpool: DEBUG: "GET /apachesoftware/avro/stable/java/avro-tools-1.7.7.jar HTTP/1.1"<PHONE_NUMBER>7
--------------------- >> end captured logging << ---------------------
----------------------------------------------------------------------
Ran 2 tests in 61.807s

@delagoya yes, this is expected behavior to fail in this way.  Once #292 is merged, I will rebase this branch on top of master.

Much better, thanks @dcolligan! This is a great base for us to start adding more checks on the stuff in the schema.
+1.

Ok, pushed a new update and the tests pass.  We should get this merged quickly before another merge causes a break in the (yet-unmerged) CI.
Note: I also fixed some minor encoding issues in wip/matchmaker.avdl -- running CI locally caught these since they were making maven throw warnings; see example run below.
$ python scripts/run_tests.py
*** Running: "flake8 scripts tests"
*** Running: "nosetests -v tests"
testMaven (test_maven.TestMaven) ... FAIL
testSchemaProperties (test_protocol.TestValidateSchemas) ... ok

======================================================================
FAIL: testMaven (test_maven.TestMaven)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/Users/dannyc/ga4gh/schemas/tests/test_maven.py", line 31, in testMaven
    self.runCommandCheckWarnings(mvnInstall)
  File "/Users/dannyc/ga4gh/schemas/tests/test_maven.py", line 44, in runCommandCheckWarnings
    self.fail("Command '{}' issued warning(s)".format(cmd))
AssertionError: Command 'mvn install -DskipTests=true -Dmaven.javadoc.skip=true -B -V' issued warning(s)
-------------------- >> begin captured stdout << ---------------------
Running 'mvn install -DskipTests=true -Dmaven.javadoc.skip=true -B -V'
[WARNING] /Users/dannyc/ga4gh/schemas/target/generated-sources/avro/org/ga4gh/match/MatchResponse.java:[11,9] unmappable character for encoding UTF-
[WARNING] /Users/dannyc/ga4gh/schemas/target/generated-sources/avro/org/ga4gh/match/MatchResponse.java:[14,418] unmappable character for encoding UTF-
[WARNING] /Users/dannyc/ga4gh/schemas/target/generated-sources/avro/org/ga4gh/match/Matchmaker.java:[11,7602] unmappable character for encoding UTF-
[WARNING] /Users/dannyc/ga4gh/schemas/target/generated-sources/avro/org/ga4gh/match/Matchmaker.java:[11,8015] unmappable character for encoding UTF-
[WARNING] /Users/dannyc/ga4gh/schemas/target/generated-sources/avro/org/ga4gh/match/MatchRequest.java:[11,640] unmappable character for encoding UTF-
[WARNING] /Users/dannyc/ga4gh/schemas/target/generated-sources/avro/org/ga4gh/match/MatchRequest.java:[13,70] unmappable character for encoding UTF-
[WARNING] /Users/dannyc/ga4gh/schemas/target/generated-sources/avro/org/ga4gh/match/MatchRequest.java:[54,69] unmappable character for encoding UTF-
[WARNING] /Users/dannyc/ga4gh/schemas/target/generated-sources/avro/org/ga4gh/match/MatchRequest.java:[62,69] unmappable character for encoding UTF-

--------------------- >> end captured stdout << ----------------------

----------------------------------------------------------------------
Ran 2 tests in 17.315s

FAILED (failures=1)
*** ERROR

I'm going to +1 this. Besides maybe wanting not to have a monolithic validator test (which at the moment isn't a big deal since it only has one rule to check), I can't find anything wrong with it.

+1 from me as well.

Merging.


Memory model soundness

The following example (see this test case) reveals an unsoundness wrt to handling subtypes:
class A extends RuntimeException { }

class UnsatThrows {
	public static void main(String[] args) {
		RuntimeException a = new A();
		try { throw a;
		} catch (Throwable e) { assert false; }
	}
}

The pull that fetches the type of the caught exception only looks at the type RuntimeException and does not see that the type might be A. Hence, the assert false becomes unreachable.

Fixed in this commit. There were in fact two problems:

We did not check invariants of potential subtypes (fixed in this commit.
There was a bug in the SootRunner that caused a hiccup in Soot which dropped the trap and the assert false in the above example.


[webview_flutter] Fix html dropdown on Android

Fix html dropdown
Description
Replace this paragraph with a description of what this PR is doing. If you're modifying existing behavior, describe the existing behavior, how this PR is changing it, and what motivated the change.
Related Issues
Replace this paragraph with a list of issues related to this PR from the issue database. Indicate, which of these issues are resolved or fixed by this PR. Note that you'll have to prefix the issue numbers with flutter/flutter#.
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

[x] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[x] My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
[x] All existing and new tests are passing.
[ ] I updated/added relevant documentation (doc comments with ///).
[x] The analyzer (flutter analyze) does not report any problems on my PR.
[ ] I read and followed the Flutter Style Guide.
[ ] The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
[ ] I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
[x] I updated CHANGELOG.md to add a description of the change.
[x] I signed the CLA.
[ ] I am willing to follow-up on review comments in a timely manner.

Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?

[ ] Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
[ ] No, this is not a breaking change.

@luisdiaz14 can you feel an issue describing the problem with a minimal sample app?

Sounds like https://github.com/flutter/flutter/issues/34248 is the relevant issue, thanks.

Sounds like https://github.com/flutter/flutter/issues/34248 is the relevant issue, thanks.
As I mentioned we can't pass the activity as the context, we'll have to find a different solution. I'd suggest closing the current PR until we come up with a workable solution.

Hello Amirh,
I need to be able to solve this problem. This bug is important to fix as its holding back one of my apps from using webview.
Thanks

I'm sorry this is holding you back. I'm personally currently dealing with other priorities and will prioritize the issue according to https://github.com/flutter/flutter/wiki/Issue-hygiene#prioritization
If you can't wait you're welcomed to keep investigating and propose a solution.
As I mentioned this PR cannot land as we must pass the VD's context to views we are creating within that VD. I'm closing this PR as this solution isn't viable.


Monthly Chat Agenda August 2024 (2024-08-05 and 2024-08-19)

This is the Agenda for the two Monthly CRS Chats.
The general chat is going to happen on https://owasp.slack.com in the channel #coreruleset on Monday, 2024-08-05, at 20:30 CEST. That's the 1st Monday of the month. A separate issue chat is happening at the same location, same time on Monday, 2024-08-19. That's the 3rd Monday of the month. Please note that we have a CRS calendar (maintained by @fzipi).
Archived previous meetings and their decision are here.
What happened in the meantime since the chat last month
Outside development
Blog Posts that mention CRS

https://dev.to/motorbuy6/why-safeline-might-be-the-best-free-waf-23o7 (Twitter Post: https://x.com/prod42net/status/1822962701485662508)

Inside development
Rules

FIXME: Please fill in

CRS Sandbox

FIXME: Please fill in

Security

FIXME: Please fill in

Plugins

FIXME: Please fill in

Documentation and Public Relations

FIXME: Please fill in

Project Administration and Sponsor relationships

We are in the process of getting new important sponsorship 🎉 More news in the next meeting.

Tools

FIXME: Please fill in

Testing incl. Seaweed and many future plans

No news on this area

Containers

We released a new version with updated CRS version to 4.5.0 and apache to 2.4.62.

CRS Status Page

There are some internal failures while running the Azure tests, need to review.

Project discussions and decisions

LTS release when?

We want integrators to be able to get on board with v4 so that v4 sees widespread use: currently they're all sticking with v3

There was a survey internally about what leaders think about a Contributor License Agreement (CLA). CLA is a legal document that defines the terms under which a license is granted by a contributor to an open source project. It is used to protect a project from future legal issues. Please review the Individual Contributor License Agreement (ICLA) or, if applicable, the Corporate Contributor License Agreement (CCLA) from the Apache Foundation. Additional information related to open source contributor and/or copyright agreements can be found here
#3770: how much HTML do we want to detect?
#3780: new rule or add to existing rule? -> performance overhead vs. rule complexity (and ReDos)
#3573

Rules development, key project numbers
PRs that have been merged since the last meeting

#3784
#3783
#3778
#3777
#3776
#3773
#3772
#3771
#3766
#3765
#3763
#3762
#3760

Open PRs
Open PRs marked DRAFT or work in progress or needs action
Separate 2nd Meeting (Monday, 2024-08-19)
We generally cover 10 issues per month in a separate issue meeting. Add them as you see fit.

Issue slot 1: ...
Issue slot 2: ...
Issue slot 3: ...
Brainstorm: if and which rule we would like a friendly CDN to test for us in terms of false positives. Ideally something that gets triggered by attacks from time to time (so not a super exotic rule that is never triggering, because attacks are so rare).

Other topics

FIXME: Please fill in

How to get to our slack and join the meeting?
If you are not yet on the OWASP Slack, here is your invite: https://owasp.org/slack/invite .
Everybody is welcome to join our community chat.

Decisions July 5th
LTS Release
🔵 We will start adding issues with the things we think v4 LTS should have. A new label v4 LTS will be added to track them.
🔵 Regarding CLA, we don't have a clear position, as it is not a requirement now.

Decisions Aug 19th
PR Jit https://github.com/coreruleset/coreruleset/pull/3780
🔵 @Xhoenix will test @theseion's extension to the cmdline processor as proposed in the PR.
Which rule do we want to test?
🔵 @fzipi will start a wiki page where we add our suggestions and comments to a list of rules
Info dev retreat
🔵 @fzipi just let us know that he'w working on getting all set for the developer retreat asap.


Remove cross icon

Remove cross icon
https://github.com/GeneralMagicio/pairwise-rf6/issues/173

Hi Maryfaf,
The show closeButton if you remove ModalProps from this it will remove close Button for all the modals
you could just do showCloseButton as false for this case

Hi Maryfaf, The show closeButton if you remove ModalProps from this it will remove close Button for all the modals
you could just do showCloseButton as false for this case

@HrithikSampson I've changed it based on your comment


collection.upload.staticURL is optional but is actually required

Link to reproduction
https://github.com/payloadcms/payload/commit/cf8b836f72011a80f92eabedb49a35d970652974
To Reproduce

payload.init({ serverUrl: undefined })
Create collection "test" without upload.staticURL
Add a document
Query the collection and notice the url property

Option 1:
Expected: url: "/test/example.png"
Actual: url: "undefined/test/example.png"
Option 2:
Expected: invalid payload config, staticURL was empty
Actual: valid payload config, image urls are broken
Describe the Bug
This worked upto 1.13, it broke it 1.14.0
Ideally it should use the server origin + collection slug (as it did before?)
Payload Version
1.14 - 1.15.2

Hey @thgh - I'm not able to replicate the issue you described, I just tried with Payload v1.15.2 and am seeing the correct media url even though staticURL is undefined. If you could add a reproduction repo that would be super helpful!

Hi, the actual issue is that collection sanition happens before server url sanition. The issue appears only when server url is undefined. I updated the repro steps and added a testcase over here: https://github.com/payloadcms/payload/pull/3238/commits/bf19afa7d2f8399f021a9410eb62bcc9af9c87d5

Oh, it's more specific: serverUrl must be actually set to undefined

PR updated with two commits: first a failing testcase, then a fix.

Hey @thgh - we appreciate the time you put into finding this issue and adding a PR. Prior to reviewing your PR, I was unable to reproduce the issue with your reproduction steps.
Having serverURL set to undefined and providing no staticURL for uploads in a collection still output the expected url.
Could you please provide a reproduction repo that I could pull down that way my configuration is matching yours? Thank you!

OK, here it is: https://github.com/thgh/payload/tree/fix/3237-server-url
Run yarn test:int -t uploads and it will succeed, revert the sanitize fix to trigger the bug
Or check out this action (see log below)
(here are some notes on the root cause)
Summary of all failing tests
FAIL test/uploads/int.spec.ts (14.899 s)
  ● Collections - Uploads › REST › create › creates from form data given a png

    expect(received).not.toContain(expected) // indexOf

    Expected substring: not "undefined"
    Received string:        "undefined/media/image-1.png"

      58 |         expect(sizes).toHaveProperty('mobile');
      59 |         expect(sizes).toHaveProperty('icon');
    > 60 |         expect(doc.url).not.toContain('undefined');
         |                             ^
      61 |       });
      62 |
      63 |       it('creates from form data given an svg', async () => {

      at Object.toContain (test/uploads/int.spec.ts:60:29)

Test Suites: 1 failed, 24 passed, 25 total
Tests:       1 failed, 1 skipped, 2 todo, 452 passed, 456 total
Snapshots:   0 total
Time:        94.596 s
Ran all test suites.
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
Error: Process completed with exit code 1.

Hi, here is the command to check out the reproduction:
git checkout cf8b836f72011a80f92eabedb49a35d970652974

Is everything clear?

Confirmed bug while debugging #3275. @PatrikKozak or @JessChowdhury, make sure you are on latest when testing this.

@JessChowdhury please pick back up on this work and ensure this is resolved.
Thank you!


Config and code modification for BEVFormer w/OSP

Hi, Thanks for your good job!
I am trying to reproduce the result(mIoU=41.21) of BEVFormer w/OSP, but can not find the correct config. In your README-Results, OSP and BEVFormer w/OSP share the same config(projects/configs/osp.py), could you please provide the detailed config for BEVFormer w/OSP(e.g., the config to freeze trained BEVFormer)? Besides, I have some other questions:

why self-attn osp.py is not needed in OSP?
there are 3 encoder layers, but each layer forward twice BEVFormerEncoder, why? Any explanation is appreciated.
i find a hard-code use_bev_volume=False, is this should be True for using OSP as a plugin to argument volume-based methods? and how to modify the code?

Looking forward to your reply, Thanks!

Hi!
The config for BEVFormer can refer to the baseline provided by the CVPR2023 Challenge.

The input query only interacts with the images and does not require self-attention.
This part can refer to the oversample and GPCA mentioned in the paper.
Thank you for pointing that out. This hard-code was added in a previous experiment and will be removed.

Have you reproduced this result? Did you use the "projects/configs/osp.py" file for it?

Have you reproduced this result? Did you use the "projects/configs/osp.py" file for it?


Handling re-run NPOC/TN data

I am working on adapting this code for TEMPEST and dont understand this function's purpose @peterregier: https://github.com/COMPASS-DOE/EXCHANGE/blob/42fd16551b3a0f23bc11370eab56f79c0dcff7e8/Processing_Scripts/water_npoc_tdn.R#L103

@amyerspigg because some samples were rerun, there are two records for a number of kits, one with a npoc value and one with a tdn value. This function merges those rows via mean_if_numeric, where a normal merge would result in NAs (stats on NAs yield NAs). Lemme know if that's not clear. To see which kits this effects and how it effects them, compare npoc_blank_corrected and npoc_duplicates_removed dataframes


WIP: Update Mbed TLS to mbedtls-3.2.1.

This is built on top of #496 so not ready for review!

I've tested 2d335595c226cd526ae18f360dedd42bf5b6b5b5 (current version of this) on Nitro.


Ensure Sync PVCs return requeue false once processed

In processVRAs{Primary|Secondary} PVCs that are in a sync
protection need to return true for requeue, for the orchestration
to proceed with their deletion.
This was not the case, and is corrected with this commit.
Further, in delete, the ready boolean was not used to determine
VR readiness in the current state. This is also corrected.
Signed-off-by: Shyamsundar Ranganathan<EMAIL_ADDRESS>

Regional e2e complete (deploy->relocate->failover->relocate->delete).


Add support for HTTP(S) proxies to connect()

Fix #364.

Most likely this doesn't close one of the two transports when the connection terminates.

Nothing more than the public comments here.

Any updates on this?

I'm really looking forward to this 👍

@aaugustin could you please update this, so that I can still use it with the latest version?

Feel free to do the rebase yourself and post a link to it here, if you're really in a hurry that's probably the best course of action. Others may pitch in by testing said new branch and giving feedback on it as well. Cheers

Well, going from this PoC to a properly tested implementations that supports all cases (HTTP/HTTPS => HTTP/HTTPS) is rather boring. I haven't been motivated to do it.
Also, I'd like to revisit the part after # Wrap socket with TLS.  Perhaps there's a better solution now that websockets requires Python > 3.6.
Proxies are most common in corporate networks. If you work at a company that relies on websockets and needs this feature, please consider paying for its development.
Get in touch at aymeric.augustin at fractalideas.com if you're interested.
Before downvotes pour in, I'd like to say that paying people is a time-proven way to get them to do things they wouldn't do by themselves otherwise ;-)

So what should we do for this feature (not PR) to be merged? Shall we continue this PR (I'm sorry but I haven't tested this yet) or start from a scratch? I'm not really familiar so I'm not sure if I can help but at least I can try.
Or buy enough ☕ for you and wait? If it works, I think it's a fair request 👍 (but then how much? :grin:)

Agree. Less code to maintain. :slightly_smiling_face:

Hi guys... I had to make proxies work with websockets, where the proxy server required NTLM authentication (just to make things interesting)... My fork is here with explanatory notes added to README: https://github.com/mdymike/websockets
Hopefully someone finds that useful.  I don't feel it's polished enough to do a pull request so just putting it out there 'as-is' :)
Best, Mike

Hi guys... I had to make proxies work with websockets, where the proxy server required NTLM authentication (just to make things interesting)... My fork is here with explanatory notes added to README: https://github.com/mdymike/websockets
Hopefully someone finds that useful.  I don't feel it's polished enough to do a pull request so just putting it out there 'as-is' :)
Best, Mike

@aaugustin, hi, I don’t want to bug you with this too much, but now that start_tls is available and Python 3.8 is already around, maybe you can find some time to have a look at this again?
Thanks in advance, and I hope you stay safe in this pandemic.

Hi guys... I had to make proxies work with websockets, where the proxy server required NTLM authentication (just to make things interesting)... My fork is here with explanatory notes added to README: https://github.com/mdymike/websockets
Hopefully someone finds that useful. I don't feel it's polished enough yet to do a pull request so just putting it out there 'as-is' for now :)
Best, Mike

I tested the fork by Mike and can confirm that it works behind a corporate proxy 😄 👍
(I did not test the NTLM authentication though)
It would be nice to see proxy support in the official websockets library.

I have forward-ported this pull request to the current websockets code using start_tls; I will submit a pull request superseding this one soon.


DNSResolve: DNS Cache Not Working in Certain Scenarios

In k8s environment, the concatenation of the hostname and searchDomain, can cause the DNS cache to become ineffective. I think if searchDomains are concatenated during DNS resolution, we should iterate through and concatenate all searchDomains to obtain the cached results.
eg.
hostname: k8s service name

Each EpollEventLoop has its own DNS resolution cache, but when DNS resolution is executed in an EpollEventLoop that does not have a cached result, it can cause the DNS resolution cache to become ineffective.

This looks like a potential bug. Can it be assigned to me? I would like to try fixing it.
Netty version
4.1.73.Final
JVM version (e.g. java -version)
jdk8
OS version (e.g. uname -a)
k8s 5.15.0-101-generic #111-Ubuntu SMP Tue Mar 5 20:16:58 UTC 2024 x86_64 GNU/Linux

You are welcome to try fixing it. I recommend first making sure it's still a bug in the latest version. Then see if you can capture it in an automated test. Also feel free to discuss the ideas you have for how to fix it.

You are welcome to try fixing it. I recommend first making sure it's still a bug in the latest version. Then see if you can capture it in an automated test. Also feel free to discuss the ideas you have for how to fix it.

This bug still exists in the latest version. If each type of DNSCache implementation has its own global cache, it should be able to resolve the issue mentioned above, and the cost of fixing it would be relatively low. In the ResolveWithDotSearchDomain scenario, I have made some small modifications by iterating through all searchDomains and matching 'hostname+ '.' +searchDomain' to search for results in the DNSCache. Would this be an appropriate solution?
please review: https://github.com/netty/netty/compare/4.1...qnnn:netty:4.1
Best wishes!

@chrisvest Or, we could specify a global DNS cache that belongs to the DnsAddressResolverGroup when creating a new NameResolver. WDYT?


CB-8643 Stabilize DistroXAutoScaleClusterV1EndpointTest

Alert Monitors are disabled in UnitTest Context where there isn't any external service connectivity.
Tests should assert response of the invoked api.

See detailed description in the commit message.

In some Jenkins CI runs when jobs are running very slowly, test appears flaky because of background processing by AlertMonitors.  Monitors should not be enabled in unit test context since external service connectivity is not available.


Sorting arm-consumption 'usage details' by resource group

I am using the arm-consumption package to get the usage details for a subscription and finding it difficult to sort the results in a meaningful way.  I need to get them by resource group, but 1) it does not appear to be possible to filter the details by resource group when getting the data from azure and 2) the 'resource group' property on the usage details items does not correspond directly to the resource group, i.e., if the resource group is called 'ExampleGroup' (as per arm-resources or portal.azure.com), the usage details property 'resource group' is a longer string which appears to begin with the first few letters of the resource group but not in a consistent enough way to use to search.  (There are a larger number of 'resource groups' appearing in arm-consumption than in arm-resources, and their names do not appear to correlate in a consistent, searchable way).
I would like to either be able to use a resource group filter when fetching the usage details, and/or have a property in the usage details that gives the resource group of the item as defined in arm-resources.
I have tried getting all the usage details data and sorting it myself by resource group, however then I encounter the problem where the resource group name that I need to sort by is not a property of the usage details items.
I have also tried looking to see if there is any existing API that provides a map between the arm-resources resource groups names and the arm-consumption resource group names, but have not so far found one.

@BasiaMH I think you can pass a scope parameter to get all the usage details within one resource group https://github.com/Azure/azure-rest-api-specs/blob/main/specification/consumption/resource-manager/Microsoft.Consumption/stable/2021-10-01/examples/UsageDetailsListByManagementGroup.json#L6 . let me know if that works for you ? Thanks

Thanks,
I can pass subscriptions/{subscriptionId} in the scope, which returns all
usage details for our subscription, but if I try to pass the
resourceGroups/{resourceGroupName} I get no results.
What is returned is an array with one item, containing a url
https://costmanagement.trafficmanager.net/subscriptions/c9e88f4c-b9f3-4941-b51e-c9cbbfb9742e/resourcegroups/dicomweb-group/providers/Microsoft.Consumption/usagedetails/Export
And when I navigate to the url it just gives an error message:
Either: "The resource you are looking for has been removed, had its name
changed, or is temporarily unavailable."
or:
{"message":"No HTTP resource was found that matches the request URI
'https://costmanagement.trafficmanager.net/subscriptions/c9e88f4c-b9f3-4941-b51e-c9cbbfb9742e/resourcegroups/dicomweb-group/providers/Microsoft.Consumption/usagedetails/Export'.","messageDetail":"No
route providing a controller name was found to match request URI
'https://costmanagement.trafficmanager.net/subscriptions/c9e88f4c-b9f3-4941-b51e-c9cbbfb9742e/resourcegroups/dicomweb-group/providers/Microsoft.Consumption/usagedetails/Export'"}
Basia
On Fri, Jan 14, 2022 at 3:22 AM Qiaoqiao Zhang @.***>
wrote:

@BasiaMH https://github.com/BasiaMH I think you can pass a scope
parameter to get all the usage details within one resource group
https://github.com/Azure/azure-rest-api-specs/blob/main/specification/consumption/resource-manager/Microsoft.Consumption/stable/2021-10-01/examples/UsageDetailsListByManagementGroup.json#L6
. let me know if that works for you ? Thanks
—
Reply to this email directly, view it on GitHub
https://github.com/Azure/azure-sdk-for-js/issues/19835#issuecomment-1012906456,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AFJXFDSC4B3G53GBYR3R4MDUV7MLNANCNFSM5L343HJQ
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you were mentioned.Message ID:
@.***>

@BasiaMH Did you pass the scope like /subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName} ?

That's exactly what I tried, yes.
(Before that I tried including resourceGroups in a filter, but that just
returned all the data unfiltered.)
On Sun., Jan. 16, 2022, 8:52 p.m. Qiaoqiao Zhang, @.***>
wrote:

@BasiaMH https://github.com/BasiaMH Did you pass the scope like
/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName} ?
—
Reply to this email directly, view it on GitHub
https://github.com/Azure/azure-sdk-for-js/issues/19835#issuecomment-1014065383,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AFJXFDWW4TZVRKOVU5UWZFLUWNY4DANCNFSM5L343HJQ
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you were mentioned.Message ID:
@.***>

Looks like we need some help from service team.
@mitagarg Is it possible that you could help here, as I see you are the author of this PR https://github.com/Azure/azure-rest-api-specs/pull/17013

Hi, is there any update or further information on this problem?  Or a different workaround someone could suggest to somehow get the usage and cost per resource or per resource group?
Thanks

@BasiaMH Hi, Since this is probably an issue on the service side, Could you open a ticket here https://docs.microsoft.com/en-us/answers/topics/azure-cost-management.html so that you can get direct support from the service team ?


EhCache expiry listener

As per my understanding currently only cacheEvent listener is there which gets invoked at the time an expired key is accessed . But I couldn't find a way where i can get hold of an event when a cache is expired.

There is no event fired at the "moment" entries are expired because the system does not actively check for expiry. The event will only be fired when an entry is noticed or found to be expired.


       ))

This also fails:
(deftype B [^:unsynchronized-mutable ^int a]
  P
  (foo [this]
    (set! a 20)))

Seems to be a language bug, stay tuned.

closing as duplicate of #294


Update scale-requirements.md

remove the GPU worker node sizes and point to GPU pages.

#sign-off


Automated cherry pick of #6663: fix: 优化安全组同步逻辑

Cherry pick of #6663 on release/3.0.
#6663: fix: 优化安全组同步逻辑

Codecov Report

Merging #6733 into release/3.0 will decrease coverage by 0.37%.
The diff coverage is 9.79%.

@@              Coverage Diff               @@
##           release/3.0   #6733      +/-   ##
==============================================
- Coverage         6.92%   6.55%   -0.38%
==============================================
  Files              541     556      +15
  Lines            91753   98577    +6824
==============================================
+ Hits              6351    6457     +106
- Misses           84880   91598    +6718
  Partials           522     522

Flag
Coverage Δ

#aFlag
6.55% <9.79%> (-0.38%)
:arrow_down:

Impacted Files
Coverage Δ

pkg/cloudcommon/policy/resources.go
0.00% <ø> (ø)

pkg/cloudprovider/objectstore.go
2.51% <0.00%> (-0.01%)
:arrow_down:

pkg/cloudprovider/securitygroup.go
0.00% <0.00%> (ø)

pkg/compute/models/buckets.go
1.23% <0.00%> (ø)

pkg/compute/models/cloudproviders.go
0.97% <0.00%> (-0.01%)
:arrow_down:

pkg/compute/models/guestdisks.go
0.57% <ø> (+<0.01%)
:arrow_up:

pkg/compute/models/regiondrivers.go
20.00% <ø> (ø)

pkg/compute/models/secgrouprules.go
4.20% <0.00%> (ø)

pkg/compute/models/secgroups.go
1.88% <0.00%> (-0.01%)
:arrow_down:

pkg/compute/models/snapshots.go
1.58% <0.00%> (+<0.01%)
:arrow_up:

... and 36 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b51daa0...7b0c053. Read the comment docs.


[small] Expose json rpc error enum

Motivation
Expose the error enum
Have you read the Contributing Guidelines on pull requests?
Yes
Test Plan
cargo x test

@bors-libra r=thefallentree

:pushpin: Commit 43b954d has been approved by thefallentree

@bors-libra R+

:hourglass: Testing commit 43b954ddda5af67b1a0b4a8a5368a9e85b17de6a with merge 74389aa22f1087f8b75b1e6ca87a677fc0726a5a...

:sunny: Test successful - checks-actions_land_blocking_test, checks-circle_commit_workflow
Approved by: thefallentree
Pushing 74389aa22f1087f8b75b1e6ca87a677fc0726a5a to master...


Create strapi backend mock

Description
Maybe a good idea is to create our backend using strapi as a headless cms while I learn to create my own backend in Js or any other backend programming languaje
Acceptance Criteria

Text strapi as a headless cms
Experiment about how to use strapi
Create default project

Notes

https://docs.strapi.io/dev-docs/quick-start

I have added an strapi default project but i decided to use SQlite first to experiment, the purpouse of the issue has been completed, now is needed to investigate the best hosting for databases and add a connection into Strapi project, I have created an issue for this #6


RS-420: Create computer vision use case page

New page about computer vision use case

@atimin the text is fully ready for review, but the illustrations still need to be updated (work in progress)


Support for Django 2.1?

Hi!
Judging from tox.ini line 13 and the traceback I get with Django 2.1(.2 but not with 2.0.9), `django-widget-tweaks does not seem ready for Django 2.1. Are there plans to add support for it?
Thanks in advance!
Best, Sebastian
PS: The traceback is this:
[..]
  File "/usr/local/lib/python3.7/site-packages/widget_tweaks/templatetags/widget_tweaks.py", line 31, in as_widget
    html = old_as_widget(widget, attrs, only_initial)
  File "/usr/local/lib/python3.7/site-packages/django/forms/boundfield.py", line 93, in as_widget
    renderer=self.form.renderer,
TypeError: render() got an unexpected keyword argument 'renderer'

This related fix could be of interest: https://github.com/stuartaccent/django-autocomplete-light/commit/cfc5f4a25fcb4937cf07fc65ef4ed549ca0d1338

Anyone?
I can try a pull request if someone with merge permissions signs up for review :smile:

@hartwork sure, I will.

It turns out the problem is actually not in django-widget-tweaks but in a custom widget of the code base I was trying to upgrade to Django 2.1. The guilty code looks like this:
class ......(forms.TextInput):
    ......
    def render(self, name, value, attrs=None):
        ......
        return super().render(name, value, attrs)

So no support for renderer=.... That code no longer works with Django commit https://github.com/django/django/commit/2bd207ada0367debe8c8e298203435d5c88c14bd .
So'll close this ticket as invalid.
Please see pull request #73 to officially unlock support for Django 2.1 and Python 3.7.


Can someone explain to me what the filterDate prop needs to filter the weekends?

I have looked at the example in the docs. It shows filterDate={this.isWeekday}.
What is this.isWeekday ?
What am i putting in this variable?
Or would someone show me an example of using the filterDate prop?
This is my first time using this datepicker. Any help is much appreciated.

It's a function that takes a moment object and returns whether or not it is a weekday.
You can see it in the example code at https://github.com/Hacker0x01/react-datepicker/blob/efa7edc043f04db8ed0a29365e0300c797be06e9/docs-site/src/examples/filter_dates.jsx#L19
I suppose it would be good if that were included in the example code on the page as well.

Thank you. This is exactly what I need.


I have a new question

This is it

Please ask your question on StackOverflow. We have a great community over there. They have already answered thousands of questions and are happy to answer yours as well. See also our issue reporting guidelines.
Happy Coding!


feat: PLGR-53 add GameResultCard and GameResultCardScoreBadge components

I added GameResultCard and GameResultCardScoreBadge components, its tests and storybooks

We can move this file to organisms folder

i moved kardo thanks for feedback


MySQL service unavailable on ubuntu-18.04

Describe the bug
We were using for some weeks already MySQL server on ubuntu-18.04 without any issues. It seems that since recently MySQL does not work correctly or that something has changed slightly, enough to cause issues
Area for Triage:
jobs:
  backend-tests:
    name: Run backend tests
    runs-on: ubuntu-18.04
    timeout-minutes: 10
    steps:
      - uses: actions/checkout@v2
      - name: Setup MySQL
        run: mysql -u root -proot < .github/mysql-init/0_init.sql

Question, Bug, or Feature?:
Bug
Virtual environments affected

[ ] macOS 10.15
[ ] Ubuntu 16.04 LTS
[x] Ubuntu 18.04 LTS
[ ] Windows Server 2016 R2
[ ] Windows Server 2019

Expected behavior
Runner version: '2.165.2'
Run mysql -u root -proot < .github/mysql-init/0_init.sql
  mysql -u root -proot < .github/mysql-init/0_init.sql
  shell: /bin/bash -e {0}
  env:
    JAVA_HOME: /opt/hostedtoolcache/jdk/8.0.242/x64
    JAVA_HOME_8.0.242_x64: /opt/hostedtoolcache/jdk/8.0.242/x64
mysql: [Warning] Using a password on the command line interface can be insecure.

Actual behavior
Runner version: '2.165.2'
Run mysql -u root -proot < .github/mysql-init/0_init.sql
  mysql -u root -proot < .github/mysql-init/0_init.sql
  shell: /bin/bash -e {0}
  env:
    JAVA_HOME: /opt/hostedtoolcache/jdk/8.0.242/x64
    JAVA_HOME_8.0.242_x64: /opt/hostedtoolcache/jdk/8.0.242/x64
mysql: [Warning] Using a password on the command line interface can be insecure.
ERROR 2002 (HY000): Can't connect to local MySQL server through socket '/var/run/mysqld/mysqld.sock' (2)
##[error]Process completed with exit code 1.

Why did all of a sudden mysqld.sock became unavailable 13th and 16th March 2020?

Hello, @milanaleksic
We have disabled mysql service by default - https://github.com/actions/virtual-environments/issues/375
Please enable service before using mysql:
run:
  sudo systemctl enable mysql.service

OK, thanks

Hi,
I have the same issue, but adding this step:
- name: Start mysql service
        run: |
          sudo systemctl stop mysql.service
          sudo systemctl enable mysql.service
          sudo systemctl restart mysql.service

the CI not working and I have this error message:
Run sudo systemctl stop mysql.service   sudo systemctl stop mysql.service   sudo systemctl enable mysql.service   sudo systemctl restart mysql.service   shell: /usr/bin/bash -e {0} Synchronizing state of mysql.service with SysV service script with /lib/systemd/systemd-sysv-install. Executing: /lib/systemd/systemd-sysv-install enable mysql Created symlink /etc/systemd/system/multi-user.target.wants/mysql.service → /lib/systemd/system/mysql.service. Job for mysql.service failed because the control process exited with error code. See "systemctl status mysql.service" and "journalctl -xe" for details. Error: Process completed with exit code 1.

Hi, @lcolombini
    runs-on: ubuntu-latest
    steps:
      - run: |
           sudo /lib/systemd/systemd-sysv-install enable mysql
           sudo systemctl enable mysql.service
           sudo systemctl start mysql.service
           sudo systemctl status mysql.service


Update to 1.16.1 and noarch: python

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@conda-forge-admin, please rerender


Missing LSBMode flag bug for LSBCEncode and LSBCDecode methods

Half-baked feature was accidentally merge with main branch. Oops. ¯\_(ツ)_/¯

#15


Bug/#1214 -General cleanup

#1214

https://www.reddit.com/r/androiddev/comments/6cgcbr/a_simple_new_feature_announced_during_this_io_i/


ci: migrate to codecov

PR Checklist
Please check if your PR fulfills the following requirements:

[x] The commit message follows Conventional Commits
[ ] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been added / updated (for bug fixes / features)

PR Type
What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Refactoring
[ ] Code style update
[x] Build or CI related changes
[ ] Documentation content changes

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Codecov Report

:exclamation: No coverage uploaded for pull request base (main@ed1bd33). Click here to learn what that means.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1227   +/-   ##
=======================================
  Coverage        ?   67.97%
=======================================
  Files           ?      585
  Lines           ?     6985
  Branches        ?     1458
=======================================
  Hits            ?     4748
  Misses          ?     1869
  Partials        ?      368

Flag
Coverage Δ

addon-mobile
∅ <0.00%> (?)

addon-table
81.39% <0.00%> (?)

addon-tablebars
∅ <0.00%> (?)

cdk
82.33% <0.00%> (?)

core
68.69% <0.00%> (?)

kit
63.61% <0.00%> (?)

summary
67.97% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ed1bd33...228b4d4. Read the comment docs.


Add snakecase to snippets syntax

closes #233798
Implement /snakecase transformer for editor snippets.
Can be tested using the example in linked issue.

@microsoft-github-policy-service agree

The changes introduced in PR 237110 add the /snakecase transformation to snippets, enhancing the flexibility of text formatting within the editor:
Modified snippets.tmLanguage.json to include snakecase.
Updated snippet.md to document the new snakecase option.
Added _toSnakeCase method in snippetParser.ts.
Added test cases for snakecase in snippetParser.test.ts.
These changes will allow users to convert text to snake_case format in their snippets, improving the overall functionality and customization of the editor.

I need back my account please help me
<EMAIL_ADDRESS>

@joeriddles > <!-- Thank you for submitting a Pull Request. Please:

Read our Pull Request guidelines:
https://github.com/microsoft/vscode/wiki/How-to-Contribute#pull-requests
Associate an issue with the Pull Request.
Ensure that the code is up-to-date with the main branch.
Include a description of the proposed changes and how to test them.
-->

closes #233798
Implement /snakecase transformer for editor snippets.
Can be tested using the example in linked issue.

@jrieken is there anyway to disable outside comments? Looks like there are some spam accounts commenting repeatedly on this PR.


Standard Config Directories

First go at adding #233 (Would be cleaner if #237 was implemented)
This is my first rust PR so I'm very open to constructive criticism!
This is an attempt to get navi loading config from "standard" config directories. I've split the bundled cheats out into their own folder at the system level and set the fallback cheat path to the user's XDG_CONFIG_HOME. I run Linux so haven't been able to test with OSX. It would probably need either some changes in the code or in the brew install process to get it working there.

I've pushed a new commit here to use the data_dir function from the dirs crate instead of the consts I initially used which is a more flexible approach and doesn't require any elevated permissions to install

Closing without merging in favor of #258. Thanks again for the initial work!


unit tests for cred def routes

Signed-off-by: sklump<EMAIL_ADDRESS>

Codecov Report

Merging #486 into master will increase coverage by 0.16%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #486      +/-   ##
==========================================
+ Coverage   94.12%   94.29%   +0.16%
==========================================
  Files         236      236
  Lines       12008    12008
==========================================
+ Hits        11303    11323      +20
+ Misses        705      685      -20


database_alias on mssql

Describe the bug
i'm trying to ingest my mssql to datahub with this config
source:
  type: mssql
  config:
    uname,pas,port
    database: db_name
    database_alias: db_alias

but doesn't use the database_alias like db_alias.dbo.table its still using the database name db_name.dbo.table
To Reproduce
Steps to reproduce the behavior:

creating the mssql config file with databse_alias
idatahub -c ingest config_file.yml
see on the datahub its stil using the original database name

Expected behavior
expected result:  db_alias.dbo.table (using database_alias from config file)
actual result: db_name.dbo.table (ignoring the database_alias)
Additional context
after following some instruction from slack forum to add code similar tothis after this line.
its still using db_name and still ignoring the db_alias in the config file.

Hi @kevinhu! Can you take a look at this one?

Sure!

@datatimnih should be fixed! See https://github.com/datahub-project/datahub/pull/4523


num_beams for beam search

Hi, I want to use num_beams for generate, but PipelineModel can't. Can you support num_beams?
Best wishes.

Since we are working on imporving a large-scale model demo recently, the requirement might be delayed for one or two weeks.
You can use beam search in transformer and add it to your code following  this.
Also, welcome you to contribute your beam code usage to the project.


NCAAB box score list index out if range

from sportsipy.ncaab.boxscore import Boxscore
Boxscore('2021-04-03-17-baylor')
Gettting an error for list index out of range when trying to get the boxscore of games for the 2021 season.
https://www.sports-reference.com/cbb/boxscores/2021-04-03-17-baylor.html
Here is an example of the box score that I want to pull

I'm also having this issue!

Same issue here :')

Just had this issue as well, it appears that any 2021 boxscores have different HTML than previous seasons at least from looking at it myself.  If you look at the API, def _parse_record(self, field, boxscore, index) in boxscore.py tries to return the records of the teams that played but it isn't able to find any records from the PyQuery object, so there is an empty list that it is trying to index (at least this is where mine gets stuck).  If you don't need the records, you can edit this function locally as a temporary fix, the path for me on linux is: /home/insertUsernameHere/.local/lib/python3.8/site-packages/sportsipy/ncaab/boxscore.py


http_server discontinued

Since http_server package has been discontinued, I think we should start moving to shelf package

Thank you very much for the hot news.
I think that maybe we don't need it, I mean, it was only useful for serving statistical files.
I don't know if we should build a stack on top of the shelf, or create our own implementation.


publish<EMAIL_ADDRESS>

Requested by: @brustolin
Merge target: chore(sr)/publish-testflight
Quick links:

View changes
View check runs

Assign the accepted label to this issue to approve the release.
Leave a comment containing #retract under this issue to retract the release (original issuer only).
Targets

[x] github
[x] cocoapods[sentry-cocoapod]
[x] registry

Targets marked with a checkbox have already been executed.  Administrators can manually tick a checkbox to force craft to skip it.

Made it to GitHub:

https://github.com/getsentry/sentry-cocoa/releases/tag/8.24.0-alpha.0

Failed release registry:

Error:  CONFLICTS: .github/last-release-runid:content, Package.swift:content, Samples/iOS-Swift/iOS-Swift/AppDelegate.swift:content, Sentry.podspec:content, Sentry.xcodeproj/project.pbxproj:content, SentrySwiftUI.podspec:content, Sources/Configuration/Sentry.xcconfig:content, Sources/Sentry/Public/SentryOptions.h:content, Sources/Sentry/SentryClient.m:content, Sources/Sentry/SentryDataCategoryMapper.m:content, Sources/Sentry/SentryMeta.m:content, Sources/Sentry/SentryOptions.m:content, Sources/Sentry/include/SentryDataCategory.h:content, Sources/Sentry/include/SentryDataCategoryMapper.h:content, Sources/Sentry/include/SentryPrivate.h:content, Tests/HybridSDKTest/HybridPod.podspec:content, Tests/SentryTests/Networking/SentryDataCategoryMapperTests.swift:content
151

Also landed on cocoapods it seems:
[info] ========================================================
[info] === Publishing to target: cocoapods[sentry-cocoapod] ===
[info] ========================================================
[info] [[target/cocoapods]] Loading podspec from getsentry/sentry-cocoa:Sentry.podspec
[debug] GET /repos/getsentry/sentry-cocoa/contents/Sentry.podspec?ref=bb0c39adabdfdedefa225be46f7dbfd1c74f36ed - 200 in 286ms
[info] [[target/cocoapods]] Pushing podspec "Sentry.podspec" to cocoapods...
[info] [[target/cocoapods]] Cocoapods release complete

Who can help us understand the error? Should I revoke to close this issue?


[FEATURE] Add ability to specify dataset problem type during data import

🚀 Feature
LLM studio supports multiple problem types (Causal Modeling/ Classification), however, during data import, it expects dataset to be named exactly as the problem type, otherwise proper problem type can not be set.
Motivation
When importing custom dataset named train.csv for classification, it would be great to have the ability to select proper problem type.

Maybe add this snippet
items += [
                ui.dropdown(
                    name="dataset/import/cfg_file",
                    label="Problem Type",
                    required=True,
                    choices=choices_problem_types,
                    value=q.client["dataset/import/cfg_file"],
                    trigger=True,
                    tooltip=tooltips["experiments_problem_type"],
                )
            ]

here :https://github.com/h2oai/h2o-llmstudio/blob/d1acb59/llm_studio/app_utils/sections/dataset.py#L491


docs(STONEINTG-473): add diagram of Snapshot Controller

How to view the diagram from this PR?

Click on "Files changed"
Click the three dots on the top-right of the file
Click on "View file"

How to propose changes to the diagram?

Go to mermaid.live
Paste this diagram's code
Change the code the way you want, and see the changes instantly there.
You can refer to this Mermaid cheatsheet to propose any changes.

Few areas that need to be reviewed

Content of the diagram
Are we okay with CamelCasing? or do we want to separate the node names with an underscore in between?

fetchAllReleases VS fetch_all_Releases

FYI: the latest force push didn't change any content, but just change the naming convention of node names from Camel case to Snake case.

FYI: The latest force push only modified one block's content based on this review comment.


Implement Splice out

Implement splicing out of a channel.
Also did some clean-up as per the comments from #49.

bors r+

It took a week to get some reviews on this. I will implement the comments in a follow-up PR.


Kruize Notification prod fix

Description
A metric entry with only three tags, which are unlikely to have many unique values, will therefore help reduce cardinality.
Fixes # (issue)
Type of change

[ ] Bug fix
[ ] New feature
[ ] Docs update
[ ] Breaking change (What changes might users need to make in their application due to this PR?)
[ ] Requires DB changes

How has this been tested?
A metric entry with only three tags, which are unlikely to have many unique values, will therefore help reduce cardinality.

[ ] New Test X
[ ] Functional testsuite

Test Configuration

Kubernetes clusters tested on:

Checklist :dart:

[ ] Followed coding guidelines
[ ] Comments added
[ ] Dependent changes merged
[ ] Documentation updated
[ ] Tests added or updated

Additional information

@kusumachalasani  for cloud watch is current production configured to include  LOGGER.INFO  ?

@kusumachalasani for cloud watch is current production configured to include LOGGER.INFO ?

Yes

metrics and cloud watch tested and attached screenshot

Cloud Watch
2024-08-3020:28:46.188 INFO [qtp844112759-63][KruizeNotificationCollectionRegistry.java(87)]-quarkus-resteasy-kruize-min-http-response-time-db_0|tfb-server-0|2024-09-01T01:58:43.302Z|model|short_term|cost|221001|error|Number of pods cannot be zero
metrics
TYPE KruizeNotifications_total counter
KruizeNotifications_total{api="updateRecommendations",application="Kruize",recommendations_notifications="short_term|cost|error",} 6.0
KruizeNotifications_total{api="updateRecommendations",application="Kruize",recommendations_notifications="short_term|performance|error",} 6.0

TYPE KruizeNotifications_total counter
KruizeNotifications_total{api="updateRecommendations",application="Kruize",recommendations_notifications="short_term|cost|error",} 6.0 KruizeNotifications_total{api="updateRecommendations",application="Kruize",recommendations_notifications="short_term|performance|error",} 6.0

@msvinaykumar ? I understand we want to avoid the experiment_name as well in the notification metrics because of cardinality issues, but  how can these metrics help the customer ? As we are sending this info in the logs and the user has an option to look into the logs for debugging purposes. Unless there is an importance for these metrics, it is going to affect the performance.

TYPE KruizeNotifications_total counter
KruizeNotifications_total{api="updateRecommendations",application="Kruize",recommendations_notifications="short_term|cost|error",} 6.0 KruizeNotifications_total{api="updateRecommendations",application="Kruize",recommendations_notifications="short_term|performance|error",} 6.0

@msvinaykumar ? I understand we want to avoid the experiment_name as well in the notification metrics because of cardinality issues, but how can these metrics help the customer ? As we are sending this info in the logs - the user has an option to look into the logs for debugging purposes. Unless there is an importance for these metrics, it is going to affect the performance.

Ideally, if everything is functioning properly, there shouldn't be any metrics for errors or critical notifications. If such metrics are found, it is a clear indication that the recommendations are compromised and need to be addressed. The SRE or other relevant teams should be able to debug the issue using Kibana logs. These metrics are essential for alerting users to the presence of errors that need to be resolved. Hope it answers your question.

It is important to note how much additional space the logs might occupy due to this change. Considering we run at least 90,000 recommendations daily in the remote monitoring scenario—and there are no request/limit notifications for one-fourth of the experiments—these logs are frequently generated. Understanding this can help us anticipate the extra storage required for a pod and potential errors if the pod runs for an extended period.

LGTM from a functional point of view. Would be worth measuring the extra storage required if there is atleast 1 notification for 5 experiments and extrapolate the same for 90K recommendations for production usecase.

This change doesn't store data in the Postgres database; it simply fetches, processes, and displays the information in cloudwatch and increase the counter at Prometheus  .

LGTM from a functional point of view. Would be worth measuring the extra storage required if there is atleast 1 notification for 5 experiments and extrapolate the same for 90K recommendations for production usecase.

This change doesn't store data in the Postgres database; it simply fetches, processes, and displays the information in cloudwatch and increase the counter at Prometheus .

I was thinking from the perspective of pod log.

True , Depends on cloudwatch scale limitations.   We have flag to turn off jic

@msvinaykumar It appears that there is a build failure and the crc PR check is failing

@msvinaykumar It appears that there is a build failure and the crc PR check is failing

checking

@msvinaykumar It appears that there is a build failure and the crc PR check is failing

checking

Thanks, @dinogun, for catching this. I overlooked and missed checking in one file after addressing the review comments. After checking in the file, the CRC passed.


Fix writing INI and man pages for subcommands

This PR addresses two issues pertaining to subcommands: writing the INI and writing the man pages.
The work is split across two commits. The first commit addresses an issue where INI sections for subcommands were written as [sub.] instead of [parent.sub]. The second commit addresses an issue with usage text in man pages where commands only included the usage text of their immediate parent instead of a complete usage starting from the root.

Addressed gofmt issue with fixup of 97ea3ef.

@jessevdk , are you still maintaining this project?

@jessevdk , ping


dataset download

Hi, I can't seem to download the dataset~

Thanks for your contribution！ It would be better if the link address could be made permanent.

Thank you very much!


Implementation of Redux Middleware

Feat: Redux Middleware Implementation
Implemented an example of redux middleware.
Benefits: This would help in getting started for redux advanced feature like middlewares and their use case.

@DanielRosenwasser  Can you please check.


Replace sum() with tf.add_n()

I think this might be better because on the GPU it would end up storing the result of the summation to global memory once, instead of n-1 times. I also fear a bunch of cascaded summations ends up creating multiple intermediate tensors which each have to be allocated and use up memory.
In other words, sum(A) creates a graph that does:
sum1 = a1+a2
sum2 = sum1 + a3
sum3 = sum2 + a4
...
instead of tf.add_n() which just does:
sum = a1 + a2 + a3 + a4 + ...
I don't really know for sure.

It actually used to be tf.add_n in one of the earlier commits :)
I think sum might be better because TensorFlow can clean up  the a1, a2, ... tensors as it calculates each of the residual blocks. So I would expect that it uses less memory.
We should use the memory profiling functionality in TensorFlow to find out.

So I would expect that it uses less memory.

That could be true, but still be slower, as it requires more writes to memory compared to just storing the final sum once.

We should use the memory profiling functionality in TensorFlow to find out.

Any pointers to that? I haven't found any memory profiling in tensorflow docs.

Any pointers to that? I haven't found any memory profiling in tensorflow docs.

If you enable the store_metadata option, the training script will save the profiling information in the TensorBoard output: https://github.com/ibab/tensorflow-wavenet/blob/2125f3966e38ebaa8109241c27c4e4c1854f9ace/train.py#L272
You might have to add the CUDA profiling libraries to your LD_LIBRARY_PATH.
In the graph tab in TensorFlow, you'll be able to pick the log output that contains the profiling information on the left, which will give you memory and evaluation statistics.
There's also a timeline trace that you can open with the Chrome timeline viewer.

This appeared in a PR but was removed because it was an unrelated change, it'd be good to discuss it a bit further here. I think that if TensorFlow provides something natively that can be so trivially done in Python there has to be a good reason for it. However, one of the Google Brain engineers pointed out that adding them manually indeed uses less memory for large tensors (see http://stackoverflow.com/a/34520066/1729279). Why do they provide add_n then? To simplify the graph?

Why do they provide add_n then?

I tried to say above: I imagine it would reduce from N stores to global memory to 1. Faster.
I don't guess the memory thing being significant. I don't know the intricacies of tf's heap coalescing and temporary tensor allocations, but it seems like it would only slightly change how long it has to keep the operand tensors in memory. And I wonder, if they are being added to summaries as we are doing, if it can even let go of them at all.

If you enable the store_metadata option, the training script will save the profiling information in the TensorBoard output

Thanks for that. There's a list of things I'd like to get done and right now this doesn't seem like my best use of time, so don't think I will work on that.


Add the support for ignoreTrailingWhiteSpace and ignoreLeadingWhiteSpace

https://github.com/databricks/spark-csv/issues/304
This PR adds the support for ignoreTrailingWhiteSpace and ignoreLeadingWhiteSpace options which were exposed but not implemented.
For Apache Common CSV Parser (common),  it supports the functionalities only when both ignoreTrailingWhiteSpace and ignoreLeadingWhiteSpace are set to true by using withIgnoreSurroundingSpaces() at CSVFormat.
For Univocity parser (univocity),  it supports this functionalities for ignoreTrailingWhiteSpace, and/or ignoreLeadingWhiteSpace by using setIgnoreLeadingWhitespaces() and/or setIgnoreTrailingWhitespaces() at CsvParserSettings.

Current coverage is 87.43%

Merging #306 into master will increase coverage by +0.77% as of 9584d9b

@@            master    #306   diff @@
======================================
  Files           12      12
  Stmts          540     541     +1
  Branches       160     160
  Methods          0       0
======================================
+ Hit            468     473     +5
  Partial          0       0
+ Missed          72      68     -4

Review entire Coverage Diff as of 9584d9b

Powered by Codecov. Updated on successful CI builds.

I try to use this, but I am facing a strange issue. I am able to create a dataframe from the csv, but if I try to use the dataframe that is created and convert 1 of column from string to date using withColumn and then try to write it out to parquet I get a number format exception. However if I write the dataframe out as parquet first and read the parquet back and use the withColumn to create a new dataframe and write that out everything works fine.  I can create a test case if you need more information

I can rebase this if it seems worth adding it.

Any reason users would want to keep whitespace on one side? I'd recommend simplifying this to add "ignoreHeaderWhitespace" to ignore trailing and leading whitespace. I don't see a use case where users would want to keep one or the other, and it makes referring to columns more complex. Users might run into more issues if they only add 1 option, but wanted both.

Closing this as it is now maintenance mode and it seems it is not a critical bug.

Any plans to add this?  I noticed the two ignore whitespace options on the javadoc but was unable to use them

I have forked this repo. Any chances you can raise a pull request to it ?


making currentKey (read-only) public

Thanks for your contribution but I have merge another PR that does the same thing more concisely
public internal(set) var currentKey: String?


Add a generic tag helper for umbnav items

The method to build a tag for any UmbNavItem is to use item.getLinkHtml(), there doesn't appear to be any comparable helper for labels. Calling someLabel.getLinkHtml() is somehwat confusing for rendering an inert label.
It would be handy if there were a helper like item.getItemHtml() which would render the appropriate html based on the umbnav itemtype.

Great idea!

On looking it turns out this should already do this, in my tests it works correctly.
https://github.com/AaronSadlerUK/Our.Umbraco.UmbNav/blob/95edc04f68ad32be9313a72e22c1d910eaa657f2/src/UmbNav.Core/Extensions/UmbNavItemExtensions.cs#L27-L30
So much like #13 I have a feeling this is a cache issue your end.
I have however added an extension with a generic name of GetItemHtml but this just maps to GetLinkHtml

It was working for us (when other things were working). This enhancement was more about not having to use getLinkHtml to render a non link item. :) The extension satisfies the feature request for me. Thanks!


[BUG] Opening the C# solution from the U# menu will freeze the UE Editor

UE 5.4.4: When clicking that link, the C# solution will open but the UE Editor hangs. Opening the .sln outside of using this shortcut doesn't cause any issue with the UE Editor.
Tested on a new blank game project.

I don't know if this helps but this only happens to me when I use Visual Studio

Interesting observation. I use Visual Studio Community 2022. Didn't try with other IDEs.

I can not confirm this. It is not happening for me.
I have VS 2022 community too with Version 17.11.5 currently.

Same here using Visual Studio Community 2022 17.10.5 and Unreal Engine 5.4.2 compiled from source. After closing it, it stops freezing. Opening visual studio from outside has no issues.
It's probably blocking unreal's main thread.

Using UE 5.4.4 and Rider 2024.2.7, encountered the same issue.

also happens to me

Looks like it blocks in UnrealSharpEditor.cpp OpenSolution() on the line:
FPlatformProcess::ExecProcess(TEXT("cmd.exe"), *OpenSolutionArgs, nullptr, nullptr, nullptr);

Doesn't look like there's a parameter to make ExecProcess non-blocking, but we could run it as a separate AsyncTask or thread.
As an AsyncTask it'd change to this:
	AsyncTask(ENamedThreads::AnyBackgroundThreadNormalTask, [OpenSolutionArgs]()
	{
		FPlatformProcess::ExecProcess(TEXT("cmd.exe"), *OpenSolutionArgs, nullptr, nullptr, nullptr);
	});

I can create an PR with the above as it seems to fix the issue, but happy for someone who knows more about how multi-threading in Unreal works to weigh in.  (e.g. pros/cons of using AsyncTask vs a new thread (via FRunnable?) vs a more standard C++ thread)

scratch the above - FPlatformProcess::ExecProcess() blocks, but there's also a non-blocking one  FPlatformProcess::CreateProcess()

PR here: https://github.com/UnrealSharp/UnrealSharp/pull/297


:sparkles: View files task attachments

Resolves: https://github.com/konveyor/tackle2-ui/issues/1929
Functional changes:

document to be viewed is selected from the list (first action above
the editor) or via URL
display language toggle based on languages supported by the document.
For attachments the list consists of plain text and optionally a
second language discovered based on file extension (YAML or JSON).
replace "merged" checkbox with an option in the select

Related refactorings:

split getTaskById() query into specialized queries:
a) getTaskById() returning Promise for working with the object
b) getTaskByIdAndFormat() returning Promise for displaying
the task as a formatted text
configure AnalysisDetails component to respond to 2 routes: existing
details route and newly added /applications/:applicationId/analysis-details/:taskId/attachments/:attachmentId
persist merge mode in the URL as search param "merged"

Analysis details with default option pre-selected

Typical task attachment (text only)

Example of a task attachment that supports both plain text and JSON
The screenshot was taken in dev mode - under production conditions the file name would need to end with ".json".

@jortel @JustinXHale @rromannissen
Please take a look at screenshots above.
The version currently under review has some differences compared to the enhancement - most notably handling the "merged" view has changed. I've put all options in one place. Let me know if you would prefer a checkbox as before.

@jortel @JustinXHale @rromannissen Please take a look at screenshots above. The version currently under review has some differences compared to the enhancement - most notably handling the "merged" view has changed. I've put all options in one place. Let me know if you would prefer a checkbox as before.

would the default view be the Log View? I dont have any objections.

@JustinXHale

would the default view be the Log View?

yes

LGTM!


Adaptive Dialogs HttpRequest support for app level auth

HttpRequest is an usefull action in Adaptive Dialogs but you should provide an easy way to generate a token for app authentication:
For user level auth yuo provide OAuthInput but many external apis, graph and azure functions require at least app level auth.
I know that i can generate the token in a CodeAction but i think that this is a limitation at least for declarative dialog generated by composer.

Thanks, this is a very good request. I'm adding it to the backlog so we consider it in the planning of the upcoming releases.

@garypretty , please assign a priority to this item.

Priority / milestone assigned.

This will not be done in R11. Will move to the next milestone.

We're closing up R11 and moving into planning soon and will keep you updated with the decision for this ask.

@garypretty is this scoped for R12?

@mrivera-ms I am going to mark this as R12, but we may need to re-review over the coming weeks as the bigger ticket items from planning come in.

@garypretty, are we still targeting R12 for this?

@garypretty, are we still targeting R12 for this?

@garypretty, I am moving this to the next milestone. We do not have an available resource to take it now and it is a P2 item. Please ping me if you believe we should reconsider.


非推奨 google.maps.Marker

概要
現在使用している google.maps.Marker からの移行が必要
https://developers.google.com/maps/documentation/javascript/advanced-markers/migration?hl=ja
地図ライブラリ側はまだ未対応
https://github.com/JustFly1984/react-google-maps-api/issues/3337
ただし駅ピンはパフォーマンスの問題からgooglemaps api を直接使用しているためライブラリ更新以外にも対応が必要
translated in English:

Currently used google.maps.Marker must be migrated to AdvancedMarker.
https://developers.google.com/maps/documentation/javascript/advanced-markers/migration?hl=ja
but react-google-maps/api does not support it yet.
https://github.com/JustFly1984/react-google-maps-api/issues/3337
Note: due to performance issue of markers, googlemaps api is directly been used now.
So waiting for library update is not enough for my case.

I think you would get more attention if you write in english.

If number of markers is large (>10000) and their visibilities are changed frequently, performance issue can be seen in my project.
I implemented my own MarkerCluster(er) component which is flexible for large numbers of markers.
https://github.com/Seo-4d696b75/ekisagasu/blob/main/src/components/map/MarkerCluster.tsx


fix: Ensure one profile per Stronghold

Description of change
By saving the id of the first account in the profile we can check for importing strongholds that contain the same account id.
Type of change

Enhancement (a non-breaking change which adds functionality)

How the change has been tested
Tested on windows
Change checklist
Add an x to the boxes that are relevant to your changes, and delete any items that are not.

[x] I have followed the contribution guidelines for this project
[x] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes

@cvarley100 do we still want to do this? Or is it worth closing?

Multiple profiles with the same Stronghold is a useful feature for user issue resolution.


Provide current nickname in embed for infraction search

Will reduce confusion when someone does an infraction search since most users have a nickname completely different to their actual username.
Potential duplicate to this issue, not sure if it would be better to just comment on that one.

I think I can do that, using Member.nick I would like to claim the issue.

Hard to test because the infraction database is host on the website, so I cannot test my changes only running the bot.

Assigned to @kraktus

the bot's docker-compose does spin up a site container for you, so it makes it quite trivial to test this.
All you gotta do is create a few infractions. just mute yourself a few times and then do a search.

This ticket is open to anyone wishing to claim it.

This is blocked until https://github.com/python-discord/bot/issues/533#issuecomment-586673988 is figured out.


refactor: small cleanup around fullscreenmodal

removing components that just add classes, so that we can replace them with
their ui-kit pendants some time soon.
pulling out some static content (it's easier to reason about components if there
can't be a this involved).
get rid of .modal-full-screen-header-with-sub-title, which was aligning the
height of the header when installing Frameworks. chose to remove all the
complexity around it and live with a headline that's off by 2 pixels to replace
it with a ui-kit component in the future.
replace PropTypes with TS-typings.
Testing

Trade-offs

Dependencies

Screenshots

:tada: This PR is included in version 5.2.0 :tada:
The release is available on:

v5.2.0
GitHub release

Your semantic-release bot :package::rocket:


basic ELI5 how-to

I see a lot of information on the different find/replace commands and transforms, but I am not even sure how to get started. Do I just create a json file and add commands? Then how do I run it if so? I didn't see anything like this in the README/docs. Sorry if I missed it.

I mention keybindings.json and settings.json a few times.  For information on using those, see the vscode documentation.


v-a-s does not activate (with ASK) until app started

Behavior to Reproduce:

Restart/turn on device and go to home screen.
Open up app that uses (AnySoftKeyboard) keyboard app.
Tap mic phone to attempt voice recognition.

Expected Behavior:
Voice recognition starts.
Actual Behavior:
ASK's download activity notifies user that voice recognition app not installed and prompts to download app from Play store
**Of note, if vosk app started prior to attempting voice recognition through keyboard app, expected behavior occurs. Expected behavior also occurs if vosk app is force stopped through system utilities (vosk app verified stopped in background through developer settings).
Posting as a v-a-s issue given that above behavior illustrates some app/service state issue that favors cause from within v-a-s vs ASK.
*configuration
Source: [5e02806], current as of initial issue post
Build Configuration: Gradle Toolkit command-line, debug w/universal apk (compilesdk 33)
Gradle toolkit version: 7.6 (defaults despite the build kts depending on 7.2.2; no api level spec'd); builds against OpenJDK-14
Device: Pixel 3
Device OS: Android 12
Additional Device Apps: AnySoftKeyboard (v1.11.7137/F-droid; UTD)

.... Update now that I have managed to manually rebuild ASK to debugging. As of the most recent builds of ASK from current 5/2023, this isn't an issue. @nshmyrev , you can close this within 48-72 hr.

Thanks @drew-sinha. Btw, I've sent you the invite to join this project


⚠ Bofrost.at has degraded performance

In 15b7a98, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 1874 ms

Resolved: Bofrost.at performance has improved in a33e91e after 6 minutes.


Getting started with third party packages

Is your feature request related to a problem? Please describe.
Hey there, I love to see it getting more and more mature. I would like to start to use it on some projects but I'm facing "getting started" problem. The one-liner to generate a flutter app with some rust functions is great but when it comes to third parties libraries I feel lost. I've read various sections of the documentation but it miss step by step approach so we can step in without many doubts
Describe the solution you'd like

101 Imports and use a rust third party package into your dart/flutter app
101 Generating a dart/flutter package from a rust third party (may be a good answer to flutter crypto libraries chaos)

Describe what you've tried

flutter_rust_bridge one liner
cd rust
Import a third party library: cargo add nostr
cd ..
flutter_rust_bridge_codegen generate

error:
flutter_rust_bridge_codegen-2.5.0/src/library/codegen/ir/mir/ty/enumeration.rs:51:32:
enum_pool does not contain MirTypeEnumRef { ident: MirEnumIdent(NamespacedName { namespace: Namespace { joined_path: "nostr::nips::nip19" }, name: "Nip19" }), is_exception: false }
thread 'main' panicked at flutter_rust_bridge_codegen-2.5.0/src/library/codegen/ir/mir/ty/enumeration.rs:51:32:
enum_pool does not contain MirTypeEnumRef { ident: MirEnumIdent(NamespacedName { namespace: Namespace { joined_path: "nostr::nips::nip19" }, name: "Nip19" }), is_exception: false }
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

Additional context
I give here the example with the nostr third party package but I do not seek a specific answer for this, I'm looking for a more comprehensive way of using your tool his limits and how to work around.

Hi, automatically scanning a whole third party package is experimental feature and may not support too complex arbitrary packages (since there are so many corner cases for Rust). Looks like nostr may contain some edge cases that does not support yet. But feel free to use the https://cjycode.com/flutter_rust_bridge/guides/third-party/manual manual way!

Thanks to your last answer I've took the manual way
I've created a simple function that consume the third party crate:
use nostr::key::{Keys, SecretKey};

#[flutter_rust_bridge::frb(init)]
pub fn init_app() {
    flutter_rust_bridge::setup_default_user_utils();
}

#[flutter_rust_bridge::frb(sync)]
pub fn generate_nostr_keys() -> (String, String) {
    let keys = Keys::generate();
    let secret = keys.secret_key().to_secret_hex();
    let public = keys.public_key().to_string();
    return (secret, public);
}

While it's work fine on macos and ios, I'm facing this error targeting chrome with build-web related to secp256k1, probably a dependency of the third-party crate nostr
The following warnings were emitted during compilation:

warning<EMAIL_ADDRESS>error: unable to create target: 'No available targets are compatible with triple "wasm32-unknown-unknown"'
warning<EMAIL_ADDRESS>1 error generated.
warning<EMAIL_ADDRESS>error: unable to create target: 'No available targets are compatible with triple "wasm32-unknown-unknown"'
warning<EMAIL_ADDRESS>1 error generated.

error: failed to run custom build command for `secp256k1-sys v0.10.1`

…

warning: build failed, waiting for other jobs to finish...
Error: Compiling your crate to WebAssembly failed
Caused by: Compiling your crate to WebAssembly failed
Caused by: failed to execute `cargo build`: exited with exit status: 101
  full command: cd "rust" && "cargo" "build" "--lib" "--target" "wasm32-unknown-unknown" "-Z" "build-std=std,panic_abort"

Is there a work-around ?

I also had trouble building on ios and macos using web_socket_channel but this has nothing to do with rust third-party package, it's a compatibility issue between flutter_rust_bridge and web_socket_channel

Hi, that looks like a Rust compilation error. Thus maybe google / ask on the spcfici crate secp256k1-sys, since this is not flutter_rust_bridge can control.

Close since this seems to be solved, but feel free to reopen if having any questions!


Prepdocs --remove with file is not deleting files from blob storage

``### This issue is for a: (mark with an x)
- [x ] bug report -> please search issues before submitting
- [ ] feature request
- [ ] documentation issue or request
- [ ] regression (a behavior that used to work and stopped in a new release)

Minimal steps to reproduce

Try to delete a file using --remove
Vector embeddings from AI Search will be deleted, however file is still in the blob storage container

Any log messages given by the failure
None
Expected/desired behavior
File should be deleted from blob storage
OS and Version?

Windows 10

Mention any other details that might be useful
Whenever I call prepdocs with --remove of a file, the deletion logic is falling into a 'continue' statement that is skipping the deletion of the targeted file in the blob storage. The issue arises if the file does not have a number in its name.
Here, if a file named 'test.pdf' (without a number) is encountered, this code will incorrectly skip its deletion. The regular expression rf"{prefix}-\d+.pdf" is causing the function to 'continue' as it expects a number to always be present in the filename, more specifically, in between the prefix and .pdf or .png.
Problematic code:
-> scripts/prepdocslib/blobmanager.py
async def remove_blob(self, path: Optional[str] = None):
        async with BlobServiceClient(
            account_url=self.endpoint, credential=self.credential
        ) as service_client, service_client.get_container_client(self.container) as container_client:
            if not await container_client.exists():
                return
            if path is None:
                prefix = None
                blobs = container_client.list_blob_names()
            else:
                prefix = os.path.splitext(os.path.basename(path))[0]
                blobs = container_client.list_blob_names(name_starts_with=os.path.splitext(os.path.basename(prefix))[0])
            async for blob_path in blobs:
                # This still supports PDFs split into individual pages, but we could remove in future to simplify code
                if (
                    prefix is not None
                    and (
                        not re.match(rf"{prefix}-\d+\.pdf", blob_path) or not re.match(rf"{prefix}-\d+\.png", blob_path)
                    )
                ) or (path is not None and blob_path == os.path.basename(path)):
                    continue
                if self.verbose:
                    print(f"\tRemoving blob {blob_path}")
                await container_client.delete_blob(blob_path)

Possible fix is placing the await container_client.delete_blob(blob_path) in place of the continue statement. That will either delete the files if it exists in the blob storage (path is not None and blob_path == os.path.basename(path))) and also delete if the file contains any numbers between the prefix and .pdf or png.
I can put this in a pull request if the solution is satisfactory.


Fixing variable interpolation in cmd.rs

The variable interpolation we added should properly handle:
Simple variable substitution:

${target}
${report_file}
${min_risk}

Path variables in volumes:
volumes:

${HOME}/${auth_script}:/zap/wrk/auth.js
${cwd}:/data

Default values in environment variables:

${user_agent:-robopages}

The changes we made to cmd.rs should be backward compatible because:

It still handles basic command line arguments without variables
It properly interpolates variables from the environment
It maintains the existing container support
It preserves all the existing functionality while adding variable substitution

@elderhp a few questions to make sure i'm on the same page as you about what this PR is about.

Simple variable substitution:
${target}
${report_file}
${min_risk}
...
...

This was supposed to be implemented and working already, did you find any bugs about it? I'd like to fix it if there's one.

Default values in environment variables:
${user_agent:-robopages}

As per README default values are already supported by the ${name or default} syntax. Moreover this PR doesn't seem to add any additional default parsing but only env variables interpolation ... what am I missing?

...
It properly interpolates variables from the environment
...

Environment variables were already interpolated here when referenced explicitly with ${env.variable_name} ... found any bugs with this behaviour?


Added Hazelcast liveness and readiness probe. Cleaned up Hazelcast health indicator.

Closes lhotse#31

I thought the idea was to allow consumer of the health indicator to have
special handling about unhealthy cluster in k8s in that it can somehow
ignore or delay any action since k8s will self recover? Or maybe I didn’t
understand its purpose in the first place.
On Mon, 24 Aug 2020 at 8:24 am, Sebastian Luehr<EMAIL_ADDRESS>wrote:

@sluehr commented on this pull request.

In
src/main/java/engineering/everest/starterkit/axon/HazelcastHealthIndicator.java
https://github.com/everest-engineering/axon-command-distribution-extension/pull/4#discussion_r475274551
:

             .build();

 }

private boolean determineIfRunningInKubernetes() { // TODO: replace with @ConditionalOnCloudPlatform()

No, it seemed pointless to me when you look at what it does.
Setting a Boolean to indicate whether you're running in k8s.... why on
earth did we ever do that?
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
https://github.com/everest-engineering/axon-command-distribution-extension/pull/4#discussion_r475274551,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAR4K5EXPIPLBSSBKDZJI33SCGJJNANCNFSM4QFUPZ2Q
.
--

                  Life is elsewhere

Nah, custom logic for handling the health state conditional on whether in k8s or not would quickly spiral out of control.
The new liveness and readiness health endpoints were introduced in Spring Boot 2.3 explicitly to support k8s which is a much better outcome all round.


Changes to parent dir before checking for gulpfile.coffee

project/
├─ gulpfile.js
└─ subdir/
  └─ gulpfile.coffee

What were you expecting to happen?
Running gulp in /subdir, I'd expect it to use gulpfile.coffee
Yes, I have coffee-script installed locally and it did work on a previous gulp version (I think I had 3.8.8 before, but possibly newer)
What actually happened?
~/project/subdir$ gulp
[13:34:15] Working directory changed to ~/project
[13:34:17] Using gulpfile ~/project/gulpfile.js

What version of gulp are you using?
CLI version 3.9.1
Local version 3.9.1
What versions of npm and node are you using?
node v6.3.0
npm v3.10.3

@ripexz: This was actually just fixed: is your dependency tree up to date?
https://github.com/gulpjs/gulp/issues/1823#issuecomment-253349513

@callumacrae ah, I updated all deps and it works with<EMAIL_ADDRESS>thanks! 😄


chore(deps): update common-dev-assets digest to d66ebf9

This PR contains the following updates:

Package
Update
Change

common-dev-assets
digest
436485c -> d66ebf9

Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.

[ ] If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

:tada: This PR is included in version 2.1.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket: