Version info doesn't appear to be configured properly

Based on a quick one-off test the build info is being set properly, but isn't being returned properly via --version  or -h flags.
$ ./release_assets/elbow/elbow-v0.7.3-8-g8ff1aee-dirty-linux-amd64 --version
version: v0.7.3-8-g8ff1aee-dirty

ELBOW dev
https://github.com/atc0005/elbow

This is from me prepping for a v0.7.4 release and having just created the cmd/elbow structure. The version: v0.7.3-8-g8ff1aee-dirty string is from a fmt.Println("version:", version call within main(), proving that the Makefile is properly generating and passing in a version string based on the current git tag info.
Somewhere later in the code the value is lost, perhaps as part of merging the various config sources? I suspect that the version info isn't the only detail lost.

Somewhere later in the code the value is lost, perhaps as part of merging the various config sources? I suspect that the version info isn't the only detail lost.

$ git diff
diff --git a/config/config.go b/config/config.go
index 8a8d240..bc72dac 100644
--- a/config/config.go
+++ b/config/config.go
@@ -187,6 +187,9 @@ func NewConfig(appVersion string) (*Config, error) {
        // default.
        argsConfig := Config{}

+       // TESTING: Try bolting on version info directly to argsConfig
+       argsConfig.AppVersion = appVersion
+
        // Initialize logger "handle" for later use
        baseConfig.logger = logrus.New()

Results:
$ go build -mod=vendor -a -ldflags="-X main.version=$(git describe --always --long --dirty)" ./cmd/elbow && ./elbow.exe --version

ELBOW v0.7.5-2-gebd9b3e-dirty
https://github.com/atc0005/elbow

Wider view:

	// Apply default settings that other configuration sources will be allowed
	// to (and for a few settings MUST) override
	baseConfig := NewDefaultConfig(appVersion)

        // ...

	// Settings provided via command-line flags and environment variables.
	// This object will always be set in some manner as either flags or env
	// vars will be needed to bootstrap the application. While we may support
	// using a configuration file to provide settings, it is not used by
	// default.
	argsConfig := Config{}

	// TESTING: Try bolting on version info directly to argsConfig
	argsConfig.AppVersion = appVersion

	// Initialize logger "handle" for later use
	baseConfig.logger = logrus.New()

	// Bundle the returned `*.arg.Parser` for later use from `main()` so that
	// we can explicitly display usage or help details should the
	// user-provided settings fail validation.
	baseConfig.flagParser = arg.MustParse(&argsConfig)

Earlier we set baseConfig which populates the AppVersion field with the provided version string, but we did not apply the same version information to argsConfig or fileConfig, presumably due to an earlier decision to allow each config source to fully override all field values (which I later reversed course on). It is either that or this has been broken for a very long time now.

There is probably a more elegant way to do this, but since the majority of the earlier tags did not use the cmd subdirectory structure, this loop built and generated help output that I could visually review:
 for tag in $(git tag -l); do git checkout $tag && go build -a -ldflags="-X main.version=$(git describe --always --long --dirty)" && ./elbow.exe -h; done

The version string was present at first appearance up to v0.6.2 at which point it vanished for v0.7.0 and later releases.

From the v0.7.0 CHANGELOG:

Add support for importing settings from a TOML configuration file
Add support for merging multiple config sources

the defined precedence decides what config source wins for a specific setting in case of a
conflict.
non-conflicting settings are merged into one comprehensive configuration


Generated RSA private key's private exponent value range is small

I am generating 2048-bit RSA private keys with the following code:
var gen = new RsaKeyPairGenerator();
gen.Init(new KeyGenerationParameters(new SecureRandom(), 2048));
var keyPair = gen.GenerateKeyPair();

The generated private keys have a private exponent value whose range seems smaller than I would expect. I generated 100 of these keys and grouped them based on the value of the most significant byte (assuming the private exponent is a 256-byte value)

byte[0] = [0 - 31]: 65 keys
byte[0] = [32 - 63]: 23 keys
byte[0] = [64 - 95]: 10 keys
byte[0] = [96 - 127]: 2 keys
byte[0] = [128 - 159]: 0 keys
byte[0] = [160 - 191]: 0 keys
byte[0] = [192 - 223]: 0 keys
byte[0] = [224 - 255]: 0 keys

I compared these with CNG-generated keys, using the following code:
CngKeyCreationParameters creationParams = new CngKeyCreationParameters
{
    ExportPolicy = CngExportPolicies.AllowPlaintextExport
};
creationParams.Parameters.Add(new CngProperty("Length", BitConverter.GetBytes(2048), CngPropertyOptions.None));
var key = CngKey.Create(CngAlgorithm.Rsa, null, creationParams)

Here is the corresponding list for these keys:

byte[0] = [0 - 31]: 19 keys
byte[0] = [32 - 63]: 11 keys
byte[0] = [64 - 95]: 19 keys
byte[0] = [96 - 127]: 18 keys
byte[0] = [128 - 159]: 15 keys
byte[0] = [160 - 191]: 13 keys
byte[0] = [192 - 223]: 4 keys
byte[0] = [224 - 255]: 1 key

The CNG keys have private exponents whose values cover a much larger range than BouncyCastle-generated keys. I am not sure if this is a security issue, but I wanted to bring it to light. Is this the intended behavior?

Our RSA key generation uses Carmichael's totient (especially for the FIPS versions it's mandatory), so the distribution of lengths you show does not look unusual.
The distribution for CNG-generated keys looks consistent with use of Euler's totient.

One thing I'm curious about, I noticed you included 0 in the ranges. How many values in each set have zero as the first byte?

I created 300 each of BouncyCastle keys and CNG keys. For the CNG keys, 1 key had 0 for the first byte of the private exponent. For the BouncyCastle keys, I exported the private exponent as an unsigned byte array and counted the number of arrays with 255 bytes. Counting this way, I found 17 keys.

Interesting - there might be something wrong with the unsigned export - the BC BigInteger convert to two's complement byte arrays - the zero byte to prevent the number being negative (as is the lack of a top bit being set). I think you'll find there are more keys in the 128+ range and less in the 0-31.


Babel compatible AST

Heya,
thanks for this amazingly fast parser! I've been playing with replacing it with Babel's parser, but I also used a number of babel libraries which expect a Babel AST. Namely span to be in-lined (collapsing LogicalExpression into BinaryExpression does not seem to be causing problems). Now I was wondering whether the divergence from Babel's AST is wanted? I can imagine integration into all kinds of related libs to be simpler when conforming to their AST more. Or is there a perf cost associated with these differences?
Would be curious to learn more and I did not find a past issues that made me understand.
Cheers!
Edit: Oh I also just saw that BlockStatement is also shaped differently

It's not hard, but not trivial at all.
It would require really lots of work.

There are also some cases were babel made some incorrect namings in their AST https://github.com/swc-project/swc/issues/548
Also, generally SWC moves faster than Babel and so sometimes SWC is ahead with their support for TS language features. So SWC could implement something then Babel could come along and implement it with a different AST shape.

Just curious, won't this eventually need to be done to support #1321 ?

@dwoznicki Yes, this is required for #1321.

Thank you for such a nice project :). I'm working on putout code transformer, it has support of the most popular JavaScript parsers that producing estree and babel AST (with help of estree-to-babel adapter). This made to have ability to switch into fastest one, right now babel is default.
As I see swc should be the fastest parser, because it's written on Rust and as I understood it's willing to be successor of babel. I think that would be amazing to add support of swc parser (or switch to it in the future, if it really will be faster) to putout, but I see that it has different AST format.  Would be great to see all deviations from babel AST, as I understood from @Gregoor they are not to many, so some adapter can be written for this purpose (hope it wan't kill all speed :)).
About TS language it's not a problem that syntax is different, anyways would be great to have a list of differences, to simplify switching from one tool to another. Also babel has a lot plugins, reach ecosystem and even a book, so would be beneficial to have ability to reuse all this tools that using Babel AST :).

@coderaiser I know it worths it, but I just don't have time.
And as swc is also used from rust side, changing ast definitions to match one of babel is unacceptable.
swc-to-babel, written in rust, would be a better solution and would not be hard.

@kdy1, swc-to-babel adapter is great, even written in JavaScript, but in Rust it will be definitely faster.
Also would be amazing to have ability to get tokens list from the root of ast. It needed for recast, that helps to change only code that matters, not the whole file. In other case another parser should be used to get tokens list (esprima by default) and this can nullify all speed benefits of swc.

Heya, I noticed babelify is still commented out in the exported JS, are there issues you consider blocking before exposing it?

Yes, some more works are required

I started working on babelify and swcify.
I'd like to know your usecase to determine api. (e.g. file vs ast vs source code for input)
Can you tell me about it?

I'm also going to write babel-plugin runner so I'm not sure if babelify is necessary.

I started working on babelify and swcify.
I'd like to know your usecase to determine api. (e.g. file vs ast vs source code for input)
Can you tell me about it?

I want to use swc as drop-in replacement of babel parser in putout linter, to use as an input for recast.
Also would be nice to have generator, but parser is also amazing, especially if it will be faster.

Maybe acorn's AST is more standard.
https://astexplorer.net/

I tried this, but actually, it was slower.
Parsing as babel AST was performant enough, even though it does parsing and converting.
But returning the parsed ast back to javascript world was too slow.
This is the number I get.

This is rust-side benchmark, which uses same file but from rust side.

It's about 37365 ops / sec.
I'll investigate a way to make crossing boundaries faster.

In my mind, babelify may not the most important task. The target may make the js plugin system more user friendly. For example: 1. create some type node faster; 2. node type checker; 3. playground...

In my mind, babelify may not the most important task. The target may make the js plugin system more user friendly. For example: 1. create some type node faster; 2. node type checker; 3. playground...

@SoloJiang
For 1, almost all of slowdown comes from passing ast nodes from rust to node.
(It might be worth using wasm, as V8 is free to optimize it while native addons are not)
For 2, I'm working hard on it.
For 3, https://swc.rs/docs/online-repl although it's does not show ast.
For 4, can you elaborate?  What does code like babel/generator means?

For 4: like this https://babeljs.io/docs/en/babel-generator. Developer can use it verify their plugin quickly.

For 1: my meaning is not runtime speed. Okay, my presentation problem. I  mean I can create AST nodes very quickly....

@SoloJiang @kdy1
I don't think it's necessary to be compatible with Babel's AST standard, but I'm still worried about the data transfer between rust and js, which is a performance bottleneck. I have seen that parcel operates AST directly on the rust side (using wasm), which seems to be the best solution at present, but swc does not provide a plugin system for rust.

I'll fix swc.print() along while fixing the plugin apis.
(I need to verify codegen anyway to verify plugin api.

@yisar you are right, but js plugin system for the front developer is more friendly? rust plugin system and js plugin system, we all need =。= ... The decision to use the plugin system should be the developer's.

@yisar I came up with an idea. I didn't make rust plugin system because

rust does not have abi and the ast definitions of swc are changing quite frequently
deploying node binaries are hard

But passing down ast as json to plugin would be performant enough and I can create a wrapper for swc plugins using proc macros.
@SoloJiang Do you mean users of swc should decide the language used for plugins?

For 1: my meaning is not runtime speed. Okay, my presentation problem. I mean may it create AST nodes very quickly....

For this, I can create import xxx from  'ABC' by:
t.importDeclaration([t.importDefaultSpecifier(t.identifier(localName)], t.stringLiteral(value));

@kdy1 Yeah, I mean this.

For 3: I mean AST playground, hhhhh

@kdy1  Unfortunately, I have tested the performance of swc_wasm, but it is still very slow.
I feel that it is unreliable to operate AST in js side, because there is no good way to optimize it by serializing AST as JSON and passing it back and forth.
Now I can only use SWC to operate AST in rust side, and then pass a simple structure to js side.

@yisar Yes, I also think so.
I'll provide rust plugin API and plugins for various open-source projects.
(Porting a babel plugin is very easy task to me, but API for such system is hard)

Just tying this issue to #1366 as any adapter will need valid span/range/start/end values (which are lacking at the moment)

Hi there, just heard of SWC today and I'm not sure if this is the right place to ask but - I'm curious how one would go about migrating their babel macros to work with SWC ?? I see some documentation on plugins but doesn't quite look like the same thing.
Most common problem trying to solve is reading in values from package.json or environment variables at compile time. But the @emotion/styled/macro would also be a huge win / non-start to switching away from babel.

I'm going to provide a rust plugin api and deprecate node apis.
Babel plugins are not supported.

I'm going to provide a rust plugin api and deprecate node apis.

Just to confirm, does this mean that we should avoid writing plugins similar to the example here: https://swc.rs/docs/usage-plugin? Will this kind of js plugin be deprecated in the future in favour of rust-only plugins?

@jdb8 Correct. It's simply misdesigned.

@kdy1 good to know, thanks - I wonder if it would be worth updating that page with a deprecation warning? I was briefly considering porting some plugins from Babel to swc, but I'll definitely now wait until the Rust api is finalised.

I added it. Thanks!

@kdy1 would this rust plugin api allow us to build macros similar to babel macros?

Yes it will.

I think #2175 is relevant to this discussion. I've done some experiments into ways to speed up parse().

This can be a solution: swc-to-babel. But I need a comments as well. I'm working on 🐊Putout, and comments really needed 🤷♂.
Here is AST examples for Babel:
{
  "type": "File",
  "start": 0,
  "end": 29,
  "loc": {
    "start": {
      "line": 1,
      "column": 0
    },
    "end": {
      "line": 3,
      "column": 1
    }
  },
  "errors": [],
  "program": {
    "type": "Program",
    "start": 0,
    "end": 29,
    "loc": {
      "start": {
        "line": 1,
        "column": 0
      },
      "end": {
        "line": 3,
        "column": 1
      }
    },
    "sourceType": "module",
    "interpreter": null,
    "body": [
      {
        "type": "FunctionDeclaration",
        "start": 9,
        "end": 29,
        "loc": {
          "start": {
            "line": 2,
            "column": 0
          },
          "end": {
            "line": 3,
            "column": 1
          }
        },
        "id": {
          "type": "Identifier",
          "start": 18,
          "end": 23,
          "loc": {
            "start": {
              "line": 2,
              "column": 9
            },
            "end": {
              "line": 2,
              "column": 14
            },
            "identifierName": "world"
          },
          "name": "world"
        },
        "generator": false,
        "async": false,
        "params": [],
        "body": {
          "type": "BlockStatement",
          "start": 26,
          "end": 29,
          "loc": {
            "start": {
              "line": 2,
              "column": 17
            },
            "end": {
              "line": 3,
              "column": 1
            }
          },
          "body": [],
          "directives": []
        },
        "leadingComments": [
          {
            "type": "CommentLine",
            "value": " hello",
            "start": 0,
            "end": 8,
            "loc": {
              "start": {
                "line": 1,
                "column": 0
              },
              "end": {
                "line": 1,
                "column": 8
              }
            }
          }
        ]
      }
    ],
    "directives": []
  },
  "comments": [
    {
      "type": "CommentLine",
      "value": " hello",
      "start": 0,
      "end": 8,
      "loc": {
        "start": {
          "line": 1,
          "column": 0
        },
        "end": {
          "line": 1,
          "column": 8
        }
      }
    }
  ]
}

And SWC:
{
  "type": "Module",
  "span": {
    "start": 0,
    "end": 12,
    "ctxt": 0
  },
  "body": [
    {
      "type": "VariableDeclaration",
      "span": {
        "start": 0,
        "end": 12,
        "ctxt": 0
      },
      "kind": "const",
      "declare": false,
      "declarations": [
        {
          "type": "VariableDeclarator",
          "span": {
            "start": 6,
            "end": 11,
            "ctxt": 0
          },
          "id": {
            "type": "Identifier",
            "span": {
              "start": 6,
              "end": 7,
              "ctxt": 0
            },
            "value": "a",
            "optional": false,
            "typeAnnotation": null
          },
          "init": {
            "type": "NumericLiteral",
            "span": {
              "start": 10,
              "end": 11,
              "ctxt": 0
            },
            "value": 5
          },
          "definite": false
        }
      ]
    }
  ],
  "interpreter": null
}


Application has to support multiple languages

If the user doesn’t provide the correct details as input, we’d like to show error messages according to the user’s locale.

NB: https://www.baeldung.com/spring-custom-validation-message-source


Add git config: checkout CRLF commit LF

Added "git config --global core.autocrlf true" to the appveyor.yml to improve the AppVeyor console output by continuing to checkout during the build process with CRLF line-endings and commit with LF line-endings, which is the preferred line ending format.

Fixes #120

Nice work, thank you @tlindsay42!


feat(Card): enable border for mdl-card__supporting-text

I believe we should also enable border for mdl-card__supporting-text as well.
Usage:
<div class="mdl-card__supporting-text mdl-card--border">
Now I can have divisions inside my card
</div>

I'm not sure what went wrong here.

cc @sgomes want to take a look at this v1 change?

Yup, will take a look next week, as I'm out for a bit. Thanks for the PR, @leocaseiro! Please remind me if I forget, which is somewhat, if I know myself :)

Thanks @traviskaufman and @sgomes.
Is there anything I could do to fix the CI failing?
Good, next week 😄

LGTM, thanks @leocaseiro!


Improve ast handeling

The current handle ling of the inpit ast is fairly basic and easily breaks.
Improve it to handle both prefix and suffix.

Any thing that ends with -- currently fails


Fix Flexbox Bug

Fix Flexbox Result Issue
Clean CSS
Add Loading

Nice job @Mylena-Rodrigues! Amazing! 🎉
PR approved


Migrate from nUnit to xUnit

Related to #101

coverage: 78.934% (-0.2%) from 79.16%
when pulling 4ee5e71bd2906d7d553816cfccf4beb5ae719371 on refactor/migrate-to-xunit
into 790ddc9111ad061aad2a9e960e1f206716d18e43 on master.


StockVisualEnhancements fix

Use bundled EVE and conflict with the full EVE.

See also PR #3784

politas just in case you didn't see my comment on the forums. The current version of SVE has the latest release of EVE bundled in it.

So, is SVE anything more than an EVE configuration set?

This most recent config will break SVE. SVE currently provides its own surefire working EVE plugin, as EVE updates break config packs from time to time. Installing EVE over SVE causes some impressive graphical and performance issues, and that's exactly what you seem to be proposing to do.

The conflict with EnvironmentalVisualEnhancements-Config, shouldn't have allowed any other EVE config to install, but ok, let's go back to using the bundled EVE and conflicting with EVE.

Just checking the conversation vs the code. The code changes have this depend upon EVE rather than conflicting with it. Is that correct?

No, it's installing the bundled EVE and conflicting with EVE

@Nhawks1717 should CKAN only be installing the spacedock release or should we make each quality level available via the github releases?

That would require Github releases.

So is it fixed now or no? I'm a bit confused.

The current state of the config should work. At the moment SVE provides both configuration and base - and conflicts with anything that provides either configuration or base.

Okay, I'll let the thread peps know this'll be merged soon. Thanks for the hard work guys.

Looks good to me, merging with my thanks.


FE search suggestions input bug

Go to Catalog page -> Groups tab -> Add entity group form.
If you enter a search query into add entities field main search input will be also updated.

It works fine. Seems to be fixed in previous releases.


Broadcasting localhost; broadcasting complex objects with pivot table entries; broadcasting softdeleted data

Laravel Version: 5.3.16
PHP Version: 7.0.11
Database Driver & Version: My main Database is Postgres 9.6, I also use Redis on windows to do my Broadcasting

Description:
I am not sure if I am posting my issue at the right place; should there be a better place, feel free to point me to that place.
I have 3 odd Braodcasting related issues and for 2 of them kind of dirty solutions.
Right now I am developing on a Windows System. On the Server side I am using Laravel Echo Server (socket.io and redis ..... => without pusher https://github.com/tlaverdure/laravel-echo-server), the MSOpen version of Redis for microsoft (https://github.com/MSOpenTech/redis), Laravel 5.3 and Postgres 9.6.
On my client side I am using Laravel Echo for the broadcasting and some other typical JS libraries for client side stuff. I am not using Vue though.
My first issue is related to using the laravel development server (php artisan serve) to test my application on my windows system. When I run that command I am able to use the application fine on localhost:8000. The localhost ip adress variant (<IP_ADDRESS>:8000) doesn't work. Because of this issue the laravel-echo-server is not able to authenticate my users. It will automatically change localhost:8000 to the ip adress variant and thus fail to connect. I am able to fix this by running: php artisan serve --host <IP_ADDRESS>  This feels kind of dirty though. Is there a way to setup the laravel development server on windows so that I can use the localhost ip adress variant/ why is <IP_ADDRESS>:8000 not available?
My second issue is related to the data I am broadcasting. Within my application I have a projects table. This table has a n:m relationship with my users table.  In the user-project pivot table I am storing which user is currently doing what in which project.  Within my broadcast I want to broadcast to all users in my application  what the users which are part of the project are currently doing in the project . My broadcastevent is setup in a way that the constructor receives the project as well as the pivot table data inside of it.  If I broadcast the project without doing anything else my clients will receive the project but will not receive the pivot table data. If I iterate over the entries in my pivot table within the broadcastOn method, my clients will receive the project data as well as the pivot table data. This "solution" feels super dirty and wrong. Why does it happen and what is the proper solution.
 $project = Project::with('users')->findOrFail($projectId);
 broadcast(new XYZ($project))->toOthers();

class XYZ implements ShouldBroadcast
{
 use InteractsWithSockets, SerializesModels;
 public $project;

 public function __construct(Project $p)
    {
        $this->project = $p;
    }

 public function broadcastOn()
    {
        $channels = array();
        foreach ($this->project->users as $u) {
          //without this loop the pivot table (->users) is not broadcasted
        }
        $users = User::all();
        foreach ($users as $user) {
          array_push($channels, new PrivateChannel('App.User.'. $user->id));
        }
        return $channels;
    }
}

The third issue occurs when I try to delete a project. Projects in my application are using soft delete functionality. If a project is deleted I want to basically broadcast to all members in that project that it got deleted.  This doesn't seem the work (my logging in the broadcastOn method of this event indicates that the broadcastOn method is not called).  I asume it doesn't work because of the softdelete (it works if I comment out the  $project->delete(); ); are there any special rules for broadcasting softdeleted objects?
 $project = Project::with('users')->findOrFail($projectId);
 broadcast(new XYZ2($project))->toOthers();
 $project->delete();

class XYZ2 implements ShouldBroadcast
{
 use InteractsWithSockets, SerializesModels;
 public $project;

 public function __construct(Project $p)
    {
        $this->project = $p;
    }

   public function broadcastOn()
    {
        $channels = array();
        Log::info('broadcastOn $this->project: '.$this->project); // nothing is written in Log file
        foreach ($this->project->users as $u) {
          array_push($channels, new PrivateChannel('App.User.'. $u->id));
        }
        return $channels;
    }
}

Have you tried using Homestead?

Have you tried using Homestead?

Sadly using a vm is currently not an option for me.

@JCLengeling still having this issue?

I am still solving my first 2 problems in the described (as I feel dirty) way and I kind of solved the broadcasting softdeleted data issue.
I solved this issue by using the ShouldBroadcastNow interface instead of the ShouldBroadcast interface. So the issue might be that my event instances get put on a queue and as soon as it is the turn of the queued event some error occurs.
I am kind of new to PHP and if I understand correctly PHP should work in a “pass-by-value" way. So
in the construction of the event broadcast: broadcast(new XYZ2($project))->toOthers(); the project should be passed as a value (not a reference) and thus deleting the original $project after basically creating a "copy" of the $project in the Broadcast Event instance shouldn't influence the copied value in the Broadcast Event instance.
The outcome of my code (what I am seeing when I run my web application) kind of indicates that this understanding of mine is wrong or that there is a bigger issue. An indication that my understanding is wrong is actually my second issue. If it truly would be “pass-by-value" I shouldn't need to reiterate trough the previously (eager) loaded data.

For your second issue, I think you need to load the relationship, when you run $this->project->users the relationship gets loaded and that's why it becomes available, try:
$this->project->load('users');

For your third issue, it's related to how we unserialize models, I'm checking if we can safely change this behaviour. For your first issue, I think the solution you came to is the trick :)

Thanks for the reply. I succesfully replaced the ugly foreach loop with the suggested code :D

👍
This was merged today as well: https://github.com/laravel/framework/pull/16301#event-851900629
This will allow for unserializing soft deleted models, which will solve your 3rd issue.
As for the first issue I highly recommend that you use Homestead on Windows, it solves a lot of issues.


Dart -> Engine roll failing on python syntax error

Starting with https://github.com/flutter/engine/pull/25633. Possibly from https://dart.googlesource.com/sdk.git/+/b5c63ce7577c8c7634651dfac28d3e093bba91f7
 File "/b/s/w/ir/cache/builder/src/third_party/dart/runtime/third_party/binary_size/src/run_binary_size_analysis.py", line 627
    file=sys.stderr)

/cc @athomas @godofredoc @a-siva

/cc @aam

Well, the script is python3-compliant now, but the original problem was actually that python2 is used (from cipd_bin_packages)
https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket.appspot.com/8849470996820397072/+/steps/generate_treemap_for_android-arm64-release/0/logs/execution_details/0:
'/b/s/w/ir/cipd_bin_packages/python',
  '-u',
  '/b/s/w/ir/cache/builder/src/third_party/dart/runtime/third_party/binary_size/src/run_binary_size_analysis.py',

@godofredoc any ideas how to switch this to python3?

if getting python3 on luci builders is a problem then temporarily we might have to fork python2 version of runtime/third_party/binary_size/src/elf_symbolizer.py and
runtime/third_party/binary_size/src/run_binary_size_analysis.py

It would probably help to have a temporary python2 version available - it would be even better if you could leave the existing scripts as python2 and make new ones that are python3, otherwise we have to do a recipe dance to make it work that will break all open PRs until they sync to head :\

We could also temporarily disable the treemap analysis if a fix is incoming for this soon, to unblock the roll.

Can the old version of the script be run with python3, or is it incompatible?

We can also just temporarily disable the treemap upload until this gets resolved.

it would be even better if you could leave the existing scripts as python2 and make new ones that are python3

Given bigger migration away from python2, there was a concerted effort to move all of dart sdk python scripts to python3.

Can the old version of the script be run with python3, or is it incompatible?

It is incompatible unfortunately.

We can also just temporarily disable the treemap upload until this gets resolved.

SGTM

That step has been commented out and the roll has landed - we can keep this open to track using vpython3 to get it running again.

thank you @dnfield !

FWIW: I don't think vpython3 is much better than python3 for scripts without dependencies. You could also rely on the shebang and change the recipes to run bash -c script.py if the script is executable (elf_symbolizer isn't, but perhaps it's not meant to be run) as a temporary measure.
The task that failed had python3 on the path via this CIPD package:
Environment Prefixes
--
PATH=cipd_bin_packages:cipd_bin_packages/bin:cipd_bin_packages/cpython:cipd_bin_packages/cpython/bin:cipd_bin_packages/cpython3:cipd_bin_packages/cpython3/bin

cipd_bin_packages/cpython3/
--
Requested: infra/3pp/tools/cpython3/${platform}:version:3.8.7.chromium.12

Oops sorry - trying to fix some issues with my local SDK and pushed some changes to my GitHub fork as a backup. Didn't occur to me that would happen - I'll check I didn't close anything else 😱

CL for the fix:
https://flutter-review.googlesource.com/c/recipes/+/12740

The fix seems to have landed. Closing. Please reopen if I am mistaken.


DE50056: disable skeleton pulse animation in Safari

DE50056:
https://rally1.rallydev.com/#/15545167705d/custom/21568985922?detail=%2Fdefect%2F647111877577
For an unknown reason, starting with Safari 16 the pulsing skeleton animation causes FACE (assignments, quizzing) and possibly other pages that make use of skeletons to render a blank page.
I tried a few different alternatives, but in the end disabling the animation was the only thing that worked reliably. I'm hoping that Apple fixes this relatively quickly and we can restore things.
This will be cert-fixed to 20.22.10 and possibly hotfixed on 20.22.09.

Ugh... need to figure out a way to disable stylelint.

Glad you had to come up with that Regex and not me!

Haha I didn't, it was what I considered the best out of several Stack Overflow provided options! :)

Tested out the regex...

Thanks for the extra testing, appreciate it!


Quote matching logic should not apply when I am in the midst of writing a comment

In the gif above, the ' is automatically paired as I am writing the sentence, even though I am writing a comment and ' used as an apostrophe is more likely to happen.

The logic for that depends on the language you are using. Please update this issue with that detail

Hello @jreiken, I am developing in Javascript :smile:

I'm not able to reproduce on the latest Insiders. @julianlam can you try with the latest here?

I confirmed this behavior is present in the latest insiders builds for both singleline and multiline comments in JavaScript.

@waderyan Like @mjbvz I am able to reproduce this on the latest insiders build

Seems to be fixed in the latest insiders builds. I believe the fixing change was 4bb1d18d6a6599ae93d03571961ca055ce6dcf58

Confirmed fixed in the new versions updated this morning (1.8.0-insider (1.8.0-insider))


Updates/Fixes to E-Heza Nomination

Fixes

link to open source (Apache 2.0) license
typo in maintainer email address.

Thanks @adamhstewart, this looks good to me. We will instead merge the changes into #1342 to allow the reviewers make comments on the original PR.


Logos page alias update

We have been working on an updated version of the GBIF logos and identity system page and we need to update the alias /logos so that it points to this page instead of the old page.
Thanks!

There is a field called url alias in contentful.
The existing page https://app.contentful.com/spaces/uo17ejk9rkwj/entries/4DXYM8oohOuKI2sw4syEGk
has the value /logos
The new page https://app.contentful.com/spaces/uo17ejk9rkwj/entries/6lIWX44DtYLMYBqB3k2UAh
has no urlAlias listed.
You should update that. If it does not work, then please reopen.

My apologies—I thought we needed to update these in the registry when switching pages at a given alias!
Sent with GitHawk

No worries. I see it worked


Destructuring Header Component: Download button not visible

Description
Currently, the download button is not visible but lies under the header component. Also, the header component has no header tag and is therefore not accessible.
Acceptance criteria

[ ] change the nav to header tag (since there is no navigation the nav would be inaccurate to use)
[ ] delete all unnecessary tags
[ ] wrap logo and name into the same tag
[ ] set the alt text of the logo image to alt=""
[ ] change h2 of Name to span, with no className
[ ] add DownloadButton.js into the Header.js component, after the logo
[ ] use display: flex, and justify-content: space-between to let the logo appear on the left and the DownloadButton appear on the right side
[ ] delete all unused CSS for this component
[ ] move and adjust the inline style of the button into the App.css file.
[ ] move content of Header.css to index.css (and delete the now empty component)
[ ] change backgroung-color of nav to white and set a box-shadow

Write className like
header, header-logo, button-download
Screenshots
Header component

Source code

Additional information
Please make sure your fork has the latest updates before opening a pull request (PR).

@YuriDevAT , assign me this issue

Hiya, please could you assign this to me and I'll have a go following the notes you made and let you know if I have any queries.
Thanks, Alexis

Nice to have you on board, @LittleMissButtons. 🔥


Add missing return values to MsiDatabaseOpenViewA.  The doc is still unclear whether a PMSIHANDLE can be specified for param phView.

Notes:
I neglected to make a corresponding edit to the MsiDatabaseOpenViewW function documentation page.  Please commit a corresponding change to that page as well.
Related API documentation issues which I lack the knowledge to confirm:
ISSUE 1:
In the Remarks section, both pages state:

it is recommended to use variables of type PMSIHANDLE because the installer closes PMSIHANDLE objects as they go out of scope, whereas you must close MSIHANDLE objects

However, in the Syntax section, the type of parameter phView is specified as MSIHANDLE.  There is no explicit mention within the Syntax section that phView can be an MSIHANDLE or a PMSIHANDLE.
ISSUE 2:
The result set for an executed view must be closed by MsiViewClose.  This would happen prior to closing the MSIHANDLE for the view.  But if the view is initially opened using a PMSIHANDLE, there is no mention in the documentation for MsiViewClose whether MsiViewClose can accept a PMSIHANDLE, or whether MsiViewClose needs to be called as follows when the view was opened with a PMSIHANDLE:
// Open view using a PMSIHANDLE named MyPMsiHandle...
// Execute the view...
// Close the result set of the view:     UINT result = MsiViewClose(MyPMsiHandle());
// Note the extra parentheses after MyPMsiHandle, which should return the raw MSIHANDLE.
// If these extra parentheses are required the documentation for MsiViewClose should indicate so.

@Mike4Online I'm accepting your change. Thanks for catching and fixing this error in the docs. I looked at the header files and it looks like PMSIHANDLE implements a casting operator to MSIHANDLE, so it should work for all APIs that accept MSIHANDLE. I've added a sentence about this behavior to the Use PMSIHANDLE instead of HANDLE section that is linked in the docs. The update should be live within ~24 hours.

I've added a sentence about this behavior to the Use PMSIHANDLE instead of HANDLE section that is linked in the docs.

Thanks for doing this.
One other consideration that is not obvious is whether a PMSIHANDLE can be assigned by other MSI functions which assign handles to MSIHANDLE objects.  If so, then a PMSIHANDLE can truly be used in place of an MSIHANDLE object throughout the SDK.  But if not this behavior should be noted.  Either way its an additional documentation update.

One last oddity: many of the MSI functions will return values such as ERROR_SUCCESS.  These values are typically long values, but the return type in most MSI functions is UINT.  This can involve a need to cast return values from long to UNIT.  But I have not found any mention of this in the SDK docs, or whether a return value could ever NOT be successfully cast to UINT without losing data.


Next button gets cut off in Spanish view, assuming other languages as well

Describe the bug
Button label for Next button gets cut off in Spanish
To Reproduce
Steps to reproduce the behavior:

Go to any skill map
Click on set language to spanish
Scroll down to next button
See error

Expected behavior
I should see the entire translated word for "Next"
Screenshots

Removing 7rem CSS rule from .tutorial-controls .ui.button worked to show the entire label, but not sure if there restriction was there for another purpose.

That rule shouldn't be necessary anymore / is a leftover from old tutorial layout, can probably just delete it (after testing different layouts real quick)

There are targets which use older layout, like microbit through a key. Please ensure they work with the changes as well.


tf.image.flip_left_right and tf.image.flip_up_down incorrectly assumes rank-3 image and flips along the wrong axis

System information

Have I written custom code (as opposed to using a stock example script provided in TensorFlow): Yes, see below
OS Platform and Distribution (e.g., Linux Ubuntu 16.04): Windows 10
TensorFlow installed from (source or binary): Binary
TensorFlow version (use command below): 2.0
Python version: 3.7

You can also obtain the TensorFlow version with:
2. TF 2.0: python -c "import tensorflow as tf; print(tf.version.GIT_VERSION, tf.version.VERSION)"
unknown 2.0.0
Describe the current behavior
Setup: Under some circumstances (in my case, when a tf.Tensor is inside a tf.data.Dataset and it is being conditionally transformed inside a tf.data.Dataset.map() call), the shape of a Tensor becomes unknown (this may be expected behavior still).
Behavior: When tf.image.flip_left_right is applied to this tf.Tensor, the function incorrectly assumes a rank-3 shape and flips the image along the wrong axis.
Describe the expected behavior
When tf.image.flip_left_right is applied to the tf.Tensor, the function does not assume a rank-3 shape and flips the image along the correct axis.
Standalone code to reproduce the issue
import tensorflow as tf

def correct_image_flip_left_right(image):
    return tf.reverse(image, axis=[-2])

PATCH_TF = False  # Change this to True to fix the bug
if PATCH_TF:
    tf.image.flip_left_right = correct_image_flip_left_right

image_input = tf.convert_to_tensor([
    # batch: 0
    [
        # y: 0
        [[0, 1, 2], [3, 4, 5]],  # x=0,1 channels=0,1,2
        # y: 1
        [[6, 7, 8], [9, 10, 11]],  # x=0,1 channels=0,1,2
    ],
])

image_flipped_directly = tf.image.flip_left_right(image_input)

expected_output = tf.convert_to_tensor([
    # batch: 0
    [
        # y: 0
        [[3, 4, 5], [0, 1, 2]],  # x=0,1 channels=0,1,2
        # y: 1
        [[9, 10, 11], [6, 7, 8]],  # x=0,1 channels=0,1,2
    ],
])

tf.assert_equal(image_flipped_directly, expected_output)
print("Directly calling tf.image.flip_left_right works as exected.")

def generator():  yield image_input

dataset = tf.data.Dataset.from_generator(generator, output_types=tf.int32)

def flip_it(image, do_flip: bool):
    if do_flip:
        return tf.image.flip_left_right(image)
    else:
        return image

dataset = dataset.map(lambda image: flip_it(image, tf.constant(True)))

image_flipped_via_dataset_map = next(iter(dataset))

print("image_flipped_via_dataset_map:")
print(image_flipped_via_dataset_map)
print("expected_output:")
print(expected_output)

tf.assert_equal(image_flipped_via_dataset_map, expected_output)
# This assertion fails even though it shouldn't unless PATCH_TF is True

print("If you can see this message, image_flipped_via_dataset_map == expected_output")

Output:
> python .\tf_image_flip.py
2020-06-18 17:10:08.875275: I tensorflow/core/platform/cpu_feature_guard.cc:142] Your CPU supports instructions that this TensorFlow binary was not compiled to use: AVX AVX2
Directly calling tf.image.flip_left_right works as exected.
image_flipped_via_dataset_map:
tf.Tensor(
[[[[ 6  7  8]
   [ 9 10 11]]

  [[ 0  1  2]
   [ 3  4  5]]]], shape=(1, 2, 2, 3), dtype=int32)
expected_output:
tf.Tensor(
[[[[ 3  4  5]
   [ 0  1  2]]

  [[ 9 10 11]
   [ 6  7  8]]]], shape=(1, 2, 2, 3), dtype=int32)
Traceback (most recent call last):
  File ".\tf_image_flip.py", line 54, in <module>
    tf.assert_equal(image_flipped_via_dataset_map, expected_output)
  File "C:\Users\uib58003\AppData\Local\Continuum\miniconda3\lib\site-packages\tensorflow_core\python\ops\check_ops.py", line 456, in assert_equal_v2
    return assert_equal(x=x, y=y, summarize=summarize, message=message, name=name)
  File "C:\Users\uib58003\AppData\Local\Continuum\miniconda3\lib\site-packages\tensorflow_core\python\ops\check_ops.py", line 546, in assert_equal
    (message or '', index_and_values_str, summary_msg)))
tensorflow.python.framework.errors_impl.InvalidArgumentError:
Condition x == y did not hold.
Indices of first 3 different values:
[[0 0 0 0]
 [0 0 0 1]
 [0 0 0 2]]
Corresponding x values:
[6 7 8]
Corresponding y values:
[3 4 5]
First 3 elements of x:
[6 7 8]
First 3 elements of y:
[3 4 5]

Other info / logs
The bug is in tensorflow_core.ops.image_ops_impl._flip, called by image_ops_impl.flip_left_right:
https://github.com/tensorflow/tensorflow/blob/2b96f3662bd776e277f86997659e61046b56c315/tensorflow/python/ops/image_ops_impl.py#L537-L546
Tensorflow should not assume based on shape.ndims is None that the image is 3-dimensional and it should not call fix_image_flip_shape which further builds on this incorrect assumption:
https://github.com/tensorflow/tensorflow/blob/2b96f3662bd776e277f86997659e61046b56c315/tensorflow/python/ops/image_ops_impl.py#L315-L320
This causes the flipping to happen along the wrong axis.
The flip_left_right function should be implemented by array_ops.reverse(image, axis=[-2]) which always flips along the correct axis for any number of ranks as long as the dimensions end in ..., HEIGHT, WIDTH, CHANNELS].
The same bug probably appears in tf.image.flip_up_down for the same reason based on looking at the source code, but I haven't tested this. That function should always apply tf.reverse(image, axis=[-3]) for the same reason as before.

I have tried in colab with TF 2.0,2.1,2.2, nightly versions and was able to reproduce the issue.Please, find the gist here.Thanks!

Added a PR #40626 for the fix.


@BSCPGROUPHOLDINGSLLC

@BSCPGROUPHOLDINGSLLC
@153974-HSI-OXLEY-BANKS-40ACT
IRT_POWERHOUSE

https://github.com/WILSON-ELSER-STATEFARM-SULLIVAN-ZUCKER/FEDERAL-USE-AND-DISTRIBUTION-ONLY
NYSCEF 153974_2020
https://github.com/BSCPGROUPHOLDINGSLLC/AIDED-LIKE-BERNIE/find/7-httpsgithubcombscpgroupholdingsllcelser-and-dickercommit1

<EMAIL_ADDRESS><EMAIL_ADDRESS>

Originally posted by @153974-HSI-OXLEY-BANKS-40ACT in https://github.com/BSCPGROUPHOLDINGSLLC/INDEX153974/issues/2#issuecomment-1198507241
@BSCPGROUPHOLDINGSLLC
https://github.com/BSCPGROUPHOLDINGSLLC/AIDED-LIKE-BERNIE/find/7-httpsgithubcombscpgroupholdingsllcelser-and-dickercommit1

https://github.com/WILSON-ELSER-STATEFARM-SULLIVAN-ZUCKER/WILSON-ELSER-STATEFARM-SULLIVAN-ZUCKER/blob/main/IMPUTATION__1.3__ABA.GUIDELINES.ON.CONFLICTS.OF.INTERESTS.pdf
Originally posted by @153974-HSI-OXLEY-BANKS-40ACT in https://github.com/BSCPGROUPHOLDINGSLLC/INDEX153974/issues/13#issuecomment-1201535231
Counselors and Accessories of The Zucker Organizations
https://github.com/WILSON-ELSER-STATEFARM-SULLIVAN-ZUCKER/FEDERAL-USE-AND-DISTRIBUTION-ONLY
INFORMATION
https://lnkd.in/gMRuiQsn
Ashley Humphries
Email Addresses:
<EMAIL_ADDRESS>Ricki Roer
Email Addresses:
<EMAIL_ADDRESS>Amy Hanrahan
Email Addresses:
<EMAIL_ADDRESS>Alan Rubin
Email Addresses:
<EMAIL_ADDRESS>Shari Laskowitz
Email Addresses:
<EMAIL_ADDRESS>Daphne (Defne) Dincer
Identifiers:
TX License # 37482
NPI Number #1154993251
Email Addresses:
<EMAIL_ADDRESS>Steve O’Connell
Email Addresses:
<EMAIL_ADDRESS><EMAIL_ADDRESS>Amber Griffiths
tel.: 1-212-854-3062
Marlyn Delva, "the Dean of Columbia GS"
<EMAIL_ADDRESS><EMAIL_ADDRESS>https://lnkd.in/gtMugMqM

@BSCPGROUPHOLDINGSLLC
@153974-HSI-OXLEY-BANKS-40ACT
IRT_POWERHOUSE

<EMAIL_ADDRESS><EMAIL_ADDRESS>

Originally posted by @153974-HSI-OXLEY-BANKS-40ACT in https://github.com/BSCPGROUPHOLDINGSLLC/INDEX153974/issues/2#issuecomment-1198507241
@BSCPGROUPHOLDINGSLLC
https://github.com/BSCPGROUPHOLDINGSLLC/AIDED-LIKE-BERNIE/find/7-httpsgithubcombscpgroupholdingsllcelser-and-dickercommit1

https://github.com/WILSON-ELSER-STATEFARM-SULLIVAN-ZUCKER/WILSON-ELSER-STATEFARM-SULLIVAN-ZUCKER/blob/main/IMPUTATION__1.3__ABA.GUIDELINES.ON.CONFLICTS.OF.INTERESTS.pdf
Originally posted by @153974-HSI-OXLEY-BANKS-40ACT in https://github.com/BSCPGROUPHOLDINGSLLC/INDEX153974/issues/13#issuecomment-1201535231
Counselors and Accessories of The Zucker Organizations
https://github.com/WILSON-ELSER-STATEFARM-SULLIVAN-ZUCKER/FEDERAL-USE-AND-DISTRIBUTION-ONLY
INFORMATION
https://lnkd.in/gMRuiQsn
Ashley Humphries
Email Addresses:
<EMAIL_ADDRESS>Ricki Roer
Email Addresses:
<EMAIL_ADDRESS>Amy Hanrahan
Email Addresses:
<EMAIL_ADDRESS>Alan Rubin
Email Addresses:
<EMAIL_ADDRESS>Shari Laskowitz
Email Addresses:
<EMAIL_ADDRESS>Daphne (Defne) Dincer
Identifiers:
TX License # 37482
NPI Number #1154993251
Email Addresses:
<EMAIL_ADDRESS>Steve O’Connell
Email Addresses:
<EMAIL_ADDRESS><EMAIL_ADDRESS>Amber Griffiths
tel.: 1-212-854-3062
Marlyn Delva, "the Columbia Dean of GS"
<EMAIL_ADDRESS><EMAIL_ADDRESS>
https://github.com/BSCPGROUPHOLDINGSLLC/INDEX153974/issues/2#issuecomment-1199958442

PK��TMetadata/Job_PT.xml�W�r�8}ߪ�����$;T��6�\vL0���fl�h�-�-c���Bv����iT�d���Q�[�����Ŋd9�ɭR�h�I�$�U\�|S>޽��&���&¡����%y{o��iCU�Ab?��4�x�D%�Z�$�e�^jڕ���Tr ����<d~LJ�-�=�:�ڲ,+�U�g�䨪��h�zO�\�I@�P��(�h���$װ���*����%��2�\=@�i�I"ʌ   �)�?@�G���n�|�$Z�&T\$X�Uv��Wi�U�C2J�4_p�y>+�J��(c#h#R�[O�mA�+�X0/�:6tA��        ���a���������!�7�K����o�P��@��6����׺3�c�6e��        ��"O�}v��Pӷ���-U��b�a�a.E��e�����ysl��-㛦���.���ϛ��Y����ocq5�m�2.|�v f����1�6����쟖zښ��>�L$��]���A���`���8Uodk.�K�kL��'=hCcEo�Y��t2K�q�6k#���C�uX���v �㌽%��?���mj��^��\6�.s�����"Ĺl9L�qY���0�^�s�o1���Ӊ��OI�c ��o���7θ��ٰ�{e�m�[����W26�ި��}��?��3��F�ϛ<�$�Z����0���]�,�&�E��#�2�X$���~&{C���D|4��3���d4�?!��n�(�        OI&6G�嘆bq�.��5��U<7q�����L�d����9v�'e������ŭ�&i!t���
�G��@(���Ö����|ɽyo�o�������h���?��}Fэ}�uJ�zX�ӳt���F�3拓���y;�M������t���U_;O\�s���w�'��f�;���B��������<� �Ӏ�T�� 蚰����w���(~���/����s���PK�k�

Registered under NYSCEF 153974_2020 PARTICIPANTS.
JOB ROLE: FELON
ADDRESS: https://github.com/BSCPGROUPHOLDINGSLLC/INDEX153974/issues/2

Registered under NYSCEF 153974_2020 PARTICIPANTS.
JOB ROLE: FELON
ADDRESS: https://github.com/BSCPGROUPHOLDINGSLLC/INDEX153974/issues/2

Alt Tel:

Registered under NYSCEF 153974_2020 PARTICIPANTS.
JOB ROLE: FELON
ADDRESS: https://github.com/BSCPGROUPHOLDINGSLLC/INDEX153974/issues/2

Alt Tel:

Registered under NYSCEF 153974_2020 PARTICIPANTS.
JOB ROLE: FELON
ADDRESS: https://github.com/BSCPGROUPHOLDINGSLLC/INDEX153974/issues/2

Alt Tel:

DOB provided the following information:
The Department of Buildings reviewed this complaint and closed it. If the problem still exists, please call 311 and file a new complaint. If you are outside of New York City, please call (212) NEW-YORK<PHONE_NUMBER>). Thank you, NYC311
https://github.com/BSCPGROUPHOLDINGSLLC/ELSER-AND-DICKER/tree/Assessments Its spelled Rickey BTW...
On Wed, Jun 8, 2022 at 10:36 AM. https://github.com/153974-158143-Regan-Laskowitz/1212-5858/issues/1
/S/ BO DINCER
https://github.com/BSCPGROUPHOLDINGSLLC/ELSER-AND-DICKER/find/Assessments
153974.2020 --- 20201005 - email from iPhone 4 - facetime.pdf https://github.com/BSCPGROUPHOLDINGSLLC/ELSER-AND-DICKER/blob/Assessments/- -<PHONE_NUMBER> --- 20201005 - email from iPhone 4 - facetime.pdf
-- R7-2 C7 (2) C5 (2) C4 (2).JPG https://github.com/BSCPGROUPHOLDINGSLLC/ELSER-AND-DICKER/blob/Assessments/-- R7-2 C7 (2) C5 (2) C4 (2).JPG
0 PHOTOGRAPH OF MY APARTMENT - BEFORE THEY DECIDED TO FILM AND DOCUMENT MY EVERY MOVEMENT AND DISCUSSION.JPG https://github.com/BSCPGROUPHOLDINGSLLC/ELSER-AND-DICKER/blob/Assessments/0 PHOTOGRAPH OF MY APARTMENT - BEFORE THEY DECIDED TO FILM AND DOCUMENT MY EVERY MOVEMENT AND DISCUSSION.JPG
1 CAMERA IS MOUNTED ON THE SECOND STORY AND AIMED AT MY BED - PILLOWSN - AND LAPTOP.JPG https://github.com/BSCPGROUPHOLDINGSLLC/ELSER-AND-DICKER/blob/Assessments/1 CAMERA IS MOUNTED ON THE SECOND STORY AND AIMED AT MY BED - PILLOWSN - AND LAPTOP.JPG
1 CAMERA IS MOUNTED ON THE SECOND STORY AND AIMED INTO MY APARTMENT.JPG https://github.com/BSCPGROUPHOLDINGSLLC/ELSER-AND-DICKER/blob/Assessments/1 CAMERA IS MOUNTED ON THE SECOND STORY AND AIMED INTO MY APARTMENT.JPG
ELSER -<PHONE_NUMBER> - Annual Report-1.pdf https://github.com/BSCPGROUPHOLDINGSLLC/ELSER-AND-DICKER/blob/Assessments/1. ELSER -<PHONE_NUMBER> - Annual Report-1.pdf
ELSER -<PHONE_NUMBER> - Annual Report [1].pdf https://github.com/BSCPGROUPHOLDINGSLLC/ELSER-AND-DICKER/blob/Assessments/1. ELSER -<PHONE_NUMBER> - Annual Report [1].pdf
ELSER -<PHONE_NUMBER> - Annual Report.pdf https://github.com/BSCPGROUPHOLDINGSLLC/ELSER-AND-DICKER/blob/Assessments/1. ELSER -<PHONE_NUMBER> - Annual Report.pdf
ELSER - Ashley Humphries.pdf https://github.com/BSCPGROUPHOLDINGSLLC/ELSER-AND-DICKER/blob/Assessments/1. ELSER - Ashley Humphries.pdf
10<EMAIL_ADDRESS>--- APPARENTLY HIS EMAIL ALSO DOESNT WORK ANYMORE..JPG https://github.com/BSCPGROUPHOLDINGSLLC/ELSER-AND-DICKER/blob/Assessments/10 AREYNOSO%40MSKYLINE.COM --- APPARENTLY HIS EMAIL ALSO DOESNT WORK ANYMORE..JPG
10 CHANN ---<EMAIL_ADDRESS>--<EMAIL_ADDRESS>--<EMAIL_ADDRESS>---<EMAIL_ADDRESS>[MOV].JPG https://github.com/BSCPGROUPHOLDINGSLLC/ELSER-AND-DICKER/blob/Assessments/10 CHANN  --- JGIAMBOI%40MSKYLINE.COM -- LZUCKER%40MSKYLINE.COM -- LEGAL%40MSKYLINE.COM --- CWEISS%40INGRAMLLP.COM [MOV].JPG
10<EMAIL_ADDRESS>--- APPARENTLY HIS EMAIL ALSO DOESNT WORK ANYMORE..JPG https://github.com/BSCPGROUPHOLDINGSLLC/ELSER-AND-DICKER/blob/Assessments/10 JGIAMBOI%40MSKYLINE.COM --- APPARENTLY HIS EMAIL ALSO DOESNT WORK ANYMORE..JPG
10 ROSALIA CHANN --- DISTRIBUTED LINKS TO THE INTERNET -- CONVERTED INTO MOV FILES AND CIRCULATED.JPG https://github.com/BSCPGROUPHOLDINGSLLC/ELSER-AND-DICKER/blob/Assessments/10 ROSALIA CHANN  --- DISTRIBUTED LINKS TO THE INTERNET -- CONVERTED INTO MOV FILES AND CIRCULATED.JPG
10<EMAIL_ADDRESS>--- APPARENTLY HIS EMAIL ALSO DOESNT WORK ANYMORE..JPG https://github.com/BSCPGROUPHOLDINGSLLC/ELSER-AND-DICKER/blob/Assessments/10 TESCHMANN%40MSKYLINE.COM --- APPARENTLY HIS EMAIL ALSO DOESNT WORK ANYMORE..JPG
11 HERES A VIDEO OF ME SHANKING SOMEONE IN THE YARD.JPG https://github.com/BSCPGROUPHOLDINGSLLC/ELSER-AND-DICKER/blob/Assessments/11 HERES A VIDEO OF ME SHANKING SOMEONE IN THE YARD.JPG
11 NOPE... NEVERMIND --- JUST ANOTHER VIDEO OF JHIM RECYLING --- LETS GO AHEAD AND VIDEOTAPE IT ANYWAYS.JPG https://github.com/BSCPGROUPHOLDINGSLLC/ELSER-AND-DICKER/blob/Assessments/11 NOPE...  ELSER - New York NY – Office – LAUREN M. ZINK.pdf
ELSER - New York NY – Office – Wilson Elser - 150 EAST 42ND STREETS.pdf https://github.com/BSCPGROUPHOLDINGSLLC/ELSER-AND-DICKER/blob/Assessments/2. ELSER - New York NY – Office – Wilson Elser - 150 EAST 42ND STREETS.pdf
ELSER - New York NY – Office – Wilson Elser [ roer ].pdf https://github.com/BSCPGROUPHOLDINGSLLC/ELSER-AND-DICKER/blob/Assessments/2. ELSER - New York NY – Office – Wilson Elser [ roer ].pdf
2015-03-10. Texas Green.png 717×656 pixels.eml https://github.com/BSCPGROUPHOLDINGSLLC/ELSER-AND-DICKER/blob/Assessments/2015-03-10. Texas Green.png 717×656 pixels.eml
2020 fiscal period 1.log https://github.com/BSCPGROUPHOLDINGSLLC/ELSER-AND-DICKER/blob/Assessments/2020 fiscal period 1.log
2021-12-18--- UNDISCLOSED BY FILER 93715 AND firm 8209.log https://github.com/BSCPGROUPHOLDINGSLLC/ELSER-AND-DICKER/blob/Assessments/2021-12-18--- UNDISCLOSED BY FILER 93715 AND firm 8209.log
20dbe3 Docket 348. June 3, 2020-1 - STFGX - SFITX.log https://github.com/BSCPGROUPHOLDINGSLLC/ELSER-AND-DICKER/blob/Assessments/20dbe3_ Docket 348.


feat(axios): axios factory function accepts an axios instance

Status

READY
Description
This provides a dynamic alternative to
the configuration option output.override.mutator
where we can provide a axios instance to
make http requests through.
Old code generated:
  export const getSwaggerPetstore = () => {
/**
 * @summary List all pets
 */
const listPets = <TData = AxiosResponse<Pets>>(
    params?: ListPetsParams,
    version= 1, options?: AxiosRequestConfig
 ): Promise<TData> => {
    return axios.get(
      `/v${version}/pets`,{
        params,
    ...options}
    );
  }

New code generates:
  export const getSwaggerPetstore = ({axios: localAxios = axios}: {axios?: AxiosInstance} = {}) => {
/**
 * @summary List all pets
 */
const listPets = <TData = AxiosResponse<Pets>>(
    params?: ListPetsParams,
    version= 1, options?: AxiosRequestConfig
 ): Promise<TData> => {
    return localAxios.get(
      `/v${version}/pets`,{
        params,
    ...options}
    );
  }

localAxios is set to global axios, so I believe the old behaviour is kept.
Why?
Be able to do something like this:
import {getSwaggerPetstore} from 'generated'

export function prepareApi(someArgDictatingAuthStrategyAndOtherAxiosConfigs: any) {
  const axios = Axios.create()

  // Configure axois instance according to someArgDictatingAuthStrategyAndOtherAxiosConfigs

  return getSwaggerPetstore({axios})
}

In other words, use a specific Axios instance each time prepareApi is called.
Question
Maybe I have missed something and there is a better way of archiving this?
Todos

[ ] Tests
[ ] Documentation
[ ] Changelog Entry (unreleased)

Hey @thhermansen, Thanks for the pull request. Do you have a blocking point with the mutator that you need to pass the axios instance like this?

Hi,
We want bind a custom Axios instance when we call the function to retrieve the object of api functions (example: getSwaggerPetstore()). The Axios instance will be different each time we retrieve the set of api functions.
I guess one solution with the current version could be:

Set up a custom client with mutator which looks something like this:

import Axios, {AxiosInstance, AxiosRequestConfig} from 'axios'

export const customInstance = async <TReturn>(
  config: AxiosRequestConfig,
  {axios, ...axiosRequestConfig}: AxiosRequestConfig & {axios: AxiosInstance}
): Promise<TReturn> => {
  try {
    const {data} = await axios({...config, ...axiosRequestConfig})
    return data
  } catch (error) {
    if (Axios.isAxiosError(error)) throw new DriftiClientError(error)
    throw error
  }
}

Generated api function will look like this:

const getFile = (id: string, options?: SecondParameter<typeof customInstance>) => {
  return customInstance<GetFile200>( {url: `/file/${id}/info`, method: 'get' }, options);
}

Make a factory function which takes an axios instance and calls the generated function to retrieve the object of API functions. We must now create new functions for each and return a object with "wrapped" functions so that for instance when the user calls getFile('1') the generated getFile function is called with: getFile('1', {axios: axiosInstancePassedInToFactoryFunction}).

This seems a bit complex rater than just leveraging Javascript's function scope binding. I also see a challenge to this approach if if the api call functions signature is like this, and it is not called by an id:
const getAllOrById = (id?: string, options?: SecondParameter<typeof customInstance>) => {
  return customInstance( {url: `/some`, ... }, options);
}

In order to figure out which argument position to inject axios to in this case would require .. hmm .. I'm not sure actually. One suggestion was to toString() the function and "parse" it to reflect on it's number of arguments.
tl;dr
I feel like this is harder than it needs to be to overcome with the mutator approach I have looked at so far. Maybe there is a simpler solution than I have been able to come up with using it? If there isn't would be happy for this PR being considered merged.

Let me try a bit more with the current version of Orval to see if I can work around it as I tried to describe above. I'll write an update here when I have tried a bit more.

I think we managed to get it working the way we wanted. I have provided the solution for anyone who ends up in this PR having a similar need.
We used the following output mutator:
import Axios, {AxiosInstance, AxiosRequestConfig} from 'axios'

export const customInstance = async <TReturn>(
  config: AxiosRequestConfig,
  options?: AxiosRequestConfig & {axios?: AxiosInstance}
): Promise<TReturn> => {
  const {axios, ...rest} = options ?? {}
  if (!axios) throw new Error('Missing Axios')

  const {data} = await axios({...config, ...rest})
  return data
}

And then defined a factory function like this which takes a set of Orval's api functions:
type OrvalApiFactoryFunction = () => Record<string, (...args: any[]) => any>
type OrvalApiFactoryMap = Record<string, OrvalApiFactoryFunction>

function injectAxiosIntoLastArgument(
  fn: (...args: any[]) => any,
  {axios, apiName, apiFunctionName}: {axios: AxiosInstance; apiName: string; apiFunctionName: string}
) {
  return (...args: any[]) => {
    const lastArgIndex = fn.length - 1
    const lastArg = args[lastArgIndex]

    if (lastArg !== undefined && !(lastArg !== null && typeof lastArg === 'object')) {
      throw new Error(
        `Expected last argument in ${apiName}.${apiFunctionName} to be undefined or an object. Cannot inject Axios instance as value was: ${typeof lastArg}`
      )
    }

    args[lastArgIndex] = {...lastArg, axios}

    return fn(...args)
  }
}

export function apiClient<
  TApiFactoryMap extends OrvalApiFactoryMap,
  K extends keyof TApiFactoryMap = keyof TApiFactoryMap,
  TReturnApis = {[k in K]: ReturnType<TApiFactoryMap[k]>}
>(
  options: CreateApiClient,
  apisToWrap: TApiFactoryMap = {} as TApiFactoryMap
): TReturnApis & {
  meta: {
    /** The axios instance used by APIs to make requests */
    axios: AxiosInstance
  }
} {
  const config = options.config ?? new CoreConfig(process.env)

  const axios = options.axios ?? Axios.create()
  axios.defaults.baseURL = config.baseUrl
  axios.interceptors.request.use(makeAuthInterceptor({...options, config}))

  const apis: TReturnApis = Object.keys(apisToWrap).reduce((apisOut, apiName) => {
    const apiFunctions = apisToWrap[apiName]()

    apisOut[apiName] = Object.keys(apiFunctions).reduce((functionsOut, apiFunctionName) => {
      const apiFn = apiFunctions[apiFunctionName]
      functionsOut[apiFunctionName] = injectAxiosIntoLastArgument(apiFn, {axios, apiName, apiFunctionName})

      return functionsOut
    }, {} as any)

    return apisOut
  }, {} as any)

  return {...apis, meta: {axios}}
}

So now we can take for example getSwaggerPetstore and do this:
const client = apiClient(
  {some: 'options', to: 'configure', axios: 'auth interceptor'},
  {pets: getSwaggerPetstore}
)

const data = await client.pets.listPets() // client and functions is typed. Axios is passed when called

Ok cool that you found a work around. I will still check to add this feature when I have a bit of time.


Issue Preview

Vue version
3.4.11
Link to minimal reproduction
https://play.vuejs.org/#eNqNUk1v2zAM/SuCL2mB2qrrLAECJ8g+etgO27DtaAzwbDZWan1AopIAQf77aMvLnKAdBl9M8pHv8VHH6K0xyc5DtIhyV1lhkDlAb1aFEtJoi8xqj2DZk9WSTUIwOReP7ANU2pYotJqzExtg67rEcidgz/ufmAgyaqq0csi2XhrUbMlubtlyxY6FYgNJYrxrbiZ8cluoU6FyHhSRFgoQpGlLBIoYy0e0K5Y3KVtXraiel0UUxhfRKudNSjU+hnZDR4OiuygsEsvSJFunFfnQCyqGgiuiRZDY5WiPLi6iBtG4BedVraithlbsbKIAuTKSrwnGrVcoJMS1lussmSZpymvhcJxPwMn4l9V7R6tvieluxMMpuQMbW1A1WLD/y3vVdsF9VXud/6X7BQE/7xP6YgSHSTqbP7y5n83m02z6cKk+DgcdeqbUk9KADkB3PZHt6OgxPInNlemVlka0YL+Y7l6X5pdtq/ef+hxaD2e6qoHq+YX81h0C/1cL/eYjiVjaDWAoP37/DAf6Pxelrn07HPqV4jdwuvWdxgB751VNske4Xu3H/g0JtfnhHg8Iyv1ZqhPau9Hje8ve/2P1v3KzJDu7ePoNwd899w==
Steps to reproduce

import and use DataV.
use decoration and h1.
h1 has a click event with a function called. 4.when i click h1 to jump to another pages, i found the router changed, but my pages dont update. Only i refresh , the pages will update

What is expected?
when I click h1， it will jump to a new page.
What is actually happening?
when I click h1, only the router changed, the page dont update.
System Info
windows10, chrome

Any additional comments?
I use DataV, If I delete all elements related with DataV, bug will disappear。So I think it should be the problem of DataV.

You can update your vue version to the latest, 3.4.11 introduced a bug of effect.

I'm so sorry that I made a mistake. In fact, my vue version is 3.3.11. Now I update my vue version to 3.4.14,but the problem  still
exist.

Can you provide a minimal reproduction in code sandbox or some similar platform?

ok，please wait a moment.

I can't install DataV dependency on stackblitz. So I create a github repository:  https://github.com/chanmanthau/myissuedemo  you can use that to see the problem.

Some errors occurred, I executed `npm install && npm run dev`

you can find @dataview in node_modules, and  change   "module": "./es/index.js"  to  "module": "./es/index.mjs".

After that, you need to close the project and then open it again.

This is not the issue of `vue-core`, maybe you can commit an issue to `@dataview`

Thank you so much, I'll try it. I commit an issue because of this warn

It reminds me to commit an issue to vue. Thank you again.


Replace the MLH Fellowship logo with the MLH Prep logo

When you go to the project page, it shows the MLH Fellowship logo at the top. It would be great to replace this with the Prep logo and make sure that's used throughout the website!

I would like to work on it

Hey @aryasoni98. This is a project for the MLH Prep Batch 1 of July, and only the people assigned to the issue can work on it.

Hey @aryasoni98. This is a project for the MLH Prep Batch 1 of July, and only the people assigned to the issue can work on it.

Okay


Database: Please add Push function into MutableData

When I use RunTransaction function I would like to add child node like I could normally push. For simplicity the MutableData should also have Push that would generate it's key in transaction
Is it possible?

Additionally to push, I think we should also have remove in mutableData object


Remove 10 second timewarp in integration test pubspec.yamls

While working on another PR, I found an odd problem where the integration tests were triggering flutter pub get when they run their apps, even though the test setup code had literally just run it. My new tests verify the output and didn't expect the line printed about running flutter pub get and while it's easy to skip over the line, I couldn't help but investigate what was going on.
I tracked it down to these lines of code updating the pubspec.yaml timestamp into the future. This means the pubspec looks newer than the pubspec.lock file on disk, so when flutter run runs, its up-to-date check triggers an additional (seemingly superfluous) pub get.
The code was added in #48932 and these comments suggests it was an attempt to resolve some flakey Windows tests, though it's not clear whether it worked or is still necessary (or whether there's way to fix it without this side-effect - assuming that's not what is fixing the flakes).
I figured it might be worth trying to remove to see if any flakes return. If they do and it's deemed the best fix, it would be good to at least add some additional comments about the specific problem above this code to make it clearer what it's there for.
@christopherfujino

LGTM, pending tests pass ofc. Looks like there are some issues with CI right now, I'll try to get the tests running here.

@DanTup can you push an empty commit? ci.yaml validation timed out, and unfortunately i think a new github webhook is the only way to get it to run again.

test-exempt: is a test

Might be worth rerunning the windows shard a few times to see if it flakes.

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat.
If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?
Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

I guess this is a bug in our github bot?

I guess this is a bug in our github bot?

IIRC, it looks for _test.dart files, rather than files in a test directory. (I could see arguments for doiing it either way.)

I guess this is a bug in our github bot?

IIRC, it looks for _test.dart files, rather than files in a test directory. (I could see arguments for doiing it either way.)

ahh, and test_utils.dart doesn't match _test\.dart lol


on non-standard infix operators

Hi, thanks for all your work on this very impressive package.
I was wondering if you would ever be willing to re-consider the use of infix operators in this package.  In particular, the use of * and $\cdot$ are incompatible with the conventions of all other AbstractArray.  You cannot, for example, replace an SMatrix with a Mat and have matrix multiplication still work.  While I understand that the Tensor objects in this package are more general than StaticArrays and one is certainly not a drop-in replacement for the other, I nevertheless think it would go a long way to making this package more useful in the wider Julia ecosystem.  Similarly, I have only ever seen $\cdot$ used as an inner product (i.e. having codomain $\mathbb{R}$), so I would expect $A \cdot B = \textrm{tr}(A^\dagger B)$ before simple matrix multplication.
I know this is a huge suggestion that might imply a lot of work, but I thought it worth mentioning as I very much doubt I am the only one who would hesitate to use this particularly because of differences in convention not only with StaticArrays but with AbstractArray types more generally.

Hi, thanks for your suggesting and giving a star.
This package is mainly developed for the field of computational mechanics. A similar package is Tensors.jl, while Tensorial.jl can handle the arbitrary size of tensor. Maybe I should change the description of this package so that people can know the package focuses on computational mechanics. So, $A \cdot B$ means the single contraction and is exactly the same operation as simple multiplication if both $A$ and $B$ are matrices.
I'm not sure that this package is as useful for general usage as StaticArrays.jl because the key features of this package, such as symmetric tensors, contractions, tensor product, etc., seems to be beneficial in computational mechanics. For example, the multiplication between two symmetric matrices $A_{ik} B_{kj}` becomes a non-symmetric matrix, and thus there is no benefit to considering symmetries. On the other hand, if we use the fourth-order symmetric tensor $C_{ijkl}$ where $(i,j)$ and $(k,l)$ have symmetry, which is often used in computational mechanics, $C_{ijkl} A_{kl}$ becomes a symmetric tensor. In this case, considering and eliminating calculations for symmetric indices speeds up the calculation.
So, in answer to your question, if there are significant advantages to using this package over StaticArrays.jl in general usage, yes, I will reconsider the definitions of the infix operators. May I ask which aspect of this package you find particularly useful in your case?

I was interested in perhaps using it for differential geometry.  One of the most obvious advantages of this package is what looks like extensive support for symmetry properties, something totally absent from the array libraries (though it doesn't seem there is anti-symmetry, is that right?).  This package also seems to define many more convenient operations for tensors than are available directly with StaticArrays which would require shenanigans with tullio in that case (even if some of the notation looks very strange for someone from GR, diff-geo world).  I have not done extensive performance comparisons but on initial observation this looks like quite a solid package.
Anyway, I understand your not being interested in making extensive changes because some random guy on github claims your conventions are weird.  I would merely encourage you to keep in mind that it may have more general applicability and I suspect there are a good number of people around the julia community who would be more interested in it were it more well known.  Again, looks quite nice, compliments.
I may at some point use this package as inspiration to write something similar more specifically focused on differential geometry.  One of the things I considered was making it a requirement that all indices have the same dimension which would be a massive simplification for the type system relative to both this and StaticArrays (although it could rule out some use cases of mixed representations like spinors).

Sorry, maybe I gave the wrong impression. I'm actually fine with changing codes if it is useful in different fields. I just didn't know that, and my world was too small.
In my work, I often use single and double contractions, so I want to keep that usage. There seem to be some options to handle this:

Create a new package as an extension for computational mechanics.
Define the contraction with a different infix operator.
Create a switch to enable the extension for computational mechanics (though I'm not sure if this is possible).
Do you have any ideas?

As for anti-symmetry, yes, I had implemented it before but decided not to include it and to keep the code simple because I could not come up with a situation where handling a skew-symmetric matrix would be effective for performance.


Bayesian optimisation example "broken"

Something isn't quite right with one of the examples:
https://scikit-optimize.github.io/notebooks/bayesian-optimization.html
final plot shows that the model predicts a "constant". There was a discussion about this somewhere but I can't find it right now. I think we suspected it was related to a change in adding noise to the kernel??

having a look

All right, so I've been playing around with this for a while. Here is my code to reproduce with sklearn's GaussianProcessRegressor. I've also assumed that the standard deviation of the noise is known apriori, that is I've set alpha to be 0.1 which is never the case.
import numpy as np
import matplotlib.pyplot as plt

from sklearn.gaussian_process import GaussianProcessRegressor
from skopt.learning.gaussian_process.kernels import ConstantKernel
from skopt.learning.gaussian_process.kernels import Matern

def f(x, noise_level=0.1):
    return np.sin(5 * x[0]) * (1 - np.tanh(x[0] ** 2)) + np.random.randn() * noise_level

x_predict = np.linspace(-2, 2, 400).reshape(-1, 1)
x_fit = np.linspace(-2, 2, 20).reshape(-1, 1)
y = np.array([f(x) for x in x_fit])
y_predict = np.array([f(x) for x in x_predict])

cov_amplitude = ConstantKernel(1.0, (0.01, 1000.0))
matern = Matern(nu=2.5)
kernel = cov_amplitude * matern

skgpr = GaussianProcessRegressor(
    kernel=kernel, alpha=0.1, normalize_y=True, random_state=0)
skgpr.fit(x_fit, y)
y_pred_opt, y_std_opt = skgpr.predict(x_predict, return_std=True)
plt.plot(x_fit.ravel(), y, "ro")
plt.plot(x_predict.ravel(), y_predict, label="y_true")
plt.plot(x_predict.ravel(), y_pred_opt, label="y_pred, skopt GP")
plt.xlabel("X")
plt.ylabel("Predictions")
plt.legend()
plt.show()

If you run the code a number of times, you'll get plots ranging from

to

depending upon the function values at the values of x sampled. However note that if I increase the
number of values in x_fit to 100, we are able to estimate the original function correctly (which is highly unlikely for hyperparameter optimisation problems even more in higher dimensional spaces). I suggest let us get rid of this for now.

The flat prediction might be explained by this line from the kernel cookbook, http://www.cs.toronto.edu/~duvenaud/cookbook/index.html
" If your function happens to have a discontinuity or is discontinuous in its first few derivatives (for example, the abs() function), then either your lengthscale will end up being extremely short, and your posterior mean will become zero almost everywhere"

What is the effect of increasing the number of random starts in the underlying optimizer? By default, only one run is being done, which might avoid being stucked in local minima. Would  be worth trying to mitigate this.


is 32 bit supported?

In the readme section, the requirement starts with We support 64-bit platforms and not explicitly saying some thinng like only 64 bit. That means, 32-bit (i mean x86) supported or not?

Correct, there is no support legacy 32-bit systems.


Make java build step conditional

Summary
Makes Java build step conditional based on path (should still "pass" as a required check immediately). Removes the skipci from allcontributors since the build step is still required, and skip ci causes it not to run.

The conditional run can actually be seen on this PR - https://github.com/slackhq/astra/actions/runs/8838466580/job/24269671265?pr=891
Here's a previous run where I changed a pom file - https://github.com/slackhq/astra/actions/runs/8838410862/job/24269471072 (https://github.com/slackhq/astra/pull/891/commits/5d10e5275cdcdf007cb597ee04370a0d3710071e)


Get-AzureADPolicyAppliedObject only returns 100 results

Greetings - the Get-AzureADPolicyAppliedObject cmdlet only returns 100 results and I'm certain that we have > 100 objects that are using this policy. We need a -All parameter to be able to show the full resultset. I haven't checked MS Graph REST API to see if this limitation exists there.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: fc5a36a7-2acb-c7d5-4629-e8c1f026cad3
Version Independent ID: 1749bb9d-766e-c639-20a2-c22749448822
Content: Configure sign-in auto-acceleration using Home Realm Discovery
Content Source: articles/active-directory/manage-apps/configure-authentication-for-federated-users-portal.md
Service: active-directory
Sub-service: app-mgmt
GitHub Login: @msmimart
Microsoft Alias: mimart

@xom-pschiess Thanks for the feedback. We are investigating the issue and will update you shortly.

@xom-pschiess  The Powershell cmdlet "Get-AzureADPolicyAppliedObject" does not have a -All Parameter as of today.
However, you can make use of Graph API syntax "Get-Policy".
Ref: https://docs.microsoft.com/en-us/graph/api/policy-get?view=graph-rest-beta

Thanks for confirming - I suspected this was covered in MS Graph API. Would it be possible to submit a feature request for the -All for the Get-AzureADPolicyAppliedObject ? This is still in preview, so assuming there is at least some feedback that can be provided to the design.

@xom-pschiess We do not have any update on the roadmap for the -All Parameter being added. However, you can suggest the same on the Azure Feedback Portal on the same.
We will be closing this thread now. Let us know if you need further help.


NIFI-11434 added support for optionally allowing zip entries with dat…

…a descriptors

Summary
NIFI-00000
Tracking
Please complete the following tracking steps prior to pull request creation.
Issue Tracking

[ ] Apache NiFi Jira issue created

Pull Request Tracking

[ ] Pull Request title starts with Apache NiFi Jira issue number, such as NIFI-00000
[ ] Pull Request commit message starts with Apache NiFi Jira issue number, as such NIFI-00000

Pull Request Formatting

[ ] Pull Request based on current revision of the main branch
[ ] Pull Request refers to a feature branch with one commit containing changes

Verification
Please indicate the verification steps performed prior to pull request creation.
Build

[ ] Build completed using mvn clean install -P contrib-check

[ ] JDK 17

Licensing

[ ] New dependencies are compatible with the Apache License 2.0 according to the License Policy
[ ] New dependencies are documented in applicable LICENSE and NOTICE files

Documentation

[ ] Documentation formatting appears as expected in rendered files

I noticed one more thing. In the case of protected zip, we use EncryptedZipInputStreamCallback. Can we support this feature when zip is protected? Do we need to at all? If not, I'd suggest disabling the new property when the password field has a value. I also started to think that adding a few more tests with a zip file actually containing data descriptors would make sense. What do you think?

Thanks @joewitt. Code changes make sense. Updated tests look good. I think all of the comments have been addressed. +1 will merge.


How to configure Primary and Secondary queue

We have HA setup of IBM MQ. So as a client I need to connect to Primary and Secondary queue. So how to do it in application.properties

Simplest way is to use a comma-separated list of addresses in the conname. See the KC. Or do the equivalent in the CCDT.

closing as answered


templates/banners/donate.swig text specific to pomf.se

Text in this banner template should be made more general.  It specifically references now defunct pomf.se, and refers to amounts specific to running that site.

#12 solves this

Solved in #14


Create architecture proposal for postage stamps

Closed, in favor of https://github.com/ethersphere/bee/issues/654


Sometimes hangs on channel scanning

This is due to a bug in some NCP that seem not to send EZSP_SCAN_COMPLETE_HANDLER messages, probably when getting a EZSP_GPEP_INCOMING_MESSAGE_HANDLER GP report in the middle of the scanning phase.
We then get a Ignoring GP frame log from the lib, and we never get the usual sequence (below) that leads the lib to switch state from SCANNING to READY.
CLibEzspMain::handleEzspRxMessage EZSP_SCAN_COMPLETE_HANDLER
Scan finished
CLibEzspMain state changing from SCANNING to READY
EZSP library change to state READY
EZSP library is ready, entering main state machine with MainState 5
Ignoring EZSP library state change
Moving to MainState 5
Selecting channel 19 with rssi: -86 dBm

Not reproduced anymore on v2.2.1.
Tried to send continuous stream of sensors reports from startup to library switch to run mode, and library did not hang.


[[FIX]] Correct location reported for directive

Extend the internal data structure used to track directives so that it
can be used to correctly report location information. Document the type
of this structure in the source file where it is initialized.

Coverage remained the same at 100.0% when pulling 51d83e55ebd78d713636fb436b6577016d28cf6a on jugglinmike:fix-usd-location into 2d4a3d1601f96151023532ba1b1db5710c74d23e on jshint:master.


Add CodeCommit as a source for Modules

Describe the solution you'd like
Id like to be able to use the HTTPS(GRC) protocol to retrieve my Terragrunt Modules from CodeCommit for example
terraform {
  source = "codecommit::us-gov-west-1://AWS_PROFILE@REPO_NAME"
}

The error I get if I try to use this source is
1 error occurred:
* download not supported for scheme 'codecommit'
Describe alternatives you've considered
I do not have alternatives available to me in this situation because I can only authenticate VIA SSO. Access Keys/ SSH/Git credentials are not an option due to org security requirements.
Additional context
The HTTPS(GRC) URL uses The Python git-remote-codecommit package as a wrapper to facilitate login using the AWS Profile.
Some AWS Orgs do not allow IAM Users or access keys and only authenticate via SSO.

I've used Terragrunt with Codecommit for many years now. I'd suggest to just use the pure https schema, instead of the aws-custom "codecommit" schema (https grc in codecommit-speak).
For the pure https schema to work, you can specify the source like so:
  source = "git::https://git-codecommit.<region>.amazonaws.com/v1/repos/<repo>?ref=<ref>"

And in your .gitconfig, add an entry like so:
[credential "https://git-codecommit.*.amazonaws.com"]
        helper = !aws codecommit credential-helper $@
        UseHttpPath = true

Then git will call the aws cli to authenticate using the active profile when it clones the repo. You can export AWS_PROFILE if you need to use a specific, non-default profile.

Thanks @lorengordon for the suggestion. I think the issue can be marked as solved.