Introduce with_range on Parser

This PR introduces a new constructor for Parser, similar to the existing fn from_ref but taking a range to initialize the parser on a subset of the octets.
It currently errors when the end of the passed range lies beyond the end of the octets, meaning passing in an open-ended range (n..) is not possible. Alternatively, we could accept any (open) end and limit it to the length of the octets, and not returning any error.

Something like this seems to work. But if we really want to support this it might be cleaner to add fn from_ref_range_from() and fn from_ref_range_to() taking a RangeFrom / RangeTo, respectively.
pub fn from_ref_with_range<R>(
    octets: &'a Octs,
    range: R
) -> Result<Self, ShortInput>
where
    Octs: AsRef<[u8]>,
    R: core::ops::RangeBounds<usize>
{
    use std::ops::Bound;
    let octets_len = octets.as_ref().len();

    let pos = match range.start_bound() {
        Bound::Unbounded => 0,
        Bound::Included(n) => {
            if *n - 1 > octets_len {
                octets_len
            } else {
                *n
            }
        }
        Bound::Excluded(_) => unreachable!() // not a thing for the
                                             // start_bound, right?
    };

    let len = match range.end_bound() {
        Bound::Unbounded => octets_len,
        Bound::Excluded(n) => {
            if *n > octets_len {
                octets_len
            } else {
                *n
            }
        }
        Bound::Included(n) => {
            if (n - 1) > octets_len {
                octets_len
            } else {
                n - 1
            }
        }
    };

    let len = if len < pos {
        pos
    } else {
        len
    };

    Ok(
        Parser {
            pos,
            len,
            octets
        }
    )
}

I’d probably just call the function with_range.

I wonder if it should just panic if the range is outside the octets’ full range. The use case for the function typically is where you store the range to make a parser on the fly later, so you usually have checked already. And most things that take a range on slices do panic as well, so this may even be consistent.

That sounds good, I'll adapt it and rename the fn as well.

I guess this happened partly because that's what was there in my vim buffer after a lot of undo-ing, but I also thought it sort of made sense to force to be exact (i.e. an ended Range and not a possibly open-ended RangeBounds). When you are working with a Parser on a stream-like bunch of octets, you might have no idea whether there is stuff before the message you are parsing, or stuff beyond the end of that message. So allowing open-ended ranges sound like a bit of a foot gun?

I think there are legitimate use cases for using open ranges. For instance, if you want to split a sequence in two, only remembering the mid point and then use open ranges when creating parsers rather than doing some extra maths to get to the full ranges is probably safer.
So, I think allowing all kinds ranges is probably better.

There we go. It does allow ranges such as 2..=1 (equivalent to 2..2 producing a parser with 0 remaining octets), which feel strange to me because such range looks like it is decreasing. But this actually in line with e.g. slice indexing in the standard library.

I think this would benefit from a bunch of tests, especially for the corner cases.

Tests, definitely.
With regards to len, that always points to what we call the 'end' of the Parser if I'm not mistaking. Should that be renamed?

Oh, you are right. Fooled myself there, apparently. Renaming it to end is probably a wise move, indeed. (By the looks of it, the code itself tries to avoid using it directly and uses remaining instead.)

Fixes for your comments pushed, unit tests coming up.
And then let's do the renaming of len in a separate PR once we're happy with this one.


Keyboard navigation between developer tools and vs code window

When the chromium developer tools inside visual studio code are open, it is not possible to navigate between the tools and the window of VS Code. I"m not sure how this is done visually, but it might help to add them to the F6 sequence or provide another sequence to switch between the two. I think this  could be really helpful for keyboard dependent users to inspect the DOM tree for accessibility feedback.
Cc @isidorn

@leonardder good point. Though this should be handled by chrome, there should be a keyboard shortcut to close the dev tools.
Unfortunetly we can not integrate F6 to take into account dev tools
@deepak1556 @bpasero do you know of a keybaord shortcut to quit chrome dev tools on Windows? I tried and could not find one.

@isidorn see https://github.com/microsoft/vscode/blob/ff118340b561fea6184172ffaf3bbf859b21055b/src/vs/workbench/electron-browser/actions/developerActions.ts#L13-L29

@bpasero that toggles developer tools from vscode. But can not do it while the focus is in the chrome dev tools, or am I missing something?

Hm I think CtrlCmd+Shift+I always works?

@bpasero just tried that and it does not work both on macOS and Win.

F12 it is.

I'm neither able to escape from them with ctrl+shift+i nor f12 on Windows

Yeah also does not work for me.

Maybe open shortcuts panel in devtools to find out more:

@bpasero thanks
Ok so looked a bit more, and we only assign the keybdinig when running out of source.
@leonardder thus I suggest the following: File > preferences > keyboard shortucts
Find the command "Developer: Toggle Developer Tools" and invoke context menu -> change when clause
Delete the when  caluse to be empty.
Now you will be able to simply Ctrl+Shift+I to toggle it.
Thus closing this as I think this solution might be ok for now.


Don't build tests on Run & Analyze

Carthage fails to build the SwiftCheck-iOS target with the error module 'SwiftCheck' was not compiled for testing. I believe they best way to fix this is not build the test target for Run & Analyze actions. This is consistent with the configuration on the Mac & watchOS schemes.

Sorry, tvOS. The other other OS.

So this passes carthage build --no-skip-current?

Finally had a chance to run this locally.  Thanks so much for the fix! :sparkles:
I'm going to try and get the build scripts working with carthage so this doesn't happen ever again then put out a new point release.

:boat:

Glad to help, thanks.


initial scorecard2 kuttl user facing doc

Description of the change:
this PR holds the scorecard2 'kuttl' documentation that would live on the website under the scorecard area.  This
doc describes to end users of the scorecard how the kuttl tests are set up within the scorecard config and provides
links to relevant kuttl website docs for reference.
Motivation for the change:
part of the scorecard kuttl implementation that is on-going.

/lgtm


network with output dims [ 1 ] ,  how to define config.pbtxt output field

Description
A clear and concise description of what the bug is.
TRTIS Information
What version of TRTIS are you using?
Are you using the TRTIS container or did you build it yourself?
To Reproduce
Steps to reproduce the behavior:
Expected behavior
A clear and concise description of what you expected to happen.

There are several examples of creating a config.pbtxt that you can see by following the quickstart. Also you can use --strict-model-config=false to have TRTIS generate the config.pbtxt for you for some type of model frameworks. Let us know if there is some specific issue you are having.


Demo profile has wrong HPA or CPU settings

To repro: install istio using the pre-rendered demo profile
The result is pilot, policy, ingress, egress (but surprisingly not telemetry) all running with 5 replicas.
Expected 1 replica.
Reason: each is set with 0.1 CPU requirements, and with HPA with max 5 and 80%.
The demo profile should have HPA off ( max to 1 ) - we need to keep the low CPU requirements
so it can be used in single-node or very small clusters ( kind, etc ).
This probably needs to be backported to a 1.2.x release.
[ ] Configuration Infrastructure
[ ] Docs
[ ] Installation
[ ] Networking
[ ] Performance and Scalability
[ ] Policies and Telemetry
[ ] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure
Expected behavior
Steps to reproduce the bug
Version (include the output of istioctl version --remote and kubectl version)
How was Istio installed?
Environment where bug was observed (cloud vendor, OS, etc)
Additionally, please consider attaching a cluster state archive by attaching
the dump file to this issue.

@fpesce
@duderino

 kubectl apply -f istio-1.2.2/install/kubernetes/istio-demo.yaml
results in
kubectl -n istio-system get po
NAME                                     READY   STATUS    RESTARTS   AGE
grafana-7869478fc5-sjmt4                 1/1     Running   0          20h
istio-citadel-d6d7fff64-hwwdw            1/1     Running   0          20h
istio-egressgateway-d5cc88b7b-4k64m      1/1     Running   0          20h
istio-egressgateway-d5cc88b7b-5x7kq      1/1     Running   0          20h
istio-egressgateway-d5cc88b7b-7jqf4      1/1     Running   0          20h
istio-egressgateway-d5cc88b7b-hcs2k      1/1     Running   0          20h
istio-egressgateway-d5cc88b7b-hpcfq      1/1     Running   0          20h
istio-galley-545fdc5749-2xqnl            1/1     Running   0          20h
istio-ingressgateway-6d9db74868-dcxpb    1/1     Running   0          20h
istio-ingressgateway-6d9db74868-fxkxj    1/1     Running   0          20h
istio-ingressgateway-6d9db74868-hcsxn    1/1     Running   0          20h
istio-ingressgateway-6d9db74868-mvlr2    1/1     Running   0          20h
istio-ingressgateway-6d9db74868-xt2ck    1/1     Running   0          20h
istio-pilot-69f969cd6f-929lr             2/2     Running   0          20h
istio-pilot-69f969cd6f-jmmbb             2/2     Running   0          20h
istio-pilot-69f969cd6f-n5wk7             2/2     Running   0          20h
istio-pilot-69f969cd6f-sqp6w             2/2     Running   0          20h
istio-pilot-69f969cd6f-t676w             2/2     Running   0          20h
istio-policy-68c868b65c-6mgdt            2/2     Running   0          20h
istio-policy-68c868b65c-bcblj            2/2     Running   0          20h
istio-policy-68c868b65c-gvkgz            2/2     Running   2          20h
istio-policy-68c868b65c-tjvzk            2/2     Running   0          20h
istio-policy-68c868b65c-xpkgr            2/2     Running   0          20h
istio-sidecar-injector-68bf9645b-kkqbf   1/1     Running   0          20h
istio-telemetry-9c9688fb-26tm5           2/2     Running   2          20h
istio-tracing-79db5954f-mz8hl            1/1     Running   0          20h
kiali-7b5b867f8-5t66l                    1/1     Running   0          20h
prometheus-5b48f5d49-b7dpr               1/1     Running   0          20h

Also
kubectl -n istio-system top pod
NAME                                     CPU(cores)   MEMORY(bytes)
grafana-7869478fc5-sjmt4                 4m           43Mi
istio-citadel-d6d7fff64-hwwdw            4m           25Mi
istio-egressgateway-d5cc88b7b-4k64m      17m          71Mi
istio-egressgateway-d5cc88b7b-5x7kq      14m          73Mi
istio-egressgateway-d5cc88b7b-7jqf4      15m          73Mi
istio-egressgateway-d5cc88b7b-hcs2k      16m          71Mi
istio-egressgateway-d5cc88b7b-hpcfq      15m          72Mi
istio-galley-545fdc5749-2xqnl            225m         56Mi
istio-ingressgateway-6d9db74868-dcxpb    15m          76Mi
istio-ingressgateway-6d9db74868-fxkxj    15m          76Mi
istio-ingressgateway-6d9db74868-hcsxn    16m          77Mi
istio-ingressgateway-6d9db74868-mvlr2    15m          77Mi
istio-ingressgateway-6d9db74868-xt2ck    15m          76Mi
istio-pilot-69f969cd6f-929lr             32m          79Mi
istio-pilot-69f969cd6f-jmmbb             34m          72Mi
istio-pilot-69f969cd6f-n5wk7             34m          75Mi
istio-pilot-69f969cd6f-sqp6w             36m          78Mi
istio-pilot-69f969cd6f-t676w             34m          70Mi
istio-policy-68c868b65c-6mgdt            22m          67Mi
istio-policy-68c868b65c-bcblj            23m          66Mi
istio-policy-68c868b65c-gvkgz            22m          67Mi
istio-policy-68c868b65c-tjvzk            22m          66Mi
istio-policy-68c868b65c-xpkgr            22m          65Mi
istio-sidecar-injector-68bf9645b-kkqbf   153m         31Mi
istio-telemetry-9c9688fb-26tm5           22m          70Mi
istio-tracing-79db5954f-mz8hl            2m           47Mi
kiali-7b5b867f8-5t66l                    1m           9Mi
prometheus-5b48f5d49-b7dpr               71m          799Mi

@mandarjog


added retrypolicy to topic client in azure topic publisher

Also: Issue #18 needs to be solved before this can released. It's currently being done in #19 but I'm probably not able to fix that today because I need to hunt down our nuget api keys


error

| GoSublime error: MarGo build failed
|                > This is possibly a bug or miss-configuration of your environment.
|                > For more help, please file an issue with the following build output
|                > at: https://github.com/DisposaBoy/GoSublime/issues/new
|                > or alternatively, you may send an email to<EMAIL_ADDRESS>|                >
|                >
|                > cmd: ['/usr/local/go/bin/go', 'build', '-v', '-x', '-o', 'gosublime.margo_r14.12.06-1_go1.5.1.exe', 'gosubli.me/margo']
|                > stdout: ``
|                > stderr: WORK=/var/folders/9_/2f7h06ws4cx9c0kxhf6wc1sc0000gn/T/go-build951875286 |                > ../../../../GoSublime/src/gosubli.me/margo/broker.go:4:2: cannot find package "bufio" in any of: |                > 	/usr/local/go/bin/src/bufio (from $GOROOT) |                > 	~/Library/Application Support/Sublime Text 3/Packages/GoSublime/src/bufio (from $GOPATH) |                > ../../../../GoSublime/src/gosubli.me/margo/broker.go:5:2: cannot find package "bytes" in any of: |                > 	/usr/local/go/bin/src/bytes (from $GOROOT) |                > 	~/Library/Application Support/Sublime Text 3/Packages/GoSublime/src/bytes (from $GOPATH) |                > ../../../../GoSublime/src/gosubli.me/margo/common.go:5:2: cannot find package "encoding/base64" in any of: |                > 	/usr/local/go/bin/src/encoding/base64 (from $GOROOT) |                > 	~/Library/Application Support/Sublime Text 3/Packages/GoSublime/src/encoding/base64 (from $GOPATH) |                > ../../../../GoSublime/src/gosubli.me/margo/broker.go:6:2: cannot find package "encoding/json" in any of: |                > 	/usr/local/go/bin/src/encoding/json (from $GOROOT) |                > 	~/Library/Application Support/Sublime Text 3/Packages/GoSublime/src/encoding/json (from $GOPATH) |                > ../../../../GoSublime/src/gosubli.me/something-borrowed/gocode/package.go:5:2: cannot find package "errors" in any of: |                > 	/usr/local/go/bin/src/errors (from $GOROOT) |                > 	~/Library/Application Support/Sublime Text 3/Packages/GoSublime/src/errors (from $GOPATH) |                > ../../../../GoSublime/src/gosubli.me/margo/main.go:7:2: cannot find package "flag" in any of: |                > 	/usr/local/go/bin/src/flag (from $GOROOT) |                > 	~/Library/Application Support/Sublime Text 3/Packages/GoSublime/src/flag (from $GOPATH) |                > ../../../../GoSublime/src/gosubli.me/margo/common.go:7:2: cannot find package "fmt" in any of: |                > 	/usr/local/go/bin/src/fmt (from $GOROOT) |                > 	~/Library/Application Support/Sublime Text 3/Packages/GoSublime/src/fmt (from $GOPATH) |                > ../../../../GoSublime/src/gosubli.me/margo/common.go:8:2: cannot find package "go/ast" in any of: |                > 	/usr/local/go/bin/src/go/ast (from $GOROOT) |                > 	~/Library/Application Support/Sublime Text 3/Packages/GoSublime/src/go/ast (from $GOPATH) |                > ../../../../GoSublime/src/gosubli.me/margo/m_play.go:5:2: cannot find package "go/build" in any of: |                > 	/usr/local/go/bin/src/go/build (from $GOROOT) |                > 	~/Library/Application Support/Sublime Text 3/Packages/GoSublime/src/go/build (from $GOPATH) |                > ../../../../GoSublime/src/gosubli.me/margo/common.go:9:2: cannot find package "go/parser" in any of: |                > 	/usr/local/go/bin/src/go/parser (from $GOROOT) |                > 	~/Library/Application Support/Sublime Text 3/Packages/GoSublime/src/go/parser (from $GOPATH) |                > ../../../../GoSublime/src/gosubli.me/margo/common.go:10:2: cannot find package "go/printer" in any of: |                > 	/usr/local/go/bin/src/go/printer (from $GOROOT) |                > 	~/Library/Application Support/Sublime Text 3/Packages/GoSublime/src/go/printer (from $GOPATH) |                > ../../../../GoSublime/src/gosubli.me/margo/m_lint.go:6:2: cannot find package "go/scanner" in any of: |                > 	/usr/local/go/bin/src/go/scanner (from $GOROOT) |                > 	~/Library/Application Support/Sublime Text 3/Packages/GoSublime/src/go/scanner (from $GOPATH) |                > ../../../../GoSublime/src/gosubli.me/margo/common.go:11:2: cannot find package "go/token" in any of: |                > 	/usr/local/go/bin/src/go/token (from $GOROOT) |                > 	~/Library/Application Support/Sublime Text 3/Packages/GoSublime/src/go/token (from $GOPATH) |                > ../../../../GoSublime/src/gosubli.me/something-borrowed/gocode/config.go:7:2: cannot find package "io" in any of: |                > 	/usr/local/go/bin/src/io (from $GOROOT) |                > 	~/Library/Application Support/Sublime Text 3/Packages/GoSublime/src/io (from $GOPATH) |                > ../../../../GoSublime/src/gosubli.me/something-borrowed/gocode/autocompletecontext.go:9:2: cannot find package "io/ioutil" in any of: |                > 	/usr/local/go/bin/src/io/ioutil (from $GOROOT) |                > 	~/Library/Application Support/Sublime Text 3/Packages/GoSublime/src/io/ioutil (from $GOPATH) |                > ../../../../GoSublime/src/gosubli.me/margo/main.go:10:2: cannot find package "log" in any of: |                > 	/usr/local/go/bin/src/log (from $GOROOT) |                > 	~/Library/Application Support/Sublime Text 3/Packages/GoSublime/src/log (from $GOPATH) |                > ../../../../GoSublime/src/gosubli.me/something-borrowed/types/const.go:12:2: cannot find package "math/big" in any of: |                > 	/usr/local/go/bin/src/math/big (from $GOROOT) |                > 	~/Library/Application Support/Sublime Text 3/Packages/GoSublime/src/math/big (from $GOPATH) |                > ../../../../GoSublime/src/gosubli.me/something-borrowed/gocode/server.go:5:2: cannot find package "net" in any of: |                > 	/usr/local/go/bin/src/net (from $GOROOT) |                > 	~/Library/Application Support/Sublime Text 3/Packages/GoSublime/src/net (from $GOPATH) |                > ../../../../GoSublime/src/gosubli.me/margo/m_pkgdoc.go:7:2: cannot find package "net/http" in any of: |                > 	/usr/local/go/bin/src/net/http (from $GOROOT) |                > 	~/Library/Application Support/Sublime Text 3/Packages/GoSublime/src/net/http (from $GOPATH) |                > ../../../../GoSublime/src/gosubli.me/something-borrowed/gocode/client.go:7:2: cannot find package "net/rpc" in any of: |                > 	/usr/local/go/bin/src/net/rpc (from $GOROOT) |                > 	~/Library/Application Support/Sublime Text 3/Packages/GoSublime/src/net/rpc (from $GOPATH) |                > ../../../../GoSublime/src/gosubli.me/margo/m_pkgdoc.go:8:2: cannot find package "net/url" in any of: |                > 	/usr/local/go/bin/src/net/url (from $GOROOT) |                > 	~/Library/Application Support/Sublime Text 3/Packages/GoSublime/src/net/url (from $GOPATH) |                > ../../../../GoSublime/src/gosubli.me/something-borrowed/gocode/autocompletecontext.go:10:2: cannot find package "os" in any of: |                > 	/usr/local/go/bin/src/os (from $GOROOT) |                > 	~/Library/Application Support/Sublime Text 3/Packages/GoSublime/src/os (from $GOPATH) |                > ../../../../GoSublime/src/gosubli.me/something-borrowed/gocode/os_posix.go:8:2: cannot find package "os/exec" in any of: |                > 	/usr/local/go/bin/src/os/exec (from $GOROOT) |                > 	~/Library/Application Support/Sublime Text 3/Packages/GoSublime/src/os/exec (from $GOPATH) |                > ../../../../GoSublime/src/gosubli.me/margo/m_doc.go:7:2: cannot find package "path" in any of: |                > 	/usr/local/go/bin/src/path (from $GOROOT) |                > 	~/Library/Application Support/Sublime Text 3/Packages/GoSublime/src/path (from $GOPATH) |                > ../../../../GoSublime/src/gosubli.me/something-borrowed/gocode/autocompletecontext.go:11:2: cannot find package "path/filepath" in any of: |                > 	/usr/local/go/bin/src/path/filepath (from $GOROOT) |                > 	~/Library/Application Support/Sublime Text 3/Packages/GoSublime/src/path/filepath (from $GOPATH) |                > ../../../../GoSublime/src/gosubli.me/something-borrowed/gocode/config.go:10:2: cannot find package "reflect" in any of: |                > 	/usr/local/go/bin/src/reflect (from $GOROOT) |                > 	~/Library/Application Support/Sublime Text 3/Packages/GoSublime/src/reflect (from $GOPATH) |                > ../../../../GoSublime/src/gosubli.me/margo/m_lint.go:9:2: cannot find package "regexp" in any of: |                > 	/usr/local/go/bin/src/regexp (from $GOROOT) |                > 	~/Library/Application Support/Sublime Text 3/Packages/GoSublime/src/regexp (from $GOPATH) |                > ../../../../GoSublime/src/gosubli.me/something-borrowed/gocode/autocompletecontext.go:12:2: cannot find package "runtime" in any of: |                > 	/usr/local/go/bin/src/runtime (from $GOROOT) |                > 	~/Library/Application Support/Sublime Text 3/Packages/GoSublime/src/runtime (from $GOPATH) |                > ../../../../GoSublime/src/gosubli.me/something-borrowed/gocode/autocompletecontext.go:13:2: cannot find package "sort" in any of: |                > 	/usr/local/go/bin/src/sort (from $GOROOT) |                > 	~/Library/Application Support/Sublime Text 3/Packages/GoSublime/src/sort (from $GOPATH) |                > ../../../../GoSublime/src/gosubli.me/something-borrowed/gocode/client.go:10:2: cannot find package "strconv" in any of: |                > 	/usr/local/go/bin/src/strconv (from $GOROOT) |                > 	~/Library/Application Support/Sublime Text 3/Packages/GoSublime/src/strconv (from $GOPATH) |                > ../../../../GoSublime/src/gosubli.me/something-borrowed/gocode/decl.go:10:2: cannot find package "strings" in any of: |                > 	/usr/local/go/bin/src/strings (from $GOROOT) |                > 	~/Library/Application Support/Sublime Text 3/Packages/GoSublime/src/strings (from $GOPATH) |                > ../../../../GoSublime/src/gosubli.me/something-borrowed/gocode/decl.go:11:2: cannot find package "sync" in any of: |                > 	/usr/local/go/bin/src/sync (from $GOROOT) |                > 	~/Library/Application Support/Sublime Text 3/Packages/GoSublime/src/sync (from $GOPATH) |                > ../../../../GoSublime/src/gosubli.me/something-borrowed/gocode/package.go:13:2: cannot find package "text/scanner" in any of: |                > 	/usr/local/go/bin/src/text/scanner (from $GOROOT) |                > 	~/Library/Application Support/Sublime Text 3/Packages/GoSublime/src/text/scanner (from $GOPATH) |                > ../../../../GoSublime/src/gosubli.me/something-borrowed/gocode/autocompletecontext.go:14:2: cannot find package "time" in any of: |                > 	/usr/local/go/bin/src/time (from $GOROOT) |                > 	~/Library/Application Support/Sublime Text 3/Packages/GoSublime/src/time (from $GOPATH) |                > ../../../../GoSublime/src/gosubli.me/something-borrowed/gocode/cursorcontext.go:6:2: cannot find package "unicode" in any of: |                > 	/usr/local/go/bin/src/unicode (from $GOROOT) |                > 	~/Library/Application Support/Sublime Text 3/Packages/GoSublime/src/unicode (from $GOPATH) |                > ../../../../GoSublime/src/gosubli.me/something-borrowed/gocode/cursorcontext.go:7:2: cannot find package "unicode/utf8" in any of: |                > 	/usr/local/go/bin/src/unicode/utf8 (from $GOROOT) |                > 	~/Library/Application Support/Sublime Text 3/Packages/GoSublime/src/unicode/utf8 (from $GOPATH)
|                > exception: None
|   install state: busy
| sublime.version: 3083
| sublime.channel: stable
|       about.ann: a14.02.25-1
|   about.version: r14.12.06-1
|         version: r14.12.06-1
|        platform: osx-x64
|            ~bin: ~/Library/Application Support/Sublime Text 3/Packages/User/GoSublime/osx-x64/bin
|       margo.exe: ~bin/gosublime.margo_r14.12.06-1_go1.5.1.exe (missing)
|          go.exe: /usr/local/go/bin/go (ok)
|      go.version: go1.5.1
|          GOROOT: /usr/local/go/bin
|          GOPATH: /Volumes/Code/golang
|           GOBIN: (not set) (should usually be (not set))
|       set.shell: []
|       env.shell: /bin/bash
|       shell.cmd: ['/bin/bash', '-l', '-c', '${CMD}']

your GOROOT is wrong. It should probably be /usr/local/go


Changes continuous mode to Reactive mode.

After discussion, ensuring that continuous update is the default is more intuitive for getting started.
This only changes the default behavior and the general semantics. Continuous is now the default with Reactive mode being opt in.
The semantics makes it obvious that under normal circumstances godot-egui will update every frame like an immediate mode gui would be expected.

:+1:

Looks great! Thanks for taking care of this :smile:


Added a tooltip for fields with the type "file" and "image"

What does it do ?
Added a tooltip for fields with the type "file" and "image":

Why is it needed ?
For fields except "file" and "image", tooltips work. Now they work for all fields.
Related issue(s)/PR(s)
https://github.com/modmore/ClientConfig/issues/163#issuecomment-535943250

This works nicely, thanks @Ruslan-Aleev 👍🏻


Unexpected token

I have a problem with brackets. I can install extension to brackets but I can't use it. I open  developer tools but i don't understand this problem. Console show me this all the time.
Uncaught SyntaxError: Unexpected token < file:///C:/Users/:1

@Zevgart Looks like you have a problem with some brackets extension on Windows OS. Are you sure it's related to the Storybook project? As I know we don't have any brackets extensions yet.
If you need help with running Storybook on Windows with Brackets feel free to connect with me in our slack, possible we can figure out it together


[PRSS - AZURE CODE SIGNING - SIGN - Azure Code Signing] API Review

New API Review meeting has been requested.
Service Name: PRSS - AZURE CODE SIGNING - SIGN - Azure Code Signing
Review Created By: Jaxel Rojas Lopez @Jaxelr
Review Date: 05/23/2023 01:00 PM PT
PR: https://github.com/Azure/azure-rest-api-specs/pull/22310
Hero Scenarios Link: Not Provided
Core Concepts Doc Link: Not Provided
Description: Scheduling API Review meeting for Dataplane service of Azure Code Signing service.
Detailed meeting information and documents provided can be accessed here
For more information that will help prepare you for this review, the requirements, and office hours, visit the documentation here

@jaxelr We just had a slot open up on the review calendar for this Tuesday, May 9, at 1PM PT.  If you are ready please feel free to reschedule your review into this open slot.

Meeting updated by Jaxel Rojas Lopez
Service Name: PRSS - AZURE CODE SIGNING - SIGN - Azure Code Signing
Review Created By: Jaxel Rojas Lopez
Review Date: 05/23/2023 01:00 PM PT
Onboarding Record: https://dev.azure.com/azure-sdk/Release/_workitems/edit/9295
PR: https://github.com/Azure/azure-rest-api-specs/pull/22310
Hero Scenarios Link: here
Core Concepts Doc Link: here
Description: Scheduling API Review meeting for Dataplane service of Azure Code Signing service.
Detailed meeting information and documents provided can be accessed here
For more information that will help prepare you for this review, the requirements, and office hours, visit the documentation here

API Review: 23-May-23
/codesigningaccounts/{codeSigningAccountName}/certificateprofiles/{certificateProfileName}/sign/...

There are multiple values in the path that "magic values" - these are very hard to use from the perspective of the developer, e.g. where do they get them, what do they mean, etc. Consider simplifying these.

Consider adding list operations on the "magic values" so that developers can discover valid values.
It's recommended to perform user studies on how developers use the API outside of the portal.

Try using the Azure-Core operation templates. There are several examples where the templates would help, e.g.


Direct Input Keybinds

after running the exe, I got the error that everyone seems to get, "Script failed to execute..", after looking at the log and actually running the py script, the reason for my case is:

Traceback (most recent call last):
File "dev_autopilot.py", line 372, in
keys = get_bindings()
File "dev_autopilot.py", line 354, in get_bindings
binding['key'] = SCANCODE[binding['pre_key']]
KeyError: 'DIK_HASH'

Before this one, I got the same error but for DIK_NUMPAD_SUBTRACT, thought someone just forgot the NUMPAD_ missing from directinput.py and moved along, now I realize that these keybinds aren't very compatible, as HASH (the # character) doesn't seem to even exist in dinput.h
It seems that ED can identify these keys in a reliable fashion, but I'm not quite sure how this program could be made to do the same.
After spending a bit of time finding random keys that didn't conflict with anything, it worked (still not on the exe, that one's just broken, although maybe in a similar place).

there are some known issues with the way we are currently reading in the keybinds file. i think these are fixed in my testing branch, could you please do a fresh clone from here let me know if it works. this branch also has some debug windows enabled but these can be ignored.

That branch is slightly better (The ] key works now), but Key_Hash is still not available

hang on what key is the hash key? for me it is shift+3 so there is no actual code for it. what keyboard layout are you using?

It's strange, I don't have a hash key either, on my keyboard (pt), it's ~ (Shift and you get ^), but Elite reads it as #, and the key works like normal
The error resulting from it says KeyError: 'Key_Hash'

where is the key physicaly?

To the left of RETURN, the ~ and ^ key

In Minecraft, it gets registered as ~, in Elite Dangerous:

And it's not the keyboard, I've tried 3 now and they all have the exact same behaviour

ok could you try and see what you get from that key on this site. https://keycode.info/ this is not for scancodes but it is good for seeing how the computer is interpreting the key.

well now i'm lost. that is the same code as i get from the / key. it might be that we simply cannot support this key. without being able to identify the key properly i won't be able to get the code to send to ED.

i mean worse case we could try just incrementing the code and waiting till ED gets the right key.

Brute force is not a good option here, it's better to just inform the user should this error occur

i don't mean every time i just mean to get the code needed for the future. if i could through something together to try and find the code would you be willing to test it? i don't have a keyboard like that so i wont be able to.

Oh, sure
I already looked through keyboard module's documentation and the key_to_scan_codes function tells me it's 43(decimal), which is apparently 'Key_BackSlash': 0x2B,  # KEY_BACKSLASH
So the question is: Why does Elite see it as Key_Hash, and why does that not exist?
(The answer that seems most likely right now is: blame FDev and call it a day)

what does elite do when you try and use back slash?

I added it to EDKeyCodes now (And it does work), and I guess I could make the settings menu (Where one can change the start and end keys to the program) always log the keycode for future issues


Support for Selecting Pre-existing Assistants in Betalgo OpenAI C# Library

Is your feature request related to a problem? Please describe.
Yes, I'm encountering a limitation in the Betalgo OpenAI C# library when integrating ChatGPT assistants. Currently, the library does not offer an option to select and utilize a pre-existing assistant created via the OpenAI platform (e.g., through the assistant management interface). This restricts the ability to manage and interact with assistants that are already configured and fine-tuned in the OpenAI environment, leading to redundancy and increased overhead in assistant management. https://platform.openai.com/docs/api-reference/assistants/getAssistant
Describe the solution you'd like
I would like the library to include functionality that allows users to specify an existing assistant's ID when creating chat sessions. This feature would enable developers to seamlessly integrate and manage multiple pre-configured assistants directly through the C# library, enhancing usability and flexibility in application development.
Describe alternatives you've considered
As a workaround, I have considered manually mapping assistant IDs within my application logic and passing these IDs as parameters when initiating sessions. However, this approach is less efficient and does not leverage the native capabilities of the OpenAI API, which could potentially offer more robust and integrated solutions.
Additional context
I've attached screenshots demonstrating the absence of this feature in the current library interface. The ability to directly select a pre-existing assistant would significantly streamline the development process for applications leveraging the OpenAI platform.
Also, here is a additional video about the issue: https://youtu.be/LQ5xtsp7gYo?t=464

Can you share what kind of code you wish existed?
Because we have methods to list and also retrieve an assistant linked to your account. You should be able to use the Assistant that you created via the API or Playground UI.


Support custom host for Cloud Spanner

The Cloud Spanner client library allows a custom host to be specified instead of using the default https://spanner.googleapis.com. Setting a custom host makes it possible to connect to a (local) emulator instead of a real Cloud Spanner instance for testing/development purposes. Adding a 'host' configuration property to GcpSpannerAutoConfiguration could solve this.

Thank you for the issue and PR. However, we can't merge this since we don't plan to support 3rd party emulators/services endpoints right now.


Replace babel polyfill with transform runtime

Note: The commit message might be a bit confusing, it doesn't fix all of #42, just https://github.com/schmich/instascan/issues/42#issuecomment-302707439
I can squash and force-push if you want and remove the reference, or you could use squash during merge.

I'm not able to reproduce the error locally Error: Cannot find module 'babel-runtime/regenerator'. Perhaps it means the babel-runtime has to be an explicit dependency as well? https://babeljs.io/docs/plugins/transform-runtime/


Variants sets integration in clin

This PR avoids making extra request calls to annotate variants when launched from clin.
To test:

Use the branch integrate-variants-set https://github.com/iobio/clin.iobio/tree/integrate-variant-sets for clin.iobio
Launch a project from Mosaic with variant sets in clin (Do the URL trick to change URL localhost:4030).
Go to review-variants
All the genes should be analyzed and variants should be imported.

quarantest build successful. Demo link at
http://aa64f74c.quarantest.iobio.io


Source file trees

Implement source file tree support.

Please be carefull when merging this since it might conflict with #4, that is to say, the code in this branch might need to be altered to also support multiple source file extensions.

The clean commands don't work properly on this branch. The versions on #6 should work so it is probably wise to merge that branch into this one first.

The cleaning logic is not quite yet perfect

It is true that cleaning still goes wonky when BINDIR is set to . but it wouldn't suffice to simply check if BINDIR==. since when building libraries it is not uncommon to set BINDIR to ... I honestly don't know how to handle this properly.

I agree with the changes, looks good! Time to merge.

Has been merged manually


Add Digital Outcomes and Specialists to frameworks

Depends on:

[x] https://github.com/alphagov/digitalmarketplace-buyer-frontend/pull/187 being merged and deployed through to production

--
This commit checks to see if:

the framework exists in the enum before trying to add it
the framework exists in the table before trying to add

This means that it won’t fall over on environments where DOS has already been created (eg local dev machines, preview).
The downgrade will fail if data associated with a framework has been created (eg a supplier has registered interest). We made this trade off because:

can rollback production if anything goes wrong if we deploy this
no framework-related data will be created on production until the framework is open—by which time it will be way too late to rollback this far

Paired with @TheDoubleK

Closing in favour of https://github.com/alphagov/digitalmarketplace-api/pull/294


Is there support to load any kind of local image?

Yes, if you use a local image then this will fallback to using the Image component.

@DylanVann so it will't use glide anymore? i mean glide has support for local images and caching. sorry for many questions but..


fix typo

Hi, thanks again for the effort. This has already been fixed in #4, so I will close it for now.


Quote module overlapping text

Hey guys,
Just noticed this:

And was wondering if this is something only on my end* or a bug actually.  If so, I'd like to know if it's valuable to issue a PR to fix this.
*I'm using Version 43.0.2336.0 canary (64-bit)
Here is a live demo: https://google.github.io/web-starter-kit/hello-world/styleguide.html#quote

If I'm not mistaken it seems that Roboto font isn't loading, thus the error.

This appears to be an issue with Roboto not loading indeed. As we've halted work on updating the styles/components for WSK 0.5.0 (0.6 comes with a brand new component set), I recommend using the z-index hack proposed by @battaglr as a workaround in the mean time. Sorry we don't have a better answer for this yet, but 0.6 will have more robust styles :)

hey guys, thanks for the feedback :)


In Blazor: setting select element value by code is not consistent

Using Blazor I want to set the selected option in a select element from code in the same page. That doesnt work when writing out the options explicitly, but works when using a @foreach:
This doesnt work: (option 2 will not be selected when page is navigated to)
@page "/test2"

	<select class="form-control" value=@theValue>
		<option value="1">item1</option>
		<option value="2">item2</option>
		<option value="3">item3</option>
	</select>
	@theValue

@functions {
	private int theValue { get; set; } = 2;
}

This works: (option 2 will be selected when page is navigated to)
@page "/test3"

	<select class="form-control" value=@theValue>
		@foreach (var id in theList)
		{
			<option value="@id">@id</option>
		}
	</select>
	@theValue

@functions {
	private int theValue { get; set; } = 2;
	int[] theList = new int[] { 1, 2, 3, 4 };
}

To my limited knowledge both version should work.
/Mats Wessling
versions:
Microsoft Visual Studio Professional 2017
Version 15.9.4
VisualStudio.15.Release/15.9.4+28307.222
Microsoft .NET Framework
Version 4.7.03056
Installed Version: Professional
Visual C++ 2017   00369-60000-00001-AA941
Microsoft Visual C++ 2017
ADL Tools Service Provider   1.0
This package contains services used by Data Lake tools
Application Insights Tools for Visual Studio Package   8.14.11009.1
Application Insights Tools for Visual Studio
ASP.NET and Web Tools 2017   15.9.04012.0
ASP.NET and Web Tools 2017
ASP.NET Core Blazor Language Services   0.7.0-rtm-20181115.1
ASP.NET Core Razor Language Services   15.8.31590
Provides languages services for ASP.NET Core Razor.
ASP.NET Web Frameworks and Tools 2017   5.2.60913.0
For additional information, visit https://www.asp.net/
Azure App Service Tools v3.0.0   15.9.03024.0
Azure App Service Tools v3.0.0
Azure Data Lake Node   1.0
This package contains the Data Lake integration nodes for Server Explorer.
Azure Data Lake Tools for Visual Studio   2.3.5001.7
Microsoft Azure Data Lake Tools for Visual Studio
Azure Functions and Web Jobs Tools   15.9.02046.0
Azure Functions and Web Jobs Tools
Azure Stream Analytics Tools for Visual Studio   2.3.5001.7
Microsoft Azure Stream Analytics Tools for Visual Studio
C# Tools   2.10.0-beta2-63501-03+b9fb1610c87cccc8ceb74a770dba261a58e39c4a
C# components used in the IDE. Depending on your project type and settings, a different version of the compiler may be used.
Common Azure Tools   1.10
Provides common services for use by Azure Mobile Services and Microsoft Azure Tools.
Fabric.DiagnosticEvents   1.0
Fabric Diagnostic Events
GitHub.VisualStudio   <IP_ADDRESS>27
A Visual Studio Extension that brings the GitHub Flow into Visual Studio.
JavaScript Language Service   2.0
JavaScript Language Service
JavaScript Project System   2.0
JavaScript Project System
Microsoft Azure HDInsight Azure Node   2.3.5001.7
HDInsight Node under Azure Node
Microsoft Azure Hive Query Language Service   2.3.5001.7
Language service for Hive query
Microsoft Azure Service Fabric Tools for Visual Studio   2.4
Microsoft Azure Service Fabric Tools for Visual Studio
Microsoft Azure Stream Analytics Language Service   2.3.5001.7
Language service for Azure Stream Analytics
Microsoft Azure Stream Analytics Node   1.0
Azure Stream Analytics Node under Azure Node
Microsoft Azure Tools   2.9
Microsoft Azure Tools for Microsoft Visual Studio 2017 - v2.9.10730.2
Microsoft Continuous Delivery Tools for Visual Studio   0.4
Simplifying the configuration of Azure DevOps pipelines from within the Visual Studio IDE.
Microsoft JVM Debugger   1.0
Provides support for connecting the Visual Studio debugger to JDWP compatible Java Virtual Machines
Microsoft Library Manager   1.0
Install client-side libraries easily to any web project
Microsoft MI-Based Debugger   1.0
Provides support for connecting Visual Studio to MI compatible debuggers
Microsoft Visual C++ Wizards   1.0
Microsoft Visual C++ Wizards
Microsoft Visual Studio Tools for Containers   1.1
Develop, run, validate your ASP.NET Core applications in the target environment. F5 your application directly into a container with debugging, or CTRL + F5 to edit & refresh your app without having to rebuild the container.
Microsoft Visual Studio VC Package   1.0
Microsoft Visual Studio VC Package
MLGen Package Extension   1.0
MLGen Package Visual Studio Extension Detailed Info
MySQL for Visual Studio   1.2.8
Data design and management tools for MySQL. Copyright (c) 2007, 2018, Oracle and/or its affiliates. All rights reserved.
Node.js Tools   1.4.21001.1 Commit Hash:8dd15923800d931b153ab9e4de74e42a74eba5e6
Adds support for developing and debugging Node.js apps in Visual Studio
NuGet Package Manager   4.6.0
NuGet Package Manager in Visual Studio. For more information about NuGet, visit http://docs.nuget.org/.
ProjectServicesPackage Extension   1.0
ProjectServicesPackage Visual Studio Extension Detailed Info
ResourcePackage Extension   1.0
ResourcePackage Visual Studio Extension Detailed Info
ResourcePackage Extension   1.0
ResourcePackage Visual Studio Extension Detailed Info
SQL Server Data Tools   15.1.61810.11040
Microsoft SQL Server Data Tools
ToolWindowHostedEditor   1.0
Hosting json editor into a tool window
TypeScript Tools   15.9.20918.2001
TypeScript Tools for Microsoft Visual Studio
Visual Basic Tools   2.10.0-beta2-63501-03+b9fb1610c87cccc8ceb74a770dba261a58e39c4a
Visual Basic components used in the IDE. Depending on your project type and settings, a different version of the compiler may be used.
Visual C++ for Linux Development   <IP_ADDRESS>218
Visual C++ for Linux Development
Visual F# Tools 10.2 for F# 4.5   <IP_ADDRESS>.  Commit Hash: 6e26c5bacc8c4201e962f5bdde0a177f82f88691.
Microsoft Visual F# Tools 10.2 for F# 4.5
Visual Studio Code Debug Adapter Host Package   1.0
Interop layer for hosting Visual Studio Code debug adapters in Visual Studio
Visual Studio Tools for CMake   1.0
Visual Studio Tools for CMake
Visual Studio Tools for Containers   1.0
Visual Studio Tools for Containers

Per @Andrzej-W 's response above, this is a dupe of https://github.com/aspnet/AspNetCore/issues/5616


Cannot find namespace 'Zod'. Did you mean 'zod'?

Hi,
I have an issue in my application, when I try to generate the build, TypeScript throws the error below:
node_modules/zod-validation-error/dist/types/ValidationError.d.ts:3:20 - error TS2833: Cannot find namespace 'Zod'. Did you mean 'zod'?

3     details: Array<Zod.ZodIssue>;
                     ~~~

node_modules/zod-validation-error/dist/types/ValidationError.d.ts:5:50 - error TS2833: Cannot find namespace 'Zod'. Did you mean 'zod'?

5     constructor(message: string, details?: Array<Zod.ZodIssue> | undefined);
                                                   ~~~

Found 2 errors in the same file, starting at: node_modules/zod-validation-error/dist/types/ValidationError.d.ts:3

I don't know if the issue is with my application or with zod-validation, I'm using version 1.3.0.

@lucasfernandodev thanks for reporting this issue. I have qualified it as a bug. The team is working on a solution.

Thank you, feel free to ask me for any information you need.

Fixed with v.1.3.1. Currently released on npm.


[WIP] Taught Godot how to redirect the texture locations when import_animat…

…ion_from_other_importer.
Found a problem where import_scene_from_other_importer doesn't give enough information to redirect .import files to the original location.

It would be better to find a way to get back to the original path directly by looking it up in the import remaps hashmap. There might already be an API for that, but best wait for @reduz to give input on that.

There is two ways you can can call import scene from other importer:

call it from an existing location in the file system
use the external exporter then call the api with the exporter location and the original location. For example somewhere in .import and the original location.

The first one requires the associated data to be in the same place. This is the normal case.
The second case requires the .import scene to be relocated so that the associated data is at the original location.

Updated.

Moving to 3.2 milestone as we're about to enter the beta stage and release freeze for Godot 3.1. Only bug fixes against issues of the 3.1 milestone (or enhancements to core features of the 3.1 roadmap) will be considered until 3.1-stable is released.

My original case for using this was to import_scene_from_other_importer for FBX via GLTF2, but since that isn't my approach anymore, I'm not able to test this.
import_scene_from_other_importer is still broken.., but I'm not using it.


Directions rawBody is created on main thread

https://github.com/akexorcist/Android-GoogleDirectionLibrary/blob/c13996e1a89cf484b8b9781ac3610313bcb2052a/googleDirectionLibrary/src/main/java/com/akexorcist/googledirection/request/DirectionRequest.java#L116
Callback runs on  MainThread, and there is creation of json from response.
In case when the path is long (ex. walk path across whole country) the conversion may take a while and cause application to hang (path of 700km converts on slow phone for 2 seconds)

I removed this value in https://github.com/akexorcist/Android-GoogleDirectionLibrary/commit/fa42e57d6ace382f3362931788a5598977ab9ba1
There's no reason to use this value


[Geographiclib] update version to 2.3

[x] Changes comply with the maintainer guide
[x] SHA512s are updated for each updated download
[x] The "supports" clause reflects platforms that may be fixed by this new version
[ ] N/A Any fixed CI baseline entries are removed from that file.
[ ] N/A Any patches that are no longer applied are deleted from the port's directory.
[x] The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
[x] Only one version is added to each modified port's versions file.

Thanks for the update!


Plug 1446

Changes

When login with SSO -> used API connect/userinfo to fetch permissions
when login with uname_password - using jwt decode to fetch permissions
Removed hardcode values of result states
Fetched result state dynamically and shown according to permission

Test below cases login with SSO and username_password both

Create a new Role R1
Create a new user with R1 roles

Test Case 1

Role R1 - uncheck permission of set-result-state-toverify.
login with the VS code plugin and check the result state available in the result state table
Expected output - To Verify option not available in Result state dropdown
Do similar things for Confirmed, Urgent, Not exploitable, Proposed not exploitable
update vulnerability states of any
Check with different language

Test Case 2

Create a custom state as per documentation
https://checkmarx.atlassian.net/wiki/spaces/KC/pages/5982847752/Adding+Custom+Result+States
Provide newly created states permission to the user
log in with the VS plugin and check the result state available in the result state table
Expected output - newly created custom field display in result state dropdown
update the vulnerability states of any
remove permission of newly created custom states
login with the VS plugin and check result state is available in the result state table or not
Expected output - option not available in Result state dropdown

Test Case 3

Test all this with latest SAST 9.4,9.5,9.6.

Test Case 4

For SAST 9.4 API is not available - sast/resultStates
If user not have permissions and try to update selected vulnarabilty result state then it will return error message -You are not authorized to mark the selected vulnerability result as

Approved


Fails with absolute paths

As of now, getFileContent cannot process absolute paths like include /base.
In jade, include /base is resolved relative to options.basedir, see https://github.com/visionmedia/jade/blob/master/lib/parser.js#L466-L469.
So it is actually taken from options.basedir, that we take as correct.
In jade-loader, it is converted to .//base in the first line of getFileContent:
  function getFileContent(context, request) {
		request = /^~/.test(request) ? request.substr(1) : "./" + request;

...and taken from the current folder, that's wrong.

Consider changing root option to basedir, which is what jade options calls it.


Update to Spring Boot 2.2.6.RELEASE

This updates CAS 6.1 from using Spring Boot 2.2.0 to 2.2.6 and also some transitive dependencies like Spring Framework and Spring Data.

Thanks very much for the patch. We cant accept this, as this does not fit the scope of a patch release. If there is a specific bug or fix you have mind, we can discuss that review that item specifically, whether that requires an upgrade, etc.

@mmoayyed The "goal" was to stop CVE-2020-5397 and CVE-2020-5398 from showing up on our dependency reports.
This requries an update to Spring Framework 5.2.3+.
Since cas ship's it's dependencies itself (inside the overlay war) we can't easily override the versions in our build script.

Apologies for the latest response.
Is this a sort of issue that actually affects CAS with applicability (in which case you should likely submit a query to the appsec group?) or is this more like a nuisance that just pops up on the reports with no reproducible impact?
As far as I can tell, recent versions of 6.1.x today should ship with Spring 5.2.5. Does not that address your concern?
...and, dependency updates on patch releases usually should be applied surgically to minimize impact to overlays. Upgrading Spring Boot requires a change also in overlay on the users' part and lot more testing which creates extra unnecessary work for a patch release where the expectation is to usually upgrade the CAS version itself and no more. If there is something specific you'd like to upgrade, it would be best to focus on that component only rather than sweeping changes. If the scope you have in mind is broader than a patch release, please target your changes to the master/main and switch to the latest cutting edge (RC or SNAPSHOT) to assist with testing and future upgrade plans. (RCs are cut for exactly this reason). The current branch is running the latest available spring version and spring boot version and the dependency-upgrade policy is more relaxed for feature releases.


[window-state] Only saving window position and not size (v2)

The window-state plugin (v2 off of crates.io) fails to save/restore window size (at least on MacOS, I haven't tested on any other operating systems).
MRE Repo (Just run the app, resize, close, relaunch, and observe the size not being restored)
I've seen some similarish looking issues but they've been closed and don't seem to be addressing the same problem. If this has already been fixed and is just finding its way to release let me know.

Couldn't reproduce on Windows, can't really investigate macos

I confirm. This error also occurs on my macOS

I find that this issue is caused by tauri::window::Window::inner_size() function. It always returns the width and height defined in tauri.conf.json but not the actual number of the current window size.

In the picture above, you'll find that the inner size is always 1024x768 which is the same as what in tauri.conf.json, but the outer size changes very differently.
So, it seems to be a bug of tauri v2.0-beta... But it can be a simple workaround by changing it into self.outer_size().
https://github.com/tauri-apps/plugins-workspace/blob/v2/plugins/window-state/src/lib.rs#L269

Hey guys, I found some PR related to this bug.
https://github.com/tauri-apps/tauri/pull/8280/files#diff-9fff33774bba86e0056dc083e3ec624f275b9d05427031c76dc1b313ade17a82R736
In this PR, Tauri 2.0 beta supported multiple webviews in a single window, but some functions about get_webview were marked as unstable causing the get_size function to return an unexpected value without unstable feature. So, you just need to enable the unstable feature in Tauri's dependency and this plugin could work normally.
// enable unstable features
tauri = { version = "2.0.0-beta", features = ["unstable"] }

Finally, I'm not sure if the unstable flag should be removed in Tauri, so I just created a PR to this repo to update docs in v2 README to workaround it. https://github.com/tauri-apps/plugins-workspace/pull/1086

I can confirm that this bug exists (MacOS). Maybe because the WindowEvent::Resized is missing from the code?
https://github.com/tauri-apps/plugins-workspace/blob/c013fa52cd66885cf457a64e75373cb2066bc849/plugins/window-state/src/lib.rs#L369-L388

Can someone confirm whether this is still an issue in the rc version?

I reproduced this issue in the plugin-workspace example. I found that the outer size height is being stored in the inner size.
1.

2.

@amrbashir @FabianLars Hey👋, I just used the plugin in v2.0.2 and the terminal keeps printing windowDidResize related output!
.plugin(
    tauri_plugin_window_state::Builder::default()
        .with_state_flags(StateFlags::all() & !StateFlags::VISIBLE)
        .build(),
)

https://github.com/user-attachments/assets/405a2918-531e-488c-89dd-fbeb0bf39d0b

On windows, when setting decorations to false, the window size is not preserved

the project clash verge rev uses the window-state v2.2.0，but it can't save position and size
https://github.com/clash-verge-rev/clash-verge-rev


Added ts version implementation of StateStorage

StateStorage already has an implementation of the rust version in cyfs-lib, and needs to have an equivalent implementation in ts

ts StateStorage implementation added at 01444480


Provide Support documentation to end user (Onur)

💡 Description
See email
⚔ Parent Epic / Related Tickets
No response

We can try to use peppi with one of the datasets proposed in this page https://sbn.psi.edu/pds/archive/orbital.html
The first collection is available in the registry.

@collinss-jpl will re-use the code provided in ticket #60 to one of the datasets selected by SBN.


ehancement eliminate project in the post process phase

Proposed changes
Problem summary
Remove those projects that used for column pruning only and don't do any expression calculation, So that we could avoid some redundant data copy in do_projection of BE side.
Checklist(Required)

Does it affect the original behavior:

[ ] Yes
[x] No
[ ] I don't know

Has unit tests been added:

[x] Yes
[ ] No
[ ] No Need

Has document been added or modified:

[ ] Yes
[x] No
[ ] No Need

Does it need to update dependencies:

[ ] Yes
[x] No

Are there any changes that cannot be rolled back:

[ ] Yes (If Yes, please explain WHY)
[x] No

Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 34.94 seconds
load time: 440 seconds
storage size:<PHONE_NUMBER>4 Bytes
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20221122113000_clickbench_pr_50727.html


Import annotation from csv feature, is it still available?

This resource shows that once creating an annotation layer by ctrl+click new layer, there's a button to import or export annotations to csv.  https://brainmaps.princeton.edu/2020/10/new-neuroglancer-feature-import-annotations-from-csv-files/

However, this does not show up in my present neuroglancer UI.

What is the current method to import annotations from a csv if it's no longer available?

This is related to a long ago fork of the seung-lab branch with mainline google.  That documentation refers to the seung-lab branch.  There is no GUI right now for upload/download of annotation layer annotations.  You have to parse out the json in the state using the {} tool in the upper right.  To create states there are some python tooling available via neuroglancer python, or pipelines build on top of it like nglui (https://pypi.org/project/nglui/).
Note annotation layers of most types can be dragged from seung-lab windows to mainline google, so a workaround is to use seung-lab branch (deployed at neuromancer-seung-import.appspot.com) and then create the annotation layer and then drag it over to a mainline neuroglancer window.  Note there are more annotation features in seung-lab branch that aren't part of mainline so this only works with certain basic types of annotation features.

Hmmm, given that the json is converted into a web URL, do you think there is a limit to the number of annotations before the URL becomes too long for the browser to handle? I'm working with MERSCOPE cell coordinates that number in the millions. I may need to find an alternative way to perform this annotation.

I added 1000 annotations using the example "python/examples/write_annotations.py"
The spots tend to disappear. I might need to optimize the sharding parameters more. I tried a larger chunk size but it's made things worse.
https://github.com/google/neuroglancer/assets/10882060/373349c2-273d-4288-8104-fe604258fb8b


How to collate a mixed list of file

This isn't strictly and issue, but I am really grasping at straws here. If there is a better place to ask for help or you don't offer help please close this issue and I can keep working on my own. Just thought I would try posting this (you've been very helpful in the past! and I very much appreciate it)
I am working on a pipeline that interacts with NCBI SRA data. I basically have a list of SRR id's which correspond to fastq files. I read in my list and use an @originate decorator to download the files one at a time and feed them in. I will be getting alot of them so my plan is to download, process and delete the information all in the pipeline so I don't use all my HDD space.
Here is what I have so far:
total_srr_list = map(lambda x: options.output + x +".fastq", total_srr_list)

@originate(total_srr_list, fqd, output)
def download_fastq_files(srr_file, fqd, output):

    srr_number = path.splitext(path.basename(srr_file))[0]
    assert srr_number.startswith("SRR")
    fqd(sra_number)   # short hand for the NCBI fastq-dump command

Basically I take my list of SRR ids which looks like:
["SRR000001", "SRR0000002", ..... ]

And turn it into this (adding the path and .fastq suffix):
["./SRR000001.fastq", "SRR0000002fastq", ..... ]
I feed this into my originate command, and call fastq-dump on each file. fastq-dump takes only the "SRR00001" part and automatically names the file it downloads as .fastq so I have to pull the number bit back out. The issue is that SRR numbers can point to PE or SE data and if it's PE fastq-dump will end up making a _1.fastq and _2.fastq file, which wont match my originate list and will be lost as far as I can tell. I don't know ahead of time which SRR's are PE and which are SE. I'd like to check in my originate function download_fastq_files to see if paired end files exist and modify the output or redirect that output to a different task. I am struggling on a way to implement this without ruining the concurrency.
Really just looking for some advice, again understand if your busy or don't do this kind of thing. Also if you have ever heard of Gitter it's a great service to foster an ecosystem for stuff like this. I know I'd be on the ruffus channel if there was one and I could probably tackle some basic questions people might have.
Thanks!

Realized there is a google group, closing


Suit workstation dupe?

Could be related to tfc through

How did you get from A to B with any of these?

just wear them and open the suit workstation

seems to be an TFC issue


Test configuration management on main device

Proposed changes

Add Cumulocity configuration management integration tests (for the main device)
Types of changes

[ ] Bugfix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[x] Improvement (general improvements like code refactoring that doesn't explicitly fix a bug or add any new functionality)
[ ] Documentation Update (if none of the other choices apply)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Paste Link to the issue

Checklist

[x] I have read the CONTRIBUTING doc
[x] I have signed the CLA (in all commits with git commit -s)
[ ] I ran cargo fmt as mentioned in CODING_GUIDELINES
[ ] I used cargo clippy as mentioned in CODING_GUIDELINES
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] I have added necessary documentation (if appropriate)

Further comments

Beware that the refactoring of configuration management  has been merged. Hence, if we want to compare before/after behavior we will have to compare with the 0.10 release.

The test looks fine. A few more tests cases that could be added for improved coverage (not necessarily to be added in this PR itself):

Updates to the c8y-configuration-plugin.toml are automatically picked up and the supported config list is updated
Set non-existent config file with the desired file permissions
Updating c8y-configuration-plugin.toml from the cloud updates the supported config list automatically

I can think of some more negative test cases like setting broken/invalid c8y-config-plugin.toml, setting non-existent config-type etc. But, not sure if they're all relevant here at a system test level.

I just re-read the list of extra test cases and I think it would be definitely worthwhile extending this PR to cover them, thanks for the suggestions.

For "sed", I can see the notify stream has events for the tmp file creation as well as renaming the tmp file to the c8y-configuration-plugin.toml but the notify stream match (crates/common/tedge_utils/src/notify.rs:73) drops the modification events which renames the tmp file to c8y-configuration-plugin.toml because we only match on modification events which have kind "data" but they're multiple event types created here which are Modify(Name(From)), Modify(Name(To)) and Modify(Name(Both)) the types can be seen at https://docs.rs/notify/latest/notify/event/enum.ModifyKind.html and these events are dropped so I'm not surprised this fails.
@reubenmiller On the other hand when manually testing the "mv" I can see appropriate logs all the way from the notify stream to the ConfigManagerMessageBox sending a message with an updated config but the Robotest fails and I'm not why.

@reubenmiller On the other hand when manually testing the "mv" I can see appropriate logs all the way from the notify stream to the ConfigManagerMessageBox sending a message with an updated config but the Robotest fails and I'm not why.

There is actually a different here. I posted a comment describing when a move will work and when it won't. https://github.com/thin-edge/thin-edge.io/issues/1896#issuecomment-1516382281


Fix 3 Duplication, 1 Style issues in source\vlc\cpp\include\vlc\plugins\vlc_block_helper.h

CodeFactor found multiple issues:
Duplicate Code

[ ]  source\vlc\cpp\include\vlc\plugins\vlc_block_helper.h:331-369
[ ]  source\vlc\cpp\include\vlc\plugins\vlc_block_helper.h:281-319
[ ]  source\vlc\cpp\include\vlc\plugins\vlc_block_helper.h:283-303
[ ]  source\vlc\cpp\include\vlc\plugins\vlc_block_helper.h:333-353
[ ]  source\vlc\cpp\include\vlc\plugins\vlc_block_helper.h:224-244
[ ]  source\vlc\cpp\include\vlc\plugins\vlc_block_helper.h:392-410
[ ]  source\vlc\cpp\include\vlc\plugins\vlc_block_helper.h:339-357
[ ]  source\vlc\cpp\include\vlc\plugins\vlc_block_helper.h:289-307

Redundant blank line at the end of a code block should be deleted.

[ ]  source\vlc\cpp\include\vlc\plugins\vlc_block_helper.h:507

oop


Where to put Shell Extensions / Windows Enhancements

Which category is a library that supports developing shell extensions (like registry, COM-Server, Context Menu) or Windows Enhancements?
There is no "COM (Component Object Model)" neither a "Registry" nor a "Shell Extension" or "Windows Explorer / Browser" category, yet.
I'd like to add SharpShell for managed Shell Extensions
"SharpShell makes it easy to create Windows Shell Extensions using the .NET Framework."

PR and create a new category if you like


AFL crash

The AFL fuzz I started in #37 found a crash (after 37 days and 2 cycles!) where the decompressed data does not match the input (with CompressionOptions::default()). I'll look into in the next few days and also PR the fuzz binary. In the meantime here's the crash input.
id:000000,sig:06,src:000831,op:havoc,rep:64.zip

Oh wow, will look into it in a week when I have time if no one else has found the issue by then.

Last I checked there were 3 more unique crashes. I should note all of these are just the compression roundtrip data not matching the original data; no crashes in the library. I'll upload them next time I'm at that computer.

The other 3: crashes.zip


Set no delay for the first connection

Coverage remained the same at 94.324% when pulling ad9d0330685087276b24094a9f9f5fef94f2792e on quentinus95:patch-1 into c64d32fbeaf70199e7b82817476f4d9f3e35ef39 on pladaria:master.

Do you see a way to cover it?
I tried:
const wss = new WebSocketServer({port: PORT});
const ws = new ReconnectingWebSocket(URL);

t.is(ws._getNextDelay(), 0);

ws.close();
wss.close();

It would be a little flaky but you could do something like take a time reading before creating the websocket, create the websocket with a high minReconnectionDelay, and then do an open listener that asserts that lower than a reasonably short time has passed.  Not really sure if there is a cleaner way.
Also, this behavior is blocking me from being able to use this library, so let me know if I can do anything to help ferry this through

@quentinus95 I haven't had a chance to dig into the internals here and see how it could be covered by tests, but you must have verified the behavior manually? Maybe try to think of a way to re-create your manual verification within the tests. Perhaps using setTimeout to check the actual timing.
@phil-flyclops Maybe try adding a test case for it?
Haven't heard yet from @pladaria , his approval would seal the deal.

Please merge. :-)

Looks like @pladaria is no longer maintaining this lib. Any active forks?

I can fork it and deploy it to npm with the fix if you want me to.

@quentinus95 Publishing this as a fork to npm would be great, or even just commit the compiled files to your fork so people could install it from your github until this is merged.

For situations like this, the patch-package module is fantastic. It lets you put a temporary patch on an npm module as part of the install process for that module (so it is reapplied each time you install/delete/update any modules). It means that you don't need someone to publish a fork if you're able to make the change to the compiled module code yourself. Since this is a pretty simple change, it's relatively easy to apply it to each of the dist folder files.

I hope this can be merged soon :(

@pladaria thanks for a great lib! are you still maintaining?
can we expect a merge+release anytime soon?

if you're going to put out a new version, can you include this fix as well?

Thanks!


Optimize Role model/dataset

The Role model is not backed by a dedicated table, but a dataset that is a UNION of eight individual roles tables. When filtering for roles, this was done by adding WHERE conditions to the overall dataset, which resulted in slow query executions. A more efficient approach is to move the WHERE conditions into the individual datasets per role.
This commit customizes the Role model/dataset. The creation of the UNIONed dataset is moved into a dedicated class (RoleDataset) that supports building a dataset with filters (i.e. WHERE conditions) per role (i.e. individual table). The where method of the Role dataset is overridden and uses Dataset.from ([1]) to change the dataset's source. It replaces the source with a new dataset built with filters per role.
As where calls can be chained, the filters need to be kept in the dataset instance (cache) and the source dataset needs to be built again on each where invocation with all the filters, i.e. previous and new WHERE conditions.
Furthermore fully qualified identifiers (table name and column name) have to be adapted; as the WHERE conditions are applied on the individual roles tables, no table name prefix is required and thus removed from the identifiers.
Some filters can now be handled in a more efficient way. When filtering for a specific role type, the corresponding dataset gets a WHERE 1 = 1, whereas all the other datasets get a WHERE 1 = 0, meaning they never return any rows. Something similar is done when filtering for organizations or spaces; the opposite role types get a WHERE 1 = 0 as they don't have the requested id field.
As there might be filters that still should be applied to the overall dataset, where invocations with a block (aka. virtual row block) are treated as before, i.e. applied at the end.
Drawbacks:

The current implementation of the custom Role model/dataset is rather strict with regards to allowed filter expressions. This means that if some functionality is added (e.g. new or different filter), the custom Role model/dataset needs to be adapted. This was done by intention to ensure that every code path is tested.
To limit the number of different filter expressions, invocations of first(cond) and find(cond) on the custom Role model/dataset have been replaced with where(cond).first which is semantically identical.

 Is there any reason it is still a draft?

The main reason for keeping this as a draft was that I wanted to perform more performance testing. As you run such tests in your environment, it should be good to be merged.


research: Add comparison between opendal and fsspec

fsspec is the specification that python filesystems should adhere to. Let's add some comparison between opendal(-python) with fsspec. Also, we can contribute opendal to fsspec as a new backend!

No actionable task. let's close.


Nonlinear Reservoir Outlet Max Flow

Adding nonlinear reservoir max outlet flow parameter.
Additions
Adding nonlinear reservoir max outlet flow parameter.
Testing

Added corresponding unit test.

Notes
PR #56 needs to be merged before this one.
Fixes Issue #54
Checklist

[x] PR has an informative and human-readable title
[x] Changes are limited to a single goal (no scope creep)
[x] Code can be automatically merged (no conflicts)
[x] Code follows project standards (link if applicable)
[x] Passes all existing automated tests
[x] Any change in functionality is tested
[x] New functions are documented (with a description, list of inputs, and expected output)
[ ] Placeholder code is flagged / future todos are captured in comments
[ ] Project documentation has been updated (including the "Unreleased" section of the CHANGELOG)
[ ] Reviewers requested with the Reviewers tool :arrow_right:

Testing checklist (automated report can be put here)

Target Environment support

[ ] Linux

PR #56 has been merged into master. I rebased on top of master from that merge.


Make the commit/revision selection optional

After selecting the branch you have to select a specific commit.
This should be optional (you can just specify the branch).

Maybe we should/could fill the missing information on the backend side.

Checked in branch and works well in general. There is only a caveat when the targeted branch is distinct from main (details next)
Cases checked:

Pushing the app from the second commit from not main branch fails to display in UI the correct branch and commit selection. (FAILED)
To check:

epinio push --name testatpp-gitlab-cli-1-nomainbranch-from-nofirstcommit --git https://gitlab.com/richard-cox/epinio-sample-app,ee069123

Result:

Pushing the app solely specifying repo name correctly takes main branch as the default and the last commit (OK)

epinio push --name testatpp-gitlab-cli-2 --git https://gitlab.com/richard-cox/epinio-sample-app

Result:

Pushing the app to specifying a branch different from the main and not commit number correctly points to the latest commit (OK)

epinio push --name testatpp-gitlab-cli-3 --git https://gitlab.com/richard-cox/epinio-sample-app,lots-of-commits

Pushing app specifying 2nd commit but not the main branch correctly points there on the main branch (OK)

epinio push --name testatpp-gitlab-cli-4-nonspeficied-mainbranch-2ndcommit --git https://gitlab.com/richard-cox/epinio-sample-app,bb688311

Result:

Pushing the app with git tag, specifying a tag belonging to a branch distinct from the main (branch test here) fails to show the right selection in UI. (FAILED)
To reproduce:
Go to example-go repo
Run:

git checkout test
epinio push --name testatpp-gitlab-cli-6-tag --git https://github.com/epinio/example-go,v0.0.1

Result:

Pushing app specifying git tag on commit different from first one and being in main, works:

epinio push --name testatpp-gitlab-cli-7-tag-main --git https://github.com/epinio/example-go,v0.0.2

Result:


Markdown massacre

Drop the instruction for Windows and various lint fixes

@mvillis What do you think? Windows folk should know what they're getting into? :)

Coverage remained the same at 100.0% when pulling 36594cec8921abbb5b844a3758be3e7310d46681 on markdown-massacre into d33f0b4694c89d2ee9690986b2162be5bb70ab57 on master.


Initial stab at a UMD-compatible structure

Probably not safe to merge as-is, but I took a stab at porting to a TypeScript UMD-style module
Refs #83

Thx for your effort 👍 very much appreciated!
I'm moving atm and there's no internet connection yet nor a desk or anything to work at home so I can't review it right now ;) will take at least a week till I can get back to this.

No worries, ignore this until you're all unpacked and settled in :)
I did notice one major problem with this branch when combined with WebPack 2, namely that WebPack can't handle TypeScript-output UMD modules and turns it into a require('.') call that breaks the entire bundle.
As a workaround for that, I made a branch that's using rollup.js to generate the UMD module:
https://github.com/timruffles/ios-html5-drag-drop-shim/compare/rewrite...dpogue:buildsystem
Don't really want to open a PR that replaces the entire build system without discussing it though 😛
I've confirmed that it works with WebPack (although the sourcemaps for the min.js file are causing problems that I need to look into) and will try to do some more testing with the included demo/test cases.

Finally had time to look at the changes needed for full UMD-support (AMD, CommonJS, Global) and TypeScript's UMD-module does not support a globals fallback. Further it needs manual additions to the created d.ts-files..
That's a bummer.. Should've read about the detailed capabilities of TypeScript's UMD support earlier. Having to fiddle with the d.ts-files each time a release is made is not really what I was aiming for. Also dead-code elimination with uglify does not work once the code is wrapped in the UMD function.
Wishlist

supports AMD, CommonJS, Global
automatically enhance d.ts-file(s) with needed export as namespace line
does not interfere with minification

With this in mind I think TypeScript's UMD setting is not the right thing for this library. Rather we need some build step on the .js output that adds the appropriate UMD wrapper function and also adds the extra line to the d.ts
Another approach would be to generate separate build outputs (Global, CommonJS, ES2015).

Would this be solved by using webpack, browserify etc after TypeScript?

Yes (well, I used rollup to generate the UMD module): https://github.com/timruffles/ios-html5-drag-drop-shim/compare/rewrite...dpogue:buildsystem

@dpogue so this PR is looking good to you? @reppners anything else required?

No, I'll open a new PR with the rollup-based buildsystem: #98


Removing Keybase app mean I can't add any more devices again

I removed the Keybase app from my phone. Now it is impossible for me to log in to the app again since it requires my phone to verify the login. There doesn't seem to be a way to remove the device from Keybase.

Log in to the website
Click cog icon on your profile.
Click revoke all devices.

The cog menu only gives these options:

Reset your keys and start from scratch
Edit your account/settings

I'm super confused here.
The only device listed for me is one I've just securely destroyed -- but I still have my private key offline.
How do I get back to the point I was at before I had that device associated with my account?

I'm super confused here.
The only device listed for me is one I've just securely destroyed -- but I still have my private key offline.
How do I get back to the point I was at before I had that device associated with my account?

The same question is asked repeatedly here: https://github.com/keybase/client/issues/8405
The answer is always just "reset everything and start from scratch.  Also, make sure you carry a 'paper key' in your wallet'" 😂


Deleting multiple messages in the Trash folder does not work correctly

When I pass the uid array and run it through foreach to move to another folder it works fine.
But when I pass the uid array and pass it through foreach to delete messages, then all messages in the Trash folder are deleted, not just those that were passed in the array!?

(At the same time, deleting an array of messages in the Spam, Drafts folders destroyed () method works
/ or if you transfer only one message to the Trash folder, then the destroyed () method works well)
How can i work with delete () of multiple messages in Trash folder?
I get:
500 (Internal Server Error)

Hi @AnastasiaDolgopolova ,
many thanks for your report. Unfortunately this isn't the right repository. Please head over to https://github.com/Webklex/php-imap/issues/new?assignees=&labels=&template=bug_report.md and create it over there.
Please try to answer as many of the questions mentioned in the issue template as possible. Especially regarding the used software versions.
Perhaps this issue is related to https://github.com/Webklex/php-imap/issues/106?
Best regards,

The issue has been moved to https://github.com/Webklex/php-imap/issues/182


Typedoc is failing to build documentation

After the change, I saw a type-resolution issue within onEnd tests, which I fixed according to what it expected, but then typedoc stopped working, which apparently relies on running tsc, which fails for those tests also.
@RebeccaStevens Any idea why TSC is now failing, and how else that test can make use of type IIterationSummary?
If I roll the changes back, it looks like this:

i.e. it cannot see the type, though it works, and typedoc also builds, but in the current code, it looks correct, all valid, but typedoc fails because so does TSC. Any idea what it really should be?
This looks like a conflict between TSC compiler and the type changes, which only manifests when generating documentation, which relies on running TSC.

I have reverted the test code into the master, because I need to be able to build documentation. In the meantime, I've noticed this issue isn't limited to onEnd operator. The same issue can be seen in tests for operator timing.

Sorry, I'm not sure I follow.
So you're saying you can't build the docs? How are you building them? With yarn docs?
That's working for me without issue.

As per above, I reverted the code back to your own version, so I can build documentation, by running npm run doc.
But as you can see in the screenshots above, the IDE fails to understand tests for operators onEnd and timing, and so they come up in red. If it is an IDE issue somehow, it would be an odd one.
I can fix the issue by how types IIterationSummary and IValueTiming are used, but if do, and the IDE likes it, but then tsc and npm run doc both fail, and I cannot generate documentation.

After a bit more playing with it, I think it may be an IDE issue after all, something with failing to pick up the types or linting issue, I'm not sure. But after restarting the IDE, I cannot see the issue again, which is quite odd.
Therefore, I'm just going to close this.
@RebeccaStevens Thank you for looking into this!


feat: Add environment variables

Hi,
Setting configurations via default environment variables is very usefull, so I added a way to directly configure logRocket with env vars and updated dependencies.
Regards,

@Zevran Due to the reason that your PR ran into conflicts, I ended up merging it manually myself. The changes have been published in version 1.2.0.
Thanks for your contribution.


Not all available modules for a meeting shows up

Trying to add a user's module to a meeting, the expected module didn't show up in the avilable modules list.

The problem was that only the first module name in a package was displayed. This is now changed so all modules in a package is listed.


feat(core): DTIS-261 meerkat p2p proof of concept

Closing as we are removing DIDComm support on develop. Can be re-opened with a restored branch in the future if ever needed.


[Vssue]사내 Private project(운영지원)

https://rick00kim.github.io/kururu-blog/posts/projects/support-private-dev/

Test Comment

Is that regist to issue?


Aws redshift proxy

adds the ability to proxy redshift to the client; depends on aws auth client proxy only

This is awesome!
It may take me a week or two to merge, there are a couple things I'd like to address outside of this PR and then rebase this on top of that -- the primary concern is just around making it easier to extend/add other engines (we've been thinking about adding elasticache/redis support).
There are a couple things we need to work out to make it happen:

For the client TUI, we probably need a way to segment by the kind of resource being accessed, i.e. rds-auth-proxy postgres client, rds-auth-proxy redis client so we spawn the right kind of proxy.
For the both the server/client, we're going to want a way to enable/disable engines, so you don't have to overload an IAM user or role with permissions if you don't want to enable the engine.
We probably want to avoid clobbering target names, we're already at risk of doing that if the user manually specifies a target in the config - it just becomes more likely as we add more engines.


Set trust_env=True for aiohttp to repsect http_proxy env vars

A simple patch that prevent developers (specially in China) getting confused when switching from sync apis to async apis

Thanks for putting the effort into opening a PR, sorry it wasn't merged!
In the v1 of this library we've unified the sync and async clients to use httpx which means there won't be any confusion due to differences in configuration.


Ldap filtering

Description

Types of changes

[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] New feature (non-breaking change which adds functionality)
[ ] Bug fix (non-breaking change which fixes an issue)
[ ] Enhancement (improves an existing feature and functionality)
[ ] Cleanup (Code refactoring and cleanup, that may add test cases)

Screenshots (if appropriate):
How Has This Been Tested?

@DaanHoogland additional tasks requested:

Write an integration test under test/integration/plugins/ (or suitable path) which should assume an external AD server who settings/details are either provided by test_data.py or another config file (or changes in the file itself)
Fix travis failures etc. and run smoketests for regression testing

@rhtyd can you have another look?

@borisstoyanov I removed the ldif files not reff'd.

@DaanHoogland I'll schedule a review for this and few other PRs later this week or next.

closing this in favour of https://github.com/apache/cloudstack/pull/3694


Python3 support set notebook kernels cleanup

This is a clean version of #315.

Appveyr builds: https://ci.appveyor.com/project/willirath/parcels/


feat: set err.headerSent before app error event emit #919

cherry-pick from https://github.com/koajs/koa/pull/919

no idea why codecov isn't working here


Compatibility with v1.10.19

Is this project or any fork compatible with v1.10.19 of DataTables.Net?

Haven't tested it I'm afraid. Happy to accept a PR updating it though!

Ok thanks. The current version of this project is working fine for me right now. I don't have time at the moment to do a PR to get it to work with the current version of DataTables.Net - I assume an update on the jquery column filter plugin would also need to be updated.


No longer needed.


ERROR - FFmpeg is not installed

i get this error when i record more than 2 lives

but ffmpeg is installed well and last version

actually it's pretty random, somtimes shows this error when i record a second live other times when i record a third one.... sometimes shows this error for one special user

yeah i'm limited to record two lives, don't get why

pip install ffmpeg
pip3 install ffmpeg

i try install ffmpeg

uninstall your curent python and try install python 3.10

I tried it on 2 computers and 3 different version of python 3.9, 3.10, 3.11 and have the same issues. It didn't worked for a single live

You have to use a different type of url like this : https://www.tiktok.com/xxxxxxx/live?enter_from_merge=others_homepage&enter_method=others_photo

Fixed in version 5.4


bug: inconsistency of index privileges between rw and pg

Describe the bug
In rw, when a superuser creates an index on a table, the owner of the table cannot access this index then, different from pg.
Error message/log
No response
To Reproduce
No response
Expected behavior
No response
How did you deploy RisingWave?
No response
The version of RisingWave
No response
Additional context
No response

cc @yezizp2012

https://github.com/risingwavelabs/risingwave-docs/pull/1541#discussion_r1400020306


Debugger is crashing the App

My App was under a breakpoint in IntelliJ IDEA and suddenly the App closed on my Android Emulator, this was the error message:
F/libc    (31521): Fatal signal 11 (SIGSEGV), code 128 (SI_KERNEL), fault addr 0x0 in tid 3067 (Thread-5), pid 31521 (yapp.myapp)

Build fingerprint: 'google/sdk_gphone_x86_arm/generic_x86_arm:9/PSR1.180720.117/5875966:user/release-keys'
Revision: '0'
ABI: 'x86'
pid: 31521, tid: 3067, name: Thread-5  >>> com.myapp.myapp <<<
signal 11 (SIGSEGV), code 128 (SI_KERNEL), fault addr 0x0
eax b4fa4b52  ebx 64c8fdda  ecx cb57ef3c  edx 64f27632
edi 64d5a09a  esi 7fada462
ebp 7fada4fa  esp 7fada7ae  eip ef1a1ce3
backtrace:
#00 pc 0001fce3  /system/lib/libc.so (sigsetjmp+99)
Lost connection to device.
Failed to send request: {"jsonrpc":"2.0","id":"1677","method":"resume","params":{"isolateId":"isolates/3688252752053767"}}

Flutter 1.12.13+hotfix.8 • channel stable • https://github.com/flutter/flutter.git
Framework • revision 0b8abb4724 (4 weeks ago) • 2020-02-11 11:44:36 -0800
Engine • revision e1e6ced81d
Tools • Dart 2.7.0

Duplicate of #27077


Fix for crash of MaxQuant wrapper when using TMT data and PTXQC report

This PR fixes the PTXQC report generation when using TMT input data. In addition, PTXQC was updated to the newest version and isobaric labels were moved into tokens. A test for PTXQC was added.

Merci!


Blending currently gamma-incorrect

Maybe i'm missing something but it seems to me that wlroots (and weston, compton, ...) actually do blending of surfaces incorrectly. Investigated with rootston.
This is how blending with rootston (and sway and ever compositor that builds upon wlroots) looks today (two different surfaces overlapping, the top one with low alpha):

I haven't followed the wayland colorspace discussion too closely but i guess we assume that all input we get from clients is roughly in srgb space, right? At least that's what pretty much every program out there outputs. But we don't transform it back to linear space before blending surfaces. That means we blend in srgb space, which is wrong and looks bad. An article that explains it nicely is this: http://blog.johnnovak.net/2016/09/21/what-every-coder-should-know-about-gamma/ (see especially the section about blending).
I noticed this when writing the vulkan renderer and had to select a colorspace for images and framebuffer (vulkan is explicit about it) so i tried interpreting textures as srgb and also output srgb (which means that when sampling we get the image data in linear space and also blend in linear space) which gives this result:

The thing is, pretty much every compositor out there does it like wlroots at the moment so this is probably rather a discussion about expected behavior. Below are compton on i3 and weston with the same two example surfaces:

I guess it's obvious in this case which result is "correct" though. If we change this we should probably at least provide an option for the user to choose since wlroots would then be doing it differently than everyone out there and everything with alpha looks quite a bit different. If this is really an issue and not just a misunderstanding on my side, we should probably discuss it with the weston folks as well. Although i only tried it with vulkan, a patch for opengl shouldn't be much harder (make the framebuffer srgb and interpret textures as srgb), i could dive into that.
Do you agree that it currently is an issue? If so, how should we handle it? My idea would be to allow to choose on renderer creation whether or not it should blend correctly or use the legacy mode for compatibility. And then compositors can expose that in their configuration somehow. It's probably more of a temporary solution anyways until wayland gets more elaborate colorspace negotiation support.

It's actually really vague as to whether a client buffer is in sRGB or linear RGB. It's not actually defined anywhere. I think the prevailing assumption that everything is in linear RGB, but it's more likely than not that people just didn't really think about it that much (well, at least I didn't).
I think that colour management protocol being discussed is the solution to this.
Proper colour management and blending is definitely something I agree that we should be working towards.

hm ok let's wait for the color management protocol then, hopefully it'll clear things up.

Just FYI, most clients simply assume sRGB and most monitors are somewhere near sRGB so even color managed applications produce images with near sRGB gamma. In the absence of a color management protocol blending should assume sRGB and apply degamma before blending.

I think I stumbled on this specification hole while writing a client application with transparent backgrounds. In my case, blending seems to require premultiplied alpha in the wl_surface to produce the normal over operator. Is this expected?
I'll be waiting for the color management protocol to settle down and define this clearly. Until this happens, is there any sort of documentation or source reference that shows how wlroots does it?

blending seems to require premultiplied alpha in the wl_surface to produce the normal over operator. Is this expected?

Yes.

Ref EXT_sRGB_write_control for the GL side of things

Can confirm that unless otherwise specified clients send sRGB, not linear.

@nyorain, do you have the source of your test client somewhere?

GL_EXT_sRGB is usable during texture uploads, however it can't be used when importing DMA-BUFs. So we can't use it to gamma-decode textures coming from clients and gamma-encode FBOs.
I was about to give up, but then found out about EGL_KHR_gl_colorspace and EGL_EXT_image_gl_colorspace. I'll try to see whether it helps.
Another option is to manually write up the gamma encoding/decoding in the shaders, however that will have a performance impact.

@nyorain, do you have the source of your test client somewhere?

It's here but it's old and you are probably better off just pasting the drawing code into your own sample framework.

Another option is to manually write up the gamma encoding/decoding in the shaders, however that will have a performance impact.

Using hardware decoding would be nice but the performance impact shouldn't be too huge either way, it's not much more than a pow (see e.g. here for an efficient implementation) and often done manually in GL. In Vulkan, we should be able to import as SRGB.

I've incorporated the test pattern from the article your linked above into wleird: https://github.com/emersion/wleird/commit/06664c180c028068e5cf7ae19317fea209d4a209


Feature/unity alpha

Android support for the Unity 2019.3 new export format Unity as a Library
Fixes  #10 (on Android at least)

Thanks, @thomas-stockx reviewing the PR

@thomas-stockx I haven't tested the Unity as a Library though, but doesn't it disable the ability to embed in a section of widget or screen, since from what I've read, it forces the app to go fullscreen?

@juicycleff Passing an activity to the UnityPlayer forces the app to go fullscreen, which was already fixed in https://github.com/snowballdigital/flutter-unity-view-widget/pull/14.
It's independent of Unity as a Library (which is just an architectural change of the exported project, no actual code changes)

Hi @juicycleff , the Unity as a Library web page indeed states:

Unity as a Library supports full-screen rendering only; rendering on only a part of the screen is not supported

But that is not correct, or at least with the Flutters PlatformView solution it's perfectly possible or maybe they mean they are not really supporting it in their pro-plan... I have iOS working now, but  waiting for this PR to be merged, otherwise there is an annoying merge conflict in the README file.

@juicycleff Added a new example gif to the README, which was built with Unity as a Library.

Thanks, fo the feedbacks @thomas-stockx  and @krispypen and I did test it and it's working. @thomas-stockx great contribution. I will add the contributor's section today and will work on ios next this weekend I believe. Would love to see where the other contributor has gone with iOS :)


Adding some handy alias

@YanDeLeon LMK if this looks good. I'm adding here some alias that could come handy. THanks!

@YanDeLeon LMK if this looks good. I'm adding here some alias that could come handy. THanks!

@paganotoni It looks great !!


New package for AutoHotkey LSP

The AutoHotkey project is only for windows environment.
Describe your changes
AutoHotkey support on windows
Issue ticket number and link

Checklist before requesting a review

[x] I have successfully tested installation of the package.
[x] I have successfully tested the package after installation.

Screenshots

This still needs this: https://github.com/neovim/nvim-lspconfig/pull/3408


Port L1 -> L2a data analysis code from JPL II&T

Many folks at JPL have already done a lot of work on this. Let's not double efforts.
We will wait for JPL to approve open-sourcing this before really getting to it.
Included capabilities functions are:
L1_to_L2a:
This will implement the following steps:
- Separate image from prescan
- Compute bias from prescan, including offset subtraction, and
subtract from image
- Build per-frame cosmic ray masks and remove cosmic rays
- Correct for nonlinearity

Should crop down to 1024/1024 at the end of this process

Should I go ahead and get started on this?

I think @m-samland also had some interest in helping with this. @mygouf perhaps you can divide up some of the work to @m-samland so he can help you with this? You could decide to share a branch where you push code for this.

Ok, let me start working on it and think about how to divide and conquer. Once we have a good plan for L1 to L2a we can use a similar template for higher levels port and implementation. We can chat more in person next week.

a natural way to divide and conquer might be to break up all the functions in the ttr5_analog.py into separate issues. What do you think?

Yes this is what I had in mind. But wanted to wait for your review before going ahead and starting creating new issues.

a natural way to divide and conquer might be to break up all the functions in the ttr5_analog.py into separate issues. What do you think?

Yes this is what I had in mind. But wanted to wait for your review before going ahead and starting creating new issues.

Yes, I am interested in helping out with porting these to the new pipeline to get used to the code base. It would be good to discuss with @mygouf so that we can coordinate!

Closing this issue since we have split it up into sub-issues.