Refactor logging to use a structured logger and log levels

Feature Request
Refactor our logging to use a structured logger and log levels. Structured logging allows us to use a consistent method of logging messages and a way of filtering messages for support. It also allows us to format messages for either the traditional log file that we normally use and like along with JSON messages for consumption by automated log tools like Splunk.
Proposal: Refactor logging to a structured logger and log levels
Current behavior: We use the Go standard log package
Desired behavior: Using the structured logger
Use case: It makes log files easier to follow and filter out messages that may only be a concern to those doing development.

/cc @beckettsean @corylanou

More useful if we also implement #7037.

Yes, #7037 along with log levels would be a killer feature for gathering diagnostic information from customers. It would also allow us to recommend WARN level for production systems and only do INFO or DEBUG when needed.

We should also add the ability to do backoff logging, so if you see the same type of message over and over, it doesn't fill up logs. Things like can't write to remote node showing up 10,000 in a second aren't useful, regardless of log level.

@corylanou my favorite example from a system with a Graphite endpoint that was getting spammed by bad connections. The error [graphite] 2016/05/02 03:44:09 unable to parse line:  : received " " which doesn't have required fields makes up over 99% of the log.
$ wc -l influxd.log
 33376296 influxd.log
$ grep "unable to parse" influxd.log | wc -l
 33232791

So in a 33 million line log file (3.3GB uncompressed), only 143,505 lines are anything other than the Graphite error. About 385 lines per second.

+1 & allow configurable log handlers... as all levels ends into a single writer (/dev/stderr), to automatically catch some unexpected patterns and raise attention to humans to investigate deeper requires parsing of those logs.
Btw, I know structured logging can be expensive and https://github.com/uber-go/zap/ is cheap

@bclermont zap looks really good. I'll be looking into that as a potential solution for this.
A few notes about what I want out of structured logging. First, a step by step plan.

Modify all log statements to use a structured logger. Not necessary to use different log levels or structured logging at this point yet.
Start breaking out messages to use fields and different log levels.

When it comes to the output and what features we want, I think it should be possible to set the log level differently for different parts of the system. I don't think that's needed out of the first version, but we should be able to dynamically change the level of these different loggers too.
I would also like to see it possible to use different output methods. I would personally like the default to be one similar to the current output with colors when a terminal is being used, but I know others want logfmt to be the default. I think making this configurable is easiest rather than deciding on what everyone might want. JSON is definitely something I think should be in there. Even if I don't personally like JSON logging, common devops tools like Splunk have the ability to inject JSON logs and I think it's a decent enough feature as long as it doesn't take too much time to implement.

Thoughts on uber-go/zap. Initially, I really like the idea and I feel positive to see what direction they go until it becomes a stable API. The sad part is I really hope they rethink the current API because it seems to be missing a few key aspects in the publicly exposed API that make me rethink using it at the current moment.
First, for things I like. I like the use of interfaces and I like the options. I think the model for dealing with fields is superior because of fewer allocations and I like the nesting. I also like zap.CheckedMessage and how the various different levels are handled. I like how everything is typed and that interface{} is not used at all (there are a few popular structured logging libraries like log15 that use interface{} that I don't like). I much prefer log.Info("message", zap.String(key, value)) over log.Info("message", key, value). I view the latter as too prone to mistakes and it won't get caught either in compilation or go vet since it's not one of the printf rules. I also like it better than logrus since, even though they use a similar system there, logrus constructs a map to pass the fields and then has to perform sorting rather than just passing those values as a slice and already being ordered. apex/log uses something similar to logrus and I like that better, but it's on par with how zap does it.
The negatives I've run into are a mostly inconsistent API when you try to do something more complicated. It's trivial to create a single logger and build child loggers off of that and have them all write to the same place. But, if you need to have various different levels for those loggers, you are mostly out of luck.
If you need to have multiple loggers for some reason (like having different writing outputs or different levels), you mostly can't share the same output. In order to synchronize the output, you need to use zap.Output() to wrap the output in a writer that's threadsafe. But, if you use zap.Output() to generate an Option, it is constructed in a way where the threadsafe writer is used between multiple writers. So you have to log to multiple different outputs or supply your own threadsafe writer.
Now the log output is stored in a zap.Meta and you can construct one of those using zap.MakeMeta, but this function appears to be useless. There's no way to construct your own zap.Meta and pass it to a zap.Logger. You have to construct a logger with zap.Encoder and zap.Option to construct the logger which leads to the above problem.
You also can't clone the logger in anyway or pass new options to child loggers so you're stuck with whatever options you pass into the root logger.
Maybe we can use it anyway, but any ability to change log levels or use other outputs does not seem like it will be possible unless they change the API a bit. Likely, just allowing the construction of a zap.Logger from a custom zap.Meta is all that is needed. I can go ask on their bug tracker if they are planning to do something like that. I think if I could change just that one thing the library would work perfectly.


How to integrate Multi-LoRA Setup at Inference with NVIDIA Triton / TensorRT-LLM? I built the engine...

I built the engine, and had two separate LoRA layers with the base llama3.1 model. The output from the build is rank0.engine, config.json, and then a lora folder with the following structure:
lora
|
|>0
|      |_> adapter_config.json
|  |> adapter_model.safetensors
|
|>1
|      |> adapter_config.json
|__  |> adapter_model.safetensors
Is this expected? I figured there would be rank engines? I passed these in the lora directory on the engine build:
trtllm-build --checkpoint_dir ./tllm_checkpoint_1gpu_tp1 --output_dir /opt/tensorrt_llm_engine --gemm_plugin auto --lora_plugin auto --max_batch_size 8 --max_input_len 512 --max_seq_len 562 --lora_dir  "/opt/lora_1" "/opt/lora_2" --max_lora_rank 8 --lora_target_modules attn_q attn_k attn_v
Any advice is appreciated.

Hi @JoJoLev ,
I suppose the output folder is expected. You built the eigine with TP=1, and there was one rank0.engine. The LoRA weights are saved in adapter_model.safetensors under each LoRA folder.

Hi @syuoni
Thanks for the response. Yes, I have a rank0.engine file, and config. My question now is that when I deploy on to a container, say NVIDIA Triton, do I have to include the LoRA weights? Or have those been baked in to the rank0.engine?

Hi @syuoni
Thanks for the response. Yes, I have a rank0.engine file, and config. My question now is that when I deploy on to a container, say NVIDIA Triton, do I have to include the LoRA weights? Or have those been baked in to the rank0.engine?

Yes, you have to include the LoRA weights. They are not baked into the engine because TRT-LLM supports multi-lora, so has to load LoRA weights dynamically at runtime.

@syuoni got it!
Thank you! So, after running my engine build I had the aforementioned folder structure, if I was to deploy on NVIDIA Triton, would I include the LoRA weights in the 1/ sub folder where my rank0.engine file and config.json are? Or would I be placed on a different path?
I believe this is the container we are going with on deployment.

Hi @JoJoLev ,
The lora weights under the engine folder (i.e., lora/0/ and lora/1/) are used for ModelRunner(Cpp). For example, run.py script.
To use lora for Triton server, we need to convert the lora weights to the format required by C++ runtime. Please follow the steps shown in this doc. Also, I'd like to remind that the Triton server deployment need to be in the container provided by TensorRT-LLM Backend, see here.

@syuoni , got it. I just converted the LoRA files to the format with tensorrt-LLM. I now have the engine build with lots and have converted the Lora.
When constructing the triton, where do the files go?
Typically with triton there is a structure of:
Path
|
|>1->rank0.engine
|     |_>config.json
|
|> config.pbtxt
Where would the lora files go?

Please see this doc: https://github.com/triton-inference-server/tensorrtllm_backend/blob/main/docs/lora.md#launch-tritonserver
Once lora checkpoints are converted by hf_lora_convert.py, they can be passed to inflight_batcher_llm_client.py via --lora-path

Hi @syuoni
Thanks for the support!
For an update, this works, got the inference running per the tutorial you shared.
Now, the thing I need to configure is how to properly construct this setup to deploy on Sagemaker. For the config.pbtxt in NVIDIA Triton, would I call the Lora paths there? Or would they be in file structure for triton when I deploy endpoint?
Thanks!

Hi @JoJoLev ,
I don't think I've fully understood your questions. I would say that lora paths are not closely related to config.pbtxt.
Once lora checkpoints are processed by hf_lora_convert.py, the processed lora paths can be used for Triton. They should be specified via --lora-path to inflight_batcher_llm_client.py. To clarify, the lora paths should be in the client side.

@syuoni thanks for the info.
So right now, I have the lots adapters, I have built a trtllm engine. And have all the proper files.
I am having difficulty enabling this on Sagemaker with triton right now.
Basically, I am wrapping up the files as a tar.gz, and then deploying on triton container.
So, judging by the config.json, I structure my lora path and the rest of the models paths like the following:
Tensorrtllm
|__>1
|   |>rank0.engine
|   |>config.json
|
|config.pbtxt
|>lora
|>0
|  |>lora1 files
|
|>1
|>lora2 files
If I have this files structure on a tar.gz, will I need to add this to config.pbtxt structure?
And then I guess I can call the Lora directory on the client side as an input request?
Hope this clarifies what I am trying to accomplish on this. Thanks!


backpressure_filter: Correct the filter description

Commit Message:
Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]

/assign @alyssawilk
I am clarifying some typo (copy-paste ? :)) in this filter's description.  PTAL, Thank you!


Trouble getting started with Nuxt

Fresh install, using nuxt with vuetify. Access token and mapStyle are set.
Tried this from #328

/plugins/mapbox.js
/* eslint-disable import/no-extraneous-dependencies */
import Vue from 'vue';
import {
  MglMap,
  MglGeolocateControl,
  MglGeojsonLayer,
  MglMarker,
} from 'v-mapbox';

Vue.component('MglMap', MglMap);
Vue.component('MglGeolocateControl', MglGeolocateControl);
Vue.component('MglMarker', MglMarker);
Vue.component('MglGeojsonLayer', MglGeojsonLayer);

/nuxt.config.js plugins: [ { src: '~/plugins/mapbox', mode: 'client' }, ],

Added stylesheets on the page and globally

css: [
'node_modules/mapbox-gl/dist/mapbox-gl.css', 'node_modules/v-mapbox/dist/v-mapbox.css'
],

Not working for me. I'm getting 2 errors:

[Vue warn]: The client-side rendered virtual DOM tree is not matching server-rendered content. This is likely caused by incorrect HTML markup, for example nesting block-level elements inside <p>, or missing <tbody>. Bailing hydration and performing full client-side render.

v-mapbox.esm.js?5e6e:1291 Uncaught (in promise) TypeError: Cannot read properties of undefined (reading 'container')

Also tried the example here: Base map
Error I get is this

window is not defined

Not sure where to go or what to try from here.

You have to wrap the  component in the <client-only> tag within the template.
Also, try disabling ssr in nuxt.config.ts:
export default {
  # ....
   ssr: false,
  # ....
}

Tried both, it's not having it. No changes. This is what I've got on the page.
<template>
  <v-container fluid pa-0>
    <div>
      <client-only>
        <MglMap :accessToken="accessToken" :mapStyle="mapStyle" />
      </client-only>

    </div>
  </v-container>
</template>

<script>
import 'mapbox-gl/dist/mapbox-gl.css'
import 'v-mapbox/dist/v-mapbox.css';
export default {
  data: () => ({
    accessToken: ACCESS_TOKEN,
    mapStyle: 'mapbox://styles/mapbox/streets-v11'
  })
}
</script>

Noticed another error
DevTools failed to load source map: Could not load content for http://localhost:3000/_nuxt/vendors/pages/map/v-mapbox.css.map: HTTP error: status code 404, net::ERR_HTTP_RESPONSE_CODE_FAILURE

https://codesandbox.io/s/v-mapbox-with-nuxt-lbrt6?file=/pages/index.vue
^^ I just did a repro here, can you verify/validate it with your own nuxt app ?

Not working for me. Same two errors: "Cannot read properties of undefined (reading 'container')" and "Could not load content". I'm using npm, instead of yarn, is it possible that's an issue?
Also, I need the site to be Server Side Rendered, just the map to be client only. Trying to figure out how to get it working that way.

Got it! (well, almost)
It works in SSR with Nuxt 2 importing the Nuxt Composition API, that was the missing link.
Problem now is that I decided to make the switch to Nuxt Bridge (if possible) and now it doesn't work.

@ConnorOnTheWeb: I'm completely refactoring the code to with Vue 3 as base & support for Vue 2 via vue-demi, currently it lies in the directory of another repo, but I am making progress (mostly over the weekend(s) & later in the day off work) surely but (unfortunately) slowly. I still have to research a bit on how to support it for SSR but CSR is already supported out-of-the-box

@vinayakkulkarni I appreciate your work here. I've made v-mapbox load in a satisfactory way, with SSR using Nuxt 2 and the Nuxt Composition API, now just a couple more details continued in the next thread #713


Blobstore Integration

This PR lets users upload a profile picture onto their profile using Blobstore. Right now only a user can see their own picture. The next step is to display the pictures of users' matches although this shouldn't be too challenging since all the infrastructure needed to support Blobstore has been set up in this PR.

FYI: The client id/secret was reset since I wasn't able to completely remove it from git history. The client id/secret found in the repo are no longer valid and API requests using them will be rejected.


IPTT in other languages periods drop down aren't translated

Open IPTT in French or Spanish
Notice that periods drop down values are in English

closing as duplicate of #1776


Slow to start app (windows pyinstaller) due to matplotlib font scanning

font_manager

Fixed? by https://github.com/jimbo1qaz/corrscope/pull/105

seems to be fixed?


Modal border

Addition of a border to modals. Currently modals are blending into the background, the border will make it clear where the edge of the modal is against the dark background.
This applies to all modals.
Desktop:
Border color: interaction/secondary outline (3C3B43)
Border size: 3px
Mobile:
Border color: interaction/secondary outline (3C3B43)
Border size: 2px
Figma:
See mobile and desktop variants as well as examples.
https://www.figma.com/file/bZh7tOiLm6Ls9Hl4RL6qMC5X/Augur-Redesign?node-id=8219%3A265582

Closed with #4673


OSX glfw window blank until re-positioned

I noticed the same issue here: https://github.com/faiface/pixel/issues/140 is present in this project... I figured I might open this ticket so anyone searching for things like, blank window osx glfw might find this article and know that the current workaround is moving the window by 1px on init...
SetWindowPosition((GetMonitorWidth() - GetScreenWidth())/2, ((GetMonitorHeight() - GetScreenHeight())/2)+1);

Is what I rigged up...
Please close this issue if you feel it is not relevant.

Do you have the newest master checked out? #655 ought to fix that.

Shoot, looking now it does look like I am on an older build of raylib, let me double check a newer tag, i am pretty sure it will fix my issue.

@diclophis Did you have time to check whether the issue still exists?

@a3f yea it looks like the fix is good, thanks again for the heads up.
Side note, I have been enjoying using this framework and integrating it with mruby here: https://github.com/diclophis/kit1zx
I am building out a wrapper to hopefully take advantage of some of the DSL like abilities of ruby, crossed with the lightweight nature of this framework to produce small demo/art like applications
class SimpleCube < GameLoop
  def play
    size = 1.0
    cube = Cube.new(size, size, size, 1.0)

    lookat(1, 10.0, 5.0, 10.0, 1.0, 1.0, 1.0, 60.0)

    main_loop { |gtdt|
      global_time, delta_time = gtdt

      drawmode {
        threed {
          draw_grid(33, size * 2.0)
          cube.deltap(Math.sin(global_time), 1.0, 1.0)
          cube.draw(true)
        }

        twod {
          cube.label(global_time.to_i.to_s)
        }
      }
    }
  end
end

SimpleCube.new("simple_cube", 512, 512, 0).play

To produce...


Could not load file or assembly 'LiteDB, Version=<IP_ADDRESS>

On development machine everything is working good.
When pushing code on buildserver to generate release for QA team, getting below error. Please advise to fix it
`[App][1] App exit due to exception: An unhandled exception occurred: Could not load file or assembly LiteDB, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=4ee40123013c9f27' or one of its dependencies. The system cannot find the file specified.
16:27:50.387   [App][1] System.IO.FileNotFoundException: Could not load file or assembly 'LiteDB, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=4ee40123013c9f27' or one of its dependencies. The system cannot find the file specified.
16:27:50.387   [App][1] File name: LiteDB, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=4ee40123013c9f27
16:27:50.387   [App][1]    at ConfigurationCore.DB.LiteHelper.createDb()
16:27:50.387   [App][1]    at ConfigurationCore.DB.LiteHelper..ctor()
16:27:50.387   [App][1]    at ConfigurationCore.Config.RequireImport()
16:27:50.387   [App][1]    at ConfigurationCore.Config.Init()
16:27:50.387   [App][1]    at MainWindow.OnLoaded(Object sender, RoutedEventArgs e)
16:27:50.387   [App][1]    at System.Windows.RoutedEventHandlerInfo.InvokeHandler(Object target, RoutedEventArgs routedEventArgs)
16:27:50.387   [App][1]    at System.Windows.EventRoute.InvokeHandlersImpl(Object source, RoutedEventArgs args, Boolean reRaised)
16:27:50.387   [App][1]    at System.Windows.UIElement.RaiseEventImpl(DependencyObject sender, RoutedEventArgs args)
16:27:50.387   [App][1]    at System.Windows.UIElement.RaiseEvent(RoutedEventArgs e)
16:27:50.387   [App][1]    at System.Windows.BroadcastEventHelper.BroadcastEvent(DependencyObject root, RoutedEvent routedEvent)
16:27:50.387   [App][1]    at System.Windows.BroadcastEventHelper.BroadcastLoadedEvent(Object root)
16:27:50.387   [App][1]    at MS.Internal.LoadedOrUnloadedOperation.DoWork()
16:27:50.387   [App][1]    at System.Windows.Media.MediaContext.FireLoadedPendingCallbacks()
16:27:50.387   [App][1]    at System.Windows.Media.MediaContext.FireInvokeOnRenderCallbacks()
16:27:50.387   [App][1]    at System.Windows.Media.MediaContext.RenderMessageHandlerCore(Object resizedCompositionTarget)
16:27:50.387   [App][1]    at System.Windows.Media.MediaContext.RenderMessageHandler(Object resizedCompositionTarget)
16:27:50.387   [App][1]    at System.Windows.Media.MediaContext.Resize(ICompositionTarget resizedCompositionTarget)
16:27:50.387   [App][1]    at System.Windows.Interop.HwndTarget.OnResize()
16:27:50.387   [App][1]    at System.Windows.Interop.HwndTarget.HandleMessage(WindowMessage msg, IntPtr wparam, IntPtr lparam)
16:27:50.387   [App][1]    at System.Windows.Interop.HwndSource.HwndTargetFilterMessage(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam, Boolean& handled)
16:27:50.387   [App][1]    at MS.Win32.HwndWrapper.WndProc(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam, Boolean& handled)
16:27:50.387   [App][1]    at MS.Win32.HwndSubclass.DispatcherCallbackOperation(Object o)
16:27:50.387   [App][1]    at System.Windows.Threading.ExceptionWrapper.InternalRealCall(Delegate callback, Object args, Int32 numArgs)
16:27:50.387   [App][1]    at MS.Internal.Threading.ExceptionFilterHelper.TryCatchWhen(Object source, Delegate method, Object args, Int32 numArgs, Delegate catchHandler)
16:27:50.387   [App][1]
16:27:50.387   [App][1] WRN: Assembly binding logging is turned OFF.
16:27:50.387   [App][1] To enable assembly bind failure logging, set the registry value [HKLM\Software\Microsoft\Fusion!EnableLog] (DWORD) to 1.
16:27:50.387   [App][1] Note: There is some performance penalty associated with assembly bind failure logging.
16:27:50.387   [App][1] To turn this feature off, remove the registry value [HKLM\Software\Microsoft\Fusion!EnableLog].
16:27:50.387   [App][1] `

Apologize for making noise, issue was on our side.

well, I have the same issue, but on my dev machine. Mind if I ask what the issue was?

Same here.
I have a solution with multiple projects. One of them references LiteDB. My main project and the unit tests only reference the other project and not LiteDB directly. When I converted my  DB project from net47 to netstandard2.0 everything compiles, but the LiteDB.dll is not copied over to the other projects bin\debug folder.
I don't think, that this is LiteDB's problem, but I don't know what I did wrong and found this issue.

Turned out I was a muppet, I had a project called LiteDB (same name as the nuget package), that was a bad idea :-) after changing project name it worked.

Looks like it is https://github.com/NuGet/Home/issues/4488

For anyone googling the title, I had the same error when another NuGet package was using its own LiteDB, and I added this LiteDB in addition to it. In my scenario, it was Monkey Cache package


[WIP] Implement Array in Rust

Replace the mruby-defined Array with an Array backed by a VecDeque.
This patch pulls in https://github.com/artichoke/mruby/commit/e32f4a060bde9e923d241eae8635dec2db8cf2e4 which makes modifications to mruby core (including the VM) to support swapping the Array impl.

This build currently compiles, links, and successfully launches an airb shell.
Arrays can be created via the literal ['a'] syntax, but you can't do anything with them since the Ruby API is not yet implemented.

Head as of right now is able to run the spec suite to completion.

Passed 1075, skipped 225, not implemented 150, failed 1122 specs.

https://twitter.com/artichokeruby/status/1180368691008950272

the mruby patch referenced in the issue description is out of date and needs to be re-extracted. There were some GC bits that were subtly wrong.

Passed 624, skipped 116, not implemented 141, failed 333 specs.

Existing passing specs pass (e.g. URI).
Cleaning up and getting this to a mergable state.

Success!
https://circleci.com/gh/artichoke/artichoke/2846
🎉🎉🎉🎉🎉🎉🎉🎉🎉🎉🎉🎉🎉🎉🎉
💎💎💎💎💎💎💎💎💎💎💎💎💎💎💎

Some cleanup to do after this:

[ ] File tickets for getting remaining specs passing.
[ ] Fixup artichoke-backend build to prep for:
[ ] Merging mruby-sys into artichoke-backend.
[ ] Rename artichoke-backend to artichoke-mruby.
[ ] implement Array#initialize in Rust and remove Ruby impl of Array::new.

Once that's done, start working on alternate Array impls to prep for RubyConf.


Non GitHub mirror sbc.io Error 404 Not Found

'404 Not Found' response for http://sbc.io/hosts/hosts or other hosts variants.

@mikhaelkh use this link temporarily until the problem is fixed: https://www.celsoazevedo.com/hosts/
ping Steven @StevenBlack

Hi Michael @mikhaelkh thank you for this.
Fixed!
Closing.


Template rendering optimization

resolves #7449
Description
Reduces the repetitive rendering described in the issue by caching results.
Local before on internal analytics:
dbt --no-version-check --no-partial-parse parse  20.67s user 0.51s system 98% cpu 21.506 total

And after:
dbt --no-version-check --no-partial-parse parse  18.71s user 0.49s system 98% cpu 19.465 total

Checklist

[x] I have read the contributing guide and understand what's expected of me
[x] I have signed the CLA
[x] I have run this code in development and it appears to resolve the stated issue
[x] This PR includes tests, or tests are not required/relevant for this PR
[x] I have opened an issue to add/update docs, or docs changes are not required/relevant for this PR
[x] I have run changie new to create a changelog entry

Love the sweet sounds of "12% faster" @peterallenwebb 🎵 !
Curious: is the caching approach a form of memoization?

Is this one of those global file things that we need to reset for new commands?  Some of the values in the strings that are rendered could change from command to command, such as variables, etc. So it should be reset at some point.

@dbeatty10 Yes, it is effectively memoizing this function.

@gshank I think that is a good point about clearing the cache between commands, and it makes me wonder if we are doing this for other caches (or should). I wish I felt like I could trust the comment, because if I did we could just call python's ast.literal_eval and return the result (or a the original string if it throws).

@peterallenwebb Nice work! Anything blocking us from merging this one?

@jtcohen6 I'd been putting it off because i have a more comprehensive solution in mind, but I don't think there is any reason not to enjoy this little speedup in the meantime.


Also, does this need to obscure the whole page? It's basically a hint, it could just be some text and a high contrast arrow pointing to the link. Clicking from the services to the explore page seems to say "Ok cool, we've got your services done, lets have a look at what you can now do with it Wait Hold on one sec, I forgot to tell you, if you want to connect more services they are over there" :)
Maybe some text stating "if you don't want to sign up all your services now, or want to add additional ones later, they'll be over here" would be better, on the connectors page?

such a potty mouth!

I think every time you hit #Explore-connect, a cookie gets set that will show that dialog on your next page. Users only see #Explore-connect immediately after they create a locker, so this may just be a dev problem.

@elsmorian It's part of the create-account experience and not meant to just appear in this manner.

@kristjan that is possible, but still a bug, that's why I've filed this for a later milestone.


Encode PromQL Matricies with Arrow

Use content negotiation to return a stream of Arrow records from the query and query_range endpoints in the case where a matrix is returned. This provides vastly superior CPU performance both on the server and on the client when transferring significant amounts of data.
This is a very minimal implementation, and only targets the matrix type of response to begin with as that is the only response that can return very large amounts of data. I try to explain the response, and leave it open to implementing streaming samples for each series, but today all samples are returned in a single record batch for performance reasons (and the 11,000 point limit makes this safe).
Happy to iterate on the format or code. I also wonder if we should put this behind a feature flag, but since content negotiation is required an additional flag did not feel necessary to me. The documentation still calls out the arrow type as experimental. More information on the Arrow Streaming format can be found at https://arrow.apache.org/docs/format/Columnar.html#ipc-streaming-format.
goos: darwin
goarch: arm64
pkg: github.com/prometheus/prometheus/web/api/v1
BenchmarkRespond-8                  2326            475496 ns/op          213687 B/op          8 allocs/op
BenchmarkRespondArrow-8            16176             74459 ns/op          452520 B/op         83 allocs/op

Could the conversion to arrow happen in a dedicated package, instead of web?

I added a commit that moves the arrow transformation and writes to the Matrix and Series types in the promql package and hid them behind an interface so we could support Vector or other types in the future with minimal changes. What do you think of that approach? I am also happy to move the code to a separate arrow package if desired, perhaps as a sub-package of promql?

At the dev-summit after PromCon we did agree that a streaming API is something we are interested in. However, I do not want to derail this pull request with discussing a streaming API as supporting streaming responses in the PromQL engine is a far larger change than this.
However, I do want the wire format in this PR to support streaming use cases, and the question of if we want to stream by series and samples (what is present in this PR), or stream by timestamp with all series in one row is relevant to the wire format of this PR. For example, rather than the simple schema I use here (two columns, t and v) I could add every series as a separate column with one t column in addition. I am experimenting a bit with that format, but I am not sure I love it as you can end up with a fairly sparse matrix in the presence of churn or an instant query like up[30d]. I would love to hear the opinions of others on per-series vs per-timestamp streaming though.
Plus, if the wire format supports streaming, those other projects can experiment with/implement streaming as they want :).

I was more thinking about moving the modification to the model/ package than into promql itself, would it make sense for you?

I was more thinking about moving the modification to the model/ package than into promql itself, would it make sense for you? It would then be usable for third parties promql engines as well.

That seems reasonable, I will at least investigate it next week!

Is there a particular reason we’re doing this in the query range API? I personally find this an odd placement and usage of arrow, typically arrow the format used within a query engine for zero copy computations. Have we considered doing this rather for remote read? That seems like the more natural space for it to me. And streaming there would also work very well as we already have machinery available from the proto streaming variant.

Yes, the idea of supporting Arrow in the query(_range) API is to better support data analytics and machine learning use cases. For those use cases I have found it common to at least use a function like rate and commonly also some level of aggregation. I would not want a client to have to deal with things like counter resets that are handled by PromQL which means remote read does not work well for these use cases.

Got it. That makes sense. I hope that eventually, we have PromQL be arrow-based, and then it doesn't really matter, but until then I agree it's difficult to make a case for just remote-read. Thanks for elaborating!

For my use case it would be nice if the format of the (float) histogram results returned by such API is the encoded internal representation and not what Prometheus returns currently which is the user-friendly JSON.

Actually to avoid favoring one use-case, it would be nice to be able to dependency inject additional serializers into the web/api. One could select from client side with Accept header which one to use. This would enable me to add my own serializer and get the data in the format that suits me.

For my use case it would be nice if the format of the (float) histogram results returned by such API is the encoded internal representation and not what Prometheus returns currently which is the user-friendly JSON.

I agree, as you can see I have not implemented native histograms yet, but my thought is to have a set of columns that represent the internal structure for native histograms. I looked briefly at using the JSON representation but performance was significantly worse than I would have liked.
I am planning to come back to this PR soon. Talking with Julien we decided it would be best to move the translation back to web for now.

WRT native histograms: While the internal representation is very efficient, it requires very specific knowledge to decode.
If the goal of this Arrow approach is to shovel vast amounts of metrics data into some 3rd party data processing system (as @csmarchbanks said above: "support data analytics and machine learning use cases"), it might be better to still use a more explicit representation of the native histograms (more or less something like the JSON representation, just not in JSON). Otherwise, you need to reproduce the decoding logic that is currently "internal to Prometheus" in the 3rd party data processing system (and worse, you also have to keep it up to date with "Prometheus internal" changes, e.g. adding new bucket layout schemas).
If the goal is to transfer the data into another system that is still based on how Prometheus internally works (that's @krajorama's use case), then using the internal "encoded" version of the native histograms is fine.

@csmarchbanks I think it's still a really great thing to have. Would you please rebase and take @brancz 's suggestion into consideration? Thanks :-)

I’ve thought about this even more and I think I’ve come to the conclusion that samples should be a list of a struct that under the hood is just a column for timestamp and value. Happy to sketch out the schema if you want!

Looking at this during the bug scrub.
@csmarchbanks is this still on your radar? The idea seems to be universally loved.

Yep, this is still on my radar, but I won't have time to work on it until at least after my second batch of paternity leave (end of January).
I would be happy to see some additional schema ideas to discuss, I am a little bit hesitant to go too far into custom struct types as I want this to be easy to use with things like pandas in the data science realm, but I could also provide a library to make that easier.

Nothing I suggested is custom, I think serializing the labels as metadata as it's proposed in this PR is very custom.
I think a dictionary + RLE encoded string column for each label-name and a list of structs that's timestamp and value would be the most idiomatic arrow schema.

I'll rephrase that, my motivation for the format in this PR was to make it as easy and efficient as possible to operate on those time series using tools like Pandas or NumPy. In my experience all of those tools use a column for timestamp and then one or more columns for values to represent a time series. You should be able to directly load this Arrow schema into a Pandas series without any transformations or allocations. By "custom" I meant types that I think might make it harder to load directly into Pandas/Numpy (see https://arrow.apache.org/docs/python/pandas.html#zero-copy-series-conversions).
Anyway, I do like that your proposed schema can add multiple series to the same record batch and avoids using metadata fields. I also like that it would work well for a vector response whereas my original proposal would be a massive amount of overhead. However, I would like to discuss some of the motivation/tradeoffs for each. I created a quick design doc where we can do this, would you be willing to add to/correct the details I added for your proposal?
Basically, I am happy to implement the format you proposed when I have time to come back to this, but would like to discuss the motivation and tradeoffs first.

Thank you so much for putting that together! I commented with a few thoughts. I think there are a few things to explore, but loving where this is going. (btw at this point we should discuss having an arrow flight compatible API)

Hello again from the bug-scrub!  @csmarchbanks could you give us another status update please?
We noted that content-type negotiation has become more powerful, which might make this PR easier (and requires a rebase).


PEs with ImageBase == 0 that need relocations aren't loaded correctly

SMM Drivers usually (and other PEs, I'm sure) have an ImageBase of 0 but have relocations, so they could be rebased and relocated.
There are two problems here:

The PE loader rebases a PE with ImageBase == 0, which isn't necessary, but not a problem in itself
Relocations aren't applied when VA == 0, so the PE is first rebased but then flagged as non-relocatable

In combination, this of course causes erroneous loading of the PE and additionally, there is no error message pointing out this problematic combination.
Rebasing PEs with an ImageBase of 0 is debateable, but of course, relocations have to work correctly, if rebasing is done.

We should just get a menu for imagebase in the loader options like ELF has

I just noticed that the decompiler can't deal with images mapped to 0 correctly, so for now, we should just merge the Relocation fix and keep the rebasing for ImageBase == 0

I have a question? What’s the highest power GHIDRA IS USED WITH?
On Saturday, August 8, 2020, Felix Schneider<EMAIL_ADDRESS>wrote:

Reopened #1562
https://github.com/NationalSecurityAgency/ghidra/pull/1562.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/NationalSecurityAgency/ghidra/pull/1562#event-3635953996,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AQQ3LSXSMP676CQ32JDVJNDR7WXCJANCNFSM4KZWVI3Q
.


[Core] Split constants files

As there are quite a few files declaring constants, we should change this to have the constants split into more meaningful classes instead of a Constants class declaring various constants for different functionalities. For example, we may have a class XSFileExtensions declaring constants about file extensions and similar other more granular classes. We should have in mind that some constants should only be declared where used if used only in one place.

This issue is closed as the project is no longer maintained


[hotROD] Replace ot traces and const with otel

Which problem is this PR solving?

Part of #3381
This PR adds otel traces and const to hotROD test file

Short description of the changes

Replace OT const with otel trace spans const i.e. ext.SpanKind.. with trace.SpanKind.. and its trace API

Thanks again. But I am wondering why our test is still failing.
On Thu 10 Aug, 2023, 11:33 PM Yuri Shkuro @.*** wrote:

@.**** commented on this pull request.
In examples/hotrod/pkg/tracing/rpcmetrics/observer_test.go
https://github.com/jaegertracing/jaeger/pull/4635#discussion_r1290499874
:

@@ -109,20 +103,17 @@ func TestTags(t *testing.T) {
key     string
variant string

that means it's not used, that link is still initialization path
—
Reply to this email directly, view it on GitHub
https://github.com/jaegertracing/jaeger/pull/4635#discussion_r1290499874,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AWUUWLVIB3BKAZJR26MCPJDXUUO7XANCNFSM6AAAAAA3HMVMPY
.
You are receiving this because you commented.Message ID:
@.***>


[model] Roberta converted weights

Description
(Brief description on what this PR is about)
Checklist
Essentials

[ ] PR's title starts with a category (e.g. [BUGFIX], [MODEL], [TUTORIAL], [FEATURE], [DOC], etc)
[ ] Changes are complete (i.e. I finished coding on this PR)
[ ] All changes have test coverage
[ ] Code is well-documented

Changes

[ ] Feature1, tests, (and when applicable, API doc)
[ ] Feature2, tests, (and when applicable, API doc)

Comments

If this change is a backward incompatible change, why must this change be made.
Interesting edge cases to note here

Job PR-870/1 is complete.
Docs are uploaded to http://gluon-nlp-staging.s3-accelerate.dualstack.amazonaws.com/PR-870/1/index.html

Job PR-870/2 is complete.
Docs are uploaded to http://gluon-nlp-staging.s3-accelerate.dualstack.amazonaws.com/PR-870/2/index.html

Job PR-870/3 is complete.
Docs are uploaded to http://gluon-nlp-staging.s3-accelerate.dualstack.amazonaws.com/PR-870/3/index.html

Job PR-870/4 is complete.
Docs are uploaded to http://gluon-nlp-staging.s3-accelerate.dualstack.amazonaws.com/PR-870/4/index.html

Job PR-870/5 is complete.
Docs are uploaded to http://gluon-nlp-staging.s3-accelerate.dualstack.amazonaws.com/PR-870/5/index.html

Job PR-870/6 is complete.
Docs are uploaded to http://gluon-nlp-staging.s3-accelerate.dualstack.amazonaws.com/PR-870/6/index.html

Job PR-870/7 is complete.
Docs are uploaded to http://gluon-nlp-staging.s3-accelerate.dualstack.amazonaws.com/PR-870/7/index.html

Job PR-870/8 is complete.
Docs are uploaded to http://gluon-nlp-staging.s3-accelerate.dualstack.amazonaws.com/PR-870/8/index.html

Job PR-870/9 is complete.
Docs are uploaded to http://gluon-nlp-staging.s3-accelerate.dualstack.amazonaws.com/PR-870/9/index.html


One source record can be matched with two Golden record creating two match links

NOTE: Before filing a ticket, please see the following URL:
https://github.com/hapifhir/hapi-fhir/wiki/Getting-Help
Describe the bug
In MDM when one source resource is a possible match to two different Golden resources, accepting both possible match record creates 2 match links (manual) in single source
To Reproduce
Steps to reproduce the behavior:

Create two different Patient resources thus creating two Golden records
Create a patient resource with info that connects with already created Golden records thus creating two possible match record
Accept both the possible match records

Expected behavior
One source record should only be matched with one Golden record, In this case one source is linked with two Golden record
Screenshots
N/A
Environment (please complete the following information):

HAPI FHIR 6.1.1
OS: macOS Monterey Version 12.6
Browser: Google Chrome Version 105.0.5195.125

Fixed by: https://github.com/hapifhir/hapi-fhir/pull/4344


Could provide a complete demo?

Input an image, output the scene graph, sub gcn, sub gcn score, and image captions. thanks a lot!

Thanks for your interest. Unfortunately, it's not trivial to combine all these components into single codebase, since scene graph was generated by an independent codebase.


There is no "Select/Create Parameter File…" in status bar after resetting global state

OS: Windows 10
Build Version: 20200619.4
Repro Steps:

Open a template file and create a parameter file for it.
Remove the association with the parameter file (Select Parameter File... -> None -> Reset global extension state)
It will reload the VS Code -> Check the status bar

Expect:
There is a "Select/Create Parameter File..." in status bar.
Actual:
There is no "Select/Create Parameter File..." in status bar.

I can't seem to repro.

For me, it took a few seconds before the status bar message came up, but it did come up every time.  If it's still reproing for you, does it get fixed if you change tabs, close/reopen the file, etc?


CSS image references

Hi,
Good day.

Regards.
JJ

Please give more details about what you mean. What do you want to handle here ?

Hi,
This might not be directly related now that I'm thinking about it. I use the widmogrod/zf2-assetic-module, based on this repo. Will post question there, thanks.
Regards.
JJ


Docker integration

Hello,
I have integrate a docker solution with Docker + TensorFlow + your tutorial Python scripts.
Docker images (sources (Dockerfile[.gpu]) are presents under 'docker' directory. These images are based from official repo: tensorflow/tensorflow:latest and tensorflow/tensorflow:latest-gpu (for GPU version).
I'v added a 'run.sh' bash script to help to use these images (and containers associated).
I'v added too a 'makefile' to help to run your Python tutorial scripts with theses images.
A tmux screen record is present in the 'docker/README.md' file (it can be useful for understand how that work ^^).
Hope your enjoy my submission and it can be useful for others users/students.
Thx for your time and your sharing (knowledges) !
YoYo

Thank you for your contribution but I will decline it. This tutorial focuses on deep learning, not Tensorflow installation, which is done through a straightforward pip install. I do not want to introduce Docker into this. Advanced users who need Docker will have no difficulties dockerizing the project.


Concretize IndexLens using to_indices

Should implement #35.  The "problem" with this is that the resulting values are not exactly what you'd write by hand:
julia> AbstractPPL.concretize(@varname(x.a[1:end, end][:]), x)
x.a[1:2,2][Base.Slice(Base.OneTo(2))]

That wouldn't be so much of a problem besides printing, but unfortunately, lenses currenctly compare equality using strict types:
julia> AbstractPPL.concretize(@varname(x[1:3, :]), rand(10, 10)).lens.indices == @varname(x[1:3, 1:10]).lens.indices
true

julia> AbstractPPL.concretize(@varname(x[1:3, :]), rand(10, 10)).lens == @varname(x[1:3, 1:10]).lens
false

julia> AbstractPPL.concretize(@varname(x[1:3, :]), rand(10, 10)) == @varname(x[1:3, 1:10])
false

Cf. https://github.com/jw3126/Setfield.jl/issues/165; the equality comparison can hopefully be fixed there.
The remaining thing is that subsumption must still be able to work with Colon, since a user might index a trace/VarInfo using a non-concretized varname containing a colon.  But at least we can then be sure that one side is always concrete.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

1 of 1 (100.0%)  changed or added relevant line in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.2%) to 77.982%

Totals

Change from base Build<PHONE_NUMBER>:
0.2%

Covered Lines:
85

Relevant Lines:
109

💛  - Coveralls

I added some normalization code to the index conversions, so that all ranges will become "normal ranges", as constructed by :.
This should mitigate possible confusions in printing and problems with equality.  Also, at the time lenses are actually applied for getting, the indices are converted once more using to_indices, anyway, so the potential optimization of OneTo etc. is not lost.

I'm generally okay with this change, but I'd like to think about it a tiny bit more. E.g.

The remaining thing is that subsumption must still be able to work with Colon, since a user might index a trace/VarInfo using a non-concretized varname containing a colon. But at least we can then be sure that one side is always concrete.

this is quite an annoying issue. Do you have any thoughts on how we'd approach this dealing with this?

The remaining thing is that subsumption must still be able to work with Colon, since a user might index a trace/VarInfo using a non-concretized varname containing a colon. But at least we can then be sure that one side is always concrete.

this is quite an annoying issue. Do you have any thoughts on how we'd approach this dealing with this?

Sure, lets think about it. In my intuition, : in a varname without concrete context is a bit like infinity. If you have only of the, it works quite fine, you only run into undefined situations when there's two.
But my solution would be to do the same thing as the to_index family of functions, and always pass along the value you're talking about. : only means somthing in the context of a given array. Then subsumption checks of : amount to subsumption of to_index(x, :).
Now that's the logical answer. But if we do it this way, you compute the to_index at every lookup. Hence the idea to normalize it right away. Now, as @devmotion noted corretly, this changes printing, on which chains unfortunately depend... OTOH, we already change printing: https://github.com/TuringLang/AbstractPPL.jl/blob/3897231e14242fe0dcc5c762ecea71fbac218dfc/src/varname.jl#L174. So one hacky solution would be to just continue with that.  For example,
julia> to_indices([1,2], (:,))
(Base.Slice(Base.OneTo(2)),)

so we can dispatch on Base.Slice, which is used when a Colon is concretized.

So one hacky solution would be to just continue with that.

There's a major difference here though: : is an alias of the singleton Colon() (https://github.com/JuliaLang/julia/blob/8c9799530383d571d5beab4e530d86e40a289929/base/essentials.jl#L691), and hence both are identical and can't be distinguished. Whereas this is clearly not the case for Slice.

I found that the following is also a problem, and more severe:
julia> y = rand(10, 10);

julia> to_indices(x, (2:2:5,))
(2:2:4,)

I've made some changes trying to find a balance here. Namely,

to_indices is applied to all indices, but values which were originally Colon are un-converted to just UnitRange(converted_index) (which is what you get when writing begin:end instead).
I reintroduced the explicit concretize argument for varname, since now there is an actual choice to be made for "non-dynamic" varnames. This behaves the same as previously and fails on begin/end, just with a different error message.

I thought it would be possible to wrap the un-converted index into Base.Slice, but Base doesn't like Slice{UnitRange}. So the only reasonable thing IMHO is to do it as I described. This does have the effect that stringification changes: y[:] becomes y[1:N].

@torfjelde can you take a look at this PR, see whether you are happy before I merge it?

I'd have to look at this one myself again; IIRC there were some unexpected subtleties.

Sooo... I think we need to think about this a bit more. I have now added a couple of proper tests for VarName, and fixed some edge cases. Setfield 0.8.1 is required to make things like
@varname(A[1, Not(3)], true) == @varname(A[1, [1, 2, 4, 5, 6, 7, 8, 9, 10]])

work.
I have started to continue and refactor some other things (so currently many subsumption tests are broken).

I got quite something, and I think it's reasonable. Please review.

This assumes that non-concrete colons can never be subsumed (you cannot reasonably decide that x[:] is subsumed by x[1]; the other way around it makes sense), and so I error in this case.

Thanks, @phipsgabler for looking further into it.  I think it is sensible to throw an error on these corner cases. It is also fine to forbid cases where it causes inconsistency with downstream packages like MCMCChains, if that helps to keep the complexity of PR under control.

What remains to be discussed are the choices about colons.  Is concretizing them into ranges OK, and do the subsumption rules involving them not cause troubles.
I think I can argue for both (and think that some breaking changes are acceptable if it makes the overall implementation better and more consistent), but this needs to be cleared by people who can judge the downstream consequences better than me.
I'll add more test cases and README documentation to lay out the behaviour later this week.

I have a compromise suggestion: instead of not concretizing : or completely concretizing it to a UnitRange, we introduce a new type which clones Base.Slice (which is what to_indices of : results in), but prints as ::
julia> y = rand(10, 10);

julia> x = (;y);

julia> @varname(x.y[1, :])
x.y[1,:]

julia> @varname(x.y[1, :], true)
x.y[1,:]

julia> AbstractPPL.getlens(@varname(x.y[1, :], true)).inner.indices
(1, :)

julia> AbstractPPL.getlens(@varname(x.y[1, :], true)).inner.indices[2]
ConcretizedSlice(Base.OneTo(10))

That way, the colon is concretized, but not visibly distinguishable from :.  ConcretizedSlice should behave exactly like the original colon in indexing, and at the same time like the resulting Base.Slice.

bors try

Bors try

Some tests fail on Julia 1.0, which is probably OK to ignore. I updated the CI scripts to replace 1.0 with 1.6, the new long term support Julia version.

It seems the PR breaks https://github.com/TuringLang/DynamicPPL.jl/blob/aeb5e03fdfe6958e4f79d9ccc5b01b84b93371ff/test/compiler.jl#L220. The model seems reasonable though, doesn't it?

It seems the PR breaks<EMAIL_ADDRESS>The model seems reasonable though, doesn't it?

It does indeed. I need to take a look at that.

bors try

bors try

The remaining DPPL errors are, I think, simply caused by the fact that varname should now be called with concretize = true in the compiler context.

bors r+


Break down image deletion into an extensible list of smaller functions

Signed-off-by: Swathi Gangisetty<EMAIL_ADDRESS>

At some point, it would be ideal to revisit the exception catching patterns in Anchore Engine as a whole. These are problematic because makes debugging and testing hard if not impossible.
I understand that this PR addresses important issues for a release, but I've bubbled up these concerns before other releases and would like this one to get addressed.
To follow up, and have some accountability on fixing the problem, I've created an issue to track the effort #867
For this PR in particular, the changes needed to make this better are straightforward.

I agree with improving the exception handling but it should be noted a bigger change is necessary to support that. The exception raisers are not consistent through out the system and its down to the invoking function to interpret the errors. Error handling across the board needs improvement to raise well-defined reliable exceptions, overhauling the try-except blocks to handle restrictive errors is not a complete solution

At some point, it would be ideal to revisit the exception catching patterns in Anchore Engine as a whole. These are problematic because makes debugging and testing hard if not impossible.
I understand that this PR addresses important issues for a release, but I've bubbled up these concerns before other releases and would like this one to get addressed.
To follow up, and have some accountability on fixing the problem, I've created an issue to track the effort #867
For this PR in particular, the changes needed to make this better are straightforward.

I agree with improving the exception handling but it should be noted a bigger change is necessary to support that. The exception raisers are not consistent through out the system and its down to the invoking function to interpret the errors. Error handling across the board needs improvement to raise well-defined reliable exceptions, overhauling the try-except blocks to handle restrictive errors is not a complete solution

@zhill Merging this following our discussion. This blocks a downstream commit. I can follow it up with more updates if necessary

@zhill Merging this following our discussion. This blocks a downstream commit. I can follow it up with more updates if necessary


[FEATURE REQUEST] Add a separate label for the scanner and the wallet to help filter issue tracker

Is your feature request related to a problem? Please describe.
Issue tracker will get confusing over time as both Wallet issues and Scanner issues will be managed on the same repo.
Describe the solution you'd like
A separate label for scanner and wallet. Preferably simple labels like "scanner" and "wallet". This is based on the assumption that we can add multiple labels to a single issue. Please do correct me if I'm wrong.
Describe alternatives you've considered
Apparently it's possible to have multiple projects under the same repository... Maybe you could call this group of products something else like OSS Tools or something, and then have the scanner and the wallet be separate projects under it? That would make it easier to not only manage issues but I believe releases would be easier to track as well.

Apparently it's possible to have multiple projects under the same repository... Maybe you could call this group of products something else like OSS Tools or something, and then have the scanner and the wallet be separate projects under it? That would make it easier to not only manage issues but I believe releases would be easier to track as well.

@thisisartman Thanks i am not sure i want to merge with Fossily Tools right now. Might be an idea for the future
now having separate labels is an idea

@thisisartman Thanks i am not sure i want to merge with Fossily Tools right now. Might be an idea for the future

Fair enough

now having separate labels is an idea

🙃

EDIT: i added the app dropdown in the github issue template. But i cant make the label be added automatically right now( not without a github action which i dont want)

I see...


Merge Staging into Production, 2023-Aug-21 edition

Pages that have been changed:

[x] All pages, footer:

[x] Debra's email has been updated from her @uwaterloo address to her @dal address.
[x] Credits to Jan and Christine have been removed, and a link to DDMAL has been added

[x] Chant Create

[x] Feast field is now an autocomplete.

[x] Chant Detail

[x] Fixed bug with pre-syllabized text, where the page would break if a word started or ended with a hyphen.

[x] Chant Edit

[x] Fixed bug with pre-syllabized text, where the page would break if a word started or ended with a hyphen.
[x] Feast field is now an autocomplete.

[x] Content Overview

[x] Items now ordered by date_update

[x] Source Create

[x] RISM field is now an autocomplete widget

[x] Source Edit

[x] RISM field is now an autocomplete widget

[x] Behind the scenes

[x] permissions checks (for visiting various pages) have been refactored

This code is now running on production! Tests are passing, the password reset link works, and pages are loading as expected.


Illegal instruction (core dumped)

I am following 'ngpy' tutorial , here https://github.com/yahoojapan/NGT/tree/master/python
under simple samples , ngpy section.
I am executing this line 'ngtpy.create(b"tmp", dim)'
I am getting this error.
Can you explain, what 'tmp' is? Is it a directory or file or what?
Why have we put 'b' infront of it?
OS - Ubuntu 16
Python Version - Python 3.5

What error did you get?
Did you use pip to install ngtpy?
tmp is the name of the created index directory. It makes 'tmp' in the working directory.
b is not always necessary.

If your cpu cannot use avx2, you might get the error message.
Could you install NGT from source codes using cmake as follows.
cmake -DNGT_AVX_DISABLED=ON ..

Or, please use cpu with avx2.
tmp is the name of the created index directory. It makes 'tmp' in the working directory.
b is not always necessary.


Update toy tutorial

Description
Update add_toy_account function to create building asset first and add other assets as its children.
This should apply to battery and reporter cases. Plus in reporter case it is also necessary to move grid_connection_capacity sensor to building asset instead of Transmission zone.
Add building status page screenshot to the end of tutorial with comment like "A nice feature is that you can check the data connectivity status of your building asset. Now that we have made the schedule, both lamps are green."
Look & Feel
There should be new screenshot in the end of https://flexmeasures.readthedocs.io/en/latest/tut/toy-example-expanded.html
How to test
Follow toy tutorial instructions and check that all assets are created under Building asset
Further Improvements

Related Items

[x] I agree to contribute to the project under Apache 2 License.
[x] To the best of my knowledge, the proposed patch is not based on code under GPL or other license that is incompatible with FlexMeasures

Btw, Coveralls sometimes gets into a situation where it refuses some builds with an error like it happened here:

"Can't add a job to a build that is already closed. Build<PHONE_NUMBER> is closed.

Not our fault, we'll merge this anyways.
I looked for a bug at their end and they know it but haven't fixed it yet, it seems.


Remove duplicate validation messages

@bratseth or @bjorncs please review and merge. ? extends Collection<String> should accommodate the existing List<String> used by current config-model code.

Wont that require recompilation of the old model?

Why? Map<ValidationId, ? extends Collection<String>> should be capable of accepting a Map<ValidationId, List<String>> ... ?

The caller is old, and passes an argument which is a ... List<String> — this is fine with the old signature, which matches this exactly, and with the new one.

Yes, but signature changes which are type-compatible may require recompiling the caller as the byte-code invoke is for the exact types of the signature it matches. I don't recall the exact rules so don't know if that is true in this case though.

I doubt it, since this is a generic signature.

Probably doesn't matter that the generic type matches, as it's erased at runtime anyway.

If this was a change from accepting a List to Collection, it could matter, and perhaps it wouldn't work. But the signature here is a Map in both cases, so I'd be very surprised if this wasn't OK.


In Markdown "-", Multi-cursor + Enter does not meet expectations

Eg

AA BB CC
Multi-cursor + Enter
AA
BB CC

Thanks for creating this issue! We figured it's missing some basic information or in some other way doesn't follow our issue reporting guidelines. Please take the time to review these and update the issue.
Happy Coding!


upgrade async-sse

Version 4.0.0 of async-sse has this issue, which is apparently fixed in 4.0.1, can you upgrade in your dependencies?

@daleione please run cargo update (or delete your Cargo.lock).

thx


GitHub actions

This PR improves and speed up CI tests.

Normalize the YAML action file and respect .editorconfig settings
Rename the job according to the Github action filename.
Ensure the coverage test happens once every PR.
No need to validate and normalize composer.json so for each version of PHP

matrix.php == '8.22' :facepalm: ugh, how'd I miss that, oops. Thanks for the help!


req.login redirect is done before the user info is saved in the session

I have a simple login page with local auth and custom callback.
When the login is successful, I redirect the user to the main page and check if (req.isAuthenticated()) is true.
50% of the time,  req.isAuthenticated() returns false. It seems that the redirect is happening before the session information is updated. It didn't notice this issue when I was using the standard local auth options without custom callback.
Any idea ?
    self.app.post('/login', function (req, res, next) {
        passport.authenticate('local', function (err, user, info) {
            if (err) {
                return next(err);
            }

            var sanitizedEmail = validator.escape(req.body.username);
            if (!user) {
                req.flash('error', 'Wrong email or password');
                req.flash('emailL', sanitizedEmail);
                return res.redirect('/login');
            }
                req.logIn(user, function (err) {
                    if (err) {
                        return next(err);
                    }
                        return res.redirect('/main/');
                });
        })(req, res, next);
    });

Yeah I've seen this same issue. There is a workaround posted in this ticket https://github.com/jaredhanson/passport/issues/306
Basically they suggest saving the session manually and waiting for the save callback before hitting your redirect, that is what we are now doing, but I can't say I love that solution. Anyone more familiar with the passport code know of a better way to address this? Is there a second callback or event we can listen for. Should not req.logIn wait for the session save to finish before hitting the callback? Thoughts?

@franck34 I have the same issue too here. +1

I am still experiencing this, and saving the session doesn't fix it. Also with Postgres as others have mentioned

100% of the time not working here with postgre, whether I call req.login explicitly or use the authenticate middle which calls the function. I'm not new to passport, I even made a strategy, I don't think there are any issues on my end (always possible though).

Still an issue for me. Cannot find a fix for it. Implementing the hack.
@jaredhanson

I do have a similar problem of req.user not being saved properly on the redis database.
Apart from doing req.session.save, what works for me is to set saveUninitialized to false.
The reason behind the problem is user send more than 1 requests almost at the same time to my api server, one for authentication/login and the others for retrieving data. As a result, more than 1 cookie is being set on the client side. When the client send subsequent requests to the server, the server somehow parse one of the cookies which does not contain the user info in the session store.


Database Design

[x] Understand requirements
[x] Choose a suitable database for this project (MySQL, PostgreSQL, ...)
[x] Make a list of all the different tables the database would need (example: User, Data, Session, ...)
[x] Figure out which tables should be connected and how they should be connected
[ ] Figure out the individual table structure for each table
[ ] Document everything
[ ] Add all to PDF file and share through Microsoft teams

03.11.2022

created initial database design
looking into best way of storing datasets (currently thinking of storing whole JSON files with singular row for each set OR creating individual tables for each dataset)


Update dynamic-data-masking.md

It said you could grant granular permissions to users, but it should be either "database principals" or "users or database roles" so that is clear. I wish the term principals had been pushed harder in 2005 and beyond, but users or roles is probably good enough of a clarification in my mind (even though you can also grant to certificates :))

Docs Build status updates of commit 0c3084e:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/relational-databases/security/dynamic-data-masking.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

@VanMSFT

Can you review this PR?

IMPORTANT: When this content is ready to merge, you must add #sign-off in a comment or the approval may get overlooked.
#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team


fix bepinex compatibility

for some reason these changes are required for the mod to work with bepinex installed.

BepinEx uses a different version of harmony, which is likely why some of these things don't work. Especially the CreateDelegate functions. Those simply don't exist in BepinEx's harmony for some reason.


Rectcut

This adds the rectcut pattern for subdividing rectangles to raylibmisc. It remains to be tested. I also know it probably doesn't compile yet.

probably compiles now. Anyways will do actual tests when this will be easier to set up and test


Upgrade Airlock Function to v4

Description
As a TRE Administrator
I want to the airlock function to be upgraded to v4
So that it will continue to be supported on Azure as older versions (what we currently use) are going out on December 2022

@martinpeck as per your comment on #3664 are you good to take this one and the airlock firewall issue? Thanks.

send it

@martinpeck was this done?

Yep
Regards, Martin

From: Marcus Robinson @.>
Sent: Tuesday, September 19, 2023 5:32:12 PM
To: microsoft/AzureTRE @.>
Cc: Mention @.>; Comment @.>; Assign @.***>
Subject: Re: [microsoft/AzureTRE] Upgrade Airlock Function to v4 (Issue #2683)
@martinpeckhttps://github.com/martinpeck was this done?
—
Reply to this email directly, view it on GitHubhttps://github.com/microsoft/AzureTRE/issues/2683#issuecomment-1726044908 or unsubscribehttps://github.com/notifications/unsubscribe-auth/AALUFY65ZOVCNXPH6VE3BN3X3HCIZBFKMF2HI4TJMJ2XIZLTSSBKK5TBNR2WLJDUOJ2WLJDOMFWWLO3UNBZGKYLEL5YGC4TUNFRWS4DBNZ2F6YLDORUXM2LUPGBKK5TBNR2WLJDUOJ2WLJDOMFWWLLTXMF2GG2C7MFRXI2LWNF2HTAVFOZQWY5LFUVUXG43VMWSG4YLNMWVXI2DSMVQWIX3UPFYGLAVFOZQWY5LFVIZTAMZWGAZDSNJYGKSG4YLNMWUWQYLTL5WGCYTFNSWHG5LCNJSWG5C7OR4XAZNMJFZXG5LFINXW23LFNZ2KM5DPOBUWG44TQKSHI6LQMWVHEZLQN5ZWS5DPOJ42K5TBNR2WLKJTGQ2DKMJRGI3DHAVEOR4XAZNFNFZXG5LFUV3GC3DVMWVDCMZZGM4DCMZWGUZIFJDUPFYGLJLMMFRGK3FFOZQWY5LFVIZTAMZWGAZDSNJYGKTXI4TJM5TWK4VGMNZGKYLUMU.
You are receiving this email because you were mentioned.
Triage notifications on the go with GitHub Mobile for iOShttps://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Androidhttps://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.


:uri attribute

a :uri attribute can automatically be transformed to href="real URI"

Should every method in the TestController::class be covered?

No you don't need to test all these methods. However, I just realised: how should we pass in route parameters? 🤔 Maybe this feature won't work at all 😅

No you don't need to test all these methods. However, I just realised: how should we pass in route parameters? 🤔 Maybe this feature won't work at all 😅

I was doing some fancy things with thee container to resolve the controller. Maybe too fancy at this stage.

Yeah let's just close this one for now :) Thanks for looking into it though!


Add Honeycomb.io Go and Node Distros to Registry

Add Honeycomb.io OpenTelemetry Go and Node.js Distros to Registry

@chalin heh, fun timing with https://github.com/open-telemetry/opentelemetry.io/pull/2249 -- should 2249 happen first?

@cartermp - Yes, let's get #2249 in first. Thanks!

PR #2249 has been merged, and the "how to submit a post" instructions have been updated too (#2250).
I'm glad to resubmit this PR's addition if you'd like. Let me know.

reopened as #2254


Use the generator script

This is just a PR I'm opening to show how simply blade-ui-kit/blade-icons#144 could help maintain icon sets.

@mallardduck sorry, realized you might want to revert the changes I made to the composer.json file in order to continue.

@driesvints - NP at all. my setup works for the relative paths too.

Thanks @mallardduck!


Duplicate JsonDecodeError type with Data.Argonaut.Decode

This module has its own JsonDecodeError type (that is just a copy of the code from Data.Argonaut.Decode.Error), which makes modules incompatible. How this could be solved, with dependency on "argonaut-codes"?

It's the other way around, the error type was copied from here to -argonaut-codecs. The modules being incompatible isn't of great concern to me personally, as I don't use -argonaut-codecs and don't want to add a dependency on it - I think it's a bad library.
If we can figure out a decent resolution to the problem of wanting a slightly more open error type, talked about in https://github.com/purescript-contrib/purescript-argonaut-codecs/pull/85 (there is discussion scattered in a few places too I think) and then make a library with just that type I'd switch to it though.

The modules being incompatible isn't of great concern to me personally

It can be a concern for lib authors that would like to use Json/JsonDecodeError types and give users the freedom to choose a particular way they perform encoding/decoding (use codecs or codec).
It seems like PureScript lacks a standardized approach to handling JSON which is kind of a basic type for the main PS application. I believe you wanted to fix this with https://github.com/garyb/purescript-json?

Yeah, exactly. I think most people do use argonaut-core but there's some inappropriately using foreign, etc. That -json library is intended to go in core, and will have absolutely minimal FFI so it can be used easily across different backends.
It's not going to contain any opinion on codecs though, so it won't really have an impact on this solve this problem.

That -json library is intended to go in core

Just to clear things up, what is meant by "core" here? Is this Json type supposed to be standard like String and Array?

It means the library will move under the main purescript organisation.

@wclr See The Core Libraries

@garyb ok, why modules there come under Json namespace, not Data.Json?


JSoup parsing unclosed tags (continued)

Similar to this issue (https://github.com/jhy/jsoup/issues/313), the handling of unclosed tags is yet not perfect. Consider the below examples:
String html = "
textextext<iframe frameborder=\"0\" height=\"420\"
";
Document doc = Jsoup.parse(html);
System.out.println(doc);

The broken iframe tag is correctly closed:

textextext<iframe frameborder="0" height="420" <="">

Yet, if I add an enclosing div tag:
String html = "

textextext<iframe frameborder=\"0\" height=\"420\"

";
Document doc = Jsoup.parse(html);
System.out.println(doc);

The broken iframe tag is wrongly closed after the previously enclosing div tag.

textextext<iframe frameborder="0" height="420" <=""></div>

Firefox correctly renders the broken iframe as text. I think this solution is the most appropriate one, since it is impossible to know what the broken iframe was supposed to contain.
Either way, the expected behaviour would be to either fix or render as text anything between the last correct opening tag and the first correct corresponding closing tag. Tags outside of these two tags should not be affected by error correction (in this case, the div tags).

(Closing out old, dormant bugs. If you are still impacted by this, please reopen & vote.)


Users are unable to post issues

How to reproduce this bug
Go to the bottom of the page and click on "GitHub" in the sentence "Lag en issue på GitHub" in incognito mode. This will direct you to a 404 on GitHub.
Possible fix
Since our repo is private there is no straightforward way to allow non-members of the repo to create issues. However, there are the two solutions presented in this StackOverflow issue:

Using something called Bitbucket
Creating a separate public repo only for issues from the public

Resolved as we are now open source.


[HOLD #12046] Feature Request : not hide Keyboard  when click on chat with your specialist reported by @gadhiyamanan

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Problem:
Keyboard hides click on chat with your specialist
Solution:
We should not hides Keyboard  click on chat with your specialist
Context/Examples/Screenshots/Notes:
Platform:
Where is this issue occurring?

iOS
Android
Mobile Web

Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:
https://user-images.githubusercontent.com/43996225/196322185-8c9f1fbf-c017-4012-8ea1-a6edddaa34c5.mp4
Expensify/Expensify Issue URL:
Issue reported by: @gadhiyamanan
Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1665637839530719?thread_ts=1665033893.404679&cid=C01GTK53T8Q
View all open jobs on GitHub

Checking on internally here https://expensify.slack.com/archives/C07F03W66/p1666112472276209?thread_ts=1665510343.387969&cid=C07F03W66

Gonna close this for now as I'm unable to reproduce, please comment and/or reopen if anyone is able to repro with

My mistake, I thought a Guide was sending the "Chat with your specialist" link but it's coming from Concierge.   And.. when I get the message, I'm unable to click the link, when I try to click it, nothing happens.  @gadhiyamanan @kavimuru can you try to reproduce and let me know what you're finding?  I've asked here too
https://expensify.slack.com/archives/C01GTK53T8Q/p1666630199231519?thread_ts=1666270549.878679&cid=C01GTK53T8Q

Thanks @kavimuru ,  this flow is particularly janky.  If you click a link in the app to a chat in the app, you shouldn't be taken OUT of the app.  Also... the title of this GH is a different problem :(
Chatting more about in the #expensify-open-source https://expensify.slack.com/archives/C01GTK53T8Q/p1666818969906699?thread_ts=1666270549.878679&cid=C01GTK53T8Q

OK... so the other problem should be being handled in this issue https://github.com/Expensify/App/issues/12046
I'm going to put this issue on hold, pending the above because, when I click "chat with your specialist" I'm being sent to a different platform or tab.  Once we're not doing that we'll check to see if the keyboard shows or not. (I think that makes sense, comment here if not)

Holding on #12046

Reassigning as I'm heading OOO for a month. bumping back to weekly cuz it's on hold.

oh hold not overdue

@ctkochan22 I left a comment on this GH
As I believe this one was placed on HOLD for that one. But when I test it's still behaving in a way that I don't think it should.
Does this one need to be taken off hold as the fix for that one did not resolve this one?

Ah okay, let me take a look. I'm a bit all over the place htis week bc of covid, but I'll get to this as soon as i can. Otherwise you can drop in engineering chat to recuirt someone else in the meantime

@ctkochan22 have you had a chance to take a peak at this.
I just tried recreating again and while I'm not receiving the same outcome above (keyboard being hidden) I'm being routed to an archived room that I can't start a conversation in.

@ctkochan22 I'm going to close this one as I'm not receiving the same outcome as before.
When I do it the keyboard is not hidden and I'm brought to the room to chat as normal

Sorry, trying to catch up with being OOO for a while. Sounds like this is okay?
If there is an issue, lets create a new GH and I'll take it


F/updating gofn

Might want to find an alternative to gofn (I haven't looked around yet, it's way too late here 3AM! 😄 ).
The new gofn does not return proper errors. It now does a fatal log when the repository does not exist.
ref #13

thanks @bnkamalesh


[NEMO-364] Upgrade Beam version

JIRA: NEMO-364: Upgrade Beam
Major changes:

Upgrades the Beam version to 2.11.0, the newest version, to fix various errors.

Minor changes to note:

Updates to the deprecated packages and syntaxes.

Tests for the changes:

Existing tests confirm the changes

Other comments:

None

Closes #204

Great! I'm good to merge it :)


fix(connector): fix batch file source when there are no files

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
Previously for batch read from file source, the task_parallelism is set to (self.batch_parallelism / 2) as u32, which by default is 2, and this will cause 2 issues:

when their is only one file, another parallelism can not cancel normally.
when their is no files in source, the  parallelism can not cancel.

This pr fix these two issues by

set the task_parallelism to min(file_nums, (batch_parallelism / 2)), and minimum value is 1.
When their is no files in source, schedule an empty task to prevent stuck.

Checklist

[ ] I have written necessary rustdoc comments
[ ] I have added necessary unit tests and integration tests
[ ] I have added test labels as necessary. See details.
[ ] I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features #7934).
[ ] My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
[ ] All checks passed in ./risedev check (or alias, ./risedev c)
[ ] My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)

[ ] My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

[ ] My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

fix #17984?

Yes, added in pr description.


Clarify error message due to missing shader file

Objective
The error printed-out due to a missing shader file was confusing; This PR changes the error message.
Fixes #13644
Solution
I replaced the confusing wording (... shader is not loaded yet) with a clear explanation (... shader could not be loaded)
Testing

Did you test these changes? If so, how?

removing assets/shaders/game_of_life.wgsl & running its associated example now produces the following error:
thread '<unnamed>' panicked at examples/shader/compute_shader_game_of_life.rs:233:25:
Initializing assets/shaders/game_of_life.wgsl:
Pipeline could not be compiled because the following shader could not be loaded: AssetId<bevy_render::render_resource::shader::Shader>{ index: 0, generation: 0}
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
Encountered a panic in system `bevy_render::renderer::render_system`!

I don't think there are any tests expecting the previous error message, so this change should not break anything.

Are there any parts that need more testing?

If there was an intent behind the original message, this might need more attention.

How can other people (reviewers) test your changes? Is there anything specific they need to know?

One should be able to preview the changes by running any example after deleting/renaming their associated shader(s).

If relevant, what platforms did you test these changes on, and are there any important ones you can't test?

N/A

Thanks for taking care of this!


UX update

Streamline command output, add unicode icons and as for passphrase
during onboarding.
Fixes #1698
Signed-off-by: Dominik Schulz<EMAIL_ADDRESS>

Codecov Report

Merging #1715 (add5760) into master (774eb1d) will increase coverage by 0.02%.
The diff coverage is 36.21%.

@@            Coverage Diff             @@
##           master    #1715      +/-   ##
==========================================
+ Coverage   58.54%   58.56%   +0.02%
==========================================
  Files         190      191       +1
  Lines        9120     9113       -7
==========================================
- Hits         5339     5337       -2
+ Misses       3168     3162       -6
- Partials      613      614       +1

Impacted Files
Coverage Δ

internal/action/delete.go
61.29% <0.00%> (ø)

internal/action/edit.go
46.51% <0.00%> (ø)

internal/action/generate.go
47.26% <0.00%> (ø)

internal/action/repl.go
0.00% <0.00%> (ø)

internal/out/print.go
83.33% <0.00%> (ø)

internal/store/leaf/recipients.go
39.23% <0.00%> (ø)

internal/store/leaf/reencrypt.go
37.31% <0.00%> (ø)

internal/store/leaf/write.go
30.61% <0.00%> (ø)

internal/store/root/move.go
33.33% <0.00%> (ø)

main.go
48.78% <0.00%> (ø)

... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 774eb1d...add5760. Read the comment docs.

Codecov Report

Merging #1715 (add5760) into master (774eb1d) will increase coverage by 0.02%.
The diff coverage is 36.21%.

@@            Coverage Diff             @@
##           master    #1715      +/-   ##
==========================================
+ Coverage   58.54%   58.56%   +0.02%
==========================================
  Files         190      191       +1
  Lines        9120     9113       -7
==========================================
- Hits         5339     5337       -2
+ Misses       3168     3162       -6
- Partials      613      614       +1

Impacted Files
Coverage Δ

internal/action/delete.go
61.29% <0.00%> (ø)

internal/action/edit.go
46.51% <0.00%> (ø)

internal/action/generate.go
47.26% <0.00%> (ø)

internal/action/repl.go
0.00% <0.00%> (ø)

internal/out/print.go
83.33% <0.00%> (ø)

internal/store/leaf/recipients.go
39.23% <0.00%> (ø)

internal/store/leaf/reencrypt.go
37.31% <0.00%> (ø)

internal/store/leaf/write.go
30.61% <0.00%> (ø)

internal/store/root/move.go
33.33% <0.00%> (ø)

main.go
48.78% <0.00%> (ø)

... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 774eb1d...add5760. Read the comment docs.


[FEAT]: How can I improve the quality of text spliting ？

How are you running AnythingLLM?
Docker (local)
What happened?
When I upload a docx file,then I use the function of query,I find the qulity of answer is not matched correctly.I want to improve the qulity of answer by improving the way of text spliting.What should I do?
Are there known steps to reproduce?
No response

https://docs.anythingllm.com/llm-not-using-my-docs#how-can-i-make-retrieval-better-then


fix: order logs by last event

Another fix for people who have too many log files. By default the ordering is by name, so if you have less than 50 streams for today things were working fine, but once you have more than 50 things they are just being ordered randomly (string sorting on the hash).

never seen that option before! (aws-sdk docs geeez)

published in<EMAIL_ADDRESS>🎸


Makefile for automatically generating OM client code

as well as datacatalog server code.
Currently, one can only run:
make generate-code patch
Signed-off-by: Doron Chen<EMAIL_ADDRESS>

This PR includes both the original swagger json for OM, and a slightly amended swagger json which I use to fix auto-generated client code.
We use openapi to generate both server and client code for the data catalog. The server code is the backbone of the connector. The client code is to help with connection information which may include unexpected fields, such as "s3" (trick suggested by Rohith)


‘FacemarkLBF’ was not declared in this scope

When making the php module i get this error
/root/php-opencv/source/opencv2/face/opencv_facemarkLBF.cc:32:9: error: ‘FacemarkLBF’ was not declared in this scope      Ptr<FacemarkLBF> Facemark;
Devtoolset used
gcc (GCC) 4.8.2 20140120 (Red Hat 4.8.2-15)

Nevemind solved by compiling the commit https://github.com/hihozhou/php-opencv/commit/5d7dc11e6d2647f9326619141adde7e31e56470a before adding Facemark

If your problem is solved you can close this ticket.


Create public art filter for san-francisco.

Directory has been updated to united-states/california/san-francisco/


Feature highlighting across tiles inconsistent

Hi - I'm using this plugin with tilestache and it's working pretty well - but the highlighted features are only sometimes showing in tiles outside the mouseover tile, the docs suggest there is an option for this 'Optionally can highlight entire feature, not just the portion of it within a single tile'  - but I couldn't find anything.

@gusmacaulay, the "optionally" refers to highlighting or not; there isn't an option for only highlighting the part in a given tile.  This was written to be in contrast to the other implementation I found, which only highlights the part in a given tile.
Can you share a publicly accessible URL to your tile service, so I can test and try to find the underlying issue?  A small extract of the tile stack as a zip file or mbtiles file would be fine too, so long as it shows the problem.

@brendan-ward - Thanks, I looked into my utfgrids and figured out the issue - I was trying to use a key that wasn't unique, the result was quite muddled.


Check if IDP is MFA-ed when populating cis groups.

Coverage increased (+0.003%) to 90.032% when pulling 065c4f0b46efcb11eba173483c162392d5e2760d on johngian:fix-groups-passwordless into 37d6d092d2ad9a795b02a90cf7dbf6c032d1fdd2 on mozilla:master.

Coverage increased (+0.01%) to 90.043% when pulling 76d25ce0f7a7d1c7f5557a5893dc2345a1f44cd4 on johngian:fix-groups-passwordless into 37d6d092d2ad9a795b02a90cf7dbf6c032d1fdd2 on mozilla:master.

Coverage increased (+0.01%) to 90.043% when pulling 76d25ce0f7a7d1c7f5557a5893dc2345a1f44cd4 on johngian:fix-groups-passwordless into 37d6d092d2ad9a795b02a90cf7dbf6c032d1fdd2 on mozilla:master.

Coverage increased (+0.01%) to 90.042% when pulling 76d25ce0f7a7d1c7f5557a5893dc2345a1f44cd4 on johngian:fix-groups-passwordless into 37d6d092d2ad9a795b02a90cf7dbf6c032d1fdd2 on mozilla:master.

Coverage increased (+0.01%) to 90.044% when pulling 8ee785721403a7999a36d4e0678c21b0aa7ef125 on johngian:fix-groups-passwordless into 37d6d092d2ad9a795b02a90cf7dbf6c032d1fdd2 on mozilla:master.


Support for disabling whole drop-down box

It would be nice if the directive would offer the possibility to disable the whole drop-down box and not just the individual elements. This could be easily done by adjusting the template to something like this:
'<button ng-if="!isDisabled" type="button" class="button multiSelectButton" ng-click="toggleCheckboxes( $event ); refreshSelectedItems(); refreshButton();" ng-bind-html="varButtonLabel">' +
                '<button ng-if="isDisabled" type="button" class="button multiSelectButton disabled" ng-bind-html="varButtonLabel">' +

Hence if the isDisabled attribute is true the drop-down itself will be disabled. IMHO this makes sense as the user doesn't have to first click to then find out that not a single item can be selected.
What do you think, can this little extension go into the code?

Hi @RealGizmo ,
The reason behind that is; I want the users to still be able to see the available selections - thus I don't disable the whole dropdown box.

Understood. What about adding another attribute "disableDropDown" for making this configurable for those customers who want it ;) ?

Great work @isteven. This directive helps solve a pretty common problem where traditional html falls short.
I agree with @RealGizmo on the disable point though. Since this mimics the behavior of an html form control, it seems logical to at least include the option to disable it since all form controls support the disable attribute. I can understand your reasoning @isteven, but this behavior deviates from the normal set of html form controls and might not be what a seasoned developer using a form element would expect.

+1 for disabling the dropdown. The current disabling behavior is slightly disorienting.

:+1:  for disabling the dropdown. I was looking around the documentation and couldn't find a solution to this. I would simply like to disable a button based on the response to a previous button.

+1 for disabling the dropdown.

Hi all,
Noted.. will provide this much requested feature in the next release.

I'm just found that I need it too :+1:  :)

Hi I was wondering if this feature has been implemented yet. Thanks!

+1 for disabling the dropdown.

+1 for disabling the dropdown


fix(test): address issue with baseline and test versions

Alaska Airlines Pull Request
Summary:
This PR and the previous commit address an issue of reported cases when the user tried to install an updated version of the generator, there was an incorrect strict restriction as to the baseline version of node.
Type of change:
Please delete options that are not relevant.

[ ] New capability
[x] Revision of an existing capability
[ ] Infrastructure change (automation, etc.)
[ ] Other (please elaborate)

Checklist:

[x] My update follows the CONTRIBUTING guidelines of this project
[x] I have performed a self-review of my own update

By submitting this Pull Request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Pull Requests will be evaluated by their quality of update and whether it is consistent with the goals and values of this project. Any submission is to be considered a conversation between the submitter and the maintainers of this project and may require changes to your submission.
Thank you for your submission!
-- Auro Design System Team

:tada: This PR is included in version 3.7.2 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Clean

Seems ok to me...
Removing those assets and moving back to remote theme removed some changes I made to the sidebar...
But I guess there is no harm...
Maybe adding a section for letting know the user where/how to submit reports?

Maybe adding a section for letting know the user where/how to submit reports?

yeah it would be nice if you can found a way without injecting tons of files.

Or we can just use the same template on OPL main repo and just copy them here


Use port 7000 to resolve response delay issues in hm-diag.

gunicorn running on port 5000 for hm-diag was causing delays in minutes for endpoint responses. See hm-diag#248 for the full discussion. Switching to a different port resolves this issue.

@kashifpk should this be converted to a draft or closed?

@marvinmarnold -Since the issue this was for is on the back burner now and we haven't determined the root cause any way, I'll just close this for now and once we tackle the issue again we can do a new PR.


Opens the wrong Chrome

I'm on a Mac, which also has Parallels to run Windows 10, and this plug-in opens Parallels to run Chrome on the Windows side instead of the Mac version by default.

I basically call the command to start chrome..based on the OS..I am not sure what might be happening.

I was able to find a temporary work around by delete the shortcut to the Windows version of Chrome from the Mac side.

I have no way a testing this..if you have any suggestion feel free to update this thread.


Pub cleanup

It would be nice for the editor to have an automatic way of cleaning up pubs that were previously added but are now no longer used - otherwise experience with other package systems suggests that packages will get deployed just out of risk-aversion of not wanting to remove them in case they're still needed.
Unclear whether this is a pub feature, an editor feature, or a tree-shaking combo feature... Possibly all of the above.

This issue has been moved to dart-lang/pub#336.


Enables Cells Saving in Runme

Enables support to Save Cells in the Stateful Platform.
Updates the validation that skips writing session file, now it considers if auto-save is on/off to resolve it.
In Runme the Lifecycle ID is configured by default at Cell level, so the experiment reporter (runme.experiments.reporter) fails due to it needs the Frontmatter, which is not available. To solve this issue, this PR uses the Ephemeral ID as fallback.
Runme extension known bugs:

When a file is crated and a Cell is inserted and run, it is not sending the file contents to the Platform. It requires re-opening the file to work as it's expected. I'll face it in a separate branch.

Dagger terminal outputs are not working with the Save button. I'll face it in a separate branch.

Runme extension known bugs

When a file is crated and a Cell is inserted and run, it is not sending the file contents to the Platform. It requires re-opening the file to work as it's expected. I'll face it in a separate branch.

While it's probably safe to merge this branch without enabling the Save button, I think we need a solution for the abovementioned issue. For the dagger integration we could just disable the Save button or whatever is the most straightforward.


Not working with Grav's Admin Panel

The plugin Materializer can't be configured using the new Grav's Admin Panel. For example, if we go to the settings page of the plugin (url /admin/plugins/materializer) and click on Save, there's the following error:

Validation failed: always_load is not defined in blueprints

According to a Grav developer: "These plugins just need to get updated with appropriate blueprint files so they will work in the admin plugin."
My config: Grav v0.9.39, Admin Panel v0.4.2, Materializer v1.3.0

I haven't updated For the Admin yet as I'm not 100% sure of the blueprint format yet (it hasn't been documented with the Admin still in beta). I'll take a look at it this weekend and see what can be done.
Thanks for the heads up and the interest in Materializer.

Thanks for this quick answer.

I asked a Grav developer about blueprint format. Answer:

We are in the process of documenting these. Hopefully next week we will have some preliminary blueprint documents.
In the meantime, you can see examples in the various blueprints in system/blueprints however. This will give you an idea about the possible blueprint values.

Thanks. Of course you can still configure the plug-in just fine by editing the YAML files, as always. :)

Fixed in v1.3.1.

Thanks a lot.


Error: ImportError: cannot import name 'int_classes' from 'torch._six' (/home/hedian/anaconda3/envs/pytorch/lib/python3.9/site-packages/torch/_six.py)

hello! how to fix this error?
Thank you!!!

https://github.com/zh-plus/video-to-pose3D/pull/49

#49 merged.


baseclasses fail for configs

kosmos -p 'j.tutorials.baseclasses.configobjects.test()'
kosmos -p 'j.tutorials.baseclasses.world.test()'

[ ] test world.test fails
[ ] these 2 tests should be part of our automated test suite

(STILL WIP) Issue with world.test(): in the test of using a generic usable factory

The World class has 3 children (Ship, Ships, and Cars). Ships and Cars can be accessed using w.ships and w.cars, but the object_config class Ship cannot be accessed using w.ship. This arises after the call of w._children_recursive_get() where a recursive call to create instances is done on all children of World and their children.

When World() is created, an instance of its children are created as well. The Ship instance created is without a name, once it is assigned a name it can be accessed. Looking into baseclass to trace where the issue arises exactly for that.

@despiegk In world.test(), should World() have childclasses of both object_config_collection(Ships,Cars) and object_config(Ship)? Accessing the children of world arises for the Ship.
Can you provide more details regarding the logic of this test case please? https://github.com/threefoldtech/jumpscaleX_libs/blob/development/tutorials/base/object_structure/BaseClasses_Object_Structure.py#L116

Fix: https://github.com/threefoldtech/jumpscaleX_libs/commit/be2115d0180e2c5d154c65a288ff5dc54e556de2

Changed test to how base classes behave where an empty instance of object_config shouldn't exist where name would be empty. The test now tests scenario where Ships and Cars are children to World and they have their own children and can be accessed
WIP:
World3 scenario: Contains schematext and childclasses. Issue arises when accessing the childclass Cars using w2.cars where the mother_id is not set. Still looking into it.

The issue with World3 scenario is because the Children Cars and Ships were created before in the test scenario itself alone. They were added without a mother_id because of the 1st scenario.So when they are to be used in the World3 scenario, a new item isn't created that contains the mother_id but the old one is retrieved.
When scenario of World 3 is tested alone without the conflicting scenario run before it, it passed.
WIP  Looking into the mother_id issue mentioned in the test and base classes

Seperated the two tests for World to avoid the previously mentioned conflicts.

verified.