Contract Types Plugin - Initial Implementation

Full readme: taqueria-plugin-contract-type-generator/Readme.md
Requires:

https://github.com/ecadlabs/taquito/pull/1343 [Merged, pending release v 11.2]

Related Issues:

https://github.com/ecadlabs/taqueria/issues/176
https://github.com/ecadlabs/taqueria/issues/177

Completes

[x] contract.methods and contract.methodsObject parameters are fully typed
[x] contract.storage is fully typed
[x] originate storage parameter is fully typed

This plugin will generate typescript types for a contract.
In the simple case, it reads the artifacts folder for any *.tz Michelson files and will generate a types file with the matching filename for each.
Example Usage (based on an nft auction contract from open minter sdk)
export const exampleContractMethods1 = async () => {

    const Tezos = new TezosToolkit(`https://YOUR_PREFERRED_RPC_URL`)

    const contract = await Tezos.contract.at<TestContract>(`tz123`);

    contract.methods.bid(tas.nat(0));
    contract.methods.configure(
        /*opening_price:*/ tas.mutez(10),
        /*min_raise_percent:*/ tas.nat(10),
        /*min_raise:*/ tas.mutez(10),
        /*round_time:*/ tas.nat(10),
        /*extend_time:*/ tas.nat(10),
        /*asset:*/ [{
            fa2_address: tas.address(`tz123`),
            fa2_batch: [{
                amount: tas.nat(100),
                token_id: tas.nat(`100000000000000`),
            }],
        }],
        /*start_time:*/ tas.timestamp(new Date()),
        /*end_time:*/ tas.timestamp(`2020-01-01`),
    );

    // methodsObject
    contract.methodsObject.bid(tas.nat(0));
    contract.methodsObject.configure({
        asset: [{
            fa2_address: tas.address(`tz123`),
            fa2_batch: [{
                amount: tas.nat(100),
                token_id: tas.nat(`100000000000000`),
            }],
        }],
        start_time: tas.timestamp(new Date()),
        end_time: tas.timestamp(`2020-01-01`),
        extend_time: tas.nat(10),
        min_raise: tas.mutez(10),
        min_raise_percent: tas.nat(10),
        opening_price: tas.mutez(10),
        round_time: tas.nat(10),
    });

};

Example typegen task
$ taqueria typegen --typescriptDir ./types
generateTypes
{
  "typescriptDir": "./types"
}
Generating Types: /home/rick/projects/crypto/taqueria/example/artifacts => /home/rick/projects/crypto/taqueria/example/types
Contracts Found:
        - /home/rick/projects/crypto/taqueria/example/artifacts/example-contract-1.tz
Processing /example-contract-1.tz...example-contract-1.tz: Types generated

Example type output
type Storage = {
    pauseable_admin?: {
        admin: address;
        paused: boolean;
        pending_admin?: address;
    };
    current_id: nat;
    max_auction_time: nat;
    max_config_to_start_time: nat;
    auctions: BigMap<nat, {
        seller: address;
        current_bid: mutez;
        start_time: timestamp;
        last_bid_time: timestamp;
        round_time: int;
        extend_time: int;
        asset: Array<{
            fa2_address: address;
            fa2_batch: Array<{
                token_id: nat;
                amount: nat;
            }>;
        }>;
        min_raise_percent: nat;
        min_raise: mutez;
        end_time: timestamp;
        highest_bidder: address;
    }>;
};

type Methods = {
    confirm_admin: () => Promise<void>;
    pause: (param: boolean) => Promise<void>;
    set_admin: (param: address) => Promise<void>;
    bid: (param: nat) => Promise<void>;
    cancel: (param: nat) => Promise<void>;
    configure: (
        opening_price: mutez,
        min_raise_percent: nat,
        min_raise: mutez,
        round_time: nat,
        extend_time: nat,
        asset: Array<{
            fa2_address: address;
            fa2_batch: Array<{
                token_id: nat;
                amount: nat;
            }>;
        }>,
        start_time: timestamp,
        end_time: timestamp,
    ) => Promise<void>;
    resolve: (param: nat) => Promise<void>;
};

This should be nearly done, but it requires an upcoming taquito release version 11.2

@ricklove as usual, good stuff!
A few thoughts/suggestions:

The init and scaffold tasks accept the output directory as a positional argument. Perhaps to keep to the UE consistent, we could accept a positional argument here as well instead of the typescriptDir option?
We're using verbs for task names everywhere else. Similarly to the above, to achieve consistently, perhaps we could rename the task from "types" to "gen types"? @russellmorton any verb suggestions?
There were a couple of inline TODOs, which is fine. Could we also create issues for those and list the issue #s beside the TODOs please?
I'm glad to see all of the automated tests. I just need to check with the SDET guys to see if they have any preference to move these somewhere else. @alexzbusko ?
I took forever to get you a code review on this. As such, this branch has diverged from main quite a bit. Do you mind merging main into your branch please? I promise not to take so long for the final sign-off.

Thanks again Rick. Really appreciate all of the effort on this. @alexzbusko when you're able, would you be able to pull this branch down, build it, and give it a spin once Rick makes some of the adjustments above? I'll do the same. We'll then have some manual test coverage on both Windows and Mac.

@mweichert

👍 Makes sense, will fix that

❓ Ok, it seems ideally it would be a single word and without abbreviations. For reference, hardhat uses the name of the plugin: hardhat typechain. Not sure what would be ideal here.

👍 I'll make sure to link the issue for those.

❗ I don't think it would make sense to move these outside the plugin, they aren't tests about the plugin, but are about the correctness of the internal implementation, i.e. they are very tightly coupled to the implementation (and are more the domain of the implementer, not of testers).
If anything it might make sense to move these to a peer folder (so they can have a different node_modules dependency set), but it would not make sense to move these tests out of the control of the plugin implementation or far away from the implementation code.
I do have an idea to expand these substantially, so this will require a longer discussion.

👍 Sure - will merge in latest main

This should be ready, just need to test the positional argument

Having trouble using the positional argument, debugging now


update centralize subnet gatewayNode until gw is ready

[x] Make sure you have followed Kube-OVN Code Style.

What type of this PR

Bug fixes

1、 GatewayNode is nil for centralized subnet and patch subnet status as not ready succeed,  which will lead no update for subnet.
Wait gatewayNode ready for centralized subnet.
2、If subnet is not ready，the route from subnet cidr to ovn0 would not be added in cni.
Which issue(s) this PR fixes:
Fixes #1803

已回合 release-1.10  release-1.9  release-1.8 分支

子网信息

node 状态变化

log查看 subnet 变化


sink: add redis persistence

This PR adds redis persistence as an option.
Note that locking is not yet implemented since it's not that urgent
Fixes #314

Current dependencies on/for this PR:

main

PR #317   👈

This stack of pull requests is managed by Graphite.


Expose HF_HOME in constants

TL;DR: HF_HOME env variable is parsed but not exposed as a huggingface_hub constant. Let's expose it to harmonize things in other libraries.

I am currently making a cleanup of the environment variables in the HF ecosystem, and especially transformers (following up after https://github.com/huggingface/huggingface_hub/pull/1786).
I realized transformers and datasets need to know the HF_HOME directory to store python modules. At the moment the parsing is done individually in those libraries. Let's harmonize that by defining a HF_HOME constant in huggingface_hub directly -instead of lowercased hf_cache_home.
I am tempted to make a new 0.19.2 release once this is merged so that it can directly be integrated in transformers/datasets.

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.

Thanks for the review!


Bellman Ford Algorithm in C++

Want to work on this issue?
yes

@vivekcrux  : Can you move the algorithm to the appropriate folder.
https://github.com/fnplus/interview-techdev-guide/pull/115


close the experiment modal after clicking on save

This PR will fix the issue of the experiment modal not closing after saving changes in edit.

@Yagnik56 This works fine, but observed that the "Save" button on overview stepper is not disabled on context change, as we had earlier, maybe this got changed in some commit. We need to make sure the experimenter moves to the design page for updating the decision points and conditions as per the updated context, else wrong design is mapped with the context. The "Save" button should remain enabled for all other edits other than context on Overview page.

@ppratikcr7 disabled the save button if context or experiment type changes in overview page.

@Yagnik56 It works partially. In case I update the context to say A to B and then again update from B to A to keep it same, the save button is still disabled. For experiment type change this scenario enables the save button. This should happen for context too. Else, the experimenter has to forcibly go to next page to update/save any other value of overview page.

Also, found a new page on this overview page. The Assignment Algorithm when updated from Random to SRS without a stratification factor and tried to move next, will show an error on the stepper, which is expected. But, when you again update it to Random, you are unable to move to next design page and the error message also stays there. Also, the error message is overlapped a bit by the buttons. Can you add a proper padding around it. And align the logging checkbox in a straight left margin line. Please refer below:


Windows build is slow as molasses

Ok, that's an exaggeration, but the startup time when I run NW against the current directory is like 1-2 seconds, and when I package it (and I made sure I'm not packing any file that's not used), it's like 6-8 seconds. After that it's fast enough, but startup time shouldn't be that big, even on an HDD.
Tested is Windows 7 x64.

It is because the way nw extracts itself to a folder in your computer's temp folder every time. As far as I know (but I did not research this subject recently) to avoid that you need to package and execute your application differently, so after it lands on a user's machine it is extracted only once and then you run it using nw.exe

Yes, and that would not be a bad solution.
I mean, node-webkit-builder could have an option where it just copies over files and creates an "application folder" for each platform. Or bundle a zip file; I think NW supports reading a zip file faster than the way node-webkit-builder is doing it.
I'm much more concerned over startup time than having a single-file executable, and to be honest, if you're going to have a "single-file executable" and half-ass it by having two data files, DLLs and a locales folder, you might as well make a self-extracting archive. The current way is combining the bad part of both worlds.

Either way, I want to say that the idea behind node-webkit-builder is great and it's really easy to use; testing it out was super easy but if I can shave off several seconds of startup time by coding something myself it's just a pity.

duplicates #164 ?

Although I think there's a deeper issue here (unzipping shouldn't be that slow, ever), one simple solution is "not zipping". But really, there must be something wrong with whatever is unzipping the files. But I'm grateful for #200.

Closing in favour of #164.


Additional Box2D functions

Currently PHP7 Mapnik only implements the bare minimum requirements for constructing Box2D objects. There's plenty of low hanging fruit in the C++ API that would make working with envelopes easier...

width() and height()
expand_to_include()
contains()
intersects()
re_center()
clip()
pad()
etc.

Should probably do a PHP implementation of the coord class before tackling this.

yeah, those are a great idea.


UnboundLocalError: local variable 'data' referenced before assignment

Not sure if that's an issue, this error occurs after the script runs for +- 5 min.
Traceback (most recent call last):
  File "C:\ProgramData\Anaconda3\envs\godly-project\lib\threading.py", line 932, in _bootstrap_inner
    self.run()
  File "C:\ProgramData\Anaconda3\envs\godly-project\lib\threading.py", line 870, in run
    self._target(*self._args, **self._kwargs)
  File "C:\ProgramData\Anaconda3\envs\godly-project\lib\site-packages\tweepy\streaming.py", line 320, in _run
    six.reraise(*exc_info)
  File "C:\ProgramData\Anaconda3\envs\godly-project\lib\site-packages\six.py", line 703, in reraise
    raise value
  File "C:\ProgramData\Anaconda3\envs\godly-project\lib\site-packages\tweepy\streaming.py", line 289, in _run
    self._read_loop(resp)
  File "C:\ProgramData\Anaconda3\envs\godly-project\lib\site-packages\tweepy\streaming.py", line 349, in _read_loop
    next_status_obj = buf.read_len(length)
  File "C:\ProgramData\Anaconda3\envs\godly-project\lib\site-packages\tweepy\streaming.py", line 183, in read_len
    self._buffer += self._stream.read(read_len)
  File "C:\ProgramData\Anaconda3\envs\godly-project\lib\site-packages\urllib3\response.py", line 546, in read
    if data:
UnboundLocalError: local variable 'data' referenced before assignment

Im running on the newest version 3.1.0 using -> from tweepy.streaming import StreamListener

Tweepy v3.1.0 is over 5 years old now. The latest version of Tweepy is v3.9.0.
Regardless, this seems to be an issue with urllib3 rather than Tweepy.
You don't seem to be using the latest version of urllib3 either though, since the line that errors is on line 542 in urllib3 v1.25.10.
Feel free to provide an updated traceback if you're still able to reproduce this with the latest updated versions of both libraries, but this is unlikely to be an issue with Tweepy.


Basic list view for API 10 and below

Make library work for API 11 and above and provide basic list functionality on 10 and below instead of crashing. Also updated to latest libraries.
I want my app to run on Gingerbread even if it means the swipe feature wouldn't work. This should not affect functionality for API 11 and above, but it does pull in the compat libraries and increase library size and method count, so I can understand if you don't accept this PR. In that case please just close the PR. Thanks.

Hey, thanks for the pull request.
I'm trying to push a new version of the lib to maven, but I'm getting some dependency problems when generating the javadoc. If you are good with Gradle you might be able to help me.
This is the build.gradle for the lib. When I run uploadArchives, I get this error. So the android.support.v7.widget is not being imported. It seems to be the same problem as this stackoverflow question.
Previously I was having a few more errors, regarding the NonNull annotation, and this answer helped me fix that. However using the same approach for the support-v7 hasn't helped (line 33 of the build.gradle).
Let me know if you have some suggestions for me to try.

@brnunes #13 Try this. I didn't test it here, but have done those before.
Also let me know about this PR. I am kinda 50/50 because it pulls in com.android.support:support-v4, which adds like 8k to the DEX count. What do you think?

@brnunes Hey did you get a chance to try out the deploy script?

@benhylau I'll do it in the next few days.
About this PR, I'm not sure how to measure the pros and cons. I haven't done much Android development lately, but I imagine only large apps have a problem with DEX count, and if the app is large chances are it already includes the support-v4 lib (?).
Maybe releasing two versions of the lib is a solution?

Yea you are right, it mostly affects large apps that integrate lots of third party libraries, and chances are somehow support-v4 already got pulled in from some of those. Releasing two versions I think is the best solution, but may be too much trouble to maintain two branches just because of this.

@benhylau I've published a new version to maven, it should be online now. Please give it a try to see if everything is well.

Thanks I should try it soon.

I will post results here: https://github.com/hyperboria/android/issues/56


Add job dynamically

Hello and thank you for this great gem!
Is it possible to add a recurring job after sidekiq has started?

Nevermind!
It was as simple as:
Sidekiq::Cron::Job.create(name: 'Hard worker - every 5min', cron: '*/5 * * * *', class: 'HardWorker')


my emulator loads to 100% and then nothing else happens

Hi I'm trying to embed the emulator and nhl 94 into a blog post on Blogger. I'm using dropbox for the files and it looks like it loads to 100% and then fades to black. Am I supposed to put the snes.swf file in the embed as well?

what's the code?

https://github.com/nesbox/emulator

no I mean for the website

anyone know how to fix this?

Nevermind yall, figured it out. I changed params.allowscriptaccess = 'sameDomain'; to 'always'.

Where is params.allowscriptaccess? I think I may also have this problem.

@colt05 it is in the embed code they provided.

ah ok thanks


Disable Boundary feature bug

Enabling this feature causes cameras to break when trying to take control over one. The camera view is stuck in a black screen with the glitch effect, basically rendering the game frozen and having to force close the game. This is with the current version 2.0 of the game and 1.26.1 mod, and I've made sure to test it with no mods but this feature only enabled.
I also checked some of the closed bug reports regarding the boundary feature and was wondering if this may be related to them. I'm on an AMD ryzen 7700x and radeon 7900xt. I've posted a save where I attempted to hack a camera:
QuickSave-1.zip

Disable Boundary also causes a freeze during "The Heist" when you enter the Delamain cab after exiting the Afterlife

For me it's caused a freeze at the last frame before teleporting. I had a camera effect like it's usually before teleportation, and then the game completely froze, even alt-tabbing won't help.


UX: rage-keygen error output can be more intuitive

General Info
The error message was not as intuitive as it could have been.
It would be more intuitive for the keygen to create a directory if one doesn't exist for the file, or at the very least mention that the directory does not exist rather than it failing to open.
As this improvement could be undesirable for the user or cause issues, it would be worthwhile to also have a flag to prevent creation of any directories (if applicable for the user).
What were you trying to do
I was trying to generate a new key pair.
What happened
The console output:
~$ rage-keygen -o ~/.config/age/age.key
Error: Failed to write to output: Failed to open file '/home/marcel/.config/age/age.key'

[ Did rage not do what you expected? Could an error be more useful? ]
[ Tell us: https://str4d.xyz/rage/report

The output implies that a file exists which is trying to be opened.
What I had to do instead was create the directory manually with mkdir, and then create the key pair file within it.

I agree. Moreover, for file encryption (no recipients needed) they key system is not good- i spent about an hour dealing with error messages, using the right formatted key, and other issues before i just gave up and figured to use rage just for password encryption of files. Encrypting using one's own key , if its not meant to be, say so then!!

I agree. Moreover, for file encryption (no recipients needed) they key system is not good- i spent about an hour dealing with error messages, using the right formatted key, and other issues before i just gave up and figured to use rage just for password encryption of files. Encrypting using one's own key , if its not meant to be, say so then!!  I found the entire key system very frustrating and clunky, very far from the promise of the app being "easy" to use. ChatGPT had a very hard time figuring out the key system too. Very NOT user friendly, very clunky.

I believe it's generally the case for Unix tools that directories are not created automatically. Some examples:
$ ./age-keygen -o does-not-exist/test-530.key
age-keygen: error: failed to open output file "does-not-exist/test-530.key": open does-not-exist/test-530.key: no such file or directory
age-keygen: report unexpected or unhelpful errors at https://filippo.io/age/report

$ ssh-keygen -f does-not-exist/test-530.key
Generating public/private rsa key pair.
Enter passphrase (empty for no passphrase):
Enter same passphrase again:
Saving key "does-not-exist/test-530.key" failed: No such file or directory

So I'm going to have rage-keygen also continue to fail if the directory does not exist, but I'll see if I can improve the error message.


False positive in checking nilabilty of slice using len(s) assigned to a variable

The following code reports a false positive.
func test(mp map[string][]*int) {
	sl := mp["foo"]
	slLen := len(sl)
	if slLen == 0 {
		return
	}
	_ = sl[0] // FP: error: deep read from parameter `mp` lacking guarding; sliced
}

However, using len directly in the condition works as expected, reporting no error.
func test(mp map[string][]*int) {
	sl := mp["foo"]
	if len(sl) == 0 {
		return
	}
	_ = sl[0]
}

@abhinav, thanks for reporting this. :) We'll try and add support for this soon.

However, if len(slice) - 1 >= 0, then len(slice) > 0 so it should infer that the slice is non-nil.

Just to set expectations a bit here, while we are happy to build heuristics for common cases, in the limit NilAway shouldn't be expected to reason about arbitrarily complex integer arithmetic. This is a type system for nilability and that sort of thing is the domain of SMT solvers.
I do think x-1 >= 0 => x > 0 can be special cased, though! 😅
I just wouldn't expect say, this, to ever work:
j := len(b.bs)
i := (j - 1) % 2
if i >= 0 {
  b.bs[i] = ...
}

Even though, of course, it's equally safe (len(nil) = 0 => i =  (0-1) % 2 = -1).
In theory a tool can be built that reasons about whether values can contain nil and the possible value ranges of every integer variable in the program, but the later is a harder problem than the former.

Thanks, @lazaroclapp, that's completely reasonable.
I'm aware that not requiring code annotations was one of the goals of nilaway, but just thinking out loud:
Would there be room in the system to annotate code with comments for these corner cases?
For example, for the Zap function above:
func (b *Buffer) TrimNewline() {
	if i := len(b.bs) - 1; i >= 0 {
		if b.bs[i] == '\n' {
			b.bs = b.bs[:i]
		}
	}
}

If authors could do something like this, informing nilaway that that condition implies something about the result:
if i := len(b.bs) - 1; i >= 0 {
	// @implies:not-nil(b.bs) // i > 0 guarantees b.bs is non-nil
	if b.bs[i] == '\n' {
		// ...
	}
}

Then nilaway wouldn't have to worry about special-casing arbitrary arithmetic and other special cases that nilaway shouldn't have to handle.


feat: increase hitslop of section title

This PR resolves [https://www.notion.so/artsy/Art-Advisor-Home-View-Feedback-abc1123548504ae58051405627fb6c9f]
Description
This PR updates the hitslop of the section title to make it easier to tap.

Before
After

PR Checklist

[x] I have tested my changes on iOS and Android.
[x] I hid my changes behind a feature flag, or they don't need one.
[x] I have included screenshots or videos, or I have not changed the UI.
[x] I have added tests, or my changes don't require any.
[x] I added an app state migration, or my changes do not require one.
[x] I have documented any follow-up work that this PR will require, or it does not require any.
[x] I have added a changelog entry below, or my changes do not require one.

To the reviewers 👀

[ ] I would like at least one of the reviewers to run this PR on the simulator or device.

Changelog updates
Changelog updates

Cross-platform user-facing changes

increase hitslop of section titles - mounir

iOS user-facing changes

Android user-facing changes

Dev changes

Need help with something? Have a look at our docs, or get in touch with us.

This PR contains the following changes:

Cross-platform user-facing changes (increase hitslop of section titles - mounir)

  Generated by :no_entry_sign: dangerJS against ca6e8bad8d9d241fa37594fe10671147cbf5fe9c


Sample?

Looks a great library
Any sample would be helpful
Thanks!

It's a good point :-)
Unfortunately I haven't had the time yet to generate sample code in the README...
But try to use it naturally:
HttpRequest.postRequest(url)
  .setContentType(HttpRequest.ContentType.JSON)
  .addHeader("MyHeader", "Value")
  .setRequestBody("{\"key\": \"value\"}")
  .getResponseAsync(...)

Of course there are many features like automatically handling multipart encoding, setRequestBody from stream, adding a part from stream, adding a part from file, etc. without filling up the RAM.
If you write down some use cases - I can create samples for those and add to the README :)

Thanks i will try that !


[SPARK-26598] Fix HiveThriftServer2 cannot be modified hiveconf/hivevar variables

What changes were proposed in this pull request?
The intent to use the --hiveconf/--hivevar parameter is just an initialization value, so setting it once in SparkSQLSessionManager#openSession is sufficient, and each time the SparkExecuteStatementOperation setting causes the variable to not be modified.
Why are the changes needed?
It is wrong to set the --hivevar/--hiveconf variable in every SparkExecuteStatementOperation, which prevents variable updates.
Does this PR introduce any user-facing change?
cat <<EOF > test.sql
select '\${a}', '\${b}';
set b=bvalue_MOD_VALUE;
set b;
EOF

beeline -u jdbc:hive2://localhost:10000 --hiveconf a=avalue --hivevar b=bvalue -f test.sql

current result:
+-----------------+-----------------+--+
|     avalue      |     bvalue      |
+-----------------+-----------------+--+
| avalue          | bvalue          |
+-----------------+-----------------+--+
+-----------------+-----------------+--+
|       key       |      value      |
+-----------------+-----------------+--+
| b               | bvalue          |
+-----------------+-----------------+--+
1 row selected (0.022 seconds)

after modification:
+-----------------+-----------------+--+
|     avalue      |     bvalue      |
+-----------------+-----------------+--+
| avalue          | bvalue          |
+-----------------+-----------------+--+
+-----------------+-----------------+--+
|       key       |      value      |
+-----------------+-----------------+--+
| b               | bvalue_MOD_VALUE|
+-----------------+-----------------+--+
1 row selected (0.022 seconds)

How was this patch tested?
modified the existing unit test

Can one of the admins verify this patch?

Can one of the admins verify this patch?

Can one of the admins verify this patch?

Because the developer who reported SPARK-26598 had not responded for some time, I now take over the issue.
Adding test on the basis of https://github.com/apache/spark/pull/23516
@wangyum

ok to test

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/15304/
Test PASSed.

Test build #110309 has started for PR 25722 at commit 2716281.

Test build #110309 has finished for PR 25722 at commit 2716281.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/110309/
Test PASSed.

retest this please

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/15305/
Test PASSed.

Test build #110310 has started for PR 25722 at commit 2716281.

Test build #110310 has finished for PR 25722 at commit 2716281.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/110310/
Test PASSed.

cc @HyukjinKwon

Thank you @cxzl25

Merged to master

cc @juliuszsompolski


Undefined reference to hpx::assertion_failed

Building commit 6c08935c5d9158031bbdee01872283e2dd8b0ceb with GCC 5.3 and RelWithDebInfo as the build type fails due to an undefined reference to hpx::assertion_failed.
After examining the compiler output, it seems that all calls of assertion_failed are inlined. Afterwards the dead function is eliminated by the compiler and the reference in assert.hpp can not subsequently be resolved by the linker.
The reason for this behavior seems to be the contradicting declaration of this function in exception.hpp (as an inline function) and in assert.hpp (as a non-inline function).
As far as I know an inline function must be defined in every translation unit where it is called. In addition, an inline function with external linkage must be declared inline in every translation unit. Both rules are (possibly) violated in this case.
I was able to fix the issue by moving the definition into exception.cpp
assertion_failed_msg should be affected by the same issue.

@chinz07 Would you be able to create a pull request fixing this? We'd be more than happy to accept such a patch.

@hkaiser Sure! I will submit a pull request as soon as possible.


Create tm1.txt

New High School

@zslitwarszawa Pull request merged. Please notice that free educational license for JetBrains tools is for high and higher schools students, i.e. those who are over 13 of age. Thank you!


Fix NPE when building blobProperties without account and container

When using RestUtils#buildBlobProperties without account and container
object injected in the RestRequest, it throws NPE. This PR makes it to
explicitly throw RestServerException instead of NPE.
Test: clean build

Codecov Report

Merging #733 into master will decrease coverage by 0.09%.
The diff coverage is 100%.

@@             Coverage Diff             @@
##             master     #733     +/-   ##
===========================================
- Coverage     65.73%   65.63%   -0.1%
+ Complexity     3811     3803      -8
===========================================
  Files           330      330
  Lines         25240    25244      +4
  Branches       3159     3161      +2
===========================================
- Hits          16592    16570     -22
- Misses         7771     7789     +18
- Partials        877      885      +8

Impacted Files
Coverage Δ
Complexity Δ

...src/main/java/com.github.ambry/rest/RestUtils.java
96.21% <100%> (+0.08%)
54 <0> (+2)
:arrow_up:

...in/java/com.github.ambry.clustermap/Partition.java
82.43% <0%> (-4.06%)
23% <0%> (-1%)

.../main/java/com.github.ambry.store/HardDeleter.java
80% <0%> (-1.94%)
41% <0%> (-1%)

.../src/main/java/com.github.ambry.store/Journal.java
89.65% <0%> (-1.73%)
19% <0%> (-1%)

...in/java/com.github.ambry.store/BlobStoreStats.java
85.61% <0%> (-1.68%)
93% <0%> (-1%)

...ava/com.github.ambry.store/BlobStoreCompactor.java
92.21% <0%> (-1.15%)
115% <0%> (-3%)

...java/com.github.ambry.store/CompactionManager.java
91.04% <0%> (-0.75%)
17% <0%> (ø)

...in/java/com.github.ambry.network/SocketServer.java
82.78% <0%> (-0.41%)
13% <0%> (ø)

...java/com.github.ambry.network/SSLTransmission.java
62.33% <0%> (-0.34%)
49% <0%> (-1%)

...ain/java/com.github.ambry.router/PutOperation.java
89.9% <0%> (-0.23%)
69% <0%> (-1%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 72fc287...a8ecfe5. Read the comment docs.


RFM - Windows Azure PowerShell

https://chocolatey.org/packages/WindowsAzurePowershell
I will pick this one up.

These two packages - 1 and 2 - are similar and should be deprecated

The AzurePowershell package should probably be the one that isn't deprecated, and rather deprecate WindowsAzurePowershell instead.

That's what was discussed on the email in the Google group. Which reminds me to reply to that.

azurepowershell package, version 5.0.0 and 5.5.0 have both been submitted. Both also require an exception which I've requested for 5.0.0 and will request for 5.5.0 when it fails.
Once both of these packages are accepted I'll then deprecate the other two.

Both packages have been deprecated (awaiting mod approval):
https://chocolatey.org/packages/WindowsAzurePowershell_0871
https://chocolatey.org/packages/WindowsAzurePowershell

Previously approved versions unlisted for both packages.


React Issue? Or Do I am Missing somthing...Maybe a hidden bug?

import React from 'react';
import { default as NQB } from '../../game/sidebar/next-quarter-button/next-quarter-button.jsx';
// import { default as advisorPanel } from '../advisor-panel/advisor-panel.jsx';
// import { default as companyName} from '../company-name/company-name.jsx';
//
//
export default React.createClass({
render() {
return (

                <NQB/>

    );
}

});
This WORKS
VS
import React from 'react';
import { default as nextQuarterButton } from '../../game/sidebar/next-quarter-button/next-quarter-button.jsx';
// import { default as advisorPanel } from '../advisor-panel/advisor-panel.jsx';
// import { default as companyName} from '../company-name/company-name.jsx';
//
//
export default React.createClass({
render() {
return (

                <nextQuarterButton/>

    );
}

});
Not Work, I have even replaced nextQuarterButton With nextQuarterButtonZ (Clearly not used anywhere else in code)
import React from 'react';
import { default as nextQuarterButtonZ } from '../../game/sidebar/next-quarter-button/next-quarter-button.jsx';
// import { default as advisorPanel } from '../advisor-panel/advisor-panel.jsx';
// import { default as companyName} from '../company-name/company-name.jsx';
//
//
export default React.createClass({
render() {
return (

                <nextQuarterButtonZ/>

    );
}

});
Also Not work. something fishy is going on. Any Clue? If not Ill use Short all cap var names for things that work with what that they should be called...

NQAX works, NQAXX Works. So... no idea whats going on.

React Components should start with a capital letter and be title case. I think that is the issue you are running into.

https://facebook.github.io/react/docs/jsx-in-depth.html#html-tags-vs.-react-components


Fix: Resend magic code link looks like not responding

@mananjadhav @puneetlath
Details

Fixed Issues

$ https://github.com/Expensify/App/issues/17345
PROPOSAL: https://github.com/Expensify/App/issues/17345#issuecomment-1520913749
Tests

Open App
Go to profile
Add as secondary login an email
Click Resend magic code link
Click Resend magic code link more times
Verify that the success message has effect for every trigger

[x] Verify that no errors appear in the JS console

Offline tests

Same as tests
QA Steps

Same as tests

[x] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android / native
[x] Android / Chrome
[x] iOS / native
[x] iOS / Safari
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[x] I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

https://user-images.githubusercontent.com/75031127/235539663-0878977e-b468-429b-b29e-57067c0ce193.mov

Mobile Web - Chrome

https://user-images.githubusercontent.com/75031127/235542433-f7827e50-b67f-41c7-9d6a-0a8a1f8b53e7.mov

Mobile Web - Safari

https://user-images.githubusercontent.com/75031127/235541138-07d67960-26f8-4cf1-91d1-5321fa3c42e8.mov

Desktop

https://user-images.githubusercontent.com/75031127/235543001-c5c6d7be-37b3-48b9-b457-fb25ec106444.mov

iOS

https://user-images.githubusercontent.com/75031127/235544637-14ab2636-33e0-42c4-9679-e75c954e408a.mov

Android

https://user-images.githubusercontent.com/75031127/235752771-874cd141-d1d2-428d-9267-9d04e60b83cb.mov

@puneetlath @mananjadhav One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

On the login page, it looks like the "link has been re-sent" text replaces the "resend magic code" text. Shall we do the same here?

On the login page, it looks like the "link has been re-sent" text replaces the "resend magic code" text. Shall we do the same here?

For the login page if you see the Resend  text is different from the Button. Hence, we show that. I think the current change in the PR looks good with both success and error scenarios.

@puneetlath @shawnborton what do you think?

Reviewer Checklist

[x] I have verified the author checklist is complete (all boxes are checked off).
[x] I verified the correct issue is linked in the ### Fixed Issues section above
[x] I verified testing steps are clear and they cover the changes made in this PR

[x] I verified the steps for local testing are in the Tests section
[x] I verified the steps for Staging and/or Production testing are in the QA steps section
[x] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[x] I checked that screenshots or videos are included for tests on all platforms
[x] I included screenshots or videos for tests on all platforms
[x] I verified tests pass on all platforms & I tested again on:

[x] Android / native
[x] Android / Chrome
[x] iOS / native
[x] iOS / Safari
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop

[x] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[x] I verified proper code patterns were followed (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I verified that this PR follows the guidelines as stated in the Review Guidelines
[x] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[x] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web
https://user-images.githubusercontent.com/3069065/235760669-c4dd8039-3562-4d00-bf64-c0328ef9ef10.mov

Mobile Web - Chrome
https://user-images.githubusercontent.com/3069065/235760839-ce2da994-a0e8-4168-b5ba-460ff96275c2.mov

Mobile Web - Safari
https://user-images.githubusercontent.com/3069065/235760901-6867a7a0-0522-40cb-9114-4b1da5be774f.mp4

Desktop
https://user-images.githubusercontent.com/3069065/235760942-a028ca64-4585-49e0-854e-2296ba67d4ea.mov

iOS
https://user-images.githubusercontent.com/3069065/235761527-553602d5-a105-41f0-ad5c-b4f7608ff7b9.mov

Android
https://user-images.githubusercontent.com/3069065/235760991-def1a2e1-bcf7-4531-bcee-7d1e52872ff3.mov

@puneetlath I've updated the checklist based on the original discussion except for your last comment. Do let me know

Looking good! I might just add like 8px more margin/padding above the dot indicator message.
Also, is there a way to make it fade in nicely rather than having it just appear?

@getusha @mananjadhav I think your logic makes sense, thanks. If we can just address @shawnborton's feedback then we should be good to go.

@getusha did you get a chance to look at @shawnborton's comment?

Extra margin looks good!

I think that's a fair point about animations. Let's handle that more holistically rather than here.

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to staging by https://github.com/puneetlath in version: 1.3.10-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/roryabraham in version: 1.3.12-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


Add Google Analytics integration

Added the option from config to use Google Analytics.
Resolves #30

Thanks to you, excellent tool.


Unable to generate summary in github

Got below error while running:
python cli.py --pr_url="https://github.com/XXX/pull/17" describe
    changes in file: No changes were made to the file. stop
INFO:root:Preparing answer...
ERROR:root:Failed to parse AI prediction: while scanning a simple key
  in "<unicode string>", line 5, column 1:
    The PR changes the filename of a ...
    ^
could not find expected ':'
  in "<unicode string>", line 6, column 1:
    PR Main Files Walkthrough:
    ^
INFO:root:Successfully parsed AI prediction after removing 6 lines
INFO:root:Pushing answer...

@okotek it is our org private repo but it is happening when PR Title value has ":"
e.g. PR Title: PROJ-324: Need to handle special characters

@saumilsdk thanks for the feedback. will take a look

I wasn't able to reproduce this, do you mind sharing the result AI completion? I'm not sure that your solution would work for the general case of malformed YAML


RangeError: Invalid time value

Describe the bug
To Reproduce
Expected behavior
Screenshots
Applicable Versions:

Decap CMS version<EMAIL_ADDRESS>Git provider: git-gateway
Browser version: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/<IP_ADDRESS> Safari/537.36

CMS configuration
backend:
  name: git-gateway
  branch: master
media_folder: static/img
collections:
  - name: blog
    label: Post
    folder: posts
    create: true
    slug: "{{slug}}"
    fields:
      - label: Title
        name: title
        widget: string
      - label: Publish Date
        name: date
        widget: datetime
      - label: Author
        name: author
        widget: string
        default: Anonymous
      - label: Summary
        name: summary
        widget: text
      - label: Tags
        name: tags
        widget: list
        default:
          - post
      - label: Body
        name: body
        widget: markdown
    publish: true
    type: folder_based_collection
    sortable_fields:
      - commit_date
      - title
      - date
      - author
      - summary
    view_filters: []
    view_groups: []
  - name: pages
    label: Page
    folder: pages
    create: false
    slug: "{{slug}}"
    fields:
      - label: Title
        name: title
        widget: string
      - label: Publish Date
        name: date
        widget: datetime
      - label: Permalink
        name: permalink
        widget: string
      - label: Navigation
        name: eleventyNavigation
        widget: object
        fields:
          - label: Key
            name: key
            widget: string
          - label: Order
            name: order
            widget: number
            default: 0
      - label: Body
        name: body
        widget: markdown
    publish: true
    type: folder_based_collection
    sortable_fields:
      - commit_date
      - title
      - date
      - commit_author
    view_filters: []
    view_groups: []
publish_mode: simple
slug:
  encoding: unicode
  clean_accents: false
  sanitize_replacement: "-"
public_folder: /static/img
isFetching: false
error: null

Additional context

Hi @jcrabapple, please fill out all the fields in the issue template. The information you provided is not enough to debug the problem.
I'm closing the issue for now. Once you add the missing information, I can open it again.


can't disable namespace

environment: node
I use same namespace across few files.
When I disable namespace in one file
    let namespaces = enabledNamespaces()
    const index = namespaces.indexOf(namespace)
    namespaces[index] = `-${namespace}`
    debug.enable(namespaces.join())

in other other file I see that debug doesn't have this namespace in the list of names, but the namespace still enabled  and there is an output.

See #425


[AutoRelease] t2-connectedvmware-2023-10-25-44104(can only be merged by SDK owner)

https://github.com/Azure/sdk-release-request/issues/4547
Live test success
https://dev.azure.com/azure-sdk/internal/_build?definitionId=3325

issue link:https://github.com/Azure/sdk-release-request/issues/4547


Ability to show progress

I'm currently attempting to use ps-osc on a two billion row, 482 GB (223 table/259 index) table. Needless to say, it's taking a long time. I'm actually starting to doubt if it's actually working as the output is just this so far after twenty hours:
{"name":"pg-online-schema-change","hostname":"Bryces-MacBook-Pro-M2.local","pid":19905,"level":40,"time":"2023-07-27T17:34:49.736-04:00","v":0,"msg":"DEPRECATED: -w is deprecated. Please pass PGPASSWORD environment variable instead.","version":"0.9.2"}
WARNING:  there is already a transaction in progress
{"name":"pg-online-schema-change","hostname":"Bryces-MacBook-Pro-M2.local","pid":19905,"level":30,"time":"2023-07-27T17:34:51.126-04:00","v":0,"msg":"Setting up audit table","audit_table":"pgosc_at_mytable_c16c36","version":"0.9.2"}
{"name":"pg-online-schema-change","hostname":"Bryces-MacBook-Pro-M2.local","pid":19905,"level":30,"time":"2023-07-27T17:34:51.382-04:00","v":0,"msg":"Setting up triggers","version":"0.9.2"}
WARNING:  there is already a transaction in progress
WARNING:  there is already a transaction in progress
WARNING:  there is no transaction in progress
{"name":"pg-online-schema-change","hostname":"Bryces-MacBook-Pro-M2.local","pid":19905,"level":30,"time":"2023-07-27T17:34:51.714-04:00","v":0,"msg":"Setting up shadow table","shadow_table":"pgosc_st_mytable_c16c36","version":"0.9.2"}
WARNING:  there is already a transaction in progress
WARNING:  there is already a transaction in progress
{"name":"pg-online-schema-change","hostname":"Bryces-MacBook-Pro-M2.local","pid":19905,"level":30,"time":"2023-07-27T17:34:51.937-04:00","v":0,"msg":"Running alter statement on shadow table","shadow_table":"pgosc_st_mytable_c16c36","parent_table":"mytable","version":"0.9.2"}
WARNING:  there is already a transaction in progress
{"name":"pg-online-schema-change","hostname":"Bryces-MacBook-Pro-M2.local","pid":19905,"level":30,"time":"2023-07-27T17:34:52.051-04:00","v":0,"msg":"Clearing contents of audit table before copy..","shadow_table":"pgosc_st_mytable_c16c36","parent_table":"mytable","version":"0.9.2"}
WARNING:  there is already a transaction in progress
{"name":"pg-online-schema-change","hostname":"Bryces-MacBook-Pro-M2.local","pid":19905,"level":30,"time":"2023-07-27T17:34:52.148-04:00","v":0,"msg":"Copying contents..","shadow_table":"pgosc_st_mytable_c16c36","parent_table":"mytable","version":"0.9.2"}
WARNING:  there is already a transaction in progress
WARNING:  there is already a transaction in progress

Is there a way to show any sort of progress indicator while the tool is running? I realize this would be challenging as the copy_data! command is just running a query inside a larger transaction. I'm not sure if it's even possible to get visibility into this, but it sure would be nice!

You could take a look at pg_stat_activity with something like:
SELECT *
  FROM pg_stat_activity
 WHERE state <> 'idle'
;

and see what's happening on the db side.

@jfrost Yeah, I can see the INSERT INTO running in the process list. Just no idea how long it will take. My original command failed with an PQconsumeInput() server closed the connection unexpectedly (PG::ConnectionBad) error after over 20 hours. I have it running again to see if I can actually get it to run successfully. It brings to mind so many nice potential features:

Showing progress
Restarting a failed process (need to keep persisted state somehow)
Some sort of preview/recommendation feature that scan the size of your database, looks at the host resources (CPU/Memory), and various PG settings (max_wal_size etc.), and gives an idea of how long the process might take and any tweaks that might help.

Anyway, we'll see how this turns out. I also have a custom SQL script running on a test instance that uses a different approach for changing a primary key from int4 to int8. Hopefully one of these will succeed and I can run it on the real thing and move on.

Quick update, I did finally get the command to finish on a test instance. It took a little over 21 hours. Some way to show progress would be nice, though. Feel free to close this issue if there's no viable way to do it.

@brycethornton They have --verbose command to show you what is currently happening.

They have --verbose command to show you what is currently happening.

@sasharevzin Thanks. Yeah, that does add some handy output but the specific area where I would love some more visibility is during the Copying contents.. portion. I know what happens during this time but I don't know how far long it is at any given time. It's not a huge deal on smaller tables but on a really large table it would be really hand to know that it's 25%, 50%, 75%, etc. done with the "INSERT INTO..." statement. I don't think there's a good way to do this unfortunately.

I wonder if we periodically compare the count of the rows between tables and log a percentage complete every minute or so. I guess it might be hard to do with the transaction that is running the copy not completed 🤔

Yeah, I haven't been able to find a way to do it since the shadow table creation and insertion are all within the same transaction. I can't get any visibility.

Sorry I'm late writing back...vacation got a little hectic. The joys of MVCC keep us from really seeing what the row count is. The only thing I can think of would be to look at the on disk file sizes, but you can only do that if you have access to the filesystem, so no way to do it on platforms like RDS.

My workaround on RDS was to monitor the free storage space. Since this was such a big table I could roughly see how far along it was as free storage space shrunk:

Oh good point and you could watch the raw metric in cloudwatch if it's a smaller table. That would work well enough for DBs with relatively stable sizes and big tables like you mentioned!

@shayonj is it possible to do this on the shadow table and compare it to the original table? That'll give you a decent sense of progress. I have no idea whether this works on the shadow table while it's in a transaction.
SELECT pg_size_pretty(pg_total_relation_size('"<schema>"."<table>"'));

ah! i missed that the table creation happens from the same transaction as well, which means the table isn't visible to another connection either.
This is interesting....
https://github.com/shayonj/pg-osc/blob/baa638f5a48fbc0289b74d3ce2c76602a9b7482a/lib/pg_online_schema_change/orchestrate.rb#L166-L175

v0.9.7 is now out with the new estimated progress in logs during copy: https://github.com/shayonj/pg-osc/releases/tag/v0.9.7
Please feel free to share any ideas, feedback and bugs. Thanks everyone for all the brainstorming and feedback.
Closing now.

Thank you, @shayonj! I'm excited to give this a spin soon!

Woot! Would love to hear your thoughts.
Going to release 0.9.8 today evening. Looks like there are some gem version conflicts currently. Stay tuned.


[refmt bug] renames quoted object fields, inconsistently since bs-platform 7.0.0.

In bs-platform "7.0.0 this gives a type error.
type marshalFields = {
  .
  "switch__": string,
};

let testMarshalFields: marshalFields = {
  "switch__": "switch",
};

reformats to ocaml:
type marshalFields = < switch: string   >  Js.t
let testMarshalFields = ([%bs.obj { switch_ = "switch" }] : marshalFields)

This is what it used to reformat to with bs-platform 7.0.0-dev.2:
type marshalFields = < switch__: string   >  Js.t
let testMarshalFields = ([%bs.obj { switch__ = "switch" }] : marshalFields)

Any chance that we can get a quick fix? doing a minor release soon, if so we can get it in, thanks

For reference, here are some tests I had to change until this is resolved:
https://github.com/cristianoc/genType/pull/316/commits/15109ad6351371585d02700f08411c04fb34f07f


Console can't run console commands

I tried running /ppcheck against a player and it stated that the console didn't have the right permission to do so. The code specifically locks this command to the console so the permission is rather redundant.
Commands that can be run by players or the console should explicitly grant the console permission. Humbug tags a permission group onto the console object and then adds the individual command permissions into that group (plugin.yml). For commands that are hard coded to only run in the console, the permission is unnecessary.
https://github.com/Civcraft/Humbug/blob/master/src/main/java/com/untamedears/humbug/Humbug.java#L2375

was this solved in the new version?

its /pplocateany not /ppcheck right? or are they aliases, if they are then /pplocateany works perfectly.

They are different commands.
On Wed, Jul 1, 2015 at 4:08 PM, ttk2<EMAIL_ADDRESS>wrote:

its /pplocateany not /ppcheck right? or are they aliases, if they are then
/pplocateany works perfectly.
—
Reply to this email directly or view it on GitHub
https://github.com/Civcraft/PrisonPearl/issues/32#issuecomment-117846824
.

yup still no perms to run it from the console.

#55

This can be closed.


Release 0.7.4

Thank you @Shatur for some fixes to consistency in the Bevy demo, and @TotalKrill for finding a bug :pray:

Changing connection mechanism is a breaking change, I would suggest to go with 0.8.

Looks like it's only a breaking change on the Bevy adapters ... I'll increment those to 0.8.0 and 0.7.4 for the others.  I'll make sure all versions get incremented together in a more major releases :+1:
Thank you!


Has anyone met the following problem during the running of "interactive_gui.py"?

Traceback (most recent call last):
File "interactive_gui.py", line 23, in
from PyQt5.QtWidgets import (QWidget, QApplication, QMainWindow, QComboBox, QGridLayout,
ImportError: /usr/lib/x86_64-linux-gnu/libQt5Core.so.5: version `Qt_5.15' not found (required by /home/fg/anaconda3/envs/MiVOS/lib/python3.7/site-packages/PyQt5/QtWidgets.abi3.so)

@hkchengrex

pip install PyQt5
Looking in indexes: https://pypi.tuna.tsinghua.edu.cn/simple
Requirement already satisfied: PyQt5 in /home/fg/anaconda3/envs/MiVOS/lib/python3.7/site-packages (5.15.4)
Requirement already satisfied: PyQt5-sip<13,>=12.8 in /home/fg/anaconda3/envs/MiVOS/lib/python3.7/site-packages (from PyQt5) (12.8.1)
Requirement already satisfied: PyQt5-Qt5>=5.15 in /home/fg/anaconda3/envs/MiVOS/lib/python3.7/site-packages (from PyQt5) (5.15.2)
######################################################
I have tried to reinstall it, but the prompt reminds me that I have had it in the environment.

I have not encountered this problem before. Probably you have a system installed Qt (which is not the same as the one installed by pip) and python is not linking correctly. This might help: https://stackoverflow.com/questions/39129615/pyqt5-not-finding-installed-qt5-library

https://blog.csdn.net/jiguangfan/article/details/86488573. @hkchengrex Thank you very much!!!!


Upgrade to liquibase 4.9.0

Are there any plans to upgrade to the latest version of liquibase (currently 4.9.0 - https://github.com/liquibase/liquibase/releases)?

Bumparino


Updated to be compatible w/ 10.11 CoreServices changes

Many LSSharedFile____ functions were moved to "SharedFileList/LSSharedFileList.h" in OS X 10.11
(See https://developer.apple.com/library/mac/releasenotes/General/APIDiffsMacOSX10_11/Objective-C/CoreServices.html)
Updated imports to check version and manually load LSSharedFile functions from new location if os_vers > 10.10.9

Awesome!


Roll engine 3496156bd9bf..bb354363e0bb (6 commits)

https://github.com/flutter/engine/compare/3496156bd9bf...bb354363e0bb
git log 3496156bd9bfe61788bf64ce3ca3cf1bc2663f95..bb354363e0bb5cee5d8e561f144a9bc7e1d364cc --no-merges --oneline
bb354363e Roll src/third_party/dart 70e3e67dd7..5e9df35a57 (45 commits)
3b19a4d30 Removed dart_plugin_tag from DEPS
d9b6629b6 Roll src/third_party/skia 4273a150f84d..ba91f65f2070 (6 commits) (flutter/engine#8225)
e88573aef Roll src/third_party/skia d7d93001ead2..4273a150f84d (1 commits) (flutter/engine#8224)
be9067cc7 Roll src/third_party/skia 37a9294d2eb9..d7d93001ead2 (2 commits) (flutter/engine#8223)
ee4abba58 Roll src/third_party/skia 2894d13a0d9b..37a9294d2eb9 (1 commits) (flutter/engine#8222)
The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff (liyuqian@google.com), and stop
the roller if necessary.

Trybots failed. These were the failed builds: https://cirrus-ci.com/task/5041916855975936

Commit queue failed; closing this roll.


Set Environment Variable

I would like to know if it is possible to define an environment variable when I run my 2e2 tests and get it in my js code.
Thx

process.env.ENV_VAR? See also https://stackoverflow.com/questions/12236890/run-mocha-tests-in-test-environment

That would be for the tester project, not the app process.

Ok, i'm using dotenv now, what's the best practice to call a particular .env file when I running detox test


[Feature Request] Add Approve button to the main PR page

Introduction
Currently when you want to approve a PR you have to navigate to PR > Files Changed > Review > Approve. It is not only confusing for beginners but also a unnecessary handicap. Of course you should review the changes before approving but still a unnecessary amount of "work"
Proposal
Add a Approve button right next to the Merge button

Why you want to approve before you have reviewed the code?

Why you want to approve before you have reviewed the code?

I did not say that I want to approve before reviewing

Of course you should review the changes before approving

Why you want to approve before you have reviewed the code?

I did not say that I want to approve before reviewing

Of course you should review the changes before approving

So I think it's suitable only put the button on review page but not conversation page.

I agree, it doesn't make sense to have the approval button outside the Files Changed tab


Translation modules

Has anyone tried using this module with either Fluent or Translatable?
It seems the whole one page and navigation breaks when Fluent is set up on the project.
Any ideas what might be the case?

Hello past me, I'm back 3 years later with a fix!

Nice one! Thanks for the contribution!


automatically go to tailing service.log (or other log file) after clicking 'run now'

(reopening #475 against master instead of hs_staging)

@benrlodge I'm not a fan of how you're passing 2 extra collections views/request for the sake of a bunch of logic I don't think should even be in there. The 80-ish lines you're adding to the view don't have anything to do with that part of the UI.
What I'd do here is put this stuff in its own class, maybe call it lib/TaskPoller or something like that. Then you can just use that inside of views/requests while keeping all of the logic in its own neat little package that can be re-used if necessary. Speaking of re-using, does all of this polling stuff work if you use the requests table run-now button?
I haven't been following SUI development over the past few months so sorry if I'm sticking my nose somewhere it's not welcome or if I'm misreading what you're doing! I got an email notification related to this and thought I'd have a look at it for the craic.
cc @tpetr @timmfin

@tpetr I moved the auto tailing logic out of the request view and into a reusable lib/AutoTailer class. I also included this class in the views/requests table view as well


Neo cli daemon with wallet unlock

added --rpcwallet option.
this function allow to unlock a wallet before start neo rpc server.
usage:
dotnet neo-cli.dll --rpcwallet "/home/user/walletpath/wallet.db3" "W4LL3tP4sSw0rD 01"
dotnet neo-cli.dll --rpcwallet "/home/user/walletpath/wallet.json" "W4LL3tP4sSw0rD 01"
or with screen (linux)
screen -dmS neod dotnet neo-cli.dll --rpcwallet "/home/user/walletpath/wallet.db3" "W4LL3tP4sSw0rD 01"
screen -dmS neod dotnet neo-cli.dll --rpcwallet "/home/user/walletpath/wallet.json" "W4LL3tP4sSw0rD 01"
<EMAIL_ADDRESS>Donations are welcome XD we are developing NEO WEB PANEL MANAGER for NEO NODES (also private deploy of NEO blockchain).
NEO: AYUd4G2dNXAEyUxkZGyMdXAnJ396jJfNDz
ETC: 0x982e45402ad06d0a01f3e54732b28c76d9870422
BTC: 1HxdgF6WsvcRVNiXhz6jZgbD9eopvzAxap
ETH: 0x5cb3784e71710f681410d30d615a3b3bb3c24ff1

How many critical projects do this is by using environment variables for passwords and keys.

can we read it from file like ethereum?

Hi erik, chris,
load password from file commit just made.
Let me know if can be included in master branch.
Thanks,
Tiz

I have no say in this, but generally I think environment variables are more robust and flexible.

Hi Erik,
new changes just commited.
https://github.com/neo-project/neo-cli/pull/152


Same accuracy optimise load profile

Currently, in v2.2.0, we added a lot of options to customize the convergence behaviour of iterative methods within GHEtool. However, the optimise load profile method still works with a predefined temperature limit of 0.05°C.
In this issue we convert this also to the custom convergence criteria.

This is due to a difference in convergence criteria.
Where the size method converges based on a difference in required depth between two iterations, the optimise load profile converges based on a difference in fluid temperature w.r.t. the respective limit.
This can cause a difference in results that when the optimise method says that 100% of a load can be put onto a borefield of 150m deep, the sizing method can give you back another depth, since it converges in another way. It will however not differ that much in the end.


Cloud

Cloud class for #32

Should we perhaps use this: https://github.com/fsspec/universal_pathlib?

Should we perhaps use this: https://github.com/fsspec/universal_pathlib?

Cool, let's do it later?


Document debug vars valuesWrittenOK and pointsWrittenOK

Closes #1608

[x] Tests pass (no build errors)
[x] Rebased/mergeable

In the code these are defined here: https://github.com/influxdata/influxdb/blob/master-1.x/services/httpd/service.go#L21-L47.

@pierwill , @kelseiv  -- please correct me if i'm wrong but i think you're asking if the pointsWrittenOK and valuesWrittenOK stats we see in the show stats output is the same as the values we see in the debug vars obtained via the http endpoint.
to that the answer is yes. :)
did i understand the question?

Thank you, @ayang64 @pierwill,
My question was this:
Should pointsWrittenOK and valuesWrittenOK be in both the httpd measurement and the write measurement?
In this PR, we added both values to the write measurement. ThepointsWrittenOK value was already included in the httpd measurement. Do we also add valuesWrittenOK to the httpd measurement?


Wrong pressure units for Ecobee Weather component

Home Assistant release with the issue:
0.94.1
Last working Home Assistant release (if known):
Unknown
Operating environment (Hass.io/Docker/Windows/etc.):
Hassbian on rPi
Component/platform:
https://www.home-assistant.io/components/ecobee
Description of problem:
It appears the pressure unit advertised by the Ecobee weather component is incorrect. The Ecobee docs are unclear about the unit passed, but based on my current value of 1012 I would bet the units are mbar (since normal atmospheric pressure (1 atm) is 1013.25mbar). I'm seeing inHg in the unit display. Possible this is limited to HA installations not using metric.

Problem-relevant configuration.yaml entries and (fill out even if it seems unimportant):
ecobee:
  api_key: !secret ecobee_api_key

I hope this comment is a) allowed, and b) helpful. I am seeing this error on my HA (0.95.4), and in pursuit of a solution, noticed this:
https://www.home-assistant.io/lovelace/weather-forecast/
The documentation for the Weather Forecast Card itself shows a pressure that must certainly be in the (same) wrong units!
Not sure what this tells us, but it's a data point, no?

I don't have a unit to test, so I'm hesitant to put in new code without being able to test it.  The Ecobee weather platform needs to check for the unit system and convert accordingly.  Note that visibility is also presumably in meters but presented as miles.  Wind speed is presumably in miles per hour (the api documentation says it will be in mph * 1000 but this seems to not be the case here), so it will be wrong using metric too, since it will display as km/hr.
A lot of weather platforms suffer from unit mismatches in either imperial or metric systems.  I fixed openweathermap and dark sky not too long ago for pressure.  Check here for an example of how openweathermap handles it:
https://github.com/home-assistant/home-assistant/blob/dev/homeassistant/components/openweathermap/weather.py#L112-L119

Wow. I'm new to this codebase (so apologies if this comes across as brash or ungrateful or whatever), but at first glance, what a mess! In that code you referenced, I see your nice-looking code that handles the conversion, some code later on with hard-coded constants, and just above it, code that just seems to assume metric! I kinda would have thought the framework would have some facility for returning a nicely-formatted string with the current {pressure, temperature, whatever} in the local language, in the local units. Apparently not.

It is a bit of a mess.  HA moves fast and integrations get left behind unless someone is willing to put in PRs.  Hint, hint.  I would note that temperature is the only attribute that handles conversion by itself in a weather platform, so it doesn't assume metric.

I am definitely interested in doing my part, but I've got some learnin' to do before I jump in. If I can fix the bug that I see on my system, I will certainly push it back.
I'm not sure about your statement that "it doesn't assume metric". I see
    @property
    def temperature(self):
        """Return the temperature."""
        return self.data.get_temperature('celsius').get('temp')

which looks pretty assumptuous to me. ;-) [I know that's not a word.]

If you look just below your quote, there is a temperature unit property.  Then in the weather component itself, you can see where the state attributes are defined, see link.  Temperature is converted to the requested units but not of the others are.
https://github.com/home-assistant/home-assistant/blob/dev/homeassistant/components/weather/__init__.py#L117-L123

Proof is also in the pudding.  Switch your units in your config to metric, only temperature will change in Ecobee.


Is it possible and how, if yes, one can have different width for selected and non-selected cell?

Is it possible and how, if yes, one can have different width for selected and non-selected cell?
Maybe somehow using different xibs?

Use cell.selectionStyle = UITableViewCellSelectionStyleGray;

Apparently that wasn't clear.
I meant here collectionViewCell in the pagingMenu itself.
So that cell (buttonBarItem) that is currently selected has different width from all other cells/ buttonBarItems.

It's not possible at least i can't figure out a easy way.


KeyedGather does not work on byte[] keys

Keyed Gather operation does not work on byte[] keys, all the values are sent separately.

Are you running an example or your own code?

The current example does not have an byte[] key, so i added an example to the KGatherExample and ran that. Will push that example

Found the possible reason, in KGatherBatchFinalReceiver merge method we use an Hashmap and use the K value as the key into the HashMap when merging, since byte[] does not have "value equality" each K value is taken as a new value for the Map.

Then I think this could happen to any Key type that inherits equals and
hashcode methods from Object class.
We can write array wrappers for array types that would implement equals and
hashcode methods. Then use wrapper as the key for the hashmap. But that
would be super inefficient for large arrays.
On Wed, Nov 27, 2019, 21:35 Pulasthi Supun<EMAIL_ADDRESS>wrote:

Found the possible reason, in KGatherBatchFinalReceiver merge method we
use an Hashmap and use the K value as the key into the HashMap when
merging, since byte[] does not have "value equality" each K value is taken
as a new value for the Map.
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
https://github.com/DSC-SPIDAL/twister2/issues/783?email_source=notifications&email_token=ABXZKCOGVAQAGNFIDNPLF7LQV4U5ZA5CNFSM4JSNTC4KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEFLIA4I#issuecomment-559317105,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABXZKCIP3VFMLTL7BL6OHTTQV4U5ZANCNFSM4JSNTC4A
.

@pulasthi @supunkamburugamuve any suggestions?

Yeah, that sounds like a good solution, since we already define other details such as packers in the MessageTypes class we can associate the wrapper with that too. This wrapper needs to be used at the destination selector as well (in the HashingSelector) since we again use the hashCode value to determine the target.
However, it looks like we would need to change a lot of places to correctly apply the changes. I do have a solution (hack) for the byte[] issue, maybe we can use that for the 0.4.0 release and make this change for the next release. WDYT?

fixed with pull #788


Can not install in OpenShift or maybe any else k8s environments with PodSecurityPolicy enabled

Describe the bug
While installing helm, I found that k8s can't create the first pod by Job pulsar-mini-kube-prometheu-admission-create in the first step.
After checking, it was found that the pulsar installation does not support K8s with tighter restrictions on container or PodSecurityPolicy enabled.
Is it my understanding that helm deployments are not available for production environments yet?
To Reproduce
helm install \
    --values ./values-openshift.yaml \
    --namespace pulsar \
    pulsar ./charts/pulsar
Error: INSTALLATION FAILED: failed pre-install: timed out waiting for the condition

Expected behavior
A clear and concise description of what you expected to happen.
Screenshots

Desktop (please complete the following information):

OS: OpenShift 4

Additional context
Add any other context about the problem here.

bookeeper and zookeeper also have this problem:

I've temporarily manually bound a few openshift permissions and am currently pulling image.
However, I've found that the PodSecurityPolicy resource will be unavailable at 1.25.
W0724 14:45:03.839188   30985 warnings.go:70] policy/v1beta1 PodSecurityPolicy is deprecated in v1.21+, unavailable in v1.25+
W0724 14:45:03.844912   30985 warnings.go:70] policy/v1beta1 PodSecurityPolicy is deprecated in v1.21+, unavailable in v1.25+
W0724 14:45:03.850366   30985 warnings.go:70] policy/v1beta1 PodSecurityPolicy is deprecated in v1.21+, unavailable in v1.25+
W0724 14:45:03.855862   30985 warnings.go:70] policy/v1beta1 PodSecurityPolicy is deprecated in v1.21+, unavailable in v1.25+
W0724 14:45:03.862282   30985 warnings.go:70] policy/v1beta1 PodSecurityPolicy is deprecated in v1.21+, unavailable in v1.25+
W0724 14:45:03.871034   30985 warnings.go:70] policy/v1beta1 PodSecurityPolicy is deprecated in v1.21+, unavailable in v1.25+
W0724 14:45:04.721243   30985 warnings.go:70] policy/v1beta1 PodSecurityPolicy is deprecated in v1.21+, unavailable in v1.25+
W0724 14:45:04.721809   30985 warnings.go:70] policy/v1beta1 PodSecurityPolicy is deprecated in v1.21+, unavailable in v1.25+
W0724 14:45:04.722587   30985 warnings.go:70] policy/v1beta1 PodSecurityPolicy is deprecated in v1.21+, unavailable in v1.25+
W0724 14:45:04.722694   30985 warnings.go:70] policy/v1beta1 PodSecurityPolicy is deprecated in v1.21+, unavailable in v1.25+
W0724 14:45:04.723155   30985 warnings.go:70] policy/v1beta1 PodSecurityPolicy is deprecated in v1.21+, unavailable in v1.25+
W0724 14:45:04.723338   30985 warnings.go:70] policy/v1beta1 PodSecurityPolicy is deprecated in v1.21+, unavailable in v1.25+

Another question I have is why does pulsar use one all-image instead of splitting into different images for different components?

Another question I have is why does pulsar use one all-image instead of splitting into different images for different components?

Please discuss this on Pulsar Slack or GitHub Discussions, see https://pulsar.apache.org/community/#section-discussions

It should be possible to deploy on OpenShift. Please open another issue if it doesn't work with the latest chart release.


DRA1-UCA-EP04-US06 Inbound Data Capabilities

As a Manufacturer
I want to have the capability to handle additional information without impacting system performance or detracting from the user experience. For example display a recall message, display Anti-counterfeit check, displaying of different language files
So That potential future requirements can be easily built on top
User Story Rationale/ Examples:
The rationale behind this user story is for the designers/ developers to consider, as much as reasonably possible, future proofing the design of the solution and not just considering ePI as the end goal. We want to reduce/ minimize future costs when deploying additional use cases

User Story Rationale/ Examples:
The rationale behind this user story is for the designers/ developers to consider, as much as reasonably possible, future proofing the design of the solution and not just considering ePI as the end goal. We want to reduce/ minimize future costs when deploying additional use cases

User Story Rationale/ Examples:
The rationale behind this user story is for the designers/ developers to consider, as much as reasonably possible, future proofing the design of the solution and not just considering ePI as the end goal. We want to reduce/ minimize future costs when deploying additional use cases

User Story Rationale/ Examples:
The rationale behind this user story is for the designers/ developers to consider, as much as reasonably possible, future proofing the design of the solution and not just considering ePI as the end goal. We want to reduce/ minimize future costs when deploying additional use cases

User Story Rationale/ Examples:
The rationale behind this user story is for the designers/ developers to consider, as much as reasonably possible, future proofing the design of the solution and not just considering ePI as the end goal. We want to reduce/ minimize future costs when deploying additional use cases

Question: Languages of ePI: what is content standard format to be used?
Question: Recall: what is the process to trigger the message? Where does the message come from?
Blocker:
a.	app language: No
b.	content language: Yes
c.	recall message: Yes

Question: Languages of ePI: what is content standard format to be used?
Question: Recall: what is the process to trigger the message? Where does the message come from?
Blocker:
a.	app language: No
b.	content language: Yes
c.	recall message: Yes

It is clear that the ePI needs to be in all the current languages used across the Globe. PharmaLedger will not change this. There is no standard for the format right now. we should continue using the spl structure. Is there a technical issue in displaying French or Chinese for example, if it was in the spl format/ structure?
The trigger for the recall process will depend on the backend integration. It cannot be seen as a standalone function.

Action items -

Use the right encoding on the SPL (XML) for different languages and test it [@maherpa2 ]


Fix hidden StatusBar reappearing after exiting app on Android

I changed the technique used to hide the status bar and now it works properly. Also changed the way flags are set on the decorView to make sure it doesn't cause issues with other flags already set and fix deprecated Promise.reject
Test plan
Test using the UIExplorer StatusBar example, change the hidden prop value and go in and out of the app making sure the status bar has the right visibility.
Fixes #5991

Since you're the owner of this module I trust you :) One nit about potential NullPointerExceptions and let's merge this.

@facebook-github-bot shipit


Temporary Personal Numbers

Hi Guys!
Nice small project you guys built here.
I was wondering if you have intentionally left the temporary personal numbers out or this is something you haven't taken into consideration?
An input of YYYYMMDDTXXX / YYMMDDTXXX should actually be true, the way you can simply fix this and support temporary personal numbers is to check if there is a T and replace that with 1 before you make the validation check. We currently do this in code before we check for validation and it's not a big deal however it would be nice if it's implemented in this project by default.
Thank you!

Hi there @endri55 !
When it comes to temporary ones, the system have changed to "samordningsnummer" (coordination numbers), I'm not sure if there are anyone who have a tilldelningsnummer in Sweden as of now?
Now, I have only done some quick checks for it, so if you have any sources which shows it as something actually used still in any way, I'll gladly propose it as an option in the api specification :)

Hi @Johannestegner,
The temporary number is still widely used for students in Sweden.
The personal identity number issued by the Tax Agency should not be confused with the temporary registration number, a 4-digit number following your date of birth containing the letter ‘T’, given to you by KTH when you were admitted. Format of T-number: YYMMDD-TXXX
Source: https://www.kth.se/en/student/studentliv/new-in-sweden/swedish-personal-identity-number-1.443883
Our solution for this is by simply replacing the T with 1 and then it works fine with the verifier.
str.replace("T", "1")
Before passing it onto the other function to verify should do the trick.

@endri55 Hey, sorry for the late answer, i've started to look into this and it's not hard to fix and we should probably do it. The hard part is to find some valid TP-numbers that can be public and that we can use for our tests. Do you know any numbers that we can use?
I've also tried to search GitHub for other personnummer packages and see how they do with TP-numbers and haven't found any package that actual implemented this and then I didn't found any testdata.
We have this folder of testdata where we would like to add test TP-numbers https://github.com/personnummer/meta/tree/master/testdata

Moving this discussion to meta repository since it will not just be a change in the JavaScript package https://github.com/personnummer/meta/issues/43


sparse + dask array not supported

cc @hameerabbasi
dask+sparse works, but not sparse+dask.
I think dask should probably implement this case, via it's __array_ufunc__ method. Here's the traceback:
In [1]: import sparse

In [2]: import dask.array as da

In [3]: import numpy as np

In [4]: x = np.arange(3)

In [5]: y = sparse.COO(x)

In [6]: z = da.from_array(y, chunks=3)

In [7]: z + y
Out[7]: dask.array<add, shape=(3,), dtype=int64, chunksize=(3,)>

In [8]: y + z
---------------------------------------------------------------------------
TypeError                                 Traceback (most recent call last)
<ipython-input-8-ff96b8185f8d> in <module>
----> 1 y + z

~/miniconda3/envs/xarray-py37-dev/lib/python3.7/site-packages/numpy/lib/mixins.py in func(self, other)
     23         if _disables_array_ufunc(other):
     24             return NotImplemented
---> 25         return ufunc(self, other)
     26     func.__name__ = '__{}__'.format(name)
     27     return func

TypeError: operand type(s) all returned NotImplemented from __array_ufunc__(<ufunc 'add'>, '__call__', <COO: shape=(3,), dtype=int64, nnz=2, fill_value=0>, dask.array<array, shape=(3,), dtype=int64, chunksize=(3,)>): 'COO', 'Array'

What do you think would be the right approach here?  Call da.from_array on all non-dask arrays?
Currently we have this code, which seems problematic:
https://github.com/dask/dask/blob/6f382404707df2d7ca70d44bd36ecae485de4028/dask/array/core.py#L1106-L1110
I wonder if just removing that check would make things work

I think probably adding a `hasattr(..., 'array_ufunc') would help here.

Xarary defines array_ufunc, so that wouldn't be enough. Dask needs to
defer to xarray, but handle sparse arrays itself. I don't know if there's a
good way to do that without an explicit list of valid or invalid "array
chunk types".
On Mon, Aug 12, 2019 at 6:48 AM Hameer Abbasi<EMAIL_ADDRESS>wrote:

I think probably adding a `hasattr(..., 'array_ufunc') would help here.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/dask/dask/issues/5259?email_source=notifications&email_token=AAJJFVVTDWXY2MOJU2XHYITQEFSZTA5CNFSM4IK5QBXKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD4CSSZA#issuecomment-520431972,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAJJFVWRCWNCCUNN5YV7VHLQEFSZTANCNFSM4IK5QBXA
.

Maybe there needs to be a way to declare something as “ndarray-compatible”, this has come up before.

Maybe there needs to be a way to declare something as “ndarray-compatible”, this has come up before.

Right, but remember that other "ndarray-compatible" arrays might need to wrap dask arrays. For example, if someone wrote a duck type compatible version of autograd.

What do you think would be the right approach here? Call da.from_array on all non-dask arrays?

We call da.asarray in other places to handle non-Dask Arrays. Seems reasonable to do it here too.

We call da.asarray in other places to handle non-Dask Arrays. Seems reasonable to do it here too.

yes, though with overriding numpy ufuncs we still have to be careful to explicitly skip types like xarray.DataArray

Right, but remember that other "ndarray-compatible" arrays might need to wrap dask arrays. For example, if someone wrote a duck type compatible version of autograd.

Wouldn’t autograd be wrapped by Dask Array instead?

We call da.asarray in other places to handle non-Dask Arrays. Seems reasonable to do it here too.

yes, though with overriding numpy ufuncs we still have to be careful to explicitly skip types like xarray.DataArray

This is what I'm hoping the asduckarray function will do for us in libraries like Dask. 😉
xref: https://github.com/numpy/numpy/issues/13831 (for others interested in learning more)


Add Advanced Installer gitignore

Reasons for making this change:
There is currently no .gitignore file for Advanced Installer, a product that creates installer files for Windows. Advanced Installer projects are appropriate for version control, however it creates binaries and cache files that are not.
Links to documentation supporting these rule changes:
Cache: http://www.advancedinstaller.com/user-guide/project-cache-tab.html
Default output folder: http://www.advancedinstaller.com/user-guide/set-output-build-location.html
If this is a new template:

Link to application or project’s homepage: http://www.advancedinstaller.com/

I added another commit for the prequisites directory that Advanced Installer generates if you choose to include any prerequisites in your installer project. The documentation doesn't appear to specifically call out the the default folder name is Prerequisites, but the general documentation for it is here: http://www.advancedinstaller.com/user-guide/predefined-prerequisites.html

@mikebei - This tempalte is live on gitignore.io - https://www.gitignore.io/api/advancedinstaller

I'm going to close this out because the value of maintaining a template like this in the repository isn't clear to me.
@mikebei if you still feel this should be a template listed in this repository, please read the section about specialized templates and open a new pull request that follows the new pattern.


Green color in video

On some devices, RTSP stream shows green color in video. Any solution for this?

Hi, what do you mean by device? Is there a frame problem on some mobiles or some cameras?

frame problem is in some mobiles i think. i know i dont have much more information regarding this, as video streaming from camera is giving .H264 codec only.

I have seen this problem in situations such as the size not being appropriate when decoding or the codec being incorrect.
First, please send the part of the code that is related to the setup and use of this library so that we can go step by step and solve the problem.
You may need to send me a YUV Byte-Array frame.

it is a yuv planes problem.
On some devices it decodes yuv frame wrong.
I use NV21 decode by OpenCV or you can decode it by other library


Prepare release for DesktopVirtualization

Contributing to the Azure SDK
Please see our CONTRIBUTING.md if you are not familiar with contributing to this repository or have questions.
For specific information about pull request etiquette and best practices, see this section.

API change check
API changes are not detected in this pull request.


DNS setting is not saved

Hi,
Thank for this project. Simple, efficient, easy to run on my nas in a docker compose stack.
 But DNS field is still missing
++ Simulot

Hi, thank you for using Wg Gen Web.
DNS settings are for clients, there is no DNS option on server side. Please read Wireguard documentation for more info.
If you have an issue with generated config fill free to describe in details
thank you

Hi,
I have rebuild the setup using CLI... and now it's working.  So, I'd prefer not touching it.
So I can't elaborate this.
Thanks for your help.


Support content security policy in Django 1.10

Currently Fein CMS uses inline JS for customisation and Django->JS communication this should be replaced with JSON parsing etc to allow for unsafe-inline to be disabled.

Good point.
(django-mptt's DraggableMPTTAdmin (http://django-mptt.github.io/django-mptt/admin.html#mptt-admin-draggablempttadmin) and django-content-editor (https://github.com/matthiask/django-content-editor) already are CSP-compatible. We should probably (re)build on top of those.)

any updates on this one?

No, nobody's actively working on this right now.

Nothing has changed. Closing this because nobody's working on it and it's not probable anyone will (on FeinCMS 1.x)


Update CodeMirror

Closes #10921.
I've run all unit tests without errors and also Smoke Tests, where 3 steps failed (2 (Multi Browser) Live Preview, 1 Inline Editor), but they also fail on master. I'll see whether they are already filed and file them if not.
CodeMirror releases page
Commit log

Fix for the change in CodeMirror commit.
LGTM. Merging.
@MarcelGerber Thanks..


Project name is too short, it should be greater than 4 characters?

Is there a way to avoid this restriction? We have a three-char repo name for organizational units.

You'll need to update the code to work around...

Thanks Is there any particular reason why the name should be greater than 4 chars?

For quick reference, the code that needs to be changed to modify the project name requirement can be found here.
src/ui/api/project.go: const projectNameMinLen = 4
src/ui/static/resources/js/components/project/add-project.directive.js: if (status === 400 && vm0.projectName != '' && vm0.projectName.length < 4)
You will need to rebuild the ui which can be done by running "make compile_ui" from the parent directory. Copy the output of that compilation (make/dev/ui/harbor_ui) into /harbor of the running UI container and restart the container.

@wknet123
Backend already done.
Please update UI code. thanks~

Thanks