[tfm][lpcxpresso55s69_ns] all tfm_integration cases failed.

Describe the bug
all tfm_integration cases failed.
Please also mention any information which could help others to understand
the problem you're facing:

What target platform are you using?
lpcxpresso55s69_ns
What have you tried to diagnose or workaround this issue?
N/A
Is this a regression? If yes, have you been able to "git bisect" it to a
specific commit?
this case is never PASS in v3.5.0
...

To Reproduce
Steps to reproduce the behavior:
cd samples/tfm_integration/psa_protected_storage
west build -b lpcxpresso55s69_ns
west flash --file=build/zephyr/tfm_merged.hex

the log is not as expected
Expected behavior
see the read me files in each tfm_integration
Impact
tfm_integration
Logs and console output
[INF] Starting bootloader
[WRN] This device was provisioned with dummy keys. This device is NOT SECURE
[INF] Image index: 1, Swap type: none
[INF] Starting bootloader
[WRN] This device was provisioned with dummy keys. This device is NOT SECURE
[INF] Image index: 1, Swap type: none
[INF] Image index: 0, Swap type: none
[INF] Bootloader chainload address offset: 0x8000
[INF] Jumping to the first image slot
[WRN] This device was provisioned with dummy keys. This device is NOT SECURE
[Sec Thread] Secure image initializing!
Booting TF-M v1.8.0
[INF][Crypto] Provisioning entropy seed... complete.

Environment (please complete the following information):

OS: (e.g. Linux, )
Toolchain (e.g Zephyr SDK, ...)
Commit SHA or Version used: 915f8a10b62b24b244d2da00793e2b670f677763

@hakehuang , have these tests passed on lpcxpresso55s69_ns before?

Reopened.
Sorry, closed by accident, by pressing wrong GH button.

@hakehuang , have these tests passed on lpcxpresso55s69_ns before?

I just set up testing for this _ns board, the formal testing is just download the zephyr.elf, not the tfm_merged.hex, which is not correct.

TFM requires tfm_merged.hex.

It should be a common TFM issue, could you check it?
BTW: Do we have somewhere regular Zephyr TFM regression tests?

Community NO. but I have set up regular testing on NXP platforms, this is why I report this issue. and lpc55s609 is the only platform that we support

git bisect direct to this commit
c6e3bac4f20a659143a56bda0166a111629d79b1 is the first bad commit
commit c6e3bac4f20a659143a56bda0166a111629d79b1
Author: Emilio Benavente<EMAIL_ADDRESS>Date:   Wed Jan 11 17:40:46 2023 -0600

    soc: arm: lpc55xxx: Updated clock init

    Updated the clock init to reflect the sdk also
    updated the clock frequencies to reflect the
    respective soc clock values, this file originally
    contained unexpected clock values, updated comments
    to reflect changes and got rid of doxygen style
    comments

    Signed-off-by: Emilio Benavente<EMAIL_ADDRESS>
soc/arm/nxp_lpc/lpc55xxx/Kconfig.soc |  10 ++-
soc/arm/nxp_lpc/lpc55xxx/soc.c       | 129 ++++++++++++++++++++++++++---------
2 files changed, 104 insertions(+), 35 deletions(-)

Thank you @hakehuang, saved us time.
Hi @EmilioCBen, could you have a look at your commit c6e3bac4f20a659143a56bda0166a111629d79b1. It was flagged as a bad one that broke the TFM LPC55S69. Can it be modified somehow to make TFM work again?


Feature/serial

A prototype implementation for serial manipulators.
If assumed massless (@danbarla ) the Jacobian calculated by the poe method can be used to compute torques $tau=J^T \mathcal{F}$ with F the wrench at the end-effector (foot). We can "easily" add joint angle dynamics, actually, in a later PR, I think.
The last test shows decomposition of the Panda, effortlessly.

@danbarla I added some math for you to read

@Joobz also approve if you're satisfied I can easily address comments.


DOC: Add resources for Python, terminal use etc.

Proposed documentation enhancement
We have tutorials on how to get started with MNE-Python that cover some more general aspects of Python (e.g. https://mne.tools/stable/auto_tutorials/intro/15_inplace.html).
I often get asked where to start if you do not know any Python at all yet - and as far as I am aware there is no material on the MNE homepage for that.
Maybe we could add a tutorial page with resources we can recommend for getting started with Python, numpy, or also the use of a terminal.

We have this page https://mne.tools/stable/overview/learn_python.html
What I'm hearing is that it's not discoverable.

Oh!
Well, I searched for it and did not find it. Based on the questions I get asked, it seems like it is the same for users - and it seems @larsoner was not aware either ...
Maybe we could move it to tutorials? This is where most people seem to land if they feel like they need an in-depth start.

A few potential ideas

Move from overview to tutorials
Add a new tutorial intro/05_new_to_python.py that just links to the overview doc
Add to existing intro/10_overview.py a .. sidebar:: or so that links to the overview doc

IMO the docs need a medium-sized overhaul, cf #10707.  I think this issue and that one should be addressed together, as I don't think we can find the "right place" for this info in the current (IMO wrong) organization of the (non-tutorial) docs content.


Install lastest v1 not working

Describe the bug
The install of awscli v1 as describe in README.md, do not work and try to install v2
Steps to reproduce
Try to install the latest awscli v2 as describe in [README.md]
$ asdf install awscli latest 1 # 1.19.33
awscli 2.1.31 is already installed

Expected behavior
Installation of the latest version of awscli v1
Additional context
Test only on linux.
Install specific version is ok :
$ asdf install awscli 1.19.33
* Downloading awscli release 1.19.33...
~/.asdf/installs/awscli/1.19.33 ~/.asdf/plugins/awscli
Collecting pip
  [...]
awscli 1.19.33 installation was successful!

Oops ! After looking at the build.yml file I noticed that the syntax should be:
$ asdf install awscli latest:1

Ultimately it's just a documentation typo in README.
Sorry I could have done it before !

I opened #12 with this change!

Closed in #12


field ‘timestamp’ has incomplete type error during build.

I get the following error during installation.
$ npm install

><EMAIL_ADDRESS>install /home/rich/Projects/tmp/v4l2camera
> node-gyp rebuild

make: Entering directory '/home/rich/Projects/tmp/v4l2camera/build'
  CXX(target) Release/obj.target/v4l2camera/v4l2camera.o
  CC(target) Release/obj.target/v4l2camera/capture.o
In file included from ../capture.h:7:0,
                 from ../capture.c:1:
/usr/include/linux/videodev2.h:2127:20: error: field ‘timestamp’ has incomplete type
  struct timespec   timestamp;
                    ^~~~~~~~~
v4l2camera.target.mk:112: recipe for target 'Release/obj.target/v4l2camera/capture.o' failed
make: *** [Release/obj.target/v4l2camera/capture.o] Error 1
make: *** Waiting for unfinished jobs....
In file included from ../node_modules/nan/nan_callbacks.h:83:0,
                 from ../node_modules/nan/nan.h:146,
                 from ../v4l2camera.cc:3:
../node_modules/nan/nan_callbacks_12_inl.h: In instantiation of ‘v8::Local<v8::Function> Nan::FunctionCallbackInfo<T>::Callee() const [with T = v8::Value]’:
../v4l2camera.cc:255:48:   required from here
../node_modules/nan/nan_callbacks_12_inl.h:108:71: warning: ‘v8::Local<v8::Function> v8::FunctionCallbackInfo<T>::Callee() const [with T = v8::Value]’ is deprecated: Use Data() to explicitly pass Callee instead [-Wdeprecated-declarations]
   inline v8::Local<v8::Function> Callee() const { return info_.Callee(); }
                                                                       ^
In file included from /home/rich/.node-gyp/7.5.0/include/node/node.h:42:0,
                 from ../node_modules/nan/nan.h:47,
                 from ../v4l2camera.cc:3:
/home/rich/.node-gyp/7.5.0/include/node/v8.h:8119:17: note: declared here
 Local<Function> FunctionCallbackInfo<T>::Callee() const {
                 ^~~~~~~~~~~~~~~~~~~~~~~

I was able to fix it by adding #include <time.h> to the top of capture.h
#ifndef CAMERA_H
#define CAMERA_H

#include <time.h>
#include <stdbool.h>
#include <stdint.h>
#include <stdlib.h>
#include <linux/videodev2.h>
#ifndef __V4L2_COMMON__
#  define CAMERA_OLD_VIDEODEV2_H
#endif

Sorry about the noise. Wrong project.


2d/3d viewport is broken after resizing editor small

Operating system or device, Godot version, GPU Model and driver (if graphics related):
Ubuntu 16.04
GeForce GTX 670 384.90 nvidia proprietary driver
godot 3.0 56a44ca
Issue description:
2d/3d viewport is broken after resizing editor small
Steps to reproduce:

nothing

I think this pr #14805 fix that too.


New Updates

Added routes for faq and getting started. Also added navigation menus to layout.jade. Created faq.html and gettingstarted.html and copied them from asp.net project.

took a little fiddling, but it's merged


flag to only report issues

could we have a flag to only report packages with issues?

Definitely. I will work on it now. I would say I will have a solution soon, and will endeavour to do so. I have a lot of irons in the fire so will apologize in advance if a fix is delayed.

Anything I can do to help?

Thank you for the offer. I am always open to pull requests, but I expect to have this done by the end of this coming weekend at the latest anyhow so it is all good :)
If I cannot reproduce your other issue I might require additional help. I will be able to get back that one later in the week, so we shall see there. I will keep you updated.

Holy smokes. I went and implemented a feature for this, then realized that it already exists. It was added when we put in support for "winston" (a logging framework). You can change the verbosity of the log. Set the logging level to error in this way:
auditjs -l error

Sorry it took so long to get back to you on this. I noticed that it still prints out a line of dashes when there are no errors. I am fixing that.

Ah, but the error logging appears to have a bug. Fixing that now...

Nope. Testing problem. Everything seems to be running fine. Please let me know if your version does not run properly with the raised logging level.


Adding short time units for english

Can you please accept this PR for short time units in English? Sometimes spaces are restricted and yo may need to shortest time units!
Changes tested and all seem to work fine :)

The strings for 1 minute and 1 month are equal


Merak-Network: switch to use service_config to get constants.

For example use the url in services/merak-network/utils/constant.go

This is already done. Addressed in PR #49 .


asible_fqdn sometimes gets set to localhost.localdomain

Which version of Ansible are you running?
ansible-2.9.3-1.el7.noarch
Is your version of Ansible patched in any way?
no
Are you running with any custom modules, or module_utils loaded?
no
Have you tried the latest master version from Git?
no
Mention your host and target OS and versions
Scientific Linux 7.7
Mention your host and target Python versions
python-2.7.5-86.el7.x86_64

We run ansible-pull periodically locally on our hosts.  On rare instances during the ansible-pull run it appears that ansible_fqdn gets set to "localhost.localdomain".
I put a check at the top of our playbook as follows:
  tasks:
    - fail:
        msg: "Hostname incorrectly set to localhost.localdomain - aborting"

But that did not fire:
Mar 06 07:22:40 iiwi.cora.nwra.com ansible-pull[4635]: localhost.localdomain
Mar 06 07:22:40 iiwi.cora.nwra.com ansible-pull[4635]: PLAY [localhost.localdomain] ***************************************************
Mar 06 07:22:40 iiwi.cora.nwra.com ansible-pull[4635]: skipping: no hosts matched

However, later on tasks that evaluated ansible_fqdn resolved it to "localhost.localdomain":
  - name: "Check if ssl key is presnet"
    stat: path="{{ openssldir }}/private/{{ ansible_fqdn }}.key"
    register: ssl_key

Mar 06 07:23:12 iiwi.cora.nwra.com python(mitogen:root@iiwi.cora.nwra.com:5423)[5461]: ansible-stat Invoked with checksum_algorithm=sha1 get_checksum=True follow=False path=/etc/pki/tls/private/localhost.localdomain.key get_md5=False get_mime=True get_attributes=True

I'm not sure if this is an underlying ansible problem or not.

Since it appears the ansible_fqdn is implemented via socket.getfqdn() this could return erratic results.  I've switched to using ansible_nodename instead.  Hopefully that will resolve it.


Publish helm charts

Coming from #10 and #4
consider https://github.com/helm/chart-releaser-action

I can take this up once OpenSearch Dashboards Chart is merged 😄

@TheAlgo If you need help let me know. I have a good example of GitHub Actions that do this.
https://github.com/DandyDeveloper/charts/blob/master/.github/workflows/publish.yml
There's a lot of different options for doing this nowadays through GitHub actions. Let me know if I can help.

@DandyDeveloper  yes that will be great we can pick it up together after the dashboards chart is merged.  We can decide whether we want to use actions or something else.

The chart version should probably be something less than 1.0.0 for the first release. Maybe 0.1.0?

Existing examples of using action-based tooling for CI and publishing:

https://github.com/evryfs/helm-charts
https://github.com/helm/charts-repo-actions-demo/

I have completed the GitHub workflow using the helm-chart-tester and helm-chart-releaser actions and am happy to contribute to this project is folks are supportive.

helm repo add opensearch https://mprimeaux.github.io/opensearch-devops/
helm search repo open search

I'll re-fork and cleanup but just wanted solicit feedback.

I have completed the GitHub workflow using the helm-chart-tester and helm-chart-releaser actions and am happy to contribute to this project if folks are supportive.

I would be happy love to contribute and support. Thanks

Thanks for your feedback. I'll re-fork, clean the patch up, and submit a PR. All comments and criticisms are always welcome. it's a learning opportunity for me and all.

@mprimeaux Thanks for the work we are also in the process of moving helm to its own repo instead of keeping it in opensearch-devops repo.
Once it has its own repo could you apply the same changes you have in your fork to here?
Thanks.

@peterzhuamazon Definitely. Just let me know when you're ready for the new fork and PR

@peterzhuamazon What is the estimated time for when the new repository will be ready? Again, thanks for your help.

Hi @mprimeaux we need to add the related contributing documents and such as well as labels, etc..
We are planning to release the opensearch-helm standalone repo sometime either next week or the week after that.
Would definitely need community help to migrate it together.
Thanks.

@peterzhuamazon One thing to note is that I had to heavily modify the chart and related values files for lint to pass. I'll ensure all of those changes are encapsulated into the PR.

@peterzhuamazon One thing to note is that I had to heavily modify the chart and related values files for lint to pass. I'll ensure all of those changes are encapsulated into the PR.

@mprimeaux what exactly do you mean by heavy modification of the chart. As far as I remember all the lint checks were passing last time I raised the PR. Curious to know what changes we need for publishing this 😀

@TheAlgo Regarding lint rules, there were broadly four categories of lint errors:

Too many blank lines
Trailing spaces
Comments without a trailing space.
Missing CR/LF at the end of the yaml

You can look at the differences between current charts and relate values files for the detail.
I’m happy to walk you through the differences as needed.

@mprimeaux I get that. It might be possible as I did not use workflow actions to lint but the helm lint command which is used to find lint errors which can cause installation issues.
In that case I agree it might be tedious to fix those. Thanks for taking us up. Much appreciated.

@TheAlgo Thanks for replying and for that detail. The subtle difference is that helm lint checks for helm-related errors (i.e missing chart version, etc) whereas the helm-chart-testing action checks for yaml errors.
To your point, in my opinion, it would be a benefit to add yaml listing to helm.

@peterzhuamazon Just checking in to see if you all are still on track for this week or next for the new repository. In the interest of transparency, we are keen to get this in place for nearly 7 multi-tenant 'as-a-Service' platforms globally we have at Cubic Transportation Systems in AWS.
Your help is greatly appreciated. We stand by ready to help.

Hi @mprimeaux sorry for the late response we are on track to release the repo, probably a bit longer than expected since we are currently voting for the name of it here #49.
There were some initial concerns on the naming so we would like the community to vote on it before proceed.
Thanks.

@peterzhuamazon Thanks for the update.
I've cast my vote 👍🏼 in #49.

@peterzhuamazon Our team also has made defect fixes related to security that we will issue as a PR. Perhaps best in the new repository.

@peterzhuamazon Our team also has made defect fixes related to security that we will issue as a PR. Perhaps best in the new repository.

Thanks @mprimeaux we plan to start the migration next week, since the vote will end on Friday.
We will make the repo public next week as well once the name is settled.
You will then be able to contribute.
Thanks.


test: refactor testing tools

Check the vacancy of ports before assigning them to the test functions.
Refactor some test helper functions to be more unified and reusable.

Rebased on the most recent commit.

rebased


Getting error while playing songs

Player got exception
This error in LavaLink console

This error in bot console

Don't use the built-in YouTube source manager.


Batch 010

Issue Addressed
Which issue # does this PR address?
Proposed Changes
Please list or describe the changes introduced by this PR.
Additional Info
Please provide any additional information. For example, future considerations
or information useful for reviewers.

@mergify queue


Language_Translator_using_Python_and_GoogleAPI

I want to work on this please assign me, I'm a participant of LGM-SOC'21

Please assign this issue to me

@Niketkumardheeryan Please assign me this. I want to work on this issue sir.

@Niketkumardheeryan I want to work on this issue. Please assign this issue to me.


test-framework-doctest v0.1cannot be compiled with the latest test-framework

Since ropt_plain_output in test-framework has been obsoleted, test-framework-doctest v0.1cannot be compiled with the latest test-framework. Fix is trivial. Please catch up the latest test-framework.

@sakari I made that change in test-framework, and I'm just preparing a patch for test-framework-doctest.

Fixed in sol@0338c229a5c223c3140c2f5291e21c34d3d9c9e2

duplicate of sakari/test-framework-doctest#5

Thanks. I hope that new version will be released soon.


Minimap Highlight Selected don´t work

Minimap Highlight Selected doesn´t work in Atom for windows.

Hmm, I think this issue is no longer relevant, is it?


Fix OSGi META INF, fixes #152

@Mailaender this seems to work.

MANIFEST.MF is still just
Manifest-Version: 1.0

for me. :(

Oh, you're right. The publish.gradle file is only applied when the Sonatype credentials are available:
if (project.hasProperty('SONATYPE_USERNAME') && project.hasProperty('SONATYPE_PASSWORD')) {

I guess that means it doesn't work for local deployments. On the other hand, there is probably no reason to not move the lines I changed to the top of the file, outside the conditional block.


chore: fix psr-4 in composer.json

:tada: This PR is included in version 1.0.0-beta.2 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Spanish locale file added

My small support to this wonderful project. Thanks for this great tool!!!

Hey, gracias !
Could I ask you to check against https://github.com/bmichotte/HSTracker/blob/develop/config/locales/en.yml (local for current beta) and complete yours ?

Sure.

Added by 2da4acba02ab131a3ff1e866824bd0e2f53866f1
Will be available in the next release !
Thanks @asiertejada


remove "Compounds"? what is cim:Status?

"Compounds" are cims:dataTypes that are neither Primitive, nor have unit/multiplier:
PREFIX rdf: <http://www.w3.org/1999/02/22-rdf-syntax-ns#>
PREFIX cims: <http://iec.ch/TC57/1999/rdf-schema-extensions-19990926#>
select * where {
  ?prop a rdf:Property; cims:dataType ?compound.
  ?compound cims:stereotype "Compound"
}

prop
compound

dm: DifferenceModel.forwardDifferences
rdf: Statements

dm: DifferenceModel.preconditions
rdf: Statements

dm: DifferenceModel.reverseDifferences
rdf: Statements

dm: DifferenceModel.forwardDifferences
rdf: Statement

dm: DifferenceModel.preconditions
rdf: Statement

dm: DifferenceModel.reverseDifferences
rdf: Statement

cim: StreetAddress.status
cim: Status

cim: Location.mainAddress
cim: StreetAddress

cim: StreetAddress.streetDetail
cim: StreetDetail

cim: StreetAddress.townDetail
cim: TownDetail

cim:Status is the only compound that has no fields. It's not an Enumeration either:
cim:Status cims:stereotype "Compound".
cim:StreetAddress.status cims:dataType cim:Status.

So it's undecided what it is ;-)

Its referencing class cim:StreetAddress is defined in 61970-600-2_GeographicalLocation-AP-Voc-RDFS2020_v3-0-0.
It is not used, which makes this problem about its status almost a non-issue.
rdf:Statement vs rdf:Statements should be replaced with named graph
StreetAddress, StreetDetail, TownDetail are objects with some props: but are not used either, AFAIK

Currently links to Compounds are mapped ObjectProperty.
I think cim:Status needs to be defined, or maybe all "Compounds" should be removed?

We may need to discuss but here some feedback

half of this is in the difference exchange trying to mimic what is in the 61970-552 document. I am not sure we are using the statement, etc. We can definitely improve there
the rest is from GL profile. I see the status defined in the 61970-600-2_GeographicalLocation-AP-Voc-RDFS2020_v3-0-0


Failed to execute goal com.github.s4u.plugins:pgpverify-maven-plugin

Hi,
I have git pulled cas-services-management-overlay.
When building cas-services-management-overlay, build is failing with this error :
...
[INFO] --- pgpverify-maven-plugin:1.1.0:check (default) @ cas-overlay ---
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 02:08 min (Wall Clock)
[INFO] Finished at: 2017-02-24T13:05:33+01:00
[INFO] Final Memory: 13M/106M
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal com.github.s4u.plugins:pgpverify-maven-plugin:1.1.0:check (default) on project cas-overlay: Connexion terminée par expiration du délai d'attente (Connection timed out) -> [Help 1]
...

My config : Debian stretch, Openjdk-8-jre
JAVA_HOME : /usr/lib/jvm/java-8-openjdk-amd64/jre/
Thanks in advance for your help.

Fix your connection please so it doesn't time out.

I have a similar issue. Get a no route to host error. Is the build doing something on a non-standard port (eg not 80 or 443) somewhere?


feat(diagnoses): adds ability to view a diagnosis

Fixes #2129.
Changes proposed in this pull request:

Added a diagnosis table component, where each row/diagnosis has a "view" button that leads to the corresponding form
Added a new react-query handler for the diagnosis routing
Changed Diagnoses and ViewPatient tests
Added new tests for the components and routing
Added asynchronous data loading for diagnoses (similar to care plans)

Newly added dependencies with Bundlephobia links:

No dependencies added.

One bug that I noticed: the diagnosis tab does not highlight  when viewing a diagnosis.

@jackcmeyer All of the changes that you requested were addressed. One issue that I noticed with similar tests for react-query hooks like useAllergy and useCarePlan is that they don't correctly test their respective error handlers, but they pass anyway. Maybe this is related to #2287?

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

This PR has been updated to resolve merge conflicts with RTL @jackcmeyer @blestab

@anthonyaperez sorry about delay, but the project is unfortunately back in a "frozen state". can you align your PR with the master?

@tehKapa Done!


Detailed documentation on initialization, configuration, and early termination

The bot seems simple enough to use, but I am still unsure how to set OOO time. For example, if I comment with "/ooo 9/15 until 10/2", does the range of days include 10/2, or does it only go through 10/1? Can I substitute "until" with "through" or "to"? What other keywords are supported? Will an empty call to "/ooo" cancel the autoresponder?

sorry...Because my e mail has been stolen, I have not used e mail for a while...


dosya

Why:
Closes [issue link]

What's being changed:

Check off the following:

[ ] I have reviewed my changes in staging (look for the latest deployment event in your pull request's timeline, then click View deployment).
[ ] For content changes, I have completed the self-review checklist.

Writer impact (This section is for GitHub staff members only):

[ ] This pull request impacts the contribution experience

[ ] I have added the 'writer impact' label
[ ] I have added a description and/or a video demo of the changes below (e.g. a "before and after video")

BEN KAPAMADIM SİSTEM KAPATTI

çekme isteğnide olanların hepsi virüs sayın ramya
Ramya Parimi @.***>, 4 Eki 2021 Pzt, 14:38 tarihinde
şunu yazdı:

Closed #10489 https://github.com/github/docs/pull/10489.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/github/docs/pull/10489#event-5403314021, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AV2WBW34AKOKSVGEIRIDP53UFGG3RANCNFSM5FHIGG6Q
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

All those who have a pull request are viruses, Mr. Ramya
Erçetin Güler @.***>, 4 Eki 2021 Pzt, 14:53
tarihinde şunu yazdı:

çekme isteğnide olanların hepsi virüs sayın ramya
Ramya Parimi @.***>, 4 Eki 2021 Pzt, 14:38 tarihinde
şunu yazdı:

Closed #10489 https://github.com/github/docs/pull/10489.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/github/docs/pull/10489#event-5403314021, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AV2WBW34AKOKSVGEIRIDP53UFGG3RANCNFSM5FHIGG6Q
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.


fix semver comparison

Close #10

https://github.com/mix1009/version_check/issues/10#issuecomment-1330076728


Links with anchors aren't parsed properly

Some reference links aren't parsed correctly into A tags even though they're defined correctly at the bottom of the page. I think this is the case for any reference links defined after one containing an anchor.
As an example, In logging-destination.md fluentd-match is linked properly (in the first paragraph) but any references defined after it (fluentd-plugin, iam-credentials, etc) aren't parsed and render as raw text in the page.
https://github.com/coreos/tectonic-docs/blame/1.7.5-tectonic.1/Documentation/admin/logging-destination.md#L241

Captured in https://jira.prod.coreos.systems/browse/DOCS-176


export const NOTCOIN_EXCHANGERS = [

https://github.com/okx/js-wallet-sdk/blob/594fa2854b62f2958a2ea8acd27750de6d267161/packages/coin-ton/src/api/constant.ts#L5

export const NOTCOIN_EXCHANGERS = [how to accepted gives away ton space


[APK Management Server to Agent Client Communication] Extract Data for Enforcer XDS

Description:
This is to extract data for Enforcer XDS.
Need to debug and check how enforcer gets consumer keys currently (it's not via xDS currently).
Update application.proto to send consumer keys and do the related changes in enforcer side.

Changes are in this PR for now https://github.com/wso2/product-microgateway/pull/3128 and will be moved to apk repo

https://github.com/wso2/apk/pull/116 merged


[Feature]: TeamCity - Comment on Pull Request when build succeeds

What feature?
With Jenkins, it used to commented preview of what it would look like with the pull request.
It was lost when CI/CD changed to TeamCity.

Let TeamCity comment on the Pull Request
https://{short-commit-hash}.dev.mochatto.com
Remove the comment when commit is updated
Post new comment with same content as 1.

Change content of https://github.com/Amijakan/mochatto/blob/main/.teamcity/settings.kts
https://teamcity.mochatto.com/app/dsl-documentation/-team-city -kotlin -d-s-l/jetbrains.buildServer.configs.kotlin.buildFeatures/index.html
Approaches

Use Github API to comment on the PR.

Find a way to inject environment variable
Use curl

Find something that teamcity offers.

TeamCity related config / code should be moved to different repo


Payment email apparently can take in very long emails

When donating i discovered that
email length is not specified and can enter email say like 50 to 75 character long.
eg<EMAIL_ADDRESS>which most of the donors won't be having this long email.

When donating i discovered that
email length is not specified and can enter email say like 50 to 75 character long.
eg<EMAIL_ADDRESS>which most of the donors won't be having this long email.

I think this is not an issue. Let it be as it is.


Refactoring - retrieve user ID

Description
Refactoring - retrieve user ID
(it will be used in several parts of code)
Type of change

[x] Refactor
[ ] New feature
[ ] Bug fix
[ ] CVE fix
[ ] Optimization
[ ] Documentation Update
[ ] Configuration Update
[ ] Bump-up dependent library

/lgtm

/approve


Bugfix/expand dendrite json

This updates several things:

synapse.dict() -> json.loads(synapse.json())
pydantic to 2.5.2 (latest version) with a massive overhaul
fastapi to 0.105.0 (latest version)
updates related synapse code to leverage these upgrades

This effectively increases the types that can be serialized over the bittensor network natively, e.g. datetime

Looks good, mind expanding a bit about the differences between .dict() vs json.loads? What bug does this fix?

Yes, will expand in the main comment.


Add crash reporting

This helped me to debug why Electron 0.37.4 was crashing. Turns out that 0.37.4 has a broken Buffer implementation and it seem is (accidentally) using a pre-release version of Node 6. Whoops!
In any case, crash reporting is useful. Going to leave this in.
Server-side components to the reporting are in this PR: https://github.com/feross/webtorrent-www/pull/52

Wow electron really has everything
https://github.com/electron/electron/blob/master/docs/api/crash-reporter.md


Fix pyenv version/virtualenv display

Fixes https://github.com/denysdovhan/spaceship-zsh-theme/issues/103
Notes: I am not sure if this is okay and works perfectly for everything
This is how it looks now:
~ via ⬢  v6.10.0 on 🐳  v17.04.0-ce via 🐍  3.6.0b3 3.5.2 system

However, it shouldn't be shown when version is system only. Does it work that way?

Did you check this?

Nope.

Ah it shows

:-(

I guess its okay anyways

Showing system all the time is not Spaceship-way. Other sections don't do that.

This could be fixed, but I am not sure how this is wrong.
When someone installs pyenv, it will show system, and when someone does pyenv local system it will show system

That's how pyenv works


Sync SriovNetworkNodeState CRD into helm chart

SriovNetworkNodeState is outdated. IsRdma field was introduced
in the PR #207.
This patch syncs CRDs between config/crd/bases and helm chart.

@SchSeba @pliurh PTAL

/lgtm
in general maybe we can have a make command that will copy all the files into the right folders :)


feat: enable direct access to signup/signin form from respective buttons and merged two types of authetication in one page

🚧 Fixes Issue
closes #1038
Changes made 👷🏻
Removed the modal which was being opened after clicking Signup/Signin button, Now it directly opens a Form.
Added dropdown menu in form which contains two options "Club" and "User" and will show respective fields according to the choice made.
Added a validation for password and confirm password meaning those two should be same otherwise it will show error Toast.
Screenshots  📸

Note to Reviewers
Added two new files named "AuthLogin.jsx" and "AuthRegister.jsx" inside /src/pages/Auth.
Removed folders named club and user from /src/pages/Auth since it wasn't required anymore.

I found one bug in my code so I'm closing this Pull Request and Opening a new one sorry for this inconvenience.

I found one bug in my code so I'm closing this Pull Request and Opening a new one sorry for this inconvenience.

You can simply push the changes here - it would be auto-deployed.


fix(element-plus): handling components without styles

Description
Element Plus can contain components without css files. There seems to be only one such component right now, ElAutoResizer. Now it comes to an error of loading un-existed styles file.
This PR adds a list of components without styles that can be updated later, and toggles the importStyle flag to false for them.
Linked Issues
https://github.com/element-plus/element-plus/issues/7933

Maybe can add a noStylesComponent option for users to configure themselves.

You are so efficient, it's amazing 👍


Ethernet_Large + Lib Patches give always IP:<IP_ADDRESS> || can not server.streamFile () from SPIFFS

Hello,
I'm trying to set up a web server with a W5500 Shield (and a m5Stack).
Since I use Bootstrap and the files are> 40 kB (up to 200 kB) I used the Ethernet_Large Library.
Without your lib patches, the html part loads, but the ESP crashes with the large css + js files.
When I import your lib patches, I only get IP: <IP_ADDRESS> addresses, regardless of whether I choose static or dynamic. (If I use the original Ethernet_large sources again, I get the correct IP address)
Unfortunately loading SPIFFS doesn't work with your library:
  File file = SPIFFS.open ("/bootstrap.min.css.gz", "r");
  size_t sent = server.streamFile (file, "text/css");

so I added another library:
Effortless_SPIFFS.h https://github.com/thebigpotatoe/Effortless-SPIFFS
This loads the files stored in SPIFFS into a string at lightning speed, which I then transfer to your lib:
Unfortunately the Effortless_SPIFFS doesn't load and extract .gz files (which will server.streamFile() do and server.send() not,  I presume ), so I have to use the uncompressed ones ...
bool handleFileRead (String path) {
  String sHTML;
  char cPath [20];
  if (path.endsWith ("/")) path + = "index.html";
  if (SPIFFS.exists (path)) {
    path.toCharArray (cPath, 20);
    String contentType = getContentType (path);
    fileSystem.openFromFile (cPath, sHTML); // <- Effortless_SPIFFS.h
    server.send(200, contentType, sHTML);
    return true;
  }
  return false;
}

Is it possible, to load Files large than >40 kb from SPIFFS and send it to server() - directly with Ethernet_Large, and server.streamFile() or with server.send() ?
Thank you verry much,,
Armin

Congrats on your project's quick advancement.
There are many known issues with ESP32 and W5x00 libraries, relating to SPIFFS as you can see in Spiffs not work.
There is also the possible problems caused by the Ethernetx libraries on which this EthernetWebServer library is relying. Also keep in mind that these libraries and MCUs, even ESP32, have limited capability and can't be expected to work as fast and good as the PCs.
I'm sure that the patched EthernetLarge library is working OK. The IP: <IP_ADDRESS> issue is caused by something in your code. Test using one of the examples to know for sure and compare. If you can provide some code the duplicate this IP issue, I can help you there.
I just can suggest you test step-by-step

Change the Ethernet library to Ethernet2, Ethernet3
Use the Ethernetx libraries directly to isolate where the problem is.
Using native ESP32 WiFi for your application
Try new ESP32 LittleFS instead of slower and to-be-deprecated SPIFFS
Using SD card instead of SPIFFS/LittleFS
Conflict on SPI bus

There is no way I can help you solve this problem without much info or code to duplicate the issue.
I'll close the issue now as it seems to me that the problem is caused be other libraries / configuration / core.
Good Luck,


Made Coordinate a slice

The GeoJSON "coordinate" is just an array whose definition depends on the CRS (coordinate reference system). The Coordinate type that is used to express coordinates only supports two elements. I changed it to be a slice.
I chiefly just wanted to have altitudes (GeoJSON defaults to the WGS84 datum as the CRS, which supports altitudes).

Thank you.


Add autostep for level objects(stairs and low edges)

If you load the level map with autostep, it seems to not work at all.
Here's the example I am working on (still WIP too), it has some new models and different dialog interactions, but it's not the case. I have changed the scene level to a more complex one, with many stairs and edges. Here's a wasm example(my example is basing on foxtrot 0.3): https://661ba63c824e4d4afe1f877d--prismatic-shortbread-d520b8.netlify.app/
It would be nice to add a feature for which the character won't stop on a little edge or stairs.
That's the model I used:
https://www.turbosquid.com/3d-models/collage-3d-model-2088622
ps. I have also thought, about water physics, but that may be for another thread.

Without having looked too much into it, this seems to be an issue relating to Tnua, the underlying character controller.

I was using version 0.3 in which rapier was used and tried to use that: https://rapier.rs/docs/user_guides/bevy_plugin/character_controller/#stairs-and-small-obstacles
but it didn't work. I thought that may not work because the level model, which I used, was very "monolithic", so it has about 5-6 huge colliders. I tried with different values, but maybe I can check my theory on the "tennis court" collider which is very small.

Oooh I see! In later versions, I switched away from rapier to XPBD and am now using Tnua instead of a custom character controller. As such, I cannot help you that much. I advise you switch to Tnua as well, since it can also support rapier and supports the mentioned features out of the box.

I'll close this as already done due to Tnua integration, but feel free to reach out to me if you still have questions :)


Microsd only working after resuming from hibernation on Asus rog ally

Hello
I'm trying the last version on an Asus rog ally and I can't acces the microsd unti I resume from hibernation. The sd isn't even detected until I press the power off button and then bring It back online
The microsd port was working on Windows without any issues
Best regard

I haven't seen any problems with my microsd and how are you hibernating your device? Hibernation is not supported ATM in chimeraos, or are you talking about sleep?


Static code analysis

Are you interested in making Boon pass static code analysis tools like PMD, FindBugs, Checkstyle, etc?
I'm happy to develop and submit pull requests if so.

Example of a problem correctly identified by FindBugs:
public static boolean equalsOrDie(String message, Object expected, Object got) {

    if (expected == null && got != null) die(message, "Expected was", expected, "but we got", got);
    // will fail with NullPointerException if both expected and got are null.
    if (!expected.equals(got)) die(message, "Expected was", expected, "but we got", got);
    return true;
}

My suggested replacement:
public static boolean equalsOrDie(String message, Object expected, Object got) {
    if (expected == null) {
        return got == null || die(message, "Expected was", expected, "but we got", got);
    }

    return expected.equals(got) || die(message, "Expected was", expected, "but we got", got);
}

please submit a pull request. :)

Done at https://github.com/boonproject/boon/pull/326
There are various other issues reported by FindBugs, but some would need discussion of what is the expected behavior.
PMD might be helpful too, but issues it reports are less likely to be actual bugs, and more likely to be cleanup, eg removing unused imports. Sometimes it spots genuine issues worth fixing, though.
Based on what I've seen in the code, you probably don't want Checkstyle; or would you be happy to have your code formatted, just haven't taken time for it?


Filtering criteria order sensitive

In HC 11 I've noticed a filtering issue where the criteria in the 'where' seem to be order sensitive.
Example
This works as expected:

But this doesn't not:

I get error "Property 'Int32 AssessmentTypeId' is not defined for type 'Shards.Model.Item' (Parameter 'property')", which seems to indicate HC is trying to find 'assessmentTypeId' in 'item' (the now prior criteria).

This issue might have something to do with list filtering ('some').
If I replace the item criteria with a simpler, non-list filter criteria, then everything works as expected.


Feature powf, exp, log10, log2 log, ln, trunc, fract, copysign support + unit tests for each

There are about a million different implementations of each, but for exp and ln, you basically end up with a splitting based upon 2^n splitting and Horner schemes, or generated polynomials as the fastest methods.  You can tweak the iterations but overall there's really not much more you can do to make things faster, you generally end up with 4 -> 5 multiply adds on top of some bit-twiddling and a few non-iterative additions.
Powf is pretty much always going to be based upon x^logx(b) scheme, and because of this rely heavily on both your exp/expx and ln/logx being reasonably accurate, as powf will inherit both functions error, if you skimp too much on accuracy you get extremely poor results.  That said, relative accuracy was pretty high in all of these tests, with powf being 0.002 relative (so not absolute like some of the tests present) in every instance tested (though not exhaustive).
There are also some checks made for inputs of 1.0 and 0.0 in some functions, to provide exact output in those scenarios, I wasn't sure if they were necessary, but error is horrendous at the edges of the polynomial approximations, where 1.0 and 0.0 almost always were, resulting in some pretty bad error (ie I remember something like ln(1.0) == 0.0006... at some point in testing).
The fract and trunc functions should work in all normal scenarios, but its possible that you would want versions which don't care about the sign of what is being extracted.  In such cases it might make more sense to have separate functions, but I wasn't sure if that was in the scope of "micromath" in general.
This is my first time writing anything substantial in rust, and I'm not sure I've followed proper idioms, and I'm willing to make massive modifications if need be.

Nice! Will review this when I have some time.

Overall it looks good, in the spirit of this library, and I don't see anything I'd consider particularly non-idiomatic.
I guess as a general note you have a lot of comments asking questions which seem to fall into a couple categories: things I'd consider TODOs, and rationales for the current implementation but phrased in the form of a question.
I think it'd be good to either label TODOs as TODOs or change the other questions to affirmations. Will try to leave some advice on those line by line.

Awesome, thanks!

Released in v0.4.0 :shipit:


Descriptive Notation to Algebraic Notation conversion failure

Trying to convert to convert the example presented on this Wikipedia article Example fails.
At this point:

... BxNP

It also fails in others cases like PxBP.

Thank you for reviewing this case! I will probably have time to look into this no sooner than this weekend; sorry.

@insanetesterftw got the wikipedia example you mentioned working except for one detail: it can't deal with checks, doublechecks and mates being separated from the moves (by spaces).
This should now work
1. P-K4 P-K4
2. N-KB3 N-QB3
3. B-B4 B-B4
4. P-QN4 BxNP
5. P-B3 B-R4
6. P-Q4 PxP
7. O-O P-Q6
8. Q-N3 Q-B3
9. P-K5 Q-N3
10. R-K1 KN-K2
11. B-R3 P-N4
12. QxP R-QN1
13. Q-R4 B-N3
14. QN-Q2 B-N2?
15. N-K4 Q-B4?
16. BxQP Q-R4
17. N-B6ch! PxN
18. PxP R-N1
19. QR-Q1! QxN
20. RxNch NxR
21. QxPch! KxQ
22. B-B5dblch K-K1
23. B-Q7ch K-B1
24. BxNmate

http://marianogappa.github.io/ostinato-examples/parser
Let me know what you find.


[FLINK-12911][table-api] Port AppendStreamTableSink, UpsertStreamTableSink, RetractStreamTableSink to flink-api-java-bridge

What is the purpose of the change
This is a simple issue to port these interface from scala to java and move to table-api-java-bridge module.
Brief change log
Port AppendStreamTableSink, UpsertStreamTableSink, RetractStreamTableSink to scala and move to table-api-java-bridge module.
Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): (yes / no)
The public API, i.e., is any changed class annotated with @Public(Evolving): (yes / no)
The serializers: (yes / no / don't know)
The runtime per-record code paths (performance sensitive): (yes / no / don't know)
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes / no / don't know)
The S3 file system connector: (yes / no / don't know)

Documentation

Does this pull request introduce a new feature? (yes / no)
If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

Hi @dawidwys , could have a quick look at this PR.
It's a simple code port.

Thanks for the tips @dawidwys . I have fixed them.
Will merge this when travis pass.


[Bug]:  placement of text is not align

Description
text is not visible
Expected Behavior
the text color and placement should change to improve it visibility
Show us the trouble with screenshots

Which browsers are affected?
No response
Which OS are affected?
No response
Enter the version of your web browser
chrome
Device?
Desktop
Record

[X] I agree to follow this project's Code of Conduct
[X] I'm a GSSoC'23 contributor
[X] I want to work on this issue

@Vaishnavi-Patil2211 please assign me this issue

@Vaishnavi-Patil2211 please assign me this task

Hi @vaibhavi-d18 please assign me this task


Remove @Deprecated methods from Translate client

@garrettjonesgoogle this seems to have been resolved by #1678 ... or am I missing something?

I think I was looking at an old branch when I found the @Deprecated tags. It looks like there is nothing else to do in master.


feat(readme): nuxt3 kysely example

@DawidWetzler Thanks for your contribution.  i have few questions or remarks.

is this working only for Web or also for Native App

it is a bit confusing to have call this capacitor-sqlite-kyselyas it is not a capacitor plugin so this is confusing. it is more a driver or wrapper. Would be better to rename it kysely-capacitor-sqlite-driver

this.#sqlite.saveToStore(this.#config.name) is only valid for Web platform. You may add @capacitor/core as dependency,import { Capacitor } from '@capacitor/core'; and get the platform const platform = Capacitor.getPlatform();doing so you can test for the platform and not throw an error in native

for the beginTransaction, commitTransaction, rollbackTransaction method you must use the new db.beginTransaction, ... of the @capacitor-community-sqlite plugin

Apart from this, i am sure that your contribution will be greatly appreciated by the community, thanks for this

Hello there, thanks for your feedback.

It should work for all the platforms this plugin supports.

I've though about calling it kysely-capacitor-sqlite but also had questions like following in my head

Q: How would I look after a extension of capacitor sqlite?
A: capacitor sqlite querybuilder
A: capacitor sqlite with kysely
A: kysely capacitor sqlite
R: capacitor-sqlite-kysely
Q: What's actually using what?
A: Kysely uses capacitor sqlite to make it work within capacitor projects.
R: kysely-capacitor-sqlite
Q: This is extension of whose functionalities?
A: Capacitor Sqlite
R: capacitor-sqlite-kysely
Q: Can I still use capacitor-sqlite outside kysely?
A: Definitely. Also shown in the example.
R: capacitor-sqlite-kysely
and for the reasons I decided to go with capacitor-sqlite-kysely but if you think this might be confusing I'm open to republish this as kysely-capacitor-sqlite or kysely-driver-capacitor-sqlite as I haven't done a pull request on the kysely repository itself for now.

That's true. I could've done a more proper handling of this than just try catching it. I'll note this down and look into this in the next few days.

Thanks for catching this!

@DawidWetzler may be you should open a PR to kysely as it is a driver for kysely this is how it was made for typeOrm. Try to clarify with them if you can do it that way.

Hey @jepiqueau, the issues you've found out are now fixed and the docs also now include the driver.

@DawidWetzler  can you share this as the link given earlier does not show it or has not been updated

I'm not sure about which link you're talking about but

https://github.com/kysely-org/kysely/commit/56facee8b070f560f13f0e1fe26ad50e3edb866b
https://kysely.dev/docs/dialects

and the rest

https://github.com/DawidWetzler/nuxt3-capacitor-sqlite-kysely-example
https://github.com/DawidWetzler/capacitor-sqlite-kysely

Could you please provide me the source for this? If there's this written somewhere I'd like to include this in the current repo as I have to admit I will be really unhappy with this because of:

signature within code won't match anymore
archiving repository current repository
creating another repository reflecting this name change
changing package within example
providing another pull request to kysely just to change the name


how to make word_index_dict.txt

I have a little immature question, how to make word_index_dict.txt about Mandarin?

My understanding is to write all the appearing phonemes into the txt file and correspond to an id, is my understanding correct?

I guess the first five tokens should be "", "", "", "" and blank. e.g. https://github.com/yl4579/AuxiliaryASR/blob/5cb3ee46c4839d96d50c8ad9b3f378b1d7f06df7/models.py#L106

Thanks, got it


terraform reports region value update which doesn't get resolved on apply.

Terraform reports update to model that doesn't get resolved after applying.  It always wants to remove the region key, although it was not included in the tf file.
Terraform used the selected providers to generate the following execution plan. Resource actions are indicated with the following symbols:
  ~ update in-place

Terraform will perform the following actions:

  # juju_model.terraform will be updated in-place
  ~ resource "juju_model" "terraform" {
        id         = "b86dbd3b-07ec-4283-8019-dc99903142ac"
        name       = "terraform"
        # (3 unchanged attributes hidden)

      ~ cloud {
            name   = "localhost"
          - region = "localhost" -> null
        }
    }

Plan: 0 to add, 1 to change, 0 to destroy.

main.tf to reproduce, on an lxd localhost cloud:
terraform {
  required_providers {
    juju = {
      version = "~> 0.7.0"
      source  = "juju/juju"
    }
  }
}

provider "juju" {}

resource "juju_model" "terraform" {
  name = "terraform"

  cloud {
    name   = "localhost"
  }
}

If I add region = "localhost" to the cloud block above, the issue is resolved and terraform reports no changes.  But this shouldn't be required, because the region key is optional.

@swalladge this looks like a bug to investigate.
Could you please use the bug report template like in #184 ?


Normal Distribution

I am implementing many Distributions. #4678
#4678 PR is too big to review.
Therefore I am dividing this PR into some PRs.
First, I opened this PR which contain normal distribution and utils related to normal distribution.

Thank you for the comments.
I fixed the codes based on your comments.

Thank you. I will check the updates.

I fixed again.

I fixed.

Jenkins, test this please.

fixed.

Jenkins, test this please.

Could you update setup.py to install chainer.distributions? It looks the CI fails for it.

Done.

Thank you.
Jenkins, test this please.

I fixed.

Thanks. Jenkins, test this please again.


Deploy cargo-fuzz automatically

To speed up CI jobs that use cargo-fuzz and avoid running the cargo install cargo-fuzz command, I think it would be helpful to automatically deploy cargo-fuzz on Linux, MacOS and Windows through GithHub Actions. The action is triggered when a new tag is added and pushed.
I hope this is appreciated, thanks in advance for your review!

I'm okay with this either way; I personally don't find actions-rs to be a major CI dep since everyone uses it anyway

Thanks!
Can we just do rustup toolchain install stable --profile minimal --no-self-update instead of depending on actions-rs/toolchain?

No problem at all, I removed actions-rs/toolchain, let's see if it works

I'm okay with this either way; I personally don't find actions-rs to be a major CI dep since everyone uses it anyway

It's just a one line command, so taking on a dep feels a little silly to me.


Code Smell

Demo test Page:

Duplicated code: It would be better to add these repeated code to the beforeEach scope.

Long Method: arr variable is too long, should use a for loop to generate the characters.

Mysterious Name: index, arr and returnStr do not have a clear meaning.

Duplicated code is indeed appear, it should be revised. great idea to  add these repeated code to the outer scope.
Also, Long Method is not only appear test part , Also In the milestone 3,
Original -> we just "convert to b64input[1]"  part  to download function,
After revise -> we create new function called updateTextXML()  and recall it in download function.
//pass all sentences to b64Inputs[1]
  updateTextXML(): void {
    // @ts-ignore
    const readalongRoot: any = document.querySelector("read-along").shadowRoot;
    if (readalongRoot == null) {
      return;
    }
    const translation = readalongRoot.querySelectorAll(".translation");
    var textXML = this.b64Service.b64_to_utf8(
      this.b64Inputs[1].substring(this.b64Inputs[1].indexOf(",") + 1)
    );

    const parser = new DOMParser();
    const doc = parser.parseFromString(textXML, "application/xml");
    // if translation class exist, delete it
    if (doc.querySelector(".translation") != null) {
      doc.querySelectorAll(".translation").forEach((node) => {
        node.remove();
      });
    }
    const ss = doc.querySelectorAll("s");
    let count = 0;
    ss.forEach((tag_s) => {
      tag_s.insertAdjacentHTML(
        "afterend",
        `<span class="translation" contenteditable="true">${translation[count].innerHTML}</span>`
      );
      count++;
    });

    const serializer = new XMLSerializer();
    const xmlStr = serializer.serializeToString(doc);
    this.b64Inputs[1] =
      this.b64Inputs[1].slice(0, this.b64Inputs[1].indexOf(",") + 1) +
      this.b64Service.utf8_to_b64(xmlStr);
  }

  download() {
    // recall updatetextXML()
    this.updateTextXML();

duplicate code
in the test of milestone1, there are some duplicate code.
for this one, it's better to write a new function to generate the string for test.

Mysterious Name
For our project's repo, for example we have functions named 'picked', the name of the function can be confusing to other
people.

Refactor: So we would better give these functions a more detailed name to explain or write a documentation above each
function to explain what these functions are doing.

Long method
For our repo, the download function is too long. For this function, we include changing the innerhtml, converting the base64 input and also the append node to the page element. In my opinion, it's usually a very good idea to split large functions into smaller ones. It's not a problem if they are well designed and it's easy to understand what is going on. But the larger the function, the harder it becomes to do so. Keeping functions simple will allow you to track problems easier later on. As we go through the implementation of the function, we may also add more lines of additional innerhtml for the sentence elements which would make the download function longer.

refactor: separate the download function or write a function implement the add innerhtml, then call that function inside the download function
benefits:same to large class, if we separate into smaller codebase, it would be clean and sustainable in the future.

Data clump
It happens in our repo that a group of variables(base64inputs) are passed around together in various parts of the program. Because we would always need to convert the string/ images into base 64 input format and our download function also depends on this.
refactor: it would be more appropriate for us to formally group the different variables together into a single object, and pass around only the new object instead
benefits: we don’t need to write the process of converting the base64 input again and again. Save time, increase efficiency.

Variable mutations

mutations that vary widely enough that refactoring the code becomes increasingly difficult, due to the actual value's status as unpredictable and hard to reason about.For some of our code, our variable’s type is any which will make it harder to debug and confused of the status of the variable.

Refactor: change the type of variable, let it more specific
Benefits: easy for debugging, easy to track the process

large class
For our own repo, there is a class named 'DemoComponent' which contains lots of functions.
refactor: So we may pay attention to this class and see whether we could separate it into several different classes. Each class can contain less function like image class or input class.
benefits: more flexible and maintainable for future modifications.Easier to understand the logic of each function.

1.Mysterious Name: functions, modules, variables or classes that are named in a way that does not communicate what they do or how to use them
In our repo, I think there is some function without friendly instructions.Although part of them is easy to understand without comments, parts of them may be hard to know how to handle with parameters. As a result , it is not an easy thing to understand the repo for new learner.I think it is the most important thing we have to follow up involving the code smell.

Before refactoring this function is called download, from which we can’t tell what the function can really do. After refactoring, we know the function is called for downloading the web file with recording.
2.Duplicated code: identical or very similar code that exists in more than one location.
In our repo, many functions have similar need to deal with the encoding content. Hence, it is easy to write the similar code especially if we have four teammates. If we discuss further before coding, it may ease this situation. As a result, we have to follow up our own encoding or decoding.

For example, we all have the similiar function to get the element with querySelector, but at first we all use .image to get the default image. But when I deal with my part. I find that it may be a little mistake when I using delete button to delete the image. Hence ,it maybe cause other people's function doesn't work well. And we shoudle refactor it to querySelector(.page) instead.
3.Shotgun surgery: a single change that needs to be applied to multiple classes at the same time.
It is basically the same situation I mentioned in 2 . The simple change may have to be rewritten in every similar parts to do that.
4.Lazy class/freeloader: a class that does too little.
There are some functions just for simple use. Hence, these functions are very short and just for one simple usage.
private appendToChunks = (event: any) => {
this.chunks.push(event.data);
};
This function is just simple pushing. It can be considered as a lazy class.
It can be added into other functions.
5.Long method: a method, function, or procedure that has grown too large.

As for our repo, all the download functions can be considered long method. Cause we have to add encoding functions and deal with the certain code to get the index of string file and make them visible to the html that be downloaded. Hence, it turns out to be more and more large.
The possible way to fix that is to seperate the whole function into some little function like dealing with the string and call this funcion in download funcion. It is a relatively easy way to do that.
6.Excessively short identifiers: the name of a variable should reflect its function unless the function is obvious.

This function shoulde be refactored as choose_images function. In case the stakeholders can't easily understand the function.


Dockerfile update

The dockerfile on https://docs.flowiseai.com/configuration/deployment/hugging-face is not working so i updated the file please allow me so i can push the new Dockerfile.

maybe you should make the changes on your own forked branch instead :)


Missing docs from tutorial

[ ] defaults
Packages specifics:

[ ] openapi3
[ ] rest

defaults

Ah, good catch.

Add to: https://github.com/microsoft/cadl/blob/main/docs/tutorial.md


GUVNOR-2916: Library: It should be possible to create other project types on the library.

Part of ensemble:
https://github.com/droolsjbpm/kie-wb-common/pull/712
https://github.com/droolsjbpm/jbpm-wb/pull/646


Cirrus: Use images w/ buildah fix

Ref: https://github.com/containers/buildah/pull/1109
Signed-off-by: Chris Evich<EMAIL_ADDRESS>

/approve

Some day, our CI will start working, and the PR queue will start to shrink. But it is clearly not this day.

bot, retest this please

@mheon by the looks of it, it's only papr causing trouble here.  I'm finishing up #1606 which can replace the papr-F28 job.  Following that is #1674 to replace FAH-28.  CentOS and RHEL images are ready for testing to be switched on.  The future looks bright, and my pipeline of work is totally full :smile:
(This PR is ready to merge BTW)

The issue is the version of podman in F28 is broken. and this is causing all of the issues.  We need to get podman 0.10.1 into our test machines, and that should clear this up so that --privileged will start working again correctly.

@rhatdan this PR only affects cirrus, which currently does full-VM (make local...) testing on Ubuntu.  I haven't gotten to the podman-in-podman/docker-in-podman testing in cirrus yet, but it's in my pipeline.

ref: #1683 for papr updates-testing fix.

rebased and --force pushed.

/lgtm

/lgtm


TLS Verify Peers Fix

This patch fixes the logic problem with verifyPeers. If verifyPeers is enabled and no peer is specified or there are no known_hosts files an error will now occur instead of falling through to a successful connection.
Many thanks to @vladimirvivien for discovering this issue.

Codecov Report

Merging #515 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #515   +/-   ##
=======================================
  Coverage   28.23%   28.23%
=======================================
  Files          33       33
  Lines        1980     1980
=======================================
  Hits          559      559
  Misses       1362     1362
  Partials       59       59

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8570256...28f4b6d. Read the comment docs.

@akutz
This patch produces an error when libstorage.server.tls:true
rexray:
  modules:
    default-docker:
      disabled: true
libstorage:
  embedded: true
  client:
    type: controller
  server:
    tls: true
    endpoints:
      public:
        address: tcp://:7979
    services:
      virtualbox:
        driver: virtualbox

Causes the following error when the RR service is starting.
Apr 24 17:54:57 ubuntu rexray[8935]: REX-Ray
Apr 24 17:54:57 ubuntu rexray[8935]: -------
Apr 24 17:54:57 ubuntu rexray[8935]: Binary: /home/vladimir/DEV/go/bin/rexray
Apr 24 17:54:57 ubuntu rexray[8935]: Flavor: client+agent+controller
Apr 24 17:54:57 ubuntu rexray[8935]: SemVer: 0.8.2+17+dirty
Apr 24 17:54:57 ubuntu rexray[8935]: OsArch: Linux-x86_64
Apr 24 17:54:57 ubuntu rexray[8935]: Branch: tls-support-583
Apr 24 17:54:57 ubuntu rexray[8935]: Commit: efda90972215aeeb5b1a5e5d557bf6296f6a070c
Apr 24 17:54:57 ubuntu rexray[8935]: Formed: Mon, 24 Apr 2017 17:38:15 EDT
Apr 24 17:54:57 ubuntu rexray[8935]: libStorage
Apr 24 17:54:57 ubuntu rexray[8935]: ----------
Apr 24 17:54:57 ubuntu rexray[8935]: SemVer: 0.5.2+38
Apr 24 17:54:57 ubuntu rexray[8935]: OsArch: Linux-x86_64
Apr 24 17:54:57 ubuntu rexray[8935]: Branch: 8570256
Apr 24 17:54:57 ubuntu rexray[8935]: Commit: 857025622f33431b47f072024680ec89c88d3982
Apr 24 17:54:57 ubuntu rexray[8935]: Formed: Mon, 24 Apr 2017 17:38:03 EDT
Apr 24 17:54:57 ubuntu rexray[8935]: time="2017-04-24T17:54:57-04:00" level=error msg="error starting libStorage server" error="tls: neither Certificates nor GetCertificate set in Config" time=1493070897036
Apr 24 17:54:57 ubuntu rexray[8935]: time="2017-04-24T17:54:57-04:00" level=error msg="default module(s) failed to initialize" error="tls: neither Certificates nor GetCertificate set in Config" time=1493070897037
Apr 24 17:54:57 ubuntu rexray[8935]: time="2017-04-24T17:54:57-04:00" level=error msg="daemon failed to initialize" error="tls: neither Certificates nor GetCertificate set in Config" time=1493070897037
Apr 24 17:54:57 ubuntu rexray[8935]: time="2017-04-24T17:54:57-04:00" level=error msg="error starting rex-ray" error="tls: neither Certificates nor GetCertificate set in Config" time=1493070897037

But, the error goes away when I completely remove tls:true setting.

Hi @vladimirvivien,
That's because you told it to enable TLS on the server where there are no certificate files specified and none were found in the default locations. The server cannot enable TLS without certificates.

The following config will always be invalid unless certs are found in the default locations:

@akutz the cert/key files were at the default /etc/libstorage/tls directory actually.  That's why I was surprised it did not work.

Hi @vladimirvivien,
Not according to the provided logs they weren't. And you should remove it anyway to test the auto-enable. Please provide the full config and debug logs via a Gist link. Please indicate your deployment strategy as well.

Hi @vladimirvivien,
According to the above log you're not using the TLS patch:

Apr 24 17:54:57 ubuntu rexray[8935]: Commit: 857025622f33431b47f072024680ec89c88d3982

The TLS patch is ded0789bf209bcf390ef19c4c4d6b1156b8d9eab. You're still using 857025622f33431b47f072024680ec89c88d3982, the path refactor.


Removing the old import

Now that we can import using importlib I would like to remove the old import (import::import_module). The problem is that some of the modules that use the old import are needed for importlib import to work (_io, _thread). For example in io_open we import io using the old import so we can create an instance of FileIO. We can't use the new import as in that phase it is not initialized yet.
How do you think we should solve this problem? Should we remove all use of import in the modules used by importlib? This will require us to have a struct that implements PyValue for every class.

I was wrong about this as can be seen in #1102.


ALB ingress can't deploy on outpost

ALB creation fails when using an outpost subnet.
1015 23:21:32.485817       1 controller.go:217] kubebuilder/controller "msg"="Reconciler error" "error"="failed to build LoadBalancer configuration due to failed to resolve 2 qualified subnet with at least 8 free IP Addresses for ALB. Subnets must contains these tags: 'kubernetes.io/cluster/brylex': ['shared' or 'owned'] and 'kubernetes.io/role/elb': ['' or '1']. See https://kubernetes-sigs.github.io/aws-alb-ingress-controller/guide/controller/config/#subnet-auto-discovery for more details. Resolved qualified subnets: '[\"subnet-0dcffec1fcfc48382\"]'"  "controller"="alb-ingress-controller" "request"={"Namespace":"2048-game","Name":"2048-ingress"}
ALB creation detects my correctly tagged outpost subnet, however fails to proceed with ALB creation because check exists to qualify two subnets.
ALB on outpost only uses 1 subnet unlike the region which uses two.

i'll try to setup a outpost environment to resolve this post our initial v2.0.0 :D

ping me internally if you need access to an outpost

/kind feature

Closing
This is resolved with 2.0.1 release.


Add ability to disable only the visibility button

You might have a better idea of a cleaner way to do this but I'd like to be able to disable the visibility button on page load and only enable it after the user has modified the field, so I'm passing this in as a prop: disableButton={!fields[field].dirty}

Looks finde, I don't really see a cleaner way of doing this (using a prop is pretty clean already). Would you mind adding the new prop to the propTypes?

@leMaik Done :)

@shawngustaw Oh, I forgot to mention the readme. :see_no_evil: I'm sorry…

Btw, this will be released in v1.1.0 (coming in a minute).


Propose changes to address undefined behavior

Hello, thank you for making this crate. Here are some proposed changes to unsafe code that avoid undefined behavior. These changes either maintain the optimizations that the original versions contained or incur minimal overhead in the existing context.
For src/read.rs::read_bytes, creating a reference to uninitialized memory is considered undefined behavior (tracked issue). Since the function is called with n = 4 bytes, the initialization overhead should be minimal.
For calls to mem::transmute, we can add explicit return types to avoid possible unpredicted types from inference.
For the buffer fields in ChunksWriter and SampleWriter16, we can use MaybeUninit<u8> to be explicit about when the values are initialized to avoid undefined behavior of creating references to uninitialized memory.
In  write_sample<S: Sample>the calls to write on MaybeUninit<u8>'s behave the same as writing the u8 values as before.
For write_u16_le_unchecked, we can use MaybeUninit::write() like we did for write_sample but instead of referencing a bounds checked element at an index, we can get an unchecked reference as before.
Assmebly code for write_u16_unchecked can be found here.
Thanks again for maintaining this awesome crate, I hope you find these proposed changes useful for future development and use.

Thank you for taking the time to open a pull request. Nice that you also verified the assembly for write_u16_unchecked.
I have two small comments, but overall this looks like a nice improvement.
For MaybeUninit, in the past I refrained from using it because it was relatively new (Hound predates it by several years, you can probably also tell by the try! instead of ?) and at the time I did not think bumping the minimal supported Rust version was worth that. But by now, Rust 1.36 is pretty old, and making 1.36 the new MSRV should be fine. We can also go to 1.40 and get f32::from_le_bytes. Even Debian oldoldstable ships Rust 1.41, so bumping the MSRV to 1.40 should be fine.
If you address my comments, I’ll merge this, but also to set some expectations, master is not in a state right now where I’m comfortable releasing it. I want to review it front to back and fuzz it before making a new release, but in all honesty, I’ve been planning to do that for multiple years now and I never get to it, so it’s unlikely that I’ll release this soon.

Thanks!

Interested in picking up these changes! Would these changes be able to release out in a new crate version?

So, @maxwellmckinnon backported these changes on top of v3.5.0, and I published those to crates.io as v3.5.1. As far as I am aware, the undefined behavior did not cause rustc to compile programs in a problematic way, but for good measure I submitted a RustSec advisory either way.


phaser.d.ts Game constructors do not match documentation

According to the documentation it is perfectly valid to pass strings to the first two parameters of Phaser.Game. However, that is not supported by the TypeScript implementation which only supports numbers:
constructor(width?: number, height?: number, renderer?: number, parent?: any, state?: any, transparent?: boolean, antialias?: boolean, physicsConfig?: any);

constructor(config: IGameConfig);

Hey @Bilge
This has been addressed on the dev build:
https://github.com/photonstorm/phaser/blob/dev/typescript/phaser.d.ts

Wouldn't it be more correct to create another constructor definition that accepts strings, rather than just cover it up with an any type? Does TypeScript support this sort of overloading?

You are right about overloading. As far as the any goes, I was actually hoping we would get some union types by now.

Maybe in the next version of TypeScript :+1:

@Bilge  that appears to be now with 1.4 :dancer:
http://blogs.msdn.com/b/typescript/archive/2015/01/16/announcing-typescript-1-4.aspx

Created #1570.


FileSystemLoader Loader Constructs Incorrect Path

In loaders.py, there is code at line 68 that does not produce the desired path in Windows in some cases:
def get_source(self, environment, template):
    pieces = split_template_path(template)
    for searchpath in self.searchpath:
        filename = path.join(searchpath, *pieces)
        # ...

The function split_template_path() splits a full path into fragments like this: ['c:', 'xxx', 'yyy', 'zzz'txt'].
The bug is that for this kind of split path, os.path.join() does not produce a proper path in Windows.  E.g.:
sep = '\\'
pieces = ['c:', 'xxx', 'yyy', 'zzz.txt']
filename = os.path.join(sep, *pieces)
# gives 'c:xxx\yyy\zzz.txt', not the intended c:\xxx\yyy\zzz.txt

I have observed cases where the full path to a template file is split by split_template_path(), then passed to get_source with searchpath = \.  The intended output is obviously a fully qualified path since it gets passed to open_if_exists().  The result is that the template is never found.
This code may appear in other loaders too, but I have not checked this.
This joining behavior is actually the documented behavior for os.path.join().  So Jinja needs to work around it.  One way would be to check to see if the template string is an existing path.  This could look like the following:
    def get_source(self, environment, template):
        pieces = split_template_path(template)
        for searchpath in self.searchpath:
            if os.path.exists(template):
                filename = template
            else:
                filename = path.join(searchpath, *pieces)
            f = open_if_exists(filename)

Desired Behavior
To demonstrate, run the following code:
import os
from jinja2 import loaders
PTH =  '\\'
fqp = r'c:\spam\green\eggs.txt'  # or 'spam\green\eggs.txt'
splitpath = loaders.split_template_path(fqp)
if os.path.exists(fqp):
    filename = fqp
else:
   filename = os.path.join(PTH, *splitpath)
print filename
# When fqp points to an actual file, observe filename = fqp
# When fqp is not an absolute path to an actual file,  observe
# that a proper path is constructed: \spam\green\eggs.txt

Actual Behavior
import os
from jinja2 import loaders
PTH = '\\'
fqp = r'c:\spam\green\eggs.txt'
splitpath = loaders.split_template_path(fqp)
print splitpath # observe lack of "\" after the "c:".
filename = os.path.join(PTH, *splitpath)
print filename
# observe incorrect path c:spam\green\eggs.txt'

Your Environment

Python version: 2.7
Jinja version: 2.10.3

Template paths are not supposed to be filesystem paths. It doesn't make sense to be passing c:\anything in this context.


RFC: drivers: clock_control: stm32: add an option to enable CRS for HSI48

The HSI48 clock is the clock used by default for the USB controller, however its default tolerance is not enough for the USB specification, leading to some random errors depending on many factors, including the upstream HUB or host.
This commit adds an option in the device tree to enable the STM32 Clock recovery system (CRS) using USB SOF packet reception as a reference, which brings the HSI48 within the required accuracy for USB transfers.
Note: this is just a RFC to check the concept for the STM32G0 family, which will likely break the compilation for other STM32 families. Then it can be improved added support for the other families, and also support for using LSE as a reference (which might require using an enum property instead of a boolean).

@aurel32 Do you  intend to complete this PR ?
On my side, I consider this is heading to the right direction

@aurel32 Do you intend to complete this PR ?
On my side, I consider this is heading to the right direction

Yep it's still on my todo list, just that I am a bit busy those days

@aurel32 Are you fine if we take up this PR ? (@Desvauxm-st most likely)

I haven't been able to dedicate time for Zephyr in the last months, so yes just go ahead and do not block on me. I'll be quite happy if the issue is fixed

@aurel32
you can find this new PR in relation with this RFC
drivers: clock_control: stm32: add an option to enable CRS for HSI48 #63111


added short parameter names also to constructors and methods

#179

Need to rebuild one test image, if it is going to merge. How can I do this?

Run the testsuite locally and commit the diff.

I'm not sure about the term "decoration", but the rename to "tableEntryAnnotation" will produce quite a big diff for the next dlang.org upgrade. Just puttying this up for thought.
Otherwise +1


Update Documentation “knowledge-base-discover-by-features”

Automatically generated by Netlify CMS

👷 Deploy Preview for elastic-yonath-a8509d processing.
🔨 Explore the source changes: 3b76511ade326be20bab0f7f5f3c43ef8dc02e76
🔍 Inspect the deploy log: https://app.netlify.com/sites/elastic-yonath-a8509d/deploys/619338cf19e6c00007565ee4


Accept default as function

Fixes #13

Codecov Report

Merging #17 into master will not change coverage.
The diff coverage is 100%.

@@          Coverage Diff          @@
##           master    #17   +/-   ##
=====================================
  Coverage     100%   100%
=====================================
  Files          14     14
  Lines         332    332
  Branches       93     94    +1
=====================================
  Hits          332    332

Impacted Files
Coverage Δ

packages/schm/src/parsers.js
100% <100%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3ca2faa...cc1fddb. Read the comment docs.


Make log_message() compatible with PSR-3

Description

Now, any call that is done through the log_message() function will use your library instead.
https://codeigniter4.github.io/CodeIgniter4/general/logging.html#using-third-party-loggers

But the method log() does not exist in PSR-3, so log_message() does not work with PSR-3 logger.
Checklist:

[x] Securely signed commits
[] Component(s) with PHPdocs
[] Unit testing, with >80% coverage
[] User guide updated
[x] Conforms to style guide

@paulbalandan
You are correct.
I overlooked that method.


UI - Provider help for Global DNS annotation when creating ingress.

Rancher server version -  Build from master
When user wants to create Global DNS entries pointing to projects , they are expected to create ingress with annotation - rancher.io/globalDNS.hostname to match the  host name they use for their routing rules.
It would be good if UI is able to provide some helper text /option to make this annotation made available to the user.

Version: Master 2.2 (2/21/19)
There is now helper text if you pick the Projects radio button when creating a GDNS entry:


Gitlab API Browser

add a gitlab api browser that serializes the received data into a class that sanitizes it.

marked this issue as blocking #115

marked this issue as blocked by #138

marked this issue as blocked by #58

marked this issue as related to #68


eu-central-2 support

Would it be possible to also support eu-central-2 region? Looks like currently AMIs are not pushed there

There's a few regions that have launched in the last year that we're not in yet. I'll be sure to add them in the next release. For now you can use Packer to build and deploy an AMI into your own account. We'll get eu-central-2 included in the next release.


jsonwebtoken dependency.

Is the jsonwebtoken dependency still being used?  It looks like the only reference to it was taken out in November.

@wtgtybhertgeghgtwtg Ah yep, this is now in the sc-auth module. Thanks.


[Feature Request] More advanced demos for Graph RAG

Required prerequisites

[X] I have searched the Issue Tracker and Discussions that this hasn't already been reported. (+1 or comment there if it has.)
[ ] Consider asking first in a Discussion.

Motivation
explore more for Graph RAG
Solution
No response
Alternatives
No response
Additional context
No response

can I work on this?

Hey @havkerboi123 , thank you for your willingness to contribute! We are excited to have more use cases and demos utilizing our graph RAG capability and to further enhance it. I will assign this issue to you, and please feel free to create a pull request for this. Here is our contribution guideline FYR: https://github.com/camel-ai/camel/blob/master/CONTRIBUTING.md


Create a .tmLanguage file for syntax highlighting

We have a basic Vim syntax definition, but other editors (TextMate, VsCode, SublimeText, etc.) will need a .tmLanguage file to enable syntax highlighting.
See also gh-48 (LSP support).

It may be possible to convert from .tmLanguage to elisp for emacs support as well: https://stackoverflow.com/q/28592093/10601


gdocwork._write_to_df_sheet has orphaned option

Code currently has non-default option to write with AppsScript, but all calls use gspread. Try to migrate to AppsScript and kill the gspread option

With latest release of gspread, that option is actually faster. Will leave both options in function in case the Apps Script option is useful with quota issues.


Add cookie information message

When a user visits a site for the first time show them a message about cookies and link to the cookies section on the help page. On any subsequent page views the cookie message is hidden by the presence of a cookie called seen_cookie_message being set to yes.
This follows the pattern establised on GOV.UK and in the govuk_template gem but the implementation is slightly different in that we're not using JavaScript to determine whether to show the message or not and we're also setting the expiry date on the cookie that stores whether the user has seen the message or not to 1 year and not the standard 28 days.
We may need to revisit this when we look at performance and caching.
https://www.pivotaltracker.com/story/show/95857040

:+1: nice and simple.

LGTM :+1:

LGTM


Hosted login page url

Need to link hosted or live url of login page in readme.md with additional coloumn

i can work on this

Would like to work on this

@abhir9, is the github pages is on for this repo? then it will be easier to do.

i would love to work on this issue can you please assign it to me @abhir9

Hey @abhir9 ,
I would love to fix this issue, please assign this to me.

@abhir9 please assign me if no one is assigned

I would like to contribute

Hello @abhir9,
I have a lot of experience with hosting websites and I would love to work on this.  Please assign this issue to me.
Many thanks,
Vijay Shanmugam

Hello @abhir9,
I have hosted the login pages on Vercel and I have submitted a PR with my changes.  Please let me know if this is what you were looking for.
Thanking you,
Vijay Shanmugam

Hey, Can i work on this?

Hi Please assign this issue to me.
I have created responsive login page.


Implement CH4 Challenge 1 - Elliptic curve cryptography

Use the ScriptingChallenge component  to implement chapter 4 challenge 1. For our lesson IDs we can use CH4EC1 and CH4EC2.
Link to Figma
Is currently blocked by #624 and #593

@afterburn  is this still blocked by #624  and #593 ??

#593 is really just an intro page, and #624 should be ready to be implemented; it is still open only because we haven't tested it in an actual way yet. This issue should be ready for dev!

From the call I think that the mvp for this issue should also include creating the placeholder for the suceeding lesson, as this person would be most familiar with how they have saved the data on their primary work. @afterburn let me know if you disagree on this


Example code crashes with no error

When I run the example code (as written in the readme), the app crashes with no error message. When I print out the native modules I can see that RNIcloudAccountStatus is available. I've also been able to console log the constants e.g. iCloudAccountStatus.STATUS_AVAILABLE implying that it has been correctly installed and that there is a bug with the getStatus method.

Hi, in order to help you, could you provide the following:

iOS version
React Native version
Activated Capabilities for your app (see Requirements in README)


Adding support for specifying output file in bin_descend

This fixes issue #15

Thanks, this is much appreciated!


Added new tier 3 projects

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):
Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[x] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes.
[x] All new and existing tests passed.

repos migrated, so this is now up to date 🚀


feat: Open search results in new activity

Fixes #170  #664

This is going from OK to bad again. Fix back stack management for once and robustly, we do not want to handle edge cases in this manner

Then this issue can solve in #170 by showing search results in a new activity or handling onBackPressed in MainActivity. Any other suggestions?

@nikit19 Updated

The title is not changed in event detail view

The title is not changed in event detail view

There was no title in event detail view, should I remove it or add specific title according to the event?

The event title should be displayed there

The event title should be displayed there

Updated. Is that okay?

@iamareebjamal Title issue can be solved by using only title =  instead of  supportActionBar().title in other places also. But in MainActivity supportActionBar is using everywhere. And EventDetailFragment is used for event details, from events, favorites, and search.
If I change everywhere, casting for the title is not necessary, but how to handle home up button then.
.
I see other projects(susi_android) as well, they are using like that for getting support action bar from fragment -
(activity as? MainActivity)?.supportActionBar?.setDisplayHomeAsUpEnabled(true)
(activity as? MainActivity)?.supportActionBar?.title = " "
.
The main problem is I cannot access supportActionBar without this.
Even in the current state of this project following method is used -
val activity = activity as? MainActivity
        activity?.supportActionBar?.setDisplayHomeAsUpEnabled(true)
        activity?.supportActionBar?.title = ""

Changed in PR #57 Authored by @simarsingh24

Then how can you get supportActionBar from SearchResultsActivity?

I see other projects(susi_android) as well, they are using like that for getting support action bar from fragment
If even Google would be doing it, it won't make it right

Then how can you get supportActionBar from SearchResultsActivity?
Same
(activity as? SearchResultsActivity)?.supportActionBar by if (fromSearchResults) . But it becomes same.

But, currently,  is that okay or need to change it? -

Even in the current state of this project following method is used -
val activity = activity as? MainActivity
        activity?.supportActionBar?.setDisplayHomeAsUpEnabled(true)
        activity?.supportActionBar?.title = ""

No, it is not okay to change to that. It is simply not needed. Period.
I will give you a very simple code. A quick showcase of how inheritance works in Java. You can run it in kotlin to get what I am trying to say
class SupportActionBar {
	private var displayHomeAsUp = false
	var title: String? = null

	fun setDisplayHomeAsUpEnabled(enabled: Boolean) {
		this.displayHomeAsUp = enabled
	}
}

open class Activity {}

open class FragmentActivity: Activity() {}

open class AppCompatActivity: FragmentActivity() {
	var supportActionBar: SupportActionBar? = SupportActionBar()
}

open class MainActivity: AppCompatActivity() {}

open class SearchResultsActivity: AppCompatActivity()

open class SomeThirdActivity: AppCompatActivity()

class TestFragment(val fromSearchResults: Boolean, extra: Boolean = false) {
	var activity: FragmentActivity? = null

	init {
		if (extra) {
			activity = SomeThirdActivity()
		} else {
			if (!fromSearchResults) {
				activity = MainActivity()
			} else {
				activity = SearchResultsActivity()
			}
		}
	}

	fun run() {
		// activity?.supportActionBar.?title = "OK" // Won't work because fragment activity does not have title

		val thisActivity = if (fromSearchResults) activity as? SearchResultsActivity else activity as? MainActivity
		if (thisActivity is MainActivity) {
			println("MainActivity")
		} else if (thisActivity is SearchResultsActivity) {
			println("SearchResultsActivity")
		} else {
			println("Something Else")
		}
		thisActivity?.supportActionBar?.title = "Explicit casting"
		println(thisActivity?.supportActionBar?.title)

		// This will work, but its very bad
		// Why not do this?

		val finalActivity = activity
		if (finalActivity is AppCompatActivity) {
			println("AppCompatActivity") // This will be true for both cases
			finalActivity.supportActionBar?.title = "Implicit casting"
			println(finalActivity.supportActionBar?.title)
			finalActivity.supportActionBar?.setDisplayHomeAsUpEnabled(false)
		}

	}

}

TestFragment(true).run()
println()
TestFragment(false).run()
println()
// TestFragment(true, true).run() // Uncomment this to see why your case will fail and mine will not

I have spent half an hour to devise a way for you to understand why is not needed at all to cast to MainActivity or SearchResultsActivity.
Carefully study it and modify it and run it with Kotlin and then tell me that you  understand or not that it is not required to cast FragmentActivity to any of the concrete class because supportActionBar is not a property of either of those classes

@iamareebjamal
Thank you for this. Now, I understand how smart cast can be used from this example.
I'm very sorry to bother you about this, My knowledge for kotlin smart cast was not clear.
In my case, it fails because if another activity is using the same fragment.

val finalActivity = activity
if (finalActivity is AppCompatActivity) {
println("AppCompatActivity") // This will be true for both cases
finalActivity.supportActionBar?.title = "Implicit casting"
println(finalActivity.supportActionBar?.title)
finalActivity.supportActionBar?.setDisplayHomeAsUpEnabled(false)
}

I have tried it before but it was not working due to declare val finalActivity = activity as private before onCreate().
When I use it in that way, working fine.
But in onDestroyView, need to specify the title while returning from the fragment. It can be done with smart casting but, the condition is required to specify the title. So, need to use fromSearchResults. Can I go for it?

Updated

@iamareebjamal Updated.

Please merge this PR so, I can work on another issues related to this activity and fragment.