[Refactor] Renaming for some public facing API

Purpose

Renaming for public facing api to shorten parameter name
Rename generic name ErrorType to CommunicationUIErrorType
Remove cusotmTranslations logic from localization (will not support currently)

Does this introduce a breaking change?

[ ] Yes
[ x ] No

Pull Request Type
What kind of change does this Pull Request introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ x ] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[ ] Other... Please describe:

What to Check
Verify that the following are valid

All test passing, and app is functional

Other Information

We will need to update the change log with the ErrorEvent rename I believe this will be considered a breaking change

We will need to update the change log with the ErrorEvent rename I believe this will be considered a breaking change

Should that be a separate PR for documentation? or should I list all the api breaking changes because we renamed communicationTokenCredential to credential and themeConfiguration to theme


Replace with opensearch-http-channel and opensearch-http-server-channel

Description
Netty4HttpServerTransport uses es-http-channel and es-http-server-channel as an attribute key for netty channel.
They are replaced with opensearch-.
Issues Resolved

#1795

Check List

[ ] New functionality includes testing.

[ ] All tests pass

[ ] New functionality has been documented.

[ ] New functionality has javadoc added

[X] Commits are signed per the DCO using --signoff

Signed-off-by: Shinsuke Sugaya<EMAIL_ADDRESS>

start gradle check

@marevol Can you rebase and do a force push for the CI to pass


cfn_flip: init at 1.1.0

Motivation for this change
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[ ] NixOS
[ ] macOS
[x] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Assured whether relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

@dotlambda Moved the package to python-packages.

@dotlambda fixed that ^^

@dotlambda  should be good now.

@GrahamcOfBorg build python2.pkgs.cfn-flip python3.pkgs.cfn-flip


Please Integrate Laravel Passport for Authentication.

As Laravel has provided passport fro API authentication so we should integrate Passport instead of JWT OR "tymon/jwt". etc

That's intended more for when you have an api for consumers. In this case the api is only used by the client application.


ISO Creation Error.[BUG]

Missing the required efisys_noprompt.bin bootfile for ISO creation.
18363.1 Enterprise ISO updated with W10UI script to 18262.10015

This is not a bug with Optimize-Offline...
The reason Optimize-Offline bypasses the ISO creation is because the W10UI script removes the efisys_noprompt.bin, thus it's not present for Optimize-Offline to use as a bootcode for ISO creation.
To correct this from occurring, you need to remove that line of code in the W10UI script that deletes the efisys_noprompt.bin so your update images retain both bootcode files.

Thank you.


Transparent axis/button IDs

Per IRC discussion, this replaces the AxisId/ButtonId newtypes with type aliases, and relocates them to the events module. This makes generic input events usable in practice, and is more consistent with the existing ScanCode type.
Replaces #172.

I'm in favor of this, but let's leave it open for discussion.
My reasoning is that basically an axis ID or a button ID is always no more than some sort of index. You can't add or remove axes or buttons for example. Therefore there is no reason for these to be opaque, and using a dedicated type feels like too much typing.

For posterity: the motivation behind newtypes was to provide strong typing to avoid confusion between unrelated ID spaces in comparisons and possible future APIs to query for details (such as name or axis resolution and range). I think these are reasonable goals, but it's not totally obvious that accomplishing them with newtypes is a net ergonomic win: simple uses will likely be limited to matching on hardcoded values (e.g. 0/1 usually being X/Y axes), making the newtypes nothing but extra verbosity. Combining that uncertainty with the convention established by ScanCode and the improved convenience of type aliases for the inevitable operations that wouldn't be forwarded by a newtype (such as (de)serialization) I'm satisfied with the type alias approach.


nz-descriptions component is not entirely themeable

Version
8.2.0
Environment
all
Description
Descriptions is missing a theme variable for the item label backgrounds https://github.com/NG-ZORRO/ng-zorro-antd/blob/8.2.0/components/descriptions/style/index.less#L100

I see this is an upstream issue. Created a new issue there https://github.com/ant-design/ant-design/issues/18372

@krokofant Thanks you for opening these pull requests (we are enjoying a free ride 😎

@wendzhue @vthinkxie If an issue like this was fixed upstream should it still be mentioned in the ng-zorro release notes after the upstream is synced to ng-zorro?
Like now I'm keeping track of when this PR from the bot is merged but ideally I'd want to keep track of the ng-zorro release notes. Thanks for your insights.


WIP Allow large range to run concurrently with writes

The main idea is to get a dedicated boltdb transaction for range request instead of using the readtx which blocks batchtx for writes.
This PR includes a draft work, which makes all requests behavior as what large request should...
But the result is promising! With a large range over 1mm keys that taking 3s to finish, the write latency remains stable! Before this patches, the slowest put takes 3s.
Summary:
  Total:	49.1813 secs.
  Slowest:	0.7156 secs.
  Fastest:	0.0004 secs.
  Average:	0.0048 secs.
  Stddev:	0.0075 secs.
  Requests/sec:	203.3294

/cc @heyitsanthony @mitake What do you think about this?

got a better solution. will push soon.


Pool fails to restart actors on Travis only?

Hi,
Thanks for all your work on this gem. It's been really fun trying to learn how everything works!
I'm trying to parallelize some tree traversal: as I go down each node, that node determines whether there are any nodes under it, and if there are, it continues downward.
In my test suite, there are a couple tests which make sure that, if an error is raised during this process, it is either raised or returned as a string message, depending on a debug: switch.
On my local environment (OSX 4-cores, I've tried Ruby 2.2.0 & 2.1.5), the test suite always passes. On Travis, the test suite fails if the error checking tests run before other tree traversal tests. Those later tests fail with DeadActorError, which suggests to me that the pool hasn't restarted some dead actors.
At first, I thought the difference might be pool size, since it defaults to Celluloid.cores. But even setting a default pool size of 10, it continued passing locally but failing on Travis.
Can you help me find the cause of this problem? Or why it would behave differently on Travis than locally? It seems likely that I am misusing Celluloid in some way that I don't understand!
Here's some relevant info:
My code

[ExecutionWorker] (https://github.com/rmosolgo/graphql-ruby/blob/parallel-2/lib/graphql/query/parallel_execution.rb#L76-L81) performs a non-destructive proc which returns a value:
It's pooled with a Celluloid::Supervision::Container
The pool is started before I do the traversal
It's used to find child nodes in the tree
Later, I recurse over those returned Celluloid::Futures to get their values

Failing Test

During this test, a RuntimeError is raised during traversal, then re-raised by my code (on purpose)
During this test, the RuntimeError is rescued and returned as a string message
The following test fails with DeadActorError

Is there anything else I can provide that would help find the cause of this?

Sounds like there's a race condition in CI. I will come back to help you with this if someone else doesn't before me. I will leave this here because it's so well put together, but usually this would either be a question on the mailing list until it's determined to be a bug -- or at least posted on the gem in question; in this case celluloid-pool

And fyi, I magically happen to have a lab in Carlsbad, so if this gets totally out of hand for you, I have a half-room full of whiteboards. But hopefully this can be handled simply for you.

Ohhh thanks for the tip -- actually that's quite helpful.
For the time being, I think I can just use a fresh pool for each run. It adds some overhead of restarting & terminating, but I think it's ok for now.
Thanks for your suggestion, and the offer to meet up! Btw if you're ever interested, we host this at our office near Palomar Airport: http://www.meetup.com/fullstacktalks/ :)
Ok, I'll close this, feel free to reopen if you want to use it for bug tracking or something, but I'm happy!


Invent and implement testing for Command Line: xlsx-renderer-cli and xlsx-import-cli

According to: #97, #129

I removed the important label because CLI libraries aren't as popular as expected. More important things to do.

I removed the important label because CLI libraries aren't as popular as expected. More important things to do.


Implement the feature that close issuse as archived/merged/resolved

Close #22793
Implement the feature of "Close as archived / resolved / merged"

Create a new issues, open the dropdown, user can select what they want to do.

click the left button, submit with a comment.

in the issue list, we can see what kind of closed status in the tooltip

This PR is not good enough, I am trying to rewrite this in a new branch, and will create a new PR replace this when it was done. So close it for now.


Merge Stylesheet and SubredditStylesheet

They now function as one, which saves a bunch of memory during runtime and makes the size of the codebase smaller.
Fix #1378

which saves a bunch of memory during runtime

How much are we talking about?

Well, one object doesn't take up too much memory on its own, but if you were working with a bunch of subreddits, it would save some memory.

On Mar 22, 2020, at 1:58 PM, Bryce Boe<EMAIL_ADDRESS>wrote:

which saves a bunch of memory during runtime
How much are we talking about?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

subreddit_id is just the full name for the subreddit, and as we already have a subreddit attribute, I didn't see the need for another one.

On Mar 22, 2020, at 2:07 PM, Bryce Boe<EMAIL_ADDRESS>wrote:

@bboe requested changes on this pull request.
In praw/models/reddit/subreddit.py:

@@ -2982,6 +3013,15 @@ def init(self, subreddit):

     """
     self.subreddit = subreddit

   super().__init__(subreddit._reddit, None)

   self.subreddit_display_name = self.subreddit.display_name

Is this an actual attribute returned by Reddit? If not, please prefix with _.
In praw/reddit.py:

@@ -389,7 +389,6 @@ def _prepare_objector(self):
"moderators": models.ModeratorsWidget,
"more": models.MoreComments,
"post-flair": models.PostFlairWidget,

       "stylesheet": models.Stylesheet,

Why don't we update the mapper to use the new object?
In praw/models/reddit/subreddit.py:

@@ -2982,6 +3013,15 @@ def init(self, subreddit):

     """
     self.subreddit = subreddit

   super().__init__(subreddit._reddit, None)

   self.subreddit_display_name = self.subreddit.display_name

def _fetch(self):

   url = API_PATH["about_stylesheet"].format(subreddit=self.subreddit)

   data = self.subreddit._reddit.get(url)

   data = data["data"]

   del data["subreddit_id"]

Why are we deleting this attribute?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

Well, one object doesn't take up too much memory on its own, but if you were working with a bunch of subreddits, it would save some memory.

That's a much different statement than "saves a bunch". Let's try to avoid making general statements without data. I agree a constant amount memory will be saved per instance, but that's not really a great reason to make a change. A change that saves a linear amount of memory, or a polynomial amount (or more) general are worth it.

subreddit_id is just the full name for the subreddit, and as we already have a subreddit attribute, I didn't see the need for another one.

I don't like the idea of removing attributes that Reddit provides. So please leave that in.

subreddit_id is just the full name for the subreddit, and as we already have a subreddit attribute, I didn't see the need for another one.

I don't like the idea of removing attributes that Reddit provides. So please leave that in.

I was thinking of making that the model display name, although I might redefine __str__`` To display the subreddit` name.

The main motivator for combining the two classes is that when you look for a Stylesheet, you are presented with two different classes, and it's confusing to work with, because you don't know which one the methods return.


.container class now breaks responsivness

The Bootstrap .container class is now primarily intended to wrap a site's contents ( http://getbootstrap.com/css/#overview-container ) and therefore sets a fixed width relative to the viewport. It used to be the case that Bootstrap allowed containers inside navbars by setting: .navbar .container { width: auto } but that no longer seems to be the case (.3.3.6).
By using the .container class within twitter-bootstrap-wizard's navbar, the pills no longer wrap to the wizard container's width when not being used at full page width.
Unless I'm missing something (possible), either the use of the .container class needs to change, or an additional css style needs to set its width to auto.

@losttheplot it's up to you to decide the markup for the navigation bar. the demo just shows how this can be done as an example, since that was created for bootstrap 2 and then early 3.x version it might not be the best option any longer. feel free to change the markup.


Arbitrary buttons

Shifts from having just +/- buttons to allowing any number of buttons with arbitrary glyphs. Also adds some plumbing in ANTLR to make more +/- buttons possible in C mode, and implements +/- buttons for several constructs in C mode.

Abandoned in favor of #181


Support glTF spec gloss extension

Support the KHR_materials_pbrSpecularGlossiness extension.
https://github.com/AnalyticalGraphicsInc/gltf-pipeline/issues/331 has a lot of good notes.

We can also close this @lilleyse.


Unable to properly infer complex Json

If I have the following command:
Route.get("complex") { request in
    let json = [
        "root" : [
            ["hello" : "world"],
            ["hello" : "mars"]
        ]
    ]
    return try Response(status: .OK, json: json)
}

It will work locally, but on Heroku, it will hit Mirror in the JsonSerializer and return ""
If, I add let json: [String : Any] = ... then it will return { "root" : "" } because it fails in parsing the nesting.
This can be reproduced locally, but requires a bit trickier response:
Route.get("thing") { _ in
    let thing: [String : [String : Any]] = [
        "one" : [
            "hi" : "there"
        ],
        "two" : [
            "hi" : "again",
            "bye" : "sup"
        ]
    ]

    return thing
}

Then my only response is: `

FWIW, NSJSONSerialization ran on heroku for me, I also use a library https://github.com/gfx/Swift-PureJsonSerializer which might be nice to use if you'd prefer to stay truly pure Swift

Yeah the current JSON serializer for Linux is a placeholder for something better. I was hoping to hold out for Apple supporting pure Dictionary and Array objects in their Foundation serializer.
I will look into that repo you linked.

I took a look into a couple JSON serializers for supposedly "Swift on Linux" last night, and none of them worked. The current Linux compiler does not view [String: Any] as an AnyObject which they all seem to rely on. Or some rely on defining your JSON like this:
let response: JSON = [
     ....
]

I'm not a fan of this solution because this destroys the concise syntax of something like:
Route.get("...") { _ in
  return [
      ...
  ]
}

You can use the Foundation JSON serializer if you explicitly make all of your responses NSDictionarys with NSString keys, but that is a pain semantically.
I can't see any solution now besides waiting for the compiler to get its weirdnesses figured out.

The pure Json one works for sure, I'll make a pull request in a bit

I see the problem with the requiring an explicit addition.
I've solved a similar problem w/ Json convertible types on top of pure json serializer.  I'll see if I can apply some of that here so the user could see just a standard concise syntax and we'd be able to convert it in the background.

If you could make a PR or link me to some examples of this working that would be helpful. Also, nice article on Medium. :+1:

@tannernelson Will do, might not be until tomorrow, but I have some code that should work for this.  I just need to break the convertible component out so we're not doing copy pasta between the two libs.
Glad you saw the medium post, I couldn't find your twitter to link you, let me know if you have one and I'll add it!

My twitter is @tanner0101
And that sounds good. Feel free to submit the PR early/incomplete if you want assistance working on it.

@tannernelson If you didn't see, we're up on http://iosdevweekly.com/
Hopefully can get some more traffic this way!  I've started some of the Json convertible stuff, I'll have a pr up soon hopefully :+1:

Awesome! :) Congrats.
Also, check out issue #28. There is a potential solution for serializing and parsing mentioned there.

Awesome coverage!
Matthew Clarkson

On 20 Feb 2016, at 6:52 AM, Tanner<EMAIL_ADDRESS>wrote:
Awesome! :) Congrats.
Also, check out issue #28. �There is a potential solution for serializing and parsing mentioned there.
—
Reply to this email directly or view it on GitHub.

Added to roadmap.


net/frr: Add BGP neighbor timers and graceful restart

Closes #1001

@mimugmail did you mean to reference https://github.com/opnsense/plugins/issues/1877 ? Would you mind also adding an option to define a value for the connect timer? The syntax is "neighbor X.X.X.X timers connect Y"
Alternatively, can we get this merged so i can create another PR to add the connect timer?

@marcquark ok its in now, @fichtner no bump needed, current stable is 1.17 and devel 1.19 :)

Merged, thanks!


Serpent Interface Upgrade

Pull Request Description
What issue does this change request address? (Use "#" before the issue to link it, i.e., #42.)
Closes #2289
What are the significant changes in functionality due to this change request?
This merge request is aimed to upgrade and make the SERPENT interface fully functional and flexible.

Addition of support for eigen/criticality calculations (not only burnup)
Usage of open source tool (serpentTools: https://serpent-tools.readthedocs.io/en/master/index.html) to parse results from serpent. The serpentTools library is not installed if a user does not invoke the serpent interface.
Utility Function to create RAVEN variable groups has been rewritten to leverage Serpent output parser directly (if a modification of the parser is performed, the script is able to get it directly)
Addition of embedded reactivity calculation
Support of multiple output files (Result files, Detector outputs, Depletion outputs, Micro XS reader)
Bumat support has been disabled since Serpent is removing (deprecated) such output format and all the info are already contained in the Depletion output (*dep.m format)
Consistency checks in the input files (if an output is requested, the flags in the input are checked accordingly)

For Change Control Board: Change Request Review
The following review must be completed by an authorized member of the Change Control Board.

[x] 1. Review all computer code.
[x] 2. If any changes occur to the input syntax, there must be an accompanying change to the user manual and xsd schema. If the input syntax change deprecates existing input files, a conversion script needs to be added (see Conversion Scripts).
[x] 3. Make sure the Python code and commenting standards are respected (camelBack, etc.) - See on the wiki for details.
[x] 4. Automated Tests should pass, including run_tests, pylint, manual building and xsd tests. If there are changes to Simulation.py or JobHandler.py the qsub tests must pass.
[x] 5. If significant functionality is added, there must  be tests added to check this. Tests should cover all possible options.  Multiple short tests are preferred over one large test. If new development on the internal JobHandler parallel system is performed, a cluster test must be added setting, in  XML block, the node <internalParallel> to True.
[x] 6. If the change modifies or adds a requirement or a requirement based test case, the Change Control Board's Chair or designee also needs to approve the change.  The requirements and the requirements test shall be in sync.
[x] 7. The merge request must reference an issue.  If the issue is closed, the issue close checklist shall be done.
[x] 8. If an analytic test is changed/added is the the analytic documentation updated/added?
[x] 9. If any test used as a basis for documentation examples (currently found in raven/tests/framework/user_guide and raven/docs/workshop) have been changed, the associated documentation must be reviewed and assured the text matches the example.

Job Test qsubs sawtooth on a5b2cd7 : invalidated by @wangcj05
very slow in removing packages

Job Test qsubs sawtooth on a5b2cd7 : invalidated by @wangcj05
library issue

checklist passed. PR can be merged.

@wangcj05 Thanks a lot!!!


Issue with  1.2.2 for zabbix

Hi Dave,
Currently i had to drop down to version 1.2.1 as the change seems not sending to zabbix
This happens when i first create the repo
Thanks

Solved with 1.2.3

HI @tiredofit Quick question, i currently see this info but no data? could you remind me whats the manual command to send the info to zabbix?

Backups get sent to Zabbix from here: https://github.com/tiredofit/docker-restic/blob/2b159b3213cf1a66c70dfd0a96dcc2e0f165654a/install/assets/functions/20-restic#L1197 - Since it's doing it silently you can activate SHOW_OUTPUT=TRUE which may give some information as to what is being sent or the results, or by cranking up the log level in your zabbix agent (4) and reading the logs when the information is being sent..


no arg call fails with "mkn.yml" but not "mkn.yaml"

fixed in https://github.com/Dekken/maiken/pull/52


2217 Update digital schema

Pre-review checklist
I have ensured that:

[ ] Code runs successfully in the development environment.
[ ] New code is tested to prove that it works. If not, justify reasoning.
[ ] New code is documented using type hinting and following the numpydoc docstring format.
[ ] New code follows the project naming standards.

Overview of changes

Post-review checklist
As I merge these changes, I have:

[ ] Updated the related Jira ticket, including approximate time spent (including review).
[ ] Moved the related Jira ticket to Done.

@mat-may sorry about this, but the yes/no/null options are used here because participants are able to leave the questionnaire null/incomplete at any stage
We want the dummy data to reflect all of the options we could see in the real data from the questionnaire spec, rather than base it on responses we've had so far


Done=False on agent death in collecthealth

https://github.com/maximecb/gym-miniworld/blob/77083a1efb838389819479e43542b9bc5453d37e/gym_miniworld/envs/collecthealth.py#L72
done=True must be set here to start new episode.

I was thinking that the agent could just keep training continuously in an endless episode. That way there isn't the overhead of regenerating the environment when the episode ends. Do you find that this is a problem?

Ok. I will make the episode end when the agent dies, and probably after some very large number of steps, eg: 1000.

Done.


Crash on startup with Mystcraft (not sure)

Last version crashes on sturtup in my modpack. I'm not quite sure if the problem is caused by mystcraft or not, but the crash report mentions this mod
crash-2024-05-13_12.54.02-client.txt

Fixed with version 1.12.2-1.1.5


fix: windows bump WindowsTargetPlatformMinVersion

In RNW .72, we bump WinUI from 2.7 to 2.8 which targets a higher TargetPlatformMinVersion. This PR bumps the WindowsTargetPlatformMinVersion to the correct version for RNW .72

@nicholaslee119 Would you mind looking at this PR when you have the chance? It's will block any app from using checkbox in a react-native-windows .72 app. thanks!

@TatianaKapos Thanks for the PR, I will check it ASAP

Thanks, 0.5.16 was released


Azure DevOps created a service account with cluster-admin role for a RBAC-enabled cluster

Created a new AKS cluster in the Azure portal
Enabled RBAC
Selected the new AKS cluster and namespace in the Azure DevOps "Add Kubernetes Resource" inside an Environment
Used kubectl to examine what Azure DevOps did
Verified Azure DevOps created a service account with cluster-admin role for a RBAC-enabled cluster

New service account:
kubectl get serviceaccount --namespace test
NAME              SECRETS   AGE
azdev-sa-403636   1         37m

New RoleBinding:
kubectl get rolebinding --namespace test -o json
            "roleRef": {
                "apiGroup": "rbac.authorization.k8s.io",
                "kind": "ClusterRole",
                "name": "cluster-admin"
            },
            "subjects": [
                {
                    "kind": "ServiceAccount",
                    "name": "azdev-sa-403636",
                    "namespace": "test"
                }

According to the documentation, the service account should be least-privileged:

For an RBAC enabled cluster, RoleBinding is created as well to limit the scope of the created service account to the chosen namespace. For an RBAC disabled cluster, the ServiceAccount created has cluster-wide privileges (across namespaces).

Either the documentation needs to be updated to say For an RBAC enabled cluster, the ServiceAccount created has a cluster-admin role or the DevOps bug needs to be corrected.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 7730ae4d-4101-9c83-1823-4ff43ff161ce
Version Independent ID: 20a7e263-4819-783e-c984-c4f3b459e22f
Content: Environment - Kubernetes resource - Azure Pipelines
Content Source: docs/pipelines/process/environments-kubernetes.md
Product: devops
Technology: devops-cicd-process
GitHub Login: @juliakm
Microsoft Alias: jukullam

https://developercommunity.visualstudio.com/content/problem/1076806/azure-devops-created-a-service-account-with-cluste.html

@GeorgeTsiokos we are taking a glimse on CSS Azure DevOps support, we are going to analyze the data

Azure DevOps Support #:<PHONE_NUMBER>01404
Would be great if the documentation included the service account RBAC permissions required in the namespace for Azure DevOps Kubernetes environments.

This article was updated last month to make permissions clearer.


There is no possibility to "Claim" G$ on QA env.

There is no possibility to "Claim" G$ on QA env.
Preconditions:

the user is logged in
the main page is open

Steps to reproduced:

Click on the "Claim" button
Observe the result

Actual result:
The error popup is shown
Expected result:
The user is able to "Claim" G$/Pass the FV
Environment:
QA 1.30.1-14
Devices:
Windows 10 // Google Chrome v92
Attachments:
Video - https://www.screencast.com/t/VU510GmvyJF3
Popup - https://www.screencast.com/t/2MlGpud8vv
MasterSeed - b7e95255985cfb462d2784861cf7b4cb15e3ee4a754e83b6ae33494cbbe79743
WalletAddress - 0x28E74dBb696a6423CdE6a0Bdf7Dd3fCE42D4fb39
Note: This issue reproduced on every account, but anyway i added info about the current account

@vldkh please actualize this

@johnsmith-gooddollar
Still reproducing

@sirpy @johnsmith-gooddollar
The issue is not reproduced


Support bit-level initialization tracking.

I think that this should proceed as follows:

Update shadow memory tracking to be allocation-based rather than the old fragment-based system (recreated memory was updated way back in 97b8557fca6edaaa967b0528e3a69ca36774c8a8).
Implement methods to retrieve/set the shadow state of memory that can be used by instrumented code and interceptors.
Update the instrumentation to propagate uninitialized bits through instructions.

In the long term, it would be nice to have a large block of shadow memory so that determining the location of the shadow memory for any particular byte was a simple operation (a la Memcheck, MemorySanitizer, etc.)

This issue was moved to seec-team/seec#16


Implement audioplayer

Use third party component: https://www.npmjs.com/package/react-spotify-playback-player. Use through importing and adding <AudioPlayer/>, doesn't auto-play though.
Also adds useTrack in spotifySource.js, which should play a track by uri but needs to be tested more.
Closes #24 and closes #7.

oopsie did not look great, had to revert

Remember to npm install but yes App.js needs to add import to redirectPresenter.js.


How to use jest?

According to jest documentation, jest is for Javascript. To use it with TypeScript requires the installation of Babel.
Why is jest included here, and is there any instruction on how to use it?

Jest works fine with TypeScript, see the bottom of that page you linked to 👍

Though if you look inside the [jest settings for this repo](https://github.com/microsoft/TypeScript-Node-Starter/blob/master/jest.config.js#L1 - it uses ts-jest which doesn't require babel


operator postgresql (5.3.0)

Signed-off-by: Ben Blattberg<EMAIL_ADDRESS>Thanks for submitting your Operator. Please check the below list before you create your Pull Request.
New Submissions

[ ] Are you familiar with our contribution guidelines?
[ ] Have you packaged and deployed your Operator for Operator Framework?

[ ] Have you tested your Operator in all supported installation modes?
[ ] Have you considered whether you want to use semantic versioning order?
[ ] Is your submission signed?
[ ] Is operator icon set?

Updates to existing Operators

[x] Did you create a ci.yaml file according to the update instructions?
[x] Is your new CSV pointing to the previous version with the replaces property if you chose replaces-mode via the updateGraph property in ci.yaml?
[x] Is your new CSV referenced in the appropriate channel defined in the package.yaml or annotations.yaml ?
[x] Have you tested an update to your Operator when deployed via OLM?
[x] Is your submission signed?

Your submission should not

[x] Modify more than one operator
[x] Modify an Operator you don't own
[x] Rename an operator - please remove and add with a different name instead
[x] Modify any files outside the above mentioned folders
[x] Contain more than one commit. Please squash your commits.

Operator Description must contain (in order)

[x] Description of the managed Application and where to find more information
[x] Features and capabilities of your Operator and how to use it
[x] Any manual steps about potential pre-requisites for using your Operator

Operator Metadata should contain

[x] Human readable name and 1-liner description about your Operator
[x] Valid category name1
[x] One of the pre-defined capability levels2
[x] Links to the maintainer, source code and documentation
[x] Example templates for all Custom Resource Definitions intended to be used
[x] A quadratic logo

Remember that you can preview your CSV here.
--
1 If you feel your Operator does not fit any of the pre-defined categories, file an issue against this repo and explain your need
2 For more information see here

/merge possible

/merge possible

/retest

/test 4.8-deploy-operator-on-openshift

/test 4.8-deploy-operator-on-openshift

/test 4.8-deploy-operator-on-openshift

/retest

/merge possible

| /test 4.8-deploy-operator-on-openshift
-- | --

/test 4.8-deploy-operator-on-openshift

/test 4.8-deploy-operator-on-openshift

@benjaminjb are you able to start your operator on ocp v4.8?

@benjaminjb are you able to start your operator on ocp v4.8?

@mvalarh good question, we did some experimentation and have discovered the problem seems to be with the size of our bundle and the extract command being used in 4.8.
That is, it seems like this commit is active in v4.9+; and we verified through installing in an ocp v4.9 that the install job's pod's command has the -z flag set, so the bundle is being gzipped; but in 4.8, without that gzip, the bundle is too big for the limit set in the extract command.
(Just to double-check, we installed on a 4.8 cluster without problem through kustomize, so it's really that 4.8 non-gzipped bundle that's causing the problem here.)

@benjaminjb are you able to start your operator on ocp v4.8?

@mvalarh good question, we did some experimentation and have discovered the problem seems to be with the size of our bundle and the extract command being used in 4.8.
That is, it seems like this commit is active in v4.9+; and we verified through installing in an ocp v4.9 that the install job's pod's command has the -z flag set, so the bundle is being gzipped; but in 4.8, without that gzip, the bundle is too big for the limit set in the extract command.
(Just to double-check, we installed on a 4.8 cluster without problem through kustomize, so it's really that 4.8 non-gzipped bundle that's causing the problem here.)

@benjaminjb then you could change com.redhat.openshift.versions: 'v4.8' to com.redhat.openshift.versions: v4.9 in annotations.yaml. Thank you.

Updated to 4.9, holding off until we can fix the certified-operators merge.

/merge possible

/merge possible


Update installation Instructions in README.md

It was added in https://github.com/Homebrew/homebrew-cask/pull/95487. I will keep an eye on this app & update it if you have a new release.

Here is only a doc change to the Readme.md you already added I think (that change is not by me).

Here is only a doc change to the Readme.md you already added I think (that change is not by me).

I don't see anywhere mentioning Homebrew in README.md?

Hi @singularitti ,
Sorry it has taken me so long to respond. Thanks for your interest in the project.
A while ago, I tried running your Homebrew command locally, and it failed because Aural Player was already installed. I didn't investigate the matter any further.
What is the correct way to upgrade Aural Player using your Homebrew command ?
Also, please note that I'm a total noob when it comes to Homebrew, so I don't know if there is some setup that I haven't performed yet, although I would imagine that no setup should be required (for app users). I do have Homebrew installed, of course.
Please clarify the correct way to use your command, and I will try to incorporate your changes into the project.
BTW, I really appreciate your interest in the project and your work on this. And sorry again.
Regards,
maculateConception


Datasets Train: and Test: not Loading in Step 3

After I configure a linux server, install all the libraries, download the mode from the model zoo, and then run the command under "Step 3: For testing our model, download the best pretrained model weights from the Model Zoo" in the Readme.
I always get a KeyError: "Dataset 'pub_val' is not registered! ...
This is the same if you use PubLayNet or DocLayNet.  All of the available datasets are for image instance segmentation for objects not document content.
Available datasets are: coco_2014_train, coco_2014_val, coco_2014_minival, coco_2014_valminusminival, coco_2017_train, coco_2017_val, coco_2017_test, coco_2017_test-dev, coco_2017_val_100, keypoints_coco_2014_train, keypoints_coco_2014_val, keypoints_coco_2014_minival, keypoints_coco_2014_valminusminival, keypoints_coco_2017_train, keypoints_coco_2017_val, keypoints_coco_2017_val_100, coco_2017_train_panoptic_separated, coco_2017_train_panoptic_stuffonly, coco_2017_train_panoptic, coco_2017_val_panoptic_separated, coco_2017_val_panoptic_stuffonly, coco_2017_val_panoptic, coco_2017_val_100_panoptic_separated, coco_2017_val_100_panoptic_stuffonly, coco_2017_val_100_panoptic, lvis_v1_train, lvis_v1_val, lvis_v1_test_dev, lvis_v1_test_challenge, lvis_v0.5_train, lvis_v0.5_val, lvis_v0.5_val_rand_100, lvis_v0.5_test, lvis_v0.5_train_cocofied, lvis_v0.5_val_cocofied, cityscapes_fine_instance_seg_train, cityscapes_fine_sem_seg_train, cityscapes_fine_instance_seg_val, cityscapes_fine_sem_seg_val, cityscapes_fine_instance_seg_test, cityscapes_fine_sem_seg_test, cityscapes_fine_panoptic_train, cityscapes_fine_panoptic_val, voc_2007_trainval, voc_2007_train, voc_2007_val, voc_2007_test, voc_2012_trainval, voc_2012_train, voc_2012_val, ade20k_sem_seg_train, ade20k_sem_seg_val, ade20k_full_sem_seg_train, ade20k_full_sem_seg_val, ade20k_panoptic_train, ade20k_panoptic_val, coco_2017_train_stuff_10k_sem_seg, coco_2017_test_stuff_10k_sem_seg, mapillary_vistas_sem_seg_train, mapillary_vistas_sem_seg_val, coco_2017_train_panoptic_with_sem_seg, coco_2017_val_panoptic_with_sem_seg, ade20k_instance_train, ade20k_instance_val, mapillary_vistas_panoptic_train, mapillary_vistas_panoptic_val, prima_train, prima_val"

Detectron2 doesn't have the instance segmentation datasets for doclay or publay.
Below is the error that always comes up.  How do we get the right datasets for train and test?
Traceback (most recent call last):
  File "/home/ubuntu/.pyenv/versions/3.10.12/lib/python3.10/site-packages/detectron2/data/catalog.py", line 51, in get
    f = self[name]
  File "/home/ubuntu/.pyenv/versions/3.10.12/lib/python3.10/collections/__init__.py", line 1106, in __getitem__
    raise KeyError(key)
KeyError: 'pub_val'

The above exception was the direct cause of the following exception:

Traceback (most recent call last):
  File "/home/ubuntu/git/doc_segmenter/./train_net.py", line 392, in <module>
    launch(
  File "/home/ubuntu/.pyenv/versions/3.10.12/lib/python3.10/site-packages/detectron2/engine/launch.py", line 84, in launch
    main_func(*args)
  File "/home/ubuntu/git/doc_segmenter/./train_net.py", line 367, in main
    res = Trainer.test(cfg, model)
  File "/home/ubuntu/.pyenv/versions/3.10.12/lib/python3.10/site-packages/detectron2/engine/defaults.py", line 604, in test
    data_loader = cls.build_test_loader(cfg, dataset_name)
  File "/home/ubuntu/.pyenv/versions/3.10.12/lib/python3.10/site-packages/detectron2/engine/defaults.py", line 560, in build_test_loader
    return build_detection_test_loader(cfg, dataset_name)
  File "/home/ubuntu/.pyenv/versions/3.10.12/lib/python3.10/site-packages/detectron2/config/config.py", line 207, in wrapped
    explicit_args = _get_args_from_config(from_config, *args, **kwargs)
  File "/home/ubuntu/.pyenv/versions/3.10.12/lib/python3.10/site-packages/detectron2/config/config.py", line 245, in _get_args_from_config
    ret = from_config_func(*args, **kwargs)
  File "/home/ubuntu/.pyenv/versions/3.10.12/lib/python3.10/site-packages/detectron2/data/build.py", line 562, in _test_loader_from_config
    dataset = get_detection_dataset_dicts(
  File "/home/ubuntu/.pyenv/versions/3.10.12/lib/python3.10/site-packages/detectron2/data/build.py", line 253, in get_detection_dataset_dicts
    dataset_dicts = [DatasetCatalog.get(dataset_name) for dataset_name in names]
  File "/home/ubuntu/.pyenv/versions/3.10.12/lib/python3.10/site-packages/detectron2/data/build.py", line 253, in <listcomp>
    dataset_dicts = [DatasetCatalog.get(dataset_name) for dataset_name in names]
  File "/home/ubuntu/.pyenv/versions/3.10.12/lib/python3.10/site-packages/detectron2/data/catalog.py", line 53, in get
    raise KeyError(
KeyError: "Dataset 'pub_val' is not registered! Available datasets are: coco_2014_train, coco_2014_val, coco_2014_minival, coco_2014_valminusminival, coco_2017_train, coco_2017_val, coco_2017_test, coco_2017_test-dev, coco_2017_val_100, keypoints_coco_2014_train, keypoints_coco_2014_val, keypoints_coco_2014_minival, keypoints_coco_2014_valminusminival, keypoints_coco_2017_train, keypoints_coco_2017_val, keypoints_coco_2017_val_100, coco_2017_train_panoptic_separated, coco_2017_train_panoptic_stuffonly, coco_2017_train_panoptic, coco_2017_val_panoptic_separated, coco_2017_val_panoptic_stuffonly, coco_2017_val_panoptic, coco_2017_val_100_panoptic_separated, coco_2017_val_100_panoptic_stuffonly, coco_2017_val_100_panoptic, lvis_v1_train, lvis_v1_val, lvis_v1_test_dev, lvis_v1_test_challenge, lvis_v0.5_train, lvis_v0.5_val, lvis_v0.5_val_rand_100, lvis_v0.5_test, lvis_v0.5_train_cocofied, lvis_v0.5_val_cocofied, cityscapes_fine_instance_seg_train, cityscapes_fine_sem_seg_train, cityscapes_fine_instance_seg_val, cityscapes_fine_sem_seg_val, cityscapes_fine_instance_seg_test, cityscapes_fine_sem_seg_test, cityscapes_fine_panoptic_train, cityscapes_fine_panoptic_val, voc_2007_trainval, voc_2007_train, voc_2007_val, voc_2007_test, voc_2012_trainval, voc_2012_train, voc_2012_val, ade20k_sem_seg_train, ade20k_sem_seg_val, ade20k_full_sem_seg_train, ade20k_full_sem_seg_val, ade20k_panoptic_train, ade20k_panoptic_val, coco_2017_train_stuff_10k_sem_seg, coco_2017_test_stuff_10k_sem_seg, mapillary_vistas_sem_seg_train, mapillary_vistas_sem_seg_val, coco_2017_train_panoptic_with_sem_seg, coco_2017_val_panoptic_with_sem_seg, ade20k_instance_train, ade20k_instance_val, mapillary_vistas_panoptic_train, mapillary_vistas_panoptic_val, prima_train, prima_val"

Check line no. 350 and 351 of train_net.py
Change prima_train/prima_val with your desired dataset name.
got to the config file you are using.
and put the following
DATASETS:
TRAIN: ("put the same training dataset name you are using in train_net.py",)
TEST: ("put the same validation dataset name you are using in train_net.py",)

Thansk I'll try that out.

Thanks again @ayanban011. It worked so I am closing the issue if that is ok.


Loosen version requirements for all dependencies

Closes #104
There is no need for them to be so strict, I wasn't that familier with how to set this up when I did it. The only one that is important is langcodes, but i believe it is still in the correct range.

I read it as the opposite. If you look below, setting it to 0.18 allows all version from 0.18.0 to 0.999999.999999. The one you suggests is how it is now, it only allows 0.18.1 to 0.18.99999999999 to be installed.

On the poetry dependency specification page it is written: Caret requirements allow SemVer compatible updates to a specified version. An update is allowed if the new version number does not modify the left-most non-zero digit in the major, minor, patch grouping.
With ^0.18 the left-most non-zero digit (18) may not be modified by the update. So updating to 0.19 is not allowed.
The >= that I suggested is in my opinion working across all the major, minor, patch grouping. Thus 2.3.4 >= 1.4.5 and 1.20.3 >= 0.26.4 and thus also 0.19.0 >= 0.18.1.

Right now it is >=0.18.1and that is causing him issues, so clearly that does not work.
The left most none zero digit is still 18 when setting it to 0.18.1 instead of what I suggest 0.18. I am no expert at all at this and will look closer into this in coming weekend 😊

One additional remark: At this moment it is '^0.18.1' which is something else than '>=0.18.1'

Right, the last comment you posted, made me understand what i was missing. Thanks reviewing, learned something new today :)
Please review my latest changes

Thanks!! :heart:

I can confirm that the dependencies for poetry are now working correctly.
During an update to mytoyota 0.7.5, by using pip, I got:
Requirement already satisfied: httpx>=0.18.1 in /usr/local/lib/python.....
Requirement already satisfied: arrow<2.0,>=1.1 in /usr/local/lib/python.....
Requirement already satisfied: langcodes<4.0,>=3.1 in /usr/local/lib/python.....

The dependency on httpx is now thus >= 0.18.1, and also httpx 0.19 is now allowed to fulfill the requirement.

Awesome, Home Assistant just pushed there's to 0.21 a couple of days ago, so really glad we got this fixed. 😄

Ok. I updated my installation also. It is running on httpx version 0.21.1 now, and seems to be running ok.


V8 performance degradation ~20%

Issue tracker is used for reporting bugs and discussing new features. Please use
stackoverflow for supporting issues.

Expected Behavior
Similar performance comparing to V7.

Current Behavior
~20 degradation.

Context (Environment)
Simple app that reads from Redis Cluster and returns result via REST. Original version with V7.4.0, and new version with V8.6.0, everything else are the same except changes to accommodate the new API. context.Background is used. The test was done on Linux, Redis 5.0.7.

Please provide some program that reproduces the problem.

Here is a sample app. The only difference is one uses V7 (7.4.0) and the other uses V8 (8.6.0).
redis7.go.gz
redis8.go.gz

Further testing shows V8 (8.0.0) is almost on par with V7 (7.4.0). However, 8.1.0 and 8.6.0 shows ~20 degradation.

@jfjm2018
HI~, based on the information you provided, I did a simple test.
redis version: Redis server v=6.1.242 sha=00000000:0 malloc=jemalloc-5.1.0 bits=64 build=572ba9acdb92d890
redis-server: <IP_ADDRESS>: 6379
redis-cluster:
master: <IP_ADDRESS>:1001, <IP_ADDRESS>:1002, <IP_ADDRESS>:1003
slave: <IP_ADDRESS>:2001, <IP_ADDRESS>:2002, <IP_ADDRESS>:2003
<IP_ADDRESS>:1001> cluster nodes
4baf31a244dd8cb0fdeccebc5bf65875228787cf <IP_ADDRESS>:1003@11003 master - 0<PHONE_NUMBER>485 3 connected 10000-16383
04401cd0e1ab632825bbb29ecdf41856b2320650 <IP_ADDRESS>:1001@11001 myself,master - 0<PHONE_NUMBER>000 1 connected 0-4999
886c44065fc2862889b803ae3f3b64b27a2e9f4f <IP_ADDRESS>:2003@12003 slave 4baf31a244dd8cb0fdeccebc5bf65875228787cf 0<PHONE_NUMBER>000 3 connected
56dee0d5a57b3e77fdc417b8b3b927f82a078a87 <IP_ADDRESS>:2001@12001 slave 04401cd0e1ab632825bbb29ecdf41856b2320650 0<PHONE_NUMBER>458 1 connected
4888357cec2b19de4ce8be45409bcd31f8b35339 <IP_ADDRESS>:1002@11002 master - 0<PHONE_NUMBER>468 2 connected 5000-9999
88978ac9fb8441e225f51d5639aa5bf91b909a10 <IP_ADDRESS>:2002@12002 slave 4888357cec2b19de4ce8be45409bcd31f8b35339 0<PHONE_NUMBER>435 2 connected

This is the Redis.Client test result: https://github.com/monkey92t/tool/blob/master/Redis-Client-V7-V8.pdf
This is the RedisCluster test result: https://github.com/monkey92t/tool/blob/master/RedisCluster-Client V7-V8.pdf
This is the test program: https://github.com/monkey92t/tool/blob/master/main.go
according to the results of this test, I found that there is not much evidence to prove that there is a problem with v8 efficiency, and the network request itself is unstable.
If you have a better test, you can reopen an issue.


Structure.xml should be rendered equal to phpDocumentor2's output

Because the parser / transformer backend changed we need to re-implement several bit; this includes the rendering of the structure.xml.
As such we need to add a new Render Action that will generate an XML representation of the parsed project equal to the structure that was used in phpDocumentor 2. This will enable us to re-use the XSLT based templates without discrepencies between phpDocumentor 2 and 3. In addition: some users use this file to extract the information that phpDocumentor has parsed.

Closing the 3.0 tickets, will reconsider them after our re-alignment


New version: Atom v0.11.2

Registering package: Atom
Repository: https://github.com/JunoLab/Atom.jl
Created by: @pfitzseb
Version: v0.11.2
Commit: 438ae4608fd84f5437fdc7e1303926b706ed3ef9
Reviewed by: @pfitzseb
Reference: https://github.com/JunoLab/Atom.jl/commit/438ae4608fd84f5437fdc7e1303926b706ed3ef9#commitcomment-35589275

Your new version pull request does not meet all of the guidelines for automatic merging.
Specifically, your pull request does not meet the following guidelines:

I was not able to install and import the package. See the Travis logs for details.

It is important to note that if your pull request does not meet the guidelines for automatic merging, this does not mean that your pull request will never be merged. It just means that your pull request will require manual review by a human.

These guidelines are intended not as requirements for packages but as very conservative guidelines, which, if your new package or new version of a package meets them, it may be automatically merged.

On a separate note, I see that you are registering a release with a version number of the form v0.X.Y.
Does your package have a stable public API? If so, then it's time for you to register version v1.0.0 of your package. (This is not a requirement. It's just a recommendation.)
If your package does not yet have a stable public API, then of course you are not yet ready to release version v1.0.0.

[noblock]

Your new version pull request met all of the guidelines for automatic merging.
I will automatically merge this pull request during the next cron job.
If you want to prevent this pull request from being auto-merged, simply leave a comment.
(If you want to post a comment without blocking auto-merging, you must include the text [noblock] in your comment.)

On a separate note, I see that you are registering a release with a version number of the form v0.X.Y.
Does your package have a stable public API? If so, then it's time for you to register version v1.0.0 of your package. (This is not a requirement. It's just a recommendation.)
If your package does not yet have a stable public API, then of course you are not yet ready to release version v1.0.0.

[noblock]


Publish as package on pypi

We want to use this package in our device tests. To remain consistent with the way we use python-mnemonic in the tests we would need this package published on pypi.

v0.1.0 tagged and released


Add UI Router

Instead of calling ghost_ci.refresh_repos() directly, just call like ghost_ci.navigate_to(window.hash) or whatever and let it figure out what to display

This was delivered in f573275ec647106657246763c2317184574b45a0


switch to mstmp

fix #2231

@frennkie pls edit the title… is there more to be done from your point of view?

Merged to be part of v1.71RC2 ... please test with RC2 if you need any further patches to be included in RC3 or final.


Prefetch limits

This PR brings two separate features from branch htex_strategy:

Support for specifying a prefetch_capacity that limits the # of tasks that can be fetched over the available worker capacity on the managers.
Support for identifying managers with block_ids, and identification via a registration message to the interchange.

Note from @ZhuozhaoLi, default prefetch should be zero

#881 and #888 cover all the changes in this PR. Closing.


@universal/ng-aspnetcore-engine usage in boot.server.ts

Hello-
Any reason why boot.server.ts. doesn't use @universal/ng-aspnetcore-engine?
// Temporary * the engine will be on npm soon (@universal/ng-aspnetcore-engine)
I see it is installed in package.json.
The documentation says to reference this app:
https://www.npmjs.com/package/@nguniversal/aspnetcore-engine
I assume just lack of time and/or nobody PR'd it.   But wanted to double check if it is stable.
Thanks

It'll be adding in the upcoming 5.0 release (as it's waiting to be merged in there, there were many updates for 5.0)
5.0 PR here:
#437
Universal aspnetcore-engine PR here:
https://github.com/angular/universal/pull/825


Frost Protection not working

I have an Apollo 9000 split unit labeled "Andersen Electric". It appears to be a straight relabeled Midea unit, and everything works - except the Away mode does not trigger the Frost Protection mode.
I can enable FP from the IR remote.
Selecting e.g Drying mode from the integration takes the unit out of FP. Changing to Heat mode works, but selecting Away mode only result in a "bip" from the unit and nothing else.
Wondering how I can add more substance to this issue - and also if it really just is something not intended to work with the present function set in the integration?

Hi.
The away/freeze protection mode has been tested successfully by a few other users. However it wouldn't be the first time a device has only had a function available via the remote.
A. If you enable FP mode via the remote, does HA switch to the "Away" preset?
B. Does the OEM app provide an option for FP mode? Or is it only on the remote?

Hi, thanks,
A. when I use the 'away' preset, it is not really working, in that it revert to 'none' after a few seconds
the debug log records this string:
2024-10-30 20:00:49.095 WARNING (MainThread) [msmart.device.AC.device] Device is not capable of property <PropertyId.IECO: 227>.
B. The OEM app does no provide an option for the FP mode. Enabling it only via the IR remote.

Additionally,
A. changing the device to FP on the IR remote has no effect on the preset value - it is always 'none'

2024-10-30 20:00:49.095 WARNING (MainThread) [msmart.device.AC.device] Device is not capable of property <PropertyId.IECO: 227>.

This is irrelevant to your issue although I'm not sure why it appeared.
Can you post the full debug log after restarting HA?

B. The OEM app does no provide an option for the FP mode. Enabling it only via the IR remote.
A. changing the device to FP on the IR remote has no effect on the preset value - it is always 'none'

Most likely this means the device doesn't expose the FP control and there's nothing we can do.

Closing as stale.


changed e-mail field character limit

Motivation and Context
The e-mail field in the action exporter schema needed to be changed from 50 to 200 in order to accommodate longer e-mails.
What has changed

The emailaddress field in action exporter_foundation_schema.sql was changed from allowing a maximum of 50 characters to a maximum of 200.

A line was added into ActionRequestBuilder.java to make sure that the tests don't break from having a long e-mail address inserted onto them.

How to test?
Build the service and make sure everything works.
Links
Trello card

The travis build is failing due to a linting error.  This needs fixing before this gets merged in.


Update conda.store domain to point to Netlify docs

Reference docs: https://docs.netlify.com/domains-https/custom-domains/configure-external-dns/#configure-an-apex-domain

Done! Thanks, @costrouc and @trallard!


Add repo download button to complaints and feedbacks

Checklist

[x] I tested all changes and all related features with different users (student, tutor, instructor, admin) on the test server https://artemistest.ase.in.tum.de.
[x] Client: I added multiple screenshots/screencasts of my UI changes

Motivation and Context

Tutors are currently not able to view the repository of complaints they have to assess.
Description

I added our download button component to the feedback and complaint rows in the tutor dashboard. That way, tutors can now take a look at the student's code before evaluating the complaint.
Steps for Testing

Log in to Artemis
Create a programming exercise with manual reviews
Assess a solution and complain about it, or request more feedback
As the tutor, next to the feedback/complain assessment button, there should be a download button for the repository

Screenshots

I moved the download button to the manual assessment dialog modal. There also is a link to the repository itself in case the download doesn't work (e.g. in the case @maxr96 described).
We should also be more careful when creating button components, as the default type of a button is "submit" resulting in a submit of every form in which the button is contained. In this case, our jhi-button inside the download repos button inside the manual assessment modal caused a submit when downloading the repository, which results in a save of the feedback/complaint! This is fixed now, as we have an additional option shouldSubmit for our button component


Most of the Swift source now built into the Swift compiler does not have a cross-compilation CMake configuration

Motivation
The Swift source in SwiftCompilerSources/ has long supported cross-compilation, added by @eeckstein in #40068 for Darwin a couple years ago and then in #40277 for non-Darwin Unix by me. However, the recently added Swift source in lib/{ASTGen,Macros}/ and tools/swift-plugin-server/ does not support cross-compilation, and the new swift-syntax parser never has. Before we start requiring the swift-syntax parser to build the Swift compiler, we better get it cross-compiling, as cross-compilation will be the only way to get the Swift compiler running on new platforms after that.
Proposed solution
I cross-compile the Swift compiler for Android AArch64 from a linux x86_64 host, and these are the three changes I had to make to get all this Swift source in the compiler itself cross-compiled:

Add cross-compilation flags for Android to _add_host_swift_compile_options(), which is used to build lib/{ASTGen,Macros}/ and tools/swift-plugin-server/. This should be easy to generalize like SwiftCompilerSources/ does.
Do the same in the swift-syntax repo with add_swift_syntax_library(): this may take more work to generalize because of the cross-repo CMake config.
Cross-compiling swift-plugin-server with add_pure_swift_host_tool() and 1. doesn't work, so I hacked it to use the old add_swift_host_tool() instead. I forget the precise error but it had to do with its swiftLLVMJSON dependency in turn linking a C++ library, swiftBasic, so the tool wasn't actually pure Swift. That works fine when natively compiling, but not when cross-compiling.

I can probably implement 1. easily for non-Darwin Unix, but I'm looking for input from @rintaro and @bnbarham on how we should properly fix the other two, plus I don't use Darwin or Windows so others will have to get cross-compilation working again there.

I asked directly on the forum what the plan is and was told that a switch to using CMake's built-in Swift support is planned, so I will hold off on my changes building on the existing cross-compilation support and see what ends up rolling out with that new effort first.


Fix invalid JSON in Azure Batch example.

Correct name found in https://learn.microsoft.com/en-us/azure/virtual-machines/extensions/key-vault-windows?tabs=version3

@Padmalathas
IMPORTANT: When the changes are ready for publication, add a #sign-off comment to signal that the PR is ready for the review team to merge.
#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team


⚡ Various guidance updates

@kfollis
Can you review the proposed changes?
When the changes are ready for publication, add a #sign-off comment to signal that the PR is ready for the review team to merge.
#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

@davidiseminger - please review this submission and help us get the PR into the reviewers queue

#sign-off


Showcase demo apps in Ensemble Go (iOS) and Ensemble Preview (Android)

Added the following for each demo app

description field:  to demo apps so we can show that for people to know what capabilities an app is demonstrating. This should be displayed as a subtitle in the listitem
demoOrder: which order to show the demo apps in the list of demo apps

@amin-nas we need to showcase the demo apps better. Our Ensemble Go and Preview look really bad. Perhaps we should use a tile view so at least the apps we produce have nice images. Also need to put a progress state, right now there is no loading sign when it is loading the list of demo apps.

@tibrahulz description and demoOrder are both optional fields. Make sure to check for null before using them


Fail to create an object

When I was trying to create an object, I got this error:
UnmappedClassError: Class 'sqlalchemy.sql.sqltypes.Integer' is not mapped
What should I do to fix it?
Thank you!

saved me a ton of time guys thanks!

@lorey solved my problem,
i was using db.relationship in both models.
thanks mate!


Using Github roadmaps for project tracking

As a new contributor, I want to be able to easily determine what are the goals of the project, what is the long-term direction of the project, and what is actively being worked on.
To solve the first two, I propose we more heavily utilize the roadmap feature on Github to track goals for cosign, fulcio and rekor. We should also schedule periodic triaging of open tickets.
Context: New contributor friction log

I would be supportive of using github milestones for release planning. Are there any communities around that have a decent process we could replicate?

The new github projects tool is still in beta but it's much much much better than the old one. It's still missing a few pieces around automation to really make it work. This is a struggle for every project I've seen.

Nothing to do at the org level, closing this out


Add missing license identifier

This fixes #72 and adds missing license headers.
It also adds Fabric's license check to the
make checks target.
Signed-off-by: Marcus Brandenburger<EMAIL_ADDRESS>

Yes, I guess there are also some missing Intel copyrights already; can you do a pass and add a commit here or reuse mine and also sign-off?! Let's not over complicate it. @bvavala Can you do this?

Nice check.
Agreed, let's not over complicate. We'll update the header as we touch the files.


Build docker images error

Hello,
The command 'docker-compose build' gives the following error:
Step 1/56 : FROM ubuntu:16.04
ERROR: Service 'cvat' failed to build: The command '/bin/sh -c python3 -m pip install --no-cache-dir -r /tmp/requirements/${DJANGO_CONFIGURATION}.txt' returned a non-zero code: 2
How can I resolve this?   thank you

run follwing command and agian build docker-compose
docker system prune
docker stop $(docker ps -a -q)
docker rm $(docker ps -a -q)

@PavneshYadav123 This doesn't solve the issue for me.

@PavneshYadav123 This doesn't solve the issue.

@linmengnan , please provide the full command which you used to build CVAT. Also need full logs. Which git branch did you use (develop or master)?

develop is used
cvat admin$ docker-compose build
........
Downloading https://files.pythonhosted.org/packages/d3/d0/ef75c788627f4218a8d08dccdf4ebc91f5b83c48d09ec8f2a3db9610014b/Django-2.2.8-py3-none-any.whl (7.5MB)
ERROR: Exception:
Traceback (most recent call last):
File "/usr/local/lib/python3.5/dist-packages/pip/_vendor/urllib3/response.py", line 425, in _error_catcher
yield
File "/usr/local/lib/python3.5/dist-packages/pip/_vendor/urllib3/response.py", line 507, in read
data = self._fp.read(amt) if not fp_closed else b""
File "/usr/lib/python3.5/http/client.py", line 458, in read
n = self.readinto(b)
File "/usr/lib/python3.5/http/client.py", line 498, in readinto
n = self.fp.readinto(b)
File "/usr/lib/python3.5/socket.py", line 575, in readinto
return self._sock.recv_into(b)
File "/usr/lib/python3.5/ssl.py", line 929, in recv_into
return self.read(nbytes, buffer)
File "/usr/lib/python3.5/ssl.py", line 791, in read
return self._sslobj.read(len, buffer)
File "/usr/lib/python3.5/ssl.py", line 575, in read
v = self._sslobj.read(len, buffer)
socket.timeout: The read operation timed out
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "/usr/local/lib/python3.5/dist-packages/pip/_internal/cli/base_command.py", line 153, in _main
status = self.run(options, args)
File "/usr/local/lib/python3.5/dist-packages/pip/_internal/commands/install.py", line 382, in run
resolver.resolve(requirement_set)
File "/usr/local/lib/python3.5/dist-packages/pip/_internal/legacy_resolve.py", line 201, in resolve
self._resolve_one(requirement_set, req)
File "/usr/local/lib/python3.5/dist-packages/pip/_internal/legacy_resolve.py", line 365, in _resolve_one
abstract_dist = self._get_abstract_dist_for(req_to_install)
File "/usr/local/lib/python3.5/dist-packages/pip/_internal/legacy_resolve.py", line 313, in _get_abstract_dist_for
req, self.session, self.finder, self.require_hashes
File "/usr/local/lib/python3.5/dist-packages/pip/_internal/operations/prepare.py", line 194, in prepare_linked_requirement
progress_bar=self.progress_bar
File "/usr/local/lib/python3.5/dist-packages/pip/_internal/download.py", line 465, in unpack_url
progress_bar=progress_bar
File "/usr/local/lib/python3.5/dist-packages/pip/_internal/download.py", line 316, in unpack_http_url
progress_bar)
File "/usr/local/lib/python3.5/dist-packages/pip/_internal/download.py", line 551, in _download_http_url
_download_url(resp, link, content_file, hashes, progress_bar)
File "/usr/local/lib/python3.5/dist-packages/pip/_internal/download.py", line 253, in _download_url
hashes.check_against_chunks(downloaded_chunks)
File "/usr/local/lib/python3.5/dist-packages/pip/_internal/utils/hashes.py", line 80, in check_against_chunks
for chunk in chunks:
File "/usr/local/lib/python3.5/dist-packages/pip/_internal/download.py", line 223, in written_chunks
for chunk in chunks:
File "/usr/local/lib/python3.5/dist-packages/pip/_internal/utils/ui.py", line 160, in iter
for x in it:
File "/usr/local/lib/python3.5/dist-packages/pip/_internal/download.py", line 212, in resp_read
decode_content=False):
File "/usr/local/lib/python3.5/dist-packages/pip/_vendor/urllib3/response.py", line 564, in stream
data = self.read(amt=amt, decode_content=decode_content)
File "/usr/local/lib/python3.5/dist-packages/pip/_vendor/urllib3/response.py", line 529, in read
raise IncompleteRead(self._fp_bytes_read, self.length_remaining)
File "/usr/lib/python3.5/contextlib.py", line 77, in exit
self.gen.throw(type, value, traceback)
File "/usr/local/lib/python3.5/dist-packages/pip/_vendor/urllib3/response.py", line 430, in _error_catcher
raise ReadTimeoutError(self._pool, None, "Read timed out.")
pip._vendor.urllib3.exceptions.ReadTimeoutError: HTTPSConnectionPool(host='files.pythonhosted.org', port=443): Read timed out.
ERROR: Service 'cvat' failed to build: The command '/bin/sh -c python3 -m pip
@nmanovic  thank you!

@linmengnan , do you have a proxy? Logs clear says that data cannot be fetched from files.pythonhosted.org. Usually it means that you have some problems with your network.

@linmengnan , I will close the issue. Please don't hesitate to re-open it if you have more information for us to investigate the issue.


qdrant integration for vector based similar resources endpoint

What are the relevant tickets?
Closes https://github.com/mitodl/hq/issues/5865
Description (What does it do?)
This PR introduces the following

a new endpoint to show similar resources using vector embeddings via QDrant
a "generate_embeddings" management command to embed learning resources and contentfiles

How can this be tested?

Checkout this branch
You will need to rebuild your images to install dependencies. (docker compose down docker compose build )
load up learning resources via management command
run the embedding management command ./manage.py generate_embeddings --all --skip-content-files (skip contentfiles for now - more on this in the additional context section)
once embeddings have been generated, visit the qdrant dashboard and see that the resources are populated.
find a course id and visit the new similar resources endpoint http://open.odl.local:8063/api/v1/learning_resources/<<resource_id>>/vector_similar/ and validate the results

Additional Context

The results do not currently look at contentfiles (just learning resources). Contentfiles are also stored in a separate collection (unlike in opensearch where they sit with the index of the associated learning resource). Once this goes out and we see this works get a sense of performance, it should be easy to follow up with the addition of contentfile data . Either keep it in a separate collection and make the relation to its parent resource in code or embed learning resources with contentfile vectors in a single collection.
The "generate_embeddings" management command is currently not baked into the celery crontab - Once this is deployed and manually validated, I'll follow up with a pr that adds this into the celery schedule.
Contentfiles (atleast locally) take a long time but i dont think much longer than opensearch indexing.
I was running into some uwsgi exception locally which appears to be resolved by setting the harakiri timeout in uwsgi.ini. Not sure if we expect this to happen when deployed but we can set it there if we need do.

@mbertrand this is ready for another look.
I followed the "increase throughput" section from qdrants performance guide and I got it to index 8148 resources in 702 seconds by reducing the number of segments to just 2.

@mbertrand I'm going to try something locally and see if I can resolve that issue (which I think could happen once deployed as well) - I think it might be due to the segment size optimization but I will have to confirm.

@mbertrand I had modified the code to use a hybrid search approach as opposed to the default which is to use fast-embed (requires far less resources). Using fast embed is probably the right thing for now. After reverting to fast embed indexing ~8k resources took only 248 seconds and the results loaded much faster too (without the gateway errors)


Failover SearchPathCompositeEnvironmentRepository when git repository is not found

Is your feature request related to a problem? Please describe.
I have a use case that I need to support multiples git backends. I found that it is possible to use Composite Repository but I realized after some tests that if a repository is not present in one of the git backends the request to configserver will throw an exception "RepositoryNotFound".
Describe the solution you'd like
It would be amazing if we have the option to choose whether the request to configserver would fail or return empty for the specific git backend keeping the response from the others git backend.
Describe alternatives you've considered
I considered implementing a new Repository that inherits from SearchPathCompositeEnvironmentRepository that catch the exception and ignore it.
Something like:
@Slf4j
public class ResilientCompositeEnvironmentRepository extends SearchPathCompositeEnvironmentRepository
{
    public ResilientCompositeEnvironmentRepository(List<EnvironmentRepository> environmentRepositories)
    {
        super(environmentRepositories);
    }

    @Override
    public Environment findOne(String application, String profile, String label, boolean includeOrigin)
    {
        Environment env = new Environment(application, new String[] {profile}, label, null, null);
        for (EnvironmentRepository repo : environmentRepositories)
        {
            try
            {
                env.addAll(repo.findOne(application, profile, label, includeOrigin).getPropertySources());
            }
            catch (Exception e)
            {
                log.warn("Could not find repo", e);
            }
        }
        return env;
    }
}

But the problem is that the SearchPathCompositeEnvironmentRepository bean created at EnvironmentRepositoryConfiguration is a Primary bean and I'm not able to easily override it.
Thanks

I found that there. is flag failOnError in the newest version. I will update my spring-cloud version.


remove degenerate _scans.tsv files?

reading bids specification https://bids-specification.readthedocs.io/en/stable/common-principles.html#compulsory-optional-and-additional-data-and-metadata
It is RECOMMENDED that non-compulsory metadata fields (like `notch` in `channels.tsv` files)
and/or files (like `events.tsv`) are fully omitted *when they are unavailable or unapplicable*,
instead of specified with an `n/a` value, or included as an empty file
(for example an empty `events.tsv` file with only the headers included).

it is just RECOMMENDED so we do not really have to do that ;)

@yarikoptic
That's interesting. Thanks for the heads up.
Do you think this is realistic though? We're getting BIDS warnings for missing _scans.tsv files.
FAQ. Why would a complete _bold but 'n/a' filled _scans.tsv be a valid case?
Not every analysis requires a _scans.tsv metadata. We had a discussion with other data users - Given that some are interested in naturalistic paradigms and hyperalignment, these analyses are not contingent on scans.tsv files. Users were in favor of more data, rather than deleting bold due to a degenerate scans.tsv


Please mark as unofficial

Hello! Great work on this plugin, over at Semgrep we're planning to release an officially supported version of an IntelliJ plugin (see here). Feel free to keep this one up, but it'd be very much appreciated if you labeled this as unofficial in the plugin title and description.

Marked description as unofficial and linked to official.

Thanks!


Global AVR parameters not shown on zone 1

After we refactored the parser in the latest update, a number of responses no longer have an associated zone which stops HA from picking up a large number of global attributes unless a zone specific attribute is updated (such as volume).
Raising this issue more as a note. @crowbarz I'm tempted to just add a check into _parse_response for aiopioneer and add zone 1 to updated_zones if the parser response zone was null. What do you think?

I was thinking yesterday that there is a need for Zones.All or Zones.None to cover commands for attributes that are independent of zones. That could also be used in the parser table and trigger an update in the HA component for wherever it decides these attributes should go. In the interim maybe we can add None to  updated_zones and have the HA integration decide what to update. (I haven't looked at the code to see how updated_zones is processed.

I think a Zones.All would be good, I'll do some work in aiopioneer to add that in.

In #35 I've added HA DataCoordinators for each zone to trigger zone entity refreshes via a callback from aiopioneer. The HA media_player entity attaches to that, as do the new zone related property entities (sensors, binary_sensors, etc.) There's also now a DataCoordinator for Zones.ALL that global entities attach to, which triggers a refresh when any global properties are updated. This works for global attribute groups such as the tuner, audio parameters and video parameters, so I think the original issue will be resolved on the next release.
Interestingly, HA attributes that have dict values (eg. the audio and video attributes that were formerly on the media_player entity) don't seem to be refreshed properly on the Developer Tools > States UI, so perhaps that isn't a great way to expose structured data.

This is resolved with the 0.9.0 release


ERROR  Cannot start nuxt:  Cannot find any-observable implementation

Environment

Operating System: Linux
Node Version:     v16.15.0
Nuxt Version:     2.15.8
Package Manager<EMAIL_ADDRESS>Builder:          webpack
User Config:      rootDir, env, bridge, telemetry, nitro, head, publicRuntimeConfig, css, plugins, components, buildModules, vuetify, i18n, modules, compilerOptions, build, watchers, ssr
Runtime Modules:  -
Build Modules<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>

Reproduction
Unfortunately I do not know how to reproduce.
The error does not occur locally but does occurs on the server (both nodejs v16.15.0).
Describe the bug
When running npx nuxi dev (I cannot use nuxi build because of #27 ) I get the error:
 ERROR  Cannot start nuxt:  Cannot find any-observable implementation nor global.Observable. You must install polyfill or call require("any-observable/register") with your preferred implementation, e.g. require("any-observable/register")('rxjs') on application load prior to any require("any-observable").

  at loadImplementation (node_modules/any-observable/register.js:29:9)
  at node_modules/any-observable/loader.js:30:18
  at Object.<anonymous> (node_modules/any-observable/index.js:2:39)
  at Module._compile (node:internal/modules/cjs/loader:1105:14)
  at Object.Module._extensions..js (node:internal/modules/cjs/loader:1159:10)
  at Module.load (node:internal/modules/cjs/loader:981:32)
  at Function.Module._load (node:internal/modules/cjs/loader:822:12)
  at Module.require (node:internal/modules/cjs/loader:1005:19)
  at require (node:internal/modules/cjs/helpers:102:18)
  at Object.<anonymous> (node_modules/@samverschueren/stream-to-observable/index.js:2:20)
  at Module._compile (node:internal/modules/cjs/loader:1105:14)
  at Object.Module._extensions..js (node:internal/modules/cjs/loader:1159:10)
  at Module.load (node:internal/modules/cjs/loader:981:32)
  at Function.Module._load (node:internal/modules/cjs/loader:822:12)
  at Module.require (node:internal/modules/cjs/loader:1005:19)
  at require (node:internal/modules/cjs/helpers:102:18)

So both "dev" and "build" fail and I cannot use anything on the server.
Additional context
npm why any-observable

<EMAIL_ADDRESS>dev
node_modules/any-observable
<EMAIL_ADDRESS>from<EMAIL_ADDRESS>  node_modules/@samverschueren/stream-to-observable
<EMAIL_ADDRESS>from<EMAIL_ADDRESS>    node_modules/listr
      peer<EMAIL_ADDRESS>from<EMAIL_ADDRESS>      node_modules/listr-update-renderer
<EMAIL_ADDRESS>from<EMAIL_ADDRESS><EMAIL_ADDRESS>from<EMAIL_ADDRESS>      node_modules/nitropack
<EMAIL_ADDRESS>from<EMAIL_ADDRESS>        node_modules/@nuxt/bridge
          dev @nuxt/bridge@"npm<EMAIL_ADDRESS>from the root project

Logs
No response

Solved :-)
It seems that this had to so with Cypress and not Nuxt.
The error started after issuing "npm remove cypress".
I had to TOTALLY remove cypress (also from package-lock.json and deleting node_modules) to solve this.


Clarify iOS keyboard support

https://appt.org/en/docs/ios/features/keyboard-access
The keyboard support for iOS states within the Overview section it is limited to iPad, but is Overview the only section where support is limited to iPad, or is the entire keyboard experience from this page currently limited to iPad?
If the former, please consider adding a sentence at the beginning of the page saying it applies to both iPhone and iPad unless otherwise noted. If the latter, please move the sentence about applying to iPad only, out from the nesting in the Overview section into the first section so that it is clear where the iPad-only content is.
I seem to be experiencing limited functionality for iPhone with my (Windows) external Bluetooth keyboard so I'm not sure if it's user error or actually limited in its expected behavior. I do not have an iPad to compare. The Reference link for iPhone to connect to Bluetooth is helpful but incomplete. Perhaps include https://support.apple.com/guide/iphone/adjust-keyboard-settings-ipha7c3927eb/17.0/ios/17.0 which shares keyboard shortcuts for Magic Keyboard. Since it's not clear on the Apple page whether the same expectations apply to other Bluetooth keyboards I was looking for answers on appt.org.

Hi @jamieherrera thanks for raising this issue. One of the differences between iOS and iPadOS is the lack of support for showing Keyboard shortcuts using the Command key. When I have a bit more time, I will clarify this and also look at expanding documentation for keyboard shortcuts.

Hi @jamieherrera , I added clarification about difference on iPad vs iPhone/iPod in the first paragraph. Also added your link with Apple guidance to the list of external resources.


Add Frontend unit test coverage

At the minute we have good coverage on our back end code but very poor coverage on our front end.
Please feel free to implement some unit tests for the front end code where you see fit

Hi @jhanna60,
I would like to work on this.

@zeaus assigned now thanks

Hello, @zeaus are working on this?

Hi @jvmazagao ,
I created a pull request and it got merged. I added some basic test cases here is a screenshot of the test coverage report.
The test coverage can further be improved though might need some code refactoring.

I can take a look at this coverage, and the unit tests.

Sure, it's yours

can we change the testing library to react testing library?


Cannot use textarea as subwidget_form

Django better admin ArrayField version: 1.4.2
Django version: 3.2.13
Python version: 3.7.13
Operating System: Mac OS 12.3.1

Description
I want to pass a custom subwidget_form to DynamicArrayWidget.  Specifically, I want to use forms.TextAreainstead of forms.TextInput:
class MyModelAdmin(...):
    ...
    form = modelform_factory(
        ...
        widgets =  {
            "my_field_name": DynamicArrayWidget(subwidget_form=forms.Textarea),
        }
     )

When I do this, clicking on the "Add another" button throws a JS error:
django_better_admin_arrayfield.min.js:1 Uncaught TypeError: Cannot read properties of null (reading 'getAttribute')
    at HTMLInputElement.<anonymous> (django_better_admin_arrayfield.min.js:1:474)
(anonymous) @ django_better_admin_arrayfield.min.js:1

...because of this line:
https://github.com/gradam/django-better-admin-arrayfield/blob/master/django_better_admin_arrayfield/static/js/django_better_admin_arrayfield.js#L29
...because the querySelector is specifically looking for an input (not a textarea).

Same error here.


[client] Use table dialogs for all multi-valued selections

Currently, remembered tokens are managed by cycling through displays each of which have a single token and its nickname.  In contrast, remembered setups are managed with a table dialog from which you select an entry.   There is no good reason why these interactions should be so totally different.   Actually, the same goes for playing deck selection, box "kind" selection and perhaps others.   When there are more than two possibilities, cycling through options in an arbitrary order in not a good idea.   The intermediate steps are reflected to the state of the game, which can be disruptive.    We should use table dialogs everywhere for this type of selection.   The two-valued case (true toggle) can still work as before.

The new PlayingDeckDialog and BoxKindDialog are now used for selection of playing decks and box kinds, respectively.  The harder conversion is for remembered tokens, where the initiating dialog needs to be changed more deeply to get a pleasing result.   Tentative plan follows.

The current token displays as either <token> or <token>(<nickname>).    The nickname is only present if the token was found in the saved tokens via the nickname.
New token button allows a token value (not nickname) to be entered.  It will then replace the current token.
Save button allows an optional nickname to be added; if none is added the token is saved without one.   Nicknames have to be unique (locally).
There is a "use saved" button.   It selection dialog displays nicknames if present, otherwise tokens.

Otherwise, to the extent feasible the look and feel of this dialog and the RestoreSetupDialog should be similar.

I have done a large revision to make the player setup dialog simpler and to use a table selection when retrieving tokens.  That should resolve the issue assuming there are no new bugs introduced (which I will find out presently).


Added Document360Reader. Contributed by the PLACE team.

Description
The Document360Reader class is a custom reader developed by the PLACE team that interacts with the Document360 API to fetch articles.
It processes articles recursively and allows further handling via custom callback functions, while also handling rate limiting and errors.
Fixes # (issue)
New Package?
Did I fill in the tool.llamahub section in the pyproject.toml and provide a detailed README.md for my new integration or package?

[x] Yes
[ ] No

Version Bump?
Did I bump the version in the pyproject.toml file of the package I am updating? (Except for the llama-index-core package)

[ ] Yes
[x] No

(It's a new package)
Type of Change
Please delete options that are not relevant.

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

[x] Added new unit/integration tests
[ ] Added new notebook (that tests end-to-end)
[x] I stared at the code and made sure it makes sense

Suggested Checklist:

[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] I have added Google Colab support for the newly added notebooks.
[x] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes
[x] I ran make format; make lint to appease the lint gods

Thanks for the suggestions @logan-markewich!
Updated the MR and tested locally. Everything works fine.

I'll fix a few things in a followup related to CICD, I can't push to your PR branch


Friend query is directional, fails to find Alice and the restaurants that she likes.

Friend query is directional, fails to find Alice and the restaurants that she likes.  So the query "Find Restaurants that John's friends like" completely ignores Alice, who is a friend of John's, as defined by the friendOf.

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 84c44dc1-637b-22b0-35db-0668d741818d
Version Independent ID: 5425118c-d998-df3e-89ee-29656a8aa07c
Content: SQL Graph Database Sample - SQL Server
Content Source: docs/relational-databases/graphs/sql-graph-sample.md
Product: sql
Technology: ****
GitHub Login: @MikeRayMSFT
Microsoft Alias: mikeray

@thecatt -- thank you for your feedback.  Please consider these resources:

SQL Server on Microsoft Q&A
DBA Stack Exchange
Stack Overflow

@MikeRayMSFT -- please look into this issue.

Reviewing. Will get back to you.

Yes, SQL graph implements a directional graph and hence traversals done via. MATCH are also strictly directional. I can see how this sample might create confusion as it depicts a one-way friendship. In order to represent a mutual friendship between John and Alice in this sample graph, an additional friendOf edge would have to be created from John to Alice:
INSERT INTO friendOf
VALUES ((SELECT $NODE_ID FROM Person WHERE ID = 1), (SELECT $NODE_ID FROM Person WHERE ID = 3))

For the future, we can re-examine the choice of the friendOf edge if it is causing confusion.

#please-close


UCP123: Support to show markdown content in the cluster diagnosis report

Thanks! Could you post a screenshot for the result?

@all-contributors please add @qxhy123   for code


Add helios-solo (formerly named helios-standalone)

This includes two things:

Building the helios-solo Docker image as part of the helios-services build.

Building a helios-solo Debian package, which contains helios-up and other
scripts for launching and using helios-solo.

:+1: :bear: :elephant:

s/:bear:/:beer:

:+1:


[KARAF-5940] Fix maven-install-plugin version to 2.5.2 to avoid artifact attaching issue

retest this please

retest this please

retest this please


pixysOS 12L test

for garden, bruh.

Unfortunately failed to flash (not on my device, but I give to to someone to test it)
also closing, maybe i will figure it out to solve installation issue


chore: Update dependencies

Some maintenance updates:

Update http-content-range: Add a new error variant
Update itertools, tower-http and rstest: No code change
Update async-zip: Wants a tokio buf reader now, so we create one with capacity 0 to avoid extra requests.
Add Cargo.lock to git: See changed guidance in https://blog.rust-lang.org/2023/08/29/committing-lockfiles.html
Update to 0.8.1 for releasing the dependency updates

Thanks! Much appreciated


Usage cleanup & select statement fix

minor changes to ensure the pass only runs on selected modules, clarify usage in help statement, and handle argument parsing according to the same pattern as other yosys passes

Fair point on the alumacc pass. I missed that.
But on that topic, 2 questions:

Philosophically speaking, should this plugin only run alumacc specifically on the adders it will optimize itself (i.e: the ones marked with the pptrees flag)?

I noticed in your line of code syntax that I did not know existed. Is there some syntax that can make these two lines better?

My intuition is yes; I think if the user set attributes on parts of the code, the expectation should be that it only touches those parts. Maybe add a flag to use a set of default transforms on any adders that don't have attributes set? I can see the utility of a general adder optimization pass.

Maybe something like:
RTLIL::Selection s(false); s.select(mod, cell); pass::call_on_selection(design, s, stringf("techmap -map %s/pptrees_alu.v %%", pptrees_dir.c_str()));
Haven't tested that yet though.

Maybe we can also borrow some cycles from @Ravenslofty and have him critique the code.

them.


Unfortunate line splitting behaviour

-        let cx = tp1.x + any * radius * if anticlockwise { 1.0 } else { -1.0 };
-        let cy = tp1.y - anx * radius * if anticlockwise { 1.0 } else { -1.0 };
+        let cx = tp1.x +
+                 any * radius *
+                 if anticlockwise {
+            1.0
+        } else {
+            -1.0
+        };
+        let cy = tp1.y -
+                 anx * radius *
+                 if anticlockwise {
+            1.0
+        } else {
+            -1.0
+        };

There is the single_line_if_else config bool, which could help here. Otherwise, how should we format this?

I guess it's not clear to me why we end up with any * radius on one line and other things with one item per line? The formatting of the if/else blocks probably makes this look worse than it ordinarily would, too.

It's an oddity of the heuristic we're using. We're formatting the expression in the order that they are laid out in the AST. Addition has the lowest precedence, so that's why we see a weird split there. It needs tweaking.

Also the indentation of the if block is pretty sad.

Closed by #1017


Support for ImageMagick >= 7

Build fails when ImageMagick 7.0.2 is present during compilation . I could fix the failure by changing the path to MagickWand/MagickWand.h when the following error showed up -
../blockhash.c:14:10: fatal error: 'wand/MagickWand.h' file not found
#include <wand/MagickWand.h>

Complete build logs - https://gist.github.com/02477d5bcbbbf2b4697991d18cd48add
Could you please add support for ImageMagick 7.0.x?

@jonasob @artfwo ping on this. The issue looks like it's only the location of the header, but otherwise it builds.

Hi and thanks for the heads up! It looks like the majority of Linux distros are still relying on the version 6 of ImageMagick. We can probably support both versions 6 and 7 though. For the record, here's the version 7 porting guide: https://www.imagemagick.org/script/porting.php

@artfwo here's what I did so that we could avoid "boneyarding" blockhash: https://github.com/Homebrew/homebrew-core/blob/master/Formula/blockhash.rb#L25-L28

Yeah, that will work. But I think the issue is best solved by adding a configure option or auto-detecting version 7 during configure step and choosing the header via a compile-time flag.

@artfwo right. That is just a stop-gap for brew, not an actual solution.

@artfwo thanks! Could I sweet talk you into tagging a new release? :innocent:

@ilovezfs already done :)

Neat. Thanks. Running our test block for HEAD, I see
==> /usr/local/Cellar/blockhash/HEAD-cc2c8be_2/bin/blockhash /tmp/blockhash-test-20170113-83389-5ecol5/clipper_ship.jpg
Error: blockhash: failed
Expected /00007ffe7ffe7ffe7ffe7ffe7ffe77fe77fe600e7f5e00000000000000000000/ to match "00007ff07fe07fe07fe67ff07520600077fe601e7f5e000079fd40410001fffe  /tmp/blockhash-test-20170113-83389-5ecol5/clipper_ship.jpg\n".

Is that expected that the end would have changed like that since 0.1?

The test has been
  test do
    resource("testdata").stage testpath
    hash = "00007ffe7ffe7ffe7ffe7ffe7ffe77fe77fe600e7f5e00000000000000000000"
    # Exit status is not meaningful, so use pipe_output instead of shell_output
    # for now
    # https://github.com/commonsmachinery/blockhash/pull/9
    result = pipe_output("#{bin}/blockhash #{testpath}/clipper_ship.jpg", nil, nil)
    assert_match hash, result
  end

@ilovezfs the algorithm has been updated for improved accurary, so yeah, this is expected.

Cool. I'll update the hash then!

Voilà: https://github.com/Homebrew/homebrew-core/pull/8815.

Awesome, thanks!


XLSX cache improvements

#196 introduced a cache of the EmbeddedXlTables extracted from XLSX files to work around openpyxl's slow reading of certain Excel files. There are some ways it can be improved:

[ ] "It might be worth trying caching with parquet files instead of pickles in future, they're usually lightning fast to read/write compared to pickles (although 0.8s is probably fast enough for me :) ), and the file sizes are much smaller. The downside is that you'd have to save one file per table though." (Perhaps we could wrap all tables from a file in a class?)
[ ] "Another potential issue is that the .cache/ dir gets created inside the xl2times module (i.e. beside xl2times/init.py). This seems (to me) a bit unusual. Would it be better to create it in the users' home dir (eg. pathlib.Path.home() / '.xl2times/cache)? That seems to be where most apps create their caches now - at least I seem to have lots of caches there."
[ ] Enforce a maximum cache size by evicting oldest items?
[ ] Also check file modification time to be ultra sure there are no hash collisions?

@SamRWest you're right, I wasn't sure where to put the cache directory. I'm also used to caches living in ~/.cache/ but then I wasn't sure how that translated to Windows.

I'm also used to caches living in ~/.cache/ but then I wasn't sure how that translated to Windows.
This has been standard on Windows for a while now too, which is handy.  ~ ends up being c:\Users\<username> and pathlib.Path.home() is a cross-platform equivalent to ~.

Also check file modification time to be ultra sure there are no hash collisions?
If the file has been modified but the contents (and thus its content-only hash) hasn't changed, so this is probably unnecessary. The chance of an accidental collision of the file contents is infinitesimal.

Re: parquet - your pickle mechanism is actually very fast, and now I've used it for a bit, the cache is small enough that I doubt this will really become a problem, as long as we clean up old files at some point.

@siddharth-krishna is this still relevant?

Yes, it's low priority, but we could still at some point move the cache to the home directory and evict old items. Let me know if this is something I can tackle in the upcoming period.


⚠ Bofrost.lu has degraded performance

In 9a1dd5f, Bofrost.lu (https://www.bofrost.lu) experienced degraded performance:

HTTP code: 200
Response time: 1336 ms

Resolved: Bofrost.lu performance has improved in 058c260 after 6 minutes.


Docu outdated?

Hi,
I'm just learning rust and how to use that image crate, not everything is obvious.
Trying just a simple
let mut imgbuf = image::ImageBuffer::new(512,512);
as described in section 4.2.1 of the README.md runs into
error[E0284]: type annotations required: cannot resolve <_ as image::Pixel>::Subpixel == _
(using rustc 1.17.0 and cargo 0.18.0)
Seems as if the docu is somewhat outdated and the api has changed since, and I guess that it requires two type arguments as generics, but I don't currently see what exactly to pass.
Please update the examples.
regards

Check out https://github.com/PistonDevelopers/image/issues/494


Refactor usage of the ContractHash and Key types in preparation for Uref work

We've identified some places in the code that were using the Key type where it was statically known that the key would always be a ContractHash which made it annoyingly difficult to prototype changes for the upcoming Uref work. This PR substitutes the types in several places. This change also made us realise that there was some unreachable code in the project, particularly in RuntimeContext::remove_key and Account::extract_access_rights. The dead code was removed.
Related to: https://app.zenhub.com/workspaces/engineering-l1-60953fafb1945f0011a3592d/issues/gh/casper-network/roadmap/143

bors r+


MSO-specific UI guidance

Update the monitoring doc with MSO-specific UI guidance
Update the Connect to your cluster with a Monitoring section. Might have to rework the doc a bit).

@Amruta-Ranade, is this still in scope for 19.2, or should we push it to later?

This project's priority keeps moving -- we deprioritized this project in favor of the "Build an app" project, but customer feedback seems to suggest that I need to pick this up soon-ish. Can we keep this for 19.2 and revisit it in a few days?

Sure.


Broken doc link for 3 ways to mitigate risk when using private packag

Below link is not working here: https://learn.microsoft.com/en-us/nuget/concepts/security-best-practices#nuget-feeds
I believe it should point here: https://azure.microsoft.com/mediahandler/files/resourcefiles/3-ways-to-mitigate-risk-using-private-package-feeds/3 Ways to Mitigate Risk When Using Private Package Feeds - v1.0.pdf

Dup of https://github.com/NuGet/docs.microsoft.com-nuget/issues/3186.


Define which type of API to choose

Case study to select a type of API to implement: REST, GraphQL, Grpc, ...

REST seems the obvious choice, as the amount of data to send is not much (wich would be a reason to choose GraphQL) and gRPC & Webhooks are not usefull in a client/server relationship involving javascript UI.


Create the function to get the latest register inserted

Definition
Create a new function associated to the Repository[T any] struct to get the latest register inserted in the table. This function must have the signature above.
func (r *Repository[T]) GetLatest() (*T, error)

Is very important understand that the function will act as a generic way and the database can user the default ID generated by GORM or a custom ID that can have any data type.
Acceptation Criteria

[x] 1. The function must get the latest element from database table;
[ ] 2. The unity tests must be developed;
[ ] 3. The test coverture to this function must be 100%.

The function have 100% of coverage