Should ADC API have more explicit error messages?

Currently we have 200 and 500 as http responses. There are a number of error messages that one might expect from the ADC API based on the spec, such as a "Timeout" when the server gives up because the query is to complex or a "Too much data" error when the user asks for more data at a time than the server can provide. I suspect there might be others...

Sounds good, I suppose some codes are immediately appropriate like "408" for timeout.  Can you propose which ones that should be added?

Sounds good, I suppose some codes are immediately appropriate like "408" for timeout.  Can you propose which ones that should be added?

Moving this to ADC API v2.0 as the question is still relevant.

@schristley I suggest we add some docs to the limits section, and add the following error messages that should be returned when limits are not adhered to:

408 when a server time out has expired https://developer.mozilla.org/en-US/docs/Web/HTTP/Status/408
413 when max_size or max_query_size are exceeded - https://developer.mozilla.org/en-US/docs/Web/HTTP/Status/413

I think we should suggest that other codes are returned as deemed appropriate - obvious I suppose, but worth stating.

@schristley I suggest we add some docs to the limits section, and add the following error messages that should be returned when limits are not adhered to:

Yes, I agree but let's also put them in the API spec as responses.

408 when a server time out has expired https://developer.mozilla.org/en-US/docs/Web/HTTP/Status/408

VDJServer should be returning this already.

413 when max_size or max_query_size are exceeded - https://developer.mozilla.org/en-US/docs/Web/HTTP/Status/413

Not sure if VDJServer returns this, I think it returns generic 400 for query error but I'm good with using a more specific error code.

Added some docs:
https://github.com/airr-community/airr-standards/pull/752/commits/ab2b8ce470fcfe72840236ab58f35dd746058a68
Updated the specs:
https://github.com/airr-community/airr-standards/pull/752/commits/f88b357286a90287325a362360cc63831b0b60a2
https://github.com/airr-community/airr-standards/pull/752/commits/65e7ab2abc3f5c015d61693ba857e9c7b21f8b80
I think we can close this.


Please add sasl.username and sasl.password

We have our kafka cluster secured and requires sasl user and pass. Please allow this to be configured via the Kafka engine syntax.

@daledude, look at this pull request, will it help you?

@Amper, thanks for the pointer but I don't see anything related to SASL PLAIN or I missed something?

@daledude, section "Configuration":

@Amper Thank you! I missed the crucial "see ... for list of other options" so I didn't realize I could use any of the librdkafka options.


Restore MAX macro

MAX macro had been deleted from shader.cpp in the latest commit, and without it the code can't be compiled

are you using this project?

i've started following materials for your course recently https://tamats.com/learn/realtime-graphics/ :)
currently at the illumination slides and videos

Thank you for sharing it!

oh, great then :)


Docs: Elaborate on complex dependencies

Hi! I'm looking at this section in the docs: https://helm.sh/docs/charts_tips_and_tricks/#complex-charts-with-many-dependencies
I'm very curious about this type of setup, especially the Deis Workflow example, where the "umbrella chart is built from each component, and each component is tracked in a different Git repository".
The Docs say to "Check out the requirements.yaml file to see how this chart is composed by their CI/CD pipeline."
Unfortunately, it seems that the Deis workflow is no longer maintained, and their CI pipeline is no longer active. So I'm not really sure what I'm looking at in their requirements.yaml, namely where the <*-tag> values are coming from.
I would love to see a little bit more detail in the Helm docs in this section to explain the design pattern that Deis workflow exemplifies.
Thanks a lot!
Oliver

@bacongobbler Deis workflows!

Hi, @OliverEvans96 - Apologies for the delayed reply. Much has changed in Helm 3, and you may find that the info in https://helm.sh/docs/topics/library_charts/ and https://helm.sh/docs/chart_template_guide/subcharts_and_globals/ is relevant to your question. Please let us know if you have further questions; thanks!


Added package_name parameter.

That will enable user to install non default package name like
logstash-all-plugins.

sudo puppet apply -e "package{'logstash': ensure => present, provider => rpm, source=> 'http://ord-repo-001.ludia.me/misc/logstash-all-plugins-2.4.0.noarch.rpm',}"
I'll get that error:
Error: Execution of '/usr/bin/rpm -i http://ord-repo-001.ludia.me/misc/logstash-all-plugins-2.4.0.noarch.rpm' returned 1: package logstash-all-plugins-1:2.4.0-1.noarch is already installed
Error: /Stage[main]/Main/Package[logstash]/ensure: change from absent to present failed: Execution of '/usr/bin/rpm -i http://ord-repo-001.ludia.me/misc/logstash-all-plugins-2.4.0.noarch.rpm' returned 1: package logstash-all-plugins-1:2.4.0-1.noarch is already installed
It is happening, because puppet is checking for 'logstash' rpm and as it is not installed, will try to install logstash-all-plugins-2.4.0.noarch.rpm (but it is already installed.
My solution will include the parameter 'name' from logstash::package_name and:

sudo puppet apply -e "package{'logstash': name => 'logstash-all-plugins', provider => rpm, source=> 'http://ord-repo-001.ludia.me/misc/logstash-all-plugins-2.4.0.noarch.rpm',}"
Notice: Compiled catalog for test.foo.me in environment production in 0.53 seconds
Notice: Finished catalog run in 0.78 seconds

Hi @cropalato, we have found your signature in our records, but it seems like you have signed with a different e-mail than the one used in yout Git commit. Can you please add both of these e-mails into your Github profile (they can be hidden), so we can match your e-mails to your Github profile?

Hi @karmi, I just added the other email in my profile.

Hey guys, something is not correct with your ci script.

 Or something is not correct with the CI environment, at least. With the current combination of Travis, Beaker, and Docker, the run times for the tests are non-deterministic in a massive way. Check out the spread of run times for the build:
https://travis-ci.org/elastic/puppet-logstash/builds/170170382
Sometimes, they run so long that Travis times them out. When that happens, I can trigger a rebuild for the timed out jobs. That's what I did for this patch and now it passes (thank you!)
This is one of the reasons that I'm now planning to migrate the CI tests to Elastic's CI infrastructure, where I have more control over the environment, and can also substitute Virtualbox for Docker, which will make the init system tests much more realistic.


New file does not have any grammar checking

Create a new file
Type random strings
There is no highlighting for strings that aren't words.
Save and close the program
Reopen the file
Highlighting appears from now on.

It was defaulting to a 'none' grammar for new files. Now the default is the 'text' grammar.


feat(web): update header with the new logo

https://pins-ds.atlassian.net/browse/APPLICS-1107
Update header with the new logo
-adjust header padding to follow branding guidelines

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Documentation update
[ ] Other (please explain in the description section above)

Checklist before requesting a review

[ ] I have performed a self-review of my own code
[ ] I have double checked this work does not include any hardcoded secrets or passwords
[ ] I have made corresponding changes to the documentation
[ ] I have provided details on how I have tested my code
[ ] I have referenced the ticket number above
[ ] I have provided a description of the ticket
[ ] I have included unit tests to cover any testable code changes

:tada: This PR is included in version 2.33.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:

:tada: This PR is included in version 2.41.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


TypeError: isDynamicRoute is not a function

Describe the bug
When trying to build my next.js site on Netlify, I will get the following error:
10:25:24 PM: ────────────────────────────────────────────────────────────────
10:25:24 PM:   Plugin "@netlify/plugin-nextjs" internal error
10:25:24 PM: ────────────────────────────────────────────────────────────────
10:25:24 PM:
10:25:24 PM:   Error message
10:25:24 PM:   TypeError: isDynamicRoute is not a function
10:25:24 PM:
10:25:24 PM:   Plugin details
10:25:24 PM:   Package:        @netlify/plugin-nextjs
10:25:24 PM:   Version:        3.2.1
10:25:24 PM:   Repository:     git+https://github.com/netlify/netlify-plugin-nextjs.git
10:25:24 PM:   npm link:       https://www.npmjs.com/package/@netlify/plugin-nextjs
10:25:24 PM:   Report issues:  https://github.com/netlify/netlify-plugin-nextjs/issues
10:25:24 PM:
10:25:24 PM:   Error location
10:25:24 PM:   In "onBuild" event in "@netlify/plugin-nextjs" from Netlify app
10:25:24 PM:       at /opt/build/repo/.netlify/plugins/node_modules/@netlify/plugin-nextjs/src/lib/pages/withoutProps/redirects.js:30:10
10:25:24 PM:       at async asyncForEach (/opt/build/repo/.netlify/plugins/node_modules/@netlify/plugin-nextjs/src/lib/helpers/asyncForEach.js:3:5)
10:25:24 PM:       at async getRedirects (/opt/build/repo/.netlify/plugins/node_modules/@netlify/plugin-nextjs/src/lib/pages/withoutProps/redirects.js:24:3)
10:25:24 PM:       at async setupRedirects (/opt/build/repo/.netlify/plugins/node_modules/@netlify/plugin-nextjs/src/lib/steps/setupRedirects.js:41:9)
10:25:24 PM:       at async build (/opt/build/repo/.netlify/plugins/node_modules/@netlify/plugin-nextjs/src/index.js:31:3)
10:25:24 PM:       at async nextOnNetlify (/opt/build/repo/.netlify/plugins/node_modules/@netlify/plugin-nextjs/src/index.js:75:5)
10:25:24 PM:       at async onBuild (/opt/build/repo/.netlify/plugins/node_modules/@netlify/plugin-nextjs/index.js:67:5)
10:25:24 PM:       at async Object.run (/opt/buildhome/.netlify-build-nvm/versions/node/v12.16.3/lib/node_modules/@netlify/build/src/plugins/child/run.js:18:3)
10:25:24 PM:       at async handleEvent (/opt/buildhome/.netlify-build-nvm/versions/node/v12.16.3/lib/node_modules/@netlify/build/src/plugins/child/main.js:36:38)
10:25:24 PM:       at async process.<anonymous> (/opt/buildhome/.netlify-build-nvm/versions/node/v12.16.3/lib/node_modules/@netlify/build/src/plugins/ipc.js:103:16)

Four days ago it built correctly but then it was using<EMAIL_ADDRESS>so maybe it's related to the plugin version.
Expected behavior
The site should build correctly.
Versions

Next.js: 10.0.9

Same error here

+1 same here, my site was building fine only a couple of hours ago. I only made minor changes to CSS and now get this build error. My build works fine locally.

+1 same error for me. Was working when I last built it around 12 hours ago. Latest changes was for some minor text.

Same issue. Last successful build at 19:48 GMT, last one failed at 22:05 (now)

+1 same here

+1 and i didnt even change any code tbh

Same here

Same for me

I'm also experiencing this.
I have this plugin installed via package.json in version 3.2.0 so I wonder why the netlify ci is using 3.2.1.
I thought adding a plugin to package.json was the way to control the version.
Is there any advice about how to roll back a netlify plugin?

oh my GOODNESS. FRIENDS. i was on a call. hi i'm releasing this fix now. fyi for future: advice on rolling back is to lock it to the last working version (you can check our releases).

OKAY 3.2.2 should be out now. please let me know if you continue to have issues! apologies for the delay and thanks so much for your patience ❤ . i'll also add a note in the README about how to manually "roll back" in the event of the plugin breaking.

https://github.com/netlify/netlify-plugin-nextjs#faq !

https://github.com/netlify/netlify-plugin-nextjs#faq !

Thanks @lindsaylevine . Actually I think my version was not pinned because I had it as a dev dependency. I moved it to non-dev with a ^3.2.0 and this indeed forced the version on netlify. Just mention this because I see in the faq that it also installs it as a dev dep.
Anyway, thanks for the quick help!

you're right thank you @einSelbst ! i think -D only works for CLI 😅 appreciate the tip!!!


Fix computation of the suffix for executable files.

Executable files were being given the suffix ".exe"
even on non-windows platforms. Ordinarily this is not
a problem, but with Windows Subsystem for Linux
this sometimes causes Windows to interpret the file
as a Windows executable rather than a Linux executable.
One one case (while using opam to install opam module core_kernel)
this was causing a test C program to get a kill signal
from the system.
Signed-off-by: Richard L Ford<EMAIL_ADDRESS>

Fixes #9.


User Column Data Disappears on Reload

Problem
After adding in data, formula or text, to a user column, it will be erased on reload. This is especially an issue with sites that reload on click or keydown since they are constantly checking for new rows, but is not an issue with site adapters like Hacker News since they are static.
Solution
This issue appeared after the change to reloadData that allows new rows after the initial loading of data. The function now retrieves the new rows from the site adapter and puts them in the table instead of merging the user data as well. The solution should be a better way to allow new rows, but keep existing user data as well.

to clarify: this is a known issue, we understand why it's happening. just need to fix


Custom templates in Typeahead?

Am I right in thinking there's no way to override the default template path in Typeahead? If there is a way to do this, docs should be updated.

Perhaps because I'm new to angular-bootstrap, but to me it seems very unintuitive that it isn't enough to just set typeahead-template-url to a file path of a template I want to use, but instead I need to use hacky solutions like (http://stackoverflow.com/a/26339919/2066118)[this one] or (this one)[http://stackoverflow.com/a/19720026/2066118]. Wouldn't it be much easier to just load a template from a specified file path specified via the  typeahead-template-url attribute?
The solution with


rpkg update panics out

Original issue URL: https://github.com/kptdev/kpt/issues/3933
Original issue user: https://github.com/Cbkhare
Original issue created at: 2023-04-27T15:10:31Z
Original issue last updated at: 2023-05-02T16:19:21Z
Original issue body: I am trying to update my downstream packages, but the kpt alpha rpkg update --discover=upstream panics out with below stack
$ kpt version
1.0.0-beta.31

followed the command instructions as per output of below command
kpt alpha rpkg update --help

$ kpt alpha rpkg update --discover=upstream
panic: runtime error: slice bounds out of range [:-1]

goroutine 1 [running]:
github.com/GoogleContainerTools/kpt/commands/alpha/rpkg/update.(*runner).availableUpdates(0xc0006b2380, 0xc0014dad68, 0xc0022ca000)
/go/src/github.com/GoogleContainerTools/kpt/commands/alpha/rpkg/update/discover.go:120 +0xa69
github.com/GoogleContainerTools/kpt/commands/alpha/rpkg/update.(*runner).findUpstreamUpdates(0xc0006b2380?, {0xc0021f9980?, 0xa, 0x0?}, 0x0?, {0x21949c0, 0xc000012018})
/go/src/github.com/GoogleContainerTools/kpt/commands/alpha/rpkg/update/discover.go:67 +0x109
github.com/GoogleContainerTools/kpt/commands/alpha/rpkg/update.(*runner).discoverUpdates(0xc0006b2380, 0x0?, {0xc0023d6750?, 0x0, 0x1})
/go/src/github.com/GoogleContainerTools/kpt/commands/alpha/rpkg/update/discover.go:56 +0x172
github.com/GoogleContainerTools/kpt/commands/alpha/rpkg/update.(*runner).runE(0x0?, 0x0?, {0xc0023d6750?, 0x0?, 0x0?})
/go/src/github.com/GoogleContainerTools/kpt/commands/alpha/rpkg/update/command.go:123 +0x77
github.com/spf13/cobra.(*Command).execute(0xc0023a3200, {0xc0023d6730, 0x1, 0x1})
/root/go/pkg/mod/github.com/spf13/cobra@v1.6.1/command.go:916 +0x862
github.com/spf13/cobra.(*Command).ExecuteC(0xc0006bc000)
/root/go/pkg/mod/github.com/spf13/cobra@v1.6.1/command.go:1044 +0x3bd
github.com/spf13/cobra.(*Command).Execute(...)
/root/go/pkg/mod/github.com/spf13/cobra@v1.6.1/command.go:968
k8s.io/component-base/cli.run(0xc0006bc000)
/root/go/pkg/mod/k8s.io/component-base@v0.25.3/cli/run.go:146 +0x317
k8s.io/component-base/cli.RunNoErrOutput(...)
/root/go/pkg/mod/k8s.io/component-base@v0.25.3/cli/run.go:84
main.runMain()
/go/src/github.com/GoogleContainerTools/kpt/main.go:62 +0x45
main.main()
/go/src/github.com/GoogleContainerTools/kpt/main.go:46 +0x19

$ kpt alpha rpkg update --discover=downstream
panic: runtime error: slice bounds out of range [:-1]

goroutine 1 [running]:
github.com/GoogleContainerTools/kpt/commands/alpha/rpkg/update.(*runner).availableUpdates(0xc00059f110, 0xc00132f560, 0xc002068930)
/go/src/github.com/GoogleContainerTools/kpt/commands/alpha/rpkg/update/discover.go:120 +0xa69
github.com/GoogleContainerTools/kpt/commands/alpha/rpkg/update.(*runner).findDownstreamUpdates(0xc000130008?, {0xc002379980, 0xa, 0x0?}, 0x0?, {0xc0012582d0, 0x0, 0x1}, {0x21949c0, 0xc000130008})
/go/src/github.com/GoogleContainerTools/kpt/commands/alpha/rpkg/update/discover.go:87 +0x130
github.com/GoogleContainerTools/kpt/commands/alpha/rpkg/update.(*runner).discoverUpdates(0xc00059f110, 0x0?, {0xc0012582d0?, 0x0, 0x1})
/go/src/github.com/GoogleContainerTools/kpt/commands/alpha/rpkg/update/discover.go:58 +0x206
github.com/GoogleContainerTools/kpt/commands/alpha/rpkg/update.(*runner).runE(0x0?, 0x0?, {0xc0012582d0?, 0x0?, 0x0?})
/go/src/github.com/GoogleContainerTools/kpt/commands/alpha/rpkg/update/command.go:123 +0x77
github.com/spf13/cobra.(*Command).execute(0xc000ae8c00, {0xc0012581b0, 0x1, 0x1})
/root/go/pkg/mod/github.com/spf13/cobra@v1.6.1/command.go:916 +0x862
github.com/spf13/cobra.(*Command).ExecuteC(0xc000521500)
/root/go/pkg/mod/github.com/spf13/cobra@v1.6.1/command.go:1044 +0x3bd
github.com/spf13/cobra.(*Command).Execute(...)
/root/go/pkg/mod/github.com/spf13/cobra@v1.6.1/command.go:968
k8s.io/component-base/cli.run(0xc000521500)
/root/go/pkg/mod/k8s.io/component-base@v0.25.3/cli/run.go:146 +0x317
k8s.io/component-base/cli.RunNoErrOutput(...)
/root/go/pkg/mod/k8s.io/component-base@v0.25.3/cli/run.go:84
main.runMain()
/go/src/github.com/GoogleContainerTools/kpt/main.go:62 +0x45
main.main()
/go/src/github.com/GoogleContainerTools/kpt/main.go:46 +0x19

Original issue comments:
Comment user: https://github.com/natasha41575
Comment created at: 2023-04-27T15:46:09Z
Comment last updated at: 2023-04-27T15:49:17Z
Comment body: Do you mind sharing what repos/packagerevisions you had registered when you ran into this issue, i.e. the output of kpt alpha rpkg get and kpt alpha repo get? If any of your packagerevisions are clones, could you also share how you created them?
While we should never panic, this issue is odd because it implies a malformed UpstreamLock in the Kptfile (or one of our assumptions about ref formats was incorrect) and I'd like to understand how that happened.
Comment user: https://github.com/Cbkhare
Comment created at: 2023-04-27T16:29:41Z
Comment last updated at: 2023-04-27T16:29:41Z
Comment body: Hi,
below are the requested details
$ kpt alpha repo get -A
NAME             TYPE   CONTENT   DEPLOYMENT   READY   ADDRESS
test-catalogue   git    Package   false        True    https://github.com/********/*********************.git

$ kpt alpha rpkg get -A
NAMESPACE   NAME                                                      PACKAGE                       WORKSPACENAME   REVISION   LATEST   LIFECYCLE   REPOSITORY
test        test-catalogue-233a4ca4388204556f5bceff99a9799d1a86ed1a   test-pk2                      v1              v1         true     Published   test-catalogue
test        test-catalogue-7a25f33ed16f31e2df4cc29da9c34565848d81c4   test-pkg                      v1              main       false    Published   test-catalogue
test        test-catalogue-93b612f846d238c0ee3cae8441f2e924d07eeca1   test-pkg                      v1              v1         true     Published   test-catalogue
test        test-catalogue-76dd1a835ac600377616d401ecb05323bf17f2a9   test-pkg-docker               v1              v1         true     Published   test-catalogue
test        test-catalogue-912d60e5385d7979399530e0c14ccde526622213   test-pkg-out/test-pkg-test    v1                         false    Proposed    test-catalogue
test        test-catalogue-bbb48d4284bd16b74cd089314906ed3b2ea7ba45   test-pkg-out/test-pkg-test1   v1                         false    Draft       test-catalogue
test        test-catalogue-88eafbcb6d7b73c5d934ba48ef4031334983e1e0   test-pkg-test1                v1                         false    Draft       test-catalogue
test        test-catalogue-2495313e2ff74c68b606b9ec2c16e04a0a7efc6a   test-pkg2                     v1              main       false    Published   test-catalogue
test        test-catalogue-170e5f5a6ed89619f1a0aee50623e6f98b27ee02   test-pkg2-u                   v1              main       false    Published   test-catalogue
test        test-catalogue-9e4212ac5bce692e4f2744c5ff32136cb078fa27   test-pkg2-u1                  v1                         false    Proposed    test-catalogue

Some of the above packages are clone. Below is the command I used to clone one of the package, with the output
$ kpt alpha rpkg clone test-catalogue-7a25f33ed16f31e2df4cc29da9c34565848d81c4 test-pk2 --repository=test-catalogue --ref=v2 --namespace=test --directory=test-pkg

result was
NAMESPACE   NAME                                                      PACKAGE                       WORKSPACENAME   REVISION   LATEST   LIFECYCLE   REPOSITORY
test        test-catalogue-233a4ca4388204556f5bceff99a9799d1a86ed1a   test-pk2          v1                         false    Draft       test-catalogue

Comment user: https://github.com/natasha41575
Comment created at: 2023-04-28T01:33:27Z
Comment last updated at: 2023-04-28T01:38:48Z
Comment body: Hmmm... I'm not able to reproduce the issue. Here are the steps I followed:
$ kpt alpha repo reg https://github.com/natasha41575/blueprints.git -ndefault --repo-basic-username=natasha41575 --repo-basic-password=*** -ntest

$ kpt alpha repo get -ntest
NAME         TYPE   CONTENT   DEPLOYMENT   READY   ADDRESS
blueprints   git    Package                True    https://github.com/natasha41575/blueprints.git

$  kpt alpha rpkg init test-pkg --workspace=v1 --repository=blueprints -ntest
blueprints-f09e7e39a212cd16f5abcbf8fec35099cbee266d created

$ kpt alpha rpkg clone blueprints-f09e7e39a212cd16f5abcbf8fec35099cbee266d -ntest --workspace=clone --repository=blueprints test-pkg-clone
blueprints-8c50f85abaa5d22110b7c826bcb77f8f33d39dbb created

$ kpt alpha rpkg clone blueprints-f09e7e39a212cd16f5abcbf8fec35099cbee266d test-pk2 --repository=blueprints --ref=v2 --namespace=test --directory=test-pkg
blueprints-07772b7fb702c1068c74e9345d820f758e446bb1 created

$ kpt alpha rpkg get -ntest
NAME                                                  PACKAGE          WORKSPACENAME   REVISION   LATEST   LIFECYCLE   REPOSITORY
blueprints-07772b7fb702c1068c74e9345d820f758e446bb1   test-pk2         v1                         false    Draft       blueprints
blueprints-f09e7e39a212cd16f5abcbf8fec35099cbee266d   test-pkg         v1                         false    Draft       blueprints
blueprints-8c50f85abaa5d22110b7c826bcb77f8f33d39dbb   test-pkg-clone   clone                      false    Draft       blueprints

$ kpt alpha rpkg update --discover=downstream
All downstream packages are up to date.

$ kpt alpha rpkg update --discover=upstream
PACKAGE REVISION                                      UPSTREAM REPOSITORY   UPSTREAM UPDATES
blueprints-07772b7fb702c1068c74e9345d820f758e446bb1   blueprints            No update available
blueprints-f09e7e39a212cd16f5abcbf8fec35099cbee266d                         No update available
blueprints-8c50f85abaa5d22110b7c826bcb77f8f33d39dbb   blueprints            No update available

Can you double check my above steps and let me know if there is anything differently that you did? Would you mind also sharing the Kptfiles of your packages? The upstreamLock.Git.Ref in the Kptfile for cloned packages should be of the format drafts/pkg-name/workspace or pkg-name/version. If they are not, then porch won't know how to parse them, so I'm wondering if one of the commands you ran incorrectly wrote out an invalid upstreamLock.Git.Ref. Please also let us know if you made any changes to the package outside of running kpt alpha rpkg/repo commands. Also please let us know what version of kpt CLI you are using and what version of porch you have running?
I also created a PR here https://github.com/GoogleContainerTools/kpt/pull/3938 to error out instead of panic.
As a side note, I don't think the --ref=v2 does anything for your rpkg clone command. I think this is only relevant if you are cloning directly with a git URL or from OCI.
Comment user: https://github.com/Cbkhare
Comment created at: 2023-05-02T09:19:43Z
Comment last updated at: 2023-05-02T10:41:44Z
Comment body: Hi Natasha,
Thanks for checking this. Below are some pointers wrt to above comment of yours.

2 of my Directory in the repository have the kptfiles with details as follows. I can see the ref is main. This was a cloned package.

upstreamLock:
  type: git
  git:
    repo: https://github.com/***********/*****************.git
    directory: test-pkg
    ref: main
    commit: 4331f0d83c6aa9f98b5a51e6

I added some files in the Directory from the Github UI.

kpt version

~$ kpt version
1.0.0-beta.31

Comment user: https://github.com/natasha41575
Comment created at: 2023-05-02T16:19:20Z
Comment last updated at: 2023-05-02T16:19:20Z
Comment body: Ah I see, that would explain it. rpkg update --discover doesn't handle clones from main. That is definitely a bug and we should see if we can fix it.

Closing as it was previously fixed


h5py version

As discussed in #4 , h5py 2.7.0 is required.  After downgrading pip install h5py=2.7.0, I still have
$ mpirun -n 4 python test_h5py.py
hdf5_version=1.10.1
hdf5_version=1.10.1
rank 0 read and write
Traceback (most recent call last):
  File "test_h5py.py", line 10, in <module>
    f  = h5py.File('surf_file.h5', 'r+')
  File "/home/weiw/anaconda2/lib/python2.7/site-packages/h5py/_hl/files.py", line 271, in __init__
    fid = make_fid(name, mode, userblock_size, fapl, swmr=swmr)
  File "/home/weiw/anaconda2/lib/python2.7/site-packages/h5py/_hl/files.py", line 103, in make_fid
    fid = h5f.open(name, h5f.ACC_RDWR, fapl=fapl)
  File "h5py/_objects.pyx", line 54, in h5py._objects.with_phil.wrapper
  File "h5py/_objects.pyx", line 55, in h5py._objects.with_phil.wrapper
  File "h5py/h5f.pyx", line 78, in h5py.h5f.open
IOError: Unable to open file (Unable to lock file, errno = 11, error message = 'resource temporarily unavailable')
hdf5_version=1.10.1
rank 0 read and write

Also seems the version plots are different here:
$ python
>>> import h5py
>>> print (h5py.version.hdf5_version)
1.10.1
>>> print h5py.__version__
2.7.0
>>>

OS: "Ubuntu 16.04.5 LTS"
Python:
Python 2.7.15 |Anaconda, Inc.| (default, Oct 23 2018, 18:31:10)
[GCC 7.3.0] on linux2

Hi Wei,
Thanks for the report! As discussed in https://github.com/h5py/h5py/issues/712 and https://github.com/tomgoldstein/loss-landscape/issues/4, the code works well with hdf5 v 1.8.16 but may fail with hdf5 v 1.10. Could you also check dpkg -s libhdf5-dev?  If it still shows v 1.10, then it does not work.
The default hdf5 (libhdf5-dev) comes with ubuntu 16.04 (code name 'xenial') is 1.8.16, it is upgraded to 1.10.0 in Ubuntu 18.04 (code name 'bionic') https://packages.ubuntu.com/bionic/libhdf5-dev
Could you check your OS code name with lsb_release -a? The lib may be upgraded to higher version.
If downgrading to 1.8.16 is not easy, a temporary (ugly) solution is:

download the source of hdf5_1.8.16+ and build it.
build h5py with the new hdf5, check custom installation of h5py

It is not elegant, we will try to work out a better solution.

Thanks! I have install the specific hdf5, how to build h5py from the specific hdf5 then? The tutorial is just not good. I cannot find setup.py anyway.

Hi Wei,
The source code for h5py can be found here: https://github.com/h5py/h5py , which is the place you can find setup.py. You may need to build from the source. Please let us know if there is any problems once these setting is up. Sorry for the painful process of downgrading.

Trying to get there, but python setup.py install get /home/weiw/github/h5py/h5py/defs.c:609:17: fatal error: mpi.h: No such file or directory.  Let investigate.

It took me two days to get it work. My recalls:
Note: Anaconda may not work (conda installed hdf5 may conflict with your customized installation).

install openmpi and mpi4py==2.0.0

# download openmpi-3.1.2
cd openmpi-3.1.2
./configure --prefix=/usr/local
make all
sudo make install

sudo pip install mpi4py==2.0.0

install hdf5 with --enable-parallel

# download and unzip  hdf5_1.8.16+docs.orig.tar.gz
cd hdf5-1.8.16+docs/
./configure --prefix=/usr/local/ --enable-parallel
make
sudo make install

install h5py with your hdf5

git clone https://github.com/h5py/h5py.git
cd h5py
git checkout 2.7.0
python setup.py configure --hdf5=/usr/local/
python setup.py configure --mpi
sudo python setup.py install

Thanks for the clear instructions, Wei!  We will updated README with a pointer to your scripts.

I have the same problem as you. I'd like to provide my solution here.
Since the error is caused by the  mode conflicts(r+ and r), we can solve this by changing the code, not depending on the version of h5py or hdf5. My idea is creating another h5 file( named surf_file_new) to store the losses and accuracies, so we only need to open the surf_file with 'r' mode and surf_file_new with 'w' mode.
For less code changing, I copy the content of surf_file to surf_file_new and after function cruch(), I let surf_file = surf_file_new, so that we don't need to change the subsequent code.

Downgrading h5py worked for me
pip3 install --user 'h5py==2.7.0' --force-reinstall --no-cache-dir

Downgrading h5py worked for me
pip3 install --user 'h5py==2.7.0' --force-reinstall --no-cache-dir

Fixed issue with 1.10.6 conflicting with model which was built with 1.10.4

Is it possible to support the latest h5py and hdfs by modifying the code?


Custom loss usage by name: not working in V3 but worked in V2

Default use case for custom loss in V2 (for me) was:

Register custom loss with register_keras_serializable
Use it in model compile by name compile(loss="MyPackage>MyLoss")

This worked in Keras V2, but not working in Keras V3. Here is a simple test https://colab.research.google.com/drive/1R3z3fFhV7NN1Oa_HJYp60LsneoxjOlvj?usp=sharing

@shkarupa-alex,
Unfortunately, I don't have access to Colab. Could you please grant us access?

shared

Hi @shkarupa-alex, thanks for the Colab! Could you try keras.saving.get_registered_object(name) with the name "MyPackage>MyLoss"?

Hi @shkarupa-alex, thanks for the Colab! Could you try keras.saving.get_registered_object(name) with the name "MyPackage>MyLoss"?

Added to the same colab notebook: keras.saving.get_registered_object("MyPackage>MyLoss") returns custom loss class


Clarifying that both SELECT...INTO and INSERT...SELECT ignore ORDER BY

You can easilly see this example:
drop table if exists test
go
select *
into test
from FactInternetSales where 1=0

create clustered columnstore index cci_test on test

insert into test --with (tablock)
select s.* from FactInternetSales s
order by ProductKey

And look at the actual execution plan, which lacks a sort operator.  And if the source table is large enough, you can verify that the column segments don't end up sorted.
select object_name(p.object_id) table_name, s.segment_id, c.name column_name,  s.min_data_id, s.max_data_id
from sys.column_store_segments s
join sys.partitions p
  on s.hobt_id = p.hobt_id
left join sys.columns c
  on c.object_id = p.object_id
  and c.column_id = s.column_id
where c.name = 'ProductKey'

@davidbaxterbrowne : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@davidbaxterbrowne : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@davidbaxterbrowne  Is that true for all versions of SQL Server that the documentation covers?

@davidbaxterbrowne  Is that true for all versions of SQL Server that the documentation covers?

Yes.  There has never been a documented ordering guarantee for either of these operations, so even if it behaved differently in some older version, or for some type of table, it's still appropriate to document it this way.

Yes.  There has never been a documented ordering guarantee for either of these operations, so even if it behaved differently in some older version, or for some type of table, it's still appropriate to document it this way.

Hi @davidbaxterbrowne - Thanks for submitting this!
@bluefooted - Hey Pam, can you please help confirm this? I tested David's example, and it does seem to be the case.

Hi @davidbaxterbrowne - Thanks for submitting this!
@bluefooted - Hey Pam, can you please help confirm this? I tested David's example, and it does seem to be the case.

Thanks @bluefooted!
#sign-off
@davidbaxterbrowne - Thanks again. We appreciate your help on our documentation!

Thanks @bluefooted!
#sign-off
@davidbaxterbrowne - Thanks again. We appreciate your help on our documentation!


Bump ZF diactoros version after security alert

It doesn't seem to require a significant bump in other requirements, and still supports PHP 5.6.
We've had this mentioned a few times: #167 saw it coming from the Laravel component, as did #171. It's mentioned in #151 (although there are other packages there).

Should we also allow ~2.0 so that #171 is resolved?

Yes, added to the patch.


Added week 9

Project
Name of the project
Changes
What was updated (new pages, weekly update, etc.)
Notes
If there are any further notes.

Hey @kartiktongaria  please fix the build


Received error "Not a valid stream" from API when attempting to delete a video

As you can see I'm taking a direct stream model and passing it to the api with an updated deleted field.
Code calling update:
- (void)deleteButtonTapped:(id)sender {
    UIButton *deleteButton = (UIButton*)sender;
    NSInteger index = deleteButton.tag;
    **KFStream *stream = self.streams[index];**
    stream.deleted = YES;
    [[KFAPIClient sharedClient] updateMetadataForStream:stream callbackBlock:^(KFStream *updatedStream, NSError *error) {
        if (nil != error) {
            NSLog(@"Error deleting video");
        }
    }];
}

outgoing jsonString:
{
  "state" : null,
  **"stream_id" : "ba50d609-6efb-46c3-9c44-628c01e134d5",**
  "time_started" : "05\/13\/2016 17:44:48",
  "kickflip_url" : "https:\/\/kickflip.io\/ba50d609-6efb-46c3-9c44-628c01e134d5",
  "end_lat" : null,
  "thumbnail_url" : "http:\/\/kick-us-east-1.s3.amazonaws.com\/voterockit\/gyoulcexzyje\/ba50d609-6efb-46c3-9c44-628c01e134d5\/thumb.jpg",
  "deleted" : true,
  "stream_url" : "https:\/\/d3mf59dq42lc44.cloudfront.net\/voterockit\/gyoulcexzyje\/ba50d609-6efb-46c3-9c44-628c01e134d5\/vod.m3u8",
  "city" : null,
  "start_lat" : null,
  "stream_type" : null,
  "end_lon" : null,
  "time_finished" : "05\/13\/2016 17:44:52",
  "user_username" : "gyoulcexzyje",
  "start_lon" : null,
  "country" : null
}

Error:
{success=false, reason=Not a valid stream. Make sure you supply a correct 'stream_id'., code=301}

So it looks like this is because I was trying to delete a video of a user who I'm not logged in as, however, since we don't use a login, we can't login users who have created videos.. meaning we cannot delete junk videos. Of course some sort of administrative access would be preferred, but looking into if a user can login to delete videos without having registered.

@OnlyInAmerica is there a way to delete these videos from users who don't have a password?


Duplicate declaration of update_overlay in api sample base clase

The api sample base class (based on my samples) always had a function called update_overlay in the protected part of the class:
https://github.com/KhronosGroup/Vulkan-Samples/blob/0d0cf9b90541d349ceb49682d063d27a8c2432de/framework/api_vulkan_sample.h#L357
At some point some PR seems to have introduced a virtual function with the same name in the public part:
https://github.com/KhronosGroup/Vulkan-Samples/blob/0d0cf9b90541d349ceb49682d063d27a8c2432de/framework/api_vulkan_sample.h#L115
MSVC is picking this up:

It looks like the virtual function was supposed to replace the old one, but the old declaration hasn't been removed.

Looking at that base class it also seems like a lot of recent changes were made without documentation and that there now are two public section. I'll probably do a clean up pass over the whole base class.


Genome Overview: list antibiotics alphabatically

Currently, it looks like antibiotics are listed in some random order.
https://www.patricbrc.org/portal/portal/patric/Genome?cType=genome&cId=72407.229

fixed and available on production.


Angular 15 support

Reproduction link
https://github.com/angular/angular/releases/tag/15.0.0
Steps to reproduce
Try to run with Angular 15
What is expected?
Angular 15 support
What is actually happening?
No support yet

Environment
Info

ng-zorro-antd
14.1.1

Browser
All

Hello, Angular 15 is in prerelease version now. How can we help you to add Angular 15 support for ng-zorro-antd?

If it's like angular 14, we'll have to wait a few months. Btw Angular 15 is published yesterday.

i would be happy if this time it would go a little faster with the help of us users if that is possible

definitely need new release now

We definitely cannot keep on waiting 2+ months after each major angular release.

I would also love to see a release compatible with ng15. Please let us know if we can assist somehow.
Does it make sense to do a pre-release just with the latest ng-zorro v14 adopted to ng15?

We expect to release the next version of<EMAIL_ADDRESS>as next) based on v14 until we are ready to release the version. I would very much welcome someone to take care of that work :)
Also maybe we need a new branch named release-15.0.0

https://github.com/ant-design/ant-design-icons/issues/550

Just made a pr to update the icons https://github.com/ant-design/ant-design-icons/pull/551
I have given it a quick go to update this repo to ng15 as well, but so fare there are some type errors that needs to be fixed that still takes some time.

Hey @jornare ! I also gave a look on my side to migrate to v15 and fixed the type problem.
But there is another problem. Since @angular/cdk the enum TargetVersion remove all the version expect v15. This cause the following problem

Ng update schematics migration don't work anymore
Test to previous version update don't work anymore

My question is: does it make sense to keep all the previous ng update migration for this tag version because all the schematics will be disable
@simplejason
Other thoughts, node must be upgrade since  Angular v15 minimum node version is 14.20.x
Finally test depends of @angular-builders/custom-webpack package  that is still in version 14

@Nicoss54 I noticed the same issues. I did make a workaround with the schematics using ['V11'] style accessors.  Also the builder @next is a v15 beta. This enables me to build and run the tests. The schematics tests fail now though. I could probably get them fixed, but they may as you say be of not much use anymore.

I can share my progress, but I just got to work and will not be able to look at it for about 12h.

@jornare i did the same workaround but when i did it i ask myself if it don't make more sense to remove all these deprecated migration
Maybe @simplejason can confirm or not
That's why on my fork i begin to remove
Regarding the tests i am not able to lunch them. I am on the node version 18.10.x.

Hey @jornare ! I also gave a look on my side to migrate to v15 and fixed the type problem.
But there is another problem. Since @angular/cdk the enum TargetVersion remove all the version expect v15. This cause the following problem

Ng update schematics migration don't work anymore
Test to previous version update don't work anymore

My question is: does it make sense to keep all the previous ng update migration for this tag version because all the schematics will be disable @simplejason
Other thoughts, node must be upgrade since Angular v15 minimum node version is 14.20.x
Finally test depends of @angular-builders/custom-webpack package that is still in version 14

Thanks for your efforts :) I have some questions about this:
What means @angular/cdk the enum TargetVersion remove all the version expect v15? Do you mean it removes the definition of TargetVersion? But I did find it in angular/components.
nit: If you want, you can upgrade v15 based on the branch next-15.0.0, I will merge it to master until all things done :)

@simplejason no no the TargetVersion is still present but all the previous version to v15 was removed

@simplejason no no the TargetVersion is still present but all the previous version to v15 was removed

Got it! We can follow angular to remove redundant migrations just like this PR said.

@simplejason no no the TargetVersion is still present but all the previous version to v15 was removed

Got it! We can follow angular to remove redundant migrations just like this PR said.

Okkey so you are agree with me removing previous schematics ng update test and all previous schematics update ?

@simplejason no no the TargetVersion is still present but all the previous version to v15 was removed

Got it! We can follow angular to remove redundant migrations just like this PR said.

Okkey so you are agree with me removing previous schematics ng update test and all previous schematics update ?

It's ok for me, I think that's what we can do now, otherwise it should report a type error, so I think we can remove that unless we have other compatible solutions.

@simplejason no no the TargetVersion is still present but all the previous version to v15 was removed

Got it! We can follow angular to remove redundant migrations just like this PR said.

Okkey so you are agree with me removing previous schematics ng update test and all previous schematics update ?

It's ok for me, I think that's what we can do now, otherwise it should report a type error, so I think we can remove that unless we have other compatible solutions.

Hey, i made the PR for Angular v15 compatibility, currently pipeline not passed due to the change of npm version and the non compatibility of @ant-design/icons-angular
I also update the minumum node required version in package.json and the azure pipeline
Hope it help

I got my PR to ant-design/ant-design-icons approved. It's now in released in v15 🎉

I got my PR to ant-design/ant-design-icons approved. It's now in released in v15 🎉

Hey nice, i will update the dependencies today :) and finalize the PR. Thanks for the work you dit

hello everyone, new angular v15 uses typescript v4.8.4 and this version of typescript causes type error in application.
node_modules/ng-zorro-antd/drawer/drawer.component.d.ts:17:70    17 export declare class NzDrawerComponent<T = NzSafeAny, R = NzSafeAny, D = NzSafeAny> extends NzDrawerRef<T, R> implements OnInit, OnDestroy, AfterViewInit, OnChanges, NzDrawerOptionsOfComponent {                                                                            ~~~~~~~~~~~~~
    This type parameter might need an `extends Partial<any> | undefined` constraint.
** Angular Live Development Server is listening on localhost:4299, open your browser on http://localhost:4299/ **
× Failed to compile.

there is already an issue #7620 for this

hello everyone, new angular v15 uses typescript v4.8.4 and this version of typescript causes type error in application.
node_modules/ng-zorro-antd/drawer/drawer.component.d.ts:17:70    17 export declare class NzDrawerComponent<T = NzSafeAny, R = NzSafeAny, D = NzSafeAny> extends NzDrawerRef<T, R> implements OnInit, OnDestroy, AfterViewInit, OnChanges, NzDrawerOptionsOfComponent {                                                                            ~~~~~~~~~~~~~
    This type parameter might need an `extends Partial<any> | undefined` constraint.
** Angular Live Development Server is listening on localhost:4299, open your browser on http://localhost:4299/ **
× Failed to compile.

there is already an issue #7620 for this

Hey :) compatibility with typescript 4.8 is done with the pull requests of angular 15 compatibility

So, any progress on this?

Code is in master, could we pretty please get a beta release or similar anytime soon? -Anything we can pull from NPM 😃

Hehe, I just noticed after leaving the comment. I thought I deleted it quick enough, but apparently not 😛

Upgraded my project, receiving a build error
Error: Package path ./ng-zorro-antd.min.css is not exported from package C:\dev\myapp\node_modules\ng-zorro-antd (see exports field in C:\dev\myapp\node_modules\ng-zorro-antd\package.json)
I used to include this css from styles.scss but moved the inclusion to be included from angular.json after build error.

Adding the full path (like the docs say) fixed the issue

Is it possible that recent ControlValueAccessor changes have some unnoticed impact?
I'm seeing incorrectly disabled date-picker since v15 upgrade. Looking at the sources here, I assume it may relate:

Is it possible that recent ControlValueAccessor changes have some unnoticed impact?
I'm seeing incorrectly disabled date-picker since v15 upgrade. Looking at the sources here, I assume it may relate:

yes it seams, this condition is incorrect, i will check

Is it possible that recent ControlValueAccessor changes have some unnoticed impact?
I'm seeing incorrectly disabled date-picker since v15 upgrade. Looking at the sources here, I assume it may relate:

yes it seams, this condition is incorrect, i will check

this PR will fix the issue: https://github.com/NG-ZORRO/ng-zorro-antd/pull/7786
@simplejason

This may be not the only issue, i.e. there's broken binding nzDisabled on nz-checkbox - the checkbox is not disabled at all. Any chance it could be tested per component?

This may be not the only issue, i.e. there's broken binding nzDisabled on nz-checkbox - the checkbox is not disabled at all. Any chance it could be tested per component?

let me check

v14 vs v15

v14 vs v15

@strigefleur, your behavior is fix in this PR: https://github.com/NG-ZORRO/ng-zorro-antd/pull/7786
I also check the other component, and fix issues when needed
@simplejason do you have an idea when this PR can be merged ? I will also create another PR with some missing test for checkbox

The issue considered blocking as it breaks quite a lot on our side. Any version bump ETA greatly appreciated.

@strigefleur does it work with the version 15.0.2 ?


Bot limits not working

Hi there using this bot and tried applying all the limits ddirect/torrent/ytdl/mega/leech none of the limit i working even if you set leech limit to 2 it will still continue to download the files over 2 gb ignoring the preset limits

Probably you tried with owner account, bot don't check limit for owners

Yes bro really really really sorry. Actually bot limits don't apply on group admins. Can you please also apply limits for group admins and just keep unrestricted for authorized users instead group admins. But ytdl limit is inconsistent if you set ytdl limit to 0.2gb it sometimes still ignore the 0.2gb limit and continues mirroring above that. Often happens with playlist and sometimes also with normal youtube links
Also can you do that if we disable drive link it should still be available only for bot owner mirrored messages and just be disabled for all other normal users (https://github.com/weebzone/WZML-X/blob/6eafa28dc446ecbec3b9a885221d66af8f815e71/bot/helper/listeners/tasks_listener.py#L505) like this
Thanks a lot for amazing repo bro.


Add AppLC team to OWNERS file

This PR is to add the Applifecycle team to the list of approvers & reviewers.

/cc @xiangjingli

/lgtm


Footer in documentation is not using proper/semantic html and my fix provided

Not to be a stickler but this is something that I noticed today and I thought it could be a smaller fix.
The footer in the documentation is using h5 for the footer content without having an h1-h4. Using h5 without the previous ones just for the style of it is just improper HTML and will affect accessibility and SEO, and we can do better!

Footer Content

You can use rows and columns here to organize your footer content.

Links

Link 1

Link 2

Link 3

Link 4

            © 2014 Copyright Text
            More Links

From what I have tried is that I replaced the h5 with a p tag and added these styles to it and it looked very similar to the h5. I wasn't sure if it needed to be a span, p, or something else, so I just put it as p for now. I am sure someone here can help write better html and make it more proper.

Footer Content

I was thinking since we are giving every developer something that they will probably just copy and paste, might as well give them something good!

Hmm I'm curious about how it's affecting the SEO. I mean, the footer is not the main focus of the SEO, isn't it?

That is a great question! Improper html tends to hinder accessibility and signals to Google that this website is not done properly and has accessible problems, and Google only wants to provide the best websites to their users that are the fastest, most recent, most relevant, most accessible, safest, and has the best UI and UX.
Which, I think makes sense to me because search engines like Google want their users to  show the best websites that they can find to their users so they have happy users. There are many websites that may apply when the user searches for "bees", but search engines only want to show the best one so the users are happy and get websites they like.

In most big client projects we applied the same margins and font-size values with classes like .h5.
p is not correct as this is not a paragraph per se but a heading / single line of text.

Hm, what should we do here? SEO is not our main problem and not top priority.

Hm, what should we do here? SEO is not our main problem and not top priority.

I dont see any issue here too.


DataRefresh extensions does not return the correct data

The extensions defined in DataRefresh.kt is not returning the correct data because the query does not look for the data by ID and instead only looks for data by mime type.
This means that...
var johnEmail: Email?
johnEmail = johnEmail(contactsApi)  // this could instead return jackEmail

This is a part of v0.1.9 Release Checklist.


Add test harness support for testing without jQuery.

Add new ember-try scenario for no-jquery
Add new scenario to .travis.yml (moving default and no-jquery
first in the matrix)
Update ember-cli-build.js to properly disable using jQuery when
running under the correct ember-try scenario.

Nce. I never heard of ember-native-dom-event-dispatcher. If it's a drop-in replacemente why didn't become the default?


Fix for ans1 unpackaged

Resolves: #521
I am sure will need work still, but want to try this in CI and get some discussion going as this is a high priority to fix.
Note I remove, deep quote - no one is using this at all (I am certain), so I am happy to follow up and remove the rest.
Signed-off-by: Luke Hinds<EMAIL_ADDRESS>

@stefanberger

@stefanberger

I am not 100% aware of what ima_file_signing does. Is that intended to check the IMA Signature of the measured files?
If that is the case, I have an objection for removing it :)
Starting with Fedora 34, the RPM contents will be signed for IMA.
https://fedoraproject.org/wiki/Changes/Signed_RPM_Contents
Are you removing the capability to remotely verify those signatures?

I am not 100% aware of what ima_file_signing does. Is that intended to check the IMA Signature of the measured files?
If that is the case, I have an objection for removing it :)
Starting with Fedora 34, the RPM contents will be signed for IMA.
https://fedoraproject.org/wiki/Changes/Signed_RPM_Contents
Are you removing the capability to remotely verify those signatures?

I think the easiest would be to move the import of asn1 to the part that actually needs. No more DSA keys.

I think the easiest would be to move the import of asn1 to the part that actually needs. No more DSA keys.

hold off on this one for https://github.com/keylime/keylime/pull/524 instead.

hold off on this one for https://github.com/keylime/keylime/pull/524 instead.

Are we still going to go forward with this? It still has the feature of turning IMA signature support completely off, but is that desired?

Are we still going to go forward with this? It still has the feature of turning IMA signature support completely off, but is that desired?

I am happy to close this now.

I am happy to close this now.


KMM Memory Leak (RAM + Disk) issue

How frequently does the bug occur?
Always
Description
I have been using Java Realm in the past for an Android app, that I migrated recently to Kotlin Multiplatform in order to make it compatible with iOS. After testing, it appears that by running it in an iOS environment, my memory was getting saturated by a leak, which affected both the RAM, and the disk (which it would fill up entirely in a few weeks of testing, all 64Gb). So I made a really simple downgraded version of it which showcases what exactly fails in it. In short, by calling the realm.open and realm.close methods, I leak memory (instances of realm_scheduler according to my memory graph on Xcode, but anything related to realms seems to create a way too large amount of instances in it).

In short, my Swift code to be run on iOS only executes this, which creates a timer calling Leaker.leak() every .1s :
    var leaker = RealmLeaker()
    // Code skipped here for readability
        NavigationView {
            Text("A")
        }
        .onAppear() {
            var timer1 = Timer.scheduledTimer(withTimeInterval: 0.1, repeats: true) { timerI in
                // Leaking
                leaker.leak()
            }
        }

In the KMM side, here's the Leaker Class :
class RealmLeaker {
    fun leak() {
        val config = RealmConfiguration.Builder(setOf(TestClass::class))
            .build()

        // This should simply open, then close the realm. Note that if you comment everything below this, there is no leak.
        val realm: Realm = Realm.open(config)
        realm.close()
    }
}

And for more context, here's the "TestClass" that I use :
// This class isn't really useful. Only there to showcase the leak, its properties are outside the scope of the problem.
class TestClass : RealmObject{
    @PrimaryKey
    var _id : String = "0"

    var value : Boolean = false
    var key : String = "test"
}

Here’s a repo to reproduce the error : GitHub - ALXgba/realmKMMIssue: Memory leak using Kotlin API in a KMM project, when run in iOS environment. 1
This issue seemed to be previously patched, yet I can still reproduce it : https://github.com/realm/realm-kotlin/pull/1463#pullrequestreview-1564671369
Edit : While the issue doesn't seem so terrible using the Xcode debug graphs, what isn't clearly shown by it is that the app's size on disk is also growing indefinitely, as said earlier. Meaning that a user WILL need to uninstall and reinstall periodically this app if they want to use it frequently, wiping the Realm in the process. Also, the RAM used seems to grow at a small rate, but I have observed it in my actual app (not the test one) growing fast enough to crash after an hour or so as the whole RAM gets clogged up.
Can you reproduce the bug?
Always
Reproduction Steps
Open and close a realm instance from a KMM Project using Realm Kotlin SDK inside your Swift iOS project. Everytimes you do this, a memory leak occurs.
Version
1.11.0
Are you using encryption?
No
Platform OS and version(s)
iOS 16.6 | Android SDK 26 and up

I use the SDK locally, but I don't know how to change the tags of the ticket. Could someone please edit it?

Hi, i have the same problem in my kmm project. It seems that the realm-kotlin/releases branch provides a fix for this, is there any chance that the correction will be officially released soon? @clementetb

Hi @JustusBachmann, we have addressed the issue here.
We have no planned release date yet, but you can use the snapshot builds. Please report back if the fix is working for you.

Hi @JustusBachmann, we have addressed the issue here.
We have no planned release date yet, but you can use the snapshot builds. Please report back if the fix is working for you.

Hello @clementetb. I have tried the snapshot on my test project, and I can confirm that it works. I hope it will come soon in an official release to integrate in my project. :)

Regarding the disk memory leak that I reported, that was an error on my part. Xcode was logging every read and writes to the disk in a file that wasn't cleaned, thus making it seem as if it was the database leaking. I will edit the post's original description to reflect that.

@ALXgba Ok, but the original issue was fixed as you stated in https://github.com/realm/realm-kotlin/issues/1501#issuecomment-1780826298?
By the way, the fix is available in 1.12.0

@ALXgba Ok, but the original issue was fixed as you stated in #1501 (comment)?
Yes, the issue has been resolved in 1.12.0, and I have tested it.


[stable/neo4j] neo4j prometheus monitoring

Is this a new chart

NOTE: We're experiencing a high volume of PRs to this repo and reviews will be delayed. Please host your own chart repository and submit your repository to the Helm Hub instead of this repo to make them discoverable to the community. Here is how to submit new chart repositories to the Helm Hub.

What this PR does / why we need it:
Which issue this PR fixes
(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)

fixes #

Special notes for your reviewer:
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

[ ] DCO signed
[ ] Chart Version bumped
[ ] Variables are documented in the README.md
[ ] Title of the PR starts with chart name (e.g. [stable/chart])

@rowecharles
Could you sign DCO and rebase to the latest version of Chart please? Thank you.


Dead Google Transcription jobs can indefinitely throw exception

Transcription job error due to problems with the Google transcription APIs can result in indefinite exceptions.
E.g. Exception when calling the recognition endpoint for media package unknown, job id<PHONE_NUMBER>655994050

Patched in develop branch via commit c87ef69.


Init and reset the noResponseCounter state variable

Fixes https://github.com/yfinkelstein/node-zookeeper/issues/269
Still Work In Progress and not ready for merging.
TODO:

[x] Prebuild for Windows (node 14)
[x] Prebuild for Windows (node 12)
[x] Test according to the issue reported by @asmeikal

Do you have any feedback on this pull request @asmeikal?

Hi @DavidVujic, it seems to work with the test I made!

Great, thank you @asmeikal!


chore: bump version 0.4.0-beta.10

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (fe377ae) 5.98% compared to head (b175e74) 5.98%.
Report is 82 commits behind head on main.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@          Coverage Diff          @@
##            main    #272   +/-   ##
=====================================
  Coverage   5.98%   5.98%
=====================================
  Files         78      78
  Lines       4548    4548
  Branches     893     893
=====================================
  Hits         272     272
  Misses      3412    3412
  Partials     864     864

Flag
Coverage Δ

unittests
5.98% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Passing array of Visitors/Members/Owners

Is there a way I can pass array of Visitors/Members/Owners to the template?
Currently I can pass individual users like below but with real time scenario its dynamic.
  <pnp:Security AssociatedOwnerGroup="{sitetitle} Owners" AssociatedMemberGroup="{sitetitle} Members" AssociatedVisitorGroup="{sitetitle} Visitors">
    <pnp:AdditionalOwners>
      <pnp:User Name="{parameter:Owner1}" />
      <pnp:User Name="{parameter:Owner2}" />
    </pnp:AdditionalOwners>
    <pnp:Permissions />
  </pnp:Security>

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: ec8b1360-5133-03ea-c4de-97d7280ef82c
Version Independent ID: f7354bf2-01b5-c097-3590-326761cc7f20
Content: Apply-PnPProvisioningTemplate (sharepoint-pnp)
Content Source: sharepoint/sharepoint-ps/sharepoint-pnp/Apply-PnPProvisioningTemplate.md
GitHub Login: @techwriter40
Microsoft Alias: kirks

@officedocsbot assign @yogkumgit

No, but you could build your XML injecting the AdditionalOwners element as needed.

@tseward  Thank you very much for the contribution and sharing this explanation. @ravick4u
Hope this comment is helpful for you. If you see a documentation update is required, please feel free to open an issue for the same. We proceed here to close it. Thanks for taking out some time to open the issue. Appreciate and encourage you to do the same in future also.


feat(rpc): Implement starknet_traceBlockTransactions RPC call

feat(rpc): Implement starknet_traceBlockTransactions
This PR aims to implement starknet_traceBlockTransactions rpc call introduced in v0.4.0-rc1 according to the v0.5.1 RPC specs described in https://github.com/keep-starknet-strange/madara/issues/1291
starknet_traceBlockTransactions
Retrieve traces for all transactions in the given block
Arguments
block_id : the hash of the requested block, or number (height) of the requested block, or a block tag

Return
Returns the execution traces of all transactions included in the given block
Errors
This function might return the following errors:
BLOCK_NOT_FOUND - The specified blocj could not be found.

@Tbelleng can i take this?

Yes, just check with @tdelabro before !

@Tbelleng
Checked with @tdelabro and he approved.
Just to understand context, need to implement this RPC call which returns execution traces of all transactions included in the given block, why we may encounter the error mentioned above?

The main concern is that I have no idea how you will get the execution traces.
I think you will have to re-execute the whole block in some way, while recording the trace somewhere.
What is your plan @aniketpr01 ?

@tdelabro
As discussed on TG, I can utilize runtime_api() to simulate and re-execute tx's in an environment of block preceding the one of interest (block n-1).
This can enable me to trace and collect execution details of a block and implement this RPC call.

@aniketpr01 @Tbelleng who is working on this? I think I talked to @aniketpr01 on TG

yes @tdelabro, I will be working on it!

how its going ? @aniketpr01

@Tbelleng
I am still debugging simulating the transactions and requesting some more time on this!
Also could you please share your Telegram id or if you can DM me? TG: aniketpr01

@Tbelleng I am still debugging simulating the transactions and requesting some more time on this! Also could you please share your Telegram id or if you can DM me? TG: aniketpr01

Done !

closed by #1416


Rechapcha upgrade!!!

i'm new on github sorry for errate section,
google say's  reCAPTCHA v1, which will be turned off on March 31, 2018!
it's time to upgrade to v2 or invisible?

I'd say, make a pull and merge request after doing that part. Because @TheSerapher is retired from OSS for now. :)

What @jimcouts said :D

@AmazingDreams I don't think anyone has started on this. I'm interested if you you end up developing this.

@daygle

Excellent, thanks heaps. I'll give it a try.

Added to Development branch via 97b3cc3 by @AmazingDreams - thanks a lot!


NaN fix

TBR: @bwilkerson @danrubel
Rare conditions were causing the cost function to become undefined. This allows the clustered to pass through these states and introduce steps that caused the clustering to regress. This resulting in the invariant trap aborting the clustering.

LGTM

lgtm


[Bug] FreeType renderer still missing some fonts.

FreeType
DirectWrite

Character Information

Login Queue

I am using FreeType and DirectWrite with the same preset.
Program Version: https://github.com/Soreepeong/FFXIV-FontChanger/issues/5#issuecomment-1141711913
The preset:
https://gist.github.com/toshiya14/38bce63a2bf1f26cb7216e62afa94905

XivRes.FontGenerator64.zip
Try this one. It should fix concurrency problems occurring while using FreeType.

Can you try this one? https://github.com/Soreepeong/FFXIV-FontChanger/files/8825723/XivRes.FontGenerator64.zip
I believe I found the reason freetype isn't working correctly, and this should work.

Yes, thank you. I am sorry for my late reply.
This version works fine.


Can't test registration with unconfirmed access

Description
I'm trying to write a rspec for testing the registrations controller. I configured devise to allow uncofirmed access by adding this line to the initializer. But the test keeps failing.
config.allow_unconfirmed_access_for = 15.days

Environment

Ruby 2.2.4p230
Rails 5.0.0
Devise 4.2.0

Current behavior
This is the code for the current test.
require 'rails_helper'

describe Users::RegistrationsController do
  describe 'POST #create' do
    before :each do
      @request.env['devise.mapping'] = Devise.mappings[:user]
    end

    it 'registers a new user' do
      params = valid_user_params

      expect { post :create, params: params }.to change(User.all, :count).by(1)
    end
end

And this is the error thrown.

Expected behavior
The test should pass. In fact when unconfirmed_access is not permited, the test doesn't throws any errors.

Hello @jibm82, thanks for your report.
Can you provide us a sample application that reproduces the issue in isolation?
Another option is to use our bug report template.
That would help us find the issue.
Thank you!

I'm closing this issue because it had no recent activity.
If you're still facing this on the latest version, please open a new one with all the information requested in the template.
Thank you!


Ignore binary files in test directory

Fixes #27

Codecov Report

Merging #28 (2102b11) into main (f8d4e7d) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #28   +/-   ##
=======================================
  Coverage   78.08%   78.08%
=======================================
  Files           5        5
  Lines          73       73
  Branches        4        4
=======================================
  Hits           57       57
  Misses         15       15
  Partials        1        1

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Strange gauge when values outside min/max

When entity value is outside the range of min/max the gauge is shown as in attached image

Expected:

when value is < min: empty gauge
when value is > max: full gauge

Not sure if this is a bug or as intended but I'd for instance like a general min max in temperature of 18-25 but some odd days the temperature might actually be outside this range and when that happens it looks weird if the gauge suddenly behaves strange.
The standard gauge shipped with home assistant works as expected.

Created pr with customized code from official gauge.

fixed by pull request #12 by optama
Thx!


Add E2E tests for DNS Records

Resolves #436
This is a WIP

I remembered that we also don't have edit and delete tests so I added a new file and moved some functions to a common file


v1.1.7 Completely Fails to Install on Windows 10

Hi
v1.1.7 will not install for me on Windows 10 (32 or 64 bit). This is my log:
2016-09-01 22:10:46> Program: Starting Squirrel Updater: --install .
2016-09-01 22:10:46> Program: Starting install, writing to C:\Users\XXXX\AppData\Local\SquirrelTemp
2016-09-01 22:10:46> Program: About to install to: C:\Users\XXXX\AppData\Local\OpenBazaar
2016-09-01 22:10:46> Program: Install path C:\Users\XXXX\AppData\Local\OpenBazaar already exists, burning it to the ground
2016-09-01 22:10:47> CheckForUpdateImpl: Couldn't write out staging user ID, this user probably shouldn't get beta anything: System.IO.DirectoryNotFoundException: Could not find a part of the path 'C:\Users\XXXX\AppData\Local\OpenBazaar\packages.betaId'.
at System.IO.__Error.WinIOError(Int32 errorCode, String maybeFullPath)
at System.IO.FileStream.Init(String path, FileMode mode, FileAccess access, Int32 rights, Boolean useRights, FileShare share, Int32 bufferSize, FileOptions options, SECURITY_ATTRIBUTES secAttrs, String msgPath, Boolean bFromProxy, Boolean useLongPath, Boolean checkHost)
at System.IO.FileStream..ctor(String path, FileMode mode, FileAccess access, FileShare share, Int32 bufferSize, FileOptions options, String msgPath, Boolean bFromProxy, Boolean useLongPath, Boolean checkHost)
at System.IO.StreamWriter.CreateFile(String path, Boolean append, Boolean checkHost)
at System.IO.StreamWriter..ctor(String path, Boolean append, Encoding encoding, Int32 bufferSize, Boolean checkHost)
at System.IO.File.InternalWriteAllText(String path, String contents, Encoding encoding, Boolean checkHost)
at System.IO.File.WriteAllText(String path, String contents, Encoding encoding)
at Squirrel.UpdateManager.CheckForUpdateImpl.getOrCreateStagedUserId()
2016-09-01 22:10:47> CheckForUpdateImpl: Failed to load local releases, starting from scratch: System.IO.DirectoryNotFoundException: Could not find a part of the path 'C:\Users\XXXX\AppData\Local\OpenBazaar\packages\RELEASES'.
at System.IO.__Error.WinIOError(Int32 errorCode, String maybeFullPath)
at System.IO.FileStream.Init(String path, FileMode mode, FileAccess access, Int32 rights, Boolean useRights, FileShare share, Int32 bufferSize, FileOptions options, SECURITY_ATTRIBUTES secAttrs, String msgPath, Boolean bFromProxy, Boolean useLongPath, Boolean checkHost)
at System.IO.FileStream..ctor(String path, FileMode mode, FileAccess access, FileShare share)
at Squirrel.Utility.LoadLocalReleases(String localReleaseFile)
at Squirrel.UpdateManager.CheckForUpdateImpl.d__3f.MoveNext()
2016-09-01 22:10:47> CheckForUpdateImpl: Reading RELEASES file from C:\Users\XXXX\AppData\Local\SquirrelTemp
2016-09-01 22:10:47> CheckForUpdateImpl: First run or local directory is corrupt, starting from scratch
2016-09-01 22:10:47> ApplyReleasesImpl: Writing files to app directory: C:\Users\XXXX\AppData\Local\OpenBazaar\app-1.1.7
2016-09-01 22:10:50> IEnableLogger: Failed to install package to app dir: System.AggregateException: One or more errors occurred. ---> System.IO.IOException: Access to the path 'resources' is denied.
at System.IO.DirectoryInfo.MoveTo(String destDirName)
at Squirrel.UpdateManager.ApplyReleasesImpl.<>c__DisplayClassaf.<>c__DisplayClassb3.<>c__DisplayClassb5.b__ad(DirectoryInfo subdir)
at Squirrel.Utility.<>c__DisplayClass181.<>c__DisplayClass1a.<ForEachAsync>b__17()    at System.Threading.Tasks.Task.InnerInvoke()    at System.Threading.Tasks.Task.Execute() --- End of stack trace from previous location where exception was thrown ---    at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)    at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)    at Squirrel.Utility.<>c__DisplayClass1e1.<>c__DisplayClass20.<b__1d>d__22.MoveNext()
--- End of inner exception stack trace ---
at System.Threading.Tasks.Task.ThrowIfExceptional(Boolean includeTaskCanceledExceptions)
at System.Threading.Tasks.Task.Wait(Int32 millisecondsTimeout, CancellationToken cancellationToken)
at Squirrel.UpdateManager.ApplyReleasesImpl.<>c__DisplayClassaf.<>c__DisplayClassb3.b__ac(DirectoryInfo ld)
at Squirrel.EnumerableExtensions.ForEach[TSource](IEnumerable1 source, Action1 onNext)
at Squirrel.UpdateManager.ApplyReleasesImpl.<>c__DisplayClassaf.<b__a9>d__b7.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
at Squirrel.Utility.d__501.MoveNext() ---> (Inner Exception #0) System.IO.IOException: Access to the path 'resources' is denied.    at System.IO.DirectoryInfo.MoveTo(String destDirName)    at Squirrel.UpdateManager.ApplyReleasesImpl.<>c__DisplayClassaf.<>c__DisplayClassb3.<>c__DisplayClassb5.<installPackageToAppDir>b__ad(DirectoryInfo subdir)    at Squirrel.Utility.<>c__DisplayClass181.<>c__DisplayClass1a.b__17()
at System.Threading.Tasks.Task.InnerInvoke()
at System.Threading.Tasks.Task.Execute()
--- End of stack trace from previous location where exception was thrown ---
at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
at Squirrel.Utility.<>c__DisplayClass1e`1.<>c__DisplayClass20.<b__1d>d__22.MoveNext()<---
2016-09-01 22:10:50> Unhandled exception: System.AggregateException: One or more errors occurred. ---> System.AggregateException: One or more errors occurred. ---> System.IO.IOException: Access to the path 'resources' is denied.
at System.IO.DirectoryInfo.MoveTo(String destDirName)
at Squirrel.UpdateManager.ApplyReleasesImpl.<>c__DisplayClassaf.<>c__DisplayClassb3.<>c__DisplayClassb5.b__ad(DirectoryInfo subdir)
at Squirrel.Utility.<>c__DisplayClass181.<>c__DisplayClass1a.<ForEachAsync>b__17()    at System.Threading.Tasks.Task.InnerInvoke()    at System.Threading.Tasks.Task.Execute() --- End of stack trace from previous location where exception was thrown ---    at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)    at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)    at Squirrel.Utility.<>c__DisplayClass1e1.<>c__DisplayClass20.<b__1d>d__22.MoveNext()
--- End of inner exception stack trace ---
at System.Threading.Tasks.Task.ThrowIfExceptional(Boolean includeTaskCanceledExceptions)
at System.Threading.Tasks.Task.Wait(Int32 millisecondsTimeout, CancellationToken cancellationToken)
at Squirrel.UpdateManager.ApplyReleasesImpl.<>c__DisplayClassaf.<>c__DisplayClassb3.b__ac(DirectoryInfo ld)
at Squirrel.EnumerableExtensions.ForEach[TSource](IEnumerable1 source, Action1 onNext)
at Squirrel.UpdateManager.ApplyReleasesImpl.<>c__DisplayClassaf.<b__a9>d__b7.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
at Squirrel.Utility.d__501.MoveNext() --- End of stack trace from previous location where exception was thrown ---    at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)    at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)    at System.Runtime.CompilerServices.TaskAwaiter.ValidateEnd(Task task)    at Squirrel.UpdateManager.ApplyReleasesImpl.<ApplyReleases>d__7b.MoveNext() --- End of stack trace from previous location where exception was thrown ---    at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)    at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)    at Squirrel.UpdateManager.<FullInstall>d__f.MoveNext() --- End of stack trace from previous location where exception was thrown ---    at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)    at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)    at System.Runtime.CompilerServices.TaskAwaiter.ValidateEnd(Task task)    at Squirrel.Update.Program.<Install>d__38.MoveNext()    --- End of inner exception stack trace ---    at System.Threading.Tasks.Task.ThrowIfExceptional(Boolean includeTaskCanceledExceptions)    at System.Threading.Tasks.Task.Wait(Int32 millisecondsTimeout, CancellationToken cancellationToken)    at System.Threading.Tasks.Task.Wait()    at Squirrel.Update.Program.executeCommandLine(String[] args)    at Squirrel.Update.Program.main(String[] args) ---> (Inner Exception #0) System.AggregateException: One or more errors occurred. ---> System.IO.IOException: Access to the path 'resources' is denied.    at System.IO.DirectoryInfo.MoveTo(String destDirName)    at Squirrel.UpdateManager.ApplyReleasesImpl.<>c__DisplayClassaf.<>c__DisplayClassb3.<>c__DisplayClassb5.<installPackageToAppDir>b__ad(DirectoryInfo subdir)    at Squirrel.Utility.<>c__DisplayClass181.<>c__DisplayClass1a.b__17()
at System.Threading.Tasks.Task.InnerInvoke()
at System.Threading.Tasks.Task.Execute()
--- End of stack trace from previous location where exception was thrown ---
at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
at Squirrel.Utility.<>c__DisplayClass1e1.<>c__DisplayClass20.<<ForEachAsync>b__1d>d__22.MoveNext()    --- End of inner exception stack trace ---    at System.Threading.Tasks.Task.ThrowIfExceptional(Boolean includeTaskCanceledExceptions)    at System.Threading.Tasks.Task.Wait(Int32 millisecondsTimeout, CancellationToken cancellationToken)    at Squirrel.UpdateManager.ApplyReleasesImpl.<>c__DisplayClassaf.<>c__DisplayClassb3.<installPackageToAppDir>b__ac(DirectoryInfo ld)    at Squirrel.EnumerableExtensions.ForEach[TSource](IEnumerable1 source, Action1 onNext)    at Squirrel.UpdateManager.ApplyReleasesImpl.<>c__DisplayClassaf.<<installPackageToAppDir>b__a9>d__b7.MoveNext() --- End of stack trace from previous location where exception was thrown ---    at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)    at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)    at Squirrel.Utility.<LogIfThrows>d__501.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
at System.Runtime.CompilerServices.TaskAwaiter.ValidateEnd(Task task)
at Squirrel.UpdateManager.ApplyReleasesImpl.d__7b.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
at Squirrel.UpdateManager.d__f.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
at System.Runtime.CompilerServices.TaskAwaiter.ValidateEnd(Task task)
at Squirrel.Update.Program.d__38.MoveNext()
---> (Inner Exception #0) System.IO.IOException: Access to the path 'resources' is denied.
at System.IO.DirectoryInfo.MoveTo(String destDirName)
at Squirrel.UpdateManager.ApplyReleasesImpl.<>c__DisplayClassaf.<>c__DisplayClassb3.<>c__DisplayClassb5.b__ad(DirectoryInfo subdir)
at Squirrel.Utility.<>c__DisplayClass181.<>c__DisplayClass1a.<ForEachAsync>b__17()    at System.Threading.Tasks.Task.InnerInvoke()    at System.Threading.Tasks.Task.Execute() --- End of stack trace from previous location where exception was thrown ---    at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)    at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)    at Squirrel.Utility.<>c__DisplayClass1e1.<>c__DisplayClass20.<b__1d>d__22.MoveNext()<---
<---

I might add, the "burn it to the ground" line is awesome.

I have the same problem, same stack trace.

Please try on 1.1.8 release and re-open if necessary.


More pleasing icon placement

It's now possible to set the position in the settings file. Thanks @ryw


feat(react-image-block): add new props from Thumbnail component

General summary

Add new props from Thumbnail component.
Screenshots

Check list

[ ] (if has style) Add need: review-integration label
[ ] (if has textual documentation) Add need: review-doc label
[x] (if has code) Add need: review-frontend label
[ ] (if has react) Check through the react dev check list
[x] (if fix or feature) Add need: test label

Check out the contribution guide for general guidelines for submissions to the design system.

These props are going to be removed from the ImageBlock component when the thumbnail is extracted as a children, right?

Yes, exactly!


time is missing

Ftp connect: time is missing

sftp connect: Time is present

This is likely a client issue. It is common for clients to exclude the time when the modified date is not in the current year (as shown in your example).
Either way this is not likely an issue with the docker image.


Sieve approach

An approach for Sieve.

@ErikSchierboom: C++ Sieve approach ready for review.

Some small suggestions:

The std::vector is named composites. Personally I'd rather use the name sieve because that's the eponymous Sieve of Eratosthenes. But naming is subjective and I can see why you chose composites.
The function reserves a capacity of limit / 2. That's not wrong but are you sure that's worth the effort? Even for moderately large limits the number of primes is much smaller that limit / 2. If you really want to avoid any resize operation you could use one or multiple of the inequalities that the Wikipedia lists as Approximations for the nth prime number or Non-asymptotic bounds on the prime-counting function. But personally I would omit the reserve() completely. All std::vector operations increase the capacity by some factor between 1.5 and 2, guaranteeing an amortized linear runtime and it's an optimization beyond the level of explanation.
The inner for loop marks all composites of the current prime, starting with number + number. But you can choose a larger starting point: number * number because all multiples below that have been marked in a previous iteration. With this small optimization the runtime complexity becomes Θ(n log log n) (see The Genuine Sieve of Eratosthenes by Melissa O'Neill).

In the explanation:

"the number being iterated" -> "the current number", because it's a little bit simpler

@siebenschlaefer: Thank you again for your comprehensive feedback! As mentioned in the forum, we're looking for optimistic merging for these. I encourage you to bring your expertise to improving them after merging. However, if these are too far below an acceptable quality level, I won't take offense if you prefer I not do them for C++. I admittedly have limited stamina for some details, especially after the burnout of having done so many for so many languages already. Thanks again!

Sorry, it seems I misunderstood "ready for review".
If you prefer merging it first and then improving it through PRs that's fine with me.
And no, I do not think the code or explanation is unacceptable.
The code is easy to read, idiomatic, and reasonably efficient, I had no problems understanding the explanation.

I'm okay with leaving it as is, but re starting with number + number, when we're processing 2, if we don't set 4 to true for being a composite, won't it get skipped? As processing 3 won't handle it, and then when we iterate to 4 it will be false for being a composite and will be added to the primes. But math isn't my forte, so maybe I'm not seeing something?

@ErikSchierboom or @siebenschlaefer: I think this might be ready to be merged now?

@siebenschlaefer Any objections to merging this as is and improving things in a follow-up PR?

Okay, I'm thinking the number times itself would be more performant and would work. Let me make that change...

Looks good!

Thanks both!


Some plots are not drawn with the colour I set

I'm drawing many plots in the same chart, half of them are in blue, the others are red.
But the chart display (sometimes) some of them in different colours.
for (int k=0;k<nbrRuns;k++) {
// Series
XYSeries series1 = chart.addSeries("Hash"+k, xData, results1[k]);
series1.setLineColor(XChartSeriesColors.BLUE);
XYSeries series2 = chart.addSeries("Fitness"+k, xData, results2[k]);
series2.setLineColor(XChartSeriesColors.RED);
}

@elkrari
This is caused by drawing markers.
There are two ways to solve it:

Don't draw marker:

series1.setMarker(SeriesMarkers.NONE);
series2.setMarker(SeriesMarkers.NONE);

Set marker color, same as line color:

series1.setMarkerColor(XChartSeriesColors.BLUE);
series2.setMarkerColor(XChartSeriesColors.RED);


Last active time based login flow

Last active time should be recorded whenever app goes out of focus
If app has been out of focus for less than 20 sec, HS should be shown directly.
If app has been out of focus for more than 20 sec. The user should be asked to enter the passcode again.

-Verified this issue on Dev app v1.7.5 (294)


[BUG] Add list of columns that will be dropped in SARIMAX model

🐛 Bug Report
Now if something went wrong while training SARIMAX model we see the following warning
packages/etna/models/sarimax.py:294: UserWarning: SARIMAX model does not work with exogenous features (features unknown in future).

Expected behavior
The warning should be more like
packages/etna/models/sarimax.py:294: UserWarning: SARIMAX model does not work with exogenous features (features unknown in future).
Columns to be droped: <List[ColumnNames]>.
Data latest timestamp: <latest timestamp>.
List[ColumnNames]: List[LatestTimestaps of columns]

How To Reproduce
{
"forecaster": {
"target": "etna.pipeline.Pipeline",
"horizon": 7,
"model": {
"target": "etna.models.SARIMAXModel",
"order": [
4,
0,
4
],
"seasonal_order": [
1,
0,
0,
7
]
},
"transforms": []
}}
Environment
No response
Additional context
No response
Checklist

[X] Bug appears at the latest library version

I guess we have FilterTransform for dropping extra features 🤔


AO-14938: Single gRPC client for all

This PR makes everything be sent out from a single gRPC connection, rather than two.
See https://swicloud.atlassian.net/browse/AO-14938

Codecov Report

Merging #138 into master will increase coverage by 0.2%.
The diff coverage is 50%.

@@            Coverage Diff            @@
##           master     #138     +/-   ##
=========================================
+ Coverage   81.91%   82.12%   +0.2%
=========================================
  Files          37       37
  Lines        4590     4575     -15
=========================================
- Hits         3760     3757      -3
+ Misses        705      694     -11
+ Partials      125      124      -1

Impacted Files
Coverage Δ

v1/ao/internal/reporter/reporter_grpc.go
70.49% <50%> (+1.12%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 20903ac...3de7a40. Read the comment docs.


Return exit codes depending on situation

It would be wonderful if the script would return i. e. a 1 exit code if everything went well and a certificate has actually been updated by a renewal. This would ensure that the reload of the webserver only happens when it is really necessary.

As the author mentioned in a comment to another issue, Python will return exit code 1 if the scripts halts due to an exception. Furthermore as far as I know a renewal attempt is made upon each invocation of the script. So if exit code = 0, the certificate will have changed.
Note that the renewal script shown in step 6 does not check the exit code at all and will effectively erase the certificate if the script halted with an exception. So I highly recommend modifying it to check the exit code.
Maybe something like this:
#!/bin/sh

python /path/to/acme_tiny.py --account-key /path/to/account.key --csr /path/to/domain.csr --acme-dir /path/to/acme-challenge/ > /path/to/domain.renew
STATUS=$?
if [ $STATUS -eq 0 ]
then
    cp /path/to/domain.renew /path/to/domain.crt
    wget -O - https://letsencrypt.org/certs/lets-encrypt-x1-cross-signed.pem > intermediate.pem
    cat /path/to/signed.crt intermediate.pem > /path/to/chained.pem
    service nginx reload
fi

This script is also pretty well suited to include it the python way:
import acme_tiny
...
try:
   acme_tiny.get_crt(...)
except:
   ...

This way, you can handle the exceptions very smooth. I'd prefer this way of integration in an automated environment.
(See my issue #23 for redirection of the non-error messages.)

Yes, if you want more than a 0 or 1 exit code, please import the script in python and catch exceptions raised how you like.


Consistent React event method naming

Use "on" for props, same as React's own event naming: https://facebook.github.io/react/docs/forms.html#interactive-props
Use "handle" to delineate internal handlers
Merge together with https://github.com/silverstripe/silverstripe-asset-admin/pull/154

Rebased and merged separately.

https://github.com/silverstripe/silverstripe-framework/commit/0838770798eb82618c32c8bb803fb94a1566d9fb


possible server disconnect after some time in background on develop

I just rolled back to the 0.8.15 update to see if it goes away. When opening the app after an hour or so, the server will not be connected, and I have to wait about twenty seconds for it to connect so I can properly send messages. If I don't wait, they wont send and #2508 just deletes them entirely.

Realized it started happening right around the time I started joining larger rooms, so I left all the large rooms I was in on the matrix homeserver and the issue resolved itself. No more twenty second waits to send messages.


Added init_downstream_modules phase allowing modules to be set up before startup

This addresses a roadblock I’ve hit trying to make the new downstream modules mechanism work for me: these cannot be configured from within the HttpProxy instance. The configuration has to happen after http_proxy_service has been called, but at this point the HttpProxy instance has been moved into the service and is no longer accessible. In order to adjust the compression level for example some code outside the actual handler would have to mess with the service configuration which is a significant logic break.
In case of compression this can be addressed by adjusting compression level in early_request_filter. When the handler wants to add its own module however (helps remove some work-arounds I’ve added before), this option is rather suboptimal.
So I’ve added an init_downstream_module phase where HttpProxy can adjust modules to its liking.

When the handler wants to add its own module however (helps remove some work-arounds I’ve added before), this option is rather suboptimal.

Actually, I can see now that the module list is no longer mutable during early_request_filter, so adding modules isn’t even possible there. Hooking into the server initialization is really the only way.

You can access and mutate the modules here. Be this PR also provides a nicer API.
let mut proxy = http_proxy_service(...);
proxy.app_logic_mut().unwrap().downstream_modules

You can access and mutate the modules here.

I know. As I said, doing this via some code outside the handler is possible but a significant logic break.

We've brought this into main as dda7bec58cb176228b8194e97c8c9e52bf36b878. Thanks!


feat : Adding animations in the home page of the website

we can add scroll animations and parallax animation
in the website

@RamakrushnaBiswal Describe your Issue .


Tables have some accessibility issues

Package
filament/tables
Package Version
v2.16.37
Laravel Version
v9.37
Livewire Version
v2.10.7
PHP Version
8.1
Problem description
I've observed two significant issues with the admin tables that make them very difficult to use for a screen reader user (and not WCAG compliant).

The bulk action checkboxes do not have an accessible label.
The sort buttons at the top of the column don't indicate what happens when you click them.

Expected behavior

The checkbox should reference the table row it is used to select in one of three ways:

giving each checkbox a unique id and providing a <label> which references the id via its for attribute;
referencing another element by id which provides a label for the checkbox using the aria-labelledby attribute;
using an aria-label attribute directly on the checkbox input

The checkbox should be announced as (for example): "Test User, checkbox, unchecked"

The sort button, in addition to the column name, should include text visually hidden using Tailwind's .sr-only class which says "Sort (ascending|descending) by". The button would then be announced as "Sort ascending by name" instead of just "Name", providing better context to a screen reader user.

Steps to reproduce
Preparation: clone repository, install dependencies, run php artisan migrate:fresh --seed. Log in to /admin as user<EMAIL_ADDRESS>password = 'password'. Visit the Users page in the admin area.

Using VoiceOver on macOS, every checkbox on the Users admin page is announced as "unchecked checkbox" with no further context.

Using VoiceOver on macOS, the sort buttons on the Users admin page only give the column name and not any context for what will happen when they are pressed.

Reproduction repository
https://github.com/greatislander/filament-tables
Relevant log output
No response

P.S. I would be happy to contribute PRs for both of these issues.

PRs would be great, thanks!

Please ensure that any labels are also added as translatable

I also spotted the accessibility issues when testing to WCAG 2.1 AA standard. I will hold off raising a PR until the OP @greatislander has finished this PR.
I can confirm the issue using the OP's Reproduction repository, then run Google Chrome's lighthouse report, set to test accessibility.  See admin-users-table.pdf. The current score is 86%.

The input is as per the OP's issue. regarding the checkbox
The drop-down selector for the number of pages isn't mentioned. It would be a similar fix to the input.
Contrast ratio issues are also not raised, although they will be per the theme. As amber is the default, it may be worth making the default theme compliant. However, I'm not sure how this will affect other themes, do they inherit the default?

Tailwind CSS makes fixing contrast radio problems easier:

User white text with amber background (bg-primary-500): increase the background by 100 until the ratio passes (e.g. bg-primary-600 > bg-primary-700).
Edit amber text (text-primary-500) on white background: increase the text by 100 until the ratio passes (e.g. text-primary-600 > text-primary-700).

I expect the CSS will need to be recompiled.
Thanks

Issues addressed in #5648


How can I use bottomLeftComponent?

How can I use bottomLeftComponent ?
I set this value to any but it seems not work

Hi,
any is a type, it's not a value that you can set: https://www.typescriptlang.org/docs/handbook/basic-types.html
Here is an example: https://github.com/fnzc/react-native-pincode/issues/33#issuecomment-445627825
Cheers :),
Jeremy