Serverless compatibility

I am wondering how would HikariCP behave in a Serverless environment. I am developing an application with AWS Lambda functions, but since those functions are pretty stateless, it's hard to deal with connection pooling.
Most of the issues are summarized here, but I really don't like that solution, it's cumbersome and depends on a synchronization that can fail.
Other websites show simpler options, like this one, which could be replaced by HikariCP.
In a nutshell, they tell you to create a connection on the first run and save it as a global variable, then reuse it every time the Lambda function is invoked. In case the function is never invoked again, set a small connection lifetime in the database so it won't run out of connections.
I wonder if I could just use HikariCP with AWS Lambda, telling HikariCP to only manage 1 connection. There's always the problem of maxing out the database connections, but I can limit how many Lambda instances can be created at the same time.
The main issue for me will be how HikariCP would behave once the Lambda function freezes background tasks after returning, and then resume them after being triggered another time.
Do have any best practices for using HikariCP with AWS Lambda? Have this been tested before? Or is it not recommended at all?

Sorry, I have no experience with AWS Lambda at all.  Try asking on stackoverfow or the AWS support forums.

Ok, but I don't expect them to know much about it because they won't know the inner workings of your library.
AWS Lambda basically initiates a container on a first invocation, so we can set up static variables that will live as long as the container lives. Then it calls a handler function we defined in the configurations. This handler function executes, does it magic, and returns. Upon returning any background threads created by the handler function are freezed and the whole container is freezed, until a new invocation is made. Invocations can be triggers by events like API calls or cron jobs or modifications in AWS systems.
Once a new invocation arrives the container is already created, so this is like a hot start, it just unfreezes the container and all the background threads come back to life.
This "unfreeze" behavior on a static HikariCP instance that bothers me.

It is difficult to see how a pool can work well in such a scenario.  The housekeeper thread cannot retire connections, and if the container is truly frozen it is possible that unacknowledged TCP can even hang connections from the DB perspective.
It seems like other Lambda users must be using databases.  The question is what are they doing to manage connections?  Maybe there is a pool implementation specifically for Lambda...

I will try it out.
Just to clarify things a bit further, AWS actually recommends 2, with some brief words. 3 is another AWS recommendation on how to avoid maxing out the DB connections. Other strategies are to limit the number of containers a Lambda function can create.
So as far as I can see, no perfect solution for serverless DB connections yet.

@feinstein Where you able to find a perfect solution eventually ?

Nope, I stopped using pooling and did my own code where I cache one connection and one only.

Could you please send a link to your implementation of that

I am not comfortable with that as that code wasn't thoroughly tested yet.

Handling connections in serverless is pretty complicated. AWS has their recommendations here.

Yes they are, and all of them have caveats, as I exposed in a previous comment on this thread.


Add info about ca cert used to verify chain.

The tsi_peer object will now contain the subject of the root/ca cert that was used to verify the peer's chain during a handshake.
We have to get this information into tsi_peer in a roundabout way - unfortunately BoringSSL does not have the function SSL_get0_verified_chain. The only way to get the verified chain (and thus the CA/root cert that was used to verify the peer's chain) is through the X509_STORE_CTX used during the handshake post-verification. So we tie into that callback, then we store the CA Cert on the SSL object as ex_data. The SSL object is what we have access to when setting the values on tsi_peer, thus we need the information on that object.
There will be a follow-up PR that adds this information to grpc_tls_custom_verification_check_request and TlsCustomVerificationCheckRequest (these structs/classes are constructed using information in tsi_peer), with the end goal of the grpc-user having access to the Subject information of the CA cert used to verify the peer chain during custom verification callbacks.

@matthewstevenson88

Feel free to add Zhan as another pair of eyes, and I believe I've addressed your last round of comments.
There's a few tests failing, but I believe it's some infra/CI related issues (I made no material code changes since the last commit since everything passed). I'll keep an eye on it and re-run the tests.

@zeromath

LGTM on OpenSSL APIs.

@markdroth we've got LGTM from the security side, can we get a general language review?


Support custom order_by function?

I find all docs that the order_by is support for filed, may i use custom order_by function? thx.

order_by on a query works exactly like in plain SQLAlchemy.
Besides that, your question is extremely unclear and support questions should be asked on IRC or Stack Overflow.


Revert dev channel back to Flutter stable

I goofed in https://github.com/dart-lang/dart-services/pull/1002 and broke the build for the DartPad dev channel. Reverting just that part of the previous change.

I'm curious, what is dev in the DartPad UI (which has Stable, Beta, Old, and Master)?

I'm curious, what is dev in the DartPad UI (which has Stable, Beta, Old, and Master)?

Dev was the old flutter dev channel. When that channel was retired we repurposed it for testing things. So these days the dev channel shadows the stable channel, but it has additional packages. It's also hidden by default in the front end UI.
So these days stable and beta are the matching flutter channels. Old is the previous stable, and master is my best effort at keeping up to date with google3 rolls. Usually I sim for weekly.


Add designspace test with axis element

MutatorMath requirement needs to be updated to latest, and then hopefully this will pass.

Is this what you need: https://github.com/LettError/MutatorMath/releases/tag/2.01

@LettError yes, thank you Erik!
@jamesgk if you rebase on master, the test should now pass.


It is not documented how to discover, install, and use external toolchains

Currently each board will describe how to use an external toolchain.
This causes duplication between boards, as they re-iterate what toolchains are available and how to use them, and it causes some users to not discover that there are more supported toolchains available than what the board's documentation mentions.

Are there some examples? In my list, Zephyr SDK is the canonical source of the toolchain, and I don't remember seeing my of external toolchain docs in the boards (I may imagine some, like esp32, indeed have that).

The board xtensa/esp32 is describing how to install the ZEPHYR_GCC_VARIANT=espressif toolchain.
The board riscv32/zedboard_pulpino is describing how to install the ZEPHYR_GCC_VARIANT=riscv32 toolchain.
The toolchain ZEPHYR_GCC_VARIANT=gccarmemb could be used by several boards, but there is no way for an ARM user to discover that he has more options than ZEPHYR_GCC_VARIANT=zephyr.
I don't have any examples of toolchain documentation being duplicated, but obviously the next board that supports espressif or riscv32 will have to duplicate the documentation as there is nowhere to put external toolchain documentation today.

Thanks, that clarifies the issue (and hopefully will help to set a priority for it).

over 1 year, closing.

@dbkinder : FYI


Need clean up intermediate data in Ballista

Is your feature request related to a problem or challenge? Please describe what you are trying to do.
We need to check whether the states saved in the sled is consumed by UI or not.
if not consumed by UI, we can clean the job/task data when the SQL is finished.
If they are consumed by UI, we can choose either LRU based policy like Spark or time based eviction policy.
Regarding shuffle files, we also need to implement a way to clean them. This is a little bit complex because we need to clean up the files on all the hosts. We might need to add new RPCs.

related to #1701


feat: add support for kirby serve w/ HMR plugin

fix #17
depends on https://github.com/getkirby/kirby/pull/4541
To do:

[x] verify asset imports work in serve mode
[x] verify env vars (default and from .env) work in serve mode
[x] verify default aliases and kirby.config.js#alias work in serve mode
[x] verify postcss transforms work in serve mode
[x] enable reload for PHP changes (configurable?)
[x] CLI help texts in cli-start.ts
[x] investigate slowdown caused by kirbyup config (done, separate issue: #19)
[x] investigate slow server response times with vite-plugin-live-reload
[ ] Update README
[ ] Add tests

This is the greatest contribution to a project of mine. Thank you so much, digging into this feature. Stunning work.
Regarding the docs
Since the README got pretty verbose by now, I will migrate to VitePress soon. We can then add a dedicated section to the serve feature.
Regarding reload for PHP changes
We could introduce a CLI option like kirby-dir to let the user point us to the right direction, while also checking for something like parentPath.endsWith('site/plugins') to somewhat detect the environment. Most plugin devs probably develop right from their plugins folder of their Kirby instance. Could be activated by default with an opt-out, I think.

I haven't yet tested the feature thoroughly yet.

Status update:
✅ Verified that .env, alias and PostCSS features work as intended in serve mode.
👀 Assets are a different beast however:

Vite inlines all imported static assets in library mode, so the JS and CSS files get huuuuuge if you import any images, fonts etc.. This isn't serve related and definitely a separate issue. (see: https://github.com/vitejs/vite/issues/4454 https://github.com/vitejs/vite/issues/3295 https://github.com/vitejs/vite/pull/5028)

For kirbyup serve, we must specify the server.origin option in the Vite config, otherwise assets are requested from the Kirby/PHP server and error out.

This means we need to hardcode the port kirbyup uses so we can specify it in server.origin. A bit unfortunate, but not a dealbreaker, I think?
vite-plugin-vue2 appears to have a bug where URLs referenced from the template (img src="../...") don't properly include the origin - a slash is missing (http:/...) so the URL isn't treated as absolute and asset loading breaks

So yeah, the asset story is a bit unclear. I can think of a couple ways to fix the behavior in serve mode (fix plugin-vue2 so assets can be loaded from the Vite server directly, or set a base so assets can be imported from Kirby's site/ or media/ directories and the request doesn't hit Vite) – but even with these fixes in, the behavior in build mode is still terrible, and I don't see an easy way to fix it, as it even applies to assets in the public/ dir.
Aside from the whole assets endeavor, I'm currently investigating some possible issues with server closing and server response times, which seem to be affected by the existence of a kirbyup.config.js and also by vite-plugin-full-reload 🤔

Submitted the fix so that server.origin doesn't break asset URLs in https://github.com/vuejs/vue/pull/12732 :)

Most of the Kirby Panel plugins don't actually include custom assets, as far as I know. As relevant as a bloated bundle is, I think it's neglectable if you can't make it working. 🙂

Alright, so I take it that https://github.com/vuejs/vue/pull/12732 is non-blocking - we can move forward with this PR, assets in dev break and if the Vue PR is merged we simply need to update @vue/compiler-sfc and it should work. :)
The dev server needs a fixed port for the asset URLs, which defaults to 5177 and can be set via the -p, --port CLI flag.

I'm completely fine tracking that in a separate issue!

Found the issue with vite-plugin-live-reload: https://github.com/ElMassimo/vite-plugin-full-reload/issues/9 (and added a workaround)

So, everything should be working now I think!
As for docs, I'd suggest adding the new command and its options to the README for now, switching to VitePress sounds like material for another PR.
Then the only open question would be how (and how thoroughly) to test this. Apart from that, HMR support should be ready and we just need https://github.com/getkirby/kirby/pull/4541 to move forward! :)

Alright, so I take it that https://github.com/vuejs/vue/pull/12732 is non-blocking - we can move forward with this PR, assets in dev break and if the Vue PR is merged we simply need to update @vue/compiler-sfc and it should work. :)
The dev server needs a fixed port for the asset URLs, which defaults to 5177 and can be set via the -p, --port CLI flag.

It is non-blocking. Sounds good.
Another approach, would be to use pnpm patch to patch the package until the issue is resolved upstream. We have to patch @vitejs/plugin-vue2 currently as well to ensure it's working with npx. Without patching, the Vite plugin will not work ran from the global _npx dir.
Adding another fix for the Vue compiler would be fine by me. Otherwise, we just wait. Maybe it's not worth the time patching it now. What do you think?

Found the issue with vite-plugin-live-reload: https://github.com/ElMassimo/vite-plugin-full-reload/issues/9 (and added a workaround)

Good catch!

So, everything should be working now I think!

Seems like it. Again, amazing work!

As for docs, I'd suggest adding the new command and its options to the README for now, switching to VitePress sounds like material for another PR.

👍 I don't have the resources to migrate to VitePress at the moment and don't want to rush it. A section in the README should do the job just as fine.

Then the only open question would be how (and how thoroughly) to test this. Apart from that, HMR support should be ready and we just need https://github.com/getkirby/kirby/pull/4541 to move forward! :)

I'm unsure how to debug as well. In an older version of kirbyup I used npx tsx cli.ts to run the tests. It may be suitable for the serve tests if some kind of output artifact is readable and reproducible.

Another approach, would be to use pnpm patch to patch the package until the issue is resolved upstream.

Already tried that, but it doesn't work. :(
It only works for plugin-vue2 because it is inlined into the built kirbyup, so downstream users don't load it from their node_modules but use the shipped and patched copy. But inlining @vue/compiler-sfc doesn't work, it has a ton of optional dependencies which rollup transforms into sync imports so unless stylus, velocityjs etc. all are installed, it won't execute.

Dang, you're right, I had to inline @vitejs/plugin-vue2 for the fix to be effective… :rocket-down-emoji:
Doesn't make sense for the Vue SFC Compiler. Non-blocking it is, still. When your fix is approved, we can release a minor update. 🙌

One more optional task: Adding your name to the license file and README, since your contribution will be an impactful one. Feel welcome to do so!

We can add automated tests later. 🙂


Скласти таймлайн

Скласти список всіх (важливих) життєвих подій, визначних дат, досягнень, періодів, що дали приємний і неприємний досвід, тощо. В цьому конкретному випадку довгих списків не буває, натомість бувають погано згорнуті, тому пакуємо сюди все підряд, а про "лишні" події можна буде промовчати пізніше. Список повинен бути систематизованим і посортованим в такий спосіб, щоб читач швидко зрозумів "паттерн" і міг легко орієнтуватись в просторі і часі цього резюме.

EXPERIENCE
2018 Amongst many fighters of the past was featured in the movie "Ready Player One". Ryu ready always!
2017
United with unknown until then to me Power Rangers to defea resurrected M.Bison.Damn good fighters they are, even not knowing karate ways!
2016
In "Street Fighter V" once and for all erased M.Bison from earth and tamed my inner Evil Ryu. Also spent some time on a side-project, mini-series "Street Fighter: Resurrection".
2014
Filmed in a martial arts tutorial "Street Fighter: Assassin's Fist", revealing to audience forgotten art of Ansatsuken.
2012 The gods of intenet concluded me in the animated movie "Wreck-It Ralph", but rewarded me with a good drink for it!
2008
My evil alter ego sneaked out of control and became a boss in "Street Fighter IV".
2006
Borrowed my famous ripped gi to Soki in "Onimusha: Dawn of Dreams", gods informed me he needed that for the battle.
1998
Defeated M. Bison in "Street Fighter Alpha 2", bastard wanted to use my heroic body for his evil intentions, but retreated with shame. Also this year I encountered Marvel universe in "Marvel vs. Capcom: Clash of Super Heroes" fighter,loyal to my employer, Capcom, of course.
1997
Reunited with Ken, my friend and opponent in "Street Fighter III". Men's friendship works mysteriously. Also helped with Arika project "Street Fighter EX"
1996
Took care of villainous Akuma in "Street Fighter Alpha 2". As a freelance on "Super Puzzle Fighter II Turbo" tried myself in a new genre, puzzle games. Let the wrath of seven heavens come upon these malicious enigmas, never again!
1995
Kept fighting in "Street Fighter Alpha: Warriors' Dreams".
1994 Screened in a movie "Street Fighter", so that the batllesof past would not be forgotten by millenial generation.
1991
Was promoted to "Street Fighter II". Didn't stay there for long, celebrations and office dwelling is not for me!
1987
Started working for Capcom project "Street Fighter". My partner was Ken Masters, the boss'name was Sagat.
PUBLICATIONS
2011 The true and humble story of me under pseudonim Tyler Wilde in an article "The evolution of Ken and Ryu"
2003-2018 For 15 years I have published comic books with Udon Entertainment depicting my adventures, bitter lessons and great victories.


(maint) Update internal test forge URI

Analogous to https://github.com/puppetlabs/puppet-agent/pull/1470

jenkins please test this on amazon7-64a,sles11-32a with agent 5.5.x

CLA signed by all contributors.


LoadbyIdandOpenDialog saves as Creat not as Update

Dlg. LoadbyIdandOpenDialog (12345) is retrieving the correct record but when I click save it looks for Create not Update.

Check sample CustomLinksInGrids. This works fine.

Check IdProperty of your column.

of your Row


Add match parameter to transformNull

None is only transformed when the match (another series) has a valid value at the same position.
We have multiple stats that are reported simultaneously and we expect to compare.  Some stats are from dynamic counters, where the counter doesn't exist until the first event is counted.  The service runs periodically with a varying duration, so there are also periods where all stats are None.  In this case we want to transform Nones to 0 only when a report was generated.

The equivalent functionality was added in https://github.com/graphite-project/graphite-web/pull/1322. Thanks for the submission though!


Issue accessing location after making changes or restarting.

I am encountering a issue when trying to use background-location with the simulator after upgrading to ns 3.3 and bg-location to 1.7.0 on IOS. The first time I run the app it prompts ands asks if it should use the location always or only when using the app - All is fine at this point.
If I make any changes or re run the app the location just stops working  and doesn't produce any errors. I am making a call to watchPosition and it doesn't execute success or error callbacks this time round
I am unsure if this is a issue or its related to the simulator.

WARNING:  If you ignore this template, your issue will be too.

Your Environment

Plugin version:
Platform: iOS or Android
OS version:
Device manufacturer / model:
Nativescript version (tns info):
Plugin config

Expected Behavior

Actual Behavior

Steps to Reproduce

Context

Debug logs


Pull request with type [CREATE] for user [bobmn] and object type [TaskSequence] - titled [How to use SMSTSPreserveContent variable]

Automated pull request from the Configuration Manager community hub.

Add the link to online documentation for variable SMSTSPreserveContent inside the task sequence:
https://docs.microsoft.com/en-us/mem/configmgr/osd/understand/task-sequence-variables


Reformatting /* */ as // isn't always desirable

-            let unwrapped_obj = UnwrapObject(obj, /* stopAtOuter = */ 0);
+            let unwrapped_obj = UnwrapObject(obj,
+                                             // stopAtOuter =
+                                             0);

@jdm how often do you do this in Servo? I'm wondering whether we should try to fix this (which would mean adding an option, I don't think there is a general fix that would work here). If it is rare then it could be the sort of thing that is best addressed by #[rustfmt_skip]

It looks like there are only two instances of it in Servo.

Ok, then it is probably something I'd recommend we don't fix. I'll leave the issue open in case someone sees a way to fix it nicely.

I've configured my editor to auto-reformat my files when I save them which means that any code I've commented out gets reformatted:
/*
struct Test;

impl Test {
    fn test() {
        println!("test");
    }
}
*/

To:
// struct Test;
//
// impl Test {
// fn test() {
// println!("test");
// }
// }
//

You can set the option normalise_comments to false to avoid this. If wrap_comments is also false (the default) then rustfmt should avoid this reformatting. Interested to know if it actually does.
Closing this issue because it is fixed by the normalise_comments option.

Any chance this can be disabled by default? I usually use /* */ comments for reasons beyond style (they're more convenient when commenting/uncommenting code). Most projects us the defaults and the defaults really should be safe.

At least until #583 and/or #584 get fixed so I can prevent my commented code from getting flushed to the LHS.

Hmm, a lot of times this is quite a desirable reformatting (at least for me). I'd be wary of changing the default. I'll try and find some time to fix #583 asap.


Features: The Blogs section and Contact us

The  Blog section looks not very attractive and the contact us page is down of the home page which can be assigned to the new page which provides more look to the webpage.
The blog section image is very big and the contents can be arranged like cards.
I would like to work on the issue can you align the issue to me, @tushargupta1504


Add filipdutescu/renamer.nvim

Add a link to filipdutescu/renamer.nvim to the "Editing support" section.
Signed-off-by: Filip Dutescu<EMAIL_ADDRESS>Checklist:

[x] The plugin is specifically built for Neovim.
[x] The lines end with a .. This is to conform to awesome-list linting and requirements.
[x] It's not already on the list.
[ ] It supports treesitter syntax if it's a colorscheme.

Thanks for the PR!

Thank you as well for accepting it!


[Issue] Hurt particles appear when in F1 mode

When disabling the GUI with F1, the hurt particles will still appear when you are hit as if you aren't in F1

Can you specify the game and mod version please?

Minecraft version is 1.21, mod version is 1.1.0


Buttons disappeared

Hi, after the first try all four flic buttons where added and also got the automations to work.
I tried a new Project with mini media player and some scripts for radiostations and also added spotify playlists. I also had to make changes on my configuration.yaml for that.  After this other project the flic buttons stoped working and were not be detected from HA. I don't know if this have to do something with this issue. In the Flic App the buttons are still available. I tried to reinstall the flic hub, but now I only see one deviece (only the hub). I also tried to restard the tcpserver in the sdk. If I press configuration on the flic hub integration I'll get this error:  500 Internal Server Error Server got itself in trouble
Is there anything else which I can check to get the buttons back to home assistant?
Thanks in advanced.

Weirdly enough, I have the same issue. The flic button were unavailable for several days, I checked on the SDK page and the code seems fine there, as far as I can tell :

As @AndyIX89, I can't configure the integration and I have the same 500 error message. In the logs, I noticed this error repeated over and over :
homeassistant  | 2024-04-29 20:50:28.195 WARNING (MainThread) [pyflichub.client] FlicButton.__init__() got an unexpected keyword argument 'boot_id'
homeassistant  | Traceback (most recent call last):
homeassistant  |   File "/usr/local/lib/python3.12/site-packages/pyflichub/client.py", line 152, in data_received
homeassistant  |     self._handle_command(Command(**msg))
homeassistant  |   File "/usr/local/lib/python3.12/site-packages/pyflichub/client.py", line 167, in _handle_command
homeassistant  |     self.buttons = [FlicButton(**button) for button in humps.decamelize(cmd.data)]
homeassistant  |                     ^^^^^^^^^^^^^^^^^^^^
homeassistant  | TypeError: FlicButton.__init__() got an unexpected keyword argument 'boot_id'
homeassistant  | 2024-04-29 20:50:28.197 WARNING (MainThread) [pyflichub.client] Unable to decode received data

Let me know if you need more informations.

I'm having the same problem
2024-05-07 15:58:38.304 WARNING (MainThread) [pyflichub.client] FlicButton.init() got an unexpected keyword argument 'boot_id'
Traceback (most recent call last):
File "/usr/local/lib/python3.12/site-packages/pyflichub/client.py", line 152, in data_received
self._handle_command(Command(**msg))
File "/usr/local/lib/python3.12/site-packages/pyflichub/client.py", line 167, in _handle_command
self.buttons = [FlicButton(**button) for button in humps.decamelize(cmd.data)]
^^^^^^^^^^^^^^^^^^^^
TypeError: FlicButton.init() got an unexpected keyword argument 'boot_id'
2024-05-07 15:58:38.306 WARNING (MainThread) [pyflichub.client] Unable to decode received data
2024-05-07 15:58:44.348 WARNING (MainThread) [pyflichub.client] Waited for 'buttons' data for 10.0 secs.
2024-05-07 15:58:48.297 WARNING (MainThread) [pyflichub.client] Waited for 'buttons' data for 10.0 secs.
2024-05-07 15:58:53.359 WARNING (MainThread) [pyflichub.client] 'NoneType' object has no attribute 'name'
Traceback (most recent call last):
File "/usr/local/lib/python3.12/site-packages/pyflichub/client.py", line 150, in data_received
self._handle_event(Event(**msg))
File "/usr/local/lib/python3.12/site-packages/pyflichub/client.py", line 183, in _handle_event
_LOGGER.debug(f"Button {button.name} was {event.action}")
^^^^^^^^^^^
AttributeError: 'NoneType' object has no attribute 'name'
2024-05-07 15:58:53.361 WARNING (MainThread) [pyflichub.client] Unable to decode received data
2024-05-07 15:58:53.588 WARNING (MainThread) [pyflichub.client] 'NoneType' object has no attribute 'name'
Traceback (most recent call last):
File "/usr/local/lib/python3.12/site-packages/pyflichub/client.py", line 150, in data_received
self._handle_event(Event(**msg))
File "/usr/local/lib/python3.12/site-packages/pyflichub/client.py", line 183, in _handle_event
_LOGGER.debug(f"Button {button.name} was {event.action}")
^^^^^^^^^^^
AttributeError: 'NoneType' object has no attribute 'name'
2024-05-07 15:58:53.590 WARNING (MainThread) [pyflichub.client] Unable to decode received data

Sorry for the delay. An update should be available in just a few minutes.

Thanks for the update, but it did not fix the problem for me. Should I delete the integration and start over or do something else ?


[SPARK-41338][SQL] Resolve outer references and normal columns in the same analyzer batch

What changes were proposed in this pull request?

Today, the way we resolve outer references is very inefficient. It invokes the entire analyzer to resolve the subquery plan, then transforms the plan to resolve UnresolvedAttribute to outer references. If the plan is still unresolved, repeat the process until the plan is resolved or the plan doesn't change any more. Ideally, we should only invoke the analyzer once to resolve subquery plans.
This PR adds a new rule to resolve outer references, and put it in the main analyzer batch. Then we can safely invoke the analyzer only once.
Why are the changes needed?

Simplify the subquery resolution code and make it more efficient
Does this PR introduce any user-facing change?

no
How was this patch tested?

existing tests

cc @viirya @allisonwang-db

thanks for review, merging to master!


replace ioutil.ReadAll with io.ReadAll in README

Everything is in the title. As ioutil is depreciated now, you can update your example in the README.

Updated, thanks.


Dockerfile files syntax highlight

Lapce Version
0.28
System information
Arch Linux
Describe the bug
No automatic syntax highlight for files named Dockerfile without any extension
Additional information
workaround: manually specify the language with the language selector

Already mentioned in https://github.com/lapce/lapce/issues/272 and it's available in 0.2.8

@panekj If it's already available, does it need to be enabled some way? Because Dockerfiles are still not being highlighted "out of the box". Shall I open a separate issue for this?


Parameter issue with hugsql snippets

Our query:
-- :name get-donation-records-from-query :?
SELECT t.*
FROM (
:snip:main-donations-query
) t

ORDER BY :sql:order-col :sql:order-dir, donation_id DESC
LIMIT :limit
OFFSET :offset;

:snip:main-donations-query is a snippet that takes one param.
When we run (db/get-donation-records-from-query-sqlvec query*)
We get
["SELECT t.*
  FROM (
  SELECT * FROM donation
  WHERE donation.account_id IN ($1)
  ) t

  ORDER BY created_at ASC, donation_id DESC
  LIMIT $1
  OFFSET $2;"
 6
 nil
 nil]

Note that there's two $1, meaning the parameters from the hugsql :snip aren't considered as separate. Thus, the error is org.pg.error.PGError: Wrong parameters count: 3 (must be 2)

Hi @kanwei ! I believe this was fixed in [0.1.24], could you please give it a try?

Closing as it has been tested locally. Feel free to reopen if you find any problems.


Bug/chat input

also looks like you have already signed CLA:

@HenryHengZJ fixed the issue for hide text underneath,  when you paste long text in dialog.


Slow unit test execution due to network access

Description:
Unit test execution is really slow down to 131 tests for 14 minutes. Also, note the second attempt at running unit tests show failed network calls when the network was unavailable at the second attempt.

Visual vm profiling

Steps to reproduce:
Affected Versions:
1.2.0
MacOs
OS, DB, other environment details and versions:
Related Issues (optional):

Suggested Labels (optional):

Suggested Assignees (optional):

Fixed with https://github.com/ballerina-platform/ballerina-lang/pull/22118


Update StatusTag.jsx to add support for providing other styles

I want to be able to add borders and other such styles to some of the tags. This supports that aim.

Nice! Can you add some documentation to the readme to support this?

Closing for lack of activity


Fix persistence & restoration of Naive Bayes models

It seems that #9 has caused projects using github.com/cdipaolo/sentiment to break. I've found out the reason is that the new concurrentMap is no longer a simple map that Go knows how to un/marshal out of the box.
This pull request implements the necessary functions for concurrentMap so that the Restore() function works again.

Thanks a bunch for catching this and fixing it :shipit:!!! I really appreciate it. The reason this was overlooked (retroactively thinking) was because there was no persistence test for the NaiveBayes model (it was forgotten). I've added a test now so we won't have this problem again in the future.
:cat:


Support awaiting on non-MainActor and add awaiting tests

Splits IAsync***.get() into two methods: one for awaiting with the MainActor and one without. The latter will allow awaiting in unit tests where there might not be a MainActor running a message loop.
Fixes errors/cancelations not being surfaced on IAsyncActions after awaiting
Adds tests for awaiting IAsyncOperations: success vs failure cases, and "already completed" vs suspension cases.
Fixes WIN-842

I had a green arc build using this change. I think the previous errors I had seen there were unrelated (there were warnings of bad threading around boosts code which was unrelated from uses of await on WinRT objects.
Build here: https://github.com/thebrowsercompany/swift-winrt/actions/runs/6721274646/job/18266648563#step:5:228
Validation here: https://github.com/thebrowsercompany/arc/pull/18840/files


CB-1713: Add SDX ha blueprint to CB.

We need to have an SDX blueprint for HA deployment. Scope of this Jira to get an initial version and make improvements as we go.
Made sure that cloudbreak is able to set up a CM cluster using the blueprint.

Can one of the admins verify this patch?

Closing this pull request. A new pull request will be created addressing the comment.


Support syntax highlighting for more languages

Solves #768

The problem is that I should not use the latest rulesets since syntect does not support Sublime Text's latest version yet.

Use default features of syntect can solve the problem.

Where does the syntaxes.bin come from?

I compiled the binary syntax file using modified bat source code via syntect's dump function.

https://github.com/trishume/syntect/pull/470 has been merged, but we still need to wait for a new release of syntect.

Since Typst isn't on crates.io, we can also switch to the git version of syntect for now. However, it is unclear to me under what license terms we would use syntaxes.bin here.

For the license terms, we can refer to https://github.com/Canop/broot/tree/main/resources/syntect.

The syntax file is now generated a bit differently to be compatible with the current dependency settings.
The following syntaxes are disabled due to compatibility issues:

syntaxes/02_Extra/Assembly (ARM).sublime-syntax
syntaxes/02_Extra/Elixir/Regular Expressions (Elixir).sublime-syntax
syntaxes/02_Extra/JavaScript (Babel).sublime-syntax
syntaxes/02_Extra/LiveScript.sublime-syntax
syntaxes/02_Extra/PowerShell.sublime-syntax
syntaxes/02_Extra/SCSS_Sass/Syntaxes/Sass.sublime-syntax
syntaxes/02_Extra/SLS/SLS.sublime-syntax
syntaxes/02_Extra/VimHelp.sublime-syntax
syntaxes/02_Extra/cmd-help/syntaxes/cmd-help.sublime-syntax

Here the syntaxes directory refers to https://github.com/sharkdp/bat/tree/master/assets/syntaxes
Code for syntax set generation:
fn main() {
    let mut builder = syntect::parsing::SyntaxSet::load_defaults_nonewlines().into_builder();
    builder.add_from_folder("syntaxes/02_Extra", false).unwrap();
    let syntax_set = builder.build();
    syntect::dumps::dump_to_file(&syntax_set, "syntaxes.bin").unwrap();
}

@reknih @laurmaedje Please review the changes.

When generating the syntax set, lines_include_newline = false is used. According to https://github.com/trishume/syntect/blob/b5212417475f678706bdc243d7adbf99b26923bd/src/parsing/syntax_set.rs#L471, this might not work correctly for some syntaxes. But I have not found any examples (where this setting fails) yet.
However, if we use lines_include_newline = true, I did find some cases that the syntax highlighting cannot work correctly, e.g., the following Julia code,
# comment
function f() # comment
    2 # comment
end

will be completely rendered as comments.
This can be solved by tweaking https://github.com/typst/typst/blob/4b17c3f5c65a3ec87719d3c39d270767140e3767/library/src/text/raw.rs#L186 and adding a newline manually, but that would lead to other new issues. So I gave up and used lines_include_newline = false for now.

In the future, I think we should design something like bat's asset cache for both syntaxes and themes so that users can add new syntaxes or themes themselves.

@lucifer1004 It seems we have to annotate the type as rust compiler suggests:
   --> library/src/text/raw.rs:314:5
    |
314 |     Lazy::new(syntect::parsing::SyntaxSet::load_defaults_nonewlines);
    |     ^^^^^^^^^ cannot infer type of the type parameter `T` declared on the struct `Lazy`
    |
help: consider specifying the generic arguments
    |
314 |     Lazy::<T, _>::new(syntect::parsing::SyntaxSet::load_defaults_nonewlines);
    |         ++++++++

For more information about this error, try `rustc --explain E0282`.
error: could not compile `typst-library` due to previous error

I changed the line to make it work:
Lazy::<syntect::parsing::SyntaxSet>::new(syntect::parsing::SyntaxSet::load_defaults_nonewlines);

Thanks!

Do you remember what was the issue with the PowerShell syntax file? I'd like to get PowerShell highlighting working in Typst for my thesis.

Do you remember what was the issue with the PowerShell syntax file? I'd like to get PowerShell highlighting working in Typst for my thesis.

You can find a fixed powershell syntax here.


Electron failed to install correctly, please delete node_modules/electron and try installing again

Anyone can help me to fix this problem ?
0 info it worked if it ends with ok
1 verbose cli [ '/usr/bin/node', '/usr/bin/npm', 'start' ]
2 info using<EMAIL_ADDRESS>3 info using<EMAIL_ADDRESS>4 verbose run-script [ 'prestart', 'start', 'poststart' ]
5 info lifecycle<EMAIL_ADDRESS><EMAIL_ADDRESS>6 silly lifecycle<EMAIL_ADDRESS>no script for prestart, continuing
7 info lifecycle<EMAIL_ADDRESS><EMAIL_ADDRESS>8 verbose lifecycle<EMAIL_ADDRESS>unsafe-perm in lifecycle true
9 verbose lifecycle<EMAIL_ADDRESS>PATH: /usr/lib/node_modules/npm/bin/node-gyp-bin:/home/pi/MagicMirror/node_modules/.bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/usr/local/games:/usr/games
10 verbose lifecycle<EMAIL_ADDRESS>CWD: /home/pi/MagicMirror
11 silly lifecycle<EMAIL_ADDRESS>Args: [ '-c', 'sh run-start.sh' ]
12 silly lifecycle<EMAIL_ADDRESS>Returned: code: 1  signal: null
13 info lifecycle<EMAIL_ADDRESS>Failed to exec start script
14 verbose stack Error<EMAIL_ADDRESS>start: sh run-start.sh
14 verbose stack Exit status 1
14 verbose stack     at EventEmitter. (/usr/lib/node_modules/npm/lib/utils/lifecycle.js:255:16)
14 verbose stack     at emitTwo (events.js:106:13)
14 verbose stack     at EventEmitter.emit (events.js:191:7)
14 verbose stack     at ChildProcess. (/usr/lib/node_modules/npm/lib/utils/spawn.js:40:14)
14 verbose stack     at emitTwo (events.js:106:13)
14 verbose stack     at ChildProcess.emit (events.js:191:7)
14 verbose stack     at maybeClose (internal/child_process.js:920:16)
14 verbose stack     at Process.ChildProcess._handle.onexit (internal/child_process.js:230:5)
15 verbose pkgid<EMAIL_ADDRESS>16 verbose cwd /home/pi/MagicMirror
17 error Linux 4.9.67-v7+
18 error argv "/usr/bin/node" "/usr/bin/npm" "start"
19 error node v6.12.1
20 error npm  v3.10.10
21 error code ELIFECYCLE
22 error<EMAIL_ADDRESS>start: sh run-start.sh
22 error Exit status 1
23 error Failed at the<EMAIL_ADDRESS>start script 'sh run-start.sh'.
23 error Make sure you have the latest version of node.js and npm installed.
23 error If you do, this is most likely a problem with the magicmirror package,
23 error not with npm itself.
23 error Tell the author that this fails on your system:
23 error     sh run-start.sh
23 error You can get information on how to open an issue for this project with:
23 error     npm bugs magicmirror
23 error Or if that isn't available, you can get their info via:
23 error     npm owner ls magicmirror
23 error There is likely additional logging output above.
24 verbose exit [ 1, true ]

Please refer to http://forum.magicmirror.builders for support and troubleshooting.
I'm closing this issue for now. If you feel this issue should remain open, please let me know.


Triangles are not in their places

How can I fix this?

Hi @flomaster9 !
Please have a look at our troubleshooting wiki page. If that does not help you, I am afraid this is a font issue then..

Yeah, this looks to me like you are using Apple's Term.app, which has known issues rendering things properly.
Were you able to get this fixed, perhaps by using iTerm2?

@flomaster9 Can you tell which font you are using? Is it a nerd font? If so we are working on some fixes for the positioning

I have this issue with a nerd-font, in particular 'DroidSansMonoForPowerline Nerd Font Book', the non-Mono variant. With the Mono variant, the gaps are collapsed; however, then the glyphs are way too small as per #430

Found another reference ryanoasis/nerd-fonts#26


Optimize static memory pools

This patch enables the optimization of the static memory pools emitted by the bundling pass.
Two krnl.getref operations can share the same slot in the memory pool if several conditions are met:

Same memory footprint: this includes the case where the MemRefs they produce have different shapes. Example: memref<3x4xf32> and memref<2x6x4xi8> occupy the same memory.
Not in the same krnl.memcpy: there is no krnl.memcpy which uses both. A krnl.memcpy is equivalent to a load from the source of the memcpy followed by a store to the destination of the memcpy.
Mutually disjoint load-store chains: the stored values in one of the resulting MemRefs must not have been computed using loads from the other resulting MemRefs. When a new krnl.getref is added to the same memory slot, it needs to be mutually disjoint with each of the other MemRefs already sharing that memory slot.
Live ranges must not intersect: a live range is the chain of instructions between the first and last load/store/memcpy instruction that uses a krnl.getref. This covers the case where krnl.getref uses are not linked by a load-store chain but are live at the same time.
Live range endpoints cannot appear in the same loop nest: live ranges as defined above may not intersect but instead they may start or end under the same loop (in our case krnl.iterate). To mitigate this case we ensure that the endpoints of the two krnl.getref operations do not share the same outermost loop.

Example:
Considering the following static memory pool usage:
    %1 = alloc() : memref<2000xi8>
    %2 = "krnl.getref"(%1, %c1600_i64) : (memref<2000xi8>, i64) -> memref<10x10xf32>
    %3 = "krnl.getref"(%1, %c1200_i64) : (memref<2000xi8>, i64) -> memref<10x10xf32>
    %4 = "krnl.getref"(%1, %c800_i64) : (memref<2000xi8>, i64) -> memref<10x10xf32>
    %5 = "krnl.getref"(%1, %c400_i64) : (memref<2000xi8>, i64) -> memref<10x10xf32>
    %6 = "krnl.getref"(%1, %c0_i64) : (memref<2000xi8>, i64) -> memref<10x10xf32>

Example of MemRefs which do not satisfy this rule (MemRefs %4 and %5, the values of MemRef %4 are computed using values from MemRef %5):
        %14 = affine.load %arg0[symbol(%arg2), symbol(%arg4)] : memref<10x10xf32>
        %15 = affine.load %5[symbol(%arg4), symbol(%arg3)] : memref<10x10xf32>
        %16 = affine.load %4[symbol(%arg2), symbol(%arg3)] : memref<10x10xf32>
        %17 = mulf %14, %15 : f32
        %18 = addf %16, %17 : f32
        affine.store %18, %4[symbol(%arg2), symbol(%arg3)] : memref<10x10xf32>

Example of MemRefs which satisfy the second rule (MemRefs %4 and %6):
    %7:2 = krnl.define_loops 2
    krnl.iterate(%7#0, %7#1) with (%7#0 -> %arg2 = 0 to 10, %7#1 -> %arg3 = 0 to 10) {
      affine.store %cst, %6[symbol(%arg2), symbol(%arg3)] : memref<10x10xf32>
      %13 = krnl.define_loops 1
      krnl.iterate(%13) with (%13 -> %arg4 = 0 to 10) {
        %14 = affine.load %arg0[symbol(%arg2), symbol(%arg4)] : memref<10x10xf32>
        %15 = affine.load %arg1[symbol(%arg4), symbol(%arg3)] : memref<10x10xf32>
        %16 = affine.load %6[symbol(%arg2), symbol(%arg3)] : memref<10x10xf32>
        %17 = mulf %14, %15 : f32
        %18 = addf %16, %17 : f32
        affine.store %18, %6[symbol(%arg2), symbol(%arg3)] : memref<10x10xf32>
      }
    }
    %8:2 = krnl.define_loops 2
    krnl.iterate(%8#0, %8#1) with (%8#0 -> %arg2 = 0 to 10, %8#1 -> %arg3 = 0 to 10) {
      %13 = affine.load %arg0[symbol(%arg2), symbol(%arg3)] : memref<10x10xf32>
      %14 = affine.load %6[symbol(%arg2), symbol(%arg3)] : memref<10x10xf32>
      %15 = addf %13, %14 : f32
      affine.store %15, %5[symbol(%arg2), symbol(%arg3)] : memref<10x10xf32>
    }
    %9:2 = krnl.define_loops 2
    krnl.iterate(%9#0, %9#1) with (%9#0 -> %arg2 = 0 to 10, %9#1 -> %arg3 = 0 to 10) {
      affine.store %cst, %4[symbol(%arg2), symbol(%arg3)] : memref<10x10xf32>
      %13 = krnl.define_loops 1
      krnl.iterate(%13) with (%13 -> %arg4 = 0 to 10) {
        %14 = affine.load %arg0[symbol(%arg2), symbol(%arg4)] : memref<10x10xf32>
        %15 = affine.load %5[symbol(%arg4), symbol(%arg3)] : memref<10x10xf32>
        %16 = affine.load %4[symbol(%arg2), symbol(%arg3)] : memref<10x10xf32>
        %17 = mulf %14, %15 : f32
        %18 = addf %16, %17 : f32
        affine.store %18, %4[symbol(%arg2), symbol(%arg3)] : memref<10x10xf32>
      }
    }

The number of krnl.getref operations must be preserved because each one of the getref operations sharing a memory pool slot may return a MemRef with a different shape (dimensions or even rank). When collapsing getrefs into the same memory slot, more than one getref may be collapsed at a time.

Left a couple of questions. At a general level, can you also comment on why you requires the sizes to be the same for merging? I can see how one would first try to merge all identical ones, and then progressively the ones that are most similar in sizes (e.g. 1000 would fit in 1001 bytes).

Very good point. For now I have only tried precise sizes for simplicity. This way I can compare the new incoming candidate size with any of the existing getRefs sharing that slot instead of having to keep track of the maximum MemRef size for a given slot.

@AlexandreEichenberger I have gathered together in KrnlSupport.cpp/hpp all the helper functions that are used at the level of abstraction of the Krnl Dialect. As a consequence passes in Transforms no longer have a dependency on the ONNXToKrnlCommon.cpp/hpp files which was not desirable. This means we can drop the ONNX dialect dependency that we had when working on krnl transformations due to the use of the ONNXToKrnlCommon.cpp/hpp files.


Jenkinsfile bug and prepare for 2.5.0 release

Description
Jenkinsfile bug and prepare for 2.5.0 release
Issues Resolved
Part of https://github.com/opensearch-project/opensearch-k8s-operator/issues/709 and https://github.com/opensearch-project/opensearch-k8s-operator/issues/674
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

This image is not available in

Please check

also update the versions of supported opensearch that can be installed.

alos i see that operator 2.5.0 uses statefulset ondelete strategy, please update the same in docs too.

Hey @vipinjn24 please check the the workaroud I have posted here https://github.com/opensearch-project/opensearch-k8s-operator/issues/709#issuecomment-1922632388, also to fix this I have a raised a PR for 2.5.1 release.
https://github.com/opensearch-project/opensearch-k8s-operator/pull/716


add linters and publish action

Description
Add Linters to github action workflows
Issues Resolved

Check List

[ ] All tests pass.
[ ] All style checks pass.
[ ] Functionality includes testing.
[ ] Functionality has been documented in the README if applicable

@kasif-adnan can you copy over the CODEOWNERS file from hyperv too, please?


Selecting mean from relation (edge) property

I'm trying to select aggregation by edge relation. Is it even possible?
I have object with relation to opinions. Each opinion holds rating field. I want to have list of objects with average rating attached to them.
What I came up with is something like below, but it still gives me full opinions list instead of just average rating. And I kind of know what I'm doing wrong, but I don't know how to change it to return what I need.
objects := client.Object.Query().
    WithOpinions(func(oq *ent.OpinionQuery) {
        var v []struct {
            Mean int `json:"mean"`
        }
        oq.GroupBy(opinion.ObjectColumn).Aggregate(ent.Mean(opinion.FieldRating)).Scan(ctx, &v)
    }).
    Limit(20).
    AllX(ctx)

Anyone able to help here?

@a8m tagging you as requested on Slack

Hey @Morishiri and thanks for opening this issue. I added an example on the documentation on how to do such queries.
Please update to the latest master in order to run such examples, as I added a fix in https://github.com/ent/ent/pull/1478.
go get -u entgo.io/ent@master

Let me know if you need further help with it or we can close the issue. Thanks 🙏

Hey @a8m, thanks for all your work here! Great to see such fast answer.
I'm however still having trouble. In your example pet doesn't have ID column. In my case both entities have it and I'm getting pq: column reference "id" is ambiguous when using it like this:
var objects []struct {
	ID      int     `json:"id"`
	Average float64 `json:"average"`
}

database.Client.Object.Query().
	Limit(limit).
	GroupBy(object.FieldID).
	Aggregate(func(s *sql.Selector) string {
		t := sql.Table(opinion.Table)
		s.Join(t).On(s.C(object.FieldID), t.C(opinion.ObjectColumn))
		return sql.As(sql.Avg(t.C(opinion.FieldRating)), "average")
	}).
	ScanX(c.Context(), &objects)

How can I specify the correct field so it's no longer ambiguous?

Hey @Morishiri, what ent version do you use? You can check this with:
go list -m entgo.io/ent

Can you try to update to the latest master using go get entgo.io/ent@master, re-run the codegen, and report if that still happens?

BTW, you're welcome to share with me an example-repo and I can help with this there.

 Thanks! You can close the issue :)

@a8m while we are still in the topic. is it possible to maybe order by aggregated field? I'm able to write such query, but it looks like Order methods are not generated for Aggregation.

You can add this to your custom aggregation function as follows:
client.User.Query().
	GroupBy(user.FieldID).
	Aggregate(func(s *sql.Selector) string {
		t := sql.Table(pet.Table)
		s.Join(t).On(s.C(user.FieldID), t.C(pet.OwnerColumn))
+		s.OrderBy("average")
		return sql.As(sql.Avg(t.C(pet.FieldAge)), "average")
	}).
	ScanX(ctx, &users)

Closing, but please feel free to continue the discussion if you still have questions on this topic. Also, if you're interested to get ~monthly updates on our new releases and features, subscribe to our newsletter 🙏


1.12.1 Client crash while looking at a placed Bibliocraft clipboard

I have the baubles one probe on. I placed a clipboard on the side of a Extra Utilities 2 indexer. After placing it I crashed to desktop. I was able to log back into the smp server by moving my mouse while logging in to not look at the clipboard.
Full crash: https://pastebin.com/rTa17YLz
Modpack: Modern Skyblock 2 v2.4.4
MC: 1.12.1
TOP: 1.4.18
Bibliocraft: v2.4.3
Forge: 2484

Looks like a bug in BiblioCraft. Report to them as well

https://github.com/Nuchaz/BiblioCraft/issues/510

I'm having this issue as well.  When I get to close to the clipboard it crashes the game.  Posted on Oneprobe and Bibliocraft.
crash-2018-05-03_19.36.25-client.txt

Issue was fixed on BiblioCraft side, so this one could be closed


Pagespeed caching breaks javascript

I am on a Wordpress site, some of the javascript files are malfunctioning after caching. I am not sure if its the CSS's not loading correctly or the Javascripts being disrupted. Can you send me some light to see what's up ? Not sure what filter is causing it. I am also using cloudflare. Here are my filters :
pagespeed on;
Needs to exist and be writable by nginx.  Use tmpfs for best performance.
pagespeed FileCachePath /tmp/pagespeed;
location ~ ".pagespeed.([a-z].)?[a-z]{2}.[^.]{10}.[^.]+" {
add_header "" "";
}
location ~ "^/pagespeed_static/" { }
location ~ "^/ngx_pagespeed_beacon$" { }
#Enable HTTPS
pagespeed FetchHttps enable;
#HTTPS certificates
pagespeed SslCertDirectory /etc/ssl/private;
pagespeed SslCertFile cert_chain.crt;
#pagespeed ModifyCachingHeaders on;
pagespeed RewriteLevel CoreFilters;
#pagespeed RewriteLevel PassThrough;
pagespeed EnableFilters prioritize_critical_css;
pagespeed EnableFilters make_google_analytics_async;
pagespeed EnableFilters move_css_to_head;
pagespeed EnableFilters move_css_above_scripts;
pagespeed EnableFilters outline_javascript;
pagespeed EnableFilters outline_css;
pagespeed EnableFilters defer_javascript;
pagespeed EnableFilters insert_dns_prefetch;
pagespeed EnableFilters combine_css;
pagespeed EnableFilters combine_javascript;
pagespeed EnableFilters convert_meta_tags;
Thanks !

Seems that the cached version is a version where part of a relevant .js is is still not loaded ?

I just tested disabling cloudflare first, then deactivating and cleaning the cache of pagespeed and all is back to normal. So cloudflare seems to not be the issue, Is there any way to debug or fine tune wich filter can be causing this ?

Can you describe in more detail the symptom you observed on your site?
That might help us identify which filter is causing trouble.
Another approach is to start with PassThrough and enable filters one at a
time until the problem appears.  In your case if you feel the problem is
JavaScript related, you can just focus on the three filters with
"javascript" in their name.
Of the filters you've enabled, defer_javascript is inherently the most
risky, so I might start with that one.
-Josh
On Wed, Nov 4, 2015 at 7:52 AM, chromafunk<EMAIL_ADDRESS>wrote:

I just tested disabling cloudflare first, then deactivating and cleaning
the cache of pagespeed and all is back to normal. So cloudflare seems to
not be the issue, Is there any way to debug or fine tune wich filter can be
causing this ?
—
Reply to this email directly or view it on GitHub
https://github.com/pagespeed/ngx_pagespeed/issues/1038#issuecomment-153712151
.

For example, at the home page there is a background row with a youtube video on full screen. The video and text does not show up. There is also a cart box made with Jquery that slides down when you hover over it, and it is completely out as if it was locked open on hover. Other Jquery navigational interfaces don't load either.

Try turning defer_javascript off.
On Wed, Nov 4, 2015 at 8:34 AM, chromafunk<EMAIL_ADDRESS>wrote:

For example, at the home page there is a background row with a youtube
video on full screen. The video and text does not show up. There is also a
cart box made with Jquery that slides down when you hover over it, and it
is completely out as if it was locked open on hover. Other Jquery
navigational interfaces don't load either.
—
Reply to this email directly or view it on GitHub
https://github.com/pagespeed/ngx_pagespeed/issues/1038#issuecomment-153720630
.

Actually, just before posting this, defer_javascript was off already.  It was maybe the combine javascript one then ? I will try it out.

It finally was rocket loader @Cloudflare ... What is rocket loader exactly ? Defer Parsing of JS ?


replace babel-preset-es2015 (deprecated) by babel-preset-env

Short description of what this PR does:

replaces babel-preset-es2015 (deprecated) by babel-preset-env
add testing voor nodejs 10

Checklist

[x ] I have made a material change to the repo (functionality, testing, spelling, grammar)
[x ] I have read the [Contribution Guide] and my PR follows them.
[x ] I updated my branch with the master branch.
[x ] I have added tests that prove my fix is effective or that my feature works
[x ] I have added necessary documentation about the functionality in the appropriate .md file
[x ] I have added inline documentation to the code I modified

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Add documentation for writing E2E tests

Fixes https://github.com/kubeflow/tf-operator/issues/822

This change is

/assign @jlewi

Coverage remained the same at 57.037% when pulling<PHONE_NUMBER>63b769f8774c39da99ee91cf6bb90f on richardsliu:e2etest_doc into f86a3112197a08eb985742c98877becc35ad3e18 on kubeflow:master.

@johnugeorge Feel free to cancel the hold to merge it.

Looks good
/hold cancel


New token structure

Nice job @kosecki123!
I see you doing 4 things here:

approval of each action issue/claim/transfer
as I understand you want to make it NFT
make issuance and claims private
reveal the private issuance/claim into a "normal" certificate as you wrote in one TODO: zk proofs that issuance commitment - revealed claims < toBeRevealed claim

What would you say if we would make proposed improvements modular that sit on top of proposed standard for clarity (examples):

approval is a separate contract (can be inherited by the global registry) or consider that permissioning and request potentially can be solved in a clean way with just identity (Certifying Authority) where you send execution request (i.e. based on ERC-735), and with right key can check and approve that call, this way will leave room for future improvements for that functionality.

as I understand you want to make it NFT, but with value = X MWh, where X is hidden within commitment and where each action creates a verifiable commitment that then can fallback to / be exchangeable to ERC-1888 (NFT+FT)?

"privateIssuance", "privateTransfer" and "privateClaim" can be used in a separate contract sitting on top of the ERC-1888 and fall back to "normal" certificate when needed? As this would require custom circut (remember about 2 different balances), perhaps we can assume that only "privateIssuance", "privateTransfer" are needed (and therefore only balance will be private) and when you claim you actually want to reveal the value (claimedBalance)?

Current draft to be compliant with underlying ERC-1155 needs following:

the (NFT) token has to have balance/value 1, when minted
the token has to be transfered from 0x00 to owner

Regarding compliance with ERC-1888:
claim = transfer from owner to 0x00, decrease balance, increase claimedBalance
Claim according to ERC-1888 aim to eventually make the certificates non-transferable (certificates have 2 balances, balance and claimedBalance), but with  claimed balance in the state to allow for automation.
I don't understand what do you mean by claim in your draft?
Awesome work!

Also you while for your preciseProofs the order is important (as there is a strict scheme) in this case you want to just store balances (order is not important ?), therefore you will need simple merkle proof (without specifying which side of the branch is that), and you can get rid of boolean left and use openzeppelin's verification of merkle proof.
https://github.com/OpenZeppelin/openzeppelin-contracts/blob/master/contracts/cryptography/MerkleProof.sol

The reason for splitting the private and public functionalities is that, usually the privacy schemes work on a basis of a separate layer where you deposit the tokens to a smart contract from where you can privately move it and then later withdraw it when needed...
https://ethresear.ch/t/ethereum-9-send-erc20-privately-using-mimblewimble-and-zk-snarks/6217


dunst: fix 1.6.1 src and build

The previous bump to version 1.6.1 left the sha256 of the src attribute
unchanged, and as a consequence, it still built the old version.
But since the make config injected the version number, the binary still
self-reported as 1.6.1, even though it was built from 1.5.0.
I found this because I tried for an hour to get the new progress bar feature to work without success, now I know why.
As a drive-by, I also removed the dunstify option, as it was no longer effective because make install now always includes it, as remarked in https://github.com/NixOS/nixpkgs/pull/93731#issuecomment-663864072.

Motivation for this change
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[x] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

pinging @tuxinaut @marsam based on the last PR.

@fatho at first sorry for wasting your time :sob: Thank you very much for discovering and fixing this "nasty" bug. No clue why I forgot to change the SHA256 sum :shrug:

@tuxinaut Don't worry, it's not wasted, as at least this PR came out of it :slightly_smiling_face:


Uses clap builder to parse kernel arguments

The reason is because clap derive does not supports default value from Default trait (AFAIK), which we required for IDPS.

maybe default_value_t = Default::default?

Also, have you tried this?

maybe default_value_t = Default::default?

Not working.

Also, have you tried this?

Not tried without = yet but I think the builder pattern is better here because it does not require std::fmt::Display implementation on the type.


Add inline type hints

A couple review notes:

I removed python 3.5 support as a) that's very very deprecated, and b) variable type hints would make this much worse.
I recommend you try to check this against a codebase that uses this, as I may have forgotten to make a type as wide as the docs promise!

Sorry for the large PR, but I wanted to upstream my stubs (and make sure they were right -- after all, this way you yourself can run mypy and find things!)
BTW, if I bump the python version to 3.7 in mypy's configuration, I get all these issues from the wsproto event dataclasses currently ignored:
trio_websocket/_impl.py:821: error: Argument "host" to "Request" has incompatible type "Optional[str]"; expected "str"  [arg-type]
trio_websocket/_impl.py:821: error: Argument "target" to "Request" has incompatible type "Optional[str]"; expected "str"  [arg-type]
trio_websocket/_impl.py:822: error: Argument "subprotocols" to "Request" has incompatible type "Optional[Iterable[str]]"; expected "List[str]"  [arg-type]
trio_websocket/_impl.py:823: error: Unused "type: ignore" comment
trio_websocket/_impl.py:947: error: Unused "type: ignore" comment
trio_websocket/_impl.py:1016: error: Unused "type: ignore" comment
trio_websocket/_impl.py:1031: error: Unused "type: ignore" comment
trio_websocket/_impl.py:1031: error: Argument "payload" to "Pong" has incompatible type "Optional[bytes]"; expected "bytes"  [arg-type]
trio_websocket/_impl.py:1046: error: Unused "type: ignore" comment
trio_websocket/_impl.py:1049: error: Unused "type: ignore" comment
trio_websocket/_impl.py:1079: error: Unused "type: ignore" comment
trio_websocket/_impl.py:1102: error: Unused "type: ignore" comment
trio_websocket/_impl.py:1107: error: Unused "type: ignore" comment
trio_websocket/_impl.py:1122: error: Unused "type: ignore" comment
trio_websocket/_impl.py:1256: error: Unused "type: ignore" comment
Found 15 errors in 1 file (checked 3 source files)

However, I do not want to fix them (similar to how I just added TODOs to things that were Optional and shouldn't be), as that would make the scope of the PR too broad; these could be follow-up changes!
Additionally, this might make a potential port to anyio easier since you will know what types to update!

Pull Request Test Coverage Report for Build 202

137 of 144 (95.14%)  changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.6%) to 95.135%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

trio_websocket/_impl.py
136
143
95.1%

Totals

Change from base Build 187:
-0.6%

Covered Lines:
528

Relevant Lines:
555

💛  - Coveralls

I am very sorry I left this out to dry for so long. I'm here to try to push this through, although it may take a bit more work.
Here's some reasons why it's useful to have type hints in the library:

Detects (some) bugs. This is always nice. IMO users of the library will benefit moreso than someone who knows the library inside and out, but whatever.
Keeps documented types up to date (I would be OK sending a PR that updates the documentation to match the types I have here)
The locality makes it easier to check the types against the code (I realize stubcheck exists in mypy but I'd rather not go there)
Autocomplete in IDEs is always nice.

It's been a solid couple months so I will have to get re-adjusted to everything, but I'll take a look to see if something can be done about the additional dependencies and I'll bring this up to date. I'd love a re-review (and will be requesting another review after I have done everything I need to)

trio-websocket is kind of on life support, and I'm the closest thing to a maintainer.  When something does come up that needs attention, I can barely get to it.  I'd prefer not to include "fighting with the type system" as more obstacles to my future self.  There's are a number of areas the library could use improvement if there were time, but I wouldn't rank typing too high-- and in any case there are not enough actual users (of trio-websocket or trio) to warrant the work.
I appreciate that you've spent time on this-- but I had mentioned I'm hesitant, and hope I didn't mislead you into investing more time.

Ah, shame. I was planning on trying to combine wsproto with httpx's streams anyways (would support anyio + have less deps), just wanted to finish this up in case people wanted it.
Thanks for the notice though, yup!


sourcemap of import not served/deployed

Hi,
Really liking playing around with Framework, congrats on an awesome release!
We might like sourcemaps to go out of fashion(?) but I generate ESM and keep a sourcemap.
I'm importing that ESM using a regular import:
import * as model from './cul/calcs_esm/cul_scope_0.js'
The file ends with //# sourceMappingURL=cul_scope_0.js.map: a reference to the sourcemap file, but because this file isn't deployed (to dist or to observablehq.cloud) or served (with npm run dev), then it isn't available to devtools - see error:

Should/can Framework detect and serve sourcemaps?
On Quarto I include sourcemap files as a resource and they gets served - this could be a workaround, but might need to be a more particular one given Frameworks directory structure (_file, _import etc.)
Thanks!
Declan

Yes we hope to add sourcemaps in the future (see e.g. #805).

Yes, I think it would be reasonable to check for //# sourceMappingURL=… and include the referenced file in dist on build.


[Question]: Docx parse erroe

Describe your problem
When I upload a docx file and parse it, there is a error.
[ERROR]Internal server error: not enough values to unpack (expected 2, got 0)

Perhaps this is related to the content of my file. Due to certain reasons, my docx file is composed of images pieced together, with each page featuring an image filled with text, representing the official content like this:

Is there any way to parse these files using Ragflow?

fixed

fixed

The pr just fixed error occured, the paser still can't extract any text.


Make displayed Web errors more meaningful

Updates the code to display an error to not only show the message, but the context as well.

Before
After

Are we ok with "??" https://caniuse.com/?search=%3F%3F
Without need for msg it could be even:
	function displayFailureNotice(err) {
		console.error(err);
		setStatusNotice(err.message ?? err);
		setStatusMode('notice');
		initializing = false;
	}

Are we ok with "??" https://caniuse.com/?search=%3F%3F

Indeed, I missed that, what's the rationale for chaining to ???

Are we ok with "??" https://caniuse.com/?search=%3F%3F

Indeed, I missed that, what's the rationale for chaining to ???

?? is the new standard to test if a value exists or not. In the code changed, if err.message === "", it will resort back to err even if "" is a valid message, all because "" is a falsy value (which the or tests). The nullish operator (which is pretty much supported by all browsers since 2020) tests only if it's nullish, not if it's falsy.

Ah yes, ?? is better in this case, because:
const err = { message: "" };
const msg = err.message ?? err;
console.log(msg); // Outputs: ""

and || will break setStatusNotice
const err = { message: "" };
const msg = err.message || err;
console.log(msg); // Outputs: { message: "" }

@patwork @Faless I updated my code finally, to make sure that setStatusNotice() is well set. Maybe overkill, but it will work.
function displayFailureNotice(err) {
	console.error(err);
	if (err instanceof Error) {
		setStatusNotice(err.message);
	} else if (typeof err === 'string') {
		setStatusNotice(err);
	} else if (typeof err === 'object' && err.toString === 'function') {
		setStatusNotice(err.toString());
	} else {
		setStatusNotice('An unknown error occured');
	}
	setStatusMode('notice');
	initializing = false;
}

I guess we can assume that err will be either string or Error().
This could potentially get us "[Object Object]" or similiar:
	} else if (typeof err === 'object' && typeof err.toString === 'function') {
		setStatusNotice(err.toString());

It is better to write right away that it is an unknown error.
a= new Promise(() => {});
typeof a;
"object"
a.toString();
"[object Promise]"

Thanks!


ci: adbc-driver-snowflake-test fails on SnowflakeConnectionTest.MetadataGetObjectsColumns

What happened?
On several PRs the Snowflake Integration Tests job seems to fail:

https://github.com/apache/arrow-adbc/actions/runs/8878797658/job/24375724410#logs
https://github.com/apache/arrow-adbc/actions/runs/8878797658/job/24375724410

The error is:
 /home/runner/work/arrow-adbc/arrow-adbc/c/validation/adbc_validation_connection.cc:824: Failure
Value of: found_expected_table
  Actual: true
Expected: false
Google Test trace:
/home/runner/work/arrow-adbc/arrow-adbc/c/validation/adbc_validation_connection.cc:758: Filter: (no filter)

[  FAILED  ] SnowflakeConnectionTest.MetadataGetObjectsColumns

How can we reproduce the bug?
No response
Environment/Setup
No response

@zeroshade any idea?

at some point between our toying with the all of the casing and quotes, we ended up with two tables in the ADBC_TESTING db: bulk_ingest and  BULK_INGEST. Since we do our comparison as a case-insensitive comparison, we ended up finding the table twice and failing.
I've removed the duplicate table from our snowflake instance and the test succeeds locally, so it should succeed on here too.

And there we go. I re-ran the job and we have success:

Thanks!


outline view clashes with "show references" slidebar.

Cosmetic issues (low priority):
The "References" sidebar shows up outside the outline view sidebar, and the tops don't line up. Maybe it should show up inside the outline view sidebar?
Also, the space available for code gets shrinks when the "References" view shows up, because there are two sidebars. So alternatively, perhaps there could be one tabbed sidebar where you can switch between them?

planned now (closing as a dupe of another item)


prometheus-domain-exporter: init at 1.10.0

Motivation for this change
Useful exporter for monitoring domain expiration time.
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[x] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

@GrahamcOfBorg build prometheus-domain-exporter

WFM macos 10.14, linux x86_64, nixos test passes.

Thank you!


Fix code scanning alert - Semgrep Finding: javascript.sequelize.security.audit.sequelize-injection-express.express-sequeliz...

SQLi zafiyeti
Tracking issue for:

[ ] https://github.com/merveesari/juice-shop/security/code-scanning/170

https://github.com/juice-shop/juice-shop/commit/01b3122b6b875955e42657a1e97a4df3d9ba8b85
"Issue Fix 3 SQLi" commiti ile zafiyet kapatılmıştır.


Calculate calendar weeks using US system for 'en' locale

This pull request changes the default calendar week numbering to the US system (first calendar week is the week containing Jan 1st = the week containing the first Saturday of the year).
To calculate the calendar weeks according to ISO 8601 set firstCalendarWeekDay to 4 (Thursday). This pull requests does this for all locales setting weekStart to 1.

Q
A

Bug fix?
yes

New feature?
yes

BC breaks?
no

Related tickets
fixes #1942

License
MIT

Thanks a lot for the contribution @matthias-g! I'm requested a review from a few of the maintainers and I will try to review the PR soon!
/cc @Azaret @vsn4ik

Thanks. When reviewing feel free to come up with better names for the variables. I'm not really happy with firstCalendarWeekDay but it was the best I found for the day of the week that must be contained in the first calendar week of the year.

Why is it not merged? Many years passed and still nothing?

currentFirstCWDay = new Date(Number(weekStart) + (7 + this.o.firstCalendarWeekDay - weekStart.getUTCDay()) % 7 * 864e5),

@matthias-g This code does not work! It says 'Invalid Date'.


Build a hyper table definition from source_schema in Java

private static TableDefinition CUSTOMER_TABLE = new TableDefinition(
// Since the table name is not prefixed with an explicit schema name, the table will reside in the default "public" namespace.
new TableName("Customer"),
asList(
new TableDefinition.Column("Customer ID", text(), NOT_NULLABLE),
new TableDefinition.Column("Customer Name", text(), NOT_NULLABLE),
new TableDefinition.Column("Loyalty Reward Points", bigInt(), NOT_NULLABLE),
new TableDefinition.Column("Segment", text(), NOT_NULLABLE)
)
);
How to handle hyperextract table creation by reading the schema from a file and create the table definitions dynamically?
I was able create the table dynamically for extapi 2.0, but having trouble with hyperapi. I am newbie, any tips/help is appreciated.

I am able to resolve the issue.


Implement alt-link and bind it to ^o

Add support for an "alternate link" for a coin, to a user-defined target.  This is expressed in a code snippet, defined in the config.toml file. The code has access to sprintf and a coin object with [ID, Name, Symbol, Rank, Slug] available.
alt_link_code = "sprintf(\"https://www.tradingview.com/chart/?symbol=%sUSDT\", coin.Symbol)"

Per #283

Thoughts:

signature of interface.CoinLink() and interface.AltCoinLink() are different - they should probably be the same
in fact, CoinLink should probably just be a pre-configured example of the same pattern
in fact, we could probably support an arbitrary number of CoinLinks (though managing config would be a pain)
the config should probably be in an api-specific section, but updating config structs gives me a headache

The config is a little codey.  Might be easier to explain with simple tokens.

(copying my comment from discord):
This format makes it very specific to Go but the config file should be generalized. I think something like alt_link_code = "https://www.tradingview.com/chart/?symbol=:SYMBOL:" would be better and we can offer :SYMBOL:, :NAME, :ID: , etc as variables

Merging this with some updates
Example
alt_coin_link = "https://www.tradingview.com/symbols/{{SYMBOL}}USD/"

Available tags:

{{ID}}
{{NAME}}
{{RANK}}
{{SLUG}}
{{SYMBOL}}


use correct job name for plugins nightly test

Fixes:<PHONE_NUMBER>09c761d6707cdad81f53f16ba7e017

@ekohl that's what you get for merging too quickly ;-)


Customizing starlight tr

What kind of changes does this PR include?
Updates of Starlight docs site content
Description
This pull request adds translated in Turkish customization.mdx file in project.

Lunaria Status Overview
🌕 This pull request will trigger status changes.

Learn more
By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.
You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

Locale
File
Note

en
guides/authoring-content.md
Source changed, localizations will be marked as outdated.

tr
environmental-impact.md
Localization changed, will be marked as complete.

tr
guides/components.mdx
Localization changed, will be marked as complete.

tr
guides/css-and-tailwind.mdx
Localization removed, will be marked as missing.

tr
guides/customization.mdx
Localization added, will be marked as complete.

Warnings reference

Icon
Description

🔄
The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

Closing PR due to file changes.


Create test cases for router multiplicity

@vadimeisenbergibm I'm assigning this issue and #223 to you for validation. Please look them over as soon as possible.

Validated.


is there any doc on useHttps?  I can't find any

user trying to set it up... but not referenced in config docs
and the config sample
path to  implies, NOT filename

this post  says the code is broken
https://forum.magicmirror.builders/topic/14091/issues-enabling-https-on-rp-4?_=1640398160931
useHttps: false -> useHttps: true

Nevertheless I only got a black screen afterwards.

I tried everything I could think of, but, being that Im not much of a programmer, it basically meant hitting the keyboard with one hand while having another coffee hoping that would do it.

Eventually, I managed to find out that I could connect to the https://localhost:port via a browser, which made me realise the keyboard-hitting works… and that it was running… just not with electron.

Well, tonight, after many an hour in front of this, I was able to get it to work, so I can narrow it down to the following:

Create your certificates correctly
Make sure you put the right address where they are located
Not enough coffee
There is a piece of code in electron.js that seems to be checking the wrong variable:
// if (config[“tls”] !== null && config[“tls”]) {
if (config.useHttps) {
prefix = “https://”;
} else {
prefix = “http://”;
}

The line in “//” was commented out by me. I couldnt find much of a reference to tls anywhere.

Finally, as the certificate is self signed, these lines had to be added also to electron.js:

app.on(‘certificate-error’, (event, webContents, url, error, certificate,
callback) => {
event.preventDefault();
callback(true);
});

I see electron.js in develop is still checking config['tls'], not config.useHttps

yes, this is a mess.
AFAIK there were 2 use cases implemented using https so far:

option useHttps for serveronly mode: parameter useHttps and certs in config.js
option tls for clientonly mode: runtime parameter --use-tls needed

But I never understood any of the https use cases. Why encrypt things when the whole config per default is public and so readable by erveryone (including config secrets)?
So if anyone wants to have a public MagicMirror-Url he should protect this url with some sort of authentification and therefore simplest solution is a reverse proxy which also can handle the https part out of the box.

apparently home assistant in https mode cannot access mm in http mode

to get this running without breaking the existing code we could change the if statement in electron.js to
	if ((config["tls"] !== null && config["tls"]) || config.useHttps) {
		prefix = "https://";
	} else {
		prefix = "http://";
	}

and add the app.on(‘certificate-error’ ...)

@khassel   thanks.. I have sent the user an updated electron.js with those changes

someone should decide if this should be done in the code here, can provide a PR but only if this is wanted.
So any comments to this @sdetweil @rejas @MichMich ?

I think we want it. I have code ready for the pr, have sent to user for testing. it's the holidays, so not sure on his responsiveness

So any comments to this @sdetweil @rejas @MichMich ?

Got no experience with the https stuff in general so I follow @sdetweil's lead here :-)


triton-client: add triton-client http bindings for python

This PR generates python bindings for the triton-client library

Hey @roger652
Could you please push the PR for master branch ?
Thanks

@ichergui Ok, I will do that.

@ichergui Ok, I will do that.

Thanks @roger652

@ichergui Thanks for the review! I try to fix the issue this week.

Hey @roger652
Any updates concerning this PR ?

Hey @roger652 Any updates concerning this PR ?
Hey @ichergui

Sorry for the delay. I'm trying to port the changes to the master branch but I still have some compiler problems to fix.
Keep you posted.

Hey @roger652 Any updates concerning this PR ?
Hey @ichergui

Sorry for the delay. I'm trying to port the changes to the master branch but I still have some compiler problems to fix. Keep you posted.

Please let me know if I can help


getZones hangs

My execution halts whenever i call getZones. I tried exact names, wildcards, etc. The execution just halts with no activity. The CLI is responsive and keeps animating the running... part, but nothing ever happens

@farnoy this sounds similar to https://github.com/pulumi/pulumi/issues/3309 which happens with specific versions of Node and Pulumi. Can you compare your versions to the versions mentioned in that issue and upgrade if you're on the affected versions?

I used nodejs 12.13.0 with pulumi 1.4.1 (upgraded both the CLI tool as well as my pulumi js libraries/plugins in package.json). So I think I have the patch mentioned in that issue

@farnoy just to confirm, are you sure that you don’t have any older versions of @pulumi/Pulumi being loaded?  You could confirm by looking at all mentions of that package in package-lock.json.
It should be the case that if you are using recent versions of that package and the CLI, this hang is no longer possible without also seeing a warning suggesting a change you should make in your code.

I upgraded everything with yarn commands, I didn't edit package.json manually. I also removed all pulumi plugins and ran yarn install again to make sure it picked them up correctly. And I ran the update command twice, because I know it takes one execution to update the provider plugin&version, and the 2nd one still hung for me.
Now that I think about it, the only thing I haven't tried is to update first, run pulumi update and then start using getZones. Maybe that's the proper way of updating it, but I wasn't able to represent my Record objects without providing them zoneId (and using getZones for that).
Are you absolutely sure that this was fixed? I can try more stuff the next time I sit down to upgrade this.

@CyrusNajmabadi It appears that the warning that we are aiming to print here isn't getting rendered.  A console.log there does get rendered.  This may be related to what happens behind the scenes that leads to the hang in this case.
@farnoy It is possible, though I am not 100% sure, that you do need to explicitly add async: true to your calls to getZones per the docs here: https://www.pulumi.com/docs/troubleshooting/#synchronous-call.  The warning I noted above should have pointed you to this.

The warning occurs when invoking a resource function synchronously while also using an explicit provider object that isn’t yet ready to use. For example:

I wasn't using a specific provider, just the implicit cloudflare provider that gets created automatically. Does it matter? Also, if I go with the async route, do I await for that promise in JavaScript, or do I wrap it with pulumi.output?

Also, if I go with the async route, do I await for that promise in JavaScript, or do I wrap it with pulumi.output?

You can do either.  Whichever is more ergonomically pleasant for you in your particular code scenario.
Happy to answer more questions about this (though i'll be on some bit of delay as i'm working on through some personal family affairs right now).  But i will check in at least every 24-48 hours. You can also reach me on our public slack channel if you'd like to use that to discuss this issue more.
Thanks, and sorry for any pain this is causing you!

@farnoy can you share a snippet of the code that is causing the hang, and the contents of your package-lock.json or yarn.lock file?


Design Documents (System Architecture)

Acceptance Criteria:

[ ] Should be able to provide system architecture documentation for this project

@dkeithdj kindly attach the file in this comment section please para ma-review sa tech lead. thanks! cc @franzcruspero

Here: https://docs.google.com/document/d/1onCD4eSdAAcHzdzi-2HQa80moutxP1fDa216qG5Ys6A/edit?usp=sharing


Error queue retention period isn't saved properly.

This is because the value for retention period of error queue is replaced by retention period of the actual queue.

This bug has been fixed. I'll close the issue.


Add support to download data from EBI

It would be nice if grabseqs supported downloading data from EBI.

Hi @ElDeveloper, thanks for the issue! I haven't used EBI before but I think much or all of the data might already be available through SRA.
For example, if I go to the metagenome search page, I see sample IDs that look like SRR#####, DRR#####, ERR######, etc; and project IDs that look like PRJEB######, PRJDB#####, PRJNA######, etc. All of those can be passed to grabseqs.
Is that functionality what you're looking for, or have I misunderstood?

@louiejtaylor thanks for the suggestion. It used to be the case that SRA and EBI/ENA were fairly out of sync but that may have changed recently. Other than that, I tried the command you suggested and I was able to download all sequences for a small study, but wasn't able to figure out a way to download the sample metadata.
For example, when I run:
grabseqs sra -m metadata.csv -o proj/ ERP020591

The file metadata.csv includes some technical information about the sequences. However, the sample metadata that describes covariates for the study isn't there. For that accession, the metadata can be found here. Does grabseqs support downloading that data?

@louiejtaylor friendly ping - is there any way grabseqs could support downloading that additional metadata?


Fixed note

Fixed Azure note that did not render properly.

Hi @gbellmann, I'm your friendly neighborhood Azure Pull Request Bot (You can call me AZPRBOT). Thanks for your contribution!

This seems like a small (but important) contribution, so no contribution license agreement is required at this point. Real humans will now evaluate your PR.

TTYL, AZPRBOT;

@gbellmann - I'm pulling this over to our internal repo so I can stage the change. Thanks for the update.


wrong implementation of Adam

Adam.iterations param is not saved
https://github.com/keras-team/keras/blob/14625e57af7fe85eae501582ce1da135fc04c8e8/keras/optimizers.py#L462
So every time I continue training the model Adam.iterations is reset, which affect many params, for example lr decay is reset.
moving params are also not saved and zeroed every iteration
look at PyTorch.Adam https://github.com/pytorch/pytorch/blob/master/torch/optim/adam.py

also PyTorch.Adam has it own state per param !!
I will try to port PyTorch.Adam to keras


Add the reason of spam in bot info

When a bot identifies the spam text, it have to explain the reason of it.
Right now it is only notify about spam and wishing to delete it.

Done it. Close.


Linux/Mac doesn't work due to missing executable bit for Posix file systems

Posix file systems without an executable bit think that hcl2json is a document and thus can't execute it.
#9  fixes the issue by setting the bit

I've closed this issue as this is as expected, explained in the Pull Request comment. https://github.com/MertSenel/Hcl2PS/pull/9#issuecomment-1685140138


Cannot resize SVG

Hello there,
I have a problem with resize SVG image files. The setSize(width, height) is useless and there is no effect.
I'm using Phaser v3.11.0 with ES6 on Webpack.

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

Have you tried setting the displayWidth and displayHeight properties? That's how I've been doing, not sure if it's the recommended way.

Yeah. I tried and it works. I think this is the only way the effect the width/height of images (or sprites) is using setScale that changes displayWidth and displayHeight or setting them directly.
I wonder what is the purpose of using setSize method? :(

The purpose is for setting the internal size of the Game Object, as used by frames or physics body creation. To adjust how it's rendered, use setScale or setDisplaySize. I've updated the jsdocs to make this more clear.


automatically handling Keras 'Error when checking model input'

This seems to be pretty common especially before getting used to the paradigm upon which Keras operates. For example you give in two features but did not set dimensions to 2 (now it's 300 by default). One solution would be at some point before building the model to detect shape and use that as dims, unless dims is set (and set 'auto' by default). Then if 'auto' is not set, and there is the error we could provide a more clear error message that suggests the action to take.

Apparently you can have dims < than features but not the other way around. But it's probably not a good idea to have less dims than features ;)
How do you think we best handle this?

Closing this for now as we have better use of time.


NuGet package Grpc.HealthCheck Version 2.28.1 does not compile .NET 4.5 lib with #define GRPC_SUPPORT_WATCH

https://github.com/grpc/grpc/blob/v1.28.1/src/csharp/Grpc.HealthCheck/HealthServiceImpl.cs#L134
Decompiler output of
"C:\Users\andre\.nuget\packages\grpc.healthcheck\2.28.1\lib\net45\Grpc.HealthCheck.dll" shows that class "Grpc.HealthCheck.HealthServiceImpl" does not implement the Watch method, but
"C:\Users\andre\.nuget\packages\grpc.healthcheck\2.28.1\lib\net462\Grpc.HealthCheck.dll" does implement it!

I noticed this because I upgraded the Grpc.HealthCheck package in my .NET 4.5 hoping that I would get the implementation of the Watch method, but my client still returned error code UNIMPLEMENTED when calling the watch method.

The watch implementation currently only supported for net462 and netstandard2.0.
https://github.com/grpc/grpc/pull/21120/files#diff-8a3c5313f31d458cd763e3da44471824R22
I'd recommend migrating to one of them to benefit from all the new features.


[Feat]: Add Campusgate

What feature?
I would like to add Campusgate - Platform to prepare for interview.
Add screenshots

Code of Conduct

[X] I agree to follow this project's Code of Conduct

The template you used is incorrect. Please use the correct template and create a new issue.


update images error (pt. 2)

See https://github.com/containerd/containerd/pull/1858#issuecomment-348626418
ctr: : manifest sha256:375718bf305a6e1a4a3e7014958ec5ea5ca52537f00dc70cde71be078fbbd64c: not found

becomes
ctr: manifest sha256:7a0097084ca8095f15290ba77546407228b461c23ae683ff9be3abb487785895: not found

Signed-off-by: Jess Valarezo<EMAIL_ADDRESS>

LGTM

LGTM

Codecov Report

Merging #1861 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1861   +/-   ##
=======================================
  Coverage   49.18%   49.18%
=======================================
  Files          86       86
  Lines        8244     8244
=======================================
  Hits         4055     4055
  Misses       3519     3519
  Partials      670      670

Flag
Coverage Δ

#linux
52.6% <ø> (ø)
:arrow_up:

#windows
44.25% <ø> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 271836a...41ac9fa. Read the comment docs.


BlockId::Number refactor: trivial changes to BlockId::Hash

It changes all the usages of BlockId::Number to BlockId::Hash wherever such change was trivial.
This PR is part of BlockId::Number refactoring analysis (#11292) .

bot merge


Recompile plugin with steampipe-plugin-sdk v4.1.5

Closing this PR in favour of https://github.com/turbot/steampipe-plugin-cloudflare/pull/37


Destruct CowData more graciously by avoiding accidentally exposing a half-destructed buffer.

This can avoid problems with cyclic references (and breakers).
You may think it's rare, but one such cyclic reference is currently occurring in GDScript compiler behavior and leading to half-destructed buffers being copied around. This is not leading to problems right now, because of a coincidental inefficiency in CowData is leading to a technically unnecessary fork of the data before double destruction can occur. In the worst case, the array would have been reallocated halfway through destruction, causing undefined behavior and possibly segmentation faults.
My PR removing the unnecessary forks (#100619) triggered the bug more harshly, and this led to very strange leaks occurring.
Importantly, master currently fails this simple sanity check:
https://github.com/godotengine/godot/commit/75b7a03db68211ae68a9c01386472363dad69639
This PR no longer fails the sanity check.
I also added a test to make sure there is no regression of this behavior.

Very impressive work! That took quite some sleuthing.
I wonder, however, of instead we should delete operator& from all of our CoWing types (Vector, String, etc), reason being that by taking a pointer to the container you circumvent CoW, which is what, in my mind, lies at the root of this.
I think with a CoW datatype taking a pointer to it should be an error, because you should never be storing a reference to the container, you should always take a copy and rely on CoW to make it safe.
If a piece of code can't do that, then it shouldn't be using CoW to begin with. Especially now with the move operators, I feel that if you need to do processing on a CoW type to later pass it on, it is only marginally more expensive to just create a LocalVector to then later copy it to a Vector for passing on.

I have changed my mind a little bit, I think that what I wrote above is true, it is also kind of off topic.
When refcount == 0, the only valid state for ptr() is nullptr. Anything else would be a violation of the contract.

Thanks!


Create Azure AKS bootstrap script

Name and Version
charts/*
What is the problem this feature will solve?
The ability to spin up a response environment in Azure
What is the feature you are proposing to solve the problem?
Similar to the init-gke.sh script for bootstrapping a GKE cluster, create a script that can help bootstrap a Azure AKS cluster and create the required IAM account and equivalent NFS fileshare
What alternatives have you considered?
No response

We should also consider having a internet connectivity option which can help with automating the DNS setup (via route 53) and certificate creation for the domain (if a k8s equivalent is not available similar to here)