Allow class decorators to add static properties.

Search Terms
Class, decorators, typing.
Suggestion
I have a decoator which is typed like so to add a static method to a decorated class. I would like the decorator's typing information to be evaluated and added to the class' typing information.
Decorator typing information (Biscuit is the name of my engine, don't judge I'm not good at naming things):
type ConstructArgs<T> = T extends (new (...args: infer C) => any)?C: never;
type Prototype<T> = (Function & { prototype: T });

//First set of params are the ones supplied in the decorator, like: @BiscuitObject(common);
declare function BiscuitObject<SerialiseType extends Object>(datatype: SerialiseType): (
		//Second set of params are the class the decorator is decorating, in this case the BiscuitObject.
		<
			BiscuitClass extends Function & { prototype: Object },
			Biscuit extends Prototype<BiscuitClass>,
			ConstructorArguments extends ConstructArgs<Biscuit>,
		>
			(biscuit: BiscuitClass) => BiscuitClass & {
				//We return a deserialise function that takes some data and converts it
                // into a new object of this class type.
				deserialise: (object: SerialiseType, ...args: ConstructorArguments) =>	Biscuit;
	});

Example code:

class BDataType {
    tell!: string;
    constructor(tell: string) {
        this.tell = tell;
    }
}

@BiscuitObject(BDataType)
class B {
    tell: string;
    param: string;
    constructor(param: string) {
        this.param = param;
        this.tell = "hi";
    }
    serialise() {
        return new BDataType(this.tell);
    }
	method() {
		console.log(this.tell, this.param);
	}
}

B.deserialise(new BDataType("world"), "hello").method(); //This line errors currently.

https://www.typescriptlang.org/play?#
Use Cases
I want to use this to automate the addition of several common static functions that I use across about 20 different classes in my codebase.
Checklist
My suggestion meets these guidelines:

[y] This wouldn't be a breaking change in existing TypeScript/JavaScript code
[y] This wouldn't change the runtime behavior of existing JavaScript code
[y] This could be implemented without emitting different JS based on the types of the expressions
[y] This isn't a runtime feature (e.g. library functionality, non-ECMAScript syntax with JavaScript output, etc.)
[y] This feature would agree with the rest of TypeScript's Design Goals.

Duplicate of #4881.

Sorry! I did a search and found two related (but closed issues) so I made this. Thanks for that reference about TC39, that's really helpful to know.


Erorr [Composer Update]

I got error  when i run command "Composer Update"
My databes is configured properly!
In DatabaseManager.php line 152:
Database [] not configured.
Script @php artisan package:discover --ansi handling the post-autoload-dump event returned with error code 1

What it means is that you need to set the correct database connection. In .env you should see DB_CONNECTION=.
You can input the db connection, I believe only mysql is supported. Anyway, it would look like this: DB_CONNECTION=mysql


Error: failed to import fd 18 Aborted

Env:

4B (with 4G memory), 64bit Pi OS
uanme -a:

/boot/config.txt:

Problem:

Remarks:

I try rerun cmake with this in this project build dir:  cmake -DENABLE_COMPILE_FLAGS_FOR_TARGET=none ..      (but have the same problem.)

Hi, thanks for this report. Indeed I've seen this error reported before (on a 1GB Pi 4 running a 32-bit OS) but the thread rather dried up. But I'd like to get to the bottom of this.
Firstly, I've been running a 64-bit build with exactly the same data (via uname -a) as yours, and I've copied your /boot/config.txt verbatim, and (you've guessed it) it works fine. So:

First let's double-check the firmware version (type vcgencmd version). I have:
May 27 2021 14:03:06
Copyright (c) 2012 Broadcom
version 7d9a298cda813f747b51fe17e1e417e7bf5ca94d (clean) (release) (start_x)
Have you installed anything extra in your build, and are you running this straight after booting up with nothing else going on?
Are you running headless, or logged in via ssh, or anything like that? I'm assuming you're logged directly in the Pi with a local screen attached. (BTW, what resolution is the screen? I think tvservice -s would tell you)
The failure is clearly here. Would you be able to fish out the actual EGL error? So you'd have to add something like + " " + std::to_string(eglGetError()) to the end of that error runtime error message, and re-run make.
In the meantime I'll consult with some folks who know rather about all this, perhaps there's some more debug we can enable or look at. (I don't suppose dmesg reports anything that looks related?)

Thanks!

Thanks for your help!

My vcgencmd version is the same as yours.
First time it prompt: can not find libGLESv2.so,  and i google and run : apt install libgles2-mesa-dev libglfw3-dev.
I  logged in via ssh (Mobaxterm tool with X server).  tverservice output:

I try like this in egl_preview.cpp:

rerun output:

I google for this error code. Look like this:

Some info maybe useful:

Hi again
Firstly, It sounds to me like there might be something wrong about your installation. The fact that you've had missing libraries and installed some others is clearly not right - the correct procedure is here
Having said that, I assume from your comments that you're running headless. Are you by any chance trying to use X forwarding? Our EGL-based preview shares dmabufs from the camera with the GPU on the Pi and I have no idea whether that's even possible with X forwarding. It's certainly not supported at the moment, but I'll have to take advice on that. In the meantime, you might find that qcam with its Qt copying-based preview would work.

Thanks a lot.
Yes,  according to your suggestion, i found the core of problem is about X forwarding. When i turn off X Server and  hook up the monitor everything is ok.

We've pushed a change which provides another implementation of the preview window that doesn't use zero-copy buffer sharing or GPU acceleration. It's implemented using Qt and can be enabled using (for example) libcamera-hello --qt-preview. Note that it's very slow compared with the other preview implementations (so we never use it unless it's requested explicitly), and it would be best to avoid large images. But it does work with X forwarding. I think that's enough to close this thread - but please file a new issue if anything crops up.

@BrendanHenryGithub
Hey there,
I got the same problem like you but in my case it was what(): failed to import fd19. So with the installation from here (https://github.com/raspberrypi/libcamera-apps#readme) it should work ?
Would appreciate it, if you could answer this.

@BrendanHenryGithub
Hey there,
I got the same problem like you but in my case it was what(): failed to import fd19. So with the installation from here (https://github.com/raspberrypi/libcamera-apps#readme) it should work ?
Would appreciate it, if you could answer this.


Revert "Add Client option for access_token_class"

Reverts oauth-xx/oauth2#516

Pull Request Test Coverage Report for Build 1049

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 0.0%

Totals

Change from base Build 1046:
0.0%

Covered Lines:
0

Relevant Lines:
0

💛  - Coveralls

Pull Request Test Coverage Report for Build 1049

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 0.0%

Totals

Change from base Build 1046:
0.0%

Covered Lines:
0

Relevant Lines:
0

💛  - Coveralls


Create AzureOpenAITestingSub.json

Adds a subconfig all languages can target for live Azure OpenAI tests

The following pipelines have been queued for testing:java - templatejava - template - testsjs - templatenet - templatenet - template - testspython - templatepython - template - tests You can sign off on the approval gate to test the release stage of each pipeline. See eng/common workflow

The following pipelines have been queued for testing:java - templatejava - template - testsjs - templatenet - templatenet - template - testspython - templatepython - template - tests You can sign off on the approval gate to test the release stage of each pipeline. See eng/common workflow

The following pipelines have been queued for testing:java - templatejava - template - testsjs - templatenet - templatenet - template - testspython - templatepython - template - tests You can sign off on the approval gate to test the release stage of each pipeline. See eng/common workflow

Seems we don't need this after talking to @xiangyan99 and @danieljurek. Closing the PR.


AsyncDuckDB.instantiate emits error (worker terminated with 1 pending requests) and hangs

What happens?
In some situations, AsyncDuckDB.instantiate emits this error and hangs next build:
worker terminated with 1 pending requests

I've run into this a few times while trying to use duckdb-wasm in Next.js apps. Here's some repro info (copied from runsascoded/duckdb-wasm-issue):
Repro
duckdb-utils/src/duckdb.ts calls AsyncDuckDB.instantiate:
const { worker, bundle } = await nodeWorkerBundle()
console.log("bundle:", bundle)
const logger = { log: () => {}, }
const db = new AsyncDuckDB(logger, worker)
console.log("instantiating db")
await db.instantiate(bundle.mainModule, bundle.pthreadWorker)  // ❌ "worker terminated with 1 pending requests"
console.log("instantiated db")

Github Actions repro
Here's an example of the error in a Github Action:
bundle: {
  mainModule<EMAIL_ADDRESS>  mainWorker<EMAIL_ADDRESS>  pthreadWorker: null
}
instantiating db
worker terminated with 1 pending requests
 ⚠ Restarted static page generation for / because it took more than 60 seconds

Dockerfile repro
For some reason, the error only happens in this Dockerfile when the duckdb-utils module is npm linked:
FROM node:19.3.0
COPY . /src

# ✅ Build succeeds with local duckdb-utils install
RUN cd /src/duckdb-utils/dist && npm i
WORKDIR /src
RUN npm i
# This fails in Github Actions, but not in this Docker build, or on the underlying host, on my M1 macbook or an Amazon Linux EC2 instance
RUN npm run build

# ❌ Build fails with `npm link`ed duckdb-utils
RUN cd /src/duckdb-utils/dist && npm link
RUN npm link duckdb-utils
RUN npm run build  # ❌ `worker terminated with 1 pending requests` inside AsyncDuckDB constructor

Clone + docker build
Clone this repo, and build the Dockerfile:
git clone --recurse-submodules https://github.com/runsascoded/duckdb-wasm-issue
cd duckdb-wasm-issue
docker build -t duckdb-wasm-issue .  # ❌ fails
# 7.865 bundle: {
# 7.865   mainModule<EMAIL_ADDRESS># 7.865   mainWorker<EMAIL_ADDRESS># 7.865   pthreadWorker: null
# 7.865 }
# 7.865 instantiating db
# 7.868 worker terminated with 1 pending requests
# 68.12  ⚠ Restarted static page generation for / because it took more than 60 seconds
# … etc.

Host repro
I also see the same failure when running directly on each underlying host (macbook / AZLinux), without Docker:

npm run build succeeds when duckdb-utils is npm installed directly.
npm run build fails when duckdb-utils is npm linked.

I don't know why Github Actions' ubuntu-latest demonstrates the problem more easily (without the npm link step).
Earlier repro: next.js#57819
I previously filed a repro at next.js#57819.
All the repros I've found involve Next.js, but the fact that the failure occurs within duckdb-wasm, and manifests as a hang instead of a normal Error / exception, makes me feel like it may be primarily a duckdb-wasm problem. I have only tried to use duckdb-wasm within Next.js, so I'm not sure it's specific to Next.
To Reproduce

Github Actions example
Dockerfile example
https://github.com/vercel/next.js/discussions/57819 also contains a repro.

Browser/Environment:
Node v19.3.0
Device:
M1 macbook, Amazon Linux, Github Actions ubuntu-latest
DuckDB-Wasm Version:
1.28.0
DuckDB-Wasm Deployment:
@duckdb/duckdb-wasm/dist/duckdb-eh.wasm
Full Name:
Ryan Williams
Affiliation:
Runs As Coded LLC

Will try to add more details later but 2 things that seem to help:
Skip this npm i in the Dockerfile:
-RUN cd /src/duckdb-utils/dist && npm i
+RUN cd /src/duckdb-utils/dist

Make sure web-worker is in the dependencies array of the outer package (this was already the case in my repro, but I ran into it in another project today).


network plugin can not be detected,my netowrk plugin is flannel

⚠ Checking Submariner support for the CNI network plugin
⚠ Submariner could not detect the CNI network plugin and is using ("generic") plugin. It may or may not work.
Network plugins supported: calico, flannel, kube-router, cilium, kube-ovn
CLUSTER_NETWORK="flannel"
What happened:
What you expected to happen:
How to reproduce it (as minimally and precisely as possible):
Anything else we need to know?:
Environment:

Diagnose information (use subctl diagnose all):

[root@localhost ~]# subctl diagnose all
Cluster "cluster1"
 ✓ Checking Submariner support for the Kubernetes version
 ✓ Kubernetes version "v1.23.1" is supported

 ⚠ Checking Submariner support for the CNI network plugin
 ⚠ Submariner could not detect the CNI network plugin and is using ("generic") plugin. It may or may not work.

 ✗ Checking gateway connections
 ✗ There are no gateways detected

 ✓ Checking Submariner pods
 ✓ All Submariner pods are up and running

 ✓ Globalnet deployment detected - checking if globalnet CIDRs overlap
 ✓ Clusters do not have overlapping globalnet CIDRs

 ✓ Checking Submariner support for the kube-proxy mode
 ✓ The kube-proxy mode is supported

 ✗ Checking the firewall configuration to determine if the metrics port (8080) is allowed
 ✗ The tcpdump output from the sniffer pod does not contain the client pod HostIP. Please check that your firewall configuration allows TCP/8080 traffic on the "<IP_ADDRESS>" node.

 ✗ Checking the firewall configuration to determine if VXLAN traffic is allowed
 ✗ Could not find the local Endpoint in cluster "cluster1"

 ✗ Checking Globalnet configuration
 ✗ Found [0 %!d(string=cluster-egress.submariner.io)] ClusterGlobalEgressIP resources but only the default instance (%!q(MISSING)) is supported
 ✗ Couldn't find the default ClusterGlobalEgressIP resource(["cluster-egress.submariner.io"])

Skipping inter-cluster firewall check as it requires two kubeconfigs. Please run "subctl diagnose firewall inter-cluster" command manually.

Gather information (use subctl gather):
Cloud provider or hardware configuration:
Install tools:
Others: subctl 0.12.1

This may have been fixed, as described above. Closing for now, feel free to re-open @13567436138 if this is still an issue with latest subctl.


"Cannot cast mixed to float." static analysis error for "traces_sample_rate" config key

How do you use Sentry?
Sentry Saas (sentry.io)
Version
^3.3
Steps to Reproduce

Run phpstan
An error occurs

Cannot cast mixed to float.

Expected Result
No static analysis errors.
Actual Result

Cannot cast mixed to float.

A little more context of the error (like the code it's erroring on) is appreciated!
phpstan shouldn't analyze vendor code so this error occurs in your own code most likely.

Sorry, I find the issue template a bit restricting imo, was not sure where to put additional context.
I ran phpstan on my config file, and after opening the issue I was able to fix it simply by calling floatval() (which allows to take a mixed type) instead of float cast language expression.
I'm able to open a pull request if you want. If you consider this is not needed since config file should not be statically analyse, feel free to close it.

I ran phpstan on my config file

Are you talking about Laravel then?

Yes actually, missed the correct repo then!


Add subnet or broadcast in prefix

Environment

Python version:  3.6.8
NetBox version:  2.5.13

Steps to Reproduce

Add prefix
Enter prefix
Switch to tab 'IP Addresses'
Click on XXX IPs available for XXX.XXX.XXX.0/XX or XXX.XXX.XXX.255/XX ip addresses (even showing these as available)

Expected Behavior
Not showing .0 or .255 ip addresses, since they are a subnet or broadcast address

Observed Behavior
Can add .0 or .255 as useable address

+1. seeing this on netbox 2.5.12 . broadcast ip is available to be assigned

This is most likely behaviour that has not been changed since initial release.
Couple of reasons for this:

Prefixes can be designated a "pool", in which case it would be perfectly valid to have a network and broadcast address
There may be specific reasons that you want to document the Network or Broadcast address, or perhaps you forgot to mark it as a pool
This has to be done manually, as in you have to consciously choose to input the network or broadcast address.  Both the UI and the API correctly return only the usable addresses available

I personally think the work required to implement the appropriate checks for this is better spent elsewhere.

Thanks for your feedback. I personally think broadcast addresses should never be used and subnet address is defined by prefix, but I understand it'd be a lot of work to do.
You now know about this issue, whether or not you'd like to fix this in future belongs to you/netbox team!


Image Rendering as missing textures

Hello, I've got some issues in image rendering, I did do nothing with this picture, just decompile with MCP and in Eclipse run the code.
[Client thread/WARN]: Failed to load texture: minecraft:textures/gui/title/edition.png java.io.FileNotFoundException: minecraft:textures/gui/title/edition.png 	at net.minecraft.client.resources.FallbackResourceManager.func_110536_a(FallbackResourceManager.java:66) ~[bin/:?] 	at net.minecraft.client.resources.SimpleReloadableResourceManager.func_110536_a(SimpleReloadableResourceManager.java:62) ~[bin/:?] 	at net.minecraft.client.renderer.texture.SimpleTexture.func_110551_a(SimpleTexture.java:31) ~[bin/:?] 	at net.minecraft.client.renderer.texture.TextureManager.func_110579_a(TextureManager.java:66) [bin/:?] 	at net.minecraft.client.renderer.texture.TextureManager.bindTexture(TextureManager.java:41) [bin/:?] 	at net.minecraft.client.gui.GuiMainMenu.func_73863_a(GuiMainMenu.java:498) [bin/:?] 	at net.minecraft.client.renderer.EntityRenderer.func_181560_a(EntityRenderer.java:1113) [bin/:?] 	at net.minecraft.client.Minecraft.func_71411_J(Minecraft.java:1095) [bin/:?] 	at net.minecraft.client.Minecraft.run(Minecraft.java:395) [bin/:?] 	at net.minecraft.client.main.Main.main(Main.java:115) [bin/:?] 	at Start.main(Start.java:11) [bin/:?]

thatis i'm pretty sure a problem with resourceloader images with the format of .jpg work just fine

Install any archive editor like 7z then go to the eclipse open: jars>versions>your version>urversion.jar with 7z then open assets>minecraft>textures>gui>title and paste here linked image https://www.mediafire.com/view/mcsf8slir5hxusp/edition.png/file


[FEATURE] Is it possible to have crew ai or autogen like feature where agents/bots which we create with different roles communicate together and solve one problem or given case together

The feature i am talking about is what makes autogen and crewai special as with help of there special feature of making multi bots/agents communicate together and maybe use different api/models to solve one task/issue together is PRETTY BIG THING and it makes the best use of multiple bots which we can also create with flowise too thankfully but to truly harness the true power of multiple bots with multi roles we must make them capable to think as expert individual in particular thing(with help of system message) and work TOGETHER as individual experts of something and solve one specific issue/case together which involves deep thinking(in that case multiple different agents with different expertise can give best solution/idea) instead of directly using one bot which wont think much and will give insta response which is not something which we want(You all can see videos on crew ai and autogen if you were busy in development and didnt know about it to get better idea of what i am saying)and because of that autogen and crew ai like foss projects were build where we want better and perfectly planned detailed answer on many complex cases like for example -
this is not my example but just to help you understand this whole thing better i am taking one medium post example you can read better with this link
("https://webcache.googleusercontent.com/search?q=cache:https://medium.com/@mayaakim/crewai-a-team-of-ai-agents-that-work-together-for-you-4cc9d24e0857")
I want an agent that browse the internet, another one that can write blog posts (with at least 10 paragraphs) and a critic agent that checks and makes sure that standards that I’ve defined are met
explorer = Agent(
role='Senior Researcher',
goal='Find and explore the most exciting projects and companies in
AI and machine learning in 2024',
backstory="""You are and Expert strategist that knows how to spot
emerging trends and companies in AI, tech and machine learning.
You're great at finding interesting, exciting projects in Open
Source/Indie Hacker space. You look for exciting, rising
new github ai projects that get a lot of attention.
""",
verbose=True,
allow_delegation=False,
tools=[search_tool]
)
writer = Agent(
role='Senior Technical Writer',
goal='Write engaging and interesting blog post about latest AI projects
using simple, layman vocabulary',
backstory="""You are an Expert Writer on technical innovation, especially
in the field of AI and machine learning. You know how to write in
engaging, interesting but simple, straightforward and concise. You know
how to present complicated technical terms to general audience in a
fun way by using layman words.""",
verbose=True,
allow_delegation=True
)
critic = Agent(
role='Expert Writing Critic',
goal='Provide feedback and criticize blog post drafts. Make sure that the
tone and writing style is compelling, simple and concise',
backstory="""You are an Expert at providing feedback to the technical
writers. You can tell when a blog text isn't concise,
simple or engaging enough. You know how to provide helpful feedback that
can improve any text. You know how to make sure that text
stays technical and insightful by using layman terms.
""",
verbose=True,
allow_delegation=True
)
after these agents created as expert in different things
then Let’s define 3 tasks as well that each of the agents will execute:
task_report = Task(
description="""Use and summarize scraped data from subreddit LocalLLama to
make a detailed report on the latest rising projects in AI. Your final
answer MUST be a full analysis report, text only, ignore any code or
anything that isn't text. The report has to have bullet points and with
5-10 exciting new AI projects and tools. Write names of every tool and
project. Each bullet point MUST contain 3 sentences that refer to one
specific ai company, product, model or anything you found on subreddit
LocalLLama. Use ONLY scraped data from LocalLLama to generate the report.
""",
agent=explorer,
)
task_blog = Task(
description="""Write a blog article with text only and with a short but
impactful headline and at least 10 paragraphs. Blog should summarize
the report on latest ai tools found on localLLama subreddit. Style and
tone should be compelling and concise, fun, technical but also use
layman words for the general public. Name specific new, exciting projects,
apps and companies in AI world. Don't write "Paragraph [number of the
paragraph]:", instead start the new paragraph in a new line. Write names
of projects and tools in BOLD.
ALWAYS include links to projects/tools/research papers.
""",
agent=writer,
)
task_critique = Task(
description="""Identify parts of the blog that aren't written concise
enough and rewrite and change them. Make sure that the blog has engaging
headline with 30 characters max, and that there are at least 10 paragraphs.
Blog needs to be rewritten in such a way that it contains specific
names of models/companies/projects but also explanation of WHY a reader
should be interested to research more. Always include links to each paper/
project/company
""",
agent=critic,
)
so after we execute code with crew ai these agents will work together and
1.searches the internet for latest AI projects and trends
2.writes a blog post about it
3. and improves the text in the blog if it fails to meet some standards
according to the task we have assigned and will give the best possible blog.(Please do read from above mentioned link of medium in detail to get best idea as in that with tools which are also there in flowise now thankfully can help to make this process much better, i am not pasting more stuff here because i guess this much is enough for getting basic understanding :-)

this is the next thing we are working on! crewai is still working on their JS/TS version, we might be able to do this with langgraph

@HenryHengZJ nice hope to see it soon because it will give more power to this awesome project :-))

released! https://github.com/FlowiseAI/Flowise/pull/2319 💯


Add multi terms aggregation feature

Is your feature request related to a problem? Please describe.
I'd like to have an aggregation feature that lets me sort by a number of a document or a metric aggregation on a composite key and get top N results.
This feature was already implemented in the 7.15 version of Elastic Search.
Here you go link to the documentation:
https://www.elastic.co/guide/en/elasticsearch//reference/master/search-aggregations-bucket-multi-terms-aggregation.html
Describe the solution you'd like
It would be perfect to see this feature as a part of the official solution (as a service). Currently, we would have to instantiate (ES 7.15) and maintain it as a container ourselves.
Describe alternatives you've considered
As an alternative, we've considered some custom implementation of this mechanism on the consumer side (our service) but it seems ineffective. Moreover, it duplicates already existing features and has no sense to do it in that way.

When will this feature get added?

When will this feature get added?

AFAIK nobody is working on this, please contribute / raise your hand if you are.

SQL/PPL require this feature also. https://github.com/opensearch-project/sql/issues/124.

Any updates on this feature?

Working on PR now. Give a quick demo of the feature now and will post first version soon.

Request

GET localhost:9200/test_00001/_search
{
  "size": 0,
  "aggs": {
    "hot": {
      "multi-terms": {
        "terms": [{
          "field": "region"
        },{
          "field": "host"
        }],
        "order": {"max-cpu": "desc"}
      },
      "aggs": {
        "max-cpu": { "max": { "field": "cpu" } }
      }
    }
  }
}

Response

{
  "took": 118,
  "timed_out": false,
  "_shards": {
    "total": 1,
    "successful": 1,
    "skipped": 0,
    "failed": 0
  },
  "hits": {
    "total": {
      "value": 8,
      "relation": "eq"
    },
    "max_score": null,
    "hits": []
  },
  "aggregations": {
    "multi-terms": {
      "doc_count_error_upper_bound": 0,
      "sum_other_doc_count": 0,
      "buckets": [
        {
          "key": [
            "dub",
            "h1"
          ],
          "key_as_string": "dub|h1",
          "doc_count": 2,
          "max-cpu": {
            "value": 90.0
          }
        },
        {
          "key": [
            "dub",
            "h2"
          ],
          "key_as_string": "dub|h2",
          "doc_count": 2,
          "max-cpu": {
            "value": 70.0
          }
        },
        {
          "key": [
            "iad",
            "h2"
          ],
          "key_as_string": "iad|h2",
          "doc_count": 2,
          "max-cpu": {
            "value": 50.0
          }
        },
        {
          "key": [
            "iad",
            "h1"
          ],
          "key_as_string": "iad|h1",
          "doc_count": 2,
          "max-cpu": {
            "value": 15.0
          }
        }
      ]
    }
  }
}

Nice, can't wait for this feature

1.Performance Improvement
As described in #2687, multi_terms aggregation is 20x slower than terms aggregation. After profiling, we found that encode is major contributor.

Why encode is major contributor?

Serialize List<Object>  as BytesRef take a lot of CPU time. Which is the potential optimization point.

Why not decode?

Decode is execute only on each bucket key, encode is executed on each document. for example, there are 1M docs, but only 10 bucket key. encode will execute 1M times, but decode only execute 10 times.

2.Experiments

Use hasCode() to generate bucket key, instead of serialize entire List<Object>
Use globalOrdinal for string term.

2.1.Benchmark the average time of hashCode vs Encode.
Test with integer value, hashCode() is around 30x faster then encode().
  @Benchmark
  public void encode(Blackhole bh) {
    for (int i = 0; i < iterations; i++) {
      bh.consume(encode(Arrays.asList(random.nextInt(32), random.nextInt(32))));
    }
  }

  @Benchmark
  public void hash(Blackhole bh) {
    for (int i = 0; i < iterations; i++) {
      bh.consume(Arrays.asList(random.nextInt(32), random.nextInt(32)).hashCode());
    }
  }

  private static BytesRef encode(List<Object> values) {
    try (BytesStreamOutput output = new BytesStreamOutput()) {
      output.writeCollection(values, StreamOutput::writeGenericValue);
      return output.bytes().toBytesRef();
    } catch (IOException e) {
      throw ExceptionsHelper.convertToRuntime(e);
    }
  }

Benchmark             (iterations)  Mode  Cnt   Score   Error  Units
HashBenchmark.encode          1000  avgt    5   0.304 ± 0.006  ms/op
HashBenchmark.encode         10000  avgt    5   3.020 ± 0.071  ms/op
HashBenchmark.encode        100000  avgt    5  32.215 ± 4.714  ms/op
HashBenchmark.hash            1000  avgt    5   0.020 ± 0.001  ms/op
HashBenchmark.hash           10000  avgt    5   0.196 ± 0.019  ms/op
HashBenchmark.hash          100000  avgt    5   1.931 ± 0.083  ms/op

Test the performance of globalOrdinal and hashCode
Do a POC to verify the idea and test the performance. In general, we are 4x faster then existing multi_terms aggregation implementation.
# 1. multi_terms aggregation of keyword and integer field
time curl --request GET   --url http://localhost:9200/logs-201998/_search?pretty   --header 'content-type: application/json'   --data '{"size":0,"aggs":{"hot":{"multi_terms":{"terms":[{"field":"clientip"},{"field":"status"}],"order":{"avg-size":"desc"}},"aggs":{"avg-size":{"avg":{"field":"size"}}}}}}'

real	0m1.859s

# 1. multi_terms aggregation of integer and integer field
time curl --request GET   --url http://localhost:9200/logs-201998/_search?pretty   --header 'content-type: application/json'   --data '{"size":0,"aggs":{"hot":{"multi_terms":{"terms":[{"field":"status"},{"field":"status"}]}}}}'

real	0m0.653s

we need to see how to - showcase visualizations and UI changes in visualize

@penghuo my apologies if I am missing something, but I suspect the idea to use hashCode() relies on the fact that it returns an unique value for each key. This is particularly not true for Java's String impelementation, simple example:
jshell> "Ca".hashCode()
$5 ==> 2174

jshell> "DB".hashCode()
$6 ==> 2174

There are some in depth details in here [1] but should not rely on hash code uniqueness [2].
[1] https://dzone.com/articles/what-is-wrong-with-hashcode-in-javalangstring
[2] https://github.com/penghuo/OpenSearch/blob/640b4a8bcbbf5a70fd990c711d6d3f97fb5da73a/server/src/main/java/org/opensearch/search/aggregations/bucket/terms/MultiTermsAggregator.java#L221

@penghuo my apologies if I am missing something, but I suspect the idea to use hashCode() relies on the fact that it returns an unique value for each key. This is particularly not true for Java's String impelementation, simple example:
jshell> "Ca".hashCode()
$5 ==> 2174

jshell> "DB".hashCode()
$6 ==> 2174

There are some in depth details in here [1] but we should not rely on hash code uniqueness [2].
[1] https://dzone.com/articles/what-is-wrong-with-hashcode-in-javalangstring [2] https://github.com/penghuo/OpenSearch/blob/640b4a8bcbbf5a70fd990c711d6d3f97fb5da73a/server/src/main/java/org/opensearch/search/aggregations/bucket/terms/MultiTermsAggregator.java#L221

Good point. Instead of using String.hashcode for string, I think using globalOrdinal for string value. But not verified yet.

@penghuo this issue is tagged 2.1.0.
We are code freeze for 2.1. I'll move this issue to 2.2.0, let me know if you think otherwise.

The two PRs mentioned this issue were backported to 2.x before 2.1 was cut. The backport commits 32cfe530baa and c7656f1de4a are already in 2.1 branch

Yes as @joshuali925 mentioned this feature is present in feature 2.1 branch


HIVE-12261

Resolved through manual patch process.
https://issues.apache.org/jira/browse/HIVE-12261


Make installation of dependency possible from the manifest

Description of problem
When a package is dependent from another package there are two possibilities at the monent.

Add a dependency
<dependency type="Package">chartjs</dependency>
If the package is not installed the installation would fail with a more or less cryptic error message.

Include the full package in the manifest.

Description of solution
A cleaner way would be the possibility to include a link to the installation package in the manifest, something like
<dependency type="Package">
   <name>chartjs</name>
   <url>https://github.com/EngageSoftware/DNN-JavaScript-Libraries/releases/download/chart.js_2.7.3/chart.js_2.7.3.zip</url>
</dependency>
When the download is not possible (e.g. in an Intranet server) the error message could display the link as well and give some explanation about it (e.g. "Please download the package chartjs from https://github.com/EngageSoftware/DNN-JavaScript-Libraries/releases/download/chart.js_2.7.3/chart.js_2.7.3.zip prior to installing this package.")

I am closing this issue in favor of #2614 which covers this use case and is a more discussed RFC that would solve this issue.


Fix misleading number of bytes sent reported on Apple platforms

The number of bytes sent reported is incorrect, this PR fixes it

+1


:sparkles: Add Tdarr integration and widget

Category
Feature
Overview
Add new integration and widget for Tdarr. The widget uses the Tdarr API (Reference: https://tdarr.readme.io/reference) to fetch and display the following information:

Number of queued files
Total size of queued files
Number of errors and corresponding filenames
List of queued files, including file size and current status

The widget only integrates with one app at a time, but allows the user to choose.
Issue Number
Related issue: #1865
Screenshots
Queued files:

Errors:

Loading skeleton:

Empty queue (with updated header design):

Integration in app settings:

Updated header with app icon & name:

Support for multiple apps:

Thanks a lot for the PR ! I didn't read the code yet but based off the screenshots, have you tried to use the mantine component for scrollarea ? It would remove the ugly automatic chrome scroll bars with better ones when the data overflows

Thanks a lot for the PR ! I didn't read the code yet but based off the screenshots, have you tried to use the mantine component for scrollarea ? It would remove the ugly automatic chrome scroll bars with better ones when the data overflows

Ah, good suggestion. I will update the widget.

Well, I was working on that too x)

I was taking a different approach, more minimalist with more stats and less of a list.
Was still a work in progress though kinda close.

Well, I was working on that too x)

I was taking a different approach, more minimalist with more stats and less of a list.
Was still a work in progress though kinda close.

I guess yours could be a tdarr-stats like we have overseer stats

Well, I was working on that too x)  I was taking a different approach, more minimalist with more stats and less of a list. Was still a work in progress though kinda close.

That's really neat. Initially, I was planning to integrate a statistics panel of some sort but couldn't figure out how to get the information from the API. Similarly, I am really curious how you got the progress indicator working, I didn't find that either.

Well, I was working on that too x)  I was taking a different approach, more minimalist with more stats and less of a list. Was still a work in progress though kinda close.

That's really neat. Initially, I was planning to integrate a statistics panel of some sort but couldn't figure out how to get the information from the API. Similarly, I am really curious how you got the progress indicator working, I didn't find that either.

Since mine is a work in progress, how about I publish my branch, share it here, and you take as much of it as you want?
I think a list containing all the files is a bit overbearing so showing stats is better.
For exemple all the staged files shouldn't be listed, only how many are.

https://github.com/Tagaishi/homarr/tree/media-transcode-integration
What was missing in my opinion in mine:

Show stat for staged files (had to tweak with the UI to show that)
Show badge to tell if the worker is a healthcheck or transcoding
Button to toggle all workers (Not sure if possible, tdarr's api is quite annoying)
I wanted to make the 2 cards buttons that could auto requeue failing items. (again, not sure if possible)

Since mine is a work in progress, how about I publish my branch, share it here, and you take as much of it as you want? I think a list containing all the files is a bit overbearing so showing stats is better. For exemple all the staged files shouldn't be listed, only how many are.

That would be amazing, thanks for the kind offer.
I guess it depends on the use case. I use Tdarr for transcoding audio streams to eliminate the need for on the fly transcoding on devices that don't support Dolby Atmos. So I'm mainly interested in when Tdarr has finished processing a certain file so I can start streaming it.
But I also get the appeal of a more minimalist stats widget. I like @ajnart's suggestion to have two separate widgets, or we could create a single one taht does both.
Perhaps a Discord poll could be useful for gauging what would be useful for most people?

Since mine is a work in progress, how about I publish my branch, share it here, and you take as much of it as you want? I think a list containing all the files is a bit overbearing so showing stats is better. For exemple all the staged files shouldn't be listed, only how many are.

That would be amazing, thanks for the kind offer.
I guess it depends on the use case. I use Tdarr for transcoding audio streams to eliminate the need for on the fly transcoding on devices that don't support Dolby Atmos. So I'm mainly interested in when Tdarr has finished processing a certain file so I can start streaming it.
But I also get the appeal of a more minimalist stats widget. I like @ajnart's suggestion to have two separate widgets, or we could create a single one taht does both.
Perhaps a Discord poll could be useful for gauging what would be useful for most people?

Well, it's all yours now, do as you think is best, I trust you ^^

Thanks for the review @manuel-rw. I will try to integrate @Tagaishi's widget in the coming days which will require a good amount of refactoring of my changes anyway, I'll fix your remarks then.

Did you run formatting on every file in the project?
Don't modify files that have nothing to do with the widget and it's integrations please.

Yep, I reverted every change not related to the integration. How do you normally enforce formatting?

f1 -> format document. (Same for organize imports)
Only doing so on files that we're currently working on.

 Sometimes I don't think we should force people to use shorthand properties instead of using style, because both work. But it's good to know that they exist.
Nice to see you got really good at remembering them because I always forget

f1 -> format document. (Same for organize imports) Only doing so on files that we're currently working on.

That might work for your particular editor and keymap. Could something like a pre-commit hook, lint-staged or a PR check that enforces proper formatting be helpful?

f1 -> format document. (Same for organize imports) Only doing so on files that we're currently working on.

That might work for your particular editor and keymap. Could something like a pre-commit hook, lint-staged or a PR check that enforces proper formatting be helpful?

No idea, never used those. We just manually run "Prettier"'s formatting on files we work on.

@jbruell are you still working on this?

@jbruell are you still working on this?

@manuel-rw Sorry, life got in the way a bit. I forgot to backup my Tdarr config before reinstalling my server from scratch and haven't found the motivation to set it up again afterwards. I might spend some time in the coming weeks.
I have to sift through Tagaishi's comments again after that and see what I can do with a reasonable time invest.

@jbruell are you still working on this?

@manuel-rw Sorry, life got in the way a bit. I forgot to backup my Tdarr config before reinstalling my server from scratch and haven't found the motivation to set it up again afterwards. I might spend some time in the coming weeks.
I have to sift through Tagaishi's comments again after that and see what I can do with a reasonable time invest.

I think you covered my comments pretty thoroughly as I saw you thumbed up most if not all of them.
double checking never hurts but I think now what is most important is to resolve merge issues and details.

These are my current TODOs which I've extracted from all the comments:

Rename widget to: media-transcoding
Use MantineReactTable
Add pagination for workers
Rethink Health Indicator ring / Statistics in general

I'm not happy with it as it stands, but the Tdarr stats aren't that important to me anyway, since my reason for wanting a Tdarr widget was to see when a movie is ready for watching, so I'm having a hard time coming up with something useful. If you have any input or ideas what you'd like to see, I'd be more than happy to hear them.

Remove AppSelector (?)

If you'd prefer, I can remove it again, I can understand if it doesn't fit the long term plans for Homarr

Feel free to add any additional points that I might've missed.

These are my current TODOs which I've extracted from all the comments:

Rename widget to: media-transcoding

Use MantineReactTable

Add pagination for workers

Rethink Health Indicator ring / Statistics in general

I'm not happy with it as it stands, but the Tdarr stats aren't that important to me anyway, since my reason for wanting a Tdarr widget was to see when a movie is ready for watching, so I'm having a hard time coming up with something useful. If you have any input or ideas what you'd like to see, I'd be more than happy to hear them.

Remove AppSelector (?)

If you'd prefer, I can remove it again, I can understand if it doesn't fit the long term plans for Homarr

Feel free to add any additional points that I might've missed.

Sounds good, I think @Tagaishi will be able to give you more insights

Hi @jbruell ,
we're currently working on Homarr 1.0 with a complete rewrite of many systems (see #1993).
Would you help us migrating the code of this widget? We do not run Tdarr and would be awesome if you could help us out.
Cheers 👋


Distance and Direction - Ellipse tool does not create correct Full ellipse when using map point tool.

Widget
Distance and Direction
Version of widget
1.0 for WAB 2.2
Bug or Enhancement
Bug
Repo Steps or Enhancement details
When drawing a full ellipse dynamically, I expect the labels to represent the full major and minor axis, which are the diameters of the two axes of the ellipse. Currently, when I draw an ellipse using the Full drop down on the distance and direction widget, I get a full label for major axis, and a semi label for minor axis. I figured this out using the measurement widget:

This is similar to this issue in that it talks about inaccuracies in ellipse labeling in distance and direction widgets:https://github.com/Esri/solutions-webappbuilder-widgets/issues/816

Issue should be address please can somebody verify
@NatalieCampos @dfoll @topowright @ACueva

I got this one.

Verified.
Behavior is now Semi Ellipses return the radius length for both Major and Minor axis.
Full Ellipses return the diameter length for both Major and Minor axis.
Unknown if this affects documentation.  Adding label.

This is not listed as a known issue.  It does not appear to affect documentation.  Removing label and closing.


Blind Control Example #3 rules not triggered

Describe the bug
A clear and concise description of what the bug is.
I testes the blind controller node with the example #3.
There is this option for 1sec is 30min input.
If i start this with the start/stop flow, the rules are not triggering.
Screenshots
If applicable, add screenshots to help explain your problem.

Expected behavior
Rules should trigger, and also override "Sonnesteuerung"
System information (please complete the following information):

Node Version
Node-Red Version V2.1.4

Additional context
Add any other context about the problem here.

The error is n the function node:

in line 20 must be instead of (isNAN --> (!isNAN:

Will be fixed in the next release!

The issue should be fixed in the latest release.


Adding check for local dynamo status on app startup

@bsweger or @jworcestBAH

@nmonga91 This is working as expected on OSX (i.e, it produces error messages when local dynamo isn't running). @jworcestBAH can you confirm that this works on Windows?
The only flag here is that at least on OSX, the nmap install gets an unsigned warning. If someone asks, where can we point them to ensure that this is a safe app to use?

So this does not work on windows after installing nmap because awk is not a command in windows.  One fix could be to add a utility that can replace that to install instructions and have a conditional that runs a different command here for windows.

Alternatively, can we rewrite this to not use awk?

@jworcestBAH thanks for testing this on Windows! What do you and @nmonga91 think about making this simpler and trying to issue a dummy session table request to Dynamo and forcing an error if said request doesn't return in n amount of time? Not as precise but would limit the extra installs and cross-platform issues.

I would be happy with that solution, not requiring users to install extra things is a nice benefit.

Thanks for weighing in. I should have been explicit and said that I like @nmonga91's timing and the approach of doing the check when the app starts up.


Progress into the response when calling progress callback on completion

The object is accessible, why not receive it.
At completion, some information into Progress object could be very useful

          1 Warning

:warning:
The library files were changed, but the tests remained unmodified. Consider updating or adding to the tests to match the library changes.

SwiftLint found issues
Warnings

File
Line
Reason

MoyaProvider+Internal.swift
212
Function should have complexity 10 or less: currently complexity equals 14

MoyaProvider+Internal.swift
94
Function should have 5 parameters or less: it currently has 7

  Generated by :no_entry_sign: Danger


Sometimes high load

Describe the bug

Sometimes, apm puts a high load on the CPU.
But I don't know why it happens.
Please let me know if the same thing happens or if you find the reason.
To Reproduce
Steps to reproduce the behavior:
I don't know why it happens.
All I know is that apm continues to run with a high load even after closing.
Expected behavior

apm doesn't put a high load on the CPU.
Screenshots

Desktop (please complete the following information):

OS: Windows 10 Home
Version: 21H1

Additional context

It happened to me too. 4 electron processes were using 100% of the CPU even after APM exited. I will check it out.

This bug can be reproduced by adding throw new Error(); after createSplash(); on main.js:385 and before app.on('activate', () => { on main.js:388.

Also, this happens in ad62aee5bf5d4949397fafdad8d8b3a479279335 and not in a6664df3d3e36d90f58e71380a4beb56a42ae09c after updating to Electron14. Therefore, it may not happen in the future.


Move create tools template to use full ica path name to prevent warnings

Related to:

https://github.com/umccr/cwl-ica/issues/155
https://github.com/umccr/cwl-ica/pull/190
https://github.com/umccr-illumina/cwl-iap/issues/189

Solved by #100


Multiple calls to the changeCellItem() method result in StackOverflowError: stack size 8MB

in your demo

After multiple clicks, an error occurred after sliding left and right

Thanks for the bug report. I have been just fixed this problem.

Why recall  mGestureDetector.onTouchEvent(e) at clickAction?


Make filterBy return a valid load profile

Currently, #filterBy returns a load profile that only contains the filtered detailed load hours. While this works fine for common analytical operations like sum, it's technically an invalid load profile instance and would fail if a user tried to chain another load profile manipulation method off of it (like aggregate or loadShift). This change makes sure that the result of the filter operation is still a 100% valid load profile.

Thinking out loud... do we want to name this something else?

Keeps filter to a javascript convention
Doesn't force us to check all our codebases for the previous use of filterBy

Yeah, that's not a bad idea. Maybe something that implies it's 0ing out values? It's very similar to loadShift when I think about abstractly. Instead of taking a variable load and shifting it by a defined amount, it shifts it by whatever it takes to take it to 0.


After killed and started the app will not receive the messages sent during restart

If you are creating an issue for a BUG please fill out this information. If you are asking a question or requesting a feature you can delete the sections below.
Failure to fill out this information will result in this issue being closed. If you post a full stack trace in a bug it will be closed, please post it to http://gist.github.com and then post the link here.
Bug Information
After killed and started the app will not receive the messages sent during restart
Version Number of Plugin: 2.1.3
Device Tested On: Huawei X2, P8
Simulator Tested On:
Version of VS: 2017
Version of Xamarin: <IP_ADDRESS>
Versions of other things you are using:
Steps to reproduce the Behavior
Start the app, then kill it from the tasks, and send a notification to it, then start.
Expected Behavior
App to receive the push send during the restart.
Actual Behavior
App is not receiving the push send during the restart.
Code snippet
Screenshots

It's PCL Android Native app.

Seems like using the original Chinese firmware of the devices is making the issue, since the Google Play services is installed manually on them,
Going to get more devices for test without chinese firmaware.

These phones have a particular quirk that when the app is force closed that you will no longer be able to receive notifications until the app is restarted. In order for you to receive background notifications:
On your Huawei device go to Settings > Protected apps > check "My App" where.
On your Xiaomi make sure your phone has the "Auto-start" property enabled for your app.
On your Asus make sure your phone has the "Auto-start" property enabled for your app.


Build out the new Marsha site to enable uploads & management of videos

Purpose
We're making a new Marsha site. The first users are instructors and instructor support staff who need to quickly upload many videos and their related files.
We thus focused on that use case as we built our first draft for the new site, building out views for organizations/playlists/videos and an upload view leveraging <UploadManager />.
Proposal

[x] integrate react-query to communicate with the API through a cache layer
[x] leverage the <UploadManager /> to make an upload monitoring view
[x] build organization/playlist/video views using a nested structure and breadcrumbs to facilitate navigation

What we're not doing in this PR:

reach parity with the LTI app on video management (eg. timed text tracks, thumbnails)
add a dashboard/homepage

Current status
I removed code related to TimedTextTrack/Thumbnail management to make this PR lighter right now. I also merged some commits that were easier to split out through a bunch of smaller PRs.
What is left is to write unit tests for the frontend views added in this PR

Note: it should run, use yarn webpack instead of yarn build for the frontend to bypass typescript not passing.

Part of this PR is cherry-picked on https://github.com/openfun/marsha/pull/982 as needed for another feature.
Remaining commits are rebased on https://github.com/openfun/marsha/tree/add-mass-upload-rebased @mbenadda

Close as we should merge #1022 instead.


Bump version to 2.0.4

Signed-off-by: Chuck Short<EMAIL_ADDRESS>

[Current coverage][cc-pull] is 97.19%

Merging [#160][cc-pull] into [master][cc-base-branch] will not change coverage

@@             master       #160   diff @@
==========================================
  Files            13         13
  Lines           535        535
  Methods           0          0
  Messages          0          0
  Branches         54         54
==========================================
  Hits            520        520
  Misses            8          8
  Partials          7          7

Powered by Codecov. Last updated by [80c823d...54e1248][cc-compare]
[cc-base-branch]: https://codecov.io/gh/lxc/pylxd/branch/master?src=pr
[cc-compare]: https://codecov.io/gh/lxc/pylxd/compare/80c823d9f3bd4d50bc8091325a418873e174ed7f...54e1248d18f3ab78ba2ca4124235f4253fab686a?src=pr
[cc-pull]: https://codecov.io/gh/lxc/pylxd/pull/160?src=pr

Please merge https://github.com/lxc/pylxd/pull/159 first.

Hi @pcdummy - is there a particular reason why #159 needs to be merged first? At the moment, this is blocking #159 from running tests, so my general logic would be to get this merged first.

Now i understand, shouldn't do 3 things at once. Travis needs this.


CLI interface

Do you think it's consistent with the goal of this module to provide a CLI? There's indexhtmlify that wraps a script in html, but perhaps it's not inconceivable to just generate a html file, full stop. Presumably with command line flags via minimist, which would be pretty simple to implement. I'm glad to submit a PR but thought it worthwhile to test the water before bothering 😄

Just found create-html that appears a perfectly good fit. 👍


[Parameter Request] COD 225 - OnSelectCustLedgEntryOnAfterSetFilters(AccNo)

In COD 225, function SelectCustLedgEntry, we'd like to allow selecting customer ledger entries in case the customer (AccNo) is not filled on the journal line as well. We've implemented a feature of 'head' customers to group customers from a same master company together. When applying, we might not know the exact customer, so we want to filter the ledger entries on 'head' / group customer instead to allow easier retrieval of the right customer.
Therefore, following code line is added in SelectCustLedgEntry
IF (AccNo <> '') THEN //NVTBE-0064/Apply also via headcustomer
  CustLedgEntry.SETRANGE("Customer No.",AccNo);

The new publisher OnSelectCustLedgEntryOnAfterSetFilters could support us in moving this code away, but therefore we need access to the 'AccNo' value in the publisher
LOCAL [IntegrationEvent] OnSelectCustLedgEntryOnAfterSetFilters(VAR CustLedgerEntry : Record "Cust. Ledger Entry";GenJournalLine : Record "Gen. Journal Line"; AccNo)
Please update the OnSelectEmplLedgEntryOnAfterSetFilters, OnSelectVendLedgEntryOnAfterSetFilters events accordingly.

You already have events to implement this here

@AlexanderYakunin. Do'nt know how I can workaround the suggested code, but I think I would at least need access to the 'AccNo' variable in the 'OnSelectCustLedgEntryOnAfterSetFilters' pusblisher (or GlobalVarAccess?), which is not available in BC 140 Cu1 as far as I could see...

@jobulsin Not sure based on the comments of AlexanderYakunin vs the Label 'ships-in-future-update' if the requested parameter is accepted?

You don't need this change. Field Customer No. in CustLedgEntry already filtered by AccNo, so you can easily do GETFILTER to get AccNo in your code.


If redis sockets are closed Redix does not complain at the exact moment the socket closes

Hey,
I was wondering if this a decision made or just something left behind.
I have noticed that If I open some Redis connections and then close Redis server, Redix will only start to complain once I start to make calls again.
It will return something like
{:error, %Redix.ConnectionError{reason: :closed}}
The only way to make Redix notice that sockets are closed was to add Port.monitor(socket)

My problem is that I have a pool of conns, and because they don't know if the port is open the pool will checkout a conn that is broken, creating a crash instead of directly checking a conn that has a healthy socket.
I've read https://hexdocs.pm/redix/reconnections.html#content and I understant that I should handle reconnections but imo whould be nicer to just be able to monitor the port if I want in order to handle myself the reconnections at the moment the socket closes.

@saulbensach Redix will reconnect in the background, yes. This is the desired behavior in most applications in my experience. However, Redix supports the :exit_on_disconnection option, which will cause the Redix process to exit if the socket connection breaks or is closed. You can use this and monitor the process in your pool to implement what you want. I'm going to close this as I think it solves your issue, but feel free to reach out again if you're still having trouble 🙃


[fastlane] Version bump

Fixed OneOff actions not loading the built-in fastlane actions (#5015)
Add CI configurations to plugin template (#5011)
Updated rubocop code style rules
Log SSH output as it is received (#4662)

😄 👍


Service Task followed by Message Catch Events

Hi. I was testing few things and found a strange bug. When we have a service task followed by a message catch event like given in the screenshot below, and if I use  complete.success(updatedWorkflowObj) to complete the worker followed by publishMessage() immediately in succession, the message catch event is not received by Zeebe.
I have to rather add a setTimeOut or delay before I do publishMessage() to the workflow post complete.success.
My assumption here is that the workflow receives the message event faster than it receives the task complete event (not sure though). Are the protocols used for both message catch event as well as task worker completion the same? If yes, may I know if the order in which such events are published are preserved/queued?

The message subscription in this case is created when the token hits the catch event. Publish the message with a TTL, or put this in a sub-process. See the last two sections here: https://zeebe.io/blog/2019/08/zeebe-message-correlation/


JOSS Review "Authors" [Minor]

The submitting author: Kivan Polimis, has not institute listed, while the others have is this intentional ?

added: eScience Institute, University of Washington for Kivan Polimis


TD-831: Allow adjustment change of amount in Payment in failed state

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

1 of 1 (100.0%)  changed or added relevant line in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 90.207%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
4523

Relevant Lines:
5014

💛  - Coveralls


[Enhancement] Files commited with CRLF line endings

Existing/related issue?
No response
Please describe the new behavior that that will improve Egeria
While working on PR conflicts IntelliJ showed me Line Separator Warning like this:

For now committed as-is but this triggered me to check what we have across this git repo and this is the result:
> git ls-files --eol | grep "w/crlf"
i/crlf  w/crlf  attr/                 	Community-Guide.md
i/crlf  w/crlf  attr/                 	gradlew.bat
i/crlf  w/crlf  attr/                 	open-metadata-implementation/adapters/open-connectors/data-store-connectors/file-connectors/csv-file-connector/src/test/resources/ComplexColumnsWithColumnNames.csv
i/crlf  w/crlf  attr/                 	open-metadata-implementation/adapters/open-connectors/data-store-connectors/file-connectors/csv-file-connector/src/test/resources/NoColumnNames.csv
i/crlf  w/crlf  attr/                 	open-metadata-implementation/adapters/open-connectors/data-store-connectors/file-connectors/csv-file-connector/src/test/resources/SimpleColumnsWithColumnNames.csv
i/crlf  w/crlf  attr/                 	open-metadata-implementation/adapters/open-connectors/event-bus-connectors/open-metadata-topic-connectors/kafka-open-metadata-topic-connector/src/main/java/org/odpi/openmetadata/adapters/eventbus/topic/kafka/KafkaOpenMetadataEventConsumer.java
i/crlf  w/crlf  attr/                 	open-metadata-resources/open-metadata-deployment/sample-data/coco-pharmaceuticals/data-files/CompDir-ContactEmail.csv
i/crlf  w/crlf  attr/                 	open-metadata-resources/open-metadata-deployment/sample-data/coco-pharmaceuticals/data-files/CompDir-ContactList.csv
i/crlf  w/crlf  attr/                 	open-metadata-resources/open-metadata-deployment/sample-data/coco-pharmaceuticals/data-files/CompDir-ContactPhone.csv
i/crlf  w/crlf  attr/                 	open-metadata-resources/open-metadata-deployment/sample-data/coco-pharmaceuticals/data-files/EmplSAnl-EmpSalaryAnalysis.csv
i/crlf  w/crlf  attr/                 	open-metadata-resources/open-metadata-deployment/sample-data/coco-pharmaceuticals/data-files/Employee-Dept.csv
i/crlf  w/crlf  attr/                 	open-metadata-resources/open-metadata-deployment/sample-data/coco-pharmaceuticals/data-files/Employee-Employee.csv
i/crlf  w/crlf  attr/                 	open-metadata-resources/open-metadata-deployment/sample-data/coco-pharmaceuticals/data-files/Location-WorkLocation.csv
i/crlf  w/crlf  attr/                 	open-metadata-resources/open-metadata-deployment/sample-data/coco-pharmaceuticals/data-files/Patient-Patient.csv
i/crlf  w/crlf  attr/                 	open-metadata-resources/open-metadata-deployment/sample-data/coco-pharmaceuticals/ldap/02-users.ldif
i/crlf  w/crlf  attr/                 	open-metadata-resources/open-metadata-deployment/sample-data/coco-pharmaceuticals/ldap/03-groups.ldif
i/crlf  w/crlf  attr/                 	open-metadata-resources/open-metadata-samples/access-services-samples/asset-management-samples/CompanyDirectoryDatabase.csv
i/crlf  w/crlf  attr/                 	open-metadata-resources/open-metadata-samples/access-services-samples/asset-management-samples/ContactList.csv

Not worried about most of the files as it may be relevant to have CRLF (i.e. in bat file) but the question is do we standardize this?
At minimum we should convert the .java source file to use LF for consistency.
open-metadata-implementation/adapters/open-connectors/event-bus-connectors/open-metadata-topic-connectors/kafka-open-metadata-topic-connector/src/main/java/org/odpi/openmetadata/adapters/eventbus/topic/kafka/KafkaOpenMetadataEventConsumer.java
thoughts?
Alternatives
No response
Any Further Information?
No response
Would you be prepared to be assigned this issue to work on?
No response

I'm not sure how the git client will handle windows, but the 'gradlew.bat' has been created by the official gradle wrapper, so I would be inclined to leave it as is. We would never expect any manual edits of that file
When the wrapper is updated, it will again create a new .bat file -- for windows users
I do think the others should be changed.

Thanks I am thinking only to change the .java file for consistency.

Closing. Good enough fix #7650


I can't find "Giveaway Extractor" icon anymore.

Icon moved somewhere?

There's really a lot room for improvements with your bug report. You could make life easier for @gsrafael01 and increase the chance of getting your bug fixed if you would add at least some of the information the bug report template suggest like version, addon/script, browser and example page / screen with missing icon.
For me the icon is there on e.g. this page:

Have you checked that giveaway extractor is enabled in the settings and run it here is also enabled and set to everywhere?

Maybe it's hidden in the left / right panels (the button with 3 dots)? You can check the location of the button in the Element Ordering section in the settings menu.

Since there's no response for 7 days and I'm pretty sure the button is just hidden in the left / right panels (same bug as #1309, which has an easy workaround as seen in that issue), I'll close this. Let me know if it's not the same as #1309 and I'll reopen.


Please update cocoapod.

I use TPKeyboardAvoiding thru cocoapods, it doesn't seem to be picking up new updates. The current pod still has a warning for missing [super awakeFromNib]

Done!

Noticed some updates through June. Would love to get a new release and cocoapod released that has the changes since 2016


ex/websites/signupz

What
Basic signup site for now. Someday with private signups using Zcash
Why
I need a signup site anyways. But, it doesn't seem like the existing products are mindful of privacy. So, I'm going to be stubborn and build my own signup site for emails. Someday this site could be even more private with Zcash signups.

Artwork looks dope, where'd you find that? The UI for this site looks sweet!

yeah, I just googled it. It was on some "freepics" type site. But, should figure out who the artist is and do some combination of a) credit b) pay c) teamup


Exited out of Task due to invalid (null) target structure.

Everything works for a duration but when this bug appears its persistent and never goes away.
Bug Effect: Workers stop moving.
Console:
[FactionMemberTask.cs:26] Exited out of Task due to invalid (null) target structure. THIS PROBABLY WILL CAUSE AN ERROR IN COLONIST BEHAVIOUR.

The problem is the StructureList is being populated at the same time the colonists are being assigned the ResourceTask. The solution is to add a boolean to wait for the StructureList to be populated, then allow the colonist to do their ResourceTask or any other task after.
As a side note, the StructureList should not be populated in GameEntity.cs, but rather WorldGenerator.cs.

https://github.com/valkyrienyanko/Survivor/blob/c6c4a6439ef61cd7cbee0ed34d7f19754f9b3ad5/Assets/Scripts/World/WorldGenerator.cs#L39
The count value is being logged as 0, this doesn't seem right.

The issue was due to the parents not being set soon enough.
There were 2 Start() functions being fired at once. One in World and another in Structure, you can not guaranteed, that one Start() will run before the other.


[nfc] clippy lint job

With this we have two lint jobs: Lint / lint  and Tests / lint / bazel. To avoid confusion, can we indicate that the new lint job is for clippy or for Rust? (Ideally we'd have one unified lint job but that does not need to be handled here)

to avoid confusion, can we indicate that the new lint job is for clippy or for Rust?

clang-tidy will also come one day


docs: Fix grammatical errors in README

Fixes
Checklist

[ X] I have made a material change to the repo (functionality, testing, spelling, grammar)
[X ] I have read the [Contribution Guide] and my PR follows them.
[X ] I updated my branch with the master branch.
[X ] I have added tests that prove my fix is effective or that my feature works
[ X] I have added necessary documentation about the functionality in the appropriate .md file
[X ] I have added inline documentation to the code I modified

Short description of what this PR does:

Fixed two gramatical errors in the README.md file

If you have questions, please send an email to Sendgrid, or file a Github Issue in this repository.

Hello @chaman-k,Thanks again for the PR! It's HACKTOBERFEST! We want to show our appreciation by sending                                              you some special Hacktoberfest swag. If you have not already, could you please fill out                                              this form so we can send it to you? Thanks!                                             Team SendGrid DX

Hello @chaman-k,Thanks again for the PR!                                         You have earned 1 out of the 5 points needed to receive glorious SendGrid Hacktoberfest swag.                                         Please take a moment to checkout this link to find more issues to get you past the required threshold or to simply continue the celebration.                                         Also, please be sure you have officially registered with us here by November 1, 2018 to qualify.                                         If you have any questions you can email us at<EMAIL_ADDRESS>                                        Thank you and Happy Hacktobering!                                         Team SendGrid

Hello @chaman-1,Thanks again for the PR! We want to show our appreciation by sending                                              you some swag. Could you please fill out                                              this form so we can send it to you? Thanks!                                             Team SendGrid DX


Don't automatically virtualize two types in the same hierarchy, unless one is deeper than the other

Fixes #2661
Fixes #4303
What this means is that with this PR, the language will now behave like this:
class Foo
end

class Bar < Foo
end

class Baz < Foo
end

var = rand < 0.5 ? Bar.new : Baz.new
typeof(var) #=> Bar | Baz

Previously the type would go up to Foo.
However:
var = rand < 0.5 ? Bar.new : Foo.new
typeof(var) #=> Foo

because Bar < Foo, so that gets "upcasted" to Foo (or Foo+, if you know what I mean).
This makes it possible to have more accurate information about the type of a variable. For example in the compiler's source code we have a TypeDeclaration node whose var is of type ASTNode, where in reality it can only be Var | InstanceVar | ClassVar | Global. So the compiler has some "otherwise, raise bug" that could be removed.
Somehow, compilation times for the compiler don't get much more slower. Memory consumption goes a bit higher (most probably because now there are some union types that previously would go up to ASTNode but not now, so a bit more duplicated code is generated), but I don't think we should care anymore about compile times or memory consumption of the compiler (Slack alone, or Chrome, already consume 1GB from your computer and nobody seems to complain... or maybe yes, but well, "if they do it..."). Or, as usual, we can worry about such things later, or maybe a superhero will come with a compiler rewrite or some patches to improve performance 😛
PLEASE, if you can, checkout this branch, compiler the compiler, and try it in your projects. Many things can happen:

Your code won't compile for some reason. This usually happens when you have [foo, bar], you'll probably now have to write [foo, bar] of T for some T because (taking the above example), Array(Foo) is not compatible with Array(Bar | Baz).
Your code will explode (after fixing possible errors in 1). This is what I'd like to know, as it probably means this PR is buggy.

Once and if we can go ahead with this change, I'd like to revisit #4837, as it can be another great addition for more type safey and accuracy in the language, avoiding useless else raise "Impossible" and generally making the code more robust to changes.

This was a PR I wasn't expecting to see (I thought the issue was unfixable), but you've worked out a simple, easy to understand semantic to work around it, and this PR has made my day. Thank you so much.

Yeah, I was cleaning up branches and I accidentally deleted my old attempt at it. Then I said "maybe I can try it once more and see how bad it was". I probably did something different this time, because it didn't become that much worse.
I think at least in the parser it would be worth it to add explicit casts to ASTNode in a few places to avoid the many different union types. The main issue here is that this is a guess game, unless we somehow provide a tool to list methods or places where big (or not so big) union types are formed. I don't feel comfortable generating redundant code under the hood, but that's how the language worked all the time (in some code spots, usually when you have a big hierarchy like ASTNode has, so I believe it's more relevant in parsers and compilers), and so far it didn't seem to bother anyone other than me, so ai guess it's fine.

I amended the commit to add a few explanatory comments.

I tested this in a few projects (the one that compile with master) and it seems to be working well. We can always revert it if we find out there's a huge problem with this.

Docs about the old behaviour (virtual types) will also have to be updated.

Hey, since this happened, my project (https://gitlab.com/WitchKnight/ParadoxPyramid) can't compile anymore...
First I generated a lot of subtypes for a class using a macro, and then I used the parent type as an umbrella type for all the subtypes and passed an array of the parent type , with possibly all the different subtypes inside. Then I could just pattern match as needed if I needed to do subclass-specific operations.
Here's the error : https://play.crystal-lang.org/#/r/4dpl
I'd like to know a workaround.. tried to include subclasses of a subclass in a type alias and use array of that instead (because then it wouldn't be on the same level)  but I get the same error.

I'll just use a macro to generate the union type of all the subclasses but it feels really dirty

Crystal won't merge subtypes as their parent type anymore, you must specify the parent type explicitly. Using the issue example, you can cast like so, for example:
var = (rand < 0.5 ? Bar.new : Baz.new).as(Foo)

See https://play.crystal-lang.org/#/r/4dqh

You probably want to cast .as(Label) in your to_label method.

wow thanks !