[feature request] callback returning wins (or winrate) vs another agent

When training with different reward functions it's hard to compare 2 bots. A callback capable of running n games between current agent and another would prove useful to measure progress.
I will look into it but if someone knows how to do that help is welcome.

Good idea.
This here is probably the closest existing code to it:
https://github.com/glmcdona/LuxPythonEnvGym/blob/c5d4c161b8aa0c4d5ca7ef08ab1d597be81a7883/luxai2021/env/lux_env.py#L14
And example usage:
https://github.com/glmcdona/LuxPythonEnvGym/blob/c5d4c161b8aa0c4d5ca7ef08ab1d597be81a7883/examples/train.py#L114
You can also look at the built-in eval callback:
https://github.com/glmcdona/LuxPythonEnvGym/blob/c5d4c161b8aa0c4d5ca7ef08ab1d597be81a7883/examples/train.py#L136


Error generate code to RTL with blackbox

when I want to convert code chisel to verilog with black box, I have error :

[error] /data/workspace/chisel/chisel3-3.1.8/src/main/scala/tap/dti_bypass_register.scala:45:18: overloaded method value execute with alternatives:
[error]   (args: Array[String],dut: () => chisel3.experimental.RawModule)chisel3.ChiselExecutionResult
[error]   (optionsManager: firrtl.ExecutionOptionsManager with chisel3.HasChiselExecutionOptions with firrtl.HasFirrtlOptions,dut: () => chisel3.experimental.RawModule)chisel3.ChiselExecutionResult
[error]  cannot be applied to (Array[String], () => dti_bypass_register)
[error]   chisel3.Driver.execute(args, () => new dti_bypass_register)
[error]                  ^
[error] one error found
[error] (Compile / compileIncremental) Compilation failed

What is wrong? How can I fix it? My code is here
`import chisel3._
import chisel3.util._
class dti_bypass_register extends BlackBox with HasBlackBoxResource {
val io = IO(new Bundle {
val clk_DR             = Input (Clock())// Bypass register clock
val TDI                   = Input (UInt(1.W))// data in
val bypass_en       = Input (Bool())// enable signal
val captureDR       = Input (Bool())// captureDR signal
val TDO_bypass      = Output (UInt(1.W))// Serial data out

})
setResource("/dti_bypass_register.v")
}
object dti_bypass_registerDriver extends App {
chisel3.Driver.execute(args, () => new dti_bypass_register)
}`

Maybe you forgot to wrap your Blackbox module with chisel3.Module class.
The 2nd argument of chisel3.Driver.execute must need to pass subclass of RawModule.
You should try to make wrapper module to wrap your Blackbox module class like this:
class dti_wrapper extends Module {
  val io = IO(new Bundle {
    val clk_DR = Input (Clock())// Bypass register clock
    val TDI = Input (UInt(1.W))// data in
    val bypass_en = Input (Bool())// enable signal
    val captureDR = Input (Bool())// captureDR signal

    val TDO_bypass      = Output (UInt(1.W))// Serial data out
  })

  val mod = Module(new dti_bypass_register)

  io <> mod.io
}

yeb, it is reason why I make this error. I fixed it. Thanks you so much!

Great to hear it!


feat: add examples

Describe the feature you'd like to request
Keeping in mind that the current docs are still WIP, it's still hard to set up novel.
Adding a few examples should help with the DX.
Describe the solution you'd like to see
Add multiple examples, use npx to initialize them

[ ] Next.js + Tailwind (Shadcn-ui)
[ ] Next.js + AI example
[ ] Next.js + CSS
[ ] Astro + Tailwind (Shadcn-ui)

Additional information
No response

Next.js + Tailwind (Shadcn-ui)

@andrewdoro Please add the example of ;
Nextjs + Tailwindcss and
Nextjs + Tailwindcss + Shadcn
Looking forward


Add support for SSD1322 OLED display driver

Initial support for SSD1322 OLED display driver. Only 1 bit color mode is supported. It it inspired by existing driver for SSD1306. Tested on 3.2 inch 256x64 module (https://www.buydisplay.com/white-3-2-inch-arduino-raspberry-pi-oled-display-module-256x64-spi)

@jfischer-no could you provide feedback on this PR to move it forwards?

ping @jfischer-no


Abandonned dependency

On composer install first execution, there is a warning output:
Package liip/doctrine-cache-bundle is abandoned, you should avoid using it. Use doctrine/doctrine-cache-bundle instead.

This dependency is now removed. Thanks @mickaelandrieu!


READMES with "mustache" strings cause the page to be blank

Directory Lister Version
v3.0.0-beta.3
PHP Version
All
HTTP Server
All
Describe the bug
When a README contains "mustache" strings (i.e. {{ anything }}) the page fails to display due to Vuejs attempting to render a value that doesn't exist.
Steps To Reproduce

Add a README with mustache strings to any directory
Enable the DISPLAY_READMES option
Navigate to the directory with that README file

Expected behavior
The page should display and the README should render properly.
Additional context
Add any other context about the problem. Error logs would be very helpful here.

Resolved by cdfd23c


Decoupled templating functionality from file IO

Templates could've only been generated using data from files and the output had to be written to a file to.
GenerateTemplate now allows one to generate templates from and to io.Reader and io.Writer objects respectively.
This can come in handy in situations where the data is generated/manipulated dynamically (say, through a web ui).

@adamreese or @michelleN  Can we get another code review on this? I'd like to merge it for the next release.
@colonelmo Thanks for this. And I am sorry for the delay in responding. That was my fault.


fix getString method doesn't work as expected for issue #1446

What this PR does / why we need it?
fix getString method doesn't work as expected for issue #1446
方法判断条件里增加了 TemporalAccessor，经测试 对于 java.time下的类，getString 方法与 fastjson的 getString 返回结果一致

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

JSONArray的getString方法也一并改了吧

您好，改好啦


Cleanup and refactoring

DRY/refactor common parts of std.ddoc and doc.ddoc (continuation of #852)
Clean up unused macros

The cleanup and refactoring is an important step towards having a consistent style on *.dlang.org.

Ah, so nice. I wanted to do the DDOC= consolidation forever, and I was planning on using exactly the same ROOT trick. Thanks!


Add new Commands

Can you add more commands.
Some ideas:

passwd (Change password)
gsetting (Change settings from the system)

Added new Commands:

ls / dir

/ < (bash)

added external lib imports

added setenv instead of gsetting

Password change is only available if its a OS version like in DZ OS


onBackdropPress does not work on 11.3.0

Environment
System:
OS: Windows 10
CPU: (4) x64 Intel(R) Core(TM) i5-6600K CPU @ 3.50GHz
Memory: 19.84 GB / 31.94 GB
Binaries:
Node: 12.7.0
Yarn: 1.17.3
npm: 6.9.0
IDEs:
Android Studio: Version  <IP_ADDRESS> AI-183.6<IP_ADDRESS>92245
Platforms

Versions

Android:
iOS:
react-native-modal: 11.3.0
react-native: 60.4
react:16.8.6

Description
With the new 11.3.0, onBackdropPress does not work. I am not using a custom backdrop. Downgraded to 11.2.0 and it works again.

Thanks for the report @jslok
I did some debugging and this happens because the change introduced in 11.3.0 doesn't make the backdrop touchable when the Modal prop coverScreen is set to true (which is the default value).
I will make a PR when I get free time, unless someone does it first.

Thanks @jslok 🙏
Just sent #339 ... I can't test it right now though, anyone willing to check it?

Wow that was fast. I just reported it this afternoon.
11.3.1 works great for me. Thanks!

All thanks to @kenyontu :)

On iPhone XS Max is still not working.

for me it doesn't work as well iPhoneX

It's broken, just tested it.

Seems to be fixed in 11.3.1. Make sure you don't have a view with 100% height/width above the backdrop, in which case the touch event wont be caught by the underlying backdrop.

@rewieer I have simple view inside modal and still doesn't work, for Android works okay but for IOS press on the backdrop, doesn't work. I have IPhoneX - 12.4 and the newest modal version. Why yesterday you said it is broken and today it is working for you? Can you provide code which didn't work for you and this one which works for you today?

@redbluenat Yesterday I was using RN 11.1.0 and noticed the very same problem. Today I upgraded to 13.1.0 and it wasn't working either. After careful debugging I realized I had a view that spawned all above the backdrop, such that events wouldn't propagate to the backdrop. Fixed it and it reworked again.
Can you provide some sample repository of a code that doesn't work ? That'd be easier for me to try and debug what's happening. Of course if you can try to debug and find the root cause, you can either point me to the problem or submit a PR.

If coverScreen  is false then onBackButtonPress in android doesn't work.
"react-native": "0.61.5",
"react-native-modal": "11.5.6",

Same here, with 11.5.6 version.
When using converScreen={false} or have a custom backdrop (simple view) the onBackButtonpress doesn't work.
To get work i needed to do a workaround like this:
customBackdrop={         <TouchableWithoutFeedback           onPress={dismiss}         >           <View             style={{               flex: 1,               backgroundColor: '#000',               marginTop: 56,             }}           />         </TouchableWithoutFeedback>       }

I just managed to make a PR for this. In urgent cases, you can just get code from my repository

Finally... I fixed this bug in #485. Hope my PR is merged soon.

Same here, with 11.5.6 version.
When using converScreen={false} or have a custom backdrop (simple view) the onBackButtonpress doesn't work.
To get work i needed to do a workaround like this:
customBackdrop={
  <TouchableWithoutFeedback onPress={dismiss}>
    <View
      style={{
        flex: 1,
        backgroundColor: '#000',
        marginTop: 56,
      }}
    />
  </TouchableWithoutFeedback>
}

Thanks! this worked for me.

RELOAD the iOS emulator! This happened to me I tried loads of stuff, then noticed it's fine for my friend. Reloaded the emulator and it's fine.


Same fix for lost CRS attributes for load_clearlandsat

Same fix for missing CRS when changing dtype

looks good to me. thanks


MajorityFilter tool produces bad result in some cases

MajorityFilter tool produces bad result in some cases. Please test with input.tif from https://drive.google.com/drive/folders/1GL7g5AUyNP3TuHeDc2_aaVX5O8eohQPb?usp=sharing with comand whitebox_tools -r=MajorityFilter -v --wd=. -i=input.tif -o=output.tif --filter=15.
I am using latest version of the app from today and branch master.

I'll look more closely at this afterwards, but I suspect the issue isn't the filter, but rather the size of the raster. WhiteboxTools doesn't support the BigTIFF format, which is likely needed for a raster with 42997 x 46497 rows and columns.

I am getting invalid results also if I create input geotiff with gdalwarp and -co BIGTIFF=NO parameter.
But actually the problem is with the compression DEFLATE (PREDICTOR=2). When I used no compression then the result was fine.
Feel free to elaborate id a little more and close it or transform to a different isue (like "add support for DEFLATE"?).

Same problem is with FeaturePreservingSmoothing if input GeoTIFF has this compression:
  COMPRESSION=DEFLATE
  INTERLEAVE=BAND
  PREDICTOR=2


docs: make it obvious that extensions don't work with nested reads/writes

I found this caveat buried in one of the examples:

NOTE: Query extensions do not currently work for nested operations. In this example, validations are only run on the top level data object passed to methods such as prisma.product.create(). Validations implemented this way do not automatically run for nested writes.

This seems like a pretty important caveat that should be in a more-obvious place (perhaps the extension docs site).

Potentially related issue: https://github.com/prisma/prisma/issues/20780.

I believe the issue is stemming from the fact that extensions don't allow for nested CRUD operations because that is essentially what a connect/disconnect/set through one of the models would be.
What would the recommended workaround for this be?

I have built a solution on the assumption that this works well. It was a big surprise when I had to realise that this feature really doesn't work for nested queries and then I have found these issues.
My use case: I have introspected an existing database and generated a graphql api for it with typegraphql prisma. The generated api uses selects in nested queries. I am implementing an i18n layer for the api which will translate the api responses with the i18next package. To do so I need to modify the responses and replace the original content with the translated version. Originally I was using a result extension, but that's not good because in a nested query case the model names don't match.
Example: I have locations which are also available through a regions model. The regions query is using select to include locations.
I have found 2.5 workarounds:
1 use query extension and chain the modification
Inside the then the params.__internalParams.dataPath["select", "<actual_model_name>"]
prisma.$extends({
      name: 'debug',
      query: {
        $allModels: {
          $allOperations(params) {
            /* your custom logic for modifying all operations on all models here */
            // console.log('---', model, operation, JSON.stringify(args))
            return params.query(params.args).then((res) => {
              console.log(
                '---',
                JSON.stringify(params, null, 2),
                JSON.stringify(res),
              )
              return res
            })
          },
        },
      },
    })

2 use a middleware
The trick is the same, it's just easier to access the variable in params.dataPath["select", "<actual_model_name>"]
  prisma.$use(async (params, next) => {
    const result = await next(params)

    console.log('---', JSON.stringify(params))
    console.log('---', JSON.stringify(result))

    return result
  })

0.5
In the applyAllResultExtensions the necessary infrastructure seems to be in place and since the visitQueryResult is meant to be recursively traversing the tree my assumption is that the current behavior is a bug. This function was introduced in #20438.

Hi all,
I have created a package that allows you to create extensions that work with nested operations: https://github.com/olivierwilkinson/prisma-extension-nested-operations. Writing extensions for nested operations means you need to account for the different format of nested operation args, so make sure to read the README and to test thoroughly before putting anything out to production 👍


Telegram Notification

Is there a possibility to test the Telegram notification?

With one of the latest commits there should be a notification at bot startup.

I get a badly started up chromium (url looks like "data;") when setting
telegramEnabled = false

This issue is not relevant anymore, please close it.
The Telegram integration is working with the current master version and also with the latest docker image.


Is there a way to set resource to vertical resource orientation

Currently, Resources are arranged horizontally (one next to another). So, how about vertical resource orientation (like under image). Will it be supported too?

In next release, you can try resourceViewMode="vertical"
caveat: header days are not sticky for now

Great! Thank you for your support


feat: Migrate 'Create React App' to 'Next.js'

Summary:

Added TypeScript support.
Implemented routing using the Pages Router.

Next Steps (To Do):

Refactor existing components to align with the new Pages Router structure.
Remove any other redundant React configurations.

Everything looks good to me :)


Implement AUC

Area-under-curve is something that would be super useful for diagnostic/descriptive purposes.

Agreed @christophertubbs. I think an ROC chart would be really nice.

Area-under-curve is something that would be super useful for diagnostic/descriptive purposes.

Can you be more specific? Is this AUC for any arbitrary function or AUC for a single valued time-series, something else?
How does the interface look? What's the expected return value?
from hydrotools.metrics import metrics

AUC = metrics.area_under_curve(
    parameter_1=something,
    parameter_2=something_else
)

I think we're looking at:
from hydrotools.metrics import metrics
x = [0, 1, 3, 5, 6, 7, 8, 9, 10]
y = [13.7, 14.5, 8.7, 6.66, 5.8, 3.85, 10.1, 11, 19.8]

AUC = metrics.area_under_curve(x, y)

print(AUC)

96.64
It'll be the auc for a single valued time series. I think? I have a little more research to do to figure out all that we'll need to do with it. At this point I mostly just know that we need it and people get ornery if I break out sklearn. I think we do/will need the roc chart, but it hasn't been brought up yet.
Now, what would be REAL cool is if we could get an array back instead of a single value, so we'd get the AUC for x[:2], x[:3], x[:4], etc, so we can see the change in auc over time. That's more of a "Neat! How can we use that?" idea, though.

OK, this looks like numerical integration. I didn't do the math, but it looks like you're using a typical LHS (left-handed) Riemann Sum to compute the "area under the curve" of the function y(x). This is doable, but will require a little bit of design to allow for different quadrature rules. We'll also want to check for basic continuity/smoothness (i.e. the independent variable needs to be uniquely valued and increasing). We'll also need checks at the ends of the interval. I think the example you posted might need one more x-value to compute the last rectangle.
I'd be surprised if there isn't already a library that does this, but if not I don't have a problem adding this functionality.

sklearn learn does it :D
That's where I got all the math.

get the AUC for x[:2], x[:3], x[:4], etc, so we can see the change in auc over time

Derivatives, derivatives, derivatives, derivatives.....Remember, don't drink and derive.

Do I look like I remember anything from math in college?

sklearn learn does it :D
That's where I got all the math.

scikit-learn already has these methods. I don't think we should be reinventing the wheel. One of the motivations of hydrotools being a Python package suite was potential interoperability with popular well-established scientific computing libraries. The hydrotools.metrics package re-implements some basic metrics for convenience, but the vast majority of the metrics in this package are specific to hydrological evaluation and at the time of development weren't known to exist in other well-maintained modern packages. The interfaces were also modeled after similar metrics methods in sklearn and scipy. So, my vote is to use sklearn.
https://scikit-learn.org/stable/modules/generated/sklearn.metrics.auc.html
https://scikit-learn.org/stable/modules/generated/sklearn.metrics.roc_auc_score.html

Alrighty, closing the issue.

Is it worth wrapping the method under the hydrotools package to ensure a uniform interface? If not, then it is probably worth some documentation on how to use scikit/scipy with hydrotools data in conjunction with methods provided by the package.

Is it worth wrapping the method under the hydrotools package to ensure a uniform interface? If not, then it is probably worth some documentation on how to use scikit/scipy with hydrotools data in conjunction with methods provided by the package.

Yes, we've discussed adding some example workflows to the repository documentation. An annotated notebook demonstrating how to combine nwis_client, nwm_client, and sklearn is a good idea.


hiscore api: add Callisto and Cerberus

Jagex finally added them to the index_lite format :tada:

Updated the test


In Oniguruma LoadWasm function, node fs buffer works fine but vscode.workspace.fs buffer does not work.

Does this issue occur when all extensions are disabled?: Yes

VS Code Version: 1.65.0-insider (user setup)
OS Version: Windows 10 Pro 21H2

I'm not sure that it is a bug, but it is a very strange behavior. I'm building a VSCode extension. I'm trying to load oniguruma wasm with vscode.workspace.fs buffer, it does not work, but node fs buffer works fine. I don't want to use node fs, because I want my extension to be a web extension (as well as desktop extension).
Steps to Reproduce (See full code down below, after the gif):

The code:
import * as vscode from "vscode";
import * as path from "path";
import * as nodeFs from "fs";

import myOniguruma = require("vscode-oniguruma");
const myOnigurumaPath = require.resolve("vscode-oniguruma");

const myWasmPath = path.join(
    myOnigurumaPath.slice(0, myOnigurumaPath.length - 7),
    "onig.wasm",
);
const myWasmPathUri = vscode.Uri.file(myWasmPath);

vscode.workspace.fs.readFile(myWasmPathUri).then((myUint8Array) => {
    const vscodeFsBuffer = myUint8Array.buffer;
    console.log("vscodeFsBuffer: ", vscodeFsBuffer);

    const nodeFsBuffer = nodeFs.readFileSync(myWasmPath).buffer;
    console.log("nodeFsBuffer: ", nodeFsBuffer);

    myOniguruma.loadWASM(nodeFsBuffer) // this works fine --------------------------------
    // myOniguruma.loadWASM(vscodeFsBuffer) // this does not work ----------------------------
        .then((x) => {
            console.log("successful");
        })
        .catch((error) => {
            console.log("error: ", error);
        });
});

The error:
message:'WebAssembly.instantiate(): expected magic word 00 61 73 6d, found 01 00 00 03 @+0'
stack:'CompileError: WebAssembly.instantiate(): expected magic word 00 61 73 6d, found 01 00 00 03 @+0'

rejected promise not handled within 1 second: Error: Must invoke loadWASM first.

@leodevbro Uint8Array is a view on an ArrayBuffer. That means that the Uint8Array can use only a part of its underlying .buffer, namely the part from .byteOffset and of length .byteLength:
interface ArrayBufferView {
    /**
     * The ArrayBuffer instance referenced by the array.
     */
    buffer: ArrayBufferLike;

    /**
     * The length in bytes of the array.
     */
    byteLength: number;

    /**
     * The offset in bytes of the array.
     */
    byteOffset: number;
}

So in this particular case this is a programming mistake.
However, I can see how you would now need to create a new Buffer of the right size and copy the parts of the other Buffer into the new one, so I have pushed a change to vscode-oniguruma to accept an ArrayBufferView, so you will be able to use myOniguruma.loadWASM(myUint8Array)

@alexdima, huge thanks, it's working, really appreciate that you updated vscode-oniguruma package.


Navbar Improved

I have made changes in the following pages -
⭐ Header - logo added and active page styling has been included. The navbar is fully functional
⭐Footer - logo added in the footer.
If there is anything to be changed then you can let me know.
Thank you for letting me work on this issue.

I have made changes in the following pages -
⭐ Header - logo added and active page styling has been included. The navbar is fully functional ⭐Footer - logo added in the footer.
If there is anything to be changed then you can let me know. Thank you for letting me work on this issue.

I could able to see logo

U need to merge in order to view the chhanges, since I've added a new logo file.

U need to merge in order to view the chhanges, since I've added a new logo file.

Here, I can see the preview of the website before PR merging. Please check it in your local system to ensure it has been properly applied.
In React, you should avoid adding a direct path in the image src attribute. Instead, you should first import the image at the top of the file and then use that imported reference in the src attribute.
Check this blog for reference:
https://stackabuse.com/importing-images-with-react/

Okay sure, I'll update it and create another pr. Sorry, for the inconvenience.


Texture Handler draws incorrect colors to atlas from greyscale textures

Vanilla minecraft anvil texture which is set to use a greyscale pallet

And how it renders ingame

Texture dump showing that its incorrect on the atlas itself

Texture when its export using an RGB pallet

Raw textures used

Is this relevant still?

Probably, I never fixed it and I dont think anyone else did


fix: Ref transform being applied to variables named hasOwnProperty.

Given the variable var hasOwnProperty = Object.prototype.hasOwnProperty running through the transformer will result in
https://github.com/vuejs/vue-next/blob/master/packages/ref-transform/src/refTransform.ts#L313
id.name being hasOwnProperty which will return truthy for all objects. So instead we check for strict equality. We will only get properties flagged true in the scope passing through to be transformed.
This problem is blowing up all applications when using refTransform: true as @vue/shared is doing this exact thing here
https://github.com/vuejs/vue-next/blob/master/packages/shared/src/index.ts#L54
When running vite in dev mode the line below is being transformed to
var hasOwn = (val, key) => hasOwnProperty.value.call(val, key);

This small update will fix that.

@aphex is this a duplicate of https://github.com/vuejs/vue-next/pull/4503 ?
/cc @ygj6

@aphex这是#4503的副本吗？
/cc @ygj6

yes:stuck_out_tongue:

Yup, I will close mine as theirs looks good to me and has a test 😍


Removed unnecessary flake8 exception.

Since #136 we don't need to make an exception for flake8 import checks (using # NOQA instead, which is much better).

+1

+1


[webview_flutter] Allow underscores anywhere for Javascript Channel name

Description
Allow underscores anywhere for Javascript Channel name
Related Issues
https://github.com/flutter/flutter/issues/35011
Checklist

[x] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[x] My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
[x] All existing and new tests are passing.
[ ] I updated/added relevant documentation (doc comments with ///).
[x] The analyzer (flutter analyze) does not report any problems on my PR.
[x] I read and followed the Flutter Style Guide.
[x] The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
[x] I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
[x] I updated CHANGELOG.md to add a description of the change.
[x] I signed the CLA.
[x] I am willing to follow-up on review comments in a timely manner.

Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?

[ ] Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
[x] No, this is not a breaking change.

Seems CI broken is not related.


docs: fix typo in composable name

to be honest it would be better if we renamed the composable to isValidGitHubWebhook (with maybe a duplicate of isValidGithubWebhook for backwards compatibility), but just wanted to update the docs to reflect the name that's currently used before I forgot

Thanks for the suggestion I agree with you!


fix to plural

Codecov Report

Merging #69 (8913808) into main (7a7df8a) will increase coverage by 0.95%.
The diff coverage is 99.81%.

:exclamation: Current head 8913808 differs from pull request most recent head 59086b3. Consider uploading reports for the commit 59086b3 to get more accurate results

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
@@            Coverage Diff             @@
##             main      #69      +/-   ##
==========================================
+ Coverage   98.87%   99.82%   +0.95%
==========================================
  Files          30       28       -2
  Lines         266      588     +322
==========================================
+ Hits          263      587     +324
+ Misses          3        1       -2

Impacted Files
Coverage Δ

...CodeGen.Core/TemplateLoaders/FileTemplateLoader.cs
100.00% <ø> (ø)

...er.Commons.StringHelpers/CasingStringExtensions.cs
100.00% <ø> (ø)

...r.Commons.StringHelpers/GrammarStringExtensions.cs
66.66% <66.66%> (ø)

...ure.DataAttributes/AutoNSubstituteDataAttribute.cs
100.00% <100.00%> (ø)

...tler.Commons.CodeGen.CSharp/CSharpCodeGenerator.cs
100.00% <100.00%> (ø)

...ler.Commons.CodeGen.CSharp/CSharpTemplateLoader.cs
100.00% <100.00%> (ø)

...antler.Commons.CodeGen.CSharp/Model/CSharpClass.cs
100.00% <100.00%> (ø)

....Commons.CodeGen.CSharp/Model/CSharpCompilation.cs
100.00% <100.00%> (ø)

....Commons.CodeGen.CSharp/Model/CSharpConstructor.cs
100.00% <100.00%> (ø)

...CodeGen.CSharp/Model/CSharpConstructorParameter.cs
100.00% <100.00%> (ø)

... and 18 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Vertical scroll to element until it's visible is failing with "Error: [object Object] is not a valid options" exception

While performing vertical scroll to element until it's visible getting the following error:
[HTTP] --> POST /wd/hub/session/acf4933c-8840-4e98-b3e0-c958b8064e8a/execute
[HTTP] {"script":"flutter:scrollUntilVisible","args":[{"ELEMENT":"eyJmaW5kZXJUeXBlIjoiQnlWYWx1ZUtleSIsImtleVZhbHVlU3RyaW5nIjoidHJhY3Rvcl9mb3JtX2xpc3RfdmlldyIsImtleVZhbHVlVHlwZSI6IlN0cmluZyJ9"},{"item":{"ELEMENT":"eyJmaW5kZXJUeXBlIjoiQnlWYWx1ZUtleSIsImtleVZhbHVlU3RyaW5nIjoiU1VCTUlUIFRSQUNUT1IgSU5GT1JNQVRJT04iLCJrZXlWYWx1ZVR5cGUiOiJTdHJpbmcifQ=="},"dyScroll":-256}]}
[debug] [MJSONWP (acf4933c)] Calling AppiumDriver.execute() with args: ["flutter:scrollUntilVisible",[{"ELEMENT":"eyJmaW5kZXJUeXBlIjoiQnlWYWx1ZUtleSIsImtleVZhbHVlU3RyaW5nIjoidHJhY3Rvcl9mb3JtX2xpc3RfdmlldyIsImtleVZhbHVlVHlwZSI6IlN0cmluZyJ9"},{"item":{"ELEMENT":"eyJmaW5kZXJUeXBlIjoiQnlWYWx1ZUtleSIsImtleVZhbHVlU3RyaW5nIjoiU1VCTUlUIFRSQUNUT1IgSU5GT1JNQVRJT04iLCJrZXlWYWx1ZVR5cGUiOiJTdHJpbmcifQ=="},"dyScroll":-256}],"acf4933c-8840-4e98-b3e0-c958b8064e8a"]
[debug] [FlutterDriver] Executing Flutter driver command 'execute'
[debug] [MJSONWP (acf4933c)] Encountered internal error running command: Error: [object Object] is not a valid options
[debug] [MJSONWP (acf4933c)]     at Object.exports.scrollUntilVisible (/Users/okaruk/.nvm/versions/node/v14.13.0/lib/node_modules/appium/node_modules/appium-flutter-driver/lib/commands/execute/scroll.ts:91:11)
[debug] [MJSONWP (acf4933c)]     at FlutterDriver.exports.execute (/Users/okaruk/.nvm/versions/node/v14.13.0/lib/node_modules/appium/node_modules/appium-flutter-driver/lib/commands/execute.ts:48:14)
[debug] [MJSONWP (acf4933c)]     at commandExecutor (/Users/okaruk/.nvm/versions/node/v14.13.0/lib/node_modules/appium/node_modules/appium-flutter-driver/node_modules/appium-base-driver/lib/basedriver/driver.js:330:9)
[debug] [MJSONWP (acf4933c)]     at /Users/okaruk/.nvm/versions/node/v14.13.0/lib/node_modules/appium/node_modules/async-lock/lib/index.js:125:12
[debug] [MJSONWP (acf4933c)]     at AsyncLock._promiseTry (/Users/okaruk/.nvm/versions/node/v14.13.0/lib/node_modules/appium/node_modules/async-lock/lib/index.js:249:31)
[debug] [MJSONWP (acf4933c)]     at exec (/Users/okaruk/.nvm/versions/node/v14.13.0/lib/node_modules/appium/node_modules/async-lock/lib/index.js:124:9)
[debug] [MJSONWP (acf4933c)]     at AsyncLock.acquire (/Users/okaruk/.nvm/versions/node/v14.13.0/lib/node_modules/appium/node_modules/async-lock/lib/index.js:140:3)
[debug] [MJSONWP (acf4933c)]     at FlutterDriver.executeCommand (/Users/okaruk/.nvm/versions/node/v14.13.0/lib/node_modules/appium/node_modules/appium-flutter-driver/node_modules/appium-base-driver/lib/basedriver/driver.js:343:39)
[debug] [MJSONWP (acf4933c)]     at FlutterDriver.executeCommand (/Users/okaruk/.nvm/versions/node/v14.13.0/lib/node_modules/appium/node_modules/appium-flutter-driver/lib/driver.ts:122:22)
[debug] [MJSONWP (acf4933c)]     at AppiumDriver.executeCommand (/Users/okaruk/.nvm/versions/node/v14.13.0/lib/node_modules/appium/lib/appium.js:532:36)
[debug] [MJSONWP (acf4933c)]     at runMicrotasks (<anonymous>)
[debug] [MJSONWP (acf4933c)]     at processTicksAndRejections (internal/process/task_queues.js:93:5)
[debug] [MJSONWP (acf4933c)]     at asyncHandler (/Users/okaruk/.nvm/versions/node/v14.13.0/lib/node_modules/appium/node_modules/appium-base-driver/lib/protocol/protocol.js:300:21)
[HTTP] <-- POST /wd/hub/session/acf4933c-8840-4e98-b3e0-c958b8064e8a/execute 500 2 ms - 209
[HTTP]

Here is complete command written on Ruby:
driver.execute_script('flutter:scrollUntilVisible', by_type('ListView'), {item: by_value_key('submit_btn'), dyScroll: -256})
It should be okay to skip dxScroll value as per Flutter docs - At least one of dxScroll and dyScroll must be non-zero. (https://api.flutter.dev/flutter/flutter_driver/FlutterDriver/scrollUntilVisible.html)
Probably there is a reason of the fail: https://github.com/truongsinh/appium-flutter-driver/blob/master/driver/lib/commands/execute/scroll.ts#L89
I suppose the condition should look like: if (dxScroll === 0 && dyScroll === 0), to not to throw exception when at least one value equals zero

@savy-91 @KazuCocoa is it possible to fix this issue in the same way you did for scroll to allow the horizontal or vertical scroll to element until its visible?
PR: https://github.com/appium-userland/appium-flutter-driver/pull/205/files

Could be. You can try it out with flutter-driver v0.0.33

@okaruk I created a new PR that should fix your error, you can try it here: https://github.com/savy-91/appium-flutter-driver/tree/fix/scroll_until_visible


Create Generic Pages “portfolio”

Automatically generated by Netlify CMS

👷 Deploy Preview for tech-works-for-us processing.

Name
Link

🔨 Latest commit
2561953812deab240f003693ba5390f928cf80cc

🔍 Latest deploy log
https://app.netlify.com/sites/tech-works-for-us/deploys/63dd387825c8cd00080e3ab0


Int128 and Int256

Hi. Thanks for this complete  library
Can you add Int128 and Int256?

I have no plans to add signed integers. Do you really need it? Usually unsigned should be enough, actually all arithmetic operations should be the same.


Add files via upload

Hello, your gentx seems invalid; you have used a wrong chain-id. Make sure you set a correct chain-id when you create your gentx with --chain-id=shentu-rts flag, usually when initializing your directory. Could you resubmit your gentx?


adding gift in F&F invite

When the user adds a gift to the link the CTA at the bottom is not visible.
The user has to scroll to use the CTA which is not as per our design guidelines.

resolved


[BUG]: Fix URL to Sample Application in Quick Start Page

Contact Details
No response
What Happened?
The current link to the sample application in the Quick Start page https://docs.paig.ai/quick-start/index.html is incorrect. The link https://github.com/privacera/notebooks/tree/main/paig-os needs to be updated to https://github.com/privacera/paig/tree/main/notebooks/paig-os
Acceptance Criteria:

Ensure the new link points to the correct path: https://github.com/privacera/paig/tree/main/notebooks/paig-os.

Application Version
N/A
Python Version
N/A
Platform Version
N/A
Affected Browsers
Other
Steps to Reproduce

Click https://docs.paig.ai/quick-start/index.html
Check for

All the Quick Start notebooks and sample applications are also available in the [GitHub repository (https://github.com/privacera/notebooks/tree/main/paig-os)

Relevant Log Output
No response
Code of Conduct

[X] I agree to follow this project's Code of Conduct

this has been fixed.


WIP: Fix Bcrypt implementation and add feature to change Key Stretching Function

refs #16

@davidmigloz if you have time I would welcome a review about broken brycpt fix

Coverage increased (+0.6%) to 86.393% when pulling 671ace00b5851938cc417009c68129ac510364f6 on feat-16-fix-bcrypt into 6955e2dca6f4782a578d61a3585ae5e57aa5394b on master.

Hi Patrick! Thanks for the new implementation I'll review it today.

Sorry I couldn't review it yesterday in the end. I'll do it this evening!

It looks very good, I haven't found anything. Good job 😄

I was wondering whether we can have a better name for FixedBcryptKeyStretcher without the fixed word. What do you think?

Do you have a suggesting. I just wanted to be different from the old BcryptKeyStretcher

BCryptKeyStretcher (with C in capital letter)?  My concern with "fixed" is that one thing is fixed until another bug is found hehe (it shouldn't be the case, but still..)

How about just ArmadilloBcryptKeyStretcher?

Also fine 👍


pyzmq swallows error when attempting connection to blocked port (firewall)

Actual:
The following code swallows a connection error, if the firewall on the server-side blocks the port the client connects to.
import zmq

endpoint = "tcp://{IP}:{PORT}"   # < -- The PORT is blocked by a firewall

zmq_ctx = zmq.Context()
sock = zmq_ctx.socket(zmq.PAIR)
sock.connect(endpoint)  # <--- I would expect an exception thrown here, however this is not the case

sock.disconnect(endpoint)
sock.close()
zmq_ctx.term()  # <--- This blocks infinetely

Instead of throwing an exception the code runs into the zmq_ctx.term() and blocks infinitely, then.
Expected:
Having a possibility to catch such a connection error during initialization phase not during shutdown phase.
Workaround:
Attempt telnet connection before attempting zmq connection on the same endpoint.

Questions about libzmq behavior should generally be directed to the libzmq repo. pyzmq doesn't govern this behavior. libzmq's async connection behavior means that connection events happen in the background, and don't block, which often means errors can't be raised in connect (e.g. you can connect to a peer before it's there, and libzmq will retry until it succeeds).
It does seem like a libzmq bug that disconnect followed by close & term would hang, which is generally reserved for outstanding messages (governed by socket.linger).


Added support to capture video.

Task/Issue URL:
Description
Steps to test this PR
Feature 1

[ ]
[ ]

UI changes

Before
After

!(Upload before screenshot)
(Upload after screenshot)

[!WARNING]
This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

In this stack: 📱 Android: Enhancing video capture capabilities

develop

#4052

#4060   👈

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @anikiki and the rest of your teammates on  Graphite


Lockvar issues: fix get_lhs() object/class access to avoid SEGV; accurate error messages.

get_lval() detects/returns object/class in lval_T
compile_lock_unlock() generate code for bare static access
do_lock_var() check lval for ll_object/ll_class and fail if so.

Details:

Add ll_object/ll_class/ll_oi to lval_T.
In get_lval(), fill in ll_object/ll_class/ll_oi as needed; when no [idx] or .key, check for bare class variable access on the way out.
In do_lock_var() check for ll_object/ll_class; also bullet proof ll_dict case and give Dictionay required if problem. (not needed to avoid lockvar crash anymore)
Add lookup_static(), similar to lookup_local.
In compile_lock_unlock() compile for the class variable case.

This PR gives these vim9class semantics for lockvar in vim9.1

lockvar of a class or object does nothing and no error.
A possible future extension would allow a class to hook into lockvar.
lockvar of a class member is an error.

Behavior differences
Old behavior
TODO: (1) and (5) in both old/new are because the access check in
get_lval() doesn't consider inside class. Not sure there's a simple/clean fix.
class C
    this.v1: number = 1
    public this.v2: number = 2
    public static sv1 = 3
    static sv2 = 4
def Lock()
    lockvar this.v1     # (1) E1335: Variable "v1" in class "C" is not writable
    lockvar this.v2     # (2) SEGV
    lockvar C.sv1       # (3) SEGV
    lockvar sv1         # (4) E1246: Cannot find variable to (un)lock: sv1
    lockvar C.sv2       # (5) E1335: Variable "sv2" in class "C" is not writable
    lockvar sv2         # (6) E1246: Cannot find variable to (un)lock: sv2
enddef
static def SLock()
    lockvar sv1         # (7) E1246: Cannot find variable to (un)lock: sv1
    lockvar sv2         # (8) E1246: Cannot find variable to (un)lock: sv2
enddef
endclass

Behavior with this PR
def Lock()
    lockvar this.v1     # (1) E1335: Variable "v1" in class "C" is not writable *** it is writable
    lockvar this.v2     # (2) E1384: Cannot (un)lock variable "this.v2" in class "C"
    lockvar C.sv1       # (3) E1384: Cannot (un)lock class variable "C.sv1" in class "C"
    lockvar sv1         # (4) E1384: Cannot (un)lock class variable "sv1" in class "C"
    lockvar C.sv2       # (5) E1335: Variable "sv2" in class "C" is not writable *** it is writable, doesn't detect current class is "C"
    lockvar sv2         # (6) E1384: Cannot (un)lock class variable "sv2" in class "C"
enddef
static def SLock()
    lockvar sv1         # (7) E1384: Cannot (un)lock class variable "sv1" in class "C"
    lockvar sv2         # (8) E1384: Cannot (un)lock class variable "sv2" in class "C"
enddef

@yegappan Looking for initial comments, check TODO in the modified source.
Still need to test for various lockvar depths, and add tests in general

Another error case without this PR. lockvar handles list on object in 3 out of 4 cases.
Fails if the object is an argument to a scriptlevel :def, like def F(o: C).
(This PR doesn't handle the error case (yet))
vim9script

class C
    public this.ll: list<list<number>> = [ [1], [2], [3] ]
    def Lock3()
        lockvar this.ll[1]  # OK
    enddef
endclass

var o1 = C.new()
lockvar o1.ll[1]    # OK

o1 = C.new()
o1.Lock3()

o1 = C.new()
def Lock3b()
    lockvar o1.ll[1]    # OK
enddef
Lock3b()

def Lock3(o: C)
    lockvar o.ll[1]     # <<<<< E121: Undefined variable o >>>>>
enddef
Lock3(C.new())

Rebased, and cleaned up some (thanks for earlier review, and hints).
Since I didn't hear "OMG NO", I'll add some (more than I like to think about) tests. I'll take a look about adding cctx to get_lval(); I'll have to investigate where it's called from, probably add a possibly NULL argument, sigh (where's poly when you need her); but first tests.

Now handles this case
vim9script

def Lock(val: any)
    lockvar val
enddef

var d = {a: 1, b: 2}
Lock(d)

@yegappan This should be pretty close. I'd appreciate a comment on the first item below (new flag in lval_T)
Open issues

Add flag to lval_T, see TODO at end of get_lval_special_without_index(), used in do_lock_var() in evalvars.c:2233
Pass cctx to get_lval() for accurate access check.
more tests

@yegappan This PR doesn't handle proper access checks in get_lval(). Since that's a pre-existing condition, I'll take a look at that issue, probably using cctx, after this PR is resolved.

Somewhere in vim9class.txt there should be something that says:
E1391 E1392
Neither object variables nor class variables can be locked.
I didn't see an obvious spot. Maybe it should be in there twice, once for object and once for class.

Are you going to follow up with a separate PR for all the various TODO items?

Yes, that's the plan.

thank you! I think this makes sense. Let me include it!


docs[prep]: add factor ranking for video game

Feasibility 70/100: This largely depends on the type of game we want to make. It can't be too trivial but I think if we really love our game idea then we can definitely make it happen
Real-World Impact 10/100: Making a game isn't anything special, causing movement in the industry would require us to make something truly unique
Productive in Industry 5/100: It's not really relevant to a video game but I left it at 5 as copium
Productive Personally 100/100: I'm a gamer so it's no surprise that I think it would super awesome to make a game
Economic Impact 25/100: I'm not sure if there's a high chance that we make money, but it's not a super low chance either
Socially Responsible 100/100: This has no social effect on the real world it's a video game
Interesting Computationally 70/100: Depends on the game we make but if we want to make a good one we will need to have some cool gameplay mechanics that will require some complexity to their implementations
Interesting Data 60/100: This goes along the same lines as the previous category, but I think the algorithms themselves will be more interesting than the data we're working with
Impressive Data 30/100: This entirely depends on our art style. Designing our own assets, animations and effects might be out of scope but they go a long way in complementing gameplay
Interesting System Integration 80/100: A video game has many components that interact with each other and it'll be really cool to learn how it's all put together
Impressive Documentation Process 20/100: Nobody reads docs unless they see something interesting
Interesting to Develop 100/100: Games are awesome, making them is even cooler
Interesting Infrastructure 5/100: Depends on the game but I'd rather make something that can be run locally that doesn't require any networking
Impressive Infrastructure 5/100: Even if we do make something that requires a network it wouldn't really be any different than what's currently out there
Supervisor(s)/Stakeholder(s) Availability 90/100: I have loads of gamer friends so it'll be easy to get a hold of them

I agree with what's been written here. I would say some of the ratings can be flexible depending on the type of game being built? for example if we decided to make something educational then its real world impact would be higher

I generally agree with Ahmed's comments about how conservative some of the initial ratings here, but I think a big issue right now is we don't have a clear idea of what the game is beyond it is most likely some vague form of a roguelike. We should probably try to sort out the genre, engine, main features in a more clear manner and then review the scores again.
I actually think "Impressive data" could be ranked higher. If we implemented a diablo-style ARPG loot system (random traits + stats) and some form of procedural level generation, the amount of variety the game could have can easily sky rocket. I think the assets and art style of the game are not the only things that could be impressive about the project.

It's a fair evaluation. Although I think this video game is more feasible than we think. Is it very impressive at the end of the day as an overall project? Fairly so, but not jaw-droppingly spectacular that we'd be dealing with queue management on demo day at the expo because of how excited everyone is to view our game.


run: add no_new_privs as runtime option

See proposal making no_new_privs something exposable from Kubernetes. https://github.com/kubernetes/community/pull/180/files#r92733392

Let's hold off on this until kubernetes/community#180 is actually decided.

kubernetes/community#180 is decided in design-proposals/no-new-privs.md (via https://github.com/kubernetes/community/pull/639).
The implementation in Kubernetes is in progress in PR https://github.com/kubernetes/kubernetes/pull/47019 (issue https://github.com/kubernetes/kubernetes/issues/38417), targetting Kubernetes 1.8.


compress: unify Huffman logic in flate and bzip2

The Huffman encoding in both flate and bzip2 is identical except for some minor differences:

bzip2 treats the leading bits in a bitstream as the MSB of a byte, while flate treats the leading bits as the LSB of a byte.
bzip2 allows Huffman codes to be up to 20-bits long, while flate allows codes up to 15-bits long.

Currently, the implementation of Huffman encoding in flate is superior (and faster) to the one in bzip2. The differences are very minor and it should be able to unify the two without any performance hit. We should extract the common logic as compress/internal/huffman.

Looks like an interesting performance optimization and stdlib simplification.  Any plans to work on this personally or is it open for the community in general?

I re-wrote the flate decoder from the ground up in https://github.com/dsnet/compress/tree/d2570c4d5b0229583afd32c7c4767e51f314c608. It uses the unified Huffman logic idea I wrote about here, but I haven't gotten around to merging it into standard library.
The performance is significantly faster than the stdlin implementation (~1.4x).

That sounds great!  I hope it makes it into a future release as those speed improvements would be welcome.


Formlibrary: Service and Distribution models

What is the Purpose?
This PR contains an update to the app formlibrary. It includes general refactoring, testing, update to fixtures and addresses the issues #419 and #412
What was the approach?
This work was gradually done in the branch formlibrary-app-update through the following PRs in order: #504, #508 then #519
Are there any concerns to addressed further before or after merging this PR?
Further work related to the formlibrary models remain to be done
Few branches should be deleted.
Also, do not merge until #519 is merged.
Mentions?
@mikael19 @Kimaiyo077 @andrewtpham

"Work in progress" page will be added under the "Form Library" section instead of the current dropdown options


Reply refactor

At the moment in master we can serve around 17k req / sec, with this change we can serve around 19.5k req / sec.
Is a ~15% improvement, that's good!
But this perf improvement implies an awful API, reply.reply.
Example:
fastify
   .get('/', schema, function (req, reply) {
     reply.header('Content-Type', 'application-json').code(200)
     reply.reply(null, {hello: 'world'})
   })

@mcollina @davidmarkclements do you know any ninja trick to get this perf but have a nice looking API?
ps for the moment I disabled all the test, since all of them will fail.

TODO:
Stream:

[x] Test
[x] Docs
[ ] What to do if pump fails

Reply:

[x] Promises support
[x] Test
[x] Docs
[x] Async/Await support

Also @marchbachman.

Coverage increased (+2.6%) to 98.876% when pulling 0f7fe69b34e9d29dd243ebae5161d0a233178253 on reply-refactor into 1e4f3a013ada54ed85e321deffef358799836925 on master.

I'm 👍 , but we should add support for:

[ ] streams
[ ] promises

before making a full release. I would not like to break things further.
I would love to have an opinion on this refactor by: @davidmarkclements @mcdonnelldean @marcbachman.

@mcollina @davidmarkclements do you know any ninja trick to get this perf but have a nice looking API?

Now that bind is optimized in node v7 that could be an alternative.
Just in case you'd like to keep the callback api.

I haven't benchmarked it yet. Most likely it's not faster than creating a new function.

It's a bit faster than the function instantiation, but slower than new Reply()
https://gist.github.com/marcbachmann/f831e041ab4f04dfadc0861c0f155e6d

@mcollina regarding the streams, I can just add the work done in #26, but there are still some changes to do.
Any opinion on how implement the Promise API? (native es6 or some lib?)
@marcbachmann I'll go with the new Reply, it's faster and .bind works well only on Node ≥ 7.
Furthermore, I think we should call the serialize function only in case the content-type header is setted to application/json, that must be the default if the content-type is not setted.
Something like:
if (!this.res.getHeader('Content-Type') || this.res.getHeader('Content-Type') === 'application/json') {
  this.res.setHeader('Content-Type', 'application/json')

  const str = serialize(this.handle, payload)
  if (!this.res.getHeader('Content-Length')) {
    this.res.setHeader('Content-Length', Buffer.byteLength(str))
  }
  this.res.end(str)
  return
}

this.res.end(payload)

Add the streams work.
As for promises, don't add any deps, we should be able to support them without using the Promise object. My goal is to support async/await in 7+.

Coverage increased (+1.0%) to 97.238% when pulling 6e7cf83debebc35ba4e6c3bf30ffd9592ef7d2c4 on reply-refactor into 1e4f3a013ada54ed85e321deffef358799836925 on master.

I've added the todo list above to track the work to do :)

Coverage decreased (-0.6%) to 95.676% when pulling dd0b8e37bcf7ee01183248468ad62fcf6bbb47d3 on reply-refactor into 1e4f3a013ada54ed85e321deffef358799836925 on master.

Should we wrap the reply.res.end(payload) into a try/catch?
This because if something goes wrong, and payload is not a string/buffer, .end will throw.
Maybe something like
function wrapReplyEnd (reply, payload) {
  try {
    reply.res.end(payload)
  } catch (e) {
    reply.res.statusCode = 500
    reply.res.end()
  }
}

Coverage increased (+0.9%) to 97.222% when pulling c1e12b4a3bddaf745db72fa21410687d1991ec08 on reply-refactor into 1e4f3a013ada54ed85e321deffef358799836925 on master.

@delvedor do not do that, no try catch. Validate the parameters and throw if needed.

Validate the parameters and throw if needed.

So let's leave it as it is, because res.end automatically validates the parameters and throws if they are not correct :)

Not exactly. end() throws in a setImmediate. You should throw on the current stack. You can call cork(), write() and then end() and uncork() inside setImmediate()

This expected to merge in soon? Or holding off for a later major release?

Merging soon, next week probably.

Hi @brwnll thanks for the interest!
We want just to make sure to build a robust api, so in the future we will not need to break it again :)

Coverage increased (+3.2%) to 99.451% when pulling af54594040a46d5a223877f2d7b4202ae874a50d on reply-refactor into 1e4f3a013ada54ed85e321deffef358799836925 on master.

Hey guys, please take a look to the code, is everything ok to you?
Any other suggested change?
ps we reached 300 unit test! 🎉 🎉 🎉

Coverage increased (+3.2%) to 99.482% when pulling e3eca6d78ce1bfa1cd3a5ef9eab0af71b1277cbe on reply-refactor into 1e4f3a013ada54ed85e321deffef358799836925 on master.

Coverage increased (+3.2%) to 99.482% when pulling a658a7d3d4958fce100b02e5bc8c692dd5eeb58b on reply-refactor into 1e4f3a013ada54ed85e321deffef358799836925 on master.

OK for me.
You need me to fill the other point, but on Reply  and Promise are good to go.

Coverage increased (+3.2%) to 99.482% when pulling dfe91038ab1bc7d4de2aaefc1fb81f6c10de5622 on reply-refactor into 1e4f3a013ada54ed85e321deffef358799836925 on master.

Ok, guys, we are almost done here.
Is ok for you how is treated the error inside pump?
Any advice for the stream content-length management?
Regarding the async/await, I think could be a good idea develop that feature in a  separate branch and release this one, since async/await will need some test.

IMHO:

let's have no content-length for streams ATM, and address that in another PR.
the error inside pump should be logged
if we support returning a promise from a handler, we support async/await

Coverage increased (+3.2%) to 99.482% when pulling afe0724787e251874ee25cae9537329f09061482 on reply-refactor into 1e4f3a013ada54ed85e321deffef358799836925 on master.

Coverage increased (+3.2%) to 99.497% when pulling a7c3ae962e12788f8d8a78a3a22072e380639f75 on reply-refactor into 1e4f3a013ada54ed85e321deffef358799836925 on master.

Given that I am a madman, would you mind adding a quick test for https?
https://coveralls.io/builds/9407439/source?filename=fastify.js#L31 and then we'll have 100% code coverage :D.

Coverage increased (+3.2%) to 99.497% when pulling 5296631e6cb7cb3a79235e11f70a19687d96b54f on reply-refactor into 1e4f3a013ada54ed85e321deffef358799836925 on master.

async/await support on node v7 is there.

Coverage increased (+3.2%) to 99.5% when pulling fe2d65cda41b34b13f24b89bf31f01fa2aaa7b5e on reply-refactor into 1e4f3a013ada54ed85e321deffef358799836925 on master.

Coverage increased (+3.2%) to 99.5% when pulling fe2d65cda41b34b13f24b89bf31f01fa2aaa7b5e on reply-refactor into 1e4f3a013ada54ed85e321deffef358799836925 on master.

Coverage increased (+3.2%) to 99.5% when pulling fe2d65cda41b34b13f24b89bf31f01fa2aaa7b5e on reply-refactor into 1e4f3a013ada54ed85e321deffef358799836925 on master.

Coverage increased (+3.2%) to 99.5% when pulling fe2d65cda41b34b13f24b89bf31f01fa2aaa7b5e on reply-refactor into 1e4f3a013ada54ed85e321deffef358799836925 on master.

Coverage increased (+3.2%) to 99.51% when pulling ffd5a0fd7a525a80aa37e0ddb0415bfe5aa62469 on reply-refactor into 1e4f3a013ada54ed85e321deffef358799836925 on master.

Great job! Looks everything good to me.
Now we just need to add this:

Not exactly. end() throws in a setImmediate. You should throw on the current stack. You can call cork(), write() and then end() and uncork() inside setImmediate()

I'll do tomorrow, then I think we can finally merge and release! 🎉🎉🎉


Add ability to quickly change year

Hi,
Firstly, thank you for this widget, it looks nice and was very easy to integrate into my app.
Please could you make it possible to change the year quickly. e.g. Right now if I want to change the year to 1984, that's an awful lot of clicking backwards ...
On widgets that I've used previously, clicking on the year allows the user to navigate through the years.
Many thanks,
Paul

I believe this was done in #33! Freebies.


slow system memory leak of RMC model

Issue: while doing WikiText-103 benchmarks, the system memory usage of RMC increases very slowly. GPU VRAM remains stable.
Setup: anaconda, python 3.6, conda binary of PyTorch 0.4.1. Both CUDA 9.0 + CuDNN 7.1.2 and CUDA 9.2 + CuDNN 7.1.4  have same issues.
Problem: nn.CrossEntropyLoss wrapped inside the forward() of RelationalMemory may be the suspect. Removing it and calculating the loss in the training loop appears to remove the memory leak. But then the VRAM usage will be imbalanced if using multi-GPU with DataParallel.
Maybe related to reference cycle issue link, but it's fixed long ago and some toy examples (nn.CrossEntropyLoss inside the class) showed no leak.
Things tried: gc.collect() and del gc.gargabe[:] here and there. Didn't help.
Possible solution: Just giving up VRAM usage optimization. Have to use adaptive softmax anyway if using large-vocab dataset.

edit: the issue still persists even if loss is calculated outside the model class. Still investigating.

After a brute force memory footprint logging of the forward pass, there are (randomly?) occasional ~0.3MB jumps during dropout, linear and attend_over_memory() function calls. Closing this issue since it seems like a PyTorch bug itself (reference cycle? fragmentation? not sure) and there's not much i can do.

Update: the leak seems to have gone with the latest 1.0.0 release.


Regression in backdrop filter perf benchmark raster time on Android

On the engine -> framework roll in https://github.com/flutter/engine/compare/0e7344ae240d...db0c0b7ca428
https://flutter-flutter-perf.skia.org/e/?keys=X5091b64d31a29b82a43623a80066ad75&requestType=0&selected=commit%3D42869%26name%3D%252Carch&xbaroffset=42869

I was able to verify locally that the change was introduced in https://github.com/flutter/engine/pull/55717

A regression was seen on iOS too: https://flutter-flutter-perf.skia.org/e/?queries=test%3Dbackdrop_filter_perf__timeline_summary&selected=commit%3D42868%26name%3D%252Carch%253Dintel%252Cbranch%253Dmaster%252Cconfig%253Ddefault%252Cdevice_type%253DPixel_7_Pro%252Cdevice_version%253Dnone%252Chost_type%253Dlinux%252Csub_result%253Daverage_frame_rasterizer_time_millis%252Ctest%253Dbackdrop_filter_perf__timeline_summary%252C

I'm unable to capture the frame with xcode, the replay mechanism crashes after the capture.  I reduced the number of blurs to 1 and it still has that problem.

As jonah pointed out, we are blurring the whole area now.  This can be more easily duplicated by looking at AiksTest.CanRenderBackdropBlurInteractive
CanRenderBackdropBlurInteractive-before.gputrace.zip
CanRenderBackdropBlurInteractive-after.gputrace.zip


Optimize base58 decoding with digit table.

Before:
BenchmarkBase58Encode         20          64998995 ns/op           0.08 MB/s
BenchmarkBase58Decode         50          35965928 ns/op           0.19 MB/s
Now:
BenchmarkBase58Encode         20          64131154 ns/op           0.08 MB/s
BenchmarkBase58Decode         50          31986764 ns/op           0.21 MB/s

Coverage remained the same at 90.66% when pulling 87573123e726765d1664cdc48f39be5c2cb27507 on jrick:jrick_base58table into 9dcef5b30f87a84bf5eaf26d5e3c92b51c456bb0 on btcsuite:master.

Don't merge this yet. It may panic on non-ASCII input due to indexing outside of the 7-bit character range.  I'll fix by extending the digit table to 256 bytes.

I was just about to post that it could panic on non-ASCII.

Also, this needs license headers.

Coverage remained the same at 90.66% when pulling cc1eb1e0c759fa862b24078d03d7aaa65212dade on jrick:jrick_base58table into 9dcef5b30f87a84bf5eaf26d5e3c92b51c456bb0 on btcsuite:master.

Coverage decreased (-0.01%) to 90.66% when pulling dca623d4ef069c804bf1c11274be8d8419c105a3 on jrick:jrick_base58table into 9dcef5b30f87a84bf5eaf26d5e3c92b51c456bb0 on btcsuite:master.

Coverage decreased (-0.01%) to 90.66% when pulling dca623d4ef069c804bf1c11274be8d8419c105a3 on jrick:jrick_base58table into 9dcef5b30f87a84bf5eaf26d5e3c92b51c456bb0 on btcsuite:master.

Might want to update the PR description with the new timing for historical purposes.  Looks good.


[flutter_markdown] Custom Builder for 'hr' Tag Not Invoked

What package does this bug report belong to?
flutter_markdown
What target platforms are you seeing this bug on?
iOS
Have you already upgraded your packages?
Yes
Dependency versions
pubspec.lock
# Generated by pub
# See https://dart.dev/tools/pub/glossary#lockfile
packages:
  args:
    dependency: transitive
    description:
      name: args
      sha256: "7cf60b9f0cc88203c5a190b4cd62a99feea42759a7fa695010eb5de1c0b2252a"
      url: "https://pub.dev"
    source: hosted
    version: "2.5.0"
  async:
    dependency: transitive
    description:
      name: async
      sha256: "947bfcf187f74dbc5e146c9eb9c0f10c9f8b30743e341481c1e2ed3ecc18c20c"
      url: "https://pub.dev"
    source: hosted
    version: "2.11.0"
  boolean_selector:
    dependency: transitive
    description:
      name: boolean_selector
      sha256: "6cfb5af12253eaf2b368f07bacc5a80d1301a071c73360d746b7f2e32d762c66"
      url: "https://pub.dev"
    source: hosted
    version: "2.1.1"
  characters:
    dependency: transitive
    description:
      name: characters
      sha256: "04a925763edad70e8443c99234dc3328f442e811f1d8fd1a72f1c8ad0f69a605"
      url: "https://pub.dev"
    source: hosted
    version: "1.3.0"
  clock:
    dependency: transitive
    description:
      name: clock
      sha256: cb6d7f03e1de671e34607e909a7213e31d7752be4fb66a86d29fe1eb14bfb5cf
      url: "https://pub.dev"
    source: hosted
    version: "1.1.1"
  collection:
    dependency: transitive
    description:
      name: collection
      sha256: ee67cb0715911d28db6bf4af1026078bd6f0128b07a5f66fb2ed94ec6783c09a
      url: "https://pub.dev"
    source: hosted
    version: "1.18.0"
  cupertino_icons:
    dependency: "direct main"
    description:
      name: cupertino_icons
      sha256: ba631d1c7f7bef6b729a622b7b752645a2d076dba9976925b8f25725a30e1ee6
      url: "https://pub.dev"
    source: hosted
    version: "1.0.8"
  fake_async:
    dependency: transitive
    description:
      name: fake_async
      sha256: "511392330127add0b769b75a987850d136345d9227c6b94c96a04cf4a391bf78"
      url: "https://pub.dev"
    source: hosted
    version: "1.3.1"
  flutter:
    dependency: "direct main"
    description: flutter
    source: sdk
    version: "0.0.0"
  flutter_lints:
    dependency: "direct dev"
    description:
      name: flutter_lints
      sha256: "9e8c3858111da373efc5aa341de011d9bd23e2c5c5e0c62bccf32438e192d7b1"
      url: "https://pub.dev"
    source: hosted
    version: "3.0.2"
  flutter_markdown:
    dependency: "direct main"
    description:
      name: flutter_markdown
      sha256: a23c41ee57573e62fc2190a1f36a0480c4d90bde3a8a8d7126e5d5992fb53fb7
      url: "https://pub.dev"
    source: hosted
    version: "0.7.3+1"
  flutter_test:
    dependency: "direct dev"
    description: flutter
    source: sdk
    version: "0.0.0"
  leak_tracker:
    dependency: transitive
    description:
      name: leak_tracker
      sha256: "7f0df31977cb2c0b88585095d168e689669a2cc9b97c309665e3386f3e9d341a"
      url: "https://pub.dev"
    source: hosted
    version: "10.0.4"
  leak_tracker_flutter_testing:
    dependency: transitive
    description:
      name: leak_tracker_flutter_testing
      sha256: "06e98f569d004c1315b991ded39924b21af84cf14cc94791b8aea337d25b57f8"
      url: "https://pub.dev"
    source: hosted
    version: "3.0.3"
  leak_tracker_testing:
    dependency: transitive
    description:
      name: leak_tracker_testing
      sha256: "6ba465d5d76e67ddf503e1161d1f4a6bc42306f9d66ca1e8f079a47290fb06d3"
      url: "https://pub.dev"
    source: hosted
    version: "3.0.1"
  lints:
    dependency: transitive
    description:
      name: lints
      sha256: cbf8d4b858bb0134ef3ef87841abdf8d63bfc255c266b7bf6b39daa1085c4290
      url: "https://pub.dev"
    source: hosted
    version: "3.0.0"
  markdown:
    dependency: "direct main"
    description:
      name: markdown
      sha256: ef2a1298144e3f985cc736b22e0ccdaf188b5b3970648f2d9dc13efd1d9df051
      url: "https://pub.dev"
    source: hosted
    version: "7.2.2"
  matcher:
    dependency: transitive
    description:
      name: matcher
      sha256: d2323aa2060500f906aa31a895b4030b6da3ebdcc5619d14ce1aada65cd161cb
      url: "https://pub.dev"
    source: hosted
    version: "0.12.16+1"
  material_color_utilities:
    dependency: transitive
    description:
      name: material_color_utilities
      sha256: "0e0a020085b65b6083975e499759762399b4475f766c21668c4ecca34ea74e5a"
      url: "https://pub.dev"
    source: hosted
    version: "0.8.0"
  meta:
    dependency: transitive
    description:
      name: meta
      sha256: "7687075e408b093f36e6bbf6c91878cc0d4cd10f409506f7bc996f68220b9136"
      url: "https://pub.dev"
    source: hosted
    version: "1.12.0"
  path:
    dependency: transitive
    description:
      name: path
      sha256: "087ce49c3f0dc39180befefc60fdb4acd8f8620e5682fe2476afd0b3688bb4af"
      url: "https://pub.dev"
    source: hosted
    version: "1.9.0"
  sky_engine:
    dependency: transitive
    description: flutter
    source: sdk
    version: "0.0.99"
  source_span:
    dependency: transitive
    description:
      name: source_span
      sha256: "53e943d4206a5e30df338fd4c6e7a077e02254531b138a15aec3bd143c1a8b3c"
      url: "https://pub.dev"
    source: hosted
    version: "1.10.0"
  stack_trace:
    dependency: transitive
    description:
      name: stack_trace
      sha256: "73713990125a6d93122541237550ee3352a2d84baad52d375a4cad2eb9b7ce0b"
      url: "https://pub.dev"
    source: hosted
    version: "1.11.1"
  stream_channel:
    dependency: transitive
    description:
      name: stream_channel
      sha256: ba2aa5d8cc609d96bbb2899c28934f9e1af5cddbd60a827822ea467161eb54e7
      url: "https://pub.dev"
    source: hosted
    version: "2.1.2"
  string_scanner:
    dependency: transitive
    description:
      name: string_scanner
      sha256: "556692adab6cfa87322a115640c11f13cb77b3f076ddcc5d6ae3c20242bedcde"
      url: "https://pub.dev"
    source: hosted
    version: "1.2.0"
  term_glyph:
    dependency: transitive
    description:
      name: term_glyph
      sha256: a29248a84fbb7c79282b40b8c72a1209db169a2e0542bce341da992fe1bc7e84
      url: "https://pub.dev"
    source: hosted
    version: "1.2.1"
  test_api:
    dependency: transitive
    description:
      name: test_api
      sha256: "9955ae474176f7ac8ee4e989dadfb411a58c30415bcfb648fa04b2b8a03afa7f"
      url: "https://pub.dev"
    source: hosted
    version: "0.7.0"
  vector_math:
    dependency: transitive
    description:
      name: vector_math
      sha256: "80b3257d1492ce4d091729e3a67a60407d227c27241d6927be0130c98e741803"
      url: "https://pub.dev"
    source: hosted
    version: "2.1.4"
  vm_service:
    dependency: transitive
    description:
      name: vm_service
      sha256: "3923c89304b715fb1eb6423f017651664a03bf5f4b29983627c4da791f74a4ec"
      url: "https://pub.dev"
    source: hosted
    version: "14.2.1"
sdks:
  dart: ">=3.4.1 <4.0.0"
  flutter: ">=3.19.0"

Steps to reproduce
1. Copy Paste this file and add SwMarkdownWidget to your tree.
import 'package:flutter/material.dart';
import 'package:flutter_markdown/flutter_markdown.dart';
import 'package:markdown/markdown.dart' as md;

const String md_content = '''
# Example of horizontal rules

---
This is a paragraph.
***
This is another paragraph.
___

''';

class SwMarkDownWidget extends StatelessWidget {
  final String mdContent;

  const SwMarkDownWidget({
    super.key,
    required this.mdContent,
  });

  @override
  Widget build(BuildContext context) {
    return MarkdownBody(
      data: mdContent,
      builders: {
        'hr': HorizontalRuleBuilder(),
      },
    );
  }
}

class HorizontalRuleBuilder extends MarkdownElementBuilder {
  @override
  bool isBlockElement() => true;

  @override
  Widget visitText(md.Text text, TextStyle? preferredStyle) {
    debugPrint("visitText: ${text.text}"); // Debug statement
    return super.visitText(text, preferredStyle) ?? Container();
  }

  @override
  Widget? visitElementAfter(md.Element element, TextStyle? preferredStyle) {
    debugPrint("visitElementAfter: ${element.tag}");
    return Container(
      color: Colors.red,
      height: 2,
      margin: const EdgeInsets.symmetric(
        vertical: 10,
      ), // Add some spacing around the hr
    );
  }
}

2. Add SwMarkdownWidget to your tree.
SwMarkdownWidget(mdContent : md_content)

Expected results
We expect the horizontal rule to appear as what the custom builder builds.

Actual results
The Markdown widget don't appear to use the builder as the horizontal rule doesn't change from the default behavior.

Code sample
Code sample
import 'package:flutter/material.dart';
import 'package:flutter_markdown/flutter_markdown.dart';
import 'package:markdown/markdown.dart' as md;

void main() {
  runApp(const MyApp());
}

class MyApp extends StatelessWidget {
  const MyApp({super.key});

  // This widget is the root of your application.
  @override
  Widget build(BuildContext context) {
    return const MaterialApp(
      title: 'Flutter Demo',
      home: MyHomePage(),
    );
  }
}

class MyHomePage extends StatelessWidget {
  const MyHomePage({super.key});

  @override
  Widget build(BuildContext context) {
    return const SwMarkDownWidget(mdContent : md_content);
  }
}

const String md_content = '''
# Example of horizontal rules

---
This is a paragraph.
***
This is another paragraph.
___

''';

class SwMarkDownWidget extends StatelessWidget {
  final String mdContent;

  const SwMarkDownWidget({
    super.key,
    required this.mdContent,
  });

  @override
  Widget build(BuildContext context) {
    return MarkdownBody(
      data: mdContent,
      builders: {
        'hr': HorizontalRuleBuilder(),
      },
    );
  }
}

class HorizontalRuleBuilder extends MarkdownElementBuilder {
  @override
  bool isBlockElement() => true;

  @override
  Widget visitText(md.Text text, TextStyle? preferredStyle) {
    debugPrint("visitText: ${text.text}"); // Debug statement
    return super.visitText(text, preferredStyle) ?? Container();
  }

  @override
  Widget? visitElementAfter(md.Element element, TextStyle? preferredStyle) {
    debugPrint("visitElementAfter: ${element.tag}");
    return Container(
      color: Colors.red,
      height: 2,
      margin: const EdgeInsets.symmetric(
        vertical: 10,
      ), // Add some spacing around the hr
    );
  }
}

Screenshots or Videos

Screenshots / Video demonstration
[Upload media here]

Logs
Logs
[Paste your logs here]

Flutter Doctor output
I know there is an issue, that is because I had to downgrade Flutter version manually. But that is not the origine of the problem.
Doctor output
flutter doctor -v
[!] Flutter (Channel [user-branch], 3.22.1, on macOS 14.2.1 23C71 darwin-arm64, locale en-US)
    ! Flutter version 3.22.1 on channel [user-branch] at /Users/romainpattyn/Development/flutter
      Currently on an unknown channel. Run `flutter channel` to switch to an official channel.
      If that doesn't fix the issue, reinstall Flutter by following instructions at https://flutter.dev/docs/get-started/install.
    ! Upstream repository unknown source is not a standard remote.
      Set environment variable "FLUTTER_GIT_URL" to unknown source to dismiss this error.
    • Framework revision a14f74ff3a (3 months ago), 2024-05-22 11:08:21 -0500
    • Engine revision 55eae6864b
    • Dart version 3.4.1
    • DevTools version 2.34.3
    • If those were intentional, you can disregard the above warnings; however it is recommended to use "git" directly to perform update
      checks and upgrades.

[✓] Android toolchain - develop for Android devices (Android SDK version 34.0.0)
    • Android SDK at /Users/romainpattyn/Library/Android/sdk
    • Platform android-34, build-tools 34.0.0
    • Java binary at: /Applications/Android Studio.app/Contents/jbr/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 17.0.10+0-17.0.10b1087.21-11572160)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 15.4)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Build 15F31d
    • CocoaPods version 1.15.2

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 2023.3)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 17.0.10+0-17.0.10b1087.21-11572160)

[✓] VS Code (version 1.92.1)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.94.0

[✓] Connected device (5 available)
    • iPhone de Romain (mobile)       • 00008110-00014CEC1E51801E            • ios            • iOS 17.5.1 21F90
    • iPhone 15 (mobile)              • 1C459C9B-830D-45C7-B148-CF86317EDCBE • ios            •
      com.apple.CoreSimulator.SimRuntime.iOS-17-5 (simulator)
    • macOS (desktop)                 • macos                                • darwin-arm64   • macOS 14.2.1 23C71 darwin-arm64
    • Mac Designed for iPad (desktop) • mac-designed-for-ipad                • darwin         • macOS 14.2.1 23C71 darwin-arm64
    • Chrome (web)                    • chrome                               • web-javascript • Google Chrome 127.0.6533.120

[✓] Network resources
    • All expected network resources are available.

! Doctor found issues in 1 category.

Thanks for the report. Seeing the same behavior as reported on latest versions.
Stable and master: 3.24.0

I’m going to dive in and help out with the issue. If there’s anything specific I should know before getting started, it’d be great if you could let me know. Otherwise, I’ll go ahead and work on a fix.

If there’s anything specific I should know before getting started, it’d be great if you could let me know.

Please check this for your reference.

@romain-pattyn For a workaround, define your own HR replacement:
class _HorizontalRuleSyntax extends md.HorizontalRuleSyntax {
  @override
  md.Node parse(md.BlockParser parser) {
    parser.advance();
    return md.Element.empty('hhrr');
  }
}

and use that:
body: Markdown(
  ...
  extensionSet: md.ExtensionSet([_HorizontalRuleSyntax()], []),
  builders: {'hhrr': _HorizontalRuleBuilder()},

And, by the way, not directly related, but you might want to use the newer visitElementAfterWithContext() instead of the deprecated, older function.


rewrite tests to use t.TempDir(), and some minor fixes

See individual commits for details

Thanks! I'll bring this one in 👍


Update http4s-circe, http4s-client, ... to 0.23.14

Updates

org.http4s:http4s-circe
org.http4s:http4s-client
org.http4s:http4s-core
org.http4s:http4s-dsl

from 0.23.6 to 0.23.14.
GitHub Release Notes - Version Diff
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Adjust future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "org.http4s" } ]

Or, add this to slow down future updates of this dependency:
dependencyOverrides = [{
  pullRequests = { frequency = "@monthly" },
  dependency = { groupId = "org.http4s" }
}]

labels: library-update, early-semver-minor, semver-spec-patch, commit-count:1

Superseded by #1067.


hide() feature of Floating UI

We can pass hide as a prop to the <Float/> component. But, according to the floating UI Documentation the hide() middleware is a data provider. So currently we have no way to get this data, consequently, we cannot hide the floating element after its reference is hidden.

I think this is a feature request.
I currently do not fully implement the hide() feature, if I have the time will be to check it.

Released v0.13, see the docs https://headlessui-float.vercel.app/react/floatingui-options.html#hide for more information of hide usage.


Readme tools samples

revise README, add samples
Revise README.rst to use syntax sections recommended in
https://www.sphinx-doc.org/en/master/usage/restructuredtext/basics.html#sections
Improve README opening to better explain ipromise.
Revise README.rst line widths.
Add easier-to-read sample code, both in README and in python
files under samples/.
add development tools wrappers

@NeilGirdhar any opinion on this PR?

I squashed the force-pushed the commits (which messes up the PR review history above 😕  but is a cleaner commit to master branch).

@jtmoon79 Thanks, can you remove the scripts?  I still see them.

@jtmoon79 Thanks, can you remove the scripts? I still see them.

Whoops, for some reason the git rm commit was dropped. Should be fixed now.

@NeilGirdhar how about this round of updates?


Avoid storage of entity FQCN

Currently, we are storing admin class associated with SavedFilters entity.
We need such information to be able to find out for which admin the filter was saved for.
But storing an FQCN in a database has drawbacks :

it is a "sensitive" information
you are exposing unecessary technical information
you will have to migrate data whenever you rename the entity

I suggest to store the sonata admin code instead.
It will create a BC, because many things will change, and the existing filers won't be working anymore.

At first it would seem like a good idea, but with deeper look maybe not so much: IMHO the 3 points remain valid with the admin code:

is it really a less sensitive information than an entity's FQCN?
it's also a technical information
you would also need a migration whenever you would change your admin's code (or class name if the code is based on the admin's FQCN)

Therefore I'm not sure it would bring any major improvements.
What do you think?

Yeah, for the moment, I think you are right, I do not see that much benefit switching
It was FTR anyway, thanks :)


Shadow in navigator transition?

Anyone know how I can add a shadow to the navigator transition? Right here?
(With Navigator, not NavigatorIOS)

Things I've tried:

Style on the components
sceneStyle on the Navigator
adding shadows to the NavigatorSceneConfigs

I tried to do this as well couple of days ago without any success. For now I've set root component's background dark to fake scene going underneath but it gives ugly borders.

@brentvatne @ericvicenti would either of you have some insight into how to do this?

Navigator takes a sceneStyle prop. Have you tried putting shadow styles on it?
On Aug 13, 2015, at 8:25 AM, Luke Dubert <notifications<EMAIL_ADDRESS>wrote:
@brentvatnehttps://github.com/brentvatne @ericvicentihttps://github.com/ericvicenti would either of you have some insight into how to do this?
—
Reply to this email directly or view it on GitHubhttps://github.com/facebook/react-native/issues/2301#issuecomment-130728387.

Thanks @ericvicenti. It worked but it's not dynamic like in NavigatorIOS.
Remember to set overflow: 'visible' otherwise shadow doesn't show.
<Navigator sceneStyle={{overflow: 'visible'}} />

@jozan - could you explain what you mean by dynamic?

@brentvatne Check shadow's opacity.

@jozan - good point! it changes as you move further to the left to be darker - that would be possible to do if the view was an Animated.View and Navigator provided some hook into the swipe events that would allow us to update that value accordingly

@brentvatne Yes, I hope Navigator starts using Animated soon.
:baby_chick:

UNBELIEVABLE. I've been trying to figure this out for 4 days. And all I needed was an overflow: visible prop.
One of the first things I tried was putting the shadow on sceneStyle but it didn't work because I didn't have overflow: visible.
Yeah, next step is making it dynamic. I'll poke around in Navigator and sceneConfigs to see what I can do.

It might be a bumpy transition, but we are working on a new Navigator which fully utilizes Animated and allows scenes to perform their own animation

That's really exciting @ericvicenti. Will there be a prebuilt style that mimics iOS as closely as possible?

@jozan I got it working using sceneConfigs:
It's not 100% perfect, but it's pretty close.
in Libraries > CustomComponents > Navigator > NavigatorSceneConfigs:

var NativeFadeToTheLeft = {
  transformTranslate: {
    from: {x: 0, y: 0, z: 0},
    to: {x: -Math.round(Dimensions.get('window').width * 0.3), y: 0, z: 0},
    min: 0,
    max: 1,
    type: 'linear',
    extrapolate: true,
    round: PixelRatio.get(),
  },
  opacity: {
    from: 1,
    to: 0.3,
    min: 0,
    max: 1,
    type: 'linear',
    extrapolate: false,
    round: 100,
  },
  translateX: {
    from: 0,
    to: -Math.round(Dimensions.get('window').width * 0.3),
    min: 0,
    max: 1,
    type: 'linear',
    extrapolate: true,
    round: PixelRatio.get(),
  },
};

var NativeFromTheRight = {
  opacity: {
    value: 1.0,
    type: 'constant',
  },
  shadowColor: {
    value: '#000000',
    type: 'constant',
  },

  shadowOpacity: {
    from: 0.1,
    to: 0.5,
    min: 0,
    max: 1,
    type: 'linear',
    extrapolate: false,
    round: 100,
  },

  shadowRadius: {
    from: 2,
    to: 6,
    min: 0,
    max: 1,
    type: 'linear',
    extrapolate: true,
  },

  transformTranslate: {
    from: {x: Dimensions.get('window').width, y: 0, z: 0},
    to: {x: 0, y: 0, z: 0},
    min: 0,
    max: 1,
    type: 'linear',
    extrapolate: true,
    round: PixelRatio.get(),
  },

  translateX: {
    from: Dimensions.get('window').width,
    to: 0,
    min: 0,
    max: 1,
    type: 'linear',
    extrapolate: true,
    round: PixelRatio.get(),
  },

};

// [...omitted]

var NavigatorSceneConfigs = {
  AsCloseToNativeIOSAsPossible: {
    ...BaseConfig,
    // We will want to customize this soon
    gestures: {
      jumpBack: BaseLeftToRightGesture,
      jumpForward: BaseRightToLeftGesture,
    },
    animationInterpolators: {
      into: buildStyleInterpolator(NativeFromTheRight),
      out: buildStyleInterpolator(NativeFadeToTheLeft),
    },
  },
  // [...omitted]
}

@dubert Thank! I will try that. Maybe you could create PR of the scene config and get it integrated.
@ericvincenti Would PR for Navigator be waste when reworked version is coming?

It will be better to not to spend time adding features to the current Navigator while we work on the new one.
I'm sure that with the community's help, we can make the new Animated Navigator have a very close resemblance to the platform navigation

Nice one @dubert!

@ericvicenti Any estimation when the Animated Navigator will be released?

@dubert Awesome!It's really a great solution(I don't like the scale animation) and thank you so much.Besides,I wrapped  with  element whose background color is black,and set the config opacity form 1 to 0.8.It seems like we have the darkened overlay ,something like this:

@dubert I'm getting errors like this on RN 0.27.0
View #1176 of type RCTView has a shadow set but cannot calculate shadow efficiently. Consider setting a background color to fix this, or apply the shadow to a more specific component.

Any solution? Lol - sorry about reviving an old issue.

@huangbong does setting a background color not work?

@dubert does not


where are the python code?

@haohuancheng commented on Fri Jun 21 2019
I can not found any python code in this page:
https://docs.microsoft.com/zh-cn/azure/iot-central/howto-connect-raspberry-pi-python

文档详细信息
⚠ 请勿编辑此部分。 docs.microsoft.com ➟ GitHub 问题链接必须具有此部分。

ID: f9195da5-634f-e46f-4af3-4e8e1b7c4690
Version Independent ID: a82ddd98-db6f-7ad7-58f1-2c7f46b06706
Content: 将 Raspberry Pi 连接到 Azure IoT Central 应用程序 (Python)
Content Source: articles/iot-central/howto-connect-raspberry-pi-python.md
Service: iot-central
GitHub Login: @dominicbetts
Microsoft Alias: dobett

Hi team,
I'm moving this here because the issue can be found in the en-us, too
kind regards

Thanks @CeciAc! Hi @haohuancheng Thanks for reaching out. I am not sure if I understand your feedback. It looks like you would like to see an explanation of the code in this tutorial vs just using the sample application and adding your credentials to it?

@haohuancheng Please check the "Configuring Raspberry Pi" section for sample codes. When you open the link you will be able to see the samples on Github repo. We will now proceed to close this thread. If there are further questions regarding this matter, please tag me in your reply. We will gladly continue the discussion and we will reopen the issue.


What does T_G_C and T_G_B stand for?

hi，I want to know that what  are T_G_C and T_G_B mean?
For example,Maybe T_G_C means from ground to camera?

Also,T_C_B?

Hi @zzxp
In this paper I describe the transformations in more detail. We tried to have the same nomenclature than e.g. maplab or aslam_cv2:
G: Global/World frame
C: Camera frame
B (identical to I): Body frame of the robot, coinciding with the IMU
T_G_C: Pose of camera in global/world frame
T_G_B (identical to T_G_I): Pose of body/IMU in global/world frame
T_C_B (identical to T_C_I): Camera-IMU transformation obtained from Kalibr

Thank you!


When I click "Kata" I can't see: Fortran, Julia, Powershell in the list of languages

^
Browser: Google Chrome

Well, they're in beta, just like BF used to be.

Well now I see them.

Disappeared again!


Add support for multiple source URLs (mirrors)

From examining the conda-recipe-manager integration tests, I've discovered that the source/url field only supports scalar values and does not support lists/mirrors yet.
Error:   × Parsing: expected a scalar value.
    ╭─[40:5]
 39 │       url:
 40 │ ╭─▶     - ${{ cran_mirror }}/src/contrib/highr_${{ version }}.tar.gz
 41 │ ├─▶     - ${{ cran_mirror }}/src/contrib/Archive/highr/highr_${{ version }}.tar.gz
    · ╰──── expected a string value for `url`
 42 │       sha256: ec55bc1ff66390ed66806dc2a7b6c17dbfd089b3d73fe2e369017f8cb4bc347b
    ╰────

From CEP-14:
# url pointing to the source tar.gz|zip|tar.bz2|... (this can be a list of mirrors that point to the same file)
url: url | [url]

Presumably the basename of each member of the list should be identical. I'm not sure if we want to perform that in the validation phase.

Yep! We should implement this.
I am not sure that the base name needs to be the same.
For archives, they get extracted automatically.
For other files, one could force it using the file_name: <> field.


Develop Slides for next WMWG

Create the deck
Include workshop feedback and updated Personas

includes Tim's feedback integration

https://drive.google.com/file/d/1dXbHwGJ_4JBuJ9IHNbXoVK24f5dXSI-i/view?usp=sharing


Broken certificates

Description
When you navigate to the domain https://opencollective.com, the certificate is correct and the padlock icon on the navigation bar is green as expected. However, when you navigate to https://opencollective.com/webpack, the site becomes insecure.
To Reproduce
Steps to reproduce the behavior:

Go to https://opencollective.com
Click on 'Discover'
Scroll to 'Webpack' and click it
See error

Expected behavior
Correct certificates should be given on all pages.
Screenshots
Desktop

OS: Arch Linux
Browser: Firefox
Version: 61.0.2-1

It's fixed. Thanks!

Yes, the the slack logo on this page was not loaded from https. We fixed that issue.
However, we still need to change the way we link to external images to prevent that happening in the future.


Theme Tweaks

Hey there. I recently used your hero theme on a side project. (Out of all the available hugo themes, they picked yours based on the design, so props).
Made a few tweaks when implementing it, so thought I'd give back. Thanks for making this theme 👍
Changes:

Allow custom css files by accepting an array of assets dir file paths
Allow contact page address to enter and show newlines
Allow contact page business hours to be specified in config, not hardcoded in template

Was looking through the open issues. Looks like this PR would partially address https://github.com/zerostaticthemes/hugo-hero-theme/issues/22

Bump

Bump

@zwbetz-gh sorry for the delay mate. Thank you so much for the PR.
I like what you've added for the contact page.
Can you explain the use case/advantage of the custom css? Isn't it just as easy to add a new @import to the style.scss?

@zwbetz-gh sorry for the delay mate. Thank you so much for the PR.
I like what you've added for the contact page.
Can you explain the use case/advantage of the custom css? Isn't it just as easy to add a new @import to the style.scss?

I prefer working with CSS over SCSS because I'm a bit old-school. But fair point. Someone could just edit the style.scss. I'll remove the custom CSS config changes from this PR.

I prefer working with CSS over SCSS because I'm a bit old-school. But fair point. Someone could just edit the style.scss. I'll remove the custom CSS config changes from this PR.

Removed in https://github.com/zerostaticthemes/hugo-hero-theme/pull/28/commits/406ec59bc9a8cd4cd03da97aa35e025c51cab79a
Now just the Contact page changes remain.

Removed in https://github.com/zerostaticthemes/hugo-hero-theme/pull/28/commits/406ec59bc9a8cd4cd03da97aa35e025c51cab79a
Now just the Contact page changes remain.


Change locator strategy of hash (#) to css selector instead of id

Proposed changes
//: # This change addresses issue 2780 where By.id location strategy is being removed since it is not part of the w3c spec.   With hash # already working for css selectors, this should be a transparent change to existing tests
Types of changes

[] Bugfix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

[X] I have read the CONTRIBUTING doc
[X] I have added tests that prove my fix is effective or that my feature works
[X] I have added necessary documentation (if appropriate)
[ ] I have proposed the same patch to the new v5 repository

Further comments
Reviewers: @christian-bromann

Is this really the only changed needed to use css id selector syntax for newer selenium drivers?

@emilyrohrbough I believe so.  findElementStrategy.js file is responsible for determining which locator strategy to send as the using portion of the POST body.
pre-change:
COMMAND POST "/wd/hub/session/0f10e8f6-066d-4a9c-bced-24ccf21cc2f7/elements" DATA {"using":"id","value":"my_selector"}

post-change:
COMMAND POST "/wd/hub/session/0f10e8f6-066d-4a9c-bced-24ccf21cc2f7/elements" DATA {"using":"css selector","value":"#my_selector"}

🤦♀ oh nice catch!
I've actually spent the last few days creating a custom linter to discourage css id selector syntax with auto-fixes because this was about to become a huge problem for our projects. Guess I can throw that out now 😄

@christian-bromann Let me know what you think.  Thanks

@christian-bromann any idea when you might be able to do a release?


Add Bun to the Package Manager Tabs across the docs

📚 Subject area/topic
Package Managers
📋 Suggested page
https://docs.astro.build/en/install/auto/
https://docs.astro.build/en/editor-setup
... most pages tbh
📋 General description or bullet points (if proposing new content)
Just adding the bun commands to the documentation.
🖥 Reproduction of code samples in StackBlitz
No response

Working on the changes here if this is something the team is interested in.

Hi @dax911! We know Bun is working on supporting Astro, but Bun is not officially supported by Astro, so we are not including it in our documentation at this time. We do have a user-submitted recipe for using Bun with Astro, and if there is an error on that page you are welcome to PR a correction! But we've decided that for the time being, we will not be adding additional package managers or runtimes to the docs.


Frame duration issue

Not sure if I'm doing something wrong, but it appears the frame duration is being ignored except on the very first frame of an animation.
Every frame in the following example is set to 500ms (I made it super slow to see if it was even working), which only the first frame honors, after that it seems to revert to some default animation speed.

Never mind actually! I was passing in a handle to a different Aseprite asset when spawning the Bundle that had different timings.


Update classgraph to 4.8.161

About this PR
📦 Updates io.github.classgraph:classgraph from 4.8.147 to 4.8.161
Usage
✅ Please merge!
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

⚙ Adjust future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "io.github.classgraph", artifactId = "classgraph" } ]

Or, add this to slow down future updates of this dependency:
dependencyOverrides = [{
  pullRequests = { frequency = "30 days" },
  dependency = { groupId = "io.github.classgraph", artifactId = "classgraph" }
}]

labels: test-library-update, early-semver-patch, semver-spec-patch, commit-count:1

Superseded by #238.


notification on pb sometimes not working

it's still detecting a run finish but somehow not a pb occasionally

should be fixed, will reopen if not


Security per flv stream

How could I put security to different streams
For example I have:
http://<IP_ADDRESS>:8080/live/livestream_1.flv
http://<IP_ADDRESS>:8080/live/livestream_2.flv
http://<IP_ADDRESS>:8080/live/livestream_3.flv
I want to authenticate to each "livestream" with different user name
Is it possible?
How could I do it?

Please read wiki about HTTP Callback.


Income Stmt. Bal. Acc. does not exist on General Fast Tab in Business Central

Are you then not allowed to have multiple retained earnings accounts in Business Central?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 3ce81758-a039-ef6d-5f39-c0a4c6f58b08
Version Independent ID: 911e4550-454d-101f-99f7-24eec4cc88b9
Content: How to Set Up and Close Income Statement Balances - Business Central
Content Source: business-central/LocalFunctionality/Spain/how-to-set-up-and-close-income-statement-balances.md
Service: dynamics365-business-central
GitHub Login: @SorenGP
Microsoft Alias: sgroespe

Sorry for the delay in getting back to you. I hope you found an answer to your question in the Business Central community (https://community.dynamics.com/business/f/758) or suggested it as a feature in Ideas (https://experience.dynamics.com/ideas/list/?forum=e288ef32-82ed-e611-8101-5065f38b21f1)