Using Numba

Dear @pilcru,
First let me thank you for this wonderful tool that is GHPythonRemote.
I would like to know if it is possible to use Numba with it and if so, how.
Importing it doesn't seem to be an issue but adding a @jit decorator to a function returns an error.
Example test:
nb = scriptcontext.sticky['numba']
jit = nb.jit

@jit
def f(x, y):
    return x + y

f(24, 167)

Returned error:
Runtime error (Exception): NotImplementedError

Traceback:
  line 58, in script
  line 102, in value, "C:\Users\solub\AppData\Roaming\McNeel\Rhinoceros\6.0\Plug-ins\IronPython (814d908a-e25c-493d-97e9-ee3861957f49)\settings\lib\rpyc\core\async_.py"
  line 458, in sync_request, "C:\Users\solub\AppData\Roaming\McNeel\Rhinoceros\6.0\Plug-ins\IronPython (814d908a-e25c-493d-97e9-ee3861957f49)\settings\lib\rpyc\core\protocol.py"
  line 76, in syncreq, "C:\Users\solub\AppData\Roaming\McNeel\Rhinoceros\6.0\Plug-ins\IronPython (814d908a-e25c-493d-97e9-ee3861957f49)\settings\lib\rpyc\core\netref.py"
  line 247, in __call__, "C:\Users\solub\AppData\Roaming\McNeel\Rhinoceros\6.0\Plug-ins\IronPython (814d908a-e25c-493d-97e9-ee3861957f49)\settings\lib\rpyc\core\netref.py"

Hi @solub,
Thank you for trying the plugin! Numba is only half compatible with GHPythonRemote, you can import modules that use numba but cannot import numba and call jit on IronPyton code.
While it's possible to use numba on the CPython side of the connection, it's not possible to cross the interface and use it on functions defined on the IronPython side. The problem is that numba needs to access the bytecode of the function to be JITed, and GHPythonRemote does not know how to transfer that. I don't even know of a way to access that information on IronPython like on CPython (I initially tried to transfer the function to the CPython side with a utility from RPyC, but that's trying to access function properties that are not defined in the IronPython implementation).
So the best you can do is code everything that needs to use numba in a separate CPython module, and add this module to the list of modules to import through GHPythonRemote. The module needs to be importable by your CPython installation (rhinoremote virtual environment, probably), that is be in its python path. I find the easiest way to achieve that is to create a package with a simple setup.py file, and use an editable install: pip install -e . (run this from the folder containing the setup.py file, with rhinoremote activated).
There is an example project layout with a simple setup.py here.

Thank you so much for the kind reply and the comprehensive explanation. This is very helpful.


Yosys updates

Motivation for this change
New yosys release and update nextpnr.
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Fits CONTRIBUTING.md.

CCing @thoughtpolice.

@GrahamcOfBorg build symbiyosys nextpnr

Success on aarch64-linux (full log)
Attempted: symbiyosys, nextpnr
Partial log (click to expand)
shrinking RPATHs of ELF executables and libraries in /nix/store/dxg24w68m84cgi6bqk04534wi1pzzkwq-nextpnr-2018.10.17
shrinking /nix/store/dxg24w68m84cgi6bqk04534wi1pzzkwq-nextpnr-2018.10.17/bin/nextpnr-ice40
shrinking /nix/store/dxg24w68m84cgi6bqk04534wi1pzzkwq-nextpnr-2018.10.17/bin/nextpnr-generic
strip is /nix/store/p9akxn2sfy4wkhqdqa3li97pc6jaz3r1-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/dxg24w68m84cgi6bqk04534wi1pzzkwq-nextpnr-2018.10.17/bin
patching script interpreter paths in /nix/store/dxg24w68m84cgi6bqk04534wi1pzzkwq-nextpnr-2018.10.17
checking for references to /build in /nix/store/dxg24w68m84cgi6bqk04534wi1pzzkwq-nextpnr-2018.10.17...
postPatchMkspecs
/nix/store/bsrkbz5582wcxww9v5h1bap6lpkg6hf1-symbiyosys-2018.09.12
/nix/store/dxg24w68m84cgi6bqk04534wi1pzzkwq-nextpnr-2018.10.17

Success on x86_64-darwin (full log)
Attempted: symbiyosys
The following builds were skipped because they don't evaluate on x86_64-darwin: nextpnr
Partial log (click to expand)
no configure script, doing nothing
building
installing
patching script interpreter paths in /nix/store/9h2hsa34pdrqyqdg5ngs987ds8b71vwv-symbiyosys-2018.09.12/bin/sby
/nix/store/9h2hsa34pdrqyqdg5ngs987ds8b71vwv-symbiyosys-2018.09.12/bin/sby: interpreter directive changed from "/usr/bin/env python3" to "/nix/store/8rw1vq2k50g7jgniskzs51qjb47w8nhz-python3-3.6.6/bin/python3"
post-installation fixup
strip is /nix/store/53nysl8bqwxihwzs1pgwka20nf8mbvlp-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/9h2hsa34pdrqyqdg5ngs987ds8b71vwv-symbiyosys-2018.09.12/bin
patching script interpreter paths in /nix/store/9h2hsa34pdrqyqdg5ngs987ds8b71vwv-symbiyosys-2018.09.12
/nix/store/9h2hsa34pdrqyqdg5ngs987ds8b71vwv-symbiyosys-2018.09.12

Success on x86_64-linux (full log)
Attempted: symbiyosys, nextpnr
Partial log (click to expand)
patching script interpreter paths in /nix/store/b7bhydva9l7jaj1xq4d6wi11j8avgcb6-symbiyosys-2018.09.12/bin/sby
/nix/store/b7bhydva9l7jaj1xq4d6wi11j8avgcb6-symbiyosys-2018.09.12/bin/sby: interpreter directive changed from "/usr/bin/env python3" to "/nix/store/nrl0l79a48924xb0897ap572xf29ciir-python3-3.6.6/bin/python3"
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/b7bhydva9l7jaj1xq4d6wi11j8avgcb6-symbiyosys-2018.09.12
strip is /nix/store/vcc4svb8gy29g4pam2zja6llkbcwsyiq-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/b7bhydva9l7jaj1xq4d6wi11j8avgcb6-symbiyosys-2018.09.12/bin
patching script interpreter paths in /nix/store/b7bhydva9l7jaj1xq4d6wi11j8avgcb6-symbiyosys-2018.09.12
checking for references to /build in /nix/store/b7bhydva9l7jaj1xq4d6wi11j8avgcb6-symbiyosys-2018.09.12...
/nix/store/b7bhydva9l7jaj1xq4d6wi11j8avgcb6-symbiyosys-2018.09.12
/nix/store/2rmdks5z7rvgih71hxxmxbarm3z6ak79-nextpnr-2018.10.17


"All time"  should include 1 year into the future

Summary
Change the "All time"  date range to include 1 year into the future
Why?
Some of the dates that are used in the system include future dates (e.g. pick up and delivery dates).  They should be included in "All time".
Details
There is a common element used for the date ranges.  One way to see it is:  sign in as<EMAIL_ADDRESS>and click on "Distributions".
This element has an "All Time"  choice  that currently goes back 100 years from today.  It should also go into the future 1 year.
Criteria for completion

[ ] behaviour as above
[ ] automated tests to support
[ ] modification of any current tests regarding future dates and "all time"

I would like to work on this issue

Please do.


"react-content-query-webpart" is not running with spfx 1.4.1 version

@spplante ,
As per the Microsoft recommendation, We are trying to Create "react-content-query-webpart" in SPFx 1.4.1 version.
we are getting Below error , This is error is coming in lib folder files(.js) but not in ts file

Did anyone try to upgrade this app to 1.4.1?
Please let me know if we can upgrade this app to SPFx 1.4.1
Thanks,
Bhanu

@bhanuprakash857 , I did upgrade the WebPart to 1.4.1 successfully for my current client. Obviously it wasn't 100% transparent, I had to fix some API changes here and there but I can't remember if the error above was one of them. Give me a moment and I will send you an upgraded version, is that good for you?

Thanks for the information @spplante . Could you please send me the upgraded one?

Yes, working on it.
Do you have an email I can send it to?
Thanks!

Just figured out that I can attch files directly in here hehe...
Here it is in 1.4.1 with the assets being included directly in the .sppkg 👍
content-query-webpart.zip

Thank you so much @spplante , You really saved my day.

My pleasure, have fun 👍

@spplante If possible merge this change. That will help others as well

@sprider thought about it but not sure how I would pull this off, because the main version has to stay 1.1 in order to stay compatible for SharePoint 2016. I could submit a completely new sample which runs on 4.1 but then changes would have to be sync between both projects which isn’t really convenient

Sure, Thank you.

@sprider @bhanuprakash857 , I just fixed an issue causing multiple filters to loose their sort order in IE. For you guys to get the update for the 1.4.1 version, I added a .zip at the root of the project which has the latest version upgraded to 1.4.1, you can download the .zip in the pull request #517 which I just submitted.
I will try to keep this .zip updated from now on every time I do some changes to the project. Thanks!

My pleasure, have fun

Hi @spplante
I downloaded your code when I try to build the code  im getting below error..
Assertion `args[1]->IsString()' failed
Im new to spfx, kindly suggest what im missing

Which one did you download, the one in this conversation or the one included in the repo? The 1.1 version or the 1.4.1?
I can build both of them maje sure your npm/node is up to date


Code on computing the anomaly score is inconsistent with the paper

Hi, Thanks for your work.
From formula(6) in paper:

for formula (7) in paper, it should be:

### "with N_b (m^ ) the b nearest patch-features in M for test patch-feature m^**
but your code: w = (1 - (np.max(np.exp(N_b))/np.sum(np.exp(N_b))))
I think it's not right

I think this line "w = (1 - (np.max(np.exp(N_b))/np.sum(np.exp(N_b))))" should be changed to
"w = (1 - (np.min(np.exp(N_b))/np.sum(np.exp(N_b))))".
Because S* should be the max distance between mtest and its nearest neighbor. N_b is a vector of distance between the chosen mtest and its k-nearest neighbor. So here in this line, we only need to get the smallest distance among k distances, which is the ||mtest* - m*||.
After changing this line, the performance raise a bit.

It can be changed to "w = (1 - (np.exp(N_b[0])/np.sum(np.exp(N_b))))" because the N_b is sorted by k.
In the other hand, I want to figure out some explanation of why multiply s* by this w can make judge more robust, but still have no idea.  Does anyone have any idea of this?

It can be changed to "w = (1 - (np.exp(N_b[0])/np.sum(np.exp(N_b))))" because the N_b is sorted by k. In the other hand, I want to figure out some explanation of why multiply s* by this w can make judge more robust, but still have no idea. Does anyone have any idea of this?

I have the same question.


Json parse fix

Cloning the response fails because the responses are too big which causes back pressure in buffers. Removed clone implementation.

+1


feat: xcpp support reexecution

Properly support reexecution by putting cell code inside nested namespaces __xns1::__xns2::...
Fixes: #72

Patch submitted to LLVM under https://github.com/llvm/llvm-project/pull/75547

This seems to work perfectly. Can anyone verify it?

At least post an error message and build logs.
Anyways, this patch breaks the for loop. The LLVM patch should be different, but unfortunately I don't know how.
See issue #72, I've gathered all the information there.

xeus-clang-repl is being ported to xeus-cpp. Please take a look there, although there is no re-execution support.


Update shippable.yml

Coverage decreased (-0.03%) to 97.831% when pulling a65d1c97016599fdeccf4320eae3cf55ae7c08d0 on checking-versions into 8508ff0e62c9357deb771e2d1d82d5b5de3b7e0d on master.

Coverage remained the same at 97.862% when pulling 0072d230388cee9127730451564054fed5bfcf7b on checking-versions into 8508ff0e62c9357deb771e2d1d82d5b5de3b7e0d on master.


[BUG] A task was canceled

Description
While using the Audit History extractor, the Exporting of the data takes too long, and after a while it shows an Error saying "A task was Canceled". This happens since the latest update from last week.
To Reproduce
Select Opportunity in Entity, using the Opportunity Name as the Primary Key field, Filter data using a Personal View (Open Opportunities) and click Export to CSV. Wait for a few minutes until the Error is displayed.
Expected behavior
Finish Downloading the data with a File Completed message in less than 15 minutes.
Screenshots

Desktop:
XrmToolbox Version 1.2022.5.56
Tool version 2.2021.8.1

Additional context
Preview Data option works correctly. I already re-created a new connection.

There was an update today for XRMToolBox and it's now working.


Categorise Chats

Is there any way to categorise chats like only groups, unread messages like in Cooby whatsapp chrome extension?

HI @edgardmessias can you please suggest how this can be possible?

Cooby extension is a external service, so, that data are save externally.
You can use the WA-JS to get the WhatsApp data and create by your self a service like that


Structure of the project

@VanekPetr
It would be good if at least all Python code resides under the same top folder, e.g. something like
funnel
--- models
--- financial_data_preprocessing
--- investment_club
--- ...
It's important that there is no init.py file directly on the funnel level.
We can then measure test coverage for the funnel folder... and things become cleaner...

you can also have assets, dashboard and financial_data under the funnel folder. I would not(!) tests and your mfo folder under funnel


DE24227 - Elipsis shifting slightly on Safari

See this video:
https://www.dropbox.com/s/yjuhgzvr5lmbsb9/elipsis-hover-moving.mov?dl=0

Confirmed that this no longer occurring. Not sure what changed to fix it, but the ellipses menu now stays in exactly the same place on tile hover vs. "..." hover vs. menu opening.


adding dummy data to products and seeding handling -- accept this after the prev one

LGTM NICE DUMMY DATA!


Remove service overrides for kuttl tests which don't have network-isolation

for reference https://github.com/openstack-k8s-operators/openstack-operator/blob/main/kuttl-test.yaml#L21

recheck

recheck

recheck retry limit

/lgtm
worked fine in test https://github.com/openstack-k8s-operators/openstack-operator/pull/1230


Make position transfer more reliable when track is stopped

This came up when attempting to use coupled mode in the editor (it was using decoupled until now).
When the track finished, the decoupled clock would be at a different CurrentTime to the source track (sometimes ahead, sometimes behind it) due to a final value transfer not occurring.
This would in turn cause the track to not loop correctly, as the editor was relying on checking Current vs Length to check whether playback has finished.
I know this is adding even more complexity to the existing clocks, but right now I'm just trying to get everything working. I'm plannning to probably do a full rewrite of interpolating/decoupling in the future.

I've confirmed that osu! passes all tests with this change, for whatever that's worth.


chore: enable valgrind test

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 81.13%. Comparing base (5245f5d) to head (891d3f9).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #690      +/-   ##
==========================================
- Coverage   81.26%   81.13%   -0.14%
==========================================
  Files          95       95
  Lines       24295    24407     +112
==========================================
+ Hits        19744    19803      +59
- Misses       4551     4604      +53

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


backoff: fix enforcing max backoff

The Piko client uses backoff with jitter to avoid overloading the server when reconnecting, however the client wasn't enforcing max backoff meaning it could grow far too large...

lgtm

Also updated to log how long the backoff is (otherwise it's quite hard to debug)


Dtls cannot establish with libdatachannel

When we work with OBS broadcast (which uses libdatachannel internally), DTLS connection cannot be established.
[2023-08-07T10:12:18.325Z INFO  str0m::ice::agent] Add local candidate: Candidate(host=<IP_ADDRESS>:64225 prio=2130706175)
[2023-08-07T10:12:18.325Z TRACE str0m::ice::agent] Calculated local preference: 65534
[2023-08-07T10:12:18.327Z INFO  str0m::ice::agent] Set remote credentials: IceCreds { ufrag: "p5IV", pass: "MeL2sgkoqVHqORLqUmVP9W" }
[2023-08-07T10:12:18.327Z INFO  str0m::ice::agent] Add remote candidate: Candidate(host=<IP_ADDRESS>:53735 prio=2122317567)
[2023-08-07T10:12:18.327Z TRACE str0m::ice::agent] Form pair local: Candidate(host=<IP_ADDRESS>:64225 prio=2130706175) remote: Candidate(host=<IP_ADDRESS>:53735 prio=2122317567)
[2023-08-07T10:12:18.327Z DEBUG str0m::ice::agent] Add new pair CandidatePair(0-0 prio=9115284546252701182 state=Waiting attempts=0 unanswered=0 remote=0 last=None nom=None)
[2023-08-07T10:12:18.327Z INFO  str0m::ice::agent] Add remote candidate: Candidate(host=<IP_ADDRESS>:53735 prio=2122317823)
[2023-08-07T10:12:18.327Z TRACE str0m::ice::agent] Form pair local: Candidate(host=<IP_ADDRESS>:64225 prio=2130706175) remote: Candidate(host=<IP_ADDRESS>:53735 prio=2122317823)
[2023-08-07T10:12:18.327Z DEBUG str0m::ice::agent] Add new pair CandidatePair(0-1 prio=9115285645764328958 state=Waiting attempts=0 unanswered=0 remote=0 last=None nom=None)
[2023-08-07T10:12:18.327Z INFO  str0m] DTLS setup is: false
[2023-08-07T10:12:18.327Z DEBUG str0m::session] Enable TWCC feedback
[2023-08-07T10:12:18.327Z INFO  str0m::media] Set Mid(0) extension map: Extensions()
[2023-08-07T10:12:18.327Z INFO  str0m::change::sdp] Adding SSRC: SsrcInfo { ssrc: Ssrc(5002), repairs: None, cname: Some("mjRNPIvR0kqaQS4q"), stream_id: Some("ZETlb4lFx3Lb2skD"), track_id: Some("ZETlb4lFx3Lb2skD-audio") }
[2023-08-07T10:12:18.327Z DEBUG str0m::streams::receive] Create StreamRx for SSRC: 5002
[2023-08-07T10:12:18.327Z INFO  str0m::media] Set Mid(1) extension map: Extensions()
[2023-08-07T10:12:18.327Z INFO  str0m::change::sdp] Adding SSRC: SsrcInfo { ssrc: Ssrc(5000), repairs: None, cname: Some("mjRNPIvR0kqaQS4q"), stream_id: Some("ZETlb4lFx3Lb2skD"), track_id: Some("ZETlb4lFx3Lb2skD-video") }
[2023-08-07T10:12:18.327Z DEBUG str0m::streams::receive] Create StreamRx for SSRC: 5000
[2023-08-07T10:12:18.330Z TRACE str0m::ice::agent] Enqueueing event: IceRestart(IceCreds { ufrag: "jz1H", pass: "7F517yJ2CxkpnlaC8VMsLf" })
[2023-08-07T10:12:18.330Z INFO  str0m::ice::agent] State change (new connection): New -> Checking
[2023-08-07T10:12:18.330Z TRACE str0m::ice::agent] Enqueueing event: IceConnectionStateChange(Checking)
[2023-08-07T10:12:18.330Z TRACE str0m::ice::agent] Handle next triggered pair: CandidatePair(0-1 prio=9115285645764328958 state=Waiting attempts=0 unanswered=0 remote=0 last=None nom=None)
[2023-08-07T10:12:18.330Z TRACE str0m::ice::pair] Check state: Waiting -> InProgress
[2023-08-07T10:12:18.330Z DEBUG str0m::ice::agent] Send STUN request: <IP_ADDRESS>:64225 -> <IP_ADDRESS>:53735 StunMessage { method: Binding, class: Request, attrs: [Username("p5IV:jz1H"), IceControlled(8986517625568425202), Priority(1862270719), MessageIntegrityMark, FingerprintMark], integrity_len: 0 }
[2023-08-07T10:12:18.343Z DEBUG str0m::streams::receive] Created feedback RR: ReceiverReport { sender_ssrc: Ssrc(3354681331), reports: [] }
[2023-08-07T10:12:18.343Z DEBUG str0m::streams::receive] Created feedback extended receiver report: ExtendedReport { ssrc: Ssrc(5002), blocks: [Rrtr(Rrtr { ntp_time: MediaTime(3900391938331714, 1000000) })] }
[2023-08-07T10:12:18.343Z DEBUG str0m::streams::receive] Created feedback RR: ReceiverReport { sender_ssrc: Ssrc(3354681331), reports: [] }
[2023-08-07T10:12:18.343Z DEBUG str0m::streams::receive] Created feedback extended receiver report: ExtendedReport { ssrc: Ssrc(5000), blocks: [Rrtr(Rrtr { ntp_time: MediaTime(3900391938331714, 1000000) })] }
[2023-08-07T10:12:18.343Z TRACE str0m::ice::agent] Poll event: Some(IceRestart(IceCreds { ufrag: "jz1H", pass: "7F517yJ2CxkpnlaC8VMsLf" }))
[2023-08-07T10:12:18.343Z TRACE str0m::ice::agent] Poll event: Some(IceConnectionStateChange(Checking))
[2023-08-07T10:12:18.343Z DEBUG str0m] IceConnectionStateChange(Checking)
[2023-08-07T10:12:18.343Z TRACE str0m::ice::agent] Poll transmit: Transmit { source: <IP_ADDRESS>:64225, destination: <IP_ADDRESS>:53735, len: 88 }
[2023-08-07T10:12:18.343Z TRACE str0m] OUT Transmit { source: <IP_ADDRESS>:64225, destination: <IP_ADDRESS>:53735, len: 88 }
[2023-08-07T10:12:18.343Z TRACE str0m] IN Receive { source: <IP_ADDRESS>:53735, destination: <IP_ADDRESS>:64225, contents: Stun(StunMessage { method: Binding, class: Request, attrs: [Priority(1853882367), IceControlling(6386116986444904902), Unknown(32802), Username("jz1H:p5IV"), MessageIntegrity(_), Fingerprint(1634438764)], integrity_len: 68 }) }
[2023-08-07T10:12:18.343Z TRACE str0m::ice::agent] Handle receive: Receive { source: <IP_ADDRESS>:53735, destination: <IP_ADDRESS>:64225, contents: Stun(StunMessage { method: Binding, class: Request, attrs: [Priority(1853882367), IceControlling(6386116986444904902), Unknown(32802), Username("jz1H:p5IV"), MessageIntegrity(_), Fingerprint(1634438764)], integrity_len: 68 }) }
[2023-08-07T10:12:18.343Z TRACE str0m::ice::agent] Check if accepts message: StunMessage { method: Binding, class: Request, attrs: [Priority(1853882367), IceControlling(6386116986444904902), Unknown(32802), Username("jz1H:p5IV"), MessageIntegrity(_), Fingerprint(1634438764)], integrity_len: 68 }
[2023-08-07T10:12:18.343Z TRACE str0m::ice::agent] Message accepted
[2023-08-07T10:12:18.343Z TRACE str0m::ice::agent] Remote candidate for STUN request found
[2023-08-07T10:12:18.343Z TRACE str0m::ice::agent] Found existing pair for STUN request: CandidatePair(0-0 prio=9115284546252701182 state=Waiting attempts=0 unanswered=0 remote=0 last=None nom=None)
[2023-08-07T10:12:18.343Z TRACE str0m::ice::pair] Remote binding requests: 1
[2023-08-07T10:12:18.343Z DEBUG str0m::ice::agent] Send STUN reply: <IP_ADDRESS>:64225 -> <IP_ADDRESS>:53735 StunMessage { method: Binding, class: Success, attrs: [XorMappedAddress(<IP_ADDRESS>:53735), MessageIntegrityMark, FingerprintMark], integrity_len: 0 }
[2023-08-07T10:12:18.343Z TRACE str0m::ice::agent] Enqueueing event: DiscoveredRecv { source: <IP_ADDRESS>:53735 }
[2023-08-07T10:12:18.343Z TRACE str0m::ice::agent] Poll event: Some(DiscoveredRecv { source: <IP_ADDRESS>:53735 })
[2023-08-07T10:12:18.343Z INFO  str0m] ICE remote address: <IP_ADDRESS>:53735
[2023-08-07T10:12:18.344Z TRACE str0m::ice::agent] Poll transmit: Transmit { source: <IP_ADDRESS>:64225, destination: <IP_ADDRESS>:53735, len: 64 }
[2023-08-07T10:12:18.344Z TRACE str0m] OUT Transmit { source: <IP_ADDRESS>:64225, destination: <IP_ADDRESS>:53735, len: 64 }
[2023-08-07T10:12:18.344Z TRACE str0m] IN Receive { source: <IP_ADDRESS>:53735, destination: <IP_ADDRESS>:64225, contents: Stun(StunMessage { method: Binding, class: Request, attrs: [Priority(1853882111), UseCandidate, IceControlling(6386116986444904902), Unknown(32802), Username("jz1H:p5IV"), MessageIntegrity(_), Fingerprint(3002203556)], integrity_len: 72 }) }
[2023-08-07T10:12:18.344Z TRACE str0m::ice::agent] Handle receive: Receive { source: <IP_ADDRESS>:53735, destination: <IP_ADDRESS>:64225, contents: Stun(StunMessage { method: Binding, class: Request, attrs: [Priority(1853882111), UseCandidate, IceControlling(6386116986444904902), Unknown(32802), Username("jz1H:p5IV"), MessageIntegrity(_), Fingerprint(3002203556)], integrity_len: 72 }) }
[2023-08-07T10:12:18.344Z TRACE str0m::ice::agent] Check if accepts message: StunMessage { method: Binding, class: Request, attrs: [Priority(1853882111), UseCandidate, IceControlling(6386116986444904902), Unknown(32802), Username("jz1H:p5IV"), MessageIntegrity(_), Fingerprint(3002203556)], integrity_len: 72 }
[2023-08-07T10:12:18.344Z TRACE str0m::ice::agent] Message accepted
[2023-08-07T10:12:18.344Z TRACE str0m::ice::agent] Binding request sent USE-CANDIDATE
[2023-08-07T10:12:18.344Z TRACE str0m::ice::agent] Remote candidate for STUN request found
[2023-08-07T10:12:18.344Z TRACE str0m::ice::agent] Found existing pair for STUN request: CandidatePair(0-0 prio=9115284546252701182 state=Waiting attempts=0 unanswered=0 remote=1 last=Some(Instant { tv_sec: 1147222, tv_nsec: 571870958 }) nom=None)
[2023-08-07T10:12:18.348Z TRACE str0m::ice::pair] Remote binding requests: 2
[2023-08-07T10:12:18.348Z DEBUG str0m::ice::pair] Nominated pair: CandidatePair(0-0 prio=9115284546252701182 state=Waiting attempts=0 unanswered=0 remote=2 last=Some(Instant { tv_sec: 1147222, tv_nsec: 572741375 }) nom=Nominated)
[2023-08-07T10:12:18.348Z DEBUG str0m::ice::agent] Send STUN reply: <IP_ADDRESS>:64225 -> <IP_ADDRESS>:53735 StunMessage { method: Binding, class: Success, attrs: [XorMappedAddress(<IP_ADDRESS>:53735), MessageIntegrityMark, FingerprintMark], integrity_len: 0 }
[2023-08-07T10:12:18.348Z TRACE str0m::ice::agent] Poll transmit: Transmit { source: <IP_ADDRESS>:64225, destination: <IP_ADDRESS>:53735, len: 64 }
[2023-08-07T10:12:18.348Z TRACE str0m] OUT Transmit { source: <IP_ADDRESS>:64225, destination: <IP_ADDRESS>:53735, len: 64 }
[2023-08-07T10:12:18.348Z TRACE str0m] IN Receive { source: <IP_ADDRESS>:53735, destination: <IP_ADDRESS>:64225, contents: Dtls(len: 342) }
[2023-08-07T10:12:18.348Z DEBUG str0m::dtls::ossl] Accept
[2023-08-07T10:12:18.381Z INFO  str0m::ice::agent] State change (got nomination, still trying others): Checking -> Connected
[2023-08-07T10:12:18.381Z TRACE str0m::ice::agent] Enqueueing event: IceConnectionStateChange(Connected)
[2023-08-07T10:12:18.381Z TRACE str0m::ice::agent] Nominating best candidate
[2023-08-07T10:12:18.381Z TRACE str0m::ice::agent] Enqueueing event: NominatedSend { source: <IP_ADDRESS>:64225, destination: <IP_ADDRESS>:53735 }
[2023-08-07T10:12:18.381Z TRACE str0m::ice::agent] Handle next triggered pair: CandidatePair(0-0 prio=9115284546252701182 state=Waiting attempts=0 unanswered=0 remote=2 last=Some(Instant { tv_sec: 1147222, tv_nsec: 572741375 }) nom=Nominated)
[2023-08-07T10:12:18.381Z DEBUG str0m::ice::pair] Nominated attempt STUN binding: CandidatePair(0-0 prio=9115284546252701182 state=Waiting attempts=0 unanswered=0 remote=2 last=Some(Instant { tv_sec: 1147222, tv_nsec: 572741375 }) nom=Nominated)
[2023-08-07T10:12:18.381Z TRACE str0m::ice::pair] Check state: Waiting -> InProgress
[2023-08-07T10:12:18.381Z DEBUG str0m::ice::agent] Send STUN request: <IP_ADDRESS>:64225 -> <IP_ADDRESS>:53735 StunMessage { method: Binding, class: Request, attrs: [Username("p5IV:jz1H"), IceControlled(8986517625568425202), Priority(1862270719), MessageIntegrityMark, FingerprintMark], integrity_len: 0 }
[2023-08-07T10:12:18.381Z TRACE str0m::ice::agent] Poll event: Some(IceConnectionStateChange(Connected))
[2023-08-07T10:12:18.381Z DEBUG str0m] IceConnectionStateChange(Connected)
[2023-08-07T10:12:18.381Z TRACE str0m::ice::agent] Poll event: Some(NominatedSend { source: <IP_ADDRESS>:64225, destination: <IP_ADDRESS>:53735 })
[2023-08-07T10:12:18.381Z INFO  str0m] ICE nominated send from: <IP_ADDRESS>:64225 to: <IP_ADDRESS>:53735
[2023-08-07T10:12:18.381Z TRACE str0m::ice::agent] Poll transmit: Transmit { source: <IP_ADDRESS>:64225, destination: <IP_ADDRESS>:53735, len: 88 }
[2023-08-07T10:12:18.381Z TRACE str0m] OUT Transmit { source: <IP_ADDRESS>:64225, destination: <IP_ADDRESS>:53735, len: 88 }
[2023-08-07T10:12:18.381Z TRACE str0m::dtls] Poll datagram: 256
[2023-08-07T10:12:18.381Z TRACE str0m] OUT Transmit { source: <IP_ADDRESS>:64225, destination: <IP_ADDRESS>:53735, len: 256 }
[2023-08-07T10:12:18.381Z TRACE str0m::dtls] Poll datagram: 256
[2023-08-07T10:12:18.381Z TRACE str0m] OUT Transmit { source: <IP_ADDRESS>:64225, destination: <IP_ADDRESS>:53735, len: 256 }
[2023-08-07T10:12:18.383Z TRACE str0m::dtls] Poll datagram: 256
[2023-08-07T10:12:18.383Z TRACE str0m] OUT Transmit { source: <IP_ADDRESS>:64225, destination: <IP_ADDRESS>:53735, len: 256 }
[2023-08-07T10:12:18.383Z TRACE str0m::dtls] Poll datagram: 256
[2023-08-07T10:12:18.383Z TRACE str0m] OUT Transmit { source: <IP_ADDRESS>:64225, destination: <IP_ADDRESS>:53735, len: 256 }
[2023-08-07T10:12:18.383Z TRACE str0m::dtls] Poll datagram: 256
[2023-08-07T10:12:18.383Z TRACE str0m] OUT Transmit { source: <IP_ADDRESS>:64225, destination: <IP_ADDRESS>:53735, len: 256 }
[2023-08-07T10:12:18.383Z TRACE str0m::dtls] Poll datagram: 61
[2023-08-07T10:12:18.383Z TRACE str0m] OUT Transmit { source: <IP_ADDRESS>:64225, destination: <IP_ADDRESS>:53735, len: 61 }
[2023-08-07T10:12:18.383Z TRACE str0m] IN Receive { source: <IP_ADDRESS>:53735, destination: <IP_ADDRESS>:64225, contents: Stun(StunMessage { method: Binding, class: Success, attrs: [XorMappedAddress(<IP_ADDRESS>:64225), Unknown(32802), MessageIntegrity(_), Fingerprint(2584379561)], integrity_len: 44 }) }
[2023-08-07T10:12:18.383Z TRACE str0m::ice::agent] Handle receive: Receive { source: <IP_ADDRESS>:53735, destination: <IP_ADDRESS>:64225, contents: Stun(StunMessage { method: Binding, class: Success, attrs: [XorMappedAddress(<IP_ADDRESS>:64225), Unknown(32802), MessageIntegrity(_), Fingerprint(2584379561)], integrity_len: 44 }) }
[2023-08-07T10:12:18.383Z TRACE str0m::ice::agent] Check if accepts message: StunMessage { method: Binding, class: Success, attrs: [XorMappedAddress(<IP_ADDRESS>:64225), Unknown(32802), MessageIntegrity(_), Fingerprint(2584379561)], integrity_len: 44 }
[2023-08-07T10:12:18.383Z TRACE str0m::ice::agent] Message accepted
[2023-08-07T10:12:18.383Z TRACE str0m::ice::agent] Found local candidate for mapped address: <IP_ADDRESS>:64225
[2023-08-07T10:12:18.383Z DEBUG str0m::ice::pair] Nomination success: CandidatePair(0-0 prio=9115284546252701182 state=InProgress attempts=1 unanswered=0 remote=2 last=Some(Instant { tv_sec: 1147222, tv_nsec: 572741375 }) nom=Success)
[2023-08-07T10:12:18.383Z TRACE str0m::ice::pair] Check state: InProgress -> Succeeded
[2023-08-07T10:12:18.383Z TRACE str0m::ice::pair] Recorded binding response: CandidatePair(0-0 prio=9115284546252701182 state=Succeeded attempts=1 unanswered=0 remote=2 last=Some(Instant { tv_sec: 1147222, tv_nsec: 572741375 }) nom=Success)
[2023-08-07T10:12:18.383Z TRACE str0m] IN Receive { source: <IP_ADDRESS>:53735, destination: <IP_ADDRESS>:64225, contents: Dtls(len: 15) }
[2023-08-07T10:12:18.383Z DEBUG str0m::dtls::ossl] DTLS failure: Error { code: ErrorCode(1), cause: Some(Ssl(ErrorStack([Error { code: 336602130, library: "SSL routines", function: "dtls1_read_bytes", reason: "sslv3 alert bad certificate", file: "ssl/record/rec_layer_d1.c", line: 615, data: "SSL alert number 42" }]))) }

May be have some issues with ossl.rs.
Ps: I also tested with webrtc-rs and it work well.

@giangndm-bluesea thanks for that.
It might be the expected SSL algorithm isn't there. Can you post the SDP?

@algesten Bellow is Offer from Libdatachannel and Answer from Str0m
v=0
    o=rtc<PHONE_NUMBER> 0 IN IP4 <IP_ADDRESS>
    s=-
    t=0 0
    a=group:BUNDLE 0 1
    a=group:LS 0 1
    a=msid-semantic:WMS *
    a=setup:actpass
    a=ice-ufrag:ooFK
    a=ice-pwd:Giv0kf3WBRsvl/NpomCICy
    a=ice-options:ice2,trickle
    a=fingerprint:sha-256 EF:95:E2:3C:39:5F:6C:0B:D9:B9:1C:87:29:22:77:D1:91:34:0D:CB:F0:92:69:C5:A2:72:92:06:98:F8:AA:85
    m=audio 56530 UDP/TLS/RTP/SAVPF 111
    c=IN IP4 <IP_ADDRESS>
    a=mid:0
    a=sendonly
    a=ssrc:446539624 cname:HIw16uf5wUgY2R7K
    a=ssrc:446539624 msid:DqqsVyiXSR1mlGpQ DqqsVyiXSR1mlGpQ-audio
    a=msid:DqqsVyiXSR1mlGpQ DqqsVyiXSR1mlGpQ-audio
    a=rtcp-mux
    a=rtpmap:111 opus/48000/2
    a=fmtp:111 minptime=10;maxaveragebitrate=96000;stereo=1;sprop-stereo=1;useinbandfec=1
    a=candidate:1 1 UDP<PHONE_NUMBER> <IP_ADDRESS> 56530 typ host
    a=candidate:2 1 UDP<PHONE_NUMBER> <IP_ADDRESS> 56530 typ host
    a=end-of-candidates
    m=video 56530 UDP/TLS/RTP/SAVPF 96
    c=IN IP4 <IP_ADDRESS>
    a=mid:1
    a=extmap:1 urn:ietf:params:rtp-hdrext:sdes:mid
    a=extmap:2 urn:ietf:params:rtp-hdrext:sdes:rtp-stream-id
    a=sendonly
    a=msid:DqqsVyiXSR1mlGpQ DqqsVyiXSR1mlGpQ-video
    a=rid:l send
    a=rid:m send
    a=rid:h send
    a=simulcast:send l;m;h
    a=rtcp-mux
    a=rtpmap:96 H264/90000
    a=rtcp-fb:96 nack
    a=rtcp-fb:96 nack pli
    a=rtcp-fb:96 goog-remb
    a=fmtp:96 profile-level-id=42e01f;packetization-mode=1;level-asymmetry-allowed=1

    v=0
    o=str0m-0.1.0<PHONE_NUMBER>447092337 2 IN IP4 <IP_ADDRESS>
    s=-
    t=0 0
    a=group:BUNDLE 0 1
    a=msid-semantic: WMS DqqsVyiXSR1mlGpQ
    m=audio 9 UDP/TLS/RTP/SAVPF 111
    c=IN IP4 <IP_ADDRESS>
    a=candidate:8402408543720050545 1 udp<PHONE_NUMBER> <IP_ADDRESS> 55734 typ host ufrag x2sb
    a=ice-ufrag:x2sb
    a=ice-pwd:1vDMMeruMKTl62Ygvzsm1O
    a=ice-options:trickle
    a=fingerprint:sha-256 FF:74:71:9C:BD:A3:3A:42:34:F2:DB:A2:EA:CD:2B:2A:28:1E:D4:C9:C4:81:E0:4C:19:F8:C7:BB:43:97:B0:6C
    a=setup:passive
    a=mid:0
    a=recvonly
    a=msid:DqqsVyiXSR1mlGpQ DqqsVyiXSR1mlGpQ-audio
    a=rtcp-mux
    a=rtpmap:111 opus/48000/2
    a=rtcp-fb:111 transport-cc
    a=fmtp:111 minptime=10;useinbandfec=1
    m=video 9 UDP/TLS/RTP/SAVPF 96
    c=IN IP4 <IP_ADDRESS>
    a=ice-ufrag:x2sb
    a=ice-pwd:1vDMMeruMKTl62Ygvzsm1O
    a=ice-options:trickle
    a=fingerprint:sha-256 FF:74:71:9C:BD:A3:3A:42:34:F2:DB:A2:EA:CD:2B:2A:28:1E:D4:C9:C4:81:E0:4C:19:F8:C7:BB:43:97:B0:6C
    a=setup:passive
    a=mid:1
    a=extmap:1 urn:ietf:params:rtp-hdrext:sdes:mid
    a=extmap:2 urn:ietf:params:rtp-hdrext:sdes:rtp-stream-id
    a=recvonly
    a=msid:DqqsVyiXSR1mlGpQ DqqsVyiXSR1mlGpQ-video
    a=rtcp-mux
    a=rtpmap:96 H264/90000
    a=rtcp-fb:96 transport-cc
    a=rtcp-fb:96 goog-remb
    a=rtcp-fb:96 ccm fir
    a=rtcp-fb:96 nack
    a=rtcp-fb:96 nack pli
    a=fmtp:96 level-asymmetry-allowed=1;packetization-mode=1;profile-level-id=42e01f
    a=rid:l recv
    a=rid:m recv
    a=rid:h recv
    a=simulcast:recv l;m;h

For more information, I attached Wireshark captured of the failed case
libdatachannel-connect-error.pcapng.zip

Hi @giangndm-bluesea it seems libdatachannel is rejecting our self generated TLS cert for some unknown reason (42). Could you provide the log that libdatachannel produces during this?
Also do you have some test code you can share?

@algesten It only happened with OBS WHIP build version, (we can test by using not released version at https://github.com/obsproject/obs-studio/actions/runs/5815986617 ).
When I try with libdatachannel direct it does not occur above issue. But when switch to using libnice for ICE, which failed to connect but I think it is another issue.
If have any update about that error, I will update soon.

I have the same problem.
And after some testing it seems that adding some issuer and subject information to the certificate solves the problem.
let mut x509_name = openssl::x509::X509NameBuilder::new().unwrap();
x509_name.append_entry_by_text("C", "US").unwrap();
x509_name.append_entry_by_text("ST", "CA").unwrap();
x509_name.append_entry_by_text("O", "Some organization").unwrap();
x509_name.append_entry_by_text("CN", "www.example.com").unwrap();
let x509_name = x509_name.build();

x509b.set_subject_name(&x509_name)?;
x509b.set_issuer_name(&x509_name)?;

Put this here, but maybe with relevant information.
https://github.com/algesten/str0m/blob/28956b093ac6d8b29127f455d7352fa88e52b67a/src/dtls/ossl.rs#L54

Nice catch! Let's fix that!

This is fixed by #402

@jellevd246 or @giangndm-bluesea can anyone confirm this is fixed in the main branch now?

@algesten Yes OBS WHIP has no problem connecting now for me.

🎉
Thank you both so much for investigating this! I'll make a patch release now.

Released in 0.4.1


Great work on this!

You had asked me a question about me accepting pull requests on my repo, but I think you should just continue with what you have here. If I have some time I'd love to contribute to this repo going forward. I love what you have done! I think leaning into the Unreal Engine workflow is a great choice. If you ever want to reach out, my email is my github username at gmail.

Thanks.  I am currently trying to take the geojson coordinates of features for the selected tile and draw them on an Unreal Engine landscape.  The problem I am having is getting the lon/lat coordinates to match up with the imported heightmap.  I am using the new 4.27 Georeferencing system.  I am stuck trying to convert the coordinates correctly.  If you have time, I could use the help figuring this out.  Here is my question on stackoverflow that describes what I am trying to do.  https://stackoverflow.com/questions/70582519/how-do-you-convert-long-lat-coordinates-for-a-selected-feature-in-mapbox-tile-ge.  My current thought process is to get the lon/lat at the center of the bounding box and use that as a reference starting point for the Georeferencing system.  I can get the long/lat center of the bbox no problem but even using that as a starting point in Unreal I still can't get the coordinates of the geojson features to match.  I will upload these changes soon so you can try it out if you want. https://terrain.justgeektechs.com/#/.    TY! and Cheers!

I took a look at the Unreal Engine Georeferencing docs...lots to take in there. I'm a geospatial developer and I've never used ECEF coordinates...my guess is you are seeing a non-zero elevation in your conversion as that might be the distance from the center of the earth. However, even with that your coordinate that is returned in your SO question seems wonky. Have you considered using a Projected CRS in Unreal and projecting your lat/longs to UTM and using the Flat planet shape option? Given a lat/long, you can determine the UTM zone's EPSG number with this formula (in Python):
def get_utm_epsg(lon, lat):
    """

    Returns the EPSG number for a UTM zone from a given
    input longitude and latitude.

    Parameters
    ----------
    lon : Float
        Longitude.
    lat : Float
        Latitude.

    Returns
    -------
    epsg : Integer
        The EPSG number for the UTM zone for the input longitude
        and latitude.

    """
    offset = int(round((183 + lon) / 6, 0))
    epsg = 0
    if lat > 0:
        epsg = 32600 + offset
    else:
        epsg = 32700 + offset
    return epsg

Also, your blueprint wasn't showing up at that website, it just redirects to the home page. Do you need to set it to public or something?

Here is the repo to the Unreal Plugin  https://github.com/delebash/UnrealMapboxPlugin.  You should be able to download it and open in UE4.27.  I am not sure how familiar you are with UE but you will need to show plugin and engine content.  Then scroll down to UnrealMapboxPlugin Content then choose the blueprint folder and right click and run the editor widget.  You can also edit it to see the current blueprint.  Also here is the link for the web version and yes it was set to private :(.  https://blueprintue.com/blueprint/-zo2hsac/.  I can produce projected coordinates from Mapbox in WGS84 EPSG:3857. I tried this but it still does not look right.

Cool, I'll try to load your plugin as soon as I can. I imagine EPSG:3857 can give you problems, especially as you get further north. Maybe try on a tile on the equator and see if you get better results. I read the Unreal docs in more detail....maybe try this:
Assumptions: Your heightmap is centered on (0, 0, 0) in the level and you know the lat/long of the center of the heightmap

Find the UTM Zone of the lat/long that is the center of your heightmap ( https://www.latlong.net/lat-long-utm.html )
Google the zone to find it's epsg number (e.g. https://www.google.com/search?q=utm+18n )
In the long term, use code in previous message to obtain this information

In the GeoReferencingSystem:

Planet Shape: Flat Planet
Projected CRS: EPSG: XXXXX (from the google search / code provided above)
Geographic CRS: EPSG: 4326
Origin Location in Projected CRS: unchecked
Origin Latitude: latitude of center of heightmap
Origin Longitude: longitude of center of heightmap
Origin Altitude: 0

Then for your blueprints, get a reference to your GeoReferencingSystem and for each coordinate in your GeoJSON, pipe it through Geographic to Projected --> Projected to Engine. To obtain the z value (like if a road is going over a mountain), you will need a method to query the heightmap to obtain that "pixel value". Or maybe Unreal provides a method to query the level heightmap at a specific X, Y to get a Z?
Other things to consider:

Entities that cross UTM zones. I assume in this case you would need to do a UTM zone check for each coordinate and generate/update a GeoReferencingSystem object before doing the conversion.
Autogenerating tiles in your level. If you are doing this, it may be easier to set your origin starting tile to have its origin at (min_x, min_y, 0). However, I think Unreal has a way of resetting the origin or something for larger levels and you may already be aware of this.

Awesome, I will give it a try.  When you generate the tile image from the web app it will create a geojson file with features and coordinates.  For testing I have a file with just a single road in it to make things easier.  The test files are located in UnrealMapboxPlugin\Plugins\UnrealMapboxBridge\Resources\Test Geojson Files\wewahootee road Florida.  When you run the widget just click on the button and load the sample geojson file.  The tile_info.json file has the center of the bounding box, I hope.  From what I could figure out from Mapbox it should be.
"bbox_center": {
"lng": -81.10536575317383,
"lat": 28.422353711415433
},
Thanks for the help and you are more than welcome to contribute to the projects.  It would be great working on these together.

Hmm, just noticed this in the docs: "For floating point accuracy reasons, these origin values have to be integers to avoid bad roundings." A single degree in WGS84 is huge so Origin Location in Projected CRS should be checked and you should know the center coordinate in UTM. Not too difficult.
Cool, I'll try to recreate with your test data once I get your plugin loaded.

I also have a problem with the generated heightmap.  When you import the heightmap the landscape is not created at sea level.  Please see https://github.com/delebash/unreal_mapbox_bridge/issues/7

Please try downloading the UnrealMapboxPlugin https://github.com/delebash/UnrealMapboxPlugin.  It should work now.  There was an extra dependency that was not needed.  Let me know if you have any problems. Also, if we could move discussions for UnrealMapboxPlugin to https://github.com/delebash/UnrealMapboxPlugin/issues/
Thanks.


Hybrid Demucs model implementation

Draft PR with initial model implementation with minor changes from previous implementation

Are you also adding training recipes later or will this just be for using the pretrained models?

Are you also adding training recipes later or will this just be for using the pretrained models?

Are you also adding training recipes later or will this just be for using the pretrained models?

The main goal of this is to use with pretrained models. Depending on the timeline of my internship adding further training information is a part of my goals, but is not the focus.


Remove special case for gdkx11-sys

@GuillaumeGomez  Please check is this version works

It compiles at least. Thanks for removing my hack!


configured eslint

Fixes Issue
This PR fixes the following issues: Added eslint configration
closes #64

Changes proposed
Here comes all the changes proposed through this PR

Check List (Check all the boxes which are applicable)

[x] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[x] All new and existing tests passed.
[x] This PR does not contain plagiarized content.
[x] The title of my pull request is a short description of the requested changes.

Done, I have removed it.

@shubhamku044 whatever mark conversations as resolved wherever applicable.

@shubhamku044 whatever mark conversations as resolved wherever applicable.

done


Inference with AD3 on CRF models now supports hard logic constraints.

I wanted to exploit structural (logical) constraints at inference time on a EdgeFeatureGraphCRF model trained with a OneSlackSSVM learner.
So I extended AD3 as explained in their ICML 2011 paper, and in turn I extended pystruct to have an optional constraints parameter in the predict method.
I did that extension on the CRF and SSVM classes. So almost it is widely useable.
But this inference under constraints is only supported with AD3.
(Note: This code requires the updated AD3 library, currently at https://github.com/jlmeunier/AD3.
A pull request has been done as well.)
The auto-test produces the same results, and in my application works fine.
JL

Hi again,
A new update: this time I'm contributing a new model where nodes can be of different nature (and by consequence edges as well). Each node type has its own separate state-space and weight vector (edge types also have separate weight vectors).
This required updates to AD3, which I did as well.
Thanks
JL

hey. Sorry I'm swamped. I'll try to review but I can't promise anything. It would be good to have the tests work, though I'm sure it's my fault and not yours.

Hi Andreas
Not sure I get properly your question.
I went to 0.3 because of the add of new functionalities
0.3.3 because of 3rd big stable SW state
From: Andreas Mueller<EMAIL_ADDRESS>Sent: 20 February 2017 00:51
To: pystruct/pystruct<EMAIL_ADDRESS>Cc: Meunier, Jean-Luc<EMAIL_ADDRESS>Author<EMAIL_ADDRESS>Subject: Re: [pystruct/pystruct] Inference with AD3 on CRF models now supports hard logic constraints. (#193)
@amueller commented on this pull request.

In setup.pyhttps://github.com/pystruct/pystruct/pull/193#discussion_r101932970:

@@ -10,18 +10,18 @@

include_dirs = [np.get_include()]
setup(name="pystruct",

 version="0.2.5",

 install_requires=["ad3"],

 version="0.3.3",

what is that based on?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://github.com/pystruct/pystruct/pull/193#pullrequestreview-22673389, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AOWTUC3zn6GG8HZne1lt4psn1_PX1gaFks5reNV8gaJpZM4Ksm-r.

Hi Andy
Thanks for the review.
I pushed 0.3.4 which fixes ones pb and now passes all tests (apart one which was not passing anyway, and fixing it would require quite some work for me to understand it fully)
JL
From: Andreas Mueller<EMAIL_ADDRESS>Sent: 20 February 2017 00:49
To: pystruct/pystruct<EMAIL_ADDRESS>Cc: Meunier, Jean-Luc<EMAIL_ADDRESS>Author<EMAIL_ADDRESS>Subject: Re: [pystruct/pystruct] Inference with AD3 on CRF models now supports hard logic constraints. (#193)
hey. Sorry I'm swamped. I'll try to review but I can't promise anything. It would be good to have the tests work, though I'm sure it's my fault and not yours.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://github.com/pystruct/pystruct/pull/193#issuecomment-280960188, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AOWTUMV8duwwXXXQ4RSksFAHKIAoQzP8ks5reNTwgaJpZM4Ksm-r.


Browser Console Output displays 'Total balance: BTC'. It should say 'Total balance: BCH'

Browser Console Output displays 'Total balance: BTC'. It should say 'Total balance: BCH'
Ran against Chain: bch/livenet
Console output is incorrect:

Fixed in PR #92.

PR was merged. Closing.


Replace deprecated .Capabilities.KubeVersion.GitVersion with .Capabilities.KubeVersion.Version in helm charts

How to categorize this PR?

/kind enhancement
What this PR does / why we need it:

Replace deprecated .Capabilities.KubeVersion.GitVersion with .Capabilities.KubeVersion.Version in helm charts, see https://github.com/helm/helm/blob/6d96283c0ba0f1f3aa2c80ebe7f86e98d571d5a1/pkg/chartutil/capabilities.go#L82-L83
Update helm in tools

Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Release note:

NONE

/approve


allow haproxy's syslog len parameter to be set via attribute

add new attribute node['haproxy']['syslog']['length'] to set a max syslog line length in haproxy.cfg.  Default value of nil has no impact and the haproxy default of 1024 will remain.
See https://cbonte.github.io/haproxy-dconv/configuration-1.5.html#3.1-log
Without this setting, long URLs can result in truncated log entries in the haproxy log file.

@andrewgoktepe Thanks for the contribution. Can you please update this PR to 'develop' instead of to 'master'.

Done.  New PR submitted for develop branch: #126


reformat, tidy, add support for all Pointer, Vector, Array

Gets rid of ParseOptions in favor of using logger.debug and a comptime argument to omit logging in release builds.
Adds support for Vectors, Arrays, and all Pointers.
Tidy up code related to determining when we need an allocator

Looks good! Thanks Nameless!


put less-loader in correct position

Okey not sure if I like this put according to the source
https://github.com/facebookincubator/create-react-app/blob/master/packages/react-scripts/config/webpack.config.prod.js
https://github.com/facebookincubator/create-react-app/blob/master/packages/react-scripts/config/webpack.config.dev.js
new rules should be put before file loader. This change fixes that that means it will also make assumptions of the real config. Another way would be to put it after eslint and before oneOf.
What do you think? Not even sure why they document that it needs to be before file loader, given that it actually works as it is today.

Guess we'll run with this for now not sure why either.


Problem with SortableTreeWithoutDndContext

Reporting a Bug?
Troubleshooting have problem
Requesting a Feature?
import { SortableTreeWithoutDndContext as SortableTree } from 'react-sortable-tree';

Hi,
without a code example it is hard to tell what's wrong. For start, can you create a small example on codesandbox and also look at example here.

@jzoric  which more example need?
I only imported SortableTreeWithoutDndContext
And i get error

@top1st I asked for code example because I believe you don't have DnD context for the SortableTree.
In this codesandbox, if I export the App component without DnD context I will get the same error message as you do, but if I export it with the context everything is working fine.

@top1st Hi, what is the status with this?

I just happened to have the same problem because I simply replaced the import line as described in  README.md  Troubleshooting part.
the solution is to look at the example, and add another line
export default DragDropContext(HTML5Backend)(YourComponent);


Fixing #1391 Missing Separator When Headers are Hidden

fixes #1391

[x] I have read the Contribution Guidelines
[x] I have commented on the issue above and discussed the intended changes
[x] A maintainer has signed off on the changes and the issue was assigned to me
[x] All newly added code is adequately covered by tests
[x] All existing tests are still running without errors
[x] The documentation was modified to reflect the changes OR no documentation changes are required.

Changes
Fixes table render when headers are hidden by adding an additional condition to the check that renders table separator to cover case when table headers are not rendered and therefor a new separator is needed

Merged! Thank you for your contribution. Much appreciated! 👍


⚠ Bofrost.gr has degraded performance

In 19fcc4b, Bofrost.gr (https://www.bofrost.gr) experienced degraded performance:

HTTP code: 200
Response time: 2048 ms

Resolved: Bofrost.gr performance has improved in 891f632 after 6 minutes.


Create default config files for Wazuh

Description
We need to create the default configuration files for Wazuh. More precisely, the opensearch_dashboards.yml file.
Also, some of the base changes were applied directly to the source code, and later had to be reverted due to tests not passing. These changes will be applied using the corresponding configuration options.
Changes

[x] #17
[x] expandedHeader

Re-opened in https://github.com/wazuh/wazuh-dashboard/pull/53
See https://github.com/wazuh/wazuh-dashboard/issues/1#issuecomment-1516555068 for details.


SIG-2165 Add eIDAS Login verification

Adds a verification object for the eIDAS Login

Can be merged after eIDAS production release


[Python] Define the unittests using pytest

Rationale for this change

pytest is more convenient for writing python tests and we should be able to reuse the testing suite define in pyarrow.
What changes are included in this PR?

Are there any user-facing changes?

Codecov Report

Merging #493 (f877f83) into master (a1b8305) will not change coverage.
The diff coverage is n/a.

:exclamation: Current head f877f83 differs from pull request most recent head 0d8ccbb. Consider uploading reports for the commit 0d8ccbb to get more accurate results

@@           Coverage Diff           @@
##           master     #493   +/-   ##
=======================================
  Coverage   75.80%   75.80%
=======================================
  Files         153      153
  Lines       25924    25924
=======================================
  Hits        19652    19652
  Misses       6272     6272

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a1b8305...0d8ccbb. Read the comment docs.

see related https://github.com/apache/arrow-datafusion/pull/484

@kszucs  FYI PR now needs to be rebased. I agree btw that pytest is really nice (and much nicer than unittest) 👍

Do we need two requirements files? I think we only need one, for the tests?

We used multiple requirements file in pyarrow for easier dependency composition. Though there are nicer ways to define  multiple kinds of dependency. I don't have a strong preference, so I'm going to add pytest to the requiremets.txt file.


resolved_ts: refactor region_read_progress to avoid time-consuming operation in raftstore

What problem does this PR solve?
Issue Number: close #10342
Problem Summary:
Currently, the CheckLeader rpc is handled in raftstore, when the number of regions info in the CheckLeader request is large, handling the request could be time-consuming, and may increase the tail latency of Append log duration/Propose wait duration.
What is changed and how it works?
What's Changed:
This PR fix the issue by:

move the handling of CheckLeader request to the resolved-ts worker
instead of StoreMeta, using another fine-grained mutex for region_read_progress

Related changes

Need to cherry-pick to the release branch

Check List

Existing integration test

Release note
None

/rebuild

How does it perform comparing to no check-leaders at all?

How does it perform comparing to no check-leaders at all?

The CheckLeader is disabled by dynamically changing the resolved-ts.advance-ts-interval to 1h at about 23:15

/rebuild

/rebuild

I have done more benchmark about this PR, the result looks good:

The first three workloads are running on the master branch with the CheckLeader interval set to 1s, 5s and 1h (which can consider as disable CheckLeader) respectively, we can see the .999 and .99 latency is highly affected by the CheckLeader interval and with this PR the effect is not more exist.

/run-integration-common-test

/merge


typo Fix some display errors

Proposed changes
Issue Number: close #xxx
Problem summary
It is different from the corresponding Chinese page display, and I fixed it.
Checklist(Required)

[ ] Does it affect the original behavior
[ ] Has unit tests been added
[ ] Has document been added or modified
[ ] Does it need to update dependencies
[ ] Is this PR support rollback (If NO, please explain WHY)

Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

run buildall

run p0


belongsToMany  - show Extra Pivot Column in the Form view

Version information

Laravel: v5.7.13
Voyager: v1.1.10
PHP: 7.2.10
Database: MySQL 5.7

Description

First, in my app, I have those 3 models :
Workout

id
name
image

Exercise

id
name
description

exercise_workout

Pivot Table

exercise_id
workout_id
number_sets

When a user want to add new workout, he will enter the name, image and multiple exercises for this workout. For that I used "BelongsToMany" Relationship and it's worked perfectly.

Expected behavior
The issue that the "Add Form" generated by Voyager not showing  a field for number_sets, it's showing only a field for exercises only. How can I resolve this issue?

Please search before opening new issues.
Closing as a duplicate of  https://github.com/the-control-group/voyager/issues/3327 , https://github.com/the-control-group/voyager/issues/2556 and many more.


Chisel Compile Times Way Too Long (Too Many Duplicates)

Here is a test app (inspired by GDA), whose chisel compiles 20x slower than old spatial.  Even worse, NW and SW take hours to compile when they used to take seconds, most likely because of this.  This may turn out to be the same root cause as a previous issue
@test class DupTest extends SpatialTest {

  override def runtimeArgs: Args = NoArgs

  def main(args: Array[String]): Void = {
    val d = DRAM[Int](16,16)

    Accel {

      val s = SRAM[Int](16)
      Foreach(16 by 1){i => s(i) = i}
      val s2 = SRAM[Int](16,16)
      Foreach(16 by 1, 16 by 1 par 8) {(i,j) => s2(i,j) = s(i) * s(j)}
      d store s2

    }

    printMatrix(getMatrix(d), "result: ")

  }
}

In old spatial, there would be two duplicates of s.  In new spatial, there are 9 duplicates.

Added spatial.tests/feature/banking/ReadBroadcast to check this

This turned out to be due to the general MemPrimitives io interface having wires for each address in the case of regfiles.  This was fixed and compile times are normal now


Nextjs Usage Issue [ Property 'l-bouncy' does not exist on type 'JSX.IntrinsicElements' ]

I've tried the dynamic import from the nextjs guide, but I'm still facing the same issue.
I'm using:
next 15.0.4
react 19
tried with ldrs 1.0.1 and 1.0.2

I can confirm the issue. The current solution isn't working for current versions of Next. I have to investigate, but for now, you can fix this by including the following:
declare module "react" {
  namespace JSX {
    interface IntrinsicElements {
      'l-bouncy': {
        size?: string | number
        color?: string | number
        speed?: string | number
      }
    }
  }
}

Alternately you can use the raw HTML/CSS.


Override probot/stale defaults, if necessary

Per the discussion in https://github.com/exercism/discussions/issues/128 we
will be installing the probot/stale integration on the Exercism organization on
April 10th, 2017.
By default, probot will comment on issues that are older than 60 days, warning
that they are stale. If there is no movement in 7 days, the bot will close the issue.
By default, anything with the labels security or pinned will not be closed by
probot.
If you wish to override these settings, create a .github/stale.yml file as described
in https://github.com/probot/stale#usage, and make sure that it is merged
before April 10th.
If the defaults are fine for this repository, then there is nothing further to do.
You may close this issue.

I made a mistake.
This was not explicitly documented in the README, but probot/stale requires the presence of a .github/stale.yml file.
If you want the default behavior, you need to add an empty .github/stale.yml file to this repo, otherwise the bot will not be active.

@kytrinyx here is another one without that file. let me know if you'd like help with these.

Nice! Yeah, would you mind submitting a PR for this here?

@kytrinyx wouldn't mind at all.  Doesn't seem as though this track has any labels to exclude so we'd just use a pretty basic version of the config file.

Yeah, I created a stale label that we could use instead of wontfix. Other than that I think we should just keep the defaults.


7 tests failing on Alpine Linux (musl libc) v2.3.1

With v2.3.1 7 of the tests fail (make test). I am not certain but I think it is due to musl libc not supporting the used character encodings.
cupsCharsetToUTF8(CUPS_ISO8859_7): FAIL (len=-1, expected 8)
    utf8greek: 41 20 21 3d 20 ce91 2e
    utf8dest:
cupsUTF8ToCharset(CUPS_WINDOWS_932): FAIL
cupsCharsetToUTF8(CUPS_WINDOWS_932): FAIL (len=-1, expected 9)
    utf8japan: 41 20 21 3d 20 ee9c80 2e
    utf8dest:
cupsUTF8ToCharset(CUPS_EUC_JP): PASS
cupsUTF8ToCharset(CUPS_WINDOWS_950): FAIL
cupsCharsetToUTF8(CUPS_WINDOWS_950): FAIL (len=-1, expected 9)
    utf8taiwan: 41 20 21 3d 20 e4b982 2e
    utf8dest:
cupsUTF8ToCharset(CUPS_EUC_TW): FAIL
cupsCharsetToUTF8(CUPS_EUC_TW): FAIL (len=-1, expected 9)
    utf8taiwan: 41 20 21 3d 20 e4b982 2e
    utf8dest:
make[1]: *** [Makefile:625: testi18n] Error 1
make[1]: *** Waiting for unfinished jobs....

buildlog - buildlog.txt

Yes, if your libc provides the iconv API, it needs to actually support it.


Fix MultiMesh errors in editor and resource duplication

The buffer property of a MultiMesh can't be set when there are no instances, but no instances are the default so it causes issues with the editor and resource duplication.
Trying to set the property in the editor gives this error:

rendering/renderer_rd/storage_rd/mesh_storage.cpp:1935 - Condition "p_buffer.size() != (multimesh->instances * (int)multimesh->stride_cache)" is true.

When the MultiMesh is a resource_local_to_scene, the engine gives this error every time it instantiates a scene with it:

Buffer argument is not a valid buffer of any type.

Fixes: https://github.com/godotengine/godot/issues/68592

Thanks!


Popcorn desktop

No open issues

The install fail might be related to:
https://github.com/popcorn-official/popcorn-desktop/issues/2768


Send me to the graveyard

@mccalluc this repo can go to the graveyard

Done! I'll also add a note to the readme and archive.


Make a "register_colormap" hookspec

🚀 Feature
Following discussion in https://twitter.com/sofroniewn/status/1413691322334998528 and some more plugin dev stuff that i've been playing with - I think it would be very nice to add a hookspec to allow plugins to register custom colormaps.
I'm imagining something like
@napari_hook_specification(historic=True)
def napari_register_colormap() -> Union[
    ColormapType, List[ColormapType]
]:

where a ColormapType is a dict with kwargs that are the inputs to https://github.com/napari/napari/blob/aade148d8e5cb339bb2981ab4d1081ae5d2747e0/napari/utils/colormaps/colormap.py#L28-L46
Thoughts? I'd immediately start using this in one of my plugins, and it would let me reduce the plugins dependency on napari.
Could be used by custom reader/ IO plugins as well when they want to specify extra colormaps. We might need to think about name-spacing to make sure there aren't collisions between builtins/ plugins. I'd prefer not to allow people to overwrite builtins due to "reproducibility" reasons - I'd rather not get in a situation where the same layer data looks different because of what plugins people have installed - that seems like a "reproducibility" nightmare, so we might need to namespace are prevent duplicates

i like it.


WebAssembly example having compilation problem

Compilation issue with web_app example
Description
Having problem while trying to compile the web assembly example
Over commit f6477d1d6be89927866659e960e7c05198cbf4d6, following issues is seen:
...
   Compiling gloo-events v0.1.1
   Compiling gloo-console-timer v0.1.0
   Compiling gloo-timers v0.2.1
   Compiling gloo-file v0.1.0
   Compiling gloo v0.2.1
   Compiling web_app v0.1.0 (/home/va/meilisearch-rust/examples/web_app)
error[E0277]: `Rc<std::string::String>` cannot be shared between threads safely
  --> src/lib.rs:16:1
   |
16 | / lazy_static! {
17 | |     static ref CLIENT: Client = Client::new(
18 | |         "https://finding-demos.meilisearch.com",
19 | |         "2b902cce4f868214987a9f3c7af51a69fa660d74a785bed258178b96e3480bb3",
20 | |     );
21 | | }
   | |_^ `Rc<std::string::String>` cannot be shared between threads safely
   |
  ::: /home/va/.cargo/registry/src/github.com-1ecc6299db9ec823/lazy_static-1.4.0/src/inline_lazy.rs:19:20
   |
19 |   pub struct Lazy<T: Sync>(Cell<Option<T>>, Once);
   |                      ---- required by this bound in `lazy_static::lazy::Lazy`
   |
   = help: within `Client`, the trait `Sync` is not implemented for `Rc<std::string::String>`
   = note: required because it appears within the type `Client`
   = note: this error originates in the macro `__lazy_static_create` (in Nightly builds, run with -Z macro-backtrace for more info)

error: aborting due to previous error

For more information about this error, try `rustc --explain E0277`.
error: could not compile `web_app`

To learn more, run the command again with --verbose.

$ cargo --version
cargo 1.54.0 (5ae8d74b3 2021-06-22)
$ rustc --version
rustc 1.54.0 (a178d0322 2021-07-26)
Built using this command:
~/meilisearch-rust/examples/web_app$ cargo build
Any change I could make to compile this? or something I am missing?
Thanks.

@vsndev3 I just tried and was able to build without error using these flags for my build cargo build --example web_app --target wasm32-unknown-unknown --features=sync. If you build with the flags set do you still get errors?

@sanders41 Thanks, the build cargo build --example web_app --target wasm32-unknown-unknown --features=sync works, however the issue is seen if wasm-pack build examples/web_app/ --target=web --no-typescript
The wasam-pack version I am using is:
> wasm-pack -V
wasm-pack 0.10.0

I am assuming it could be due to interoperability reasons by wasm-pack

I can confirm I get the same error with wasm-pack build examples/web_app/ --target=web --no-typescript using both wasm-pack 0.9.1 and 0.10.0. I'm not very familiar with wasm so unfortunately beyond confirming I get the same error, I'm not sure of the solution.

Closing the issue, since compilation is working with cargo and due to wasm-pack.

HI @vsndev3, building with wasm-pack is possible. Try something like
wasm-pack build examples/web_app/ --target=web -- --features=sync

If I remember well, this is how to add optional features with wasm-pack


Validate called on initial render, how to determine if the form is submitting?

The validate function is currently called when reading the fields on form init.
Nothing is passed in the props (except in private properties) to determine if the form is submitting or not.

validate calls on init and when field values change,
It helps to prevent submitting if form is invalid
If you want to validate only after submit - you have to return Promise.reject(errors) in function you passed to handleSubmit
Look at props documentation for details


fix previous pattern link

the link to task chaining is wrong
Thank you for helping make the Dapr documentation better!
Please follow this checklist before submitting:

[ ] Commits are signed with Developer Certificate of Origin (DCO - learn more)
[ ] Read the contribution guide
[ ] Commands include options for Linux, MacOS, and Windows within codetabs
[ ] New file and folder names are globally unique
[ ] Page references use shortcodes instead of markdown or URL links
[ ] Images use HTML style and have alternative text
[ ] Places where multiple code/command options are given have codetabs

In addition, please fill out the following to help reviewers understand this pull request:
Description

source
page: https://docs.dapr.io/developing-applications/building-blocks/workflow/workflow-patterns/
Issue reference
n/a

@spottedmahn - You will need to perform a new pull on Dapr v1.11 branch for the build to succeed. Thx

new PR created: #3396


Change user guide link in help window

Codecov Report

Merging #165 (17e536d) into master (84325e8) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #165   +/-   ##
=========================================
  Coverage     71.32%   71.32%
  Complexity      503      503
=========================================
  Files            81       81
  Lines          1559     1559
  Branches        194      194
=========================================
  Hits           1112     1112
  Misses          396      396
  Partials         51       51

Impacted Files
Coverage Δ

src/main/java/seedu/address/ui/HelpWindow.java
0.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 84325e8...17e536d. Read the comment docs.


Mouse cursor gone

It was working before and then something updated and now the mouse cursor disappeared I tried changing the display from windowed to fullscreen to fullscreen windowed, I tried all the options for display but when I have poe overlay open the cursor disappears. The game works normally if I don't have poe overlay open.
Things that have been updated since it worked.
Graphics card drivers nvidia 457.09
Epic store.
POE itself. <IP_ADDRESS>
Win 10

I think I figured this out something with the geforce overlay it appears. I turned that off and changed it to windowed fullscreen again and it seems to be working again.


2i2c-aws-us, cosmicds: cleanup not needed trick for repo2docker logs

I've confirmed that this isn't needed, practically checking that I get logs at /srv/repo/.jupyter-server-log.txt even when we leave singleuser.cmd set to jupyterhub-singleuser, which overrides the docker image's CMD (but not ENTRYPOINT).
repo2docker sets ENTRYPOINT (k8s command) and CMD (k8s args, and singleuser.cmd mapping to KubeSpawner.cmd) like this, as seen from docker inspect  quay.io/nmearl/hubble-user-image:294205fdd286:
            "Cmd": [
                "jupyter",
                "notebook",
                "--ip",
                "<IP_ADDRESS>"
            ],

            "Entrypoint": [
                "/usr/local/bin/repo2docker-entrypoint"
            ],

With this, #3805, and #3797, we no longer set cmd explicitly for any community, and rely systematically on the z2jh defaults of specifying singleuser.cmd. In practice, images ENTRYPOINT are systematically untouched, and images CMD are systematically replaced with jupyterhub-singleuser.

Thank you @sgibson91 for reviewing!


Feature: Bring back storage and network details as sensors, not attributes

Sorry, but for me this last change to move sensors of network and storage to attributes was a big mistake. To have the functionality back I would now need to create an template sensor for at least 18 Sensors ! Without that no data is logged in Grafana anymore.
I installed the release 2022.12.0 and everything is back to normal. I will not install any newer version without a fix to have my sensors back (at least as an option).

Hey @CamFlyerCH, 'big mistake' might be a bit harsh, but I get your point, and it's something I thought about as well. Thing is that as it was, there were just too many sensors being created. I'll think about the 'publish as individual sensors' option.
I'd rather have HA implement this so the user can pick individual attributes, like this feature request:
https://community.home-assistant.io/t/easy-creation-of-sensors-from-attributes/429646/10

It would be possible to create the sensors disabled by default so people that want to use them can enable them.
Or maybe like how the Mikrotik Router custom integration does it. There you can configure if you want sensors. or switches for certain functionality
.

Agreed. The thing is; I'm a single developer with a ton of pending features/bugfixes and only sparetime to spend on this project. This would mean quite a bit of extra work (more so than creating 18 template sensors I think). So I'll keep it in mind, as it'd be a nice feature, but it could take a while :(


Fixes some inconsistencies in network api definition

Apparently, and unless we are missing something, some call definitions were not consistent with the parameters this version of the network api expects. This changeset fixes calls 'create or update a network interface card' and 'create or update a public ip address'. Also defines the parameter 'LocationParameter'.
If this pull request does go in the right direction, we could provide more fixes for api definitions.

Hi @ureesoriano, I'm your friendly neighborhood Azure Pull Request Bot (You can call me AZPRBOT). Thanks for your contribution!

In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes. I promise there's no faxing. https://cla.azure.com.

TTYL, AZPRBOT;

@ureesoriano - How are you using this swagger spec? Are you using one of our auto generated sdks from the swagger spec? If so then can you let me know which language sdk are you using?
That will help me help you in a better way.
FYI, we currently auto generate in C#, Java, node.js, ruby, python and Go.

@amarzavery We are autogenerating a very, very early version of an azure sdk for perl (we also made & maintain the aws sdk for perl). So far, we are trying to get working only a small subset of calls.

@ureesoriano, Thanks for signing the contribution license agreement so quickly! Actual humans will now validate the agreement and then evaluate the PR.
Thanks, AZPRBOT;

I see. Would you like to extend this in our code generator Autorest. We have designed lot of extensions that are present in the spec and are understood by Autorest. It would be fairly easy for you to add a new language generator.

Closing the PR.


Update some important setting of PGDriveV2

What changes do you make in this PR?

Please describe why you create this PR

Here are the changes:

In PGDriveV2, the random_traffic, engine/brake force, max steering/max speed is configured.
Allow set the map seed during env.reset and env.seed
Change the block type distributions
From:

       Curve: 0.5,
        Straight: 0.1,
        StdInterSection: 0.075,
        Roundabout: 0.05,
        StdTInterSection: 0.075,
        InRampOnStraight: 0.1,
        OutRampOnStraight: 0.1,

to:
        Curve: 0.3,

        # 0.3 for straight
        Straight: 0.1,
        InRampOnStraight: 0.1,
        OutRampOnStraight: 0.1,

        # 0.3 for intersection
        StdInterSection: 0.15,
        StdTInterSection: 0.15,

        # 0.1 for roundabout
        Roundabout: 0.1,

Fix bug in MA Round environment

Checklist

[ ] I have merged the latest main branch into current branch.
[ ] I have run bash scripts/format.sh before merging.
Please use "squash and merge" mode.

Merge when tests passed!


Preload an image on Icon

I have a Feature with an svg image. Hovering over the element, I change the style of the feature with a new image, the problem is that the current image disappears and there is a little delay in showing the new image. Is there a way to preload this new image so that the change is immediate?
Default style
const feature = new Feature({
.
.
.
});
const featureStyle = new Style({
    image: new Icon({
        anchor: [anchorX, anchorY],
        src: 'data:image/svg+xml,IMGE_SVG',
        size: [width, height],
        color: 'white',
        scale: 1
    });
});
feature.setStyle(featureStyle);

Hover on feature
feature.setStyle(new Style({
    image: new Icon({
        anchor: [anchorX, anchorY],
        src: 'data:image/svg+xml,HOVER_IMGE_SVG',
        size: [width, height],
        color: 'white',
        scale: 1
    });
}))

You can preload the svgs to JavaScript Image objects and use the img option in the ol/style/Icon constructor

It works, thanks!!


Error Loading Excel File in IDS Converter

Error Loading Excel File in IDS Converter
This is a print screen of the error and attached excel file.

IDS_TEMPLATE-e1-v2.xlsx

Bug fixed


multiple choice question in an accordion automatically marked as correct.

If a question has multiple parts, then the parts that are multiple choice will appear as correct and the accordion will be collapsed, even if no answer has been selected. If I select the wrong answer and hit check my answer, it will tell me I am wrong, but the tick in the accordion remains.
Here is an example: https://staging.isaacphysics.org/questions/fasttrack_core_2?board=fasttrack_core_1_14

This still seems to be a problem.


CSHARP-2293: Implement new count API.

Evergreen patch build for this branch:
https://evergreen.mongodb.com/version/5b2c2a78e3c3313717414bc6

FYI, lots of red on the patch build. The one I saw was about hint for aggregate command.

New commit to fix the red in Evergreen with older servers. New patch build:
https://evergreen.mongodb.com/version/5b2c64ca2fbabe4924b42f06
Also updated reference docs to use CountDocuments instead of Count.


Use system save/load dialog on OS X and Windows

I dislike the godot save/load window. It feels inconsistent with all the other apps running.
It would be nice if the save and open dialogs could use the OS X and Windows default save/open dialogs on those systems so that they benefit from the familiar feel of the system specific UX and help users to find their files quicker.

Here is a comparison of how they appear on my machine.

![Uploading Screen Shot 2017-11-22 at 11.00.56 pm.png…]()

Godot does not rely on any system dialogs, and I think it should stay this way by default. Consistency across the application can also be a virtue.
I would welcome this as an option, though. But Linux support does matter as well 😄

Sorry, this is not going to happen. The UI may look nicer, but this road was not taken because users preferred to have better previews for resources instead of consistency with the OS. Closing.

in any case, if you would like the built-in filedialog to support something to make your life easier, feel free to request it

Thank you for addressing this @reduz.
Whilst I respect the reasons that this was done, it's probably not practical for me to flood the issue tracker with feature requests. People obviously value things differently, so what one person values (as a power user) in a Linux environment is probably very different to what another person values in an OS X or Windows environment.
Things that you might take for granted, for example navigating from the root of your file system to your home directory or from the file system root into a removable storage device, are not very straightforward for your average artist or high school student. It is more likely that they will become frustrated and blame it on godot. Familiarity is the strongest UX you can provide here and I urge you to reconsider whether it could be possible to mux the current implementation for Linux and offer a more uniform solution for OS X and Windows.

Here we are a few years alter, and I wondered about the current opinion on this? Has anything changed?
Personally I find the Godot file picker to be a barrier and hurdle to the Pixelorama app that I am using.
The "better previews for resources" as mentioned above is not something I am familiar with, can somebody please clarify?
This is what I see when I choose File/Open:

Also, if you export for macOS with the sandbox entitlement enabled (AFAIK, currently it's not hard requirement for the App Store distribution, but eventually it will be), native dialog is the only option to select files outside the app container. For the sandboxed app, Godot file dialog is completely broken and useless (and probably there's no fix for this, it's done deliberately for security reasons).

@bruvzg this is by far the most important point for allowing use of the native system file picker, thank you

There's native dialog module for Godot https://github.com/GodotExplorer/NativeDialogs for macOS, Windows, and Linux, but it's not updated for the long time (probably incompatible with the Godot 4.x), and I have uploaded my own module implementation (macOS File and Alert panels only, works with both 4.x and 3.x) - https://github.com/bruvzg/mac_file_panels

The "better previews for resources" as mentioned above is not something I am familiar with, can somebody please clarify?

Resource previews are only available in the editor-only EditorFileDialog, not in the FileDialog which is used in Godot projects.
See also https://github.com/godotengine/godot/pull/36053.

#36053 seems to be reinventing the wheel, and desire its good intentions will never able to please some Linux/Mac/Windows users who expect their system file picker.
So, I'll open a proposal. Thanks

Proposal filed! https://github.com/godotengine/godot-proposals/issues/1123


Remove self defined init & create Operations from ecore.ecore

self defined operations in EPackage removed from model
replaced by realization of #2 and #3


Create a working example for Cognito with JPL SSO

Currently working with JPL Identity, Credential, and Access Management team to setup JPL SSO.


Cannot set integer and "special" properties on Files

Trying to deploy a display template JavaScript file as shown here:
http://sharepointcookies.com/2015/07/working-with-display-templates-with-the-new-pnp-provisioning-core-engine/
I get the exception Apply-PnPProvisioningTemplate : Error converting value 15 to type 'System.String[]'. Path '', line 1, position 2.
The same error happens when I remove the UIVersion property with the TemplateHidden property. Another error happens with the "special" characters for TargetControlType: ;#SearchResults;#. The exception is: Apply-PnPProvisioningTemplate : Unexpected character encountered while parsing value: ;. Path '', line 0, position 0.
The error messages don't really help...
The only fix is to not have the following properties

<pnp:Property Key="UIVersion" Value="15" />
<pnp:Property Key="TemplateHidden" Value="0" />
<pnp:Property Key="TargetControlType" Value=";#SearchResults;#" />

Without these file properties (basically any int property and special character such as #) the display template provisions just fine, but it cannot be selected in a search result web part because the TargetControlType is missing. Once I set this manually everything is fine.
Setting those properties with PnP PowerShell (i.e. Set-PnPListItem ...) works without problem, so it is a problem with provisioning.
Environment is SP2013 OnPrem, using SharePointPnPPowerShell2013 2.14.1704.0.

Hi,
Thanks for your feedback. However, this issue is more engine related, rather than schema related. Thus, I will close this item and I will refer it with a new issue in the PnP-Sites-Core repository.


Don't hide pagination size selector column when there isn't a pagination dropdown

It broke the pagination buttons.

@frontsideair, thanks :)


  There's really no need for this at this point.  Let's get rid of that so the console is less noisy.

@humphd This issue can be closed. It was fixed with this PR https://github.com/humphd/brackets-browser-livedev/pull/23


feat: Add Google Workspace TXT record

Add Google Workspace TXT record

@phoward38 - just FYI: don't delete the develop branch after it merges into main

@jimbrig that was an automated deletion by an extension; I turned it off so not sure how it got re-enabled


Added instances related to Administration Type

Related to issue #135  and PR #137
The definitions might need some tweaking to make it more generalised. I was going back and forth on whether the definition needs to be related to 'administration' or any type of procedure. Feel free to provide some suggestions here :)

@lzehl I think your suggestion makes sense, so I moved them and updated with the requested changes.


Critical: People can enchant amors rpg

Hi, with the old plugin RPG-Items you cant enchant armor or weapons rpg, but with this one you can, and that is very OP because with an armor rpg and enchanted is very dificult to kill players. Regards

I cannot reproduce this issue.
Please provide:

Your server version, use /version command
Your plugin version
Take the item which has his problem in hand and issue /rpgitemupdate inspect command
Give yourself a new rpgitem and test if the issue still exists.

Server Version 1.8.8 R0.1
Plugin version: 3.5.102

If I givemyself a new rpgitem, that item would be ok, but the problem is that users can enchant the rpgitem, with the old rpgitems (thinkofdeath) if you try to enchant, the item becomes to a normal item, but with this one, people can enchant all the rpgitems.


Autorest Regen Preview to 3.0.0-alpha.20230927.2 by Dapeng Zhang from refs/pull/3775/merge

Triggered from https://github.com/Azure/autorest.csharp/pull/3775

API change check
API changes are not detected in this pull request.


How to use gemma for multi-round conversations

Thank a lot for your great work！
I deployed gemma-2b locally. I would like to understand how to have multiple rounds of dialog effectively.
I searched the internet and found that I could type in previous conversations to get answers for the next round. But I don't know exactly how it works inside Gemma. I hope to get your pointers or if you can recommend some existing tutorials.
I'm not a native English speaker and may have some grammatical problems. Thank you for your attention.

The following code is copied from the Gemma's kaggle page
# Use the model

USER_CHAT_TEMPLATE = "<start_of_turn>user\n{prompt}<end_of_turn>\n"
MODEL_CHAT_TEMPLATE = "<start_of_turn>model\n{prompt}<end_of_turn>\n"

prompt = (
    USER_CHAT_TEMPLATE.format(
        prompt="What is a good place for travel in the US?"
    )
    + MODEL_CHAT_TEMPLATE.format(prompt="California.")
    + USER_CHAT_TEMPLATE.format(prompt="What can I do in California?")
    + "<start_of_turn>model\n"
)

model.generate(
    USER_CHAT_TEMPLATE.format(prompt=prompt),
    device=device,
    output_len=100,
)

It tells how to use <start_of_turn> and <end_of_turn> to control roles and turns.
This code can inspire us to write a program for multiple rounds of dialogue, but I still have some doubts:

What should I do if there are too many dialogue rounds and the number of tokens in the Gemma model is exceeded?
I am very confused: why to call USER_CHAT_TEMPLATE.format() again in the model.generate() function call? Such an operation will produce the following strange input:<start_of_turn>user
<start_of_turn>user
What is a good place for travel in the US?<end_of_turn>
<start_of_turn>model
California.<end_of_turn>
<start_of_turn>user
What can I do in California?<end_of_turn>
<start_of_turn>model
<end_of_turn>

Hi @ranck626, Does the above response answer your question?

Hi @ranck626,
Could you please confirm if this issue is resolved for you with the above comment ? Please feel free to close the issue if it is resolved ?
Thank you.

Closing this issue due to lack of recent activity, Please feel free reopen if this is still a valid request. Thank you!


why jfoenix.jar for java8 have no JFButton?

can't use JFButton on java8??

U mean JFXButton? It's in both 8.x and 9.x JFoenix editions

this is for java8 version JFoenix when it open SceneBuilder

and this is for java9 version JFoenix when it open SceneBuilder

i did wrong..?

Hi,
You should move to Java 9 or Java 10 to use JFXButton if you can not find it in Jfoenix for java 8. I had the same problem but I moved to JFoenix for java 9 and JFXButton came back. Java 8 is old and no longer supported by Oracle so the better idiea is switch to the newer version of Java.

Thank you advice to me
But Our Team already dicision to use java8 ..ㅠㅠ
i really want to use JFoenix.. anyway thank you !!

The problem is with your Scene Builder, make sure you're using the latest version (J8 - 8.5.0), for me with build-in Scene Builder in Intellij IDEA, JFXButton is clearly visible

I'm success!! Thanks a lot!! bb!
Thank you Thank you~~!!

ljh95 how do you fixed it? i mean you switched to java 9 or still on java 8. If you still using java 8 then let me know how you've fixed this issue. Thanks please help

ljh95 how do you fixed it? i mean you switched to java 9 or still on java 8. If you still using java 8 then let me know how you've fixed this issue. Thanks please help

I've downgraded SceneBuilder V11 to V8 (For Java8), and it shows all the options now. Cheers

i coundn't fixed this issue in java 8 so, i upgraded java version to 9
On Wed, Mar 11, 2020 at 7:04 AM Cristhian<EMAIL_ADDRESS>wrote:

ljh95 how do you fixed it? i mean you switched to java 9 or still on java
8. If you still using java 8 then let me know how you've fixed this issue.
Thanks please help
I've downgraded SceneBuilder V11 to V8 (For Java8), and it shows all the
options now. Cheers
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/jfoenixadmin/JFoenix/issues/978?email_source=notifications&email_token=AKR6NJFPWHYCUTGU5UTEQPTRG3TD7A5CNFSM4HEAY2I2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEONZOCA#issuecomment-597399304,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AKR6NJDZUEIBQE4NF2ANF2DRG3TD7ANCNFSM4HEAY2IQ
.


Alpine images for PHP 5.6 do not build

See here: https://github.com/PrestaShop/prestashop-flashlight/actions/runs/9976400408
Seems to be related to a MySQLd issue not compatible for an arm64 x-compilation build.

Quick fix: if you need a PHP 5.6 PrestaShop image, please use the OS_FLAVOUR=debian build instruction, or use an official -debian Flashlight build.


react-styleguidist production build broken: Error: RangeError: Maximum call stack size exceeded

I am using Webpack 4.41.0 and I have issue with production build of documentations.
I got all my documentation production build broken for some reason.
Example: https://rollup-umd.github.io/test/
Error:  RangeError: Maximum call stack size exceeded
I haven't change anything in my source code. It just happen to be broken.
I can't remove UglifyJS plugin because react-styleguidist forbid it.
Current behavior
After running npm run styleguide:build, I have:
bundle.ebc589be.js:65 Uncaught RangeError: Maximum call stack size exceeded
    at e (bundle.ebc589be.js:65)
    at e (bundle.ebc589be.js:65)
   ...
Show 170 more frames

To reproduce

Example: https://rollup-umd.github.io/test
Local Reproduction:

git clone git@github.com:rollup-umd/test.git
cd test
npm i
npm run styleguide:build
npm i -g serve
serve public
# open chrome and http://localhost:5000

Expected behavior

Work as in npm run styleguide.

Related information
It was working 24h ago, since then, I have not change anything in all my sources codes.
All my production build in all my projects are down.
I believe (unless I am wrong but to me it is the only valid reason): the dep tree as changed.
For those who ask why I don't have a lock file: It is because we do not use package-lock.json in distributed modules, because lock file are for application.
Does anybody have an idea of what changes recently?
Is there a way I can trace and find what cause all my documentations to be broken?

@kopax in dev mode all work fine?

Yes in dev mode all work fine. The code is open source as you can see.
I just added a breakpoint in the minified code and went up the trace, and it happen in a library called color, exactly here.
This file as not been changed since June, and the library where I use it here as also not changed since February.
When I run it in development it work fine. Something must have change somewhere in the prod build.

@kopax do you use uglify-webpack-plugin or terser-webpack-plugin? I can't clone you repo, can you provide public link?

Yes we use react-styleguidist that force the use of uglify-webpack-plugin:
To reproduce

Example: https://rollup-umd.github.io/test
Local Reproduction:

git clone git@github.com:rollup-umd/test.git
cd test
npm i
npm run styleguide:build
npm i -g serve
serve public
# open chrome and http://localhost:5000

Please make sure you have the correct access rights and the repository exists.

@kopax uglify is abandoned, please switch on terser-webpack-plugin

react-styleguidist is not my module.
I have reported the issue here, I can't change that: https://github.com/webpack/webpack/issues/9794#issuecomment-540596331

@kopax

Note that react-styleguidist is not my module, I have reported your advice here: #9794 (comment)

Right solution.

It seems thay haven't change their code since July: https://github.com/webpack-contrib/uglifyjs-webpack-plugin/releases

The uglify-js package is not supported a long time and contains a lot of bugs. The plugin is not officially marked as deprecated in historical/legacy reason (we will do it in near future).

I have forked the repo and try to replace uglify-js myself. Are you confident this is the issue for me here?

@kopax give me some time, i investigate this

Thanks, I will have a try. I have checked and react-styleguidist use<EMAIL_ADDRESS>not uglifyJS anymore.

My big recommendation is using lock files in future to avoid this situations.

@kopax you can use dependencies bots (like renovate/dependabot/etc) to run CI on each new package release and automatically update a lock file (you can setup it, how often it should happens - every day, every hour, every week/etc).
It is allow to you:

catch regressions in dependencies (include transitive dependencies)
keep stable development environment
keep all dependencies up to day
have the same dependencies in yourself and other developers

We use greenkeeper, and I am seriously reconsidering to apply your strategy for the futur.
Are you still trying to understand why the minified build is causing error?

@kopax

We use greenkeeper, and I am seriously reconsidering to apply your strategy for the futur.

:+1:

Are you still trying to understand why the minified build is causing error?

Sorry, no. I don't have time on this, better if it do maintainers of terser

Thanks. I am digging into it. I haven't change my source code so I presume one library in the middle I didn't wrote is causing this, and it is related to terser because without the uglification it work.


Excluding nodes and endpoints from restoration

Fixes #71

Introduced a blacklist of resources that are non-restorable.  The
goal being that the backup can still include these resources for
logging/auditing purposes but they are explicitly added to
ExcludedResources in the RestorController's "defaulting" logic
to ensure that if someone were to explicitly ask for Node that
they would be expressly denied.

Signed-off-by: Justin Nauman<EMAIL_ADDRESS>

@jrnt30 we need to be able to restore some endpoints: those that are managed by a user. Those are services that don't have a selector specified.

Also FYI the GitHub "fixes" notation requires each issue to have "fixes" in front of it.

Thanks for the clarification.  I'll throw this in WIP and see if I can use what I have going or if it needs to be significantly refactored for endpoints.  If so I will probably just remove the endpoint support for now.

Generally LGTM. Just the 1 comment on variable naming. @skriss any other comments?

@jrnt30 squash please & I'll merge

@jrnt30 sorry, decided to get logrus in first. Mind rebasing?

No problem, that was a big one for sure. Should be good now.


org.multibit.hd.hardware.core.domain.Identity - obstructing validation

Please remove following check as it has no grounds and is making ssh auth challenges (with over 200bytes) impossible. Thanks, M.
//Preconditions.checkArgument(challengeHidden.length <= 64, "'challengeHidden' must be 64 bytes or less");

https://github.com/bitcoin-solutions/multibit-hardware/blob/develop/core/src/main/java/org/multibit/hd/hardware/core/domain/Identity.java#L35

Currently, the TREZOR firmware is using max_size=256 for SignIdentity.challenge_hidden:
https://github.com/trezor/trezor-mcu/blob/master/firmware/protob/messages.options#L91
For NIST256P1 elliptic curve, I have seen 209 byte-long blobs passed to ssh-agent for signature:
2016-02-27 19:45:41,998 DEBUG        calling sign_message()                                                                               [protocol.py:53]
2016-02-27 19:45:41,998 DEBUG        key type: ecdsa-sha2-nistp256                                                                        [formats.py:51]
2016-02-27 19:45:41,998 DEBUG        curve name: nistp256                                                                                [formats.py:58]
2016-02-27 19:45:41,998 DEBUG        looking for 58:77:de:fe:62:b0:98:2b:fd:4f:ac:03:7a:dc:5f:47                                          [protocol.py:87]
2016-02-27 19:45:41,998 DEBUG        using key 'ssh://localhost' (58:77:de:fe:62:b0:98:2b:fd:4f:ac:03:7a:dc:5f:47)                        [protocol.py:94]
2016-02-27 19:45:41,998 DEBUG        signing 209-byte blob                                                                                [protocol.py:100]
2016-02-27 19:45:41,998 DEBUG        parsed identity: {'path': None, 'host': u'localhost', 'proto': u'ssh', 'port': None, 'user': None}   [client.py:104]
2016-02-27 19:45:41,999 DEBUG        key type: ecdsa-sha2-nistp256                                                                        [formats.py:51]
2016-02-27 19:45:41,999 DEBUG        curve name: nistp256                                                                                [formats.py:58]
2016-02-27 19:45:41,999 DEBUG        ssh-connection: user 'roman' via 'publickey' ('ecdsa-sha2-nistp256')                                 [client.py:66]
2016-02-27 19:45:41,999 DEBUG        nonce: 56320455f525293be340cf9be4a713432033cba710c32b6aebb70c877b3c3444                              [client.py:67]
2016-02-27 19:45:41,999 DEBUG        fingerprint: 58:77:de:fe:62:b0:98:2b:fd:4f:ac:03:7a:dc:5f:47                                         [client.py:68]
2016-02-27 19:45:41,999 INFO         please confirm user "roman" login to "ssh://localhost" using Trezor...                               [client.py:71]
2016-02-27 19:45:52,200 DEBUG        signature: 6a905c9842d5128af926649edf89b15d0842c206f17e30ce69e11f79116771856b1a2e8afe14808aa1bdb900697ffefcfe93f3caecd47fd08b64a92c116d06e6 [protocol.py:103]
2016-02-27 19:45:52,394 INFO         signature status: OK                                                                                [protocol.py:107]
2016-02-27 19:45:52,394 DEBUG        signature size: 74 bytes                                                                             [protocol.py:112]
2016-02-27 19:45:52,394 DEBUG        reply: 110 bytes                                                                                [protocol.py:56]

Ok, 256 bytes will do. Please fix :-) Yeah 209 is about right... M.

I've increased the sizes and pushed the code against develop.
Ready for review and close.

Thanks for the additional help @romanz - much appreciated.

Fixed. Thank you guys.


Auto-generated-thumbnails

Updated the thumbnail image.

@AhsanAyaz I think, it requires a review from Vercel as well.

not really. But can you remove the ahsanayaz.com from the image? That is not required

Sure, I can.