.ds-datahub_usage_event index is created with an excess replica

Describe the bug
I have a datahub setup backed with a standalone ES. Despite that, sometimes .ds-datahub_usage_event-* indexes are created with two replicas. Replica shard could be assigned to another node, thus keeping elastic in Yellow state.
looking deeper in indices settings, most have 0 replicas configured and some 1 replica configured, which makes Elastic to create an not assignable replica shard.
All other indices have 0 replicas in its settings.
To Reproduce
Unknown.
ELASTICSEARCH_NUM_REPLICAS_PER_INDEX is at its defaults.
Expected behavior
Number of replicas/shards created respects ELASTICSEARCH_NUM_REPLICAS_PER_INDEX variable
Additional context
maybe that usage events handler counts replicas from 0 while others from 1.
Datahub version is v0.8.41

How this bot should work?
Through all the 50 issues there was no a single comment, so they are stale and will be auto closed? 👍

@igorfraa - The DataHub usage index is not managed by the same process as all other indices. It is created by the elasticsearch-setup job and the replica can be controlled with DUE_REPLICAS which as a default of 1 replica here: https://github.com/datahub-project/datahub/blob/master/docker/elasticsearch-setup/create-indices.sh#L9C5-L9C17


Adding missing frequently used components

Not sure if this extension is being still maintained. But given that this is sooo useful to me every single day (and probably to a lot of others as well), adding some of the missing most frequently used components while developing with MUI v5.

muiAvatar
muiBox
muiCard
muiChip
muiDivider
muiLink
muiPaper
muiSkeleton
muiTable

Cheers!!

Closes #2
Closes #3

yes this is still being maintained, thanks!  I'll try to add comments to this PR...

Okay that's most of the things I want to comment on I think.  Basically I try to keep the "most default" snippet for a component only using props from the most basic use case, and use other snippets for when there are more props.
Good job figuring out my crazy templating system!

Look at muiGridContainer and muiGridContainerFulll for examples of how I like to split up the default/advanced use cases.  Also, I like to use prop__optional for the advanced props because in the generated snippet that wraps the whole property in a placeholder so that you can remove it.

AWESOME extension!!! THANK you soo much for creating this!!! @jedwards1211  @oliviertassinari @heIsThePirate
I just started with using "snippets" and found your awesome extension
Could you show me how to add this snippet (if its possible at all):

add import { useTheme } from '@mui/material' to the import section
add const theme = useTheme() to the beginning of current function
(stay or jump back) to the current cursor position

im sadly already struggling at the beginning of positioning:
{
"useTheme": {
		"prefix": [
			"theme",
		],
		"body": "import { useTheme } from '@mui/material'\nconst theme = useTheme()",
		"description": "useTranslation"
	}
}

Your templating language seems amazing, and might solve this?
if so, would it be possbile somehow, to make user-created snippets with your template-language easier?
I would love to also add non mui-related stuff with your solution like:
{
"useTranslation": {
		"prefix": [
			"useTranslation",
			"t("
		],
		"body": "import { useTranslation } from 'next-i18next'\nconst { t } = useTranslation()",
		"description": "useTranslation"
	},
}

Thanks again

@heIsThePirate  can you add MuiAlert?
and can someone please merge this!!!


SEV-SNP disabled

Hi,
I have ubuntu 22.04 and I tried to setup SNP host and guest using sev-utils, when I setup the host and do the reboot SEV-SNP is not enabled for me! Look into the picture below:

I had a fresh Ubuntu with kernel 5.15 and after setting up the host I have kernel 6.11.0-rc3-snp-host-85ef1ac03.
Note: all the Bios settings for SNP are enabled.

Hi @pegahnikbakht , thanks for raising this issue.
Can you show us the output of lscpu?

Yes, here it is.

This is the output of snphost ok:
sudo ./snphost ok
[ PASS ] - AMD CPU
[ PASS ]   - Microcode support
[ PASS ]   - Secure Memory Encryption (SME)
[ FAIL ]     - SME: MSR read failed: Error Reading MSR
[ PASS ]   - Secure Encrypted Virtualization (SEV)
[ PASS ]     - Encrypted State (SEV-ES)
[ PASS ]       - SEV-ES INIT: Enabled
[ PASS ]     - SEV INIT: SEV is INIT, but not currently running a guest
[ PASS ]     - Secure Nested Paging (SEV-SNP)
[ PASS ]       - VM Permission Levels
[ PASS ]         - Number of VMPLs: 4
[ FAIL ]       - SNP: MSR read failed: Error Reading MSR
[ PASS ]       - SEV Firmware Version: Sev firmware version: 1.55
[ FAIL ]       - SNP INIT: Failed to get SNP Platform status unable to retrieve SNP platform status
[ PASS ]     - Physical address bit reduction: 5
[ PASS ]     - C-bit location: 51
[ PASS ]     - Number of encrypted guests supported simultaneously: 509
[ PASS ]     - Minimum ASID value for SEV-enabled, SEV-ES disabled guest: 100
[ PASS ]     - Reading /dev/sev: /dev/sev readable
[ PASS ]     - Writing /dev/sev: /dev/sev writable
[ PASS ]   - Page flush MSR: ENABLED
[ PASS ] - KVM supported: API version: 12
[ PASS ]   - SEV enabled in KVM: enabled
[ PASS ]   - SEV-ES enabled in KVM: enabled
[ FAIL ]   - SEV-SNP enabled in KVM: Error - contents read from /sys/module/kvm_amd/parameters/sev_snp: N
[ PASS ] - Memlock resource limit: Soft:<PHONE_NUMBER> | Hard:<PHONE_NUMBER>
[ FAIL ] - Reading RMP table: Failed to read the desired MSR: Error Reading MSR
[ FAIL ] - RMP INIT: Failed to get SNP Platform status unable to retrieve SNP platform status
[ FAIL ] - Comparing TCB values: Failed to get SNP Platform status unable to retrieve SNP platform status
ERROR: One or more tests in sevctl-ok reported a failure
Error: One or more tests in sevctl-ok reported a failure
Any idea why MSR read is failed?


WIP: example docstring to extract matrix of fwd operator

@Eric89GXL and I discussed how to extract the numpy array containing the forward operator and he suggested I add in an example docstring. This PR does that in the docstring for apply_forward.

please put it there
http://martinos.org/mne/dev/auto_tutorials/plot_forward.html
thx

closing in favor of #4123


Request to join the Pattern House Organization

Github Username : @Mahak008
I wanted to be a part of the organization in order to get knowledge about Open Source. I would like to collaborate and learn new skills and have a good experience while learning and contributing to the project.
I wanted to mentor the Series Pattern - Java @aryashah2k

Invite has been sent, Welcome to PatternHouse!


How to activate validation via JavaScript

I cannot find any way to activate validation via JavaScript, I want to manually post the data.

This is less of a materialize issue itself and more of a general "how to" question. As the framework maintainers we can't possibly answer every "how to do this and that" question. Try asking on stack overflow or in our gitter channel. Thanks.


Improve fee payer txn submission APIs

Description

This simplifies the fee payer APIs by reducing the steps needed to submit such a transaction while still maintaining support for remote signing.
Now the txn may be submitted either on the fee payer side or the sender side.
This also improves the keyless experience as proofs may be fetched asynchronously, in those cases since submission is an async function where we can await the proof fetch.
Test Plan

Tested via sponsored txn example.
More tests in progress
Related Links

I have but is it relevant to this PR?  doesn't seem so afaict

Have you seen this PR? following upcoming changes to the framework #467

I have but is it relevant to this PR? doesn't seem so afaict

(Missing) signAndSubmitAsFeePayer -> sender: Account, feePayer: Account (1 step sign)

I figure that this doesn't make sense.  If you are submitting as the fee payer you don't have access to the sender account and the sender ought to send you an authenticator that's valid for sponsorship.
Additionally the case is covered by the usual signAndSubmitTransaction.


add log.level and log.encoding to all components

Problem Statement
Add log.level and log.encoding to all components, default is the same as documented by cli flags
Related Issue
Fixes #3440
Proposed Changes
i added a log.level and log.encoding values to the chart and set the default to
Checklist

[X] I have read the contribution guidelines
[X] All commits are signed with git commit --signoff
[] My changes have reasonable test coverage
[X] All tests pass with make test
[X] I ensured my PR is ready for review with make reviewable

Great stuff, thanks for taking care of that. Could you please also update the docs here: https://external-secrets.io/latest/api/controller-options/
It would be good to add the available time encoding options as well. Would it be worth to rename it to time-encoding? Encoding could mean json/human-readable format of the log messages

@moolen how do i update the website? i have site folder in my repo but its ignored by .gitignore

There is the docs dir which contains a bunch of markdown files: https://github.com/external-secrets/external-secrets/blob/main/docs/api/controller-options.md

/ok-to-test sha=a6c6ceb

:tada: LGTM, thank you for this!


Thumbnail URL can't add MangaDex covers to some sources

Steps to reproduce
Edit info and add thumbnail URL from MangaDex website. Some sources show an error picture, other sources work properly.

Expected behavior
Images should be displayed correctly.

Actual behavior
Webtoon, mangapark, hiperdex and other sources display this message [look at the attachment]
I used the same link, but some sources works well, other don't.

Crash logs
No response
TachiyomiSY version
Preview 547 and 1.10.5 stable
Android version
14
Device
Xiaomi pad 6
Other details
When you first paste the link to the working sources they still show the error image, but when you swipe down to refresh the entry it works correctly. This doesn't happen with the "broken" sources.
Acknowledgements

[X] I have searched the existing issues and this is a new ticket, NOT a duplicate or related to another open or closed issue.
[X] I have written a short but informative title.
[X] I have gone through the FAQ and troubleshooting guide.
[X] I have updated the app to version 1.10.5.
[X] I have updated all installed extensions.
[X] I will fill out all of the requested information in this form.

That's just your run of the mill hot-linking protection in action.
It usually just takes sending the right headers to get around it but there's no way to know what they are for every arbitrary URL you throw in. At best it will reuse the extension's connection and its headers, but that will only work for the same domain, not for a completely different site like you have in your example.


Fising the content alignment in the card and having 2 cards in a row instead of having just one card

having 2 cards in a row will make it look more alluring ,right now just one card is taking too much unnecessary space

I would like to work on this issue under gssoc'23


Chrome extension does not work

As of February 28, 2018, chrome extension stopped working.

Hello @dreiguintu,
the chrome extension is working fine in my chrome,
please give us more infos about your issue.

not showing the view image button for me either. Version 64.0.3282.186

Hello @picard102,
the chrome extension is still working fine in my last version of chrome,
It may be an issue with your country google domain please check it.

.com nor .ca does it work.

Uncaught TypeError: Cannot set property 'innerText' of null
at addButton (chrome-extension://hgngncnljacgakaiifjcgdnknaglfipo/gis-vib.user.js:46)
at addedNodes.forEach (chrome-extension://hgngncnljacgakaiifjcgdnknaglfipo/gis-vib.user.js:76)
at NodeList.forEach ()
at mutations.forEach (chrome-extension://hgngncnljacgakaiifjcgdnknaglfipo/gis-vib.user.js:75)
at Array.forEach ()
at MutationObserver (chrome-extension://hgngncnljacgakaiifjcgdnknaglfipo/gis-vib.user.js:72)
Version 64.0.3282.186
Reproduced here on .co.uk.

For me as of 18th march this no longer works. The button isnt there anymore.

Also not working for me. This is the console output:
Uncaught TypeError: Cannot read property 'closest' of null
    at addButton (chrome-extension://h…/gis-vib.user.js:57)
    at forEach.call (chrome-extension://h…gis-vib.user.js:100)
    at NodeList.forEach (<anonymous>)
    at mutations.forEach (chrome-extension://h…/gis-vib.user.js:99)
    at Array.forEach (<anonymous>)
    at MutationObserver (chrome-extension://h…/gis-vib.user.js:96)


Fix/read csv kwargs

The new kwarg allow for pandas read_csv arguments to be used. Works as intended

It works

Cannot be processed over


proposal: error handling:

Proposal Details
Would you consider yourself a novice, intermediate, or experienced Go programmer?
Experienced.
What other languages do you have experience with?
Java, Groovy, Python, Erlang, Ruby, Delphi, FoxPro, C/C++, and others.
Would this change make Go easier or harder to learn, and why?
Neither. No language changes are included in this proposal.
Has this idea, or one like it, been proposed before?
Not that I am aware of.
What is the proposed change?
Simply say, in documentation and training materials (e.g. "Effective Go", "Go Style Best Practices"), that panic/recover is as acceptable as returning errors.
Is this change backward compatible?
Yes. No language changes are required.
Examples:
Idiomatic / good style:
func GetProfile(req Request) (Response, error) {
   user, err := db.GetUserById(req.Id)

   if err != nil {
      return Response{}, err
   }

   settings, err := db.GetSettingsById(req.Id)

   if err != nil {
      return Response{}, err
   }

   return Response{User: user, Settings: settings}, nil
}

Also idiomatic / good style:
func GetProfile(req Request) (resp Response, err error) {
   defer func() {
      if r := recover(); r != nil {
         err = fmt.Errorf("get profile: %w", r)
      }
   }()

   resp.User := db.GetUserById(req.Id)
   resp.Settings := db.GetSettingsById(req.Id)

   return resp, err
}

package db

...

func GetUserById(id string) User {
   user := ...

   if user == nil {
      panic(fmt.Errorf("user not found: %s", id))
   }

What is the cost of this proposal?
Minimal. Only documentation and training materials would need to be updated.
Can you describe a possible implementation?
N/A
How would the language spec change?
N/A
Orthogonality: how does this change interact or overlap with existing features?
N/A
Is the goal of this change a performance improvement?
No.
Does this affect error handling?
In the language, no. In solutions, perhaps.
*Is this about generics?
No.
Conclusion:
Panic and recover are features of the language. There is no reason that using them should be any less valid than using any other language feature. Making panic/recover as acceptable as returning errors would make error handling a less contentious subject and greatly reduce the desire of many programmers to "fix" it (or to just stop using Go).

See https://go.dev/blog/errors-are-values

See https://go.dev/blog/errors-are-values

I have seen that, many times. Dogma is alive and well here.

Go is an opinionated language.


Update install docs to install ko using Scoop

Hello, I recently created a pr in the main bucket of Scoop, to add Ko as a package. This allows Windows users to install Ko using the scoop install ko command on Windows and makes using this great tool a lot easier. :-).
As soon as the pr in the Scoop repo is merged, I'd like to update the docs how to install Ko on Windows.

Excellent! Thanks for adding it to Scoop, and for sending this PR! Please ping here when it's ready to take a look, and I'll approve and merge.

Hello @imjasonh, my pull request for the Scoop main repo was merged and Ko is now officially part available for installation with Scoop. 👍🥳
(0) > scoop install main/ko
Installing 'ko' (0.14.1) [64bit] from main bucket
ko_0.14.1_Windows_x86_64.tar.gz (9,3 MB) [====================================================================] 100%
Checking hash of ko_0.14.1_Windows_x86_64.tar.gz ... ok.
Extracting ko_0.14.1_Windows_x86_64.tar.gz ... done.
Linking D:\scoop\apps\ko\current => D:\scoop\apps\ko\0.14.1
Creating shim for 'ko'.
'ko' (0.14.1) was installed successfully!

User@PC ~
(0) > ko version
0.14.1


Use Angular 2 Template Syntax

I suggest a new major version which uses Angular 2's new template syntax. Like Marko, this extends HTML well. I think this would quickly attract a wide set of people to the project!

Hi @aaronshaf, can you please be more specific on which aspects of the Angular 2 syntax interest you? Some of the syntax is related to event binding, one-way versus two-way data-binding, etc.
On a related note, this has been discussed in a few other issues, but longer term we are thinking about replacing the HTML parser with a new parser that can recognize types of attributes. With an HTML parser every attribute is a string regardless if it is quoted or not. Here's what we are thinking:
<my-component number=1/>
<my-component expression=(a + b)/>
<my-component string="hello"/>
<my-component string-concatenated=("hello"+a)/>
<my-component boolean=true/>

Thoughts?

Hi @aaronshaf, I decided to create a more formal proposal for introducing typed attributes. Please take a look at the following and provide feedback if you get a chance: https://github.com/raptorjs/marko/issues/90

Closing this issue in favor of the proposal for #90. We want to make Marko a more powerful blend of JavaScript and HTML by adopting JavaScript as the type for all HTML attributes.


Updating Main to Version 1.0 - Released

Version 1.0 has been released.
Branch Annex-A-1 and Development  have been updated. Now  Main will be updated with this pull.

Approved !
Now we give way for version 2.0


cannot download pretrained model

hi @lindahua @sshaoshuai @hellock @MMLAB-CUHK
thanks for your great work!
but I have no VPN to download the pre-trained models on drivegoogle website.
Could you offer other ways to download ?(I'm in china)
It means a lot to me .Looking forward to your reply.
Thanks very much.

if you will,  you could leave an email address and the pretrained model you need, I can download it and send it to you :)

Could you send me a copy ? my email is<EMAIL_ADDRESS>Thanks very much. @brankyy

Could you please send me a copy ? I tried many times but still can not download! my email is<EMAIL_ADDRESS>Thank you very much!@brankyy

@brankyy could please send me the pointpillar model (model-18m), my email is<EMAIL_ADDRESS>thank you so much.

I also need  the pointpillar model (model-18m), thank you!@brankyy

I also need the pointpillar model (model-18m), thank you!@brankyy   my<EMAIL_ADDRESS>


Navbar Contributor button flow incorrectly

Issue:
Navbar Contributor button jumps to second row on certain width.
Button disappears when logged in as it is behind the second navbar
Steps to reproduce:

Enter Chrome browser mobile view.
Set width between 902 and 770 px

Screenshots:

Button on second row

Button missing

@martin-henz You encountered this issue during your lecture :)

@martin-henz You encountered this issue during your lecture :)

Yes, I was quite perplexed.


Add an API Endpoint /getVersion

This will send a header with the current version.
Additionally the logic will either send a status ok, or an upgrade command.
Later we can add code to check the user-agent and version etc.
For now just short circuit to upgrade command so we can integrate / test this in the app code bases.
Ok command:
Custom Header:
"X-API-Version": {{current version}}
{
    "status": "200",
    "message": "App version ok"
}

Upgrade command:
Custom Header:
"X-API-Version": {{current version}}
{
    "status": "426",
    "message": "Please upgrade your client"
}

X-API-Version header for specifying the version the client is expecting. Great!


[SPARK-8835][Streaming] Provide pluggable Congestion Strategies for Receiver-based Streams

The new (destructive) strategies avoid leaving elements in the TCP buffer, leading to breakages at the sender level when this buffer finally drops them.

Can one of the admins verify this patch?

/cc @tdas and @JoshRosen  (the later to issue an 'ok to test' here)

Pinging @srowen for an 'ok to test'.
Also, if you're asking yourself why some tests are in "ignore" : the answer is in the commit messages.

ok to test.

I think this requires a good design doc for me to make sense of the overall idea, and discuss the design. Its hard to discuss the design in the PR.

Merged build triggered.

Merged build started.

Test build #44516 has started for PR 9200 at commit 2e8e5de.

Test build #44516 has finished for PR 9200 at commit 2e8e5de.

This patch fails Scala style tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):\n  * class BernoulliSampler[T: ClassTag](fraction: Double, rng: Random = RandomSampler.newDefaultRNG) extends RandomSampler[T, T] \n

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44516/
Test FAILed.

Merged build triggered.

Merged build started.

Test build #44519 has started for PR 9200 at commit bc06de2.

Test build #44519 has finished for PR 9200 at commit bc06de2.

This patch fails Scala style tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):\n  * class BernoulliSampler[T: ClassTag](fraction: Double,\n

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44519/
Test FAILed.

Merged build triggered.

Merged build started.

Test build #44520 has started for PR 9200 at commit b2dd6b8.

Test build #44520 has finished for PR 9200 at commit b2dd6b8.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):\n  * class BernoulliSampler[T: ClassTag](fraction: Double,\n

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44520/
Test FAILed.

Thanks for the pull request. I'm going through a list of pull requests to cut them down since the sheer number is breaking some of the tooling we have. Due to lack of activity on this pull request, I'm going to push a commit to close it. Feel free to reopen it or create a new one.


Searching of documents must populate them without the query limit

Currently the population of the found documents is limited to the search size amount of rows, which is wrong as any document larger that this will not be populated completely (reference).
The full search must also consider this as documents are loaded fully, and we might need to remove any limits there and respect only page size of the returned docs (reference).

Need discussions with @dimas-b to understand if this is really a problem or not..

False alarm, closing. Test showed that this is not the case.


Add SerializeAsAny to migration guide and possibly move functionality into model_config

Initial Checks

[X] I confirm that I'm using Pydantic V2

Description
We ran into some issues with serialization when migrating (subclass data loss). It wasn't until finding this bug  that led us to discover the docs with the Migration warning  stating you need to use SerializeAsAny.
This is less a bug and more a request to put this front and center in the migration doc. We lost a lot of time trying to figure this out and given that serialization is so essential for any API, esp FastAPI, this isn't something that should require a ton of searching to figure out.
Anyway, wondering if there is a possible plan to implement this logic within the model_config = ConfigDict()? I think it would make more intuitive sense.
From Docs, perhaps add to migration guide:
This behavior is different from how things worked in Pydantic V1, where we would always include all (subclass) fields when recursively dumping models to dicts. The motivation behind this change in behavior is that it helps ensure that you know precisely which fields could be included when serializing, even if subclasses get passed when instantiating the object. In particular, this can help prevent surprises when adding sensitive information like secrets as fields of subclasses.
Thanks so much!
Example Code
No response
Python, Pydantic & OS Version
pydantic version: 2.1.0
        pydantic-core version: 2.4.0
          pydantic-core build: profile=release pgo=false mimalloc=true
                 install path: /Users/taddeskorris/.pyenv/versions/3.11.0/envs/merino-311/lib/python3.11/site-packages/pydantic
               python version: 3.11.0 (main, Dec 13 2022, 15:17:55) [Clang 13.1.6 (clang-13<IP_ADDRESS>.5)]
                     platform: macOS-12.5-arm64-arm-64bit
     optional deps. installed: ['typing-extensions']

Selected Assignee: @dmontagu

Anyway, wondering if there is a possible plan to implement this logic within the model_config = ConfigDict()? I think it would make more intuitive sense.

We decided it would be better as a runtime flag, see https://github.com/pydantic/pydantic-core/pull/740. The constraint has been bandwidth in implementation. A contribution to move that work forward or to improve the docs would be very welcome!

Closing as a duplicate of https://github.com/pydantic/pydantic/issues/6423, which we've included in our 2.6.0 milestone. Will remember to update the migration guide and docs as well 👍


blackfire: init at 1.44.0

Motivation for this change
Adds Blackfire, a proprietary profiler for PHP and other languages.
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[x] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

I successfully created a profile on my NixOS server.
Rendered docs:

cc @NixOS/php
One thought without looking into too deeply: Couldn't the extension/probe bit be part of the file with all other extensions? It has support for extensions that depends on other extensions.

In my experience, separate files are better for automated updates (that reminds me I still need to write an updateScript) and as fair as I can tell the dependencies to other extensions are done through the PHP attribute, which I am passing to callPackage (would be nicer if the extensions were a separate scope with its callPackage but top-level callPackage seems to work now). Also I do not think blackfire depends on anything, or anything on blackfire.
Though there are some incompatible extensions, maybe we could assert that they are not enabled at the same time?

In my experience, separate files are better for automated updates

Hmm, then we maybe should make a directory for php extension derivations and start splitting out things from "the big file" of all packages and extensions that we have today.


Can't use material icons on IconButton

Reading the docs about icons, to use google material icons you have to set 'material-icons' in the iconClassName property + the name of the icon as child of Iconbutton.
<IconButton iconClassName="material-icons" tooltipPosition="bottom-center" \n' +
        '  tooltip="Sky">settings_system_daydream</IconButton>

But I get a warning at console:
You have set both an iconClassName and a child icon. It is recommended you use only one method when adding icons to IconButtons.

Can someone help me? It seems like the docs are outdated... i'm not sure.
thankyou

@ayozebarrera The docs should be up to date. Can you post your render function please?

Following the docs couldn't achieve nothing.
I solved it:
<IconButton
  onClick={this.logout}
  tooltipPosition="bottom-center"
  tooltip="Logout"
  onClick={this.logout}>
    <i className="material-icons" style={{color: 'white'}}>exit_to_app</i>
</IconButton>

using the tag i inside with the className property. Notice that Iconbutton now is without iconClassName
You can close the issue if you think this is a good way to solving that. If not, tell me how I'm supposed to use it.
Thankyou

@ayozebarrera I'm glad you found a fix. That is very strange. I'm not sure what the difference is, but you can see that this code is working on the docs site:
https://github.com/callemall/material-ui/blob/master/docs/src/app/components/pages/components/icon-buttons.jsx#L177
<IconButton iconClassName="material-icons" tooltip="Sky">settings_system_daydream</IconButton>

Yeah, I know.. but I couldn't achieve that ;(
Will try soon :p


Ws inline edit

Here you can see inline edit component implemented as Preact/React component.
Here how it looks as a single div block:

I am happy to have some comments to styles and logic.

@tonysaad Will also add some changes after our discussion.
He want to fix "jumps" when you change from div to input.
Waiting for his changes

@alexisinwork Please check the latest changes, and let me know what do you think.
Note: There were some errors in the demo as it wasn't compatible with React Rules so I changed them a bit

@alexisinwork I like you code but there is one really small thing which @tonysaad  is missing as well. Pls put a new line between class functions^^
Beside that it looks really good :+1:

I have another question. This component covers editable texts. How do we want to handle editable selections or dates?
Should that be in one component with a type attribute or do we want to create multiple components. Then we might rename this to something type related like ws-editable-text/ws-editable-date or ws-inline-text-edit/ws-inline-select-edit.

type property would work for me. but there we have maybe the date picker?

I think few components is better idea then one super big general inline edit component

but isn't it just one property on the input field? and what about the date-picker instead of inline-edit-date?

@faboweb I would create a dedicated component (ws-inline-date-edit) which inherits from date picker but renders differently and adds required functionality

@faboweb Waiting from your approvement the whole PR and then after approve you can merge it


For empty partitions, spark_apply() fails.

See https://github.com/rstudio/sparklyr/issues/878. The following command fails:
sdf_len(sc, 10, repartition = 12) %>% spark_apply(function(e) e)

Since out of the 10 partitions, at least 2 are empty. This might be more common while working at scale. Fix is to avoid retrieving data when no rows are provided in the partition.

I think we can also close https://github.com/rstudio/sparklyr/issues/737 with this PR


Committing work in progress on ephemeral counters.

I still have some work to do on this feature, but committing what I have so far to minimize collisions with Dan.

Good to go after the flagged log statement is changed,

Addressed feedback -- merging this in.


How do I open a video, no labels, no weird stuff, just a normal video :)

❓ Questions on how to use PyTorchVideo
Pytorchvideo seems to be equipped with tons of amazing features. However, I was not able to find a way to open a video, just a video, with the library.
Thank you :)
Cheers,
Francesco

Please use the EncodedVideo.from_path method - https://github.com/facebookresearch/pytorchvideo/blob/main/pytorchvideo/data/encoded_video.py#L48


Used volumes can be deleted from other environment

⚠ POTENTIAL VOLUME DATA LOSS ⚠
Bug description
When using a volume plugin like nutanix / vsphere / glusterfs / ... in multiple swarm environments, all volumes are shown in all environments.
If a volume us used in environment 1, it is also shown in environment 2.
The dangerous thing: The volume in environment 2 is shown as "unused" even if it is used in environment 1.
Therefore it can be deleted without backend-check (is in use?) and the service in environment 1 lost all data.
Especially if the volume list is cleaned up on a regular basis by deleting "unused" volumes.
Once a volume is deleted this way, it will not be re-created even if the whole stack is re-created.
Expected behavior
Used volumes should ALWAYS be shown as used, and never be delete-able.
Even if the volume is used in another environment.
Portainer Logs
The logs did not provide any lines regarding the volume.
Steps to reproduce the issue:

create 2 swarm clusters (at least 1 manager each)
add a shared volume plugin (like nutanix, vsphere, ...)
setup portainer with this 2 swarm environments
create a service in environment 1 with a volume created with the volume plugin
switch to environment 2 "volumes"
delete the volume
check service in environment 1 > you see the volume is missing and the data is lost

Technical details:

Portainer version: 2.9.2
Docker version: 20.10.9
Platform: centos 7.9.2009
Command used to start Portainer: docker-stack file
Browser: latest chrome and safari
Use Case: portainer managing multiple swarm environments
Have you reviewed our technical documentation and knowledge base? yes

Additional context
This is maybe related to #1918
Of course, there should be also a blocking logic on volume driver side. But still the "first" user-interface (portainer) should prevent deletion of any used resource, especially because the "overall view" over all environments provide this used/unused details.
Screenshots
Environment 1

Environment 2

@mschoeffmann
Are these environments completely separate swarm clusters in your case? or are they both pointing to the same hosts / swarm cluster?
I'm trying to check further and replicate the issue.

@samdulam in this case there are 2 separated swarm clusters. you can see it at the screenshots:
sw01-mgr with sw01-n01 to 04 as nodes, and sw20m-mgr with sw20-n01 as node.
the infrastructure:
there is a manager server (portainer) with ip .1
there is sw01 with manager ip .10 and nodes .11-.14
there is sw20 with manager ip .200 and node .201
every swarm has the agent stack running.
they share:

portainer server
the storage (in our case: nutanix volume plugin, based on iscsi)

so in general, every swarm is completely separated except the storage pool (which has to be shared because sometimes volumes have to be cross-mounted between prod, dev and sandbox environments)
additional infos, just discovered:

docker volume ls also lists all volumes
docker volume rm also removes the volume without notice, but as stated above: since portainer has the general overview, deletion of used resources should be blocked at first place

@mschoeffmann
Thanks for the detailed info.
As I understand it, Portainer's behaviour is inline with docker (swarm). I also understand the need for a better management of this. Hence, I'm marking this as an enhancement request.
This will be considered for our future releases.


Fatal error during Windows desktop run

Hi team.
I used 0.4.0-build184 build 1.4.32 kotlin version.
And in two of three runs have crash.
Crash reports in attachment. Command line part omitted.
hs_err_pid6104.log
hs_err_pid18996.log
Code to reproduce:
@Composable
internal fun HorizontalScrollbarContainer(
    modifier: Modifier = Modifier,
    content: @Composable (horizontalScrollState: ScrollState) -> Unit
) = Box(
    modifier = modifier.fillMaxSize()
) {
    val horizontalScrollState = rememberScrollState(0)
    content(horizontalScrollState)
    HorizontalScrollbar(
        modifier = Modifier
            .align(Alignment.BottomCenter)
            .fillMaxWidth(),
        adapter = rememberScrollbarAdapter(horizontalScrollState)
    )
}

@Composable
fun Item(index: Int) = Row(
    modifier = Modifier
        .wrapContentHeight()
        .padding(start = 30.dp * index)
        .fillMaxWidth()
) {
    Text("Item $index")
}

@Composable
fun LazyColumnView(
    modifier: Modifier = Modifier.fillMaxSize()
) = HorizontalScrollbarContainer(modifier) { horizontalScrollState ->
    LazyColumn(
        modifier.horizontalScroll(horizontalScrollState)
    ) {
        items(300) { index ->
            Item(index)
        }
    }
}

fun main() = Window(
    "2 of 3"
) {
    MaterialTheme {
        DesktopTheme {
            LazyColumnView()
        }
    }
}

Seems crash is in
j  org.jetbrains.skiko.redrawer.Direct3DRedrawer.makeDirectXRenderTarget(JII)J+0
j  org.jetbrains.skiko.redrawer.Direct3DRedrawer.makeRenderTarget(JII)Lorg/jetbrains/skija/BackendRenderTarget;+9
j  org.jetbrains.skiko.context.Direct3DContextHandler.initCanvas()V+55
j  org.jetbrains.skiko.SkiaLayer.draw()V+83
j  org.jetbrains.skiko.redrawer.Direct3DRedrawer.draw()V+4
j  org.jetbrains.skiko.redrawer.Direct3DRedrawer.redrawImmediately()V+57
j  org.jetbrains.skiko.SkiaLayer.paint(Ljava/awt/Graphics;)V+77
j  javax.swing.JComponent.paintChildren(Ljava/awt/Graphics;)V+523 java.desktop@15
j  javax.swing.JComponent.paint(Ljava/awt/Graphics;)V+318 java.desktop@15
j  javax.swing.JLayeredPane.paint(Ljava/awt/Graphics;)V+73 java.desktop@15
j  javax.swing.JComponent.paintChildren(Ljava/awt/Graphics;)V+523 java.desktop@15
j  javax.swing.JComponent.paint(Ljava/awt/Graphics;)V+318 java.desktop@15
j  javax.swing.JComponent.paintChildren(Ljava/awt/Graphics;)V+523 java.desktop@15
j  javax.swing.JComponent.paint(Ljava/awt/Graphics;)V+318 java.desktop@15

What is your video card?

Intel(R) HD Graphics 4400

Try run your app with OpenGL rendering, sample code:
fun main() {
    System.setProperty("skiko.renderApi", "OPENGL")
    Window(
        ... // your window settings
    ) {
        ... // your content
    }
}

Tried.
Works cool. I have zero crashes for 7 runs.

Hello,
I also got the same EXCEPTION_UNCAUGHT_CXX_EXCEPTION error when my Composer Desktop program was running with my Intel graphics chipset (Intel HD Graphics 4600 chipset to be precise). During the day, I searched on the internet for the EXCEPTION_UNCAUGHT_CXX_EXCEPTION error code, and I indeed found one (and only one) result that indicated the mood incompatibility between intel chipsets (I say them, but I don't know if all are concerned) and the applications developed with this framework.
I thought I would open an issue if none was already open on this subject, so I searched for "intel" in the already open issues and I found this one.
So I took the opportunity to test @Rsedaikin's solution, and yes, it works.
So why this message ? Two reasons: first to confirm that the solution works for all those who would have the same problem, and to add the code of this error to this issue that simply explains how to solve it, because just by searching with the error code in the issues or on google, we do not come across this topic. And I thought that was a shame. I just hope that the indexing bots will do their job for future people who, like me, have already struggled to find the java runtime error code and want to solve their problem.

I also have this problem when running the plain project created by IntelliJ.
I'm currently using the workaround above suggested by @Rsedaikin.

OS: Windows 10
Integrated graphics card: Intel® HD Graphics 4600
Dedicated graphics card: AMD Radeon R7 M265
IDE: IntelliJ IDEA 2021.3
Jetbrains compose: 1.0.0
Kotlin: 1.5.31

My IntelliJ IDEA:
IntelliJ IDEA 2021.3 (Community Edition)
Build #IC-213.5744.223, built on November 27, 2021
Runtime version: 11.0.13+7-b1751.19 amd64
VM: OpenJDK 64-Bit Server VM by JetBrains s.r.o.
Windows 10 10.0
GC: ParNew, ConcurrentMarkSweep
Memory: 1469M
Cores: 8
Registry:
    debugger.click.disable.breakpoints=true

Non-Bundled Plugins:
    [...]
    org.jetbrains.kotlin (213-1.6.10-release-923-IJ5744.223)

Kotlin: 213-1.6.10-release-923-IJ5744.223

The error log:
# A fatal error has been detected by the Java Runtime Environment:
#
#  EXCEPTION_ACCESS_VIOLATION (0xc0000005) at pc=0x00007fffddca588c, pid=11104, tid=10656
#
# JRE version: OpenJDK Runtime Environment AdoptOpenJDK (<IP_ADDRESS>+1) (build <IP_ADDRESS>+1)
# Java VM: OpenJDK 64-Bit Server VM AdoptOpenJDK (<IP_ADDRESS>+1, mixed mode, tiered, compressed oops, g1 gc, windows-amd64)
# Problematic frame:
# C  [skiko-windows-x64.dll+0x5588c]
#
# No core dump will be written. Minidumps are not enabled by default on client versions of Windows
#
# If you would like to submit a bug report, please visit:
#   https://github.com/AdoptOpenJDK/openjdk-support/issues
# The crash happened outside the Java Virtual Machine in native code.
# See problematic frame for where to report the bug.
#

---------------  S U M M A R Y ------------

Command Line: -javaagent:C:\Program Files\JetBrains\IntelliJ IDEA Community Edition 2021.3\lib\idea_rt.jar=13471:C:\Program Files\JetBrains\IntelliJ IDEA Community Edition 2021.3\bin -Dfile.encoding=UTF-8 MainKt

Host: Intel(R) Core(TM) i7-4702MQ CPU @ 2.20GHz, 8 cores, 7G,  Windows 10 , 64 bit Build 19041 (10.0.19041.1348)

---------------  T H R E A D  ---------------

Current thread (0x000001d6c540a000):  JavaThread "AWT-EventQueue-0" [_thread_in_native, id=10656, stack(0x000000afa5700000,0x000000afa5800000)]

Stack: [0x000000afa5700000,0x000000afa5800000],  sp=0x000000afa57f9f10,  free space=999k
Native frames: (J=compiled Java code, j=interpreted, Vv=VM code, C=native code)
C  [skiko-windows-x64.dll+0x5588c]

Java frames: (J=compiled Java code, j=interpreted, Vv=VM code)
j  org.jetbrains.skiko.redrawer.Direct3DRedrawer.makeDirectXSurface(JJIII)J+0
j  org.jetbrains.skiko.redrawer.Direct3DRedrawer.makeSurface(JIII)Lorg/jetbrains/skia/Surface;+15
j  org.jetbrains.skiko.context.Direct3DContextHandler.initCanvas()V+160
j  org.jetbrains.skiko.context.ContextHandler.draw()V+21
j  org.jetbrains.skiko.redrawer.Direct3DRedrawer.drawAndSwap(Z)V+27
j  org.jetbrains.skiko.redrawer.Direct3DRedrawer.redrawImmediately()V+148
j  org.jetbrains.skiko.SkiaLayer.paint(Ljava/awt/Graphics;)V+88
j  androidx.compose.ui.awt.ComposeLayer$ComponentImpl.paint(Ljava/awt/Graphics;)V+12
j  javax.swing.JComponent.paintChildren(Ljava/awt/Graphics;)V+523<EMAIL_ADDRESS>j  javax.swing.JComponent.paint(Ljava/awt/Graphics;)V+318<EMAIL_ADDRESS>j  javax.swing.JLayeredPane.paint(Ljava/awt/Graphics;)V+73<EMAIL_ADDRESS>j  javax.swing.JComponent.paintChildren(Ljava/awt/Graphics;)V+523<EMAIL_ADDRESS>j  javax.swing.JComponent.paint(Ljava/awt/Graphics;)V+318<EMAIL_ADDRESS>j  javax.swing.JComponent.paintChildren(Ljava/awt/Graphics;)V+523<EMAIL_ADDRESS>j  javax.swing.JComponent.paint(Ljava/awt/Graphics;)V+318<EMAIL_ADDRESS>j  javax.swing.JLayeredPane.paint(Ljava/awt/Graphics;)V+73<EMAIL_ADDRESS>j  javax.swing.JComponent.paintChildren(Ljava/awt/Graphics;)V+523<EMAIL_ADDRESS>j  javax.swing.JComponent.paintToOffscreen(Ljava/awt/Graphics;IIIIII)V+72<EMAIL_ADDRESS>j  javax.swing.RepaintManager$PaintManager.paintDoubleBufferedImpl(Ljavax/swing/JComponent;Ljava/awt/Image;Ljava/awt/Graphics;IIII)V+163<EMAIL_ADDRESS>j  javax.swing.RepaintManager$PaintManager.paintDoubleBuffered(Ljavax/swing/JComponent;Ljava/awt/Image;Ljava/awt/Graphics;IIII)V+46<EMAIL_ADDRESS>j  javax.swing.RepaintManager$PaintManager.paint(Ljavax/swing/JComponent;Ljavax/swing/JComponent;Ljava/awt/Graphics;IIII)Z+128<EMAIL_ADDRESS>j  javax.swing.RepaintManager.paint(Ljavax/swing/JComponent;Ljavax/swing/JComponent;Ljava/awt/Graphics;IIII)V+51<EMAIL_ADDRESS>j  javax.swing.JComponent.paint(Ljava/awt/Graphics;)V+221<EMAIL_ADDRESS>j  java.awt.GraphicsCallback$PaintCallback.run(Ljava/awt/Component;Ljava/awt/Graphics;)V+2<EMAIL_ADDRESS>j  sun.awt.SunGraphicsCallback.runOneComponent(Ljava/awt/Component;Ljava/awt/Rectangle;Ljava/awt/Graphics;Ljava/awt/Shape;I)V+155<EMAIL_ADDRESS>j  sun.awt.SunGraphicsCallback.runComponents([Ljava/awt/Component;Ljava/awt/Graphics;I)V+157<EMAIL_ADDRESS>j  java.awt.Container.paint(Ljava/awt/Graphics;)V+58<EMAIL_ADDRESS>j  java.awt.Window.paint(Ljava/awt/Graphics;)V+68<EMAIL_ADDRESS>j  javax.swing.RepaintManager$4.run()Ljava/lang/Void;+142<EMAIL_ADDRESS>j  javax.swing.RepaintManager$4.run()Ljava/lang/Object;+1<EMAIL_ADDRESS>v  ~StubRoutines::call_stub
j  java.security.AccessController.doPrivileged(Ljava/security/PrivilegedAction;Ljava/security/AccessControlContext;)Ljava/lang/Object;+0<EMAIL_ADDRESS>j  java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(Ljava/security/PrivilegedAction;Ljava/security/AccessControlContext;Ljava/security/AccessControlContext;)Ljava/lang/Object;+18<EMAIL_ADDRESS>j  javax.swing.RepaintManager.paintDirtyRegions(Ljava/util/Map;)V+154<EMAIL_ADDRESS>j  javax.swing.RepaintManager.paintDirtyRegions()V+46<EMAIL_ADDRESS>j  javax.swing.RepaintManager.prePaintDirtyRegions()V+73<EMAIL_ADDRESS>j  javax.swing.RepaintManager$ProcessingRunnable.run()V+37<EMAIL_ADDRESS>j  java.awt.event.InvocationEvent.dispatch()V+47<EMAIL_ADDRESS>j  java.awt.EventQueue.dispatchEventImpl(Ljava/awt/AWTEvent;Ljava/lang/Object;)V+21<EMAIL_ADDRESS>j  java.awt.EventQueue$4.run()Ljava/lang/Void;+32<EMAIL_ADDRESS>j  java.awt.EventQueue$4.run()Ljava/lang/Object;+1<EMAIL_ADDRESS>v  ~StubRoutines::call_stub
j  java.security.AccessController.doPrivileged(Ljava/security/PrivilegedAction;Ljava/security/AccessControlContext;)Ljava/lang/Object;+0<EMAIL_ADDRESS>j  java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(Ljava/security/PrivilegedAction;Ljava/security/AccessControlContext;Ljava/security/AccessControlContext;)Ljava/lang/Object;+18<EMAIL_ADDRESS>j  java.awt.EventQueue.dispatchEvent(Ljava/awt/AWTEvent;)V+46<EMAIL_ADDRESS>j  java.awt.EventDispatchThread.pumpOneEventForFilters(I)V+78<EMAIL_ADDRESS>j  java.awt.EventDispatchThread.pumpEventsForFilter(ILjava/awt/Conditional;Ljava/awt/EventFilter;)V+35<EMAIL_ADDRESS>j  java.awt.EventDispatchThread.pumpEventsForHierarchy(ILjava/awt/Conditional;Ljava/awt/Component;)V+11<EMAIL_ADDRESS>j  java.awt.EventDispatchThread.pumpEvents(ILjava/awt/Conditional;)V+4<EMAIL_ADDRESS>j  java.awt.EventDispatchThread.pumpEvents(Ljava/awt/Conditional;)V+3<EMAIL_ADDRESS>j  java.awt.EventDispatchThread.run()V+9<EMAIL_ADDRESS>v  ~StubRoutines::call_stub

siginfo: EXCEPTION_ACCESS_VIOLATION (0xc0000005), reading address 0x0000000000000000

Register to memory mapping:
[...]

I used to have no problem running my app before version v1.2.0-alpha01-dev770 . When I tried v1.2.0-alpha01-dev770 or now,  v1.2.0-alpha01-dev774, the application fails to run with:
#
# A fatal error has been detected by the Java Runtime Environment:
#
#  EXCEPTION_ACCESS_VIOLATION (0xc0000005) at pc=0x00007ffab1886716, pid=1264, tid=9704
#
# JRE version: OpenJDK Runtime Environment (11.0.12+7) (build 11.0.12+7-b1504.28-7817840)
# Java VM: OpenJDK 64-Bit Server VM (11.0.12+7-b1504.28-7817840, mixed mode, tiered, compressed oops, g1 gc, windows-amd64)
# Problematic frame:
# C  [skiko-windows-x64.dll+0x56716]
#
# No core dump will be written. Minidumps are not enabled by default on client versions of Windows
#
# If you would like to submit a bug report, please visit:
#   https://bugreport.java.com/bugreport/crash.jsp
# The crash happened outside the Java Virtual Machine in native code.
# See problematic frame for where to report the bug.
#

But thankfully, after trying out:

...Try to run your application with OpenGL rendering, example code:
System.setProperty("skiko.renderApi", "OPENGL")

the issue disappeared.

Please check the following ticket on YouTrack for follow-ups to this issue. GitHub issues will be closed in the coming weeks.


CollectPadsStop to before parent state transition

The stopping of collect pads is an exception to the "downward state transitions after parent state transition" rule.

Codecov Report
Attention: 12 lines in your changes are missing coverage. Please review.

Comparison is base (6af9a7a) 16.38% compared to head (5465607) 16.49%.
 Consider uploading reports for the commit 68d23d8 to get more accurate results

Files
Patch %
Lines

src/gstreamer/gstkvssink.cpp
0.00%
12 Missing :warning:

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1131      +/-   ##
===========================================
+ Coverage    16.38%   16.49%   +0.11%
===========================================
  Files           51       50       -1
  Lines         6849     7014     +165
===========================================
+ Hits          1122     1157      +35
- Misses        5727     5857     +130

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

No we don't have any kvssink tests at all, have just tested for functionality locally, and this change isn't addressing any actual issue anyone was seeing, rather it is just more closely adhering to GStreamer recommendations/guidelines.

Can we at least run whatever kvssink samples we have to get some confidence that we are not regressing, whatever manual testing we have at our disposable with various pipelines that actually would exercise this code path.

Sounds good, the local testing so far has been just the kvssink sample on Mac, I'll now run all the example command line pipelines on Ubuntu, Windows, and Mac.


Remove grant year ranges from profile card display

Including grant year ranges created a mismatch between the years
listed and the name of the grant shown, which was only the
most recent one.
See #197

Codecov Report

Merging #223 into develop will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           develop     #223      +/-   ##
===========================================
- Coverage    98.13%   98.13%   -0.01%
===========================================
  Files           84       84
  Lines         2840     2839       -1
===========================================
- Hits          2787     2786       -1
  Misses          53       53


download links are not working

Hi I wanted to try your code. The data download links or the pretrained model download links are not working. Could you please update them so that I could proceed. Thanks

Hi I wanted to try your code. The data download links or the pretrained model download links are not working. Could you please update them so that I could proceed. Thanks

Hi, actually I am also really interested in this repository, did you get some idea of how to get the required data here?

Sorry for the inconvenience, however the Shapeflow data was hosted on a lab server that recently experienced some disk corruption and unfortunately I wasn't able to obtain backup files. I'm still in the process of reaching out to some other users of this data to see if they have a backup but so far I haven't been able to locate a copy myself.

I was able to find the pretrained model weights and attached it below. Hope that this is somewhat helpful, though I haven't been able to recover the other files yet.
https://drive.google.com/file/d/1FEeYAwa3eqvzZOmcF2pQ92MhHDSZ6lhA/view?usp=drive_web

Sorry for the inconvenience, however the Shapeflow data was hosted on a lab server that recently experienced some disk corruption and unfortunately I wasn't able to obtain backup files. I'm still in the process of reaching out to some other users of this data to see if they have a backup but so far I haven't been able to locate a copy myself.

That is so kind of you, thank you so much, I think that could help me a lot. btw, I have requested the access to this link, could you please approve that?


[WIP] TVM SGX

This PR allows compiling a TVM runtime that can be used in an Intel SGX enclave. It depends on https://github.com/dmlc/dmlc-core/pull/368.
Re #912: using guards seemed easier than splitting the header files (which would make understanding the codebase harder for new users, I think). I'm open to suggestions, though!
Still TODO: add working example in app/sgx
Resolves #912

@tqchen The example in apps/sgx should work now. Please let me know what you think. If it's to your liking, I'll tidy things up and add some docs!

In general, it looks good. To make the code style in apps/sgx also consistent with Google C style used in the rest of the project, let us change the suffix from cpp to cc, unless there is a code style culture for SGX that suggest the other way.

re: the failing tests, any tips? they work fine on my machine, so it's tough to figure out how (whether?) to fix them.
Otherwise, I'll have the PR spiffied up and ready to go by tomorrow.

Okay, the code is now ready for a proper review! At your leisure.


Soninke needs an eng, it’s right there in the sample text

Soninke needs an eng, it’s right there in the sample text
Yucateco needs a MODIFIER LETTER APOSTROPHE
Yapese also needs a modifier letter apostrophe
Remove apostrophe from Maithali sample

@simoncozens

Soninke needs an eng, it’s right there in the sample text
It needs Ŋ as well as all capitals are listed. It also needs ñ (used in Senegal, Gambia, Mauritania) and ɲ (used in Mali).
See #201.

Remove apostrophe from Maithali sample

https://www.unicode.org/L2/L2008/08197--bodo-dogri-maithili.pdf

Bodo, Dogri and Maithili languages are also written in Devanagari script. These
languages are using Latin Apostrophe (U+02BC) to denote special tone mark.
This tone maker is known as [...] Bikari Kaamaa (िबकारी कामा) in Maithili.

If that is not true in general practice (https://mai.wikipedia.org or https://www.ohchr.org/sites/default/files/UDHR/Documents/UDHR_Translations/mai.pdf doesn’t use it for example) and is only true in some contexts (https://udhr.audio/UDHR_Video.asp?lng=mai uses it for example), U+02BC should be moved to auxiliary.

I went with your PR instead of mine for Soninke. I think we need more clarity on what we're doing with ’.  On the one hand, it's just a punctuation mark, you don't put . in base. On the other, we have fonts which will render the sample texts with tofu because they contain all the other characters but not ’ - in which case, ’ is required for correctly displaying the language. On the gripping hand, if it's something like a glottal stop, then that's clearly a "letter".
Do we need to invent a required_punctuation category? If so, then we need to audit the existing punctuation category to see which entries are required and which are optional. 🙃

Yes, if it can be done, punctuation that is auxiliary should be moved to auxiliary.
Seeing how broken the snk_Latn (SLDR and gflanguages) or even the mg_Latn are (CLDR and SLDR, Hyperglot, gflanguages), more than punctuation should be reviewed.
For ’ U+2019, it’s difficult to be consistent as it is often used as a letter instead of ʼ U+02BC for the glottal stop. I’ve tried to only include it when it is listed as a letter in the alphabet in references.
There’s also / U+002F that is used in some languages as a letter and there’s no equivalent letter character for it, excluding the languages that use it as a fallback for ǀ U+01C0. The punctuation sign · U+00B7 also ends up in the base characters.


simplify ElementsAttrBuilder::reduce() with StridesIterator

Jenkins Linux s390x Build #10504 [push] simplify ElementsAttrBui... started at 19:29

Jenkins Linux ppc64le Build #9551 [push] simplify ElementsAttrBui... started at 19:32

Jenkins Linux amd64 Build #10493 [push] simplify ElementsAttrBui... started at 18:29

Jenkins Linux amd64 Build #10493 [push] simplify ElementsAttrBui... passed after 1 hr 21 min

Jenkins Linux s390x Build #10504 [push] simplify ElementsAttrBui... passed after 1 hr 35 min

Jenkins Linux ppc64le Build #9551 [push] simplify ElementsAttrBui... aborted after 1 hr 52 min


Speed up version map

[x] Have you followed the guidelines in our Contributing document?
[x] Have you checked to ensure there aren't other open Pull Requests for the same change?
[x] Have you added an explanation of what your changes do and why you'd like us to include them?
[ ] Have you written new tests for your changes? Here's an example.

[x] Have you successfully run brew typecheck with your changes locally?
[x] Have you successfully run brew tests with your changes locally?

Attempts to address #11281 in two ways:

Stop looking at formula revisions after viewing all revisions of a single pkg_version
Don't look at the formula at each individual commit pulled into master via a merge, only look at the formula at the point it was merged into master

This seems logically correct to me but probably need to find some formula with a convoluted history to test it on.
Here's a quick benchmark of getting the bottle_version_map (twice) for<EMAIL_ADDRESS>Rehearsal ---------------------------------------------------------------------
depth=2 first_parent=false (orig)   0.028839   0.022891   8.828547 (  8.672422)
depth=1 first_parent=false          0.001221   0.004078   5.830595 (  5.843517)
depth=1 first_parent=true           0.001118   0.003426   5.817436 (  5.834915)
depth=2 first_parent=true           0.002547   0.004504   7.563878 (  7.584342)
latest_bottle_rebuild               0.000744   0.003529   4.737067 (  4.752579)
----------------------------------------------------------- total: 32.777523sec

                                        user     system      total        real
depth=2 first_parent=false (orig)   0.002320   0.004377   7.499702 (  7.518854)
depth=1 first_parent=false          0.001254   0.003911   5.797942 (  5.808991)
depth=1 first_parent=true           0.001219   0.003896   5.851955 (  5.882971)
depth=2 first_parent=true           0.002558   0.004528   7.528107 (  7.550281)
latest_bottle_rebuild               0.000699   0.003799   4.707501 (  4.726870)

depth=1 first_parent=true is the proposed alternative for bottle_version_map. Not a groundbreaking improvement, but better. latest_bottle_rebuild is an even more aggressive version that takes a specific pkg_version and stops after it finds the first bottled revision for that pkg_version (or first encounters an earlier pkg_version).

This seems logically correct to me but probably need to find some formula with a convoluted history to test it on.

Something like wget that's been around for an age may be a good candidate 👍🏻

I added a bunch of debugging to try to figure out why some revisions weren't being looked at... and I think this may have become a LOT slower back when sha256 "digest" => :tag was deprecated. formula_at_revision sets deprecations to be raised as exceptions and therefore doesn't consider those revisions.
The original code (pre this PR) looks at 140 revisions before completing-- it only finds a single "good" pkg_version so it looks through the whole history. If you comment out the Homebrew.raises_deprecation_exceptions lines, it looks at 7 revisions. So it's possible that an alternative here could be creating a way to suppress deprecation exceptions AND deprecation warnings.
That said, it could still be worth considering one of the strategies from this PR for limiting the number of revisions considered, assuming it still gives the desired result.

#11134 should help with the deorecation stuff.

@cwegrzyn Would be interesting to see the versions and rebuilds that this looks at for wget (with some debugging output).
I'm also tempted to consider that we consider dropping this logic entirely in favour of just rebuild = old_version == new_version ? old_rebuild+1 : 0 and we see how many issues that ends up causing us.

I have a version that only considers the latest rebuild that I pushed up over at https://github.com/Homebrew/brew/pull/11293
I can get the log of revisions in both cases posted a little later today

Closed in favor of https://github.com/Homebrew/brew/pull/11293


fix image not displayed when tapped on search page

Details
Fixed Issues
$ https://github.com/Expensify/App/issues/51161
PROPOSAL: https://github.com/Expensify/App/issues/51161#issuecomment-2432845073
Tests
Same QA step

[x] Verify that no errors appear in the JS console

Offline tests
QA Steps

Go to NewDot.
Tap on any chat.
Paste ![test](https://camo.githubusercontent.com/4848d0f965f332077b77a1a0488c3e66b4769032104f4de6890bae218b4add8d/68747470733a2f2f70696373756d2e70686f746f732f69642f313036372f3230302f333030)_test in the compose box.
Send the message.
Navigate to LHN.
Tap the bottom search icon.
Select the chat from the dropdown.
Tap on the image.
Verify that the image is displayed in the attachment modal.

[x] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
https://github.com/user-attachments/assets/4c496889-aa28-455d-a2bb-2ebbabd3d47c

Android: mWeb Chrome
https://github.com/user-attachments/assets/cda70ee0-061b-4bb6-96a6-e3c6287564fe

iOS: Native
https://github.com/user-attachments/assets/27542baa-1668-481c-8834-34fa10c9de28

iOS: mWeb Safari
https://github.com/user-attachments/assets/d80034bf-a67d-4390-a06f-d3cd59762ab6

MacOS: Chrome / Safari
https://github.com/user-attachments/assets/cd3570a5-cfd3-47b0-b698-92a9ee675a35

MacOS: Desktop
https://github.com/user-attachments/assets/e445e051-ec7d-45b4-83d9-ecfa06a2e736

@sobitneupane what's that AbortError in your Chrome video?

Ok got it. Has it been reported?

@sobitneupane Could you check the question above?

@puneetlath I don't think it has been reported yet. Should I report it?

Yes please. Ping me here when you've reported it and then I'll merge.

@sobitneupane fyi 👆

Reported the bug: https://expensify.slack.com/archives/C049HHMV9SM/p1731396042629799

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

This PR is failing for iOS because of issue #52475

@IuliiaHerets https://github.com/Expensify/App/issues/52475 I believe this ticket is not related to this PR.


The execution price is far away from the OB

I should be able to set this limit order here, this new validation restricts traders.
I want to set a sell at 17$ and come back in a few days because I believe there will be a 60% change filling my order, why should the frontend restrict me? This would be a very common scenario.

Preventing users from placing orders that are 50% away from mid price if the order is about to be filled is totally understandable and desired i.e. sell INJ here at 4$ but what do we gain out of this validation here if the order doesn't cross?


Dataset Split Size

I noted that the dataset has been updated, e.g. iwildcam. Where can I find the latest information about the dataset split size?

The updates are described in the release notes: https://github.com/p-lambda/wilds/releases
and also reflected in the latest arxiv paper: https://arxiv.org/abs/2012.07421
Hope that helps!


winget upgrade list unistalled packages

Brief description of your issue
We are trying to upgrade all packages through the terminal, as we do in Linux, and it is working well.
We realized winget is listing uninstalled packages:
PS C:\Users\Luis Alaguna> winget upgrade --all
Name                                             Id                                Version    Available  Source
---------------------------------------------------------------------------------------------------------------
Microsoft Windows Desktop Runtime - 5.0.17 (x64) Microsoft.DotNet.DesktopRuntime.6 < 6.0.5    6.0.16     winget
OpenOffice 4.1.12                                Apache.OpenOffice                 4.112.9809 4.113.9810 winget
JetBrains ETW Host Service (x64)                 JetBrains.ReSharper               > 2022.2.2 2022.3.3   winget
3 upgrades available.

Every time we try to reinstall Microsoft Windows Desktop Runtime, it fails; so we installed it manually, and use winget to check updates.
OpenOffice comes by default in Windows 11, and we uninstalled it manually, but still it is listed by winget.  So we checked to uninstall it with winget  but it fails:
PS C:\Users\Luis Alaguna> winget uninstall Apache.OpenOffice
Found OpenOffice [Apache.OpenOffice]
Starting package uninstall...
Uninstall failed with exit code: 1605
PS C:\Users\Luis Alaguna> winget uninstall Apache.OpenOffice
Found OpenOffice [Apache.OpenOffice]
Starting package uninstall...
Uninstall failed with exit code: 1605
PS C:\Users\Luis Alaguna> winget uninstall Apache.OpenOffice
Found OpenOffice [Apache.OpenOffice]
Starting package uninstall...
Uninstall failed with exit code: 1605

It fails because the uninstaller cannot uninstall uninstalled software; so, why is OpenOffice being listed by winget?
For  JetBrains.ReSharper, it is not possible to update it:
PS C:\Users\Luis Alaguna> winget upgrade JetBrains.ReSharper
A newer version was found, but the install technology is different from the current version installed. Please uninstall the package and install the newer version.

Steps to reproduce

Uninstall Open Office.
Run upgrade with winget: winget upgrade --all
Check all failures.
Try to uninstall Apache: winget uninstall Apache.OpenOffice
Try to upgrade ReSharper: winget upgrade JetBrains.ReSharper

Expected behavior
It should not list uninstalled software or wrong versions.
Actual behavior
It lists uninstalled or updated packages and lists wrong versions
Environment
PS C:\Users\Luis Alaguna> winget --info
Windows Package Manager v1.4.10173
Copyright (c) Microsoft Corporation. All rights reserved.

Windows: Windows.Desktop v10.0.22000.1936
System Architecture: X64
Package: Microsoft.DesktopAppInstaller v1.19.10173.0

Logs: %LOCALAPPDATA%\Packages\Microsoft.DesktopAppInstaller_8wekyb3d8bbwe\LocalState\DiagOutputDir

User Settings: %LOCALAPPDATA%\Packages\Microsoft.DesktopAppInstaller_8wekyb3d8bbwe\LocalState\settings.json

Links
---------------------------------------------------------------------------
Privacy Statement   https://aka.ms/winget-privacy
License Agreement   https://aka.ms/winget-license
Third Party Notices https://aka.ms/winget-3rdPartyNotice
Homepage            https://aka.ms/winget
Windows Store Terms https://www.microsoft.com/en-us/storedocs/terms-of-sale

What seems to have happened here is that the Registry Entries for Open Office are still present, meaning that it wasn't uninstalled correctly. You could try checking the Add & Remove Programs menu in control panel (appwiz.cpl) to see if Open Office is listed there; If it isn't, you may need to use a program like Revo Uninstaller to remove the registry entries.
The issue around Windows Desktop Runtime is a separate issue where side-by-side applications don't behave correctly. You may be able to use winget install Microsoft.DotNet.DesktopRuntime.6 --force to force an install of the latest version, but as long as the previous version is present on the system, it will always show as available for upgrade in winget upgrade because of that older version.

The issue around Windows Desktop Runtime is a separate issue where side-by-side applications don't behave correctly. You may be able to use winget to install Microsoft.DotNet.DesktopRuntime.6 --forceto force an install of the latest version, but as long as the previous version is present on the system, it will always show as available for upgrade inwinget` upgrade because of that older version.

Why is there an old version? I installed the last version manually many times, does it not remove the old version?

Some packages support side-by-side installation. When the manifest doesn't specify a requirement to uninstall the previous version (which may be intentional), you will have both installed.
https://github.com/microsoft/winget-cli/releases/tag/v1.5.1572 includes:
Switch for --uninstallPrevious for upgrade https://github.com/microsoft/winget-cli/issues/2727

Some packages support side-by-side installation. When the manifest doesn't specify a requirement to uninstall the previous version (which may be intentional), you will have both installed.
https://github.com/microsoft/winget-cli/releases/tag/v1.5.1572 includes: Switch for --uninstallPrevious for upgrade #2727

Isn't Microsoft careful enough to avoid mistakes like this?

WinGet supports both scenarios because some publishers and some users want one or the other behavior.
For a "true" upgrade as supported by MSIX and MSI based installers, the experience is graceful. When you're dealing with .exe-based packages there are cases where you don't want the previous version uninstalled.
For example, Ultimaker.Cura releases new versions, but the settings don't get migrated. Users need to be able to move their settings over since the installer doesn't do that automatically.
Many runtimes like Python, and Java need to be able to have side-by-side versions available.


Authentication fails when username and password contain hyphens

Hi.  I'm trying to use Prisma in a situation where a AWS RDS MySQL username and password both contain hyphens.  I've found Prisma always fails to connect when the username and password contain hyphens.  It fails with this exception:

the provided database credentials for (not available) are not valid

The (not available) bit is actually what is included in the error message - it is not me obscuring part of the error message.  That (not available) in the error message seems to be caused by the username containing hyphens

If you only change the password to not contain hyphen, Does the same error occur?
If you only change the user to not contain hyphen, while keeping the same password containing a hyphen. Does the same error occur?
Internal note: besides understanding if we are tampering with the username; or MySQL is rejecting it, and we can do something about it. Maybe the error can be made more obvious?

Can you share an anonymized version of the credentials you are using @simondean? Just replace all the characters with other ones or something, I would love to see the "structure" of what you are using there that causes this error. Maybe that would already be enough for us to reproduce as well.

Hello again,
Without further info, we'll need to close this issue. If you are still experiencing this issue, please leave a comment or open a new issue. Thank you!

Hi @Weakky, @jharrell.  Sorry I've not replied sooner.  The component I was writing when I hit the issue, I had to switch to mysql2 package due to time frames for implementing it, so I've not got an immediate need for the fix.

If you only change the password to not contain hyphen, Does the same error occur?
If you only change the user to not contain hyphen, while keeping the same password containing a hyphen. Does the same error occur?

I'm not sure sorry.  I wasn't in control of the user name or password, so I wasn't able to change either to see if the root cause was with user names or passwords
I think the issue I saw was prisma was escaping the hyphens in the user name and/or password (not sure which) - could have been percent encoding but not sure - when the escaping was not needed.  The escaping was actually breaking things

In case it helps, I was using Prisma with AWS RDS MySQL.


Release version 0.1 of the Plugin

Release the first version of the plugin.
It includes tagging the code on the master branch, adding a release inside github and adding the plugin to vim.org
This version will be very simple, but it is a start and it should be usable (even if not very good).

Done.


Add files via upload

Added EBeam_heaters_LeelaQv3.gds, EBeam_heaters_LeelaQv4.gds, EBeam_heaters_LeelaQv5.gds. The DRC check gives an error because the metal routing goes over the waveguides, but I think this is ok? (I believe this was answered somewhere on EdX but just wanted to double check.)
Also for EBeam_heaters_LeelaQv5.gds, are my pad labels ok corresponding to the optical input label? The idea is that there is only one optical input which affects both rings, and both rings have voltage applied to them simultaneously. Thanks!

Sorry I was editing the comment with another question while this got merged. For EBeam_heaters_LeelaQv5.gds, are my pad labels ok corresponding to the optical input label? The idea is that there is only one optical input which affects both rings, and both rings have voltage applied to them simultaneously. Thanks!


Change of database in DAT

Just had a call with Alexander Praetorius, who gave me a lot of good tips for libraries we can use instead of pouchDB and adapters to use for DAT.
Just leaving them here, so we can discuss about them, also related to the sharing network:
https://github.com/beakerbrowser/hashbase (https://hashbase.io/)
https://github.com/mafintosh/hypercore
https://github.com/mafintosh/hypervision
https://github.com/mafintosh/hyperdb (alternatively: https://github.com/beakerbrowser/injestdb)
https://github.com/levelgraph/levelgraph as a graph database (alternatively gun.js.org, however the latter is a separate application which does not integrate so)
hyperdb, injestdb,levelgraph, hypercore and hashbase modularly integrate/build on top of each other very well with leveldb, so we can use it in the browser's native database + on the server as well.

This will be dealt with at a later stage.


Shdr: can not convert from 'const mediump float' to 'FragColor mediump 4-component vector of float'

This issue I have shows up all the time on code that should be able to compile correctly. I don't know why every time when i try to pass a vec4 function to the gl_FragColor I get this. Is the gl_FragColor not supposed to be a vec4? From my understanding it was. It is a rather annoying problem. I love the UI and everything. The models look fantastic but I need to be able to pass vec4's to the fragment as it is just common shader sense. It also happens with "vec2 uv = gl_TexCoord[0].st". can not convert from 'float' to '2-component vector of float'

The following shader produces a similar error (and compiles/works properly on a desktop); vertex shader


[PE-D] Edit command can add non unique names

manage to edit name to 'another' as compared to 'Another' 2nd movie, not fully unique and case insensitive

Labels: severity.High type.FunctionalityBug
original: yongler/ped#3

I think we forgot to consider case-sensitivity when checking for unique names.


Firefox popping noises

I have found the following bug which happens in Firefox 68.0.2, it doesn't occur on chrome.
If you instantiate a Tone.Synth with envelope:{release: 0.07} and try multiple times to triggerAttackRelease with multiple notes, randomly there will appear popping noises at the start of the note. It happens randomly and I haven't been able to get the pop to appear consistently, but it appears pretty often with the options given.

Thanks for the issue, given the inconsistency in reproducibility, my guess is it is performance issues with firefox's web audio implementation which i've found tends to be slightly more sluggish than chrome causing it to crackle sooner.
Unfortunately, if it is performance issues of its web audio implementation, there is nothing that Tone.js can do, other than the incremental optimizations which are added whenever they are found. I could not reproduce a Tone.js issue related to that release time in my testing (seemed to work the same with any release value that i used). Sorry i couldn't be more helpful. If you have a specific performance issue which might be web audio-related and firefox specific, it can be helpful to file it with bugzilla.


openhcl: log how large the saved state buffer is for servicing

We know how large it is, but log it so it's discoverable.
In the future, we are probably moving to a model where we do not send the saved state to the host. This will help us decide how large to size a reserved memory range inside OpenHCL.

Worth taking to 2411 to get numbers from prod?


Assigning Pods to Nodes

in part of node-affinity, the example yaml file specific following condition:
  requiredDuringSchedulingIgnoredDuringExecution:
    nodeSelectorTerms:
    - matchExpressions:
      - key: kubernetes.io/os
        operator: In
        values:
        - linux

BUT, in part of describe area, it seems unmatched:
The node must have a label with the key topology.kubernetes.io/zone and the value of that label must be either antarctica-east1 or antarctica-west1.
does the nodeAffinity part means pod must be scheduled to node with label (kubernetes.io/os=linux) ?
It seems to have nothing to do with key topology.kubernetes.io/zone. Maybe I misunderstood this part.

This issue is a duplicate of #34573

/triage duplicate
It seems that this is already resolved by the PR #34785.
It is likely that you are viewing somehow old version of this page, or certain localized page which is probably outdated.
Page: https://kubernetes.io/docs/concepts/scheduling-eviction/assign-pod-node/#node-affinity
[As-is]


Bug fix lc 14 empty org error v3

Fix for response already committed error which causes the UI to fail.

Merging


Next button / pages not showing on logs/request-viewer/

The next button as it is shown in the readme screenshot doesn't appear in the dashboard.
Though adding ?page=X param works.

I've looked in the dashboard template.
It seems like the fragment for the pagination is empty on my end.
So maybe the queryset parameter is missing from the template context.
Maybe this is connected to my django version, I might look into this further quite busy atm though.
But nice django app! :)


[WIP][Ignore] trigger CI

Fixes #

Proposed Changes

Release Note

Docs

Passed 3 times in a row, check https://github.com/knative-sandbox/eventing-kafka/pull/926


Inconsistencies in the docs vs the demo project

I think that it has some inconsistencies in the docs vs the demo project.
In the demo project:
# Add the key for the match certificate repository to ssh
# See https://docs.semaphoreci.com/article/109-using-private-dependencies
- chmod 0600 ~/.ssh/*
- ssh-add ~/.ssh/match-repository-private-key

In the documentation when looking for help: https://docs.semaphoreci.com/article/109-using-private-dependencies
- chmod 0600 ~/.keys/*
# Add the key to the ssh agent:
- ssh-add ~/.keys/*

It can be confused for beginners if they create their secrets with sem create secret private-repo --file id_rsa_semaphoreci:/home/semaphore/.keys/private-repo than try to follow with the demo project configuration.

In general links to docs in YML are meant to be read for additional information on how something works on Semaphore.
I think it's strange that the docs article is referring to ~/.keys directory when on both Linux and Mac you typically use ~/.ssh. I propose changing the docs page to have ~/.ssh, what do you think?

I agree with you @markoa. ~/.ssh it's probably more familiar for beginner developers.

Updated the docs page.


Replace unregisterAllRuntimeModels with undefineAllRepresentations

This issue is being closed since the DataBinder class has been refactored and is no longer marked for deprecation.


Add user_error functionality so a user may create a custom jsonapi compliant error response.

This PR creates a function user_error that returns a custom error response that is jsonapi compliant.
Users can use this to create custom errors relating to

status_code
title
detail
pointer
Please note status_code, title, detail, and pointer are all required.

👍


fix copyable command

This doesn't seem to affect anything... Can you describe what problem this fixes? Or is this just a formatting change? I agree it does look cleaner.

This doesn't seem to affect anything... Can you describe what problem this fixes? Or is this just a formatting change? I agree it does look cleaner.

The command needs the space between the x and localhost to properly run.

Apparently this affects:
macOS catalina 10.15.7 - zsh shell
Merging.


ARTEMIS-1656 OpenWire scalability improvements

The improvements included are:

exclusive OpenWireFormat instances for input/output message paths
direct ByteBuf pooling for messages sent across connection
groupId pooling
stateless OpenWire converter

Do not merge it yet: need to run the OpenWire compatibility tests

It is broking some test.. I will close it for now :+1:


Simplify nano::invoke

Now that we're using C++17, we can simplify our implementation of std::invoke by using if constexpr.

Apparently libc++ 5.0 doesn't have std::invoke_result or std::is_nothrow_invocable, and the former is broken in libc++ 6.0. So... never mind.


HAL Module Request: hal_hisilicon

Origin
https://github.com/xingrz/hal_hisilicon
Purpose
This repository provides source of components support for the HiSilicon Hi3861 SoC.
Mode of integration
Please integrate this project as a module according to the generic Zephyr HAL modules structure.
Maintainership

@xingrz

Pull Request
#57363
Description
I am uncertain whether this repository should be considered a "HAL module." It contains sources for two components:

loaderboot - The source of a bootable image that was imported from the original SDK. This component is required by the hiburn runner that I have implemented in the PR above. To flash the board, this image will be sent to and run on the RAM of the SoC. It will receive data sent from the hiburn on the host side and write it onto the flash.
flashboot - This is a few lines of bare metal code that I wrote. The fixed romcode of the Hi3861 always expects the entry to be located in RAM instead of Flash. The only purpose of this image is to bridge this gap by jumping to the Zephyr kernel on the Flash.

Although the manufacturer of this SoC offers an official LiteOS SDK, I did not use it in its entirety. Instead, I selectively chose the loaderboot from it.
Furthermore, all the drivers have been implemented in accordance with the user manual from HiSilicon, so no headers from the original SDK were imported into this repository.
Although the wireless feature has not been implemented yet, since Hi3861 is a WiFi SoC, this repository will also be used to specify RF blobs to be fetched in the future.
Dependencies
None.
Revision
https://github.com/xingrz/hal_hisilicon/tree/ffe31f98d315a2ae3d52724c0c1d709df59eb284
License
Apache-2.0

License
Apache-2.0

This is not correct. At least some of the files (i.e. hi3861/boot/flashboot/riscv_init.S are under 3-clause BSD.

License
Apache-2.0

This is not correct. At least some of the files (i.e. hi3861/boot/flashboot/riscv_init.S are under 3-clause BSD.

You're right. But the original LiteOS SDK says it was released under Apache-2.0 License.
https://gitee.com/openharmony/device_soc_hisilicon/tree/master/hi3861v100/sdk_liteos/license

License
Apache-2.0

This is not correct. At least some of the files (i.e. hi3861/boot/flashboot/riscv_init.S are under 3-clause BSD.

You're right. But the original LiteOS SDK says it was released under Apache-2.0 License.
https://gitee.com/openharmony/device_soc_hisilicon/tree/master/hi3861v100/sdk_liteos/license

Oh, I see what the issue is now. The manufacturer has released their code from multiple sources. Initially, they provided zip files on their website, but now they release the code on Gitee, where all sources have been re-licensed with Apache 2.0. I will update my repository with the latest sources.

License
Apache-2.0

This is not correct. At least some of the files (i.e. hi3861/boot/flashboot/riscv_init.S are under 3-clause BSD.

I just updated and switched to the OpenHarmony branch. Now the code is definitely licensed under Apache 2.0.

Can you contribute the flashboot directly into the Zephyr tree?  This code is your own, correct?
The loaderboot code probably makes sense as a module, but it's definitely not a HAL.

Can you contribute the flashboot directly into the Zephyr tree? This code is your own, correct?

Yes, but I'm not sure which directory I should place it in.

Yes, but I'm not sure which directory I should place it in.

Perhaps a subdirectory to the soc directory?

@xingrz - Can you drop the "hal" from the proposed module name?  How about hisilicon_loaderboot or just hisilicon?

@xingrz - Can you drop the "hal" from the proposed module name? How about hisilicon_loaderboot or just hisilicon?

Sure. However, without the "hal" prefix, is it appropriate to use this repository to declare the west blobs required for WiFi in the future?

@xingrz - Can you drop the "hal" from the proposed module name? How about hisilicon_loaderboot or just hisilicon?

Sure. However, without the "hal" prefix, is it appropriate to use this repository to declare the west blobs required for WiFi in the future?

Note that blobs are not permitted to be hosted in the Zephyr main tree or modules. See details here.  However the module can be used to reference the blob hosted somewhere else.
Please use  hisilicon as the module name.  This allows flexibility to add additional code from HiSilicon in the future.
Once this issue gets updated, I'll add the TSC label so that this issue gets voted on by the TSC.  Assuming it's approved, then maintainers will create the zephyrproject-rtos/hisilcon.

Note that blobs are not permitted to be hosted in the Zephyr main tree or modules. See details here. However the module can be used to reference the blob hosted somewhere else.

Yes, I'm aware of that.
I've updated the title and the description of this issue.

The TSC noticed that there are some pre-built libraries/object files in the proposed module.
https://github.com/xingrz/zephyr_module_hisilicon/tree/master/hi3861/loaderboot/libs
If these libraries are not needed, please delete from the module.  If the libraries are required, you'll need to follow the process for adding binary blobs.

If these libraries are not needed, please delete from the module. If the libraries are required, you'll need to follow the process for adding binary blobs.

I understand the concern. These libs are indeed necessary. However, it's important to note that these libs will not be compiled into the Zephyr binary. The loaderboot.bin itself is similar to FLM files used during JLink flash.
While it is possible to reimplement a pure open-source alternative, it would require a significant amount of time.
Instead, would it be feasible if I provide the loaderboot.bin separately in another location, such as my own GitHub repo, telling the developers that they need to obtain this additional bin file for flashing in the README for the board?

is there any progress on this discussion?

Marking as rejected by the TSC due to the binaries in the module.


workflows: add Linux build

This adds Linux coverage to the CI to prevent accidental breakage.  The previous
changes to support Windows seems to have accidentally regressed Linux builds.
Add coverage to prevent that in the future.

#281 will also fix the Linux build.

Yes, the change was in #281 for _GNU_SOURCE to be defined earlier.
I can certainly rename the file and job.  I tend to find build to be descriptive as it is the build test (where you may have other jobs for linting or documentation generation).  I think with quoting I can change it to "build and test", any suggestions for the file?

Cool! Sounds good, so let's just go with "build" then :)