Peer Review  Summary Milestone #2

Peer Review Summary:

Napkin and Architecture Diagram helps to get a clear idea of what the application is about.
Easily able to login into Jenkins and Consul.
To test the entire CI/CD, a different pipeline could have been made which triggers building and deployment for all the microservices.
Wiki should contain the use cases for the application. For example, what should a user expect when he is unable to locate a car, or the application is not able to detect user’s location.
Email Microservice return nothing when pinged directly on http://<IP_ADDRESS>:3000/ via browser.
Login/Sign up should be before I am able to see any rides.
UI and Functionality
a.	No option to login or register. It directly shows me all the available rides
b.	A new page open when clicked on “Request Rides” but with no data/information.
c.	A google map could be displayed on the “Available Rides” page below the list of rides which shows driver’s ETA and route map and other things like Lyft or Uber application when booking a ride.
d.	Once I login, the UI should show somewhere that I logged in. User details page is blank. No back button on “details” page. At least user should be able to save card details in order to pay for booked ride.
e.	No action on clicking “BOOK” button on any ride.
f.	After sign up, I should be redirected to sign in page and after sign in, I should be directed to the page where I am booking the ride I selected previously.
g.	While adding ride, not able to enter date in MM/DD/YYYY format. Either a date picker could be provided, or it should throw error if I am not entering date in correct format. Another option would be to show date format below Date column after user clicks on the date row.
h.	Dollar symbol should be appended before amount. Just as a feature improvement, currency should be automatically selected based on start and end destination country.
i.	The about page for the application is blank.
j.	No error or message provided if password or username is wrong.
k.	Overall the UI could much more interactive and user friendly.

Thanks Pulkit.
All the UI changes suggested have been implemented other than google map integration.
This is not a cab application.
This is actually a car pool  application so there is no live tracking like in a case of taxi


Possibility to defer validation until blur?

Thx. for the great lib.
Would you consider (or is it already possible) to configure vee-validate in such a way that the validation will be performed on-blur instead of immediately (or after delay) ??. IMHO the user should not get any validation-errors until he actually leaves a field.
Best, Carsten

See the API docs.

If you are binding your inputs with your models via v-model you can use the v-model.lazy modifier which should trigger the validation less frequently.
In general the only way to do it is to specify data-vv-validate-on on each input, which is very verbose, I will try to add a global config to set the behavior without much hassle.
custom input components will be excluded from this behavior tho.

I see that this is sitll not implemented, or at least I did not find how to achieve it.
I tried with data-vv-validate-on="blur" but this disables the ability to validate when the input becomes valid (for example, when typing email).
So the best result would be, as with angular, if the field has not been touched, show error only when the user blurs it. If it has been touched validate always at every event.

I even prever to use the dirty flag, since I find it pretty annoying that when the user only just tabs through the fields it gets the validation messages already.
So I now mostly use the following:
v-show="fields.email && fields.email.dirty && errors.has('email')"
(where email is depending on your field ^^ )
or (if you have a generic InputField component:
v-show="fields[name] && fields[name].dirty && errors.has(name)"
Link to all the flags documentation

When input and it's error message are made in one component (as it should be imho) it's easy to watch focus/blur events.
Take a look on fast made example on codesandbox.

this.errors.has('email') &&        ((this.fields.email.untouched && !this.fields.email.dirty && this.fields.email.validated) ||         (this.fields.email.touched && (this.fields.email.dirty || this.fields.email.validated)));
This condition work for me well

Why not like this? It will throw the error only if v-model value is entered and there is no focus on the field.
Not a native vee-validate approach but I believe it works pretty well...
<template>
<ValidationProvider
:rules="required"
v-slot="{ errors, valid, invalid, pristine }">

    <input
    @focus='focus = true'
    @focusout='focus = false'
    v-model="value"
    type="text" />
    <small
    v-if='errors[0] && value != "" && !focus'
    :class="errorClasses">{{ errors[0] }}</small>

</ValidationProvider>
</template>
<script>
export default {
  name: "form-input",
  data: () => ({
    focus: false,
    value: ""
  })
}
</script>


How to get the cache name in CacheEventListener?

In practice, you need to add different listeners according to the different names of the configured cache.
But the CacheEventListener interface does not get the cache name, unfortunately did not find other ways!!!
Through CacheRuntimeConfiguration only registerCacheEventListener and deregisterCacheEventListener methods, there is no method to query the existing listener, resulting in frequent and repeated registration exceptions.
Please give a solution!!!🙏

The issue tracker isn't for support questions but for the filing of bugs. The documentation for cache event listeners can be found here: https://www.ehcache.org/documentation/3.8/cache-event-listeners.html
I would suggest that if you find yourself needing to know the alias for a cache in a listener (caches don't have names) then you're probably doing something wrong. Instead just have distinct listener instances for each cache.
As for registration exceptions: those should only happen if you are trying to register the same listener twice (as judged by Object.equals(...)).

The issue tracker isn't for support questions but for the filing of bugs. The documentation for cache event listeners can be found here: https://www.ehcache.org/documentation/3.8/cache-event-listeners.html
I would suggest that if you find yourself needing to know the alias for a cache in a listener (caches don't have names) then you're probably doing something wrong. Instead just have distinct listener instances for each cache.
As for registration exceptions: those should only happen if you are trying to register the same listener twice (as judged by Object.equals(...)).


VS Addition v0.0.{9,10} create big cannons API does not work on Fabric, works on Forge

Mod Name
create big cannons
This issue occurs when only Valkyrien Skies, addons, and the mod I have specified are installed and no other mods

[ ] I have tested this issue and it occurs with only Valkyrien Skies, addons, and the mod I have specified

Minecraft Version
1.20.1
Mod Loader
Fabric
Issue description
Placing a "CC: Tweaked" advanced computer directly in front of a properly build cannon mount (holding an auto-turret) produces different results for the peripherals command, and different available APIs between forge and fabric.
I have attempted to get the exact same versions of various mods on both Fabric and Forge, but some other mods have slightly older versions for Fabric.  Details below.  However, after digging through the code, I suspect that the issue is in the "VS Addition" mod.  I will include screen shots if github will let me.
Basically, the full API, es expressed in [1] works in Forge, but not in Fabric.
[1] https://github.com/xiewuzhiying/VS-Addition/blob/1.20.1/main/common/src/main/kotlin/io/github/xiewuzhiying/vs_addition/compats/computercraft/peripheral/CannonMountMethods.kt

Mod
Fabric
Forge

CC: Tweaked
1.114.2
1.114.2

CC: C Bridge
1.6.2b-fabric
1.6.3

CC: VS
0.1.1
0.1.1

Clockwork
0.1.16
0.1.16

Create Big Cannons
5.5.1
5.6.0

Valkyrien Skies
2.3.0-beta5
2.3.0-beta5

VS Addition
0.0.10
0.0.9

Results of running peripherals on Forge (desired):

Peripheral Name: createbigcannons:cannon_mount.
Peripheral Type: cbc_cannon_mount (has desired API).

Results of running peripherals on Fabric (undesired):
(NOTE: You must run redstone set back true first to assemble the cannon on Fabric).

Peripheral Name: createbigcannons:cannon_mount.
Peripheral Type: item_storage (only has inventory API).

Forge (works):

Fabric (desired API missing):

Issue reproduction

For each mod launcher, build a minimal Create Big Cannon (I used auto-turret).

Run the peripherals command.
Observer that the two mod loaders offer different CBC APIs.  The "VS Addition" CBC API appears to be missing on Fabric.

Logs
No response

This is similar to the issue super95shao mentioned to me previously, I'll look into it.


Add the normal clang build and replace some builders with it.

Since there are only few developers working on actually fixing UBSan issues, I'm fine with having less UBSan buildbot workers, as soon as we still have at least one UBSan worker. It's the case with this PR:
        ("AMD64 Clang UBSan", "gps-clang-ubsan", ClangUbsanLinuxBuild, UNSTABLE),

UBSan builds produce tons of warnings which make it harder to identify regular clang compiler warnings.

PR merged, new config deployed. Thanks @stratakis.


how to synthesize without browser interface?

#synth.py
from synthesizer import Synthesizer

a=Synthesizer()
a.load('tacotron-20180906\model.ckpt')

text='Scientists at the CERN laboratory say they have discovered a new particle.'

with open('out.wav','wb') as f:
	f.write(a.synthesize(text))


Jquery File Upload display few rows is missing while uploading multiple files.

I have set the option for the file upload to multiple(singleFileUploads: false) After selecting multiple(6 files) rows in the container to upload the files, facing issue in the display of the download template of file list in the row .
While retrieving the response from the server, if the server is slow the files are updated correctly in the download template.
The issue is while the server is normal or faster, and uploading multiple files some of the files in the row is not changing to the template download state, its showing the upload template which is hidden for few of the files in the row.
Main Issue: few rows are hidden in the display container while the server is normal or fast on uploading files if the condition is limitMultiFileUploads:3 and singleFileUploads: false,
Example: if i upload 5 files only 3 rows are visible the other two rows not changing to the completed state.
Can you please help on this to rectify the issue as  soon as possible.
Please let me know if you need any other clarifications.

I have added blueimp jquery file upload with progress but after clickeing upload it sent a message file upload fail where I am wrong why it's not working?

Please don't misuse the pull request feature.
For support, please see https://github.com/blueimp/jQuery-File-Upload#support


Esp32 resets wen data is sennding

The log of the file is given below, the reset happens frequently . I have cross checked the user name, passwords host served details :
'''
Send TYPE
Type I
Send PASV
Data port: 65218
Data connection established
Send STOR
File Size:414761Writing
Guru Meditation Error: Core  0 panic'ed (LoadProhibited). Exception was unhandled.

 CRC=0x7bd5c66f instead of 0x0
Rebooting...
ÓRöîfgRâ
'''

LoadProhibited indicates you tried to load a variable form an illegal address. Please read the ESP32 documentation
You will find that "EXCVADDR register in the register dump. If this address is zero, it usually means that the application has attempted to dereference a NULL pointer."
This is not a library issue, thus closing it.


Warn users when hotlinking icons instead of uploading

Since these images could be deleted at any moment, or modified, and we're only embedding them, we should let users know this. We should also maybe prompt them (automatedly, through JavaScript?) to upload them to the site.
Possibly related to / combined with #787.

Possibly relevant on the TinyMCE editor? Mostly relevant on the gallery#new page, we should clarify to users that we don't rehost the links they post in (and maybe make it so we can do that).


Mirror: Update DB on Address-Update too

fix #12962

Codecov Report

Merging #12964 into master will increase coverage by 0.00%.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##           master   #12964   +/-   ##
=======================================
  Coverage   42.65%   42.66%
=======================================
  Files         669      669
  Lines       73493    73494    +1
=======================================
+ Hits        31351    31354    +3
+ Misses      37058    37057    -1
+ Partials     5084     5083    -1

Impacted Files
Coverage Δ

services/mirror/mirror.go
18.51% <0.00%> (-0.07%)
:arrow_down:

modules/git/repo_language_stats.go
52.83% <0.00%> (-3.78%)
:arrow_down:

modules/log/event.go
56.60% <0.00%> (-2.84%)
:arrow_down:

services/pull/pull.go
40.78% <0.00%> (ø)

modules/indexer/stats/db.go
60.86% <0.00%> (ø)

models/error.go
34.85% <0.00%> (+0.50%)
:arrow_up:

modules/queue/workerpool.go
60.00% <0.00%> (+1.22%)
:arrow_up:

modules/queue/unique_queue_disk_channel.go
55.38% <0.00%> (+1.53%)
:arrow_up:

modules/util/timer.go
85.71% <0.00%> (+42.85%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 14e7186...3b0ee1a. Read the comment docs.

this may need a backport :D

🚀

backport -> #12967


Merge for v5.3.1

a minor bugfix release
🔨 fixes

fix parsing n=None as shape-argument in the companion-widget
allow using the companion-widget when matplotlib is using "QtAgg" as backend

Codecov Report

Merging #127 (f99840c) into master (743dcb7) will increase coverage by 2.64%.
The diff coverage is 67.77%.

@@            Coverage Diff             @@
##           master     #127      +/-   ##
==========================================
+ Coverage   71.99%   74.63%   +2.64%
==========================================
  Files          13       18       +5
  Lines        6331     7341    +1010
==========================================
+ Hits         4558     5479     +921
- Misses       1773     1862      +89

Impacted Files
Coverage Δ

eomaps/eomaps.py
72.73% <ø> (+3.70%)
:arrow_up:

eomaps/_containers.py
74.59% <17.39%> (+3.23%)
:arrow_up:

eomaps/draw.py
18.70% <18.70%> (ø)

eomaps/utilities.py
58.77% <48.00%> (-0.47%)
:arrow_down:

eomaps/scalebar.py
80.84% <52.08%> (-2.49%)
:arrow_down:

eomaps/_webmap_containers.py
54.18% <54.18%> (ø)

eomaps/reader.py
76.21% <62.50%> (+60.79%)
:arrow_up:

eomaps/_webmap.py
82.76% <71.42%> (+2.45%)
:arrow_up:

eomaps/colorbar.py
76.09% <76.09%> (ø)

eomaps/helpers.py
78.30% <77.94%> (+4.47%)
:arrow_up:

... and 17 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


Fix compilation error that occurs with the latest version of near-sdk

This error occurs when running cargo test with the master branch from near-sdk.
Error displayed is:
error[E0277]: can't compare `AccountId` with `std::string::String`
   --> sputnikdao-factory2/src/lib.rs:149:9
    |
149 | /         assert_eq!(
150 | |             factory.get_daos(0, 100),
151 | |             vec![format!("test.{}", accounts(0))]
152 | |         );
    | |__________^ no implementation for `AccountId == std::string::String`

I'm not sure I follow. I pulled the main branch from this repo, went into sputnikdao2 and sputnikdao-factory2 and was able to run ./build.sh and cargo test -- --nocapture successfully without seeing an error.
I'm also not sure what you mean relating to near-sdk here? Did you modify a manifest file (Cargo.toml) to see this change? I don't see changes to that file in this PR.

You need the latest near-sdk to see the error. Just change all occurrences of "4.0.0-pre.4" to { git = "https://github.com/near/near-sdk-rs" }in all theCargo.toml` files and you'll see the error.


NIFI-8121 Updated ListenHTTP with inferred Client Authentication Policy

Description of PR
NIFI-8121 Updates ListenHTTP with an additional configuration option for the Client Authentication property to support automatic configuration of requiring or requesting client certificates based on the presence or absence of Trust Store properties in the configured SSLContextService.
NiFi versions 1.12.1 and prior do not have the Client Authentication property and instead called SslContextFactory.setNeedClientAuth(true) when the configured SSLContextService included Trust Store properties.  The introduction of the Client Authentication property in PR #4687 for NIFI-1930 removed this implicit behavior and did not provide backward compatibility for configurations where ListenHTTP was configured for one-way TLS.  The changes included in this PR include a custom ClientAuthentication enum with a value of AUTO that ListenHTTP uses as the default property value.  This approach will maintain backward compatibility during an upgrade and also allow explicit configuration going forward.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:

[X] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?

[X] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

[X] Has your PR been rebased against the latest commit within the target branch (typically main)?

[X] Is your initial contribution a single, squashed commit? Additional commits in response to PR reviewer feedback should be made on this branch and pushed to allow change tracking. Do not squash or use --force when pushing to allow for clean monitoring of changes.

For code changes:

[X] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
[X] Have you written or updated unit tests to verify your changes?
[X] Have you verified that the full build is successful on JDK 8?
[ ] Have you verified that the full build is successful on JDK 11?
[ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
[ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
[ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
[X] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?

For documentation related changes:

[X] Have you ensured that format looks appropriate for the output in which it is rendered?

Note:
Please ensure that once the PR is submitted, you check GitHub Actions CI for build issues and submit an update to your PR as soon as possible.

Thanks for the review and testing @turcsanyip!

Thanks for the review and testing @turcsanyip!


Don't create default zabbix database

Don't create a zabbix database when user does not specify any databases.

It's been removed from the defaults


Fixes #1018

removed comment which does not apply any more
put the final if(RDK_BUILD_PYTHON_WRAPPERS) clause outside the initial
if(RDK_BUILD_INCHI_SUPPORT) clause, as otherwise the if(RDK_BUILD_INCHI_SUPPORT)
which is inside the if(RDK_BUILD_PYTHON_WRAPPERS) clause would always evaluate to
true and noinchi.py wouldn't get a chance to be copied. This simply restores the behaviour
before commit 5d3bb1148848169aa6df342aaac1f1d97a0c3496

so much for my fix being simple.
thanks for fixing the fix. :-)


Open source programs updated

This PR closes #377 issue
Changes ->
Anchor tags and images are added and modified in Readme.md and assets/../images
Screenshots ->

@smaranjitghose
This PR is under DWOC program

Please add DWOC label before merging the PR @smaranjitghose

Please add DWOC label before merging the PR @smaranjitghose

isn't this done already

isn't this done already


How To Introduce Redaction?

Please provide us with the following information:

This issue is for a: (mark with an x)
- [ ] bug report -> please search issues before submitting
- [X] feature request
- [ ] documentation issue or request
- [ ] regression (a behavior that used to work and stopped in a new release)

Minimal steps to reproduce

Any log messages given by the failure

Expected/desired behavior

Is there a suggested approach to introduce redaction into the application without effecting the various components (indexing, etc.)?

OS and Version?

Windows 7, 8 or 10. Linux (which distribution). macOS (Yosemite? El Capitan? Sierra?)

azd version?

run azd version and copy paste here.

Versions

Mention any other details that might be useful

Thanks! We'll be in touch soon.

More specifically, could the PII detection skill be used within this application to redact the documents?

This seems like a valid feature request. Leaving it open for others to comment. I don't know of anyone working on it at the moment.


Add some new types to the API to help clarify

People have a really hard time figuring this out, and I understand why, it didn't click for me either for a while, mainly due to the way \recv -> works. I talked a bit to Christoph about it, and in that conversation it occurred to me we can probably help a great deal just by throwing some types in the mix to hide some of the "low-level complexity" that the existing types expose.
Also nobody knows what the Left and Right mean for the emit, even though it does say in the comment, so similar to the Step we have in MonadRec I guess an either-iso is fine to use here to help too.
This is just an idea, I'm not precious about the names I've used here or anything, just thought I'd throw it out there to see what the reception would be. If we want to do this I'll add comments to the new stuff too.
/cc @paf31 @natefaubion @kRITZCREEK

👍 I'd probably rename Emission to Step or something, with the constructor renamed to Emit, but I like it!

That alternative type & constructor name sound good to me. 👍 Although it will mean that it ends up as emit emitter $ Emit a :smile:
May as well hold off on actually merging this until we IOify etc. since that'll help with the point about rows anyway. Unless anyone really wants to get their hands on it now!

How about Finish instead of Result? I think another important bit will be to just have an example of a setInterval emitter that fires every second or so.

How about these names and things? I figured providing emit/close functions for Emitter rather than having emit emitter $ Emit "foo" / emit emitter $ Finish "foo" kinda thing seemed nice.


wl-mirror: 0.14.2 -> 0.15.0

Description of changes
This PR updates wl-mirror to release 0.15.0; notable new features are the --fullscreen and --fullscreen-output options.
Things done

Built on platform(s)

[X] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[X] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[X] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[X] Fits CONTRIBUTING.md.

@Synthetica9 @twitchyliquid64

Add a :+1: reaction to pull requests you find important.

Result of nixpkgs-review pr 277710 run on x86_64-linux 1

1 package built:

wl-mirror

Could you please update this?
- description = "Mirrors an output onto a Wayland surface.";
+ description = "Mirrors an output onto a Wayland surface";

Perhaps even matching the upstream description:

A simple Wayland output mirror client

Following: https://nixos.org/manual/nixpkgs/stable/#var-meta-description

updated

now matches upstream description

now split into two commits, looks cleaner IMO


[timm] crossvit_9_240 fails accuracy

crossvit_9_240 fails accuracy in all modes and data types.

I ran this test with TIMM_FUSED_ATTN=0 due to the previously found problem in TIMM benchmarks. With this option CPU results match in eager inductor modes. XPU results differ but XPU inductor results match CPU results, so I assume the problem is in XPU eager mode. Used reproducer:
import copy
import torch
import intel_extension_for_pytorch
import timm
from timm.models import create_model

from torch._dynamo.utils import clone_inputs
from torch._dynamo.testing import same, reset_rng_state

model_name = "crossvit_9_240"

def make_model():
    reset_rng_state()
    return create_model(model_name, in_chans=3, scriptable=False, num_classes=None, drop_rate=0.0,
            drop_path_rate=None,
            drop_block_rate=None,
            pretrained=False)

def make_input(device):
    input_size=(3, 240, 240)
    batch_size = 8

    # generate input data
    torch.manual_seed(1337)
    input_tensor = torch.randint(
        256, size=(batch_size,) + input_size, device='cpu'
    ).to(dtype=torch.float32).to(device)
    mean = torch.mean(input_tensor)
    std_dev = torch.std(input_tensor)
    res = (input_tensor - mean) / std_dev
    return [res]

def run_model(model, device, inputs):
    model_copy = copy.deepcopy(model).to(device)
    model.eval()
    input_copy = clone_inputs(inputs)
    with torch.no_grad():
        return model_copy(*input_copy)

def check_model(model, device):
    input = make_input(device)

    reset_rng_state()

    res1 = run_model(model, device, input)

    torch._dynamo.reset()
    reset_rng_state()

    optimize_ctx = torch._dynamo.optimize('inductor', nopython=False)
    model_fn = optimize_ctx(run_model)
    res2 = model_fn(model, device, input)

    print(f"{device} results match: {same(res1, res2)}")

    return res1, res2

model = make_model()

cpu1, cpu2 = check_model(model, 'cpu')
xpu1, xpu2 = check_model(model, 'xpu')

print(f"Eager results match: {same(cpu1, xpu1.to('cpu'))}")
print(f"Inductor results match: {same(cpu2, xpu2.to('cpu'))}")

I could reduce the model to a single interpolation layer with the same situation but other problems might also exist. Note that batch size >1 is required to reproduce the problem because the first result in a batch is correct. Small reproducer:
import torch
import intel_extension_for_pytorch

class Test(torch.nn.Module):
    def __init__(self):
        super().__init__()

    def forward(self, x):
        x = torch.nn.functional.interpolate(x, size=(224, 224), mode='bicubic', align_corners=False)
        return x

def make_input(device):
    torch.manual_seed(1337)
    return torch.randn((2, 3, 240, 240), dtype=torch.float32, device='cpu').to(device)

def check_model(device):
    model = Test().to(device)
    input = make_input(device)

    res1 = model(input)

    model = torch.compile(model, backend='inductor')
    res2 = model(input)

    print(f"{device} results match: {torch.allclose(res1, res2, atol=1e-4, rtol=1e-4)}")

    return res1, res2

cpu1, cpu2 = check_model('cpu')
xpu1, xpu2 = check_model('xpu')

print(f"Eager results match: {torch.allclose(cpu1, xpu1.to('cpu'), atol=1e-4, rtol=1e-4)}")
print(f"Inductor results match: {torch.allclose(cpu2, xpu2.to('cpu'), atol=1e-4, rtol=1e-4)}")

Issue no longer reproducible
Env:

pytorch is built from source, top of the main trunk, commit_id - 9a8ab778d34bd24c5caceb340837483decc4c311
triton xpu is built from source, top of the main trunk, commit_id - fe93a00ffe438e9ba8c8392c0b051b1662c810de
benchmark is built from source, top of the main trunk, commit_id - d54ca9f80ead108c8797441681e219becaf963d8
torchaudio is built from source, top of the main trunk,  commit_id - 1980f8af5bcd0bb2ce51965cf79d8d4c25dad8a0
torchvision  is built from source, top of the main trunk,  commit_id -<PHONE_NUMBER>9e527f8b7e7b3340c40ee38bb1cfc4
PyTorch Dependency Bundle 0.5.0
Latest Rolling Driver


Delete pr branch test

testing pull request workflow

Repoman Generation Results
Repoman pushed changes to remotes for the following projects:
Project: todo-nodejs-mongo
Remote: azure-samples
Branch: pr/20
You can initialize this project with:
azd init -t kaizentm/todo-nodejs-mongo -b pr/20

View Changes | Compare Changes

Project: todo-python-mongo
Remote: azure-samples
Branch: pr/20
You can initialize this project with:
azd init -t kaizentm/todo-python-mongo -b pr/20

View Changes | Compare Changes


Cannot find any information about azure sql managed instance?

How azure sql managed instance is related to FedRAMP controls? We could not find this on any of the Microsoft documentations.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: f5219528-fc64-7b32-27b3-96118a2a89ef
Version Independent ID: 706d224a-b728-f5c8-a228-7c540f7c53c3
Content: Azure Security and Compliance Blueprint - IaaS Web Application for FedRAMP
Content Source: articles/security/blueprints/fedramp-iaaswa-overview.md
Service: security
GitHub Login: @jomolesk
Microsoft Alias: jomolesk

Addressed customer question through email. Please close; issue is not related to article content.

@Anmolgan81 We will now proceed to close this thread. If there are further questions regarding this matter, please reopen it and we will gladly continue the discussion.


Ignore config.cmake in git and remove old files

Description
Remove old files to make the cmake instruction consistent with our man page.
Add config.cmake to gitignore for better developer experience.
@leezu Please review.

What's the rationale for removing dev menu? The main goal is to reproduce CI results, build documentation and reproduce failures. I understand that the installation instructions were updated and that's fine. But I think the two things are unrelated.

@larroy I don't see it being used in our current CI any more. Where do we use it?
This caused confusion to new users. We have seen in the slack channel some users were trying to modify cmake_options.yml and build mxnet.

Update PR per offline discussion with @larroy

Thanks, could you update dev_menu.py to use the new way to configure CMake ?  right now it will be broken.

Essentially if think for that you need to delete
    def read_config(self):
        assert os.path.isfile(self.cmake_options_yaml)
        with open(self.cmake_options_yaml, 'r') as f:
            self.cmake_options = yaml.safe_load(f)

    def _cmdlineflags(self):
        res = []
        for opt,v in self.cmake_options.items():
            res.append('-D{}={}'.format(opt,v))
        return res

def cmake_command(self) -> str:
        """
        :return: Cmake command to run given the options
        """

and replace cmake_command call with something like ['cmake', '-C', 'config.cmake']?

Did you try to run the tool? Looks like it's broken now.

Where is the config.cmake? or where is documented how to use it?, I looked at the new build from source instructions are we are still calling plain cmake.

Calling plain cmake is intended and correct. You just need to pass the -C path/to/config.cmake option.
You can find the default files in https://github.com/apache/incubator-mxnet/tree/master/config
#17602 renamed the config.cmake to linux.cmake etc


chore: manual bump of jx-helpers as updatebot is broken

Signed-off-by: ankitm123<EMAIL_ADDRESS>

/approve


Unable to boot into single user mode

Describe the bug
When appending the single keyword to the the linux kernel line of the boot entry in grub, the system boots into rescue mode, however you get the message Cannot open access to console, the root account is locked
To Reproduce

Boot Fedora IoT
Interrupt boot process at grub menu
Append single to the linux line
Continue boot

Expected behavior
I expect to be dropped into an interactive rescue shell.
Screenshots

OS version:
This happens with Fedora IoT 40 (40.20240923.1) and 41 (41.20241027.0)
Additional context
See also https://github.com/coreos/fedora-coreos-tracker/issues/1792

You can workaround this problem by appending init=/bin/sh to the linux line of the grub entry

If you have a password configured for the root user, this does not happen.
We can't set a default root password and we can't enforce the creation of a root password when the system is provisioned, so maybe we just need some clear docs around this.

If you have a password configured for the root user, this does not happen.

What doesn't happen? Do you mean it works as expected for the single key word?
Also is this a ostree issue, or a Fedora/systemd issue in general? I suspect it's a systemd feature (or bug depending on which way you look at it).

For reference this is not new, it's a systemd feature and not specific to ostree or even Fedora, it's also been the case for years, they added the ability to override it with an environment variable in 2018[1].
I think this should be, and it may already be but a quick search didn't bring anything up, documented as part of standard Fedora docs as it's not IoT (or ostree for that matter) specific.
[1] https://github.com/systemd/systemd/pull/10397

I'm going to close this, it's working as expected, and in fact is a feature we want for edge devices because else it's a security attack vector if a random person can access the root filesystem without any restriction.
If a user that wants to be able to do this without a password they can set the appropriate env variable, details are in the referenced systemd PR. It should be documented in general Fedora docs but it's already in systemd docs (I believe).

The feedback is fair and makes sense; I was applying use cases for desktops to the IoT/Edge environment, which don't have the same requirements.

It's useful to have the conversation documented here in a ticket though for people to see why a decision was made so thanks!


CASMTRIAGE-5619 - Add steps to verify iPXE binary to PXE runbook

Description
Add procedure to verify the iPXE binary is valid after troubleshooting boot issues on tyr where it wasn't.

Checklist

[X] If I added any command snippets, the steps they belong to follow the prompt conventions (see example).
[X] If I added a new directory, I also updated .github/CODEOWNERS with the corresponding team in Cray-HPE.
[X] My commits or Pull-Request Title contain my JIRA information, or I do not have a JIRA.

/backport release/1.3


Guard against undefined objects during encounters

Hello, learning to develop on this project. Starting simple by eliminating a couple of exceptions that I noticed.

When starting a combat encounter without a scene or tokens, undefined object exceptions fire in CombatHelpers.startTurnChecks() for the turn object and CombatHelpers.checkEndTurnConditions() for the combatant object. Added tests for undefined to prevent these exceptions, and write a console warning instead in startTurnChecks().

Seems like all the sound files are removed from sounds.txt, so WFRP_Audio.PlayContextAudio by default always throws an undefined object and also causes an HTTP 404. Added test for undefined sound.file to prevent both of those in favor of a console warning.

Set git to ignore the wfrp4e.lock file if you happen to have the system locked in VTT.

Thanks!


Add Spark.Builtins

One of the spark types we have is {:spark_function_behaviour, ... that allows specifying a "builtins module" which is a module from which to show autocompletions automatically. What we should do is allow other modules to add to that list by putting doing the following:
defmodule Foo do
  use Spark.Builtins, for: Ash.Resource.Changes.Builtins, extension: ExtensionName
end

for example.
The spark autocomplete extension would then look for any module doing that and add its functions into the mix, as long as the resource is using the provided extension. (since the extension would do the importing). Then users would get nice autocomplete of automatically imported additional builtins.

I'm going to close this as unplanned, as it's a bit too implicit/indirect. importing functions is easy and works well.


Unable to get open price of a stock on the current day itself, getting yesterday instead

I have the latest version of yfinance installed.
I tried the following query, ohlcv = yf.Ticker('AAPL').history(period='1d'), to get the open price of a stock 1 second after the market open at 9:30:01.
I even did
ohlcv = yf.Ticker('AAPL').history(period='1d')
while ohlcv.index[0].date() != datetime.datetime.now(pytz.timezone('US/Eastern'))).date():
    ohlcv = yf.Ticker('AAPL').history(period='1d')
    time.sleep(0.5)

because i wanted to make sure that the date was correct.
I tried this with 6 tickers today, GOOGL, NOW, BABA, BX, APD and SEDG.
Using the code above, and asserting that I get todays date (12 July 2023), I got the following open prices which are actually 11 July 2023. Even though i used datetime.datetime.now(pytz.timezone('US/Eastern'))).date() to assert the date.
GOOGL 116.29 supposed to be 118.80
NOW 567.21 supposed to be 570.86
BABA 91.02 supposed to be 94.11
BX 93.80 supposed to be 99.60
APD 291.28 supposed to be 291.70
SEDG 266.00 supposed to be 272.10
I have no idea why I get yesterdays open even though I am forcing the program to check the date as today. Any idea why it's behaving like this and what I can do to solve this? I am trying to get the open price of a stock on that day itself.
It seems that the date is today's date but the price is yestedays open. I tried it again like an hour later and it showed the correct price.
I have tried this everyday for a week already and it's the same during the market open.
I have tried it on BP.L and RELIANCE.NS during their respective market opens but they seem to work fine. This problem only seems to happen on the US market opens.

Hello,
I get the same error.

Hello,
Did you get any solution way?
Thanks

Any update on this one? Not sure if this is a locale related issue. I am pulling the data from India and the current day data doesn't get refreshed until 11:30 EST.

How are you determining what the price should be? Maybe that's wrong.

By the date.

Review the bug report template form and complete relevant questions/tasks here. Need to correctly identify fault before solving.

How are you determining what the price should be? Maybe that's wrong.

20231016: Open price should be 250.05. This is currently reflected two hours after market open.
ticker type    open    high     low   close     volume
1    TSLA CURRD  258.90  250.48  248.48  250.29    2861650   => @ 9.31, the open price is showing incorrectly as 258.9. This is prev day open price. Other values are ok.
2    TSLA PREVD  258.90  259.60  250.22  251.12  102073800
Values at 11:00 EST.
ticker type    open    high     low   close     volume
1    TSLA CURRD  250.05  254.17  248.48  253.23   37805861
2    TSLA PREVD  258.90  259.60  250.22  251.12  102073800

Please: https://docs.github.com/en/get-started/writing-on-github/working-with-advanced-formatting/organizing-information-with-tables

@anarchy89 did you find a fix/workaround for this issue? Issue persists in the latest release. Thanks!

No I am still waiting for a solution as well

I'm waiting for someone to post debug log ...
https://github.com/ranaroussi/yfinance/issues/1591#issuecomment-1766244019

Describe Bug
The open price of the ticker is set to yesterdays open price at 9:30 a.m EST and this does not get updated until 10:30 a.m. EST

Sample code that reproduces your problem:
import yfinance as yf
import logging
logging.basicConfig(level=logging.DEBUG)
data = yf.download("TSLA")
print(data.tail(5).to_string())

Debug log:
DEBUG:yfinance:Entering download()
DEBUG:yfinance:Disabling multithreading because DEBUG logging enabled
DEBUG:yfinance: Entering history()
DEBUG:peewee:('CREATE TABLE IF NOT EXISTS "_kv" ("key" VARCHAR(255) NOT NULL PRIMARY KEY, "value" VARCHAR(255)) WITHOUT ROWID', [])
DEBUG:peewee:('SELECT "t1"."key", "t1"."value" FROM "_kv" AS "t1" WHERE ("t1"."key" = ?) LIMIT ?  LIMIT ? OFFSET ?', ['basic', 1, 0])
DEBUG:yfinance:loaded persistent cookie
DEBUG:yfinance:reusing cookie
DEBUG:urllib3.connectionpool:Starting new HTTPS connection (1): query1.finance.yahoo.com:443
DEBUG:urllib3.connectionpool:https://query1.finance.yahoo.com:443 "GET /v1/test/getcrumb HTTP/1.1" 200 None
DEBUG:yfinance:crumb = '/bPWUUV6QNr'
DEBUG:yfinance:    Exiting _get_cookie_and_crumb_basic()
DEBUG:yfinance:   Exiting _get_cookie_and_crumb()
DEBUG:urllib3.connectionpool:Starting new HTTPS connection (1): query2.finance.yahoo.com:443
DEBUG:urllib3.connectionpool:https://query2.finance.yahoo.com:443 "GET /v8/finance/chart/TSLA?period1=-1421452800&period2=1700643606&interval=1d&includePrePost=False&events=div%2Csplits%2CcapitalGains&crumb=%2FbPWUUV6QNr HTTP/1.1" 200 None
DEBUG:yfinance:  Exiting get()
DEBUG:yfinance:TSLA: yfinance received OHLC data: 2010-06-29 13:30:00 -> 2023-11-21 14:30:00
DEBUG:yfinance:TSLA: OHLC after cleaning: 2010-06-29 09:30:00-04:00 -> 2023-11-21 09:30:00-05:00
DEBUG:yfinance:TSLA: OHLC after combining events: 2010-06-29 00:00:00-04:00 -> 2023-11-21 00:00:00-05:00
DEBUG:yfinance:TSLA: yfinance returning OHLC: 2010-06-29 00:00:00-04:00 -> 2023-11-21 00:00:00-05:00
DEBUG:yfinance: Exiting history()
DEBUG:yfinance:Exiting download()

Bad data proof:
Actual Data

|Date       | Open       | High       | Low        | Close      | Adj. Close | Volume   |
|-----------| -----------| ---------- | ---------- | ---------- | ---------- | ---------|
|2023-11-15 | 239.289993 | 246.699997 | 236.449997 | 242.839996 | 242.839996 | 150354000|
|2023-11-16 | 239.490005 | 240.880005 | 230.960007 | 233.589996 | 233.589996 | 136816800|
|2023-11-17 | 232.000000 | 237.389999 | 226.539993 | 234.300003 | 234.300003 | 142532800|
|2023-11-20 | 234.039993 | 237.100006 | 231.020004 | 235.600006 | 235.600006 | 116320100|
|2023-11-21 | 234.039993 | 243.619995 | 233.339996 | 241.199997 | 241.199997 | 121987800|

Expected Data

|Date       | Open       | High       | Low        | Close      | Adj. Close | Volume   |
|-----------| -----------| ---------- | ---------- | ---------- | ---------- | ---------|
|2023-11-15 | 239.289993 | 246.699997 | 236.449997 | 242.839996 | 242.839996 | 150354000|
|2023-11-16 | 239.490005 | 240.880005 | 230.960007 | 233.589996 | 233.589996 | 136816800|
|2023-11-17 | 232.000000 | 237.389999 | 226.539993 | 234.300003 | 234.300003 | 142532800|
|2023-11-20 | 234.039993 | 237.100006 | 231.020004 | 235.600006 | 235.600006 | 116320100|
|2023-11-21 | 235.039993 | 243.619995 | 233.339996 | 241.199997 | 241.199997 | 121987800|

yfinance version:
0.2.32

Python version:
3.10.x

Operating system:
Windows 10

DEBUG:yfinance:TSLA: yfinance received OHLC data: 2010-06-29 13:30:00 -> 2023-11-21 14:30:00

Means data returned by yfinance matches what Yahoo API returns, except timezone change.

Hi,
Maybe it should be changed to include pytz so that it’s in the time zone of where the stock is instead of where the query comes from.
On 22 Nov 2023, at 21:12, ValueRaider @.***> wrote:

DEBUG:yfinance:TSLA: yfinance received OHLC data: 2010-06-29 13:30:00 -> 2023-11-21 14:30:00
Means data returned by yfinance matches what Yahoo API returns, except timezone change.
—
Reply to this email directly, view it on GitHubhttps://github.com/ranaroussi/yfinance/issues/1591#issuecomment-1822746795, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ABM3J44R26SDUP5QLZ7KKMTYFX23PAVCNFSM6AAAAAA2HVA2WWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMRSG42DMNZZGU.
You are receiving this because you were mentioned.Message ID: @.***>

This may or may not be a timezone issue. It is only the open price that is incorrect and not the HLC values. Let me try to grab the log exactly at 9:30/9.35/10 EST.

@anarchy89 read the log, your comment is redundant.

Debug log not helping because I misunderstood issue, I thought was "today is missing". I have no insight to offer beyond what I said 2 comments ago.

You can fix this by putting the end date one day into the future.
When you download the historical prices (in .csv) from the yahoo web page and change the default date, it will also be from yesterday.
To get data from today in the .csv file, you have to change the end date to tomorrow.
from datetime import datetime, timedelta
import yfinance as yf

start_date = date.today()-timedelta(days=7)
end_date = date.today()+timedelta(days=1)

msft = yf.Ticker("MSFT")
hist = msft.history(period="1d", start= start_date, end=end_date)
hist

2023-12-04 00:00:00-05:00	369.100006	369.519989	362.899994	369.140015	32063300	0.0	0.0
2023-12-05 00:00:00-05:00	366.450012	373.079987	365.619995	372.519989	23065000	0.0	0.0
2023-12-06 00:00:00-05:00	373.540009	374.179993	368.029999	368.799988	21182100	0.0	0.0
2023-12-07 00:00:00-05:00	368.230011	371.450012	366.320007	370.950012	23118900	0.0	0.0
2023-12-08 00:00:00-05:00	369.200012	374.440002	368.279999	374.230011	20034491	0.0	0.0

@Maximilian3141 The issue is about the data quality. The open price @930 am EST shows yesterdays open price and this continues till 1000 am EST at which point the current days open price is correctly captured. What do you get at 930 EST with the fix that you are proposing?

@chotaGit I'm sorry, I just tried it, since European markets are open right now, and it's not fixed by choosing an end date one day in the future. Previously, I couldn't reproduce the error correctly, because no markets were open.
Current Time: 2023-12-11 09:59:06.574482+01:00

2023-12-07 00:00:00+01:00	16623.890625	16655.300781	16595.109375	16628.990234	76803200	0.0	0.0
2023-12-08 00:00:00+01:00	16644.619141	16782.720703	16630.179688	16759.220703	77814500	0.0	0.0
2023-12-11 00:00:00+01:00	16644.619141	16777.460938	16745.560547	16750.140625	0	0.0	0.0

I don't think it is fixable? The problem is that the yahoo API provides wrong data for the first few minutes/hours in a day?


Support for worker execution context

I initially experimented with OffscreenCanvas to allow compiling examples without  modifying the game loop.
But now i realized that the execution of WASM code is treated like a normal function call (not a macro or micro tasks), so the worker thread will never handle user input, which is useless for many apps.
Also currently it is impossible to simply generate frames in a worker with OffscreenCanvas and bitmaprenderer context, as they don't work with 2d context.
So my experiment was failed, but there is a code to run lib in worker or main thread.

I don't get it. Is this some sort of working solution or just some bits of a failed experiment?

I don't get it. Is this some sort of working solution or just some bits of a failed experiment?

This is a working solution for running Raylib.js in worker

But does this allow to use original unmodified examples without the GameFrame() trick?

But does this allow to use original unmodified examples without the GameFrame() trick?

No, this pull request only about support for worker context.
But i think it is possible to do this in worker context.
I came up with the idea of using SharedArrayBuffer and maybe Atomics to implement the queue for passing events into worker context.
Also, as far as I remember, OffscreenCanvas with the transferToImageBitmap approach does not redraw the canvas in the main thread if the worker thread is blocked. So you need to generate and send the entire frame (possibly in the EndDrawing call) via postMessage.
I can continue to work specifically on this if needed.

I implemented my idea in a separate branch and here's what I realized:

performance degradation is there, at any settings (without GameFrame() trick)
different settings work differently on different machines and in different browsers
using Atomics.wait and a separate thread, you can load resources (images, fonts, ...) synchronously

Here is an implementation https://x0k.github.io/raylib.js/ (changing settings may require reloading the page).
Thanks to @AntonPieper for the GitHub pages hack with SharedArrayBuffer.


Writing Documentation of Project in HIndi Language

Hello Respected sir/mam
If you like my idea then we can write a Documentation on this project in Hindi Language
Aim of writing Document of Project in  Hindi Language is that Many people understand Hindi language well so one can read the documentation in Hindi language and understand Project well
If you like my idea than we can move ahead

@swapnilsparsh   If you find it valueable then please assign me this under iwoc with any difficulty tag

Not Needed


[project] Deployment of developer setup fails

I executed the steps as described in the README.
[INFO] Deploying war to http://localhost:8080/CS-Select
Uploading: http://localhost:8080/manager/text/deploy?path=%2FCS-Select
5348/17386 KB
[INFO] I/O exception (java.net.SocketException) caught when processing request: Software caused connection abort: socket write error
[INFO] Retrying request
Uploading: http://localhost:8080/manager/text/deploy?path=%2FCS-Select
5466/17386 KB
[INFO] I/O exception (java.net.SocketException) caught when processing request: Software caused connection abort: socket write error
[INFO] Retrying request
Uploading: http://localhost:8080/manager/text/deploy?path=%2FCS-Select
5564/17386 KB
[INFO] I/O exception (java.net.SocketException) caught when processing request: Connection reset by peer: socket write error
[INFO] Retrying request
Uploading: http://localhost:8080/manager/text/deploy?path=%2FCS-Select
5436/17386 KB
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  17.772 s
[INFO] Finished at: 2019-02-12T10:42:57+01:00
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal org.apache.tomcat.maven:tomcat7-maven-plugin:2.2:deploy (default-cli) on project CS-Select: Cannot invoke Tomcat manager: Connection reset by peer: socket write error -> [Help 1]
org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute goal org.apache.tomcat.maven:tomcat7-maven-plugin:2.2:deploy (default-cli) on project CS-Select: Cannot invoke Tomcat manager
    at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:215)

was cs-select already hosted on the tomcat installation? in that case:
can you try to use mvn tomcat7:redeploy instead of mvn tomcat7:deploy?

I cleaned tomcat's webapps/ dir before. Also tried redeploy: same problem.

what is the content of the
$CATALINA_HOME/conf/settings.xml file of your tomcat installation?

The file does not exist 😃 . Maven has a settings.xml, though.

can you create the file, with the following content:
    <settings >
        <servers>
            <server>
                <id>TomcatServer</id>
                <username>admin</username>
                <password>password</password>
            </server>
        </servers>
    </settings>

then restart tomcat and try again?

Same result.

in that case try putting the above text into the maven file

Same result.

I'll try to find out what is going on, this might take some time

do the new instructions on branch developer_setup work for you?

Sorry, I just found the reason: I messed up my Tomcat installation, a clean download fixed the issue. The re-written version of the README is still nice though, and could be merged,


Feature/957 validate course participation years

Context

see #957 on the Accredited Programmes Trello board.

Changes in this PR
We're kicking off the validation of entities in the API with this branch. This one focuses on the year-based fields in CourseParticipationEntity.CourseParticipationOutcome - yearStarted and yearCompleted.

Edited the type of these two year-based fields to Year. This means we don't need to e.g. manually ensure a four-digit integer is used.
Added a custom annotation called @YearFloor which accepts a date, in our case 1990. This also implicitly ensures that a four-digit year is used.
Implemented validation on the new annotation.
Ensured that transforming between the domain CourseParticipationEntity and its corresponding api model filters these fields through the validator.
Updated unit and integration tests to show the validation at work.

This ensures that we're validating at two places in the API - once at the domain level (on the entity itself) and once when transforming from the model (passed in from the controller) to the domain entity.
I've also taken the liberty of slightly improving the controller functions for updating and deleting a course participation, and implementing tests for both. Whilst not strictly related to this PR, it's related enough to my changes that I think it's worth including here.
Release checklist
Release process documentation
As part of our continuous deployment strategy we must ensure that this work is
ready to be released once merged.
Pre-merge

[ ] There are changes required to the Accredited Programmes UI for this change to work...

[ ] ... and they been released to production already

Post-merge

[ ] Manually approve release to preprod
[ ] Manually approve release to prod

Not sure what git absorb did there for some of the changes to import statements and the like. I'd cherry-pick them out but they're such minimal breakages that it probably isn't worth the effort.


Show error message in case of problems with getting access token

Currently in case of problems with token refresh is unclear what caused the problem and this change brings additional details.
Related to https://github.com/JetBrains/teamcity-google-storage/pull/9

@chingor13, could you please take a look on it? It'll help to diagnose credentials-related problems.

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@eb7e845). Click here to learn what that means.
The diff coverage is 100%.

@@            Coverage Diff            @@
##             master     #206   +/-   ##
=========================================
  Coverage          ?   75.84%
  Complexity        ?      313
=========================================
  Files             ?       20
  Lines             ?     1354
  Branches          ?      148
=========================================
  Hits              ?     1027
  Misses            ?      254
  Partials          ?       73

Impacted Files
Coverage Δ
Complexity Δ

.../google/auth/oauth2/ServiceAccountCredentials.java
81.38% <100%> (ø)
44 <0> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eb7e845...0915929. Read the comment docs.


Introduce MDel do the batch delete and use MultiLockGuard guarantee atomicity

Previously, the DEL/UNLINK commands looped through each key to
delete a single key. We need to change to batch delete (write),
and also the original implementation did not lock the keys and
will break atomicity.
This PR introduces a new Mdel function, which uses MultiLockGuard
to lock all the keys to guarantee atomicity, and use batch to do
the final delete (write).
Now it will be only used in DEL / UNLINKE commands. Noticed that
our DEL / UNLINK test coverage was not sufficient, added some simple
coverage tests to cover it.
Fixes for DEL / UNLINK issues in #1692.

We may have the deadlock in ZSet::InterStore(as well as other similar APIs) if the dst key was inside the source key list since the OverWrite function will also lock the dst key: https://github.com/apache/kvrocks/blob/unstable/src/types/redis_zset.cc#L635
This issue was found by TSAN in CI: https://github.com/apache/kvrocks/actions/runs/6022265431/job/16338859035?pr=1712

@git-hulk Good point.

I guess we should lock all the keys including the destination inside the ZSet::InterStore and similar methods (right now we lock the destination inside the Overwite method). Will it work?

I guess we should lock all the keys including the destination inside the ZSet::InterStore and similar methods (right now we lock the destination inside the Overwite method). Will it work?

Yes, I think it can resolve this issue.

I submit another issue to track this since it's related but NOT introduced by this PR. https://github.com/apache/kvrocks/issues/1715

Is it possible to lock the dst key only and use the read snapshot like SDIFFSTORE/SINTERSTORE?

Is it possible to lock the dst key only and use the read snapshot like SDIFFSTORE/SINTERSTORE?

@git-hulk can you describe this a bit more? (for example posting a pseudo code)

Is it possible to lock the dst key only and use the read snapshot like SDIFFSTORE/SINTERSTORE?

@git-hulk can you describe this a bit more? (for example posting a pseudo code)

Sure. For now, SDIFFSTORE is implemented in two steps:

The first step is to calculated the diff result without locking source keys
Then overwrite the dst key with locking the dst key

Is it possible to lock the dst key only and use the read snapshot like SDIFFSTORE/SINTERSTORE?

@git-hulk can you describe this a bit more? (for example posting a pseudo code)

Sure. For now, SDIFFSTORE is implemented in two steps:

The first step is to calculated the diff result without locking source keys
Then overwrite the dst key with locking the dst key

actually now we will lock the source keys. it was added in #1700, maybe we should remove the source keys locks?
rocksdb::Status Set::Diff(const std::vector<Slice> &keys, std::vector<std::string> *members) {
  std::vector<std::string> lock_keys;
  lock_keys.reserve(keys.size());
  for (const auto key : keys) {
    std::string ns_key = AppendNamespacePrefix(key);
    lock_keys.emplace_back(std::move(ns_key));
  }
  MultiLockGuard guard(storage_->GetLockManager(), lock_keys);

edit: ohh, i think i got your point. maybe we should split InterStore to two function, one do the inter and the other one do the store, just like the Set apis. I wanted to do it (adding a ZINTER command) before, but because we already had a pending #1517

Great, thank you!

i pushed a commit c51975b
split InterStore to two function, one do the inter and the other one do the store, just like the Set apis. to see if the CI can pass

i see the CI is passed, so the split change can fix the deadlock, i am going to submit another PR to make the change, am revert the change in this PR (after we merge the new PR, we can re-merge it)

lock-order-inversion found in TSan
https://github.com/apache/kvrocks/actions/runs/6062050794/job/16447962572?pr=1712


Update Location details in the App

Update list from DHO to include all villages in the App.

Do we essentially need a DHO version of the mobile app? If so, we probably need to discuss what functionality they need-i.e. if they aren't performing follow up visits, that functionality should be restricted.

They aren't performing followup visits. Its Typically following up VHTs and
Midwives
On Mon, Nov 13, 2017 at 5:15 PM, Eric Winkler<EMAIL_ADDRESS>wrote:

Do we essentially need a DHO version of the mobile app? If so, we probably
need to discuss what functionality they need-i.e. if they aren't performing
follow up visits, that functionality should be restricted.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/UNFPAInnovation/GetIn_Mobile/issues/83#issuecomment-343931041,
or mute the thread
https://github.com/notifications/unsubscribe-auth/APeq_07Ia-9Fl09izjJXmKu9e7HIPffKks5s2E7rgaJpZM4QZWQ5
.

--
Donald Waruhanga RUkanga
System Analyst, Developer, Entrepreneur, Computer Scientist!
my code, my innovations.

We need to revisit the necessity of this one. Seems like it is outside of scope for this next round of updates.

yea, its not necessary now. we should probably plan to train them on accessing dashboard via the phone


GPU CUDA Unknown Error

Thank you!!!

This doesn't seem related to DIGITS. Sounds like you killed a process in a weird way. Try rebooting? Otherwise try on StackOverflow or the NVIDIA devtalk forum or something?

Thank you for your reply.@lukeyeager
I aready rebooting. Then it's has already been solved. But I don't why.This issue has appeared several times.I always solve it by restarting the server.So I want to why.I also ask the issue to flx42.Below is his reply information.And you can see.

Well I'm glad Felix agrees with me! Please post back if you figure it out!

Okay.I'll do.


Unify launcher for bangle.js 2 and 1

Changes

Delete separate launcher code for bangle.js 1.
Slightly modify bangle.js 2 code to work on both devices.

Issues affected by this
Fixes #1177
(This means bangle.js 1 users will have a way to change the size of the text, and there's less code to maintain.)

[x] Tested on Bangle.js 1
[ ] Tested on Bangle.js 2

Tested on Bangle.js 2 and works well.


Add a full url to negotiate response

The full url like https://endpoint/path is suitable for engine.io to parse
Mainly used by engine.io negotiation's proposal: https://github.com/socketio/engine.io-client/pull/710

What is the output of Engine.IO parsing? Is the output a pair of (endpoint, path)?
If given a single string url combining endpoint and path, how could the Engine.IO client distinguish which part is endpoint and which part is path?
For example, assuming url = 'http://abc.com/foo/bar`, there are 2 possible (endpoint, path)

(endpoint, path) = ("http://abc.com", "/foo/bar")
(endpoint, path) = ("http://abc.com/foo", "/bar");
Both of them are legal but only 1 are correct for server.

Let's sync about the negotiate design for native Socket.IO package later.


Strange performance difference between localhost and <IP_ADDRESS>

Stumbled upon a strange performance issue this afternoon that I can't quite explain.
I am consistently seeing terrible performance when targeting localhost on my local machine vs. <IP_ADDRESS>.
Tested this on both 3.2.6 and 3.2.9.
# Put

~$ time ETCDCTL_API=3 etcdctl --endpoints=http://<IP_ADDRESS>:2379 put role testing
OK

real	0m0.018s
user	0m0.007s
sys	0m0.009s
~$
~$ time ETCDCTL_API=3 etcdctl --endpoints=http://localhost:2379 put role testing
OK

real	0m1.023s
user	0m0.007s
sys	0m0.011s

# Get

~$ time ETCDCTL_API=3 etcdctl --endpoints=http://localhost:2379 get role
role
testing

real	0m1.089s
user	0m0.009s
sys	0m0.027s
~$
~$
~$ time ETCDCTL_API=3 etcdctl --endpoints=http://<IP_ADDRESS>:2379 get role
role
testing

real	0m0.015s
user	0m0.007s
sys	0m0.008s

Any ideas?

Probably the resolution of localhost takes sometime? can you try with other tools like curl to verify it?

I can't seem to reproduce the issue outside the context of Etcd.  Are any of you guys able to reproduce locally?
Curl
~$ time curl -sL http://localhost:2379/metrics > /dev/null
real	0m0.230s
user	0m0.007s
sys	0m0.009s

~$ time curl -sL http://<IP_ADDRESS>:2379/metrics > /dev/null
real	0m0.031s
user	0m0.008s
sys	0m0.008s

Etcd Ruby client
require 'benchmark'
require 'etcdv3'

Benchmark.bm(10) do |x|
  x.report("localhost:") { Etcdv3.new(endpoints: 'http://localhost:2379').get('foo') }
  x.report("<IP_ADDRESS>:") { Etcdv3.new(endpoints: 'http://<IP_ADDRESS>:2379').get('foo') }
end

 user     system      total        real
localhost:   0.000000   0.010000   0.010000 (  1.017036)
<IP_ADDRESS>:   0.000000   0.000000   0.000000 (  0.001784)

Redis client test
$ time redis-cli -h localhost ping
PONG

real	0m0.007s
user	0m0.002s
sys	0m0.003s

$ time redis-cli -h <IP_ADDRESS> ping
PONG

real	0m0.012s
user	0m0.002s
sys	0m0.004s

Heh, I figured it out...  It appears that localhost is actually resolving to the ipv6 loopback ::1 fails as it hits the 1 second timeout, then falls back to the ipv4 <IP_ADDRESS> address.
Closing this out...


Get Data Set from URL

Need to grab the Data Set from an URL, download it, unzip it and formate is so we can use it for the training.

Resolved in commit


Validate names of package settings and patch directories

Fromager should ensure that settings files and patches directory use the override module name canonicalize_name(name).replace("-", "_"). In downstream we have a mix of canonical name and override module name for patches.

Based on https://github.com/python-wheel-build/fromager/blob/main/src/fromager/packagesettings.py#L474 I think we are already enforcing that naming convention, we just don't report issues with patches that don't match. #420 should help with that.

I think this was done with https://github.com/python-wheel-build/fromager/pull/424


Memory corruption with C# [Csharp] bindings

i. version of lib3mf: 2.2.0
ii. operating system: Windows 10
iii. what did  you do:
Compiled and ran the attached project:
class ThreeMfTest
{
    public static void Main()
    {
        CModel model = Wrapper.CreateModel();

        CColorGroup colorGroupTest = model.AddColorGroup();
        sColor redTest = Wrapper.RGBAToColor(255, 0, 0, 255);
        uint idRedTest = colorGroupTest.AddColor(redTest);
        // throws System.AccessViolationException:
        //   HResult = 0x80004003
        //   Attempted to read or write protected memory. This is often an indication that other memory is corrupt.
    }
}

iv. expected:
I expected the code to not throw an exception
v.
It throws an exception indicating that memory has probably been corrupted.
I shall attach a full solution .sln etc.. so the fault can be reproduced.

3MfTest.zip
Attached is zip file containing C# solution to exercise the fault.
When I am finish I shall have some C# examples translated from C++ that you can add to your package.

lib3MF v2.1.1 has the same fault.

Having the exact same problem with version 2.2.0 (and older versions as well e.g. 2.1.1, 2.0.1 & 2.1.0).
Problem does not only occur with adding colors, it also occurs once you add a material e.g.
CModel rootModel= Wrapper.CreateModel();
var baseMatGroup = rootModel.AddBaseMaterialGroup();
var darkBlue = Lib3MF.Wrapper.RGBAToColor(20, 20, 90, 255);
baseMatGroup.AddMaterial("material1", darkBlue); // ---> throws the same exception 'Attempted to read or write protected memory. This is often an indication that other memory is corrupt.'

Any idea how to solve this or any work around to get the colors working on C# ?


testing endpoint  -  add latest value  -  Feature request

To use your values in Home Assistant, it would be useful to not only have the testing history, but to have a kind of latest or actual value. Or even better (to reduce amount of transferred data) a testing endpoint, which just has the values of the last/latest week.

PR #209 will add this feature.

@hajo62 What du you mean by „latest value“?
The sum of all tests?
The latest history value is the latest value the RKI provides, there are no daily numbers.

To minimize the effort, I only asked for the absolut value of last week.

Now you can call https://api.corona-zahlen.org/testing/history/1 to get the latest data.


order of element in makestyles when using props

[X] This is not a v0.x issue.
[X] I have searched the issues of this repository and believe that this is not a duplicate.

Expected Behavior 🤔

When using makeStyles and using props on some class or property, if a html element have  multiple class, the priority of a element should be based on the order of declarations of elements.
Current Behavior 😯

If a class or a property was declared via a callback to have access to props, it will always have priority.
Steps to Reproduce 🕹

Link: https://codesandbox.io/s/prod-currying-01910?fontsize=14
If you update this codesandbox and change the line 12
width: () => "200px",
to
width: "200px",
the width of classB will get the priority (like it should)
Context 🔦

Your Environment 🌎

Tech
Version

Material-UI
v4.1.1

React
v16.8.6

Browser
Chrome 75.0.3770.90 / Firefox   67.0.3

clsx
v1.0.4

@vaielab Thank you for the report. I'm closing as a duplicate of #16316.


Detected blocking call to load_verify_locations

Describe the bug
I am on HA Core 2024.10 and get the following warning, which I am not sure if it was reported already:
WARNING (MainThread) [homeassistant.util.loop] Detected blocking call to load_verify_locations with args (<ssl.SSLContext object at 0x7fe0b26aa8d0>,) inside the event loop by custom integration 'robonect' at custom_components/robonect/__init__.py, line 81: await client.state() (offender: /usr/local/lib/python3.12/site-packages/httpx/_config.py, line 149: context.load_verify_locations(cafile=cafile)), please create a bug report at https://github.com/geertmeersman/robonect/issues
For developers, please see https://developers.home-assistant.io/docs/asyncio_blocking_operations/#load_verify_locations
Traceback (most recent call last):
  File "<frozen runpy>", line 198, in _run_module_as_main
  File "<frozen runpy>", line 88, in _run_code
  File "/usr/src/homeassistant/homeassistant/__main__.py", line 223, in <module>
    sys.exit(main())
  File "/usr/src/homeassistant/homeassistant/__main__.py", line 209, in main
    exit_code = runner.run(runtime_conf)
  File "/usr/src/homeassistant/homeassistant/runner.py", line 189, in run
    return loop.run_until_complete(setup_and_run_hass(runtime_config))
  File "/usr/local/lib/python3.12/asyncio/base_events.py", line 674, in run_until_complete
    self.run_forever()
  File "/usr/local/lib/python3.12/asyncio/base_events.py", line 641, in run_forever
    self._run_once()
  File "/usr/local/lib/python3.12/asyncio/base_events.py", line 1990, in _run_once
    handle._run()
  File "/usr/local/lib/python3.12/asyncio/events.py", line 88, in _run
    self._context.run(self._callback, *self._args)
  File "/usr/src/homeassistant/homeassistant/config_entries.py", line 742, in async_setup_locked
    await self.async_setup(hass, integration=integration)
  File "/usr/src/homeassistant/homeassistant/config_entries.py", line 594, in async_setup
    result = await component.async_setup_entry(hass, self)
  File "/config/custom_components/robonect/__init__.py", line 81, in async_setup_entry
    await client.state()

To Reproduce
Restart HA
Maybe 2024.10 required

According to the logs it seems an issue with the httpx library, but I'll check it out

Should be fixed in release v2.0.0

If all is fine, please close the issue 🙏

The warning no longer appears with version 2.0.0


parsing errors: expected identifier, got ast.ExpressionList

Please answer these questions before submitting your issue. Thanks!
What version of Go are you using (go version)?
go version go1.10.3 linux/amd64
What operating system and processor architecture are you using (go env)?
linux / amd64
What version of GoRuby are you using (git show -s --format=%H or goruby -version)?
ee5b7274d84c124 (which is HEAD)
What did you do?
I want goruby to produce an AST I can walk, but it's encountering errors with files rake accepts.
go run main.go -e "d w{}.o, w{}.o"
What did you expect to see?
If it parsed, I'd expect complaints of undefined variables or methods, such as
undefined local variable or method `p' for main:Object

What did you see instead?
syntax error, Parsing errors:
        could not parse call expression: expected identifier, got token 'ast.ExpressionList'
        1:12: no prefix parse function for type . found

exit status 1

When I hit the error in issue #53, I didn't see an easy fix, so I started pre-processing the ruby to remove newlines following commas. That led me to this error.

Hey @mpictor, no surprise here. The AST/Parser is not yet done. There are still a lot of missing cases. I am sure it's the same reason for #53.


ci(renovate): enable custom.regex manager

:tada: This PR is included in version 2.2.18 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Sharing feature for plant photos

Let users share plant photos by generating a share link. Use external host and specify a hint that indicates how this works. This feature needs to be enabled by an admin.

To do:

E-Mail confirmation for sharing photo
Allow sharing of gallery items

Resolved.


Introduce Sequence constant

Codecov Report

Merging #28 (6e4d7e0) into master (56c4fd4) will decrease coverage by 0.00%.
The diff coverage is 81.81%.

@@            Coverage Diff             @@
##           master      #28      +/-   ##
==========================================
- Coverage   83.99%   83.98%   -0.01%
==========================================
  Files          21       21
  Lines         937      943       +6
==========================================
+ Hits          787      792       +5
- Misses        150      151       +1

Flag
Coverage Δ

unittests
83.98% <81.81%> (-0.01%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

supergsl/plugins/chopchop/plugin.py
70.58% <50.00%> (ø)

supergsl/core/parser.py
90.18% <80.00%> (-0.39%)
:arrow_down:

supergsl/core/ast.py
84.61% <100.00%> (+0.13%)
:arrow_up:

supergsl/core/lexer.py
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 56c4fd4...6e4d7e0. Read the comment docs.


Azure EventHub PubSub component drastically reduces event distribution after a while

Expected Behavior
Unhandled events in the Azure EventHub get distributed to the Pods of the ReplicaSet until all events are handled.
Actual Behavior
After (re-)starting the deployment, it runs as expected for a while. All pods receive events and run without issues.
After an hour or two, the first pod starts to only sporadically receive events. With more time, more and more pods display this behaviour until all of them only handle an event every few minutes or so.
The strange thing about it is that the amount of unhandled events is still way up, so it's not just that there are no events to handle.
Other notable details:

The containers in the pods are healthy. If you could tell me a way to do it, I could also check whether the daprd sidecar responds.
There are still unhandled events in the hub. I checked by looking at data that should've been changed by the pods, had the events been handled.
The daprd sidecar shows no errors (debug logging is active).

Steps to Reproduce the Problem
This is also a bit spicy. I have the exact same setup running in another namespace connected to another EventHub, running under different names and everything. No issues on this one.
Still, my setup includes:

A Deployment listening via its sidecar to one dapr PubSub binding and publishing to another. It has the following annotations:

dapr.io/app-protocol: grpc
dapr.io/enable-api-logging: "true"
dapr.io/enabled: "true"
dapr.io/log-level: debug
dapr.io/app-id: cloud-dev-sidedetection-logic
dapr.io/app-port: "3010"

A dapr PubSub component for subscription:
  apiVersion: dapr.io/v1alpha1
  kind: Component
  metadata:
    name: dev-sidedetection-sub
  spec:
    type: pubsub.azure.eventhubs
    version: v1
    metadata:
      - name: connectionString
        secretKeyRef:
          key: AzureEventHubConnectionStringSubscriber
          name: cloud-dev-sidedetection-logic
      - name: storageAccountName
        value: rwimportermaterialized
      - name: storageAccountKey
        secretKeyRef:
          key: AzureEventCheckpointStorageKey
          name: cloud-dev-sidedetection-logic
      - name: storageContainerName
        value: azure-webjobs-eventhub

A dapr PubSub component for publishing:
  apiVersion: dapr.io/v1alpha1
  kind: Component
  metadata:
    name: dev-sidedetection-pub
  spec:
    type: pubsub.azure.eventhubs
    version: v1
    metadata:
      - name: connectionString
        secretKeyRef:
          key: AzureEventHubConnectionStringPublisher
          name: cloud-dev-sidedetection-logic
      - name: storageAccountName
        value: rwimportermaterialized
      - name: storageAccountKey
        secretKeyRef:
          key: AzureEventCheckpointStorageKey
          name: cloud-dev-sidedetection-logic
      - name: storageContainerName
        value: azure-webjobs-eventhub

A Secret containing the connection strings

A KEDA ScaledObject Custom Resource for scaling the ReplicaSet according to the amount of unhandled events

A KEDA TriggerAuthentication CustomResource which just connects the ScaledObject to the secret

A ClusterRoleBinding for HashicorpVault

I'd really like to give more information, but I'm highly unsure where to even look for more clues.

Release Note

RELEASE NOTE:

Possibly will be fixed by #2101 - we will be replacing the underlying SDK used.

It looks like we are experiencing the same behavior. Is there any way to work around this @berndverst that you are aware of?

So after I didn't touch the project for what must be months, it just started working today.
I changed nothing. The events are only stored for a week, so it can't be broken events stuck in the hub. The deployments didn't get restarted. Dapr wasn't updated.
If I ever get behind what sorcery happened here, I'll update this thread, but I wouldn't get my hopes up


Add support for Cloudflare R2 cloud storage

Description of changes:
Add support for Cloudflare R2 cloud storage
>>> import numpy as np
>>> from PIL import Image
>>> from streaming import MDSWriter
>>>
>>> # Local or remote directory in which to store the compressed output files
>>> data_dir = 'r2://test'
>>>
>>> # A dictionary mapping input fields to their data types
>>> columns = {
...     'image': 'jpeg',
...     'class': 'int'
... }
>>>
>>> # Shard compression, if any
>>> compression = 'zstd'
>>>
>>> # Save the samples as shards using MDSWriter
>>> with MDSWriter(out=data_dir, columns=columns, compression=compression) as out:
...     for i in range(10000):
...         sample = {
...             'image': Image.fromarray(np.random.randint(0, 256, (32, 32, 3), np.uint8)),
...             'class': np.random.randint(10),
...         }
...         out.write(sample)
...
>>> from torch.utils.data import DataLoader
>>> from streaming import StreamingDataset
>>>
>>> # Remote path where full dataset is persistently stored
>>> remote = 'r2://test'
>>>
>>> # Local working dir where dataset is cached during operation
>>> local = './test'
>>>
>>> # Create streaming dataset
>>> dataset = StreamingDataset(local=local, remote=remote, shuffle=True)
>>>
>>> # Let's see what is in sample #1337...
>>> sample = dataset[1337]
>>> img = sample['image']
>>> cls = sample['class']
>>>
>>> # Create PyTorch DataLoader
>>> dataloader = DataLoader(dataset)
>>> sample
{'class': 6, 'image': <PIL.JpegImagePlugin.JpegImageFile image mode=RGB size=32x32 at 0x23A3B83BFA0>}
>>>

Issue #, if available:
Merge Checklist:
Put an x without space in the boxes that apply. If you are unsure about any checklist, please don't hesitate to ask. We are here to help! This is simply a reminder of what we are going to look for before merging your pull request.
General

[ ] I have read the contributor guidelines
[ ] This is a documentation change or typo fix. If so, skip the rest of this checklist.
[ ] I certify that the changes I am introducing will be backward compatible, and I have discussed concerns about this, if any, with the MosaicML team.
[ ] I have updated any necessary documentation, including README and API docs (if appropriate).

Tests

[ ] I ran pre-commit on my change. (check out the pre-commit section of prerequisites)
[ ] I have added tests that prove my fix is effective or that my feature works (if appropriate).
[ ] I ran the tests locally to make sure it pass. (check out testing)
[ ] I have added unit and/or integration tests as appropriate to ensure backward compatibility of the changes.

Thanks @hlky for creating a PR.

Let me know if there any changes required, thanks.

Overall, the PR looks great @hlky . Thank you for your contribution. I have some minor comments to it.
Cloudflare r2 is an s3-compatible storage system. Users credentials can be set explicitly or it can retrieved implicitly  from AWS_ACCESS_KEY_ID and AWS_SECRET_ACCESS_KEY , here is the reference link for the same. Hence, instead of having a separate environment variables for R2 such as R2_ACCESS_KEY_ID and R2_SECRET_ACCESS_KEY. Instead, we can rely on the default AWS environment variable names such as AWS_ACCESS_KEY_ID and AWS_SECRET_ACCESS_KEY. The benefit of this is that it can work in both the cases as mentioned here where user just have to set the credentials once as part of ~/.aws/credentials and ~/.aws/config.
Here is my proposal:

You can remove R2_ACCESS_KEY_ID and R2_SECRET_ACCESS_KEY and replace R2_ENDPOINT_URL with S3_ENDPOINT_URL.
you can update the R2 documentation by pointing it here for the credentials setup. There will be an additional step required to set the flag S3_ENDPOINT_URL. Also mentioned this as part of R2 documentation.
On the streaming dataset side, streaming code will just have to do

r2_client = session.client('s3', region_name='auto', endpoint_url=os.environ['S3_ENDPOINT_URL'])

For the multiple object stores, for example, if user would like to keep an AWS S3 credentials as well as R2 credentials part of ~/.aws/credentials and ~/.aws/config, then they can do so by separating the credentials in a different AWS_PROFILE. For example, user just need to set all of credentials under AWS_PROFILE section and set it either as os.environ['AWS_PROFILE'] = '<profile_name>' or export AWS_PROFILE='<profile_name>'. You can also add this point as part of R2 documentation. The ~/.aws/credentials   would look something like this as shown below. In this case, os.environ['AWS_PROFILE'] = 'r2'.

[default]
aws_access_key_id=<your_aws_access_key>
aws_secret_access_key=<your_aws_secret_key>
[r2]
aws_access_key_id=<your_cloudflare_access_key>
aws_secret_access_key=<your_cloudflare_secret_key>

The ~/.aws/config would look something like this as shown below:
[default]
region=us-west-2
[r2]
region=us-west-2

On the streaming side, there is no change in the API, it will still have to do the same thing since boto3 imports AWS_PROFILE during runtime.

r2_client = session.client('s3', region_name='auto', endpoint_url=os.environ['S3_ENDPOINT_URL'])

Please let us know if you have any questions. Thank you!

As suggested I have removed R2 specific environment variables, replaced R2_ENDPOINT_URL with S3_ENDPOINT_URL, and updated documentation.
There is a fix for paths on Windows in R2Uploader's upload_file too, this could be replicated to other upload classes. Tests on Windows are also spotty with many tests failing from Invalid Cloud provider prefix. and others
Expected: download_from_gcs('gs://streaming-test-bucket\\train\\file.txt', 'C:\\Users\\user\\AppData\\Local\\Temp\\tmp16qu_of_\\file.txt')
Actual: download_from_gcs('gs://streaming-test-bucket/train/file.txt', 'C:/Users/user/AppData/Local/Temp/tmp16qu_of_/file.txt')

botocore.exceptions.ParamValidationError: Parameter validation failed:
Invalid bucket name "streaming-test-bucket\train\file.txt": Bucket name must match the regex "^[a-zA-Z0-9.\-_]{1,255}$" or be an ARN matching the regex "^arn:(aws).*:(s3|s3-object-lambda):[a-z\-0-9]*:[0-9]{12}:accesspoint[/:][a-zA-Z0-9\-.]{1,63}$|^arn:(aws).*:s3-outposts:[a-z\-0-9]+:[0-9]{12}:outpost[/:][a-zA-Z0-9\-]{1,63}[/:]accesspoint[/:][a-zA-Z0-9\-]{1,63}$"

I have also updated the description.

@hlky thanks for doing this, it's great to see the OSS community get involved!  Please let us know what else we can add or improve.

No problem, happy to help, Streaming seems to be a great alternative to WebDataset. I'll check further into Windows support as this would be useful for me.


kernel 4.10.1 bpf verifier

kernel image 4.10.1 should have our BPF patches, however installing it in my vagrant box
http://kernel.ubuntu.com/~kernel-ppa/mainline/v4.10.1/
still fails as below:
 R0=inv56 R1=pkt(id=0,off=0,r=34) R2=pkt_end R3=imm272,min_value=272,max_value=272 R4=inv R5=inv56 R6=ctx R7=inv56,min_value=0,max_value=255 R8=imm0,min_value=0,max_value=0 R9=inv R10=fp
441: (bf) r5 = r3
442: (07) r5 += 32
443: (18) r4 = 0xfffffff8
445: (5f) r5 &= r4
446: (77) r5 >>= 3
447: (bf) r0 = r1
448: (0f) r0 += r5
cannot add integer value with 3 upper zero bits to ptr_to_packet

it either ubuntu's mistake or mine, the official Linux kernel 4.10.1 does not have our verifier patch.


namespace vela-system is deleted when disable one special addon

Describe the bug
Namespace vela-system is deleted when disable one special addon, and all the vela's pods are deleted.
Vela is crashed.
To Reproduce
Steps to reproduce the behavior:

create one customized addon.
specify vela-system to be needNamespace in this addon's metadata.yml

needNamespace:
  - vela-system

add my private github addon registry, which holds this addon
go to velaux webpage, and enable this addon
wait for addon is installed
go to velaux and disable this addon
Namespace vela-system and its resources are deleted

Expected behavior
1.only the addon is uninstalled, vela should not be impacted
KubeVela Version
Version: v1.2.0
GitRevision: git-6cee468
GolangVersion: go1.16.13

After debugging, here is my investigation:
If user specify need namespace vela-system in addon's metadata as below
needNamespace:
  - vela-system

When vela enables this addon, it renders Application of addon, and one namespace Component is attached to Application
apiVersion: core.oam.dev/v1beta1
kind: Application
# ignore something here
spec:
  components:
# ignore something here
  - name: vela-system-namespace
    properties:
      apiVersion: v1
      kind: Namespace
      metadata:
        name: vela-system
    type: raw

"vela-system" namespace is patched some labels as below:
apiVersion: v1
kind: Namespace
metadata:
  labels:
    addons.oam.dev/name: mytest-middleware
    addons.oam.dev/registry: github-catalog
    app.oam.dev/app-revision-hash: e0c334973f055758
    app.oam.dev/appRevision: addon-mytest-middleware-v1
    app.oam.dev/cluster: ""
    app.oam.dev/component: vela-system-namespace
    app.oam.dev/name: addon-mytest-middleware
    app.oam.dev/namespace: vela-system
    app.oam.dev/resourceType: WORKLOAD
    app.oam.dev/revision: vela-system-namespace-v1
    kubernetes.io/metadata.name: vela-system
    name: vela-system
    oam.dev/render-hash: d36a385f6a56b1ac
    workload.oam.dev/type: raw

So, this addon could be enabled normally, but when user disable this addon, both the Application and namespace Component are deleted.
I think this vulnerability may be used by Malicious User or Attacker. Attacker could provide  such addon  to destroy vela system.
Actually, "vela-system" namespace do not need to be randered as one Component, because this namespace is already created when user install KubeVela.
If user want to enable vela addon, KubeVela and its namespace must exist already.


Numeric Syntax

Like the DatasetSyntax example, we will need syntax for Numerics
Think basic operators (+, -, /, *) etc

I'll try to tackle this one.

Awesome. I've just merged in the PR thats been open for the last few weeks on dataset/data stream design.
Check out this:
https://github.com/scalaz/scalaz-analytics/blob/api-design/src/main/scala/scalaz/analytics/AnalyticsModule.scala

Based on the latest conversations from Gitter, I propose to close this one and "join the forces" on #16 together with @GrafBlutwurst and @LukaJCB.


Missing v2.0.0 Release Artifacts?

It looks like there was a v2.0.0 release on Rubygems earlier today. However, I'm not seeing a git tag in this repo, nor an updated CHANGELOG, nor an updated README (it still refers to 2.x as an "(unreleased, master branch)" for instance).
I'm less pinging here as a reminder to do those things and more as a "this feels weird that the team pushed a new major release and forgot a bunch of stuff, was this push/release accidental?"

I got interrupted as I was checking things off the list.  Tag has been pushed!  Working on the others.

Done!

This is the first major release that I've done on this project, and over the 4 years I've worked preparing this release the mentions of 2.0.0 being unreleased multiplied, and I failed to snipe them all before the release.


Empty molecule has non-zero LabuteASA

It probably doesn't matter what property values are returned for empty molecules, but it struck me as odd:
Chem.rdMolDescriptors.CalcLabuteASA(Chem.Mol())

1.3684777599037141

Seems to come from here, https://github.com/rdkit/rdkit-orig/blob/master/Code/GraphMol/Descriptors/MolSurf.cpp#L76-L78

Hah!  That is a pretty funny result.  Good sleuthing!

Yeah, nice catch and thanks for pointing out exactly where the problem is!

@greglandrum thanks for the quick fix.  Our QA found this one ("A QA engineer walks into a bar ...").


Display most recent posts on landing page

Closes #33.
@JanaNF Feel free to take over or make changes as you see fit.

Closing as stale since changes are outdated and now conflict.


How to disable waves effects on mobile while scrolling / dragging?

Is there a way to disable waves effects on buttons while scrolling down a page on a mobile device? To me, it looks like it may cause user experience issues, where if you click on a button and scroll down it may look like they have clicked button due to the ripple effect.

Duplicate of #4027


Error is displayed when clicking on the annotation (the document is imported from MinIO

Precondition:
Import the document with annotations from MinIO (via the swagger)
Steps:

Open the document
Tap on the annotation

AR:
Error is displayed
https://user-images.githubusercontent.com/98399603/224980346-31b182f4-4047-4add-83d3-a84a42b803dd.mp4
ER:
Error is not displayed. Annotation is highlighted.

Fixed


Fixed failing JS tests issue

Fixed the issues in the medium JS tests
Tested with npm run test:medium, all tests are passing.

Merged

This is an automated message from Fork, Commit, Merge [BOT].

Thank you for your contribution! Your pull request has been merged. The files have been reset for the next contributor.
What's next?
If you're looking for more ways to contribute, I invite you to check out my other projects. Just click here to find more. These projects contain real issues that you can help resolve.
Also please leave a star to this project if you feel it helped you, i would really appreciate it.
I look forward to seeing your contributions!


Fix UG bugs for List command

Codecov Report

Merging #162 (327ac57) into master (3ab0397) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #162   +/-   ##
=========================================
  Coverage     30.41%   30.41%
  Complexity      499      499
=========================================
  Files           105      105
  Lines          4140     4140
  Branches        637      637
=========================================
  Hits           1259     1259
  Misses         2738     2738
  Partials        143      143

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3ab0397...327ac57. Read the comment docs.


WIP: VpnClient PowerShell reference update

1869910
I think this may be a false positive:
This appears in the current documentation: TunneledNonEapAuthMethod
This is the generated version: TunnledEapAuthMethod
"TunneledNonEapAuthMethod" is an alias of "TunnledEapAuthMethod".

Docs Build status updates of commit 508c1f9:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docset/winserver2022-ps/vpnclient/New-EapConfiguration.md
:white_check_mark:Succeeded
View (WindowsServer2022-ps)

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Closing per discussion with @PatAltimore


Refreshing partitions window

PostgreSQL
DBeaver 7.0.2
Windows 10x64

hi @greenpeas ,
unfortunately cannot reproduce an issue. it is reproducible after reseting UI settings (File - Reset UI Setting)?

Yes. I reset the interface settings and the problem is still there. I missed one point: I used a filter in the table tree. Then I erased the filter and the problem remains. I think the problem is due to the filter of the table tree.

still cannot reproduce it.
is it reproducible for you against 7.0.4?

In version 7.1.0 all good.


While creating new organization, if the new org doesn't exist in sfdc and clearbit, on clicking next button it goes back to the Select Organization page

Steps:

Have a PR which is gated
Click on 'Not Covered' and select CCLA
Go to Create New Org page and enter an org url which doesn't exist on sfdc and clearbit, add org name and entity name, click on Next button.

Actual Result: The page goes back to the Select Org. screen and console shows 404 errors.

Expected Result: On clicking next, it should go to 'CLA Not Found' page

As per release notes https://github.com/communitybridge/easycla-contributor-console/releases/tag/v1.0.34 this has been deployed to Dev, Staging & PROD.

As per release notes https://github.com/communitybridge/easycla-contributor-console/releases/tag/v1.0.34 this has been deployed to Dev, Staging & PROD.

Tested on Stage and it works fine.

Tested on Stage and it works fine.


Read R lists

It would be nice if librdata could read R lists.
It has been mentioned before in #12 , but as more and more people is asking about it (for example: this and this) I create here a separate issue for more visibility.

In the meantime it would be useful if a warning was emitted when a list is encountered in the file, many people is confused by trying to read lists and not getting anything back.


DoSOCS relationships

Look into allowing scan to create identifiers instead of oneshot.

Too much of a hassle for what we need to do.


Weird http pooling related error after v0.6.patch upgrade

Hi there,
After upgrading ethereumex  from v0.6.0 to v0.6.1 my test suite fails/gets stuck with some odd error. After some debugging I find error to be a very implicit/fundamental change in the way http pool is handled due to internal httpoison upgrade:
https://github.com/izelnakri/eth/blob/master/test/support/eth_client.exs#L13
https://github.com/izelnakri/eth/blob/master/test/support/eth_client.exs#L42 -> following code first returns hundreds/thousands of {:error, :econnrefused} while waiting for the spawned processes/ganache-cli http server to start and then it subsequent requests dont seem to get sent, and I assume the previous ones on the pool now returns {:error, :checkout_timeout} after ganache-cli starts serving the requests.
I'm still digging to see what has changed, the test suite doesnt work on the latest ethereumex as well. Most likely, our http pooling logic has changed and needs adjustments. I'll share more information once I have better understanding.
More info on the {:error, :checkout_timeout}: https://github.com/edgurgel/httpoison/issues/359

Your pr was merges and httpoison  was bumped to 1.7 in 0.7.0


Request two new annotations

From<EMAIL_ADDRESS>on April 17, 2015 16:50:57
Two annotation properties, 'term requester' and 'tracker item' proposed by Alan related to the OBO Foundry trackers: https://code.google.com/p/obo-foundry-operations-committee/issues/detail?id=166 The 'term requester' can credit the person, organization or project who request the term.
The 'tracker item' can associate a tracker with a specific ontology term.
Here are proposed definitions from Jie, Alan and Chris
term requester
--------------
Definition: The name of the person, project, or organization that motivated inclusion of an ontology term by requesting its addition.
tracker item
-------------
Definition: An IRI or similar locator for a request or discussion of an ontology term.
EXAMPLE: the URI for an OBI Terms ticket at sourceforge.
Chris thought the labels are too general. He prefer to give them more specific labels.
term requester -> ontology term requester
tracker item -> term tracker item
I am OK to use more specific labels that Chris proposed.
If no objection in 2 weeks, I will add them in the IAO.
Original issue: http://code.google.com/p/information-artifact-ontology/issues/detail?id=181

Two terms were added on Jan 19, 2016