Support for sructured logging

I am unable to get formatted or structured messages to appear in the TableStorage
target config
<target name="AzureTableStorage" type="AzureTableStorage"         tableName="auditLogs"               connectionStringKey="Nlog.Azure.BlobStorage.ConnectionString" >         <layout type="JsonLayout" includeAllProperties="true">           <attribute name="time" layout="${longdate}" />           <attribute name="level" layout="${level:upperCase=true}"/>           <attribute name="message" layout="${message}" />         </layout>       </target>
I get this in the Azure table Storage
{FullMessage: { "time": "2019-06-19 11:03:12.6477", "level": "DEBUG", "message": "{shopitem} added to basket by {user}" }, Message: {shopitem} added to basket by {user} }
It's called via the following
logger.Debug("{shopitem} added to basket by {user}", new { Id = 6, Name = "Jacket", Color = "Orange" }, "Kenny")

@anthony-sap I was unable to reproduce the same log in Table Storage. I see the contents of FullMessage as:
{
    "time": "2019-06-19 21:01:15.3335",
    "level": "DEBUG",
    "message": "{ Id = 6, Name = Jacket, Color = Orange } added to basket by \"Kenny\"",
    "shopitem": "{ Id = 6, Name = Jacket, Color = Orange }",
    "user": "Kenny"
}

This was just using the IntegrationTest project in the repo running .NET 4.5.2
What framework are you running?

It's being used in a .NET 4.5 project, does it need to 4.5.2?


Update faq.mdx for more accurate billable events description

Dynamic config checks are not billable. We were missing custom metrics and ingestions as well.

🚀 Deployed on https://6531a75cfd8e6c0bfea592ad--cozy-fox-0defec.netlify.app


Update README.md

Related issue

What changes does this PR do?
Screenshots (If any)
Questions

correction has been made and name has been arranged alphabetically.


Tests/benchmarks should clean up after themselves

There are many tests that drop tempfiles directly into os.TempDir() and don't delete them. Instead, these tests should do this:
tempDir, err := ioutil.TempDir("", "nsq-some-desc-here")
if err != nil {
  t.Fatal(err)
}
defer os.RemoveAll(tempDir)

I discovered this by finding that /tmp has 21GB of nsq data data in it.
I'll try to send over a PR for this.

RFR @jehiah @cespare


Override Jest config collectCoverageFrom with package.json

Solves #1455.
Verified by creating a new project using this code and testing with example package.json configuration:
"jest": {
  "collectCoverageFrom": [
    "src/**/*.{js,jsx}",
    "!<rootDir>/node_modules/",
    "!<rootDir>/path/to/dir/"
  ]
}

@ryansully I like this idea. But why not go a bit further and merge the default config object with any config object found in package.json.jest. In that way anyone can customize the jest config. Add their own coverage threshold and coverage path ignore patterns. What do you think @Timer @gaearon?

It could be done by just returning the config like this in createJestConfig.js:
const packageConfig = require(paths.appPackageJson).jest;
return Object.assign({}, config, packageConfig);

I can make a PR for that.

Personally, I can agree with merging the entire Jest config object, though keep in mind that doing so with the code above will only merge a shallow copy, which may have unintended side effects with any possible preexisting configuration that has deeper objects.
However, the original issue was specifically for collectCoverageFrom and so was written explicitly to address that issue and only that issue, in keeping with the Core Ideas of the project.
I'll leave the final decision up to @Timer, @gaearon, et al.

Yes I understand that adding configuration isn't going with the mind of "convention over configuration"

I tweaked this so that a subset is configurable, and other options throw.

Please help beta test the new version that includes this change!
https://github.com/facebookincubator/create-react-app/issues/2172

This might be a dumb question, but i'm a bit new to Jest & npm.
I'm trying to exclude a directory from being watched so that it doesn't trigger a refresh when the file changes.
I updated package.json with the jest object and something like this, trying to ignore src/json folder
"jest": {     "collectCoverageFrom": [       "src/**/*.{js,jsx}",       "!**/node_modules/**",       "!**/src/json/**"     ]   }
Then i run npm update.
It's still refreshing the browser when a file inside the json folder updates.
What am i doing wrong?
Thanks!!


Records metatables

Codecov Report

Merging #227 into lablua will increase coverage by 0.07%.
The diff coverage is 100%.

Impacted Files
Coverage Δ

titan-compiler/coder.lua
92.26% <100%> (+0.16%)
:arrow_up:

titan-compiler/upvalues.lua
95.58% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f10ece2...aa50131. Read the comment docs.


corpus_info_path can't be found in train_gpu.py

It is indeed not needed. README fixed in https://github.com/zihangdai/xlnet/commit/331dd006cab54d357b4c4f1dce7879fd1e0cce8c

And how to set FLAGS.model_dir, I can't find the flag. Thanks!


How to handle database version  update?

When I add a new field in my CoreData entity,the framework throws an error at this line.
internal var contextOptions: ContextOptions { return self.stack.contextOptions }
I want to know how to resolve this issue,because app's table structure often needs to be updated.

Hello. Can you provide the error description and call stack?

I believe this is related to issue #3, which we will need migration methods. Or maybe there is smart logic that can handle the database updates in simple scenarios, as simply adding/removing a field.
In development, I just delete the app in the device or simulator to let it regenerate the database to get around it. Of course, this doesn't make sense in production.
Below is the error stack. It can be reproduced in the sample project by adding a new field in AlecrimCoreDataExample.xcdatamodeld then regenerate the models via ACDGen. Run the project and you get:
2015-07-19 07:06:31.402 AlecrimCoreDataExample[59104:2363378] CoreData: error: -addPersistentStoreWithType:SQLite configuration:(null) URL:file:///Users/dev/Library/Developer/CoreSimulator/Devices/EB5BDC38-7A65-4BAC-A8A6-556FD8F38446/data/Containers/Data/Application/1680B0DB-CE14-455A-9738-6D54AD15C3AC/Library/Application%20Support/com.alecrim.AlecrimCoreDataExample/CoreData/AlecrimCoreDataExample.sqlite options:{
    NSInferMappingModelAutomaticallyOption = 1;
    NSMigratePersistentStoresAutomaticallyOption = 1;
} ... returned error Error Domain=NSCocoaErrorDomain Code=134130 "The operation couldn’t be completed. (Cocoa error 134130.)" UserInfo=0x7fbc42c20d90 {URL=file:///Users/dev/Library/Developer/CoreSimulator/Devices/EB5BDC38-7A65-4BAC-A8A6-556FD8F38446/data/Containers/Data/Application/1680B0DB-CE14-455A-9738-6D54AD15C3AC/Library/Application%20Support/com.alecrim.AlecrimCoreDataExample/CoreData/AlecrimCoreDataExample.sqlite, metadata={
    NSPersistenceFrameworkVersion = 519;
    NSStoreModelVersionHashes =     {
        Event = <895adb9f 0b23d63a 2e24bdc6 543ad1d6 034c05fb 996a90a6 883eb0af 37dfbd4f>;
        SubEvent = <651a1ecd 3bcdb170 ab15d3c9 0239e7dc 333e043e 9155596a 8961e9b8 22f79c3d>;
    };
    NSStoreModelVersionHashesVersion = 3;
    NSStoreModelVersionIdentifiers =     (
        ""
    );
    NSStoreType = SQLite;
    NSStoreUUID = "009AA3B4-006D-4D46-BBC8-D53E88C25681";
    "_NSAutoVacuumLevel" = 2;
}, reason=Can't find model for source store} with userInfo dictionary {
    URL = "file:///Users/dev/Library/Developer/CoreSimulator/Devices/EB5BDC38-7A65-4BAC-A8A6-556FD8F38446/data/Containers/Data/Application/1680B0DB-CE14-455A-9738-6D54AD15C3AC/Library/Application%20Support/com.alecrim.AlecrimCoreDataExample/CoreData/AlecrimCoreDataExample.sqlite";
    metadata =     {
        NSPersistenceFrameworkVersion = 519;
        NSStoreModelVersionHashes =         {
            Event = <895adb9f 0b23d63a 2e24bdc6 543ad1d6 034c05fb 996a90a6 883eb0af 37dfbd4f>;
            SubEvent = <651a1ecd 3bcdb170 ab15d3c9 0239e7dc 333e043e 9155596a 8961e9b8 22f79c3d>;
        };
        NSStoreModelVersionHashesVersion = 3;
        NSStoreModelVersionIdentifiers =         (
            ""
        );
        NSStoreType = SQLite;
        NSStoreUUID = "009AA3B4-006D-4D46-BBC8-D53E88C25681";
        "_NSAutoVacuumLevel" = 2;
    };
    reason = "Can't find model for source store";
}
2015-07-19 07:06:31.405 AlecrimCoreDataExample[59104:2363378] CoreData: annotation: NSPersistentStoreCoordinator's current model hashes are {
    Event = <7d07cbd9 e01b95fc 964bbff5 e49bf8f4 4c6300e8 4f5f3bc0 5b417f97 113637d8>;
    SubEvent = <651a1ecd 3bcdb170 ab15d3c9 0239e7dc 333e043e 9155596a 8961e9b8 22f79c3d>;
}
2015-07-19 07:06:31:405 AlecrimCoreDataExample [59104:main] Stack.swift(244) persistentStoreForSQLiteStoreTypeWithCoordinator(_:contextOptions:):
	Error Domain=NSCocoaErrorDomain Code=134130 "The operation couldn’t be completed. (Cocoa error 134130.)" UserInfo=0x7fbc42c20d90 {URL=file:///Users/dev/Library/Developer/CoreSimulator/Devices/EB5BDC38-7A65-4BAC-A8A6-556FD8F38446/data/Containers/Data/Application/1680B0DB-CE14-455A-9738-6D54AD15C3AC/Library/Application%20Support/com.alecrim.AlecrimCoreDataExample/CoreData/AlecrimCoreDataExample.sqlite, metadata={
    NSPersistenceFrameworkVersion = 519;
    NSStoreModelVersionHashes =     {
        Event = <895adb9f 0b23d63a 2e24bdc6 543ad1d6 034c05fb 996a90a6 883eb0af 37dfbd4f>;
        SubEvent = <651a1ecd 3bcdb170 ab15d3c9 0239e7dc 333e043e 9155596a 8961e9b8 22f79c3d>;
    };
    NSStoreModelVersionHashesVersion = 3;
    NSStoreModelVersionIdentifiers =     (
        ""
    );
    NSStoreType = SQLite;
    NSStoreUUID = "009AA3B4-006D-4D46-BBC8-D53E88C25681";
    "_NSAutoVacuumLevel" = 2;
}, reason=Can't find model for source store}

fatal error: unexpectedly found nil while unwrapping an Optional value
(lldb)

@basememara is right.The framework does not handle database migration(such as adding a field to an Entity).

Yes. This is precisely what issue #3 is about. I just do not have time or how to perform tests with migration until now (the models I have used has lasted for a long time without changes, but I know to support model changes is fundamental, including in this my own projects in future releases).
I'll try to fill this gap in version 4 of the library and then backport to version 3.x as well.

@vmartinelli A documentation for versioning and migrating with alecrimcoredata would be useful.

+1

Hi good morning, one question ! Are you working on those methods @vmartinelli ?? We can help you.

Hello, @CristianCardosoA.
No, I'm not. And I will not be able to work on it anytime soon.
It would be nice to have your help on this subject if it is possible for you.
Thank you very much. :-)


Case sensitivity error in README

Bnomei\Dotenv::load(); should be Bnomei\DotEnv::load(); on case sensitive installs (like heroku i think?)

sorry for the late fix – did miss the notification/email somehow.


Pressing delete triggers leaving source editor

To replicate:

Create new source
Load in Geojson
Put text cursor in the projection input field
Press delete to try to clear the text
Studio abruptly leaves the page and goes back to the previous page

I gather this is happening because you are not supposed to edit the projection of a GeoJSON (although we should allow this). Either way I can't see any reason why the delete key should cause the app to go backwards and potentially lose unsaved work.

@springmeyer the project input field is not a real field. What is happening is you are essentially just clicking on the page and then pressing delete. 'Delete' is the default keybinding for back page. We could disable the default behavior of 'delete' ?


[Question] Determinism of the F# Compiler

The Roslyn team has made an effort to make the C# / VB compilers deterministic: https://github.com/dotnet/roslyn/issues/372
This is interesting both for security (validating that an exe was built by the source someone claims it was built from) and for the build performance itself (only rebuilding things that changed).
According to this ominous tweet, it looks like Microsoft itself is building a deterministic & distributed build system: https://twitter.com/xjoeduffyx/status/686785616030240768 (Does anyone know anything about that? It is already April =) )
Are there any plans to make the F# compiler deterministic?

It is not currently in our plans to make the compiler deterministic although it would be sort of nice, to reap the benefits of determinism, essentially all or most of the tools in the build system need to be deterministic.  Deterministic builds for products the size of VS or windows are clearly advantageous and performance improving.  What do you think?

@KevinRansom (or anyone with even a remote idea) could you share what are the aspects that are known to be undeterministic?
I gather there might be async usages whose unordered results or side effects might create non-deterministic behaviour; it would help to have a rough overview if you expect the community to take on some smaller parts of this work.
Thanks

Well …
·        there are paths buried in the dll for source files, to tell the debugger about source files to debug
·        there is an mvid which is a random guid generated when a binary is created.
·        Version numbers .. id’s
·        I’m not too worried about async … the F# compiler isn’t anywhere near as reliant on thread-pools as Roslyn.  In fact it is pretty much single threaded.
The number of items in roslyn was surprisingly long … I remember at standup one or another of the dev’s on the team would be working on some determinism bug or another that they had found, most weeks.
The toughest problem, was some lack of determinism somewhere else in the toolchain, because that required another team to fix their determinism issues.
A particularly cool one occurred if there was a GC while writing out methods for some particular item, the GC could discard the items in a weak reference collection, and somehow the order of the subsequent items emitted changed.
·        If the community could construct determinism test cases,
·        we would certainly try to fix determinism issues, and take PR’s to address those issues.
·        The community would also need to fix up the community type providers which I suspect are pretty non-deterministic too.
Just as an FYI: the main driver for determinism in C# is that Windows and Visual Studio both have vast codebases (many millions of lines of code in each) and they are moving over to a deterministic build in order to ensure that we can gain the large build time reductions due to cashing of build artifacts.
There is a large portion of C#  code in both Windows and VS, due to the limited amount of F# code in those two codebases is lower there has been no pressure for us to make the compiler deterministic.
What is it about determinism builds that you see as being particularly useful?
Kevin
From: Gauthier Segay<EMAIL_ADDRESS>Sent: Saturday, April 9, 2016 1:15 AM
To: Microsoft/visualfsharp<EMAIL_ADDRESS>Cc: Kevin Ransom<EMAIL_ADDRESS>Subject: Re: [Microsoft/visualfsharp] [Question] Determinism of the F# Compiler (#1042)
@KevinRansomhttps://github.com/KevinRansom (or anyone with even a remote idea) could you share what are the aspects that are known to be undeterministic?
I gather there might be async usages whose unordered results or side effects might create non-deterministic behaviour; it would help to have a rough overview if you expect the community to take on some smaller parts of this work.
Thanks
—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHubhttps://github.com/Microsoft/visualfsharp/issues/1042#issuecomment-207743074

What is it about determinism builds that you see as being particularly useful?

We don't have such a big codebase, so it is not as important for us as for e.g. Microsoft, but I would be interested in deterministic builds to:

Reduce compile time during development
Currently, a full local build takes about 10 minutes.
Because we often work somewhere on the lower projects, the time between a change + F5 and the program starting is often multiple minutes. I know there are different things we can do to improve this, but deterministic builds would help.

Reduce patch size if fewer files change between versions.
(This would be just nice-to-have, our program size is nowhere near critical)

Thanks for all those details, quite interesting!

What is it about determinism builds that you see as being particularly useful?

TBH, as end user of F#, that doesn't impact me much, I use Resharper's Build which does very clever things with public API footprint of assemblies which saves lot of time in rebuild, even if I change a project low in the dependency tree it won't rebuild dependent things most of the times.
At Microsoft (and place having distributed build setup), it seems the requirement for deterministic (or at least distributed) build is higher, probably many solutions have been adopted for that; there still (naïvely) seems to be viable solutions around the fact that compiler might not be deterministic, by checking the exact input to the compiler against the cache.
For end-users, with large F# code base, compilation time probably has a more direct impact.

Strictly speaking there's relatively little non-determinism in the F# compiler.  You can see that partly because we are able to use emitted IL as a baseline.  While we have to "clean" that IL, that's normally because different arguments have been passed to the compiler, or compilation has happened in a different directory
AFIAK the only item that's really non-deterministic is the timestamp

The MVID is almost generated deterministically based on hashing some of the contents of the generated code.  However a timestamp is added to the hash.  We should likely just do whatever C# does here.

The timestamp is also recorded in the PDB file, probably for no useful reason.

If you want determinism to mean "it doesn't matter which directory you compile in", then this item is also relevant:

PDBs for debugger source file names contain full paths.

That said, the F# compiler is not particularly "stable under small code changes", which can be another meaning of non-determinism in incremental scenarios.  Specifically it generates stamps, see newStamp and its uses, and these can end up in emitt4ed IL, as can line numbers.  So adding a blank line to your source can change your output.  That may or may not be a problem depending on your scenarios.
It would be great to rid ourselves of these last few sources of non-determinism, by just doing whatever C# does in these cases.

I'm keen to look at this issue, although bare with me, this is my first attempted contribution to F# 😎
Much like @0x53A, we have a complex project build from mostly C#, with increasing amounts of F# at the lower levels. We put all artifacts for release into Git, and having deterministic builds will greatly help our speed and efficency of CI and CD.
Changing the two MVID and PDB timestamp as @dsyme has identified will give us what we need.
I've been investigating what C# did for a Roslyn in these two areas, a good reference for the changes made for Roslyn by @jaredpar: http://blog.paranoidcoding.com/2016/04/05/deterministic-builds-in-roslyn.html
To quote:

To create the MVID and time stamp with repeatable unique values the compiler uses cryptographic hashes. It takes the content of the PE with the above entries set to 0 and runs it through a SHA1 3 hash. The resulting 20 bytes are then carved up into a GUID (16 bytes) and a time stamp entry (4 bytes, high bit always set). A similar operation is performed for the PDB ID. This means the above values will be repeatable and unique for a given set of inputs.
The combination of the explicit ordering guarantee and the predictable values for MVID, PDB ID and timestamp allow us to produce fully deterministic PE outputs from the compiler. They will be identical byte for byte.

I'll have a look at the Roslyn repo to find the exact code that C# uses.
First question, should this we a compiler option or a change of default behaviour ?  If an option, default to on or off ?  jaredpar mentions the default of C# being off because of AssemblyVersionAttribute = *, is that something we need to support in F# ?

First question, should this we a compiler option or a change of default behaviour ? If an option, default to on or off ?

The best way to drive that decision is to consider the AssemblyVersionAttribute case and how the conflicts are handled.  Essentially when the compiler is both trying to build deterministically and dealing with an AssemblyVersionAttribute that has a * value.  These are naturally in conflict because:

*:  On ever build of the code base, please change this value.
/deterministic: On every build of the code base, please produce the exact same binary: byte for byte.

There are really a limited number of choices here for the compiler:

Honor deterministic and Ignore the * (use a default value like 0)
Ignore deterministic and honor the *
Honor both, issue no warning / error, and field the "determinism is broken" bug reports
Issue an error because this is confusing

Once you settle on which behavior the F# compiler should have above then that will pretty much settle the decision about what the default behavior should be.

Thanks, sounds like 4 is the sane choice, like C#, but maybe a warning rather than an error (are you still hopeful of going deterministic by default in C# 7 ?)

It's nearly impossible for us to have deterministic by default + issuing a warning about the use of *.  It would break so many customers that it would be an adoption blocker for Visual Studio.  The only realistic way we could make it the default is to:

Not warn about the use of *
Use warning waves to make the warning explicitly opt in.

It depends how you feel about determinism in the compiler.  In my mind the compiler should build the application described the source files.  and the use of a /determinism switch should cause the compiler to complain 'error' when it can't be deterministic and honour the source code.  However, no error is necessary in the absence of the switch.
my 2cents and probably worth all that we paid for them.

all sounds sensible, so opt in to determinism and error if using * and /deterministic

Have had initial stab at this on PR #2954, will work on tests next.

Closing due to merge of #2954 - thanks for the feature @davidglassborow !


Build failing with gcc 14.1.1

This build is failing for me on ArchLinux (gcc 14.1.1) with the following error:
zectl/src/zectl-0.1.3/lib/libze/libze.c:596:35: error: passing argument 2 of ‘nvpair_value_string’ from incompatible pointer type [-Wincompatible-pointer-types] ... /usr/include/libzfs/sys/nvpair.h:291:57: note: expected ‘const char **’ but argument is of type ‘char **’
I found that adding -fpermissive to CFLAGS solved this, but this feels like more of a work around than fixing the issue.

@woodsb02 Fixed in #53 and 0.1.4


Pin Firefox version for SauceLabs tests

Part fix for failing Travis build reported in
https://github.com/alphagov/accessible-autocomplete/issues/253
We hadn't tied SauceLabs to a version of Firefox. We haven't done
active development on the repo for a bit so it looks like the latest FF is not
compatible.
Tested as part of this PR: https://github.com/alphagov/accessible-autocomplete/pull/254
I wonder if we should specify Chrome version as well?

👏


Fix calico netmask calculation

Found by ineffassign in https://goreportcard.com/report/github.com/Mirantis/virtlet
WIP, because for sure it desires a coverage by separate test.

This change is

Ok. Test for that is postponed to separate task as I need to work on other tasks where this fix should be merged quite soon.

Reviewed 1 of 1 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable

Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable


discuss Static TypeScript design

Starting a thread to discuss what Static TypeScript is and is not. See https://github.com/Microsoft/pxt/blob/master/common-docs/javascript/sts.md

We do in fact support type assertions for class types. We could support union and intersection types between object values. What we cannot do is distinguish between strings, numbers, booleans and classes, since they all share representation. This is similar to Java, where int is different from Int, and you can cast Int to Object but not int to Object. C# hides that, while C++ doesn't really have the concept.

We just emit the underlying expression of the type assert. There is no runtime check of class, as we don't have a runtime tag.  We should make a decision on whether we want to add a runtime tag for classes. This will further distinguish them from records.   This would also allow us to check safety of downcasts.  Regarding union and intersection, once we have a runtime tag, they are easier to check.

Reads great :)
Need to address exceptions, floating point vs integer semantics, regex, debugging, async!!!.
We do support "any" for built in functions like string concat.
It would be good to give the historical context behind sts, it helps putting design decision in the context of microcontrollers.

@tballmsft  Sorry, that's right! I thought I implemented the tags. It shouldn't be too hard though. I think we should have it.  instanceof expression is only for classes, not for records, so we should be good there.

I am closing this issue and moving discussion to a pull request.


fix(charts/tigera-operator): openshift provider

Description
Fixes installation of calico tigera-operator when installation.kubernetesProvider is set to OpenShift.
Currently some resources are not created when installation.kubernetesProvider is set to OpenShift since the comparision is case sensitive. Since installation.kubernetesProvider values are limited to ["", EKS, GKE, AKS, OpenShift, DockerEnterprise, RKE2, TKG] due to Installation CRD schema we need to adapt the conditional.
Related issues/PRs
None
Todos

[ ] Tests
[ ] Documentation
[ ] Release note

Release Note
Helm: Fix OpenShift provider case sensitivity

Reminder for the reviewer
Make sure that this PR has the correct labels and milestone set.
Every PR needs one docs-* label.

docs-pr-required: This change requires a change to the documentation that has not been completed yet.
docs-completed: This change has all necessary documentation completed.
docs-not-required: This change has no user-facing impact and requires no docs.

Every PR needs one release-note-* label.

release-note-required: This PR has user-facing changes. Most PRs should have this label.
release-note-not-required: This PR has no user-facing changes.

Other optional labels:

cherry-pick-candidate: This PR should be cherry-picked to an earlier release. For bug fixes only.
needs-operator-pr: This PR is related to install and requires a corresponding change to the operator.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

@unai-ttxu sorry for missing this one!
The changes LGTM - but you may need to run make generate in order to update manifests, etc., that are based on this.

/sem-approve

@unai-ttxu sorry for missing this one!
The changes LGTM - but you may need to run make generate in order to update manifests, etc., that are based on this.

Thank you so much for the review and the approval :smile:. I see that finallly the manifests update was not necessary. If you need anything let me know.


Unable to retrieve parameters from figma.mixed node.textStyle

I am trying to output text to code using the plugin, but it doesn't work when some of the text is Bold for example. It just says the style is figma.mixed. How do I output this as different text blocks?
I am aware that the current textbox could be easily separated into two (stacked vertically), but often this isn't the case and they need to create a seemless paragraph with normal text and bold text being side-by-side and wrapping inside the frame/autolayout they are contained in. Is there a way to pickup the different sections of the text related to each style being applied or is there a way you can have text boxes fill and wrap inside an autolayout so that they look just like a single textbox?

There is a discussion on this topic in the Figma forums here and I was wondering if you have a workaround:
https://forum.figma.com/t/ability-to-auto-layout-two-text-nodes-as-one-block-of-text-flowing-continuously/44109

Yeah, there isn't a great way to model this because it can get very complicated. You could theoretically have hundreds of styles in the same text node. We are leaving it at what the plugin API provides at the node level, without any text range traversal. The recommendation is to detect the scenario where it is mixed, and render a default style name instead.


Correction for raw affiliation IEP de Grenoble

Correction needed for raw affiliation IEP de Grenoble
raw_affiliation_name: IEP de Grenoble
new_rors: 03c7zyj82
previous_rors:
works_examples: W2010495332;W4240718421;W2912748818
contact: 70c75bde097e62c431e4d931b9f4080c:e938931f4a74fd0de79788b52e76731e1148d27fa9 @ recherche.gouv.fr

This issue was accepted and ingested by the OpenAlex team on 2024-11-18. The new affiliations should be visible within the next 7 days.


Clicks While Page Loads are in Wrong Location

Bug
Clicking links while the page is loading on an Android device causes links somewhere else on the page to be activated. The window of time that this can happen can be 10 seconds or more on a slow connection.
To Reproduce
Steps to reproduce the behavior:

Go to any video using Android
Refresh page
Click the first link you see

Expected behavior
The link you clicked is activated
Screenshots
https://user-images.githubusercontent.com/30788194/138770695-108f90bb-522e-4eaf-a4f7-a08fd2c5ba42.mp4

Let us know if things feel smoother with the recent performance improvements and redesign. There's probably a bit more we can do, will continue to focus on performance as part of other issues.


Simplify development environment set up

Make it easy for contributors to set up their development environment.

Installing local database
Build, Test, Run application

@cmatheny
Which one?
src/main/resources/SQL/development/bash/sql/pg_evaluations_install.sh
src/main/resources/SQL/development/bash/pg_evaluations_install.sh

src/main/resources/SQL/development/bash/pg_evaluations_install.sh
I removed the other one, it wasn't supposed to be there.
Also, src/main/resources/SQL/development/zipped/evaluationsdb-lin.tar.gz is the full package that would be distributed for bash installation. It has all the files from the bash folder archived together.

@cmatheny Small changes to bash script:

When you use sed -i on Mac, you must specify an extension.
Use ~/.bash_profile

Also created Makefile.  Can you test on Windows?
Runs your database script (should detect your operating system)
make init

Builds and runs application using Docker
make

A few issues:

make is not included with windows or git bash for windows, but is easy to find/download make.exe (no installation needed)
make doesn't work from windows command line, and the windows install file doesn't work from bash shell
I can probably modify the bash script to work whether it's mac/linux or bash for windows

This leaves us a few options:

require bash and make as dependencies for a windows environment
support bash and make as easier options for people who have them but maintain the windows batch file for people who don't and don't want to set it up

I'm leaning towards the first option since bash is probably expected for other parts of development anyways, and make is a simple single file to add to the path. What are your thoughts?

I agree with the first option.  For a consistent contributor, having the Makefile is pretty useful.  Not sure of all the complications with bash on windows, but it's important we work out the kinks.
Having the same set of commands work in both environments also simplifies our documentation.
DRY

I had to change sed again to work on linux and bfw. It has an extension now and should hopefully work for mac as well
sed -i'.bak' '/INTEVAL/d' ~/.bash_profile
the space between -i and the quotes was the problem for me. Also, the new version backs up the profile to .bash_profile.bak which is good practice. Can you make sure it works on mac?

Makefile on Mac 👍

Working on connecting to database from container.
May run postgres in a container as well.

Working on windows and linux. Environment variables are only set inside the bash shell (not windows environment) but this is fine for the docker architecture and IDE will still have access if launched from the bash shell.
Do we want to include the make command for windows in the repo, or link to a download site in the wiki?

@cmatheny check out cmatheny/interview-evaluations#1

@cmatheny the development environment looks good.  Any clean up needed before we merge?

I fixed some bugs in the database, filled in some missing dummy data, and added a few QoL improvements to the Makefile:

Add a 10 second delay to make up to hopefully resolve the database connection caveat
Add interactive versions of up and run to show logs in the same command: Useful for when you want to see output in the terminal to know when api is running/ read exceptions etc but maybe we can improve this
Add log-db option as a shortcut to check database logs if it isn't working

Everything looks good to me now, if you agree we can go ahead and update the wiki and merge this.

I'd rather not have the -i options.
We already provide commands to get logs, so maybe provide the following commands?
All logs: make logs
API logs: make logs-api
DB logs: make logs-db

@cmatheny So we only need the delay on the first ever make up.
I don't think it makes sense to delay every time.

@tjkemper I like the -i to save having to run make && make logs every time I rebuild, but we can take it out if you disagree. I could make a bash function locally to do the same thing.
I just added the delay because you said it was sometimes an issue. Is the db connection problem only when it has to download the image? I've never had the timeout problem even after a make clean, so I wasn't sure if it's an issue with then the database is being built or the image being download.

Problem: When the database is initially created it needs some time to set up.  So the API cannot connect and fails to deploy.  This only happens the first time you run make up or after you run make clean.   However, I didn't get the problem today 😉
This is foreseeable, but not worth a fix.  And we shouldn't sleep every time we run make up.
Did some clean up.  The -i commands are ok with me.  Ready to merge when you are 👍

@cmatheny Do we need src/main/resources/SQL/?

@tjkemper Everything in src/main/resources/SQL/development is obsolete with the docker/makefile setup - the scripts that we're still using are in sql/. The database_tables.sql is outdated and a less accurate representation of the production database than the new create_tables sql file. I think the only relevant thing in there is the layout image, which we should keep and move to docs/.

lgtm


[FLINK-28597][state] Discard initial checkpoints without a delay in common cases

What is the purpose of the change
This PR limits checkpoint discard delay in CLAIM restore mode (FLINK-25872) to two cases:

Changelog (off -> on). Adjust SharedStateRegsitry API to make it explicit that the state to register must prevent deletion of the checkpoint created it (i.e. initial checkpoint). This only takes effect when referring to the initial checkpoint state.
RocksDB Incr. Native Savepoint. Rely on SharingFilesStrategy of the restored savepoint to determine whether any shared state can reside inside the chk-xx folder (rather than /shared).

SharingFilesStrategy is a proxy to scope and therefore (SST) files location in terms of code.
Conceptually, it also seems the right property of the checkpoint to analyze.
Verifying this change
New tests in SharedStateRegistryTest.
Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): no
The public API, i.e., is any changed class annotated with @Public(Evolving): no
The serializers: no
The runtime per-record code paths (performance sensitive): no
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: no
The S3 file system connector: no

Documentation

Does this pull request introduce a new feature? no
If yes, how is the feature documented? no

Except for testUnregisterNonInitialCheckpoint, this PR looks good to me.
@curcur would you like to take a look as well?

Besides the comments above, I think one thing that bothers me a bit is the new Checkpoint Meta serializer.
If no_sharing is documented as it is, it should be fine just deleting it? No matter shared part or private part.
It would be great if we can get rid of all the changes of meta data + completed Checkpoint data change.

Thanks a lot for updating the PR @rkhachatryan, the changes LGTM, could you please squash the commits?

@flinkbot run azure


WinTimer crash on close / relaunch

I believe this is quite an old issue, but I only isolated it just now from a Windows source build. It seems like if I leave a program running for a while (I don't know why this should matter, but it seems to) then attempt to relaunch / close Solar, it will often shut down soon afterward.
These always seem to be on https://github.com/coronalabs/corona/blob/master/platform/windows/Corona.Native.Library.Win32/Rtt/Rtt_WinTimer.cpp#L78, suggesting that the timer object has been destroyed and the memory there is bogus.
I confirmed that Stop() was being called, so this seemed strange.
The KillTimer docs (https://docs.microsoft.com/en-us/windows/win32/api/winuser/nf-winuser-killtimer) mention for the second parameter that it "must be the same as the nIDEvent value passed to SetTimer." so I thought https://github.com/coronalabs/corona/blob/master/platform/windows/Corona.Native.Library.Win32/Rtt/Rtt_WinTimer.cpp#L61 just needed to be changed to ::KillTimer(fWindowHandle, (UINT_PTR)this);.
The issue still occurs even with that "correction", though, so I'm a bit stumped. 😄

Curiously, the timer class is mostly replicated over in the network library. Among the differences is an ID -> timer map, whose entry is wiped in Stop() and then checked in the callback.
It would not surprise me at all if that was to account for this very problem; I'll give this a try.

I've since submitted a fix.


Feat/validators maj

TODO:

Write one function that validates the block and all the transactions
Test all the code with blocks
Fix DB issues in miner


HHH-17789 fix the blob/clob/nclob not free caused hana memory issue

https://hibernate.atlassian.net/browse/HHH-17789

Thanks @beikov. Last thing @gaogaodepanpan, please squash the code-style commit so that we have a single one and we can merge this, thanks!

Hi @mbladel, It seems this PR is ready to merge, you will help to merge this to main right?


RUM-6375: Force single core for session replay

What does this PR do?
Allow session replay to run only one core at once, otherwise send telemetry.
Motivation
It doesn't make sense for session replay to run on multiple cores.
Additional Notes
Anything else we should know when reviewing?
Review checklist (to be filled by reviewers)

[ ] Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
[ ] Make sure you discussed the feature or bugfix with the maintaining team in an Issue
[ ] Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 70.39%. Comparing base (774c798) to head (4fbbd96).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2324      +/-   ##
===========================================
- Coverage    70.41%   70.39%   -0.02%
===========================================
  Files          739      739
  Lines        27536    27544       +8
  Branches      4614     4616       +2
===========================================
  Hits         19388    19388
- Misses        6866     6867       +1
- Partials      1282     1289       +7

Files with missing lines
Coverage Δ

...com/datadog/android/sessionreplay/SessionReplay.kt
68.57% <100.00%> (+9.31%)
:arrow_up:

... and 33 files with indirect coverage changes


How could I run multiple containers from single docker-compose.yml definition?

Dockerspec Version
0.5.0
Ruby Version
2.5.3
Platform Details
MacOS
Scenario
Steps to Reproduce
handler.rb
require 'json'
 def hello(event:, context:)
  { statusCode: 200, body: JSON.generate('Hello Ruby!') }
end

def check_environment(event:, context:)
  { statusCode: 200, body: ENV.inspect }
end

docker-compose.yml:
version: '3'
services:
  # Closely replicated lambda environment
  lambda:
    image: lambci/lambda:ruby2.5
    volumes:
      # Mount whole project
      - .:/var/task
    networks:
      default:

  # Local mocked services
  ## AWS S3
  s3:
    build:
      context: mocks/s3/
    ports:
      - 8000
    networks:
      default:
        aliases:
          - bucket.local-s3

networks:
  default:

spec/lambda_spec.rb:
require 'dockerspec/serverspec'

COMPOSE_YML = File.expand_path(File.join(__FILE__, "../../docker-compose.yml"))
raise(Exception, "Missing docker-compose file: #{COMPOSE_YML}") unless File.exists? COMPOSE_YML

describe docker_compose(COMPOSE_YML) do
  describe 'Running docker-compose.yml with services' do
    # Start mocked s3 server
    its_container(:s3, family: 'debian') do
      its(:stdout, retry: 60) { should include 'Server is listening' }
      describe process('node') do
        it { should be_running }
      end
    end

    its_container(:lambda) do
      describe command('handler.hello'), retry: 1 do # disable retries here
        its(:stdout) { should include 'Hello Ruby!' }
        its(:stderr) { should eq '' }
      end

      describe command('handler.check_environment', environment: { HELLO: 'RUBY'}), retry: 1 do # disable retries here
        its(:stdout) { should include '"HELLO"=>"RUBY"' }
        its(:stderr) { should eq '' }
      end
    end
  end
end

Expected Result
I know that this doesn't work. I'm willing to contribute on this feature but I'm in need of feedback.
How would you enhance this gem so that I could do multiple runs like these:
$ docker-compose run --rm lambda handler.hello
$ docker-compose run --rm -e HELLO=RUBY lambda handler.check_environment

Actual Result
Currently it just fails because the lambda container stops immediately:
$ bundle exec rspec spec/lambda_spec.rb

Serverspec on file: "......../docker-compose.yml"
  Running docker-compose.yml with services
    "lambda" container
      Command "handler.hello"
        stdout
          example at ./spec/lambda_spec.rb:18 (FAILED - 1)
Failures:

  1) Serverspec on file: "........../docker-compose.yml" Running docker-compose.yml with services "lambda" container Command "handler.hello" stdout
     Failure/Error: its(:stdout) { should include 'Hello Ruby!' }
     Docker::Error::ConflictError:
       Container d6aa793121d1357fbf7ab12e018a925d1208c96ca427b94a4ecf87d63ac5900d is not running

So the current way runs something similiar to docker-compose exec service-name. I would want to use something like this docker-compose --rm run service-name multiple times.
I know you must be busy but I would want to support this feature financially as well.

Something like this would be awesome:
with_service(:lambda) do
  describe run('handler.hello'), retry: 1 do # disable retries here
    its(:stdout) { should include 'Hello Ruby!' }
    its(:stderr) { should eq '' }
  end

  describe run('handler.check_environment', environment: { HELLO: 'RUBY'}), retry: 1 do # disable retries here
    its(:stdout) { should include '"HELLO"=>"RUBY"' }
    its(:stderr) { should eq '' }
  end
end

Which would run something similiar to:
$ docker-compose run --rm lambda handler.hello
$ docker-compose run -e HELLO=RUBY --rm lambda handler.check_enviroment

And I already did initial support for docker-compose.yml version 3 into docker-compose-api gem:
https://github.com/mauricioklein/docker-compose-api/pulls
I'm just not sure how to pass the contexts correctly inside dockerspec.


npm package version not updated - current latest is 1.3.0

Can we please update the npm registry when the next release comes so bower and npm are sync'd to the latest (release) package?
Thanks!

https://www.npmjs.com/package/localforage shows the latest version at 1.3.3, published a few weeks ago. Try checking again and if you can't install a new version feel free to re-open the issue.


Adds sidebar toggles for notifications/reader

Fixes #2674 by surfacing context menu options for Notifications/Reader View.

@brentsimmons
Checkmarks added in 62ed749.
It also posts a notification when webfeed preferences are updated from the context menu, which the Inspector observes, to keep the Inspector in sync.

https://user-images.githubusercontent.com/7046652/106543950-b7735280-6541-11eb-82bf-07360dea00e3.mov

Don't merge this just yet. I'm going to update it so that the sidebar check for notifications being authorised.

Fixed in aa0a5d2


Added configuration for calendar orientation Fixes ThasianX/ElegantCalendar#6

Amazing stuff man! Not bad for your first pull request. I created a new pull request based off of your changes and merged those changes into master. I made a few edits like making the yearly calendar scroll horizontally as well. You can take a look at the diff in there to learn a few things. Let me know if you have any more questions. And thanks for contributing!


Testing setup (dependencies and github actions)

Lets start slow and just run an empty test set.
Starting to address #167

Testing setup is working on my fork:
https://github.com/sergioisidoro/shynet-genisys/pull/1
Looks good to merge and start adding tests :)


Inspect use of unsafe functions in network packages

By history and convention, Haskell library functions have used the prefix 'unsafe' to indicate unsafe functions.  However, it is not always clear what is meant by 'unsafe'.  In what follows, we discriminate between up to four definitions for 'unsafe':

unsafe(1): Using this function could break the type-safety of the  language, i.e., break the memory model of the language, cause a crash and/or undefined behavior. E.g., operations we might do with a pointer; or e.g.,  unsafePerformIO mimicking unsafe "polymorphic references".
unsafe(2): Using this function could break equational reasoning for the program.  E.g., unsafePerformIO causing indeterminate side-effects.
unsafe(3).: Using this function could raise an unexpected runtime exception.  E.g., divide by zero, unmatched patterns, etc.
unsafe(4).: Some user defined property or implicit property of the program might be broken.  E.g., the monad laws could be violated; e.g., unsafeShiftL; e.g., an intended module abstraction is being broken; e.g., some preconditions on user code may not hold and thus code could give "wrong" (that is unexpected) results.

Assuming the code is following the naming convention, we can grep for "unsafe" to find potentially suspicious code. Grepping gives just five general cases in the code:

A. Use of unsafeNoThunks (from the nothunks package): This function is possibly unsafe(2) as it can allow for code to observe the evaluation state of Haskell expressions.  But the uses here in
ouroboros-network/src/Ouroboros/Network/PeerSelection/PeerMetric.hs
ouroboros-network/src/Ouroboros/Network/TxSubmission/Inbound.hs

all follow one of these two desirable patterns for avoiding space leaks:
 newTVarWithInvariant (\a -> show <$> unsafeNoThunks a) ...
 checkInvariant (show <$> unsafeNoThunks st) (f st) ...

where we use functions from the strict-checked-vars package (from the cardano-base repo) to immediately throw exceptions when values are thunks.

B. The import of Test.QuickCheck.Gen.Unsafe "Unsafe combinators for the Gen monad" in
ouroboros-network-testing/src/Ouroboros/Network/Testing/QuickCheck.hs

This is only unsafe(4), and at worst allows the user to break the monad abstraction of Gen.

C. The use of Socket.unsafeFdSocket in ouroboros-network-framework/src/Ouroboros/Network/Snocket.hs
This could be unsafe(3).  This function is used by these two exported functions:
socketFileDescriptor
localSocketFileDescriptor

Note

The first function is dead in the repo, as well as in the cardano-node and ouroboros-consensus repos.
The second function is used, but currently is only used to create tracer datatypes. For all practical purposes this is safe (1-4); although there's no guarantee that some /very evil code/ won't take the FileDescriptor integer from the Trace datatype and use it to create an OS call!
Although ouroboros-network-framework/src/Ouroboros/Network/Snocket.hs has this comment:-- | We use 'unsafeFdSocket' but 'FileDescriptor' constructor is not exposed.
-- This forbids any usage of 'FileDescriptor' (at least in a straightforward
-- way) using any low level functions which operate on file
-- descriptors.

The comment isn't true, 'FileDescriptor' is exported, to be used in test/simulation code!  We refactor the code to fix this unfortunate situation in this #4664

D. The use of FT.unsafeFmap in ouroboros-network-api/src/Ouroboros/Network/AnchoredSeq.hs
could possibly be unsafe(3) or unsafe(4).  A few notes here

This use of FT.unsafeFmap is rather complicated and subtle.
It appears that if this code was used incorrectly, the Priority Queue implementation would be incorrect---unsafe(4).
However, the FT.unsafeFmap is only used (transitively) bybimapPreservingMeasure, mapPreservingMeasure

which are both dead in this repo as well as in the cardano-node and ouroboros-consensus repos.
Recommendations: add some QuickCheck properties here; add assertions.

E. UnsafeNormalisedId in Simulation/Network/Snocket.hs is a constructor for a local datatype.  This is only unsafe(4) as the datatype is intended to satisfy an invariant not enforced by the constructor (but is enforced by a normalizeId smart constructor; it could be helpful to rename this to "UnNormalizedId" to alleviate any doubts regarding safe(1,2,3).


fix: Investigate removing the dependency on pandas

The only use of pandas in this package it to read a csv (in channelcatalog.py1). Instead, the built-in csv module could be used. E.g. https://medium.com/@AIWatson/how-to-read-csv-files-in-python-without-pandas-b693fc7ea3b7

Pandas is required for the stats2inv_mseed function in the package. Therefore, we'll maintain pandas import for this purpose. Closing the issue.


External Initiator for Klaytn

External Initiator for Klaytn.
subscribe API in Klaytn works similar with eth's. It is different from eth that klaytn uses 'klay' instead of 'eth' in method.
If you are subscribing something other than Log, it could have different struct from eth's. (e.g. Structs such as Headers are different.)
I've tested Klaytn EI with chainlink node and  attaching to Klaytn testnet (Baobab)
: https://github.com/winnie-byun/demo-klaytn-chainlink

@winnie-byun Hello! I've been assigned to review the Klatyn EI implementation. After a first look, here's some feedback so we can get your PR merged!

It seems like you based the klatyn.go file from the eth.go file which is a good start. There are some functions in creating the filter query and parsing the event logs that would be needed to make it work with our on-chain smart contracts (example from the BSC initiator).

Creating the filter query: https://github.com/smartcontractkit/external-initiator/blob/master/blockchain/binance-smart-chain.go#L27
Parsing: https://github.com/smartcontractkit/external-initiator/blob/master/blockchain/binance-smart-chain.go#L133

Make sure all the integration tests run successfully. They can be run with instructions in the root readme
There also seems to be some linting errors, these can usually be solved with go fmt
Also, please rebase so the latest changes are included

Thanks!

@aalu1418 I changed the code like the BSC initiator and rebased.
The code is already go fmted.
I tested that with a chainlink core and it runs with no error. I will update after I tested with klaytn chainlink adapter.
Please take a look.

Requested changes will be addressed in a separate PR


Marshmallow support

Doesn't seem to work on marshmallow on version 10.43.60

yes, dont work on xposed framework v77, nexus 4, minimalOS based on cm, 6.0 marshmallow

Yes, doesn't work on 10.43.60, marshmallow, cm13

Yes, it only works in 10.40.58 or later.
So I installed this version of Youtube:
http://www.apkmirror.com/apk/google-inc/youtube/youtube-10-40-58-480dpi-android-4-0-3-5-1-1-android-apk-download/
And it worked.
Print: http://imgur.com/4XT2irw

Are there any difference on that version compaired to the current?

No I think, both have google cardboard support (the lastest "new" update of youtube).

Guys,
10.43.62 is supported!
Grab it here:
http://www.apkmirror.com/?s=Youtube&post_type=apps_post

esgie, we cant install this youtube version - its only to max 5.1... we need version for 6.0+

10.45.52 has been released.
Unfortunately there was some major code changes and it needs a further investigation,
@iHelp101
Your help is priceless - can you help this time? :)
The first hook should has below values I guess:
"lns", "b", "f", "e"
But atm I cannot really find the proper way of enabling the second hook - the code in the class "jff" seems to changed ENTIRELY.
And I keep getting "audio error" only :(

@andreglud
@Skyloud
Can you test below build against 10.43.60 on Marshmallow:
http://www17.zippyshare.com/v/bBmVLNYF/file.html
Note that 10.45.52 which has been released today is NOT YET supported!!!

@esgie working! thanks :) nexus 4, minimalOS based on cm, android 6.0 marshmallow


setup-hooks: separate-debug-info.sh: Remove extraneous local variable…

Oops... this certainly can't be merged directly to master.  Right now it contains commits missing in there and that would confuse the GitHub UI, but that should be resolved within six hours.

Looks good to me


⭐ | Add a dockerfile

I've added a dockerfile to easy build & run the bot 😉

Hey! Thanks for your contribution - however I'm least likely interested to add more unnecessary bloat in the basic template.
We could indeed add this dockerfile as an example in our documentation and I'll do that for sure!


modelize_property: Remove an unreachable case

Exploit the De Morgan’s law.
Signed-off-by: Jean-Christophe Beaupré<EMAIL_ADDRESS>

♻

[x] Use the is_new variable to simplify another line of code.

♻

[x] Undo a change to fix a bug related to nullables.

Looks like you had a bad fall this spring.
— Sierra Entertainement


[Metircs] Added Sensitivity and Specificity. Added pos_labels param.

What does this PR do?

Added Sensitivity and Specificity (useful for medical projects).
Added pos_labels param (#4791).

See if you are interested. If so, I will add tests and the corresponding doc updates.
Fixes # (issue)
Before submitting

[ ] Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
[ ] Did you read the contributor guideline, Pull Request section?
[ ] Did you make sure your PR does only one thing, instead of bundling different changes together? Otherwise, we ask you to create a separate PR for every change.
[ ] Did you make sure to update the documentation with your changes?
[ ] Did you write any new necessary tests?
[ ] Did you verify new and existing tests pass locally with your changes?
[ ] If you made a notable change (that affects users), did you update the CHANGELOG?

PR review
Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

[ ] Is this pull request ready for review? (if not, please submit in draft mode)
[ ] Check that all items from Before submitting are resolved
[ ] Make sure the title is self-explanatory and the description concisely explains the PR
[ ] Add labels and milestones (and optionally projects) to the PR so it can be classified; Bugfixes should be including in bug-fix release milestones (m.f.X) and features should be included in (m.X.b) releases.

Did you have fun?
Make sure you had fun coding 🙃

Hello @shijianjian! Thanks for opening this PR.

In the file pytorch_lightning/metrics/utils.py:

Line 180:26: W292 no newline at end of file

Do see the Hitchhiker's guide to code style

@shijianjian mind resolve conflicts so can let it land? :]
cc: @SkafteNicki @justusschock

@shijianjian, aren't sensitivity and recall same? or is there any difference when it comes to medical applications?

@shijianjian, aren't sensitivity and recall same? or is there any difference when it comes to medical applications?

Yes, they are the same. So that the sensitivity is an alias to recall in the code.
If lightning does not mean to make all alias available, I think it is better to use naming system like TPR, TNR instead.

@shijianjian I don't think aliases are necessary since in the docs it is mentioned how a specific metric is calculated.

@shijianjian what about updating the documentation of recall such that it states something like: "...also known as sensitivity or true positive rate..."?

@shijianjian what about updating the documentation of recall such that it states something like: "...also known as sensitivity or true positive rate..."?

Yes, we can update the doc for that.
If so, my suggestion is to use TPR, TNR, PPV instead of Recall, Specificity and Precision since they are not in the same naming system. I feel like we are mixing concepts up.

In my personal opinion, most of the people would know the terms precision, recall, specificity better than PPV, TPR, TNR. So, I think it would be better to add those terms to the documentation like @SkafteNicki said.

Specificity is essentially Recall with pos_label==0.
If you want to remove the alias, I think specificity can also be removed in that case.  The only problem is that it will not make sense semantically since it will count true_positives and conditional_positives  internally, which might confuse some users.

@shijianjian so is the fix to include the pos_label arg in Recall and then it can do everything that the sensitivity and specificity metrics you have also included?

@shijianjian so is the fix to include the pos_label arg in Recall and then it can do everything that the sensitivity and specificity metrics you have also included?

Yes. To maximumly reduce the complexity, from the functionality perspective, a recall with pos_label would be sufficient.
Though I would suggest to have ~Sensitivity = Recall~ and
Class Specificity(Recall):
    def __init__(self, ..., pos_label=0):
        ...

@shijianjian so is the fix to include the pos_label arg in Recall and then it can do everything that the sensitivity and specificity metrics you have also included?

Yes. To maximumly reduce the complexity, from the functionality perspective, a recall with pos_label would be sufficient.
Though I would suggest to have ~Sensitivity = Recall~ and
Class Specificity(Recall):
    def __init__(self, ..., pos_label=0):
        ...

I am completely fine with that. It is very similar to how we have subclass FBeta into F1 because it is a very commonly used metric.

@shijianjian mind resolve conflicts so we can proceed further? 🐰

@shijianjian mind resolve conflicts so we can proceed further? 🐰

No problem. Will do it this week.

No problem. Will do it this week.

Hey @shijianjian,
Would you mind resolving conflicts ?
Best,
TC

Hey @shijianjian,
Would you mind resolving conflicts ?
Best,
TC

@shijianjian how is it going here? :]

@shijianjian how is it going here? :]

Hi guys, sorry for the delay. We are busy finalizing lots of stuff due to the Chinese New Year. Also, those conflicts are introducing deprecations with some behaviour changes. It is not an easy merging. I will rewrite this part according to the new changes by 10th Feb (holiday period).

Will prob need a rebase to feature branch as well? @Borda

Thank you for this valuable feature

Hi @shijianjian, we are very happy that you decided to improve PL and opened this PR.
Never the less we have moved the metric package outside PT, to a separate repository - torchmetrics, and unfortunately, there is not GH option to transfer your opened PR there to finish the job there. So I would like to kindly ask you if you are able to finish this PR by end of this week and then we can transfer your merged commit to the new repo or please open the very same PR in the new repository... 🐰
Anyway thank you very much for being with us ⚡

It has already been finished at least three times, but conflicts are coming up very quickly ahead of the review. I would say it might be easier to copy and paste the code from this PR to a new PR in the new repo.

@shijianjian I fully understand your frustration with fast changes which raises conflicts...
As we already started the deprecation here in PL it would be even more difficult to finish adding a new metric here, may I kindly ask you to reopen the very same PR in torchmetrics (the reason is to preserve you as the contribution author) and I promise to help you to finish it there :]
So pls, open PR in TM with the very same content and refer to this PL PR 🐰


update release note

@yualan : Thanks for your contribution! The author, @stevestein, has been notified to review your proposed change.


Log when a connection to the database is closed

Currently the Query Engine (via Prisma Client) only logs the creation of the connection pool after startup and when a connection is created (vs. taken as existing from the connection pool) - but not when it is closed. This makes it hard to observe the behavior of the Query Engine and the connection pool.
We should log every time a connection is closed.

If @pimeys has capacity at some point, I would like to pair on this issue.

This would be a bit easier if we define the conditions. We do not close connections, but connections can get stale and dropped when they start giving errors. Logging a dropped connection should then happen in the connection pool crate (mobc) or even deeper in the database crates.

$disconnect does not close a connection?

Yeah, it tears down the whole engine, so naturally we also disconnect. Implementing some logging might or might not include adding the feature to the database crates... And then of course logging it there.


Add support for '.' in C# namespaces

First PR for highlight.js, please let me know anything that could be done better or that you'd like changed for whatever reason. (For example, this is a tiny change and I'm happy to omit the edit to AUTHORS.en.txt.) Without this edit, C# code that includes a dotted namespace (as in the example file) is not recognized as C#.

Thanks, merged!


⚠ Processors has degraded performance

In c9c519c, Processors ($STATUS_URL) experienced degraded performance:

HTTP code: 200
Response time: 58 ms

Resolved: Processors performance has improved in 46c9ea4.


Allow decimal numbers to omit leading zero

the expression of numbers is consistent with JSON where a digit before the radix is required.
e.g. 0.123 is valid, while .123 is not valid.
Whereas in openformula, .123 is valid.
We should allow numbers without the leading digit.

fixed


No layers for League of Legends

What are you experiencing an issue with?

[ ] Aurora
[ ] Aurora supported game, (Fill in the game)
[ ] Aurora Wrapper
[ ] Aurora Profile
[ ] Aurora supported device, (Fill in problematic devices)
[ ] Aurora Scripts
[ ] Aurora Updater
[x ] Aurora Lighting issue
[ ] Other, (Fill in another issue here)

What kind of an issue is it?

[ ] Crash
[ ] Performance problems
[ ] Visual bug
[x ] Localization issue
[ ] Enhancement suggestion
[ ] Device issue
[ ] Other, (Fill in another type of issue here)

Expected behavior:
League of legends should provide current values for HP, mana, etc. for layer creation
Actual behavior:
Values for LoL not available. Other games don't show this issue.
How often does this problem occur?

Please describe the steps to reproduce this issue:
The issue can be reproduced by doing following steps:

What is the version of Aurora you are experiencing this issue with?

My version is... (Fill in here)
Does the previous version of Aurora have this issue?
The previous version, (Fill in the version here), did/did not have this issue.
Please include any logs, screenshots, or files that are related to this issue:

For logs, you can use: http://pastebin.com/
For screenshots, you can use: http://imgur.com/
For files, you can use: http://www.tinyupload.com/ , https://www.dropbox.com/ , or attach them to the issue.

We cannot get the information from League of Legends, the LightFX patch that is mentioned in the League of Legends overview is used to pipe the lighting effects that the game usually sends to the Alienware devices through Aurora. Therefore we cannot get exact data for the information that is displayed on the keyboard.


chore(CI): fix "auto-update" Jenkins job

The job is currently failing, because the Node.js version used in not compatible with some of our dependencies (e.g. Protractor).
The added jenkins.sh script is going to be executed by https://ci.angularjs.org/job/angular-phonecat auto-update/.

After merging this, we should update https://ci.angularjs.org/job/angular-phonecat auto-update/ to use run scripts/private/jenkins.sh.
/cc @petebacondarwin

I fear that this will also fall foul of the fact that nvm install returns an error code if the version is already installed

@petebacondarwin, I copied the nvm stuff from ng1's jenkins scripts. How come it works there?

Well let's give it a go, eh?

Landed with tweaks: https://ci.angularjs.org/job/angular-phonecat auto-update/18634/console

(Merged as 6b930ac.)


MySQL Environment Variables: DB_SCHEME='mysql' twice

Is some content missing, wrong or not clear?
In the MySQL Environment Variables, DB_SCHEME='mysql'  is listed twice twice.
Describe the solution you'd like
This seems to be an error as YML files have it only ones. For some this might be obvious, but if someone is just trying - it might be confusing.
Additional context
Add any other context or screenshots about the feature request here.

@joeshajan assigned to you.


Add missing ESLint rules

Coverage remained the same at 100.0% when pulling 91274b727e865ffa54f566124514b48012aebbab on update-missing-rules into 8bcd56b739636867389049cbbc6e0c48ea771f09 on master.


Fix maxMessageSize validation in StandardMessageDispatcher

maxDeviceMessageSize field accepts random integer values, should only accept 0 or the minimum packet size(300) bytes

closing this and deferring .


Appstudio update test-component-pac-dxnr

Pipelines as Code configuration proposal

Pipelines as Code CI/test-component-pac-dxnr-on-pull-request has successfully validated your commit.

StatusDurationName

✅ Succeeded
6 seconds
init

✅ Succeeded
18 seconds
clone-repository

✅ Succeeded
1 minute
build-container

✅ Succeeded
16 seconds
inspect-image

✅ Succeeded
1 minute
deprecated-base-image-check

✅ Succeeded
3 minutes
clair-scan

✅ Succeeded
33 seconds
clamav-scan

✅ Succeeded
10 seconds
sbom-json-check

✅ Succeeded
1 minute
label-check

✅ Succeeded
1 minute
optional-label-check

✅ Succeeded
6 seconds
show-summary


Everything relating to the ID scalar should be moved outside of the Relay namespace

Is your feature request related to a problem? Please describe.
Currently everything, but the IdType, like the IDAttribute or the ID() descriptor extensions live in the Relay namespace.
This doesn't make sense to me, as the ID scalar and its requirement for uniqueness are part of the GraphQL specification and not something Relay specific.
Describe the solution you'd like
I would like to extract the following things out of the Relay namespace:

RelayIdFieldExtensions (should be just IdFieldExtensions going forward)
GlobalIdInputValueFormatter
IdMiddleware
IdSerializationException
IdSerializer
IdValue
IIdSerializer

As the wish to extract the Relay specific functionality into a separate package came up recently, I think this would be a good change to perform, when the new package is introduced.

The ID behavior is not specified in the spec. It is rather more about semantics in there.

GraphQL is agnostic to ID format, and serializes to string to ensure consistency across many formats ID could represent, from small auto‐increment numbers, to large 128‐bit random numbers, to base64 encoded values, or string values of a format like GUID.

Regarding to the spec the ID format could be quite a range of things. Only the relay spec defines that it has to be encoded and that there is a node field and stuff like that. The IDAttribute and ID extension add the relay ID specific serializer to any field and by thus do not allow the field to be all that the spec would allow.
The IDAttribute represents the implementation of the ID behavior represented by the relay spec.
However, maybe we should rename these to be GlobalIdAttribute and GlobalId to make that more clear.
@benmccallum what are your thoughts on that?

Regarding uniqueness, the relay spec lays out a very specific way to format the ID and a very specific way to make keys unique. This is essentially the main benefit these helpers introduce.

Yes, I think [GlobalId] makes the connection to AddGlobalObjectIdentification more clear.
But something like [ID] should also stay in my opinion, as a shorthand for [GraphQLType(typeof(IdType))]. It having the same name is likely going to cause issues with people migrating though, so I'm not sure how we could go about it. Maybe [IdField]?

I think given that the ID scalar is defined in the GraphQL spec, it should stay in the namespace it currently is.
I agree with Michael that the Relay-specific way of implementing that ID stays in a Relay-specific namespace/package. Conceptually it's like ID: String! is the contract, and AddGlobalObjectIdentification is registering the Relay implementation.
I would be in favour of a rename of IDAttribute to GlobalIdAttribute since Global Id seems to be the terminology in Relay and it'd make more sense with the AddGlobalObjectIdentification definitely.
In terms of keeping ID, I'd say it's dropped for v12 entirely, and in the breaking changes notes we make a note that if you were using it just for typing to a scalar, here's a simple IDAttribute to do that, and whack in a sample as it's pretty easy. But it's really just a find and replace. Keeping it in a way that just types to ID would be a mistake IMO, at least for a few more major versions, as people would assume their code is working if it compiles but not realize the attribute no longer applies all the relay middleware that some folks would need.
Sorry Tobias :P Interesting discussion though.
I now regret calling our library AutoGuru.HotChocolate.PolymorphicIds when the spec uses the word "coercion" which is much clearer. D'oh!

@benmccallum Thanks for the input :)
I'll go ahead and create a new issue for the GlobalId part and close this one.
Just to make sure I understood your point about the ID correctly: You'd like to remove it entirely and make a note to either use the GlobalId or a tutorial on how to create an attribute as shorthand for the IdType?

I just meant if rename it to GlobalIdAttribute, we should not keep an IDAttribute that behaves differently (e.g. just sets the type) at least for a few major versions.
I'm not sure if people are using the attribute just for the type setting, but we could just show them how to do that in a code example in the breaking changes docs. Basically
... descriptor.Type<IdType>();
}```

If they wanted that convenience. I think it's too risky doing that ourselves for a while. We could do an IdAttribute I guess :P

On my phone :p

Basically let's rename it for sure.
And optionally show people how to make an attribute that sets the type only if someone finds that useful.


Added HTML code to application

This PR adds all of the HTML we need for the prework study guide application.

Conflicts resolve.

test comment


Convert the docs website to a Progressive Web App

ISSUE / FEATURE REQUEST:
We could convert the website to a PWA (Progressive web app) by providing an "Add to Homescreen" button, which when clicked, can add  it to our home screen to be read whenever needed.

Yes, I'd like to take this issue up and work on it.

Can you elaborate on what value this will add to the user experience?
Also, if you are looking for Hacktoberfest projects, the to-do apps repo might be of more interest to you: https://github.com/cockroachdb/cockroachdb-todo-apps

It might not add much to the user experience, but since a PWA also works offline, the docs can be read by the user whenever they want and also since PWAs have access to a user's phone's push notifications, it can lead to higher reach.
Talking about the to-do repo, yeah I've looked into it. I'll start working on it soon😊

Users can bookmark the site and access it when they need it. Not sure we need an app that pushes notifications to drive readership to the docs -- we don't want to spam the users.

OK cool then. I'll work on the to-do app👍

Closing this issue for now!


Automating the coverage update

@michalk8 , did you get round to this yet?

Done via #188 - there was some unknown error, if it persists (I've issued a small fix), I wll create a new issue.

Code coverage is shown as 0 now...

It means it at least runs, will debug it tomorrow.

I can't seem to pinpoint the source of the error - I went through this, it seems fine: https://github.com/theislab/cellrank/runs/791304725?check_suite_focus=true.

mhm, I'm also unsure. I checked on codecov, our coverage went to 0 on June 20th. Something about the github action is not quite working yet....

Maybe the token fixes this problem, otherwise, I would consider opening an issue on the repo: https://github.com/codecov/codecov-action

Done, because I don't know how to fix this. Here's the link: https://github.com/codecov/codecov-action/issues/85.

Thanks Mike

Hackily fixed via https://github.com/theislab/cellrank/commit/69be28e86b72e2e3da1949ef450bb38cab9c865a
Uploader is the problem, when running under GitHub Actions.

Wow, I'm impressed!


GLTF import on html5

Godot version
3.4.2
System information
Manjaro-latest, i5-4210, geforce 920m
Issue description
I have been following past issues, proposals, and details on enabling the PackedSceneGLTF for importing gltf on runtime. It works on the editor and a custom export template on native platforms, but not on web. available plugins/modules also don't support web. I have tried both compiling and using prebuilt version through gdnative export of HTML5 with no luck of it working. I also tried custom export template with module_gltf=yes flag with no luck there either (taken from a repo's instruction).
I was wondering if I'm missing something or is the web a problem as web editor does work fine.
Steps to reproduce

get the source of godot
compile with scons platform=javascript target=release debug_symbols=no tools=no module_gltf=yes -j8 use_lto=yes use_llvm=yes module_arkit_enabled=no module_mobile_vr_enabled=no module_csg_enabled=no
open a new project, add some gltf files and import them through:

func _ready():
	var path = "res://assets/HUB.glb"
	var gltf = PackedSceneGLTF.new()
	var model = gltf.import_gltf_scene(path)
        add_child(model)

export the project with the custom built export template
run a local server and open it in the browser

Minimal reproduction project
No response

@fire

I remember it was slow on the editor build.

https://github.com/SIsilicon/Godot-Web-File-Manager
https://editor.godotengine.org/releases/latest/

Please do not open issues for discussions you've already opened: https://github.com/godotengine/godot-proposals/discussions/4038
Export templates do not feature glTF import functionality (or import functionality in general), regardless of the platform. Editor binaries however do feature glTF import functionality, also regardless of the platform.
It's not possible to backport run-time glTF loading to Godot 3.x, as it relies on backwards-incompatible changes.


More options for huskchat

can you add a setting to define a server that uses "normal" chat because I have plugins that use "normal" minecraft chat and they don't work now. or something that fixes this issue.
Example with quickshop:

when I put chat message: "1" it doesn't do anything
(I already asked that for quickshop authors about it and they said this:

please contact its author, we just handle and cancel chat event currently, nothing wrong in our side)

Link for quickshop authors reply: https://github.com/PotatoCraft-Studio/QuickShop-Reremake/discussions/383#discussion-5410969

HuskChat is a proxy plugin and won't work with backend plugins by default.
Relevant documentation, which explains why this is the case, and provides examples of how you can work around this: https://william278.net/docs/huskchat/backend-chat-entry


Support/optimization for 16-bit floating point?

According to the MXNet.jl documentation:

There is no generics in NDArray, the eltype is always mx.MX_float. Because for applications in machine learning, single precision floating point numbers are typical a best choice balancing between precision, speed and portability. Also since libmxnet is designed to support multiple languages as front-ends, it is much simpler to implement with a fixed data type.

If I understand correctly, MXNet currently cannot take advantage of the 2x half-precision performance of the upcoming NVidia Pascal-based cards. Is this correct? If so, are there plans to add the ability to leverage this feature in the future?

python package does support fp16. julia package doesn't

@novog I am currently working on supporting this https://github.com/dmlc/MXNet.jl/pull/97. I hope to have this ready in the coming weeks.

Good to hear, thanks!


pytest --help  error log could not load initial conftests

run
`
ubuntu@ubuntu-OptiPlex-7050:/home/shared/disk/zephyr_project/twister$ pytest --help
usage: pytest [options] [file_or_dir] [file_or_dir] [...]
positional arguments:
file_or_dir
general:
-k EXPRESSION         only run tests which match the given substring expression. An expression is a python evaluatable expression where all names are substring-matched against test names and their parent classes. Example: -k
'test_method or test_other' matches all test functions and classes whose name contains 'test_method' or 'test_other', while -k 'not test_method' matches those that don't contain 'test_method' in their names. -k
'not test_method and not test_other' will eliminate the matches. Additionally keywords are matched to classes and functions containing extra names in their 'extra_keyword_matches' set, as well as functions which
have names assigned directly to them. The matching is case-insensitive.
-m MARKEXPR           only run tests matching given mark expression.
For example: -m 'mark1 and not mark2'.
--markers             show markers (builtin, plugin and per-project ones).
-x, --exitfirst       exit instantly on first error or failed test.
--fixtures, --funcargs
show available fixtures, sorted by plugin appearance (fixtures with leading '_' are only shown with '-v')
--fixtures-per-test   show fixtures per test
--pdb                 start the interactive Python debugger on errors or KeyboardInterrupt.
--pdbcls=modulename:classname
specify a custom interactive Python debugger for use with --pdb.For example: --pdbcls=IPython.terminal.debugger:TerminalPdb
--trace               Immediately break when running each test.
--capture=method      per-test capturing method: one of fd|sys|no|tee-sys.
-s                    shortcut for --capture=no.
--runxfail            report the results of xfail tests as if they were not marked
--lf, --last-failed   rerun only the tests that failed at the last run (or all if none failed)
--ff, --failed-first  run all tests, but run the last failures first.
This may re-order tests and thus lead to repeated fixture setup/teardown.
--nf, --new-first     run tests from new files first, then the rest of the tests sorted by file mtime
--cache-show=[CACHESHOW]
show cache contents, don't perform collection or tests. Optional argument: glob (default: '*').
--cache-clear         remove all cache contents at start of test run.
--lfnf={all,none}, --last-failed-no-failures={all,none}
which tests to run with no previously (known) failures.
--sw, --stepwise      exit on test failure and continue from last failing test next time
--sw-skip, --stepwise-skip
ignore the first failing test but stop on the next failing test.
implicitly enables --stepwise.
reporting:
--durations=N         show N slowest setup/test durations (N=0 for all).
--durations-min=N     Minimal duration in seconds for inclusion in slowest list. Default 0.005
-v, --verbose         increase verbosity.
--no-header           disable header
--no-summary          disable summary
-q, --quiet           decrease verbosity.
--verbosity=VERBOSE   set verbosity. Default is 0.
-r chars              show extra test summary info as specified by chars: (f)ailed, (E)rror, (s)kipped, (x)failed, (X)passed, (p)assed, (P)assed with output, (a)ll except passed (p/P), or (A)ll. (w)arnings are enabled by default (see
--disable-warnings), 'N' can be used to reset the list. (default: 'fE').
--disable-warnings, --disable-pytest-warnings
disable warnings summary
-l, --showlocals      show locals in tracebacks (disabled by default).
--tb=style            traceback print mode (auto/long/short/line/native/no).
--show-capture={no,stdout,stderr,log,all}
Controls how captured stdout/stderr/log is shown on failed tests. Default is 'all'.
--full-trace          don't cut any tracebacks (default is to cut).
--color=color         color terminal output (yes/no/auto).
--code-highlight={yes,no}
Whether code should be highlighted (only if --color is also enabled)
--pastebin=mode       send failed|all info to bpaste.net pastebin service.
--junit-xml=path      create junit-xml style report file at given path.
--junit-prefix=str    prepend prefix to classnames in junit-xml output
pytest-warnings:
-W PYTHONWARNINGS, --pythonwarnings=PYTHONWARNINGS
set which warnings to report, see -W option of python itself.
--maxfail=num         exit after first num failures or errors.
--strict-config       any warnings encountered while parsing the pytest section of the configuration file raise errors.
--strict-markers      markers not registered in the markers section of the configuration file raise errors.
--strict              (deprecated) alias to --strict-markers.
-c file               load configuration from file instead of trying to locate one of the implicit configuration files.
--continue-on-collection-errors
Force test execution even if collection errors occur.
--rootdir=ROOTDIR     Define root directory for tests. Can be relative path: 'root_dir', './root_dir', 'root_dir/another_dir/'; absolute path: '/home/user/root_dir'; path with variables: '$HOME/root_dir'.
collection:
--collect-only, --co  only collect tests, don't execute them.
--pyargs              try to interpret all arguments as python packages.
--ignore=path         ignore path during collection (multi-allowed).
--ignore-glob=path    ignore path pattern during collection (multi-allowed).
--deselect=nodeid_prefix
deselect item (via node id prefix) during collection (multi-allowed).
--confcutdir=dir      only load conftest.py's relative to specified dir.
--noconftest          Don't load any conftest.py files.
--keep-duplicates     Keep duplicate tests.
--collect-in-virtualenv
Don't ignore tests in a local virtualenv directory
--import-mode={prepend,append,importlib}
prepend/append to sys.path when importing test modules and conftest files, default is to prepend.
--doctest-modules     run doctests in all .py modules
--doctest-report={none,cdiff,ndiff,udiff,only_first_failure}
choose another output format for diffs on doctest failure
--doctest-glob=pat    doctests file matching pattern, default: test*.txt
--doctest-ignore-import-errors
ignore doctest ImportErrors
--doctest-continue-on-failure
for a given doctest, continue to run after the first failure
test session debugging and configuration:
--basetemp=dir        base temporary directory for this test run.(warning: this directory is removed if it exists)
-V, --version         display pytest version and information about plugins. When given twice, also display information about plugins.
-h, --help            show help message and configuration info
-p name               early-load given plugin module name or entry point (multi-allowed).
To avoid loading of plugins, use the no: prefix, e.g. no:doctest.
--trace-config        trace considerations of conftest.py files.
--debug=[DEBUG_FILE_NAME]
store internal tracing debug information in this log file.
This file is opened with 'w' and truncated as a result, care advised.
Defaults to 'pytestdebug.log'.
-o OVERRIDE_INI, --override-ini=OVERRIDE_INI
override ini option with "option=value" style, e.g. -o xfail_strict=True -o cache_dir=cache.
--assert=MODE         Control assertion debugging tools.
'plain' performs no assertion debugging.
'rewrite' (the default) rewrites assert statements in test modules on import to provide assert expression information.
--setup-only          only setup fixtures, do not execute tests.
--setup-show          show setup of fixtures while executing tests.
--setup-plan          show what fixtures and tests would be executed but don't execute anything.
logging:
--log-level=LEVEL     level of messages to catch/display.
Not set by default, so it depends on the root/parent log handler's effective level, where it is "WARNING" by default.
--log-format=LOG_FORMAT
log format as used by the logging module.
--log-date-format=LOG_DATE_FORMAT
log date format as used by the logging module.
--log-cli-level=LOG_CLI_LEVEL
cli logging level.
--log-cli-format=LOG_CLI_FORMAT
log format as used by the logging module.
--log-cli-date-format=LOG_CLI_DATE_FORMAT
log date format as used by the logging module.
--log-file=LOG_FILE   path to a file when logging will be written to.
--log-file-level=LOG_FILE_LEVEL
log file logging level.
--log-file-format=LOG_FILE_FORMAT
log format as used by the logging module.
--log-file-date-format=LOG_FILE_DATE_FORMAT
log date format as used by the logging module.
--log-auto-indent=LOG_AUTO_INDENT
Auto-indent multiline messages passed to the logging module. Accepts true|on, false|off or an integer.
[pytest] ini-options in the first pytest.ini|tox.ini|setup.cfg file found:
markers (linelist):   markers for test functions
empty_parameter_set_mark (string):
default marker for empty parametersets
norecursedirs (args): directory patterns to avoid for recursion
testpaths (args):     directories to search for tests when no files or directories are given in the command line.
filterwarnings (linelist):
Each line specifies a pattern for warnings.filterwarnings. Processed after -W/--pythonwarnings.
usefixtures (args):   list of default fixtures to be used with this project
python_files (args):  glob-style file patterns for Python test module discovery
python_classes (args):
prefixes or glob names for Python test class discovery
python_functions (args):
prefixes or glob names for Python test function and method discovery
disable_test_id_escaping_and_forfeit_all_rights_to_community_support (bool):
disable string escape non-ascii characters, might cause unwanted side effects(use at your own risk)
console_output_style (string):
console output: "classic", or with additional progress information ("progress" (percentage) | "count").
xfail_strict (bool):  default for the strict parameter of xfail markers when not given explicitly (default: False)
enable_assertion_pass_hook (bool):
Enables the pytest_assertion_pass hook.Make sure to delete any previously generated pyc cache files.
junit_suite_name (string):
Test suite name for JUnit report
junit_logging (string):
Write captured log messages to JUnit report: one of no|log|system-out|system-err|out-err|all
junit_log_passing_tests (bool):
Capture log information for passing tests to JUnit report:
junit_duration_report (string):
Duration time to report: one of total|call
junit_family (string):
Emit XML for schema: one of legacy|xunit1|xunit2
doctest_optionflags (args):
option flags for doctests
doctest_encoding (string):
encoding used for doctest files
cache_dir (string):   cache directory path.
log_level (string):   default value for --log-level
log_format (string):  default value for --log-format
log_date_format (string):
default value for --log-date-format
log_cli (bool):       enable log display during test run (also known as "live logging").
log_cli_level (string):
default value for --log-cli-level
log_cli_format (string):
default value for --log-cli-format
log_cli_date_format (string):
default value for --log-cli-date-format
log_file (string):    default value for --log-file
log_file_level (string):
default value for --log-file-level
log_file_format (string):
default value for --log-file-format
log_file_date_format (string):
default value for --log-file-date-format
log_auto_indent (string):
default value for --log-auto-indent
pythonpath (paths):   Add paths to sys.path
faulthandler_timeout (string):
Dump the traceback of all threads if a test takes more than TIMEOUT seconds to finish.
addopts (args):       extra command line options
minversion (string):  minimally required pytest version
required_plugins (args):
plugins that must be present for pytest to run
environment variables:
PYTEST_ADDOPTS           extra command line options
PYTEST_PLUGINS           comma-separated plugins to load during startup
PYTEST_DISABLE_PLUGIN_AUTOLOAD set to disable plugin auto-loading
PYTEST_DEBUG             set to enable debug tracing of pytest's internals
to see available markers type: pytest --markers
to see available fixtures type: pytest --fixtures
(shown according to specified file_or_dir or current dir if not specified; fixtures with leading '_' are only shown with the '-v' option
warning : /home/ubuntu/.local/lib/python3.10/site-packages/_pytest/config/init.py:1214: PytestConfigWarning: could not load initial conftests: /home/shared/disk/zephyr_project/twister/tests/conftest.py
self.issue_config_time_warning(
`

I find I need run  pip install twisterv2 to solve this, but looks like it is not documented

Thanks for looking into the plugin. I am guessing what is your problem, since it is hard to figure it out from output of pytest --help. Do you mean that twister is not among options in help? What you're reporting is desired functionality. We have addopts = -p no:twister in tox.ini https://github.com/zephyrproject-rtos/twister/blob/main/tox.ini#L38 This means that when you call pytest from twister folder it won't add twister plugin. This was done on purpose so our unit tests can run in the CI environment, where zephyr is not present. You can find a bit more background at this issue #138
I will open a PR explaining that the plugin is not loaded when calling from twister dir. We assumed most users will install it from the repository and won't even checkout the github repo and wouldn't see this isssue. I will close this issue when that readme PR is merged. Does this address your issue?

Thanks for looking into the plugin. I am guessing what is your problem, since it is hard to figure it out from output of pytest --help. Do you mean that twister is not among options in help? What you're reporting is desired functionality. We have addopts = -p no:twister in tox.ini https://github.com/zephyrproject-rtos/twister/blob/main/tox.ini#L38 This means that when you call pytest from twister folder it won't add twister plugin. This was done on purpose so our unit tests can run in the CI environment, where zephyr is not present. You can find a bit more background at this issue #138 I will open a PR explaining that the plugin is not loaded when calling from twister dir. We assumed most users will install it from the repository and won't even checkout the github repo and wouldn't see this isssue. I will close this issue when that readme PR is merged. Does this address your issue?

Thanks @PerMac , I suggest the readme need to be revised, and give detailed step by step, to avoid any misuage


Update README.md

Coverage remained the same at 94.74% when pulling 2f93ec831859db5870e29bfa4eccf80ca435f923 on phodal:patch-1 into 5d5a878da7e938f7cd33891f6e81ddd15b29c21e on un33k:master.


Update toc.yml

Fixes #13395

Probably. I'll do that in another PR

That's just a toc.yml change, I should have done it in the PR. - Right?

Right.  But a separate one is fine too.


Unify  _up_ref methods returned type

Related to a discussion in #818 .
Add  status return value for some of them without it.
Update the docs.
Are this PR compatible with API freeze cut-off ?

thanks! +1 and will merge after another review.

Rebased on today HEAD, it builds OK.
Just need one more review.

Probably needs a CHANGES entry. As this is only return value changes I think this is ok to go in??

Docs updated.
This change don't value one more CHANGES entry, IMHO.
But if you insist...

Updates look fine, but I do think a CHANGES entry is warranted. The reason is that it is a change to an existing API which is likely to go unnoticed if we don't draw attention to it.

Looks fine to me.  @mattcaswell?

Subject to the nit being fixed I can +1 this. @richsalz there's been a few changes since you added the "reviewed" label. Can you reconfirm this?

Wholeheartedly yes, +1 remains.

+1

Ping @mattcaswell : is it ok for you ?

Merged.


wrong json created for AWS::Logs::Destination

logs.Destination doesnt generate the correct json CloudFormation expects since its sublcassing the wrong thing. should be AWSObject instead of AWSProperty
attempting to create the stack throws this exception
botocore.exceptions.ClientError: An error occurred (ValidationError) when calling the CreateStack operation: Invalid template resource property 'DestinationName'

bad json output
"MyLogDestination": {
    "DestinationName": "destination-name",
    "DestinationPolicy": "destination-policy-arn",
    "RoleArn": "role-arn",
    "TargetArn": "target-arn",
    "Type": "AWS::Logs::Destination"
}

according to the docs, the output should look like this:
"MyLogDestination": {
    "Properties": {
        "DestinationName": "destination-name",
        "DestinationPolicy": "destination-policy-arn",
        "RoleArn": "role-arn",
        "TargetArn": "target-arn"
    },
    "Type": "AWS::Logs::Destination"
}

Thanks. I pushed a fix at about the same time you did. :-)


Password Policies Parameter

When setting the password to expire for a specific user, what are some of the parameters that we can use except -PasswordPolicies None? Can we set number of days for example 90 or 100 etc?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: f52c6916-7e79-9a9c-b7a6-47041ddb81e3
Version Independent ID: 43c9b873-d354-d814-3065-1e8832361b86
Content: Set an individual user's password to never expire - Microsoft 365 admin
Content Source: microsoft-365/admin/add-users/set-password-to-never-expire.md
Service: o365-administration
GitHub Login: @cmcatee-MSFT
Microsoft Alias: cmcatee

@M88X Thank you for your feedback. The other parameters that we can use for -PasswordPolicies are

DisablePasswordExpiration
DisableStrongPassword (Allows weaker passwords than the default policy to be specified)

However, for a password to expire in a certain number of days you need to use the Set-MsolPasswordPolicy cmdlet which updates the password policy of a specified domain or tenant.
Example 1: Update validity period and notification for the current domain
PS C:> Set-MsolPasswordPolicy -ValidityPeriod 60 -NotificationDays 14
This command updates the tenant so that all user's passwords expire after 60 days. The users receive notification 14 days prior to that expiry.
Example 2: Update validity period and notification for a domain
PS C:> Set-MsolPasswordPolicy -ValidityPeriod 60 -NotificationDays 14 -DomainName "contoso.com"
This command updates the policy on the domain contoso.com so that users' passwords expire after 60 days. The users receive notification 14 days prior to that expiry.
You can find more information about this cmdlet at https://docs.microsoft.com/en-us/powershell/module/msonline/set-msolpasswordpolicy?view=azureadps-1.0
Hope this helps!
@yogkumgit There is no changes needed in the document and the issue can be closed.
Thanks
Sri

@msbemba Thank you very much for the contribution and sharing this explanation. @M88X Hope this comment is helpful for you. If you see a documentation update is required, please feel free to open an issue for the same. We proceed here to close it. Thanks for taking out some time to open the issue. Appreciate and encourage you to do the same in future also.


Scripts for Gentoo

Hi
I use Gentoo and OpenRC (init.d) so I had to modify the install and init scripts, both for loraserver and lora-app-server. Is there any interest/need for them? If so, where I can send them?
Note that I could test them on OpenRC only. The Systemd variant is present but I don't have an equivalent Gentoo to test them.

Great you got it working on Gentoo :-) I'm a bit reserved in adding these to the repository, as I don't have experience with using Gentoo, and it means I need to maintain these scripts too. However I think the forum could be a great place to post these scripts and share how you did your setup (Setup and configuration category): https://forum.loraserver.io. Thanks in advance!


[RunequestGQS] fails to render

Only code displays since last committ on Chrome and Firefox
relevant screenshot:
https://pasteboard.co/J96OkCC.png

Some extra tags seemed to have gotten added to the front of the file .  These have no effect in a custom sheet or sandbox but do seem to have an effect in the live system
I have uploaded a fix to remove this but I doubt they would  merge any pull request  this week.  I have asked about getting a rollback.

@LechPsztyk you could edit this issue to state the name of the sheet [RunequestGQS], so others also notice this.
For others who find this Issue, more info can be found in this forum thread: https://app.roll20.net/forum/post/8695053/runequest-character-sheet-issues

Done, and thank you for quick reply

This sheet was fixed today(I tested), so this issue can now be closed: https://app.roll20.net/forum/post/8703742/release-note-for-may-21-2020-hotfix

Fixed, Thank you