chore(deps): update node.js to v20

This PR contains the following updates:

Package
Type
Update
Change

node
final
major
18.16.1-alpine3.17 -> 20.3.1-alpine3.17

node
stage
major
18.16.1-alpine3.17 -> 20.3.1-alpine3.17

Release Notes

nodejs/node
v20.3.1: 2023-06-20, Version 20.3.1 (Current), @RafaelGSS
Compare Source
This is a security release.
Notable Changes
The following CVEs are fixed in this release:

CVE-2023-30581: mainModule.__proto__ Bypass Experimental Policy Mechanism (High)
CVE-2023-30584: Path Traversal Bypass in Experimental Permission Model (High)
CVE-2023-30587: Bypass of Experimental Permission Model via Node.js Inspector (High)
CVE-2023-30582: Inadequate Permission Model Allows Unauthorized File Watching (Medium)
CVE-2023-30583: Bypass of Experimental Permission Model via fs.openAsBlob() (Medium)
CVE-2023-30585: Privilege escalation via Malicious Registry Key manipulation during Node.js installer repair process (Medium)
CVE-2023-30586: Bypass of Experimental Permission Model via Arbitrary OpenSSL Engines (Medium)
CVE-2023-30588: Process interuption due to invalid Public Key information in x509 certificates (Medium)
CVE-2023-30589: HTTP Request Smuggling via Empty headers separated by CR (Medium)
CVE-2023-30590: DiffieHellman does not generate keys after setting a private key (Medium)
OpenSSL Security Releases

OpenSSL security advisory 28th March.
OpenSSL security advisory 20th April.
OpenSSL security advisory 30th May

More detailed information on each of the vulnerabilities can be found in June 2023 Security Releases blog post.
Commits

[dac08dafc9] - crypto: handle cert with invalid SPKI gracefully (Tobias Nießen) nodejs-private/node-private#393
[d274c3babc] - crypto,https,tls: disable engines if perms enabled (Tobias Nießen) nodejs-private/node-private#409
[5621c1de38] - deps: update archs files for openssl-3.0.9-quic1 (Node.js GitHub Bot) #48402
[771caa9f1c] - deps: upgrade openssl sources to quictls/openssl-3.0.9-quic1 (Node.js GitHub Bot) #48402
[0459bf9c99] - doc,test: clarify behavior of DH generateKeys (Tobias Nießen) nodejs-private/node-private#426
[27e20501aa] - http: disable request smuggling via empty headers (Paolo Insogna) nodejs-private/node-private#427
[9c17e335f1] - msi: do not create AppData\Roaming\npm (Tobias Nießen) nodejs-private/node-private#408
[b51124c637] - permission: handle fs path traversal (RafaelGSS) nodejs-private/node-private#403
[ebc5927adc] - permission: handle fs.openAsBlob (RafaelGSS) nodejs-private/node-private#405
[c39a43bff5] - permission: handle fs.watchFile (RafaelGSS) nodejs-private/node-private#404
[d0a8264ec9] - policy: handle mainModule.__proto__ bypass (RafaelGSS) nodejs-private/node-private#416
[3df13d5a79] - src,permission: restrict inspector when pm enabled (RafaelGSS) nodejs-private/node-private#410

v20.3.0: 2023-06-08, Version 20.3.0 (Current), @targos
Compare Source
Notable Changes

[bfcb3d1d9a] - deps: upgrade to libuv 1.45.0, including significant performance improvements to file system operations on Linux (Santiago Gimeno) #48078
[5094d1b292] - doc: add Ruy Adorno to list of TSC members (Michael Dawson) #48172
[2f5dbca690] - doc: mark Node.js 14 as End-of-Life (Richard Lau) #48023
[b1828b325e] - (SEMVER-MINOR) lib: implement AbortSignal.any() (Chemi Atlow) #47821
[f380953103] - module: change default resolver to not throw on unknown scheme (Gil Tayar) #47824
[a94f87ed99] - (SEMVER-MINOR) node-api: define version 9 (Chengzhong Wu) #48151
[9e2b13dfa7] - stream: deprecate asIndexedPairs (Chemi Atlow) #48102

Commits

[35c96156d1] - benchmark: use cluster.isPrimary instead of cluster.isMaster (Deokjin Kim) #48002
[3e6e3abf32] - bootstrap: throw ERR_NOT_SUPPORTED_IN_SNAPSHOT in unsupported operation (Joyee Cheung) #47887
[c480559347] - bootstrap: put is_building_snapshot state in IsolateData (Joyee Cheung) #47887
[50c0a15535] - build: set v8_enable_webassembly=false when lite mode is enabled (Cheng Shao) #48248
[4562805cf6] - build: speed up compilation of mksnapshot output (Keyhan Vakil) #48162
[8b89f13933] - build: add action to close stale PRs (Michael Dawson) #48051
[5d92202220] - build: replace js2c.py with js2c.cc (Joyee Cheung) #46997
[6cf2adc36e] - cluster: use ObjectPrototypeHasOwnProperty (Daeyeon Jeong) #48141
[f564b03c38] - crypto: use openssl's own memory BIOs in crypto_context.cc (GauriSpears) #47160
[ac8dd61fc3] - crypto: remove default encoding from cipher (Tobias Nießen) #47998
[15c2de4407] - crypto: fix setEngine() when OPENSSL_NO_ENGINE set (Tobias Nießen) #47977
[9e2dd5b5e2] - deps: update zlib to 337322d (Node.js GitHub Bot) #48218
[bfcb3d1d9a] - deps: upgrade to libuv 1.45.0 (Santiago Gimeno) #48078
[13930f092f] - deps: update ada to 2.5.0 (Node.js GitHub Bot) #48223
[3047caebec] - deps: set CARES_RANDOM_FILE for c-ares (Richard Lau) #48156
[0db79a0872] - deps: update histogram 0.11.8 (Marco Ippolito) #47742
[99af6716f5] - deps: update histogram to 0.11.7 (Marco Ippolito) #47742
[d4922bc985] - deps: update c-ares to 1.19.1 (Node.js GitHub Bot) #48115
[f6ccdb289f] - deps: update simdutf to 3.2.12 (Node.js GitHub Bot) #48118
[3ed0afc778] - deps: update minimatch to 9.0.1 (Node.js GitHub Bot) #48094
[df7540fb73] - deps: update ada to 2.4.2 (Node.js GitHub Bot) #48092
[07df5c48e8] - deps: update corepack to 0.18.0 (Node.js GitHub Bot) #48091
[d95a5bb559] - deps: update uvwasi to 0.0.18 (Node.js GitHub Bot) #47866
[443477e041] - deps: update uvwasi to 0.0.17 (Node.js GitHub Bot) #47866
[03f67d6d6d] - deps: upgrade npm to 9.6.7 (npm team) #48062
[d3e3a911fd] - deps: update nghttp2 to 1.53.0 (Node.js GitHub Bot) #47997
[f7c4daaf67] - deps: update ada to 2.4.1 (Node.js GitHub Bot) #48036
[c6a752560d] - deps: add loongarch64 into openssl Makefile and gen openssl-loongarch64 (Shi Pujin) #46401
[d194241716] - deps: update undici to 5.22.1 (Node.js GitHub Bot) #47994
[02e919f4a2] - deps,test: update postject to 1.0.0-alpha.6 (Node.js GitHub Bot) #48072
[2c19f596ad] - doc: clarify array args to Buffer.from() (Bryan English) #48274
[d681e5f456] - doc: document watch option for node:test run() (Moshe Atlow) #48256
[96e54ddbca] - doc: reserve 117 for Electron 26 (Calvin) #48245
[9aff8c7818] - doc: update documentation for FIPS support (Richard Lau) #48194
[8c5338648f] - doc: improve the documentation of the stdio option (Kumar Arnav) #48110
[11918d705f] - doc: update Buffer.allocUnsafe description (sinkhaha) #48183
[2b51ee5e22] - doc: update codeowners with website team (Claudio Wunder) #48197
[360df25d04] - doc: fix broken link to new folder doc/contributing/maintaining (Andrea Fassina) #48205
[13e95e21a4] - doc: add atlowChemi to triagers (Chemi Atlow) #48104
[5f83ce530f] - doc: fix typo in readline completer function section (Vadym) #48188
[3c82165d27] - doc: remove broken link for keygen (Rich Trott) #48176
[0ca90a1e6d] - doc: add auto intrinsic height to prevent jitter/flicker (Daniel Holbert) #48195
[f117855092] - doc: add version info on the SEA docs (Antoine du Hamel) #48173
[5094d1b292] - doc: add Ruy to list of TSC members (Michael Dawson) #48172
[39d8140227] - doc: update socket.remote* properties documentation (Saba Kharanauli) #48139
[5497c13efe] - doc: update outdated section on TLSv1.3-PSK (Tobias Nießen) #48123
[281dfaf727] - doc: improve HMAC key recommendations (Tobias Nießen) #48121
[bd311b6c70] - doc: clarify mkdir() recursive behavior (Stephen Odogwu) #48109
[5b061c8922] - doc: fix typo in crypto legacy streams API section (Tobias Nießen) #48122
[10ccb2bd81] - doc: update SEA source link (Rich Trott) #48080
[415bf7f532] - doc: clarify tty.isRaw (Roberto Vidal) #48055
[0ac4b33c76] - doc: correct line break for Windows terminals (Alex Schwartz) #48083
[f30ba5c320] - doc: fix Windows code snippet tags (Antoine du Hamel) #48100
[12fef9b68c] - doc: harmonize fenced code snippet flags (Antoine du Hamel) #48082
[13f163eace] - doc: use secure key length for HMAC generateKey (Tobias Nießen) #48052
[1e3e7c9f33] - doc: update broken EVP_BytesToKey link (Rich Trott) #48064
[5917ba1838] - doc: update broken spkac link (Rich Trott) #48063
[0e4a3b7db1] - doc: document node-api version process (Chengzhong Wu) #47972
[85bbaa94ea] - doc: update process.versions properties (Saba Kharanauli) #48019
[7660eb591a] - doc: fix typo in binding functions (Deokjin Kim) #48003
[2f5dbca690] - doc: mark Node.js 14 as End-of-Life (Richard Lau) #48023
[3b94a739f2] - doc: clarify CRYPTO_CUSTOM_ENGINE_NOT_SUPPORTED (Tobias Nießen) #47976
[9e381cfa89] - doc: add heading for permission model limitations (Tobias Nießen) #47989
[802db923e0] - doc,vm: clarify usage of cachedData in vm.compileFunction() (Darshan Sen) #48193
[11a3434810] - esm: remove support for arrays in import internal method (Antoine du Hamel) #48296
[3b00f3afef] - esm: handle globalPreload hook returning a nullish value (Antoine du Hamel) #48249
[3c7846d7e1] - esm: handle more error types thrown from the loader thread (Antoine du Hamel) #48247
[60ce2bcabc] - http: send implicit headers on HEAD with no body (Matteo Collina) #48108
[72de4e7170] - lib: do not disable linter for entire files (Antoine du Hamel) #48299
[10cc60fc91] - lib: use existing isWindows variable (sinkhaha) #48134
[a90010aae9] - lib: support FORCE_COLOR for non TTY streams (Moshe Atlow) #48034
[b1828b325e] - (SEMVER-MINOR) lib: implement AbortSignal.any() (Chemi Atlow) #47821
[8f1b86961f] - meta: bump github/codeql-action from 2.3.3 to 2.3.6 (dependabot[bot]) #48287
[1b87ccdf70] - meta: bump actions/setup-python from 4.6.0 to 4.6.1 (dependabot[bot]) #48286
[10715aea26] - meta: bump codecov/codecov-action from 3.1.3 to 3.1.4 (dependabot[bot]) #48285
[79f73778ab] - meta: remove dont-land-on-v14 auto labeling (Shrujal Shah) #48031
[9c5711f3ea] - meta: move one or more collaborators to emeritus (Node.js GitHub Bot) #48010
[6d6bf3ee52] - module: reduce the number of URL initializations (Yagiz Nizipli) #48272
[f380953103] - module: change default resolver to not throw on unknown scheme (Gil Tayar) #47824
[950185b0c0] - net: fix address iteration with autoSelectFamily (Fedor Indutny) #48258
[5ddca72e62] - net: fix family autoselection SSL connection handling (Paolo Insogna) #48189
[750e53ca3c] - net: fix family autoselection timeout handling (Paolo Insogna) #47860
[a94f87ed99] - (SEMVER-MINOR) node-api: define version 9 (Chengzhong Wu) #48151
[e834979818] - node-api: add status napi_cannot_run_js (Gabriel Schulhof) #47986
[eafe0c3ec6] - node-api: napi_ref on all types is experimental (Vladimir Morozov) #47975
[9a034746f5] - src: add Realm document in the src README.md (Chengzhong Wu) #47932
[b8f4070f71] - src: check node_extra_ca_certs after openssl cfg (Raghu Saxena) #48159
[0347a18056] - src: include missing header in node_sea.h (Joyee Cheung) #48152
[45c3782c20] - src: remove INT_MAX asserts in SecretKeyGenTraits (Tobias Nießen) #48053
[b25e7045ad] - src: avoid prototype access in binding templates (Joyee Cheung) #47913
[33aa373eec] - src: use Blob{Des|S}erializer for SEA blobs (Joyee Cheung) #47962
[9e2b13dfa7] - stream: deprecate asIndexedPairs (Chemi Atlow) #48102
[96c323dee2] - test: mark test-child-process-pipe-dataflow as flaky (Moshe Atlow) #48334
[9875885357] - test: adapt tests for OpenSSL 3.1 (OttoHollmann) #47859
[3440d7c6bf] - test: unflake test-vm-timeout-escape-nexttick (Santiago Gimeno) #48078
[215b2bc72c] - test: fix zlib version regex (Luigi Pinca) #48227
[e12ee59d26] - test: use lower security level in s_client (Luigi Pinca) #48192
[1dabc7390c] - Revert "test: unskip negative-settimeout.any.js WPT" (Filip Skokan) #48182
[c1c4796a86] - test: mark test_cannot_run_js as flaky (Keyhan Vakil) #48181
[8c49d74002] - test: fix flaky test-runner-watch-mode (Moshe Atlow) #48144
[6388766862] - test: skip test-http-pipeline-flood on IBM i (Abdirahim Musse) #48048
[8d2a3b1952] - test: ignore helper files in WPTs (Filip Skokan) #48079
[7a96d825fd] - test: move test-cluster-primary-error flaky test (Yagiz Nizipli) #48039
[a80dd3a8b3] - test: fix suite signal (Benjamin Gruenbaum) #47800
[a41cfd183f] - test: fix parsing test flags (Daeyeon Jeong) #48012
[4d4e506f2b] - test,doc,sea: run SEA tests on ppc64 (Darshan Sen) #48111
[44411fc40c] - test_runner: apply runOnly on suites (Moshe Atlow) #48279
[3f259b7a30] - test_runner: emit test:watch:drained event (Moshe Atlow) #48259
[c9f8e8c562] - test_runner: stop watch mode when abortSignal aborted (Moshe Atlow) #48259
[f3268d64cb] - test_runner: fix global after hook (Moshe Atlow) #48231
[15336c3139] - test_runner: remove redundant check from coverage (Colin Ihrig) #48070
[750d3e8606] - test_runner: pass FORCE_COLOR to child process (Moshe Atlow) #48057
[3278542243] - test_runner: dont split lines on test:stdout (Moshe Atlow) #48057
[027c531766] - test_runner: fix test deserialize edge cases (Moshe Atlow) #48106
[2b797a6d39] - test_runner: delegate stderr and stdout formatting to reporter (Shiba) #48045
[23d310bee8] - test_runner: display dot report as wide as the terminal width (Raz Luvaton) #48038
[fd2620dcf1] - tls: reapply servername on happy eyeballs connect (Fedor Indutny) #48255
[62f847d0b3] - tools: update rollup lint-md-dependencies (Node.js GitHub Bot) #48329
[3e97826a66] - Revert "tools: open issue when update workflow fails" (Marco Ippolito) #48312
[5f08bfe35f] - tools: don't gitignore base64 config.h (Ben Noordhuis) #48174
[ded0e2d755] - tools: update LICENSE and license-builder.sh (Santiago Gimeno) #48078
[07aa264366] - tools: automate histogram update (Marco Ippolito) #48171
[1416b75eaa] - tools: use shasum instead of sha256sum (Luigi Pinca) #48229
[b81e9d9b7b] - tools: harmonize dep_updaters scripts (Antoine du Hamel) #48201
[a60bc41e53] - tools: deps update authenticate github api request (Andrea Fassina) #48200
[7478ed014e] - tools: order dependency jobs alphabetically (Luca) #48184
[568a705799] - tools: refactor v8_pch config (Michaël Zasso) #47364
[801573ba46] - tools: log and verify sha256sum (Andrea Fassina) #48088
[db62325e18] - tools: open issue when update workflow fails (Marco Ippolito) #48018
[ad8a68856d] - tools: alphabetize CODEOWNERS (Rich Trott) #48124
[4cf5a9edaf] - tools: use latest upstream commit for zlib updates (Andrea Fassina) #48054
[8d93af381b] - tools: add security-wg as dep updaters owner (Marco Ippolito) #48113
[5325be1d99] - tools: port js2c.py to C++ (Joyee Cheung) #46997
[6c60d90277] - tools: fix race condition when npm installing (Tobias Nießen) #48101
[0ab840a58f] - tools: refloat 7 Node.js patches to cpplint.py (Rich Trott) #48098
[a298193378] - tools: update cpplint to 1.6.1 (Yagiz Nizipli) #48098
[f6725751b7] - tools: update eslint to 8.41.0 (Node.js GitHub Bot) #48097
[6539361f4e] - tools: update lint-md-dependencies (Node.js GitHub Bot) #48096
[5d94dbb951] - tools: update doc to<EMAIL_ADDRESS>(Node.js GitHub Bot) #48095
[2226088048] - tools: add debug logs (Marco Ippolito) #48060
[0c8c383583] - tools: fix zconf.h path (Luigi Pinca) #48089
[6adaf4c648] - tools: update remark-preset-lint-node to 4.0.0 (Node.js GitHub Bot) #47995
[92b3334231] - url: clean vertical alignment of docs (Robin Ury) #48037
[ebb6536775] - url: call ada::can_parse directly (Yagiz Nizipli) #47919
[ed4514294a] - vm: properly handle defining symbol props (Nicolas DUBIEN) #47572

v20.2.0: 2023-05-16, Version 20.2.0 (Current), @targos
Compare Source
Notable Changes

[c092df9094] - doc: add ovflowd to collaborators (Claudio Wunder) #47844
[4197a9a5a0] - (SEMVER-MINOR) http: prevent writing to the body when not allowed by HTTP spec (Gerrard Lindsay) #47732
[c4596b9ce7] - (SEMVER-MINOR) sea: add option to disable the experimental SEA warning (Darshan Sen) #47588
[17befe008c] - (SEMVER-MINOR) test_runner: add skip, todo, and only shorthands to test (Chemi Atlow) #47909
[a0634d7f89] - (SEMVER-MINOR) url: add value argument to URLSearchParams has and delete methods (Sankalp Shubham) #47885

Commits

[456fca0d9c] - bootstrap: initialize per-isolate properties of bindings separately (Joyee Cheung) #47768
[d6d12bf978] - bootstrap: log isolate data info in mksnapshot debug logs (Joyee Cheung) #47768
[e457d89a1b] - buffer: combine checking range of sourceStart in buf.copy (Deokjin Kim) #47758
[00668fcfb4] - child_process: use signal.reason in child process abort (Debadree Chatterjee) #47817
[d7993474ea] - crypto: remove default encoding from scrypt (Tobias Nießen) #47943
[09fb74a7cc] - crypto: fix webcrypto private/secret import with empty usages (Filip Skokan) #47877
[e9c6ee74f3] - crypto: remove default encoding from pbkdf2 (Tobias Nießen) #47869
[b7f13a8679] - deps: update simdutf to 3.2.9 (Node.js GitHub Bot) #47983
[b16f6da153] - deps: V8: cherry-pick 5f025d1 (Michaël Zasso) #47610
[99f8fcab45] - deps: V8: cherry-pick a8a11a8 (Michaël Zasso) #47610
[c2b14b4c78] - deps: update ada to 2.4.0 (Node.js GitHub Bot) #47922
[cad42e7a56] - deps: V8: cherry-pick 1b471b7 (Lu Yahan) #47399
[7b2f17ca59] - deps: upgrade npm to 9.6.6 (npm team) #47862
[d23b1af562] - deps: update ada to 2.3.1 (Node.js GitHub Bot) #47893
[72340c98fb] - dgram: convert macro to template (Tobias Nießen) #47891
[9be922892f] - dns: call ada::idna::to_ascii directly from c++ (Yagiz Nizipli) #47920
[4a1e97156a] - doc: add missing deprecated blocks to cluster (Tobias Nießen) #47981
[13118a19ee] - doc: update description of global (Tobias Nießen) #47969
[372796440b] - doc: update measure memory rejection information (Yash Ladha) #41639
[7ecc6740e4] - doc: fix broken link to TC39 import attributes proposal (Rich Trott) #47954
[b9771c95c7] - doc: fix broken link (Rich Trott) #47953
[6f5ba92e61] - doc: remove broken link (Rich Trott) #47942
[c9ffc555f1] - doc: document make lint-md-clean (Matteo Collina) #47926
[7ed99e8ba5] - doc: mark global object as legacy (Mert Can Altın) #47819
[bf39f2d252] - doc: ntfs junction points must link to directories (Ben Noordhuis) #47907
[4dfc3890d8] - doc: improve permission.has description (Daeyeon Jeong) #47875
[93f1aa2856] - doc: fix params names (Dmitry Semigradsky) #47853
[9a362aa2fb] - doc: update supported version of FreeBSD to 12.4 (Michaël Zasso) #47838
[89c70dc6e6] - doc: add stability experimental to pm (Rafael Gonzaga) #47890
[f96fb2eee7] - doc: swap Matteo with Rafael in the stewards (Rafael Gonzaga) #47841
[1666a146e3] - doc: add valgrind suppression details (Kevin Eady) #47760
[e53e8231ff] - doc: replace EOL versions in README (Tobias Nießen) #47833
[c092df9094] - doc: add ovflowd to collaborators (Claudio Wunder) #47844
[f7106765b3] - doc: update BUILDING.md previous versions links (Tobias Nießen) #47835
[811b43c215] - doc,test: update the v8.startupSnapshot doc and test the example (Joyee Cheung) #47468
[1ec640ac70] - esm: do not use 'beforeExit' on the main thread (Antoine du Hamel) #47964
[106dc612d6] - fs: make readdir recursive algorithm iterative (Ethan Arrowood) #47650
[a0da2348a8] - fs: move fs_use_promises_symbol to per-isolate symbols (Joyee Cheung) #47768
[4197a9a5a0] - (SEMVER-MINOR) http: prevent writing to the body when not allowed by HTTP spec (Gerrard Lindsay) #47732
[a4d6543598] - http2: improve nghttp2 error callback (Tobias Nießen) #47840
[a4fed6c580] - lib: update comment (sinkhaha) #47884
[fd8bec7b2b] - meta: bump step-security/harden-runner from 2.3.1 to 2.4.0 (Rich Trott) #47980
[f5b4b6d5dc] - meta: bump github/codeql-action from 2.3.2 to 2.3.3 (Rich Trott) #47979
[c05c0a2359] - meta: bump actions/setup-python from 4.5.0 to 4.6.0 (Rich Trott) #47968
[2a3d6d97cb] - meta: add security-wg ping to permission.js (Rafael Gonzaga) #47941
[6c158e8dd1] - meta: bump step-security/harden-runner from 2.2.1 to 2.3.1 (dependabot[bot]) #47808
[f7a8094d37] - meta: bump actions/setup-python from 4.5.0 to 4.6.0 (dependabot[bot]) #47806
[0f58e48792] - meta: bump actions/checkout from 3.3.0 to 3.5.2 (dependabot[bot]) #47805
[652b06dd82] - meta: remove extra space in scorecard workflow (Mestery) #47805
[9f06eaccaf] - meta: bump github/codeql-action from 2.2.9 to 2.3.2 (dependabot[bot]) #47809
[977fd7cf35] - meta: bump codecov/codecov-action from 3.1.1 to 3.1.3 (dependabot[bot]) #47807
[c19385c154] - module: refactor to use normalizeRequirableId in the CJS module loader (Darshan Sen) #47896
[739113f2fc] - module: block requiring test/reporters without scheme (Moshe Atlow) #47831
[f489c6710c] - (NODE-API-SEMVER-MAJOR) node-api: get Node API version used by addon (Vladimir Morozov) #45715
[7222f9d74b] - path: indicate index of wrong resolve() parameter (sosoba) #47660
[7dd32f1536] - permission: remove unused function declaration (Deokjin Kim) #47957
[af86625a05] - permission: resolve reference to absolute path only for fs permission (Daeyeon Jeong) #47930
[1625ae11fe] - quic: address recent coverity warning (Michael Dawson) #47753
[c4596b9ce7] - (SEMVER-MINOR) sea: add option to disable the experimental SEA warning (Darshan Sen) #47588
[1a7fc186bc] - sea: allow requiring core modules with the "node:" prefix (Darshan Sen) #47779
[786a1c5398] - src: deduplicate X509Certificate::Fingerprint* (Tobias Nießen) #47978
[060c1d502b] - src: stop copying code cache, part 2 (Keyhan Vakil) #47958
[1aec718619] - (SEMVER-MINOR) src: add cjs_module_lexer_version base64_version (Jithil P Ponnan) #45629
[0c06bfd8dc] - src: move BlobSerializerDeserializer to a separate header file (Darshan Sen) #47933
[bd553e7521] - src: rename SKIP_CHECK_SIZE to SKIP_CHECK_STRLEN (Tobias Nießen) #47845
[190596c189] - src: register external references for source code (Keyhan Vakil) #47055
[4293cc47f4] - src: support V8 experimental shared values in messaging (Shu-yu Guo) #47706
[9bc5d78f0c] - src: register ext reference for Fingerprint512 (Tobias Nießen) #47892
[a11507e23b] - src: stop copying code cache (Keyhan Vakil) #47144
[515c9b8de6] - src: clarify the parameter name in Permission::Apply (Daeyeon Jeong) #47874
[c4217613f5] - src: fix creating an ArrayBuffer from a Blob created with openAsBlob (Daeyeon Jeong) #47691
[4bc17fd67b] - src: avoid strcmp() with Utf8Value (Tobias Nießen) #47827
[d358317f70] - src: get binding data store directly from the realm (Joyee Cheung) #47437
[b04d51a0b5] - src: prefer data accessor of string and vector (Mohammed Keyvanzadeh) #47750
[2952cc576c] - src: add per-isolate SetFastMethod and Set[Fast]MethodNoSideEffect (Joyee Cheung) #47768
[010d2ecf94] - test: mark test-esm-loader-http-imports as flaky (Tobias Nießen) #47987
[bb33c74c07] - test: add getRandomValues return length (Jithil P Ponnan) #46357
[6e019586f7] - test: unskip negative-settimeout.any.js WPT (Filip Skokan) #47946
[8f547afe5f] - test: use appropriate usages for a negative import test (Filip Skokan) #47878
[7e34f77518] - test: fix webcrypto wrap unwrap tests (Filip Skokan) #47876
[30f4f35244] - test: fix output tests when path includes node version (Moshe Atlow) #47843
[54607bfd68] - test: reduce WPT concurrency (Filip Skokan) #47834
[17945a2495] - test: migrate a pseudo_tty test to use assertSnapshot (Moshe Atlow) #47803
[c9233679e8] - test: fix WPT state when process exits but workers are still running (Filip Skokan) #47826
[34bfb69b5b] - test: migrate message tests to use assertSnapshot (Moshe Atlow) #47498
[d25c785c2a] - test: allow SIGBUS in signal-handler abort test (Michaël Zasso) #47851
[aa2c7e00d7] - test,crypto: update WebCryptoAPI WPT (Filip Skokan) #47921
[da27542058] - test_runner: use v8.serialize instead of TAP (Moshe Atlow) #47867
[17befe008c] - (SEMVER-MINOR) test_runner: add shorthands to test (Chemi Atlow) #47909
[42db1d50a0] - test_runner: fix ordering of test hooks (Phil Nash) #47931
[d81c54e3a8] - test_runner: omit inaccessible files from coverage (Colin Ihrig) #47850
[a4e261e910] - tools: debug log for nghttp3 (Marco Ippolito) #47992
[f6ff318d4c] - tools: automate icu-small update (Marco Ippolito) #47727
[706c305381] - tools: update lint-md-dependencies to<EMAIL_ADDRESS>(Node.js GitHub Bot) #47903
[e22c686ca9] - tools: update eslint to 8.40.0 (Node.js GitHub Bot) #47906
[36f7cfac93] - tools: update eslint to 8.39.0 (Node.js GitHub Bot) #47789
[7323902a40] - tools: fix jsdoc lint (Moshe Atlow) #47789
[a0634d7f89] - (SEMVER-MINOR) url: add value argument to has and delete methods (Sankalp Shubham) #47885
[1b06c1e003] - url: improve isURL detection (Yagiz Nizipli) #47886
[2bd869d20c] - vm: fix crash when setting __proto__ on context's globalThis (Feng Yu) #47939
[e6685f9e82] - vm,lib: refactor microtaskQueue assignment logic (Khaidi Chu) #47765
[47fea13dac] - worker: support more cases when (de)serializing errors (Moshe Atlow) #47925
[6f3876c035] - worker: use snapshot in workers spawned by workers (Joyee Cheung) #47731

v20.1.0: 2023-05-03, Version 20.1.0 (Current), @targos
Compare Source
Notable Changes

[5e99598639] - assert: deprecate CallTracker (Moshe Atlow) [#&#8

Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about these updates again.

[ ] If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

@craigyu @RMCampos This is a big enough update we should probably write an issue. That said, it appears to be fine. Opinions?

@craigyu @RMCampos This is a big enough update we should probably write an issue. That said, it appears to be fine. Opinions?

@DerekRoberts This will require us update other packages such as @types/node, any reason why we are moving away from LTS?

@craigyu @RMCampos This is a big enough update we should probably write an issue. That said, it appears to be fine. Opinions?

@DerekRoberts This will require us update other packages such as @types/node, any reason why we are moving away from LTS?

@craigyu v20 becomes the new LTS in October.  It's a good idea to upgrade early.

@DerekRoberts do you prefer another PR to update @types/node or should I push a commit to this one?

@DerekRoberts do you prefer another PR to update @types/node or should I push a commit to this one?

IMO it's easier to see everything in one PR, but this is your call.

Edited/Blocked Notification
Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.
You can manually request rebase by checking the rebase/retry box above.
⚠ Warning: custom changes will be lost.

@DerekRoberts do you prefer another PR to update @types/node or should I push a commit to this one?

IMO it's easier to see everything in one PR, but this is your call.

I will do that

node 20.3 causes this bug:

Related issues:

https://github.com/nodejs/docker-node/issues/1912
https://forums.docker.com/t/getting-error-when-running-container-env-cant-execute-node-text-file-busy/136409

Let's wait for a fix? @DerekRoberts

Good catch @craigyu! Let's close this and worry later. :)

Renovate Ignore Notification
As this PR has been closed unmerged, Renovate will ignore this upgrade and you will not receive PRs for any future 20.x releases. However, if you upgrade to 20.x manually then Renovate will reenable minor and patch updates automatically.
If this PR was closed by mistake or you changed your mind, you can simply rename this PR and you will soon get a fresh replacement PR opened.


ci: remove markdown file bypass

Signed-off-by: Akash Singhal<EMAIL_ADDRESS>Description
What this PR does / why we need it:
The github build workflow currently does not get triggered for Pull Requests that only have changes to markdown files. This then blocks the PR from merging since build-pr is a required check.
This change removes the markdown file bypass.
ORAS CLI repository also does not have a bypass for markdown file. See here: https://github.com/oras-project/oras/blob/a671c16f2dc788699e355dbb2019740ef72f8107/.github/workflows/build.yml#L14
Which issue(s) this PR fixes (optional, using fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when the PR gets merged):
Fixes #
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration
Checklist:

[ ] Does the affected code have corresponding tests?
[ ] Are the changes documented, not just with inline documentation, but also with conceptual documentation such as an overview of a new feature, or task-based documentation like a tutorial? Consider if this change should be announced on your project blog.
[ ] Does this introduce breaking changes that would require an announcement or bumping the major version?
[ ] Do all new files have appropriate license header?

This fix will unblock #477

lgtm, good to know it!


feat: HugrView method for iterating over neighbouring ports

HugrView::neighbour_ports(&self, node: Node, direction: Direction) -> impl Iterator<Item = (Node, Port)> + '_;

Isn't this HugrView::linked_ports ?

no, that takes a single port as input, this takes a node (its a flat map over the linked ports of all the node's ports)


Added variable to skip spec location check

Storage team is blocked for the GA release which depends on a legacy version spec in non-main branch. Service team needs more time to use the latest stable version specs from the main branch of Azure spec repo. As discussed with Scott, we decided to allow the check to be skipped by pipeline variable to unblock the release.

The following pipelines have been queued for testing:java - templatejava - template - testsjs - templatenet - templatenet - template - testspython - templatepython - template - tests You can sign off on the approval gate to test the release stage of each pipeline. See eng/common workflow


VM templating does not work on master

VM templating is not working with master anymore.
kata-runtime factory init will fail.
Expected result
Command returns vm factory initialized
#Actual Result
QMP command failed: Invalid parameter 'bypass-shared-memory'

Moving bug to packaging repo.


Implement basic API functions for Byron-style wallets.

Issue Number
#774 (restoreByronWallet)
#775 (listByronWallets)
#776 (getByronWallet)
#777 (deleteByronWallet)
Overview
This PR implements all API functions apart from those relating to migration.
We have:

[x] Provided an implementation for restoreByronWallet.
[x] Provided an implementation for listByronWallets.
[x] Provided an implementation for getByronWallets.
[x] Provided an implementation for deleteByronWallet.
[x] Fixed existing integration tests for all of the above.

Not included in this PR
Further integration tests: these will be included in further sub-topic PRs.

bors try

bors try

bors try

looks good.

Thanks for reviewing this! :smile:

Integration tests need to be expanded to assert also more for actual response also, not only response code. But this can be done in the next pr.

It was indeed my intention to add more integration tests in further PRs.

bors try

@paweljakubas wrote:

Looks fine to me!
Thanks for looking at this!

bors r+


Basic sample for GORM

As discussed, this is meant to mirror basic-sample.go.
I believe the naming convention here should also apply for ORM samples
that require multiple files, such as Hibernate. A Hibernate sample might
be ZIP'ed and be named hibernate-basic-sample.zip.

This change is

http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/61031dbfd717307dd3881be62f3b2c8810656ea0/

Review status: 0 of 1 files reviewed at latest revision, 4 unresolved discussions.

_includes/app/gorm-basic-sample.go, line 14 at r1 (raw file):

// Account is our model, which corresponds to a database table.
type Account struct {
	ID      int `gorm:"primary_key"`

Do you think we should advertise the gorm.Model convention?

_includes/app/gorm-basic-sample.go, line 22 at r1 (raw file):

	const addr = "postgresql://maxroach@localhost:26257/bank?sslmode=disable"
	db, err := gorm.Open("postgres", addr)
	defer db.Close()

Does GORM advise that you defer db.Close before checking for errors? That's usually an anti-pattern in Go.

Comments from Reviewable

_includes/app/gorm-basic-sample.go, line 14 at r1 (raw file):
Previously, nvanbenschoten (Nathan VanBenschoten) wrote…
Do you think we should advertise the gorm.Model convention?

I think we definitely should, but this can probably be in the context/instructions rather than in the file comments.

Comments from Reviewable

Review status: 0 of 1 files reviewed at latest revision, 4 unresolved discussions.

_includes/app/gorm-basic-sample.go, line 14 at r1 (raw file):
Previously, jseldess wrote…
I think we definitely should, but this can probably be in the context/instructions rather than in the file comments.

Yeah, maybe advertise it in the instructions.  Btw, I chose not to embed gorm.Model, because it forces the calls to db.Create below to look like this rather ugly (and less clear) example:
db.Create(&Account{Model: gorm.Model{ID: 1}, Balance: 1000})

_includes/app/gorm-basic-sample.go, line 22 at r1 (raw file):
Previously, nvanbenschoten (Nathan VanBenschoten) wrote…
Does GORM advise that you defer db.Close before checking for errors? That's usually an anti-pattern in Go.

My oversight. Fixed.

_includes/app/gorm-basic-sample.go, line 27 at r1 (raw file):
Previously, jseldess wrote…
nit: ...the "accounts" table...

Done.

Comments from Reviewable

http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/6c3fabf07b695fa9cf283186eef10f97d005c5de/

LGTM


cleaned unused imports.

Codecov Report

Merging #4733 into master will decrease coverage by <.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #4733      +/-   ##
==========================================
- Coverage   40.43%   40.42%   -0.01%
==========================================
  Files        2575     2575
  Lines       78364    78364
  Branches    10643    10643
==========================================
- Hits        31683    31679       -4
- Misses      43793    43795       +2
- Partials     2888     2890       +2

Impacted Files
Coverage Δ

...http/interceptor/HttpURLConnectionInterceptor.java
0% <ø> (ø)
:arrow_up:

...r/response/DefaultResponseTimeMetricCollector.java
85.71% <0%> (-14.29%)
:arrow_down:

.../profiler/sender/StandbySpanStreamDataStorage.java
72.88% <0%> (-3.39%)
:arrow_down:

...tor/metric/datasource/DefaultDataSourceMetric.java
75% <0%> (-3.13%)
:arrow_down:

...navercorp/pinpoint/rpc/common/SocketStateCode.java
82.92% <0%> (-2.44%)
:arrow_down:

...corp/pinpoint/rpc/stream/StreamChannelManager.java
70.68% <0%> (-1.73%)
:arrow_down:

...java/com/navercorp/pinpoint/rpc/DefaultFuture.java
72.5% <0%> (-1.67%)
:arrow_down:

.../pinpoint/rpc/client/PinpointClientHandshaker.java
65% <0%> (-1.43%)
:arrow_down:

...pinpoint/profiler/monitor/DeadlockMonitorTask.java
18.6% <0%> (-1.17%)
:arrow_down:

...cluster/zookeeper/ZookeeperClusterDataManager.java
64.62% <0%> (-0.69%)
:arrow_down:

... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0c926fe...1c1317f. Read the comment docs.

thanks 👍


create stairs for block, not ingot

this was clearly a bug, but is now required for compatibility with https://github.com/minetest-mods/moreblocks/pull/191

The crafts are really expensive as blocks, is there a way to keep it as-is?

changing the block craft would be the best solution to this, i think


EPIC: Steve should support per-resource schemas

For details please see SURE-6164
Related Issues

rancher
blocking dashboard
SURE

https://github.com/rancher/rancher/issues/40712
https://github.com/rancher/dashboard/issues/7897
SURE-3183

https://github.com/rancher/rancher/issues/34731
https://github.com/rancher/dashboard/issues/3609

https://github.com/rancher/rancher/issues/39378

SURE-5416

https://github.com/rancher/dashboard/issues/5306

https://github.com/rancher/dashboard/issues/8594

https://github.com/rancher/dashboard/issues/4399

https://github.com/rancher/rancher/issues/34731
https://github.com/rancher/dashboard/issues/5722

https://github.com/rancher/dashboard/issues/6667

https://github.com/rancher/dashboard/issues/8544
SURE-6067

https://github.com/rancher/dashboard/issues/8606

Issue of note https://github.com/rancher/rancher/issues/36799
[It would be nice if each of the above lines had a checkbox but github markdown doesn't support active task lists in tables (see https://github.com/github/task_list/issues/42 , closed as wontfix 2017-11-01 - EP]

From a UI perspective we need to understand if the user can do action x to resource y in context z. For example

Add a user as a member of a project in a downstream cluster
Remove a user as an owner from a cluster
Remove a user's restricted-admin's role
Edit a project (i don't think this is achievable via the resource's link.update value). Update: link's update url doesn't provide fine grain PUT/PATCH permissions) in a downstream cluster
Add a configmap in a namespace in a downstream cluster
Historically this was done via either a global schema applying to all resources, or the contents of a resource's actions/links collection. We would receive updates to both over socket if anything changed.

We need to work together to understand how this can be done in a way that scales, automatically updates and integrates with the UI well

Internal reference: SURE-6164 for this work. SURE-8995 has picked up activity as of late and SURE-6656 rides in its wake.

https://github.com/rancher/rancher/issues/47393 is related to these issues, and may be tied to / fixed alongside https://github.com/rancher/rancher/issues/34731


Missing keycode ${e.keyCode}

I pressed the Caps Lock key and the page showed code 0. I use Firefox on Linux.

I think this has been fixed in previous releases.
Please re-open it if needed.


launch.json option for debugpy.debug_this_thread()

Currently, to debug Python scripts called by external applications (e.g. Python being called by MATLAB) it is necessary to import debugpy and call debugpy.debug_this_thread() at the top of the file. I am proposing a launch.json option that handles this, or some other way to no longer need to manually add this statement to a Python script in order to properly debug.

/extPython

VS Code knows nothing about Python.


appsettings config transforms with arrays should perform update instead of merge operation

I have a use case where I have an array that I want to mutate for production release but the transform on the appsettings is performing a merge operation when the item I want to change is in an array.
Example
appsettings.json
{
  "Foo": {
    "Name": "Justin",
    "Roles": [
      {
        "Name": "Reader",
        "IsAllowed": "true"
      }
    ],
  }
}

appsettings.Production.json
{
  "Foo": {
    "Roles": [
      {
        "Name": "Reader",
        "IsAllowed": "false"
      }
    ],
  }
}

Desired final output:
{
  "Foo": {
    "Name": "Justin",
    "Roles": [
      {
        "Name": "Reader",
        "IsAllowed": "false"
      }
    ],
  }
}

The path to update this if mutating this by Path via environment settings would be
Foo:Roles:0:IsAllowed = false

We've discussed this before and unfortunately we think this behavior would be too ambiguous

I have the similar issue but merging happens with values from config and default values set in options' class construction.
I have
public class AuthOptions
{
    public long UserId { get; set; }
    public string[] Roles { get; set; }
    public AuthOptions()
    {
        UserId = 1;
        Roles = new[] { "Administrator" };
    }
}
///...
AuthOptions opts = Configuration.GetSection("Auth").Get<AuthOptions>();

{
 "Auth": {
  "UserId": 2,
  "Roles": [ "User" ]
 }
}

As a result I get UserId default value was overridden by config file. But Roles array contains merged values:
UserId : 2
Roles:  [ "User", "Administrator" ]
If this is expected behavior then how can one override default value of array setting?

Try specifying it as a nested section with the key as the index, i.e. {"Auth:Roles:0", "User"}:
See https://github.com/aspnet/Configuration/blob/dev/test/Microsoft.Extensions.Configuration.Binder.Test/ConfigurationCollectionBindingTests.cs#L14


Grammatical issues in the doc

[Enter feedback here]
This page:  Azure Pipelines automatically builds and tests ... -> Azure Pipelines automatically build and test ...
The heading of a topic is What do I need to use Azure Pipelines?
The next sentence is: To use Azure Pipelines, you need
Suggestion: What do You need to use Azure Pipelines?
On https://docs.microsoft.com/en-us/azure/devops/pipelines/?view=azure-devops, under Concepts, the link text is What is Azure Pipelines?. Suggestion: What are Azure Pipelines?
There are many other similar issues. Looks like you are using a variable for the "Azure Pipelines" term.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: f15f40a4-bae9-154b-752a-2e9f453d79e3
Version Independent ID: 3b937e0b-f919-f227-742f-dc740ad4e6f9
Content: What is Azure Pipelines? - Azure Pipelines
Content Source: docs/pipelines/get-started/what-is-azure-pipelines.md
Product: devops
Technology: devops-cicd-get-started
GitHub Login: @juliakm
Microsoft Alias: jukullam

Thanks for the feedback @alex-cloud. We treat Azure Pipelines as singular since it's a product but you can have one or more pipelines (the actual YAML pipeline in the app).


ModDevTool - Export to .pck file

PCKPacker
Use PCKPacker to pack packages.

That would also allow the 3.x plugin to be rewritten to work without shipping an entire Godot 4 export.

We decided to only used zip files.
https://github.com/GodotModding/godot-mod-loader/issues/24


Send this info to developer !!! { Unhandable information found in DoHome : "autoAssistFreeTrialEnabled" with value : false

Describe the bug
Error "Send this info to developer !!! { Unhandable information found in DoHome : "autoAssistFreeTrialEnabled" with value : false" appears by every polling since today in the log due to a new attribute is provided by the interface.
To Reproduce
Run v0.2.1 and check the kog.
I will create a PR today in the evening.

PR #97 created

same here! please fix

same here! Every 30-40sec

If you like you can install the fork on your own risk at
https://github.com/HGlab01/ioBroker.tado
until it is fixed in this repository. For me and others it worked smoothly.
How: https://github.com/iobroker-community-adapters/ioBroker.tado/issues/62#issuecomment-716326327

Forked version works. Please pull upstream.

If you like you can install the fork on your own risk at
https://github.com/HGlab01/ioBroker.tado
until it is fixed in this repository. For me and others it worked smoothly.
How: #62 (comment)

You Rock ! Will look at the pr this Weekend

You Rock ! Will look at the pr this Weekend

This was the easy part of my three PRs  ;-)

lol
@HGlab01
That's not true. The beads of sweat ran off your forehead.
Or was it just tears?   ;-D

Men do not cry  ;-)

https://github.com/iobroker-community-adapters/ioBroker.tado/commit/f32410b79c143534a081a3b1733533fc7537b79d

Same "problem" here, adapter works besides the Log Spam.
Thanks for the great work!


Help needed to use Science sensor plugin with lrauv simulation

Hello,
For a project that I am currently working on, I need the lrauv scenario simulation to test a custom control code for the robot. For the same I need to integrate the science sensors plugin to simulate relevant scenarios. I followed the installation instructions and I am able to run the empty_environment and the tethys_at_empty_environment worlds. But I would like to simulate scenarios similar to the portuguese ledge world. To get started, I tried running the tethys_at_portugueseledge world, but I am not able to. It glitches and hangs. Is there any reference world file for lrauv robot integrated with science sensors that I can begin with? Could you provide some pointers on how I can go about this? I am new to this and hence, not very confident about navigating the system, I have a doubt, I see that the other world files under the lrauv_gazebo_plugin seem to have a .em extension; Is that expected to work the same way as the other world files? May I know the difference?
Kindly guide in this regards!
Thanks!

Hi @gnanukoth may I know whether you are running with the mbari controller? How is gazebo installed by source or by debs? What is the error when you run it? Perhaps a log via gz sim -v 4 tethys_at_portuuese_ledge. By default empty environment supports science sensors. You just need to spawn an lrauv and then load your data  via the gui.

Hi @gnanukoth, is it possible to share the data if there is a bug we might be able to reproduce it. I believe you should be able to use the gui to load visuals using the worldconfig plugin without the need for any additional work. Are you able to see the science sensor topic?

Hello @arjo129, I am using the default data file that is provided with the repo '2003080103_mb_l3_las.csv'. My understanding was that I do not have to initialize the data file again, since I am using the default one and it is built already as part of the package. I am able to see the sensor topics, but when I do gz topic -e -t "/model/tethys/salinity" or any other science sensor topic, there is no msg received.

Regarding the portuguese_ledge, I ran the command you shared, gz sim -v 4 tethys_at_portuguese_ledge.sdf, it works fine; I am able to receive the science sensor data as well. Also when I try gz sim tethys_at_portuguese_ledge.sdf, it works fine, did not hang or get stuck today! I am not sure what the reason is. But the science sensor readings do not work with tethys_at_empty_environment.sdf. The plugins are all same and the steps followed for execution are also same. I did not initialize the data file for portuguese_ledge explicitly anywhere either. I am not sure what I am missing. Besides, the world config option in the gui is very slow and freezes before i can get to the folder where the data file is present.
Also, when I run gz sim tethys_at_portuguese_ledge.sdf.em, it throws the following error:
Error Code 34: Msg: Invalid argument. Unable to set value [@(tiles[0].lat_deg)] for key[latitude_deg].
[Err] [Server.cc:159] Error Code 9: [/sdf/world[@name="portuguese_ledge"]/spherical_coordinates/latitude_deg:/home/anna/gazebo_models/install/lrauv_gazebo_plugins/share/lrauv_gazebo_plugins/worlds/tethys_at_portuguese_ledge.sdf.em:L85]: Msg: Error reading element <latitude_deg>
[Err] [Server.cc:159] Error Code 9: [/sdf/world[@name="portuguese_ledge"]/spherical_coordinates:/home/anna/gazebo_models/install/lrauv_gazebo_plugins/share/lrauv_gazebo_plugins/worlds/tethys_at_portuguese_ledge.sdf.em:L80]: Msg: Error reading element <spherical_coordinates>
[Err] [Server.cc:159] Error Code 9: [/sdf/world[@name="portuguese_ledge"]:/home/anna/gazebo_models/install/lrauv_gazebo_plugins/share/lrauv_gazebo_plugins/worlds/tethys_at_portuguese_ledge.sdf.em:L67]: Msg: Error reading element
[Err] [Server.cc:159] Error Code 9: Msg: Error reading element
[Err] [Server.cc:159] Error Code 1: Msg: Unable to read file:/home/anna/gazebo_models/install/lrauv_gazebo_plugins/share/lrauv_gazebo_plugins/worlds/tethys_at_portuguese_ledge.sdf.em
I am not sure if this is how I am supposed to run it. My apologies if these are very silly, I am just trying to understand how this works and how the world file has to be built, so that the file I create, works seamlessly. Thanks!

You are not supposed to run  gz sim tethys_at_portuguese_ledge.sdf.em. If
you modify the .em file you have to colcon build the workspace again.
This is because the .em file is actually a python empy
https://pypi.org/project/empy/ template. The
tethys_at_portuguese_ledge.sdf.em is used to
generate tethys_at_portuguese_ledge.sdf. So if you modify
tethys_at_portuguese_ledge.sdf.em you should simply call colcon build && gz sim tethys_at_portuguese_ledge.sdf

Besides, the world config option in the gui is very slow and freezes
before i can get to the folder where the data file is present.

Interesting. This may be worth investigating, however this functionality is
currently in the process of being migrated over to the mainstream gazebo.

My apologies if these are very silly, I am just trying to understand how
this works and how the world file has to be built, so that the file I
create, works seamlessly. Thanks!

No worries.
On Fri, Feb 17, 2023 at 11:57 AM gnanukoth @.***> wrote:

Regarding the portuguese_ledge, I ran the command you shared, gz sim -v 4
tethys_at_portuguese_ledge.sdf, it works fine; I am able to receive the
science sensor data as well. Also when I try gz sim
tethys_at_portuguese_ledge.sdf, it works fine, did not hang or get stuck
today! I am not sure what the reason is. But the science sensor readings do
not work with tethys_at_empty_environment.sdf. The plugins are all same and
the steps followed for execution are also same. I did not initialize the
data file for portuguese_ledge explicitly anywhere either. I am not sure
what I am missing. Besides, the world config option in the gui is very slow
and freezes before i can get to the folder where the data file is present.
Also, when I run gz sim tethys_at_portuguese_ledge.sdf.em, it throws the
following error:
Error Code 34: Msg: Invalid argument. Unable to set value
[@(tiles[0].lat_deg)] for key[latitude_deg].
[Err] [Server.cc:159] Error Code 9: @.***
https://github.com/name="portuguese_ledge"]/spherical_coordinates/latitude_deg:/home/anna/gazebo_models/install/lrauv_gazebo_plugins/share/lrauv_gazebo_plugins/worlds/tethys_at_portuguese_ledge.sdf.em:L85]:
Msg: Error reading element <latitude_deg>
[Err] [Server.cc:159] Error Code 9: @.***
https://github.com/name="portuguese_ledge"]/spherical_coordinates:/home/anna/gazebo_models/install/lrauv_gazebo_plugins/share/lrauv_gazebo_plugins/worlds/tethys_at_portuguese_ledge.sdf.em:L80]:
Msg: Error reading element <spherical_coordinates>
[Err] [Server.cc:159] Error Code 9: @.***
https://github.com/name="portuguese_ledge"]:/home/anna/gazebo_models/install/lrauv_gazebo_plugins/share/lrauv_gazebo_plugins/worlds/tethys_at_portuguese_ledge.sdf.em:L67]:
Msg: Error reading element
[Err] [Server.cc:159] Error Code 9: Msg: Error reading element
[Err] [Server.cc:159] Error Code 1: Msg: Unable to read
file:/home/anna/gazebo_models/install/lrauv_gazebo_plugins/share/lrauv_gazebo_plugins/worlds/tethys_at_portuguese_ledge.sdf.em
I am not sure if this is how I am supposed to run it. My apologies if
these are very silly, I am just trying to understand how this works and how
the world file has to be built, so that the file I create, works
seamlessly. Thanks!
—
Reply to this email directly, view it on GitHub
https://github.com/osrf/lrauv/issues/280#issuecomment-1434061363, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AAEEMQA7CQO3BGQRRQATDJ3WX3ZKPANCNFSM6AAAAAAU5XBFTE
.
You are receiving this because you were mentioned.Message ID:
@.***>

Noted, Thanks! Is there any pointers for me to troubleshoot why the data is not published for the science sensors with tethys_at_empty_environment.sdf?

Check where you are spawning the vehicle. Is it within the field of your
data set? Portuguese ledge is located at a specific location on earth, your
data needs to be from portugues ledge's location. If you don't mind I'm
going to close this issue as it is not a bug.
On Fri, Feb 17, 2023 at 1:44 PM gnanukoth @.***> wrote:

Noted, Thanks! Is there any pointers for me to troubleshoot why the data
is not published for the science sensors with
tethys_at_empty_environment.sdf?
—
Reply to this email directly, view it on GitHub
https://github.com/osrf/lrauv/issues/280#issuecomment-1434133010, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AAEEMQCKA4WKT2AK25VAH4TWX4F2NANCNFSM6AAAAAAU5XBFTE
.
You are receiving this because you were mentioned.Message ID:
@.***>

Not a bug

Sure, Noted, Thanks!


Connect api

In this Milestone, I used store, actions and reducers in React and connected an existing API via Redux and use the data to display something in a UI.

#STATUS: INVALID 🔴 ⚠
Hi, @Chike1990,
While you made a great effort in this project, unfortunately, I cannot proceed to review your code.
Invalid Code Review Request
You have submitted a project, that has linter errors, please remember that all the linters should be in green when you send the code review request 😄
Your Code Review Request will be marked as invalid in your Dashboard, so please submit a new one once you are ready 🙏
Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.

Invalid Code Review Request Does not count into the code reviews limit.

Thanks a lot


minor deployment fixes

This PR implements two minor fixes:

When fh_hf_deploy is run with private set to true/false a 0/1 is passed to create_repo which throws Bad request: "private" must be a boolean.
fasthtml-hf needs to be included in the user's requirements.txt to deploy the app (instruction added to the readme)

Many thanks :D


Allow methods from ancestors of the entity

Had a little problem with inherited entities and changes done in #217. This should allow the method to be in a inherited class up until the Grape::Entity class.

Just noticed that this was fixed in #231 already. So will close this, also the approach in #231 is nicer:).


add OIDC client

Coverage: 86.536% (-0.1%) from 86.671% when pulling d206a1b75439edb478a4ed16ea6317568d1844cb on oidc-client into 9e61867fb4aa67d8716fd9f4bec2fc2a4f8ef17b on main.


Check for validity before concluding retrieving chunk

In order to account only for valid chunks that are returned by others (i.e. not paying for junk) we need to check for chunk validity before we would change the account of the serving peer.
As we want to do the accounting in for example retrieval, this required us to do the check before the end of retrieval, while the preexisting code only checked after retrieve returned.
This also brought our attention to another possible issue, that if we were to recieve garbage chunk, we would not retrieve from another peer, as the verification takes place after the peer queries, so then we would probably fail, even if the valid chunk would be available from the next tried peer.
So we created the chunk in retrieve, and passed a validation function as an argument to retrieve that can do the validation and already return the chunk. This might cause performance issues because of the frequent passing of validation functions. Also some tests need to be fixed before this could be merged

@metacertain , what is the status of this PR? Could you be so kind to provide a description to this PR and/or link it to an existing issue? Right now, I cannot see which problem you intend to solve with this code. Thanks

@Eknir Updated description to elaborate


No module named 'confluent_kafka.cimpl' - Python 3.7 and confluent-kafka

Is your question related to a specific version? If so, please specify:
python3.7/3.9/3.9 and confluence-kafka 1.7.0
What binding does your question apply to, if any? (e.g. Blob Trigger, Event Hub Binding, etc)
function azure
Question
Hi I have to upgrade the version of a funcion App on Azure from python 3.6 to 3.7 or 3.8 or 3.9 (I don't mind what version but I vhave to do it because python 3.6 doesn't exist any longer). What's more, we use confluence-kafka on the script.
To solve the issue I've upgraded the module confluence-kafka to the version 1.7.0, but I still have an error when I debug or run the function on Azure. I also tried to run the function with several versions of  pyhon, 3.7, 3.8, 3.9 but nothing. I also changed the version of the module confluence-kafka, version 1.7.0, 1.8.2, 1.9.2 and the same error.
That's the error:
"_Result: Failure Exception: ModuleNotFoundError: No module named 'confluent_kafka.cimpl'. Please check the requirements.txt file for the missing module. For more info, please refer the troubleshooting guide: https://aka.ms/functions-modulenotfound Stack: File "/azure-functions-host/workers/python/3.7/LINUX/X64/azure_functions_worker/dispatcher.py", line 359, in _handle__function_load_request func_request.metadata.entry_point) File "/azure-functions-host/workers/python/3.7/LINUX/X64/azure_functions_worker/utils/wrappers.py", line 42, in call raise extend_exception_message(e, message) File "/azure-functions-host/workers/python/3.7/LINUX/X64/azure_functions_worker/utils/wrappers.py", line 40, in call return func(*args, **kwargs) File "/azure-functions-host/workers/python/3.7/LINUX/X64/azure_functions_worker/loader.py", line 127, in load_function mod = importlib.import_module(fullmodname) File "/usr/local/lib/python3.7/importlib/init.py", line 127, in import_module return _bootstrap._gcd_import(name[level:], package, level) File "/home/site/wwwroot/CopyTransactionHttpTrigger/init.py", line 8, in  from confluent_kafka import avro File "/home/site/wwwroot/.python_packages/lib/site-packages/confluent_kafka/init.py", line 19, in  from .deserializing_consumer import DeserializingConsumer File "/home/site/wwwroot/.python_packages/lib/site-packages/confluent_kafka/deserializing_consumer.py", line 19, in  from confluent_kafka.cimpl import Consumer as ConsumerImpl"
I was searching on the internet for a solution but I just founded for AWS. I don't know If I have to install the module manually and where or what I have to do to sort it out.
Thanks

@chandrod / @shrohilla Can anyone you help me on this issue

@jgadelevopment thanks for reporting, have you tried the trouble shootings steps provided below.
https://aka.ms/functions-modulenotfound
.

I think @jgadelevopment, Can you try this with -- confluent-kafka[avro]==1.7.0 ?

Sorry, I've made I mistake when I wrote 'confluent_kafka[avro]==1.7.0', I've got confluent-kafka[avro]==1.7.0 in my requirements.txt. @shrohilla you meant? => -- confluent-kafka[avro]==1.7.0 o confluent-kafka[avro]==1.7.0

@shrohilla Can you provide your inputs on above. Thanks.

Finally, I could pass the error "ModuleNotFoundError: No module named 'confluent_kafka.cimpl'." What I did was to install the modules inside the .pythn_packages\lib\site-packages. However I've got another error:
Result: Failure Exception: ImportError: cannot import name 'WinDLL' from 'ctypes' (/usr/local/lib/python3.7/ctypes/init.py). Please check the requirements.txt file for the missing module. For more info, please refer the troubleshooting guide: https://aka.ms/functions-modulenotfound Stack: File "/azure-functions-host/workers/python/3.7/LINUX/X64/azure_functions_worker/dispatcher.py", line 359, in _handle__function_load_request func_request.metadata.entry_point) File "/azure-functions-host/workers/python/3.7/LINUX/X64/azure_functions_worker/utils/wrappers.py", line 42, in call raise extend_exception_message(e, message) File "/azure-functions-host/workers/python/3.7/LINUX/X64/azure_functions_worker/utils/wrappers.py", line 40, in call return func(*args, **kwargs) File "/azure-functions-host/workers/python/3.7/LINUX/X64/azure_functions_worker/loader.py", line 127, in load_function mod = importlib.import_module(fullmodname) File "/usr/local/lib/python3.7/importlib/init.py", line 127, in import_module return _bootstrap._gcd_import(name[level:], package, level) File "", line 1006, in _gcd_import File "", line 983, in _find_and_load File "", line 967, in _find_and_load_unlocked File "", line 677, in _load_unlocked File "", line 728, in exec_module File "", line 219, in _call_with_frames_removed File "/home/site/wwwroot/CopyTransactionHttpTrigger/init.py", line 8, in  from confluent_kafka import avro File "/home/site/wwwroot/.python_packages/lib/site-packages/confluent_kafka/init.py", line 18, in  _delvewheel_init_patch_76882796227() File "/home/site/wwwroot/.python_packages/lib/site-packages/confluent_kafka/init.py", line 11, in _delvewheel_init_patch_76882796227 from ctypes import WinDLL
It's quite similar to the another one, it requires a module, I think

Closing as resolved


GET /suppression/spam_report/{email} call not working / returning 404

This endpoint doesn't seem to be working: After making a SendGrid object with my api key (which is working fine), I'm calling it from PHP as:
$email =<EMAIL_ADDRESS>$response = $sg->client->suppression()->spam_report()->_($email)->get();
just as the documentation (https://github.com/sendgrid/sendgrid-php/blob/master/USAGE.md) shows. I get, on return:
SendGrid\Response::__set_state(array(
'statusCode' => 404,
'body' => '{"errors":[{"field":null,"message":"resource not found"}]}',
'headers' =>
array (
', 0 => 'HTTP/1.1 404 NOT FOUND
', 1 => 'Server: nginx
', 2 => 'Date: Wed, 01 Feb 2017 17:10:55 GMT
', 3 => 'Content-Type: application/json
', 4 => 'Content-Length: 58
', 5 => 'Connection: keep-alive
', 6 => '
7 => '',
),
))
I would think that the spam_report call would work in the same way as the bounce list or invalid_emails calls -- if there's nothing there, the API call succeeds with a status code of 200, but returns a body of [] (empty array). 404, to me, would suggest that the endpoint just doesn't exist. For instance, if I make an intentionally flawed api call like:
$response = $sg->client->suppressionsdfgjkfdslgj()->blocks()->_($email)->get()
I get the same kind of 404 result as I'm currently getting from the spam report call.
Technical details:

sendgrid-php Version: master; public release version
PHP Version: 5.6.27

Hi @jim-at-miramontes,
spam_report should be spam_reports
I hope that helps!
Thanks!

Indeed!  Works fine; it just needs a doc update, I guess.  Thanks!


Do not log Subscription messages which are not pertinent to operation of the code

We are going to receive a lot of Subscription messages. Ignore any that do not pertain to the operation of the code at hand to prevent filling logs without warrant.

Line 448 Fixed. Would notify only when the outbound call is to 911


vips.Image.text : no such operation

I recently installed vips-8.10.5, and tried rendering text, but I got an error:
> vips = require 'vips'
> image = vips.Image.text("Hello World!", {dpi = 300})
/usr/local/share/lua/5.1/vips/voperation.lua:155: no such operation
VipsOperation: class "text" not found

stack traceback:
	[C]: in function 'error'
	/usr/local/share/lua/5.1/vips/voperation.lua:155: in function 'text'
	stdin:1: in main chunk
	[C]: at 0x5649cc4771d0

(this is the example taken from README, run in luajit interactive mode)
I installed vips with just ./configure && make && sudo make install && sudo ldconfig. Did I miss something? Is there a proper way to uninstall and try again, maybe trying an older version?

Hello @piface314,
Your example works for me:
john@kiwi:~$ luajit
LuaJIT 2.1.0-beta3 -- Copyright (C) 2005-2017 Mike Pall. http://luajit.org/
JIT: ON SSE2 SSE3 SSE4.1 BMI2 fold cse dce fwd dse narrow loop abc sink fuse
> vips = require 'vips'
> image = vips.Image.text("Hello World!", {dpi = 300})
>

My guess would be that libvips failed to find the various libraries it needs to enable text rendering during configure. Check the output carefully and keep adding dependencies until you see yes in the summary table at the end. pangoft2-dev is probably the main one.
What platform are you using?

Hello @piface314,
Your example works for me:
john@kiwi:~$ luajit
LuaJIT 2.1.0-beta3 -- Copyright (C) 2005-2017 Mike Pall. http://luajit.org/
JIT: ON SSE2 SSE3 SSE4.1 BMI2 fold cse dce fwd dse narrow loop abc sink fuse
> vips = require 'vips'
> image = vips.Image.text("Hello World!", {dpi = 300})
>

My guess would be that libvips failed to find the various libraries it needs to enable text rendering during configure. Check the output carefully and keep adding dependencies until you see yes in the summary table at the end. pangoft2-dev is probably the main one.
What platform are you using?

I'm using Ubuntu 20.04. It's weird that I checked for pango before installing, it seems to be there:
$ apt search pangoft2
Sorting... Done
Full Text Search... Done
libpangoft2-1.0-0/focal,now 1.44.7-2ubuntu4 amd64 [installed,automatic]
  Layout and rendering of internationalized text

Is it the wrong package? Now that you said it, I really noticed that running ./configure again showed that it's missing.:
...
text rendering with pangoft2: 		no

I'm using Ubuntu 20.04. It's weird that I checked for pango before installing, it seems to be there:
$ apt search pangoft2
Sorting... Done
Full Text Search... Done
libpangoft2-1.0-0/focal,now 1.44.7-2ubuntu4 amd64 [installed,automatic]
  Layout and rendering of internationalized text

Is it the wrong package? Now that you said it, I really noticed that running ./configure again showed that it's missing.:
...
text rendering with pangoft2: 		no

You need the -dev package to get the headers for compilation.
Ubuntu 20.04 comes with an OK libvips, I would just use that unless you have a very strong reason to make your own.

You need the -dev package to get the headers for compilation.
Ubuntu 20.04 comes with an OK libvips, I would just use that unless you have a very strong reason to make your own.

Oh, I wasn't aware of that. How should I properly remove this current misconfigured installation? Is enought to just delete the binaries?

Oh, I wasn't aware of that. How should I properly remove this current misconfigured installation? Is enought to just delete the binaries?

You can do make uninstall, as long as you've not touched the libvips area since you did make install.
Otherwise, I'd do:
find /usr/local/ -name "*vips*"

And remove everything that looks vipsy.

You can do make uninstall, as long as you've not touched the libvips area since you did make install.
Otherwise, I'd do:
find /usr/local/ -name "*vips*"

And remove everything that looks vipsy.

Thanks! That solved it, and now I'm using vips 8.9.1 which is in apt.

Thanks! That solved it, and now I'm using vips 8.9.1 which is in apt.

Closing, since the issue has been solved.

Nice job clearing the weeds @rolandlo !


validate_confirmation default message could be better

Precheck
This lives somewhere between bug and feature request. I'll be happy to close and repost in a forum if that is the desired place. My apologies in advance if this is not the right place.
Environment
n/a
Summary
The default of "does not match confirmation" should either be "does not match" or "does not match #{field}"
Details
original change:
https://github.com/elixir-ecto/ecto/commit/209890de21b42733d4eafce48291f07325f24a2b#diff-9495d20c8803917c695d397ba72de489R974
This original change seemed to tie the confirmation field's error directly to the parent field, such that the parent field would get an error saying that it did not match its confirmation. You can see in the test file that this was fairly clear:
https://github.com/elixir-ecto/ecto/blob/209890de21b42733d4eafce48291f07325f24a2b/test/ecto/changeset_test.exs#L754
"Title does not match confirmation"
This made sense at the time, but the default error message has not been updated in the years since when the error message was no longer tied to the parent field. Here is what we see today:
https://github.com/elixir-ecto/ecto/blob/722d1c932e61cea3d8d86fe3b1dec53c12608c77/test/ecto/changeset_test.exs#L1261
"Title confirmation does not match confirmation"
This has had at least one ripple effect in another package: The whole reason I dug into this was because POW uses the same default message in the same scenario. (Unfortunately there, it is not as easy to override, and I'd argue they had a better message before they understandably decided to match Ecto.)
I see three paths forward:

Do nothing. Defaults can be overridden.
Remove the word "confirmation" from "does not match confirmation"
Interpolate the parent field so the message would read "does not match ${field}"

This is obviously something that is not essential since the message can be overridden, but I contend that if this change is made, far fewer developers will a) change the message at all or b) live with a default they don't like (whatever their reasons). If there is ever a possibility that a default can serve most people's needs, that is what the default should be.
Changing it would also be helpful in situations like mine where I am depending on a package that mimics the default messaging from Ecto, but changing that message is not as straightforward.
I'd be happy to give this a go and create a PR, but would defer to the maintainers of this package on which option they prefer.
Cheers, and thanks for this fantastic software ecosystem. I am very new to Elixir and I am loving the possibilities that it brings to the table.

Yes, I have noticed this recently when working on an app and unfortunately I am not sure there is a straight-forward answer because of backwards compatibility.
I would like to avoid having dynamic fields, because it makes it harder to apply i18n. So our option is to leave it as is and remove "confirmation". Is removing "does not match" clear enough though? Although the current message is vague, if we are going to fix it, we should make sure we get the wording right.

Other options:

"confirmation does not match": This is arguably clearer since "confirmation" would be the subject rather than the object, but might be the only error message that refers to itself (?)
"does not match original": Closer syntax to what we'd get with interpolation

A point of clarification: Are you avoiding interpolation because of some kind of variability within a single confirmation or because you'd prefer that every confirmation validation return the exact same message?
I have never done the work to internationalize an application, so I am not sure if it would be beneficial for these validations to actually produce different strings or not. In relative ignorance, I'd imagine being able to target "does not match password" and "does not match title" independently would be helpful.

(Personally, I do think that "does not match" all by itself is clear enough, considering some of the other defaults that haven't been problematic at this point. But that is purely a gut feeling.)

In a new Phoenix app, we generate a file with all default error messages so they can be translated. Making it dynamic would make this operation extremely hard - so it is best if custom messages are opted-in.
"confirmation does not match" is clearer but it is inconsistent as we don't have the subject in any other message. Perhaps the best option for now is to keep this open so we can further collect feedback.

I would be very careful about changing the messages. For applications that do use Gettext for i18n it would break translations in a way that might be hard to notice.
It's definitely possible to change the messages, but IMO the bar for doing that should be relatively high.

Perhaps this should be targeted at a major release?
Another option that I could not undertake on my own would be something in config that allows you to opt in to the new messages until the next major release, at which point we'd remove the old ones. Deprecation notice plus a way to opt in would allow developers to have time testing the new functionality before it is mandatory.
That's a fair amount of work for an overridable field, though, if such a system is not already in place.

Perhaps this should be targeted at a major release?

That's the issue. We don't plan to release a new major version. :S

Interesting. That seems like a bigger discussion, indeed. Perhaps I'll look for that topic in the forums.
Assuming there will never be a 4.x branch, I guess the best way to move forward is to close this issue, or add an opt in for newer defaults somehow with no intent of removing the opt-in logic?
Adding "feature flags" is certainly one way to keep software moving forward without a new major release.

The issue is that feature flags are global and we want to avoid global configuration due to the coupling. In this case is exactly what you want but I would like to avoid to precedent. :(

Hi @happycollision! Thank you for the report. I agree there is a better message somewhere here but unfortunately I cannot see a way to move forward without breaking applications or without introducing opt-in globals that very few people would use. You can pass the message option or use gettext to "translate" all occurrences to something better. :) Have a good weekend!


HiDpiMode::Default does not use the DPI factor from winit

The docs state

The DPI factor from winit is used directly without adjustment

#[derive(Copy, Clone, Debug, PartialEq)]
pub enum HiDpiMode {
    /// The DPI factor from winit is used directly without adjustment
    Default,
...

But if you look at this "helper" function, the winit dpi is not used at all in with Default.
    #[cfg(feature = "winit-19")]
    pub fn scale_pos_from_winit(
        &self,
        window: &Window,
        logical_pos: LogicalPosition,
    ) -> LogicalPosition {
        match self.hidpi_mode {
            ActiveHiDpiMode::Default => logical_pos,
            _ => logical_pos
                .to_physical(window.get_hidpi_factor())
                .to_logical(self.hidpi_factor),
        }
    }

On my machine the dpi for my window changes from 1.0 to 1.16 after a while, and now the mouse clicks are all off center. I realized that when I use HiDpiMode::Rounded, everything works fine.
I think the problem is that the framebuffer scale is set correctly for dpi changes, but scale_pos_from_winit doesn't get the correct size. I think it also should scale it by the current dpi.

It definitely sounds like a DPI factor bug, although I don't yet see what the problem could be in scale_pos_from_winit. With HiDpiMode::Default, self.hidpi_factor should always be equal to window.get_hidpi_factor(), so there's no scaling that needs to be done and using winit's values (like logical_pos parameter here) directly should always be ok.
Which operating system and winit version are you using? Windows + winit 0.19?

Windows 10 1909, winit v0.19.3 (*). imgui-rs git master ccec55c10a787f92b21054476f5817506c38692e.
When opening the "test_window_impl" example with Windows set to 125% scale, fonts are the same size at 100% scale. When opening at 150% or 175% scale, fonts are exactly twice the size as at 100% scale, and chunky (nearest neighbor upscaling).
When I first open the example, then switch Windows from 125% to 175%, the example window becomes blurry, but cursor clicks are not misaligned.

@Gekkio I am on linux with awesomewm. I think the problem was that the the dpi factor is cached but window.get_hidpi_factor() changes over time. From 1.0 to 1.16 after a few ticks.
I'll post some results when I get home and have a look at it again.

Closing old issue - this was around imgui-rs 0.3. With ~v0.8 the DPI scaling seems to work correctly on Linux at least under XFCE4 and Sway


Wiki updates

Overview/Summary
This PR makes some updates to the Wiki documentation to help provide users with better information on how to use the module.
This PR fixes/adds/changes/removes

Adds improvements to the Management resources example.
Adds a new Management resources with custom settings example.
Adds more information covering working with the archetype_config object to fix #28
A few general tweaks to other example pages.
Updates to sidebar and ToC on other pages.
Added new page covering permission requirements to fix #145.
Updated documentation for variables to improve accuracy and coverage.
Improves links to multi-Subscription examples to fix #147

Breaking Changes
None
Testing Evidence
Latest commit passes linting, and no changes to functional code.
As part of this Pull Request I have

[x] Checked for duplicate Pull Requests
[x] Associated it with relevant issues, for tracking and closure.
[x] Ensured my code/branch is up-to-date with the latest changes in the main branch
[x] Performed testing and provided evidence.
[x] Updated relevant and associated documentation.
[x] Updated the "What's New?" wiki page (located in the Enterprise-Scale repo in the directory: /docs/wiki/whats-new.md)

/azp run unit


Add "UseFullName" parameter to Update-MarkdownHelpModule

Thank you!

Added one! #380 - let me know if I need to do anything except update the code itself.

Can you, please, update the platyPS docs too? That's why the CI build fails: https://ci.appveyor.com/project/PowerShell/markdown-maml/build/<IP_ADDRESS>3

Great, thank you!

@vors Thanks!! Might have a few more pull requests coming in soon - hoping to get some more improvements done.  Do you know when the next release is?

I'm still working on a few other PRs for the repo based on requests from the azure-powershell team/partners of the azure-powershell team, but I'll let you know when everything gets in (or I give up).  Thanks for the help :)


added partial_sort function to algorithms

This PR...

Fixes #
Changes

Checklist

[x] I have read CONTRIBUTING guidelines.
[x] This is a typo fix.
[x] I am not updating any todo.txt files.

i have added partial_sort function to algorithms


Mailpit in crashloopbackoff error in Kubernetes

Hi,
I've deployed mailpit as a deployment in my GKE cluster with following configuration,no authentication or anything is enabled,
 env:
        - name: MP_DATABASE
          value: /data/mailpit.db
        - name: MP_MAX_MESSAGES
          value: '5000'
        - name: MP_SMTP_AUTH_ACCEPT_ANY
          value: '1'
        - name: MP_SMTP_AUTH_ALLOW_INSECURE
          value: '1'

It runs for sometime,but then mailpit pod goes into crashloopbackoff error
level=fatal msg="database is locked (5) (SQLITE_BUSY)"
I tried using three different mailpit docker images with version v1.20.7,v1.21.3,v1.21.5 but all result in same error.
Can please help me out on this as to why i keep getting this error.

Hi @wali97. Internally Mailpit enforces single connection to the database to prevent this very issue, so this should not happen unless:

You have another process sharing / accessing the database (eg: another instance of Mailpit or script reading/writing to the database)
The database is stored on a network filesystem such as SMB or NFS (SQLite is designed for local)

Can you confirm you don't have 1 or 2 above, and any other details about your setup that may be appropriate? Are you receiving  a very high load of emails (not that it should matter, I've tested with a constant stream of 130k emails without issues).

Hi @axllent .
No other process is sharing or accessing the database,i've other instance of mailpit running but they're in a different namesapce..
However,i'm using a NFS server as a persistent storage to store the data at path: /data

I'm not sure what to say. SQLite over NFS is known for file locking issues, sure it may work for a while, but it goes wrong eventually as you've discovered, not to mention poor performance.
You could investigate NFS mount options (not sure if there are actual working configurations), but it's best to avoid it if possible. Not sure what other options you have though... I would suggest using an elite database, however it also uses SQLite, and it sounds like you may just be shifting the problem.

Sorry, I just edited my previous response (typo + add link to rqlite).

I see GKE supports persistent volumes which may solve your issue (by not using NFS).

I have updated the documentation to emphasize (more) the fact that the database should be local. Sorry, I wish I could help but there isn't anything else I can do here, so I am closing this ticket.


Removed duplicate identifier preventScrollOnTouch

preventScrollOnTouch is defined twice in the file causing an error when used in a Typescript project

this should be merged urgently

@ganlanyuan - pls merge & create a patch


Update Go builder to latest version of library

Related #67

@laurentsimon We should probably discuss whether it's worth it to continue to have a separate go.mod for the Go builder. I think we addressed privacy by adding it to internal and I'm doubtful the Go builder will have significantly more dependencies than the base library, but I'd like your thoughts.
In the future, I can definitely see us having a separate go.mod for a Docker builder (e.g. #23). For example, if we need to import Docker client that would import a huge number of transient dependencies.

Let's merge the go.mod, there does not seem to be a simple solution to this at the moment. We can re-visit later if this becomes an issue.
Thanks @ianlewis and @asraa for bringing this up

I needed this as part of https://github.com/slsa-framework/slsa-github-generator/pull/142, so I made the changes in the PR


!whitelist command to whitelist stuff from our filters.

The bot should be able to whitelist stuff from our filters with a command.
This should probably be a command group that allows whitelisting of several different things that we're currently configuring in default-config.yml.

!whitelist guild 15409531 should whitelist a guild invite for posting on our server. Currently this is managed in the guild_invite_whitelist section in default-config.yml
!whitelist format .ipybn should whitelist a format from the anti-malware filter. Currently managed in the anti_malware.whitelist section of the default-config.yml

This issue will require a corresponding change to the site. You can find the corresponding issue for this at https://github.com/python-discord/site/issues/305

Can I work on this?

@atmishra yes, as long as you're comfortable working on both sides of the stack. This will require a change on the site as well.

Thanks, @lemonsaurus for assigning this to me. I am more comfortable with the site part of this task So it will not be a problem for me. On the command part, can you give me some more details like:

What all items can be added to this whitelist?
Should it also give option to list, edit or delete the whitelist?
any restrictions on who can call this command or in which channels?

This is my first task on creating a command, So need some more clarity. Thanks!

any restrictions on who can call this command or in which channels?

It should definitely be restricted. I think this falls under the umbrella of server administration, so it would make sense to restrict this to those with the admins or owners role. There are constants defined in config-default.yml/bot.constants with the relevant role IDs. It's not really sensitive information, so I don't think a channel lock-down is necessary to prevent accidental data leaks.

Should it also give option to list, edit or delete the whitelist?

Definitely, with the listing preferably separated by the type of whitelist (guild invite, file extension, ...). I'm not sure if an edit makes sense; I think the whitelist mutations will mainly come down to either adding an item to the whitelist or removing it, but feel free to play around with to see if it makes sense from a UX point of view. Maybe someone else has an opinion about this as well.

What all items can be added to this whitelist?

This is the most difficult question to answer. So far, we've mainly discussed the whitelist in relation to the server invite filter and the file extension filter. In general, I think the back-end solution should be flexible enough so that adding more whitelists in the future isn't difficult.
The other two whitelists that are currently in there, the channel_whitelist and role_whitelist, are fairly static and depend on other constants with pointers/references. I don't think it's necessary to include those, but we can always add them later if we want a single, tried and tested method for whitelists.

@atmishra The site-side changes seem to be done, but we still need the bot-side changes to be made. Are you still interested in tackling this part? If so, when do you think you'll be able to open a pull request for it?
I don't want to merge the site-side changes until the bot changes are ready, since that might require us to write another migration for site for any changes made to the whitelists in the space between now and then. It would be better to merge both of these at the same time.

@lemonsaurus Thanks for the feeback. I am done with the most of the work on bot side as well. I will soon raise a PR for that.

@atmishra Any updates on your progress?

Hi @MarkKoz I have raised a PR for this.

I'll handle this.


Add options to support external DB TLS

Adds 2 new (optional) parameters to the helm chart values - one for toggling external db TLS validation, and one to supply a CA cert for use in validating external db TLS
Description

The changes to releases.yml are required regardless of the TLS support - this is due to the fact that when you enable external db support the ops files try to remove the same vars twice and fail to render the template
The changes to database.yml ops file are pretty much a repetition of the same thing for each job. Adding a proper explicit toggle for TLS validation of DB connections (rather than relying on the defaults), and adds the ability to provide a CA cert to validate against.
Motivation and Context

This change is required due to the fact that UAA's default config is to perform full validation of the DB CA cert. This became apparent when attaching to an RDS instance and being unable to configure UAA to talk to the DB without overrides.
While it would be easier to just set the default behavior for UAA to disable DB TLS by default (as the other jobs do) as the only option, it would be nice to provide the choice of forcing validation for all DB connections

How Has This Been Tested?
This has been tested by deploying to a KubeCF in EKS and Rancher EC2 K8s, both connected to an external RDS (Postgres) instance as well as tested with the external db disabled to ensure the default internal db still works.
This has also been tested in the same manner on KubeCF in vSphere using an external Postgres DB

KubeCF version - 0.2.0
CF-Operator Version - v2.0.0-0.g0142d1e9

Screenshots (if appropriate):
Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[x] My code has security implications. (Adds the ability for operators to force TLS for external DB connections)
[x] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.

Looks like this resolves #191 (Forgot to include in description)

@f0rmiga Updated the PR as per your comments (Thanks!) - haven't had time to take it for a spin just yet but I'll try to do that at some point soon.


Searchable Events

Issue
It may be that a user suspects there are ticket-able events, but doesn't know the link.
User Story
I am looking for an event to generate a ticket and expect to find it with a simple search because I just don't want to scroll through Crypto Twitter or Discord to find it.
Discussion
Recommendation: For later consideration, it might be nice to add a search function to find events.
This could be a text-based search box where I can search for a project name (e.g., Crypto Faries").
Or this could be behind the scenes as a lookup query where I connect a wallet and the PolicyIDs are searched against existing events with those PolicyIDs and either returns something like:

"No events for your tokens found."
Or, a list of titles and links to the events that are found.

OK, I didn't see any mention of that. But if the point is to be able to run your own ticketing site for your event then this could be less of an issue.
I would probably actually prefer to be able to run this on my own platform. Hosting a ...twistedgears.io/tickets page that highlights an event. I generally would see that as more favorable, since keeping the URL on the same site reduces the possibility of phishing-type attacks and retains branding for projects.


Convert [FB_14] OAD006 [NEG] Malformed client_credential access token request to use a dynamically calculated HTTP BASIC Authentication Header

Closed 175c6aaa7f3dcbdd66389b5ab7a9f04e11037865


Use multiple docker images and directly tag them

This results in inputoutput/hydra-node and inputoutput/hydra-tui being
the images and for example inputoutput/hydra-node:0.2.0 a tagged version.
Saw the tags step only after changing things so I kept it this way and wanted to see what you guys think.
IMO having the tag == the git tag is nice and having two images for two different components seems more docker idiomatic to me, but not entirely sure.

I assume you've also created the corresponding repositories on dockerhub?
@KtorZ No I have not. :open_mouth:  It seems we are also using your key. We should share that credential or use an IOHK one!?

Ho. I forgot about that one 😅
Ideally we should get some API key, but that's managed by the ops team.

Having different repositories for different purposes and tag images by commits is best practice in dockerland AFAIK, so I am all for this change.

Great. So this depends on changing the credentials and/or creating the repository using the existing credentials now.

We discussed that using the github image registry may be a good alternative to docker hub as well

There's also Google Container Registry we could use, as we have a dedicated project for Hydra: https://cloud.google.com/container-registry

We have two public packages now:

Will push a commit now which makes the docker.yaml workflow not run on this branch anymore. See previous success for approval.


Build #4342378 stuck in Building state

Details

Project URL: https://readthedocs.org/projects/secretstorage/
Build URL (if applicable): https://readthedocs.org/projects/secretstorage/builds/4342378/
Read the Docs username (if applicable): mitya57

Expected Result
The build either completes, or fails, or times out.
Actual Result
The build is stuck in Building state for more than a month. All other builds went fine.

Have a similar issue here
https://readthedocs.org/projects/geonode/builds/4537979/
the "latest" branch works while the "master" one stucks on "cat conf.py"

All of my builds are stuck on "cat conf.py", doesn't make a difference for me whether I build latest or master, see #2476

I am running into this constantly. My doc tree builds fine running Sphynx directly on another linux platform and I get literally no feedback what is going on in RTD. I am finding it very unusuable.

Yes it's a shame, it's great when it's working. I'm manually building & deploying my docs to GitHub Pages to work around the issue. RTD was always getting stuck at exactly the same point in my build.
cat conf.py
Although looks as though my build history console output is now missing too, so I can no longer see what causing the build failures :(

Same issues.
Worked fine every time, then after last build it keeps getting stuck on
cat conf.py
/revitpythonwrapper
Build #4641434
latest (adf3db113c0feaddc4fa2279d36fe090f8d5dbba)

following up made a trivial change to project settings, and it got rebuilt successfully.
previous build still stuck:

I've tried modifying all sorts of different build settings, still hasn't made a difference for me unfortunately.

@gtalarico and what was that magic trivial change? :)

@mitya57 one of the problem I see here is your conf.py makes the server goes into a:
RecursionError: maximum recursion depth exceeded
because you are returning the same Mock() class instead of MagicMock() at this line: https://github.com/mitya57/secretstorage/blob/master/docs/conf.py#L79
After changing that in my local clone of your repository, I was able to build it without any problem.
Can other people having this issue confirm that you are not running into the same problem?

@humitos

because you are returning the same Mock() class instead of MagicMock()

Oh, that was because that was documented in the FAQ before #2530 was merged. I have updated it now. If you kill the outstanding running build, I think we can mark the issue resolved.

@mitya57 there is no way to kill a building (see #2471) but that is not a problem for this since it's just a UX issue. I mean, the building process doesn't exist anymore in the server, there is nothing running but the thing is it is not communicated properly to the Front End. I saw an issue for that, but I'm not finding it right now.
Thank you. I'm closing this issue.
Feel free to re-open if any of you still have the problem.


Allow to pass in HttpContext when generating links

https://github.com/aspnet/Routing/commit/aed2e244831f4aeb3ef5b3b5c33f4a053f70a9a2


AArch64 macOS: Enable MathLoadTest tests

This commit enables some MathLoadTest tests on AArch64 macOS again.
They were excluded by #3375.
Signed-off-by: KONNO Kazuhiro<EMAIL_ADDRESS>

This PR depends on https://github.com/eclipse/omr/pull/6551

The nightly job https://openj9-jenkins.osuosl.org/job/Pipeline_Build_Test_JDK18_aarch64_mac/124/ contains the PR from OMR, and it finished successfully.  This PR is ready now.


Improve RTD integration

We should have a single, top-level URL like visit.readthedocs.io From there, we should host all manuals (GUI, CLI, etc.) We should also support versions To do all this, we need to debug why RTD builds don't like building from VisIt's trunk Might be best to wait 'til we move to github
-----------------------REDMINE MIGRATION-----------------------
This ticket was migrated from Redmine. As such, not all
information was able to be captured in the transition. Below is
a complete record of the original redmine ticket.
Ticket number: 2976
Status: Pending
Project: VisIt
Tracker: Docs
Priority: Normal
Subject: Improve RTD integration
Assigned to: Mark Miller
Category: -
Target version: -
Author: Mark Miller
Start: 11/13/2017
Due date:
% Done: 0%
Estimated time:
Created: 11/13/2017 11:53 pm
Updated: 11/28/2017 06:44 pm
Likelihood: 3 - Occasional
Severity: 2 - Minor Irritation
Found in version: 2.12.3
Impact:
Expected Use:
OS:
Support Group: Any
Description:
We should have a single, top-level URL like visit.readthedocs.io From there, we should host all manuals (GUI, CLI, etc.) We should also support versions To do all this, we need to debug why RTD builds don't like building from VisIt's trunk Might be best to wait 'til we move to github
Comments:

fixed in #3323


bug:

Plugin version:
2.0.2
Platform(s):
iOS Build
Current behavior:
Build errors:
node_modules/@capawesome/capacitor-screen-orientation/ios/Plugin/ScreenOrientation.swift:62:57: value of type 'UIViewController' has no member 'setNeedsUpdateOfSupportedInterfaceOrientations'
windowScene?.keyWindow?.rootViewController?.setNeedsUpdateOfSupportedInterfaceOrientations()

node_modules/@capawesome/capacitor-screen-orientation/ios/Plugin/ScreenOrientation.swift:63:26: value of type 'UIWindowScene' has no member 'requestGeometryUpdate'
windowScene?.requestGeometryUpdate(.iOS(interfaceOrientations: orientationMask))

node_modules/@capawesome/capacitor-screen-orientation/ios/Plugin/ScreenOrientation.swift:63:49: cannot infer contextual base in reference to member 'iOS'
windowScene?.requestGeometryUpdate(.iOS(interfaceOrientations: orientationMask))

Expected behavior:
Build successfull
Other information:
Reverting to 2.0.1 builds fine
Capacitor doctor:
💊   Capacitor Doctor  💊

Latest Dependencies:

  @capacitor/cli: 4.7.0
  @capacitor/core: 4.7.0
  @capacitor/android: 4.7.0
  @capacitor/ios: 4.7.0

Installed Dependencies:

  @capacitor/cli: 4.6.3
  @capacitor/core: 4.6.3
  @capacitor/android: 4.6.3
  @capacitor/ios: 4.6.3

[success] iOS looking great! 👌
[success] Android looking great! 👌

Thanks for reporting this!
Unfortunately, I can't reproduce it with the demo app on my iPhone with iOS 16.
Please share the following information with me:

XCode Version
iOS Version
Whether you can reproduce it in the simulator or not

Xcode Version 13.4.1 <= that's probably the problem 😅
I would have thought that the if #available(iOS 16, *) would have also be understood by the compiler: "you don't know about iOS 16, let's forget about this if".
I'll update xcode and reopen if still having the problem. Sorry about the troubles.


Unfollow confirmation for Chatterino's usercard

What should be added?
A unfollow confirmation for Chatterino's usercard. Twitch added it aswell and Chatterino does't have it.
Why should it be added?
So that people don't mistakly hit that checkbox and unfollow. It is important, see https://twitch.uservoice.com/forums/923383-creators-and-stream-features/suggestions/10197198-get-a-warning-to-follow-and-unfollow-someone

Being implemented in #2629

Duplicate of #1886


fix: disable drf browsable api by default

openapi / swagger is the supported documentation for the api. Disable DRF views by default.
Jira: https://issues.redhat.com/browse/AAP-12014

Seems that we are going to do the contrary.