Create a template for issues and pull requests

We need a template for issues and pull requests
How Github template works: https://docs.github.com/en/communities/using-templates-to-encourage-useful-issues-and-pull-requests/manually-creating-a-single-issue-template-for-your-repository
Examples of issues templates: https://github.com/search?utf8=✓&q=in%3Apath+issue_template.md&type=Code&ref=searchresults
Examples of PR templates: https://github.com/search?utf8=✓&q=in%3Apath+pull_request_template.md&type=Code&ref=searchresults

Hi, I would like to work on this. Could you please assign this issue to me?

Hi @Shatakshi0805, shure! Feel free to choose a template.

We have a openning PR for Pull Request templates (https://github.com/rodrigo-brito/ninjabot/pull/22)
Can you help me with the issue template?

yes, definitely. would be making a PR soon.

I have made the PR. Please review the same.

Closed by https://github.com/rodrigo-brito/ninjabot/pull/23


[WFLY-13375] JNDI view does not show implementation classes for connection factories and destinations registered by 3rd party resource adapters.

Issue: https://issues.redhat.com/browse/WFLY-13375

@emmartins Please review.

@bstansberry @parsharma LGTM

Hi, I am improving this PR by adding a test case. Please don't merge as of now.

@parsharma This was merged 3 days ago.


Can't see the Container Environment variables set, on Rancher UI

We're using Rancher v1.6.0, Cattle framework.
Via User with readonly permission, the user can't see the environment variables set inside the docker container. It's getting displayed as None.
Needless to say, environment variables are visible from member and admin role permissions.
Would be great, if you could remove the restriction of viewing the environment variables from readonly role / permission.

Any update on this issue?

This is intentional because they often contain passwords (despite being poorly-advised) and will not be changing in 1.x.  In 2.0 it will likely be a capability to can toggle on a role.

With the release of Rancher 2.0, development on v1.6 is only limited to critical bug fixes and security patches.


Internationalization support

The MSRV for rage is bumped to 1.45.0, which is required for the i18n-embed crate.

The translations don't currently cover the gumdrop usage text, because we use gumdrop_derive which requires literal strings.


feat(autoware_test_utils): add general topic dumper

Description
By running
ros2 launch autoware_test_utils psim_road_shoulder.launch.xml vehicle_model:=<vehicle-model> sensor_model:=<sensor-model>

and then stop the simulation whenever you want, using the SimulatedClockPanel, you can save the specified ros topic in the specified format by call the service.
ros2 service call /autoware_test_utils/topic_snapshot_saver std_srvs/srv/Empty \{\}

https://github.com/user-attachments/assets/c97c2177-a6e0-482b-8c0b-8c23ef91f66d
Related links
Parent Issue:

https://tier4.atlassian.net/browse/RT1-8338

How was this PR tested?
Notes for reviewers
None.
Interface changes
None.

Effects on system behavior
None.

run following command in the attached state
ros2 service call /autoware_test_utils/topic_snapshot_saver std_srvs/srv/Empty \{\}

generated file is following
topic_snapshot.zip

@soblin
This is a really great feature. Am I correct in understanding that examples of utilizing the YAML files generated on the unit test side and the readme will be added in the future?

Please ignore the spellcheck because they stem from other packages


Added Compare and Decimals methods to coins

I've added methods for coins comparison and a getter for decimals, it might be useful

Hi, lets make them methods of Coins struct e.g. func (c *Coins) Decimals() int and same for Compare

Oh, you are right. I just copied it from my project and didn't pay attention.


Add caching mechanism for the date header value

I was upgrading the http4s code in the Techempower Benchmark and got curious to see where some of the bottlenecks are.
One of them was the fact that the HTTP Date header is always calculated and rendered for each request. This means that if you receive a lot of requests in a second each time you're going to render the Date header.
To solve this, this PR adds a simple caching mechanism that only renders the date header once in a given second, reusing the same value for all subsequent requests in that same moment.

Yes, I tested the improvement with a JMH benchmark and obtained these results:
[info] Benchmark                              Mode  Cnt        Score        Error  Units
[info] Http4sDateFormatting.http4sWay        thrpt    3  1769821.455 ±   6346.432  ops/s
[info] Http4sDateFormatting.simplyCachedWay  thrpt    3  8865904.658 ± 459379.561  ops/s

The benchmark code was this short snippet:
@State(Scope.Thread)
class Http4sDateFormatting {
  @Benchmark
  def http4sWay(): Unit = {
    val rr = new StringWriter(512)
    rr << Date.name << ": " << Instant.now << "\r\n"
  }

  val SimplyCachedRenderer: Renderer[Instant] =
    new Renderer[Instant] {
      private val dateFormat =
        DateTimeFormatter
          .ofPattern("EEE, dd MMM yyyy HH:mm:ss zzz")
          .withLocale(Locale.US)
          .withZone(ZoneId.of("GMT"))

      var cachedString: String = dateFormat.format(Instant.now())
      var currentTime: Long = Instant.now().getEpochSecond

      def format(instant: Instant): String = {
        if (instant.getEpochSecond != currentTime) {
          currentTime = instant.getEpochSecond
          cachedString = dateFormat.format(instant)
        }
        cachedString
      }

      override def render(writer: Writer, t: Instant): writer.type =
        writer << format(t)
    }

  @Benchmark
  def simplyCachedWay(): Unit = {
    val rr = new StringWriter(512)
    rr << Date.name << ": "
    rr.<<(Instant.now)(SimplyCachedRenderer)
    rr << "\r\n"
  }
}

Cherry-picked for release into 0.21.x.


AngularJS - Service not acting as singleton

Hello all, so I am using this wrapper for the Amplitude JS API in my Angular application and as it is heavily related to this project, I figured I might as well ask here. Also, it is my hope that hopefully this will catalyze more support/documentation for using AmplitudeJS in an AngularJS application.
Apologies for the code heavy post but I wanted to provide as much context as possible. I am having an issue with defining Amplitude as a service in my Angular.js application. Services are supposed to act as singletons throughout an application (source), so I am confused to be getting the following behavior.
In my app.js file, I call AmplitudeService.logEvent('EVENT_NAME') in a .run function which successfully logs the event to Amplitude. Note: Console.log(AmplitudeService) returns an object with all the correct functions here.
However, when I call AmplitudeService.logEvent('EVENT_NAME') within any other controller, (header.js file in this example) I do not ever see any data in my Amplitude dashboard. Note: Console.log(AmplitudeService) within header.js returns an identical object to the one returned from app.js
Would appreciate any and all insight!
AmplitudeService.js (source)
Note: If you check the author's syntax, he returns an object at the end of his service. In my research, I've read to use the "this" keyword when defining Service functions (source), and that you don't need to return an object as you would with a Factory, so I have updated it accordingly.
    angular.module('AmplitudeService', [])
    .service('AmplitudeService',
    ['$amplitude', '$rootScope', 'amplitudeApiKey', '$location',
    function ($amplitude, $rootScope, amplitudeApiKey, $location) {

      this.init = function() {
        $amplitude.init(amplitudeApiKey, null);
      }

      this.identifyUser = function(userId, userProperties) {
        $amplitude.setUserId(userId);
        $amplitude.setUserProperties(userProperties);
      }

      this.logEvent = function(eventName, params) {
        $amplitude.logEvent(eventName, params);
      }
    }]);

angular-amplitude.js (source)
This allows access to "$amplitude" throughout the application
```
(function(){
var module = angular.module('angular-amplitude', ['ng']);

module.provider('$amplitude', [function $amplitudeProvider() {
this.$get = ['$window', function($window) {
  (function(e,t){
    var r = e.amplitude || {};
    var n = t.createElement("script");
    n.type = "text/javascript";
  n.async = true;
  n.src = "https://d24n15hnbwhuhn.buttfront.net/libs/amplitude-2.2.0-min.gz.js";
  var s = t.getElementsByTagName("script")[0];
  s.parentNode.insertBefore(n,s);
  r._q = [];

  function a(e){
    r[e] = function(){
      r._q.push([e].concat(Array.prototype.slice.call(arguments,0)));
    }
  }
  var i =    ["init","logEvent","logRevenue","setUserId","setUserProperties","setOptOut","setVersionName","setDomain","setDeviceId","setGlobalUserProperties"];
  for(var o = 0; o < i.length; o++){
    a(i[o])
  }
  e.amplitude = r
}
  )(window,document);
  return $window.amplitude;
}];
}]);
return module;
}());
```

App.js
```
angular.module('app', [
'ngRoute',
'angular-amplitude',
'AmplitudeService',
])

 .run(['AmplitudeService', function(AmplitudeService){
 console.log(AmplitudeService); // Outputs 'Object {}'
 AmplitudeService.init();
 *AmplitudeService.logEvent('LAUNCHED_SITE'); // This logs the event*
 console.log(AmplitudeService); // Outputs 'Object {}'
 }])
```

Header.js
 ```
 angular.module('app.common.header', [])
 .controller('HeaderCtrl', [ '$rootScope', '$scope', '$location','$route', '$window', 'AmplitudeService', function($rootScope, $scope, $location, $route, $window, AmplitudeService){

 $scope.goToSearch = function(term) {
 $location.path('/search/' + term);
  console.log(AmplitudeService); // Outputs 'Object {}'
*AmplitudeService.logEvent('SEARCHED');* // This does not log the event
 };
 }]);
 ```

If anyone has any experience implementing Amplitude JS in their Angular app, would love to hear from you. Thanks.

@zcoon , I'm not familiar with the AngularJS wrapper around our SDK. It sounds like you are calling the wrapper from multiple files. My guess is the wrapper instance is not being persisted across files. Basically the main issue is that you need to initialize the SDK with your API key before you log any events.
If in file 1 you initialize and successfully log events, but in file 2 you fail to log events, that seems to indicate to me that you did not initialize in file 2. You assume it would be the same instance from file 1 and it should already be initialized, but it looks like to me that's not the case.
The solution could be as simple as initializing the wrapper in every file that you use it before you start logging events, but I'm not familiar with Angular JS or the wrapper.
Also, if you were logging events on an uninitialized SDK you should see warnings in the console.

Thanks for the comment @djih,
My solution was to initialize the SDK by calling AmplitudeService.init() within app.js, which initialized an amplitude object within my window. From there forward, I included $window as a service in each of my controllers and called $window.amplitude.logEvent('event_name_here');


fix(SchemaBase): allow to use class types in generics

Before this commit the SchemaBase class having only one constructor
signature requiring 1 argument it was not possible to use class types in
generics with classes extending SchemaBase. This commit fixes it.
closes #11

Great, thank you.


Current dark theme feels washed out

For reference, this is how my app looks with the current dark theme

and this is how my app looked like with version 2.0.7 of DaisyUI

I tried creating a new theme using the values from 2.0.7

And for the most part, this worked fine. But it doesn't work with the typography tailwind plugin (nothing was getting applied at all, not even header styling).
Is there any plan to reverse this direction with the dark theme? Or at least providing a higher contrast dark theme than in 2.6.4? If not, how would I go about overriding values in the dark theme (because clearly I haven't grabbed all the values needed to fully replace the dark theme)?

Yes, dark theme got darker because it didn't look good on some displays at night (it was too light)
I think it looks better now but if you want the old colors, use this config: https://play.tailwindcss.com/54nC2MwxeG?file=config
It works good with Typography plugin too. (there were color issues on older versions but it's fixed now)
Let me know if there's an issue


Animator positions look incorrect

Need to investigate, is it animator or real positions that are wrong?

Real positions were not being assigned correctly in the parser
Fixed YNTDL lib in https://github.com/buzz66boy/YNTDL/commit/b847fdeeb0a0379d56ac16dced9ec8ae2a91fdca
Fixed ns3-lxc main branch in
https://github.com/buzz66boy/ns3-lxc/commit/c901708abcca3426fa1bb4a9d0a76d05ea670c5c


Beutify and make some slight optimizations

Closing this as there are no real improvements. Please see https://meta.discourse.org/t/contributing-to-discourse/53797#code-computer-6 for contributing.


Drop unnecessary non-nil check since we have a presence check

Found when doing something like Vm.where(:id => 2).select(:id, :name).first; nil. With the default_value_for that doesn't allow nil, extra attributes get populated.
Discovered here: https://github.com/ManageIQ/manageiq/pull/18492#issuecomment-493139108.

@miq-bot assign @bdunne

thanks @bdunne

LGTM :+1:
Can you also open a separate issue (or even PR) for DialogField and MiqAeMethod?  I'm concerned that we shouldn't be using allows_nil => false there either.

sure gimme just a second @Fryguy


Fix #458, Add reusable unit test and coverage verification workflow

Checklist (Please check before submitting)

[x] I reviewed the Contributing Guide.
[x] I signed and emailed the appropriate Contributor License agreement to<EMAIL_ADDRESS>and copied<EMAIL_ADDRESS>
Describe the contribution

Fix #458

Testing performed
CI from CF (w/ modified repo/path): https://github.com/skliper/CF/actions/runs/2174432954
Expected behavior changes
None
System(s) tested on
CI
Additional context
None
Code contributions
The cFS repository is provided to bundle the cFS Framework.  It is utilized for bundling submodules, continuous integration testing, and version management and does not contain any software.  Code contributions should be directed to the appropriate submodule.
Contributor Info - All information REQUIRED for consideration of pull request
Jacob Hageman - NASA/GSFC

CCB:2022-04-20 APPROVED with Changes

change don't skip from "push" to "pull request"

CCB:2022-04-20 APPROVED with Changes

change don't skip from "push" to "pull request"

Fixed in 254db27, should be ready to merge.


Fix uneven divider in nav bar for small viewport

Bug/issue #, if applicable: 91372980
Summary
Fix uneven divider in nav bar for the small viewport. This only happens when we use NavMenuItem component (not NavMenuItems
Fixed by overriding line height for the small viewport.
Checklist
Make sure you check off the following items. If they cannot be completed, provide a reason.

[ ] Added tests - NA
[x] Ran npm test, and it succeeded
[ ] Updated documentation if necessary - NA

@swift-ci test

This is the exact change that broke it. I am not sure whether we should revert that min-height to height or keep this fix. https://github.com/apple/swift-docc-render/pull/47/files#diff-0e3113fe0f5966efbcbf73dbccb8c910fd794de61da439d6063299dc39feee9cR46
I am OK with both.
CC @marinaaisa

I don't have the context of why height was changed to min-height in the first place. If reverting it doesn't create a regression, I would prefer not adding new CSS. Since you were the one introducing the min-height change, can you tell if there is any regression when reverting it, @dobromir-hristov ?

Not that i could see. I think it was so that we could have items larger than that height as children without cutoff.

Not that i could see. I think it was so that we could have items larger than that height as children without cutoff.

Do you have an example of that? I could open another PR and keep both height and min-height?

@swift-ci test


Where do i need to insert my app_id?

the nativve setup doesnt change for either IOS or android
feel free to follow the official setup guides
https://developers.facebook.com/quickstarts


feat: WIP: Adjust GPU Layers

Description

Add GGUF Parser

TODO

Install nvidia-smi driver
Fetch GPU Device information
Offload layers to GPU baed on GGUF Parser metadata

This PR fixes #
Notes for Reviewers
Signed commits

[ ] Yes, I signed my commits.

@mudler can u kindly check the PR approach and give some high level feedback when possible?
Next step that i will add is some sort of GPU_Layer estimator based on:

VRAM from GGUF Parsing
Noof GPU's on the device

@siddimore thanks for taking a stab at this, direction looks good here - just few minor nits here and there but definitely not blockers

@siddimore thanks for taking a stab at this, direction looks good here - just few minor nits here and there but definitely not blockers

thanks much @mudler you are welcome!! i will improve the code and add some more testing. Appreciate the feedback and will fix the comments


refactor(tooltip): split arrow style from pseudo

removed the need to use pseudo element for arrows
added new classes for "nested/adjustable" arrow styling
flipped left and right to match top and bottom

BREAKING CHANGES: flipped left and right, removed obsolete mixin vanilla-tooltip__main

:tada: This PR is included in version 5.0.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Add support for signalfd

This PR is stale (and superseded by wip-signals). I'm going to close this and hopefully a new PR will be opened soon.


Research wording for nc licenses

The CI failure is about some missing tags or sections in the dataset cards, and is unrelated to the part about non commercial use of this PR. Merging


Strange behavior of CSS selectors

I've noticed a strange behavior of selectors in Portia. Here's a zipped video of my workflow:
css-selector-bug.zip
So basically what I do is create a project on scrapinghub.com, create a spider for the https://www.kurtgeiger.com/women/shoes/trainers/slip-ons/logical-silver-glitter-kg-kurt-geiger and then select an element which has a #product-sku id. At first Portia gives it #details-dl > dd:nth-child(10) selector which is strange because a unique id exists for that element. But after creating another annotation, a first element's selector changes to the correct #product-sku.

The way selectors are generated there is a preference to creating longer selectors but when you added a second annotation the long selector was no longer valid due to the closeness of the elements in the page.
When you had just one annotation the algorithm was going to search the HTML tree to a depth of ~10 elements. When you add a second annotation this tells the algorithm that the annotations are going to be in a specific part of the page and the CSS selectors update to reflect this. There are actually 3 CSS selectors generated. If you look inside the data for the sample you should see that there is an annotation with Item_container: true and selector: #details-dl at the top followed by your 2 other annotations.
There is a bug here though. That annotation shouldn't change its selector after you have changed it from automatic to CSS and it shouldn't be used for the generation of the 3rd selector.

@ruairif Thanks for the explanation. What I find problematic here is that #details-dl > dd:nth-child(10) selector is much less robust than #product-sku is. Other products may contain another attribute count in the dl element and the selector that depends on an element order will fail while #product-sku will work just right. Is there a way to shift preference towards id selectors, make them have more priority? Any help to where I should look is appreciated.

Also, maybe I missed the point, but even when I select an element that is not close to the #product_sku (I select .page > header > .inner-wrap > .hide-text in the header), the behavior is the same as in my original post.

Maybe the generation doesn't behave how I think it does then.
I can't make it prioritise id selectors but I will fix the bug that causes the css selector to change. After you mark a selector as CSS then it should be static unless you manually change it


Mark a new release

With all the work from #10, we should have a new version tagged/released.
Can be saved for the same time that #27 is implemented to aid in testing that workflow.

This was done as part of the follow-up to #31


Fill In the TODOs in the documentation

[ ] - README.md usage instructions
[x] - ruby_rest_client - spec.summary
[x] - ruby_rest_client - spec.description
[x] - ruby_rest_client - spec.homepage
[x] - ruby_rest_client - allowed_push_host
[x] - ruby_rest_client - source_code_url
[x] - ruby_rest_client - changelog_uri

I've added these successfully. I've not added usage instructions as of yet because I'm not sure how this is going to go. Over time I can see these being multiple gems as their functionality is fleshed out. That should not discount work that needs to be done now.

I'm going to close this for now.


The webvtt subtitles referenced by m3u8 cannot be displayed correctly on the client.

Describe the bug
When playing m3u8 with streaming and subtitles, the streaming will play normally, but the subtitles cannot be displayed correctly. After logging, it was found that the client would continuously send subtitle requests to srs.
Version
5.0release (v5.0.193)
To Reproduce

Compile and launch from source code using clion.
Use OBS Studio to push the stream using RTMP (rtmp://localhost/live/livestream).
Set up m3u8 and put the webvtt file in /trunk/objs/nginx/html/live.
Use hls.js demo (https://tinyurl.com/yz72un3r), chrome extension (https://tinyurl.com/yxc5523r) or my video.js player to play index.m3u8.
After successful streaming, select the option to display subtitles.
See error.

Expected behavior
Play streaming and subtitles simultaneously.
Additional context
index.m3u8 (Generate by myself):
#EXTM3U
#EXT-X-VERSION:3
#EXT-X-MEDIA:TYPE=SUBTITLES,GROUP-ID="subs",NAME="English",LANGUAGE="en",URI="sublist.m3u8"
#EXT-X-STREAM-INF:NAME="Main",SUBTITLES="subs"
livestream.m3u8
sublist.m3u8 (Generate by myself):
#EXTM3U
#EXT-X-VERSION:3
#EXT-X-MEDIA-SEQUENCE:0
#EXT-X-TARGETDURATION:105
#EXTINF:70.817,
sub.webvtt
livestream.m3u8 (Generate by srs):
#EXTM3U
#EXT-X-VERSION:3
#EXT-X-MEDIA-SEQUENCE:23
#EXT-X-TARGETDURATION:71
#EXTINF:70.833, no desc
livestream-0.ts
livestream-1.ts

Supplement:
Automatically add query after .webvtt

SRS does not support HLS with WebVTT subtitle, which is also not included in the RTMP specfication. And the source for generating subtitle is uncertain, meaning you can not add existing WebVTT file to a live stream, because in real world the live stream can not be described by fixed subtitle.
Now, with the ability and development in AI, it is now possible to generate subtitle automatically during live stream. This feature is supported by SRS Stack, not by SRS. Please refer to the transcript feature of SRS Stack, see https://blog.ossrs.io/revolutionizing-live-streams-with-ai-transcription-creating-accessible-multilingual-subtitles-1e902ab856bd


Addon Crashes Launcher

If addon is loaded the game crashes, atleast 15 more are reporting that issue on the XIVLauncher Discord

This is related to a recent XIVLauncher change, looking into it.

The XIVLauncher change has been reverted, closing.


Add the linter to the golangci-lint

It will be very useful, if go-arch-lint is added to the golangci-lint.
How to add new linter to the golangci-lint

they require full unit test coverage. I do not want write unit test for coverage.
But i have service tests for each command, this cover most cases.
am not against integration with golangci-lint, but the guys do not want to


Quake Mode - Allow Horizontal resizing

Description of the new feature/enhancement
Currently, the Quake Mode Terminal takes up whole width of the screen and when using it on a wide monitor, this can get cumbersome to use it. Please allow horizontal resizing and allow docking it at the center horizontally - similar to the way ConEmu works.
Worth mentioning another issue already logged here #11125 which causes additional inconvenience while using wide monitor.

 Then you mentioned

similar to the way ConEmu works.

So if ConEmu can do it, then we should too.

I found a workaround!
We can Ctrl+Shift+P and choose Toggle Focus Mode and then use Fancy Zone to define a zone and drag the terminal into the zone.
But again, I wish there was native support though👍

Variable width is a must on an ultra-wide monitor. One terminal stretched across 34 inches is no bueno.

workaround continues:
While using fancy zones, it allows overriding windows default docking keyboard shortcut Win+Arrow and we can use these key combinations to dock terminal as well


webpack cache broken by recreate link of node_modules using rush/pnpm

Bug report

What is the current behavior?
webpack rebuild without change, (only recreate link of node_modules) spend as much time as first build

build first time

rebuild without any change

rebuild after recreate link of node_modules using rush install

If the current behavior is a bug, please provide the steps to reproduce.
I created a repo to reproduce, following steps please see README file

What is the expected behavior?
webpack rebuild after recreate link of node_modules should spend as much time as rebuild without any change using cache

Other relevant information:
webpack version:  5.60.0
Node.js version: v12.22.6
Operating System: mac os
Additional tools<EMAIL_ADDRESS><EMAIL_ADDRESS>

Expected, we store time of cache files to validate cache, but rush install fully remove node_modules and recreate node_modules and files in node_modules (check it - create test.txt file in node_modules and run rush install), not only create links, how to fix - provide location for cache where cache file will not be recreated:
cache: {
        type: 'filesystem',
        cacheDirectory: path.resolve(__dirname, '../../.temp_cache/'),
        buildDependencies: {
            defaultWebpack: ['webpack/lib/'],
            config: [__filename],
        }
    },

I am not familiar deeply with rush, but just check stats. Feel free to feedback.

Yes, it works, thank you!


argument error Inspect.Ecto.Query.expr_to_string/4

Environment

Elixir version (elixir -v): 1.6.2
Database and version (PostgreSQL 9.4, MongoDB 3.2, etc.): Mysql 5.7.18
Ecto version (mix deps): 2.1.6
Database adapter and version (mix deps): mariaex 0.8.3
Operating system: Mac OS Sierra

Current behavior
Here's my query:
  def revenue(user) do
    from(
      months in subquery(
        from(
          entry in "time_entries",
          cross_join: num in fragment("(SELECT @num := -1)"),
          select: %{
            month: fragment("DATE_FORMAT(NOW() - INTERVAL (@num := @num + 1) MONTH, '%Y-%m')")
          },
          limit: 13
        )
      ),
      left_join: rev in subquery(
        from(
          [line, je] in lines(user),
          join: ca in "chart_accounts", on: line.chart_account_id == ca.id,
          select: %{
            month: fragment("DATE_FORMAT(?, '%Y-%m')", je.date),
            total: fragment("SUM(IF(? = 0, ? * -1, ?))", line.kind, line.amount, line.amount),
          },
          where: ca.account_id == ^user.account_id and ca.classification in ^ZB.ChartClassifications.sales(),
          group_by: fragment("month")
        )
      ), on: rev.month == months.month,
      select: %{
        month: months.month,
        total: rev.total,
      }
    )
    |> ZB.Repo.all()
  end

  defp lines(user) do
    from(
      line in {"journal_entry_lines", ZB.JournalEntryLine},
      join: je in "journal_entries", on: line.journal_entry_id == je.id,
      where: line.account_id == ^user.account_id
        and je.is_confirmed
        and is_nil(je.deleted_at)
        and is_nil(line.deleted_at)
        and je.currency_code == ^user.account.default_currency_code
    )
  end

If select is this:
      select: %{
        month: months.month,
      }

It works. But if I try to reference total from the left join, like this:
      select: %{
        month: months.month,
        total: rev.total,
      }

I get:
08:14:41 phoenix-api.1      |  ** (exit) an exception was raised:
08:14:41 phoenix-api.1      |      ** (ArgumentError) argument error
08:14:41 phoenix-api.1      |          (ecto) lib/ecto/query/inspect.ex:160: Inspect.Ecto.Query.expr_to_string/4
08:14:41 phoenix-api.1      |          (elixir) lib/macro.ex:813: Macro.unary_call/2
08:14:41 phoenix-api.1      |          (elixir) lib/macro.ex:678: Macro.to_string/2
08:14:41 phoenix-api.1      |          (elixir) lib/macro.ex:877: Macro.call_to_string/2
08:14:41 phoenix-api.1      |          (elixir) lib/macro.ex:885: Macro.call_to_string_with_args/3
08:14:41 phoenix-api.1      |          (elixir) lib/macro.ex:686: Macro.to_string/2
08:14:41 phoenix-api.1      |          (elixir) lib/macro.ex:950: anonymous fn/2 in Macro.kw_list_to_string/2
08:14:41 phoenix-api.1      |          (elixir) lib/enum.ex:1365: anonymous fn/4 in Enum.map_join/3
08:14:41 phoenix-api.1      |          (elixir) lib/enum.ex:1899: Enum."-map_join/3-lists^foldl/2-0-"/3
08:14:41 phoenix-api.1      |          (elixir) lib/enum.ex:1899: Enum.map_join/3
08:14:41 phoenix-api.1      |          (elixir) lib/macro.ex:586: Macro.to_string/2
08:14:41 phoenix-api.1      |          (ecto) lib/ecto/query/inspect.ex:133: Inspect.Ecto.Query.kw_expr/3
08:14:41 phoenix-api.1      |          (ecto) lib/ecto/query/inspect.ex:64: Inspect.Ecto.Query.to_list/1
08:14:41 phoenix-api.1      |          (ecto) lib/ecto/query/inspect.ex:34: Inspect.Ecto.Query.to_string/1
08:14:41 phoenix-api.1      |          (ecto) lib/ecto/exceptions.ex:34: Ecto.QueryError.exception/1
08:14:41 phoenix-api.1      |          (elixir) lib/enum.ex:1047: anonymous fn/3 in Enum.flat_map_reduce/3

Expected behavior
If I get rid of the lines function and merge the query components from lines into the query above, it works. Unfortunately that creates duplicate logic I'd like to avoid and I don't see any reason why this shouldn't work… do you?

It is definitely a bug, since it was not supposed to fail like that, but you need to provide us a smaller sample or an application that allows us to reproduce it. The code that you have still have a lot of dependencies on user fields and things like ^ZB.ChartClassifications.sales(). If you can replace those by values and provide a failing query it would help a lot.
Also note that you are not on the latest Ecto. This may have been fixed in the latest 2.2.

I'll close for now since I think it would be a significant of work to make an app that duplicates it and it sounds like you haven't seen it before, so its probably rare


add action_kit as a shipment item on the campaign signup data form

related to #4303

if this doesn't get done in time for GTFO launch we'll have to programmatically update the shipment_item entries that come in before we deploy this

@mikefantini I can get this out today


Applied ESBuild transformation

This PR applies ESBuild to XElement and introduces a transformation step, where the JS or TS entered into the Payload is now transformed and minified.
The end result is a cleaner, transformed and smaller payload pushed through, resulting in better performance in build time and FCP,
This to iterate allows for Typescript to now be used within the <XElement> handlers, 🥳
I would like to pay my thanks to @okikio for his epic contribution in helping to guide this into creation, and for @jonathantneal  for helping to make it safe and stable to use.
Thank you guys, you're both legends,

Awesome 🚀

Ill make it pretty tomorrow, lol, thank you for your amazing work today, really was a monumental effort,


Flutter v1.12.13+hotfix.5, bug on compile

Hi.
This package ran very well, but in the new version of Flutter,
it has been a problem compiling and running.
Flutter v1.12.13+hotfix.5
Dart 2.7.0
Tanks

@LuizLeite
Thanks for reporting the issue.
I'm not able to reproduce this issue.
Can you add some error logs or some steps to reproduce this?

Hi.

Create a default Flutter 1.12.13 project.
Install the package.
When running a dialog appears on the Android screen saying that my app has stopped.
Only that.

@LuizLeite
I've made a fix to this but many users are continuously reporting same issue for most of the plugins.
As of now i think we should wait till official hotfix to this/ any announcement.
To make it run it would be better to downgrade the flutter version.
I'll keep you updated on this.
Thanks

Hi.

Create a default Flutter 1.12.13 project.
Install the package ^0.1.7.
When running a dialog appears on the Android screen saying that my app has stopped.
if I remove the package the app runs normally.
Only that.

Same happens to me

@LuizLeite @marcos930807: You can try using solution mentioned in this and this comment. It worked for me!

In my case i modified my cache pup project and cast to a FlutterFragmentActivity because that is the entry Point of my Android part. Thanks

This issue has been resolved. It will be available in the new release.

please release this issue solution.

Same problem, can you give a solution or release the new fixed version? thanks!

Is this resolved in a new release? Which version??

Seems that its fixed on last commit, not available on pub yet btw, installed via git, on pubspec paste:
 flutter_barcode_scanner:      git: git://github.com/AmolGangadhare/flutter_barcode_scanner.git

I have this problem too
please release updated about this issue

Seems that its fixed on last commit, not available on pub yet btw, installed via git, on pubspec paste (take care of indentation):
 flutter_barcode_scanner: git: git://github.com/AmolGangadhare/flutter_barcode_scanner.git

Here's the right way to install from Git
https://flutter.dev/docs/development/packages-and-plugins/using-packages#dependencies-on-unpublished-packages

I had the same issues, and i solved change the mod that i import the package on pubspec.yam
like this:
flutter_barcode_scanner:
git: git://github.com/AmolGangadhare/flutter_barcode_scanner.git

V1.0.0 has been released
Closing this, feel free to reopen if the issue persists


Added egg for Fabric

Added Pterodactyl Egg for Fabric Mod Loader

Thanks for this PR. Did it actualy work on your instalation?

Just fixed it! Did not check my PR thoroughly enough, really sorry for the inconvenience!


Could you add a feature to automatically pop up the loot frame after a boss is defeated, or whenever someone in a party, raid, or LFR loots an item?

Could you add a feature to automatically pop up the loot frame after a boss is defeated, or whenever someone in a party, raid, or LFR loots an item?

Normally if the other player can give you the object it will automatically pop up the loot frame. If it's for anniversary LFR becareful you can't trade the warband item.
If it's not that tell me in which instance it doesn't open


IET - new rocm_smi_lib

change IET module to work with the new new rocm_smi_lib

See also #212

fixed in iss234


Cython 0.22 does not compile master

Using cython dev from github:
e:\MinGW\bin\gcc.exe -shared -s build\temp.win32-2.7\Release\kivy\graphics\trans
formation.o build\temp.win32-2.7\Release\kivy\graphics\transformation.def -Le:\P
ython27\libs -Le:\Python27\PCbuild -lopengl32 -lglew32 -lpython27 -lmsvcr90 -o G
:\Python\dev2\kivy\kivy\graphics\transformation.pyd -lm
cythoning kivy\graphics/vbo.pyx to kivy\graphics\vbo.c

 Error compiling Cython file:
 ------------------------------------------------------------
 ...
     cpdef release(self)
     cpdef get_pixel_color(self, int wx, int wy)

     cdef void create_fbo(self)
     cdef void delete_fbo(self)
     cdef void apply(self)
                   ^
 ------------------------------------------------------------

 kivy\graphics\fbo.pxd:27:19: Signature not compatible with previous declaration

 Error compiling Cython file:
 ------------------------------------------------------------
 ...
     cdef void push_states(self, list names) except *
     cdef void pop_state(self, str name) except *
     cdef void pop_states(self, list names) except *
     cdef void enter(self) except *
     cdef void leave(self) except *
     cdef void apply(self) except *
                   ^
 ------------------------------------------------------------

 kivy\graphics\instructions.pxd:123:19: Previous declaration is here
building 'kivy.graphics.vbo' extension
e:\MinGW\bin\gcc.exe -mdll -O -Wall -Ie:\Python27\include -Ie:\Python27\PC -c ki
vy\graphics\vbo.c -o build\temp.win32-2.7\Release\kivy\graphics\vbo.o
kivy\graphics\vbo.c:1:2: error: #error Do not use this file, it is the result of
 a failed Cython compilation.
 #error Do not use this file, it is the result of a failed Cython compilation.
  ^
 error: command 'e:\\MinGW\\bin\\gcc.exe' failed with exit status 1
make: *** [force] Error 1

I think they most have become stricter about keeping function prototypes consistent.

Reopening because this is now a issue with cython 0.22 on pip.

Here's the cython bug report of this issue: https://groups.google.com/forum/#!topic/cython-users/r3dQSfOKMjI

@matham, adding except * works on Linux. Could you check if my PR works for you on Windows? If it doesn't, there might be something specific to Windows we can fix to make it work with 0.22.

Closing because we now refuse to build, with a helpful error message, on Cython 0.22 (and 0.22.alpha0, 0.22.beta0).

Unfortunately, this is still affecting the macports version, which tries to use the latest cython, which is 0.22_0. From a developer perspective, I get it, but from a user perspective this is a big pain. I've commented on the cython bug also. I think Kivy is an excluded option for me until this is fixed.

I ran into the cython 0.22 build problem on ubuntu 15.04. quick fix is
$ pip install -I cython==0.21

master should compile on cython .22 now, if you are using the last stable release you will need to use cython .21 I believe


API: Make public internal chainBundle

TypeScript Version:  3.2.0-dev.201xxxxx
Currently we can't work with bundles in transformers, but built-in transformers use chainBundle to iterate over sourceFiles inside them
return chainBundle(transformSourceFile);

So, we need something similar or opened chainBundle to use in the custom transformers

+1, it would be really helpful.


An easy way to disable DLL plugin

I might be wrong, but I vaguely remember that a few months back it was possible to disable the DLL plugin by simply deleting the dllPlugin section from package.json or even doing something like:
- "dllPlugin": {
+ "dllPlugin (disabled)": {

(see https://github.com/react-boilerplate/react-boilerplate/issues/784#issuecomment-235549193 as an example of a situation when this has helped)
Today's implementation of internals/scripts/dependencies.js does not support this kind of trick and always generates a DLL no matter if the dllPlugin section in package.json is present or not. So in order to temporary disable the plugin, one should tweak the scripts section, which is less intuitive.
What do you guys think of returning the old (i.e. optional) style of invoking the generation of DLL? This would just mean that when pkg.dllPlugin is undefined in dependencies.js, the script does echo('Generating Webpack DLL is skipped as there is no dllPlugin section in package.json'); and exits. This may be useful for debugging webpack config that includes specific rules for certain modules.

This may be useful for debugging webpack config that includes specific rules for certain modules.

@kachkaev Help me out here, please. Can you give a scenario where disabling dll plugin would be helpful?

Hey @KarandikarMihir!
I guess a general answer is a situation requires some webpack tweaking. Some npm modules may not work perfectly with the standard build config and therefore require a bit of webpack tweaking. When dllPlugin is on, one first needs to build that DLL and only then npm start to see what's happened. Without this step, the build will take longer but at least you'll be able to iterate over an error with a smaller number of commands.
Going more specific, I've had two cases in my experience. One is react-map-gl, which uses mapbox-gl-js that is built with browsefy and not working ideally inside webpack. There exists a solution, but it's not very obvious in this boilerplate.
Another case is a component library called antd that offers custom theming for their standard LESS styles. Setting things up is quite a magical process especially given that a good chunk of advice is for webpack 1. With DLL module temporary turned off, going through the pain of tweaking looks a bit less unpredictable.

As a troubleshooting aid this sounds like a reasonable feature. Our webpack config is pretty intimidating, even for advanced users... Reducing the potential problem scope is a valuable troubleshooting technique.
I would welcome a PR enabling this feature.

@kachkaev Nice!

but it's not very obvious in this boilerplate.

True. I've never had to face this issue in my project. PR is welcome 😊

Closing due to inactivity


[Question] After config, Some thing now working/misunderstand/affect by something else

Hello:
I follow the guide and success config bitlock network unlock, All things working fine, But if I unplug workstation network cable, Make it absoulte disconnect, The workstation still boot up and login (show the login screen), Is this failed? Or system contains some cache can unlock disk even network disconnect ?

文档详细信息
⚠ 请勿编辑此部分。 docs.microsoft.com ➟ GitHub 问题链接必须具有此部分。

ID: 91c13083-9b29-e54b-fd85-8033ec665fcd
Version Independent ID: ce8c4647-69bc-95d4-2192-6e737d5ad5da
Content: BitLocker 如何启用网络解锁（Windows 10） - Microsoft 365 Security
Content Source: windows/security/information-protection/bitlocker/bitlocker-how-to-enable-network-unlock.md
Product: w10
Technology: windows
GitHub Login: @Dansimp
Microsoft Alias: dansimp

Disclaimer: I am not affiliated with Microsoft or the Microsoft Docs teams here on GitHub.
Unfortunately, I don't know this subject well enough to give you a guaranteed correct answer.
Maybe someone from the technical writers' team will reply to you some day (don't know when).
Until then, I will offer a guess on my part, that Network Unlock technology is not about locking a device or computer from user login directly from the console.
I am guessing that Network Unlock allows administration tools and WDS to access the device remotely, but does not block the operating system if network is disconnected.
The intention of this repository is to improve on the existing documentation by providing the users a way to report factual errors, improvement suggestions and request updates for new versions.
The MS Docs team members might not have time to answer your question, both due to the small size of the team and the big workload.
Try the following resources to get in touch with users who may be able to help you:

TechNet forums: https://social.technet.microsoft.com/Forums/en-US/home
MSDN: https://social.msdn.microsoft.com/Forums/en-US/home
Microsoft Community: https://answers.microsoft.com/

Note to myself: There is a broken link anchor in this page, only visible on the /en-us/ page, the HTML tag </a> is missing from this heading:

https://docs.microsoft.com/en-us/windows/security/information-protection/bitlocker/bitlocker-how-to-enable-network-unlock#install-the-wds-server-role

@e0i : Do you know if it would be useful to have this ticket question answered by one of the tech writers, for future reference?


Add consul agent to the traffic_controller

Diego needs to locate the Traffic Controller using consul so that the TPS can retrieve app metrics for apps running on Diego. By default consul is not deployed in cf-release, however co-locating the consul_agent on the VM will not affect the operation of the Traffic Controller (cloud_controller already does this.)
Thanks,
@jfmyers9 && @atulkc

Coverage decreased (-0.12%) to 82.54% when pulling 05ccc5351e1a8b7143ac6c62e1cd905dc4370935 on jfmyers9:add-consul-agent-to-loggregator-trafficcontroller into e33c9e7c5c63479e06f3bb990080576e2d4f5b09 on cloudfoundry:develop.

Hi @jfmyers9 .Traffic controller can be discovered using CC API's /v2/info endpoint. We discussed this as a team a while ago and we do not want to have multiple ways of discovering TC. Happy to continue discussing.

How does one find loggregator without CC? Diego has Lattice which has no CC.
We are also trying to prevent 3 trips through the LB/GR for calls that originate from the CC.

@fraenkel Hmmm .. is consul the only way one can discover services in lattice? I know this isn't ideal. From loggregator's perspective, we already have a dependency on etcd and we don't want to depend on another key-value store. To your second point, we do have a story to move traffic controllers not register through the gorouter: https://www.pivotaltracker.com/story/show/84943402

@wfernandes we'd like to reopen this conversation, do you have some more thoughts @jfmyers9?

I've opened this, and I'll be scheduling a short hangout to talk through it.

@Jim-Campbell Did you schedule anything yet? I don't see any meeting on my calendar.

We have completed this work #113316357.


@conda-forge-admin, please update team

Additional comment:
No response

Hi! This is the friendly automated conda-forge-webservice.
I just wanted to let you know that I updated the team with maintainers from main.

https://github.com/orgs/conda-forge/teams/gromacs still doesn't work for me :-(

But it does now that I accepted an invitation from conda-forge-linter to join conda-forge. Thanks all!

Great! :)


Line ends are not drawn correctly on canvas

My line ends seem to be less than 100% of a circle if I draw a line anywhere towards the left.
e.g.

This is on macos (retina),
Simple reproducer below:
from kivy.app import App
from kivy.uix.boxlayout import BoxLayout
from kivy.lang.builder import Builder
from kivy.graphics import Color, Line

kv = '''

BugTest:

<BugTest>:
    canvas.before:
        Color:
            rgba: 1,1,1,1
        Rectangle:
            size: self.size
            pos: self.pos
    Label:
        text: 'test'
'''

class BugTest(BoxLayout):
    def __init__(self, **kwargs):
        super(BugTest, self).__init__(**kwargs)
        with self.canvas:
            Color(0, 0, 0, 1)
        self.line_width=10

    def on_touch_down(self, touch):
        with self.canvas:
            touch.ud['current_line'] = Line(
                points=(touch.x, touch.y), width=self.line_width, cap='round', joint='round')
            touch.ud['current_line'].points += (touch.x, touch.y)

    def on_touch_move(self, touch):
        if 'current_line' in touch.ud:
            touch.ud['current_line'].points += (touch.x, touch.y)

class LineEndBugApp(App):

    def build(self):
        self.app = Builder.load_string(kv)
        return self.app

LineEndBugApp().run()

@hackalog  On trying to reproduce I got this traceback..Basically there is no Builder class defined inside ..kivy/lang/builder.py
``Traceback (most recent call last):    File "test.py", line 3, in <module>      from kivy.lang.builder import Builder  ImportError: No module named builder

@saqib1707 No problem with that code for me. Check if you have Kivy installed properly or try to make it from kivy.lang import Builder only.

Thanks @KeyWeeUsr .Its working .

Hi friend why does my app crashes whenever I initialize it(start it)
meanwhile am running it in root directory
On Saturday, November 26, 2016, Peter Badida<EMAIL_ADDRESS>wrote:

@saqib1707 https://github.com/saqib1707 No problem with that code for
me. Check if you have Kivy installed properly or try to make it from
kivy.lang import Builder only.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/kivy/kivy/issues/4752#issuecomment-263050943, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AWevmFHHQipC1HMZ9ZxW71amka7ucrnXks5rB-sEgaJpZM4K8s0A
.

Everytime I tried starting my kivy app it crashes automatically. Am running
it in a root  directory
On Saturday, November 26, 2016, Peter Badida<EMAIL_ADDRESS>wrote:

@saqib1707 https://github.com/saqib1707 No problem with that code for
me. Check if you have Kivy installed properly or try to make it from
kivy.lang import Builder only.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/kivy/kivy/issues/4752#issuecomment-263050943, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AWevmFHHQipC1HMZ9ZxW71amka7ucrnXks5rB-sEgaJpZM4K8s0A
.

@700brains   try to make it **from kivy.lang import Builder **only.

Please bro/sis can you elaborate am zero to kivy framework
Just Give me an example on how?
And again running with sudo like sudo buildozer android debug is it
advisable to run with sudo. Can't wait to hear from you!
On Saturday, November 26, 2016, Saqib Azim<EMAIL_ADDRESS>wrote:

@700brains https://github.com/700brains try to make it **from kivy.lang
import Builder **only.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/kivy/kivy/issues/4752#issuecomment-263083297, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AWevmGTCCg4kzKF988d5cDa3AFzLINB_ks5rCJM3gaJpZM4K8s0A
.

@700brains This is not a chat, please target beginner questions to IRC, mailing list or some other site supporting it clearly visible here.
The repository is specifically for code and issues related to it, not a Q&A website.

Pls when I run it on my Ubuntu it went OK but after I compiled it to an apk
file and run on my tecno p9 it crashes. This is just a Hello world program
ignore the too much import I did will use it later
On Saturday, November 26, 2016, Saqib Azim<EMAIL_ADDRESS>wrote:

@700brains https://github.com/700brains try to make it **from kivy.lang
import Builder **only.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/kivy/kivy/issues/4752#issuecomment-263083297, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AWevmGTCCg4kzKF988d5cDa3AFzLINB_ks5rCJM3gaJpZM4K8s0A
.

Just now I found out that the sangle=0 always and therefore https://github.com/kivy/kivy/blob/master/kivy/graphics/vertex_instructions_line.pxi#L564-L569 is  causing problems when the cap is square giving irregular line ends.Any idea how to solve this when cap='square' ?

Any progress here? We've had the fox#4752 in our local kivy tree for ages, and it does indeed solve the problem with round ends.

Bump this again. Is there some reason this wasn't getting merged? (or fixed a different way?) Is there something I can do to fix up the fix?

Sorry this fell out the radar, will look asap, seems you linked back there in previous comment, did you mean #4772 ?

Sorry, yes, that's the fix I mean.

So, fun thing, i was looking into this again, because that fix is quite crude, and i could only reproducing it by hand-drawing the line with the example code, all my hardcoded examples were fine, until i dumped the points coords created by the examples, and saving them.
which looked like this
        Line:
            width: 20
            points:
                [
                375.0,<PHONE_NUMBER>9999994,
                375.0,<PHONE_NUMBER>9999994,
                373.0,<PHONE_NUMBER>9999994,
                372.0,<PHONE_NUMBER>9999994,
                372.0, 407.0,
                370.0, 403.0,
                368.0,<PHONE_NUMBER>0000006,
                367.0, 398.0
                ]

So i commented out the 3 duplicate lines, and it went away. It's just that the duplicate points confuses the line algo, when it tries to find the segments angle, as these are 0-length segments, their angle is undefined, which leads to these beird behavior.
Editing the example code not to save the first point in on_touch down, seems to fix it too, but that might be just luck.
    def on_touch_down(self, touch):
        with self.canvas:
            touch.ud['current_line'] = Line(
                points=tuple(), width=self.line_width, cap=choice(caps), joint='round', cap_precision=5)

            touch.ud['current_line'].points += (touch.x, touch.y)

    def on_touch_move(self, touch):
        if 'current_line' in touch.ud:
            touch.ud['current_line'].points += (touch.x, touch.y)
            print(touch.ud['current_line'].points)

So, we could avoid these 0-length segments, either when points is assigned, (but that could be quite a performance cost), or during drawing, the downside here is that it wouldn't allow us to account for the saved points in the malloc, but that still seems better, efficiency wise?

diff --git a/kivy/graphics/vertex_instructions_line.pxi b/kivy/graphics/vertex_instructions_line.pxi
index 19ea74436..3b8282ec3 100644
--- a/kivy/graphics/vertex_instructions_line.pxi
+++ b/kivy/graphics/vertex_instructions_line.pxi
@@ -332,7 +332,7 @@ cdef class Line(VertexInstruction):
         cdef double pcx, pcy, px1, py1, px2, py2, px3, py3, px4, py4, pangle, pangle2
         cdef double w = self._width
         cdef double ix, iy
-        cdef unsigned int piv, pii2, piv2
+        cdef unsigned int piv, pii2, piv2, skip = 0
         cdef double jangle
         angle = sangle = 0
         piv = pcx = pcy = cx = cy = ii = iv = ix = iy = 0
@@ -346,7 +346,11 @@ cdef class Line(VertexInstruction):
             bx = p[i * 2 + 2]
             _by = p[i * 2 + 3]

-            if i > 0 and self._joint != LINE_JOINT_NONE:
+            if (ax, ay) == (bx, _by):
+                skip += 1
+                continue
+
+            if i - skip > 0 and self._joint != LINE_JOINT_NONE:
                 pcx = cx
                 pcy = cy
                 px1 = x1
@@ -384,7 +388,7 @@ cdef class Line(VertexInstruction):
             x3 = bx + cos2
             y3 = _by + sin2

-            if i == 0:
+            if i - skip == 0:
                 sx1 = x1
                 sy1 = y1
                 sx4 = x4
@@ -421,7 +425,7 @@ cdef class Line(VertexInstruction):
             iv += 1

             # joint generation
-            if i == 0 or self._joint == LINE_JOINT_NONE:
+            if i - skip == 0 or self._joint == LINE_JOINT_NONE:
                 continue

             # calculate the angle of the previous and current segment
@@ -498,8 +502,6 @@ cdef class Line(VertexInstruction):
                     ii += 6
                     iv += 2

-
-
             elif self._joint == LINE_JOINT_ROUND:

                 # cap end
@@ -644,6 +646,11 @@ cdef class Line(VertexInstruction):
             indices[ii + 2] = piv + 2
             ii += 3

+        while ii < indices_count:
+            indices[ii] = 0
+            print("catching up")
+            ii += 1
+
         # compute bbox
         for i in xrange(vertices_count):
             if vertices[i].x < self._bxmin:

Not very nice, but as long as the line has segments with a defined length, it seems to do the job.

Yes, the case where all points are equal should just draw both caps i guess, (which my fix doesn't do correctly), if i add even 1e-10 to one of the values, just to differenciate them, without any visible difference, the look is fixed, but maybe we should find a more elegant solution.


basic test cases

I have been using this library recently since I don't need the performance of C modules and much prefer the simplicity.
I imagine adapting existing test cases won't be too difficult (some have the same API), if you don't have time, I might consider working on it :)

Hello, I'm really happy to hear this library is being used!
I ran those tests and there are some failing tricky tests.
But unfortunately, now I don't have time to work on it.

Oh good to know, still, it would be nice to know what edge cases are failing, so people don't stumble into them. When you say those tests, you are referring to the repo I linked right?

Right.
tests from test_compat.lua
assert(utf8.find("", "") == 1) -- gives "nil" instead "1, 0"
assert(utf8.find("", "", 1) == 1) -- same

assert(utf8.byte("\xe4") > 127) -- 120
assert(utf8.sub("\000123456789",3,5) == "234") -- \000 is "Invalid UTF-8 character"
assert(utf8.sub("\000123456789", 8) == "789") -- same

assert(utf8.byte("hi", 9, 10) == nil) -- fails with "comparing nil with number"
assert(utf8.char() == "") -- same
assert(utf8.byte("\n\n", 2, -1) == 10) -- returns nil

I assume bugs related to symbol parsing are simple to fix (>= 0, ~= nil, etc).
To fix find("", "") you should look at matcher first and last functions in function list.
Matcher designed as list of chars, and list of checker-functions, checker-functions can mark positions on lists to rollback to. It's like state machine.
Hope it helps, may the force be with you :)

match(input, '([^%s]+)%s%s') should match the last 2 space but I find it able to match just one. string.match doesn't seem to behave this way, not sure it's a bug related to your comment or not.

It took me some time to fix this


Update index.md

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

sample1/index.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


MAINT: Pass leverage instead of account to risk.

The only value used in the account is leverage, so pass the leverage
value directly.
Also, remove account from risk init, since it is not used.

Other than the one question lgtm


PANIC whilst trying to do migrate task: runtime error: invalid memory address or nil pointer dereference

Description
I want to migrate repositories with related info like issues, pull requests, etc.
Tried once with the following settings:

But what I got is:

For debug purpose, you can check:

Gitea Version
1.20.0+rc0 built with GNU Make 4.4.1, go1.20.5 : bindata, timetzdata, sqlite, sqlite_unlock_notify
Can you reproduce the bug on the Gitea demo site?
No
Log Gist
No response
Screenshots
Got another issue on your Gitea demo site:

Git Version
2.40.1
Operating System
Synology DSM7.2
How are you running Gitea?
From docker image
Database
SQLite

the repo is public, don't need a Access token

the repo is public, don't need a Access token，please retry without Access token

What about the rate limit?

the repo is public, don't need a Access token，please retry without Access token

What about the rate limit? Also, the access token is required for selecting "Migration Items" options:

And do you have the relevant permissions for this repository?

And do you have the relevant permissions for this repository?

No, I just want to mirror the repo, with all related items also.

QQ Group:328432459

And do you have the relevant permissions for this repository?

No, I just want to mirror the repo, with all related items also.

Do not enter the Access token

And do you have the relevant permissions for this repository?

No, I just want to mirror the repo, with all related items also.

Do not enter the Access token

Hmm, you just reset the conversation back to https://github.com/go-gitea/gitea/issues/25793#issuecomment-1628031754...

sorry

And do you have the relevant permissions for this repository?

No, I just want to mirror the repo, with all related items also.

Don't pick the issue


Inline styles

Is there someway to prevent the editor to add inline styles to html tags?

I believe this can be achieved by hooking into quill's api. Could you give a little more detail as to what you wanting to achieve? For example, if bold is selected, how would that get styled?

Sometime it adds inline styles to the tags like style="color: black;". I just want it to add the tags like <b> or <strong> etc.
The rest of the editor works great though!

The only way I was able to achieve this was by setting the color via the toolbar. Is this how you did it?


Using webarena in async environment?

Is there a way to use the webarena ScriptBrowserEnv in an async context? For some context on my use case, I'm not using the bundled run.py, but rather building up my own eval loop (following minimal_example.py as a guideline).
The system I'm working on requires running as async, and it seems like WebArena is tightly coupled with the Sync API of Playwright (which in turn does not play nice with another asyncio loop running in parallel). I've done some digging and see that there's an AsyncScriptBrowserEnv, but this does not seem to match the API of ScriptBrowserEnv. Do you have any additional context as to how we might accomplish this?

Hi, great question! AsyncScriptBrowserEnv was very half-baked. At this point, we do not have plans to support async environments but contributions are welcome! Curious about what scenarios you are working on. Would scripts like this which launches parallel runs be helpful to you?

Got it. I think a workaround would be to run the core WebArena loop in a separate process and communicate with the system under test using HTTP -- I'll try this out and update my results here soon.
In particular, I'm the lead developer of the Kani library (GH: https://github.com/zhudotexe/kani; paper: https://aclanthology.org/2023.nlposs-1.8/), which provides an interface for function calling with LLMs. Right now I'm working on a multi-agent system project, which relies heavily on async for running agents in parallel without the need for multiprocessing/threading code (which trips up a lot of Python programmers - I could rant about this for quite some time).
It seems like the parallel run script is primarily a wrapper around tmux, so not quite what I'm looking for, but thanks for the pointer.

Seems like running it as an HTTP server won't work either, as frameworks like Flask process incoming requests in greenlets (which interfere with synchronous Playwright when the Playwright instance needs to be shared across multiple requests).
I've had some success in running all the webarena code in a separate process launched by my main system, which then communicates using a multiprocessing Pipe:
main.py
import multiprocessing

(wa_send, wa_recv) = multiprocessing.Pipe()
wa_process = multiprocessing.Process(target=wa_entrypoint, args=(wa_recv,))
wa_process.start()

for task_config in task_configs:
    # ... code to run system here
    # pseudocode:
	wa_send.send({"cmd": "reset", "data": {"task_config": task_config}})
	wa_send.recv()
    while not done:
		wa_send.send({"cmd": "get_prompt"})
        prompt = wa_send.recv()
		action = system.do_work(prompt)
		wa_send.send({"cmd": "action", "data": {"action": action}})
		wa_send.recv()
		# ...
	wa_send.send({"cmd": "score"})
	score = wa_send.recv()
	# ...
wa_send.send({"cmd": "stop"})
wa_process.join()

subprocess.py
from multiprocessing.connection import Connection
from typing import Any, TypedDict

from browser_env import Action, ScriptBrowserEnv, StateInfo, Trajectory, create_stop_action
from evaluation_harness import evaluator_router

from .utils import map_url_to_real

# ===== wa config ====
WA_HEADLESS = False
WA_TRACE = True

# ===== commands =====
class WASubprocessCommand(TypedDict, total=False):
    cmd: str
    data: Any

# ===== state =====
class State:
    """Store the state of a trial in this class."""

    def __init__(self, env: ScriptBrowserEnv):
        self.env = env
        self.config_file = None
        self.trajectory: Trajectory = []
        self.obs = None
        self.info = None
        self.last_action_success = None

    def save_state_to_trajectory(self):
        """Save the browser state to the trajectory. Called after setup and each action."""
        state_info: StateInfo = {"observation": self.obs, "info": self.info}
        self.trajectory.append(state_info)

    def reset(self, config_file: str):
        """Reset the WA env to the initial state for this trial."""
        self.config_file = config_file
        self.trajectory = []
        self.last_action_success = True
        self.obs, self.info = self.env.reset(options={"config_file": config_file})
        self.save_state_to_trajectory()

    def action(self, action: Action):
        """Save the action to the trajectory, take it, save the resulting state, and return the result."""
        self.trajectory.append(action)
        self.obs, self.last_action_success, _, _, self.info = self.env.step(action)
        self.save_state_to_trajectory()
        # return self.obs, self.last_action_success, self.info

    def get_prompt(self, task: str) -> str:
        """Get the prompt at the current state:
        {observation}
        URL: {url}
        OBJECTIVE: {objective}
        [ERROR: {extra}] (if not last_action_success)
        """
        obs = self.obs["text"]
        page = self.info["page"]
        url = map_url_to_real(page.url)

        raw = f"BROWSER STATE:\n{obs}\nURL: {url}\nOBJECTIVE: {task}"
        if self.last_action_success:
            return raw
        error = self.info["fail_error"]
        return f"{raw}\nERROR: {error}"

    def end(self, answer: str):
        """Called once when the system finishes its task."""
        self.trajectory.append(create_stop_action(answer))

    def get_score(self):
        evaluator = evaluator_router(self.config_file)
        score = evaluator(
            trajectory=self.trajectory,
            config_file=self.config_file,
            page=self.env.page,
            client=self.env.get_page_client(self.env.page),
        )
        return score

    def save_trace(self, path: str):
        if WA_TRACE:
            self.env.save_trace(path)

def wa_entrypoint(pipe: Connection):
    """Main entrypoint for the subprocess.

    Creates the environment and listens for commands from the pipe until a STOP command is received.

    POSTCONDITION: Every received command will send back exactly one response.
    RESTRICTION: No commands will be sent in parallel.
    """
    wa_env = ScriptBrowserEnv(
        headless=WA_HEADLESS,
        observation_type="accessibility_tree",
        current_viewport_only=False,
        viewport_size={
            "width": 1280,
            "height": 720,
        },
        save_trace_enabled=WA_TRACE,
        sleep_after_execution=0.0,
    )
    state = State(wa_env)
    running = True

    while running:
        # recv
        retval = None
        data: WASubprocessCommand = pipe.recv()

        # process
        try:
            match data:
                case {"cmd": "stop"}:
                    running = False
                case {"cmd": "reset", "data": {"config_file": config_file}}:
                    retval = state.reset(config_file)
                case {"cmd": "action", "data": {"action": action}}:
                    retval = state.action(action)
                case {"cmd": "get_prompt", "data": {"task": task}}:
                    retval = state.get_prompt(task)
                case {"cmd": "end", "data": {"answer": answer}}:
                    retval = state.end(answer)
                case {"cmd": "score"}:
                    retval = state.get_score()
                case {"cmd": "save_trace", "data": {"path": path}}:
                    retval = state.save_trace(path)
                case other:
                    print(f"!!! UNKNOWN COMMAND IN WA IPC !!!\n{other}")
                    raise ValueError("Unknown command")
        except Exception as e:
            retval = e

        # return
        pipe.send(retval)

    # clean up
    wa_env.close()


"WHAT IS 4C?" colour contrast

Issue:
Colour contrast on the small text above the

What is 4C?

The Cool Community For Content Creators

The current contrast is 3.35:1 and needs to be 4.5:1 minimum.
Suggested Fix Options:
1. Put the text within a box with a dark background with rounded corners.

Styles
background-color: #212121; /*this is 4.54:1 contrast ratio */
display: inline-block;
padding: 0.5rem 1rem;
border-radius: 0.5rem;
margin-left: -1rem;
margin-bottom: -1rem;

2. Make the text darker (introduce third colour that allows for sufficient contrast).
A darker text colour, either the existing body text grey (text-gray-500) or another to be decided.

3. Make the text larger
Make the font size 24px equivalent (preferable to use rem which would be font-size: 1.5rem or tailwind equivalent)

Anyone working on this issue?

@StarTrooper08 nope, all yours! 😁

@StarTrooper08 we would love to have you contribute. Do you want me to assign you this. Also it is recommended to change the styling to either the second or the third one.

Sure you can assign me this issue

Assigned! :)

I feel like the third option ( make the text larger ) is a better option.
what do you say @ayushhagarwal ?

Before

After

Did the font size for (What is 4C?) to 1.34rem.
font-size on  1.5rem seemed to be larger and it was getting overlapped by the contributor's button when I view it on small window size.
font size at 1.5rem 👇

It has to be font-size: 1.5rem to meet minimum standards for contrast and font size.
I would suggest the fix would be to add some padding or margin to the top of the container at mobile size to push it down far enough that there is no overlap. 👍

Ohk👍


WIP demonstrate OAuth tokens can't be used post TGT expiry

Follows on from #3206, demonstrating:

Generate a TGT, and then an AT off of that.
Create an RT off of that AT and TGT.
Expire the TGT
Observe the behavior when you use/exchange the AT.  (Right now: AT is considered expired)
Observe the behavior when you use/exchange the RT for yet another AT. (Right now: RT is considered expired)

RefreshTokenTimeoutTests is a simple test, testing the tokens expiry directly, whereas the OAuth20AccessTokenControllerTests test the ticket consumption via the controller.

Merging so as to review and provide a diagnosis. Thank you @sbearcsiro . Please stay tuned.

Please review the latest commits and children of BaseOAuthExpirationPolicyTests to verify behavior.


Citation metadata

This is required for publications.  I validated it too
cffconvert --validate
Citation metadata are valid according to schema version 1.2.0.
syntax checked by:
https://pythonlang.dev/repo/citation-file-format-citation-file-format/

I would write "Universität Hamburg" for Marcs affiliation

I would write "Universität Hamburg" as Marcs affiliation


Feature/poet 3 connect to jira

The JIRAconnector class for requesting data from JIRA server.
getDescription(id) and getAssignee(id) methods were set and will return strings.Try JIRAconector.function_name() to test.
The authentication was basic auth and used my name/password, so currently these methods can only handle tickets assigned to me. This can be changed in later releases.
This branch's name is slightly different from JIRA's but both refer to ticket POET-3. Another branch called POET-3-request-from-JIRA-API was created by accident and make no sense.

Can you remove all .idea file changes and push again? There are 2500+ file.

.idea/ is removed now.
ready to be reviewed.


getting this CUDA issue in Automatic1111

seems bitsandbytes was installed with A4.  i didn't seek  out the extension but seems it's been added to the main repo.  getting this error when i run  :
===================================BUG REPORT===================================
================================================================================
The following directories listed in your path were found to be non-existent: {WindowsPath('tmp/restart')}
CUDA_SETUP: WARNING! libcudart.so not found in any environmental path. Searching in backup paths...
The following directories listed in your path were found to be non-existent: {WindowsPath('/usr/local/cuda/lib64')}
DEBUG: Possible options found for libcudart.so: set()
CUDA SETUP: PyTorch settings found: CUDA_VERSION=118, Highest Compute Capability: 8.6.
CUDA SETUP: To manually override the PyTorch CUDA version please see:https://github.com/TimDettmers/bitsandbytes/blob/main/how_to_use_nonpytorch_cuda.md
CUDA SETUP: Loading binary C:\AI\stable-diffusion-webui_bak\venv\lib\site-packages\bitsandbytes\libbitsandbytes_cuda118.so...
argument of type 'WindowsPath' is not iterable
CUDA SETUP: Problem: The main issue seems to be that the main CUDA runtime library was not detected.
CUDA SETUP: Solution 1: To solve the issue the libcudart.so location needs to be added to the LD_LIBRARY_PATH variable
CUDA SETUP: Solution 1a): Find the cuda runtime library via: find / -name libcudart.so 2>/dev/null
CUDA SETUP: Solution 1b): Once the library is found add it to the LD_LIBRARY_PATH: export LD_LIBRARY_PATH=$LD_LIBRARY_PATH:FOUND_PATH_FROM_1a
CUDA SETUP: Solution 1c): For a permanent solution add the export from 1b into your .bashrc file, located at ~/.bashrc
CUDA SETUP: Solution 2: If no library was found in step 1a) you need to install CUDA.
CUDA SETUP: Solution 2a): Download CUDA install script: wget https://github.com/TimDettmers/bitsandbytes/blob/main/cuda_install.sh
CUDA SETUP: Solution 2b): Install desired CUDA version to desired location. The syntax is bash cuda_install.sh CUDA_VERSION PATH_TO_INSTALL_INTO.
CUDA SETUP: Solution 2b): For example, "bash cuda_install.sh 113 ~/local/" will download CUDA 11.3 and install into the folder ~/local

I am too.. I have to keep deleting the bitsandbytes folder in \Stable Diffusion\stable-diffusion-webui\venv\Lib\site-packages\ and then
git clone https://github.com/TimDettmers/bitsandbytes.git
cd bitsandbytes
python setup.py install
every single time I close auto1111 and open it again.

I am too.. I have to keep deleting the bitsandbytes folder in \Stable Diffusion\stable-diffusion-webui\venv\Lib\site-packages\ and then
git clone https://github.com/TimDettmers/bitsandbytes.git cd bitsandbytes python setup.py install
every single time I close auto1111 and open it again.

could work as a temp fix. seems to be working? i think probably easy enough to python or powershell script something like this to automate. and then afterpython setup.py install .... you run the web gui after?

I still haven't figured out what the actual issue is, but it did start when I updated my extensions, this is the current work around..
@echo off
set FOLDER_PATH=D:\stable-diffusion-webui\venv\Lib\site-packages\bitsandbytes
if exist "%FOLDER_PATH%" (
rmdir /s /q "%FOLDER_PATH%"
echo Folder %FOLDER_PATH% deleted successfully.
) else (
echo Folder %FOLDER_PATH% does not exist.
)
git clone https://github.com/TimDettmers/bitsandbytes.git
cd bitsandbytes
python setup.py install
cd D:\stable-diffusion-webui
set PYTHON=
set GIT=
set VENV_DIR=
set COMMANDLINE_ARGS= --api --xformers
call webui.bat

I am too.. I have to keep deleting the bitsandbytes folder in \Stable Diffusion\stable-diffusion-webui\venv\Lib\site-packages\ and then
git clone https://github.com/TimDettmers/bitsandbytes.git cd bitsandbytes python setup.py install
every single time I close auto1111 and open it again.

could work as a temp fix. seems to be working? i think probably easy enough to python or powershell script something like this to automate. and then afterpython setup.py install .... you run the web gui after?

Ok, so I disabled ALL of my extensions (not built in), removed the script I posted above. It started up fine. I went through and toggled extensions on one at a time and closed and restarted through almost the whole list, aside from a few that I really don't use or were redundant. So it may be one of those causing the issue.
I don't plan on testing the rest, but I can if it would help others.
This is what is disabled for extensions that I have not tested -
StylePile
miaoshouai-assistant
rembg
sd-dynamic-prompts
sd-webui-lora-block-weight
sd-webui-openpose-editor
sd-webui-roop
sd_dreambooth_extension
stable-diffusion-webui-rembg

Bitsandbytes was not supported windows before, but my method can support windows.（yuhuang）
1  open folder J:\StableDiffusion\sdwebui，Click the address bar of the folder and enter CMD
or WIN+R, CMD  。enter，cd /d J:\StableDiffusion\sdwebui
2  J:\StableDiffusion\sdwebui\py310\python.exe -m pip uninstall bitsandbytes
3 J:\StableDiffusion\sdwebui\py310\python.exe -m pip uninstall bitsandbytes-windows
4 J:\StableDiffusion\sdwebui\py310\python.exe -m pip install https://github.com/jllllll/bitsandbytes-windows-webui/releases/download/wheels/bitsandbytes-0.41.1-py3-none-win_amd64.whl
Replace your SD venv directory file（python.exe Folder） here（J:\StableDiffusion\sdwebui\py310）

OR you are  Linux distribution (Ubuntu, MacOS, etc.)system ,AND CUDA Version: 11.X.
Bitsandbytes can support ubuntu.（yuhuang）
1  open folder J:\StableDiffusion\sdwebui，Click the address bar of the folder and enter CMD
or WIN+R, CMD  。enter，cd /d J:\StableDiffusion\sdwebui
2  J:\StableDiffusion\sdwebui\py310\python.exe -m pip uninstall bitsandbytes
3 J:\StableDiffusion\sdwebui\py310\python.exe -m pip uninstall bitsandbytes-windows
4 J:\StableDiffusion\sdwebui\py310\python.exe -m pip install https://github.com/TimDettmers/bitsandbytes/releases/download/0.41.0/bitsandbytes-0.41.0-py3-none-any.whl
Replace your SD venv directory file（python.exe Folder） here（J:\StableDiffusion\sdwebui\py310）


[Feature Request] 24 word mnemonic engraving option, all on a single side of SH01

I believe support for 24 word mnemonic was a late feature addition to v0.9.0
Currently a 24 word mnemonic requires 2 sides of a SH01 plate, this is due the the need for 24 words plus a CompactSeedQR, and makes sense due to the close synergy with Seedsigner.
However I want to use Seedhammer not just with stateless hardware wallets but also with devices like Coldcard, Passport and Bitbox02.  As these hardware wallets use 1-2 secure elements I am comfortable including them as part of my multi-vendor multisig in a non-stateless manner.
If it were possible to squeeze a 24 words mnemonic on a single side of a SH01 plate (whether with just a smaller font, or with engraving the first 4 letters, or leaving out the CompactSeedQR) that would allow users to hide their mnemonic by using a singe blank plate (15 pairs in the 30 pack), whereas since both sides of SH01 are engraved, one would need 2 blank plates to cover the single engraved plate (10 triplets in the 30 pack).
Thanks

+1
I feel this would be a great solution for 24 word. I like the 4 letter option as the font needs to be a decent size and keeping the QR is my preference...

+1 with a twist - the front of the plate would be two 12-word columns and the back of the plate would be a CompactSeedQR (21x21) or possible option to select a SeedQR as requested in issue #5.
This also gives users the option to engrave each side to it's own plate which would permit concealing the contents if you screwed each half together.

@cody-wastaken that is a great idea, as you say it would allow engraving on 2 separate plates to join them face to face, but also give to option to dry-run the QR code engraving entirely. The QR is very useful for stateless Seedaigner / Jade but not useful for Coldcard / etc which don't have a camera

I believe we already support your use case.

Create or import your singlesig wallet in eg. Sparrow.
Ask Sparrow to show the descriptor (little QR-icon under "Script Policy")
Scan the descriptor QR with the SeedHammer software ("Backup Multisig").

You will now be able to hammer either 12 or 24 words on SH01 or SH02 respectively.


[BUG] Cannot use source with intentional compile errors for ToolsExtension

Describe the bug
Compiler errors will make ToolsExtension believe that the compiler didn't start, failing the test run.
To Reproduce
Set up a test class with @ExtendWith(ToolsExtension.class) and feed it source code that makes the annotation processor report errors.
The test run will fail, with the somewhat misleading message Failed to start javac (javac actually runs, it merely returns a compilation error)
Expected behavior
DaemonCompiler.run should not throw a CompilationException. (Though it's weird that the test will hang indefinitely if I make the Results object a success to prevent the run() function from throwing that exception. I didn't look deeper at what's happening there.)
I also have been hoping that the Java compiler will return a best-effort AST if it hits compilation errors, and that I can inspect it.
Maybe that hope was misguided though and you can't use ToolsExtension with intentionally-failing Java code.

If I understand correctly you tried to feed the extension source code which contained compilation errors. In that case, I think JavacExtension will be more appropriate. See the javac extension.
Due to how ToolExtension works internally, I don't think it's possible for it to parse uncompilable code.

It's just the annotation processor that throws errors, javac can parse if no problems.
To the very least, the error message shouldn't say "could not start the java compiler", that's just misleading: The Java compiler started, spat out error messages, terminated normally, and ToolsExtensions even constructs a Results object.

But yeah I see what you mean; expecting javac to return an AST in case of errors, whether from an annotation processor or not, is likely going beyond what the TCK demands.

Could attach a short snippet of code that demonstrates this?
If an annotation processor throws an exception, it does mean that compilation has failed since it is assumed that the annotation processor has errored out unintentionally. For expected errors, i.e. annotation processor expected some other type, it should log a failure using the given Message instead.
If it fails with "could not start the Java compile" in the latter case, it's a bug with how ToolExtension.
If it's the first case:
The problem is there isn't a good way to distinguish between whether javac fails to start vs fails to compile code. See https://github.com/Pante/elementary/blob/f07194495b1b396523258307af342c93bce6c194/elementary/src/main/java/com/karuslabs/elementary/junit/DaemonCompiler.java#L115
I think that the error message is valid since javac starts with the annotation processor but stops compilation midway through due to the annotation processor failing. In a sense it "failed to start".

Nah, it's the example project that's erroring out.
The compiler messages also have just the annotation processor's error message.
Example project is at https://github.com/toolforger/elementary-demo .
I put a breakpoint in DaemonCompiler.run(), on the if (!results.success) { line, so it was easy to check the logs and see what actually happened.

On a tangent, I think I can work around the issue with erroring-out annotation processor - just leave out the annotations, make the tests not check that the annotation processor errors out but just that the conditions hold that will make it error out, in those code snippets that we believe should trigger specific error conditions.
Still, the error message is misleading. I think it's this code that needs a bit of a rewrite:
        try {
            var results = compiler.compile(files);
            if (!results.success) {
                throw new CompilationException(results.find().diagnostics());
            }

        } catch (Throwable e) {
            processor.environment.completeExceptionally(new CompilationException("Failed to start javac", e));
        }

I think it should be something like this:
        Results results;
        try {
            var results = compiler.compile(files);
        } catch (Throwable e) {
            processor.environment.completeExceptionally(new CompilationException("javac did not start, or crashed", e));
            return;
        }
        if (!results.success) {
            processor.environment.completeExceptionally(new CompilationException(results.find().diagnostics()));
        }

This also avoids wrapping a CompilationException in another CompilationException, so the exception stack trace will have a better noise-to-signal ratio.
I wanted to insert a "javac completed with error messages:" line before the results.find().diagnostics() messages, but it would have complicated the suggested code so I left it out for better clarity.

I think I get what you mean, but can't the if-statement be placed in the try-block? Also, any chance you would be willing to submit a PR for this on master heh?

I have found over the years that nesting tends to couple code blocks, which can hinder refactoring. It also creates a bias towards keeping the code path joined, even if it shouldn't be.
The exact decision is pretty subjective though, so I don't care much about the exact flow.
The subjectivity is also why I didn't create a PR: I don't know what your priorities are, so any PR would probably be rejected and require more work from both of us.

Fair enough, I'll create a PR later then, thanks for reporting this issue regardless!


QR Code not able to scan with UTF8

Changed UTF8 to ASCII that I could scan the QR code in my MacOS Terminal. With the UTF8 there was to much space between the lines and no scanner could identify the data. Maybe you insert both options to generate - with a 1/2 selection or just both in sequence.
qrencode -t UTF8 < ~/"$client.conf"
qrencode -t ASCII < ~/"$client.conf"

use term instead of terminal

Unable to reproduce.


Lost all User/ settings in VS Code (extensions, keybindings are gone)

I was updating my keybindings.json file, and my VS Code program started to lag. I got a prompt to refresh my editor to make my settings take effect. After I clicked to refresh, my keybindings.json file was almost completely empty. I found it fell back to a version from over a year ago, that happened to be backed up from the Settings Sync extension. I never used that extension since its initial sync.
After further investigation, I realized that all of my User/ data is gone. My keybindings, extensions, and my settings.json config all reset back to what data was there over a year ago.
While this could be something to do with Settings Sync, my strong suspicion is that something went wrong in VS Code, and Settings Sync was able to at least provide the last information it had.
Has this been reported by anyone else, and more importantly is there a built-in way for me to recover my settings?

VSCode Version: Version 1.31.1 (1.31.1)
OS Version: High Sierra 10.13.6

Does this issue occur when all extensions are disabled?: Yes/No

VSCode itself will not touch your user data directory, so I am assuming this is due to the extension you mention.


ValueError: Error looking at files

generated output

AutoPR encountered an error while trying to fix (redacted repo/issue).
Traceback
Traceback (most recent call last):
  File "/app/autopr/agents/brain_agent/base.py", line 75, in generate_pr
    self._generate_pr(event)
  File "/app/autopr/agents/brain_agent/simple_v1.py", line 27, in _generate_pr
    pr_desc = self.pull_request_agent.plan_pull_request(self.repo, issue, event)
  File "/app/autopr/agents/pull_request_agent/base.py", line 50, in plan_pull_request
    pull_request = self._plan_pull_request(repo, issue, event)
  File "/app/autopr/agents/pull_request_agent/rail_v1.py", line 392, in _plan_pull_request
    notes = self.write_notes_about_files(files, issue, filepaths)
  File "/app/autopr/agents/pull_request_agent/rail_v1.py", line 317, in write_notes_about_files
    raise ValueError('Error looking at files')
ValueError: Error looking at files

more context:
The issue was something like:
in path/to/file.tsx, update the "messages" and "files" Buttons to be IconButtons. also add aria-label properties to them.

The action's log seemed to output a ton of activity, but it said it failed before the action had even finished with the message above in the generated PR. Not sure why it failed.

Hey, thanks for reporting this.
That's an interesting error, I think I'd need to see the prompt and response to debug it. If you'd be comfortable sharing them privately, feel free to message me on Discord or email me at<EMAIL_ADDRESS>Though to be honest, I'm planning to rewrite the pull request agent in the next few days. You could just try running it again when I publish the new agent.


Escaping command

Escaping can be a challenge with the current syntax. What should this do?
cmd.execute(:ls, "hello world")

[71555-047a57b2] Running ls hello world
[71555-047a57b2]    ls: hello: No such file or directory
[71555-047a57b2]    ls: world: No such file or directory
[71555-047a57b2] Finished in 0.002 seconds with exit status 1 (failed)

Sure you can execute the command the way you have mentioned. The readme is definitely not comprehensive yet. If you run cmd.execute("ls -la > output") it will respect the redirect and execute the string as is. There are many ways to pass the arguments which try to mimic the spawn behaviour.

This is probably worth some further discussion. We might want to mimic the current Ruby behavior:
>> system("ls", "hello world")
ls: hello world: No such file or directory

Agree mimicking Ruby behaviour.

Do you have time to work on this?


Added XmlLoggingConfiguration.CreateFromXmlString(xml) helper

fixes https://github.com/NLog/NLog/issues/2819

@snakefoot doubting, I could add it to LoggingConfiguration instead of XmlLoggingConfiguration. What do you think?

Prefer that LoggingConfiguration knows nothing about XmlLoggingConfiguration

OK thx for the feedback!


Hand movement detection for helping with device usage for the crippled

Hey, I was thinking that a hand movement detection for the screen could help in daily life as it could make it easier for many. I would like to work on this under GSSOC'23.

GO AHEAD @oshinsaraf


Which option is performing DWPose

I was just wondering which option is performing DWPose, do I change the mode='balanced' to be able to use DWPose? If not what should I change to perform DWPose

Hi @KahHan19 ,since DWPose is a distilled version of RTMPose, you can just pass its model links to RTMPose. I have updated the download links of DWPose models in README.


Add ability to drag file into a phosphor dock area

Wait for merge of new drag drop behavior in the dock panel.

cc @afshin

Add a widgetFactory that we use in the plugin to create drop targets for the dock panel which are editor widgets.
https://github.com/afshin/phosphor-dashboard/blob/master/src/listitem.ts

Add a widgetFactory that we use in the plugin to create drop targets for the dock panel which are editor widgets.
https://github.com/afshin/phosphor-dashboard/blob/master/src/listitem.ts


Don't steal nodes when not reusing nodes

Previously, node reuse was part of the handshake between nodes but two
MSBuild process cones started at roughly the same time could steal each
other's newly-created processes:

MSBuild A would start a process with /nr:false
MSBuild A' would start and wait for a connection
MSBuild B would look for live nodes that accepted its handshake
MSBuild B would connect to and handshake with MSBuild A'
MSBuild A would try to connect to MSBuild A', fail, and start another
new process.

Prevent this by only attempting to connect to processes we started when
using /nr:false. Fixes #3140.
The only change is wrapping the formerly #ifed connect-to-idle-node code with an additional runtime check. Whitespace makes it look bigger.

@ryanbrandenburg @natemcmaster FYI, I put privates built off this commit into ~/.dotnet/sdk in https://github.com/aspnet/BuildTools/pull/627 and the tests don't hang (since you're already using /nr:false).

Thanks @rainersigwald! Once we have an SDK with this fix, let me know and I can work on getting it into aspnet.


get_bandwidth_per_quantizer is incorrect.

🐛 Bug Report
    def get_bandwidth_per_quantizer(self, sample_rate: int):
        """Return bandwidth per quantizer for a given input sample rate.
        """
        return math.log2(self.bins) * sample_rate / 1000

it should be
        return math.log2(self.bins) * sample_rate / 1000 / self.hop_length

My bad. sample_rate is already divided by sample rate.


Can't upgrade to @nuxt/scripts ^0.7.0 because peerDependencies from @nuxtjs/turnstile is: "@nuxt/scripts": "^0.6.0"

🐛 The bug
Hello, we are unable to update Nuxt Scripts due to the peer dependencies of this project.
Thank you for your efforts!
🛠 To reproduce
https://stackblitz.com/github/nuxt-modules/turnstile/tree/main/playground
🌈 Expected behaviour
Now that Nuxt Script has been released, no more limited dependency on future versions
ℹ Additional context
No response

Same issue here

Same issue here:
npm error code ERESOLVE
npm error ERESOLVE unable to resolve dependency tree
npm error
npm error While resolving<EMAIL_ADDRESS>npm error Found<EMAIL_ADDRESS>npm error node_modules/@nuxt/scripts
npm error   dev<EMAIL_ADDRESS>from the root project
npm error
npm error Could not resolve dependency:
npm error peer<EMAIL_ADDRESS>|| ^0.7.0 || ^0.8.0" from<EMAIL_ADDRESS>npm error node_modules/@nuxtjs/turnstile
npm error   dev<EMAIL_ADDRESS>from the root project
npm error
npm error Fix the upstream dependency conflict, or retry
npm error this command with --force or --legacy-peer-deps
npm error to accept an incorrect (and potentially broken) dependency resolution.


[test] fix android build check

OPENTHREAD_CONFIG_FILE is now defined in OPENTHREAD_PROJECT_CFLAGS in
OpenThread. This PR adds the definition to fix android build check.

fix Travis CI fail? @bukepo


Issue 6985: Bare metal upgrade should honor the TinkerbellDatacenterC…

…onfig.skipLoadBalancerDeployment config value
Issue 6985:
https://github.com/aws/eks-anywhere/issues/6985
Description of changes:
Ensures the value of TinkerbellDatacenterConfig.skipLoadBalancerDeployment is honored when upgrading a bare metal cluster.  If set to true then kube-vip should not be installed.
Testing (if applicable):
Covered by existing and built the local binary and ran for our clusters and worked as expected
Documentation added/planned (if applicable):
Already documented in the bare metal configuration options
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

/ok-to-test

/test eks-anywhere-presubmit

/approve

/cherry-pick release-0.18


IoU values coming out as negative or > 1

How can this happen? Loss is also negative, model always converges to predicting all class 0
`genargs = dict(
brightness_range=[0.5, 2],
rotation_range=180,
zoom_range=[0.3,2],
horizontal_flip=True,
vertical_flip=True
)
xgen = ImageDataGenerator(**genargs)
ygen = ImageDataGenerator(**genargs)
compute quantities required for featurewise normalization
(std, mean, and principal components if ZCA whitening is applied)
seed = 1
xgen.fit(x_train, augment=True, seed = seed)
ygen.fit(y_train, augment=True, seed = seed)
epochs = 1000
saves = 10
fits the model on batches with real-time data augmentation:
###seg model
BACKBONE = 'inceptionv3'
x_train=sm.backbones.get_preprocessing(BACKBONE)(x_train)
#need to get them to 528 x 672
x_train = np.pad(x_train, ((0,0), (0,16),(0,32),(0,0)), 'mean')
x_train = np.concatenate((x_train,x_train,x_train), axis = 3)
add the padding as background class
y_train = np.stack([np.pad(y_train[:,:,:,0], ((0,0), (0,16),(0,32)), 'constant', constant_values=1),
np.pad(y_train[:,:,:,1], ((0,0), (0,16),(0,32)), 'constant', constant_values=0),
np.pad(y_train[:,:,:,2], ((0,0), (0,16),(0,32)), 'constant', constant_values=0)], axis = 3)
model = sm.PSPNet(BACKBONE, input_shape=(528,672,3), classes=3, encoder_weights=None, psp_use_batchnorm=False)
model.compile(keras.optimizers.Adam(), #lr=1e-4, epsilon=1e-8, decay=1e-6
loss=sm.losses.jaccard_loss, metrics=[sm.metrics.f_score])
batch_size=4
initial_epoch = 0
if train:
x_train = y_train

xgen = xgen.flow(x_train, batch_size=batch_size, seed=seed)
# class mygen:
#     def __next__(self):
#         yield sm.backbones.get_preprocessing(BACKBONE)(xgen.next())
ygen = ygen.flow(y_train, batch_size=batch_size, seed=seed)
train_generator = zip(xgen, ygen)

subset = round(epochs / saves)
for current_epoch in range(subset):
    model.fit_generator(train_generator, #class_weight={0: 1, 1: 5, 2: 1},
                    steps_per_epoch=len(x_train) / batch_size, epochs=saves, verbose = 1, initial_epoch=initial_epoch)`

I'm setting
x_train = y_train
as a test, seeing if the model can just predict the input as its output.

Input images should be in range (0, 255)
Ground truth masks - binary images {0, 1}


Replace rustls with mbedtls in veracruz-client.

Our forks of rust-mbedtls and rust-psa-crypto now use the same config.

(Sorry, @mathias-arm not @dreemkiller.  I was thinking of the wrong PR.)

+1+1 = +1 reached, merging.


A11y improvements and dependency updates

Thanks for making an awesome open-source link-in-bio platform. I made some improvements that I'd love to contribute back to the root repo.

Made some accessibility improvements. The header image needed alt text and the footer image needed alt text. MDX was compiling child of all buttons as paragraph tags, and paragraph tags cannot be nested inside of anchor tags. I've replaced them with span tags. I also increased the color contrast for muted buttons when they are being hovered.
Updated all dependencies and locked them to exact versioning (to avoid issues with version discrepancies.) I also added .npmrc to save any future dependencies with their exact versions going forward.
Added rel="noopener noreferrer" to the Button component to avoid a security loophole with target="_blank" (https://www.jitbit.com/alexblog/256-targetblank---the-most-underestimated-vulnerability-ever/)
Fixed any build errors that came about due to these changes (and also added a descriptive comment for a specific type issue I was facing.)

Thanks for these super helpful contributions! Always looking for ways to make what I create more accessible :)


added json option

This is the command line option to allow for a json output file
one can now type -j FILENAME and the output will be in json
Added option for json output

This is the command line option to allow for a json output file
one can now type -j FILENAME and the output will be in json
Added option for json output
PS- Not sure really what Im doing here as this is my second ever GITHUB pull request and first time ever contributing to the open source community.

We're all learning, thank you for contributing.