Permissions not reloaded for online player using NetEvents

Issue
When using NetEvents plugins, if I add a permission node of an online player from the master NetEvents server, the permissions of the player aren't reloaded.
It only reloads the player's permissions if he's not online.
How to reproduce
Scenario 1 : player (testPlayer) online

Login on server 2 with testPlayer
Command from server 2 (netevents slave)
/pex user testPlayer check test.node -> null
Command from server 1 (netevents master)
/pex user testPlayer add test.node
Command from server 2 (netevents slave)
/pex user testPlayer check test.node -> null

Result : testPlayer's permissions weren't updated
Scenario 2 : player (testPlayer) offline

Command from server 2 (netevents slave)
/pex user testPlayer check test.node -> null
Command from server 1 (netevents master)
/pex user testPlayer add test.node
Command from server 2 (netevents slave)
/pex user testPlayer check test.node -> testPlayer has test.node

Result: testPlayer's permissions were updated
What I expected
The expected behavior should be that in both scenarios (player offline or online) it should update the player's permissions with the new permission node.

For senecio 1, after you have issued the command to set the players permission, can you issue "/pex reload" and feed back results?

yes if I issue /pex reload, the check test.node works the same as in scenario 2 but it should work without doing this reload, otherwise it's useless :/

Well, NetEvents doesn't edit PermissionEx's permissions in memory. The reason why pex reload is fixing it is because pex is replacing the permissions in memory with the ones on file. When a player joins (thus scenario 2) pex will commit that players permissions to memory. In scenario 1, the player is logged in and pex will not continuously to search for new permissions.
A developer will either have to change NetEvents API to change whats in memory, or you can change your plugin that handles global command handling. I use ExecuteEverywhere for global command handling. (Requires A redis server to work)

Unfortunately PermissionsEx is currently unmaintained and no further updates are planned. Because of this, all pull requests are being closed. If you are looking for an actively maintained permissions plugin, take a look at LuckPerms. It is compatible with major server platforms and can import data from PEX.


Split Aggregator into Native and Halo2 version

Native version:
https://github.com/eigen-trust/protocol/blob/master/circuit/src/verifier/aggregator.rs#L65-L106
https://github.com/eigen-trust/protocol/blob/master/circuit/src/verifier/aggregator.rs#L171-L222
Halo2 version:
https://github.com/eigen-trust/protocol/blob/master/circuit/src/verifier/aggregator.rs#L108-L139C1
https://github.com/eigen-trust/protocol/blob/master/circuit/src/verifier/aggregator.rs#L243-L409
Make folder named aggregator:

native.rs
mod.rs

EDIT:
We also want to make a native version of aggregator chip, where the logic of aggregation is done using NativeTranscriptRead and NativeLoader.
Reference logic:
https://github.com/eigen-trust/protocol/blob/a3dbc1002d45ccbb57d404e611e00de1d1abcf4b/circuit/src/verifier/aggregator.rs#L325-L400

@duguorong009 Updated the issue


switches with fall-through cases

The converter does not correctly handle stuff like this:
switch (whatever) {
case FOO:
case BAR:
    something();
    break;
}

In this case it actually just silently eliminates one of the cases, which results in bugs when transforming Java code.
It should produce this code:
switch (whatever)
case (foo, bar) {
    something();
}

And what about nonempty fall-through cases? (C# disallows them, but they’re legal in Java.) There’s no really good way to map them to Ceylon I think, so IMO a // TODO Java fall-through would be enough.

@lucaswerkmeister Good point.


Add info about the default service name

Why
Especially for IIS configuring the SIGNALFX_SERVICE_NAME can be cumbersome to configure. We want to avoid this configuration if possible.
What
Documenting the default service name and making the case that the user just needs to set it if the default doesn't work for their scenario.
Tests
N/A (docs only)

Thanks for the suggestions @theletterf

Test run failure:
Error: [xUnit.net 00:01:07.03]     Datadog.Trace.ClrProfiler.IntegrationTests.SmokeTests.AssemblyLoadFileNotFoundExceptionSmokeTest.NoExceptions [FAIL]
    Failed Datadog.Trace.ClrProfiler.IntegrationTests.SmokeTests.AssemblyLoadFileNotFoundExceptionSmokeTest.NoExceptions [1 m]
    Error Message:
     System.TimeoutException : The smoke test is running for too long or was lost.
    Stack Trace:
       at Datadog.Trace.ClrProfiler.IntegrationTests.SmokeTests.SmokeTestBase.CheckForSmoke(Boolean shouldDeserializeTraces) in Y:\tracer\test\Datadog.Trace.ClrProfiler.IntegrationTests\SmokeTests\SmokeTestBase.cs:line 127
    Standard Output Messages:
   Application path: Y:\tracer\test/test-applications/regression\AssemblyLoad.FileNotFoundException\bin\X64\Release\net461\AssemblyLoad.FileNotFoundException.exe
   Executable path: Y:\tracer\test/test-applications/regression\AssemblyLoad.FileNotFoundException\bin\X64\Release\net461\AssemblyLoad.FileNotFoundException.exe
   Assigning port 50552 for the aspNetCorePort.
   Assigned port 50553 for the agentPort.
   The smoke test is running for too long or was lost.
   StandardOutput:
   All is well!


in jupyter notebook any way to set model.fit() output error frequency?

model.fit() with verbose = 1 can output error status, however, sometimes it is too fast that the webpage is getting slow..remember jupyter notebook is still a webpage..  is there anyway to get around with his?

You can set verbose to either 0 or 2, use the RemoteMonitor callback (or a variant of it that also posts data on batch_end), and write your own web service to display the data. If you are using TensorFlow, TensorBoard may be an option. But barring those two options, right now, there is no other option other than TensorBoard for TensorFlow, or just logging less data.
Jupyter does not handle the screen clears correctly, and accrues the output, making the notebook larger and larger. If you look at a saved notebook after the .fit method, you'll see stuff like this:
[=>...................]
[==>..................]
[===>.................]
[====>................]

which quickly gets to be a lot of data.

Thanks for the response. Actually I use tensorboard to monitor my work on workstation. The workstation works on a dropbox file folder so I can see what's going on by just tensorboard at this dropbox.
Another option I just find is that, use command line rather than ipython notebook..which is much faster for output to screen.


Build(deps-dev): Bump @testing-library/user-event from 14.0.1 to 14.0.4 (#3246)

Pull request opened by the merge tool on behalf of #3246

Merged in 0f6c35daa09a76b1a50464e4d0cdfa570a30acd7


api.helper.get.is_locale checks only for capitalized 2 letter strings

Just to clarify from the other thread, I'm assuming the intent was to check only for capitalized 2 letter strings.
Previous behavior:
gmail.helper.get.is_locale("US");
true

gmail.helper.get.is_locale("Us");
false

gmail.helper.get.is_locale("uS");
false

gmail.helper.get.is_locale("us");
**true**

New behavior:
gmail.helper.get.is_locale("US");
true

gmail.helper.get.is_locale("Us");
false

gmail.helper.get.is_locale("uS");
false

gmail.helper.get.is_locale("us");
**false**

Hey there and thanks for the PR.
To be clear, I'd like to the match to be 100% case-insensitive. That is, a check for "US", "us", "Us" or "uS" should all succeed.
Gmail.js has a way of being somewhat "fuzzy" about matching and just trying to make things work, and this function should ideally be no different :smiley:

Also that bad CI tells me we should be migrating to GitHub Actions too. Yay.

In that case, shouldn't it just return true once we know the string doesn't contain any numbers? Or do you want some other formal checks?
   api.helper.get.is_locale = function(locale) {
        // A locale is a string that begins with 2 letters, either lowercase or uppercase
        // The "lowercase" check distinguishes locales from other 2-letter strings like "US"
        // (the user"s location?).
        if (!locale || ((typeof locale) !== "string") || locale.length < 2) {
            return false;
        }

        if (locale.match(/[0-9]/)) {
            return false;
        }

        var localePrefix = locale.slice(0, 2);
        // perform additional check ?
        // return localePrefix.toUpperCase() === localePrefix;
        return true;

    };

Yeah you're right. Looking at the code now, I must admit I don't remember the exact reason for it being the way it is, and whatever particular quirks I encountered when writing it (basically as a support function for gmail.get.localization()).
For now though, I think it's best to leave it as is, unless anyone can pinpoint particular issues the current implementation this is causing.
Sorry for wasting your time :disappointed:


fix(docs): Update README Components links to new URL pattern

We don't use HashRouter anymore, so the links no longer begin with #. Also adds anchors to the Forms page for each of the components listed (radio, checkbox, and so forth).
Breaking changes
None.
Features
None.
Bug fixes

[x] Update README Components links to new URL pattern

Thank you! I made those changes and also:

[x] Changed Sidebar to not be under construction
[x] Reverted some other links that were broken (Typography, components that are not yet converted to flowbite-react yet)

@bacali95
Thank you! I made those changes and also:

[x] Changed Sidebar to not be under construction
[x] Reverted some other links that were broken (Typography, components that are not yet converted to flowbite-react yet)

Great thanks, let's merge this one


Update version to 1.0.70-0 on staging

Update version to 1.0.70-0

🚀 Cherry-picked to staging in version: 1.0.70-0🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production in version: 1.0.73-3🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


Added a 'wait' argument to control how long the radio waits to receive a message

In a project using a few Circuit Playground Bluefruit boards, I needed a way to control how long each board waited for a new message. With the edits in this request, it is possible to pass a wait keyword argument to any receive call.
Usage, in my case:
radio.receive(wait=0.2)
I am not a programmer by trade, so my apologies if this is absolutely not the right way to do a pull request!

Thanks again @FoamyGuy for your feedback! I made the changes on my branch, but I'm not sure if I need to close this request and open a new one, or is it possible to share my newest commits within this request?

@mlupo thanks for working on that. They are updated here automatically once pushed into your branch so there is no need to close / make a new PR. This one contains all of the latest changes now.
I will circle back and look this over again this evening.


connect({}) throws runtime error, yet compiles according to type system

Current Behavior
After upgrading to current version of web3onboard/react, my code fails due to connect({})
Expected Behavior
should not fail since ConnectOptions allows for undefined autoSelect. Getting autoSelect is undefined in index.svelte.
Steps To Reproduce
Call the connect function with {}
What package is effected by this issue?
@web3-onboard/core
Is this a build or a runtime issue?
Runtime
Package Version
2.9.1
Node Version
20.11
What browsers are you seeing the problem on?
Firefox
Relevant log output
TypeError: autoSelect is undefined
    4 Index.svelte:418
    RxJS 14
    instance$4 Index.svelte:415
    init$1 index.mjs:2165
    Index$1 index.2d3ace14.js:216334
    create_if_block_20 index.2d3ace14.js:216795
    p index.2d3ace14.js:218159
    update index.mjs:1347
    flush index.mjs:1307
    promise callback*schedule_update index.mjs:1258
    make_dirty index.mjs:2133
    ctx index.mjs:2171
    instance index.2d3ace14.js:218324
    RxJS 26
    dispatch$1 index.ts:117
    setWalletModules actions.ts:216
    connect$1 connect.ts:30
    connect useConnectWallet.js:12
    walletSelect useWeb3.tsx:165
    React 23
    ["4aBH6"]< index.tsx:95
    newRequire index.2d3ace14.js:71
    <anonymous> index.2d3ace14.js:122
    <anonymous> index.2d3ace14.js:145

Uncaught (in promise) TypeError: ctx[0] is undefined
    create_fragment$4 Index.svelte:580
    init$1 index.mjs:2180
    Index$1 index.2d3ace14.js:216334
    create_if_block_20 index.2d3ace14.js:216795
    p index.2d3ace14.js:218159
    update index.mjs:1347
    flush index.mjs:1307
    promise callback*schedule_update index.mjs:1258
    make_dirty index.mjs:2133
    ctx index.mjs:2171
    instance index.2d3ace14.js:218324
    RxJS 26
    dispatch$1 index.ts:117
    setWalletModules actions.ts:216
    connect$1 connect.ts:30
    connect useConnectWallet.js:12
    walletSelect useWeb3.tsx:165
    React 23
    ["4aBH6"]< index.tsx:95
    newRequire index.2d3ace14.js:71
    <anonymous> index.2d3ace14.js:122
    <anonymous> index.2d3ace14.js:145
Index.svelte:580:6

Anything else?
No response
Sanity Check

[X] If this is a build issue, I have included my build config. If this is a runtime issue, I have included reproduction steps and/or a Minimal, Reproducible Example.

@bengobeil please give this a shot with @web3-onboard/react v 2.9.2-alpha.2 should be fixed but would love confirmation on your end prior to release

yes @Adamj1232 it works, thanks!


[not done yet] StreamAlert SQS missing prefixes migration cleanup

to: @ryandeivert
cc: @airbnb/streamalert-maintainers
related to: #958
Background
Cleans up the code in the migration commit and destroys the SQS queue that is no longer needed.
Changes

Cleans up the code
Deletes old resources that are no longer necessary

Testing
TODO (haven't gotten to this yet).

Coverage remained the same at 96.806% when pulling 370e6b00075edf4142cf4e0780e9fb0af9aea81d on dw--missing-prefixes-finish into 7475d633007921baf95042c8fbe8d3285bf0bdb3 on dw--missing-prefixes-migration.

Coverage remained the same at 96.806% when pulling 370e6b00075edf4142cf4e0780e9fb0af9aea81d on dw--missing-prefixes-finish into 7475d633007921baf95042c8fbe8d3285bf0bdb3 on dw--missing-prefixes-migration.

After some discussion we've concluded there's an easier way to do this


Astro - Cannot find module '@vercel/speed-insights/astro' on import

When I try to import the Astro package, I get a TS error:
Cannot find module '@vercel/speed-insights/astro' or its corresponding type declarations.ts(2307)
Code in .astro file:
import SpeedInsights from "@vercel/speed-insights/astro";
File can be found here:
https://github.com/thomasledoux1/website-thomas-astro/blob/main/src/layouts/Layout.astro

Same here. Package is seemingly not exported.

Hello gents and thank you for this bug report.
I did not managed to reproduce the error.
I've setup a basic Astro application:
> pnpm create astro@latest

 astro   Launch sequence initiated.

   dir   Where should we create your new project?
         ./speed-insights-issue-36

  tmpl   How would you like to start your new project?
         Include sample files

  deps   Install dependencies?
         Yes

    ts   Do you plan to write TypeScript?
         No
      ◼  No worries! TypeScript is supported in Astro by default,
         but you are free to continue writing JavaScript instead.

   git   Initialize a new git repository?
         No
      ◼  Sounds good! You can always run git init manually.

      ✔  Project initialized!
         ■ Template copied
         ■ Dependencies installed

  next   Liftoff confirmed. Explore your project!

         Enter your project directory using cd ./speed-insights-issue-36
         Run pnpm dev to start the dev server. CTRL+C to stop.
         Add frameworks like react or tailwind using astro add.

         Stuck? Join us at https://astro.build/chat

╭─────╮  Houston:
│ ◠ ◡ ◠  Good luck out there, astronaut! 🚀
╰─────╯

> cd speed-insights-issue-36

> pnpm i @vercel/speed-insights
Packages: +1
+
Progress: resolved 450, reused 416, downloaded 0, added 1, done

dependencies:
+ @vercel/speed-insights 1.0.2

Done in 906ms

Then in src/layouts/Layout.astro I added:
---
import SpeedInsights from '@vercel/speed-insights/astro'; // <---- added

interface Props {
  title: string;
}

const { title } = Astro.props;
---

<!doctype html>
<html lang="en">
  <head>
    <meta charset="UTF-8" />
    <meta name="description" content="Astro description" />
    <meta name="viewport" content="width=device-width" />
    <link rel="icon" type="image/svg+xml" href="/favicon.svg" />
    <meta name="generator" content={Astro.generator} />
    <title>{title}</title>
  </head>
  <body>
    <slot />
    <SpeedInsights />  <!-- <---- added -->
  </body>
</html>

Finally, running pnpm dev and visiting the site works seamlessly.
@alexbouchardd the astro component export is properly defined in  packages/web/package.json.
The types are not, indeed, but we're considering replacing Tsup, so we'll get that fix during the migration.

Hi @feugy,
I've created a minimal reproduction repo.
Steps to reproduce:
git clone git@github.com:mingjunlu/speed-insights-issue-36.git
cd speed-insights-issue-36
pnpm install
pnpm run build

You'll see some error message like this:
src/pages/index.astro:2:27 - error ts(2307): Cannot find module '@vercel/speed-insights/astro' or its corresponding type declarations.

2 import SpeedInsights from '@vercel/speed-insights/astro';
                            ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Result (3 files):
- 1 error
- 0 warnings
- 0 hints

 ELIFECYCLE  Command failed with exit code 1.

We've released version 1.0.4 which fixes the issue. Happy coding!


Auto indentation after parentheses

The current behavior of Spyder's auto indentation, when we hit "Enter" right after typing ( is like this:
result = function(
    |)

("|" is where the cursor is)
It seems that PyCharm and VSCode are both using this following style:
result = function(
    |
)

If I remember correctly, PyCharm's and VSCode's style is the recommended style in PEP?  Is it possible for you to make a small tweak in Spyder?  Thanks!

Hi @jsh9,
Both forms are valid in PEP8, we implemented the first one. If more users request the second form for auto indentation we can see if we can add an option to shift between the two forms.
Thanks for reporting!


versioning a resource fails when author is no longer hs user

Description of the bug
Try to version this resource: https://beta.hydroshare.org/resource/2836494ee75e43a9bfb647b37260e461/
Traceback (most recent call last):
  File "/hydroshare/hs_core/tasks.py", line 803, in create_new_version_resource_task
    utils.copy_and_create_metadata(ori_res, new_res)
  File "/hydroshare/hs_core/hydroshare/utils.py", line 553, in copy_and_create_metadata
    dest_res.metadata.copy_all_elements_from(src_res.metadata, exclude_elements)
  File "/hydroshare/hs_core/models.py", line 4637, in copy_all_elements_from
    self.create_element(element_name, **element_args)
  File "/hydroshare/hs_core/models.py", line 4788, in create_element
    element = model_type.model_class().create(**kwargs)
  File "/hydroshare/hs_core/models.py", line 551, in create
    validate_hydroshare_user_id(hs_user_id)
  File "/hydroshare/hs_core/models.py", line 137, in validate_hydroshare_user_id
    raise ValidationError(err_message)
django.core.exceptions.ValidationError: ['1829 is not a valid id for hydroshare user']

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/usr/local/lib/python3.9/site-packages/celery/app/trace.py", line 451, in trace_task
    R = retval = fun(*args, **kwargs)
  File "/usr/local/lib/python3.9/site-packages/celery/app/trace.py", line 734, in __protected_call__
    return self.run(*args, **kwargs)
  File "/hydroshare/hs_core/tasks.py", line 836, in create_new_version_resource_task
    raise utils.ResourceVersioningException(str(ex))
hs_core.hydroshare.utils.ResourceVersioningException: ['1829 is not a valid id for hydroshare user']

The resourcemetadata.xml contains:
    <dc:creator>
      <rdf:Description>
        <hsterms:organization>UT Austin Center for Water and the Environment</hsterms:organization>
        <hsterms:phone></hsterms:phone>
        <hsterms:hydroshare_user_id rdf:datatype="http://www.w3.org/2001/XMLSchema#integer">1829</hsterms:hydroshare_user_id>
        <hsterms:description rdf:datatype="http://www.w3.org/2001/XMLSchema#integer">1829</hsterms:description>
        <hsterms:creatorOrder rdf:datatype="http://www.w3.org/2001/XMLSchema#integer">2</hsterms:creatorOrder>
        <hsterms:homepage></hsterms:homepage>
        <hsterms:address></hsterms:address>
        <hsterms:name>Erika Boghici</hsterms:name>
        <hsterms:email>e.boghici@austin.utexas.edu</hsterms:email>
      </rdf:Description>
    </dc:creator>

The hydroshare_user_id is no longer valid. That causes the versioning to fail
Expected behavior
Versioning should succeed
Additional information
HS 2.11.1

@martinseul suggested: "we'll need to prevent that a user who is an author on a published resource can be deleted"

released as 2.11.2


flutter_tools supports only Android Gradle Plugin <= 4.1.0 when using multidimensional flavors

Flutter hardcodes supported Android Gradle Plugin versions in relation to Gradle version. The problem is, it's outdated.
We cannot use AGP 4.2.1, 4.2.2, 4.2.*, and 7.0.* (and possibly future ones).
This problem shows up when we try to build an app bundle:
Running Gradle task 'bundleXxxxxProdRelease'...                   149.5s
Unsupported Android Plugin version: 4.2.2.

Those are the supported AGP <=> Gradle versions: https://developer.android.com/studio/releases/gradle-plugin#updating-gradle
https://github.com/flutter/flutter/blob/cf885c12ea5f157efa65a2ef63f7728c2949dced/packages/flutter_tools/lib/src/android/gradle_utils.dart#L148-L186
Flutter 2.5.1 • channel unknown • unknown source
Framework • revision ffb2ecea52 (5 weeks ago) • 2021-09-17 15:26:33 -0400
Engine • revision b3af521a05
Tools • Dart 2.14.2

Without additional information, we are unfortunately not sure how to resolve this issue.
We are therefore reluctantly going to close this bug for now.
Please don't hesitate to comment on the bug if you have any more information for us; we will reopen it right away!
Thanks for your contribution.
Could everyone who still has this problem please file a new issue with the exact description of what happens, logs, and the output of flutter doctor -v.
All system setups can be slightly different, so it's always better to open new issues and reference related issues.

Without additional information, we are unfortunately not sure how to resolve this issue.

What about this comment? 🤔

CLARIFICATION! flutter_tool does not support AGP > 4.1 when the app uses multidimensional flavor.
May be related to #92316.
Reproduction steps:

flutter create outdated_agp
Update the distributionUrl in android/gradle/wrapper/gradle-wrapper.properties from 6.7 to https\://services.gradle.org/distributions/gradle-7.3-all.zip
In android/build.gradle, change com.android.tools.build:gradle version from 4.1.0 to 7.0.1
Add the following code to android/app/build.gradle inside the android {}:

flavorDimensions "app", "type"

productFlavors {
    example {
        dimension "app"
    }

    prod {
        dimension "type"
    }
}

As you can see, APK is produced sucessfully, but AAB fails:
➜  outdated_agp flutter build apk --flavor exampleProd

💪 Building with sound null safety 💪

w: Runtime JAR files in the classpath have the version 1.3, which is older than the API version 1.5. Consider using the runtime of version 1.5, or pass '-api-version 1.3' explicitly to restrict the available APIs to the runtime of version 1.3. You can also pass '-language-version 1.3' instead, which will restrict not only the APIs to the specified version, but also the language features
w: /Users/albert/.gradle/caches/modules-2/files-2.1/org.jetbrains.kotlin/kotlin-stdlib-jdk7/1.3.50/50ad05ea1c2595fb31b800e76db464d08d599af3/kotlin-stdlib-jdk7-1.3.50.jar: Runtime JAR file has version 1.3 which is older than required for API version 1.5
w: /Users/albert/.gradle/caches/modules-2/files-2.1/org.jetbrains.kotlin/kotlin-stdlib/1.3.50/b529d1738c7e98bbfa36a4134039528f2ce78ebf/kotlin-stdlib-1.3.50.jar: Runtime JAR file has version 1.3 which is older than required for API version 1.5
w: /Users/albert/.gradle/caches/modules-2/files-2.1/org.jetbrains.kotlin/kotlin-stdlib-common/1.3.50/3d9cd3e1bc7b92e95f43d45be3bfbcf38e36ab87/kotlin-stdlib-common-1.3.50.jar: Runtime JAR file has version 1.3 which is older than required for API version 1.5
w: Runtime JAR files in the classpath have the version 1.3, which is older than the API version 1.5. Consider using the runtime of version 1.5, or pass '-api-version 1.3' explicitly to restrict the available APIs to the runtime of version 1.3. You can also pass '-language-version 1.3' instead, which will restrict not only the APIs to the specified version, but also the language features
w: /Users/albert/.gradle/caches/modules-2/files-2.1/org.jetbrains.kotlin/kotlin-stdlib-jdk7/1.3.50/50ad05ea1c2595fb31b800e76db464d08d599af3/kotlin-stdlib-jdk7-1.3.50.jar: Runtime JAR file has version 1.3 which is older than required for API version 1.5
w: /Users/albert/.gradle/caches/modules-2/files-2.1/org.jetbrains.kotlin/kotlin-stdlib/1.3.50/b529d1738c7e98bbfa36a4134039528f2ce78ebf/kotlin-stdlib-1.3.50.jar: Runtime JAR file has version 1.3 which is older than required for API version 1.5
w: /Users/albert/.gradle/caches/modules-2/files-2.1/org.jetbrains.kotlin/kotlin-stdlib-common/1.3.50/3d9cd3e1bc7b92e95f43d45be3bfbcf38e36ab87/kotlin-stdlib-common-1.3.50.jar: Runtime JAR file has version 1.3 which is older than required for API version 1.5
No issues found.
Running Gradle task 'assembleExampleProdRelease'...                 4.1s
✓  Built build/app/outputs/flutter-apk/app-exampleprod-release.apk (15.5MB).

➜  outdated_agp flutter build appbundle --flavor exampleProd

💪 Building with sound null safety 💪

Removed unused resources: Binary resource data reduced from 33KB to 19KB: Removed 40%
Running Gradle task 'bundleExampleProdRelease'...                  20.8s
Unsupported Android Plugin version: 7.0.1.

[✓] Flutter (Channel stable, 2.5.3, on macOS 12.0.1 21A559 darwin-arm, locale
    en-PL)
    • Flutter version 2.5.3 at /Users/albert/fvm/versions/2.5.3
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 18116933e7 (5 weeks ago), 2021-10-15 10:46:35 -0700
    • Engine revision d3ea636dc5
    • Dart version 2.14.4

[✓] Android toolchain - develop for Android devices (Android SDK version 31.0.0)
    • Android SDK at /Users/albert/Library/Android/sdk
    • Platform android-31, build-tools 31.0.0
    • Java binary at: /Applications/Android
      Studio.app/Contents/jre/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 11.0.10+0-b96-7249189)
    • All Android licenses accepted.

@danagbemava-nc can we reopen that? I provided reproduction steps

Thanks for the update and detailed steps to replicate. I confirm the same on latest stable.
Steps to replicate as mentioned in https://github.com/flutter/flutter/issues/92317#issuecomment-972596042

 stable flutter doctor -v
[✓] Flutter (Channel stable, 2.5.3, on Mac OS X 10.15.4 19E2269 darwin-x64,
    locale en-GB)
    • Flutter version 2.5.3 at /Users/dhs/documents/fluttersdk/flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 18116933e7 (2 days ago), 2021-10-15 10:46:35 -0700
    • Engine revision d3ea636dc5
    • Dart version 2.14.4

[✓] Android toolchain - develop for Android devices (Android SDK version 30)
    • Android SDK at /Users/dhs/Library/Android/sdk
    • Platform android-30, build-tools 30.0.3
    • ANDROID_HOME = /Users/dhs/Library/Android/sdk
    • Java binary at: /Users/dhs/Library/Application Support/JetBrains/Toolbox/apps/AndroidStudio/ch-0/202.7486908/Android
      Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6915495)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 12.3, Build version 12C33
    • CocoaPods version 1.10.1

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 4.1)
    • Android Studio at /Users/dhs/Library/Application Support/JetBrains/Toolbox/apps/AndroidStudio/ch-0/202.7486908/Android
      Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build
      1.8.0_242-release-1644-b3-6915495)

[✓] VS Code (version 1.57.1)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.21.0

[✓] Connected device (4 available)
    • Darshan's iphone (mobile)  • 21150b119064aecc249dfcfe05e259197461ce23 •
      ios            • iOS 14.4.1 18D61
    • iPhone 12 Pro Max (mobile) • A5473606-0213-4FD8-BA16-553433949729     •
      ios            • com.apple.CoreSimulator.SimRuntime.iOS-14-3 (simulator)
    • macOS (desktop)            • macos                                    •
      darwin-x64     • Mac OS X 10.15.4 19E2269 darwin-x64
    • Chrome (web)               • chrome                                   •
      web-javascript • Google Chrome 93.0.4577.82

• No issues found!

@GaryQian could you take a look at this?

cc @blasten

friendly ping @blasten

Fixed by https://github.com/flutter/flutter/pull/99723


Updating vulnerable dependencies according to assessment report : 66740c9cbc76cb13b034e620

Summary Report

Scenario
Upgrades
Critical
High
Medium
Low

Full Upgrade
18
1
2
15
0

Full Upgrade
18
1
2
15
0

Full Upgrade
6
1
0
5
0

Vulnerability Upgrade Report

CVE
Target Dependency
Parent Dependency
Project Dependency
Upgraded Dependency
Remediation Status
Description

CVE-2024-27306 + 18 more
aiohttp:3.5.3
aiohttp-session:2.7.0
requirements.txt

❌
No available versions available for upgrade.

CVE-2024-3651 + 1 more
idna:2.8
idna:2.8
requirements.txt
idna:3.7
✅
Upgrade successful!

CVE-2017-18342 + 1 more
pyyaml:3.13
pyyaml:3.13
requirements.txt
pyyaml:5.1
✅
Upgrade successful!

CVE-2017-18342 + 1 more
pyyaml:3.13
trafaret-config:2.0.2
requirements.txt
trafaret-config:2.0.2
✅
Upgrade successful!

CVE-2024-3651 + 1 more
idna:2.8
yarl:1.3.0
requirements.txt
yarl:1.6.3
✅
Upgrade successful!

CVE-2024-27306 + 18 more
aiohttp:3.5.3
aiohttp-jinja2:1.1.0
requirements.txt

❌
No available versions available for upgrade.

CVE-2024-22195 + 6 more
jinja2:2.10
aiohttp-jinja2:1.1.0
requirements.txt

❌
No available versions available for upgrade.

CVE-2024-22195 + 6 more
jinja2:2.10
jinja2:2.10
requirements.txt
jinja2:3.1.4
✅
Upgrade successful!


Add dnxcore platform support

The new RC of CoreCLR, CoreFX, and dnx means that applications can now be built using these tools. Please add a Nuget package targeting dnxcore or better yet netstandard so that F# apps can be written on this new platform. The CoreFX team has a great writeup on the new standard dotnet API. A compiler plugin for dnx has already been written.

Just to check - do you want

F# support on CoreCLR/CoreFX (which is already in progress in the coreclr branch of Microsoft/visualfsharp), or

an FSharp.Compiler.Service package that targets netstandard (also a good idea, but a different request)

If 2 please add more details about your use cases.

Essentially, I would like the ability to compile and run F# code on CoreCLR/CoreFX using the new project.json based build system. Right now, AFAIK, the dnx is the only way to do so, and it requires the aforementioned compiler plugin to compile F# code. This plugin depends on the FSharp.Compiler.Service package to function.
Are you planning to add official support for building F# code using the new project.json system?

Ah ok -  I see.
We'll need to integrate the work from Microsoft\visualfsharp coreclr branch once it's stable - those are the changes needed to bring up the compiler (and this compiler service) on CoreCLR.  I think the core of the work relevant to the compiler service is already stable and can be brought over - perhaps into a CoreCLR branch here.

Sounds great! I'll keep an eye out for said branch :)

OK, it's time to bring this to life again...
The steps we need to get a .NETCore FCS are:

Integrate from Microsoft/visualfsharp --> fsharp/fsharp --> fsharp/FSharp.Compiler.Service

Add build support for CoreCLR to this repo.  Basically copy the appropriate dependencies and settings from Microsoft/visualfsharp to this repo if they didn't come across as part of the integration.

Build it, test it on CoreCLR

Ship an updated Nuget

For #1, there is an integration from Microsoft/visualfsharp --> fsharp/fsharp going on here; https://github.com/fsharp/fsharp/pull/558.  It's still work in progress

Thanks for the update! The F# tooling for .NET Core has mostly fulfilled my requirements that originally motivated this issue. However, I'm sure there will be many other potential use cases for a .NET Core FCS package for other developers. Regardless, thanks for the effort to bring F# into the Core fold!

@ncave The first step is now complete.  Would be able to help add a .NET Core build of this component?

@dsyme Awesome! Just to clarify again, is your preference to start here, or can we add coreclr FCS to fsharp/fsharp, as stated in the Looking Ahead section, paragraph 1 of fsharp-contributions?

@ncave We should start here.
One of the reasons I'd like to do things here is to understand better what it means to add a .NETCore build+test for an existing, standard F# repository. This is a somewhat orthogonal goal but we need to make sure it is "easy".  We are going to have to do this for 100s of repositories over the coming year.
There are various ways to add .NET Core support to a repo. Some examples are:

FsSrGen, this a little executable tool. The repo builds and runs both a .NET Framework and a .NET Core version of the tool, so in theory it's a lot like what we have to do here.   It uses both a .fsproj and a project.json, sort of a parallel universe of two build systems. The .NET Core support is complex and looks very fragile - there are Powershell scripts, which I'd very much like to avoid, there's a gnarly Travis config file to run .NET Core code from CI on Linux, and likewise a gnarly AppVeyor config file.  While it's great to have this as an examplar to prove that it's actually possible, they also indicate just how "raw" end-to-end .NET Core support still is (just to build+test a basic cross-platform .EXE).  I'd expect this stuff to simplify massively in the next few months.  Much of it has nothing to do with F#.

Visual F# This repo also builds (and runs) a .NET Core version of the F# compiler itself.  The build system is complex, but you successfully augmented the .NET Core build of FSHarp.Compiler.LanguageService to do the right thing.

Suave.  This is another good exemplar, it does a build+test.  But again the contortions in the appveyor.yml concern me, and the [travis.yml)(https://github.com/SuaveIO/suave/blob/master/.travis.yml) has not been updated.  Paket is not used for .NET Core package management (project.json + dotnet CLI is used instead), so the repo is left in a "fractured" or "two-parallel-build-systems" state.    The repo uses both a project.json and a Suave.fsproj

All this is kind of unsatisfactory: to be honest it seems that adding .NET Core support is still quite hard.  I can see why you went and modified Microsoft/visualfsharp - but we have to make adding .NET Core support simpler.
I'm generally curious to know if it's possible to use Paket+.fsproj+msbuild to build dnxcore/netcore/netstandard components (though all the stuff linked above will still presumably be needed if we want to test anything).  What I found is this:

A suitable addition to paket.dependencies appears to be this:

source https://www.myget.org/F/dotnet-core/api/v3/index.json
source https://api.nuget.org/v3/index.json
source https://www.nuget.org/api/v2/
nuget NETStandard.Library

However, Paket doesn't yet support the "netstandard" monikers that came out in the last few days.  Support is being added..  I'm not sure there's any workaround short of winding back to earlier reference assemblies which used the "dnxcore" monikers.

We still need an FSharp.Core for .NET Core.  @enricosada says this is in the feed source https://www.myget.org/F/fsharp-daily/api/v3/, browse here, though there is also something available here.  I'm not totally keen on taking dependencies "daily" feeds but the status of the second thing is not clear either.  In either  seems best to add a netstandard version to the normal FSharp.Core nuget package, so I've added an issue for that here.

I'd like too to see a clean implementation of a fsproj supporting .net core, with paket if possibile.
So if i can help, pls tell me.
Long comments, as usual sorry
Some more info:
fsharp daily is not daily ci
The nuget it's published when a new version is needed.
FSharp.Core .NET Core nuget is:

name: Microsoft.FSharp.Core.netcore
version: 1.0.0-alpha-160412
feed: https://www.myget.org/F/fsharp-daily
supported frameworks: netstandard1.5

the previous version supported dnxcore50 only, not netstandard.
dnxcore50 is deprecated.
docs: http://dotnet.github.io/docs/libraries/libraries-with-cli.html and
About put netcore in that in same FSharp.Core nuget, pls do it.
But it's i think there are issues about alignment/sync/reference, but i'll add a comment to the issue
Sry no changelog
About .net cli
To write info about current situation (initial committed code may be old/dirty)
It's not to defend project.json based, but i think it has a lot of features the msbuild lack (first class support for packages, easy to read, easy multi framework support).

All together, i dont want to touch msbuild files anymore, because i can do the same job with project.json + .net cli. And it's oss
build script
to run a build and create a package, you need only to do
dotnet restore
cd projectDir
dotnet pack

dotnet pack already call dotnet build to compile for every framework specified in project.json, ootb, with nuspec attributes like authors, tags etc writte in the project.json.
to build and run a project (like tests)
dotnet restore
cd projectDir
dotnet run -- argument1 argument 2

appveyor and travis
both config just download a script. The script download the .net cli ZIP, unzip in a subdirectory, and add that to PATH. nothing fancy.
a clean template/example of both are:

[https://github.com/enricosada/fsharp-dotnet-cli-samples/blob/master/appveyor.yml] (WIN)
[https://github.com/enricosada/fsharp-dotnet-cli-samples/blob/master/.travis.yml] (OSX/Ubuntu).

i can do curl | bash with one liner, i think like that it's easier to read. but maybe less lines is better.
Current it's like when mono was installed before travis supported that ootb.
work is in progress in travis csharp image to add a -dotnet: version like -mono: version after dotnet cli rc2 is released.
also it's possibile to use system packages instead of unzip in a directory, but i prefer unzip because i can try that locally without messing up my machine.
official docs of .net cli install scenario: https://github.com/dotnet/cli/blob/rel/1.0.0/Documentation/cli-installation-scenarios.md
my build scripts in FsSrGen and other pr
I write a lot of code for build because i like to split commands in multiple task/targets.
It's not needed, as i said, just restore + pack are needed.
I used powershell because i tried experience without dependencies on build tools.
In the other pr (chessie/suave) i tried initially to NOT mess with their build file, and run commands in appveyor/travis after build.
The updated pr now integrate in fake/rake, and run commands as fake/rake tasks. And these task can be merge in a single one.
Some examples:

in a fake target, like fsx in chessie pr running cmd like Shell.Exec("dotnet", "restore")
in a rake task, like Rakefile in suave pr running cmd like system "dotnet restore"
from script, like powershell or bat or bash or appveyor, just running cmd like dotnet restore

Thanks @dsyme and @enricosada, the examples help a lot.

@ncave Overall, I'd say that for now we would accept a PR that adds .NETCore build + test support along the lines of Suave or FsSrGen, even if that means we end up with two build systems and duplication of the messy stuff from those repos.  Presumably we can clean it out later.
Criteria would be

[ ] Add a suitable project.json, plus all the ugly appveyor.yml, travis.yml  stuff .... No use of Paket.
[ ] Run tests

Perhaps much of that travis/appveyor/powershell stuff could go away if some CoreCLR helpers were added to FAKE.
I'm actually les concerned about running tests than you might think and we could release a pre-release without it, as long as a basic manual test has been done. This code is a fork of  http://gitub.com/Microsoft/visualfsharp, we can assume CoreCLR testing has been done.

@enricosada Thanks for the notes!
dotnet cli is nice as a project builder.  Is there FAKE support for it yet?   Does there need to be?  That would seem to be important.  Perhaps it's a one liner but it would be nice to have a sample.
Currently I feel that the simple task of targeting "netstandard" as a profile is forcing people to change everything:

framework: fragmented netstandard instead of unified .NET 4.6,2
project build system : dotnet-cli instead of MSBuild
dependency manager : nuget v3 instead of Paket
editor tooling : VS .xproj instead of fsproj
build automation : PS scripts instead of FAKE helpers

This amount of change is really hard to get your head around.
I just wish things were a bit more independent, e.g.

project build system: "You can use either dotnet-cli or MSBuild to create either netstandard or netfx components."

dependency manager: "You can use either project.json or Paket to declare and manage dependencies"

editor tooling: "You can use either xproj+dotnet-cli or fsproj+MSBuild when targeting either netstandard or netfx"

build automation: "You can use FAKE with either xproj+project.json+dotnet-cli or fsproj+MSBuild"

@dsyme  i can do the pr project.json.
I have already done that for visualfsharp ( fsharp.core/fsc/fsi/fsharp.compiler ) so i know issues (for
example we need fssrgen from package)
test it's easy, we can run nunit 3 tests (or whaterver) with .net core, already done that  for chessie, ref this commit

build automation: "You can use FAKE with either xproj+project.json+dotnet-cli or fsproj+MSBuild"

Yes, @dsyme see my previous comment, there is the example of fake integration in chessie.
It's just Shell.Exec("dotnet", "restore") in Fake

@enricosada I think it's important to make this replicable, so other people can do what you've been doing, and are happy to do it. So I might ask you to let @ncave have a crack at this (@ncave - do you want to?), and then review what he does.
Some other comments

I'd think I'd really like to see all that Powershell and Bash stuff in travis/appveyor.yml become FAKE helpers.  Or somehow factored out.  I definitely want to keep FAKE as the overall build automation.

So I'd like to limit the role of "project.json" to just a project build, giving a single DLL (rather than producing an intermediate nuget package just for the netstandard DLL which we then have to merge)

@enricosada Thanks for the FAKE sample, that's helpful.
Is it possible to avoid the dependency on "mergenupkg" here?  I don't want to depend on any non-standard extensions to dotnet-cli, and simply use it as a DLL builder called by FAKE.

@dsyme non standard extension is a dotnet cli tool ( inside tools in project json, ref doc ).
It's a normal package with a normal console app built for netstandard1.5. you can download the package, and dotnet run it
If you put that package foo inside the property tools in project.json, the dotnet restore download also that package, and you can run it with dotnet foo argument1 argument2. RAD.
Atm is not possible, but the only problem i see is paket template (for create the nuspec) doesnt support multiple frameworks ( ref https://github.com/fsprojects/Paket/issues/1539 ). We can add files (it's easy with paket template), but not new dependencies for netstandard1.5
For that (and because not everyone use paket) i added dotnet mergenupkg, the packages are a zip files and nuspec is an xml so it's easy to move thing.

@enricosada I think it's important to make this replicable, so other people can do what you've been doing, and are happy to do it. So I might ask you to let @ncave have a crack at this (@ncave - what do you think - would you like to?), and then review?

Sure, just ping me if someone need help. a basic migration guide is there.
https://github.com/enricosada/fsharp-dotnet-cli-samples/wiki/Migrate-fsproj-To-.NET-CLI
I used that for FsCheck, it's long because:

first create the project and use net46 framework so you fix all project.json issues (deps, files, f# 3 -> 4 sometimes)
add netstandard (.NET Core) and fix .net core issue (deprecated api, etc)

so you dont get all the issues together, more mechanical

@dsyme  .... is a  dotnet cli tool  ( inside  tools  in project json, ref doc ).  It's a normal package ...

Yep, I know.  But for the purposes of what we're trying to achieve here, we don't even want to do a dotnet publish, do we?  We just want to build a DLL?  I assume it is possible to just use dotnet as a project builder, without buying into these intermediate nuget packages?

@dsyme sure, just tell paket to download the dotnet-mergenupkg package, unzip, and dotnet "path/to/dotnet-mergenupkg.dll" argument1 argument2

Sure, just ping me if someone need help. a basic migration guide is there.
https://github.com/enricosada/fsharp-dotnet-cli-samples/wiki/Migrate-fsproj-To-.NET-CLI

Two things

Could we move enricosada/fsharp-dotnet-cli-samples to fsprojects/fsharp-dotnet-cli-guide to make it canonical?
Could we move that wiki to a README.md so it can accept PRs?

thanks!

@dsyme sure, just tell paket to download the  dotnet-mergenupkg  package, unzip, and  dotnet "path/to/dotnet-mergenupkg.dll" argument1 argument2

Not quite what I meant -  I mean we just call dotnet build and mention the generated DLL in the existing package template, just like we do for existing DLLs.  FAKE's packaging support does the rest.

Could we move enricosada/fsharp-dotnet-cli-samples to fsprojects/fsharp-dotnet-cli-guide to make it canonical?

i think i am moving that to github.com/dotnet/netcorecli-fsc/ the new home dotnet-compile-fsc , the tool who call fsc after dotnet build.
I just need to finish some commit in that repo and create the official package, atm is inside dotnet/cli repo

Could we move that wiki to a README.md so it can accept PRs?

The wiki is public, i wrote about it the home, just change it, i'd love to (for example FAQ)
For example i got some help from @NumberByColor , to polish things

i think i am moving that to github.com/dotnet/netcorecli-fsc/ the new home

OK, great

The wiki is public

OK, thanks!

just like we do for existing DLLs. FAKE's packaging support does the rest

@dsyme fake packaging use paket template, and you can put additional file inside, but not specify dependencies for additional frameworks for nuspec, so i cannot add depdencies for netstandard1, see  fsprojects/Paket#1539

@dsyme fake packaging use paket template, and you can put additional file inside, but not specify dependencies for additional frameworks for nuspec, so i cannot add depdencies for  netstandard1 , see fsprojects/Paket#1539

Ah, I see.  Yes, so that information in the intermediate nuget package is very valuable, I now understand why you ended up with dotnet-mergenupkg.
If Paket supported both "netstandard" and https://github.com/fsprojects/Paket/issues/913 then I assume you wouldn't need this step?

If Paket supported both "netstandard" and fsprojects/Paket#913 then I assume you wouldn't need this step?
@dsyme yes, should work.
If you use a nuspec file and nuget pack, for example, you dont need dotnet mergenupkg

@dsyme Thanks I'll take a crack at it with fake as in the Chessie netcore build that @enricosada contributed (great wiki, thanks!).

@dsyme Thanks I'll take a crack at it with fake as in the Chessie netcore build that @enricosada contributed (great wiki, thanks!).

@ncave Awesome. Don't hesitate to ask questions - we're all learning here :)  I even grab @enricosada on Skype sometimes :)

@ncave what's missing there? how can i help?
As recap, what's ok/missing?

[ ] build using .NET Core SDK preview1

[ ] fw netstandard1.5
[ ] use only corefx deps of preview1, published on nuget.org (not dev feed)
[ ] use latest FSharp.Core netcore in fsharp-daily

[ ] put built assemblies inside normal package ( using fake, paket or dotnet mergenupkg )

i checked project.json, i think only deeps need to be changed
deps
  "dependencies": {
    "Microsoft.NETCore.App": {
      "type": "platform",
      "version": "1.0.0-rc2-3002702"
    },
    "System.Diagnostics.TraceSource": "4.0.0-rc2-*",
    "Microsoft.FSharp.Core.netcore": "1.0.0-alpha-*",
  },

use "NETStandard.Library": "1.5.0-rc2-24027" instead of Microsoft.NETCore.App, that's for console app.
you can see project.json.lock for useful deps for Microsoft.NETCore.App
also i think we can remove import of dnxcore50 from netstandard1.5, should work anyway because latest fsharp.core is netstandard, not dnxcore50 anymore. The others are corefx and are already netstandard

@enricosada Thanks for the dotnet-mergenupkg link.

No, the merging with the main FCS package is not done yet. I wholeheartedly agree the .netcore package needs to go away, so by all means if you can merge it, go ahead. It still has dependencies on the alpha versions of the Microsoft.FSharp.Core.netcore package, but I'm sure it will eventually be merged into the main FSharp.Core package too.
The dependency on Microsoft.NETCore.App is a shortcut because FCS uses a lot of packages beyond NETStandard.Library. Of course, ideally we should not use either, but use trimming instead.
Yes, if you can merge the nuget packages, the appveyor build jobs need to be merged too. Purely dotnet core TravisCI build is still TBD due to some xplat tools missing.

@nave just open project.lock.json and copy deps of .NETCore.App (removing useless), that's it. It's a strange package, for apps. also you can see package needed in the project.json of the visualfsharp repo
I'll send a pr for preview2 fix and dotnetmergenupkg (it's already in dev, works ok, probably today)
i think i can just update the fslexyacc (current sources) to dnc, as dotnet-fslexyacc so we have xplat. @7sharp9 is working a lot on this, and need it, i'll do that.

This has been added, a separate bug tracks nuget package for this


1.6.2

Version bump and new SUSHI for next GoFSH release.

Yes, indeed, the number 2 comes after the number 1. Well done!

The tricky part is there are two 1s and yes I did accidentally name the branch 2.6.2 at first 😅

Yes, indeed, the number 2 comes after the number 1. Well done!

The tricky part is there are two 1s and yes I did accidentally name the branch 2.6.2 at first 😅

Oh! Yeah, actually, in my haste, I think I misremembered the change as being 2.6.1 to 2.6.2 (in which case my comment would make more sense).  I actually wasn't intentionally calling out your initial mistake (.2 instead of .1).  I hadn't even noticed it, but in fact, had moreso bought into it.  Oops!

Wait.  I am so confused.  Actually, now I see that the GoFSH version really did bump from 1.6.1 to 1.6.2, so my initial comment was in the right context.  When I just relooked at it now, I was looking at the SUSHi dependency version.  You're right, too many 1s.
Anyway, the release notes look good.  I'm merging it!


Simple pluggable serve-and-handle API

This is my take on serve-and-handle API, which I think we can introduce effortlessly. It doesn't brake any existing API. It also uses radix tree matching for path serving. Here's the sample of proposed API:
bot, err := telebot.NewBot(os.Getenv("BOT_TOKEN"))
if err != nil {
	log.Fatalln(err)
}

bot.Handle("/start", func (c telebot.Context) {
	b, m := c.Bot, c.Message

	b.SendMessage(m.Sender, "Hello!", nil)
})

messages := make(chan telebot.Message, 100)
bot.Listen(messages, 1*time.Second)

for message := range messages {
	bot.Serve(&message)
}

Shouldn't bot.Serve(&message) be bot.Serve(message) after f7a78ef?


ring_gc_*_test timeout on simarm_x64

ring_gc_test, ring_gc_sendAndExit_tests fail on simarm_x64 bots: https://ci.chromium.org/p/dart/builders/ci.sandbox/vm-kernel-precomp-linux-debug-simarm_x64/2008
The issue seems to be related to how spawned isolate is not able to recognize Command.kClose enum value.

Smaller repro
import 'dart:async';
import 'dart:isolate';

import 'package:expect/expect.dart';

enum Command {
  kRun,
  kRunAndClose,
  kClose,
}

void tryClose(List list) {
  final Command command = list[0];
  final SendPort sendPort = list[1];
  if (command != Command.kClose) {
    print("Really unexpected inequality of enum value");
    sendPort.send(false);
  }
  switch (command) {
    case Command.kRun:
      print("tryClose Recognized as run command");
      break;
    case Command.kRunAndClose:
      break;
    case Command.kClose:
      print("tryClose Recognized as close command");
  }
  sendPort.send(true);
}

main(args) async {
  final rp = ReceivePort();
  final si = StreamIterator(rp);
  await Isolate.spawn(tryClose, [Command.kClose, rp.sendPort]);
  await si.moveNext();
  Expect.equals(si.current, true);
  rp.close();
}

Comparing disassembly produced by simarm_x64/gen_snapshot and simarm/gen_snapshot I see differences in offsets to the fields in StoreInstanceField like below(isClosed is at 15 for simarm, vs at 19 for simarm_x64)
simarm/gen_snapshot output:
Code for optimized function 'dart:io__NativeSocket<EMAIL_ADDRESS>{
        ;; B0
        ;; B1
        ;; Enter frame
0xf6e8dba8    e92d4800               stmdb sp!, {fp, lr}
0xf6e8dbac    e28db000               add fp, sp, #0
        ;; ParallelMove r1 <- C, r0 <- C
0xf6e8dbb0    e3a01000               mov r1, #0
0xf6e8dbb4    e3a00702               mov r0, #524288
        ;; CheckStackOverflow:8(stack=0, loop=0)
0xf6e8dbb8    e59ac024               ldr ip, [thr, #+36]
0xf6e8dbbc    e15d000c               cmp sp, ip
0xf6e8dbc0    9a00004f               bls +324 ; 0xf6e8dd04
        ;; ParallelMove r2 <- S+2
0xf6e8dbc4    e59b2008               ldr r2, [fp, #+8]
        ;; StoreInstanceField(v2 . isClosed = v3, NoStoreBarrier)
0xf6e8dbc8    e59ac078               ldr ip, [thr, #+120]   false
0xf6e8dbcc    e582c00f               str ip, [r2, #+15]
        ;; StoreInstanceField(v2 . isClosing = v3, NoStoreBarrier)
0xf6e8dbd0    e59ac078               ldr ip, [thr, #+120]   false
0xf6e8dbd4    e582c013               str ip, [r2, #+19]
        ;; StoreInstanceField(v2 . isClosedRead = v3, NoStoreBarrier)
0xf6e8dbd8    e59ac078               ldr ip, [thr, #+120]   false
0xf6e8dbdc    e582c017               str ip, [r2, #+23]
        ;; StoreInstanceField(v2 . closedReadEventSent = v3, NoStoreBarrier)
0xf6e8dbe0    e59ac078               ldr ip, [thr, #+120]   false
0xf6e8dbe4    e582c01b               str ip, [r2, #+27]
        ;; StoreInstanceField(v2 . isClosedWrite = v3, NoStoreBarrier)
0xf6e8dbe8    e59ac078               ldr ip, [thr, #+120]   false
0xf6e8dbec    e582c01f               str ip, [r2, #+31]

simarm_x64/gen_snapshot
Code for optimized function 'dart:io__NativeSocket<EMAIL_ADDRESS>{
        ;; B0
        ;; B1
        ;; Enter frame
0x4960eb00    e92d4800               stmdb sp!, {fp, lr}
0x4960eb04    e28db000               add fp, sp, #0
        ;; ParallelMove r1 <- C, r0 <- C
0x4960eb08    e3a01000               mov r1, #0
0x4960eb0c    e3a00702               mov r0, #524288
        ;; CheckStackOverflow:8(stack=0, loop=0)
0x4960eb10    e59ac024               ldr ip, [thr, #+36]
0x4960eb14    e15d000c               cmp sp, ip
0x4960eb18    9a00004f               bls +324 ; 0x7f994960ec5c
        ;; ParallelMove r2 <- S+2
0x4960eb1c    e59b2008               ldr r2, [fp, #+8]
        ;; StoreInstanceField(v2 . isClosed = v3, NoStoreBarrier)
0x4960eb20    e59ac078               ldr ip, [thr, #+120]
0x4960eb24    e582c013               str ip, [r2, #+19]
        ;; StoreInstanceField(v2 . isClosing = v3, NoStoreBarrier)
0x4960eb28    e59ac078               ldr ip, [thr, #+120]
0x4960eb2c    e582c017               str ip, [r2, #+23]
        ;; StoreInstanceField(v2 . isClosedRead = v3, NoStoreBarrier)
0x4960eb30    e59ac078               ldr ip, [thr, #+120]
0x4960eb34    e582c01b               str ip, [r2, #+27]
        ;; StoreInstanceField(v2 . closedReadEventSent = v3, NoStoreBarrier)
0x4960eb38    e59ac078               ldr ip, [thr, #+120]
0x4960eb3c    e582c01f               str ip, [r2, #+31]
        ;; StoreInstanceField(v2 . isClosedWrite = v3, NoStoreBarrier)
0x4960eb40    e59ac078               ldr ip, [thr, #+120]
0x4960eb44    e582c023               str ip, [r2, #+35]

https://dart-review.googlesource.com/c/sdk/+/147808 addressed difference in generated code mentioned in https://github.com/dart-lang/sdk/issues/41824#issuecomment-627424319, but the repro test still fails with same enum value failing to compare correctly when using simarm_x64/gen_snapshot.

@aam Could this be due to our canonical hash codes behaving differently ? Do we embed any canonical hashes in the snapshot?

Could this be due to our canonical hash codes behaving differently ?  Do we embed any canonical hashes in the snapshot?

Yeah, canonical hashes between simarm_x64/gen_snapshot and simarm/gen_snapshot,dart_precompiled_runtime differ. Canonical hashes seem to end up being embedded into the snapshot, but then during simarm/dart_precompile_runtime execution cross-isolate message receiving(deserialization) we try to canonicalize the constants being received, which results in in different hash(simarm_x64 hash vs simarm hash).

Reason for why the hashes are different seems to be that enum instance integer field is getting unboxed and those are not being properly accounted for.


cannot create ticket when not logged in

Trac Ticket #21
component: code
owner: somebody
reporter: dagmar
created: 2016-09-22 17:27:45
milestone:
type: task
version:
keywords:
It is not allowed to create a feedback ticket without being logged in to the SEMS page, ie, externals cannot give feedback ;)
I came from http://most.sems.uni-rostock.de/
(feel free to delete this if it is not related to your report)

solved due to the integration of the track to github


refactor Should(Have.Count(index+1)) built into collection[index]

it should work without extra Should call
and error message on fail should show why it failed

Propose to add the following test case to SeleneCollection_Indexer_Specs to validate the implementation:
[Test]
public void NoTimeout_OnMatchedCondition_OnUnmatchedCollectionElement()
{
    Configuration.Timeout = 2.000;
    Given.OpenedEmptyPage();
    var validPositiveIndex = 100;

    var beforeCall = DateTime.Now;
    SS("#will-not-appear")[validPositiveIndex].Should(Be.Not.InDom);
    var afterCall = DateTime.Now;

    Assert.IsTrue(afterCall < beforeCall.AddSeconds(Configuration.Timeout));
}

Note: this test case is currently failing!

yes, make sense... but probably it's good to add this test together with a refactored implementation...

My proposal is to refactor the implementation of SCollectionWebElementByIndexSLocator.Find from
    return this.context.Should(Have.CountAtLeast(this.index+1)).ActualWebElements[index];

to
        public override IWebElement Find ()
        {
            var actualWebElements = this.context.ActualWebElements;
            if (actualWebElements.Count <= this.index)
            {
                throw new NotFoundException(
                    $"element was not found in collection by index {this.index} " +
                    $"(actual collection size is {actualWebElements.Count})"
                );
            }

            return actualWebElements[this.index];
        }


Enh/map block bootstrap

Pull Request Checklist:

[x] This PR addresses an already opened issue (for bug fixes / features)

This PR fixes #932

[x] Tests for the changes have been added (for bug fixes / features)
[ ] Documentation has been added / updated (for bug fixes / features)
[x] HISTORY.rst has been updated (with summary of main changes)

[x] Link to issue (:issue:number) and pull request (:pull:number) has been added.

[ ] bumpversion patch has been called on this branch
[x] The relevant author information has been added to .zenodo.json

What kind of change does this PR introduce?
This PR make an optimization to dask graph when bootstrapping percentiles using xarray.map_block.
There are also a few refactorings to clarify the code.
Before
The main concern was the intermediary results stored on disk by dasks.
In a large dataset, It was generating up 150Go of data on disk.
This had two consequences:

Computation is slow down by i/o operations, which may even idle all worker's threads while the i/o is in progress.
The OS may not allow an application to write so much data on disk, especially if there is no such space...
I suspect dask was storing the data broadcasted to window size which could effectively be reused in multiple steps of bootstrapping algorithm.
The other concern was the high memory (RAM) use. This lead dask to spill even more on disk and also limited the number of threads concurrently running.
For example, on dask default scheduler the OS would often kill the python process due to the amount of memory being use.
Finally on large dataset the dask graph could be populated with a lot of tasks.

Now
When running bootstrap algorithm on a single file of shape time: 3653, lat: 128, lon: 256 and stored in chunks: chunksizes': (1, 128, 256), there are approximately the same number of dask tasks created as before.
However, on a zarr store of shape lat: 256, lon: 512, time: 38716 and stored in chunks (38716, 3, 512), when 10 years are bootstrapped on a 20 years study, it was generating 1M tasks where now it "only" generates 250K tasks.
Plus, there is much less spilling on disk going on and the memory use always stays at a very manageable level.
Does this PR introduce a breaking change?
No.
Other information:
There was also some cases where years were duplicated and an (ugly) post-processing was filtering them out.
The root cause was the object used to iterates. We were using the whole da instead of the overlapping da in between reference period and studied period.
Two more errors can now be raised to avoid starting bootstrap when it's unnecessary:

When the reference period and the studied period don't overlap.
When the reference period and the studied period fully overlap.
This last case may seem counterintuitive. The bootstrap algorithm is used to avoid the inhomogeneity of percentile comparison between the period where both the index and the daily percentiles are computed (reference period) and the period where only the index is computed.
Thus, when reference period is equal to the study period there is no inhomogeneity.

All tests were done on my laptop. CPU: i5 2GHz 4 cores (x2) ; RAM: 16GB (dask is configured to use this as a limit)

Oopsi, I missclicked on "create pull request" too soon...

I'm satisfied with the perfs for now.
It works especially well when the data is stored in an appropriate chunking schema, that is when time is not chunked (or not too much).
However on 100 netcdf files with 1 year per file, it performs better than before but it's not crazy good.
BTW, I'm considering making Pangeo rechunker a dependency of icclim to delegate to it the pre-process rechunking. If you have some experience with rechunker, I'm curious to hear what you think about this.

... I first transfered the data to a zarr file and than did the rechunking. It was in most cases faster and less buggy.

Ah! I was wondering why they were doing this in rechunker tutorial. Thanks for the tips!

@bzah Do you think it would be possible to address the final comments today or tomorrow? Our next release is scheduled for the end of the week. Thanks again!

If you are ok with the warning wording I think it can be merged.

All good for me! LGTM


Inject to UpperC, Fix Access level modifier.

[Inject] reserved word must be in upper case.
Set IToaster access level to protected.

Thank you very much: I clearly didn't give to the readme the love it deserved. Thanks again

Thanks to you man! I learned a lot: take a look to https://github.com/ctrl-alt-d/BlazorConfirm. As you can see, it is so close you yours. Any comment/suggestion about BlazorConfirm will be welcome. A question, it worth to publish it on nuGet?
Also, Alessandro, do you have a second typo on your readme:
@inject Sotsera.Blazor.Toaster.IToaster toaster;  <-- here! the ;
It is without ";". Like:
@inject Sotsera.Blazor.Toaster.IToaster toaster
Thanks a lot about share your code!
dani herrera
ctrl.alt.d at gmail.


Scope problem when testing services at startup

If you turn on Scope Validation for DI, you will get an error when IdentityServer starts. This is because the services are tested at the root DI context. See https://github.com/IdentityServer/IdentityServer4/blob/ff5ca5c992a4001d76af33e42861fb1383ee2c11/src/IdentityServer4/Configuration/IdentityServerApplicationBuilderExtensions.cs#L35-L37
To resolve, create a scope before running the tests and use it on the tests:
using (var scope = app.ApplicationServices.CreateScope())
{
    // run tests using scope
}

Issue / Steps to reproduce the problem
On .NET Core 1.1, at the ConfigureServices method, change the method signature to return an IServiceProvider and at the end enable scope validation, like so:
return services.BuildServiceProvider(validateScopes: true);

Relevant parts of the log file
fail: IdentityManager.WebApp.Startup[0]
      System.InvalidOperationException: Cannot resolve scoped service 'IdentityServer4.Stores.IClientStore' from root provider.
         at Microsoft.Extensions.DependencyInjection.ServiceLookup.CallSiteValidator.ValidateResolution(Type serviceType, ServiceProvider serviceProvider)
         at Microsoft.Extensions.DependencyInjection.ServiceProvider.GetService(Type serviceType)
         at Microsoft.AspNetCore.Builder.IdentityServerApplicationBuilderExtensions.TestService(IApplicationBuilder app, Type service, ILogger logger, String message, Boolean doThrow)
         at Microsoft.AspNetCore.Builder.IdentityServerApplicationBuilderExtensions.Validate(IApplicationBuilder app)
         at Microsoft.AspNetCore.Builder.IdentityServerApplicationBuilderExtensions.UseIdentityServer(IApplicationBuilder app)
         at IdentityManager.WebApp.Startup.Configure(IApplicationBuilder app, IHostingEnvironment env, ILoggerFactory loggerFactory) in C:\p\foo\Startup.cs:line 350

At this log, line 350 is the call to app.UseIdentityServer();.
Tested on versions:
"IdentityServer4": "1.1.0"
"IdentityServer4.EntityFramework": "1.0.0"
"IdentityServer4.AspNetIdentity": "1.0.0"

https://github.com/IdentityServer/IdentityServer4/pull/825 🎉

I merged the PR - thanks for reporting!

@leastprivilege Cool! Would you know when this will be released?

In the he next weeks. Feel free to use the myget in the meantime.

@giggio You should take in mind that the validate scope functionality currently contains a bug that is not rolled out yet.
https://github.com/aspnet/DependencyInjection/pull/470

We shipped 1.2.0 yesterday.


Local installation failed when CLOUD_PROVIDER is set None.

The turbinia_config_tmpl.py says to use None for local installation.
# Which Cloud provider to use. Valid options are None and 'GCP'. Use 'GCP'
# for GCP or hybrid installations, and None for local installations.
CLOUD_PROVIDER = 'GCP'

However, turbinia/config/__init__.py specifies CLOUD_PROVIDER is required and None raises exception.
line#43
# Required config vars
REQUIRED_VARS = [
    # Turbinia Config
    'INSTANCE_ID',
    'CLOUD_PROVIDER',

line#210
    if var in REQUIRED_VARS and getattr(_config, var) is None:
      raise TurbiniaException(
          'Config attribute {0:s}:{1:s} is not set'.format(
              _config.configSource, var))

ty roshan i can fix, in meantime, you can put empty '' instead of None and that should work


Change PickFunctionApp to distinguish between containerized function apps and regular ones

Contributes to #3523.
Also refer to #3943 for UI changes.
When using the command palette actions that don't pertain to containerized function apps you are still ablt to pick them because the functionFilter value is the same for both. To bypass this we will throw an error for the commands that don't pertain and have a seperate function pickContainerOrFunctionApp that allows either to be chosen.

Just want to clarify: the reason we can't filter between the two is that our PickAppResource function can only filter the top level resources by type and kind, which for these resources are the exact same. That's a real bummer.

Just want to clarify: the reason we can't filter between the two is that our PickAppResource function can only filter the top level resources by type and kind, which for these resources are the exact same. That's a real bummer.
I bet we could add a way to filter top level resources by context value, but for now I think it's fine.

Yeah, this is how I recommended Megan do it because it would be kind of a pain to implement a pickAppResource that can filter by context value. I think that it could be useful to have at some point, but right now there hasn't really been a compelling reason to do this work yet.
If we have more resources that need this or if containerized function app usage explodes, we should probably do it then.


change to new CCF container registry

Updated the docker container to the latest 5.0.4 CCF image.
After running dependabot we have several packages that cannot be installed automatically. This is fixed in this PR.

Can you provide a link to a privacy-sandbox-dev CI run which shows this doesn't break anything? Otherwise looks okay to me

Can you provide a link to a privacy-sandbox-dev CI run which shows this doesn't break anything? Otherwise looks okay to me

https://github.com/microsoft/privacy-sandbox-dev/actions/runs/10698226659


Trouble with input Japanese characters when rapidly typing

This issue is very hard to explain, but it's actually happening.
(For Japanese, this issue is about "高速にタイプすると途中で変換できなくなる件".)
Japanese people type Japanese characters through converting alphabets like this. When I want to input こんにちは, I type konnichiha. Also, during typing, browser shows the text (こんにちは) with underline. This underline indicates "This text is not yet determined, you can also choose alternative plans to describe konnichiha". All of こんにちは, 今日は and コンニチハ can be converted from konnichiha. So we choose one of them before finishing typing. To summarize, this "undetermined state" is important.
Now, the problem is, when "value" attribute of input element is set by program, this "undetermined state" suddenly disappears. Basically, this does not happen because the value in Elm is always equal to the value of input element. But when I type rapidly, it behaves unexpectedly.
Type slowly

action
DOM value
Elm value
Applying patch

り
り

type "r"
りｒ

りｒ
no change

type "i"
りり

りり
no change

Type rapidly

action
DOM value
Elm value
Applying patch

り
り

type "r"
りｒ

type "i"
りり

りｒ
りｒ
りり ⇒ りｒ

りり
りり
りｒ ⇒ りり

The last two needless changes cause disappearance of "undetermined state". I confirmed this happens only when this line is evaluated. I think this is common issue in Chinese too.
If you can type this kind of language, I also created an example at jsFiddle, which is not Elm but able to see the behavior.
Thanks.

OS: Windows 7
Browser: Chrome 51
Elm: 0.17.0
elm-lang/core: 4.0.3
elm-lang/html: 1.1.0

P.S.
Sorry for not showing SSCCE. It is hard to reproduce...

There's an issue on this repo or on virtual-dom that talks about "unmanaged inputs" which basically means you do not add a value property on the input. Just let it do its own thing and track it internally. This means you cannot modify the field with value, but it should fix this issue. Can you link that issue in this thread if you find it?

Maybe this one? I haven't read all of this discussion but I confirmed defaultValue attribute instead of value works well. Thank you.

This is the issue - it's on the old evancz/elm-html repo

Tracking in https://github.com/elm-lang/virtual-dom/issues/107. Thank you for the report!


Add codecov and build badges

WIP

Codecov Report

:exclamation: No coverage uploaded for pull request base (main@b6b90c9). Click here to learn what that means.
The diff coverage is n/a.

@@           Coverage Diff            @@
##             main        #2   +/-   ##
========================================
  Coverage        ?   100.00%
========================================
  Files           ?         1
  Lines           ?        47
  Branches        ?        13
========================================
  Hits            ?        47
  Misses          ?         0
  Partials        ?         0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b6b90c9...f292027. Read the comment docs.


Modified code to refactor string duplication

Breaking change

Proposed change

Type of change

[ ] Dependency upgrade
[ ] Bugfix (non-breaking change which fixes an issue)
[ ] New integration (thank you!)
[ ] New feature (which adds functionality to an existing integration)
[ ] Deprecation (breaking change to happen in the future)
[ ] Breaking change (fix/feature causing existing functionality to break)
[x] Code quality improvements to existing code or addition of tests

Additional information

This PR fixes or closes issue: fixes #
This PR is related to issue:
Link to documentation pull request:

Checklist

[x] The code change is tested and works locally.
[x] Local tests pass. Your PR cannot be merged unless tests pass
[x] There is no commented out code in this PR.
[x] I have followed the development checklist
[x] The code has been formatted using Black (black --fast homeassistant tests)
[ ] Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

[ ] Documentation added/updated for www.home-assistant.io

If the code communicates with devices, web services, or third-party tools:

[ ] The manifest file has all fields filled out correctly.
Updated and included derived files by running: python3 -m script.hassfest.
[ ] New or updated dependencies have been added to requirements_all.txt.
Updated by running python3 -m script.gen_requirements_all.
[ ] For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
[ ] Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

[x] No score or internal
[ ] 🥈 Silver
[ ] 🥇 Gold
[ ] 🏆 Platinum

To help with the load of incoming pull requests:

[ ] I have reviewed two other open pull requests in this repository.

There is a low maintainability index in the code base due to string duplication. When it comes to maintenance, it will be difficult if your code uses the same string multiple times within a single file. To achieve this in this PR, I created constants within each file and assigned a string to each to be used whenever needed. In this way, we can only change the constant in the file if we want to change that string.

closing

reopened

Looks good. Both motivation and code changes are reasonable.


ci: sync release to pg branch

Description
This CI job is responsible for syncing changes from the release branch to the pg branch. This happens for every commit merged to release branch, similar to Sync Community Workflow
Fixes #Issue Number
Automation
/ok-to-test<EMAIL_ADDRESS>:mag: Cypress test results

[!TIP]
🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/10564440505
Commit: 51fddfb47115fb0bfca19df10b6f0ada2174eeef
Cypress dashboard.
Tags: @tag.Sanity
Spec:
Mon, 26 Aug 2024 18:02:33 UTC

Communication
Should the DevRel and Marketing teams inform users about this change?

[ ] Yes
[ ] No

Summary by CodeRabbit

New Features

Introduced an automated workflow for merging changes from the release branch to the pg branch, enhancing integration and development efficiency.
Added notifications for merge conflicts to improve communication and resolution tracking.

@abhvsn I have changed the channel id to point to pg channel for the same reason you have mentioned in the comment.

@abhvsn I have changed the channel id to point to pg channel for the same reason you have mentioned in the comment. Here is commit hash for reference - f8ab124

Can we update the the comment in that case?


if link exists in duo gallery, image should be linked as well

example https://www.dosomething.org/search/apachesolr_search/ggw
related to #3580

This was fixed when we updated the Figure pattern a while back.


Allow Signing Policy Document

The current SDK doesn't support signing policy documents, only signing URLs.
See: https://cloud.google.com/storage/docs/xml-api/post-object#policydocument
Since signed URLs doesn't support limiting the size of the uploaded file, signing policy documents is a much needed feature.

closing this issue as it's already being tracked here


Color List endpoint

Hey, I'm working on syncing BrickLink to BrickOwl and I see that BrickOwl has a nice Color List endpoint that would help me with this. Can you implement it?
As an alternative, I know I can implement Rebrickable API for this purpose
Endpoint:
GET https://api.brickowl.com/v1/catalog/color_list
Example response:
{
    "0": {
        "id": "0",
        "name": "Not Applicable",
        "hex": "000000",
        "peeron_names": [
            null
        ],
        "ldraw_ids": [
            null
        ],
        "bl_ids": [
            "0"
        ],
        "bl_names": [
            "N/A"
        ],
        "lego_colors": []
    },
    "2": {
        "id": "2",
        "name": "Chrome Gold",
        "hex": "f1f2e1",
        "peeron_names": [
            "ChromeGold"
        ],
        "ldraw_ids": [
            "334"
        ],
        "bl_ids": [
            "21"
        ],
        "bl_names": [
            "Chrome Gold"
        ],
        "lego_colors": [
            {
                "lego_id": "310",
                "raw_name": "METALIZED GOLD"
            }
        ]
    },
    "3": {
        "id": "3",
        "name": "Pink",
        "hex": "FFC0CB",
        "peeron_names": [
            "Pink"
        ],
        "ldraw_ids": [
            "13"
        ],
        "bl_ids": [
            "23"
        ],
        "bl_names": [
            "Pink"
        ],
        "lego_colors": [
            {
                "lego_id": "9",
                "raw_name": "LIGHT REDDISH VIOLET"
            }
        ]
    },
    "4": {
        "id": "4",
        "name": "Purple",
        "hex": "a5499c",
        "peeron_names": [
            "Purple"
        ],
        "ldraw_ids": [
            "22"
        ],
        "bl_ids": [
            "24"
        ],
        "bl_names": [
            "Purple"
        ],
        "lego_colors": [
            {
                "lego_id": "104",
                "raw_name": "BRIGHT VIOLET"
            }
        ]
    },
//... more entries
}

Hi @norberto5 ,
as I have no immediate need for this endpoint, it will probably take some time until I can implement this.
If you like, we can discuss your implementation in a pull request.


Unit tests for mysql adapter

Add real unit tests for mysql adapter, refs #406 issue.
While coding this tests i saw #419, #418 and #417.
Some tricks as:

implement a child class from real class to test protected/private methods
make testeable and mockable PDO
reimplement method setConnection without typehinting.

This tricks are required for run with fake PDO and capture all message passing.
Some tests are not totally pure unit because have internal 'new' calls:

testGetColumns has new Column
testCreateTable* has new Column

The way for resolve this problem is refactoring adapter with dependency injection in parameters but I tried not to be too intrusive.
Also, we have the folder structure... I didn't know where to put the unit test.
I think ideal location is test/unit/Phinx/Db/Adapter/MysqlAdapterTest.php and moving all old tests to tests/functional but again is a big movement. For now, the tests is located in same folder than funcional with unit suffix.
If this code is finally merged, some tests from current mysqladapter test, must be deleted (duplicated in both: unit and functional).
Please, review and send your comments.
I will complete a few code not covered.

Awesome, thanks!


Please support Fahrenheit Temp Measures.

Right now it seems that only Celsius is supported.

This is controlled by the Tesla and HA UIs.

Version of the custom_component
2.0.1
Configuration
Add your logs here.

Installed via HACS, I am not sure where the logs are located.
Describe the bug
A clear and concise description of what the bug is.
Since Home Assistant release 2022.4 (I am currently on 2022.4.5), the two temperature sensors (not the HVAC component as you showed above) are showing as Celsius where they were showing Fahrenheit before. One is for the inside temperature and one is for the outside temperature.

I have checked and my global temperature setting is set to Imperial/Fahrenheit and since this release of Home Assistant they have allowed you to individually change the entity unit of measurement. I have tried to change that on both of these but nothing happens when I click Update, it just stays as Celsius and when you go back to the entity settings it is back to Celsius again.

I am happy to provide more information to help resolve this, just wanted to get more details on the information you need. Thanks.
Debug log
Did you want specific component logs for this integration or did you want everything on debug level?

Ok, I see it now. Looks like they changed something in HA.


[ll] associated constants for format types

This is how it was meant to be played in the first place :)
Unfortunately, Rust-1.20 ICEs... Waiting for Beta to catch up, see https://github.com/rust-lang/rust/issues/29924

Replaced by https://github.com/gfx-rs/gfx/pull/1554/commits/6e773b6028a12532367c0e92019a16e53727d878
Strangely, no longer ICEs


Add tools to context menu

I've been trying to add a few tools to the right-click menu on Windows but without success. It works for single entries, but I wanted to have them under a retoolkit sub-menu. The later only worked with admin rights. 😢

https://github.com/akinuri/custom-context-submenu

Try https://github.com/lifenjoiner/sendto-plus. It doesn't write registry! It just groups shortcuts by folders ;)

Thanks a lot for the suggestions! I chose to go with SendTo+ as suggested by @lifenjoiner as recent versions of Windows limited the number of items in the sub-menu that you can create via registry.

I'm glad my tool can help anybody for a better life. Just follow the license. Especially, there are many software redistributed.

Yup, it definitely helps! Thanks!
I read the licenses of the software included in the package and asked permission for those requiring it. Do you have any specific concern? Please, let me know. I take this very seriously.
Thanks,
Fernando

I tried the installer, and found that like some others there is only binary file of sendto+.
I think the license file should be included.
It would be better to include a readme.md file for anyone who wants to known the usage. Users may want to extend retoolkit with their existing tools, just by adding some shortcuts.

Oh, you are right. Sorry about that. This was not by intent. I've opened #34 and will fix it for the next release. Does that sound ok for you?
Thanks again.

OK.


athenian.txt

Athenian school is a college prep middle school / high school located in Danville, CA.

@skydufaux Could you please change the title in the file from "Create Athenian School" to just "Athenian School"? Also, please notice that free educational license for JetBrains tools is for high and higher schools students, i.e. those who are over 13 of age. Thank you!

Done.  Ok, great.  I'm 14 and so are most of my 8th grade classmates!  Thanks so much!

@skydufaux Pull request merged. Thank you for the update!


Use the same distribution for all GCC-9 builds

We build our projects with with gcc-9 to test we are not breaking users trying very new compilers. We should be using the same distribution (probably Fedora:31) for all these builds.

[ ] -common
[ ] -cpp
[ ] -spanner
[ ] -pubsub
[ ] -bigquery

Obsolete due to our move to a monorepo. https://github.com/googleapis/google-cloud-cpp/issues/3612


Possible bug in k reciprocal computation

Hi,
I think I may have found a bug in the k reciprocal computation.
Based on the implementation from the original author https://github.com/zhunzhong07/person-re-ranking/blob/c11b3514114cbffc70588decda48c958fc965f5a/python-version/re_ranking_feature#L49 the re ranking function expects the actual distance which is then squared to get squared distance.
In your implementation, the _cal_dis function returns the squared distance not the actual distance. https://github.com/PyRetri/PyRetri/blob/402cb98b3be525f0e8b7f5648afde06e3a58c139/pyretri/index/re_ranker/re_ranker_impl/k_reciprocal.py#L51
In this case, I don't believe that there's a need to square it again here https://github.com/PyRetri/PyRetri/blob/402cb98b3be525f0e8b7f5648afde06e3a58c139/pyretri/index/re_ranker/re_ranker_impl/k_reciprocal.py#L65
In my own implementation, I removed this line and it improved my performance by 1% pts across all my metrics.
Thank you for the great work!
P.S. Implementing my suggestion in https://github.com/PyRetri/PyRetri/issues/14 can fix this issue without having to remove the squaring operation

Thanks for you suggestions! I will fix it in the next version.

Thanks for you suggestions! I will fix it in the next version.


Add the "by code" procedure

Operations though portal are usually ok for testing or for small scenarios. For an enterprise scale implementation, all operations needs to be automated.
Please include a reference to specific APIs, PowerShell, CLI and/or others to achieve the same result by code.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: e87c5c36-7f4f-cb86-8835-85df5ae91269
Version Independent ID: 3e5c0cc6-a001-bd81-6bed-c4322fc11faa
Content: Assign Azure resource roles in Privileged Identity Management - Azure Active Directory
Content Source: articles/active-directory/privileged-identity-management/pim-resource-roles-assign-roles.md
Service: active-directory
Sub-service: pim
GitHub Login: @curtand
Microsoft Alias: curtand

@simonbMS Thanks for the feedback. We will engage the content development team for further investigation, they will verify and perform necessary changes in the document as needed.
@curtand Can you have a look at this ?

Guidance on how to automate PIM as part of Enterprise-Scale LandingZone delployments would be very welcome.
Can you update the current status of this request?

Guidance on how to automate PIM as part of Enterprise-Scale Landing Zone deployments would be very welcome.
Can you update the current status of this request?

No changes yet

Hi @GitHubUser1339
The reference for API commands to assign Azure resource roles is at https://docs.microsoft.com/en-us/azure/role-based-access-control/role-assignments-rest
For Azure AD directory roles, the reference is at https://docs.microsoft.com/en-us/graph/api/resources/rolemanagement?view=graph-rest-beta
I'm just about to publish the first of our article updates to "Assign an Azure AD  role in PIM" (https://github.com/MicrosoftDocs/azure-docs-pr/pull/170948) and will be following up shortly with other additions to add sample calls and responses  for other actions.

For further updates, the timeline for resolution may vary based on resourcing, so we've created an internal work item to incorporate your suggestions. We are closing this issue for now, but feel free to comment here as necessary. #please-close


Review 'Mendelian disease'

Mondo term (ID and Label):
MONDO_0003847 Mendelian disease
Suggested new label:
Genetic disease
Your nano-attribution (ORCID)
If you don't have an ORCID, you can sign up for one here
(0000-0002-5520-6597)
Optional: Any additional information (like supporting evidence, PubMed ID, etc.)
The current definition is ‘a disease that is caused by genetic modifications where those modifications are inherited from a parent's genome.'
In my understanding Mendelian diseases are only monogenic diseases. I'm under the impression that MONDO lists OMIM entries here but some of these OMIM are not single gene / monogenic diseases. OMIM is "an Online Catalog of Human Genes and Genetic Disorders' -  A broader term such as genetic disease or inherited disease may thus be required.

Peter and Ada agreed to the label 'herediary disease'

To do:

[ ] rename MONDO:0003847 'hereditary disease'
[ ] review the x-ref for MONDO:0003847
[ ] children for 'hereditary disease' should be

monogenic/mendelian disease (New term)

chromosomal disorders.

hereditary syndromic disease (New term)

[ ] New term: monogenic/mendelian disease (some of the x-ref for MONDO:0003847 might refer to this new term)
[ ] review the classification of current terms
[ ] create sub-classification based on structure affected (e,g, cardiogenetic disease, nephrogenetic disease, genodermatodis (https://github.com/monarch-initiative/mondo/issues/5952)

Revision of current terms, maybe could be done programmatically?

diseases that have 1 (and only 1) axiom 'has material basis in germline mutation in' some gene" should be monogenic/mendelian disease
terms that have "syndromic disorder" parent and/or have the word "syndrome" in their label should be hereditary syndromic disease
(I need feedback on these rules)

Discussed on Mondo Medical Expert Meeting (2023-02-23)
@nicolevasilevsky, could you please review? Thank you!

this looks good to me!

Thank you for looking into this :)

should mendelian be Mendelian ?
I am not sure that the term 'hereditary syndromic disease' is appropriate here  , NCBI definition of syndromic disease:
" A group of signs, symptoms, and clinicopathological characteristics that may or may not have a genetic basis and collectively define an abnormal condition. [ from NCI]
Syndromic disease (Concept Id: C0039082) - NCBI

Thus a syndromic disease can be a Mendelian disorder. I would consider 'multifactorial' or 'complex inheritance'

Hi Imke,

Yes, we'll capitalize Mendelian
we will define 'hereditary syndrome disease' as A group of signs, symptoms, and clinicopathological characteristics that have a genetic basis and collectively define an abnormal condition. We have a separate term for syndromic disease.

Hi Nicole, I am still not sure if that is the correct term. I assume that you want to capture under this term something that is different to Mendelian and Chromosomal. There are multiple hereditary syndromic diseases (based on your definition) that would be Mendelian diseases or chromosomal disorders. I assume that you would want to capture the kind of diseases were genetics contributes to the disease but other factors also play a role and/or where many different genes contribute to disease. The mode of inheritance for these is described in OMIM (and most geneticists) as 'multifactorial' (see 106300
SPONDYLOARTHROPATHY, SUSCEPTIBILITY TO, 1; SPDA1 as an example in OMIM). I would thus strongly suggest to use 'multifactorial disease'


Missing documentation on FlutterApplicationLifeCycleDelegate in Swift

It appears as if there is some missing documentation on how to conform to the FlutterApplicationLifeCycleDelegate protocol from Swift. Namely, I was trying to integrate the _:didFinishLaunchingWithOptions: hook.
Is this expected? Where should that documentation live?
More details (and places I looked figuring this out):

Writing custom platform-specific code: https://flutter.dev/docs/development/platform-integration/platform-channels?tab=ios-channel-swift-tab
Developing packages & plugins: https://flutter.dev/docs/development/packages-and-plugins/developing-packages#step-2c-add-ios-platform-code-swifthm
Protocol documentation: https://api.flutter.dev/objcdoc/Protocols/FlutterApplicationLifeCycleDelegate.html#/c:objc(pl)FlutterApplicationLifeCycleDelegate(im)application:didFinishLaunchingWithOptions:
First-party plugins, none of which appear to be written in Swift: https://github.com/flutter/plugins/tree/master/packages

Swift documentation has been added.


(ngShow) cannot evaluate expression containing void 0

version: 1.4.7
I usually like to use "void 0" in expressions to test for undefined values, so i tried that on ngShow
<div data-ng-show="someVar !== void 0">
</div>

This majestically goes boom with the following output:
Error: [$parse:syntax] Syntax Error: Token '0' is an unexpected token at column 17 of the expression [someVar !== void 0] starting at [0].
at /bower/angular/angular.js:68:12
at Object.AST.throwError (/bower/angular/angular.js:13057:11)
at Object.AST.ast (/bower/angular/angular.js:12827:12)
at Object.ASTCompiler.compile (/bower/angular/angular.js:13276:31)
at Parser.parse (/bower/angular/angular.js:14146:29)
at $parse (/bower/angular/angular.js:14248:39)
at Scope.$watch (/bower/angular/angular.js:15412:19)
I have not tested this against other expression evaluating directives, but since this comes from the AST i suspect other failure candidates as well.
Is this something that is expected or defined behaviour?
Have a nice day!

As void 0 is undefined, you can write someVar !== undefined to get the desired behaviour

The void operator is not supported in angular expressions. This is explained here https://docs.angularjs.org/guide/expression

As void 0 is undefined, you can write someVar !== undefined to get the desired behaviour
-frfancha

Yeah, sure. Until some funny guy assigns something like $scope.undefined = 'bla' or even worse assigns to $rootScope. This is why i use void 0, which evaluates to undefined but is not undefined.

The void operator is not supported in angular expressions. This is explained here https://docs.angularjs.org/guide/expression
-lgalfalso

Thank you very much, that explains it.

Inside an expression, undefined will always evaluate to undefined. If you
want to access a property on $scope under the name "undefined" then the
expression must be this.undefined
On Friday, October 23, 2015, burner-account<EMAIL_ADDRESS>wrote:

As void 0 is undefined, you can write someVar !== undefined to get the
desired behaviour
-frfancha
Yeah, sure. Until some funny guy assigns something like $scope.undefined =
'bla' or even worse assigns to $rootScope. This is why i use void 0, which
evaluates to undefined but is not undefined.
The void operator is not supported in angular expressions. This is
explained here https://docs.angularjs.org/guide/expression
-lgalfalso
Thank you very much, that explains it.
—
Reply to this email directly or view it on GitHub
https://github.com/angular/angular.js/issues/13149#issuecomment-150649371
.

@lgalfaso  Thanks a lot for your relentless effort to answer my questions and further my understanding of angular. I appreciate your patience.


sysrib test uses JSON for configuring state

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 65.531%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
3173

Relevant Lines:
4842

💛  - Coveralls


Webrtc behind NAT not work

I use the example in the directory: libp2p/js-libp2p/examples/libp2p-in-the-browser/webrtc/browser-to-browser. If 2 browsers are on the same LAN, they can connect and send messages.
But with 2 devices using 4G or using other wifi, it will not connect.
I have read the libp2p docs and see that AutoNAT and circuitRelayServer have the same support as TURN server relay data. But I didn't find any examples? Can you provide me with an example?

.

In our universal connectivity repo we have an example of two browser nodes connecting via a rust relay server which can be hosted remotely. Please take a look there and if you have any further questions related to getting setup or debugging feel free to start a discussion on our Q&A forum


Docs

Before submitting

[ ] Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
[ ] Did you read the contributor guideline, Pull Request section?
[ ] Did you make sure to update the docs?
[ ] Did you write any new necessary tests?

What does this PR do?
Fixes # (issue).
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃

Codecov Report

Merging #12 into master will increase coverage by 28.10%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##           master       #12       +/-   ##
============================================
+ Coverage   71.89%   100.00%   +28.10%
============================================
  Files           5         5
  Lines         274       250       -24
============================================
+ Hits          197       250       +53
+ Misses         77         0       -77

Impacted Files
Coverage Δ

pytorch_lightning_bolts/__init__.py
100.00% <100.00%> (ø)

pytorch_lightning_bolts/models/mnist_template.py
100.00% <100.00%> (+69.33%)
:arrow_up:

...bolts/models/variational_autoencoders/basic/vae.py
100.00% <100.00%> (+23.36%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 61bee90...952e433. Read the comment docs.