scripts: module: support for name field in zephyr/module.yml

The folder name of a Zephyr module is also used as its module name
when integrating it into the build system.
This means that a Zephyr module, BAR, located in:
<workspace>/modules/foo
                    |--- zephyr
                          |--- CMakeLists.txt
                          |--- Kconfig

will be referred to as FOO in the build system, that is:
ZEPHYR_FOO_MODULE_DIR==/modules/foo
ZEPHYR_FOO_CMAKE_DIR==/modules/foo/zephyr
The name field allows the module to specify its module name,
independent of its location like:
<workspace>/modules/foo/zephyr/module.yml
name: bar
build:
  cmake: zephyr

will instead be referred to as BAR in the build system, that is:
ZEPHYR_BAR_MODULE_DIR==/modules/foo
ZEPHYR_BAR_CMAKE_DIR==/modules/foo/zephyr
This allows for greater flexibility of relocating Zephyr modules in
other folders and at the same time be guaranteed that other modules
depending on ZEPHYR_BAR_MODULE_DIR is still working.
If name field is not specified in module.yml, then the existing
behavior of using the folder name will be used.

Introducing name: <module-name> as requirement in Zephyr maintained
modules.
This will ensure that Zephyr module names are kept in sync between the
project names in the default west.yml manifest file, and the names
used when referring to the Zephyr module in the build system.
This means the project foo in west.yml will look as:
west.yml
manifest:
  projects:
    - name: foo

must have:
<foo-repo>/zephyr/module.yml with content
name: foo

and can be referred to in the build system as:

ZEPHYR_FOO_MODULE_DIR, for the module directory
ZEPHYR_FOO_CMAKE_DIR, for the directory containing the Zephyr module
CMakeLists.txt.

doc: documenting the depends feature in Zephyr modules
Fixes: #29549
This commit documents the Zephyr module depends feature.

@tejlmand I think we should enforce a convention that module names and west project names should always match, to save our sanity. Agreed?

@tejlmand I think we should enforce a convention that module names and west project names should always match, to save our sanity. Agreed?

@tejlmand I think we should enforce a convention that module names and west project names should always match, to save our sanity. Agreed?

If you mean enforced in the code ?, then i'm not sure.
In most cases I believe people want to keep those two names aligned, but

west is still optional
There could be downstream use-cases where you for some reasons would like to have different names.
An example could be mbedtls,  where it might be that a downstream project, like NCS, would have their own mbedtls which in west could be called mbedtls to replace the version in Zephyr, but in the module itself it could be named: mbedtls-nrf to avoid Zephyr module root to be activated for that module, and instead pick-up mbedtls glue code from another module root, see also #30904.

As a guideline for Zephyr modules maintained by the Zephyr community, I think it's a good idea to have this as a rule.

@tejlmand I think we should enforce a convention that module names and west project names should always match, to save our sanity. Agreed?

If you mean enforced in the code ?, then i'm not sure.
In most cases I believe people want to keep those two names aligned, but

west is still optional
There could be downstream use-cases where you for some reasons would like to have different names.
An example could be mbedtls,  where it might be that a downstream project, like NCS, would have their own mbedtls which in west could be called mbedtls to replace the version in Zephyr, but in the module itself it could be named: mbedtls-nrf to avoid Zephyr module root to be activated for that module, and instead pick-up mbedtls glue code from another module root, see also #30904.

As a guideline for Zephyr modules maintained by the Zephyr community, I think it's a good idea to have this as a rule.

@tejlmand I think we should enforce a convention that module names and west project names should always match, to save our sanity. Agreed?

As a guideline for Zephyr modules maintained by the Zephyr community, I think it's a good idea to have this as a rule.

@mbolivar-nordic Added the following commit with an extra rule: https://github.com/zephyrproject-rtos/zephyr/pull/31156/commits/66e5becd07f0ad1f4348bb3d5d6aec4799a13d87
@ioannisg please give feedback on this new rule. I think this makes very much sense, as we now align how a module is named in west and the build system, as well as how to refer to it.

@tejlmand I think we should enforce a convention that module names and west project names should always match, to save our sanity. Agreed?

As a guideline for Zephyr modules maintained by the Zephyr community, I think it's a good idea to have this as a rule.

@mbolivar-nordic Added the following commit with an extra rule: https://github.com/zephyrproject-rtos/zephyr/pull/31156/commits/66e5becd07f0ad1f4348bb3d5d6aec4799a13d87
@ioannisg please give feedback on this new rule. I think this makes very much sense, as we now align how a module is named in west and the build system, as well as how to refer to it.

If you mean enforced in the code ?, then i'm not sure.

No, I meant, enforced as a Zephyr convention in review.

If you mean enforced in the code ?, then i'm not sure.

No, I meant, enforced as a Zephyr convention in review.

If you mean enforced in the code ?, then i'm not sure.

No, I meant, enforced as a Zephyr convention in review.

Then I guess the additional rule commit should suffice.

If you mean enforced in the code ?, then i'm not sure.

No, I meant, enforced as a Zephyr convention in review.

Then I guess the additional rule commit should suffice.

@tejlmand I assume that this one is expected to be merged first, and then #30904 will be updated accordingly, right?

@tejlmand I assume that this one is expected to be merged first, and then #30904 will be updated accordingly, right?

@tejlmand I assume that this one is expected to be merged first, and then #30904 will be updated accordingly, right?

Doesn't really matter, I will fix any conflicts regardless of merge order, but I do assume this is more likely to be merged first.

@tejlmand I assume that this one is expected to be merged first, and then #30904 will be updated accordingly, right?

Doesn't really matter, I will fix any conflicts regardless of merge order, but I do assume this is more likely to be merged first.

If you mean enforced in the code ?, then i'm not sure.

No, I meant, enforced as a Zephyr convention in review.

I also agree with this approach, and I think the way it is documented in the PR is good enough.
@mbolivar-nordic are you happy with the PR now?

If you mean enforced in the code ?, then i'm not sure.

No, I meant, enforced as a Zephyr convention in review.

I also agree with this approach, and I think the way it is documented in the PR is good enough.
@mbolivar-nordic are you happy with the PR now?

I also agree with this approach, and I think the way it is documented in the PR is good enough.
@mbolivar-nordic are you happy with the PR now?

@carlescufi so you are saying you're OK with every module.yml having a name that 'shall' match the project name in zephyr/west.yml? I won't block the merge, but I'm against that.

I also agree with this approach, and I think the way it is documented in the PR is good enough.
@mbolivar-nordic are you happy with the PR now?

@carlescufi so you are saying you're OK with every module.yml having a name that 'shall' match the project name in zephyr/west.yml? I won't block the merge, but I'm against that.

even when it is not necessary and the project path would have resulted in the same values?

How will you ensure the project path has the same value for a user not using west ?
You have no control where he decides to place the module, it could be in a folder named differently, or even worse, in a folder matching the name of another module.

it's troublesome unnecessary boilerplate.

a zephyr/module.yml is also required, but that too is unnecessary boilerplate if all you have is zephyr/CMakeLists.txt file.
The zephyr/CMakeLists.txt is the file that is default used, even if the zephyr/module.yml is not present.
I don't see why having a name key is more troublesome than having to make an unnecessary zephyr/module.yml in first place.
Note, I fully support the rule of all modules having a zephyr/module.yml file, as it makes things aligned, only I fail to understand why the first rule is good, but the additional proposed rule is so much more troublesome compared to the first rule.
We could relax the rule a bit, and adjust it to:

The module.yml file shall contain the name key if the module is using any of the keys: cmake-extern or kconfig-extern.

cause that is the case where we have increased risk. It must be ensured, in all situations, that module name matches the glue code that is going to be used from a different location.
That rule could even be enforced in code, because the cmake-extern and kconfig-extern are new keys, so no backward compatibility would not be broken.
We can merge the name feature itself, and then discuss coding rules separately, that is, take 66e5becd07f0ad1f4348bb3d5d6aec4799a13d87 into a dedicated PR.

even when it is not necessary and the project path would have resulted in the same values?

How will you ensure the project path has the same value for a user not using west ?
You have no control where he decides to place the module, it could be in a folder named differently, or even worse, in a folder matching the name of another module.

it's troublesome unnecessary boilerplate.

a zephyr/module.yml is also required, but that too is unnecessary boilerplate if all you have is zephyr/CMakeLists.txt file.
The zephyr/CMakeLists.txt is the file that is default used, even if the zephyr/module.yml is not present.
I don't see why having a name key is more troublesome than having to make an unnecessary zephyr/module.yml in first place.
Note, I fully support the rule of all modules having a zephyr/module.yml file, as it makes things aligned, only I fail to understand why the first rule is good, but the additional proposed rule is so much more troublesome compared to the first rule.
We could relax the rule a bit, and adjust it to:

The module.yml file shall contain the name key if the module is using any of the keys: cmake-extern or kconfig-extern.

cause that is the case where we have increased risk. It must be ensured, in all situations, that module name matches the glue code that is going to be used from a different location.
That rule could even be enforced in code, because the cmake-extern and kconfig-extern are new keys, so no backward compatibility would not be broken.
We can merge the name feature itself, and then discuss coding rules separately, that is, take 66e5becd07f0ad1f4348bb3d5d6aec4799a13d87 into a dedicated PR.

Module naming rules removed from feature PR to split functionality from module guidelines.
See https://github.com/zephyrproject-rtos/zephyr/pull/31359

Module naming rules removed from feature PR to split functionality from module guidelines.
See https://github.com/zephyrproject-rtos/zephyr/pull/31359

I also agree with this approach, and I think the way it is documented in the PR is good enough.
@mbolivar-nordic are you happy with the PR now?

@carlescufi so you are saying you're OK with every module.yml having a name that 'shall' match the project name in zephyr/west.yml, even when it is not necessary and the project path would have resulted in the same values? I won't block the merge, but I'm against that; it's troublesome unnecessary boilerplate.

Yes, that is exactly what I am saying. Better explicit than implicit. This conversation, however, now should take place in https://github.com/zephyrproject-rtos/zephyr/pull/31359

I also agree with this approach, and I think the way it is documented in the PR is good enough.
@mbolivar-nordic are you happy with the PR now?

@carlescufi so you are saying you're OK with every module.yml having a name that 'shall' match the project name in zephyr/west.yml, even when it is not necessary and the project path would have resulted in the same values? I won't block the merge, but I'm against that; it's troublesome unnecessary boilerplate.

Yes, that is exactly what I am saying. Better explicit than implicit. This conversation, however, now should take place in https://github.com/zephyrproject-rtos/zephyr/pull/31359

@nashif and @mbolivar-nordic , now that the controversial bits have been moved out to https://github.com/zephyrproject-rtos/zephyr/pull/31359, can we get this in?

@nashif and @mbolivar-nordic , now that the controversial bits have been moved out to https://github.com/zephyrproject-rtos/zephyr/pull/31359, can we get this in?

I am fine with the change, but we are introducing this with almost 0 testing and verification that it actually works as advertised. I always thought that example-application thing would actually serve for this type of testing but that is going in completely different ways right now.

I am fine with the change, but we are introducing this with almost 0 testing and verification that it actually works as advertised. I always thought that example-application thing would actually serve for this type of testing but that is going in completely different ways right now.

I am fine with the change, but we are introducing this with almost 0 testing and verification that it actually works as advertised. I always thought that example-application thing would actually serve for this type of testing but that is going in completely different ways right now.

We will introduce this very soon as part of:
https://github.com/zephyrproject-rtos/zephyr/pull/30904
and
https://github.com/zephyrproject-rtos/zephyr/pull/31224

I am fine with the change, but we are introducing this with almost 0 testing and verification that it actually works as advertised. I always thought that example-application thing would actually serve for this type of testing but that is going in completely different ways right now.

We will introduce this very soon as part of:
https://github.com/zephyrproject-rtos/zephyr/pull/30904
and
https://github.com/zephyrproject-rtos/zephyr/pull/31224


rocAL Video Reader : Support to pass filenames and labels as list

Add support to pass filenames and labels as list in Video reader
Add changes in rocalVideo iterator to return labels
Add new python example which demonstrates passing filenames and labels as input to the reader
Add C++ test case for the filenames case

please address review comments

@rrawther Addressed all review comments, Please check

@fiona-gladwin @rrawther why is this PR going to master? We have develop for all the tensor work.

@LakshmiKumar23 We have added these changes to master since this was requested by a user, The develop branch has tensor related changes and is not yet merged with master branch. Once this PR is merged we will ensure this feature is added to develop as well.

@rrawther - let me know if we can merge to master

@fiona-gladwin : added comment in passing vectors. Also please merge tot

Addressed review comments and merged with TOT

@rrawther
Verified that the tests are passing.
@fiona-gladwin
Before merging the PR, would you be able to update the README file in the cpp_api_test for video label case?(case =4)

@kiritigowda : this PR can be merged . But it uses ROCAL_DATA and we don't have that in ROCm. We can merge it and create the DATA repo and update readme afterwards

Merge pending - http://math-ci.amd.com/blue/organizations/jenkins/main%2Fprecheckin%2FrocAL/detail/PR-89/1/pipeline

@kiritigowda : I think the PR was meant for develop branch for tensor. So it has to be merged to develop
@fiona-gladwin : Can you please confirm

@kiritigowda : I think the PR was meant for develop branch for tensor. So it has to be merged to develop @fiona-gladwin : Can you please confirm

@rrawther We have added these changes to master branch since this was requested by a user, Please let me know if this needs to be added to the develop branch and I can issue a different PR for the same


Improve text placement on lines

The screenshot below showns river ways with labels as vector features. Each river is presented as a single line. The lines are very curvy. The labels are styled with placement: 'line', maxAngle: 0.5, overflow: true.

When maxAngle is defined some charactures start overlapping. It would be better to prevent such overlapping by taking the angle of adjacent charactures into account.
Although the length of the line is enough to fit the entire label, it may sometimes be placed beyond the line. It would be better to keep labels within the line if it is long enough to fit them.
One and the same label instances are sometimes rendered overlapping each other. It would be better to prevent such overlapping.
Label instances are sometimes rendered too close to each other in which case they look cluttered. It would be nice to add some paramether to control the number of instances a label is rendered on the current map view.

Can anyone help me to align the text along with the orientation of the line

Duplicate of #8236, which has more detail on the problem.


Workflow Docs

Multiple docs around workflows...

New Builds doc under Deployment, documenting build copy, import and export
New Workflows section
New Staging/Production doc under Workflows
New Custom doc under Workflows

Release Playbook

[ ] Rebase against master
[ ] Code review
[ ] Merge into master
[ ] Verify changes at http://site-staging.convox.com
[ ] Promote release on site-production in the convox/production Rack

This is stale. Closing without merge.


[c2][decoder] Fixed some issues when oneVPL returns resolution change

case: widevineH264AdaptiveWithRendererDisablingV18

prevent deleting bs which in use.
when oneVPL returns an error of resolution change, it is not necessarily the width or height has changed. however, we reinit the codec.
when deleting a work if it is not found, do not return a fatal error directly.

Tracked-On: OAM-104374
Signed-off-by: zhangyichix<EMAIL_ADDRESS>

Do you mean is resolution change event got, for oneVPL the resolution may not changed, so the older logic of check resolution change may not work anymore, and we just run the reset logic without check width/height again?

yes.


Add R2 bucket binding

Description
Added the ability to binding an R2 bucket to workers.  Cloudflare-go currently supports binding of text, kv namespaces, secrets, etc. but not R2 buckets.  This changes adds support for R2 bucket bindings.
Has your change been tested?
Enhanced TestWorkers_ListWorkerBindingsMultiScript with an additional test for R2 bucket bindings.  Also verified this against an active cloudflare account.
Types of changes
What sort of change does your code introduce/modify?

[X] New feature (non-breaking change which adds functionality)

Checklist:

[x] My code follows the code style of this project.
[X] I have added tests to cover my changes.
[X] All new and existing tests passed.
[X] This change is using publicly documented (api.cloudflare.com or developers.cloudflare.com) and stable APIs.

Codecov Report

Merging #964 (2512553) into master (939975e) will decrease coverage by 0.00%.
The diff coverage is 43.75%.

@@            Coverage Diff             @@
##           master     #964      +/-   ##
==========================================
- Coverage   48.59%   48.59%   -0.01%
==========================================
  Files          97       97
  Lines        9924     9940      +16
==========================================
+ Hits         4823     4830       +7
- Misses       4040     4049       +9
  Partials     1061     1061

Impacted Files
Coverage Δ

workers.go
68.71% <43.75%> (-0.85%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 939975e...2512553. Read the comment docs.

appreciate the PR, thank you!


skillmap homescreen: repeating exception in debug output

Fixed in stable7.1. Will merge stable to master after we ship it.


Clarify zoom API

Right now zoom_level can be get/set or one can call zoom which seems to do the same thing. Not sure that was the intent in the original API proposal at https://gist.github.com/eteq/bb625148969db51b2b03b71e92ca5231

Oh, it's about relative vs absolute zoom.  That is get/set of zoom is all that is needed for the functionality, but something along the lines of this is useful:
def zoom(factor):
    self.zoom_level = self.zoom_level*factor

So it's really just trivial syntactic sugar.  Now that I look at that, perhaps an alternative is to just tell users to do self.zoom_level *= factor, though?  As long as zoom_level is a multiplicative factor rather than a non-linear thing like some other js image viewers I've seen, anyway.

I implemented what I just said above in #15 ...
however, that made me realize a confusing element: ginga distinguishes between "zoom" and "scale".  As I understand it, scale is 2d (x and y), while zoom is a fixed change.  But zoom is also distinguished by the "rate" being settable.  Presumably this is to facilitate user interaction to make the zoom be faster.
My instinct is that the API we're using here is a bit better for the purpose we have here because it's simpler, and is what I think more people have in mind when they think of "zooming" - but it's a lot closer to what ginga calls "scale".  And maybe we do want a way to control the "zoom rate".  I just think that should be handled as a widget property and not better of the Python-useful API.  Do you have any thoughts on that @pllim ?

Looks like #15 is merged. I'm okay with current implementation. We can revisit extra functionality if users complain about not able to set zoom the other way. Should we close this?

Closed by #15


Adding user interaction to presented Views

Hi,
I want hide PKHUDErrorView faster then timer fire, when user clicked on X. UITapGestureRecognizer added to MBHUDErrorView not working. How I can do this?

I'm not quite following


hack/tls-setup tools is broken

Env
$ ./bin/etcd --version
etcd Version: 3.0.0+git
Git SHA: 581f847
Go Version: go1.5.4
Go OS/Arch: linux/amd64

Steps to reproduce
$ go get github.com/coreos/etcd
$ cd $GOPATH/src/github.com/coreos/etcd
$ ./build
$ cd hack/tls-setup
$ make
$ goreman start

Actual result
10:58:57 etcd3 | 2016-07-01 10:58:57.845691 N | membership: set the initial cluster version to 3.0
10:58:57 etcd2 | 2016-07-01 10:58:57.849779 N | membership: set the initial cluster version to 3.0
10:58:57 etcd1 | 2016-07-01 10:58:57.850985 N | membership: set the initial cluster version to 3.0
10:58:57 etcd3 | 2016-07-01 10:58:57.954489 I | api: enabled capabilities for version 3.0.0
10:58:57 etcd3 | 2016-07-01 10:58:57.954847 I | v3rpc/grpc: transport: http2Client.notifyError got notified that the client transport was broken unexpected EOF.
10:58:58 etcd1 | 2016-07-01 10:58:58.031714 I | v3rpc/grpc: transport: http2Client.notifyError got notified that the client transport was broken unexpected EOF.
10:58:58 etcd2 | 2016-07-01 10:58:58.066854 I | v3rpc/grpc: transport: http2Client.notifyError got notified that the client transport was broken unexpected EOF.
10:58:58 etcd3 | 2016-07-01 10:58:58.073724 I | v3rpc/grpc: transport: http2Client.notifyError got notified that the client transport was broken unexpected EOF.

Expected results
Tool works as it was on revision 374b14e

@agalitsyn What are the client commands that you sent to etcd server?

@xiang90 I can reproduce in linux machine. Just goreman start will return these errors...

@gyuho OK. We should fix it then.

Sure, I will investigate more to fix it.

@xiang90 right, I did just goreman start and nothing more.

Can it be related with that etcd v3 uses gRPC, which use HTTP2, which means go1.6? I build etcd on go1.5.4. At least you might want mention this in doc.

I built etcd master branch with Go tip, and still see this. We have TLS e2e tests, so it looks like some TLS configuration issue. We will investigate more.
Thanks for reporting!

@agalitsyn I would suspect it is an internal issue (seem like the grpc gateway was complaining). We will take a look tomorrow morning. it is late night here at US.

@agalitsyn I tried go1.6.2 and go1.7beta1 and works well (go tip as of yesterday doesn't work though...).
Can you try again with go1.6.2 or go1.7beta1?
Thanks!

http2 probably does not work well on go 1.5. so closing.

@xiang90 works with go 1.6.2, here actions log for you
$ cd $GOPATH/src/github.com/coreos/etcd
$ docker run -it -v $(pwd):/go/src/github.com/coreos/etcd golang:1.6.2-alpine sh
# apk update
# apk add git make gcc musl-dev
# cd /go/src/github.com/coreos/etcd
# ./build
# ./bin/etcd --version
etcd Version: 3.0.0+git
Git SHA: 9405583
Go Version: go1.6.2
Go OS/Arch: linux/amd64
# cd hack/tls-setup
# make
# goreman start

result - no errors


Function Replace has wrong names for Parameters

Description for function Replace has parameters not present in function signature like:
oldValueRegexPattern and replacementPropertyName.
Explanation for "When regexPattern, regexGroupName, replacementValue are provided:" should be reviewed as it uses not existent parameters.
Explanation for "When regexPattern, regexGroupName, replacementPropertyName are provided:" should be reviewed as it says "Replacement value is returned as the result", shouldn't be "replacementValue"?
Parameters description should be reviewed to use correct name replacementAttributeName or replacementPropertyName
Review that all parameters are in bold.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: c8685339-06af-5bb1-64da-80c16878b0bf
Version Independent ID: 1ee0d812-00de-90cc-f5e2-d53e3b610bf0
Content: Writing Expressions for Attribute Mappings in Azure Active Directory
Content Source: articles/active-directory/manage-apps/functions-for-customizing-application-data.md
Service: active-directory
GitHub Login: @barbkess
Microsoft Alias: chmutali

@javierruizjimenez Thank you for your reply . We will investigate and update the thread accordingly.

@javierruizjimenez We are requesting the author for getting this reviewed by the engineering.

@barbkess Could you please have the above request reviewed. It seems like a typo and at some places provides incorrect details however since its technical syntax , it would need verification from engineering.
thank you.

Please assign this to @CelesteDG .  Thank you.

@shashishailaj  : Please assign to @CelesteDG

@MicrosoftDocs/azure-cxp-triage : Please assign to @CelesteDG

#reassign:msmimart


[Python] Verify that terminating sequences in binary IPC stream do not interfere with HTTP/1.1 transport

Describe the usage question you have. Please include as many useful details as  possible.
Chunked transfer encoding is commonly used in HTTP/1.1. In chunked transfer encoding, special sequences of bytes are used to separate the chunks and as the terminating chunk. But what happens if those sequences of bytes occur inside binary Arrow IPC data, for example in a binary or string array?
I am almost certain (based on an understanding of how HTTP/1.1 clients work) that this will not cause any problems, but we should test to be fully certain.
To test, we could for example use the simple Python GET example, replacing the schema and the definition of GetPutData with the following:
schema = pa.schema([('a', pa.binary())])

def GetPutData():
    arrays = [pa.array('4\r\nWiki\r\n7\r\npedia i\r\nB\r\nn \r\nchunks.\r\n0\r\n\r\nabcdefg', type=pa.binary())]
    batches = [pa.record_batch(arrays, schema), pa.record_batch(arrays, schema)]
    return batches

Or this similar version which creates the buffers manually:
schema = pa.schema([('a', pa.binary())])

def GetPutData():
    bytestr = '4\r\nWiki\r\n7\r\npedia i\r\nB\r\nn \r\nchunks.\r\n0\r\n\r\nabcdefg'.encode('ascii')
    data = [bytestr, bytestr]
    offsets_buffer = pa.py_buffer(b''.join([n.to_bytes(4, 'little') for n in [0, 49, 98]]))
    values_buffer = pa.py_buffer(b''.join(data))
    array = pa.BinaryArray.from_buffers(pa.binary(), 2, [None, offsets_buffer, values_buffer])
    arrays = [array]
    batches = [pa.record_batch(arrays, schema), pa.record_batch(arrays, schema)]
    return batches

Component(s)
Python

I confirmed through testing that this does not cause any problems. At the beginning of each chunk, HTTP/1.1 clients read the length of the chunk in bytes, then read in the chunk bytes. Clients never look for terminating sequences inside the chunks.


Enable CL Content Assist

I have recently installed Code for i and I am trying to get the CL Content Assist activated. I watched your YouTube video on how to do this but it is unavailable in my Settings. I seen in a previous post here with the same issue and it was suggested that the poster needed...
RPGLE: https://marketplace.visualstudio.com/items?itemName=HalcyonTechLtd.vscode-rpgle
CL: https://marketplace.visualstudio.com/items?itemName=IBM.vscode-clle
These extensions have already been installed but like I noted, in Settings there is no selection for CL Content Assist. Any help would be appreciated.

Hey there.
Do you get a message that asks if you want to install the CL tools? There is no longer a configuration setting for it.

I uninstalled CL and reinstalled and I did get the message. I answered it to update and it and now CL Assist works. It does not display very long, I remember that from the first install. Nice IDE, I use rdi but wanted to check this out. Very fast! I think I will bounce between them for awhile. Thanks for the reply.
Get Outlook for iOShttps://aka.ms/o0ukef

From: barry @.>
Sent: Thursday, May 11, 2023 9:14:31 PM
To: halcyon-tech/vscode-ibmi @.>
Cc: Gregg Willow @.>; Author @.>
Subject: Re: [halcyon-tech/vscode-ibmi] Enable CL Content Assist (Issue #1284)
Hey there.
Do you get a message that asks if you want to install the CL tools? There is no longer a configuration setting for it.
—
Reply to this email directly, view it on GitHubhttps://github.com/halcyon-tech/vscode-ibmi/issues/1284#issuecomment-1545007106, or unsubscribehttps://github.com/notifications/unsubscribe-auth/A7YWFDZZX4UU22F5IH6RYVLXFWMIPANCNFSM6AAAAAAX6QFMC4.
You are receiving this because you authored the thread.Message ID: @.***>
[NOTICE: This message originated outside of the MCIS Mail System -- DO NOT CLICK on links or open attachments unless you are sure the content is safe.]
The information contained in this electronic message may be privileged and/or confidential information and is intended only for the use of the individual(s) to whom this electronic message is addressed. If the reader of this message is not the intended recipient, or the employee or agent responsible to deliver it to the intended recipient, you are hereby notified that any dissemination, distribution or copying of this electronic communication or any attachment thereto is strictly prohibited. If you have received this electronic communication in error, you should immediately return it to us and delete the message from your system. Thank you


trinsic-cli: init at 1.1.0

Motivation for this change
Command line interface for Trinsic Ecosystems
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[x] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
21.11 Release Notes (or backporting 21.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 146458 run on x86_64-linux 1

1 package built:

trinsic-cli

All package related commits should be squashed into the first, and adding the maintainer to the general maintainers file should be called maintainers: add tmarkovski.
Unfortunately when running the program I'm getting weird errors:
$ ./results/trinsic-cli/bin/trinsic wallet
thread 'main' panicked at 'Unrecognized command', src/parser/wallet.rs:35:9
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

All package related commits should be squashed into the first, and adding the maintainer to the general maintainers file should be called maintainers: add tmarkovski.
Unfortunately when running the program I'm getting weird errors:
$ ./results/trinsic-cli/bin/trinsic wallet
thread 'main' panicked at 'Unrecognized command', src/parser/wallet.rs:35:9
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

The config and help subcommands work.

Thanks @legendofmiracles, I'll address the noted. The correct wallet subcommand is trinsic wallet create --name legendofmiracles, you can then follow it with trinsic wallet search. Other command trinsic config --show.

@SuperSandro2000 I'd appreciate your second look on this PR. Requested changes are in. Thanks


Failing to launch emulator - Android Studio 3.4 (Mac OS)

Note - this was performing without issue prior to updating Android Studio.

Hey Keith,
I updated also to Android Studio 3.4, but not have any issues so far.
Your issue seems to be related with the avdmanager, can you run avdmanager list avd ?
Maybe something is broken in the Android-SDK.


 I add a symbolic break point, there is my lldb bt instruction prints:

thread #4: tid = 0x17dce, 0x004ece34 WorkBench`+[TBImageUtility guassianBlurProcess:withProgress:](self=, _cmd=, inputImage=, progress=) + 40 at TBImageUtility.m:103, queue = 'NSOperationQueue 0x1ae69d0 :: NSOperation 0xe6d1d50 (QOS: USER_INTERACTIVE)', stop reason = breakpoint 3.1

frame #0: 0x004ece34 WorkBench+[TBImageUtility guassianBlurProcess:withProgress:](self=<unavailable>, _cmd=<no value available>, inputImage=<unavailable>, progress=<unavailable>) + 40 at TBImageUtility.m:103 [opt] frame #1: 0x004e480e WorkBench-[SDWebImageDownloaderOperation connection:didReceiveData:](self=0x0e6d1d50, _cmd=, connection=, data=) + 1174 at SDWebImageDownloaderOperation.m:443 [opt]
frame #2: 0x1b9f2172 CFNetwork__65-[NSURLConnectionInternal _withConnectionAndDelegate:onlyActive:]_block_invoke + 56 frame #3: 0x1b9f212c CFNetwork-[NSURLConnectionInternal _withConnectionAndDelegate:onlyActive:] + 182
frame #4: 0x1b9f221c CFNetwork-[NSURLConnectionInternal _withActiveConnectionAndDelegate:] + 36 frame #5: 0x1b9bbf2a CFNetwork_NSURLConnectionDidReceiveData(_CFURLConnection*, __CFData const*, long, void const*) + 76
frame #6: 0x1b9408da CFNetwork___ZN27URLConnectionClient_Classic29_delegate_didReceiveDataArrayEv_block_invoke + 214 frame #7: 0x1b93fe30 CFNetwork___ZN27URLConnectionClient_Classic18_withDelegateAsyncEPKcU13block_pointerFvP16_CFURLConnectionPK33CFURLConnectionClientCurrent_VMaxE_block_invoke_2 + 70
frame #8: 0x017a0d52 libdispatch.dylib_dispatch_client_callout + 22 frame #9: 0x017aa472 libdispatch.dylib_dispatch_block_invoke_direct + 338
frame #10: 0x1b9d3986 CFNetworkRunloopBlockContext::_invoke_block(void const*, void*) + 18 frame #11: 0x1b202a84 CoreFoundationCFArrayApplyFunction + 36
frame #12: 0x1b9d3870 CFNetworkRunloopBlockContext::perform() + 180 frame #13: 0x1b9d482e CFNetworkMultiplexerSource::perform() + 208
frame #14: 0x1b9d4640 CFNetworkMultiplexerSource::_perform(void*) + 46 frame #15: 0x1b2b5c8a CoreFoundationCFRUNLOOP_IS_CALLING_OUT_TO_A_SOURCE0_PERFORM_FUNCTION + 12
frame #16: 0x1b2b5794 CoreFoundation__CFRunLoopDoSources0 + 438 frame #17: 0x1b2b3a6a CoreFoundation__CFRunLoopRun + 762
frame #18: 0x1b203072 CoreFoundationCFRunLoopRunSpecific + 486 frame #19: 0x1b245528 CoreFoundationCFRunLoopRun + 104
frame #20: 0x004e35aa WorkBench-[SDWebImageDownloaderOperation start](self=<unavailable>, _cmd=<unavailable>) + 1850 at SDWebImageDownloaderOperation.m:161 [opt] frame #21: 0x1bbfd10a Foundation__NSOQSchedule_f + 190
frame #22: 0x017aced8 libdispatch.dylib_dispatch_queue_serial_drain + 980 frame #23: 0x017a4214 libdispatch.dylib_dispatch_queue_invoke + 556
frame #24: 0x017aede0 libdispatch.dylib_dispatch_root_queue_drain + 408 frame #25: 0x017aebe8 libdispatch.dylib_dispatch_worker_thread3 + 112
frame #26: 0x1ab55946 libsystem_pthread.dylib_pthread_wqthread + 1168 frame #27: 0x1ab5549c libsystem_pthread.dylibstart_wqthread + 8

i do not think TBImageUtility is part of Apple's IOS 10 frameworks.Maybe is it part of your code.closing this. please reopen if thats not the case


Use Mul by reference in pow

Resubmission of #153, since it wasn't open to maintainer edits.  I added a distinct Float::powi fallback since that doesn't have Mul by reference.
cc @dten

bors r+

Shame i lost my commit contribute but oh well. Thanks

Your commit still has you as the author, just me as the committer since I rebased it.  Is that what you mean?

Doesn't show in contributors for some reason. No idea how github makes those stats. Doesn't matter i just like numbers against my name haha

Oh, I think that's just because it's not on master. :)

Ahh. The wait begins


adds cones for felinids

meow meow

About the PR
Media

[ ] I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Changelog

:cl:

add: cones to wear
remove: Removed fun!

screenshot please

screenshot please

working on it, i just been busy

updated sprites

This PR makes me consider if a component that restricts usage by morphotype might be useful.
I'm also thinking now maybe switching it to a neck slot item might fix the back sprite layering issue. It's worth a try.

That might be helpful for this

I'm not home at the moment.

all the errors created are stuff don't know how to fix

how i feel closing the pr even though i can save it but im just too lazy to...


Misleading comment

Comments in ftorch.f90 describing the device to specify when running on GPUs suggest torch_kGPU, as opposed to the correct torch_kCUDA.

Thanks Elliot - this is why testing in practice is better than 'works in theory'!!
If you can correct with a quick PR that would be great.
I'm intrigued to see how one might get the mps or xpu backends to work...

Resolved by #49


Custom keyboard key for RE4 Tweaks menu?

As discussed in a previous thread, we came to the understanding that Home + End wasn't the best key combo for toggling the Debug as many users don't have keyboards with those keys. Now another user has brought it to my attention that F1 is actually used by Raz0r's trainer, as well as some other custom mods people have made.
Would it be possible to include  an option to use a custom keyboard key instead of F1 in the [MISC] section like what was done with:
DebugMenuKeyCombination = CTRL+F3 ?
maybe something like:
RE4TweaksMenuKeyCombination = CTRL+F1 ?
You could still default to F1 , but give a few examples in the ini for people to draw from for formatting purposes.
Thanks!

Hmm, maybe should add a [HOTKEYS] section to INI & allow customizing them all in there, instead of having XXKeyCombination settings in different categories.
Something like
[HOTKEYS]
; Key combinations for various RE4 tweaks features
; All keys can be combined (requiring multiple to be pressed at the same time) by using + symbol between key names
; (see top of Settings.cpp file for possible key names to use)

; Key-combination to open the re4_tweaks config UI
ConfigMenu = F1

; Key-combination to open the re4_tweaks debug console (only in certain re4_tweaks builds)
Console = F2

; Key-combination to make the "tool menu" debug menu appear
; (Requires EnableDebugMenu = True above)
DebugMenu = CTRL+F3

The new section could be a good idea.
Could move the inventory flipping and qte bindings there too, I guess.
(@emoose just sent you another email, in albert's behalf this time :p)

@nipkownix replied, also forgot to mention in that email, but can you let albert know I'm thankful for the offer too 😄

No worries, I'll let him know right away!

thanks for the speedy reply and willingness to implement this.

Implemented as of 5d9fe7fae761786b.
Here's a build:
re4_tweaks-hotkeys.zip
No support for mouse keys for now though. Have yet to decide what to do with those.
 Let me know if it is all good.
Thanks!


Update prost from 0.11.9 to 0.12.0

In my use case and by running test I didn't notice with pushing prost to 0.12.0 any problems.

Many thanks for putting together this PR! I was planning to release a new version in the next two weeks. I did notice that Prost now has a version 0.12.1 (also in crates.io), so we might want to go straight for that one instead. Also need a little more time to investigate why the build fails at 1.62. It looks like minimum required will be 1.63 now...

Just pushed prost up to 0.12.1. When it comes to MSRV I am perfectly fine with needing 1.63. In the project I am using prost-wkt I do use current stable and update it regularly so that doesn't affect me.

FYI #54 has an error that is happening when one uses prost-wkt with the latest version of prost (0.12.1). I'm also having the same error.
Just saying this here to avoid potential problems with bumping the prost version of the crate. Maybe prost introduced a breaking change that does not have a test here to catch it? Not sure, but though you all should know.

FYI #54 has an error that is happening when one uses prost-wkt with the latest version of prost (0.12.1). I'm also having the same error.
Just saying this here to avoid potential problems with bumping the prost version of the crate. Maybe prost introduced a breaking change that does not have a test here to catch it? Not sure, but thought you all should know.

No, this is just how rust works, when you pull current prost-wkt into a project that uses prost 0.12.1 you have two prost version in your project, 0.11 with prost-wkt implements and 0.12.1 with your project uses, so yes then you get errors of stuff not implemented because prost structs implement it for 0.11, not 0.12.
They where for sure some breaking changes in 0.12 with is why the version bump was made, but they don't affect prost-wkt.

FYI #54 has an error that is happening when one uses prost-wkt with the latest version of prost (0.12.1). I'm also having the same error.
Just saying this here to avoid potential problems with bumping the prost version of the crate. Maybe prost introduced a breaking change that does not have a test here to catch it? Not sure, but thought you all should know.

No, this is just how rust works, when you pull current prost-wkt into a project that uses prost 0.12.1 you have two prost version in your project, 0.11 with prost-wkt implements and 0.12.1 with your project uses, so yes then you get errors of stuff not implemented because prost structs implement it for 0.11, not 0.12. They where for sure some breaking changes in 0.12 with is why the version bump was made, but they don't affect prost-wkt.

I see, thanks for the reply! Hopefully we'll be having this PR merged soon, then. I introduced an implementation of TryFrom for prost's enums and wanted to use it in my projects.

@fdeantoni Is there anything blocking releasing the new version on crates.io?


chore: No more painfully to see warnings

It's just that ☝ I cleared up the build warnings so your github actions result will no longer look like:

Thank you! We'll have a look asap

@waldekmastykarz I got an update that you merged the latest main to this branch, but there aren’t any updates right?

I got a message that there were updates on main so added them. I'll have a closer look at the PR asap 👍


Minor code optimizations and linting

Double referencing in format! args have a small perf impact
A few format arg inlining
Fixed a few pedantic clippy things

I was trying to solve #39 and was reviewing the code in the mean time - and this is the result, hope these nits are not too big of a problem, thx!

Thanks!


Access Review APIs

Description
The API server should provide endpoints to allow access control checks and subject access checks without direct knowledge of the backing authorization engine.  This allows delegation of authorization.
Progress Tracker

[ ] Before Alpha

[ ] Write and maintain draft quality doc

[ ] During development keep a doc up-to-date about the desired experience of the feature and how someone can try the feature in its current state. Think of it as the README of your new feature and a skeleton for the docs to be written before the Kubernetes release. Paste link to Google Doc: DOC-LINK

[x] Design Approval

[x] Design Proposal. Upstreaming *AccessReview checks from https://github.com/openshift/origin/blob/master/docs/proposals/policy.md#apiversionnsnamespaceresourceaccessreview was agreed to some time ago in @kubernetes/sig-auth
[x] Initial API review (if API).  Maybe same PR as design doc. https://github.com/kubernetes/kubernetes/pull/18722 introduced the objects

Any code that changes an API (/pkg/apis/...)
cc @kubernetes/api

[x] Identify shepherd (your SIG lead and/or<EMAIL_ADDRESS>will be able to help you). @deads2k @erictune

A shepherd is an individual who will help acquaint you with the process of getting your feature into the repo, identify reviewers and provide feedback on the feature. They are not (necessarily) the code reviewer of the feature, or tech lead for the area.
The shepherd is not responsible for showing up to Kubernetes-PM meetings and/or communicating if the feature is on-track to make the release goals. That is still your responsibility.

[x] Identify secondary/backup contact point. @liggitt

[ ] Write (code + tests + docs) then get them merged.  ALL-PR-NUMBERS

[x] Code needs to be disabled by default.   Verified by code OWNERS
[x] Minimal testing
[ ] Minimal docs

cc @kubernetes/docs on docs PR
cc @kubernetes/feature-reviewers on this issue to get approval before checking this off
New apis: Glossary Section Item in the docs repo: kubernetes/kubernetes.github.io

[ ] Update release notes

[ ] Before Beta

[ ] Testing is sufficient for beta
[ ] User docs with tutorials
- Updated walkthrough / tutorial in the docs repo: kubernetes/kubernetes.github.io
- cc @kubernetes/docs on docs PR
- cc @kubernetes/feature-reviewers on this issue to get approval before checking this off
[ ] Thorough API review

cc @kubernetes/api

[ ] Before Stable

[ ] docs/proposals/foo.md moved to docs/design/foo.md
- cc @kubernetes/feature-reviewers on this issue to get approval before checking this off
[ ] Soak, load testing
[ ] detailed user docs and examples

cc @kubernetes/docs
cc @kubernetes/feature-reviewers on this issue to get approval before checking this off

FEATURE_STATUS is used for feature tracking and to be updated by @kubernetes/feature-reviewers.
FEATURE_STATUS: IN_DEVELOPMENT
More advice:
Design

Once you get LGTM from a @kubernetes/feature-reviewers member, you can check this checkbox, and the reviewer will apply the "design-complete" label.

Coding

Use as many PRs as you need.  Write tests in the same or different PRs, as is convenient for you.
As each PR is merged, add a comment to this issue referencing the PRs.  Code goes in the http://github.com/kubernetes/kubernetes repository,
and sometimes http://github.com/kubernetes/contrib, or other repos.
When you are done with the code, apply the "code-complete" label.
When the feature has user docs, please add a comment mentioning @kubernetes/feature-reviewers and they will
check that the code matches the proposed feature and design, and that everything is done, and that there is adequate
testing.  They won't do detailed code review: that already happened when your PRs were reviewed.
When that is done, you can check this box and the reviewer will apply the "code-complete" label.

Docs

[ ] Write user docs and get them merged in.
User docs go into http://github.com/kubernetes/kubernetes.github.io.
When the feature has user docs, please add a comment mentioning @kubernetes/docs.
When you get LGTM, you can check this checkbox, and the reviewer will apply the "docs-complete" label.

@kubernetes/sig-auth @erictune @smarterclayton
We've talked about doing this for some time.  The API objects were actually approved and merged, but we've had trouble getting review attention on the PRs that provide the REST endpoints.
I'd really like to focus on getting this in for 1.4.  I think providing a complete authorization delegation API is important for things like server federation.

David and I are both SIG leads and we both approve of this initiative.
On Wed, Jul 20, 2016 at 12:44 PM, David Eads<EMAIL_ADDRESS>wrote:

@kubernetes/sig-auth https://github.com/orgs/kubernetes/teams/sig-auth
@erictune https://github.com/erictune @smarterclayton
https://github.com/smarterclayton
We've talked about doing this for some time. The API objects were actually
approved and merged, but we've had trouble getting review attention on the
PRs that provide the REST endpoints.
I'd really like to focus on getting this in for 1.4. I think providing a
complete authorization delegation API is important for things like server
federation.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/kubernetes/features/issues/37#issuecomment-234059876,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AHuudmdyce9Dhlry6gkO0f4MxwEv-OEvks5qXnqEgaJpZM4JRIlO
.

https://github.com/kubernetes/kubernetes/pull/31271 adds the SelfSubjectAccessReview API.

@deads2k Are the docs ready? Please update the docs in https://github.com/kubernetes/kubernetes.github.io, and then add PR numbers and check the docs box in the issue description

Ping.  Any update on docs?

Ping. Any update on docs?

Right now, its API only, but swagger is complete.  CLI integration should come in 1.5 and then there will be something more substantive to doc for end users.

How about one sentence that says that the API exists, so that people know
to go look at the swagger?  Nobody is going to study the swagger to find
new APIs.
On Wed, Sep 7, 2016 at 3:39 PM, David Eads<EMAIL_ADDRESS>wrote:

Ping. Any update on docs?
Right now, its API only, but swagger is complete. CLI integration should
come in 1.5 and then there will be something more substantive to doc for
end users.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/kubernetes/features/issues/37#issuecomment-245441726,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AHuudohBEVPn9ma6PJpHKQWaQI8rH5Nwks5qnz0qgaJpZM4JRIlO
.

How about one sentence that says that the API exists, so that people know
to go look at the swagger?  Nobody is going to study the swagger to find
new APIs.

Fair.  I'll find a spot tomorrow or early next week.

@deads2k @erictune Another ping on docs. Any PRs you can point me to?

@deads2k @erictune Another ping on docs. Any PRs you can point me to?

I've written a brief description here: https://github.com/kubernetes/kubernetes.github.io/pull/1219 .  As we continue to fill out the API, it will become easier to use and have more capability.


AIR amplifier wrong position?

As like in http://explorer.milsymb.net/#/explore/ an helo should look like this:
https://gyazo.com/36d75ef86506e1c37df4c0b8952995a8
yours look like this:
https://gyazo.com/7fe77da3332ecfbce6e079878fa2606f
I am not sure what the specification says,
if yours is correct, just forward the issue to the other project :P
I use version ## 1.2.1 12 JUN 2017

This is a bit tricky, if we look in MIL-STD-2525D, the unit size modifiers are not specified for air symbols. Compare figure C-3 and figure D-3 here http://www.dtic.mil/doctrine/doctrine/other/ms_2525d.pdf
What happens in the milsymb explorer is that the unit size modifiers are drawn in the position that they would be for land unit frames, and they are not move based on the size of the frame. So if you change the symbol to neutral instead of friend it will suddenly be outside of the frame.

Since I know that users want to set the unit size modifier on all types of symbols the approach in milsymbol is a bit more complex, where I take the intent of land units (that the modifier should be on top of the frame) and apply it to all type of frames, so that the modifier is not defined in a fixed place and instead as a small offset from the frame.
So to answer your question:
I think that the way that milsymbol draws the symbol is correct. And I also think that it is handled correct in milsymb since you shouldn't use the unit size modifier on air symbols.
Does this explanation make sense for you?

It is all fine! I just noticed the difference and thought might be good to tell.
For my application it is good, to also be able to set the amplifier no matter what the spec says :D


Skip type checking project reference redirect(declaration file from project reference) to improve perf

Search Terms

Suggestion
We could probably set internal option and skip type checking project reference redirects (included .d.ts files from project reference output)
This could speed up tsc --b mode by skipping type checking generated files, (eg. skip compiler.d.ts when building tsc project and so on...) Since in build mode referencing projects are not built if there are any errors in the referenced project this should report all errors.
Use Cases

Examples

Checklist
My suggestion meets these guidelines:

[ ] This wouldn't be a breaking change in existing TypeScript / JavaScript code
[ ] This wouldn't change the runtime behavior of existing JavaScript code
[ ] This could be implemented without emitting different JS based on the types of the expressions
[ ] This isn't a runtime feature (e.g. new expression-level syntax)

It would, yea.

Is this proposal only for TypeScript's internal use to compile itself or is it intended for all users of project references?
If the consuming project has different compiler options than the referenced project, there might be type errors in the declaration files. Therefore type checking declaration files of referenced projects should not be turned off by default.

Did we end up doing this?  We don't actually type check our own output if --skipLibCheck isn't set, do we?


New feature PEG ratio

I have create the function.py and main.py

Also update ENDPOINTS.md and push this in same PR @iamVedanta

Hey @iamVedanta, can you add the ENDPOINTS in md file?? Or should I close the PR?


Network Traffic graph displays errenous traffic spikes

Ported from: https://github.com/bitcoin/bitcoin/issues/10296. This has had little follow up / discussion, and may not even be an issue any more (tested version was 0.14.0).
Describe the issue
First Issue
In Bitcoin Core 0.14.0 the Network Traffic graph in the Debug window displays erroneous traffic spikes when synchronizing the block chain. My internet connection is limited to 50 megabit/sec downstream yet the bursts are over 10 megabytes/sec, approximately twice the bandwidth that  my internet connection should be capable of. Although theoretically my internal network could be buffering this traffic and sending it as a burst, these theoretical traffic bursts are not seen by the operating system's Task Manager or Resource Monitor applications therefor I believe it is safe to rule this out as the cause.
Second Issue
When you press the Clear button in the Network Traffic graph, and no network activity is taking place, it will not render a graphic for the graph. After a period of time when network traffic does take place it will render a flat line followed by a graph of the traffic
Can you reliably reproduce the issue?
If so, please list the steps to reproduce below:
First Issue
Replicate the environment, begin to download the block chain and watch the traffic graph window for hours. I'm sure you could save yourself a lot of time by doing this programmatically and have your code look for traffic spikes which would exceed the available internet bandwidth.
Second Issue
Replication the environment, begin to download the block chain, wait for a period of no network traffic, press the clear button, wait for network traffic to resume.
Expected behaviour
First Issue
The network graph should display accurate traffic statistics.
Second Issue
The network graph should display a flat line during periods of no traffic
Actual behaviour
First Issue
There are erroneous traffic spikes.
Second Issue
A flat line is not displayed until traffic occurs after the graph has been cleared.
Screenshots.
First Issue
Please be aware that there is also iSCSI and Remote Desktop Services traffic accounted for in the Task Manager/Resource Monitor graphs. Even with this extra traffic, Task Manager/Resource Monitor does not display the same 10+ megabyte/sec traffic spikes.
Video of it happening with Task Manager - https://my.mixtape.moe/ugszqy.mp4
Screenshot of it happening with Resource Monitor:

Second Issue
Video of it happening - https://my.mixtape.moe/gcazhi.mp4
What version of bitcoin-core are you using?
0.14.0
Machine specs:

OS: Windows Server 2016 Remote Desktop Services Session Host virtual machine with Bitcoin Core configured as a RemoteApp on a VMware ESXi 6.5 host
CPU: 4 cores from a dual Xeon E5-2660v2 with high latency sensitivity and 100% resource reservations
RAM: 4GB with 100% resource reservations
Disk size: OS/Bitcoin Core 32GB, data directory 1TB
Disk Type (HD/SDD): OS/Bitcoin Core is stored on the host as a VMDK on a 8x SSD RAID 0 VMFS6 datastore, the data directory is a thin provisioned LUN on a Microsoft iSCSI target server 2016 failover cluster running deduplication stored on the host as a VMDK on a 8x HDD RAID 6 VMFS5 datastore.
Network: Cable Modem->Cisco ASA 5510 firewall->Two Cisco Aironet 1141 802.11n (2.4Ghz) APs configured as a workgroup bridge->Cisco Catalyst 3750E switch->ESXi host with a Intel X520 NIC as the uplinks for the VDS port group->VM with a VMXNET3 network adapter

Might it be due to the interval being used not always being correct (e.g. sometimes there can be delays in the function being called).
It sounds like you're not able to easily reproduce the issue, but if you were, I'm curious if this https://github.com/rebroad/bitcoin/commit/5ff00f855a4ff6f4beb2cf36b74aebd00488fe62 would help.


Unable to Activate the Flashbot Option via Yarn Deploy

Hi All and many thanks to Daniel for developing this interesting bot. To begin, I am a real beginner with no knowledge of JS,  TS, or Sol coding and programming. I am just trying to understand what it takes to build and interact with web3 and blockchain Apps using practical examples like Liqbot. I was able to clone the repo to vscode and run it successfully but without the flashbot option. Using a Goerli testnet (or Mainnet) node on Alchemy, I was able to register eth-call requests which means the bot would have triggered liquidations if any trove ICR dropped below the MCR. I was not able to assess this as no liquidation events happened (Eth price on the rise) since I started few days back.
The issue is that I was unable to deploy the flashbot smart contract using "yarn deploy". This is what I got whenever I tried:
PS C:\Users\Mine\Documents\GitHub\liqbot> yarn deploy
yarn run v1.22.19
$ node --loader ts-node/esm scripts/deploy.ts
(node:7664) ExperimentalWarning: --experimental-loader is an experimental feature. This feature could change at any time
(Use node --trace-warnings ... to show where the warning was created)
<ref *1> Error: spawnSync yarn ENOENT
at Object.spawnSync (node:internal/child_process:1111:20)
at spawnSync (node:child_process:814:24)
at execFileSync (node:child_process:857:15)
at file:///C:/Users/Mine/Documents/GitHub/liqbot/scripts/deploy.ts:9:3
at ModuleJob.run (node:internal/modules/esm/module_job:198:25)
at async Promise.all (index 0)
at async ESMLoader.import (node:internal/modules/esm/loader:385:24)
at async loadESM (node:internal/process/esm_loader:88:5)
at async handleMainPromise (node:internal/modules/run_main:61:12) {
errno: -4058,
code: 'ENOENT',
syscall: 'spawnSync yarn',
path: 'yarn',
spawnargs: [ '--cwd', 'contracts', 'deploy', '--network', 'external' ],
error: [Circular *1],
status: null,
signal: null,
output: null,
pid: 0,
stdout: null,
stderr: null
}
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
Doing some research, it appears that the error "spawnSync yarn ENOENT" is a well known problem. Being a novice, I was unable to resolve by myself and thought of raising this issue here.
My environment is:

Windows 10/Pro Version 20H2
Vscode 1.69.0
Node 16.15.1
Yarn 1.22.19
Npm 8.13.2

On a last note, whenever I check npm version, I get the following warning:
PS C:\Users\Mine\Documents\GitHub\liqbot> npm -v
npm WARN config global --global, --local are deprecated. Use --location=global instead.
8.13.2
I will appreciate any guidance on how to deploy and enable the flashbot liquidation.
Regards,

Getting the same error


question for ‘clsx’ library usage

i noticed the clsx installed in your project, but i cant find any usage, so what's the purpose?
"clsx": "^2.1.1",

clsx is an essential utility for managing class names in applications. It helps in dynamically constructing class names based on various conditions, which is particularly useful when working with CSS, Sass, and Tailwind. Here are a few reasons why clsx is invaluable:
1.	Conditional Classes: Easily toggle class names based on component state or props.
2.	Combining Classes: Concatenate multiple class names efficiently without worrying about falsy values.
3.	Readability and Maintainability: Cleaner and more readable JSX code compared to traditional string concatenation.

While you might not see explicit usage, it’s intended to streamline the process of applying styles conditionally, especially when integrating Tailwind’s utility classes or custom styles from Sass.


Replace VMware CLA with DCO

Fixes #2171

Thanks for catching all my typos @jianjuns and @tnqn :)

/skip-all


Add explainability algorithms for ML model

One interesting blog on this: https://mindfulmodeler.substack.com/p/shap-is-not-all-you-need

Duplicate of #203


clangd extracts completely wrong includes

On an ARM project, clangd extracts x86_64 includes instead of ARM ones from arm-none-eabi-gcc:
$ clangd --query-driver="/nix/store/*/bin/arm-none-eabi-*" --check=src/main.c
I[19:13:48.701] clangd version 18.1.8
I[19:13:48.701] Features: linux
I[19:13:48.701] PID: 2037970
I[19:13:48.701] Working directory: /home/lu/dev/refloat
I[19:13:48.701] argv[0]: /nix/store/0vwmhvjdkli5jz8aygdb6psn9nar660h-clang-tools-18.1.8/bin/clangd
I[19:13:48.701] argv[1]: --query-driver=/nix/store/*/bin/arm-none-eabi-*
I[19:13:48.701] argv[2]: --check=src/main.c
I[19:13:48.701] Entering check mode (no LSP server)
I[19:13:48.701] Testing on source file /home/lu/dev/refloat/src/main.c
I[19:13:48.701] Loading compilation database...

I[19:13:48.756] Built preamble of size 988384 for file /home/lu/dev/refloat/src/main.c version null in 0.04 seconds
I[19:13:48.756] Indexing headers...
E[19:13:48.773] [pp_file_not_found] Line 20: in included file: 'gnu/stubs-32.h' file not found
I[19:13:48.773] Building AST...
I[19:13:48.815] Indexing AST...
I[19:13:48.821] Building inlay hints
I[19:13:48.821] Building semantic highlighting
I[19:13:48.825] Testing features at each token (may be slow in large files)
I[19:13:49.349] Found definition heuristically in index for io_write
I[19:13:49.349] Found definition heuristically in index for io_write
I[19:13:49.349] Found definition heuristically using nearby identifier beeper_pin
I[19:13:49.349] Found definition heuristically using nearby identifier beeper_pin
I[19:13:49.351] Found definition heuristically in index for io_write
I[19:13:49.351] Found definition heuristically in index for io_write
I[19:13:49.351] Found definition heuristically using nearby identifier beeper_pin
I[19:13:49.351] Found definition heuristically using nearby identifier beeper_pin
I[19:14:00.275] All checks completed, 1 errors

This is what the arm-none-eabi-gcc prints:
$ arm-none-eabi-gcc  -x c++ -E -v -
Using built-in specs.
 search starts here:
#include <...> search starts here:
 /nix/store/9z0l7wpqx3fqybmyp9gjvihw756dg5fi-gcc-arm-embedded-13.2.rel1/bin/../lib/gcc/arm-none-eabi/13.2.1/../../../../arm-none-eabi/include/c++/13.2.1
 /nix/store/9z0l7wpqx3fqybmyp9gjvihw756dg5fi-gcc-arm-embedded-13.2.rel1/bin/../lib/gcc/arm-none-eabi/13.2.1/../../../../arm-none-eabi/include/c++/13.2.1/arm-none-eabi
 /nix/store/9z0l7wpqx3fqybmyp9gjvihw756dg5fi-gcc-arm-embedded-13.2.rel1/bin/../lib/gcc/arm-none-eabi/13.2.1/../../../../arm-none-eabi/include/c++/13.2.1/backward
 /nix/store/9z0l7wpqx3fqybmyp9gjvihw756dg5fi-gcc-arm-embedded-13.2.rel1/bin/../lib/gcc/arm-none-eabi/13.2.1/include
 /nix/store/9z0l7wpqx3fqybmyp9gjvihw756dg5fi-gcc-arm-embedded-13.2.rel1/bin/../lib/gcc/arm-none-eabi/13.2.1/include-fixed
 /nix/store/9z0l7wpqx3fqybmyp9gjvihw756dg5fi-gcc-arm-embedded-13.2.rel1/bin/../lib/gcc/arm-none-eabi/13.2.1/../../../../arm-none-eabi/include
End of search list.

System information
$ clangd --version
clangd version 18.1.8
Features: linux
Platform: x86_64-unknown-linux-gnu

Operating system:
NixOS (hence the weird long include paths, and I suspect the issue might be related to the OS, but since clangd claims to extract from the ARM compiler and the result is x86_64 includes, I'm pretty sure something is wrong in clangd too)

Can you share verbose logs (taken with --log=verbose in clangd's arguments)?

@HighCommander4 attached:
clangd_verbose.txt

Thanks, and can you say more about the "clangd extracts x86_64 includes" part? What are these x86_64 includes and where are you seeing them?

The line in the clangd log starting with:
        got includes: "/nix/store/wy8rawky6ml5l02lmkvxrag43m949g63-python3-3.11.8-env/include ...

Python 3.11. More paths follow that are clearly from my desktop.
A few lines below that a line starting with:
I[19:13:48.718] internal (cc1) args are: -cc1 -triple thumbv7em-none-unknown-eabihf ...

Containing e.g. this and a ton of other desktop includes:
-isystem /nix/store/1dm1zr8bcbsjcqn53c4701lipyq86fpg-qtdeclarative-5.15.12-dev/include

FWIW what I'm trying to troubleshoot is this error in the same log:
E[19:13:48.773] [pp_file_not_found] Line 20: in included file: 'gnu/stubs-32.h' file not found

And I suspect this is because it's using the desktop / x86_64 libs ending with glibc instead of newlib. Not entirely sure that's the case but looks plausible.

Ok, I see. And just to make sure, when you showed the output of arm-none-eabi-gcc  -x c++ -E -v -, the full path of the compiler you were running was /nix/store/9z0l7wpqx3fqybmyp9gjvihw756dg5fi-gcc-arm-embedded-13.2.rel1/bin/arm-none-eabi-gcc (what we see in the log after "System includes extractor: successfully executed")?
Assuming that's the case, the only explanation I can think of is that when clangd executes that command, it has something in its environment (like CXXFLAGS or a similar environment variable) which is not present when you're running the command directly in the terminal, and which influences what the command prints under #include <...> search starts here:.
I vaguely remember running into a case of NixOS making heavy use of environment variables like this in the past.

Assuming that's the case, the only explanation I can think of is that when clangd executes that command, it has something in its environment (like CXXFLAGS or a similar environment variable) which is not present when you're running the command directly in the terminal, and which influences what the command prints under #include <...> search starts here:.

Some brief experimentation shows that the output under #include <...> search starts here: is sensitive to certain environment variables (not CXXFLAGS, but CPATH, C_INCLUDE_PATH, and CPLUS_INCLUDE_PATH in my testing), so this explanation seems plausible.
So I think your recourse would be to ensure these variables are not present in clangd's own environment. Clangd usually inherits the environment from the editor that launches it, so it may be a case of taking care to launch the editor in the right environment, or alternatively replacing clangd's path in your editor's config with the path of a script which clears the environment variables and then calls the actual clangd executable.

Ok, I see. And just to make sure, when you showed the output of arm-none-eabi-gcc -x c++ -E -v -, the full path of the compiler you were running was /nix/store/9z0l7wpqx3fqybmyp9gjvihw756dg5fi-gcc-arm-embedded-13.2.rel1/bin/arm-none-eabi-gcc (what we see in the log after "System includes extractor: successfully executed")?

Yes.

Assuming that's the case, the only explanation I can think of is that when clangd executes that command, it has something in its environment ...

I'm running both commands (clangd --query-driver="/nix/store/*/bin/arm-none-eabi-*" --check=src/main.c and arm-none-eabi-gcc -x c++ -E -v -) from the same shell one after the other. There is no difference in the environment and the editor plays no role here.

I've created a NixOS issue for this, maybe the devs there will have additional insight: https://github.com/NixOS/nixpkgs/issues/348791

Assuming that's the case, the only explanation I can think of is that when clangd executes that command, it has something in its environment ...

I'm running both commands (clangd --query-driver="/nix/store/*/bin/arm-none-eabi-*" --check=src/main.c and arm-none-eabi-gcc -x c++ -E -v -) from the same shell one after the other. There is no difference in the environment and the editor plays no role here.

Perhaps clangd actually refers to a script which adds something to the environment before calling the actual clangd executable?

Oh, you're right, that's it:
$ cat /nix/store/0vwmhvjdkli5jz8aygdb6psn9nar660h-clang-tools-18.1.8/bin/clangd
#!/nix/store/1xhds5s320nfp2022yjah1h7dpv8qqns-bash-5.2p32/bin/sh

buildcpath() {
  local path after
  while (( $# )); do
    case $1 in
        -isystem)
            shift
            path=$path${path:+':'}$1
            ;;
        -idirafter)
            shift
            after=$after${after:+':'}$1
            ;;
    esac
    shift
  done
  echo $path${after:+':'}$after
}

export CPATH=${CPATH}${CPATH:+':'}$(buildcpath ${NIX_CFLAGS_COMPILE} \
                                               $(</nix/store/qg9s4a1473skkrsrh1nykfvxm6w5p23d-clang-wrapper-18.1.8/nix-support/libc-cflags)):/nix/store/qg9s4a1473skkrsrh1nykfvxm6w5p23d-clang-wrapper-18.1.8/resource-root/include
export CPLUS_INCLUDE_PATH=${CPLUS_INCLUDE_PATH}${CPLUS_INCLUDE_PATH:+':'}$(buildcpath ${NIX_CFLAGS_COMPILE} \
                                                                                $(</nix/store/qg9s4a1473skkrsrh1nykfvxm6w5p23d-clang-wrapper-18.1.8/nix-support/libcxx-cxxflags) \
                                                                                $(</nix/store/qg9s4a1473skkrsrh1nykfvxm6w5p23d-clang-wrapper-18.1.8/nix-support/libc-cflags)):/nix/store/qg9s4a1473skkrsrh1nykfvxm6w5p23d-clang-wrapper-18.1.8/resource-root/include

exec -a "$0" /nix/store/maa8li4ybxv6hb2k23n4akqdk609fh1r-clang-18.1.8/bin/$(basename $0) "$@"

And if I call the binary from the script without the added environment, it works much better:
$ /nix/store/maa8li4ybxv6hb2k23n4akqdk609fh1r-clang-18.1.8/bin/clangd --query-driver="/nix/store/*/bin/arm-none-eabi-*" --check=src/main.c
I[00:11:30.406] clangd version 18.1.8
I[00:11:30.406] Features: linux
I[00:11:30.406] PID: 2918316
I[00:11:30.406] Working directory: /home/lu/dev/refloat
I[00:11:30.406] argv[0]: /nix/store/maa8li4ybxv6hb2k23n4akqdk609fh1r-clang-18.1.8/bin/clangd
I[00:11:30.406] argv[1]: --query-driver=/nix/store/*/bin/arm-none-eabi-*
I[00:11:30.406] argv[2]: --check=src/main.c
I[00:11:30.406] Entering check mode (no LSP server)
I[00:11:30.406] Testing on source file /home/lu/dev/refloat/src/main.c
I[00:11:30.406] Loading compilation database...
I[00:11:30.407] Loaded compilation database from /home/lu/dev/refloat/compile_commands.json
I[00:11:30.418] System includes extractor: successfully executed /nix/store/9z0l7wpqx3fqybmyp9gjvihw756dg5fi-gcc-arm-embedded-13.2.rel1/bin/arm-none-eabi-gcc
        got includes: "/nix/store/9z0l7wpqx3fqybmyp9gjvihw756dg5fi-gcc-arm-embedded-13.2.rel1/bin/../lib/gcc/arm-none-eabi/13.2.1/include-fixed, /nix/store/9z0l7wpqx3fqybmyp9gjvihw756dg5fi-gcc-arm-embedded-13.2.rel1/bin/../lib/gcc/arm-none-eabi/13.2.1/../../../../arm-none-eabi/include"
        got target: "arm-none-eabi"
I[00:11:30.418] Compile command from CDB is: [/home/lu/dev/refloat/src] /nix/store/9z0l7wpqx3fqybmyp9gjvihw756dg5fi-gcc-arm-embedded-13.2.rel1/bin/arm-none-eabi-gcc -fpic -Os -Wall -Wextra -Wundef -std=gnu99 -I../vesc_pkg_lib/ -I../vesc_pkg_lib//stdperiph_stm32f4//CMSIS/include -I../vesc_pkg_lib//stdperiph_stm32f4//CMSIS/ST -I../vesc_pkg_lib//utils// -fomit-frame-pointer -falign-functions=16 -mthumb -fsingle-precision-constant -Wdouble-promotion -mfloat-abi=hard -mfpu=fpv4-sp-d16 -mcpu=cortex-m4 -fdata-sections -ffunction-sections -DIS_VESC_LIB -DUSE_STLIB -I../vesc_pkg_lib//stdperiph_stm32f4//inc -flto -c -o main.so -isystem /nix/store/9z0l7wpqx3fqybmyp9gjvihw756dg5fi-gcc-arm-embedded-13.2.rel1/bin/../lib/gcc/arm-none-eabi/13.2.1/include-fixed -isystem /nix/store/9z0l7wpqx3fqybmyp9gjvihw756dg5fi-gcc-arm-embedded-13.2.rel1/bin/../lib/gcc/arm-none-eabi/13.2.1/../../../../arm-none-eabi/include --target=arm-none-eabi -resource-dir=/nix/store/maa8li4ybxv6hb2k23n4akqdk609fh1r-clang-18.1.8/lib/clang/18 -- /home/lu/dev/refloat/src/main.c
I[00:11:30.418] Parsing command...
I[00:11:30.419] internal (cc1) args are: -cc1 -triple thumbv7em-none-unknown-eabihf -fsyntax-only -flto=full -flto-unit -disable-free -clear-ast-before-backend -disable-llvm-verifier -discard-value-names -main-file-name main.c -function-alignment 4 -mrelocation-model pic -pic-level 1 -fhalf-no-semantic-interposition -mframe-pointer=none -fmath-errno -ffp-contract=on -fno-rounding-math -mconstructor-aliases -nostdsysteminc -target-cpu cortex-m4 -target-feature -crc -target-feature -dotprod -target-feature +dsp -target-feature -mve -target-feature -mve.fp -target-feature -ras -target-feature -bf16 -target-feature -sb -target-feature -i8mm -target-feature -lob -target-feature -cdecp0 -target-feature -cdecp1 -target-feature -cdecp2 -target-feature -cdecp3 -target-feature -cdecp4 -target-feature -cdecp5 -target-feature -cdecp6 -target-feature -cdecp7 -target-feature -pacbti -target-feature -hwdiv-arm -target-feature +hwdiv -target-feature -vfp2 -target-feature +vfp2sp -target-feature -vfp3 -target-feature -vfp3d16 -target-feature +vfp3d16sp -target-feature -vfp3sp -target-feature +fp16 -target-feature -vfp4 -target-feature -vfp4d16 -target-feature +vfp4d16sp -target-feature -vfp4sp -target-feature -fp-armv8 -target-feature -fp-armv8d16 -target-feature -fp-armv8d16sp -target-feature -fp-armv8sp -target-feature -fullfp16 -target-feature -fp64 -target-feature -d32 -target-feature -neon -target-feature -fp16fml -target-feature -crypto -target-feature -sha2 -target-feature -aes -target-feature +strict-align -target-abi aapcs -mfloat-abi hard -Wunaligned-access -debugger-tuning=gdb -fdebug-compilation-dir=/home/lu/dev/refloat/src -ffunction-sections -fdata-sections -fcoverage-compilation-dir=/home/lu/dev/refloat/src -nostdsysteminc -resource-dir /nix/store/maa8li4ybxv6hb2k23n4akqdk609fh1r-clang-18.1.8/lib/clang/18 -isystem /nix/store/9z0l7wpqx3fqybmyp9gjvihw756dg5fi-gcc-arm-embedded-13.2.rel1/bin/../lib/gcc/arm-none-eabi/13.2.1/include-fixed -isystem /nix/store/9z0l7wpqx3fqybmyp9gjvihw756dg5fi-gcc-arm-embedded-13.2.rel1/bin/../lib/gcc/arm-none-eabi/13.2.1/../../../../arm-none-eabi/include -I ../vesc_pkg_lib/ -I ../vesc_pkg_lib//stdperiph_stm32f4//CMSIS/include -I ../vesc_pkg_lib//stdperiph_stm32f4//CMSIS/ST -I ../vesc_pkg_lib//utils// -D IS_VESC_LIB -D USE_STLIB -I ../vesc_pkg_lib//stdperiph_stm32f4//inc -internal-isystem /nix/store/maa8li4ybxv6hb2k23n4akqdk609fh1r-clang-18.1.8/lib/clang/18/include -source-date-epoch 315532800 -Os -Wall -Wextra -Wundef -Wdouble-promotion -std=gnu99 -ferror-limit 19 -fno-signed-char -fgnuc-version=4.2.1 -fskip-odr-check-in-gmf -vectorize-loops -vectorize-slp -no-round-trip-args -faddrsig -x c /home/lu/dev/refloat/src/main.c
I[00:11:30.419] Building preamble...
I[00:11:30.439] Built preamble of size 694932 for file /home/lu/dev/refloat/src/main.c version null in 0.02 seconds
I[00:11:30.439] Indexing headers...
E[00:11:30.453] [pp_file_not_found] Line 20: in included file: 'stdbool.h' file not found
I[00:11:30.453] Building AST...
E[00:11:30.488] [field_declared_as_function] Line 98: field 'beeper_enabled' declared as a function
E[00:11:30.488] [field_declared_as_function] Line 100: field 'standstill_brake_active' declared as a function
E[00:11:30.488] [field_declared_as_function] Line 122: field 'surge_enable' declared as a function
E[00:11:30.488] [field_declared_as_function] Line 123: field 'duty_beeping' declared as a function
E[00:11:30.488] [field_declared_as_function] Line 164: field 'traction_control' declared as a function
E[00:11:30.488] [field_declared_as_function] Line 173: field 'is_upside_down_started' declared as a function
E[00:11:30.488] [field_declared_as_function] Line 174: field 'enable_upside_down' declared as a function
E[00:11:30.488] [field_declared_as_function] Line 179: field 'flywheel_abort' declared as a function
E[00:11:30.488] [undeclared_var_use_suggest] Line 348: use of undeclared identifier 'false'; did you mean 'else'?
E[00:11:30.488] [expected_expression] Line 348: expected expression
E[00:11:30.488] [undeclared_var_use] Line 352: use of undeclared identifier 'false'
E[00:11:30.488] [undeclared_var_use] Line 386: use of undeclared identifier 'false'
E[00:11:30.488] [undeclared_var_use] Line 388: use of undeclared identifier 'false'
E[00:11:30.488] [undeclared_var_use] Line 414: use of undeclared identifier 'false'
E[00:11:30.488] [func_returning_array_function] Line 518: function cannot return function type 'bool' (aka 'int (int *)')
E[00:11:30.488] [undeclared_var_use_suggest] Line 520: use of undeclared identifier 'true'; did you mean 'trunc'?
E[00:11:30.488] [-Wint-conversion] Line 520: incompatible pointer to integer conversion returning 'double (double)' from a function with result type 'int'
E[00:11:30.488] [illegal_initializer] Line 525: illegal initializer (only variables can be initialized)
E[00:11:30.488] [undeclared_var_use_suggest] Line 529: use of undeclared identifier 'true'; did you mean 'trunc'?
E[00:11:30.488] [fatal_too_many_errors] Line 1: too many errors emitted, stopping now
I[00:11:30.488] Indexing AST...
I[00:11:30.493] Building inlay hints
I[00:11:30.493] Building semantic highlighting
I[00:11:30.497] Testing features at each token (may be slow in large files)
I[00:11:30.975] Found definition heuristically in index for io_write
I[00:11:30.975] Found definition heuristically in index for io_write
...

I guess this implies the variables in the wrapper script are used wrong? Thanks a lot for your help!

I guess this implies the variables in the wrapper script are used wrong?

My guess is they're right for processing code targeting the host, but the script doesn't consider a cross-compilation scenario like yours.

The documentation for the --query-driver option (https://clangd.llvm.org/design/compile-commands#query-driver) lacks these details, so please correct me if I'm wrong:
clangd should only use the default include paths if the driver is not queried, in case the driver is queried and the set of include paths are different, only the driver include paths should be used and the clangd paths should not, otherwise the include paths are "poisoned" by something completely irrelevant (I think this is the behavior I observed and thus this is working correctly in clangd).
In contrast to this, I would think the above-mentioned env variables (CPATH, C_INCLUDE_PATH, and CPLUS_INCLUDE_PATH) (haven't checked the docs for those) always add the extra paths. Meaning adding these to the NixOS wrapper script is strictly wrong (because if any driver is queried the added paths will poison the includes).

clangd should only use the default include paths if the driver is not queried, in case the driver is queried and the set of include paths are different, only the driver include paths should be used and the clangd paths should not, otherwise the include paths are "poisoned" by something completely irrelevant (I think this is the behavior I observed and thus this is working correctly in clangd).

That matches my understanding.

In contrast to this, I would think the above-mentioned env variables (CPATH, C_INCLUDE_PATH, and CPLUS_INCLUDE_PATH) (haven't checked the docs for those) always add the extra paths. Meaning adding these to the NixOS wrapper script is strictly speaking wrong (because if any driver is queried the added paths will poison the includes).

Yeah, I'm not sure what NixOS is trying to accomplish by doing this. What I've typically seen in other distributions is that they do not try to inject any additional include paths into the compiler's list of default include paths, but rather expose this information in a way such that build systems can pick up these paths and explicitly add them to the compile commands they generate.

Thank you very much for the help, closing the issue.


feat: Workflow tools

@madeindjs You always share some good advice :) Happy to provide more context for these features if necessary.


Fix clicking in gradient editor

When double-clicking on the gradient we should open the colour picker and create a colour key.
Instead, we were also evaluating the click further down producing the colour key to move around.

Bugsquad edit:

Fix #67235

Please amend the commit name to the current PR name (we don't use fix links or numbers in the commit or PR names).

Please amend the commit name to the current PR name (we don't use fix links or numbers in the commit or PR names).

To clarify, it's fine to put "Fixes #67235" in the description of the commit message (and thus in the description of the PR too). We just don't include it in the title (first line) of the commit message, which should be a short explanation of the bug being fixed. So here for example:
Fix clicking in gradient editor

Fixes #67235.

Chaosus added the "Fixes ..." line to the PR description so it's fine as is (the "Fixes" keyword will automatically close the issue when the PR is merged, which is quite convenient).

Thanks! And congrats for your first merged Godot contribution :tada:

Thanks for the help! Hopefully next ones are smoother :)


Issue adding new kernel (stata_kernel)

Hi there, I have followed the documentation for adding a new kernel but not able to get stata_kernel working with the notebook/compute on Azure Machine Learning. Please can you provide an update to the doc with an example? Is it even possible?
Thanks
Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 25d37573-7e5e-f808-2dce-9f5efc25c3bf
Version Independent ID: 08bd729f-fd87-ae90-4ae4-f6f47bc5a2f2
Content: How to run Jupyter Notebooks in your workspace - Azure Machine Learning
Content Source: articles/machine-learning/how-to-run-jupyter-notebooks.md
Service: machine-learning
Sub-service: core
GitHub Login: @AbeOmor
Microsoft Alias: osomorog

@DeanGodfree Thank you for your feedback! We will review and update as appropriate.

@DeanGodfree Thanks for the feedback. Please follow the below doc for adding new kernel in Jupyter notebooks. Please find the snapshot for the same.

We will now proceed to close this thread. If there are further questions regarding this matter, please tag me in your reply. We will gladly continue the discussion and we will reopen the issue.


Roadmap image update request

I tried to edit this document on github, but it turns out the roadmap is an image, rather than editable text.
Request: can we change the roadmap so that the "Sept+" reads "2020" instead?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 3d3c351d-a2e9-9f0b-e8c2-75a2009854e3
Version Independent ID: dd8af514-128a-4d60-07ce-e193415455a7
Content: Azure Marketplace and AppSource Roadmap
Content Source: articles/marketplace/marketplace-roadmap.md
Service: marketplace
GitHub Login: @qianw211
Microsoft Alias: blevens

Thanks for your comment. The feedback has been shared with the content owner for further review. Thanks for your patience.

#please-close this is now resolved!

Hi @qianw211.
It doesn't seem resolve to me as the roadmap table is still embeded in a picture, not editable, not searchable, not accessible, ...
Can you please reopen this issue?

@Benjiiim Hi, could you please let me know the reasons that you want to go in and edit the roadmap table?  Thanks!

For example, to edit "Ongoing through 2019".
But having some text instead of an image would help for other reasons (eg: accessybility for people using screen readers, ability to search for content).

Hi @BrianLevenson and @MarlEva, could you please look into this GitHub issue?  Thanks!

Happy to tackle this, although we're going to need help restructuring this page. I can provide content and information, but I believe you created the page and image, @qianw211
Can we add this to the list of work items so it can be prioritized against the other requests?

@BrianLevenson  please submit doc requests through DocEx program.  Thanks!


Add function: Get-SlackChannel

https://api.slack.com/methods/channels.list
https://api.slack.com/methods/channels.info

Initial implementation complete, closing out!  Still need tests, might need refactor...


Highlighting doesn't appear on termite.

After running wal, when I am selecting text in termite, it works, but there is no way to know what is selected.

Confirmed for mate-terminal and roxterm.
It seems that selected text is turned white (i.e. the corresponding equivalent in the colorscheme), which works as highlighting for every other color, but most text in the terminal is white.

Fixed. Sorry for the delay.


Add an example for multiple Window.on_dropfile

Useful and not mentioned yet thing in the examples. :yum:

Sorry, this does not work for me, on 1.9.0 or master? Is this for a specific OS?

On master, I tested it on Windows, but should work on others too as it basically executes functions from list when on_dropfile is dispatched.

Pity. Seems that does not work on linux (Mint 17.3 KDE).

Does on_dropfile itself work? I don't see a reason why it shouldn't work if the event itself works.

Well, the 'on_dropfile' never fires. The button captions stay the same whatever one drops on them. Looking over the code, that's what should happen?

Exactly what shouldn't happen. On each drop depending on the area where the drop is the appropriate Label should change its text.
As I read the code, the problem might be here depending on your window provider https://github.com/kivy/kivy/blob/master/kivy/core/window/init.py#L1407
Check console with this:
from kivy.app import App
from kivy.uix.button import Button
from kivy.core.window import Window
from kivy.uix.boxlayout import BoxLayout

class DropApp(App):
    def printer(self, *args):
        print(args)

    def build(self):
        Window.bind(on_dropfile=self.printer)
        box = BoxLayout()
        return box
DropApp().run()

Nope, nothing happens.
[INFO   ] [Kivy        ] v1.9.2-dev0
[INFO   ] [Python      ] v2.7.6 (default, Jun 22 2015, 17:58:13)
[GCC 4.8.2]
[INFO   ] [Factory     ] 193 symbols loaded
[INFO   ] [Image       ] Providers: img_tex, img_dds, img_gif, img_sdl2, img_pil (img_ffpyplayer ignored)
[INFO   ] [Text        ] Provider: sdl2

Then it's probably window provider's fault, because it should print all args if the event is dispatched with the check I pasted here. If it's not dispatched, therefore there's an issue probably with getting user's input(or making it available for provider) from the provider.
Are you using different provider than the default one(sdl2)?

No, just SDL2.

works for me, on linux (ubuntu 16.04) with sdl2, with i3wm.

Then I guess it should be fine to merge, maybe with an additional warning saying it's only supported where drop support is working?

Hm, fine then, I'll edit it in a while.


Running multiple Puphpeteer instance in parallel

This is a question more than a bug and could not be sure if that should be under this repo or under rialto-php/rialto
Hello :wave:
When we try to run another instance of puphpeteer, it waits for the previous process to finish to make a new connection. Is it possible to run multiple instances at the same? If so, how? If it's not possible atm, what part of this project needs improvement for that feature? I can try to help you to add that feature in that case.

Hi,
I'm not sure what you are trying to do, for me you want two instaciate the Nesk\Puphpeteer\Puppeteer class multiple times? This is perfectly possible and it works out of the box, check out this script:
<?php

require_once 'vendor/autoload.php';

// First instance
$pu1 = new \Nesk\Puphpeteer\Puppeteer;
$br1 = $pu1->launch(['headless' => false]);

// Second instance
$pu2 = new \Nesk\Puphpeteer\Puppeteer;
$br2 = $pu2->launch(['headless' => false]);

echo shell_exec('ps | grep node');

sleep(10);

Try it, you should see the following output:
36819 ttys005    0:00.15 node<EMAIL_ADDRESS>/absolute/path/to/puphpeteer/src/PuppeteerConnectionDelegate.js {"idle_timeout":60,"log_node_console":false,"log_browser_console":false}
36860 ttys005    0:00.17 node<EMAIL_ADDRESS>/absolute/path/to/puphpeteer/src/PuppeteerConnectionDelegate.js {"idle_timeout":60,"log_node_console":false,"log_browser_console":false}
36878 ttys005    0:00.00 sh -c ps | grep node
36880 ttys005    0:00.00 grep node

We can see we have two node processes running at the same time. Also you should see two browsers opened on your OS (due to ['headless' => false]).

@nesk I wanted to open another issue for this, but seemed a bit related, and it was also a question not an issue, so.
What do you think is the best approach performance-wise, if you're using phphpeteer to generate pdf exports? Isn't it better if we keep a node process running and just use that? Or should we boot a process and close it with each export?

It would be better to keep a process running. Starting a new Node process and a new browser each time you want to generate a PDF is not the best way to optimize things. 😉


ask iteles for s3 keys

@iteles do you have an active AWS Account?

No such luck, mine also got deleted apparently (probably due to inactivity in the last year)

Closed?
As in you aren't going to try and sign up again?

Yes, but I also didn't get past the phone verification https://github.com/nelsonic/stream-to-s3/issues/11#issuecomment-137943434 so you'll get one before me...!

Sounds like we need a brand new bank account and a new "test" mobile phone number for dwyl AWS...

:+1:  That sounds like an issue worth opening...

I've created an AWS Account with ideaQ credit card for now. we can come back to this if/when we get a dwyl bank account. but for now its "sorted" :+1:

:+1: Excellent.


fix: release update

:tada: This PR is included in version 0.0.4-alpha.1 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:

:tada: This PR is included in version 0.0.4 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Make maybeQuote more safe

Hi @acarl005
maybeQuote is used in queries to sanitize strings.
However strings can contain characters like ' and \ which can terminate string literal and inject arbitrary SQL code.
This implementation prevents most easiest attacks on SQL layer.
Note that escaping values in queries manually is always big hazard. It will be better to use placeholders in queries and pass values to database via real arguments protocol channel.
There are better ways to build queries like SQL template tag here which is derived from pg-template-tag

Thanks


IsWindowOnCurrentVirtualDesktop does not work in Windows 1809 April 2019

OS Build 17763.475
VirtualDesktopAccessor has been update to the latest version
> git log -n5
commit a7aa8715d49fd48d66cb235f5217937a05743d49 (HEAD -> master, origin/master, origin/HEAD)
Author: Jari Pennanen<EMAIL_ADDRESS>Date:   Tue Feb 26 00:15:04 2019 +0200

    ...

commit 6f3755ea56fa177d81db24e3c7cd845a2c2b0a60
Author: Jari Pennanen<EMAIL_ADDRESS>Date:   Fri Oct 5 22:19:57 2018 +0300

    further fixes for 1809 (these are not major flaws though)

Test script
#NoEnv

SetTitleMatchMode 2

hVirtualDesktopAccessor := DllCall("LoadLibrary", Str, A_ScriptDir . "\x64\Release\VirtualDesktopAccessor.dll", "Ptr")

global IsWindowOnCurrentVirtualDesktopProc := DllCall("GetProcAddress", Ptr, hVirtualDesktopAccessor, AStr, "IsWindowOnCurrentVirtualDesktop", "Ptr")

IsWindowOnCurrentVirtualDesktop(windowID:=0) {
	return DllCall(IsWindowOnCurrentVirtualDesktopProc, windowID) == 1
}

Run Notepad
Sleep 100
hwnd := WinExist("Notepad")
if (IsWindowOnCurrentVirtualDesktop(hwnd)) {
	MsgBox found: %hwnd%
} else {
	MsgBox not found: %hwnd%
}

Result

The result of IsWindowOnCurrentVirtualDesktopProc is empty (string?) by the way.

It works for me, you have to try it with the Visual Studio project and start Notepad. Then hit Launch.

See these lines:
https://github.com/Ciantic/VirtualDesktopAccessor/blob/master/TestVirtualDesktopAccessorWin32/TestVirtualDesktopAccessorWin32.cpp#L94-L95
They give me result 1:

@char101 Your script is broken, this works:

hVirtualDesktopAccessor := DllCall("LoadLibrary", Str, A_ScriptDir . "\x64\Release\VirtualDesktopAccessor.dll", "Ptr")

IsWindowOnCurrentVirtualDesktopProc := DllCall("GetProcAddress", Ptr, hVirtualDesktopAccessor, AStr, "IsWindowOnCurrentVirtualDesktop", "Ptr")

Run Notepad
Sleep 1000
hwnd := WinExist("ahk_class Notepad")
MsgBox, %IsWindowOnCurrentVirtualDesktopProc%
MsgBox, %hwnd%
bloo := DllCall(IsWindowOnCurrentVirtualDesktopProc, UInt, hwnd, UInt)
MsgBox, %bloo%

Thanks, the problem was that I was using DetectHiddenWindows On and while searching for the windows of an executable, it detects the hidden window as being in the current desktop and tried to activate it. I suspected that the problem was in IsWindowOnCurrentVirtualDesktopProc because I just upgraded to 1809 and there was no problem when runing 1803.

@char101 nope, your script has several problems, for starters it never finds the HWND of a notepad:

Run Notepad
Sleep 100
hwnd := WinExist("Notepad")
MsgBox, %hwnd%

Is simply wrong, it produces always 0x0 which is not a handle to notepad:

Second, your script is using call DllCall(IsWindowOnCurrentVirtualDesktopProc, windowID) which is also totally incorrect to my knowledge, it should be something like DllCall(IsWindowOnCurrentVirtualDesktopProc, UInt, hwnd, Int)

Thanks but I already fixed my script by adding DetectHiddenWindows On.
Also, WinExist("Notepad") works if you add SetTitleMatchMode 2.