Infinite unresponsive loop on debugging any extension

Does this issue occur when all extensions are disabled?: Yes

VS Code Version: 1.74.0
OS Version: Linux mint 21

Steps to Reproduce:

Press F5 to start debugging any vscode extension template (e.g from yo code)
The following message appears in debug console

Could not read source map for file:///usr/share/code/resources/app/out/vs/out-vscode/vs/loader.js: ENOENT: no such file or directory, open '/usr/share/code/resources/app/out/vs/out-vscode/vs/nls.js.map'

This folder out-vscode does not exist
Vscode goes into an infinite cpu cycle and the only way to stop debugging is to kill the process

i'm using this (default) launch.json file to run the extension
{
	"version": "0.2.0",
	"configurations": [
		{
			"name": "Run Extension",
			"type": "extensionHost",
			"request": "launch",
			"args": [
				"--extensionDevelopmentPath=${workspaceFolder}"
			],
		}
	]
}

i think it might be linked to the current working directory when you start code, this infinite loop does not happen when code is started from the startup menu.
however it does happen when you launch code from the terminal or a script

Are there any environment variables set in that environment that are related to node/electron?

the names/count of environment vars is identical both when started from menu and when started from terminal. no variables related to node

How did you determine that, from the terminal? That might have been sanitized or your shell might have overwritten the parent environment. Can you check the environment of vscode's extensionHost process from the outside (I think this is /proc/<pid>/environ or something similar)
Can you also just share the output of printenv in the terminal that you launch from that doesn't work?
And third, can you give the full command line of the process that is not responding, so I know which vscode process it is?

ohh you're right about the environment variables - i was trying that through the shell. ill get back to you in a moment

ok so in this example the process 34467 is out of control and here are the environment variables for this process.

ian@ian-mint:/mnt/e/projects/aasdasd$ cat /proc/34467/environ
ELECTRON_RUN_AS_NODE=1LANGUAGE=en_USUSER=ianroc=/mnt/e/box1/proj/roc-lang/_roc/rocXDG_SEAT=seat0DOTNET_CLI_TELEMETRY_OPTOUT=1XDG_SESSION_TYPE=x11NEMO_SCRIPT_WINDOW_GEOMETRY=1280x1372+2560+0SHLVL=0HOME=/home/ianDESKTOP_SESSION=cinnamonGIO_LAUNCHED_DESKTOP_FILE=/usr/share/applications/nemo.desktopGTK_MODULES=gail:atk-bridgeXDG_SEAT_PATH=/org/freedesktop/DisplayManager/Seat0LC_MONETARY=et_EE.UTF-8DBUS_SESSION_BUS_ADDRESS=unix:path=/run/user/1000/busNEMO_SCRIPT_CURRENT_URI=file:///mnt/e/projects/fable-vscode-demoGIO_LAUNCHED_DESKTOP_FILE_PID=34329NEMO_SCRIPT_NEXT_PANE_SELECTED_FILE_PATHS=INSIDE_NEMO_PYTHON=MANDATORY_PATH=/usr/share/gconf/cinnamon.mandatory.pathQT_QPA_PLATFORMTHEME=qt5ctLOGNAME=ianNEMO_SCRIPT_SELECTED_URIS=XDG_SESSION_CLASS=userDEFAULTS_PATH=/usr/share/gconf/cinnamon.default.pathXDG_SESSION_ID=c2GTK_OVERLAY_SCROLLING=1DOTNET_ROOT=/usr/lib/dotnet/dotnet6-6.0.110GNOME_DESKTOP_SESSION_ID=this-is-deprecatedPATH=/home/ian/.dotnet/tools:/home/ian/bin/:/home/ian/.pack/bin:/mnt/e/box1/proj/fstar-lang/fstar/bin:/home/ian/.local/bin:/home/ian/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/usr/games:/usr/local/games:/snap/bin:/home/ian/.dotnet/tools:/home/ian/.local/share/JetBrains/Toolbox/scriptsGDM_LANG=en_USGTK3_MODULES=xapp-gtk3-moduleSESSION_MANAGER=local/ian-mint:@/tmp/.ICE-unix/1845,unix/ian-mint:/tmp/.ICE-unix/1845XDG_SESSION_PATH=/org/freedesktop/DisplayManager/Session0LC_ADDRESS=et_EE.UTF-8XDG_RUNTIME_DIR=/run/user/1000DISPLAY=:0LANG=en_US.UTF-8DOTNET_BUNDLE_EXTRACT_BASE_DIR=/home/ian/.cache/dotnet_bundle_extractLC_TELEPHONE=et_EE.UTF-8XDG_CURRENT_DESKTOP=X-CinnamonXDG_SESSION_DESKTOP=cinnamonXAUTHORITY=/home/ian/.XauthorityXDG_GREETER_DATA_DIR=/var/lib/lightdm-data/ianSSH_AUTH_SOCK=/run/user/1000/keyring/sshSHELL=/bin/bashLC_NAME=et_EE.UTF-8DOTNET_NEW_PREFERRED_LANG=F#QT_ACCESSIBILITY=1GDMSESSION=cinnamonLC_MEASUREMENT=et_EE.UTF-8NEMO_SCRIPT_SELECTED_FILE_PATHS=GPG_AGENT_INFO=/run/user/1000/gnupg/S.gpg-agent:0:1LC_IDENTIFICATION=et_EE.UTF-8XDG_VTNR=7NEMO_SCRIPT_NEXT_PANE_CURRENT_URI=PWD=/mnt/e/projects/fable-vscode-demoXDG_CONFIG_DIRS=/etc/xdg/xdg-cinnamon:/etc/xdgXDG_DATA_DIRS=/usr/share/cinnamon:/usr/share/gnome:/home/ian/.local/share/flatpak/exports/share:/var/lib/flatpak/exports/share:/usr/local/share:/usr/shareLC_NUMERIC=et_EE.UTF-8LC_PAPER=et_EE.UTF-8NEMO_SCRIPT_NEXT_PANE_SELECTED_URIS=VSCODE_CWD=/mnt/e/projects/fable-vscode-demoVSCODE_CLI=1ELECTRON_NO_ATTACH_CONSOLE=1CHROME_DESKTOP=code-url-handler.desktopORIGINAL_XDG_CURRENT_DESKTOP=X-CinnamonGDK_BACKEND=x11VSCODE_NLS_CONFIG={"locale":"en-us","availableLanguages":{},"_languagePackSupport":true}VSCODE_CODE_CACHE_PATH=/home/ian/.config/Code/CachedData/5235c6bb189b60b01b1f49062f4ffa42384f8c91VSCODE_IPC_HOOK=/run/user/1000/vscode-5f2b04ed-1.74.0-main.sockVSCODE_PID=34348VSCODE_AMD_ENTRYPOINT=vs/workbench/api/node/extensionHostProcessVSCODE_HANDLES_UNCAUGHT_ERRORS=trueVSCODE_EXTHOST_IPC_HOOK=/run/user/1000/vscode-ipc-16ad17c4-4880-49f1-83fa-ee0ebfcbc152.sockNODE_CHANNEL_FD=3NODE_CHANNEL_SERIALIZATION_MODE=json

and as a comparision, when i launch from the start menu it runs fine, has processes like this

and environ has these variables (i guessed the proc id by memory usage and variables)
ian@ian-mint:~$ cat /proc/37132/environ
ELECTRON_RUN_AS_NODE=1GJS_DEBUG_TOPICS=JS ERROR;JS LOGLANGUAGE=en_USUSER=ianroc=/mnt/e/box1/proj/roc-lang/_roc/rocXDG_SEAT=seat0DOTNET_CLI_TELEMETRY_OPTOUT=1XDG_SESSION_TYPE=x11SHLVL=0HOME=/home/ianDESKTOP_SESSION=cinnamonGIO_LAUNCHED_DESKTOP_FILE=/usr/share/applications/code.desktopGTK_MODULES=gail:atk-bridgeXDG_SEAT_PATH=/org/freedesktop/DisplayManager/Seat0LC_MONETARY=et_EE.UTF-8DBUS_SESSION_BUS_ADDRESS=unix:path=/run/user/1000/busCINNAMON_VERSION=5.4.12GIO_LAUNCHED_DESKTOP_FILE_PID=36145MANDATORY_PATH=/usr/share/gconf/cinnamon.mandatory.pathQT_QPA_PLATFORMTHEME=qt5ctLOGNAME=ianXDG_SESSION_CLASS=userDEFAULTS_PATH=/usr/share/gconf/cinnamon.default.pathXDG_SESSION_ID=c2GTK_OVERLAY_SCROLLING=1DOTNET_ROOT=/usr/lib/dotnet/dotnet6-6.0.110GNOME_DESKTOP_SESSION_ID=this-is-deprecatedPATH=/home/ian/.dotnet/tools:/home/ian/bin/:/home/ian/.pack/bin:/mnt/e/box1/proj/fstar-lang/fstar/bin:/home/ian/.local/bin:/home/ian/bin:/home/ian/.cargo/bin:/home/ian/.dotnet/tools:/home/ian/bin/:/home/ian/.pack/bin:/mnt/e/box1/proj/fstar-lang/fstar/bin:/home/ian/.local/bin:/home/ian/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/usr/games:/usr/local/games:/snap/bin:/home/ian/.dotnet/tools:/home/ian/.local/share/JetBrains/Toolbox/scripts:/home/ian/.dotnet/tools:/home/ian/.local/share/JetBrains/Toolbox/scriptsGDM_LANG=en_USGTK3_MODULES=xapp-gtk3-moduleSESSION_MANAGER=local/ian-mint:@/tmp/.ICE-unix/1845,unix/ian-mint:/tmp/.ICE-unix/1845XDG_SESSION_PATH=/org/freedesktop/DisplayManager/Session0LC_ADDRESS=et_EE.UTF-8XDG_RUNTIME_DIR=/run/user/1000DISPLAY=:0LANG=en_US.UTF-8DOTNET_BUNDLE_EXTRACT_BASE_DIR=/home/ian/.cache/dotnet_bundle_extractLC_TELEPHONE=et_EE.UTF-8XDG_CURRENT_DESKTOP=X-CinnamonXDG_SESSION_DESKTOP=cinnamonXAUTHORITY=/home/ian/.XauthorityXDG_GREETER_DATA_DIR=/var/lib/lightdm-data/ianSSH_AUTH_SOCK=/run/user/1000/keyring/sshSHELL=/bin/bashLC_NAME=et_EE.UTF-8DOTNET_NEW_PREFERRED_LANG=F#QT_ACCESSIBILITY=1GDMSESSION=cinnamonLC_MEASUREMENT=et_EE.UTF-8GPG_AGENT_INFO=/run/user/1000/gnupg/S.gpg-agent:0:1LC_IDENTIFICATION=et_EE.UTF-8GJS_DEBUG_OUTPUT=stderrXDG_VTNR=7PWD=/home/ianXDG_CONFIG_DIRS=/etc/xdg/xdg-cinnamon:/etc/xdgXDG_DATA_DIRS=/usr/share/cinnamon:/usr/share/gnome:/home/ian/.local/share/flatpak/exports/share:/var/lib/flatpak/exports/share:/usr/local/share:/usr/shareLC_NUMERIC=et_EE.UTF-8LC_PAPER=et_EE.UTF-8CHROME_DESKTOP=code-url-handler.desktopORIGINAL_XDG_CURRENT_DESKTOP=X-CinnamonVSCODE_CWD=/home/ianGDK_BACKEND=x11VSCODE_NLS_CONFIG={"locale":"en-us","availableLanguages":{},"_languagePackSupport":true}VSCODE_IPC_HOOK=/run/user/1000/vscode-5f2b04ed-1.74.0-main.sockVSCODE_PID=36145LS_COLORS=LESSCLOSE=/usr/bin/lesspipe %s %sLESSOPEN=| /usr/bin/lesspipe %s_=/usr/share/code/codeVSCODE_AMD_ENTRYPOINT=vs/workbench/api/node/extensionHostProcessVSCODE_HANDLES_UNCAUGHT_ERRORS=trueVSCODE_EXTHOST_IPC_HOOK=/run/user/1000/vscode-ipc-69a7b720-7f69-4c3e-94ad-c2ebf452c01a.sockNODE_CHANNEL_FD=3NODE_CHANNEL_SERIALIZATION_MODE=json

Isn't that just showing 6% CPU though? And can you help me figure out which process it is either by giving the full command line (eg from ps) or finding it in the vscode process explorer (Help > Open Process Explorer)

found it,
process 38218 this time

ian@ian-mint:~$ ps 38218
    PID TTY      STAT   TIME COMMAND
  38218 ?        Rl     1:18 /usr/share/code/code --ms-enable-electron-run-as-no

6% implies it is a single threaded javascript process running at 100% capacity, it couldn't go any higher than this

Any guesses @connor4312?

This was https://github.com/microsoft/vscode-js-debug/issues/1469 which should be fixed when you update to 1.74.1


WIP: Contribution changes

Added contribution examples.

@AnaisUrlichs please merge this once satisfied that it's ready.  i've updated to latest by rebasing on master so merging should be a single "squash and merge" click.


access missing api’s

Sorry for asking, but Is there a way through gdnative to access AudioStreamPlayer’s _mix_to_bus, or is it module only?... Or in general: is it possible to access everything in Godot also in gdnative?

No need to be sorry for asking :slightly_smiling_face:
The headers here contain mostly "just the core API", so bindings for Vector2 and Transform and the likes.
There are a few calls needed to call into other things, which are the

godot_get_class_constructor which returns a function to construct an object of that type
godot_global_get_singleton which returns the singleton object (for example Input and Engine)
godot_method_bind_get_method which returns a "binding" to a method of a class. You can use this binding to call the method later on using the following two ways
godot_method_bind_ptrcall calls the method directly via pointer and requires the user to set up an array of parameters which contain pointers to the argument.
godot_method_bind_call calls the method the same way GDScript would, adding in default parameters, converting arguments and other "convenience" things, but this is slower than ptrcall

This is all very low-level, which is why language bindings generally give you a way to auto-generate those calls and "copy" the Godot API using actual classes/types.

or is it module only?

is it possible to access everything in Godot also in gdnative?

GDNative generally only has access to everything that GDScript would have access to as well, it has to go through the ClassDB bindings (one exception is "hardcoded" GDNative extensions, for example for networking or VR)
So in short: most stuff should be accessible, but it's a bit more limited that modules, you have to see for the functionality you need yourself.

Friendly and informative, thanks 👍


Responsive Design

Definitely some design decisions to be made going forward. For the time being, it is fully accessible/functional on mobile screens!


[docs]Translate README into English.

Overview
The README is currently written in Japanese.
In order to connect with more OSS developers,
I see a lot of value in translating the documentation into English.
Task list

[ ] create docs/README_EN.md
[ ] Translate the content of the README into English.

Others
The README file contains a large amount of text.
Therefore, some sections can be cut out as separate issues.

If anyone would like to challenge this Issue, please add a comment!
Thank you for your interest in this issue 🚀.

Can you assign me this

Translated the Readme.md into english and created a new docs/README_EN.md
On Sat, 5 Oct 2024 at 1:11 PM, kazzyfrog @.***> wrote:

Assigned #290
https://github.com/first-contributions-ja/first-contributions-ja.github.io/issues/290
to @RashmitTopG https://github.com/RashmitTopG.
—
Reply to this email directly, view it on GitHub
https://github.com/first-contributions-ja/first-contributions-ja.github.io/issues/290#event-14527138424,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/BG5EYWACOX5KOZWAAPQN3ZDZZ6J4HAVCNFSM6AAAAABPMLNARSVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJUGUZDOMJTHA2DENA
.
You are receiving this because you were assigned.Message ID:
<first-contributions-ja/first-contributions-ja.github.
@.***>

Thanks for your contribution 🥳


Unsure whether variable assignment can reference variables

After reading the documentation, I'm left unsure whether the following is possible:
sauce set env foo='${bar};foo'

I'm not entirely sure what this is supposed to do.
$ sauce set env bar=meow
$ sauce set env foo='${bar}'
$ sauce
$ env | grep foo
foo=meow

seems like the intent behind what you're doing above, but i'm not sure?

so tl;dr, i think the answer is yes, so I'm going to close this? happy to reopen if not


gnutar: 1.32 -> 1.34

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/gnutar/versions.
meta.description for gnutar is: "GNU implementation of the `tar' archiver"
meta.homepage for gnutar is: "https://www.gnu.org/software/tar/"
meta.changelog for gnutar is: ""
Updates performed

Version update

To inspect upstream changes
Impact

Checks done (click to expand)

built on NixOS

The tests defined in passthru.tests, if any, passed

0 of 0 passed binary check by having a zero exit code.

0 of 0 passed binary check by having the new version present in output.

found 1.34 with grep in /nix/store/jbjski1z23v8was266c7278a62697p29-gnutar-1.34

directory tree listing: https://gist.github.com/461cee3d8675edbb6a870f71080b65b7

du listing: https://gist.github.com/cd6852127478a9dd93471671057cbe4a

Rebuild report (if merged into master) (click to expand)

128282 total rebuild path(s)

37811 package rebuild(s)

37413 x86_64-linux rebuild(s)
33083 i686-linux rebuild(s)
25469 x86_64-darwin rebuild(s)
32316 aarch64-linux rebuild(s)

First fifty rebuilds by attrpath

AMB-plugins
AusweisApp2
CoinMP
EBTKS
EmptyEpsilon
FIL-plugins
Fabric
LAStools
LASzip
LASzip2
Literate
MIDIVisualizer
MMA
NSPlist
OSCAR
OVMF
OVMF-CSM
OVMF-secureBoot
PlistCpp
QuadProgpp
R
SDL
SDL2
SDL2_gfx
SDL2_image
SDL2_mixer
SDL2_net
SDL2_ttf
SDL_Pango
SDL_gfx
SDL_gpu
SDL_image
SDL_mixer
SDL_net
SDL_sixel
SDL_sound
SDL_stretch
SDL_ttf
SPAdes
SkypeExport
Sylk
ViennaRNA
Xaw3d
_0verkill
_0x0
_1oom
_1password
_1password-gui
_2048-in-terminal

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/jbjski1z23v8was266c7278a62697p29-gnutar-1.34 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A gnutar https://github.com/r-ryantm/nixpkgs/archive/8a2488d181d2c78c63ab4eef0e3b9555106c3d92.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/jbjski1z23v8was266c7278a62697p29-gnutar-1.34
ls -la /nix/store/jbjski1z23v8was266c7278a62697p29-gnutar-1.34/bin

Pre-merge build results
NixPkgs review skipped

Maintainer pings

https://savannah.gnu.org/bugs/?59897
https://nvd.nist.gov/vuln/detail/CVE-2021-20193


bug(chat): Embedded videos will return error

Issue:
When you send a youtube link in chat and go to play it, the video player will show an error
OS:
All
Screenshot:

still happens

I am going to relinquish this ticket.
I suspect it having something to do with what each individual webview allows OR something to do with the protocol dioxus sets, but I am not sure.
Dioxus sets the protocol to 'dioxus' on mac, but not on windows.
mac:

here is the same thing in windows (thank you @XileHorizon ):

Some videos have this error from the iframe in console:

Since this particular video, https://www.youtube.com/watch?v=w3rQ3328Tok, works embedded on windows, which uses chrome/edge webview, which is not present in safari: https://caniuse.com/mdn-http_headers_content-security-policy_require-trusted-types-for


Use unicode9 character widths

Update runewidth to use unicode9 character width tables. This is the default in vim and neovim now, so should be safe to use in any terminal.
The Condition is no longer calculated using IsEastAsian() as terminals do not use locale to determine how wide to draw ambiguous with characters. Rather, they simply default to 1, and may offer an option to set to 2 (which is discouraged).
Once this repo is updated, when fzf is rebuilt, it will then use unicode9 widths as well.
All tests still pass. The API is very close to the way it was, but not identical. Still, fzf compiles using this version without issue.
A good example is to use fzf ctrl-r when there are emoji in the history. This should fix all rendering issues.

Hi, please send the pull request directly to the upstream (https://github.com/mattn/go-runewidth). The purpose of this fork is only to make fzf unaffected by the changes made in the upstream. (There are of course better ways to manage dependencies in Go project, but anyway that's how I did it.) Once it's merged, I'll update the fork.

This change has been merged upstream. Please update here.

Done. Thanks!


How to change path in include function?

Consider this line in fitting_snap.jl:
include(joinpath(dirname(pathof(LAMMPS)), "..", "examples", "snap.jl"))
In my environment this tries to load from
/home/user/.julia/packages/LAMMPS/zlQdm/...
which I think is my "private" LAMMPS package? According to here.
I would like to load from my current directory instead of /home/user/.julia/... - is there some command or path variable I need to change?
Alternatively, is there a proper Julia way to update /home/user/.julia/packages/LAMMPS/...?

I am on vacation right now, but maybe @jpsamaroo or @emmanuellujan can quickly help.
In the package manager you should be able to say: ]dev LAMMPS and then it should point to your local clone. Or just change the path locally there

Hi!

Download the repository
Open julia in the main folder ./LAMMPS.jl-main
Type: ]dev LAMMPS
Type: include("examples/fitting_snap.jl")

The example runs and produces the following output:
Potential Energy, Fitted Potential Energy, Error (%)
1695.02, 1721.56, 1.57
1716.77, 1625.86, 5.30
1727.48, 1739.46, 0.69
1690.29, 1730.16, 2.36
1709.51, 1766.40, 3.33
1749.57, 1695.72, 3.08
1752.94, 1712.39, 2.31
1765.52, 1670.54, 5.38
1725.46, 1744.22, 1.09
1732.92, 1748.40, 0.89
1687.87, 1692.51, 0.27
1726.56, 1756.36, 1.73
1685.35, 1747.74, 3.70

:)

Thanks guys, this worked. Another question related to this:
If I change the files in ./LAMMPS.jl/..., it doesn't change the files in ~/.julia/dev/LAMMPS/, where the include function in fitting_snap.jl looks.
Are we supposed to keep these two directories the same somehow?

Interesting, based on what you say we can save a step:
$ cd ~/.julia/dev/
$ julia
(@v1.6) pkg> dev LAMMPS
julia> include("LAMMPS/examples/fitting_snap.jl")

and work directly in ~/.julia/dev/LAMMPS


Avoid long running CDDL-test

Move long running test to nightly.

This may be relevant
https://github.com/input-output-hk/iohk-nix/blob/master/docs/start.md#how-to-set-up-scheduled-builds-in-buildkite


PATH_INFO corrupted when SCRIPT_NAME is part of REQUEST_URI

In our nginx/php-fpm setup, we get corrupted PATH_INFO's whenever SCRIPT_NAME (which is "index.php") incidentally occurs in REQUEST_URI. For instance, if I visit /search?q=index.php, PATH_INFO ends up as /=index.php.
This patch fixes the problem without breaking any existing tests:
diff --git a/Slim/Environment.php b/Slim/Environment.php
index a15e1e4..9420f61 100644
--- a/Slim/Environment.php
+++ b/Slim/Environment.php
@@ -132,7 +132,7 @@ class Environment implements \ArrayAccess, \IteratorAggregate
             $queryString = isset($_SERVER['QUERY_STRING']) ? $_SERVER['QUERY_STRING'] : ''; // <-- "test=abc" or ""

             // Physical path
-            if (strpos($requestUri, $scriptName) !== false) {
+            if (strpos($requestUri, $scriptName) === 0) {
                 $physicalPath = $scriptName; // <-- Without rewriting
             } else {
                 $physicalPath = str_replace('\\', '', dirname($scriptName)); // <-- With rewriting

This patch adds a test that verifies that SCRIPT_NAME is only stripped if it's a prefix. The above patch fixes it.
diff --git a/tests/EnvironmentTest.php b/tests/EnvironmentTest.php
index b35405c..4b53e0a 100644
--- a/tests/EnvironmentTest.php
+++ b/tests/EnvironmentTest.php
@@ -116,6 +116,16 @@ class EnvironmentTest extends PHPUnit_Framework_TestCase
         $this->assertEquals('/index.php', $env['SCRIPT_NAME']);
     }

+    public function testThatScriptNameIsNotStrippedIfItOccursInRequestUri()
+    {
+        $_SERVER['SCRIPT_FILENAME'] = '/var/www/index.php';
+        $_SERVER['REQUEST_URI'] = '/bar/xyz?q=index.php';
+        $_SERVER['SCRIPT_NAME'] = 'index.php';
+        $env = \Slim\Environment::getInstance(true);
+        $this->assertEquals('/bar/xyz?q=index.php', $env['PATH_INFO']);
+        $this->assertEquals('.', $env['SCRIPT_NAME']);
+    }
+
     /**
      * Test parses script name and path info
      *

This issue may be related to these others: https://github.com/codeguy/Slim/issues/802 https://github.com/codeguy/Slim/issues/875

Is there a reason for just closing this???? As far as I can see this is still an issue in the 2.x code base or have support been dropped on the 2.x branch??

2.x branch is only taking security fixes at the moment, we are working on releasing 3.x which should fix these sort of issues.


Navbar issues

[ ] The text of the menu option wraps when width gets limited due to the scrollbar i.e. the browser doesn't accommodate width for the scrollbar but instead takes up width of the container/element.

Relevant URLs -
https://stackoverflow.com/questions/5605667/scrollbar-shifts-content
https://stackoverflow.com/questions/1417934/how-to-prevent-scrollbar-from-repositioning-web-page

[ ] In Safari exclusively, the submenu is not visible when the vertical scrollbar is enabled. My understanding is that Safari has some incompatibilities with position:fixed and scollbar. The submenu options are still clickable and inspectable but they are not visible!

Relevant URLs -
https://bugs.webkit.org/show_bug.cgi?id=160953
https://stackoverflow.com/questions/26704903/only-in-safari-positionfixed-child-cut-off-when-parent-is-positionfixed-and/59656203#59656203

This is fixed in safari with the migration to react. The other issue about text wrapping still occurs

Both issues still occur.

Depending on the length of the text, the OS/browser will decide to place the scrollbar inside of the element or outside of the element on the right

This depends on their OS settings like on mac being able to show scrollbars "Based on using a mouse vs trackpad" which will hide most scrollbars until the element is hovered
we can't easily control this and is only a minor inconvenience

solution requires dynamic javascript to calculate element sizes and change CSS styles

the 2nd issue can be resolved by removing the z-index in safari browsers for the "parent" menu

The merged pull request fixes the 2nd bullet from the description above. The first issue will be marked as "won't fix". Closing this issue


gradlew assembleRelease Error on Windows

OS: Windows 7 64-bit
react-native-cli Version: 2.0.1
react-native Version: 0.44.2
npm Version: 4.6.1
react-native-sentry Version: 0.11.6

Open Command Prompt as an Administrator.
react-native init AwesomeProject
cd AwesomeProject
npm install react-native-sentry --save
react-native link react-native-sentry
Answered the questions asked in the Command Prompt.
cd android
gradlew assembleRelease
The following error occurs:

'...\AwesomeProject/node_modules/sentry-cli-binary/bin/sentry-cli' is not recognized as an internal or external command,
operable program or batch file.
:app:bundleReleaseJsAndAssets FAILED
FAILURE: Build failed with an exception.
* Where:
Script '...\AwesomeProject\node_modules\react-native-sentry\sentry.gradle' line: 115
* What went wrong:
Execution failed for task ':app:bundleReleaseJsAndAssetsSentryUpload'.
> Process 'command 'cmd'' finished with non-zero exit value 1

jic, I've described possible solution in #https://github.com/getsentry/react-native-sentry/issues/91

Fixed in 0.12.5


Textinput includes touchableopacity which supersedes parent onpress actions

🐛 Bug Report
When a textinput component is included as a child of touchableopacity, it supersedes the parent's touchableopacity onpress.
In some cases, we want to change the display of a textinput's parent when the textinput is pressed; this goes beyond using onfocus as if the textinput already has focus, the onfocus is correctly not invoked.
As a side note, if I have nested TouchableOpacity elements, even if the child element with TouchableOpacity does not have an onPress, it also supersedes the parent's onPress. Just something interesting to note.
To Reproduce
Nest a textinput component within a touchableopacity component.
The OnPress of the touchableopacity is never called.
In inspecting the TextInput element, this is caused by the fact that textinput is always wrapped in its own TouchableOpacity with OnPress logic.  From what I can tell, this logic is necessary to update the onfocus of the textinput.
Note, this issue was previously reported with https://github.com/facebook/react-native/issues/14958 but that item was closed as stale.
Expected Behavior
Ideally, an OnPress could be added to the textinput component to be invoked prior (or after) setting the onfocus event (of course, with code added above this to pass in the onPress prop as well):
TextInput.js
 _onPress: function(event: Event) {
    if (this.props.editable || this.props.editable === undefined) {
      if (this.props.onPress) {
        this.props.onPress(event);
      }
      this.focus();
    }
  },

Code Example
<TouchableOpacity
            key={item.itemDisplay}
            onPress={() => onRecipientSelect(index)}
          >
            <TextInput
              value={item.itemDisplay}
              style={
                index === selectedRecipient
                  ? styles.chipSelectedStyle
                  : styles.chipStyle
              }
               caretHidden={true}
              spellCheck={false}
              autoCorrect={false}
              onChangeText={onChangeText}
             />
          </TouchableOpacity>

Environment
React Native Environment Info:
    System:
      OS: Windows 10
      CPU: (4) x64 Intel(R) Pentium(R) CPU G4560T @ 2.90GHz
      Memory: 2.03 GB / 7.43 GB
    Binaries:
      Yarn: 1.10.1 - C:\Users\mjfiandaca\AppData\Roaming\npm\yarn.CMD
      npm: 6.4.1 - C:\Program Files\nodejs\npm.CMD
    IDEs:
      Android Studio: Version  <IP_ADDRESS> AI-182.5<IP_ADDRESS>64788
React-native version:  0.57.8

Snack reproducing: https://snack.expo.io/@jkcooper/rn-issue-#23720---text-input-touchable-opacity
I don't think the touch event should necessarily bubble out of the TextInput, but there should probably be a way to fire an event on each press of a text input, not just the focus.

Hello there 👋 this issue seems more of a precise feature request than a bug report. For this reason, we'd prefer for you to post it to Canny so that it can be prioritized against the FR already there (maybe someone already submitted it!).


Fix split cell icon disabled after converting from text to code

This PR addresses https://github.com/microsoft/azuredatastudio/issues/17405
https://user-images.githubusercontent.com/23462877/138150915-75efd94a-f6eb-4c09-9d35-36c2732f4ca3.mov

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 2 (0.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.002%) to 41.48%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/sql/workbench/contrib/notebook/browser/cellToolbarActions.ts
0
2
0.0%

Totals

Change from base Build<PHONE_NUMBER>:
-0.002%

Covered Lines:
26817

Relevant Lines:
58648

💛  - Coveralls

Gotcha, thanks for clarifying!


Add a simple GUI to examples to manage parameters

Windows and Linux compatible
Single option in CMakeLists.txt : SD_EXAMPLES_GLOVE_GUI
Set CLI argument -glove to sd executable
Requires only Qt to be installed
Autosave parameters
The GUI is easily modifiable : does not require GUI knowledge

Add parameters
Order of parameters
Group parameters

Compatible with Qt5 and Qt6
On Windows, depending on Qt installation, some DLLs may not be found:

go to bin/Release or bin/Debug, or wherever is sd.exe
windeployqt.exe .\sd.exe

Related to #262

I think it's better to put this gui in a separate repo, I can add a link to it in the readme.


How can I set multiple index in initialSelection

@dillidon  As question. I need to set multiple initial selection in picker view.
I have used it with 2 pickers so I have 2 values but I can only set selection for 1 column.
How can I set multiple selection. Is it possible?

@oniikal3 Every time you change the picker Action return index (column: Int, row: Int), so you can easily get necessary value using switch:
switch index.column:
case 1:
//...
case 2:
//...

I have achieved this behaviour by editing the class PickerViewViewController  here is my code
this is my implementation of the pickerView

    let pickerViewSelectedValue: [PickerViewViewController.Index] = [(column: 0, row: month-1), (column: 1, row: yearIndex)]
    alert.addPickerView(values: pickerViewValues, initialSelection: pickerViewSelectedValue) { vc, picker, index, values in
        self.month = picker.selectedRow(inComponent: 0)+1
        self.year = Int(years[picker.selectedRow(inComponent: 1)])!
    }

this is the change i have made in PickerViewViewController

blue lines indicates the changes.


Made onxxrutime an optional dependency

Description of changes
Now onxxrutime is used to calculate default embedding. But onxxrutime doesn't support all operation systems (for example it doesn't work with alpine at all)
I think to replace onxxruntime to something else it's a big task, but at least we can allow to run chromadb without default embedding if onxxrutime is not present.
Summarize the changes made by this PR.

Improvements & Bug fixes

Make onxxrutime optional

New functionality

Added initial support of alpine

@tazarov can you take a look here?

Just chiming in in favor of this change - we're running into a problem where we'd like to install onnxruntime-gpu, which provides an alternate implementation of the onnxruntime package, but we can't because the chromadb packages requires onnxruntime unconditionally.

@mangin, you have a point about alpine. Arguably though, there is a build for onnx that runs on musl distros, although the pypi package isn't there, which makes it a tad more difficult to run onnx and therefore Chroma on alpine.
That said, this change can be challenging to merge as it will break DX. Consider this: today you install chroma and doing something like:
collection.add(ids=[...], documents=[...])

just works.
With an optional onnxruntime, users will get an error as optional deps are not installed by default. Which creates a friction for the starting experience.
We're also in the process of transitioning away onnx-based default EF, so that would be a natural point for merging the proposed solution in this PR.
Either way, I think this needs a bit deeper consideration. So give me couple of days to do some experiments.

That said, this change can be challenging to merge as it will break DX. Consider this: today you install chroma and doing something like:
collection.add(ids=[...], documents=[...])

just works.
With an optional onnxruntime, users will get an error as optional deps are not installed by default. Which creates a friction for the starting experience.

Could you instead recommend pip install chromadb[onnx] in your various guides? That would still give the desired UX, and then advanced users can drop the optional requirement when needed.


Change header fields to network order in C Program

Convert all header fields to network order in EBPF C Program.
Handle corresponding arithmetic operations with respect to endianness in parser and control block.

Hi Komal,
We found the following issues:

In the generated code program: https://github.com/p4tc-dev/p4tc-examples-pub/blob/main/routing/routing.p4
When starting to compute the checksum, the compiler tries to shift -96 a hdr->ip, which is a struct:

{
        struct ipv4_t ip_1;
        __builtin_memset((void *) &ip_1, 0, sizeof(struct ipv4_t ));
        u16 chk_state = 0;
{
;
                        ip_1 = (hdr->ip >> -96);
            /* chk.clear() */
            chk_state = 0;

In this same program, the default action processing is in the else statement which will cause a NULL dereference:

                     if (value != NULL) {
                        /* run action */
                        switch (value->action) {
                            case MAIN_FIB_TABLE_ACT_MAIN_SET_NHID:
                                {
                                    nh_index_0 = value->u.Main_set_nhid.index;
                                }
                                break;
                            default:
                                return TC_ACT_SHOT;
                        }
                    } else {
                        nh_index_0 = value->u.Main_set_nhid.index;
                    }

This issue, however, I think you are already working on, so should be fixed when issue (https://github.com/p4tc-dev/p4tc-e2e/issues/40) is resolved.

Whenever we assign any value to a header field, we need to convert the value so that it is in network order.

In cases where the default_action's parameter is constant:

table fib_table {
      key = {
         hdr.ip.dstAddr : lpm @tc_type("ipv4") @name("prefix");
      }
      actions = {
         set_nhid;
      }
      /* 0 is the default route */
      default_action = set_nhid(0);
};

We should assign the parameter's value in the template:
$TC p4template update table/routing/Main/fib_table default_miss_action action routing/Main/set_nhid param index 0

We shouldn't be shifting and masking mac addresses in the parser

hdr->arp_ipv4.sha = (u64)((load_dword_ne(pkt, BYTES(ebpf_packetOffsetInBits)) >> 16) & EBPF_MASK(u64, 48));

It should just either just call load_dword_ne without shifts and masks:
hdr->arp_ipv4.sha = (u64)((load_dword_ne(pkt, BYTES(ebpf_packetOffsetInBits)));

Or simply memcpy. I think we need a rule that says that if the header field is a bit where X is multiple of 8 and different from any of C's integer type size, we should memcpy. We need to think a bit more about this one.

Hi Komal,
We found the following issues:

Whenever we assign any value to a header field, we need to convert the value so that it is in network order.

Can you point testcase for iii) issue?

Something like:
In the P4 program
header ethernet_t {
    EthernetAddress dstAddr;
    EthernetAddress srcAddr;
    bit<16>         etherType;
}

...

action assign_ethertype(bit<16> etherType) {
    hdr.eth.etherType = etherType
}

...

In the eBPF C code:
struct ethernet_t {
    u64 dstAddr; /* EthernetAddress */
    u64 srcAddr; /* EthernetAddress */
    u16 etherType; /* bit<16> */
    u8 ebpf_valid;
};
...

u16 etherType;

...

etherType = <action_parameter_val>;
hdr->eth.etherType = htons(etherType);


AADB2C90079: Clients must send a client_secret when redeeming a confidential grant.

Please provide us with the following information:

This issue is for a: (mark with an x)
- [X] bug report -> please search issues before submitting
- [ ] feature request
- [ ] documentation issue or request
- [ ] regression (a behavior that used to work and stopped in a new release)

Minimal steps to reproduce

Basically, I use the exact same code (with exceptions of the client secret and the application id).
The confidentialClientConfig is the same (again, with my own clientId, authority, etc...)
The getAuthCode function and the endpoints ("/signin", "/redirect", ...) are the same.
The AD B2C configuration is exactly as prescribed.

Any log messages given by the failure

{"errorCode":"invalid_request","errorMessage":"undefined - [undefined]: AADB2C90079: Clients must send a client_secret when redeeming a confidential grant.\r\nCorrelation ID: bfac0c4b-d0c4-423b-9889-7c846145813d\r\nTimestamp: 2022-03-24 16:16:52Z\r\n - Correlation ID: undefined - Trace ID: undefined","subError":"","name":"ServerError"}

Debug console:
[Thu, 24 Mar 2022 16:24:55 GMT] : [00ee5b5f-c32a-458c-9ee3-816c128a767c]<EMAIL_ADDRESS>: Verbose - createAuthority called
[Thu, 24 Mar 2022 16:24:55 GMT] : [00ee5b5f-c32a-458c-9ee3-816c128a767c]<EMAIL_ADDRESS>: Verbose - Auth code client created
[Thu, 24 Mar 2022 16:24:55 GMT] : [00ee5b5f-c32a-458c-9ee3-816c128a767c]<EMAIL_ADDRESS>: Info - in acquireToken call
Expected/desired behavior

I would expect the acquireTokenByCode function to return the access token succesfully.

OS and Version?

Windows 10.

Versions

<EMAIL_ADDRESS>
Mention any other details that might be useful

Thanks! We'll be in touch soon.

Just in case it has any value at all, I use Webpack.

@turbocarte-foodradar
Thank you for your feedback.
Make sure you're using the app secret for the app that you registered. Also ensure the authorities, say for sign in sign up have the correct user-flow in the URL
The app must be a web app (confidential), not a single-page app (SPA).
The web app represented here does not return an access token, only ID token to identify a user, so we're using it to sign in and sign out a user, edit profile and reset password. You won't retrieve an access token from acquireTokenByCode function if no scopes are passed.
If you want to learn how to retrieve an access token, use this repo, it's simple a folder (call-protected-api)) in the repo you used.
Also, make use of the resources.
Please let us know if this is helpful.
Thanks.

Thank you @kengaderdus. The user-flow uri are working nicely. My app is confidential (Express/NodeJS web site running on Nginx, on an Azure VM).
I'll keep searching and I'll post some more details tomorrow if I still have problems.

The "/signin" part works fine:
getAuthCode(b2cPolicies.authorities.signUpSignIn.authority, [], APP_STATES.login, res);
The "/redirect" is called and then, the call to pca.acquireTokenByCode(tokenRequest) fails;
The tokenRequest contains the following (I erased some parts of the code value):
tokenRequest
{redirectUri: 'http://localhost:3000/redirect', authority: 'https://FoodRadarADB2C.b2clogin.com/FoodRad…nmicrosoft.com/B2C_1_FoodRadar_SignupSignIn', code: 'eyJra...xNSIsInZlciI6Ij…gSr4aHIaPQcaY_YjgdYfCs.NenbQRQ7se_fKBi1t2Y7Cg'}
authority:'https://FoodRadarADB2C.b2clogin.com/FoodRadarADB2C.onmicrosoft.com/B2C_1_FoodRadar_SignupSignIn'
code:'eyJra...xNSIsInZlciI6Ij…gSr4aHIaPQcaY_YjgdYfCs.NenbQRQ7se_fKBi1t2Y7Cg'
redirectUri:'http://localhost:3000/redirect'
I also tried adding the client secret as a property of tokenRequest, but it doesn't work either.

Also, confidentialClientConfig does contain the client secret.

Also, I have the same error when I run the user flow from the Azure AD B2C test page.

When I use the sample code with my AD B2C account infos, it works. So it has something to do with my own code. You can close this issue and mark it as resolved ;-)
Thank you very much

I was calling PublicClientApplication instead of ConfidentialClientApplication. Totally my fault. Thank you.

@turbocarte-foodradar
Thanks you for your feedback.


[autoparallel] add following node generator

What is following strategies node
Some nodes like linear or conv generate strategies by the computation rules, and the input arguments have to do shape consistency to join the strategies. However, some nodes like unary elementwise kernel are not expected to change the predecessor ndoe strategy, so their strategy is just following the input's strategy. We call those node as "following strategies node"
What does this PR do

To build following strategies node generator, node is added as an attribute into FollowingStrategyGenerator.
This PR adds handler for operator.getitem. There are mainly three use cases:

args_0._meta_data: torch.Tensor, args_1._meta_data: int
args_0._meta_data: torch.Tensor, args_1._meta_data: slice
args_0._meta_data: Tuple[torch.Tensor], args_1._meta_data: int
All above cases are covered in this PR.

Fix some previous bugs of other handlers.

This PR has a conflicted file, please fix the conflict first.


Make Team Section Responsive

I want to work on this issue

@ZaidKhan2002 Assigning this issue to you. Happy Coding!


Ensure known hosts path is the same as ssh_config

What this PR does / why we need it:
This ensures the create ssh known hosts path shares the same directory as the ssh_config.
This stop an error occurring where a  known_hosts_path was being written to a directory that did not yet exist.
fixes #772
Ensure ssh_known_host file shares the same ssh_config directory.

/assign @simonswine

/lgtm


Vanderbilt SPC error 0.65 - 0.65.5 works on 0.64

Make sure you are running the latest version of Home Assistant before reporting an issue.
You should only file an issue if you found a bug. Feature and enhancement requests should go in the Feature Requests section of our community forum:
**Home Assistant release (hass --version): 0.65.5
**Python release (python3 --version):Python 3.6.0
**Component/platform: Vanderbilt SPC
Description of problem:
same config works in 0.64 but not in 0.65 - 0.65.5
**Expected:
Problem-relevant configuration.yaml entries and steps to reproduce:

spc:
  api_url: http://192.168.***.***:8088/
  ws_url: ws://192.168.***.***:8088/

Traceback (if applicable):

Additional info:
 11:57:01 ERROR (MainThread) [homeassistant.setup] Error during setup of component spc
Traceback (most recent call last):
  File "/usr/local/lib/python3.6/site-packages/homeassistant/setup.py", line 142, in _async_setup_component
    result = await component.async_setup(hass, processed_config)
  File "/usr/local/lib/python3.6/site-packages/homeassistant/components/spc.py", line 64, in async_setup
    areas = yield from api.get_areas()
  File "/usr/local/lib/python3.6/site-packages/homeassistant/components/spc.py", line 180, in get_areas
    return (yield from self._get_data('area'))
  File "/usr/local/lib/python3.6/site-packages/homeassistant/components/spc.py", line 205, in _get_data
    data = yield from self._call_web_gateway(resource)
  File "/usr/local/lib/python3.6/site-packages/homeassistant/components/spc.py", line 226, in _call_web_gateway
    response = yield from action(url)
  File "/usr/local/lib/python3.6/site-packages/aiohttp/client.py", line 207, in _request
    raise RuntimeError('Session is closed')
RuntimeError: Session is closed

Same problem in 0.66
Log Details (ERROR)
Sat Mar 31 2018 07:46:20 GMT+0200 (Västeuropa, sommartid)
Error during setup of component spc
Traceback (most recent call last):
File "/usr/local/lib/python3.6/site-packages/homeassistant/setup.py", line 142, in _async_setup_component
result = await component.async_setup(hass, processed_config)
File "/usr/local/lib/python3.6/site-packages/homeassistant/components/spc.py", line 64, in async_setup
areas = yield from api.get_areas()
File "/usr/local/lib/python3.6/site-packages/homeassistant/components/spc.py", line 180, in get_areas
return (yield from self._get_data('area'))
File "/usr/local/lib/python3.6/site-packages/homeassistant/components/spc.py", line 200, in _get_data
data = yield from self._call_web_gateway(resource)
File "/usr/local/lib/python3.6/site-packages/homeassistant/components/spc.py", line 221, in _call_web_gateway
response = yield from action(url)
File "/usr/local/lib/python3.6/site-packages/aiohttp/client.py", line 207, in _request
raise RuntimeError('Session is closed')
RuntimeError: Session is closed

Same here, I temporarily fix this by using a older version (db56748) of the spc.py file, seems to work for now

I got the same kind of errors in several components (deconz, yr) when I tried out 0.66. Something related to new version of the aiohttp library perhaps?

Still broken in 0.69.1

still broken in 0.71

Still broke in 0.73

Tell me if I can help in any way

The new update works for me with Home Assistant
0.75.2    :-) :-)
:+1:

on 0.76.2 and not working for me.
Still have to use the temporary fix.
`2018-08-28 16:35:22 INFO (MainThread) [homeassistant.setup] Setting up spc
2018-08-28 16:35:22 ERROR (MainThread) [homeassistant.setup] Error during setup of component spc
Traceback (most recent call last):
File "/usr/src/app/homeassistant/setup.py", line 145, in _async_setup_component
hass, processed_config)
File "/usr/src/app/homeassistant/components/spc.py", line 64, in async_setup
areas = yield from api.get_areas()
File "/usr/src/app/homeassistant/components/spc.py", line 180, in get_areas
return (yield from self._get_data('area'))
File "/usr/src/app/homeassistant/components/spc.py", line 200, in _get_data
data = yield from self._call_web_gateway(resource)
File "/usr/src/app/homeassistant/components/spc.py", line 221, in _call_web_gateway
response = yield from action(url)
File "/usr/local/lib/python3.6/site-packages/aiohttp/client.py", line 250, in _request
raise RuntimeError('Session is closed')
RuntimeError: Session is closed
2018-08-28 16:35:22 INFO (MainThread) [homeassistant.core] Bus:Handling <Event call_service[L]: domain=persistent_notification, service=create, service_data=title=Invalid config, message=The following components and platforms could not be set up:

spc
`

@fergalom I can't reproduce your problem on 0.76.2 Docker I'm afraid. Looks like you're using the old code.

New update doesnt work for me either. Getting the same error. Do you need to download a beta version? When I add ”:latest” tag to the docker build it doesnt work.

@mbrrg ok I don't get it. I always run ":latest" docker image, just tried "0.77.3" tag and also "dev" tag.
Same result as logs above

The changes haven't been merged into any beta/release version of Home Assistant yet. @RMarjanovic @fergalom


cleanups for demo for tutorial

Unfortunately, I was not able to push my cleanup changes to https://github.com/ros-planning/moveit_task_constructor/pull/104 directly. For this reason, I file them here.
@henningkayser, please have a look and merge them. With those changes, I approve https://github.com/ros-planning/moveit_task_constructor/pull/104.

Ping @henningkayser.


Idea: Live editor for pages and posts/custom content.

In generate --watch --server mode it might be helpful to have some way of editing the site within the browser. Particularly if it could handle errors more gently than Sculpin currently does, in case a typo causes a crash and leaves the web browser disconnected.

A minimum initial implementation of this would be to do a "live reload" instead of full live editing. This was first suggested in issue https://github.com/sculpin/sculpin/issues/217

Closing due to some progress in #443


[react-router] Upgrade to<EMAIL_ADDRESS>

Depends on https://github.com/rackt/react-router/pull/590

Can we have an example with react-router beta?

Agreed, we should update our example to react-router 1.0. We will try to get to it soon.

Hopefully this helps someone else: see #153

react-router 1.0 will have support for using a route store with HOCs, and I think they're killing willTransitionTo. Once that's working and you can take a similar approach to fluxible-router, handling actions can be left up to the user.
As an example of what can be achieved right now with react-router v1.0.0-beta3, check out redux-react-router.
There's a good discussion about it here.

Makes sense. I will change this issue to upgrading to react-router 1.0

How would we do a data fetch before render with the new react-router?

This has changed in the latest version of react router v1.0. For example, Router.run is no longer available.

@pheuter im gonna put an example up in the next few days

@mmahalwy sweet! ping when u do

@mmahalwy any progress?

I been hacking through this for a while:
https://github.com/mmahalwy/react-fluxible-starter
I am not very content with it just yet, the reason being I really dislike the way I have to do the hook for async data before rendering from the server. See: https://github.com/mmahalwy/react-fluxible-starter/blob/master/server.js#L29
If anyone has better suggestions I am game

<EMAIL_ADDRESS>has dropped: https://github.com/rackt/react-router/blob/master/CHANGES.md#v100

Anyone working on this ?

@sfarthin you can look at my starter, which i havent maintained for a while but it'd help as a guiding stick: https://github.com/mmahalwy/react-fluxible-starter you should use https://github.com/rackt/async-props instead of RoutingContext

Closing old issues. Please re-open in the yahoo/fluxible repo if needed.


Add logs instructions to currencyservice

The following PR adds logs to CurrencyService (c++):
https://github.com/open-telemetry/opentelemetry-demo/pull/1378
This PR updates the logs section of this service.
I also updated the metrics section which was outdated.

Should be good to go!
Demo PR got merged


fix: send proposal schema

send-proposal doesn't have connection_id in the schema, which is inconvenient for generated clients

Codecov Report

Merging #1377 (9a4967b) into main (99093a7) will increase coverage by 0.00%.
The diff coverage is 100.00%.

:exclamation: Current head 9a4967b differs from pull request most recent head a98ddf8. Consider uploading reports for the commit a98ddf8 to get more accurate results

@@           Coverage Diff           @@
##             main    #1377   +/-   ##
=======================================
  Coverage   95.40%   95.40%
=======================================
  Files         476      476
  Lines       28980    28969   -11
=======================================
- Hits        27648    27639    -9
+ Misses       1332     1330    -2

@ianco @shaangill025 -- could one or both of you please take a look? Timo's asked this be added sooner than later.
Thanks


ZH-trans: add /kubeadm/generated/...

zh-trans: add kubeadm/generated/...
File directory

/assign @lucperkins

/assign @chenopis

@xichengliudui for chinese content, you dont have to assign outside Chinese i18n team, you can cross post PR review request into wechat group discussions if needed, thanks!

/assign

I might just have to suggest that we probably dont need to translate --attribute string to something like --attribute 字符串 due to the type explicitness

@tengqm ,修改完毕，感谢提出的意见。

/approve

/lgtm

/approve


Make Jenkins deploy to PyPI

According to the documentation, "pip install" takes a --pre flag which causes it to use the latest pre-release aka unstable aka .dev build.  We will have to see if that works.


Invalid object name for simple SQL queries

I've posted my issue on SO - https://stackoverflow.com/questions/53877942/sqlkata-simple-select-query-returning-invalid-object-name-for-legitimate-table
But here it is: (This is querying against SQL Server 2016)
Has anyone used the SqlKata library and had issues doing even a simple SELECT * FROM TABLE? I've tried both the standard GET (which produces a query that has the table in [], and the GetRaw which produces the query without the []).
Both queries return invalid object name for a clearly available table? My application records the following in logs:
[Error] SELECT * FROM InSiteStoreInfo
[Error] Invalid object name 'InSiteStoreInfo'.
The example code I'm using is below (I've tried the non-raw version of Get as well).
public async Task GetQueryKata(APIGatewayProxyRequest request, ILambdaContext context)
{
LogLevel environmentLogLevel = (LogLevel)Convert.ToInt32(Environment.GetEnvironmentVariable("LOG_LEVEL"));
string jsonOutput = null;
APIGatewayProxyResponse proxyResponse = new APIGatewayProxyResponse();
    try
    {
        using (var connection = new SqlConnection(
            await RetrieveParameterStoreValue(ParameterStoreStrings.Database, true, context, environmentLogLevel)))
        {

            var db = new QueryFactory(connection, new SqlServerCompiler());

            // Log the compiled query to the console
            db.Logger = compiled => {
               CreateCloudWatchLog(compiled.ToString(),context,LogLevel.Error,environmentLogLevel);
            };

            var results = db.Query().FromRaw("InSiteStoreInfo").Get();
            CreateCloudWatchLog(JsonConvert.SerializeObject(results, Formatting.Indented),context, LogLevel.Error,environmentLogLevel);
            jsonOutput = JsonConvert.SerializeObject(results, Formatting.Indented);
        }

        proxyResponse = await BuildResponse(jsonOutput, HttpStatusCode.OK, context, environmentLogLevel);
    }
    catch (Exception ex)
    {
        CreateCloudWatchLog(ex.Message, context, LogLevel.Error, environmentLogLevel);
        proxyResponse = await BuildResponse(ex.Message, HttpStatusCode.BadRequest, context, environmentLogLevel);
    }

    return proxyResponse;
}

@kknd4eva
I'm going to probably say that if you are getting the invalid object error and you are sure the table exists--that the result of the method call RetrieveParameterStoreValue is not opening your SqlConnection to the correct catalog.
To help troubleshoot, I would likely start by assigning the result from RetrieveParameterStoreValue to a discrete variable, using that variable to create the sql connection and then setting a break-point just inside the using block which you create the connection to ensure that everything is correct.

The table definitely exists. RetrieveParameterStoreValue simply points to a connection string for SQL server, the initial database of which is the right one to reference to include this table. That's what is so perplexing.  I will try as you suggest however, and provide the results. (Will just need to hide the password etc)

The reason I know the connection string etc is fine, is that I am already working with the same connection string, table etc in this application without SqlKata (this is a web API that interacts with a SQL DB). I have created just one method to trial SqlKata and - if I like it - port the whole API across to it. So I am fairly certain the DB connection string, connectivity etc is OK, as it works elsewhere where SqlKata is not being used as the query engine (instead I'm just using standard .NET objects).

as @ceastwood said, make sure you are connecting to the right server/db, the error is coming from SqlServer and nothing to do here with SqlKata.

Could you share a project that replicate the error ?

@kknd4eva
Could you please confirm the version of SqlKata & Execution packages that you have installed also?
I dont think we are trying to say has to be only that error, but your query is very simple and I can say that I use the SqlKata portion of this project in production on Sql2012, 2014, 2016 and a staging server of 2017, and it feels to me like your query is getting executed in the wrong catalog.
If you can help us repro the issue outside of your total solution (since you might not be able to share it with us), we definitely want to take a look.

Hi guys, thanks for taking a look into this. I can't share the project unfortunately as it's for work, but I am happy to do anything else required.  Here is some more info.
Versions:
SqlKata - 1.1.3
SqlKata.Execution - 1.1.3
System.Data.SqlClient - 4.5.1
SYstem.Data.Common - 4.3.0
The project is an AWS API Gateway (so Lambda functions via HTTPS). I have created one single method using SqlKata to test alongside existing methods that use native .NET libraries to query the database.
Here is the connection string in use. I have edited out some details.
Data Source=cloudcapture-dev-db.xxxxxxxxxxx.ap-southeast-2.rds.amazonaws.com,1433;Initial Catalog=API;user id=;password=;Max Pool Size=10000
And here using SQL Management Studio you can see the table I'm referencing exists:

Yet running the method using SqlKata returns:
START RequestId: 0f8339dc-064c-11e9-91c3-7df7d79dba8e Version: $LATEST
[Error] SELECT * FROM InSiteStoreInfo
[Error] Invalid object name 'InSiteStoreInfo'.
END RequestId: 0f8339dc-064c-11e9-91c3-7df7d79dba8e
Interestingly, you are correct that it does not appear to be an issue with SqlKata, at least not at the moment, as my own native .NET method which was working a couple of days ago, is also not working and producing the same error!
[Information] SELECT * FROM InSiteStoreInfo WITH (NOLOCK)
[Error] Invalid object name 'InSiteStoreInfo'.
I will look into this, clearly something else has broken here. Thank you for your help thus far and many apologies for hassling you!


Your main algorithm may not be that accurate than it is showing

I have seen your algorithm for studying purposes but found that it is not accurate.But coincidentally it showin above 95% accuracy.In the fucntion of the bot_prediction_algorithm() prediction_df is not sorted according to the indexes of the rows,while the train_df is by sequence indexing of the rows.So while finding the accuracy it is coincidentally showing above 95%.When I sorted the prdeiction_df it is showing aroung 69 % of the accuracy.Correct me if I am wrong

@R30B yeah, I tried the same thing and I got an accuracy of 70%, I guess for the sake of completing their project they have changed the prediction part of the project.


Typo on Terraform AVD Session Host deployment

The code in the main.tf file at https://learn.microsoft.com/en-us/azure/developer/terraform/create-avd-session-host fails at the line that says:
private_ip_address_allocation = "dynamic"

It should be updated to
private_ip_address_allocation = "Dynamic"

The values are case-sensitive.

Thanks @dpantaz. I'll get this corrected.

Unfortunately, we have not been able to review this issue in a timely manner. We sincerely apologize for the delayed response. We are closing this issue. If you feel that the problem persists, please respond to this issue with any additional information.
Please continue to provide feedback about the documentation. We appreciate your contributions to our community.
#please-close


Switch configuration management to viper or koanf

Not sure about this anymore. Does this really need advanced configuration apart from what it has now?
Environment vars could be fun if we want to do this in a container.


Face Editing UI Refresh

I've almost never used github before so I hope this is the right spot to put this.
The face editing UI is pretty disorganized so I took a stab at fixing it up.

I made the material preview be hidden by default. It takes up space and is pretty redundant in my opinion because you can see the material in the selection dialogue and also on the brush itself. But I didn't want to completely remove it.

I'm not too sure what to do with the code because I don't know github. It may be worth mentioning that I did Format Document in visual studio (it's just habit, I do it almost as much as ctrl+s) which I think changed spaces to tabs so a lot of lines of code were changed but I didn't actually do anything to them. I'm not sure what should be done about that.
Drop any suggestions too that I could try implementing

Usually you make a Pull Request. If you are using Sourcetree I can show you the steps it's not very difficult. Looking good so far! It's something I have been wanting to clean up as well. I was considering using icons to reduce he amount of text (especially on things like the selection helpers) but they may not be nearly as obvious.
I actually wanted to rewrite most tools sooner or later into a system that's more extendable because now any new feature that needs another button is going to make the user interface too big for small screens. If you have any suggestions for a completely new interface in general feel free to let us know as well.

I actually don't use any source control lol, maybe it's possible to do the pull request on the site?
Regarding icons, I think they would just reduce clarity like you said especially if the icons were made small to further reduce the area. Keeping things as text is very clear about what the buttons do and they don't take up too much more space either. Probuilder I think suffers from this, where all their stuff is icons and there's no tooltips (at least that I was aware of) so I couldn't figure out how to use it.
As for suggestions on the interface. What if some of the toolbars were broken out into a dockable window similar to what Probuilder does? That way the UI isn't limited in size by the scene view window. Also under the UV tools, I don't know what the planar buttons do, it's not clear and I can't tell from trying them. The rotate and scale buttons also are misleading as they rotate/scale the texture by the amount in the text box but the expected behavior is to set the rotation/scale to what's in the text box. I don't trust myself to go digging too deep into the code to try and change that though.


Tissot indicatrix

colors on a mesh maybe?  or deformations using decomposed circles (probably better).

As it turns out, a proper Tissot indicator should really be done using great circle calculations.  There's a new example in #207 which shows how you can use Proj.jl's new geodesic API for this purpose.
Still waiting on antimeridian cutting which should come with GeometryOps.jl fairly soon!


Livewire Service Provider

@drewroberts that appeared to do the trick here including Locations when I tested locally. This likely means that any existing package using Livewire will need this if they do not have it already in their test cases.


Enable refresh materialized views with atomic swap

Add an option to refresh materialized views with an atomic swap. When the refresh starts, it would create a new materialized view (with some temp name), and when it is created, it would run an atomic deletion of the old materialized view, and renaming of the new view to the correct name.
This could reduce the number of vacuums PostgreSQL is doing. It may also allow the view to be created without using the concurrent flag, which should be faster.

This would be a great feature, especially for larger materialized views.


Problem with starting

I followed the README, but something is not working for me. Does base.yaml have to be online or offline? I have offline and I have problems with it, and I have not changed anything in it (attachment - variables). The current temperature is shown to me from time to time.
Do you have any tips for me?
THX
logs_klimasalon_logs.txt
logs_klimasalon_validate.txt
logs_base_logs.txt
logs_base_validate.txt
I am attaching log files.

I see a lot of "line busy, not sending yet" messages in your first log file. This is probably a hardware issue. It means the controller isn't sending anything to the AC (and then also not receiving anything) because it thinks the other side is sending.

ok I understand, I'll take a closer look at the board, maybe I'll find something.
And what can you tell me about the base file, should it be displayed as offline in ESPhome (like it is in my case)?

And what can you tell me about the base file, should it be displayed as offline in ESPhome (like it is in my case)?

I've never seen this but I also don't use the ESPHome dashboard. It's probably fine to ignore.

The ESPHome dashboard just lists every .yaml file; I renamed base.yaml to base.include so that it wouldn't show up in the dashboard.

I just found a mistake, there was a missing contact on the tranceiver's 3.3V power supply, because I'm currently working on a breadboard.

@kchen good idea to hide the base, I'll try it on mine - thanks!


ValueError: The condensed distance matrix must contain only finite values.

<<Please describe the issue in detail here, and for bug reports fill in the fields below.>>
I am trying to run CMT tracking code and continuously getting raiseValue error.
Reproducing code example:
<<A short code example that reproduces the problem. It should be self-contained, i.e., possible to run as-is via 'python myproblem.py'>>

Error message:
<<Full error message, if any (starting from line Traceback: ...)>>
 linkage = scipy.cluster.hierarchy.linkage(pdist)
  File "/home/shuchita/.virtualenvs/cv3/lib/python3.5/site-packages/scipy/cluster/hierarchy.py", line 713, in linkage
    raise ValueError("The condensed distance matrix must contain only "
ValueError: The condensed distance matrix must contain only finite values.

Scipy/Numpy/Python version information:
Version - 1.0.1

not a bug, something is wrong with the inputs to the function.
if you're really convinced it's a bug, please provide a reproducible example


Add Ashutosh Singh to Contributors list

this is my first pull request
it has been overcome my biggest fear
thank you @Roshanjossey

@ashubly25, I'm quite elated about your PR. I wanna evolve this project to addresses various problems faced by first-time contributors. I'd love to learn about your journey in open source community, the problems, pain points you had etc.
Could you explain how you felt when you went through the tutorial, made a PR and learned that I merged it?
We’ve added a tweet feature to our web app recently. Can you please go to https://roshanjossey.github.io/first-contributions/#social-share and share your first contribution to open source?
Also, check out projects with easy issues while you’re there.

sure thanks a lot helping me out in my biggest fear and happy diwali

@ashubly25, happy Diwali.
I’d urge you to continue contributing to other open source projects.
We also have a slack team to help/mentor people trying to contribute to open source projects.
You can join the team by going to https://firstcontributions.herokuapp.com

:heart:


Visibility animation of BottomNavigationBar(Android) is somehow not so UI Friendly.

A difference in the visibility animation of StatusBar and BottomNavigationBar is perceptible.
All I did was
 onTap:(){
        makeItFullScreen
            ? SystemChrome.setEnabledSystemUIOverlays([])
            : SystemChrome.setEnabledSystemUIOverlays(
               [SystemUiOverlay.bottom, SystemUiOverlay.top]);
        makeItFullScreen = !makeItFullScreen;
    }

The flickering of that particular part(bottom) of the screen needs to be fixed I guess.
I tested this on emulator and an actual device.
Most of us might not have noticed this because we usually use the default(white) background of our Scaffold.

Flutter Doctor Logs:
[✓] Flutter (Channel dev, v0.7.2, on Linux, locale en_US.UTF-8)
    • Flutter version 0.7.2 at /home/daksh/flutter
    • Framework revision f8a2fc7c28 (3 days ago), 2018-08-27 20:58:30 +0200
    • Engine revision af42b6dc95
    • Dart version 2.1.0-dev.1.0.flutter-ccb16f7282

[✓] Android toolchain - develop for Android devices (Android SDK 27.0.3)
    • Android SDK at /home/daksh/Android/Sdk
    • Android NDK location not configured (optional; useful for native profiling support)
    • Platform android-27, build-tools 27.0.3
    • ANDROID_HOME = /home/daksh/Android/Sdk
    • Java binary at: /home/daksh/android-studio/jre/bin/java
    • Java version OpenJDK Runtime Environment (build 1.8.0_152-release-1024-b01)
    • All Android licenses accepted.

[✓] Android Studio (version 3.1)
    • Android Studio at /home/daksh/android-studio
    • Flutter plugin version 25.0.1
    • Dart plugin version 173.4700
    • Java version OpenJDK Runtime Environment (build 1.8.0_152-release-1024-b01)

[✓] IntelliJ IDEA Community Edition (version 2018.1)
    • IntelliJ at /home/daksh/Downloads/idea-IC-181.5281.24
    • Flutter plugin version 25.0.2
    • Dart plugin version 181.4892.1

[✓] VS Code (version 1.26.1)
    • VS Code at /usr/share/code
    • Flutter extension version 2.17.1

[✓] Connected devices (1 available)
    • Android SDK built for x86 • emulator-5554 • android-x86 • Android 8.1.0 (API 27) (emulator)

• No issues found!

Cross-link https://stackoverflow.com/questions/52095813/visibility-animation-of-bottomnavigationbarandroid-is-somehow-not-so-ui-friend

Please add the output of flutter doctor -v.

@zoechi  I was editing my comment before you posted your's :p

Same problem. Fade out ok, fade in of bottom bar -> annoying white flash.

Same problem here, any update on this?

Issue still exist
import 'package:flutter/material.dart';
import 'package:flutter/services.dart';

void main() => runApp(MyApp());

class MyApp extends StatelessWidget {
  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      debugShowCheckedModeBanner: false,
      title: 'Material App',
      theme: ThemeData.dark(),
      home: Home(),
    );
  }
}

class Home extends StatefulWidget {
  @override
  _HomeState createState() => _HomeState();
}

class _HomeState extends State<Home> {
  bool makeItFullScreen = false;

  @override
  Widget build(BuildContext context) {
    return Scaffold(
      appBar: AppBar(
        title: Text('Material App Bar'),
      ),
      body: Center(
        child: Container(
          child: Text('Hello World'),
        ),
      ),
      floatingActionButton: FloatingActionButton(
          child: Icon(Icons.add),
          onPressed: () {
            makeItFullScreen
                ? SystemChrome.setEnabledSystemUIOverlays([])
                : SystemChrome.setEnabledSystemUIOverlays(
                    [SystemUiOverlay.bottom, SystemUiOverlay.top]);
            makeItFullScreen = !makeItFullScreen;
          }),
    );
  }
}

flutter doctor -v
[✓] Flutter (Channel dev, v1.18.0-6.0.pre, on Mac OS X 10.15.4 19E287, locale
    en-GB)
    • Flutter version 1.18.0-6.0.pre at /Users/taha/Code/flutter_dev
    • Framework revision 84c84fb249 (31 hours ago), 2020-04-20 21:35:01 -0400
    • Engine revision 2bde4f0ae4
    • Dart version 2.9.0 (build 2.9.0-1.0.dev a12c36dd97)

[✓] Android toolchain - develop for Android devices (Android SDK version 29.0.3)
    • Android SDK at /Users/taha/Code/sdk
    • Platform android-29, build-tools 29.0.3
    • ANDROID_HOME = /Users/taha/Code/sdk
    • Java binary at: /Applications/Android
      Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build
      1.8.0_212-release-1586-b4-5784211)
    • All Android licenses accepted.
[✓] Xcode - develop for iOS and macOS (Xcode 11.4.1)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 11.4.1, Build version 11E503a
    • CocoaPods version 1.9.1
[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome
[✓] Android Studio (version 3.6)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin version 45.1.1
    • Dart plugin version 192.7761
    • Java version OpenJDK Runtime Environment (build
      1.8.0_212-release-1586-b4-5784211)
[✓] VS Code (version 1.44.2)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.9.1
[✓] Connected device (4 available)
    • SM M305F   • 32003c30dc19668f • android-arm64  • Android 10 (API 29)
    • macOS      • macOS            • darwin-x64     • Mac OS X 10.15.4 19E287
    • Chrome     • chrome           • web-javascript • Google Chrome
      81.0.4044.113
    • Web Server • web-server       • web-javascript • Flutter Tools
• No issues found!

Issue is reproducible on latest stable and master.
https://user-images.githubusercontent.com/67046386/104444836-539edf00-55be-11eb-9b0a-feaea3da5cba.mov

stable and master flutter doctor -v
[✓] Flutter (Channel stable, 1.22.5, on Mac OS X 10.15.4 19E2269 darwin-x64,
    locale en-IN)
    • Flutter version 1.22.5 at /Users/dhs/documents/Fluttersdk/flutter
    • Framework revision<PHONE_NUMBER> (5 weeks ago), 2020-12-10 11:54:40 -0800
    • Engine revision ae90085a84
    • Dart version 2.10.4

[✓] Android toolchain - develop for Android devices (Android SDK version 30.0.0)
    • Android SDK at /Users/dhs/Library/Android/sdk
    • Platform android-30, build-tools 30.0.0
    • Java binary at: /Applications/Android
      Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build
      1.8.0_242-release-1644-b3-6915495)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 12.0.1)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 12.0.1, Build version 12A7300
    • CocoaPods version 1.9.3

[!] Android Studio (version 4.1)
    • Android Studio at /Applications/Android Studio.app/Contents
    ✗ Flutter plugin not installed; this adds Flutter specific functionality.
    ✗ Dart plugin not installed; this adds Dart specific functionality.
    • Java version OpenJDK Runtime Environment (build
      1.8.0_242-release-1644-b3-6915495)

[✓] VS Code (version 1.52.1)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.16.0

[✓] Connected device (3 available)
    • sdk gphone x86 64 arm64 (mobile)    • emulator-5554
      • android-x64 • Android 11 (API 30) (emulator)
    • Darshan's iphone (mobile)           •
      21150b119064aecc249dfcfe05e259197461ce23 • ios         • iOS 14.2
    • iPhone SE (2nd generation) (mobile) • 6C85835D-FBFD-4AB3-8DE8-B4FAD35E5367
      • ios         • com.apple.CoreSimulator.SimRuntime.iOS-14-0 (simulator)

! Doctor found issues in 1 category.

[✓] Flutter (Channel master, 1.26.0-2.0.pre.312, on Mac OS X 10.15.4 19E2269
    darwin-x64, locale en-IN)
    • Flutter version 1.26.0-2.0.pre.312 at
      /Users/dhs/documents/Fluttersdk/flutter
    • Framework revision 7c75c01fc3 (8 hours ago), 2021-01-12 19:01:18 -0800
    • Engine revision 10cee6abcb
    • Dart version 2.12.0 (build 2.12.0-214.0.dev)

[✓] Android toolchain - develop for Android devices (Android SDK version 30.0.0)
    • Android SDK at /Users/dhs/Library/Android/sdk
    • Platform android-30, build-tools 30.0.0
    • Java binary at: /Applications/Android
      Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build
      1.8.0_242-release-1644-b3-6915495)
    • All Android licenses accepted.

[!] Xcode - develop for iOS and macOS
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 12.0.1, Build version 12A7300
    ! CocoaPods 1.9.3 out of date (1.10.0 is recommended).
        CocoaPods is used to retrieve the iOS and macOS platform side's plugin
        code that responds to your plugin usage on the Dart side.
        Without CocoaPods, plugins will not work on iOS or macOS.
        For more info, see https://flutter.dev/platform-plugins
      To upgrade see
      https://guides.cocoapods.org/using/getting-started.html#installation for
      instructions.

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 4.1)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build
      1.8.0_242-release-1644-b3-6915495)

[✓] VS Code (version 1.52.1)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.16.0

[✓] Connected device (5 available)
    • sdk gphone x86 64 arm64 (mobile)    • emulator-5554
      • android-x64    • Android 11 (API 30) (emulator)
    • Darshan's iphone (mobile)           •
      21150b119064aecc249dfcfe05e259197461ce23 • ios            • iOS 14.2
    • iPhone SE (2nd generation) (mobile) • 6C85835D-FBFD-4AB3-8DE8-B4FAD35E5367
      • ios            • com.apple.CoreSimulator.SimRuntime.iOS-14-0 (simulator)
    • macOS (desktop)                     • macos
      • darwin-x64     • Mac OS X 10.15.4 19E2269 darwin-x64
    • Chrome (web)                        • chrome
      • web-javascript • Google Chrome 87.0.4280.141

! Doctor found issues in 1 category.

Issue is reproducible on latest stable and master.
https://user-images.githubusercontent.com/67046386/104444836-539edf00-55be-11eb-9b0a-feaea3da5cba.mov

stable and master flutter doctor -v
[✓] Flutter (Channel stable, 1.22.5, on Mac OS X 10.15.4 19E2269 darwin-x64,
    locale en-IN)
    • Flutter version 1.22.5 at /Users/dhs/documents/Fluttersdk/flutter
    • Framework revision<PHONE_NUMBER> (5 weeks ago), 2020-12-10 11:54:40 -0800
    • Engine revision ae90085a84
    • Dart version 2.10.4

[✓] Android toolchain - develop for Android devices (Android SDK version 30.0.0)
    • Android SDK at /Users/dhs/Library/Android/sdk
    • Platform android-30, build-tools 30.0.0
    • Java binary at: /Applications/Android
      Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build
      1.8.0_242-release-1644-b3-6915495)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 12.0.1)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 12.0.1, Build version 12A7300
    • CocoaPods version 1.9.3

[!] Android Studio (version 4.1)
    • Android Studio at /Applications/Android Studio.app/Contents
    ✗ Flutter plugin not installed; this adds Flutter specific functionality.
    ✗ Dart plugin not installed; this adds Dart specific functionality.
    • Java version OpenJDK Runtime Environment (build
      1.8.0_242-release-1644-b3-6915495)

[✓] VS Code (version 1.52.1)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.16.0

[✓] Connected device (3 available)
    • sdk gphone x86 64 arm64 (mobile)    • emulator-5554
      • android-x64 • Android 11 (API 30) (emulator)
    • Darshan's iphone (mobile)           •
      21150b119064aecc249dfcfe05e259197461ce23 • ios         • iOS 14.2
    • iPhone SE (2nd generation) (mobile) • 6C85835D-FBFD-4AB3-8DE8-B4FAD35E5367
      • ios         • com.apple.CoreSimulator.SimRuntime.iOS-14-0 (simulator)

! Doctor found issues in 1 category.

[✓] Flutter (Channel master, 1.26.0-2.0.pre.312, on Mac OS X 10.15.4 19E2269
    darwin-x64, locale en-IN)
    • Flutter version 1.26.0-2.0.pre.312 at
      /Users/dhs/documents/Fluttersdk/flutter
    • Framework revision 7c75c01fc3 (8 hours ago), 2021-01-12 19:01:18 -0800
    • Engine revision 10cee6abcb
    • Dart version 2.12.0 (build 2.12.0-214.0.dev)

[✓] Android toolchain - develop for Android devices (Android SDK version 30.0.0)
    • Android SDK at /Users/dhs/Library/Android/sdk
    • Platform android-30, build-tools 30.0.0
    • Java binary at: /Applications/Android
      Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build
      1.8.0_242-release-1644-b3-6915495)
    • All Android licenses accepted.

[!] Xcode - develop for iOS and macOS
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 12.0.1, Build version 12A7300
    ! CocoaPods 1.9.3 out of date (1.10.0 is recommended).
        CocoaPods is used to retrieve the iOS and macOS platform side's plugin
        code that responds to your plugin usage on the Dart side.
        Without CocoaPods, plugins will not work on iOS or macOS.
        For more info, see https://flutter.dev/platform-plugins
      To upgrade see
      https://guides.cocoapods.org/using/getting-started.html#installation for
      instructions.

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 4.1)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build
      1.8.0_242-release-1644-b3-6915495)

[✓] VS Code (version 1.52.1)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.16.0

[✓] Connected device (5 available)
    • sdk gphone x86 64 arm64 (mobile)    • emulator-5554
      • android-x64    • Android 11 (API 30) (emulator)
    • Darshan's iphone (mobile)           •
      21150b119064aecc249dfcfe05e259197461ce23 • ios            • iOS 14.2
    • iPhone SE (2nd generation) (mobile) • 6C85835D-FBFD-4AB3-8DE8-B4FAD35E5367
      • ios            • com.apple.CoreSimulator.SimRuntime.iOS-14-0 (simulator)
    • macOS (desktop)                     • macos
      • darwin-x64     • Mac OS X 10.15.4 19E2269 darwin-x64
    • Chrome (web)                        • chrome
      • web-javascript • Google Chrome 87.0.4280.141

! Doctor found issues in 1 category.

Reproducible on stable 3.3 and master 3.7 on emulator but not a physical device Xiaomi k20 pro (Android 11)

Xiaomi Redmi k20 pro (Android 11)
Emulator Pixel 4 api 30

flutter doctor -v (mac)
[✓] Flutter (Channel master, 3.7.0-13.0.pre.131, on macOS 13.1 22C65 darwin-arm64, locale en-IN)
    • Flutter version 3.7.0-13.0.pre.131 on channel master at /Users/mahesh/Development/flutter_master
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 0196e6050b (2 days ago), 2022-12-31 11:10:23 -0500
    • Engine revision 932591ec04
    • Dart version 3.0.0 (build 3.0.0-76.0.dev)
    • DevTools version 2.20.0
    • If those were intentional, you can disregard the above warnings; however it is recommended to use "git" directly to perform update checks
      and upgrades.

[✓] Android toolchain - develop for Android devices (Android SDK version 33.0.0-rc4)
    • Android SDK at /Users/mahesh/Library/Android/sdk
    • Platform android-33, build-tools 33.0.0-rc4
    • ANDROID_HOME = /Users/mahesh/Library/Android/sdk
    • Java binary at: /Applications/Android Studio.app/Contents/jre/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 11.0.12+0-b1504.28-7817840)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 14.0.1)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Build 14A400
    • CocoaPods version 1.11.3

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 2021.2)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.12+0-b1504.28-7817840)

[✓] IntelliJ IDEA Community Edition (version 2021.2.1)
    • IntelliJ at /Applications/IntelliJ IDEA CE.app
    • Flutter plugin version 61.2.4
    • Dart plugin version 212.5080.8

[✓] VS Code (version 1.74.2)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.56.0

[✓] Connected device (3 available)
    • iPhone 12 Pro (mobile) • 026D5789-9E78-4AD5-B1B2-3F8D4E7F65E4 • ios            • com.apple.CoreSimulator.SimRuntime.iOS-14-5 (simulator)
    • macOS (desktop)        • macos                                • darwin-arm64   • macOS 13.1 22C65 darwin-arm64
    • Chrome (web)           • chrome                               • web-javascript • Google Chrome 108.0.5359.124

[✓] HTTP Host Availability
    • All required HTTP hosts are available

• No issues found!

[✓] Flutter (Channel stable, 3.3.9, on macOS 12.6 21G115 darwin-arm, locale en-IN)
    • Flutter version 3.3.9 on channel stable at /Users/mahesh/Development/flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision b8f7f1f986 (24 hours ago), 2022-11-23 06:43:51 +0900
    • Engine revision 8f2221fbef
    • Dart version 2.18.5
    • DevTools version 2.15.0

[✓] Android toolchain - develop for Android devices (Android SDK version 33.0.0-rc4)
    • Android SDK at /Users/mahesh/Library/Android/sdk
    • Platform android-33, build-tools 33.0.0-rc4
    • ANDROID_HOME = /Users/mahesh/Library/Android/sdk
    • Java binary at: /Applications/Android Studio.app/Contents/jre/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 11.0.12+0-b1504.28-7817840)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 14.0.1)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Build 14A400
    • CocoaPods version 1.11.3

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 2021.2)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.12+0-b1504.28-7817840)

[✓] IntelliJ IDEA Community Edition (version 2021.2.1)
    • IntelliJ at /Applications/IntelliJ IDEA CE.app
    • Flutter plugin version 61.2.4
    • Dart plugin version 212.5080.8

[✓] VS Code (version 1.70.2)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.53.20221101

[✓] Connected device (3 available)
    • iPhone 12 Pro (mobile) • 026D5789-9E78-4AD5-B1B2-3F8D4E7F65E4 • ios            •
      com.apple.CoreSimulator.SimRuntime.iOS-14-5 (simulator)
    • macOS (desktop)        • macos                                • darwin-arm64   • macOS 12.6 21G115 darwin-arm
    • Chrome (web)           • chrome                               • web-javascript • Google Chrome 107.0.5304.110

[✓] HTTP Host Availability
    • All required HTTP hosts are available

• No issues found!

Issue is reproducible on latest stable and master.
21212.mov
stable and master flutter doctor -v

About this issue, I faced it earlier.
I found this issue that already speak about this problem. (also here on stackoverflow)
Just adding <item name="android:windowLayoutInDisplayCutoutMode">shortEdges</item> in your styles.xml solve the weird behavior with the notch that is filled with a black line.


Get-ChildItem and piped rename-item result in iterative renaming

Prerequisites

[X] Write a descriptive title.
[X] Make sure you are able to repro it on the latest released version
[X] Search the existing issues.
[X] Refer to the FAQ.
[X] Refer to Differences between Windows PowerShell 5.1 and PowerShell.

Steps to reproduce
I am trying to rename all files in a directory.  This directory has 99 files in it.  Create an empty folder.  Then the following will create the files:
for($i=1; $i -lt 100; $i++) {
  Write-Output $i
  $s = "$i"
  if( $i -lt 10 ) { $s = "0$i" }
  New-Item "$s File $s.mp3" -type file
}

After creating files in a folder execute the following command:
Get-ChildItem -Path . -file | rename-item -NewName {"Pre $_"}

Expected behavior
I would expect the new file name would be as follows:

Pre 01 File 01.mp3

### Actual behavior

```console
Pre Pre Pre Pre Pre Pre Pre Pre Pre Pre Pre Pre Pre Pre Pre Pre Pre Pre Pre Pre Pre Pre Pre Pre Pre Pre Pre Pre Pre Pre Pre Pre Pre Pre Pre Pre Pre Pre Pre Pre Pre Pre Pre Pre Pre Pre Pre Pre Pre Pre Pre Pre Pre Pre Pre Pre Pre Pre Pre Pre 01 File 01.mp3

Error details
rename-item : The specified path, file name, or both are too long. The fully qualified file name must be less than 260
characters, and the directory name must be less than 248 characters.
At line:1 char:31
+ Get-ChildItem -Path . -file | rename-item -NewName {"Pre $_"}
+                               ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    + CategoryInfo          : NotSpecified: (:) [Rename-Item], PathTooLongException
    + FullyQualifiedErrorId : System.IO.PathTooLongException,Microsoft.PowerShell.Commands.RenameItemCommand

Environment data
Name                           Value
----                           -----
PSVersion                      5.1.19041.2673
PSEdition                      Desktop
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0...}
BuildVersion                   10.0.19041.2673
CLRVersion                     4.0.30319.42000
WSManStackVersion              3.0
PSRemotingProtocolVersion      2.3
SerializationVersion           <IP_ADDRESS>

Visuals
No response

This does not seem to happen on PowerShell 7.3. I notice your version says you are using windows PowerShell 5.1
On the latest released version. rename-item -NewName {"Pre $_"} - as shown above - gives an error because $_ is the path not the file name and the new name is trying to be Pre C:\Temp\test\Pre 01 File 01.mp3 .  Using  {"Pre $($_.name)"}  works. as expected
I have used Get-ChildItem  [something] | ren -new {$_.name -replace [old] [new]}
Since PowerShell 1 without hitting this problem.
If Get-ChildItem is finding the renamed Item and passing it down the pipeline -which might not happen in all circumstances - then I have been preventing that behaviour with the file selections I have been making, but I'm fairly sure I have done get * / replace "IMG","Paris" on a folder with hundreds of files.
Since the problem (I would class it as a bug but it might be by design, or some paging in .NET that PowerShell can't control) seems to be fixed in current PowerShell it's unlikely you'll see any change in PowerShell 5 as that is pretty much frozen except for security issues
Get-ChildItem -File * -Exclude "pre*"  | rename-item
gives a workaround

Hey:
I tried it and it doesn't appear to work the same:

Get-ChildItem -Path . -file | rename-item -NewName {"Pre $_"}Rename-Item: Cannot rename the specified target, because it represents a path or device name.
Stack overflow hasn't helped yet!
Phil==============  Phil Huhn(734) 545-5845==============

On Thursday, March 30, 2023 at 08:20:58 AM EDT, Phil Huhn<EMAIL_ADDRESS>wrote:

Hey:
I will attempt ps7.  The rename-item mostly worked for me also, but something about this command went very wrong.  Some edge case!
Phil==============  Phil Huhn(734) 545-5845==============
On Thursday, March 30, 2023 at 06:23:33 AM EDT, jhoneill<EMAIL_ADDRESS>wrote:

This does not seem to happen on PowerShell 7.3. I notice your version says you are using windows PowerShell 5.1
On the latest released version. rename-item -NewName {"Pre $"} - as shown above - gives an error because $ is the path not the file name and the new name is trying to be Pre C:\Temp\test\Pre 01 File 01.mp3 . Using {"Pre $($_.name)"}  works. as expected
I have used Get-ChildItem [something] | ren -new {$_.name -replace [old] [new]}
Since PowerShell 1 without hitting this problem.
If Get-ChildItem is finding the renamed Item and passing it down the pipeline -which might not happen in all circumstances - then I have been preventing that behaviour with the file selections I have been making, but I'm fairly sure I have done get * / replace "IMG","Paris" on a folder with hundreds of files.
Since the problem (I would class it as a bug but it might be by design, or some paging in .NET that PowerShell can't control) seems to be fixed in current PowerShell it's unlikely you'll see any change in PowerShell 5 as that is pretty much frozen except for security issues
Get-ChildItem -File * -Exclude "pre*" | rename-item
gives a workaround
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you authored the thread.Message ID: @.***>

@PHuhn can you try this command Get-ChildItem -File *.mp3 | Rename-Item -NewName {"Pre $($_.Name)"}

I did the following:
Get-ChildItem -Path . -file | Select-Object -ExpandProperty Name | rename-item -NewName {"Pre $_"}


Try running on 3 channels images, requires too much memory?

Thanks for contributing, I saw your comments on https://github.com/gram-ai/capsule-networks/issues, and gave it a try.
Instead of testing on Mnist, I am tried it on Cifar10. I do not have weights mismatch, but seems like it requires a lot of memory? I have reduced batch_size to 16.
RuntimeError: CUDA out of memory. Tried to allocate 26.41 GiB (GPU 0; 11.17 GiB total capacity; 3.16 GiB already allocated; 6.24 GiB free; 1.45 GiB cached)
Have you tried running it on Cifar10 or Imagenet?
This is my notebook:
https://colab.research.google.com/drive/1QLA6ktgjJlN-mtfm3VUBJ38VLPAXkD4q

Hey there,
Thanks for giving it a shot.
I looked at your code and I think it is because you are resizing your images to 224 (which is unusual for cifar10). If you change 114 to 32, it works with no problem. Even if you want to try capsule network on larger images, I'd say use some convolutions (with s>1) or even some pre-trained networks (e.g. use them as feature extractors; use the output of the last convolution to create the primary caps) to make the spatial dimensions (height and width) smaller before creating the primary capsules. The OOM problem happens in dynamic routing when you have a lot of capsules.

I also added the CIFAR10 dataset


Improve variant table search with a new index

As Daniele found out, creating new index like:
CREATE INDEX variant_pos_text_pattern_idx ON variants (("POS"::text) text_pattern_ops);

vastly improves performance when search for CHROM and partial POS, e.g.:
explain analyze select "CHROM", "POS", "REF", "ALT" from variants where "CHROM"='22' and "POS"::text like '3821%' limit 20;

Is this for new schema?  If not can be closed.

Yes, this is done.


Spyder, scipy.sparse.linalg librarie problem

hi
i am trying to use in Spyder v2.2.5 the function scipy.sparse.linalg.linsolve, but it is not recognized. It is possible to get it? or exist another way alternative to Spyder to use this function?

That's a module not a function. Maybe try spsolve?


Adding rosros to noetic and foxy, and to rosdep/python

Please add the following dependency to the rosdep database.
Package name:
rosros
Package Upstream Source:
https://github.com/suurjaak/rosros
Purpose of using this:
rosros is a wrapper library for providing a convenient unified interface to ROS1 / ROS2 Python API.
Distro packaging links:
Links to Distribution Packages

Pip:

https://pypi.org/project/rosros

Please Add This Package to be indexed in the rosdistro.
noetic, foxy
The source is here:
https://github.com/suurjaak/rosros
Checks

[X] All packages have a declared license in the package.xml
[X] This repository has a LICENSE file
[X] This package is expected to build on the submitted rosdistro

@suurjaak since this PR hasn't been updated recently I am going to close it. Feel free to re-open it when you have time to address the given feedback. If you open a new PR for the same project with an updated name please link back to this pull request so the discussion history is preserved.


Support websocket in insomnia

I am using websocket for graphql subscription but insomnia doesn't seem to support this feature. It would be great to bring websocket support.

Closing as duplicate of #528


Transform f1_bal_sheet_cr

Overview:
I used the same process_instant_xbrl and wide_to_tidy function as was used for some of the other specific FERC table transformer classes. However, in the process_instant_xbrl function, I changed the ValueError about unexpected years to a logger.warning plus row drop. There were some cases where data from 2019 was reported, but was irrelevant to the start and end that should have been 2020 and 2021. We should talk about how to standardize this function.
I didn't add a drop_invalid_rows param because I felt like it might make sense for every utility/year group to have the same list of liability_type values even if the starting_balance and ending_balance were NA. Like a mandatory categorical to indicate that there was a reporting gap/expected result. Open to discuss this.
To Do:

[ ] Reconcile with CG's PR #2127.

[ ] Use the drop_duplicate_rows_dbf from Christina's PR #2127. Note that there is one case (below) where the duplicate rows are NOT the same, rather, one line is all NA. This could be solved by adding a drop_invalid_rows param. See above for my thoughts on drop_invalid_rows.

utility_id_ferc1_dbf
report_year
starting_balance
ending_balance
end_qtr_bal
pri_yr_q4_bal
liability_type
record_id
utility_id_ferc1

48337
189
2000
nan
nan
nan
nan
accumulated_deferred_income_taxes
f1_bal_sheet_cr_2000_12_189_0_53
199

48339
189
2000
1.76227e+08
1.73642e+08
nan
nan
accumulated_deferred_income_taxes
f1_bal_sheet_cr_2000_12_189_0_53
199

[ ] Update min and max rows in validation

PR Checklist
Before requesting a review of your pull request, please make sure you've done the
following:

[ ] Merge the most recent version of dev (or the appropriate upstream branch) into
your branch and resolved any merge conflicts. You may need to do this several
times over the course of a PR as dev changes frequently.
[ ] Verify that all of the CI checks on your PR are passing. See
Running Tests with Tox
for details on how to run the full test suite locally if you need to debug a
particular failure.
[ ] Ensure that the docstrings for any new modules, classes, functions, or methods are
descriptive enough for developers and users to understand your code.
[ ] If you expanded data coverage or changed the outputs, ensure that the full
data validation tests
pass locally on a fresh DB.
[ ] If you've added new functions or classes, ensure that they have at least basic
unit tests.
[ ] If you've added new analyses, make sure they include defensive sanity checks that
will catch unexpected data issues.
[ ] Update the
release notes
to reflect your changes. Make sure to reference the PR and any related issues.
[ ] Do your own review of the PR. Add comments highlighting areas where you have
questions you'd like reviewers to answer, known issues, solutions you're
unsatisfied with, or other things that deserve special attention from the
reviewer.

I just made a new parameter called create_instant_start_end_cols that, when True, implements the process_instant_xbrl code we were duplicating in table classes.
As I was applying this to the plant in service table and the balance sheet liabilities table, I noticed that the PIS table was erroring both before and after I added the new code. Specifically, when I run process_xbrl on the PIS table before adding my parameter it would fail because there were unexpected years (2019, the same issue I was having here in the liabilities table that I fixed). After adding my parameter and code to the parent process_instant_xbrl function, it still failed because of the following wide_to_tidy parameters. It seems like it didn't drop any columns when it was expected to drop 2 based on the parameters. Just wanted to check with you @cmgosnell if this seems weird or what to expect here.
AssertionError: Dropping more columns (0) than expected (2). Columns dropped: []

Should I make a unit test for process_xbrl_instant?


Removed a public website reference

Public websites were removed from SharePoint Online

@MikePlumleyMSFT is it okay to merge this?