Nginx + Flask

I have Nginx over flask to redirect requests at port 8443 to flask on port 5000.
3 weeks ago it worked properly simply setting the defaults value on flask (host=<IP_ADDRESS>, port=5000) , but has stopped working. Now only it works if you put  flask directly on webhook at port 8443 defining host to <IP_ADDRESS> .
I've been debugging and in both cases the message arrives to the queue (pass_update) but the difference between one form and another seems that one consume the msg stored in the queue and the other no, simply put it in.
What am i doing wrong?
here is my bot run code (it's like an example...)

from queue import Queue
from flask import Flask, request
from mybot import Bot
from mybot.settings import WEBHOOK_PORT, WEBHOOK_CERT, WEBHOOK_CERT_KEY

app = Flask(__name__)
update_queue = Queue()   # channel between `app` and `bot`
bot = Bot(update_queue)
context = (WEBHOOK_CERT, WEBHOOK_CERT_KEY)
bot.message_loop()

@app.route('/mybot', methods=['POST'])
def pass_update():
    update_queue.put(request.data)  # pass update to bot
    return 'OK'

if __name__ == '__main__':
    app.run(
        # host='<IP_ADDRESS>',
        # port=WEBHOOK_PORT,
        ssl_context=context,
        debug=True)

I think I `m going to develop my own solution using celery and passing telepot .

In case you haven't totally left, shouldn't you supply the message queue to message_loop()?
bot = telepot.Bot(TOKEN)

bot.message_loop(source=update_queue)

I am assuming you have overridden the appropriate methods in bot, so there is no need to supply a handler function or routing table to message_loop().


[Bug]: Compose Multiplatform cannot aggregate resources properly in multi-module projects

Is there an existing issue for this?

[X] I have searched the existing issues

Is there a StackOverflow question about this issue?

[X] I have searched StackOverflow

What happened?
https://youtrack.jetbrains.com/issue/CMP-6986/Compose-Multiplatform-cannot-aggregate-resources-properly-in-multi-module-projects
Relevant logcat output
No response
Code of Conduct

[X] I agree to follow this project's Code of Conduct

Caused by kotlin.mpp.enableResourcesPublication=false in gradle.properties


error: llava key

Hey1
I'm encountering an error when trying to download the model from Hugging Face. The error is related to "llava." Are you already integrated with Hugging Face? Should I install a version later than your requirements, or should I proceed to download the model in a different way?
thank you!

@menahem-borges-rodrigues how did you resolve this?


Keyboard not working at all

Hello everyone,
I have soldered this keyboard and flashed as described in the repository with no error, but the keyboard is not working at all.
I see the redox-wireless receiver in my settings in Windows, but no input is sent to the System.
Since i dont have the on/off switches right now, I have soldered the PCBs to be on, I hope it works this way as well?
Also the LEDs are not working, but I am pretty sure this cant be the issue that nothing works.
Yes, I am not the best in soldering work, but the previous keyboard, an Ergodox works.
I have uploaded some images here: https://github.com/AsatothAbaddon/redox-w
I hope anyone can help, I really want to finish this keyboard.
Thanks in advance!

Hi,

Since i dont have the on/off switches right now, I have soldered the PCBs to be on, I hope it works this way as well?

It should as long as the pads you joined are the correct ones. Can't quite make out if that's the case but a multimeter should tell you all you need to know. If you see 3.3V on the VCC pad of the YJ-14015 you're good. Another way to power the YJ-14-015 is through the programming headers using the ST-Link programmer.

Also the LEDs are not working, but I am pretty sure this cant be the issue that nothing works.

Yeah, should not be a problem.

Yes, I am not the best in soldering work, but the previous keyboard, an Ergodox works.

Sorry to tell you but those two are quite different in the skill required. The YJ-14015 is hard to get right and, judging from the pics, it might be a soldering issue from what I see.
Try powering the board through the ST-Link programmer (removing the batteries of course) and try it out. If it doesn't work it's most probably a soldering issue.

Thanks for your reply!
So I think i need a multimeter.

Try powering the board through the ST-Link programmer (removing the batteries of course) and try it out. If it doesn't work it's most probably a soldering issue.

I tried to use the 3.3v and the GND Pins with the corresponding onces on the PCBs (ofc, with no battery) and while the receiver is plugged in but nothing happend...
I order a multimeter right now and make tests on the weekend.


Ability to invalidate old token/session when user login with another machine.

Hi All,
I'm new to feathers. I already implement local and jwt authentication.

I use local authentication to get token
I use token authentication to call api services.

but when I go to login on another machine. the old logged in session on the old machine still valid.
I would like to know, Is there any setting or work around to invalidate old token or old user session to make old session or token not usable anymore.
Thanks

That is how JWT works.  A token is valid until its expiration date.  You can store the token at login, maybe with the user, or wherever you want, and run a check to see if the passed in token matches the stored one.

Yup. Duplicate of #133. If you want to revoke tokens, you need to maintain a blacklist or whitelist. This is left up to you. Generally, JWT assumes that since tokens are unique and should be securely stored that if they user discards it, then it will eventually be no longer valid.
Tokens are only good for a day but you can configure their TTL as well if you want.

Hi all,
Thanks for your kindness response. I think I will store the latest token in the database after login and then compare latest token with JWT authentication.
by the way, I'm falling in love with feathersjs. It really cool.

Hi,
I am just starting FeatherJS and found the same problem. I do understand JWT should stored for this kind of application. Ok, lets suppose that I store the JWT on user/whatever storage from authentication after hook. But, When the user logouts by app.logout() I didn't find it is called remove method of authentication service. What is the way/best practice to remove the JWT on logout/password change etc events? Please give me insight of both frontend and backend.


Custom # of channels from new PR not working

EfficientNet.from_pretrained("efficientnet-b{}".format(bN),
                                               num_classes=6,
                                               in_channels=channels)

TypeError: from_pretrained() got an unexpected keyword argument 'in_channels'

might have to do with the fact that there are 2 from_pretrained() methods? not exactly sure
Edit: I made some changes in my fork, will post a PR once I have time to test it

#94 Fixed this issue and tweaked from_name as well


Embed stops working after longer inactivity

Summary
Create map with Builder and publish as embed URL, after some time inactivity the tokens get expired, and map stops working unless user does manual refresh.
Steps to Reproduce

Create map, publish and get embed link. Open this link. Check that it works fine with zoom/pan etc. Do not close the window/tab in browser
Use same tab after some time, e.g. 24 hours later. Do not reload page.
Zoom/pan map

Current Result
Map is broken - see only basemap and previously cached tiles, no new tiles loaded. From network log I see 400 Bad Request instead of map tiles, and data is {"errors":["Invalid or nonexistent map configuration token 'ba5fe63177f3b69f129b9e51cedc33cf'"],"errors_with_context":[{"type":"unknown","message":"Invalid or nonexistent map configuration token 'ba5fe63177f3b69f129b9e51cedc33cf'"}]}
Now if I refresh page manually in browser, then map starts working again - meaning that map itself is ok, just the token was expired.
Expected result
Browser (JS) should make automatic reload of the map configuration (re-init of the map) if user keeps browser open for long time, so it just keeps working without manual refresh requirement.
If map is really expired (deleted, unpublished etc), then should show relevant error message instead of broken map.
Browser and version
Chrome on mac
Use cases
Most users do not notice it, they do not have long sessions. Or if they do, then may try manual refresh which resolves issue. Still even this gives somewhat negative impression of the page - why does it not just work. And there could be cases where this can be really problematic - e.g. info kiosk in museum with keeps same page open, and does not always have manual reload button.
Impact can be checked from logs by 400 Bad Request messages perhaps

It seems that same happens also with Builder.


Tests for idempotency check.

Hello @amore17! Thanks for the PR.
I think we can use the actual tests to write idempotency checks instead of write new checks. I wrote an example here: https://github.com/linux-system-roles/certificate/compare/master...seocam:idempotence-example
Basically we include the role again (it will use the same variables) and then we verify if it hasn't changed anything.

Hello @amore17! Thanks for the PR.
I think we can use the actual tests to write idempotency checks instead of write new checks. I wrote an example here: master...seocam:idempotence-example
Basically we include the role again (it will use the same variables) and then we verify if it hasn't changed anything.

BTW, that's the idea but this example doesn't work. result.changed is always false no matter if the role changed something or not.


pulumi-bin: 3.134.1 -> 3.135.1

https://github.com/pulumi/pulumi/compare/v3.134.1...v3.135.1
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Isn't it pulumi-bin: 3.134.1 -> 3.135.1?

Yeap. It is. However, closing this one in favor of #347446


Remove min and max range on line-length JSON schema

Summary
This was introduced in https://github.com/astral-sh/ruff/pull/7412, but SchemaStore doesn't accept it. I manually edited the JSON schema last time, then tried to fix this, then gave up -- so removing for now.
(See, e.g., https://github.com/SchemaStore/schemastore/pull/3278, which failed prior to removing the min and max.)

Can we not just add exceptions in the schema store schema validator similar to what I did at https://github.com/SchemaStore/schemastore/pull/3221/files#diff-5b41cf0105f054a82fd2932cf8e4af10ec697a315a9fe61d3f1956c0a47cdafc?
I don't think we should remove correct validation on our end if avoidable.

I'll give it a quick try on SchemaStore! If it doesn't work, we should merge this and revisit later. From a procedural perspective, this is a clean revert of a change that broke the release. (Users already aren't benefiting from the change because we can't release the updated schema anyway.)

Maybe I can try post-processing the JSON. Sounds like a pain in Rust though 😬

Tracking in https://github.com/astral-sh/ruff/issues/7877.

For posterity, this is not SchemaStore being overly strict, it's invalid JSONSchema. This following is invalid:
    "line-length": {
      "description": "The line length to use when enforcing long-lines violations (like `E501`). Must be greater than `0` and less than or equal to `320`.",
      "anyOf": [
        {
          "$ref": "#/definitions/LineLength"
        },
        {
          "type": "null"
        }
      ],
      "maximum": 320.0,
      "minimum": 1.0
    }

An anyOf can't have a minimum/maximum length. Only a "type": "number" has those properties. So it has to go inside the definition at "#/definitions/LineLength".

Thanks @henryiii, much appreciated!


Redirect people to a raw version of the syntax logo after a Right Click

Referencing issue #273
Hope this helps 👍

Hey, would like someone review my Pull Request 👍


Please, fix this bug with this code changes

I was to create screens with godot when I tried to stop one node and keeping the other running.
get_tree().set_pause(false)
nodeA.set_pause_mode(PAUSE_MODE_STOP)
nodeB.set_pause_mode(PAUSE_MODE_PROCESS)
get_tree().set_pause(true)
NodeA and B are children from main scene. I discover that problem is when run nodeB.set_pause_mode(PROCESS) the children from nodeB are stopped like if the nodeB was stopped too, but no, nodeB is the ONLY running, while their children are paused! I tried to alert this but it seems nobody understand.
Now the solution:
Go to the scene/main/ in godot's source
Open the file node.cpp
Go to line 72 and where has the else with data.pause_owner=NULL;, just change to data.pause_owner=this;
The problem was the data.pause_owner stay lost in some part of the code, that above in my opinion.
It was because that the program NEVER GOES BEYOND of the "if (!data.pause_owner)" in the function "Node::can_process()" when pause mode of the node is PAUSE_MODE_INHERIT
NOTE: I don't know how to add the fix to godot code, so please, anyone do this for me.]
Espero ser mais ouvido na próxima vez.
Passar bem.

Oh and some little note: in the line 388 of the node.cpp in function set_pause_mode() if the node not has any parent so the pause_owner in the children will be lost because it's a NULL on the line 384. I put an else with "owner = this" and this could have some effect on the solution of the bug, please, give a look in that lines.

It would be nice if you could edit the issue title to actually describe the bug, and not a request :) People reviewing bug reports should not have to read everything before they can understand what the issue is talking about (even though reading it all is of course necessary to understand it fully - but the title should be a summary).

Man, the fix not change the physics of the game and not change the sample player, because to get this works you must have to set the pause to true. Well, I will try the old method to make screens.

@sam-leo Would you mind either making a sample project or a PR (pull-request) with your fix?

Sorry for the delay, @bojidar-bg I don't was able to reproduce the bug in a little example. I suppose it was just in my project. So, I will close this issue. Maybe the "bug" was for the way that I tried to use the screens: loading all nodes and hide the nodes and showing the actual screen. Thank you


fixed Treasury acronyms in outputs

changed TREAS to treas in titles of outputs

I think this PR is unnecessary now. Closing and deleting branch without merging.


Fix release workflow

:tada: This PR is included in version 1.4.1 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:

:tada: This PR is included in version 1.4.1 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:

:tada: This PR is included in version 1.4.1-test.1 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:

:tada: This PR is included in version 1.4.1 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Why i can't search any manga

I can't search any manga , a notification no results found show in bottom , when i click retry nothing change

can you clear your cookies in advanced settings then relogin

Still can't search

if this was a new account did you activate it after signing up?

It work , thanks


Functional subcommittee links broken

Page(s) where issue occurs
https://www.tdwg.org/about/executive/
Issue description
Functional subcommittee links broken. They point to links in the form:
https://www.tdwg.org/committees/tag/
The correct format seems to be:
https://www.tdwg.org/about/committees/tag/

What is wrong? What were you expecting instead?

Thanks, Nicky!  Fixed.


vapoursynth-{bm3d,bm3dcuda,bm3dcpu,bm3dhip,dfttest,hqdn3d,knlmeanscl,wnnm},vs-{dfttest2,dfttest2cuda,dfttest2gcc,dfttest2hip,nlm-cuda,nlm-ispc},neo_{dfttest,f3kdb}: init

Description of changes
Added a bunch of vapoursynth plugins

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Result of nixpkgs-review pr 333321 run on x86_64-linux 1

3 packages failed to build:

vs-dfttest2
vs-dfttest2cuda
vs-dfttest2gcc

13 packages built:

neo_dfttest
neo_f3kdb
vapoursynth-bm3d
vapoursynth-bm3dcpu
vapoursynth-bm3dcuda
vapoursynth-bm3dhip
vapoursynth-dfttest
vapoursynth-hqdn3d
vapoursynth-knlmeanscl
vapoursynth-wnnm
vs-dfttest2hip
vs-nlm-cuda
vs-nlm-ispc

Result of nixpkgs-review pr 333321 run on x86_64-linux 1

16 packages built:

neo_dfttest
neo_f3kdb
vapoursynth-bm3d
vapoursynth-bm3dcpu
vapoursynth-bm3dcuda
vapoursynth-bm3dhip
vapoursynth-dfttest
vapoursynth-hqdn3d
vapoursynth-knlmeanscl
vapoursynth-wnnm
vs-dfttest2
vs-dfttest2cuda
vs-dfttest2gcc
vs-dfttest2hip
vs-nlm-cuda
vs-nlm-ispc

Result of nixpkgs-review pr 333321 run on x86_64-linux 1

16 packages built:

neo_dfttest
neo_f3kdb
vapoursynth-bm3d
vapoursynth-bm3dcpu
vapoursynth-bm3dcuda
vapoursynth-bm3dhip
vapoursynth-dfttest
vapoursynth-hqdn3d
vapoursynth-knlmeanscl
vapoursynth-wnnm
vs-dfttest2
vs-dfttest2cuda
vs-dfttest2gcc
vs-dfttest2hip
vs-nlm-cuda
vs-nlm-ispc

I suppose you could use generic stdenv and cudaPackages parameters instead of specific variants and then provide those as arguments to callPackage in pkgs/top-level/all-packages.nix, but I am not sure how important that is.


regex_match does not compile using the g flag

Describe the bug
The regexp_match function fails to compile when supplied a g flag.
To Reproduce
At the moment many functions including regex match are not working correctly when accessed directly via the dataframe interface (I am working on a fix for this).
To reproduce this bug, setup a test in functions.rs
    test_function!(
            RegexpMatch,
            &[
                lit(ScalarValue::Utf8(Some("abc".to_string()))),
                lit(ScalarValue::Utf8(Some("a..".to_string()))),
                lit(ScalarValue::Utf8(Some("g".to_string()))),
            ],
            Ok(Some("abc")),
            &str,
            Utf8,
            StringArray
        );

This will fail with a compile error from the regex subsystem.
Expected behavior
The regex_match function should accept "g" as the standard regex global expression flag.
Additional context
the regex_match function, that does behave as expected includes some lines to format flags into a rust pattern:
https://github.com/apache/arrow-datafusion/blob/50a98805cdd6d5383f0c124d449ed549ca13428a/datafusion/src/physical_plan/regex_expressions.rs#L139
This mapping is not present in the regex_match function.

If we are using PostgreSQL as baseline, then supplying g flag to regexp_match() should indeed result in an error.
psql (15.1 (Debian 15.1-1.pgdg110+1))
Type "help" for help.

postgres=# select regexp_match('a', '[a-z]', 'g');
ERROR:  regexp_match() does not support the "global" option
HINT:  Use the regexp_matches function instead.
postgres=#

Reference: https://www.postgresql.org/docs/current/functions-matching.html#FUNCTIONS-POSIX-REGEXP
Supported flags: https://www.postgresql.org/docs/current/functions-matching.html#POSIX-EMBEDDED-OPTIONS-TABLE
Seems its regexp_matches() which is the one supporting g flag, but doesn't seem to be implemented in Datafusion yet (could raise an issue for this?)


[Feature] Rewards Pool field

Feature Description

For participating in the bond (being a guarantor and providing the bond) they may or not be a reward. The reward field describes the participants reward.
Additional Information

rewardsPool will not be alterable after bond creation.
Optional, null/empty is allowed.
Following single responsibility, implement this feature in it's own contract and have the bond extend apply the functionality via inheritance.

Closed by https://github.com/windranger-io/windranger-treasury/issues/67
Going with a single field that may contain multiple value, all managed externally to the contract (i.e. bond creator / front end JS).


Add fuzz inputs

C.f. last one: https://github.com/bitcoin-core/qa-assets/pull/175
mv fuzz_seed_corpus fuzz_inputs_upstream
../bitcoin-core/test/fuzz/test_runner.py -l DEBUG --par $( nproc ) --m_dir ./fuzz_inputs_upstream/  --m_dir ./results_from_working_farm --m_dir ../etc/... ./fuzz_seed_corpus
git restore -- ./fuzz_seed_corpus
git add ./fuzz_seed_corpus
git commit -m "Add fuzz inputs"

I am never quite sure how I’m supposed to read those two coverage reports. :sweat_smile:
If I read it right, the main branch has no coverage of sha256_avx2.cpp, sha256_sse4.cpp, and sha256_sse41.cpp, while the feature branch has full coverage of those three, but the main branch had full coverage of sha256_x86_shani.cpp and the feature branch has none.
Are these different architectures where only one or the other applies?

Otherwise looks like some nice NgU

LGTM

Gonna wait for https://github.com/bitcoin/bitcoin/pull/30169


task(CI): enable 64 bit IL2CPP android tests

Goal
enable 64 bit IL2CPP android tests

Raw project settings don't mean too much to me and more detail in the description would be useful.   What can we do after this change that we couldn't do beforehand?  What testing has been performed to show the change is correct?  That doesn't necessarily have to be automated tests, but having an understanding of what the problem was and that this solves that problem would be good.


Add alt-text tags to foundation pages (4-7)

Add alt-text tags to the build foundation pages (4-7).
In the code at:
_posts/build_fdn/2020-06-09-Realm-API-Key.md
_posts/build_fdn/2020-06-09-Setup-Commandline-for-Realm-Import.md
_posts/build_fdn/2020-06-09-Import-Realm-Code.md
_posts/build_fdn/2020-06-09-Connect-Realm-With-Data.md
On the web at:
https://wildaid.github.io/foundation/2020/06/09/Realm-API-Key.html
https://wildaid.github.io/foundation/2020/06/09/Setup-Commandline-for-Realm-Import.html
https://wildaid.github.io/foundation/2020/06/09/Import-Realm-Code.html
https://wildaid.github.io/foundation/2020/06/09/Connect-Realm-With-Data.html
A brief guide to alt-text tags can be found in our style guide at https://wildaid.github.io/style/2020/10/02/Alt-Text.html

I can add in these alt tags, assign to me and I'll fork over the repo

Hello @ericblancas23, thanks for offering to work on this! I have assigned it to you.


Woker2003 patch 1

add domain place: intep.edu.co

@Woker2003 First stage of verification passed, official domain for Instituto de Educación Técnica Profesional de Roldanillo, Valle INTEP is intep.edu.co as far as I verified. This is just an informational note. Pull request is still in the review. I appreciate your patience while waiting for the final decision.

@Woker2003 I am closing this request as a duplicate. Thank you.


No compatible binary build found for this package

Hi,
I wanted to update my packages today and it seems that the Meteor-Files one (ostrio:files) is somehow  broken currently (at least for me).

There might have occured an error in one of the later steps of publishing the build.

Hi @Aur0r
This issue is known, working on it.
Please let me know which Meteor version and Platform you're on (Win, Mac, Linux)?
During our investigation, please read this thread and this one, it's for different package, but with same issue, hope it will help.

Or install:
meteor add<EMAIL_ADDRESS>--allow-incompatible-update

v1.4.0 has same codebase, only difference v1.4.1 has explicit dependency for fibers package

Just to let you know I updated successfully to the newest version and everything works. Thank you again!

Thank you for contribution. BTW, new version is coming :)


How to make slight modifications to the lstn/dataloaders/train_datasets.py?

Hello author, how do I need to modify this aspect?

Replace the lines in the py file where images and masks are loaded with the image loading method from OpenCV.
For example, replace line 55 with ref_label =  cv2.imread(xxx)

Thank you very much for your timely reply, but does ref_index need further processing?


forgejo: fix applying of our STATIC_ROOT_PATH patch

Description of changes
This fixes an issue where running the forgejo package standalone, without the use of our nixos/forgejo module, would try to use a directory named @data@ for its STATIC_ROOT_PATH assets.
This went unnoticed until now, because most users use the nixos/forgejo module in which we explicitly set this option/setting/path to cfg.package.data by default (pkgs.forgejo.data).
Also, this commit hard-copies the patch in question from gitea to our nixpkgs derivation directory.
We decided a long time ago to part ways, and forgejo inheriting the patch from gitea's drv directory puts strain on gitea.
So we don't do that anymore and instead maintain that patch ourselves
from now on.
Unfortunately, substituteInPlace --subst-var does not error, when the
substitution fails.
This would have prevented this issue from going unnoticed.
Fixes #299802 (cc @LunarLambda)
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[x] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Thank you very much for the quick action! Out of curiosity, what's the rough turnover for this fix being available in nixpkgs-unstable?

@LunarLambda: The turnover time depends on the amount of rebuilds CI needs to do, and if any tests fail the channel does not advance at all (good!). I don't know if the channel lag time is tracked anywhere, but I think it is an interesting metric.
You can track this specific PR here though: https://nixpk.gs/pr-tracker.html?pr=299811

ah, thank you :)

Update landed, installed, confirm it works like a charm!
The lack of a version bump made it a little harder to install (had to uninstall, then reinstall, or maybe I'm just doing it wrong ^^;)


New Getting Started section for Performance: Measuring Performance doc and all images

New Getting Started section for Performance: Measuring Performance doc and all images

I approved this pull request; however, see my feedback above to make the images look better using the shadow technique.

The new images are great, but still gonna keep this open, to improve the appearance of remaining images by adding the shadow effects. Basically you use these commands on the same photos: Cmd + Shift + 4 + spacebar + click, and the image will get a nice shadow background around it, which makes it look quite a bit cleaner. For an example of what I mean, check out images in this doc that uses that technique: https://developers.google.com/web/tools/chrome-devtools/.
One trick of getting this to work quickly is to open each existing photo in it's own tab, shrink it down, and then use the commands. That way you are taking a picture of the picture, and getting the shadow effects.

Hey folks. Do we know what the current status of this PR is? I see Dave landed some follow up commits to the shadow comments in https://github.com/google/WebFundamentals/pull/5182/commits/9c539db35d6c4236313014137bd08edee1bfa121. Are we closer to landing this?

Hey,
I will do a full sweep Thursday morning to give a proper status.
Wasn't able to do this over the past few weeks due to GDD India deadlines.
Meggin
On Mon, Dec 4, 2017 at 8:19 AM, Addy Osmani<EMAIL_ADDRESS>wrote:

Hey folks. Do we know what the current status of this PR is? I see Dave
landed some follow up commits to the shadow comments in 9c539db
https://github.com/google/WebFundamentals/commit/9c539db35d6c4236313014137bd08edee1bfa121.
Are we closer to landing this?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/google/WebFundamentals/pull/5182#issuecomment-349013379,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABfU4YIC4SnmHRH1PYLe9w3VIH1Eey5Cks5s9BuZgaJpZM4P-YDz
.

Looks like the build is failing, once that's fixed, @addyosmani, please squash and merge when you're ready.

:tada: This has been pushed live to https://developers.google.com/web/


Add README note to avoid issues with parked domains

Unconfigured (parked) Porkbun domains have trouble using dns-porkbun. By default, Porkbun does not enable API access on domains, and two default ALIAS records pointing to Porkbun's domains make dns-porkbun do a CNAME forwarded verification with Porkbun's domain. The latter issue is particularly bad because the only error given is an Invalid domain. error, which more-or-less leaves you to intuit that your domain redirected verification to another. I would consider adding a log message to more clearly indicate the result of domain resolutions, though I digress.
These issues should only appear on parked Porkbun domains. The software is behaving exactly as it should, but some people (myself included) may try to generate certificates before setting up their DNS records, potentially causing them issues. To remedy this, I'm opening this PR with a note advising users to enable API access and remove the default ALIAS records.
Thanks!

LGTM


Enhance Code Security with Pre-Commit Hooks

We are taking proactive steps to embed security into our coding practices, improve adherence to language-specific best practices, strengthen and secure our Software Configuration Management (SCM) workflow, and fortify our release process.
As part of this effort, we have prepared a process to include pre-commit hooks in our development workflow. These hooks serve as a crucial line of defense, helping us catch potential issues before they become problems.
Action required:
To make it easy for all members of our development team to integrate these hooks, we have compiled templates for various languages and technologies. You can find these templates in our dedicated repository:
Your cooperation in implementing these hooks is greatly appreciated. If you encounter any issues during the installation or have any recommendations or questions, please feel free to reach out to me.
Let's work together to make our development process more secure and efficient.
@jebinjeb @vijeyash1

changes available as part of this PR https://github.com/intelops/kubviz/pull/344


Pilot 0.7.1 sometimes never configures in.80 cluster in sidecar proxy

This is reproducible by deleting and restarting injected pods repeatedly. After <100 tries, a newly started sidecar will always returns 503s for every HTTP request.
This message appears repeatedly in the istio-proxy logs:
2018-05-03T01:22:20.150396936Z [2018-05-03 01:22:20.150][11][warning][upstream] external/envoy/source/server/lds_subscription.cc:68] lds: fetch failure: route: unknown cluster 'in.80'

When in that state, the sidecar proxy never recovers, even after several hours.
The only workaround is to restart Pilot, which immediately recovers the sidecar.
Note that there are no network connectivity issues for that pod at all. And it correctly receives listener configuration from Pilot:
2018-05-03T01:22:20.147122047Z [2018-05-03 01:22:20.146][11][info][upstream] external/envoy/source/server/lds_api.cc:60] lds: add/update listener 'http_<IP_ADDRESS>_9093'
2018-05-03T01:22:20.147124538Z [2018-05-03 01:22:20.146][11][info][upstream] external/envoy/source/server/lds_api.cc:60] lds: add/update listener 'tcp_<IP_ADDRESS>_443'
2018-05-03T01:22:20.147223801Z [2018-05-03 01:22:20.147][11][info][upstream] external/envoy/source/server/lds_api.cc:60] lds: add/update listener 'tcp_<IP_ADDRESS>_15003'
2018-05-03T01:22:20.147434882Z [2018-05-03 01:22:20.147][11][info][upstream] external/envoy/source/server/lds_api.cc:60] lds: add/update listener 'tcp_<IP_ADDRESS>_15005'
2018-05-03T01:22:20.147646504Z [2018-05-03 01:22:20.147][11][info][upstream] external/envoy/source/server/lds_api.cc:60] lds: add/update listener 'tcp_<IP_ADDRESS>_443'
2018-05-03T01:22:20.150396936Z [2018-05-03 01:22:20.150][11][warning][upstream] external/envoy/source/server/lds_subscription.cc:68] lds: fetch failure: route: unknown cluster 'in.80'

Attached the sidecar proxy and Pilot logs:
app-sidecar-proxy.log
pilot.log

Upper is from cilium + istio0.7.1 + k8s 1.0.
In calico + istio0.7.1 + k8s 1.9, also raise upper issue once:
[2018-05-03 06:29:16.470][59][warning][upstream] external/envoy/source/server/lds_subscription.cc:68] lds: fetch failure: route: unknown cluster 'in.3000'
[2018-05-03 06:29:17.667][59][warning][upstream] external/envoy/source/server/lds_subscription.cc:68] lds: fetch failure: route: unknown cluster 'in.3000'

@rshriram , will this issue be fixed in istio 0.8.0？ Thanks

@johnzheng1975 I haven't been able to reproduce this so far with version release-0.8-20180521-15-16 and the proxyv2 image.

@rlenglet I will close this for now, please re-open if you still see this with 0.8.


Remove Page.Page()

Will this stop working?
layouts/_default/single.html
{{ partial "foo" . }}

layouts/partials/foo.html
{{ .Page.Title }}

Will this stop working?

... Yes. Maybe that was a bit rash ... I guess people have this construct to make the templates more portable (between shortcodes and page) ...

OK, I'll drop that idea ...


Adding a stats page

@netlify /en/pages-to-review/

@JulieBB23 Do we want the analytics to be part of the "About the Digital Accessibility Toolkit" section on the homepage?

@JulieBB23 Do we want the analytics to be part of the "About the Digital Accessibility Toolkit" section on the homepage?

Yes, i think it is a good idea to share it.
Approved :)

Any objects of this going live:

Website usage analytics
Analytique de l’utilisation du site Web


Iterators: [NFC?] Pass TypeConverter through IteratorAnalysis.

This PR used to be part of #553 and should be non-controversial. It extends the IteratorAnalysis class and related functions with a TypeConverter member/argument such that that type converter can be used when computing the type of an iterator state (which is one of the main tasks of the analysis).

In the PR of the "read from memrefs" op (#553), I currently need a TypeConverter here in order to determine the LLVM type of one field of the LLVM struct that represents the state of the iterator, namely that of the input "columnar batch"/"table"/...
I guess that the fact that I need this is a consequence of the fact that the lowering from iterators to LLVM is rather large step. But if I want to lower the iterator state to an LLVM struct, all of its contents have to be lowered to LLVM in the same step, so any state that would otherwise contain higher-level values, needs to do such a lowering. I understand that this is not elegant at all, but improving this fundamentally seems to require a redesign of the whole conversion. Is that something we want to do before merging in the "read from memrefs" op?
Let's suppose we don't and try to find a fix. Indeed, IteratorAnalysis now "has a" TypeConverter. But that doesn't have a formal function like mlir::isa(), right? And I would say that IteratorAnalysis "is not a" TypeConverter -- it computes types for the ops of a given module (in a way that is sensitive to their use-def chains) so it can't be used as a TypeConverter. Plus it does a bunch of other things (namely determining the names of the open/next/close functions). In short, I don't see how either of the two help?
Also note that we have to pass the TypeConverter to all computeStateType functions because they aren't member functions of the IteratorAnalysis (by design) -- unless we want to have have different calls to these functions depending on the function signatures (which I think isn't elegant and which I removed not too long ago in #554).

The redesign of the analysis, type vs SSA etc is a much longer topic.
Here I am just suggesting creating a new struct from the typeconverter and moving all the static funcs into it: low tech refactoring that avoids changing all the signatures everywhere.

Here I am just suggesting creating a new struct from the typeconverter and moving all the static funcs into it: low tech refactoring that avoids changing all the signatures everywhere.

Ah, OK, I see, thanks! Is the updated PR what you had in mind?


Add 'tests/test_install.py'

This change adds unit tests for the aqt install and aqt install-qt commands, and establishes a pattern that can be extended for more tests. This is intended to make it easier to increase test coverage of parts of the codebase that are not yet covered by tests.
This uses the pytest-socket library to ensure that the tests do not use any network IO. It also mocks multiprocessing.get_context to prevent multiprocessing. This is necessary because multiprocessing spawns child processes that have not been monkey-patched, which would break the test.
These tests use py7zr to create mock 7z archives, which are installed and patched in a temporary directory. The tests check the content of the patched files and any output to stderr.
I think that this will increase the code coverage of this project by a good chunk. These are the coverage changes that I am seeing locally:

archives: 56 -> 59%
helper: 66 -> 74%
installer: 42 -> 65%
updater: 11 -> 53%

Edit: The tests are running OK locally. I'm not yet certain why they are failing in CI.

This definitely needs a code review. I did some weird things to monkeypatch the multiprocessing library that I am not too comfortable with. I have noticed some platform-dependent differences between Windows and Linux, and that makes me wonder if these tests will run properly on a Mac. I have not tried that yet, since I don't have regular access to a Mac.


ignore_sigterm.sh: Put date after sleep

At least the only way for test/exile/process_test.exs:225 to work correctly
is to use sleep(1) as date and echo barely take any time to execute.

Hi @lanodan, can you share what issue you were facing with this test? It was failing for BSD systems is it?

Nah, it's on linux. Reading the test case again it doesn't seems to be timeout-related as it fails right before.
This is the test failure I reliably get:
mix test test/exile/process_test.exs:225
Excluding tags: [:test]
Including tags: [line: "225"]

  1) test process termination await_exit with timeout (Exile.ProcessTest)
     test/exile/process_test.exs:225
     match (=) failed
     code:  assert {:ok, "ignored signals\n"} = Process.read(s)
     left:  {:ok, "ignored signals\n"}
     right: {:ok, "ignored signals\n2024-01-24_00:11:37\n"}
     stacktrace:
       test/exile/process_test.exs:230: (test)

Maybe the assert should be changed instead? I'm not really sure what it's supposed to test.

Understood. This assertion is to synchronize that we script started and trap is called.
We don't really care if the output contains date or now. We will push changes to relax the assertion.


Add build context configuration property

This implements #6.

Starting over with a clean history ...
Closing this one.


Added for sleitnick owned loader AddServices and AddControllers

I thought it was easy to use the installer that sleitnick has.

A


[MINOR][DOCS] Add errors.rst to .gitignore

What changes were proposed in this pull request?
After PR [SPARK-44945][DOCS][PYTHON] Automate PySpark error class documentation, errors.rst file will be automatically generated during document build process.

Add the file python/docs/source/development/errors.rst to git ignore.
Why are the changes needed?
To avoid developers from accidentally adding those files when working on docs.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Manually test.
Was this patch authored or co-authored using generative AI tooling?
No.

cc @itholic @zhengruifeng @HyukjinKwon

late LGTM


About the docs

I found the docs is much more simplified than old version, why some useful info deleted? for example, there are detail informations for use of each layer, dataiter, and so on. but now, it's gone? why? I think   the old one is much more friendly to freshman, however, I can find the use of detail in source code.

docs have been moved to mxnet.io

@mli It seems the doc building is failing. No doc for operators is currently listed here: http://mxnet.io/packages/python/symbol.html

the log at http://mxnet.io:8080/ seems normal. but definitely there is something wrong..

moved to #3446


About vacuum?

Is the vacuum operation blocking? Does Seaweedfs will accept read and write(delete) requests if a vacuum operation is in progress?

Not blocking.
It does accept requests when vacuuming.


ANNOUNCE validation now rejects h.264 tracks that do not provide sprop-parameter-sets in the SDP

Which version are you using?
v0.17.10
Which operating system are you using?

[x] Linux amd64 standard
[x] Linux amd64 Docker
[ ] Linux arm64 standard
[ ] Linux arm64 Docker
[ ] Linux arm7 standard
[ ] Linux arm7 Docker
[ ] Linux arm6 standard
[ ] Linux arm6 Docker
[ ] Windows amd64 standard
[ ] Windows amd64 Docker (WSL backend)
[ ] macOS amd64 standard
[ ] macOS amd64 Docker
[ ] Other (please describe)

Describe the issue
Description
Since https://github.com/aler9/rtsp-simple-server/commit/f7ea9a6b2d2eedb7f6bd3f63ee98cebc169e0f25 rtsp-simple-server rejects ANNOUNCEd h.264 tracks that don't include sprop-parameter-sets in its SDP, which excludes any source who is signalling sps+pps inband.
I saw this similar exception being added but it's on the source end:
https://github.com/aler9/rtsp-simple-server/commit/c7b2ae83df8fb6f87154b719d519480aa9bf6d73
Describe how to replicate the issue
Use an RTSP upstream that doesn't include sprop-parameter-sets in its SDP, e.g.
time="30-11-2021 21:49:39.064" level=info msg="   Media: &{video 0 RTP/AVP 96 <nil> <nil> [] <nil> [rtpmap:96 H264/90000 fmtp:96 profile-level-id=42e01f;packetization-mode=1 control:trackID=0 sendonly]}"

Hello, the server supports proxing streams that don't provide SPS/PPS (and fixes them, since c7b2ae8), but i was not aware of any RTSP client that pushes H264 tracks without SPS / PPS. That check was added exactly to discover any client with this behavior.
What is the name and version of the client?

It is just a custom client which can relay arbitrary rtsp streams which we wrote using gortsplib, I will try to provide a simplified version that demonstrates the behaviour.

It's better not to support this special case in order to avoid problems. You can copy and paste the code in rtsp_source.go in order to add SPS and PPS to streams that don't have them. In the future this feature will be integrated directly into gortsplib's Client.

It's better not to support this special case in order to avoid problems. In the future the server will become smarter and smarter and H264 params are absolutely needed. You can copy and paste the code in rtsp_source.go in order to add SPS and PPS to streams that don't have them. In the future this feature will be integrated directly into gortsplib's Client.

Thanks for the suggestion, because the existing handleMissingH264Params has a lot of internal dependencies it's not really practical to use outside of rtsp-simple-server, but once it's integrated in gortsplib this would be a good option.


Possible bug in read_function?

I was attempting to debug why https://github.com/rust-lang/crates.io/blob/120f8008fb08c21fc6cd239c1100692a0ff487e6/src/tests/record.rs#L310-L370 was returning "Problem's parsing json". Changing the URL to http and then inspecting the traffic w/ wireshark, it looks like the request body is never being sent. https://github.com/rust-lang/crates.io/blob/120f8008fb08c21fc6cd239c1100692a0ff487e6/src/tests/record.rs#L347-L349 is definitely being called, and the buffer passed in is being populated correctly. I'm not sure if this is a bug in crates.io or a bug in curl-rust.

In case it's relevant:
[master][~/builds/crates.io] curl --version
curl 7.43.0 (x86_64-apple-darwin14.0) libcurl/7.43.0 SecureTransport zlib/1.2.5
Protocols: dict file ftp ftps gopher http https imap imaps ldap ldaps pop3 pop3s rtsp smb smbs smtp smtps telnet tftp
Features: AsynchDNS IPv6 Largefile GSS-API Kerberos SPNEGO NTLM NTLM_WB SSL libz UnixSockets

I think this may have to do with something liek Expect: 100-continue or something like that, does that sound familiar though?


Smart syncing of Users

Closes #1119
Implementation

[x] Refactor Code to support paginated response.
[ ] Bulk Update Users whose properties have changed.

Details

This PR is directly linked with the Site repo PR https://github.com/python-discord/site/pull/378

This PR uses the changes made in the above-mentioned PR.

Only merge this PR after the Site PR is merged.

This PR will be ready for review when the related site PR has been merged.
https://github.com/python-discord/site/pull/378


Enable Catch by FullyQualifiedErrorID

The FullyQualifiedErrorID as described in https://msdn.microsoft.com/en-us/library/ms714465(v=vs.85).aspx is used: "for scripts that handle specific error conditions with specific error handlers."
Currently this can be accomplished with conditional logic such as a Switch ($PSItem.FullyQualifiedErrorID) inside a general Catch block, but it would be nice if the FullyQualifiedErrorID were treated as a first class property for catching errors.
This property is generally more specific than the exception type and always includes the Cmdlet/Function name that generated it. It is easy to create your own using Write-Error with the string ErrorID parameter.

Perhaps this is an area where PowerShell could borrow from C# and have exception handling filters e.g.
catch [Exception] if ($PSItem.FullyQualifiedErrorID -eq ...) {

Although that is starting to feel a bit advanced for a shell scripting language.  :-)

to me, a possible simple syntax would be:
catch 'NoServiceFoundForGivenName,Microsoft.PowerShell.Commands.GetServiceCommand'
{ }

I like this idea and the proposed syntax.
Some thoughts/questions:

Multiple strings should be allowed, like catch "aaa","bbb"
Should we support wildcards, e.g. catch "*GetServiceCommand"

My personal sentiment is that multiple strings should be allowed, and the input type should probably be System.String[]. Wildcards would also provide a very nice shortcut syntax, per the example you put for catch "*GetServiceCommand".

catch "aaa","bbb" say nothing about FullyQualifiedErrorID 😕 Why not filter by any other properties of exception? Like @rkeithhill 's idea:
try {} catch filter() do {}

Things may have changed, but LINQ expression trees did not support filter when I last looked. They have support in the api, but no code generation support, I believe due to issues in the JIT.
That doesn't mean we couldn't implement exception filtering anyway, but it might not work like it does in C# (e.g., unwinding behavior might differ).
I think using an exception filter will be less obvious to many folks - it's more verbose. Of course it's more powerful, but I doubt that power is needed in PowerShell much.

Another option. The catch expects types and we cannot break it. Therefore we need a prefix to say that  next is not a type, but something else. It was also good for UX to use a tab completion.
try {}
catch : FullyQualifiedErrorID  "aaa", "bbb" {}
catch ( FullyQualifiedErrorID )   "aaa", "bbb" {}

@iSazonov I know this is an ancient issue but it annoyed me enough that there wasn't a short way to do this I looked it up. Was there any movement on this or is it still up for grabs?

@iSazonov I know this is an ancient issue but it annoyed me enough that there wasn't a short way to do this I looked it up. Was there any movement on this or is it still up for grabs?

Was there any movement on this or is it still up for grabs?

It is still up for grabs. You can continue the discussion.

Was there any movement on this or is it still up for grabs?

It is still up for grabs. You can continue the discussion.

In that case do we really need a special syntax? Why not just take the fully qualified as a string and determine logic based on whether it is a type definition or a string?
catch [exception] {
}
vs
catch 'FullyQualifiedErrorId' {
}

In that case do we really need a special syntax? Why not just take the fully qualified as a string and determine logic based on whether it is a type definition or a string?
catch [exception] {
}
vs
catch 'FullyQualifiedErrorId' {
}

I think PowerShell parser would allow this.
https://github.com/PowerShell/PowerShell/blob/c406f9fe68b7bee1bc4695f70d9dba86b3061ad4/src/System.Management.Automation/engine/parser/Parser.cs#L5450

I think PowerShell parser would allow this.
https://github.com/PowerShell/PowerShell/blob/c406f9fe68b7bee1bc4695f70d9dba86b3061ad4/src/System.Management.Automation/engine/parser/Parser.cs#L5450


enum support

Support of the RAML enum property would really help us in providing complete documentation.

Added enum support in 0.2.0


Some special characters in Passwords will result in an error

Expected Behavior

If you use special chars like ¤$ in your password, Invoke-Webrequest will give you an error, this is because powershell uses UniCode wheres as the web request expects UTF8
Current Behavior

Possible Solution

$result = Invoke-RestMethod -Uri $uri -Method Post -ContentType "application/$Format" -Headers $headers -Body  ([System.Text.Encoding]::UTF8.GetBytes($json))
Force the json to be loaded as UTF8.
Steps to Reproduce (for bugs)

New-PasswordStatePassword -ApiKey $ADUserListCred -PasswordListId 49 -Username ctn -Password ('1dsdsdsdfsdsd¤234' | ConvertTo-SecureString -AsPlainText -Force) -ExpiryDate '15-10-2020 14:37:30' -Title test1234 -Verbose

Context

I am adding some extra stuff, so will do a PR when I get that worked out.
Your Environment

Module version used:
Operating System and PowerShell version:

Awesome. Thanks for finding this!


Update to fcl 0.6.1 and ci build for linux/win/mac using github actions

This pull request kind of combine #21 and #18:

Update to 0.6.1 with #21 but fixed to be cross-platform
Add windows build like #18 but:

based on fcl 0.6.1
same setup.py for all platform
add setup.cfg for static metadata and pyproject.toml to fine tune ci options
platform specific build script for dependencies
using github actions as ci provider to allow build simultaneously on linux/mac/windows.

This is awesome! I checked with @mmatl a while back and he was cool with me merging one of the PR's updating to the latest version of FCL and the cross-platform stuff is also awesome. This looks like it did the work to combine those PR's and check via multiplatform builds. I'm happy to review/test/merge once builds/tests/conflicts are resolved, unless someone has strong objections.

Thanks for the big PR! @mikedh @CyrilWaechter just let me know when this is fully ready and I can stage a deploy

@mikedh @mmatl  I did not expect an answer. Happy to see that the repo is more alive than I thought :smiley: .

I have rebased my branch on top of master to allow cleaner merge
I have udated readme, setup.cfg, dockerfile and travis (in case you keep travis)
I have split github actions workflows to upload wheels only on release

Let me know if you want me to fix/change something else.

@CyrilWaechter Looks good to me! I'll go ahead and merge it now.

 Getting those PR's across the line is a ton of work, thanks for taking it on!
I installed the wheels generated via this PR built for 3.8/manylinux, and with one minor issue my upstream tests worked. I did have to change data I was passing from float32 to float64 to get upstream tests to pass:
Traceback (most recent call last):
  File "/home/mikedh/trimesh/trimesh/collision.py", line 204, in add_object
    t = fcl.Transform(transform[:3, :3], transform[:3, 3])
ValueError: Buffer dtype mismatch, expected 'double' but got 'float'
ValueError: Buffer dtype mismatch, expected 'double' but got 'float'
Exception ignored in: 'fcl.fcl.numpy_to_vec3d'

If fcl.numpy_to_vec32 requires a float64/double, should it always convert in that function via a .astype?
Only other thought is I think we should probably drop Travis completely and just use Github actions.

@mjd3 Could you merge this PR and do a deploy? I no longer have access rights to this repo, it appears.

I installed the wheels generated via this PR built for 3.8/manylinux, and with one minor issue my upstream tests worked. I did have to change data I was passing from float32 to float64 to get upstream tests to pass:
Traceback (most recent call last):
  File "/home/mikedh/trimesh/trimesh/collision.py", line 204, in add_object
    t = fcl.Transform(transform[:3, :3], transform[:3, 3])
ValueError: Buffer dtype mismatch, expected 'double' but got 'float'
ValueError: Buffer dtype mismatch, expected 'double' but got 'float'
Exception ignored in: 'fcl.fcl.numpy_to_vec3d'

If fcl.numpy_to_vec32 requires a float64/double, should it always convert in that function via a .astype?

Sorry. I have no idea. @DmitryNeverov did the core work. I just fixed bvh path and work on the packaging side. On my side I just checked that all test were passing and that I was able to use clash detection tool from BlenderBIM Add-on which currently use python-fcl.

@CyrilWaechter
Glad to see this eventually got some traction, thanks for pushing it forward.
I've left suggestions above that should fix
ValueError: Buffer dtype mismatch, expected 'double' but got 'float'

that @mikedh was facing.

Awesome thanks @DmitryNeverov @Pebaz @CyrilWaechter for the fixes and all the work on the upgrade! I just checked the regenerated wheels and they fixed the only minor issue I was seeing. It looks like I still have merge privileges on this repo and I'm happy to merge this (I think it's ready to go), although I think the CI gnomes won't release to PyPi correctly until we do the following:

@mmatl could you generate a PyPi repo access token for python-fcl?
Could someone with admin on this repo (@mjd3?) add that token as PYPI_TOKEN (or something) secret to Github Actions? It looks like I can merge stuff here but not add secrets.
I'll delete .travis.ci and add the PyPi release step in a followup PR.

That sound OK?

@mikedh Sorry for the delay! Token has been generated, and @mjd3 will take care of getting it added to the repo's secrets. Feel free to perform the merge and add the github actions PR as soon as you have time.

@mikedh token is added as PYPI_API_TOKEN to the repo's secrets. Let me know if you need any assistance with the GH Actions PR (although you probably have more experience with that than me)!

Awesome thanks @mjd3 @mmatl! I'll block off an afternoon and get this released, I'll let you know if I run in to trouble haha.

Hi there,
Thanks a lot for this update,
Any chance it will be released soon?
Cheers


Qwen1.5 lora

Implement the lora of Qwen1.5 model with reference to llama's lora

Are you observing issue inferencing LoRA with current main branch after the merge of #3177?

Closing as superseded by #9622


[CodeComplete] Fix a crash when completing in the signature of a function annotated with result builder

When we are completing inside a function signature, the function doesn’t have a body. We were still running PreCheckResultBuilderApplication, which crashed if the body was nullptr.
rdar://111489024

@swift-ci Please smoke test

@swift-ci Please smoke test


Updated gallery

updated artworks as per the request.
added back to gallery button
replaced hard coded address and age with real information
adjusted layout so that the actual size of the artwork images are displayed in the artwork vote page
adjusted layout to match the figma design for both mobile and desktop

I think some slight modifications to the width properties make the artwork page look a little better

line 50 Link being 'md:w-1/3'
line 33 'md:w-3/5'

I think some slight modifications to the width properties make the artwork page look a little better

line 50 Link being 'md:w-1/3'
line 33 age + country etc 'md:w-3/5'

Hi I have updated the width properties~ @Isaac-Best


Integration tests on ping functionality

To check interoperability between a Micro XRCE-DDS Client and Agent, in terms of checking from the client the presence of an up-and-running agent, two pull requests were created, on both endpoints, to ping the agent without the need of establishing a session:  https://github.com/eProsima/Micro-XRCE-DDS-Client/pull/180 and https://github.com/eProsima/Micro-XRCE-DDS-Agent/pull/203.
Integration tests should be included testing this functionality, for all available transports.

Done: https://github.com/eProsima/Micro-XRCE-DDS/pull/61


UI Shell Docs Improvements

Overhaul of the UI Shell guidance on the Carbon website.
Better guidance on why teams/products should use this component. How and when to use it.

replaced by https://github.com/ibm/carbon-components/issues/2338


docs: Imports tutorial docs

@gumuz where is this linked from? Shouldn't there be a link here? https://github.com/GetStream/stream-cli/blob/master/docs/use_cases.md

@gumuz where is this linked from? Shouldn't there be a link here? https://github.com/GetStream/stream-cli/blob/master/docs/use_cases.md

yeah, that would've been my followup question, thanks :)

I think looks fine, I suggest we collapse big blocks by default but feel free to ignore if you feel easier to navigate currently


Expose multi-draw calls

For GL: https://www.khronos.org/opengl/wiki/Vertex_Rendering#Multi-Draw

As @nical suggested, we could record those calls automatically by the backend side. We know when the pipeline/shaders change, and we know if multi-draw is supported, so this should not be difficult to achieve. Bonus is - less API surface.


Nicer docs

added DIP method with ConvDecoder arch
added DIP demo
added MOI self-supervised learning demo
updated dataset docs
added custom sampler demo
small fixes to ei demo docs

Checks to be done before submitting your PR

[x] python3 -m pytest tests/ runs successfully.
[x] black . runs successfully.
[x] Updated docstrings related to the changes (as applicable).
[] Added an entry to the CHANGELOG.md (as applicable) (to come).

codecov is a bit down since I didn't add tests for the dip


CMS wymeditor layout breaking

Wymeditor elements of class "ui-tabs-hide" (I believe) are being set at width:0 or width:1px and do not extend back to 958px when their corresponding tab is clicked

I simply can't reproduce :( @gogogarrett and @ugisozols can you try?

Sorry, I can't reproduce it either.


[Communication] Adding ACS NetworkTraversal 2022-03-01 API - PENDING REVIEW

MSFT employees can try out our new experience at OpenAPI Hub  - one location for using our validation tools and finding your workflow.

This swagger introduces an optional request parameter to the ACS NetworkTraversal API allowing users to specify the TTL for TURN credentials when fetching a Relay Configuration.
Changelog
Add a changelog entry for this PR by answering the following questions:

What's the purpose of the update?

[ ] new service onboarding
[X] new API version
[ ] update existing version for new feature
[ ] update existing version to fix swagger quality issue in s360
[ ] Other, please clarify

When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
2022-02-30
When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
2022-03-01
If updating an existing version, please select the specific langauge SDKs and CLIs that must be refreshed after the swagger is published.

[x] SDK of .NET (need service team to ensure code readiness)
[x] SDK of Python
[x] SDK of Java
[x] SDK of Js

Contribution checklist:

[X] I commit to follow the Breaking Change Policy of "no breaking changes"
[X] I have reviewed the documentation for the workflow.
[X] Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.

And you need to fix the Avocado error, which is basically saying that you need to update the readme.md to add a tag for your new api-version, pointing to the new version of the API defn.

/azp run

@tjprescott I have removed the "PENDING DEPLOYMENT" tag from the title, since this swagger is now ready to be merged. Side note, related to the recent GA noise, I changed the API version to include the -preview


ROS Melodic on Raspberry Pi 4 [Debian Buster] + RPLIDAR A1M8

Describe the process of compiling ROS Melodic from source on the new Raspberry Pi 4.

The above issue has been completed and uploaded. Please refer to the below file for detailed information.
ROS Melodic on Raspberry Pi 4 [Debian Buster] + RPLIDAR A1M8.md


Message deserialization optimization

In this PR, modifiers message deserialization now avoids unnecessary allocations.

Coverage remained the same at 46.984% when pulling 30c255a7afd2f824346b519a04be32e721608ce5 on msgs-opt into 4405ea45e3acebd5d145dbf9a8c33638b5bd7f3f on master.


feat: from method on all rune classes

Currently, we instantiate Rune subclasses from constants as follows.
const multisig = Rune
  .constant({
    signatories: [alexa, billy, carol]
      .map(({ publicKey }) => publicKey),
    threshold: 2,
  })
  .into(MultisigRune, chain)

Following this PR we can express this as...
const multisig = MultisigRune.from({
  signatories: [alexa, billy, carol]
    .map(({ publicKey }) => publicKey),
  threshold: 2,
}, chain)

Discussed offline: the typing of this won't work as we hoped it would; we'll leave it to pattern libraries to write their own analogs (including variants like fromHex etc.)


rdopkg review-spec fails on rdo-FTBFS reviews

rdopkg review-spec does not handle amending reviews autogenerated  on trunk build failures[1]
$ git-review -r review-origin -d 1064
Downloading refs/changes/64/1064/1 from gerrit
Switched to branch "review/rdo_trunk/rdo-FTBFS"
...fix spec...
$ git commit -a --amend
$ rdopkg review-spec
## get_package_env
## review_spec
git review -r review-origin review/rdo_trunk/rdo-FTBFS
The branch 'review/rdo_trunk/rdo-FTBFS' does not exist on the given
remote 'review-origin'. If these changes are intended to start a new
branch, re-run with the '-R' option enabled.
command failed: git review -r review-origin review/rdo_trunk/rdo-FTBFS

Branch "review/rdo_trunk/rdo-FTBFS" should not be specified, it is taken from .gitreivew and the git best-practice is to use local topic branches vs submitting from the local mirror of the target branch.
[1] https://review.rdoproject.org/r/#/q/topic:rdo-FTBFS

This is the command I got from rpmfactory folks which doesn't require .gitreview at all as discussed in #63


Use WDS tokens in anvil config

Related conversation https://theappsmith.slack.com/archives/C04P60V0VQE/p1702000601536169

Develop a skeleton component that will use WDS tokens. The current implementation of the component can be found here — https://github.com/appsmithorg/appsmith/blob/release/app/client/src/widgets/Skeleton.tsx


Segmentation fault if menu is clicked while alert is visible

On OS X 10.13, the following gives me a segfault.
import rumps

class BarApp(rumps.App):
    @rumps.clicked("Test")
    def test(self, _):
        rumps.alert("Now click BarApp twice, then click OK.\nResult: segfault")

BarApp("BarApp").run()

To reproduce:

Select BarApp -> Test on the BarApp menu.
An alert box appears. Without dismissing the alert, click BarApp twice in the menu bar. The menu appears after the first click (with all menu items disabled, strangely), and is then dismissed after the second click.
Click OK in the alert box to get Segmentation fault: 11.

Changing rumps.alert to rumps.window gives the same behaviour.

I'm getting a segmentation fault 11 just by importing rumps.
Macos Mojave
Python 3.9 installed via homebrew

Are these Intel or M1 chips?

I'm on Intel.


Figure out if Javalin#stop() triggers a graceful Jetty shutdown

I was hoping to validate whether performing a Javalin#stop() action will perform a graceful shutdown of Jetty and any associated servlets, such that all outstanding requests would be served before shutting down Jetty?

Javalin just calls stop() on the Jetty Server, which I think is supposed to be graceful. I haven't checked though. If it turns out to not be, and it's possible to instruct Jetty to stop gracefully, you can switch out the server using app.server(() -> myGracefulServer)

I'll have to take a look. I know with Undertow you have to manually configure a graceful shutdown request handler wrapper.

Great, let me know what you find out. We should consider making it the default behavior if it isn't already.

Hey @tipsy; you're welcome. I am looking at your v2 code and jettyServer's type isn't very apparent. When I look up it's field, I see a call to JettyServerUtil.defaultServer();, which is implemented in some Kotlin code of yours that gets really confusing really quick for me.
I saw that same comment from @gregw, but I wasn't 100% sure if that was still valid based on some of the other pages I listed. Maybe it is though.
That said, I could do what you said. Write some request handler that purposely takes a long time and figure out a way to stop the server and still validate that the request completes. I'm in the middle of a big project right now, but when it's done I wouldn't mind taking a look at this.

jettyServer is a Server, more specifically as org.eclipse.jetty.server.Server:
The initialization code:
fun defaultServer() = Server(QueuedThreadPool(250, 8, 60_000)).apply {
    server.addBean(LowResourceMonitor(this))
}

Can be written like this in Java:
public static final Server defaultServer() {
    Server server = new Server(new QueuedThreadPool(250, 8, 60_000));
    server.getServer().addBean(new LowResourceMonitor(server));
    return server;
}

That said, I could do what you said. Write some request handler that purposely takes a long time and figure out a way to stop the server and still validate that the request completes. I'm in the middle of a big project right now, but when it's done I wouldn't mind taking a look at this.

That would be great, let me know if you need any assistance.

Thanks for that comment. I had no idea what .apply {...} meant. I still am not 100% sure, but at least I know what's happening :smile:

It's a really nice function. The official docs says that it Calls the specified function block with this value as its receiver and returns this value..
In more plain English:

Inside the scope of apply the object you called apply on can be referenced as this (which can be omitted, just like in Java).
apply returns the object you call it on

It makes working with Java objects in Kotlin simple, ex:
public Person newJohn() {
    Person john = new Person()
    john.setName("John");
    john.setAge(37);
    return john;
}

fun newJohn() = Person.apply {
    name = "John" // same as this.name (could also be written as this.setName())
    age = 37
}

Oh, very nifty!

Should probably make sure the setStopTimeout value is sane: https://www.eclipse.org/jetty/javadoc/9.4.11.v20180605/org/eclipse/jetty/server/Server.html#setStopTimeout-long-

So much Kotlin test code. Too bad I don't know Kotlin. Hrmmm... I might have to learn enough Kotlin so I can actually write a test.

It's completely fine if you prefer writing the test in Java.

That's nice to hear. I was just trying to find the proper test module to add it in, and I'm wondering if there isn't one that really fits. Should I just create a new module related to graceful shutdowns? Also, I don't seem to see signs of TDD style testing. Do you more care about pure functional testing?

That's nice to hear. I was just trying to find the proper test module to add it in, and I'm wondering if there isn't one that really fits. Should I just create a new module related to graceful shutdowns?

Yup, feel free to create a new one.

Also, I don't seem to see signs of TDD style testing. Do you more care about pure functional testing?

I'm not a big fan of mocking, all the tests are functional/blackbox. I think this approach will work well for your test too.

Yes, no worries, I'm a big mocker, but I definitely respect it's not the only way to go. So, my plan is to have a functional test that will start up Javalin with TestUtil, automatically configured for graceful shutdown. Trigger a long(ish) running request by setting up some request handler with a Thread#sleep or some such, simultaneously trigger a shutdown slightly after starting the request, but before it has a chance to complete, and then validate that the request returns with a correct result, while also verifying that the server actually did shut down.
I'll have to somehow utilize threading to have both events happen simultaneously. I'm also assuming that you don't want to have any tests that take too long to run.

No more than a second, two tops. Some of the tests are @Ignored, and are not part of the normal test suite. If you want to test a setStopTimeout of ten seconds I think it should be enough to run the test manually.


Longevity of IPFS content referenced in issues ( Github, Mailing lists, etc )

NOTE: This issue is orthogonal / the opposite of github issues on IPFS
A non-trivial portion of bugreports / issues / design documents currently available on github etc do refer to IPFS file content ( Qm... ). A staggering portion of this content does not currently resolve: either being lost for good or sitting on nodes not currently online. To make matters worse much of this content is a direct product of ProtocolLabs members, which has implications on the perceived health of the product.
Some sort of quick-and-dirty solution needs to be implemented as soon as feasible to systematically crawl and pin content across at least github issues/pulls, due to the high visibility of resolution failures.
There would be implications with potential for abuse of the pinning service / moderation evasion, but these should be dealt with as they arise, and not get in the way of "the simplest thing that can/should exist today"
/cc @VictorBjelkholm @Mr0grog @whyrusleeping

Yeah that's a thing I've been thinking about too. Instead of a crawler, there should be a webhook listener that scans for certain events and pins the respective stuff. In this case here mostly for CIDs in comment texts, but similar tools could add new commits on our repos to IPFS.

Commits that updates .gx/lastpubver and package.json in go repos should also result in pins.

And another tangent to this issue: the blogpost by @diasdavid referenced in the ipfs-npm docs is no longer available :(

Yeah, I think there are two areas where we need to immediately improve. First is something that goes through all (yeah...) existing content within our organizations and checks if it's actually pinned somewhere. We should be able to run this on some interval and it should report issues with links to the affected content.
Second is moving forward, a webhook-service that analyses all new content and makes sure it's pinned.
Side-note: @mib-kd743naq you can now find that blogpost here: http://daviddias.me/blog/stellar-module-management/ seems @diasdavid changed the structure of the blog.

@lgierth @VictorBjelkholm Sounds like we are all agreed on needing to do something for this. Where does this work need to happen and how can we best track it? Who can take responsibility for it?

Instead of a crawler, there should be a webhook listener that scans for certain events and pins the respective stuff.

I think there are two areas… First is something that goes through all (yeah...) existing content within our organizations and checks if it's actually pinned somewhere… second is moving forward, a webhook-service that analyses all new content

Ha, seems like we have different views here. I think it might make sense to focus first on what we can do going forward — new posts/content should usually not have the problem we’re trying to prevent (content not being resolvable), so they will be pretty easy to handle. Old stuff will be much more likely to be unresolvable, and every unresolvable link will be a complicated project to try and find. We may not even always be able to solve it. That makes new stuff a much simpler problem.

@lgierth @VictorBjelkholm is there any part of this a community member can write or prototype that you can then fit into PL’s infrastructure? e.g:

Library of functions that, given a GitHub API object for posts/commits/etc., identify a list of IPFS content paths/references?
Webhook handling server that pipes things through the above functions and then…

Calls some pluggable function/module?
Calls another webhook address that can be configured?
Sends commands to pinbot? (any reference for how to do that?)

Script that, given a repo, pulls all the various objects (e.g. issue comments, commits) (maybe which types of objects is configurable) that might have IPFS content paths and runs them through the above functions and then does similar to the webhook server described above?

If someone could work on those, is there a preferred language or toolset that makes it easy for you to integrate?
Trying to think of how folks in the community can pitch in on this, since I know you time is limited and I’m sure there are people who’d love to help.

I feel like the most helpful entrypoint would be to just have a github-adapter to work with https://github.com/ipfs/ipfs-hubot (which should basically be plug-and-play, except a regex to grab hashes from posts/commits/etc). ipfs-hubot is also deployed already (somewhere, unsure of where actually) so would just have to add the adapter and deploy the changes.


Earthquake early warning system technology.

@KOSASIH can you please provide a description of what this pull request is intended to do? This repository is a static starting place for the OpenEEW project rather than a host of code itself (which is in other repos under the same org).

@KOSASIH can you please provide a description of what this pull request is intended to do? This repository is a static starting place for the OpenEEW project rather than a host of code itself (which is in other repos under the same org).

Agreed. If you join us on Slack it may be easier to discuss this with the
team.
On Tue, 5 Jan 2021 at 11:51, Daniel Krook<EMAIL_ADDRESS>wrote:

@KOSASIH https://github.com/KOSASIH can you please provide a
description of what this pull request is intended to do? This repository is
a static starting place for the OpenEEW project rather than a host of code
itself (which is in other repos under the same org).
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/openeew/openeew/pull/18#issuecomment-754794072, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/ABP5GHJZENYOXHB7DI635ULSYNGS7ANCNFSM4R6R5UXQ
.

--
Andres Meira
m +52 (55) 12246468
*skype *andresmeira

Agreed. If you join us on Slack it may be easier to discuss this with the
team.
On Tue, 5 Jan 2021 at 11:51, Daniel Krook<EMAIL_ADDRESS>wrote:

@KOSASIH https://github.com/KOSASIH can you please provide a
description of what this pull request is intended to do? This repository is
a static starting place for the OpenEEW project rather than a host of code
itself (which is in other repos under the same org).
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/openeew/openeew/pull/18#issuecomment-754794072, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/ABP5GHJZENYOXHB7DI635ULSYNGS7ANCNFSM4R6R5UXQ
.

--
Andres Meira
m +52 (55) 12246468
*skype *andresmeira

Thank you Sir, an honor for me to join with a great team.
🙏

Thank you Sir, an honor for me to join with a great team.
🙏


Dont throw model exception on Backend_Application while showException is off

1. Why is this change necessary?
It can spam logs or services like rollbar, sentry etc,  If someone requests /backend/application
2. What does this change do, exactly?
Throws the exception only if showException is enabled in config.php
3. Describe each step to reproduce the issue or behaviour.
4. Please link to the relevant issues (if any).
#1418
5. Which documentation changes (if any) need to be made because of this PR?
6. Checklist

[ ] I have written tests and verified that they fail without my change
[ ] I have squashed any insignificant commits
[ ] This change has comments for package types, values, functions, and non-obvious lines of code
[X] I have read the contribution requirements and fulfil them.

We decided to reopen #1418 as the solution provided there is much better for handling this problem.


bot wont boot up : ValueError: Expecting property name

Expected Behavior
start normally
Actual Behavior
-> # sudo python pokecli.py -cf ./configs/config.json
[06:46:21] PokemonGO Bot v1.0
Traceback (most recent call last):
  File "pokecli.py", line 250, in <module>
    main()
  File "pokecli.py", line 229, in main
    config = init_config()
  File "pokecli.py", line 57, in init_config
    load.update(json.load(data))
  File "/usr/lib/python2.7/json/__init__.py", line 290, in load
    **kw)
  File "/usr/lib/python2.7/json/__init__.py", line 338, in loads
    return _default_decoder.decode(s)
  File "/usr/lib/python2.7/json/decoder.py", line 366, in decode
    obj, end = self.raw_decode(s, idx=_w(s, 0).end())
  File "/usr/lib/python2.7/json/decoder.py", line 382, in raw_decode
    obj, end = self.scan_once(s, idx)
ValueError: Expecting property name: line 22 column 7 (char 607)

Steps to Reproduce
git clone latest build on dev branch
doing initial step
edit the config.json file
Other Information
OS: Debian x64_86
Git Commit: c4c34875c7af8d8ffdcc18e76b0ea0f0146c2422

I committed fix, please test.

after git pull :
-> # sudo python pokecli.py -cf ./configs/config.json
[07:08:16] PokemonGO Bot v1.0
Traceback (most recent call last):
  File "pokecli.py", line 250, in <module>
    main()
  File "pokecli.py", line 229, in main
    config = init_config()
  File "pokecli.py", line 57, in init_config
    load.update(json.load(data))
  File "/usr/lib/python2.7/json/__init__.py", line 290, in load
    **kw)
  File "/usr/lib/python2.7/json/__init__.py", line 338, in loads
    return _default_decoder.decode(s)
  File "/usr/lib/python2.7/json/decoder.py", line 366, in decode
    obj, end = self.raw_decode(s, idx=_w(s, 0).end())
  File "/usr/lib/python2.7/json/decoder.py", line 382, in raw_decode
    obj, end = self.scan_once(s, idx)
ValueError: Expecting property name: line 22 column 7 (char 607)

im getting the same error as above with lastest pull. just to confirm

I get a different error:
$ python pokecli.py
[13:23:45] PokemonGO Bot v1.0
Traceback (most recent call last):
  File "pokecli.py", line 250, in <module>
    main()
  File "pokecli.py", line 229, in main
    config = init_config()
  File "pokecli.py", line 55, in init_config
    if os.path.isfile(config_arg):
  File "/Users/***/Desktop/PokemonGo-Bot/_dev/PokemonGo-Bot/lib/python2.7/genericpath.py", line 37, in isfile
    st = os.stat(path)
TypeError: coercing to Unicode: need string or buffer, NoneType found

Ensure that there is no comma separator in the last json value.

here is the last line of my json config file, just to eject this possibility
{
    ...
    "use_lucky_egg": false,
    "evolve_captured": false,
    "catch": {
      "any": {"catch_above_cp": 0, "catch_above_iv": 0, "logic": "or"},
      // "Rattata": { "always_catch" : true }
    },
    "release": {
      "any": {"release_below_cp": 500, "release_below_iv": 0.8, "logic": "and"},
      // "Rattata": { "always_release" : true }
    }
}

Try to completely remove the catch and release keys, and also the leftover comma friom the "evolve_captured" key afterwards.

@mehdi-S you have a malformed son in the configuration. Check for commas

I've been following this thread and after cleaning the catch and release keys I used the command posted by @mehdi-S sudo python pokecli.py -cf ./configs/config.json and now everything seems to be working fine 👍

what you see is exactly the defaut config.json.exemple with my value, so maybe the typo is also in the default file and need to be corrected
works fine without the catch/release key to confirm

Is the parser fine with the // comments in the JSON structure?

@ngkogkos
trying with and without, not the issue here

now the bot is working fine but dont release anything anymore

The example config looks like this:
"release": {
      "any": {"release_below_cp": 0, "release_below_iv": 0, "logic": "or"},
      // "Rattata": { "always_release" : true }
    }

but since the last line is commented out there is one comma too much. It should be
"release": {
      "any": {"release_below_cp": 0, "release_below_iv": 0, "logic": "or"}
    }

right?

yep, not a valid JSON with that last comma
Error: Parse error on line 9:
...logic": "or"		},		// "Rattata": { "alw
---------------------^
Expecting 'STRING', got 'undefined'

Exactly. Same for the "catch" key also

had the same issue, after deleting the catch lines it works only if i put the config in the root direct...on windows it doestn work in the configs file....and realy...do we need for only ONE file a dir?! :/

@tpmodding files could increase in future

@tpmodding you maybe are on the master branch, where configs/ folder dont exist already ?

no i'm an dev, i have the dir but it works only when i put the file to pokecli.py and start with python pokecli.py -cf config.json

@tpmodding dont you try to use /configs/ instead of ./configs/  or configs/ ?

it shouldn matter? if i start with "python pokecli.py" shouldnt it auto-load from configs/config.json? or am i wrong?

Change the last configs to:
    "catch": {
      "any": {"catch_above_cp": 0, "catch_above_iv": 0, "logic": "and"}
    },
    "release": {
      "any": {"release_below_cp": 340, "release_below_iv": 0, "logic": "or"}
    }
}

The problem is the comma....

for the moment, this issue is closed
Solution :
Don't forget is you want to get rid of the // "Rattata": { "always_release" : true } line in
"release": {
      "any": {"release_below_cp": 0, "release_below_iv": 0, "logic": "or"},
    }

object, to also remove comma after
"any": {"release_below_cp": 0, "release_below_iv": 0, "logic": "or"},
line like so
"any": {"release_below_cp": 0, "release_below_iv": 0, "logic": "or"}
do the same for the catch line and you're good to go !


Is there any way to achieve a more HD raw image?

Hello, I am using ggkegg for drawing
library(ggkegg)
g<-pathway("hsa01240")
ggraph(g,aes(x=x,y=y),layout="auto")+
  overlay_raw_map()+
  theme_void()

I would like to save a more high resolution image, such as what pathview draws. But pathview can't specify multiple conditions for plotting, and it's not as friendly as ggplot2.
Looking forward to your reply, thanks!

Hi, thanks for raising this important point.
ggkegg uses annotation_raster to incorporate PNG images into the ggplot layer. ggkegg by default used interpolation, however, this makes the image blurry in some instances. Would you try disabling this option and using ggkeggsave function to save the image?
As it depends on the graphic devices used, we can also use another approach, that combines the image of geom layers and the original PNG image. I implemented the output_overlay_image function in the devel branch (installation by devtools::install_github("noriakis/ggkegg", ref="devel")).
This outputs two images and combines them inside the function, yielding the same resolution as the original image.
However, this approach must extract the main panel from the ggplot object, and thus the legend (or the title, the axis, etc... made by ggplot) will be omitted from the output. The legend can be placed inside the main panel (e.g. theme(legend.position=c(0.1, 0.1))), or can be placed outside the image by specifying the option (with_legend_image).
The examples are now described in the bookdown.
I hope this helps and if you have any opinions or a better way of rendering, please feel free to report them!

Thank you very much, I am able to save high res images using ggkeggsave, however when I save a pdf, the clarity is nowhere near as good as a png.

But I can use convert in linux to make png2pdf also achieve good results
convert test.png test.pdf

Glad that it helped. As you stated, saving in PDF file format is not
feasible for saving in high resolution as the original PNG image is
rasterized.
I think it is appropriate to convert it that way, and thanks for sharing.
On Sun, Feb 4, 2024 at 10:43 AM sunliangxing @.***>
wrote:

Thank you very much, I am able to save high res images using ggkeggsave,
however when I save a pdf, the clarity is nowhere near as good as a png.
image.png (view on web)
https://github.com/noriakis/ggkegg/assets/71911098/3d251de9-80c5-464a-b009-924f407bfbd8
But I can use convert in linux to make png2pdf also achieve good results
convert test.png test.pdf
image.png (view on web)
https://github.com/noriakis/ggkegg/assets/71911098/355fdf0a-6a63-4cc8-9d51-6f28d186cfd8
—
Reply to this email directly, view it on GitHub
https://github.com/noriakis/ggkegg/issues/19#issuecomment-1925532251,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AHNHVPZV3JEXY4Z5NAT76J3YR3RVBAVCNFSM6AAAAABCWKTF7CVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMRVGUZTEMRVGE
.
You are receiving this because you commented.Message ID:
@.***>


UNUSED_METHOD_ARGUMENT is triggered with a function argument

For example:
public string function myFunction(function doSomething){
    return doSomething();
}

UNUSED_METHOD_ARGUMENT: Argument dosomething is not used in function. Consider removing it.

I have confirmed that the example given above incorrectly reports the UNUSED_METHOD_ARGUMENT issue.
However, I have found that it does not report that issue when including the scope as below:
public string function myFunction(function doSomething){
    return arguments.doSomething();
}


Create Add Foreign Key Function

Created CI_DB_forge->add_foreign_key() function and added documentation to user guide.

Slightly different implementation of #4275 to keep inline with existing CI_DB_forge->add_key() functionality.

Good work on this @EpicKris , hopefully it'll be merged soon :)

@narfbg Could you review this pull request and let me know if I should make any changes? Thanks!

Did you not see my comment on #4275?

@narfbg Sorry, but I don't understand why this would only work for MySQL and not other database drivers?

Because I'm yet to see a query other than very, very basic SELECT or DELETE to work across all databases. You just can't assume what works on MySQL will work for everything else ... asking "why wouldn't it" isn't serious.
Obviously, nobody has all of them in order to test, but you can at least consult different documentations to confirm it.

I'll test this with different database drivers and work out the differences, almost certain this will work for MySQL, PostgreSQL, and Microsoft SQL though.

Those are only 3 out of ~10 ... and I'm pretty sure it doesn't work out of the box on SQLite.

@narfbg What if a database doesn't support foreign keys?

Well then it obviously will fail, but it has to fail gracefully, not by virtue of the query just refusing to execute. :)

@EpicKris Yeah I can put some time aside to review documentation on this to see where it will fail, although re-factoring bits of code may take me longer as i'm also a little stacked at the moment though. This is a feature I need in pretty much every project though so willing to invest time into getting this into an acceptable state for a release candidate

@steve-goodwin Likewise, I'd like to get this in as soon as possible as I'd like to use it for a school project.

@steve-goodwin I'm going to start having more time on my hands, so will look into this, I also want a way of creating and deleting foreign keys independently of creating a table, deleting foreign keys may be required for downgrading migrations.

@EpicKris - sorry I've been flat out on other projects, had a look through your commits and looking good. What's left to get this feature complete and passing?

@EpicKris - sorry I've been flat out on other projects, had a look through your commits and looking good. What's left to get this feature complete and passing?

@steve-goodwin, I've also been flat out busy with my new job, obviously the build is failing at the moment, so that needs checking out, and I'd like a way to be able to add and drop foreign keys independently of creating a table (adding and dropping foreign keys may be required for migrations, etc…), and then each database driver needs to be checked for compatibility and updated accordingly.


Anyone who can code history page.

Describe the Issue
Anyone who can code the history page. we will provide UI and documentation.

@HarshKumarraghav I can take this

@HarshKumarraghav can i take this issue


Add automated build in hub.docker.com

That would be so much better to use image from docker hub: docker run ankane/pgslice
instead of building it every time with git clone ... && docker build -t pgslice . && docker run pgslice.

Hey @kressh, pushed to Docker Hub. https://hub.docker.com/r/ankane/pgslice/


107 rename folders fix namespace mismatch

This is a continuation of PR https://github.com/aspnet/LibraryManager/pull/551
In that PR, the following namespaces were not created because a class exists with the same name as its folder:

Microsoft.Web.LibraryManager.CacheService
Microsoft.Web.LibraryManager.SemanticVersion
Microsoft.Web.LibraryManager.Vsix.ErrorList

My suggestions are to rename the "CacheService" directory to simply "Cache", remove the "SemanticVersion" folder (since it only contains one file), and rename the 'ErrorList" directory to "Errors".
Partially addresses #107.

I figured since I started working on #107, I might as well continue to get it closed.  I'm completely open to suggestions.


Use Nextflow Executor

At the moment we are using hardcoded  qsub command.
Instead we should use nextflows executors.

We are not using 'qsub' directly anymore, so I will close this issue.


Remove relic prop

Motivation
Remove unused prop to fix <KeyValuePair> was created with unknown prop 'alignIconRight' that breaks unit tests.
Changes
Cleanup
Screenshots
No changes, cleanup only

Ah, haha. KeyValuePair doesn't have the prop?

Not anymore, my bad.


RCTFatal : operator() + 68

Description
I've noticed that a not insignificant number of my iOS users experience the fatal error ( RCTFatal : operator() + 68) in production.
I'm unable to reproduce the bug in local, staging, or production. How can i debug this error further?
Version
0.66.4
Output of npx react-native info
System:
OS: macOS 12.4
CPU: (8) arm64 Apple M1 Pro
Memory: 714.34 MB / 16.00 GB
Shell: 5.8.1 - /bin/zsh
Binaries:
Node: 18.5.0 - /opt/homebrew/bin/node
Yarn: 1.22.19 - /opt/homebrew/bin/yarn
npm: 8.12.1 - /opt/homebrew/bin/npm
Watchman: 2<IP_ADDRESS> - /opt/homebrew/bin/watchman
Managers:
CocoaPods: 1.11.3 - /opt/homebrew/bin/pod
SDKs:
iOS SDK:
Platforms: DriverKit 21.4, iOS 15.5, macOS 12.3, tvOS 15.4, watchOS 8.5
Android SDK: Not Found
IDEs:
Android Studio: 2021.2 AI-212.5712.43.2112.8609683
Xcode: 13.4.1/13F100 - /usr/bin/xcodebuild
Languages:
Java: 11.0.15 - /opt/homebrew/opt/openjdk@11/bin/javac
npmPackages:
@react-native-community/cli: Not Found
react: 17.0.2 => 17.0.2
react-native: 0.66.4 => 0.66.4
react-native-macos: Not Found
npmGlobalPackages:
react-native: Not Found
Steps to reproduce
Unable to reproduce...
Snack, code example, screenshot, or link to a repository

Did you ever solve this? Struggling with this now. Thanks in advance

I think this error is due to an error in your code. For me, I'm trying to access to a property of an object = undefined so my app crash.


Complains incorrectly about persist-credentials

zizmor looks great, thanks!  I ran it, it said I should use persist-credentials: false for actions/checkout.  I read about it, and added it to all my actions.  Running zizmor again still shows all the same warnings:
warning[artipacked]: credential persistence through GitHub Actions artifacts
   --> /Users/ned/coverage/trunk/.github/workflows/kit.yml:149:9
    |
149 |         - name: "Check out the repo"
    |  _________-
150 | |         uses: actions/checkout@eef61447b9ff4aafe5dcd4e0bbf5d482be7e7871 # v4.2.1
151 | |         persist-credentials: false
    | |__________________________________- does not set persist-credentials: false
    |

What am I doing wrong?  The setting is clearly displayed in the warning output.

Thanks for trying it out @nedbat!
I think your workflow syntax is wrong, which is why it's not noticing the change: it should be:
uses: actions/checkout@eef61447b9ff4aafe5dcd4e0bbf5d482be7e7871 with:
  persist-credentials: false

i.e., you need the with: clause.

(This is a good reminder that I should add warnings when the workflow itself has invalid keys, though!)

My bad, I see the syntax now.  Thanks for the quick response!

No problem, thanks for confirming! I'll file a follow-up for making it more clear when the workflow itself isn't the shape GHA expects :slightly_smiling_face:

I currently use https://github.com/mpalmer/action-validator for this purpose and combine it with zizmor.


Support more hash algorithms and other fixes

Improvements

Supports more hash algorithms
Support spaces and case differences in hashes (for config readability)
Consolidate hash verification code
Download incubating releases from incubator release area

Fixes

Run shellcheck and fix reported problems
Supports spaces in paths with better quoting
Stop masking fetch errors by ignoring exit code from fetch script

Nits/Grammar

Use "source" instead of "." for consistency
Remove trivial extra spaces in printed messages/docs
Fix typo "does not exists" to "does not exist"

+1


Specify receiver on a project base instead of globally.

While previous use-cases were ok with a global payment receiver, a generic platform should be able to allow specifying a different receiver per project.

I suggest adding an owner field to the Project class and removing the author extension.


⚠ Bofrost.fr has degraded performance

In ee108df, Bofrost.fr (https://www.bofrost.fr) experienced degraded performance:

HTTP code: 200
Response time: 827 ms

Resolved: Bofrost.fr performance has improved in 3cd572c.


Move LoginModal username and password into instance properties, remove refs

Before submitting, please confirm you've

[x] read and understood our Contributing Guidelines
[x] completed Mattermost Contributor Agreement
[x] executed npm run lint:js for proper code formatting

Please provide the following information:
Summary
Resolves an issue where username and password were not being passed for HTTP basic authentication.
Issue link
Fixes #965
Test Cases
Additional Notes

Not sure which dev is owning reviews on this, assigning one more reviewer.