The generate API always returns the same number of tokens as output nomatter what is min_tokens

Here is the code I am trying
import { pipeline } from '@xenova/transformers';
import { env } from '@xenova/transformers';

let generator = await pipeline('text2text-generation', 'Xenova/LaMini-Flan-T5-783M');
let output = await generator('write a blog on Kubernetes?', {
  max_new_tokens: 512,min_new_tokens:512,min_length:300
});

console.log(output)

So no matter whatever is min_new_tokens or min_length (even if I try one of them only), output just remains same length

Are you sure? Running on my side (just using max_new_tokens), I get this:
let generator = await pipeline('text2text-generation', 'Xenova/LaMini-Flan-T5-783M');
let output = await generator('write a blog on Kubernetes?', {
    max_new_tokens: 100,
});
// Kubernetes is a popular cloud computing platform that allows users to store, manage, and process data on-premises and on the cloud. It is a distributed computing environment that is designed to be scalable, secure, and easy to manage.
Kubernetes is known for its robust security features, including a distributed network architecture, distributed computing, and a distributed database management system. It also offers a wide range of services and tools for developers, including

without max_new_tokens I get:
// Kubernetes is a popular cloud computing platform that allows users to store, manage

This line in the config.json file seem to indicate that indeed the max window for generation is 128. Oddly enough, no runtime error is displayed. A simple fix might just be to crop the past key values to this length. @fxmarty, do you maybe have any ideas here?

In fact, I was able to reproduce this in the python library:
With transformers:
from transformers import pipeline
pipe = pipeline('text2text-generation', 'MBZUAI/LaMini-Flan-T5-783M')
output = pipe('Tell me a story about cheese.', max_new_tokens=500)
len(pipe.tokenizer(output[0]['generated_text'])['input_ids'])
# returns 128

Or with optimum:
git clone https://huggingface.co/Xenova/LaMini-Flan-T5-783M

import onnxruntime as ort
from optimum.onnxruntime import ORTModelForSeq2SeqLM
from transformers import AutoTokenizer, pipeline

model_id = 'LaMini-Flan-T5-783M'
session = ORTModelForSeq2SeqLM.from_pretrained(
    model_id,
    subfolder='onnx',
    use_merged=False,
    encoder_session=encoder_model,
    decoder_session=decoder_model,
    decoder_with_past_session=decoder_model,
    )
tokenizer = AutoTokenizer.from_pretrained(model_id)

encoder_model=ort.InferenceSession('LaMini-Flan-T5-783M/onnx/encoder_model_quantized.onnx')
decoder_model=ort.InferenceSession('LaMini-Flan-T5-783M/onnx/decoder_model_merged_quantized.onnx')

generator_ort = pipeline(
    task="text2text-generation",
    model=session,
    tokenizer=tokenizer,
)

output = generator_ort('Tell me a story about cheese.', max_new_tokens=500)
len(tokenizer(output[0]['generated_text'])['input_ids'])
# returns 128

cc @Narsil @ArthurZucker perhaps I'm missing some generation parameter? As I mentioned above, it looks like relative_attention_max_distance is causing this (which is set to 128 in config.json).

Seems it was just trained that way somehow.
Probably just fed only sentences of 128 tokens max (which would put a lot of EO S token there).
If you do use min_length it will not produce EOS and respect it, proving that's it's the model's doing of finishing at 128. (Also the pipeline includes the prompt so 128 is the total length).

Hi, at least on the transformers side, if you want generate to actually obey to min_new_tokens (allowing EOS tokens) you need the following:
gen_config = GenerationConfig(..., eos_token_id=None)
model.generation_config.eos_token_id = None  # greedy_search falls back on this eos_token_id that we need to set to None as well for min_new_tokens to have an effect.

due to this and this
transformers.js behavior is probably different though, so the issue may be elsewhere.

Yes really: https://github.com/huggingface/transformers/blob/fb7d246951d5f60aa36a7958841dfea72f51fc6b/src/transformers/generation/utils.py#L2501. If all sequences in the batch produce an EOS token, the generation stops before min_new_tokens.

transformers.js behavior is probably different though, so the issue may be elsewhere.

@fxmarty I haven't yet added the min_new_tokens option to Transformers.js' generation config, and it should be quite simple to add, so that's one difference. However, my concern is more about why it's stopping at exactly 128.
@Narsil with your example, could you maybe explain to me why the generation always stops at 128 if you don't specify min length? Is the model actually predicting eos_token? Or is it due to "relative_attention_max_distance": 128, in config.json? I've also searched the transformers repo for relative_attention_max_distance, but it doesn't appear in the generation code (it's only set for config). If it's operating as I understand it, does it not make sense to crop the attentions during generation?

It looks like eos I tried to remove the relative thing from the config and nothing seems to have changed. I may have done it wrong though I just edited the file and didn't check what happened deep into the code.

It looks like eos

Your earlier experiment of setting min_tokens (i.e., not allowing the model to predict EOS) seems to confirm this. Still very strange, no? I would think that even if the model only attends to the previous 128 tokens, it would still be able to generate more than that. Alternatively, this may be a by-product of how the model was trained: with chunks of 128 tokens.
I initially suspected that the model would output gibberish after token 128 if we just don't allow it to predict EOS. However, the output seems perfectly sound 👍 (320 tokens)

Kubernetes is a popular containerization platform that allows developers to build and deploy applications on a large scale. It is a lightweight, scalable, and cost-effective way to manage and scale applications. Kubernetes is based on the Kubernetes Stack, which is a collection of containerization tools and services. It is designed to be easy to use and manage, making it a popular choice for developers and organizations. One of the main advantages of Kubernetes is its ability to handle large volumes of traffic. Kubernetes supports a large number of concurrent applications, and it can handle large volumes of traffic with ease. It is also a highly customizable platform, allowing developers to tailor Kubernetes to their specific needs. Kubernetes is also highly secure, as it uses a combination of encryption, port control, and containerization techniques to ensure that applications can run smoothly on different environments. Kubernetes also provides a robust security framework, which makes it easy to manage and deploy applications. This makes it a popular choice for developers who want to build and deploy applications on a large scale. Kubernetes also provides a robust security framework, which makes it easy to manage and secure applications. It is also a popular choice for developers who want to build and deploy applications on a large scale. Overall, Kubernetes is a powerful tool for building and deploying applications on a large scale.

(bold is >token 128)


List view (similar to issue #13442)

What feature or improvement do you think would benefit Files?
The ONLY thing I miss in Windows File Explorer is the List view. It is extremely useful when managing very large directories.
This would also be a solution to request #13442.
I'm not sure how to fulfill the requirement to "include a list of changes" but this might be what you want.

create a very compact view that only shows file names with the smallest size icons.
add this view under the layout icon in the toolbar.

I'm not sure what is expected under Requirements, below. Please advise if I should modify this perhaps giving exemplars.
These screenshots show how the feature is implemented in Windows Explorer. I'm not concerned that it be implemented exactly the same way, just to have a convenient and intuitive way to invoke the view.

Requirements

This proposal will make it easier to peruse and manage large directories of similarly named files.
This proposal will add support for sysops.

Files Version
<IP_ADDRESS>
Windows Version
10.0.22631.2715
Comments
Screenshots of the view in Windows Explorer are provided above.

Thanks for the feedback, Merging with #2509. You can check there or click subscribe in the right sidebar for updates.

Thanks for the immediate response. The issue to which it is linked and other similar issues are marked closed, although the feature is not available. Does this mean the request was denied or that it is planned for a future version?

It still planned, the issue I linked isn't closed. Other ones were merged with that one also.

Thanks, Josh!
-- Wes
On Wed, Nov 29, 2023 at 10:39 AM Josh65-2201 @.***>
wrote:

It still planned, the issue I linked isn't closed. Other ones were merged
with that one also.
—
Reply to this email directly, view it on GitHub
https://github.com/files-community/Files/issues/14117#issuecomment-1832492485,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAPL7O7TNF26NJNYK4Y24M3YG56MRAVCNFSM6AAAAAA775SDZCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMZSGQ4TENBYGU
.
You are receiving this because you authored the thread.Message ID:
@.***>

@wrishel thank you for your patience, I'm excited to share that a List View layout will be included in the next release.


ShortedThrowableConverter: review documentation and examples

Provide more information/documentation about ShortedThrowableConverter and how to customise stack traces.
Points deserving more explanations:

frames are effectively removed from the stack trace if at least TWO CONSECUTIVE frames must be excluded. In other words it is not possible to remove a single element.
EventEvaluator: give an example, joran evaluator can be used as well (evaluators are a Logback feature)
stress that exclude patterns are regex expressions -> special characters like dot, dollar, etc need to be escaped to match the corresponding literal
the converter can be used inside a Layout:

provide an example (config + output)
document the available options (configuration)

Also, the stack hash documentation gives a least of recommended exclusions to use in a SpringBoot application to produce stable hashes. I understand that the hash computation algorithm will ignore the matching frames, however it makes me believe they will be omitted from the printed/reduced stack trace as well. This won't obviously be the case since we must have at least two consecutive frames for them to be removed.
This is rather confusing to most users and I wonder if the documentation should not be improved on the subject.


SAK-31051 return url string, instead of /access url, for Web Link resources

Changed the logging level from "info" to "warn" level inside the exception handling blocks.

Log message changed - removed the "this + " part


[Bug]: Potential goroutine leak in pool.go

Actions I've taken before I'm here

[X] I've thoroughly read the documentations on this issue but still have no clue.
[X] I've searched the current list of Github issues but didn't find any duplicate issues that have been solved.
[X] I've searched the internet with this issue, but haven't found anything helpful.

What happened?
I notice the ctx.Done() needs a cancel function to unblock the statement of ctx.Done in https://github.com/panjf2000/ants/blob/dev/pool.go#LL84C21-L84C21,
but I never find the cancel function in its invocation.  So if this may leak the goroutine where the ctx.Done() locates?
Maybe what I said is not right, thank you.
Major version of ants
v2
Specific version of ants
v2.6.0
Operating system
Linux
Relevant log output
.

Code snippets (optional)
.

How to Reproduce
.
Does this issue reproduce with the latest release?
I haven't verified it with the latest release

Check out this:
https://github.com/panjf2000/ants/blob/9fdd99a7b4b568d102ea85a62341641bacfc5827/pool.go#L293-L296

You can refer to these link:
https://www.arangodb.com/2020/09/a-story-of-a-memory-leak-in-go-how-to-properly-use-time-after/
https://github.com/eclipse/paho.mqtt.golang/issues/518


Refactor test_integration

This PR aims to improve the experience with the test_integration. As it was using the same table_name for the tests it doesn't work well when running tests in parallel.

I believe this was addressed in the pyomnisci / pyomniscidb migration.


[Question] Type inference

Hi together!
I am new to flutter and I have a question about the analyzer & the type inference.
In all the examples in the www and also in the flutter documentation or even in the source code of the framework itself, almost 99% of the code have fixed types assigned. Rarely I found modules or code parts where type inference is used. (I found mixed parts in e.g. the flutter cookbook)
Lets talk about some precise examples:
// Fair enough, I could guess it by recognizing the quotes; still, why type it?
String someString = "someValue"

// Can build return something else, other than a widget?
Widget build(BuildContext context) {

// Ok, this is really hard now; the type is even duplicated from the instantiation
final TextEditingController controller = TextEditingController();

I am using VSC as an editor and the integration works like a charm. I have no doubts about it. I simply want to understand why so many people favor fixed types instead of making use of the inference.
Is this a best practice?
Do people use it to read the code without possibly open it in an editor?
If I understand anything wrong or missed an important concept please do not hesitate to point out my mistakes.
Would be great if you give me feedback.
Cheers

This is covered in the Flutter style guide.

This is covered in the Flutter style guide.

The anchor you linked does defenitely not answer my questions.

You asked why Flutter code uses explicit types; the answer to that question is the explanation for the style rule I linked to:

This achieves two purposes: it verifies that the type that the compiler would infer matches the type you expect, and it makes the code self-documenting in the case where the type is not obvious (e.g. when calling anything other than a constructor).

I precisely asked why explicit types are used when the type can be clearly infered (from the analyzer and from looking at the code; see my examples above). If it is used to force self documentation why is the inference even there if its a best practice to fix them anyway.
I see it seems to be a best practice for flutter. I just wanted to discuss that because sometimes leaving out the obvious redundant types makes the code slimmer.


Fixed bug in r_string

The end-of-string pointer was not updated in the force member function
This could lead to undefined behaviour in the std::string conversion
operator, when using the iterator interface (begin() / end()), and the size()
member function.

Thank you for the PR.


Nested example failure

I was writing about using blacken-docs and it crashed like:
$ python -m blacken_docs example.rst
Traceback (most recent call last):
  File "/.../3.10/lib/python3.10/runpy.py", line 196, in _run_module_as_main
    return _run_code(code, main_globals, None,
  File "/.../3.10/lib/python3.10/runpy.py", line 86, in _run_code
    exec(code, run_globals)
  File "/.../site-packages/blacken_docs.py", line 248, in <module>
    exit(main())
  File "/.../site-packages/blacken_docs.py", line 243, in main
    retv |= format_file(filename, black_mode, skip_errors=args.skip_errors)
  File "/.../site-packages/blacken_docs.py", line 199, in format_file
    new_contents, errors = format_str(contents, black_mode)
  File "/.../site-packages/blacken_docs.py", line 186, in format_str
    src = RST_RE.sub(_rst_match, src)
  File "/.../site-packages/blacken_docs.py", line 106, in _rst_match
    min_indent = min(INDENT_RE.findall(match['code']))
ValueError: min() arg is an empty sequence

With this example.rst:
blacken-docs does changes like:

.. code-block:: diff

     .. code-block:: python

    -    name  = 'World'
    -    format_html('Hello {}',
    -        name
    -    )
    +    name = "World"
    +    format_html("Hello {}", name)

It seems blacken-docs picks up .. code-block:: python, but then INDENT_RE doesn't then due to diff indentation.
(I worked around this by changing the example to not include .. code-block:: python.)

the crash seems correct, the python block contains non python code

It's not a real block though because it's in a different code block - perhaps blacken-docs could be taught to ignore code blocks inside code blocks?

I doubt it, there isn't a real parser involved


Login-Redirect-Fix

Change description

Removal of home component
Redirecting to search after login
Preserving routes when unauthenticated also to redirect to after successful login

Checklist

[ ] commit messages are meaningful and follow good commit message guidelines
[ ] README and other documentation has been updated / added (if needed)
[x] tests have been updated / new tests has been added (if needed)
[ ] Does this PR introduce a breaking change

I've updated cypress tests to reflect the redirect to the search page now


is the min limit 10?

I'm trying to limit to 1 or 3 results,
but no matter what limit under 10 - it still gives back 10.

Yes, the minimum is 10, since it's scraping from actual google search results pages, which contain 10 results each.


List the git SSH clone URL on the swift package index website.

Reasoning
Using two factor authentication on GitHub makes cloning via https a bit of a chore. It’s generally easier to deal with this by using SSH to clone a repo.
Currently the swift package index only lists the HTTPS clone url (see screenshot).
It would be nice if we could choose between https and ssh (I.e. git@github.com:user/repo).
Screenshots

Thanks for the report, Brent! You’re right, that’s definitely something we could improve. We were also considering adding a representation that can be copied into Package.swift and we could perhaps tackle all of these if not at the same time at least with a general mechanism/UI.

Closing this for now. It's pretty straightforward to click through to the Github repo in order to obtain the SSH url as a workaround.


⚠ SceneTime has degraded performance

In 10d2729, SceneTime ($ST) experienced degraded performance:

HTTP code: 200
Response time: 28191 ms

Resolved: SceneTime performance has improved in b8a5205 after 8 minutes.


Ho-Ho-Hold up a second, Racist terms in code??

I kept a hearin a whole lotta hub-bub bout' this here vs code. So I thought, shieeet, maybe i'll give it a go, I could always use me one of them 6 figure microsoft jobs.
However as I was browsin the code in my Jetbrains WebStorm(Take 25% off with promo code: SANTA - expires Jan 1st, 2020), I noticed some very racist terms being used freely by the development team.

I have been called a monkey many times in my life, but I never thought that microsoft would do it themselves, shame on them.
Here is a link to a random article (that neither you or I will read) that easily helps boost my credibility( http://theconversation.com/comparing-black-people-to-monkeys-has-a-long-dark-simian-history-55102 )
Until issue is fixed, I am instructing all of my black brothers and sympathizers at microsoft to halt work on this project.
And for the racists in question, we got our eyes on you, and don't expect anything but coal from santa this year.

lol. Where is my Vederko of OR?

WOW. I can't believe Microsoft would do something like this! If they are this open about being racist, they're probably sexist AND transphobic too! I am litearlly shitting and pissing and cumming right now!!!

A python killed my first born. That's offensive...

  Where is my Vederko of OR?

bucket of what?

Well written


[Feature request] Support react-native-web

Folks, we love your work, please help support this module for react-native-web sourcebase, we believe that your work will be recognized both on react-native and cross-stack communities, RNW is now the most prominent one in industrial ICT projects
Reference:

https://github.com/necolas/react-native-web (400K+ sourcebase worldwide)
https://github.com/vemarav/react-native-web-typescript-template
Cheers,

Hi @phathuynh5519 thank you! Are you facing any issues supporting web?

Hi @phathuynh5519 thank you! Are you facing any issues supporting web?
Yep Dear, would u please support us, we tried uninstall node_modules folder and reinstall npm

TS2307: Cannot find module '@env' or its corresponding type declarations.
    16 | import {Lookup} from './screens/Lookup';
    17 | import Realm from 'realm';
  > 18 | import {email, password, realmID} from "@env";
       |                                                  ^^^^^^
    19 | import {getCurrentUser, addCurrentUser} from './constants/Realm';
    20 | const Tab = createBottomTabNavigator();
    21 |

  Binaries:
    Node: 16.13.2 - D:\Program Files\nodejs\node.EXE
    Yarn: 1.22.4 - D:\Roaming\npm\yarn.CMD
    npm: 6.14.5 - D:\Roaming\npm\npm.CMD

Oh this is a typescript issue. Can you try changing moduleName to "react-native-dotenv" and use "react-native-dotenv" instead of "@env" ?


Unable to serialize CoxPHFitter when baseline_estimation_method is defined

When I specify a baseline_estimation_method for the CoxPHFitter, I cannot pickle the model.
from lifelines.datasets import load_rossi
from lifelines import CoxPHFitter
from pickle import dumps

rossi = load_rossi()

cph = CoxPHFitter(baseline_estimation_method='spline', n_baseline_knots=5)
cph.fit(rossi, duration_col='week', event_col='arrest')

dumps(cph)

The code above results in the following.
---------------------------------------------------------------------------
NotImplementedError                       Traceback (most recent call last)
<ipython-input-9-b9dedf290e8d> in <module>
      8 cph.fit(rossi, duration_col='week', event_col='arrest')
      9
---> 10 dumps(cph)

C:\ProgramData\Anaconda3\lib\site-packages\patsy\util.py in no_pickling(*args, **kwargs)
    722 def no_pickling(*args, **kwargs):
    723     raise NotImplementedError(
--> 724         "Sorry, pickling not yet supported. "
    725         "See https://github.com/pydata/patsy/issues/26 if you want to "
    726         "help.")

NotImplementedError: Sorry, pickling not yet supported. See https://github.com/pydata/patsy/issues/26 if you want to help.

Any ideas on how to get this fixed? Using dill does not work either.

A fix is coming soon! #1131 will allow pickable models


Opening .sst files

Can anyone please guide me on how to open these files? I've been trying to do this since days.
I have asked my question on stack overflow here .

The README points to https://github.com/google/leveldb/blob/master/doc/index.md which describes the LevelDB API. You can use that to read the files from a C++ program.
Your StackOverflow question suggests that you're looking for something to read a very specific format (neural network weights?) that happens to be embedded in a LevelDB database. We can't help you with that.

Hi,
Thanks for your reply.
I am not trying to get the neural network weights, The database contains images and some numbers associated with every image, it's just like any other dataset, but I can't decode how to open those .sst files.
Can .sst files be opened by levelDB?
About the screenshot I posted, is that a LevelDB database?
Thank you,

Yes, it's a leveldb. Assuming it wasn't written with a custom Iterator your program to read from it should look something like this:
#include "leveldb/db.h"

// Open the database.
leveldb::DB* db;
leveldb::Options options;
options.create_if_missing = true;
leveldb::Status status = leveldb::DB::Open(options, "/tmp/testdb", &db);
if (!status.ok())
  return;

// Read each key/value in the database.
leveldb::Iterator* it = db->NewIterator(leveldb::ReadOptions());
for (it->SeekToFirst(); it->Valid(); it->Next()) {
  // You probably want to change this from cout to using your key/values
  cout << it->key().ToString() << ": "  << it->value().ToString() << endl;
}

// Close the database.
delete db;


BUG:  In the Navbar Genre Button Underline is not Showing  ( LIght & dark )

Is there an existing issue for this?

[X] I have searched the existing issues

What happened?

please assign i can fix this
Record

[X] I agree to follow this project's Code of Conduct
[X] I'm a GSSOC'24 contributor
[X] I want to work on this issue

Is there an existing issue for this?

[X] I have searched the existing issues

What happened?

please assign i can fix this
Record

[X] I agree to follow this project's Code of Conduct
[X] I'm a GSSOC'24 contributor
[X] I want to work on this issue

assigned


Adding winres increases binary size

Hi!
I added this crate as dependency to add an icon to my project and expected this to have zero effect on the final binary size. To my surprise was the binary size increased. Is this expected or not?
This is how my toml looks like...
[package]
#...
build = "build.rs"

#...
[target.'cfg(windows)'.build-dependencies]
winres = "0.1.11"

winres.a is statically linked, so there is obviously some overhead.

winres does not link code into binary. The static library is a necessity to link the icon (and other resources) into the executable. The static library (which should be called resource.lib but is a .ar archive) in actuality is the output of the rc.exe resource compiler usually with the suffix .res, but since we need the rust compiler to link it a library suffix is needed.
Back to the OP's comment the t the binary size increases. This must obviously be the case as now the binary contains in itself the icon and other resources like the version string information. If you use a particularly large icon (like 512px) then the binary size may increase by more than 1MB. (pictures need size). I'm not sure what OP originally expected but if you add content to a file its size will always increase.
So I'm closing this as invalid.


Implement the bilinear initializer op

Bilinear interpolation is commonly used to initialize upsampling layers like conv2d_transpose. This PR implements a CPU op to initialize the filters.
Similar feature request: https://github.com/tensorflow/tensorflow/issues/5790

Fine for API review.

Hi @protoget , thanks for offering to review this issue! Please feel free to let me know of any suggestions.

Whats ETA on this? We really need this feature.

@srikalyan The implementation is ready and tested.
@martinwicke @protoget Would you mind taking a look at this PR? It's a quite simple one. Most of the code are just boilerplate templates.

Could you add documentation that explains what exactly this does? I can tell from the code, but it's not clear from the docs alone.
Also, the quadruple loop appears to be inefficient. Since you only assign a value for k==l, three loops should suffice. For bonus points, can you express this loop in eigen operations? That will give it both GPU support and significant optimizations.
I am wondering whether a C++ op is even necessary for this. Can you build this initializer from existing op kernels (e.g. ResizeBilinear for appropriate inputs?). That would be easier to maintain.

@martinwicke Thanks for the comments.
I added more docs/comments on the code to make it easier to understand.
I fixed the quadruple loop into a triple loop. Thank you for the suggestion!
Using eigen will make it more concise and gain the benefit of GPU support. But it will also make it harder to understand and maintain. As an initializer, it only runs once at the beginning. Thus the performance impact is relatively limited.
It's not very straightforward to implement it using ResizeBilinear, because ResizeBilinear directly performs the upsampling on the data while BilinearInitializer generates a kernel with which the convolution conducts the upsampling.

@martinwicke Do you have some time to take a look at this PR?
I've heard from several people who wanted to use this feature in their fully convolutional networks (FCN).
Thanks!

Nagging Assignee @protoget: It has been 14 days with no activity and this issue has an assignee. Please update the label and/or status accordingly.

Can someone take a look at this PR? It has been waiting for a while. Thanks!

Nagging Assignee @protoget: It has been 17 days with no activity and this issue has an assignee. Please update the label and/or status accordingly.

Nagging Reviewer @ebrevdo, @sherrym: It has been 14 days with no activity and the awaiting review label was assigned. Can you please take a look?

Nagging Reviewer @ebrevdo, @sherrym: It has been 29 days with no activity and the awaiting review label was assigned. Can you please take a look?

Nagging Reviewer @ebrevdo, @sherrym: You have been added as a reviewer to this pull request. Please add your review or reassign. It has been 45 days with no activity and the awaiting review label has been applied.

Nagging Reviewer @ebrevdo, @sherrym: You have been added as a reviewer to this pull request. Please add your review or reassign. It has been 59 days with no activity and the awaiting review label has been applied.

Nagging Reviewer @ebrevdo, @sherrym: You have been added as a reviewer to this pull request. Please add your review or reassign. It has been 74 days with no activity and the awaiting review label has been applied.

Nagging Reviewer @ebrevdo, @sherrym: You have been added as a reviewer to this pull request. Please add your review or reassign. It has been 89 days with no activity and the awaiting review label has been applied.

Nagging Reviewer @ebrevdo, @sherrym: You have been added as a reviewer to this pull request. Please add your review or reassign. It has been 104 days with no activity and the awaiting review label has been applied.

Nagging Reviewer @ebrevdo, @sherrym: You have been added as a reviewer to this pull request. Please add your review or reassign. It has been 119 days with no activity and the awaiting review label has been applied.

Nagging Reviewer @ebrevdo, @sherrym: You have been added as a reviewer to this pull request. Please add your review or reassign. It has been 134 days with no activity and the awaiting review label has been applied.

Nagging Reviewer @ebrevdo, @sherrym: You have been added as a reviewer to this pull request. Please add your review or reassign. It has been 149 days with no activity and the awaiting review label has been applied.

Nagging Reviewer @ebrevdo, @sherrym: You have been added as a reviewer to this pull request. Please add your review or reassign. It has been 164 days with no activity and the awaiting review label has been applied.

Nagging Reviewer @ebrevdo, @sherrym: You have been added as a reviewer to this pull request. Please add your review or reassign. It has been 182 days with no activity and the awaiting review label has been applied.

Nagging Reviewer @ebrevdo, @sherrym: You have been added as a reviewer to this pull request. Please add your review or reassign. It has been 197 days with no activity and the awaiting review label has been applied.

Nagging Reviewer @ebrevdo, @sherrym: You have been added as a reviewer to this pull request. Please add your review or reassign. It has been 29 days with no activity and the awaiting review label has been applied.

Nagging Reviewer @ebrevdo, @sherrym: You have been added as a reviewer to this pull request. Please add your review or reassign. It has been 44 days with no activity and the awaiting review label has been applied.

Nagging Reviewer @ebrevdo, @sherrym: You have been added as a reviewer to this pull request. Please add your review or reassign. It has been 59 days with no activity and the awaiting review label has been applied.

Nagging Reviewer @ebrevdo, @sherrym: You have been added as a reviewer to this pull request. Please add your review or reassign. It has been 74 days with no activity and the awaiting review label has been applied.

Nagging Reviewer @ebrevdo, @sherrym: You have been added as a reviewer to this pull request. Please add your review or reassign. It has been 89 days with no activity and the awaiting review label has been applied.

Nagging Reviewer @ebrevdo, @sherrym: You have been added as a reviewer to this pull request. Please add your review or reassign. It has been 104 days with no activity and the awaiting review label has been applied.

Nagging Reviewer @ebrevdo, @sherrym: You have been added as a reviewer to this pull request. Please add your review or reassign. It has been 119 days with no activity and the awaiting review label has been applied.

Nagging Reviewer @ebrevdo, @sherrym: You have been added as a reviewer to this pull request. Please add your review or reassign. It has been 134 days with no activity and the awaiting review label has been applied.

Nagging Reviewer @ebrevdo, @sherrym: You have been added as a reviewer to this pull request. Please add your review or reassign. It has been 149 days with no activity and the awaiting review label has been applied.

Nagging Reviewer @ebrevdo, @sherrym: You have been added as a reviewer to this pull request. Please add your review or reassign. It has been 164 days with no activity and the awaiting review label has been applied.

Can one of the admins verify this patch?

@bowang Could you please resolve the conflicts? Thanks!

I am happy to fix the conflicts if any maintainer agrees to review this PR... otherwise it's just work in vain.

I'll take a look

@bowang Could you please check reviewer comments and keep us posted. Thanks!

@bowang Could you please check reviewer comments and resolve conflicts?. Thanks!

I said I'll take a look but it's going to be wasted time to look at it before conflicts are fixed.

Actually, contrib is removed so closing this PR. Please reopen against TF Addons.


StateColab issue with TodoItemInlineEditor on Android 7.0

In devices or emulators with Android 7.0 it is impossible to edit properly the text of an item in the todo list.
The problem can be reproduced through the following steps:

checkout of the codelab
install the "finished" module app on the device or emulator with Android 7.0 (24).
click on the button "Add random Item".
click on the task that has just been added to the list
try editing the text

It is impossible to add to the text, but it is possible to delete characters.
In other physical devices or emulators with versions different from Android 7.0 (24) everything works as expected.

Using an emulator with API 24 I am unable to reproduce this.

Using an emulator with API 24 I am unable to reproduce this.

Branch main, commit 52f22aabd7d06b89beaaf874bb71e995f388671f
Android Studio Arctic Fox | 2020.3.1 Canary 3
Build #AI-202.7319.50.2031.7019041, built on December 8, 2020
Runtime version: 11.0.8+10-b944.6842174 x86_64
VM: OpenJDK 64-Bit Server VM by N/A
macOS 10.15.6
GC: G1 Young Generation, G1 Old Generation
Memory: 2048M
Cores: 8
Registry: external.system.auto.import.disabled=true
Non-Bundled Plugins: org.jetbrains.kotlin, com.developerphil.adbidea
Android Gradle Plugin version: 7.0.0-alpha03
Gradle version: 6.8-rc-1
Compose version: 1.0.0-alpha09
Kotlin version: 1.4.21
Physical device:

board: universal7420
brand: samsung
cpu.abi: arm64-v8a
cpu.abilist: arm64-v8a,armeabi-v7a,armeabi
cpu.abilist32: armeabi-v7a,armeabi
cpu.abilist64: arm64-v8a
device: zeroflte
locale: en-GB
manufacturer: samsung
model: SM-G920F
name: zerofltexx
version.release: 7.0
version.sdk: 24

https://user-images.githubusercontent.com/6303224/104033143-6e90de00-51cf-11eb-82a3-84713be8ae2e.mp4
unfortunately I can no longer reproduce the same problem with the emulator

Branch main, commit 52f22aabd7d06b89beaaf874bb71e995f388671f
Android Studio Arctic Fox | 2020.3.1 Canary 3
Build #AI-202.7319.50.2031.7019041, built on December 8, 2020
Runtime version: 11.0.8+10-b944.6842174 x86_64
VM: OpenJDK 64-Bit Server VM by N/A
macOS 10.15.6
GC: G1 Young Generation, G1 Old Generation
Memory: 2048M
Cores: 8
Registry: external.system.auto.import.disabled=true
Non-Bundled Plugins: org.jetbrains.kotlin, com.developerphil.adbidea
Android Gradle Plugin version: 7.0.0-alpha03
Gradle version: 6.8-rc-1
Compose version: 1.0.0-alpha09
Kotlin version: 1.4.21
Physical device:

board: universal7420
brand: samsung
cpu.abi: arm64-v8a
cpu.abilist: arm64-v8a,armeabi-v7a,armeabi
cpu.abilist32: armeabi-v7a,armeabi
cpu.abilist64: arm64-v8a
device: zeroflte
locale: en-GB
manufacturer: samsung
model: SM-G920F
name: zerofltexx
version.release: 7.0
version.sdk: 24

https://user-images.githubusercontent.com/6303224/104033143-6e90de00-51cf-11eb-82a3-84713be8ae2e.mp4
unfortunately I can no longer reproduce the same problem with the emulator

Thanks for the details. This doesn't look like an issue with the codelab, but with Compose.
I created an issue for this here.
Closing this issue.

Thanks for the details. This doesn't look like an issue with the codelab, but with Compose.
I created an issue for this here.
Closing this issue.

@defio - our engineers have some questions for you to help fix this issue.
Would you mind adding a comment to the official issue so they can start asking some questions?
Thanks!

@florina-muntenescu  of course! I just commented on the ticket in the official issue.


Google "I'm feeling lucky" redirect notice on reddit login

New Issue Checklist (tick off like this: [x])

[X] I checked existing issues (open and closed) for possible duplicates
[X] I can reproduce the problem on the latest stable version (not nightly!)
[X] If you have a problem a specific website: adding the domain to your blacklist does not solve the problem
[X] The issue is not about adding entries to the default blacklist

What is your browser?

[X] Firefox
[ ] Chrome

What is your operating system?

[X] Linux
[ ] Mac
[ ] Windows

Description (please include examples/screenshots where applicable)
Google has recently started to notice its users that they are being redirected somewhere when using the feature "I'm feeling lucky".
"Skip-redirect" fixes this new behaviour for most of the query except for when trying to access the reddit login page.
How to reproduce:
Click here and see that instead of going directly to reddit login page you have the "you are being redirected" advice, even with the skip-redirect addon installed: https://www.google.com/url?q=https://www.reddit.com/login&BtnI=1

login is on the default blacklist. You can remove it there. but that might break many other pages.


Adding a vagrantfile definition for csharp (mono/.NET)

Vagrantfile definition to install mono-complete which adds C# and even just general mono/.NET

Hey, @enckse
Could you add a link to the mono website to the Tooling column of the Readme?
Once that's done, feel free to merge :+1:


Added more abbreviations

Closes #
What new changes did you make? Tick all applicable boxes

[ ] Added new abbreviation
[ ] Fixed something in the source code
[ ] Added a new feature
[ ] Fixed the docs (README.md, CONTRIBTUING.md, etc)

Describe the new changes you added.

Share a screenshot of new changes

@Njong392 Thank you for your message and for pointing out the issue with my pull request. I apologize for not syncing my fork with the upstream repo before creating the new pull request. I will make sure to do that in the future to avoid such mistakes.


[Feature] refine our contributor document

including

rules to obey before merge
setup/debug/contributor guide
code style
...

#683


Mod manager can't find game

i wanted to play the VR-Mod for OW.
I've purchased OW on Epic Game Launcher.
I installed the mod manager, OWML and NomaiVR.
But when I press Start Game, this is whats displayed in the logs:
Client connected to console | Mod Manager |
Started OWML v2.9.0 | OWML |
Current game path is not valid: F:/Epic/Games/TheOuterWorlds | OWML |
Game not found in Steam. | OWML |
Game not found in EGS. | OWML |
Game not found in UWP. | OWML |
Game not found in default locations. | OWML |
Game not found at F:/Epic/Games/TheOuterWorlds | OWML |
Please enter the correct game path: | OWML
The gamepath is correct and i also tried to start with "launch game exe directly" enablled.
I can start the game all normally threew epic game launcher.

Go to the manager settings and insert the correct game path here:

If that doesn't work, you can also insert the game path in the black console window that pops up when you try running the game from the manager.

Are you sure you have the right game? The Outer Worlds is different from Outer Wilds.

lol didn't even notice


Add Support for Part Modifications

Currently Control Part Modifications of Adds Alters are not being displayed in OCSCALProfile, more specifically OSCALControlModification. Parts may contain [0, 1] parts or [0, 1] props.
Current Behavior
When loading the Profile https://raw.githubusercontent.com/GSA/fedramp-automation/master/baselines/rev4/json/FedRAMP_rev4_MODERATE-baseline_profile.json, Control part RA-5.a says there are 2 modifications but only lists 1.
Expected Behavior
Parts are displayed. For the image below, it would be more valuable to show are the title and prose than the individual props
Helpful Resources
Outline of adds:
This has been discussed and attempted to fix at #53.

Raised by @tuckerzp.


Kwin feature/configurable image qualities

| ------------------------ | ---
| Fixed Issues?            | Fixes #254
| Patch: Bug Fix?          | No
| Minor: New Feature?      | Yes
| Major: Breaking Change?  | No
| Tests Added + Pass?      | Yes
| Documentation Provided   | Yes (code comments and or markdown)
| Any Dependency Changes?  | No
| License                  | Apache License, Version 2.0

Codecov Report

Merging #270 into master will decrease coverage by 0.37%.
The diff coverage is 76.66%.

@@             Coverage Diff              @@
##             master     #270      +/-   ##
============================================
- Coverage     82.74%   82.36%   -0.38%
- Complexity      787      792       +5
============================================
  Files            73       73
  Lines          2538     2575      +37
  Branches        463      470       +7
============================================
+ Hits           2100     2121      +21
- Misses          174      187      +13
- Partials        264      267       +3

Impacted Files
Coverage Δ
Complexity Δ

...com/adobe/cq/wcm/core/components/models/Image.java
100% <ø> (ø)
12 <0> (ø)
:arrow_down:

.../core/components/internal/models/v1/ImageImpl.java
86.91% <100%> (+0.12%)
35 <0> (ø)
:arrow_down:

.../core/components/internal/models/v2/ImageImpl.java
72.22% <100%> (+1.2%)
20 <0> (+1)
:arrow_up:

...onents/internal/servlets/AdaptiveImageServlet.java
77.43% <74.07%> (-2.4%)
75 <5> (+4)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 344a47a...2bbe751. Read the comment docs.

Thanks @kwin - this looks good to me. One thing I think we're still missing is documentation of the available selectors in the AdaptiveImageServlet and of the new JPEG quality parameter in the individual image component Readme.md.

@bpauli Thanks for picking this up and sorry that I missed this unit test.
@richardhand This is now a PR from @bpauli but I can prepare a third :-) PR when I am back from vacation and provide a modified readme on top of this branch.

@kwin We can keep the selector as it is. Thanks again for the PR.


Home Assistant Integration

Use-case:
I have a wall mounted 7" Raspberry Pi display with a POE SSR relay hat to control some lights that can't be smart and are controlled by a poorly placed wall switch. So controlling / monitoring remote Raspberry Pi GPIO's would expand the use of Rpi's in HA Outside of HA servers. I think the current solution is using Remote GPIO but it's a headache to get it integrated into HA.
So, the idea would be to have some HA plugin that connected to piglet/porky much like piggie does and to be able to control outputs from it and react to input levels/changes
I hope to play around with your release this weekend.

See https://github.com/thecode/ha-rpi_gpio

Maybe a python plugin could be done, where the serde over the wire could be done with part of pigg as a library, using https://pyo3.rs/v0.22.3/, to ensure wire format compatibility.....

https://github.com/thecode/ha-rpi_gpio/tree/main/custom_components/rpi_gpio


Add ability to directly assume credentials or generate a console link in a sub-account

The previous workflow we had was that we had credentials for all of the payer accounts saved on our laptops, and then it was a one step procedure to generate credentials or a console login link via osdctl account console -i [account-number] -p [payer-account-name].
With this new flow through rh-aws-saml-login it would be nice to be able to pass an additional argument that would allow me to drop right into a sub account, through the specified payer account, instead of having to drop into the shell that's created as part of rh-aws-saml-login and run a further step to get into the account that I am looking for.
Non-Goal - I would not expect these sub-accounts to be listed by the rh-aws-saml-login tool, there are just too many (and the ability to query them is heavily rate limited by AWS) and it would not be a good user experience. We should expect the end users who use this functionality to know the account ID that they're trying to access.

Thanks for looking! No rush! This is 100% a convenience feature request :)


OPT: update release changelog automatically in the publishing workflow

Nice, great addition by using community actions as well! Not entirely sure on using @master on the generate-release one, but also not a huge deal.


Improve solidity code for PNA

Various improvements and cleanups
Changes:

More consistent and descriptive naming style
Simplified token registry
AgentExecutor.sol: Remove deprecated execute method
Foreign tokens are now owned by the gateway rather than the assethub agent. This simplifies code without sacrificing any security & robustness
Moved more asset-specific code to Assets.sol

FIXES: SNO-1133

Foreign tokens are now owned by the gateway rather than the assethub agent.

What about already registered foreign assets? Are they still using the agent as admin account? Or do you plan to switch the registered admin on AH for them (need to check if that is possible)?

Cool, much simple!
Btw: It seems we want to support multi-hop for Ethereum->AH->Para direction. So is the fee token on Para still be relay token? If so will destination chain accept that? Can we always assume it's reserve-backed transfers beween AH and Para(more discussion in https://snowfork.slack.com/archives/G01BGMGLAC9/p1724456977726639thread_ts=1724432403.659139&cid=G01BGMGLAC9)?
My concern here is seems not easy to find a common pattern to support multi-hop which applies to all parachains.

Foreign tokens are now owned by the gateway rather than the assethub agent.

What about already registered foreign assets? Are they still using the agent as admin account? Or do you plan to switch the registered admin on AH for them (need to check if that is possible)?

This is an Ethereum-specific addition that does not involve AH. Currently there are only native tokens (aka Ethereum-native ERC20s) registered in the Gateway contract, and on AH too.
This change gives our gateway contract the ability to be aware of foreign assets on AH for example the Hydra or Kilt token in the ForeignAssets pallets.
So it does affect the code paths that involve ethereum-native assets such as WETH or WBTC.

Foreign tokens are now owned by the gateway rather than the assethub agent.

What about already registered foreign assets? Are they still using the agent as admin account? Or do you plan to switch the registered admin on AH for them (need to check if that is possible)?

This is an Ethereum-specific addition that does not involve AH. Currently there are only native tokens (aka Ethereum-native ERC20s) registered in the Gateway contract, and on AH too.
This change gives our gateway contract the ability to be aware of foreign assets on AH for example the Hydra or Kilt token in the ForeignAssets pallets.
So it does affect the code paths that involve ethereum-native assets such as WETH or WBTC.

I see. Sounds good! Thanks for the explanation 👍🏻

Cool, much simple!
Btw: It seems we want to support multi-hop for Ethereum->AH->Para direction. So is the fee token on Para still be relay token? If so will destination chain accept that? Can we always assume it's reserve-backed transfers beween AH and Para(more discussion in https://snowfork.slack.com/archives/G01BGMGLAC9/p1724456977726639thread_ts=1724432403.659139&cid=G01BGMGLAC9)?
My concern here is seems not easy to find a common pattern to support multi-hop which applies to all parachains.

One idea I had for the Ethereum->AH->Parachain flow regarding fees on the final destination parachain.
We already take DOT from AH's SA on BH to pay for XCM execution on AH. So we could go on step further and on AH we swap some of that DOT for the native token of the destination parachain.

go on step further and on AH we swap some of that DOT for the native token of the destination parachain.

Sounds good. Can we make the fee asset of destination Para configurable when register token here?
So for chains does allow AH-DOT as fee asset, swap is not required.


Enable tcp/443 as fallback for udp 1194

Hi @kylemanna,
I was wondering if there is a specific reason you disabled tcp 443 for this build? I know udp is preferable, but I was hoping to find a setup that would fallback to tcp 443 if udp is being blocked by a firewall (or random coffee shop's setup).

I was wondering if there is a specific reason you disabled tcp 443 for this
build? I know udp is preferable, but I was hoping to find a setup that would
fallback to tcp 443 if udp is being blocked by a firewall (or random coffee
shop's setup).

The initial incarnation of all of this was intended to be very simple
for the base use case to operate.
That said, in the back of my head I tried to keep it so that power
users could override the config file (i.e. skip the generated file or
modify it) to support whatever they liked.
Support for 443 is definitely available right now if you intend to run
the server dedicated on that port:
docker run --volumes-from $OVPN_DATA --rm kylemanna/openvpn ovpn_genconfig -u tcp://VPN.SERVERNAME.COM

and later map the port accordingly (note: 443 is the public port 1194 is
inside the container and hard coded to 1194 for simplicity since only
one openvpn daemon runs per container.)
docker run --volumes-from $OVPN_DATA -d -p 443:1194/tcp --cap-add=NET_ADMIN kylemanna/openvpn

And things will most likely work as you expect.
What would be an enhancement, would be a method that would allow two
docker-openvpn instances (one on 1194/udp and one on 443/tcp) share the
same EasyRSA PKI certs.
That would require a little bit of work.  Maybe a manually copied config
file that the user would edit and then a script update to allow the
docker run command to select the second config file.
Then users would need to manually update their client config files to
support the ... ... syntax that was removed in
pull request #21

I like  jpetazzo/dockvpn's setup where it runs on both 443 and 1194. When you download his config it defaults to connecting with 1194, but if you change the config and put 443 first it uses that.

Can't download a config on port 443 as:

It's insecure
Nothing else matters after point 1, but....
There are independent configs for each client as opposed to jpetazzo's static key configuration


Remove lein config file from bin folder.

The bin folder is not an exercise.  This commit removes a lein
configuration file that was incorrectly merged in by a previous pull
request.

Haha, yep :) Good call.


DDCE-3243 : Update a11y statement following latest retest

Please do not merge yet as we are awaiting signoff from the Welsh translation team

Signoff from Welsh translation team received. See ticket DDCE-3243


[FEA] Refitting an already fitted workflow for faster iteration

Is your feature request related to a problem? Please describe.
When we are first getting started with NVTabular and doing a bunch of iterations, sometimes, we would only make a very small change to the workflow; however, even with a very small change, we would still need to re-fit the workflow on the dataset.
For example, if we added a ValueCount() operator to of the columns, though the output of the preprocessing would virtually be the same and most columns would not be affected, we would still need to re-fit the entire dataset.
Describe the solution you'd like
So, I wish NVTabular had some way to load back the already fitted workflow to re-fit portions of it slightly differently.
Describe alternatives you've considered
We could simply always work with smaller datasets as we get started so the actual fitting is very quick.
CC: @rnyak

Iterative fitting is something we've considered and would like to do but it's a little ways down our roadmap.  We're going to try to line it up with iterative retraining as well.

Got it - thank you for letting me know!


Remove delete command

Only removes delete command from Logic.
Model still supports deleting of persons.

Pull Request Test Coverage Report for Build 231

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.1%) to 85.07%

Totals

Change from base Build 191:
-0.1%

Covered Lines:
2057

Relevant Lines:
2418

💛  - Coveralls


[cookies] fix chrome aes_cbc plaintext unicode decoding

Decoded Chrome cookies have 32 extra bytes as prefix which mess with unicde decoding
Fixes issue discussed in thread at https://github.com/yt-dlp/yt-dlp/issues/6564
Fixes #6564
Template
Before submitting a pull request make sure you have:

[x] At least skimmed through contributing guidelines including yt-dlp coding conventions
[x] Searched the bugtracker for similar pull requests

In order to be accepted and merged into yt-dlp each piece of code must be in public domain or released under Unlicense. Check all of the following options that apply:

[x] I am the original author of this code and I am willing to release it under Unlicense
[ ] I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

[ ] Fix or improvement to an extractor (Make sure to add/update tests)
[ ] New extractor (Piracy websites will not be accepted)
[x] Core bug fix/improvement
[ ] New feature (It is strongly recommended to open an issue first)

Just for clarification:
Chrome 129 or so come back with 32 extra bytes at the beginning of every cookie. It is likely a signature of some sort but this has not been figured out yet.
This patch maintains backward compatibility with the former versions or in case a fork does not get this change in cookie storage.

For reference, the prepended value is SHA256 hash https://chromium.googlesource.com/chromium/src/+/b02dcebd7cafab92770734dc2bc317bd07f1d891/net/extras/sqlite/sqlite_persistent_cookie_store.cc#223
I will push a change to change the cut based on the meta table version.

So when this merge to master is planned, because Vivaldi is also affected for more than a month now...?


UI improvement for changing attribute color mapping

We are constantly being asked to change attribute colors. We need an easier way to do it.

Changing the color mapping for an attribute should be a button available on the attribute from the short list.

A colormap should appear where the actual colors can be selected, possibly from a color wheel. It is way too cumbersome the way its implemented now.

Requested again at presentation 2/28/2018.

This will go in with the context menu

implemented


Install library headers

Install library headers to allow 3rd party code to link and build against the libraries provided by libcamera-apps.
This is used for INDI Libcamera driver but would be useful for any 3rd party project that wants to build on libcamera-apps.

@krno thank you for this submission.  I think the change is useful, and we should include it.  Would you be able to re-submit this with a commit message that better follows our convention?  Something like:
build: Install library headers

Install the library headers into the system install location...

Please also do add a Signed-off-by: tag to the end of the commit message.

@knro do you intend to update the submission? Otherwise, I can take over.

Please go ahead I got so busy and didn't have time to update it.


Fix  "Out of depth map range error"

Hi,
When both the shoulder and the hip are not in the image, there is an error in depthai with "Out of depth map range error" because the checking of the shoulder inside the image is ignored because xyz_ref = 2 is set anyway.
Not sure if it is intentional. If it is, please close and ignore this PR.

Hi @ibaiGorordo ! Thank you for noticing. You are right, the line xyz_ref = 2 should be removed. This should remove some of the "Out of depth map range" errors.
We will still get some because this error is generated when the ROI sent to the SpatialLocationCalculator is crossing the image border. Typically, it happens when the mid hips (or mid shoulders) is very close to the image border. To completely remove this error, I should make sure that the whole ROI fully stands inside the image area. Added to my todo list.


How to get handlebars's usage in power shell ? [OS: Windows 7]

I saw the usage in page "https://github.com/wycats/handlebars.js". And the web site "http://handlebarsjs.com/precompilation.html", open and scroll to end "Optimizations", here only show the " -k if "...
I wonder how to browse handlebars's usage in windows 7 power shell ?
I try "handlebars -h",  "handlebars -help", "handlebars --help", no one works, why and how ?

Released in 3.0.0


Prokka annotation tutorial: removed unnecessary commands; added slides

For GCC 2019 workshop, took out some extra commands in Prokka and JBrowse that aren't needed anymore; also added a few more annotation slides. Moved slide images up into a higher level "images" directory.

thanks @erasche looks good!

Thanks so much @AnnaSyme!


Feature/import resilience

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Oversights in example project

First of all, thanks for your work on connecting Elysia with Remix!
I noticed some oversights in the example project you provide by running the quick start command in your README.md.
The most major one is the fact that you were importing elysia-remix in a relative manner from the package repository itself, this breaks when running the template command like you instruct, since the example will be cloned alone.
You also run the Vite dev server with the bun --watch flag, which causes an infinite hot reload loop due to conflicts with the native Vite HMR.
I will be opening a PR (#2) to fix these bigger issues, I hope you find it helpful!

Yeah, thanks!
I use relative import for development and forgot remove it later)
And about --watch flag, I think we need to find something that narrows the files that the script overloads when changing


Manual resolution of the muxer for dotnet test MSBuild extension

closes https://github.com/microsoft/testfx/issues/3689

Unrelated failure


minor optimization Message.toString()

StringBuffer -> StringBuilder in Message.toString()
in tests: correlationId is a string, new String(String) can be avoided

Just to have less warnings in IDE :-)

Merged as https://github.com/spring-projects/spring-amqp/commit/3a43611d46c37d311fdb22465547dcb07b5534ad.
Thank you!


Essential Power reading issue

So not really a bug but an issue depending on how you use your AUX port
I use it as a generator input and when the generator is running the Essential Power goes into the negative
If it is being used as a non-essential load then the readon would be correct
Graph from yesterdays loadshedding when the generator kicked in

Today essential power is defined as:
 essential_power = inverter_power + grid_ld_power - aux_power

from the definitions file
 Sensor(175, "Inverter power", WATT, -1),
 Sensor(167, "Grid LD power", WATT, -1),
 Sensor(166, "AUX power", WATT, -1),
 MathSensor((175, 167, 166), "Essential power", WATT, factors=(1, 1, -1)),

maybe we could just change the definition to?
 MathSensor((175, 167, 166), "Essential power", WATT, factors=(1, 1, 1)),

so are you saying that aux_power should only be part of this equation when it's negative?

For what it's worth, my aux_power and essential_power sensors work correctly, though I am using the aux port as an output, not as a generator input.

Thanks @Ivan-L - I'm not using AUX for anything, so the final fix will probably need to check the direction/sign of the AUX power, or use the absolute value of AUX

@lispwarez and @Ivan-L can you both try the essential_abs_power sensor? For now it's a test sensor only in the dev version
It simply reports an absolute value of the current essential_power sensor and will hopefully address the graph above.
There is a second test sensor as well, called essential_l2_power which includes an l2 sensor. Not exactly sure what is being added, but a user on powerforum reported he needed to add the l2_power

I quickly loaded up the dev version now during loadshedding to capture the graph. All is looking correct. Both abs and l2 readings seem to be the same on my side

Great, I'm considering making essential_l2_power the only one as it seems to work in my case as well

Thanks again for the read/write contributions @Ivan-L !! Wish you all the best and happiness in your new home.
An inverter is probably not the first thing you need in your new country, unlike here in sunny South Africa 😉

Added it in https://github.com/kellerza/sunsynk/commit/89df18f459ba1a0b6f9c48ca51eae0a1ce4a9510
Should be released in the new multi inverter addon, but no exact timeline when that will be completed


install.sh fails to download packages (IDFGH-9826)

Answers checklist.

[x] I have read the documentation ESP-IDF Programming Guide and the issue is not addressed there.
[X] I have updated my IDF branch (master or release) to the latest version and checked that the issue is present there.
[X] I have searched the issue tracker for a similar issue and not found a similar issue.

IDF version.
v2.x
Operating System used.
Windows
How did you build your project?
Command line with Make
If you are using Windows, please specify command line type.
None
What is the expected behavior?
Download successful.
What is the actual behavior?
It seems that each package has downloaded a large portion, but it is not complete.
Steps to reproduce.
./esp-idf/install.sh
Build or installation Logs.
Checking "python" ...
Python 3.10.6
"python" has been detected
Installing ESP-IDF tools
Current system platform: linux-amd64
Selected targets are: esp32c3, esp32, esp32s3, esp32h2, esp32s2
Installing tools: xtensa-esp-elf-gdb, riscv32-esp-elf-gdb, xtensa-esp32-elf, xtensa-esp32s2-elf, xtensa-esp32s3-elf, riscv32-esp-elf, esp32ulp-elf, openocd-esp32
Installing<EMAIL_ADDRESS>Downloading https://github.com/espressif/binutils-gdb/releases/download/esp-gdb-v11.2_20220823/xtensa-esp-elf-gdb-11.2_20220823-x86_64-linux-gnu.tar.gz
Destination: /home/none/.espressif/dist/xtensa-esp-elf-gdb-11.2_20220823-x86_64-linux-gnu.tar.gz.tmp
96%WARNING: Download failure <urlopen error retrieval incomplete: got only 25901812 out of 26947336 bytes>
WARNING: file size mismatch for /home/none/.espressif/dist/xtensa-esp-elf-gdb-11.2_20220823-x86_64-linux-gnu.tar.gz.tmp, expected 26947336, got 25901812
WARNING: Failed to download https://github.com/espressif/binutils-gdb/releases/download/esp-gdb-v11.2_20220823/xtensa-esp-elf-gdb-11.2_20220823-x86_64-linux-gnu.tar.gz to /home/none/.espressif/dist/xtensa-esp-elf-gdb-11.2_20220823-x86_64-linux-gnu.tar.gz.tmp
Downloading https://github.com/espressif/binutils-gdb/releases/download/esp-gdb-v11.2_20220823/xtensa-esp-elf-gdb-11.2_20220823-x86_64-linux-gnu.tar.gz
Destination: /home/none/.espressif/dist/xtensa-esp-elf-gdb-11.2_20220823-x86_64-linux-gnu.tar.gz.tmp
96%WARNING: Download failure <urlopen error retrieval incomplete: got only 25903104 out of 26947336 bytes>
WARNING: file size mismatch for /home/none/.espressif/dist/xtensa-esp-elf-gdb-11.2_20220823-x86_64-linux-gnu.tar.gz.tmp, expected 26947336, got 25903104
WARNING: Failed to download https://github.com/espressif/binutils-gdb/releases/download/esp-gdb-v11.2_20220823/xtensa-esp-elf-gdb-11.2_20220823-x86_64-linux-gnu.tar.gz to /home/none/.espressif/dist/xtensa-esp-elf-gdb-11.2_20220823-x86_64-linux-gnu.tar.gz.tmp
Downloading https://github.com/espressif/binutils-gdb/releases/download/esp-gdb-v11.2_20220823/xtensa-esp-elf-gdb-11.2_20220823-x86_64-linux-gnu.tar.gz
Destination: /home/none/.espressif/dist/xtensa-esp-elf-gdb-11.2_20220823-x86_64-linux-gnu.tar.gz.tmp
96%WARNING: Download failure <urlopen error retrieval incomplete: got only 25919488 out of 26947336 bytes>
WARNING: file size mismatch for /home/none/.espressif/dist/xtensa-esp-elf-gdb-11.2_20220823-x86_64-linux-gnu.tar.gz.tmp, expected 26947336, got 25919488
WARNING: Failed to download https://github.com/espressif/binutils-gdb/releases/download/esp-gdb-v11.2_20220823/xtensa-esp-elf-gdb-11.2_20220823-x86_64-linux-gnu.tar.gz to /home/none/.espressif/dist/xtensa-esp-elf-gdb-11.2_20220823-x86_64-linux-gnu.tar.gz.tmp
ERROR: Failed to download, and retry count has expired
Traceback (most recent call last):
  File "/home/none/esp32-arduino-lib-builder/esp-idf/tools/idf_tools.py", line 1976, in <module>
    main(sys.argv[1:])
  File "/home/none/esp32-arduino-lib-builder/esp-idf/tools/idf_tools.py", line 1972, in main
    action_func(args)
  File "/home/none/esp32-arduino-lib-builder/esp-idf/tools/idf_tools.py", line 1509, in action_install
    tool_obj.download(tool_version)
  File "/home/none/esp32-arduino-lib-builder/esp-idf/tools/idf_tools.py", line 764, in download
    raise DownloadError()
__main__.DownloadError

More Information.
There is a proxy on my router (openwrt), but it does not require any settings on the operating system.
I attempted to execute install.sh on ubuntu 22.10 amd64 (Python 3.10.6), ubuntu 18.04 aarch64 (Python 3.7.6 chroot), and android 11 aarch64 (Python 3.10.6 self compiled environment), but both errors were the same
Finally, I tried using Raspberry Pi 3b+(the latest raspberry os armhf) (Python 3.9.2) to execute this script, but it ran normally and without any errors. 🤯
They are all connected to my router at the same time, I really don't know why. Although I can compile with Raspberry Pi 3b+, the efficiency is really too low.
I have found similar issues, but they seem to be caused by Python 2 and are not applicable to me.

please remove the dependent folder .espressif and reinstall all dependent.before use below command make shoure you have add IDF_PATH in your environment
python -m pip install --user -r $IDF_PATH/requirements.txt

Sadly, this bug has not been solved....

please remove the dependent folder .espressif and reinstall all dependent.before use below command make shoure you have add IDF_PATH in your environment
python -m pip install --user -r $IDF_PATH/requirements.txt

Sadly, this bug has not been solved....

as you are using older version of idf so there are chance those resource not available right now upgrade your ide version5 and verify once

I'm very sorry, it seems that I am using the master branch. When I manually download the corresponding file using wget, the script can run normally. This has solved my urgent need.

Hi @Oopas. Do you have a proper Internet connection on your Windows machine?
/home/none/.espressif/ - I don't understand these paths. You said that you are using Windows. This doesn't seem to me a Windows path.
v2.x - this doesn't look like the ESP-IDF version. Can you check the proper version please?

https://github.com/espressif/binutils-gdb/releases/download/esp-gdb-v11.2_20220823/xtensa-esp-elf-gdb-11.2_20220823-x86_64-linux-gnu.tar.gz

Are you able to download the file shown in the error message with your Internet browser?
If download works with the Internet browser then you can download the files there and put them inside the /home/none/.espressif/dist/ directory. After that you can re-run the install script and it won't need to download it anymore.

I'm very sorry, it seems that I am using the master branch. When I manually download the corresponding file using wget, the script can run normally. This has solved my urgent need.


Adding support to other LoRa boards/device hats

I saw that there was support for the author's RNode LoRa device, but would the same Interface work with other LoRa boards?
Like this one, for example: https://www.amazon.com/Frequency-Spectrum-Modulation-Raspberry-Interface/dp/B07VS47RQZ
Would I need to change any of the code from the RNode Interface to use this device?
I saw that the RNode uses a Semtech SX1276 Chip, but the example board uses a SX1262 Chip. Would that change the syntax needed?
Thanks for any replies.

Hello! @markqvist already has worked on a tool to configure off-the-shelf LoRa into functional RNodes: rnodeconfigutil.
It currently supports:

The original RNode from unsigned.io
Homebrew RNodes based on ATmega1284p boards
Homebrew RNodes based on ATmega2560 boards
Homebrew RNodes based on Adafruit Feather ESP32 boards
Homebrew RNodes based on generic ESP32 boards
LilyGO T-Beam v1.1 devices
LilyGO LoRa32 v2.0 devices
LilyGO LoRa32 v2.1 devices

I've also had success with using it with a Heltec ESP32 LoRa board.
Please feel free to follow up if you have any other questions.

Yes, the easiest route to support new LoRa transceiver boards is to add support to the RNode Firmware and RNode Config util.
Adding support for the SX1262 family of devices is already on the roadmap, and work on that should start in the not-too-distant future. You can also have a look at this section of the Reticulum repo README for a general overview of where the development is heading.
Speaking in broad terms, there is huge potential for adding support for the many hundreds of kinds of transceiver modules available, and it is most definitely the intention to exploit that potential.
It needs to be done in the most optimally ordered, generalized and efficient way, so we don't end up needing to maintain 150+ codebases for different transceiver types ;) That is also why LoRa transceiver support currently exists under the RNode umbrella.


Empty output_got.csv

Twitter weird response. Try to see on browser: https://twitter.com/search?q= europe refugees&src=typd
Done. Output file generated "output_got.csv".
get "Twitter weird response"  tried solution in https://github.com/Jefferson-Henrique/GetOldTweets-python/issues/176 but still get twitter weir response

same issue, tried the same solution, still not working.


feat: port Analysis.NormedSpace.OperatorNorm

I merged master in order to get the fixes from https://github.com/leanprover-community/mathlib4/pull/3800

Closed in favour of #3903


fea(native plugin): add sql source native plugin

Signed-off-by: Jianxiang Ran<EMAIL_ADDRESS>

commit name typo fea


fix(markdown-widget): support arbitrary component order

Fixes #5258

Summary
Updates remarkShortcodes to handle custom editor components occurring in
any order in a given markdown field.
Previously, remarkShortcodes (the remark tokenizer plugin in the markdown widget) was relying on Map.find to attempt to match the registered editor components' patterns against the remaining uneaten markdown. Because Map.find returns after the first instance that returns true, some valid shortcode matches can be "skipped" by the plugin, and parsed as plain text instead.
This made it almost impossible to use multiple shortcodes in a single markdown field. At least one of them regularly gets "skipped" by the tokenizer.
This also updates the initial value returned by getEditorComponents() to correctly be an instance of Map, instead of an empty array.
Test plan
Unit Tests
I've updated the unit tests in the following ways:

I'm now passing an instance of Map as the second argument to process, instead of an array, because that's what is actually passed in the code
I've added a new unit test that covers this case, relying on an OrderedMap to force a specific coincidental state that would have triggered the bug in the previous code (I verified that this new test does in fact fail under the previous code)

Manual Inspection
I built this package locally and linked it into the project that I first identified this bug in, and verified that it resolved this issue and that I could not identify any new issues:
Before:

After:

A picture of a cute animal (not mandatory but encouraged)
Some very tired dogs, as tribute:

Sorry for the delay here, @erezrokah, I have some personal stuff going on right now that's pulled me away from this. I should be able to make these changes in the next two weeks!

No worries @SMores, I appreciate the status update.

I suspect this might be a bug I'm running into... is there anything blocking this?

I suspect this might be a bug I'm running into... is there anything blocking this?

Hi @jasikpark, changes were requested for the PR - see the comments. However if someone else would like to pick this up I don't think anyone would object.

I apologize. I didn't mean to approve this. I didn't even know I could approve this.

Closing this for now. Please comment on the PR if still relevant and I'll re-open

I can't necessarily tell whether this would fix my problems with netlify editor component parsing, but it seems like a good start...

Sorry I dropped the ball here; picking this back up now! @erezrokah would you be alright with reopening?

I would just make the changes, while still waiting on the PR to reopen

Changes have been pushed! It looks like GitHub stops syncing updates from forked repos when a PR is closed, though :P

Thanks @SMores, I can't re-open:

Not sure why. Can you open a new one?

Reopened in #5597. Sorry, I didn't realize force pushing would break anything!


Problem with Etc/GMT+X

Hi guys! I bring you a problem I'm getting using the library in the client side:
My local time is GMT+1 and I'm experimenting using the Etc/GMT+X transformation. For example:
var d = new Date();
//> d
//< Wed Feb 18 2015 13:15:58 GMT+0100 (CET)
moment(d).tz('Etc/GMT+1').format('h');
//< 11

The expected ouput is 1 but I get two hours less. However, if a try with the negative offset:
moment(d).tz('Etc/GMT-1').format('h');
//< 1

Is this a bug or am I missing something?
Thanks in advance

This is by design in the tzdb.  See the last paragraph under "Area" in the Wikipedia article.  See also the comments in the tzdb itself

Thanks for the info, very useful :)

BTW this is very confusing and you could point it in your documentation IMHO

@IvanGuardado  See also moment/moment-timezone#179


Ice connection fails, how can I know what is wrong?

Hi!
I have an application using the latest version RTCMultiConnection and it works well with most person I test it with.
But with some people, the Ice negotiation just fails, giving me the RTCMultiConnection error "ICE connectivity check is failed. Renegotiating peer connection."
Is there a way to know what is wrong?
Thanks.
EDIT: I have tested some online demo of webrtc with these persons and it works without problem. ;(

@muaz-khan
Hi Muaz Khan
i am facing similar problem and you are right , it success from second try ,till here i am able to find a solution but after some times some users are disconnected for some reason and the console show error
i think there is a problem in signal server.

@muaz-khan
this issue appear while you are on same network using wfi or on different network

@muaz-khan
onfailed event is not fired also

@muaz-khan
waiting your reply

Stop flooding.

did you solve the problem?


theme editor in the front

theme editor is not showing in the frontend

Unfortunately, we haven't adapted the Theme Editor for this theme yet.

Why don't you use less bootstrap version?
https://github.com/twbs/bootstrap/tree/master/less

@WorckOleg: There is an opened issue (#26) for this request.

I would prefer to keep Theme Editor support separate from the boilerplate theme, since it's not necessary in some cases.
An obvious example is when a theme is being purpose-built for a single store, without the intention to provide customisation via Theme Editor to the store owner (so they would not ruin the design, etc).

@demeldoo , @matthewmorek , from CS-Cart 4.3.6 Theme Editor has been moved in admin area, so at the moment theme will work fine if you will add "Styles" with less variables.  (from last week we decided to remove styles folder because she was empty)

@demeldoo , @matthewmorek , Theme editor working will be added in CS-Cart 4.3.7. So if u have another version you can't use Theme editor in Boilerplate


Missing requirements.txt?

Hi there the installation instructions mention a requirements.txt but I am not seeing one, please advise

The requirements.txt was just added in commit d92f8555.


Rearrange/reword storage release notes for 1.6

CC @kubernetes/sig-storage-misc

using a link now, @jeffvance

@saad-ali, @jeffvance could you or someone from @kubernetes/sig-storage-misc please collect, summarize, and remove the autogenerated release notes from the bottom of the doc. Thanks!

@calebamiles Under Flex Volume Plugin there is this "Breaking changes": Flex volume plugin is updated to support attach/detach interfaces, however this change does not appear to be listed in the "Action Required" summary.

Maybe for a future pr, but it would be nice if there was a way to generate an index or TOC based on important words, such has "taints", "volumes", "storage class" etc. Maybe there are too many "important" words for this be useful, but, thinking out loud, it would nice to see some order to the action-able and noteworthy changes.

@ethernetdan can we merge this please

@saad-ali I will include your updates to my PR with the pre-final release notes.


Minor improvement to Mac OS install instructions

Tickets addressed: N/A
Review: By commit
Merge strategy: Merge (no squash)

Description
Clarify the version requirement for conan in the sample script. Without this, the first run for somebody on Mac OS will result in a conan error. The version requirements are actually documented elsewhere, however we should just give users the correct command to copy/paste in the first place.
Verification
Executed command manually on local machine.
Documentation
N/A
Future work
N/A

Thanks for sharing your idea.  However, the latest develop already has verbose print statements to the terminal if it finds a wrong version of conan installed.  The issue with the newer 2.x version of conan are common across all three supported platforms, not just macOS.   You should not be getting an error now when running python conanfile.py, even if you have the the newest conan installed.  I just re-tested this and got this error message:
conan version 2.0.6 is not compatible with Basilisk.
use version 1.40.1 to 1.59.0 to work with the conan repo changes.

Further, rather than making the correction mentioned, the install page mentions at the top the required versions of packages.  These are read in currently from a single file so I don't have to maintain multiple RST install pages.  Thus, I don't want to modify the install instructions as you suggest.

@schaubh  Thanks for the thoughtful response here!
Just to be clear (and for others), I got to the stage in the install doc where it says pip3 install wheel conan and hadn't mentally carried through the version requirement at the top of the doc. I just copy/pasted the command and ran it, then hit a conan-related issue in a following step. I am not personally familiar with conan at all, so I had to take a step back and do some on the fly debugging to figure out what i had missed.
If develop handles this version dependency mismatch more gracefully, then that solves the core issue I was trying to address here and my change is not necessary. Thanks again!

Correct, the current version of develop has new code in it to catch someone running conan 2.x and the prints out the version incompatibility issue above.  Long-term we are looking to migrate to the new conan 2.x architecture, but haven't had time for this transition.  It isn't a trivial upgrade.


.NET Alpha SDK

Alpha Checklist:

[x]  spec compliant
[x]  contains test suite which verifies behavior consistent with spec
[x]  contains test suite with reasonable coverage
[x]  automated publishing
[ ]  comprehensive readme

@beeme1mr i think we can close this one out after https://github.com/open-feature/dotnet-sdk/pull/41 has been merged

Yep, I agree.


Update configs via scripts.

#14

As noted in the related issue - #14 - I'm closing this PR as we're not using Parcel any more.


some problems about basicvsr++ training

When I train the basicvsr++ using the Default Settings of configs,I met the error:
ValueError: You may use too small dataset and our distributed sampler cannot pad your dataset correctly. We highly recommend you to use fewer GPUs to finish your work
I use : ./tools/dist_train.sh configs/restorers/basicvsr_plusplus/basicvsr_plusplus_c64n7_8x1_600k_reds4.py 8

Hello @Shuweis, thanks for your report. This is because REDS4 contains 4 folders and we have 8 GPUs. This issue has been fixed in #672, please have a look, thanks!

Closing this issue since the bug has been fixed in a merged pull request.
Please feel free to reopen it if it has not been fixed.


Multisig. Multisig creation. Network list opens inside the window

Description
When user create a multisig - Network list opens inside the window and it's hard to navigate
https://github.com/user-attachments/assets/a6b773ae-dbd3-4097-8ed7-5d7dc161e3e8
Environment
https://github.com/novasamatech/nova-spektr/commit/cc8d6ced61346b84c2790a5d07744512c16b3537

Status verification: ✅


Make Fab and Button submit form

Hi,
We have a Page with a List of Input for the user to enter data, and aFab (or Button depending on platform) to save. We would like to wrap both the List and the Fab inside a <form> so that we can utilize browser's form validation and bind onSubmit. However, since those buttons are not real buttons, they won't submit the form.
I'd rather not bind onClick on them to submit the actual form node through refs. Is there a way to achieve form submission?

Thanks @sntran for your question. We will look into it, but it might be also a good Question to rather look into our community (community.onsen.io)

Mhh, i am not 100% sure, but what is your problem @sntran? The fact that you don't like to use ref? You could use window.document.form or document.getElementById and set the id of the form if you think this is nicer. I cannot think about something out of my head right now, but please feel free to ask in our community (https://community.onsen.io/).

Hi @philolo1 .
I guess my issue is that <ons-button>, and by definition, <Button> React component, should wrap a HTML button element instead of providing custom markup. This way the component is still a valid button, and can act like a button, i.e, submitting the form it is contained in. This is the standard behavior of HTML. And <Button> component does not do that.

@sntran we are using Custom Components to enable more functionality for the button. So I guess what you want is that the ons-button works like a normal button for forms. I think this is an enhancment that belongs to rather the core. I think for now you should just use the normal <button>, but we might implement something like that in the future.

Thank you @philolo1 for opening an issue at OnsenUI/OnsenUI.

I will close this since it's an issue in the core.


Testing the interface between tiny/v0.1 and eembc

Hi, I want to test how the eembc benchmark runner interfaces with the tiny v0.1, and wanted to do that by deploying one of the reference submissions locally, on a desktop and testing it with the eembc runner. Is there a reference implementation for that somewhere?
So far I've only found examples that must be compiled with MBED and deployed to dedicated hardware. I'm also unaware if these examples are ready-to-go, or if they require additional work like creating/compiling a model a certain way before testing it.

Hi,
The reference submissions should be 'ready to go' (with minor things still being checked in) as long as you follow the steps in the READMEs. The models used in the reference submissions have already been converted to TF lite micro format. You do need an mbed platform to run the reference submissions.
EEMBC's runner assumes a USB serial connection to the device under test so I'm not sure it would work with something running locally.
Is there something specific you wanted to test about the interface?

My team had several goals in mind:

Test a pretrained model locally to see timing and performance numbers and compare them to our own test stack.
Deploy a model to RPi (Cortex-A) and test

We're a little confused about the process to deploy to RPi that won't break the EEMBC interface.
Are there any reference examples for an RPi/Cortex-A?

Good goals!
I'd suggest:

The benchmark relies on a timer on the DUT to measure latency. It would probably be easiest to implement the C++ API to run on your model locally and time the latency without the EEMBC runner. The accuracy test sets used by the runner are available here so you can test the accuracy without the runner as well.
Deploying an RPI shouldn't be an issue as long as there is some UART connection with the host. As a side note, the benchmarks may be trivial for Cortex-A class systems.

Hello @colbybanbury,
Thanks for the quick reply. With regards to the EEMBC runner, I followed the readme to setup only the performance runner (no energy hardware implemented). The one portion of this segment of the README that was temporarily skipped is the compilation for our submission. For the time being, we're getting familiar with how everything pieces together :)
This is the segment that was skipped:

Compile as EE_CFG_ENERGY_MODE 0 (see the #define in monitor/th_api/th_config.h or api/submitter_provided.h). Program the th_timestamp function to return the current microseconds since boot time (e.g., with a MCU counter or system timer).
My current setup right now is having a Pi 4 directly connected to my Windows (also tried this on Mac OSX) host machine using a USB to TTL adapter.

I'm also able to ssh via COM3 on Windows with Putty without any issues. When starting the EEMBC Runner, I am unable to get the device to list. COM3 is detected, but I keep getting 00001.271 framework: Serial COM3 failed name check, skipping.
00000.394 framework: Package version: 3.0.2
00000.395 framework: Mode: production
00000.395 framework: User home directory is C:\Users\honson
00000.395 framework: Session storage directory is C:\Users\honson\eembc\runner\sessions
00000.396 framework: Temporary storage directory is C:\Users\honson\eembc\runner\temp
00000.396 pnp: m-scan-start
00000.396 pnp: Looking for 'EEMBC Serial' devices...
00000.398 framework: Serial scan using 115200 baud
00001.271 framework: Serial COM3 failed name check, skipping
00001.271 pnp: Looking for 'Joulescope' devices...
00001.271 pnp: Looking for 'STMicroelectronics LPM01A' devices...
00001.272 pnp: m-scan-stop
00001.272 framework: m-ready

Additional, I have ensured that .eembc.ini has a matching baud rate and have tried to increase the time for detection of devices to 10s. Here is a copy of my .eembc.ini:
default-timeout-ms=5000
dut-baud=115200
dut-boot-mv=10000
emon-drop-thresh-pct=0.1
root=C:\Users\iFai1
timestamp-hold-us=50
umount-on-error=true
use-crlf=false
use-visa=false
n6705-set-vio=false

There's some references in the readme that suggest to also make sure the command name% returns back the device name, but I'm not sure if this is referring to the CLI in the EEMBC Runner, or the Putty Terminal. Any help would be great! We seem to be close.

Additional note: I'm aware there is a similar post here. Just an assumption, is the EEMBC Runner searching for MBED devices that have the compiled .bin flashed onto the device? That would be the only reason I would expect the device not to detect. Is there currently a flow to support the Pi on the EEMBC Runner?

Hi,
Yes, you're right! The runner looks to handshake with the device under test via the 'name' command. They don't have to be MBED devices though they just need to be running the benchmarking API.
We haven't tested the Pi ourselves but you should be able to port the benchmarking API to the Pi without too much trouble. Sorry for the lack of RasPi support, it's somewhat outside of the target device range. It would be nice to know if it works though.

You need to connect to the UART on the Pi, not the process listening to UART. Two very different things. The printf and getchar functions in the test harness must use the actual UART TX/RX, not the console. I believe this requires changing the boot config on the Pi to not set-up a terminal on the UART, and then writing that layer yourself with the C libraries to retarget stdout/stdin in GCC to that port.

@petertorelli thanks for clarifying. We managed to retarget stdin/stdout, and now are working on getting some inference tests going.
I am able to see my device in the runner. After placing the datasets from the runner to the directory listed in red text on the runner, I pressed initialize, then benchmark. I'm currently facing some bugs on this end, and wanted to see where I would go debug further. Any suggestions will be greatly appreciated!
01582.242 parser: Command "mountc dut dut"
01582.317 dut: e-[Unknown command: nam]
01582.317 dut: m-ready
01582.317 sequencer: e-[Unknown command: nam]
01582.317 sequencer: m-sequencer-stop
01582.317 parser: e-['bm init' failed, unmounting all devices]
01582.317 parser: e-[Command 'bm' failed: Unknown command: nam]
01582.317 mounter: m-mounted-alias[dut]-uid[COM3]-driver[eeserial]
01582.317 parser: m-ready-finished[bm]
01582.317 parser: m-ready-finished[mountc]
01583.595 parser: Command "bm run ulp-mlperf"
01583.595 session: m-session-start-id[20210426194846]
01583.595 parser: m-bmark-run-name[ML Performance 1.0.0]-code[ulp-mlperf]
01583.596 parser: e-[Command 'bm' failed: Model not defined]
01583.596 parser: m-ready-finished[bm]

Your serial interface is malfunctioning. I'm not sure what the problem is but the DUT is not advancing/clearing the command buffer, as it is clearly stuck at 'nam', but it seems to be parsing the terminator so I don't know what is up.
If you mount the DUT with mountc dut dut and then type dut name and dut profile it should print the name of the device and the model it is compiled for. If this doesn't work the UART interface on the Pi is not implemented correctly. If this does work then we can debug the Runner further.

Hello @petertorelli. Thanks for the quick reply.
Here is the log of the suggested commands you have given:
17229.147 parser: Command "mountc dut dut"
17229.227 dut: m-name-dut-[raspberry-pi-4]
17229.227 dut: m-ready
17229.227 mounter: m-mounted-alias[dut]-uid[COM3]-driver[eeserial]
17229.227 parser: m-ready-finished[mountc]
17236.781 parser: Command "dut name"
17236.781 parser: m-ready-finished[dut]
17236.825 dut: m-name-dut-[raspberry-pi-4]
17236.841 dut: m-ready
17241.337 parser: Command "dut profile"
17241.337 parser: m-ready-finished[dut]
17241.400 dut: m-profile-[ULPMark for tinyML Firmware V0.0.1]
17241.416 dut: m-model-[vww01]
17241.432 dut: m-ready

If it helps, we were working on writing the implementation of the serial connection, but have also found out that the following command has also made it possible for the runner to communicate with our program. I'm mentioning this here in case this would be the cause of the command buffer not clearing, or data not sending to the device. For this experiment, we're simply testing rerouting stdin/stdout between the program and the runner as such:
./bin/main < /dev/ttyS0 > /dev/ttyS0

Interesting. Could be a buffer flush issue with the Unix pipes + O/S, a previous run had half a command in it and was followed by a new command which caused an error, I've seen that happen before when the UART code doesn't flush properly. Might have been leftover data in the unix pipes on a restart. Manual mount works, and initialization sends those exact commands. What happens when you type bm init ulp-mlperf?

00046.740 parser: Command "mountc dut dut"
00046.810 dut: e-[Unknown command: nme]
00046.810 mounter: m-mounted-alias[dut]-uid[COM3]-driver[eeserial]
00046.810 parser: m-ready-finished[mountc]
00046.826 dut: m-ready
00052.038 parser: Command "dut name"
00052.039 parser: m-ready-finished[dut]
00052.088 dut: m-name-dut-[raspberry-pi-4]
00052.088 dut: m-ready
00054.286 parser: Command "dut profile"
00054.286 parser: m-ready-finished[dut]
00054.360 dut: m-profile-[ULPMark for tinyML Firmware V0.0.1]
00054.376 dut: m-model-[vww01]
00054.376 dut: m-ready
00057.676 parser: Command "bm init ulp-mlperf"
00057.676 sequencer: m-sequencer-start
00057.676 sequencer: m-sequencing-i[1]-command[umount]-ack[/parser: m-ready/]-ms[5000]-acc[0]-total_ms[15000]
00057.676 parser: Command "umount"
00057.676 mounter: Unmounting "dut"
00057.791 mounter: m-unmounted-alias[dut]
00057.791 parser: m-umount-done
00057.791 parser: m-ready-finished[umount]
00057.791 sequencer: m-sequencing-i[2]-command[mountc dut dut]-ack[/parser: m-ready/]-ms[5000]-acc[5000]-total_ms[15000]
00057.791 parser: Command "mountc dut dut"
00057.863 dut: e-[Unknown command: nme]
00057.863 sequencer: e-[Unknown command: nme]
00057.863 sequencer: m-sequencer-stop
00057.863 parser: e-['bm init' failed, unmounting all devices]
00057.864 parser: e-[Command 'bm' failed: Unknown command: nme]
00057.864 mounter: m-mounted-alias[dut]-uid[COM3]-driver[eeserial]
00057.864 parser: m-ready-finished[bm]
00057.864 parser: m-ready-finished[mountc]
00057.879 dut: m-ready

this was also another issue we had where some bytes were dropping (i.e nme, nam, etc). Rerunning bm init ulp-mlperf after the log above, I was able to get this:
00105.226 parser: Command "bm init ulp-mlperf"
00105.226 sequencer: m-sequencer-start
00105.226 sequencer: m-sequencing-i[1]-command[umount]-ack[/parser: m-ready/]-ms[5000]-acc[0]-total_ms[15000]
00105.226 parser: Command "umount"
00105.226 mounter: Unmounting "dut"
00105.342 mounter: m-unmounted-alias[dut]
00105.342 parser: m-umount-done
00105.342 parser: m-ready-finished[umount]
00105.342 sequencer: m-sequencing-i[2]-command[mountc dut dut]-ack[/parser: m-ready/]-ms[5000]-acc[5000]-total_ms[15000]
00105.342 parser: Command "mountc dut dut"
00105.403 dut: m-name-dut-[raspberry-pi-4]
00105.419 dut: m-ready
00105.419 mounter: m-mounted-alias[dut]-uid[COM3]-driver[eeserial]
00105.419 parser: m-ready-finished[mountc]
00105.419 sequencer: m-sequencing-i[3]-command[dut profile]-ack[/dut: m-ready/]-ms[5000]-acc[10000]-total_ms[15000]
00105.419 parser: Command "dut profile"
00105.419 parser: m-ready-finished[dut]
00105.483 dut: m-profile-[ULPMark for tinyML Firmware V0.0.1]
00105.499 dut: m-model-[vww01]
00105.515 dut: m-ready
00105.515 sequencer: m-sequencer-stop
00105.515 parser: m-ready-finished[bm]

Some more examples of dropped bytes in the commands being sent over posted below (i.e. timestamp). This is the log from pressing run on the performance benchmarks:
00757.271 parser: Command "bm cfg ulp-mlperf runMode"
00757.780 parser: m-bm-cfg-name[ulp-mlperf]-key[runMode]-val[single]
00757.780 parser: m-ready-finished[bm]
00757.780 sequencer: m-sequencing-i[3]-command[dut timestamp]-ack[/dut: m-ready/]-ms[5000]-acc[10000]-total_ms[457368]
00757.780 parser: Command "dut timestamp"
00757.780 parser: m-ready-finished[dut]
00757.831 dut: e-[Unknown command: tmestamp]
00757.831 sequencer: e-[Unknown command: tmestamp]
00757.831 sequencer: m-sequencer-stop
00757.831 session: m-session-stop-id[20210427131120]
00757.831 session: Saved this run to session ID<PHONE_NUMBER>1120
00757.832 parser: e-['bm run' failed, unmounting all devices]
00757.832 mounter: Unmounting "dut"
00757.950 mounter: m-unmounted-alias[dut]
00757.951 parser: e-[Command 'bm' failed: Unknown command: tmestamp]
00757.951 parser: m-ready-finished[bm]

Yep, that looks a lot like when the UART buffer is overflowing / not draining.

Hi @petertorelli thank you for your inputs. They've been very useful in guiding us towards getting the UART working end to end. In our experiments, we're noticing that the model under test ends up being set to vww01. How would we make sure that the handshake tells the runner to use ic01?

@videetparekh By setting the proper #define in the submitter implemented header file found here : https://github.com/mlcommons/tiny/blob/1e3bdc19aaa70009c0d9d17ed9c78bcc989e077b/v0.1/api/submitter_implemented.h#L43-L49

Is this resolved, can it be closed now?

@petertorelli Yes! Thank you for all your help.


Create user in domain for primary/backup domain controllers

What does this PR do?
Changes how we handle creating dd-agent-user

On all machines, allows users to specify on command line the ddagent user name and/or password
On domain controller machines, requires user to specify ddagent user name and password

Motivation
Previously known limitations on how we handle creating user in domain environment
Additional Notes

created against wrong branch


Add support for --help flag in core

Passing the --help flag should cause the application to print a document to the console describing the way the configuration system was wired together. This work MUST be done prior to wiring any modules, so additional logs will not be emitted
This command will:

iterate through each project going into the application
print out a list of all configuration properties

name, description, type, module level default value, value enum, required state
environment variable / --switch that can be used to define the value

A related flag should also be introduced to just dump the data as json, for processing by other scripts

Blocked by #86


Fix: remove extra Precondition constructor

Fixes #64

Coverage remained the same at 98.182% when pulling 2bde06421373f23cb5495f7936786516f7b3b595 on remove-extra-precondition into c83d26d70a584ca44baf6227002f6a53340ac16a on master.

Coverage remained the same at 98.182% when pulling 2bde06421373f23cb5495f7936786516f7b3b595 on remove-extra-precondition into c83d26d70a584ca44baf6227002f6a53340ac16a on master.

Coverage remained the same at 98.182% when pulling 2bde06421373f23cb5495f7936786516f7b3b595 on remove-extra-precondition into c83d26d70a584ca44baf6227002f6a53340ac16a on master.

Coverage remained the same at 98.182% when pulling 2bde06421373f23cb5495f7936786516f7b3b595 on remove-extra-precondition into c83d26d70a584ca44baf6227002f6a53340ac16a on master.