v5.4.1: after restart all tikv/pd/tidb, one tikv continue report error "invalid store ID 0, not found"

Bug Report

What version of TiKV are you using?

./tikv-server -V
TiKV
Release Version:   5.4.0
Edition:           Community
Git Commit Hash:   44d2e7e8d86566b4b270c1ae39a4956e0f74a6e8
Git Commit Branch: heads/refs/tags/v5.4.1
UTC Build Time:    2022-04-29 06:35:41
Rust Version:      rustc 1.56.0-nightly (2faabf579 2021-07-27)
Enable Features:   jemalloc mem-profiling portable sse test-engines-rocksdb cloud-aws cloud-gcp cloud-azure
Profile:           dist_release
What operating system and CPU are you using?

Steps to reproduce

tcms test plan:
<EMAIL_ADDRESS>following tidb global config has been set.
tidb_partition_prune_mode='dynamic' ,
tidb_replica_read='follower'
What did you expect?
tikv should works fine.
What did happened?
Tikv heartbeat with pd disconnect after that, no region message update from pd monitor.
tikv logs:
Status { code: 2-UNKNOWN, message: "invalid store ID 0, not found", details: [] }))"]
tikv.log:[2022/05/10 02:28:24.557 +00:00] [ERROR] [util.rs:460] ["request failed"] [err_code=KV:PD:gRPC] [err="Grpc(RpcFailure(RpcStatus { code: 2-UNKNOWN, message: "invalid store ID 0, not found", details: [] }))"]
tikv.log:[2022/05/10 02:28:25.558 +00:00] [ERROR] [util.rs:460] ["request failed"] [err_code=KV:PD:gRPC] [err="Grpc(RpcFailure(RpcStatus { code: 2-UNKNOWN, message: "invalid store ID 0, not found", details: [] }))"]
tikv.log:[2022/05/10 02:28:25.565 +00:00] [ERROR] [util.rs:460] ["request failed"] [err_code=KV:PD:gRPC] [err="Grpc(RpcFailure(RpcStatus { code: 2-UNKNOWN, message: "invalid store ID 0, not found", details: [] }))"]
tikv.log:[2022/05/10 02:28:25.565 +00:00] [ERROR] [raft_client.rs:749] ["resolve store address failed"] [err_code=KV:Unknown] [err="Other("[src/server/resolve.rs:102]: RpcFailure: 2-UNKNOWN invalid store ID 0, not found")"] [msg="region_id: 134700 from_peer { id: 134703 store_id: 6 } to_peer {} region_epoch { conf_ver: 11 version: 1138 } extra_msg {}"] [store_id=0]
tikv.log:[2022/05/10 02:28:25.565 +00:00] [ERROR] [util.rs:460] ["request failed"] [err_code=KV:PD:gRPC] [err="Grpc(RpcFailure(RpcStatus { code: 2-UNKNOWN, message: "invalid store ID 0, not found", details: [] }))"]

/type bug
/assign @5kbpers
/severity Critical
/found automation

Investigated that it was caused by a bug introduced by #8820.
#8820 introduces a mechanism that when a follower with no leader information wants to send a ReadIndex, it will try to query leader information from PD and send a "wakeup message" for waking up a hibernated leader.
https://github.com/tikv/tikv/blob/6d24c60586ac94ba24a16513b92989f63b8fced7/components/raftstore/src/store/peer.rs#L3597-L3599 https://github.com/tikv/tikv/blob/6d24c60586ac94ba24a16513b92989f63b8fced7/components/raftstore/src/store/fsm/peer.rs#L992-L999
The problem is sometimes PD doesn't have any knowledge about region leaders. Despite https://github.com/tikv/pd/pull/2591 starting to sync region leaders to PD followers, when all PD peers restarted then region leaders info could still get lost.

/LGTM


jmeterUserProperties are not working

I cannot get user jmeterUserProperties to work with ${__P(...)}.
I'm running the jmeter 2.4 plugin using maven. I've added the following to the POM as explained in the wiki:

${project.build.directory}/jmeter

hostname.com

The test is running fine, but everywhere where I try to get the variable it is not evaluated.
For example in User Defined Variables I've added a variable with the value ${__property(someVariableName)}, but the value isn't set to "hostname.com" as I would have expected, but "${__property(someVariableName)}"

Turned out not to be a problem with the mavenised version of JMeter.
It was actually a problem with JMeter not managing to scan all of its modules jar files to extract the functions that map user properties to ${__P(...)}.
Should be fixed in the current build.


unable to see the adv_drop_count in the podlevel metrics

I am using retina in my project .
i have enabled the advance level pod metrics.
I am able to see the adv_forward_count metrics , drop_bytes, drop_count and so .
But i am unable to get the metrics of adv_drop_count . Please let me know if i have to add anything .
i have attached MetricsConfiguration file below.
apiVersion: retina.sh/v1alpha1
kind: MetricsConfiguration
metadata:
  name: metricsconfigcrd
spec:
  contextOptions:
    - metricName: drop_count
      sourceLabels:
        - ip
        - podname
        - port
      additionalLabels:
        - direction
        - reason
      destinationLabels:
        - ip
        - podname
        - port
        - workload
    - metricName: forward_count
      sourceLabels:
        - ip
        - podname
        - port
      additionalLabels:
        - direction
      destinationLabels:
        - ip
        - podname
        - port
        - workload
  namespaces:
    include:
      - default
      - kube-system

Thanks for raising this issue. On my setup, I also don't see any adv_drop_ metrics. We will need to dig into the code to understand why.
I have retina v0.0.5 with the following ConfigMap:
$ k get cm retina-config -oyaml
apiVersion: v1
data:
  config.yaml: |-
    apiServer:
      host: <IP_ADDRESS>
      port: 10093
    logLevel: info
    enabledPlugin: [dropreason,packetforward,linuxutil,dns,packetparser]
    metricsInterval: 10
    enableTelemetry: false
    enablePodLevel: true
    remoteContext: false
    enableAnnotations: true
kind: ConfigMap
metadata:
  annotations:
    meta.helm.sh/release-name: retina
    meta.helm.sh/release-namespace: kube-system
  creationTimestamp: "2024-04-15T06:53:58Z"
  labels:
    app.kubernetes.io/managed-by: Helm
  name: retina-config
  namespace: kube-system

@abhipatwari17 Can you clarify the following:

what's the retina version you are using?
can you confirm a network policy manager is running in the system?
can you confirm packets are dropped on any one node?
can you share the retina-config?
can you share the retina-agent and retina-operator status and logs?

Hi , sorry for the late response .let go one by one ....
what's the retina version you are using? =  "v0.0.10"
can you confirm packets are dropped on any one node? = i am using one node in k8s cluster, i am able to  see the drop count level of cluster, i can see there is variation in the graph [not able to see at the pod level]
can you share the retina-config
retina:
  # Default values for retina.
  # This is a YAML-formatted file.
  # Declare variables to be passed into your templates.

  # Support linux and windows by default.
  os:
    linux: true  # Enable retina for Linux
    windows: true # Enable retina for Windows

  operator:
    enabled: true  # Enable retina operator
    repository: ghcr.io/microsoft/retina/retina-operator  # Retina operator repository
    tag: "v0.0.10"
    installCRDs: false
    enableRetinaEndpoint: true
    capture:
      debug: "true"
      jobNumLimit: 0
    resources:
      limits:
        cpu: 500m
        memory: 128Mi
      requests:
        cpu: 10m
        memory: 128Mi

  image:
    repository: ghcr.io/microsoft/retina/retina-agent  # Retina agent repository
    initRepository: ghcr.io/microsoft/retina/retina-init
    pullPolicy: Always
    tag: "v0.0.10"
    # Take the latest version . Ref:https://github.com/microsoft/retina/releases

  enablePodLevel: true
  remoteContext: true
  enableAnnotations: false
  bypassLookupIPOfInterest: false

  namespace: default  # Namespace for retina deployment

  agent:
    name: retina-agent

  agent_win:
    name: retina-agent-win

  retinaPort: 10093  # Port for retina

  apiServer:
    host: "<IP_ADDRESS>"
    port: 10093

  # Supported - debug, info, error, warn, panic, fatal.
  logLevel: info

  enabledPlugin_linux: '["packetparser","dropreason","packetforward","linuxutil","dns"]'
  enabledPlugin_win: '["hnsstats"]'

can you share the retina-agent and retina-operator status and logs?
Below are the logs.txt file for both opertor as well as retina agent . please find the attachment.
retina-operator.txt
retina-agent.txt

There was an report at #80. Are these two related? I'm having the same issue of not seeing adv_drop_count metrics and will investigate it further.


rekor cli upload with cosign public key

I know that by using cosign sign-blob, it will automatically upload an entry into rekor tlog, but I was experimenting with uploading the record to the rekor tlog manually (using rekor-cli), and it seems to encounter an issue with the cosign public key. Is the cosign public key not in the correct format for rekor-cli to use?
cosign generate-key-pair

 // intentionally not uploading to rekor
cosign sign-blob --key cosign.key --output-signature sig.txt --tlog-upload=false artifact.txt

// i tried the different pki formats but all did not work
rekor-cli upload --public-key cosign.pub --signature sig.txt --artifact artifact.txt --pki-format tuf|pgp|minisign|ssh|x509|pkcs7

--pki-format should be x509 when uploading a public key.

This seems related to an issue I am finding also. Using --pki-format x509, I'm not able to successfully upload with rekor-cli upload (although using cosign verify-blob with the same material does work):
[lily@fedora cosign]$ cosign verify-blob --key keys/cosign.pub --signature blob_sig generated_payload --insecure-ignore-tlog=true
WARNING: Skipping tlog verification is an insecure practice that lacks of transparency and auditability verification for the blob.
Verified OK

[lily@fedora cosign]$ rekor-cli upload --artifact generated_payload --public-key keys/cosign.pub --pki-format x509 --signature blob_sig
error: error retrieving external entities: invalid signature when validating ASN.1 encoded signature

Why do these two commands have different results?

Responding on the other issue about signature formats.


Fix overly-broad use of raise_error with no argument

Fixes these RSpec warnings:

WARNING: Using the raise_error matcher without providing a specific error or message risks false positives, since raise_error will match when Ruby raises a NoMethodError, NameError or ArgumentError, potentially allowing the expectation to pass without even executing the method you are intending to call.

Good housekeeping @mattbrictson :+1:


Fix binding layout

After updating to the latest version of wgpu-py, I encountered an error in one of my use cases related to a mismatch between ResourceBinding and the pipeline layout:
In wgpuDeviceCreateRenderPipeline
Error matching ShaderStages(FRAGMENT) shader requirements against the pipeline
Shader global ResourceBinding { group: 0, binding: 0 } is not available in the pipeline layout
Buffer structure size 48, added to one element of an unbound array, if it's the last field, ended up greater than the given min_binding_size, which is 16

Upon look into it, I found that the min_binding_size was not properly set when creating the bind group layout.
This issue likely existed for a long time, but previous versions of wgpu did not report the error. It’s possible that the min_binding_size parameter did not take effect or was properly validated in earlier versions.

Uh, a strange CI error.
The logs show that there was an issue with validate_culling during rendering, but the screenshot seems to have been generated correctly. And, I'm unable to reproduce the error locally. 🤔

(Very strange error and now I feel responsible because I touched that code last)

Try to restart the ci. If there is no option close and open the pr


add configure options to support set linker

this is a rewrite  pull request  https://github.com/alibaba/tengine/pull/546
this patch support:
./configure --with-link=g++ --with-ld-opt=" -static-libgcc -static-libstdc++ "

when you want link  libgcc, libstdc++  static,  when the  envirment of tengine running using diff version of gcc .

I think it is a good idea to merge this. It is very useful to build with specific (commonly, latest) version of gcc. And it's usual to install it separately because OS do not support latest version.

LGTM
thanks


Add method to blank all displays

This would behave like PresentRenderBuffers(), but would instead clear all screens to black.  This is utility function to help in situations like Unreal or Unity when you have an asynchronous call when editors start/stop or scenes switch and you can't handle doing it in the standard rendering loop.
Probably a virtual function that gets implemented in the OpenGL and D3D base classes.

Added in commit bb307e0f51898d61e2d0bfd6da370588d466cfce which has been merged to master.  Includes new example program.  Tested in OpenGL, Direct3D(SDL, NVIDIA), OpenGL/D3D interop, ATW.


PT forbid to upload a patterned part having its description ending by "Pattern (Needs work)"

PT forbid to upload a patterned part having its description ending by "Pattern (Needs work)"

The "W" must be capitalized.

Oh thanks! I didn't know this was case sensitive. Maybe the error message could be modified from:
Pattern part description must end with "Pattern"
to:
Pattern part description must end with "Pattern" or "Pattern (Needs Work)"


Start detekt with Type Resollution

Hi!
A want to start detekt with type resolution in my Android project. But there isn't command detekt in gradle task list. What i need to do to start this command?

(@arturbosch can you convert this to a discussion, or grant members the right to do that? 👌 )
You will find detektMain and other tasks with Type Resolution enabled inside your app (or libraries) module. What you're looking at now is the tasks from the root project.

(@arturbosch can you convert this to a discussion, or grant members the right to do that? 👌 )
You will find detektMain and other tasks with Type Resolution enabled inside your app (or libraries) module. What you're looking at now is the tasks from the root project.

I also don't see this command inside the app module

I also don't see this command inside the app module

There is a demo in my repository https://github.com/AlinaRakhimova/customDetekt

There is a demo in my repository https://github.com/AlinaRakhimova/customDetekt

I also don't see this command inside the app module

That happens because you're applying the Detekt Gradle plugin only on your root project and not on the app module. You can check this template https://github.com/cortinico/kotlin-android-template/blob/88719a470dfc3585e7af326503c90a52346886df/build.gradle.kts#L21-L50 for an example on how to setup the Detekt task on all of your subprojects.

I also don't see this command inside the app module

That happens because you're applying the Detekt Gradle plugin only on your root project and not on the app module. You can check this template https://github.com/cortinico/kotlin-android-template/blob/88719a470dfc3585e7af326503c90a52346886df/build.gradle.kts#L21-L50 for an example on how to setup the Detekt task on all of your subprojects.

(@arturbosch can you convert this to a discussion, or grant members the right to do that?  )

Could you test again? Technically you are now able to delete the detekt repo :D

(@arturbosch can you convert this to a discussion, or grant members the right to do that?  )

Could you test again? Technically you are now able to delete the detekt repo :D

Could you test again? Technically you are now able to delete the detekt repo :D

Turns out the feature was disabled by Github (https://github.com/github/feedback/discussions/2952#discussioncomment-279785) due to a bug on their end. They're slowly re-enabling the feature. I've asked for our repo to be re-added.
So I believe I actually already had the power to do so also before 👌

Could you test again? Technically you are now able to delete the detekt repo :D

Turns out the feature was disabled by Github (https://github.com/github/feedback/discussions/2952#discussioncomment-279785) due to a bug on their end. They're slowly re-enabling the feature. I've asked for our repo to be re-added.
So I believe I actually already had the power to do so also before 👌

I added Detekt Gradle plugin in my app module. And now I have detektMain. Thank you so much!

So, we can close this now, right?


✨ metadata handling improvements

This PR was documented and reviewed in this old owid-catalog-py PR.
There have been some new changes with respect to that PR. Mainly:

I had to do a minor fix in backport/datasync/data_metadata.py so that grapher steps can be executed.
Adapted a data pipeline us_corn_yields to the new metadata tools.
Improved the table functions (mainly merge, melt, pivot, concat) and fixed some issues.
Added many unit tests.
Added some useful functions (e.g. to update and amend entries in the processing log).
Did many minor tweaks to old etl steps so that they return the same data and metadata as currently in the catalog. There are still some irrelevant differences. The only significant issues (which I'll mention on Slack) are:

data://garden/owid/latest/covid
Data is equal to remote if we restrict dates to ~<2022-05-01. Otherwise, remote data seems to not be up to date.
data://garden/war/2023-01-18/clodfelter_2017 (and other steps in war)
Data is identical, however members of 'conflict_participants' appear in different order.
data://open_numbers/open_numbers/latest/bp__energy (and all open_numbers steps)
All open numbers steps are not found in the catalog, so I couldn't do the comparison.
data://garden/energy/2023-06-01/global_primary_energy (and data://grapher/energy/2023-06-01/global_primary_energy)
The only difference is that the field "additional_info" disappeared. It used to be transferred from the BP backported dataset to the combined dataset Smil + BP. But that field is probably unnecessary.
data://grapher/fasttrack/2023-06-16/guinea_worm
I was unable to load it from the catalog. Is there anything wrong with this dataset?
data://meadow/oecd/2016-06-01/regional_wellbeing
Again, I wasn't able to load it from the catalog (but the error was different).
data://meadow/un/2022-07-11/un_wpp (and data://garden/un/2022-07-11/un_wpp)
When I run these steps, the resulting data is different to the one in the catalog. But this also happens when I run the step in the master branch. So there is something odd with this step.

NOTES:

By default, environment variable PROCESSING_LOG is assumed False, and therefore nothing is added to the processing log. So this PR will only affect the way metadata is handled. In a future PR we'll need to work a bit further on handling the processing log, and adapting the unit tests to this new attribute of variables.
Is there any way to check that the results of --grapher operations are not affected? I run just one and the result was identical, but maybe there's a way to check on more steps.

@pabloarosado can you increment ETL_EPOCH so that all datasets get refreshed for reviewers (tip for other reviewers - I cloned etl to new folder and building it there to avoid back and forth rewriting of data/ when switching between branches).

A couple of additional notes:

I've tested the performance and it looked good!
I tried to run those problematic datasets and I think they're fine (still looking into un_wpp, but others are good)
I'm running into pylance (=pyright) linting errors in VSCode and type checks in general, but we don't have to fix it as part of this PR

An additional note. I see something like the code below repeat itself often:
old_title = table[column].metadata.title
old_description = table[column].metadata.description
# some operation son table[column] ...
table[column].metadata.title = old_title
table[column].metadata.description = old_description

I understand that propagating the title and description fields in metadata automatically may not apply to all instances (maybe the processing done to the field implies a change in title/description). However, could we have a flag set to True if we want to propagate certain fields?
tb[column].preserve_fields = True

Or something in this spirit.

An additional note. I see something like the code below repeat itself often:
old_title = table[column].metadata.title
old_description = table[column].metadata.description
# some operation son table[column] ...
table[column].metadata.title = old_title
table[column].metadata.description = old_description

I understand that propagating the title and description fields in metadata automatically may not apply to all instances (maybe the processing done to the field implies a change in title/description). However, could we have a flag set to True if we want to propagate certain fields?
tb[column].preserve_fields = True  # automatically propagates metadata.title and metadata.description (and possibly others)
# some operation son table[column] ...

Or something in this spirit.

Yes Lucas, I think we should rethink some of the logic currently implemented in this PR. But maybe it's better to focus on new steps (done with the new tools in mind) rather than old steps. So, we could start working with the new tools, and after gathering some experiences then decide what would be the best logic to implement and make changes.

Hi @Marigold @larsyencken what do you think, is it ready to be merged? If you have concerns, please let me know, thanks.

Thanks @Marigold I've just removed all lines where tb.metadata.dataset was overwritten to combine sources and licenses.

I've just checked all datadiffs and the only problematic case (dataset life_tables) I've checked it locally and found no differences. So I think we are ready to merge.


Change rls -> rls-preview

The rls component has been renamed to rls-preview.

Also, since Rust 1.21, rls-preview is available in the stable toolchain.

Oh good catch. Hm, I wonder what's the best way to detect the version of the currently active toolchain. Looks like we'll have to manually parse for the active toolchain section of rustup show?
$ rustup show
Default host: x86_64-unknown-linux-gnu

installed toolchains
--------------------

stable-x86_64-unknown-linux-gnu (default)
nightly-x86_64-unknown-linux-gnu

active toolchain
----------------

stable-x86_64-unknown-linux-gnu (default)
rustc 1.21.0 (3b72af97e 2017-10-09)

Or maybe we don't even need to, just try installing it with their default and tell them to update if it errors. That's probably better.

Agreed on that @jacobmischka. Mind updating this PR to that?

Done! Additionally, it will now use the default toolchain by default, displaying an error if rls-preview and friends are unsupported on the current default toolchain.

Thanks for the excellent work @jacobmischka


Issue #1013: Fix Random Failure Bugs & Add More Debug Info

Issue #1013 raised two action items of export_table_test:

Increase debugability;
Fix potential bugs that caused random failures.

The first one was solved by:

Moving assertions into CheckContent so that we can distinguish different failure cases;
Providing the location of mismatch data, i.e., which row and column has unexpected data;
Reserving the seed and exported file if there are failures so that the failure can be reproduced.

The second item was solved by identifying a rare case where when a row only contains a single null value, it was exported as ""\n. \n is its only delimiter but was not properly parsed before, so when such row was generated, the test would fail.
The new version of the test in this RB has been verified by repeating 3000 times without failures.

@Yuze this huge! Thanks so much!

@apavlo My pleasure! It's what I'm supposed to do :)


Image Updates

Added updated illustrations for office-add-ins.md documentation for review by @Reezaali.

:warning: Validation status: warnings

File
Status
Preview URL
Details

docs/design/ux-design-pattern-templates.md
:warning:Warning

Details

.DS_Store
:white_check_mark:Succeeded

docs/.DS_Store
:white_check_mark:Succeeded

docs/images/.DS_Store
:white_check_mark:Succeeded

docs/images/AddInCommands.png
:white_check_mark:Succeeded

docs/images/ComponentsHelloWorldOffice.png
:white_check_mark:Succeeded

docs/images/ContentAddIn.png
:white_check_mark:Succeeded

docs/images/ManifestWebpage.png
:white_check_mark:Succeeded

docs/images/TaskPane.png
:white_check_mark:Succeeded

docs/overview/.DS_Store
:white_check_mark:Succeeded

docs/overview/office-add-ins.md
:white_check_mark:Succeeded

docs/design/ux-design-pattern-templates.md

Line 25: [Warning] Invalid file link:(~/first-run-experience-patterns.md).
Line 26: [Warning] Invalid file link:(~/authentication-patterns.md).
Line 27: [Warning] Invalid file link:(~/navigation-patterns.md).
Line 28: [Warning] Invalid file link:(~/branding-patterns.md).

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

@lindalu-MSFT @Lauragra is it possible to publish the updated images for the About Office Add-ins page without processing the ux-design-pattern-templates.md? We'd like to see these go live.

@hodlhodl The only way to do that is to merge the images separately. You would need to take the individual image files and merge them to the https://github.com/OfficeDev/office-js-docs-pr/tree/master/docs/images folder. Otherwise, when I merge this, I will be updating the entire file.

@hodlhodl Mei Li, I will hold off on the PR until I hear what you want me to do.

@lindalu-MSFT let's close this PR and use #219 instead. Thanks!


Switch to netcore 2.0

Currently, when you use the latest .NET Core 2.0 SDK, and try to execute dotnet build, you get the following error:
C:\Program Files\dotnet\sdk\2.0.0\Sdks\Microsoft.NET.Sdk\build\Microsoft.NET.Sdk.DefaultItems.targets(286,5): error : Duplicate 'Content' items were included. The .NET SDK includes 'Conten
t' items from your project directory by default. You can either remove these items from your project file, or set the 'EnableDefaultContentItems' property to 'false' if you want to explici
tly include them in your project file. For more information, see https://aka.ms/sdkimplicititems. The duplicate items were: 'wwwroot\css\ie10-viewport-bug-workaround.css'; 'wwwroot\css\sit
e.css'; 'wwwroot\favicon.ico'; 'wwwroot\js\ie10-viewport-bug-workaround.js'; 'wwwroot\js\site.js' [C:\KC\tools\net-boilerplate\MyWebsite\MyWebsite.csproj]

fixed in #50


Add client metrics posted to Prometheus.

Add client metrics posted to Prometheus.
Does this need to be enabled/disabled with settings?

Regarding an enable/disable switch via settings, I think it would make sense to just have this on by default. I don't believe there will be any real performance impact to our controller from keeping these metrics updated.

@jortel one final follow-up question: do you have a feel for how much of the controller code is not using the custom client? E.g. how many calls will go untracked.

Resolves #594

@jortel one final follow-up question: do you have a feel for how much of the controller code is not using the custom client? E.g. how many calls will go untracked.

All of the source/destination cluster API calls use the custom client.  The client associated with each Reconciler is the cached client obtained from the Manager and is only used for local API calls not related to source/destination cluster reconciliation.  This would be mainly Mig* resources and associated secrets.


Duplicate item

Face++ (https://github.com/cipher387/API-s-for-OSINT#face-detection) is duplicate. One of the two entries should be removed.
Otherwise, @cipher387 good job I really love this repo!

Thank you


Migrate to Spine v0.7.1

Should be merged after #14

@armiol PTAL

Current coverage is 88.69% (diff: 80.00%)

Merging #15 into master will not change coverage

@@             master        #15   diff @@
==========================================
  Files            13         13
  Lines           628        628
  Methods           0          0
  Messages          0          0
  Branches         69         69
==========================================
  Hits            557        557
  Misses           45         45
  Partials         26         26

Powered by Codecov. Last update 48aaac1...a930159


Usage with multiple domains for the same application

Hi, I have an application which is accessible with two domains: domain1.com, domain2.com. (The response is totally identical, just different domains).
How should I set the domain field? Should I use the location.hostname?

Hi @wong2!
I haven't tried that use case, but I believe yes, you should extract the domain from the current URL. Have you tried?


[util] Return watch from WatchAndUpdate functions

This PR returns the ValueWatches from the WatchAndUpdate functions so the caller can close them if they need to. Callers would then be able to ensure that the goroutines which watch for these updates will be closed.
cc @prateek @cw9

Coverage increased (+0.2%) to 84.394% when pulling eacf7a07c01cecbe35eb1139b356c9559b982cd7 on jeromefroe/util/return-watches-from-utility-functions into 56c031689fb080404de0b2acfc385e91627d93d7 on master.

Coverage decreased (-0.007%) to 84.177% when pulling 51f82fca4eb4c5335e0be904d61bc2e448ce6b02 on jeromefroe/util/return-watches-from-utility-functions into 56c031689fb080404de0b2acfc385e91627d93d7 on master.


Perception: fill lane detection results into output channel: /perception/obstacles

The fitting parameters c0, c1, c2, c3 lies in car coordinates: x forward, y left, z up

@yg13 Do we plan to use it in standard mode or highway mode? Just an FYI that it would be no problem in highway mode but hard to use by PnC in standard mode as the lane in Vehicle FLU coordinate system.

@Capri2014 I see your point. FLU representation might not be used directly for PNC. I think c0, c1, and x_start, x_end can be converted to world coordinates directly and has definite meanings to use. However for c2, c3, I am not sure. If the whole curve shape is actually needed in world coordinate system, a polyline representation can be converted from ego to world.
Maybe for this PR, I just keep current format. If any representation in world coordinates is required I can add these in a separate PR later.


what is this problem?

Describe your problem here.
I did't hide hit sound option inOptionsState but i can't see it in the game.

Are you modding a build from source or with Lua?
Source
What is your build target?
Windows x64
Did you edit anything in this build? If so, mention or summarize your changes.


Lesson modal close button should be sticky

When scrolling a lesson, the close button does not stick to the top of the modal. As a result, you need to scroll back to the top to close the modal. This will be annoying for lessons with lots of content. Although you can close the modal using the Esc key, this won't be obvious for most users.

Closed #94

Closed #94


Wounded Condition

MIDI QOL can apply the "Dead" condition automatically as an overlay.  I have created the custom condition "Wounded", but it only applies as a tiny icon.  It would be great to have Wounded (and perhaps any custom condition) be able to be applied as an overlay. Alternatively, perhaps "Wounded" can be added as a stock condition?

Yes, I actually saw that the other day in Midi. I'll add a stock one. What icon did you decide on for it? Always the hardest part...

Yes, I actually saw that the other day in Midi. I'll add a stock one. What icon did you decide on for it? Always the hardest part...

Yeah, which icon is the issue.  There is a foundry blood drops icon, but I find it not useful as an overlay since it obscures too much of the token.  I personally like the wounded icon from Combat Utility Belt (Data/modules/combat-utility-belt/icons/wounded.svg).  The condition is obvious with the red tint but the icon does not obscure too much of the token as an overlay.  I would recommend using that as inspiration.

Added in v2.4.4


Fix typo in README.md

Hi @hezhizhen. Thanks for your PR.
I'm waiting for a pusher member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test label.
I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

/cc @maxthelion @zerok @pl

@hezhizhen: GitHub didn't allow me to request PR reviews from the following users: zerok.
Note that only pusher members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @maxthelion @zerok @pl

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.


ApplicationArea: How to create new setups

Hello,
I am developing an extension and assigning my own ApplicationArea to controls. I am following this documentation: https://docs.microsoft.com/en-us/dynamics-nav/developer/devenv-extending-application-areas
The "Application Area Setup" table contains the following fields in its primary key:

Company Name
Profile ID
User ID

I understand then that I can use different applications areas per diferents companies, profiles or even per user.
My question is: where is the setup done?
We only have page 9179 Application Area, but it is not editable. I cannot find any other place where I can setup applications areas per user.
Thanks for your feedback.
Salut!
Laura Nicolàs

Hi @LauraNicolas,
For now, we only provide the ability to set application areas per company. We don't support it directly for users and for profiles and currently don't have any plans on making it available.
The management of application areas is made in the Codeunit 1 (Application Management), this is where the application areas are set per session at logon. When a user logs on, this codeunit is read and gives the server the list of application area to enable for the current session. If you want to have a behavior dedicated per profile and user, you should investigate this codeunit and modify it in order to enable the scenarios you mentioned.

Thanks @qutreson ,
I guess this could be a topic for an extension .-)
To me, being able to assign ApplicationAreas per user solves (or could be used to solve) an important issue: Permissions per role/user.
Right now, if you assign a write permission to the Item table to a warehouse employee, he/she can change anything, also postings groups. Someone could argue that warehouse employees should not be able to modify accounting-related information. And they are probrarbly right.
With AppAreas, this problem can be solved. I can easily hide certain fields, based on peoples role.
I would rather be able to choose if it has to be hidden, or just not editable, but it is better than nothing.
Salut!
Laura Nicolàs


Arch Linux support?

It would be nice if Arch Linux were to be supported by NCSC the configuration for Linux only supports Ubuntu. However, with Linux now becoming popular due to Steam Deck and with SteamOS being Arch-based there's a likely chance that companies might want to go to Linux etc. Could NCSC do a guidance for Arch Linux if possible?

Companies are interested in long-term support and rarely in rolling releases.
However, I invite you to read this:
https://www.ssi.gouv.fr/en/guide/configuration-recommendations-of-a-gnulinux-system/


Support batch inference for models other than patch32

The current batch inference code is only applicable to the patch32 model. When using other models such as patch16 or patch14, it produces incorrect results. Specifically, the behavior is such that the first embedding result in a batch is correct, but all subsequent results are a single incorrect fixed value.

@skirodev Thanks for raising the issue. I'll try to reproduce it. It might be related to a memory alignment issue that I would need to patch in the ggml repo. Will update it once I reproduce it.

#71

This PR only fixed batch inference for the patch32 model, not for other patches (such as patch16 and patch14) model. Maybe we should keep it open. What's your take on this?


new flag -TMS

there is conversion y = 2 ** z - 1 - y
for the case where mbtiles are in x-y-zoom Google's format
and we need them in TMS format for Osmand
but some mbtiles are already in TMS format so my idea is to add flag/parameter
parser.add_argument('-TMS', action='store_true', help='convert tiles from TMS standard instead Google x y zoom')
and change line
y = 2 ** z - 1 - y
to
if(args.TMS):
y = 2 ** z - 1 - y

Requires analysis.
MBTiles spec: https://github.com/mapbox/mbtiles-spec/blob/master/1.3/spec.md

columns MUST encode the location of the tile, following the Tile Map Service Specification, with the restriction that the global-mercator (aka Spherical Mercator) profile MUST be used.

But I don't understand which format uses OsmAnd.
https://github.com/osmandapp/Osmand/blob/master/OsmAnd/src/net/osmand/plus/SQLiteTileSource.java
There are some interesting properties: inverted_y, tilenumbering, BIG_PLANET_TILE_NUMBERING.
I'll analyze it later.

Requires analysis.
MBTiles spec: https://github.com/mapbox/mbtiles-spec/blob/master/1.3/spec.md

columns MUST encode the location of the tile, following the Tile Map Service Specification, with the restriction that the global-mercator (aka Spherical Mercator) profile MUST be used.

But I don't understand which format uses OsmAnd.
https://github.com/osmandapp/Osmand/blob/master/OsmAnd/src/net/osmand/plus/SQLiteTileSource.java
There are some interesting properties: inverted_y, tilenumbering, BIG_PLANET_TILE_NUMBERING.
I'll analyze it later.


Support triu function for tvm.relay.expr.Call Inputs

This PR is to address https://github.com/tenstorrent/tt-tvm/issues/3
Having a proper support for triangular upper when the inputs are a list of CallNodes will allow us to be a step closer to successfully implementing Qwen 1.5 (0.5B)  (See https://github.com/tenstorrent/tt-buda-demos/issues/20).
Explanation
def triu(self, inputs, input_types):
    x = inputs[0]
    x_shape = _infer_shape(x)

+    if isinstance(inputs[0], tvm.relay.expr.Call):
+        return self.trilu(inputs, input_types, mode="triu")

    mask = np.triu(np.ones(x_shape), inputs[1]).astype(np.bool)
    mask = tvm.nd.array(mask)
    mask = tvm.relay.Constant(mask)

    zeros = np.zeros(x_shape).astype(_convert_tvm_to_np_dtype(input_types[0]))
    zeros = tvm.nd.array(zeros)
    zeros = tvm.relay.Constant(zeros)

    return _op.where(mask, x, zeros)

When compiling Qwen 1.5 (0.5B)  (https://github.com/tenstorrent/tt-buda-demos/pull/37), one of its OP codes is aten::triu with its inputs containing nested functions of OP calls.
>> inputs[0]
CallNode(Op(add), [CallNode(Op(subtract), [CallNode(Op(subtract), [CallNode(Op(add), [Constant(256), Constant(0)], (nullptr), []), CallNode(Op(multiply), [Constant(1), Constant(256)], (nullptr), [])], (nullptr), []), CallNode(Op(multiply), [Constant(1), Constant(32768)], (nullptr), [])], (nullptr), []), Constant(1)], (nullptr), [])

>> type(inputs[0])
<tvm.relay.expr.Call>

self.trilu seems to be able to successfully handle these inputs when mode="upper" to do triangular upper operation.
Issues
1 Op(trilu) instead of Op(triu)
After doing self.trilu(inputs, input_types, mode="triu"), the resulting output would be:
CallNode(Op(trilu), [CallNode(Op(cast), [CallNode(Op(ones_like), [CallNode(Op(add),...

Is this a genuine issue??? Or can it be ignored for now?
2. NaN tensor values for Grayskull e75
When tested on @marty1885's e75, he ran into an error where his tensor values were NaN.
But weirdly @JonathanALevine's e150 was able to successfully compile and run it until running into some errors later.
*This is a draft for now since this is just a workaround and not a proper fix yet.

Closed as this is no longer an issue for Qwen specifically


Exception thrown when requiring a file twice, once as a source file and once as a compiled file

Demo repository
Running nyc node c.js produces the following output:
/home/ether/Desktop/nyc-bug/node_modules/nyc/node_modules/istanbul-lib-source-maps/lib/transformer.js:97
            mappedCoverage.addStatement(mapping.loc, hits);
                           ^

TypeError: mappedCoverage.addStatement is not a function
    at /home/nyc-bug/node_modules/nyc/node_modules/istanbul-lib-source-maps/lib/transformer.js:97:28
    at Array.forEach (<anonymous>)
    at SourceMapTransformer.processFile (/home/nyc-bug/node_modules/nyc/node_modules/istanbul-lib-source-maps/lib/transformer.js:88:34)
    at /home/nyc-bug/node_modules/nyc/node_modules/istanbul-lib-source-maps/lib/transformer.js:169:24
    at Array.forEach (<anonymous>)
    at SourceMapTransformer.transform (/home/nyc-bug/node_modules/nyc/node_modules/istanbul-lib-source-maps/lib/transformer.js:159:25)
    at MapStore.transformCoverage (/home/nyc-bug/node_modules/nyc/node_modules/istanbul-lib-source-maps/lib/map-store.js:143:8)
    at SourceMaps.remapCoverage (/home/nyc-bug/node_modules/nyc/lib/source-maps.js:29:41)
    at NYC.getCoverageMapFromAllCoverageFiles (/home/nyc-bug/node_modules/nyc/index.js:436:30)
    at NYC.report (/home/nyc-bug/node_modules/nyc/index.js:442:18)

c.js contains:
require('./a')
require('./b')

a.js contains:
module.exports = {}

b.js is produced by babel a.js --out-file b.js --source-maps and contains:
module.exports = {};

//# sourceMappingURL=b.js.map

b.js.map contains:
{"version":3,"sources":["a.js"],"names":[],"mappings":"AAAA,MAAM,CAAC,OAAP,GAAiB,EAAjB","file":"b.js","sourcesContent":["module.exports = {}\n"]}

Expected Behavior
nyc should exit without errors.
Observed Behavior
nyc throws an exception.
Forensic Information
Operating System: Ubuntu 19.04.
Environment Information: node v12.2.0, npm 6.9.0, nyc 14.1.1
Notes
Why would anyone require both the source files and the built/transpiled files? I got into that use case with a source file that exports constants. Those constants are only used by unit tests, i.e. not exported in transpiled files. I.e. tests need to require the source file (to get the constants) + require the transpiled file (to run the code).

My setup (and the result) is quite similar. I'm running tests of different nature during a single coverage pass:

Unit tests, which import corresponding source files.
Functional tests, which import rollup+babel compiled library.

Tests pass but then NYC fails with "TypeError: mappedCoverage.addStatement is not a function".

Is this still occurring with the latest versions of nyc and using babel-plugin-istanbul as documented with the preset configuration?

@JaKXz Please give me some time to check it on Monday if you are unable to verify yourself the case I've prepared above. Or you disagree with the example?

Thanks for checking this out @JaKXz. I've just updated the demo repository with the latest version of nyc and the bug still appears. The setup is using @babel/cli, not babel-plugin-istanbul.

@JaKXz I've updated dependencies in my MWE at paulsmirnov/issue-nyc-940 but it still crashes<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>rollup@1.12.3). It is easy to reproduce as described in README.

I've labeled this so the stale bot will leave it alone.  This is a difficult issue I'm not sure how to solve.

Alright, no worries. If you want to close this issue instead, this might be more appropriate.

I'm having this problem too with various Typescript projects.
It seems to be unpredictable, in that a fellow developer hasn't seen the problem on his Mac, and sometimes it goes away on my Ubuntu.
Our deployment - which uses Docker Ubuntu Alpine - never seems to hit the problem.
I hope that helps.

@ehmicky I've found the cause and solution to this issue.  The linked PR fixes your demo repository - I verified by manually editing the node_modules/istanbul-lib-source-maps/lib/transform.js installed from your repository.

@coreyfarrell Great! Thanks for looking into this.


Insert Random with multi-line editing

When multiple cursor selections are present, the "Insert Random..." options insert the same random value at each location. Could there be an additional prompt to choose between using a single random value for all cursor locations (current default behavior), or inserting a different random option for each cursor location? The extra prompt step would ideally only appear if multiple cursor instances are present.

Good suggestion, I'll add it

031fc946f8561e016cc633e1659127c3f4e0504e


Compiler Warning AL0729 "Promoted can only be set..." is wrong

I think this warning is invalid because actions do not only open pages. For example, this warning gets raised for promoted actions that execute the action using the OnAction trigger. I think this warning should only be raised if the RunObject is a page.
Warnings:

Example:

Thanks for your feedback. This repo is meant for documentation issues only. This looks like a product bug. Please use your usual support channel to file a bug. Thanks.


Inheritance generated constructors can clash with other constructors

The test case was submitted via: https://github.com/Blazebit/blaze-persistence/pull/464
The problem is, that the "default" constructor generated for BView clashes with the constructor generated for inheritance. This is because the attribute names are in the same order for both cases, the subtype configuration and the "default non-subtype case".
The underlying problem is that type clashes could also happen becuase of reorderings.
Imagine AView having a String. BView extends AView and also has a String. The default constructor might be like (AView.String, BView.String) whereas the subtype configuration constructor might be (BView.String, AView.String). Simply omitting the type clashing constructor wouldn't work as the sematics of the constructors are different.
I'm not yet sure how to approach this, but I have a feeling that it might be better to have just a single constructor that has a total order of attributes and instead create static factory methods that map to that single constructor. I just don't see how we could solve this by using just a constructor.

Why have multiple constructors at all? Can’t we annotate the constructor parameters with some mapping meta data such as the mapping field and its originating view class, so that we can resolve the parameters from there?

I did somewhat similar to what you suggested but without the annotations.
The final design I came up with that I'm currently trying to implement is the following...
An entity view class hierarchy might have multiple usages. When a type of the hierarchy is used statically(attribute type), it becomes an inheritanceBase. The effect is, that every subtype of that inheritanceBase class gets a specific class generated that is bound to that inheritanceBase.
The next concept that is interesting is about subtype configurations. In JPA you only have a single subtype configuration i.e. every entity subtype of an inheritance enabled entity is part of that subtype configuration. In Blaze-Persistence Entity Views, we allow to have multiple subtype configurations by specifying the interesting subtypes at the use site(attribute declaration).
At runtime, every subtype configuration needs an appropriate factory method that is used to construct subtype instances uniformly. Previously, we tried to generate constructors for every configuration which doesn't work out. The new idea is, to construct an overall configuration that contains all subtypes for which only a single constructor is created. Every other subtype configuration has a mapping to that overall configuration. For each subtype configuration, we now generate a static create method that maps the configuration specific attributes to the overall constructor. That way, we avoid clashing constructors when having multiple configurations. The static create methods are suffixed with their subtype configuration index.


[GKE] Followup on cluster labels handling

What kind of request is this (question/bug/enhancement/feature request): tech debt
Follow up on the solution implemented for https://github.com/rancher/rancher/issues/32433

Remove the exponential backoff from UpdateLabels, if possible, in favor of letting the reconciler and recordError handle the update conflict gracefully.
Track down the resource conflict error when recording status updates and avoid retrying the status update.

To test this, it should be sufficient just to make sure that adding and removing labels still works fine.

tested on v2.6-6c14c339a699af2c88d1c5ea075f8eedce07f55b-head
Could add and delete cluster labels


README: fix url() example output

The url() method returns the /advisory/<id> endpoint.
(The /errata/<id> is wrong, and in fact it's a 404 error server-side.)

Working on some unit tests and caught this.

Look correct to me

Thanks!


Servers Offline

Current behavior
I can't download it, the servers are offline for all URLs, the application does not works anymore?
From terminal:
neur4l in ~
➜  wget https://s3.amazonaws.com/swaggymnia/1.0.0-beta/linux/swaggymnia
--2022-07-23 19:36:55--  https://s3.amazonaws.com/swaggymnia/1.0.0-beta/linux/swaggymnia
Resolving s3.amazonaws.com (s3.amazonaws.com)... <IP_ADDRESS>
Connecting to s3.amazonaws.com (s3.amazonaws.com)|<IP_ADDRESS>|:443... connected.
HTTP request sent, awaiting response... 404 Not Found
2022-07-23 19:36:56 ERROR 404: Not Found.

https://s3.amazonaws.com/swaggymnia/1.0.0-beta/linux/swaggymnia
This XML file does not appear to have any style information associated with it. The document tree is shown below.
<Error>
NoSuchBucket
<Message>The specified bucket does not exist</Message>
<BucketName>swaggymnia</BucketName>
<RequestId>G3KMJF15KTT2A732</RequestId>
<HostId>gkfOnLHKQ7yOz9hE9ILobR3QZYdx0mvLNyScF6WrXhMLP37Zmy4wKblExAM3VYDeacMBYhtdHT4=</HostId>
</Error>

http://www.blog.labouardy.com/generate-swagger-documentation-from-insomnia-rest-client/
403 ERROR
The request could not be satisfied.
Bad request. We can't connect to the server for this app or website at this time. There might be too much traffic or a configuration error. Try again later, or contact the app or website owner.
If you provide content to customers through CloudFront, you can find steps to troubleshoot and help prevent this error by reviewing the CloudFront documentation.
Generated by cloudfront (CloudFront)
Request ID: a9Ina3yDZ9EuDGbYZNvVm9hB1o5pYGuttNj6GEsqmJKobyDnrXXDfw==

Steps to reproduce the behavior
Clicks on links below:
https://s3.amazonaws.com/swaggymnia/1.0.0-beta/linux/swaggymnia
http://www.blog.labouardy.com/generate-swagger-documentation-from-insomnia-rest-client/

having same issue:
wget https://s3.amazonaws.com/swaggymnia/1.0.0-beta/osx/swaggymnia

and it returned:
--2022-09-17 22:53:35--  https://s3.amazonaws.com/swaggymnia/1.0.0-beta/osx/swaggymnia
Resolving s3.amazonaws.com (s3.amazonaws.com)... <IP_ADDRESS>
Connecting to s3.amazonaws.com (s3.amazonaws.com)|<IP_ADDRESS>|:443... connected.
HTTP request sent, awaiting response... 404 Not Found
2022-09-17 22:53:36 ERROR 404: Not Found.

Having the same problem

same here

Guys,
Swaggyminia does not work anymore and I come with some helpful information, I used swagger-ui-express with openapi: 3.0.0, in this version you can use one authentication to all routes that u want to be authenticated with and not one a one like another versions that I've tried.
Example of swagger file: XP-Bank - Swagger File
This swagger file is not fully formatted, you guys can use some part of this structure to make their swagger file.
I think it could help!

Current behavior
I can't download it, the servers are offline for all URLs, the application does not works anymore?
From terminal:
neur4l in ~
➜  wget https://s3.amazonaws.com/swaggymnia/1.0.0-beta/linux/swaggymnia
--2022-07-23 19:36:55--  https://s3.amazonaws.com/swaggymnia/1.0.0-beta/linux/swaggymnia
Resolving s3.amazonaws.com (s3.amazonaws.com)... <IP_ADDRESS>
Connecting to s3.amazonaws.com (s3.amazonaws.com)|<IP_ADDRESS>|:443... connected.
HTTP request sent, awaiting response... 404 Not Found
2022-07-23 19:36:56 ERROR 404: Not Found.

https://s3.amazonaws.com/swaggymnia/1.0.0-beta/linux/swaggymnia
This XML file does not appear to have any style information associated with it. The document tree is shown below.
<Error>
NoSuchBucket
<Message>The specified bucket does not exist</Message>
<BucketName>swaggymnia</BucketName>
<RequestId>G3KMJF15KTT2A732</RequestId>
<HostId>gkfOnLHKQ7yOz9hE9ILobR3QZYdx0mvLNyScF6WrXhMLP37Zmy4wKblExAM3VYDeacMBYhtdHT4=</HostId>
</Error>

http://www.blog.labouardy.com/generate-swagger-documentation-from-insomnia-rest-client/
403 ERROR
The request could not be satisfied.
Bad request. We can't connect to the server for this app or website at this time. There might be too much traffic or a configuration error. Try again later, or contact the app or website owner.
If you provide content to customers through CloudFront, you can find steps to troubleshoot and help prevent this error by reviewing the CloudFront documentation.
Generated by cloudfront (CloudFront)
Request ID: a9Ina3yDZ9EuDGbYZNvVm9hB1o5pYGuttNj6GEsqmJKobyDnrXXDfw==

Steps to reproduce the behavior
Clicks on links below:
https://s3.amazonaws.com/swaggymnia/1.0.0-beta/linux/swaggymnia
http://www.blog.labouardy.com/generate-swagger-documentation-from-insomnia-rest-client/

Try uploading your exported .json/.yaml from insomnia in https://www.apimatic.io/ , then export from there to OpenAPI 3.x. It worked for me

It Worked Thank you @guipedrazzi


Fix for bdb api changes on new DB_SITE handle

repmgr_set_local_site() and repmgr_add_remote_site() methods
no longer exist, they are replaced by a DB_SITE handle type.
See also: https://docs.oracle.com/cd/E17076_04/html/installation/upgrade_11gr2_52_grp_mbr.html

Just as an FYI I originally forked this and made my changes so I could upload it to a personal gem server. I have no access to the bdb gem on rubygems and I'm not the original maintainer. I've had a long time pull request to get my changes into the repository I forked from, but I don't think the original maintainer looks at that or is there. I don't actually know who even has access to upload new gems for bdb.


Bugfix/4619

Related Issues

closes #4619
Short Description and Why It's Useful

we need to pass {product} to getItem method to get currentItem.
before: await dispatch('getItem', clientItem)
after: await dispatch('getItem', { product })
Also second change which I'm not sure about is that we check item_id instead of server_item_id for clientItem. What I see is that clientItem doesn't have item_id. cartItem has it because it is added by createCartItemForUpdate. I couldn't find any info about this change https://github.com/DivanteLtd/vue-storefront/commit/e073566eb1423881a7f285e958cf0a08f0ff2405#diff-2101c92c40c144e3e56fb400ac211e3dL580-R605
-        if (clientItem.server_item_id) {
+        if (!serverItem) {
+          commit(types.CART_DEL_ITEM, { product: clientItem, removeByParentSku: false })
+        } else if (clientItem.item_id) {

Screenshots of Visual Changes before/after (if There Are Any)

Which Environment This Relates To
Check your case. In case of any doubts please read about Release Cycle

[ ] Test version (https://test.storefrontcloud.io) - this is a new feature or improvement for Vue Storefront. I've created branch from develop branch and want to merge it back to develop
[x] RC version (https://next.storefrontcloud.io) - this is a stabilisation fix for Release Candidate of Vue Storefront. I've created branch from release branch and want to merge it back to release
[ ] Stable version (https://demo.storefrontcloud.io) - this is an important fix for current stable version. I've created branch from hotfix or master branch and want to merge it back to hotfix

Upgrade Notes and Changelog

[x] No upgrade steps required (100% backward compatibility and no breaking changes)
[x] I've updated the Upgrade notes and Changelog on how to port existing Vue Storefront sites with this new feature

IMPORTANT NOTICE - Remember to update CHANGELOG.md with description of your change
Contribution and Currently Important Rules Acceptance

[x] I read and followed contribution rules

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


loopback socket send from shell hangs

When trying to send a packet on loopback socket from shell, the shell hangs.

Enable loopback interface with below settings  CONFIG_NET_DRIVERS=y
  CONFIG_NET_LOOPBACK=y
  CONFIG_NETWORKING=y
  CONFIG_NET_SOCKETS=y
  CONFIG_POSIX_API=y
  CONFIG_NET_TC_TX_COUNT=0

Bind a socket and listen in a thread
From shell send a packet to the socket listening above, the shell immediately hangs, if the packet is dropped by networking stack for e.g., due to same source and port number, then hang is not observed.

I guess this is probably because in drivers/net/loopback loopback_send we feed the packet to recv in the same context.
Even if I use system workqueue to actually do the send above asynchronously it doesn't work.

Observed issue with below as well, and when its hung, halting the Ozone debugger, call stack shows the thread is running i.e., each halt shows different callstack, but looks like it is stuck in a infinite loop of sending?
CONFIG_NET_TC_TX_COUNT=1
CONFIG_NET_TC_RX_COUNT=1

Server: bind 9999, on INADDR_ANY
Client: send 9999, <IP_ADDRESS> (sending on <IP_ADDRESS> works, as the packet is dropped because same source and same port, not sure if this is another bug).

Digging in to this further, its a soft hang, as after first sendto the socket is marked ready, the select always breaks causing a soft while loop and starving other threads. And the reason is EoF was not set in socket FD because of a silly mistake where I hadn't implemented recv in my callback handler after select :).
So, closing this as there is no issue in Zephyr.


'utf-8' codec can't decode byte 0xfa in position 1: invalid start byte

while trying to read a CSV file using pandas the following error occurred. please help -
b'Skipping line 3: expected 1 fields, saw 3\nSkipping line 7: expected 1 fields, saw 2\nSkipping line 8: expected 1 fields, saw 2\nSkipping line 9: expected 1 fields, saw 2\nSkipping line 13: expected 1 fields, saw 3\nSkipping line 14: expected 1 fields, saw 3\nSkipping line 17: expected 1 fields, saw 2\nSkipping line 19: expected 1 fields, saw 2\nSkipping line 20: expected 1 fields, saw 5\nSkipping line 22: expected 1 fields, saw 2\nSkipping line 25: expected 1 fields, saw 3\nSkipping line 26: expected 1 fields, saw 2\nSkipping line 27: expected 1 fields, saw 2\nSkipping line 29: expected 1 fields, saw 2\nSkipping line 31: expected 1 fields, saw 2\nSkipping line 42: expected 1 fields, saw 3\nSkipping line 52: expected 1 fields, saw 2\nSkipping line 57: expected 1 fields, saw 2\nSkipping line 61: expected 1 fields, saw 2\nSkipping line 65: expected 1 fields, saw 3\nSkipping line 69: expected 1 fields, saw 2\nSkipping line 70: expected 1 fields, saw 2\nSkipping line 71: expected 1 fields, saw 2\nSkipping line 79: expected 1 fields, saw 2\nSkipping line 85: expected 1 fields, saw 2\nSkipping line 86: expected 1 fields, saw 4\nSkipping line 88: expected 1 fields, saw 2\n'
Traceback (most recent call last):
File "pandas_libs\parsers.pyx", line 1175, in pandas._libs.parsers.TextReader._convert_tokens
File "pandas_libs\parsers.pyx", line 1281, in pandas._libs.parsers.TextReader._convert_with_dtype
File "pandas_libs\parsers.pyx", line 1297, in pandas._libs.parsers.TextReader._string_convert
File "pandas_libs\parsers.pyx", line 1539, in pandas._libs.parsers._string_box_utf8
UnicodeDecodeError: 'utf-8' codec can't decode byte 0x8b in position 0: invalid start byte
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "D:\Toxic Comment Classification Bangla\Toxic Comment Classification - Copy.py", line 40, in
df = pd.read_csv('BanglaHate.csv',encoding='utf-8',error_bad_lines=False)
File "C:\Users\lenovo\AppData\Local\Programs\Python\Python36\lib\site-packages\pandas\io\parsers.py", line 709, in parser_f
return _read(filepath_or_buffer, kwds)
File "C:\Users\lenovo\AppData\Local\Programs\Python\Python36\lib\site-packages\pandas\io\parsers.py", line 455, in _read
data = parser.read(nrows)
File "C:\Users\lenovo\AppData\Local\Programs\Python\Python36\lib\site-packages\pandas\io\parsers.py", line 1069, in read
ret = self._engine.read(nrows)
File "C:\Users\lenovo\AppData\Local\Programs\Python\Python36\lib\site-packages\pandas\io\parsers.py", line 1839, in read
data = self._reader.read(nrows)
File "pandas_libs\parsers.pyx", line 902, in pandas._libs.parsers.TextReader.read
File "pandas_libs\parsers.pyx", line 924, in pandas._libs.parsers.TextReader._read_low_memory
File "pandas_libs\parsers.pyx", line 1001, in pandas._libs.parsers.TextReader._read_rows
File "pandas_libs\parsers.pyx", line 1130, in pandas._libs.parsers.TextReader._convert_column_data
File "pandas_libs\parsers.pyx", line 1182, in pandas._libs.parsers.TextReader._convert_tokens
File "pandas_libs\parsers.pyx", line 1281, in pandas._libs.parsers.TextReader._convert_with_dtype
File "pandas_libs\parsers.pyx", line 1297, in pandas._libs.parsers.TextReader._string_convert
File "pandas_libs\parsers.pyx", line 1539, in pandas._libs.parsers._string_box_utf8
UnicodeDecodeError: 'utf-8' codec can't decode byte 0x8b in position 0: invalid start byte

b'Skipping line 3: expected 1 fields, saw 3\nSkipping line 7: expected 1 fields, saw 2\nSkipping line 8: expected 1 fields, saw 2\nSkipping line 9: expected 1 fields, saw 2\nSkipping line 13: expected 1 fields, saw 3\nSkipping line 14: expected 1 fields, saw 3\nSkipping line 17: expected 1 fields, saw 2\nSkipping line 19: expected 1 fields, saw 2\nSkipping line 20: expected 1 fields, saw 5\nSkipping line 22: expected 1 fields, saw 2\nSkipping line 25: expected 1 fields, saw 3\nSkipping line 26: expected 1 fields, saw 2\nSkipping line 27: expected 1 fields, saw 2\nSkipping line 29: expected 1 fields, saw 2\nSkipping line 31: expected 1 fields, saw 2\nSkipping line 42: expected 1 fields, saw 3\nSkipping line 52: expected 1 fields, saw 2\nSkipping line 57: expected 1 fields, saw 2\nSkipping line 61: expected 1 fields, saw 2\nSkipping line 65: expected 1 fields, saw 3\nSkipping line 69: expected 1 fields, saw 2\nSkipping line 70: expected 1 fields, saw 2\nSkipping line 71: expected 1 fields, saw 2\nSkipping line 79: expected 1 fields, saw 2\nSkipping line 85: expected 1 fields, saw 2\nSkipping line 86: expected 1 fields, saw 4\nSkipping line 88: expected 1 fields, saw 2\n'
Traceback (most recent call last):
File "pandas_libs\parsers.pyx", line 1175, in pandas._libs.parsers.TextReader._convert_tokens
File "pandas_libs\parsers.pyx", line 1281, in pandas._libs.parsers.TextReader._convert_with_dtype
File "pandas_libs\parsers.pyx", line 1297, in pandas._libs.parsers.TextReader._string_convert
File "pandas_libs\parsers.pyx", line 1539, in pandas._libs.parsers._string_box_utf8
UnicodeDecodeError: 'utf-8' codec can't decode byte 0x8b in position 0: invalid start byte
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "D:\Toxic Comment Classification Bangla\Toxic Comment Classification - Copy.py", line 40, in
df = pd.read_csv('BanglaHate.csv',encoding='utf-8',error_bad_lines=False)
File "C:\Users\lenovo\AppData\Local\Programs\Python\Python36\lib\site-packages\pandas\io\parsers.py", line 709, in parser_f
return _read(filepath_or_buffer, kwds)
File "C:\Users\lenovo\AppData\Local\Programs\Python\Python36\lib\site-packages\pandas\io\parsers.py", line 455, in _read
data = parser.read(nrows)
File "C:\Users\lenovo\AppData\Local\Programs\Python\Python36\lib\site-packages\pandas\io\parsers.py", line 1069, in read
ret = self._engine.read(nrows)
File "C:\Users\lenovo\AppData\Local\Programs\Python\Python36\lib\site-packages\pandas\io\parsers.py", line 1839, in read
data = self._reader.read(nrows)
File "pandas_libs\parsers.pyx", line 902, in pandas._libs.parsers.TextReader.read
File "pandas_libs\parsers.pyx", line 924, in pandas._libs.parsers.TextReader._read_low_memory
File "pandas_libs\parsers.pyx", line 1001, in pandas._libs.parsers.TextReader._read_rows
File "pandas_libs\parsers.pyx", line 1130, in pandas._libs.parsers.TextReader._convert_column_data
File "pandas_libs\parsers.pyx", line 1182, in pandas._libs.parsers.TextReader._convert_tokens
File "pandas_libs\parsers.pyx", line 1281, in pandas._libs.parsers.TextReader._convert_with_dtype
File "pandas_libs\parsers.pyx", line 1297, in pandas._libs.parsers.TextReader._string_convert
File "pandas_libs\parsers.pyx", line 1539, in pandas._libs.parsers._string_box_utf8
UnicodeDecodeError: 'utf-8' codec can't decode byte 0x8b in position 0: invalid start byte

Doesn't look related to dateparser.


type Serializer as generic

Serializer now takes one generic parameter, either str or bytes, to define what dumps returns rather than a str | bytes union.
The default_serializer attribute and serializer argument are a generic protocol with the same parameter. The protocol requires an object that has a loads method and a dumps method that returns the appropriate type.
URLSafeSerizlizer is typed to always return str. This makes it more convenient as the user code no longer needs to do extra work to satisfy the type checker.
s = URLSafeSerializer()
data = s.dumps(...)

fixes #347

Hmm, mypy somehow knows that Serializer().dumps() returns str, even without an annotation. pyright does not though:
from itsdangerous import Serializer

s = Serializer("secret")
data = s.dumps("test")
reveal_type(data)

Mypy reveals str, pyright reveals Unknown unless you do s: Serializer[str] = Serializer().

OK, figured out how to get mypy and pyright to understand that the default is Serializer[str] if no serializer argument is provided. Used an overload that specified the type of self. Now both tools reveal str in the example above.

This doesn't quite make things nice for typing users, as now json and pickle are not "valid" as values to serializer since neither mypy or pyright treat modules with functions as fulfilling a protocol.

These variance issues are why you're getting complaints for json and pickle.

Continued in #376.


tests: spec-tests broken after (#7)

Using jQuery to support MSIE8 naturally broke the spec tests.

Merged for v0.1.3 and v0.2.0


Feature request: add plugin for open brush models

Icosa gallery / open brush app team just released a plugin that takes only two lines of code to support beautiful animated brushes in ANY three.js application. This would be amazing for Webaverse, especially if artists can mint their creations. Full pipeline from VR creation to social sharing / monetization, very metaversey seeds for pseudonymous creator economy

three-icosa provides glTF extensions for three.js that allow for the correct rendering and animation of glTFs exported from Open Brush and the now-discontinued Tilt Brush.

Source: https://github.com/icosa-gallery/three-icosa

I recall avaer made a loader for .tilt files awhile ago, haven't dove into what makes this plugin different - figure it's worth checking out

Thanks for raising the issue! It actually looks like it should be straightforward to integrate this seamlessly (we have similar logic for hubs extensions already).


Suggestion: "withForm" HOC

What
I suggest to ship a HOC dedicated for wrapping the custom form components, which in return render native <Form>.
Why

To get rid of form callback functions and use mapped props instead

How
import { withForm } from 'react-advanced-form';

class RegistrationForm extends React.Component {
  render() {
    const { submitting } = this.props;

    return (
      <Form>
        { submitting && (<Loader />) }
        <Input name="foo" />
      </Form>
    );
  }
}

export default withForm((state) => ({
  submitting: state.isSubmitting
}))(RegistrationForm);

Keynotes

HOC is configurable and has at least mapStateToProps function
HOC exposes the crucial state of the wrapped form, such as submitting, error (form-wide error after onSubmitFail), etc.

This may overcomplicate the overall architecture, and I wouldn't dive into this unless there is a proof use case. Closing.


Kenka Bancho Otome 2nd Rumble!! [PCSG01241]

App summary

App name: 喧嘩番長　乙女　2nd Rumble！！
App serial: PCSG01241
App version: 1.00

Vita3K summary

Version: v0.1.3
Build number: 2325
Commit hash: https://github.com/Vita3K/Vita3K/commit/afb2ea52fc485975a51e5cc525b28fc9568c20b0
CPU backend: Dynarmic

Test environment summary

OS: Windows 10
CPU: Intel(R) Core(TM) i5-10300H CPU @ 2.50GHz   2.50 GHz
GPU: NVIDIA GeForce GTX 1650 Ti/PCIe/SSE2
RAM: 8 GB

Issues
-stuck in the trophy　loading scence
Screenshots

Log
vita3k.log
Recommended labels

Intro

for this game is caused by  dynarmic error

Vita3K v0.1.5 2734-0751c4ee
still the same problem
vita3k.log

So how should we solve it? I have the same problem.

for this game is caused by dynarmic error

How should I modify it?


Manually create CPI client for Serum DEX

Create a dex module analogous to https://github.com/project-serum/anchor/blob/master/spl/src/token.rs in the anchor_spl crate.

Bumping this. Would be great to have
- InitializeMarket
- NewOrder(V?)
- ConsumeEvents
- CancelOrder(V?)
- SettleFunds

Currently have new_order and settle_funds from #224.. The rest are straightforward to add as needed.

Think we mostly sorted this over time.


Intellij create step implementation in ruby project only wants to create java class

I have an existing ruby on rails project in Intellij that I'm looking to add Gauge tests to. I did a "gauge --init ruby" in the root directory of the project.
The new files and setting were created as expected, and running 'gauge specs/' works as expected.
I then created a new specification, a scenario and a couple steps.
When I use the keyboard shortcut to create step implementation I'm only presented with the option of creating a new file. When I choose that option the file types are for a java project.

Sorry Ken. Gauge IntelliJ plugin supports only Java. We do not have support for any IDE for Ruby as of now.
You can find more details about IDE support over here.

Ah, didn't realize. Thanks


Update pyproject.toml: added missing quotation mark

Update pyproject.toml: added missing quotation mark

Cleaning up this old PR.


Adding context to glob! on panic

In case my code panics in this common pattern, it is somewhat difficult to figure out which original file has caused the failure.  Would it be possible for glob! to use catch_unwind and report the file being processed?
glob!("../tests/fixtures", "**/*.txt", |file| {
    // this panic is deep inside the code,
    // without any knowledge of the current file
    panic!("something panicked");
});

Expected output
---- my_test stdout ----
while processing `some_path/my_input_file_discovered_by_glob.txt`:
thread 'my_test' panicked at <some_file>:
My error message

Slightly tangential, but we use description=> to add context to the errors within a glob!:
https://github.com/PRQL/prql/blob/c3ab63acdbd0729f73a18aa420216bc91cc7d2d1/crates/prql-compiler/tests/integration/main.rs#L345-L349
(giving more context automatically sounds like a good idea too though...)

Maybe there could be a flag that controls catching of panics. I think the issue is that the rust testing infrastructure is already pretty brittle as it stands and catching down panics might be a bit too magic?


Duplicate applications are threaded in Gmail

Right now if someone submits their application twice it gets attached to only one of the club application boxes on Streak because both emails have the same subject and Gmail threads emails with the same subject. We can fix this by adding their club application ID to the email subject.
We'll also want to remove the club application ID added to the confirmation email message we currently have here: https://github.com/hackclub/monolith/blob/master/api/app/views/club_application_mailer/admin_notification.text.erb#L10

@paked any updates on this?


Section "Using the Count Filter" is very wrong

Pretty much the whole "Count" section is wrong (heading included).  Please see the screenshot attached for my comments.
If you'd like me to review again after a revised version is drafted I'd be happy to.
Thank you
Regards, David.

@rebeccas-workfront , I believe this is the article: https://experienceleague.adobe.com/docs/workfront/using/adobe-workfront-api/api-general-information/api-basics.html?lang=en
Thanks!

Yes, that's the one.  I clicked the Report an Issue button at the bottom of this page but I'm guessing it didn't give you the URL.
Thank you for looking into it.
Regards, David

Hi David,
Regarding this page of the Workfront documentation (https://experienceleague.adobe.com/docs/workfront/using/adobe-workfront-api/api-general-information/api-basics.html?lang=en), you wrote:
"Pretty much the whole "Count" section is wrong (heading included). Please see the screenshot attached for my comments."
Thank you for bringing this to our attention. I've updated the article to reflect what you pointed out. The changes are live online now.
Thanks for helping to improve the Workfront documentation!
-Rebecca

Thank you Rebecca - the wording is perfect now!  Great job.
Regards,
David Cornwell
Senior Integrations Architect
E.
@.***
W.
leappoint.comhttp://www.leappoint.com
[https://signaturehound.com/api/v1/file/101tmrnldu6ojyg]http://www.leappoint.com
[https://signaturehound.com/api/v1/png/linkedin/round-outlined/000000.png]https://www.linkedin.com/company/leappoint-llc/
[https://signaturehound.com/api/v1/png/twitter/round-outlined/000000.png]https://twitter.com/leappointllc
[https://signaturehound.com/api/v1/png/facebook/round-outlined/000000.png]https://www.facebook.com/LeapPoint
[https://signaturehound.com/api/v1/png/instagram/round-outlined/000000.png]https://www.instagram.com/leappoint
[https://signaturehound.com/api/v1/png/youtube/round-outlined/000000.png]https://www.youtube.com/channel/UCz_rJxXkbTiF49yGVeKbktA/featured?themeRefresh=1
The content of this email is confidential and intended for the recipient specified in message only. It is strictly forbidden to share any part of this message with any third party, without a written consent of the sender. If you received this message by mistake, please reply to this message and follow with its deletion, so that we can ensure such a mistake does not occur in the future.
Book time to meet with me @.***?anonymous&ep=pcard>

From: rebeccas-workfront @.>
Sent: Saturday, January 20, 2024 3:34 AM
To: AdobeDocs/workfront.en @.>
Cc: David Cornwell @.>; Author @.>
Subject: Re: [AdobeDocs/workfront.en] Section "Using the Count Filter" is very wrong (Issue #30)
Hi David,
Regarding this page of the Workfront documentation (https://experienceleague.adobe.com/docs/workfront/using/adobe-workfront-api/api-general-information/api-basics.html?lang=en), you wrote:
"Pretty much the whole "Count" section is wrong (heading included). Please see the screenshot attached for my comments."
Thank you for bringing this to our attention. I've updated the article to reflect what you pointed out. The changes are live online now.
Thanks for helping to improve the Workfront documentation!
-Rebecca
—
Reply to this email directly, view it on GitHubhttps://github.com/AdobeDocs/workfront.en/issues/30#issuecomment-1901074466, or unsubscribehttps://github.com/notifications/unsubscribe-auth/BFMRARDXXRENNPMUO5TJYPDYPLKERAVCNFSM6AAAAABB5EJBJCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMBRGA3TINBWGY.
You are receiving this because you authored the thread.Message ID: @.***>