Error building when modifying the solution

I can get this to run unmodified; however, I made a few modifications:

Added additional docker images (tested locally and these build correctly) - also if I don't delete on stack failure these images are present.
added additional batch jobs for docker images
removed sections of the code the upload the sample data.

I updated the policy for the sample bucket to :
      Policies:
        - PolicyName: S3Access
          PolicyDocument:
            Version: 2012-10-17
            Statement:
              - Effect: Allow
                Action:
                  - s3:ListBucket
                  - s3:GetObject
                  - s3:GetObjectVersion
                  - s3:PutObject
                Resource:
                  - !Sub arn:aws:s3:::${JobResultsBucket}
                  - !Sub arn:aws:s3:::${JobResultsBucket}/*
              - Effect: Allow
                Action:
                  - s3:ListBucket
                  - s3:GetObject
                Resource:
                  - arn:aws:s3:::my_data_folder
                  - arn:aws:s3:::my_data_folder/*
                  # - !Sub arn:aws:s3:::${SamplesBucket}
                  # - !Sub arn:aws:s3:::${SamplesBucket}/*

I get the following error when building and I am unclear what it means or how to debug it.
2021-09-07T08:53:14.924-07:00	++ get-repo-url GenomicsWorkflowPipe
2021-09-07T08:53:14.924-07:00	++ local stack_name=GenomicsWorkflowPipe
2021-09-07T08:53:14.924-07:00	+++ aws cloudformation describe-stacks --stack-name GenomicsWorkflowPipe --query 'Stacks[].Outputs[?OutputKey==`RepoCloneUrl`].OutputValue' --output text
2021-09-07T08:53:14.924-07:00	++ local url=https://git-codecommit.us-west-1.amazonaws.com/v1/repos/GenomicsWorkflowCode
2021-09-07T08:53:14.924-07:00	++ echo https://git-codecommit.us-west-1.amazonaws.com/v1/repos/GenomicsWorkflowCode
2021-09-07T08:53:14.924-07:00	+ git remote add origin https://git-codecommit.us-west-1.amazonaws.com/v1/repos/GenomicsWorkflowCode
2021-09-07T08:53:14.924-07:00	+ git push -u origin master
2021-09-07T08:53:18.981-07:00	To https://git-codecommit.us-west-1.amazonaws.com/v1/repos/GenomicsWorkflowCode
2021-09-07T08:53:18.981-07:00	* [new branch] master -> master
2021-09-07T08:53:18.981-07:00	Branch 'master' set up to track remote branch 'master' from 'origin'.
2021-09-07T08:53:18.981-07:00	+ wait-for-stack GenomicsWorkflowCode
2021-09-07T08:53:18.981-07:00	+ local stack_name=GenomicsWorkflowCode
2021-09-07T08:53:18.981-07:00	+ local exists_attempts=6
2021-09-07T08:53:18.981-07:00	+ local status=0
2021-09-07T08:53:18.981-07:00	+ set +e
2021-09-07T08:53:18.981-07:00	+ echo 'Creating stack: GenomicsWorkflowCode'
2021-09-07T08:53:18.981-07:00	Creating stack: GenomicsWorkflowCode
2021-09-07T08:53:18.981-07:00	+ (( attempt=1 ))
2021-09-07T08:53:18.981-07:00	+ (( attempt<=6 ))
2021-09-07T08:53:18.981-07:00	+ echo 'Waiting for stack creation - attempt: 1'
2021-09-07T08:53:18.981-07:00	Waiting for stack creation - attempt: 1
2021-09-07T08:53:18.981-07:00	+ aws cloudformation wait stack-exists --stack-name GenomicsWorkflowCode
2021-09-07T08:54:55.034-07:00
2021-09-07T08:54:55.034-07:00	Waiter StackExists failed: Max attempts exceeded. Previously accepted state: Matched expected service error code: ValidationError
2021-09-07T08:54:55.034-07:00	+ status=255
2021-09-07T08:54:55.034-07:00	+ '[' 255 -eq 0 ']'
2021-09-07T08:54:55.034-07:00	+ (( attempt++ ))
2021-09-07T08:54:55.034-07:00	+ (( attempt<=6 ))
2021-09-07T08:54:55.034-07:00	+ echo 'Waiting for stack creation - attempt: 2'
2021-09-07T08:54:55.034-07:00	Waiting for stack creation - attempt: 2
2021-09-07T08:54:55.034-07:00	+ aws cloudformation wait stack-exists --stack-name GenomicsWorkflowCode
2021-09-07T08:56:31.112-07:00
2021-09-07T08:56:31.112-07:00	Waiter StackExists failed: Max attempts exceeded. Previously accepted state: Matched expected service error code: ValidationError
2021-09-07T08:56:31.112-07:00	+ status=255
2021-09-07T08:56:31.112-07:00	+ '[' 255 -eq 0 ']'
2021-09-07T08:56:31.112-07:00	+ (( attempt++ ))
2021-09-07T08:56:31.112-07:00	+ (( attempt<=6 ))
2021-09-07T08:56:31.112-07:00	+ echo 'Waiting for stack creation - attempt: 3'
2021-09-07T08:56:31.112-07:00	Waiting for stack creation - attempt: 3
2021-09-07T08:56:31.112-07:00	+ aws cloudformation wait stack-exists --stack-name GenomicsWorkflowCode
2021-09-07T08:58:07.196-07:00
2021-09-07T08:58:07.196-07:00	Waiter StackExists failed: Max attempts exceeded. Previously accepted state: Matched expected service error code: ValidationError
2021-09-07T08:58:07.196-07:00	+ status=255
2021-09-07T08:58:07.196-07:00	+ '[' 255 -eq 0 ']'
2021-09-07T08:58:07.196-07:00	+ (( attempt++ ))
2021-09-07T08:58:07.196-07:00	+ (( attempt<=6 ))
2021-09-07T08:58:07.196-07:00	+ echo 'Waiting for stack creation - attempt: 4'
2021-09-07T08:58:07.196-07:00	Waiting for stack creation - attempt: 4
2021-09-07T08:58:07.196-07:00	+ aws cloudformation wait stack-exists --stack-name GenomicsWorkflowCode
2021-09-07T08:59:43.284-07:00
2021-09-07T08:59:43.284-07:00	Waiter StackExists failed: Max attempts exceeded. Previously accepted state: Matched expected service error code: ValidationError
2021-09-07T08:59:43.284-07:00	+ status=255
2021-09-07T08:59:43.284-07:00	+ '[' 255 -eq 0 ']'
2021-09-07T08:59:43.284-07:00	+ (( attempt++ ))
2021-09-07T08:59:43.284-07:00	+ (( attempt<=6 ))
2021-09-07T08:59:43.284-07:00	+ echo 'Waiting for stack creation - attempt: 5'
2021-09-07T08:59:43.284-07:00	Waiting for stack creation - attempt: 5
2021-09-07T08:59:43.284-07:00	+ aws cloudformation wait stack-exists --stack-name GenomicsWorkflowCode
2021-09-07T09:01:21.383-07:00
2021-09-07T09:01:21.383-07:00	Waiter StackExists failed: Max attempts exceeded. Previously accepted state: Matched expected service error code: ValidationError
2021-09-07T09:01:21.383-07:00	+ status=255
2021-09-07T09:01:21.383-07:00	+ '[' 255 -eq 0 ']'
2021-09-07T09:01:21.383-07:00	+ (( attempt++ ))
2021-09-07T09:01:21.383-07:00	+ (( attempt<=6 ))
2021-09-07T09:01:21.383-07:00	+ echo 'Waiting for stack creation - attempt: 6'
2021-09-07T09:01:21.383-07:00	Waiting for stack creation - attempt: 6
2021-09-07T09:01:21.383-07:00	+ aws cloudformation wait stack-exists --stack-name GenomicsWorkflowCode
2021-09-07T09:02:58.238-07:00
2021-09-07T09:02:58.238-07:00	Waiter StackExists failed: Max attempts exceeded. Previously accepted state: Matched expected service error code: ValidationError
2021-09-07T09:02:58.238-07:00	+ status=255
2021-09-07T09:02:58.238-07:00	+ '[' 255 -eq 0 ']'
2021-09-07T09:02:58.238-07:00	+ (( attempt++ ))
2021-09-07T09:02:58.238-07:00	+ (( attempt<=6 ))
2021-09-07T09:02:58.238-07:00	+ '[' '!' 255 -eq 0 ']'
2021-09-07T09:02:58.238-07:00	+ echo '[ERROR] Stack creation could not be started.'
2021-09-07T09:02:58.238-07:00	[ERROR] Stack creation could not be started.
2021-09-07T09:02:58.238-07:00	+ return 255
2021-09-07T09:02:58.238-07:00	+ status=255
2021-09-07T09:02:58.238-07:00	+ set -e
2021-09-07T09:02:58.238-07:00	+ '[' '!' 255 -eq 0 ']'
2021-09-07T09:02:58.238-07:00	+ echo '[ERROR] GenomicsWorkflowCode Stack FAILED'
2021-09-07T09:02:58.238-07:00	[ERROR] GenomicsWorkflowCode Stack FAILED
2021-09-07T09:02:58.238-07:00	+ exit 255
2021-09-07T09:02:58.238-07:00
2021-09-07T09:02:58.238-07:00	[Container] 2021/09/07 16:02:56 Command did not exit successfully ./setup/$SOLUTION_ACTION.sh exit status 255
2021-09-07T09:02:58.238-07:00	[Container] 2021/09/07 16:02:56 Phase complete: INSTALL State: FAILED
                               [Container] 2021/09/07 16:02:56 Phase context status code: COMMAND_EXECUTION_ERROR Message: Error while executing command: ./setup/$SOLUTION_ACTION.sh.
                               Reason: exit status 255

Upon digging through the logs I found:
denied: User: arn:aws:sts::<ACCOUNTID>:assumed-role/DataQualityWorkflowsPipe-IamRoles-JC-CodeBuildRole-27UMBE2B38IO/AWSCodeBuild-5f5cca70-b5d1-4072-abac-ab48b3d387ed is not authorized to perform: ecr:CompleteLayerUpload on resource: arn:aws:ecr:us-west-1:<ACCOUNTID>:repository/dataqualityworkflows-spades
I've added 5 tools, fastp, fastqc, megahit, spades and bbtools and the other will push to ECR but spades will not; and I am not sure why?  Any assistance would be grateful.
denied: User: arn:aws:sts::378882993238:assumed-role/DataQualityWorkflowsPipe-IamRoles-JC-CodeBuildRole-27UMBE2B38IO/AWSCodeBuild-5f5cca70-b5d1-4072-abac-ab48b3d387ed is not authorized to perform: ecr:CompleteLayerUpload on resource: arn:aws:ecr:us-west-1:378882993238:repository/dataqualityworkflows-spades

Hey Daniel,
I'm not the developer of this solution but I think that the developers did not planed that you use their solution that way.
See issue: https://github.com/awslabs/genomics-secondary-analysis-using-aws-step-functions-and-aws-batch/issues/2
Am I right that you are trying to modify directly the files that are present in this repo ?
Here is how I added my private ECR images and how I think the developer would rather do:
Deploy the stacks using the files provided in this repo, without modification, that I think you managed.
Then you will have in your CodeCommit two repos: "Code" and "Pipe". You should clone these repos and make your own customizations there.
"Pipe" is the repo that deploys the resources that are necessary for "Code" to operate. If you have a look into CodePipeline, you have the "CodePipeline"  that for the moment only builds the code and the Docker images defined in the vanila project. So you must modify these so that your new Docker images are built.
To do so you modify main.cfn.yaml in "Pipe" CodeCommit  and that's where you add your "StackBuildContainerSpades". Then at the end of the same file you modify the code pipeline so that you include the new stack in the build phase. Once pushed you will see that the CodePipeline now has the unbuilt Spades block in the build phase.
Now you need to add a new folder in the "Code" repo: containers/spades/ and write the Dockerfile there. If everything is in order, next time the Pipeline "Code" will run, this file will be read and the spades container built into ECR. As this is use case is already planed in the vanilla project, you should not need to modify any IAM role. (all ecr rights are already included in the CodeBuildSeviceRole of the "Pipe" repo. In the main.cfn.yaml, you will have to define the Batch job definition based on the spades container however.
At least that's how I managed to build my own custumized solution and I think was the intended use. I hope this is more or less clear.

@sachalau
First off thank you so much, I believe I am now on the right path!
However, I am now running into an issue where the new docker containers are not being built and if I trigger them manually by clicking Start Build from the web UI I get the following error:
Build failed to start. The following error occurred: ArtifactsOverride must be set when using artifacts type CodePipelines
Error from Web UI

I think you can't build the images from the UI because you have defined an artifact that must come from CodePipelines. Can you push a change to your "Code" CodeCommit" or release a change to the "Pipe" CodePipeline tools ?

@sachalau - I don't think I am following. I followed the PFD guide and first updated the GenomicsWorkflowPipe repo, I modified main.cfn.yml like I have shown above by added StackBuildContainerSpades and then under the Codepipeline section added a new section for Spades.

Yep. Now if you go to the codepipeline "pipe" you should see in the build s
stage the steps for building the docker images you added. However as you
have not run the codepipeline "pipe" since you added them, they should
appear as grey "did not run". To run this pipeline, you must either push a
change to the repo "code" or in the UI, click release change.
Le mer. 8 sept. 2021 à 19:31, Daniel Donovan @.***> a
écrit :

@sachalau https://github.com/sachalau - I don't think I am following. I
followed the PFD guide and first updated the GenomicsWorkflowPipe repo, I
modified main.cfn.yml like I have shown above by added
StackBuildContainerSpades and then under the Codepipeline section added a
new section for Spades.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/awslabs/genomics-secondary-analysis-using-aws-step-functions-and-aws-batch/issues/6#issuecomment-915432574,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AD347NJIBLX7R7OKWYKWRJDUA6MWHANCNFSM5DSYTJOA
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.


Refactored ansible-mongo script

Removed unused packages:

fluentd

Added kitchen test to verify if the mongo_server and client are installed.
Added ability to control the version of mongo that is installed.

team approved


Fallback text for icons in ActionHeader buttons

Description of Issue
The icons used in the action header buttons need to have fallback text in case the icons fail to load.

@jmsv6d What are the cases where the icons fail to load?

@Matt-Butler This was a change that was made recently in our legacy component. Looking back at the issue, it was with font icons failing to load. I'm not sure if this could still happen with svg icons.

Closed with #50


Update crane

Codecov Report

Merging #385 (d7199ba) into master (b3ea1ae) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #385      +/-   ##
==========================================
- Coverage   75.19%   75.18%   -0.01%
==========================================
  Files          83       83
  Lines       10406    10406
==========================================
- Hits         7825     7824       -1
- Misses       2581     2582       +1

Impacted Files
Coverage Δ

minimint/src/net/peers.rs
92.89% <0.00%> (-0.27%)
:arrow_down:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


#329: copy pspjuth techtree.zip

This just copies the zip file here that @pspjuth posted. Seems to work fine for me with R&F + spring update

Thanks for helping with CQUI. The spring patch is in branch Patch-<IP_ADDRESS>7, not master. Although I'm pretty confident this is already merged into that branch, just not into R&F.

My mistake... I meant to branch off of expansion1.


Toggle block comment add extra single space

VSCode Version: Code 1.14.1 (2648980a697a4c8fb5777dcfb2ab110cec8a2f58, 2017-07-13T19:18:47.188Z)
OS Version: Windows_NT ia32 10.0.15063
Extensions:

Extension
Author (truncated)
Version

html-snippets
abu
0.1.0

vscode-simpler-icons
dav
1.3.0

csharp
ms-
1.11.0

debugger-for-chrome
msj
3.1.6

vscode-icons
rob
7.10.1

html-css-class-completion
Zig
1.7.0

(3 theme extensions excluded)

Steps to Reproduce:
Toggle block comment (shift + alt + a) add extra single space at the start and end of the block.
If remove comment again by pressing shift + alt + a , the white space added previously should remove.
Please do the needful.

Reproduces without extensions: Yes/No

It's already fixed and you can see that in Insider or next Stable release. Thanks!


Fix typo: "starts to fail" → "fails to start"

I have trouble making sense of the current phrasing, whereas switching the older of the words matches the implication of the parenthesized part.

Thanks!


Update MockSplFileInfo.php

I would do this, or have a break at every case. I prefer this.

LGTM, Can you submit a PR on symfony/symfony for the 2.7 branch instead? This is a read-only repo.

whoops. https://github.com/symfony/symfony/pull/19718


Comparison with offlineimap

I'm currently trying to decide between offlineimap, imapfw and mbsync/isync.
As such, a comparison between all three of them would be nice to help people decide, but is probably out of scope here - but since you're familiar with at least offlineimap and imapfw and slightly competing against your previous stable software here: how does offlineimap compare to imapfw, and what's the status, what's supported by each one of them and what isn't, and so on. Is there an overview somewhere?

imapfw is definitely not ready. It's still very early stage.
For a full comparison between offlineimap and mbsync I have no idea and I'm not aware of something like that available on the web.
Some users have more success with offlineimap, some other with mbsync. I've read comments that users tend to find that mbsync is faster than offlineimap. OTOH, offlineimap is more flexible.
You might like to try both.

I found offlineimap is better that it support Windows. I cannot make mbsync to support Windows.


Consider Open-Sourcing the project by adding a License

First of all nice work!
The module looks pretty complete and well thought out.
Please consider using license by adding a file called LICENSE at the root of the repository directory 😉.

Hi Alejandro, thanks for the suggestion, we will do it 🦾. Also be free to contribute.!

Thanks @asajaroff for contributing!
@federicoaaguirre, I've left some comments in #10.

Solved: v3.1.4


Resizing container with autoResize does not work

@bluepnume
In the xcomponent.create I have:
autoResize: {
height: true,
width: true
}
But it does not autoresize.
I tried to pass a prop from parent resizeParent:function(){ window.resize('100%', '100%');}
Then, calling window.xprops.resizeParent();
I have a react component as child. It is a list of items.
I would like to resize parent container once there are more/less items in the child.
But that did not work as well 😟
Thanks!

I had the same problem with autoResize until i added an element property pointing to a css selector of my embedded app. I couldn't find this behavior on the docs.
autoResize {   height: true,   width: true,   element: '.my-selector' }

@jelohe
You are the savoir! Worked great.
Thanks a lot 😃

@bluepnume
Would you like to add it to docs?
Should I make a pull request to add the info?

#148: Let me know if this makes it clear.


chore: updated source paths

paths moved from .spec.modules to .spec.distribution.modules
indent template functions are now dynamic for tolerations/ nodeSelector
fixed paths to vendor module's folders

@omissis @Al-Pragliola we need to change the target branch for this PR, this branch feature/template-eks is superseded by this one


Cant create resources

Describe the bug
I cant any resource via template or new resource wizard
[2022-03-26 03:31:58.670] [error] (node:5182) Warning: Keys with collection values will be stringified due to JS Object restrictions: "[\n  {\n      description: Address ...". Set mapAsMap: true to use object keys.
Desktop (please complete the following information):

OS: [e.g. ]Linux Ubuntu
Version [e.g. 22]20.04 LTS

Thanks for the issues you created @Drontitan !! We will fix them as soon as possible and release the next version.

Hi @Drontitan , this should be fixed in 1.6.2, let us know if you still have any problems!

Fixed.


Fix storage of DOM elements

If you store a DOM element in a value() you may get errors from the browser or in more rare cases (explained in the commit message) an error during vnode patching.
The vnode patching error feels like something inside Vue is wrong for something like this to be able to cause that kind of error but I want to look more into it to see why that might be happening.
In any case this appears to fix the issue from what I can tell. I have not written a test for it yet, just a stub. I need to figure out how to write one that will verify the problem whether or not its run in a browser.

Cool! I met this problem yesterday when using tiptap rich text editor.

Oh good so I'm not completely crazy for trying to put a DOM element into an observed property.
🙌

The default environment in Jest is jsdom, we don't need to install it again.

Hi @liximomo, thank you for your efforts for the wonderful 2.2.0~  I am eager to try the new render function support ;) .
However,  just like what @thecrypticace shows above, when I am using tiptap (https://github.com/scrumpy/tiptap, probably the best rich text editor in
Vue ecosystem) it breaks the whole vue runtime when emitting events under higher than 2.0.6, saying no el in vnode.

Seeing as the new proposal has changed things a bit I'm closing this PR. This issue will need to be resolved in some manner in any case due to the introduction of template refs.


Wrong Author Order in the Pre-record Talk

Zhepei Wei reported through acl2020-virtual-helpdesk google group that in the extra preface added to the slides where the title and authors are presented, the order of authors is wrong.
The correct order should be as below:
Zhepei Wei, Jianlin Su, Yue Wang, Yuan Tian, Yi Chang

I believe SlidesLive has kept the author names in lexicographical order in the preface slide for all the presentations. :confused:

Hello Sayan,
Thanks for the reply. Is there any way we could change it? If not, i will
get back to the author who reported this issue.
Best,
Yiding
On Sun, Jul 5, 2020 at 2:32 PM Sayan Sinha<EMAIL_ADDRESS>wrote:

I believe SlidesLive has kept the author names in lexicographical order in
the preface slide for all the presentations. 😕
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/acl-org/acl-2020-virtual-conference/issues/469#issuecomment-653848606,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AO55FCQ6AXPPAZEZ7WRWC7LR2ANATANCNFSM4OQXGVHA
.

Hi @ranyd18! I don't think we can make the change by issuing any patch in this repo. We would have to contact SlidesLive to make the change from their end. He has been contacted on chat, so let's hope this issue gets resolved soon! :smiley:

Hello Sayan,
Thanks for the prompt response! I will update the authors with this
information.
Best,
Yiding
On Sun, Jul 5, 2020 at 2:52 PM Sayan Sinha<EMAIL_ADDRESS>wrote:

Hi @ranyd18 https://github.com/ranyd18! I don't think we can make the
change by issuing any patch in this repo. We would have to contact
SlidesLive to make the change from their end. He has been contacted on
chat, so let's hope this issue gets resolved soon! 😃
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/acl-org/acl-2020-virtual-conference/issues/469#issuecomment-653850002,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AO55FCXBPABMJS6BXTWTBR3R2APLPANCNFSM4OQXGVHA
.


Fix request to API

Update schemas
Regenerate python code for new schemas
Move api urls to settings
Fix get pools request'

@Alliad please fail in not 200 and push merge.


Add transformers usage & demo link to model card

I wanted to open an issue here before opening the PR. It would be nice to add how to use Nougat with transformers API and the link to this demo so people can see the API and also try the model right away. If the repository owners agree I can open a PR.

Where you able to figure out any progress on this? I want to make this work for a browser based transformers.js setup

Where you able to figure out any progress on this? I want to make this work for a browser based transformers.js setup

Ah nvm! Seems like it's already implemented in transformers.js !


Fix Flow 0.14.0 errors

Flow hates the let keyword, so you might as well use var. It also complains about the _scrollComponent property; don't know how resonable my kludge is there... Another option of course would be to remove the @flow declaration?

We'll remove the flow declaration since 'let' support is coming soon.

I published 0.1.1 with @flow removed.

Cool, thanks!


[FORMATS-124] Add field for generic non-reference allele.

Resolves #124. Adds a field to cover the case where a variant contains a symbolic non-reference alternate allele.
I'm not sure if I like this approach. Putting it out there to see if other people like it or don't like it.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/bdg-formats-prb/148/
Test PASSed.

https://github.com/bigdatagenomics/adam/pull/1389 made this unnecessary, closing as WontFix


change crawler container polling to event-driven

Problem Statement
Currently, crawler collects the knowledge of all running container by periodically polling (docker ps) containers. Containers having their life-span shorter than this polling period are essentially missed from crawling. So we need to add support to register for container creation/deletion events and immediately crawling containers upon their instantiation.
Limitation
Currently, such event notification support is provided by only docker containers. So such support will be available only for docker containers.
Functional Requirement
Add a docker event monitor (simple docker-py client) which will register for container create and delete events. This monitor need to be started as a separate thread.
We will implement thread-safe queue to store container events (create and delete).
Docker monitor will push any container event into this queue.
And in our main scheduler, feature this queue with blocking loop and a timeout. Thus, if no container is created within a timeout, call will be un-blocked automatically and if there is any container creation event within timeout, then it will immediately un-block and container will be crawled.
For container delete event will also need to be handled ? So that deleted containers will be removed from local cache of running containers.
References:
Sample docker event monitor:
https://github.com/cloudviz/agentless-system-crawler/pull/52/files#diff-455ca27256f59b449d25d58e202d5f60
Main scheduler blocking:
container_event = eventQ.get(block=True, timeout = wait_period)

PR #215 merged to master.


Antithesis instrumentation improvements

High Level Overview of Change
Minor changes relating to feedback received late in #5042

Context of Change

Rename ASSERT to XRPL_ASSERT
Upgrade to Anthithesis SDK 0.4.4
Use new 0.4.4 features

automatic cast to bool, like assert

Add instrumentation workflow to verify build with instrumentation enabled

Type of Change

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[x] Refactor (non-breaking change that only restructures code)
[ ] Performance (increase or change in throughput and/or latency)
[ ] Tests (you added tests for code that already exists, or your new feature included in this PR)
[ ] Documentation update
[x] Chore (no impact to binary, e.g. .gitignore, formatting, dropping support for older tooling)
[ ] Release

Man, I wish I could ignore the ASSERT -> XRPL_ASSERT changes the way I can ignore whitespace. This PR would be like 50 lines long.

You could repeat what I've done
for i in $(git grep -Hwn ASSERT | grep -oE '^[^.]+.(cpp|h|ipp)|^CONTRIBUTING.md' | sort -u); do sed -i "s|\bASSERT\b|XRPL_ASSERT|g" "$i"; done
find include src -type f \( -name '*.cpp' -o -name '*.hpp' -o -name '*.h' -o -name '*.ipp' \) -exec clang-format -i {} +

... and then compare results.


RTL.bbcode_text += operator doesn't use append_bbcode

should use append_bbcode, currently it uses set_bbcode internally if doing += operator on bbcode_text property.
(set_bbcode causes massive lag when adding a ton of text over time to the "bbcode_text" property)
@willnationsdev is current rtl guru, plz take a look, ty sir.
https://github.com/godotengine/godot/blob/e24f2c6489afdccc6268008d3dcc1ff4ad8ea71c/scene/gui/rich_text_label.cpp#L2044
just to add: possible internal issue with gdscript's += operator, since it's a string appendation.
might need a special case for bbcode_text appending, and have it use append_bbcode instead

I don't think it can be easily solved, it would imply adding support for all properties to set different methods to overload operators.

@akien-mga i see. maybe in docs prob be good to note that using append_bbcode is ideal then. users who are using bbcode_text += text might notice slowdown. ( where i found this bug initially )
can close if you want sir, this is prob low priority, just figured i let u you know!

Well I agree that at least the documentation should be improved.


FEATURE: implement eval phase 2 and expose as a library.

Currently we are using Aiken via JNI binding to evaluate cost for redeemers but it would be nice to have a library / interface from this library accessible from Java that would simply allow us to get rid of JNI binding as this project implement CEK machine.
https://github.com/bloxbean/aiken-java-binding
https://github.com/bloxbean/aiken-jna-wrapper

"A bit later" I've implemented it 87e352252a7722e53b5b8fa808c466ee14c4db7b


no rewards when running different game using dqn_atari.py

Hello,
I have encountered a issue when I try to test out a different gym game called "Enduro-v0" using dqn_atari.py. For some reasons I only get zero reward for both episode reward and mean reward. The only part of the code that I change is the following:
 parser.add_argument('--env-name', type=str, default='Enduro-v0')

This means that the agent never discovers a state that yields a reward. However, since this is not an issue with the framework itself but rather a problem with an application, please refer to the Keras-RL Google group for further discussion: https://groups.google.com/forum/#!forum/keras-rl-users


Implement Connor's RSI

Expected Behavior
Connor's RSI is supported.
Actual Behavior
Connor's RSI is not supported:
https://www.quantconnect.com/forum/discussion/4824/anyone-have-connors-rsi
Potential Solution
Implement Connor's RSI:
https://stockcharts.com/school/doku.php?id=chart_school:trading_strategies:rsi2
https://www.tradingview.com/wiki/Connors_RSI_(CRSI)
Checklist

[x] I have completely filled out this template
[x] I have confirmed that this issue exists on the current master branch
[x] I have confirmed that this is not a duplicate issue by searching issues

spy_crsi.csv

spy_crsi.csv
columns: "SPY close" "Conner RSI"
script:
import talib

qb = QuantBook()

spy = qb.AddEquity("SPY", Resolution.Daily).Symbol

history = qb.History([spy, qqq], datetime(1998, 1, 1), datetime(2023, 2, 23))

close = history.loc[spy].close

# Source: https://www.tradingview.com/support/solutions/43000502017-connors-rsi-crsi/
rsi = talib.RSI(close, 3)
streak = close * 0
for i in range(1, len(close)):
    if streak.iloc[i-1] / close.pct_change().iloc[i] <= 0:
        streak.iloc[i] = 0
    else:
        streak.iloc[i] = streak.iloc[i-1]
    if close.iloc[i] > close.iloc[i-1]:
        streak.iloc[i] = streak.iloc[i] + 1
    elif close.iloc[i] < close.iloc[i-1]:
        streak.iloc[i] = streak.iloc[i] - 1
rsi_streak = talib.RSI(streak, 2)
crsi = ((rsi + rsi_streak + close.pct_change(100)) / 3).to_frame()
crsi["SPY close"] = close
crsi = crsi.iloc[:, [1, 0]].dropna()
crsi.to_csv("spy_crsi.csv", header=False)

spy_crsi.csv
Columns: date, close, crsi
The script has been updated, and the way the last part is calculated has changed. Instead of using close.pct_change(100), which is a ROC with a period of 100, a ROC with a period of 1 is used. Then, the current value is compared with the previous 100 ROC values, and finally, the percentage of values that are lower than the current one is calculated. Source
import talib
import pandas as pd

history = pd.read_csv("https://github.com/QuantConnect/Lean/raw/master/Data/equity/usa/daily/spy.zip",
                       index_col=0, names=["open", "high", "low", "close", "volume"])

close = history.close
pd.set_option('display.max_rows', 115)

# Source: https://chartschool.stockcharts.com/table-of-contents/technical-indicators-and-overlays/technical-indicators/connorsrsi
rsi = talib.RSI(close, 3)
streak = close * 0
for i in range(1, len(close)):
    if close.pct_change().iloc[i] != 0 and streak.iloc[i-1] / close.pct_change().iloc[i] <= 0:
        streak.iloc[i] = 0
    else:
        streak.iloc[i] = streak.iloc[i-1]
    if close.iloc[i] > close.iloc[i-1]:
        streak.iloc[i] = streak.iloc[i] + 1
    elif close.iloc[i] < close.iloc[i-1]:
        streak.iloc[i] = streak.iloc[i] - 1
rsi_streak = talib.RSI(streak, 2)

period = 100
daily_return = close.pct_change()
counts = [None] * (period + 1)
for i in range(period + 1, len(daily_return)):
    previous_values = daily_return.iloc[i-period:i]
    current_value = daily_return.iloc[i]
    count = (previous_values < current_value).sum()
    counts.append(count)

counts = pd.Series(counts, index=daily_return.index)
percent_rank = counts / period * 100

crsi = ((rsi + rsi_streak + percent_rank) / 3).to_frame(name="crsi")

crsi["close"] = close
crsi = crsi.iloc[:, [1, 0]]
crsi.to_csv("spy_crsi.csv", index_label="date", header=True)


not all related projects from admin show up in the frontend

e.g. for Xenon, the related projects that are visible in the admin interface are:

eMetabolomics
ABCMuse
Distributed AMUSE
Enabling Dynamic Services
eSalsa
Mapping the Via Appia in 3D
Visualizing Uncertainty and Perspective Plus
Visualizing Uncertainty and Perspectives

but the frontend only shows:

ABC-MUSE
Mapping the Via Appia in 3D
Visualizing Uncertainty and Perspectives

additional problem seems to be that the corporate website seems to show a maximum of 100 projects, which probably affects harvesting of data by the scraper.

admin interface saves associated projects under key usedInProjects (or is it outputOfProject?), while the frontend uses corporateProjects.
Should be resolved by completing data model cleanup (#36) and associated data migration.

In the new data model, we have one list of projects https://github.com/research-software-directory/backend/blob/677d919d733b953bffa33c386c1b0fcbd75505ec/schemas/software.json#L505-L516, so I'm calling this solved.


Add missing usages of $applyNodeReplacement

Generally you don't need to add $applyNodeReplacement to your subclasses unless you plan to expose them as a library, which I think is probably rare in userland. I would say let's not put this in every creator on the playground for people to just copy and paste everywhere. The problem this is solving is allowing customization of core node behavior without changing the core library itself. The concept is not necessarily useful or applicable in places like TweetNode, where we don't even expose the node.

@acywatson Fair point. I've just added it in to the exported nodes now.


(Test Fail) Cleanup your project with Modules

Describe your problem and how to reproduce it:
To pass the test   - text: Modules present     testString: getUserInput => $.get(getUserInput('url')+ '/_api/server.js') .then(data => { assert.match(data, /require.*("|').\/routes.js("|')/gi, 'You should have required your new files'); assert.match(data, /mongo.connect[^]*routes/gi, 'Your new modules should be called after your connection to the database'); }, xhr => { throw new Error(xhr.statusText); })
The require statement must include the '.js' file extension.
Add a Link to the page with the problem:
https://learn.freecodecamp.org/information-security-and-quality-assurance/advanced-node-and-express/clean-up-your-project-with-modules/
To pass this test your require statement must be
const routes=require('./routes.js'); instead of const routes=require('./routes'); which is also valid.

Thanks @tamerMarzouk, I've verified this and it should definitely accept both.


Error while convertir large byte ascii text

This is what I get:
echo "%b00000000010111110000000100000000000000000000000000000000000000000000000000000000000000000000000000000000000000010000000000000000000000" | binmake
terminate called after throwing an instance of 'std::out_of_range'
what():  stoull
Aborted (core dumped)

Hi @pdelteil
This is a large binary number (about 16 bytes) while the higher number type managed is 64 bits, that is 8 bytes.
So this is a misuse of binmake. If you want to represent a so big number of bytes in binary representation you might use separated bytes like :
echo "binary 00000000 01011111 000000010 00000000 00000000 00000000...." | ./binmake

(or in the opposite order depending on endianness)

Note that you didn't provide ASCII text but bits (binary digits)


Add code quality linting checks via ruff through pre-commit

Description
This PR adds a few code quality linting checks via ruff to help us develop the almanack Python package and related. These checks are performed through the existing pre-commit workflows related to the repository. They're also meant to perform checks gradually, meaning new code is checked but we haven't retroactively changed any other code to meet these standards. That said, some minor changes to existing code are applied to help pass the initial settings.
Through these changes we will use pyflakes, pylint, mccabe, and ruff-specific rules to check code.
Thanks for any feedback you may have!
Closes #56
What is the nature of your change?

[ ] Content additions or updates (adds or updates content)
[ ] Bug fix (fixes an issue).
[x] Enhancement (adds functionality).
[ ] Breaking change (these changes would cause existing functionality to not work as expected).

Checklist
Please ensure that all boxes are checked before indicating that this pull request is ready for review.

[x] I have read the CONTRIBUTING.md guidelines.
[x] My code follows the style guidelines of this project.
[x] I have performed a self-review of my own contributions.
[x] I have commented my content, particularly in hard-to-understand areas.
[ ] I have made corresponding changes to related documentation (outside of book content).
[x] My changes generate no new warnings.
[x] New and existing tests pass locally with my changes.
[ ] I have added tests that prove my additions are effective or that my feature works.
[x] I have deleted all non-relevant text in this pull request template.

Thanks @gwaybio ! Merging this in.


date showing in post list without any post error?

hey, i was just modifying my website and somehow there is this unnecessary date occured in my recent posts list and archive list? how can i remove it, i just couldn't figure out how it is appeared in first place, i was just using the template very smoothly.

sorry, it was my bad, i realized that i've created a file without front matter.


Implement join operator

https://github.com/Reactive-Extensions/RxJS/blob/master/doc/api/core/operators/join.md

@trxcllnt I can try to implement this one if you're not doing it already.

@luisgabriel go for it!

I'm going to close this for now. Given that with pipeable operators it's so easy for users to implement their own operators, and there's been very limited interest in implementing this particular operator.

Well, we did have #2194... if we can update that to the new repo structure, we can add it I suppose. :thinking: ... reopening

Hi @trxcllnt. As the issue is very old and nobody asked for it I kindly suggest to close it.
Please let me know if this also your opinion.


How to resolve »expected simple binding, found nested binding«-error

I get the error »expected simple binding, found nested binding SomeMacroVariable« on usage of an external macro, but cargo build compiles just fine. However, if the same macro is not in an external crate but just in a module, this error does not occur. How do I resolve this issue?

If it works with cargo, then it's a bug in rust-analyzer's macro expansion code. Can you provide the macro?


calendar.yml has no effect on day length

Describe the bug
Spigot with Minecraft 1.20.6
Latest AdvancedSeasons.
ProtocolLib dev [#689] May 6, 2024, 5:02 PM
Using calendar.yml to adjust time length has no effect whatsoever.
How to reproduce
Install Spigot 1.20.6 and dev version of protocolLib that runs on 1.20.6
Install AdvancedSeasons.

time:
# In Vanilla: entire day in normal minecraft is 20 minutes
spring:
# Length of day time, in real world minutes
dayLength: 40
nightLength: 40
summer:
dayLength: 60
nightLength: 20
fall:
dayLength: 40
nightLength: 40
winter:
dayLength: 28
nightLength: 52

# Seasons Progression
progression:
# Should season progression be paused? Set to true to pause
paused: false

calendar:
# How many days should one season last
seasonDays: 2
# How many days should it take to transition between seasons?
transitionDays: 1

This config results in 100% normal 20 minute day length.
Screenshots / Videos
No response
Server Log
No response

This is not a bug, it is common behavior. The custom time function is only for changing the length of the night or day without exceeding 20 minutes.


refactor and eupsify repo

These changes enable this package to be setup using eups.   I've refactored the parsing code, adding some validation of the input commands, and added unit tests.

OK.  This all looks good.  I still have some questions on some of the issues above but I can ask you about them on slack.  I'll go ahead an merge.


Move eslintrc/stylelintrc to non-deprecated extensions

Extensionless config files for these have been deprecated a long time ago, rename them.

Note that both .yaml and .yml extensions are valid but I am a proponent of .yaml even thought other files in the root currently use .yml.

CI failure is unrelated.

:rocket:


Feature #3417 - Implement tuiDropdownDirectionChange & tuiHintDirectionChange (New branch with clean git history)

Continuation PR for #9645 with clean git history
Close #3417

I am grateful for your patience & guidance throughout the process. It was a great experience to collaborate with you.


Does not start in Ubuntu

Installing the current version from the PPA results in a build which will not start:
pkg_resources.DistributionNotFound: PySide
The reason is that the python-pyside package does not correctly register PySide as installed. A temporary workaround is to modify the file /usr/lib/python2.7/dist-packages/yubioath_desktop-2.2.1.egg-info/requires.txt removing the PySide line from it.

I'm getting the same issue in LinuxMint 17.2 Xfce x64.

There's a new build in the PPA which should resolve this issue.

just made a fresh install using the ppa on ubuntu 16.04 and it doesn't work.
$ yubioath
Traceback (most recent call last):
  File "/usr/local/bin/yubioath", line 5, in <module>
    from pkg_resources import load_entry_point
  File "/usr/lib/python2.7/dist-packages/pkg_resources/__init__.py", line 3141, in <module>
    @_call_aside
  File "/usr/lib/python2.7/dist-packages/pkg_resources/__init__.py", line 3127, in _call_aside
    f(*args, **kwargs)
  File "/usr/lib/python2.7/dist-packages/pkg_resources/__init__.py", line 3154, in _initialize_master_working_set
    working_set = WorkingSet._build_master()
  File "/usr/lib/python2.7/dist-packages/pkg_resources/__init__.py", line 640, in _build_master
    ws.require(__requires__)
  File "/usr/lib/python2.7/dist-packages/pkg_resources/__init__.py", line 941, in require
    needed = self.resolve(parse_requirements(requirements))
  File "/usr/lib/python2.7/dist-packages/pkg_resources/__init__.py", line 828, in resolve
    raise DistributionNotFound(req, requirers)
pkg_resources.DistributionNotFound: The 'PySide' distribution was not found and is required by yubioath-desktop

The PPA doesn't install to /usr/local/, so it doesn't look like you're actually running the version from the PPA. Perhaps you have a lingering installation that's interfering?

Probably lingering but after removing averything that I could find that was related and reinstalling from ppa.
$ sudo apt-get install yubioath-desktop
Reading package lists... Done
Building dependency tree
Reading state information... Done
The following additional packages will be installed:
  libpyside1.2 libshiboken1.2v5 libykpers-1-1 libyubikey0 python-crypto python-pyscard python-pyside.qtcore
  python-pyside.qtgui python-pyside.qtnetwork
Suggested packages:
  python-crypto-dbg python-crypto-doc python-wxgtk3.0
The following NEW packages will be installed:
  libpyside1.2 libshiboken1.2v5 libykpers-1-1 libyubikey0 python-crypto python-pyscard python-pyside.qtcore
  python-pyside.qtgui python-pyside.qtnetwork yubioath-desktop
0 upgraded, 10 newly installed, 0 to remove and 74 not upgraded.
Need to get 0 B/3 309 kB of archives.
After this operation, 19,2 MB of additional disk space will be used.
Do you want to continue? [Y/n] y
Selecting previously unselected package libshiboken1.2v5:amd64.
(Reading database ... 180932 files and directories currently installed.)
Preparing to unpack .../libshiboken1.2v5_1.2.2-2build2_amd64.deb ...
Unpacking libshiboken1.2v5:amd64 (1.2.2-2build2) ...
Selecting previously unselected package libpyside1.2:amd64.
Preparing to unpack .../libpyside1.2_1.2.2-2build2_amd64.deb ...
Unpacking libpyside1.2:amd64 (1.2.2-2build2) ...
Selecting previously unselected package libyubikey0.
Preparing to unpack .../libyubikey0_1.13-1_amd64.deb ...
Unpacking libyubikey0 (1.13-1) ...
Selecting previously unselected package python-crypto.
Preparing to unpack .../python-crypto_2.6.1-6build1_amd64.deb ...
Unpacking python-crypto (2.6.1-6build1) ...
Selecting previously unselected package python-pyscard.
Preparing to unpack .../python-pyscard_1.9.2-2_amd64.deb ...
Unpacking python-pyscard (1.9.2-2) ...
Selecting previously unselected package python-pyside.qtcore.
Preparing to unpack .../python-pyside.qtcore_1.2.2-2build2_amd64.deb ...
Unpacking python-pyside.qtcore (1.2.2-2build2) ...
Selecting previously unselected package python-pyside.qtgui.
Preparing to unpack .../python-pyside.qtgui_1.2.2-2build2_amd64.deb ...
Unpacking python-pyside.qtgui (1.2.2-2build2) ...
Selecting previously unselected package python-pyside.qtnetwork.
Preparing to unpack .../python-pyside.qtnetwork_1.2.2-2build2_amd64.deb ...
Unpacking python-pyside.qtnetwork (1.2.2-2build2) ...
Selecting previously unselected package libykpers-1-1:amd64.
Preparing to unpack .../libykpers-1-1_1.17.2-1_amd64.deb ...
Unpacking libykpers-1-1:amd64 (1.17.2-1) ...
Selecting previously unselected package yubioath-desktop.
Preparing to unpack .../yubioath-desktop_2.3.0-1_all.deb ...
Unpacking yubioath-desktop (2.3.0-1) ...
Processing triggers for libc-bin (2.23-0ubuntu2) ...
Processing triggers for hicolor-icon-theme (0.15-0ubuntu1) ...
Processing triggers for man-db (2.7.5-1) ...
Processing triggers for bamfdaemon (0.5.3~bzr0+16.04.20160322.1-0ubuntu1) ...
Rebuilding /usr/share/applications/bamf-2.index...
Processing triggers for gnome-menus (3.13.3-6ubuntu3) ...
Processing triggers for desktop-file-utils (0.22-1ubuntu4) ...
Processing triggers for mime-support (3.59ubuntu1) ...
Setting up libshiboken1.2v5:amd64 (1.2.2-2build2) ...
Setting up libpyside1.2:amd64 (1.2.2-2build2) ...
Setting up libyubikey0 (1.13-1) ...
Setting up python-crypto (2.6.1-6build1) ...
Setting up python-pyscard (1.9.2-2) ...
Setting up python-pyside.qtcore (1.2.2-2build2) ...
Setting up python-pyside.qtgui (1.2.2-2build2) ...
Setting up python-pyside.qtnetwork (1.2.2-2build2) ...
Setting up libykpers-1-1:amd64 (1.17.2-1) ...
Setting up yubioath-desktop (2.3.0-1) ...
Processing triggers for libc-bin (2.23-0ubuntu2) ...

$ yubioath
Traceback (most recent call last):
  File "/usr/bin/yubioath", line 5, in <module>
    from pkg_resources import load_entry_point
  File "/usr/lib/python2.7/dist-packages/pkg_resources/__init__.py", line 3141, in <module>
    @_call_aside
  File "/usr/lib/python2.7/dist-packages/pkg_resources/__init__.py", line 3127, in _call_aside
    f(*args, **kwargs)
  File "/usr/lib/python2.7/dist-packages/pkg_resources/__init__.py", line 3154, in _initialize_master_working_set
    working_set = WorkingSet._build_master()
  File "/usr/lib/python2.7/dist-packages/pkg_resources/__init__.py", line 640, in _build_master
    ws.require(__requires__)
  File "/usr/lib/python2.7/dist-packages/pkg_resources/__init__.py", line 941, in require
    needed = self.resolve(parse_requirements(requirements))
  File "/usr/lib/python2.7/dist-packages/pkg_resources/__init__.py", line 828, in resolve
    raise DistributionNotFound(req, requirers)
pkg_resources.DistributionNotFound: The 'PySide' distribution was not found and is required by yubioath-desktop

sorry, it just needed even more cleaning... It's not an issue. Forget all about it.


Bot is bloat due to unnecessary dependencies

Escuse my dumby question, but do we need all these dependencies to run the bot? 😅
appdirs==1.4.4
APScheduler==3.6.3
beautifulsoup4==4.9.3
black==20.8b1
certifi==2020.11.8
cffi==1.14.4
chardet==3.0.4
click==7.1.2
cryptography==3.2.1
decorator==4.4.2
idna==2.10
linkpreview==0.1.11
mypy-extensions==0.4.3
pathspec==0.8.1
pycparser==2.20
python-decouple==3.3
python-telegram-bot==13.0
pytz==2020.4
regex==2020.11.13
requests==2.25.0
six==1.15.0
soupsieve==2.0.1
toml==0.10.2
tornado==6.1
typed-ast==1.4.1
typing-extensions==<IP_ADDRESS>
tzlocal==2.1
urllib3==1.26.2

It seems pip is installing dependencies to run a webserver (tornado), but we are not depending on it (although that python-telegram-bot depends on it). We should only rely on really needed dependencies, dev dependencies that facilitate our workflow and the telegram api wrapper itself(python-telegram-bot).

This is normal behaviour, as found here, for example. @RicardoSilveira23 can get into detail but since he installed on an empty venv, the dependencies should be fine :)

This is normal behaviour, as found here, for example. @RicardoSilveira23 can get into detail but since he installed on an empty venv, the dependencies should be fine :)

Oh okay, didn't know about that! My bloat trigger is now off :)


Messages are sometimes duplicated

This results in a React Native warning:
Warning: flattenChildren(...): Encountered two children with the same key...

I did several fixes regarding messages.
Can not reproduce anymore.


meta indexing

@mayooear how do you enable not sure how to call it, meta indexing? when chatbot understands which document is which and can compare between them, the one you made in the video about tsla 2020 vs 2021 or smth like that
thank you!

I'm having a similar problem. I'm ingesting several files and when I ask a question that involves data from several (or all) files then the chat bot is not capable of giving a good answer.

Warning I still don't fully understand how langchain works, so I may say something that is not correct.

Let me know if I'm mistaken, but this is what I think it's happening: first we use the given question to find the relevant document pieces in the vector store, then we use that as context to send the question to the OpenAI api. If the question is too vague, or if it involves lot's of documents, then the given context is not enough for the chatbot to respond.
My case involves several documents with information about some government subsidies. If I ask the chatbot to list all the available subsidies then it just gives me a couple of them or tells me that the given context is not enough.
I think that the 2020 vs 2021 comparison works fine because the answer it is part of the input PDF document:


Don't work if Debug server host is setted: websocket: connection error", "Failed to connect to localhost/<IP_ADDRESS>:7007

 Issue by linonetwo
Saturday Dec 17, 2016 at 07:06 GMT
Originally opened as https://github.com/storybooks/react-native-storybook/issues/116

I use wifi to sent bundle, in Dev settings, I set Debug server host to <IP_ADDRESS>:8081, and bundle was sent. But socket seems still try to connecting <IP_ADDRESS>:7007.
I think socket should read Dev setting, and try to connect <IP_ADDRESS>:7007 if I have set it.
Seems running "storybook start -h <IP_ADDRESS> -p 7007" can't help.

 Comment by linonetwo
Saturday Dec 17, 2016 at 07:20 GMT

Ok, seems using:
const StorybookUI = getStorybookUI({port: 7007, host: '<IP_ADDRESS>'});

can do this.


Reduce amount of Java code by eliminating duplicate if-then statements

Java code was so large that it did not compile.  This is because a lot of the code was duplicated.  Solution was to keep track of objects used to generate code and only generate the code once.  Only template "pluginfactory.java.tpl" was changed.

@pdumais , need your review on this

Looks good to me


Invalid tab title in Flutter Web on iOS

There is a problem with the page title in Flutter Web.
after setting the title parameter:
...
  Widget build(BuildContext context) {
    return MaterialApp(
      title: 'My Title',
      theme: ThemeData(
...

The custom title is displayed correctly in the desktop version of the site:

But in mobile browsers, instead of the title, a string with the value "flutter" is displayed.
I tried to find the 'flutter' string in the compiled js code and replace it with another value:

Problem solved, but I don't think it is a good solution:

Examples:

Correct mobile title:
http://hhhhtyu.000webhostapp.com/test_title_2/

Invalid mobile title:
http://hhhhtyu.000webhostapp.com/test_title/

I also noticed that in the second example, /#/ is inserted at the end of the url.
Help me to understand

Hello @syfulin ,
Could you please post the output of flutter doctor -v
In Navigator 1.0, flutter creates a single page application and uses # to navigate between different pages
Thank you!

@sidrao2006

@sidrao2006
Let me summarize my problem:
This is a standard project - a counter.
When you try to open it using a link like this:
http://hhhhtyu.000webhostapp.com/test_title/#/
Title displays correctly in Chrome Desktop and Chrome Mobile
When you try to open it using a link like this:
http://hhhhtyu.000webhostapp.com/test_title
Title displays correctly only Chrome Desktop.
In Chrome Mobile instead of the title, the string 'flutter' is displayed:

Hey @syfulin , for me both the links show test_title

hI @syfulin
Testing on iOS and Android, results are different from following

Placed another application at the root of the site. The problem is the same:
http://hhhhtyu.000webhostapp.com/ title="flutter"
http://hhhhtyu.000webhostapp.com/#/ title="Flutter Demo"

Android
Opening http://hhhhtyu.000webhostapp.com/ on Chrome on Android adds #/ to this link
This opens as it is  http://hhhhtyu.000webhostapp.com/#/

iOS
Opening http://hhhhtyu.000webhostapp.com/ on Chrome on IOS, it doesn't add  #/
This opens as it is  http://hhhhtyu.000webhostapp.com/#/

Are you experiencing this same behavior? The problem seems to rely on iOS since the same behavior as Android is on Desktop as well

@TahaTesser
Thanks for the tests.
I only tested on ios and windows.
I consider this problem to be critical, as the string value "flutter" can be confusing to users. I will think about how I can fix this problem from Flutter side. And I will write about it here.

Duplicate of https://github.com/flutter/flutter/issues/53568
/cc @goderbauer , same issue we discussed


WA: ffmpeg upstream change increase more buffer about transcode

upstream commit
https://github.com/intel-media-ci/ffmpeg/commit/e0da916b8f5b079a4865eef7f64863f50785463d

@xhaihao @uartie @FocusLuo


library not found for -lRCTGeolocation

Bug

Environment info

React native info output:
 System:
    OS: macOS 10.14.3
    CPU: (4) x64 Intel(R) Core(TM) i5-6267U CPU @ 2.90GHz
    Memory: 376.07 MB / 8.00 GB
    Shell: 2.6.0 - /usr/local/bin/fish
  Binaries:
    Node: 10.16.0 - ~/.config/fnm/bin/node
    Yarn: 1.13.0 - /usr/local/bin/yarn
    npm: 6.9.0 - ~/.config/fnm/bin/npm
    Watchman: 4.7.0 - /usr/local/bin/watchman
  SDKs:
    iOS SDK:
      Platforms: iOS 12.4, macOS 10.14, tvOS 12.4, watchOS 5.3
    Android SDK:
      API Levels: 16, 21, 23, 25, 26, 27, 28
      Build Tools: 23.0.1, 25.0.0, 25.0.1, 25.0.2, 25.0.3, 26.0.0, 26.0.1, 26.0.2, 26.0.3, 27.0.0, 27.0.1, 27.0.2, 27.0.3, 28.0.3
      System Images: a...ult | ARM EABI v7a, a...-21 | Intel x86 Atom, a... | Intel x86 Atom_64
  IDEs:
    Xcode: 10.3/10G8 - /usr/bin/xcodebuild
  npmPackages:
    react: 16.8.6 => 16.8.6
    react-native: 0.60.0 => 0.60.0
  npmGlobalPackages:
    create-react-native-app: 2.0.2
    react-native-cli: 2.0.1
    react-native-git-upgrade: 0.2.7

Library version: "0.25.0"
after I was trying to upgrade RN to version 0.60 I've followed the document, but I was getting this error:
Library not found for -lRCTGeolocation
podfile
# Uncomment the next line to define a global platform for your project
platform :ios, '9.0'
require_relative '../node_modules/@react-native-community/cli-platform-ios/native_modules'

target 'DNA' do
  # Pods for DNA
  pod 'React', :path => '../node_modules/react-native/'
  pod 'React-Core', :path => '../node_modules/react-native/React'
  pod 'React-DevSupport', :path => '../node_modules/react-native/React'
  pod 'React-fishhook', :path => '../node_modules/react-native/Libraries/fishhook'
  pod 'React-RCTActionSheet', :path => '../node_modules/react-native/Libraries/ActionSheetIOS'
  pod 'React-RCTAnimation', :path => '../node_modules/react-native/Libraries/NativeAnimation'
  pod 'React-RCTBlob', :path => '../node_modules/react-native/Libraries/Blob'
  pod 'React-RCTImage', :path => '../node_modules/react-native/Libraries/Image'
  pod 'React-RCTLinking', :path => '../node_modules/react-native/Libraries/LinkingIOS'
  pod 'React-RCTNetwork', :path => '../node_modules/react-native/Libraries/Network'
  pod 'React-RCTSettings', :path => '../node_modules/react-native/Libraries/Settings'
  pod 'React-RCTText', :path => '../node_modules/react-native/Libraries/Text'
  pod 'React-RCTVibration', :path => '../node_modules/react-native/Libraries/Vibration'
  pod 'React-RCTWebSocket', :path => '../node_modules/react-native/Libraries/WebSocket'

  pod 'React-cxxreact', :path => '../node_modules/react-native/ReactCommon/cxxreact'
  pod 'React-jsi', :path => '../node_modules/react-native/ReactCommon/jsi'
  pod 'React-jsiexecutor', :path => '../node_modules/react-native/ReactCommon/jsiexecutor'
  pod 'React-jsinspector', :path => '../node_modules/react-native/ReactCommon/jsinspector'
  pod 'yoga', :path => '../node_modules/react-native/ReactCommon/yoga'

  pod 'DoubleConversion', :podspec => '../node_modules/react-native/third-party-podspecs/DoubleConversion.podspec'
  pod 'glog', :podspec => '../node_modules/react-native/third-party-podspecs/glog.podspec'
  pod 'Folly', :podspec => '../node_modules/react-native/third-party-podspecs/Folly.podspec'

  target 'DNATests' do
    inherit! :search_paths
    # Pods for testing
  end

end

 target 'DNA-tvOS' do
  # Pods for DNA-tvOS

   target 'DNA-tvOSTests' do
    inherit! :search_paths
    # Pods for testing
  end

 end

Since RN 0.60, the Geolocation module was migrated out of RN Core.
Try installing from https://github.com/react-native-community/react-native-geolocation

@christopherdro I just installed the react-native-geolocation and nothing, doesn't work, stills shows the same message. Any thoughts?


Make IndexSet::intersection() work with stdlib's hashset

There's no reason it shouldn't work with the stdlib hashset. Perhaps we can add a second method for this?

It could work with lots of container types -- anything that has a contains method. But really, intersection amounts to just set.iter().filter(|item| other.contains(item)).

We don't inadvertently want to be responsible for a traitification of set collections, I guess? It's an awkward question.


[theming] Add theme-specific color customizations

Now there are only 2 settings to customize current theme:
"workbench.colorCustomizations": {}
"editor.tokenColorCustomizations": {}
The downside: if you have a habit to customize each one of your themes, then you have to manually maintain the list of all of your tweaks.
New Syntax:
"workbench.colorCustomizations[One Dark Pro]": {}
"editor.tokenColorCustomizations[One Dark Pro]": {}

Color priority:
2: Setting with theme name ("workbench.colorCustomizations[One Dark Pro]": {})
       ↓ ↓ ↓ ↓ ↓ ↓ ↓ ↓ ↓ ↓ ↓ ↓ ↓ ↓ ↓ ↓ ↓ ↓ ↓
1: Setting without theme name (workbench.colorCustomizations: {})
       ↓ ↓ ↓ ↓ ↓ ↓ ↓ ↓ ↓ ↓ ↓ ↓ ↓ ↓ ↓ ↓ ↓ ↓ ↓
0: Active theme (One Dark Pro)
Use cases:

Using different themes for night and day
Using several favorite themes (in no particular order)
Trying out new theme, tweaking it, but in the end returning to the previous one

Note that you can easily create a new theme out of your customized theme with the `Generate Color Theme from User Settings' command.

As far as I understand, that will leave you without theme updates:

Added support for a new language
Fixed a bug
Used new styling properties

+1

This is pretty cool 👍

IKR? Should this be included in the release notes?

I added an entry in the release notes and updated the docs.
Thanks again @usernamehw !


Root CA renewal

Hi folks,
These instructions advise us to hardcode a certificate thumbprint into the profile (see step 8).
Can you please advise the recommended steps when the root CA cert renews?
All the remote devices loose access if this happens automatically.
Clearly this is a problem as once a remote device looses connectivity they cannot get a fix pushed out to them without returning to base.
Thanks

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: e7453068-95eb-2a42-fd0b-553ae593adb0
Version Independent ID: b39b2cb7-25b1-2af3-4954-dbcc04c836e9
Content: Configure Windows 10 Client Always On VPN Connections
Content Source: WindowsServerDocs/remote/remote-access/vpn/always-on-vpn/deploy/vpn-deploy-client-vpn-connections.md
Product: windows-server-threshold
Technology: networking-ras
GitHub Login: @shortpatti
Microsoft Alias: pashort

Thanks for your dedication to our documentation. If we have been unable to review your issue in a timely manner, we sincerely apologize for the delayed response. We have captured the informtion you have provided for review. We are closing this issue for now, but if you feel that it's still a concern, please respond and let us know. If you determine another possible update to our documentation, please don't hesitate to reach out again. #please-close


V8: Form Block > Edit Form is Displaying Duplicates

When adding items to the form block, the edit form tab seems to be having issues displaying correct information.  Even so the form displays correctly, but this editing screen is displaying duplicates:

There is only 1 actually question added to this form...   Deleting them does not take effect, as they come back once you go into edit the form after exiting.

For now I would just use the legacy forms as this error does not apply to them. ( I also had this error)

So replace the form block with the 5.7 one?

@ob7 In v8 there's included 'Legacy Form'.

Oh look at that, down at the very bottom as if it was a custom block. Thanks.
One question, whats the point of redoing the form block?  What new functionality is planned for the new form block?

Is this the wrong place to ask questions?

Github is mainly for developers that want to help develop/debug the next version.
Right now the main branch "develop" is version 8.0. And if you want to contribute with something that would make it better or if you find a bug. Then this is the place!
If you just want a discussion about concrete5 as a user. You should ask your questions on the forum on concrete5.org - http://www.concrete5.org/community/forums/


failed to write response body because the response reader was dropped

When doing a lot of very similar requests, occasionally i will get logs like this:
[WARN] failed to write response body because the response reader was dropped

I know these are just warnings, but I'm currently debugging a tricky problem and I'd rather be sure about what is happening. Why are these warnings happening, and is there any way to prevent them?
Here's the code in question:
    let response = isahc::http::Request::put(format!("{}/links/_bulk", opt.elastic_url))
        .header(CONTENT_TYPE, "application/json")
        .authentication(Authentication::basic())
        .credentials(Credentials::new("elastic", opt.elastic_pass.clone()))
        .body(body.to_string())?
        .send()?;
    if !response.status().is_success() {
        let mut buffer = String::new();
        response.into_body().read_to_string(&mut buffer)?;
        error!("Got non-success status code, response was\n {}", buffer);
    }

Is this perhaps due to into_body consuming the response?

Interesting, this should probably not be happening for code like the above. This warning is emitted if you drop the reponse Body without first reading from it fully, such as in code like this:
let response = isahc::get("http://some/url");
let _body = response.into_body();
// We just dropped _body without reading from it

This is a warning because it is a perfectly valid thing to do if you want to, but for most HTTP versions this means the connection must be closed and can't be reused for connection pooling, resulting in sub-optimal throughput.
However, if the only thing using the HTTP client is your code example, then read_to_string should be consuming the response body fully, so I would not expect to see this warning unless something else is going on.
What's the value returned by isahc::version(), just so I know how Isahc is built and configured?

What's the value returned by isahc::version(), just so I know how Isahc is built and configured?

This is the output from my development machine. By my understanding it should be the same on my production server (thanks to Cargo.lock and the static-curl feature), but if you want I can retrieve the isahc::version from my server, too.

From my server:
isahc/0.9.12 (features:default,encoding_rs,http2,mime,static_curl,text_decoding) libcurl/7.73.0
-DEV OpenSSL/1.1.1 zlib/1.2.11 nghttp2/1.33.90

I should note that these are extremely rare - i make about 35k requests, and last time i got 4 warnings, probably when the server just fails for whatever reason. I'll try and print more diagnostics when it happens.

Thanks for all the helpful information! I'll be digging deeper into this issue soon to see what I can find out.

Lemme add even more information.
I don't think that this is an issue with my code, but for full clarity here's the entire scope as of now:
pub fn bulk_request(opt: &Opt, body: BulkBody) -> Result<()> {
    let response = isahc::http::Request::put(format!("{}/links/_bulk", opt.elastic_url))
        .header(CONTENT_TYPE, "application/json")
        .authentication(Authentication::basic())
        .credentials(Credentials::new("elastic", opt.elastic_pass.clone()))
        .body(body.to_string())?
        .send()?;
    if !response.status().is_success() {
        dbg!(&response.status().as_str());
        dbg!(&response.headers());
        let mut buffer = String::new();
        response.into_body().read_to_string(&mut buffer)?;
        error!("Got non-success status code, response was\n {}", buffer);
    }
    Ok(())
}

The reason i believe this are the dbg!'s I added: I get no output from them even when i get this warning - so it doesn't have anything to do with the if statement, and after the if there's nothing that would use the body.
I will update to 0.9.14 and see if i can reproduce it there.

Thanks for the additional info. I'm hoping to dig deeper into this problem soon. My hunch is that there is a race condition of some sort somewhere with low probability of occurring causing the response stream to be dropped early.

OK, so I did some digging just to verify, but I'm not seeing any bugs like this in Isahc. However, I did notice something about your code after reading it again -- you only consume the response body if the response code is not a 2xx. This is probably the source of the warning, as you are not consuming the response body in the success case.
Now the warning is probably rare for you because the response body in this case may be very small, in which case there's a good chance that it will have been read already as part of the same read operation that read the response headers, so therefore no problem. But this can vary a lot since the amount returned in a read can vary depending on hardware state, network conditions, and just other things the kernel is working on. I bet in the rare circumstance where the body is not fully read before send() returns to your code is when you are getting this warning. I bet if the server returned a larger response body (>16 KiB, our default read buffer size) you would get this warning for every request.
The way to avoid this is to make sure you always consume the response body. For example,
pub fn bulk_request(opt: &Opt, body: BulkBody) -> Result<()> {
    let mut response = isahc::http::Request::put(format!("{}/links/_bulk", opt.elastic_url))
        .header(CONTENT_TYPE, "application/json")
        .authentication(Authentication::basic())
        .credentials(Credentials::new("elastic", opt.elastic_pass.clone()))
        .body(body.to_string())?
        .send()?;
    if !response.status().is_success() {
        dbg!(&response.status().as_str());
        dbg!(&response.headers());
        let mut buffer = String::new();
        response.into_body().read_to_string(&mut buffer)?;
        error!("Got non-success status code, response was\n {}", buffer);
    } else {
        // Always consume response body to allow connection reuse.
        response.copy_into(std::io::sink())?;
    }
    Ok(())
}

On my end, there's a couple things that we should do to make this a better experience for you:

Improve the warning message to explain what is happening better, and include a suggestion in how to fix it.
Call out this behavior more clearly in the documentation.
Add methods as described in #257 to make it simple to do this consuming.

I considered having the response body do this on drop automatically, but decided against it as doing I/O for an unknown amount of time (e.g. very large bodies) inside a drop handler is not a wise move and can be an unexpected performance gotcha.

OK, so I did some digging just to verify, but I'm not seeing any bugs like this in Isahc. However, I did notice something about your code after reading it again -- you only consume the response body if the response code is not a 2xx. This is probably the source of the warning, as you are not consuming the response body in the success case.
Now the warning is probably rare for you because the response body in this case may be very small, in which case there's a good chance that it will have been read already as part of the same read operation that read the response headers, so therefore no problem. But this can vary a lot since the amount returned in a read can vary depending on hardware state, network conditions, and just other things the kernel is working on. I bet in the rare circumstance where the body is not fully read before send() returns to your code is when you are getting this warning. I bet if the server returned a larger response body (>16 KiB, our default read buffer size) you would get this warning for every request.

I see, I did not expect response.status() to also (partially) read the body. I thought it would just be dropped without the response ever being turned into a body, which somehow wouldn't trigger the warning...? Now that you explained it, that doesn't make a lot of sense :sweat_smile: .

The way to avoid this is to make sure you always consume the response body. For example,
pub fn bulk_request(opt: &Opt, body: BulkBody) -> Result<()> {
    let mut response = isahc::http::Request::put(format!("{}/links/_bulk", opt.elastic_url))
        .header(CONTENT_TYPE, "application/json")
        .authentication(Authentication::basic())
        .credentials(Credentials::new("elastic", opt.elastic_pass.clone()))
        .body(body.to_string())?
        .send()?;
    if !response.status().is_success() {
        dbg!(&response.status().as_str());
        dbg!(&response.headers());
        let mut buffer = String::new();
        response.into_body().read_to_string(&mut buffer)?;
        error!("Got non-success status code, response was\n {}", buffer);
    } else {
        // Always consume response body to allow connection reuse.
        response.copy_into(std::io::sink())?;
    }
    Ok(())
}

I'll see if I can perform another test, but it sounds correct.

On my end, there's a couple things that we should do to make this a better experience for you:
* Improve the warning message to explain what is happening better, and include a suggestion in how to fix it.

* Call out this behavior more clearly in the documentation.

* Add methods as described in #257 to make it simple to do this consuming.

More docs is always a thumbs up for me.

I considered having the response body do this on drop automatically, but decided against it as doing I/O for an unknown amount of time (e.g. very large bodies) inside a drop handler is not a wise move and can be an unexpected performance gotcha.

I don't have a development environment at hand, so this is entirely off the top of my head. Assuming I receive a very large response body, would it be beneficial to allow some form of explicit drop instead, without triggering the warning? I'm thinking something like a response.close_connection(). I certainly wouldn't want to read several hundred MB just to get rid of a log.

I see, I did not expect response.status() to also (partially) read the body

send() does not return until at least the response headers have been read. status() does not do any reading, it just returns the status code already read.
When HTTP/1.x is being used, there's no way to read just the response headers because it is of an unknown size. You just fill the buffer and then look for the end of the header (\r\n\r\n). But more may have been returned to you in the same read() call. Indeed, if the entire response headers and body fit inside one TCP packet, then there's a very good chance the whole thing will be read off the socket in a single read().

Assuming I receive a very large response body, would it be beneficial to allow something akin to an explicit drop instead, without triggering the warning?

Yeah, that sounds pretty reasonable to include. Perhaps abort() would be a good method name. Though be aware that both abort() and consume() (if provided) have trade-offs. With HTTP/1.x, there's no facility in the protocol to tell the server, "Hey, I know I asked for this big file and you're doing a great job sending it to me, but could you stop?" Your only option is to ungracefully close the TCP connection.
In applications doing file downloads, this is probably what you want if you click "Cancel", but in applications making many small API calls, this is probably not what you want. If the response body is just a few MB, then it is probably more efficient in the long run to simply read the response and throw it away rather than take a hit on connection reuse by closing the connection. Establishing new connections can be pretty expensive, relatively speaking.
As I write this, I am warming to the idea of providing both consume() and abort(), with appropriate docs on each about their tradeoffs.
Note that if you know you are using HTTP/2 or newer, then abort() would probably be better since HTTP/2 does include throttle controls as part of the protocol, which we already use proactively. (Meaning, if a buffer of response body is sitting there waiting to be read for a while and you do not immediately read it, we already ask the server to stop sending more data until we know you want to continue.) Aborting one transfer does not prevent you from reusing an HTTP/2 connection.

Also while digging, I did just now find an issue (sort of a race condition) where we are emitting that warning inconsistently right now. Everything else works correctly, but the condition under which we emit the warning is a bit inconsistent. 😅 It should be emitted more often than it is right now...

Thank you for your elaborate responses, I'm really enjoying this sort of in-depth knowledge :)

In applications doing file downloads, this is probably what you want if you click "Cancel", but in applications making many small API calls, this is probably not what you want. If the response body is just a few MB, then it is probably more efficient in the long run to simply read the response and throw it away rather than take a hit on connection reuse by closing the connection. Establishing new connections can be pretty expensive, relatively speaking.

Just for the record, this efficiency hit would only apply when querying the same server again, right? Querying different servers would require a new connection anyways.

Also while digging, I did just now find an issue (sort of a race condition) where we are emitting that warning inconsistently right now. Everything else works correctly, but the condition under which we emit the warning is a bit inconsistent. 😅 It should be emitted more often than it is right now...

Glad I helped reveal that ^^

Just for the record, this efficiency hit would only apply when querying the same server again, right? Querying different servers would require a new connection anyways.

Yep, that's right, this is only a problem when making multiple requests to the same server. By default we cache everything for a short time since Isahc doesn't know if you are going to make more requests to the same server or not, though this can be changed with custom client configuration.

Thinking about this further, I am having second thoughts as to whether this is the appropriate direction to go. While it isn't usually the most optimal way of performing requests, there is nothing inherently wrong with aborting connections early if you don't care about the response body, and connection pooling is never guaranteed to be possible regardless. I suppose it is a trade-off between convenience and explicitness:

Explicit: Have the caller choose whether they want to consume and discard the response, or abort it. Gives a good degree of control, but is more complicated to understand.
Convenient: Same behavior as today, except just remove the warning altogether (make it an INFO or DEBUG). Simpler for everyone to grasp, but some users may be unintentionally leaving some performance on the table. Most HTTP clients appear to go with this approach.

Maybe changing the warning into an INFO or DEBUG message is a sufficient solution, as most users may not care about the difference and trade-offs of approach and would rather have the HTTP client just handle it. Users already looking to tune the performance of their code might be more interested in these distinctions and may decide to consume the response stream instead.

I decided to change this log to an INFO level message instead and to make the message itself much more understandable (as well as fix the message being reported inconsistently). This change will be in the next release.


Links not showing up in news feed tiles

Links not showing up in news feed tiles, e.g. https://www.metaculus.com/notebooks/27592/

Ready for testing on dev and prod

Thanks!

Sorry @ncarazon I forgot how this works. LGTM. Close when shipped.


How do I scroll the bottom bar icons horizontally?

Right now I have 8 icons in the bottom bar. The icons have reduced in size as the bottom bar tries to fix everything in the screen width.. Is there a way to allow the bottom bar to go beyond the screen and allow for horizontal scrolling?

I would highly recommend not doing so since that goes against the guidelines for a bottom navigation (https://material.google.com/components/bottom-navigation.html)

Usage:
Three to five top-level destinations

Don't.
Avoid scrollable content in the bottom navigation bar.

Don't.
Avoid using more than five destinations in bottom navigation as tap targets will be situated too close to one another.

@manrock007 sure, @pollax is right. You should not be using more than 5 top-level destinatinos in the bottom bar according to Google's guidelines. You can still use tabs or a Navigation drawer

With this library it isn't possible, and I'm not intending to support it, sorry.


ui: sync camera frame with model frame

reopen https://github.com/commaai/openpilot/pull/33774 (closed by bot)

Let's just wait for raylib on this. It's been tricky in the past.


KurtZimmermann.HDCleanerX32 version 2.043

[ ] Have you signed the Contributor License Agreement?
[ ] Have you checked that there aren't other open pull requests for the same manifest update/change?
[ ] Have you validated your manifest locally with winget validate --manifest <path>?
[ ] Have you tested your manifest locally with winget install --manifest <path>?
[ ] Does your manifest conform to the 1.4 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.

Microsoft Reviewers: Open in CodeFlow

@microsoft-github-policy-service agree [company="KurtZimmermann"]

@microsoft-github-policy-service agree

Similar PR (#94905) for the x64-version. Merge these into one manifest?


Trim RFC1123 non-compliant chars from pod name

Resolves: https://issues.redhat.com/browse/OSPRH-8692

recheck
failed during openshift_setup, step Wait for openshift-marketplace pods to be running

recheck

recheck

recheck
tempest post failure (HTTP 502)

recheck

/cherry-pick 18.0.0-proposed


add the github link to contribute section!

add the github link to contribute section!
https://github.com/OpenFloodAI

Hi, I'd love to do this.

sure @wale-bant

Great. I'm on it.

Done. Please review my PR #16 .


Update tools to use peer key string

Closes #35
Also included some other updates to fix gradle build issues.

We're going to hold off on merging this at this time to keep the tools support for Ditto SDK 4.5.x

This can now be merged (pending merge conflict resolution)


Update API to v1.10.0

It keeps Smapp working well with new changes in SmesherService.PostSetupProviders.
Better to review code per commit, since there are some generated code updates.

"looks" good but yes more checks are needed.


success_url never gets hit in LIVE mode, works fine in SANDBOX mode

Hey @mehdibo , the library works fine in the sandbox mode but the issue is that when i switch to live mode it never hits the success_url after payment. after the 3DS verification and the payment is done, the payment page gets automatically closed without hitting the success_url.

Hello
Please provide a code to reproduce the issue

so i have used firebase cloud function here
exports.generateYouCanPayPaymentUrl = functions.https.onRequest(
  async (req, res) => {
    const ip = req.ip
    cors(req, res, async () => {
      const { userId, amount, order_id, selectedPlan } = req.body;
      try {
      const ycp = YcpFactory.ycp({
        privateKey: 'myprivatekey',
        isSandboxMode: false,
      });
        const tokenRes = await ycp.tokenizePayment(
          {
            amount: amount * 100,
            currency: CurrencyCode.MAD,
            order_id,
            customer_ip: ip,
            success_url: `my firebase cloud function`,
            error_url: `myfirebase cloud function`,
          },
          Lang.AR
        );
        res.json({ paymentUrl:tokenRes.paymentUrl });
      } catch (error) {
        console.error(error);
        res.status(500).json({ error: "Internal Server Error" });
      }
    });
  }
);

Did you configure the URLs in your Youcanpay dashboard?

No i didn't, i did not see any option such as.

Ohk i found those options, is that the issue?
my urls are dynamic https://mycloutfunctionurl.cloudfunctions.net/youCanPayTransactionDone?userId=${userId}&selectedPlan=${selectedPlan} how should i enter these urls in the dashboard then.

i tried putting urls in the youcanpay dashboard, even that didn't worked.

I can't really give you support on the payment gateway, only the library.
You will have to contact their support to pin point the issue.
If you have a bug I can reproduce I will gladly push a fix for it

@vaibhav834 i think you need to use the Metadata in tokenizePayment to save the userId and the selectedPlan becuse the Metadata will be returned via the webhook


Error while packing project

As mentioned in #359 , my goal is to edit the Mustang asset (edit car's parameters) and because the u4pak tool is not compatible with UE4, I have to repack the whole project (generating a new pak file). Unfortunately, I am getting this error:
ERROR: Command failed (Result:5):
~/UnrealEngine_4.18/Engine/Binaries/DotNET/UnrealBuildTool.exe CarlaUE4 Linux Development -Project=~/carla/Unreal/CarlaUE4/CarlaUE4.uproject  ~/carla/Unreal/CarlaUE4/CarlaUE4.uproject -NoUBTMakefiles  -remoteini="~/carla/Unreal/CarlaUE4" -skipdeploy -noxge -NoHotReload -ignorejunk.
AutomationTool exiting with ExitCode=5 (5)
[2018.04.18-15.57.49:470][353]UATHelper: Packaging (Linux): RunUAT ERROR: AutomationTool was unable to run successfully.
[2018.04.18-15.57.49:470][353]PackagingResults: Error: Unknown Error

System info: Ubuntu 16.04.4 LTS x64 / Linux 4.13.0-36-generic
Is there something I am missing?
Thanks.

I have managed to completely rebuild the project and construct the .pak file by firstly cleaning the project.
Right now, I am facing another problem when running this custom release [1] (from LinuxNoEditor folder: ./CarlaUE4.sh /Game/Maps/Town01 -carla-server -windowed -ResX=640 -ResY=480).
There is an assertion error in sensor.py when the client reads the data:  assert len(raw_data) == 4 * width * height.
It appears that the width and height from data (where data = self._stream_client.read()) are 1, 0 respectively. There are no problems when running the official carla release (0.8.1). Is there a setting I am omitting?
[1] custom = modified some car parameters in the Mustang asset
Thanks!

I think I have found one source of the problem. When data is read from the stream_client: data = self._stream_client.read(), it is packed differently in my custom build vs in the original release (i.e.: my custom build (server) adds extra bytes after the sensor_id)
Thus, if I change the data from the stream client () to be data = data[0:4] + data[12:], then the parsing works as expected and I am able to see image data.
Any ideas for where those extra 8 bytes might come from?

Hello @alexandru-dinu we had a similar problem recently, take a look to the issue #318 ,it only happened with Windows and Direct3D, and when the source stride is different than the destiny stride, it was fixed, have you tried using Vulkan as renderer or ,are you changing anything related to the screen captures?

Hello, @juaxix.
I am not using Vulkan, nor I am changing anything related to the screen captures.
Basically what I did was to rebuild the whole Carla (clean + build) with that altered asset (Mustang car) and redo all the steps for a server-control communication. Anything else is unchanged.

@alexandru-dinu I was suggesting you to try to use Vulkan hehe, but ok, no worries, what I need to analyze the error, is the commands you are using for server (simulator) and python client. And some logs should be very useful too

@juaxix - Here are the logs for the client and the server [1].
The client was started as: python manual_control.py
The server was started as: ./CarlaUE4.sh -carla-server -windowed -ResX=640 -ResY=480
The exact setup works without problem in Carla release 0.8.1 so there's certainly a problem with my custom build.
[1] https://gist.github.com/alexandru-dinu/2619012a4b28ec5c22499db3abb17445
Thank you for your help!

Hello!
Any updates on this issue?

Hello @alexandru-dinu , we can't currently support modifications of the delivered paks, so I would recommend you to make your own version of CARLA compiling it from scratch using the guide , and of course, try with vulkan because it uses another path to generate the images from the screen captures, you just have to add the parameter "-vulkan" to the end of the command line when you run the simulator (server)

make your own version of CARLA compiling it from scratch using the guide
I have already done this, as mentioned in the beginning of this issue. My build and release 0.8.2 both have the same assertion error problem.

Oh ,sorry, I misunderstood.
I would like to know more details about your hardware, can you post info of your gpu please?

[1] custom = modified some car parameters in the Mustang asset

are you sure that those modifications in the car are working?, if the car is not spawning it will lead to errors...did you run the game with no server mode to see if the car is ok?

GPU info: nVidia GTX 1050 Ti mobile
Update: I have managed to get CARLA release 0.8.2 to work, it was a misunderstanding. It works well now.
Regarding my custom build, I'll perform a clean-up and rebuild the whole thing with my modifications.
I think this can be closed. If any other problems occur, I'll keep you updated.
Thank you very much for your help!

OS Linux Ubuntu 16.04 - 64bit
Unreal 4.18.3
Carla 0.8.4
I made a change in map and now want to package project for shipping mode,
how should I do that?
by rebuilding all the project? will my changes remove when executing this line or not?
$ UE4_ROOT=~/UnrealEngine_4.18 ./Rebuild.sh?
using package menue in Unreal throw this error:

Error: RunUAT.bat ERROR: AutomationTool was unable to run successfully. Cannot build.
Tnx in advance

For anyone has similar issues:
I did following things:

un-installed clang-5.0, make sure I am using clang-3.9 only.
Followed https://carla.readthedocs.io/en/stable/how_to_build_on_linux/
Remove UnrealEngine_4.18 folder and git clone it again, re-compiled it again.
Remove carla-0.8.4 branch folder and git clone it again, re-compiled it again.

Just doing step 1 (downgrading clang from 6.0 to 3.9) already solved my problem. I also have the "Full rebuild" option selected on Unreal so it makes a clean build all the time. You can change that on Project Settings > Project - Packaging. Thank you!


fix: Move copying translation files before npm run build in Docker

SUMMARY
Since #29791 the webpack.config.js file now requires that the translation files are present when running the build. This change simply moves the copy of the translation files before the npm run build step.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Beforehand, an error printed was printed, although it doesn't seem to stop the build, that can cause confusion as to whether something is wrong with the build:
#19 [superset-node  7/12] RUN npm run build
#19 0.291
#19 0.291 ><EMAIL_ADDRESS>build
#19 0.291 > cross-env NODE_OPTIONS=--max_old_space_size=8192 NODE_ENV=production BABEL_ENV="${BABEL_ENV:=production}" webpack --color --mode production
#19 0.291
#19 1.087 Error reading the directory: Error: ENOENT: no such file or directory, scandir '/app/superset/translations'
#19 1.087     at Object.readdirSync (node:fs:1507:26)
#19 1.087     at getAvailableTranslationCodes (/app/superset-frontend/webpack.config.js:52:22)
#19 1.087     at Object.<anonymous> (/app/superset-frontend/webpack.config.js:168:20)
#19 1.087     at Module._compile (node:internal/modules/cjs/loader:1469:14)
#19 1.087     at Module._extensions..js (node:internal/modules/cjs/loader:1548:10)
#19 1.087     at Module.load (node:internal/modules/cjs/loader:1288:32)
#19 1.087     at Module._load (node:internal/modules/cjs/loader:1104:12)
#19 1.087     at Module.require (node:internal/modules/cjs/loader:1311:19)
#19 1.087     at require (node:internal/modules/helpers:179:18)
#19 1.087     at WebpackCLI.tryRequireThenImport (/app/superset-frontend/node_modules/webpack-cli/lib/webpack-cli.js:204:22) {
#19 1.087   errno: -2,
#19 1.087   code: 'ENOENT',
#19 1.087   syscall: 'scandir',
#19 1.087   path: '/app/superset/translations'
#19 1.087 }

TESTING INSTRUCTIONS
Build the superset-node stage and ensure it completes without errors relating to the translations files:
docker buildx build --progress plain --target superset-node --build-arg PY_VER=3.10-slim-bookworm --no-cache .

ADDITIONAL INFORMATION

[ ] Has associated issue:
[ ] Required feature flags:
[ ] Changes UI
[ ] Includes DB Migration (follow approval process in SIP-59)

[ ] Migration is atomic, supports rollback & is backwards-compatible
[ ] Confirm DB migration upgrade and downgrade tested
[ ] Runtime estimates and downtime expectations provided

[ ] Introduces new feature or API
[ ] Removes existing feature or API

Oh this will impact the docker-cache hit-rate a bit. If anything in the translation folder changes we won't be able to reuse the frontend build cache, which is probably ok and required anyways.
I have to admit I didn't know if the translation was more of a build-time thing or a run-time thing. Given the new logic in the webpack config it appears it's required at build time. Hoping it doesn't impact perf when using en, please confirm if you can.
We may want to introduce a new ARG build_translations=false to speed up build and reduce image size for the large majority on a en-only deploy.

Thanks for the review!

I have to admit I didn't know if the translation was more of a build-time thing or a run-time thing. Given the new logic in the webpack config it appears it's required at build time. Hoping it doesn't impact perf when using en, please confirm if you can.
We may want to introduce a new ARG build_translations=false to speed up build and reduce image size for the large majority on a en-only deploy.

I think this would cause more data to be loaded when the moment-timezone library is lazy loaded by the time zone selector. Before my changes the docker image would only keep the en timezone data but now it would include everything for the locales defined in the translations directory - I'm not sure on the exact size of this but it is only loaded when the timezone selector is made visible on the alerts/reports modal.
Is the preference still to add the build flag and then also remove the translations from the backend and have the standard image be en only?

Took the time to understand the new optimization in webpack.config.js, it's a build time optimization specific to moment's (time processing library) i18n. I looks in the folder for language subfolders and do it based on that. Presumalby moment's support many more language than Superset does (about 20) so that trims the excess.
Note that we have a LANGUAGES config that is used by the admin to set which languages are made available in their environment, ideally that optimization would be in-line with that list instead of looking at subfolders in the repo. It can be a  bit tricky to share config between the backend and frontend, currently the main mechanism for this is the backend sends a payload "bootstrap_data" encoded in the html of the page sent to start the "single-page-app", but that doesn't work for build time. We would need to have something like languages.json that both the backend's config and the frontend webpack.confic.js could read from.
Overall unclear how much this matters (could be good to know the bundle size without any locale, with the 20 we support, and with all locales). I vote to keep things simple and simply adding a setting ARG build_translations=false (or similar) and allow to skip some of the complexity and weight for those who use en only.

I resolved the merge conflict I created in the first place...

I seem to have a couple of failed tests and I can't quite see why.

The docs build has detected some broken links - maybe these are really expired?
One of the matrix values for the E2E tests has failed with a crashed Chrome but I can't see why what I have done here to have broken that?

Thanks!

The docs build has detected some broken links - maybe these are really expired?

rebase and should be fine

random fail in matrix

unfortunately we have some flakiness in these tests, should re-run after you rebase+push

I think I've hit a bad link in the release notes that wasn't picked up when the change was merged to master?
The Docs Testing/Link Checking workflow only runs when changes are made to docs/** but then the link checker itself also checks things in the RELEASING directory so it wasn't picked up.
Shall I fix it here or do you have a policy that that should be fixed in a separate PR?

I'm not sure why @github-actions E2E / cypress-matrix (0, chrome) (pull_request)  check is failing, at first I thought it was test flakiness, but I manually restarted a few times and seems to consistently fail. Restarting it once again.
For the docs, I think the failed check is non-blocking for merging, and there's new commits in master making those just warning, so rebasing once again might help here [sorry about the confusion!].

Restarting it once again.
All is passing!

For the docs, I think the failed check is non-blocking for merging
Please re-review/unblock the PR if you think it's OK to go, so either of us can merge it after giving @martyngigg a little extra time for touchups :)

Oh, thinking prior to this PR the effective default is BUILD_TRANSACTION=true so this is kind of a breaking change for those who build/ship translations. We could either set the default to true here or add an entry in UPDATING.md ("if your environment requires translations, you'll want to set the docker build arg BUILD_TRANSACTION=true").
If we decide to switch the default to true, I would set the default in docker-compose.* to false as most development environments don't need translations.
Given the semi-unknown/uneven state of translations coverage and quality, I vote for setting the default to false (as it is now), but that means this PR needs to add an entry in UPDATING.md as suggested above.

Thanks for merging this :)
Sorry for not responding to the above comment sooner but I didn't have time to look at this yesterday. As I didn't have time to add the entry in UPDATING.md shall I open a new PR for that?

shall I open a new PR for that?

Oh I forgot about my own comment, a new comment in UPDATING.md would be nice if you don't mind opening a one-liner

shall I open a new PR for that?

Oh I forgot about my own comment, a new comment in UPDATING.md would be nice if you don't mind opening a one-liner

No problem :)
Ignore the first closed PR above that I managed to open on my fork by accident! 🤦🏻


Issue with seed in tabular model

Hi,
I am facing issue setting seed value for tabular model on CPU. This is what I have tried.
def seed_everything(seed):
    random.seed(seed)
    os.environ['PYTHONHASHSEED'] = str(seed)
    np.random.seed(seed)
    torch.manual_seed(seed)
    torch.cuda.manual_seed(seed)
    torch.backends.cudnn.benchmark = False
    torch.backends.cudnn.deterministic = True
seed_everything(SEED)

Post doing above I still get different values for torch.seed()
Also, the results are different. I am not sure if I am missing out something basic :(
Thanks in advance.

AFAICT you are seeding everything already. You should post your problem on the forum with the code you are then using to gather your data and train your model, as there will be more people to help here.
Closing this as it's not a bug in the library from what I can see, please reopen if debugging discovers a reproducible bug in fastai,