return maximum output value

Package used (python/R/jvm/C++): python / R
Hi,
Thank you for this awesome work! I am working on a project and have utilized xgboost as my ML algorithm. Normally, we will want to go to the next step in using this to optimize some variables. I.e: Using regression, we can model the project and using linear programming to obtain some values in order to optimize the target variable.
However, using xgboost, we do not have an equation. Is there any method I can use to obtain the best possible variable values for the best (highest)  target variable? like optimization?
Regards
Germayne

Glad to hear that you found XGBoost to be useful.  There is active development for supporting linear boosting on the GPU.
As for the tree model, here's what you may want to try:

Gather all split thresholds used in all the trees. Let threshold[fid] represent the list of  distinct thresholds used for feature fid. You should be able to do this by dumping the model.

Sort each threshold[fid] in ascending order.

Pick values x[fid][0], x[fid][1], x[fid][2], ... so as to satisfy the inequalities

                       x[fid][0]   < threshold[fid][0]
threshold[fid][0]   <= x[fid][1]   < threshold[fid][1]
threshold[fid][1]   <= x[fid][2]   < threshold[fid][2]
...
threshold[fid][n-1] <= x[fid][n]   < threshold[fid][n]
threshold[fid][n]   <= x[fid][n+1]

An easy way to do this is to take the midpoint of each interval. Repeat this step for every threshold list threshold[fid].

Now iterate over the Cartesian product

{ x[0][i] : i = 0, 1, ... } x { x[1][i] : i = 0, 1, ... } x ... x { x[d-1][i] : i = 0, 1, ...}
(d = number of features)

and find the input that maximizes the output. This will consider n^d possibilities, where n is an upper bound on the number of threshold per feature.

And here is a short script to extract the list of all thresholds:
def combine_thresh_table(old, new):
  for k, v in new.items():
    if k not in old:
      old[k] = set()
    old[k] |= v
  return old

def get_thresh(tree):
  table = dict()
  if 'children' in tree:
    fid = tree['split']
    val = tree['split_condition']
    if fid not in table:
      table[fid] = set()
    table[fid].add(val)
    table = combine_thresh_table(table, get_thresh(tree['children'][0]))
    table = combine_thresh_table(table, get_thresh(tree['children'][1]))
  return table

def get_thresh_ensemble(ensemble):
  table = dict()
  for tree in ensemble:
    table = combine_thresh_table(table, get_thresh(tree))
  return table

def get_ensemble_json_dump(model_path):
  bst = xgboost.Booster()
  bst.load_model(model_path)
  tree_dump = []
  for dump in bst.get_dump(with_stats=True, dump_format='json'):
    tree_dump.append(json.loads(dump))
  return tree_dump

ensemble = get_ensemble_json_dump('my.model')
thresh_table = get_thresh_ensemble(ensemble)

Hi @hcho3
Thank you for giving such a fantastic answer. I do have a couple of queries to address. But let us talk about some issues:
I understood the concept and implemented the sample script with some minor changes. ( i added the ascending sort) I came to realized that there is a problem where the variable order is changed in the threshold variable
basically :

you can see that it changes the variable order. As such, at the step where x is generated followed by e to be passed into predict function, the result is not correct. What i did was to change the order prior to creating the model but this results in threshold, x and e to have another different order. It will be good if you can help me with it!

Hi @hcho3,
Thank you for providing this fantastic answer. I do have some more questions that i would love to clarify. From this, my understanding of xgb or tree algorithms in general is also much better !!
Some questions:

From my understanding, the way we create x and then e by using the split thresholds in the tree algorithm is because we want to create  spread of values such that it will satisfy all the possibility ( pass through all the possible path in the tree. )

Is this understanding correct? For example, if there is only a single tree where the split is at x = 500, we only want to create 2 values, one below 500 and one more than 500 to achieve the 2 possible path down this split. Doesnt matter if the values are
400 , 600 vs 100 , 700 since it will result in the same score down the tree.

@germayneng I found a couple issues with my script and updated it. The issues were:

The feature values were not in the correct order in the test matrix. I convert x into list of lists so that every vector emitted by itertools is of form [value for feature 0, value for feature 1, value for feature 2, ...].
Some features never appear in any split condition. For these features, simply assign np.nan.

@germayneng I just found this interesting paper: https://arxiv.org/pdf/1705.10883.pdf. In cases where brute-force iteration over the candidate space (the Cartesian product I mentioned above) is infeasible, you may be able to form a kind of mixed integer programming and solve it approximately.

@hcho3  Thank you for the fast reply.
May i get more clarification on

Some features never appear in any split condition. For these features, simply assign np.nan.

I did realized that on my end, there are some features that are not in threshold. So what i did was to manually add them:
# add missing variable
threshold['f8'] = [0.5]
threshold['f13'] = [0.5]

Concept wise, what is the reason these features are not in the threshold? They are also the same variables that are missing in feature_importance. These 2 variables are in fact part of  one-hot-encoding features. (they are dummy variables)

@germayneng Please refer to the revised script, which deals with the missing feature. Conceptually, each split is chosen in Greedy fashion to improve the global loss function. Intuitively, those features that help us best predict the target will be chosen in the splits. There is no guarantee at all for all features getting picked. In fact, if you have a high-dimensional data, say of 1000 features, and you fit a tree of only 50 splits, some features will be left out for sure.

@hcho3 this makes perfect sense! Thank you.
On the side note: the research paper linked is very interesting. However, i do have a question. When you mean forming a MIP to solve, do i utilize modules that solves MIP problems and apply it to the xgb model?

@germayneng The paper presents a formulation of a MIP for a tree ensemble. So yes, you will have to extract necessary information from xgb model, construct the MIP, and solve it using an optimization package.

The new discussions are now welcomed at https://discuss.xgboost.ai/


[stable/airflow] Cannot send cli commands to the scheduler

Describe the bug
I am trying to send cli commands to airflow. I try sending airflow list_dags to the running scheduler/web pod but it seems to either default to the git-sync sidecar or cannot find airflow in the path. Port forwarding the web host and sending commands through the REST api does work though. The base container is puckel/docker-airflow.
Version of Helm and Kubernetes:
Helm: 3.1.0
AKS 1.14.8
Which chart:
Stable/airflow 6.7.3
What happened:
kubectl exec -it airflow-scheduler-7c7f88bbcd-4pmkd -- airflow list_dags

Defaulting container name to git-sync.
Use 'kubectl describe pod/airflow-scheduler-7c7f88bbcd-4pmkd -n default' to see all of the containers in this pod.
OCI runtime exec failed: exec failed: container_linux.go:346: starting container process caused "exec: \"airflow\": executable file not found in $PATH": unknown
command terminated with exit code 126

What you expected to happen:
To be able to issue cli commands
How to reproduce it (as minimally and precisely as possible):
kubectl exec -it airflow-scheduler pod -- airflow list_dags
Anything else we need to know:
The base container is the puckel/docker-airflow. It was modified to add kubernetes and the recommended metric exporter for prometheus/grafana.

Figured it out. Needed to switch containers in the same pod because I was running the git-sync sidecar.
kubectl exec -it airflow-scheduler-7c7f88bbcd-4pmkd -c airflow-scheduler  -- airflow list_dags


Allow for Passing Custom Functions to Open/Close event listeners on popups

Describe the feature in detail (code, mocks, or screenshots encouraged)
The title pretty much describes the request.
I want to have make a hover popup that does not disappear when pressing shift. Currently it's not possible as the element has a mouseleave event listener telling the popup to be closed.
Example of what I want to achieve (the "window" is done by pressing Shift):
https://github.com/skeletonlabs/skeleton/assets/32039708/507c002e-d448-40bf-831c-7005b5c67211
Allowing to the user to pass their own open and close functions would allow for such additional functionality.
What type of pull request would this be?
Enhancement
Provide relevant links or additional information.
There was once a conversation about attempting to create this sort of hover-to-window functionality, but it ended up going nowhere.

I will note that the Pull Request is more of a proof of concept than an actual PR, don't merge my fumbling around in TS 😂

Saw the PR before this - see my comment there for my response

FYI, as we begin prepping for the new standalone popup package, we're consolidating all known issues for popups into this new thread:

https://github.com/skeletonlabs/skeleton/issues/1916

Your post will now be closed, but has been referenced in the post linked above. Please note that by doing this, your request is being folded into this larger effort. Please feel free to monitor the linked issue if you wish to track progress on this going forward.


WindowsAppearFaster Crashing?

@cursey where was it crashing for you?

Near northern tir moongate and when teleporting to tail moongate by the druid.

Can't seem to replicate this. I'll test it some more later.

It crashes me when moving towards moongates also.
It isn't unheard of either:
https://mabimods.net/index.php?topic=14837.msg245001#msg245001

Seems to crash me now, too.

I fixed it.


refactor: migrate protobuf to prost_reflect

Signed-off-by: tabVersion<EMAIL_ADDRESS>I hereby agree to the terms of the Singularity Data, Inc. Contributor License Agreement.
What's changed and what's your intention?
a new pb parser based on prost
Checklist

[x] I have written necessary rustdoc comments
[x] I have added necessary unit tests and integration tests
[x] All checks passed in ./risedev check (or alias, ./risedev c)

Documentation
A new protobuf parser
Types of user-facing changes

Connector (sources & sinks)

Release note
now, user need to compile a protobuf schema file and it's dependencies into one binary schema pb file.
protoc --include_imports -I /path/to/includes --descriptor_set_out=/path/to/output /path/to/proto

and then create a source using the output pb schema file:
create materialized source cs with (
    connector = 'kafka',
    topic = 'proto_bin_c',
    properties.bootstrap.server = '<IP_ADDRESS>:29092',
    scan.startup.mode = 'earliest',
    proto.message = 'test.User')
row format protobuf message 'test.User'
row schema location 'file://src/source/src/test_data/complex-schema';

Refer to a related PR or issue link (optional)
resolve #4456

LGTM please add e2e for the parser

I have modified the kafka.slt, so the new parser already pass the e2e test.

Oh great, seems we have reduced the amount of deps from 1k+ to 700


bug: No static compilation or failed to find dll on windows

Describe the bug

To Reproduce
Windows on cuda

Linking this to:

[ ] https://github.com/janhq/nitro/issues/256

only cudart64_12.dll and zlib.dll now is not able to add as static compilation. I will comback will another approach for cuda dependencies stuff later.


Add support for data texture for morph target

Store morph target data into texture to get more targets supported
(like what was done for bones)

I would like to contribute to this if possible.
How can I currently intercept and add to the vertex and fragment shader sources of a PBR material loaded with a GLTF asset prior to the compilation of the shader program?

Wrong fix id

@deltakosh Would you consider the following API?
API :
instance.instancedBuffers.morphTargets.targetName.influence

It will not use instance buffer but a texture array actually :)

It will not use instance buffer but a texture array actually :)

So something like?:
API :
instance.textureArrays.morphTargets.targetName.influence

So something like?:
API :
instance.textureArrays.morphTargets.targetName.influence

Actually there will be no API change. Instead of storing the targets into attributes, we will store them into texture arrays (same was as what we did for bones)
Influence values are stored into uniforms so what you are suggesting will not work unfortunately

Actually there will be no API change. Instead of storing the targets into attributes, we will store them into texture arrays (same was as what we did for bones)
Influence values are stored into uniforms so what you are suggesting will not work unfortunately

@Influence values are stored into uniforms so what you are suggesting will not work unfortunately
Are these influence value uniforms going to be data textures in order to accommodate for the per instance customized influence values?

@Influence values are stored into uniforms so what you are suggesting will not work unfortunately
Are these influence value uniforms going to be data textures in order to accommodate for the per instance customized influence values?

Not for first version. I mean, it is a different issue. Having influences as an attribute can be a different issue

Not for first version. I mean, it is a different issue. Having influences as an attribute can be a different issue


install nlohmann-json

Environment

OS: Window10 x64
Compiler: vs2019

To Reproduce
Steps to reproduce the behavior:

./vcpkg install nlohmann-json
See error:

_Downloading https://github.com/nlohmann/json/raw/v3.9.1/CMakeLists.txt... Failed. Status: 6;"Couldn't resolve host name"
CMake Error at scripts/cmake/vcpkg_download_distfile.cmake:181 (message):
  Failed to download file.
  If you use a proxy, please set the HTTPS_PROXY and HTTP_PROXY environment
  variables to "https://user:password@your-proxy-ip-address:port/".
  Otherwise, please submit an issue at https://github.com/Microsoft/vcpkg/issues

Call Stack (most recent call first):
ports/nlohmann-json/portfile.cmake:7 (vcpkg_download_distfile)
ports/nlohmann-json/portfile.cmake:16 (download_src)
scripts/ports.cmake:79 (include)_
Remark
https://github.com/nlohmann/json/raw/v3.9.1/CMakeLists.txt
This link is indeed not accessible

@aa9bb  ,Thanks for posting this issue,This issue duplicate to #14585


Fix typo in error message

Codecov Report

Merging #441 (52d8e78) into master (22243df) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #441   +/-   ##
=========================================
  Coverage     79.89%   79.89%
  Complexity     1069     1069
=========================================
  Files           136      136
  Lines          3208     3208
  Branches        430      430
=========================================
  Hits           2563     2563
  Misses          573      573
  Partials         72       72

Impacted Files
Coverage Δ

src/main/java/seedu/awe/commons/core/Messages.java
92.85% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 22243df...52d8e78. Read the comment docs.


Add Traditional Chinese localization

Picking up where @ethanhuang13 is left. Here's the full translation for Traditional Chinese.
cc @pofat

Thanks @ethanhuang13 and @itszero for getting this over the line!


link and content update

@Zoemeckbach please revert the image link back to the correct public link:
https://developers.cryptowerk.com/platform/image/portal/Cryptowerk.png


upload produces "mime", image is downloaded instead of shown in browser

We wanted to upload image file to the volume server. (2.27) We always get a wired mime result.
The browser will download the image (jpg) instead of showing it to the user.
{"size":77048,"eTag":"f9bf9cc0c401fec012e99c024a2ad336","mime":"multipart/form-data; boundary=------------------------a560cf4fbe000bd9"}
Can anybody help?

Hi @kw005 how you solved this?


Backup & Recovery options

[ ] For Tribe RGB backup is to be done for Seed Phrase and RGB assets

SelfCustody > On Chain
 Seed Phrase to be backup by the user outside the app.
RGB Assets will be backed by relay server by default.  At any moment user can download this file on his phone.
While recovery user can provide this RGB file if we do not find it on relay.
SelfCustody > On Chain & Lightning
No Backup
Supported
 Only Seed Phrase to be backup by the user outside the app.

[ ] 3.Supported Wallet

Task: Simplify the backup process for supported wallets.
Backup Option:
Seed Words Only: Ensure seed words are the only recovery method, focusing on simplicity and ease of use.
Recovery Options Tasks
1. Recovery Options for Self-Custody On-Chain Wallet
Task: Implement two recovery options for on-chain wallets:
Seed Option: Allow users to recover their wallet using their seed words.
RGB asset Backup Option: Provide recovery through stored asset backup on relay.
*2. Recovery Options for Self-Custody Lightning Wallet
Node Details Option: Include recovery through node details for users with node setups.
UI/UX Enhancements:
Display the recovery options with clear instructions and relevant tooltips.
3. Recovery Options for Supported Wallet
Task: Limit recovery for supported wallets to seed words only.
No node details are required for supported wallets.

Supported Wallet Recovery Process (error case )

Scenario:
If the supported node is not found from the relay, or no metadata/RGB file is available, prompt the user with two fallback options:
Upload a Zip File Manually: Allow the user to upload a previously saved zip file for recovery.
Create a New Wallet: Provide an option to create a new wallet if no backup is available.

https://us02web.zoom.us/rec/share/7HRkrivYTJdKOkYzaKIU94kyruO7dliSzPuClXAWMYTdyMSwpDpRaRMF6EFa8dYs.Rec-FOosgwpNZkIk
Passcode: FC#N7*VC

@Jddesigner0003 We are doing Backup part in 41

@Deveshshankar   Hey I was designed the backup options can you please first review from your side and share with me feedback after that will share with team for final preview
https://www.figma.com/design/e0RxSAiRCMt5Z48LJVNEXr/Tribe-RGB?node-id=4475-44912&t=0SyqMylwcCT0qgVU-1

@Deveshshankar @cakesoft-shashank   Please check the updated backup flow. The subtitle content is pending, and I will update it in the design once the team member sends it to me.
Figma: https://www.figma.com/design/e0RxSAiRCMt5Z48LJVNEXr/Tribe-RGB?node-id=4615-50042&t=Jl4PC3HnGo4lFrBD-1

https://www.figma.com/design/e0RxSAiRCMt5Z48LJVNEXr/Tribe-RGB?node-id=4475-44912&m=dev&t=2DNw3fzzWNwIsbYT-1 @cakesoft-shashank updated approved flow Backup and Recovery

Umbrella issue so closing


Option to send already selected URIs

Is there an option to send already selected Uris to the Mattise activity, so that those images are shown checked already?

no such feature right now .
what's the point of this feature ? the selected images are shown  checked already ,when click sure button ,those images will be selected once again .which might  not be a good idea .

Let me give you a use case for this feature,
I go to Matisse activity, select few images. Then, select sure.
Now, I might want to add more images to my selection.
It will be good idea to show the previously selected images already in the Matisse activity. That way, user will know which images he selected previously.

This library : https://github.com/ParkSangGwon/TedPicker
also allows you to send selected images uri.
Intent intent = new Intent(mActivity, ImagePickerActivity.class);
intent.putExtra(ImagePickerActivity.EXTRA_IMAGE_URIS, uris);

how to distinguish previous selected and new selected images when I press sure button ? any good idea ?

There won't be any differentiation.
It's just that, library should provide a parameter to already select few Uris. The only change in UI would be that, instead of zero items shown checked at first, it will be pre filled with the (optional) parameter passed.

This is a very cool feature!

Hey,
Did anyone find the solution? Need help!

So, is this going to be implemented anytime soon?


Provide a customisable hint when capturing an event

Summary
Would it be possible have a way to provide a Hint along with an Event in Hub
Motivation
I'm customising the errors I send to sentry by calling sentry.Hub.CaptureEvent with an event from sentry.Client.EventFromException. This works well apart from the fact that I lose the Hint that I would get if I called CaptureException making it harder to use other parts of the API like BeforeSend.
Unfortunately there doesn't seem to be a way to add an EventHint manually with the Hub API, that can only be done at the client level but if I call the client directly myself it looks like I will be breaking handling of lastEventID in the hub.
Would it be reasonable to add a version of CaptureEvent that took both an event and a hint to allow callers to have this flexibility without breaking other parts of the API?
Additional Context

What are you using lastEventID for? When using the default, async transport, CaptureException & Co. simply return the event id, so it's not a guarantee that the event was actually sent to Sentry, but rather, it was queued up in the transport.

I'm not actually using it but was worried that if it wasn't set I would be breaking some contract with the hub. Should I just get the client and the scope from the hub and call the client's CaptureEvent myself?

Yeah, nothing wrong about this approach.

Then I'll go with that for now, thanks!


Viewing Profiles in Deck Shows Wrong Posts

Summary

When you open a user in the dock, then open another user, the posts of the second user are all replaced with the posts of the first
Expected Behavior
show the posts of the second user

Actual Behavior

the posts of the first user stay
Steps to Reproduce

enter deck view tih transitions disabled
click one user
click a second user

Environment

Activity と Photos も該当していて直ってないようにも見える


test(NODE-5855): unskip transaction tests

Description
What is changing?

Unskip TXN tests now that we've updated the unified spec tests
Unskip TXN tests on LB
Move session clearing of connection after checkIn

Also resolves: NODE-5931
Is there new documentation needed for these changes?
What is the motivation for this change?

Testing TXN

Release Highlight

Double check the following

[ ] Ran npm run check:lint script
[ ] Self-review completed using the steps outlined here
[ ] PR title follows the correct format: type(NODE-xxxx)[!]: description

Example: feat(NODE-1234)!: rewriting everything in coffeescript

[ ] Changes are covered by tests
[ ] New TODOs have a related JIRA ticket

The serverless test failures in this PR are unrelated.


Add validations to User model

Required validations for the User model:

correct format for email
non empty username

#68


Only log transient resource unavailability in extra verbose output mode

This change the current output as follows:
On success with -v (old behaviour):
2016/11/25 15:43:01 Awaiting resource: mysql://user:pass@db:3306/db#tables
2016/11/25 15:43:01 Resource unavailable: dial tcp <IP_ADDRESS>:3306: getsockopt: connection refused
2016/11/25 15:43:02 Awaiting resource: mysql://user:pass@db:3306/db#tables
2016/11/25 15:43:02 Resource unavailable: dial tcp <IP_ADDRESS>:3306: getsockopt: connection refused
2016/11/25 15:43:02 Awaiting resource: mysql://user:pass@db:3306/db#tables
2016/11/25 15:43:02 Resource unavailable: dial tcp <IP_ADDRESS>:3306: getsockopt: connection refused
2016/11/25 15:43:04 Awaiting resource: mysql://user:pass@db:3306/db#tables
:
2016/11/25 15:43:04 All resources available

On success with -v:
2016/11/25 15:43:01 Awaiting resource: mysql://user:pass@db:3306/db#tables
2016/11/25 15:43:04 All resources available

On success with -vv:
2016/11/25 15:43:01 Awaiting resource: mysql://user:pass@db:3306/db#tables
2016/11/25 15:43:01 Resource unavailable: dial tcp <IP_ADDRESS>:3306: getsockopt: connection refused
2016/11/25 15:43:02 Resource unavailable: dial tcp <IP_ADDRESS>:3306: getsockopt: connection refused
2016/11/25 15:43:02 Resource unavailable: dial tcp <IP_ADDRESS>:3306: getsockopt: connection refused
:
2016/11/25 15:43:04 All resources available

On failure without -v (old behaviour):
2016/11/25 16:04:33 Resource unavailable: dial tcp: <IP_ADDRESS>:3306: getsockopt: connection
2016/11/25 16:04:33 Timeout exceeded

On failure without -v:
2016/11/25 16:04:33 Resource unavailable: dial tcp: <IP_ADDRESS>:3306: getsockopt: connection
2016/11/25 16:04:33 Timeout exceeded

On failure with -v:
2016/11/25 15:40:59 Awaiting resource: mysql://user:pass@db:3306/db#tables
2016/11/25 15:41:59 Resource unavailable: dial tcp: lookup db: no such host
2016/11/25 15:41:59 Timeout exceeded

On failure with -vv:
2016/11/25 15:46:21 Awaiting resource: mysql://user:pass@db:3306/db#tables
2016/11/25 15:46:21 Resource unavailable: dial tcp: lookup db: no such host
2016/11/25 15:46:21 Resource unavailable: dial tcp: lookup db: no such host
2016/11/25 15:46:21 Resource unavailable: dial tcp: lookup db: no such host
:
2016/11/25 15:47:21 Timeout exceeded

Closes #22.

Superseded by https://github.com/betalo-sweden/await/pull/24 as I accidentally didn't merge it to master but refactor branch.


Initial Support IPv6

We are adding L2 support for IPv6 for LeaderElection of static pods for control plane but not service type LoadBalancer.
This partially addresses #155 as a thin thread of IPv6 support.

@flawedmatrix @rosenhouse & myself

This... is ... excellent! 🤯😀

With the limited testing I can perform this seems as though it doesn't impact existing behaviours, so I'm going to merge it in.

I justed ran some e2e tests + the tests of the PR
/lgtm


Incorrect app name for Conditional Access exclusion

When using Conditional Access, the article states:
[...] Conditional Access policies to control access need to exclude the Universal Store Service APIs and Web Application, AppID 45a330b1-b1ec-4cc1-9161-9f03992aa49f, from their Conditional Access policies [...]
But there is no app called "Universal Store Service APIs and Web Application".
In the article that is linked, the AppId "45a330b1-b1ec-4cc1-9161-9f03992aa49" belongs to "Windows Store for Business".
However, there is an app with a similar name called  "Universal Store Native Client" with AppId "268761a2-03f3-40df-8a8b-c3db24145b6b".

Which one(s) do we need to exclude now?

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 6443e532-640d-81c0-8215-b711bd1977d4
Version Independent ID: fc504984-91d7-b586-04ec-4c751fb48998
Content: Windows subscription activation - Windows Deployment
Content Source: windows/deployment/windows-10-subscription-activation.md
Product: windows-client
Technology: itpro-fundamentals
GitHub Login: @frankroj
Microsoft Alias: frankroj

Thank you for the feedback @Wh00T and I apologize over the delay. After some research, we have determined that it could have either name and it just depends on the tenant. I have added both names to the instructions to provide clarity. It should be live either later today or tomorrow.


Ambience no longer plays in the lobby

Ambience does no longer play in the lobby
A check prevents ChangeAmbience from calling StartAmbience after the player entity is moved during lobby creation. Also removed unnecessary function call to EndAmbience.
fixes #11198
doesn't implement the second part of the issue ("Ideally we should have more ways of controlling ambient music like space wind too so we can have it per tile?") though.
Changelog

:cl: Sheppard

fix: Ambience no longer plays in the lobby.

You don't need to change anything that you've already done, but just so you know, I have a PR up where I'm working on audio formatting, so try to keep additional changes down so that it's easier to merge. #11238


Add docs to mention changes regarding modular upgrades

Issue #, if available:
Description of changes:
This PR adds docs to mention changes regarding modular upgrades, specifically the version skew support and the behavior that could happen when upgrading the workload cluster after upgrading the management cluster.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

/lgtm

/cherry-pick release-0.16


[Event Modification] Codeunit 87 "Blanket Sales Order to Order" – OnBeforeCreateSalesHeader - Add additional var parameter SalesOrderHeader

Describe the request
Could you add the global variable SalesOrderHeader as a var parameter to the existing event OnBeforeCreateSalesHeader because we want to customize the filling of the global record variable SalesOrderHeader.
On a side not: if in the current situation IsHandled would be set to True, the record variable SalesOrderHeader would not be assigned, which seems like a bug if this is not possible as in the subsequent code this global variable is used to created new Sales Order Lines.
local procedure CreateSalesHeader(SalesHeader: Record "Sales Header"; PrepmtPercent: Decimal) CreditLimitExceeded: Boolean
var
    StandardCodesMgt: Codeunit "Standard Codes Mgt.";
    IsHandled: Boolean;
begin
    IsHandled := false;

    // Old to be removed:
    // OnBeforeCreateSalesHeader(SalesHeader, PrepmtPercent, CreditLimitExceeded, IsHandled);

    // New as replacement:
    OnBeforeCreateSalesHeader(SalesHeader, PrepmtPercent, CreditLimitExceeded, IsHandled, SalesOrderHeader);

    if IsHandled then
        exit(CreditLimitExceeded);

Original Event:
[IntegrationEvent(false, false)]
local procedure OnBeforeCreateSalesHeader(var SalesHeader: Record "Sales Header"; PrepmtPercent: Decimal; var CreditLimitExceeded: Boolean; var IsHandled: Boolean)
begin
end;
Modified Event as replacement:
[IntegrationEvent(false, false)]
local procedure OnBeforeCreateSalesHeader(var SalesHeader: Record "Sales Header"; PrepmtPercent: Decimal; var CreditLimitExceeded: Boolean; var IsHandled: Boolean; var SalesOrderHeader: Record "Sales Header")
begin
end;
Additional context
For a customer with more than 1 blanket contract we want to have the possibility to create a Sales Order which consists of lines from different Blanket Orders (from the same customer). In that case the Sales Order Header must be created only once.
Internal work item: AB#543331

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.
Build ID: 22697.


cargo-show-asm: 0.2.42 -> 0.2.43

Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.
meta.description for cargo-show-asm is: Cargo subcommand showing the assembly, LLVM-IR and MIR generated for Rust code
meta.homepage for cargo-show-asm is: https://github.com/pacak/cargo-show-asm
meta.changelog for cargo-show-asm is: https://github.com/pacak/cargo-show-asm/blob/0.2.43/Changelog.md
Updates performed

Ran passthru.UpdateScript

To inspect upstream changes
Impact
Checks done

built on NixOS
The tests defined in passthru.tests, if any, passed
found 0.2.43 with grep in /nix/store/dazqn4f6z2qzz5hd22kmnp1akv385y92-cargo-show-asm-0.2.43
found 0.2.43 in filename of file in /nix/store/dazqn4f6z2qzz5hd22kmnp1akv385y92-cargo-show-asm-0.2.43

Rebuild report (if merged into master) (click to expand)

3 total rebuild path(s)

3 package rebuild(s)

First fifty rebuilds by attrpath

cargo-show-asm
irust

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/dazqn4f6z2qzz5hd22kmnp1akv385y92-cargo-show-asm-0.2.43 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A cargo-show-asm https://github.com/r-ryantm/nixpkgs/archive/82bd5667d425ec609eb6b9f0216d8add6bca9a84.tar.gz

Or:
nix build github:r-ryantm/nixpkgs/82bd5667d425ec609eb6b9f0216d8add6bca9a84#cargo-show-asm

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/dazqn4f6z2qzz5hd22kmnp1akv385y92-cargo-show-asm-0.2.43
ls -la /nix/store/dazqn4f6z2qzz5hd22kmnp1akv385y92-cargo-show-asm-0.2.43/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
nixpkgs-review result
Generated using nixpkgs-review.
Command: nixpkgs-review

x86_64-linux

:white_check_mark: 2 packages built:

cargo-show-asm
irust

Maintainer pings
cc @figsoda @oxalica @matthiasbeyer for testing.

[!TIP]
As a maintainer, if your package is located under pkgs/by-name/*, you can comment @NixOS/nixpkgs-merge-bot merge to automatically merge this update using the nixpkgs-merge-bot.

Add a :+1: reaction to pull requests you find important.

@ofborg build cargo-show-asm cargo-show-asm.passthru.tests


Bug/consolidated bug fixes 201026

This PR implements the following tickets:
195339 - Sign out option not available on iOS
193596 - Descriptive text in settings is incorrect
195455 - Version info in settings page
196261 - Badge count on springboard icon does not auto-refresh
196512 - Favourited conversations create dot icon on conversations tab
This branch utilises the new LingoTests target introduced in PR #6 to specify unit tests for changes specific to the Lingo ACT Health project. Unit tests for 195339 and 196512 are included in this PR.
The branch is based upon act-master.
This branch will build on Xcode 12 / iOS 14.
Pull Request Checklist

[x] I read the contributing guide
[x] UI change has been tested on both light and dark themes, in portrait and landscape orientations and on iPhone and iPad simulators
-Noting there is no change currently in the display behaviour between those two settings as per requirement.
[x] Pull request is based upon act-master from the Pegacorn repo.
[x] All new and existing unit tests pass successfully in this branch.

Note 193596 should be 195396


Gnosis Safe based Fractal Node - first steps

We'd like to build the first steps towards a Gnosis Safe based Fractal node (as outlined in https://www.notion.so/hulking-cosmos-3e8/Gnosis-Based-Fractal-DAO-Nodes-a865c68b3dcb4095bdc8ae8167aab624).
This first step is a contract that can deploy a new Gnosis Safe (representing a Fractal DOA), and attach a module to it, in a single transaction.
This will then allow the front end to begin speccing out working with Gnosis Safes in the front end UI.

[ ] A contract with the ability to deploy a new Gnosis Safe and attach a module in a single transaction. This would be something similar to createDAO with CreateDAOParams.

Closing this, we'll create new issues during planning


fix(layer-selector): switch to plain object for basemap

Before this change, I was getting the following error message in WFRC:
Accessor#set Assigning an instance of 'esri.Basemap' which is not a subclass of 'esri.Basemap'

Which is strange but ¯_(ツ)_/¯

I think that this is the issue: https://github.com/agrc/kitchen-sink/issues/127


About reproduction of evaluation

Good work, the details on evaluation are lack, when using
bash ./evaluation/batch_eval.sh 1 0 0
to do evaluation, the affinity calculation would produce errors by ourselves. We'd like to ask if convenient to release some information on evaluation.

We have also been trying to work on the evaluation part recently, and we found that the env_adt.yml file specifies some package versions but is not complete, for example, the version of rdkit is not given. And we noticed that the env_adt.yml file specifies python=2.7.18, which should be because autodock only supports python 2.7, but there is no calrmsd function in python2.7 . We would also like to get more information about the evaluation section.

Hi, thanks for your interest in our work. The file env_adt.yml only defines the environment for docking with qvina2. As you can see in line 135 in evaluation/docking.py, the code will execute commands that activate the adt environment to run qvina2. For evaluation, you do not need to explicitly change to the adt environment to run evaluation scripts.
Besides, to make sure adt environment is installed successfully, you can first activate the environment in a terminal and
manually execute the comments defined in line 135. For example, type qvina2 in the terminal in the adt environment to see whether it prints meaningful information. If the adt environment is successfully installed, you can just run the evaluation scripts in your normal environment (not the adt environment).

Thanks for your replies, they are very helpful. All scripts in around line 135 in docking.py could be okay, except qvina2. After we have created the env adt, the qvina2 command could not be found. qvina2 seems not in env_adt.yml. So we'd like to ask if qvina2 is installed by some other way and please provide some help if convenient.

Hi, maybe you need to download and install qvina2 separately. Refer to the qvina2 website or conda-forge website, and check by typing  qvina2 (or qvina, depending on the version) in the terminal.


chore: Remove unused imports

This is a regeneration of all APIs, basically - like #9003, but regenerated locally.

(Self-merging as this is all generated.)


Give Users Access to Legal Text in Explanations Without Requiring Use of Defeasibility?

Right now, the only way the user gets access to the links to the source material is if the "according to" system is used in the interface. If the user has no intention of overriding anything, it seems unnecessary to force them to use the "according to" and the "holds" blocks in order to get access to the source material. Might want to see if there is a way we can design it where you can get access to the source rules without using the defeasibility blocks.

Resolved in 1.5.0-alpha


Missing redirects (Slash vs. non-slash)

On the live site, extensionless pages (e.g: https://www.airlessco.com/emea/pl/products/accessories/revtipspraytips ) redirect to having a slash on the end (e.g: https://www.airlessco.com/emea/pl/products/accessories/revtipspraytips/).
Franklin has a mixed experience, where some pages only work without the slash (https://main--airlessco--hlxsites.hlx.page/na/en/products/mp455) and some only work with it (https://main--airlessco--hlxsites.hlx.page/na/en/products/)

Are these handled at the CDN? Let me know if I can help...

This is a good point - the reason for it is the URLs with trailing slash are auto-loaded to the index file in the specified folder.
The ones without a trailing slash have existing pages. There's three options:

Ignore it and/or try to add redirects - this may be hard to achieve in a way that doesn't affect content.
Move every page into its own folder so that they're all "index" files - then every page ends in a trailing slash.
Move the landing pages to not be index type pages, so that they resolve without a trailing slash.

Customer has opted for option 2. So we'll start moving the content around accordingly.

All redirects have been uploaded to the file.


[RTM] ENH: Use mri_robust_template for T1 merge

We've found that FLIRT alignment can sometimes fail on T1 images. Although a 9-DOF affine registration resolves the issue, it appears to be an artifact problem, rather than a scaling issue that would require the extra 3 degrees of freedom.
This PR uses FreeSurfer's mri_robust_template to generate a structural reference image.
mri_robust_template throws an error on single volumes, so I subclass freesurfer.RobustTemplate to copy the input file in that case. (I use a hack similar to that in freesurfer.ReconAll to fiddle with the cmdline.)
Closes: #439, #473

This is running fine for me. Do we still want to pass the pre-merged T1 to FreeSurfer? On the one hand there's no scaling issue to correct before passing it in; on the other, it's what FS will do immediately, anyway, so no need to duplicate work.
Leaving it as is also puts the original T1s into the FreeSurfer directory, which is either good (for provenance sake) or bad (for taking up space), depending on your priority.
I can go either way.

I would lean towards feeding one merged image.

BTW - can we get a changelog entry? It would be good that now the templates are unbiased. This also closes #310

When you say unbiased, you mean that we're no longer aligning to the first image before taking the average? Because we're still doing that. The FreeSurfer invocation is --inittp 1 --fixtp, which means "use first frame as the 'init' time point and align to that time point", so I kept on with this.
I can play with dropping those to see what effect that has, but I think maybe that makes sense as a separate PR. This fixes #439 in the short term while keeping as close as possible to existing behavior.

Ok then this does not close #310. Lets leave it to another PR.

The new merge stripped original filename info from the pipeline. This should resolve that, though another option would be to pull the bids_info node out of surface_recon_wf and just pass in the subject_id. But I figured there might be something else that counts on this name getting propagated through properly, so I went with this option.

Re-ran s497 from scratch overnight. Outputs LGTM. Moving to interfaces.freesurfer to be consistent with #484. Will merge on pass.


[SPARK-12934][SQL] Count-min sketch serialization

This PR adds serialization support for CountMinSketch.
A version number is added to version the serialized binary format.

Test build #49967 has started for PR 10893 at commit e97d7f9.

Test build #49967 has finished for PR 10893 at commit e97d7f9.

This patch passes all tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
      throw new CountMinSketchMergeException(\"Cannot merge estimator of class \" + other.getClass().getName());
public class CountMinSketchMergeException extends Exception

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/49967/
Test PASSed.

Test build #50020 has started for PR 10893 at commit 4abc4e0.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/50019/
Test FAILed.

Test build #50023 has started for PR 10893 at commit 9acfe33.

Test build #50025 has started for PR 10893 at commit 4636af1.

Test build #50023 has finished for PR 10893 at commit 9acfe33.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/50023/
Test PASSed.

Test build #50025 has finished for PR 10893 at commit 4636af1.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/50025/
Test PASSed.

Test build #50020 has finished for PR 10893 at commit 4abc4e0.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/50020/
Test PASSed.

LGTM overall

Going to merge this. Thanks. Please address my (one) feedback in your next pr.


Search with row selection not working properly

Question
When I configure search along with row selection, row selection is not working anymore.

@ananthongit you don't follow the issue or question template so that I close your issue/question.  I will reopen it when you follow the instruction of opening issue here


Cactbot UI doesnt show up after 24th May patch everything else works

Cactbot doesnt show up anymore after patch from tuesday act doesnt show any errors i already reinstalled everything except ff14 itself.
/countdown 5 doesnt bring up the ui either everything else works parsing or triggernometrie for example.
Test Ui blue box with red frame also shows up until i lock the overlay like described in the guide.
On monday before maintenance and patch everything worked.

Have you updated to the latest ffxiv plugin that released today?

Yes it was automaticaly updated through act

Probably your best bet is to ask on the ffxiv act discord and get some more direct tech support.  There hasn't been a cactbot update so nothing has changed here.

Its the only Module thats doesnt Work anymore as i said parsing and triggernometrie wirks Just fine the Test ui ist showing Up i can Lock it but it dies nothing while every Others Module works as intended

Found a solution installed alerts and timeline seperately not combined now it works maybe inmaxe the test window top small ?

Glad you got it sorted!


pythonPackage.progressbar2: Fix

Motivation for this change
progressbar2 build fails on my machine.
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Fits CONTRIBUTING.md.

Notify maintainers
cc @ashgillman

@GrahamcOfBorg build python27Packages.progressbar2 python37Packages.progressbar2 python38Packages.progressbar2 truvari

Thank you @Pamplemousse


Domain activation Failed

Basically I had already connected my app to the domain I had recently bought. The domain was active and my connected app was showing up at the url I wanted it to. Then I went back into aws console later and the app no longer showed up under my apps, even though it appeared to still be there at the domain. Now it won't let me upload new builds because it thinks it is already connected to a different resource. I tried retrying and it did not help.

Weirdly, even though I continue to get this error it actually is updating my site, so I suppose it is working at the end of the day, just throwing a weird error.

Hi @treyholt ,
Can you please send an email to<EMAIL_ADDRESS>and include your account id and appArn (can be found in the General Settings page), and the domain name you are trying to connect?
Thanks!


WARNING: There are known rendering problems with Cairo <= 1.14.0

The dependencies listed in the dockerfile:
 DEPS=' \
        bash \
        gettext \
        libcairo2 \
        libffi-dev \
        libpango1.0-0 \
        libpangoft2-1.0-0 \
        libgdk-pixbuf2.0-0 \
        libxml2-dev \
        libxslt1-dev \
        shared-mime-info \
        fontconfig \
        libfontconfig1 \
    ' \

Are causing the following warning messages:
WARNING: There are known rendering problems with Cairo <= 1.14.0
WARNING: @font-face is currently not supported on Windows

Everything is working fine but maybe we should change the dependencies to a newer version?
P.S: can't wait for 0.2.0 release, great work! this library is definitely the less painful of all those that I have found (django-wkhtmltopdf, reportlab)

Same =(

Me too.
I'm developing an application that generates a PDF document to be printed and signed. So far the development has not been affected and I'm creating the PDF, but I fear that later this may lead to a problem that will disrupt the application.

I have solved this issue when I switch to Alpine Linux. Here's my dockerfile:
FROM python:3.6-alpine3.7

ENV PYTHONUNBUFFERED 1

RUN  addgroup -S django \
    && adduser -S -G  django django

# OS dependencies
RUN apk update \
    # psycopg2 dependencies
    && apk add --virtual g++ build-deps gcc python3-dev musl-dev \
    && apk add postgresql-dev \
     # Pillow dependencies
    && apk add jpeg-dev zlib-dev freetype-dev lcms2-dev openjpeg-dev tiff-dev tk-dev tcl-dev \
    # CFFI dependencies
    && apk add libressl-dev libressl libffi-dev py-cffi \
    # Weasyprint dependencies
    && apk add cairo pango cairo-dev pango-dev gdk-pixbuf freetype ttf-freefont

Also, I have uninstalled this package since it is not maintained anymore. I am using only WeasyPrint to create my PDF rendering functions.


Blueprints

Playing around with Blueprints to get a feel for it

var player = new ComponentBlueprint(24, "PlayerComponent", null);

var positionFields = new Dictionary<string, object> {
    { "x", 12 }, { "y", 34 }, { "z", 56 }
};
var position = new ComponentBlueprint(42, "PositionComponent", positionFields);

var components = new [] {
    player,
    position
};

var blueprint = new Blueprint(string.Empty, components);

pool.CreateEntity(blueprint);

Blueprints contain all the information needed to create an entity. We can add converters to create Blueprints from different sources like XML, JSON, YAML, etc. We can either use them directly with pool.CreateEntity(blueprint) or use them as a base for code generation pool.CreateHero()
The first approach relies on reflection and might be slower than the code generation approach where no reflection is necessary.

Had to look a short while before I found Pool.CreateEntity(Blueprint) and ComponentBlueprint.CreateComponent(), but yeah, this seems to be exactly the way we're doing it in our framework as well. Nice! :)

Blueprints are not in yet. The branch has been merged, but the contents have been removed again. I'll create a new branch once I continue working on this feature.


is_consistent_across_study

this PR adds is_consistent_across_study operator that takes a target and makes sure it is consistent across values
to test:
run test using operator:
neg.json
Rule_underscores.json
send pos.xlsx
send neg.xlsx
pos.json

I ran the test for the operator. the operator accurately points out any inconsistencies if found in the dataset. But what I have noticed is that even if I run the test function in the engine using standard as sdtmig (-s sdtmig) the engine still runs for this sending rule. I think this needs to be resolved on priority


Ensure "builtin" flag is correctly set for search results

Before when searching for "string" you could see errors like this in the console:

This caused problems downstream occasionally (e.g. https://github.com/Microsoft/pxt/pull/5362)
This was because the builtin blocks (e.g. text_length) are supposed to have the "builtinBlock" flag set to true in the SearchInfo type, but this wasn't being correctly set because of an issue in how the builtin and non-builtin search sets where combined (the non-builtin search set included some builtins that overwrote the builtin search set).
After this PR, these errors no longer appear in the console.

@riknoll , here's the search change I made to de-dupe built-in blocks.


How to change certificateUrlValue for osProfile to use certificateCommonName

How to change certificateUrlValue for osProfile to use certificateCommonName? It still points to one version of the cert, which will be changed if the cert is rotated.
"osProfile": {
            "adminPassword": "[parameters('adminPassword')]",
            "adminUsername": "[parameters('adminUsername')]",
            "computernamePrefix": "[parameters('vmNodeType0Name')]",
            "secrets": [
              {
                "sourceVault": {
                  "id": "[parameters('sourceVaultValue')]"
                },
                "vaultCertificates": [
                  {
                    "certificateStore": "[parameters('certificateStoreValue')]",
                    "certificateUrl": "[parameters('certificateUrlValue')]"
                  }
                ]
              }
            ]
          },

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: e302570c-50f7-af0d-ab7c-62845ecd35cb
Version Independent ID: 679e51cc-2123-adb8-abe2-1c8bbacf46c3
Content: Create a cluster using certificate common name - Azure Service Fabric
Content Source: articles/service-fabric/service-fabric-create-cluster-using-cert-cn.md
Service: service-fabric
GitHub Login: @sukanyamsft
Microsoft Alias: sukanyas

@dip07 Thank you for sharing your query! We are currently investigating and will get back to you shortly on this.

@dip07 Apologies for the delay in response and all the inconvenience caused because of the issue. I had discussion internally and got below response from the team:
The OsProfile.Secrets method of provisioning certificates into a VMSS is by designed versioned; this is to ensure consistency across instances of the VMSS, and following events like reimaging or scaling out.
For versionless/auto-rollover-compatible provisioning of certs, please have a look at the Azure Key Vault VM Extension for Windows - Azure Virtual Machines | Microsoft Docs.
In either case, the provisioning is not by CN but by the address of that certificate in the store.
Hope it helps!!!

@psmanhas Found out an alternative way. This helped me solve my problem

"vaultCertificates": [
{
"certificateStore": "[parameters('certificateStoreValue')]",
"certificateUrl": "[reference(resourceId(resourcegroup().name, 'Microsoft.KeyVault/vaults/secrets', parameters('keyVaultName'), parameters('certNameInKV')), variables('keyVaultApiVersion')).secretUriWithVersion]"
}
]

In this way, the version is pulled automatically

@dip07 Thank you for sharing out your solution really appreciate that :)
We will now close this issue. If there are further questions regarding this, please tag me in a comment. I will reopen it and we will continue the discussion.


FATAL: sorry, too many clients already

          Hi @visch, @BuzzCutNorman, and @edgarrmondragon,

it looks like this one is tripping again. I am observing it on my workstation, and on CI, like at GH-250. Do you think that would qualify to re-open this ticket?
@visch said:

Verified that this opens up 100 connections in my use case. This seems like multiple issues.

Pooling doesn't seem to be working properly / setup properly

That would also be my personal feeling about the situation. However, I haven't been able to take a closer look up until now, and thought it would be a good idea to talk to you beforehand.
With kind regards,
Andreas.
Originally posted by @amotl in https://github.com/MeltanoLabs/target-postgres/issues/124#issuecomment-1862969053

@amotl I created this one instead of reviving the old ticket. Seems like you can replicate this with the code at https://github.com/MeltanoLabs/target-postgres/pull/250 , should definitely take a look. If it's just during testing that's one level of issue, it sounds like this doesn't happen when running the target in production which is good so that means we're probably limited to just a Test setup related issue

Hi Derek,
thank you for refactoring the ticket, and for your reply.
Yeah I guess it looks like you've invested into proper pool behaviour the other day already, so there is a good chance it may only be related to testing. It looks like @BuzzCutNorman is an expert on this matter, so maybe he could take a look? 🙏
With kind regards,
Andreas.

Adding 8ec2a1508a to GH-250 improves the situation, only leaving one error like this behind.

Adding 87b24372bd to GH-254 seems to fix the problem without further ado.
So, to summarize, I think the flaw has been introduced by GH-215, starting to call create_engine(target) per test function, but got amplified by adding more test cases and another test utility function doing the same thing on behalf of GH-250.

@amotl thanks for the kind words but I am definitely not an expert.  I just contributed some code.  I took a quick glance and I you might be running into the connection limit because you are creating a new engine/connection pool with each test run.
The code I contributed does the following when a target class instance adds its first sink it generates an instance of the default connector class and stores it in a private variable _target_connector.  This connector is available via the property target_connector.  The target then shares this connector with each sink instance it generates so they share one engine/connection pool.  Which is hard to replicate if you are attempting to test multiple connection types.
If I am following the test code correctly each test is creating an engine/connection pool and not closing or disposing of the engine.  I think this is causing you to reach the limit of connections.  My suggestion would be to dispose of the engine at the end of each test that generates an engine to see if that helps.
https://docs.sqlalchemy.org/en/20/core/connections.html#engine-disposal

Hi again. I think I've identified the flaw and fixed it per 0eb1e18f504.

Hm, it looks like it still tripping on CI, on the same single occasion as before. I can promise it works on my machine ™, though. Apparently, it needs more digging...
-- https://github.com/MeltanoLabs/target-postgres/actions/runs/7266523429/job/19798429798?pr=250

Apparently, all of 8b3ea4f55c, a9d179694a, 723e1fa699b are needed to remedy the flaw. I am not sure if they are correct, but they resolve the problem at hand: GH-250 passes CI now.


Module 5A: Data Enhancements [1st Draft Completion List]

Module 5A: Data Enhancements

[x] Title created
[x] Purpose created
[x] Keywords created
[x] Point Person assigned
[ ] Task List filled in
[ ] Essential training added
[ ] Metrics costing reporting filled in
[ ] Outreach opportunities filled in
[ ] Exemplar workflows added
[ ] References to other Modules added/linked
[ ] Discussion section added at bottom
[ ] Links to standards/Best practices

What is 5A: Date formats, measurements, tags, notes, collector parsing, curatorial and historical information - "have you thought of these things"

What is 5A: Date formats, measurements, tags, notes, collector parsing, curatorial and historical information - "have you thought of these things"

We need to add references to the idea of adding metacollections/paracollections:
e.g. https://spnhc.biowikifarm.net/wiki/Field_Notes

https://www.idigbio.org/wiki/images/f/f9/Source_Results.pdf

Capturing field notes/accession books as a workflow process may need to be developed?

@tmcelrath @ccwirth - the digitization of field notes would fit best in Module 1D, rather than 5A, since they directly relate to collecting metadata, rather than data "extras". I'll add these comments to 1D.

Difference between 1D + 5A - mostly perspective. 1D - think about things before digitization. 5A - what stuff gets added after digitization happens. What value can still be added?


Added examples for anonymous() and file()

For #34
Added examples for anonymous() and file().
Please let me know if these look OK! I'll write examples for the other functions if so.
I added ? to all of the examples according to the API guidelines.
Ottavio

CI is failing because of ?, but I think it's important to include in the documentation.

I think it's important to include in the example docs.

Yah I agree.  It should be possible to run only the non-doc tests using cargo test --lib, but it may require some surgery to ci/script.sh to figure out the rustc version and do a special test.

Thanks @omh1280 !

No problem :) I'll work on the rest of the public functions now

Just rebased (hope that's ok) and squashed all of the commits into one.
 Honestly, it became really hard to be creative in every example, but there is now a framework for people to add creativity to the examples :)
How's it look?
P.S. The tests will fail on CI because of ?, but they all pass on my machine.

Thanks again!


More fixes to get a green build

Test fixes

// , OK, because we're missing some parameters in the configuration file to support 0.11.1.

Merging this since I think it's as good as it's going to get while we use poise


Change the groupName of ADC_Common from ADC to ADC_Common

In the https://github.com/tinygo-org/stm32-svd project, it depends this project and generates types by the peripheral's groupName. Because the ADC_Common's groupName is ADC, it can't generate the types ADC and ADC_Common correctly. I want to change the ADC_Common's groupName to ADC to make it work fine.  See https://github.com/tinygo-org/tinygo/pull/2717 , https://github.com/tinygo-org/stm32-svd/pull/7 , but those are not good way.
I checked the generated rust code, it's not changed after apply this change and run make, seems it doesn't depend groupName. So can you accept this PR?

Rebased to resolve merge conflict.
bors r+


Testing custom elements without a name property

I'm using a library called Vuetify. Now my app contains (almost) only vuetify elements like v-btn/v-toolbar/...
The problem is that I can't test anything because Avoriaz requires custom elements to have a name property and none of those custom elements have a name property...
I'm sorry if I'm totally wrong, I'm pretty new to testing javascript. Any help is appreaciated. :)

Yes you're right, avoriaz needs a custom name property to identify components.
This isn't ideal, I can have a look and see what other ways we can use to identify vue components 🖒

Hi @YassineGherbi, I've looked into Vuetify, and every component I checked has a name. Which component were you using that didn't have a name?

I realize now this is a pretty old issue, but there is a workaround in case anyone else runs into it. Assuming that the Vuetify components are registered globally, you can set a name property on any relevant components via a new vue instance for your tests.
Something along these lines:
describe ('some-component', () => {
  const sandbox = sinon.sandbox.create();

  let vueInstance
       vuetifyComponentMock;

  beforeEach(() => {
    vuetifyComponentMock = { name: 'vuetify-component-name' };

    vueInstance = Vue.extend();
    vueInstance.use(Vuetify);
    vueInstance.options.components.someVuetifyComponent.name = vuetifyComponentMock.name;
  });

  it('some test', () => {
    const wrapper= mount(ComponentUnderTest, {
      instance: vueInstance
    });
  });
});

I haven't actually used the approach of setting name only in quite some time though (I now stub the entire component so I can just test if props are set correctly), so it's possible I have that property wrong (vueInstance.options.components.someVuetifyComponent.name). If so, you might need to inspect the object, it should be in the vicinity.


Update Set-ADUser.md

I made the attributes, that can be used to specify the Identity more visible. (I kind of struggled, which Active-Directory Attributes can be used)
While developing my script, I struggled, how to specify the paramenters correctly... I wanted to provide an example to help others
PR Summary

PR Checklist

[ ] Descriptive Title: This PR's title is a synopsis of the changes it proposes.
[ ] Summary: This PR's summary describes the scope and intent of the change.
[ ] Contributor's Guide: I have read the contributors guide.
[ ] Style: This PR adheres to the style guide.

@microsoft-github-policy-service agree

From: learn-build-service-prod[bot] @.>
Sent: Wednesday, January 10, 2024 4:46:30 PM
To: MicrosoftDocs/windows-powershell-docs @.>
Cc: PhilippRenner @.>; Mention @.>
Subject: Re: [MicrosoftDocs/windows-powershell-docs] Update Set-ADUser.md (PR #3723)
Learn Build status updates of commit fc693f2https://github.com/PhilippRenner/windows-powershell-docs/commits/fc693f2e7ccfb73dde53e1ffeb320ccafc667731:
✅ Validation status: passed
File    Status  Preview URL     Details
docset/winserver2022-ps/activedirectory/Set-ADUser.mdhttps://github.com/PhilippRenner/windows-powershell-docs/blob/patch-1/docset/winserver2022-ps/activedirectory/Set-ADUser.md      ✅Succeeded      Viewhttps://review.learn.microsoft.com/en-us/powershell/module/activedirectory/set-aduser?view=windowsserver2022-ps&branch=pr-en-us-3723 (WindowsServer2022-ps)
For more details, please refer to the build reporthttps://buildapi.docs.microsoft.com/Output/PullRequest/46a32786-a1f6-1250-e1e1-2a4554025dc9/202401101538091557-3723/BuildReport?accessString=7351612cfe0e78c4d619f846ce4aeba3b34ab3f36aca58ee5140760645c453ee.
For any questions, please:

Try searching the learn.microsoft.com contributor guideshttps://review.learn.microsoft.com/en-us/help/?branch=main
Post your question in the Learn support channelhttps://teams.microsoft.com/l/channel/19%3A7ecffca1166a4a3986fed528cf0870ee%40thread.skype/General?groupId=de9ddba4-2574-4830-87ed-41668c07a1ca&tenantId=72f98bf-86f1-41af-91ab-2d7cd011db47

—
Reply to this email directly, view it on GitHubhttps://github.com/MicrosoftDocs/windows-powershell-docs/pull/3723#issuecomment-1885110568, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AGBZSWPSEMUCC6ML6QYPZ6TYN2ZVNAVCNFSM6AAAAABBU75ZWOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQOBVGEYTANJWHA.
You are receiving this because you were mentioned.Message ID: @.***>


Request: reduce lags while scrolling

I've noticed that when performing a fast scrolling of the view, there is sometimes lag. a jump between frames.
Enabling the "profile GPU rendering", I noticed that indeed it can get very slow :

At first I thought it's something with the adapter onBindViewHolder function, but it's far from the truth.
The real reason for this, is that the scrolling constantly calls notifyDataSetChanged, as I wrote here:
    @Override
    public void onScrolled(RecyclerView recyclerView, int dx, int dy) {
        //On Scroll, agenda is refresh to update background colors
        post(new Runnable() {
            @Override
            public void run() {
                mCalendarAdapter.notifyDataSetChanged();
            }
        });

Commenting this part, scrolling becomes super smooth, but of course there won't be any selection of items during scroll:

Please do think of a better way to update the views.
It doesn't make sense to update all of the views, whenever you scroll, or even whenever a new selection is made. Only 2 views are supposed to be updated, and only when the selection has changed.

This is also Circumstantially related to have a large range of dates which was not considered.
I don't see until now any use-case of displaying more than 1 year in such a Horizontal Calendar!

fast scrolling isn't related to having a list of dates, no matter how long the list is (unless I can't fast scroll, because there are only 5 items in the list).
It is about the scrolling of the items.
To prove it, I changed to display a single year of range, and I still have lags:
    Calendar startDate = Calendar.getInstance();
    startDate.setTime(new Date(0L));
    Calendar endDate = Calendar.getInstance();
    endDate.add(Calendar.YEAR, 1);
    final Calendar defaultDate = Calendar.getInstance();

This occurs even with 2 months.
As I wrote, memory usage doesn't cause the performance hit.

Well it doesn't occur on my device for sure, maybe try turning off screen recording and try again?

An image isn't screen recording. A video is.
Taking an image doesn't affect the app in this matter. I even took it after I stopped scrolling , here:
https://github.com/Mulham-Raee/Horizontal-Calendar/issues/48#issuecomment-339007685
This is also why the right part of the graph seems lower. It didn't refresh the view so often.
I tried to use notifyItemChanged, while also updating the previously selected view, but this caused a weird artifact that causes the holder's view to overlap others.
It's also a bit cool bug, showing as if you scroll very fast, like the speed of light, but that's not what I want :)
See here my POC image, including the graph:

Of course I won't use this, but it seems a bit cool.

I've succeeded updating the exact viewholders, instead of calling notifyDatasetChanged.
This means that whenever a new selection is found, it refreshes only 2 views : the old one and the new one.
I've also modified the layout of each cell, so that each textView won't try to cause a layout change of the others. Not sure if that helps, because it's smooth already.
The final result is much better . I tried to scroll as fast as I could, and the graph barely and rarely even reached the half-height, as opposed to what it was before
Here's how it works on OnePlus 2:
device-2017-10-25-101806.zip
I've also tested on Nexus 4 with Android 4.4.4 . The graph there is a bit weird. It's almost always below the green line, but I see 2 more graphs. Thing is that there is lag, so much that the selection is behind its true position and in some cases it's outside of the RecyclerView, on the repo's sample :

I suspect that the selection is wrong due to the "post" call.
On my POC, it's consistant, and have much lower graph. The selection is always on the middle item:

About code, what I do is to save the last selected viewHolder and its position in a fields:
private var lastSelectedHolder: MyViewHolder? = null

This is the code for the scroll listener:
        override fun onScrolled(recyclerView: RecyclerView?, dx: Int, dy: Int) {
            val position = getPositionOfCenterItem(linearLayoutManager)
            if (recyclerView != null && recyclerView.adapter != null && (lastSelectedItem == -1 || lastSelectedItem != position)) {
                if (lastSelectedHolder != null)
                    recyclerView.adapter.bindViewHolder(lastSelectedHolder, lastSelectedHolder!!.adapterPosition)
                val viewHolder = recyclerView.findViewHolderForAdapterPosition(position)
                recyclerView.adapter.bindViewHolder(viewHolder, viewHolder!!.adapterPosition)
                lastSelectedItem = position
            }
        }

and the relevant code in the "onBindViewHolder" :
                val positionOfCenterItem = getPositionOfCenterItem(linearLayoutManager)
                val isSelected = position == positionOfCenterItem
                if (isSelected && lastSelectedHolder != holder)
                    lastSelectedHolder = holder
                holder.selectionView.visibility = if (isSelected) View.VISIBLE else View.INVISIBLE

Oh, and I know why you called "post". The log writes about it here:

Cannot call this method in a scroll callback. Scroll callbacks mightbe run during a measure & layout pass where you cannot change theRecyclerView data. Any method call that might change the structureof the RecyclerView or the adapter contents should be postponed tothe next frame.

Still, no need to create a new instance of the Runnable each time.
And, the new solution should solve this anyway...


Can't Install specific version of sfdx on linux

Summary
For our CI process, we have SFDX pinned to a specific version (49.10.0) because salesforcedx plugin updates keep breaking our CI process so we want something stable.
However, as of mid last week, installation of<EMAIL_ADDRESS>is failing with no error given.
Steps To Reproduce:

Have a linux machine
(ous) Kernel Version: Linux 2f93efba8fff 4.15.0-1077-aws #81-Ubuntu SMP x86_64 Linux
Install SFDX with the following commands:
mkdir sfdx          wget -qO- $DX_CLI_URL | tar xJ -C sfdx --strip-components 1          ./sfdx/install          sfdx          sfdx plugins --core          sfdx plugins:install<EMAIL_ADDRESS>
Expected result
salesforcedx plugin vesion 49.10.0 is installed
Actual result
Install fails and exits with exit code 1 and the following output:

sfdx plugins:install<EMAIL_ADDRESS>Successfully validated digital signature for salesforcedx.
Finished digital signature check.
Installing plugin salesforcedx... yarn add v1.22.10
Installing plugin salesforcedx... info No lockfile found.Installing plugin salesforcedx... [1/4] Resolving packages...Installing plugin salesforcedx... [2/4] Fetching packages...Installing plugin salesforcedx... info Visit https://yarnpkg.com/en/docs/cli/add for documentation about this command.Installing plugin salesforcedx... !

Additional information
SFDX CLI Version(to find the version of the CLI engine run sfdx --version):
sfdx-cli/7.81.0-7b953c80d1 linux-x64 node-v12.18.3
SFDX plugin Version(to find the version of the CLI plugin run sfdx plugins --core)
sfdx plugins --core
@oclif/plugin-autocomplete 0.1.5 (core)
@oclif/plugin-commands 1.3.0 (core)
@oclif/plugin-help 3.2.0 (core)
@oclif/plugin-not-found 1.2.4 (core)
@oclif/plugin-plugins 1.9.1 (core)
@oclif/plugin-update 1.3.10 (core)
@oclif/plugin-warn-if-update-available 1.7.0 (core)
@oclif/plugin-which 1.0.3 (core)
@salesforce/sfdx-trust 3.4.3 (core)
alias 1.1.3 (core)
analytics 1.12.1 (core)
auth 1.3.0 (core)
config 1.2.1 (core)
generator 1.1.3 (core)
salesforcedx 50.6.0 (core)
├─ schema 1.0.1 (core)
├─ @salesforce/sfdx-plugin-lwc-test 0.1.7 (core)
├─ templates 50.1.0 (core)
├─ custom-metadata 1.0.10 (core)
├─ apex 0.1.4 (core)
└─ salesforce-alm 50.6.0 (core)
sfdx-cli 7.81.0 (core)
OS and version:
PRETTY_NAME="Debian GNU/Linux 9 (stretch)"
NAME="Debian GNU/Linux"
VERSION_ID="9"
VERSION="9 (stretch)"
VERSION_CODENAME=stretch

Some more info:
yarn global add sfdx-cli
Fails with:

error<EMAIL_ADDRESS>The engine "node" is incompatible with this module. Expected version ">=14". Got "12.20.0"
error Found incompatible module.
info Visit https://yarnpkg.com/en/docs/cli/global for documentation about this command.

This is very unexpected as sfdx reports to use 12.18.3 internally and we have been using the docker image circleci/node:12 for ages now. The errors do seem to correspond with the image being upgraded to node 12.20 though.

Running into the same issue here, we were on 49.9.2 for the same reason

Isn't this a duplicate of #746?

@thvd Not completely as I experienced the issue even after upgrading to Node14. Upgrading to Node14 does NOT fix the issue

@yippie That's because the antlr lib also changed the location of their index.  Can you please try installing the latest-rc tag (which will become latest tomorrow morning)?  If that doesn't work please re-open this issue.


initialize new projects with git init if git present

fixes #28
i may have also extracted that trimLeft functionality

I would add several more patterns to gitignore:

ignoring logs:

*.log
npm-debug.log*
yarn-debug.log*
yarn-error.log*

ignoring coverage (preact-cli will be using jest AFAIK which uses istanbul)

coverage

The default gitignore for node might have some more goodies but frankly I haven't seen half of those files in any node project.

^^ With *.log in place, no need for these:
npm-debug.log*
yarn-debug.log*
yarn-error.log*

I remember npm generating timestamps in log file names but it doesn't do so anymore (at least I don't remember how it is done) so probably they are not needed. :)

Overall this is great! Thanks for doing all the work, haha.
Only thing I'm keen to add to this aside from the little sync fix would be a git option that defaults to true, so someone can do preact create --no-git to avoid initializing a repo if they wish.  I'm happy to add that after merging if it's not of interest :)

@lukeed agreed, it would be nice to have commandExists('yarn') that just returns a Boolean without the try/catch.

@developit @lukeed it's here - https://github.com/developit/preact-cli/pull/31/files#diff-3d03cf8df0979b4050f3a105cfd861c5R168 .
We can do this after merges.

wow I even subconsciously stole the name

I think this makes more sense to be paired up with #56 as a minor or even major.


Invalid type: map, expected a sequence at line 1 column 0

While version 0.2.4 seems to work fine, 0.3.1 doesn't seem to accept any tokens?
Printing the error gives the following
FetchFailed("Auth error occurred: error decoding response body: invalid type: map, expected a sequence at line 1 column 0")

I pretty much followed the example shown on the repo.
Replaced
let firebase_auth = FirebaseAuth::try_from_json_file("tests/env_files/firebase-creds.json")
    .unwrap();

with
let firebase_auth = FirebaseAuth::builder()
        .json_file("firebase-credentials.json")
        .build()
        .unwrap();

with a firebase-credentials.json file in the root folder (same folder as Cargo.toml & the src folder)
and used the following example along with some extra prints
#[get("/hello")]
async fn hello_world(state: &State<ServerState>, token: BearerToken) -> Status {
    let token = state.auth.verify(&token).await;

    println!("Token: {:?}", token);
    match token {
        Ok(token) => {
            let uid = token.uid;
            println!("Authentication succeeded with uid={uid}");
            Status::Ok
        }
       Err(err) => {
            println!("Authentication failed.");
            println!("{:?}", err);
            Status::Forbidden
        }
    }
}

I've also noticed that running the Rocket app in Docker causes both 0.2.4 and 0.3.1 to no longer verify any tokens.
Where both would give the following error
FetchFailed("Auth error occurred: error sending request for url (https://www.googleapis.com/service_accounts/v1/jwk/securetoken@system.gserviceaccount.com): error trying to connect: error:1416F086:SSL routines:tls_process_server_certificate:certificate verify failed:../ssl/statem/statem_clnt.c:1913: (unable to get local issuer certificate)")

The FetchFailed error is only used when something fails while fetching the list of JWKs from Google (URL). I didn't change anything from 0.2.4 to 0.3.1 that should have affected this in a weird way so I'm scratching my head thinking how this error happened. Could you tell me a bit more about how you encountered this problem?

I pretty much followed the example shown on the repo.
Replaced
let firebase_auth = FirebaseAuth::try_from_json_file("tests/env_files/firebase-creds.json")
    .unwrap();

with
let firebase_auth = FirebaseAuth::builder()
        .json_file("firebase-credentials.json")
        .build()
        .unwrap();

with a firebase-credentials.json file in the root folder (same folder as Cargo.toml & the src folder)
and used the following example along with some extra prints
#[get("/hello")]
async fn hello_world(state: &State<ServerState>, token: BearerToken) -> Status {
    let token = state.auth.verify(&token).await;

    println!("Token: {:?}", token);
    match token {
        Ok(token) => {
            let uid = token.uid;
            println!("Authentication succeeded with uid={uid}");
            Status::Ok
        }
       Err(err) => {
            println!("Authentication failed.");
            println!("{:?}", err);
            Status::Forbidden
        }
    }
}

I've also noticed that running the Rocket app in Docker causes both 0.2.4 and 0.3.1 to no longer verify any tokens.
Where both would give the following error
FetchFailed("Auth error occurred: error sending request for url (https://www.googleapis.com/service_accounts/v1/jwk/securetoken@system.gserviceaccount.com): error trying to connect: error:1416F086:SSL routines:tls_process_server_certificate:certificate verify failed:../ssl/statem/statem_clnt.c:1913: (unable to get local issuer certificate)")

Thanks for the detailed answer! I haven't tested these for Docker, so I'll see if I can work on that... we should definitely include an example using docker as it seems some extra steps need to be taken for it to work as intended.
As for the error in 0.3.1, I'll have to take a look!

Reporting that this exact error appears with meas well. I'm not running the server in Docker, I'm running it bare metal on my machine.
I'm on Manjaro (based on Arch Linux), using version 0.3.1 of the crate.

@rgarlik Thanks for the comment. I implemented a small fix and released it with v0.3.2. I hope this fixes the error.
I still need to create an example using docker though, so I'll keep this ticket open until that's finished


Rely on NIO defaults for child maxMessagePerRead

One message per read is probably too low. Let's revert to the NIO default of 4

Is there a noticable performance improvement?


#164 add pypi package update action

Description
Please include a summary in English, of the changes in this pull request. If it closes an issue, please mention it here.
Closes: #164
You should link at least one existing issue for PR. Before your create a PR, please check to see if there is an issue for this change.
PRs from forked repository not accepted.
Change(s)

Add pypi package update github workflows

Changelog
If you PR to dev branch, please add a brief summary of the change to the Upcoming Release section of the CHANGELOG.md file and include a link to the PR (formatted in markdown) and a link to your github profile.
For example,
- Added a new feature by `@myusername` in [PR 2023](https://github.com/Nota-NetsPresso/netspresso-trainer/pull/2023)

Code Formatting
If you PR to either master or dev branch, you should follow the code linting process. Please check your code with lint_check.sh in ./scripts directory.
For more information, please read the contribution guide in CONTRIBUTING.md.

@illian01
PYPI_API_TOKEN has been registered as secret.

@illian01
Currently, tags should be manually pushed.
I considered whether we apply tagging with our release PR, but it's hard to decide myself.


Handle deprecated C++17 std::allocator API.

Fixes #1214
Bug 200619424

Fixed an issue with the rebind_* members in the last push. Running CI in 28744950.


delete host: NameError: name 'y' is not defined

while testing your script i found the following. not shure if i'm doing something wrong or its
some kind of bug.
root@lpgaixmgmtlx01:/root/ansible-dynamic-inventory-mysql>./inventoryctl.py host -H TESTHOST -d
[Command]: host
Are you sure you want to delete the host: TESTHOST[TESTHOST] ?!
After deleting the data will not be restored!!  [y/n]: y
Traceback (most recent call last):
  File "./inventoryctl.py", line 552, in <module>
    InventoryCtl()
  File "./inventoryctl.py", line 38, in __init__
    self.run_command()
  File "./inventoryctl.py", line 115, in run_command
    self._cmd_host()
  File "./inventoryctl.py", line 135, in _cmd_host
    hostdata['host'], hostdata['hostname'])):
  File "./inventoryctl.py", line 527, in _prompt
    val = input()
  File "<string>", line 1, in <module>
NameError: name 'y' is not defined

oops sorry wrong project...


refactor pysift as a library with install

@rmislam As I was working through the code I refactored the library slightly and added a packaging script (setup.py). If you are interested in this PR then I can expand further and add tox for testing as well as refactoring the code a little to include more testing and modularity.
Thank you for writing this and the excellent tutorial on the SIFT algorithm.

@normanb Wow, thanks a lot! This is extremely helpful. Yes, I'm very interested in this PR, and please by all means expand further. Truth be told, I don't have too much time these days, but if I can help you out somehow, please let me know.

@rmislam thank you. I am going to make the library callable by breaking out the functions where I can and so that the code can be ran in parallel to increase performance. I can work in this branch with separate commits so you can clearly see the changes. I understand that the code needs to be readable enough for people following your tutorial.


[ic-data-table]: Selectable row event

Summary
It is possible to click on a row and highlight it however, there is no event attached to it to retrieve any data.
💬 Description
The improvement to data tables selected row is to emit an icSelectedRow event which returns the data from the row and emitted within the event. Returning the data on the line will provide flexibility to mutate the data. This can be improved further by adding a prop which allows multiple rows to be selected.
An update may be required for this.selectedRow to hold multiple rows if required. At the moment, the this.selectedRow state is only used to add a CSS class.
If we add this event, we will need to make rows with it keyboard focusable.
💰 Use value
This increases the functionality of the selected row state as at the moment, it simply highlights the row and nothing else.
📝 Acceptance Criteria
If relevant, describe in full detail the different interactions and edge cases that the component or patterns needs to fulfil.
Given the data table is loaded and shows a set of data
When I click on a table row and the row is highlighted
Then I use the eventListener for icSelectedRow to return the data as an object
✏ Designs
N/A
🧾 Guidance
N/A
Additional info
N/A

Design to explore checkboxes on how to select rows


Errors with nvim-treesitter

Description
:checkhealth nvim-treesitter reports error messages for C# and Zig
Neovim version
v0.10.1
How to reproduce the issue

Use minimal init.lua as below

vim.env.LAZY_STDPATH = ".repro"
load(vim.fn.system("curl -s https://raw.githubusercontent.com/folke/lazy.nvim/main/bootstrap.lua"))()

require("lazy.minit").repro({
	spec = {
		{
			"nvim-treesitter/nvim-treesitter",
			opts = { ensure_installed = { "c_sharp", "zig" } },
			config = function(_, opts)
				require("nvim-treesitter.configs").setup(opts)
			end,
		},
		"p00f/alabaster.nvim",
	},
})
vim.cmd.colorscheme("alabaster")

:checkhealth nvim-treesitter
See error

Output of :checkhealth nvim-treesitter
==============================================================================
nvim-treesitter: require("nvim-treesitter.health").check()

Installation ~
- OK `tree-sitter` found 0.23.0 (12fb31826b8469cc7b9788e72bceee5af1cf0977) (parser generator, only needed for :TSInstallFromGrammar)
- OK `node` found v20.17.0 (only needed for :TSInstallFromGrammar)
- OK `git` executable found.
- OK `cc` executable found. Selected from { vim.NIL, "cc", "gcc", "clang", "cl", "zig" }
  Version: cc (Rev1, Built by MSYS2 project) 14.2.0
- OK Neovim was compiled with tree-sitter runtime ABI version 14 (required >=13). Parsers must be compatible with runtime ABI.

OS Info:
{
  machine = "x86_64",
  release = "10.0.22631",
  sysname = "Windows_NT",
  version = "Windows 11 Pro"
} ~

Parser/Features         H L F I J
  - c_sharp             x ✓ ✓ . ✓
  - zig                 x ✓ ✓ ✓ ✓

  Legend: H[ighlight], L[ocals], F[olds], I[ndents], In[j]ections
         +) multiple parsers found, only one will be used
         x) errors found in the query, try to run :TSUpdate {lang} ~

The following errors have been detected: ~
- ERROR c_sharp(highlights): .../current/share/nvim/runtime/lua/vim/treesitter/query.lua:252: Query error at 589:2. Invalid node type "record_struct_declaration":
  (record_struct_declaration
   ^

  c_sharp(highlights) is concatenated from the following files:
  |    [OK]:"C:\Users\username\OneDrive\dotfiles\.repro\data\nvim-data\lazy\nvim-treesitter\queries\c_sharp\highlights.scm"
  | [ERROR]:"C:\Users\username\OneDrive\dotfiles\.repro\data\nvim-data\lazy\alabaster.nvim\after\queries\c_sharp\highlights.scm", failed to load: .../current/share/nvim/runtime/lua/vim/treesitter/query.lua:252: Query error at 12:2. Invalid node type "record_struct_declaration":
  (record_struct_declaration
   ^

- ERROR zig(highlights): .../current/share/nvim/runtime/lua/vim/treesitter/query.lua:252: Query error at 287:2. Invalid node type "Decl":
  (Decl
   ^

  zig(highlights) is concatenated from the following files:
  |    [OK]:"C:\Users\username\OneDrive\dotfiles\.repro\data\nvim-data\lazy\nvim-treesitter\queries\zig\highlights.scm"
  | [ERROR]:"C:\Users\username\OneDrive\dotfiles\.repro\data\nvim-data\lazy\alabaster.nvim\after\queries\zig\highlights.scm", failed to load: .../current/share/nvim/runtime/lua/vim/treesitter/query.lua:252: Query error at 4:2. Invalid node type "Decl":
  (Decl
   ^

If I do :TSInstall all and then :che nvim-treesitter, report shows 3 errors (out of all 297 parsers)
The following errors have been detected: ~
- ERROR c_sharp(highlights): .../current/share/nvim/runtime/lua/vim/treesitter/query.lua:252: Query error at 589:2. Invalid node type "record_struct_declaration":
  (record_struct_declaration
   ^

  c_sharp(highlights) is concatenated from the following files:
  |    [OK]:"C:\Users\username\AppData\Local\nvim-data\lazy\nvim-treesitter\queries\c_sharp\highlights.scm"
  | [ERROR]:"C:\Users\username\AppData\Local\nvim-data\lazy\alabaster.nvim\after\queries\c_sharp\highlights.scm", failed to load: .../current/share/nvim/runtime/lua/vim/treesitter/query.lua:252: Query error at 12:2. Invalid node type "record_struct_declaration":
  (record_struct_declaration
   ^

- ERROR hare(highlights): .../current/share/nvim/runtime/lua/vim/treesitter/query.lua:252: Query error at 278:12. Invalid node type "name":
            (name) @AlabasterDefinition))
             ^

  hare(highlights) is concatenated from the following files:
  |    [OK]:"C:\Users\username\AppData\Local\nvim-data\lazy\nvim-treesitter\queries\hare\highlights.scm"
  | [ERROR]:"C:\Users\username\AppData\Local\nvim-data\lazy\alabaster.nvim\after\queries\hare\highlights.scm", failed to load: .../current/share/nvim/runtime/lua/vim/treesitter/query.lua:252: Query error at 6:12. Invalid node type "name":
            (name) @AlabasterDefinition))
             ^

- ERROR zig(highlights): .../current/share/nvim/runtime/lua/vim/treesitter/query.lua:252: Query error at 287:2. Invalid node type "Decl":
  (Decl
   ^

  zig(highlights) is concatenated from the following files:
  |    [OK]:"C:\Users\username\AppData\Local\nvim-data\lazy\nvim-treesitter\queries\zig\highlights.scm"
  | [ERROR]:"C:\Users\username\AppData\Local\nvim-data\lazy\alabaster.nvim\after\queries\zig\highlights.scm", failed to load: .../current/share/nvim/runtime/lua/vim/treesitter/query.lua:252: Query error at 4:2. Invalid node type "Decl":
  (Decl
   ^

I don't write C#, @Zorbn can you take a look? I'll update zig

It's been a while since I used Neovim but I guess record_struct_declaration just doesn't exist (anymore?) so it can be removed from the highlights file. Maybe all of those C# *_declarations can be replaced with a single type_declaration.
https://github.com/tree-sitter/tree-sitter-c-sharp/blob/fd7f7402db6e66afd70b402fb2e367b2d71c10d6/grammar.js#L250


Support negative resize for multiple points line/arrow

Fixes #1122
Implement the behavior of negative resizing a line (or arrow) with multiple points.

If this PR is merged, #1214 should be solved together.

We're getting too many PRs dealing with related code. What order do we merge these: https://github.com/excalidraw/excalidraw/pull/1214 https://github.com/excalidraw/excalidraw/pull/1225

The merge conflicts are unavoidable.. we could go with this one first.. it's mostly removing code.

Then the #1193 has to be adjusted first to support resizing arrows/lines before merging I guess.

There's a bug though. Resizing slowly will make the arrow disappears when it reaches 0 width:

Almost there! :)

I suspect the audience wouldn't be amused :).

There's a bug though. Resizing slowly will make the arrow disappear when it reaches 0 width:

Thank you for finding this, but I couldn't reproduce it...
Do I have to make any conditions?
I tried it here: https://excalidraw-git-fork-lusingander-support-resize-multi-point-line.excalidraw.now.sh

I couldn't reproduce it either.

I couldn't either, but I suspect the height is exactly 0. Could you reproduce the behavior with height = Math.floor(height * 100) / 100?

Thanks for confirming, but still couldn't..

Oh, sorry about that. So, maybe height is negative? not sure. I can try later.

@lusingander
I can reproduce the disappearing issue with my hack, please try it again.
L2164
            case "n": {
              let height = element.height - deltaY;
              height = Math.floor(height * 100) / 100;

@dai-shi
Thanks, I could reproduce it.
The fix was not wrong, but It finally happened after several tries.

😄 100 might be too big. height = Math.floor(height) would be much easier to reproduce it.

Yea, if we're not flooring until commit (don't recall) then this bug won't be reproducible on high-DPI screens (due to subpixels).

I think I know why it's happening.
rescalePoints(1, height, element.points) is called when height (or width) is zero.
In the following steps of rescalePoints, prevDimensionSize is calculated to be zero, and dimensionScaleFactor is NaN.
  const prevDimValues = prevPoints.map((point) => point[dimension]);
  const prevMaxDimension = Math.max(...prevDimValues);
  const prevMinDimension = Math.min(...prevDimValues);
  const prevDimensionSize = prevMaxDimension - prevMinDimension;

  const dimensionScaleFactor = nextDimensionSize / prevDimensionSize;

And then, points of the line (arrow) are (x, NaN).
I still don't know how to respond to it 😕

Is there a coordinate for display and a coordinate for save, respectively?
Once the coordinate of a point becomes (x, 0) (or (0, y)), can it be returned to the original shape?
I don't know much about this application yet, but it looks like we don't have a way to do that.

rescalePoints(1, height, element.points) is called when height (or width) is zero.

Sounds like we need to jump zero and go negative.

By not calling rescalePoints when the height is zero, this problem does not seem to reproduce.
Is it a good to fix it this way? As I commented, It seems that it's hard to fix it correctly.
App.tsx#onPointerMove
            case "n": {
              let height = element.height - deltaY;
              height = Math.floor(height * 10) / 10;

              if (isLinearElement(element) && height != 0) {
                mutateElement(element, {
                  height,
                  ...adjustXYWithRotation("n", element, 0, deltaY, angle),
                  points: rescalePoints(1, height, element.points),
                });

@lusingander I hope it's OK. Let's see how it works, hopefully with several people with different browsers.
And, #1193 is merged. Sorry for the conflict, but would you apply your change to the new file? It's resizeElements.ts. It should make it easier to modify/review without touching the big file App.tsx.

That's almost perfect.. the opposite corner is moving a little bit when the line is rotated.

@lipis Are you referring to the behavior like #1275 ?

I think so, yes! Probably for another PR.

Let's merge this one..

The disappearing was fixed, but I'm seeing weird behavior when change both height/width to negative at the same time:

Not how it changed direction. It can change in any, depending on the order of operations.

Wow, that's interesting like a magic. I guess we might need to calm down and reconsider the logic.

Thanks for the confirmation.
I think so too, it seems better to think carefully about calculating the coordinates.

@lusingander Meanwhile, would be willing to tackle other issues in #1298?

Should we merge this as is since it at least improves the situation, and leave the rest for later PR?

@dwelle Let's keep this unmerged, while #1296 is in process. Its going to be a big rewrite.

Originally, it was a bug as described in #1214, so it might be better to merge this (or #1214) if it takes a while to fix #1296 and others.

That's another option. I'm OK with it as long as we file a new issue or keep #1122 open.

@lusingander Meanwhile, you might want to take a look at #1330.

I'm gonna merge this one because it fixes real-word issues, while the side-effect bug (swapping directions) isn't that huge a problem, and happens only in edge cases. I'll create a new issue for that.

Yeah, let's merge this and apply the same technique in #1330.


Help me improve README files

Suggest the proper documentation for this repository. We can discuss it here or Pull Requests are always welcomed.

Currently, I am just looking for a Proper README file. But thanks for suggesting this. We will soon work on this part too.

Merged successfully!


... always need to "Reset" before able to code.

Challenge Name
Responsive Design with Bootstrap
https://www.freecodecamp.com/challenges/responsively-style-checkboxes
Issue Description
When a new challange starts, I always have first to "Reset" the challange, if not, I'm not able to place the cursor where I would like to code, or, when clicked into the coding part, the cursor "jumps" to another part and my code is entered there.
Browser Information

Chrom, Version 50.0.2661.94 m
Windows 10:
Desktop

Your Code
not relevant
Screenshot
not possible
regards
opel22
PS: in the jQuery-Part it is working again as expected.

Duplicate of #7847.
Please go through Help I have found a bug before submitting a bug report.
Thanks and happy coding!