New feature request: Saga

New feature request: implement saga for long-running business processes
Example
https://blog.bernd-ruecker.com/saga-how-to-implement-complex-business-transactions-without-two-phase-commit-e00aa41a1b1b
https://docs.particular.net/nservicebus/sagas/

Masstransit or NServicebus?
https://stackoverflow.com/questions/13647423/nservicebus-vs-masstransit
I guess Masstransit is more attractive.

Nem há situação no projeto atual para se usar saga.

Hello,
just wondering if this has been implemented? I'm also interested in how this pattern can be achieved in your solution.
tks
Lawrence

At this moment the saga pattern doesn't fit with the project purpose


Add nullable colors to settings UI

Summary of the Pull Request
Adds some pre-existing settings ($profile.foreground, $profile.background, $profile.selectionBackground, $profile.cursorColor) to the settings UI. This was accomplished by introducing a new control: NullableColorPicker. This control allows the user to pick a color from the color scheme, set the color to null, and select a color from an advanced color picker.
References and Relevant Issues
#10000
Detailed Description of the Pull Request / Additional comments

NullableColorPicker control

includes a built-in NullColorButton to set the current value to null
includes a "More colors..." button to display an advanced color picker
uses data templates on data templates (data templates squared?) to convert the current color scheme into a grid of color chips
color chips display a checkmark (similar to Windows settings personalization). This automatically updates its color to stay compliant with color contrast.
color chips are added to a list so we can (un)check them when a new color is selected

SettingsContainer changes

Forked ExpanderSettingContainerStyle to allow for a custom preview template. This way, we can display the current value in the expander and we're not just limited to text.
changed type of CurrentValue property from String to IInspectable
added CurrentValueTemplate property to control how to display the current value

Miscellaneous:

Added a few converters (BooleanToVisibility, ColorToString, ColorToBrush)
Added NameWithHexCode to ColorTableEntry to expose a color as Red #RRGGBB (used for tooltips and a11y)
Added ForegroundPreview (and equivalent for other colors) to AppearanceViewModel to deduce the color that will be used

Validation Steps Performed

[X] a11y pass (NVDA, keyboard)
[X] set the color to one of the color chips
[X] set the color to null
[X] set the color to a value from the integrated color picker
[X] control updates properly when a new color scheme is selected
[X] control updates properly when a color scheme has multiple colors of the same value

Follow-ups

[A11y] Screen readers don't read expander's preview text
Add Tab Color to settings UI
Update CursorColor preview to display #FFFFFF as "invert"
[Focus issue] Clicking on the appearance page yeets focus to FontFace control

Demo

Alright! Made some minor changes to fix the focus issue, text box issue, theme issue (on Win10), and layout concerns. Here's a storyboard of the slightly new design:

Changes:

Moved color scheme back to the top
Removed text boxes from color picker. IMO this is fine as the hex value is presented in the Expander's header.

I do still miss having the text box though. What if I add a textbox inside the expander? That'll act as a live preview for the hex value too, and allow users to copy-paste the value directly? It may look a little weird though :/

Combined override settings and color scheme setting into one expander

Weird idea? Maybe. But there are plenty of examples of expanders having full controls in the header. This groups the settings together, but keeps them all near the top (by the live preview too).

Feedback from Bug Bash (11/19)

[ ] Nit: "Color" --> "Cursor Color"
[ ] Foreground/Background/Selection background don't get updated when the selected scheme changes
[ ] The Icon editor doesn't update when I click the revert button (!)
[ ] Icon/ColorScheme SettingContainer has wrong indentation in header
[ ] Nit, probably a puntable thought: can we do Leonard's font picker thing, with the Segoe icon picker, so that you can filter the list? (i may be overindexed on filterable list UIs these days)

Note to reviewer
The Profile.Icon changes all come from https://github.com/microsoft/terminal/pull/17965 which merged into this PR. The PR title and description have been appropriately updated.
Some changes have been made to that area since it merged (just this one commit really): https://github.com/microsoft/terminal/pull/17870/commits/e46ed40bd9286e168c3ec57473d55e5d357712ef

(Code format seems upset)


Ubuntu 2004 support

Hi is there any plan to support Ubuntu 20.04?

Issue transfered to 2004 repository.
Tagged first release 1.0.0 based on @a7i contributions.

Thanks I will try this on AWS later

@liuyangc3 any updates about this?

I've just ran it on a test machine and tested it with Wazuh, the score went from 33% to 84%. A lot more secure, but there are a few things he's still marking as failed. For example, he's telling me there are some options missing on some directories.

@DB-Vincent thanks a lot for testing. Unfortunately, some of the items are difficult to implement as a generic ansible role. Mount options are one of them. Especially cloud images often have only one partition.

@florianutz I've been trying out a few things inside the playbook in order to try to fix those items. The main problem is that ansible keeps skipping the tasks on my machine (although they're all enabled).


branch-AddGradedTest

Added GradedTest.java
Added ReadingAssessment.java
Added MidTerms.java
Added Finals.java
Added PracticalExams.java
Added ExpectedGrade.java
Added JsonAdapetedGradedTest.java
Updated Persons.java
Updated JsonAdaptedPersonTest.java

Added GradedTestListBook.java
Added ReadOnlyGradedTestList.java
Added GradedTestList.java
Added GradedTEstNotFoundException.java
Added GradedTestListStorage.java
Added JsonGradedTestListStorage.java
Added JsonSerializableGradedTestList.java
Added GradedTestBuilder.java
Added TypicalGradedTest.java
Updated GradedTest.java
Updated ReadingAssessment.java
Updated MidTerms.java
Updated Finals.java
Updated PracticalExams.java
Updated ExpectedGrade.java
Updated JsonAdapetedGradedTest.java
Updated Persons.java
Updated JsonAdaptedPersonTest.java

Fixed * imports error
Added essential JavaDocs


icedtea6-native_1.8.11 build error

Hi,
I am trying to build yocto/oe daisy branch using meta-java master branch. Getting the following error:
http://pastebin.com/L3pDvq62
Any ideas?

Did you resolve this?
I am getting the same error on meta-java dora branch now. It worked fine on Ubuntu 14.04 LTS but upgraded to Ubuntu 14.10 and got this error.

I resolved it, but I cant remember how. I also switched to daisy, so havent tried any Dora build for a couple of weeks.

meta-java has moved you can now find it under
git://git.yoctoproject.org/meta-java


Add KONG as an example app

Create an example configuration for http://getkong.org showing:

Running Cassandra Mesos framework
Running the KONG docker container

+1

great idea, Kong definitely fits right at home here!

+1, this would be a great example app!

Github repo: https://github.com/mashape/kong

:+1:

With today's mantl release of 0.5, we now can launch a cassandra cluster with a single curl command. We have also added a nice load balancer with Traefik. Anyone want to take a stab at launching the Kong API fronted?

I have actually started working on this!

@stevendborrelli @siddharthist happy to assist with kong related questions/setup if needed :)

Hello @siddharthist. I am trying to deploy a example using your branch (feature/kong), but I am having trouble, the cassandra cluster deployed by mantle-api get random port and not 9042 default port which is setted in kong config, furthermore the cassandra service is restarted and getting a new random port each time. Do you have the same trouble?
So I get this error when in start up of my Kong container:
[0m[34m[INFO] [0m[0mUsing configuration: /etc/kong/kong.yml
[0m[34m[INFO] [0m[0mKong version.......0.5.4
       Proxy HTTP port....8000
       Proxy HTTPS port...8443
       Admin API port.....8001
       dnsmasq port.......8053
       Database...........cassandra keepalive=60000 timeout=1000 contact_points=mantl-cassandra.service.consul:9042 keyspace=kong
[INFO] [0m[0mConnecting to the database...
[ERR] [0m[0mCassandra error: connection refused

@feliperfmarques I don't think I've seen that one before, usually port 9042 worked for me and I ran into a different error. That branch is still WIP, but I'd love help getting it working.

Hello @siddharthist, thanks for your help. I'll debug more calmly and I report back here, ok? One question: In your deploy the health state of cassandra on marathon did stay green or gray?
I understand that branch is still WIP, so I'd love to can help you in this working.

I'm asking around in the Kong community if anybody can help me with my issue. My problem is that the container appears to start sucessfully, and then exits. Mesos shows the task as "Finished", rather than "Failed". Here are the logs. Did you get any further @feliperfmarques?

@siddharthist Sorry for my delay, I was working in other codes last week, for this reason I didn't get any further.  I don't tried to deploy more times since the last time but I will to try these days and report back if I have any news. Furthermore, I also will following your issue in Kong community. Let's do This :smile:

Pull request is in! We'd love help with testing/review @feliperfmarques, @ all.  Please let me know if anything is unclear in the documentation, etc.


emacs-all-the-icons-fonts: 3.1.1 -> 3.2.0

Motivation for this change
Update to version 3.2.0
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Assured whether relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

Now only the version number is updated but the sha256 remains unchanged. Is this correct?

Now only the version number is updated but the sha256 remains unchanged. Is this correct?

It happens that only the fonts are installed in this derivation, and it looks like they have not been changed from the prior version. The emacs part is installed by other means.
I would update only to keep the version number up to date.

Fine, let's do that.


fix load of asset field editors when set value is called multiple times

Fixes https://github.com/microsoft/pxt-arcade/issues/2543
Adding DO NOT MERGE because this requires this blockly pr:
https://github.com/microsoft/pxt-blockly/pull/331

Bumping Blockly to include https://github.com/microsoft/pxt-blockly/pull/331


Filter invalid CARGO_CFG_ in build scripts

The environment variables CARGO_CFG_DEBUG_ASSERTIONS and CARGO_CFG_PROC_MACRO are set when a build script is executed.  These variables have no meaning, due to the way cfg discovery is done.  The build script code should probably avoid setting these two values to avoid any possible confusion.
Cargo has been issuing a warning for a little while for using these in cfg expressions, so I think it should be OK to just filter these two values entirely.  cfg values are collected here, so I think just filtering them there at the source should be ok.

Isn't it better to stop setting those variables altogether instead of filtering them out? If they aren't used at all, that is.

In Cargo's TargetInfo, it collects these cfg values by querying rustc.  proc_macro is set because Cargo queries all crate types at once, and proc_macro is included in the list.  rustc sets debug_assertions by default, and I don't think it is really necessary to try to unset it with -C debug_assertions=off (that is an option, but it seems easier to just filter it so that these exceptions are listed in one place).

Got it: those variables are of use on users' side, but shouldn't be on Cargo's side.
Let me do the required change.


Error when building OSX UE5.1

Hi, I've been using this great plugin since 4.6 and am having the first compilation issues on OSX for UE5.1
Building 3 actions with 3 processes...
[1/3] Compile Module.UE_OSC.cpp
In file included from /Users/[username]/Documents/Unreal Projects/MyProject/Plugins/UE-OSC/Intermediate/Build/Mac/x86_64/UnrealEditor/Development/UE_OSC/Module.UE_OSC.cpp:10:
In file included from /Users/[username]/Documents/Unreal Projects/MyProject/Plugins/UE-OSC/Source/UE_OSC/Private/Common/OscFunctionLibrary.cpp:2:
/Users/[username]/Documents/Unreal Projects/MyProject/Plugins/UE-OSC/Source/UE_OSC/Private/Common/OscUtils.h:2:10: fatal error: 'UObject\NameTypes.h' file not found
#include <UObject\NameTypes.h>
^~~~~~~~~~~~~~~~~~~~~
1 error generated.
[2/3] Link UnrealEditor-UE_OSC.dylib cancelled
[3/3] WriteMetadata MyProjectEditor.target cancelled
Command ExternalBuildToolExecution failed with a nonzero exit code

Oh sorry, I left a backslash in the file path...
It's fixed!


bash-language-server: use pnpm.fetchDeps instead of node2nix

Motivation for this change
CC @malob per https://github.com/NixOS/nixpkgs/commit/75942540fafbfeb6d4ba39db64ab1573083683d9 .
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
22.05 Release Notes (or backporting 21.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

maybe add an alias to pkgs/development/node-packages/aliases.nix?

maybe add an alias to pkgs/development/node-packages/aliases.nix?

Good idea! I didn't know about it (nix search doesn't show packages from nodePackages, because we don't recurseIntoAttrs nodejs.pkgs...).

Result of nixpkgs-review pr 317954 run on x86_64-linux 1

1 package failed to build:

bash-language-server

this does not build on my machine
@nix { "action": "setPhase", "phase": "buildPhase" }
Running phase: buildPhase
Executing npmBuildHook

> compile
> tsc -b

Finished npmBuildHook
@nix { "action": "setPhase", "phase": "installPhase" }
Running phase: installPhase
Packages are copied from the content-addressable store to the virtual store.
  Content-addressable store is at: /build/tmp.j6SpMvrkRZ/v3
  Virtual store is at:             ../../nix/store/yhg3chw7ih4scbl2nqlvx4qrra0vc4px-bash-language-server-5.3.3/lib/bash-language-server/node_modules/.pnpm
Progress: resolved 0, reused 1, downloaded 0, added 0
Progress: resolved 236, reused 236, downloaded 0, added 0
 ERR_PNPM_NO_OFFLINE_META  Failed to resolve<EMAIL_ADDRESS>in package mirror<EMAIL_ADDRESS>
This error happened while installing a direct dependency of /build/source
Progress: resolved 236, reused 236, downloaded 0, added 0

@ofborg build bash-language-server

Aish weird! It didn't fail like that when I opened the PR. Apparently this was a symptom of using the wrong pnpm version to generate pnpmDeps. Now I tested it locally, rebased onto latest master, and it worked for me.

Result of nixpkgs-review pr 317954 run on x86_64-linux 1

1 package built:

bash-language-server

This seems to have broken nixvim:
       error: Alias bash-language-server is still in node-packages.nix

Does bashls need to be removed from node-packages.nix?

Does bashls need to be removed from node-packages.nix?

it does, sorry for the breakage.


Germany is not getting the blue color (chapter 3 page 3_24.html)

In Chrome or in Opera browser, I'm getting an error with the 1st item, to get the color for the region.
The console is showing the following error.
3_24.html:109 Uncaught TypeError: Cannot read property 'region' of undefined(…)

Germany is not getting the blue color (chapter 3 page 3_24.html)
This issue sounds like a "political correcting" issue ...
in concern to an upcoming "Trump-like" german party, that's associated with the color 'blue' ...

so Germany MUST stuck to 'black' (= Merkel's Party) !!
(... laughing ;-) )

But let's come back to reality ;-))
The error comes from:
3_24_orig.html:105 Uncaught TypeError: Cannot read property 'region' of undefined(…)
that's origined by a non fitting selection (in line 89) ...
Change
d3.selectAll("g").each(function() {
to
d3.selectAll("g.overallG").each(function() {
This example 3_24 is - at last to me as upcoming to d3 -
somehow confusing, since the mixing/overlapping
of d3 methods with SVG DOM methodology ...
Best wishes,
Wolfgang


onnx 1.4.1 dependency

Hi Jk,
Thank you for the tutorials. They are extremely helpful.
Could you please help to look into the onnx==1.4.1 dependency for the yolov4/yolov3 demo and shine some lights on how can we overcame this dependency to use later onnx version to potentially open up to more models.
I understand it is mentioned here:
https://forums.developer.nvidia.com/t/tensorrt-backend-for-onnx-on-jetson-nano/74980/6

This onnx==1.4.1 requirement is due to the use of ONNX "Upsample" op to implement "upsample" layer in DarkNet models, e.g. a example "upsample" layer in the yolov4 model.
The ONNX "Upsample" op is only available in python onnx==1.4.1 (ONNX opset 9).  It has been deprecated since ONNX opset 10.  That's why my current code in this repo only works with onnx==1.4.1.
You could reference NVIDIA's latest TensorRT/samples/python/yolov3_onnx code for how to solve this.  It has been updated to onnx==1.9.0.  And it uses ONNX "Resize" op to implement DarkNet's "upsample" layer instead.
I might look into this and update the code when I have time...

@tnaduc  I've updated the "yolo_to_onnx.py" code.  It now works for onnx==1.9.0 (but won't work for onnx==1.4.1 anymore).  I've only tested it with TensorRT 8.0 so far, but I think it should work for TensorRT 7 as well.
Please give it a try.

Thank you @jkjung-avt you are amazing.


links: option to prevent external icon (for images e.g. buttons)

To prevent this:

From https://dvc.org/doc/user-guide/contributing/docs#development-environment

You can work around this issue by making a link in explicit HTML instead of Markdown. I have a PR showing how it can fix this issue at #1251

@rogermparent does it makes sense to keep the ticket open even if we apply workaround? Can we detect this type of links automatically?

If that's not easy, I think we can close this. We're using the workaround for now.

It shouldn't be too hard to simply give this a real implementation, but the question is how we do so. If we change it such that external links containing only an image are exempt, do we need to implement the behavior to re-enable the link?
I don't think this issue is anything to worry about currently with the workaround, but is worth bringing up as a concern if at any point we overhaul the blog remark pipeline.
I could implement this behavior in a Remark transformer if it's really wanted, but it looks like selective disabling isn't currently a natively configurable option so I don't believe it's as simple as changing an option.

Thanks for looking into it Roger. Sounds complicated, I think let's close this for now but feel free to reopen if you feel differently, guys.


Add better debug logging around CNI plugins

Right now, it is hard to see what plugins, config path, or actions and errors coming from calling CNI plugins.  CRI just doesn't have logging in this area.  We should add this behind the debug level to help people troubleshoot network related issues.
These changes may span into our go-cni library so that stderr or typed errors can be send to the main daemon's log stream.

@crosbymichael logging the inputs in containerd/go-cni would be very helpful. It looks like it might be easier to do this in go-cni. The next steps would be to find a good way to add logging to cni plugins and have that passed back to the containerd logger?

You can try starting K3s with environment variable CONTAINERD_LOG_LEVEL=debug and then grep the containerd logs for cni, since I suspect that's where your problem lies.


chore: remove @[simp] from bind_eq_some

I have the Mathlib fixes, but on an apparently-inaccessible-via-ssh machine right now. I'll finish this once I'm home next week.


display species concentration on mouseover

analytic & image initial concentration dialogs display location&concentration at point on mouseover
would be nice to do this elsewhere

todo

main GUI Compartment tab: display location on mouseover
main GUI Species tab: display location&concentration on mouseover

location display on mouseover resolved by #510


Making a comment by using regular expression

Hi, I am currently working on creating a very French programming language. This language must have comment statements like:
#this is a comment
entier var = 10;

I defined it in my grammar as shown:
COMMENT: /^#.*\n$/
%ignore COMMENT

Unfortunately, this is not working when I try to parse the sample code. This is the log associated :
#ceci est un commentaire

Traceback (most recent call last):
  File "/CroissantCompiler/lib/python3.12/site-packages/lark/parsers/lalr_parser_state.py", line 77, in feed_token
    action, arg = states[state][token.type]
                  ~~~~~~~~~~~~~^^^^^^^^^^^^
KeyError: '$END'

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/CroissantCompiler/spf.py", line 50, in <module>
    tree = parser.parse(line)
           ^^^^^^^^^^^^^^^^^^
  File "/CroissantCompiler/lib/python3.12/site-packages/lark/lark.py", line 658, in parse
    return self.parser.parse(text, start=start, on_error=on_error)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/CroissantCompiler/lib/python3.12/site-packages/lark/parser_frontends.py", line 104, in parse
    return self.parser.parse(stream, chosen_start, **kw)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/CroissantCompiler/lib/python3.12/site-packages/lark/parsers/lalr_parser.py", line 42, in parse
    return self.parser.parse(lexer, start)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/CroissantCompiler/lib/python3.12/site-packages/lark/parsers/lalr_parser.py", line 88, in parse
    return self.parse_from_state(parser_state)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/CroissantCompiler/lib/python3.12/site-packages/lark/parsers/lalr_parser.py", line 111, in parse_from_state
    raise e
  File "/CroissantCompiler/lib/python3.12/site-packages/lark/parsers/lalr_parser.py", line 105, in parse_from_state
    return state.feed_token(end_token, True)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/CroissantCompiler/lib/python3.12/site-packages/lark/parsers/lalr_parser_state.py", line 80, in feed_token
    raise UnexpectedToken(token, expected, state=self, interactive_parser=None)
lark.exceptions.UnexpectedToken: Unexpected token Token('$END', '') at line 1, column 1.
Expected one of:
	* __ANON_5
	* NON
	* BOOLEAN_VALUE
	* POUR
	* INTEGER_VALUE
	* SI
	* MINUS
	* IDENTIFIER
	* LSQB
	* TANT
	* PRINT
	* TEXT_VALUE
	* TYPE
	* TAILLE
	* AJOUTER

Can someone tell me what's wrong ?

Can you provide a full python script that results n this error message? The error message indicates that the file is empty, which doesn't seem correct.

Sure !
the test set (test.spf, since I decided to call my language to spf):
entier var = 10;
entier var = 10 + 10 * 2;
10 / 10;
10 < 11;
11 < 10;
10 <= 10;
10 >= 10;
faux vaut vrai;
faux != vrai;
faux;
vrai;
faux et vrai;
vrai et vrai;
non vrai et faux;
"test";
"test"[0];
"tu" + "es";
taille "test";
[];
[1];
[1 , [2, 3]];
[1:3];
[0, 1, 1];
taille [0, 1, 1];
[1, 2][0];
[1,2,[3,4]];
entier x = 3;
booléen z = x < 4;
ajouter 2 dans [1];
ajouter 3 dans [1, 2];
ajouter [3, 4] dans [1, 2];
entier a = 3;
entier a = a + 1;
#ceci est un commentaire
entier a = a + 1;

the python code only takes this file to parse it
from sys import platlibdir, argv

from lark import Lark, Token, Transformer, Tree, v_args

from modules.statement import Statement
from modules.variable import global_context

debug = False

class Interpreter(Transformer):

    @v_args()
    def interpret(self, args, statement_type=Statement()):
        if isinstance(args, Tree):
            type = args.data.upper()
            return statement_type[type](self.interpret(args.children))
        elif isinstance(args, Token):
            return args.value
        elif len(args) == 1 and isinstance(args[0], Token):
            return args[0].value
        else:
            return [self.interpret(node) for node in args]

def memory():
    print("------MEMOIRE---------")
    for variable in global_context.keys():
        print(global_context[variable])

if __name__ == "__main__":
    print(argv)
    with open("spf.lark", "r") as grammar:
        interpreter = Interpreter()
        parser = Lark(
            grammar, start="statement", parser="lalr", transformer=interpreter
        )
        """
        while True:
            tree = parser.parse(input(">"))
            result = interpreter.interpret(tree)
            print(result)
            print(global_context)
        """
        if "--debug" in argv[1:] or "-d" in argv[1:]:
            debug = True
        with open("modules/test.spf", "r") as file:
            for line in file:
                print("----------------------------------")
                print(f"TEST : " + line)
                tree = parser.parse(line)
                result = interpreter.interpret(tree)
        if "--memory" in argv[1:] or "-m" in argv[1:]:
            memory()

You didn't include spf.lark, which is the most important bit 🤷
But probably your grammar just doesn't support an empty program. (comments don't count as syntax)

Hey, thanks a lot for your help !
Here's our grammar (sorry to not have included it beforehand) :
?start: statement+ -> interpret

    ?statement: assignment ";"
        | condition ";" -> condition
        | loop ";" -> loop
        | expression ";"
        | PRINT expression ";" -> print

    ?assignment: TYPE IDENTIFIER "=" expression -> initialization
        | TYPE IDENTIFIER -> declaration

    ?expression: comparison
        | arithmetic_op
        | string_e
        | boolean_e
        | list_e
        | variable

    ?block: "{" statement* "}"

    ?condition: "si" boolean_e "alors" block ("sinon" block)? -> if_else

    ?loop: "tant" "que" boolean_e "faire" block -> while
        | "pour" "chaque" TYPE IDENTIFIER "dans" expression "faire" block -> for

    ?comparison: expression ("vaut" | "==") expression -> equals
        | expression ("ne vaut pas" | "!=") expression -> not_equal
        | expression "<=" expression -> less_equal
        | expression ">=" expression -> greater_equal
        | expression "<" expression -> less
        | expression ">" expression -> greater

    ?arithmetic_op: INTEGER_VALUE -> int_atomic_value
        | "-" expression -> int_negation
        | expression "+" expression -> addition
        | expression "-" expression -> subtraction
        | expression "*" expression -> multiplication
        | expression "/" expression -> division

    ?boolean_e: BOOLEAN_VALUE -> bool_atomic_value
        | "non" boolean_e -> bool_negation
        | boolean_e "et" boolean_e -> conjunction
        | boolean_e "ou" boolean_e -> disjunction

    ?string_e: TEXT_VALUE -> string_atomic_value
        | string_e "+" string_e -> concat
        | "taille" string_e -> size
        | string_e "[" arithmetic_op "]" -> index

    ?list_e:  "[]" -> list_bc //basis case
        | "[" sequence "]" -> list_gc //general case
        | "[" arithmetic_op ":" arithmetic_op "]" -> range_list
        | list_e "+" list_e -> concat_list
        | list_e "["arithmetic_op"]" -> index_list
        | "taille" list_e -> size_list
        | "ajouter" expression "dans" list_e -> add

    ?sequence: expression ("," expression)*

  //  ?boolean: expression ("<" | ">" | "<=" | ">=") expression -> comparison
  //      | "non" boolean -> not

    ?variable: IDENTIFIER

// Tokens (type has a priority over identifier)
TYPE.1: /entier|texte|liste|booléen/

PRINT: "afficher"

IDENTIFIER: /[_a-zA-Zé][\wé_]*/
TEXT_VALUE.1: /"[^"]*"/
INTEGER_VALUE.1: /(0)|((-)?[1-9][0-9]*)/
BOOLEAN_VALUE.1: /faux|vrai/

DELIMITER: ";"

COMMENT: /^#.*\n$/
%ignore COMMENT
%ignore "\n"
%ignore " "

How could we define a rule to handle empty programs as you said since it, in fact, probably doesn't support it ?
We already tried to add things like "$" and "$END" but to no luck..
Thanks again for your help ^^

Just change statement+ to statement*
On Sun, Mar 31, 2024 at 15:43 KazaWai @.***> wrote:

Hey, thanks a lot for your help !
Here's our grammar (sorry to not have included it beforehand) :
?start: statement+ -> interpret
?statement: assignment ";"
    | condition ";" -> condition
    | loop ";" -> loop
    | expression ";"
    | PRINT expression ";" -> print

?assignment: TYPE IDENTIFIER "=" expression -> initialization
    | TYPE IDENTIFIER -> declaration

?expression: comparison
    | arithmetic_op
    | string_e
    | boolean_e
    | list_e
    | variable

?block: "{" statement* "}"

?condition: "si" boolean_e "alors" block ("sinon" block)? -> if_else

?loop: "tant" "que" boolean_e "faire" block -> while
    | "pour" "chaque" TYPE IDENTIFIER "dans" expression "faire" block -> for

?comparison: expression ("vaut" | "==") expression -> equals
    | expression ("ne vaut pas" | "!=") expression -> not_equal
    | expression "<=" expression -> less_equal
    | expression ">=" expression -> greater_equal
    | expression "<" expression -> less
    | expression ">" expression -> greater

?arithmetic_op: INTEGER_VALUE -> int_atomic_value
    | "-" expression -> int_negation
    | expression "+" expression -> addition
    | expression "-" expression -> subtraction
    | expression "*" expression -> multiplication
    | expression "/" expression -> division

?boolean_e: BOOLEAN_VALUE -> bool_atomic_value
    | "non" boolean_e -> bool_negation
    | boolean_e "et" boolean_e -> conjunction
    | boolean_e "ou" boolean_e -> disjunction

?string_e: TEXT_VALUE -> string_atomic_value
    | string_e "+" string_e -> concat
    | "taille" string_e -> size
    | string_e "[" arithmetic_op "]" -> index

?list_e:  "[]" -> list_bc //basis case
    | "[" sequence "]" -> list_gc //general case
    | "[" arithmetic_op ":" arithmetic_op "]" -> range_list
    | list_e "+" list_e -> concat_list
    | list_e "["arithmetic_op"]" -> index_list
    | "taille" list_e -> size_list
    | "ajouter" expression "dans" list_e -> add

?sequence: expression ("," expression)*

//  ?boolean: expression ("<" | ">" | "<=" | ">=") expression -> comparison
//      | "non" boolean -> not
?variable: IDENTIFIER

// Tokens (type has a priority over identifier)TYPE.1: /entier|texte|liste|booléen/
PRINT: "afficher"
IDENTIFIER: /[a-zA-Zé][\wé]/TEXT_VALUE.1: /"[^"]"/INTEGER_VALUE.1: /(0)|((-)?[1-9][0-9])/BOOLEAN_VALUE.1: /faux|vrai/
DELIMITER: ";"
COMMENT: /^#.\n$/%ignore COMMENT%ignore "\n"%ignore " "
How could we define a rule to handle empty programs as you said since it,
in fact, probably doesn't support it ?
We already tried to add things like "$" and "$END" but to no luck..
Thanks again for your help ^^
—
Reply to this email directly, view it on GitHub
https://github.com/lark-parser/lark/issues/1401#issuecomment-2028747455,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAFSSSAOMHOZLH25ITFDKILY3AHHZAVCNFSM6AAAAABFQKLVRWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMRYG42DONBVGU
.
You are receiving this because you commented.Message ID:
@.***>


App crashes when alarm is triggered

The app cannot display the "alarm triggered" UI, so whenever the alarm goes off, the app will crash and it will be impossible to open it to disarm/cancel the alarm. Similar to #6, I think this is a case of another missing image.

No longer a problem with the ability to invert the color of images


Update comments in src to clarify arguments to loadJs

The sourcecode indicates that a fourth argument to loadJs is possible, as arg[3]:
https://github.com/muicss/loadjs/blob/master/src/loadjs.js#L216
...however, I'm not sure this is correct, I believe the third argument would be ignored?   I think arg[2] could have the comment:
 * @param {Function|Object} [arg2] - The success or error callback or object literal with success/error arguments, numRetries, etc.

...or something more snappy!
Similarly, as per the example:
loadjs(['/path/to/foo.js', '/path/to/bar.js'], {
  success: function() { /* foo.js and bar.js loaded in series */ },
  async: false
});

...arg[1] can actually be an object literal, and not just {(string|Function)} as the comment suggests.

Fixed! Thanks for the suggestion.
https://github.com/muicss/loadjs/blob/master/src/loadjs.js#L211-L219


add __traits(child, parent, member)

See https://github.com/dlang/dmd/pull/11442

The rendered HTML looks correct, please amend and force push to make it green.

alright this is green now, ping to the dlang.org team to merge this.


zscore, zunion, and zunionstore

In the Java implementation for Glide, add GlideString (binary safe string) support for zscore, zunion, and zunionstore.

Please update PR description to be more detailed. What client are you working on?

Added integ tests in comments, they will be uncommented once PR 1648 is merged

These functions were implemented and merged in other PRs


Prowler : Integrate this tool for regular scans

https://github.com/prowler-cloud/prowler
Prowler is a command line tool that helps you with AWS security assessment, auditing, hardening and incident response.
It follows guidelines of the CIS Amazon Web Services Foundations Benchmark (49 checks) and has more than 190 additional checks including related to GDPR, HIPAA, PCI-DSS, ISO-27001, FFIEC, SOC2 and others.

Prowler has been integrated as a shell script that can be activated from reference buildspec used by SPA. Add an environment variable WITH_PROWLER in your settings on OU or on accounts where you want to run prowler on maintenance window. This has been pushed to production some months go.


Consider buffer radius in addition to H3 resolution when counting points in the aggregated bins of H3-hexagons

Hello,
I am focussing on the H3-JS example from
https://observablehq.com/@nrabinowitz/h3-tutorial-using-point-layers?collection=@nrabinowitz/h3-tutorial
Within the provided code, there is a function (below) that counts the number of points in each of the hexagons after the binning and embeds these as attributes within the geoJSON.
function _countPoints(h3,h3Resolution,normalizeLayer){return(
function countPoints(geojson) {
  const layer = {};
  geojson.features.forEach(feature => {
    const [lng, lat] = feature.geometry.coordinates;
    const h3Index = h3.geoToH3(lat, lng, h3Resolution);
    layer[h3Index] = (layer[h3Index] || 0) + 1;
  });
  return normalizeLayer(layer, true);
}
)}

However, in addition to the h3Resolution, I was hoping to integrate Buffer Radius in this calculation.
You see I am fully using the example. Thus, the user can choose values for both: h3Resolution and Buffer Radius.
That means that the resulting geojson should shoe the counts after considering both the values: h3Resolution and Buffer Radius.
Finally we need a geojson which has the features, together with the h3 cells, h3 resolution, buffer radius and the number of points contained within.
I would appreciate any guidance on this small question.

I'm not clear on what's intended here. Is the Buffer Radius in grid distance? I.e. if I run countPoints(res, radius) you want the count of all points that are both in the specific h3 cell and in its neighbors at a given radius?
This could look like:
function countPoints(geojson, h3Resolution, bufferRadius) {
  const layer = {};
  geojson.features.forEach(feature => {
    const [lng, lat] = feature.geometry.coordinates;
    const h3Index = h3.geoToH3(lat, lng, h3Resolution);
    const neighbors = h3.kRing(h3Index, bufferRadius);
    for (const neighbor of neighbors) {
      layer[neighbor] = (layer[neighbor] || 0) + 1;
    }
  });
  return normalizeLayer(layer, true);
}

Yes, that is what I needed.
Thank you.


Python Challenge: brain_teasers > score_after_flipping_matrix

[x] PR's title includes the challenge's name and language
[x] PR has short and clear description of the challenge
[x] PR has appropriate labels and milestones for easy identification
[x] PR it is assigned to the owner
[x] reviewers are assigned
[x] the PR contributes only one focused change
[x] the branch is up to date with main/master
[x] the code works when pulled and run locally
[x] all conflicts are resolved (if any)
[x] It is linked to an issue in the appropriate column of the project board
[x] feedback is addressed (if any, and if it is appropriate feedback.)

README Documentation

[x] The solution is documented in /src/README.md
[x] The markdown source is formatted
[x] Spelling and grammar is correct in all text
[x] The markdown looks correct when you preview the file
[x] All links and images work
[x] The README documents the solution's behavior, strategy(ies) and implementation(s)
[x] There are use cases in code blocks to illustrate the function's behavior

Python Files

[x] There is a module header
[x] There is a module docstring
[x] File names are in snake_case
[x] Test files are named test_<module_name>.py

Function Docstring

[x] Behavior description
[x] Parameter description
[x] Return value description
[x] Include any assumptions
[x] Include 3 or more (passing!) doctests
[x] Include 1-2 use cases (if necessary)

Function Implementation

[x] The solution is not is not copied from djeada
[x] The code is auto-formatted
[x] The code has no (reasonable) linting mistakes
[x] Variables are named with snake_case
[x] The function has a clear and helpful name
[x] The file's name matches the function name
[x] The code follows the strategy as simply as possible
[x] Variable names are clear and helpful
[x] Comments explain the strategy (if necessary)
[x] There are type annotations
[x] (challenge) The code includes defensive assertions

Unit Test Suite

[x] The test class has a helpful name in PascalCase
[x] The test class has a docstring
Each unit test has

[x] A helpful name
[x] A clear docstring
[x] Only one assertion

[x] All tests pass
[x] There are tests for defensive assertions
[x] There are tests for boundary cases
[x] Test suite includes black-box and glass-box tests

LGTM


Update README.md

Thank you :+1:
LGTM, I'll merge after my holidays :wink:

Merged as 3b69463e61becd3e36e27abb3bb43eb77389164c.


GSB: Remove a couple of well-formedness assertions [5.5]

The underlying issue here won't be fixed in 5.4 and 5.5, so remove the
asserts to avoid allowing code in no-asserts builds that is rejected in
asserts builds.
Any code that builds with this assert commented out might fall victim
to an ABI break once the bug with same-type requirement minimization
is actually fixed.
"Fixes" https://bugs.swift.org/browse/SR-14776.

@swift-ci please test

Build failed
Swift Test Linux Platform
Git Sha - 304a1b71a33f2b4affbb133ba1e7b256d5bf203b

Build failed
Swift Test OS X Platform
Git Sha - 304a1b71a33f2b4affbb133ba1e7b256d5bf203b

@swift-ci please test

Build failed
Swift Test Linux Platform
Git Sha - 344e60d5a7876a36705919b9548ecbc00e079701

Build failed
Swift Test OS X Platform
Git Sha - 344e60d5a7876a36705919b9548ecbc00e079701

@swift-ci please test

Build failed
Swift Test Linux Platform
Git Sha - 344e60d5a7876a36705919b9548ecbc00e079701

Build failed
Swift Test OS X Platform
Git Sha - 344e60d5a7876a36705919b9548ecbc00e079701


0.0.1 was not released

Here are details...
https://github.com/holixon/axon-server-testcontainer/runs/4196121276?check_suite_focus=true

Fixed...
[INFO]  * Upload of locally staged artifacts finished.
[INFO]  * Closing staging repository with ID "ioholixon-1028".

Waiting for operation to complete...
..............

[INFO] Remote staged 1 repositories, finished with success.
[INFO] Remote staging repositories are being released...

Waiting for operation to complete...
.......

[INFO] Remote staging repositories released.
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  02:01 min
[INFO] Finished at: 2021-11-13T12:55:38Z
[INFO] ------------------------------------------------------------------------


Error: Maximum call stack size exceeded

When run the vscode extension, get the following error
[Error - 19:51:45] Request textDocument/semanticTokens/range failed.
  Message: Request textDocument/semanticTokens/range failed with message: Maximum call stack size exceeded
  Code: -32603

Langium version: 0.4.0
Steps To Reproduce

The semantic token provider is implemented as follows

export class MediatorGrammarSemanticTokenProvider extends AbstractSemanticTokenProvider {
    protected highlightElement(node: AstNode, acceptor: SemanticTokenAcceptor): void {
        if (isTypeDefinition(node)) {
            acceptor({
                node,
                feature: 'alias',
                type: SemanticTokenTypes.type
            });
        }
    }
}

A minimal grammar to reproduce

entry Program:
    TypeDefinition*;

TypeDefinition infers TypeDefinition:
    'typedef' name=TypeSpecifier 'as' alias=ID ';';

TypeSpecifier:
    (
        'int' | 'real' | 'char' | 'bool' | UnionCompositeTypeSpecifier
    )
    ('[' Expression? ']')?
    ('init' init=Expression)?
;

UnionCompositeTypeSpecifier:
    'union' '(' TypeSpecifier (',' TypeSpecifier)* ')';

Expression:
    Addition;

Addition infers Expression:
    Multiplication ({infer BinaryExpression.left=current} operator=('+' | '-') right=Multiplication)*;

Multiplication infers Expression:
    PrimaryExpression ({infer BinaryExpression.left=current} operator=('*' | '/') right=PrimaryExpression)*;

PrimaryExpression infers Expression:
    '(' Expression ')' |
    {infer NumberLiteral} value=(INT | FLOAT);

terminal ID returns string: /[a-zA-Z_]\w*/;
terminal FLOAT returns number: /\d+\.\d*/;
terminal INT returns number: /[1-9]\d*|0/;

hidden terminal WS: /\s+/;
hidden terminal ML_COMMENT: /\/\*[\s\S]*?\*\//;
hidden terminal SL_COMMENT: /\/\/[^\n\r]*/;

NOTE: the error disappears when the UnionCompositeTypeSpecifier rule is removed.

The current behavior
When running the plugin, open the file and write:
typedef int as myint;

then the error shows up, and myint is not correctly colored.
The expected behavior
When the UnionCompositeTypeSpecifier rule is removed, myint gets correctly colored, and the error disappears.

Hey @luan-xiaokun,

When the UnionCompositeTypeSpecifier rule is removed

That kind of makes perfect sense, since it's not a legal rule. Our validations don't catch it (yet), but having multiple unassigned rule calls after another don't work as expected (as in: undefined behavior). Something like the following should resolve the issue:
UnionCompositeTypeSpecifier:
    'union' '(' specifiers+=TypeSpecifier (',' specificers+=TypeSpecifier)* ')';

Can you try that and see whether that resolves the issue?

It works, thanks for you help!
My complete grammar seems to have many such errors, so it seems that I should spend more time learning the langium grammar.


python: no completion for controller.A.on_event

Describe the bug
Python autocomplete (maybe js too, am in a python tutorial) seems to think controller === controller.A and only gives options like .any_button

To Reproduce
Steps to reproduce the behavior:

Go to a python project
type controller.A
expect to see on_event
See error

Expected behavior
should get a valid completion

javascript completion for controller.A.onEvent results in code with error:
controller.A.onEvent.Pressed, function() {

})

Still repros.


[bug] cmake building failed

I compile on Linux and arm64 machines, but using cmake will result in compilation failure. The variable ./build/.config:103:CONFIG_HOST_X86_64=y value in the .config file generated by cmake was found to be incorrect and cannot be set by cmake. I'm not sure if there are any other mistakes. The configure.sh tool can automatically generate, but it cannot generate files in the build folder and cannot be used by cmake.

@zyy37 thank you for reporting the issue! I think the issue is:
choice
        prompt "Host CPU Type"
        default HOST_X86_64

So, currently NuttX building system (both Makefile and CMake) are not able to autodetect the host for SIM target.
Maybe if you run "make menuconfig" before "cmake --build build" it will be fixed. Unfortunately I don't have an ARM64 Mac to confirm it.
@pkarashchenko or @cederom could you please confirm?

Perhaps Makefile has more comprehensive features, so I will try to use it as much as possible. Thanks


nvme and mmcblk installation fails

Cool script, congrats!
I suspect wrong grep clause in /etc/fstab generation for new system - ZBM_install() routine. If disk name ends with a digit, like 'nvme0n1', ''mmcblk1n1' or similar, 'p' is added to partition before the partition number - 'nvme0n1p1', etc.
I suggest replace grep "${DISK}${BOOT_PART}" with something like grep -E "^/dev/${DISK}(p)?${BOOT_PART}", or similar.

Would you be so kind to send the output of "ls -la /dev/disk/by-id" taken from a machine with nvme or mmcblk and with one of those disks with one or two partitions created, please?
I don't have any at hand at the moment

This should not be the case as I'm using disks by-id.
For example, part 2 of an nvme disk should come across as nvme-WDC_WDS500G2B0C-00PXH0-2453AA234312-part2.
I'm about to test this on a machine I need to reinstall with ubuntu 24.04 on nvme. Please, feel free to post here more information about your issue (screenshots, logs, zpool output, etc)

This is fixed now. Thank you for the head-up

done

fixed as per VVShh recommendation


Formatting is not applied correctly on 'Adding ssh-key steps ..'

Code of Conduct

[X] I have read and agree to the GitHub Docs project's Code of Conduct

What article on docs.github.com is affected?
I am noticing the issue in this article. When I switched the tab to Windows I faced this issue in the formatting for steps in the Adding your SSH key to the ssh-agent section. I have attached the screenshot and video recording of the same. I also tried refreshing the browser but issue persists.
Screenshot:

Video:
https://github.com/github/docs/assets/45136568/7c270f0e-b7d0-4aa0-8a72-bfd7c680e72c
I am using a mac mini with macOS Venture 13.4 and my browser is Google chrome (Version 115.0.5790.114 (Official Build) (arm64)).
For macOS and linux, the formatting for the steps looks correct but for windows tab, the formatting is not correct.
What changes are you suggesting?
I suggest that the issue should be fixed as soon as possible. The formatting should be seen equivalent for all macOS, windows and linux platform tabs in the docs.
This is required as new readers might get bad UI experience when referring the docs.
Fixing this issue will help the readers of the docs to be able to refer the docs smoothly.
Additional information
No response

@Mallikarjunople this should be fixed as of today in github/docs#27174.

@Mallikarjunople Thanks for opening an issue! As @dane stated, this was fixed internally. If you are still having issues with it, let me know and I'll reopen, but going ahead and closing it now 💛
Thank you for your interest in improving GitHub Docs! :sparkling_heart:


Contrast normalization

Original SNR Map

CLAHE
Using cv2 implementation.

It isn't clear whether this is useful, but probably not by the above reason.

SNR-stratified histogram equalization (SSHE)
Attempted a custom mapping between stratified source intensity ranges and destination intensity ranges. I think I got the details right because this looks reasonable.
With SNR-stratification + HE on each stratum, we get to chop off the big low-SNR peak. BUT when you chop off the big tail, the important data histogram is already pretty stretched/equalized. So HE doesn’t end up helping much anyway

HE on RLI images
CLAHE
RLI as a tif for CLAHE. Clearly artifacts introduced, but in some important spots it does work:

On the other hand, the new rig DIC images are usually good enough on contrast, though the benefit is still there sometimes:

SSAHE
(All still on Kate's 09_04_01, received on 11/23/22)
There’s an interesting tradeoff with that method (custom SSAHE) based on the number and width of strata I choose. But it does work, generally speaking -- it’s just not as “adaptive” as CLAHE because I have to make sure that each stratum gets mapped into its own non-overlapping destination stratum in the final histogram.  Otherwise the low-SNR strata out-compete their high-SNR neighbors, especially if the strata are small in width. Adding in this feature limits how much equalization can happen, especially if the number of strata is high.

Takeaways:

CLAHE for DIC images – possibly able to match visible-light cells to fluorescence changes
SSAHE as a replacement for GMM – worth the comparison. Even if performance is similar, it is possibly more justifiable / intuitive

11/16/22
Example analysis with contrast norm versus with with GMM

No. clusters: 71

10/14/22 with CN

Slice 4 Loc 1 Rec 1 Example

Date
Slice/Loc
Mean snr
Number ROIs
Line

10-14-22
01_01
3.409
76
kv2.1hVOS 3.0 / PV-Cre

10-14-22
02_01
3.553
70
kv2.1hVOS 3.0 / PV-Cre

10-14-22
03_01
3.380
80
kv2.1hVOS 3.0 / PV-Cre

10-14-22
04_01
3.508
80
kv2.1hVOS 3.0 / PV-Cre

Average snr (weighted by # ROIs): 3.46
Total ROI count: 306

10/21/22 with CN

Slice 1 Loc 1 Rec 4 Example

Date
Slice/Loc
Mean snr
Number ROIs
Line

10-21-22
01_01
3.222
30
kv2.1hVOS 3.0 / PV-Cre

10-21-22
01_02
3.464
30
kv2.1hVOS 3.0 / PV-Cre

10-21-22
01_03
3.456
15
kv2.1hVOS 3.0 / PV-Cre

Average snr (weighted by # ROIs): 3.37
Total ROI count: 75


also run the compress benchmarks

So the issue with this is that our benchmark display website is pretty artisanal crafted for aggregating different runs of same query together and it assumes some logic of the benchmark name. Would make sure that you can parse still display the html properly

I would try to trim down end to end - medicare/compress. Not sure if there's a way to simplify this benchmark or od we just let it run


SOX-124 update texts

Jira: SOX-124
KBC: https://github.com/keboola/connection/pull/4476
Before asking for review make sure that:
Checklist

[x] New client method(s) has tests
[ ] Apiary file is updated

Release

[x] I gave the PR a proper label:

major (BC break)
minor (new feature)
patch (backwards compatible fix)
no release (just test changes)

chybi mi jeste apiary


[OPPRO-346] Follow substrait's naming for bitwise functions

This PR depends on https://github.com/substrait-io/substrait/pull/370.
test by CH[[238]]

@zzcclp, we have a patch merged to substrait (https://github.com/substrait-io/substrait/pull/370). Let's follow substrait's naming for bitwise functions. Could you please help do some fixing in CH? Thanks!

@loneylee please help to modify in CH, thanks.

https://github.com/Kyligence/ClickHouse/pull/238

retest this please


Extend WriteMetricsTransform in Ingestion to write feature value stats to StatsD

What this PR does / why we need it:
This PR adds a step (blue coloured box) to write stats for numerical value of every feature to StatsD.

A fixed window (default to 30s) will first be applied, before the stats calculation of each feature. This is to ensure the metrics collector is not overwhelmed with metrics data (and drop the metrics as a result). For validation of features by value, an aggregated windowed view of the values is also usually adequate.
The following gauge metrics will be sent to StatsD for every feature at the end of the window:

feature_value_min
feature_value_max
feature_value_mean
feature_value_percentile_50
feature_value_percentile_90
feature_value_percentile_95

Reason for using gauge metric type as opposed to histogram/timings in StatsD is because StatsD only support positive values for histogram metric types, while numerical feature values can be of any double value.

Which issue(s) this PR fixes:

Related to #172
Does this PR introduce a user-facing change?:

/retest

/lgtm


Web support

Have any work or branch for web support?

@RicardoHds
Thanks for using the plugin.
I did not try it for web support as of now. I'll keep you updated on this.
Thanks

Any news on this?

@wer-mathurin  If you only want web support, I made a JSQR wrapper for flutter here: https://github.com/treeder/jsqr_flutter

@treeder Thanks, I didn't found it off the bat when searching on pub.dev.  Probably adjusting the readme to include "QR Code Scan" can boost the popularity of your plugin!  And thanks again for taking the time to reply :-)

@wer-mathurin Good tip, done.

It would be great to include web support in the library 🙏🙏🙏


[BUG] - If 'num reconnect attempts' setting is > 0, reconnects will be attempted even when a disconnect is triggered by timeout.

UE Version:
5.2
Problem component
Frontend
Description
If num reconnect attempts setting is greater than 0, then reconnects will be attempted even when a disconnect is triggered by timeout.
Expected behavior
Reconnects should not be attempted when the stream is closed due to timeout.

Ok


Update mod.rs

Description
add chunk size limit for starknet_getEvents method

Summary by CodeRabbit

New Features

Introduced a new method to fetch events with a specified limit, enhancing flexibility in event retrieval.
Added a constant to define the maximum chunk size for event fetching.

Improvements

Updated existing event fetching logic to utilize the new method for better control over the number of events returned.

Isn't this already tackled by #2644?


x/crypto/ssh: OpenSSH hanging on loading shell prompt on 7.3p1+

What version of Go are you using (go version)?
1.8
What operating system and processor architecture are you using (go env)?
GOARCH="amd64"
GOBIN=""
GOEXE=""
GOHOSTARCH="amd64"
GOHOSTOS="darwin"
GOOS="darwin"
GOPATH="/Users/cfdojo/workspace/diego-release"
GORACE=""
GOROOT="/usr/local/Cellar/go/1.8/libexec"
GOTOOLDIR="/usr/local/Cellar/go/1.8/libexec/pkg/tool/darwin_amd64"
GCCGO="gccgo"
CC="clang"
GOGCCFLAGS="-fPIC -m64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -fdebug-prefix-map=/var/folders/z7/g9fftkv12493psx5nsmpcslm0000gn/T/go-build598478375=/tmp/go-build -gno-record-gcc-switches -fno-common"
CXX="clang++"
CGO_ENABLED="1"
PKG_CONFIG="pkg-config"
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
What did you do?
Thanks to @keymon for the simple repro steps below in https://github.com/cloudfoundry/diego-ssh/issues/31
# Get the diego release for the dependencies
git clone https://github.com/cloudfoundry/diego-release
cd diego-release
./scripts/update

# Use diego release as GOPATH
export GOPATH=$(pwd)

# Compile sshd
CGO_ENABLED=0 go build -a -installsuffix static code.cloudfoundry.org/diego-ssh/cmd/sshd

# Run sshd without authentication.
./sshd \
	--allowedKeyExchanges= \
	--address=<IP_ADDRESS>:2223 \
	--allowUnauthenticatedClients=true \
	--inheritDaemonEnv=true \
	--allowedCiphers= \
	--allowedMACs= \
	--logLevel=debug \
	--debugAddr=

# In another shell attempt to ssh
ssh -p 2223 -vvv localhost

What did you expect to see?
ssh session successfully loads interactive shell prompt
What did you see instead?
OpenSSH_7.5p1, OpenSSL 1.0.2k  26 Jan 2017
...
debug3: send packet: type 21
debug2: set_newkeys: mode 1
debug1: rekey after<PHONE_NUMBER> blocks
debug1: SSH2_MSG_NEWKEYS sent
debug1: expecting SSH2_MSG_NEWKEYS
debug3: receive packet: type 21
debug1: SSH2_MSG_NEWKEYS received
debug2: set_newkeys: mode 0
debug1: rekey after<PHONE_NUMBER> blocks
debug2: key: /Volumes/dannycf/id_rsa (0x7ff6e8900690), agent
debug2: key: keypair/id_rsa_bosh (0x7ff6e89005f0), agent
debug2: key: /Users/cfdojo/.ssh/id_rsa (0x0)
debug2: key: /Users/cfdojo/.ssh/id_dsa (0x0)
debug2: key: /Users/cfdojo/.ssh/id_ecdsa (0x0)
debug2: key: /Users/cfdojo/.ssh/id_ed25519 (0x0)
debug3: send packet: type 5
debug3: receive packet: type 6
debug2: service_accept: ssh-userauth
debug1: SSH2_MSG_SERVICE_ACCEPT received
debug3: send packet: type 50
debug3: receive packet: type 52
debug1: Authentication succeeded (none).
Authenticated to localhost ([<IP_ADDRESS>]:2223).
debug1: channel 0: new [client-session]
debug3: ssh_session2_open: channel_new: 0
debug2: channel 0: send open
debug3: send packet: type 90
debug1: Entering interactive session.
debug1: pledge: network
debug3: receive packet: type 91
debug2: callback start
debug2: fd 5 setting TCP_NODELAY
debug3: ssh_packet_set_tos: set IP_TOS 0x10
debug2: client_session2_setup: id 0
debug2: channel 0: request pty-req confirm 1
debug3: send packet: type 98
debug2: channel 0: request shell confirm 1
debug3: send packet: type 98
debug2: callback done
debug2: channel 0: open confirm rwindow 2097152 rmax 32768
debug3: receive packet: type 99
debug2: channel_input_status_confirm: type 99 id 0
debug2: PTY allocation request accepted on channel 0
debug3: receive packet: type 99
debug2: channel_input_status_confirm: type 99 id 0
debug2: shell request accepted on channel 0

Hangs here

Some interesting things to note

This works in 7.2 and under, but not 7.3+
Non-interactive ssh sessions work as intended

> ssh -p 2223 -vvv localhost 'echo Success'
debug3: send packet: type 21
debug2: set_newkeys: mode 1
debug1: rekey after<PHONE_NUMBER> blocks
debug1: SSH2_MSG_NEWKEYS sent
debug1: expecting SSH2_MSG_NEWKEYS
debug3: receive packet: type 21
debug1: SSH2_MSG_NEWKEYS received
debug2: set_newkeys: mode 0
debug1: rekey after<PHONE_NUMBER> blocks
debug2: key: /Volumes/dannycf/id_rsa (0x7fb52c200e90), agent
debug2: key: keypair/id_rsa_bosh (0x7fb52ac0c970), agent
debug2: key: /Users/cfdojo/.ssh/id_rsa (0x0)
debug2: key: /Users/cfdojo/.ssh/id_dsa (0x0)
debug2: key: /Users/cfdojo/.ssh/id_ecdsa (0x0)
debug2: key: /Users/cfdojo/.ssh/id_ed25519 (0x0)
debug3: send packet: type 5
debug3: receive packet: type 6
debug2: service_accept: ssh-userauth
debug1: SSH2_MSG_SERVICE_ACCEPT received
debug3: send packet: type 50
debug3: receive packet: type 52
debug1: Authentication succeeded (none).
Authenticated to localhost ([<IP_ADDRESS>]:2223).
debug1: channel 0: new [client-session]
debug3: ssh_session2_open: channel_new: 0
debug2: channel 0: send open
debug3: send packet: type 90
debug1: Entering interactive session.
debug1: pledge: network
debug3: receive packet: type 91
debug2: callback start
debug2: fd 5 setting TCP_NODELAY
debug3: ssh_packet_set_tos: set IP_TOS 0x08
debug2: client_session2_setup: id 0
debug1: Sending command: echo Success
debug2: channel 0: request exec confirm 1
debug3: send packet: type 98
debug2: callback done
debug2: channel 0: open confirm rwindow 2097152 rmax 32768
debug3: receive packet: type 99
debug2: channel_input_status_confirm: type 99 id 0
debug2: exec request accepted on channel 0
Success
debug3: receive packet: type 98
debug1: client_input_channel_req: channel 0 rtype exit-status reply 0
debug3: receive packet: type 97
debug2: channel 0: rcvd close
debug2: channel 0: output open -> drain
debug2: channel 0: close_read
debug2: channel 0: input open -> closed
debug3: channel 0: will not send data after close
debug2: channel 0: obuf empty
debug2: channel 0: close_write
debug2: channel 0: output drain -> closed
debug2: channel 0: almost dead
debug2: channel 0: gc: notify user
debug2: channel 0: gc: user detached
debug2: channel 0: send close
debug3: send packet: type 97
debug2: channel 0: is dead
debug2: channel 0: garbage collecting
debug1: channel 0: free: client-session, nchannels 1
debug3: channel 0: status: The following connections are open:
  #0 client-session (t4 r0 i3/0 o3/0 fd -1/-1 cc -1)

debug3: send packet: type 1
Transferred: sent 1744, received 1084 bytes, in 0.0 seconds
Bytes per second: sent 212555.0, received 132115.6
debug1: Exit status 0

I won't have time to look at this this week. Some questions:

what does a stacktrace from Go look like?

is there a recent commit to crypto/ssh that introduced this?

 We were however noticing this behavior in https://github.com/cloudfoundry/diego-ssh/issues/30 which at the time was using https://github.com/golang/crypto/commit/d68c3e (a fairly old commit). Upon updating crypto to master we were still seeing this behavior.

Actually it turns out the issue was on our end. OpenSSH 7.3+ introduces a new opcode specified here that we didn't correctly process in our ssh server. Credit to @ematpl and @jvshahid for digging through the stacktrace and finding that. Closing this issue out.

Thanks, @caod123 ! For some reason that link is 404ing, but here's an up-to-date link to a later draft: https://tools.ietf.org/html/draft-sgtatham-secsh-iutf8-06.


runtime: golang 1.14.rc1 3-5% performance regression from golang 1.13 during protobuf marshalling

$ go1.14rc1 version
go version go1.14rc1 linux/amd64
$ go version
go version go1.13 linux/amd64

Does this issue reproduce with the latest release?
This is an issue with the latest release
What operating system and processor architecture are you using (go env)?
go env Output
$ go env
GO111MODULE="on"
GOARCH="amd64"
GOBIN=""
GOCACHE="/usr/local/google/home/howardjohn/.cache/go-build"
GOENV="/usr/local/google/home/howardjohn/.config/go/env"
GOEXE=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GONOPROXY=""
GONOSUMDB=""
GOOS="linux"
GOPATH="/usr/local/google/home/howardjohn/go"
GOPRIVATE=""
GOPROXY="https://proxy.golang.org,direct"
GOROOT="/usr/local/go"
GOSUMDB="sum.golang.org"
GOTMPDIR=""
GOTOOLDIR="/usr/local/go/pkg/tool/linux_amd64"
GCCGO="gccgo"
AR="ar"
CC="gcc"
CXX="g++"
CGO_ENABLED="1"
GOMOD="/usr/local/google/home/howardjohn/go/src/istio.io/istio/go.mod"
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build462288476=/tmp/go-build -gno-record-gcc-switches"

What did you do?
Ran a benchmark for our application on go 1.13 and go 1.14rc1. performance took about a ~5% hit.
$ go test ./pilot/pkg/proxy/envoy/v2/ -bench=BenchmarkEDS -run=^$ -benchmem -benchtime=20s
goos: linux
goarch: amd64
pkg: istio.io/istio/pilot/pkg/proxy/envoy/v2
BenchmarkEDS/100/1-6              264200             90238 ns/op            8964 B/op        361 allocs/op
BenchmarkEDS/1000/1-6              30642            775560 ns/op           62452 B/op       3061 allocs/op
BenchmarkEDS/10000/1-6              3147           6909406 ns/op          604528 B/op      30086 allocs/op
BenchmarkEDS/100/100-6              3217           7292090 ns/op          876827 B/op      35645 allocs/op
BenchmarkEDS/1000/100-6<PHONE_NUMBER>5 ns/op         6318974 B/op     307880 allocs/op
BenchmarkEDS/10000/100-6              34         657385493 ns/op        70324914 B/op    3240990 allocs/op
PASS
ok      istio.io/istio/pilot/pkg/proxy/envoy/v2 176.394s

$ go1.14rc1 test ./pilot/pkg/proxy/envoy/v2/ -bench=BenchmarkEDS -run=^$ -benchmem -benchtime=20s
goos: linux
goarch: amd64
pkg: istio.io/istio/pilot/pkg/proxy/envoy/v2
BenchmarkEDS/100/1-6              246732             97406 ns/op            8964 B/op        361 allocs/op
BenchmarkEDS/1000/1-6              29126            823575 ns/op           62454 B/op       3061 allocs/op
BenchmarkEDS/10000/1-6              3036           7492450 ns/op          604574 B/op      30087 allocs/op
BenchmarkEDS/100/100-6              3120           7801905 ns/op          876848 B/op      35645 allocs/op
BenchmarkEDS/1000/100-6<PHONE_NUMBER>2 ns/op         6323512 B/op     307986 allocs/op
BenchmarkEDS/10000/100-6              33         689077376 ns/op        70629433 B/op    3248162 allocs/op
PASS
ok      istio.io/istio/pilot/pkg/proxy/envoy/v2 180.654

What did you expect to see?
Hopefully performance improves or remains constant
What did you see instead?

Profile shows 1.14 spends 16% of time on gcBgMarkWorker, but 1.13 only 14.5%.
CPU profiles:
profiles.tar.gz
Let me know if there is more info I can provide, I realize these reports typically need a lot of info to track down the root cause. You might/should be able to reproduce by running the same command after checking out the repo at this PR: https://github.com/istio/istio/pull/20899

/cc @aclements @randall77

@howardjohn Thanks so much for the issue and the detailed information. Looking into it.

@howardjohn thank you for the report! Just a comment that in the future you can also use benchstat https://godoc.org/golang.org/x/perf/cmd/benchstat for an isolated summary of benchmark results.

Uses of runtime.aeshash64 in Go 1.13 should have been replaced by uses of runtime.memhash64 in Go 1.14.
Oh, I see, this program must be using hash maps with keys of interface types.  See https://golang.org/cl/191198.  Perhaps we should have a release note for that?

@ianlancetaylor Yeah that's right. @cherrymui and I dug a little deeper and it's actually map with keys of type reflect.Type that is causing >70% of the mapaccess1 calls. :)

Might be worth adding a special case for pointers in runtime.typehash, to call the sized memhash function rather than the general one.  For 1.14.1.

Certainly we could swap the order of the regular memory check and the kind switch, and add a kindPtr case.

I think if regular memory check is true, we could special case 32-bit and 64-bit sizes?

i am not sure if this is related, but i saw some differences in map access performance, too. In my case I am not using interface{} as a key, but instead a map[int]int
https://github.com/SlinSo/random/blob/master/mapaccess_test.go
pprof excerpt:
go1.13.8:
0.73s  9.53% 82.64%      0.73s  9.53%  runtime.aeshash64
go1.14rc1:
1230ms 15.81% 66.20%     1410ms 18.12%  runtime.memhash64Fallback
140ms  1.80% 97.43%      140ms  1.80%  runtime.memhash64

That's a bug. Yikes!
Fix coming.

(Unrelated to this issue, though.)

@randall77 is the intent for this to be tracked as a back port candidate? Ian had mentioned in https://github.com/golang/go/issues/37086#issuecomment-583161919

Might be worth adding a special case for pointers in runtime.typehash, to call the sized memhash function rather than the general one. For 1.14.1.

@gopherbot please open a backport issue.
I don't think this performance regression qualifies for a backport, but I'll let the release guys make that call.

@randall77 oddly it didn't backport for Go1.14.1, it only created PRs for 1.12 and 1.13.

Made #37613 for 1.14.


Added ability to override video output dir for running inside contain…

…er (related to #255)

Codecov Report

Merging #274 into master will decrease coverage by 0.52%.
The diff coverage is 41.17%.

@@            Coverage Diff             @@
##           master     #274      +/-   ##
==========================================
- Coverage   72.19%   71.66%   -0.53%
==========================================
  Files           8        8
  Lines        1086     1094       +8
==========================================
  Hits          784      784
- Misses        257      263       +6
- Partials       45       47       +2

Flag
Coverage Δ

#unittests
71.66% <41.17%> (-0.53%)
:arrow_down:

Impacted Files
Coverage Δ

selenoid.go
76.59% <30%> (-1.16%)
:arrow_down:

service/docker.go
74.7% <57.14%> (-0.61%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 35c6251...c88ec35. Read the comment docs.


[9.x] Add serialized cast

This PR adds the serialized model attribute cast.
Recently, I found myself serializing/unserializing model attributes with accessors and mutators.
However I think, it would be better to have a native support for serialized value casting.
This is only additive, should not contain any BC.

@bert-w If it's good practice or not is another question but just for the sake of the question the json cast would not be handling classes correctly.
$user = User::first();
$data = [
    'some' => 'data',
    'user' => $user
];

// will return the $data array with a full eloquent user model.
unserialize(serialize($user));

// will return the $data array with a stdClass having all columns as properties.
json_decode(json_encode($user));

Well, most of the cases I use JSON as well. Simple and portable.
But in some scenarios it's possible the developer want to store and keep the native PHP types of the data structure.
Also serialization has some other advantages like using __wakeup(), but I think for a model attribute it would be an overkill.
Overall, I find it's a nice to have.

Thanks for your pull request to Laravel!
Unfortunately, I'm going to delay merging this code for now. To preserve our ability to adequately maintain the framework, we need to be very careful regarding the amount of code we include.
If possible, please consider releasing your code as a package so that the community can still take advantage of your contributions!
If you feel absolutely certain that this code corrects a bug in the framework, please "@" mention me in a follow-up comment with further explanation so that GitHub will send me a notification of your response.


Theme Not Applied for Legacy Components

Is this a regression?

[ ] Yes, this behavior used to work in the previous version

The previous version in which this bug was not present was
Not Applicable - Legacy Components Didn't Exist in Previous Versions
Description
When using legacy buttons (by importing MatLegacyButtonModule) the theme is not being applied to the buttons as expected.
The theme is applied when not using legacy components (MatButtonModule).
However, I've read that the new MDC components are meant to be opt-in (when migrating my app, it automatically updated to use the legacy imports), so I think that having the theme not apply to legacy components would be an issue.
I've replicated the issue in this stackblitz: https://stackblitz.com/edit/f8rble-hjxjr7?file=src%2Fmaterial.module.ts.
If you switch the imports in src/material.module.ts from using legacy(MatLegacyButtonModule) to using MDC (MatButtonModule), you'll see the theme is applied for MDC components. If it's importing the legacy module, the theme is not applied.
Reproduction
StackBlitz link: https://stackblitz.com/edit/f8rble-hjxjr7?file=src%2Fmaterial.module.ts
If you switch the imports in src/material.module.ts from using legacy(MatLegacyButtonModule) to using MDC (MatButtonModule), you'll see the theme is applied for MDC components. If it's importing the legacy module, the theme is not applied.
Expected Behavior
Theme to be applied in legacy components as they are in MDC components
Actual Behavior
Theme is not applied to legacy component buttons
Environment

Angular: 15
CDK/Material: 15
Browser(s): Chrome
Operating System (e.g. Windows, macOS, Ubuntu): macOS (also virtual? Stackblitz?)

It's because there are a different set of themes for the legacy components. Instead of mat.all-component-themes, you should include mat.all-legacy-component-themes.

Ah, thank you. I assumed all-component-themes included legacy. Thank you for sharing all-legacy-component-themes with me.


:farmer: Error C2065: 'M_PI': undeclared identifier in AdvancedLiftDrag.cc(618,64)

Environment

OS Version: Windows CI
Source gz-sim build

Description

Expected behavior: Build should pass
Actual behavior: Build is failing because of an undeclared identifier

Steps to reproduce

Run a job in gz-sim7 or 8
See build fail

Output
Reference build: gz-sim8-win
Log output:
  gz-sim8-acoustic-comms-system.vcxproj -> C:\J\workspace\ign_gazebo-gz-8-win\ws\build\gz-sim8\bin\Release\gz-sim8-acoustic-comms-system.dll

  Building Custom Rule C:/J/workspace/ign_gazebo-gz-8-win/ws/gz-sim/src/systems/advanced_lift_drag/CMakeLists.txt

  AdvancedLiftDrag.cc

C:\J\workspace\ign_gazebo-gz-8-win\ws\gz-sim\src\systems\advanced_lift_drag\AdvancedLiftDrag.cc(618,64): error C2065: 'M_PI': undeclared identifier [C:\J\workspace\ign_gazebo-gz-8-win\ws\build\gz-sim8\src\systems\advanced_lift_drag\gz-sim8-advanced-lift-drag-system.vcxproj]

C:\J\workspace\ign_gazebo-gz-8-win\ws\gz-sim\src\systems\advanced_lift_drag\AdvancedLiftDrag.cc(674,46): error C2065: 'M_PI': undeclared identifier [C:\J\workspace\ign_gazebo-gz-8-win\ws\build\gz-sim8\src\systems\advanced_lift_drag\gz-sim8-advanced-lift-drag-system.vcxproj]

M_PI mentions: https://github.com/gazebosim/gz-sim/blob/gz-sim8/src/systems/advanced_lift_drag/AdvancedLiftDrag.cc#L618 and https://github.com/gazebosim/gz-sim/blob/gz-sim8/src/systems/advanced_lift_drag/AdvancedLiftDrag.cc#L674.
This is only failing in Windows

it should be GZ_PI

it should be GZ_PI

from https://github.com/gazebosim/gz-math/blob/6460f7c0a59833e2729157d246ee07806ff56126/include/gz/math/Helpers.hh#L43-L55


Received Date cannot be erased

ticket#6084; After deleting a quarterly report, it's not allowing me to erase the corresponding received date.

The highlighted date above can not be removed.

The date is able to be removed on the popup as shown above, but after clicking "Save" still exists on the main page.


Strategy symbol optional

Fixes https://github.com/snapshot-labs/snapshot/issues/1020

@bonustrack should we make symbol optional on all strategies?

@ChaituVR I don't think you need to remove the minLength if you remove the required.

@samuveth If we leave minLength and If we pass an empty string it throws an error,

But why do we need minLength now anyway? any problem by removing it? 😅

@bonustrack should we make symbol optional on all strategies?

@samuveth On all strategies yes

@ChaituVR Was with with removing symbol in "required"?

@samuveth If we leave minLength and If we pass an empty string it throws an error,
But why do we need minLength now anyway? any problem by removing it? 😅

Not sure how we are handling this one the backend but if we don't have a minlength the symbol could be an empty string.

But why do we need minLength now anyway? any problem by removing it? 😅

Not sure how we are handling this one the backend but if we don't have a minlength the symbol could be an empty string.

@samuveth On all strategies yes

So yeah @ChaituVR all strategies need this change.

On all strategies yes

@bonustrack Does it also mean in the future, anyone wants to add a strategy with "symbol" required, we should change it to optional? I mean is it always optional regardless of strategy/ its owner?

@ChaituVR Yes, ideally we would move at some point the symbol param into the parent object like network example:
{
  "name": "ticket",
  "symbol": "ABC",
  "network": "1",
  "params": {}
}

This way we wont need to force ourself some schema for strategy params

Awesome @bonustrack we should do that soon 👍 made it optional in all strategies and added a test case so users will not make it required for future strategies

Awesome @bonustrack we should do that soon 👍 made it optional in all strategies and added a test case so users will not make it required for future strategies

Would be good to maybe create an issue for it


admonition extension returns invalid html code without blank line.

In [8]: import markdown
In [9]: some_text = """
   ...: !!! danger "Danger"
   ...:     don't try this at home.
   ...:
   ...: """
In [10]: markdown.markdown(some_text, tab_length=2, extensions=['admonition'])
Out[10]: '
\n
Danger
don\'t try this at home.
\n
\n
'

A paragraph inside a paragraph is invalid html and etree parser complains!
the simple solution of turning the title paragraph into a div will work, but it wraps the inner paragraph, resulting in a CSS mess.

Recommended working solution:
     CLASSNAME_TITLE = 'admonition-title'
+    CLASSNAME_BODY = 'admonition-body'
     RE = re.compile(r'(?:^|\n)!!! ?([\w\-]+(?: +[\w\-]+)*)(?: +"(.*?)")? *(?:\n|$)')

@@ -130,9 +134,11 @@ class AdmonitionProcessor(BlockProcessor):
             div = etree.SubElement(parent, 'div')
             div.set('class', '{} {}'.format(self.CLASSNAME, klass))
             if title:
-                p = etree.SubElement(div, 'p')
+                p = etree.SubElement(div, 'div')
                 p.text = title
                 p.set('class', self.CLASSNAME_TITLE)
+                p = etree.SubElement(div, 'div')
+                p.set('class', self.CLASSNAME_BODY)

Note:   the parse_content() method of your admonition extension is an unreadable code-mess ;-)

Your proposed change alters the HTML output. Note that the HTML output is defined by what docutils outputs for admonitions. We are simply matching their output.  In other words, as docutils outputs the title in a p tag, so must we. Therefore, any change to the output which changes that is not acceptable.
I'm assuming the issue it related to the the tab length. Presumably somewhere within the extension tab length is assumed to always be 4. We should instead be pulling the value in from the Markdown class instance. A brief look at the code reveals that we are already, but maybe it is being missed in one obscure location. This will take some digging in to find.
This is why we have been working on blocks which don't rely on indentation. You might want to try block based admonitions. They will not suffer from this issue.

The element doesn't need to be changed, the content is indented and should be seen as an indented code block, but somehow it is included in the summary. We need to ensure it doesn't get inserted into the summary. We'll have to take a look for a way to handle this properly, but I don't think your suggestion is the way to go.
As a workaround, if you intend to use an indented code block, put an empty line between admonition headers and the block, and if you did not intend to have an indented code block, ensure the paragraph is not indented as such.

Further, tab_length has nothing to do with this. This behavior is seen with default tab length as well if you indent the first paragraph 8 spaces after the admonition header.

So if I'm understanding correctly, if there is no blank line between the opening line (!!!) and the body and the first line of the body is indented two levels, then the first block in the body is inserted as a child p of the title.  However, if either a blank line is added or the indentation is reduced to a single level, then the error does not occur.
I think I know what the problem is. It is related to the workarounds for the pesky block-parser, which splits everything into blocks by blank lines. That means that the entire body of an admonition is not fed in all together (each line-separated-block is fed in separately). Therefore, the code in parse_content which @lmende didn't understand is trying to determine if the current block is a child of the admonition or not. It does so by checking if the last child of the parent is an admonition. If so and the current block in indented, then it is assumed that the current block is also a part of the admonition. The problem occurs when there is no blank line. Everything after the opening line/title is broken off for future parsing. Apparently we are not handling indention properly here. I suspect we are prematurely dedenting. However, I have no idea why the content is being inserted as a child of the title.

It certainly needs investigation. I'm fairly certain it can be reasonably fixed, but I'd have to dig in and understand the conditions that cause it.

@facelessuser

Further, tab_length has nothing to do with this. This behavior is seen with default tab length as well if you indent the first paragraph 8 spaces after the admonition header.

That doesn't seem to be entirely true — consider the following differences:
>>> text = """
... !!! danger "This is not"
...     one long admonition title
... """
>>> print(markdown.markdown(text, extensions=['admonition']))

This is not

one long admonition title

>>> print(markdown.markdown(text, tab_length=2, extensions=['admonition']))

This is not
one long admonition title

It seems to me that tab_length has everything to do with it. The blank line is what actually has nothing to do with it — it screws up even when it's present. Observe:
>>> text = """
... !!! danger "This is not"
...
...     one long admonition title
... """
>>> print(markdown.markdown(text, extensions=['admonition']))

This is not

one long admonition title

>>> print(markdown.markdown(text, tab_length=2, extensions=['admonition']))

This is not
one long admonition title

@ferdnyc, I don't think you understand my statement. Using tab_length 2 isn't the problem, it is indenting the first line more than tab length (whatever that may be). The actual tab length doesn't matter.
If you are using tab length 2, you should only indent your admonition content by 2. Indenting the first line in this case by 4 should trigger a code block, but it doesn't.
If you use the default tab length of 4, you should indent your admonition content by 4. Indenting the first line in this case by 8 should trigger a code block, but it doesn't.
>>> import markdown
>>> md = """
... !!! danger "This is not"
...   one long admonition title
... """
>>> print(markdown.markdown(md, tab_length=2, extensions=['admonition']))

This is not

one long admonition title

>>> md = """
... !!! danger "This is not"
...     one long admonition title
... """
>>> print(markdown.markdown(md, tab_length=2, extensions=['admonition']))

This is not
one long admonition title

>>> md = """
... !!! danger "This is not"
...     one long admonition title
... """
>>> print(markdown.markdown(md, tab_length=4, extensions=['admonition']))

This is not

one long admonition title

>>> md = """
... !!! danger "This is not"
...         one long admonition title
... """
>>> print(markdown.markdown(md, tab_length=4, extensions=['admonition']))

This is not
one long admonition title

So, my statement is that what you set the tab length to doesn't matter, it is the handling of the first line indent. Nothing I've seen has proven my statement false. With that said, I haven't had a chance to root cause this issue yet.

@facelessuser
Fair enough. Although, based on the tests I showed, this workaround... doesn't?

As a workaround, if you intend to use an indented code block, put an empty line between admonition headers and the block, and if you did not intend to have an indented code block, ensure the paragraph is not indented as such.

It's been long enough that I don't recall if I tried out the workaround, or assumed the workaround should work, but you are correct that a new line does not fix the issue. It seems using fenced code blocks does work, or at least when using SuperFences (Python Markdown's fenced_code does not support being nested under other constructs like this).

I should also mention that the new Pymdown Extension's Admontion does not have this issue.  A new line between the header is required if indenting as indenting directly under the header is how you specify YAML options
>>> import markdown
>>> md = """
... /// danger | This is not
... one long admonition title
... ///
... """
>>> print(markdown.markdown(md, tab_length=2, extensions=['pymdownx.blocks.admonition']))

This is not

one long admonition title

>>> md = """
... /// danger | This is not
...
...     one long admonition title
... ///
... """
>>> print(markdown.markdown(md, tab_length=2, extensions=['pymdownx.blocks.admonition']))

This is not

  one long admonition title

With that said, this has been a reminder that I should try and look into this issue here.

I think I have this solved, a fix should be coming shortly.


vmchecker issues?

I can't log in to vmchecker, the log-in screen simply freezes... Is there a maintenance work scheduled?

Yes, there is an issue for the moment with the Vmchecker. Is not from us, we have to wait for it to come back on. You can retry periodically to login (once a few hours). Most of you already know how to test locally your homework, so you can do that until then :)

vmchecker is dead again since morning. Will we get an extension for the deadline?

Yes
On Sun, 17 Mar 2019 at 16:20, alfredrogoveanu<EMAIL_ADDRESS>wrote:

vmchecker is dead again since morning. Will we get an extension for the
deadline?
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
https://github.com/UPB-FILS/alf/issues/20#issuecomment-473670209, or mute
the thread
https://github.com/notifications/unsubscribe-auth/ACtOoTr6H3fj6wwuoXloyC5MrNBHX22Zks5vXk9JgaJpZM4brE8g
.

--
Alexandru RADOVICI
Universitatea "Politehnica" din Bucuresti
e-mail<EMAIL_ADDRESS>telefon:<PHONE_NUMBER>
www.ipworkshop.ro


Etar not linking to calendar icon

About this discussion
Even though the entry for ws.xsoh.etar exists, the calendar icon is not applied. This happens on the most recent debug-build.

The play store version is working for me , can you share the app component name for the apk you installed?
you can follow below guid to get it.
https://github.com/LawnchairLauncher/lawnicons/blob/develop/CONTRIBUTING.md#using-3rd-party-apps

ws.xsoh.etar
com.android.calendar.AllInOneActivity

IIRC this is correct in the .xml

Can you share the lawnicons version , lawnchir version. I have tried with recent builds with both alph 4 and alpha 5 version of lawnchir,Even in other thirdparty launcher (I tested no Nova) it's working fine.
Also try to

retstart Lawnchair
check rest to defult  in customise icon

Dev #1495
Did you test Kvaesitso? That's what I'm using.
Am 28. Januar 2023 11:04:02 MEZ schrieb Naveen @.***>:

Can you share the lawnicons version , lawnchir version. I have tried with recent builds with both alph 4 and alpha 5 version of lawnchir,Even in other thirdparty launcher (I tested no Nova) it's working fine.
Also try to

retstart Lawnchair
check rest to defult  in customise icon

--
Reply to this email directly or view it on GitHub:
https://github.com/LawnchairLauncher/lawnicons/issues/989#issuecomment-1407364132
You are receiving this because you authored the thread.
Message ID: @.***>

I have checked kavaesiso, it's not working. The problem is with kvaestso launcher, it somehow consider lawnicons as themedicon alone and not supporting dynamic calendar icons except Google Calendar.
1.The fix should be from launcher because other launchers, it's working fine, I have tested in lawncher, nova, rootless pixel launcher

As a workaround we can add static Calendar icon in lawnicons for the launcher which is not supporting dynamic calendar icons. But I need test if this has any impact with dynamic calendar

@Sir-Photch , with this build https://github.com/LawnchairLauncher/lawnicons/pull/1007 , Etar calendar appiled in Kvaesitso launcher but with static calendar icons . To have it dynamic calendar please raise issuw with Kvaesitso team.

Yep, that build works for me, albeit being fixed to the 31st.


[Bug]: Embedding pipeline bad column name

Do you need to file an issue?

[x] I have searched the existing issues and this bug is not already filed.
[x] My model is hosted on OpenAI or Azure. If not, please look at the "model providers" issue and don't file a new one here.
[x] I believe this is a legitimate bug, not just a question. If this is a question, please use the Discussions area.

Describe the bug
There is a title variable that gets use to access the entity titles within a dataframe before embedding the descriptions for that entity. Later in the code, this variable get updated with a description causing a KeyValue error.
Here are the two lines in question:
https://github.com/microsoft/graphrag/blob/634e3ed62a6c5de7084f20e034edbb7185ad5e84/graphrag/index/operations/embed_text/embed_text.py#L180
https://github.com/microsoft/graphrag/blob/634e3ed62a6c5de7084f20e034edbb7185ad5e84/graphrag/index/operations/embed_text/embed_text.py#L196
Steps to reproduce
Build a brand-new index
Expected Behavior
No response
GraphRAG Config Used
# Paste your config here

Logs and screenshots
No response
Additional Information

GraphRAG Version: 0.3.6
Operating System: Linux
Python Version: 3.11.5
Related Issues:

Resolved with #1356, thanks @nievespg1 !


Bug when breading slowpoke

Hello, I am actually trying to bread two non alola slowpoke together but it ALWAYS give me an alola one.

Well, I found the solution. To all the people that have the same problem, the two slowpokes need to wear both an everstone.

This is a known issue for Pixelmon. I believe the next update will address it.


New package: InuInu2022.NodoAme version 0.4.0-beta-2

[x] Have you signed the Contributor License Agreement?
[x] Have you checked that there aren't other open pull requests for the same manifest update/change?
[x] This PR only modifies one (1) manifest
[x] Have you validated your manifest locally with winget validate --manifest <path>?

[x] Does your manifest conform to the 1.5 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.

For moderators
This account is automated by Github Actions and the source code was created by CoolPlayLin. If you have any questions about any pull request, don't hesitate to ping @Exorcism0666, I'll get a notification.

[!important]
Please carefully review these Pull Request before merging. If it is a Pull Request for removing incorrect content and the URLs are issue, free upon manual checking, please close this Pull Request directly. (It is best to inform Exorcism0666 of the closure.)

良い一日をお過ごしください！

Manual Validation ended with:

Faulting application name: NodoAme.exe, version: <IP_ADDRESS>, time stamp: 0xfa20fb26
Faulting module name: KERNELBASE.dll, version: 10.0.19041.1202, time stamp: 0xc9db1934 Exception code: 0xe0434352 Fault offset: 0x0000000000034f99
Faulting process id: 0x7cc
Faulting application start time: 0x01da4295211c8a57
Faulting application path: C:\Users\User\AppData\Local\Microsoft\WinGet\Packages\InuInu2022.NodoAme__DefaultSource\NodoAme.exe
Faulting module path: C:\Windows\System32\KERNELBASE.dll Report Id: a3a90f4c-3c0f-4d8c-8ba2-64283e5b8ef3
Faulting package full name:
Faulting package-relative application ID:   Application: NodoAme.exe Framework Version: v4.0.30319 Description: The process was terminated due to an unhandled exception. Exception Info: System.IO.DirectoryNotFoundException    at System.IO.__Error.WinIOError(Int32, System.String)    at System.IO.FileSystemEnumerableIterator1[[System.__Canon, mscorlib, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=b77a5c561934e089]].CommonInit()    at System.IO.FileSystemEnumerableIterator1[[System.__Canon, mscorlib, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=b77a5c561934e089]]..ctor(System.String, System.String, System.String, System.IO.SearchOption, System.IO.SearchResultHandler`1<System.__Canon>, Boolean)    at System.IO.Directory.GetFiles(System.String)    at CodingSeb.Localization.Loaders.LocalizationLoader.AddDirectory(System.String)    at NodoAme.App.OnStartup(System.Windows.StartupEventArgs)    at System.Windows.Application.<.ctor>b__1_0(System.Object)    at System.Windows.Threading.ExceptionWrapper.InternalRealCall(System.Delegate, System.Object, Int32)    at System.Windows.Threading.ExceptionWrapper.TryCatchWhen(System.Object, System.Delegate, System.Object, Int32, System.Delegate)    at System.Windows.Threading.DispatcherOperation.InvokeImpl()    at MS.Internal.CulturePreservingExecutionContext.CallbackWrapper(System.Object)    at System.Threading.ExecutionContext.RunInternal(System.Threading.ExecutionContext, System.Threading.ContextCallback, System.Object, Boolean)    at System.Threading.ExecutionContext.Run(System.Threading.ExecutionContext, System.Threading.ContextCallback, System.Object, Boolean)    at System.Threading.ExecutionContext.Run(System.Threading.ExecutionContext, System.Threading.ContextCallback, System.Object)    at MS.Internal.CulturePreservingExecutionContext.Run(MS.Internal.CulturePreservingExecutionContext, System.Threading.ContextCallback, System.Object)    at System.Windows.Threading.DispatcherOperation.Invoke()    at System.Windows.Threading.Dispatcher.ProcessQueue()    at System.Windows.Threading.Dispatcher.WndProcHook(IntPtr, Int32, IntPtr, IntPtr, Boolean ByRef)    at MS.Win32.HwndWrapper.WndProc(IntPtr, Int32, IntPtr, IntPtr, Boolean ByRef)    at MS.Win32.HwndSubclass.DispatcherCallbackOperation(System.Object)    at System.Windows.Threading.ExceptionWrapper.InternalRealCall(System.Delegate, System.Object, Int32)    at System.Windows.Threading.ExceptionWrapper.TryCatchWhen(System.Object, System.Delegate, System.Object, Int32, System.Delegate)    at System.Windows.Threading.Dispatcher.LegacyInvokeImpl(System.Windows.Threading.DispatcherPriority, System.TimeSpan, System.Delegate, System.Object, Int32)    at MS.Win32.HwndSubclass.SubclassWndProc(IntPtr, Int32, IntPtr, IntPtr)    at MS.Win32.UnsafeNativeMethods.DispatchMessage(System.Windows.Interop.MSG ByRef)    at System.Windows.Threading.Dispatcher.PushFrameImpl(System.Windows.Threading.DispatcherFrame)    at System.Windows.Application.RunDispatcher(System.Object)    at System.Windows.Application.RunInternal(System.Windows.Window)    at NodoAme.App.Main()

(Automated response - build 530.)

Hi @Exorcism0666,
This package installed normally, but didn't run when launched. The above errors were in the Application log.

Hi @Exorcism0666,
This package installs normally, but doesn't run when lauched.

Manual Validation ended with:

2024-01-10 15:53:42.548 [CLI ] Starting: 'C:\Users\User\AppData\Local\Temp\WinGet\Microsoft.DotNet.Framework.DeveloperPack_<IP_ADDRESS>\ndp481-devpack-enu.exe' with arguments '/install /passive /norestart' 2024-01-10 15:58:42.013 [CLI ] ShellExecute installer failed: 3010

(Automated response - build 543.)

Unfortunately, the dependency Microsoft.DotNet.Framework.DeveloperPack_4 is requiring reboots, blocking their packages.


Refresh Challenge on Failed Attempts to Prevent Brute-Force Attacks

The code example doesn’t refresh after a failed attempt, allowing attackers to repeatedly attempt the same challenge without solving it, increasing vulnerability to brute-force attacks. Please consider refreshing the challenge in the exmaple after each failed attempt to ensure unique challenges per attempt, making brute-force attacks harder.

Hi, I'm not sure if I understand the issue correctly, but this is just a library with helpers for creating and solving challenges for ALTCHA. It does not include any server-side implementations such as replay-attack prevention etc (https://altcha.org/docs/server-integration/#security-recommendations). Users have to implement such mechanisms on their own depending on the technologies they use. The lack of these features is intentional to keep the library simple and independent from specific server technologies.


Https doesn't work with the latest version of Apicurio Registry.

The following deployment doesn't enable the https port and logs these warnings at the start:
apiVersion: registry.apicur.io/v1
kind: ApicurioRegistry
metadata:
  name: reg
spec:
  deployment:
   image: registry.redhat.io/apicurio/apicurio-registry-kafkasql-rhel8:2.6.1
  configuration:
    security:
      https:
        secretName: mytls-secret
    persistence: kafkasql
    kafkasql:
      bootstrapServers: "my-cluster-kafka-bootstrap:9092"

2024-08-12 18:37:26 WARN <> [null] (main) Unrecognized configuration key "quarkus.http.ssl.certificate.key-file" was provided; it will be ignored; verify that the dependency extension for this configuration is set or that you did not make a typo
2024-08-12 18:37:26 WARN <> [null] (main) Unrecognized configuration key "quarkus.http.ssl.certificate.file" was provided; it will be ignored; verify that the dependency extension for this configuration is set or that you did not make a typo
....
It only listens on the http port:
2024-08-12 18:37:36 INFO <_> [io.quarkus.bootstrap.runner.Timing] (main) apicurio-registry-storage-kafkasql 2.6.1.redhat-00003 on JVM (powered by Quarkus 3.8.4.redhat-00002) started in 11.219s. Listening on: http://<IP_ADDRESS>:8080
Apparently the http ssl config key names were changed in the more recent Quarkus version.
https://quarkus.io/guides/http-reference#configuring-the-http-server-directly

I'm looking into this. As a temporary workaround, you can set configuration properties by setting env. variable JAVA_OPTS_APPEND, which should fix the issue.

Hi @jsenko I've sent a PR #255 , please check if it is correct.


Website Layout

Project title
Website Layout
Project Description
I have made this project as a basic layout of a website which we can edit for our use
Stack:

[x] Html
[x] CSS

/assign


Custom Themes execute code in Editor without Tool mode

Tested versions
Reproducible in Godot Engine v4.2.2.stable.official.15073afe3
System information
Windows 10 - Vulkan API 1.3.242 - Forward+ - Using Vulkan Device #0: NVIDIA - NVIDIA GeForce RTX 2070 SUPER
Issue description
Custom Theme Resources will have their _init() function executed within the editor context, despite no Tool annotation being present.
This may also apply to other Resources defined in the ProjectSettings, if any.
Steps to reproduce
Define a custom Theme Resource as such:
class_name MyTheme
extends Theme

func _init() -> void:
    code goes here.
    For example you may subscribe to SceneTree.node_added() and modify the node.

Detailed example: https://github.com/TheDuriel/DurielUtilities/blob/main/FancyTheme/FancyTheme.gd
Define this Them as a Custom Theme in the Project Settings.
Restart the editor.
The Themes _init() function will not be executed, despite the lack of a Tool annotation.
Minimal reproduction project (MRP)
N/A

Does not seem to happen with all resources (tried with the icon).
Probably the Theme is loaded very early, before engine sets the editor hint, so the script instance is created as if the resource was loaded at runtime.

Possibly just a 'needs documentation' case then. It was rather unexpected behavior. (my custom theme tried skinning my whole editor.)

Well, regular scripts should not be executed in editor context. If the context is initialized too late then it's a bug.
It can be documented as limitation if the fix is unfeasible.


How to export filamat or mat in running program  After i dynamic call setParameter on MaterialInstance?

Is your feature request related to a problem? Please describe.
How to export filamat or mat in running program  After i dynamic call setParameter on MaterialInstance?

Duplicate