Improve performance of SliceInt64FromBytes

This attempts to preserve the semantics of the recent out-of-bounds bugfix.

Kicking off a reference run of a k=30. Time to beat is 12725.418 seconds.
Time with only the bug fix reverted instead and with the other improvements is 11458.487 seconds.

Adam, did you look at the code this produces compares to the existing code?
Another thing to try is to spell out the condition as an if-statement (instead of min()); in the hopes the branch predictor can kick in. But maybe the problem is that this uses an additional slot in the branch predictor table.

this gives me an idea. The only reason (as far as I can tell) that we need the call to std::min() currently, is because SliceInt64FromBytesFull() wants to use this function in a funky way, where start_bit + num_bits > 64, which causes us to truncate. SliceInt64FromBytesFull() will then fixup the last bits from the 9th byte.
If SliceIn64FromBytesFull() instead used this "duff's device"-like implementation, I think SliceInt64FromBytes() could be simplified.
The main cost, though, is probably using a variable size in memcpy() compared to always copying 8 bytes, as we did previously. With fixed 8 bytes, it probably turns into a single mov.

11780.493 seconds.

Beta 15 time for reference: Total time = 11670.208 seconds.

I think this patch has been superseded now

@aqk - should I just delete the branch?

@aqk Should I delete the branch too?


Handling structs with nested fields

Thanks for this project. I discovered it from a reddit thread.
How can I best handle structs with nested fields?
struct A { field1: i32, field2: i32 }

struct B { a: A }

struct C { field1: B }

I want boilermate to generate a struct that does not have the c_obj.field1.a.field2 field. How can I achieve this?

Hi, you could do something like that:
use boilermates::boilermates;

#[boilermates("AWithoutField2")]
struct A {
    field1: i32,

    #[boilermates(only_in_self)]
    field2: i32,
}

struct B {
    a: AWithoutField2,
}

struct C {
    field1: B,
}

fn main() {
    let a_without_field2: AWithoutField2 = AWithoutField2 { field1: 1 };
    let b = B {
        a: a_without_field2,
    };
    let c = C { field1: b };

    // and of course, it's easily convertible to a full `A` by filling in the value of `field2`
    let a: A = c.field1.a.into_a(3);
}

That's the simple answer – if you need something more advanced, keep on reading :)
Your question got me thinking, so I’ve added a feature just now to boilermates 0.2.0, where you have the HasNo{Field} generated trait for boilermates structs that lack a specific field.
So what you could do is:
use boilermates::boilermates;

#[boilermates("AWithoutField2")]
struct A {
    field1: i32,

    #[boilermates(only_in_self)]
    field2: i32,
}

struct B<T: HasNoField2> {
    a: T,
}

struct C<T: HasNoField2> {
    field1: B<T>,
}

If you parametrize B and C with a generic that has a NoField2 trait bound, you can enforce your requirement. The struct WithoutField2 that's generated from the boilermates macro would implement NoField2, while WithField2 would not. (the trait has no functions, it's just a marker)
This will not compile:
    let a = A {
        field1: 1,
        field2: 2,
    };
    let b = B { a };
    let c = C { field1: b };

The errors would be:
error[E0277]: the trait bound `WithField2: HasNoField2` is not satisfied
  --> src/main.rs:25:17
   |
25 |     let b = B { a };
   |                 ^ the trait `HasNoField2` is not implemented for `WithField2`
   |
   = help: the trait `HasNoField2` is implemented for `WithoutField2`
note: required by a bound in `B`
  --> src/main.rs:11:13
   |
11 | struct B<T: HasNoField2> {
   |             ^^^^^^^^^^^ required by this bound in `B`
. . .

Now you will still be able to to do this:
    let a_without_field2: AWithoutField2 = AWithoutField2 { field1: 1 };
    let b = B {
        a: a_without_field2,
    };
    let c = C { field1: b };

And be able to convert to WithField2 when you're ready:
    let aa: WithField2 = c.field1.a.into_with_field2(3);

Hope this helps!
Also, can I ask what's the use case?

Thanks, I will try to fit it to my codebase later.
As for the use-case, I have a DoneWorkout struct, which holds information about a workout session. But some fields on the struct are calculated (for example, total weight lifted). I want to generate another struct without these calculated fields. As you can see, the struct itself is highly nested, hence my original question :).


Added telkom to companies starting with t

Hi! There's a mismatch in the two PRs you sent. A company added in the .md should also be added in it's equivalent  js file.


Fix typo in "4.5. Integration Testing Application Modules Workting with Events"

https://docs.spring.io/spring-modulith/docs/0.1.x/reference/html/#events.integration-testing
Workting -> Working

That one's merged, thanks!


[Compute] Fix the issue caused by the lack of os_type when creating VM from shared gallery id

Description

Related PR: #19037
Testing Guide

History Notes

[Component Name 1] BREAKING CHANGE: az command a: Make some customer-facing breaking change.
[Component Name 2] az command b: Add some customer-facing feature.

This checklist is used to make sure that common guidelines for a pull request are followed.

[x] The PR title and description has followed the guideline in Submitting Pull Requests.

[x] I adhere to the Command Guidelines.

[x] I adhere to the Error Handling Guidelines.

Compute


2.17.1 beta

Sorry about the confusion - the reason all this text showed up was not that I wrote it, but that the swagger file now contains remarks, and those remarks are showing up in the client library.

Tested locally. It works! Merging. Above comments have to do with auto-generated code, so the origin codebase has to be modified.


Build for master is broken

Last build on travis (21hrs ago) was successful: https://travis-ci.org/yannickcr/eslint-plugin-react/builds/250125668
However, when I try to run tests on master I get two failures (see below). Not sure what is up? Some newer version of a dependency that got updated was my first guess, but I could not find which.
  2369 passing (7s)
  2 failing

  1) no-unused-vars valid
        /* eslint jsx-uses-vars: 1 */
        class HelloMessage {}
        <HelloMessage />
      :

      AssertionError: Should have no errors but had 1: [ { ruleId: null,
    fatal: true,
    severity: 2,
    source: '        <HelloMessage />',
    message: 'Parsing error: Unexpected token <',
    line: 4,
    column: 9 } ]
      + expected - actual

      -1
      +0

      at testValidTemplate (node_modules/eslint/lib/testers/rule-tester.js:415:20)
      at Context.RuleTester.it (node_modules/eslint/lib/testers/rule-tester.js:545:25)

  2) no-unused-vars valid
        /* eslint jsx-uses-vars: 1 */
        class HelloMessage {
          render() {
            var HelloMessage =
Hello
;
            return HelloMessage;
          }
        }
        <HelloMessage />
      :

      AssertionError: Should have no errors but had 1: [ { ruleId: null,
    fatal: true,
    severity: 2,
    source: '        <HelloMessage />',
    message: 'Parsing error: Unexpected token <',
    line: 9,
    column: 9 } ]
      + expected - actual

      -1
      +0

      at testValidTemplate (node_modules/eslint/lib/testers/rule-tester.js:415:20)
      at Context.RuleTester.it (node_modules/eslint/lib/testers/rule-tester.js:545:25)

To reproduce:
git clone https://github.com/yannickcr/eslint-plugin-react/
npm i
npm test

Also TravisCI PR builds are broken, e.g: https://travis-ci.org/yannickcr/eslint-plugin-react/builds/250443200?utm_source=github_status&utm_medium=notification

I can't reproduce that issue locally; I've reran the master build. If that passes, then it's not a transitive dependency being updated.
What version of node are you using?

Since the travis master build failed, this time I rm -rf node_modules && npm install, and now I can reproduce it.

Fixed by 65b746edb07080ac3a8c66cd12c532f1a1adc5cb

Nice. I suppose the issue was a release of acorn? https://www.npmjs.com/package/acorn (which is a dependency of espree).
What about introducing yarn or npm5 to generate a lockfile? (I believe npm5 also generates it by default, but haven't used it yet)

Absolutely not; only apps should have lockfiles, never published packages.


fix: Jackson version update 2.13 -> 2.15

this will fix it: https://app.snyk.io/vuln/SNYK-JAVA-COMFASTERXMLJACKSONCORE-7569538
Thanks @ruivieira

We might need to pull this change to RHOAI as well.


Display sensible error messages when step indices are out of range for edit recipe

Closes #212
Closes #238

Codecov Report

Merging #247 into master will increase coverage by 0.05%.
The diff coverage is 91.66%.

@@             Coverage Diff              @@
##             master     #247      +/-   ##
============================================
+ Coverage     76.98%   77.03%   +0.05%
- Complexity     1528     1532       +4
============================================
  Files           141      141
  Lines          4110     4119       +9
  Branches        547      551       +4
============================================
+ Hits           3164     3173       +9
  Misses          856      856
  Partials         90       90

Impacted Files
Coverage Δ
Complexity Δ

...ava/chopchop/logic/commands/EditRecipeCommand.java
95.57% <91.66%> (+0.38%)
44.00 <2.00> (+4.00)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ef6d8c5...23aaae1. Read the comment docs.


graphical Interface

Hi Alireza , I really appreciate your great work on reality-ezpz , but if possible , contribute with other programmers and start creating a GUI and also a better user management system , most of my friends abuse the config I've given them by sharing it to a lot of people , please keep in mind , we support you and all contributors to this project , and we thank you all .
Yours Sincerely
cipherx .

Hi Alireza , I really appreciate your great work on reality-ezpz , but if possible , contribute with other programmers and start creating a GUI and also a better user management system , most of my friends abuse the config I've given them by sharing it to a lot of people , please keep in mind , we support you and all contributors to this project , and we thank you all . Yours Sincerely cipherx .

Thanks for your kind works,
Actually this is a script that other developers can use it as the core of different products. It should be easy to create web interface for it and I welcome contributions!
About the accounting, it is a complex project and needs time for development. Unfortunately I don't have time to spent on it for now.
Regards


Suggestion - Mermaid diagrams rendering

Dear Sirs,
What would be the effort to create a scope for Mermaid JS diagrams rendering with Kaleido? That would be a nice proof that Kaleido can perform beyond the scope of vizualisation libraries...
Unfortunately I have limited skills to implement such scope myself :(
Best regards

duplicate of #165


buildref, keep things in sync

straight from https://github.com/sqlcollaborative/sqlcollaborative.github.io/pull/13

so sorry, related tests did not pass ❌


Openscad to OpenJSCAD

Hi, I have installed the CLI version on Mac and as far as I can tell everything is installed OK. However firstly, when I run openjscad example005.jscad from the terminal nothing happens. Secondly, the CLI does not allow me to choose an scad file from a local hard drive and thirdly if I have an openSCAD file, how I can convert it to OpenJSCAD ?

@TeslaGeek Welcome!
The script places the converted file into the same directory as the original. So, please look inside the examples directory.
If the script executes properly then a message about the Blob export size should show in the terminal.
If you still have issue then please run ./openjscad --version
I'd like to see the output, if any.

It seems,  openscad to openjscad still have some problem. I have tried the code below, it failed.
“”
/* [leaf] */
// (Total leaves that make up a pinecone) :
totalLeafs = 150; // [10:400]
// (Average length of each leaf) :
leafBaseLength = 60; // [10:200]
// (Average thichkness of each leaf) :
leafThickness = 5; // [2:10]
// (Shape of leaf) :
leafSides = 4; // [3:6]
// (Spikiness of leaf) :
leafSpikiness = 8; // [0:20]
// (Upwards angle of leaf for printability) :
leafGrade = 30;  // [0:80]
/* [pinecone] */
// (Overall height of pinecone) :
pineConeHeight = 120; // [10:300]
// (Spiraling angle between leaf (Phi = 137.5, Lucas = 100.0) ) :
angleBetweenLeafs = 137.5;
// layer
module layer(segments) {
union () {

    // Overall height of pinecone
    pineConeBase = leafBaseLength*0.15;
    cylinder(h = pineConeHeight, r1 = pineConeBase, r2 = 2, $fn=leafSides);
    cylinder(h = pineConeHeight*0.1, r1 = (pineConeBase+4), r2 = 0, $fn=leafSides);

    for ( i = [0 : segments] ) {

        seedNormal = (i/(segments-1));
        inverseSeedNormal = ((1-seedNormal) >.3) ? ((1-seedNormal)) : (.3);
        sinusoidalNormal = sin(seedNormal*90);
        inverseSinusoidalNormal = 1-sinusoidalNormal;

        baseTaper = .1;
        bottomLeafScalar = (seedNormal<baseTaper) ? (( seedNormal/baseTaper)*0.75+0.25 ) : 1;

        sizeScalar = bottomLeafScalar*inverseSeedNormal*leafThickness;

        leafWidth = 3*sizeScalar;
        leafHeight = 2*sizeScalar;

        leafBaseLengthCalculated = bottomLeafScalar*(leafBaseLength - (seedNormal*leafBaseLength));
        leafOffsetFromCenter = 0;
        leafTipLengthCalculated = leafSpikiness*inverseSeedNormal;
        leafHeightOffset = sinusoidalNormal*-pineConeHeight;

        rotate([0,0,0])
        rotate([0,90,0])
        rotate([i*angleBetweenLeafs ,0,0])
        translate([leafHeightOffset-5,0,0])
        leaf(
            width = leafWidth,
            height = leafHeight,
            baseLength = leafBaseLengthCalculated,
            tipLength = leafTipLengthCalculated,
            offsetFromCenter = leafOffsetFromCenter,
            seedNormal = seedNormal
        );
    }
}

}
// leaf
module leaf(width, height, baseLength, tipLength, offsetFromCenter, seedNormal) {
tip = tipLength;
base = baseLength;
rotate([0,-leafGrade,0]) // upwards angle for printing
rotate([0,0,0]) // upwards angle for printing
union () {
    // leaf base
    translate([0,0,offsetFromCenter])
    scale([height,width,1])
    cylinder(h = base, r1 = 0.5, r2 = 1, $fn=leafSides);

    // leaf tip
    translate([0,0,offsetFromCenter+base])
    scale([height,width,1])
    cylinder(h = tipLength, r1 = 1, r2 = 0, $fn=leafSides);

}

}
scale([1,1,1])
layer( totalLeafs );
“”


Add API routes of chart repo services in harbor API router

Add API routes of chart repo services in harbor API router

add chart repo API controller
update GetChartVersion to extract repo name from the request
update the corresponding UI cases
update the chart controller initialization process

Pull Request Test Coverage Report for Build 7627

17 of 165 (10.3%)  changed or added relevant lines in 2 files are covered.
4 unchanged lines in 1 file lost coverage.
Overall coverage decreased (-0.5%) to 64.674%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/chartserver/manipulation_handler.go
8
11
72.73%

src/ui/api/chart_repository.go
9
154
5.84%

Files with Coverage Reduction
New Missed Lines
%

src/common/utils/utils.go
4
81.55%

Totals

Change from base Build 7624:
-0.5%

Covered Lines:
11653

Relevant Lines:
18018

💛  - Coveralls


Add notification channels SmsPreferred and EmailPreferred

Description
Service owners may be flexible w.r.t which notification channel is used to pass on a notification.
If this is the case they can prefer one channel, but be fine with the notification being sent via backup channel if required.
SmsPreferred will send an sms to the recipient if a mobile number is available, and an email if no mobile number is available, but an email address is.
Considerations

If we cannot find neither an email address nor a mobile number should we create a notification within just the preferred notification channel which gets the status recipient not identified ?

Refinement: We will store the result on a notification on the preferred channel.

Given a new notification channel, how do we ensure that service owners get the best view of the final result? We have the endpoints /notifications/sms and notifications/email but they would need to call both and cross check the lists to identify who has and has not received notifications.

Refinement: Deferred, we postpone this question to when we start getting questions or feature requests.

How do we handle the case where notification channel is SmsPreferred and a recipient is provided with national identity number + an email address? Do we use provided email directly, look up sms and if no number present utse the registered or provided email ?

Refinement: Orders where a single recipient have both a lookup value and a specific contact point should be refused.

When sending notification to org, if we find a set of emails for emailPreferred, do we not send sms to the users that only have a number registered? In other words, is emailPreferred evaluated for each eligible recipient, or for the organization as a whole?

Additional Information
No response
Tasks
Notifications

[x] Add new enum values to NotificationChannelExt
[x] Add new endpoint to OrdersController for ordering notifications with any notification channel
[x] Add new RequestValidator, if a "preferred" notification channel is used, both templates must be populated.
[x] Consider if any changes is required t othe external models or status models.

Notifications.Core
Persisting the order request

[x] Re-work logic in OrderRequestService.GetRecipientLookupResult to handle the case where the new notification channels are used.
[x] Add function to ContactPoint service for AddPreferedContactPoints which can handle both SmsPrefered and Email Prefered.
[x] Re-work logic for defining RecipientLookupResult given the new notification channel

Processing the order

[x] Add a new interface and service for AdvancedOrderProcessing /ComplexOrderProcessing which is able to handle both SmsPreferred and EmailPreferred processing logic. Interface should define the same methods as IEmailOrderProcessingService

Notifications.Tests

Implement relevant tests for the service layer as unit tests wherever integrations are involved.

Notifications.IntegrationsTest

Implement relevant tests validating the validation logic in the controller

Chores

[x] Update APIM
[x] Update swagger in docs

Documentation

[x] User guide on the new endpoint
[x] Document the new notification channel wherever relevant

Acceptance Criterias

[ ] It is possible to place a notification order using SmsPreferred as the notification channel
[ ] It is possible to place a notification order using EmailPreferred as the notification channel
[ ] It is possible to place a notification order using Sms as the notification channel
[ ] It is possible to place a notification order using Email as the notification channel
[ ] If a preferred notification channel is defined and the recipient does not have any contact points, the lookup should fail
[ ] If SmsPreferred has been defined as the notification channel and the recipient only has an email address registered, an email notification should be sent
[ ] If EmailPreferred has been defined as the notification channel and the recipient only has a mobile number registered, an sms notification should be sent
[ ] Orders where a single recipient have both a lookup value and a specific contact point should be refused.
[ ] If user is reserved, no communication channel should be used

Doing some initial testing and have found a tiny issue: Looks like we have a fallback to Email notification also when given channel is Sms. This is not expected. The expected result would be to fail with missing contact information.

All tasks completed.


Fix for recent Deno versions + misc

Cool project! I hit a speed bump when I tried to use it, so here's a fix, and some other changes too.

Accept VS Code's auto-suggested as unknown as to fix type errors.
Add VS Code settings file (from denoland.vscode-deno)
Add a few instructions to the Readme
Add a basic CI pipeline. (for now this runs the tests; in the future it could also deno lint and deno fmt)

Hi @jrr, thanks for the PR. The type errors were  due to a mistake with how the pointers were cast, so I've passed them as params into the pointer view rather than casting them to unknown. Could you rebase your PR to the latest main and I will test the CI changes? Thanks

Done! Dropped the commit with the code changes. Here's how CI looks on my fork: https://github.com/jrr/cursed/actions/runs/2026267363


Rename TxConstraints to TxBuilder or sth

People are not very familiar with the constraints interface nowadays. We should consider picking another name.

https://github.com/mlabs-haskell/purescript-cardano-transaction-builder


Is this codec in unsigned-varint format?

I must have missed something obvious.  For example, this item in the current table:
leofcoin-block,                 ipld,           0x81,           draft,     Leofcoin Block

The code 0x81 is binary 10000001, and in my understanding of unsigned varint, should indicate there is a 2nd byte. Why isn't there 2nd byte in the table for this codec?

The table lists the un-encoded numbers. So in this case 0x81 would mean that if it is e.g. used in a CID, the unsigned varint of it would be 0x8101.

May I suggest adding (or just replacing with) the actual unsigned varint encoded code?  Because in the real life uses, we are using and seeing encoded numbers.
Just like UTF-8 which uses similar technique, we only care the actual encoded bytes.

I'm not sure I can think of a case where I've had to manually type out the encoded form, much more typically I'm using the integer form, e.g. https://github.com/ipld/js-dag-json/blob/328eda133620a0aff8cb19a314b5622f0054a6d3/index.js#L198 and I'm regularly copy and pasting from this table so it'd be a massive loss to ditch the human-readable forms for computer-redable ones.
You might be able to make a case for tacking an additional column with the bytes, but we're not dealing with a very extensible format with our CSV and haven't made any progress on a more extensible form unfortunately.

Hey, @Stebalien I am currently working on some implementations and would appreciate some clarification about this issue.
For the example @keepsimple1 raised (0x81) would it be to take that value (129 in decimal) and then encode it as an Unsigned Var Int (hence the 0x8101 given by @vmx)?
Are the entries then in big endian notation? (So udp multiaddr which is noted as 0x0111 would then be 273 and would then be 0x9102 as an Unsigned Var Int?

Yes, if encoding 0x81 from the table as a varint, then you'd get two bytes, 0x81 and 0x01, or 129 & 1. The multicodec table doesn't dictate the use of varints which is why it's listed as an integer there. Varints are a use-case implementation detail - CIDs (only one use-case of the multicodec table) do use varints and we generally expect they're used because they're compact and let us span a large range without worrying too much about lower, more common values taking up a lot of space.
Have a look at https://github.com/multiformats/unsigned-varint which attempts to describe what "varint" means in the multiformats context, with links to compatible implementations in JS, Rust and Go that you can compare against.


Comment in Creating dependent jobs section is vague and confusing

What article on docs.github.com is affected?
https://docs.github.com/en/free-pro-team@latest/actions/learn-github-actions/managing-complex-workflows#creating-dependent-jobs and/or https://docs.github.com/en/free-pro-team@latest/actions/reference/workflow-syntax-for-github-actions#jobsjob_idneeds
What part(s) of the article would you like to see updated?
In https://docs.github.com/en/free-pro-team@latest/actions/learn-github-actions/managing-complex-workflows#creating-dependent-jobs, the possibility of constraining jobs to run sequentially without the failure of earlier jobs in the sequence preventing the later jobs from running: If one of the jobs fails, all dependent jobs are skipped; however, if you need the jobs to continue, you can define this using the if conditional statement.
I had expected, thus, to see an example of how to do this, either directly here or in one of the two linked-to articles (either https://docs.github.com/en/free-pro-team@latest/actions/reference/workflow-syntax-for-github-actions#jobsjob_idif or https://docs.github.com/en/free-pro-team@latest/actions/reference/workflow-syntax-for-github-actions#jobsjob_idneeds).
It is not clear what sort of "if" statement is called for, nor whether it should supplement or replace the "needs" directive.  The https://docs.github.com/en/free-pro-team@latest/actions/reference/workflow-syntax-for-github-actions#jobsjob_idneeds article reiterates the possibility of constraining jobs to run in sequence without failing jobs preventing later jobs from running: If a job fails, all jobs that need it are skipped unless the jobs use a conditional statement that causes the job to continue.  This at least suggests that the "if" statement supplements the "needs" directive, but again, there is no example given of how to do this.
Since the Creating dependent jobs article occurs in the Learn GitHub Actions section of the documentation, it would probably be better to just omit the comment about allowing dependent jobs to run when their precursors fail, or at least to provide or link to an example the clarifies how to set this up.
Additional information

Content Plan
Linked here

Thanks so much for opening an issue @gsrohde! I'll get this triaged for review.

Thanks for pointing this out @gsrohde !
Here is an example of a job continuing based on a conditional even though it needs a job that failed:
name: need-fail-continue

on: [push, workflow_dispatch]

jobs:
  job1:
    runs-on: ubuntu-latest
    steps:
      - run: exit 1 # This will cause job1 to fail

  job2:
    needs: [job1]
    if: ${{ always() }} # This makes job2 run even if job1 fails
    runs-on: ubuntu-latest
    steps:
      - run: echo '...'

Perlukan dector penyensaian masalah

What article on docs.github.com is affected?
https://docs.github.com/en/free-pro-team@latest/actions/learn-github-actions/managing-complex-workflows#creating-dependent-jobs and/or https://docs.github.com/en/free-pro-team@latest/actions/reference/workflow-syntax-for-github-actions#jobsjob_idneeds
What part(s) of the article would you like to see updated?
In https://docs.github.com/en/free-pro-team@latest/actions/learn-github-actions/managing-complex-workflows#creating-dependent-jobs, the possibility of constraining jobs to run sequentially without the failure of earlier jobs in the sequence preventing the later jobs from running: If one of the jobs fails, all dependent jobs are skipped; however, if you need the jobs to continue, you can define this using the if conditional statement.
I had expected, thus, to see an example of how to do this, either directly here or in one of the two linked-to articles (either https://docs.github.com/en/free-pro-team@latest/actions/reference/workflow-syntax-for-github-actions#jobsjob_idif or https://docs.github.com/en/free-pro-team@latest/actions/reference/workflow-syntax-for-github-actions#jobsjob_idneeds).
It is not clear what sort of "if" statement is called for, nor whether it should supplement or replace the "needs" directive. The https://docs.github.com/en/free-pro-team@latest/actions/reference/workflow-syntax-for-github-actions#jobsjob_idneeds article reiterates the possibility of constraining jobs to run in sequence without failing jobs preventing later jobs from running: If a job fails, all jobs that need it are skipped unless the jobs use a conditional statement that causes the job to continue. This at least suggests that the "if" statement supplements the "needs" directive, but again, there is no example given of how to do this.
Since the Creating dependent jobs article occurs in the Learn GitHub Actions section of the documentation, it would probably be better to just omit the comment about allowing dependent jobs to run when their precursors fail, or at least to provide or link to an example the clarifies how to set this up.
Additional information

What article on docs.github.com is affected?
https://docs.github.com/en/free-pro-team@latest/actions/learn-github-actions/managing-complex-workflows#creating-dependent-jobs and/or https://docs.github.com/en/free-pro-team@latest/actions/reference/workflow-syntax-for-github-actions#jobsjob_idneeds
What part(s) of the article would you like to see updated?
In https://docs.github.com/en/free-pro-team@latest/actions/learn-github-actions/managing-complex-workflows#creating-dependent-jobs, the possibility of constraining jobs to run sequentially without the failure of earlier jobs in the sequence preventing the later jobs from running: If one of the jobs fails, all dependent jobs are skipped; however, if you need the jobs to continue, you can define this using the if conditional statement.
I had expected, thus, to see an example of how to do this, either directly here or in one of the two linked-to articles (either https://docs.github.com/en/free-pro-team@latest/actions/reference/workflow-syntax-for-github-actions#jobsjob_idif or https://docs.github.com/en/free-pro-team@latest/actions/reference/workflow-syntax-for-github-actions#jobsjob_idneeds).
It is not clear what sort of "if" statement is called for, nor whether it should supplement or replace the "needs" directive. The https://docs.github.com/en/free-pro-team@latest/actions/reference/workflow-syntax-for-github-actions#jobsjob_idneeds article reiterates the possibility of constraining jobs to run in sequence without failing jobs preventing later jobs from running: If a job fails, all jobs that need it are skipped unless the jobs use a conditional statement that causes the job to continue. This at least suggests that the "if" statement supplements the "needs" directive, but again, there is no example given of how to do this.
Since the Creating dependent jobs article occurs in the Learn GitHub Actions section of the documentation, it would probably be better to just omit the comment about allowing dependent jobs to run when their precursors fail, or at least to provide or link to an example the clarifies how to set this up.
Additional information

It should also be made clear, with examples, that the (Job status check functions)[https://docs.github.com/en/actions/reference/context-and-expression-syntax-for-github-actions#job-status-check-functions] apply to jobs as well as steps.

A job should be fully explained I don't know what to figure out how to get it all done and will be trying new things in the internet to get it done 👍


doc: add notes for .cargo/config.toml

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
According to the issue https://github.com/risingwavelabs/risingwave/issues/8608

Documentation

[x] My PR DOES NOT contain user-facing changes.

Click here for Documentation
Types of user-facing changes
Please keep the types that apply to your changes, and remove the others.

Installation and deployment
Connector (sources & sinks)
SQL commands, functions, and operators
RisingWave cluster configuration changes
Other (please specify in the release note below)

Release note

cc @ahmedriza


Build Error: Could not deduce (StateType (Handler b Sqlite) ~ Sqlite)

Hi there,
I am trying the new version <IP_ADDRESS> and I'm getting an error while I am building my project.
The error is located for the HasSqlite instance. I added the import "Control.Monad.State" as it is shown in the example project, but cabal throws the error
"Could not deduce (StateType (Handler b Sqlite) ~ Sqlite) from the context (MonadCatchIO-transformers-<IP_ADDRESS>:Control.Monad.CatchIO.MonadCatchIO
(Handler b App) bound by the instance declaration at libarary\Application.hs:22:5--24.
Expected type: Handler b Sqlite Sqlite
Actual type: Handler b Sqlite (StateType (Handler b Sqlite))
Relevant bindings include
 getSqliteState :: Handler b App Sqlite
  (bound at library\Application.hs:23:5)
In the second argument of `with', namely get'

My code is the following:
{-# LANGUAGE OverloadedStrings   #-}
{-# LANGUAGE ScopedTypeVariables #-}
{-# LANGUAGE TemplateHaskell   #-}
{-# LANGUAGE FlexibleInstances #-}

-- | Module, which defines and holds several sub snaplets.
module Application where

import           Control.Lens
import           Control.Monad.State
import           Snap
import           Snap.Snaplet
import           Snap.Snaplet.SqliteSimple

-- | Holds the snaplets.
data App = App { _playerDAO :: Snaplet Sqlite  }

-- | Creates the snaplet.
makeLenses ''App

-- | Provides a HasSqlite instance for this module.
instance HasSqlite (Handler b App) where
    getSqliteState = with playerDAO get

Cabal-version: 1.18.05 using <IP_ADDRESS> of Cabal library
GHC: 7.8.3

Thanks for the report.  Is this a regression from the new snaplet-sqlite-simple-<IP_ADDRESS> version, ie. was it working before?
The snaplet-sqlite-simple example app was building fine on GHC 7.6.3 on Travis: https://travis-ci.org/nurpax/snaplet-sqlite-simple/builds/66760603.
Did you try building in a clean sandbox?  Have you recently updated with "cabal update"?
I suppose either the snaplet code doesn't (anymore) build on GHC 7.8 or later, or you have some different versions of some dependent libraries.  Do you see any notable library version differences if you compare your locally installed versions against the ones picked up in https://travis-ci.org/nurpax/snaplet-sqlite-simple/builds/66760603?
I note that snaplet-postgresql-simple defines the HasPostgres differently.  From their docs:

instance HasPostgres (Handler b App) where
getPostgresState = with db get
setLocalPostgresState s = local (set (db . snapletValue) s)

Are you able to reproduce this in an isolated gist?  Would be easier for me to take a look.

Hi,
It worked before I updated to <IP_ADDRESS> aside from some strange random server time outs. But that's a different topic :)
I used a clean sandbox and I updated cabel in order to get snaplet-sqlite-simple <IP_ADDRESS>.
My dependencies are a bit different. So I am using the latest snap (<IP_ADDRESS>), but I have to use snap core <IP_ADDRESS> instead of <IP_ADDRESS> because of this issue: https://github.com/snapframework/snap-core/issues/228.
Also I am using the newer version <IP_ADDRESS> of sqlite-simple (instead of <IP_ADDRESS>).
I tried to create a small gist of my problem:
https://gist.github.com/wochinge/f84dc4f8fa8672827443
Thanks for your help!

Hi @wochinge, I think the problem is in your use of monads-tf package for monad transformers.  If I switch that package to mtl, your gist builds fine.
diff --git a/test.cabal b/test.cabal
index 7dea39a..990ca63 100644
--- a/test.cabal
+++ b/test.cabal
@@ -25,7 +25,7 @@ library
     exposed-modules:        Application
     build-depends:
         base,
-        monads-tf,
+        mtl,
         snap == <IP_ADDRESS>,
         blaze-builder,
         snap-core == <IP_ADDRESS>,

I've never actually come across monads-tf whereas mtl seems to be pretty common.  The mtl package is one of the dependencies for snap so it seems like it's a pretty safe bet to use the same in apps too.
I have no idea why this build problem arose in the context of my snaplet-sqlite-simple update though. :)

Thank you very much! It works now! Then nothing stops me from upgrading :-)
I guess I added the dependeny a bit too fast when cabal complained ;)


xrdp name misused

I wanted to make you aware that the name xrdp is now used for an X11 exploit kit:
https://howucan.gr/scripts-tools/1365-xrdp-a-rudimentary-remote-desktop-tool-for-the-x11-protocol-exploiting-unauthenticated-x11-sessions
https://github.com/sensepost/xrdp

What, we've been using the name for 10 years.

You may want to tell them, not me 😃.

I have opened an issue with them…

I think we can close this now. The linked project appears to be unmaintained.


refactor: Replace white & black colors with theme aware ones

Hey, I just made a Pull Request!
Based on discussions on #15677 it was decided we'll change black & white colors to be theme aware, and if possible the colors that are close to the theme.palette.status.* colors.
:heavy_check_mark: Checklist

[x] A changeset describing the change and affected packages. (more info)
[ ] Added or updated documentation
[ ] Tests for new functionality and regression tests for bug fixes
[ ] Screenshots attached (for UI changes)
[x] All your commits have a Signed-off-by line in the message. (more info)

I saw some files with *Chip in the name and wanted to change the colors to use theme.palette.status.* ones, but couldn't properly type the theme variable to use BackstageTheme, still looking how to do this but from the typings code I think withStyles was not made to allow custom themes, or at least not in the way we use the custom theme, maybe if we augmented the original theme instead of extending it as BackstageTheme...

I'm a bit confused with the failing test, it seems the theme in which the test are running is not a BackstageTheme but a normal MUI v4 theme...


Token Drag Vision is not handled correctly

In the path that skips core's _onDragLeftDrop we still need to reset vision to the initial location. Otherwise sight might be refreshed with the destroyed preview vision source still in the sight layer's sources. This seems to be harmless with just core (no errors at least), but it triggers an error if Perfect Vision is enabled.
function onEntityDragLeftDrop(event) {
	const ruler = canvas.controls.ruler
	if (!ruler.isDragRuler) {
		ruler.draggedEntity = undefined;
		return false
	}

	// Reset vision back to the initial location
	if (game.settings.get("core", "tokenDragPreview")) {
		event.data.clones?.forEach(c => c._original.updateSource({ skipUpdateFog: true, defer: true }));
	}

	// When we're dragging a measured template no token will ever be selected,
	// resulting in only the dragged template to be moved as would be expected
	const selectedTokens = canvas.tokens.controlled
	// This can happen if the user presses ESC during drag (maybe there are other ways too)
	if (selectedTokens.length === 0)
		selectedTokens.push(ruler.draggedEntity);
	ruler._state = Ruler.STATES.MOVING
	moveEntities.call(ruler, ruler.draggedEntity, selectedTokens);
	return true
}

Good catch! In fact there appear to be several issues with Token Drag Vision in Drag Ruler (i never tested that setting, tbh) that need to be adressed (cancelling a drag is even broken without PV enabled)

FYI: In 9.245 Token Drag Vision parts were removed from Token#_onDragLeftDrop, and now there's the Token#_onDragLeftCancel that handles the Token Drag Vision logic.

Thanks for the heads-up. I've released a version with appropriate changes.


Typos in Examples of Quick-Start Guide on pyB12MPS page

Link: http://pyb12mps.bridge12.com/quick-start.html#communicating-with-the-bridge12-mps

'rxVoltage = mps.rxdiodemv()' should be 'rxVoltage = mps.rxpowermv()'
'print(rxVolrageList)' should be 'print(rxVoltageList)'
The whole script is not the same as that from Github

This issue is now resolved.


Reset to default button on each state

A button to reset to default (to simply delete the key in local storage) would be interesting so it then reads ui-config.json again instead. And maybe even an option to overwrite the values in ui-config.json as a way to store the state "permanently"

Two requests, please...

Would love a "select all" button on your settings page, or even better...  "select all except seed"
Add ControlNet save settings... that would get you a donation!
Thank you for this awesome extension, I was hoping someone would create something like this, it's very useful.

I just added a simple button for reseting the state next to the checkpoint dropdown. I am planning to add separate deleting of all state variables. ControlNet support will be a bit more trickier and time consuming since most of the elements dont have id`s and the things are changing every day, but I will see what I can do :)

I just merged the PR with control net support. Let me know if you find some bugs :)

I added 'Select All', 'Select All Except Seeds' and 'Unselect All' buttons  in settings page.

Hello,
Unfortunately, these new features are not showing up or working for me. Over the last few days State wasn't working at all but I know how updates work. When Auto 1111 updates I need to be patient with extension developers.
Now State is working as before, including the "reset state next to the checkpoint dropdown" but State will not remember the ControlNet settings nor do I see the new options to "Select All..."
I have updated, shut everything down, rebooted, relaunched and updated again (a few times) but no luck.
Thank you for your efforts on this, I find it be a valuable addition to my workflow.
Cheers

I updated my SD version to latest and there were A LOT of changes there.

gradio version was updated
selects is not native html elements anymore, but custom ones
get_uiCUrrentTab method does not work anymore
onUiTabChange callback not working properly at the moment
changed css classes almost everywhere
So yes, as this is almost entirely JS extension, it depends on some html structure when there is no id attributes there and it is very fragile and hard to support.

Today I fixed most of this issues and found some new ones... I also applied your fixes. You can update the extension and check if its working for you. If not, please check js console for errors, to give me a hint for eventual problems.
Cheers :)

hey ilian, first of all thank you for the amazing idea and extension. works really well and i (and many others, im sure) are very grateful for this tool. could i suggest the ability to save inpainting option states as well (masked content, inpaint area etc)? Thank you!


Create zh_cn.json

Will merge this and #7 at a later date as I'm currently on a break from modding due to some medical issues, but thank you for the PRs!


Support imported functions

Does this library support importing Python functions into the WebAssembly module instances?
I couldn't find any example and looking at the code at https://github.com/wasmerio/python-ext-wasm/blob/89cecbbd672023f2b12ae183641fba2f9cc4c7e3/src/instance.rs#L133-L134 it seems like it is not supported yet?

Hi,
Not yet. We are working on it. The Wasmer runtime API, with its C and C++ bindings, support that but for statically typed languages. We have to make it compliant with dynamically typed languages.

@Hywan Is there any update? This is already supported in Go version of Wasmer library.

It's easier in Go than it is with Python. I'm working on it at the runtime-core level, see https://github.com/wasmerio/wasmer/pull/882. It's a WIP.

@Hywan Great!When do you expect to be finished?

I can't specify any date :-).

Would like to see this feature.  I'm trying to port a Rust module compiled with wasm_bindgen to run on Python but am getting "Failed to instantiate the module" errors since there are no function imports available.

Yup, working on it :-).

Still going?

Yes, https://github.com/wasmerio/python-ext-wasm/pull/140 is under review.


Cached image returns broken

I'm trying to serve a cached image but I'm only getting a broken image link. How come?
$cachedImage = Image::cache(function($img) {
			return $img->make('http://cdn.smosh.com/sites/default/files/ftpuploads/bloguploads/twilight-meme-scumbag-edward.jpg');
		}, 10, true);

return Response::make($cachedImage, 200, array('Content-Type' => $cachedImage->mime));

This is my result:

And this should be the result:

Does anyone here have a solution to this? It works just fine on a localhost server, but once live it just stopped. Any help would be much appreciated.

It's possible that the server is configured, to accept only requests with a valid user-agent. Intervention Image just uses file_get_contents(), and sends no agent info. I would try to fetch the file via Curl or Guzzle with a valid user-agent info and pass it to Intervention Image afterwards.


STCM Editor Corrupting gbin

I'm trying import back the text to a .gbin str, and for some reason the genareted file only contains few lines instead the all text, the input file for example is 15kb, the output 6kb
Sample.7z.zip
Original File:

Result File:

―――――――――――――――――――――――――――――――――――――――― 10000
Io
―――――――――――――――――――――――――――――――――――――――― 10001
Estou tão preocupada.
―――――――――――――――――――――――――――――――――――――――― 10001
Io
―――――――――――――――――――――――――――――――――――――――― 10002

Oh shit, multiple lines have the same id. This will require some format changes. What game is this even?

Since it looks like you already use some random parameters, I've added a new parameter, --simple-ids. This will change how the ids are calculated, so multiple lines won't end up with conflicting ids. However you'll have to manually fix up old txt files (I hope you don't have too much of them)

It's from Moero Chronicles

This will change how the ids are calculated, so multiple lines won't end up with conflicting ids. However you'll have to manually fix up old txt files (I hope you don't have too much of them)
Isn't a problem, Thank you.
the test build don't finished yet, but I supose you already tested and is fixed, then i will close the issue, thank you :)


fix cli schema path resolver

Summary

npx gql.tada generate is resolving the schema.graphql file path from parent of CWD instead of the CWD.
e.g.
// tsconfig.json
{
  "plugins": [
    {
      "name": "@0no-co/graphqlsp",
      "schema": "./graphql/schema.graphql",
      "tadaOutputLocation": "./types/graphql-env.d.ts"
    }
  ]
}

Assume CWD is /path/to/my_projects/my_app
Run npx gql.tada generate gets error:
Something went wrong while writing the introspection file [Error: ENOENT: no such file or directory, open '/path/to/my_projects/graphql/schema.graphql']

Set of changes

remove path.dirname()

NOTE: I would add a test-case but I don't see tests for CLI yet

Just need a changeset and we're good! Thanks for filing the Pr

@JoviDeCroock added! let me know if I did it wrong


Improve schema merging

Is your feature request related to a problem or challenge? Please describe what you are trying to do.

I am trying to work with the nyctaxi parquet data set which has one file per month. Over time, some of the types have changed. For example passenger_count started out as Int64 and was later changed to Float64.
Arrow-rs can not merge these schemas.
Other solutions (such as DuckDB) will merge these schemas and pick the least restrictive type (Float64).
Describe the solution you'd like

Describe alternatives you've considered

Additional context

I would have thought this logic would exist within the query engine, i.e. DataFusion, not the compute engine?

I'm fine with implementing this in DataFusion. It currently delegates to Schema::try_merge in this repo, though, so it would likely mean duplicating some of this code in DF. I'll transfer this issue.


Add "new" relations to the HuBMAP KG relations tables

Run OWLNETS to make sure relations in new ontologies exist or generates new relations table that includes all the relations

This is part of issue #31

This is part of issue #31


Changes during testing on 6 29

Modified wait_for a non-local action
Added mgmt address that the ansible host can use to delegate to
Added modifications of scaleio gateway to support a fixed address and port changes

Looks good :+1:

Good :+1:


安装第二个节点的时候，报解压pypi的错误

TASK: [untar pypi] ************************************************************
failed: [<IP_ADDRESS>] => {"changed": true, "cmd": "cd /tmp/; tar jxf /tmp/pypi.tar.bz", "delta": "0:00:00.206149", "end": "2016-01-13 14:39:26.463352", "rc": 2, "start": "2016-01-13 14:39:26.257203", "warnings": []}
stderr:
bzip2: Compressed file ends unexpectedly;
perhaps it is corrupted?  Possible reason follows.
bzip2: Inappropriate ioctl for device
Input file = (stdin), output file = (stdout)
It is possible that the compressed file(s) have become corrupted.
You can use the -tvv option to test integrity of such files.
You can use the `bzip2recover' program to attempt to recover
data from undamaged sections of corrupted files.
tar: Unexpected EOF in archive
tar: Unexpected EOF in archive
tar: Error is not recoverable: exiting now
FATAL: all hosts have already failed -- aborting
PLAY RECAP ********************************************************************
to retry, use: --limit @/root/tmp.o5EcLoZSjr.retry

please 'rm -rf  /usr/local/zstack/apache-tomcat/webapps/zstack/static/
pypi.tar.bz' in management-node 1. The issue might be happened after
breaking the command when doing zstack-ctl install_management_node.
On Wed, Jan 13, 2016 at 4:01 PM, cist<EMAIL_ADDRESS>wrote:

TASK: [untar pypi]

failed: [1921682161] => {"changed": true, "cmd": "cd /tmp/; tar jxf
/tmp/pypitarbz", "delta": "0:00:00206149", "end": "2016-01-13
14:39:26463352", "rc": 2, "start": "2016-01-13 14:39:26257203", "warnings":
[]}
stderr:
bzip2: Compressed file ends unexpectedly;
perhaps it is corrupted? Possible reason follows
bzip2: Inappropriate ioctl for device
Input file = (stdin), output file = (stdout)
It is possible that the compressed file(s) have become corrupted
You can use the -tvv option to test integrity of such files
You can use the `bzip2recover' program to attempt to recover
data from undamaged sections of corrupted files
tar: Unexpected EOF in archive
tar: Unexpected EOF in archive
tar: Error is not recoverable: exiting now
FATAL: all hosts have already failed -- aborting
PLAY RECAP

to retry, use: --limit @/root/tmpo5EcLoZSjrretry
—
Reply to this email directly or view it on GitHub
https://github.com/zstackorg/zstack/issues/195.

--
Yongkang You

Any feedback?

thanks  i resolved it   .  thanks very much


Question: how to disable vertical line on hover

When I moving mouse along Y axis.
In addition to tooltip, vertical line is showing.
How to disable it?
Example here http://c3js.org/samples/simple_multiple.html

Use css:
.c3-event-rects { display: none }

Thanks for answering @abacaj!
Closing as resolved.

Use css:
.c3-event-rects { display: none }

This is an incorrect solution. Because in this way you'll hide entire events layer.
If you need to disable only vertical bar, use .c3-xgrid-focus class:
.c3-xgrid-focus {     display: none; }


Volume website - updates needed for launch

[ ]  In the investor logos the Solana is not the right size and New Form is another color. Please replace logos for: https://drive.google.com/drive/u/1/folders/1Z6bHl-dQjNsLNVLQSJADoJurmbwN9TpF
[ ]  Crosschain Coalition logos. Please use: https://drive.google.com/drive/u/0/folders/1nLtQnSFmyPi2INKJ8Sv9yho-FeOU8o_N Please add 70% opacity.
[ ]  Cross-chain Weekly. We need to connect the button "Subscribe" to the database of the Newsletter.
[ ]  Update Taariq and Vera picture to: https://drive.google.com/drive/u/0/my-drive

@verabehr @wdev733 here are: https://drive.google.com/drive/u/0/folders/19zthOR0m-7QDEbZefpIabIGNtTTsEtWn


[AMBARI-24060] Sys-prepped Hosts do not Install and Finalize correctly

What changes were proposed in this pull request?

Installation of packages using a host that is sys-prepped is choosing package names in a non-deterministic way on ubuntu14/16
Finalization is failing when there are no packages installed on-system.

How was this patch tested?
Manual testing + update python unit test.

No issues reported with yum

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/Ambari-Github-PullRequest-Builder/2641/
Test PASSed.

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/Ambari-Github-PullRequest-Builder/2642/
Test PASSed.


Fix: Token fragment names are dropped from parser codegen

Not sure I understand the fix. Can you please let me know?

If this fixes token fragments, I would have expected the snapshots for MultilineComment to change.
If this fixes top-level tokens, I would have expected the snapshots for VersionPragmaOperator to change.

Not sure I understand the fix. Can you please let me know?

It definitely changes the tree you see using the solidity parser cli. I think the issue is that you are using custom serializer in the test output.


Add emails to author snippets

I tested various html and markdown syntax and non worked. Author info is stored in a .yaml file, and yaml does not include any kind of "import" or "include" statement. I'm moving this into the backlog, likely need Jeff's help.

@greensomes Here's the content for current team members
Lindsay Goldstein: Digital Services Specialist at the Office of Natural Resources Revenue. Contact Lindsay.
Alexandra McNally: User Experience Designer at the Office of Natural Resources Revenue. Contact Alexandra.
Christine Thomas: Content Strategist at the Office of Natural Resources Revenue. Contact Christine.


Updates on TNIL documentation

Apparently there are some updates on the official TNIL documents.

Morphology: New_Ithkuil_design_doc_v_1_1.pdf Version 1.2, December 29, 2022
SHA256: ed3d186a0f3226900d08c8d4cd03b2511c8d295381e135f491a4d8ec6120ca14
Affixes: affixes_v_1_0.pdf Version 1.0, Dec. 30, 2022
SHA256: fdc94646b99ea0719cb05a48ae9a7f5724e088774089a3ae4d4cff33b27d09a8
Script: Script_for_New_Ithkuil.pdf Version 1.0, December 2022
SHA256: fecea494db9b7fae209265e3819966801fee1a1d0124dad7db24c5c31346ad57

Thanks for the heads-up. Of course we should preserve every version that gets posted to the site, be it with or without prior announcement from JQ.
I'll add those when I'm free later tonight.

Oh, forget that last comment, I thought the version numbers hadn't been bumped.
Is Script_for_New_Ithkuil.pdf in fact a distinct file from the one currently available in the archive?

Is Script_for_New_Ithkuil.pdf in fact a distinct file from the one currently available in the archive?

Yes, there seem some minor changes.

Two of the files you've named hash to different sha256 upon downloading from ithkuil.net:

design doc<PHONE_NUMBER>4725954d3c0f416509b59ea99291cab18bc10c78ece4428d8ffbf5
affixes da69f284de9cc9bc3a57561aeb3c5b12222076718328c186f6891ea60915b00f

@omasanori, for the sake of archival completeness, could you provide me with the versions of the two documents that you hashed?

@uakci OK, I will send you these files by email.

I've sent them. Ping me if not delivered.

All done and dusted – thanks for the valuable contribution :D


Add CoinSwitch.io

CoinSwitch.io has started exchanging NAV.
https://coinswitch.co/
It needs to be added to the exchanges list
https://navcoin.org/en/buy-navcoin/
Acceptance Criteria
Add exchange to exchange listings

[ ] Title
[ ] Link
[ ] Logo (400x400)

claimed by @roast-nav

Resolved by https://github.com/navcoin/navcoin-org/pull/205


Minification process replacing absolute units with px

Hello guys,
I'm running into an issue that started happening in one of your latest releases - not exactly sure what is the build number, please accept my apologies.
During the deployment of one of the applications at my workplace we noticed that "gulp-minify-css" (which basically a wrapper for "clean-css") is currently replacing absolute units (pc, pt, etc) with px.
Although this seems to be not affecting the layout of our pages on Google Chrome, Firefox and Safari, it is completely breaking the layout on Internet Explorer (9 and above). The only way I was able to avoid these units to be replaced was setting the "advanced" option to false. Although I don't think this is the best solution, this issue was affecting our deployments on production and we really needed to find a way around it.
Do you have any ideas on why this is happening? Could you please tell us if there is a cleaner way to avoid this behavior?
Thank you in advance.
Renato.

It's a duplicate of #654 - fixed in version 3.4.2 and up. You could probably just delete gulp plugin from node_modules and rerun the build so it uses the latest clean-css.

Hello @jakubpawlowicz,
I actually looked at this issue earlier today and did exactly what you just described above.
However, for some reason it still didn't work as expected... I was wondering if the fix was also going to be applied the other way around, absolute units to px.
I'll give it another whirl once I get on my workplace tomorrow though.
Much appreciated.
Renato.

All the units are kept unchanged now, so there's no absolute units -> px conversion.
If you have access to the server then npm ls clean-css will help you find out what version of clean-css you are using and where it's located.
Hope this helps.

Below you can find the output I'm currently getting:
renato@server:/path$ npm ls clean-css
<EMAIL_ADDRESS>/path
âââ¬<EMAIL_ADDRESS>âââ<EMAIL_ADDRESS>It looks like we're using the right version according to what you mentioned on your first reply (3.4.2+).
Any thoughts? Would you like me to send you an example of what the output looks like before and after we noticed the issue?
Renato.

You certainly have the right version. I would make sure you serve the updated files, they are not cached on the server or in a browser in the first place.


rater组件star属性支持v-html渲染

Please makes sure the items are checked before submitting your PR, thank you!

[x] Rebase before creating a PR to keep commit history clear.
[x] Only One commit
[x] No eslint errors

Codecov Report

Merging #2183 into v2 will decrease coverage by 0.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##               v2    #2183      +/-   ##
==========================================
- Coverage   20.63%   20.59%   -0.04%
==========================================
  Files         211      211
  Lines        5141     5141
  Branches      571      571
==========================================
- Hits         1061     1059       -2
- Misses       3976     3978       +2
  Partials      104      104

Impacted Files
Coverage Δ

src/components/rater/index.vue
0% <ø> (ø)
:arrow_up:

src/components/blur/blur.js
64.51% <0%> (-2.16%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c1bd27c...9f45c21. Read the comment docs.


Kestrel on Ubuntu not complying to UseUrls("http://*")

Sorry if this is the wrong place to post this issue.
I have the following code. The UseUrls below works fine on Windows. However when i run it on Ubuntu Kestrel continues to listen only on localhost:5000 (note, 5000 and not 50000) as defined below. I would expect it to listen on localhost:50000 as well as externalIP:50000
public static void Main(string[] args)
{
            var host = new WebHostBuilder()
                .UseKestrel()
                .UseUrls("http://*:50000")
                .UseContentRoot(Directory.GetCurrentDirectory())
                //.UseIISIntegration()
                .UseStartup<Startup>()
                .Build();

            host.Run();
}

What does "not complying" mean. What error do you get?

I mean it doesn't obey the URL i give it. Instead it continues to only listen on localhost:5000. I don't get an error as far as i can tell. My app works fine. However I'm expecting it to bind to other interfaces then just localhost. That's the behavior I get on Windows just not on Ubuntu

Do you have a firewall, router, or anything else like that that could be preventing the request from reaching the external IP address? Are you able to reach other servers running in the same machine?

Two things make me think its not a router/firewall thing. First, it is still listening on the wrong port and not on the port i gave it. For example localhost:50000 (fifty thousand) doesn't work. Instead its listening on port 5000 (5 thousand) - even though i explicitly asked it to listen to 50,000. Secondly, from the local ubuntu machine, I am unable to access it from its 10.x.x.x IP. Of course externally also it doesn't work. Its basically ignoring the UseUrls

When you start it, is Kestrel printing Now listening on: http://*:50000? Or is it printing Now listening on: http://*:5000?

Assuming that it's printing Now listening on: http://localhost:5000 on linux you could try changing host.Run() to the following:
using (host)
{
    Console.WriteLine("ASPNETCORE_URLS: {0}", Environment.GetEnvironmentVariable("ASPNETCORE_URLS"));
    Console.WriteLine("Pre-start addresses: {0}", string.Join(", ", host.ServerFeatures.Get<IServerAddressesFeature>().Addresses));
    host.Start();
    Console.WriteLine("Post-start addresses: {0}", string.Join(", ", host.ServerFeatures.Get<IServerAddressesFeature>().Addresses));
    Console.ReadLine();
}

My guess is that its that the ASPNETCORE_URLS environment variable somehow got set.

You can also store the WebHostBuilder object into a hostBuilder variable before calling .Build() and take a look at its "urls" setting. E.g:  Console.WriteLine("urls: {0}", hostBuilder.GetSetting("urls"));

I want to confirm that indeed it is printing
Now listening on: http://localhost:5000
I'll try some of the other stuff @halter73 requested.

Well, i must be going crazy now because even if i remove everything in Main(string[] args) and write whatever i want to the console, nothing changes. I get nothing new in the console. Kestrel still runs and i'm still able to use my app. See code below
It seems to be when publishing to linux, asp .net core is assuming lots of things.
Here is what i'm running. Notice all the commented out code. This is almost unbelievable, even though i've tried extensively to prove myself wrong.
public static void Main(string[] args)
        {
            Console.WriteLine("Hello world!");

            //var host = new WebHostBuilder()
            //    .UseKestrel()
            //    .UseUrls("http://*:50000")
            //    .UseContentRoot(Directory.GetCurrentDirectory())
            //    //.UseIISIntegration()
            //    .UseStartup<Startup>()
            //    .Build();

            //Console.WriteLine("ASPNETCORE_URLS: {0}", Environment.GetEnvironmentVariable("ASPNETCORE_URLS"));
            //Console.WriteLine("Pre-start addresses: {0}", string.Join(", ", host.ServerFeatures.Get<IServerAddressesFeature>().Addresses));
            //host.Start();
            //Console.WriteLine("Post-start addresses: {0}", string.Join(", ", host.ServerFeatures.Get<IServerAddressesFeature>().Addresses));
            Console.ReadLine();
            //host.Run();
        }

Basically everthing in main is commented out. Why does it still run anything!?!?

Sounds like you're editing one version and compiling another. When in doubt add a compiler error to Main and it will become pretty clear if your code is even being compiled.

I'm running the exact same code on Windows to very different effect. On Windows, as expected i get "hello world" and no webserver started. On Linux, it is as if it is ignoring what's in my main. The biggest difference between Windows and Linux i can see is that i publish a self-contained app to Linux but on windows I'm running it as a portable app. No source code difference between the two.

If you want to prove you're running what you think you are, use a decompiler and look at the binary.  Maybe the build is failing and you're just running the old bits.

Ok, i decompiled. The publish in VS is ignoring the code i write in Main.cs if i publish to Ubuntu (16.04-x64). It seems to input there some template code. If I publish to Windows, it takes my code instead of the template code. Same source code on my side. Deleting binaries and starting from scratch every time.
Publish to Ubuntu is not emitting IL that represents my code. It's emitting some basic template IL

Do you have a runtimes section in your project.json?

Yes -
,
"runtimes": {
"win8-x64": {},
"ubuntu.16.04-x64": {}
},

In fact, It doesn't emit my changes to Startup.Configure either (according to decompiler). But it does emit correct IL for Startup.ConfigureServices.
This also explains this other problem I've had that i posted about here on StackOverflow

Well, that's my problem! If i copy the published to Windows version over to my linux machine, it responds to the UseUrls and my console says "Now listening on http://*:50000 and listening to multiple IPs

I guess based on what i'm saying (if you believe me! :)), this probably isn't the right forum for this. Would you guys happen to know what the right forum would be?

dotnet cli? https://github.com/dotnet/cli

To update everyone that helped me. I had to publish via command line instead of VS and things work now.

https://github.com/aspnet/Tooling-Internal/issues/599


How can i get user profile info from API?

I need the user profile information. For example, who is currently logged in? By pulling his Name and Email on our web app.This functionality needs to be provided by the API developer.

@samktest Unfortunately, our API does not provide such functionalities. I think this is a good use case, can you make a request here:https://intuitdevelopergroup.uservoice.com/forums/182764-intuit-developer-group/filters/top? I will vote for it.


Luk10114/1206 issues with samples

Related to issues described here: https://devtopia.esri.com/runtime/common-samples/issues/1206
Not all issues have been resolved, one relates to a geopackage that needs updating and one relates to (I suspect) a Samples App issue.

Thanks for reviewing @TADraeseke , changes have been made.


fill tasklist in auth attributes for poll APIs

Pull Request Test Coverage Report for Build ffdff039-8ae8-4779-8f4d-5de6cf680c4e

2 of 2 (100.0%)  changed or added relevant lines in 1 file are covered.
85 unchanged lines in 8 files lost coverage.
Overall coverage decreased (-0.004%) to 59.78%

Files with Coverage Reduction
New Missed Lines
%

common/task/weightedRoundRobinTaskScheduler.go
1
89.64%

service/history/queue/timer_queue_processor.go
2
58.77%

service/matching/taskListManager.go
2
74.09%

common/task/fifoTaskScheduler.go
3
84.54%

common/persistence/nosql/nosqlplugin/cassandra/tasks.go
14
72.8%

common/persistence/nosql/nosqlTaskStore.go
16
58.53%

common/persistence/cassandra/cassandraPersistence.go
23
50.62%

common/persistence/cassandra/cassandraPersistenceUtil.go
24
85.32%

Totals

Change from base Build 09e6697b-92f3-4805-b880-0a95d0c481bf:
-0.004%

Covered Lines:
90388

Relevant Lines:
151201

💛  - Coveralls


UI - Document Upload Fixes, Listing Url and Single Checkbox

Issue:

https://github.com/bcgov/entity/issues/23856
https://github.com/bcgov/entity/issues/23951
https://github.com/bcgov/entity/issues/23685
https://github.com/bcgov/entity/issues/24283

Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the namex license (Apache 2.0).

/gcbrun

Temporary Url for review: https://strr-ui-dev--pr-305-mnpudtqu.web.app

/gcbrun

Temporary Url for review: https://strr-ui-dev--pr-305-mnpudtqu.web.app

/gcbrun

Temporary Url for review: https://strr-ui-dev--pr-305-mnpudtqu.web.app

/gcbrun

Temporary Url for review: https://strr-ui-dev--pr-305-mnpudtqu.web.app

/gcbrun

Temporary Url for review: https://strr-ui-dev--pr-305-mnpudtqu.web.app

/gcbrun

Temporary Url for review: https://strr-ui-dev--pr-305-mnpudtqu.web.app

/gcbrun

Temporary Url for review: https://strr-ui-dev--pr-305-mnpudtqu.web.app


Implement TextField#html

At least a mostly correct version of it.
r? @tobytailor.

/botio reftest

Now with the test I meant to add.

/botio reftest

r+ but reminds me that we have to convert text runs back to html after parsing.


Add social media share buttons to post-detail route

Context
I'd like to have the social media share buttons within the post-detail page. This would let viewers easily share posts to their chosen social media platform (LinkedIN, Facebook, etc)
Current Behavior/Workaround
Users must copy/paste the url into a social media post.
Ideal behavior
User clicks a share button corresponding to the social media platform they wish to share to.
Things to consider
This django library looks very promising. It includes:
'Tweet This'
'Share this on Facebook'
'Share on Google+'
'Share on LinkedIn'
'Share on Telegram'
'Share on WhatsApp'
'mailto://'.
'Save to Pinterest'

Verified on PR and in production.
Twitter and LinkedIN share buttons work on posts. Image preview comes through and the post is successful.


NoSuchMethodError: org.apache.logging.log4j.spi.LoggerContext

https://hastebin.com/jicedenuru.md
Only happens when I switch to MongoDB
from h2
SRV VER: CraftBukkit version git-PaperSpigot-8b18730 (MC: 1.8.8) (Implementing API version 1.8.8-R0.1-SNAPSHOT)
Works fine on localhost also i am using mongodp from cloud.mongodb.com

Try to delete the libs folder in the luckperms folder.

This is most likely being caused by another plugin shading SLF4J incorrectly. Try running with only LuckPerms installed, if it works then you know the issue isn't being caused by LP.


Manuscript draft

I've started a manuscript draft on overleaf and shared with all of you. I will be finishing a rough outline of the paper & making placeholders for figures over the next few days / weeks.

@bradyrx, do you think you could use your visualization / graphic design skills to improve this schematic I made that summarizes our methods?

Per our Zoom call, post the code here when you have it and I can make a mock up to the best of my abilities..

Here's the notebook (since deleted) that I used to create the globes in this schematic https://github.com/hdrake/cmip6hack-multigen/blob/3d835872948f683bc7e20ba8de6e6aced9df24d3/notebooks/2_multigenerational_skill_figure_for_talk.ipynb


Refactor

as part of digging into the gpfit code I cleaned up some logic in fit.py...
@mjburton11, could you check this still works with your stuff?
@whoburg, ready for review.

@bqpd, the renaming of u to u_fit caused some problems in evaluate_fit.py that I was able to fix.  (pull my latest commit on this branch) However, running gassolar/environment/wind_fit.py in commit hoburg/gas_solar_trade@d65428cad05c36c5f70a9ffddb313b669e6c1e82 gives this error:
---------------------------------------------------------------------------
AttributeError                            Traceback (most recent call last)
/Users/mjburton11/MIT/GPKIT/gpkit-projects/gas_solar_trade/gassolar/environment/wind_fit.py in <module>()
    100                     print "rms iter=%d" % i
    101                 np.random.seed(i)
--> 102                 cns, rm = fit(X, Y, 4, "SMA")
    103                 rms.append(rm)
    104                 if rm > 0.05:

/Users/mjburton11/anaconda/lib/python2.7/site-packages/gpfit/fit.pyc in fit(xdata, ydata, K, ftype)
    105     elif ftype == "SMA":
    106         # constraint of the form w^alpha >= c1*u1^exp1 + c2*u2^exp2 +....
--> 107         lhs, rhs = w**alpha, monos.sum()
    108         print_SMA(A, B, alpha, d, K)
    109     elif ftype == "MA":

/Users/mjburton11/MIT/GPKIT/gpkit/gpkit/nomials/array.pyc in sum(self, *args, **kwargs)
    199             i = it.multi_index
    200             it.iternext()
--> 201             cs.extend(mag(self[i].cs).tolist())
    202             exps.extend(self[i].exps)
    203         if units:

The bottom part of the error message seems to be missing...

@mjburton11, what's the full error message above?

Oh I got it. Fixing...

haha just updated the comment...

@mjburton11, I think the latest commit fixes the bug

@bqpd, now getting the following error:
---------------------------------------------------------------------------
ValueError                                Traceback (most recent call last)
/Users/mjburton11/MIT/GPKIT/gpkit-projects/gas_solar_trade/gassolar/environment/wind_fit.py in <module>()
    144     colnames = np.append(colnames, "alpha")
    145     colnames = np.insert(colnames, 0, "latitude")
--> 146     df.columns = colnames
    147     # df.to_csv("windaltfitdata1.csv")

/Users/mjburton11/anaconda/lib/python2.7/site-packages/pandas/core/generic.pyc in __setattr__(self, name, value)
   2159         try:
   2160             object.__getattribute__(self, name)
-> 2161             return object.__setattr__(self, name, value)
   2162         except AttributeError:
   2163             pass

pandas/src/properties.pyx in pandas.lib.AxisProperty.__set__ (pandas/lib.c:42548)()

/Users/mjburton11/anaconda/lib/python2.7/site-packages/pandas/core/generic.pyc in _set_axis(self, axis, labels)
    411
    412     def _set_axis(self, axis, labels):
--> 413         self._data.set_axis(axis, labels)
    414         self._clear_item_cache()
    415

/Users/mjburton11/anaconda/lib/python2.7/site-packages/pandas/core/internals.pyc in set_axis(self, axis, new_labels)
   2217         if new_len != old_len:
   2218             raise ValueError('Length mismatch: Expected axis has %d elements, '
-> 2219                              'new values have %d elements' % (old_len, new_len))
   2220
   2221         self.axes[axis] = new_labels

ValueError: Length mismatch: Expected axis has 8 elements, new values have 14 elements

Actually I think this is better fixed in gpkit...

Wait.. this is a pandas error...

Yeah not sure about that pandas error :p. Worked on mine, got a latex error instead

@bqpd, ok so when I generate the fit, K=4 SMA, it prints out 4 terms but the constraint it returns only has 2...

Yeah, the first two terms were zero. :-/

Which is what caused the bug.

Hmmm... that's not what I'm seeing.

Ok now I'm getting this error:
---------------------------------------------------------------------------
AttributeError                            Traceback (most recent call last)
/Users/mjburton11/MIT/GPKIT/gpkit-projects/gas_solar_trade/gassolar/environment/wind_fit.py in <module>()
    100                     print "rms iter=%d" % i
    101                 np.random.seed(i)
--> 102                 cns, rm = fit(X, Y, 4, "SMA")
    103                 rms.append(rm)
    104                 if rm > 0.05:

/Users/mjburton11/anaconda/lib/python2.7/site-packages/gpfit/fit.pyc in fit(xdata, ydata, K, ftype)
    105     elif ftype == "SMA":
    106         # constraint of the form w^alpha >= c1*u1^exp1 + c2*u2^exp2 +....
--> 107         lhs, rhs = w**alpha, monos.sum()
    108         print_SMA(A, B, alpha, d, K)
    109     elif ftype == "MA":

/Users/mjburton11/MIT/GPKIT/gpkit/gpkit/nomials/array.pyc in sum(self, *args, **kwargs)
    199             i = it.multi_index
    200             it.iternext()
--> 201             cs.extend(mag(self[i].cs).tolist())
    202             exps.extend(self[i].exps)
    203         if units:

AttributeError: 'float' object has no attribute 'cs'

Yup, that's the zero.

making a gpkit pull (https://github.com/hoburg/gpkit/pull/1019) to address the summing issue. Not sure why the fit has zeros, though; did it not before?

So sometimes it did have zeros, but sometimes with a different seed I could get a function without a zero...

Lol!

Did those functions have a lower rse, or is a 4th-order fit overkill, or is this some weird local minima thing?

@mjburton11, now implements proper summing on gpkit master, so you shouldn't see that 'float' object has no attribute 'cs' error anymore.

I'm still getting the cs error.  As for the zeros,  4th order might be overkill... Im not sure about a local minimum thing.

Have you updated gpkit?

Ok I'm not getting that error anymore.  But the printed fit is still different from the returned constraint:
In [1]: %run wind_fit.py
Fitting for 54 latitude
rms iter=0
w**0.00298794 = 0.045666 * (u_1)**3.05619 * (u_2)**3.31932
    + 0.00105499 * (u_1)**0.0966488 * (u_2)**27.3915
    + 0.634617 * (u_1)**-0.0265261 * (u_2)**0.0118065
    + 0.362956 * (u_1)**0.0510403 * (u_2)**-0.0161858
RMS Error: 0.013 after iter=0, Altitude 40000

...Pandas error...

In [3]: cns
Out[3]: gpkit.PosynomialInequality(w_fit**0.003 >= 0.363*u_fit_(0,)**0.051*u_fit_(1,)**-0.016 + 0.635*u_fit_(0,)**-0.027*u_fit_(1,)**0.012)

That looks like a refactor problem, yeah!

Resolved by the latest commit, I think.

@mjburton11, re: evaluate_fit.py, what about having the constraints returned by fit have a method that accepts x data?

Doing so seems to also remove some of the iterations that were occurring in wind_fit.py...

Now with more refactor...

@mjburton11, @whoburg, this is ready for review.

@galbramc, the example seems unable to import gpfit? Or at least it has this pylint error: "Unable to import 'gpfit.fit'"

retest this please

@galbramc, fixed it by pip installing gpfit in jenkins

Hmm, didn't realize I had forgotten to install gpfit

I've run this through all my stuff and it works fine.  I like that the evaluate function can be called from constraint.  Much more elegant way to do that...

:) merge away! (this'll just merge into your PR)
On Dec 30, 2016 13:39, "Michael Burton"<EMAIL_ADDRESS>wrote:

I've run this through all my stuff and it works fine. I like that the
evaluate function can be called from constraint. Much more elegant way to
do that...
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/hoburg/gpfit/pull/61#issuecomment-269825115, or mute
the thread
https://github.com/notifications/unsubscribe-auth/ABagGCjcgP8n81zSs3UYb4USoNbM2sWlks5rNXn-gaJpZM4LTq2I
.

Should I squash/merge?

Probably regular merge into yours, and we can decide whether to squash from
there?
On Dec 30, 2016 14:23, "Michael Burton"<EMAIL_ADDRESS>wrote:

Should I squash/merge?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/hoburg/gpfit/pull/61#issuecomment-269829334, or mute
the thread
https://github.com/notifications/unsubscribe-auth/ABagGANmqv7eMqf-6B3SNdEpzMTwxHKGks5rNYRegaJpZM4LTq2I
.

Deleted branch.

oh, this got merged to smaequality, not master. Shall I review over there? (timeframe may take ~1 week)

I think this mostly replaced smaequality! I'll check what the diff is.

Made a new issue for these pylint issues: https://github.com/hoburg/gpfit/issues/63

@whoburg, these changes were identical to those in smaequality, so I merged that branch.


[PHP 5.6 Compliant] I miss the last function

Hello,
It's fix on the last commit.
Have a nice day !

Fixed. Thank you! :)


[AUTHZ] More test cases for function privileges building

Why are the changes needed?

How was this patch tested?

[x] Add some test cases that check the changes thoroughly including negative and positive cases if possible

[ ] Add screenshots for manual tests if appropriate

[x] Run test locally before make a pull request

cc @bowenliang123

Codecov Report

Merging #5143 (76d5e5a) into master (0a04f08) will not change coverage.
Report is 17 commits behind head on master.
The diff coverage is n/a.

:exclamation: Current head 76d5e5a differs from pull request most recent head 68c043c. Consider uploading reports for the commit 68c043c to get more accurate results

@@          Coverage Diff           @@
##           master   #5143   +/-   ##
======================================
  Coverage    0.00%   0.00%
======================================
  Files         566     566
  Lines       31601   31601
  Branches     4120    4120
======================================
  Misses      31601   31601

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Update .gitkeep

Please include a description of the goal and side-effects of your PR so we know what you're attempting to change.


fix: 🐛 add onWheelGuard to prevent unwanted preventDefault

Description

Motivation and Context
fix #941

Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Enhancement (changes that improvement of current feature or performance)
[ ] Refactoring (changes that neither fixes a bug nor adds a feature)
[ ] Test Case (changes that add missing tests or correct existing tests)
[ ] Code style optimization (changes that do not affect the meaning of the code)
[ ] Docs (changes that only update documentation)
[ ] Chore (changes that don't modify src or test files)

Self Check before Merge

[ ] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[ ] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes.
[ ] All new and existing tests passed.

#943

@OpportunityLiu  是的，为了不影响线上项目，紧急发了一个版本，现在想用你的 PR，能重新提一下吗😶


Hook scripts

This PR does the following:

Add husky as a development dependency
Set hook scripts for prepush and prepublish to run npm test
Set npm test to at least call npm run lint for now
Fix a linter issue in menu.js

The hook scripts for git (e.g., prepush) will be setup when the user runs npm install.
With the prepush hook, git will run npm test prior to pushing to a repo. Could also do precommit but it's overkill and can make complex rebase operations more difficult.

Good idea

Nice!


add Bound constructors for PyByteArray and PyMemoryView

Part of #3684
The adds the Bound constructors for PyByteArray and PyMemoryView.
Since the original from constructor used as_ptr(), which returns a borrowed ptr, I used a borrowed &Bound for the new one. Please correct me if I'm wrong here.

Btw, if you are interested in some reviewing as well as coding, I've started keeping a list on #3684, some help getting those reviewed and merged would go a long way towards getting this new API shipped!

Btw, if you are interested in some reviewing as well as coding, I've started keeping a list on #3684, some help getting those reviewed and merged would go a long way towards getting this new API shipped!

I'll have a look and leave some comments.


Accessibility of TAML documents

How do we provide better support for screen readers?
Screen readers turn commas and spaces into pauses, this may make it a little strange to listen to a TAML document

Perhaps we can provide a phrase or additional formatting appropriate for Visual Studio Code to present to a screen reader?


Do not reply with content from examples if they don't match the specified types

Prism replies with content from the "examples" property in OpenAPI even if the examples don't match types specified in the schema.
Context
Consider the following OpenAPI spec:
openapi: 3.0.2
paths:
  /pets:
    get:
      responses:
        '200':
          description: OK
          content:
            application/json:
              schema:
                '$ref': '#/schemas/Pet'
              examples:
                cat:
                  summary: An example of a cat
                  value:
                    id: "string_id"
                    name: 123
                    photoUrls: [[]]
                    status: 135

schemas:
  Pet:
      type: object
      required:
      - name
      - photoUrls
      properties:
        id:
          type: integer
          format: int64
        name:
          type: string
          example: doggie
        photoUrls:
          type: array
          xml:
            name: photoUrl
            wrapped: true
          items:
            type: string
        status:
          type: string
          description: pet status in the store
          enum:
          - available
          - pending
          - sold

Notice how the values given in the "cat" example do not match the types in the schema. id should be an integer but is the string "string_id", name should be a string but is the integer 123, photoUrls should be an array of strings but instead is an array of arrays [[]], and status is the string "available1" but not one of the allowed enums for status ("available", "pending", "sold").
Current Behavior
Currently, if we mock the above spec and call curl -i http://localhost:4010/pets, we get the following result:

The example is successfully returned even though the types of its values do not match the schema. These errors are detected as sl-violations, but the example is still returned. The logger also picks up the errors as seen below:

Expected Behavior
We want to introduce a command-line flag or equivalent to tell Prism not to reply with content from the examples if the types don't match the schema. Instead, Prism should return an error, potentially a 406 Not Acceptable error.
Possible Workaround/Solution
I am working introducing a command-line flag for this issue that supports the expected behavior described above. I am posting the issue here in case anyone has any input as to how they want this to look.
Steps to Reproduce
Let the OpenAPI spec pasted above be in a file called example.yaml.

Call prism mock example.yaml
Call curl -i http://localhost:4010/pets and notice how the example is returned even though it has invalid content for the specified types in the schema

@rattrayalex

Thanks for filing this, @ilanashapiro ! It looks like you closed this as completed, but I don't see a linked PR – was that intentional?

@rattrayalex Yes -- I am following up via email! Thanks!

RE: Closing this issue
After poking around the code for a bit to figure out how to introduce the command line flag, I discovered that if you include the existing --errors flag in the cURL command, an error will be thrown if the example doesn't match the schema type.
For instance, if you take the spec that I used for the GitHub issue: https://github.com/stoplightio/prism/issues/2271, and put it in a file called example.yaml, you can mock it with Prism using prism mock example.yaml --errors. Then if you call curl -i http://localhost:4010/pets, it returns the following error

rather than returning the invalid example. If you leave out the --errors flag and solely call prism mock example.yaml, the invalid example is returned as in the GitHub issue I created. I believe this behavior is implemented here: https://github.com/stoplightio/prism/blob/53d60521cafaa877e7495909aa7bb62aceb1b638/packages/http-server/src/server.ts#:~:text=if (opts.config,)%3B

@ilanashapiro ah the behaviour we'd like is for Prism to ignore the provided example if it is invalid and instead generate  a valid example itself - do you think that would be possible?


Don't Merge! PR real time test for webhook case

OPS Build status updates of commit bb51e98:
:clock10: Pending: waiting for processors (11 builds ahead of you)
:warning: OPS Build is busy, click here to report any potential performance downgrade issues, or you could view Docs Portal for trend of build queue length.

OPS Build status updates of commit bb51e98:
:x: Validation status: errors
Please follow instructions here which may help to resolve issue.

File
Status
Preview URL
Details
Dependent Files

:x:Error

Details

[Error] Cannot sync git repo to specified commit because branch pr-webhook has been deleted or has been force pushed: fatal: Could not parse object 'bb51e98eeb7eb40d1f414cc95fabacaa8d522f26'.

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Use local TypeScript with dtslint

Description:
This PR reconfigures dtslint to use the locally-installed version of TypeScript - i.e. the version with which RxJS is built.
The command must be passed an absolute path to the directory that contains typescript.js as said path is passed to require in two files within the dtslint implementation that reside in different directories - so each has a different relative path the the locally-installed TypeScript. To account for this, dtslint is not invoked via spec-dtslint/script.js.
This PR also restores numerous tests that had to be commented out due to the different behaviour of typescript@next.
Oh, and I changed prepublish to prepublishOnly as I was tired of having the build and tests run whenever I did an npm ci. Now, that stuff will only run before an actual publish. Never mind. It seems the CI build depends upon all that stuff happening after an npm install. :unamused:
Related issue (if exists): #4705

Pull Request Test Coverage Report for Build 8352

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 96.669%

Totals

Change from base Build 8343:
0.0%

Covered Lines:
5252

Relevant Lines:
5433

💛  - Coveralls


Improve the left/right arrow navigation inside the Navigator

Bug/issue #, if applicable: 90865355
Summary
Improves the sidebar navigator keyboard navigation, related to left/right arrow handling.
Dependencies
NA
Testing
Steps:

Assert right arrow opens parent nodes with children
Assert right arrow does nothing if already open OR on a leaf without children.
Assert left arrow closes parent nodes with children
Assert left arrow navigates to the parent of a leaf item
Assert left arrow navigates to the parent of a closed parent

Checklist
Make sure you check off the following items. If they cannot be completed, provide a reason.

[x] Added tests
[x] Ran npm test, and it succeeded
[x] Updated documentation if necessary

@swift-ci test

@swift-ci test


vmap equivalent for tensor[indices]

Hi,
Is there a way of vmapping over the selection of passing indices within a Tensor? Minimal reproducible example below,
import torch
from functorch import vmap

def select(x, index):
  print(x.shape, index.shape)
  return x[index]

x = torch.randn(64, 1000) #64 vectors of length 1000
index=torch.arange(64)   #index for each vector

out = vmap(select, in_dims=(0, 0))(x, index) #vmap over the process
print(out) #should output vector of 64

This should take in a batches of vectors and select the corresponding index from index vector (which can be viewed as a batch of scalars, and is hence represented as a vector).
The error is as follows,
RuntimeError: vmap: It looks like you're calling .item() on a Tensor. We don't support vmap over calling .item() on a Tensor, please try to rewrite what you're doing with other operations. If error is occurring somewhere inside PyTorch internals, please file a bug report.

I tried using torch.select but that requires passing the index as an int rather than Tensor so it must call .item() interally. Is there a workaround that already exists for this?

Just figured out what you can do,
def gather(x, index):
  return torch.gather(x, 0, index)

out = vmap(gather, in_dims=(0, 0))(x, index)
print(out) #returns vector of 64


Add Poimandres Theme

Which @codeimage/* package(s) are relevant/releated to the feature request?
highlight
Description
Hi, just wondering if you’re open to PRs for new themes.
I’d like to add the Poimandres theme if so.

Hi Kalmarv, yes these prs are fine 😄
The README is not complete so I am writing you some information here to build it, and if you need any help, write me.

The createPrismJsTheme doesn't exist anymore, you should use the newest createTheme function which provides a theme for the editor including autocomplete, dropdown, box preview etc. Here you can find the latest added theme with an example https://github.com/riccardoperra/codeimage/blob/main/packages/highlight/src/lib/themes/githubDark/index.ts

Each theme must be in his own folder and must exports two files: index.ts and .ts

To compile the theme you should add in the array the folder name you used https://github.com/riccardoperra/codeimage/blob/6e3dd296ee1e6f61fb93bfcdb5f6c5233749fb16/packages/highlight/rollup.config.ts#L9

Remember to add the module and type definition in package.json https://github.com/riccardoperra/codeimage/blob/6e3dd296ee1e6f61fb93bfcdb5f6c5233749fb16/packages/highlight/package.json#L119

if you need to test it in the application, you should import dynamically the theme in the registry
https://github.com/riccardoperra/codeimage/blob/main/apps/codeimage/src/state/theme/themeRegistry.ts (order of this array matter, i think I would put it under the synthwave84 theme)


Rule prefer-object-spread should not work when the first argument of Object.assign is not {}

Bug Report

TSLint version: 5.7.0
TypeScript version: 2.5
Running TSLint via: VS Code

TypeScript code being linted
const values = [2, 3, 4, 5]
const obj = values.reduce(
    (o, v, i) => Object.assign(o, {[i]: v}),
    {},
)

with tslint.json configuration:
"prefer-object-spread": true,

Actual behavior
[tslint] 'Object.assign' returns the first argument. Prefer object spread if you want a new object. (prefer-object-spread)

Expected behavior
I actually want assign properties to the first argument, I want this side effects, it is common in reducing. The reasonable tips appearing is using Object.assign({}, o1, o2), it should be suggested to using spread instead of. What I'm using is the Object.assign designed for.

While I agree that your code is valid, the rule is still right in this case. You can simply convert your code as follows:
const values = [2, 3, 4, 5]
const obj = values.reduce(
    (o, v, i) => ({...o, [i]: v}),
    {},
)

It yields the same result. In some other cases it even provides better type inference and checking. That's why the rule suggests object spread in the first place.

Regarding your feature request there are two possible options:

add an option to turn off the extensive check if the first parameter is not an object literal
change the rule to only do the basic check by default and add an option to enable the extensive check

If we eventually will merge all properties, why we have to spread properties out?
Moreover, if we wanna try such a meta programming:
const o = {
    a: 42
}

Object.defineProperty(o, 'a', {
    set(value) {
        console.log(value)
    }
})

// A
const oo = Object.assign(o, { a: 7 })
// B
const ooo = Object.assign({}, o, { a: 7 })
// C
const oooo = { ...o, ...{ a: 7 }}

Object.assign will trigger the setter and spread operator won't. Statement A print the '7', B and C have the same behavior. I think C shouldn't be a replacement for A but B.

Since Object.assign modifies the first argument, wouldn't the fixer potentially break code?
var o1 = { a: 1 };
var o2 = { b: 2 };
var o3 = { c: 3 };

var obj = Object.assign(o1, o2, o3);
console.log(obj); // { a: 1, b: 2, c: 3 }
console.log(o1);  // { a: 1, b: 2, c: 3 }, target object itself is changed.

if (o1.b === 2) {
    // this would no longer run if Object.assign is changed to `{...o1, ...o2, ...o3}`?
}

If that's correct, I definitely think that the rule should only trigger when the first argument is a literal. In fact this could be considered a bug.

It seems there is a bug with auto-fixing Object.assign, e.g.:
const arr = ['a', 'b', 'c']
const arrMod = Object.assign([], arr, {1: 'd'})
Array.isArray(arrMod)

which will return true (still an Array)
Will be autofixed as:
const arr = ['a', 'b', 'c']
const arrMod = {...[], ...arr,  1: 'd'}
Array.isArray(arrMod)

which will return false (not an Array)

One more scenario when rules works incorrect
class Foo {
    handleBar() {
        console.log('bar handled');
    }
}

const foo = new Foo();

const bar: any = Object.assign(foo, {prop: 'ok'}); // <-- tslint suggest to replace with spread but it dramatically changes semantic

bar.handleBar();

It's definitely a bug in the fixer, not an enhancement. Please change the label.

I'm suggesting that the default behavior of the rule (the proposed "basic" check) should work the same as the ESLint rule. not talking about configuration there

Removing the Type: Breaking Change label per #4811. Now accepting PRs!

💀 It's time! 💀
TSLint is deprecated and no longer accepting pull requests other than security fixes. See #4534. ☠
We recommend you instead use typescript-eslint to lint your TypeScript code with ESLint. ✅
👋 It was a pleasure open sourcing with you!

🤖 Beep boop! 👉  TSLint is deprecated 👈 (#4534)  and you should switch to typescript-eslint! 🤖
🔒 This issue is being locked to prevent further unnecessary discussions. Thank you! 👋


Color scheme + Fonts suggestions for entire project

This are some of changes that I feel.

This are some of changes that I feel.

Good, but @khushi935 , we have to make a new website from scratch. We will use old website just as a source of motivation, to know how was it done previously.
We aim to build an Amazing new website for the project, that will have  added functionality and better user experience.

Okay, I got it😊

Have a look here first of all https://github.com/himanshu007-creator/SFC-foundations/issues/12

@himanshu007-creator  Can I work on this issue? I would like to solve this problem as a part of GirlScript Summer of code 2021.

@himanshu007-creator Can I work on this issue? I would like to solve this problem as a part of GirlScript Summer of code 2021.

Hi @Mukta-Sawant , you are most welcomed to work on this issue, Please have a look here and you will know the drill.
Best of luck.

Hi, i want to contribute as a participant of gssoc'21

@Mukta-Sawant   yes you can work on it. We just need an idea like how you will proceed. As we are redesigning everything so everything will be changes and so will the site structure. We just need to know how you are going to implement it. Prepare a prototype of code and send it within this week. Best of luck!

@himanshu007-creator  sir can i implement it ? I will send u a prototype of this code .
Please Assign it to me

@mansijain980  make it soon

@himanshu007-creator i was working on a hackathon and sry for delay .....I will submit it soon.
Thanks

doesn't work


Update wiki pages on compilation, debugging and Chombo timers

I should update the Wiki pages on compilation to include the content in my slides from the last GRChombo meeting (26/03/2020).

Also should write a page on how to build PETSc.


Fallback to nodejs binary if node was not found

Deals with Ubuntu's non standard node binary, which is called nodejs.

I confirm it works on a fresh Ubuntu 14.04 installation.

It works in OS X as well.

Doesn't work on Windows. I tried various workarounds but NPM will not make the correct symlink in Windows except the shebang is #!/usr/bin/env node.


Call param() middleware before the first actual match.

Fix the param matching to behave exactly the same as koa-router or express.
Its useful for cases where you have routes with params on the same level as hardcoded ones.
e.g.
/messages/compose
/messages/:messageId

If the first matched middleware is final (does not call next()) - there is no need to call the param for :messageId. And then its safe to ctx.throw or to do the auth logic inside the param middleware without breaking the first route.
I'm not sure about the correctness of the patch itself, but it doesn't break any existing tests.

Yes you right, all params are concat before compose and i think your solution is nice.


Update README.md

Corrected the grammar in the flow diagrams.
Summary
The text in the flow diagram was slightly incorrect, as it was mixing tenses.

Thanks!