UX Researcher: Creating Interview Script - Batch 1: (Approval) Workflows

I am going to modify my base interview questions and scope them down to create an interview script for the interviews with our primary users: Jeremy and Allen.
This portion of the interview script will focus on team (approval) workflows around content creation. #296
Feature: Create interview script for user interviews with Jeremy and Allen
  As a UX researcher
  I want to create an interview script from my list of interview questions crafted for the CMS UX that is catered to the role of the specific interviewee around understanding their team (approval) workflows for content creation
  So that I can make sure to ask the interviewee specific questions that will be relevant to their team workflows in creating content

 Scenario: Craft interview script for Jeremy
    Given that Jeremy will be the main user entering marketing content into our CMS
     When I go to craft his interview script centered around his team's workflows
     Then I will able to ask Jeremy the questions that will allow me to gather data to understand the marketing team content creation workflow, which includes creating revisions for review
      And previewing / reviewing revisions
      And approving / publishing revisions
      And communication around revision edits/ changes
      And expectations for using the CMS as part of their content creation workflow

Scenario: Craft interview script for Allen
    Given that Allen will be the main user entering ID content into our CMS
     When I go to craft his interview script centered around his team's workflows
     Then I will able to ask Allen the questions that will allow me to gather data to understand the ID team content creation workflow, which includes creating revisions for review
      And previewing / reviewing revisions
      And approving / publishing revisions
      And communication around revision edits/ changes
      And expectations for using the CMS as part of their content creation workflow

Research Interview Script

[ ] Create interview script for Allen around understanding team (approval) workflows
[ ] Create interview script for Jeremy around understanding team (approval) workflows

Blocker to #415

@ineedsubstance @joshkimmell @poofichu @Snugug @scottnath @SirSpidey
Wrote this story for researching team approval workflows.

@mkiang3051 - see my comments on #415 for this story as well

Link to interview script on Box: https://ibm.box.com/s/3qcrna0siatds3c9lme34ebm6k1i1yad

This is done.


Unsure what git commit an Indexer is running

Add a REST endpoint (e.g. /version or /about) that provides the git commit ('git rev-parse --short=8 HEAD) this Indexer instance was built against.
Note that the --version for the CLI returns mina-indexer 0.1.1 (due to this in Cargo.toml).

This relates to https://github.com/Granola-Team/mina-block-explorer/issues/698 and the implementation PR #702:

I was going to suggest adding a build.rs but you beat me to it. You could use something like the BUILDKITE_COMMIT env variable to set this value in CI/CD

For consistency, please use the output of 'git rev-parse --short=8 HEAD', run at build time.

For simplicity sake, I fixed the CLI version command to include the git commit hash. If we really want to add an API, it should be another issue.


Support Debian Bookworm

Instead of just sticking with Bullseye (Debian 11), let's include Bookworm (Debian 12).
Debian 12.4 was released on December 10th, 2023. Debian 12.0 was initially released on June 10th, 2023
https://www.debian.org/releases/bookworm/
Obviously this means the tagging convention will need to be revisited.

This is done


Limit to certain file types

It would be a great feature is a user could limit the files highlighted to a whitelist (CSS, Python, MD, and JS) or a blacklist of ignored file types. If not in ColorHighlight, is there an easy method in Sublime? I looked into modifying syntax-specific files, but it didn't seem like that feature was available

+1
I have some long-ass markdown files and this plugin slows sublime text to a crawl. A user setting like this: "file_extensions": ["scss", "sass", "css", "pcss"] would be useful.

+1 yes please because...

I agree. This alternative but similar package seems to offer the missing functionality.

PLS "file_extensions": ["css", "styl", "stylus"] would be useful.


Best model in ModelCheckpoint

🚀 Feature
Add a best_model attribute in ModelCheckpoint.
Motivation
After training, it would be nice to easily have the path to the checkpoint with the best val loss.
Or is there an argument in the trainer to resume best state after training and I missed it? (totally possible)

BTW, this is my solution but I don't think this should be necessary
best_k = checkpoint.best_k_models
best_path = [b for b, v in best_k.items() if v == torch.min(best_k.values())][0]

@mpariente Better condition will be:
best_k = checkpoint.best_k_models
best_path = [b for b, v in best_k.items() if v == checkpoint.best)][0]

checkpoint.modecan be max though.

True, thanks, but this still doesn't change the fact that a best_model_path attribute should be integrated in the checkpoint IMO

The save_top_k parameter saves the last k best models. When put to -1 it saves all models. The latest master version also has a save_last parameter that also keeps the latest epoch of the model.
E.g:
checkpoint_callback = ModelCheckpoint(
        filepath=os.getcwd()+"/"+"<your-folder>"+"/{epoch}-{val_loss:.6f}",
        save_top_k=1,
        verbose=False,
        monitor='val_loss',
        mode='min',
        prefix=net.__class__.__name__+"_"
    )

This results in a file called: UNet_epoch=5-val_loss=0.581735

Thanks for the example, I also use it like that.
Still, asking the user to reverse the dict or look for the best loss in the filenames is not super user-friendly. It asks few (not many) additional lines of code which are not necessary, don't you think?

this is already in master

Oh ok, sorry for bothering then, I should have checked master
Thanks for the pointer William

it's a great idea :) just someone beat you to it haha


Newbie Help

Hello,
I have Harmony-api installed on my Pi, but like many others that i've seen, find that it lacks the functionality of being able to control the individual devices, so I am trying KuKuHarmony. I'm new, so trying to decipher exactly what i'm supposed to be doing. in following the directions, I get the error:

I imagine that the container in use is from the Harmony-api. Does KuKuHarmony take the place of the Harmony-api, or does in run with the api?
Appreciate the help!

That command is called to make and start container at first.
So if you did once, to start again container you run command 'docker start harmony-api'.

Ok., thanks. That makes sense. If i'm understanding corrrecty, once I start, and then created the container, I run the command:
sudo systemctl enable /etc/systemd/system/harmony-api.service
Or is that supposed to be part of the container? I get the following error when trying to run the command:

Also, I'm not sure where to add the DTH, like you have in the instructions:


Feature/transformer

#734 LayerNorm and Transformer layers for Bert, testing should be done for the whole complete model

Codecov Report

Merging #744 into 2.2-dev will decrease coverage by 2.74%.
The diff coverage is 17.94%.

@@             Coverage Diff             @@
##           2.2-dev     #744      +/-   ##
===========================================
- Coverage    94.11%   91.36%   -2.75%
===========================================
  Files           92       94       +2
  Lines         3125     3242     +117
===========================================
+ Hits          2941     2962      +21
- Misses         184      280      +96

Impacted Files
Coverage Δ

matchzoo/layers/transformer.py
16.43% <16.43%> (ø)

matchzoo/layers/layer_normalization.py
20.45% <20.45%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d133cb4...08a32cd. Read the comment docs.


KeyError: 'Unable to open object (component not found)'

When I tried to train a cql agent with the following command:
python robomimic/scripts/train.py --dataset datasets/can/mg/low_dim_sparse.hdf5 --config robomimic/exps/templates/cql.json

An error occurs:
run failed with error:
'Unable to open object (component not found)'

Traceback (most recent call last):
  File "robomimic/scripts/train.py", line 355, in main
    train(config, device=device)
  File "robomimic/scripts/train.py", line 132, in train
    config, obs_keys=shape_meta["all_obs_keys"])
  File "/home/quan/robomimic/robomimic/utils/train_utils.py", line 106, in load_data_for_training
    train_dataset = dataset_factory(config, obs_keys, filter_by_attribute=train_filter_by_attribute)
  File "/home/quan/robomimic/robomimic/utils/train_utils.py", line 153, in dataset_factory
    dataset = SequenceDataset(**ds_kwargs)
  File "/home/quan/robomimic/robomimic/utils/dataset.py", line 116, in __init__
    self.load_demo_info(filter_by_attribute=self.filter_by_attribute)
  File "/home/quan/robomimic/robomimic/utils/dataset.py", line 170, in load_demo_info
    self.demos = [elem.decode("utf-8") for elem in np.array(self.hdf5_file["mask/{}".format(filter_by_attribute)][:])]
  File "h5py/_objects.pyx", line 54, in h5py._objects.with_phil.wrapper
  File "h5py/_objects.pyx", line 55, in h5py._objects.with_phil.wrapper
  File "/home/quan/anaconda3/envs/hand/lib/python3.7/site-packages/h5py/_hl/group.py", line 305, in __getitem__
    oid = h5o.open(self.id, self._e(name), lapl=self._lapl)
  File "h5py/_objects.pyx", line 54, in h5py._objects.with_phil.wrapper
  File "h5py/_objects.pyx", line 55, in h5py._objects.with_phil.wrapper
  File "h5py/h5o.pyx", line 190, in h5py.h5o.open
KeyError: 'Unable to open object (component not found)'

But when I train a cql agent in a human-generated dataset, everything works fine with the following command
python robomimic/scripts/train.py --dataset datasets/can/mh/low_dim.hdf5 --config robomimic/exps/templates/cql.json

Does anyone know what's wrong with it?

This is because the default training config tries to use a validation data subset, but the machine-generated data doesn't have a validation subset. I recommend using the instructions here to generate configs that correspond to our experiments on the machine-generated datasets. Alternatively, you can create a train-valid split in that dataset if you'd like - see here for more information. Hope that helps!


[Coverity CID :203393]Control flow issues in /subsys/bluetooth/controller/ll_sw/ull_conn.c

Static code scan issues seen in File: /subsys/bluetooth/controller/ll_sw/ull_conn.c
Category: Control flow issues
Function: length_req_rsp_recv
Component: Bluetooth
CID: 203393
Please fix or provide comments to square it off in coverity in the link: https://scan9.coverity.com/reports.htm#v32951/p12996

#else /* CONFIG_BT_CTLR_PHY */
4024                        lr->max_rx_time = eff_rx_time;
4025                        lr->max_tx_time = eff_tx_time;
4026#endif /* CONFIG_BT_CTLR_PHY */
4027                }
4028        } else {
4029                /* Drop response with no Local initiated request. */
4030                LL_ASSERT(pdu_rx->llctrl.opcode ==
4031                          PDU_DATA_LLCTRL_TYPE_LENGTH_RSP);
4032        }
4033
4034send_length_resp:
4035        if (tx) {
    	const: At condition nack, the value of nack must be equal to 0.
    	dead_error_condition: The condition nack cannot be true.
4036                if (nack) {

CID 203393 (#1 of 1): Logically dead code (DEADCODE)
dead_error_line: Execution cannot reach this statement: mem_release(tx, &mem_conn_t....
4037                        mem_release(tx, &mem_conn_tx_ctrl.free);
4038                } else {
4039#if !defined(CONFIG_BT_CTLR_PHY)
4040                        length_resp_send(conn, tx, eff_rx_octets,
4041                                         eff_tx_octets);
4042#else /* CONFIG_BT_CTLR_PHY */
4043                        length_resp_send(conn, tx, eff_rx_octets,
4044                                         eff_rx_time, eff_tx_octets,
4045                                         eff_tx_time);
4046#endif /* CONFIG_BT_CTLR_PHY */
4047                }
4048        }
4049


Contribute an infographic for the wiki.

Is your feature request related to a problem? Please describe.
An infographic is a good and interactive way to give information about a project.
Describe the solution you'd like
Contribute a good infographic with relevant information, statistics and diagrams that concern this project.
Additional context
Refer the following images for design ideas:

https://www.iotworldtoday.com/files/2017/03/IoT-GWS-Infographic-1-11-17.gif
https://s3.amazonaws.com/thumbnails.venngage.com/template/0fa452b4-749d-4150-8f88-415c80265fe4.png
https://www.libelium.com/wp-content/uploads/2018/11/water_report_benefits.jpg

Hello @PragatiVerma18  I'll like to contribute. Please assign me this issue.

Here is a one minimal infographic showing the main important elements. Please help where to upload

I would like to contribute to this Pragati! Please assign this issue to me.

How should I create a PR request for the same?

I would like to contribute

@meghaa105 Thanks for showing your interest. Please share your ideas here.

@PragatiVerma18    I would like to work on this issue please assign it to me .

This is the infographic I designed for this project .

@Swarnimashukla Please make a PR.

@Swarnimashukla That's awesome. 👏 May I know which platform have you used to create this? Please add the raw file too.

thanks @PragatiVerma18 @vinitshahdeo  , I used venngage to create this .

water pie chart


Add basic documentation - how slashtags works

It would be great to have some simple doumentation on how slashtags works, with links on how to directly try it out without having to build it yourself. I don't understand how the full flow works but hope this is somewhat in the right direction.

Thanks @rolznz, I really appreciate the initiative, but it goes to show why I prefer building demos, especially ones that don't need to be built to be experienced (e.g slash-wallet.netlify.app).
What is described in this PR change, is the Authentication/Connection mechanism, as it currently stands. Which is both subject to change, but also is only a part of what Slashtags is set to be.
Slashtags is supposed to enable a decentralized WoT by having 2 main primitives in place:
1- Slashtags Identifiers (DID method, to control your identity and sign claims)
2- Personal Data storage (to save, and retrieve documents that make up this WoT)
Authentication is just one use case for decentralized identifiers, and should not be the focus. If anything is worth documenting it would be the general philosophy and goals, but I would rather put more demos in everyone's hands as often as possible.

@Nazeh thanks for the additional information. It's great to see the power of what slashtags could do. The demo mostly works great, but this repository just feels a bit dead, without links and hard for people to see what the progress is and where things are going.
Maybe at least the demo links could be added to the main README or demo README so that people don't have to try build it (especially since the demos built from scratch might not work like they don't now).

It is pretty much not dead, but most of the work is on other branches than Master, but fair enough, I will feature the demos in the main README and maybe an up-to-date description of what we are currently working on/roadmap.

Thanks, Nazeh!


regen: Release of version 0.22a

added forevery(IList,IList, bool)
added forevery(IList,IList, IList, bool)
fixed extra newline at the beggining of an output after every compile.


Winter '17, Manage Household page hits error copying address to added contact

in Winter '17, if you add an existing contact to the household with the autocomplete control, you will see the error "unable to read sobject" get displayed in the header, and the household's street will copy to the added contact, but not city, state, or zip.

**lurch: add

Tracking W-011365


vm: separate JavaScript code compilation from execution

Right now we run them one after the other, but the original source code is no longer needed after we compile it to JavaScript, so we can free it.
This means that we also do more work before we actually run the code, so it might not be beneficial.

Closing. The code being executed is now freed as soon as it's loaded onto Duktape.


feat: fix root hash, add DAG testcases, DFS function

There is a bug due to an incorrect root hash that causes multiple roots to appear when adding a vertex. Additionally, there are missing test cases for checking DAG compatibility, which I have added. I've also modified the DFS functions, which are invoked during topological sorting.

lgtm


Z-Wave entity is not correctly named

Home Assistant release with the issue:
0.66
Last working Home Assistant release (if known):
0.62? Not sure, looks like an issue since the entity_registry has been introduced
Operating environment (Hass.io/Docker/Windows/etc.):
Raspbian
Component/platform:
Z-Wave
Description of problem:
When adding a new Z-Wave device and renaming it through the Z-Wave control panel, it won't be reflected on the entity_registry name. This makes a huge mess, since your Z-Wave devices will have multiple different names and you can't easily keep them apart. It only happens to devices that have been added recently.
For example, if your Z-Wave device is named multisensor2 through the control panel:
binary_sensor.sensor (current) instead of binary_sensor.multisensor2_sensor (previous)
sensor.neo_coolcam_unknown_type0003_id108d_burglar (current) instead of sensor.multisensor2_burglar
If I have a look at the same multisensor that has been added before:
binary_sensor.multisensor_sensor
sensor.multisensor_burglar
If I look at the values for binary_sensor.sensor, the friendly_name is updated with the Z-Wave name (multisensor2). But the entity itself isn't updated with the new name, which is still described in the Zwave Docs.
value_index: 0
node_id: 8
value_instance: 1
value_id:<PHONE_NUMBER>7126400
friendly_name: multisensor2 Sensor

(I solved it for myself by renaming the name in the entity_registry.yaml, however this isn't a recommended approach and in that case the Z-Wave documentation should be updated)

I've had this problem on 2 different setups with zwave components.

@iMicknl entity registry for zwave is covered here: https://www.home-assistant.io/docs/z-wave/control-panel/#z-wave-node-management

And this is a duplicate of #12430

Great, thanks for the clarification @fanaticDavid & @dshokouhi. I couldn't find any issue while searching on my keywords. :-)
However I think this should also be added to the documentation page I linked to, since the information there isn't accurate anymore.

@iMicknl anyone can click on the "edit this page in github" link and submit a PR to update it. :)

Closing because it's a duplicate.


Allow cloud credential usage for owned clusters

If a user is an owner of a cluster, then they should be allowed to use
the cloud credential associated to that cluster in the meta proxy. This
really only applies to KEv2 and RKE2/K3S provisioned clusters because
those clusters have cloud credentials associated to them.
In addition, if a user is a owner of a cluster, they should also be able
to change the cloud credential associated to a cluster to a cloud
credential they own regardless if they have access to the old cloud
credential.
This PR also fixes an obscure issue when running Rancher in a debugger (see the second commit message for details).
Issues:
https://github.com/rancher/rancher/issues/35413
https://github.com/rancher/rancher/issues/34800

The implementation was reworked to allow cloud credential usage if a user has access to any cluster associated to the cloud credential.


New version: Turing v0.19.3

Registering package: Turing
Repository: https://github.com/TuringLang/Turing.jl
Created by: @devmotion
Version: v0.19.3
Commit: ac99fb0d116dc9edf7a9df6df44c990a8fcd3945
Reviewed by: @devmotion
Reference: https://github.com/TuringLang/Turing.jl/commit/ac99fb0d116dc9edf7a9df6df44c990a8fcd3945#commitcomment-62468585
Description: Bayesian inference with probabilistic programming.

Turing doesn't support Julia 1.7 yet since  the binary dependency Libtask_jll does not support it. Hopefully the problem will be fixed soon by using Libtask 0.6 which is based on a different approach and does not depend on Libtask_jll.

Ok, would you like this manually merged @devmotion?

Yes 🙂


AnimationTreePlayer: blend value tracks (intended to close #2299)

Someone should check this to make sure I'm not doing something stupid...I added the following methods to Variant:

zero() sets a Variant to the appropriate type of zero value
blend() blends part of one Variant on top of another (a + k*b)

Then I used them to clear/blend values for value tracks in AnimationTreePlayer::_process_animation. I have two questions:
blend() doesn't handle arrays and strings the way interpolate does. Is it possible to create string or int array (real array etc) keys on an animation?
Does every element of an AnimationTreePlayer's track_map have a valid property name, or should I be checking for empty/invalid names?

Er...I thought you decided this was a bug? You make a feature that's important enough to brag about on your home page, but it only works with animations imported from Blender because you didn't take the half-hour to make it work with the built-in animations?  That seems like a bug to me...

I don't know but honestly the tag I use is not that important. And whether a not implement feature is a bug, that's very subjective :) Here you are adding a whole new blend() function, so I could tag it as "feature proposal", or "enhancement" as it makes AnimationTreePlayer better, or "bug" if we consider that AnimationTreePlayer's handling of Animation::TYPE_VALUE is bogus.

OK, fair enough. I didn't mean to claim that you're slacking off. But I do think it's very bad to be advertising features that aren't implemented yet. If you say that an AnimationTreePlayer is an "Animation Player that uses a node graph for blending"  with no mention anywhere that I can find that, oh, yeah, it doesn't work for normal animations that you create in the Godot editor...that's a big omission.
To me, misleading documentation is worse than no documentation.  Also it's perfectly reasonable to run short of time and have to leave something undone, and maybe you don't have time to make an issue, but if it's not just throwaway code you could at least tag it with a TODO or XXX comment so the team doesn't miss it when checking on what needs to be done, or, you know, leave glaring omissions when writing docs for the code.
But it's your project, so I'll stop complaining now and get back to helping make it better. :)

It's true that there are quite a few "visible" features that have actually no code behind, or big chunk of commented out code without explanations. Most of the code was written by @reduz, and he hasn't always used the best practices in this regard, though it's much better nowadays.
Now the project is gaining momentum and good practices are starting to be introduced, but it's of course a huge work :) If you do see unimplemented or broken stuff exposed in the editor, please open an issue for it so that it isn't forgotten. Same thing for big chunks of commented out code with no explanation.

When this fix will be merged?, I'm using AnimationTreePlayer and it would be nice to get this fixed.

I think it could be merged now, thanks for the reminder. However, I'd be glad if @JoshuaGrams could have a look at cleaning the git history, as there are 12 commits for only 3 that are meaningful. The first two commits revert each other, so I'd remove them altogether when rebasing. Rebasing should also hopefully remove all the "merge branch" commits.
I'd make a copy of the relevant commits first though, as git can be weird and strange stuff could happen :D

Yeah, always a little scary doing that. OK, history rewritten. I just squashed it all into one commit.

Alright, that does the trick too, thanks. I'll merge it once the travis check is done.


Use OpenSSL/libsodium binding for shared secret computation (when possible)

Follow-up of #5.
Thanks to #147, we generate the encryption keys with OpenSSL, when possible.
We're still using PHP to compute the shared secret though. It's not yet possible (to my knowledge) to do it with OpenSSL or libsodium, but if it becomes possible, please comment on this issue or (better) send a PR to fix it.

Hi @ozgurhangisi,
Sorry for the very late reply.
I confirm that the key agreement computation on PHP 7.3 will use the new openssl_pkey_derive function.
This will be available in few days.
The first tests I ran showed that this operation is approx 50 to 80 times faster than the pure php method.
So stay tuned!


python37Packages.braintree: 3.50.0 -> 3.51.0

Semi-automatic update generated by https://github.com/ryantm/nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/python3.7-braintree/versions.
meta.description for python37Packages.braintree is: '"Python library for integration with Braintree"'.

Checks done (click to expand)

built on NixOS

0 of 0 passed binary check by having a zero exit code.

0 of 0 passed binary check by having the new version present in output.

found 3.51.0 with grep in /nix/store/nps0daq48kbv5pf7czllsir7an5b09cq-python3.7-braintree-3.51.0

directory tree listing: https://gist.github.com/5a7a94789f83ba7058c85f4553a2c84b

du listing: https://gist.github.com/5d890cb7d63f192d5c24e85efc9e7554

Rebuild report (if merged into master) (click to expand)

8 total rebuild path(s)
2 package rebuild(s)
2 x86_64-linux rebuild(s)
2 i686-linux rebuild(s)
2 x86_64-darwin rebuild(s)
2 aarch64-linux rebuild(s)
First fifty rebuilds by attrpath
python27Packages.braintree
python37Packages.braintree

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/nps0daq48kbv5pf7czllsir7an5b09cq-python3.7-braintree-3.51.0 \
  --option binary-caches 'https://cache.nixos.org/ https://r-ryantm.cachix.org/' \
  --option trusted-public-keys '
  r-ryantm.cachix.org-1:gkUbLkouDAyvBdpBX0JOdIiD2/DP1ldF3Z3Y6Gqcc4c=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(r-ryantm's Cachix cache is only trusted for this store-path realization.)
Or, build yourself:
nix-build -A python37Packages.braintree https://github.com/r-ryantm/nixpkgs/archive/16b573049c2ad4ec7bed2c0499e31177e40f42f0.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/nps0daq48kbv5pf7czllsir7an5b09cq-python3.7-braintree-3.51.0
ls -la /nix/store/nps0daq48kbv5pf7czllsir7an5b09cq-python3.7-braintree-3.51.0/bin

cc @ivegotasthma for testing.

I built this with nix-review. Seems to work fine.


Adding Tests for kitties piece

closes #53

@JoshOrndorff refactored boilerplate away should be good to go now.


How to use this for previous contests?

I tried the script for an old contest. Then run it using resolver. It gave an error saying no submission found. Then I checked the JSON and there was no submission indeed.
What to do if I want to test it using a cf contest that has already happened?

Could you tell me which contest you used? I've only tested this for public gym contests, not sure if it works for standard CF ones.

stale issue, and API has been upgraded.


Mod crashes server on using /home command

Here is the server and crash log.
It sets and saves homes fine
crash-2024-11-17_21.38.21-server.txt
latest.log

Hey it seems you are using 1.21.3, that version changed something with the teleporting that causes it to crash.
If you want you can use this updated version in the meantime that i havent uploaded on modrinth yet: https://github.com/MrSn0wy/TeleportCommands/actions/runs/11797357856
On the bottom of the page download the Artifacts and then extract it locally, then get the jar for your mod loader in one of the folders.
I will upload it on modrinth in a few days, i was working on improving the error handling so i didnt release it yet

I did test your unreleased one
It did work fine, no issues that I saw

Not sure if it is possible to do easy
But i was thinking that it might be neat if one could set a few global destinations as an admin
that normal players could then use.
like to recall to world spawn
or a few other areas if the server has some set up
they could like type /goto
be up to the ops to make the locations known.
I like that his mod doesnt need world objects and resource packs etc

I did test your unreleased one It did work fine, no issues that I saw

Awesome!

Not sure if it is possible to do easy But i was thinking that it might be neat if one could set a few global destinations as an admin that normal players could then use.
like to recall to world spawn or a few other areas if the server has some set up they could like type /goto
be up to the ops to make the locations known.

I really like that idea, currently working on implementing it and thinking of just naming it /warp, shouldn't be too difficult. Will try to make a release with it today!

Hey sorry for saying i would finish it in a day heh~
Some stuff came in between, howeve i have added a /warp and a /worldspawn command to the mod!

Gonna close the issue now


ISPN-8974 Nullify marshaller/unmarshaller is instance cache too big

@danberindei Addressed both comments

Wow, lots of test failures on 8.2.x! At least the core non-xsite tests look good on my machine, so I'm integrating it :)

Interesting enough, I only got one test failure running the xsite tests on my machine, but pretty much all of them are failing in CI.


Pod is stuck in terminating: runc did not terminate sucessfully: container does not exist

Description
A kubernetes pod is stuck in terminating:
trace-resolver-intake-1-2-3-6496f5896c-wjrpz                      0/1     Terminating             0          21d

kubectl get po some-trace-resolver-pod-wjrpz -o json | jq .status.containerStatuses

[
  {
    "containerID": "containerd://dc2ca0615937ecc648dd5a6c64aff5c0993c3b0f31dbccd55fe2849371204bdc",
    "image": "trace-resolver:v2",
    "imageID": "trace-resolver@sha256:***",
    "lastState": {},
    "name": "trace-resolver",
    "ready": false,
    "restartCount": 0,
    "state": {
      "running": {
        "startedAt": "2020-01-21T13:58:22Z"
      }
    }
  }
]

On the host:
journalctl -o cat -u containerd

time="2020-02-12T13:12:54.556721052Z" level=info msg="StopPodSandbox for "4498f5a09d782a7fb5c662f20b3bdbba8260e086f32529d4d56097cf8bf4445d""
time="2020-02-12T13:12:54.556777390Z" level=info msg="Container to stop "e77efe7990700916123241ab4af14d7d9f0d262b2467a146aceb83af85274cb3" must be in running or unknown state, current state "CONTAINER_EXITED""
time="2020-02-12T13:12:54.560359783Z" level=info msg="Kill container "dc2ca0615937ecc648dd5a6c64aff5c0993c3b0f31dbccd55fe2849371204bdc""
time="2020-02-12T13:12:54.564680513Z" level=error msg="StopPodSandbox for "4498f5a09d782a7fb5c662f20b3bdbba8260e086f32529d4d56097cf8bf4445d" failed" error="failed to stop container "dc2ca0615937ecc648dd5a6c64aff5c0993c3b0f31dbccd55fe2849371204bdc": failed to kill container "dc2ca0615937ecc648dd5a6c64aff5c0993c3b0f31dbccd55fe2849371204bdc": unknown error after kill: runc did not terminate sucessfully: container "dc2ca0615937ecc648dd5a6c64aff5c0993c3b0f31dbccd55fe2849371204bdc" does not exist

crictl pods

POD ID              CREATED             STATE               NAME                                           NAMESPACE                  ATTEMPT
4498f5a09d782       3 weeks ago         Ready               trace-resolver-intake-1-2-3-6496f5896c-wjrpz   apm-firehose               0

crictl ps

sudo crictl ps
CONTAINER ID        IMAGE               CREATED             STATE               NAME                       ATTEMPT             POD ID
dc2ca0615937e       6380989e35b3b       3 weeks ago         Running             trace-resolver             0                   4498f5a09d782

Process tree of the containerd-shim, without any children:
root     29561   776  0 Jan21 ?        00:14:19  \_ containerd-shim -namespace k8s.io -workdir /var/lib/containerd/io.containerd.runtime.v1.linux/k8s.io/dc2ca0615937ecc648dd5a6c64aff5c0993c3b0f31dbccd55fe2849371204bdc -address /run/containerd/containerd.sock -containerd-binary /usr/local/bin/containerd -debug

find  /var/lib/containerd -name dc2ca0615937ecc648dd5a6c64aff5c0993c3b0f31dbccd55fe2849371204bdc -exec ls -Rl {} \;

/var/lib/containerd/io.containerd.runtime.v1.linux/k8s.io/dc2ca0615937ecc648dd5a6c64aff5c0993c3b0f31dbccd55fe2849371204bdc:
total 0
prwx------ 1 root root 0 Jan 21 13:58 shim.stderr.log
prwx------ 1 root root 0 Feb 12 13:12 shim.stdout.log
/var/lib/containerd/io.containerd.grpc.v1.cri/containers/dc2ca0615937ecc648dd5a6c64aff5c0993c3b0f31dbccd55fe2849371204bdc:
total 4
-rw------- 1 root root 145 Jan 21 13:58 status

sudo ctr -n k8s.io c ls

dc2ca0615937ecc648dd5a6c64aff5c0993c3b0f31dbccd55fe2849371204bdc    sha256:6380989e35b3b3cf22e491f5497b3437f713c191ae7e49147ffc19964461030a    io.containerd.runtime.v1.linux

jq /var/lib/containerd/io.containerd.grpc.v1.cri/containers/dc2ca0615937ecc648dd5a6c64aff5c0993c3b0f31dbccd55fe2849371204bdc/status

{
  "Version": "v1",
  "Pid": 29578,
  "CreatedAt":<PHONE_NUMBER>238074600,
  "StartedAt":<PHONE_NUMBER>390671000,
  "FinishedAt": 0,
  "ExitCode": 0,
  "Reason": "",
  "Message": ""
}

kill -USR1 29561 ; journalctl -u containerd -o cat -e

time="2020-02-12T13:12:52Z" level=info msg="=== BEGIN goroutine stack dump ===
goroutine 29 [running]:
main.dumpStacks(0xc00006a5a0)
	/home/travis/gopath/src/github.com/containerd/containerd/cmd/containerd-shim/main_unix.go:259 +0x88
main.executeShim.func1(0xc000076780, 0xc00006a5a0)
	/home/travis/gopath/src/github.com/containerd/containerd/cmd/containerd-shim/main_unix.go:179 +0x3d
created by main.executeShim
	/home/travis/gopath/src/github.com/containerd/containerd/cmd/containerd-shim/main_unix.go:177 +0x5e6
goroutine 1 [select]:
main.handleSignals(0xc00006a5a0, 0xc000076720, 0xc00005f0e0, 0xc00009a0c0, 0xc000153e80, 0x0)
	/home/travis/gopath/src/github.com/containerd/containerd/cmd/containerd-shim/main_unix.go:222 +0xf4
main.executeShim(0x7fc21c31c240, 0xc0000764e0)
	/home/travis/gopath/src/github.com/containerd/containerd/cmd/containerd-shim/main_unix.go:182 +0x61e
main.main()
	/home/travis/gopath/src/github.com/containerd/containerd/cmd/containerd-shim/main_unix.go:111 +0x1e3
goroutine 18 [syscall]:
os/signal.signal_recv(0x765e20)
	/home/travis/.gimme/versions/go1.11.11.linux.amd64/src/runtime/sigqueue.go:139 +0x9c
os/signal.loop()
	/home/travis/.gimme/versions/go1.11.11.linux.amd64/src/os/signal/signal_unix.go:23 +0x22
created by os/signal.init.0
	/home/travis/.gimme/versions/go1.11.11.linux.amd64/src/os/signal/signal_unix.go:29 +0x41
goroutine 19 [chan receive]:
main.main.func1()
	/home/travis/gopath/src/github.com/containerd/containerd/cmd/containerd-shim/main_unix.go:82 +0x7f
created by main.main
	/home/travis/gopath/src/github.com/containerd/containerd/cmd/containerd-shim/main_unix.go:81 +0x54
goroutine 5 [IO wait]:
internal/poll.runtime_pollWait(0x7fc21c317c90, 0x72, 0xc00009eaa8)
	/home/travis/.gimme/versions/go1.11.11.linux.amd64/src/runtime/netpoll.go:173 +0x66
internal/poll.(*pollDesc).wait(0xc0000bc498, 0x72, 0xffffffffffffff00, 0x765260, 0x9691c0)
	/home/travis/.gimme/versions/go1.11.11.linux.amd64/src/internal/poll/fd_poll_runtime.go:85 +0x9a
internal/poll.(*pollDesc).waitRead(0xc0000bc498, 0xc00015f000, 0x1000, 0x1000)
	/home/travis/.gimme/versions/go1.11.11.linux.amd64/src/internal/poll/fd_poll_runtime.go:90 +0x3d
internal/poll.(*FD).Read(0xc0000bc480, 0xc00015f000, 0x1000, 0x1000, 0x0, 0x0, 0x0)
	/home/travis/.gimme/versions/go1.11.11.linux.amd64/src/internal/poll/fd_unix.go:169 +0x179
net.(*netFD).Read(0xc0000bc480, 0xc00015f000, 0x1000, 0x1000, 0x60238f16053c53d, 0xc00009ebc0, 0x40338d)
	/home/travis/.gimme/versions/go1.11.11.linux.amd64/src/net/fd_unix.go:202 +0x4f
net.(*conn).Read(0xc000074090, 0xc00015f000, 0x1000, 0x1000, 0x0, 0x0, 0x0)
	/home/travis/.gimme/versions/go1.11.11.linux.amd64/src/net/net.go:177 +0x68
bufio.(*Reader).Read(0xc000050240, 0xc00004c0a0, 0xa, 0xa, 0x43a95d, 0xc000012178, 0x1)
	/home/travis/.gimme/versions/go1.11.11.linux.amd64/src/bufio/bufio.go:216 +0x22f
io.ReadAtLeast(0x764ae0, 0xc000050240, 0xc00004c0a0, 0xa, 0xa, 0xa, 0x2, 0x2, 0xc00009ed60)
	/home/travis/.gimme/versions/go1.11.11.linux.amd64/src/io/io.go:310 +0x88
io.ReadFull(0x764ae0, 0xc000050240, 0xc00004c0a0, 0xa, 0xa, 0x8, 0xc00009ef68, 0xc000012120)
	/home/travis/.gimme/versions/go1.11.11.linux.amd64/src/io/io.go:329 +0x58
github.com/containerd/containerd/vendor/github.com/containerd/ttrpc.readMessageHeader(0xc00004c0a0, 0xa, 0xa, 0x764ae0, 0xc000050240, 0xc00009eec8, 0x2, 0x2, 0xc00009ee48)
	/home/travis/gopath/src/github.com/containerd/containerd/vendor/github.com/containerd/ttrpc/channel.go:54 +0x60
github.com/containerd/containerd/vendor/github.com/containerd/ttrpc.(*channel).recv(0xc00004c080, 0x7683a0, 0xc00004c0c0, 0x2, 0xc000083600, 0x0, 0x0, 0x7a, 0x0, 0x0)
	/home/travis/gopath/src/github.com/containerd/containerd/vendor/github.com/containerd/ttrpc/channel.go:102 +0x6d
github.com/containerd/containerd/vendor/github.com/containerd/ttrpc.(*serverConn).run.func1(0xc000012060, 0xc00006a640, 0xc000012120, 0xc00004c080, 0x7683a0, 0xc00004c0c0, 0xc0000120c0, 0xc0000502a0)
	/home/travis/gopath/src/github.com/containerd/containerd/vendor/github.com/containerd/ttrpc/server.go:344 +0x1af
created by github.com/containerd/containerd/vendor/github.com/containerd/ttrpc.(*serverConn).run
	/home/travis/gopath/src/github.com/containerd/containerd/vendor/github.com/containerd/ttrpc/server.go:314 +0x24a
goroutine 25 [chan receive]:
github.com/containerd/containerd/runtime/v1/shim.(*Service).processExits(0xc00009a0c0)
	/home/travis/gopath/src/github.com/containerd/containerd/runtime/v1/shim/service.go:491 +0xd6
created by github.com/containerd/containerd/runtime/v1/shim.NewService
	/home/travis/gopath/src/github.com/containerd/containerd/runtime/v1/shim/service.go:91 +0x3bf
goroutine 26 [syscall, 202 minutes]:
syscall.Syscall6(0xe8, 0x9, 0xc00009c9b8, 0x80, 0xffffffffffffffff, 0x0, 0x0, 0xffffffffffffffff, 0x0, 0x4)
	/home/travis/.gimme/versions/go1.11.11.linux.amd64/src/syscall/asm_linux_amd64.s:44 +0x5
github.com/containerd/containerd/vendor/golang.org/x/sys/unix.EpollWait(0x9, 0xc00009c9b8, 0x80, 0x80, 0xffffffffffffffff, 0xffffffffffffffff, 0x765260, 0xc000100c00)
	/home/travis/gopath/src/github.com/containerd/containerd/vendor/golang.org/x/sys/unix/zsyscall_linux_amd64.go:1689 +0x72
github.com/containerd/containerd/vendor/github.com/containerd/console.(*Epoller).Wait(0xc000066740, 0xc0000c5a90, 0x8)
	/home/travis/gopath/src/github.com/containerd/containerd/vendor/github.com/containerd/console/console_linux.go:110 +0x7a
created by github.com/containerd/containerd/runtime/v1/shim.(*Service).initPlatform
	/home/travis/gopath/src/github.com/containerd/containerd/runtime/v1/shim/service_linux.go:111 +0xbb
goroutine 27 [chan receive, 2376 minutes]:
github.com/containerd/containerd/runtime/v1/shim.(*Service).forward(0xc00009a0c0, 0x764e40, 0xc00005cbd0)
	/home/travis/gopath/src/github.com/containerd/containerd/runtime/v1/shim/service.go:575 +0x62
created by github.com/containerd/containerd/runtime/v1/shim.NewService
	/home/travis/gopath/src/github.com/containerd/containerd/runtime/v1/shim/service.go:95 +0x471
goroutine 28 [IO wait, 31633 minutes]:
internal/poll.runtime_pollWait(0x7fc21c317d60, 0x72, 0x0)
	/home/travis/.gimme/versions/go1.11.11.linux.amd64/src/runtime/netpoll.go:173 +0x66
internal/poll.(*pollDesc).wait(0xc0000bc398, 0x72, 0xc000082000, 0x0, 0x0)
	/home/travis/.gimme/versions/go1.11.11.linux.amd64/src/internal/poll/fd_poll_runtime.go:85 +0x9a
internal/poll.(*pollDesc).waitRead(0xc0000bc398, 0xffffffffffffff00, 0x0, 0x0)
	/home/travis/.gimme/versions/go1.11.11.linux.amd64/src/internal/poll/fd_poll_runtime.go:90 +0x3d
internal/poll.(*FD).Accept(0xc0000bc380, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0)
	/home/travis/.gimme/versions/go1.11.11.linux.amd64/src/internal/poll/fd_unix.go:384 +0x1a0
net.(*netFD).accept(0xc0000bc380, 0xc00005f0f0, 0xc00005f0b0, 0xc00006a640)
	/home/travis/.gimme/versions/go1.11.11.linux.amd64/src/net/fd_unix.go:238 +0x42
net.(*UnixListener).accept(0xc00005f2f0, 0xc0000a0e98, 0xc0000a0ea0, 0x18)
	/home/travis/.gimme/versions/go1.11.11.linux.amd64/src/net/unixsock_posix.go:162 +0x32
net.(*UnixListener).Accept(0xc00005f2f0, 0x731a28, 0xc00006a640, 0x7683e0, 0xc000070010)
	/home/travis/.gimme/versions/go1.11.11.linux.amd64/src/net/unixsock.go:257 +0x47
github.com/containerd/containerd/vendor/github.com/containerd/ttrpc.(*Server).Serve(0xc00005f0e0, 0x7683e0, 0xc000070010, 0x767f20, 0xc00005f2f0, 0x0, 0x0)
	/home/travis/gopath/src/github.com/containerd/containerd/vendor/github.com/containerd/ttrpc/server.go:84 +0x10a
main.serve.func1(0x767f20, 0xc00005f2f0, 0xc00005f0e0, 0x7683e0, 0xc000070010)
	/home/travis/gopath/src/github.com/containerd/containerd/cmd/containerd-shim/main_unix.go:207 +0x8b
created by main.serve
	/home/travis/gopath/src/github.com/containerd/containerd/cmd/containerd-shim/main_unix.go:205 +0x1d8
goroutine 30 [select]:
github.com/containerd/containerd/vendor/github.com/containerd/ttrpc.(*serverConn).run(0xc00006a640, 0x7683e0, 0xc000070010)
	/home/travis/gopath/src/github.com/containerd/containerd/vendor/github.com/containerd/ttrpc/server.go:413 +0x3b8
created by github.com/containerd/containerd/vendor/github.com/containerd/ttrpc.(*Server).Serve
	/home/travis/gopath/src/github.com/containerd/containerd/vendor/github.com/containerd/ttrpc/server.go:124 +0x253
=== END goroutine stack dump ===" namespace=k8s.io path="/run/containerd/io.containerd.runtime.v1.linux/k8s.io/dc2ca0615937ecc648dd5a6c64aff5c0993c3b0f31dbccd55fe2849371204bdc" pid=29561

runc  --root /run/containerd/runc/k8s.io/ ps dc2ca0615937ecc648dd5a6c64aff5c0993c3b0f31dbccd55fe2849371204bdc

container "dc2ca0615937ecc648dd5a6c64aff5c0993c3b0f31dbccd55fe2849371204bdc" does not exist

Output of containerd --version:
containerd --version

containerd github.com/containerd/containerd v1.2.7 85f6aa58b8a3170aec9824568f7a31832878b603

runc --version

runc version 1.0.0-rc8
spec: 1.0.1-dev

kubelet --version

Kubernetes v1.10.13

Any other relevant information:
SIGKILL the containerd-shim unblock this situation.
Interesting prometheus metric:
grpc_server_handled_total{grpc_code="Unknown",grpc_method="StopPodSandbox",grpc_service="runtime.v1alpha2.RuntimeService",grpc_type="unary"} 145649

still investigating and @JulienBalestra could you mind to provide more log about the terminating pod and stack of containerd ? It looks like that cri was missing the event to update container status.

We have also been hitting this fairly consistently on a k8s cluster with containerd 1.3.3
In our case, the container that appears to get "leaked" is an init container. I can provide a pod spec as well, if that would be helpful.

looks because due to could not find the state.json. happen in our env as well.

{"level":"error","msg":"remove /run/containerd/runc/k8s.io/dfe22f220bae0fcffbeadb67f6dcaadf128a9984beffe194b39301d0200a1499/runc.pUz7r2: device or resource busy","time":"2020-04-23T15:36:58+08:00"}
{"level":"error","msg":"exec failed: container_linux.go:475: starting container process caused \"process_linux.go:91: executing setns process caused \\\"exit status 21\\\"\"\n","time":"2020-04-23T15:37:08+08:00"}

looks runc failed, but containerd still think it is created success.

My Windows worker nodes are being flooded with these:
E0524 17:24:38.357894    4028 remote_runtime.go:495] ListContainerStats with filter &ContainerStatsFilter{Id:,PodSandboxId:,LabelSelector:map[string]string{},} from runtime service failed: rpc error: code = Unknown desc = hcsshim::OpenComputeSystem f76dd003c4f827c36bb10d24d08e9f14f6e68be728b727126741fd77c6185ac3: A virtual machine or container with the specified identifier does not exist.
E0524 17:24:38.357894    4028 eviction_manager.go:255] eviction manager: failed to get summary stats: failed to list pod stats: failed to list all container stats: rpc error: code = Unknown desc = hcsshim::OpenComputeSystem f76dd003c4f827c36bb10d24d08e9f14f6e68be728b727126741fd77c6185ac3: A virtual machine or container with the specified identifier does not exist.
Any relation?
Thanks.

I seem to have encountered this exact issue on k3s, a lightweight Kubernetes implementation, as well: https://github.com/rancher/k3s/issues/1901
Trying to stop the container manually using crictl gave the same error as the Kubelets (k3s agent):
kathleen [~]$ sudo k3s crictl stop d99085b0dbfde2a40ed79423dd6b8f111bd3f7f8e4e44821790124c4e4e0a95e
FATA[2020-06-13T19:51:30.961591215Z] Stopping the container "d99085b0dbfde2a40ed79423dd6b8f111bd3f7f8e4e44821790124c4e4e0a95e" failed: rpc error: code = Unknown desc = failed to stop container "d99085b0dbfde2a40ed79423dd6b8f111bd3f7f8e4e44821790124c4e4e0a95e": unknown error after kill: runc did not terminate sucessfully: container "d99085b0dbfde2a40ed79423dd6b8f111bd3f7f8e4e44821790124c4e4e0a95e" does not exist
: unknown

However, deletion did work via ctr:
kathleen [~]$ sudo k3s ctr containers ls | grep d99085b0dbfde2a40ed79423dd6b8f111bd3f7f8e4e44821790124c4e4e0a95e
d99085b0dbfde2a40ed79423dd6b8f111bd3f7f8e4e44821790124c4e4e0a95e    quay.io/openebs/provisioner-localpv-arm64:1.9.0                                                         io.containerd.runc.v2
kathleen [~]$ sudo k3s ctr containers rm d99085b0dbfde2a40ed79423dd6b8f111bd3f7f8e4e44821790124c4e4e0a95e
kathleen [~]$ sudo k3s ctr containers ls | grep d99085b0dbfde2a40ed79423dd6b8f111bd3f7f8e4e44821790124c4e4e0a95e
kathleen [~]$

I don't think it was initContainers in my case, just regular containers. I could still retrieve their logs, so they clearly ran at some point.
I had four Pods in the same state, all on the same node. For two of them, the ctr containers rm worked; the other two I have not touched yet, as it is not bothering for me that they are stuck in Terminating. If you need any state or debugging information on the two Pods that are stuck in Terminating, let me know.

It seems like https://github.com/containerd/containerd/pull/4214 has fixed the issue. @sgielen @JulienBalestra could you please try the latest version? Thanks

It seems like #4214 has fixed the issue. @sgielen @JulienBalestra could you please try the latest version? Thanks

This would be in containerd 1.4.0+, then, right? k3s is still using 1.3.3-k3s2, so I don't know how to try the latest version. But, I also don't know how to reproduce this issue, just know that it occurred for me. I can only report back if it happens again...

I'm closing this since it's fixed for a while now


W-11261736 - removed SendMessageBatch Note after fix

Writer's Quality Checklist
Before merging your PR, did you:

[x] Run spell checker
[x] Run link checker to check for broken xrefs
[x] Check for orphan files
[x] Perform a local build and do a final visual check of your content, including checking for:

Broken images
Dead links
Correct rendering of partials if they are used in your content
Formatting issues, such as:

Misnumbered ordered lists (steps) or incorrectly nested unordered lists
Messed up tables
Proper indentation
Correct header levels

[ ] Receive final review and signoff from:

Technical SME
Product Manager
Editor or peer reviewer
Reporter, if this content is in response to a reported issue (internal or external feedback)

[ ] If applicable, verify that the software actually got released

The fix still has to be released, see this PR


runtime.txt

-----> Python app detected
-----> Using Python version specified in runtime.txt
!     Requested runtime (python-3.8.2) is not available for this stack (heroku-20).
!     Aborting.       Push rejected, failed to compile Python app.
!     Push failed
changing the python runtime to 3.9 or newer seems to fix this issue

Yes, changing it to higher version like you said should have fixed it.


tokenizer from SB paper (58 tokens instead of 51 for complete coverage)

[ ] fix link to be URL

@mravanelli , do you know how to change the link from our results drive to something SB can download (for the new tokenizer)? It's https://drive.google.com/u/0/uc?id=1muXFLLqHrKWWXAjF_R0WuukZro9KWgt3&export=download


Use hardlink on *nix

Bundling phase is painfully slow on vim.
This patch attempts to use hard link on *nix system instead of copying.

I have confirmed your problem with the trivial benchmark.
NvimLink
real    0m0.035s
user    0m0.013s
sys     0m0.023s

NvimSymLink
real    0m0.091s
user    0m0.011s
sys     0m0.080s

Copy
real    0m6.877s
user    0m4.684s
sys     0m2.193s

SystemCopy
real    0m5.293s
user    0m3.162s
sys     0m2.549s

SystemLink
real    0m2.880s
user    0m2.243s
sys     0m0.993s

SystemSymlink
real    0m3.154s
user    0m2.334s
sys     0m1.183s

Thank you for the suggestion. Cheers!


Update --team parsing preference

Closes #9
Parse input -> env -> org flag (input -> env)

Codecov Report

Merging #10 into master will not change coverage.
The diff coverage is 100%.

@@          Coverage Diff          @@
##           master    #10   +/-   ##
=====================================
  Coverage     100%   100%
=====================================
  Files           5      5
  Lines          72     73    +1
  Branches       28     28
=====================================
+ Hits           72     73    +1

Impacted Files
Coverage Δ

src/flags/team.js
100% <100%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8701c24...6817108. Read the comment docs.


[copycpp] Update to 0.1.1

Fixes #35453, update copypp to 0.1.1.
No feature needs to be tested, the usage test passed on x64-windows (header files found):
copypp provides CMake targets:

    find_package(copypp CONFIG REQUIRED)
    target_link_libraries(main PRIVATE icurve::copypp)

[x] Changes comply with the maintainer guide
[x] SHA512s are updated for each updated download
[ ] The "supports" clause reflects platforms that may be fixed by this new version
[ ] Any fixed CI baseline entries are removed from that file.
[ ] Any patches that are no longer applied are deleted from the port's directory.
[x] The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
[x] Only one version is added to each modified port's versions file.

It is copypp, not copycpp.
Duplicates #35454.

Thanks for the update! Closed as an exact duplicate.


Automatically update configuration after specific characteristics change

While I was working on the issue https://github.com/NRCHKB/node-red-contrib-homekit-bridged/issues/12 I noticed that the clients don't get informed about changes of some core characteristics (e.g. Name, Firmware Revision, Model, ...). To inform the clients about those kind of changes the configuration version (TXT Record key "c#") needs to be increased to tell the clients that the configuration has changed.
To automatically update the configuration after specific characteristics changed I defined a new property for characteristics. Every time a characteristic gets changed which has this property set to true the configuration will automatically be updated. This property defaults to false and can be overwritten in the characteristic definition.

@KhaosT please look at this PR.

Based on HomeKit Accessory Protocol Specification, those information are not suppose to change during the lifetime of the accessory. Since homed does the special parsing for the accessory info service, I'm not sure we want to support this use case since there were assumptions made to make this work (homed will rediscover accessory after configuration number changes). Is there a particular reason that those information can't be populated when you add the accessory?

One case I'm aware of is https://github.com/naofireblade/homebridge-weather-plus (a Homebridge plugin) dynamically changes the Name characteristic of some Accessories. It will create "Occupancy Sensor" Accessories to reflect when a condition exceeds some threshold (e.g., Wind Speed) and set the sensor as "Home". The Occupancy Sensor Value reflects whether or not the threshold has been exceeded, but the Name Characteristic is changed dynamically to reflect the current value (e.g., the current wind speed).
The Apple Home app will occasionally re-read the characteristics (I'm not quite sure under what conditions. New session, maybe?) and the Name will reflect the change at that time, but there's currently no way for an Accessory to 'push' a Name change other than incrementing the configuration count.

@KhaosT I missed that part of the specification were this was mentioned but you are right. It states that the values of Manufacturer, Model, Name and Serial Number should persist throughout the lifetime of an accessory. This has probably some compliance reasons and not so much technical reasons. Then it is probably better not to implement this change even though that it seams to be working just fine.
To really follow the specifications it should probably not be allowed to change those specific characteristics at all after the accessory was published the first time since it isn't really reliable. Instead this should lead to an error or a warning message. This means that a new accessory must be created every time someone wants to change those fields.
This limitation should be documented somewhere in the Wiki section.

@joconor Are you sure the plugin modifies the Name characteristic of the Accessory Information service? Or does it modify the Name characteristic of the individual services (Occupancy sensor etc). These are two fundamentally different things. The second one does perfectly work as far as I know(?)


chore(rest): updated dependencies

Signed-off-by: janrtvld<EMAIL_ADDRESS>

Codecov Report

Merging #75 (b636b47) into main (412b28e) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #75   +/-   ##
=======================================
  Coverage   85.74%   85.74%
=======================================
  Files          27       27
  Lines         463      463
  Branches       78       78
=======================================
  Hits          397      397
  Misses         66       66

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 412b28e...b636b47. Read the comment docs.


Not an Issue, more a feature request

Hi,
I finally managed to get the 123smartbms installed and also bought the adapter. However, documentation how to connect the adapter via USB is very sparse (still no clue, how to connect the two cables to the out-board).
I wanted to just read the data from the smartbms to my Linux ELK stack. However, this project here pushed my private data directly to some third party@dunnowhere. So I have started to modify the code. Would would you be interested to publish a version that writes the BMS data to a local ELK stack (for privacy reasons) ?

Hi,
I did not see your comment earlier, sorry for that.
You can create a branch and publish it with your own version if you want.
Installation instructions of the USB cable is on the website (also nice-to-know for other users).


No module named 'llama_inference_offload'

PLEASE HELP I GOT THIS ERROR :
Starting the web UI...
Warning: --cai-chat is deprecated. Use --chat instead.
===================================BUG REPORT===================================
Welcome to bitsandbytes. For bug reports, please submit your error trace to: https://github.com/TimDettmers/bitsandbytes/issues
CUDA SETUP: Loading binary E:\vicuna-chatgpt4\oobabooga-windows\installer_files\env\lib\site-packages\bitsandbytes\libbitsandbytes_cpu.dll...
E:\vicuna-chatgpt4\oobabooga-windows\installer_files\env\lib\site-packages\bitsandbytes\cextension.py:31: UserWarning: The installed version of bitsandbytes was compiled without GPU support. 8-bit optimizers and GPU quantization are unavailable.
warn("The installed version of bitsandbytes was compiled without GPU support. "
Loading anon8231489123_vicuna-13b-GPTQ-4bit-128g...
Traceback (most recent call last):
File "E:\vicuna-chatgpt4\oobabooga-windows\text-generation-webui\server.py", line 302, in
shared.model, shared.tokenizer = load_model(shared.model_name)
File "E:\vicuna-chatgpt4\oobabooga-windows\text-generation-webui\modules\models.py", line 100, in load_model
from modules.GPTQ_loader import load_quantized
File "E:\vicuna-chatgpt4\oobabooga-windows\text-generation-webui\modules\GPTQ_loader.py", line 14, in
import llama_inference_offload
ModuleNotFoundError: No module named 'llama_inference_offload'
Press any key to continue . . .

I've got the same problem.
In case that would help the diagnostic : I've got a Win10 Pc with an AMD Ryzen proc and an AMD Radeon GPU too... so I've not chosen the "NVIDIA" option at the beginning of the installation.

This is not a bitsandbytes issue. Please see #298 and #293.


Update compute.md

Add 'Amazon' and 'AWS' to service names.
Remove 'Logic Apps' from AWS Lambda functionality overlapping, since Azure Logic Apps is similar to AWS Step Functions (https://aws.amazon.com/step-functions/getting-started/) instead of AWS Lambda.

@BrianQu : Thanks for your contribution! The author(s) have been notified to review your proposed change.

Microsoft authors of articles need to make updates through the private repository so the updates can be staged and validated by the current validation rules. After you review staging and fix all validation issues, you can add the sign-off comment to let the PR reviewers know the updates are ready to be merged.It's easy to access the private repo version of your articles in GitHub. Just add -pr to the URL, as follows:
Public repo URL: https://github.com/MicrosoftDocs/azure-docs
Private repo URL: https://github.com/MicrosoftDocs/azure-docs-pr
We have closed this pull request. Please resubmit the updates through the private repo. For more information, [see the contributor guide].(https://docs.microsoft.com/en-us/contribute/)

#Sign-Off

@EdPrice-MSFT: I'm sorry - only the author of this article, @BrianQu, can sign off on your changes. But we do have an exception process - if you are on the Microsoft content or product team for this product area, you can ask the PR review team to review and merge it by sending mail to the techdocprs alias.

#Sign-Off

@EdPrice-MSFT: I'm sorry - only the author of this article, @BrianQu, can sign off on your changes. But we do have an exception process - if you are on the Microsoft content or product team for this product area, you can ask the PR review team to review and merge it by sending mail to the techdocprs alias.

Hi @EdPrice-MSFT - The article author was updated 8/9 to a different value. Which would you like to use to resolve the merge conflict?

Thanks.

Hi @EdPrice-MSFT - The article author was updated 8/9 to a different value. Which would you like to use to resolve the merge conflict?

Thanks.

We'll resolve in favor of the most recent update.

@ktoliver : Thanks for your contribution! The author(s) have been notified to review your proposed change.


outlining doesn't work for non-standard file extension

VSCode Version: 1.6.1
OS Version: Win10

Steps to Reproduce:

have a files (c++ syntax but non-standard extension, c++ scripting for specific system)
user settings contains (probably incorrect??)

"files.associations" : {  "*.aaa" : "cpp"  }
outlining (Ctrl+Shift+O) doesn't work ("no symbols.." message),
in case of I rename the file with usual extension: .cpp, all works okay then

This issue was moved to Microsoft/vscode-cpptools#291


Feature/37485: Created EchoEventHub Context, Provider & Hook

Prerequisites
Please make sure you can check the following boxes:

[x] Pull request title = BugFix or Feature #UserStoryNumber: One sentence explaining to the user what's new/fixed.
[x] My code follows the code style of this project
[x] All new and existing tests passed
[x] Fix any eslint/prettier warnings/errors: npm run lint
[x] Remove unnecessary console.log (use logInfo logWarn if it's needed)
[x] Are variable and function names properly describing what it does?

Type(s) of Changes
Contribution Type
What types of changes does your code introduce? Put an x in all the boxes that apply:

[ ] Bug fix (non-breaking change which fixes an issue, please reference the issue id)
[x] New feature (non-breaking change which adds functionality, make sure to open an associated issue first)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[x] I have updated the documentation accordingly
[x] I have added tests to cover my changes

Description
Created EchoEventHub Provider wsing React context API, and added Hook to make it easier to use within code.
Extended EchoEventHub with "subscribeMany" which allows to subscribe one handler to multiple types of events.
Remarks
[Optionally place any follow-up comments, remarks, observations, or notes here for future reference]

the rest looks fine by me ;) god job 👍


can you update the npm package?

Hi,
Can you update the npm version so that it will pick up the global leak fixes from December?
Thanks!

My mistake, I didn't realise I had other unreleased fixes, I will release 1.1.5 this evening.

cool, thanks... also I noticed there was still one line with a global variable that should be fixed, startSocket()
line 63...

You're right, that's a regression I did fix it, must have reverted but accident when I merged the new code from keithnlarsen in.


Update README.md

@silasdavis why on earth is DCO failing?

Missing signoff because via gui.... added

github actions extremely flaky on this, merging anyway


chore(main): release 0.4.5

:robot: I have created a release beep boop
0.4.5 (2024-08-20)
Bug Fixes

deploying MkDocs action fail fix (35e5a7b)

This PR was generated with Release Please. See documentation.

:robot: Created releases:

v0.4.5
:sunflower:


MSID: 89908 Version: 2 DOI: 10.1101/2<IP_ADDRESS>0422

MSID: 89908
Version: 2
Preprint DOI: https://doi.org/10.1101/2<IP_ADDRESS>0422
Step 1. Awaiting reviews
Editorial to post reviews via hypothesis
Useful links:

DocMap: https://data-hub-api.elifesciences.org/enhanced-preprints/docmaps/v2/by-publisher/elife/get-by-manuscript-id?manuscript_id=89908
New model tracking: https://docs.google.com/spreadsheets/d/1_fHaoOy7hjyocptKtVJRijeNpUY4hBS7Ck_aVmx6ZJk/
Reviews on sciety: https://sciety.org/articles/activity/10.1101/2<IP_ADDRESS>0422

For trouble shooting (e.g. no Docmaps available):

DocMap issue addressing: https://miro.com/app/board/uXjVNCwK6EI=/
Explore DataHub DocMaps API: https://lookerstudio.google.com/reporting/4c2f0368-babb-4beb-b5b3-497e7e7b0f08/page/ejphD
Unmatched submissions and preprints: https://lookerstudio.google.com/u/0/reporting/9f86204f-3bf7-477c-9b18-5c5ef141bf69/page/p_gxi57ha93c
Unmatched manuscripts spreadsheet: https://docs.google.com/spreadsheets/d/15QcK8w-ssB7109RQEDtFpJPZ0J5HTGxoHa_2TtpMBbg/edit#gid=1336081641

Step 2. Preview reviewed preprint
Production QC content ahead of publication
Instructions:

QC preview: https://prod--epp.elifesciences.org/previews/89908v2
Update ticket with any problems (add blocked label)
When QC OK, add QC OK label to ticket and add publication date and time to https://docs.google.com/spreadsheets/d/1amAlKvdLcaDp5W8Z8g77NmkwbMF5n_u89ArSqPMO8jg
Move card to next column
(At end of the day post link in #enhanced-preprint and ask for PDF to be generated)

Useful links:

Preprint DOI :  https://doi.org/10.1101/2<IP_ADDRESS>0422
Confirm reviews returned by EPP: https://prod--epp.elifesciences.org/api/reviewed-preprints/89908/v2/reviews
To update the MECA path in the docmap: https://docs.google.com/spreadsheets/d/1mctCQuNFBjSn97Lihy7_vBO6z7-N-oqyLv4clyi6zHg

Step 3: Awaiting search reindex
This step adds the reviewed preprint to the homepage: https://elifesciences.org
The search reindex is triggered once an hour. We need the reviewed preprint to be indexed as the search application serves the journal homepage.
Useful links:

Jenkins pipeline to reindex search can be triggered sooner or monitored here: https://alfred.elifesciences.org/job/process/job/process-reindex-reviewed-preprints/

Step 4: Published! PDF requested
Waiting for PDF to be generated
Useful links:

PDF tracking: https://docs.google.com/spreadsheets/d/106_XeDjmuBae7gexOTNzg60lapeqjl2aRn9DzupGyS8/

Step 5: Introduce PDF to data folder and git repo
Upload PDF to relevent folder in git repo https://github.com/elifesciences/enhanced-preprints-data/
Step 6: Done!

[ ] Kettle is on!

v2 is missing from the DocMap entirely. Adding details to the unmatched spreadsheet in order to surface the details (hopefully).

error: [journal-ref-article-title] This journal reference (id c8) has no article-title element.
error: [journal-ref-article-title] This journal reference (id c61) has no article-title element.
error: [journal-ref-article-title] This journal reference (id c89) has no article-title element.
error: [journal-ref-article-title] This journal reference (id c110) has no article-title element.
error: [journal-ref-article-title] This journal reference (id c149) has no article-title element.
warn: [mixed-citation-other-publication-flag] mixed-citation in reference (id=c27) has a publication-type='other'. Is that correct?
warn: [title-upper-case] Content of  element is entirely in upper case: Is that correct? 'RESEARCH HIGHLIGHTS'
warn: [title-upper-case] Content of  element is entirely in upper case: Is that correct? 'LIMITATIONS'
error: [body-footnote] This preprint has footnotes appended to the content. EPP cannot render these, so they need adding to the text.


chore: Remove Local Path Gem Dependencies

This is the first of many steps to decouple the contrib packages from the main repo.
See https://github.com/open-telemetry/opentelemetry-ruby-contrib/issues/1

@chrisholmes If you have some time I could use your help looking into the rspec auto-instrumentation. It seems that in CI mode it runs without colors but always colorizes output when run locally. I could not figure out the incantation to disable coloring and was hoping you had some insight into why this is failing all of the sudden.
https://github.com/open-telemetry/opentelemetry-ruby/actions/runs/2266028975


Db Transactions

First - Thank you for providing such an excellent reference!
Q: How would you make use of database transactions in a mediator handler?

I considered two options for DB transactions, either implement a filter in the Asp.Net pipeline so everything within a request is in the same transaction, or implement the MediatR IPipelineBehavior and handle the transaction there.
Which is best for you depends on your solution requirements.

Thank you for your interest in this project. This repository has been archived and is no longer actively maintained or supported. We appreciate your understanding. Feel free to explore the codebase and adapt it to your own needs if it serves as a useful reference. If you have any further questions or concerns, please refer to the README for more information.


Cannot reconnect to Websocket

Hi there,
here I have something really strange for you.
We are using you library to establish a connection between an Android Wear Device (V 1.5) and a WebSocket. The device is paired with a Samsung Galaxy S5 (latest Android). When our app first starts (Watch is connected via bluetooth to Mobile), everything works fine and as expected. If then the Bluetooth connection is cut (for whatever reason), the Watch switches to WIFI and also connects as intended. When you now reconnect the Watch to the Mobile via Bluetooth, the WebSocket connection does not get established.  Only solution is, to reboot the Watch (which actually is no solution :) )
One "funny" thing to mention: When you get the Network-Type on the Watch while connected via Bluetooth, it returns the type "PROXY" (constant value is 16) which actually is NOWHERE documented. And when you try to get the DefaultProxy-Information vom the ConnectivityManager, it returns a null

And here is the message thrown, when trying to connect
com.neovisionaries.ws.client.WebSocketException: Failed to connect to 'XXXX:3000': Host is unresolved: XXXX at com.neovisionaries.ws.client.SocketConnector.doConnect(SocketConnector.java:119) at com.neovisionaries.ws.client.SocketConnector.connect(SocketConnector.java:81) at com.neovisionaries.ws.client.WebSocket.connect(WebSocket.java:2022) at com.neovisionaries.ws.client.ConnectThread.run(ConnectThread.java:37) Caused by: java.net.UnknownHostException: Host is unresolved: XXXX at java.net.Socket.connect(Socket.java:867) at com.neovisionaries.ws.client.SocketConnector.doConnect(SocketConnector.java:110)

I would be really thankful for any help

After purchasing an Acer and a LG Phone, I can confirm that this is not related to the known "Samsung cannot resolve URI"-Problems

I'm sorry I don't understand your issue well enough, but it seems that the error message says XXXX is an invalid host name. Is it an actual error message, or did you replace an actual host name with XXXX before pasting the error message here?
If "Host is unresolved" is the root cause, it's not a WebSocket issue but a DNS issue.

Maybe the problem gets clearer when I explain the steps to reproduce:

Wear-Device connected to Internet via Bluetooth over Smartphone -> Host can be resolved and WebSocket connects
Turn off Bluetooth on Wear-Device
Wear-Device connected via WiFi directly -> Host can be resolved and WebSockets connects
Turn on Bluetooth on Wear-Device
Wear-Device connected to Internet via Bluetooth over Smartphone (again) -> Host cannot be resolved and WebSocket cant connect. Never again. Until you manually reboot the Wear-Device. Then it all start´s at 1.

Well, then, it sounds that the root cause exists in the network layer in Wear-Device. A WebSocket library cannot do anything for the problem...


About The Dataset

Thanks for your work. For the preparation of the dataset, can you give the relevant links and provide more detailed instructions?

You can first refer to the Monodepth GitHub repo for the preparation of KITTI dataset. For the Scene Flow datasets, you can first download all the tars (Finalpass and disparities of monkaa, flyingthings, driving) and then extract and place the folders according to the sceneflow_folder_structure.txt. For automatical script, I may update next week.

README has been updated.


adding privileged flag to docker containers

This is not complete - the kubernetes container manager does not actually do anything with the privileged flag. However, I am fine with leaving this incomplete for another day.

executor can now set the privileged flag for kubernetes pods

Deal with the failing lint passes and I'll hit merge

Codecov Report
Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (eb4159a) 57.79% compared to head (decddf6) 57.76%.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@                 Coverage Diff                  @@
##           feat/declarative      #10      +/-   ##
====================================================
- Coverage             57.79%   57.76%   -0.04%
====================================================
  Files                    23       23
  Lines                  3618     3620       +2
====================================================
  Hits                   2091     2091
- Misses                 1527     1529       +2

Flag
Coverage Δ

unittests
57.76% <0.00%> (-0.04%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Files
Coverage Δ

pydatatask/declarative.py
0.00% <ø> (ø)

pydatatask/executor/container_manager.py
45.97% <ø> (ø)

pydatatask/task.py
72.06% <0.00%> (-0.19%)
:arrow_down:

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report?


Detect multiple monitors using Xinerama extension for fullscreen

This change includes the Xinerama extension and queries it when going
fullscreen. Xinerama has information about the actual monitors
connected in a multi-monitor configuration. X normally treats both
monitors as a single large screen. Xinerama allows us to get the
actual dimensions of attached screens. Nvidia TwinView and other
drivers use the Xinerama protocol so this should be compatible with
most multi-screen setups.
This forces fullscreen to always go to screen 0. This fixes #1408.
This also fixes the issue in some window managers (e.g. LXDE and
OpenBox) where Godot would stretch across both monitors.

this is great! will wait a bit to merge it until the patches that add the
new screen resizing APIs can be merged
On Wed, Mar 11, 2015 at 7:00 PM, John Watson<EMAIL_ADDRESS>wrote:

This change includes the Xinerama extension and queries it when going
fullscreen. Xinerama has information about the actual monitors
connected in a multi-monitor configuration. X normally treats both
monitors as a single large screen. Xinerama allows us to get the
actual dimensions of attached screens. Nvidia TwinView and other
drivers use the Xinerama protocol so this should be compatible with
most multi-screen setups.
This forces fullscreen to always go to screen 0. This fixes #1408
https://github.com/okamstudio/godot/issues/1408.
This also fixes the issue in some window managers (e.g. LXDE and
OpenBox) where Godot would stretch across both monitors.
You can view, comment on, or merge this pull request online at:
https://github.com/okamstudio/godot/pull/1502
Commit Summary

Detect multiple monitors using Xinerama extension for fullscreen

File Changes

M platform/x11/detect.py
https://github.com/okamstudio/godot/pull/1502/files#diff-0 (5)
M platform/x11/os_x11.cpp
https://github.com/okamstudio/godot/pull/1502/files#diff-1 (21)

Patch Links:

https://github.com/okamstudio/godot/pull/1502.patch
https://github.com/okamstudio/godot/pull/1502.diff

—
Reply to this email directly or view it on GitHub
https://github.com/okamstudio/godot/pull/1502.

--
OkamStudio

Closing because PR #1487 appears to moot the issue.


[Feature] Add Metal support for FFT

Add support for Metal backend with FFT primitive as mentioned here https://github.com/ml-explore/mlx-examples/issues/249

I would like to take up this issue @awni. Please let me know if I can take this implementation up.

Do you have experience with GPU programming? This is not a trivial one so I would recommend starting with something simpler if not.

I have some experience from my intern at Amazon HPC and a GPU programming course. I am not completely familiar with Metal, but I am looking at its documentation. I'm familiar with the basics of FFT. Would that be enough to start on this?

It's hard for me to answer. I would recommend you take a look at parallel implementations of FFT. There is also this code which does FFT or Metal. Maybe a good place to start is to benchmark that code against a CPU implementation and just see how usable it might be?
We can use this thread to discuss your findings.

What's the status on this? It's blocking some audio processing stuff I'm trying to do. It looks like there's MPS implementation - any interests in adding this?
A tangential question to this, why doesn't the codebase leverage MPS more? IIUC it handles broadcasting between matrices correctly and has optimized ops for lower dimensions.

Just to chime in, if this operator is implemented (when I eventually implement conv3d) I can accelerate the operation for larger input tensor shapes. FFT conv tends to outperform winowgrad conv for larger. Would be great to have as a feature to dispatch the appropriate conv kernel depending on shape.

@AndreSlavescu See also: https://github.com/ml-explore/mlx/issues/811#issuecomment-1988934827

Could you reuse the code written for PyTorch? They added MPS support for FFT. https://github.com/pytorch/pytorch/pull/119670

It's not a great fit for us as we don't wrap MPSGraph and likely wouldn't make an exception for FFTs.


Cargo will always invoke the 'true' rustc on Windows, rather than a rustc shim

(by a 'rustc shim' I'm referring to things like rustup - it puts a shim rustc on the path which invokes the true rustc)
As part of invoking rustc for compilations, cargo will put a number of paths in the 'library environment', performed here (called from Compilation::rustc_process, which is called from prepare_rustc): https://github.com/rust-lang/cargo/blob/d4ee795/src/cargo/core/compiler/compilation.rs#L188-L204
However, a few things conspire against us:

the paths are added to the beginning of the variable, i.e. with the highest priority
on Windows the environment variable these new paths get added to (util::dylib_path_envvar()) is the same as the binary search path (i.e. PATH)
on Windows, the sysroot dylibs for the compiler are in the same directory as the actual binaries (i.e. rustc.exe lives alongside dylibs like rustc_typeck-4d5d5a72bda8f430.dll)

This means that when actually performing the compilation, an attempted invocation of rustc will jump straight to the sysroot binaries rather than using the shim - anything that the shim does (like telemetry, in the case of the rustup) gets completely skipped for any compilations. You can observe this with a build plan on Windows:
{
    "invocations": [
        {
            "package_name": "cde",
            "package_version": "0.1.0",
            "target_kind": [
                "bin"
            ],
            "kind": "Host",
            "deps": [],
            "outputs": [
                "C:\\X\\cde\\target\\release\\deps\\cde-63a3117d8b95571a.exe",
                "C:\\X\\cde\\target\\release\\deps\\cde-63a3117d8b95571a.pdb"
            ],
            "links": {
                "C:\\X\\cde\\target\\release\\cde.exe": "C:\\X\\cde\\target\\release\\deps\\cde-63a3117d8b95571a.exe",
                "C:\\X\\cde\\target\\release\\cde.pdb": "C:\\X\\cde\\target\\release\\deps\\cde-63a3117d8b95571a.pdb"
            },
            "program": "rustc",
            "args": [
                "--crate-name",
                "cde",
                "src\\main.rs",
                "--crate-type",
                "bin",
                "--emit=dep-info,link",
                "-C",
                "opt-level=3",
                "-C",
                "metadata=63a3117d8b95571a",
                "-C",
                "extra-filename=-63a3117d8b95571a",
                "--out-dir",
                "C:\\X\\cde\\target\\release\\deps",
                "-L",
                "dependency=C:\\X\\cde\\target\\release\\deps"
            ],
            "env": {
                "CARGO": "\\\\?\\C:\\Users\\aidanhs\\.rustup\\toolchains\\nightly-2018-08-19-x86_64-pc-windows-msvc\\bin\\cargo.exe",
                "CARGO_MANIFEST_DIR": "C:\\X\\cde",
                [...]
                "CARGO_PRIMARY_PACKAGE": "1",
                "PATH": "C:\\X\\cde\\target\\release\\deps;C:\\Users\\aidanhs\\.rustup\\toolchains\\nightly-2018-08-19-x86_64-pc-windows-msvc\\bin;C:\\Users\\aidanhs\\.cargo\\bin;C:\\Users\\aidanhs\\.rustup\\toolchains\\nightly-2018-08-19-x86_64-pc-windows-msvc\\bin;[...]"
            },
            "cwd": "C:\\X\\cde"
        }
    ],
    "inputs": [
        "C:\\X\\cde\\Cargo.toml"
    ]
}

Note the C:\\Users\\aidanhs\\.rustup\\toolchains\\nightly-2018-08-19-x86_64-pc-windows-msvc\\bin with a higher priority than C:\\Users\\aidanhs\\.cargo\\bin in the PATH.
There is an additional oddity though - when performing configuration tests at cargo startup (https://github.com/rust-lang/cargo/blob/d4ee795357589b9b1cfb7ed2ede9a4d43d7ac4a3/src/cargo/core/compiler/build_context/target_info.rs#L68-L75), cargo will use the correct binary, i.e. the shim. This makes sense (this is the way it actually discovers the sysroot to add to the environment), but is a bit odd (since you then get two entries in rustup telemetry).
Quick thoughts:

I'm not clear why we need to add the sysroot dylib path to the environment - on Linux the rustc binary has an rpath, and Windows will apparently attempt to use the directory of the executable first (https://msdn.microsoft.com/en-us/library/7d83bc18.aspx)
Adding paths at the end of the variable could cause oddities with unusual setups, but I would imagine the risks are fairly low given the hashes added to the end of rustc-generated dylibs.
Move dylibs into a different directory in the rust distribution - likely to make standalone rustc calls fail.

I'm going to close, since as of #11917 we are intentionally circumventing the rustup proxies. Also, since this was filed, things like telemetry have been removed from rustup. There's also been some changes to the priority of how things are added to PATH. There's still some work left to do (like https://github.com/rust-lang/rustup/issues/3036), but those are tracked elsewhere.


refactor(website): migrate to vite

Hi, the following code works fine:
import type { Plugin } from "vite";
import markdown from "../utils/markdown";
import { getMarkdownSection } from "../config/plugins/pre-markdown-loader";

const fileRegex = /\.md$/;

const pkg = "core";

export default async function pluginMD(): Promise<Plugin> {
  return {
    name: "plugin-markdown",
    enforce: "pre",
    async transform(src: string, id: string) {
      if (fileRegex.test(id)) {
        const index = id.lastIndexOf("/");
        const prePath = id.slice(0, index);
        const name = prePath.slice(prePath.lastIndexOf("/") + 1);

        const { typeDeclarations } = await getMarkdownSection(pkg, name);

        const demoPath = id.replace("README.md", "demo.tsx");
        const originHtml = markdown.render(src);
        const typeDeclarationsHtml = markdown.render(typeDeclarations);

        const code = `
        import { jsx as _jsx } from "react/jsx-runtime";
        import { jsxs as _jsxs } from "react/jsx-runtime";
        import Demo from '${demoPath}';
        function Layout() {
          return _jsxs("div", {
            className: "prose",
            children: [_jsx("div", {
              dangerouslySetInnerHTML: {
                __html: ${JSON.stringify(originHtml)}
              }
            }), _jsxs("div", {
              children: [_jsx("h2", {
                children: "Example"
              }), _jsx("div", {
                className: "demo-container",
                children: _jsx(Demo, {})
              })]
            }), _jsx("div", {
              dangerouslySetInnerHTML: {
                __html: ${JSON.stringify(typeDeclarationsHtml)}
              }
            })]
          });
        }
        export default Layout;
        `;
        return {
          code,
        };
      }
    },
  };
}

Oh, Thanks🥰.  I remember that there is a normalizePath function in Vite to convert paths to /, but I forgot.

@Daydreamer-riri Thanks! changed it.

There's nothing else.

  Sorry I didn't describe it clearly enough😂

@Daydreamer-riri  haha🤪. The overall process is fine, except for a few minor issues. When the Vite plugin is modified, restarting the server directly causes a 504 error on the development server, which is quite strange. I have to manually restart the server.

I also encountered the same problem. Not a big deal though

Sure. If I have time later, I will create a minimal demo and submit an issue on Vite.


"Remove" button has no effect

Describe the bug
"Remove" button has no effect.
To Reproduce
Steps to reproduce the behavior:

Go to 'Files'
Select a file
Click 'Remove'
Nothing happens.

Expected behavior
Show modal to confirm file deletion.
Screenshots

Desktop (please complete the following information):

OS: macOS 11
Browser Electron/Latest IPFS Desktop

Additional context
The error:
5.b38d6622.chunk.js:2 Uncaught TypeError: Cannot read property 'showModal' of undefined
    at onRemove (9.b477e6c8.chunk.js:1)
    at remove (9.b477e6c8.chunk.js:1)
    at Object.s (5.b38d6622.chunk.js:2)
    at d (5.b38d6622.chunk.js:2)
    at 5.b38d6622.chunk.js:2
    at g (5.b38d6622.chunk.js:2)
    at st (5.b38d6622.chunk.js:2)
    at ot (5.b38d6622.chunk.js:2)
    at ut (5.b38d6622.chunk.js:2)
    at ht (5.b38d6622.chunk.js:2)

I believe this was fixed in https://github.com/ipfs/ipfs-webui/pull/1790 will get bubbled up to desktop with the next release


Pylance 2022.3.4 shows errors with python-box Box class that is not thrown on 2022.3.3 or other IDEs/tools (like running mypy directly)

 Environment data

Language Server version: 2022.3.4
OS and version: darwin arm64
Python version (and distribution if applicable, e.g. Anaconda): 3.10.2
python.analysis.indexing: null
python.analysis.typeCheckingMode: basic

 Expected behaviour
I have a project I'm working on where we use the python-box dependency on 5.4.1. We have code that looks similar to the following:
from box import Box

some_box: Box = Box(({"hi": {"lol": "foo"}}))
some_other_box: Box = some_box.hi

In 2022.3.3 and other IDEs/editors/tools (like Pycharm/Neovim/mypy), there are no type issues thrown for the above code. I expect the same in Pylance 2022.3.4.
 Actual behaviour
In 2022.3.4, the following error is shown:

I'm not sure why Pylance thinks it's a BoxList in this context, but it's clearly not/shouldn't be interpreted as one. Even when I check the type in an interpreter, it reports it as a type box.box.Box (no BoxList to be found):
>>> from box import Box
>>> some_box: Box = Box({"hi": {"lol": "foo"}})
>>> some_other_box: Box = some_box.hi
>>> print(type(some_other_box))
<class 'box.box.Box'>

Any help in figuring out what's wrong here? Thanks!

This appears to be an untyped library — no annotations and no stub files. When "python.analysis.useLibraryCodeForTypes" is set to true (as it is by default), Pylance attempts to infer the types based on source. Mypy doesn't do this; it treats all symbols imported from an untyped library as Any.
For some complex functions — especially those that are polymorphic (where the return type depends on the input types), type inference can result in incomplete or incorrect return types. Inferred types are sufficient for completion suggestions, but they are often not good enough for static type checking.
In this particular case, the Box class defines a __getattr__ method that is unannotated. Pylance uses a variety of techniques to infer the return type. Once of the more advanced techniques is called call-site return type inference where it uses the input argument types to infer the return type of a polymorphic unannotated method. This technique is powerful, but it's also extremely costly. There are heuristics in place that determine when it should be used and when it shouldn't. I adjusted one of those heuristics recently to improve performance. This change means that call-site return type inference is no longer used for the Box.__getattr__ method, and the inferred return type is now Unknown | Any | BoxList rather than Unknown, as it was previously.
So this is an unexpected side effect of a small tweak to one of Pylance's internal heuristics.
If you enable static analysis diagnostics (as you have apparently done), we recommend that you set "python.analysis.useLibraryCodeForTypes" to false. This will tell Pylance to no longer attempt to infer return types from untyped libraries, matching mypy's behavior in this respect. Unfortunately, that means you will forego all completion suggestions for symbols that come from any untyped libraries.
The real long-term solution here is for all libraries to include static type annotations. Many library maintainers have already made this investment, but it appears that the maintainers of python-box have not. If this library is important to you, you may want to encourage them to do — or even better, contribute PRs to add type information to the library. We've prepared this guidance to help library authors add type information.

@erictraut thank you for the insight! I reached out to the maintainers of that project.


"Cotmeana" is listed in the drop-down menu

Description:
"Cotmeana" is listed in the drop-down menu alongside its corresponding county and commune, according to the law
Precondition:
The website is up an running.

Step 1
Type "Cotmeana" in the search bar.

Expected results
The location is listed in the drop-down menu as "Cotmeana, Argeș".


Warehouse helm subscription is not working

Description
In the document, it is specified that kargo supports helm subscription for the warehouse. But when i tried this use case, freight box is detected when a new chart version comes up. But no version information is displayed. Also when promoted, stages shows promoted but no commits there in the git branch. Here is the warehouse.yaml
apiVersion: kargo.akuity.io/v1alpha1
kind: Warehouse
metadata:
  name: kargo-demo
  namespace: kargo-demo
spec:
  subscriptions:
  - chart:
      registryURL: oci://docker.io
      name: xyz/kargo-demo-app-charts
      semverConstraint: ^0.1.0

Screenshots

Version
v0.2.1

Logs
No special logs

Hi @geowalrus4gh.

freight box is detected when a new chart version comes up. But no version information is displayed.

This is a UI issue. cc @rbreeze

Also when promoted, stages shows promoted but no commits there in the git branch

I'd need to see what kind of promotion mechanisms you're using and whether they may be misconfigured.

I'd need to see what kind of promotion mechanisms you're using and whether they may be misconfigured.

Nevermind. I see that's in #1281.

@geowalrus4gh Can you confirm that this bug is still present for you in main (or 0.5.0)? I see you were running v0.2.1 when you encountered it


Implementation of Ebay OAuth2 strategy for OmniAuth

Hi!
Even though the approach of this implementation is close to currently approved one(which IMO is definitely good) it slightly differs in configuration details and scope handling and I hope it deserves to be reviewed.
Thanks in advance!

Thank you very much for the review and comments!
I believe I've fixed all of them :)
Also I want to know your thoughts about assigning default public scope to token or append it to list of desired scopes. Leave it in current implementation as is?

I can't imagine why and when someone could need a token without an even public scope but who knows…
So how it is done in the current implementation is fine for me, at least for now.
But maybe it worth to have public scope to be the default but allow the user to get tokens without scopes at all by passing an empty array for example.

I'm closing this PR in favor of #2. I'm very grateful for your work and patience in resolving issues.
This wasn't an easy decision as all three submitted pull requests were fully functional solutions, differing in some subjective things.
This project is now alive and if you notice that it lacks some useful features, have bugs or needs polishing — pull requests are always welcome!
I learned something about OAuth while reviewing this PR (even after working with this protocol before) and hope that you have learned a lot too.

I'm absolutely OK with that - at least #2 was submitted much faster :)
Thanks for your comments and good luck!


category field params breaking for category with commas

Category field params are not working as expected for one of our categories: "Design, Photography, & Fashion". My theory is that it has something to do with the commas, as it's our only category (of 8) that isn't working, and the only category that has commas in it.
Using find_by, and passing a string to the category field, the query works as expected:
cats = Contentful::Article.find_by(production: true, category: "Design, Photography, & Fashion").limit(1000).load.to_a
cats.count
 => 31

But if I pass it as an argument in an array, it won't return any results for that category:
cats = Contentful::Article.find_by(production: true, category: ["Design, Photography, & Fashion", "Sports & Games"]).limit(1000).load.to_a
cats.count
 => 11
cats.map(&:category).uniq
 => ["Sports & Games"]

Using .params instead of find_by is even worse off:
no_design = Contentful::Article.find_by(production: true).limit(1000).params({'fields.category[nin]' => "Design, Photography, & Fashion"}).load.to_a

no_design.map(&:category).uniq
 => ["Film & TV", "Culinary Arts", "Music & Entertainment", "Politics & Society", "Design, Photography, & Fashion", "Sports & Games", "Writing", "Science & Technology"]

"Design, Photography, & Fashion" should have been excluded but clearly was not.
design = Contentful::Article.find_by(production: true).limit(1000).params({'fields.category[in]' => "Design, Photography, & Fashion"}).load.to_a
 => []

We have 31 articles in this category, as you can see in the first code block, but nothing is returned.
Please fix ASAP. This is breaking our application. Let me know if there is any more data or information that would be helpful for your debugging. Thanks!

Hey @FuzzWorley,
Your issue is happening because it's treating each of the comma separated values as a different element on the array (this is how arrays are interpreted when sent as query parameters in an HTTP request), in order to get this to work for your case when the comma is part of what you're searching for, you need to replace the , character to the HTML Entity sequence that replaces the comma, which is ,.
For reference, here you have a complete list of all HTML Entities: https://www.freeformatter.com/html-entities.html
Hope this helps,
Cheers

Hey @dlitvakb ,
That makes sense, thanks for the info! Still having trouble after encoding with CGI::encode.
CGI::escape(article_category)
=> "Design%2C+Photography%2C+%26+Fashion"

Contentful::Article.all.params({"fields.category[in]"=>"Design%2C+Photography%2C+%26+Fashion"}).load.total
=> 0 #where there should be 31 entries.

This string matches the one that I get from the w3schools generator, but I've also tried multiple encoding libraries because that one didn't work:
CGI.escapeHTML
CGI::escape
URI.escape
And none of them seem to work. It appears URL encoding breaks this query in general:
(byebug) Contentful::Article.all.params({"fields.category[in]"=>"Culinary Arts"}).load.total
164
(byebug) Contentful::Article.all.params({"fields.category[in]"=>"Culinary+Arts"}).load.total
0
(byebug) Contentful::Article.all.params({"fields.category[in]"=>"Culinary%20Arts"}).load.total
0

It only appears to work when not encoded. Again thanks for your help!

Thanks for trying this out, I think that the issue is that your %2C is getting actually transformed to %252C (basically the % character itself getting URL encoded.
I'll take a look into what possibly be done to avoid this issue.
Cheers

Cool, I appreciate your time on this as it's quite important to our business. I'm not convinced that %2C being transformed is the issue though based on the fact that even when I encode something that returns no percentages, the query still breaks.
Contentful::Article.all.params({"fields.category[in]"=>"Culinary Arts"}).load.total
164

CGI::escape("Culinary Arts")
 => "Culinary+Arts"

Contentful::Article.all.params({"fields.category[in]"=>"Culinary+Arts"}).load.total
0

Hey @dlitvakb
Any update on this issue?

Not yet, sadly hadn't got dedicated time to look into this until today.
Will check and come back to you as soon as I find something.
Cheers

Hey @FuzzWorley,
I've looked into the SDK - it is sending the proper percent encoded values (so you don't need to do it yourself). This means that there is a bug in our backend service. I will forward this to the corresponding team and give them the appropriate context.
Cheers

Looks like our backend treats %2C and , as the same character for in queries, therefore it will not work for your particular use case. If possible, you can replace it to using eq instead, and it will be working properly.
This is sadly a technical limitation of our backend, hopefully you can use the workaround.
Cheers

Thanks @dlitvakb! This appears to be fixing the issue for now.


Enable compression on dev server responses

Fixes #416
Enables compression for files sent in dev server.
I went ahead and added br and deflate quickly since they were only a couple extra if statements. Let me know if you would like those removed.
Without compression:

With gzip compression:

@FredKSchott We shouldn't be applying compression to binary files, I'm not currently accounting for that. Should I add a lib like compressible to determine it? (Update: Added as a separate commit which we can remove if you want)
Future enhancements, we could check the file size and apply a threshold before compressing since sometimes smaller files can actually get larger and just cause an additional load to the server

Thanks @stramel


[Feature💄]: Refactor reset password component.

👶 Getting Started
Please search the history to see if an issue already exists for the same problem.

[X] I have searched the existing issues.
[X] I have tested the latest version.

📝 Describe the feature
The current implementation of ResetPassword states component are not following the so-called "Best Practice" or whatever. You can take a look at the SignIn component after the refactoring process for a guide to how things should look like.
📸 Screenshots
Not necessary.
🔦 Context
That's it. Good luck!

Hi @wiseaidev, I would like to work on this issue! Thanks.

Thanks once again for your contribution!


fix: convert npm install question to a cli flag

Closes #1742

can you fix the DCO check?

can you fix the DCO check?

Should be fixed now

CI is failing

@flakey5 I fixed the execution of cli tests because somehow it was not working, let's wait for CI


Lift is always zero

After pruning, the Lift column contains only zero values.

Pruned rules replicate original lift values.