Multiple methods (for instance unit.attackRange) are not working for types 'shaman' and 'brawler' in Giants Gate.

Using python, the methods unit.maxSpeed, unit.attackDamage, unit.attackCooldown, unit.attackRange are not working for types 'shaman' and 'brawler' in Giants Gate. The methods work properly for types 'thrower', 'ogre', 'munchkin', 'warlock', and 'giant', but raise a TypeError when called for a 'shaman' or 'brawler' unit.
Also, the unit.findDistanceTo(target) and unit.findNearest(objects) don't seem to be working for any unit types.

You could create your own .distanceTo() and .findNearest() function, but yes, the unit.attackRange/unit.attackDamage/whatever functions are un-creatable.

Thanks for the suggestion joshkordek3.
That's in fact what I've done. I just thought someone should report the issue, since this is an educational platform, and a student encountering an 'official' method that doesn't work might assume the problem is with some nonexistent error in their code, and spend fruitless hours trying to figure it why it isn't working.
That's the kind of problem that can end a budding career in CS (or cause early onset ulcers : )


HARP-7105 Cleanup script for dist folder and cache policy

Added cleanup script for dist folder and added explicit HTTP cache policy to Travis S3 deploy.
Signed-off-by: Marcel Pursche<EMAIL_ADDRESS>Thank you for contributing to harp.gl!
Before requesting a pull request, please remember to check the following documents:

contribution guidelines
coding style

If you are adding new functionality we would highly appreciate if you can describe what is the capability you are adding and even better if you can add some examples. Please also remember to add tests for it.
CI Check
Our bots will check whether your PR can be directly integrated into the mainline. We have some internal integration tests running on the background, our bots will inform you of the next steps and someone from our team will take a look and help if needed!
And please do not forget to sign-off your commit! You can read more about DCO here. But, in short, you just need to use git commit -s or append --signoff when you are committing to the repo.
Happy contributing!

Codecov Report

Merging #1137 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1137   +/-   ##
=======================================
  Coverage   46.62%   46.62%
=======================================
  Files         256      256
  Lines       22658    22658
  Branches     5061     5061
=======================================
  Hits        10565    10565
  Misses      12093    12093

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 02e8dc5...4ea4902. Read the comment docs.


Issue with Julia 1.7

Hello people,
The package is throwing errors when I use it in Julia version 1.7.3. But surprisingly, in Julia version 1.6.3, the same piece of code runs smoothly without any errors. Even the example given in the Git page's readme is throwing an error!
Output from v 1.6.3:
[ Info: Global identifiability assessed in 15.339882808 seconds
Dict{Any, Symbol} with 4 entries:
  a12 => :locally
  a21 => :globally
  a01 => :locally
  b   => :nonidentifiable

Output from v 1.7.3:
[ Info: Computing Wronskians
ERROR: MethodError: Cannot `convert` an object of type
  Nemo.gfp_abs_series to an object of type
  AbstractAlgebra.Generic.AbsSeries
Closest candidates are:
  convert(::Type{T1}, ::CxxWrap.CxxWrapCore.SmartPointer{DerivedT}) where {BaseT, T1<:BaseT, DerivedT<:BaseT} at ~/.julia/packages/CxxWrap/OcN1Z/src/CxxWrap.jl:276
  convert(::Type{T}, ::T) where T at /Apps/conda/share/julia/base/essentials.jl:218
Stacktrace:
 [1] setindex!(h::Dict{AbstractAlgebra.MPolyElem, AbstractAlgebra.Generic.AbsSeries}, v0::Nemo.gfp_abs_series, key::Nemo.gfp_mpoly)
   @ Base ./dict.jl:381
 [2] wronskian(io_equations::Dict{Nemo.fmpq_mpoly, Nemo.fmpq_mpoly}, ode::ODE{Nemo.fmpq_mpoly})
   @ StructuralIdentifiability ~/.julia/packages/StructuralIdentifiability/wOUIO/src/wronskian.jl:223
 [3] macro expansion
   @ ./timing.jl:299 [inlined]
 [4] assess_global_identifiability(ode::ODE{Nemo.fmpq_mpoly}, funcs_to_check::Vector{Any}, p::Float64; var_change::Symbol, gb_method::Symbol)
   @ StructuralIdentifiability ~/.julia/packages/StructuralIdentifiability/wOUIO/src/global_identifiability.jl:207
 [5] assess_global_identifiability
   @ ~/.julia/packages/StructuralIdentifiability/wOUIO/src/global_identifiability.jl:200 [inlined]
 [6] macro expansion
   @ ./timing.jl:299 [inlined]
 [7] assess_identifiability(ode::ODE{Nemo.fmpq_mpoly}, funcs_to_check::Vector{Nemo.fmpq_mpoly}, p::Float64)
   @ StructuralIdentifiability ~/.julia/packages/StructuralIdentifiability/wOUIO/src/StructuralIdentifiability.jl:110
 [8] assess_identifiability (repeats 2 times)
   @ ~/.julia/packages/StructuralIdentifiability/wOUIO/src/StructuralIdentifiability.jl:68 [inlined]
 [9] top-level scope
   @ REPL[3]:1

Also surprisingly, the version of the package is v0.3.9 in Julia 1.6.3 while it is v0.1.0 in Julia 1.7.3, and I am unable to update to higher version in the 1.7 Julia.
Please help me out!

@vembha
Thank you for reporting! There should be a dependency issue, I will check it by the end of the week.

@vembha can you please post the result of the following julia command?
>]st

The issue with versions is due to a dependency you may have installed, possibly an older version of Nemo/abstractAlgebra.

The status of my packages, as you've asked for:
(@v1.7) pkg> st
      Status `~/.julia/environments/v1.7/Project.toml`
  [5b7e9947] AdvancedMH v0.6.7
  [6e4b80f9] BenchmarkTools v1.3.1
  [336ed68f] CSV v0.10.4
  [a93c6f00] DataFrames v1.3.4
  [0c46a032] DifferentialEquations v7.1.0
  [31c24e10] Distributions v0.25.60
  [ced4e74d] DistributionsAD v0.6.40
  [61744808] DynamicalSystems v2.3.0
  [5789e2e9] FileIO v1.14.0
  [f6369f11] ForwardDiff v0.10.30
  [28b8d3ca] GR v0.64.3
  [a98d9a8b] Interpolations v0.13.6
  [c7f686f2] MCMCChains v5.3.0
  [6fafb56a] Memoization v0.1.14
  [961ee093] ModelingToolkit v8.11.0
  [429524aa] Optim v1.7.0
  [f0f68f2c] PlotlyJS v0.18.8
  [91a5bcdd] Plots v1.29.0
  [21216c6a] Preferences v1.3.0
  [90137ffa] StaticArrays v1.4.4
  [2913bbd2] StatsBase v0.33.16
  [f3b207a7] StatsPlots v0.14.34
  [220ca800] StructuralIdentifiability v0.1.0
  [fce5fe82] Turing v0.21.2
  [fdbf4ff8] XLSX v0.7.10
  [8ba89e20] Distributed
  [37e2e46d] LinearAlgebra
  [9a3f8284] Random

@vembha Thank you. I could not reproduce the issue yet. What operating system are you using?

My Julia is installed in my university's HPC machine. The OS is Cent OS. But weirdly, on the same system, they have Julia v1.6, where the package works perfectly. So, I think it is not related to the OS or the machine, but something else.
Hope that helps.

Thanks for the info, @vembha . What happens if you try to install the specific version, like the code below?
>]add<EMAIL_ADDRESS>

I tried CentOS Linux release 7.9.2009 with Julia-1.7.3, on a new environment with >]activate /tmp/structural_identifiability and with required packages added one by one starting with StructuralIdentifiability.jl. The example worked, I could not reproduce the issue.
I also tried installing everything at once and specifying the version, this worked on my CentOS HPC
>]add<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>Distributed, LinearAlgebra, Random

Hope this helps.

Great, it worked for me too. Thanks! 😄 It looks like forcibly choosing the version number for installation gets the work done.


height of entered window reset unexpectedly when leaving the command-line window

Describe the bug
When leaving the command-line window, the height of the entered window is reset to an unexpected value if the geometry of the terminal has changed after the command-line window was entered.
To Reproduce

Run this shell command:
vim -Nu NONE +'au WinEnter * wincmd _' +'bo sp' +'set lines=10'

Press q: to open the command-line window.

Run :set lines=30 to increase the height of the terminal from 10 lines to 30 lines.

Run :q to close the command-line window.

The window is 6 lines high.
Expected behavior
The window is 26 lines high, because of the autocmd running wincmd _ on WinEnter.
Environment

Vim version: 8.1 Included patches: 1-2225
OS: Ubuntu 16.04.6 LTS
Terminal: XTerm(322)

Additional context
I could be wrong, but I think it's a bug because WinEnter is fired – in the context of the second window – after CmdWinLeave is fired; so wincmd _ should maximize the latter after the command-line window has been closed.
Besides, if you replace :bo sp with :sp:

in the context of the command-line window, the previous window number changes from 2 to 1
the issue is not triggered

So, if the autocmd succeeds in maximizing the window which is entered after leaving the command-line window while the previous window is the top one, I would expect it to also succeed when the previous window is the bottom one.

I think that the height of the last window which is entered is 6 because it's the height of the old command-line window (4) + 2 for the status line and the single text buffer line of the window which was above.
This is confirmed by the fact that if you set 'winminheight' to 0, the height of the last window which is entered is 7 (height of the old command-line window + 1 for the status line which was above).

This additional autocmd can be used as a workaround:
au CmdWinLeave * au CursorMoved * ++once wincmd _

Example:
               vvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvv
vim -Nu NONE +'au CmdWinLeave * au CursorMoved * ++once wincmd _' +'au WinEnter * wincmd _' +'bo sp' +'set lines=10'
" press `q:`
:set lines=30
:q

I frequently encounter this issue when I use tmux and close a pane which changes the geometry of the terminal from Vim's point of view. I have a plugin to automatically set the height of the focused window; it succeeds into maximizing its height after leaving the command-line window; but Vim resets its height right afterward, if the geometry of the terminal has changed after the command-line window was opened.

I'm not quite sure what you are trying to do.  I do see that when 'lines' change while the command line window is open, restoring the window sizes causes trouble.  I'll make it so that window sizes won't be restored if 'lines' changes.  I would not know what to restore them to then, so might as well skip it.


Choice options do not get normalized for case

In the options doc page there's an example of case normalization of choice options. I've created the file digest.py with the following contents:
import click

@click.command()
@click.option('--hash-type',
              type=click.Choice(['MD5', 'SHA1'], case_sensitive=False))
def digest(hash_type):
    click.echo(hash_type)

if __name__ == "__main__":
    digest()

The only difference from the example in the docs is that I'm not using setup Setuptools.
So I am running my command like this: python digest.py --hash-type=md5. According to the docs I should see MD5, the originally passed choice. In reality I am getting md5. Am I doing something wrong, or is this a bug?
Click version is 7.0.

From those docs:

Changed in version 7.1

This has not been released yet.


Project Launch

When I have run the project, it's only loading & loading the UI

@ashik5757 please help me

Did you put all the files(png,txt) of data folder properly?
On Sat, Aug 13, 2022 at 10:01 PM Mohammad Tawhid Gias <
@.***> wrote:

When I have run the project, it's only loading & loading the UI
[image: image]
https://user-images.githubusercontent.com/60693492/184501757-38f0da78-299d-423e-b20d-7ca9a02fc683.png
@ashik5757 https://github.com/ashik5757 please help me
—
Reply to this email directly, view it on GitHub
https://github.com/ashik5757/ScoreBoard-Project/issues/7, or unsubscribe
https://github.com/notifications/unsubscribe-auth/ATQG2FCI2P4QXFS2QM3IMNLVY7BGXANCNFSM56OK47XQ
.
You are receiving this because you were mentioned.Message ID:
@.***>

Yes @ashik5757 I have put the data folder in src of the project

Open this project file in IntelliJ directly and then update sdk(if not
found), remove javafx-sdk that added and add your javafx-sdk again, add all
the module dependency (controlfx, mysql)
and then must change the directory path for javafx-sdk-16\lib in VM option
in Run Configurations as same procedure mention in Readme.me
Let me know whether it is working or not.
On Sat, Aug 13, 2022 at 11:19 PM Mohammad Tawhid Gias <
@.***> wrote:

Yes @ashik5757 https://github.com/ashik5757 I have put the data folder
in src of the project
—
Reply to this email directly, view it on GitHub
https://github.com/ashik5757/ScoreBoard-Project/issues/7#issuecomment-1214192492,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ATQG2FFBDZO5K46NYZNQLGLVY7KIRANCNFSM56OK47XQ
.
You are receiving this because you were mentioned.Message ID:
@.***>

Check email, I attached a scoreboard.zip file

I didn't get the file in my email. Can you send it again please @ashik5757?

@ashik5757 Please help me quickly. Can we get a session in AnyDesk or TeamViewer? I need your help badly

Check the new released section,  I attached a zip file for IDE. And follow
the procedure mentioned in the previous email.
On Sun, 21 Aug 2022, 11:51 pm Mohammad Tawhid Gias, <
@.***> wrote:

@ashik5757 https://github.com/ashik5757 Please help me quickly. Can we
get a session in AnyDesk or TeamViewer? I need your help badly
—
Reply to this email directly, view it on GitHub
https://github.com/ashik5757/ScoreBoard-Project/issues/7#issuecomment-1221592203,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ATQG2FEFSWRNOPDAH2LG6OLV2JUC3ANCNFSM56OK47XQ
.
You are receiving this because you were mentioned.Message ID:
@.***>

Let me know, whether it is working or not.
On Mon, 22 Aug 2022, 12:01 am Ashik Rahman, @.***>
wrote:

Check the new released section,  I attached a zip file for IDE. And follow
the procedure mentioned in the previous email.
On Sun, 21 Aug 2022, 11:51 pm Mohammad Tawhid Gias, <
@.***> wrote:

@ashik5757 https://github.com/ashik5757 Please help me quickly. Can we
get a session in AnyDesk or TeamViewer? I need your help badly
—
Reply to this email directly, view it on GitHub
https://github.com/ashik5757/ScoreBoard-Project/issues/7#issuecomment-1221592203,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ATQG2FEFSWRNOPDAH2LG6OLV2JUC3ANCNFSM56OK47XQ
.
You are receiving this because you were mentioned.Message ID:
@.***>

@ashik5757 How can I remove the added javafx-sdk & add all module dependencies?

@ashik5757 It's not working yet. Please help me


avoid multiple calls to show the alertview. This solves issues where …

…the alertview disappears after multiple calls and the UI is blocked by the alertviews overlay that is still visible

Thank you for this pull request. KINWebBrowser 1.3.0 features this functionality inspired by your code!


Some cleanup

FYI: typeof is faster than checking the constructor, the constructor trick is nifty if you need to check for Array among other things, since typeof is useless there :).

Ref #4

Merged with a typo fix.. Thanks! 👍


@PermiAll annotation breaks navigateTo

naviagteTo doesn't work (Vaadin UI uncaught exception com.vaadin.flow.router.NotFoundException),
if to put @PermiAll on a class with @Route annotation.
Removing @PermiAll doesn't help.
To allow naviagteTo to work, I need to replace @PermiAll with @AnonymousAllowed temporarily.
spring-boot: 2.7.7
Vaadin: 23.3.2
karibu: 1.1.3
karibu-tools: 0.13
karibu-testing: 1.3.23

Hi, hmmm, that's interesting. Perhaps you're running the tests in production mode and the access is rejected to given route? In such case Vaadin responds with NotFoundException, in order to not to reveal to the potential attacker that the route in fact exists.

Yes, the tests are run in the production mode.
I have investigated, how Vaadin checks the access to views.
Several classes participate in the check process: SpringViewAccessChecker extends ViewAccessChecker and uses AccessAnnotationChecker to check the access.
As a workaround, I have created my own custom implementation of AccessAnnotationChecker, which bypasses annotation checks if setting isProdEnvironment=false.
So, the issue can be closed.
`
open class KVdAccessAnnotationChecker(
env: Environment,
prefix: String = defaultPrefix,
) : AccessAnnotationChecker(),
KServiceHasLoggingEnabledA by KServiceHasLoggingEnabled(env, prefix) {
companion object : KLoggerA {

    const val defaultPrefix = "KAccessAnnotationChecker"

    private val log by lazy { classLogger }
}

@Suppress("MemberVisibilityCanBePrivate")
protected val isProdEnvironment = env.getRequiredProperty<Boolean>("$prefix.isProdEnvironment", log)

override fun hasAccess(method: Method?, principal: Principal?, roleChecker: Function<String, Boolean>?): Boolean {
    if (isServiceLoggingEnabled) log.info("hasAccess($method, $principal, roleChecker)")
    return if (isProdEnvironment) {
        super.hasAccess(method, principal, roleChecker).also {
            if (isServiceLoggingEnabled) log.info("super.hasAccess(method, principal, roleChecker) -> $it")
        }

    } else {
        true.also {
            if (isServiceLoggingEnabled) log.info("true")
        }
    }
}

override fun hasAccess(cls: Class<*>?, principal: Principal?, roleChecker: Function<String, Boolean>?): Boolean {
    if (isServiceLoggingEnabled) log.info("hasAccess($cls, $principal, roleChecker)")

    return if (isProdEnvironment) {
        super.hasAccess(cls, principal, roleChecker).also {
            if (isServiceLoggingEnabled) log.info("super.hasAccess(cls, principal, roleChecker) -> $it")
        }
    }else {
        true.also {
            if (isServiceLoggingEnabled) log.info("true")
        }
    }
}

}
`

Thank you for letting me know; closing as fixed then. However, perhaps Karibu should offer some support out-of-the-box for this? If yes, we can brainstorm on the best way.


Implement configurable file compression for static files

Many different types of static files can benefit from compression when transferred over HTTP. The rdfpub generator currently only compresses RDF files that are generated for a resource; see the relevant Dockerfile lines for reference.
A new configuration option in a site's .rdfpub file should allow a site author to specify additional files to compress, such as CSS files. A list of regular expressions or wildcards for file names would work well for this, thus allowing site authors to add static compression to files of their choosing.
A solution would likely require changes to the aforementioned Dockerfile as well as to Nginx configuration such that compressed versions of files would be considered when serving static files.

This is now possible by using the new CompressFiles configuration options in a site's .rdfpub config file like so:
CompressFiles:
  - '\.css$'
  - '\.txt$'
  - '\.md$'
  - LICENSE

Documentation on the rdfpub tutorial site for this configuration option are forthcoming.


Unable to click 'Get' button due to being obsured (?) + Fix detection of post-buying game page

Ran into those two issues when trying to claim games today.
Somehow it fails to click on the 'Get' button complaining that the parent obscures it. The fix here is to simply click the parent if that happens. So far this issue only happened with this specific button.

They apparently changed the text on the buying confirmation page. Updated the string to match it.

Thanks for getting this figured out in time!


Use newer node version so that graphql queries work again

Graphql API calls weren't working.

Actually - this causes the webworker build to fail if you run yarn compile-web. I thought the issue was that it was using cjs there which is why I did the downgrade, there must just be something missing in the webworker webpack to handle this

Nevermind, there isn't an issue with cjs, the node-fetch alias just needs to be removed from browser.webpack.config.js

Everything builds if I remove the node-fetch alias. Thanks!


[WIP] Update style of using and import

Codecov Report
Attention: Patch coverage is 64.81481% with 19 lines in your changes are missing coverage. Please review.

Project coverage is 82.92%. Comparing base (d12ed32) to head (708f1f9).

Files
Patch %
Lines

src/abstractitensornetwork.jl
74.07%
7 Missing :warning:

src/Graphs/abstractdatagraph.jl
0.00%
4 Missing :warning:

src/abstractindsnetwork.jl
66.66%
3 Missing :warning:

src/formnetworks/abstractformnetwork.jl
0.00%
1 Missing :warning:

src/formnetworks/quadraticformnetwork.jl
0.00%
1 Missing :warning:

src/gauging.jl
0.00%
1 Missing :warning:

src/treetensornetworks/projttns/abstractprojttn.jl
0.00%
1 Missing :warning:

src/treetensornetworks/projttns/projttnsum.jl
50.00%
1 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #149      +/-   ##
==========================================
- Coverage   82.96%   82.92%   -0.04%
==========================================
  Files          71       71
  Lines        3762     3754       -8
==========================================
- Hits         3121     3113       -8
  Misses        641      641

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

In the latest commit, I updated the syntax for all of the remaining functions that were being overloading with import M: f; function f(...) ... end to the syntax function M.f(...) ... end.
For future reference, I used the function replace_in_files from a package I have been developing called FileUtils.jl, which recursively calls Base.replace on every line of each file in a file path.
Here is the script I used:
# https://docs.julialang.org/en/v1/base/base/#Base.names
function imported_names(M::Module)
  return setdiff(names(M; imported=true), names(M; imported=false))
end

function imported_functions(M::Module)
  return map(f -> getfield(M, f), imported_names(M))
end

using FileUtils: replace_in_files

function prepend_imports(M::Module)
  fs = imported_functions(M)
  # foreach(f -> @show((parentmodule(f), f)), fs)
  src_path = joinpath(pkgdir(M), "src")
  @show src_path
  for f in fs
    function_name = last(split(string(f), "."))
    module_name = last(split(string(parentmodule(f)), "."))
    annotated_function_name = module_name * "." * function_name
    @show function_name, annotated_function_name
    replace_in_files(
      src_path,
      "function $(function_name)(" => "function $(annotated_function_name)(";
      recursive=true,
      ignore_dirs=[".git"],
      showdiffs=false,
    )
    replace_in_files(
      src_path,
      Regex("^$(function_name)\\(") => "function $(annotated_function_name)(";
      recursive=true,
      ignore_dirs=[".git"],
      showdiffs=false,
    )
  end
end

using ITensorNetworks: ITensorNetworks
prepend_imports(ITensorNetworks)

@JoeyT1994 please try to be consistent with this style in new PRs, i.e. overloading functions defined in other modules with function M.f(...) ... end instead of import M: f; function f(...) ... end, and also instead of writing using M, put a more explicit using M: fat the top of each file wheref` is being used.

I've removed all of the import statements and some of the using statements, but I haven't changed over all of the using statements yet. I think I'll merge this as-is once tests pass and work on the using statements in a future PR.
using statements of examples and tests should also be updated from using M to using M: f, that will take some time but maybe we can update those incrementally, say as we make changes to a certain test or example file we also update that style.
Another style improvement will be to wrap each test file in a temporary module, which helps with namespace issues (i.e. helps to avoid having naming conflicts with previously defined variables when running tests), see for example https://github.com/ITensor/ITensors.jl/blob/v0.3.58/NDTensors/src/lib/BlockSparseArrays/test/test_basics.jl.

@JoeyT1994 please try to be consistent with this style in new PRs, i.e. overloading functions defined in other modules with function M.f(...) ... end instead of import M: f; function f(...) ... end, and also instead of writing using M, put a more explicit using M: f at the top of each file where f is being used.

Thanks @mtfishman I will make sure to try to stick with that style going forward and incorporate it into the inner PR


Hide the gray box with the avg framerate

I am sorry if this is super easy to do that sounds stupid, but I don't know how to turn that box off, it is in the lower right corner even after I turn off the OSD.

Never mind, I found how to disable it in the mod settings.


[dashboard] Fix for dashboard edit modal, loading user list

CATEGORY

[x] Bug Fix
[ ] Enhancement (new features, refinement)
[ ] Refactor
[ ] Add tests
[ ] Build / Development Environment
[ ] Documentation

SUMMARY

The /users/api/read endpoint was removed, so this switches to the new /api/v1/dashboard/related/owners endpoint, which should also be more accurate regarding which users are returned as potential dashboard owners.

Codecov Report

Merging #9081 into master will not change coverage.
The diff coverage is 0%.

@@           Coverage Diff           @@
##           master    #9081   +/-   ##
=======================================
  Coverage   59.45%   59.45%
=======================================
  Files         369      369
  Lines       11752    11752
  Branches     2889     2888    -1
=======================================
  Hits         6987     6987
  Misses       4586     4586
  Partials      179      179

Impacted Files
Coverage Δ

...ssets/src/dashboard/components/PropertiesModal.jsx
7.27% <0%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 540df26...d3f5efe. Read the comment docs.

@dpgaspar What filters do you think should be used?


All codes shown in 1 line

All the codes highlighted by highlighter is shown on 1 line as shown in the screenshot.
I created a minimal replication on StackBlitz.
And thanks for the work on highlighter.

 I think you are the first person to use something I built out in the wild! Awesome!
So every line is just a span which is default display: inline, the highlighter doesn't make any assumptions about the styling. I could possibly change the element containing a line to a div. I did it this way because it's how the Shiki highlighter does it by default.
So, to fix the issue either you could do something like:
code > span {
  display: block;
}

or what I do is this
pre > code {
  display: flex;
  flex-direction: column;
}

If you want to check out how I style the code blocks on my personal website, look though this file.
https://github.com/johnhooks/johnhooks.github.io/blob/6e6f5cf67e822dd053cc51a664c2d9c1047c28b1/apps/website/src/app.css#L1-L87

Also FYI, the highlighter doesn't use the theme background color, I'll try to fix that soon. But for now it's pretty easy to manually set it in css.

Another option, which is probably the right thing to do, I could put new lines back in on every line. They get stripped out during the tokenization of the code block. What solution do you like best?

@tanerijun I think<EMAIL_ADDRESS>should fix the issue, it adds newlines back in after tokenization.

 I think you are the first person to use something I built out in the wild! Awesome!
So every line is just a span which is default display: inline, the highlighter doesn't make any assumptions about the styling. It just tokenizes the code block. I could possibly change the element containing a line to a div which is default display: block. I did it this way because it's how the Shiki highlighter does it by default.
So, to fix the issue either you could do something like:
code > span {
  display: block;
}

or what I do is this
pre > code {
  display: flex;
  flex-direction: column;
}

If you want to check out how I style the code blocks on my personal website, look though this file.
https://github.com/johnhooks/johnhooks.github.io/blob/6e6f5cf67e822dd053cc51a664c2d9c1047c28b1/apps/website/src/app.css#L1-L87
Visual example: https://johnhooks.io/projects/highlighter

Thanks for the quick response.
Since the highlighter acts differently from mdsvex's default, I just assumed that it's broken without thinking much about it. I think you should consider adding this to the docs.

I've determined it was a bug, it shouldn't strip out the new lines. Just took another person's perspective for that to become obvious. Thanks.


Plugin to work With class Attribute

Plugin Package  that Provides a few small Plugins to modifiziert the classList of an Element.

addClass
removeClass
toggleClass

All three Plugins should accept piped values.
How the values are Used should be defined via options.
Data-jetjs-addClass-value="foo${value}bar"
They should work like es6 Template Strings. The ${value} is the received piped value.
Übt the piped value Must Not be used, it can also used only as trigger to rexecute the addClass Plugin. Useful with the toggleClass Plugin.
All three Plugins accept the data-jetjs-***Class-value Attribute to Delfine the classname to work with. The default is ${value} (the piped value or empty of noch value was received)

Draft implementation: https://codepen.io/alexanderbartels/pen/GvLOzJ

if Issue #10 is implemented the mode Alias Plugins can be defined, to make plugin definitions even easier.


Time look back fixes

i ported the changes into the larger overhaul of things in #6, closing this pr, thank you for having a look into!


Fix some typos, grammar and formatting in console messages

I've been really enjoying this addon!
I noticed some typos in the console messages while using it, so I fixed them along with improving some of the grammar used in the other notifications. I tried to change as little as possible to ensure that the original meaning of the messages stays the same.

Your change of this warning have different meaning. Please fix it.

Good catch! This is fixed now.

Thank you for your contribution!


Cannot extract downloaded dictionaries

Hi, I am not able to download and install any new dictionary, it always downloads it but fails the extraction.

Can you quote the exact error message, just to be sure?
Also, did you happen to change the storage location to an external SD card?
I recently got a report where that seemed to be the cause (though I do not yet understand why/how).

It says (the message is in Italian, so I am translating): "Dictionary
decompression failed: file:///storage/emulated/0/EN-EO.quickdic.v006.zip
There are 3 GB free on /storage/emulated/0
I see this only in this moment: why it is trying to decompress to the root
of the /storage/emulated/0 ?? Could it be that it has permission problems
with that directory?
The QuickDic Directory is set to /storage/MicroSD/AppData/QuickDic
On Tue, Nov 17, 2015 at 1:37 PM, Reimar Döffinger<EMAIL_ADDRESS>wrote:

Can you quote the exact error message, just to be sure?
Also, did you happen to change the storage location to an external SD card?
I recently got a report where that seemed to be the cause (though I do not
yet understand why/how).
—
Reply to this email directly or view it on GitHub
https://github.com/rdoeffinger/Dictionary/issues/8#issuecomment-157360853
.

--
Daniele "MadMage" Calisi
"Your limit is always a bit beyond"

No need to translate, those are translated strings I can look up (plus I can understand basic Italian)
The message is bad/confusing. It is downloading to /storage/emulated/0, and the file it decompresses is there. I don't think it's a permission issue.
But the QuickDic dictionary seems to be on an external SD, so that seems consistent with the other report.
After a bit of searching, it seems using external SD cards simply isn't possible without a major hassle: https://metactrl.com/docs/sdcard-on-lollipop/
In theory if you specifically specify Android/data/de.reimardoeffinger.quickdic it is supposed to work, but it seems like there are more bugs in Android and that only works if you got that path through the APIs, not of a user entered it manually.
Best chance of fixing this is probably to implement issue #4 which can then do all the necessary magic.

I added a new release (here and in Google Play beta channel) that should print an error and suggest alternatives if the selected directory is not writeable.
It's a bit messy and I haven't tested it yet (I made it mostly for trying some things out myself later), but if you have time over feel free to check if it helps.

I think 5.1.2 release will make this work, it will warn when a directory that cannot be written is chosen an it will suggest alternatives.
This is still not as user-friendly as I'd like, but it should work for the moment I hope.
Still need to test it a bit more before releasing as stable.

Newest release works for me and pinpoints the issue and gives hints about possible ways to resolve.
I was able to use an external SD card that way.

Reopen if you still have issues (besides bad usability which I track in that other ticket).

Hi Reimar,
sorry for not replying so far: I am not sure how can I install the new
version, since there is no new release on Google Play and when I install
the APK by hand, it says it has installed it, if I try to reinstall, it
says that I have version 5.1.2 and I want to install 5.1.2 (so I assume it
has been installed correctly), but the app itself, in the about screen,
says I have 5.1.0 and, above all, the behavior is the same with that bug
On Thu, Nov 19, 2015 at 9:23 AM, Reimar Döffinger<EMAIL_ADDRESS>wrote:

Reopen if you still have issues (besides bad usability which I track in
that other ticket).
—
Reply to this email directly or view it on GitHub
https://github.com/rdoeffinger/Dictionary/issues/8#issuecomment-157987144
.

--
Daniele "MadMage" Calisi
"Your limit is always a bit beyond"

I seem to have forgotten updating the version string, so the version in "about" doesn't mean anything.
If it says it's up-to-date I expect that's correct. The new version is also on the Play Store now, if in the changes list the latest entry is "Error messages when choosing an invalid storage directory" you have it.
No change means you still get the "decompression failed" and not a "Dictionary location not writable" one?
Then the issue you have isn't the one I fixed I'm afraid...
I had to use /storage/MicroSD/Android/data/de.reimardoeffinger.quickdic/files for it to work.
Now that I test some more I see that my checks don't work if the directory you specified already exists, it seems the "canWrite" function does not actually work...
I'll have to look at it again, but try the path I gave above or try entering some complete nonsense to make it print suggestions, that at least should work.

I think now the code actually works, with 5.1.3.
I also changed it so that the about page will always display the correct version, without me having to remember to change it.

Ok, somehow the last version arrived via Google Play updates on my
smartphone. Now it works (i.e., there is a popup message that says I am
using a non-writable directory and it offer some writable alternatives).
On Thu, Nov 19, 2015 at 10:03 PM, Reimar Döffinger<EMAIL_ADDRESS>
wrote:

I think now the code actually works, with 5.1.3.
I also changed it so that the about page will always display the correct
version, without me having to remember to change it.
—
Reply to this email directly or view it on GitHub
https://github.com/rdoeffinger/Dictionary/issues/8#issuecomment-158197005
.

--
Daniele "MadMage" Calisi
"Your limit is always a bit beyond"

Thanks for reporting back!
Now I just have to at some point make it actually user friendly :-)
Some day...


Implement the class Card.

gixed some bugs in the implementation with this https://github.com/sopra-fs23-group-05/Server/commit/c30f1a74cbc941df83a26d32b12a486063e7def0


(PYL-W0122) Audit required: Use of execM

Description
Usage of exec function is strongly discouraged, since it opens up possibilities of unauthorized code execution if the statements are not escaped properly. Read more on why should exec be avoided here.
Occurrences
There is 1 occurrence of this issue in the repository.
See all occurrences on DeepSource → deepsource.io/gh/ColinRobbins/scm-helper/issue/PYL-W0122/occurrences/

ok


Module::set_training takes hard-to-use &mut self

Hello everybody,
I noticed that Module::set_training takes an &mut self. This is hard to use for a non Clone and Copy type such as Linear. Taking an &mut Linear may seem viable, but my application requires an Rc<Linear>, so there is no &mut when there are more than 1 strong refs.
While looking through the code, it looks like there are only 3 impl Module in candle itself right now, so any changes would not break much code yet. I propose changing the method from taking an &mut self to &self. The trainability state would be in a Cell, and could be updated with Cell::set through an &self. To avoid sentinel values and stay idiomatic, instead of using a bool, an enum should be used with a Default impl of Trainable.
In addition, would implementing Clone on Linear and Tensor be a viable alternative? It looks like it can because Tensor is an Arc<Tensor_>.
What are your thoughts on this change?
Thanks,
Eric

Ah sorry, this set_training was actually a mistake as @Narsil already pointed out offline and should have been removed earlier, I've now removed it so that people don't start relying on it.
To me the main downsides were:

It's stateful, so requires this mut bit but also makes it easy to forget to set it and use some dropout at inference time for example.
If we provide a default implementation, it's easy to forget to pass it to submodules, if we don't it's annoying to have to set it even when writing code that will only be used for inference - or some training code that doesn't use a different behavior (so pretty much any architecture that is trained without dropout).
Instead I would want to favor a more stateless approach, i.e. if you want to train a model with a different behavior compared to inference, you could use a trait like:

trait ModuleT {
    fn forward_t(&self, xs: &Tensor, is_training: bool) -> Result<Tensor>;
}

We don't provide it at the moment as it's a bit unclear whether having a is_training: bool is sufficient or whether we want to have some more generic parameter, we would have to think more about it.
The other way is obviously to not use any trait and rather have the forward method that use the arguments that you care about, this is what is done in all the examples where the forward method needs multiple tensors or additional arguments etc.
What was your use case for using the Module trait, is it something that you can do without?

Ok, that make sense. I am working on implementing LoRA for Candle: https://github.com/EricLBuehler/candle-lora, which means that the Linear needs to have a trainable state (so that the gradients are not calculated, and therefore there are fewer trainable params for the old, wrapped layer).
If Linear has no state,, then it seems like LoRA cannot be implemented. When someone calls Optimizer::backward_step, it must be ensured that this tensor's weights and biases are not updated. So, is there a way to do this without Tensor storing state?
Perhaps the set_training method should be added again, with Tensor storing state so that it causes a short-circuit when Tensor::backward is called? As described in my original comment, set_training should take an &self, and Linear should also implement it for convenience.

Backprop only happens for tensors that are marked as "variables" (so created via candle::Var), regular tensors that you would load from say a safetensor file would not be tracked for backprop unless you explicitely make a var out of them. Wouldn't that make it possible to achieve what you describe?
Also note that the Linear layer is a very small amount of code, so if you want some specialized version of it you can definitely make one inside your model (and implement the traits that you want on it).

That make sense, but do all trainable parameters need to be wrapped in candle::Var?
It looks like Tensor implements a backward method, and that Optimizer::backward_step takes a Tensor.  I also see this:
if node.is_variable() {
    continue;
}

in Tensor::backward, so is it skipping any computations with a Var?

Yes all trainable parameters should be in a var, we backprop through tensors (hence the Tensor::backward), you can get the grad of a tensor as you noticed but this will only get populated if this tensor has a dependency on a var. The continue in the code in the var case is a technical detail that you shouldn't worry about.

Ok, thank you! Should I use VarBuilder to store my tensors in a Var? Or do I need to manually wrap with Var?

A VarBuilder based on a VarMap would be the recommended way to go, but you can certainly create your Var structs manually if you prefer, you can see how VarMap does it here.
If your linear layer is using weights that are not Var they won't be trainable (and gradients won't be tracked), up to you to decide how you create these weights, they just have to be tensors. Among the instances of VarBuilder, only the VarMap version creates Var, all the others create non-trainable Tensor (e.g. when loading from safetensor/npz/ggml/...).

Ok, that makes sense. I am writing a library, so I do not control what is passed. How do I ensure the weights and biases of the Linear layer are not variables? Can I get their "name" and then try to remove them from the VarBuilder?

Is there a way to make sure that the old Linear layer's weights and biases are not variables? Or is this something that can not be done currently?

I don't think so, you may want to create your own NonTrainableLinear or equivalent in your crate if it's important to your use case.

Would that be effective? I take the old linear as old: Arc<Linear>. In my forward method, I call .forward on the old linear, and do the required LoRA computations. The old Linear has a weight and maybe a bias (which are Tensors).
From what you explained about gradient tracking in Candle, these will not be tracked by default. However, if someone has added them to a VarBuilder, they are being tracked. Even if I wrap the Linear with a new struct or create a new version of Linear, the weights and/or biases could still be tracked, there is nothing I can do.
The reason I need this is because I am implementing LoRA, which is efficient because the old layer is not trainable (it is frozen). I need to be able to make sure the gradients from the weights and/or biases of the old Linear layer are not being tracked.
It seems to me that the only solution is to add a trainability state to the Tensor struct. How can this be implemented, perhaps with a method? Regarding backprop process itself - perhaps any non-trainable Tensor (even a variable) would not be added to the DAG? This would ensure they are not treated as variables.

You can call .detach on a tensor if you want to be sure that gradient don't go through it, with this you can easily implement NonTrainableLinear but maybe I'm missing something?
Also adding the tensor to a VarBuilder is not sufficient, you need to add it through a VarMap so that it's an actual trainable variable, so as long as you don't do this you should be fine.

Ah, okay! Thank you!


Automator: update istio/client-go@master dependency in istio/istio@master

Generated by Automator - 2024-12-30T22:49:13+00:00

@istio-testing: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests-arm64_istio
75e44c10ff9fc0ba4678e842be193e5cce7cf9b4
link
true
/test unit-tests-arm64

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@istio-testing: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests-arm64_istio
75e44c10ff9fc0ba4678e842be193e5cce7cf9b4
link
true
/test unit-tests-arm64

unit-tests_istio
75e44c10ff9fc0ba4678e842be193e5cce7cf9b4
link
true
/test unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

/retest

@istio-testing: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests_istio
75e44c10ff9fc0ba4678e842be193e5cce7cf9b4
link
true
/test unit-tests

unit-tests-arm64_istio
75e44c10ff9fc0ba4678e842be193e5cce7cf9b4
link
true
/test unit-tests-arm64

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@istio-testing: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests-arm64_istio
75e44c10ff9fc0ba4678e842be193e5cce7cf9b4
link
true
/test unit-tests-arm64

unit-tests_istio
75e44c10ff9fc0ba4678e842be193e5cce7cf9b4
link
true
/test unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@istio-testing: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests_istio
75e44c10ff9fc0ba4678e842be193e5cce7cf9b4
link
true
/test unit-tests

unit-tests-arm64_istio
05a892424bf25e04ce6d0f09d0d6e521f177f896
link
true
/test unit-tests-arm64

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@istio-testing: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests-arm64_istio
05a892424bf25e04ce6d0f09d0d6e521f177f896
link
true
/test unit-tests-arm64

unit-tests_istio
05a892424bf25e04ce6d0f09d0d6e521f177f896
link
true
/test unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@istio-testing: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests_istio
05a892424bf25e04ce6d0f09d0d6e521f177f896
link
true
/test unit-tests

unit-tests-arm64_istio
fd216fdd5846f17bc441f6cf968728958bc40e82
link
true
/test unit-tests-arm64

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@istio-testing: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests-arm64_istio
fd216fdd5846f17bc441f6cf968728958bc40e82
link
true
/test unit-tests-arm64

unit-tests_istio
fd216fdd5846f17bc441f6cf968728958bc40e82
link
true
/test unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@istio-testing: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests_istio
fd216fdd5846f17bc441f6cf968728958bc40e82
link
true
/test unit-tests

unit-tests-arm64_istio
fcb50ac1f29183ba61a7c24f568c1a2160fbff9a
link
true
/test unit-tests-arm64

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@istio-testing: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests-arm64_istio
fcb50ac1f29183ba61a7c24f568c1a2160fbff9a
link
true
/test unit-tests-arm64

unit-tests_istio
fcb50ac1f29183ba61a7c24f568c1a2160fbff9a
link
true
/test unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@istio-testing: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests_istio
fcb50ac1f29183ba61a7c24f568c1a2160fbff9a
link
true
/test unit-tests

unit-tests-arm64_istio
195e3bb99478e14c8639b366b4d679ff664ba16a
link
true
/test unit-tests-arm64

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@istio-testing: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests-arm64_istio
195e3bb99478e14c8639b366b4d679ff664ba16a
link
true
/test unit-tests-arm64

unit-tests_istio
195e3bb99478e14c8639b366b4d679ff664ba16a
link
true
/test unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.


[RESOLVED] Interface eth0(): High error rate (>2 for 5m)

Problem started at 12:30:29 on 2023.05.17
Problem name: Interface eth0(): High error rate (>2 for 5m)
Host: S100-Primario
Severity: Warning
Operational data: errors in: 1, errors out: 0
Original problem ID: 20767
Event details in Zabbix: http://<IP_ADDRESS>/tr_events.php?triggerid=23483&eventid=20767

Problem has been resolved in 3m 0s at 12:33:29 on 2023.05.17
Problem name: Interface eth0(): High error rate (>2 for 5m)
Host: S100-Primario
Severity: Warning
Original problem ID: 20767


Fix kernel ASLR breaking LLVM ASAN/MSAN builds

Ubuntu image 20240310 contained a more secure kernel build with increased kernel address randomization settings.
This is unfortunately incompatible with the provided LLVM build, and makes MSAN/ASAN crash with segfaults.
Image update fixing this is ETA March 22.
Ref: https://github.com/actions/runner-images/issues/9491#issuecomment-1989718917

We might want to wait until the updated image is available as I don't think we will merge that many pull requests that would possibly cause ASAN/MSAN builds to break and not the others.
Adding and (soon) later reverting the workaround seems counterproductive.

Is this still needed?
After new Clang/LLVM packages are added to repository, we might consider pinning the minimum versions to make sure all CI instances update to compatible version. FYI, this is similar to what we have previously done with incompatible versions of wine dependencies due to apt not correctly matching versions across architectures.


First import cpp20spaceship

Start to work on <=>.

@sponce Il est prévu de faire la partie "avancée" avec des exercices ? Et l'idée d'ue alternance plus rapide entre cours et exercices, elle est toujours dans l'air ou en sommeil ?

À mon avis, des exercices sont indispensables ! 🙂

I have on eready for <=> but where I should put it ? On emore directory in the (too) numerous ones in /code ?

WARNING : this is still a raw import from another source and format. Not yet reviewed to fit in the pages, and the content is still rather verbose, as compared as what Sebastien usually expects. More to come.

Hello @chdavid,
I would like to suggest the following change
- {\it <=}
+ \mintinline{cpp}{<=}

This would typeset the arguments as code instead of italics.
This will also fix the compilation errors, since you don't need to escape underscores inside a minted environment.

@bernhardmgruber Tried a new revision, where I rather advise : no == when <=> does not define a strong order.

So I talked to a friend of mine from the Austrian WG21 NB during my recent vacation and he said for a defaulted operator<=> it is far less important to make it a hidden friend than for the other comparison operators. The reason is that operator<=> is always generated symmetrically and the compiler is allowed to swap the operands on a callsite. There is one case remaining where the hidden friend is beneficial:
#include <functional>

struct Good {
    friend auto operator<=>(const Good&, const Good&) = default;
};

struct Bad {
    auto operator<=>(const Bad&) const = default;
};

int main() {
    Good g;
    auto rg = std::ref(g);
    rg < g; // OK
    g < rg; // OK
    rg < rg;// OK

    Bad b;
    auto rb = std::ref(b);
    rb < b;   // OK
    b < rb;   // OK
    rb < rb;  // ill-formed
}

https://godbolt.org/z/5hE51hjd3
operator<=> cannot be resolved if there are wrapping objects on both sides of the operator. However, this is probably a very rare edge case. So you can choose freely whether to make operator<=> a member or a hidden friend on your slides!

I think the content is good now, thank you for taking the time to iterate on it! I wonder though whether all the code examples fit on the slides. I guess there is some more work needed.

Yes, there is still some work to review the examples and make them fit in the slide format. And I still wonder where to put some exercise. If no other instruction given, I will add yet another subdirectory in the /code bazaar ;)

Reformatting the examples. It takes 5 minutes or so of latex compiling after each modification I want to check visually... so painful !

I just realized that your new example is not built by the CI. Please add it to .github/workflow/builds.yaml.

Done, as far as I understand what should be done.

Hmm. Maybe I have messed up the job cancellation on pushing new commits. @chavid did you cancel the jobs?

No, all is good. The jobs were cancelled because your spaceship example failed:
The job was canceled because "spaceship_true_true_ubuntu-latest_-G__Unix_Makefiles_" failed.

No, all is good. The jobs were cancelled because your spaceship example failed: The job was canceled because "spaceship_true_true_ubuntu-latest_-G__Unix_Makefiles_" failed.

The new CMakeLists.txt is OK when I try it interactively (mkdir build, cd build, cmake .., make, ./spaceship). Something I did wrong when editing .github/workflow/builds.yaml ? I just added 3 lines in the "build matrix".

The gcc used in the CI does not support spaceship yet. I can fix that for you.

The gcc used in the CI does not support spaceship yet. I can fix that for you.

Fine. Go ahead :)


Added deleteAllSleep method (similar to deleteAllWorkout)

I just added a "new" method "deleteAllSleep" which is similar to "deleteAllWorkout". It works similarly (bcz it's almost a copy). Tested

LGTM


Update storage-concurrency.md

Reviewed disqus comments (none) and wastore comments and guide is still up to date.

Hi @jasonnewyork, I'm your friendly neighborhood Azure Pull Request Bot (You can call me AZPRBOT). Thanks for your contribution!

It looks like you're working at Microsoft (jahogg). If you're full-time, we DON'T require a contribution license agreement.

If you are a vendor, DO please sign the electronic contribution license agreement. It will take 2 minutes and there's no faxing! https://cla.azure.com.

TTYL, AZPRBOT;

@jasonnewyork Jason, please submit this update through the private repo

I thought I did? I added -pr to the name didn't I?
Sent from my Windows Phone

From: Jim<EMAIL_ADDRESS>Sent: 2/12/2016 3:46 PM
To<EMAIL_ADDRESS>Cc: Jason Hogg<EMAIL_ADDRESS>Subject: Re: [azure-content] Update storage-concurrency.md (#5614)
@jasonnewyork Jason, please submit this update through the private repo

Reply to this email directly or view it on GitHub:
https://github.com/Azure/azure-content/pull/5614#issuecomment-183531208

@jasonnewyork Jason, at the top of the PR you can see that it's in azure-content (the public repo).

Article updated in another PR. CLosing.


MenuItem ReadOnly Property type

When you try to change a menu items type, it won't let you... how do you?
Uncaught Exception:
TypeError: Cannot assign to read only property 'type' of [object Object]
    at /Users/bazfoo/Public/foobar/src/menu-builder.js:299:21
    at Array.map (native)
    at MenuBuilder.buildMenu (/Users/bazfoo/Public/foobar/src/menu-builder.js:296:15)
    at EventEmitter.<anonymous> (/Users/bazfoo/Public/foobar/src/index.js:56:8)
    at emitOne (events.js:82:20)
    at EventEmitter.emit (events.js:169:7)

Menu item's type can not be changed, you have to recreate one if you want to change its type.


[Request] ARM 32/64 support

Would be great to have ARM 32/64 bit builds, especially for Raspberry Pi devices.

Hi yes this would be good to have. I see that GitHub recently released arm runners for github actions which makes it a lot easier. Tauri has support for Arm so this should be as simple as adding it to the build pipeline. I dont have time to do this personally but anyone is welcome to give it a shot.

This would be a great way to create Raspberry Pi screen companion for music assistant.

I agree, looks like it is super simple to implement, Tauri (the framework used to build the companion app) has full support for arm, so really the only thing needed is to modify the GitHub action that builds the companion and probably add a squeezelite executable for Linux arm


Allow values in Pipfile to consume Environment Variables

Relying on os.path.expandvars() to inject environment variables in strings. Works on Windows, back-supports Python 2.7.
See https://github.com/pypa/pipenv/issues/1688
I'm not 100% sure that this is the correct place to do this injection.
Some thoughts:

The Pipfile hash should be determined after values have attempted to be inserted.
Pipfile shouldn't be intelligent by trying to differentiate env vars from regular characters—if an env var can't be inserted, the string should remain intact.
As it stands, Pipenv's vendor folder contains some version of this repository. I don't fully understand the reasons behind this, maybe we could pin it as a requirement instead? We could then separate tests.

Mirrored Pipfile PR: https://github.com/pypa/pipfile/pull/105

can you add a test that fails when an environment variable is not defined?

(looks like it doesn't error just doesn't expand  in python 3.6)
>>> os.path.expandvars('${A}')
'${A}'

This seems correct to me, would you expect it to throw an error?

On Mar 16, 2018, at 6:41 PM, Jeff Tratner<EMAIL_ADDRESS>wrote:
(looks like it doesn't error just doesn't expand in python 3.6)

os.path.expandvars('${A}')
'${A}'
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.

I'm concerned about something error about not connecting that turns out to be not being able to connect to<EMAIL_ADDRESS>or something like that.
Way nicer to error and say USERNAME not defined! :)
Also how does this impact hashing? Which parts of the pipfile are allowed to have env vars in them?

(but I'm def not BDFL here :) )

After some thought I don't think this is ready. Would appreciate some clarity here.
Some thoughts:

The Pipfile hash should not be affected by the values of the env vars, only the keys. This means the hash will have to be calculated before injection.
Disagree with @jtratner regarding raising errors: Pipfile shouldn't be intelligent by trying to differentiate env vars from regular characters—if an env var can't be inserted, the string should remain the same.
The reasons for having a vendor folder aren't clear to me if they haven't been patched: Why not just add Pipfile as a requirement?

@techalchemy - maybe only the sources section should allow env vars? And
then everywhere else it’s just interpreted literally? Or alternatively you
add another key that are the vars to substitute?
Generally, not sure where it would ever make sense to have $ as a name.
If hash is calculated before env var substitution then should it be
disallowed in the packages sections?
On Fri, Mar 16, 2018 at 9:12 PM Daniel van Flymen<EMAIL_ADDRESS>wrote:

After some thought I don't think this is ready. Would appreciate some
clarity here.
Some thoughts:

The Pipfile hash should not be affected by the values of the env
vars, only the keys. This means the hash will have to be calculated before
injection.
Disagree with @jtratner https://github.com/jtratner regarding
raising errors: Pipfile shouldn't be intelligent by trying to
differentiate env vars from regular characters—if an env var can't be
inserted, the string should remain the same.
The reasons for having a vendor folder aren't clear to me if they
haven't been patched: Why not just add Pipfile as a requirement?

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/pypa/pipenv/pull/1769#issuecomment-373892854, or mute
the thread
https://github.com/notifications/unsubscribe-auth/ABhjq1g38ED2ws8L-EwunnUpaS4Mc66Yks5tfI06gaJpZM4SuhjW
.

@techalchemy, I'm confused by your concern about package hashes. Maybe I'm missing something, but it would be weird if package hashes depended on the Pipfile itself.

Generally, not sure where it would ever make sense to have $ as a name.

It's bad to make assumptions about values: $ is an allowable character for an URL.

$ is an allowable character

Good point! Hmm...
On Fri, Mar 16, 2018 at 11:46 PM Daniel van Flymen<EMAIL_ADDRESS>wrote:

@techalchemy https://github.com/techalchemy, I'm confused by your
concern about package hashes. Maybe I'm missing something, but it would be
weird if package hashes depended on the Pipfile itself.
Generally, not sure where it would ever make sense to have $ as a name.
It's bad to make assumptions about values: $ is an allowable character
for an URL.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/pypa/pipenv/pull/1769#issuecomment-373898995, or mute
the thread
https://github.com/notifications/unsubscribe-auth/ABhjq7JH49jWrD7wIdBSw6Vu8NFWX-z5ks5tfLFJgaJpZM4SuhjW
.

Thanks for everyone's interest.
I'm taking the contributors' advice and opening https://github.com/pypa/pipfile/pull/105 instead.

@kennethreitz @jtratner @techalchemy do you guys mind taking a peek at https://github.com/pypa/pipfile/pull/105

We vendor things to isolate them from system dependencies. This is a common practice.

I'm re-opening after taking suggestions and making the mirrored Pipfile https://github.com/pypa/pipfile/pull/105

:cake:

Made some changes to this — primarily, env vars are not propogated to the pipfile.lock, as they are here. They are also expanded at runtime. We want to keep secrets out of source control.

It would be nice if we can have environment variables loaded throughout the entire Pipfile. E.g.
[dev-packages]
my-package = {path="${PATH_TO_REPO}", editable = true}


JAMES-1975 Extract Mailet code out of JDKIM

Combines with https://github.com/linagora/james-project/pull/722
Rebase of https://github.com/apache/james-jdkim/pull/5

What was missing to merge it ?

One more approuval.
And a CI build.

Merged in another PR


Remove bird as a calico backend for Azure

What this PR does / why we need it:
Azure does not support IPinIP and as a result Calico's Bird can not be used, this PR removes bird as a calico backend for Azure.
For more information: https://docs.projectcalico.org/v3.5/reference/public-cloud/azure
Calico is now only used for policies on Azure, Bird backend is removed.

What about
On Kubernetes, also complete the following.

    Ensure that the selected pod’s subnet is a part of your Azure virtual network IP range.

    Include the name of your routing table in the configuration file of your Kubernetes Azure cloud provider.

https://docs.projectcalico.org/v3.5/reference/public-cloud/azure#azure-user-defined-routes

@mvladev This seems to be a revert to the old networking solution which we had before we used Calico for Azure. The route table is still part of the terraform infra job for Azure and even the cloud provider config contains it. https://github.com/gardener/gardener/blob/74e0c8d9ce71101841e247eeca0d649703fad49b/pkg/operation/cloudbotanist/azurebotanist/controlplane.go#L24-L47

/lgtm

Thanks a lot for reacting to this so quickly.


Selectively Ignoring Object Arguments

Hi Erik,
Now that OCMock retains arguments passed to mocks, I’m unable to test dealloc logic for objects whose references are retained by mocks.
Is it possible to enable "legacy" behavior on a per-mock basis, such as adding a method on OCMockObject that skips retention ("noRetainObjectArgs") or releases arguments ("releaseObjectArgs")? Happy to contribute if either seems reasonable.
Thanks,
Alan

I understand the issue. However, this seems to be quite a niche use case and, at the same time, this would make some already complex logic inside OCMock even more complex and it would require changes to the API.
For your cases could you not just send a release to the objects in question from your test code? I know it feels "asymmetric" but it's also pragmatic.

In some cases I can nil the mocks in question, but not mocks that need to be verified. Explicitly releasing the objects under test is disallowed in ARC. That's where having the ability to release (or simply not retain) arguments would be useful.


How to generate Terminal skill icons SVG

First of all, I really love this project. Excellent work here!
My question is how can I generate another SVG like this one here:
https://github.com/SofiDevO/portfolio-sofidev-garrux/blob/main/public/assets/react.svg
For a skill that is not in the assets folder. Was Iconify used? I can't find that exact SVG in this project in Iconify.
Thank you!

@aelbialy
You can follow this tutorial:
https://www.youtube.com/watch?v=fB8OraROTwk

Thank you so much @SofiDevO

@aelbialy I made the library of icons used there. Here is the link https://github.com/Garruxx/ascii-icons

Thank you so much @Garruxx I'll check it out too.


[CI][C++][Python] Verification jobs fail on ubuntu for Python due to missing libzstd

Describe the bug, including details regarding any error messages, version, and platform.
Verification jobs for Python on Ubuntu 20.04 and 22.04 due to zstd not found:
verify-rc-source-python-linux-ubuntu-20.04-amd64
verify-rc-source-python-linux-ubuntu-22.04-amd64
CMake Warning at /tmp/arrow-HEAD.xCuHo/install/lib/cmake/Gandiva/FindzstdAlt.cmake:29 (find_package):
  By not providing "Findzstd.cmake" in CMAKE_MODULE_PATH this project has
  asked CMake to find a package configuration file provided by "zstd", but
  CMake did not find one.

  Could not find a package configuration file provided by "zstd" with any of
  the following names:

    zstdConfig.cmake
    zstd-config.cmake

  Add the installation prefix of "zstd" to CMAKE_PREFIX_PATH or set
  "zstd_DIR" to a directory containing one of the above files.  If "zstd"
  provides a separate development package or SDK, be sure it has been
  installed.
Call Stack (most recent call first):
  /usr/share/cmake-3.16/Modules/CMakeFindDependencyMacro.cmake:47 (find_package)
  /tmp/arrow-HEAD.xCuHo/install/lib/cmake/Gandiva/GandivaConfig.cmake:64 (find_dependency)
  CMakeLists.txt:679 (find_package)

-- Checking for module 'libzstd'
--   No package 'libzstd' found
CMake Error at /usr/share/cmake-3.16/Modules/FindPackageHandleStandardArgs.cmake:146 (message):
  Could NOT find zstdAlt (missing: ZSTD_LIB ZSTD_INCLUDE_DIR)
Call Stack (most recent call first):
  /usr/share/cmake-3.16/Modules/FindPackageHandleStandardArgs.cmake:393 (_FPHSA_FAILURE_MESSAGE)
  /tmp/arrow-HEAD.xCuHo/install/lib/cmake/Gandiva/FindzstdAlt.cmake:124 (find_package_handle_standard_args)
  /usr/share/cmake-3.16/Modules/CMakeFindDependencyMacro.cmake:47 (find_package)
  /tmp/arrow-HEAD.xCuHo/install/lib/cmake/Gandiva/GandivaConfig.cmake:64 (find_dependency)
  CMakeLists.txt:679 (find_package)

-- Configuring incomplete, errors occurred!
See also "/arrow/python/build/temp.linux-x86_64-cpython-38/CMakeFiles/CMakeOutput.log".
See also "/arrow/python/build/temp.linux-x86_64-cpython-38/CMakeFiles/CMakeError.log".
error: command '/usr/bin/cmake' failed with exit code 1
Failed to verify release candidate. See /tmp/arrow-HEAD.xCuHo for details.

It started failing since this PR was merged which seems could be related:
https://github.com/apache/arrow/pull/35023
Those are the commits since the first failure:
https://github.com/apache/arrow/compare/61203456ed33268df0c8c164348a203c7c1be8ca...6432a2382e870633e5060b5e6ea481f28ca0c725
This should be fixed for 12.0.0 as this commit was the last one introduced before the feature freeze.
Component(s)
C++, Continuous Integration

I have no idea what is happening but could be something to do with GandivaConfig.cmake.in temporary modifying CMAKE_PREFIX_PATH?
if(DEFINED CMAKE_MODULE_PATH)
  set(GANDIVA_CMAKE_MODULE_PATH_OLD ${CMAKE_MODULE_PATH})
else()
  unset(GANDIVA_CMAKE_MODULE_PATH_OLD)
endif()
set(CMAKE_MODULE_PATH "${CMAKE_CURRENT_LIST_DIR}")

@kou any idea?

Oh, sorry...
I'll take a look at this.


Certificate expired for https://vfsforgit.org/

It seems like the certificate for HTTPS has expired
Expired: Thursday, November 26, 2020 at 15:54:14 Central European Standard Time

Could somebody on MSFT side replace this?

I think we looked into this recently, but no one really owns this web page anymore. Thoughts, @vtbassmatt?

@ethomson took care of it I think.

From my side
> echo | openssl s_client -servername vfsforgit.org -connect vfsforgit.org:443 | openssl x509 -noout -dates
depth=2 C = IE, O = Baltimore, OU = CyberTrust, CN = Baltimore CyberTrust Root
verify return:1
depth=1 C = US, ST = Washington, L = Redmond, O = Microsoft Corporation, OU = Microsoft IT, CN = Microsoft IT TLS CA 5
verify return:1
depth=0 CN = vfsforgit.org
verify error:num=10:certificate has expired
notAfter=Nov 26 14:54:14 2020 GMT
verify return:1
depth=0 CN = vfsforgit.org
notAfter=Nov 26 14:54:14 2020 GMT
verify return:1
DONE
notBefore=Nov 26 14:54:14 2018 GMT
notAfter=Nov 26 14:54:14 2020 GMT

Sorry, what I mean was he took care of it last time. Since this is no longer his area of ownership, I'm having the domains and cert privileges transferred to myself. It may take a bit of time - we have to work through multiple systems. Thanks for reporting this!

This issue isn't forgotten. I need manager approval to issue the certificate, and the interface to let my manager do so is giving us a lot of trouble ☹

Our site team was finally able to break the logjam on this. So sorry it took this long to fix 😞


Update dependency opentelemetry-sdk to v1.27.0

This PR contains the following updates:

Package
Update
Change

opentelemetry-sdk
minor
==1.26.0 -> ==1.27.0

Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Enabled.
♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.

[ ] If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

Edited/Blocked Notification
Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.
You can manually request rebase by checking the rebase/retry box above.
⚠ Warning: custom changes will be lost.


mmark: 2.2.26 -> 2.2.28

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/mmarkdown/mmark/releases.
meta.description for mmark is: "A powerful markdown processor in Go geared towards the IETF"
meta.homepage for mmark is: "https://github.com/mmarkdown/mmark"
meta.changelog for mmark is: ""
Updates performed

Golang update

To inspect upstream changes

Compare changes on GitHub

Impact

Checks done (click to expand)

built on NixOS
The tests defined in passthru.tests, if any, passed
found 2.2.27 with grep in /nix/store/dwk37ix0mif9h6v5hrsgwc5vl61zm3s6-mmark-2.2.27
found 2.2.27 in filename of file in /nix/store/dwk37ix0mif9h6v5hrsgwc5vl61zm3s6-mmark-2.2.27

Rebuild report (if merged into master) (click to expand)

1 total rebuild path(s)

1 package rebuild(s)

First fifty rebuilds by attrpath
mmark

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/dwk37ix0mif9h6v5hrsgwc5vl61zm3s6-mmark-2.2.27 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A mmark https://github.com/r-ryantm/nixpkgs/archive/1a8de07016b3d2adba9ea8c38c321a27b85b1316.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/dwk37ix0mif9h6v5hrsgwc5vl61zm3s6-mmark-2.2.27
ls -la /nix/store/dwk37ix0mif9h6v5hrsgwc5vl61zm3s6-mmark-2.2.27/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

1 package built:

mmark

Maintainer pings
cc @yrashk for testing.

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/mmarkdown/mmark/releases.
meta.description for mmark is: "A powerful markdown processor in Go geared towards the IETF"
meta.homepage for mmark is: "https://github.com/mmarkdown/mmark"
meta.changelog for mmark is: ""
Updates performed

Golang update

To inspect upstream changes

Compare changes on GitHub

Impact

Checks done (click to expand)

built on NixOS
The tests defined in passthru.tests, if any, passed
found 2.2.28 with grep in /nix/store/8mwrzs3np0caxrkkf3cy7ifm5pvljf2j-mmark-2.2.28
found 2.2.28 in filename of file in /nix/store/8mwrzs3np0caxrkkf3cy7ifm5pvljf2j-mmark-2.2.28

Rebuild report (if merged into master) (click to expand)

1 total rebuild path(s)

1 package rebuild(s)

First fifty rebuilds by attrpath
mmark

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/8mwrzs3np0caxrkkf3cy7ifm5pvljf2j-mmark-2.2.28 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A mmark https://github.com/r-ryantm/nixpkgs/archive/bafce1c7cdaed1af39b804a660aa3ce6307886af.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/8mwrzs3np0caxrkkf3cy7ifm5pvljf2j-mmark-2.2.28
ls -la /nix/store/8mwrzs3np0caxrkkf3cy7ifm5pvljf2j-mmark-2.2.28/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

1 package built:

mmark

Maintainer pings
cc @yrashk for testing.

Result of nixpkgs-review pr 188873 run on x86_64-linux 1

1 package built:

mmark


new Google sign-in page

The new Google sign-in page shows up on computers, phones, and tablets.
Now when you try login from evilginx still waiting for something ...
This morning still work, now .. no :/
I will check late if change  are required on nginx config, for example on the proxy_pass

Thank's

Thanks for letting me know. Will be able to take a look in couple of days.
On 2 May 2017 14:55, "myfoxx"<EMAIL_ADDRESS>wrote:

The new Google sign-in page shows up on computers, phones, and tablets.
Now when you try login from evilginx still waiting for something ...
This morning still work, now .. no :/
I will check late if change are required on nginx config, for example on
the proxy_pass
[image: screen shot 2017-05-02 at 14 49 40]
https://cloud.githubusercontent.com/assets/4947022/25618295/b4457f82-2f46-11e7-8b92-fb7a56e2c105.png
Thank's
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/kgretzky/evilginx/issues/15, or mute the thread
https://github.com/notifications/unsubscribe-auth/ASXmJ8He_8NbgLs2e2g_hM9-QyUtdr_jks5r1yeqgaJpZM4NOGk-
.

I've checked with Evilginx 1.0 and everything works as expected.
Are you using the updated version or the first public release from 3 weeks ago?

Thank's for the support. The version is the last, as u told me.
Now works as expected.
I have ricreate a new nginx profile.
Great job !!!


[Not for merge] Branch of #1489

This is a branch off of #1489 that makes the tests pass by moving the TYPE_CHECKING blocked imports. It is not made in #1489 itself because I have not 100% decided how I want to handle this, since there could be further updates in the upstream Prefect PR that I'm waiting to get merged.
Note: While the tests pass, there is one additional quality-of-life change that will eventually be needed. As noted in #1489, it would be nice to have the @subflow decorator automatically do a gather-type operation like in Dask.

Closing in favor of #1489, which resolves the import problem via https://github.com/PrefectHQ/prefect/pull/11616.