EVP_MD lost 'type' filed if built with no-autoalginit

Hi All,
To reduce the size of the generated binary as possible, I tried to build openssl with 'no-autoalginit' and manually added the required digest.
The strange thing is that the value of 'type' will be lost when using EVP_MD_fetch() to retrieve EVP_MD after EVP_add_digest(). Automatic initialization algorithm (without 'no-autoalginit') does not have this problem.
Any hints about it?  More details and configure as below, thanks.

build with  'no-autoalginit' and:
EVP_add_digest (EVP_sha256 ());
TestMD = EVP_MD_fetch (NULL, "sha256", NULL);

without  'no-autoalginit':

Whole configure list:
"no-afalgeng",
"no-aria",
"no-async",
"no-autoalginit",
"no-autoerrinit",
"no-autoload-config",
"no-bf",
"no-blake2",
"no-camellia",
"no-capieng",
"no-cast",
"no-chacha",
"no-cmac",
"no-cmp",
"no-cms",
"no-ct",
"no-deprecated",
"no-des",
"no-dgram",
"no-dsa",
"no-dso",
"no-dynamic-engine",
"no-ec2m",
"no-engine",
"no-err",
"no-filenames",
"no-gost",
"no-hw",
"no-idea",
"no-makedepend",
"no-module",
"no-md4",
"no-mdc2",
"no-pic",
"no-ocb",
"no-ocsp",
"no-padlockeng",
"no-poly1305",
"no-posix-io",
"no-rc2",
"no-rc4",
"no-rc5",
"no-rfc3779",
"no-rmd160",
"no-scrypt",
"no-seed",
"no-shared",
"no-siphash",
"no-siv",
"no-sm4",
"no-sock",
"no-srp",
"no-srtp",
"no-sse2",
"no-ssl",
"no-ssl3-method",
"no-ssl-trace",
"no-static-engine",
"no-stdio",
"no-threads",
"no-ts",
"no-ui",
"no-whirlpool",
"disable-legacy",
# OpenSSL1_1_1b doesn't support default rand-seed-os for UEFI
# UEFI only support --with-rand-seed=none
"--with-rand-seed=none",
"--api=1.1.1"

Without automatically loading algorithms, the types will be allocated starting from zero instead of being pre-allocated.  This is a function of how providers operate -- new algorithms get integer indices starting from zero.
I can't imagine that it will cause problems, but I've never tried.

Without automatically loading algorithms, the types will be allocated starting from zero instead of being pre-allocated. This is a function of how providers operate -- new algorithms get integer indices starting from zero.
I can't imagine that it will cause problems, but I've never tried it.

Hi, thanks for quick feedback.
This problem causes PKCS7_sign() to fail because this function uses EVP_MD_fetch() to get EVP_MD* and then retrieves EVP_MD* based on 'type' filed, I guess this filed should be NID and be fixed?

fetch call stack:
EVP_MD_fetch(ossl_lib_ctx_st * ctx, const char * algorithm, const char * properties) Line 1071 (openssl\crypto\evp\digest.c:1071)
pkcs7_bio_add_digest(bio_st * * pbio, X509_algor_st * alg, const PKCS7_CTX_st * ctx) Line 73 (openssl\crypto\pkcs7\pk7_doit.c:73)
PKCS7_dataInit(pkcs7_st * p7, bio_st * bio) Line 282 (openssl\crypto\pkcs7\pk7_doit.c:282)
PKCS7_final(pkcs7_st * p7, bio_st * data, int flags) Line 79 (openssl\crypto\pkcs7\pk7_smime.c:79)
PKCS7_sign_ex(x509_st * signcert, evp_pkey_st * pkey, stack_st_X509 * certs, bio_st * data, int flags, ossl_lib_ctx_st * libctx, const char * propq) Line 59 (openssl\crypto\pkcs7\pk7_smime.c:59)
PKCS7_sign(x509_st * signcert, evp_pkey_st * pkey, stack_st_X509 * certs, bio_st * data, int flags) Line 71

find call stack:
EVP_MD_get_type(const evp_md_st * mVd) Line 786 (openssl\crypto\evp\evp_lib.c:786)
PKCS7_find_digest(evp_md_ctx_st * * pmd, bio_st * bio, int nid) Line 682 (openssl\crypto\pkcs7\pk7_doit.c:682)
PKCS7_dataFinal(pkcs7_st * p7, bio_st * bio) Line 817 (openssl\crypto\pkcs7\pk7_doit.c:817)
PKCS7_final(pkcs7_st * p7, bio_st * data, int flags) Line 89 (openssl\crypto\pkcs7\pk7_smime.c:89)
PKCS7_sign_ex(x509_st * signcert, evp_pkey_st * pkey, stack_st_X509 * certs, bio_st * data, int flags, ossl_lib_ctx_st * libctx, const char * propq) Line 59 (openssl\crypto\pkcs7\pk7_smime.c:59)
PKCS7_sign(x509_st * signcert, evp_pkey_st * pkey, stack_st_X509 * certs, bio_st * data, int flags) Line 71 (openssl\crypto\pkcs7\pk7_smime.c:71)

The earlier answers aren't quite right.
Fetched algorithms aren't guaranteed to have an associated OBJ or NID, because provider based implementation aren't designed for it.  We do place the NID into the type field if there is a registered legacy implementation as well.
Unfortunately, there are a few subsystems that weren't fully upgraded to deal with a provider world.  PKCS#7 and CMS are among those, there's definitely a bit of work to do there.

@levitte, create an issue for this perhaps?

There is a collection of issues to raise, and that'll be quite a write-up.  I actually thought I already had raised this before we released 3.0.0...  but maybe that got lost.

There is a collection of issues to raise, and that'll be quite a write-up. I actually thought I already had raised this before we released 3.0.0... but maybe that got lost.

It would be nice to know the root cause. Thanks, I closed my PR and look forward to your issues.

There is a collection of issues to raise, and that'll be quite a write-up. I actually thought I already had raised this before we released 3.0.0... but maybe that got lost.

Hi @levitte , any update here, do we have new issue about this bug?

Sorry for the delay, I've had a few other and higher priority things on my table, and they still preoccupy me.  But, I do plan on taking on the bigger issue (lack of provider support in some sections of libcrypto) next (that's still a week or so away, mind you)

Sorry for the delay, I've had a few other and higher priority things on my table, and they still preoccupy me. But, I do plan on taking on the bigger issue (lack of provider support in some sections of libcrypto) next (that's still a week or so away, mind you)

Oh i see, thank you!

This bug impacts PEM_write_bio_PrivateKey as well if the enc field has a non-NULL algorithm defined.
PKCS5_pbe2_set_iv_ex():
if (alg_nid == NID_undef) { ...

++visibility
Hello, any update here?

This issue impacts EDK2 http boot (based on openssl TLS/SSL implementation) as well, but I don't have root cause it yet..


Live

Docs Build status updates of commit c98dece:
:white_check_mark: Validation status: passed
For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


added google chrome dino game

PR Description 📜
i have coded this dino game before , now i'm glad to add this game to this gamezone ,this is chrome sino game with scores
Fixes #3543

Mark the task you have completed ✅

[x] I follow CONTRIBUTING GUIDELINE & CODE OF CONDUCT of this project.
[x] I have performed a self-review of my own code or work.
[x] I have commented my code, particularly in hard-to-understand areas.
[x] My changes generates no new warnings.
[x] I have followed proper naming convention showed in CONTRIBUTING GUIDELINE
[x] I have added screenshot for website preview in assets/images
[x] I have added entries for my game in main README.md
[x] I have added README.md in my folder
[ ]  I have added working video of the game in README.md (optional)
[x] I have specified the respective issue number for which I have requested the new game.

Add your screenshots(Optional) 📸

Thank you soo much for contributing to our repository 💗

Thank you @Yashgabani845 ,for creating the PR and contributing to our GameZone 💗
Review team will review the PR and will reach out to you soon! 😇
Make sure that you have marked all the tasks that you are done with ✅.
Thank you for your patience! 😀

@Yashgabani845 resolve the merge conflicts !

resolved

Thank you  @Yashgabani845 , for your valuable time and contribution in our GameZone 💗.
It’s our GameZone, so Let’s build this GameZone altogether !!🤝
Hoping to see you soon with another PR again 😇
Wishing you all the best for your journey into Open Source🚀

/assign


Feature request: make .schema to accept objects that respond to #schema

I have the following two validators:
class AddressValidator
  include Hanami::Validations

  validations do
    required(:city).filled
  end
end

class CustomerValidator
  include Hanami::Validations

  validations do
    required(:name).filled
    required(:address).schema(AddressValidator.schema)
  end
end

It would be neat to have the following syntax instead:
    required(:address).schema(AddressValidator)

Can .schema check if the given object respond to #schema and eventually use it? Thanks!

Seems reasonable to me, marking as help wanted but will try and get to it soon if nobody picks it up

@jodosha @AMHOL I think my pull request provides a solution to the problem you want to address. Take a look and I'm open to any feedback.

@jodosha @AMHOL it appears that this pull request has been merged so this issue could be closed.

@jodosha I can verify that this is working in our application. https://github.com/ndlib/sipity/blob/99cfed77182444eda4ba680b21f52e9ef6a65928/app/data_generators/sipity/data_generators/submission_window_schema.rb#L14-L15

Thanks @ttdonovan @jeremyf


384 contract types generation tests

Added tests for operations for the contract types plugin

Actually, there's 11 example contracts now. Looks like he added one for the case with the complex pair Claude found

These tests lgtm
Question: Looking at the unit tests for the plugin, I see in generator.spec.ts, that only example contracts 1-4 are included, and there are 10 in the /taqueria-plugin-contract-types/example/contracts directory
I remember Rick saying those were all for test purposes (and something we will need to maintain after protocol changes) and I'm not sure if 5-10 were left out intentionally, or if they should be added to maximize coverage

@ricklove,  can you provide any information?


[BEAM-9433] Create expansion service artifact for common Java IOs.

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Choose reviewer(s) and mention them in a comment (R: @username).
[ ] Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
[ ] Update CHANGES.md with noteworthy changes.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.


Discovered something interesting

If you're using your main GitHub repo, e.g. example.github.io for this project with a CNAME setup for a custom domain then you don't need to do the CloudFlare worker proxy re-route. You can just set name = "." and it will deploy the code to the root directory which is then available directly at your root domain example.github.io (example.com with CNAME setup). Pretty neat!

GitHub Pages Custom domain
The domain name set by “GitHub Pages Custom domain” can only be accessed using yourdomain.com/blog, and the domain name set by Cloudflare can be accessed using yourdomain.com without the file address behind.

GitHub Pages Custom domain
The domain name set by “GitHub Pages Custom domain” can only be accessed using yourdomain.com/blog, and the domain name set by Cloudflare can be accessed using yourdomain.com without the file address behind.

That's not entirely correct. I named my repository mabdullahabid.github.io instead of blog so it's available at the root domain instead of /blog. Then I used a custom domain without CloudFlare workers to just display traffic at mabdullahabid.com

That's not entirely correct. I named my repository mabdullahabid.github.io instead of blog so it's available at the root domain instead of /blog. Then I used a custom domain without CloudFlare workers to just display traffic at mabdullahabid.com

Yes I know, I think this setting is the default GitHub setting and should be known to everyone. That's why it's not written in the README

Yes I know, I think this setting is the default GitHub setting and should be known to everyone. That's why it's not written in the README

Ah okay. Thanks for this. I thought we had to use the worker in order to get the blog at the root domain. Anyways, this is an amazing project. Thanks for this!
Btw, were you able to solve the Safari design issues?

Ah okay. Thanks for this. I thought we had to use the worker in order to get the blog at the root domain. Anyways, this is an amazing project. Thanks for this!
Btw, were you able to solve the Safari design issues?

Thanks for the reminder, I will write the hint that the default use of GitHub Pages dedicated projects can be simply configured with a domain name to the README.
The Safari display issue needs to be fixed by the core project author. I can't do anything about it.

Thanks for the reminder, I will write the hint that the default use of GitHub Pages dedicated projects can be simply configured with a domain name to the README.
The Safari display issue needs to be fixed by the core project author. I can't do anything about it.


What needs to be in lightning config?

Coffee is now working, but when I start lightningd I get this error:
 lightningd
2024-05-15T11:45:44.292Z INFO    lightningd: v24.02.2
error starting plugin '/home/alice/.coffee/bitcoin/plugins/folgore/target/release/folgore_plugin': option name 'bitcoin-rpcpassword' is already taken
Exception ignored in: <_io.TextIOWrapper name='<stdout>' mode='w' encoding='utf-8'>
BrokenPipeError: [Errno 32] Broken pipe

What exactly should be in my lightning config?
I commented all the bitcoin-* related lines and added bitcoin-client=nakamoto
so it looks something like this:
bitcoin-client=nakamoto

#bitcoin-rpcconnect=...
#bitcoin-rpcport=...
#bitcoin-rpcuser=...
#bitcoin-rpcpassword=...
#bitcoin-cli=...

Did you try https://github.com/coffee-tools/folgore?tab=readme-ov-file#how-to-configure ?

Ah no your problem is https://github.com/coffee-tools/folgore/issues/83
Closing as a duplicated because I think the error will be the same

Ah this is duplicate, sorry: https://github.com/coffee-tools/folgore/issues/83
disable-plugin=bcli in lightning config solves this issue.

Nice :)


Write a Java program to print multiplication table

Description
Write a Java program to print multiplication table
Input  : 2

2 x 1 = 2
2 x 2 = 4
2 x 3 = 6
2 x 4 = 8
2 x 5 = 10
2 x 6 = 12
2 x 7 = 14
2 x 8 = 16
2 x 9 = 18
2 x 10 = 20

How to contribute

Save the solution in PrintMultiplicationTable.java file
Add PrintMultiplicationTable.java file in print-multiplication-table folder

!assign


expectPrivate invoking the actual private method rather than mocking it

From<EMAIL_ADDRESS>on June 11, 2009 12:32:19
If  i test a public method that contains some private methods in it, then
when i try to mock the private methods using expectPrivate, the private
method gets invoked rather than mocking it. What is the expected output? What do you see instead? on mocking should not go to the method that is mocked but simualate it. What version of the product are you using? On what operating system? 1.2.6 Please provide any additional information below.
Original issue: http://code.google.com/p/powermock/issues/detail?id=116

From<EMAIL_ADDRESS>on June 11, 2009 03:41:42
I think you've either forgot to prepare the class for test or forgot to create a
mock. There are numerous examples in the SVN. Please register and use the
mailing-list<EMAIL_ADDRESS>so that we can continue to discussion there.

From<EMAIL_ADDRESS>on July 02, 2009 06:34:12
Status: Invalid


API To new for Azure Devops Server 2019

Hello Hannes, thank you for enabling on premisis installations! Unfortunately it seems that theAzure API used by your plugin is fairly recent and not supported by our server (on Premisis is apparently always lagging behind the cloud). I am not an Admin, but at out company we use Azure Devops "Dev17.M153.5" which I believe to be the 2019 Server. Eitherway after your Plugin was installed It signals an error and the response comes back with the following. Although I am not an expert, do you think you could easily downgrade this (my hope would be that changing the version of the azure dev library that you use would be enough.
{$id: "1", innerException: null,…}
$id: "1"
errorCode: 0
eventId: 3000
innerException: null
message: "The requested REST API version of 5.2 is out of range for this server. The latest REST API version this server supports is 5.1."
typeKey: "VssVersionOutOfRangeException"
typeName: "Microsoft.VisualStudio.Services.WebApi.VssVersionOutOfRangeException, Microsoft.VisualStudio.Services.WebApi"

You're right. Microsoft's documentation is terrible for extensions. I set demands to api-version/3.0, its actually api-version/5.2 at runtime. When I have time, I'll find a solution.

5.1 should now be used instead, please verify it now works as of 1.2.8.

Is there a way to run Azure DevOps Server locally? I will explore, it might be a build / caching issue that contributed to 5.2 still being used.

Fingers crossed it actually references 1.153.2 now in 1.2.9.

Is there a way to run Azure DevOps Server locally?

I am afraid it is costly (https://azure.microsoft.com/en-us/pricing/details/devops/server/), I do not know the details, as I am an employee that is using it for development (I do not work in the IT-Infrastructure-Department). Not sure if that is what your question aimed at.

I will explore, it might be a build / caching issue that contributed to 5.2 still being referenced.
Edit: Looks like I forgot to regenerate a yarn.lock file, will attempt again and push 1.2.9.

I requested an update and will get back to you as soon as it is installed and tested. (Now with the company's IT-Infrastructure department)

Hello Hannes,
thanks for your help with this, it did the trick, The tabs now load in Azure DevOps Server2019.
Thank you, for your support


Remove source alias

Per today's  dev call and @bkueng https://github.com/PX4/Firmware/pull/15139#discussion_r487719343
Use source for . and a prefix of ${R} set to / for nuttx and ${pwd} for linux

ehh
Now we get
etc/init.d-posix/rcS: 81: /home/david_s5/src/PX4/repos/mainline/Firmware/build/px4_sitl_default/tmp/rootfs/etc/init.d/rc.vehicle_setup: source: not found
etc/init.d-posix/rcS: 84: /home/david_s5/src/PX4/repos/mainline/Firmware/build/px4_sitl_default/tmp/rootfs/etc/init.d/rc.vehicle_setup: source: not found

NuttX is respecting . or source.
From what I can tell googling "In the POSIX standard, which /bin/sh is supposed to respect, the command is . (a single dot), not source"
Any Ideas?

That works as well in SITL: https://github.com/PX4/Firmware/compare/pr-source-alternative-test

And on Nuttx set sh . if that works.

Not sure where to adjust it for NuttX

@MaEtUgR @bkueng - thank you for testing and the suggestions.

That works as well in SITL: https://github.com/PX4/Firmware/compare/pr-source-alternative-test

And on Nuttx set sh . if that works.

Not sure where to adjust it for NuttX

Given the the POSIX comments, I have gone back to using '.' everywhere with
NuttX: R=/
Linux R="`pwd`/"
I am in favor of this because it shows the correct intent: "sourc-ing" ans "exec-ing" are not the same.
sh path_to_script - launch a process running path_to_script which can not change parent environment.
.  path_to_script and source path_to_script include the path_to_script which can change parent environment.
Let's  see what breaks now :)
We should be able to dump the sh alias as well. But I will wait for your testing

I did another test. Works great on arch

We should be able to dump the sh alias as well. But I will wait for your testing

I also tried removing it in the SITL aliases and didn't see any error.
Output

[0/1] Re-running CMake...
-- PX4 version: v1.11.0-rc3-488-g891c6e24b1
-- PX4 config file: /home/maetugr/Firmware/boards/px4/sitl/default.cmake
-- PX4 config: px4_sitl_default
-- PX4 platform: posix
-- PX4 lockstep: enabled
-- cmake build type: RelWithDebInfo
-- Building for code coverage
-- ccache enabled (export CCACHE_DISABLE=1 to disable)
-- build type is RelWithDebInfo
-- PX4 ECL: Very lightweight Estimation & Control Library v1.9.0-rc1-456-gf666ebb
-- ROMFS: px4fmu_common
-- Configuring done
-- Generating done
-- Build files have been written to: /home/maetugr/Firmware/build/px4_sitl_default
[0/1] cd /home/maetugr/Firmware/build/px4_sitl_default/tmp && /home/maetugr/Firmware/Tools/sitl_run.sh /home/maetugr/Firmware/build/px4_sitl_default/bin/px4 none jmavsim none none /home/maetugr/Firmware /home/maetugr/Firmware/build/px4_sitl_default
SITL ARGS
sitl_bin: /home/maetugr/Firmware/build/px4_sitl_default/bin/px4
debugger: none
program: jmavsim
model: none
world: none
src_path: /home/maetugr/Firmware
build_path: /home/maetugr/Firmware/build/px4_sitl_default
empty model, setting iris as default
SITL COMMAND: "/home/maetugr/Firmware/build/px4_sitl_default/bin/px4" "/home/maetugr/Firmware/build/px4_sitl_default"/etc -s etc/init.d-posix/rcS -t "/home/maetugr/Firmware"/test_data
INFO  [px4] Creating symlink /home/maetugr/Firmware/build/px4_sitl_default/etc -> /home/maetugr/Firmware/build/px4_sitl_default/tmp/rootfs/etc

______  __   __    ___
| ___ \ \ \ / /   /   |
| |_/ /  \ V /   / /| |
|  __/   /   \  / /_| |
| |     / /^\ \ \___  |
\_|     \/   \/     |_/

px4 starting.

INFO  [px4] Calling startup script: /bin/sh etc/init.d-posix/rcS 0
Info: found model autostart file as SYS_AUTOSTART=10016
INFO  [param] selected parameter default file eeprom/parameters_10016
[param] Loaded: eeprom/parameters_10016
INFO  [dataman] Unknown restart, data manager file './dataman' size is 11798680 bytes
INFO  [simulator] Waiting for simulator to accept connection on TCP port 4560
Buildfile: /home/maetugr/Firmware/Tools/jMAVSim/build.xml

make_dirs:

compile:

create_run_jar:

copy_res:

BUILD SUCCESSFUL
Total time: 0 seconds
Options parsed, starting Sim.
Starting GUI...
INFO  [simulator] Simulator connected on TCP port 4560.
Init MAVLink
INFO  [commander] LED: open /dev/led0 failed (22)
INFO  [init] Mixer: etc/mixers/quad_w.main.mix on /dev/pwm_output0
INFO  [mavlink] mode: Normal, data rate: 4000000 B/s on udp port 18570 remote port 14550
INFO  [mavlink] mode: Onboard, data rate: 4000000 B/s on udp port 14580 remote port 14540
INFO  [mavlink] mode: Onboard, data rate: 4000 B/s on udp port 14280 remote port 14030
INFO  [logger] logger started (mode=all)
INFO  [logger] Start file log (type: full)
INFO  [logger] [logger] ./log/2020-10-15/14_08_09.ulg
INFO  [logger] Opened full log file: ./log/2020-10-15/14_08_09.ulg
INFO  [mavlink] MAVLink only on localhost (set param MAV_BROADCAST = 1 to enable network)
INFO  [px4] Startup script returned successfully
pxh> INFO  [mavlink] partner IP: <IP_ADDRESS>
INFO  [ecl/EKF] 2564000: reset position to last known position
INFO  [ecl/EKF] 2564000: reset velocity to zero
INFO  [ecl/EKF] 8664000: EKF aligned, (baro hgt, IMU buf: 18, OBS buf: 14)
INFO  [ecl/EKF] 9884000: GPS checks passed

pxh>
pxh>
pxh> commINFO  [ecl/EKF] 14416000: reset position to GPS
INFO  [ecl/EKF] 14416000: reset velocity to GPS
INFO  [ecl/EKF] 14416000: starting GPS fusion
pxh> commanderINFO  [tone_alarm] home set
ERROR [tone_alarm] notify negative
pxh> commander takeoff
pxh> INFO  [commander] Armed by internal command
INFO  [navigator] Using minimum takeoff altitude: 2.50 m
INFO  [commander] Takeoff detected

PX4 Exiting...
pxh> Exiting NOW.
ninja: build stopped: interrupted by user.
make: *** [Makefile:226: px4_sitl] Interrupt

We should be able to dump the sh alias as well. But I will wait for your testing

I also tried removing it in the SITL aliases and didn't see any err

@MaEtUgR - OK removed the sh alias as well.
@dagar once this passes CI it should be ready to merge.

SITL works as expected now on Arch and Cygwin. Thanks! NuttX fix on Cygwin still pending. I'll have another look at it.


Dealing with dependabot prefixes

@dangoslen I really like this github action, I have been looking at this for a while to save time when reviewing dependency updates! Thank you for it.
However in my projects I use semantic versioning and typical commit prefixes are chore: ..., fix: .... As a result by default dependabot adds an additional prefix to its commit messages, such as:
chore(deps): Bump requests from 2.28.1 to 2.31.0 in /requirements
Unfortunately it does not seem possible to completely disable the dependabot prefix to remove the chore(deps):  part. We can modify it but not set it empty.
Considering that your action is only able to identify the prefix based on a single word, what would you recommend?

Hi @tartieret.
Thanks for your interest here! From what I understand, it sounds like we should expand the capability of the Helper to accommodate your use case. I'd imagine the best path would be to update the regex that extracts the package data.
If you are up for a PR I'd be happy to review!

@tartieret I gave this a quick look actually and I think (if I understand your problem correctly) that a small tweak to the regex should accommodate what you are looking for. Give the linked PR a look!

This was completed in #182 and was release in v3.4.0


(feat): Add codespaces/devpod support

Adds support to be able to run idpbuilder on cloud dev environment

I had to remove forwardPorts from devcontainers.json as this prevented exposing port 8843 in localhost, it wanted only to expose to .github.dev host name. forwardPorts only worked for devpod.
User in both cases need to go to "ports" in the local vscode/ide and go to Ports and add forward port 8443 to <IP_ADDRESS>
User will also need to add the /etc/hosts entry locally in laptop/workstation
<IP_ADDRESS> argocd.cnoe.localtest.me
<IP_ADDRESS> backstage.cnoe.localtest.me
<IP_ADDRESS> gitea.cnoe.localtest.me
<IP_ADDRESS> argo.cnoe.localtest.me
<IP_ADDRESS> keycloak.cnoe.localtest.me

and any other hostname handle by nginx ingress

Some things I've noticed about trying to get it working in codespaces:

Codespaces creates a public proxy endpoint for processes running in codespaces. This is considered proxy dodging and very likely gets blocked by security software managed by organizations on local machines.
Because of above, ingress-nginx cannot route based on host names. For example, when I port-forward 8443, it creates an endpoint looking something like https://random-name-8443.app.github.dev.  To access the port 8443 on codespace, we must use this url.  This means we must use path based routing in our ingress instead of hostname based routing. e.g. instead of using argocd.localtest.me, do random-name-8443.app.github.dev/argocd.
This means we need to configure argocd to append /argocd to its root path. Otherwise, the client can't fetch resources from ArgoCD.

So if we want to get this to work in Codespaces flawlessly, we need to configure our core packages for this purpose specifically.

User will also need to add the /etc/hosts entry locally in laptop/workstation
<IP_ADDRESS> argocd.cnoe.localtest.me
<IP_ADDRESS> backstage.cnoe.localtest.me
<IP_ADDRESS> gitea.cnoe.localtest.me
<IP_ADDRESS> argo.cnoe.localtest.me
<IP_ADDRESS> keycloak.cnoe.localtest.me

This shouldn't be necessary and we probably should not ask users to do this because organization security policies may not allow this kind of modifications. The domain names *.localtest.me does resolve to <IP_ADDRESS> as long as the registered NS is reachable.

@nabuskey I agree it would be better experience to have idpbuilder work with the external hostname given by Codespaces.
Reading the docs is not a random-name but the https://CODESPACENAME-PORT.app.github.dev according to the docs 1 the CODESPACENAME is a environment CODESPACE_NAME available from the environment 2
I think is matter telling the user to find and replace in the yamls host: argo.cnoe.localtest.me with host: $CODESPACE_NAME
I will test this setup

I think this is ready for merging, is a very basic dev environment for go, and if user wants to use idpbuilder is also has docker in docker that user can use idpbuilder

@nabuskey please take a look I addressed your feedback. The files now contain the absolute minimum for an user to use codespaces, devpod, docker, to have a golang environment to make changes to idpbuilder and test

LGMT!


Add support for the oci-layout file

The oci-layout file is part of the image layout and it is mandatory. https://github.com/opencontainers/image-spec/blob/main/image-layout.md#oci-layout-file
Fixes #141

Codecov Report

Merging #142 (d6dbffc) into main (22cb02c) will increase coverage by 0.79%.
The diff coverage is 47.61%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #142      +/-   ##
==========================================
+ Coverage   23.87%   24.66%   +0.79%
==========================================
  Files          22       23       +1
  Lines        1822     1885      +63
  Branches      909      937      +28
==========================================
+ Hits          435      465      +30
- Misses        623      629       +6
- Partials      764      791      +27


ESM support

Know that hardhat at last started supporting esm, most important packages like hardhat-deploy should follow :) ! as currently we have to use .cjs for deployments

it might be just a matter of compiling to esm. I used to try that a while back, before hardhat was supporting esm and gave up because of hardhat not supporting esm. Glad it changed


Pipeline Type to filter results on pipeline role role and list view

Currently pipelines are just listed in no specific order, the customer would like to be able to filter pipelines based on a tag or filter type of the pipeline. ability to have list view for end users that have thousands of pipelines it would be easier to look through.
Describe the solution you'd like
Ability when creating or editing a pipeline to attach a pipeline type (Ingestion, Use-Case, Transform, etc) and filter based on type

@chamiles this feature has been included for the next release v1.4.0 and is currently being reviewed


Unnecessary sharing links and information

Nearly every screen in the app has a sharing link. Often there is information in the link like "fossasia.github.io" or "App link goes here".

Only keep sharing links on the following pages

specific speaker page
specific session page

Document the information structure of the sharing info and take out any wrong info.

Working on it


prevent ENAMETOOLONG by hashing normalized name

Summary
In certain edge cases a javascript file might be deeply nested in a verbose folder structure
(I am looking at you, Java) and therefore cause jests haste-map can cause an ENAMETOOLONG error.
By hashing the name we limit its max size to a length of 32 + additional parts for the cost of making
the cache actually readable.
fixes #2538
Again it might be wise to check for the actual length the normalizer would produce and then only fallback to hashing when the produces name looks too verbose. Therefore keeping the ability to have a human readable hash. (then again not sure if that is needed?)

oh boy i had a very old checkout of jest, brb :P bringing this up to date


Add 1.2pre release to Vendor API versions

Context

Changes proposed in this pull request

Guidance to review

Link to Trello card

Things to check

[ ] If the code removes any existing feature flags, a data migration has also been added to delete the entry from the database
[ ] This code does not rely on migrations in the same Pull Request
[ ] If this code includes a migration adding or changing columns, it also backfills existing records for consistency
[ ] If this code adds a column to the DB, decide whether it needs to be in analytics yml file or analytics blocklist
[ ] API release notes have been updated if necessary
[ ] Required environment variables have been updated added to the Azure KeyVault

Closing, superseded by https://github.com/DFE-Digital/apply-for-teacher-training/pull/7260


⚠ SceneTime has degraded performance

In 68e2e8c, SceneTime ($ST) experienced degraded performance:

HTTP code: 200
Response time: 1402 ms

Resolved: SceneTime performance has improved in 00444fd after 10 minutes.


Changed $timeout to $interval for scheduled user validation

https://github.com/lynndylanhurley/ng-token-auth/issues/182

Oh protractor! Thanks @fatbeard2  =]

@fatbeard2 many thanks for this one!!


add comments for clarity

leave comments somewhere in the code this week for increased clarity and futureproofing of our code

Jr's must pick separate EJS files for commenting


database/sql: at least one example should handle rows.Close() error

Presumably, sql.Rows.Close() can return an error, and should be checked in code where correctness matters.
Adapting the examples to check this error isn't trivial, here's a mistake I just made in production code, for example:
func doQuery() error {
	age := 27
	rows, err := db.Query("SELECT name FROM users WHERE age=?", age)
	if err != nil {
		return err
	}
	for rows.Next() {
		var name string
		if err := rows.Scan(&name); err != nil {
			return err
		}
		fmt.Printf("%s is %d\n", name, age)
	}
	if err := rows.Close(); err != nil {
		return err
	}
	if err := rows.Err(); err != nil {
		return err
	}
}

The error is if Scan() fails, we never call rows.Close() and hold a connection open forever.
Similarly, the docs should give guidance on whether you should check Err or Close first. (Maybe it doesn't matter).

When this is clarified, the tutorial at https://github.com/VividCortex/go-database-sql-tutorial should probably also be updated.  Although that seems mostly unmaintained at the moment.

According to docs -

Close is idempotent and does not affect the result of Err.

So I guess it doesn't matter.
How about we change the example to -
age := 27
rows, err := db.Query("SELECT name FROM users WHERE age=?", age)
if err != nil {
        log.Fatal(err)
}
defer func(){
  err := rows.Close()
  if err != nil {
    log.Fatal(err)
  }
}()
for rows.Next() {
        var name string
        if err := rows.Scan(&name); err != nil {
                log.Fatal(err)
        }
        fmt.Printf("%s is %d\n", name, age)
}
if err := rows.Err(); err != nil {
        log.Fatal(err)
}

Fair points. No log fatal in examples. I think checking the scan error and rows.err is redundant. Could just return result of close. Also it the ctx is canceled rows will close.

Better even to use the double close pattern :
age := 27
rows, err := db.Query("SELECT name FROM users WHERE age=?", age)
if err != nil {
        log.Fatal(err)
}
defer rows.Close()

for rows.Next() {
        var name string
        if err := rows.Scan(&name); err != nil {
                log.Fatal(err)
        }
        fmt.Printf("%s is %d\n", name, age)
}

if err := rows.Err(); err != nil {
        log.Fatal(err)
}

if err := rows.Close(); err != nil {
        log.Fatal(err)
}

@romainmenke I'm curious, why do you say that the double-close pattern is better?
Not every io.Closer is idempotent, so that pattern is dangerous in general (but safe for sql.Rows specifically).

the docs should give guidance on whether you should check Err or Close first. (Maybe it doesn't matter).

Per http://go/godoc/database/sql/#Rows.Close,
“If Next is called and returns false and there are no further result sets, the Rows are closed automatically and it will suffice to check the result of Err.”
That seems to imply that you should call Err if Next returns false, or Close otherwise: in the common case, you need only one or the other.
That suggests a variation on @romainmenke's suggestion, omitting the second Close:
func doQuery(age int) error {
	rows, err := db.Query("SELECT name FROM users WHERE age=?", age)
	if err != nil {
		return err
	}
	defer rows.Close()

	for rows.Next() {
		var name string
		if err := rows.Scan(&name); err != nil {
			return err
		}
		fmt.Printf("%s is %d\n", name, age)
	}
	return rows.Err()
}

@bcmills - I am not very clear from your linked comment about why we can ignore the error from .Close(). As I understand, if Next() returns false, it is enough to just check for .Err(), but if we fail inside the loop, then we need to .Close() manually (and also check for the error ?)
If we don't need to check for error from .Close(), then I don't see anything else to be done in the issue. Because  the actual example in the docs does not return anything. So we need to check the error of rows.Err(); which is already being done in the example.

@agnivade, I think you're correct. The variation I suggested is almost exactly how ExampleRows is already written today, right down to the defer rows.Close(). 🙂
I agree that there doesn't seem to be anything else to be done. Other folks on the issue, please let us know if we've missed something.

Wouldn't @agnivade be the most appropriate at least for rows.Close() because it actually returns an error?


Theme colours are not maintainted with different instances and screen size

Issue Type: Bug
I have Code set to open in full screen view. I use the "Dark+ (default dark)" theme on Windows 10 desktop.
For whatever reason, more often than not, the text appears black on grey. I don't seem to be aboe to find a setting to over-ride this. It's highly annoying and makes using the dark mode hard to work with. Screenshot: https://www.dropbox.com/s/pc28ayxklb4pg7l/vs-dark-bug.jpg?dl=0
VS Code version: Code 1.28.2 (7f3ce96ff4729c91352ae6def877e59c561f4850, 2018-10-17T00:23:51.859Z)
OS version: Windows_NT x64 10.0.17134

System Info

Item
Value

CPUs
Intel(R) Core(TM) i5-6600K CPU @ 3.50GHz (4 x 3504)

GPU Status
2d_canvas: enabledchecker_imaging: disabled_offflash_3d: enabledflash_stage3d: enabledflash_stage3d_baseline: enabledgpu_compositing: enabledmultiple_raster_threads: enabled_onnative_gpu_memory_buffers: disabled_softwarerasterization: enabledvideo_decode: enabledvideo_encode: enabledwebgl: enabledwebgl2: enabled

Memory (System)
15.92GB (7.47GB free)

Process Argv

Screen Reader
no

VM
0%

Extensions (10)

Extension
Author (truncated)
Version

code-gnu-global
aus
0.2.2

gitlens
eam
8.5.6

php-debug
fel
1.12.6

php-intellisense
fel
2.3.5

php-pack
fel
1.0.2

minify
Hoo
0.3.0

mssql
ms-
1.4.0

cpptools
ms-
0.20.1

team
ms-
1.142.0

LiveServer
rit
5.1.1

It is not related to the macOS Mojave dark theme issue

This is the screenshot from the original description:

@tadywankenobi do you have any value specified for workbench.colorCustomizations in your settings?

/needsMoreInfo

Hi folks, sorry I've not logged a bug like this before. Apologies for not including enough info.
As per the Contribution guidelines:

I'm on:
Version: 1.28.2 (user setup)
Commit: 7f3ce96ff4729c91352ae6def877e59c561f4850
Date: 2018-10-17T00:23:51.859Z
Electron: 2.0.9
Chrome: 61.0.3163.100
Node.js: 8.9.3
V8: 6.1.534.41
Architecture: x64

I have the following Extensions enabled:
Azure Repos
C/C++ Intellisense
GitLens
Live Server
minify
PHP Debug
PHP Extension Pack
PHP IntelliSense
SQL Server (mssql)

Reproducible steps:

Not much to indicate here. I open VS Code and text colours do not correspond to the dark theme and are difficult to read

Actual v Expected:

Actual:

Expected:

(Extensions text on left nav. Achieved by hovering when taking screenshot)
@kieferrm to answer your questions, my workbench.colorCustomizations settings are 100% empty:

I have toggled open the Developer Tools and added a color: #fff to the .monaco-shell class, which appears to rectify the issue. I'm not sure if I should add this somewhere else though, so that this class doesn't get over-ridden again later.

Console error: there are no console errors in the Developer Tools

I have attached my settings.json file here (in txt format).
settings.txt
These are my personal settings:
{     "files.associations": {         "window.newWindowDimensions": "maximized",         "*.master": "csharp",         "*.asp": "vb"     },     "php.validate.executablePath": "C:\\xampp\\php\\php.exe",     "breadcrumbs.enabled": false,     "liveServer.settings.donotShowInfoMsg": true,     "git.autofetch": true,     "tfvc.location": "C:\\\\Program Files (x86)\\\\Microsoft Visual Studio 14.0\\\\Common7\\\\IDE\\\\TF.exe",     "team.showWelcomeMessage": false,     "workbench.colorTheme": "Visual Studio Dark", }
(I don't have too many, but if I can add something to them to fix this, I'd be happy to)
Even accessing the settings panel, I have the same issue. When I hover over the text, they go white. I'm at a loss as to what the issue is or if there's some conflict I'm missing.

That enough?

@tadywankenobi You're using the Dark theme, does this reproduce also with the Dark+ theme?

@chrmarti Yes it does. I usually use the Dark+ theme.

I've been playing with adding "workbench.colorCustomizations": {} settings but can't find one that adds just a simple white to the .monaco-shell class

@tadywankenobi Does it reproduce when launching with code --disable-extension (or the command Reload Window with Extensions Disabled from the command palette)?

@chrmarti It does. Just tested.

I also tested by removing all my user settings (cut the contents) and still the same.

Is there some file I can delete or something?

Still a puzzle. You could remove local storage from your user data dir and see if that fixes it. That would also remove any other customizations in local storage, but usually isn't too bad. Or you could check what 'colorthemedata' is set to in local storage and delete that (it's just a cache):

No joy. Not sure at all what to do. Is deleting all localStorage data risky?

It shouldn't be risky, extensions might remember some answers you gave by pressing buttons on message boxes, these you will need to provide again. You could start by backing up your user data dir and then delete the local storage (or just rename its subfolder).

Completely emptying the cache did nothing. If you can tell me where the Data directory is, I'll delete remove that and see if it helps.

It's in ~/Library/Application\ Support/Code. Try renaming the Local Storage folder there.

Sorry, on a PC

@chrmarti Any indication where this is on Windows?

It's in AppData\Roaming\Code of your user directory.
Somehow thought you were on Mac.

No joy. Have uninstalled. Will try a clean install.

Ok, I don't understand this. I've uninstalled all extensions, uninstalled code, deleted the code folder, downloaded latest version, rebooted, installed and still...

I'm at a loss.

(You'll notice there are no chrome icons either in the top right, e.g. Close, minimize, hide)

I've gone into the workbench.main.css and added a colour to .monaco-shell and it has fixed the issue. I'm assuming next time I update Code I'll lose this change though...

For the record, it's not perfect... But at least I'm not squinting and looking for black links on dark grey any more. It would appear to me that in the dark theme, there are fallback expectations that are not precise. The cascade does not appear to be correctly picking up the implicit font colour so it looks like it needs to be explicitly declared.

On further investigation, it appears the the dark theme json files are not being loaded. There are no overrides from the base theme kicking in. Can anyone offer any insight as to how to resolve this?

Reinstalling won't clean your AppData\Roaming\Code. You said that using a new user data dir helped. So you could:

close Code
rename your AppData\Roaming\Code folder
start Code
copy your old settings.json from the renamed folder to the newly created AppData\Roaming\Code folder

If you could keep a copy of your old AppData\Roaming\Code, our experts on this matter might be interested in learning more from it when they are back from vacation.

@chmarti I did all this. When I uninstalled and reinstalled, I renamed the Code folder and immediately after install, it was still the same. I’m at a complete loss.

@chrmarti For info, I manually removed all extensions, removed the app, removed the Roaming > Code folder, rebooted and then reinstalled. I immediately had the same problems. I’ve switched to a light theme so I can work but it’s a pain in the ass.

looks like the css issue we looked at with @bpasero

@tadywankenobi Could you check if this is fixed in the latest insiders builds: https://code.visualstudio.com/insiders/ ?

/duplicate #60298
Thanks @tadywankenobi .


Enabling pool pre-ping by default

Since Flask-SqlAlchemy 2.4.0 it's easy to enable SQL pool pre-pinging that should increase reliability of any services using Flask-Security, it would be a good default in majority of cases. What do you think?
This is how I and some others have done it:
    self.config["SQLALCHEMY_ENGINE_OPTIONS"] = {
        "pool_pre_ping": True,
    }

I have put that in some docs recently as suggested ideas. But it isn't really our place to automatically add options to other packages - especially DB..  IMHO.
Yes - it helps flask-security - but it is even more important to the application itself that might well have its own ideas about connections and pools etc.

Well, it does a tad more than help, currently if any connection in the pool timeouts FS won't recover, there's an issue upstream about that. Though I guess anyone actually encountering it can apply the fix themselves.

And it affects their ENTIRE application. We need to be careful not to delve too much into data stores here - it is already difficult enough to test and keep up. So - I do believe in best practice and documenting that. So we should add that to quickstart and the example app (I thought I had done that already).


comments in reference_output

As we are writing custom tests by hand, it's challenging to keep track of the meaning of the values in the reference_output.  We decided to add comments delimited by # in the reference_output.  We modified one line of the verify.sh script to ignore these comments when running a diff against signature.output, and think this feature might be helpful to other people.
verify.sh
diff --ignore-case --ignore-trailing-space --strip-trailing-cr <(grep -o '^[^#]*' ${ref}) ${sig} &> /dev/null

Well I don't see a harm in adding this as long as its backwards compatible - signatures without # should also match correctly.
just curious.. how are you adding comments to the reference_output - through your own simulator ? Could highlight what type of comments ? Maybe we can get SAIL/Spike to add something similar?

Yea, I was thinking about that as well. The obvious choice for some
automatic thing might be testcase name, though I'm not sure how to do it.
That would be fantastic if we could, and we could also add it to signatures
written by the trap handler - it would solve a huge problem with
nondeterminstic results.
On Tue, Feb 8, 2022 at 8:54 PM Neel Gala @.***> wrote:

Well I don't see a harm in adding this as long as its backwards compatible

signatures without # should also match correctly.

just curious.. how are you adding comments to the reference_output -
through your own simulator ? Could highlight what type of comments ? Maybe
we can get SAIL/Spike to add something similar?
—
Reply to this email directly, view it on GitHub
https://github.com/riscv-non-isa/riscv-arch-test/issues/230#issuecomment-1033348423,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AHPXVJUE4XK3F5C7D7TDPUDU2HXO5ANCNFSM5N35V6XQ
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

Yea, I was thinking about that as well. The obvious choice for some automatic thing might be testcase name, though I'm not sure how to do it. That would be fantastic if we could, and we could also add it to signatures written by the trap handler - it would solve a huge problem with nondeterminstic results.
…
On Tue, Feb 8, 2022 at 8:54 PM Neel Gala @.> wrote: Well I don't see a harm in adding this as long as its backwards compatible - signatures without # should also match correctly. just curious.. how are you adding comments to the reference_output - through your own simulator ? Could highlight what type of comments ? Maybe we can get SAIL/Spike to add something similar? — Reply to this email directly, view it on GitHub <#230 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AHPXVJUE4XK3F5C7D7TDPUDU2HXO5ANCNFSM5N35V6XQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub. You are receiving this because you are subscribed to this thread.Message ID: @.>

One way to do it would be to have a table of strings in the data section or a separate test pointer which increments after each test case. You can store that in the signature section, but that will increase the number of signature words you have to dump out. There are other ways of doing it where you run a post script and use the context from the logs and disassembly to figure out which test caused the write to a particular signature word. Its hard to have a implementation agnostic solution otherwise.

@davidharrishmc If I understand correctly the comments have been added manually by Kip in the reference files - there is no tool/automation which goes an updates the reference file automatically ?
@pawks @allen a yet another option : since a lot of simulators (include spike) have a elf-parser, maybe printing the closest-previous label when a signature update happens might work..

Yes. The information is already present in the elfs, it's a matter of extraction. The only issue with using simulators is that it's simulator/model dependent ( I believe it will be very difficult to achieve this in SAIL). If it is really important, I would recommend having a post processing script which adds these comments later on. That way it's simulator and model agnostic.

Neel - correct.  In our use case, both the test cases and the reference_output are written manually, and the comments make it much easier to relate the reference_output to the test cases and help identify where to put more signature entries when more test cases are added by hand.
Automation wouldn’t make sense in this case because there’s not a trivial relationship between tests and signature - the information we want to record on a page fault is different than what we want to record for a successful memory read, and we record no signature for a memory write until we verify it with a read later.
If we were writing an automated test case generator, we would generate comments in the reference_output at the same time we generate the tests and the expected values.
David

On Feb 9, 2022, at 4:46 AM, Neel Gala @.***> wrote:
@davidharrishmc https://github.com/davidharrishmc If I understand correctly the comments have been added manually by Kip in the reference files - there is no tool/automation which goes an updates the reference file automatically ?
@pawks https://github.com/pawks @allen https://github.com/allen a yet another option : since a lot of simulators (include spike) have a elf-parser, maybe printing the closest-previous label when a signature update happens might work..
—
Reply to this email directly, view it on GitHub https://github.com/riscv-non-isa/riscv-arch-test/issues/230#issuecomment-1033723647, or unsubscribe https://github.com/notifications/unsubscribe-auth/AR4AA376HWEBGDAQMIIYNZDU2JOYVANCNFSM5N35V6XQ.
Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you were mentioned.

@pawks maybe the data-propagation module within isac could achieve this.. since it includes an elf-parser and is aware when signature updates happen

@davidharrishmc the automation I am refering is purely for the comments in the reference_outputs - which can be independent of the interpretation of the signature contents. The idea is if someone sees a mismatch in the signatures, the comments must help them figure out where in the test they should be focusing on to replicate/isolate the bug.
Since majority of the tests in this repo are automatically generated, we would like to have a similar automation for "comments in reference-signature" as well. Will need to explore more along those lines

as a TODO item I will update verify.sh with your command above in my next PR.

@neelgala The BSD diff does not support --ignore-trailing-space option, so it will fail on MacOS. Can it be replaced with --ignore-all-space? It supports both BSD and Linux.

if that's the case.. @kuopinghsu would you mind creating a PR for the same ? I can then test it out for linux at my end atleast check for any odd behavior

Done. PR #252


File with incorrect filename

Hello Niklas! I'm currently trying to follow through your tutorials. I noticed that it's not possible to clone the repository on Windows because of this file - the name isn't valid under Windows, and I'm reasonably sure it's meant to be different on other systems as well :)

Thanks Timon. I've removed it. The file wasn't used.


moveViewToX

Hi,
I'm trying to set the chat to scroll to last value in data set X using moveViewToX(entries.count) but this doesn't seem to move to the last value. Any Ideas?
Cheers

You are passing an invalid index

My data set has up to 1100 data points, i want to move to the last index. Shouldn't this be the right value? if not, how can i get it?

1099
On Thu, Jul 30, 2015 at 3:32 PM, donaldkingdt<EMAIL_ADDRESS>wrote:

My data set has up to 1100 data points, i want to move to the last index.
Shouldn't this be the right value? if not, how can i get it?
—
Reply to this email directly or view it on GitHub
https://github.com/danielgindi/ios-charts/issues/258#issuecomment-126307413
.

How is that about? pls explain

The first item is at 0

Exactly my point. The last item should be at lastItem.count right?

No. If you have two items, and first one is 0, then the second one is 1. Which means that you cannot pass 2 for the last item of two, but 1.

self.chartView.setVisibleXRangeMaximum(20)
self.chartView.moveViewToX(self.measurementEntries.count - 1)
does this look right?

Fixed. Had to call self.chartView.moveViewToX(self.measurementEntries.count - 1) in ViewDidAppear().
Cheers Daniel

Had to do similar thing in viewDidAppear as well. It results in weird jump to the most recent values. But if I do this in viewWillAppear then I get the wrong position with partly blank graph.
Happy to share more details about the issue if needed.

I've the same issue.
I have 28 points and I show only 4 in a view.
I want to show (in the first time) the last point of my dataSet. But with this method, I've a blank space a the right of my last point. Any idea?
[_lineChartView zoom:7 scaleY:0 x:0 y:0];```

the thing is from what I noticed that you will get another plotted value to the right side, also you should change the order of the lines from:
[_lineChartView moveViewToX:_lineChartView.data.yValCount-1]; [_lineChartView zoom:7 scaleY:0 x:0 y:0];
to:
[_lineChartView zoom:7 scaleY:0 x:0 y:0]; [_lineChartView moveViewToX:_lineChartView.data.yValCount-1];


cmd/cue: Weird formatting when importing large files

Originally opened by @uhthomas in https://github.com/cuelang/cue/issues/826

What version of CUE are you using (cue version)?

$ cue version
cue version v0.3.0-beta.5 linux/amd64

Does this issue reproduce with the latest release?
Yes.
What did you do?

curl -Lfv https://github.com/jetstack/cert-manager/releases/download/v1.2.0/cert-manager.yaml > t.yaml
cue import --list t.yaml

What did you expect to see?
A nicely formatted CUE file.
What did you see instead?

Formatting looks fine to me. A more specific example is welcome.

@mpvl Sorry, I must not have seen your comment.
Given https://github.com/cert-manager/cert-manager/releases/download/v1.11.0/cert-manager.crds.yaml
❯ cue import --list cert-manager.yaml

Produces https://gist.github.com/uhthomas/da3842ef5880be0e26f05a00272a3ae4
The formatting is initially fine, but then looks really weird around here: https://gist.github.com/uhthomas/da3842ef5880be0e26f05a00272a3ae4#file-cert-manager-cue-L3081
apiVersion:
	"apiextensions.k8s.io/v1", kind:
	"CustomResourceDefinition", metadata: {

	name: "certificaterequests.cert-manager.io"
	labels: {
		app:                          "cert-manager"
		"app.kubernetes.io/name":     "cert-manager"
		"app.kubernetes.io/instance": "cert-manager"
		// Generated labels
		"app.kubernetes.io/version": "v1.11.0"
	}
}, spec: {

	group: "cert-manager.io"

I hope it's clear that something is wrong here.


2.0.8 aws CFT autoscale - with new vpc (no transit gateway) fails to deploy 'private' ENI for Fortigate EC instances

deployed using the 2.0.8 "fortigate-autoscale-aws-cloudformation.zip"  -
used the templates\autoscale-new-vpc.template CFT to deploy stack
Deployed this twice - both times in US-EAST-2 AZ A, and AZ B.
in the first deployment the Masterfortigate in the autoscale group did not deploy with the 2nd ENI - connected to private 1 subnet.
it only deployed with public 1 subnet eni.  -- the non master (set my desired instances to 2) did indeed deploy with 2 ENI, public 2, and private 2 networks.
Scale out did work correctly - scaled out fortigate did include 2 eni (public and private)
deleted the stack and deployed again to determine if problem could be recreated.
in my second deployment BOTH fortigates only had single eni in public 1 and public 2 subnet.
Deleted and went back to using 2.0.7 which functioned normally.
Information about deployement:
t2.small type (basic proof of concept deployment)
PAYG instance types

Hi @rayaa3 the "in the first deployment the Masterfortigate in the autoscale group did not deploy with the 2nd ENI" is a known issue, a fix will be published soon.

resolved in 2.0.9


hunspell: speed up "compress"; minimize the number of the generated entries; don't even consider "forbidden" entries anymore

I admit I've no idea what improvement I'm looking at here but I trust you know!

I can add some comments with explanations :)

I can add some comments with explanations :)

No need. I glanced through the code and it doesn't seem to be a backdoor. :) You know better what works here anyway.

@rmuir can you have a look?

I can add some comments with explanations :)

No need. I glanced through the code and it doesn't seem to be a backdoor. :) You know better what works here anyway.

Hahaha. I know donnerpeter and have seen code by him already. But like the xz/liblzma desaster he could possibly be working for long time on taking over the world! We should check if Gradle code was changed!


Check that the correct pdfDocument is still active, before rendering the outline/attachments/layers

This patch fixes some technical debt in the viewer.
Given that most API methods are (purposely) asynchronous, there's always a risk that the viewer could have been closed before the requested data arrives.
Lately we've started to check this case before using the data, to prevent errors and/or inconsistent state, however the outline/attachments/layers fetching and rendering is old enough that it pre-dates those checks.

/botio-windows preview

Looks good!


Incredible work! ❤

(I wasn't sure how to get in contact with you to thank you so apologies for creating a GitHub issue)
After purchasing and returning subpar hardware solutions like Tado and Sensibo, it was a breath of fresh air to come across your Homebridge plugin which is far superior to both of these overpriced and underperforming devices!
Set up was very simple and I haven't had any issues so far. I am now able to seamlessly integrate my A/C with Siri – amazing!
Thank you & keep up the great work.

Thank you ... i fact the homebridge plugin itself is not frommme ... I just deliver a library that can be used by other projects ...


WebID

Java implementation of WebID protocol, can be useful for us:
https://github.com/turnguard/com-turnguard-rww

The WebID verification part we implemented in a similar way by ourselves


pod install error

Hello,
I get the following error by executing pod install. Can you help me?
cloud_firestore: Using Firebase SDK version '8.9.0' defined in 'firebase_core'
firebase_core: Using Firebase SDK version '8.9.0' defined in 'firebase_core'
[!] CocoaPods could not find compatible versions for pod "FirebaseFirestore":
  In Podfile:
    FirebaseFirestore (from `https://github.com/invertase/firestore-ios-sdk-frameworks.git`, tag `8.6.0`)

    cloud_firestore (from `.symlinks/plugins/cloud_firestore/ios`) was resolved to 3.1.0, which depends on
      Firebase/Firestore (= 8.9.0) was resolved to 8.9.0, which depends on
        FirebaseFirestore (~> 8.9.0)

@MarcoVitalSci can you try with 8.9.1?

Or try pod update instead of pod install

Thank you for your responses.

pod update gives the same error.

If I change the version to 8.9.1, I get the following error message:

Running "flutter pub get" in stolperstein_app...
Because stolpersteinapp depends on firebase_core 8.9.1 which doesn't match any versions, version solving failed.
pub get failed (1; Because stolpersteinapp depends on firebase_core 8.9.1 which doesn't match any versions, version solving failed.)

I believe you are changing your flutter package versions vs the Pod dependency version. They are related but separate.
Original message:

[!] CocoaPods could not find compatible versions for pod "FirebaseFirestore":

Current message:

Because app depends on firebase_core 8.9.1 which doesn't match any versions, version solving failed.

Those are errors from completely different version resolvers.
You need to stay on whatever version of firebase_core is most recent (and works for you, I know there are different channels), while overriding the podfile version to 8.9.1 if that's possible. https://firebase.flutter.dev/docs/overview#iosmacos

Hello, I am getting this error:
pod update
Update all pods
Updating local specs repositories
Analyzing dependencies
Pre-downloading: `FirebaseFirestore` from `https://github.com/invertase/firestore-ios-sdk-frameworks.git`, tag `8.10.0`
FirebaseFirestore/AutodetectLeveldb: subspec would include leveldb if used directly or by default.
cloud_firestore: Using Firebase SDK version '8.9.0' defined in 'firebase_core'
cloud_functions: Using Firebase SDK version '8.9.0' defined in 'firebase_core'
firebase_analytics: Using Firebase SDK version '8.9.0' defined in 'firebase_core'
firebase_auth: Using Firebase SDK version '8.9.0' defined in 'firebase_core'
firebase_core: Using Firebase SDK version '8.9.0' defined in 'firebase_core'
firebase_crashlytics: Using Firebase SDK version '8.9.0' defined in 'firebase_core'
firebase_dynamic_links: Using Firebase SDK version '8.9.0' defined in 'firebase_core'
firebase_in_app_messaging: Using Firebase SDK version '8.9.0' defined in 'firebase_core'
firebase_messaging: Using Firebase SDK version '8.9.0' defined in 'firebase_core'
firebase_performance: Using Firebase SDK version '8.9.0' defined in 'firebase_core'
firebase_remote_config: Using Firebase SDK version '8.9.0' defined in 'firebase_core'
firebase_storage: Using Firebase SDK version '8.9.0' defined in 'firebase_core'
[!] CocoaPods could not find compatible versions for pod "Firebase/Messaging":
  In Podfile:
    Firebase/Messaging

    firebase_messaging (from `.symlinks/plugins/firebase_messaging/ios`) was resolved to 11.2.4, which depends on
      Firebase/Messaging (= 8.9.0)

CocoaPods could not find compatible versions for pod "FirebaseFirestore":
  In Podfile:
    FirebaseFirestore (from `https://github.com/invertase/firestore-ios-sdk-frameworks.git`, tag `8.10.0`)

    cloud_firestore (from `.symlinks/plugins/cloud_firestore/ios`) was resolved to 3.1.5, which depends on
      Firebase/Firestore (= 8.9.0) was resolved to 8.9.0, which depends on
        FirebaseFirestore (~> 8.9.0)

This is my podfile configuration:
target 'Runner' do
  use_frameworks!
  use_modular_headers!
  pod 'GoogleUtilities'
  pod 'FirebaseFirestore', :git => 'https://github.com/invertase/firestore-ios-sdk-frameworks.git', :tag => '8.10.0'

  flutter_install_all_ios_pods File.dirname(File.realpath(__FILE__))
end

You'll need to override the version for flutterfire as well.this May be important too as 890 had a bug with analytics if I remember the changelog correctly. 8 10 0 is current yes

8.10.0

Hello, I don't understand what do you mean? I am using these dependencies:
In my podfile:
:pod 'FirebaseFirestore', :git => 'https://github.com/invertase/firestore-ios-sdk-frameworks.git', :tag => '8.10.0'
and in my pudspec.yaml:
# Firebase plugins
firebase_core: ^1.10.6
cloud_firestore: ^3.1.5
cloud_functions: ^3.2.4
firebase_auth: ^3.3.4
firebase_dynamic_links: ^4.0.3
firebase_messaging: ^11.2.4
firebase_remote_config: ^1.0.3
firebase_storage: ^10.2.4
google_mobile_ads: ^1.0.1
firebase_crashlytics: ^2.4.4
firebase_performance: ^0.8.0+3
firebase_analytics: ^9.0.4
firebase_in_app_messaging: ^0.6.0+5
geoflutterfire2: ^2.3.11

Override the version in FlutterFire so it matches the one you want. The podspec there checks for a version string you can put in your Podfile and will give you positive feedback via console messages if it detects you are using a custom version
https://github.com/FirebaseExtended/flutterfire/blob/efdcc16aa2f3d45a3835f0eb73801ba88e808e07/packages/firebase_core/firebase_core/ios/firebase_core.podspec#L6-L8

Override the version in FlutterFire so it matches the one you want. The podspec there checks for a version string you can put in your Podfile and will give you positive feedback via console messages if it detects you are using a custom version
https://github.com/FirebaseExtended/flutterfire/blob/efdcc16aa2f3d45a3835f0eb73801ba88e808e07/packages/firebase_core/firebase_core/ios/firebase_core.podspec#L6-L8

@mikehardy thank you very much is working now, I used:
# Uncomment this line to define a global platform for your project
platform :ios, '11.0'
$FirebaseSDKVersion='8.10.0'


Suspend when listed in linter.disabledProviders

The package is in flux right now, and I’m working on six other things anyway, but I’m writing this down so I don’t forget about it.
Issue Type
Enhancement
Issue Description
I’ve been trying to make my own version of ide-typescript and finding that ESLint’s suggestions often overlap those of the TypeScript language server. It’s annoying to have the same issue annotated twice, especially since the two sources often disagree on severity. But I don't want to turn off linter-eslint-node entirely — just on certain projects.
The linter package allows you to specify a list of disabled providers in your settings, and I figured that’d work great with atomic-management — I’d just need to put something like this in .atom/config.cson:
"*":
  "linter":
    "disabledProviders": [
      "ESLint (Node)"
    ]

This does what it’s supposed to on linter’s side, but it’s not enough. Because we also go outside of the linter system to setup automatic fixes via fixJob.
We should be observing linter.disabledProviders so that we can do more thorough cleanup whenever that setting is changed to add or remove our linter. If the setting is changed to include our linter after we’ve loaded, we can suspend; and if it’s changed to remove our linter, we can wake up.
It would probably also be a good idea to include a shorthand setting within our package that accomplishes the same thing. This would allow per-project overrides for people who use our .linter-eslint config file instead of atomic-managment or project-config:
{
  "disabled": true
}

If either this setting or linter’s setting suggested we should be disabled, we’d disable ourselves.

Can you label this a bug please? 👀

Labelled it as both bug and enhancement. I'd split it into two different tickets, but I plan to tackle this soon anyway and will make sure to address it all in one PR.

(BTW, this issue's discovery led directly to the PR I wrote for Pulsar that took up most of my day yesterday.)


Remove incorrect and un-necessary flipping of Y center of projection …

…for distortion correction when harnessing an OpenGL renderer to a Direct3D DirectMode renderer.
This was scaling by the D factor, which it should not have been.  It also did not need to be done at all; apparently the buffer flipping elsewhere in the system takes care of this properly without requiring flipping of the COP here.
Validated this using OpenGL and OpenGL/Direct3D displays, one on the monitor and one on a DK2.

This fixes https://github.com/sensics/OSVR-RenderManager/issues/323


Support tablespace for partitioning

Add option to specify the tablespace that the partitions will be stored

Hey @trietphm, thanks for the PR! Can you give a bit more context about how you're using tablespaces with partitioning? Also, does it make sense for the parent table to share the same tablespace?

Our database has two main tablespaces: slow_tablespace and fast_tablespace.

slow_tablespace's location is set to the HDD disks and is for the data that does not require really good IO performance. Mostly for tracking, archiving data.
And fast_tablespace - the default tablespace for all other tables which points to the SSD disks.

The old ordinary table is in slow_tablespace and I want to put the partitioned table there as well.
IMO, it does not matter which tablespace that the parent will be put since there is no data in that table. Right now, the parent table is created in the default tablespace, not the same tablespace as the old one.

Thanks @trietphm, that's really helpful. It sounds like pgslice could use the tablespace from the original table in the prep command and then carry that to the partitions, but I like the simplicity of this approach. A few thoughts on the code:

Let's use the quote_ident() method around the tablespace when building SQL
From my testing, the tablespace needs to come after INHERITS () for the trigger-based approach

Yeah, you're right. Updated 👍

Thanks @trietphm! Will push out a new release shortly.


Added duplicate project interface and functionality

Fix those few comments then you're good to merge and deploy to prod


Investigate making WebRTC work completely offline

Right now it is required that you have at least one network interface that is up, not necessarily connected to the internet. We should investigate how difficult it is to make pion / cooperating SDKs/web libs to connect to the loopback interface. The loopback interface is filtered out during the ICE host candidate selection process.

if this can be done, remove SkipUnlessInternetConnected from tests that don't need the "internet"


Opencv agast tree search proposal for significant codesize reduction with comparative performance

Hi All,
I propose to fix the https://github.com/Itseez/opencv/issues/5669 problem and reduce codesize for AGAST algorithm up to 5-10 times depending on platform. It can be very useful for embedded systems with small memory resources because current AGAST codesize is one of largest in OpenCV. The performance remains comparative (50-200% variation depended on testcase and method). The core of improvements is binary tree condition search from 32-bit table instead of thousands of if-else-goto in previous code. The 32-bit tree leaf format contains two 12-bit absolute table offsets for positive/negative results, 4-bit id of compared node/pixel (can be expanded up to 7 bit if necessary) and 1 bit of comparing result (below or above threshold). The leaf table was generated automatically from current code using Perl script, all performance/ quality tests passed OK. The current proposed branch contains code replacement, but it's easy to derive new class if necessary. Also I have experimental version with even more table codesize reduction (24-bit instead of 32-bit plus relative offsets), but it seems to be slower on RISC processors because of alignments. The further performance optimization is also possible after tree reordering for better cache alignmants (I precerved the current order). Feel free to ask me any questions and proposals about this improvement.
Regards,
Andrey

@askourik ,

I like your proposal, very nice optimisation !
Can please add the perl code too somewhere in some sample folder ?

For this to get merged, better would be to (at least i would do):
(a) leave the original code too, new code should be conditioned with some flag.
(b) need to check in the depending BRISK if performance is degraded or not.
I help you with (b) and will look how we should do (a) properly.
--------------<<<--------------
Hmm i do not understand why we get there those warnings, i guess buildbot's fault and will get fixed soon, Cc @mshabunin ,

@cbalint13 ,
Of course, I can add the appropriate Perl code, but not familiar with OpenCV policy on this topic. Could you please tell me correct path to put  my script? To be mentioned: it requires some manual correction of existing code, you should split 1-line "else if" construction in 2 lines. Also, you shouls set first and last lines of each "if-else-goto" large module as input parameter. I can provide brief instructions and batch file with working examples if necessary.
On other suggestions:
a) yes, I have merged version with AGAST_TREE preprocessor define which switches on/off this functionality, If it's the best way, I can do atother pull request, or you mean software-defined flag?
b) I guess the performance is deeply depends on test platform. I tested for Intel, In general it 1.5-2 times slower for current version. But due to regular structure, it can be easily improved by tree reordering an128-bit optimizers as well as using close memory pools for pixel/tree data
BTW, what about 24-bit tree version?
Regards,
Andrey

@askourik ,

I propose you something like: http://openrisc.rdsor.ro/AGAST/agast_trees.diff I have no better idea but to leave the original for x86_64/i386 ones. The very intention of the original authors for AGAST was those decision trees, they stated: "faster than FAST and even FAST-ER" http://www6.in.tum.de/Main/ResearchAgast :) Thats why i have in mind to leave at least for x86_64/i386 their orignal code and idea.

It's 1:1 your work i just added apropiate if/else/endif for x86 CPU, nothing else (runs&compiles).

The quality of AGAST scoring routines is very good compared to FAST e.g BRISK detector/descriptor depends a lot on AGAST's scoring.

I believe we can create a doc folder inside /feature2d (just like other module have such), lets put there agast_tree_gen.pl.txt (lets have .txt ending to not confuse with some exec) and in the very features2d/include/opencv2/features2d.hpp AGAST doxygen sections lets mention that for non i386/x86_64 there are some optimised tree based routines (bit slower) and a perl generator exists for it (if someone want further work on it), and we can mention this PR&issue ticket and scope too there.

Regarding 24bit i dont know :) You done an amazing optimization already ! Probably a furthermore even better approach would be to convert your tree stuff to use inline ASM for x86 and separate inline ASM for AMD like many algorithms does this (e.g FAST). Probably even original "goto" if one rewrites it in ASM would work even better. Perhaps someone could pick up your perl generator and tackle with ASM, thats why i proposed to push perl script too for a better transparency.

Lets see upstream reviewers opinion too, hope buildboot is fixed too in the meanwhile. I believe for non-intel you already done the great :)

@cbalint13 ,
It's a good idea to leave original code for x86, I'll update my repositary tomorrow.
Yes, the brief documentation is necessary for new method because tree node structure needs description. Of course, the tree node internal format can be changed for (possible) further expansion on larger pixel areas, it's a discussion topic. Using perl script, it's a simple task.
OK, I'll create doc folder inside features2d and put here a family of perl scripts with batch file example for automation. But for good case reproduction, I'm also going to put there modified agast.cpp and agast_score.cpp files (renamed by *.txt). For original function OAST9_16, e.g., the "if-else-goto" structure is changed by "{;}-continue", so I manually replaced these operators by goto labels to simplify perl automation.
If anybody will need more compact 24-bit tree version, I can also provide appropriate Perl Script. It works only for agast.cpp because the distance between nodes in agast_score.cpp is too large (>256)
Feel free to add any comments before my tomorrow commit :)
Regards,
Andrey

I updated AGAST code and added doc folder with perl scripts as promised.

@askourik , Very nice work !

Last requirements, mandatory & cosmetic related:

(1) Can please remove any tabs and replace with spaces in the code ?
(2) Put final newline on that .bat script (its missing): https://github.com/Itseez/opencv/pull/5670/files#diff-93c8deac88ec5648d5a1a88d4284bd75R32
(3) In features2d/include/opencv2/features2d.hpp, mention that on non-intel there is tree optimised variant of AGAST with same numerical results, and also mention the presence of perl script.
(4) Squash all commits into single one so mainteiners/reviewers can read well your code.

My +1 comments:

However those "register" https://github.com/Itseez/opencv/pull/5670/files#diff-28fe7c6104c1d3e31066fa5339283e80R8156 don't know how would perform on non-intel arch that maybe have limited set of registers, so your optimisation is really welcome for any non-intel. The BRISK which depends on AGAST seems to be not affected, at least not non-intel.

Perl script looks very intuitive, anyone can do ASM optimize if want further improvements.

@askourik , I cant see the buildbot build for now (you only pushed the perl code to doc so no rebuild was triggered since there was no toch to the very code). If do the mandatory cosmetics you will anyway trigger buildbot too. Its trivial to have this builded by buildbot and passed with buildbot's QA checks too (full green states).

@cbalint13 ,
I've replaced tabs by spaces, put .bat newline and added description to features2d.hpp. Alas, the squashing all commits into one using Git is impossible task for me. I've tried to do it honestly, but no success, now the log is even more complicated :(. So I guess the best way in this situation is to clone final code on new branch and create new pull request for main repository. I'd really appreciate for any ideas in this situation.
 Dont worry.

@cbalint13 ,
Thanks, the second attempt was more successful, but the doc folder wasn't added after this patch apply. I've added docs folder be separate commit, hope that now all is OK
Regards,
Andrey

@askourik, thank you for the patch!
could you please fix the warnings reported by the Android and iOS build slaves?
http://pullrequest.opencv.org/#/summary/
also, this is quite radical refactoring of the algorithm, so some regression tests would be useful to have too.
I do not have any major complains about the code; one of possible improvements would be to change "unsigned long" that you use extensively with "unsigned". "unsigned long" is 32-bit or 64-bit number, depending on the platform (e.g. it's 64-bit number on quite popular nowadays x64 Linux distros and also on OSX), whereas "unsigned" is 32-bit number of any platform and any C/C++ compiler I can remember. So those tables would be 2x more compact if you switch from "unsigned long" to "unsigned".

@vpisarev ,
OK, I'll fix the Android/iOS bugs, it just require the declaration of one new function, I've lost it after trying of squashing commits all-in-1.
Regretfully, I cannot agree with your remarks on type of tree tables. According to C99, the "unsigned" type (brief form of "unsigned int") cannot guarantee 32-bit representation because it capable of containing at least the [−32767, +32767] range; thus, it is at least 16 bits in size (ISO/IEC 9899:1999 specification, TC3 (PDF). p. 22); moreover, all C data types can guarantee only minimal bit number because of portability; the "unsigned long" type guarantees at least 32 bits; all other problems are up to platform-dependent compiler. There is a special type "unsigned long long" which guarantees at least 64 bit; so, the correct x64 compiler must distinct the above two types and optimize them in different ways.
Regarding additional regression tests: I can only support this idea, but I need more details. Are you suggest to add new testcases in current test application or run it locally? Some new tests will be useful. But main "code-to-tables" conversion was automated using Perl script by the way similar to compiler code parsing; warnings and errors in Perl scripts are also provided. So the "human factor" error risk was minimized.
Which image samples from standard opencv test set could you recommend for additional testing?
Regards,
Andrey

According to C99, the "unsigned" type (brief form of "unsigned int") cannot guarantee 32-bit representation
In this case OpenCV doesn't not work at all. There are many things silently assume 32-bit "int".

What is about uint32_t?

@alalek ,
I guess your suggest is reasonable, I'll implement it after fixing iOS/Android compile problem

The iOS/Android bug fix is ready now. The unsigned long/uint32_t replacement was also made and works OK; the only open question is new regression tests addition, any recommendations on it?
Also, my first try to squash all-in-1 commits in opencv_agast_tree branch was very unsuccessful. If you still need it, I can generate new branch and create new pull request.
Regards,
Andrey

@askourik, @alalek, thanks for solving the datatype issue!
@askourik, regarding the tests. As I see, there is already some test for AGAST: opencv/modules/features2d/test_agast.cpp. If it passes, then may be it's enough, no extra work needed

@vpisarev , yes, there are bost performance and quality tests for AGAST algorithm, and I've checked both of them before pull request (see above discussion with @cbalint13).
Also, I can propose for OpenCV very fast and efficient Hough Transform algorithm which overtops all other Hough algorithms by performace/resolution ratio (and uses MMX/SSE optimizations). If you are interested and need details, let me know where to initiate new discussion about it.
Regards,
Andrey

@askourik

on very ARM can check if running opencv/modules/features2d/test_agast.cpp & features2d/perf/perf_agast.cpp passes ? GitHub's buildbot does not do these checks on very ARM.
on Intel it passes since we use #ifdef and old code is running.

@cbalint13 ,
Yes, it passes on my Raspberry Pi 2. I can re-run these tests using files from my last commit and provide you brief results in this discussion or elsewhere.
P.S. Are there any possibilities to check performance/regression tests using Github buildbot for ARM platform?

@askourik ,
Buildbot looks green now, so it could be merged.

As @vpisarev also stated if it pass we are on the fine path.
We should ask @mshabunin if ARM could perform tests too on buildbot ?

I guess buildbot's ARM is not that perfromant to afford running the tests too. Thank you for spending time on this PR and doing ARM tests.
----<<<----

For the MMX/Hough thing would be great to open a PR .Notice that there already is a hogh transform implemented, but i believ it can be enhanched. I plan soon to ad Radon transform among the hough ones so your MMX optimization comes just fine.

@cbalint13, @vpisarev,
Here are brief test logs from Raspberry Pi 2 (new AGAST module):
./opencv_test_features2d
CTEST_FULL_OUTPUT
OpenCV version: 3.0.0-dev
OpenCV VCS version: 3.0.0-783-g7ddc2cc-dirty
Build type: release
Parallel framework: openmp
CPU features: neon
OpenCL is disabled
[==========] Running 86 tests from 45 test cases.
[----------] Global test environment set-up.
[----------] 1 test from Features2d_AGAST
[ RUN      ] Features2d_AGAST.regression
[       OK ] Features2d_AGAST.regression (1623 ms)
[----------] 1 test from Features2d_AGAST (1623 ms total)
...
[----------] 1 test from Features2d_Detector_AGAST
[ RUN      ] Features2d_Detector_AGAST.regression
[       OK ] Features2d_Detector_AGAST.regression (685 ms)
[----------] 1 test from Features2d_Detector_AGAST (685 ms total)
...
./opencv_perf_features2d
...
[==========] Running 59 tests from 16 test cases.
[----------] Global test environment set-up.
[----------] 8 tests from agast_detect
[ RUN      ] agast_detect.detect/0
[ PERFSTAT ]    (samples = 10, mean = 78.81, median = 78.79, stddev = 0.10 (0.1%))
[ VALUE    ] 	("cv/detectors_descriptors_evaluation/images_datasets/leuven/img1.png", AGAST_5_8)
[       OK ] agast_detect.detect/0 (954 ms)
[ RUN      ] agast_detect.detect/1
[ PERFSTAT ]    (samples = 10, mean = 81.89, median = 81.85, stddev = 0.11 (0.1%))
[ VALUE    ] 	("cv/detectors_descriptors_evaluation/images_datasets/leuven/img1.png", AGAST_7_12d)
[       OK ] agast_detect.detect/1 (984 ms)
[ RUN      ] agast_detect.detect/2
[ PERFSTAT ]    (samples = 10, mean = 82.21, median = 82.22, stddev = 0.10 (0.1%))
[ VALUE    ] 	("cv/detectors_descriptors_evaluation/images_datasets/leuven/img1.png", AGAST_7_12s)
[       OK ] agast_detect.detect/2 (987 ms)
[ RUN      ] agast_detect.detect/3
[ PERFSTAT ]    (samples = 10, mean = 84.31, median = 84.30, stddev = 0.09 (0.1%))
[ VALUE    ] 	("cv/detectors_descriptors_evaluation/images_datasets/leuven/img1.png", OAST_9_16)
[       OK ] agast_detect.detect/3 (1008 ms)
[ RUN      ] agast_detect.detect/4
[ PERFSTAT ]    (samples = 10, mean = 66.69, median = 66.66, stddev = 0.08 (0.1%))
[ VALUE    ] 	("stitching/a3.png", AGAST_5_8)
[       OK ] agast_detect.detect/4 (811 ms)
[ RUN      ] agast_detect.detect/5
[ PERFSTAT ]    (samples = 10, mean = 73.92, median = 73.87, stddev = 0.25 (0.3%))
[ VALUE    ] 	("stitching/a3.png", AGAST_7_12d)
[       OK ] agast_detect.detect/5 (883 ms)
[ RUN      ] agast_detect.detect/6
[ PERFSTAT ]    (samples = 10, mean = 74.48, median = 74.43, stddev = 0.21 (0.3%))
[ VALUE    ] 	("stitching/a3.png", AGAST_7_12s)
[       OK ] agast_detect.detect/6 (888 ms)
[ RUN      ] agast_detect.detect/7
[ PERFSTAT ]    (samples = 10, mean = 78.64, median = 78.60, stddev = 0.26 (0.3%))
[ VALUE    ] 	("stitching/a3.png", OAST_9_16)
[       OK ] agast_detect.detect/7 (929 ms)
[----------] 8 tests from agast_detect (7444 ms total)

@vpisarev , @cbalint13 ,
Are there remains any problems or difficulties to merge my pull request? If yes, please let me know how to repair it. I guess that 3+ times code reduction for one of the largest openCV modules is a good reason to increase the merge priority of my pull request.
Regards,
Andrey

sorry for delay! :+1:


Unable to login user from a different app

After using your code I encountered an issue with passport local authentication policy where I have registered a user on one express site but when I try to login the same user from a different app/site it seems not possible.
Tried also creating a user in the second app with the same result, i.e. not able to authenticate the new user in the first express app.
Is this a feature or am I missing something?

What do you mean by a different app/site? You probably would want to use  tokens for this instead.

It's like I have two different deployments, completely different express apps based on your code as a starting point and wanted to have them pointing to the same database/schema etc... for authenticating the same list of users. That's where I got problems mentioned above.
Not sure I understand what you mean by "use tokens" but it sure looks like a limitation with passport-local-mongoose or some other middleware.
Any further pointers would be greatly appreciated
Thanks

Yes, I wouldn't use passport-local-mongoose in that case. Use this instead -> https://github.com/mjhea0/passport-testing


[#1317] Delegate getResultStream method in Query interfaces

Description

Related Issue
Fixes #1317
Perhaps #254 as well

Motivation and Context

@beikov do you want to add the method to Fetchable as well?

@beikov do you want to add the method to Queryable as well?

Good question, I think we should, yes. Do you happen to have Java 7 installed to check if this all still runs on Java 7?

Do you happen to have Java 7 installed to check if this all still runs on Java 7?

I do have Java 7, but do we have an example project that compiles against 7?

Do you happen to have Java 7 installed to check if this all still runs on Java 7?

I do have Java 7, but do we have an example project that compiles against 7?

Quickstart? 😆

Let's give it a shot

Nice work, thanks!


login issue with v1.7 beta 51, cannot roll back to beta 50

Prerequisite

[X] Yes, I've read the readme completely.

Cache

[X] Yes, I've cleaned accessory cache and the issue still exists.

Version
1.7.0-beta51
Device Infomation JSON File
No response
Device Control Mode
None
Logs
[10/7/2023, 12:11:54 PM] [@0x5e/homebridge-tuya-platform] Login failed. code=1013, msg=request time is invalid

Other Infomations
this seems to be new to this version. all prev 1.7 betas were fine.
only option was to rollback to v1.6 for now

can we close this?  I retried a few hours later and it logged in. no changes in the VM where this runs... odd... but it consistently failed on this when I made the report.
fun stuff.

close

thanks

the tuya api request requires correct system time, if your system time is wrong then it will failed.

Yeah, of course I checked that first, as well as the time zone offset displayed in the homebridge status page first. These were fine.So I don’t really know what the cause was, or the fix to be honest.On Oct 8, 2023, at 06:18, gaosen @.***> wrote:
the tuya api request requires correct system time, if your system time is wrong then it will failed.
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you modified the open/close state.Message ID: @.***>

well, that's weird... if you can reproduce it, please enable homgbridge debug mode, copy the whole tuya network request & response, paste here and also submit a ticket on tuya platform.


Add windows nodes to the existing k8s cluster

I have an existing kubernetes cluster. Is there a way to add Windows nodes into the existing cluster, as I would like to start experimenting with Windows workloads.
Can I re-apply a new template, i.e. this one https://github.com/Azure/acs-engine/blob/master/examples/windows/kubernetes.json , to en existing deployment?
If I try to add the windows part to apimodel.json, and run acs-engine against an updated file, I am getting  Orchestrator Kubernetes does not support Windows. This probably means I need to update to a more recent codebase. Can I then re-build acs-engine and apply it to a previosly generated apimodel.json? Or I need to make a backup and re-create the whole cluster from scratch?

It is best if you create the whole cluster from scratch and use the latest acs-engine.
If you are unable to, here is one approach:

update acs-engine
using the api model in the output directory that was created with this cluster, add a windows agent pool. (note that the original api model in the output directory is required because it contains the necessary key information).
generate the new template.
before deploying remove the master VM and other agent vm resources, so that only the new resources are put.

Closing since this is covered by adding an agent pool with Windows.


Unclear if it's possible to decode a token in string form from the docs

Is it possible to do that using this library? Seems it was in an earlier version.
If there is, maybe you could write it a bit like the ruby-jwt docs. Encode and then decode scenarios.

Yes it is possible
import Joken

my_string_token = "some_token"

my_verified_token_struct = token(my_string_token)
|> with_signer(hs256("my_secret"))
|> verify

From there you can get the claims from my_verified_token_struct either directly or through the helper functions


Versal DPU B64 performance

I was very excited to see the release of Vitis-AI 2.0, especially the new DPUCVDX8G variants that double the number of AIE cores used per batch. I benchmarked them using XVDPU-TRD on a VCK190-ES board, and unfortunately the performance of the C64 variants is underwhelming.
I used cf_resnet50_imagenet_224_224_7.7G for the tests. I got 1436 FPS on C32B3, which is in line with the 1419 FPS listed in the Model-Zoo performance chart for the VCK190. The performance gains moving from C32 to C64 are only about 30% for B1-B4, and 21% for B5. The table below shows the measured FPS for all configurations.

C32
C64
speedup

B1
482
627
30.1%

B2
962
1244
29.3%

B3
1436
1861
29.6%

B4
1912
2477
29.6%

B5
2241
2717
21.2%

B6
2846
-
-

Meanwhile PG389 Table 2 shows that the theoretical performance is doubled when using C64 instead of C32. I know that these numbers don't necessarily translate to the real world, but the difference seems too big to me.
Is this behavior expected? What could be the bottleneck in the system?

Hi @ksstms
Thanks for your kindly feedback!
Your test results are expected. The doubled theoretical performance from C64 is at the channel dimension. So those small-channel layers will not be benefit from the C64 design, and this will drop the total efficiency.

Hi @ksstms
Yes, the performance gain is model-dependent on the DPUCVDX8G design on vck190 board.
The varies of DPU designs focus on different goals. As introduced in the figure 3 in page 8 of UG1414 , the "G" in the name of DPUCVDX8G refers to "General Propose", and the "H" in the name of DPUCVDX8H refers to "High Throughput"

Thank you for the explanation.
I see that the DPUCVDX8H's XO files are available in this repo. Is it possible to implement them on the VCK190? I couldn't find the arch.json files for them, so I guess I wouldn't be able to build custom models for those. Are these available to VCK5000 customers only?

Hi @ksstms
The DPUCVDX8G's IP and DPUCVDX8H's XO series files are all designed for vc1902 chip, which means for all the boards implementing the chip, including VCK190 and VCK5000. so the different files are the platform and the vitis scripts. You could generate your custom platform on your customized pcb board.
DPUCVDX8H's XO series' configurations are fixed. so there is no arch.json file for them to reconfigure,
To build custom models for DPUCVDX8H on VCK5000, you can try with their related target name listed in targets, eg DPUCVDX8H_ISA1_F2W2_8PE or DPUCVDX8H_ISA1_F2W4_6PE_aieDWC


Prompts

Prompts
User Story
AS A developer
I WANT a README generator
SO THAT I can quickly create a professional README for a new project
Acceptance Criteria
GIVEN a command-line application that accepts user input
WHEN I am prompted for information about my application repository
THEN a high-quality, professional README.md is generated with the title of my project and sections entitled Description, Table of Contents, Installation, Usage, License, Contributing, Tests, and Questions

Prompts created for each section of README


How do you remove everything from a collection?

I can't seem to find a way to empty a collection. How do I remove a collection's contents so I can add new things to it without conflict.

One database equals one collection. Clearing everything would be:
db.remove({}, { multi: true }, function (err, numRemoved) {

});

Not sure how I missed that in the docs. Thanks!

I'd suggest closing this issue ;)

Right


added offline password manager application

| worked on     |    #56    |
Description
Added a OFFLINE password manager with a simple GUI with login functionalities and database support implemented with sqlite3.
Type of change

[✅ ] New project (non-breaking change which adds functionality)

How Has This Been Tested?
1.run the setup.py file first, and enter the email and set up the password
2.next run the passwordapp.py and login with the password
3.After that u can save your passwords.
Checklist:

[✅ ] My code follows the style guidelines of this project
[✅ ] I have performed a self-review of my own code
[✅ ] I have commented my code, particularly in hard-to-understand areas
[✅ ] I have included a README.md file
[✅ ] My project follows this structure: Domain Folder/ Project Name Folder/ Project files and Readme.md files
[ ✅] I have added demonstration in the form of GIF/video file
[ ✅] I am a GSSoC'22 Participant

code walkthrough as in do u want me to record the code and files??? or to record a video from start to finish as to how will use the app?

code walkthrough as in do u want me to record the code and files??? or to record a video from start to finish as to how will use the app? @heet-kumar

small code-walkthrough include code and files which you have added and then followed by start to finish use of the app.

@Phoenix-031 Bonus for you level changed from 2 -> 3. Amazing Work Done.

@heet-kumar  thankyou glad i could contribute😀😀.


How to add @Distance in yaml  mapping file?

Hi,
How I can add @Distance  in yaml mapping file ? I tried it and not works.
  type: embeddedDocument
  embedOne:
    address:
      targetDocument: CP\AppBundle\Document\Address
    coordinates:
      targetDocument: CP\AppBundle\Document\Coordinates
  distance: distance
  indexes:
    coordinates:
      keys:
        coordinates: 2d

(edit @alcaeus): wrapped mapping in code tags for readability

hi @jwage,
Do you know if @Distance works with yaml mapping ?
Thanks

Have you tried this?
CP\AppBundle\Document\Point:
  type: embeddedDocument
  fields:
    distance:
      distance: true
  embedOne:
    address:
      targetDocument: CP\AppBundle\Document\Address
    coordinates:
      targetDocument: CP\AppBundle\Document\Coordinates
  indexes:
    coordinates:
      keys:
        coordinates: 2d

You have to specify a field which will store the distance and mark that with distance: true

Thanks, it works.

This does not work for me, I get an "undefined index: type" error message.

@rickogden from error it seems like you are missing "type" in your mapping.

@malarzm: What should the type be set to for a distance field? I was thinking that type wasn't specified for the distance field as it's dynamically generated.

@rickogden are you sure the error is related with distance?

@malarzm: solved it. It needs to be:
fields:
    distance:
      distance: true
      type: float


Disable code coverage unless COVERAGE=true passed to build

Code coverage is used only occasionally, and typically from specific
freestyle jobs which report the coverage through graphs and annotated
source code.
Don't spend time or energy instrumenting for coverage when it won't be
used.
@reviewbybees

This pull request originates from a CloudBees employee. At CloudBees, we require that all pull requests be reviewed by other CloudBees employees before we seek to have the change accepted. If you want to learn more about our process please see this explanation.

Thanks for the suggestion in the matching git plugin pull request (use the parent pom).  That will make this pom simpler and still provide coverage reporting


Updated auth info in readme

Hi boopt2,
Thanks for submitting this pull request!
Please add a comment with a DCO1.1 Signed-off-by statement in order to allow us to process your pull request.
dco-bot