dt_ref setting problem

Here are two dt_ref related issues.（Sorry this is my first time using this feature, and my native language is not English, thank you all.）
First of all, when dt_ref is 0.02, the vehicle released by teb cannot move forward normally and will be stuck in place. If it is moved by other path tracking algorithms (such as mpc), a long reverse trajectory will appear.

Here are the parameters where this happens：
TebLocalPlannerROS:
odom_topic: /odom #/odometry/filtered
Trajectory
teb_autosize: True
dt_ref: 0.02
dt_hysteresis: 0.01
global_plan_overwrite_orientation: True
allow_init_with_backwards_motion: False
max_global_plan_lookahead_dist: 4
feasibility_check_no_poses: 0
#global_plan_viapoint_sep: 1
Robot
max_vel_x: 5
max_vel_x_backwards: 0.0000000001 #0.2
max_vel_y: 0
max_vel_theta:  3 #0.3 # the angular velocity is also bounded by min_turning_radius in case of a carlike robot (r = v / omega)
acc_lim_x: 30
acc_lim_y: 0
acc_lim_theta: 20
********************** Carlike robot parameters ********************
min_turning_radius: 0.73     # Min turning radius of the carlike robot (compute value using a model or adjust with rqt_reconfigure manually)
wheelbase: 0.34                # Wheelbase of our robot
cmd_angle_instead_rotvel: True # stage simulator takes the angle instead of the rotvel as input (twist message)
********************************************************************
footprint_model: # types: "point", "circular", "two_circles", "line", "polygon"
type: "line"
radius: 0.2 # for type "circular"
line_start: [0.0, 0.0] # for type "line"
line_end: [0.34, 0.0] # for type "line"
front_offset: 0.2 # for type "two_circles"
front_radius: 0.2 # for type "two_circles"
rear_offset: 0.2 # for type "two_circles"
rear_radius: 0.2 # for type "two_circles"
vertices: [ [-0.075,-0.17], [0.415,-0.17], [0.415,0.17], [-0.075,0.17] ]# for type "polygon"
#is_footprint_dynamic: True
#obstacle_association_force_inclusion_factor: 5
#legacy_obstacle_association: True
#switching_blocking_period: 10
GoalTolerance
xy_goal_tolerance: 0.5
yaw_goal_tolerance: 3
free_goal_vel: False
Obstacles
inflation_dist: 0.5
weight_inflation: 10
min_obstacle_dist:  0.27 #0.27 # This value must also include our robot's expansion, since footprint_model is set to "line".
include_costmap_obstacles: True
costmap_obstacles_behind_robot_dist: 1.0
obstacle_poses_affected: 60
costmap_converter_plugin: ""
costmap_converter_spin_thread: True
costmap_converter_rate: 20
Optimization
no_inner_iterations: 5
no_outer_iterations: 4
optimization_activate: True
optimization_verbose: False
penalty_epsilon: 0.0000000001 #0.1
weight_max_vel_x: 10000000
weight_max_vel_theta: 1
weight_acc_lim_x: 1
weight_acc_lim_theta: 1
weight_kinematics_nh: 1000
weight_kinematics_forward_drive: 1000
weight_kinematics_turning_radius: 1
weight_optimaltime: 5 #nice!!!
weight_obstacle: 1000
weight_dynamic_obstacle: 10 # not in use yet
#weight_viapoint: 2
Homotopy Class Planner
enable_homotopy_class_planning: False
enable_multithreading: True
simple_exploration: False
max_number_classes: 2
selection_cost_hysteresis: 1.0
selection_obst_cost_scale: 1.0
selection_alternative_time_cost: False
roadmap_graph_no_samples: 15
roadmap_graph_area_width: 5
h_signature_prescaler: 0.5
h_signature_threshold: 0.1
obstacle_keypoint_offset: 0.1
obstacle_heading_threshold: 0.45
visualize_hc_graph: False
force_reinit_new_goal_dist: 1
The second problem is that when dt_ref is 0.1, if the speed is set to 5m / s, the planned path will sometimes pass through obstacles, and the curve will become like a polyline.However, after a period of time, it will stretch back to the path that does not pass through the obstacle, but this period is too long.

Here are the parameters where this happens：
TebLocalPlannerROS:
odom_topic: /odom #/odometry/filtered
Trajectory
teb_autosize: True
dt_ref: 0.1
dt_hysteresis: 0.01
global_plan_overwrite_orientation: True
allow_init_with_backwards_motion: False
max_global_plan_lookahead_dist: 4
feasibility_check_no_poses: 0
#global_plan_viapoint_sep: 1
Robot
max_vel_x: 5
max_vel_x_backwards: 0.0000000001 #0.2
max_vel_y: 0
max_vel_theta:  3 #0.3 # the angular velocity is also bounded by min_turning_radius in case of a carlike robot (r = v / omega)
acc_lim_x: 30
acc_lim_y: 0
acc_lim_theta: 20
********************** Carlike robot parameters ********************
min_turning_radius: 0.73     # Min turning radius of the carlike robot (compute value using a model or adjust with rqt_reconfigure manually)
wheelbase: 0.34                # Wheelbase of our robot
cmd_angle_instead_rotvel: True # stage simulator takes the angle instead of the rotvel as input (twist message)
********************************************************************
footprint_model: # types: "point", "circular", "two_circles", "line", "polygon"
type: "line"
radius: 0.2 # for type "circular"
line_start: [0.0, 0.0] # for type "line"
line_end: [0.34, 0.0] # for type "line"
front_offset: 0.2 # for type "two_circles"
front_radius: 0.2 # for type "two_circles"
rear_offset: 0.2 # for type "two_circles"
rear_radius: 0.2 # for type "two_circles"
vertices: [ [-0.075,-0.17], [0.415,-0.17], [0.415,0.17], [-0.075,0.17] ]# for type "polygon"
#is_footprint_dynamic: True
#obstacle_association_force_inclusion_factor: 5
#legacy_obstacle_association: True
#switching_blocking_period: 10
GoalTolerance
xy_goal_tolerance: 0.5
yaw_goal_tolerance: 3
free_goal_vel: False
Obstacles
inflation_dist: 0.5
weight_inflation: 10
min_obstacle_dist:  0.27 #0.27 # This value must also include our robot's expansion, since footprint_model is set to "line".
include_costmap_obstacles: True
costmap_obstacles_behind_robot_dist: 1.0
obstacle_poses_affected: 60
costmap_converter_plugin: ""
costmap_converter_spin_thread: True
costmap_converter_rate: 20
Optimization
no_inner_iterations: 5
no_outer_iterations: 4
optimization_activate: True
optimization_verbose: False
penalty_epsilon: 0.0000000001 #0.1
weight_max_vel_x: 10000000
weight_max_vel_theta: 1
weight_acc_lim_x: 1
weight_acc_lim_theta: 1
weight_kinematics_nh: 1000
weight_kinematics_forward_drive: 1000
weight_kinematics_turning_radius: 1
weight_optimaltime: 5 #nice!!!
weight_obstacle: 1000
weight_dynamic_obstacle: 10 # not in use yet
#weight_viapoint: 2
Homotopy Class Planner
enable_homotopy_class_planning: False
enable_multithreading: True
simple_exploration: False
max_number_classes: 2
selection_cost_hysteresis: 1.0
selection_obst_cost_scale: 1.0
selection_alternative_time_cost: False
roadmap_graph_no_samples: 15
roadmap_graph_area_width: 5
h_signature_prescaler: 0.5
h_signature_threshold: 0.1
obstacle_keypoint_offset: 0.1
obstacle_heading_threshold: 0.45
visualize_hc_graph: False
force_reinit_new_goal_dist: 1

why enable_homotopy_class_planning:false ? If you use optimal planner,there will be only one choice, which is not reasonable if you can have more.
By the way, the weights also need to be adjusted.


Bug fix: prevent KCL error due to colliding AST execution on project switch

Currently in the desktop app, if you navigate to a project and then switch to another one, even valid code will show a KCL error at first. This error is due to colliding partial executions of the KCL code, and goes away after the code is updated.
Here is my call stack investigation notes of this bug:

kclManager.executeCode is run by the XState action "Execute AST"
"Execute AST" is fired as a result of three events in settingMachine:
set.modeling.defaultUnit: whenever the default unit setting is updated
Reset settings: whenever the user resets to the default settings
Set all settings: whenever all of the settings are overwritten at once
The "Set all settings" event is fired by the useRefreshSettings hook, which is used in these two places:
App.tsx:31
Home.tsx:46

The reason we need this hook is so that the latest settings get loaded as we navigate around, but the doc comment I left on it said it was an annoying workaround.
My fix was to make "Execute AST" only really fire if defaultUnits was being changed. This revealed another race between various calls to play() and pause() of the stream on page load, which was covered up by overriding conditions with the previous race. I have handled errors that occur due to that by logging a warning for us to clean up in the future, as it doesn't catastrophically damage user experience for now, and seems to have been a longer-standing issue.
Note: I haven't been able to test this with a prod desktop build
I would like help from anyone who can produce a working desktop build of the app. My runs of yarn tauri build have not been successful lately, even on the main branch, so I have only the behavior of yarn tauri dev to go on at the moment.

after we have thee electron app, we can add a test where we go to a project and export the file and see the file is valid and not double the side basically
electron tests
tauri tests
(for search visibility later)


use without a webserver

I have requirement to display query plan as HTML page(Without a web server). How can do that with this code?

See the upload example for a page which uses a file "upload":
https://github.com/JustinPealing/html-query-plan/blob/master/examples/upload.html
(Note that the file is not actually uploaded - the data is processed in the JavaScript).

See the upload example for a page which uses a file "upload":
https://github.com/JustinPealing/html-query-plan/blob/master/examples/upload.html
(Note that the file is not actually uploaded - the data is processed in the JavaScript).

Thanks ...


.Values.replicas should be independently set for each service

The number replicas should be configurable independently for each service, i.e. drop .Values.replicas and then have .Values.services.$service.replicas for each $service we deploy.
Random thoughts:

I think it is fine to make this a breaking change and not do another layer of defaults/ifs in the templates to make sure it does work with .Values.replicas being set
this would also be more consistent with most other major helm charts
the progress of #15 would then also be reflected in the values file, as a non-scalable service would not have replicad field, making it a little bit more self-documented

Well, that is what I meant with the first point, I do not really think a global setting is useful enough to warrant the added complexity in the helm chart.
I also expect some components like nats to require quorum, so just having one large replica setting might also invite configuration accidents, and I guess most components do not need to scale beyond HA, whereas proxy and frontend probably need quite a few more replicas in most settings.
I think I would even argue that a global setting is kinda useless for resources as well, but having good defaults there might be more tricky than replicas: 1 for each service.

I also expect some components like nats to require quorum

The builtin NATS does not support scaling / clustering. Therefore we have an example with an external NATS cluster. Currently you also need to ensure settings replicas for NATS streams, that's why we recently added NACK to the example to achieve this. See: https://github.com/owncloud/ocis-charts/tree/master/deployments/ocis-nats
There are no other components that have something like a quorum.
But other components that cannot be scaled beyond one replica and should be replaced by external scalable / HA components if needed (IDM = LDAP, IDP = OIDC Provider -> see: https://github.com/owncloud/ocis-charts/tree/master/deployments/external-user-management). Other components are not yet scalable and tracked here: #15

so just having one large replica setting might also invite configuration accidents, and I guess most components do not need to scale beyond HA, whereas proxy and frontend probably need quite a few more replicas in most settings.

I totally get your point and agree that we should offer a replica setting per service.
I guess we should have the following logic when it comes to replicas / HPA settings:

apply global replicas setting to service if no global / service-specific HPA / service-specific replicas is set
apply service-specific replicas setting to service if no service-specific HPA is set
apply global HPA setting to service if no service-specific replicas / HPA is set
apply service-specific HPA setting to service if service-specific HPA is set

In short: service-specific setting wins. And HPA wins over the replicas setting when it has the same specifically (global / service-specific).

I think I would even argue that a global setting is kinda useless for resources as well, but having good defaults there might be more tricky than replicas: 1 for each service.

We have this because many service have a similar low need for resources and they can be configured together in this way. But still it's true that you need to check if resources are set correct in the end.


[Bug]: Custom testEnvironment in TypeScript is not transformed with ESM

Version
29.7.0
Steps to reproduce
Original reported at https://github.com/kulshekhar/ts-jest/issues/4195
Expected behavior
The custom testEnvironment in TypeScript should be passed to processAsync so ts-jest can properly transform it
Actual behavior
Debugging ts-jest and I found out that the custom testEnvironment in TypeScript is passed to process instead of processAsync. This makes ts-jest to transform into CJS.
Additional context
The issue is with this line https://github.com/jestjs/jest/blob/4e56991693da7cd4c3730dc3579a1dd1403ee630/packages/jest-runner/src/runTest.ts#L109
Environment
System:
    OS: macOS 14.6.1
    CPU: (12) arm64 Apple M3 Pro
  Binaries:
    Node: 20.16.0 - /opt/homebrew/opt/nvm/versions/node/v20.16.0/bin/node
    Yarn: 1.22.22 - /opt/homebrew/opt/nvm/versions/node/v20.16.0/bin/yarn
    npm: 10.8.1 - /opt/homebrew/opt/nvm/versions/node/v20.16.0/bin/npm
    pnpm: 9.5.0 - /opt/homebrew/opt/nvm/versions/node/v20.16.0/bin/pnpm
  npmPackages:
    jest: ^29.7.0 => 29.7.0

@SimenB if you can shine me a bit how to fix it, I can make a PR :)

I think I see the path @SiemenB is referencing while exploring the same issue.
The code he references is called to load the TestEnvironment and then calls this:
https://github.com/jestjs/jest/blob/4e56991693da7cd4c3730dc3579a1dd1403ee630/packages/jest-transform/src/ScriptTransformer.ts#L773
That ultimately calls back to:
https://github.com/jestjs/jest/blob/4e56991693da7cd4c3730dc3579a1dd1403ee630/packages/jest-transform/src/ScriptTransformer.ts#L792
Which ultimately calls process:
https://github.com/jestjs/jest/blob/4e56991693da7cd4c3730dc3579a1dd1403ee630/packages/jest-transform/src/ScriptTransformer.ts#L516
Although there is a check during loadTransformers to ensure that the transformer exposes process or processAsync to make sure it's valid, I'm not seeing a path through the code which would call processAsync for this case.

Issue is still present

Still an issue.


Hello_Microverse

Create a new GitHub repo.

Add a file..gitignore

Add to gitignore file.node_modules

Add descriptive README file to your project -

the text "Hello Microverse!"

present in your GitHub repository.
Open a pull request.

hello good evening I do not understand the changes required previously I was told not to delete anything in the README and now I am asked to delete it I do not know if you do not agree to receive the work I would like to meet with you to review the arrangements thank you
De: Olaoye Oluwatoyin Abayomi @.>
Enviado el: miércoles, 12 de julio de 2023 13:44
Para: Gatofrances123/Hello_Microverse @.>
CC: Gatofrances123 @.>; Mention @.>
Asunto: Re: [Gatofrances123/Hello_Microverse] Update linters.yml (PR #1)
@AbayomiOlaoye requested changes on this pull request.
STATUS: CHANGE REQUIRED ♻
Hi @Gatofrances123https://github.com/Gatofrances123 👋 👋 ,
Good job with this milestone so far! What a brilliant attempt!!
There are just a few more issues to work on before moving on to the next project but you are almost there!
[so_close]https://camo.githubusercontent.com/0c690ab997907a8c79afe7e695c891f6398cdbef93eaf8ce19f652ff321b54f8/68747470733a2f2f6d656469612e67697068792e636f6d2f6d656469612f744b797263304e546c4563475764546870342f67697068792e676966
Highlights

No linter error ✔
Descriptive ReadMe documentation ✔

Required Changes ♻

Check the comments below:
[ ] First off, please mind the project requirement to always create a separate branch for the project implementations so that code reviewers can have access to all your changes and be able to provide you with concise and clear suggestions using inline comments
[ ] Kindly check the snapshot below:
[image]https://user-images.githubusercontent.com/99715640/253062807-dd164b4f-3113-4878-98ae-82f6e0bc6eb1.png
*   [ ] It is important that your Table of Contents matches the content in the body of the README so that users don't get confused about missing something. Since you do not have a deployed link for this exercise and it's even good that you didn't add it to your body. Kindly remove the circled links - also because you do not have a FAQs in the body of your README.
[ ] On following professional Gitflow and repo documentation:
[image]https://user-images.githubusercontent.com/99715640/253063689-fb8b3132-f154-4657-9966-7ecfb45d342e.png
*   [ ] A quick look at the above, you discover that your pull request title does not say anything about the project requirements to which you are proposing an implementation other than linters. Here is a good example or PR title 👇

[pull_request_desc]https://user-images.githubusercontent.com/99715640/253064708-d0f61f8a-af19-4b9c-9337-90cebca993c5.gif
Kindly notice how the title summarises the whole changes in the submitted files and make yours appear same

[ ] Another thing you will notice in that image from your PR is the branch name, how it is not really descriptive in relevance to your work. For example, it could be named setup_branch, or implement_hello, etc. 😄
[ ] Lastly, we examine your commit histories:
[image]https://user-images.githubusercontent.com/99715640/253066723-ba6bb7b1-bda5-4429-820a-c2d17398dcfc.png
*   [ ] Commits are like snapshots of your code lath allows you to save different versions for ease of debugging, history vetting, managing your files, or restoring to desire previous states of your code. This is why it is important that you:

[ ] Commit often when an obvious change has been implemented in your codebase. In this case, for example, committing to each project requirement implementation would be a good habit of saving your project versions at any point in time.
[ ] Secondly, like other points on PR title and branch name, each commits are professional and more helpful to you if they are descriptive, concise, and written in their present forms as actionable steps like Add index.html to file directory, Apply styling on the main heading, etc as demonstrated here 👇

[image]https://user-images.githubusercontent.com/99715640/253068679-b3d72319-232b-4e3e-9bfa-b140d8fe074d.png
Optional suggestions
Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you take them into account as they can make your code better.
Cheers, and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.

As described in the Code reviews limits policyhttps://microverse.zendesk.com/hc/en-us/articles/1500004088561 you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this formhttps://airtable.com/shrQAqnBwek5a0O0s.
—
Reply to this email directly, view it on GitHubhttps://github.com/Gatofrances123/Hello_Microverse/pull/1#pullrequestreview-1527035699, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AQCDOA5XEGN7KMI4HQYKQDLXP3V6ZANCNFSM6AAAAAA2HX6VAE.
You are receiving this because you were mentioned.Message ID<EMAIL_ADDRESS>

No, I think that's clear in itself. FAQs has that optional as you can see.
And about not deleting anything, how do explain including something in the
table of contents - sub headings which is like an introduction of what
features to look out for, only not to include it in the body of the text.
It's bad for user experience. So, if want to retain them, you need to add
their contents.
Let me know if you have any questions
On Thu, 13 Jul 2023, 05:28 Gatofrances123, @.***> wrote:

hello good evening I do not understand the changes required previously I
was told not to delete anything in the README and now I am asked to delete
it I do not know if you do not agree to receive the work I would like to
meet with you to review the arrangements thank you
De: Olaoye Oluwatoyin Abayomi @.>
Enviado el: miércoles, 12 de julio de 2023 13:44
Para: Gatofrances123/Hello_Microverse @.>
CC: Gatofrances123 @.>; Mention @.>
Asunto: Re: [Gatofrances123/Hello_Microverse] Update linters.yml (PR #1)
@AbayomiOlaoye requested changes on this pull request.
STATUS: CHANGE REQUIRED ♻
Hi @Gatofrances123https://github.com/Gatofrances123 👋 👋 ,
Good job with this milestone so far! What a brilliant attempt!!
There are just a few more issues to work on before moving on to the next
project but you are almost there!
[so_close]<
https://camo.githubusercontent.com/0c690ab997907a8c79afe7e695c891f6398cdbef93eaf8ce19f652ff321b54f8/68747470733a2f2f6d656469612e67697068792e636f6d2f6d656469612f744b797263304e546c4563475764546870342f67697068792e676966>
Highlights

No linter error ✔
Descriptive ReadMe documentation ✔

Required Changes ♻

Check the comments below:

[ ] First off, please mind the project requirement to always create a
separate branch for the project implementations so that code reviewers can
have access to all your changes and be able to provide you with concise and
clear suggestions using inline comments

[ ] Kindly check the snapshot below:
[image]<
https://user-images.githubusercontent.com/99715640/253062807-dd164b4f-3113-4878-98ae-82f6e0bc6eb1.png>

[ ] It is important that your Table of Contents matches the content in
the body of the README so that users don't get confused about missing
something. Since you do not have a deployed link for this exercise and it's
even good that you didn't add it to your body. Kindly remove the circled
links - also because you do not have a FAQs in the body of your README.

[ ] On following professional Gitflow and repo documentation:
[image]<
https://user-images.githubusercontent.com/99715640/253063689-fb8b3132-f154-4657-9966-7ecfb45d342e.png>

[ ] A quick look at the above, you discover that your pull request title
does not say anything about the project requirements to which you are
proposing an implementation other than linters. Here is a good example or
PR title 👇

[pull_request_desc]<
https://user-images.githubusercontent.com/99715640/253064708-d0f61f8a-af19-4b9c-9337-90cebca993c5.gif>
Kindly notice how the title summarises the whole changes in the submitted
files and make yours appear same

[ ] Another thing you will notice in that image from your PR is the
branch name, how it is not really descriptive in relevance to your work.
For example, it could be named setup_branch, or implement_hello, etc. 😄

[ ] Lastly, we examine your commit histories:
[image]<
https://user-images.githubusercontent.com/99715640/253066723-ba6bb7b1-bda5-4429-820a-c2d17398dcfc.png>

[ ] Commits are like snapshots of your code lath allows you to save
different versions for ease of debugging, history vetting, managing your
files, or restoring to desire previous states of your code. This is why it
is important that you:

[ ] Commit often when an obvious change has been implemented in your
codebase. In this case, for example, committing to each project requirement
implementation would be a good habit of saving your project versions at any
point in time.

[ ] Secondly, like other points on PR title and branch name, each
commits are professional and more helpful to you if they are descriptive,
concise, and written in their present forms as actionable steps like Add
index.html to file directory, Apply styling on the main heading, etc as
demonstrated here 👇

[image]<
https://user-images.githubusercontent.com/99715640/253068679-b3d72319-232b-4e3e-9bfa-b140d8fe074d.png>
Optional suggestions
Every comment with the [OPTIONAL] prefix is not crucial enough to stop the
approval of this PR. However, I strongly recommend you take them into
account as they can make your code better.
Cheers, and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something
is not 100% clear.
Please, remember to tag me in your question so I can receive the
notification.
Please, do not open a new Pull Request for re-reviews. You should use the
same Pull Request submitted for the first review, either valid or invalid
unless it is requested otherwise.

As described in the Code reviews limits policy<
https://microverse.zendesk.com/hc/en-us/articles/1500004088561> you have
a limited number of reviews per project (check the exact number in your
Dashboard). If you think that the code review was not fair, you can request
a second opinion using this formhttps://airtable.com/shrQAqnBwek5a0O0s.
—
Reply to this email directly, view it on GitHub<
https://github.com/Gatofrances123/Hello_Microverse/pull/1#pullrequestreview-1527035699>,
or unsubscribe<
https://github.com/notifications/unsubscribe-auth/AQCDOA5XEGN7KMI4HQYKQDLXP3V6ZANCNFSM6AAAAAA2HX6VAE>.
You are receiving this because you were mentioned.Message ID:
<EMAIL_ADDRESS>—
Reply to this email directly, view it on GitHub
https://github.com/Gatofrances123/Hello_Microverse/pull/1#issuecomment-1633526969,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AXYYUODW4PHKE4IRFKRSANDXP52PFANCNFSM6AAAAAA2HX6VAE
.
You are receiving this because you were mentioned.Message ID:
@.***>

Hello, thank you, then it would be like this correctly?
@.***
De: Nicolae Pop @.>
Enviado el: jueves, 13 de julio de 2023 10:07
Para: Gatofrances123/Hello_Microverse @.>
CC: Gatofrances123 @.>; Mention @.>
Asunto: Re: [Gatofrances123/Hello_Microverse] Hello_Microverse (PR #1)
@nicupop729 commented on this pull request.
Hello @Gatofrances123https://github.com/Gatofrances123 👋,
This is an additional review as a result of the second opinion request.
Congratulations for your effort in this milestone! 👏
The only change you brought in this branch is that you moved a line of code in the linters file from row 56 to row 57. From this project onward, altering the linters file will bring automatic invalidation of the project.
Also, from this project on, let's please try to build the requirements of the project in a feature branch and not into main branch. For each milestone, we need to work on a new feature branch.
From the next project, it's recommended to have good commit names, descriptive names for the feature branches, and descriptive titles for the Pull Request, in order to follow the good practices and to document our repository in a professional manner.
In order to proceed to the next milestone, kindly implement the following aspects:

[ ] As mentioned by the previous reviewer, let's please remove the Live Demo and the FAQ (OPTIONAL) links from the README for a better user experience.

Keep rocking 🚀!
—
Reply to this email directly, view it on GitHubhttps://github.com/Gatofrances123/Hello_Microverse/pull/1#pullrequestreview-1528677311, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AQCDOAYVWCY7N346ASGDRADXQAFK7ANCNFSM6AAAAAA2HX6VAE.
You are receiving this because you were mentioned.Message ID<EMAIL_ADDRESS>


[WIP] Add draft support for binary fixed width files

This pull request starts down the path of supporting reading DataFrames from fixed-width files. The current implementation is a barebones implementation of something like R's scan() function. I still need to write a version that reads fixed-width files in which all entries are plain-text and need type inference.
Eventually I'd like to move all of our I/O tools into a separate I/O package. But for now I'd just like to get this tool written.
Please bikeshed the names readfwfbin and writefwfbin. I don't like the name scan, but we can definitely do better than the names I've chosen so far.

@johnmyleswhite Is this still relevant or should it be closed?

I think this is fine to close.


Clear character dropdowns

Having no character or variant selected is valid, but once a character or variant is selected the dropdowns cannot be cleared.

Added clear buttons for these.


modify fusedrope for llama

fix nan issue in trl training for llama

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.


Reorganize Menu Items

I'd like to add some consistency to the Griptape RMB menu.

Here's the current re-order - let me know what you think

That breaks it all up based on agent tasks/etc.. I could also go media-type menu items, so group all image things, then group audio things, group text things, then utils for merging/converting..
but then for things like loading and saving, do those go in the media-based menus, or would they go in a file menu?

The other option would be something like:
Agent
* Create: Agent
* Create: Agent from Config
* Run: Agent

Agent Configs
* Agent Config: Custom Structure
* -----------------------------------
* Agent Config: Anthropic
* Agent Config: Azure OpenAI
* (etc)

Agent Drivers
* Prompt >
* Image Generation >
* Embedding >
* Vector Store >
* Text to Speech >
* Audio Transcription >
* Web Search >

Agent Rules
* Create: Rules
* Combine: Rules
* Replace: Rules on Agent

Agent Tasks
* Run: Prompt Task
* Run: Tool Task
* Run: Toolkit Task

Agent Tools
* Convert: Agent to Tool
* -----------------------------
* Tool: Audio Transcription
* Tool: Calculator
* Tool: Date Time
* (etc)

Agent Utilities
* Expand: Agent Nodes
* Set: Default Agent
* ------------------------------
* Combine: Rules
* Combine: Tool List
* ------------------------------
* Replace: Rulesets on Agent
* Replace: Tools on Agent

--------------------------------

Display
* Display Image
* Display Text
* Display Data as Text

--------------------------------

Audio
* Run: Audio Transcription
* Run: Text to Speech
* ------------------------------
* Load: Audio

Image
* Run: Create Image from Text
* Run: Create Image Variation from Text
* Run: Image Description
* Run: Parallel Image Description
* ------------------------------
* Load: Image from URL

Text
* Run: Text Summary
* ------------------------------
* Load: Text File
* Load: PDF
* Load: URL
* ------------------------------
* Save: Text File
* ------------------------------
* Vector Store: Add Text
* Vector Store: Query Text

Media Utilities
* Combine: Merge Texts
* Combine: Merge Inputs
* ------------------------------
* Convert: Text to CLIP Encode
* Convert: Text to Combo

as part of this task, I'd also like to try and rename the nodes with a Gt prefix instead of Griptape to keep the names shorter.

Another recommendation was to try and consolidate a bunch of similar nodes & hide/show parameters based on selections. Joviex (in the ComfyOrg Discord) is going to provide an example. This would allow us to do something like:
Agent: Create[Simple|Complex]
Agent: Run [Prompt|Tool(s)|TextSummary]
Vector Store [Add | Query]
--------------------------------------------
Agent Config
Agent Custom Config
Agent Tool [Agent | Calculator | DateTime ...]
Agent Utilities >
* Expand Agent
* Replace [Config | Rules | Tools] on Agent
--------------------------------------------
Prompt Driver
Image Generation Driver
Embedding Driver
Vector Store Driver
Text to Speech Driver
Audio Transcription Driver
Web Search Driver

Just pushed an update with the reordered menu items, without name changes or consolidation yet. Wanted to see if this helps.

done reorganizing for now - can do more later. :)


Not possible to recover the list of videos to download, once added from the gui.

[ x] I think my problem is NOT with youtube-dl
[ x] I've verified and i assure that I'm running youtube-dl-gui 0.4
[x ] I assure that i am using the latest version of youtube-dl
[ ] Searched bugtracker
[ ] I've read the FAQs file

What is the purpose of your issue?

[ ] Bug report
[ ] Feature request (request for a new functionality)
[ x] Question
[ ] Other

Please remove any sections between (---) if they are not related to your issue

What operating system do you use ?
Ubuntu 20.04
List of actions to perform to reproduce the problem:

Paste a list of youtube videos to download.

Add to download, via button.

Something unexpected happens we need to reboot the machine, and since the gui does not provide a way to persist the download list for later use, we want to manually backup that list to download them later.

Manually copying the download list used to be easy in the previous <0.4 version of the gui - as it simply remained present in the upper pane and was not cleared during download, not so with 0.4 where one needs to copy each item line by line.

Feature request (request for a new functionality)
Do you plan to allow an option to save the download list, in case youtubedl-gui needs to be closed?
Please make sure that the requested feature is NOT already in the TODO list

[x] I've verified and i assure that my requested feature is NOT in the TODO list

This project is not being maintained any more. There is a fork here.


refactor: less strict hook callback return type

Proposed changes
allows hook callbacks to call functions that have a return value other than void without wrapping in a closure. E.g. onSuccess: () => toast.success('...') where toast.success returns the toast id. I understand that the return value of the callback isn't used for anything but this allows for slightly cleaner code imo.
Related issue(s) or discussion(s)

[x] I read the contributing guidelines and followed them before creating this pull request.

I understand that the return value of the callback isn't used for anything but this allows for slightly cleaner code imo.

Yep, callbacks are typed void mainly to inform the user that the return value is absolutely not used in any way or form, but I can understand the cleaner code argument, since a one-liner can become a two-liner. However, I don't think that allowing less strict typings will cause bugs in apps, because callbacks behavior is pretty self-explanatory (and documented), so it's ok to merge this, in my opinion. Thank you for your contribution!


Lin HashSet tests shrinking taking very long

We are experiencing runs of Lin HashSet tests that take very long to shrink.
For example https://github.com/ocaml-multicore/multicoretests/actions/runs/4159533572/jobs/7195669682
on Windows trunk took over 4 hours
random seed: 401278811
generated error fail pass / total     time test name

[ ]    0    0    0    0 / 1000     0.0s Lin DSL Weak HashSet test with Domain
[ ]    0    0    0    0 / 1000     0.0s Lin DSL Weak HashSet test with Domain (generating)
[ ]   15    0    0   15 / 1000    62.0s Lin DSL Weak HashSet test with Domain (shrinking:    5.0003)
[ ]   15    0    0   15 / 1000   122.6s Lin DSL Weak HashSet test with Domain (shrinking:    6.0011)
[ ]   15    0    0   15 / 1000   183.4s Lin DSL Weak HashSet test with Domain (shrinking:   10.0002)
[ ]   15    0    0   15 / 1000   244.7s Lin DSL Weak HashSet test with Domain (shrinking:   10.0016)
[ ]   15    0    0   15 / 1000   306.7s Lin DSL Weak HashSet test with Domain (shrinking:   11.0006)
[ ]   15    0    0   15 / 1000   367.9s Lin DSL Weak HashSet test with Domain (shrinking:   13.0008)
[ ]   15    0    0   15 / 1000   429.4s Lin DSL Weak HashSet test with Domain (shrinking:   14.0005)
[ ]   15    0    0   15 / 1000   490.3s Lin DSL Weak HashSet test with Domain (shrinking:   14.0018)
[...]
[ ]   15    0    0   15 / 1000 14545.9s Lin DSL Weak HashSet test with Domain (shrinking:   90.0189)
[ ]   15    0    0   15 / 1000 14610.8s Lin DSL Weak HashSet test with Domain (shrinking:   90.0201)
[ ]   15    0    0   15 / 1000 14675.2s Lin DSL Weak HashSet test with Domain (shrinking:   90.0214)
[ ]   15    0    0   15 / 1000 14738.1s Lin DSL Weak HashSet test with Domain (shrinking:   90.0226)
[ ]   15    0    0   15 / 1000 14800.6s Lin DSL Weak HashSet test with Domain (shrinking:   90.0238)
[ ]   15    0    0   15 / 1000 14863.8s Lin DSL Weak HashSet test with Domain (shrinking:   90.0250)
[✓]   16    0    1   15 / 1000 14890.3s Lin DSL Weak HashSet test with Domain

and https://github.com/ocaml-multicore/multicoretests/actions/runs/4144529287/jobs/7167690602
on Windows 5.0.0 caused a time-out:
random seed: 531710245
generated error fail pass / total     time test name

[ ]    0    0    0    0 / 1000     0.0s Lin DSL Weak HashSet test with Domain
[ ]    0    0    0    0 / 1000     0.0s Lin DSL Weak HashSet test with Domain (generating)
[ ]    9    0    0    9 / 1000    64.0s Lin DSL Weak HashSet test with Domain (shrinking:    4.0003)
[ ]    9    0    0    9 / 1000   125.3s Lin DSL Weak HashSet test with Domain (shrinking:    7.0005)
[ ]    9    0    0    9 / 1000   188.1s Lin DSL Weak HashSet test with Domain (shrinking:    7.0018)
[ ]    9    0    0    9 / 1000   250.3s Lin DSL Weak HashSet test with Domain (shrinking:    8.0012)
[ ]    9    0    0    9 / 1000   310.5s Lin DSL Weak HashSet test with Domain (shrinking:    8.0022)
[ ]    9    0    0    9 / 1000   371.7s Lin DSL Weak HashSet test with Domain (shrinking:    8.0033)
[ ]    9    0    0    9 / 1000   434.7s Lin DSL Weak HashSet test with Domain (shrinking:    8.0044)
[ ]    9    0    0    9 / 1000   500.4s Lin DSL Weak HashSet test with Domain (shrinking:    8.0056)
[...]
[ ]    9    0    0    9 / 1000 16532.8s Lin DSL Weak HashSet test with Domain (shrinking:   44.0058)
[ ]    9    0    0    9 / 1000 16597.1s Lin DSL Weak HashSet test with Domain (shrinking:   44.0070)
[ ]    9    0    0    9 / 1000 16662.7s Lin DSL Weak HashSet test with Domain (shrinking:   44.0082)
[ ]    9    0    0    9 / 1000 16725.2s Lin DSL Weak HashSet test with Domain (shrinking:   45.0004)
[ ]    9    0    0    9 / 1000 16787.5s Lin DSL Weak HashSet test with Domain (shrinking:   45.0017)
[ ]    9    0    0    9 / 1000 16849.5s Lin DSL Weak HashSet test with Domain (shrinking:   45.0028)
[ ]    9    0    0    9 / 1000 16912.5s Lin DSL Weak HashSet test with Domain (shrinking:   46.0002)
[ ]    9    0    0    9 / 1000 16975.8s Lin DSL Weak HashSet test with Domain (shrinking:   46.0016)
[ ]    9    0    0    9 / 1000 17037.0s Lin DSL Weak HashSet test with Domain (shrinking:   46.0027)
[ ]    9    0    0    9 / 1000 17099.3s Lin DSL Weak HashSet test with Domain (shrinking:   46.0039)
[ ]    9    0    0    9 / 1000 17160.0s Lin DSL Weak HashSet test with Domain (shrinking:   48.0026)
Fatal error: exception User interruption
[ ]    9    0    0    9 / 1000 17220.7s Lin DSL Weak HashSet test with Domain (shrinking:   48.0069)Terminate batch job (Y/N)?
^C
Error: The operation was canceled.

I suspect this is caused by Weak and Ephemeron primitives being non-deterministic and hence teasing the shrinker (a rerun may not trigger the same issue due to it being started in a different GC state).
ATM I don't recall whether I've observed this under Linux or MacOS too.

This continues to be an issue for our Cygwin target (part 2).
Here's a fresh occurrence from yesterday causing a timeout on trunk (5.2):
https://github.com/ocaml-multicore/multicoretests/actions/runs/5199454480/jobs/9383329322
random seed: 276470064
generated error fail pass / total     time test name

[ ]    0    0    0    0 / 1000     0.0s Lin DSL Weak HashSet test with Domain
[ ]    0    0    0    0 / 1000     0.0s Lin DSL Weak HashSet test with Domain (generating)
[ ]   40    0    0   40 / 1000    60.3s Lin DSL Weak HashSet test with Domain
[ ]   78    0    0   78 / 1000   121.3s Lin DSL Weak HashSet test with Domain
[ ]   82    0    0   82 / 1000   182.1s Lin DSL Weak HashSet test with Domain (shrinking:    5.0004)
[ ]   82    0    0   82 / 1000   243.0s Lin DSL Weak HashSet test with Domain (shrinking:    5.0014)
[ ]   82    0    0   82 / 1000   306.1s Lin DSL Weak HashSet test with Domain (shrinking:    8.0002)
[ ]   82    0    0   82 / 1000   369.3s Lin DSL Weak HashSet test with Domain (shrinking:   10)
[ ]   82    0    0   82 / 1000   432.8s Lin DSL Weak HashSet test with Domain (shrinking:   11.0007)
[ ]   82    0    0   82 / 1000   496.9s Lin DSL Weak HashSet test with Domain (shrinking:   13.0004)
[ ]   82    0    0   82 / 1000   559.8s Lin DSL Weak HashSet test with Domain (shrinking:   14.0004)
[ ]   82    0    0   82 / 1000   623.2s Lin DSL Weak HashSet test with Domain (shrinking:   16.0004)
[...]
[ ]   82    0    0   82 / 1000 15130.7s Lin DSL Weak HashSet test with Domain (shrinking:   50.0293)
[ ]   82    0    0   82 / 1000 15192.4s Lin DSL Weak HashSet test with Domain (shrinking:   50.0305)
[ ]   82    0    0   82 / 1000 15255.3s Lin DSL Weak HashSet test with Domain (shrinking:   50.0317)
[ ]   82    0    0   82 / 1000 15315.8s Lin DSL Weak HashSet test with Domain (shrinking:   50.0329)
[ ]   82    0    0   82 / 1000 15380.5s Lin DSL Weak HashSet test with Domain (shrinking:   50.0341)
[ ]   82    0    0   82 / 1000 15442.9s Lin DSL Weak HashSet test with Domain (shrinking:   51.0012)
[ ]   82    0    0   82 / 1000 15507.9s Lin DSL Weak HashSet test with Domain (shrinking:   51.0024)
[ ]   82    0    0   82 / 1000 15568.6s Lin DSL Weak HashSet test with Domain (shrinking:   51.0035)
[ ]   82    0    0   82 / 1000 15632.8s Lin DSL Weak HashSet test with Domain (shrinking:   51.0048)
Error: The operation was canceled.

The new s390x runners however also hit it causing a 5h timeout.
Here's yesterday's s390x 5.1 run:
https://ocaml-multicoretests.ci.dev:8100/job/2023-06-07/160211-ci-ocluster-build-85cb51
random seed: 320445065
generated error fail pass / total     time test name

[ ]    0    0    0    0 / 1000     0.0s Lin DSL Weak HashSet test with Domain
[ ]    0    0    0    0 / 1000     0.0s Lin DSL Weak HashSet test with Domain (generating)
[ ]    1    0    0    1 / 1000    60.6s Lin DSL Weak HashSet test with Domain (shrinking:   13.0043)
[ ]    1    0    0    1 / 1000   121.1s Lin DSL Weak HashSet test with Domain (shrinking:   16.0019)
[ ]    1    0    0    1 / 1000   181.3s Lin DSL Weak HashSet test with Domain (shrinking:   16.0061)
[ ]    1    0    0    1 / 1000   241.9s Lin DSL Weak HashSet test with Domain (shrinking:   17.0023)
[ ]    1    0    0    1 / 1000   302.9s Lin DSL Weak HashSet test with Domain (shrinking:   17.0068)
[ ]    1    0    0    1 / 1000   365.0s Lin DSL Weak HashSet test with Domain (shrinking:   18.0041)
[ ]    1    0    0    1 / 1000   431.0s Lin DSL Weak HashSet test with Domain (shrinking:   18.0058)
[...]
[ ]    1    0    0    1 / 1000  7256.9s Lin DSL Weak HashSet test with Domain (shrinking:   41.0193)
[ ]    1    0    0    1 / 1000  7320.8s Lin DSL Weak HashSet test with Domain (shrinking:   41.0196)
[ ]    1    0    0    1 / 1000  7382.0s Lin DSL Weak HashSet test with Domain (shrinking:   41.0200)
[ ]    1    0    0    1 / 1000  7455.1s Lin DSL Weak HashSet test with Domain (shrinking:   41.0206)
[ ]    1    0    0    1 / 1000  7522.5s Lin DSL Weak HashSet test with Domain (shrinking:   41.0211)
[ ]    1    0    0    1 / 1000  7587.4s Lin DSL Weak HashSet test with Domain (shrinking:   41.0216)
[ ]    1    0    0    1 / 1000  7648.7s Lin DSL Weak HashSet test with Domain (shrinking:   41.0221)
[ ]    1    0    0    1 / 1000  7715.6s Lin DSL Weak HashSet test with Domain (shrinking:   41.0227)
[ ]    1    0    0    1 / 1000  7784.6s Lin DSL Weak HashSet test with Domain (shrinking:   41.0234)
[ ]    1    0    0    1 / 1000  7852.9s Lin DSL Weak HashSet test with Domain (shrinking:   41.0240)
[ ]    1    0    0    1 / 1000  7917.1s Lin DSL Weak HashSet test with Domain (shrinking:   41.0246)
[ ]    1    0    0    1 / 1000  7979.4s Lin DSL Weak HashSet test with Domain (shrinking:   41.0251)2023-06-07 23:44.19: Cancelling: Timeout (300.0 minutes)
Job cancelled
2023-06-07 23:44.22: Timeout (300.0 minutes)

and yesterday's s390x 5.2 run
https://ocaml-multicoretests.ci.dev:8100/job/2023-06-07/160211-ci-ocluster-build-302d11
random seed: 468134068
generated error fail pass / total     time test name

[ ]    0    0    0    0 / 1000     0.0s Lin DSL Weak HashSet test with Domain
[ ]    0    0    0    0 / 1000     0.0s Lin DSL Weak HashSet test with Domain (generating)
[ ]   12    0    0   12 / 1000    60.4s Lin DSL Weak HashSet test with Domain (shrinking:   24.0020)
[ ]   12    0    0   12 / 1000   120.5s Lin DSL Weak HashSet test with Domain (shrinking:   29.0015)
[ ]   12    0    0   12 / 1000   182.0s Lin DSL Weak HashSet test with Domain (shrinking:   29.0070)
[ ]   12    0    0   12 / 1000   242.5s Lin DSL Weak HashSet test with Domain (shrinking:   29.0120)
[ ]   12    0    0   12 / 1000   303.8s Lin DSL Weak HashSet test with Domain (shrinking:   29.0172)
[ ]   12    0    0   12 / 1000   364.5s Lin DSL Weak HashSet test with Domain (shrinking:   29.0232)
[ ]   12    0    0   12 / 1000   425.4s Lin DSL Weak HashSet test with Domain (shrinking:   29.0258)
[ ]   12    0    0   12 / 1000   485.5s Lin DSL Weak HashSet test with Domain (shrinking:   29.0308)
[ ]   12    0    0   12 / 1000   546.6s Lin DSL Weak HashSet test with Domain (shrinking:   29.0362)
[...]
[ ]   12    0    0   12 / 1000  7206.7s Lin DSL Weak HashSet test with Domain (shrinking:   89.0053)
[ ]   12    0    0   12 / 1000  7270.8s Lin DSL Weak HashSet test with Domain (shrinking:   89.0056)
[ ]   12    0    0   12 / 1000  7341.2s Lin DSL Weak HashSet test with Domain (shrinking:   89.0060)
[ ]   12    0    0   12 / 1000  7403.3s Lin DSL Weak HashSet test with Domain (shrinking:   89.0065)
[ ]   12    0    0   12 / 1000  7471.3s Lin DSL Weak HashSet test with Domain (shrinking:   89.0071)
[ ]   12    0    0   12 / 1000  7539.0s Lin DSL Weak HashSet test with Domain (shrinking:   90.0004)
[ ]   12    0    0   12 / 1000  7611.6s Lin DSL Weak HashSet test with Domain (shrinking:   90.0009)
[ ]   12    0    0   12 / 1000  7680.0s Lin DSL Weak HashSet test with Domain (shrinking:   90.0016)
[ ]   12    0    0   12 / 1000  7747.3s Lin DSL Weak HashSet test with Domain (shrinking:   90.0023)
[ ]   12    0    0   12 / 1000  7811.0s Lin DSL Weak HashSet test with Domain (shrinking:   90.0030)
[ ]   12    0    0   12 / 1000  7878.9s Lin DSL Weak HashSet test with Domain (shrinking:   90.0037)
[ ]   12    0    0   12 / 1000  7945.1s Lin DSL Weak HashSet test with Domain (shrinking:   90.0044)
[ ]   12    0    0   12 / 1000  8009.1s Lin DSL Weak HashSet test with Domain (shrinking:   90.0050)
[ ]   12    0    0   12 / 1000  8073.8s Lin DSL Weak HashSet test with Domain (shrinking:   90.0057)
[ ]   12    0    0   12 / 1000  8141.5s Lin DSL Weak HashSet test with Domain (shrinking:   90.0063)2023-06-07 23:47.13: Cancelling: Timeout (300.0 minutes)
Job cancelled
2023-06-07 23:47.16: Timeout (300.0 minutes)

There's a continuing pattern of many failed shrink attempts - as high as 362 above.
I believe the behaviour is fundamentally caused by the Weak module depending on the state of the Heap - which is somewhat out of our control. My hypothesis is that it confuses the shrinker - which will have a late success once sufficient garbage has been added via several failed shrink attempts.
I also have a test case locally which exhibits the problem under Linux and 5.1.0~alpha2.
On subsequent runs with the same seed it however behaves quite differently - which supports
"something outside of our control"-hypothesis.
I'll try to see if an explicit Gc-call will make the test more predictable - and run faster.


DeepFace: BGR to RGB

Hi serengil!
For black/white images, does DeepFace/VGG handle the vectorization of such images?
Also, does the image need to conform to BGR or RGB format? Because I realized it affects the output vector for BGR-type and RGB-type images.
Thanks!

you have to pass RGB images.

In extract_faces function in DeepFace.py, there is a docstring line stating that we should pass BGR images: img_path: exact image path, numpy array (BGR) or base64 encoded image. But my experiments (with MediaPipe detector) suggest that we should pass RGB images. Is it a mistake in the docstring?


revise waste container data models to align. ex. dateCreated.

it would be done if required. Plese reopen this was the case.


How do I install/link an old version of a package without it triggering warnings from brew doctor?

Bug reports:
Summary: I need to keep an old version of Scala installed/linked on my system. How can I do this without it triggering warnings from brew doctor?
Details:
I need to ignore new versions of Scala and keep version 2.10.X installed/linked on my system. Yesterday, I accidentally deleted version 2.10.X on my system and had 2.12.X installed in its place. Unfortunately, in this situation, there is no easy way to "go back".
Instead, after searching around the web, I discovered that I could get 2.10.5 installed by following these commands:
brew install homebrew/versions/scala210
brew unlink scala
brew link scala210 --force

That solved my problem but now when I run brew doctor I receive the following warnings:
Warning: You have unlinked kegs in your Cellar
Leaving kegs unlinked can lead to build-trouble and cause brews that depend on
those kegs to fail to run properly once built. Run `brew link` on these:
  scala

Warning: Some keg-only formula are linked into the Cellar.
Linking a keg-only formula, such as gettext, into the cellar with
`brew link <formula>` will cause other formulae to detect them during
the `./configure` step. This may cause problems when compiling those
other formulae.

Binaries provided by keg-only formulae may override system binaries
with other strange results.

You may wish to `brew unlink` these brews:
  homebrew/versions/scala210

What I would like to be able to do is to tell homebrew that I want 2.10.5 installed on my machine even though 2.12.X is available and have this configuration be considered normal such that it doesn't trigger warnings when I run brew doctor.
Is there anyway to achieve this?

Don't use brew link --force if you want to avoid brew doctor warnings. Instead adjust your PATH accordingly so you don't need to link it. Alternatively, ignore brew doctor. Another alternatively, please consider creating your own tap instead. Thanks!


elementArea field in mesh files has wrong units

It looks like we should be using units of radians^2 for elementArea for in ESMF unstructed mesh files.
e.g.
     double elementArea(elementCount) ;
            elementArea:units = "radians^2" ;
            elementArea:long_name = "area weights" ;

See:
https://earthsystemmodeling.org/docs/release/ESMF_8_0_1/ESMF_refdoc/node3.html#SECTION03028200000000000000
Saying that, we are not currently using this field. e.g.
https://github.com/CICE-Consortium/CICE/blob/3ebdef778bded4b10d628a179ea746d091e21150/cicecore/drivers/nuopc/cmeps/ice_comp_nuopc.F90#L732-L733
would need another argument ( addUserArea = .true. ) to actually load this. (See https://github.com/COSIMA/access-om3/issues/240)
It also looks like the cells at the north poles on the grid, should be using numElementConn = 3 , not 4.
i.e.
elementConn can be either a 2D array or a 1D array. If it is a 2D array, the second dimension of the elementConn variable has to be the size of the largest number of nodes in any element (i.e. maxNodePElement), the actual number of nodes in an element is given by the numElementConn variable.

Presumable the last element in the elementConn field is set the the _FillValue when there are only three corners to an element
 int elementConn(elementCount, maxNodePElement) ;
            elementConn:long_name = "Node Indices that define the element /
                                     connectivity";
            elementConn:_FillValue = -1 ;
            elementConn:start_index = 1 ;

The area field did get fixed in #41
There is also

It also looks like the cells at the north poles on the grid, should be using numElementConn = 3 , not 4.

Not sure if it affects anything or not


Cannot view CLA documents

I am asked to sign a CLA page stating I read the following documents which do not exist!
https://github.com/SAPDocuments/Tutorial-Contribution/blob/master/contributing.md
https://github.com/SAPDocuments/How-To-Contribution/blob/master/contributing.md
Please fix the broken links or do not ask users to sign a CLA.

Why are you writing this in this repo, when the issue is in those 2 repos. And why are creating PRs in those repos?


Add a special case for 0-time interpolations

Most of interpolation equations divide by duration, which results in infinite final value if it's 0. I added a special case for 0 duration, so now it ends instantly without computing anything.
Fixes #40843
Could be probably cherry-picked, because the interpolation method is the same (except it's not exposed).

Thanks!

Cherry-picked for 3.4.


Error Attaching Samply Profiler to Unity

Environment

Operating System: macOS 2021 M1 Pro
Samply Version: 451b5bdb14924287c7ed41c46c5f74dd17e7a3f1
Target Application: Unity built locally

Issue Description
I am encountering the following error when trying to record the Unity Editor that was locally built.
The command I used:
samply record --save-only -o profile-data.json -- build/MacEditor/x64/Debug/Unity.app/Contents/MacOS/Unity  -projectpath path_to_project
Resulting in the following error:
thread '<unnamed>' panicked at samply/src/mac/sampler.rs:99:10: couldn't create root TaskProfiler: Ignorable("Could not check process libraries", InvalidAddress) note: run with RUST_BACKTRACE=1 environment variable to display a backtrace thread 'main' panicked at samply/src/mac/profiler.rs:151:48: couldn't join sampler thread: Any { .. }
Attempts to Resolve

Running with sudo
Looking a permission rights for both Samply and Unity

Request
I am looking for guidance on how to resolve this issue. Any assistance or suggestions would be greatly appreciated.
Thank you for your time and help.

It looks like you're compiling and running an Intel version of Unity on an Apple Silicon machine. This means it runs under Rosetta. Samply cannot profile applications running under Rosetta.

Thank you for your quick reply. That was indeed the issue!


font not changed in editor

I changed my font family to Menlo which had an immediate change in navigation, menus, etc but it doesn't look like the font updated in textview.

Also, I tried updating through gide prefs and that didn't change anything it seemed. Perhaps they should be linked and there should be a dialog asking if you want to change the GoGi pref as well for those items that are in both sets of prefs.

textview has its own font.. in editor prefs -- only the one in Project PRefs will affect a running project.  It is different b/c it is monospace which is not typical for default GoGi font.
and it looks like you need to do a Ctrl+L to trigger a refresh to get it to take..

Thanks, switched to Go Medium for editor. Are you still using Go for your editor font?

Go Medium not mono spaced, can't use that!


Translation to Azerbaijani

the code is written in Azerbaijani

who is the admin or mod here?

Did I do it right?

What next should I do?

@adam50200 include also the index.ts file update.  please follow the instruction in https://github.com/pkgxdev/ossapp#readme
thanks.

@adam50200 include also the index.ts file update. please follow the instruction in https://github.com/pkgxdev/ossapp#readme
thanks.

How? I don’t understand

in the link i provided here is the screenshot of the instruction

Reopen if you

k closed as I thought it didn't include the translation, but we should get this over the line since that work was done.

Closing as the original author is now hostile to the project.


Tensor.rand for bfloat16

for numpy based random, generate one for float then cast for bfloat16.
close #3653

eh need to fix bf16 support first


Add support for mips64el

Signed-off-by: Dominic Yin<EMAIL_ADDRESS>Add support for mips64el ; )

This is very similar to the changes in https://github.com/docker-library/hello-world/pull/68 :smile:
@krallin friendly ping for your thoughts?  Any willingness to publish mips64le binaries? :innocent: :heart:

I'm sorry I had missed this :( Thanks for the ping! The build looks good indeed. I'd like to see if I can also set up aliases as per #152, but for now there's no reason not to merge this!


libpostal 1.1_1 :snowflake:

libpostal 1.1 :snowflake:
Destination channel: Snowflake
Links

PKG-5362
dev_url:        https://github.com/openvenues/libpostal/tree/v1.1
conda_forge:    https://github.com/conda-forge/libpostal-feedstock/blob/main/recipe/meta.yaml
pypi:           n/a
pypi inspector: n/a

Explanation of changes:

bump the build number because the build system lost a previous artifact (linux-aarch64's .tar.bz2)
the main change is to pre-download the data files (800MB) and disable to autodownload during a build
in addition we're running the internal tests during a build (can't be copied to run during the test phase)

though 15 parser tests fail for s390x 🤷 (not obviously going to be fixed by switching to Senzing which improves US, UK and SG)
s390x skipped as this is going to ❄

Note that technically we found a way to build autoconf packages on win (see here), although it proves very time consuming. It's ok to skip win in this case.


Nested worker leak in Safari

run ./scripts/code-web.sh
open the page in Safari (!)
open a TS file
select F1 > Restart Tsserver
🐛 notice how there are now multiple workers

/cc @alexdima we saw this while touring through this code

🎉 for fixing !


Refactoring

Code Coverage Summary [using JaCoCo]

Coverage Type
Coverage

Coverage:
18.30%

Branches:
17.90%


Test compatiblity with Matplotlib 3

What is the expected enhancement?
See if visualizations relying on matplotlib behave the same with version 3.0 of the library so we can start supporting it.

What is the problem with Matplotlib version 3?  I have been using it without issue for some time now.  The only problem I have is that the qiskit installer tries to downgrade my version, which then leads to an error in the older version for the matplotlib circuit drawer

Following yours and Diego's recommendation https://github.com/Qiskit/qiskit-terra/pull/921#issuecomment-423256570 and given that there is no test suite that stresses our visualizations or compares if the representations are preserved between versions. So this should be done manually. If you have performed these tests, bump the version in the requirements.txt and we can close the issue.

I have updated most of the tutorial notebooks and found no issues that arise because of the use of mpl-3.  Thus, I have bumped the version in #953.


Flash on cordova.apache.org?

I just noticed Firefox is bringing a flash warning. Is Adobe Flash really necessary to use cordova.apache.org

(German for "This website uses Adobe Flash, Only alllow on trusted sites)

Interesting. I couldn't trigger a warning regarding Flash on https://cordova.apache.org/blog/ - could you possibly investigate further which caused this?

I'm also unable to reproduce this. Perhaps its a browser addon?

Just a random idea: could the Twitter feed/widget perhaps (still) use Flash?

Just a random idea: could the Twitter feed/widget perhaps (still) use Flash?

I was thinking about this too... Perhaps if the tweet contains a video?

I just tested another browser (Firefox Linux, previous one was Firefox Windows) and there is a similar flash warning. Will investigate...

It should be ZeroClipBoard which is loading a .swf file. That should be the Flash script file

Should be fairly easy to remove -> https://github.com/apache/cordova-docs/search?q=ZeroClipboard&unscoped_q=ZeroClipboard
Should I go ahead and create a PR?

Weird, I get a ZeripClipboard.js file, but I don't see a ZeroClipboard.swf file being requested (on chrome)
I see the same on firefox.

I just disabled the "Shockwave flash plugin" in Firefox on Linux and now the icon in the URL bar is gone. I cannot see the swf file too.
There is no point in keeping this library right? Flash is gone from modern modern browsers and EOL by Adobe in year as far as I know.

Not sure where this library is actually used, but I think generally speaking it can probably be refactored out based and use a pure js solution based on https://caniuse.com/#feat=clipboard

I would also like to understand some historical context to understand why and what may be broken before removing things like this.
Starting from this line: https://github.com/apache/cordova-docs/blob/master/www/static/plugins/app.js#L29
I took a look through the history and discovered that this ZeroClipboard thing was introduced in PR #395.
Unfortunately PR #395 copied a bunch of files from some branch that I do not see any record of so far, at least. Bad for attribution of contributions and bad for understanding historical context of things.

I just did some searches and it looks like it is just used for the "copy" buttons next to the CLI commands on this page: https://cordova.apache.org/#getstarted

I think I may got removing ZeroClipBoard right. It works locally for me in Firefox and Chromium on Linux.

This was 100% for the “copy” buttons. I don’t recall now why JS-only wasn’t enough. Please validate on at least Ubuntu, macOS, and Windows on some modern set of browsers.

If this was done in 2015, those were different times :-). Maybe Internet Explorer? I dont't know much about the clipboard API, but I think it's time to get rid of flash now since most browser won't support it anyway.
I will test this on Windows and macOS at work soon. My test right now was done on Linux Mint (Ubuntu based).


Updated Scenario for calendar

Updated scenario for calendar

@JohanFreelancer9 Copy editing is needed for this PR. Thanks.

@MicrosoftHeidi PR has been copyedited and is ready for final review, could you please check and merge? Thanks!


MAINT: rework data aquisition to be funtional

E.g. we should check whether data is already available rather than trying to download it again by default. (This will be less of an issue when we switch away from data downloads, but currently exceptions are raised if the data is already been present in the download locations)

the download from on-prem still seem to redo the download, so a few more checks are needed. The S3 way seems to run much faster suggesting the checks work for it, nevertheless a careful double-check wouldn't hurt.


Improve resilience of TestPullFromCentralRegistryImplicitRefParts

Sometimes transient network issues will cause
TestPullFromCentralRegistryImplicitRefParts to end up pulling with the
v1 protocol. This violates the assumptions behind the test. To make the
test more robust, allow a few retries if any pull ends up using the v1
protocol.
Fixes #17214

Job: Docker-PRs FAILED:

---
er daemon 23.95 MB
Sending build context to Docker daemon 24.51 MB
Sending build context to Docker daemon 25.07 MB
Sending build context to Docker daemon 25.62 MB
Sending build context to Docker daemon 26.18 MB
Sending build context to Docker daemon 26.74 MB
Sending build context to Docker daemon  27.3 MB
Sending build context to Docker daemon 27.85 MB
Sending build context to Docker daemon 28.41 MB
Sending build context to Docker daemon 28.97 MB
Sending build context to Docker daemon 29.52 MB
[PostBuildScript] - Execution post build scripts.
Sending build context to Docker daemon 30.08 MB
Sending build context to Docker daemon 30.64 MB
Sending build context to Docker daemon  31.2 MB
Sending build context to Docker daemon 31.75 MB
Sending build context to Docker daemon 32.31 MB
Sending build context to Docker daemon 32.87 MB
Sending build context to Docker daemon 33.42 MB
Sending build context to Docker daemon 33.98 MB
Sending build context to Docker daemon 34.54 MB
Sending build context to Docker daemon 35.09 MB
Sending build contex
---

LGTM

LGTM


OSD 0 cannot write to its log file

Ceph-ansible deployments leave a /var/log/ceph-osd-0.log file on every OSD node with permissions of root/root.  This means that the real ceph OSD with ID 0 cannot write to its own log file because the daemon is running as 'ceph' and the file is owned by 'root':
~$ sudo ls -l /var/log/ceph
total 15320
-rw------- 1 ceph ceph    6240 Jan 10 08:00 ceph.audit.log
-rw------- 1 ceph ceph 6689776 Jan 11 14:50 ceph.log
-rw-r--r-- 1 ceph ceph 8753329 Jan 11 14:50 ceph-mon.mhost5.log
-rw-r--r-- 1 root root     810 Jan 10 08:00 ceph-osd.0.log
-rw-r--r-- 1 ceph ceph  210278 Jan 11 14:40 ceph-osd.1.log
I've tracked the file creation down to the call to "ceph-disk prepare".  The 'ceph-disk' tool in turn calls these commands:
/usr/bin/ceph-osd --check-allows-journal -i 0 --cluster ceph
/usr/bin/ceph-osd --check-wants-journal -i 0 --cluster ceph
/usr/bin/ceph-osd --check-needs-journal -i 0 --cluster ceph
Ceph-disk has the '0' hard coded.   This causes the log file to be created with owner root and since we are calling ceph-disk prepare on every OSD node this causes the file to be created on every OSD node.
Note, when I reproduce this with a simple playbook to call just this command with become: true the file is owned by root but has group 'ceph'.  It doesn't fully explain how the files from ceph-ansible deploy end up with root/root.
So yes, this issue is outside of ceph-ansible but I am opening the bug to have the discussion about whether these commands should be run as user 'ceph' by ceph-ansible or if we should put a 'workaround' in ceph-ansible to remove the *-osd.0.log files or change owner/group to ceph/ceph.

Update:  The ceph-disk prepare code does make the ceph-osd-0.log file and the perms are root/root.  In my original tests I was testing this in a cluster where no monitors were up. When the monitor is up and ceph-disk prepare can run to successful completion the file is left with root / root.
I did some more investigation into this to see if we could/should have ceph-ansible run ceph-disk prepare as the 'ceph' user.  This won't work ceph-disk fails with an error like this:
File "/usr/lib/python2.7/dist-packages/ceph_disk/main.py", line 581, in get_dev_size
fd = os.open(dev, os.O_RDONLY)
OSError: [Errno 13] Permission denied: '/dev/vdc'
Because user 'ceph' does not have read permission on the device.  So we must run it as root.
At this point the only workaround we could do in ceph-ansible is to do a chown/chgrp on the file after disk prepare and before OSD activate or remove the file between disk prepare and disk activate.

@smatzek or we could chown the device to the ceph user and run ceph-disk with the ceph user?

That may work.  I did more investigation after the last update and neglected to update before the weekend.  I've found that it's likely a simple fix in ceph-disk and opened a bug for that:
http://tracker.ceph.com/issues/18538
Once I get the fix for that merged the ceph-ansible question will be what, if anything, we want to do for a workaround in levels that don't have the fix.

Right, ceph-disk should apply the right permission on the device and fix its hardcoded parts. In the meantime, I think it's acceptable to apply the right permission of the block device. Do you mind testing this out?
Thanks!

The fix for http://tracker.ceph.com/issues/18538 is merged in ceph master (luminous) and is targeted for backport to jewel and kraken.
The fix for this bug isn't pretty.  You have to change the permissions on the osd.0.log and then kill -1 signal the daemon to close its FD and reopen.
Given the above, we won't workaround this in ceph-ansible and it will auto-correct once the fixes make it into minor versions of the affected releases.


Allow import with .ts / .tsx endings (include extension) for Deno support

Current Behavior
import a from './a.ts';

results in:

semantic error TS2691: An import path cannot end with a '.ts' extension. Consider importing './a' instead.

Desired Behavior
Import should just work as if this was used:
import a from './a';

Who does this impact? Who is this for?
Users aiming to build with tsdx for npm but still support Deno.
My library doesn't use any of the Node API, or have any dependencies, so my source code would "just work" in Deno with this fix.

This is a TypeScript error, not a TSDX error; even if tsdx build were to support that, it would break various other tooling in the ecosystem that relies on TS. We've already had issues with incompatibilities that are very confusing for users, so I don't think we want to add to those.
In https://github.com/jaredpalmer/tsdx/issues/722#issuecomment-633120045, I mentioned why it would be better to use the transpiles JS and have a Deno build option instead (tl;dr Deno has it's own tsconfig settings and still compiles your code)


support protobuf struct type

Rationale for this change
extra support for protobuf common types, converting to parquet
What changes are included in this PR?
support for protobuf struct and tests
Are these changes tested?
yes
Are there any user-facing changes?
yes, new option for conversion

@zeroshade can I get your thoughts on this?
spark follows this pattern: https://spark.apache.org/docs/latest/sql-data-sources-protobuf.html#handling-circular-references-protobuf-fields
syntax = "proto3"
message Person {
  string name = 1;
  Person bff = 2
}

// The protobuf schema defined above, would be converted into a Spark SQL columns with the following
// structure based on `recursive.fields.max.depth` value.

0: struct<name: string, bff: null>
1: struct<name string, bff: <name: string, bff: null>>
2: struct<name string, bff: <name: string, bff: struct<name: string, bff: null>>> ...

but parquet can't do null types
my idea, is if we get to depth = x, then we drop the field? e.g. for 2
2: struct<name string, bff: <name: string, bff: struct<name: string>>>

if the intent here is to use it for specifically JSON fields, then i would say we just use a string and utilize the Canonical JSON extension type so that it gets stored in parquet as a JSON typed field.

@tscottcoombes1 Running pre-commit should be sufficient to fix the linting issues


go.work: go.work and main.go is same path question

go.work and main.go is same path, but now it not use this. why?
sometime use work, go.work and main.go is at same path and it must use replace to other pkg at the work.

Unlike many projects, the Go project does not use GitHub Issues for general discussion or asking questions. GitHub Issues are used for tracking bugs and proposals only.
For questions please refer to https://github.com/golang/go/wiki/Questions


Correting way to call async

On Python 3.7 async is a reserved keyword,so i used getattr() to get it

Interesting, thanks for the PR! Not sure why travis/codecov barfed here, but this should be good to merge once I make sure tests are passing 👍

Yeah this looks good. I'll merge and cut a new release, thanks!


Update README to point to Safari

Update the README to include information about the Safari extension.

Thanks @dharb!


[Profile] Web - Joined workspace which is pending for approval disappears after relogin

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: <IP_ADDRESS>
Reproducible in staging?: y
Reproducible in production?: new feature
Issue reported by: Applause - Internal Team
Action Performed:
Precondition:

The invite link to workspace is https://staging.new.expensify.com/settings/workspaces/<Workspace_ID>/join?email=<admin_email>
Example<EMAIL_ADDRESS>

[Employee] Click on the invite to join the workspace.
[Employee] After the workspace shows up in All workspaces page, log out.
[Employee] Log in again and go to All workspaces page.

Expected Result:
Joined workspace which is pending for approval should be visible after relogin
Actual Result:
Joined workspace which is pending for approval disappears after relogin
Workaround:
n/a
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android: Native
[ ] Android: mWeb Chrome
[ ] iOS: Native
[ ] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[ ] MacOS: Desktop

Screenshots/Videos
Add any screenshot/video evidence
https://github.com/Expensify/App/assets/93399543/5daa81ff-6eca-4acc-ae0f-5ba297bf49f4
View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~010b6b769a86dd06b0
Upwork Job ID:<PHONE_NUMBER>971724800
Last Price Increase: 2024-03-11

Can't reproduce. I think it's a BE and already fixed.

This seems like a backend issue too. We're probably not sending the policy data for non-member back to the user on OpenApp.

I'm gonna add the Hot Pick label here. @tgolen feel free to remove it if you wanna take this on.

No update, in hot picks waiitng for a volunteer.

@amyevans we renamed those routes in Ideal Nav v2, so the correct url is /settings/workspaces/<policyID>/join?email=<inviterEmail>

It seems like the issue comes from the API not sending data for the join requests.

Hmm I think the solution for this one might be a bit involved, since we currently only store the join requests in the policy object, so we'd have to query all policies in the DB to find which ones have a join request from a particular user 😅 I think we'd have to solve this by introducing a new NVP and also storing join requests on the user account level.

I'll work on this one

Discussing here

As discussed in the thread above, we decided to :do-nothing: given that we:

Don't display anything to users in OldDot besides the growl
Users never asked us for this feature
Low usage of this flow
We currently show the pending requests, but users would have to log out / in to not see it again

Feel free to reopen if you feel differently.


Remove links for folders containing only a .gitkeep

Suggestion
In some repos, there may be empty folders containing a .gitkeep file. This is usually done so that the folders appear in the repo, even though they dont contain any files (maybe the folders themselves store information in their name).
The link to open the folder is redundant because inside it there is only a 0 KB .gitkeep file.
Refind github could check if there is only one file in the folder and if it has 0 KB, and if that is the case, completely remove the link to open the folder.
Example URL

https://github.com/AlexejheroYTB/Dlockly/tree/master/blocks/custom
Example of folder that this could apply to: 002 [sep]'
Images
This feature could look something like this:

I’m not a fan of completely hiding files, but this can be a generic feature that changes folder links to folder/single-file.ext like GitHub already does natively for folder/single-subfolder` if I remember correctly

This could be a feature for Hide Files on GitHub.

Implementation suggestion:

Watch for changes in the files list. Refer to the Hide Files extension suggested above, there’s good code for this in there.
Fetch the contents of ALL the visible folders in a single GraphQL query. Look for pre-existing features that do this: search api.v4‘s usage in our code
For each folder that has a single file, change the link to point to that file.

It’s not an easy feature, but not a super complex one either.

This needs to ask info for every folder you ever see... just to possibly skip a click that you might not ever make. This is of limited use and not worth the complexity.


Use the Python Postinstall implementation by default

What does this PR (Pull Request) do?

Makes Postinstall use the Python backend instead of the old Perl one

Deprecates the Perl version of the Postinstall script

CDN in  Box now configures Traffic Ops using the Python rewrite of the TO Postinstall script (fixes #5680).

[x] This PR fixes #3437 by documenting JSON input to the Postinstall script. We do not need to remove input.json because if it ever were to become out-of-date, CDN in a Box would break.

Which Traffic Control components are affected by this PR?

CDN in a Box
Documentation
Traffic Ops Postinstall script

What is the best way to verify this PR?

Run postinstall.test.sh
Verify that the CDN in a Box Delivery Service can be reached

The following criteria are ALL met by this PR

[x] This PR includes tests
[x] This PR includes documentation
[x] This PR includes an update to CHANGELOG.md
[x] This PR includes any and all required license headers
[x] This PR DOES NOT FIX A SERIOUS SECURITY VULNERABILITY (see the Apache Software Foundation's security guidelines for details)

Additional Information

As an aside, we could also add a GHA to run the tests when postinstall is updated. Doesn't need to go in this PR, but it might be helpful.

The script itself seems to work well enough as a drop-in replacement for Perl, but the renaming seems to have broken the tests:

Fixed in 3c3c5b4e36

As an aside, we could also add a GHA to run the tests when postinstall is updated. Doesn't need to go in this PR, but it might be helpful.

GHA added in 8b2740d54b


[Bug] pre-commit makes pointless changes all the time causing merge conflicts

Pre-requist tasks

[x] My device drivers are up to date.
[x] The troublemaking solutions did not solved my issue.

Describe the bug
I am trying to work on the python code in this repository. Whenever I commit something to an existing PR, the github CI interferes with my changes, causing merge conflicts with every second commit I make.
To Reproduce

Create a pull request from a new branch.
Modify code, e.g. add functions, edit __init__.py files
Commit the change
Continue working, add more functions and code
Commit the change
A merge conflict occurs

Expected behavior
I think the this is not a pre-commit, as the modifications by the CI obviously happen post-commit. I am proposing to turn this feature entirely off, or to execute it when merging the PR (commit to main branch), not with every commit.
Screenshots
The current workflow would work, if I wait 5 minutes between step 3 and 4, which is a waste of time obviously. Typically, the CI does changes like these:

If these are the only changes (reordering imports) I can also very conveniently live without this precommit.ci
Configuration details:

OS: [e.g. MacOS 14, Windows 11, Linux Ubuntu 22.03]
Device: [e.g. NVIDIA RTX 4090, Intel Iris Graphics, etc.]
Device type: [e.g. Integrated GPU, dedicated GPU, CPU, HPC server]

Additional context
Add any other context about the problem here.
I struggled multiple times while working on #232 you can see in the history of that PR how the CI and I are fighting against each other.

You can put # isort:skip in front of the line you do not want to be updated by isort which auto-sort import statement.
Can be tricky at first but help keep it clean. If really annoying, I will remove

The pre-commit enforce the following:

import order (with overwrite using # isort:skip)
black auto-formating
a maximum line length
clean-up invisible changes (e.g. end-of-line spaces, trailling return, yaml and json wrong formating/indentation)

I agree these are not major updates but it maintains a clean code while avoiding people the pain to install or master this ecosystem.
You can install pre-commit locally and it will act before you actually commit. Making it more immediat change. See docu, though you still might not like it :)
I will remove it for now, but I would like to keep this kind of cleanup checks to ensure clean code. I am open to alternatives if you have some in mind.

Done

Awesome, thanks! Again, I think it's cool to do this e.g. when merging into main, but not with every push on a branch.

I think I can configure it for pre-merge-commit but I do not know how it will interact with github PR merge. So I will need to test.


MobileNetV3 Large Training All From Scratch

Hi Thanks for providing this tutorial All from scratch. I have been following step by step and using Casia WebFace Datasets and the training progress increasing so slow.
Here is my accuracy result

First i was using LR: 0.0001 and change to 0.001 at 25 epochs in order to improve accuracy. It didn't help, i wonder if you have advice

My Source code is here  version 16 (before i make changes)

Just took a quick scan, great job taking it to kaggle!

You may try a smaller scale=16.0 for arcface as a start, larger one may hard to converge.
For SGD, you may start with a larger lr like 0.1.
Another point is that, in my very early tests, weight_decay is crucial for arcface loss. You may add l2_regularizer to model, or use optimizers like tfa.optimizers.SGDW or tfa.optimizers.AdamW.

May try some tests myself if got some time, but not sure...

Thank s for your response. I'll make some changes and will be back if face another problem. Just a question, how many epochs usually take to train from scratch? I read Training Scripts and your result is always high at the first epochs.

Ya, For MS1MV3 dataset, it should give some reasonable result after first expoch. Not sure for CASIA datasets, as it's much smaller, but shouldn't be larger than 3 epochs.

Any luck training this model? It boasts great memory and latency characteristics, curious what its performance looks like vs the other models.


Use Cauchy stress instead of Kirchhoff stress for solid mechanics material models

This hopefully clarifies the residual calculation calls. It is also more common for lab material libraries to use Cauchy stress vs. reference configuration stress measures.

Codecov Report

Merging #810 (e4fe942) into develop (24614a1) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

:exclamation: Current head e4fe942 differs from pull request most recent head 5183a2f. Consider uploading reports for the commit 5183a2f to get more accurate results

@@             Coverage Diff             @@
##           develop     #810      +/-   ##
===========================================
- Coverage    94.91%   94.91%   -0.01%
===========================================
  Files          142      142
  Lines         9158     9157       -1
===========================================
- Hits          8692     8691       -1
  Misses         466      466

Impacted Files
Coverage Δ

...ics/materials/green_saint_venant_thermoelastic.hpp
100.00% <100.00%> (ø)

...erials/parameterized_solid_functional_material.hpp
100.00% <100.00%> (ø)

...ac/physics/materials/solid_functional_material.hpp
100.00% <100.00%> (ø)

src/serac/physics/solid_functional.hpp
99.12% <100.00%> (-0.01%)
:arrow_down:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Key path of type 'KeyPath<Root, Type>' cannot be applied to a base of type 'UIViewController?'

Using Xcode 9.3 the CustomTransitionNode and the TransitionNode classes are giving an error in the 'selector<Root, Type>(_ keyPath: KeyPath<Root, Type>)' method for 'self.customModuleInput = destination[keyPath: selector]'

Hello! I'll check it out today.

@SpectralDragon I got same error too.

Same here

@SpectralDragon Need fix

Anybody know how to fix it?

@SerhiiMatvieiev
Hi, I use pull request version, it works this

@zarochintsev Thanks!

Do you public 2.2 version ?

If you have some idea for LightRoute evolution, you can make github issues)


Need to document following stitch guidelines

https://gist.github.com/erinkcochran87/8280f0779e0e6a75314bfe0e80d53593

Hi, @visch - Thanks for sharing this. We should be getting a lot closer with the recent markdown --about.
Regarding the list of streams being able to be included in --about, I've logged this related item: https://gitlab.com/meltano/sdk/-/issues/235
Essentially, the first step is to be able to generate a catalog without having the full config. Once that is working, we should be able to include the list of streams from catalog output using the same mechanism.


support httprb gem 4.x/5.x

The http (httprb) gem is up to a 4.2.0 release. 4.0.0 was released in Oct 2018. In fact, a 5.0.0pre release is out.
However, this gem's gemspec restricts to http 3.x.
That means any project that depends on this gem can only use http 3.x, not the newer http 4.x or upcoming 5.x.
Could the twitter gem be updated to use/allow more recent http releases?
Is this twitter gem currently maintained? Thanks!

I do unfortunately seem to have run into a bug in http that is only fixed in 4.2.0, so being stuck on 3.x, I am stuck on bug effecting me.
Don't know exactly why but:
HTTP.get("https://tenderlovemaking.com/atom.xml").to_s
With httprb 4.2.0 returns body as expected, in any previous httprb returns an incorrect empty string. Some bug that URL response specifically triggers, apparently.  My app is trying to fetch that particular URL. So unable to upgrade to http 4.2.0 because of dependency on the twitter gem, which requires only 3.x -- my app is unable to use http gem to fetch it. :(
Any feedback from maintainers appreciated!

Same here. http 4.3 fixed some compatibility issues with ruby 2.7 and the twitter gem is preventing other gems to use this new version

Would it make sense for me to try to prepare a PR loosening up http dependency restrictions?
Any feedback from maintainers? @sferik ?

Thanks @excid3 !
It's looking to me like the ruby twitter API client gem is effectively unmaintained/abandoned? @sferik ?
I will probably use @excid3's fork, while I consider if I can get off twitter gem entirely, just use raw HTTP to interact with twitter API I guess?

I only needed tweet functionality so I switched to a self implementation. Feel free to copy it if you need it too
module Twitter
  # code from https://developer.twitter.com/ja/docs/basics/authentication/guides/single-user
  class << self
    def send_tweet(tweet)
      response = client.post('https://api.twitter.com/1.1/statuses/update.json', status: tweet, trim_user: true)
      raise "Status code is not 200! #{response.code} #{response.body}" if response.code != '200'
    end

    private

    def client
      @client ||= create_client
    end

    def create_client
      consumer = OAuth::Consumer.new(ENV['TWITTER_CONSUMER_KEY'], ENV['TWITTER_CONSUMER_SECRET'], site: 'https://api.twitter.com', scheme: :header)
      token_hash = { oauth_token: ENV['TWITTER_ACCESS_TOKEN'], oauth_token_secret: ENV['TWITTER_ACCESS_TOKEN_SECRET'] }
      OAuth::AccessToken.from_hash(consumer, token_hash)
    end
  end
end

See also https://github.com/yhara/simple_twitter


Mapsd: move on the CPU

Usage of GPU:
before:

(weston, ui, modeld, camerad, mapsd)
after:

(weston, ui, modeld, camerad)
TODO:

[ ] ensure cpu performance  and stability is acceptable for mapsd (with a test)
[ ] investigate diff with gpu version (causes model replay diff in thumbnail and navmodel)
[x] schedule mapsd only on a specific CPU (probably the one that was from laikad) and prevent multithreaded rendering with llvmpipe
[ ] cleaner way to get device type in bash, or set an environment variable within manager.py

CPU vs GPU rendered diff. Seems like it might be an antialiasing thing

This is most of the way there:

[ ] add unit test on render times, something like: 1000 iterations, move position for each one, check min/max/avg/stddev
[ ] cleanup the mesa lib handling
[ ] more testing on the output diff

diff for a whole segment
diff.webm

diff.webm
maximum diff of about 8% spinning around SD


Enable local arm64 builds

These changes allow devs who use M1 macs to locally build arm64 docker images.
Also includes som docker file optimizations by merging RUN statements
Building for arm64 requires the environment variable MODELIX_TARGET_PLATFORM to be set to linux/arm64.
The default value for this variable is linux/amd64.
Therefore other devs and CI should be unaffected by these changes.

replaced by #238


Show notifications from AppDelegate

My AppDelegate has callbacks that check the internet connection and i want to show notification when connection is lost irrespective on which VIEW i'm on. How can i get the current view from AppDelegate?
Tried with
let currentView = UIApplication.sharedApplication().keyWindow?.rootViewController
TSMessage.showNotificationInViewController(currentView, title: "Ooopss.....", subtitle: "Network connection error", type: TSMessageNotificationType.Error )

Oh, AppDelegate is not called everytime a new view loads, so i have put this in the callbacks and is working now


Compatible with gulp-reporter & gulp-eslint

Compatible with gulp-reporter, easy to assign errors by developer
Compatible with gulp-eslint, #14

You also need to make it use https://github.com/sindresorhus/eslint-formatter-pretty as a formatter by default.

@sindresorhus
All done.


refactor: refactor number parsers

Implements a couple of new number parsers. Using regular expressions since they provide adequate tradeoff between perf and simplicity.
Resolves #23

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

36 of 36 (100.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
236

Relevant Lines:
236

💛  - Coveralls


Require extensions

Codecov Report

Merging #59 into master will increase coverage by 0.05%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master      #59      +/-   ##
==========================================
+ Coverage   94.93%   94.98%   +0.05%
==========================================
  Files          17       17
  Lines         474      479       +5
==========================================
+ Hits          450      455       +5
  Misses         24       24

Impacted Files
Coverage Δ

lib/jsonapi/serializable/resource/key_format.rb
100% <100%> (ø)
:arrow_up:

lib/jsonapi/serializable/resource.rb
100% <100%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e9d6300...dae68b0. Read the comment docs.


PARQUET-267 - Relax Third Party Dependency Restrictions

Apache Jira Link: https://issues.apache.org/jira/browse/PARQUET-267
This pull request builds on top of https://github.com/apache/parquet-cpp/pull/9.

Can you update the README with some steps on how to get these dependencies you removed? Perhaps just pointing them to the travis config file.
It would be nice to have as few steps as possible between cloning the repo and running the code.

Sure thing.  I added a few lines indicating how to set up a build env and pointed to the .travis.yml as well.  I also rebased the pull request off of the current master.  Let me know what you think.

@kalaxy this is potentially subsumed by #13; I don't have Travis working yet, perhaps we can collaborate.

@wesm, I checked out your branch and tried compiling.  I didn't get far.  It seems that native toolchain, I'm not sure what that is, is sort of a requirement with your cmake setup.  Setting DISABLE_NATIVE_TOOLCHAIN still doesn't allow various libraries to be found properly.  However, we might be able to come up with a merge between our branches that supports both of our use cases.

@wesm, A couple more thoughts.  It looks like cmake_modules/toolchain.cmake is setting up a build environment.  This is a bit contrary to what I was trying to accomplish here.  My personal philosophy is that the build environment should not be in committed code.  I think build config should be sufficiently parameterized to allow any build maintainer or developer flexibility to override library locations and versions as desired while defaulting to system locations and versions.  That was my goal with this pull request, to permit build environment configurability.

@kalaxy the idea is adding an optional portable (across Linux distributions) build environment. I didn't intend to make it the only option, so I will need to fix the build presuming that the user has installed the appropriate system libraries. I think merging our efforts should not be too difficult.
The end goal here is to make adding more 3rd party dependencies easier as well as building and linking libparquet with other projects sharing a common library toolchain.

Superseded by https://github.com/apache/parquet-cpp/pull/16.


Found Broken Link

Update the existing broken link

Vaia ami hackin shikbo plz vaiya🥲🥲

https://github.com/trimstray/the-book-of-secret-knowledge/commit/16bed4809d9f9ca4105d2d10acf0636a3a8- [ ] 527be~~Code
8 @sojinsamuel

~~~~~~


Add tests for Edge equality and hashing

These tests test Edge equality comparison and hashing for regressions and point out some current issues.
For equality comparison (Edge.__eq__()):

Our current definition of edge equality: Same endpoints and, if the parent graph is directed, the same order of endpoints. (Changes to that definition may require changing some of these tests as well.)
Identical objects should compare equal (reflexivity).
Comparisons should be symmetric.
Rich comparison methods should return NotImplemented if they do not implement the operation for the operands provided (see also here).
Availability of equality comparison before the edge has a parent graph.

For hashing (Edge.__hash__()):

Hashable objects which compare equal must have the same hash value (see also here).
The hash value of an hashable object should never change during its lifetime (see also here).
Try to prevent hash collisions, because they may degrade performance.
Availability of the hash method before the edge has a parent graph.

Some tests are based on problems seen with the bug and patches reported in issue pydot/pydot#92. Some other tests are based on examples from articles by Aaron Meurer and Roy Williams and adapted to our Edge class.
The tests that are currently failing have expectedFailure decorators that will be removed as their underlying issues are addressed in future commits.
The PR for this commit is pydot/pydot#249. It should get links to spin-off issues and PRs that discuss the various issues brought up by these tests in more detail.
Additional remark: This PR is based on the fix of commit pydot/pydot@e4742e91 of PR pydot/pydot#248, because if it was based on current master without that fix, the results for test_edge_equality_basics_3_same_points_not_not_equal would differ between Python 2 and Python 3 and it would be difficult to mark it as an expected failure only for Python 2. Please post comments on commit pydot/pydot@e4742e91 in pydot/pydot#248, not here.

For hashing (Edge.__hash__()):

Hashable objects which compare equal must have the same hash value (see also here).
The hash value of an hashable object should never change during its lifetime (see also here).

By those definitions, our Edge objects aren't hashable.
>>> import pydot
>>> e = pydot.Edge("a", "b")
>>> hash(e)
105812016079984353
>>> e.obj_dict["points"] = ("c", "b")
>>> hash(e)
210385293625369463

Like the docs say,

Most of Python’s immutable built-in objects are hashable; mutable containers (such as lists or dictionaries) are not; immutable containers (such as tuples and frozensets) are only hashable if their elements are hashable. Objects which are instances of user-defined classes are hashable by default. They all compare unequal (except with themselves), and their hash value is derived from their id().

We get away with putting Edge objects in a set(), only because it's confined to to_string and the Edge's parameters will never change while inside that function. But technically we're violating Python's API by attaching a __hash__() to a mutable object, and computing that hash in a way that can be affected by the object's stored values.


Updating malachite metric for supporting model inference

There are several things has been done in this pr:

Adding NodeFeatureNames and ContainerFeatureNames to BorweinOptions. Just want @csfldf to have a look here, I just don't know what you mean by "fill it with adaption table" within NewBorweinConfiguration.
Adding some rate metrics like cpu.nr.throttled.container, cpu.nr.period.container, cpu.throttled.time.container etc... There metrics are meaningless as the raw data. And they are put into model training in the form of rate.
Separating  cgroup into two files(cgroupv1, cgroupv2). And having them updated corresponding to response from malachite-core.

@luomingmeng this pr changes too much for fundamental metric-info in meta-server, should it be tested carefully before it can be merged?


Fixed the alignment and responsiveness of the navbar

Closes #1638

Changes proposed
Have fixed the alignment of the navbar by aligning the items in the right and left. Have also made it responsive
Screenshots

Note to reviewers
Please add the gssoc tag on this PR

Summary by CodeRabbit

Style

Updated import statements to use consistent quotation marks across the Navbar component.
Minor adjustments to padding and margins for improved code consistency and aesthetics.

no need to make this changes right now.
kindly try to find genuine bug