[Enhancement]: Improving Theme Toggler Button

Is your enhancement request related to a problem? Please describe.➕
Game enhancement

The entire GameZone looks quite aesthetic. But the theme toggler isn't looking that awesome in styling.

Describe the solution you'd like
Solution steps

I would like to modify the theme toggler designing based on some of the neon designs.

Select program in which you are contributing
GSSoC23
Code of Conduct

[X] I follow CONTRIBUTING GUIDELINE of this project.

Hey @dishamodi0910 , You can't have another issue before completing the previous one 😀
you already have the following 1 open issues 👀 ! :
#2376

Hey @dishamodi0910 ! Thank you so much for your raising the issue💗
It’s all yours, you can come anytime again and make some contributions! 🚀
Alone, we can do little, but together we can do so much! 😇

Hey @dishamodi0910 !
Thank you for raising an issue 💗
You can self assign the issue by commenting /assign in comment 😀
Make sure you follow CODE OF CONDUCT and CONTRIBUTING GUIDELINES 🚀
Don’t Forget to ⭐ our GameZone🎮
Make sure you join our Discord🕹


Ability to apply a setting to all args

 Issue by epage
Monday Nov 08, 2021 at 14:14 GMT
Originally opened as https://github.com/clap-rs/clap/issues/3002

Use Cases

"in our application tests [we need] to set an argument setting on all arguments programmatically just in the test context, and we had a lot of arguments so safest, cleanest, and easiest, to be able to set it with this new function.  Essentially: app.mut_args(|arg| Some(arg.setting(ArgSettings::HideEnvValues)))".  See #2966
AppSettings::AllArgsOverrideSelf is arg configuration that we want to apply everywhere.  Rather than creating specialized arguments, is there a different way?
One option for sorting arguments in help after https://github.com/clap-rs/clap/issues/2808 is to set the same display order on all arguments
App::help_heading allows applying Arg:help_heading to all future arguments to take advantage of the natural grouping of arguments when adding them.

Note: in some cases, users will want this to apply globally (ie to all subcommand args)
Solution Options
Note: this isn't a "pick one" but we can use a mixture

Specialize Arg settings in App (ie do nothing), like

AppSettings::AllArgsOverrideSelf
App::help_heading
A App::next_display_order for #2808
Con:: design / implementation is needed for each solution
Con: each solution ends up different than the others

Direct users to use reflection + mut_arg to manually apply a setting (ie do nothing, see #2976)

This ended up being what we used instead of #2966 which led to it being reverted in #2994
Con: Not ergonomic for clap_derive users (instead of calling Parser, they have to call IntoApp and FromArgMarches)

Provide a App:args_mut(&mut self) -> impl Iterator<Item = &mut Arg>.

Con: Not ergonomic for clap_derive users (instead of calling Parser, they have to call IntoApp and FromArgMarches)

Provide a App::arg_setting

Con: Only works with ArgSettings, so doesn't help with AppSettings::AllArgsOverrideSelf or display_order

mut_args, modeled after mut_arg (see #2966, #2994)

Con: The return type is confusing (should it be just bool?)
Con: Policy of when to return what is unclear

Like mut_args above but Fn doesn't have a return type

mut_arg assumes you are calling it on an arg you intend to keep, so an implicit --version becomes explicit, making it show up when you might have disabled it
#2966 carried this policy forward but provided a return value to avoid adding disabled args
This solution assumes that mass-setting an argument is argument-agnostic and it does not imply the intention of using that argument, so it keeps --version implicit

App::default_arg(arg: Arg) or App::mut_default_arg is layered underneath each arg

We'd have to implement support for tracking what arguments are explicitly set or not to know what is set in the "default arg" and what not to override in each arg
Not all settings should be layered (like alias or long)

App::override_arg(arg: Arg) or App::mut_override_arg is layered on top of each arg

We'd have to implement support for tracking what arguments are explicitly set or not to know what is set in the "override arg"
Not all settings should be layered (like alias or long)

For when to apply these to subcommands, we could

Have a global_ variant of any function, like today's ``global_settings`
Accept a global: bool or scope: enum Scope { Local, Inherit } argument in any function
Layer Subcommands on top of their immediate parent App

Like with default and override args, this will require tracking what configuration is explicitly set
Not all settings should be layered, like alias (used for subcommands)

 Comment by epage
Monday Nov 08, 2021 at 14:15 GMT

@repi in case you have any further thoughts on this topic


[Task]: Cypress tests for Airgap

Is there an existing issue for this?

[X] I have searched the existing issues

SubTasks
No response

Expected completion : 03rd of May, 2023


feat: change font size on responsive for sankey and sunburst chart

Make sunburst and sankey chart responsive
BEFORE
https://user-images.githubusercontent.com/8277264/109154049-6c321580-7776-11eb-8e1b-2842b7ff7433.mov
AFTER
https://user-images.githubusercontent.com/8277264/109971070-7b790c00-7cfe-11eb-8bfb-586e011bcd06.mov
STORYBOOK
https://user-images.githubusercontent.com/8277264/110115600-face1480-7dbe-11eb-9d58-45c4229a7d4d.mov
https://user-images.githubusercontent.com/8277264/110115613-028db900-7dbf-11eb-8e61-774a443528d2.mov

Thank you for the PR!
Sunburst

Have you also tested resizing the CHART in dashboard Edit mode, and resizing the WINDOW in Explore view, from different angles- vertical, horizontal and from conner, and see how they look?
did we set a fixed label text size? We prefer to have it dynamic - text size shrinks as the chart shrinks, to prevent overflow or truncation.

For Sankey,

The chart should hit its min height and width dynamically once the label text disappear. not sure how difficult it is.
Still seeing some label overlapping. We should hide label as soon as they overlap.
hovering text is out of the frame. I consider this information is more important than the chart it self, let's make sure they always show despite the size of the chart.

https://user-images.githubusercontent.com/8277264/109295157-ede97800-7836-11eb-8a9d-a407d38a99c8.mov
@junlincc

https://user-images.githubusercontent.com/8277264/109631102-504fba80-7b4e-11eb-9c2f-384e9459cbcf.mov

@maloun96 Then

Screen.Recording.2021-03-02.at.11.51.38.mov

@maloun96 Thanks Victor, can you confirm
Resizing in Dashboard Edit mode and chart in Explore also works.
For Sankey, what does it look when you hover?

Here is demo for dashboard, edit dashboard and explore mode.
https://user-images.githubusercontent.com/8277264/109804569-10123a00-7c2b-11eb-990f-575f40ac66ac.mov

https://user-images.githubusercontent.com/8277264/109947511-10214100-7ce2-11eb-96b4-5a62202944b1.mov
@villebro

https://user-images.githubusercontent.com/8277264/109966255-b710d780-7cf8-11eb-8a7a-66731816fbc9.mov

https://user-images.githubusercontent.com/8277264/110290324-55e84d00-7ff3-11eb-9589-0c7f67fa8dc0.mov
https://user-images.githubusercontent.com/8277264/110290347-5ed91e80-7ff3-11eb-9bb8-28ddf44ebdbc.mov

@villebro The solution is to hide both elements if they overlap, we can adjust the code to hide only 1 element if needed but will cost performance.

@maloun96 ok, let's leave it for the backlog if this becomes a problem.


[MSAL ANGULAR] Use config function instead of a config object

I'm submitting a...

[ ] Regression (a behavior that used to work and stopped working in a new release)
[ ] Bug report
[ ] Performance issue
[x] Feature request
[ ] Documentation issue or request
[ ] Other... Please describe:

Browser:

[x] Chrome version XX
[x] Firefox version XX
[x] IE version XX
[x] Edge version XX
[x] Safari version XX

Library version

Library version: 0.1.4

Current behavior

[MSAL ANGULAR] For configuring MSAL module you receive an object that is passed over from Msal module to Msal service with static values for configuring the client.
Expected behavior

Pass a valur or an object in order to obtain dynamically the configuration value at the time the service is injected and used for the first time and not when the module is imported.
This will allow to have scenarios where the configuration is pulled from the server or other async sources or at a latter time than import.
Sample scenario
config.service.ts
import { Injectable } from '@angular/core';
import { HttpClient, HttpBackend } from '@angular/common/http';

// Configuration object to be used when requesting result
let appConfig: any = null;

export function configurator() {
  return appConfig;
}

@Injectable()
export class ConfigService {
  http: HttpClient;
  constructor(httpBackend: HttpBackend) {
    // we create our own HttpClient to avoid carrying over any interceptors added such as authentication
    this.http = new HttpClient(httpBackend);
  }

  loadAppConfig(): Promise<any> {
    const promise = this.http.get('/api/clientsettings')
      .toPromise()
      .then(data => {
        appConfig = data;
        return appConfig;
      });

    return promise;
  }

  getConfig(): RemoteAppSettings {
    return appConfig;
  }
}

app.module.ts
import { BrowserModule } from '@angular/platform-browser';
import { NgModule, APP_INITIALIZER } from '@angular/core';
import { HttpClientModule, HttpClient, HttpBackend } from '@angular/common/http';
import { MsalModule, MsalConfig } from '@azure/msal-angular';
import { AppRoutingModule } from './app-routing.module';
import { AppComponent } from './app.component';
import { ConfigService, configurator } from './services/config.service';

const appInitializerFn = (configService: ConfigService) => {
   return configService.loadAppConfig();
};

@NgModule({
  declarations: [
    AppComponent
  ],
  imports: [
    BrowserModule,
    HttpClientModule,
    AppRoutingModule,
    MsalModule.forRoot(configurator),
  ],
  entryComponents: [  ],
  providers: [
    ConfigService,
    {
      provide: APP_INITIALIZER,
      useFactory: appInitializerFn,
      multi: true,
      deps: [ConfigService]
    }
  ],
  bootstrap: [AppComponent]
})
export class AppModule { }

@guevaraf Thanks for the feedback. This has been requested a few times (#963, #1103 , #943), so I'll close this as a duplicate. I'll definitely see that we make this possible in the next version of MSAL Angular.

Hi @jasonnutter, I've tried many of the solutions suggested. They all work with Angular 8, but none work with Angular 9 + Ivy + AOT = true.
In all cases, I see the following error ...
bootstrap-fail NullInjectorError: R3InjectorError(AppModule)[MsalService -> InjectionToken MSAL_CONFIG -> InjectionToken MSAL_CONFIG -> InjectionToken MSAL_CONFIG]:
NullInjectorError: No provider for InjectionToken MSAL_CONFIG!
I'm wondering if this is something that you have seen and whether you have any suggestions?
Thanks

@jrdutton Please see my comments here about Angular 9 + Ivy, specifically links to the new sample: https://github.com/AzureAD/microsoft-authentication-library-for-js/issues/855#issuecomment-593674986

Thanks very much, @jasonnutter, I saw your branch and was very excited. I'd already tried almost identical code to yours within main.ts and app.module.ts, but guess there is something else that I am missing.

@jrdutton Are you using<EMAIL_ADDRESS>

I had the same problem but managed to resolve it with the<EMAIL_ADDRESS>build. The key was replacing 'adalConfig' with MSAL_CONFIG_ANGULAR in the providers section:
    {
      provide: MSAL_CONFIG,
      useFactory: msAdalAngular6ConfigFactory
    },
    {
      provide: MSAL_CONFIG_ANGULAR,
      useFactory: msAdalAngular6ConfigFactory
    },

Hi, we did get this working. We used:
"@azure/msal-angular": "^1.0.0-beta.3"
"msal": "^1.2.2-beta.0"
and then this within our main.ts file...
export function getBaseUrl() {
return document.getElementsByTagName("base")[0].href;
}
fetch(getBaseUrl() + "/api/configuration/authorisation")
.then(response => response.json())
.then(json => {
const configuration = {
auth: {
authority: json.authority,
clientId: json.clientID,
postLogoutRedirectUri: json.postLogoutRedirectUri,
redirectUri: json.redirectUri
},
cache: {
cacheLocation: json.cacheLocation
}
} as Configuration;
platformBrowserDynamic([
{ provide: MSAL_CONFIG, useValue: configuration },
{ provide: MSAL_CONFIG_ANGULAR, useValue: {} }
])
.bootstrapModule(AppModule)
.catch(err => console.error(err));
});


DSD-928: Removing the additionalStyles prop and using style props instead

Fixes JIRA ticket DSD-928
This PR does the following:

Removes the additionalStyles attributes from the Breadcrumbs, Button, Heading, HelperErrorText, Icon, Link, List, Logo, Select, TextInput, and Toggle components.
Updates how styles are passed down to internal components in Card, Checkbox, CheckboxGroup, ComponentWrapper, DatePicker, Hero, Notification, Pagination, Radio, RadioGroup, SearchBar, and Slider. This is based on removing the additionalStyles prop and passing down styles to the __css prop.
Updates how the id is passed in the DatePicker's custom TextInput component.

How has this been tested?
Locally and Storybook. All components were reviewed but they should be re-reviewed.
Accessibility concerns or updates

N/A

Checklist:

[ ] I have updated the Storybook documentation accordingly.
[ ] I have added relevant accessibility documentation for this pull request.
[ ] All new and existing tests passed.

Front End Review:

[ ] View the example in Storybook

Tugboat has finished building the preview for this pull request!
Link:

https://pr973-1pceixbmhxp00fwthskd8wiubickhrfw.tugboat.qa

Dashboard:

https://dashboard.tugboat.qa/6266e8448a3b7b49de2ce8c0

Tugboat has finished building the preview for this pull request!
Link:

https://pr973-1pceixbmhxp00fwthskd8wiubickhrfw.tugboat.qa

Dashboard:

https://dashboard.tugboat.qa/6266e8448a3b7b49de2ce8c0

Tugboat has finished building the preview for this pull request!
Link:

https://pr973-1pceixbmhxp00fwthskd8wiubickhrfw.tugboat.qa

Dashboard:

https://dashboard.tugboat.qa/6266e8448a3b7b49de2ce8c0

Tugboat has finished building the preview for this pull request!
Link:

https://pr973-1pceixbmhxp00fwthskd8wiubickhrfw.tugboat.qa

Dashboard:

https://dashboard.tugboat.qa/6266e8448a3b7b49de2ce8c0


Feature Request: Emby Server support

The ability to poll Emby Server for recently added/played files much like what is available for Kodi/Plex.
https://github.com/MediaBrowser/Emby.ApiClient.Javascript/blob/master/README.md

Duplicate of https://github.com/Hellowlol/HTPC-Manager/issues/181


Please tell me where the password is obtained?

Please tell me where the password is obtained?
Send Transaction
Write
let password = "web3swift"
let result = try! transaction.send(password: password)
Thankyou !!

its a hard coded value

Close for now. Feel free to comment issue if you still need help. 👍


Add invalid_scope error message

The invalid_scope error message is either thrown when the given scope is incorrect (as in: not appstore::apps:readwrite) or, as it turns out, if the security profile that is used is not attached to the App Submission API. This error message makes the plugin more verbose about that mistake.
Also some automated code cleanups.

👍

@FlaShG can you please check these conflicts and try to resolve them if possible

Seems to only have been some indentation - should be fine now.

@FlaShG I see the file changes is 0, and I noticed that we already merged this before and have it in the last release
So now we have a stable version 0.4.0 and you can start using it


refactor(module:badge): implement new code flow

PR Checklist
Please check if your PR fulfills the following requirements:

[X] The commit message follows our guidelines: https://github.com/NG-ZORRO/ng-zorro-antd/blob/master/CONTRIBUTING.md#commit
[ ] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been added / updated (for bug fixes / features)

PR Type
What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[X] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?
Badge component still use structural directive for code flow
Issue Number: N/A
What is the new behavior?
Badge component use now the new code flow
Does this PR introduce a breaking change?
[ ] Yes
[X] No

Other information

code flow -> control flow
WDYT?

code flow -> control flow WDYT?

sorry my bad yes control flow


Minimal IAM Permissions

In the README you link to the Amplify IAM Docs which have an example of the needed IAM permissions to do everything with amplify. Basically an Amplify Admin Policy.
I'd like to see what are the minimal necessary permissions to create the Pull Request preview. My initial thinking is it look like:
{
    "Version": "2012-10-17",
    "Statement": [
        {
            "Sid": "AmplifyPreviewURL",
            "Effect": "Allow",
            "Action": [
                "amplify:ListApps",
                "amplify:ListBranches",
                "amplify:ListDomainAssociations",
                "amplify:GetApp",
                "amplify:CreateBranch",
                "amplify:DeleteBranch",
                "amplify:UpdateApp",
                "amplify:CreateApp",
            ],
            "Resource": "[ARN of Amplify Deployment]"
        }
    ]
}

Hi @sean-smith
Thanks for pointing this out. Please see below for the minimal necessary permissions to create the Pull Request preview. I will update readme at the later time today.
{
    "Version": "2012-10-17",
    "Statement": [
        {
            "Sid": "VisualEditor1",
            "Effect": "Allow",
            "Action": "amplify:StartJob",
            "Resource": "arn:aws:amplify:${Region}:${Account}:apps/{AppId}/branches/*/jobs/*"
        },
        {
            "Sid": "VisualEditor2",
            "Effect": "Allow",
            "Action": [
                "amplify:DeleteBranch",
                "amplify:CreateBranch"
            ],
            "Resource": "arn:aws:amplify:${Region}:${Account}:apps/{AppId}/branches/*"
        }
    ]
}

https://github.com/yinlinchen/amplify-preview-actions/commit/fd354df21899cfc7fea6a8b564326bc609842e1f Readme is updated.

You're the best! While I've got you, how should I go about debugging / testing the feature as a whole?

Hi @sean-smith
You can see the action files here:

Pull request
Merge or close

Live example: https://github.com/yinlinchen/bookapp/pulls
Note that for the PR, first label PR with Ready for review and then assign to a reviewer and it will trigger GitHub actions and you can see the logs in action log, for example.

Thanks @yinlinchen
Couple more suggestions:

The Github Secrets are all uppercased, so providing them as uppercase in the examples would be helpful.
GITHUB_TOKEN for some reason wasn't allowed for me. I had to use GITHUBTOKEN instead. I don't know if this is something specific for my organization or broader.

Here's what I've changed. See https://github.com/aws-samples/aws-hpc-tutorials/pull/21 for an example
        AWS_ACCESS_KEY_ID: ${{ secrets.AWS_ACCESS_KEY_ID }}
        AWS_SECRET_ACCESS_KEY: ${{ secrets.AWS_SECRET_ACCESS_KEY }}
        GITHUB_TOKEN: ${{ secrets.GITHUBTOKEN }}
        AmplifyAppId: ${{ secrets.AMPLIFYAPPID }}
        BackendEnvARN: ${{ secrets.BACKENDENVARN }}
        AWS_REGION: 'us-east-1'

Should I enabled PR previews?
i.e.

@sean-smith Thanks for the suggestion, I updated the readme. https://github.com/yinlinchen/amplify-preview-actions/commit/bb739b369fe498b8b286e6e4d2188841ec482278
GitHub automatically creates a GITHUB_TOKEN secret to use in your workflow. You can use it directly, see About the GITHUB_TOKEN secret
You don't need to enable PR previews in the Amplify console.

Thanks! Really great tool
On Sep 15, 2020, at 6:22 PM, Yinlin Chen<EMAIL_ADDRESS>wrote:

@sean-smithhttps://github.com/sean-smith Thanks for the suggestion, I updated the readme. bb739b3https://github.com/yinlinchen/amplify-preview-actions/commit/bb739b369fe498b8b286e6e4d2188841ec482278
GitHub automatically creates a GITHUB_TOKEN secret to use in your workflow. You can use it directly, see About the GITHUB_TOKEN secrethttps://docs.github.com/en/actions/configuring-and-managing-workflows/authenticating-with-the-github_token#about-the-github_token-secret
You don't need to enable PR previews in the Amplify console.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/yinlinchen/amplify-preview-actions/issues/5#issuecomment-693113586, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ABKJ77FVXGE4DSPP22QHTFTSGAHINANCNFSM4RMUAEXQ.

How do you get the BackendEnvARN? Is this the same as the App Arn shown in the console?

@sean-smith Please see https://github.com/yinlinchen/amplify-preview-actions/issues/2

Thanks @yinlinchen
I've opened https://github.com/yinlinchen/amplify-preview-actions/pull/6 to clarify these parameters.

I think we can close this now. Thanks @yinlinchen for answering all my questions, really appreciate it!


Skip/fix failing Cypress tests

Description
As we do not have a fork repository of [tests repo][tests-repo], we need to skip the Cypress tests that are failing due to our changes, at least until we find a better solution.
Tasks

[x] Detect the tests that fail.
[ ] Detect tests that fail because of our changes. If so, skip them.
[ ] For the tests that fail for other reason, find a way to solve them.

We expected all the tests from the Cypress tests suite to pass.

Failing Cypress tests
I downloaded and checked the logs for the action run #4546799396.
Summary

Details

core-opensearch-dashboards/opensearch-dashboards/apps/vis_builder/basic.spec.js

Visualization Builder Base Tests
Create new basic metric visualization:
CypressError: Timed out retrying after 60000ms: cy.trigger() failed because this element:

<button data-test-subj="field-undefined-showDetails" class="osd-resetFocusState osdFieldButton__button">...</button>
is being covered by another element:

...

Fix this problem, or use {force: true} to disable error checking.
https://on.cypress.io/element-cannot-be-interacted-with

Visualization Builder Base Tests
Be able to add/ edit and remove a field:
CypressError: Timed out retrying after 60050ms: cy.click() failed because this element:

<button class="euiSuperDatePicker__prettyFormat" data-test-subj="superDatePickerShowDatesButton">...</button>
is being covered by another element:

...

Fix this problem, or use {force: true} to disable error checking.
https://on.cypress.io/element-cannot-be-interacted-with

core-opensearch-dashboards/opensearch-dashboards/apps/vis_builder/dashboard.spec.js

Visualization Builder Dashboard Tests
Should be able to create a visualization:
CypressError: Timed out retrying after 60000ms: cy.trigger() failed because this element:

<button data-test-subj="field-age-showDetails" class="osd-resetFocusState osdFieldButton__button">...</button>
is being covered by another element:

...

Fix this problem, or use {force: true} to disable error checking.
https://on.cypress.io/element-cannot-be-interacted-with

Visualization Builder Dashboard Tests
Should be able to edit a visualization:
AssertionError: Timed out retrying after 60000ms: Expected to find element: [data-test-subj="dashboardEditMode"], but never found it.
at Context.eval (http://localhost:5601/__cypress/tests?p=cypress/support/index.js:386:13)

core-opensearch-dashboards/opensearch-dashboards/apps/vis_builder/vis_types/area.spec.js

Vis Builder: Area Chart
Basic test:
CypressError: Timed out retrying after 60000ms: cy.trigger() failed because this element:

<button data-test-subj="field-salary-showDetails" class="osd-resetFocusState osdFieldButton__button">...</button>
is being covered by another element:

...

Fix this problem, or use {force: true} to disable error checking.
https://on.cypress.io/element-cannot-be-interacted-with

core-opensearch-dashboards/opensearch-dashboards/apps/vis_builder/vis_types/bar.spec.js

Vis Builder: Bar Chart
Basic test:
CypressError: Timed out retrying after 60000ms: cy.trigger() failed because this element:

<button data-test-subj="field-salary-showDetails" class="osd-resetFocusState osdFieldButton__button">...</button>
is being covered by another element:

...

Fix this problem, or use {force: true} to disable error checking.
https://on.cypress.io/element-cannot-be-interacted-with

core-opensearch-dashboards/opensearch-dashboards/apps/vis_builder/vis_types/line.spec.js

Vis Builder: Line Chart
Basic test:
CypressError: Timed out retrying after 60000ms: cy.trigger() failed because this element:

<button data-test-subj="field-salary-showDetails" class="osd-resetFocusState osdFieldButton__button">...</button>
is being covered by another element:

...

Fix this problem, or use {force: true} to disable error checking.
https://on.cypress.io/element-cannot-be-interacted-with

core-opensearch-dashboards/opensearch-dashboards/apps/vis_builder/vis_types/metric.spec.js

Vis Builder: Metric Chart
Basic test:
CypressError: Timed out retrying after 60000ms: cy.trigger() failed because this element:

<button data-test-subj="field-undefined-showDetails" class="osd-resetFocusState osdFieldButton__button">...</button>
is being covered by another element:

...

Fix this problem, or use {force: true} to disable error checking.
https://on.cypress.io/element-cannot-be-interacted-with

core-opensearch-dashboards/opensearch-dashboards/apps/vis_builder/vis_types/table.spec.js

Vis Builder: Table Chart
Basic test:
CypressError: Timed out retrying after 60000ms: cy.trigger() failed because this element:

<button data-test-subj="field-undefined-showDetails" class="osd-resetFocusState osdFieldButton__button">...</button>
is being covered by another element:

...

Fix this problem, or use {force: true} to disable error checking.
https://on.cypress.io/element-cannot-be-interacted-with

core-opensearch-dashboards/opensearch-dashboards/dashboard_sanity_test_spec.js (7/34)

dashboard sample data validation
checking home page
checking tutorial_directory display:
AssertionError: Timed out retrying after 60000ms: Expected to find element: a[href="/app/home#/tutorial_directory"], but never found it.

dashboard sample data validation
adding sample data
"before all" hook for "checking ecommerce dashboards displayed":
AssertionError: Timed out retrying after 60000ms: Expected to find element: button[data-test-subj="addSampleDataSetecommerce"], but never found it.

dashboard sample data validation
adding sample data
"after all" hook for "checking ecommerce dashboards displayed":
CypressError: You attempted to make a chai-jQuery assertion on an object that is neither a DOM object or a jQuery object.

dashboard sample data validation
checking Dev Tools
checking welcome panel display:
AssertionError: Timed out retrying after 60000ms: Expected to find element: div[data-test-subj="welcomePanel"], but never found it.

dashboard sample data validation
checking Dev Tools
checking dismiss button display:
AssertionError: Timed out retrying after 60000ms: Expected to find element: button[data-test-subj="help-close-button"], but never found it.

dashboard sample data validation
checking Dev Tools
checking console input area display:
AssertionError: Timed out retrying after 60000ms: Expected to find element: div[data-test-subj="request-editor"], but never found it.

dashboard sample data validation
checking Dev Tools
checking console output area display:
AssertionError: Timed out retrying after 60000ms: Expected to find element: div[data-test-subj="response-editor"], but never found it.

Was not taking the correct branch from the cypress repository that's why some tests were failing.
With the change of the workflow they still do not pass the sample data tests.
I'm still looking to see if I can omit those tests as we modify that part and they will fail every time.


i/o timeout kubernetes v1.19.5 cluster-ip container runtime containerd

Description
i/o timeout to kubernetes cluster-ip <IP_ADDRESS>:443
Impact
coredns pod not working
flatcar linux kubernetes cluster domain cluster.local not working
Environment and steps to reproduce
OS-IMAGE: Flatcar Container Linux by Kinvolk 2605.10.0 (Oklo)
KERNEL-VERSION: 5.4.83-flatcar
CONTAINER-RUNTIME: containerd://1.4.3

Set-up: [ describe the environment Flatcar/Lokomotive/Nebraska etc was running in when encountering the bug; Platform etc. ] cloud-config with ignition
Task: [ describe the task performing when encountering the bug ] kubectl create -f coredns.yaml
Action(s): [ sequence of actions that triggered the bug, see example below ] check coredns log
a. [ requested the start of a new pod or container ]
b. [ container image downloaded ] coredns v1.8.0
Error: [describe the error that was triggered]

coredns
I1218 06:28:53.487296 1 trace.go:205] Trace[1925137650]: "Reflector ListAndWatch" name:pkg/mod/k8s.io/client-go@v0.19.2/tools/cache/reflector.go:156 (18-Dec-2020 06:28:23.486) (total time: 30000ms):
coredns
Trace[1925137650]: [30.000673657s] [30.000673657s] END
coredns
E1218 06:28:53.487332 1 reflector.go:127] pkg/mod/k8s.io/client-go@v0.19.2/tools/cache/reflector.go:156: Failed to watch *v1.Endpoints: failed to list *v1.Endpoints: Get "https://<IP_ADDRESS>:443/api/v1/endpoints?limit=500&resourceVersion=0": dial tcp <IP_ADDRESS>:443: i/o timeout
coredns
I1218 06:29:10.427621 1 trace.go:205] Trace[1296256991]: "Reflector ListAndWatch" name:pkg/mod/k8s.io/client-go@v0.19.2/tools/cache/reflector.go:156 (18-Dec-2020 06:28:40.426) (total time: 30000ms):
coredns
Trace[1296256991]: [30.00065242s] [30.00065242s] END
coredns
E1218 06:29:10.427654 1 reflector.go:127] pkg/mod/k8s.io/client-go@v0.19.2/tools/cache/reflector.go:156: Failed to watch *v1.Service: failed to list *v1.Service: Get "https://<IP_ADDRESS>:443/api/v1/services?limit=500&resourceVersion=0": dial tcp <IP_ADDRESS>:443: i/o timeout
coredns
I1218 06:29:55.298892 1 trace.go:205] Trace[264714510]: "Reflector ListAndWatch" name:pkg/mod/k8s.io/client-go@v0.19.2/tools/cache/reflector.go:156 (18-Dec-2020 06:29:25.297) (total time: 30001ms):
coredns
Trace[264714510]: [30.001039258s] [30.001039258s] END
coredns
E1218 06:29:55.298914 1 reflector.go:127] pkg/mod/k8s.io/client-go@v0.19.2/tools/cache/reflector.go:156: Failed to watch *v1.Namespace: failed to list *v1.Namespace: Get "https://<IP_ADDRESS>:443/api/v1/namespaces?limit=500&resourceVersion=0": dial tcp <IP_ADDRESS>:443: i/o timeout
coredns
I1218 06:30:17.872861 1 trace.go:205] Trace[459501464]: "Reflector ListAndWatch" name:pkg/mod/k8s.io/client-go@v0.19.2/tools/cache/reflector.go:156 (18-Dec-2020 06:29:47.872) (total time: 30000ms):
coredns
Trace[459501464]: [30.000562308s] [30.000562308s] END
coredns
E1218 06:30:17.872882 1 reflector.go:127] pkg/mod/k8s.io/client-go@v0.19.2/tools/cache/reflector.go:156: Failed to watch *v1.Endpoints: failed to list *v1.Endpoints: Get "https://<IP_ADDRESS>:443/api/v1/endpoints?limit=500&resourceVersion=0": dial tcp <IP_ADDRESS>:443: i/o timeout
coredns
I1218 06:30:39.309708 1 trace.go:205] Trace[1739290457]: "Reflector ListAndWatch" name:pkg/mod/k8s.io/client-go@v0.19.2/tools/cache/reflector.go:156 (18-Dec-2020 06:30:09.309) (total time: 30000ms):
coredns
Trace[1739290457]: [30.000547228s] [30.000547228s] END
coredns
E1218 06:30:39.309731 1 reflector.go:127] pkg/mod/k8s.io/client-go@v0.19.2/tools/cache/reflector.go:156: Failed to watch *v1.Service: failed to list *v1.Service: Get "https://<IP_ADDRESS>:443/api/v1/services?limit=500&resourceVersion=0": dial tcp <IP_ADDRESS>:443: i/o timeout

Expected behavior
[ describe what you expected to happen at 4. above but instead got an error ]
Kubernetes v1.19.5 with container runtime docker:
coredns
.:53
coredns
[INFO] plugin/reload: Running configuration MD5 = f68047850b236e33a043cf64188722fd
coredns
CoreDNS-1.8.0
coredns
linux/amd64, go1.15.3, 054c9ae

Additional information
Please add any information here that does not fit the above format.
- name: containerd.service
       enabled: true
       dropins:
       - name: 10-use-custom-config.conf
         contents: |
           [Service]
           Environment=CONTAINERD_CONFIG=/etc/containerd/config.toml
           ExecStart=
           ExecStart=/usr/bin/env PATH=${TORCX_BINDIR}:${PATH} ${TORCX_BINDIR}/containerd --config ${CONTAINERD_CONFIG}

- path: /etc/containerd/config.toml
      filesystem: root
      mode: 0600
      contents:
        inline: |
          # persistent data location
          root = "/var/lib/containerd"
          # runtime state information
          state = "/run/docker/libcontainerd/containerd"
          # set containerd as a subreaper on linux when it is not running as PID 1
          subreaper = true
          # set containerd's OOM score
          oom_score = -999
          # CRI plugin listens on a TCP port by default
          disabled_plugins = []

          # grpc configuration
          [grpc]
          address = "/run/docker/libcontainerd/docker-containerd.sock"
          # socket uid
          uid = 0
          # socket gid
          gid = 0

          [plugins.linux]
          # shim binary name/path
          shim = "containerd-shim"
          # runtime binary name/path
          runtime = "runc"
          # do not use a shim when starting containers, saves on memory but
          # live restore is not supported
          no_shim = false
          # display shim logs in the containerd daemon's log output
          shim_debug = true

- name: "kube-kubelet.service"
       enable: true
       contents: |
         [Unit]
         Description=Kubernetes Kubelet
         Documentation=https://github.com/kubernetes/kubernetes
         Requires=setup-network-environment.service
         After=setup-network-environment.service
         [Service]
         Environment=no_proxy=localhost,<IP_ADDRESS>/8,<IP_ADDRESS>,::1,<IP_ADDRESS>,manager-01,manager-01.bnpb.go.id,bnpb.go.id,/run/docker/libcontainerd/docker-containerd.sock
         EnvironmentFile=/etc/network-environment
         # wait for kubernetes master to be up and ready
         ExecStart=/opt/bin/kubelet \
           --config="/var/lib/kubelet/kubelet-config.yaml" \
           --bootstrap-kubeconfig="/etc/kubernetes/ssl/bootstrap.kubeconfig.yaml" \
           --hostname-override=manager-01.bnpb.go.id \
           --kubeconfig="/etc/kubernetes/ssl/bootstrap.kubeconfig.yaml" \
           --cert-dir="/etc/kubernetes/ssl" \
           --container-runtime="remote" \
           --container-runtime-endpoint="unix:///run/docker/libcontainerd/docker-containerd.sock" \
           --containerd="/run/docker/libcontainerd/docker-containerd.sock" \
           --docker="unix:///run/docker/libcontainerd/docker-containerd.sock" \
           --docker-endpoint="unix:///run/docker/libcontainerd/docker-containerd.sock" \
           --image-pull-progress-deadline=2m \
           --lock-file="/var/run/lock/kubelet.lock" \
           --exit-on-lock-contention \
           --logtostderr="true" \
           --register-node="true" \
           --node-labels="label=master" \
           --v=3
         Restart=on-failure
         RestartSec=5
         [Install]
         WantedBy=multi-user.target

NAMESPACE     NAME                      READY   UP-TO-DATE   AVAILABLE   AGE     CONTAINERS   IMAGES                   SELECTOR
kube-system   deployment.apps/coredns   1/1     1            1           3h50m   coredns      coredns/coredns:latest   k8s-app=kube-dns

NAMESPACE     NAME                                 DESIRED   CURRENT   READY   AGE     CONTAINERS   IMAGES                   SELECTOR
kube-system   replicaset.apps/coredns-6787b6d45d   1         1         1       3h50m   coredns      coredns/coredns:latest   k8s-app=kube-dns,pod-template-hash=6787b6d45d

NAMESPACE     NAME                 TYPE        CLUSTER-IP    EXTERNAL-IP   PORT(S)                  AGE     SELECTOR
default       service/kubernetes   ClusterIP   <IP_ADDRESS>    <none>        443/TCP                  3h52m   <none>
kube-system   service/kube-dns     ClusterIP   <IP_ADDRESS>   <none>        53/UDP,53/TCP,9153/TCP   3h50m   k8s-app=kube-dns

NAMESPACE     NAME                           READY   STATUS    RESTARTS   AGE     IP            NODE                    NOMINATED NODE   READINESS GATES
kube-system   pod/coredns-6787b6d45d-fnm84   1/1     Running   0          3h50m   <IP_ADDRESS>   manager-01.bnpb.go.id   <none>           <none>

core@manager-01 ~ $ for f in /proc/sys/net/ipv4/conf/*/forwarding; do echo -n $f ": "; cat $f; done
/proc/sys/net/ipv4/conf/all/forwarding : 1
/proc/sys/net/ipv4/conf/cni0/forwarding : 1
/proc/sys/net/ipv4/conf/default/forwarding : 1
/proc/sys/net/ipv4/conf/docker0/forwarding : 1
/proc/sys/net/ipv4/conf/ens32/forwarding : 1
/proc/sys/net/ipv4/conf/flannel.1/forwarding : 1
/proc/sys/net/ipv4/conf/kube-ipvs0/forwarding : 1
/proc/sys/net/ipv4/conf/lo/forwarding : 1
/proc/sys/net/ipv4/conf/veth1e594bc/forwarding : 1
/proc/sys/net/ipv4/conf/veth474b6b8/forwarding : 1
/proc/sys/net/ipv4/conf/veth48774175/forwarding : 1

If i used docker as kubernetes container runtime, coredns working properly,
Need your advice,
Thank you

Thanks for the report. I have a few questions:

On what platform are you running this? (AWS, Azure, EKS, GKE, bare metal, etc).
Was this working before, or did you only now start trying to move to containerd?
This looks very much like pod connectivity issues. Can you please try running another pod in the cluster and check whether you can reach the node, the outside world, etc? For example, you can do this using a debugging pod like kubectl run -it net --image=praqma/network-multitool -- sh, and then checking whether you can ping the node ip, the ip of another node, an external ip like <IP_ADDRESS> and so on.

On what platform are you running this? (AWS, Azure, EKS, GKE, bare metal, etc). We run it on bare metal vmware vsphere
Was this working before, or did you only now start trying to move to containerd? Always working with container runtime docker
This looks very much like pod connectivity issues. Can you please try running another pod in the cluster and check whether you can reach the node, the outside world, etc? For example, you can do this using a debugging pod like kubectl run -it net --image=praqma/network-multitool -- sh, and then checking whether you can ping the node ip, the ip of another node, an external ip like <IP_ADDRESS> and so on. Connectivity is working properly, i can ping flannel v0.13.0-amd64 vxlan <IP_ADDRESS>/17, cluster-ip <IP_ADDRESS>/16 and can ping <IP_ADDRESS> via coredns forward to host dns. I will provide screenshot at monday

Wait, I think i've made configuration mistake,
Here is my flannel cloud-config:
- name: "flanneld.service"
       enable: true
       dropins:
         - name: "50-ssl.conf"
           contents: |
             [Unit]
             Description=Flannel etcd ssl dir
             Requires=etcd-member.service etcd-v3-datastore.service
             After=etcd-member.service etcd-v3-datastore.service
             [Service]
             Environment="ETCD_SSL_DIR=/var/lib/etcd/ssl"
         - name: "50-network-config.conf"
           contents: |
             [Unit]
             Description=Flannel networking vxlan
             Requires=etcd-member.service etcd-v3-datastore.service
             After=etcd-member.service etcd-v3-datastore.service
             [Service]
             Environment="FLANNEL_IMAGE_TAG=v0.13.0-amd64"
             Environment="FLANNEL_IMAGE_URL=quay.io/coreos/flannel"
             Environment="FLANNEL_ETCD=https://<IP_ADDRESS>:2379"
             Environment="FLANNEL_ETCD_KEY=/coreos.com/network2"
             ExecStartPre=ETCDCTL_API=2 /usr/bin/etcdctl --ca-file=/etc/ssl/certs/ca.pem --cert-file=/var/lib/etcd/ssl/etcd-node.pem --key-file=/var/lib/etcd/ssl/etcd-node-key.pem --endpoints="https://<IP_ADDRESS>:2379" set /coreos.com/network2/config '{ "Network":"<IP_ADDRESS>/16", "SubnetLen": 24, "SubnetMin": "<IP_ADDRESS>", "SubnetMax":"<IP_ADDRESS>", "Backend": {"Type": "vxlan"} }'

flannel network cidr <IP_ADDRESS>/16,
But my apiserver and controller manager configurations are :
--service-cluster-ip-range=<IP_ADDRESS>/16
--cluster-cidr=<IP_ADDRESS>/17

cidr <IP_ADDRESS>/16 is outside flannel cidr <IP_ADDRESS>/16,
what if i change something like this:
--service-cluster-ip-range=<IP_ADDRESS>/17
--cluster-cidr=<IP_ADDRESS>/17

Will it fix the issue ??
Need your advice,
Thank you

Hey there! Did you try out your proposed solution? Did it work?

Hey there! Did you try out your proposed solution? Did it work?

@marga-kinvolk ,
No it doesn't work, i can not curl https://<IP_ADDRESS>:443/version,
kubernetes service targetport is <IP_ADDRESS>:6443,
Should i expose kubernetes secure port via haproxy ??
`docker run
--name my-running-haproxy
-v /home/core/haproxy:/usr/local/etc/haproxy:ro
-p 80:80
-p 443:443
haproxytech/haproxy-alpine:2.4
=================================================================
core@manager-01 ~ $ cat haproxy.conf
global
log stdout format raw local0
maxconn 1024
defaults
log global
timeout connect 10s
timeout client 86400s
timeout server 86400s
timeout tunnel 86400s
frontend fe_main
bind :6443 ssl crt /usr/local/etc/haproxy/haproxy.pem
mode http
default_backend be_main
backend be_main
mode http
balance leastconn
server kube-apiserver <IP_ADDRESS>:6443 check ssl verify none`
But it doesn't work either, i need help please

@marga-kinvolk ,
No it doesn't work, i can not curl https://<IP_ADDRESS>:443/version,
kubernetes service targetport is <IP_ADDRESS>:6443,
Should i expose kubernetes secure port via haproxy ??
`docker run
--name my-running-haproxy
-v /home/core/haproxy:/usr/local/etc/haproxy:ro
-p 80:80
-p 443:443
haproxytech/haproxy-alpine:2.4
=================================================================
core@manager-01 ~ $ cat haproxy.conf
global
log stdout format raw local0
maxconn 1024
defaults
log global
timeout connect 10s
timeout client 86400s
timeout server 86400s
timeout tunnel 86400s
frontend fe_main
bind :6443 ssl crt /usr/local/etc/haproxy/haproxy.pem
mode http
default_backend be_main
backend be_main
mode http
balance leastconn
server kube-apiserver <IP_ADDRESS>:6443 check ssl verify none`
But it doesn't work either, i need help please

Now it's working properly,
I did this command: sudo update-ca-certificates

Thank you


Customize generateNotes configuration

We are using semantic-release and semantic-release-monorepo in our project and want to modify the default conventional-changelog-angular writerOpts configuration (specifically the transform function).
Following the guidelines for semantic release, I added the function at the root of the config object and my changes were applied to the changelog notes in GH.
module.exports = {
  branches: ['master'],
  githubUrl: 'https://github.ibm.com',
  githubApiPathPrefix: 'api/v3',
  releaseRules: [...],
  generateNotes: {
    preset: 'angular',
    writerOpts: {
      transform: (commit, context) => {...},
    }
  },
  releaseNotes: {
    issueResolution: {
      template: '{baseUrl}/{owner}/{repo}/issues/{ref}',
      baseUrl: 'https://github.ibm.com',
      source: 'github.ibm.com',
    },
  },
}

However, with this approach we lost the commit package scoping that is provided by semantic-release-monorepo.
In a different project we use semantic-release-gitmoji as our changelog convention and were able to set it up to work with semantic-release-monorepo by doing the following:
module.exports = {
  monorepo: {
    analyzeCommits: 'semantic-release-gitmoji',
    generateNotes: 'semantic-release-gitmoji',
  },
  branches: ['develop'],
  githubUrl: 'https://github.ibm.com',
  githubApiPathPrefix: 'api/v3',
  releaseRules,
  releaseNotes: {
    template,
    partials: {
      commitTemplate,
      emojiCommitsTemplate,
    },
    issueResolution: {
      template: '{baseUrl}/{owner}/{repo}/issues/{ref}',
      baseUrl: 'https://github.ibm.com',
      source: 'github.ibm.com',
    },
  },
};

I tried to do something similar in my current project:
module.exports = {
  monorepo: {
    generateNotes: {
      preset: 'angular',
      writerOpts: {
        transform: (commit, context) => {...},
      }
    },
  },
  branches: ['master'],
  githubUrl: 'https://github.ibm.com',
  githubApiPathPrefix: 'api/v3',
  releaseRules: [...],
  releaseNotes: {
    issueResolution: {
      template: '{baseUrl}/{owner}/{repo}/issues/{ref}',
      baseUrl: 'https://github.ibm.com',
      source: 'github.ibm.com',
    },
  },
}

but did not have any luck as it reverted back to using the default transform function
Debug with generateNotes in monorepo:
options values: { branches:
  [ 'master',
    { name: 'staging', prerelease: true } ],
 repositoryUrl: 'git@github.ibm.com:liz-judd/semantic-release-testing.git',
 tagFormat: '@whpal/liz-semrel-testing-utilities-v${version}',
 plugins:
  [ '@semantic-release/commit-analyzer',
    '@semantic-release/release-notes-generator',
    '@semantic-release/npm',
    '@semantic-release/github' ],
 analyzeCommits:
  [ [AsyncFunction],
    [AsyncFunction],
    [AsyncFunction],
    [AsyncFunction],
    [AsyncFunction],
    [AsyncFunction],
    [AsyncFunction],
    [AsyncFunction],
    [AsyncFunction],
    [AsyncFunction] ],
 generateNotes:
  [ [AsyncFunction],
    [AsyncFunction],
    [AsyncFunction],
    [AsyncFunction],
    [AsyncFunction],
    [AsyncFunction],
    [AsyncFunction],
    [AsyncFunction],
    [AsyncFunction],
    [AsyncFunction] ],
 monorepo:
  { generateNotes: { preset: 'angular', writerOpts: [Object] } },
 githubUrl: 'https://github.ibm.com',
 githubApiPathPrefix: 'api/v3',
 releaseRules:  [ ... ],
 releaseNotes:
  { issueResolution:
     { template: '{baseUrl}/{owner}/{repo}/issues/{ref}',
       baseUrl: 'https://github.ibm.com',
       source: 'github.ibm.com' } },
 }

Debug with generateNotes at root:
options values: { branches:
  [ 'master',
    { name: 'staging', prerelease: true } ],
 repositoryUrl: 'git@github.ibm.com:liz-judd/semantic-release-testing.git',
 tagFormat: '@whpal/liz-semrel-testing-utilities-v${version}',
 plugins:
  [ '@semantic-release/commit-analyzer',
    '@semantic-release/release-notes-generator',
    '@semantic-release/npm',
    '@semantic-release/github' ],
 analyzeCommits:
  [ [AsyncFunction],
    [AsyncFunction],
    [AsyncFunction],
    [AsyncFunction],
    [AsyncFunction],
    [AsyncFunction],
    [AsyncFunction],
    [AsyncFunction],
    [AsyncFunction],
    [AsyncFunction] ],
 generateNotes:
  { preset: 'angular',
    writerOpts: { transform: [Function: transform] } },
 githubUrl: 'https://github.ibm.com',
 githubApiPathPrefix: 'api/v3',
 releaseRules: [...],
 releaseNotes:
  { issueResolution:
     { template: '{baseUrl}/{owner}/{repo}/issues/{ref}',
       baseUrl: 'https://github.ibm.com',
       source: 'github.ibm.com' } },
}

FYI, After going through some closed issues I also tried the following without any luck:
module.exports = {
  monorepo: {
    plugins:[
      '@semantic-release/commit-analyzer',
      ['@semantic-release/release-notes-generator', {
        generateNotes: getGenerateNotes(),
      }],
      '@semantic-release/npm',
      '@semantic-release/github'
    ],
  },
  branches: ['master'],
  githubUrl: 'https://github.ibm.com',
  githubApiPathPrefix: 'api/v3',
  releaseRules: [ ... ],
  releaseNotes: {
    issueResolution: {
      template: '{baseUrl}/{owner}/{repo}/issues/{ref}',
      baseUrl: 'https://github.ibm.com',
      source: 'github.ibm.com',
    },
  },
}

Thanks for the report, @elizabethsjudd! Does it work if you move the plugins key to the top-level?
E.g.:
module.exports = {
  plugins: [
    '@semantic-release/commit-analyzer',
    ['@semantic-release/release-notes-generator', {
      preset: 'angular',
      writerOpts: {
        transform: (commit, context) => {...},
      }
    }],
    '@semantic-release/npm',
    '@semantic-release/github'
  ],
  branches: ['master'],
  githubUrl: 'https://github.ibm.com',
  githubApiPathPrefix: 'api/v3',
  releaseRules: [ ... ],
  releaseNotes: {
    issueResolution: {
      template: '{baseUrl}/{owner}/{repo}/issues/{ref}',
      baseUrl: 'https://github.ibm.com',
      source: 'github.ibm.com',
    },
  },
}

@pmowrer That doesn't even create the custom release notes at all. Is this something I should be bring up with release-notes-generator as semantic-release-monorepo is expecting this format?

It depends on what version of semantic-release-monorepo and semantic-release you're trying this with. The monorepo namespace key in the config was deprecated as of v7 of this lib and would have no effect.

@pmowrer these are the versions I'm using. So it looks like I shouldn't be using monorepo at all.
    "semantic-release": "^17.0.4",
    "semantic-release-monorepo": "^7.0.1"

I guess my confusion is... is this a bug for:

release-notes-generator - I can't use the plugins property to configure it and then semantic-release-monorepo would be able to use that

semantic-release-monorepo - it doesn't work with the generateNotes property supported by release-notes-generator

It's most likely a bug with this library... I'll dig into it!

I believe this has been fixed in the latest version (7.0.2). Please re-open if it's still an issue.

:tada: This issue has been resolved in version 7.0.2 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

@pmowrer, I updated our version of monorepo to 7.0.2 and am still having the same issue where defining a custom  generateNotesobject  (at the root of the config) does not scope the commits to the specific packages.
Example
both of the commits under build system should not be part of a thing4 package release as they are part of a utilities package (these screen shots are a dummy repo we use for testing)

I'm also now running in to the issue of it not recognizing our custom releaseRules property either. I used to be able to have a release with the build type and now that is no longer possible.
Here's our release rules:
[
    {breaking: true, release: 'major'},
    {revert: true, release: 'patch'},
    {type: 'feat', release: 'minor'},
    {type: 'fix', release: 'patch'},
    {type: 'perf', release: 'patch'},
    {type: 'docs', release: 'patch'},
    {type: 'style', release: 'patch'},
    {type: 'test', release: 'patch'},
    {type: 'build', release: 'patch'},
    {type: 'ci', release: 'patch'},
    {type: 'refactor', release: 'patch'},
  ],

but when I have a merge with only a build type, our CI system says it does not detect any changes
[semantic-release] › ✔  Completed step "analyzeCommits" of plugin "[Function: semantic-release-monorepo]"
[semantic-release] › ℹ  There are no relevant changes, so no new version is released.

@elizabethsjudd Thanks for trying this out and sorry it still isn't working! A few questions as I try to diagnose this further:

Do you mind sharing the release config that was used in your latest test (at least the plugins part)?
Is the config in a .releaserc file or is it applied some other way?
If you run with the --debug flag, are you seeing the following message: semantic-release:monorepo Filter commits by package path: "" +0ms? If so, what follows?

Release config:
{ branches:
   [ 'master',
     { name: 'staging', prerelease: true },
     { name: 'v1', channel: 'v1x' },
     { name: 'next', prerelease: true } ],
  githubUrl: 'https://github.ibm.com',
  githubApiPathPrefix: 'api/v3',
  releaseRules:
   [ { breaking: true, release: 'major' },
     { revert: true, release: 'patch' },
     { type: 'feat', release: 'minor' },
     { type: 'fix', release: 'patch' },
     { type: 'perf', release: 'patch' },
     { type: 'docs', release: 'patch' },
     { type: 'style', release: 'patch' },
     { type: 'test', release: 'patch' },
     { type: 'build', release: 'patch' },
     { type: 'ci', release: 'patch' },
     { type: 'refactor', release: 'patch' },
     { scope: 'minor-*', release: 'minor' },
     { scope: 'patch-*', release: 'patch' },
     { scope: 'no-release', release: false } ],
  releaseNotes:
   { issueResolution:
      { template: '{baseUrl}/{owner}/{repo}/issues/{ref}',
        baseUrl: 'https://github.ibm.com',
        source: 'github.ibm.com' } },
  generateNotes:
   { preset: 'angular',
     writerOpts: { transform: [Function: transform] } },
  tagFormatPrefix: '@whpal/liz-semrel-testing-',
  tagFormat: '@whpal/liz-semrel-testing-utilities-v${version}' }

We do not have any custom plugin setup.
Here's the config that's printed out from the --debug flag
semantic-release:config options values: { branches:
  semantic-release:config    [ 'master',
  semantic-release:config      { name: 'staging', prerelease: true },
  semantic-release:config      { name: 'v1', channel: 'v1x' },
  semantic-release:config      { name: 'next', prerelease: true } ],
  semantic-release:config   repositoryUrl: 'git@github.ibm.com:liz-judd/semantic-release-testing.git',
  semantic-release:config   tagFormat: '@whpal/liz-semrel-testing-utilities-v${version}',
  semantic-release:config   plugins:
  semantic-release:config    [ '@semantic-release/commit-analyzer',
  semantic-release:config      '@semantic-release/release-notes-generator',
  semantic-release:config      '@semantic-release/npm',
  semantic-release:config      '@semantic-release/github' ],
  semantic-release:config   analyzeCommits:
  semantic-release:config    [ [AsyncFunction: semantic-release-monorepo],
  semantic-release:config      [AsyncFunction: semantic-release-monorepo],
  semantic-release:config      [AsyncFunction: semantic-release-monorepo],
  semantic-release:config      [AsyncFunction: semantic-release-monorepo],
  semantic-release:config      [AsyncFunction: semantic-release-monorepo],
  semantic-release:config      [AsyncFunction: semantic-release-monorepo],
  semantic-release:config      [AsyncFunction: semantic-release-monorepo],
  semantic-release:config      [AsyncFunction: semantic-release-monorepo],
  semantic-release:config      [AsyncFunction: semantic-release-monorepo],
  semantic-release:config      [AsyncFunction: semantic-release-monorepo] ],
  semantic-release:config   generateNotes:
  semantic-release:config    { preset: 'angular',
  semantic-release:config      writerOpts: { transform: [Function: transform] } },
  semantic-release:config   githubUrl: 'https://github.ibm.com',
  semantic-release:config   githubApiPathPrefix: 'api/v3',
  semantic-release:config   releaseRules:
  semantic-release:config    [ { breaking: true, release: 'major' },
  semantic-release:config      { revert: true, release: 'patch' },
  semantic-release:config      { type: 'feat', release: 'minor' },
  semantic-release:config      { type: 'fix', release: 32m'patch' },
  semantic-release:config      { type: 'perf', release: 'patch' },
  semantic-release:config      { type: 'docs', release: 'patch' },
  semantic-release:config      { type: 'style', release: 'patch' },
  semantic-release:config      { type: 'test', release: 'patch' },
  semantic-release:config      { type: 'build', release: 'patch' },
  semantic-release:config      { type: 'ci', release: 'patch' },
  semantic-release:config      { type: 'refactor', release: 'patch' },
  semantic-release:config      { scope: 'minor-*', release: 'minor' },
  semantic-release:config      { scope: 'patch-*', release: 'patch' },
  semantic-release:config      { scope: 'no-release', release: false } ],
  semantic-release:config   releaseNotes:
  semantic-release:config    { issueResolution:
  semantic-release:config       { template: '{baseUrl}/{owner}/{repo}/issues/{ref}',
  semantic-release:config         baseUrl: 'https://github.ibm.com',
  semantic-release:config         source: 'github.ibm.com' } },
  semantic-release:config   tagFormatPrefix: '@whpal/liz-semrel-testing-',
  semantic-release:config   _: [],
  semantic-release:config   debug: true,
  semantic-release:config   '$0': 'node_modules/.bin/semantic-release' }

The config is in a release.config.js file and in the root of our package.json we include:
"release": {
    "extends": [
      "semantic-release-monorepo",
      "./release.config"
    ]
  }

Using a JavaScript file allows us to break up the config in to multiple objects and share them across the multiple packages in the monorepo.

Here's the output of the debug from the packages that had changes in this particular push
[semantic-release] › ℹ  Start step "analyzeCommits" of plugin "[Function: semantic-release-monorepo]"
  semantic-release:monorepo Running 'analyzeCommits' version '7.0.2' +0ms
  semantic-release:monorepo Filter commits by package path: "packages/thing2" +0ms
  semantic-release:monorepo Including commit "build: trying to debug" because it modified package file "packages/thing2/README.md". +117ms
  semantic-release:monorepo Including commit "build: update semantic release monorepo version" because it modified package file "packages/thing2/package-lock.json". +0ms
[semantic-release] [[Function: semantic-release-monorepo]] › ℹ  Found 2 commits for package @whpal/liz-semrel-testing-thing2 since last release
[semantic-release] [[Function: semantic-release-monorepo]] › ℹ  Analyzing commit: build: trying to debug
  semantic-release:commit-analyzer Analyzing with default rules +0ms
[semantic-release] [[Function: semantic-release-monorepo]] › ℹ  The commit should not trigger a release
[semantic-release] [[Function: semantic-release-monorepo]] › ℹ  Analyzing commit: build: update semantic release monorepo version
  semantic-release:commit-analyzer Analyzing with default rules +1ms
[semantic-release] [[Function: semantic-release-monorepo]] › ℹ  The commit should not trigger a release
[semantic-release] [[Function: semantic-release-monorepo]] › ℹ  Analysis of 2 commits complete: no release
[semantic-release] › ✔  Completed step "analyzeCommits" of plugin "[Function: semantic-release-monorepo]"
[semantic-release] › ℹ  Start step "analyzeCommits" of plugin "[Function: semantic-release-monorepo]"
[semantic-release] › ✔  Completed step "analyzeCommits" of plugin "[Function: semantic-release-monorepo]"
[semantic-release] › ℹ  Start step "analyzeCommits" of plugin "[Function: semantic-release-monorepo]"
[semantic-release] 90m› ✔  Completed step "analyzeCommits" of plugin "[Function: semantic-release-monorepo]"
[semantic-release] › ℹ  Start step "analyzeCommits" of plugin "[Function: semantic-release-monorepo]"
[semantic-release] › ✔  Completed step "analyzeCommits" of plugin "[Function: semantic-release-monorepo]"
[semantic-release] › ℹ  Start step "analyzeCommits" of plugin "[Function: semantic-release-monorepo]"
[semantic-release] › ✔  Completed step "analyzeCommits" of plugin "[Function: semantic-release-monorepo]"
[semantic-release] › ℹ  Start step "analyzeCommits" of plugin "[Function: semantic-release-monorepo]"
[semantic-release] › ✔  Completed step "analyzeCommits" of plugin "[Function: semantic-release-monorepo]"
[semantic-release] › ℹ  Start step "analyzeCommits" of plugin "[Function: semantic-release-monorepo]"
[semantic-release] › ✔  Completed step "analyzeCommits" of plugin "[Function: semantic-release-monorepo]"
[semantic-release] › ℹ  Start step "analyzeCommits" of plugin "[Function: semantic-release-monorepo]"
[semantic-release] › ✔ 39m Completed step "analyzeCommits" of plugin "[Function: semantic-release-monorepo]"
[semantic-release] › ℹ  Start step "analyzeCommits" of plugin "[Function: semantic-release-monorepo]"
[semantic-release] › ✔  Completed step "analyzeCommits" of plugin "[Function: semantic-release-monorepo]"
[semantic-release] › ℹ  Start step "analyzeCommits" of plugin "[Function: semantic-release-monorepo]"
[semantic-release] › ✔  Completed step "analyzeCommits" of plugin "[Function: semantic-release-monorepo]"
[semantic-release] › ℹ  There are no relevant changes, so no new version is released.

and
[semantic-release] › ℹ  Start step "analyzeCommits" of plugin "[Function: semantic-release-monorepo]"
  semantic-release:monorepo Running 'analyzeCommits' version '7.0.2' +0ms
  semantic-release:monorepo Filter commits by package path: "packages/utilities" +0ms
  semantic-release:monorepo Including commit "build: trying to debug" because it modified package file "packages/utilities/release.config.js". +49ms
  semantic-release:monorepo Including commit "build: testing releaseRules" because it modified package file "packages/utilities/release.config.common.js". +0ms
  semantic-release:monorepo Including commit "bug: fix JS bug in generateNotes function" because it modified package file "packages/utilities/release.config.common.js". +0ms
  semantic-release:monorepo Including commit "build: revert changes for generateNotes" because it modified package file "packages/utilities/release.config.common.js". +0ms
  semantic-release:monorepo Including commit "build: update semantic release monorepo version" because it modified package file "packages/utilities/package-lock.json". +0ms
[semantic-release] [[Function: semantic-release-monorepo]] › ℹ  Found 5 commits for package @whpal/liz-semrel-testing-utilities since last release
[semantic-release] [[Function: semantic-release-monorepo]] › ℹ  Analyzing commit: build: trying to debug
  semantic-release:commit-analyzer Analyzing with default rules +0ms
[semantic-release] [[Function: semantic-release-monorepo]] › ℹ  The commit should not trigger a release
[semantic-release] [[Function: semantic-release-monorepo]] › ℹ  Analyzing commit: build: testing releaseRules
  semantic-release:commit-analyzer Analyzing with default rules +1ms
[semantic-release] [[Function: semantic-release-monorepo]] › ℹ  The commit should not trigger a release
[semantic-release] [[Function: semantic-release-monorepo]] › ℹ  Analyzing commit: bug: fix JS bug in generateNotes function
  semantic-release:commit-analyzer Analyzing with default rules +1ms
[semantic-release] [[Function: semantic-release-monorepo]] › ℹ  The commit should not trigger a release
[semantic-release] [[Function: semantic-release-monorepo]] › ℹ  Analyzing commit: build: revert changes for generateNotes
  semantic-release:commit-analyzer Analyzing with default rules +0ms
[semantic-release] [[Function: semantic-release-monorepo]] › ℹ  The commit should not trigger a release
[semantic-release] [[Function: semantic-release-monorepo]] › ℹ  Analyzing commit: build: update semantic release monorepo version
  semantic-release:commit-analyzer Analyzing with default rules +0ms
[semantic-release] [[Function: semantic-release-monorepo]] › ℹ  The commit should not trigger a release
[semantic-release] [[Function: semantic-release-monorepo]] › ℹ  Analysis of 5 commits complete: no release
[semantic-release] › ✔  Completed step "analyzeCommits" of plugin "[Function: semantic-release-monorepo]"
[semantic-release] › ℹ  Start step "analyzeCommits" of plugin "[Function: semantic-release-monorepo]"
[semantic-release] › ✔  Completed step "analyzeCommits" of plugin "[Function: semantic-release-monorepo]"
[semantic-release] › ℹ  Start step "analyzeCommits" of plugin "[Function: semantic-release-monorepo]"
[semantic-release] › ✔  Completed step "analyzeCommits" of plugin "[Function: semantic-release-monorepo]"
[semantic-release] › ℹ  Start step "analyzeCommits" of plugin "[Function: semantic-release-monorepo]"
[semantic-release] › ✔  Completed step "analyzeCommits" of plugin "[Function: semantic-release-monorepo]"
[semantic-release] › ℹ  Start step "analyzeCommits" of plugin "[Function: semantic-release-monorepo]"
[semantic-release] › ✔  Completed step "analyzeCommits" of plugin "[Function: semantic-release-monorepo]"
[semantic-release] › ℹ  Start step "analyzeCommits" of plugin "[Function: semantic-release-monorepo]"
[semantic-release] › ✔  Completed step "analyzeCommits" of plugin "[Function: semantic-release-monorepo]"
[semantic-release] › ℹ  Start step "analyzeCommits" of plugin "[Function: semantic-release-monorepo]"
[semantic-release] › 32m✔  Completed step "analyzeCommits" of plugin "[Function: semantic-release-monorepo]"
[semantic-release] › ℹ  Start step "analyzeCommits" of plugin "[Function: semantic-release-monorepo]"
[semantic-release] › ✔  Completed step "analyzeCommits" of plugin "[Function: semantic-release-monorepo]"
[semantic-release] › ℹ  Start step "analyzeCommits" of plugin "[Function: semantic-release-monorepo]"
[semantic-release] › ✔  Completed step "analyzeCommits" of plugin "[Function: semantic-release-monorepo]"
[semantic-release] › ℹ  Start step "analyzeCommits" of plugin "[Function: semantic-release-monorepo]"
[semantic-release] › ✔  Completed step "analyzeCommits" of plugin "[Function: semantic-release-monorepo]"
[semantic-release] › ℹ  There are no relevant changes, so no new version is released.

Let me know if you need anything else and thank you for looking in to this.

That release config is using the old format semantic-release format. As of version 15.10, most of the configuration has been moved into the plugins. None of githubUrl, githubApiPathPrefix, releaseRules , releaseNotes, generateNotes are valid top-level configuration keys anymore - I think that's why the release rules aren't being applied anymore.
See the current top-level config options here: https://github.com/semantic-release/semantic-release/blob/master/docs/usage/configuration.md#configuration
(I'd recommend running the latest version of this plugin with the latest version of semantic-release.)
Here's roughly what I think your config should look like. Please reference the individual plugin READMEs via semantic-release for their respective configuration options:
https://github.com/semantic-release/commit-analyzer
https://github.com/semantic-release/github
https://github.com/semantic-release/release-notes-generator
module.exports = {
  branches: ...,
  plugins: [
    ['@semantic-release/commit-analyzer', {
      "releaseRules": [
       { breaking: true, release: 'major' },
       { revert: true, release: 'patch' },
       { type: 'feat', release: 'minor' },
       ...
       ]
    }],
    ['@semantic-release/release-notes-generator', {
      preset: 'angular',
      writerOpts: {
        transform: (commit, context) => {...},
      }
    }],
    '@semantic-release/npm',
    ['@semantic-release/github', {
      githubUrl: 'https://github.ibm.com',
      githubApiPathPrefix: 'api/v3',
    }]
  ],
}

That did the trick @pmowrer. Thank you so much for your help!

I have a similar issue with npm options
described here


--kubeconfig-flag does not work for "component apply" since 8fa88dae

Surprisingly, it works for "component delete"...

Should we add this in 0.5.0?

Should we add this in 0.5.0?

@iaguis ?

#1018 will fix it, perhaps it could be isolated from this PR, but it is easier to fix this way.

Should we add this in 0.5.0?

Yes.


feat: add new chains [APE-941]

What I did
Added base and polygon zkevm

fixes: #
How I did it
How to verify it
Checklist

[ ] Passes all linting checks (pre-commit and CI jobs)
[ ] New test cases have been added and are passing
[ ] Documentation has been updated
[ ] PR title follows Conventional Commit standard (will be automatically included in the changelog)

thanks!
if this works for you, then we are good, consider adding tests and docs. See past PRs that add networks like this.

I didnt try it as i am waiting to merge my new plugins first. I guess without them i cant use these properly.

I didnt try it as i am waiting to merge my new plugins first. I guess without them i cant use these properly.

OK let us know how it goes.

I didnt try it as i am waiting to merge my new plugins first. I guess without them i cant use these properly.

OK let us know how it goes.

Tried verifications on both polygon zkevm and base goerli using packages locally and they are working fine.

@antazoey can we merge this one as we already transferred ape-base and ape-polygon-zkevm to apeworx organisation? this PR as long as i tried works

@antazoey can we merge this one as we already transferred ape-base and ape-polygon-zkevm to apeworx organisation? this PR as long as i tried works

Yes, I can do all this right now

moving to https://github.com/ApeWorX/ape-etherscan/pull/91 because your org prevents us from collaborating.


Why the results aren't the same as in the web?

I've decided to give hackernews-TUI a chance today but right after running it I've seen it shows different stories than they are on the web. Why? Do I use it somehow wrong?

For tabs other than front page, it can either show the stories sorted by date or by points because HN Algolia API is used for that. front page stories are fetched using HN official API.
This can be resolved by using a mix of both APIs.

Hi @ftpd. I've updated the app in #80 to show shown_hn and ask_hn stories in the same order as in the web. Can you try to the latest build to confirm that it works?

Sorry, I was on holidays.
I still see some differences.

Sorry, I was on holidays.

No worries.

I still see some differences.

Do u have any pictures of such differences? Mine is similar

This is how it looks for me:

And frontpage looks fine:

Looks like you're using the old build of hackernews_tui (as the ask-hn stories are still sorted by date). Can u try it with the latest build from main:
git clone https://github.com/aome510/hackernews-TUI.git && cd hackernews-TUI
cargo run

Oh, I've just assumed there is a new release ;-) I will build it, but no sooner than today's evening (CEST). I will let you know, sorry for the inconvenience.

Aaaaaaaand I forgot.
Now I've build from today's master - it works fine. Thanks, I will wait for the new release.

Aaaaaaaand I forgot.
Now I've build from today's master - it works fine. Thanks, I will wait for the new release.

Great. Thanks for the confirmation. I'll release a new version soon


detach thread before erasing it from the FreeThreadPool

I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=ru
Category (leave one):

Bug Fix

Short description (up to few sentences):
Otherwise std::thread will call std::terminate() from the dtor:
Detailed description (optional):
  ...
  #4  0x000000000ac829c1 in std::terminate() ()
  #5  0x0000000006f1c87f in std::thread::~thread (this=<optimized out>, __in_chrg=<optimized out>) at /usr/include/c++/7/thread:135
  ...
  #10 ThreadPoolImpl<std::thread>::worker (this=0xf370680 <ext::singleton<GlobalThreadPool>::instance()::instance>, thread_it=...) at ../dbms/src/Common/ThreadPool.cpp:191

Refs: f6b9b063071662f1c391ee95ff16a30c89069010 ("Attempt to implemnt global thread pool #4018")

The idea is correct but a fix is a little more complicated. Look at #4505.


Fix CFFI API mode binary RPATH.

This patch fixes CFFI API mode when there is another R on the system path (that without this patch takes precedence). It works by inserting into the binary rpath the location of the R libraries. I have tested this only on Linux.
Note: There are some MacOS specific overrides that are not being used here. Is there a reason for this?
Checklist

[x] Used a personal fork of the feedstock to propose changes
[x] Bumped the build number (if the version is unchanged)
[ ] Reset the build number to 0 (if the version changed)
[ ] Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[ ] Ensured the license file is being packaged.

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@conda-forge-admin, please rerender

@conda-forge-admin, please rerender

@dbast (others?) Mind if I add myself as a maintainer here?


pass the title config prop through to favicons-webpack-plugin

Thank you for your PR but I made a commit adding title and background so it's already fixed.


Revisit functional bootstrap to avoid definition property.

@sobychacko I am going to close it as I can not reproduce it and in fact there are plenty of test cases showing that it works. Feel free to reopen it if you have a reproducible sample


Always set the OUT_DIR environment variable

Describe the problem you are trying to solve
I want to create a procedural attribute macro that analyzes a function signature and exports this information into a file. This file will be used later by another program, so it's definitely needed. However, the environment variable OUT_DIR isn't always set, which would tell me a good spot to write the file to. If the crate that uses the macro has a build script, OUT_DIR is set, but if it doesn't have a build script, OUT_DIR isn't set. Therefore, I would need to tell my users to always have a build script so that the macro works. This does not work well when there are many users of that macro.
Describe the solution you'd like
My requested solution is simple: Always set the OUT_DIR environment variable to a valid output directory, if the built crate has a build script or not.
Notes
One point against this is that OUT_DIR might collide with other uses of the variable, or that the name OUT_DIR isn't a good name for that in general. However, this would be a whole other discussion since it is already set for and used by build scripts.

I think there may be a misunderstanding about how proc-macros work and how they are intended to work and how build scripts work.  Generally, proc-macros should not persist any data to disk, and should be idempotent transformations on the input, without side-effects.  OUT_DIR is specifically intended for the build script of the package being built, which for the case of a proc-macro is the macro itself, not the packages that are using the proc-macro.
It is not clear from the description why you are using proc-macros to interface with other tooling, but I recommend considering other approaches to what you are trying to accomplish. If you want help discussing different ideas, I would suggest one of the user forums.

IMO OUT_DIR should be available in every place possible. I am using proc-macros to generate language bindings and it would be helpful.

If this isn't to be changed, it'd be helpful to document this behaviour, that OUT_DIR is only set if there's a build script. We had an issue where we accidentally removed our build script (that generated Rust source files), but our include code panicked saying OUT_DIR was not set. It took me a while to realise this was the source of the issue
I could open a PR on the Cargo Book to make this change if that's alright

Thanks for your advice! It seems to be documented already.
https://github.com/rust-lang/cargo/blob/84941490fd7304317282a89309c1fe2123200a8b/src/doc/src/reference/environment-variables.md?plain=1#L230-L232


choosing DSARR as the default skin before DnD of archetypes gives empty space

I set the skin to DSARR before dragging any archetypes into the pane and it appeared as though nothing happened.  When I toggled back to default/DSARR again, it came back fine.

This appears to be happening because some prototypes do not have appropriate niches until the a skin is selected after the prototype is placed. For example it is fine to switch to DSARR and then DnD a reactor, but not a separations facility.

Does a niche get added then when the original skin is used to DnD? Could
that be done before DnDing?
On Mon, Jun 1, 2015 at 1:14 PM, FlanFlanagan<EMAIL_ADDRESS>wrote:

This appears to be happening because some prototypes do not have
appropriate niches until the a skin is selected after the prototype is
placed. For example it is fine to switch to DSARR and then DnD a reactor,
but not a separations facility.
—
Reply to this email directly or view it on GitHub
https://github.com/cyclus/cyclist2/issues/58#issuecomment-107659296.

--
Matthew Gidden, Ph.D.
Postdoctoral Associate, Nuclear Engineering
The University of Wisconsin -- Madison
Ph.<PHONE_NUMBER>

I can be done before. I never ran into this problem (since some of them work I never noticed the issue). What is missing is if the facility doesn't have a niche that matches a niche in the skin set it needs to take the generic "facility" niche.

It*

Ok, if you point me to a line, I can fix it immediately. Otherwise it might
take me a while..
On Mon, Jun 1, 2015 at 3:29 PM, FlanFlanagan<EMAIL_ADDRESS>wrote:

It*
—
Reply to this email directly or view it on GitHub
https://github.com/cyclus/cyclist2/issues/58#issuecomment-107697224.

--
Matthew Gidden, Ph.D.
Postdoctoral Associate, Nuclear Engineering
The University of Wisconsin -- Madison
Ph.<PHONE_NUMBER>

line 284 of CycIC.java
facility.cycicCircle.image.setImage(DataArrays.visualizationSkins.get(i).images.get(facility.niche));
Basically what needs to happen is a check to see if the niche exists in the images key set. Which can be accessed most easily with
images.keySet().toArray();
If it passes then take that value otherwise take the map key "facility"

Fixed in #59 or sooner


Add @Transactional annotation to BaseJpaRepository methods

Since org.springframework.data.jpa.repository.support.SimpleJpaRepository is marked as
@Transactional( readOnly = true ) every persist, merge, update, delete action will be automatically marked as read only as well.
Caused by: java.sql.SQLException: Connection is read-only. Queries leading to data modification are not allowed
Unless the outer method is annotated with @Transactional.
This PR solves that problem when there is no transactional annotation present in the first place.

That's true. Thanks for the PR.

Applied upstream, thanks


Stat labels repeating themselves

The brew looks fine in the preview, but when I try to export in pdf form the stat labels cascade and multiply.
Additional Details
Share Link : http://oi63.tinypic.com/2n6c1us.jpg
or
Brew code to reproduce : Click to expand

The Arisen Goddess of the Astral Plane
Marda Wetherspond (Nana Withers)
"It's true, I am withering. Just like any beautiful flower does."

Born in a tiny shire built into the hilly plains of the Kuuderian Empire Marda lived a typical Halfling life. She had her share of adventures, travelling the world as one fourth of an adventuring party set on claiming fame and glory, but that life swiftly overtook her when she met her husband, and the two of them settled down in Ani.
Her husband, Osver Wetherspond, made a decent living as an atilliator, making crossbows exclusively for the royal army. Marda became the local midwife and while payment for her services were rare due to her indiscriminate kindness there was always a steady flow of free food and gifts from grateful families who couldn't afford an alternative. As loathe as she was to part with such mementos there were times when pawning them off was neccessary to survive.
Marda  remembers every child she has ever brought into the world and considers them and their families to be her extended kin, as a result her home has become somewhat of a haven for those under that umbrella with people of all ages coming and going at all hours of the day, each and every one of them pressing a grateful kiss to the cheek of the one they lovingly nicknamed "Nana Withers."
Over time her desire to watch over her children and keep them safe manifested in powers fit for the new goddess of the astral plane. Quite often family members would find Nana Withers asleep, not knowing that she was wide awake in the astral realm checking in on somebody. The ability to see through the astral realm to far-away places allowed her to keep an eye on distant children and her ability to allow others to pass from one realm to another let her hide her children away from those that would do them harm.

Playing Nana Withers
Contrary to her appearance and demeanor Nana Withers is a sprightly thing, her godhood giving her a newfound prowess. She doesn't desire to flaunt this though, being the wise woman suits her fine and she'll only exert herself in emergencies. When she does however she uses her talents to their fullest, which is a testament to her tenacity.
When she's not putting belligerents in their place she does her best to act as a mentor for those who cross her path, this isn't always obvious to those subjected to her child-like curiosity and impish sense of humor.
To those she doesn't know she is a kind lady who's interested in the tales of life, this is only partly a ruse designed to gauge the intent of visitors. To those whom she trusts she is the glue that holds everything together and will do everything in her power to extend to those in need a safe haven from the chaos of the world.

Nana Withers
Small humanoid (halfling), Lawful Good

Armor Class 12
Hit Points 55(22d6)
Speed 25ft.

STR
DEX
CON
INT
WIS
CHA

12 (+1)
14 (+2)
9 (-1)
16 (+3)
16 (+3)
15 (+2)

Condition Immunities None
Senses passive Perception 13
Languages Halfling, Common, Thieves Cant
Challenge 1/2 (100 XP)
Divinity Score 15 (+2)

Actions
Multi-Attack Nana Withers can attack twice, once with each weapon, every other turn.

Spear Thrust. Melee Weapon Attack: +5 to hit, reach 5ft., one target. Hit 5 (1d6/1d8+1)
Hand Crossbow Bolt Ranged Weapon Attack: +6, range 30/120, one target. Hit 4 (1d6+2)

Lair Actions

When inside her home Nana Withers can take the following actions on Initiative Count 20:

Astral Banishment Nana Withers can pull up to five targets of her choosing into the Astral Realm and expell them in any location up to 500ft of her current position.

Astral Evacuation Nana Withers can plunge her household and everyone in it, into the Astral Realm, leaving behind an empty building, it then replaces the inside of her home in Shrapnel Cliffs.

Duplicate of #318


Add eslint-config-adjunct

I just put this together to enable me to share the same collection of smaller esLint plugins across a range of projects and thought it might be more widely useful.

Thank you! I think I'm cool with this for now, but I think long-term we should probably put in "requirements" for when to accept a new eslint-config. I'm not going to worry about that for now, but if this becomes unruly in the future with having a bunch of folks add their own config then something to consider.


Support for Spring JPA

Not sure if it's possible, but I'm using mongo JPA to query in my mongo DB.
One of my method is called findByMail and do a search on the user mail address, which I ciphered using your lib.
But of course Mongo JPA doesn't get caught by the interceptor and thus it doesn't work because the searched mail isn't the ciphered version.
I'm not sure if it's something that would doable ?
But is it possible at all with your jar to query on the ciphered fields at all ?

Sorry meant Spring-data-mongodb
I added the @Field @Encrypt on a private String name field.
I'd a spring-data-mongodb interface with the name findByName(String name) and using the real name it did not work (As I guess it was matching it to the ciphered name)