Suggest using go to install the acr cli

Suggest using go to install the acr cli:
go install github.com/Azure/acr-cli/cmd/acr@latest
I think this is the most straightforward way to gain access to this CLI.

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 40e52f8e-a63e-3e85-6c84-f881db5d3b6c
Version Independent ID: 1290c892-ea9d-d12c-be84-7ed75f28fca0
Content: Purge tags and manifests - Azure Container Registry
Content Source: articles/container-registry/container-registry-auto-purge.md
Service: container-registry
GitHub Login: @tejaswikolli-web
Microsoft Alias: tejaswikolli

@carlin-q-scott
Thanks for your feedback! We will investigate and update as appropriate.

Hi @carlin-q-scott
Thanks for your contribution. Please add your ideas in below link, so our production team can review it and update the same.
Ideas · Community (azure.com)

I'm a bit confused why I had to do that, but here's a link to my post there: https://feedback.azure.com/d365community/idea/68af6ed0-c3a0-ed11-a81b-6045bd8615b0
The docs themselves sent me here to create a GitHub issue.


Update logback-classic to 1.2.8

Updates ch.qos.logback:logback-classic from 1.2.7 to 1.2.8.
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Files still referring to the old version number
The following files still refer to the old version number (1.2.7).
You might want to review and update them manually.
ember-server/js/yarn.lock
website/src/hugo/content/changelog.md

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "ch.qos.logback", artifactId = "logback-classic" } ]

labels: library-update, early-semver-patch, semver-spec-patch, old-version-remains, commit-count:1

This is an interesting upgrade.  1.2.8 is in Maven Central but does not appear to be tagged (as of 2021-12-14 at 15:12 UTC).
Looks like it's in response to a possible security issue:
http://mailman.qos.ch/pipermail/announce/2021/000164.html

Superseded by #5738

@bfritz Thanks for the legwork on that.  It wasn't clear to me what this one was about when I first saw it this morning.

Superseded by #5750.


build: update checksum for io_bazel_rules_sass

I do not know. I'm getting a crash about checksum mismatch on both my mac machine and linux machine.
Error in download_and_extract: java.io.IOException: Error downloading [https://github.com/bazelbuild/rules_sass/archive/1.49.4.zip] to /usr/local/google/home/zachzach/.cache/bazel/_bazel_zachzach/b2d336703fb3d3f93dae8817b6fd6b36/external/io_bazel_rules_sass/temp8489840885666228383/1.49.4.zip: Checksum was bfb89ca97a4ad452ca5f623dfde23d2a5f3a848a97478d715881b69b4767d3bb but wanted 68b58c69cda77c4f765be92cf076400d882ea2f10d66eaf369ed69409afab5be
ERROR: no such package '@io_bazel_rules_sass//': java.io.IOException: Error downloading [https://github.com/bazelbuild/rules_sass/archive/1.49.4.zip] to /usr/local/google/home/zachzach/.cache/bazel/_bazel_zachzach/b2d336703fb3d3f93dae8817b6fd6b36/external/io_bazel_rules_sass/temp8489840885666228383/1.49.4.zip: Checksum was bfb89ca97a4ad452ca5f623dfde23d2a5f3a848a97478d715881b69b4767d3bb but wanted 68b58c69cda77c4f765be92cf076400d882ea2f10d66eaf369ed69409afab5be

#24331 looks related to this

What's also interesting is that the same error message happens to me as on CI on master https://app.circleci.com/pipelines/github/angular/components/34387/workflows/c677915b-5128-453b-8765-6604d26bbcc2/jobs/339673


New bug: Keeps interpreting footage at 0 or 0.5fps

So I'm testing 720p clips for the first time and I keep encountering a really strange bug where after a few seconds the framerate analysis drops to 0 or 0.5fps for the remainder of the clip. This is with forgiving pixel difference or strict. Not consistent when it happens either, just... nopes out.
You can see an example here https://www.youtube.com/watch?v=hIAKgP63gMw
This keeps happening, I can't get things to work properly now - I tried reinstalling.

It looks like there are black borders around the video frame, which it looks like trdrop counts as tearing. Does it have those borders in the original video file? You could try either removing the borders and running it again or have trdrop dismiss tearing if Apex Legends doesn't normally have tearing

Disabling tearing did not help, but cropping it did. Yes, it was in the original, but I re-exported as lossless. Weird. Thanks!


Model inside dynamically compiled ngIf not updating properly

I've got a specific case where my directive adds an ngIf attribute to an element and recompiles it. Prior to 1.5.0-beta1 it worked as desired, but after I recently updated angular to latest version, the {{ }} interpolation inside my directive stopped working. I think the lazy compilation of ngTransclude function introduced in beta1 may cause it.
See http://jsbin.com/cademegoze/1/edit?html,js,output for a repro - click the button and notice the value inside the second directive is not updating.
I can get around this by using ng-bind instead of {{ }} (as shown on the demo) but as I'm building a library I wouldn't like to restrict users from doing what usually works across angular applications.

Hi,
yeah this is 99% caused by lazy transclusion. However, in your example you are doing something that's considered bad practice: re-compiling the same element twice. This can be problematic if you don't know what other directives are on the element and what kind of behavior they add.
I've looked at some workarounds, but so far I've got nothing.
I wonder what's the use case for your wrapper?

Well, you're right, this can cause some problems. I'll think about rewriting it. I stumbled upon this problem when working on a read/edit-mode switcher in my grid: https://github.com/michaldudak/light-grid/blob/page-size-split/src/lightGrid/view.js#L63

The problem is that with lazy compilation, the second compilation receives the already compiled text node (1) instead of {{value}}, so no interpolation is detected and no watcher is added.
Here are two other options that achieve the same thing:

Extract the contents (html) of the node at compile time, and replace the compiled contents before recompilation. Note that this adds twice the interpolation watchers though. One for the first compilation and one for the second. (same as your original working example)

Make the directive terminal and the wrapper directive an attribute. This way, you can stop the interpolation from happening and when you recompile, the wrapper directive isn't included again.

I'm still not sure about the use case though. Especially with structural directives like ngIf, you should let the user make that choice where and when they add them.

I'm going to close this issue because we haven't got any feedback, and I because re-compilation is not a supported mechanism.


Notice where to get support

Would be really nice to have a notice - here (in Readme.md) and in you Webpage - where to get support for this Library.
Like each other good opensource Software, a community will build up around UI-Kitten. So they come together to ask, help and show their work... maybe on on Slack, Discord, or a Forum-Page.
I think it would massively increase the distribution of ui-kitten (btw. an awesome ui-kit), if you provide a general place, where people can get (Community)-Support for the UI.
I suggest to create an slack or Discord-Group, but I'm open for other solutions.. as long there will be one.

I've found now, that you have a notice at the bottom of the Documentation-Page:

Notice: there is no 'ui-kitten' tag at all used on stackoverflow. Only Tag is react-native-ui-kitten.
On the other hand, I still recommend to have something like a community-chat to point users on a single place to help instantly each other (like slack or discord)

Agree, I think a pinned issue called 'Ask for Support' would be good as well.

@xstable thanks for having such interest. Having community-open channels like discord, slack (whatever else) is not the thing we can do, since this requires a lot of time efforts to keep it alive :)
This is under our internal discussion sometimes, and I hope we will have it some day.

there is no 'ui-kitten' tag at all used on stackoverflow

Thanks for the notice. We'll update the tag 👍
@ivanubi

pinned issue called 'Ask for Support'

Haven't seen that in other repositories. I believe that this will become a huge mess the first day it is opened 😄

@artyorsh I don't think so... that it's takes much time from your side.
I see it in other Projects (own ones and open-source). You only need to generate a centralized place where the community come together.
You don't have to put all the time new content to this group, you only have to provide the structure (like some chat-channels). Automatically all the community-members will fill this sections with life.
The main Point is to generate a "official" Place where Community-Members can meet.
If only a ui-kitten-user starts such a channel, it might spreaded up over different Messanger-Types (some prefer slack, otherones Discord... and so on).
So all you have to do is following (would love if you could give it a try... I think it will boots usage of ui-kitten... because Support is one of the most important things for a Software!):

Create A Slack or Discord Channel (for free)
Notice at the Documentation-Page that this is official Community-Support-Chat.
Let it fill with life fully automated by the community

If you don't have interest or time to moderate such a group, choose a well known contributor who like to be a moderator of such a group. But again. it is nearly no work to setup or moderate such a group.
BTW: I like slack, because it has nice integrations with other Services. For example you can create a News-Channel and automatically connect it to your git-repo to anounce if new Push appears to the Master-Repo.
If you wan't to start it, I can give you helping hands, if needed.

@xstable would like to have a quick discussion on this in twitter :)
Can we? Please contact me with the link in my bio if yes

I've seen it naturally happens here in the issues that people ask for questions, and some of us try to answer (including the maintainers) - this is usually what I've seen happening on most repos. I think it's a bit easier.
I like the idea of another place, but personally I've never actually used any of them. I usually forget... the cool thing about GitHub is that it's the same place I use for work, so it's easier to check from time to time. Perhaps Slack might be the same for me.

Hello @lesmo,
Sorry for such delay.
I would say that it's better to stick to the web. The reason is simple - any question could be googled.
For bugs / proposals - GitHub
For questions - SO
If there are already some Slack / Discord / etc group where people are discussing UI Kitten we can put a link on it in docs. But there are no plans to "officially" run the channel.

Hello @lesmo,
Sorry for such delay.
I would say that it's better to stick to the web. The reason is simple - any question could be googled.
For bugs / proposals - GitHub
For questions - SO
If there are already some Slack / Discord / etc group where people are discussing UI Kitten we can put a link on it in docs. But there are no plans to "officially" run the channel.

@malashkevich may I suggest Github Discussions?

@malashkevich may I suggest Github Discussions?

@lesmo I don't see any reason to not enable it :)
Thanks for suggestion!

@lesmo I don't see any reason to not enable it :)
Thanks for suggestion!


Design question: Do we need to generate type definitions if the project is in typescript?

TypeScript Version:  2.4.2

package.json
This is the sample given at the typescript website that explains how to to specify types/type declarations.

{
    "name": "awesome",
    "author": "Vandelay Industries",
    "version": "1.0.0",
    "main": "./lib/main.js",
    "types": "./lib/main.d.ts"
}

However, if the project is in typescript then do we need to have typings? Can I do something like the following:
{
    "name": "awesome",
    "author": "Vandelay Industries",
    "version": "1.0.0",
    "main": "./dist/node/lib/main.js", <<< Path to the generated javascript file
    "types": "./lib/main.ts" <<<< Path to the typescript file
}

What is  the  convention or recommended pattern for typescript projects?

(Context: I am creating an isomorphic javascript application that can work in node.js as well as the browser. I want the browser version to be light weight and by not including the type definitions significant size can be reduced. Hence wanted to understand the convention)

Isn't the size of definition file smaller than the TS file itself? And the definition file is just for TS users to check types, it won't affect runtime behavior. I'm not sure what's your concern here.

You need something to run, so you will always be shipping .js files. You might think about using tools like System.js that can compile on the fly, but if you are trying to run .ts files in the browser, that is not a good idea. Compiling on the fly will freeze up your browser from doing anything useful.
So if you're shipping .js files in your package, then you still need some way of consumers getting type validation. Why not ship .ts files? There are numerous reasons, but one is just the speed of the compilation process.
The size of your .ts files are typically significantly bigger. One of the benefits of .d.ts files is that your type information is already cached. If you used .ts files, the TypeScript source code would need to go through the same type-checking over and over again, and store the entire AST when parsing/checking in editor scenarios.

I want the browser version to be light weight and by not including the type definitions significant size can be reduced.

Nobody will include/should be including .d.ts files in the browser. The entire idea is that you'll be compiling against the .d.ts files, not bundling them. It's just type metadata, it doesn't get run by anything else.

I see. I am definitely not compiling on the fly. Thanks for pointing out the benefits of d.ts v/s the typescript files.

I am using webpack to bundle the browser code and then using uglify-es to minify. bundle.js is 2KB.

Link to the webpack config can be found here. May be I am missing something really important in the webpack config that can help reduce the bundled file size. Any guidance in solving this problem would be a huge help.

While executing webpack to bundle everything webpack warns about the sizes of the d.ts files. That made me think on the lines of not having d.ts files. However, thanks for clearing my doubt. I agree that type definition files will be much smaller than the actual typescript files.

This is the structure of the generated azure-batch sdk

dist contains browser and node specific code. ("main" in package.json points to dist/node/batchServiceClient.js as the entry point)
typings folder contains the type definitions.
lib folder contains the typescript code

source-map-explorer points out that the typescript files in the lib folder are consuming too much space.

I don't know exactly what you're trying to achieve, but I'll point out that mapper.ts is over 10K lines of data, so that's likely the culprit. If you want to avoid a long initial load, you could convert that into JSON or use a dynamic import() expression to get the module and split your bundle up.

Automatically closing this issue for housekeeping purposes. The issue labels indicate that it is unactionable at the moment or has already been addressed.


Rusttype font rendering backend

This MR adds a rusttype backend for font rendering and sets it as default instead of font-kit.
Resolves #44 and probably #46
Would be nice to get a feedback for that patch. Ping @nikp123 @sujay1844 @PopeRigby or anyone else who has the font issue.

Note, it's still a draft, text search rendering is broken when match_color is set, you may have some weird stuff like that:

It's ok, it will be fixed before the merge.

Just gave it a shot. It takes around 7 seconds to launch, and the UI doesn't respond and at all. I have to force kill it.

That's weird, did you try release build?

Render time increased by factor of 10 :\ (for me 3-4ms -> 20-50ms), gpu_cache feature only make things worse. Perhaps ab_glyph should be considered also, but its API is fairly cumbersome. For now I think an appropriate solution would be setting font-kit back as a default engine.

That's weird, did you try release build?

Yep. That works just fine.


something like the 'vim browse' or 'keyboard select' patch?

Or it's better to do something using externalpipe and vim.
I've done something like that in my fork of st: https://github.com/GasparVardanyan/st/blob/master/config.h#L202

I have vimbrowse in my st build, its great, removes any need for the mouse while using the terminal and can perform actions like yi[ and it will yank inside square brackets. I would recommend this patch 100%.

vim-browse doesn't support regex search ((
The biggest advantage of urxvt over st is that urxvt has a prel interpreter I think.

Now seems it works fine in my fork: https://github.com/GasparVardanyan/st/commit/418f06c79262530a534e068f620fd15984a1c0ba

Which version of vim-browse to apply in luke's ST fork?

vim-browse includes the scrollbach patch.
Try first to unpatch the applied version of the scrollback patch with patch -R, then apply the latest version of the vim-browse patch.

I try to add vim-browse to the actual luke build of st because it's just awesome ( i don't know why luke don't use it )
After apply the patch i have some problem and i don't know how to fix it.
If somebody have a fork of luke st with vim browse it would be awesome.

I'm warming to the idea of this patch and might add it soon.

vim browse is just awesome. I don't know why you don't add this before.

Now seems it works fine in my fork: GasparVardanyan/st@418f06c

That's better than vim-browse, because its more flexible.

See #287

Hey Luke, has the patch been applied? Looks like the issue has been closed.


Feature Request : Better support of msvc compiler

The variable NSIMD_CXX is misused in case of MSVC compiler
EG: NSIMD_CXX ==2014 for visual 2019
eg: we can't check value like NSIMD_CXX < 201103L
to switch on allocator flavor

Hi Thomas,
NSIMD_CXX is less precise than __cplusplus. It is used inside NSIMD as we do not want to write code with #ifdef's for each standardized/yet to be standardized (C++1x, C++1y, C++1z, ...) version of the C++ language. We only focused on standardized versions. Plus we do not want to remember the official value of __cplusplus for each standardized versions of C++ hence the NSIMD_CXX macro.
If you wish to have a more precise value use NSIMD__cplusplus whose definition takes into account MSVC's specificity and is as follows.
#ifdef NSIMD_IS_MSVC
  #define NSIMD__cplusplus _MSVC_LANG
#else
  #define NSIMD__cplusplus __cplusplus
#endif

Maybe the most recent version of MSVC does not report a good value in _MSVC_LANG in which case a fix concerning the definition of NSIMD__cplusplus will be done.

Hi
You right this kind of stuff is painfull
Sorry i not read carefully the first time
In fact
*NSIMD provide NSIMD_CXX define here https://github.com/agenium-scale/nsimd/blob/master/include/nsimd/nsimd.h#L94
*But check here https://github.com/agenium-scale/nsimd/blob/master/include/nsimd/nsimd.h#L676
like if its NSIMD__cplusplus define i think it should be should be #if NSIMD_CXX >= 2011
Thanks
Regards
TR


Attempt to improve the stake pool calculation:

Performance should improve due to reduction of number of iterations over
the total stake pool.

Yeah initial ledger creation is lightning quick compared to previous versions.


EXPERIMENT: Reproduce C++ ASAN UBSAN crashes with tmate enabled

Rationale for this change

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

@github-actions crossbow submit test-ubuntu-20.04-cpp-thread-sanitizer

@github-actions crossbow submit test-ubuntu-20.04-cpp-thread-sanitizer

Actual fix now submitted at https://github.com/apache/arrow/pull/40559


Is MFi license required inorder to be able to integrate and run in production with HomeSpan?

Yes, a MFi license is needed.  HomeSpan was developed using Apple's HAP-R2 specs, which Apple provided for home use and experimentation only.  Though I believe the commercial specifications are functionally the same, there is a slight, but critical,  difference in the pairing protocol between HAP-R2 and MFi.  Note that when you pair a HomeSpan device (or any device that is based on HAP-R2, such as Apple's HAP-R2 ADK, Espressif's non-commercial ADK, HomeBridge, etc.) the Home App on your iPhone will flag the device as uncertified and require you to grant it permission to proceed with pairing.  This warning message about the device being uncertified does not appear on commercial devices, presumably because Apply provides the licensee with a custom MFi authorization code that is recognized by the iPhone.


Should scale answers / checkbox answers also have a correct answer?

No, I don't think so - the experimenter should then just set up a multiple choice question (e.g., multiple choice options 1-10 for scale or multiple choice one option only for checkbox)


Update README.md

The README.md examples do not reflect the current state of the docs and suggest a different use of the work graph.

Indeed. The fact that AiiDA's mechanics are supported is a neat feature. But at the end of the day, the real gain from aiida-workgraph is that one doesn't need to know about AiiDA (e.g. no AiiDA imports necessary).


Update Warning and Todo hightlight group

before

after

There is no VSCode Dark+ reference for this highlight groups.
The color and style can be discussed. The current one is my preference. The alternative is to add color to background instead of foreground.

Looks perfect for me too. Merging


[FEAT] Add local native filesystem globbing.

This PR adds an ls implementation for the native local filesystem.

@clarkzinzow  Can we also add some python tests and ensure we have the same behavior as s3 and gcs?


Add test beta_mode

see #309 for details

I have opened a pr #323 for this can you have a look?

Thank  you. Don't need to directly notify me when doing a PR or opening and issue. I get emails notifications. Also when open a PR related to an issue you can use these magic words https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue


[SDK] Remove accidentally-internal "renaming shims" from AppKit.

These were supposed to help during the early days of Swift 3, when our omission of needless words was being tempered by framework authors' explicitly-specified names in API notes...but they were accidentally not made public, and no one noticed. After checking with the AppKit team, we decided to just drop them.

@swift-ci Please smoke test


Feature Request: display file name and line number on failed tests

Hello, thank you for creating this library. What do you think about adding the file name and line number of a failed test?
If you see the failed test file and line number so you can run the specific test locally right away with:
mix test test/some_test_file.exs:10
JUnit formatter in CircleCI
Without file name and line number:

With file name and line number:

Hey @josephan ! Thanks for your request!
We have recently added the stacktrace pretty printed. In your example, if you open "more" you should probably see the file with line numbers in the stack trace as if it is shown in ex_unit.
Does that help?

@victorolinasc ah you right, I didn't see that. Thanks for pointing that out 💯


In the report detail view, the "also found in", run name should be copiable

There is a new show report info button to view the report details where the run name can be copied.


in evidence grid, ensure that evidence with null rating is sorted as zero rating

Evidence rows w/ null rating now sorted properly, and displayed with the N/A symbol.


[type:feat] support snowflake.

[type:feat] support snowflake.

Codecov Report

Merging #103 (9d4fff6) into main (d890071) will decrease coverage by 1.64%.
The diff coverage is 91.07%.

@@            Coverage Diff             @@
##             main     #103      +/-   ##
==========================================
- Coverage   85.78%   84.13%   -1.65%
==========================================
  Files          28       29       +1
  Lines         978     1034      +56
==========================================
+ Hits          839      870      +31
- Misses        104      128      +24
- Partials       35       36       +1

Impacted Files
Coverage Δ

core/lang/snowflake.go
91.07% <91.07%> (ø)

log/async_writer.go
63.04% <0.00%> (-17.40%)
:arrow_down:

log/async_bufwriter.go
48.27% <0.00%> (-13.80%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d890071...9d4fff6. Read the comment docs.


Regression: nNRF52840 HW dies at 8 minutes 20 seconds in various samples using IPSP

Describe the bug
During automated testing of the LwM2M client in master branch, a regression was noted on both reel_board and nrf52840_pca10056.  The board dies after 8 minutes and 20 seconds.   Other samples which aren't public also displayed the same behavior.  One was an MQTT and HTTP application.  All samples tested use IPSP network connection via BLE.
Bisection led to this commit:
baea22407db46e99c22c7b04bf7413880cd111d3 kernel: Always set clock expiry with sync with timeout module
Prior to this commit, the samples runs normally.
To Reproduce
Steps to reproduce the behavior:

cd samples/net/lwm2m_client
mkdir build; cd build
cmake -DBOARD=reel_board -DOVERLAY_CONFIG=overlay-bt.conf ..
make
make flash
board should be connected via IPSP (timeout might happen during init due to using generic IPv6 addresses -- doesn't affect the outcome)
6a. NOTE: if user wants connection to actually work, they may need to alter the configuration of their IPSP gateway to use the 2001:db8:: subnet.
6b. Outcome is the same whether or not IPSP networking actually works
wait for 8 minutes and 20 seconds, board will stop responding

Expected behavior
Board / sample should run longer than 8 minutes 20 seconds.
Impact
Unacceptable board behavior
Screenshots or console output
uart:~$ ***** Booting Zephyr OS zephyr-v1.13.0-2173-gbaea22407d *****
[00:00:00.007,110] <dbg> net_lwm2m_engine.lwm2m_engine_init: LWM2M engine thread started
uart:~$ [00:00:00.007,110] <dbg> net_lwm2m_obj_security.security_create: Create LWM2M security instance: 0
uart:~$ [00:00:00.007,141] <dbg> net_lwm2m_obj_server.server_create: Create LWM2M server instance: 0
uart:~$ [00:00:00.007,171] <dbg> net_lwm2m_obj_device.device_create: Create LWM2M device instance: 0
uart:~$ [00:00:00.007,171] <dbg> net_lwm2m_obj_firmware.firmware_create: Create LWM2M firmware instance: 0
uart:~$ [00:00:00.369,354] <inf> net_config.net_config_init: Initializing network
uart:~$ [00:00:00.369,720] <wrn> net_if.net_if_send_data: iface 0x2000bbe0 is down
uart:~$ [00:00:00.369,750] <err> net_if.join_mcast_allnodes: Cannot join all nodes address ff02::1 (-5)
uart:~$ uart:~$ [00:00:17.074,615] <dbg> net_lwm2m_engine.lwm2m_engine_set: path:3/0/10, value:0x20009dec, len:4
uart:~$ [00:00:17.074,676] <dbg> net_lwm2m_engine.lwm2m_engine_set: path:3/0/20, value:0x20009def, len:1
uart:~$ [00:00:17.074,707] <dbg> net_lwm2m_engine.lwm2m_engine_set: path:3/0/21, value:0x20009dec, len:4
uart:~$ [00:00:17.074,737] <dbg> net_lwm2m_engine.lwm2m_engine_create_obj_inst: path:3303/0
uart:~$ [00:00:17.074,768] <dbg> net_ipso_temp_sensor.temp_sensor_create: Create IPSO Temperature Sensor instance: 0
uart:~$ [00:00:17.074,768] <dbg> net_lwm2m_engine.lwm2m_engine_set: path:3303/0/5700, value:0x20009e00, len:8
uart:~$ [00:00:17.074,798] <dbg> net_lwm2m_engine.lwm2m_engine_create_obj_inst: path:3311/0
uart:~$ [00:00:17.074,829] <dbg> net_ipso_light_control.light_control_create: Create IPSO Light Control instance: 0
uart:~$ uart:~$ [00:00:17.165,161] <inf> net_lwm2m_rd_client.lwm2m_rd_client_start: LWM2M Client: nrf52840_pca10056
uart:~$ [00:00:17.373,901] <inf> net_lwm2m_rd_client.sm_do_init: RD Client started with endpoint 'nrf52840_pca10056' and client lifetime 0
uart:~$ [00:00:17.883,758] <dbg> net_lwm2m_rd_client.sm_send_registration: registration sent [2001:db8::2]
uart:~$ uart:~$ [00:00:20.237,945] <dbg> net_lwm2m_engine.retransmit_request: Resending message: 0x20002b90
uart:~$ uart:~$ [00:00:24.928,192] <dbg> net_lwm2m_engine.retransmit_request: Resending message: 0x20002b90
uart:~$ uart:~$ [00:00:34.298,706] <dbg> net_lwm2m_engine.retransmit_request: Resending message: 0x20002b90
uart:~$ uart:~$ [00:00:53.029,754] <wrn> net_lwm2m_rd_client.do_registration_timeout_cb: Registration Timeout
uart:~$ [00:00:53.029,754] <dbg> net_lwm2m_client_app.rd_client_event: Disconnected
uart:~$ [00:00:53.029,754] <dbg> net_lwm2m_client_app.rd_client_event: Registration failure!
uart:~$ uart:~$ [00:00:53.508,758] <inf> net_lwm2m_rd_client.sm_do_init: RD Client started with endpoint 'nrf52840_pca10056' and client lifetime 30
uart:~$ [00:00:54.018,676] <dbg> net_lwm2m_rd_client.sm_send_registration: registration sent [2001:db8::2]
uart:~$ uart:~$ [00:00:56.372,802] <dbg> net_lwm2m_engine.retransmit_request: Resending message: 0x20002b90
uart:~$ uart:~$ [00:01:01.063,049] <dbg> net_lwm2m_engine.retransmit_request: Resending message: 0x20002b90
uart:~$ uart:~$ [00:01:10.433,563] <dbg> net_lwm2m_engine.retransmit_request: Resending message: 0x20002b90
uart:~$ uart:~$ [00:01:29.164,611] <wrn> net_lwm2m_rd_client.do_registration_timeout_cb: Registration Timeout
uart:~$ [00:01:29.164,611] <dbg> net_lwm2m_client_app.rd_client_event: Disconnected
uart:~$ [00:01:29.164,611] <dbg> net_lwm2m_client_app.rd_client_event: Registration failure!
uart:~$ uart:~$ [00:01:29.676,605] <inf> net_lwm2m_rd_client.sm_do_init: RD Client started with endpoint 'nrf52840_pca10056' and client lifetime 30
uart:~$ [00:01:30.183,380] <dbg> net_lwm2m_rd_client.sm_send_registration: registration sent [2001:db8::2]
uart:~$ uart:~$ [00:01:32.537,597] <dbg> net_lwm2m_engine.retransmit_request: Resending message: 0x20002b90
uart:~$ uart:~$ [00:01:37.227,844] <dbg> net_lwm2m_engine.retransmit_request: Resending message: 0x20002b90
uart:~$ uart:~$ [00:01:46.598,358] <dbg> net_lwm2m_engine.retransmit_request: Resending message: 0x20002b90
uart:~$ uart:~$ [00:02:05.329,406] <wrn> net_lwm2m_rd_client.do_registration_timeout_cb: Registration Timeout
uart:~$ [00:02:05.329,406] <dbg> net_lwm2m_client_app.rd_client_event: Disconnected
uart:~$ [00:02:05.329,406] <dbg> net_lwm2m_client_app.rd_client_event: Registration failure!
uart:~$ [00:02:05.808,410] <inf> net_lwm2m_rd_client.sm_do_init: RD Client started with endpoint 'nrf52840_pca10056' and client lifetime 30
uart:~$ uart:~$ [00:02:06.318,267] <dbg> net_lwm2m_rd_client.sm_send_registration: registration sent [2001:db8::2]
uart:~$ uart:~$ [00:02:08.672,454] <dbg> net_lwm2m_engine.retransmit_request: Resending message: 0x20002b90
uart:~$ uart:~$ [00:02:13.362,701] <dbg> net_lwm2m_engine.retransmit_request: Resending message: 0x20002b90
uart:~$ uart:~$ [00:02:22.733,215] <dbg> net_lwm2m_engine.retransmit_request: Resending message: 0x20002b90
uart:~$ uart:~$ [00:02:41.464,263] <wrn> net_lwm2m_rd_client.do_registration_timeout_cb: Registration Timeout
uart:~$ [00:02:41.464,263] <dbg> net_lwm2m_client_app.rd_client_event: Disconnected
uart:~$ [00:02:41.464,263] <dbg> net_lwm2m_client_app.rd_client_event: Registration failure!
uart:~$ [00:02:41.943,267] <inf> net_lwm2m_rd_client.sm_do_init: RD Client started with endpoint 'nrf52840_pca10056' and client lifetime 30
uart:~$ uart:~$ [00:02:42.453,094] <dbg> net_lwm2m_rd_client.sm_send_registration: registration sent [2001:db8::2]
uart:~$ uart:~$ [00:02:44.807,312] <dbg> net_lwm2m_engine.retransmit_request: Resending message: 0x20002b90
uart:~$ uart:~$ [00:02:49.497,558] <dbg> net_lwm2m_engine.retransmit_request: Resending message: 0x20002b90
uart:~$ uart:~$ [00:02:58.868,072] <dbg> net_lwm2m_engine.retransmit_request: Resending message: 0x20002b90
uart:~$ uart:~$ [00:03:17.599,121] <wrn> net_lwm2m_rd_client.do_registration_timeout_cb: Registration Timeout
uart:~$ [00:03:17.599,121] <dbg> net_lwm2m_client_app.rd_client_event: Disconnected
uart:~$ [00:03:17.599,121] <dbg> net_lwm2m_client_app.rd_client_event: Registration failure!
uart:~$ [00:03:18.078,125] <inf> net_lwm2m_rd_client.sm_do_init: RD Client started with endpoint 'nrf52840_pca10056' and client lifetime 30
uart:~$ uart:~$ [00:03:18.587,982] <dbg> net_lwm2m_rd_client.sm_send_registration: registration sent [2001:db8::2]
uart:~$ uart:~$ [00:03:20.942,169] <dbg> net_lwm2m_engine.retransmit_request: Resending message: 0x20002b90
uart:~$ uart:~$ [00:03:25.632,415] <dbg> net_lwm2m_engine.retransmit_request: Resending message: 0x20002b90
uart:~$ uart:~$ [00:03:35.002,929] <dbg> net_lwm2m_engine.retransmit_request: Resending message: 0x20002b90
uart:~$ uart:~$ [00:03:53.733,978] <wrn> net_lwm2m_rd_client.do_registration_timeout_cb: Registration Timeout
uart:~$ [00:03:53.733,978] <dbg> net_lwm2m_client_app.rd_client_event: Disconnected
uart:~$ [00:03:53.733,978] <dbg> net_lwm2m_client_app.rd_client_event: Registration failure!
uart:~$ uart:~$ [00:03:54.212,982] <inf> net_lwm2m_rd_client.sm_do_init: RD Client started with endpoint 'nrf52840_pca10056' and client lifetime 30
uart:~$ [00:03:54.722,839] <dbg> net_lwm2m_rd_client.sm_send_registration: registration sent [2001:db8::2]
uart:~$ uart:~$ [00:03:57.077,026] <dbg> net_lwm2m_engine.retransmit_request: Resending message: 0x20002b90
uart:~$ uart:~$ [00:04:01.767,272] <dbg> net_lwm2m_engine.retransmit_request: Resending message: 0x20002b90
uart:~$ uart:~$ [00:04:11.137,786] <dbg> net_lwm2m_engine.retransmit_request: Resending message: 0x20002b90
uart:~$ uart:~$ [00:04:29.868,835] <wrn> net_lwm2m_rd_client.do_registration_timeout_cb: Registration Timeout
uart:~$ [00:04:29.868,835] <dbg> net_lwm2m_client_app.rd_client_event: Disconnected
uart:~$ [00:04:29.868,835] <dbg> net_lwm2m_client_app.rd_client_event: Registration failure!
uart:~$ uart:~$ [00:04:30.347,839] <inf> net_lwm2m_rd_client.sm_do_init: RD Client started with endpoint 'nrf52840_pca10056' and client lifetime 30
uart:~$ [00:04:30.857,666] <dbg> net_lwm2m_rd_client.sm_send_registration: registration sent [2001:db8::2]
uart:~$ uart:~$ [00:04:33.211,883] <dbg> net_lwm2m_engine.retransmit_request: Resending message: 0x20002b90
uart:~$ uart:~$ [00:04:37.902,130] <dbg> net_lwm2m_engine.retransmit_request: Resending message: 0x20002b90
uart:~$ uart:~$ [00:04:47.272,644] <dbg> net_lwm2m_engine.retransmit_request: Resending message: 0x20002b90
uart:~$ uart:~$ [00:05:06.003,692] <wrn> net_lwm2m_rd_client.do_registration_timeout_cb: Registration Timeout
uart:~$ [00:05:06.003,692] <dbg> net_lwm2m_client_app.rd_client_event: Disconnected
uart:~$ [00:05:06.003,692] <dbg> net_lwm2m_client_app.rd_client_event: Registration failure!
uart:~$ uart:~$ [00:05:06.482,696] <inf> net_lwm2m_rd_client.sm_do_init: RD Client started with endpoint 'nrf52840_pca10056' and client lifetime 30
uart:~$ [00:05:06.992,675] <dbg> net_lwm2m_rd_client.sm_send_registration: registration sent [2001:db8::2]
uart:~$ uart:~$ [00:05:09.346,740] <dbg> net_lwm2m_engine.retransmit_request: Resending message: 0x20002b90
uart:~$ uart:~$ [00:05:14.036,987] <dbg> net_lwm2m_engine.retransmit_request: Resending message: 0x20002b90
uart:~$ uart:~$ [00:05:23.407,501] <dbg> net_lwm2m_engine.retransmit_request: Resending message: 0x20002b90
uart:~$ uart:~$ [00:05:42.138,549] <wrn> net_lwm2m_rd_client.do_registration_timeout_cb: Registration Timeout
uart:~$ [00:05:42.138,549] <dbg> net_lwm2m_client_app.rd_client_event: Disconnected
uart:~$ [00:05:42.138,549] <dbg> net_lwm2m_client_app.rd_client_event: Registration failure!
uart:~$ [00:05:42.617,553] <inf> net_lwm2m_rd_client.sm_do_init: RD Client started with endpoint 'nrf52840_pca10056' and client lifetime 30
uart:~$ uart:~$ [00:05:43.127,441] <dbg> net_lwm2m_rd_client.sm_send_registration: registration sent [2001:db8::2]
uart:~$ uart:~$ [00:05:45.481,597] <dbg> net_lwm2m_engine.retransmit_request: Resending message: 0x20002b90
uart:~$ uart:~$ [00:05:50.171,844] <dbg> net_lwm2m_engine.retransmit_request: Resending message: 0x20002b90
uart:~$ uart:~$ [00:05:59.542,358] <dbg> net_lwm2m_engine.retransmit_request: Resending message: 0x20002b90
uart:~$ uart:~$ [00:06:18.273,406] <wrn> net_lwm2m_rd_client.do_registration_timeout_cb: Registration Timeout
uart:~$ [00:06:18.273,406] <dbg> net_lwm2m_client_app.rd_client_event: Disconnected
uart:~$ [00:06:18.273,406] <dbg> net_lwm2m_client_app.rd_client_event: Registration failure!
uart:~$ [00:06:18.762,390] <inf> net_lwm2m_rd_client.sm_do_init: RD Client started with endpoint 'nrf52840_pca10056' and client lifetime 30
uart:~$ uart:~$ [00:06:19.272,247] <dbg> net_lwm2m_rd_client.sm_send_registration: registration sent [2001:db8::2]
uart:~$ uart:~$ [00:06:21.626,434] <dbg> net_lwm2m_engine.retransmit_request: Resending message: 0x20002b90
uart:~$ uart:~$ [00:06:26.316,680] <dbg> net_lwm2m_engine.retransmit_request: Resending message: 0x20002b90
uart:~$ uart:~$ [00:06:35.687,194] <dbg> net_lwm2m_engine.retransmit_request: Resending message: 0x20002b90
uart:~$ uart:~$ [00:06:54.418,243] <wrn> net_lwm2m_rd_client.do_registration_timeout_cb: Registration Timeout
uart:~$ [00:06:54.418,243] <dbg> net_lwm2m_client_app.rd_client_event: Disconnected
uart:~$ [00:06:54.418,243] <dbg> net_lwm2m_client_app.rd_client_event: Registration failure!
uart:~$ [00:06:54.897,247] <inf> net_lwm2m_rd_client.sm_do_init: RD Client started with endpoint 'nrf52840_pca10056' and client lifetime 30
uart:~$ uart:~$ [00:06:55.407,104] <dbg> net_lwm2m_rd_client.sm_send_registration: registration sent [2001:db8::2]
uart:~$ uart:~$ [00:06:57.761,291] <dbg> net_lwm2m_engine.retransmit_request: Resending message: 0x20002b90
uart:~$ uart:~$ [00:07:02.451,538] <dbg> net_lwm2m_engine.retransmit_request: Resending message: 0x20002b90
uart:~$ uart:~$ [00:07:11.822,052] <dbg> net_lwm2m_engine.retransmit_request: Resending message: 0x20002b90
uart:~$ uart:~$ [00:07:30.553,100] <wrn> net_lwm2m_rd_client.do_registration_timeout_cb: Registration Timeout
uart:~$ [00:07:30.553,100] <dbg> net_lwm2m_client_app.rd_client_event: Disconnected
uart:~$ [00:07:30.553,100] <dbg> net_lwm2m_client_app.rd_client_event: Registration failure!
uart:~$ [00:07:31.032,104] <inf> net_lwm2m_rd_client.sm_do_init: RD Client started with endpoint 'nrf52840_pca10056' and client lifetime 30
uart:~$ uart:~$ [00:07:31.541,931] <dbg> net_lwm2m_rd_client.sm_send_registration: registration sent [2001:db8::2]
uart:~$ uart:~$ [00:07:33.896,148] <dbg> net_lwm2m_engine.retransmit_request: Resending message: 0x20002b90
uart:~$ uart:~$ [00:07:38.586,395] <dbg> net_lwm2m_engine.retransmit_request: Resending message: 0x20002b90
uart:~$ uart:~$ [00:07:47.956,909] <dbg> net_lwm2m_engine.retransmit_request: Resending message: 0x20002b90
uart:~$ uart:~$ [00:08:06.687,957] <wrn> net_lwm2m_rd_client.do_registration_timeout_cb: Registration Timeout
uart:~$ [00:08:06.687,957] <dbg> net_lwm2m_client_app.rd_client_event: Disconnected
uart:~$ [00:08:06.687,957] <dbg> net_lwm2m_client_app.rd_client_event: Registration failure!
uart:~$ uart:~$ [00:08:07.166,961] <inf> net_lwm2m_rd_client.sm_do_init: RD Client started with endpoint 'nrf52840_pca10056' and client lifetime 30
uart:~$ [00:08:07.676,788] <dbg> net_lwm2m_rd_client.sm_send_registration: registration sent [2001:db8::2]
uart:~$ uart:~$ [00:08:10.031,005] <dbg> net_lwm2m_engine.retransmit_request: Resending message: 0x20002b90
uart:~$ uart:~$ [00:08:14.721,252] <dbg> net_lwm2m_engine.retransmit_request: Resending message: 0x20002b90
uart:~$ uart:~$ [00:08:24.091,766] <dbg> net_lwm2m_engine.retransmit_request: Resending message: 0x20002b90
uart:~$ uart:~$

NOTE: Logging just stops here.  There is no OOPS.
Environment (please complete the following information):

OS: Linux
Distribution: Ubuntu 18.04
Toolchain: Zephyr SDK
Commit SHA: baea22407db46e99c22c7b04bf7413880cd111d3

Assigning to @pdunaj, @andyross and @andrewboie since this looks like a commit to the kernel code.

Updated w/ full log from nrf52840_pca10056 running lwm2m_client sample from master with no changes.

Huh... that patch fixed a real bug, so it can't just be reverted.  This is for sure a rollover condition.  This is a 16kHz clock, right?  So a signed rollover is going to happen at 2^23 bits, or just about exactly eight and a half minutes.  I'll take a look, though @pdunaj  is likely to see it first.
Note that I have another rework in progress of this area to prevent the "set timeout on idle" behavior entirely, which is essentially a parallel way to fix the original bug (with rapidly/repeatedly set timeouts bumping the next tick forward).   If we can't find the rollover here, we could presumably revert this one once the other fix is ready.  If, y'know, it doesn't itself introduce more bugs.

@andyross I think this is a 32KHz clock

I guess this bug is a duplicate of #11694.

Hah, even better as it can be an unsigned overflow.
Oh!  And I see you literally just pushed a patch.  Yeah, that looks like it exactly.

(Though AFAICT that bug predates @pdunaj 's patch mentioned above.  @mike-scott are you sure about that bisection?)

@andyross Absolutely.  I spent quite some time working through the commits.  And this bug reproduces perfectly every time.

I saw this with MQTT sample also. Logging completely stops, but if after it stops, you connect BLE and do IPSP stuff, the networking is still working, can ping to the device, and I am still getting stack init logs like prio recv thread stack (real size 448): unused 188      usage 260 / 448 (58 %).

@mike-scott , @andyross , bug that was fixed by the commit mentioned caused delayed work to be not executed. It could be that in the code there was something that was simply not running and now it is allowed to execute and behavior changes. If it is so it should be relatively simple to track down.


Adding a file with right click in explorer adds it to the MFS and pins it

OS: Windows
Version of IPFS Desktop 0.16.0

Describe the bug
Adding files via right click in the explorer is pretty cool, but instead of adding the file just to the MFS, it is also locally pinned. Why?
I mean, the only reason to pin an item in the MFS is when it's lazily added via CID and you want it to be downloaded completly.
To Reproduce
Steps to reproduce the behavior:

Add a file via right-click in explorer -> Add to ipfs
Open the IPFS GUI

Screenshots

This is a bug, we should not pin it, adding to MFS is enough.


Hint doesn't make sense with Import flow

What do you suggest @quintesse, to me it's obvious that you need to configure the source repository in order to import

Ah I see now that I read this wrong, probably because of the word "configure" I assumed it was talking about a destination repository. So perhaps just a slight rewording might do. Something like "You should select a repository to import from." perhaps?


DatabaseGeneratedOption.Computed always causes null

I have a column like the following:
    [Column, DatabaseGenerated(DatabaseGeneratedOption.Computed)]
    public DateTime? LastModified { get; set; }

and a SQL trigger that sets it as expected.  Entity framework expects the database to set this property and reads it back after each insert and update.  Effort always reports this as null.  That is:
    var entity = new MyEntity { LastModified = DateTime.Now };
    dbContext.MyEntities.Add(entity);
    dbContext.SaveChanges();
    Assert.NotNull(entity.LastModified);

fails where dbContext is a DbContext created from a transcient Effort DbConnection.
I would like some mechanism to get around this.  Perhaps an EntityWithComputedColumnInserting event and an EntityWithComputedColumnUpdating event for allowing users to handle the computing of computed columns.  Say using an EventArgs similar to the following:
    public class ComputedColumnEventArgs : EventArgs
    {
        public Type EntityType { get; }
        public string ComputedColumnName { get; }
        public object ComputedValue { get; set; }
    }

I could then make an event handler like the following in my test class:
    private void ComputeLastModified(object sender, ComputedColumnEventArgs e)
    {
        if (e.EntityType = typeof(MyEntity)
            && e.ComputedColumnName == nameof(MyEntity.LastModified))
        {
            e.ComputedValue = _now;
        }
    }

I'm facing the same situation at the moment. I'm going to download the source code and try to find if it's possible to implement the solution you are suggesting.

Thats the spirit!

Here you have it.
UnitTestProject1.zip

Great thank ;)

Hello @pfaustinopt ,
After some time passed on this issue, unfortunately, I don't think we can do anything for this moment.
There is currently no trigger logic implemented on Effort which make it hard to support Computed for DateTime value.
Best Regards,
Jonathan

Hello,
i'm facing the same issue.
If i try to update or create a new entitiy, which holds a column with the [DatabaseGenerated(DatabaseGeneratedOption.Computed)] attribute i get the error message, that the columns value can not be null.
It doesn't matter if i pass a value or not, the error message resists until i delete the attribute.
Maybe you can have a look at it?
Best regards

facing the same issue

Is there any solution to this problem? I do not need that the value of the computed column is correct, I just need that I can add values without crashing. Can we exclude the computed column?

Hello @drameryan ,
We will look at it. Adding an option to exclude those computed columns could be a perfect workaround.
Thank for your suggestion.
Best Regards,
Jonathan

Hello @drameryan ,
Do your computed column value is a key? We tried several column types but we are not able to reproduce the columns value can not be null error. Column are always saved with their default value, and doesn't make our application crash

Hi @JonathanMagnan ,
No, it's a DB First model, and the calculated column was simply Fullname, computed as Name + ' ' + Surname. So it doesn't have a default vale.
Default Value -> not defined
Entity Key -> false
Nullable -> false
StoreGeneratedPattern -> Computed
Type -> String

Hello @drameryan ,
It's possible for you to provide a project sample?
It will make easier for my developer to get started to fix this error. I highly believe something would be possible in this case.

Sure @JonathanMagnan,
I'm preparing it now...

I think I isolated the case. It's DB First model.
I created 3 test cases, first table with no computed column, Id, Name, Surname
Second case [TableWithComputedNullable]:  Id, Name NULL, Surname NULL, Fullname
Third case [TableWithComputedNonNullable]: Id, Name NOT NULL, Surname NOT NULL, Fullname
The first 2 cases works as expected.
In the second case, Name and Surname are nullable, therefore Fullname also not null. So a null value of the full name does not cause a crash.
But, in the third case, Fullname also automatically becomes NOT NULL, and the default Null value causes the crash NMemory.Exceptions.ConstraintException: Column 'Fullname' cannot be null. Error code: GenericError
Here is my project folder, you can find also the sql create table scripts inside.
https://startuappdev.blob.core.windows.net/web/ComputedColumn.zip

Thank a lot for the project @drameryan ,
Using your project, we easily find a quick fix.
We will re-investigate our fix tomorrow to try to improve it.
Unless something goes wrong, you can expect a new release next Monday.
Best Regards,
Jonathan

That's great! Thank you very much.
Regards

Hello @drameryan ,
The v2.1.0 has been released.
A default value (or empty string) will be inserted when you turn on the following options EntityFrameworkEffortManager.UseDefaultForNotNullable
We are currently investigating for a better fix but meanwhile this one work with the example you provided.
Best Regards,
Jonathan

@JonathanMagnan that's great, I checked and confirm that it works as expected! Thank you very much


[BUG] Critical memory leak when particles are active

Describe the bug
The memory of the process of the engine increases constantly.
To Reproduce
Steps to reproduce the behavior:

Open windows Task Manager and check LittleOrionEngine memory.
Open Level1.scene
Check that the memory of the process on the task manager will start to increase.
If you delete the GO Particles the memory stops to allocate

Expected behavior
No RAM BOOM
Screenshots
https://gyazo.com/f97b15d8efc8b2183c643ded1595d42c
https://gyazo.com/c7f880d7185ba06eda833d746f89c866
Additional context
Add any other context about the problem here.

fix https://github.com/OnionGalaxy/LittleOrionEngine/pull/196

Solved in #196


Do not understand update_parameters_policy function

Hello,
I am having a hard time understanding hwo the update_parameters_policy function achevies repalcing the forward model's jacobian by the backward model's jacobian. Could you explain and help me to understand it? thanks so much for your time!
https://github.com/CCreal/ddppo/blob/master/ddppo/agent_double_model.py#L267-334

The code was written two years ago, so allow me to recall a bit. I'll get back to you within a week.

Hello,
I am having a hard time understanding hwo the update_parameters_policy function achevies repalcing the forward model's jacobian by the backward model's jacobian. Could you explain and help me to understand it? thanks so much for your time!
https://github.com/CCreal/ddppo/blob/master/ddppo/agent_double_model.py#L267-334

The code was written two years ago, so allow me to recall a bit. I'll get back to you within a week.


Fix #11

Fix #11

@akeyder

Fix #11

@tolga-coplu @spilin
Could you review this code?

Hi @nujabes403, we decided to publish the config at the location expected in install script so this PR now obsolete, thanks for catching the problem!

@akeyder no problem :)


Code39 Extendend fixed

Some ASCII chars were not decoded correctly

Closing as we've upgraded to a newer version of ZXing.


Temporarily disable (remove) Slack workflow again because it sometime…

…s fails

#946 by Tyler will be a better solution.

closing this PR, since I don't think we will ever want to merge it given we already have the other solution in place


Multi-Market bot

Feature Suggestion
I don't understand why there's always only 1-to-1 market connection. Wouldn't it be much nicer if a bot just connects to all configured / connected markets and checks for a given pair? This way a bot could do arbitrage between the lowest ask and highest bid across 5 or even 10 spot markets. Wouldn't that make the system so much more powerful?
Impact
Arbitrage opportunities will be much higher.
┆Issue is synchronized with this Clickup task by Unito

@cardosofede Recommendation for Script, correct?

@MementoRC yes, this should be a script


Add integration tests

Integration tests can be executed with 'make integration-tests'.
The tests are not executed in the GitHub Action because it does not have access to a Kubernetes cluster.
It includes a basic test of the traceloop gadget.

Example of output:

$ time make integration-tests
go test -test.v ./integration/... -integration -image docker.io/kinvolk/gadget:latest # FIXME
=== RUN   TestDeploy
=== RUN   TestDeploy/Cleanup_test_namespace_from_previous_tests
=== RUN   TestDeploy/Cleanup_gadget_deployment_from_previous_tests
=== RUN   TestDeploy/Deploy_Inspektor_Gadget
=== RUN   TestDeploy/Wait_until_Inspektor_Gadget_is_ready
=== RUN   TestDeploy/Create_test_namespace
=== RUN   TestDeploy/Run_multiplication_pod
=== RUN   TestDeploy/Check_traceloop_list
=== RUN   TestDeploy/Get_trace_ID_for_the_multiplication_pod
=== RUN   TestDeploy/Check_traceloop_show
=== RUN   TestDeploy/Cleanup_test_namespace_from_previous_tests#01
=== RUN   TestDeploy/Cleanup_gadget_deployment_from_previous_tests#01
--- PASS: TestDeploy (22.96s)
    --- PASS: TestDeploy/Cleanup_test_namespace_from_previous_tests (0.72s)
        cli_test.go:117: Command: kubectl delete ns test-ig --force --grace-period=0 || true
        cli_test.go:121: Command returned:
            warning: Immediate deletion does not wait for confirmation that the running resource has been terminated. The resource may continue to run on the cluster indefinitely.
            Error from server (NotFound): namespaces "test-ig" not found

    --- PASS: TestDeploy/Cleanup_gadget_deployment_from_previous_tests (0.41s)
        cli_test.go:117: Command: kubectl gadget deploy $GADGET_IMAGE_FLAG | kubectl delete --force --grace-period=0 -f - || true
        cli_test.go:121: Command returned:
            warning: Immediate deletion does not wait for confirmation that the running resource has been terminated. The resource may continue to run on the cluster indefinitely.
            Error from server (NotFound): error when deleting "STDIN": serviceaccounts "gadget" not found
            Error from server (NotFound): error when deleting "STDIN": clusterrolebindings.rbac.authorization.k8s.io "gadget" not found
            Error from server (NotFound): error when deleting "STDIN": daemonsets.apps "gadget" not found

    --- PASS: TestDeploy/Deploy_Inspektor_Gadget (0.89s)
        cli_test.go:117: Command: $KUBECTL_GADGET deploy $GADGET_IMAGE_FLAG | kubectl apply -f -
        cli_test.go:121: Command returned:
            serviceaccount/gadget created
            clusterrolebinding.rbac.authorization.k8s.io/gadget created
            daemonset.apps/gadget created

    --- PASS: TestDeploy/Wait_until_Inspektor_Gadget_is_ready (5.39s)
        cli_test.go:117: Command: for POD in $(kubectl get pod -n kube-system -l k8s-app=gadget -o name) ; do kubectl wait -n kube-system --for=condition=ready $POD ; done ; sleep 2
        cli_test.go:121: Command returned:
            pod/gadget-6jrxv condition met
            pod/gadget-8f4hn condition met
            pod/gadget-jnmsz condition met

    --- PASS: TestDeploy/Create_test_namespace (0.29s)
        cli_test.go:117: Command: kubectl create ns test-ig
        cli_test.go:121: Command returned:
            namespace/test-ig created

    --- PASS: TestDeploy/Run_multiplication_pod (4.02s)
        cli_test.go:117: Command: kubectl run --restart=Never -ti -n test-ig --image=busybox multiplication -- sh -c 'RANDOM=output ; echo "3*7*2" | bc > /tmp/file-$RANDOM'
        cli_test.go:121: Command returned:

    --- PASS: TestDeploy/Check_traceloop_list (3.50s)
        cli_test.go:117: Command: sleep 2 ; $KUBECTL_GADGET traceloop list -n test-ig --no-headers | awk '{print $1" "$6}'
        cli_test.go:121: Command returned:
            multiplication deleted

    --- PASS: TestDeploy/Get_trace_ID_for_the_multiplication_pod (0.23s)
        cli_test.go:117: Command: $KUBECTL_GADGET traceloop list -n test-ig --no-headers | awk '{printf "%s", $4}'
        cli_test.go:121: Command returned:
            0000092edb8b3127
    --- PASS: TestDeploy/Check_traceloop_show (0.91s)
        cli_test.go:117: Command: $KUBECTL_GADGET traceloop show 0000092edb8b3127 | grep '\[bc\] write(1, .*, 3) = 3' | sed 's/^.*\[bc\]/[bc]/'
        cli_test.go:121: Command returned:
            [bc] write(1, "42\n", 3) = 3

    --- PASS: TestDeploy/Cleanup_test_namespace_from_previous_tests#01 (5.77s)
        cli_test.go:117: Command: kubectl delete ns test-ig
        cli_test.go:121: Command returned:
            namespace "test-ig" deleted

    --- PASS: TestDeploy/Cleanup_gadget_deployment_from_previous_tests#01 (0.83s)
        cli_test.go:117: Command: kubectl gadget deploy $GADGET_IMAGE_FLAG | kubectl delete -f -
        cli_test.go:121: Command returned:
            serviceaccount "gadget" deleted
            clusterrolebinding.rbac.authorization.k8s.io "gadget" deleted
            daemonset.apps "gadget" deleted

PASS
ok  	github.com/kinvolk/inspektor-gadget/integration	22.968s

real	0m23.373s
user	0m3.029s
sys	0m0.752s

There is a GitHub action that can provide minikube:
https://github.com/marketplace/actions/setup-minikube-kubernetes-cluster
I gave it a try in this other branch, but it does not work yet:
https://github.com/kinvolk/inspektor-gadget/commits/alban/integration_test2

I agree that integration tests are important, but I don't know if we should use go test in that way or just defining a bash script with all the steps. The go test solution looks complicated and I don't see the advantages know, do you have a strong opinion?

The advantages I see are the nicely presented output, parsing the flags (we could get options like -timeout and -v for free), and later when testing other gadgets we will need to run several processes at the same time and I think that will be easier to manage the streams of outputs in go, and also check them with regexp.

The traceloop test works when I add the "sleep 15" to make sure traceloop is fully initialised.

I think the PR description is outdated as it's working on Github Actions now, right?

Updated

I'm wondering how we could extend this to be reusable by other gadgets / integrations tests. I think command should not be an anonymous structure but a structure that exposes methods like Run, CheckOutput, etc. I don't know if your plans are to get this in place in this PR or just having some tests in place and then in a second moment improve the infrastructure of it.

I am not sure, but I think we can extend it in next PRs. One difficulty will be that with other gadgets like execsnoop, we will need to execute it in parallel to other commands.


Any thought on these loss graphs?

Did use the original PyTorch for a while but I needed 512x512 sized network, and find the adapations here. Now with TensorBoard, looking at the losses is easy, see below. What do you guys thinking of the graphs? So pix2pix adapted to 512x512, NO data augmentation in terms of cropping, my images are 512x512, so they go straight in.  Any thoughts are welcome!

Hi,
I don't know about your dataset, but does 0.014 is enough for your work ? You should end your learning to 55000 steps to avoid the divergency.
It also seems the L1 gradient takes an other way while the GAN wins over the discriminator !
How much is your gan_weight over the L1_weight ?
Regards,


Fixed Travis CI badge

pointed the link to updated build URL

Huh. It's ironic that Travis is failing on this PR, of all things. :P
[It's probably just this and/or this that need merging first -- I highly doubt a README.md update is actually at fault.]

I went ahead and cherry-picked this into #87 since I was already in "fix CI stuff" mode. Thanks for the fix!


Module security

Issue #, if available:
Description of changes:
A couple of changes included in the PR

Update to the granular permission setup notebook with instructions to add additional permissions to the execution role to prevent direct access to S3
New notebook for implementing feature group level access control (online/offline) using IAM policy (tag based approach)
reorganised 09-security-module with subfolder for the two above approaches

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Per notebook: 09-module-security/09-01-granular-access-control-lake-formation-offline/m9_01_nb0_row_cell_level_access_lf_setup.ipynb
Please add print statements for feature group names to ensure they are properly loaded from storage:
print(customers_feature_group_name)
print(orders_feature_group_name)
print(products_feature_group_name)

ERROR:  pyathena module was not installed

ModuleNotFoundError                       Traceback (most recent call last)
 in
6 import boto3
7 import sys
----> 8 from pyathena import connect
9 import pandas as pd
10 sys.path.append('..')
ModuleNotFoundError: No module named 'pyathena'

Per notebook: 09-module-security/09-01-granular-access-control-lake-formation-offline/m9_01_nb0_row_cell_level_access_lf_setup.ipynb
ERROR:
ModuleNotFoundError                       Traceback (most recent call last)
 in
9 import pandas as pd
10 sys.path.append('..')
---> 11 from utilities import Utils
12 from utilities import feature_store_helper
13
ModuleNotFoundError: No module named 'utilities'

Thanks @pmhargis-aws I have committed a new version of the notebook to address all the comments.  Thanks.

Merged the Pull-Request from module-security branch.


langchain-core v0.2.42

Checklist

[x] Used a personal fork of the feedstock to propose changes
[x] Bumped the build number (if the version is unchanged)
[x] Reset the build number to 0 (if the version changed)
[x] Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[x] Ensured the license file is being packaged.

Reviewer information
Git diff output:
% git diff langchain-core==0.2.41 langchain-core==0.2.42 -- libs/core/pyproject.toml
diff --git a/libs/core/pyproject.toml b/libs/core/pyproject.toml
index 364443590..8ace02afa 100644
--- a/libs/core/pyproject.toml
+++ b/libs/core/pyproject.toml
@@ -4,7 +4,7 @@ build-backend = "poetry.core.masonry.api"

 [tool.poetry]
 name = "langchain-core"
-version = "0.2.41"
+version = "0.2.42"
 description = "Building applications with LLMs through composability"
 authors = []
 license = "MIT"

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.
I do have some suggestions for making it better though...
For recipe/meta.yaml:

ℹ noarch: python recipes should usually follow the syntax in our documentation for specifying the Python version.

For the host section of the recipe, you should usually use python {{ python_min }} for the python entry.
For the run section of the recipe, you should usually use python >={{ python_min }} for the python entry.
For the test.requires section of the recipe, you should usually use python {{ python_min }} for the python entry.
If the package requires a newer Python version than the currently supported minimum version on conda-forge, you can override the python_min variable by adding a Jinja2 set statement at the top of your recipe (or using an equivalent context variable for v1 recipes).

ℹ PyPI default URL is now pypi.org, and not pypi.io. You may want to update the default source url.


[F] Build CookiesBanner component

@1aurend I'm going to merge this in so I have the button --sm classes you defined - can you tackle the small styling issues in another PR?


Remove 't' from question 2

Standards checklist:

[x] The PR title is descriptive.

[x] The PR doesn't replicate another PR which is already open.

[x] I have read the contribution guide and followed all the instructions.

[x] The code is mine or it's from somewhere with an MIT-compatible license.

[x] The code is efficient, to the best of my ability, and does not waste computer resources.

[x] The code is stable and I have tested it myself, to the best of my abilities.

Fixes #48

Can I just go ahead and make a new PR, I already messed this up.

@Mannuel25 Sure no problem. Once you create a new PR I will close this one down.
If you're using the command line you could try the following to amend the commit messsage https://stackoverflow.com/a/179147


Enabled constepxr support for clang-cl.

Thanks, this looks good.
Do you know if clang-cl uses _CPPUNWIND to indicate that exceptions are supported and enabled? I would expect so, but would like to confirm.
Probably in a separate issue/PR, Better Enums should start running tests on clang-cl in AppVeyor. I haven't tried using clang-cl yet. Is there anything particular to watch out for when using it with CMake and/or in AppVeyor, if you have tried either?

Actually, I just started using clang-cl myself and encountered this problem in my first test project.
Using it with CMake is rather easy (you just have to specify the toolset with -TLLVM-vs2014), but I have no experience with AppVeyor.
I would expect _CPPUNWIND to work too, as it tries to simulate VS as much as possible, but I'll check it.

Thanks!


[MRG]Support ml frameworks convert

#292
Add convert for ml frameworks such as sklearn, xgboost, lightgbm

needs unit test

move to the convert function

Seems a good re-organization

@univerone @YuanmingLeee  if no further suggestions, we can merge this


[MRG] Frontend: font, sidebar, data type link

Reduced font of index page

Sidebar:

Reduced font of text in sidebar and increased sidebar slightly so text fits
Remove white space on the left and top of side bar, which exists on certain pages
Removed 'What is RAMP?' link from sidebar. It didn't seem to fit with the other items which are all challenge specific. Now, the only link to the 'RAMP history' page is on the index page. Happy to add back if there are objections.

Problems:

Added quick note about events at the top of the problems page and link page listing challenges by data domain page. I didn't link the data science theme page because the themes seemed a bit arbitrary and messy but happy to add it if there are objections.
Added a header to the status icons reference

Slightly increased the font on the 'problem' and 'problems' pages

cc @agramfort @maikia

Merging - can update changes later.


First time Dashboard app is opened returns an error

When the personal tab app Dashboard is opened for the first time it returns a status 500 error.

To resolve the user needs to refresh the page. This creates a bad first time experience as there the app does work, but fails on the first opening.

Hi Ken,
I've seen this error when SQL Azure Firewall rules block the incoming connection.  App Insights shows an obvious SQL exception in this case.  Could this be what you are seeing?


Implement support for SearchType.ASSET_FOLDER on KIE Sandbox's WorksapceChannelApi implementation

This is relevant for WID searches that are relative to the currently open BPMN model.

Hi @tiagobento , I would like to ask these details

Is the WID the only area that will benefit from this new feature of it is only an example of many others?
Will be this new feature available only internally, for example in the BPMN editor WID files will be searched for do display custom nodes definitions in palette?
Will we change the home page workspace view/search somehow
Will be some new files (WID files) editable? readonly?
Will we add some new icons for WID files to inform users they are assets important somehow for KIE projects?
Will we add documentation how to use WID files in KIE projects?

@jomarko Thanks for your interest and your questions. This task was created to map a gap we have on the implementation of the Resource Content API on KIE Sandbox, all consequences of this support are out of scope here, as they're tied to the use of the API, not to the API implementation itself. Answering your first question, right now I only know about the WID use-case. All other questions you have are BPMN-specific, and are not in scope here I'd say. KIE Sandbox's Home page is not impacted by this too.


Unable to override the font size for the hours and relative-time classes

Is there an existing issue for this?

[X] I have searched the existing issues

Current Behavior
I am trying to change the font-size using card-mod for the .hours and .relative-time CSS classes but it doesn't seem to work,
card_mod:
  style: |
    .hours {
      color: ANTIQUEWHITE !important;
      font-size: 90% !important;
    }
    .relative-time, .time-remaining {
      font-size: 85% !important;
      color: silver !important;
    }

On further investigation, I saw that the classes have the font-size property set.
font-size: var(--time-size) !important;

Expected behaviour
Should be able to change the font-size using card-mod
Steps To Reproduce
No response
Mode
Event (default)
Card Version
9.0.0
Home Assistant Version
2023.9.3
Configuration
type: custom:atomic-calendar-revive
name: Home Calendar
entities:
  - entity: calendar.home_calendar
    icon: mdi:home
    color: DARKORANGE
enableModeChange: true
defaultMode: Event
fullDayEventText: All day
untilText: Until
showColors: true
maxDaysToShow: 7
maxEventCount: 6
showLocation: true
showMonth: true
eventTitleColor: BURLYWOOD
locationIconColor: AZURE
locationLinkColor: GAINSBORO
dimFinishedEvents: true
finishedEventOpacity: 0.6
showProgressBar: true
nameColor: DARKKHAKI
calWeekDayColor: '#b8490d'
calDayColor: rgb(179,222,120)
defaultCalColor: '#FF6347'
sortByStartTime: true
showRelativeTime: true
hideFinishedEvents: true
allDayBottom: true
showWeekDay: false
showDescription: false
showCurrentEventLine: false
card_mod:
  style: |
    .cal-card {
      background: #2E2E2E !important;
    }
    .calDateSelector .date, .prev, .next{
      color: #ffffff !important;
    }
    .calIconSelector ha-icon-button{
      color: #cdcdcd !important;
    }
    a, .headerName, .ha-icon-button, .cal-eventContainer {
      color: #ffffff !important;
    }
    .hours {
      color: ANTIQUEWHITE !important;
      font-size: 90% !important;
    }
    .event-date-month, .event-date-day, .event-date-week-day{
      color: Orchid !important;
    }
    .relative-time, .time-remaining {
      font-size: 85% !important;
      color: silver !important;
    }

Relevant log output
No response
Code of Conduct

[X] I agree to follow this project's Code of Conduct

Could you update to the new beta version and let me know if the issue is resolved for you?

Yes it worked. Thanks @marksie1988


[IRGen] Deadends don't need dealloc_pack_metadata.

There is a debug-build-only verification that is done for alloc_pack_metadata instructions that checks that there exist paired dealloc_pack_metadata instructions which will be keyed off of to clean up the on-stack variadic metadata packs corresponding to (the instruction after) the alloc_pack_metadata.
StackNesting omits the deallocation instruction (as does PackMetadataMarkerInserter) if it would be created in a dead end block. If all blocks in the dominance frontier of the alloc_pack_metadata instruction are dead-end blocks, then the verification will incorrectly fail.  It should not fail because it is not necessary to clean up the on-stack pack metadata (or any other stack allocations) in such a case.
If all such blocks are dead-end blocks, however, the alloc_pack_metadata's block itself is a dead-end block as well.  So during the verification, check whether the alloc_pack_metadata occurs in a dead-end block and do not fail verification if it does.
rdar://125265980

@swift-ci please test

@swift-ci please test

@swift-ci please test


Update all materials (readme, help messages, docs) to focus more on Kubernetes

odo is evolving past its 1.0 scope to be rooted on Kubernetes and also support OpenShift. Therefore we need to update various messaging to improve on this.
There are many places where the old tag line "OpenShift Do" exists.
Proposed changes from:
OpenShift Do - Fast, iterative OpenShift development
to:
odo - Fast, iterative Developer-focused CLI for Kubernetes & OpenShift
These changes should occur on:

[ ] Homepage
[ ] README
[ ] odo -?
[ ] Documentation

I'd strongly just refer to it as odo, which I don't think we need a proper noun version "Odo" that starts sentences.  If you read the man page for sh, it never calls it "Sh". The tool name is odo.

@Preeticp if you can please break down this epic into small parts and attach them here so we can have an itemised view on the epic's progress.

@girishramnani here's the doc issue that tracks this Epic: https://issues.redhat.com/browse/RHDEVDOCS-1823, do let us know if it needs any modifications.

Actually I was hoping for a list of issues (assuming this cannot be done in a single sprint)

Updated description with links to sub-tasks in the documentation epic. Also added an entry for Blogs in the checklist, please delete it if this is not within the scope of this issue.

@Preeticp can we please check off the acceptance criteria's that have been done?

From the docs team side, this has been taken care of in the Readme and the Documentation. I have checked them off @girishramnani

What work is left in blogs? I have been reviewing new blog posts from developers.redhat.com/blog and updated the internal FAQ on naming usage.

Struck down the Blogs part in the list, post our discussion. If the odo part, such as man pages and code have also been updated to odo, then we can close this issue.

@boczkowska @girishramnani Is this the final doc related issues list or we are expecting to consider some more?

With the exception of https://github.com/openshift/odo/issues/3749 I have addressed all above concerns with regards to Kubernetes references on our home page.
As discussed with DV, we went through (most) of the documentation with regards to OpenShift references and ensured that it says Kubernetes (first) and then OpenShift.

https://github.com/openshift/odo/issues/3749 has been merged and has also been merged to add the document to the website.
We can safely close this issue now!


Should Texture allow to open an 'XML' file directly?

While this does not make sense for full DARs, it could ease 'debugging' in an early phase.
Texture could take the XML, and treat it as a DAR without assets... more in the sense of 'Create DAR from JATS XML'.

That's more an import scenario.  Not sure if we should take over responsibility for that. Opening an XML will create all different kind of edge case scenarios. I think first there should be a CLI tool to convert those inputs to Dars (e.g. with fake images if they can't be resolved).

This idea is documented, but we think it is not worth be pursued.
If somebody thinks differently, please comment on this issue.


Update kernel version to v4.19.204-cip55

Building kernel image with this command, and it succeeded.
bitbake linux-base

Thanks!


db link not open in mysql sequencer？

What happened:
the db link did not initialized in mysql sequencer @GimmeCyy
related pr: https://github.com/mosn/layotto/pull/605
What you expected to happen:
How to reproduce it (as minimally and precisely as possible):
Anything else we need to know?:

Thanks for your feedback
@GimmeCyy Could u help with this issue?

这里的db是用sqlmock.New()出来的，所以没有去连接一个真实的数据库


reducing size of output jpg

Context: on S3, the tif corresponding to this image is below 30KB, but the output jpg on the iiif server is 461KB.
On the current website (using JAI), the corresponding image (here) is a png of about 30KB.
The png version is only 53KB, much more reasonable but still significantly more than the current website.
It seems hymir just uses the basic javax.imageio functions (see here) as provided by twelvemonkeys. The parameters that we can use in JPEGImageWriteParam look very limited. There doesn't seem to be a much better option in Java though.
This is an important issue for various reasons:

bigger files take longer to load
they cost us more to transfer to the user (we're paying the bandwidth)
a factor 10 in size is just completely unreasonable and probably indicates some deep problems

Here are a few ideas to start dealing with the issue:

[ ] first, let's bring @TBRC-JimK in: Jim, you'll develop some expertise in image treatment in Java for the asset manager, maybe we should share our doc, techniques, libraries, code, etc.?
[ ] a first easy action would be to tweak the Java jpg encoding quality values with the method suggested here, 90% is probably sufficient
[ ] we should log the decoders/encoders used by javax.imageio to make sure the correct ones are used (and probably also make sure we understand what the correct ones are)
[ ] we can also make some experiments to understand why a png produced with JAI is half the size as a png produced with imageio and report bugs or tweak configuration if needed
[ ] (I'm not sure my diagnosis is right here) then we should understand why the output jpg is full color while the original tif is black and white. It will require some diving into the Java APIs and internal image representation in Java
[ ] then we should understand if in these cases we can indicate to the iiif viewer to prefer png to jpg. This will require also some diving, this time in the iiif APIs (that's probably a job for me)

(edited)

I just want to add one remark here: unlike jpg rendering, png rendering of tiffs produces png having roughly the size of the initial tiff. It seems to me we might have an issue with jpg only.

I'm in the train now but we should run the same kind of tests on jpg files yes, and compare the size of S3, tbrc.org and iiif

(Aldo note that 53KB is 76% larger than 30KB, this is not something we can just ignore as a rounding error)

As color vs. BW is concerned, see https://github.com/dbmdz/iiif-server-hymir/blob/master/src/main/java/de/digitalcollections/iiif/hymir/image/frontend/IIIFImageApiController.java#L125 where COLOR is hardcoded. We can fix that on our side since we have our own Controller Implementation.

Excellent yes, this is something we should implement and contribute to Hymir

Here is a perf report (after I got rid of a double call to S3 by modifying hymir Image Service implementation)- Most of the time is taken by Image processing and png processing takes approximately twice the time of jpg processing.

Can you record the methodology and numbers in a Google doc? Also, maybe the cache mechanism should cache the result (png or jpg) instead of the source? It would probably make more sense in most cases

@MarcAgate thanks for the initial data. Some questions:

[ ] what is the "Building identifier from ldspdi" task. At ~12 ms per identifier that seems rather high to construct an identifier so there must be more to the task. If it's round-trip from hymir to ldspdi to fuseki to ldspdi to hymir then perhaps some short-circuiting should be considered
[ ] For the 6 samples the average transfer rate is 284 KBps w/ an average latency of 90 ms. It would be excellent to see data for fetching 1, 2, 4, 8 images at a time (either concurrently or via some sort of a bulk transfer, if possible, via the s3 api) with images around 25KB and several series of larger images, e.g., 500KB, 1MB, 2MB, and 5MB. The objective is to get a sense of how sensitive the ec2-s3 access is to how much is fetched at once and the overall size of the transfer
[ ] caching of the result (jpg or png) is not unreasonable, but it is worth considering caching the source as well we since if a pdf is requested generating directly from the source will avoid per image png/jpg processing from tiff which pdf is quite happy with.
[ ] further, regarding pdf generation it will be reasonable to use concurrent requests to s3 which s3 is designed for (rather than low-latency access). See Request Rate and Performance Guidelines and 10 Things About Using S3

Yes, building identifier is a round trip hymir-ldspdi-fuseki
Given hymir implementation, we need to cache both the raw tiff and processed images (in any standard format). I am currently working on this.
and 4) we already use multithreaded and concurrent s3 requests. I'll try to get more data on this if we decide that I should spend all that time on the overall iiif performance matter.

Thanks for the Google doc, I missed it the first time, sorry!
The round trip to Fuseki should happen only once per volume and not once per image request (is that the case?) so it's not the most important part I think (although of course we cannot ignore it).
The iiif performance are a crucial part of the new system yes, there should be at least no regression from tbrc.org (if possible an improvement). So it's absolutely worth spending some time on it. Maybe Jim can work on the image processing part (what do you think Jim?) But the rest (S3 connection, cache, etc.) are important too.

I have to finish audit tool (could be 6 weeks.) If I start building image processing, that would delay starting Asset Manager data plane & other things, although I think it would be a good thing to have in place where both Asset Manager and BUDA could get to it.
From: Elie Roux<EMAIL_ADDRESS>Reply-To: buda-base/buda-iiif-server<EMAIL_ADDRESS>Date: Monday, March 4, 2019 at 11:18
To: buda-base/buda-iiif-server<EMAIL_ADDRESS>Cc<EMAIL_ADDRESS><EMAIL_ADDRESS>Mention<EMAIL_ADDRESS>Subject: Re: [buda-base/buda-iiif-server] reducing size of output jpg (#23)
Thanks for the Google doc, I missed it the first time, sorry!
The round trip to Fuseki should happen only once per volume and not once per image request (is that the case?) so it's not the most important part I think (although of course we cannot ignore it).
The iiif performance are a crucial part of the new system yes, there should be at least no regression from tbrc.org (if possible an improvement). So it's absolutely worth spending some time on it. Maybe Jim can work on the image processing part (what do you think Jim?) But the rest (S3 connection, cache, etc.) are important too.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/buda-base/buda-iiif-server/issues/23#issuecomment-469313666, or mute the threadhttps://github.com/notifications/unsubscribe-auth/Af65RT4EOJAIROUJtvzlr4Qan2D1-U6Rks5vTUc9gaJpZM4bbzTJ.

There's another optimization to be done around here I think. We could have a function that detects if the image needs to be transformed, and if not the imgReader could be redirected directly to the output. In short: when the original is a jpg and the request is for the exact same jpg (/full/full/0/default.jpg), then the original can be served directly. This will optimize many cases.

bad news, none of the viewers can be asked to use png by default, see
https://github.com/IIIF/api/issues/1786
so we need to make the jpg output better

@berger-n is it feasible to package and use our fork of openseadragon? if it requires some code change (which I suspect it will), it would be best to create a new branch (buda-package), that would include the fix-1343 branch. I think if we can do that we could potentially use the .png instead of .jpg

Great job, that's really a huge improvement, and now we have a production-ready server, thanks! The 3 final points are less important I think as they don't hinder the performance too much and there's not much we can do about it... closing


Notifications not showing up on locked devices for newer version android

I've tested this on an OnePlus and it functions fine. But running the same code on Xiaomi devices for some reason doesn't show the notification when the phone is locked. It does show it when you pull the notifications drawer down when the phone is open, but not on the locked screen. I was thinking it might have to do with the NotificationManager.IMPORTANCE_LOW but tried setting that to different levels but that didn't help. Any advice on how to fix would be much appreciated.

So I've investigated this further and noticed it does have to do with the settings on newer devices, we need to give explicit permission for the notification to appear on locked screens. Without the permissions, it won't appear. I tried updating the code to make it so that we wouldn't need to prompt the user but I couldn't find a way to do it. I did see that spotify does have a way of doing it without the permissions so it should be possible. I couldn't figure it out though.

have you open the app settings notification?

@roeku @jeromexiong @rares45
have you found any solution for the same Android 11 Quick setting issue as well as locked screen issue.
if any one found any solution please share it.
Thanks


ICMP not working on Kubernetes even if sysctl -w net.ipv4.ping_group_range="0<PHONE_NUMBER>"

Describe the bug
Ping not working even if sysctl -w net.ipv4.ping_group_range="0<PHONE_NUMBER>" is configured.
net.ipv4.ping_group_range is set in initContainer which have privileged role an run as root.
I tried to mount an alpine container in same pod where gatus is. I can successfully use ping in this alpine container which have same securitycontext as gatus container, is running a non root user, on uid and guid 65534 (nobody)
I tried to ping google.com
Used config in config.yaml
endpoints:

name: TEST
enabled: true
url: "icmp://google.com"
interval: 60s
conditions:

"[CONNECTED] == true"
client:
timeout: 30s

What do you see?
Endpoint is returning not ok
What do you expect to see?
Ping success
List the steps that must be taken to reproduce this issue
Use icmp on endpoint running in Kubernetes using this endpoints config
endpoints:

name: TEST
enabled: true
url: "icmp://google.com"
interval: 60s
conditions:

"[CONNECTED] == true"
client:
timeout: 30s

Use initContainer with root privlege using alpine image and execute this command:
sysctl -w net.ipv4.ping_group_range="0<PHONE_NUMBER>"
Version
twinproduction/gatus:v5.7.0
Additional information
No response

I'm seeing the same behavior. I toyed around with passing sysctls to the securityContext and the method described by @jerome-karabenli -- both are unable to ping outside the pod.
I've search existing issues (#633, #182, #105) and I'm wondering if I'm missing something,

The issue is here https://github.com/TwiN/gatus/blob/master/client/client.go#L246
pinger.SetPrivileged(runtime.GOOS != "darwin")
This will set privileged to true on linux and need to use the privileged ping instead of the unprivileged one. Linux and darwin both support NonPrivileged ping (https://pkg.go.dev/golang.org/x/net/icmp?utm_source=godoc#example-PacketConn-NonPrivilegedPing) so I would expect it to be safe to only filter for windows.
The change was made here: https://github.com/TwiN/gatus/commit/c423afb0bf87d0e1be2f73fec25b5199acf1aed7 for issue #132 but darwin supports non-privileged pings so the windows only condition should be okay.

Feel free to make a PR if you think that'll fix it!

I created #748 in an attempt to address it, but I would appreciate if somebody (either @jerome-karabenli, @kevin7s-io, @h3mmy, @heathcliff26 or anybody reading this) could test it on their end and report back on whether #748 fixed it.
I've just built a container image; if you'd like to try it, pull twinproduction/gatus:experimental.
Note that the image in question is only built for linux/amd64.

Works on Windows, but not on my Kubernetes cluster, even with the following configuration on the pods
          securityContext:
            allowPrivilegeEscalation: true
            capabilities:
              add:
                - NET_RAW

https://github.com/influxdata/influxdata-docker/pull/550 and https://github.com/influxdata/influxdata-docker/issues/547 seems to have some information on what needs to be done to fix this.

I'm currently experiencing this issue, where my config that was working in docker doesn't work in Kubernetes.
I tried a bunch of things, such as capabilities, and using the same SC I use in blackbox-exporter:
podSecurityContext:
  sysctls:
    - name: net.ipv4.ping_group_range
      value: "0 65536"

which also didn't work. I already have set
enable_unprivileged_ports = true
enable_unprivileged_icmp = true

and that doesn't appear to help either.

I created #748 in an attempt to address it, but I would appreciate if somebody (either @jerome-karabenli, @kevin7s-io, @h3mmy, @heathcliff26 or anybody reading this) could test it on their end and report back on whether #748 fixed it.
I've just built a container image; if you'd like to try it, pull twinproduction/gatus:experimental.
Note that the image in question is only built for linux/amd64.

SO sorry I missed this. I went ahead an tested the branch in #748 and it works in my cluster.
This is a link to my HelmRelease: https://github.com/h3mmy/bloopySphere/blob/96329ee8e913168f11198920db4cd0f758b1ea68/cluster/apps/monitoring/gatus/app/helm-release.yaml
Important bits:

container running as non-root
dropped ALL capabilities
disallow privilege escalation
I do have an annotation to set the sysctls

annotations:
reloader.stakater.com/auto: "true"
https://github.com/prometheus-community/pro-bing#linux
security.alpha.kubernetes.io/sysctls: net.ipv4.ping_group_range=0<PHONE_NUMBER>

And the config I used as a test case: https://github.com/h3mmy/bloopySphere/blob/96329ee8e913168f11198920db4cd0f758b1ea68/cluster/apps/networking/traefik/external-services/nas-camelus.yaml

apiVersion: v1
kind: ConfigMap
metadata:
name: camelus-plexii-gatus-ep
namespace: networking
labels:
gatus.io/enabled: "true"
data:
config.yaml: |
endpoints:
- name: camelus-plexii-ping
group: infrastructure
url: icmp://${NAS_ADDRESS}
interval: 5m
ui:
hide-url: true
hide-hostname: true
conditions:
- "[CONNECTED] == true"
alerts:
- type: discord

Let me know if you'd like me to try any different arrangements for different scenarios.

The experimental image resolved it for me. I didn't need the annotation.

The experimental image resolved it for me. I didn't need the annotation.

It may vary with host distribution and kernel security profiles. I'm not an expert though.
Do you have any security profiles enabled on your host? AppArmor, seccomp, SELinux, etc?

I do not.

The following pod security context (pod, not container) fixed the issue for me:
      securityContext:
        sysctls:
          - name: net.ipv4.ping_group_range
            value: 0 65536

Just wanted to revisit this, as I realized I was still on the experimental image.
I tried swapping to 5.12, but IMCP still isn't working. I've tried the securityContext but that isn't resolving it either.
I have the following on the pod:
            securityContext:
              allowPrivilegeEscalation: false
              readOnlyRootFilesystem: true
              capabilities: { drop: ["ALL"] }
              sysctls:
              - name: net.ipv4.ping_group_range
                value: 0 65536

and the following defaultPodOptions:
    defaultPodOptions:
      dnsConfig:
        options:
          - { name: ndots, value: "1" }
      securityContext:
        runAsNonRoot: true
        runAsUser: 65534
        runAsGroup: 65534
        fsGroup: 65534
        fsGroupChangePolicy: OnRootMismatch
        seccompProfile: { type: RuntimeDefault }

I've tried putting the systctls in the defaultPodOptions.securityContext and commenting out the seccompProfile, but that hasn't worked either.

I'm facing the same issue. I pulled the latest image (5.13.1) and configured it the sysctls. It's still not working for me. I set up the dnsutils container from k8s registry to ensure this would work on my kubernetes environment (Oracle Kubernetes Engine) with another container. I was able to show it being denied and then allowing with the sysctl securityContexts.
I also noticed when I set an endpoint to external ping (GitHub.com); it was successful with https:// but not with icmp://


litmus: init at 0.13

Motivation for this change
Add litmus-package, to test WebDAV-servers.
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[ ] Fits CONTRIBUTING.md.

Notify maintainers
cc @

Argh, the pull-request did more than I meant.
I'll create a new pull-request...


Extract common gradle

Closes #31

None of the tracked files have been edited, so it isn't clear why codecov is saying coverage has gone down.


Automated Package Upgrade

:tada: This PR is included in version 7.7.245 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


iOS TestFlight version 1.0.0+1: click events on settings/about dialogues are wrongly passed to the underlying 3D layer and triggered the animation of reference object

Only the iOS build can produce this issue.
The macOS build, the Windows build, the Unity editor have no this issue.
Not a blocking issue for the iOS release.

Confirmed that this issue can be reproduced in xcode+iOS simulator.
It is an iOS-specific issue.

Reference doc:
https://answers.unity.com/questions/784617/how-do-i-block-touch-events-from-propagating-throu.html

Root cause:
EventSystem.current.IsPointerOverGameObject() requires a parameter. The default value of the parameter is -1, which means mouse left button. On mobile devices, the touchId must be passed in to test if the touch event is happening over a GUI object.