Updated code examples to ES2015, is this relevant?

Without thinking too much I updated all the documentation to ES2015(es6) and changed the code style to use semicolons and fixed some typos that could cause errors if copy-pasted, however only after finishing all of it I realized that it would cause many conflicts.
Is this relevant or should I forget about it?

Hey! Thanks for doing that! I think it would be better for us if you could submit smaller PRs with the typos first so that we can take a look at one thing at a time. Massive PRs tend to get stalled, as you noted, it becomes harder to manage the conflicts.
Re: ES6, @chrisvfritz and I have talked about this a few times, more recently we thought it might be a good direction, though that was a casual conversation so I might be mistaken. We really should hear his take before moving forward. Again, this would probably be best as a smaller PR that's separate from the typos so we can get a clean review. Thanks!

@sdras Thanks for replying, when I wrote typos I meant code errors, not grammar. In some cases, there are missing commas and other small errors that would break the code.
At this point, it will be very hard for me to separate those from the other changes.
Overall I made the code more consistent, In many cases, you could find in the same document es6/next syntax and in the next example es5 syntax, as well as different coding styles.
A summary of the most common changes is:

Anonymous functions into arrow functions(I did check for binding differences, so don't worry).
In object literals, I changed function properties into methods, for example:

render: function(h) { /* ... */ }

// into
render(h) { /* ... */ }

Inconsistencies in coding styles within the same topic(just to be clear, I wasn't very opinionated, I only made changes when you could find different coding styles within the same document, in the same topics, but there are other cases in which I did use the same syntax all over, for example in render functions.), example:

render: (h) => { /* ... */ }
// Changed into:
render(h) { /* ... */ }

Replaced all the var declarations with const(I didn't find even one case where let was needed).
Added semicolons everywhere. This one(Is seems...) is an opinionated change, but I feel like it made the code more readable in many cases, for example when chaining objects with indentation, and you are trying to find when does the line end, and when It is a different object, which happened
a lot in the animations tutorials.

In addition, there were other small changes as I explained above, like missing commas (and other stuff that I can't remember) that would break the code. And I never touched code within {% raw %} blocks. This means that the code in the examples is different in syntax to the code in the demos.

@phanan I agree with most of your point, and as I said, I didn't think much before doing it so I don't expect this to even be considered, however, I do think that converting the code to es6 should be strongly considered in addition to enforcing a coding style on the examples.
The reason I assumed that this might be a good idea is that most of the docs that I read(i think its safe to say the majority of them) has mixed ES5 and ES6 and mixed use of semicolons.
And I also agree that ideally, the code within {% raw %} blocks should be identical to the examples but In the real world its never the case, however, I do understand that it can be a nightmare to maintain(although it might be easier than thought to just automate it, then it adds maintenance concerns again).
Putting that aside for a sec, If it wasn't obvious yet, Im new to contributing to open source projects and I would really like to contribute to Vue, what would be a good place to start doing that(If needed at all)?
And thanks for your time!

@samuelgozi a great place to start would be to consider some of those small changes you mentioned where you think the code is actually broken- but in small PRs please. The docs has it's own coding style so please keep that in consideration. If we do move to ES6 for all code samples, it will likely be a larger undertaking that will be decided on with the team and particularly @chrisvfritz. For that reason I will close this issue out but it doesn't mean we aren't considering it.
Another way to contribute would be to check out the other issues in this repo- there are a few that are "low-hanging fruit". In other words, smaller changes that you could make and submit a pull request for.
Thanks!


human 3.6m dataset error

hello.
I downloaded the original videos and cdf files from  human3.6m and processed these files by provided matlab codes.
Then I found I could only extracted 1447 joints data(no matter 3d data or 2d data) from cdf files of s_09_act_05_subact_02_ca_04(actually all videos of different views has this problem).
but in your validation cache you provided data more than 1447.
could you please help me.

and I found there are  about 200 images' joints data I extracted from cdf files are different from yours provided in validationmin cache

@bucktoothsir I am facing the same issue. Did you solve it?


Goto folder

new chained function allows you to go directly to a folder in the menu system, only really been tried on 'NET RADIO'

thanks! published with<EMAIL_ADDRESS>


Switch to = default syntax

With VS 2015 (I haven't tried with VS 2017), the following code is problematic:
class float4
{
    float4() {}
    float4(float a) { ... }
    ~float4() {}
};

float4 texels[2][2];

The problem is that VS 2015 (and earlier versions, probably) doesn't realize, when exception handling is enabled, that the default constructor and the destructor do nothing and in particular don't throw. Because of that, it actually generates code to initialize all 2x2=4 float4 objects in the line
float4 texels[2][2];

Specifically, it generates a call to __vec_ctor and __vec_dtor which are compiler-generated functions, as described here:
https://www.geoffchappell.com/studies/msvc/language/compgen/index.htm?tx=12
Marking them __forceinline doesn't solve the problem.
What does solve the problem though is using C++11's way of telling to the compiler that we want the default implementation:
class float4
{
    float4() = default;
    float4(float a) { ... }
    ~float4() = default;
};

More details:
https://stackoverflow.com/questions/1025313/will-an-empty-constructor-or-destructor-do-the-same-thing-as-the-generated-one/2322314#2322314

We need to switch to this syntax for all performance-sensitive classes (foundation::Vector, foundation::Color, etc.).
Note that = default is not supported by VS 2012, which we still need to use to build some versions of the 3ds Max and Maya plugins.

Done.


Powershell Obfuscation

Hello,
Whenever we use the crackmapexec in corporate environment with --mimikatz option, we dont receive any output. Mostly because AV flags mimikatz and stop execution. Is it possible to obfuscation the mimikatz powershell script can be obfuscated and then sent to target ? I saw one project for powershell obfuscation (https://github.com/danielbohannon/Invoke-Obfuscation).
Do guide, if i am missing on something.

Any plans to release this feature in upcoming v4.0 ?

@c0d3xpl0it yup! I'm planning on integrating PS obfuscation in v4.0 using Invoke-Obfuscation. There is currently an issue with PowerShell v2.0 compatibility with the obfuscated scripts, I'm currently working with the author to resolve this issue https://github.com/danielbohannon/Invoke-Obfuscation/issues/10

Update on this, the code to support obfuscation through Invoke-Obfuscation is done (https://github.com/byt3bl33d3r/CrackMapExec/blob/master/cme/helpers/powershell.py), Im still currently waiting for that issue to be resolved.

implemented in 7149b24524cbd8b9b2ad6c42f7a1f6214c4137d9


Q: Additional Facebook properties

{{#facebook-share tagName="a" fb-layout='button' url=this.shareUrl caption="caption" description="description" picture="[redacted]/1450474936965/003.jpg"}}
    Share on Facebook
{{/facebook-share}}

Hello,
Additional properties such as caption, description & picture don't seem to be supported. Am I missing something?

@basz the library should ideally support the full range of the API. Anything missing would be gladly merged as a PR.

It's seems quite easy to add. I extended your fb component and add title in FB.ui:
function showDialog(FB) {
      let title = self.get('title');
      FB.ui(
        {
          method: 'share',
          href: self.get('url'),
          title: title,
        },

And then i simply have to send my custom title in {{#facebook-share}}.
I suppose it will work for the others properties.
If I have the time to do a clean pull request I will but I think you can easily add it yourself.
:)


Add support for the GCP and OIDC auth providers

This required an upgrade to the 1.5 client.
Fixes #9

Oh, this fix involved much less than what i would have expected, nice find!
I'm unable to test this though, could you point at some resources regarding this so we can just double check things before merging this in? Other than verifying this works i'd say it's good to go. @hatchan maybe you have some thoughts?

@akupila:

make a backup of your .kubectl/config file.
enable access token based auth (docs)gcloud container clusters get-credentials <CLUSTER>
gcloud auth application-default login

Also unable to test this. But was wondering are all those new dependencies caused by the dependencies of the upgrade to kubernetes 1.5?

But was wondering are all those new dependencies caused by the dependencies of the upgrade to kubernetes 1.5?

AFAIK, yes. I upgraded with govendor fetch ... which should not included unused deps. Also i did not notice any unused packages in govendor list

Any update on this? Really looking forward to using stern with GCP.

This version has been working great for me in the past 7days

This works great for me and resolves the issue. Since there are no tests it's hard to say for sure this doesn't break anything but my vote is to merge :-)

Sorry for the delays here! Holidays and stuff.. While we haven't tested this i trust it's 👍


Give option to remove instagram, twitter, etc

Though I know how to edit the template, it'll be nice if you give an option to remove the social links. I don't use Instagram, so I don't want to display it.
Also, some color options for "Things I do" will be great.
Thanks,
Raj

I pushed the code to disable social icons. So, please use the latest.

To disable Instagram icon, leave Instagram as empty in your config file.
Now, the color options are not available. It may come in future updates. I will notify you when its come.


Only recurses 1 level

The script doesn't seem to crawl the entire directory structure but only changes ownership of the objects immediately within the shared folder.
Between this and the #19, it's hard to find usefulness in this script outside cases simple situations that are relatively quick to do manually via the web interface already.

The script doesn't seem to crawl the entire directory structure but only changes ownership of the objects immediately within the shared folder.

That's incorrect. Recursion happens for any nested folder at any depth: https://github.com/davidstrauss/google-drive-recursive-ownership/blob/master/transfer.py#L112

Between this and the #19, it's hard to find usefulness in this script outside cases simple situations that are relatively quick to do manually via the web interface already.

Directory structures are preserved under many but not all circumstances. Much of this is a result of how Google Drive handles objects, which isn't like a normal file system. One of the characteristics is that a file cannot be in a folder for someone without being shared or owned by them, but sometimes changing the owner seems to put the object into the root of the destination user's Google Drive.
In general, it's a lot harder to move a hierarchy when the items (or at least folders) aren't already shared to the destination account. The script handles the sharing/ownership to the best ability of the API, which appears more limited than some of what the web app itself does, which offers recursive sharing (but not ownership changes) directly.
So, I believe you can work around the issue by pre-sharing. I'm not sure it's possible to solve in the script  itself.

@davidstrauss any chance we get some UTF8 love so we can use the script for non ASCII filenames?

any chance we get some UTF8 love so we can use the script for non ASCII filenames?

Let's chat on #26, which I see you've created.


clarification tensorflow + magenta .mag file / cyclic redundancy problem

Awesome job on this project.
I'm looking to extend functionality over to support magenta.
Yes, granted current library isn't rigged up to do this.
https://github.com/tensorflow/magenta
I added a .mag file from google's tensorflow / magenta project.
They are using a metagraph file - this contains a few extra protobuf files needed from tensorflow.
Tensorflow_MetaGraphDef /MetaInfoDef and others etc
(Side Note - feel free to cherry pick this stash - my branch includes all files
https://github.com/johndpope/swift-grpc-tensorflow/tree/0.0.2
If you ever find yourself wanting to programmatically convert proto files - you may also want to checkout  https://github.com/nubbel/swift-tensorflow/blob/master/RUNME.sh )
so I rigged up a new wrapper to extract the graph def  from a metagraphdef
https://github.com/johndpope/Bender/
if let path = Bundle.main.path(forResource: "attention_rnn", ofType: "mag"){
        let model = try? Data(contentsOf:URL(fileURLWithPath: path))

        // pull apart inception model.
        let myGraphProto = try? Tensorflow_Magenta_GeneratorBundle.init(serializedData:model!)

        let metaGraphData = myGraphProto!.metagraphFile

        let graph1 = try? Tensorflow_MetaGraphDef.init(serializedData:metaGraphData)
        print("graph1:",graph1)
        https://gist.github.com/johndpope/7be8b9b365050ad9615938ae15c36ac4

        // this errors.
          var graph =  TFGraph(graphDef: graph1.graphDef)
    }

could there be  a specific nip and tuck that could be done to get this to work?
https://gist.github.com/johndpope/7be8b9b365050ad9615938ae15c36ac4
related
https://github.com/tensorflow/magenta/issues/710

Thanks! :smile:
You have a Metagraph file, but you have a whole checkpoint? If you do, consider using benderthon, as described in the docs, so you can convert it to a frozen and small graph.

I don't know much about magenta and .mag files, but the file format seems to be a protobuf with GeneratorBundle as a protocol, defined in generator.proto. To simplify the process, you can load that with benderthon, forking it and then freezing and saving the graph.
With respect to the cyclic problem, it seems to be related to the RNNs. Where does it manifest exactly?

@johndpope can you provide a frozen graph so it's easier for us (and for others) to test it?

I'm digging through tensorflow magenta forums.
all my code is pushed to master here ->
https://github.com/johndpope/Bender/
I'll keep digging for check point file + meta file.

https://github.com/tensorflow/magenta/tree/master/magenta/models/melody_rnn#creating-a-bundle-file
Creating a Bundle File
The bundle format is a convenient way of combining the model checkpoint, metagraph, and some metadata about the model into a single file.
https://github.com/tensorflow/magenta/blob/master/magenta/protobuf/generator.proto

from looking at code under the hood of bender - it seems more appropriate for image stuff rather than vanilla rnn / lstm tensorflow models. going to close this.


native_posix linking issues under Ubuntu 18.04 after upgrade

Here're 2 facts:

I didn't build for BOARD=native_posix for a while.
Yesterday I upgraded from Ubuntu 16.04 to Ubuntu 18.04, which uses gcc 7.3.0 and other fancies of a modern linux distro, like PIE executables and what not.

Trying to build for BOARD=native_posix now I get:
[ 98%] Linking C executable zephyr.elf
/usr/bin/x86_64-linux-gnu-ld: i386 architecture of input file `CMakeFiles/zephyr_prebuilt.dir/misc/empty_file.c.obj' is incompatible with i386:x86-64 output
/usr/bin/x86_64-linux-gnu-ld: i386 architecture of input file `../libapp.a(main.c.obj)' is incompatible with i386:x86-64 output
/usr/bin/x86_64-linux-gnu-ld: i386 architecture of input file `libzephyr.a(thread_entry.c.obj)' is incompatible with i386:x86-64 output
/usr/bin/x86_64-linux-gnu-ld: i386 architecture of input file `libzephyr.a(crc32_sw.c.obj)' is incompatible with i386:x86-64 output
/usr/bin/x86_64-linux-gnu-ld: i386 architecture of input file `libzephyr.a(crc16_sw.c.obj)' is incompatible with i386:x86-64 output
/usr/bin/x86_64-linux-gnu-ld: i386 architecture of input file `libzephyr.a(crc8_sw.c.obj)' is incompatible with i386:x86-64 output
/usr/bin/x86_64-linux-gnu-ld: i386 architecture of input file `libzephyr.a(mempool.c.obj)' is incompatible with i386:x86-64 output

With VERBOSE=1 it's:
[ 98%] Linking C executable zephyr.elf
cd /home/pfalcon/projects-3rdparty/Embedded/Zephyr/zephyr/samples/hello_world/build/p/zephyr && /usr/local/bin/cmake -E cmake_link_script CMakeFiles/zephyr_prebuilt.dir/link.txt --verbose=1
ccache /usr/bin/gcc    CMakeFiles/zephyr_prebuilt.dir/misc/empty_file.c.obj  -o zephyr.elf -T linker.cmd -Wl,-Map=/home/pfalcon/projects-3rdparty/Embedded/Zephyr/zephyr/samples/hello_world/build/p/zephyr/zephyr.map -u_OffsetAbsSyms -u_ConfigAbsSyms -Wl,--whole-archive ../libapp.a libzephyr.a arch/posix/core/libarch__posix__core.a soc/posix/inf_clock/libsoc__posix__inf_clock.a boards/boards/posix/native_posix/libboards__posix__native_posix.a -Wl,--no-whole-archive kernel/libkernel.a CMakeFiles/offsets.dir/arch/posix/core/offsets/offsets.c.obj -L/home/pfalcon/projects-3rdparty/Embedded/Zephyr/zephyr/samples/hello_world/build/p/zephyr -Wl,--gc-sections -Wl,--build-id=none -ldl -pthread -lm
/usr/bin/x86_64-linux-gnu-ld: i386 architecture of input file `CMakeFiles/zephyr_prebuilt.dir/misc/empty_file.c.obj' is incompatible with i386:x86-64 output
/usr/bin/x86_64-linux-gnu-ld: i386 architecture of input file `../libapp.a(main.c.obj)' is incompatible with i386:x86-64 output
/usr/bin/x86_64-linux-gnu-ld: i386 architecture of input file `libzephyr.a(thread_entry.c.obj)' is incompatible with i386:x86-64 output

It clearly looks like -m32 is missing from the link command line, and indeed, re-running that command in the appropriate dir with -m32 added leads to a successful link and working executable.

native_posix builds fine in Ubuntu 18.04 w gcc 7.3.

Maybe for you, but not for me, see above.

You need to install the gcc-multilib & g++-multilib After, remember to clean before rebuilding.

Sure, I did all that.

This is clean virtual machine with the packages needed to compile zephyr + cmake + the zephyr sdk
lsb_release -a
No LSB modules are available.
Distributor ID:	Ubuntu
Description:	Ubuntu 18.04 LTS
Release:	18.04
Codename:	bionic
alpi@alpiX1804v:~/aescolar-ot$ uname -a
Linux alpiX1804v 4.15.0-23-generic #25-Ubuntu SMP Wed May 23 18:02:16 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
alpi@alpiX1804v:~/aescolar-ot$ mkdir build ; cd build
alpi@alpiX1804v:~/aescolar-ot$ source zephyr-env.sh
alpi@alpiX1804v:~/aescolar-ot$ cd build/
alpi@alpiX1804v:~/aescolar-ot/build$ cmake ../samples/hello_world/ -GNinja -DBOARD=native_posix
-- Found PythonInterp: /usr/bin/python3 (found suitable version "3.6.5", minimum required is "3.4")
-- Selected BOARD native_posix
Zephyr version: 1.13.99
Parsing Kconfig tree in /home/alpi/aescolar-ot/Kconfig
Loading /home/alpi/aescolar-ot/boards/posix/native_posix/native_posix_defconfig as base
Merging /home/alpi/aescolar-ot/samples/hello_world/prj.conf
-- Generating zephyr/include/generated/generated_dts_board.h
-- Cache files will be written to: /home/alpi/.cache/zephyr
-- The C compiler identification is GNU 7.3.0
-- The CXX compiler identification is unknown
-- The ASM compiler identification is GNU
-- Found assembler: /usr/bin/gcc
-- Performing Test toolchain_is_ok
-- Performing Test toolchain_is_ok - Success
--
*******************************
*** NOTE TO KCONFIG AUTHORS ***
*******************************

The behavior of Kconfig 'default' properties in Zephyr has changed. The
earliest default with a satisfied condition is now used, instead of the
last one. This is standard Kconfig behavior.

See http://docs.zephyrproject.org/latest/porting/board_porting.html#old-zephyr-kconfig-behavior-for-defaults.

To get rid of this note, create a file called 'hide-defaults-note' in the
Zephyr root directory. An empty file is fine.
-- Configuring done
-- Generating done
-- Build files have been written to: /home/alpi/aescolar-ot/build
alpi@alpiX1804v:~/aescolar-ot/build$ ninja
[1/69] Preparing syscall dependency handling

[69/69] Linking C executable zephyr/zephyr.elf
alpi@alpiX1804v:~/aescolar-ot/build$ zephyr/zephyr.exe
***** Booting Zephyr OS v1.9.0-7536-g73c217802 *****
Hello World! native_posix
^C
Stopped at 0.690s
alpi@alpiX1804v:~/aescolar-ot/build$ git log | head
commit 73c21780272d1f7f4382c9213c463f3ddbca5716

If you have updated your installation, maybe the gcc you are running is not the default one from the ubuntu  distro? In that case you need to install the gcc-mulitlib for that gcc package. (say gcc-7-multilib)

I indeed upgraded from Ubuntu 16.04. The gcc is:
pfalcon@x230:~$ which gcc
/usr/bin/gcc
pfalcon@x230:~$ gcc -v
Using built-in specs.
COLLECT_GCC=gcc
COLLECT_LTO_WRAPPER=/usr/lib/gcc/x86_64-linux-gnu/7/lto-wrapper
OFFLOAD_TARGET_NAMES=nvptx-none
OFFLOAD_TARGET_DEFAULT=1
Target: x86_64-linux-gnu
Configured with: ../src/configure -v --with-pkgversion='Ubuntu 7.3.0-16ubuntu3' --with-bugurl=file:///usr/share/doc/gcc-7/README.Bugs --enable-languages=c,ada,c++,go,brig,d,fortran,objc,obj-c++ --prefix=/usr --with-gcc-major-version-only --with-as=/usr/bin/x86_64-linux-gnu-as --with-ld=/usr/bin/x86_64-linux-gnu-ld --program-suffix=-7 --program-prefix=x86_64-linux-gnu- --enable-shared --enable-linker-build-id --libexecdir=/usr/lib --without-included-gettext --enable-threads=posix --libdir=/usr/lib --enable-nls --with-sysroot=/ --enable-clocale=gnu --enable-libstdcxx-debug --enable-libstdcxx-time=yes --with-default-libstdcxx-abi=new --enable-gnu-unique-object --disable-vtable-verify --enable-libmpx --enable-plugin --enable-default-pie --with-system-zlib --with-target-system-zlib --enable-objc-gc=auto --enable-multiarch --disable-werror --with-arch-32=i686 --with-abi=m64 --with-multilib-list=m32,m64,mx32 --enable-multilib --with-tune=generic --enable-offload-targets=nvptx-none --without-cuda-driver --enable-checking=release --build=x86_64-linux-gnu --host=x86_64-linux-gnu --target=x86_64-linux-gnu
Thread model: posix
gcc version 7.3.0 (Ubuntu 7.3.0-16ubuntu3)

multilib packages:
$ dpkg -l | grep multilib
ii  g++-4.8-multilib                                            4.8.5-4ubuntu8                              amd64        GNU C++ compiler (multilib support)
ii  g++-5-multilib                                              5.5.0-12ubuntu1                             amd64        GNU C++ compiler (multilib support)
ii  g++-7-multilib                                              7.3.0-16ubuntu3                             amd64        GNU C++ compiler (multilib support)
ii  g++-multilib                                                4:7.3.0-3ubuntu2                            amd64        GNU C++ compiler (multilib files)
ii  gcc-4.8-multilib                                            4.8.5-4ubuntu8                              amd64        GNU C compiler (multilib support)
ii  gcc-5-multilib                                              5.5.0-12ubuntu1                             amd64        GNU C compiler (multilib support)
ii  gcc-7-multilib                                              7.3.0-16ubuntu3                             amd64        GNU C compiler (multilib support)
ii  gcc-multilib                                                4:7.3.0-3ubuntu2                            amd64        GNU C compiler (multilib files)

So, everything looks ok. Thanks for confirming that it works for you in a clean VM and for other hints. As you can see, I unassigned this from you, will try to dig further myself (though I'd appreciate hints if I get stuck). My plan is to check how cmake passes -m32 to link stage and why it might be dropped. (Will work on this as time permits.)

And this is how the link line looks like in the example above:
[69/69] : && ccache /usr/bin/gcc    zephyr/CMakeFiles/zephyr_prebuilt.dir/misc/empty_file.c.obj  -o zephyr/zephyr.elf  -T zephyr/linker.cmd -Wl,-Map=/home/alpi/aescolar-ot/build/zephyr/zephyr.map -u_OffsetAbsSyms -u_ConfigAbsSyms -Wl,--whole-archive libapp.a zephyr/libzephyr.a zephyr/arch/posix/core/libarch__posix__core.a zephyr/soc/posix/inf_clock/libsoc__posix__inf_clock.a zephyr/boards/boards/posix/native_posix/libboards__posix__native_posix.a -Wl,--no-whole-archive zephyr/kernel/libkernel.a zephyr/CMakeFiles/offsets.dir/arch/posix/core/offsets/offsets.c.obj -L/home/alpi/aescolar-ot/build/zephyr -Wl,--gc-sections -Wl,--build-id=none -ldl -pthread -m32 -lm && cd /home/alpi/aescolar-ot/build/zephyr && /usr/bin/python3 /home/alpi/aescolar-ot/scripts/check_link_map.py zephyr.map && /usr/bin/objdump -S zephyr.elf > zephyr.lst && /usr/bin/readelf -e zephyr.elf > zephyr.stat && /usr/bin/cmake -E rename zephyr.elf zephyr.exe

Are you sure you have deleted the build directory and rebuilt?

Maybe check with alternatives which gcc you are actually running.

@pfalcon : Given that this issue seems to be related to your particular compilers setup, would you consider it reasonable to close it? (You can still re-open it later if you want to add something)

Given that this issue seems to be related to your particular compilers setup,

That's not my evaluation of this issue, mine would be "CMake build system doesn't have reliable enough ways to detect i386 vs x86_64 systems, leading to build errors". It's true that I'm the first to report it, but that doesn't mean nobody else is affected - it's just nobody else reported it yet (you can just wait for an echo thru the years).
As I mentioned, I unassigned you from this ticket, thanks for triaging it. Let me assign it to myself to avoid any confusion. If you wouldn't like to receive further notifications on this ticket, there's "Unsubscribe" button on the right of page. Thanks.

@nashif : This really seems to be an issue with Paul's multiple compilers installation/packaging issues after a distro upgrade, and not related to Zephyr per se.

@pfalcon: Using Ubuntu 16.04.10 I have the same issue, -m32 appears to be missing from the link line. This was not an upgrade, it was a recent fresh install.
[69/69] Linking C executable zephyr/zephyr.elf
FAILED: : && ccache /usr/bin/gcc    zephyr/CMakeFiles/zephyr_prebuilt.dir/misc/empty_file.c.obj  -o zephyr/zephyr.elf  -T zephyr/linker.cmd -Wl,-Map=/home/paul/zephyr/build/zephyr/zephyr.map -u_OffsetAbsSyms -u_ConfigAbsSyms -Wl,--whole-archive libapp.a zephyr/libzephyr.a zephyr/arch/posix/core/libarch__posix__core.a zephyr/soc/posix/inf_clock/libsoc__posix__inf_clock.a zephyr/boards/posix/native_posix/libboards__posix__native_posix.a -Wl,--no-whole-archive zephyr/kernel/libkernel.a zephyr/CMakeFiles/offsets.dir/arch/posix/core/offsets/offsets.c.obj -L/home/paul/zephyr/build/zephyr -Wl,--gc-sections -Wl,--build-id=none -ldl -pthread -lm && cd /home/paul/zephyr/build/zephyr && /usr/bin/python3 /home/paul/zephyr/scripts/check_link_map.py zephyr.map && /usr/bin/objdump -S zephyr.elf > zephyr.lst && /usr/bin/readelf -e zephyr.elf > zephyr.stat && /usr/local/bin/cmake -E rename zephyr.elf zephyr.exe
/usr/bin/ld: Warning: size of symbol `zephyr_app_main' changed from 26 in libapp.a(main.c.obj) to 5 in zephyr/kernel/libkernel.a(init.c.obj)
/usr/bin/ld: i386 architecture of input file `zephyr/CMakeFiles/zephyr_prebuilt.dir/misc/empty_file.c.obj' is incompatible with i386:x86-64 output
/usr/bin/ld: i386 architecture of input file `libapp.a(main.c.obj)' is incompatible with i386:x86-64 output
/usr/bin/ld: i386 architecture of input file `zephyr/libzephyr.a(thread_entry.c.obj)' is incompatible with i386:x86-64 output
/usr/bin/ld: i386 architecture of input file `zephyr/libzephyr.a(crc32_sw.c.obj)' is incompatible with i386:x86-64 output
/usr/bin/ld: i386 architecture of input file `zephyr/libzephyr.a(crc16_sw.c.obj)' is incompatible with i386:x86-64 output
/usr/bin/ld: i386 architecture of input file `zephyr/libzephyr.a(crc8_sw.c.obj)' is incompatible with i386:x86-64 output
/usr/bin/ld: i386 architecture of input file `zephyr/libzephyr.a(mempool.c.obj)' is incompatible with i386:x86-64 output

gcc is:
$ which gcc
/usr/bin/gcc
$ gcc -v
Using built-in specs.
COLLECT_GCC=gcc
COLLECT_LTO_WRAPPER=/usr/lib/gcc/x86_64-linux-gnu/5/lto-wrapper
Target: x86_64-linux-gnu
Configured with: ../src/configure -v --with-pkgversion='Ubuntu 5.4.0-6ubuntu1~16.04.10' --with-bugurl=file:///usr/share/doc/gcc-5/README.Bugs --enable-languages=c,ada,c++,java,go,d,fortran,objc,obj-c++ --prefix=/usr --program-suffix=-5 --enable-shared --enable-linker-build-id --libexecdir=/usr/lib --without-included-gettext --enable-threads=posix --libdir=/usr/lib --enable-nls --with-sysroot=/ --enable-clocale=gnu --enable-libstdcxx-debug --enable-libstdcxx-time=yes --with-default-libstdcxx-abi=new --enable-gnu-unique-object --disable-vtable-verify --enable-libmpx --enable-plugin --with-system-zlib --disable-browser-plugin --enable-java-awt=gtk --enable-gtk-cairo --with-java-home=/usr/lib/jvm/java-1.5.0-gcj-5-amd64/jre --enable-java-home --with-jvm-root-dir=/usr/lib/jvm/java-1.5.0-gcj-5-amd64 --with-jvm-jar-dir=/usr/lib/jvm-exports/java-1.5.0-gcj-5-amd64 --with-arch-directory=amd64 --with-ecj-jar=/usr/share/java/eclipse-ecj.jar --enable-objc-gc --enable-multiarch --disable-werror --with-arch-32=i686 --with-abi=m64 --with-multilib-list=m32,m64,mx32 --enable-multilib --with-tune=generic --enable-checking=release --build=x86_64-linux-gnu --host=x86_64-linux-gnu --target=x86_64-linux-gnu
Thread model: posix
gcc version 5.4.0 20160609 (Ubuntu 5.4.0-6ubuntu1~16.04.10)

multilib packages:
$ dpkg -l | grep multilib
ii  g++-5-multilib                              5.4.0-6ubuntu1~16.04.10                            amd64        GNU C++ compiler (multilib support)
ii  g++-multilib                                4:5.3.1-1ubuntu1                                   amd64        GNU C++ compiler (multilib files)
ii  gcc-5-multilib                              5.4.0-6ubuntu1~16.04.10                            amd64        GNU C compiler (multilib support)
ii  gcc-multilib                                4:5.3.1-1ubuntu1                                   amd64        GNU C compiler (multilib files)

Would be interesting to try a 16.04 clean vm to see if it is broken?

@paulsykes : Cool, thanks for confirmation and additional info. Previous to upgrade, I was on 16.04 and everything was ok for me. (16.04 was itself upgraded from 14.04.)
It's still on my todo to debug this.

From the console log above: zephyr/samples/hello_world.

The posix arch cmake file sets the "-m32"
About 16.04 I just tried, and it works fine in a clean machine. Here the exact steps I followed:
This image:
http://ftp.uni-kl.de/pub/linux/ubuntu-dvd/xubuntu/releases/16.04/release/xubuntu-16.04.5-desktop-amd64.iso

#Installed on clean VM (Virtualbox 5.2.4, new vdi), selecting during install:
#    Download updates while installing
#    Erase disk and install

#On first boot installed VirtualBox guest aditions & reboot

#Followed steps from https://docs.zephyrproject.org/latest/getting_started/installation_linux.html
sudo apt-get update
sudo apt-get upgrade
sudo apt-get install --no-install-recommends git cmake ninja-build gperf \
ccache doxygen dfu-util device-tree-compiler \
python3-ply python3-pip python3-setuptools python3-wheel xz-utils file \
make gcc-multilib autoconf automake libtool librsvg2-bin \
texlive-latex-base texlive-latex-extra latexmk texlive-fonts-recommended

git clone https://github.com/zephyrproject-rtos/zephyr.git

#continue with steps from guide
cd zephyr
pip3 install --user -r scripts/requirements.txt

#I skip installing the sdk just to save time
sudo mkdir -p /opt/zephyr-sdk/
sudo chown banana.banana /opt/zephyr-sdk/
cat <<EOF > /opt/zephyr-sdk/sdk_version
0.9.3
EOF

cat <<EOF > ~/.zephyrrc
export ZEPHYR_TOOLCHAIN_VARIANT=zephyr
export ZEPHYR_SDK_INSTALL_DIR=/opt/zephyr-sdk
EOF

mkdir $HOME/cmake && cd $HOME/cmake
wget https://cmake.org/files/v3.8/cmake-3.8.2-Linux-x86_64.sh
yes | sh cmake-3.8.2-Linux-x86_64.sh | cat
echo "export PATH=$PWD/cmake-3.8.2-Linux-x86_64/bin:\$PATH" >> $HOME/.zephyrrc

#Trying it out:

cd ../zephyr/
source zephyr-env.sh
mkdir build ; cd build
cmake ../samples/hello_world/ -GNinja -DBOARD=native_posix
ninja
zephyr/zephyr.exe
#=> It works..

The posix arch cmake file sets the "-m32"

Yeah, and I thought maybe it's conditional on some checks, but it's not:
zephyr_ld_options(
  -ldl
  -pthread
  -m32
)

Now the fun thing: there were a bunch of toolchain upgrades in 18.04 this weekend, which I installed. Ant trying to build now for BOARD=native_posix, everything links well (I tried hello_world and samples/subsys/shell/shell_module).
I don't known what may be involved. Maybe cmake tries to smartass thru app's link flags and remove something on its whim? (Btw, @aescolar, how do we deal with building native_posix on 32-bit system?)
Anyway, now I'm keen to close this, @paulsykes, let us know if you plan to investigate your case further and keeping the ticket open is beneficial.

Btw, I don't use -GNinja, i.e. use ol' good makefiles.

Ok, let's close this for now, can reopen if stable reproduction cases are provided.

Sigh, I hit this starting from scratch with 18.04 minimal setup and following instructions. There are some steps missing.

@jimschm : It is quite annoying that this is happening to some people. But it is very difficult to know what is the problem from the descriptions provided so far in this issue.
Which app are you trying to build? Which cmake version? which Ubuntu version?
Are you able to provide a reproducible set of steps where it will happens?

Yeah, my feedback isn't super actionable, except that it is another independent report. What I did is described well above. I installed 18.04 fresh from Ubuntu into a VirtualBox VM, then followed online instructions closely, including SDK installation. I put SDK export lines into .zephyrrc which was not explicitly instructed but fairly obvious. This brought me to the point where I could run cmake, but then compiler etc. was not installed. I installed a few more every day packages (build-essential, gcc-multilib, g++-multilib). Then I got here.
Unfortunately I don't have the time to troubleshoot. I switched to 16.04, did exact same steps, and it worked fine.

@jimschm: I guess, going forward, we need to collect some objective data for the working/non-working environments. As an initial step, can start with providing output for the following commands:
cmake --version
dpkg -l gcc gcc-multilib binutils libc6 cmake

For me (working env):
pfalcon@x230:~$ cmake --version
cmake version 3.8.2

CMake suite maintained and supported by Kitware (kitware.com/cmake).
pfalcon@x230:~$ dpkg -l gcc gcc-multilib binutils libc6 cmake
Desired=Unknown/Install/Remove/Purge/Hold
| Status=Not/Inst/Conf-files/Unpacked/halF-conf/Half-inst/trig-aWait/Trig-pend
|/ Err?=(none)/Reinst-required (Status,Err: uppercase=bad)
||/ Name                        Version            Architecture       Description
+++-===========================-==================-==================-============================================================
ii  binutils                    2.30-21ubuntu1~18. amd64              GNU assembler, linker and binary utilities
un  cmake                       <none>             <none>             (no description available)
ii  gcc                         4:7.3.0-3ubuntu2.1 amd64              GNU C compiler
ii  gcc-multilib                4:7.3.0-3ubuntu2.1 amd64              GNU C compiler (multilib files)
ii  libc6:amd64                 2.27-3ubuntu1      amd64              GNU C Library: Shared libraries
ii  libc6:i386                  2.27-3ubuntu1      i386               GNU C Library: Shared libraries

(As can be seen, my cmake doesn't come from distro, it's actually a manual install from ubuntu 16.04 times, when distro version was too low for Zephyr's need. Need to try distro version one of these days, but not right now, as I need to get work done, not debug build tools hell too.)

but then compiler etc. was not installed.

We are actually not telling people to install gcc or gcc-multilib in the getting started guide.. The multilib dependency is only mentioned in the native_posix board page. I will do a PR to update the getting started list of packages for Ubuntu. (Maybe this issue is the result of running cmake the first time without the needed things, then installing them, and then running it again with a corrupted cmake working directory (?))

and then running it again with a corrupted cmake working directory (?)

Definitely not for me. rm -rf ... is my frequent command during Zephyr development (I don't trust Zephyr's own clean).

I am well versed with cmake. That said it's good to mention in the instructions that tool paths are cached in the build directory.


Demo of simple recommendation engine microservice

Create a notebook that:

has a preconfigured meetup topic name
handles a GET with a natural language string as a text query param a
does entity detection on the text (using Alchemy?)
generate a meetup.com search URL for a upcoming meetups on that topic near to the (first?) location detected in the text
returns the link in a JSON response like {"url": "<the search url>"}

Have a Dockerfile that packages the notebook, the kernel, and the kernel gateway together. Document how to build and deploy (locally) the container in a simple README. Document / demonstrate how, once it's deployed, it can be invoked by existing tools, perhaps with another microservice also in play to do any necessary transformation of requests/responses.
For example, to demonstrate an IFTTT flow that monitors tweets address to a meetup bot username and tweets friendly responses with meetup links:

Setup a "if Maker POST then tweet it" and get its Make URL and event name
Create a "if Tweet then Maker GET" to another microservice that:

has a preconfigured URL of the meetup service (above)
has a preconfigured URL of the Maker response endpoint
accepts the twitter username and tweet text as URL args
invokes the meetup microservice with the text
invokes the Maker response endpoint with a tweet directed to the requesting user containing the link in the response text

Consider showing how other clients  like Slack, NodeRED, etc. can also take advantage of the microservice.

/cc @nitind


RemoteServiceException

Version
Media3 1.2.1
More version details
sometimes i see in crashlitics crashes like that:
Fatal Exception: android.app.RemoteServiceException: Context.startForegroundService() did not then call Service.startForeground(): ServiceRecord{4106886 u0 com.kamancho.melisma/.player.presentation.PlayerService}
at android.app.ActivityThread$H.handleMessage(ActivityThread.java:2044)
at android.os.Handler.dispatchMessage(Handler.java:106)
at android.os.Looper.loop(Looper.java:223)
at android.app.ActivityThread.main(ActivityThread.java:7700)
at java.lang.reflect.Method.invoke(Method.java)
at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:612)
at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:997)
Fatal Exception: android.app.RemoteServiceException: Bad notification for startForeground
at android.app.ActivityThread.throwRemoteServiceException(ActivityThread.java:2046)
at android.app.ActivityThread.access$2900(ActivityThread.java:273)
at android.app.ActivityThread$H.handleMessage(ActivityThread.java:2275)
at android.os.Handler.dispatchMessage(Handler.java:106)
Fatal Exception: android.app.RemoteServiceException$CannotDeliverBroadcastException: can't deliver broadcast
at android.app.ActivityThread.throwRemoteServiceException(ActivityThread.java:2090)
at android.app.ActivityThread.-$$Nest$mthrowRemoteServiceException()
at android.app.ActivityThread$H.handleMessage(ActivityThread.java:2357)
at android.os.Handler.dispatchMessage(Handler.java:106)
at android.os.Looper.loopOnce(Looper.java:201)
at android.os.Looper.loop(Looper.java:288)
at android.app.ActivityThread.main(ActivityThread.java:8115)
at java.lang.reflect.Method.invoke(Method.java)
at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:703)
at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:911)
Devices that reproduce the issue
First exception: Bird - FIH Foxconn P670  android 11, Huawei Honor 10 Lite android 10
Second: Transsion Tecno Pova 4 android 12
Third: Transsion Tecno android 13
Devices that do not reproduce the issue
n/d
Reproducible in the demo app?
Yes
Reproduction steps
n/d
Expected result
not crash
Actual result
crash
Media
n/d
Bug Report

[ ] You will email the zip file produced by adb bugreport to<EMAIL_ADDRESS>after filing this issue.

Hi @BoikoIlya,
Could you please provide reproduction steps for this issue? What kind of media are you selecting in the demo app?
It is interesting that it doesn't work for Android 10, 11, 12 and 13. I found the following bug https://issuetracker.google.com/issues/245258072 and it looks like most people only struggle with Android 13. It's been marked as fixed, but there is some activity around it on SO.

https://stackoverflow.com/questions/72902856/cannotdeliverbroadcastexception-only-on-pixel-devices-running-android-12
https://stackoverflow.com/questions/76340386/fatal-exception-android-app-remoteserviceexception-cant-deliver-broadcast
https://stackoverflow.com/questions/46971153/fatal-exception-android-app-remoteserviceexception-cant-deliver-broadcast-at
https://stackoverflow.com/questions/48804456/how-to-fix-android-app-remoteserviceexception-without-any-message-not-related

It looks like a problem lower down and cannot be fixed by the Exoplayer team, so I will close this issue. Please see if the issue remains on the latest Android 14 version. If so, my best advice is to wait for AOSP to ship a bugfix.


Date/Time formats

Description
I've set the data/time format to follow system preferences but a LOT of folders do not adhere to these changes I've made. Some show correctly and some don't. The folders don't remember their column widths, as well
Steps To Reproduce

Settings
Appearance
Date Format
System

Expected behavior
ALL the files should show the correct selected format
Files Version
1.5
Windows Version
Windows 11 Pro 21H2 22000.184
Relevant Assets
No response

Thanks for the report. Both this issues should be fixed in Files v2.

Hi,
I'm trying to get access to the v2 preview but after asking for an OTP, it
ask for a password which I don't have.
Thanks in advance
PS: This file browser is AWESOME
On Sat, 11 Sept 2021 at 09:21, Marco Gavelli @.***>
wrote:

Thanks for the report. Both this issues should be fixed in Files v2.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/files-community/Files/issues/6101#issuecomment-917358196,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ACC3CFKZGZE2RBHFIS7DKSLUBL7RBANCNFSM5D2VB2XQ
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

Glad you like it 🙏. An easier way to get Files v2 is to join the Files discord server https://discord.gg/files. The installers for preview versions of Files get regularly posted there.

PS: @RedSkyRoad where do you get asked for a password when trying to get Files preview? Have you filled this form: https://forms.office.com/r/E5Lri2nGqe?

I went to that discord server and then it said something went weird and
asked to send an otp to my phone
On Sat, 11 Sept 2021 at 09:57, Marco Gavelli @.***>
wrote:

PS: @RedSkyRoad https://github.com/RedSkyRoad where do you get asked
for a password when trying to get Files preview? Have you filled this form:
https://forms.office.com/r/E5Lri2nGqe?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/files-community/Files/issues/6101#issuecomment-917362912,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ACC3CFI3RI4C4HQEGR44Q53UBMDWPANCNFSM5D2VB2XQ
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

That lnk you just posted does nothing when I click Accept invite
On Sat, 11 Sept 2021 at 10:30, Barend Stapelberg @.***>
wrote:

I went to that discord server and then it said something went weird and
asked to send an otp to my phone
On Sat, 11 Sept 2021 at 09:57, Marco Gavelli @.***>
wrote:

PS: @RedSkyRoad https://github.com/RedSkyRoad where do you get asked
for a password when trying to get Files preview? Have you filled this form:
https://forms.office.com/r/E5Lri2nGqe?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/files-community/Files/issues/6101#issuecomment-917362912,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ACC3CFI3RI4C4HQEGR44Q53UBMDWPANCNFSM5D2VB2XQ
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

I've filled that Microsoft form as well. I'm not having ANY luck at getting
to a download link
On Sat, 11 Sept 2021 at 10:31, Barend Stapelberg @.***>
wrote:

That lnk you just posted does nothing when I click Accept invite
On Sat, 11 Sept 2021 at 10:30, Barend Stapelberg @.***>
wrote:

I went to that discord server and then it said something went weird and
asked to send an otp to my phone
On Sat, 11 Sept 2021 at 09:57, Marco Gavelli @.***>
wrote:

PS: @RedSkyRoad https://github.com/RedSkyRoad where do you get asked
for a password when trying to get Files preview? Have you filled this form:
https://forms.office.com/r/E5Lri2nGqe?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/files-community/Files/issues/6101#issuecomment-917362912,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ACC3CFI3RI4C4HQEGR44Q53UBMDWPANCNFSM5D2VB2XQ
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

Hi,
I haven't received any news as to the v2 I requested
On Sat, 11 Sept 2021 at 11:11, Marco Gavelli @.***>
wrote:

I've filled that Microsoft form as well. I'm not having ANY luck at
getting to a download link
You don't get a download link with the form, you just have to wait a 2/3
days and you should get the updated version from the Microsoft Store.
I went to that discord server and then it said something went weird and
asked to send an otp to my phone
Yep, with this method you need a Discord account if you don't have one
already
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/files-community/Files/issues/6101#issuecomment-917372965,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ACC3CFKPTXHDXAUI23NB7HTUBMMM7ANCNFSM5D2VB2XQ
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.


Airlock - Suggested API

Suggested API for the Airlock process:
The API suggested below corresponds to both the import and the export flows.
In order for a researcher to submit a new request, first the user must upload the files to the relevant container (for import == the external container, for export == the shared container). Then the user can create the request and specify the files.
(How the user gets the container url + token is not part of this document, assume the user has it)
Researcher

Create new import request
POST /api/workspaces/<workspace_id>/requests
{
  "type": "import",
  "files": ["file1.txt", "file2.txt"],
  "business_justification": "Meaningful text..."
}

note: the files should have  already being uploaded to the external storage container
Response
201 Created
{
  "requestId": "abcd1234-5678-9101-1121-31415161718x"
}

Cancel request
Cancelling a request, does not delete the request itself, it moves it to a 'cancelled' state and moves the data to rejected storage
POST /api/workspaces/<workspace_id>/requests/<request_id>/cancel
{
 "reason": "Some text"
}

Response
200 OK

Update request - not supported. one can close and create a new request

Get request status
GET /api/workspaces/<workspace_id>/requests/<request_id>/status
Response
{
  "status": "in-review/approved/rejected/cancelled/blocked"
}

blocked == when the scanning process detected malicious content or any other scanner did not approve the content.
Allowed for the: ws owner, data steward

Get reviews related to the request
GET /api/workspaces/<workspace_id>/requests/<request_id>/reviews
Response
200 OK
 {
    "reviews": [ { "review_decision": "approved/rejected", "decision_explanation": "Describe why the request was approved/rejected"}]
 }

Get review
GET /api/workspaces/<workspace_id>/requests/<request_id>/reviews/<review_id>
Response
200 OK
 {
  "review_decision": "approved/rejected",
  "decision_explanation": "Describe why the request was approved/rejected"
 }

TRE admin

Approve / Reject
POST /api/workspaces/<workspace_id>/requests/<request_id>/reviews
 {
   "review_decision": "approved/rejected",
   "decision_explanation": "Describe why the request was approved/rejected"
 }

Response
{
  "review_id": "xyzw1234-5678-9101-1121-31415161718x"
}

Allowed for the: data steward (TRE admin)

Get request's download links
GET  /api/workspaces/<workspace_id>/importrequests/<request_id>/download

Response
200 OK
    {
      "links": ["https://xyz.blob.core.windows.net/mycontainer?sp=abcdefg&sig=xyz...1Abc1", "https://xyz.blob.core.windows.net/mycontainer?sp=abcdefg&sig=xyz...1Abc2", "https://xyz.blob.core.windows.net/mycontainer?sp=abcdefg&sig=xyz...1Abc3", "https://xyz.blob.core.windows.net/mycontainer?sp=abcdefg&sig=xyz...1Abc4]
    }

Agree, where permissions need to be different a separate endpoint makes sense. And you are correct about reviews.
Do we also need an API to list the files that can be selected for import/export?

The request, and reviews also need to have the user's object ID and a date/time, similar to an operation.

Good points. updating

Agree, where permissions need to be different a separate endpoint makes sense. And you are correct about reviews.
Do we also need an API to list the files that can be selected for import/export?

Good question. If we say that the user uploads files to the container using a sas token with only Create permission for example, then either the user remember the file names and specify those in the request creation, or indeed the user needs an API to list the files, the problem with this API is how will we show only files uploaded by that user...
(if we don't care about knowing other's files, which I don't think its the case, we can just give LIST permissions in the sas token)

@Elad,
Canceling a request should be a PATCH method:

HTTP PATCH : Allows to do partial modifications in an entity. While POST creates a new one, and PUT replaces an existing one, PATCH just updates the properties you are sending, leaves the rest at they are.

@elad, Canceling a request should be a PATCH method:

HTTP PATCH : Allows to do partial modifications in an entity. While POST creates a new one, and PUT replaces an existing one, PATCH just updates the properties you are sending, leaves the rest at they are.

I think PATCH is more suitable if we update the request itself. what I proposed is /cancel.
I can change it to cancel the request itself and addinng a property to the request schema. wdyt

@eladiw agree might have multiple reviewers in the future per request.
Re listing files to be uploaded, copying and pasting any sort of names or tokens is a challenge for users. We need to make it as easy as possible. I don't think there is a concern with users seeing filenames of files that are going from or to a workspace they are part of.

@marrobi I agree. so basically we say that we have an external storage account PER workspace

Unless we could use a SAS token scoped to a blob container per workspace?

I think PATCH is more suitable if we update the request itself. what I proposed is /cancel.
I can change it to cancel the request itself and addinng a property to the request schema. wdyt

Yes, initial I thought of having status property for the process. Hence the cancel would be a PATH to update this property and execute any cancelling task needed.

@marrobi added a) getting storage containers b) listing the containers files c) added user id to the request and review
@joalmeid I have merged status to the GET of the actual request

@eladiw thinking about the containers. How about a flow where a user creates a request, that then creates a container and provides the upload details to the user, the request is in draft status, they put all the files they want into the container, then submit the request?
This means the container is only for that user, and we don't have to list/select files in the container?

interesting, and that container will get deleted afterwards

@marrobi  I liked the idea. updated the design
All, please re-review as I changed it quite a bit.


SPFx Enterprise Guidance: about making an app "available for use in the site collection“

Category

[x] Question
[x] Typo
[ ] Bug
[ ] Additional article idea

Expected or Desired Behavior
In the article about “Enterprise Guidance” for SPFx it says: “To enable a SharePoint Framework solution on a site collection, the site collection administrator must add it to the site collection. This is done in the same way as for SharePoint Add-ins, by selecting to Add a new app on the site collection, and then choosing the solution from the list of apps. Once the app is added, it is available for use in the site collection.”
https://github.com/SharePoint/sp-dev-docs/blob/master/docs/spfx/enterprise-guidance.md
I’m not sure if this paragraph is intended to mean you can make the app available anywhere in a Site Collection by adding it to one place in the Site Collection. I could be wrong, but I understand that SPFx apps need to be added to each individual subsite unless you were using “tenant scoped” deployment which is only available in SP 2019 and SPO. I am working in SharePoint 2016 and would love to know if there is a way I can avoid adding the SPFx app to each subsite in an environment that has hundreds of subsites.
Thanks.

Hi @samculver
For your last question (avoid add SPFx web part/extension multiple times), you can try deployment option to select which sites you want to add for your app.
This blog talks about how to deploy apps in multiple sites.


issue#49: Check that listeners exist before removing them. Also re-ru…

…n coffee with version 1.9.3

Ping @wvanbergen. Is this going to be accepted?


Create FAQ

See

See https://github.com/stryker-mutator/stryker-mutator.github.io/pull/19

Closing this issue, as it has to do with stryker-mutator.github.io


Modifying the comments of inceptionV3 dimensions

Modifying the comments of inceptionV3 dimensions to match the pytorch convention. Relevant (https://github.com/pytorch/vision/pull/719#pullrequestreview-203194302)

Sure! Done.


Reform Argument Parsing

A note to myself to fix up and merge the argparse branch, which has a sketch for cleaner argument parsing.

Done!


Enable incremental build when building Generator from source

Problem
As long as the generator is not released officially we have to build it from source.
Currently the only way is to perform a clean build every single time. This causes building tests to take much longer.
Changes
I implemented -b/--build flags to enable building from source without cleaning.

Could we somehow provide a pre-build generator? 🤔 (maybe including it in our git)
Just thinking ... to keep changes to the actual code as low as possible.

@stonko1994 yes, that is also possible. I made this to allow testing the changes I made on the generator directly.
That could be a way forward until the multi-platform changes are merged into the original repo and released as a new version.
It is as easy as to copy the run file into our repo and update the script that calls it.


Handle relative and absolute URLs coincidence in CSS filter in yii.js

I found this issue during writing tests for yii.js.
Let's take a look at the current contents of the CSS filter in yii.js which is a part of initScriptFilter() function and used to prevent loading of the same stylesheets.
$(document).ajaxComplete(function (event, xhr, settings) {
    var styleSheets = [];
    $('link[rel=stylesheet]').each(function () {
        if (isReloadable(this.href)) {
            return;
        }
        if ($.inArray(this.href, styleSheets) == -1) {
            styleSheets.push(this.href)
        } else {
            $(this).remove();
        }
    })
});

The url is retrieved from this.href and used as is.
With JS filter it's converted to absolute to prevent possible coincidence of urls like /js/script.js and http://foo.bar/js/script.js which are essentially the same if the current site is http://foo.bar:
 var url = options.url.charAt(0) === '/' ? hostInfo + options.url : options.url;

So I think the same needs to be done with CSS.
Currently if if the current site is http://foo.bar and we load /css/stylesheet.css first and then http://foo.bar/css/stylesheet.css, it will be loaded as a duplicate.
I think it was simply forgotten to be added for CSS.

Note: I already fixed it in PR containing tests for yii.js. PR will be sent soon.

Yes, should be fixed,


NavigationView Background Color

How can one change navigation background color to custom color?

with the property "Background"

or if you want to replace the Panel Acrylic Material you can override the NavigationViewMaterial resource (for the next previous release I'm going to put a PanelMaterial property)

Am really grateful for your dedicated support.
Thanks Thanks Thanks.
I was asking for that part that contains icons or navigation title.

sorry for not seeing your comment on this issue, to edit the panel's background you need to change the property PanelMaterial like this:

Thanks


[WinForms] Deprecate and remove ability to access Windows Forms objects from native code

Deprecate and remove ability to access Windows Forms objects from native code
Accessing Windows Forms objects from native code was deprecated as .NET runtime no longer supports creation of custom type libraries out of the box, nor it can't depend on the type library for .NET Framework (as would require to maintain the shape of classes as they were in .NET Framework)

Version introduced
.NET 5.0 Preview 7
Old behavior
A number of Windows Forms types were decorated as visible to COM interop, and thus accessible to native code.
New behavior

Remove ComVisible(true) from enums, they were used for TLB generation/lookup. Since there is no WinForms TLB provided by .NET Core there is no value in keeping this attribute.
Remove ComVisible(true) from AccessibleObject classes. They are not CoCreateable (no parameterless constructor) and exposing an already existing instance to COM does not require that attribute.
Remove ComVisible(true) from Control/Component classes. This was used to allow hosting of WinForms controls via OLE/ActiveX, for example in VB6 or MFC. However this requires a TLB for WinForms which is no longer provided, as well as registry-based activation which also would not work out of the box. Generally there was no maintenance of COM based hosting of WinForms controls so its likely to be broken, therefore removing support for COM based hosting of WinForms controls instead of leaving it in an unsupported state.

This commit also removes ClassInterface attributes from controls. If hosting via OLE/ActiveX is not supported these attributes are not needed anymore. They are kept in other places where objects are still exposed to COM and the attribute may be relevant.

Remove ComVisible(true) from EventArgs. They were most likely used with OLE/ActiveX hosting, which is no longer supported. They are not CoCreateable either so the attribute has no purpose. Exposing existing instances without providing a TLB makes no sense either.
Remove ComVisible(true) from delegates. Purpose is unknown but since ActiveX hosting of WinForms Controls is no longer supported its unlikely to have any purpose any more.
Remove ComVisible(true) from some non-public code. The only potential consumer would be the new VS designer, but without a GUID specified its unlikely that its still needed.
Remove ComVisible(true) from some arbitrary public designer classes. The old VS designer may have been using COM interop to talk to them, but the old designer doesn't support .NET Core so there is most likely no one who needs these ComVisible.
IWin32Window defined the same GUID as defined in .NET Framework which has dangerous consequences. If interop with .NET Framework is required this can be ComImported.
The WinForms managed IDataObject was made ComVisible. This is not required, there is a separate ComImport interface declaration for IDataObject COM interop. Having the managed IDataObject being ComVisible is actually counterproductive since no TLB is provided and marshaling will always fail. Also the GUID was not specified and differed from .NET Framework so its unlikely that removing an undocumented IID will affect customers negatively.
Remove ComVisible(false) - those are placed in seemingly arbitrary places and are redundant when the default is to not expose classes to COM interop (if the default is to expose, then current set of annotations would also be wrong because way too few classes have this annotation)

Reason for change
It worked on .NET Framework because it had a type library which made Form support IDispatch (which basically allowed the JavaScript to call back into the form subclass via reflection). .NET Core runtime no longer supports creation of custom type libraries out of the box, nor it can't depend on the type library for .NET Framework (as would require to maintain the shape of classes as they were in .NET Framework).
On .NET Core the decision was (after much discussion) that you do not want to create your own type library (not supported by .NET runtime out of the box anymore, requires manual work), and that you do not want to depend on the type library of .NET Framework (would have required to maintain the shape of classes as they were on Desktop). As
Recommended action
The following example that relied on the .NET Framework type library (which basically allowed the JavaScript to call back into the form subclass via reflection) works on .NET Framework and .NET Core 3.1, but no longer works on .NET 5.0:
[PermissionSet(SecurityAction.Demand, Name="FullTrust")]
[System.Runtime.InteropServices.ComVisibleAttribute(true)]
public class Form1 : Form
{
    private WebBrowser webBrowser1 = new WebBrowser();

    protected override void OnLoad(EventArgs e)
    {
        webBrowser1.AllowWebBrowserDrop = false;
        webBrowser1.IsWebBrowserContextMenuEnabled = false;
        webBrowser1.WebBrowserShortcutsEnabled = false;
        webBrowser1.ObjectForScripting = this;

        webBrowser1.DocumentText =
            "<button " +
            "onclick=\"window.external.Test('called from script code')\">" +
            "call client code from script code</button>" +
            "";
    }

    public void Test(String message)
    {
        MessageBox.Show(message, "client code");
    }
}

There are two possible ways to make the example working.

Introduce a user-declared ObjectForScripting object which supports IDispatch (which is applied by default, unless changed explicitly at the project level)

public class MyScriptObject
{
    private Form1 _form;

    public MyScriptObject(Form1 form)
    {
        _form = form;
    }

    public void Test(string message)
    {
        MessageBox.Show(message, "client code");
    }
}

public partial class Form1 : Form
{
    protected override void OnLoad(EventArgs e)
    {
        // ...

        // will work correctly
        webBrowser1.ObjectForScripting = new MyScriptObject(this);

        // ...
    }
}

Declare an interface with the methods to expose

public interface IForm1
{
    void Test(string message);
}

[ComDefaultInterface(typeof(IForm1))]
public partial class Form1 : Form, IForm1
{
    protected override void OnLoad(EventArgs e)
    {
        // ...

        // will work correctly
        webBrowser1.ObjectForScripting = this;

        // ...
    }
}

Category

[x] Windows Forms

Affected APIs
All Windows Forms API

Issue metadata

Issue type: breaking-change

@weltkante @JeremyKuhne could you please review the wording

@weltkante @JeremyKuhne could you please review the wording

Some points in the PR description outline different options, obviously only one of them was taken:

Remove ComVisible(true) from some non-public code. The only potential consumer would be the new VS designer, but without a GUID specified its unlikely that its still needed. Can provide a GUID if required.

IWin32Window had a conflict with Desktop Framework which has dangerous consequences, see discussion in issue. Resolution can be either removing ComVisible(true) if not required ore generating a new GUID not conflicting with Desktop Framework.

resolution in both cases was removing ComVisible

Some points in the PR description outline different options, obviously only one of them was taken:

Remove ComVisible(true) from some non-public code. The only potential consumer would be the new VS designer, but without a GUID specified its unlikely that its still needed. Can provide a GUID if required.

IWin32Window had a conflict with Desktop Framework which has dangerous consequences, see discussion in issue. Resolution can be either removing ComVisible(true) if not required ore generating a new GUID not conflicting with Desktop Framework.

resolution in both cases was removing ComVisible

Updated, thank you

Updated, thank you


add Flask logo

Hi, the logo is only black, is there any option for dark/light mode? It can be added as follows 🙂:
{
  "title": "Title",
  "category": "Category",
  "route": {
    "light": "/library/your_logo_light.svg",
    "dark": "/library/your_logo_dark.svg"
  },
  "url": "Website"
}

Thanks 🚀


Spanner: CMEK samples

Description

create database
create backup
restore database

Fixes #783
Checklist

[ ] Tests pass
[x] Lint pass: bundle exec rubocop
[x] Please merge this PR for me once it is approved.

@jiren, the Ruby client library was released with CMEK support so if you could update this PR then I think the tests will now pass.

@jiren, the Ruby client library was released with CMEK support so if you could update this PR then I think the tests will now pass.

updated spanner gem.

GOOGLE_CLOUD_SPANNER_TEST_INSTANCE and/or GOOGLE_CLOUD_SPANNER_PROJECT env variable not exported, look like issue with Kokoro config.

@dazuma  Could we get some help debugging these test failures? I think they have been failing for some time.

For Ruby 2.5 and Ruby 2.6, I'm pretty sure the Spanner tests don't run intentionally. But there is this failure:
+ bundle exec rubocop
Inspecting 516 files
.......................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................C............

Offenses:

spanner/spanner_samples.rb:132:47: C: Layout/AlignHash: Align the elements of a hash literal if they span more than one line.
  job = instance.create_database database_id, statements: [ ...
                                              ^^^^^^^^^^^^^
spanner/spanner_samples.rb:147:3: C: Layout/AlignHash: Align the elements of a hash literal if they span more than one line.
  encryption_config: { kms_key_name: kms_key_name }
  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
spanner/spanner_samples.rb:1756:5: C: Layout/AlignHash: Align the elements of a hash literal if they span more than one line.
    kms_key_name: kms_key_name
    ^^^^^^^^^^^^^^^^^^^^^^^^^^
spanner/spanner_samples.rb:1812:5: C: Layout/AlignHash: Align the elements of a hash literal if they span more than one line.
    kms_key_name: kms_key_name
    ^^^^^^^^^^^^^^^^^^^^^^^^^^

516 files inspected, 4 offenses detected

@jiren can you please fix it?
For Ruby 2.7, it fails because the project doesn't have permissions to encrypt/decrypt. I asked @dazuma offline to give the necessary permissions.

For Ruby 2.5 and Ruby 2.6, I'm pretty sure the Spanner tests don't run intentionally. But there is this failure:
+ bundle exec rubocop
Inspecting 516 files
.......................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................C............

Offenses:

spanner/spanner_samples.rb:132:47: C: Layout/AlignHash: Align the elements of a hash literal if they span more than one line.
  job = instance.create_database database_id, statements: [ ...
                                              ^^^^^^^^^^^^^
spanner/spanner_samples.rb:147:3: C: Layout/AlignHash: Align the elements of a hash literal if they span more than one line.
  encryption_config: { kms_key_name: kms_key_name }
  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
spanner/spanner_samples.rb:1756:5: C: Layout/AlignHash: Align the elements of a hash literal if they span more than one line.
    kms_key_name: kms_key_name
    ^^^^^^^^^^^^^^^^^^^^^^^^^^
spanner/spanner_samples.rb:1812:5: C: Layout/AlignHash: Align the elements of a hash literal if they span more than one line.
    kms_key_name: kms_key_name
    ^^^^^^^^^^^^^^^^^^^^^^^^^^

516 files inspected, 4 offenses detected

@jiren can you please fix it?
For Ruby 2.7, it fails because the project doesn't have permissions to encrypt/decrypt. I asked @dazuma offline to give the necessary permissions.

Done

Thanks @jiren, the 2.5 and 2.6 builds pass now :)

Phew! The tests have the right permissions now. One more error though:
Google::Cloud::FailedPreconditionError:
  9:KMS key provided can not protect the Spanner resource: Incompatible CryptoKey location. Resource location: us-east1, Key location: us-central1.. debug_error_string:{"created":"@1617839743.454502325","description":"Error received from peer ipv4:<IP_ADDRESS>:443","file":"src/core/lib/surface/call.cc","file_line":1067,"grpc_message":"KMS key provided can not protect the Spanner resource: Incompatible CryptoKey location. Resource location: us-east1, Key location: us-central1.","grpc_status":9}

@jiren the key and the instance need to be in the same region. If you can look into configuring the tests to reflect this, that would be great.

@skuruppu @thiagotnunes  Still facing KMS permission issue.

@jiren Can you please update the status of this PR? It is still a Draft, not an open PR.

@jiren Can you please update the status of this PR? It is still a Draft, not an open PR.

done

The tests are still failing because the KMS key is in a different location from the instance.
The instance is in us-central but the KMS key is currently being created in us-east. Please update the key to use the correct location.

The tests are still failing because the KMS key is in a different location from the instance.
The instance is in us-central but the KMS key is currently being created in us-east. Please update the key to use the correct location.

@larkee before kms zone was us-central-1 but it was not working.
Ref: https://github.com/GoogleCloudPlatform/ruby-docs-samples/pull/784/commits/74ff7a2a8d9a4da0640ab5b843536a11c044098f

The tests are still failing because the KMS key is in a different location from the instance.
The instance is in us-central but the KMS key is currently being created in us-east. Please update the key to use the correct location.

@larkee before kms zone was us-central-1 but it was not working.
Ref: 74ff7a2

Ahhh, try us-central1.
That's what Python uses: see here

The tests are still failing because the KMS key is in a different location from the instance.
The instance is in us-central but the KMS key is currently being created in us-east. Please update the key to use the correct location.

@larkee before kms zone was us-central-1 but it was not working.
Ref: 74ff7a2

Ahhh, try us-central1.
That's what Python uses: see here

Tried us-central1 and failed with the permission issue.  This issue because of GOOGLE_CLOUD_SPANNER_TEST_INSTANCE  instance is in 'us-east1' and test KMS key in us-central1. This will be fixed only if KMS key created in us-east1 or move spanner test instance us-central1 https://github.com/GoogleCloudPlatform/ruby-docs-samples/blob/da658aeadb439ce1f6286b57c9e3e0dcc76816d9/spanner/spec/spec_helper.rb#L25

@larkee @skuruppu tests are still failing due to KMS permission issue.


add tls1.3 cipher suites

This adds TLS 1.3 cipher names to our ciphers list so that we are able to set them in our components. This aligns with the work that's being done for the TLSSecurityProfiles (https://github.com/openshift/api/pull/458) where each of the profiles already contains these cipher suites.

/approve

/lgtm
/hold
holding for proof PRs in openshift/orign and openshift/openshfit-apiserver

/hold
Aside from our validation here, kube has its own for the cipher suites, which does not allow these ciphers to be set. It's a good thing we checked.

I've modified the logic a bit so that it matches more the behavior of golang, we'll still need to see whether setting TLS version to 1.3 does not break {kube,openshift}-apiserver I think

@deads2k @sanchezl please have a look, I don't think this should be breaking either apiservers now, kube seem to allow TLS1.3 as minVersion too - https://github.com/kubernetes/kubernetes/blob/master/staging/src/k8s.io/component-base/cli/flag/ciphersuites_flag.go#L80

/lgtm

/hold cancel
This PR no longer breaks origin/OAS


codegen: rhai_fn test improvements and name restrictions

This fixes some functional tests that I'm surprised still worked after the export_fn changes @schungx made, and also implements three new restrictions on rhai_fn(name = "..."):

A rhai_fn name cannot contain the character .. I presume this is true of Rhai in general, since . is used for attribute reading such as x.y, so I decided to use this property to implement the other two checks.
A rhai_fn name cannot conflict with another rhai_fn name in the same module. The code checks for uniqueness in the Rhai engine: the function name and all parameter types, but not the return type.
A rhai_fn name cannot conflict with an existing Rust function which is not renamed. In this case, the conflict checks names only. This is to avoid Rust compiler errors in the generated module code, which would make the macro panic! later.

The third one might be more restrictive than necessary, but I have not fully investigated all the effects of the new rename behavior.

Whoops! I didn't review the result of one of the rebases I did. Let me fix one thing quick before merge.

Now the duplicate name test actually tests something useful!
Ready for merge.

Getting better and better every day!
The standard library keeps getting more streamlined and simplified.  For these I won't open PR's.  I'll just push them directly into plugins.
Now, only missing treatment of feature flags in modules.  Then they get even simpler.

The standard library keeps getting more streamlined and simplified. For these I won't open PR's. I'll just push them directly into plugins.

I would ask you to draw the line in a slightly different place. I will put a comment on #3.

Ah.  OK.  So:

I'll open PR whenever something touches on macros or codegen.  Even for tests or standard library.

Merge directly if it is general bug fixes in other parts.


Questions about accuracy

Hello, I now want to generate a 1536*1536 DRR image, but it is too big and will cause insufficient memory. In addition to using the blocking method, I see that your code divides the size by subsample and multiplies the resolution. I also tried subsample and found that the effect is quite good. However, I am worried that multiplying the resolution by subsample will affect the accuracy of subsequent registration? I would be happy if you could answer!

Hi @khh656 , you have to multiply the resolution by the subsampling factor. Otherwise, your new detector plane will be smaller than the original.
For example, imagine your original detector plane is 100 x 100 pixels with isotropic 1 mm / pixel spacings (i.e., the resolution).
You can subsample this detector plane and instead render a 20 x 20 pixel DRR. However, if you don't also scale the resolution by the subsampling factor (i.e., maintain 1 mm / pixel spacing), this 20 x 20 image will be within the original image. In this case, it would simply be a 20 x 20 center crop of the original 100 x 100 DRR.
If instead you multiply the resolution by the subsampling factor (e.g., render a 20 x 20 pixel DRR with 5 mm / pixel spacings), the subsampled detector plane will be the same size as the original. Therefore, you will get a downsampled version of the DRR.
The only tradeoff here is that the more you downsample the DRR dimensions, the more aliased it will become. Going from 1536 x 1536 -> 256 x 256 doesn't produce very noticeable aliasing artifacts, but if you go smaller than that, the artifacts will become very apparent.

Yes, if I go from 1536 x 1536 -> 256 x 256, it is equivalent to multiplying the resolution by 6. Will the subsequent fine registration affect the registration accuracy compared to the original resolution?

That's a good question! Not something I've tried before. I would hypothesize that the lower your resolution, the worse the registration accuracy. Higher resolutions would give you more detail, at the tradeoff of slower registration. This is related to the idea of coarse-to-fine registration. This is something that would be very interesting to measure quantitatively.


Using dynamic sections on other templates

Is there anyway to use the dynamic sections functionality from the homepage on other page templates? Or are there plans to add this functionality?
It seems slightly odd that this awesome functionality is only available on the homepage.
If not, are there any ways of making sections unique so schema content is not duplicated throughout multiple pages?
Apologies if this has been answered previously or not relevant here, I couldn't seem to find any information amongst the issues.

You can currently only use dynamic sections on the homepage. You could use global settings if you don't want them repeated for every section?

Hey @t-kelly, thanks for clarifying the dynamic sections.
I don't think I explained the unique sections well enough. At the moment I can't see a way of using a section with editable content multiple times on the site.
For instance, if I create a section called banner like so:
{% schema %}
  {
    "name": "Banner",
    "settings": [
      {
        "type": "image_picker",
        "id": "image",
        "label": "Banner Image"
      }
    ],
    "presets": [{
      "name": "Banner",
      "category": "Global"
    }]
  }

If I use this section on a collection template for instance, select and image for the banner using the image picker, everything works fine.
It's only when I then try to use this banner on a different template, the uploaded image is already in the section. If I change the image on this different template, the collection template will change too.
The only way I can see getting round this is creating the same section for different templates. But this seems like a very unneccessary duplication of code.

+1

The only way I can see getting round this is creating the same section for different templates.

@jordanmoon That would be the way to do it. As @t-kelly said, dynamic sections are only available on the homepage.  That's the limitation of the current editor; which is outside the scope of this project.

That's a bad case when we have the same module and want to reuse them on the homepage and About pages.

+1

Locking this thread because as @NathanPJF said:

dynamic sections are only available on the homepage. That's the limitation of the current editor; which is outside the scope of this project.

Shopify is aware of this limitation and any change to improve it would take place on the Shopify platform, not Slate.


Pool latency histograms for sessions to avoid GC hit

Instance of LongHistogram in LatencyMetricsEntry needs a Return as well to return the shared ArrayPool?

Instance of LongHistogram in LatencyMetricsEntry needs a Return as well to return the shared ArrayPool?

Added.


[WFLY-12298] Implement RESTEasy configuration parameters in Wildfly

Thanks for submitting your Pull Request!
Please make sure your PR meets the following requirements:

[ ] Pull Request title is properly formatted: [WFLY-XYZ] Subject or WFLY-XYZ Subject
[ ] Pull Request contains link to the JIRA issue(s)
[ ] Pull Request contains description of the issue(s)
[ ] Pull Request does not include fixes for issues other than the main ticket
[ ] Attached commits represent units of work and are properly formatted

For bigger changes, major and minor component upgrades make sure your PR also meets following requirements:

[ ] Pull Request requires a change to the documentation
[ ] Documentation have been updated accordingly
[ ] Tests were added to cover changes

For new features ensure as well:

[ ] Analysis was done
[ ] Test Plan has been done
[ ] Tests were verified in advance

If you are not an active contributor of the WildFly project you can request sponsorship by one of the members to help guide you through the process.
Pull request for https://issues.redhat.com/browse/WFLY-12779
New pull request to replace https://github.com/wildfly/wildfly/pull/12835

Further discussion about this issue, WFLY-12298, can be found on https://github.com/wildfly/wildfly/pull/12835.

@ronsigal I am getting a bit confused about the need for this new PR :) I think you can just rebase your original on upstream/master and force push?
Re the EJB test failures, it might due to the fact that testsuite/integration/basic/pom.xml has two main surefire executions:

basic-integration-default-full.surefire - uses standalone-full.xml
basic-integration-default-web.surefire - uses standalone.xml

My bet is that your ResteasyAttributeTestCase gets run in the standalone.xml one, which AFAICR does not have EJB, so perhaps that is it.
Next I see a 'layers.profile' in the same pom, which is activated with -Dts.layers. It seems to have 'cloud-profile-layers.surefire' execution which tests against a Galleon slimmed server. This already excludes a lot of tests relying on EJB, so if the above theory is correct you should exclude this test from there too.
I will close this PR so we can continue discussion on the other one. If it is not possible to get the other PR in the same shape as this one, feel free to reopen this one (or ask me if you don't have permissions).


Local reader delegate keeps stale ID

Bug Report

What version of TiKV are you using?
Nightly 95951d04e6e8c0bb267c6a5591fb336ed5483b41
Steps to reproduce
Deploy a cluster with at least four TiKV nodes and enable shuffle scheduling.
Kill a node randomly and check if all tables can be accessed and then restart it.
What did you expect?
The operation can be repeated infinitely.
What did happened?
TiDB keeps failing with error region unavailable.
The detail error is "mismatch peer id 4519007 != 4513038". From the code we can see that 4513038 is the delegate id.
https://github.com/tikv/tikv/blob/d9405c71878f70a315ee7550764ccfcaf324d0ef/components/raftstore/src/store/util.rs#L334-L345
And from the TiKV log, 4513038 is removed and then 4519007 is readded on the same node. So there should be bugs that delegate ID is not updated correctly.

From logs, 4513038 has applied snapshot twice. It's possible that after first snapshot, read delegate is initialized and saved into local readers. The second snapshot creates a new read delegate and replace the first one directly without any notification. If there is no read requests until configuration changes, local readers have no chance to detect the delegate is stale, hence no chance to clean it up.
[2021/01/17 11:00:24.423 +08:00] [INFO] [raft_log.rs:531] ["log [committed=0, persisted=0, applied=0, unstable.offset=1, unstable.entries.len()=0] starts to r
estore snapshot [index: 3635738, term: 5114]"] [snapshot_term=5114] [snapshot_index=3635738] [log="committed=0, persisted=0, applied=0, unstable.offset=1, uns
table.entries.len()=0"] [raft_id=4513038] [region_id=596]
[2021/01/17 11:01:42.787 +08:00] [INFO] [raft_log.rs:531] ["log [committed=3635776, persisted=3635776, applied=3635776, unstable.offset=3635777, unstable.entries.len()=0] starts to restore snapshot [index: 3635990, term: 5115]"] [snapshot_term=5115] [snapshot_index=3635990] [log="committed=3635776, persisted=3635776, applied=3635776, unstable.offset=3635777, unstable.entries.len()=0"] [raft_id=4513038] [region_id=596]

From logs, 4513038 has applied snapshot twice. It's possible that after first snapshot, read delegate is initialized and saved into local readers. The second snapshot creates a new read delegate and replace the first one directly without any notification. If there is no read requests until configuration changes, local readers have no chance to detect the delegate is stale, hence no chance to clean it up.
[2021/01/17 11:00:24.423 +08:00] [INFO] [raft_log.rs:531] ["log [committed=0, persisted=0, applied=0, unstable.offset=1, unstable.entries.len()=0] starts to r
estore snapshot [index: 3635738, term: 5114]"] [snapshot_term=5114] [snapshot_index=3635738] [log="committed=0, persisted=0, applied=0, unstable.offset=1, uns
table.entries.len()=0"] [raft_id=4513038] [region_id=596]
[2021/01/17 11:01:42.787 +08:00] [INFO] [raft_log.rs:531] ["log [committed=3635776, persisted=3635776, applied=3635776, unstable.offset=3635777, unstable.entries.len()=0] starts to restore snapshot [index: 3635990, term: 5115]"] [snapshot_term=5115] [snapshot_index=3635990] [log="committed=3635776, persisted=3635776, applied=3635776, unstable.offset=3635777, unstable.entries.len()=0"] [raft_id=4513038] [region_id=596]


Don't show a pagination when there is only one page

👍

@voronkovich I love this attention to detail. Thanks!


update newsletter button/size

the socials were removed from this section because the footer has them and are very close to each other.

should be centered


rebase on bitcoin-core/secp256k1

Hi
I would have done a PR, but I was not sure how you handle rebasing.
Anyway, it would be great to rebase this on upstream. I am particularly interested in pulling in this change: https://github.com/bitcoin-core/secp256k1/pull/337, so I can skip some custom commits on my fork of libwally-core.

The last rebase has been 6 months  ago, so yes we can do this if it's helpful for you. I can't promise you a date though.
We typically we go with at least two people in parallel through the process and check that we arrive at the same code at a few checkpoints on the way. So yes, no need to open a PR, we'll handle it.

Ah, didn't realize it was so involved. In this case, thanks! No need to rush, I can continue with manual patching for a while.

We should also warn the Trezor people and find a minimally disruptive way to do things, this time. (Maybe it is sufficient to just rename the old branch and then they need to change nothing? I don't know.)

I think we settled on renaming the old branch to secp256k1-zkp-YYYY-MM-DD, see your comment here: https://github.com/ElementsProject/secp256k1-zkp/issues/68#issuecomment-498351737

Hello again. Are there any plans to rebase? There have been a bunch of interesting but also invasive PRs which makes it harder to rebase custom patches on both secp256k1 repos (upstream and this one):
https://github.com/bitcoin-core/secp256k1/pull/708
https://github.com/bitcoin-core/secp256k1/pull/709
https://github.com/bitcoin-core/secp256k1/pull/710
Would be great to update this repo again. I am guessing that more frequent rebasing is also less effort overall.
Happy to help if I can be of assistance, let me know.

Good points, we should think about this now. On the other hand, there will hopefully be a secp256k1 release soon, so maybe it's better to wait? No idea at the moment, we should discuss this.
Independently of this, I suggested a while ago to move some code here around. The goal is not to touch any upstream in our fork here (except maybe build system files). This is realistic because we only add features to upstream but don't change then. This will make rebasing a little bit easier.

On the other hand, there will hopefully be a secp256k1 release soon

What do you mean? The secp256k1 repo doesn't have releases nor tags.

Independently of this, I suggested a while ago to move some code here around.

Sounds good. Whatever is fastest :)

Fixed by #91


Remove the thread sleep from HttpClient

is not in Master.
Only on PR #256 ,

It was never commited to mastet


procedure for a new release

procedure for making a new release:

update the version number in

setup.py
CMakeLists.txt

update CHANGELOG.md
update dependencies (if there are new tagged releases of them available)

https://github.com/spatial-model-editor/spatial-model-editor/blob/756ab0baf8dbe10c8b8e7c6627bef9f760edb043/ci/getlibs.sh#L6
https://github.com/spatial-model-editor/spatial-model-editor/blob/756ab0baf8dbe10c8b8e7c6627bef9f760edb043/.github/workflows/wheels.yml#L30-L31

make a PR
download & check the the spatial-model-editor build artefacts work
merge the PR

Then tag this commit on the main branch & push the tag to do the actual (pypi+github) release:
git tag x.y.z
git push origin x.y.z

Finally copy&paste the relevant part from the CHANGELOG.md to the release description on github.

Additional steps now required for arm64 builds (after completing above):

if needed update https://github.com/ssciwr/sme-deps-osx-arm64 & tag to release new version of deps
update https://github.com/ssciwr/sme-osx-arm64/ with tag for sme version & deps above if changed
tag with same version number to build & publish arm64 binaries and wheels


Reply

Ao utilizar o comando de reply, o rocket encaminha um link ao invés da mensagem original.

Fixed on latest release. As this is the first Issue, you will get a free beer at out next Rocket Connect Summit :P


Add DEFROUTE options in NIC role

Assume that we have four network cards, with multiple network, we have provided IP,subnet and gateway in all network card. Now system uses all cards to reach the destination.
When you put "DEFROUTE=yes" on one card then system always use card one on priority to reach every destination.
more roles/core/nic/templates/ifcfg.j2
{%if item.defroute is defined and item.defroute == true %}
DEFROUTE=yes
{% else %}
DEFROUTE=no
{% endif %}

Example inventory
[...]
    equipment_metrics:
      hosts:
        hendrixmetrics:
          bmc:
            name: hendrixmetrics-bmc
            ip4: <IP_ADDRESS>
            mac: xx:xx:xx:xx:xx:xx:xx
            network: mn1-1
          network_interfaces:
            - interface: eno1
              ip4: <IP_ADDRESS>
              mac: xx:xx:xx:xx:xx:xx:xx
              network: mn1-1
              defroute: true
            - interface: bond0
              type: bond
              bond_options: "mode=4 xmit_hash_policy=layer3+4 miimon=100 lacp_rate=1"
              ip4: <IP_ADDRESS>
              network: ic1-1
            - interface: enp1s0
              type: bond-slave
              master: bond0
            - interface: enp129s0
              type: bond-slave
              master: bond0
[...]

Dear @SckyzO
NIC role is to be discontinuated. Please see this PR for new NIC role, now based on NMCLI module:
https://github.com/bluebanquise/bluebanquise/pull/504/files
Would that answer your need ?

Dear @SckyzO
A small ping, if no answers, I will need to close this issue 🙂

Dear @SckyzO
A small ping, if no answers, I will need to close this issue 🙂

You can close it is ok thx

You can close it is ok thx

Thanks a lot !
Have a nice end of week 😉

Thanks a lot !
Have a nice end of week 😉


Travis junit reporting site (trends, etc)

Travis only has very limited (success-failure) reporting of builds. It would be great to have a dashboard style output (like Jenkins has).
There is a issue on travis with some discussions on how to best do this: https://github.com/travis-ci/travis-ci/issues/6224, probably involving S3, gh-pages, etc.
If we get his to work for Xenon we can re-use it as well for other projects, e.g. https://github.com/NLeSC/xenon-cwl-runner and OpenDA.

Seems SonarQube (https://sonarqube.com/) is now also free for OpenSource projects and integrates with Github and includes tests results
For example see the failed tests at https://sonarqube.com/component_measures/?id=com.thoughtworks.xstream%3Axstream-parent

Fixed now we are using sonarcloud


Teams alert is not showing as expected

Describe the bug
I have integrated teams alerting system but the alert that I am getting is not as expected.
I am not getting the proper icon in the alert.
What do you see?

as you can see in this image icon is not getting resolved, I am getting some value "&#x1F6A8"
What do you expect to see?

I want to see like this, the proper icon
List the steps that must be taken to reproduce this issue
configure teams alerting system
Version
latest
Additional information
@TwiN pls look into this bug

I see the same.

I've also experienced this problem, it started when I updated teams a few weeks ago 😞
I'm not using the "Try the new Teams" feature although the same issue exists when I turn it on

I think color code needs to be changed (https://github.com/TwiN/gatus/blob/de7256e671c3cc6106a154a8fd49df426f4ce56a/alerting/provider/teams/teams.go#L108), not sure

I don't know what side is wrong on this since other similar tools also got broken notifications...
This topic was recently reported at Microsoft at https://techcommunity.microsoft.com/t5/microsoft-teams/new-teams-unicode-hex-character-and-emoji/m-p/3963936
google also show up earlier similar issues...
Both flavours of Teams (traditional and "new") are affected according to my experience.

To be completely honest, that seems more like an issue with Microsoft Teams than with Gatus, however, it's an issue nonetheless.
If allowing the customization of the title in the message generated by the webhook payload sent by Gatus resolves the situation, then I'd be willing to add a new alerting.teams.title field.
There's already a precedent for this anyways: see #602, which was made for Discord's title to be customizable.

@TwiN sounds like a new feature. thanks

To be completely honest, that seems more like an issue with Microsoft Teams than with Gatus, however, it's an issue nonetheless.
If allowing the customization of the title in the message generated by the webhook payload sent by Gatus resolves the situation, then I'd be willing to add a new alerting.teams.title field.
There's already a precedent for this anyways: see #602, which was made for Discord's title to be customizable.

The issue is limited to the Microsoft Teams classic desktop client.
Gatus alert cards are rendered correctly on my phone Teams App and on the web client via Office 365.


Getting: Property 'UUID' not found on object of type 'CBPeripheral'

Hi guys!
I'm getting the error message:

Property 'UUID' not found on object of type 'CBPeripheral

in file: CBPeripheral+UniqueId.m
I'm compiling in XCode 7 Beta2.
As mentioned by somebody else here: https://forums.developer.apple.com/thread/5941
This property is deprecated.
Please help! Thank you very much!
BaloMueller

Any progress on this? I'm now getting the same error and another similar on: property 'isConnected' not found on object of type 'CBPeripheral *'

I was able to fix this by changing the reference to 'self.UUID' to 'self.identifier' and 'self.isConnected' to '(self.state==CBPeripheralStateConnected)'

Whoo! managed to figure out the first one but just working on the second. Much thanks!

In CBPeripheral+isConnected_Universal.m change 2 instances of 'return self.isConnected;' to 'return (self.state==CBPeripheralStateConnected);'

@paulw11, @iColpitts, does this PR work for you guys?
https://github.com/PunchThrough/Bean-iOS-OSX-SDK/pull/14/files

@raykamp, I'm using Cocoapods but I don't seem to be getting the iOS 9 update.  I'm not sure what I'm doing wrong, any thoughts?
I've posted the question on Stackoverflow: http://stackoverflow.com/q/33049446/3029577

@daniel-frohardt: Can you post the line in your Podfile that specifies the Bean SDK?
Try setting the version to 0.10.0:
pod 'Bean-iOS-OSX-SDK'

Or try running pod update to update your Podfile dependencies. (pod install simply installs the versions that were last installed without checking for any updates.)
Closing this issue as it should be resolved on master, but please feel free to comment if you still have issues.

Running 'pod update' did the trick, thank you very much!


Random Name Generator

Is your extension request related to a problem? Please describe.
I want to add Random Name Generator extension which will generate Random Names for the users
Describe the solution you'd like.
I will use HTML,CSS,JS to implement this.
Describe alternatives you've considered.
NA

@harshita214 please assign