Moving palaces not supported

Must add functionality for the mountain tile after finishing the palace.

Offset is now calculated and written to rom for palaces 1-5. Palace 6 handled in separate issue.


Increase of Field Length No. in Table "Item Attribute Value Mapping"

Hi,
is there any possibility that the field length of "No." will become 40 instead of 20 in the table "Item Attribute Value Mapping" (other suggestion would be adding a new "guid" field and use it in the key, too). This would be very helpful for anyone who would like to extend this table - for example if you want to use this table for "Item Variants", too.
My idea was to extend "Item Variant" with a "Guid" field and then use this value on "Item Attribute Value Mapping" in the field "No." to allow creation of Attributes for Item Variants, too (not only for Item and Item Category).
Thanks for your answers,
best regards,
Gerald

No, this is currently not possible, this is breaking change.

Okay, thx at least for your answer.
regards
Gerald


Arcgis send conversions

Description & motivation

Changes:

To-do before merge:

Screenshots:

Validation of changes:

Checklist:

[ ] My pull request follows the guidelines in the Contributing guide?
[ ] My pull request does not duplicate any other open Pull Requests for the same update/change?
[ ] My commits are related to the pull request and do not amend unrelated code or documentation.
[ ] My code follows a similar style to existing code.
[ ] I have added appropriate tests.
[ ] I have updated or added relevant documentation.

References

Main changes:

Send Conversions for Point, Polyline, Polygon and Multipatch Vector layers; Standalone tables; Rasters; Pointclouds
QueuedTask moved to overall layer conversion, top level. So it doesn't need to be called for every small operation
better way of getting layer Field values
injecting GeometryUtils interface
edit some class definitions: make properties non-nullable and add constructors


Can I set grep within codecept.conf.js?

What are you trying to achieve?
I want to set grep within codecept.conf.js so that I can pass its value from an process environment variable. The reason why I want to do it through the config is because I am trying to pass it to the docker-compose file via the environment: section.
The only way I found grep within codecept.conf.js file is under the "multiple" section, which I am not using at the moment.

Nope, but you are right this is must-have feature.


(nucleus): apt error got ignored

Describe the bug
If I deploy a component which will run apt update or apt install $PACKAGE_NAME with root privilege, sometimes the apt error will show in greengrass log
2021-07-14T16:00:10.422Z [WARN] (Copier) component-name: stderr. E: Could not get lock /var/lib/dpkg/lock-frontend - open (11: Resource temporarily unavailable). {scriptName=services.burro-configurator.lifecycle.Bootstrap.Script, serviceName=burro-configurator, currentState=NEW}
2021-07-14T16:00:10.422Z [WARN] (Copier) component-name: stderr. E: Unable to acquire the dpkg frontend lock (/var/lib/dpkg/lock-frontend), is another process using it?. {scriptName=services.burro-configurator.lifecycle.Bootstrap.Script, serviceName=burro-configurator, currentState=NEW}

And the deployment will stop here, but the deployment status will show completed in the end which I expected the non-zero status code should be caught and present as Failed
To Reproduce
Steps to reproduce the behavior. If possible, provide a minimal amount of code that causes the bug.

Create a component with sudo apt update or sudo apt install $PACKAGE_NAME
Run sudo apt update locally and deploy the component you created in the first step.
Sometimes you will see it got blocked but the deployment status will show completed

Expected behavior
I expect APT error will get caught and present as Faileddeployment status.
Actual behavior
It will ignore the APT error and show Completed no matter the apt command successful executed or not.
Environment

OS: [e.g. Ubuntu 18.04]
JDK version: Java 8
Nucleus version: 2.4

Additional context
What kind of error will be ignore by nucleus? (This apt error might be ignored by default, so I kinda want to know more about this)
If some errors aren't presented as Failed on deployment status by default, then I will not be able to manage the correctness of deployment status. But at least, I can prepare something for it if I already know some info.

Hi,
Greengrass relies on the POSIX exit code of the command. The exit code is logged in the component log file, so you should see that in addition to the error logs.
If the exit code is not zero then it is an error. For bootstrap, exit code 100 and 101 are also acceptable but have special meanings.
What is the exit code of your bootstrap step?

It was 100. May I force bootstrap to make all non-zero exit code be Failed. Also what are the meanings of 100 and 101 to bootstrap?

Why was it 100? What is the full bootstrap script that you wrote?

Generally, the bootstrap script is /bin/bash test.bash and the code inside the test.bash is sudo apt update.
Sometimes, another process was using the apt install so the other process trying to use apt command will be blocked.
The exit code of apt update fail will be 100 so I am not sure why nucleus intentionally ignore this error code.
Example:
root@HOSTNAME:~# apt update
Reading package lists... Done
E: Could not get lock /var/lib/apt/lists/lock - open (11: Resource temporarily unavailable)
E: Unable to lock directory /var/lib/apt/lists/
root@burro-7-771:~# echo $?
100

In the bootstrap script and only the bootstrap script, Greengrass assigns special meaning to exit code 100 and 101.
I can suggest to you two things. 1) Do not use the bootstrap script unless you have a reason to use it. The reasons to use it are either if you want to restart the device or restart the Greengrass Nucleus. To signal either of these situations you would use those special exit codes (100 to restart Greengrass, 101 to restart the device). See the Greengrass recipe documentation for more information. 2) Translate the exit code from APT in your script; if it exits 100 or 101 then your script must exit with a different code. You can of course print the real exit code into the logs like echo $?.

Thanks Mike. I might need to handle these error codes myself for now. And I have some questions. What's the most use cases when people using greengrass? Do most of the people use nucleus to configure devices? or in your opinion, is there a better AWS tool to configure 100+ devices ( like apt package, software and firmware update all together).

If you're just trying to manage a fleet of devices then Greengrass isn't really the solution for you. The better solution would be AWS Systems Manager.
https://docs.aws.amazon.com/systems-manager/latest/userguide/what-is-systems-manager.html

Thank you so much Mike, I won't consider this as an issue. It's an error from user's use case. Feel free to close this thread.

Will do, good luck with your work on this.


2 issues

first: Add a way to see which discord server i've selected, or just add   back
second: add some kind of border or change the color of the roles menu so it doesn't blend in with the background so much

Fixed.


'sunrgbd_infos_train_v0_fs_plus.pkl'

How to generate a 'sunrgbd_infos_train_v0_fs_plus.pkl' file, I want to use other dataset, I want to refer to the generation and writing of your pkl file.

Hi, you could leave your email here first. I'll send you the code files after refactoring them. Thanks.

<EMAIL_ADDRESS>Thanks!


Update navbar for prod

The navigation bar for production is deprecated.
Replace with a version that automatically considers the newest version in the repostitory.

Fixed with https://github.com/google/vulncode-db/commit/f77c2c562c7de7bb58dfc8be49d31137e38a3ac3.


[3.4] Feature/arangosearch pk endianness (#7306)

refactor arangosearch pks

minor refactoring

store PK as BigEndian since it leads to more compact index representation

force iresearch to not to use libbfd

fix tests

Please note that for legal reasons we require you to sign the
Contributor Agreement
before we can accept your pull requests.

http://jenkins01.arangodb.biz:8080/view/PR/job/arangodb-matrix-pr/2023/


python312Packages.mdformat: 0.7.17 -> 0.7.18

Diff: https://github.com/executablebooks/mdformat/compare/refs/tags/0.7.17...0.7.18
Changelog: https://github.com/executablebooks/mdformat/blob/0.7.18/docs/users/changelog.md

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Result of nixpkgs-review pr 348809 run on x86_64-linux 1

55 packages built:

mdformat
nbqa
nbqa.dist
python311Packages.mdformat
python311Packages.mdformat-admon
python311Packages.mdformat-admon.dist
python311Packages.mdformat-beautysh
python311Packages.mdformat-beautysh.dist
python311Packages.mdformat-footnote
python311Packages.mdformat-footnote.dist
python311Packages.mdformat-frontmatter
python311Packages.mdformat-frontmatter.dist
python311Packages.mdformat-gfm
python311Packages.mdformat-gfm-alerts
python311Packages.mdformat-gfm-alerts.dist
python311Packages.mdformat-gfm.dist
python311Packages.mdformat-mkdocs
python311Packages.mdformat-mkdocs.dist
python311Packages.mdformat-nix-alejandra
python311Packages.mdformat-nix-alejandra.dist
python311Packages.mdformat-simple-breaks
python311Packages.mdformat-simple-breaks.dist
python311Packages.mdformat-tables
python311Packages.mdformat-tables.dist
python311Packages.mdformat-toc
python311Packages.mdformat-toc.dist
python311Packages.mdformat.dist
python311Packages.mypy-boto3-builder
python311Packages.mypy-boto3-builder.dist
python312Packages.mdformat
python312Packages.mdformat-admon
python312Packages.mdformat-admon.dist
python312Packages.mdformat-beautysh
python312Packages.mdformat-beautysh.dist
python312Packages.mdformat-footnote
python312Packages.mdformat-footnote.dist
python312Packages.mdformat-frontmatter
python312Packages.mdformat-frontmatter.dist
python312Packages.mdformat-gfm
python312Packages.mdformat-gfm-alerts
python312Packages.mdformat-gfm-alerts.dist
python312Packages.mdformat-gfm.dist
python312Packages.mdformat-mkdocs
python312Packages.mdformat-mkdocs.dist
python312Packages.mdformat-nix-alejandra
python312Packages.mdformat-nix-alejandra.dist
python312Packages.mdformat-simple-breaks
python312Packages.mdformat-simple-breaks.dist
python312Packages.mdformat-tables
python312Packages.mdformat-tables.dist
python312Packages.mdformat-toc
python312Packages.mdformat-toc.dist
python312Packages.mdformat.dist
python312Packages.mypy-boto3-builder
python312Packages.mypy-boto3-builder.dist


Validate image with EC

This commit adds instructions on how to use Enterprise Contract to validate the model image. In addition to the usual signature checks, a policy rule is used to verify the dataset used comes from a permitted source.

Added both suggestions. This is great info. I'm too close to this to realize what is not obvious to others :see_no_evil:

I'm too close to this to realize what is not obvious to others 🙈

really appreciate your contributions to this demo!


Added docs on PR labels

I haven't been able to find these documented elsewhere, other than the brief descriptions in the labels themselves.

@millerdev Thanks for the link 🙂   Andrea also pointed it out, so we chatted about where this info should live and agreed I'll keep/move the label descriptions here but keep the more internal product process on the wiki. I'm going to read through and update that page and do a followup PR.


Removed explicit dependsOn

According to https://docs.microsoft.com/en-us/azure/azure-resource-manager/bicep/compare-template-syntax#resource-dependencies explicit dependencies should be avoided (as they get implicitly created by using the variable/other resource).

@sopelt : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@sopelt - thank you for the contribution.
#sign-off


Update the docs website without plugins

It also uses the --sparse option.
@yrodiere @gsmet: You might want to have a look at this. I'm publishing the docs on hibernate.org but  it's easy to change this if we want to publish somewhere else on GItHub

Thanks @yrodiere. I will apply these changes soon.

Also, just so you know, the NoORM release scripts do more than just push the documentation to a git repo;

Sure, but that happens when the documentation is rendered, isn't it?

And it's maven?
Anyway, if could link me to the additional metadata I can include them the documentation is rendered

Sure, but that happens when the documentation is rendered, isn't it?

No. There's post-processing that adds some scripts to HTML files after the fact, and there's some JSON metadata we add next to the HTML files.
Here's the code: https://github.com/hibernate/hibernate-noorm-release-scripts/blob/1b6bad3e8472edc2bab287aec39d4b6a958ab5b3/upload-documentation.sh#L33-L112
But personally, I'd rather we all used the same scripts than we start duplicating it in every project...

And it's maven?

This part of the release scripts is not specific to Maven as far as I can tell.
As to the rest of the release scripts, we can definitely consider making them work with both Maven and Gradle. It's just about adding a few if/else in the scripts.


Get tests back online

@jonathanslenders if #35 gets merged, feel free to close this

Done in #35. closing


Improve or replace CWL md5sum repo

Context
https://github.com/dockstore/dockstore/issues/4586#issuecomment-1113775819, see that entire ticket for more details
Describe the bug
https://github.com/dockstore-testing/dockstore-workflow-md5sum-unified:

Throws warnings in cwltool
Has a checker workflow which calls a workflow which itself calls a tool
Said checker workflow cannot be imported into SB as-is
Even after being modified in a way to allow SB import, said checker wf will fail in SB unless you edit with SB's rabix editor
Appears to be used in our integration tests ("dockstore-workflow-md5sum-unified" has 8 hits in the dockstore/dockstore repo)
Is used in our documentation (checksum-support.rst)
Is based on the various md5sum workflow/tools that are used all over our docs, so there is a chance those examples may also have issues ("md5sum" has 91 hits in dockstore/dockstore-documentation)

To Reproduce
Throws warnings in cwltool:

Clone the repo locally
cwltool checker_workflow_wrapping_workflow.cwl --input_file md5sum.json
See warnings about foaf towards the top of the output

Has a checker workflow which calls a workflow which itself calls a tool:
By this I mean checker_workflow_wrapping_workflow.cwl, which calls md5sum/md5sum.cwl, which calls md5sum/dockstore-tool-md5sum.cwl. It appears that checker_workflow_wrapping_tool.cwl skips the middleman.
Cannot be imported into SB as-is:

Go to https://dockstore.org/workflows/github.com/dockstore-testing/dockstore-workflow-md5sum-unified/cwl_checker:develop?tab=files
Click button to import into SB via BDC
Select a workspace to import into
Get unhelpful error
This one can be partially remedied by replacing the contents of md5sum/md5sum.cwl with md5sum/dockstore-tool-md5sum.cwl, which turns this checker workflow-->workflow-->tool import chain into checker workflow-->tool, but...

Even after being modified in a way to allow SB import, still fail in SB unless you edit them in SB's rabix editor
If you replace  the contents of md5sum/md5sum.cwl with md5sum/dockstore-tool-md5sum.cwl like mentioned above, you will be able to import into SB, but when trying to actually run the workflow, you will get a "graph not connected" error.
Expected behavior
Throws warnings in cwltool:
The CWLs we use for testing and documentation should not throw warnings.
Has a checker workflow which calls a workflow which itself calls a tool:
This is fine in and of itself, and it does work in cwltool, but...
Cannot be imported into SB as-is
...currently this workflow-->workflow-->tool chain breaks if you try to import it into SB. Our examples should be able to import cleanly into SB, even if are not showing off the import into SB in said example, as it is a common thing to do.
Even after being modified in a way to allow SB import, still fail in SB unless you edit them in SB's rabix editor
This might be a bug with Rabix, but either way, our examples should work in SB without the user needing to debug them.
Why one big ticket?

Because these are all connected and provide context for each other
Because further investigation is needed to find out what is a TRS issue, a Dockstore issue, and/or a SB issue
Because the sum total of this ticket might mean that the short term answer is to replace some of the repos we use for documentation and testing, but maybe that's not necessary if it turns out there's a simple fix
Because I don't have a lot of experience with CWL and TRS, so there's a chance my guesses on how to tackle this/what's going on might be way off base :grimacing:

If this isn't a quick issue, and assuming I'm not way off base with my guesses as to what's going on, I'd split it like this:

investigate the app import failure
investigate the node not connected issue
replace at least this md5sum stuff from docs + tests
investigate if the other md5sum stuff that dockstore-workflow-md5sum-unified is based upon are also problematic (warnings, errors, cannot be imported, node not connected)
fix the warnings r/e foaf/namespaces

┆Issue is synchronized with this Jira Story
┆fixVersions: Dockstore 1.13
┆friendlyId: DOCK-2162
┆sprint: 90
┆taskType: Story

Implementer could check if we've fallen out of date with https://www.commonwl.org/user_guide/17-metadata/index.html

https://github.com/common-workflow-library/bio-cwl-tools/pull/101 may point to a change from dct and foad to schema.org

Breaking down ticket:

Probably doesn't hurt to clean-up the dct schema, but it isn't invalid cwl. For example

$ cwltool  --validate checker_workflow_wrapping_workflow.cwl
INFO /home/dyuen/.local/bin/cwltool 3.1.20220224085855
INFO Resolved 'checker_workflow_wrapping_workflow.cwl' to 'file:///home/dyuen/dockstore-workflow-md5sum-unified/checker_workflow_wrapping_workflow.cwl'
URI prefix 'foaf' of 'foaf:name' not recognized, are you missing a $namespaces section?
URI prefix 'foaf' of 'foaf:mbox' not recognized, are you missing a $namespaces section?
URI prefix 'foaf' of 'foaf:name' not recognized, are you missing a $namespaces section?
URI prefix 'foaf' of 'foaf:mbox' not recognized, are you missing a $namespaces section?
URI prefix 'foaf' of 'foaf:name' not recognized, are you missing a $namespaces section?
URI prefix 'foaf' of 'foaf:mbox' not recognized, are you missing a $namespaces section?
URI prefix 'foaf' of 'foaf:name' not recognized, are you missing a $namespaces section?
URI prefix 'foaf' of 'foaf:mbox' not recognized, are you missing a $namespaces section?
checker_workflow_wrapping_workflow.cwl is valid CWL.

Inability to import into SBG seems like a SBG bug

Suggest implementer fix warnings, re-attempt import into SBG, open* bug either way in an appropriate SBG repo with details about what type of CWL is unable to be imported and link to here.

or find existing ticket, add comments, vote

Above suggestions implemented to the workflow repo.
Remaining work is probably to create a tag and then update the docs as needed


5.15.2 ?

As 5.15.2 is the last in the 5-series, it will be around for a while, the PyPI package is there, but this feed-stock is not updated yet ...
Someone has an ETA on this ?
@ccordoba12 : I know you are very busy with preparations for the all-new Spyder 5, but wouldn't it be a good foundation for Spyder 5 too ? I am thinking here for sure in the direction of the QScreenCast thingy, there we had some trouble with the 5.12.3 that had already a fix in 5.14.x I think, and as we gear up to re-do QScreenCast using GStreamer under the hood ...
Nice Bonus would be if pyqt==5.15.2 would also cover aarch64 (read: RPI & Co) :stuck_out_tongue_winking_eye:

Hey @nerohmot, thanks for reporting. Unfortunately. to have PyQt 5.15 we first need to compile Qt 5.15, which is a huge undertaking. Some work was already done by @mingwandroid on that front, but I don't how advanced it is.

It's causing a fire in my back burner Carlos!

Haha, I'll try to give you a hand once we release Spyder 5 in April.

Oooh, I see, simple me was thinking that if there is a PyPI package, converting it to a conda-forge package would be easier ... (for someone more knowledgeable than me). When #84 was opened (I closed it in favor of this one) there simply was no PyPI pacage and thus the work had to be "manual" ...
Anyway to be continued :wink:

Repackaging binaries from PyPI does not generally work well within the conda ecosystem. Binary compatibility is not guaranteed and we no longer depend on our own shared libraries or compiler runtimes.
Qt is just a huge amount of effort and every update gets worse as Qt gets bigger and bigger. With Qt 6 they've changed the build system from qmake to CMake and Qt 6 isn't quite ready yet (and the application ecosystem around it is far from ready). Still I have a hope that Qt 6 will be easier to build than Qt 5 is though I'm probably fooling myself somewhat! The other thing about it is that it makes the effort to update Qt 5 one that will not be useful for Qt 6.
I'd love to get back to updating Qt to the latest version. Those Windows builds are looking pretty lonely up on my anaconda.org channel!

Also, they've released 5.15.3 yesterday...

Unfortunately, the current version of pyqt is also a huge burden for users running macOS 11, as Qt guis simply won't open … unless they set the environment variable QT_MAC_WANTS_LAYER to "1".

Right now Qt 5.12 is the oldest supported Qt version for pyqtgraph, we haven't established a timeline for making Qt 5.15 the minimum supported version; but I don't think we would do it without a package being available on conda-forge.   Don't mean to add to the noise here, just trying to relay that pyqtgraph will keep our conda users in mind.

It's been a year since the last update to this ticket.  Qt 5.15.2 is in conda-forge (as qt-main) but there are not corresponding PyQt bindings so it's not usable from Python apps.  I would very much like to be able to use Qt 5.15, and am willing to get involved and help work on this.

Note, that I'm not a maintainer of PyQt but I believe that the update of PyQt is currently underway. This was blocked by QT but since that was recently finished, we should see it here as well, including support for M1 etc.
Due to the size and complexity of it not all builds are being done in the feedstock so even if nothing is happening here, someone is probably working on it.

It would be great to get Qt6 (PySide6/PyQt6) into conda-forge. You might want to check out the current status here: https://github.com/conda-forge/qt-main-feedstock/pull/14

@conda-forger, updating Qt/PyQt to 5.15 was a funded effort that took @andfoy nine months of really work to accomplish, which is really close to be finished (@BastianZim did a pretty good status update).
@cbrnr, yes, it'd be great but that really depends on the community because it won't be funded (at least not in the short term).

CC @hoechenberger

This issue can be closed since https://github.com/conda-forge/pyqt-feedstock/pull/115 has been merged a few weeks ago. 🥳

Right, closing then.


Calling a C# interface method crashes Godot immediately

Godot version
4.0 beta10
System information
MacOS Catalina
Issue description
Calling an interface method crashes Godot immediately. The game closes with no stack trace.
Steps to reproduce
Put this code on any node:
using Godot;
using System;

interface IFoo {
  public void TestMethod() {
    GD.Print("Hello");
  }
}

public partial class Test : Node2D, IFoo {
  public override void _Ready() {
    TestMethod();
  }

  public void TestMethod() {
    (this as IFoo).TestMethod();
  }
}

Minimal reproduction project
https://github.com/johnfn/CsharpGodotCrashRepro

The code in the MRP results in a stackoverflow because TestMethod calls itself. It seems your intention was for the Test.TestMethod implementation to call the default interface implementation but by implementing the method you are essentially overriding the interface method.
This is the output I get in the terminal when launching the Godot project in Linux:
Stack overflow.
Repeat 261612 times:
--------------------------------
   at Test.TestMethod()
--------------------------------
   at Test._Ready()
   at Godot.Node.InvokeGodotClassMethod(Godot.NativeInterop.godot_string_name ByRef, Godot.NativeInterop.NativeVariantPtrArgs, Godot.NativeInterop.godot_variant ByRef)
   at Godot.CanvasItem.InvokeGodotClassMethod(Godot.NativeInterop.godot_string_name ByRef, Godot.NativeInterop.NativeVariantPtrArgs, Godot.NativeInterop.godot_variant ByRef)
   at Godot.Node2D.InvokeGodotClassMethod(Godot.NativeInterop.godot_string_name ByRef, Godot.NativeInterop.NativeVariantPtrArgs, Godot.NativeInterop.godot_variant ByRef)
   at Test.InvokeGodotClassMethod(Godot.NativeInterop.godot_string_name ByRef, Godot.NativeInterop.NativeVariantPtrArgs, Godot.NativeInterop.godot_variant ByRef)
   at Godot.Bridge.CSharpInstanceBridge.Call(IntPtr, Godot.NativeInterop.godot_string_name*, Godot.NativeInterop.godot_variant**, Int32, Godot.NativeInterop.godot_variant_call_error*, Godot.NativeInterop.godot_variant*)
zsh: IOT instruction (core dumped)  godot4

I think what you are looking for is this:
public partial class Test : IFoo
{
	public void TestMethod()
	{
		base(IFoo).TestMethod();
	}
}

This feature was cut from C# 8.0 but the intention is to bring it back in a future version of the language, see https://github.com/dotnet/csharplang/blob/main/meetings/2019/LDM-2019-04-29.md#default-interface-implementations-and-base-calls.
You can follow the base(T) feature in the champion issue: https://github.com/dotnet/csharplang/issues/2337.
Since this is not a Godot issue but a limitation of the C# language I'll close this issue.

Unfortunately we don't have any control over stackoverflows, it's a special type of exception that can't really be catched.


add shutdown script to sigterm minecraft

Not sure how to apply this to all preemptible nodes.

this doesn't do much more than a prestop, and a prestop is easier to configure


FreeRDP proxy: device redirection and clipboard channels have stopped working

To Reproduce
connect to the target with via the FreeRDP proxy server.
Application details
FreeRDP proxy version: 3.0.0-dev, Git commit: 3.0.0 (master)
OS version connecting to (server side): Windows 10 21H2
Environment:
OS: Windows 10 21H1 19043.1766
Architecture: amd64
proxy config:
[Channels]
GFX = TRUE
DisplayControl = TRUE
Clipboard = TRUE
AudioOutput = TRUE
RemoteApp = TRUE
DeviceRedirection = TRUE
VideoRedirection = TRUE
CameraRedirection = TRUE
PassthroughIsBlacklist = TRUE
; a list of comma seperated static channels that will be proxied. This feature is useful,
; for example when there's a custom static channel that isn't implemented in freerdp/proxy, and is needed to be proxied when connecting through the proxy.
Passthrough =

[Clipboard]
TextOnly = FALSE
MaxTextLength = 10 # 0 for no limit.

The issue occurs when I copy text and also files using cliprdr channel.

@maordadush already fixed. As for FreeRDP proxy version: 3.0.0-dev, Git commit: 3.0.0 (master) please add some git commit otherwise the version information is not very useful.


Crm457 974 - fixes

Description of change
CRM4 Provider - Further information Bug Fixes
Addressing these comments: Comment 1, Comment 2

Update "Re-submitted" to "Resubmitted"
Update badge colour used for Submitted and Resubmitted
Fix incorrect styling for summary cards on Check Answers page

a

looks ok, but previous defaulting to an empty array for actions allows for extensibility and allows you to not supply an array as in
govuk_summary_card(title: section.title, actions: (show_actions ? section.title_action : [])) do |card|

#ufn_card

def title_action
  []
end

Yeah I've reverted those changes now but gone with keeping the method name semantics as I was confused with how the method was working

in this case I still needed to keep the logic in for the different view on this report if it's being used on a submitted claim vs a sent back claim


No link to github on page

A github link goes a long way toward helping new developers get on board - show them the site as it exists, and within a couple of clicks they're looking at the issues they can dive into.

Thanks for making this issue. What do you mean by "on page"? Do you mean on
the actual site http://phillyfoodfinder.org/?
On Wed, Oct 28, 2015 at 1:44 PM Ben Novack<EMAIL_ADDRESS>wrote:

A github link goes a long way toward helping new developers get on board -
show them the site as it exists, and within a couple of clicks they're
looking at the issues they can dive into.
—
Reply to this email directly or view it on GitHub
https://github.com/hack4impact/gpcah/issues/78.

Exactly. I was looking at the site while on the phone with the Office of Sustainability to see if Code for Philly could help out with some future dev work, and it wasn't obvious whether it was open source at all or where to find code. For a moment I was afraid the source might not even be available!

Oh cool, that's a good idea. @sandlerben we can add a line in the footer e.g. "Developed by Hack4Impact in partnership with the Philadelphia Food Policy Advisory Council and the Greater Philadelphia Coalition Against Hunger. Interested in contributing? Check out our [project page]."

See #79


Codegen cleanup: unnecessary null handling

In protocol test codegen there are maybe 30 cases in restJson in which codegen produces null checks that are unneeded.  This task is to go through them and update codegen such that the unnecessary code isn't produced.
See also: #176146308
internal id: 176123118

Resolving in favor of aws-sdk-kotlin#322.


formatting, fix in csharp_style_throw_expression

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: Heikow2 sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/ide/editorconfig-code-style-settings-reference.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

@Heikow2 thank you so much for submitting these improvements. The topic has been reformatted considerably and your improvements have been addressed.


Contents Link not working

Contents Link not working. When click on the link it take to the edit page.

Fixed the content link


[ROS Dependency] Need to update the windows dependencies for azureiot

Describe the bug
The azureiot dependency for Windows version is out-of-dated. The folder structure for Windows is different from the latest official version for Linux.
To Reproduce

On Windows, macro_utils.h is located in "C:\opt\rosdeps\x64\include\azureiot*azure_c_shared_utility*" folder.

On Linux, after install azure-iot-sdk-c-dev with the command "sudo apt-get install -y azure-iot-sdk-c-dev",  macro_utils.h is located in /user/include/azureiot/azure_macro_utils folder.

We have refer to the different path in the source code  -
#ifdef _WIN32
#include <azure_c_shared_utility/macro_utils.h>
#else
#include <azure_macro_utils/macro_utils.h>
#endif
Environment information:

OS version: 10.0.18362.295
Chocolatey Versions: ros-melodic-desktop_full 20190729.1

Thanks for the post. We're working on vcpkg work for dependencies and will include this work

Now we switched to consume the vcpkg port, and https://github.com/microsoft/ros_azure_iothub has been switched to consume the port.


Properties of object defined as Record<string, never> can be successfully assigned to any type

🔎 Search Terms
never successfully assigned should be error
🕗 Version & Regression Information

This is the behavior in every version I tried, and I reviewed the FAQ for entries about never

⏯ Playground Link
https://www.typescriptlang.org/play/?ts=5.6.3&ssl=19&ssc=25&pln=1&pc=1#code/C4TwDgpgBAyg9gWwgFXNAvFA3gWAFBSFRwB2EAXFCQK4IBGEATgNz5FTADuclAzsIwCWJAOasCRYAAtGEClDpw4AGwgBDEuPYAzONUYB+SgCUIAYziMAJgB5+Q0QBoo1EgGsScTiQB84gL74+BYk-ApqVibmlrb2wiLOZABuTD5QmFiBePgA9DlQyFKCvFC8UnrKVhwyXlBMjJa8zrzCZtCeZMTa1RC80GANkIzAgr11AB7FwFAaVdJMELqyUGYantPa1MragsrKPVDCwEzaam3BpGG8iBDS8ZTwSKiQ6dhsRKTydBEAdJ+O70IXB44SsP2BAIkQJkcko3zB0lkEEhOj0jDhv10+khWVy+QAEl4IClGM55stOGoSp4OGheGYhGBpvVLDMSFUAJIAcgQVFq2iRHDgLj61WKHEESEU9Hw1yQd1E4O4P14YGUgmAAAoAEQ5bUASiAA
💻 Code
type SomeType = {
    one: number;
    two: string;
    three: boolean;
    four?: Record<string, unknown>;
}

const bad: Record<string, never> = {}

// This should throw errors, since none of these properties exist and therefore cannot fulfill the interface
const something: SomeType = {
    one: bad.one,
    two: bad.two,
    three: bad.three,
    four: bad.four,
}

// However, there was no typescript error and I'm now free to use this timebomb
something.two.split("/")

🙁 Actual behavior
Typescript happily accepted the input even though it was invalid and this tiny test app blew up trying to split undefined
🙂 Expected behavior
Should have issued a type error
Additional information about the issue
No response

never isn't relevant here; the problem is the index access:
https://www.typescriptlang.org/play/?ts=5.6.3#code/C4TwDgpgBAyg9gWwgFXNAvFA3gWAFBSFTADucAXFAM7ABOAlgHYDmA3PgL774DGcjNKACMAhgBNKAJQh9aYgDw0GLADTU6TZgD4omLFzz4A9EajIAFvSrVzcAK4AbMcXO04JKBFpvaVNVSYeaEZ+aDgAMxcIKmgwN0haYHpozwAPK2AoEUZnYHMvCHC4WmgebJDM8Mdw+gcHKKgmYC9wkSDefkEqRAg8zUp4JFRIXWx8ImIySlExADpSOBVObjwTKAAJdwgANy81PIKoEhFrEOI0Kh4GMEyvHyycqABJAHIEKBCPcJLoYDgoOwxFxWYj0JBCRBCfDdJB9FjzMizKhgBz0YAACgAREZMQBKfBAA
The nouncheckedindexedaccess option catches these.

@nmain that doesn't sound right to me. The definition of never is that it should not be assignable to anything - never is not and can never be a string, for example. The fact that I can assign a value typed as never to a value typed as string seems like it would clearly be an error. And yes, enabling that option will make the example successfully fail, but that seems like it's only a technicality of the way I wrote the example, since all it does is add an implicit | undefined to all values accessed via an index (although to be fair, I can't think of a good alternative example off the top of my head).

See https://www.typescriptlang.org/play/?ts=5.6.3#code/CYUwxgNghgTiAEYD2A7AzgF3gTwFzxRADcQYBuAWAChl0sAPfTGASxQHN4BeHSm1TPABe+QiRjd49MkA:
declare const y: never;
const x: string = y;
const z: never = x; // Type 'string' is not assignable to type 'never'.

That is, a variable of type never cannot be assigned any value (excepted those of type never). However, a variable of any type can always be assigned to a value of type never.

"The definition of never is that it should not be assignable to anything" No, the never type is assignable to everything..  It's TypeScript's bottom type:
declare let nvr: never;
const str: string = nvr; // okay
const num: number = nvr; // okay
const dat: Date = nvr; // okay

You've got it exactly backwards; the definition of never is that nothing (other than never) is assignable to it:
nvr = str; // error;
nvr = num; // error
nvt = dat; // error

As such, TypeScript is behaving as intended here. If you can actually find a value of type never (and you shouldn't be able to) then you can assign it to anything else.

I understand that that's true; I wonder if you might at least agree that it's alarming that in my example I can easily get to a fatal error with no warning. Or put another way, it seems fairly obvious that the situation I've outlined should produce an error, regardless of the theory behind the type.

Yes, you apparently want --noUncheckedIndexedAccess, which was already pointed out. The situation has little to do with never.

Ok, I'll give up on this, although I strongly disagree that --noUncheckedIndexAccess is the solution here. You yourself pointed out that declare let nvr: never; const str: string = nvr; works and will lead to the exact same error I produced in my example, and --noUncheckedIndexAccess will not save you.
Anyway, I'll let it go for now, as I appreciate that you guys have bigger fish to fry 😁 .

None of us guys frying fish here are official TS team folks so if you disagree both strongly and italically you might wait for them to chime in before giving up.
I'll try one more time to spell out what's happening; feel free to ignore it.
You can never get your hands on a value of type never, so any manipulation you do with a value of that type is indicative that something has already gone wrong:
function foo(): never { throw new Error("oopsie"); }
let nvr: never = foo(); // <-- this is where the runtime error happens
const str: string = nvr; // <-- this code never runs
str.toUpperCase(); // <-- this code never runs

The problem isn't with the assignment from nvr to str, the problem is that code flow has aborted before you even get there.  That's what never is supposed to be, an indication that something impossible has happened and that code flow cannot reach the code you're looking at.
That means value of type Record<string, never> is therefore something where reading a property either gives you undefined or it throws:
const rec: Record<string, never> = {
  get x(): never { throw new Error("no x") },
  get y(): never { throw new Error("no y either") },
}

So here's where --noUncheckedIndexedAccess matters. With it disabled as usual, TypeScript just ignores the possibility that you might get undefined, so it imagines that all properties you read are of type never, whereas they are very likely to be undefined. So TypeScript thinks control flow can't reach your line and will allow you to assign undefined to string or number. The problem is assigning undefined, not never.
// --noUncheckedIndexedAccess disabled
const num: number = rec.z; // okay, but this is a problem because in fact num is undefined.
const undef: undefined = rec.x; // okay, but this doesn't hurt anything because control flow never reaches here

If you turn on --noUncheckedIndexedAccess, then every property you read will be treated as type undefined, since, if the control flow can actually make it past the read, the property will be undefined:
// --noUncheckedIndexedAccess enabled
const num: number = rec.z; // error as expected, Type 'undefined' is not assignable to type 'number'.
const undef: undefined = rec.x; // okay, but this doesn't hurt anything because control flow never reaches here

That's a good point about not realistically being able to reach a scenario in which this is a problem. I can see how in a fully typescript program that would be the case, and of course in the opposite case of accepting input from the outside world you're already introducing more uncertainty than the simple possibility that we'll run into a situation we didn't think could exist (i.e., never). So yes, I can accept that.
Still, I wonder what would happen if they just made never not assignable to anything..... Would it blow everything up? Seems like it wouldn't, since it's never supposed to happen anyway 🤷 . And doing so would make it more "right" in my opinion, solving the problem without using an option that (in our case) is not feasible to enable. (As a sidebar, I would love to enable that option but our codebase is already littered with instances of using values directly, and it would be a huge pain to go through and handle them or ignore them with !.)

You might be confusing never with unknown? If you want a type that cannot be assigned to anything, it is unknown you are looking for.
In terms of sets, unknown represents the set of all possible values, while never represents the empty set. So it is entirely correct to say that any value of type never is also of type string, as the empty set is a subset of the set of all strings (or of any other set).
Making never behave like unknown would completely defeat its purpose, as it would basically mean that only functions returning unknown would be allowed to throw exceptions.

Still, I wonder what would happen if they just made never not assignable to anything..... Would it blow everything up? Seems like it wouldn't, since it's never supposed to happen anyway 🤷 . And doing so would make it more "right" in my opinion, solving the problem without using an option that (in our case) is not feasible to enable

There's a ton of misapprehension built into this statement; it's like asking what would happen if you said infinity was less than every other number. Well, it wouldn't be infinity anymore, and then you'd need a new name to give that limit, and then you'd be right back where you started.
The definition of never is the empty set of values, and the definition of "assignable to" is "is a subset of values", and the empty set subsets all other sets. I don't know which of those facts you're proposing be thrown out when you say "make never not assignable to anything".

Again, I'd like to emphasize that I understand and agree that my goal here deviates from the theory. My question is, "should a value that by definition cannot exist be freely assignable to a value that by definition does exist?" Yes, "assignable to" has special meaning in the theory underpinning typescript. But in the same way that the rules were bent to allow index access not reflect that operation's inherent uncertainty (via the noUncheckedIndexedAccess setting, which obliterates a hard theoretical fact about index access), I'm proposing that the rules be bent to make this particular aspect of typescript make more sense (and be quantifiably safer, which ultimately is the goal of the language). My understanding is that precisely because this situation is never supposed to happen in the first place, there would be no real consequence to end users other than suddenly discovering upon upgrading their typescript version that something they thought was safe was in fact definitely broken.

If you just pencil this out a few steps, you run into huge problems.
The type string & number reduces to never, because it has zero inhabitants.
The type string | never today is the same as never, because never is a subtype of string. But that's no longer true.
So let's say you have a function that filters arrays to just their strings, and you filter it:
declare function stringsOnly<T>(arr: T[]): (T & string)[];

const arr = [1, "hello"];
const s_arr = stringsOnly(arr);

Now the type of s_arr isn't string[], it's (string | never)[]. Since never isn't assignable to string anymore, you can't use this as a string[], even though that's what (T & string)[] was supposed to do. It's not really clear how you get out of this situation.

Why are you so convinced it has something to do with never? If anything, it is Record that you should blame:
const bad: Record<string, string> = {};
// Uh-oh
bad.foo.toLowerCase()

Also, where did you get a value of type Record<string, never> to begin with? It's usually already pretty rare to have to deal with never, so a record of never values seems very unusual to me.

@guillaumebrunerie noUncheckedIndexedAccess prevents the “uh oh” in that example. But never is assignable to everything on purpose because it represents the result of an operation that threw an exception.

Ok, makes sense, and this answers my question. The operation I'm hoping for would indeed cause broad problems in the implementation. I'm satisfied with that.
To @guillaumebrunerie's comment:
Yes, your example illustrates the "bending of the rules" that I was referencing with the noUncheckedIndexedAccess: false setting. Your example should fail, but you can arbitrarily configure typescript to make it not fail.
To your second point about where I got a type of Record<string, never>, maybe this is my own misunderstanding, but I have used that type to indicate an object that cannot have any properties. In the case that spawned all this, I was typing a generic request type such that if you didn't explicitly give it a body type, the body type resulted in Record<string, never>, which I intended to mean "an empty object". I admit, I grabbed that type out of habit, and you're right that unknown would probably have been a more appropriate type in that case and would have solved my problem. I just ended up shocked that there were no errors for something that was so obviously incorrect.

TypeScript is actually not type-theoretically airtight by design. It’s designed to strike a balance between soundness and usability in order to model idiomatic JS as closely as possible, so you can easily find holes in it.

Totally agree. The setting is always enabled in projects I start from scratch, but for this particular project it's not feasible.
Anyway, I'm satisfied that A) typescript is working according to its theory; and B) making an exception like this would cause widespread problems. Closing this out.

I have used that type to indicate an object that cannot have any properties

You can't represent such a type in TypeScript.


Integration of console-iot with master

Type of change

Enhancement / new feature

Description
Enable the management of IoT features through Console:

Visual IoT Screens
Integration of the IoT screens to Mock Server
Enable Mock Server to include schema and functionality to support IoT.
Upgrade Patternfly to the latest release

Marvel Designs
https://marvelapp.com/prototype/5gbji22
Checklist

[ ] Update/write design documentation in ./documentation/design
[ ] Write tests and make sure they pass
[ ] Update documentation
[ ] Check RBAC rights for Kubernetes / OpenShift roles
[ ] Try your changes from Pod inside your Kubernetes and OpenShift cluster, not just locally
[ ] Reference relevant issue(s) and close them after merging
[ ] Update CHANGELOG.md

@drcoolsanjeev @ajaypratap003 @rkpattnaik780 This PR has reintroduced warnings related react-popper, which was resolved earlier.

I noticed some inconsistencies in the input types for the graphql iot mutations this morning, i want to align those before it's merged

Looking at PR #4926: downgrading the version of react & typescript, I don't believe it will help the build issues in this PR.
I have compared a successful build from master: https://pipelines.actions.githubusercontent.com/KxWcr3gUsjLAPBH2otl3MWUiuEaoRcGYQy1SDmNP4xdyBJ0SiN/_apis/pipelines/1/runs/6570/signedlogcontent/5?urlExpires=2020-07-13T19%3A17%3A18.9691159Z&urlSigningMethod=HMACV1&urlSignature=absgcxgpIh6v%2FVxuK69b%2F%2F30Id825zMmocrKNxEReX8%3D
With the failing build from this PR: https://pipelines.actions.githubusercontent.com/KxWcr3gUsjLAPBH2otl3MWUiuEaoRcGYQy1SDmNP4xdyBJ0SiN/_apis/pipelines/1/runs/6560/signedlogcontent/5?urlExpires=2020-07-13T15%3A24%3A35.9669749Z&urlSigningMethod=HMACV1&urlSignature=HQGEBv8onh4LEmEe2DhWg1TraSWV33R6EGJo9Al0PcM%3D
But haven't been able to spot any version differences etc. that would account for it passing locally, and passing on master in jenkins.  But failing in here.
@k-wall the error message is Failed to execute goal com.github.eirslett:frontend-maven-plugin:1.9.1:yarn (yarn test - console) on project console-init: Failed to run task: 'yarn test --watchAll=false' failed.   Is it possible to get more logging for this?  I am surprised I can't reproduce it locally.


[Python] Voluptous Python 3

Please add the following dependency to the rosdep database.
Package name:
Voluptous for python3, update to https://github.com/ros/rosdistro/pull/17079
Package Upstream Source:
https://github.com/alecthomas/voluptuous
Purpose of using this:
PR to add the JSON validation library Voluptuous. We use this to validate JSON commands coming from external sources (laptop, cloud etc).
Links to Distribution Packages
Ubuntu: https://packages.ubuntu.com/focal/python3-voluptuous
Fedora: https://src.fedoraproject.org/rpms/python-voluptuous
Debian: https://packages.debian.org/buster/python-voluptuous
Gentoo: https://packages.gentoo.org/packages/dev-python/voluptuous
Checks

[x] All packages have a declared license in the package.xml
[x] This repository has a LICENSE file
[x] This package is expected to build on the submitted rosdistro

I am not fully clear if this is the best way to approach the python3 upgrade. For ubuntu there is a distinct python-voluptous and python3-voluptous, but for the other distros they ship the updated version which is compatible with python2 and python3. Happy to make any corrections to make this more sane.

It appears there's a rhel source as well. It would be great if you could add that as well! Otherwise looks good.

@mr337 I think you have to omit RHEL 7. See https://github.com/ros/rosdistro/pull/30357/files

@mr337 I think you have to omit RHEL 7. See https://github.com/ros/rosdistro/pull/30357/files

I learned the hard way :(, new changes being tested

Before merging is it better to do it this way as you linked? From RHEL 8 and on the package should be available. So will the below method do a wildcard for anything RHEL 8+?
  rhel:
    '*': [python3-flask-cors]
    '7': null

Before merging is it better to do it this way as you linked? From RHEL 8 and on the package should be available. So will the below method do a wildcard for anything RHEL 8+?
  rhel:
    '*': [python3-flask-cors]
    '7': null

Yeah, I think the idea is we want to have forwards compatibility in the case of RHEL 9, etc. Would be a bit of a headache to have to update every package when that happens haha.

Thanks for the help!


Proxy config seems to be causing problems related to memory leak

Which package is this bug report for? If unsure which one to select, leave blank
@crawlee/playwright (PlaywrightCrawler)
Issue description
I have problems with an actor only when a proxy config is used. The crawler gets stuck on loading the page infinitely, and there are memory overload warnings in the logs - all is good when the proxy config is not used. Not sure what's going on and perhaps it is related to this as the closest thing I could find but honestly didn't look into it much: https://github.com/apify/proxy-chain/pull/146 @szmarczak
Code sample
const proxyConfiguration = input.proxy && await Actor.createProxyConfiguration({
	apifyProxyGroups: input.proxy.apifyProxyGroups,
	apifyProxyCountry: input.proxy.apifyProxyCountry,
});
...

const crawler = new PlaywrightCrawler({
	// proxyConfiguration,

Package version
latest
Node.js version
21
Operating system
Win10
Apify platform

[X] Tick me if you encountered this issue on the Apify platform

I have tested this on the next release
No response
Other context
Running on platform there are no memory warnings showing up but instead getting this constantly:
WARN  PlaywrightCrawler: Reclaiming failed request back to the list or queue. Navigation timed out after 60 seconds.

Input schema:
"proxy": {
            "sectionCaption": "Proxy",
            "title": "Proxy",
            "type": "object",
            "description": "Define proxy to pass data through",
            "prefill": {
                "useApifyProxy": false
            },
            "default": {
                "useApifyProxy": false
            },
            "editor": "proxy"
        }

Runtime proxy config:
{
  isManInTheMiddle: false,
  nextCustomUrlIndex: 0,
  proxyUrls: undefined,
  tieredProxyUrls: undefined,
  usedProxyUrls: {
  },
  newUrlFunction: undefined,
  log: {
    LEVELS: {
      "0": "OFF",
      "1": "ERROR",
      "2": "SOFT_FAIL",
      "3": "WARNING",
      "4": "INFO",
      "5": "DEBUG",
      "6": "PERF",
      OFF: 0,
      ERROR: 1,
      SOFT_FAIL: 2,
      WARNING: 3,
      INFO: 4,
      DEBUG: 5,
      PERF: 6,
    },
    options: {
      level: 4,
      maxDepth: 4,
      maxStringLength: 2000,
      prefix: "ProxyConfiguration",
      suffix: null,
      logger: {
        _events: {
        },
        _eventsCount: 0,
        _maxListeners: undefined,
        options: {
          skipTime: true,
        },
      },
      data: {
      },
    },
    warningsOnceLogged: {
    },
  },
  domainTiers: {
  },
  config: {
    options: {
    },
    services: {
    },
    storageManagers: {
    },
  },
  groups: [
  ],
  countryCode: undefined,
  hostname: "proxy.apify.com",
  port: 8000,
  usesApifyProxy: true,
}

I am now only able to reproduce this consistently, only locally, not on the platform. Presence of proxy config leads to memory warnings and thousands of network-level errors in the browser, while its absence is problem free (with the proxy config prop commented out). Target is techcrunch.com
Perhaps the proxy config is somehow corrupt locally, when the platform proxy input is not used?


Feature Request - ES6 class support

ES6 classes are called as functions which throws an error; The current workaround is to pass the class enveloped into a function () => MyClass.

Not sure I understand. Can you please provide some sample code and the actual vs. desired outcome?

let sprintfJs = require('sprintf-js').sprintf

class SomeAwesomeClass {
  someMethod() {}
  someMethod2() {}
}

sprintfJs('test %s', () => SomeAwesomeClass)

First issue
Without the () =>, it tries to invoke the class as if it were a function, so you get the error TypeError: Class constructor SomeAwesomeClass cannot be invoked without 'new'.
Second issue
After using () => to work around the first problem, it converts the class to string which renders the class body instead of only the name and result of the previous code is: test class SomeAwesomeClass {\n … someMethod2() {}\n\n }, this can be worse if you use babel plugins which transforms classes to functions.
It needs to recognize that a class was passed and render a simplified string, for example test [class SomeAwesomeClass].

A use case for this feature would be test suites using https://github.com/mattphillips/jest-each

@alexei Added a pull #158  which implements the feature.

Use Class.name or instance.constructor.name

I kind of sort of understand what you're asking. It's that you need a string representation of a class. There are two issues: one is I'm not aware of any standard/convention in that regard. The other, which might be solvable, is that sprintf supports computed values


Update README.md

@kamathshashank1111 this will done by a githu bot once you make PR with presentation bro, it shouldn't be done manually


Chinese input method's First character cannot be caught when switching back using Alt + Tab

What is the problem?
When I switch back from another window using Alt+Tab shortcut, first Chinese character cannot be caught in Chinese input method. This happens sometimes, not always, but I didn't know exactly when this will happen, maybe when I write long markdown files. When I write Chinese in JavaScript files, the problem doesn't exist.  See this gif:

By the way, the problem exists on both Microsoft Pinyin & Sogou Pinyin.
How can I reproduce it?

Write some Chinese words
Use Alt + Tab to switch to another window
Use Alt + Tab to switch back
Continue writing

Is there any error message in the console?

No.

Could you disable this extension and test again? I cannot reproduce on my laptop.

After I disabled vscode-markdown, the problem still exists. I think it's relevant to vscode itself.


[Snyk] Security upgrade mistune from 0.8.4 to 2.0.3

This PR was automatically created by Snyk using the credentials of a real user.Snyk has created this PR to fix one or more vulnerable packages in the `pip` dependencies of this project.
Changes included in this PR

Changes to the following files to upgrade the vulnerable dependencies to a fixed version:

requirements-dev.txt

⚠ Warning
nbconvert 6.5.0 requires MarkupSafe, which is not installed.
nbconvert 6.5.0 has requirement mistune<2,>=0.8.1, but you have mistune 2.0.3.
Jinja2 3.1.2 requires MarkupSafe, which is not installed.
argon2-cffi 21.3.0 requires argon2-cffi-bindings, which is not installed.

Vulnerabilities that will be fixed
By pinning:

Severity
Priority Score (*)
Issue
Upgrade
Breaking Change
Exploit Maturity

551/1000  Why? Recently disclosed, Has a fix available, CVSS 5.3
Regular Expression Denial of Service (ReDoS) SNYK-PYTHON-MISTUNE-2940625
mistune:  0.8.4 -> 2.0.3
No
No Known Exploit

(*) Note that the real score may have changed since the PR was raised.
Some vulnerabilities couldn't be fully fixed and so Snyk will still find them when the project is tested again. This may be because the vulnerability existed within more than one direct dependency, but not all of the effected dependencies could be upgraded.
Check the changes in this PR to ensure they won't cause issues with your project.

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.
For more information:
🧐 View latest project report
🛠 Adjust project settings
📚 Read more about Snyk's upgrade and patch logic

Learn how to fix vulnerabilities with free interactive lessons:
🦉 Learn about vulnerability in an interactive lesson of Snyk Learn.

This is a downstream dependency for jupyter. As we are only running jupyter locally, we are not affected by this vulnerability.


Does not load in Firefox

First of all, really impressive work to get xeus-python to compile to WebAssembly!
Description
Looks like the kernel does not load in Firefox though. The error logged in the dev tools might be relevant:
TypeError: WebAssembly.Tag is not a constructor

Reproduce
Open https://xeus-python-kernel.readthedocs.io/en/latest/ with Firefox 99.
Expected behavior
Should run in Firefox.

Interestingly, it loads fine in Firefox 101.0b5 (Firefox Developer Edition).

So maybe not much to be done here for now if future versions of Firefox are not impacted.

Maybe upgrading to 100 should be enough? I see it working on 100:

Maybe upgrading to 100 should be enough? I see it working on 100:

Yes similar observation in https://github.com/jupyterlite/xeus-python-kernel/issues/6#issuecomment-1124652376.
Let's close this since it's fine the latest stable version. Thanks for checking!


Missing telink(hal_telink)

In west init setup, not found telink(hal_telink) item can be select. I suggest that all options should be obtained by traversing the zephyr/west.yml file in that zephyr version, so as not to miss anything

implemented in 1.0.24


Add retry for batchGet

What problem does this PR solve?
Close #927
Check List
Tests

Unit test

Side effects

Possible performance regression

/run-all-tests


Custom Field : ForeignKey to other model

Hello
Is it possible to add a custom field to the ticket model that would link to an object of another model?
I didn't find the possibility through the admin. Would it be possible to extend the model a way or another?
For example with django oscar you can customize any model (https://django-oscar.readthedocs.io/en/releases-1.6/howto/how_to_customise_models.html)
Is it possible to do the same here, or another way?
Thanks

While django-helpdesk does allow custom fields to be added, I believe it is only for standard types (text, integers, etc.) and not for adding new objects to the model at this time. Would be an interesting feature to consider for future releases though!


Coffee : can't caffeinate when Status menu bar is disabled

Extension
https://www.raycast.com/mooxl/coffee
Description
The Cafeinate for option (as well as Toggle Caffeinate, Caffeinate for and Caffeinate while) returns an error when using it and the Caffeinate Status Menubar command is disabled in Raycast's Extensions.
The error returned is : Error: No enabled command 'index' found
Extensions are all latest, Raycast is 1.45.2 on MacOS 13.1 and M1 Air.
Steps To Reproduce

Install Coffee extension
Use any command to Caffeinate (...for, ...while)
Command is successfull
Go into Raycast's extensions settings and disable only Caffeinate Status Menubar
Exit Raycast's Settings
Use any command to Caffeinate (...for, ...while)
Error screen is presented with the following error (got from Copy Error secondary action) : Error: No enabled command 'index' found

Issue is present with either Status menu bar activated or not (present in menu bar or not).
Current Behaviour
No response
Expected Behaviour
No response

Thanks for flagging this, I'll make a fix today 😊

@pernielsentikaer Thanks for your fixing this.
I just tested and the extension works fine without the Caffeinate Status Menubar disabled in Raycast extension settings.

Thanks for confirming it fixed the issue 😊


Use ZOO_HOST not LOCAL_ENGINE_ADDR

man i feel like that should be a util maybe ill make a pr becuase that code is copied everywher

maybe we expose it to the world sincce i use the equivalent here too https://github.com/KittyCAD/kcl.py/blob/main/src/lib.rs#L185

ill make a pr

@jessfraz OK feel free to close this one if you want

okay i made it way more dry and external folks can now call these like now we can use these in kcl.py https://github.com/KittyCAD/modeling-app/pull/4321


Move isType out of internal and make it a predicate named isSameType

The home stretch

As we come closer to feature lockdown it is time to start cleaning up, optimizing and removing all the duplication (mostly around type assertions).
This PR is the first step in that process. The old and crusty isType just would not live in the new world. So this updates that function to be able to compare types properly in one place. Also, as it is a better interface, it is time to expose it as a real predicate available to the public. So gets a new name and an introduction to the world.
In addition to this move, and cutting over all dependent files, did a couple more :lipstick: bits:

Add both to Arrow and Star on the README
Flesh out the predicate signatures on the README
Expose some missing predicates to the public API that were missed a couple PRs ago :anguished:

isBoolean
isInteger
isMonad
isSetoid
isTraverable

Coverage remained the same at 100.0% when pulling ba7b1a6299e69c3a004b032777130d320b209ec5 on isType-pred into 969b105bca9bfff51b06e2723fcb263b5f8bf40a on master.


validate uuid id/pk

Summary
Validate UUID used as the id/pk for the model instance
Details and comments

These changes check the uuid before django validates it.  So it stops raising exceptions and returns 404 for the requests.

These changes check the uuid before django validates it. So it stops raising exceptions and returns 404 for the requests.

I know, I know. But we can rely on Django validation perfectly, we just need to capture the exception that it raises. We don't need to create our own validator for that.

I believe that the django validation happens when it saves to or retrieves from the database.  It's much cleaner and safer if we validate it at the entry of the apis.

My proposal @akihikokuroda :

We need to continue handling the exception in the queries anyway because we are not doing that right now. As the issue was proposing.
I don't see bad to add additional checks but not through custom checks. We can use UUID utility from python.
Move the logic to utils and reuse it in those specific points.

handling the exception in the queries

Are the queries database query? Where do you propose to put the try clause?
The UUID utility seems for generating an UUID.  I don't see the method for validating it.

Are the queries database query? Where do you propose to put the try clause?

It happens in every find, filter, etc that uses the id to search for something, example here.
You just need to encapsulate that call in a try/except, and in this case, return None is fine for example.

The UUID utility seems for generating an UUID. I don't see the method for validating it.

If you try to create an UUID with a value that is not a valid UUID it will raise an exception that you can capture similar to what you were doing with the pattern.

Let's close this PR by now and we can reschedule it in the next weekly


Project 20 has a huge amount of whitespace at the bottom of its preview

Low priority. Not sure what's up with the spacing. Haven't bothered to isolate the bug yet...may be a particular kind of form input?
Video:

Browser: Chrome

It's YUGE because the animation needs the height to be set and we calculate it using an average height * number of components + some margin; haven't looked too deep into this to see if there's a way without specifying the height

Suggested solution: launch previews in a new tab

Added fix for space (without depending on height explicitly) and handle scrolling to top on preview


Marketplaces is a separate file now - keeping it perpetual.

@rajesh-rajagopal  Make sure you use this marketplaces.cql in the next build tomorrow for testing.


Getting "Authentication process canceled" on JWT pair google-oauth2 on post man !

Am getting Authentication process canceled with 400 status code on JWT pair google-oauth2 through post man but its works fine with "VueJs" with the "vue-authenticate" package .
I not getting why it is happening , it should works with post man also .
It is giving me headache ..all settings is fine , its working with vuejs but not working with post man
Please help me out !!

For what it's worth, i got a few of those as well.
This exception could be triggered by a lot of things:

Authentication process canceled; ; {'error': 'invalid_request', 'error_description': 'client_secret is missing.'}
Authentication process canceled; ; {'error': 'invalid_grant', 'error_description': 'Malformed auth code.'}
Authentication process canceled; ; {'error': 'redirect_uri_mismatch', 'error_description': 'Bad Request'}
Authentication process canceled; ; {'error': 'invalid_request', 'error_description': 'Invalid parameter value for redirect_uri: Fragment not allowed: http://localhost:8001/#/'}
Try putting django in debug mode, it will show you these messages.


Cannot resolve favicon.ico in npm run dev

I have the following error with npm run dev:
ERROR in ./~/app-framework/client/init.js
Module not found: Error: Cannot resolve 'file' or 'directory'
../../.app-framework-cache/icons/dev/favicon.ico in .../node_modules/app-framework/client
 @ ./~/app-framework/client/init.js 25:2-72

Webpack doesn't create index.html page and I obtain a Cannot GET / error.
When I commented
require(process.env.CACHE_ROOT_FROM_SCRIPTS + 'icons/dev/favicon.ico')
at app-framework/client/init.js:30, all works fine, obviously.
Thank you.
-L

@lcaprini - Please can you show a screenshot of your folder "app" ?

This error occurs since first run, after the npm install. This is my situation:

@lcaprini - Is the issue fixed for you when you try with a clean installation according the docs?

We've ran into this problem at latest framework update. For a some reason not all icons were generated.
Fresh installation works fine as like as removing and farther node_modules/.app-framework-cache folder regeneration during next build.


Update readme template

@po5i I've followed the instructions and run docker-compose, it works perfectly! Nice!


⚠ Bofrost.fr has degraded performance

In 1c28605, Bofrost.fr (https://www.bofrost.fr) experienced degraded performance:

HTTP code: 200
Response time: 846 ms

Resolved: Bofrost.fr performance has improved in 34e267b after 6 minutes.


Tasks connected to a swarm network will have 1 endpoint on windows RS3.

@msabansal please review

LGTM

@mavenugo @fcrisciani Can we merge this pull request?

@mavenugo @fcrisciani Or review it and give feedback so that we can merge it.

LGTM, @pradipd can you confirm that is ready to be merged?

@fcrisciani it is ready to be merged.


apple pay: don't support this device(both simulator and real device)

Describe the bug
after setting in apple developer and stripe dashboard, apple pay: the device don't support this device
Expected behavior
should be support apple pay
Desktop (please complete the following information):

OS: iOS
Version 0.1.2

Smartphone (please complete the following information):

Device: iPhoneX
OS: iOS10

Please provide screenshots and detailed reproduction steps.

Closing out as stale. Feel free to reopen with the above mentioned info.


feat: Improved Taiko Protocol and Relayer Documentations

Overview
This Pull Request introduces updates to the Taiko Protocol and Relayer project documentation and configuration settings. These changes are based on my hands-on experience using and testing these protocols, the documentation aligns well with practical usage and all setup processes are streamlined for future developers.
Changes

Expand Relayer README with Detailed Build, Config, and Usage Instructions

Overhauled the Relayer's README.md to include comprehensive instructions on building the source, configuring MySQL and RabbitMQ, setting up environment variables, and usage guidelines.

Revamp README with Detailed Steps

Extensively updated the Taiko Protocol's README.md. This revamp includes detailed steps for setting up the environment, generating the L2 genesis JSON's alloc field, generating and running with the L2 genesis block, and deploying the L1 contracts.

Disable Auto-Mining in Hardhat for Controlled Test Execution / Changed DATABASE_PASSWORD from root to passw00d

Updated Hardhat configuration to disable auto-mining for testing purposes.
Modified the default database password in the .l1processor.example.env file of the Relayer package to match the default db password.

Nice


separate in and out traffic between router and broker

… over different connections (related to issue-1431)

@lulf or @rgodfrey could someone re-review this? I believe the previous issue is now fixed.


Show source name in callstack even when path is provided

For #150

This is fine by me, but not sure if it is contradicting with @weinand comment here
We should just come to a consensus, what has priority name or the path?

@isidorn yes, 'name' has priority over 'path' for the callstack 'name' (shown on the right).  And 'path' has priority over 'name' for the callstack 'path' (shown on hover).


imagenet-camera problem

Hi, thank you for your service of jetson tutorial
I have a question
The result didn't appear at top right of frame when I ran imagenet-camera.py. I could just see FPS and model's name on title bar.

Hi can you show us the code you used ?


Scrollbar not visible at first

Not sure if this is a bug of if I'm missing something so thought I'd ask.
I have a RecyclerView that consists of varying heights TextViews (and some of the TextViews are larger than the full screen height).
When my view is first loaded, I do not see the scrollbar at all. In this case the first TextView is larger than the full screen height. As soon as I scroll down to the first line in the second TextView, the scrollbar shows up.
After that the scrollbar sticks and works fine even when scrolling back up to the top.
Any idea what might be happening here?

This is essentially the same issue as #39, so I will close it as duplicate and we will continue there.


[ART-8304] Enhance Dockerfiles to Utilize install.sh Script

Adjusted Dockerfile.base and Dockerfile.update to optimize the use of the install.sh script from art-tools. This change ensures proper execution of the script within the Docker build process, improving dependency management and aligning with our updated build strategy. The modifications include updating pip before the script execution and ensuring compatibility in the Docker environment.

/approve

/hold
@MartinPl0 can you sync the changes from the art-bot PR as well?


[loc][Query][DevDiv] Typo in source "id"

VSCode Version:
OS Version:

Steps to Reproduce:
Hi, we have a query about the English source text. Can you help please?
source:
Map all files matching the glob pattern in their filename to the language with the given id.
Map all files matching the absolute path glob pattern in their path to the language with the given id.
File Name:
extensions\json\server\out\jsoncontributions\fileAssociationContribution.nls.resx
resource ID:
".resx", 0; "assocDescriptionFile"
".resx", 0; "assocDescriptionPath"
Query:
"id" is usually spelled "ID". Can you please confirm and fix if necessary? Thanks
(TFS 208375)

I renamed "id" to "identifier". It is about the "language identifier", for example "html". I think for 1.0 it is fine to translate this to "ID".

Great, thanks!


Check LOV for common vocabularies to use

http://lov.okfn.org/dataset/lov

For observedProperty we can use the common SSN ontology: http://purl.oclc.org/NET/ssnx/ssn#observedProperty

We don't miss any terms currently, so closing this. Reopen if necessary.


OpenDota web failing because gold_t returns null instead of array

Opening any match on OpenDota Web results in the page stuck in the 'loading' state
Debugging console errors point to reading the gold_t[10] value
The API response is presently returning null instead of an array

Images attached below are in the order of the statements above

Looks like an issue with the new winner display. I've added a check to ensure gold_t exists.


Fix enumerate over an ndarray corner case

As pointer out by a FIXME, the enumerate object was eventually holding a
dangling reference.
As a side effect remove an old iterator::reference artifact.
Added a test case from stack overflow pointing out the issue!

@pbrunet everything should be ok now ;-)

There is just a question about "possible" dangling reference otherwise, LGTM.

Changes Unknown when pulling fcfc2d2a4020aab1bcd264632d1b7ee979641db0 on fix/enumerate into ** on master**.


[ACR] Update to 2017-06-01-preview version

Add webhooks and replications as nested resources under registries.

This checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines

[ ] The PR has modified HISTORY.rst with an appropriate description of the change (see Modifying change log).

Command Guidelines

[ ] Each command and parameter has a meaningful description.
[ ] Each new command has a test.

(see Authoring Command Modules)

@DavidObando Rebased from master branch with managed registry, webhooks, and replications.
@SajayAntony

Please ignore all the SDK files, they will be removed before sending a PR to Azure repo.


Add doc of one-line quick start script for different storage types

We could prepare the demo/showcase replacement, but it should be updated when BanyanDB 0.6 is ready.

Is the exposed port visible in the logs too?

Is the exposed port visible in the logs too?

Added in the website repo https://github.com/apache/skywalking-website/commit/f5532574b33b43f4d11aabc6944db97ea9761ec6


doc: add UlisesGascon as a team member

@UlisesGascon I added you to nodejs/performance github team


tools/Makefiles: Fix use of unbuilt incdir binary

Summary
There were several cases where there were attempts to use the tools/incdir binary before it was used.  You can see these in the PR checks.  They do not seem to fail the build, but there are many of these errors in the build.
This resolves that issue but adds a significant amount to the build time.

I am thinking that the cause of the performance degradation is that INCDIR is defined only once when Config.mk is first included. After the true tools/incdir binary is created, the INCDIR definition is not updated and continues to use incdir.sh, ruining perfromance.

If we accept the changes to Makefile.win and Makefile.unix but ignor the bad changes to Config.mk, then all of the errors about failing to find the indir binary disapper except four that occur during configuration.

Backing out the changes to Config.mk restores good build performance:
real    0m35.451s
user    0m24.371s
sys     1m26.637s

If we accept the changes to Makefile.win and Makefile.unix but ignor the bad changes to Config.mk, then all of the errors about failing to find the incdir binary disappear except four that occur during configuration.

I have backed out the changes to Config.mk.  That means that there are still 4 reported errors at configuration time.  I am not sure yet how to do these.
The remaining changes to Makefile.unix and Makefile.win are still good, but insufficient because you will still see 4 errors about failing to find the tools/incdir binary.

Here are the remaining four errors reported.  This is only during configuration:
$ make olddefconfig V=1
/bin/sh: [HOME]/nuttx/tools/incdir.exe: No such file or directory
/bin/sh: [HOME]/nuttx/tools/incdir.exe: No such file or directory
make -C tools -f Makefile.host TOPDIR="[HOME]/nuttx" incdir.exe
make[1]: Entering directory '[HOME]/nuttx/tools'
/bin/sh: [HOME]/nuttx/tools/incdir.exe: No such file or directory
/bin/sh: [HOME]/nuttx/tools/incdir.exe: No such file or directory
gcc -Wall -Wstrict-prototypes -Wshadow -Wundef -g -pipe -DHAVE_STRTOK_C=1 -DHOST_CYGWIN=1 -o incdir.exe incdir.c

Where [HOME]/nuttx is the location on my machine of the incubator_nuttx repository.
Any body got any ideas where these are coming from?

Does anyone have any idea where these are coming from?

We know they are coming from the Make.defs file, but we don't know how to get rid of them (i.e. build incdir before getting here)
CINCPATH := ${shell $(INCDIR) -s "$(CC)" $(TOPDIR)$(DELIM)include}
CXXINCPATH := ${shell $(INCDIR) -s "$(CC)" $(TOPDIR)$(DELIM)include$(DELIM)cxx}

CINCPATH := ${shell $(INCDIR) -s "$(CC)" $(TOPDIR)$(DELIM)include}
CXXINCPATH := ${shell $(INCDIR) -s "$(CC)" $(TOPDIR)$(DELIM)include$(DELIM)cxx}

You are exactly right.  I think we could fix this by doing 'make tools/incdir' before doing 'make olddefconfig' in sethost.sh (and configure.c)

You are exactly right. I think we could fix this by doing 'make tools/incdir' before doing 'make olddefconfig' in sethost.sh (and configure.c)

Done... Now this PR should build with no more failures to find the incdir binary.

@xiaoxiang781216 One very negative aspect of this whole change to improve performance by using a compiled C tools/incdir binary is that the tools/incdir binary must exist prior to the first make.
The main reason for that is because the Make.defs files all need to add use $INCDIR to create CFLAGS but INCDIR refers to the the tools/incdir binary which has not been built yet.
The solution for now is to add logic into sethost.sh so that the tools/incdir binary is built before the first 'make olddefconfigs'.  This is not a clean solution and if you have some better ideas, I would love to hear them.  You usually have some pretty good ideas!
Abdelatif has a number of clean-ups that he would also like to do in Makefile.win/unix but that is based on the notion that the tools/incdir binary exists prior to make.  I asked him to hold off on those changes until we get some feedback from you.
The changes in the PR are sufficient to fix all of the silent errors that we were seeing the PR check logs.  They can be merged as is if you like.  Or we can incorporate any new, good ideas they you may have.

I think we could fix this by doing 'make tools/incdir' before doing 'make olddefconfig' in sethost.sh (and configure.c)

A better place would be from the top-level Makefile.  It does not include Make.defs and could create tools/incdir prior to include Makefile.unix.

PS.: In the checks there are some /github/workspace/sources/nuttx/tools/incdir.exe: not found these are coming from tools/refresh.sh

PS.: In the checks there are some /github/workspace/sources/nuttx/tools/incdir.exe: not found these are coming from tools/refresh.sh

I think these would be fixed by the propose logic added to the top-level Makefile above.  These are probably coming from 'make olddefconfig' and 'make savedefconfig' with no tools/incdir binary.

@patacongo Yes, it is better to put the logic into Makefile than refresh.sh, but we still need do some hack before invoke Makefile.host since Makefile.host also include Make.defs too. My question is that how much benefit we can get from the immediate varaible?
https://github.com/apache/incubator-nuttx/pull/1150

but we still need do some hack before invoke Makefile.host since Makefile.host also include Make.defs too

That hack is already in ${shell $(MAKE) -C tools -f Makefile.host incdir INCDIR="$(TOPDIR)/tools/incdir.sh"} INCDIR is given an initial value of tools/incdir.sh so that Makefile.host doesn't complain.

@xiaoxiang781216 Giving the time difference I don't think you'd be available now, so I'd like to merge this PR because:

It removes the error messages, we don't want them to stick around for too long, and
We'd like to see how this change will do during the nightly build.

Please continue reviewing this and we will address any concern you might have.


Improve inference to union and intersection types

This PR improves inference to union and intersection types containing multiple naked type variables. Previously we would make no inferences to such union and intersection types (for unrelated historical reasons that no longer apply). We now make the the proper inferences:
declare function f1<T, U>(x: T | U): T | U;
declare function f2<T, U>(x: T & U): T & U;

let x1: string = f1('a');
let x2: string = f2('a');

Previously both assignments were errors because we'd infer {} for T and U.
Fixes #29815.

Since I'm curious, what prompted us to only infer to one naked type parameter originally, anyway?

@weswigham I think it was a holdover from when we didn't have priorities associated with inference candidates.

Huh. I wonder why we didn't remove it when we added the NakedTypeParameter priority, then.
🤷


Add docs-paths config to dbt_project.yml

For the configuration
docs-paths: ["models", "docs"]

I am getting Property docs-paths is not allowed.

This is pretty easy to add! Just looks like this:
https://github.com/dbt-labs/dbt-jsonschema/blob/main/schemas/dbt_project.json#L51-L53
but docs-paths instead of model-paths

Resolved in https://github.com/dbt-labs/dbt-jsonschema/commit/0d5dce7b1b215fbd425c27f4a571af35088d930b


Does not open the product card

Hello!
I found one problem - in browsers FireFox and mobile Safari (in these it is checked for sure, there may be some others also have a problem) after the first download of the site, the product card does not open. I checked this also on https://demo.vuestorefront.io/ . You can click it as many times as you like, but it will not open, after restarting the page the card opens. Seems a problem with the cache.
The problem for these browsers is that we first try to take data from the cache, but they are not there. And only then we make a request to the ElasticSearch. Apparently the code execution hangs at the stage of trying to access the browser cache.
Refusing a cache request solves the problem, but this is not a good solution.

Yes, I've observed this last week and even came with some fix: https://github.com/DivanteLtd/vue-storefront/commit/b621f12cd1a66b313e41a4365adaffddf71a5367
Setting the cache timeout for 2s; Did you tested this version (I mean the latest "develop" snapshot)?
If it still occurs then we should find for some other solution

No, I have not tested it yet, but I will definitely do it and give feedback.

Yes, it's working!


Fix bugs in series feature

Fixes a bug where if your toc was empty it wouldn't show the series sidebar (even if there was content) in the series
I think there needs to be documentation on series, because I forgot how to use the series feature 😅 but I am not sure where best to put that.
(sorry about all the other commits, I am not sure how to squash them together)

Thanks!


json_escape() compatible with python 2 and 3

On Arch Linux python3 is the system's default.
In python3 print is a function and not a statement.
So on the first lauch of zsh after login it prints the following error in console:
File "<string>", line 1
import json,sys; print json.dumps(sys.stdin.read())
                       ^
SyntaxError: invalid syntax

The proposed workaround is to change in __zplug::utils::shell::json_escape() print to print().
In python2 it works as expected with a single argument (see this answer).

Ah, already solved, closing

Thank you for the contribution! I have solved that problem just before you did.

And your solution is more bulletproof. I was too lazy to go this way :)


Mark ShootSystemComponentsHealthy condition unhealthy if ManagedResource is stuck in progressing for more than threshold time

How to categorize this PR?

/area control-plane quality
/kind enhancement
What this PR does / why we need it:
This PR introduces a new field controllers.shootCare.managedResourceProgressingThreshold in GardenletConfiguration which can be used to set threshold time for managed resource progressing condition. So if an MR's Progressing and Healthy condition status is true for more than the threshold time, ShootSystemComponentsHealthy condition status will be changed to false.
Which issue(s) this PR fixes:
Fixes https://github.com/gardener/gardener/issues/6775
Special notes for your reviewer:
Release note:

A new field `controllers.shootCare.managedResourceProgressingThreshold` is introduced in `GardenletConfiguration`, which can be used to set threshold time for managed resource progressing condition.

There is no single unit/integration test added to cover the newly introduced functionality.

/test pull-gardener-e2e-kind-ha-multi-zone

/assign

/test pull-gardener-e2e-kind-operator

@shafeeqes Anything left from your side?

One minor thing that came to my mind is that validation can be introduced for the new field that it is a non-negative duration - ref https://github.com/gardener/gardener/blob/9a8c281dd526abac2f137674e1b9ae65b3892c65/pkg/gardenlet/apis/config/validation/validation.go#L35

/lgtm

/milestone v1.63

/test pull-gardener-e2e-kind-ha-multi-zone-upgrade


Support for adding directories

I believe this is a classic use case and it would be nice to have it directly in this module.
Here's what I currently do:
var fs = require("fs");
var path = require("path");
var yazl = require("yazl");

var noop = Function.prototype;

function addDirectory(zip, realPath, metadataPath, cb) {
  fs.readdir(realPath, function(error, files) {
    if (error == null) {
      var i = files.length;
      var resolve = function(error) {
        if (error != null) {
          resolve = noop;
          cb(error);
        } else if (--i === 0) {
          resolve = noop;
          cb();
        }
      };
      files.forEach(function(file) {
        addDirectory(
          zip,
          path.join(realPath, file),
          metadataPath + "/" + file,
          resolve
        );
      });
    } else if (error.code === "ENOTDIR") {
      zip.addFile(realPath, metadataPath);
      cb();
    } else {
      cb(error);
    }
  });
}

var zip = new yazl.ZipFile();

addDirectory(zip, "./my-directory", "my-directory", function(error) {
  if (error) {
    return console.error(error);
  }

  zip.end();
  zip.outputStream.pipe(fs.createWriteStream("./archive.zip"));
});

Nice code! I like that code a lot.
You're not the first to suggest this feature. My feeling about this is that directory traversal is outside the scope of this module. Let me explain.
As your code shows, this feature can be accomplished by building on top of yazl. yazl was designed to be a low-level component on which you can build abstractions without yazl introducing any unnecessary overhead. Your code is a good example of this principle at work.
Anything included in yazl is something that I have to maintain. Directory traversal can actually become a pretty complicated problem. Some features that people might ask me to add:

follow symlinks or not
detect fs cycles and report an error or silently ignore
exclude OS-specific hidden things by default like __MACOSX or Thumbs.db
configurable exclude patterns, e.g. /^\.|~$/
configurable include patterns?

You can see how these have anything to do with creating zip files, which is what yazl is really all about.
A very common usecase for zip files is capturing the state of a file system, and indeed zip files were designed with this usecase in mind. But if yazl tries to be a file system archiving utility, then yazl needs to know about file systems and their quirks. Currently, yazl does very little in this regard, specifically mtime and permission bits during addFile(). I feel like those are common enough features of any file system that it's worth supporting them here. But I hope I've made my point about how directory traversal starts treading into scarier territory. There are even potential security vulnerabilities tangled up in this concept that I don't want to be responsible for.
I encourage someone (it could even be you!) to make a node module that combines directory traversal with yazl to provide the feature you're looking for, or maybe this already been done. But I don't think this function belongs in yazl itself.

Most of these questions could be answered by a filter predicate receiving the path and the lstats of the entry but I understand :slightly_smiling_face:
I just wanted to share this code in case it might help someone.
Have a nice day.

For the fun, a version with the filter predicate:
var fs = require("fs");
var path = require("path");
var yazl = require("yazl");

var noop = Function.prototype;

const IGNORED_FILES = {
  __proto__: null,

  "$RECYCLE.BIN": true,
  "ehthumbs_vista.db": true,
  "ehthumbs.db": true,
  "Thumbs.db": true
};

function defaultFilter(realPath, stats) {
  var basename = path.basename(realPath);
  return !(basename[0] === "." || basename in IGNORED_FILES);
}

function addDirectory(zip, realPath, metadataPath, filter, cb) {
  if (cb === undefined) {
    cb = filter;
    filter = defaultFilter;
  } else if (filter == null) {
    filter = defaultFilter;
  }

  fs.lstat(realPath, function(error, stats) {
    if (error != null) {
      return cb(error);
    }

    if (stats.isDirectory() && filter(realPath, stats)) {
      fs.readdir(realPath, function(error, files) {
        if (error != null) {
          return cb(error);
        }

        var i = files.length;
        var resolve = function(error) {
          if (error != null) {
            resolve = noop;
            cb(error);
          } else if (--i === 0) {
            resolve = noop;
            cb();
          }
        };
        files.forEach(function(file) {
          addDirectory(
            zip,
            path.join(realPath, file),
            metadataPath + "/" + file,
            filter,
            resolve
          );
        });
      });
    } else if (stats.isFile() && filter(realPath, stats)) {
      zip.addFile(realPath, metadataPath);
      cb();
    } else if (stats.isSymbolicLink() && filter(realPath, stats)) {
      return fs.readlink(realPath, function(error, target) {
        if (error != null) {
          return cb(error);
        }
        addDirectory(
          zip,
          path.resolve(path.dirname(realPath), target),
          metadataPath,
          filter,
          cb
        );
      });
    } else {
      cb(); // ignored types
    }
  });
}

var zip = new yazl.ZipFile();

addDirectory(
  zip,
  "./my-directory",
  "my-directory",
  function(realPath, stats) {
    return !stats.isSymbolicLink() && defaultFilter(realPath, stats);
  },
  function(error) {
    if (error) {
      return console.error(error);
    }

    zip.end();
    zip.outputStream.pipe(fs.createWriteStream("./archive.zip"));
  }
);


Revert "build(deps): bump azure/cli from 2.0.0 to 2.1.0"

Reverts Azure/ARO-HCP#552 due to https://github.com/Azure/azure-cli/issues/29828

I was mistaken, the bug is relevant to the azure CLI version, not the GitHub Action version


1722337107854-base.js

issue with the "1722337107854-base.js" file
Debug File
i got this error
WARNING: Could not parse n transform function.
The bug occurred when I searched for the audio and video paths separately like best audioonly  and best videoonly . before it worked. But this is the first time he has died
Environment

@distube/ytdl-core version: Latest
Node.js version: 20
Operating system: linux

please check #22

please check #22

soya-daizu/ytdl-core#sig-patch gone 🥲

Please upload your file, this bug should be fixed on latest version (4.13.5)

Please upload your file, this bug should be fixed on latest version (4.13.5)

file ? bug file or my code?
im using the latest version
and got this bug -_-
And what makes me wonder. I am only looking for video links and audio only.
2 weeks ago since the new release it has not been a problem at all (till today) just got the bug

its work again ? 😂

Got same error: WARNING: Could not parse n transform function.
Able to get audio/video format (not sure any error during this) but instant 403 miniget error on download on 3 videos
File:
1722338287104-base.zip
Environment:
@distube/ytdl-core version: 4.13.5
Node.js version: 20.16.0
Operating system: Windows 10

Got same error: WARNING: Could not parse n transform function. Able to get audio/video format (not sure any error during this) but instant 403 miniget error on download on 3 videos
File:<PHONE_NUMBER>104-base.zip
Environment: @distube/ytdl-core version: 4.13.5 Node.js version: 20.16.0 Operating system: Windows 10

its totally work for me now
idk why

Some rrr links direct to other now, when clicked, he changes to rrr1 links