how to format buffer on save using lsp formatter

I want to make emacs format the buffer using lsp formatter on save.
I tried to enable (format +onsave) in init.el and set +format-with-lsp to t, but only +format/buffer can invoke lsp format and format-on-save still use some third party formatters(eg. prettier for js).
I also tried (add-hook 'js2-mode-hook #'+format|enable-on-save) but doesn't work.
How can I correctly set lsp format on save?

If you see a function called +format|enable-on-save, it indicates you're on a very, very old version of Doom. I did away with the X|Y naming convention more than a year ago.
If you upgrade Doom to the latest version, all of that module's commands, +format/buffer, +format/region and +format/region-or-buffer will use LSP's formatter if +format-with-lsp is non-nil and the LSP server supports it.
If it still isn't formatting with LSP, it's because the LSP server doesn't support it. Try M-x lsp-format-buffer. Does it work?

If you see a function called +format|enable-on-save, it indicates you're on a very, very old version of Doom. I did away with the X|Y naming convention more than a year ago.
If you upgrade Doom to the latest version, all of that module's commands, +format/buffer, +format/region and +format/region-or-buffer will use LSP's formatter if +format-with-lsp is non-nil and the LSP server supports it and you have the necessary dependencies (prettier, in this case) installed. Enabling :editor (format +onsave) will cause the buffer to be formatted when you save.
If it still isn't formatting with LSP, it's because the LSP server doesn't support it. Try M-x lsp-format-buffer. Does it work?

Thanks! +format/buffer does use LSP formatter when I enable (format +onsave). Format-on-save still tried to use prettier yet. I looked at before-save-hook, it would trigger format-all-buffer, and it seems using prettier instead of LSP formatter.
Should I remove format-all-buffer from before-save-hook? cause I only want to let LSP format buffers.

I'm seeing a similar issue when trying to format some Go code upon saving. Instead of LSP being used, gofmt is (I assume this is where). M-x lsp-format-buffer works and I have set (go +lsp) in config.el. Am I missing anything?
Messages buffer when trying to save:
Reformatted with gofmt
Error: (error "Invalid rcs patch or internal error in +format--apply-rcs-patch")

Same issue for me with Ruby and Solargraph. +format/buffer uses LSP while format-on-save uses rufo.

I am seeing this as well with rufo and +format/buffer

I am also seeing this issue. I think it would be possible by adding a local hook with:
(add-hook 'before-save-hook #'+format/buffer nil t)

like [here](https://github.com/systemctl603/doom-emacs/commit/41d9e4b161d082468891adc3280e893e5137afaa)

@systemctl603 I'll give that a try and see if that fixes it for me

@jsmestad It has to be placed in the file modules/editor/format/config.el, btw.


Added readme and create-interfaces-interactive script

Description
I updated the readme to include the latest packages as well as a brief description of each of them. I also added a section on how to start out and contributing.
I added an interactive CLI script in generate-coa-pdf-template that allows the user to enter the filepath to an updated schema.
Fixes #114
Type of change

[X] New feature (non-breaking change which adds functionality)

Superseded by #116


Fix API DB left open

the player_db TinyDB object in api.py is left open. There should be a dedicated db manager (db.py) to open and close the files, which can be run from main.py

Added api_utils.py to separate flask routing from API logic. I also made sure to close out the db object as well.


Chain coherent dependencies up through Extensions to EF Core packages

should reduce incoherent PRs we get from darc
update dependencies from 5 repos to the latest coherent set

/fyi @davidfowl

Looks like something is pulling this out of coherence. Not ready for prime time.

@NTaylorMullen can anything be done with this PR before we depend on the new SDK about the errors using "preview" in this iteration and the complaints about not using preview in the previous build (https://dev.azure.com/dnceng/public/_build/results?buildId=136340&view=results which has been deleted ☹)?

@NTaylorMullen what leads to the following test failures? I'm not pulling in a new SDK but am getting new AspNetCore-Tooling bits. Is some reaction needed there? (May be able to avoid pulling those packages up for now.)
Failed   Microsoft.AspNetCore.Blazor.Build.Test.BindRazorIntegrationTest.Render_BindDuplicates_ReportsDiagnostic
  Error Message:
   Microsoft.AspNetCore.Blazor.Build.Test.RazorIntegrationTestBase+CompilationFailedException : Compilation failed:
  (22,2): error CS8652: The feature 'nullable reference types' is currently in Preview and *unsupported*. To use Preview features, use the 'preview' language version.
  (29,2): error CS8652: The feature 'nullable reference types' is currently in Preview and *unsupported*. To use Preview features, use the 'preview' language version.
  (10,5): hidden CS8019: Unnecessary using directive.
  (2,1): hidden CS8019: Unnecessary using directive.
  (14,5): hidden CS8019: Unnecessary using directive.
  (13,5): hidden CS8019: Unnecessary using directive.
  (11,5): hidden CS8019: Unnecessary using directive.
  (12,5): hidden CS8019: Unnecessary using directive.

  File :
  // <auto-generated/>
  #pragma warning disable 1591
  #pragma warning disable 0414
  #pragma warning disable 0649
  #pragma warning disable 0169

  namespace Test
  {
      #line hidden
      using System;
      using System.Collections.Generic;
      using System.Linq;
      using System.Threading.Tasks;
      using Microsoft.AspNetCore.Components;
      public class TestComponent : Microsoft.AspNetCore.Components.ComponentBase
      {
          #pragma warning disable 1998
          protected override void BuildRenderTree(Microsoft.AspNetCore.Components.RenderTree.RenderTreeBuilder builder)
          {
          }
          #pragma warning restore 1998
  #nullable restore
  #line 2 "x:\dir\subdir\Test\TestComponent.cshtml"

      public string ParentValue { get; set; } = "hi";

  #line default
  #line hidden
  #nullable disable
      }
  }
  #pragma warning restore 1591

  File :

  using System;
  using Microsoft.AspNetCore.Components;

  namespace Test
  {
      [BindElement("div", "value", "myvalue2", "myevent2")]
      [BindElement("div", "value", "myvalue", "myevent")]
      public static class BindAttributes
      {
      }
  }

  Stack Trace:
     at Microsoft.AspNetCore.Blazor.Build.Test.RazorIntegrationTestBase.CompileToAssembly(CompileToCSharpResult cSharpResult, Boolean throwOnFailure) in /_/src/Components/Blazor/Build/test/RazorIntegrationTestBase.cs:line 323
     at Microsoft.AspNetCore.Blazor.Build.Test.RazorIntegrationTestBase.CompileToCSharp(String cshtmlRelativePath, String cshtmlContent) in /_/src/Components/Blazor/Build/test/RazorIntegrationTestBase.cs:line 207
     at Microsoft.AspNetCore.Blazor.Build.Test.RazorIntegrationTestBase.CompileToCSharp(String cshtmlContent) in /_/src/Components/Blazor/Build/test/RazorIntegrationTestBase.cs:line 173
     at Microsoft.AspNetCore.Blazor.Build.Test.BindRazorIntegrationTest.Render_BindDuplicates_ReportsDiagnostic() in /_/src/Components/Blazor/Build/test/BindRazorIntegrationTest.cs:line 253

The compilation tests aren't using C# preview. I.e. this needs to be updated a lot like how AspNetCore-Tooling's was here

@NTaylorMullen one thought: Could SuppressNullabilityEnforcement = true and AllowUsingVariableDeclarations = false get the ~60 failing tests to pass with the latest AspNetCore-Tooling packages?

@NTaylorMullen one thought: Could SuppressNullabilityEnforcement = true and AllowUsingVariableDeclarations = false get the ~60 failing tests to pass with the latest AspNetCore-Tooling packages?

I'd first try with the updating the C# compilation options.

Ah, is it Razor compilation causing the issue with nullable refs rather than the repo source (which is referring to 8.0)
Microsoft.AspNetCore.Mvc.Razor.RuntimeCompilation.CompilationFailedException: One or more compilation failures occurred:
error CS8652: The feature 'nullable reference types' is currently in Preview and *unsupported*.
 To use Preview features, use the 'preview' language version.
error CS8652: The feature 'nullable reference types' is currently in Preview and *unsupported*.
 To use Preview features, use the 'preview' language version.
error CS8652: The feature 'nullable reference types' is currently in Preview and *unsupported*.
 To use Preview features, use the 'preview' language version.
error CS8652: The feature 'nullable reference types' is currently in Preview and *unsupported*.
 To use Preview features, use the 'preview' language version.

/cc @rynowak

@NTaylorMullen @pranavkm @ajaybhargavb @rynowak this PR is hitting additional breaking changes from the AspNetCore-Tooling repo. What reaction is needed in this repo?
Note the test failures are consistent across the Test … jobs. The Windows x64 problem is yarn flakiness and can be ignored for the sake of this conversation. Please also ignore the Microsoft.AspNetCore.TargetingPackTests.PlatformManifestListsAllFiles and Microsoft.AspNetCore.SharedFxTests.SharedFrameworkContainsExpectedFiles test failures; I'm looking into those.
Two core failures:

five tests are failing with a consistent "text versus markup" assertion failure:

Microsoft.AspNetCore.Blazor.Build.Test.GenericComponentRazorIntegrationTest.Render_GenericComponent_WithChildContent
Microsoft.AspNetCore.Blazor.Build.Test.BindRazorIntegrationTest.Render_BindToElementFallback_SpecifiesValueAndChangeEvent_BodyContent
Microsoft.AspNetCore.Blazor.Build.Test.ChildContentRazorIntegrationTest.Render_BodyChildContent_Generic
Microsoft.AspNetCore.Blazor.Build.Test.ChildContentRazorIntegrationTest.Render_BodyChildContent_Recursive
Microsoft.AspNetCore.Blazor.Build.Test.RenderingRazorIntegrationTest.SupportsCSharpExpressions

Templates.Test.MvcTemplateTest.MvcTemplate_NoAuthImplAsync(languageOverride: "F#") is failing because the generated code uses nullable reference types and compilation is done without preview features for some reason.

Example details on the first failure:
Error Message:
   Assert.Collection() Failure
  Collection: [Component: (seq=0, len=3) Test.GenericContext`1[System.Int32], Attribute: (seq=1, id=0) 'Items'='System.Collections.Generic.List`1[System.Int32]', Attribute: (seq=2, id=0) 'ChildContent'='Microsoft.AspNetCore.Components.RenderFragment`1[Test.GenericContext`1+Context[System.Int32]]', Markup: (seq=3, len=n/a) \n  , Element: (seq=4, len=2) div, ...]
  Error during comparison of item at index 3
  Inner exception: Assert.Equal() Failure
          Expected: Text
          Actual:   Markup
  Stack Trace:
     at Microsoft.AspNetCore.Components.Test.Helpers.AssertFrame.Whitespace(RenderTreeFrame frame, Nullable`1 sequence) in /_/src/Components/Shared/test/AssertFrame.cs:line 115
     at Microsoft.AspNetCore.Blazor.Build.Test.GenericComponentRazorIntegrationTest.<>c.<Render_GenericComponent_WithChildContent>b__7_4(RenderTreeFrame frame) in /_/src/Components/Blazor/Build/test/GenericComponentRazorIntegrationTest.cs:line 174
     at Microsoft.AspNetCore.Blazor.Build.Test.GenericComponentRazorIntegrationTest.Render_GenericComponent_WithChildContent() in /_/src/Components/Blazor/Build/test/GenericComponentRazorIntegrationTest.cs:line 182

Standard Output Messages:
Use this output when opening an issue
Main source file (component):
<GenericContext TItem=int Items="@(new List<int>() { 1, 2, })">
  <div>@(context.Item * context.Index)</div>
</GenericContext>

Generated C#:
// <auto-generated/>
#pragma warning disable 1591
namespace Test
{
    #line hidden
    using System;
    using System.Collections.Generic;
    using System.Linq;
    using System.Threading.Tasks;
    using Microsoft.AspNetCore.Components;
    public class TestComponent : Microsoft.AspNetCore.Components.ComponentBase
    {
        #pragma warning disable 1998
        protected override void BuildRenderTree(Microsoft.AspNetCore.Components.RenderTree.RenderTreeBuilder builder)
        {
            builder.OpenComponent<Test.GenericContext<int>>(0);
            builder.AddAttribute(1, "Items", Microsoft.AspNetCore.Components.RuntimeHelpers.TypeCheck<System.Collections.Generic.List<int>>(new List<int>() { 1, 2, }));
            builder.AddAttribute(2, "ChildContent", (Microsoft.AspNetCore.Components.RenderFragment<Test.GenericContext<int>.Context>)((context) => (builder2) => {
                builder2.AddMarkupContent(3, "\n  ");
                builder2.OpenElement(4, "div");
                builder2.AddContent(5, context.Item * context.Index);
                builder2.CloseElement();
                builder2.AddMarkupContent(6, "\n");
            }
            ));
            builder.CloseComponent();
        }
        #pragma warning restore 1998
    }
}
#pragma warning restore 1591

Details on the second failure:
Microsoft.AspNetCore.Mvc.Razor.RuntimeCompilation.CompilationFailedException: One or more compilation failures occurred:
   pfb5yk2i.dfq(15,2): error CS8652: The feature 'nullable reference types' is currently in Preview and *unsupported*. To use Preview features, use the 'preview' language version.
   pfb5yk2i.dfq(21,2): error CS8652: The feature 'nullable reference types' is currently in Preview and *unsupported*. To use Preview features, use the 'preview' language version.
   pfb5yk2i.dfq(29,2): error CS8652: The feature 'nullable reference types' is currently in Preview and *unsupported*. To use Preview features, use the 'preview' language version.
   pfb5yk2i.dfq(36,2): error CS8652: The feature 'nullable reference types' is currently in Preview and *unsupported*. To use Preview features, use the 'preview' language version.
      at Microsoft.AspNetCore.Mvc.Razor.RuntimeCompilation.RuntimeViewCompiler.CompileAndEmit(RazorCodeDocument codeDocument, String generatedCode)
      at Microsoft.AspNetCore.Mvc.Razor.RuntimeCompilation.RuntimeViewCompiler.CompileAndEmit(String relativePath)
      at Microsoft.AspNetCore.Mvc.Razor.RuntimeCompilation.RuntimeViewCompiler.OnCacheMiss(String normalizedPath)
   --- End of stack trace from previous location where exception was thrown ---
      at Microsoft.AspNetCore.Mvc.Razor.Compilation.DefaultRazorPageFactoryProvider.CreateFactory(String relativePath)
      at Microsoft.AspNetCore.Mvc.Razor.RazorViewEngine.CreateCacheResult(HashSet`1 expirationTokens, String relativePath, Boolean isMainPage)
      at Microsoft.AspNetCore.Mvc.Razor.RazorViewEngine.OnCacheMiss(ViewLocationExpanderContext expanderContext, ViewLocationCacheKey cacheKey)
      at Microsoft.AspNetCore.Mvc.Razor.RazorViewEngine.LocatePageFromViewLocations(ActionContext actionContext, String pageName, Boolean isMainPage)
      at Microsoft.AspNetCore.Mvc.Razor.RazorViewEngine.FindView(ActionContext context, String viewName, Boolean isMainPage)
      at Microsoft.AspNetCore.Mvc.ViewEngines.CompositeViewEngine.FindView(ActionContext context, String viewName, Boolean isMainPage)
      at Microsoft.AspNetCore.Mvc.ViewFeatures.ViewResultExecutor.FindView(ActionContext actionContext, ViewResult viewResult)
      at Microsoft.AspNetCore.Mvc.ViewFeatures.ViewResultExecutor.ExecuteAsync(ActionContext context, ViewResult result)
      at Microsoft.AspNetCore.Mvc.ViewResult.ExecuteResultAsync(ActionContext context)
      at Microsoft.AspNetCore.Mvc.Infrastructure.ResourceInvoker.InvokeResultAsync(IActionResult result)
      at Microsoft.AspNetCore.Mvc.Infrastructure.ResourceInvoker.InvokeNextResultFilterAsync[TFilter,TFilterAsync]()
      at Microsoft.AspNetCore.Mvc.Infrastructure.ResourceInvoker.Rethrow(ResultExecutedContext context)
      at Microsoft.AspNetCore.Mvc.Infrastructure.ResourceInvoker.ResultNext[TFilter,TFilterAsync](State& next, Scope& scope, Object& state, Boolean& isCompleted)
      at Microsoft.AspNetCore.Mvc.Infrastructure.ResourceInvoker.InvokeResultFilters()
      at Microsoft.AspNetCore.Mvc.Infrastructure.ResourceInvoker.InvokeNextResourceFilter()
      at Microsoft.AspNetCore.Mvc.Infrastructure.ResourceInvoker.Rethrow(ResourceExecutedContext context)
      at Microsoft.AspNetCore.Mvc.Infrastructure.ResourceInvoker.Next(State& next, Scope& scope, Object& state, Boolean& isCompleted)
      at Microsoft.AspNetCore.Mvc.Infrastructure.ResourceInvoker.InvokeFilterPipelineAsync()
      at Microsoft.AspNetCore.Mvc.Infrastructure.ResourceInvoker.InvokeAsync()
      at Microsoft.AspNetCore.Routing.EndpointMiddleware.Invoke(HttpContext httpContext)
      at Microsoft.AspNetCore.Authorization.AuthorizationMiddleware.Invoke(HttpContext context)
      at Microsoft.AspNetCore.Routing.EndpointRoutingMiddleware.Invoke(HttpContext httpContext)
      at Microsoft.AspNetCore.StaticFiles.StaticFileMiddleware.Invoke(HttpContext context)
      at Microsoft.AspNetCore.Diagnostics.DeveloperExceptionPageMiddleware.Invoke(HttpContext context)
   \x1b[40m\x1b[32minfo\x1b[39m\x1b[22m\x1b[49m: Microsoft.AspNetCore.Hosting.Internal.GenericWebHostService[2]

five tests are failing with a consistent "text versus markup" assertion failure

@dougbu, we changed how we handle newlines in static HTML recently. Regenerating baselines should fix it.

@ajaybhargavb dotnet test /p:GenerateBaselines=true hits the same failures and doesn't update any files.
I also tried changing a few AssertFrame.Text(...) calls to AssertFrame.Markup(...) in the affected tests but that didn't fix anything. What are the exact changes needed on this branch to get those six tests working?

Also, what aboutTemplates.Test.MvcTemplateTest.MvcTemplate_NoAuthImplAsync(languageOverride: "F#") failing? This failure looks similar to those my LanguageVersion.Preview change fixed elsewhere. Is it possible to update the F# language version or to change the template so that it does not use nullable reference types?

I've updated the branch to see if shared framework failures go away. While the new build is going, https://dev.azure.com/dnceng/public/_build/results?buildId=138906 should be available to look at the six failures I listed above.

I didn't fix the shared framework tests with the latest iteration. https://dev.azure.com/dnceng/public/_build/results?buildId=139102 is wrapping up with a similar set of failures to https://dev.azure.com/dnceng/public/_build/results?buildId=138906 ☹

nullablity issues are caused by this PR https://github.com/aspnet/AspNetCore-Tooling/pull/349
/cc @NTaylorMullen
Would pulling in a more recent sdk (and C# compiler) fix it? e.g. I used the Range [..^1] stuff locally happily, but then that failed when I submitted a PR with it as the CI was behind.

@ajaybhargavb can you help @dougbu fix up the tests due to the new AspNetCore-Toolign changes you made? It's a little more than just re-generating baselines sadly: https://github.com/aspnet/AspNetCore/blob/91dcbd44c10af893374cfb36dc7a009caa4818d0/src/Components/Blazor/Build/test/ChildContentRazorIntegrationTest.cs#L130-L138

FYI we can't get SignalR's reactions to the new JSON parser in for preview4 until this gets in, so it's a high priority. cc @BrennanConroy

macOS and Linux failures look to be issues trying to build System.Runtime.WindowsRuntime.dll for them
Native image /Users/vsts/agent/2.149.2/work/1/s/artifacts/bin/Microsoft.AspNetCore.App.Runtime/Release/netcoreapp3.0
/osx-x64/System.Runtime.WindowsRuntime.UI.Xaml.dll generated successfully.
  Error: Could not load file or assembly 'Windows, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=null, ContentType=WindowsRuntime'. The system cannot find the file specified.
   (0x80070002)
  Error compiling /Users/vsts/agent/2.149.2/work/1/s/.nuget/packages/runtime.osx-x64.microsoft.netcore.app/3.0.0-preview4-27529-11/
  runtimes/osx-x64/lib/netcoreapp3.0/System.Runtime.WindowsRuntime.dll: Could not find or load a specific file. (0x80131621)
  Error: compilation failed for "/Users/vsts/agent/2.149.2/work/1/s/.nuget/packages/runtime.osx-x64.microsoft.netcore.app/3.0.0-preview4-27529-11/
  runtimes/osx-x64/lib/netcoreapp3.0/System.Runtime.WindowsRuntime.dll" (0x80131621)
/Users/vsts/agent/2.149.2/work/1/s/src/Framework/src/Microsoft.AspNetCore.App.Runtime.csproj(340,5): error MSB3073: The command ""/Users/vsts/agent/2.149.2/work/1/s/artifacts/obj/Microsoft.AspNetCore.App.Runtime/Release/netcoreapp3.0/osx-x64/crossgen/crossgen" -nologo -readytorun -in
"/Users/vsts/agent/2.149.2/work/1/s/.nuget/packages/runtime.osx-x64.microsoft.netcore.app/3.0.0-preview4-27529-11/runtimes/osx-x64/lib/netcoreapp3.0/System.Runtime.WindowsRuntime.dll" -out
"/Users/vsts/agent/2.149.2/work/1/s/artifacts/bin/Microsoft.AspNetCore.App.Runtime/Release/netcoreapp3.0/osx-x64/System.Runtime.WindowsRuntime.dll" -jitpath
"/Users/vsts/agent/2.149.2/work/1/s/artifacts/obj/Microsoft.AspNetCore.App.Runtime/Release/netcoreapp3.0/osx-x64/crossgen/libclrjit.dylib"
<EMAIL_ADDRESS>exited with code 33.

Windows build failure is yarn
F:\workspace\_work\1\s\src\Shared\E2ETesting\E2ETesting.targets(14,5):
error MSB6006: "yarn" exited with code 1. [F:\workspace\_work\1\s\src\ProjectTemplates\test\ProjectTemplates.Tests.csproj]
F:\workspace\_work\1\s\src\Shared\E2ETesting\E2ETesting.targets(14,5):
error MSB6006: "yarn" exited with code 1. [F:\workspace\_work\1\s\src\Components\test\E2ETest\Microsoft.AspNetCore.Components.E2ETests.csproj]

And test failures are packaging
Microsoft.AspNetCore.TargetingPackTests.PlatformManifestListsAllFiles

Assert.Empty() Failure
Collection: ["System.Runtime.CompilerServices.Unsafe", "System.Security.AccessControl", "System.Security.Cryptography.Cng"]

   at Microsoft.AspNetCore.TargetingPackTests.PlatformManifestListsAllFiles() in /_/src/Framework/test/TargetingPackTests.cs:line 66

Microsoft.AspNetCore.SharedFxTests.SharedFrameworkContainsExpectedFiles

Assert.Empty() Failure
Collection: ["System.Runtime.CompilerServices.Unsafe", "System.Security.AccessControl", "System.Security.Cryptography.Cng"]

   at Microsoft.AspNetCore.SharedFxTests.SharedFrameworkContainsExpectedFiles() in /_/src/Framework/test/SharedFxTests.cs:line 54

@ajaybhargavb @NTaylorMullen @pranavkm @rynowak please help with the latest breaking changes from AspNetCore-Tooling. What additional reaction is needed in this PR  to handle the latest from that repo?
Is the necessary change just removing the getter from the named properties?
F:\workspace\_work\1\s\src\Mvc\Mvc.Razor.RuntimeCompilation\src\FileProviderRazorProjectFileSystem.cs(37,42): error CS0672: Member 'FileProviderRazorProjectFileSystem.GetItem(string)' overrides obsolete member 'RazorProject.GetItem(string)'. Add the Obsolete attribute to 'FileProviderRazorProjectFileSystem.GetItem(string)'. [F:\workspace\_work\1\s\src\Mvc\Mvc.Razor.RuntimeCompilation\src\Microsoft.AspNetCore.Mvc.Razor.RuntimeCompilation.csproj]
F:\workspace\_work\1\s\src\Mvc\Mvc.Razor.RuntimeCompilation\src\FileProviderRazorProjectFileSystem.cs(13,20): error CS0534: 'FileProviderRazorProjectFileSystem' does not implement inherited abstract member 'RazorProject.GetItem(string, string)' [F:\workspace\_work\1\s\src\Mvc\Mvc.Razor.RuntimeCompilation\src\Microsoft.AspNetCore.Mvc.Razor.RuntimeCompilation.csproj]
F:\workspace\_work\1\s\src\Mvc\Mvc.Razor.RuntimeCompilation\src\PageDirectiveFeature.cs(80,46): error CS0672: Member 'PageDirectiveFeature.EmptyRazorProjectFileSystem.GetItem(string)' overrides obsolete member 'RazorProject.GetItem(string)'. Add the Obsolete attribute to 'PageDirectiveFeature.EmptyRazorProjectFileSystem.GetItem(string)'. [F:\workspace\_work\1\s\src\Mvc\Mvc.Razor.RuntimeCompilation\src\Microsoft.AspNetCore.Mvc.Razor.RuntimeCompilation.csproj]
F:\workspace\_work\1\s\src\Mvc\Mvc.Razor.RuntimeCompilation\src\PageDirectiveFeature.cs(68,23): error CS0534: 'PageDirectiveFeature.EmptyRazorProjectFileSystem' does not implement inherited abstract member 'RazorProject.GetItem(string, string)' [F:\workspace\_work\1\s\src\Mvc\Mvc.Razor.RuntimeCompilation\src\Microsoft.AspNetCore.Mvc.Razor.RuntimeCompilation.csproj]
F:\workspace\_work\1\s\src\Components\Blazor\Build\test\Razor\VirtualProjectFileSystem.cs(22,42): error CS0672: Member 'VirtualRazorProjectFileSystem.GetItem(string)' overrides obsolete member 'RazorProject.GetItem(string)'. Add the Obsolete attribute to 'VirtualRazorProjectFileSystem.GetItem(string)'. [F:\workspace\_work\1\s\src\Components\Blazor\Build\test\Microsoft.AspNetCore.Blazor.Build.Tests.csproj]
F:\workspace\_work\1\s\src\Components\Blazor\Build\test\Razor\VirtualProjectFileSystem.cs(11,20): error CS0534: 'VirtualRazorProjectFileSystem' does not implement inherited abstract member 'RazorProject.GetItem(string, string)' [F:\workspace\_work\1\s\src\Components\Blazor\Build\test\Microsoft.AspNetCore.Blazor.Build.Tests.csproj]

I'm looking at this.

actually @NTaylorMullen just showed up and he is going to do it right now.

Had issues building locally (working on those issues now), for the interim I fixed the issues that jumped out in regards to the GetItem Obsoletion from AspNetCore-Tooling. Pushed those changes and wIll monitor the PR build to ensure that I didn't miss anything

@NTaylorMullen thanks very much for your commits. Looks like they were necessary but not sufficient:
F:\workspace\_work\1\s\src\Components\Blazor\Build\test\Razor\VirtualProjectFileSystem.cs(22,42): error CS0672: Member 'VirtualRazorProjectFileSystem.GetItem(string)' overrides obsolete member 'RazorProject.GetItem(string)'. Add the Obsolete attribute to 'VirtualRazorProjectFileSystem.GetItem(string)'. [F:\workspace\_work\1\s\src\Components\Blazor\Build\test\Microsoft.AspNetCore.Blazor.Build.Tests.csproj]
F:\workspace\_work\1\s\src\Components\Blazor\Build\test\Razor\VirtualProjectFileSystem.cs(11,20): error CS0534: 'VirtualRazorProjectFileSystem' does not implement inherited abstract member 'RazorProject.GetItem(string, string)' [F:\workspace\_work\1\s\src\Components\Blazor\Build\test\Microsoft.AspNetCore.Blazor.Build.Tests.csproj]

More shared framework woes :(
 [xUnit.net 00:00:00.34]     Microsoft.AspNetCore.TargetingPackTests.PlatformManifestListsAllFiles [FAIL]
 [xUnit.net 00:00:00.38]     Microsoft.AspNetCore.SharedFxTests.SharedFrameworkContainsExpectedFiles [FAIL]

Looks like the core of the problem is that these three assemblies are now in the shared fx but were not expected to be. (cc @JunTaoLuo)

System.Runtime.CompilerServices.Unsafe
System.Security.AccessControl
System.Security.Cryptography.Cng

macOS failure is yarn issue; transient?
SignalR/clients/ts/FunctionalTests/SignalR.Npm.FunctionalTests.npmproj(23,5):
 error MSB6006: "yarn" exited with code 1.

Just needs a restart?

macOS
LargeUpload(maxRequestBufferSize:<PHONE_NUMBER>854775807, connectionAdapter: False, expectPause: False)

System.IO.IOException : Unable to read data from the transport connection: Broken pipe.
---- System.Net.Sockets.SocketException : Broken pipe

Stack trace
   at Microsoft.AspNetCore.Server.Kestrel.FunctionalTests.MaxRequestBufferSizeTests.<>c__DisplayClass5_2.<<LargeUpload>b__0>d.MoveNext() in /_/src/Servers/Kestrel/test/FunctionalTests/MaxRequestBufferSizeTests.cs:line 152
--- End of stack trace from previous location where exception was thrown ---
   at Microsoft.AspNetCore.Server.Kestrel.FunctionalTests.MaxRequestBufferSizeTests.LargeUpload(Nullable`1 maxRequestBufferSize, Boolean connectionAdapter, Boolean expectPause) in /_/src/Servers/Kestrel/test/FunctionalTests/MaxRequestBufferSizeTests.cs:line 203
--- End of stack trace from previous location where exception was thrown ---
----- Inner Stack Trace -----

macOS
LargeUpload(maxRequestBufferSize:<PHONE_NUMBER>854775807, connectionAdapter: False, expectPause: False)

System.IO.IOException : Unable to read data from the transport connection: Broken pipe.
---- System.Net.Sockets.SocketException : Broken pipe

Stack trace
   at Microsoft.AspNetCore.Server.Kestrel.FunctionalTests.MaxRequestBufferSizeTests.<>c__DisplayClass5_2.<<LargeUpload>b__0>d.MoveNext() in /_/src/Servers/Kestrel/test/FunctionalTests/MaxRequestBufferSizeTests.cs:line 152
--- End of stack trace from previous location where exception was thrown ---
   at Microsoft.AspNetCore.Server.Kestrel.FunctionalTests.MaxRequestBufferSizeTests.LargeUpload(Nullable`1 maxRequestBufferSize, Boolean connectionAdapter, Boolean expectPause) in /_/src/Servers/Kestrel/test/FunctionalTests/MaxRequestBufferSizeTests.cs:line 203
--- End of stack trace from previous location where exception was thrown ---
----- Inner Stack Trace -----

Looks like that test had its values changed 14 hrs ago https://github.com/aspnet/AspNetCore/pull/8956/files /cc @halter73

FYI, the problem is that yarn hides console output so we weren't seeing the actual failure. Running npm tests locally on a mac shows an issue in Process which is likely fixed by https://github.com/dotnet/corefx/pull/36551. This is the same issue we are now seeing in the other tests.
@natemcmaster We need a way for yarn to show output

Oof, macOS is unhappy with 106 Failed tests
All look to be like
System.ComponentModel.Win32Exception : Operation not supported on socket

Stack trace
   at System.Diagnostics.Process.EnsureInitialized()
   at System.Diagnostics.Process.StartCore(ProcessStartInfo startInfo)
   at System.Diagnostics.Process.Start()
   at Microsoft.DotNet.Watcher.Internal.ProcessRunner.RunAsync(ProcessSpec processSpec, CancellationToken cancellationToken) in /_/src/Tools/dotnet-watch/src/Internal/ProcessRunner.cs:line 58
   at Microsoft.DotNet.Watcher.Internal.MsBuildFileSetFactory.CreateAsync(CancellationToken cancellationToken) in /_/src/Tools/dotnet-watch/src/Internal/MsBuildFileSetFactory.cs:line 83
   at Microsoft.AspNetCore.Testing.TaskExtensions.TimeoutAfter[T](Task`1 task, TimeSpan timeout, String filePath, Int32 lineNumber)
   at Microsoft.DotNet.Watcher.Tools.Tests.MsBuildFileSetFactoryTest.GetFileSet(MsBuildFileSetFactory filesetFactory) in /_/src/Tools/dotnet-watch/test/MsBuildFileSetFactoryTest.cs:line 279
   at Microsoft.DotNet.Watcher.Tools.Tests.MsBuildFileSetFactoryTest.MultiTfm() in /_/src/Tools/dotnet-watch/test/MsBuildFileSetFactoryTest.cs:line 128
--- End of stack trace from previous location where exception was thrown ---

@BrennanConroy guessing that's the Process issue you highlighted? (hopefully fixed by dotnet/corefx#36551)

Yeah I think they're the same. We'll see when those changes get to use.

FYI :up::date: to pull in latest dependencies, rebase on master, and squash commits.
Removed @JunTaoLuo and my most recent commits because problems in dependencies should now be resolved.

:up::date: again.
@roji last commit got things building locally. Could you double-check it?

@roji I worked around the new EF analyzer in 7e51698d2212 to suppress the following warnings (which are errors in this repo). Please file an issue if further or different changes are needed in this repo.
F:\workspace\_work\1\s\src\Identity\EntityFrameworkCore\test\EF.Test\Utilities\ScratchDatabaseFixture.cs(16,30): error EF1001: Microsoft.EntityFrameworkCore.Internal.LazyRef<Microsoft.AspNetCore.Identity.EntityFrameworkCore.Test.Utilities.SqlServerTestStore> is an internal API that supports the Entity Framework Core infrastructure and not subject to the same compatibility standards as public APIs. It may be changed or removed without notice in any release. [F:\workspace\_work\1\s\src\Identity\EntityFrameworkCore\test\EF.Test\Microsoft.AspNetCore.Identity.EntityFrameworkCore.Test.csproj]
F:\workspace\_work\1\s\src\Identity\EntityFrameworkCore\test\EF.Test\Utilities\ScratchDatabaseFixture.cs(19,54): error EF1001: Microsoft.EntityFrameworkCore.Internal.LazyRef<Microsoft.AspNetCore.Identity.EntityFrameworkCore.Test.Utilities.SqlServerTestStore> is an internal API that supports the Entity Framework Core infrastructure and not subject to the same compatibility standards as public APIs. It may be changed or removed without notice in any release. [F:\workspace\_work\1\s\src\Identity\EntityFrameworkCore\test\EF.Test\Microsoft.AspNetCore.Identity.EntityFrameworkCore.Test.csproj]
F:\workspace\_work\1\s\src\Identity\EntityFrameworkCore\test\EF.Test\Utilities\ScratchDatabaseFixture.cs(23,28): error EF1001: Microsoft.EntityFrameworkCore.Internal.LazyRef<Microsoft.AspNetCore.Identity.EntityFrameworkCore.Test.Utilities.SqlServerTestStore> is an internal API that supports the Entity Framework Core infrastructure and not subject to the same compatibility standards as public APIs. It may be changed or removed without notice in any release. [F:\workspace\_work\1\s\src\Identity\EntityFrameworkCore\test\EF.Test\Microsoft.AspNetCore.Identity.EntityFrameworkCore.Test.csproj]
F:\workspace\_work\1\s\src\Identity\EntityFrameworkCore\test\EF.Test\Utilities\ScratchDatabaseFixture.cs(25,28): error EF1001: Microsoft.EntityFrameworkCore.Internal.LazyRef<Microsoft.AspNetCore.Identity.EntityFrameworkCore.Test.Utilities.SqlServerTestStore> is an internal API that supports the Entity Framework Core infrastructure and not subject to the same compatibility standards as public APIs. It may be changed or removed without notice in any release. [F:\workspace\_work\1\s\src\Identity\EntityFrameworkCore\test\EF.Test\Microsoft.AspNetCore.Identity.EntityFrameworkCore.Test.csproj]

@rynowak I'm not sure what changed where but the AzureAD samples can't find AddMvc():
F:\workspace\_work\1\s\src\Azure\AzureAD\samples\AzureADB2CSample\Startup.cs(33,22): error CS1061: 'IServiceCollection' does not contain a definition for 'AddMvc' and no accessible extension method 'AddMvc' accepting a first argument of type 'IServiceCollection' could be found (are you missing a using directive or an assembly reference?) [F:\workspace\_work\1\s\src\Azure\AzureAD\samples\AzureADB2CSample\AzureADB2CSample.csproj]
F:\workspace\_work\1\s\src\Azure\AzureAD\samples\AzureADSample\Startup.cs(33,22): error CS1061: 'IServiceCollection' does not contain a definition for 'AddMvc' and no accessible extension method 'AddMvc' accepting a first argument of type 'IServiceCollection' could be found (are you missing a using directive or an assembly reference?) [F:\workspace\_work\1\s\src\Azure\AzureAD\samples\AzureADSample\AzureADSample.csproj]

Though everything looks fine in VS locally on this branch, I'm doubtful my latest push to this branch will build correctly. Please have a look.

AspNetCore-ci (Test: Windows Server 2016 x64) failure is a general malaise with all PRs currently
appverif.exe : AVRF: Warning: Verifier not enabled for target [signalrclienttests.exe].

##[error]appverif.exe : AVRF: Warning: Verifier not enabled for target [signalrclienttests.exe].
##[error]At F:\workspace\_work\1\s\.azure\pipelines\tools\SetupTestEnvironment.ps1:57 char:5

and
SSL Certificate successfully added

SSL Certificate deletion failed, Error: 2
The system cannot find the file specified.

SSL Certificate successfully added
C:\Program Files (x86)\IIS Express\config\schema\ doesn't exist
C:\Program Files\IIS Express\config\schema\ doesn't exist
C:\Program Files\IIS Express\config\schema\ doesn't exist
C:\Windows\system32\inetsrv\config\schema\ doesn't exist

Abandoning PR validation build since longest leg failed quickly.

AspNetCore-ci (Test: Windows Server 2016 x64) failed for same reasons
Steps Setup IISExpress test certificates and schema and Stop AppVerifier

Ignore the Windows test build, something is broken in AzDo right now. I say if everything else passes we should force the PR in.

Getting this in despite the IIS Express issues.

@dougbu replied internally via email, but suppressing the analyzer warning should be fine for now. It may be worth looking further to obviate this but that seems non-critical.


Autocomplete is not working

Autocomplition of code is not working

@itsAbhirup , you have a screenshot to understand your problem?. Also I recommend to you our docs: https://docs.codegpt.co/docs/tutorial-features/code_autocompletion

It is not working. I am unable to enable it from the settings. It does not turn on. Neither I can select example Ollama Deepseek-coder. It just defaults to "plus"

Indeed, we are improving the autocomplete option, we will have updates soon.


[Q] Why dummy sink on Append mode

Why dummy sink on Append mode?
Environment Description

Hudi version : 1.13.1

Spark version :

Hive version :

Hadoop version :

Storage (HDFS/S3/GCS..) :

Running on Docker? (yes/no) :

Additional context
Add any other context about the problem here.
Stacktrace
Add the stacktrace of the error.

Because by default, there is no need to do the cleaning.

Because by default, there is no need to do the cleaning.

Why do not add this operator?


Synthesis failed for nodejs-artifact-registry

Hello! Autosynth couldn't regenerate nodejs-artifact-registry. :broken_heart:
Here's the output from running synth.py:
DUCT.md
CONTRIBUTING.md
LICENSE
README.md
api-extractor.json
renovate.json
samples/README.md
2021-01-07 02:10:13,070 synthtool [DEBUG] > Post-processing GAPIC library...
DEBUG:synthtool:Post-processing GAPIC library...
2021-01-07 02:10:13,070 synthtool [DEBUG] > Installing dependencies...
DEBUG:synthtool:Installing dependencies...
npm WARN deprecated<EMAIL_ADDRESS>Debug versions >=3.2.0 <3.2.7 || >=4 <4.3.1 have a low-severity ReDos regression when used in a Node.js environment. It is recommended you upgrade to 3.2.7 or 4.3.1. (https://github.com/visionmedia/debug/issues/797)
npm WARN deprecated<EMAIL_ADDRESS>"Please update to latest v2.3 or v2.2"
npm WARN deprecated<EMAIL_ADDRESS>Use cheerio-select instead

><EMAIL_ADDRESS>postinstall /home/kbuilder/.cache/synthtool/nodejs-artifact-registry/node_modules/protobufjs
> node scripts/postinstall

><EMAIL_ADDRESS>prepare /home/kbuilder/.cache/synthtool/nodejs-artifact-registry
> npm run compile-protos && npm run compile

><EMAIL_ADDRESS>compile-protos /home/kbuilder/.cache/synthtool/nodejs-artifact-registry
> compileProtos src

installing<EMAIL_ADDRESS>installing<EMAIL_ADDRESS>installing<EMAIL_ADDRESS>installing<EMAIL_ADDRESS>installing<EMAIL_ADDRESS>
><EMAIL_ADDRESS>compile /home/kbuilder/.cache/synthtool/nodejs-artifact-registry
> tsc -p . && cp -r protos build/

npm notice created a lockfile as package-lock.json. You should commit this file.
npm WARN optional SKIPPING OPTIONAL DEPENDENCY<EMAIL_ADDRESS>(node_modules/chokidar/node_modules/fsevents):
npm WARN notsup SKIPPING OPTIONAL DEPENDENCY: Unsupported platform for<EMAIL_ADDRESS>wanted {"os":"darwin","arch":"any"} (current: {"os":"linux","arch":"x64"})

added 605 packages from 765 contributors and audited 606 packages in 28.548s

76 packages are looking for funding
  run `npm fund` for details

found 0 vulnerabilities

2021-01-07 02:10:42,608 synthtool [DEBUG] > Running prelint...
DEBUG:synthtool:Running prelint...

><EMAIL_ADDRESS>prelint /home/kbuilder/.cache/synthtool/nodejs-artifact-registry
> cd samples; npm link ../; npm i

><EMAIL_ADDRESS>prepare /home/kbuilder/.cache/synthtool/nodejs-artifact-registry
> npm run compile-protos && npm run compile

><EMAIL_ADDRESS>compile-protos /home/kbuilder/.cache/synthtool/nodejs-artifact-registry
> compileProtos src

><EMAIL_ADDRESS>compile /home/kbuilder/.cache/synthtool/nodejs-artifact-registry
> tsc -p . && cp -r protos build/

npm WARN optional SKIPPING OPTIONAL DEPENDENCY<EMAIL_ADDRESS>(node_modules/fsevents):
npm WARN notsup SKIPPING OPTIONAL DEPENDENCY: Unsupported platform for<EMAIL_ADDRESS>wanted {"os":"darwin","arch":"any"} (current: {"os":"linux","arch":"x64"})

audited 606 packages in 15.495s

76 packages are looking for funding
  run `npm fund` for details

found 0 vulnerabilities

/home/kbuilder/.nvm/versions/node/v14.15.4/lib/node_modules/@google-cloud/artifact-registry -> /home/kbuilder/.cache/synthtool/nodejs-artifact-registry
/home/kbuilder/.cache/synthtool/nodejs-artifact-registry/samples/node_modules/@google-cloud/artifact-registry -> /home/kbuilder/.nvm/versions/node/v14.15.4/lib/node_modules/@google-cloud/artifact-registry -> /home/kbuilder/.cache/synthtool/nodejs-artifact-registry
npm WARN deprecated<EMAIL_ADDRESS>Debug versions >=3.2.0 <3.2.7 || >=4 <4.3.1 have a low-severity ReDos regression when used in a Node.js environment. It is recommended you upgrade to 3.2.7 or 4.3.1. (https://github.com/visionmedia/debug/issues/797)
npm WARN deprecated<EMAIL_ADDRESS>"Please update to latest v2.3 or v2.2"
npm notice created a lockfile as package-lock.json. You should commit this file.
npm WARN optional SKIPPING OPTIONAL DEPENDENCY<EMAIL_ADDRESS>(node_modules/chokidar/node_modules/fsevents):
npm WARN notsup SKIPPING OPTIONAL DEPENDENCY: Unsupported platform for<EMAIL_ADDRESS>wanted {"os":"darwin","arch":"any"} (current: {"os":"linux","arch":"x64"})

added 138 packages from 118 contributors and audited 199 packages in 4.811s

76 packages are looking for funding
  run `npm fund` for details

found 0 vulnerabilities

2021-01-07 02:11:04,497 synthtool [DEBUG] > Running fix...
DEBUG:synthtool:Running fix...

><EMAIL_ADDRESS>fix /home/kbuilder/.cache/synthtool/nodejs-artifact-registry
> gts fix

/home/kbuilder/.cache/synthtool/nodejs-artifact-registry/node_modules/meow/index.js:61
		throw new Error(`Flag keys may not contain '-': ${invalidFlags.join(', ')}`);
		^

Error: Flag keys may not contain '-': dry-run
    at validateOptions (/home/kbuilder/.cache/synthtool/nodejs-artifact-registry/node_modules/meow/index.js:61:9)
    at meow (/home/kbuilder/.cache/synthtool/nodejs-artifact-registry/node_modules/meow/index.js:136:2)
    at Object.<anonymous> (/home/kbuilder/.cache/synthtool/nodejs-artifact-registry/node_modules/gts/build/src/cli.js:30:13)
    at Module._compile (internal/modules/cjs/loader.js:1063:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:1092:10)
    at Module.load (internal/modules/cjs/loader.js:928:32)
    at Function.Module._load (internal/modules/cjs/loader.js:769:14)
    at Function.executeUserEntryPoint [as runMain] (internal/modules/run_main.js:72:12)
    at internal/main/run_main_module.js:17:47
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR<EMAIL_ADDRESS>fix: `gts fix`
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>fix script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR! A complete log of this run can be found in:
npm ERR!     /home/kbuilder/.npm/_logs/2021-01-07T10_11_05_102Z-debug.log
2021-01-07 02:11:05,111 synthtool [ERROR] > Failed executing npm run fix:

None
ERROR:synthtool:Failed executing npm run fix:

None
Traceback (most recent call last):
  File "/home/kbuilder/.pyenv/versions/3.6.9/lib/python3.6/runpy.py", line 193, in _run_module_as_main
    "__main__", mod_spec)
  File "/home/kbuilder/.pyenv/versions/3.6.9/lib/python3.6/runpy.py", line 85, in _run_code
    exec(code, run_globals)
  File "/tmpfs/src/github/synthtool/synthtool/__main__.py", line 102, in <module>
    main()
  File "/tmpfs/src/github/synthtool/env/lib/python3.6/site-packages/click/core.py", line 829, in __call__
    return self.main(*args, **kwargs)
  File "/tmpfs/src/github/synthtool/env/lib/python3.6/site-packages/click/core.py", line 782, in main
    rv = self.invoke(ctx)
  File "/tmpfs/src/github/synthtool/env/lib/python3.6/site-packages/click/core.py", line 1066, in invoke
    return ctx.invoke(self.callback, **ctx.params)
  File "/tmpfs/src/github/synthtool/env/lib/python3.6/site-packages/click/core.py", line 610, in invoke
    return callback(*args, **kwargs)
  File "/tmpfs/src/github/synthtool/synthtool/__main__.py", line 94, in main
    spec.loader.exec_module(synth_module)  # type: ignore
  File "<frozen importlib._bootstrap_external>", line 678, in exec_module
  File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
  File "/home/kbuilder/.cache/synthtool/nodejs-artifact-registry/synth.py", line 41, in <module>
    node.postprocess_gapic_library()
  File "/tmpfs/src/github/synthtool/synthtool/languages/node.py", line 194, in postprocess_gapic_library
    fix(hide_output=hide_output)
  File "/tmpfs/src/github/synthtool/synthtool/languages/node.py", line 179, in fix
    shell.run(["npm", "run", "fix"], hide_output=hide_output)
  File "/tmpfs/src/github/synthtool/synthtool/shell.py", line 39, in run
    raise exc
  File "/tmpfs/src/github/synthtool/synthtool/shell.py", line 33, in run
    encoding="utf-8",
  File "/home/kbuilder/.pyenv/versions/3.6.9/lib/python3.6/subprocess.py", line 438, in run
    output=stdout, stderr=stderr)
subprocess.CalledProcessError: Command '['npm', 'run', 'fix']' returned non-zero exit status 1.
2021-01-07 02:11:05,160 autosynth [ERROR] > Synthesis failed
2021-01-07 02:11:05,161 autosynth [DEBUG] > Running: git reset --hard HEAD
HEAD is now at 0c5f6eb chore: release 1.0.0 (#1)
2021-01-07 02:11:05,179 autosynth [DEBUG] > Running: git checkout autosynth
Switched to branch 'autosynth'
2021-01-07 02:11:05,199 autosynth [DEBUG] > Running: git clean -fdx
Removing __pycache__/
Removing build/
Removing node_modules/
Removing package-lock.json
Removing samples/node_modules/
Removing samples/package-lock.json
Traceback (most recent call last):
  File "/home/kbuilder/.pyenv/versions/3.6.9/lib/python3.6/runpy.py", line 193, in _run_module_as_main
    "__main__", mod_spec)
  File "/home/kbuilder/.pyenv/versions/3.6.9/lib/python3.6/runpy.py", line 85, in _run_code
    exec(code, run_globals)
  File "/tmpfs/src/github/synthtool/autosynth/synth.py", line 354, in <module>
    main()
  File "/tmpfs/src/github/synthtool/autosynth/synth.py", line 189, in main
    return _inner_main(temp_dir)
  File "/tmpfs/src/github/synthtool/autosynth/synth.py", line 334, in _inner_main
    commit_count = synthesize_loop(x, multiple_prs, change_pusher, synthesizer)
  File "/tmpfs/src/github/synthtool/autosynth/synth.py", line 65, in synthesize_loop
    has_changes = toolbox.synthesize_version_in_new_branch(synthesizer, youngest)
  File "/tmpfs/src/github/synthtool/autosynth/synth_toolbox.py", line 259, in synthesize_version_in_new_branch
    synthesizer.synthesize(synth_log_path, self.environ)
  File "/tmpfs/src/github/synthtool/autosynth/synthesizer.py", line 120, in synthesize
    synth_proc.check_returncode()  # Raise an exception.
  File "/home/kbuilder/.pyenv/versions/3.6.9/lib/python3.6/subprocess.py", line 389, in check_returncode
    self.stderr)
subprocess.CalledProcessError: Command '['/tmpfs/src/github/synthtool/env/bin/python3', '-m', 'synthtool', '--metadata', 'synth.metadata', 'synth.py', '--']' returned non-zero exit status 1.

Google internal developers can see the full log here.

Autosynth passed, closing! :green_heart:

Autosynth passed, closing! :green_heart:


RTF alerts are not supported in ARM

MuleSoft Ideas Portal: https://help.mulesoft.com/s/ideas#0872T000000Xa2fQAC, and it was answered by the Runtime Fabric product manager Sundip Patel:
"
October 27, 2020 • 18:46
Thanks for sharing this idea! The Anypoint Monitoring team has recently added alerting capabilities available for all Runtime Fabric application deployments. More details can be found in the documentation for Anypoint Monitoring.
"
We need to explicitly clarify this in the Docs.

@lee3star - Please commit the small suggestion.
@sundippatel - Please approve the update.
Thanks!


Move test to tests folder

Not quite ready yet, tests require input, take quite long and give an error.

Sorry wrong button, didn't meant to put it out of draft


Improve visual structure of Navbar to make it more appealing

I would like to improve visual structure of Navbar to make it more appealing.
Please assign me this issue under GSSOC'23.

I am willing to work on this. please assign it to me

Could you please show a proposed UI for the Navbar?
Also, what features do you want to add to it?

ok first I want navbar to be fixed

logo to its end
font change
and there are more ill provide you with ui tommorow

I would like to work on this issue under GSSOC'23. I would appreciate if the issue is assigned to me.

Hello @peb-peb,
First, I would like to add Glassmorphic Effect to Navbar it will look more appealing.
Then, hover effect on navbar options and Contact Us button can be improved.

Go ahead and submit a pull request, we would be happy to merge it! @sanketsaurav2411


How to use 3 different colors?

In belka.us.androidtoggleswitch.widgets.ToggleSwitch, I have 3 buttons/labels. I want to set 3 different colors. How can I achieve this?

Hi, How I can applicate style(fonts) to textToggleRight and textToggleLeft

+1

+1

@vvbhandare, @kcywek, @MahdiPishguy I've added this functionality in my new fork of the library.
Into the documentation there is a sample that create 3 buttons with different colors.
Please, check it out at https://github.com/llollox/Android-Toggle-Switch

@llollox thank you very much


Redeem/Ticket timeout failures at orchestrator

Several slices at KNIT7 ran into failure where Redeem messages timeout. This was observed on clem-am and tacc-am.
Based on debugging so far from clem-am, the message can be seen on the topic here: https://mbsr-p.fabric-testbed.net/topic/clem-am/messages?partition=2&offset=0&count=100&keyFormat=AVRO&format=AVRO&isAnyProto=false
However, clem-am seem to have never processed or received it. Needs to look at Consumer processing at the AM
"reservation_id": "1c1d5802-d663-46e2-b187-698ca50a3c0d",

All such failures have been reported from tacc-am or clem-am as per ELK logs.
2023-10-06 14:05:56,229
Res# ba2ffc70-a222-4159-8b1c-d9562d786308 Redeem/Ticket timeout! No response received in 900 seconds from tacc-am!

2023-10-05 18:33:36,862
Res# 7a19c242-b3da-46b3-b2cb-18ed0ef1840e Redeem/Ticket timeout! No response received in 900 seconds from utah-am!

2023-09-29 19:49:09,409
Res# 540f0649-64d6-4a42-8597-db964d426fe8 Redeem/Ticket timeout! No response received in 900 seconds from tacc-am!

2023-09-28 01:35:10,538
Res# 6332d4e6-4945-4284-a443-da16432355a3 Redeem/Ticket timeout! No response received in 900 seconds from tacc-am!

2023-09-28 01:27:20,552
Res# e1ec863d-1908-4166-9c99-aa9b5e8978c0 Redeem/Ticket timeout! No response received in 900 seconds from clem-am!

2023-09-28 00:24:40,022
Res# f61428a5-e818-4045-95f1-56dc36837766 Redeem/Ticket timeout! No response received in 900 seconds from tacc-am!

2023-09-28 00:24:39,999
Res# fe668059-7948-4ae3-89df-bf88224cfad1 Redeem/Ticket timeout! No response received in 900 seconds from clem-am!

2023-09-27 23:53:49,758
Res# 1c1d5802-d663-46e2-b187-698ca50a3c0d Redeem/Ticket timeout! No response received in 900 seconds from clem-am!

2023-09-27 22:13:28,857
Res# cdfc5919-f1aa-4c1f-bf2c-a0d586ffb74d Redeem/Ticket timeout! No response received in 900 seconds from clem-am!

2023-09-27 21:35:08,535
Res# 5c4a1c6f-fa8d-4f42-9190-dd5898048556 Redeem/Ticket timeout! No response received in 900 seconds from tacc-am!

2023-09-27 20:30:07,979
Res# e9674776-798b-401b-9500-ee6e8ae4abef Redeem/Ticket timeout! No response received in 900 seconds from clem-am!

2023-09-27 19:57:07,684
Res# ba2e6a08-f769-4684-b60a-bab6007ab0e5 Redeem/Ticket timeout! No response received in 900 seconds from clem-am!

2023-09-27 11:19:23,024
Res# 5f3d40c7-3df3-4e48-a675-0d58e92c4c30 Redeem/Ticket timeout! No response received in 900 seconds from tacc-am!

Observed on following sites so far:

STAR
UCSD
GPN
GATECH
TACC
CLEM
UTAH

Observation: Several slices are reported to have one or more slivers reported as Closed with error "Redeem/Ticket timeout"
Investigating the Kafka topics and CF logs, noticed that the message for such slivers was not received on the Site AMs and processed resulting in a timeout on Orchestrator.
Addition Problems Observed:

Observation: Kafka brokers are accessible via IPv4 and IPv6, lot of sites complain about connection failures on either of those
Fix: Added explicit entries to /etc/hosts to point to IPv4 or IPv6 depending on Site's capability cleared this failures
This did not resolve the Redeem/Ticket timeouts

Real Root Cause:

Kafka Consumer thread was setup to use default configuration for offset commits i.e. auto commit with default auto commit interval set to 5 seconds. With this setting, every 5 seconds, the latest offset is commited.
Kafka Consumer thread was doing two things and took upto 3-5 seconds on the worst case:

Reading the message
Reconstructing it and also processing

Due to the above two things, offsets being committed before they could be processed by the consumer thread resulted in missed messages at Sites and timeouts on orchestrator.

Solution:

Added RPCConsumer thread responsible for processing the incoming messages
Refactored the consumer thread to just pick up the message and add to RPCConsumer thread's queue
Disabled auto commits and modified the consumer thread to commit the offset after the message has been read and added to RPCConsumer queue. This ensures that no message from Kafka broker is missed.


How to install it in Fedora32?

Recently I have shifted from ubuntu to Fedora. Please either tell me how to use usbaudio in fedora or provide an alternative.

The only things that changes in fedora are the packages
sudo dnf  install gcc git meson vlc cmake pulseaudio-libs-devel libusb-devel


Lanyard get button url?

Lanyard returns the button name, but what about the URL?

As answered in the discord, buttons are pulled from the discord API by the client when a user card is opened, bots are not able to get the button actions or anything more.


[1.2.x] [e2e] cherry-pick #1576, #1609, catalog-timestamp fix

Manual cherry pick of

https://github.com/janus-idp/backstage-showcase/pull/1576
#1609
catalog-timestamp fix from https://github.com/janus-idp/backstage-showcase/pull/1604

/retest

/retest

/lgtm


Example has invalid value warning

In VS 15.7 the example code will lead to an invalid value warning/error for Enum constraint failure
for the deliveryMethod attribute, which has network as its value in the example, but should be Network.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 18e8aae2-b92f-8913-8865-bc1abc549b90
Version Independent ID: 1e331bd2-77d7-346f-3965-b09134cf8f83
Content: <mailSettings> Element (Network Settings)
Content Source: docs/framework/configure-apps/file-schema/network/mailsettings-element-network-settings.md
Product: dotnet-framework
GitHub Login: @mcleblanc
Microsoft Alias: markl

Thanks for bringing this to our attention, @ite-klass. @davidsh, can you confirm that the value of the deliveryMethod attribute should be Network rather than network?

Thanks, @davidsh. I assume that the casing applies as well to SpecifiedPickupDirectory and PickupDirectoryFromIis, both of which are therefore also incorrect. I'll submit a PR to correct these shortly.


Introduce Service-Worker-Max-Age header

@ehsan, please correct me if this didn't match what we discussed.
Since service workers use byte-for-byte comparison rather than HTTP cache semantics, there's a risk that when using a service worker library, it becomes harder to update, since you need to change the library code.
So it would be good that in addition to the byte-for-byte comparison, there's also a header that indicates when the browser should start ignoring the service worker being byte-for-byte identical.

That sounds like an accurate summary!

The max-age is counted since installation.

There's pretty strong consensus from the F2F that this is worth doing in M2 (IIRC). Marking as such.

The are two perspectives here. One option is to extend byte-to-byte comparison to the whole imported scripts (importScripts) graph. If one node has change, update. The other is related with #839. The header Service-Worker-Force-Update proposed by @jakearchibald can be enough for this but it's hard to automatically calculate in the server cause it involves to calculate the import graph there.

One option is to extend byte-to-byte comparison to the whole imported scripts (importScripts) graph.

+1 for this
Personally I don't like the idea of having to return a custom header to force the refresh of the imported scripts.
This is because at Pushpad (which is a BaaS) we have a script that is imported in our customers' service workers. When we update our script we want the update to be propagated. However we cannot ask our customers to return custom headers for their service worker (some of them for example have simple websites or blogs powered by Wordpress).
I have described more extensively about our situation and why we need automatic updates of the imported scripts in this blog post.

We're going to check imported scripts by default https://github.com/slightlyoff/ServiceWorker/issues/839#issuecomment-236256162


api: docs: start documenting nodegroup and tree

doc-only change

/lgtm

a doc only change can't break anything, and the CI is currently failing for known reasons


Check cluster-region before creating s3-Bucket in automated setup

Description of your changes:
Automated setup will fail if cluster_region is set to us-east-1, since the s3-bucket creation will error out due to

botocore.exceptions.ClientError: An error occurred (InvalidLocationConstraint) when calling the CreateBucket operation: The specified location-constraint is not valid
thus will check if region is us-east-1 and call CreateBucket without this constraint.

Checklist:

[ ] Unit tests pass:
Make sure you have installed kustomize == 3.2.1

make generate-changed-only
make test

Hello, could you explain why the if is needed ? Would it still work without the if when our cluster region is us-east-1 ?
Thanks

Hello, could you explain why the if is needed ? Would it still work without the if when our cluster region is us-east-1 ? Thanks
@AlexandreBrown
The if is needed since locationConstraint is a required field if you are using any region besides us-east-1. However if you are using us-east-1 then using locationConstraint will be invalid. The original code doesn't work if us-east-1 is our cluster region. and you get this error message

botocore.exceptions.ClientError: An error occurred (InvalidLocationConstraint) when calling the CreateBucket operation: The specified location-constraint is not valid
thus will check if region is us-east-1 and call CreateBucket without this constraint.


Only apply SkipJitList on Unix platforms

Helps with test bucketing.
Also, some of the things on the skipJitList now work, but I really don't
want to retest on Linux to refresh the list because it's pointless at
this point (with the right fix in code review).

Hi @MichalStrehovsky, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution!
You've already signed the contribution license agreement. Thanks!
The agreement was validated by .NET Foundation and real humans are currently evaluating your PR.
TTYL, DNFBOT;

LGTM


Cacti ver 1.2.16 - editor can't edit at all

when opening a map for editing I can see all old conf but can't change anything
editor.js:44 Uncaught TypeError: jQuery(...).unload is not a function
at editor.js:44
jquery.min.js:2 Uncaught Error: Syntax error, unrecognized expression: area[id^=LINK:]
at Function.oe.error (jquery.min.js:2)
at oe.tokenize (jquery.min.js:2)
at oe.select (jquery.min.js:2)
at Function.oe [as find] (jquery.min.js:2)
at w.fn.init.find (jquery.min.js:2)
at new w.fn.init (jquery.min.js:2)
at w (jquery.min.js:2)
at attach_click_events (editor.js:88)
at HTMLDocument.initJS (editor.js:66)
at l (jquery.min.js:2)

I ran into this same issue the day after you posted this.  I'm no longer seeing the same error messages (no idea why), but I got this working by setting permissions on the weathermap/configs directory to 770.  Something like:
chown root:www-data configs -R
chmod ug+rwx configs -R
chmod o-rwx configs -R
Hopefully this helps.

Yes, this is right, it´s only because there are no write permissions on the on the weathermap/configs directory. this issue should be closed.

This issue will be resolved once this pull request is merged: https://github.com/Cacti/plugin_weathermap/pull/39
Though I will add, you still must, as the web browser, have rights to the Weathermap configs directory.


PanacheEntity at creation time

When I create a new .java file I can choose between several options (i.e class, interface, enum, ... [1]) if it is possible (don't know if it can be done) it will be nice to have a panache option too, so the generated class also implements PanacheEntity.

I'm not sure that JDT LS provides this extension kind to customize option. @fbricon can you confirm that?

no we can't do that. It might even be pretty tricky to add


Feature/expandable feedback

Codecov Report

Merging #49 into develop will increase coverage by 0.02%.
The diff coverage is 100%.

@@             Coverage Diff             @@
##           develop      #49      +/-   ##
===========================================
+ Coverage     93.6%   93.62%   +0.02%
===========================================
  Files          124      124
  Lines         1969     1976       +7
===========================================
+ Hits          1843     1850       +7
  Misses         126      126

Impacted Files
Coverage Δ

src/px-script/main/expandable/index.js
100% <100%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 24c3db9...bd8542e. Read the comment docs.


Translate labels with translation strings stored in resources/lang directory

I don't know if field labels can translated by resources/lang/.json.
Now in crud controller I do this:
foreach (CRUD::fields() as $k => $c) {
   CRUD::field($k)->label(__($k));
}

but it seems a mess. How can I do better? Couldn't you add this feature?

Hello @masetto thanks for the proposal.
You can use any laravel functionality for translations, arrayed.notation or __('string') but I think you already know that anyway: https://laravel.com/docs/8.x/localization#using-translation-strings-as-keys
You solution seems very clean, other than that define the label "per field".
In backpack we just echo the label whatever developer gives us, we don't enforce any translation method
<label>{!! $field['label'] !!}</label>

We might be able to run __($field['label']) by default, but I think that could bring in some other problems, like don't wanting the label to be translated because the same string should be translated somewhere else, but not there. Then there is no way of telling don't translate this please.
So I think the way we built it, is the most intuitive. Not everyone needs translations, who needs them can easily add them.
I personaly don't see what you did like A BIG MESS, nor adding ->label(__('some')) in the field definition, but it's my personal opinion.
If that is something you will use in all your cruds, you can abstract that to a trait RunsLabelsThroughTranslation and add it to your controllers. Then you can override backpack create and update functions https://backpackforlaravel.com/docs/4.1/crud-operation-create#callbacks and run your $this->applyTranslatedLabels() by default.
Maybe I am not seeing the big picture. Do you have any other suggestion on how we could implement it @masetto ?
Best,
Pedro

Hello @pxpm, thanks for your answer.
I think we could add a property as public $traslateLabels = false in AutoSet trait (vendor/backpack/crud/src/app/Library/CrudPanel/Traits/AutoSet.php). Then in function makeLabel we could update like this:
...
$label = trim(mb_ucfirst(str_replace('_', ' ', preg_replace('/(_id|_at|\[\])$/i', '', $value))));
if ($this->translateLabels) {
    $label = __($label);
}
return $label;

What do you think about?
However, it's not so important. I can do as you suggested.

Hey guys,
I also don't mind doing ->label(__('some')) - I think that is clean enough.
From what I know, 90% of admin panels don't have translations. The overwhelming majority of admin panels, even if they are for multi-language websites, keep their admin panels in one language alone, since the admins all speak one language. As such, I don't think a wide solution like public $traslateLabels = false would be appropriate. At least that's my first thought about it - might be wrong.
What @promatik proposed though... sounds like a super-simple solution, that could work very well. We'd just add a few more helpers to the CrudField object, something like transLabel(), transPlaceholder(), transHint() which do ->label(__($value)) behind the scenes. It could even work as a Backpack add-on - since the CrudField class is Macroable, there is the opportunity of adding methods to it on runtime. So we could split up this logic in an add-on, if we consider it's polluting the main with niche functionality. Not sure if needed.
For the moment though, we're in a feature freeze, focused on fixing all 4.1 issues. Let's think about this again with an open mind when we start working at 4.2. Thanks for raising this @masetto .
Cheers!

Changed my mind, I think ->label(__('some')) is just as good as ->transLabel('some'), but without us building or maintaining anything sooo... let's just use that. No need to add a wrapper on top of a Laravel feature, when that feature already exists.
Of course, I might be wrong - I often am. If you think us please let me know.
Cheers!


should /clear also erase input history?

/clear currently erases the backlog of received messages, originally as a privacy feature to "burn after reading". It occurred to me that we might want to also blank the input state - so it is not available by accidentally scrolling up with the mouse wheel, or with the arrow keys.

sounds like a good idea! thanks!

should we also do a full GC collection afterwards?  this won't zero out all the memory (i.e. strings /dev/mem will still contain all the text), but it's better than not doing it, maybe!?

@hannesm yes!
I had a package on the drawing board that would in the spirit of "best effort" call mlockall()/(mlock() on as much as possible) as well as hook the runtime to clean heap data, I hope to get back to that sometime.


[ISSUE #4431] add p2cLoadBalancer

#4431
add p2cLoadBalancer

Codecov Report

Merging #4451 (f480a5d) into master (60a5da4) will increase coverage by 0.04%.
The diff coverage is 77.61%.

@@             Coverage Diff              @@
##             master    #4451      +/-   ##
============================================
+ Coverage     67.99%   68.03%   +0.04%
- Complexity     7533     7549      +16
============================================
  Files          1026     1027       +1
  Lines         29100    29165      +65
  Branches       2611     2621      +10
============================================
+ Hits          19787    19843      +56
- Misses         7753     7758       +5
- Partials       1560     1564       +4

Impacted Files
Coverage Δ

...rg/apache/shenyu/loadbalancer/entity/Upstream.java
92.77% <61.53%> (-5.81%)
:arrow_down:

.../org/apache/shenyu/plugin/divide/DividePlugin.java
60.29% <68.42%> (+2.29%)
:arrow_up:

...pache/shenyu/loadbalancer/spi/P2cLoadBalancer.java
87.87% <87.87%> (ø)

...rg/apache/shenyu/common/enums/LoadBalanceEnum.java
100.00% <100.00%> (ø)

...henyu/admin/service/impl/UpstreamCheckService.java
66.66% <0.00%> (+0.57%)
:arrow_up:

...shenyu/sync/data/consul/ConsulSyncDataService.java
80.00% <0.00%> (+1.66%)
:arrow_up:

...henyu/plugin/grpc/resolver/ShenyuNameResolver.java
60.63% <0.00%> (+4.25%)
:arrow_up:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Can not launch on Marshmallow

I'm not sure the reason but you might use reflection or something like that(like ActiveAndroid).
Any idea?

Hi, @hotchemi
Thank you for reporting
I forget release... : P
Maybe, I think this problem. #4

Gotcha! Thx:-)

0.2.1 has released :shipit:

:+1:


gradle release v3.3.0

To be merged after the release is complete.

jib-gradle-plugin 3.3.0 has been released.


run an angular moment filter on data before passing it into ngi18n

{{ 'job.posted_at' | t:{ date: job.created_at | amDateFormat:'MMM Do'}}}
I have to somehow get that date transposed.

I'm not sure how to approach this one. Any suggestions? PR maybe?

Is there a way I can format the date in the controller, before it gets to the view?

That's up to your use of the moment lib. You can do translations in your controller using the i18ng service: https://github.com/mikefrey/i18ng#service


Data consumption & IPFS design doc

1 page design doc for what it would look like to consume a dataset in a notebook
Design doc outline:
Background / motivation
Use cases / user stories
Proposed technical design
Alternatives considered
See https://docs.google.com/document/d/1JGnJW1PZWwuPtakgK94pZckJMMaqEthE3TzdZh30jA0/edit#heading=h.56gutqk2k0kz

https://docs.google.com/document/d/1RVAhNC6b9ajOaHVwQz8loNUWluKqFe7r85pt754jE0Q/


Skater Stats by Date?

Anyone figure out how to aggregate stat ranges by date?
I want to recreate this from the NHL stat page: https://www.nhl.com/stats/skaters?reportType=game&dateFrom=2023-10-10&dateTo=2024-04-18&gameType=2&sort=points,goals,assists&page=0&pageSize=50
I've got this far:
https://api.nhle.com/stats/rest/en/skater/summary?limit=-1&sort=skaterFullName&cayenneExp= I imagine it would go somewhere here and gameTypeId=2.
dateId>=2023-10-10 doesn't work.
Any ideas?

isAggregate=false&isGame=true&cayenneExp=gameDate<"YYYY-MM-DD"


Do not collect replays from mobile users

We should be mindful of collecting replays from mobile users (especially those on slow connections e.g. 3g) as we don't want to drain their data as well as negatively impacting network performance.

Some ideas here:

Allow to provide a replaysSessionSampler method similar to tracesSampler, which allows users to write a dynamic sampler. E.g.:

SDK.init({
  replaysSessionSampler: () => {
    if (window.connection.type === 'cellular') {
      return 0.0; // do not sample when using cellular data
    }
    return 0.1;
  }
});

Use something like window.connection under the hood and expose a new option like skipReplayForConnectionTypes: ['cellular'].

Note on this: window.connection is not available on Safari or Firefox, so this would be a progressive enhancement (see https://developer.mozilla.org/en-US/docs/Web/API/NetworkInformation).


⚠ Adam Brand Music has degraded performance

In 3fbbdbe, Adam Brand Music (https://adambrandmusic.com) experienced degraded performance:

HTTP code: 200
Response time: 9074 ms

Resolved: Adam Brand Music performance has improved in 847a97a after 4 minutes.


Move package to pure JS

Many Node.js developers (including myself) will have this reaction

when they have to read a module written in CoffeeScript.
On top of this, the test suite is already written in JavaScript. I think that it makes sense to port everything to JavaScript and maybe use ES2015 with Babel.

I agree with CoffeeScript part. I personally don't like it.
I have not been here since the beginning of the module, but I can imagine why people used it. I think they were (and still are) hardworking Rubyists/Full Stacks (and possibly tried to make context switch cheaper) who wanted to have js modules beautiful and consistent.
As for porting completely to JS, I would first finish extend module's functionality, like adding new resources to session object so clients have access to them in their code. Also enabling use of new resources to those who are developing public apps. I know those things are not mutually exclusive and don't have to be sequential, it is my personal choice - functionality first. Mixed style of quotes might not look well, but at the moment I am more concerned with helping people to use the module.

I agree with you @Alua-Kinzhebayeva, done is better than perfect, but I also think that clean clode is a feature. A lot of code in this repo is untouchable because it's such a mess.

I guess you have an upcoming pr with port to JS. if it is the case, it will be happily merged

No, not yet, but maybe in the next few days :wink:

The truth is I chose CoffeeScript because, at the time, it was the platform that had more potential to develop the client. None if those reasons hold today, so it makes sense to port to ES6, though I would not only migrate the code but would also review the design,

getting rid of the asynchronous API using callbacks
using a reactive development style, returning streams in every call
favoring composition over inheritance

Sorry I don't have enough time to contribute to the project, but I'm amazed at what it's becoming of it.

:+1:

I close this as a significant refactor where CoffeeScript is no longer used, has been completed.
We still don't take full advantage of ES2015 syntax (import, export, destructuring assignment, etc.), but it a big step forward.


Removing Unused Replica Sets After Deply

Ive noticed that after a deploy, the old replica set is still present.
How to auto remove the old replica set (Desired 0) after deploy?

I don't believe it is possible to remove the replicasets automatically. It will be automatically scaled down for you already however.

Yes, this isn't anything to do in particular w/ this project. It's connected to K8s Deployments. I noticed too, that when running apply on a Deployment that it leaves "orphaned" replica sets that are "turned off". Harmless, I suppose, but distracting to say the least...

Won't those replica sets fill up the disk/memory of the cluster?
I am just worried of having to manually take care of them since a CI workflow is creating them on each build on our cluster

In the deployment spec you can define the revisionHistoryLimit

Also to @cmosgh those replicasets are scaled down to 0 regardless so are not taking up any cluster resources.

@viglesiasce According to docs that is incorrect.
https://kubernetes.io/docs/concepts/workloads/controllers/deployment/#revision-history-limit

All old ReplicaSets will be kept by default, consuming resources in etcd and crowding the output of kubectl get rs

Is there any way to set revisionHistoryLimit into namespace or node level ?

Is there any way to set revisionHistoryLimit into namespace or node level ?


Dockerfile needed

To ensure that we can create the whole system also in a kubernetes surrounding we need a Dockerfile for the whole api and streamlit code setup.

Shall we close this issue to @DaBeIDS , as we are no longer focusing on Dockerfile ans streamlit?

Correct the code goes to PyPi and will not need an own Dockerfile


Attempt to fix GridMass (gm still broken)

attempt to fix grid mass (#660)
the created features are weird, i think something is not right with the algorithm since we changed the datamodel.

Yes, there is definitively something wrong. WHen i look manually it does still seem to isolate mass peaks but subsequent calculations are selected from wrong source i think.
See files:
Gridmass findings.docx
export data after gridmassalgo.xlsx

This is the direct link to all downloads that should appear at the bottom of the page:
https://github.com/mzmine/mzmine3/actions/runs/2156209683

Hey @GeertNL, did you have the opportunity to test it?

Thanks for the reply, @GeertNL. We will merge the PR then, since the difference of 60 is expected and will not be fixed. (see https://github.com/mzmine/mzmine3/issues/621)


How to reassemble decrypted .ncch partition files back into a .3ds file?

Hi! There’s no discussion tab so apologies for posting this question as an issue.
I have your experimental python3 script working in Batocera Linux in a virtualenv.
giving it an encrypted .3ds file it writes a .Main.ncch, .Manual.ncch, .N3DSUpdateData.ncch and .UpdateData.ncch files which I assume are the extracted partitions.
Do I use another command to reassemble the decrypted partitions into a .3ds file again?
I tried to download makerom but couldn’t make heads or tails of the usage.

I'm wondering the same thing as @udance4ever . I'm fairly new to ROMs so I'm not sure what these files are or if they are needed for the game to work now.

@ibyrd1 welcome to the adventure! 🥾
until we get some input into what .ncch files are - this utility works great in Python 2.7:
https://github.com/b1k/b3DS
I am still hoping to use cia-unix as it is actively being maintained with support for Python3!

Thank you for posting this question.
The decrypt.py file is only a module of the cia-unix program, so it was not designed to run independently.
To decrypt and recompress a .3ds file, you should run the ./cia-unix command in the same folder where the ROM is located (along with the necessary modules: makerom, ctrtool, and decrypt.py).
cia-unix will take care of the whole process and if any dependencies are missing it will ask you to install them (by running the dltools.sh file, make sure it has run permissions with chmod +x dltools.sh)
About the python3 version: it is still in slow development, but thanks to the github community it has made a lot of progress..
The goal is to make all modules native (which is why I'm rewriting the decrypt.py module in rust) so installing dependencies will become much easier in the future.

Can I consider the issue solved ?

I will close the issue, if you have other problems related to that, please write them in this issue pinging me. Thank you :)

oh!  no problem.  yes, consider this issue closed (I will be sure to do this next time a question I ask is answered).
Next I need to decrypt a .3ds file, I will make a point to use the cia-unix command directly.  Thank you for the clear explanation & instructions (and pique my curiosity into what makes Rust great! 👀)


Consume on one specific partition

Hi, my topic have multiple partitions, is there any chance that I can create a consumer which listen on exactly 1 specified partition instead of all partitions?
thanks,

Sarama cluster will always divide your partitions by the number of available consumers. If you start as many consumers as partitions, each consumer will consume one partition, but there is no guarantees for "exactly one". If you want to consume exactly one partition with your consumer, you need to use http://godoc.org/github.com/Shopify/sarama#Consumer directly.

one consumer might listen on multiple partitions but sarama cluster ensures that one partition can only be listened by at most one consumer at a time right?
thanks,

correct! :)


Mixed type array support

Describe the bug
If a mixed type array is declared, this is not correctly rendered in the HTML view it is rendered as Array < Unknown >
How to Reproduce
To reproduce it:

copy and paste the following spec in the generator

asyncapi: 2.0.0
info:
  title: Test MQTT API
  version: '1.0.0'
  description: |
    Test

defaultContentType: application/json

channels:
  foo/bar:
    description: Test MQTT operation
    publish:

      message:
        $ref: '#/components/messages/testMessage'
components:
  messages:
    testMessage:
      contentType: application/json
      payload:
        $ref: "#/components/schemas/mainSchema"
  schemas:

    oneOfSchema:
      type: object
      properties:
        foo:
          type: number
          format: float
    oneOfSchema2:
      type: object
      properties:
        foo:
          type: number
          format: float

    mainSchema:
      type: object
      properties:
        mixedTypeArray:
          type: array
          items:
            oneOf:
            - $ref: "#/components/schemas/oneOfSchema"
            - $ref: "#/components/schemas/oneOfSchema2"

In the generated HTML code, see that the Array < Unknown > is shown for the property mixedTypeArray and no types shown in the definition of the array in the drop down of the array

Expected behavior
The drop down of the array mixedTypeArray should show the list of possible items of the array [ oneOfSchema , oneOfSchema2 ]

@jonathanhuet this issue was reported a few days here.
PR with the fix is already opened https://github.com/asyncapi/html-template/pull/97
When I check my fix with your example, this is what I get

So I guess this is also a fix for you. I'll wait for feedback from @CumminsMikeMattern one day more and if I get no response I'll look for a reviewer and merge/release, so this week it should go out

@derberg thanks for the fast reply!
Totally true about the issue #36. My bad!
About your PR result, it's totally ok for me. Thanks.
Just as a side note that probably is most a feature: As I'm familiar from Swagger/OAS, I'm missing the type name of the (referenced) object in the dropdown, as it is can be seen in OAS generator

@jonathanhuet no worries.
you mean that instead of 0 and 1 you would prefer oneOfSchema and oneOfSchema2?

yes, I think it is might be useful. OAS 3 HTML generator has it for each reference. In terms of coding I think it is useful to identify each parts and then having a specific handler/parser for that specific part of the message

I agree with @jonathanhuet

@jonathanhuet @CumminsMikeMattern I'll see what I can do. We already did it a few days ago in our react component https://github.com/asyncapi/asyncapi-react/pull/156 so this is definitely something that should be done here in the HTML template

Ok, I pushed fix that I think you are looking for
with such schema:
asyncapi: 2.0.0
info:
  title: Test MQTT API
  version: '1.0.0'
  description: |
    Test

defaultContentType: application/json

channels:
  foo/bar:
    description: Test MQTT operation
    publish:

      message:
        $ref: '#/components/messages/testMessage'
components:
  messages:
    testMessage:
      contentType: application/json
      payload:
        $ref: "#/components/schemas/mainSchema"
  schemas:

    oneOfSchema:
      type: object
      properties:
        foo:
          type: number
          format: float
    oneOfSchema2:
      type: object
      properties:
        foo:
          type: number
          format: float

    mainSchema:
      type: object
      properties:
        mixedTypeArray:
          type: array
          items:
            oneOf:
            - $ref: "#/components/schemas/oneOfSchema"
            - $ref: "#/components/schemas/oneOfSchema2"
            - type: object
              properties:
                foo:
                  type: number
                  format: float

you get this

what do you think?

what do you think?

Looks great !

fixed with https://github.com/asyncapi/html-template/pull/97

Yes, that's great!It will be very helpful! Thanks 👍

@jonathanhuet it is already released 😉 https://github.com/asyncapi/html-template/releases/tag/v0.15.0

@derberg Thanks! And also uploaded to https://playground.asyncapi.io/ , perfect!


Update script.sh for managedjob CEE/collect-verbose-ca-logs

Description
Modifying the message that gets displayed if the script is unable to retrieve logVebosity value. The descriptive message will help the user to verify if the autoscaling is properly enabled. Additionally, increasing the sleep time from 5 seconds to 10 seconds to address interim issues in pod name discrepancy.
What type of PR is this?
Script improvement
What this PR does / Why we need it?
The PR has following changes:

Modifying the message that gets displayed if the script is unable to retrieve logVebosity value.
Increasing the sleep time from 5 seconds to 10 seconds to address interim issues in pod name discrepancy.

/lgtm

Need to wait for https://github.com/openshift/managed-scripts/pull/199 to unblock the shellcheck.

/retest

/lgtm

/approve

/approve


HTML entities gets converted on save

< and > get converted to < and > in the editor
< Word up >
becomes
<Word up>

Hmm. this is most likely something related to atom rather than this plugin as the plugin doesn't do any transforming/editing when saving.


Add linux_ppc64le packages

Opening to track addition of linux_ppc64le packages for cuda-command-line-tools. This depends on cuda-gdb packages of linux_ppc64le being added ( https://github.com/conda-forge/cuda-gdb-feedstock/pull/4 ). So this is currently blocked atm

@conda-forge-admin , please re-render


Open Pandora contrib build tree.

Added the contrib/Pandora tree to assist with building the PND file for distribution to OpenPandora users.

Merged! Thank you!


Added a workflow for checking markdown links

Before submitting
Based on the https://github.com/Lightning-AI/lightning/pull/16168, added workflow files for checking markdown links.

[x] Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
[x] Did you read the contributor guideline, Pull Request section?
[ ] Did you make sure to update the docs?
[ ] Did you write any new necessary tests?

What does this PR do?
Fixes #80.
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃

@akihironitta I guess I need some approval to run workflows.

I think I need to update the config json to allow for skipping CHANGELOG links.

@shenoynikhil Oh sorry this is the correct one! https://lightning-devtools.readthedocs.io/en/latest/
@Borda We might want to update the domain to something like lightning-utilities.readthedocs.io. What do you think?

Should I use the one you have shared for now?

I updated the README with the link you shared. I guess whenever the domain changes, the README.md will also change accordingly.

Thank you so much!

We might want to update the domain to something like lightning-utilities.readthedocs.io. What do you think?

renamed as https://lit-utilities.readthedocs.io/en/latest/

hi @akihironitta @shenoynikhil what is missing to land this? :)

Hi @shenoynikhil! Mind having a look at my comment above? If you're too busy to finish this, I can contribute to this by directly pushing commits to your branch as a weekend project (if you're fine with it) 🚀

Hi @shenoynikhil! Mind having a look at my comment above? If you're too busy to finish this, I can contribute to this by directly pushing commits to your branch as a weekend project (if you're fine with it) 🚀

Sure, I'll do it.

@akihironitta ^^

@akihironitta ^^ :chipmunk:


KOGITO-5529: BPMN Editor - Support for orthogonal segments in lines

Hi @romartin, please could you review this PR?
JIRA: KOGITO-5529
Thanks

Hey @romartin @LuboTerifaj,
I finally got all checks green again. Here goes the VsCode plugin for testing.
VS Code: plugin
Thanks

@handreyrc Thanks for providing the VS Code extension for people to test. On the next times, don't  need to bother, as the VS Code Extension is already generated by the CI and available to download once the checks are green 😉

Hello @handreyrc , @romartin I will start testing the PR once we clarify the issues as we talked about today. Let's have a meeting this week, or the next one, what better suites you. Thank you!

Hi everyone, is this PR still in progress?

Hi @tiagobento,
Yes, this PR is still in progress.
I will resume my work here as soon as I finish this priority task I'm working on.
Thanks

Hey @LuboTerifaj @romartin,
For some reason the artifacts were not generated in the build so here goes the vscode extension gor testing.
VS Code: plugin
Thanks!

Closing - This feature is being implemented at lienzo level only, for the kogito SWF stream. See https://github.com/kiegroup/kie-tools/pull/1128


Update it.coffee

Coverage remained the same at 56.629% when pulling dbb44614a987cc1048f82a1b693cb51cc3c9e811 on LionHear7:master into e3caf67326764fd1895510a0e2ce25d45e1ea875 on codecombat:master.

Awesome, @LionHear7! Thanks 👍


Change of Series.apply and DataFrame.apply functions implementation

What do these changes do?
Series.apply and DataFrame.apply functions are reworked in order to match Pandas behavior.

[ ] passes flake8 modin
[ ] passes black --check modin
[ ] signed commit with git commit -s
[ ] Resolves #1674
[ ] tests added and passing

Currently blocked by #1717 and #1719.

@amyskov plz rebase from master


Android - Workspace - Workspace name is not fully displayed on Profile page

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: 1.4.45-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers<EMAIL_ADDRESS>Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:
Action Performed:

Sign in with Gmail account
Go to Settings> Create new Workspace
Navigate to Profile

Expected Result:
Workspace name should be fully displayed
Actual Result:
Workspace name is not fully displayed
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[x] Android: Native
[ ] Android: mWeb Chrome
[ ] iOS: Native
[ ] iOS: mWeb Safari
[ ] MacOS: Chrome / Safari
[ ] MacOS: Desktop

Screenshots/Videos
Add any screenshot/video evidence

View all open jobs on GitHub

Production:
https://github.com/Expensify/App/assets/78819774/42e0bbe7-910c-4196-8c83-c4e3c6a6cf6c

@hayata-suenaga  FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

We think that this bug might be related to #vip-vsp
CC @quinthar

not a bug. looks like it's intentional

looking at this right now 👀

yep this clearly looks like intentional change.
@lanitochka17 did you have any TestRail case that specify that the workspace name should be fully displayed?

anyway, closing this for now


Evaluating multiple choice questions with GPT (OpenAI Chat Completion API)

I am wondering is there a way to evaluate GPT (OpenAI Chat Completion API) on a set of multiple choice questions such as the mmlu tasks. I know that the chat completion api does not support log likelihood, but is there a built-in way that allows getting text/json answers from GPT and then post-process to get multiple choice evaluations?

I was wondering the same thing. Has there been any progress?


Project import generated by Copybara.

PiperOrigin-RevId: 543528687

Pull Request Functional Test Report for #1788 / 3a00dba13d84ee4f0839fb303cfeb35153174f77
No tests identified for validation.
Help


Concrete implementation of ==K

Part of https://github.com/kframework/kore/issues/1648

Reviewer checklist

[ ] Test coverage: stack test --coverage
[ ] Public API documentation: stack haddock

We should make the new integration tests independent of the frontend, so that we do not have to wait for the frontend release to pass before we can merge this pull request. The evm-semantics regression tests in this repository do the same thing. There is a script which generates the Kore files from the K files, and we commit the Kore files into the repository. You should make a copy of that script and modify it for the new tests. For each test, the script should invoke kollect test-name kprove ... (fill in ... with the arguments to kprove). Then, you would run the script with the correct frontend version on your PATH and with KORE pointing to your clone of the Kore repository. We should also commit the K source files to the repository (so that the tests can be re-generated) but these should go in a subdirectory so that the Makefile doesn't try to run them automatically. (It will run the generated tests instead.)


Shaka 3.X.X causes video to stall every few seconds on some WebOS TVs

Have you read the FAQ and checked for duplicate open issues?
Yes
What version of Shaka Player are you using?
Shaka 3.2.0
Can you reproduce the issue with our latest release version?
Yes
Can you reproduce the issue with the latest code from master?
Yes
Are you using the demo app or your own custom app?
Own custom app
If custom app, can you reproduce the issue using our demo app?
Yes
What browser and OS are you using?
WebOS 4.1.4-5726
For embedded devices (smart TVs, etc.), what model and firmware version are you using?
LG 49UK6400PLF (From our tests the issue seems to appear on WebOS 4.1.4-4.4.0 and/or UK64XX models)
WebOS 4.1.4-5726
What are the manifest and license server URIs?
https://tr.prem.cdn.cosmotetvott.gr/sport1hd/sport1hd.isml/.mpd?ts=1616496517&dvr_window_length=3600&hdnts=st=1631020045~exp=1631063275~acl=*~id=c4c5311b-a47f-4d11-b73b-a1872d90fb75~data=e7e7c000a7679ede3910ba63cce989d6f032717b8110daf8d00b50897ca1342e~hmac=0503ff179eb5e824daec462ccebdc5931827d53e
What configuration are you using? What is the output of player.getConfiguration()?
{ "drm": { "retryParameters": { "maxAttempts": 1, "baseDelay": 500, "backoffFactor": 1, "fuzzFactor": 0.1, "timeout": 30000, "stallTimeout": 5000, "connectionTimeout": 10000 }, "servers": { "com.widevine.alpha": "https://widevine.entitlement.eu.theplatform.com/wv/web/ModularDrm/getRawWid…Hm9xc7g&account=http://access.auth.theplatform.com/data/Account/2703510745" }, "clearKeys": {}, "advanced": { "com.widevine.alpha": { "distinctiveIdentifierRequired": false, "persistentStateRequired": false, "videoRobustness": "SW_SECURE_CRYPTO", "audioRobustness": "SW_SECURE_CRYPTO", "sessionType": "", "serverCertificate": {}, "serverCertificateUri": "", "individualizationServer": "" } }, "delayLicenseRequestUntilPlayed": false, "logLicenseExchange": false, "updateExpirationTime": 1, "preferredKeySystems": [] }, "manifest": { "retryParameters": { "maxAttempts": 1, "baseDelay": 500, "backoffFactor": 1, "fuzzFactor": 0.1, "timeout": 30000, "stallTimeout": 5000, "connectionTimeout": 10000 }, "availabilityWindowOverride": null, "disableAudio": false, "disableVideo": false, "disableText": false, "disableThumbnails": false, "defaultPresentationDelay": 0, "dash": { "clockSyncUri": "", "ignoreDrmInfo": false, "disableXlinkProcessing": false, "xlinkFailGracefully": false, "ignoreMinBufferTime": false, "autoCorrectDrift": true, "initialSegmentLimit": 1000, "ignoreSuggestedPresentationDelay": false, "ignoreEmptyAdaptationSet": false, "ignoreMaxSegmentDuration": false, "keySystemsByURI": { "urn:uuid:1077efec-c0b2-4d02-ace3-3c1e52e2fb4b": "org.w3.clearkey", "urn:uuid:edef8ba9-79d6-4ace-a3c8-27dcd51d21ed": "com.widevine.alpha", "urn:uuid:9a04f079-9840-4286-ab92-e65be0885f95": "com.microsoft.playready", "urn:uuid:79f0049a-4098-8642-ab92-e65be0885f95": "com.microsoft.playready", "urn:uuid:f239e769-efa3-4850-9c16-a903c6932efb": "com.adobe.primetime" } }, "hls": { "ignoreTextStreamFailures": false, "ignoreImageStreamFailures": false, "useFullSegmentsForStartTime": false } }, "streaming": { "retryParameters": { "maxAttempts": 2, "baseDelay": 1000, "backoffFactor": 2, "fuzzFactor": 0.5, "timeout": 30000, "stallTimeout": 5000, "connectionTimeout": 10000 }, "rebufferingGoal": 1, "bufferingGoal": 10, "bufferBehind": 0, "ignoreTextStreamFailures": false, "alwaysStreamText": false, "startAtSegmentBoundary": false, "gapDetectionThreshold": 0.1, "smallGapLimit": 4, "jumpLargeGaps": true, "durationBackoff": 1, "forceTransmuxTS": false, "safeSeekOffset": 5, "stallEnabled": true, "stallThreshold": 1, "stallSkip": 0, "useNativeHlsOnSafari": true, "inaccurateManifestTolerance": 2, "lowLatencyMode": false, "autoLowLatencyMode": false, "forceHTTPS": false, "preferNativeHls": false, "updateIntervalSeconds": 1 }, "offline": { "usePersistentLicense": true }, "abr": { "enabled": true, "useNetworkInformation": true, "defaultBandwidthEstimate": 5000000, "switchInterval": 8, "bandwidthUpgradeTarget": 0.85, "bandwidthDowngradeTarget": 0.95, "restrictions": { "minWidth": 0, "maxWidth": null, "minHeight": 0, "maxHeight": null, "minPixels": 0, "maxPixels": null, "minFrameRate": 0, "maxFrameRate": null, "minBandwidth": 0, "maxBandwidth": null } }, "preferredAudioLanguage": "el", "preferredTextLanguage": "el", "preferredVariantRole": "", "preferredTextRole": "", "preferredAudioChannelCount": 2, "preferredVideoCodecs": [], "preferredAudioCodecs": [], "preferForcedSubs": false, "preferredDecodingAttributes": [], "restrictions": { "minWidth": 0, "maxWidth": null, "minHeight": 360, "maxHeight": null, "minPixels": 0, "maxPixels": null, "minFrameRate": 0, "maxFrameRate": null, "minBandwidth": 0, "maxBandwidth": null }, "playRangeStart": 0, "playRangeEnd": null }
What did you do?
When playing a 1080p/50fps stream, it stalls roughly every 15-20 seconds. The stall duration is about 500ms. Altering some of the player params didn't lead to any success.
This issue started from version 3.0.0. 2.5.X versions worked fine with no stalls. I'm also attaching two screenshots with the logs during a stall.

We are experiencing the same issue. Is there any updates regarding this?

We don't have official support for WebOS yet.  At this time WebOS support is community-maintained.
Without WebOS testing integrated into our lab, there is nothing we can do to debug a WebOS issue right now.

We had the same issue on Webos 4 and solved it by decreasing buffer time of the player.
bufferingGoal: 3,
rebufferingGoal: 3

We had the same issue on Webos 4 and solved it by decreasing buffer time of the player.
bufferingGoal: 3, rebufferingGoal: 3

Not working for us, still reproducing multiple Stalls on WebOS TVs.

Can you test with v4.3.4? Thanks!


Will we support DomUtil?

I would like to use L.DomUtil functions, what is the best way to do inside Vue components? In case you can not make it, could you show me how to make work with Vue2Leaflet?
Thanks.

Hi @sangdth,
I'm not familiar with L.DomUtil but as Vue2Leaflet is just a wrapper you can use them.
L.DomUtil are just functions and don't require any Vue components.
Micka


allow customize numbering and supplement for mitex/mi

We can now do this by
#set math.equation(numbering: "(1)")

#mitex(`
  f(x) = \int_{-\infty}^\infty
    \hat f(\xi)\,e^{2 \pi i \xi x}
    \,d\xi
`) <eqt>

Just like the normal way of using typst.
But if we set the default values for numbering and supplement, this normal way will not work.
Is there a way to do both: using a normal set rule and also having the ability of passing arguments?

We can assume that #mitex is not math.equation so one should use #set mitex(numbering: (1)) if they want to have numbers by default.

passing arguments explicitly is useful when you want to number equations by hand. For example you only want to number some of your equations

Maybe we can add condition control? For example, the default parameter is auto, and if it detects that it is auto, arguments will not be passed to math.equation.

that make sense, I will fix that

BTW the default value for numbering in math.equation is none https://typst.app/docs/reference/math/equation/#parameters-numbering.
I guess the auto might make sense in some case but i didn't think too much. Just let you know about this.


Update in the Avatar component

It seems wrong to have both props and user in it. In the next step we already pass in the component props.author, which have name and avatarUrl attributes. So the user must be instead of props, isn't it?

Nope, all attributes in JSX become named keys in the props object.
You could destructure like this though:
function Avatar({user}) {
// ...
}


Sync BigQuery usage docs with current API

Note:  the client.jobs() example is science fiction, to be addressed in #1260.
Fixes #1259.

@dhermes any remaining issues?

LGTM. Sorry for the holdup.