PowerShell 7.1 preview 3 doesn't use configured date/time format

This should speak for itself:
> $PSVersionTable.PSVersion.ToString(); (Get-ItemProperty 'HKCU:\Control Panel\International' -name sTimeFormat).sTimeFormat;  (Get-ItemProperty 'HKCU:\Control Panel\International' -name sShortDate).sShortDate; Get-Date -DisplayHint Time; Get-Date | ConvertTo-Csv
7.0.1
HH:mm:ss
yyyy-MM-dd

10:03:10
"DisplayHint","DateTime","Date","Day","DayOfWeek","DayOfYear","Hour","Kind","Millisecond","Minute","Month","Second","Ticks","TimeOfDay","Year"
"DateTime","Friday, May 22, 2020 10:03:10","2020-05-22 00:00:00","22","Friday","143","10","Local","179","3","5","10","637257385901795718","10:03:10.1795718","2020"

> $PSVersionTable.PSVersion.ToString(); (Get-ItemProperty 'HKCU:\Control Panel\International' -name sTimeFormat).sTimeFormat;  (Get-ItemProperty 'HKCU:\Control Panel\International' -name sShortDate).sShortDate; Get-Date -DisplayHint Time; Get-Date | ConvertTo-Csv
7.1.0-preview.3
HH:mm:ss
yyyy-MM-dd

10:03:37 AM
"DisplayHint","DateTime","Date","Day","DayOfWeek","DayOfYear","Hour","Kind","Millisecond","Minute","Month","Second","Ticks","TimeOfDay","Year"
"DateTime","Friday, May 22, 2020 10:03:37 AM","5/22/2020 12:00:00 AM","22","Friday","143","10","Local","61","3","5","37","637257386170614178","10:03:37.0614178","2020"

Steps to reproduce

use the standard en-US culture
set the time format to 24-hr HH:mm:ss and date format to yyyy-MM-dd via Settings
run Get-Date | ConvertTo-Csv

Expected behavior
Time is formatted using 24-hr format, date using specified yyyy-MM-dd format.
Actual behavior
Time is formatted in 12-hr am/pm format, date using M/dd/yyyy format
Environment data
> $PSVersionTable

Name                           Value
----                           -----
PSVersion                      7.1.0-preview.3
PSEdition                      Core
GitCommitId                    7.1.0-preview.3
OS                             Microsoft Windows 10.0.18363
Platform                       Win32NT
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0…}
PSRemotingProtocolVersion      2.3
SerializationVersion           <IP_ADDRESS>
WSManStackVersion              3.0

Is this behaviour new in the latest preview or has it always been this way?

I would say it's new in preview 3. Too bad, I've just upgraded my last system, so I don't have any preview 2 system anymore.

We'll need to confirm if there was a change at some point or if this is the original behaviour.
Also, can you confirm if this is affected at all by using the -UseCulture parameter explicitly?

We use Datetime.ToLongTimeString() method for output in the case.
Also you could look (Get-Culture).DateTimeFormat.

ShortestDayNames                 : {Su, Mo, Tu, We…}
DayNames                         : {Sunday, Monday, Tuesday, Wednesday…}
AbbreviatedMonthNames            : {Jan, Feb, Mar, Apr…}
MonthNames                       : {January, February, March, April…}
IsReadOnly                       : True
NativeCalendarName               : Gregorian Calendar
AbbreviatedMonthGenitiveNames    : {Jan, Feb, Mar, Apr…}
MonthGenitiveNames               : {January, February, March, April…}

ShortestDayNames                 : {S, M, T, W…}
DayNames                         : {Sunday, Monday, Tuesday, Wednesday…}
AbbreviatedMonthNames            : {Jan, Feb, Mar, Apr…}
MonthNames                       : {January, February, March, April…}
IsReadOnly                       : True
NativeCalendarName               : Gregorian Calendar
AbbreviatedMonthGenitiveNames    : {Jan, Feb, Mar, Apr…}
MonthGenitiveNames               : {January, February, March, April…}

We'll need to confirm if there was a change at some point or if this is the original behaviour.
Also, can you confirm if this is affected at all by using the -UseCulture parameter explicitly?

> $PSVersionTable.PSVersion.ToString(); Get-Date | ConvertTo-Csv -UseCulture
7.0.1
"DisplayHint","DateTime","Date","Day","DayOfWeek","DayOfYear","Hour","Kind","Millisecond","Minute","Month","Second","Ticks","TimeOfDay","Year"
"DateTime","Friday, May 22, 2020 19:33:59","2020-05-22 00:00:00","22","Friday","143","19","Local","174","33","5","59","637257728391742480","19:33:59.1742480","2020"

> $PSVersionTable.PSVersion.ToString(); Get-Date | ConvertTo-Csv -UseCulture
7.1.0-preview.3
"DisplayHint","DateTime","Date","Day","DayOfWeek","DayOfYear","Hour","Kind","Millisecond","Minute","Month","Second","Ticks","TimeOfDay","Year"
"DateTime","Friday, May 22, 2020 7:34:45 PM","5/22/2020 12:00:00 AM","22","Friday","143","19","Local","63","34","5","45","637257728850632108","19:34:45.0632108","2020"

Looks like a regression indeed. @iSazonov do you know if there were any changes merged to this area of code since 7.1? I can't recall any at the moment.
Perhaps it's a regression or change in .NET Core?

Here's what I get with preview 2 on the same system:
> $PSVersionTable.PSVersion.ToString(); (Get-ItemProperty 'HKCU:\Control Panel\International' -name sTimeFormat).sTimeFormat;  (Get-ItemProperty 'HKCU:\Control Panel\International' -name sShortDate).sShortDate; Get-Date -DisplayHint Time; Get-Date | ConvertTo-Csv
7.1.0-preview.2
HH:mm:ss
yyyy-MM-dd

19:42:05
"DisplayHint","DateTime","Date","Day","DayOfWeek","DayOfYear","Hour","Kind","Millisecond","Minute","Month","Second","Ticks","TimeOfDay","Year"
"DateTime","Friday, May 22, 2020 19:42:05","2020-05-22 00:00:00","22","Friday","143","19","Local","14","42","5","5","637257733250149958","19:42:05.0149958","2020"

> $PSVersionTable.PSVersion.ToString(); Get-Date | ConvertTo-Csv -UseCulture
7.1.0-preview.2
"DisplayHint","DateTime","Date","Day","DayOfWeek","DayOfYear","Hour","Kind","Millisecond","Minute","Month","Second","Ticks","TimeOfDay","Year"
"DateTime","Friday, May 22, 2020 19:42:40","2020-05-22 00:00:00","22","Friday","143","19","Local","847","42","5","40","637257733608470239","19:42:40.8470239","2020"

I can not confirm. After I changed these format strings in registry and restarted PowerShell I get right outputs.

What? Where was changing the format strings in the registry mentioned here? 😕

To get things right I uninstalled preview 3 and installed preview 2
😜

I don't understand: there is an issue in preview 3, it has to be fixed!

I can repo. We need reliable repo steps.
You could download zip packages, install PowerShell side-by-side, run both version and check result (better on clean system).

You mean you can't repro?
I don't have a clean system to test on (could set up a test VM, but would take a significant amount of time).
I'll test with XCOPY-deployed SxS installations of preview 2 and preview 3.

Here's the outcome, using these launch scripts:
REM runpwsh.bat
cls
PATH=C:\WINDOWS\system32;C:\WINDOWS;C:\WINDOWS\System32\Wbem
.\pwsh -noprofile -file .\runtest.ps1

# runtest.ps1
$PSVersionTable.PSVersion.ToString()
(Get-ItemProperty 'HKCU:\Control Panel\International' -name sTimeFormat).sTimeFormat
(Get-ItemProperty 'HKCU:\Control Panel\International' -name sShortDate).sShortDate
Get-Date -DisplayHint Time
Get-Date | ConvertTo-Csv

Repro'ed on two different systems.

ShortestDayNames                 : {Su, Mo, Tu, We…}
DayNames                         : {Sunday, Monday, Tuesday, Wednesday…}
AbbreviatedMonthNames            : {Jan, Feb, Mar, Apr…}
MonthNames                       : {January, February, March, April…}
IsReadOnly                       : True
NativeCalendarName               : Gregorian Calendar
AbbreviatedMonthGenitiveNames    : {Jan, Feb, Mar, Apr…}
MonthGenitiveNames               : {January, February, March, April…}

ShortestDayNames                 : {S, M, T, W…}
DayNames                         : {Sunday, Monday, Tuesday, Wednesday…}
AbbreviatedMonthNames            : {Jan, Feb, Mar, Apr…}
MonthNames                       : {January, February, March, April…}
IsReadOnly                       : True
NativeCalendarName               : Gregorian Calendar
AbbreviatedMonthGenitiveNames    : {Jan, Feb, Mar, Apr…}
MonthGenitiveNames               : {January, February, March, April…}

What is time you change the datetime format?
The PowerShell versions use different .Net 5 Preview - 3 and 4.
You could download nightly build (it is on .Net 5.0 Preview5) and check again.
If you will see the issue you could discuss this in .Net Runtime repo.

I'm not sure I understand your question. When did I change the datetime format? That must've been when I installed the systems in the first place, 'cos as a software engineer I prefer 1) the English UI, so I changed the display language to English (my computers came with French Windows) 2) the ISO8601 YYYY-MM-DD date format. So I've probably never run any version of PowerShell with the default en-US date/time formats.
Where can I get the nightly builds from?
What is the .NET Core API that's used by PowerShell Core to convert a date/time to string? I need this information if I want to open an issue on .NET 5.0.

You can download night build from main page of the repository.
PowerShell uses Datetime.ToLongTimeString() method. All formats you get above with (Get-Culture).DateTimeFormat.

On that main page, I can see the status of the nightly builds in CI, but no download links. Am I missing something?
I'll try creating a C# test program and run it with various previous versions of .NET 5.

Press on the status icon and look artifacts under "Build for Windows".

Same repro:

The code that handles this is here:
https://github.com/PowerShell/PowerShell/blob/b1e998046e12ebe5da9dee479f20d479aa2256d7/src/Microsoft.PowerShell.Commands.Utility/commands/utility/CsvCommands.cs#L1045-L1067
With this code in mind, can you check what you get back for (Get-Date).ToString() and (Get-Date).PSObject.ToString()?
I'm reopening this as it doesn't look like we've gotten to the bottom of it yet. 🙂

What's the easy way to create a C# program that invokes that .ToString() method and run it under various previews of .NET 5?

🤔  OK, that definitely looks like a regression in .NET 5 then, nice find.
Dunno if there's an easy way, but you can specify which preview to run against with usually a global.json in the project folder; you can see an example in the global.json in this repo. 🙂

You will save time if you discuss with .Net Runtime experts.

That's what I want to do next... once I have found how to deploy the last 3 previews of .NET 5 side-by-side to run the C# test program against. I presume there are XCOPY-deployable zipfiles of those previews somewhere...

Can someone help me find those .NET bits (at least the versions used by PS7.1 preview 2 and preview 3)?

Maybe I'll just wait until preview 4, based on .NET 5 Preview 5, comes out, and test again there...

You can download nightly build - it is on .Net 5 Preview 5 already.

Good news!
But... when I reach https://powershell.visualstudio.com/PowerShell/_build/results?buildId=55455&view=artifacts&type=publishedArtifacts I get:

and clicking artifacts doesn't do anything. What am I doing wrong?
Sorry for sounding dumb, I'm definitely a GH CI rookie...

You can load nightly build from main page https://github.com/PowerShell/PowerShell#build-status-of-nightly-builds

That's exactly what I've been trying to do, see
Can't download PS nightly build.zip

Try "Artifacts" - button on the right.

What "Artifacts" button on the right? Please refer to my PSR slideshow, or make a screenshot on your own.
I presume you wanted a ProcMon log of me reproducing the problem? Here it is, with preview 3.
runpwsh.bat.procmon.202006150911.PML.zip

@sba923 I still suggest to open new issue in .Net Runtime.

That's what I've been aiming at for some time now, but I can't unless I can post a repro. For this, I need to know how to get a side-by-side deployment of different previews of .NET 5, and then write a C# program I would run against each of those .NET previews. I haven't been able to find out how to download and deploy those previews. Yet...

Download link https://dotnet.microsoft.com/download/dotnet/5.0?utm_source=dotnet-website&utm_medium=banner&utm_campaign=preview5-banner
You can use install scripts from the link.

Thanks for the hint.
But before I do this I'd like to test with a .NET 5 Preview 5-based build of PowerShell... ;-)

I think this is it ;-)
using System;

namespace DateTimeToString
{
    class Program
    {
        static void Main(string[] args)
        {
            string dotnetversion = System.Environment.Version.ToString();
            Console.WriteLine("dotnet version: {0}", dotnetversion);
            var now = System.DateTime.Now;
            string str = now.ToString();
            Console.WriteLine("DateTime.Now.ToString(): {0}", str);
        }
    }
}

gci -dir 'dotnet5p*' | % {
        $dotnetdir = $_.FullName
        "Testing in: " + $dotnetdir
        & ($dotnetdir + '\dotnet') --info | sls -raw 'Version:.*preview'
        & ($dotnetdir + '\dotnet') ($dotnetdir + '\DateTimeToString.dll')
}

Opened https://github.com/dotnet/runtime/issues/37897

In procmon log I see an access to ICU - I guess the issue could be related to the fact.

It seems .Net has an option to opt out ICU. You could try and see a result.

Here's what I get with "System.Globalization.Invariant": true if this is what you were referring to:

Formatting is incorrect whatever the .NET 5 preview version.

No, there is an option to switch back from ICU to Windows traditional API.

See https://docs.microsoft.com/en-us/dotnet/core/run-time-config/globalization#nls

Will test... The change to use ICU was introduced in .NET 5 preview 4...

Bingo!

The .NET folks marked my issue as a duplicate of https://github.com/dotnet/runtime/issues/37121, where @safern claims this was fixed for .NET 5 Preview 5--not what I see...
Am I correct to assume that you will not want to use NLS in PowerShell? IMVHO this would be a potential cause for PowerShell behaving differently on Windows and on other platforms.

The .NET folks marked my issue as a duplicate of dotnet/runtime#37121, where @safern claims this was fixed for .NET 5 Preview 5--not what I see...

That claim from my side was initially wrong as I thought https://github.com/dotnet/runtime/issues/37121 was a dupe of https://github.com/dotnet/runtime/issues/35638 which was fixed in Preview5. I expect to have a fix for https://github.com/dotnet/runtime/issues/37121 this week and hopefully will be able to port it to Preview6 on time.

Am I correct to assume that you will not want to use NLS in PowerShell?

PowerShell follows .Net (and OS) improvements. It would be amazing for users to discover that PowerShell works differently than other .Net and native OS applications.

@iSazonov I'm not sure I know how to interpret your answer. Are you (on behalf of the PowerShell team) in favor of aligning PowerShell on Windows with all other Windows applications (in which case NLS is the norm), or of aligning PowerShell on Windows with PowerShell on other platforms (in which case ICU's behavior will rule)?

For now, I might go for setting DOTNET_SYSTEM_GLOBALIZATION_USENLS=true in my global environment so that I get the expected behavior when running PowerShell 7.1 preview 3. Or I'll stick to using PowerShell 7.0.2 for any affected workloads.

@sba923 Since NLS and ICU have differences it can be a problem - one .Net application can work differently on different OS-es. MSFT has started to migrate to ICU. It was added in latest Window versions and .Net 5.0 uses ICU by default.
PowerShell 7.1 gets the enhancement automatically. The same is true for all .Net 5+ applications.

So you'll go for PS7.1 using ICU, and assuming this is backwards compatible e.g. abides by the user's settings, correct?

@sba923 7.1 will be on .Net 5.0. If the .Net will use ICU by default PowerShell will do the same.

Should be OK, provided this does not introduce severe breaking changes.

Expectedly, the issue is still present in 7.1 preview 4...

To give an update I have a PR out for the fix: https://github.com/dotnet/runtime/pull/38372

To give an update I have a PR out for the fix: dotnet/runtime#38372

Good! See my comment there about taking user changes into account on the flow. Does this need a code change on the PowerShell side of things?

If PowerShell 7.0 version sees the time (culture) changes immediately, then we get a breaking change.

If PowerShell 7.0 version sees the time (culture) changes immediately, then we get a breaking change.

How do you mean? That 7.1 should behave the same as 7.0? I don't know what 7.0's behavior is, but I would expect that it takes user changes into account dynamically.

PS C:\src\t> ($PSVersionTable.PSVersion).ToString(),(Get-Culture).DateTimeFormat.ShortDatePattern
7.1.0-preview.3
M/d/yyyy
PS C:\src\t> ($PSVersionTable.PSVersion).ToString(),(Get-Culture).DateTimeFormat.ShortDatePattern
7.0.1
yyyy-MM-dd

.Net fix was merged. We get it soon. (.Net 5.0 Preview7 ?)

.Net fix was merged. We get it soon. (.Net 5.0 Preview8)

What's the plan for testing? How difficult is it to make a private build of PS7.1 with that .NET fix in so that we can test for side effects / regressions ?

@sba923 You could build .Net locally and test. But it is not worth the effort. We can wait about a month.

Still waiting for .NET Preview 8 to be released...

PowerShell 7.1.0-preview.7 ships with .NET Preview 8, which should address this issue. Let us know if it hasn't.

I concur 😜
> $PSVersionTable.PSVersion.ToString(); (Get-ItemProperty 'HKCU:\Control Panel\International' -name sTimeFormat).sTimeFormat;  (Get-ItemProperty 'HKCU:\Control Panel\International' -name sShortDate).sShortDate; Get-Date -DisplayHint Time; Get-Date | ConvertTo-Csv
7.1.0-preview.7
HH:mm:ss
yyyy-MM-dd

18:08:34
"DisplayHint","DateTime","Date","Day","DayOfWeek","DayOfYear","Hour","Kind","Millisecond","Minute","Month","Second","Ticks","TimeOfDay","Year"
"DateTime","Thursday, September 10, 2020 18:08:35","2020-09-10 00:00:00","10","Thursday","254","18","Local","25","8","9","35","637353581150253074","18:08:35.0253074","2020"


defaults with address fields don't work

This question is using address_fields_with_defaults in interview_logic.py, and with some extra logging, I can confirm that it's setting all defaults of the address correctly (to the address of the logged in Tyler user). However, DA isn't showing those defaults to the user, or is erasing them somehow.
Guess of what could be happening:

default is just broken when trying to fill it in with code fields like this
the google auto complete is trying to autopopulate things, and some how already having value set in some inputs causes it to erase the other inputs.

Either way, it's likely an upstream issue, but I want to have some more information on how to proceed.

Happy to help investigate this


Add doctorfree/nvim-lazyman

Repo URL:
https://github.com/doctorfree/nvim-lazyman
Checklist:

[x] The plugin is specifically built for Neovim, or if it's a colorscheme, it supports treesitter syntax.
[x] The lines end with a .. This is to conform to awesome-list linting and requirements.
[x] The title of the pull request is Add/Update/Remove `username/repo`  (notice the backticks around `username/repo`) when adding a new plugin.
[x] The description doesn't mention that it's a Neovim plugin, it's obvious from the rest of the document. No mentions of the word plugin unless it's related to something else.
[x] The description doesn't contain emojis.
[x] Neovim is spelled as Neovim (not nvim, NeoVim or neovim), Vim is spelled as Vim (capitalized), Lua is spelled as Lua (capitalized), Tree-sitter is spelled as Tree-sitter.
[x] Acronyms should be fully capitalized, for example LSP, TS, YAML, etc.

Thanks for the PR!


⚠ OhDee has degraded performance

In 46dd45b, OhDee (https://ohdee.com.au) experienced degraded performance:

HTTP code: 200
Response time: 17450 ms

Resolved: OhDee performance has improved in eab406e.


Stack unwinding seems limited to a single frame

I'm trying to switch from https://github.com/google/glog to abseil for InstallFailureSignalHandler. With the former I was getting a full stack. With absl::InstallFailureSignalHandler({}); I'm getting a terse:
*** SIGSEGV received at time=1667849759 on cpu 5 ***
PC: @           0xfb3fa9  (unknown)  (anonymous namespace)::inducedFailure()
[1]    33171 segmentation fault (core dumped)

This is with abseil 20220623.1, when I used 20210324.1 I was getting more honest diagnostics containing
    @ ... and at least 1 more frames

I looked at the options in FailureSignalHandlerOptions, none of them seem applicable. Is full stack trace on failure possible with Abseil?

https://github.com/abseil/abseil-cpp/blob/master/.github/ISSUE_TEMPLATE/00-bug_report.md
This report does not contain sufficient information for us to look into this problem. Please provide all of the requested information from the bug report form.

Describe the bug
The stack trace rendered by a signal caught via
absl::InstallFailureSignalHandler({}) contains just a single frame.
Steps to reproduce the bug
Notice a single frame is printed by the binary whereas gdb prints all three frames:
% bin/a
*** SIGSEGV received at time=1667856423 on cpu 3 ***
PC: @           0x206a76  (unknown)  bar()
[1]    22351 segmentation fault (core dumped)  bin/a
% gdb bin-unwrapped/a.unwrapped
GNU gdb (GDB) 11.1
Reading symbols from bin-unwrapped/a.unwrapped...
(gdb) r
Starting program: bin-unwrapped/a.unwrapped
...
Program received signal SIGSEGV, Segmentation fault.
bar () at a/bar.cpp:2
2	  char c = *(static_cast<char*>(0));
(gdb) bt
#0  bar () at a/bar.cpp:2
#1  0x0000000000206a60 in foo () at a/foo.cpp:4
#2  0x0000000000206a4d in main (argc=1, argv=0x7fffffffe3f8) at a/a.cpp:8

What version of Abseil are you using?
20220623.1
What operating system and version are you using
Ubuntu 18.04, using Nix
What compiler and version are you using?
% PATH=/nix/store/4r36p9x75156bcrsxgi82bq2hmbkrb0r-llvm-binutils-wrapper-11.1.0/bin /nix/store/r147h09xzk3450psbxi0sy12fq8lqmzp-gcc-wrapper-10.3.0/bin/g++ --version
g++ (GCC) 10.3.0

What build system are you using?
Nix 2.10 (substantially wrapped and modified)
Additional context
Here's the complete setup:
% for i in a/*cpp; do echo "=== $i" ; cat $i; done
=== a/a.cpp
#include <absl/debugging/failure_signal_handler.h>

extern void foo();
extern char bar();

int main(int argc, char *argv[]) {
  absl::InstallFailureSignalHandler({});  // Using the default options
  foo();
  return bar();
}
=== a/bar.cpp
char bar() {
  char c = *(static_cast<char*>(0));
  return c+c;
}
=== a/foo.cpp
extern char bar();

void foo() {
  bar();
}

The program is built with a custom Nix wrapper which eventually runs
these commands under the hood:
% /nix/store/r147h09xzk3450psbxi0sy12fq8lqmzp-gcc-wrapper-10.3.0/bin/g++ -c a/bar.cpp -o /nix/store/jlg9jgd5p5scmcrmk92wdcw2zmba1vqf-a.a.__modules_bar.cpp/bar.o -ffile-prefix-map=/nix/store/kzlxpff7v14r1sm8gsy2xkpdxn85v913-absl-20220623.1/include/= -std=c++20 -ffunction-sections -fdata-sections -Wl,--gc-sections -O0 -g -Wl,--gdb-index -Wall -DDEV_BUILD -I. -I/nix/store/kzlxpff7v14r1sm8gsy2xkpdxn85v913-absl-20220623.1/include

% /nix/store/r147h09xzk3450psbxi0sy12fq8lqmzp-gcc-wrapper-10.3.0/bin/g++ -c a/foo.cpp -o /nix/store/8iq31ggc11cagfi5cf9dlbb2rm2ryi2y-a.a.__modules_foo.cpp/foo.o -ffile-prefix-map=/nix/store/kzlxpff7v14r1sm8gsy2xkpdxn85v913-absl-20220623.1/include/= -std=c++20 -ffunction-sections -fdata-sections -Wl,--gc-sections -O0 -g -Wl,--gdb-index -Wall -DDEV_BUILD -I. -I/nix/store/kzlxpff7v14r1sm8gsy2xkpdxn85v913-absl-20220623.1/include

% /nix/store/r147h09xzk3450psbxi0sy12fq8lqmzp-gcc-wrapper-10.3.0/bin/g++ -c a/a.cpp -o /nix/store/mwr7gwirgd3skx83881p36z555ypsl7k-a.a.__modules_a.cpp/a.o -ffile-prefix-map=/nix/store/kzlxpff7v14r1sm8gsy2xkpdxn85v913-absl-20220623.1/include/= -std=c++20 -ffunction-sections -fdata-sections -Wl,--gc-sections -O0 -g -Wl,--gdb-index -Wall -DDEV_BUILD -I. -I/nix/store/kzlxpff7v14r1sm8gsy2xkpdxn85v913-absl-20220623.1/include

% PATH=/nix/store/4r36p9x75156bcrsxgi82bq2hmbkrb0r-llvm-binutils-wrapper-11.1.0/bin /nix/store/r147h09xzk3450psbxi0sy12fq8lqmzp-gcc-wrapper-10.3.0/bin/g++ -o /nix/store/4zv4brd0vx5lgp40n19ijpvaqxdpsbwz-a.a/bin/a -std=c++20 -ffunction-sections -fdata-sections -Wl,--gc-sections -O0 -g -fuse-ld=lld -Wl,--gdb-index -Wall -DDEV_BUILD -I. -I/nix/store/kzlxpff7v14r1sm8gsy2xkpdxn85v913-absl-20220623.1/include /nix/store/1i6h486aakci7smpi95rbrfbxfg1k1fc-a.a.__modules_a.cpp/a.o /nix/store/8iq31ggc11cagfi5cf9dlbb2rm2ryi2y-a.a.__modules_foo.cpp/foo.o /nix/store/jlg9jgd5p5scmcrmk92wdcw2zmba1vqf-a.a.__modules_bar.cpp/bar.o -Wl,--start-group /nix/store/kzlxpff7v14r1sm8gsy2xkpdxn85v913-absl-20220623.1/lib/libabsl_cordz_sample_token.a /nix/store/kzlxpff7v14r1sm8gsy2xkpdxn85v913-absl-20220623.1/lib/libabsl_strerror.a /nix/store/kzlxpff7v14r1sm8gsy2xkpdxn85v913-absl-20220623.1/lib/libabsl_symbolize.a /nix/store/kzlxpff7v14r1sm8gsy2xkpdxn85v913-absl-20220623.1/lib/libabsl_random_internal_randen.a /nix/store/kzlxpff7v14r1sm8gsy2xkpdxn85v913-absl-20220623.1/lib/libabsl_examine_stack.a /nix/store/kzlxpff7v14r1sm8gsy2xkpdxn85v913-absl-20220623.1/lib/libabsl_random_internal_randen_hwaes.a /nix/store/kzlxpff7v14r1sm8gsy2xkpdxn85v913-absl-20220623.1/lib/libabsl_int128.a /nix/store/kzlxpff7v14r1sm8gsy2xkpdxn85v913-absl-20220623.1/lib/libabsl_graphcycles_internal.a /nix/store/kzlxpff7v14r1sm8gsy2xkpdxn85v913-absl-20220623.1/lib/libabsl_hashtablez_sampler.a /nix/store/kzlxpff7v14r1sm8gsy2xkpdxn85v913-absl-20220623.1/lib/libabsl_flags_reflection.a /nix/store/kzlxpff7v14r1sm8gsy2xkpdxn85v913-absl-20220623.1/lib/libabsl_stacktrace.a /nix/store/kzlxpff7v14r1sm8gsy2xkpdxn85v913-absl-20220623.1/lib/libabsl_bad_variant_access.a /nix/store/kzlxpff7v14r1sm8gsy2xkpdxn85v913-absl-20220623.1/lib/libabsl_leak_check.a /nix/store/kzlxpff7v14r1sm8gsy2xkpdxn85v913-absl-20220623.1/lib/libabsl_city.a /nix/store/kzlxpff7v14r1sm8gsy2xkpdxn85v913-absl-20220623.1/lib/libabsl_bad_any_cast_impl.a /nix/store/kzlxpff7v14r1sm8gsy2xkpdxn85v913-absl-20220623.1/lib/libabsl_random_internal_distribution_test_util.a /nix/store/kzlxpff7v14r1sm8gsy2xkpdxn85v913-absl-20220623.1/lib/libabsl_spinlock_wait.a /nix/store/kzlxpff7v14r1sm8gsy2xkpdxn85v913-absl-20220623.1/lib/libabsl_throw_delegate.a /nix/store/kzlxpff7v14r1sm8gsy2xkpdxn85v913-absl-20220623.1/lib/libabsl_flags_commandlineflag_internal.a /nix/store/kzlxpff7v14r1sm8gsy2xkpdxn85v913-absl-20220623.1/lib/libabsl_exponential_biased.a /nix/store/kzlxpff7v14r1sm8gsy2xkpdxn85v913-absl-20220623.1/lib/libabsl_random_seed_gen_exception.a /nix/store/kzlxpff7v14r1sm8gsy2xkpdxn85v913-absl-20220623.1/lib/libabsl_random_seed_sequences.a /nix/store/kzlxpff7v14r1sm8gsy2xkpdxn85v913-absl-20220623.1/lib/libabsl_low_level_hash.a /nix/store/kzlxpff7v14r1sm8gsy2xkpdxn85v913-absl-20220623.1/lib/libabsl_civil_time.a /nix/store/kzlxpff7v14r1sm8gsy2xkpdxn85v913-absl-20220623.1/lib/libabsl_flags_commandlineflag.a /nix/store/kzlxpff7v14r1sm8gsy2xkpdxn85v913-absl-20220623.1/lib/libabsl_random_distributions.a /nix/store/kzlxpff7v14r1sm8gsy2xkpdxn85v913-absl-20220623.1/lib/libabsl_malloc_internal.a /nix/store/kzlxpff7v14r1sm8gsy2xkpdxn85v913-absl-20220623.1/lib/libabsl_synchronization.a /nix/store/kzlxpff7v14r1sm8gsy2xkpdxn85v913-absl-20220623.1/lib/libabsl_raw_logging_internal.a /nix/store/kzlxpff7v14r1sm8gsy2xkpdxn85v913-absl-20220623.1/lib/libabsl_random_internal_pool_urbg.a /nix/store/kzlxpff7v14r1sm8gsy2xkpdxn85v913-absl-20220623.1/lib/libabsl_demangle_internal.a /nix/store/kzlxpff7v14r1sm8gsy2xkpdxn85v913-absl-20220623.1/lib/libabsl_periodic_sampler.a /nix/store/kzlxpff7v14r1sm8gsy2xkpdxn85v913-absl-20220623.1/lib/libabsl_failure_signal_handler.a /nix/store/kzlxpff7v14r1sm8gsy2xkpdxn85v913-absl-20220623.1/lib/libabsl_cordz_handle.a /nix/store/kzlxpff7v14r1sm8gsy2xkpdxn85v913-absl-20220623.1/lib/libabsl_cordz_functions.a /nix/store/kzlxpff7v14r1sm8gsy2xkpdxn85v913-absl-20220623.1/lib/libabsl_str_format_internal.a /nix/store/kzlxpff7v14r1sm8gsy2xkpdxn85v913-absl-20220623.1/lib/libabsl_flags_config.a /nix/store/kzlxpff7v14r1sm8gsy2xkpdxn85v913-absl-20220623.1/lib/libabsl_bad_optional_access.a /nix/store/kzlxpff7v14r1sm8gsy2xkpdxn85v913-absl-20220623.1/lib/libabsl_strings_internal.a /nix/store/kzlxpff7v14r1sm8gsy2xkpdxn85v913-absl-20220623.1/lib/libabsl_cord_internal.a /nix/store/kzlxpff7v14r1sm8gsy2xkpdxn85v913-absl-20220623.1/lib/libabsl_flags.a /nix/store/kzlxpff7v14r1sm8gsy2xkpdxn85v913-absl-20220623.1/lib/libabsl_raw_hash_set.a /nix/store/kzlxpff7v14r1sm8gsy2xkpdxn85v913-absl-20220623.1/lib/libabsl_flags_parse.a /nix/store/kzlxpff7v14r1sm8gsy2xkpdxn85v913-absl-20220623.1/lib/libabsl_statusor.a /nix/store/kzlxpff7v14r1sm8gsy2xkpdxn85v913-absl-20220623.1/lib/libabsl_flags_marshalling.a /nix/store/kzlxpff7v14r1sm8gsy2xkpdxn85v913-absl-20220623.1/lib/libabsl_cord.a /nix/store/kzlxpff7v14r1sm8gsy2xkpdxn85v913-absl-20220623.1/lib/libabsl_random_internal_randen_hwaes_impl.a /nix/store/kzlxpff7v14r1sm8gsy2xkpdxn85v913-absl-20220623.1/lib/libabsl_flags_usage_internal.a /nix/store/kzlxpff7v14r1sm8gsy2xkpdxn85v913-absl-20220623.1/lib/libabsl_time.a /nix/store/kzlxpff7v14r1sm8gsy2xkpdxn85v913-absl-20220623.1/lib/libabsl_time_zone.a /nix/store/kzlxpff7v14r1sm8gsy2xkpdxn85v913-absl-20220623.1/lib/libabsl_base.a /nix/store/kzlxpff7v14r1sm8gsy2xkpdxn85v913-absl-20220623.1/lib/libabsl_scoped_set_env.a /nix/store/kzlxpff7v14r1sm8gsy2xkpdxn85v913-absl-20220623.1/lib/libabsl_strings.a /nix/store/kzlxpff7v14r1sm8gsy2xkpdxn85v913-absl-20220623.1/lib/libabsl_cordz_info.a /nix/store/kzlxpff7v14r1sm8gsy2xkpdxn85v913-absl-20220623.1/lib/libabsl_flags_internal.a /nix/store/kzlxpff7v14r1sm8gsy2xkpdxn85v913-absl-20220623.1/lib/libabsl_flags_program_name.a /nix/store/kzlxpff7v14r1sm8gsy2xkpdxn85v913-absl-20220623.1/lib/libabsl_hash.a /nix/store/kzlxpff7v14r1sm8gsy2xkpdxn85v913-absl-20220623.1/lib/libabsl_status.a /nix/store/kzlxpff7v14r1sm8gsy2xkpdxn85v913-absl-20220623.1/lib/libabsl_random_internal_seed_material.a /nix/store/kzlxpff7v14r1sm8gsy2xkpdxn85v913-absl-20220623.1/lib/libabsl_debugging_internal.a /nix/store/kzlxpff7v14r1sm8gsy2xkpdxn85v913-absl-20220623.1/lib/libabsl_log_severity.a /nix/store/kzlxpff7v14r1sm8gsy2xkpdxn85v913-absl-20220623.1/lib/libabsl_flags_private_handle_accessor.a /nix/store/kzlxpff7v14r1sm8gsy2xkpdxn85v913-absl-20220623.1/lib/libabsl_flags_usage.a /nix/store/kzlxpff7v14r1sm8gsy2xkpdxn85v913-absl-20220623.1/lib/libabsl_random_internal_randen_slow.a /nix/store/kzlxpff7v14r1sm8gsy2xkpdxn85v913-absl-20220623.1/lib/libabsl_random_internal_platform.a -Wl,--end-group

% /nix/store/7iv8vfrk1gyns0rxhr72h6b1lszg0xgn-patchelf-0.13/bin/patchelf --shrink-rpath /nix/store/4zv4brd0vx5lgp40n19ijpvaqxdpsbwz-a.a/bin-unwrapped/a.unwrapped

Switching to glog-0.6.0 yields a nicely complete version:
% bin/a
*** Aborted at<PHONE_NUMBER> (unix time) try "date -d @1667857676" if you are using GNU date ***
PC: @                0x0 (unknown)
*** SIGSEGV (@0x0) received by PID 28948 (TID 0x7f86fbe60e40) from PID 0; stack trace: ***
    @     0x7f86fc3ab33e google::(anonymous namespace)::FailureSignalHandler()
    @     0x7f86fbec0c40 (unknown)
    @           0x20189f bar()
    @           0x201893 foo()
    @           0x20187b main
    @     0x7f86fbeac790 __libc_start_main
    @           0x2017aa _start
    @                0x0 (unknown)

As I was staring at glog output I noticed that it's superior in one more minor way: it prints the address that caused the failure SIGSEGV (@0x0) which is sadly lacking from abseil output.

I spent a bit more time isolating the issue and it seems to be specific to nix. I used this CMakeLists.txt with my cpp files above.
cmake_minimum_required(VERSION 3.5)

project(my_project)

# Abseil requires C++14
set(CMAKE_CXX_STANDARD 14)
set(ABSL_PROPAGATE_CXX_STD ON)

# Process Abseil's CMake build system
add_subdirectory(abseil-cpp)

add_executable(hello_world a.cpp bar.cpp foo.cpp)

# Declare dependency on the absl::strings library
target_link_libraries(hello_world absl::strings absl::failure_signal_handler)

I ran in two configurations:

Ubuntu-18 with gcc-10 and g++-10 packages

CC=gcc-10 CXX=/usr/bin/g++-10 cmake .. && cmake --build . --target hello_world

Nix

nix-shell -p gcc cmake
CC=$(which gcc) CXX=$(which g++) cmake .. && cmake --build . --target hello_world

The resulting binaries are pretty different:
-rwxr-xr-x 1 greg greg 173048 Nov  8 13:59 build-gcc-10/hello_world
-rwxr-xr-x 1 greg greg 154056 Nov  8 14:02 build-nix/hello_world

Output of nm in both configurations.

The failure is easy to reproduce with docker. Complete log


[TASK] Add from_dataset & to_dataset to EmbeddingTable

This is part of getting a common API between converting certain blocks from and to a dataset.

@marcromeyn please link the PR

Completed in https://github.com/NVIDIA-Merlin/models/pull/761


xinit: don't unset DBUS_SESSION_BUS_ADDRESS in startx

Motivation for this change
startx unsets DBUS_SESSION_BUS_ADDRESS, which makes the dbus session instance unavailable to some application started beneath startx (notably libreoffice, which starts its own private session bus and neglects to clean it up later, littering the system with unreachable dbus instances over time)
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[x] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)

startx only, didn't unset the env var anymore as expected

[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 120064 at 800a61c2 run on aarch64-linux 1

3 packages built successfully:

x11docker
x2goserver
xorg.xinit


add a supertype constraint

currently when we see a constraint <A extends B> it means A is a subtype of B, so that
declare var a: A;
declare var b: B;
b = a; // allowed
a = b; // not allowed

consider adding a new constraint of the reversed relation: <A within B> that would mean A is a supertype of B (or in other words B is subtype of A), so that:
declare var a: A;
declare var b: B;
b = a; // not allowed
a = b; // allowed

use case
i have a BigFatClass with 50 methods and a 1 little property, now i want to run some assertions  over it, if i declare these assertions like expect<T>() and toEqual<T> of the same T then toEqual asks me for 50 methods that don't matter for the test, and that's the problem
what i need it to declare expect<T>() and toEqual<U within T>() so that i could simply write:
expect(new BigFatClass()).toEqual({ value: true });

Can't you use Partial<T> for your assertion?

@aaronbeall yes, it should work for this very use case, thanks for an idea

Most recent one tracking this is #14520

thanks


Missing release 1.17.0 for darwin

this exists: https://api.pulumi.com/releases/plugins/pulumi-resource-aws-v1.17.0-linux-amd64.tar.gz
this does not exists: https://api.pulumi.com/releases/plugins/pulumi-resource-aws-v1.16.0-darwin-amd64.tar.gz

Hi @MasseGuillaume
there was an issue on the publish for the 1.17.0 release - I am going to republish the binaries very shortly
Paul


adding a test shell dir

the e2e test is a TODO.
Proposed Changes

Add test dir.

Release Note
NONE

the new feature is awesome.


Added Russian Translations

Added:

Russian Translations

Fixed:

corrected .gitignore rules for default modules (Reasoning behind change: when I added translation for alert module git add was telling me that .gitignore rule excludes files and folders under modules/default)

I also noticed that .gitignore:56 has following declaration:
# Don't ignore the node_helper nore module.
!/modules/node_helper
!/modules/node_helper/**

but I don't think this directory structure exists today (also there is a small typo)

@morozgrafix Looks good, but there is a pull request that was merged from @MichMich in there that already occurred in the master branch. I recommend that you close this pull request and re-add it after updating your branch. Otherwise, looks good!

Thanks I will do that.

@nhubbard Sorry I'm a bit confused. I think my branch was updated with latest master yesterday and commit log shows similar pattern as #596 that was approved. I think my fork is in sync with master at this point.

Are you talking about this one? https://github.com/MichMich/MagicMirror/commit/41ca7e6d308b939747502e7360ac731534d22306

@morozgrafix Could be the extra merges included in this Pull Request.
An Pull Request with two commit are more beautiful :).
Close the Pull Request is not neccesarry. You can override your branch and pushed with --force

@roramirez thanks, I'm in process of making a new PR at the moment. Ended up in a weird mess :) and started over. I need more coffee this morning.

Closing, proposed changes are in #601


Example site?

Any place where an example is being used?

dat://fritter.hashbase.io uses webDB

You can view the source of the underlying library here: https://github.com/beakerbrowser/libfritter


ARROW-15779: [Python] Create python bindings for Substrait consumer

The PR includes the initial integration of Substrait to Python

[x] Adding a util API for consuming Substrait
[x] Adding a C++ example for using Substrait with Util API
[x] Adding Python Bindings for Substrait using the Util API
[x] Adding CMake changes to integrate engine module (experimental) : comments and suggestions are much appreciated to improve this component
[x] Adding a Python example to consume a Substrait plan (experimental)

Hmm, did you mean to delete the testing submodule?

@lidavidm no I wrongly checked in files of testing submodule. I just wanted to remove that.

All tests are failing, seems like it needs to be rebased against Weston's recent refactoring?

All tests are failing, seems like it needs to be rebased against Weston's recent refactoring?

Thank you. Let me do that.

cc @lidavidm @westonpace following this refactor
option(PYARROW_BUILD_ENGINE "Build the PyArrow Engine integration" OFF)

should be changed to
option(PYARROW_BUILD_SUBSTRAIT "Build the PyArrow Substrait integration" OFF)

There's still test failures. Can we just do the 'dumb' thing that seems to work? https://github.com/apache/arrow/blob/dc97883dee25ba8da55c7591060c44de2ea00865/cpp/src/parquet/test_util.cc#L42-L72
Or else looks like we have to fix arrow::internal::PlatformFilename under MinGW.

Also @vibhatha, it is possible to set up MinGW under a Windows VM so that you can debug more quickly…unless you only have an ARM machine?

@lidavidm Yes I only have an Arm machine.
I didn’t add a fix for Windows yet, just solved the conflicts. But, trying it now.

There's still test failures. Can we just do the 'dumb' thing that seems to work?

@lidavidm what do you mean by "seems to work"? Hardcoding some value?

I linked the example of how other tests use PARQUET_TEST_DATA.

There's still test failures. Can we just do the 'dumb' thing that seems to work?
https://github.com/apache/arrow/blob/dc97883dee25ba8da55c7591060c44de2ea00865/cpp/src/parquet/test_util.cc#L42-L72
Or else looks like we have to fix arrow::internal::PlatformFilename under MinGW.

@lidavidm It seems like the path issue is related to Substrait internals. How we handle the path is not compatible with Windows. For this PR going to skip windows and create a follow up PR to fix the issue.
cc @westonpace
Filed the JIRA: https://issues.apache.org/jira/browse/ARROW-16392
Will be working on this after merging this PR. We can use the existing test case to evaluate it and enable the test for windows too.

What exactly is the issue on Windows? file:/// URIs are supported on Windows. It seems you just have to generate the right URI instead of naively concatenating the path?

Or is the problem that the API doesn't convert the path back from a URI into a file path correctly?

@lidavidm
I tried passing the expected input format for a Windows compatible url. But internally I am not sure it’s done properly.
cc @westonpace

@lidavidm I am curious about one thing. PyTests are not failing, eventhough I am using the same C++ code base.
I am curious if the way path taken in Python has anything to do with this or not.
Where do we run PyArrow tests on Windows? I couldn't clearly figure out the Python CIs running on Windows. Could you point me to one?

I'm not sure what you mean. AppVeyor was failing until the skip was added. And in fact the Python tests never ran because the C++ tests were failing.

There's also nightly builds

Or is the problem that the API doesn't convert the path back from a URI into a file path correctly?

@lidavidm
Correct.  There is some dubious path handling in relation_internal.cc.  It should be an easy fix but there are a few related issues (using proper URI parsing, supporting non-local filesystems) that could be addressed at the same time and I didn't want to add any more tangents to this PR so I suggested handling in a follow-up.

I see, sounds good then.

@westonpace I will address these. Thank you.

Ok, so it looks like this is triggering a compilation error on MSVC, even though the offending code isn't directly touched by this PR:
https://github.com/apache/arrow/runs/6390652707?check_suite_focus=true#step:7:1337
@westonpace Do you have a clue about this? Has this been seen already?

I haven't seen this before.  I'll take a look.

@pitrou @westonpace I will work on the suggestions. And about test cases, may be we can start a thread to discuss?

Sorry, I had missed the context regarding test relevance.  I've replied in the existing thread.

The python/cython code looks good to me.
I was playing a little bit with it, and ran into the following segfault (although I suppose this is a general substrait bug and not necessarily related to this PR).
If I replace the FILENAME_PLACEHOLDER in the query in the tests with a nonexistent filename, I get a segfault:
In [41]: query = substrait_query.replace("FILENAME_PLACEHOLDER", "/home/joris/scipy/test_wrong.arrow")

In [42]: buf = pa._substrait._parse_json_plan(query.encode())

In [43]: reader = substrait.run_query(buf)
../src/arrow/engine/substrait/util.cc:70:  Check failed: _s.ok() Operation failed: this->Close()
Bad status: IOError: Failed to open local file '/home/joris/scipy/test_wrong.arrow'
../src/arrow/io/file.cc:110  ::arrow::internal::FileOpenReadable(file_name_)
../src/arrow/io/file.cc:320  file->impl_->Open(path)
../src/arrow/dataset/file_ipc.cc:70  source.Open(). Detail: [errno 2] No such file or directory
/home/joris/miniconda3/envs/arrow-dev/lib/libarrow.so.800(+0x12c6476)[0x7faf77cd4476]
....

At the very least, that is something that we could fix if we added an explicit close method to the record batch reader (which I think we are planning on doing in a follow-up?)
However, it does seem that particular error should be returned when you tried to access the next item in the record batch reader and not as part of the run_substrait_query method.

@vibhatha Can you rebase this to try and get a clean CI run?
Also, the segfault should really be fixed, either now or very soon in an upcoming PR.

At the very least, that is something that we could fix if we added an explicit close method to the record batch reader (which I think we are planning on doing in a follow-up?)

Yes we are, the JIRA is here: https://issues.apache.org/jira/browse/ARROW-16515
I think we can build on top of this.

However, it does seem that particular error should be returned when you tried to access the next item in the record batch reader and not as part of the run_substrait_query method.

Mmm... about this, shouldn't we do a validation in the I/O handling part within Substrait?

@vibhatha Can you rebase this to try and get a clean CI run?
Also, the segfault should really be fixed, either now or very soon in an upcoming PR.

@pitrou I will check this on this PR itself.

Mmm... about this, shouldn't we do a validation in the I/O handling part within Substrait?

If we are given a directory name or a glob we have to do the file I/O while we are converting from Substrait -> Arrow (long term we probably want to defer this I/O to scan time).
However, if we are given files we don't do any I/O until we start scanning.

If the user never tries to read from the reader then I would expect to get a segmentation fault:
reader = substrait.run_query(buf)
del reader # This should segfault

I think, without a close method, our only other option would be to ignore the error which seems even worse to me than a segfault.

I see your point. That's bad, I agree. Shall we extend work on this and manage the Reader itself in this PR or should we block merging this until finalizing the Reader close PR and rebase this and merge.
I prefer the latter.
cc @pitrou @lidavidm @jorisvandenbossche

Can you revert 0ba47960ac0688b1cce3172cdb0fd51b8c05bb46 ?  I think it only confuses things.  Since SubstraitSinkConsumer is inside an internal namespace it is local to the file.  If you wanted to make it more generally available you'd have to move it out of the file and add a header file.  However, I don't think that is a good idea, per my comment above.
Once that is reverted let's leave this alone and merge if green.  I agree run_query_as_reader might be a good idea but let us defer that to a follow-up PR.  This one is getting unwieldy.

@westonpace About this: https://github.com/apache/arrow/pull/12672#issuecomment-1130125911
I started working on: https://issues.apache.org/jira/browse/ARROW-16515
We need this to merge this PR, right?

We need this to merge this PR, right?

As long as we are committed to finishing ARROW-16515 quickly I think it's ok to proceed with merging this PR.  We are pretty far from the next release and there are a lot of things we still need to do for this to be a meaningful feature anyways (documentation, an option to read to a table, better testing, enough support of ACE capabilities in the consumer, etc.).

@westonpace Sure, I understand. Btw just added the draft PR for ARROW-16515 (https://github.com/apache/arrow/pull/13205)


ci: fixed publish build

Please describe the changes this PR makes and why it should be merged:
Status

[x] Code changes have been tested.

Semantic versioning classification:

[ ] This PR includes new feature, methods or parameters

[ ] This PR includes breaking changes (feature, methods, parameters removed or renamed)

[x] This PR only includes non-code(typo, documentation etc.) changes

가능한 빨리 처리 부탁드립니다 🙏

Since discord.js is peer dep, the dep is not installed and the building is failing.

No better idea :( I'll change it like this


move the website to harvey-os/web

@fuchicar should merge this when the he switches the pull script to the new repo

The new github repo is not updated with blog changes and the new content in "Community" made by Alvaro.


feature: Lit integration

It would be nice for Preact signals to integrate with Lit and lit-html. I think it would be a fairly light wrapper, involving their async directive.
I did some experimentation with a similar concept here.  Thoughts? Can I open a PR? :)

Can I open a PR? :)

Absolutely! More tools supported the better!

Looks like Lit has created their own signals integration, which can be found here: @lit-labs/preact-signals
Going to close this on out


Should 2.5.0 require version 2.0 of UIImageViewModeScaleAspect?

Quick question -
Should 2.5.0 be bumped to point at the Swift 3 version of UIImageViewModeScaleAspect?

The older Obj-C version works fine for now


run OAuth and PKI CI workflows on pull request

Note: pull request runs should not execute cypress tests via cypress cloud to keep within test limits

using #2462


Proxy support?

Will there be a way to set the proxy and proxy authentication through the code any time soon? Maybe something like "set_proxy(proxy_server=proxy_server, proxy_port=proxy_port, proxy_user=proxy_user, proxy_password=proxy_password)"

Marking as feature request. We will consider adding support.

dirty but
import os
os.environ['http_proxy'] = "http://user:password@server:port"
works for me

The problem is that this sets the proxy for the whole process which can interfere with other HTTP requests.

This is a problem for our use case, as setting the http proxy means we can't use our pip index.

This PR might resolve the issue : https://github.com/boto/botocore/pull/1228
Similar discussion : https://github.com/boto/boto3/issues/338

@PVSec - Does the solution provided in this PR resolve your issue ?
Link to the boto3 documentation on use of proxy:
https://botocore.amazonaws.com/v1/documentation/api/latest/reference/config.html
This is the stack overflow link which explains how to use proxy for boto3:
https://stackoverflow.com/questions/33480108/how-do-you-use-an-http-https-proxy-with-boto3

Looks good


Just Passwall 2

Hi guys , can you tell & teach me about how can install just passwall2 ? because when download says failed to download from
((https://master.dl.sourceforge.net/project/openwrt-passwall-build/releases/packages-23.05/arm_cortex-a7_neon-vfpv4/passwall_packages/Packages.gz )) ,

rm -f ezp.sh && wget https://raw.githubusercontent.com/peditx/EZpasswall/refs/heads/main/ezp.sh && chmod -X ezp.sh && sh ezp.sh
duh


Update vscode debugging port for combined docker runner

Change description
For the combined docker runner, the debugging port for data-store has been updated: https://github.com/communitiesuk/funding-service-design-docker-runner/pull/71

It is done 🙇


database locked when non commited transaction

https://gist.github.com/PricelessRabbit/1e8a515364db5da19ee0d107b25928ce
If a transaction remains "pending" (no commit and no rollback), the db remains locked until the go process is restarted.
In the gist i created 2 different transaction. One of them (wrongTransaction) is not committed and there is no rollback. When de goroutine exits the reference to the transaction is lost, and it is impossilble to unlock the database (Process must be restarted). Are there any workarounds / solutions to ensure that db remains usable.
Because in long running processes like a web server in case of some malfunctions of a transaction / deferred db close reboot the process is not an option.
I have the issue also in WAL / shared cache. Also setting the db.SetMaxOpenConns(1) results in a deadlock
Maybe i'm missing something? it's possible to set a timer or something like that to delegate the sql driver to manage "lost" transactions?

The best thing to do would be to defer t.Rollback() right after db.Begin(). That way it is impossible for the transaction to leak. Rollback is effectively a no-op if the transaction has already been rolled back or committed.
tx, err := db.Begin()
if err != nil {
    return err
}
defer tx.Rollback()

...

return tx.Commit()

The best thing to do would be to defer t.Rollback() right after db.Begin(). That way it is impossible for the transaction to leak. Rollback is effectively a no-op if the transaction has already been rolled back or committed.
tx, err := db.Begin()
if err != nil {
    return err
}
defer tx.Rollback()

...

return tx.Commit()

@rittneje yes i implemented it in that way. But i'm worried if can be cases in which the defer rollback fails (i dont know if it is possible) and then there is no way to "recover" from the locked database.

As far as I know, it is impossible for the rollback to ever truly fail. (That is, your database won't be left with some orphaned transaction in progress.) I would recommend posting on the SQLite forum if you want further clarification.


journald logs: drain 1 more time at container exit

In the journald log driver, attempt to drain the journal 1 more time
after being told to stop following the log. Due to a possible race
condition, sometimes data is written to the journal at almost the same
time the log watch is closed, and depending on the order of operations,
sometimes you miss the last journal entry.

- What I did
- How I did it
- How to verify it
- Description for the changelog

- A picture of a cute animal (not mandatory but encouraged)

Comments in code does make sense to me, @nalind would confirm

@runcom did you see the comment on the upstream PR about restructuring the loop to make it cleaner?

I did, yes, that can go in upstream master (or 1.13, 1.14.0 branches here). As far as this PR is concerned, this code looks ok (minus the loop refactor, which should not change logic here right?)

Right
On Tue, Jan 10, 2017 at 6:28 AM, Antonio Murdaca<EMAIL_ADDRESS>wrote:

I did, yes, that can go in upstream master (or 1.13, 1.14.0 branches
here). As far as this PR is concerned, this code looks ok (minus the loop
refactor, which should not change logic here right?)
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/projectatomic/docker/pull/220#issuecomment-271552172,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAABYtVYsK44BSs-KeCYrryBR5rysS2Lks5rQ2tBgaJpZM4LaCrh
.

So, this PR is against docker-1.12.5 but we moved to docker-1.12.6 just yesterday.
The upstream PR will move at its own pace since what they're suggesting is just a code cleanup which isn't affecting the logic @ncdc is adding here (and upstream).
I'd say, if @nalind can chime in and LGTM this PR, I'll cherry-pick this commit directly in docker-1.12.6.
/cc @rhatdan

ping bump ping

Looks safe to me.  Ultimately we're hoping that journald has written the last of the messages that it's going to write for the container before we stop looking for them in the journal.

cherry-picked into docker-1.12.6 and docker-1.13


Workflow not working in laravel 5.3.* version

Hi Andrea,
Hope you are good. I am planning to implement workflow in one of my project, which is on latest version of laravel 5.3.*. I follow the steps mention in plug-in document, all goes with a happy flow. I successfully created workflow and depending files and folders auto generated in project directory. But when trying to read workflow I am getting error workflow does not exist. Please help me on that.

I am able to run workflow example project on laravel 5.0.*. Its working fine on that version.
Thank in advance

In version 5.4 not work too

I also get an Exception when running this on php7.1
ErrorException in Encrypter.php line 303:
Function mcrypt_get_iv_size() is deprecated


Backlog quota: allow time-based quota

Retention policies can be set based on size or time limit (or both), while backlog quotas can only be based on size. The recommendations I've gotten are to set backlog quota to be equal to or less than the retention policy, but if the retention policy is based solely on time, the backlog quota cannot be certain to be less than the retention policy.

@flowchartsman You can use the message TTL to expire the backlogs of the subscription.

There's no backpressure policy applied to TTL though, unless I missed something. Even if I'm combining them, there's no way for me to ensure that backlog is less than TTL.

Yes, it needs to combine them to achieve the purpose.

It still feels inconsistent. With TTL there is no good backpressure strategy, and I am then still stuck with trying to guess whether or not backlog-quota fits into TTL time or not, since it is only measured in bytes.
This would also then require me to use retention, TTL and backlog quota, and the docs seem to indicate that this is unusual.

Yes, the TTL can't achieve the backpressure strategy by the time duration. Thanks for the clarification, I think this should be a new feature, so I will change the label to type/feature.

I'll try to add this feature.


Use of react-native-vector-icons with IconWithBar ?

Is it possible to use react-native-vector-icons with IconWithBar ?
https://github.com/oblador/react-native-vector-icons
Any suggestion are appreciated.
Thank you for a great tab bar!

yes, however, if you already have your font file contains all the icons, I would suggest you to use react-native-pure-icon instead. it's pure js and doesn't have any dependencies on native side. checkout the new version of react-native-tabbar since I have rewritten from scratch.


Missing lines in signature image

I am facing some trouble with this component. 90% of the time, the resulting signature (which I get using the signaturepad.GetImage() method) is missing some lines.
For example, if I sign by drawing XAMARIN as the signature, in the app it all looks perfect, no lines missing (see below):

but in the resulting image, a lot of lines are missing (see below)

Hi!
I am using aritchie's version of the signature pad https://github.com/aritchie/acr-xamarin-forms
It's based on the Xamarin SignaturePad and the same problem is visible there, some strokes are lost randomly on the actual drawing area.

I'm having all kinds of problems when printing letters especially with letter disappearing entirely.  Ie.  I'll print the name R o b and after the b is done - the o disappears.  See the video in this link for an example.
https://www.dropbox.com/s/m3mrt83qzka702b/xamarinsignaturepadissue.mov?dl=0

I have created a fork that fixes this issue in iOS: https://github.com/napoleond/SignaturePad
It's three lines of code. PR is here: https://github.com/xamarin/SignaturePad/pull/17
I assume that a similar change is possible in Android code, although I haven't tried yet.

Hi @napoleond , how can I ouse your fork? I have the same issue.

@fcogutierrez the simplest way is probably just to clone the repo and add the project(s) to your solution (in Visual Studio or Xamarin Studio). Usage is identical to the "official" component.

This is fixed in v2.0


Cylc not pinned to a tag

resolution_fixed   |    by<EMAIL_ADDRESS>
Cylc is being downloaded from master, rather than a tag

Issue migrated from trac:58 at 2024-01-31 17:28:43 +1100

<EMAIL_ADDRESS>commented

It looked like it was redownloading it when I did a puppet update - may be a vcsrepo issue. I'll take a look.

ibc599 changed status from new to assigned

<EMAIL_ADDRESS>commented

Looks like it is an issue with vcsrepo - https://github.com/puppetlabs/puppetlabs-vcsrepo/issues/55

<EMAIL_ADDRESS>changed priority from major to trivial

ibc599 changed reviews which not transferred by tractive

ibc599 commented

Currently, we are using the revision keyword for setting which version of cylc to be used.
eg revision => 5.4.6
Could you clarify what you mean?

<EMAIL_ADDRESS>changed status from assigned to accepted

Scott Wales<EMAIL_ADDRESS>changed status from accepted to closed

Scott Wales<EMAIL_ADDRESS>changed resolution from `` to fixed

<EMAIL_ADDRESS>changed owner from Admin to saw562

ibc599 changed owner from `` to Admin

<EMAIL_ADDRESS>commented

Milestone Future deleted

Scott Wales<EMAIL_ADDRESS>commented

In [changeset:"cfbbef59d6d01df65c165717daec009871bbc524/puppet"]:
#CommitTicketReference repository="puppet" revision="cfbbef59d6d01df65c165717daec009871bbc524"
'Puppet apply' cleanup

Remove most of the excess noise from running 'puppet apply'

Fixes #90, #58, #62

Merge branch 'saw562/rose-perms'

<EMAIL_ADDRESS>removed milestone (was Future)


Angular Universal build includes Source Maps from Component CSS/SCSS in built .html

Bug Report or Feature Request (mark with an x)
- [x] bug report -> please search issues before submitting
- [ ] feature request

Command (mark with an x)
- [ ] new
- [x] build
- [x] serve
- [ ] test
- [ ] e2e
- [ ] generate
- [ ] add
- [ ] update
- [ ] lint
- [ ] xi18n
- [ ] run
- [ ] config
- [ ] help
- [ ] version
- [ ] doc

Versions

Angular CLI: 7.0.4
Node: 8.12.0
OS: win32 x64 / Windows 10
Angular: 7.0.3
... animations, common, compiler, compiler-cli, core, forms
... http, language-service, platform-browser
... platform-browser-dynamic, platform-server, router
Package                           Version
@angular-devkit/architect         0.10.4
@angular-devkit/build-angular     0.10.4
@angular-devkit/build-optimizer   0.10.4
@angular-devkit/build-webpack     0.10.4
@angular-devkit/core              7.0.4
@angular-devkit/schematics        7.0.4
@angular/cli                      7.0.4
@ngtools/webpack                  7.0.4
@schematics/angular               7.0.4
@schematics/update                0.10.4
rxjs                              6.3.3
typescript                        3.1.6
webpack                           4.19.1
Repro steps

Minimal Reproduction in repo: https://github.com/visurel/angular-universal-issue-repro
Run npm run build:ssr && npm run serve:ssr and check the source code of the localhost:4000 result.
The log given by the failure

   <!DOCTYPE html>
    --  --
       <meta charset="utf-8">
       <title>NgUniversalDemo</title>
       <base href="/">

       <meta name="viewport" content="width=device-width, initial-scale=1">
       <link rel="icon" type="image/x-icon" href="favicon.ico">
       <link rel="stylesheet" href="styles.5f175451ae854810fe6d.css">

   <app-root ng-version="7.0.3">
Universal Demo using Angular and Angular CLI
HomeLazyLazy_Nested<router-outlet></router-outlet><app-test _nghost-sc0="">

       hall

</app-test></app-root>

Desired functionality

After upgrading from Angular 6 to Angular 7 I noticed sourceMaps from CSS/SCSS encoded in base64 get added to the Angular Universal build results. Above is the output with a single .css file for a component. When having dozens of components, these sourceMaps get huge and increase .html size unnecessarily.
I'd like to remove these sourceMappingURL=data:application/json;base64 blocks from my Universal builds.
Mention any other details that might be useful

I have the same problem. I can confirmed that  "sourceMap": false option in angular.json does not work when your stack is Angular 7.0.1 + Universal + SCSS. It causes bigger bundle size and poor performance in production.

Hi, taking a look at the reproduction.
You are not specifying sourceMaps to false.  https://github.com/visurel/angular-universal-issue-repro/blob/f3e7b4e22b9961ca7917808664243e0365036335/angular.json#L109-L126 Adding sourceMap: false, doesn't generate any sourceMap.
That said this is a bug and we should not output source maps in inline styles, as they are unusable.

Hi Alan,
For server settings (where you have highlighted) adding
"sourceMap": false fixed the issue for me. But again like you said there is a bug since it wasn't the case for angular 6.
Thank you very much!

Actually thinking about it, we should probably have sourcemaps for non bootstrapped apps.
That said, it’s a bummer if you want to enable sourcemaps to have better stack traces in your error reporter. But this applies also for the client bundle as component styles sourcemaps are always embeeed

Keeping need: further discussion for now and we should evaluate what we want for universal for v8, as any changes here would be a breaking change.

Hi, taking a look at the reproduction.
You are not specifying sourceMaps to false. https://github.com/visurel/angular-universal-issue-repro/blob/f3e7b4e22b9961ca7917808664243e0365036335/angular.json#L109-L126 Adding sourceMap: false, doesn't generate any sourceMap.
That said this is a bug and we should not output source maps in inline styles, as they are unusable.

Where, exactly did you put "sourceMaps": "false" in this? I've tried a few different places in the tree with no luck.

I had this:
projects": {
    "myProjectName": {
      ...
      "architect": {
        "build": {
          ...
          "configurations": {
            "production": {
              ...
              "sourceMap": false,
              ...
          }
          "serve": { ... }
          ...

but you need to include it under "server"
projects": {
    "myProjectName": {
      ...
      "architect": {
        "build": { ... },
         ...
        "server": {
          ...
          "configurations": {
            "production": {
              ...
              "sourceMap": false,
              ...

that fixed it for me.


Feat: replace spark raw type with k8s-objects

Description of your changes

replace spark raw type with k8s-objects

How has this code been tested

This should be committed to release-1.0 first then cherry-pick to main.


chore(main): release 0.19.0

:robot: I have created a release beep boop
0.19.0 (2024-05-31)
Features

add offline confirm modal component (b4c50f2)

Bug Fixes

use url if thumbnail is empty (9850b1f)

This PR was generated with Release Please. See documentation.

:robot: Release is at https://github.com/GeotrekCE/Geotrek-rando-widget/releases/tag/0.19.0 :sunflower:


chore: parameterise cycle_group by Builder rather than Composer

Remaining cleanup from the time when the entire stdlib was still parameterised by Composer since they were together.

Benchmark results
No base data found for comparison.

Detailed results
All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call  to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.
This benchmark source data is available in JSON format on S3 here.
Proof generation
Each column represents the number of threads used in proof generation.

Metric
1 threads
4 threads
16 threads
32 threads
64 threads

proof_construction_time_sha256
5,736
1,552
713
781
773

L2 block published to L1
Each column represents the number of txs on an L2 block published to L1.

Metric
8 txs
32 txs
64 txs

l1_rollup_calldata_size_in_bytes
772
772
772

l1_rollup_calldata_gas
6,856
6,856
6,856

l1_rollup_execution_gas
587,396
587,396
587,396

l2_block_processing_time_in_ms
1,355
5,075
10,118

l2_block_building_time_in_ms
33,113
131,156
262,551

l2_block_rollup_simulation_time_in_ms
32,931
130,509
261,290

l2_block_public_tx_process_time_in_ms
20,325
82,424
165,423

L2 chain processing
Each column represents the number of blocks on the L2 chain where each block has 16 txs.

Metric
5 blocks
10 blocks

node_history_sync_time_in_ms
15,173
28,248

node_database_size_in_bytes
21,434,448
38,301,776

pxe_database_size_in_bytes
29,868
59,425

Circuits stats
Stats on running time and I/O sizes collected for every kernel circuit run across all benchmarks.

Circuit
protocol_circuit_simulation_time_in_ms
protocol_circuit_witness_generation_time_in_ms
protocol_circuit_proving_time_in_ms
protocol_circuit_input_size_in_bytes
protocol_circuit_output_size_in_bytes
protocol_circuit_proof_size_in_bytes
protocol_circuit_num_public_inputs
protocol_circuit_size_in_gates

private-kernel-init
161
3,686
23,145
19,985
61,999
86,720
2,643
1,048,576

private-kernel-inner
611
5,136
40,524
89,053
61,999
86,720
2,643
2,097,152

private-kernel-reset-small
579
2,374
23,206
117,961
61,999
86,720
2,643
1,048,576

private-kernel-tail
534
3,829
37,988
86,849
79,454
10,688
267
2,097,152

base-parity
7.66
302
3,289
128
64.0
2,208
2.00
131,072

root-parity
51.1
272
38,149
27,064
64.0
2,720
18.0
2,097,152

base-rollup
803
2,996
43,712
111,158
957
3,136
31.0
2,097,152

root-rollup
94.8
117
8,341
11,518
821
3,456
41.0
524,288

public-kernel-app-logic
247
198
730
96,978
85,095
116,448
3,572
4,096

public-kernel-tail
878
733
1,101
388,207
7,755
10,176
251
512

public-kernel-setup
234
278
1,375
138,309
85,095
116,448
3,572
4,096

public-kernel-teardown
234
225
927
143,320
85,095
116,448
3,572
4,096

merge-rollup
6.66
88.6
1,628
2,760
957
3,136
31.0
65,536

private-kernel-tail-to-public
N/A
9,656
73,086
N/A
N/A
116,960
3,588
4,194,304

Stats on running time collected for app circuits

Function
app_circuit_proof_size_in_bytes
app_circuit_proving_time_in_ms
app_circuit_size_in_gates
app_circuit_num_public_inputs

SchnorrAccount:entrypoint
16,128
47,466
2,097,152
437

Test:emit_nullifier
16,128
1,749
65,536
437

FPC:fee_entrypoint_public
16,128
9,345
524,288
437

FPC:fee_entrypoint_private
16,128
8,891
524,288
437

Token:unshield
16,128
50,175
2,097,152
437

SchnorrAccount:spend_private_authwit
16,128
2,700
131,072
437

Token:transfer
16,128
34,976
2,097,152
437

Tree insertion stats
The duration to insert a fixed batch of leaves into each tree type.

Metric
1 leaves
16 leaves
64 leaves
128 leaves
512 leaves
1024 leaves
2048 leaves
4096 leaves
32 leaves

batch_insert_into_append_only_tree_16_depth_ms
11.3
18.3
N/A
N/A
N/A
N/A
N/A
N/A
N/A

batch_insert_into_append_only_tree_16_depth_hash_count
16.7
31.8
N/A
N/A
N/A
N/A
N/A
N/A
N/A

batch_insert_into_append_only_tree_16_depth_hash_ms
0.660
0.561
N/A
N/A
N/A
N/A
N/A
N/A
N/A

batch_insert_into_append_only_tree_32_depth_ms
N/A
N/A
52.2
82.1
261
503
996
1,971
N/A

batch_insert_into_append_only_tree_32_depth_hash_count
N/A
N/A
95.9
159
543
1,055
2,079
4,127
N/A

batch_insert_into_append_only_tree_32_depth_hash_ms
N/A
N/A
0.534
0.507
0.475
0.470
0.472
0.471
N/A

batch_insert_into_indexed_tree_20_depth_ms
N/A
N/A
62.6
120
378
739
1,468
2,926
N/A

batch_insert_into_indexed_tree_20_depth_hash_count
N/A
N/A
106
208
692
1,363
2,707
5,395
N/A

batch_insert_into_indexed_tree_20_depth_hash_ms
N/A
N/A
0.544
0.537
0.513
0.509
0.509
0.509
N/A

batch_insert_into_indexed_tree_40_depth_ms
N/A
N/A
N/A
N/A
N/A
N/A
N/A
N/A
67.7

batch_insert_into_indexed_tree_40_depth_hash_count
N/A
N/A
N/A
N/A
N/A
N/A
N/A
N/A
108

batch_insert_into_indexed_tree_40_depth_hash_ms
N/A
N/A
N/A
N/A
N/A
N/A
N/A
N/A
0.593

Miscellaneous
Transaction sizes based on how many contract classes are registered in the tx.

Metric
0 registered classes
1 registered classes

tx_size_in_bytes
84,741
673,219

Transaction size based on fee payment method
| Metric |  |
| - |  |
Transaction processing duration by data writes.

Metric
0 new note hashes
1 new note hashes
2 new note hashes

tx_pxe_processing_time_ms
29,882
4,278
100,494

Metric
0 public data writes
1 public data writes
2 public data writes
4 public data writes
8 public data writes

tx_sequencer_processing_time_ms
1,427
2,689
2,052
3,421
2,009


Add afk player support that doesn't require Essentials

Please could you add the option to ignore afk players without requiring EssentialsX? I've mostly had bad experience with Essentials & would prefer not to use that plugin.

The latest beta releases re-add Harbor's built-in AFK detection system. You can download them here: https://github.com/nkomarn/Harbor/releases/tag/1.6.2-b6. Keep in mind that you will have to regenerate your configuration when updating :")


Snake dies when directed in opposite direction of movement

Describe the bug
While trying to move the snake in the opposite direction of its movement, the snake immediately dies.
Expected behavior
Acc. to the traditional rules of the snake game, the snake should not honour the request to move backwards, or in opposite direction of movement.

Hi, I would like to work on the resolution of this issue. Please assign the same.

Hi @SubhamKarmakar24 , I would like to work on the resolution of this issue. Please assign the same.

Sure, feel free to contribute


Regenerate profile SAP_ALL

Regenerate profile SAP_ALL after pulling some authorization object using abapgit. Please review, my first PR here :)
Closes #4782

Can you pls check if the delete method removes the AO from SAP_ALL. If not, add the regenerate there, too.

@mbtools Do you know when this delete method is called? I couldn't find any 'delete' on UI. I just want to test it and make sure that everything is ok.

'Advanced > Uninstall' will call delete for each object of the repo

This method https://github.com/abapGit/abapGit/blob/85878b972a775918ddf674fef41143dc94d09ffa/src/objects/zcl_abapgit_object_suso.clas.abap#L182

BTW: don't we need to update the changelong?

BTW: don't we need to update the changelong?

Usually the changelog is updated for each release, not for every pull request.

welcome to abapGit as a contributor 🎉


Issue #729: The previously-deprecated -i switch to pg_dump is no longer supported in PostgreSQL 9.5.

on 1-3-stable as https://github.com/jruby/activerecord-jdbc-adapter/commit/9bc444ec903c0135fbd1362a31c0020619941467 (will be in 1.3.23) ... thanks!


Dataverse on Azure

Hi @poikilotherm and @pdurbin, I've just managed to deploy Dataverse on Kubernetes cluster provided by Microsoft Azure.
The good news that infrastructure works without any modifications with kubectl higher than 1.14 (with kustomize support)! The only difference is the specification for volume claims, it's different for S3, Google Cloud and (now) Azure.
How do you want to get it in the repository?

I betcha @rc-colabear will be excited! He opened https://github.com/IQSS/dataverse/issues/4247 . I'm excited too. Great work, @4tikhonov 🎉

@4tikhonov please be aware that I just released v4.16 Lots of stuff now inside, many bugfixes.
And yes, it would be really cool to include those. I thought about stealing the term "installation personas" from @pdurbin and provide such things in the repo. See also #91.
For #63 I started to create a folder k8s/experiments, maybe we can rename to k8s/personas and for this Azure thing we can just provide a cool kustomization.yaml file with the necessary patches?

Credit to @janetm for the idea of Dataverse installation personas. Just wait till you see her poster! 😄

@poikilotherm, I don't think I fully understand the idea. Anyway it does work on Azure with different volumes specification
https://github.com/Dans-labs/dataverse-kubernetes/commit/b50c523bb270d531d2f8b755628869849b94b8aa
I believe we need to put this in kustomization.yaml to be able to choose Cloud Provider between Amazon, Azure and Google Cloud.

 :)

Hi @poikilotherm, we're working on the manual describing how to deploy Dataverse in Microsoft Azure Cloud. Do you have some progress with kustomization.yaml to get a Cloud as parameter?

As #110 has been closed by integrating it within the docs (see 4e0cf5b and http://k8s-docs.gdcc.io/en/v4.20/day1/provider-hints.html), I'll close this issue.
Feel free to re-open if sth. is missing.


RevEng - Fix for issue 1934 - improve layout...

...of configuration code in OnModelCreating(). See #1934.

Tests? We seem to have gotten into a very bad habit.

@bricelam They're coming. Am working on them now.

@bricelam there will be tests that will compare the codegen output with a baseline. These changes are being made first just to avoid reworking the tests (at least this first time). Please keep that in mind when reviewing.

:shipit:

Merged with commit c66035f.


Alpine Version

Hello, do you plane to make alpine version?

Alpine did not work out due to musl libc and other hard coded code paths I did not find I work around for. I am really sorry.


[Request] rotateInBack and rotateOutBack

It would be nice to have rotateIn and rotateOut animation with opposite direction as well.
In my specific case I needed this for a floating action button menu open/close effect.
See https://genielabs.github.io/zkit/docs/components/menu_overlay.html

Hello, can you provide as codepen.io of your suggestion?

I realized that for modern browsers it can be used animate-direction: reverse; for the purpose.
https://codepen.io/genielabs/pen/xWNyaw
thanks.

Hello @genemars! Thank for your suggestion, we will review that and take a look if there is a possible conflict with other animations. If there's no conflict in your suggestion I will add it immediately to our library. :) Thanks!


Date.js

Data.js URL was not working. Simply put this new URL into this file:
https://storage.googleapis.com/google-code-archive-downloads/v2/code.google.com/datejs/date.js

Hi @xentnex, thanks for the pull request. Before we can merge it, we need you to sign our Contributor License Agreement. You can do so electronically here: http://opensource.box.com/cla
Once you have signed, just add a comment to this pull request saying, "CLA signed". Thanks!

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Provide automated deployment for portal

Provide automated deployment for portal to CoditFamilyView.

What configuration is required @Drjoachim?


JWTCookieAuthentication and SessionAuthentication not working together.

I am using both of these authentication classes in settings.py file as DEFAULT_AUTHENTICATION_CLASSES.
'DEFAULT_AUTHENTICATION_CLASSES': [
        'dj_rest_auth.jwt_auth.JWTCookieAuthentication',
        'rest_framework.authentication.SessionAuthentication',
    ],

With this setting if I use browsable API then I get this error:
HTTP 401 Unauthorized
Allow: POST, OPTIONS
Content-Type: application/json
Vary: Accept
WWW-Authenticate: Bearer realm="api"

{
    "detail": "Given token not valid for any token type",
    "code": "token_not_valid",
    "messages": [
        {
            "token_class": "AccessToken",
            "token_type": "access",
            "message": "Token has wrong type"
        }
    ]
}

Not sure if this is the best way, but to my understanding for some reason the Login API is requesting credentials. My solution was to override the default class and remove any authentication requirements.
from dj_rest_auth.views import LoginView

class Login(LoginView):
    authentication_classes = []

And in the urls file"
# ...

urlpatterns = [
    path("auth/login/", core_api.WorkoutLogin.as_view()),
    path("auth/", include("dj_rest_auth.urls")),
]

# ...

I found that I can get this to work only if I use DRF's Token Authentication as well:
    'DEFAULT_AUTHENTICATION_CLASSES': (
        'rest_framework.authentication.SessionAuthentication',
        'rest_framework.authentication.TokenAuthentication',
        'dj_rest_auth.jwt_auth.JWTCookieAuthentication'
    ),

I think Simple JWT must rely on this code to work.

It seems this app can work with JWT Token or DRF Token Auth only. If I tried to use DRF SessionAuthentication only I got server errors.
REST_USE_JWT = False

...
'DEFAULT_AUTHENTICATION_CLASSES': (
        'rest_framework.authentication.SessionAuthentication',
    ),
...

INSTALLED_APPS = [
    ...
    'rest_framework',
    #'rest_framework.authtoken'
]

error:

File "/usr/local/lib/python3.7/dist-packages/dj_rest_auth/views.py" in post
  127.         self.login()

File "/usr/local/lib/python3.7/dist-packages/dj_rest_auth/views.py" in login
  79.                 self.serializer,

File "/usr/local/lib/python3.7/dist-packages/dj_rest_auth/utils.py" in default_create_token
  16.     token, _ = token_model.objects.get_or_create(user=user)

Exception Type: AttributeError at /api/v1/profiles/rest-auth/login/
Exception Value: type object 'Token' has no attribute 'objects'

I am still facing this problem with version 5.1.0. Any workaround?

I am still facing this problem with version 5.1.0. Any workaround?

I am not sure why, but switching the order of these classes seem to work for now
'DEFAULT_AUTHENTICATION_CLASSES': [
        'rest_framework.authentication.SessionAuthentication',
        'dj_rest_auth.jwt_auth.JWTCookieAuthentication',
    ],


Orbit tracker interface; Closes #108

@aaroncameron21 You have conflicts.

@benjic @mkinsey The main issue I'm having with the merge is dealing with things being split into the partials. My orbit tracker html stuff needs to be moved to simulation.html, but it loses its access to the bodyController which is still in index.html. Any ideas on how to access the bodyController from simulation.html?


Some data files upload failed

Some .csv data file upload failed. What are the specific requirements for uploading files? such as column names, etc.

Thank @znw0714  for the feedback. We will add a description about the data format in README.
Please attach the data file which is failed to upload. We will see if we can support that format. (If the file is too large or is confidential, a sample of the file will work too.)

The github issue can not upload .csv file. This is the local screenshots about the file. Probably because missing timestamp? label is null?  @ldp12416

I find that some .csv files are reported uploaded failed by Curve. But after a period of time, it magically appears in the data list.

I just updated data format in README, please  see what formats are supported now. @znw0714


When New Filename Extension setting is md, Untitled.markdown is used in save sheet

When New Filename Extension in settings is md, I’m seeing Untitled.markdown as the default name in the save sheet. It does appear that the markdown and txt settings work as expected though. This is just an issue for me if md is selected.
I’ve taken screenshots of the setting and respective save sheet to demonstrate the results I’m seeing.
md

markdown

txt

Thanks for MarkEdit! If you require more information, please let me know.

Here’s the mdls output for a .md file that was saved using MarkEdit. Hopefully it provides some clues. I’m pretty sure I set the Open With to MarkEdit in the Finder’s info panel, and clicked Change All.

_kMDItemDisplayNameWithExtensions  = "To do.md"
kMDItemAlternateNames              = (
    "To do.md"
)
kMDItemContentCreationDate         = 2023-10-16 10:36:37 +0000
kMDItemContentCreationDate_Ranking = 2023-10-16 00:00:00 +0000
kMDItemContentModificationDate     = 2024-01-24 05:29:16 +0000
kMDItemContentType                 = "net.daringfireball.markdown"
kMDItemContentTypeTree             = (
    "net.daringfireball.markdown",
    "public.plain-text",
    "public.text",
    "public.data",
    "public.item",
    "public.content"
)
kMDItemDateAdded                   = 2023-11-11 02:28:21 +0000
kMDItemDisplayName                 = "To do.md"
kMDItemDocumentIdentifier          = 5
kMDItemFSContentChangeDate         = 2024-01-24 05:29:16 +0000
kMDItemFSCreationDate              = 2023-10-16 10:36:37 +0000
kMDItemFSCreatorCode               = ""
kMDItemFSFinderFlags               = 16
kMDItemFSHasCustomIcon             = (null)
kMDItemFSInvisible                 = 0
kMDItemFSIsExtensionHidden         = 1
kMDItemFSIsStationery              = (null)
kMDItemFSLabel                     = 0
kMDItemFSName                      = "To do.md"
kMDItemFSNodeCount                 = (null)
kMDItemFSOwnerGroupID              = 20
kMDItemFSOwnerUserID               = 501
kMDItemFSSize                      = 1683
kMDItemFSTypeCode                  = ""
kMDItemInterestingDate_Ranking     = 2024-01-24 00:00:00 +0000
kMDItemKind                        = "Markdown"
kMDItemLastUsedDate                = 2024-01-24 05:29:10 +0000
kMDItemLastUsedDate_Ranking        = 2024-01-24 00:00:00 +0000
kMDItemLogicalSize                 = 1683
kMDItemPhysicalSize                = 4096
kMDItemUseCount                    = 278
kMDItemUsedDates                   = (
    "2023-11-08 08:00:00 +0000",
    "2023-11-15 13:00:00 +0000",
    "2023-11-16 13:00:00 +0000",
    "2023-11-28 13:00:00 +0000",
    "2023-11-30 13:00:00 +0000",
    "2023-12-03 13:00:00 +0000",
    "2023-12-09 13:00:00 +0000",
    "2023-12-10 13:00:00 +0000",
    "2023-12-13 13:00:00 +0000",
    "2024-01-04 13:00:00 +0000",
    "2024-01-12 13:00:00 +0000",
    "2024-01-14 13:00:00 +0000",
    "2024-01-21 13:00:00 +0000",
    "2024-01-22 13:00:00 +0000",
    "2024-01-23 13:00:00 +0000"
)
kMDItemUserModifiedDate            = (
    "2024-01-24 05:00:00 +0000",
    "2024-01-24 05:29:16 +0000"
)
kMDItemUserModifiedUserHandle      = (
    501,
    501
)

Could you please try this build? MarkEdit.zip thanks.

That seems to have fixed it! I just tested all three default filename extension settings, and all three produce the desired result.


Properties list in UI not updating effective value correctly in multi-node

If you change a prop to have a DB value (when it has no YAML values) the effective value is showing as [Multiple...] when all nodes have the same.

Fixed in b.184


Error in Ubuntu line 152

One one of my two KVM with Ubuntu 18.04 the installation  stopped with an error:wireguard-install.sh: line 152: /etc/iptables/rules.v4: No such file or directory
Failed to enable unit: Unit file<EMAIL_ADDRESS>does not exist.
Failed to start<EMAIL_ADDRESS>Unit<EMAIL_ADDRESS>not found.

Please, confirm that you are running the original script https://github.com/l-n-s/wireguard-install/blob/master/wireguard-install.sh
NOT the script from the comments in your previous issue, it will not work.

Please, confirm that you are running the original script https://github.com/l-n-s/wireguard-install/blob/master/wireguard-install.sh
NOT the script from the comments in your previous issue, it will not work.

hey, the original script dosen't work on, vultr / digital ocean / google cloud
the modified script works on those...
plus IPV6 from this script dosent work..