Wrong "tsdb format" url in Prometheus storage documentation

Can not open “tsdb format” url in https://prometheus.io/docs/prometheus/latest/storage/
I think the right is https://github.com/prometheus/tsdb/blob/master/docs/format/README.md

Hi,
it's already fixed on git:
https://github.com/prometheus/prometheus/pull/4402


Version 1.4.3

@philwills give it a whirl.

Looks good, thanks. Having this plugin in a maintained state has made developing https://github.com/guardian/scanamo much more pleasurable than it otherwise might have been.

Awesome! Glad to hear it!


feat: add at_rpc_demo; some other repo curation

- What I did

added at_rpc_demo
updated the repo's main README

- How to verify it

Run the arithmetic example server and client programs as per the at_rpc_demo's README
Proof-read the other README changes

Back to you @gkc as my latest commits mean I can't approve.


Republish topical event page on publish of about page

Previously content editors were updating about pages and were confused as to why the corresponding topical event page wasn't also being updated.
Normally this would be done by dependency resolution, but since the topical event can be created without an about page, we'd need to define this logic on create of an about page too. Alternatively we could add a reverse link in the about page, but this is the simpler option for now.
Trello
⚠ This repo is Continuously Deployed: make sure you follow the guidance ⚠
Follow these steps if you are doing a Rails upgrade.

@JonathanHallam

Could you just fix everything up into one commit please :)

Done! ✅


Error bundling when meta url doesn't have http or https specified

Notice the map URL's which should be ok (//ajax.googleapis.com/...):
When I do this I get an error when trying to build:
[Error: Unable to calculate canonical name to bundle file://ajax.googleapis.com/ajax/libs/jquery/1.12.0/jquery.min.js. Ensure that this module sits within the baseURL or a wildcard path config.]
		System.config({
			baseURL: staticContentRoot,
			paths: {
				...
			},
			map: {
				"jquery": '//ajax.googleapis.com/ajax/libs/jquery/1.12.0/jquery.min.js',
				"angular": '//ajax.googleapis.com/ajax/libs/angularjs/1.3.14/angular.min.js',
				"jqueryui": '//ajax.googleapis.com/ajax/libs/jqueryui/1.11.2/jquery-ui.min.js',
				...
			},
			meta: {
				"*.html": {
					loader: 'systemjs-text'
				},
				"*.json": {
					loader: 'systemjs-json'
				},
				"angular": {
					exports: 'angular',
					format: 'global',
					globals: {
						"jQuery": "jquery"
					},
					build: false
				},
				"jquery": {
            		format: 'cjs',
					build: false
				},
				"jqueryui": {
            		build: false
				}
			}
		});

@vidalsasoon I'd suggest including the protocol in the map. When running the builder, the base path is file:///path/to/project so that //asdf resolves to file:///asdf in the build environment.

The reason everyone else supports this format is so a web site can be protocol agnostic so it's possible to avoid the issues of mixing http and https.

Yes, and you are welcome to include that configuration in your browser configuration. But at build time it has different meaning.


feature request: cpu: show frequency

For laptop users it would be great to have access to {frequency} in the format string.

:+1:

:+1:


Create a contact info block

Add links to social networks (LinkedIn, Facebook, Instagram), phone number, email, Telegram username, etc.

Added links to LinkedIn, email, and Telegram username.


how can the code be runnable for dataframe of column size 18260?

2023-04-12 17:47:26,636 | WARNING : Not all samples have same length: maximum length set to 18260
2023-04-12 17:47:28,605 | INFO : 1212 samples may be used for training
2023-04-12 17:47:28,605 | INFO : 304 samples will be used for validation
2023-04-12 17:47:28,605 | INFO : 0 samples will be used for testing
2023-04-12 17:53:36,348 | INFO : Total number of parameters: 3656002
2023-04-12 17:53:36,348 | INFO : Trainable parameters: 3656002

Hi, it's not clear to me what you are trying to achieve. Does your time series really have 18260 features/variables per time step?

Currently i have dataset with single variant time series with dataframe size of 9000 columns..so when i run the same code using this datset im getting error..how should i make changes to make it work

Ok, so what do the columns represent? From what I understand, you have a dataset where a single training example is a time series of a single variable and length 18260?

Its Single varient time series of length 9000


win: prevent machine hang due to tty event explosion

Problem
In #1408 the detection of console window resizing on Windows was changed to use the Windows Accessibility API (SetWinEventHook), apparently because the previous implementation couldn't reliably detect console window resizing under some conditions.
Unfortunately, the current implementation can easily lead to a total machine hang due to an explosion of console events being queued by the system. This can happen when multiple libuv-powered Windows console applications that write output to their console quickly are run in parallel, even if the applications don't care about SIGWINCH signals at all.
The problem is in the way SetWinEventHook is being used. The libuv code is passing 0 for the idProcess parameter, which means "listen for events sent by any process in the system". It was doing this presumably because on Windows the console window is actually owned by a different process (conhost.exe) so libuv would never receive console resizing events if it listened only on its own process ID. Unfortunately, the event hook receives notifications when many other things happen to a console, for example when it scrolls due to a new line being written, so having many chatty console applications all listening for events from all other applications quickly leads to O(N^2) events being queued which easily brings down the whole system. It seems that Microsoft warns about this here:

The USER component of the operating system allocates memory for events that are handled by out-of-context hook functions. The memory is freed when the hook functions return. If a hook function does not process events quickly enough, USER resources are lowered, eventually resulting in a fault or extremely slow response times. These problems may occur if:

Events are fired very rapidly.
The system is slow.
The hook function processes events slowly.

To demonstrate the problem, here's a simple application that writes 25 lines/sec to the console which can easily trigger the issue:
#include <uv.h>
#include <stdio.h>

void timer_cb(uv_timer_t* handle)
{
    static int i = 0;
    printf("Timer: %d\n", ++i);
}

int main()
{
    uv_timer_t timer;
    uv_timer_init(uv_default_loop(), &timer);
    uv_timer_start(&timer, timer_cb, 0, 40);
    uv_run(uv_default_loop(), UV_RUN_DEFAULT);
}

You can save that to a file called uvhang.c and build the application as follows from an x64 Native Tools Command Prompt for VS2017:
cl /c /EHsc /Ilibuv/include uvhang.c
link uvhang.obj libuv/Release/lib/libuv.lib ws2_32.lib iphlpapi.lib advapi32.lib user32.lib userenv.lib psapi.lib

Now that you have uvhang.exe in the current directory, create a batch file called uvhang.bat with these contents:
@echo off
FOR /L %%A IN (1,1,50) DO (
	start /min uvhang.exe
)

NOTE: Running this batch file will probably hang your system. Proceed with care.
This batch file will start 50 instances of the program in parallel. On an 8-core Ryzen 2700X machine this leads to an unresponsive system within 5 seconds. We've seen 36-core production servers brought to their knees with a slightly larger number of instances (our production environment fits this profile of many console applications running in parallel).
From looking at the ETW profiling data, one can see that the win32kfull.sys driver spends an inordinate amount of time queueing these console events. Here's an example profile:

You can see from this 23-second profile that win32kfull.sys queued 170,000 event messages and spent 17 seconds doing so. If you want to capture a profile like this yourself you can use a batch file like this:
@echo off
xperf -on Latency -f %temp%\kernel.etl -stackwalk Profile -start MyTrace -on Microsoft-Windows-Win32k -f %temp%\user.etl -BufferSize 1024 -MaxBuffers 1024 -MaxFile 1024
FOR /L %%A IN (1,1,50) DO (
	start /min uvhang.exe
)
ping -n 5 localhost
taskkill /f /im:uvhang.exe
xperf -stop MyTrace -stop
xperf -merge %temp%\kernel.etl %temp%\user.etl %temp%\merged.etl
wpa %temp%\merged.etl

The problem also occurs with Node applications. Save this code to uvhang.js:
var i = 0;

function timerFunc() {
  console.log(`Timer: ${++i}`);
}

setInterval(timerFunc, 40);

Now you can cause the system hang with this batch file:
@echo off
FOR /L %%A IN (1,1,50) DO (
	start /min node uvhang.js
)

Solution
The idea behind this PR is simply to listen for console events only from our corresponding conhost.exe process, which we find using NtQueryInformationProcess with ProcessConsoleHostProcess. With this change, we still receive console resizing events for our console and the number of events queued by win32kfull.sys grows only linearly with the number of processes:

This works for 32-bit applications running on 32-bit Windows and 64-bit applications running on 64-bit Windows. Unfortunately it doesn't work for 32-bit applications running on 64-bit Windows because the WOW64 translation layer disallows the use of ProcessConsoleHostProcess for some reason. This PR currently falls back to the existing behavior of listening for events from all processes in that case, but since that means it can still cause system hangs I was wondering which of these alternatives would be preferred:

Leave the PR as-is and add a warning somewhere about this problem for 32-bit apps on 64-bit Windows.
Revert the console window resizing detection change from #1408 to its old behavior.
Use this method which involves changing the window title to some unique string to find our conhost.exe process.

Wow, that's a thorough bug report, thanks! The PR as-is LGTM. regarding what to do for 32bit apps on 64bit Windows... I'd say we wait for reports to come, and possible apply 3) by setting some UUID as the title only in that case.

CI: https://ci.nodejs.org/view/libuv/job/libuv-test-commit/1407/
Node: https://ci.nodejs.org/view/libuv/job/libuv-in-node/97/
The bug report is 11/10, great job! Originally I did not found a way to get the conhost procid, so I left 0 there.

Landed in https://github.com/libuv/libuv/commit/dabc737d7892971289537e52af4366c63cbc70b3

Just so you all know: this will not work for application sessions using libuv under a "pseudoconsole." They have HWNDs to support legacy scenarios (like vim: it will crash if it doesn't find one. this is known to be silly.) but those HWNDs will never signal any accessibility events or be displayed anywhere on the screen. There's a bit more info at microsoft/terminal#1811.
We'd like to offer a better window size event than the one that comes in on the input handle, but we haven't yet designed it. :smile:
I am moderately horrified at the MSDN documentation saying "The Win32 API provides no direct method for obtaining the window handle associated with a console application." as that is patently false. I'll get a documentation bug going to get that fixed, because that method is absolutely atrocious.
Incidentally, would GetConsoleWindow help you? :grin:

For some background: this was added, because the previous version (reading WINDOW_BUFFER_SIZE_EVENT from the console) had a number of issues - see "Notes" in the old documentation.
@DHowett-MSFT we need the PID of the conhost.exe process for the event filter. Calling GetWindowThreadProcessId on the result of GetConsoleWindow does not give that PID, so unless there is some other method this will not be useful.
I'll make another PR that removes this hook for 32/64 bit mixture as Visual Studio bundles 32bit Node instance and is most likely run on a 64bit machine. I'll reintroduce the old method as a fallback, hopefully, this will also solve https://github.com/microsoft/terminal/issues/1811.
If after that the performance issues prevail, we can always switch to pooling the console size every once in a while. Or if you have any other idea how this can be implemented, please let me know.


Publish new version to npmjs?

I've found jeep really useful for a project I'm working on--thanks for the package!
For this project, I haven't needed to handle CallExpressions, but I did as of today.  However, I'm using the package from Typescript, and the typings that are included in the 0.3.2 release don't include typings for ICallExpression.  It is on master, so I can simply install that, but I'm wondering if a release is (or can be) planned anytime soon?
Thanks.

How can we move this forward? For various reasons, I cannot refer to master's head and must go through NPM. It would be great if I can use the proper typings instead of needing to copy the declarations on my side.

I will make some hours for this, this weekend. Expect a update on NPM in a few days.

https://www.npmjs.com/package/jsep
0.3.3 is released.

Thanks!


Chapter ideas and sources

@carriewright11
For now, I'm just gathering some thoughts and posting some links, I will continue to edit this and make some sort of outline and specific ideas.
03-Data_Privacy.Rmd

Methods of privacy-preserving genomic sequencing
data alignments
New threats to health data privacy
Bioinformatics and storing data
Genome privacy: challenges, technical approaches to mitigate risk, and ethical considerations in the United States

04-Data_Sharing.Rmd

Ten Simple tips for data sharing
The Elements of Data Sharing
Practical Tips for Ethical Data sharing

05-Data_Ethics.Rmd

Toward Striking a Balance in Bioinformatics
Data Ethics in Digital Health and Genomics

I have many links as well that I had been reading through can add them soon


Fix the link for fapws project.

My oh my. Thank goodness I clicked this link while I was at home. It would be disastrous if I were in the office or public space.
⚠ NSFW Warning: Please DO NOT go to http://www[dot]fapws[dot]org/ if you're in a public space.

What the ... thanks.


Add missing views

The endpoints that should be done and are not yet covered by any issue

[ ] everything about viewing account (name, points, statistics, ...)
[ ] edit account
[ ] get a product (with all its varieties)
[x] create project from template
[ ] get a project (needs testing)
[ ] filters and orderings for listing projects (ex: review_status=pending for admins)
[ ] list my projects (meaning projects created by the current user in any stage, or non-draft ones the user moderates)

Getting a product is pretty much not needed, since the list operation gives all the info it can.
Creating a project from a template is a front-end feature, the templates aren't actually stored in the DB.

But in listing we don't need all information. For example, we don't show description, sizes, purchase count, or any images but the first. Also, we want the users to be able to navigate to something like /product/8 (especially to share this link with others or bookmark a specific product) without having to load all of the products

Well...
The reason I thought we'd get away with no detail is because I didn't want to bother separating stuff like images. But okay, fine, let's do this.

By the way, when would we want to request the projects that we created?

not sure. maybe part of the timeline? I can see it being used in the frontend in the future (part of profile or whatever), but not in the current version. it's not a priority

I find this issue too broad, closing it in favor of #31, #47, #48, #49, #53.


Add primative map to haxschema spec

That way we can easily build fallback copies of content for nojs, rss feeds, search engines and lunrjs. This content can also have it's file paths fixed for usage in the legacy outline / iframes mode of display

RSS would benefit from this version in addition to the legacy outline


pkg/helm/release/manager.go: refactor to use ThreeWayMergePatch

Description of the change:
As a follow-up to #2777, this PR swaps out our manual patch generation with the Kubernetes strategic three way merge patch.
Motivation for the change:
When a dependent resource of a helm-based operator release is changed, we currently attempt to manually build a patch that is meant to ensure the release manifest is applied. However our implementation has proven buggy recently.
The correct thing to do is to perform a Kubernetes strategic merge patch. This solution:

will honor the patch strategy defined in the OpenAPI schema of objects.
will simplify the helm-operator reconcile logic and patch building.

@Lucaber Here's the update to make the Helm operator use strategic three way merge patch. I had to modify the tests since the patch format is different. I manually tested this change just to double check since my understanding of strategic merge patch format is lacking. Everything looked okay in my testing, but I also wanted to check with you since you encountered this problem originally.

Obsoleted by #2869


A quick experiment to get allow React components in Markdown pages

This is an experiment to get React components working in markdown pages. Super rough and a proof of concept.
With the goal being to make our codebase more extensible by giving us access to the entire React ecosystem.
Todos

[x] Get static React Components working
[x] Get server side rendering working
[x] Get Dynamic React Components working
[x] Get client side hydration working
[x] confirm the passing of props works

Todos if we move forward with this experiment

[ ] get tests working again and catching malformed React comments
[ ] Get a test that checks translated files and confirms the react is still exactly the same. So we know if translators accidentally translate React components
[ ] Use the production script for react in production
[ ] Look for performance optimizations
[ ] Consider caching server side rendering of react components in Redis or as part of the build process, etc. for performance on production. Rendering the components is not free. eg. the Code tab below was 30ms to render.

Examples

Source file with react intertwined in the Markdown
Web page with the React components rendered

Example Markdown
---
title: Example
interactive: true
---

## Hello world

Markdown stuff with a [link](/path)

Other markdown stuff

{% liquid stuff still works %}

## Code Editor Component

Performance cost to render: ~5 milliseconds

<CodeEditor language='javascript' code={`console.log('hello world')`} />

## Code Block Example

Performance cost to render: ~30 milliseconds

<CodeBlock

js={`var i;
for (i = 0; i < cars.length; i++) {
  text += cars[i] + "
";
}`}

php={`for ($x = 0; $x <= 10; $x++) {
  echo "The number is: $x
";
}`}

python={`for x in "banana":
  print(x)
`}
/>

More markdown stuff

Defining new components
Start by adding frontmatter interactive:true to any markdown file that you want to support react (this prevents react render time from slowing down any other page and keeping the impact on performance very low)

Create the component in the ./react directory
Register the component for webpack in ./javascripts/index.js so the component works with client side rendering
Register the component in ./lib/react-engine.js so the component works with server side rendering
If the component needs to be evaluated client side, see the existing components for examples for how to ensure the client side component rendered by the server gets Hyrdated.

Gotchas

when requiring react components from npm you will often need to explicitly call require('component').default to make sure you get the component
Some code examples you get from external React packages won't work out of the box, you often need to dig into the module and determine whether it's exporting to default or not which will in many cases cause you to need to require('package').default
Imports are sketchy at the moment... so just use require...
If components require you to load CSS, you need to load that CSS in the javascripts/index.js file

Cool side effects

This also makes it possible to render server side React components anywhere on the site along with client side rendering for React components. Apart from Markdown. Eg. if we want to build search or just Navigation in React we can now.

Check off the following:

[ ] All of the tests are passing.
[ ] I have reviewed my changes in staging.

@JasonEtco would you be down to 🍐  on this at some point? server side rendering is working but I need some help with the webpack and logic to get the react components hydrated client side.

Thinking we need to do something like this (pseudocode) at the bottom of every component in ./react/*
This should make sure that when in the browser every component gets hydrated
if(window.type){
   const componentContainers = document.querySelector('.unique-class-name-of-component');

   for  (const index of componentContainers){

        componentContainer = componentContainers[index];
        ReactDOM.hydrate(React.createElement(ComponentName), componentContainer);

}

And then part two would be figuring out how to get the react files that work on the server working in the browser. Assuming webpack would be needed for that .

Did the first part of what I think I will work here: https://github.com/github/docs/pull/610/commits/4d9a6c70a83f5c71de2fae3c2e8ff8d275e21003
Next need to figure out webpack

Got it working!

Sorry for the late reply.  How do I review this? 😅
On Sat, Oct 17, 2020, 11:05 PM Chiedo John<EMAIL_ADDRESS>wrote:

Got it working!
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/github/docs/pull/610#issuecomment-711117343, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AQ2JP63PSDQ7V3AVZBE4G23SLJZSVANCNFSM4STZIM4Q
.

Another idea I had was, if we wanted an even cleaner syntax, we could replace this syntax:
<!—react—>

<!—end-react—>
With this syntax:
<Component />

Just an idea... we can have syntax that’s less obnoxious if we want to

Still relevant

Would it also change the extension to MDX for those files? I'm guessing it's following this style https://mdxjs.com/

@nschonni I didn't consider that but that would make a lot of sense if we were using MDX. I initially planned to use MDX but then abandoned it and built the functionality from the ground up. So no mdx extension since we're not using MDX and that would require we make lots of updates to our parsing. Rather we just use frontmatter interactive: true

@heiskr how would you feel about trying to get tests working on this this week so we can merge the work. Super low risk / high value in my opinion if we get the tests passing.

I think this pull request works as a proof of concept, but to get it production ready we might need a fresh branch so we're only including the MVP for the first deployment.

Works for me!

I removed the specific components (CodeBlock and CodeEditor) so this PR is more likely to get shipped, we can always pull them out of the version history of the branch when we want to add them later.

Before removing those components, did you confirm that the test suite would still pass when a React component was embedded in a markdown file?
If so, is this ready to 🚢 ? 🙏🏿

Before removing those components, did you confirm that the test suite would still pass when a React component was embedded in a markdown file?

The components would need their own tests, and we don't have a pattern for testing React components yet, but I don't think that all has to happen in one pull request. Given that its passing and we can add React components later, I think that's sufficient for the first pull request.

Also, I added usage documentation here, can you give that a 👀 ✔

I've looked at it, and I fixed a few typos but nothing major. Looks good to me.

/


Cannot create a new project: "Cannot read property 'code' of null"

Creating a new project fails with the filesystem left intact (no test-app directory is created):
> npx create-cljs-app test-app
npx: installed 24 in 2.223s
Cannot read property 'code' of null

Running on

macOS 10.14.6
Node 12.12.0

Well that's unexpected and bad. Hm.
Tell me please, do you have yarn on your system? And what about git of java, do you have those?

I don't have yarn, git 2.20.1 (the one that comes with macOS), my java is openjdk 13 2019-09-17.

Ok, I think I have some bad detection for yarn that is breaking things. If you'd like to install yar, I believe you'll be able to proceed right now. But I hope to have it fixed in a bit.

Yeah it should just fallback to npm when yarn isn't there. But the logic for detecting binaries wasn't working the way I thought.


A git tag for published release 0.1.0 is missing

Thanks for reporting! The tag is now pushed :smile:

Thanks!


Add response_handler_hook to the requests hook

As a software engineer I'd like to have an ability to add custom tags to the span depending of the response.
This PR adds optional response_handler_hook argument to opentracing_instrumentation.client_hooks.requests.install_patches
method. response_handler_hook should be a method that accepts response and span as positional arguments which will be provided by send_wrapper just after the response is received.
These changes also:

Bump version to 2.5.0.dev0
Add test for the requests
Update the requirements
Add support for Python 3.7
Drop support of Python 3.3
Fix some deprecation warnings
Fix flake8 warnings
Add .tox.ini
Update setup.cfg
Unify tracer fixture and move it to conftest.py
Simplify the singleton decorator
Fix strict_redis.reset_patches method

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Coverage increased (+3.1%) to 76.657% when pulling 294019eba024ed2fe5f620b5f545ff848f902345 on Jamim:feature/response-handler-hook into fbbe4b66f80de3f2b20d51d3dcac06223a0cc4e5 on uber-common:master.

Hi @yurishkuro,
Could you please review this PR?
Thank you!

@Jamim thanks for the PR.
There are way too many completely unrelated changes here, with unclear consequences & reasoning. Would you be open to grouping related changes into smaller PRs?

@yurishkuro
Sure, I'll try to provide you a series of smaller PRs as soon as I can.
Thank you!

#69 is the first PR of the announced series.

By the way, I added support for Boto 3 and Celery.
I'll create corresponding PRs in the near future.

Hello @yurishkuro,
Please give me some feedback for the current version of this PR.
I would like to know whether the proposed approach is fine for you.
Thank you!

@Jamim sorry, very busy this week, preparing for KubeCon. Please stand by.

ping @yurishkuro

Hello @yurishkuro,
I changed base Patcher and RequestsPatcher a bit.
Please review the diff.
Thank you!

🎉

Thank you for the hard work, @yurishkuro!


feat: Support Svelte 5 snippet blocks

Closes https://github.com/g-plane/markup_fmt/issues/67

Ref https://github.com/denoland/deno/issues/26324


[type: feature] init shenyu ingress controller

About #4581

ingress controller support configure http dynamicly
Support perceive the elastic scaling of services and change the upstream for it.
shenyu gateway support sni (multiple domain ssl)
ingress controller support cinfugure ssl dynamicly
mark some TODO

Make sure that:

[ ] You have read the contribution guidelines.
[ ] You submit test cases (unit or integration tests) that back your changes.
[ ] Your local test passed ./mvnw clean install -Dmaven.javadoc.skip=true.

Codecov Report

Merging #4620 (a023c9b) into master (9f602df) will decrease coverage by 2.16%.
The diff coverage is 3.96%.

@@             Coverage Diff              @@
##             master    #4620      +/-   ##
============================================
- Coverage     68.85%   66.69%   -2.16%
- Complexity     7746     7828      +82
============================================
  Files          1033     1086      +53
  Lines         29609    31048    +1439
  Branches       2682     2818     +136
============================================
+ Hits          20386    20707     +321
- Misses         7617     8712    +1095
- Partials       1606     1629      +23

Impacted Files
Coverage Δ

...e/shenyu/common/config/NettyChannelProperties.java
0.00% <ø> (ø)

...ache/shenyu/common/config/NettyHttpProperties.java
0.00% <0.00%> (ø)

...henyu/common/config/ssl/ShenyuSniAsyncMapping.java
0.00% <0.00%> (ø)

...che/shenyu/common/config/ssl/SslCrtAndKeyFile.java
0.00% <0.00%> (ø)

...e/shenyu/common/config/ssl/SslCrtAndKeyStream.java
0.00% <0.00%> (ø)

...b/configuration/ShenyuThreadPoolConfiguration.java
100.00% <ø> (ø)

...arter/netty/ShenyuNettyWebServerConfiguration.java
15.71% <11.42%> (-7.97%)
:arrow_down:

...org/apache/shenyu/plugin/base/trie/ShenyuTrie.java
75.60% <50.00%> (-0.31%)
:arrow_down:

... and 128 files with indirect coverage changes
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Integrate vcredist msm into the toolchain installer

We should integrate the vcruntime msm into the installer so that we can avoid any possible ABI issues.  This will also be required to support WinGet delivery of the toolchain with ARM64 hosts.

Fixing via https://github.com/compnerd/swift-build/pull/680


🐛: Handover garden crashes after clearing with expanded grouping

Description
After grouping in handover and expaning a group #504

then pressing clear button it crashes the application

Reproduce

Expected behavior
Expected to go back to default

Duplicate


BytesIO support?

As with the StringIO sample, I am trying to send an image generated internally by BytesIO, but the image file of 0 bytes is sent.
Does this module support BytesIO?

In fact yes it does support it, I have also done the same thing as you described (sending an image directly generated).
You can find my implementation over here.

It does support.
Here is an example of how to use it:
import aiohttp # We will read the image from an url.

url = "https://avatars.githubusercontent.com/u/98242689?s=200&v=4"
async with aiohttp.ClientSession() as session:
    async with session.get(url) as resp:
        if resp.status == 200:
            _io = (io.BytesIO(await resp.read())).read()
            file = interactions.File(file="unknown.png", fp=_io)
            await ctx.send(files=file)

I forgot to .seek(0) after using BytesIO
You can do it by using read.
We confirmed that it worked perfectly.
Thank you!


Hide tooltip on hover over x axis on Chart2 js

Feature Proposal
Can we hide tooltip on hover over x axis on Chart2 js ?
Possible Implementation
No response

Chart.js V2 is not supported anymore so any new issues about it are being disregarded. For any help witch chart.js V2 you can post your questions at stackoverflow: https://stackoverflow.com/questions/tagged/chart.js


Display workflow name in UI

Is your feature request related to a problem? Please describe.
In a multi-workflow repo, the 'name' or workflow name is required in a .dockstore.yml. Users may find it difficult to migrate existing multi-workflow repos since the UI is not explicit about what the workflow name actually is. This ambiguity can be even more confusing if it turns out that the workflow name is actually null.  Ex: Is it the full path that starts with 'github.com...'? Is it the file path? Is it the file name? Is it the TRS ID? Does the name include version name? Etc.
Describe the solution you'd like
To help users migrate workflows to github apps, it would be helpful if we displayed the name somewhere in the myWorkflows UI when the workflow is selected. This should be a key, value identifier. Similar to how we display the TRS ID as key: TRS with value: 'actual id'.
The name that's displayed should be the same name that the .dockstore.yml requires. https://docs.dockstore.org/en/1.9.0-bucket/getting-started/github-apps.html#workflow-yml-file
Things to think about:

Where should this be displayed? Info tab, above the tabbed widget, etc

should this be displayed only to owners/developer or also on the public page? (leaning towards former)

what to display when the value is null, without it being awkward

Is this necessary to display for all registration methods, or only for legacy? (to help people migrate)

Describe alternatives you've considered
When we generate a .dockstore.yml that will map the names automatically this should be taken care of.
┆Issue is synchronized with this Jira Story
┆Issue Type: Story
┆Sprint: Backlog
┆Issue Number: DOCK-1379

When we generate a .dockstore.yml that will map the names automatically this should be taken care of.

:+1:


Update blocks.ts

https://github.com/mempool/mempool.js/pull/47#issue-1118093137

https://github.com/mempool/mempool.js/pull/47#issue-1118093137

Agree
On Tue, Apr 19, 2022, 4:07 AM Camille Ashley @.***>
wrote:

@.**** approved this pull request.
—
Reply to this email directly, view it on GitHub
https://github.com/mempool/mempool.js/pull/47#pullrequestreview-945340099,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AXDNB5TRCBWVZLKQKEVNZWDVFZZV3ANCNFSM5NCRQURQ
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

de79c6b3aa8f88982bdab0bbe384a73a4758574603422a9aaaf29ddd6d6ca008

https://open.delta.app/asset/1000/BTC

1P387AySU1HNazBPBGjo1whwYFTYf6fXs4


Fix multiline comments

Description
Please explain the changes you made here. Reference related issues if applicable.
Type of Change

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Documentation update

Checklist

[ ] Lint and unit tests pass locally with my changes
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] I have added necessary documentation (if appropriate)

Related Issues
Fixes # (issue number)
How Has This Been Tested?
Describe how the changes were tested.
Additional Context
Add any other relevant information or screenshots about the PR.

:warning: Please install the  to ensure uploads and comments are reliably processed by Codecov.
Codecov Report
Attention: Patch coverage is 57.14286% with 9 lines in your changes missing coverage. Please review.

Project coverage is 68.74%. Comparing base (46b51e3) to head (4fa262e).

Files with missing lines
Patch %
Lines

internal/adapters/clients/github.go
55.00%
8 Missing and 1 partial :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #35      +/-   ##
==========================================
- Coverage   69.54%   68.74%   -0.80%
==========================================
  Files          17       17
  Lines         696      707      +11
==========================================
+ Hits          484      486       +2
- Misses        198      206       +8
- Partials       14       15       +1

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


CSS fix for truncated page titles on mobile

Closes #265
Just a simple edit following what I suggested in #265

Thank you!


Find mistake in code

I found mistake in the code.
File: yolo_model.py
for image with width not equal to height, this lines causes to error (lines 59-63):
        col = np.tile(np.arange(0, grid_w), grid_w).reshape(-1, grid_w)
        row = np.tile(np.arange(0, grid_h).reshape(-1, 1), grid_h)

        col = col.reshape(grid_h, grid_w, 1, 1).repeat(3, axis=-2)
        row = row.reshape(grid_h, grid_w, 1, 1).repeat(3, axis=-2)

instead, copy and paste these lines :
col = np.tile(np.arange(0, grid_w), grid_h).reshape(-1, grid_w)
row = np.tile(np.arange(0, grid_h).reshape(-1, 1), grid_w)
col = col.reshape(grid_h, grid_w, 1, 1).repeat(3, axis=-2)
row = row.reshape(grid_h, grid_w, 1, 1).repeat(3, axis=-2)

it's not good.
TabError: inconsistent use of tabs and spaces in indentation
i'm try to change tabs or spaces in indentation,but really tell me have mistakes


Rebase GPU preview branch

Description
Rebase the public-preview/gpu branch (originally based off v2.25.1).

#1030 introduced the two receivers;
#1080 updated the built-in receiver to use agent domain metric descriptors;
Skip newer distros and only test the GPU receivers on Ubuntu 2004; the tests covers different GPU models instead of different distros
(GPU Model P100 is included in this PR, but will remove P100 when merging during b/291585915);
Update the two receivers to have correct instrumentation scope label;
Introduce a minor refactor to the original 3P test changes; since the original change, we have introduced zone-picker logic to the integration tests, so adjust the 3P test for GPU apps to work correctly;
Add GPU detection via /sys before config merging;
Merge nvml otel receiver into the agent's hostmetrics receiver.

Related issue
b/273509985
How has this been tested?
Both receivers are covered by 3P tests.
Checklist:

Unit tests

[ ] Unit tests do not apply.
[x] Unit tests have been added/modified and passed for this PR.

Integration tests

[ ] Integration tests do not apply.
[x] Integration tests have been added/modified and passed for this PR.

Documentation

[ ] This PR introduces no user visible changes.
[x] This PR introduces user visible changes and the corresponding documentation change has been made.

Minor version bump

[ ] This PR introduces no new features.
[x] This PR introduces new features, and there is a separate PR to bump the minor version since the last release already.
[ ] This PR bumps the version.

Modified the hostmetrics receiver to include nvml otel receiver and generate nvml based on whether the system has GPUs. I kept the nvml testing folder in the 3P tests since we still need to setup GPU VMs (not based on distros in gcl but based on machine type) and install drivers (install and exercise script) to test nvml in hostmetrics.
This is now ready for review.


[Bug] missing custom ql packs

codeql-config.yml is referencing packs under a subfolder scope, but this folder and its files do not exist in this repo template.  Also the init and analyse v1 are depreciating, the template needs to update to v2

I've been struggling to use this so called training for the last hours by trying to make it work and not learned anything meaningful except that CodeQL as a product is a pain to use and docs are lacking...


wip: add union types

This PR aims tackles union types
closes #24

@emilsoman here's the first draft. Does this look good to you, or are there any major structural changes you want?

I noticed that we return a list of types instead of a string from the parser after parsing types. I am guessing it's because you wanted to check if the return type of a function is one of the possible types in the type spec of the function? I think that check should change to an "exact match" (that means we can still use strings). Reason - even though technically a function returning :foo can fit into a slot for :foo | :bar, the return type in the signature should be accurate about what the function actually returns. For example, this should not be allowed:
fn sum(a: Int, b: Int) : Int | String do
  a + b
end

because the function never returns a string and the signature is lying to the developer who will now have to conditionally handle ints and strings wherever this function is used. The compiler should report a type checking error saying the return type is specified as Int | String, but the function actually returns Int. This also means the parser can just return a string instead of a list of types. I agree that we should change this to a richer data structure later for better comparisons and improving our error messages, but this is not required for now.
Also, I am guessing the type checker changes are still WIP? A few things to note here:

if-else can now return two different types from their two branches and the type of the if-else expression will be the union type of these branches.

When passing args to functions, we need new checks now, examples:

# A function foo
#  that takes an arg x which can be an Int or a String
#  and returns one of Int, String, Bool
fn foo(x: Int | String) : Int | String | Bool

# A function bar
#  which takes an arg x which is a function ref
#    and the function it references should be able to take an Int and it should return a Bool.
fn bar(x : Fn(Int -> Bool)) : ...

This meansbar(&foo(Int)) should not be allowed because when foo is given an Int, it may return one of Int, String or Bool, but here, the function is expected to return only a Bool. But if bar was defined like fn bar(x: Fn(Int -> Int | String | Bool)), then we should be able to call bar(&foo(Int)).
Also, another case:
# x can be either an Int or a String depending on the condition evaluation during runtime.
x =
  if cond do
    123
  else
    "Hello world"
  end

# Given two function with signatures below:
fn func1(x: Int) : Int
fn func2(x: Int | String | Bool) : Int

func1(x) # not allowed
func2(x) # allowed

Hope it makes sense and you get where I'm going with this.

Also, I've simplified the parser a bit (removed a few unnecessary Enum.joins and exporting the atom parser) and added the union type parser here : https://github.com/fika-lang/fika/compare/union_type_parser?diff=split&expand=1 please take these changes into your branch if it makes sense

I noticed that we return a list of types instead of a string from the parser after parsing types. I am guessing it's because you wanted to check if the return type of a function is one of the possible types in the type spec of the function? I think that check should change to an "exact match" (that means we can still use strings). Reason - even though technically a function returning :foo can fit into a slot for :foo | :bar, the return type in the signature should be accurate about what the function actually returns. For example, this should not be allowed:

Ok, so basically that Enum.any? must change into an Enum.all?. However, I still think we need to parse types as lists so we can iterate through all of them individually. Otherwise, I'm gonna have to split the list anyway to check each type, or if not parsing, then some function that is inferred as ":foo | :bar" will not match exactly ":bar | :foo" whereas they are the same thing. Whad do you think about this?

Also, I am guessing the type checker changes are still WIP? A few things to note here:

Yeah, I've only changed the parser, basically, and made the other tests pass.

some function that is inferred as ":foo | :bar" will not match exactly ":bar | :foo" whereas they are the same thing

You are absolutely right, this is the part I was talking about in this line :

I agree that we should change this to a richer data structure later for better comparisons and improving our error messages

Let's see what happens without it:
fn fun : :bar | :foo do
  ...

  if cond do
    fn_that_returns_foo()
  else
    fn_that_returns_bar()
  end
end

TypeChecker reports the error: "Expected :bar | :foo, but got :foo | :bar. Now is it something we can live with for now? I thought about it and I feel this error message is okay, because the change I'd need to make to fix this is to make the signature reflect the order in which the return types are accumulated which is not so bad (some may even think this is a feature that helps readability of said function). But then again, I think enforcing order in union types isn't the right thing to do and why I suggested doing that is only to limit this PR's scope and introduce struct comparisons for type checking in a different PR. It's fine to use lists as intermediate step before that too, so I agree with your suggestion!

closed in favor of #43


Problem: NO audio output from, e.g. Chromium Browser

No audio from videos running in chromium browser or even YouTube itself.
So I can open YouTube (& other videos) but there is no audio, I check the tab is 'unmuted', I check that the system volume control is at MAX.  I messed around with the audio mixer, the 'test' button works but nothing else - I would say see screenshot, but I have wasted an hour trying to find a file which I could actually upload for your viewing pleasure and I go to my real-life paying job in about 12 hours so, I'm sorry I can't make that happen - yes, I tried every extension and pasting from clipboard, dragging, dropping everything, but none of that works for me.
Videos running in smplayer & vlc have no problem with audio.

U7 installed
just re-installed chrome. playing sound here

Closing issue.
Chromium browser options were changed to the OSS backend (instead of pulseaudio) a little while back and no reported issues since then.


WebJobs Extension: Allow binding to BlobContainerClient without blob

Contributing to the Azure SDK
resolves https://github.com/Azure/azure-functions-dotnet-worker/issues/1337
For binding BlobContainerClient as an input binding, we are required to provide blob name in the result such as BlobInput("input-container/blob-name"). We should be allowed to do this without providing the blob name, and currently we run into an error if you try to just put down the container name:
Invalid blob path specified : 'input-container'. Blob identifiers must be in the format 'container/blob'
This PR loosens the parsing and validating checks by adding a new parameter to BlobPath.ParseAndValidate called isParameterBindingData. This value is only set to true if we are binding to a parameter binding data type and then skips some of the checks which caused this to fail initially.
We have added a check in the dotnet worker to ensure that blob name cannot be null if we are not binding to a BlobContainerClient, which is the check we are skipping on the webjobs extension.

API change check
API changes are not detected in this pull request.

/azp run net - storage - tests

/check-enforcer override


Update update-nft-metadata.md

Description:
TokenUpdateNftsTransaction doesn't exist in the sdk, it's TokenNftsUpdateTransaction
Signed-off-by: MilanWR

I have no idea what this DCO thing is

@MilanWR this would point you to the steps to resolve DCO: https://github.com/hashgraph/hedera-docs/pull/663/checks?check_run_id=24904086031
In general you have to add this to your commit message: Signed-off-by: Author Name<EMAIL_ADDRESS>

thank you @SimiHunjan , do I need to create a new pull request?

@theekrystallee this change should be reverted, as TokenUpdateNftsTransaction now exists in the SDK and TokenNftsUpdateTransaction is removed. (no idea how i reopen this)

@MilanWR thanks for the ping. you dont have to reopen, I can make the changes and revert back. thanks again!

thanks @theekrystallee !


Closing #108 - live updates now allow differing OCI references while …

…still enforcing the increasing revision number requirement

@autodidaddict do we want to bump to 0.15.4 for this change? I'm interested in getting this into wash for live updates

yep, let's bump to 0.15.4

btw bumps can be done off-PR as one-offs I think. I'm not sure I feel like we should hold approval of PRs based on version increment prior to a release.


Gaps keeps crashing with BackendError

I have a test instance of gaps deployed on our internal server for evaluation. It is deployed inside a docker container following the instructions found in the README. Nothing exotic about the configuration.
The application doesn't seem to be able to run more than a couple of hours before it crashes with the following trace:
== Sinatra has ended his set (crowd applauds)
/gaps/vendor/bundle/ruby/2.1.0/gems/google-api-client-0.7.1/lib/google/api_client.rb:620:in `block in execute!': Backend Error (Google::APIClient::ServerError)
        from /gaps/vendor/bundle/ruby/2.1.0/gems/retriable-1.4.1/lib/retriable/retry.rb:27:in `perform'
        from /gaps/vendor/bundle/ruby/2.1.0/gems/retriable-1.4.1/lib/retriable.rb:15:in `retriable'
        from /gaps/vendor/bundle/ruby/2.1.0/gems/google-api-client-0.7.1/lib/google/api_client.rb:595:in `execute!'
        from /gaps/lib/gaps/requestor.rb:160:in `request'
        from /gaps/lib/gaps/requestor.rb:119:in `get_group_settings'
        from /gaps/lib/gaps/db/group.rb:95:in `update_config'
        from /gaps/lib/gaps/db/group.rb:187:in `block (2 levels) in refresh'
        from /gaps/vendor/bundle/ruby/2.1.0/gems/thread-0.1.4/lib/thread/future.rb:27:in `call'
        from /gaps/vendor/bundle/ruby/2.1.0/gems/thread-0.1.4/lib/thread/future.rb:27:in `block in initialize'
        from /gaps/vendor/bundle/ruby/2.1.0/gems/thread-0.1.4/lib/thread/pool.rb:56:in `call'
        from /gaps/vendor/bundle/ruby/2.1.0/gems/thread-0.1.4/lib/thread/pool.rb:56:in `execute'
        from /gaps/vendor/bundle/ruby/2.1.0/gems/thread-0.1.4/lib/thread/pool.rb:384:in `block (2 levels) in spawn_thread'
        from /gaps/vendor/bundle/ruby/2.1.0/gems/thread-0.1.4/lib/thread/pool.rb:351:in `loop'
        from /gaps/vendor/bundle/ruby/2.1.0/gems/thread-0.1.4/lib/thread/pool.rb:351:in `block in spawn_thread'
        from /gaps/vendor/bundle/ruby/2.1.0/gems/logging-1.8.2/lib/logging/diagnostic_context.rb:323:in `call'
        from /gaps/vendor/bundle/ruby/2.1.0/gems/logging-1.8.2/lib/logging/diagnostic_context.rb:323:in `block in create_with_logging_context'

Well, that doesn't sound like a very positive evaluation so far — sorry to hear that! Is it otherwise working smoothly?
I believe last time we saw this was due to Google issues — I believe that's just a generic 500. If it's just that specific endpoint that's breaking, one potential workaround is to set populate_group_settings to false in your site.yaml (which would disable that one call). Is it always that stack trace?

Not great indeed :disappointed:. The functionality is exactly what we need and the tool is performing superbly when it is up.
It is always the same stacktrace, and has been happening a couple hours after I bring it back up without fail.
I'll try disabling populate_group_settings in the yaml file. How will that affect user experience?

By default, it won't!
Today those settings are only used if you've switched to the api_scheme for privacy settings [1], i.e. you are using privacy settings out of Google's database rather than inferring based off the name/JSON tag [2].
Let me know if you see further troubles. With more data, I can probably whip up a patch (to e.g. do some exponential backoff on error rather than just crash).
[1] https://github.com/stripe/gaps/blob/master/lib/gaps/db/group.rb#L159-L160
[2] https://github.com/stripe/gaps#permissions

Ok -- thanks Greg, you've been immensely helpful. I'll make that change and close the issue in a couple of hours provided gaps is still up :)

disabling populate_group_settings did the trick. Gaps been up all day. Thanks!


issue 275

Update Python for version 12

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

BingAds/bingads-12/guides/sdk-reporting-service-manager.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


python3Packages.websockets: 8.0.2 -> 8.1

Motivation for this change
noticed the python38 build was broken when reviewing #73127
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[x] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

Notify maintainers
cc @

[16 built (7 failed), 32 copied (73.9 MiB), 15.0 MiB DL]
error: build of '/nix/store/xw7zhw57cq60rwcd2sfbf4d75093fn2a-env.drv' failed
https://github.com/NixOS/nixpkgs/pull/73128
2 package are marked as broken and were skipped:
python37Packages.discordpy python38Packages.discordpy

12 package failed to build:
datasette python37Packages.fastapi python37Packages.hbmqtt python37Packages.sentry-sdk python38Packages.datasette python38Packages.entrance python38Packages.entrance-with-router-features python38Packages.fastapi python38Packages.hbmqtt python38Packages.sanic python38Packages.starlette python38Packages.uvicorn

15 package were build:
gdbgui grab-site python37Packages.entrance python37Packages.entrance-with-router-features python37Packages.flask-socketio python37Packages.python-engineio python37Packages.python-socketio python37Packages.sanic python37Packages.starlette python37Packages.uvicorn python37Packages.websockets python38Packages.flask-socketio python38Packages.python-engineio python38Packages.python-socketio python38Packages.websockets

failures are broken on master

@GrahamcOfBorg build gdbgui grab-site python37Packages.entrance python37Packages.entrance-with-router-features python37Packages.flask-socketio python37Packages.python-engineio python37Packages.python-socketio python37Packages.sanic python37Packages.starlette python37Packages.uvicorn python37Packages.websockets python38Packages.flask-socketio python38Packages.python-engineio python38Packages.python-socketio python38Packages.websockets


MAPREDUCE-7472. Decode value of hive.query.string for the job Confguration which was encoded by hive

the value of  hive.query.string in job Configuratio is URLEncoded by hive and written to hdfs,which shoud be decoded before rendered

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 31s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  1s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

-1 :x:
test4tests
0m  0s

The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
42m 38s

trunk passed

+1 :green_heart:
compile
0m 36s

trunk passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
compile
0m 30s

trunk passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08

+1 :green_heart:
checkstyle
0m 33s

trunk passed

+1 :green_heart:
mvnsite
0m 36s

trunk passed

+1 :green_heart:
javadoc
0m 37s

trunk passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
0m 28s

trunk passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08

+1 :green_heart:
spotbugs
1m  2s

trunk passed

+1 :green_heart:
shadedclient
36m 13s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 25s

the patch passed

+1 :green_heart:
compile
0m 26s

the patch passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javac
0m 26s

the patch passed

+1 :green_heart:
compile
0m 22s

the patch passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08

+1 :green_heart:
javac
0m 22s

the patch passed

-1 :x:
blanks
0m  0s
/blanks-eol.txt
The patch has 3 line(s) that end in blanks. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply

-0 :warning:
checkstyle
0m 21s
/results-checkstyle-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-app.txt
hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app: The patch generated 4 new + 6 unchanged - 0 fixed = 10 total (was 6)

+1 :green_heart:
mvnsite
0m 25s

the patch passed

+1 :green_heart:
javadoc
0m 23s

the patch passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
0m 20s

the patch passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08

+1 :green_heart:
spotbugs
1m  2s

the patch passed

+1 :green_heart:
shadedclient
35m 26s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
8m 41s

hadoop-mapreduce-client-app in the patch passed.

+1 :green_heart:
asflicense
0m 33s

The patch does not generate ASF License warnings.

136m  0s

Subsystem
Report/Notes

Docker
ClientAPI=1.44 ServerAPI=1.44 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6520/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/6520

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux af0ab4bffa3f 5.15.0-88-generic #98-Ubuntu SMP Mon Oct 2 15:18:56 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / cc58401f9cf378ea34445158cefdd15ac768f011

Default Java
Private Build-1.8.0_392-8u392-ga-1~20.04-b08

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_392-8u392-ga-1~20.04-b08

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6520/1/testReport/

Max. process+thread count
762 (vs. ulimit of 5500)

modules
C: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app U: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6520/1/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 32s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

-1 :x:
test4tests
0m  0s

The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
46m 11s

trunk passed

+1 :green_heart:
compile
0m 33s

trunk passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
compile
0m 30s

trunk passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08

+1 :green_heart:
checkstyle
0m 33s

trunk passed

+1 :green_heart:
mvnsite
0m 35s

trunk passed

+1 :green_heart:
javadoc
0m 37s

trunk passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
0m 30s

trunk passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08

+1 :green_heart:
spotbugs
1m  2s

trunk passed

+1 :green_heart:
shadedclient
36m 44s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 26s

the patch passed

+1 :green_heart:
compile
0m 24s

the patch passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javac
0m 24s

the patch passed

+1 :green_heart:
compile
0m 24s

the patch passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08

+1 :green_heart:
javac
0m 24s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
0m 28s
/results-checkstyle-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-app.txt
hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app: The patch generated 3 new + 6 unchanged - 0 fixed = 9 total (was 6)

+1 :green_heart:
mvnsite
0m 33s

the patch passed

+1 :green_heart:
javadoc
0m 30s

the patch passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
0m 22s

the patch passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08

+1 :green_heart:
spotbugs
1m  3s

the patch passed

+1 :green_heart:
shadedclient
37m 41s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
8m 47s

hadoop-mapreduce-client-app in the patch passed.

+1 :green_heart:
asflicense
0m 35s

The patch does not generate ASF License warnings.

142m 50s

Subsystem
Report/Notes

Docker
ClientAPI=1.44 ServerAPI=1.44 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6520/2/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/6520

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux f001bf3d90e9 5.15.0-88-generic #98-Ubuntu SMP Mon Oct 2 15:18:56 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 9035b9eb336824a89003908d4b092b3d9fe2238d

Default Java
Private Build-1.8.0_392-8u392-ga-1~20.04-b08

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_392-8u392-ga-1~20.04-b08

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6520/2/testReport/

Max. process+thread count
721 (vs. ulimit of 5500)

modules
C: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app U: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6520/2/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
17m 59s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

-1 :x:
test4tests
0m  0s

The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
46m 15s

trunk passed

+1 :green_heart:
compile
0m 35s

trunk passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
compile
0m 30s

trunk passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08

+1 :green_heart:
checkstyle
0m 33s

trunk passed

+1 :green_heart:
mvnsite
0m 35s

trunk passed

+1 :green_heart:
javadoc
0m 37s

trunk passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
0m 29s

trunk passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08

+1 :green_heart:
spotbugs
1m  1s

trunk passed

+1 :green_heart:
shadedclient
38m  7s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 25s

the patch passed

+1 :green_heart:
compile
0m 26s

the patch passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javac
0m 26s

the patch passed

+1 :green_heart:
compile
0m 22s

the patch passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08

+1 :green_heart:
javac
0m 22s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
0m 23s
/results-checkstyle-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-app.txt
hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app: The patch generated 3 new + 6 unchanged - 0 fixed = 9 total (was 6)

+1 :green_heart:
mvnsite
0m 26s

the patch passed

+1 :green_heart:
javadoc
0m 24s

the patch passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
0m 22s

the patch passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08

+1 :green_heart:
spotbugs
1m  1s

the patch passed

+1 :green_heart:
shadedclient
37m 29s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
8m 26s

hadoop-mapreduce-client-app in the patch passed.

+1 :green_heart:
asflicense
0m 34s

The patch does not generate ASF License warnings.

161m  1s

Subsystem
Report/Notes

Docker
ClientAPI=1.44 ServerAPI=1.44 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6520/3/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/6520

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux 5d92a8e76d29 5.15.0-88-generic #98-Ubuntu SMP Mon Oct 2 15:18:56 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 1cbc99537b8917af795dd88fb42e3e95b5bea137

Default Java
Private Build-1.8.0_392-8u392-ga-1~20.04-b08

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_392-8u392-ga-1~20.04-b08

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6520/3/testReport/

Max. process+thread count
584 (vs. ulimit of 5500)

modules
C: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app U: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6520/3/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

_ Prechecks _

+1 :green_heart:
dupname
0m 00s

No case conflicting files found.

+0 :ok:
spotbugs
0m 01s

spotbugs executables are not available.

+0 :ok:
codespell
0m 01s

codespell was not available.

+0 :ok:
detsecrets
0m 01s

detect-secrets was not available.

+1 :green_heart:
@author
0m 00s

The patch does not contain any @author tags.

-1 :x:
test4tests
0m 00s

The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
88m 28s

trunk passed

+1 :green_heart:
compile
4m 41s

trunk passed

+1 :green_heart:
checkstyle
4m 32s

trunk passed

+1 :green_heart:
mvnsite
4m 44s

trunk passed

+1 :green_heart:
javadoc
4m 27s

trunk passed

+1 :green_heart:
shadedclient
139m 23s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
2m 31s

the patch passed

+1 :green_heart:
compile
2m 08s

the patch passed

+1 :green_heart:
javac
2m 08s

the patch passed

+1 :green_heart:
blanks
0m 01s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
1m 59s

the patch passed

+1 :green_heart:
mvnsite
2m 12s

the patch passed

+1 :green_heart:
javadoc
2m 10s

the patch passed

+1 :green_heart:
shadedclient
149m 51s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
asflicense
5m 06s

The patch does not generate ASF License warnings.

399m 51s

Subsystem
Report/Notes

GITHUB PR
https://github.com/apache/hadoop/pull/6520

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
MINGW64_NT-10.0-17763 cc389b246f28 3.4.10-87d57229.x86_64 2024-02-14 20:17 UTC x86_64 Msys

Build tool
maven

Personality
/c/hadoop/dev-support/bin/hadoop.sh

git revision
trunk / 1cbc99537b8917af795dd88fb42e3e95b5bea137

Default Java
Azul Systems, Inc.-1.8.0_332-b09

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch-windows-10/job/PR-6520/1/testReport/

modules
C: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app U: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch-windows-10/job/PR-6520/1/console

versions
git=2.44.0.windows.1

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

This is actually not the right way to do such things, we can't hardcode a hive conf in the MR code.
The correct way would be to introduce a config which can take a csv with a set of configs which should be decoded for UI and from Hive we can set that conf to have hive.query.string.

patch updated, thanks for your suggestion .

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 31s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+0 :ok:
detsecrets
0m  1s

detect-secrets was not available.

+0 :ok:
xmllint
0m  1s

xmllint was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

-1 :x:
test4tests
0m  0s

The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

+0 :ok:
mvndep
14m 40s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
34m 44s

trunk passed

+1 :green_heart:
compile
1m 47s

trunk passed with JDK Ubuntu-11.0.23+9-post-Ubuntu-1ubuntu120.04.2

+1 :green_heart:
compile
1m 38s

trunk passed with JDK Private Build-1.8.0_412-8u412-ga-1~20.04.1-b08

+1 :green_heart:
checkstyle
1m 16s

trunk passed

+1 :green_heart:
mvnsite
1m 14s

trunk passed

+1 :green_heart:
javadoc
0m 59s

trunk passed with JDK Ubuntu-11.0.23+9-post-Ubuntu-1ubuntu120.04.2

+1 :green_heart:
javadoc
0m 54s

trunk passed with JDK Private Build-1.8.0_412-8u412-ga-1~20.04.1-b08

+1 :green_heart:
spotbugs
2m 27s

trunk passed

+1 :green_heart:
shadedclient
37m 57s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 32s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
0m 57s

the patch passed

+1 :green_heart:
compile
1m 38s

the patch passed with JDK Ubuntu-11.0.23+9-post-Ubuntu-1ubuntu120.04.2

+1 :green_heart:
javac
1m 38s

the patch passed

+1 :green_heart:
compile
1m 33s

the patch passed with JDK Private Build-1.8.0_412-8u412-ga-1~20.04.1-b08

+1 :green_heart:
javac
1m 33s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
1m  7s
/results-checkstyle-hadoop-mapreduce-project_hadoop-mapreduce-client.txt
hadoop-mapreduce-project/hadoop-mapreduce-client: The patch generated 1 new + 471 unchanged - 0 fixed = 472 total (was 471)

+1 :green_heart:
mvnsite
1m  3s

the patch passed

+1 :green_heart:
javadoc
0m 43s

the patch passed with JDK Ubuntu-11.0.23+9-post-Ubuntu-1ubuntu120.04.2

+1 :green_heart:
javadoc
0m 43s

the patch passed with JDK Private Build-1.8.0_412-8u412-ga-1~20.04.1-b08

+1 :green_heart:
spotbugs
2m 36s

the patch passed

+1 :green_heart:
shadedclient
36m 53s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
8m 27s

hadoop-mapreduce-client-core in the patch passed.

+1 :green_heart:
unit
8m 46s

hadoop-mapreduce-client-app in the patch passed.

+1 :green_heart:
asflicense
0m 36s

The patch does not generate ASF License warnings.

165m 20s

Subsystem
Report/Notes

Docker
ClientAPI=1.44 ServerAPI=1.44 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6520/4/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/6520

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets xmllint

uname
Linux d0033da0c6ad 5.15.0-94-generic #104-Ubuntu SMP Tue Jan 9 15:25:40 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / abaec5cb668bc92061db35b9fceab12c84322365

Default Java
Private Build-1.8.0_412-8u412-ga-1~20.04.1-b08

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.23+9-post-Ubuntu-1ubuntu120.04.2 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_412-8u412-ga-1~20.04.1-b08

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6520/4/testReport/

Max. process+thread count
1303 (vs. ulimit of 5500)

modules
C: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app U: hadoop-mapreduce-project/hadoop-mapreduce-client

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6520/4/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

add UT for the pr

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 44s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+0 :ok:
detsecrets
0m  1s

detect-secrets was not available.

+0 :ok:
xmllint
0m  1s

xmllint was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+0 :ok:
mvndep
14m 25s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
37m 36s

trunk passed

+1 :green_heart:
compile
1m 47s

trunk passed with JDK Ubuntu-11.0.23+9-post-Ubuntu-1ubuntu120.04.2

+1 :green_heart:
compile
1m 37s

trunk passed with JDK Private Build-1.8.0_412-8u412-ga-1~20.04.1-b08

+1 :green_heart:
checkstyle
1m 11s

trunk passed

+1 :green_heart:
mvnsite
1m 15s

trunk passed

+1 :green_heart:
javadoc
1m  0s

trunk passed with JDK Ubuntu-11.0.23+9-post-Ubuntu-1ubuntu120.04.2

+1 :green_heart:
javadoc
0m 51s

trunk passed with JDK Private Build-1.8.0_412-8u412-ga-1~20.04.1-b08

+1 :green_heart:
spotbugs
2m 22s

trunk passed

+1 :green_heart:
shadedclient
39m 31s

branch has no errors when building and testing our client artifacts.

-0 :warning:
patch
39m 51s

Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 28s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
0m 57s

the patch passed

+1 :green_heart:
compile
1m 41s

the patch passed with JDK Ubuntu-11.0.23+9-post-Ubuntu-1ubuntu120.04.2

+1 :green_heart:
javac
1m 41s

the patch passed

+1 :green_heart:
compile
1m 31s

the patch passed with JDK Private Build-1.8.0_412-8u412-ga-1~20.04.1-b08

+1 :green_heart:
javac
1m 31s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
1m  3s
/results-checkstyle-hadoop-mapreduce-project_hadoop-mapreduce-client.txt
hadoop-mapreduce-project/hadoop-mapreduce-client: The patch generated 2 new + 481 unchanged - 0 fixed = 483 total (was 481)

+1 :green_heart:
mvnsite
0m 59s

the patch passed

+1 :green_heart:
javadoc
0m 42s

the patch passed with JDK Ubuntu-11.0.23+9-post-Ubuntu-1ubuntu120.04.2

+1 :green_heart:
javadoc
0m 39s

the patch passed with JDK Private Build-1.8.0_412-8u412-ga-1~20.04.1-b08

+1 :green_heart:
spotbugs
2m 27s

the patch passed

+1 :green_heart:
shadedclient
39m 41s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
8m 11s

hadoop-mapreduce-client-core in the patch passed.

+1 :green_heart:
unit
8m 17s

hadoop-mapreduce-client-app in the patch passed.

+1 :green_heart:
asflicense
0m 32s

The patch does not generate ASF License warnings.

170m 58s

Subsystem
Report/Notes

Docker
ClientAPI=1.44 ServerAPI=1.44 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6520/5/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/6520

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets xmllint

uname
Linux 31f73d95e50b 5.15.0-94-generic #104-Ubuntu SMP Tue Jan 9 15:25:40 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 3f3f9ffcd811918c63c1b5080a45a50dbefbe72f

Default Java
Private Build-1.8.0_412-8u412-ga-1~20.04.1-b08

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.23+9-post-Ubuntu-1ubuntu120.04.2 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_412-8u412-ga-1~20.04.1-b08

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6520/5/testReport/

Max. process+thread count
1084 (vs. ulimit of 5500)

modules
C: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app U: hadoop-mapreduce-project/hadoop-mapreduce-client

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6520/5/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 45s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+0 :ok:
detsecrets
0m  1s

detect-secrets was not available.

+0 :ok:
xmllint
0m  1s

xmllint was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+0 :ok:
mvndep
14m 24s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
36m 34s

trunk passed

+1 :green_heart:
compile
1m 49s

trunk passed with JDK Ubuntu-11.0.23+9-post-Ubuntu-1ubuntu120.04.2

+1 :green_heart:
compile
1m 36s

trunk passed with JDK Private Build-1.8.0_412-8u412-ga-1~20.04.1-b08

+1 :green_heart:
checkstyle
1m 14s

trunk passed

+1 :green_heart:
mvnsite
1m 17s

trunk passed

+1 :green_heart:
javadoc
1m  2s

trunk passed with JDK Ubuntu-11.0.23+9-post-Ubuntu-1ubuntu120.04.2

+1 :green_heart:
javadoc
0m 53s

trunk passed with JDK Private Build-1.8.0_412-8u412-ga-1~20.04.1-b08

+1 :green_heart:
spotbugs
2m 19s

trunk passed

+1 :green_heart:
shadedclient
38m 47s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 30s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
0m 54s

the patch passed

+1 :green_heart:
compile
1m 40s

the patch passed with JDK Ubuntu-11.0.23+9-post-Ubuntu-1ubuntu120.04.2

+1 :green_heart:
javac
1m 40s

the patch passed

+1 :green_heart:
compile
1m 31s

the patch passed with JDK Private Build-1.8.0_412-8u412-ga-1~20.04.1-b08

+1 :green_heart:
javac
1m 31s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
1m  4s
/results-checkstyle-hadoop-mapreduce-project_hadoop-mapreduce-client.txt
hadoop-mapreduce-project/hadoop-mapreduce-client: The patch generated 2 new + 481 unchanged - 0 fixed = 483 total (was 481)

+1 :green_heart:
mvnsite
1m  0s

the patch passed

+1 :green_heart:
javadoc
0m 43s

the patch passed with JDK Ubuntu-11.0.23+9-post-Ubuntu-1ubuntu120.04.2

+1 :green_heart:
javadoc
0m 41s

the patch passed with JDK Private Build-1.8.0_412-8u412-ga-1~20.04.1-b08

+1 :green_heart:
spotbugs
2m 28s

the patch passed

+1 :green_heart:
shadedclient
40m  8s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
8m 19s

hadoop-mapreduce-client-core in the patch passed.

+1 :green_heart:
unit
8m 30s

hadoop-mapreduce-client-app in the patch passed.

+1 :green_heart:
asflicense
0m 35s

The patch does not generate ASF License warnings.

170m 17s

Subsystem
Report/Notes

Docker
ClientAPI=1.44 ServerAPI=1.44 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6520/6/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/6520

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets xmllint

uname
Linux e456880a6c2c 5.15.0-94-generic #104-Ubuntu SMP Tue Jan 9 15:25:40 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 45f51dfefc58cc016fb5c643c33a2f03a875108e

Default Java
Private Build-1.8.0_412-8u412-ga-1~20.04.1-b08

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.23+9-post-Ubuntu-1ubuntu120.04.2 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_412-8u412-ga-1~20.04.1-b08

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6520/6/testReport/

Max. process+thread count
1079 (vs. ulimit of 5500)

modules
C: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app U: hadoop-mapreduce-project/hadoop-mapreduce-client

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6520/6/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

fix checkstyle of WhitespaceAfter,another one :'method call' child has incorrect indentation level 10  ,is legacy code

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
6m 37s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+0 :ok:
xmllint
0m  0s

xmllint was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+0 :ok:
mvndep
14m 23s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
20m  8s

trunk passed

+1 :green_heart:
compile
0m 58s

trunk passed with JDK Ubuntu-11.0.23+9-post-Ubuntu-1ubuntu120.04.2

+1 :green_heart:
compile
0m 52s

trunk passed with JDK Private Build-1.8.0_412-8u412-ga-1~20.04.1-b08

+1 :green_heart:
checkstyle
0m 36s

trunk passed

+1 :green_heart:
mvnsite
0m 51s

trunk passed

+1 :green_heart:
javadoc
0m 44s

trunk passed with JDK Ubuntu-11.0.23+9-post-Ubuntu-1ubuntu120.04.2

+1 :green_heart:
javadoc
0m 39s

trunk passed with JDK Private Build-1.8.0_412-8u412-ga-1~20.04.1-b08

+1 :green_heart:
spotbugs
1m 28s

trunk passed

+1 :green_heart:
shadedclient
19m 53s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 22s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
0m 35s

the patch passed

+1 :green_heart:
compile
0m 51s

the patch passed with JDK Ubuntu-11.0.23+9-post-Ubuntu-1ubuntu120.04.2

+1 :green_heart:
javac
0m 51s

the patch passed

+1 :green_heart:
compile
0m 46s

the patch passed with JDK Private Build-1.8.0_412-8u412-ga-1~20.04.1-b08

+1 :green_heart:
javac
0m 46s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
0m 31s
/results-checkstyle-hadoop-mapreduce-project_hadoop-mapreduce-client.txt
hadoop-mapreduce-project/hadoop-mapreduce-client: The patch generated 1 new + 481 unchanged - 0 fixed = 482 total (was 481)

+1 :green_heart:
mvnsite
0m 36s

the patch passed

+1 :green_heart:
javadoc
0m 28s

the patch passed with JDK Ubuntu-11.0.23+9-post-Ubuntu-1ubuntu120.04.2

+1 :green_heart:
javadoc
0m 30s

the patch passed with JDK Private Build-1.8.0_412-8u412-ga-1~20.04.1-b08

+1 :green_heart:
spotbugs
1m 32s

the patch passed

+1 :green_heart:
shadedclient
19m 51s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
6m 15s

hadoop-mapreduce-client-core in the patch passed.

+1 :green_heart:
unit
6m 49s

hadoop-mapreduce-client-app in the patch passed.

+1 :green_heart:
asflicense
0m 26s

The patch does not generate ASF License warnings.

107m 44s

Subsystem
Report/Notes

Docker
ClientAPI=1.46 ServerAPI=1.46 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6520/8/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/6520

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets xmllint

uname
Linux 929ba39f9639 5.15.0-106-generic #116-Ubuntu SMP Wed Apr 17 09:17:56 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / de49c49ca8ccb99178568a01138f39902d812ac1

Default Java
Private Build-1.8.0_412-8u412-ga-1~20.04.1-b08

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.23+9-post-Ubuntu-1ubuntu120.04.2 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_412-8u412-ga-1~20.04.1-b08

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6520/8/testReport/

Max. process+thread count
1528 (vs. ulimit of 5500)

modules
C: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app U: hadoop-mapreduce-project/hadoop-mapreduce-client

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6520/8/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 32s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+0 :ok:
xmllint
0m  0s

xmllint was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+0 :ok:
mvndep
14m 44s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
34m 30s

trunk passed

+1 :green_heart:
compile
1m 43s

trunk passed with JDK Ubuntu-11.0.23+9-post-Ubuntu-1ubuntu120.04.2

+1 :green_heart:
compile
1m 35s

trunk passed with JDK Private Build-1.8.0_412-8u412-ga-1~20.04.1-b08

+1 :green_heart:
checkstyle
1m 12s

trunk passed

+1 :green_heart:
mvnsite
1m 19s

trunk passed

+1 :green_heart:
javadoc
1m  2s

trunk passed with JDK Ubuntu-11.0.23+9-post-Ubuntu-1ubuntu120.04.2

+1 :green_heart:
javadoc
0m 56s

trunk passed with JDK Private Build-1.8.0_412-8u412-ga-1~20.04.1-b08

+1 :green_heart:
spotbugs
2m 20s

trunk passed

+1 :green_heart:
shadedclient
35m  5s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 32s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
0m 55s

the patch passed

+1 :green_heart:
compile
1m 38s

the patch passed with JDK Ubuntu-11.0.23+9-post-Ubuntu-1ubuntu120.04.2

+1 :green_heart:
javac
1m 38s

the patch passed

+1 :green_heart:
compile
1m 32s

the patch passed with JDK Private Build-1.8.0_412-8u412-ga-1~20.04.1-b08

+1 :green_heart:
javac
1m 32s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
1m  6s
/results-checkstyle-hadoop-mapreduce-project_hadoop-mapreduce-client.txt
hadoop-mapreduce-project/hadoop-mapreduce-client: The patch generated 1 new + 481 unchanged - 0 fixed = 482 total (was 481)

+1 :green_heart:
mvnsite
1m  4s

the patch passed

+1 :green_heart:
javadoc
0m 43s

the patch passed with JDK Ubuntu-11.0.23+9-post-Ubuntu-1ubuntu120.04.2

+1 :green_heart:
javadoc
0m 44s

the patch passed with JDK Private Build-1.8.0_412-8u412-ga-1~20.04.1-b08

+1 :green_heart:
spotbugs
2m 29s

the patch passed

+1 :green_heart:
shadedclient
36m 44s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
8m 30s

hadoop-mapreduce-client-core in the patch passed.

+1 :green_heart:
unit
8m 49s

hadoop-mapreduce-client-app in the patch passed.

+1 :green_heart:
asflicense
0m 37s

The patch does not generate ASF License warnings.

162m  6s

Subsystem
Report/Notes

Docker
ClientAPI=1.44 ServerAPI=1.44 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6520/7/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/6520

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets xmllint

uname
Linux 7b18390bd17f 5.15.0-94-generic #104-Ubuntu SMP Tue Jan 9 15:25:40 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / de49c49ca8ccb99178568a01138f39902d812ac1

Default Java
Private Build-1.8.0_412-8u412-ga-1~20.04.1-b08

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.23+9-post-Ubuntu-1ubuntu120.04.2 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_412-8u412-ga-1~20.04.1-b08

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6520/7/testReport/

Max. process+thread count
1656 (vs. ulimit of 5500)

modules
C: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app U: hadoop-mapreduce-project/hadoop-mapreduce-client

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6520/7/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.


Include section on generic type for event args

Improves the details of grabbing the event args through the EventToCommandBehavior class as previously discussed at https://github.com/CommunityToolkit/Maui/issues/569

Learn Build status updates of commit 9cf1619:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/maui/behaviors/event-to-command-behavior.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the learn.microsoft.com contributor guidesPost your question in the Learn support channel

Learn Build status updates of commit 430437b:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/maui/behaviors/event-to-command-behavior.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the learn.microsoft.com contributor guidesPost your question in the Learn support channel


Release Notes page in Documentation is broken

Page for Release Notes is not working the version is in the url:
This works:
https://sdk.openui5.org/#releasenotes.html
This does not work
https://sdk.openui5.org/1.126.1/#releasenotes.html
Seems broken since 1.121.0
Error in this method:
https://github.com/SAP/openui5/blame/eb7eddcbf15d4219810f4611efedceb89dc37267/src/sap.ui.documentation/src/sap/ui/documentation/sdk/controller/ReleaseNotes.controller.js#L37

Hello @marianfoo,
Thank you for sharing this finding.
I've created an internal incident DINC0216943.
The status of the issue will be updated here in GitHub.
Regards,
Konstantin


Making a mod that uses RF + compatibility

Issue Description:
Using the energy capability system provided in forge for Minecraft version 1.10.2 and forge version 1.10.2-<IP_ADDRESS>2. It seems that I can only insert energy and can't extract from any of them. I expected to be able to extract from generators and capacitors. Note this also is the case with the RF API. I can provide the code I am using to attempt this if necessary.
To reproduce

Setup the forge workspace for a new mod or use an existing one.
Create a block that accesses the Energy capability from an adjacent TE either a generator or capacitor.
After accessing it try to extract from it.

EnderIO: 1.10.2-3.1.156
EnderCore: 1.10.2-<IP_ADDRESS>-beta
Minecraft: 1.10.2
Forge: 1.10.2-<IP_ADDRESS>2

It is push based - the generators and cap banks will push energy to your block.

What if my block is just supposed to interface with it to move the energy and not store it? I assume it is not possible.

The pull-based part in the RF API was always a cause for many bugs - it is good that this is now gone.

Alright I will have to work around that then.

Sure that's possible. when you receive energy, just immediately push it out to neighbors. not that complicated.


chore: add missing test dependency to setup.py

What I did

Added missing click test dependency
Fixed IDE-found typing issue with CLI argument

How I did it
Self explanatory :)
How to verify it
Everything still works
Checklist

[ ] Passes all linting checks (pre-commit and CI jobs)
[ ] New test cases have been added and are passing
[ ] Documentation has been updated
[ ] PR title follows Conventional Commit standard (will be automatically included in the changelog)

I think this can be closed?


Padding applying to text boxes bounding box

Feature request / enhancement
Padding around text will often be start from the text box edge rather than the text itself. Is there any way around this other than setting line height?
In the example below, 5px padding has been applied to all edges but the reality is 9px on top

I'm not sure there is anything for paddy could detect, beyond line height, unless the characters were outlined.
You could have two different symbols with different line heights, one for descender, one for baseline.


feat: add step by step test instructions

Need to update the gitlab actions to use the new certy thing.


Twitch Microservice

A new service should be added for Twitch. This will be running entirely separately from the bot in a different process. The code should be maintained in root/services/twitch/*
The main file should be called mod.ts to initiate the process.
The service should communicate with the database and fetch the subscriptions from the twitch table. This should then handle as necessary with the Twitch api and when a new stream is located it should send it out using a webhook.
IMPORTANT: The service should never depend on the bot being alive and vice versa.
--
A command should be added to the bot that allows users to subscribe/unsubscribe to a channel. The command should create a webhook and store it in the database.

MUST SUPPORT FILTER OPTION BY GAME! VERY IMPORTANT! WITHOUT THIS TWITCH FEATURE IS
NO GOOD!

Concept:
1 addition is a customizable message that admins can add in the twitch command. (could use this to @ users/roles when a stream is live)

@ q


Issue Setting Background in setupCellBeforeDisplay from CloudKit

There's probably a simple solution to this - I'm a pretty new developer.
I'm trying to set my cell background color by syncing it with CloudKit - I have 3 different types of dates in my CloudKit record, and have written a function to sort them into 3 different arrays of [NSDate]. Then in a separate function, cellState.date == an object in one of the arrays, it will set the appropriate background color. It works correctly the first time the calendarView loads, but then when I scroll to the next month, it begins coloring cells that don't have dates in the CloudKit array, and will keep doing that when I scroll back to the initial month. Screenshots below (first 'August' is correct, September and second August aren't). Also shots of my code - func configureBackgroundColor gets called inside of func populateClasses(cellState), and func populateClasses(cellState) is called inside of setupCellBeforeDisplay. I think I've just misunderstood how the calendarView implements the cellView...
I really appreciate any help you can give me, and definitely want to say thanks for making this awesome library! I'm really loving it!

Would this be of help to you?

Thanks - that definitely helped, and sorry about not taking a closer look at the FAQ. I've been going through your delegate methods and a few other people's calendars, and am trying to understand where I define/access the dequeueReusableCellIdentifier set up on the collection view used for the CalendarView. Do I need to define a custom CalendarView class that inherits from JTAppleCalendarView, and then implement that on my ViewController, or can it all be done within the ViewController file? Thanks again for helping with basic questions.

Can you let me know what you are trying to do?
I do not think you have access to that identifier.
you can join me here if youre online.

Issue resolved over chat. If you have any other problems, create a new issue.


Underscores at beginning of directory names create problems for open_dataset function

When attempting to source parquet files for a dataset, I've found that underscores at the beginning of directory names (which I use often for OCD purposes) cause the function to not find any files.
Examples:
dataset <- open_dataset(     sources = "/data/_split_data",     partitioning = hive_partition(year = int32(), month = string()) )
dataset <- open_dataset(     sources = "/_data/split_data",     partitioning = hive_partition(year = int32(), month = string()) )
Both of these return FileSystemDataset with 0 Parquet files when queried via console. If I remove underscores from the beginning of directory names, the function returns as expected.

Thanks. Please open a JIRA and we can discuss there.

There is already an issue about this -> https://issues.apache.org/jira/browse/ARROW-9573

Actually, this is a slightly different issue, since it is not about underscores in partition keys, but in the base path. I thought this was something we already fixed.

I suppose I remember https://issues.apache.org/jira/browse/ARROW-8427, which seems somewhat similar (about only skipping underscores in child directories, not in the base path). I suppose that case fixed it for a list of file paths, and not for a directory. Opened https://issues.apache.org/jira/browse/ARROW-9644 for this