How to separate Frontend & Backend to use different tables (member/admin style)

I have setup a few Yii1 sites, and another Yii2 basic site.
I am used to other systems having a "members" directory, with a "members" table (or users) and an "admin" directory using an "admin" table. I am sure many of us have seen it, and that is how I like it. I like to separate the two entirely. If there was a hole, and some malicious user was to execute things they shouldn't, they could gain access to things they shouldn't. From a security point of view, the code to do admin things shouldn't be in the same file/script that users access. This has been talked about for years, and covered by security experts.
I thought Yii2 Advanced was like this. It has a frontend and backend, which looks like user and admin sections. However, the backend uses /common/models/LoginForm, which results in the same user table. It looks like any user on frontend can simply navigate to backend and be logged in?
I have tried to separate them, but have found little help online about this.
My StackOverflow Question: http://stackoverflow.com/questions/30060571/yii2-advanced-make-backend-use-admin-table-and-admin-model
I am needing the backend to be completely separate from frontend. A logged in user on frontend should not have access to backend. The backend should use a different table ('admin') from the frontend ('user').
Since frontend uses Yii::$app->user for the frontend (users), I guess that means Yii::$app->admin for the backend (admin). I see the backend also uses Yii::$app->user, so how does it know the difference between a frontend and backend user?
If you look at my SO question, you can see that I have copied the /common/models/User model as Admin, edited the main config.. I get errors, and not sure what all I have to do to get these separated. I can't find anything in the docs to help me figure out the process. I don't have a problem copying or extending classes, I just have no idea what has to be done to pull it off. I made AdminLoginForm and referenced the Admin class instead of user, but just felt I was going further down the rabbit hole. While I do assume this would require a separate login form, I don't know if the other stuff is right (main config, Admin model, etc) so I wouldn't know if it was due to errors in other areas.
IMO it should be like this out of the box, two separate sections shouldn't share the same users. Why can't the Yii2 Advanced come with an Admin section (whether it replaces backend, or it generates frontend, backend, admin) and it's own Admin model, login form, etc. We can delete it if we don't need it. It seems like it would be a very common setup that many of us would appreciate.
My guess is the logic behind it is frontend is for non-logged in users, and backend is for logged in users. Most systems need an admin section to manage those users (add/edit/delete/reset pass) at a minimum.

Advanced project template is just a template and you're free to adjust it as required. We don't plan to introduce such separation by default.

I understand that it is just a template. My question still persists.
I have it kind of setup, but it just is buggy and acting weird. It must be missing something.

Steps I have done
Install Yii2 Advanced, migrate, signup on frontend to create a new user. Copy 'user' table as 'admin', rename first username to 'admin' keeping the password the same (123456 for testing). Now I have a user and admin in the database.
Duplicate /common/models/User.php to Admin.php (changing name of the class)
Duplicate /common/models/LoginForm.php to AdminLoginForm.php (changing name of the class)
Edit /backend/controllers/SiteController.php to use AdminLoginForm instead of LoginForm, as well as all references to LoginForm to AdminLoginForm.
Edit /backend/config/main.php user component to:
'components' => [
'user' => [
'identityClass' => 'common\models\Admin',
'enableAutoLogin' => true,
],
],

What is happening
Individually, I can login to frontend or backend just fine. However, once you go to one (frontend) and logout, the other side fails to login (backend), or vica-versa. I test using private browsing, so I close and re-open the browser and it works fine. Like there is something with the cookies, but each section has their own unique 'cookieValidationKey'...
I had logged in as a frontend user, opened backend.. logged out of frontend. re-logged into frontend, and it took me to the backend.. what?
If you login to backend, then open a new tab and go to frontend you are logged in as the user with that same ID. So logging into backend makes you logged in as another user in frontend. If you login to the frontend, then open new tab and go to backend, you are the also logged in (given the id number exists). So basically a logged in user can navigate to my admin panel and be logged in.
It is just acting crazy, and I assume there is something else I need to do...
What do I need to do to separate the two? Is there anything in the docs relating to any of this? I must be missing something. I understand that I probably DO need to extend something else in Yii, but the docs don't shed any light on the subject.. And Googling my issue 10 different ways, I can't seem to get anywhere.
I tried to change the user component in backend/config/main.php to 'admin' and got errors about 'User::identityClass must be set'. It didn't like the main.php not having 'user' defined.
'components' => [
    'admin' => [
        'identityClass' => 'common\models\Admin',
        'enableAutoLogin' => true,
    ],
],

It didn't like that.. I thought that since frontend and backend would both use Yii::$app->user->isGuest(), that was the problem. Since a user on the frontend, going to the backend, would technically pass the user->isGuest() check.. So backend would need it's own, like: Yii::$app->admin->isGuest().
I understand if this is the wrong section, and would gladly move it or welcome it moved. I posted here because someone with a similar issue posted in the docs section. I think the docs could use some more info on the advanced template. It says the frontend and backend are like separate apps, but they are not behaving like they are separate considering something in frontend affects the backend (being logged in on one, assumes you can be logged into the other).

@WadeShuler

Like there is something with the cookies, but each section has their own unique 'cookieValidationKey'...

To separate backend and frontend completely like you want you also need to configure different names for user identityCookie name, request csrfParam and session name.

@SDKiller Thank you very much for replying! I made great headway with what you said, and searching for 'identityCookie' and other session info, I found some other pages relating to what I am trying to do (separate frontend from backend, error with them both being logged in). I wish I could have found them days ago.
Frontend main config:
'components' => [
    'user' => [
        'identityClass' => 'common\models\User',
        'enableAutoLogin' => true,
        'identityCookie' => [
            'name' => '_frontendUser', // unique for frontend
            //'path'=>'/advanced/frontend'  // correct path for the frontend app.
        ]
    ],
    'session' => [
        'name' => 'PHPFRONTSESSID',
        'savePath' => sys_get_temp_dir(),  //__DIR__ . '/../tmp',
    ],
],

Backend main config:
'components' => [
    'user' => [
        'identityClass' => 'common\models\Admin',
        //'class' => 'common\models\web\Admin',
        //'class' => 'Yii\web\user',
        'enableAutoLogin' => true,
        'identityCookie' => [
            'name' => '_backendUser', // unique for backend
            //'path'=>'/advanced/backend'  // correct path for the backend app.
        ]
    ],
    'session' => [
        'name' => 'PHPBACKSESSID',
        'savePath' => sys_get_temp_dir(),  //__DIR__ . '/../tmp',
    ],
],

This is almost there. Frontend and Backend login independently as the correct users.
I am getting an error when I try to logout of the frontend. However, I can logout of the backend without an error. Weird.
When logging out of the frontend, I get this error: Bad Request (#400)
I know it's a 400 Bad Request error, and looking at what Yii debug gives me, I can't see much.

@WadeShuler

request csrfParam

@SDKiller Got it, Thank you! You just saved me loads of time. I came across guides and examples, but they seem to be missing half the info. Maybe I will create a wiki to give back to the community.

A wiki article is a great idea.

I have made the wiki: [Guide] How to actually separate Frontend and Backend on Yii2 Advanced

Thanks! I've updated markup a bit so it now looks better with headers and color.

Looks like these changes (configuration) are not actual anymore, right? I ask because I simply installed the advanced template, and configured it to use different domains per frontend and backend (ex.: frontend.loc and backend.loc). And I am able to login/logout separately in both applications.

It has always been like that. Assumed have of frontend/backend is to have them on separate domains or subdomains. Ie: admin.yoursite.com for backend and just yoursite.com for frontend.
The special config is necessary if you need or want to run them on the same domain. Such as yoursite.com and yoursite.com/admin/
Even using yii2 as expected, meaning on separate sub domains without any extra config, you still won't have a separate admin table. Your admin accounts will share the same user table, which is frowned upon in regards to security. You would have a column like 'is_admin' or use the built in column for role and assign a number for admin users.. With users sharing the same column, an SQL injection could allow a user to switch the flag and convert their user account into an admin account. While an SQL injection is still possible with a separate admin table, it just makes it a little easier on them.
If you put every option on a point scale, sharing a user table for both is a few points itself for security risks.
So you would still need minor changes to create an admin model and to point to it in your config, for your backend.
Sent from my iPhone

On Dec 14, 2015, at 12:13 PM, cbepxpa3ym<EMAIL_ADDRESS>wrote:
Looks like these changes (configuration) are not actual anymore, right? I ask because I simply installed the advanced template, and configured it to use different domains per frontend and backend (ex.: frontend.loc and backend.loc). And I am able to login/logout separately in both applications.
—
Reply to this email directly or view it on GitHub.

I plan to use the advanced template to create a portal with this structure of domain/subdomain:
patient: somesite.com (search a doctor, signup/login into account to make and track appointments)
provider: provider.somesite.com (signup/login to manage doctors, appointments)
admin: admin.somesite.com (login to manage both patient and provider data)
Probably, frontend application will be used for patient, backend will be used for provider, and another one application "admin" will be created for admin. Or maybe even rename "frontend" into "patient", and "backend" into "provider". But this does not matter.
Also, I would like to have 3 tables (patient, provider, admin) and use them in authentication (the same as you suggested with user and admin).
Is not this too complicated?

No a few projects ago I had 3 areas. I just copied the frontend directory and named it "mainsite" and replaced all references to it. Each section is a separate app, they just all use the same framework files. Yii is actually stored in the vendor directory. You can run virtually unlimited apps or sites from the same Yii setup. Just copy frontend or backend and rename all references to them. I am not encouraging running multie sites off the same Yii setup. But you can run each section off the same site, members, admin, mainsite, portal.. However many you need. When you use composer to update Yii, all your sections are updated to the latest version and can share common models instead of having duplicate models for each section.
What your wanting to do is fine. You will just need to alter the config to use different user models pointing to the different tables.
Sent from my iPhone

On Dec 14, 2015, at 1:20 PM, cbepxpa3ym<EMAIL_ADDRESS>wrote:
I plan to use the advanced template to create a portal with this structure of domain/subdomain:
patient: somesite.com (search a doctor, signup/login into account to make and track appointments)
provider: provider.somesite.com (signup/login to manage doctors, appointments)
admin: admin.somesite.com (login to manage both patient and provider data)
Probably, frontend application will be used for patient, backend will be used for provider, and another one application "admin" will be created for admin. Or maybe even rename "frontend" into "patient", and "backend" into "provider". But this does not matter.
Also, I would like to have 3 tables (patient, provider, admin) and use them in authentication (the same as you suggested with user and admin).
Is not this too complicated?
—
Reply to this email directly or view it on GitHub.

I exactly want the same for backend Admin.php and for frontend user.php
I tried your settings but i got error to Array to string conversion in siteController actionLogin function to if ($model->load(Yii::$app->request->post()) && $model->login()).
Values are correctly posted. I checked it by using this Yii::$app->request->post()).
How to resolve this error array to string conversion error in actionLogin function

That depends on your model and form. I cannot guess what exacltly comes as array from your POST.
For example, you added extra brackets for input field and username comes as array.

You may check yii2tech/project-template for actual implementation.

This is an old thread, and since then I have pretty much mastered splitting the apps to handle separate user tables, and even handling sub-domains.
You can check out my repo on Github: Yii2 Members System
It already has frontend using the user table and User IdentityInterface, backend using the admin table and Admin IdentityInterface.
It also has support for sub-domains. It even has the UrlManager handled for linking to separate sub-domains (ie: site.com to sub.site.com) via a second UrlManager.
Install it and test it out. Then hack it up to suit your needs.


Bug with 2 warm-started optimizations

Hi,
I'm writing a ModelPredictiveControl (MPC) package based on JuMP.jl. The default solver is currently OSQP.jl. It is also possible to use my MPC package with DAQP.jl, thanks to your work and the JuMP.jl interface!
It seems that there is an issue with resolving a warm-started optimization problem. If I do:
using JuMP, DAQP
model = Model(DAQP.Optimizer)
@variable(model, -1<= x1 <=1)
@variable(model, -2<= x2 <=2)
@objective(model, Min, 0.5*(x1^2+x2^2)+x1+x2)
@constraint(model, c1, -3 <= x1 + x2 <= 3)
@constraint(model, c2, -4 <= x1 - x2 <= 4)
# one warm-started optimization : works well
set_start_value(x1, -0.5)
set_start_value(x2, -0.5)
optimize!(model); value.((x1, x2))

It returns as expected :
(-1.0, -1.0)

But if I do two optimizations:
using JuMP, DAQP
model = Model(DAQP.Optimizer)
@variable(model, -1<= x1 <=1)
@variable(model, -2<= x2 <=2)
@objective(model, Min, 0.5*(x1^2+x2^2)+x1+x2)
@constraint(model, c1, -3 <= x1 + x2 <= 3)
@constraint(model, c2, -4 <= x1 - x2 <= 4)
# one warm-started optimization : works well
set_start_value(x1, -0.5)
set_start_value(x2, -0.5)
optimize!(model)
# second warm-started optimization : crash with error
set_start_value(x1, -0.5)
set_start_value(x2, -0.5)
optimize!(model); value.((x1, x2))

it crashes with this error :
ERROR: MathOptInterface.UnsupportedAttribute{MathOptInterface.VariablePrimalStart}: Attribute MathOptInterface.VariablePrimalStart() is not supported by the model.

Hi Francis,
First of, nice work with the MPC package! :)
Thank you for reporting this error.
I have added support for VariablePrimalStart in #13. It will be merged into main when version 0.5.0 of DAQP_jll is available.
Although, since DAQP is a dual solver, a primal warm start cannot directly be used (it could indirectly be used by using it to get an estimation of the active set, which I might look into in the future). But at least there should be no error now!

@franckgaga there is  nothing in the solver itself that make a difference of "starting value" and "primal warm start". The original error that you found is more something related to the internals of JuMP: JuMP only seems to call "VariablePrimalStart" when you set the primal value to an optimizer that has been called once before (your original error was due to VariablePrimalStart not being defined in DAQP.jl) . The reason why VariablePrimalStart is only called in the second call is more a question for the JuMP developers;  my guess, however, is that there are situation when one wants to do something special when a warm start is given to an already optimized model (e.g., how internal factorizations in the solver should be modified to be reused etc).

Fixed in v0.5.0 (#13)

Strangely, the update seems to resolve the error with my MWE above, but not with my MPC package and I really don't understand why. If I use DAQPv0.5.0 with my package:
using ModelPredictiveControl, ControlSystemsBase, DAQP
mpc = LinMPC(LinModel(tf(2,[10, 1]), 0.1), optim=Model(DAQP.Optimizer))

and comment out the exception handling related to warm start in predictive_control.jl, that is :
set_start_value.(ΔŨvar, ΔŨ0)
set_objective!(mpc, ΔŨvar)
#try
optimize!(optim)
#catch err
#    if isa(err, MOI.UnsupportedAttribute{MOI.VariablePrimalStart})
#        # reset_optimizer to unset warm-start, set_start_value.(nothing) seems buggy
#        MOIU.reset_optimizer(optim)
#        optimize!(optim)
#    else
#        rethrow(err)
#    end
#end

and run this:
mpc = LinMPC(LinModel(tf(2,[10, 1]), 0.1), optim=Model(DAQP.Optimizer))
mpc([1]); mpc([1])

The error I get in the is a bit different :
ERROR: MathOptInterface.UnsupportedAttribute{MathOptInterface.VariablePrimalStart}: Attribute MathOptInterface.VariablePrimalStart() is not supported by the model.

Additionally, do you have any idea why set_start_value.(ΔŨvar, nothing) does not unset the starting values for DAQP (I still get a Attribute MathOptInterface.VariablePrimalStart() is not supported by the model error after) ? This is the official way to unset starting values in JuMP.jl. I think it would be cleaner to use this instead of MOIU.reset_optimizer(optim) in my exception handling (since we probably loose the factorization with reset_optimizer).
Thanks for the help!

I think it is because I forgot to add a MOI.support for VariablePrimalStart (still strange that it worked for MWE).
@franckgaga, could you check if the code on the branch v051 resolve this error on your end?

Sadly no, it does not seems to resolve the error.
If you want to reproduce, I also created the branch v062warm that exclude the exception handling related to warm start, if you want to reproduce on your side :
(@v1.9) pkg> add ModelPredictiveControl#v062warm

after installed, you can run:
using ModelPredictiveControl, ControlSystemsBase, JuMP, DAQP
mpc = LinMPC(LinModel(tf(2,[10, 1]), 0.1), optim=Model(DAQP.Optimizer))
mpc([1]); mpc([1])

and I get the same error as above.
Thanks !

@franckgaga The code v051 seems to be working on my end now with v062warm. If you can confirm that it works as expected on your end I will merge it into main and release v0.5.1 that includes it.

Yes it is also working on my side. Thanks for your time !


Fail validation if no contributor is set as a contact

@satra, @yarik, is this right?

that is correct. and i believe this happens on the pydantic side of validation.

Right, it's possible this issue is actually a no-op; I was expecting to see a "no contact" message set on this dandiset but it's not there, maybe because it's an earlier version of the schema.

i have a feeling this has other errors (like bad name format) that are superseding the contact person error.
the current release has this validation in place (and i suspect that's been there for a while)
https://github.com/dandi/dandischema/blob/3696446d225bf140273efcc90a908294f02b153e/dandischema/models.py#L963
just a note, that the contact person error would only be picked up by server side validation, not the jsonschema.

I think that the name had a bad format indeed, and we had some cryptic regex error. But at the end there was no contact person, so perhaps better error could help

I think that the name had a bad format indeed, and we had some cryptic regex error. But at the end there was no contact person, so perhaps better error could help

Not only that, but I believe both errors should show when there's no contact person set.
I would say this issue, as written, can be closed. But there's maybe a larger thing to accomplish here, which is that as many "parallel" errors as possible should show up when validation fails. I'll close this now, and if it needs to be worked on we can re-open. As for showing more errors, I think there's already some thinking about that happening so I'll leave it alone for the moment.


Feature/mm project footer

This branch will add a footer to all the pages in the project

Looks good! Merging!


Double mod crashes the game.

Having the same mod two times crashes the game. I think that is not good, better would be to either: Have them run parallel or skip the second.

Do you mean the same mod with the same name? Can you attach the file structure you have.
Please, always attach the log file.

I rechecked it its a little different: The game does not crash but it still seems the mods are not loaded correctly. Take a mod copy it leave it in the modfolder with a different name gives that error:
[= INFO =] Loading AutoSweeperMod, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=null
[= INFO =] Loading BuildingPatches, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=null
[= INFO =] Loading AutoSweeperMod, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=null
[= INFO =] Loading NuclearPowerMod, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=null
System.Reflection.TargetInvocationException: Exception has been thrown by the target of an invocation. ---> System.ArgumentException: element already exists
at System.Collections.Generic.SortedList2[System.String,ModLoader.DependencyGraph+Vertex].PutImpl (System.String key, ModLoader.Vertex value, Boolean overwrite) [0x00000] in <filename unknown>:0    at System.Collections.Generic.SortedList2[System.String,ModLoader.DependencyGraph+Vertex].Add (System.String key, ModLoader.Vertex value) [0x00000] in :0
at ModLoader.DependencyGraph.TopologicalSort () [0x00000] in :0
at ModLoader.ModLoader.Start () [0x00000] in :0
at (wrapper managed-to-native) System.Reflection.MonoMethod:InternalInvoke (object,object[],System.Exception&)
at System.Reflection.MonoMethod.Invoke (System.Object obj, BindingFlags invokeAttr, System.Reflection.Binder binder, System.Object[] parameters, System.Globalization.CultureInfo culture) [0x00000] in :0
--- End of inner exception stack trace ---
at System.Reflection.MonoMethod.Invoke (System.Object obj, BindingFlags invokeAttr, System.Reflection.Binder binder, System.Object[] parameters, System.Globalization.CultureInfo culture) [0x00000] in :0
at System.Reflection.MethodBase.Invoke (System.Object obj, System.Object[] parameters) [0x00000] in :0
at ModDB.StartModLoader () [0x00000] in :0
Failed to use ModLoader. Using built in mod system instead.

I've added a simple check to skip duplicate mods (same assembly name).
Find it here:
https://github.com/javisar/ONI-Modloader/blob/master/Managed/ModLoader.dll

@rainbowdesign could you check if it is already fixed?

got this now:
System.BadImageFormatException: Could not load file or assembly 'D:/Steam/steamapps/common/OxygenNotIncluded/OxygenNotIncluded_Data\Managed/ModLoader.dll' or one of its dependencies. An attempt was made to load a program with an incorrect format.
File name: 'D:/Steam/steamapps/common/OxygenNotIncluded/OxygenNotIncluded_Data\Managed/ModLoader.dll'
at (wrapper managed-to-native) System.Reflection.Assembly:LoadFrom (string,bool)
at System.Reflection.Assembly.LoadFrom (System.String assemblyFile, System.Security.Policy.Evidence securityEvidence) [0x00000] in :0
at System.Reflection.Assembly.LoadFile (System.String path, System.Security.Policy.Evidence securityEvidence) [0x00000] in :0
at System.Reflection.Assembly.LoadFile (System.String path) [0x00000] in :0
at ModDB.StartModLoader () [0x00000] in :0
Failed to use ModLoader. Using built in mod system instead.

Mmmm, pretty weird.
Can you download it again, it seems that you have a corrupted version of the file.
The file size is 11776 bytes.

I checked it again and i think it does work.


Fastnlight: Watch act892435

Fastnlight requests the watch of the watch_keyword act892435. See the MS search here and the Stack Exchange search in text, in URLs, and in code.

act892435 has been seen in 1 true positive, 0 false positives, and 0 NAAs.

Approved by Jeff Schaller in Charcoal HQ


Integrate new user signup with captcha in the app

@fredfalcon , can you please elaborate it. We have to integrate it with django auth or adding somethung else?

Yes, to signup from the app - we can use this https://pypi.org/project/django-rest-captcha/

Ohh thanks @fredfalcon .
Going to do it soon.
assign to me.

Do we need captcha? It is primarily for websites and is mostly used in web apps (also most plugins are for flutter web)

@just-ary27 it doesn’t seem to work.  I’m stuck on the screen with no message after pressing the button.

@fredfalcon if you're signing up for a new account, an email will be sent to your inbox for verification. (Just as on the website)

Can you add a message?  I did not get the email either. I used a real one in the previous test.

Logs are showing: Bad Request: /auth/registration/

Logs are showing: Bad Request: /auth/registration/

Please check now, it will explain the problem in your signup


Remove deprecated theme usage

In this PR:

Pass all needed theme colors  in colorScheme: ColorScheme.fromSwatch constructor
Replace deprecated text style usages with the recommended ones

Good one!


Add Pd singlet multiplicity

Add singlet Pd to a list of elements

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 57.96%. Comparing base (8e58b3c) to head (b6a8ee6).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #119      +/-   ##
==========================================
- Coverage   61.95%   57.96%   -4.00%
==========================================
  Files          37       37
  Lines        4235     4235
==========================================
- Hits         2624     2455     -169
- Misses       1611     1780     +169

Flag
Coverage Δ

python-3.9
57.96% <ø> (ø)

python-3.9-ace
?

python-3.9-mace
?

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Check that the elixirscript mix compiler works in umbrella apps

The ElixirScript mix compiler writes paths to files in the _build folder, reads those files to get the paths and then compiles files in those paths to JavaScript. Working with someone, notice that there was an error when trying to write the file in an umbrella app. Need to verify the error and then fix the compiler to work in umbrella projects

Added @recursive to mix compiler


Indexing ropes with Unicode characters is Wildly Broken

I was working on adding some QuickCheck property tests for Ropes, and I wrote two tests to ensure that Rope insert behaviour is equivalent to String insert behaviour.
Unfortunately, these tests revealed an unrelated issue: when QuickCheck generates a string containing Unicode characters, Rope's indexing operation in Rope.split() panics.
Here are a handful of the panics (it tried a lot of weird strings, so I'm only attaching the first couple):
---- test::properties::rope_insert_is_string_insert stdout ----
        thread 'test::properties::rope_insert_is_string_insert' panicked at 'index 0 and/or 9 in `¨T=/%�𞹧*jL~1ju츿瑞2⠇3*〗򸨋F+ຘ⁆숥G0𦏦𦏦^┏n䘧Y]c,”¥h䱤^‟굃…7‧[2�
                                                           &›몍% G=‑ªS񖤰A櫾2|򮁺|?(¢惐6򽑤 ‹` do not lie on character boundary', /Users/rustbuild/src/rust-buildbot/slave/nightly-dist-rustc-mac/build/src/libcore/str/mod.rs:1754
thread 'test::properties::rope_insert_is_string_insert' panicked at 'index 0 and/or 9 in `”¥h䱤^‟굃…7‧[2�
  &›몍% G=‑ªS񖤰A櫾2|򮁺|?(¢惐6򽑤 ‹` do not lie on character boundary', /Users/rustbuild/src/rust-buildbot/slave/nightly-dist-rustc-mac/build/src/libcore/str/mod.rs:1754
thread 'test::properties::rope_insert_is_string_insert' panicked at 'index 0 and/or 9 in `”¥h䱤^‟굃…7‧[2�
  &›몍% ‹` do not lie on character boundary', /Users/rustbuild/src/rust-buildbot/slave/nightly-dist-rustc-mac/build/src/libcore/str/mod.rs:1754
thread 'test::properties::rope_insert_is_string_insert' panicked at 'index 0 and/or 9 in `”¥h䱤^‟굃…7‧‹` do not lie on character boundary', /Users/rustbuild/src/rust-buildbot/slave/nightly-dist-rustc-mac/build/src/libcore/str/mod.rs:1754
thread 'test::properties::rope_insert_is_string_insert' panicked at 'index 0 and/or 9 in `^‟굃…7‧‹` do not lie on character boundary', /Users/rustbuild/src/rust-buildbot/slave/nightly-dist-rustc-mac/build/src/libcore/str/mod.rs:1754
thread 'test::properties::rope_insert_is_string_insert' panicked at 'index 0 and/or 9 in `…7‧‹` do not lie on character boundary', /Users/rustbuild/src/rust-buildbot/slave/nightly-dist-rustc-mac/build/src/libcore/str/mod.rs:1754
thread 'test::properties::rope_insert_is_string_insert' panicked at 'index 0 and/or 9 in `ဓ7‧‹` do not lie on character boundary', /Users/rustbuild/src/rust-buildbot/slave/nightly-dist-rustc-mac/build/src/libcore/str/mod.rs:1754
thread 'test::properties::rope_insert_is_string_insert' panicked at 'index 0 and/or 9 in `ࠊ7‧‹` do not lie on character boundary', /Users/rustbuild/src/rust-buildbot/slave/nightly-dist-rustc-mac/build/src/libcore/str/mod.rs:1754
thread 'test::properties::rope_insert_is_string_insert' panicked at 'index 0 and/or 9 in `ࠂ7‧‹` do not lie on character boundary', /Users/rustbuild/src/rust-buildbot/slave/nightly-dist-rustc-mac/build/src/libcore/str/mod.rs:1754
thread 'test::properties::rope_insert_is_string_insert' panicked at 'index 0 and/or 9 in `ࠀ7‧‹` do not lie on character boundary', /Users/rustbuild/src/rust-buildbot/slave/nightly-dist-rustc-mac/build/src/libcore/str/mod.rs:1754
thread 'test::properties::rope_insert_is_string_insert' panicked at 'index 0 and/or 9 in `ࠀ‧‹` do not lie on character boundary', /Users/rustbuild/src/rust-buildbot/slave/nightly-dist-rustc-mac/build/src/libcore/str/mod.rs:1754
thread 'test::properties::rope_insert_is_string_insert' panicked at 'index 0 and/or 9 in `ࠀန‹` do not lie on character boundary', /Users/rustbuild/src/rust-buildbot/slave/nightly-dist-rustc-mac/build/src/libcore/str/mod.rs:1754
thread 'test::properties::rope_insert_is_string_insert' panicked at 'index 0 and/or 9 in `ࠀࠊ‹` do not lie on character boundary', /Users/rustbuild/src/rust-buildbot/slave/nightly-dist-rustc-mac/build/src/libcore/str/mod.rs:1754
thread 'test::properties::rope_insert_is_string_insert' panicked at 'index 0 and/or 9 in `ࠀࠂ‹` do not lie on character boundary', /Users/rustbuild/src/rust-buildbot/slave/nightly-dist-rustc-mac/build/src/libcore/str/mod.rs:1754
thread 'test::properties::rope_insert_is_string_insert' panicked at 'index 0 and/or 9 in `ࠀࠀ‹` do not lie on character boundary', /Users/rustbuild/src/rust-buildbot/slave/nightly-dist-rustc-mac/build/src/libcore/str/mod.rs:1754
thread 'test::properties::rope_insert_is_string_insert' panicked at 'index 0 and/or 9 in `ࠀࠀဝ` do not lie on character boundary', /Users/rustbuild/src/rust-buildbot/slave/nightly-dist-rustc-mac/build/src/libcore/str/mod.rs:1754
thread 'test::properties::rope_insert_is_string_insert' panicked at 'index 0 and/or 9 in `ࠀࠀࠏ` do not lie on character boundary', /Users/rustbuild/src/rust-buildbot/slave/nightly-dist-rustc-mac/build/src/libcore/str/mod.rs:1754
thread 'test::properties::rope_insert_is_string_insert' panicked at 'index 0 and/or 9 in `ࠀࠀࠇ` do not lie on character boundary', /Users/rustbuild/src/rust-buildbot/slave/nightly-dist-rustc-mac/build/src/libcore/str/mod.rs:1754
thread 'test::properties::rope_insert_is_string_insert' panicked at 'index 0 and/or 9 in `ࠀࠀࠃ` do not lie on character boundary', /Users/rustbuild/src/rust-buildbot/slave/nightly-dist-rustc-mac/build/src/libc

Obviously we are not currently handling grapheme indices properly.

Failing tests are added to the the fix-unicode-indexing branch at 1507e30fc301d62d208ee7ff18fcac0c7bccfe18

Failing tests are added to the the fix-unicode-indexing branch at 1507e30fc301d62d208ee7ff18fcac0c7bccfe18


Core: Add timestamp to entities

Add timestamp to track entity creation and update in a uniform manner as in #1350.
See also #1364
Originally posted by @ndr-brt in https://github.com/eclipse-dataspaceconnector/DataSpaceConnector/pull/1350#pullrequestreview-988906511

@algattik can i still work on this issue? I can take a look at it.

@diegogomez-zf this issue will touch on code at the very core of EDC, so it is important to have a written technical proposal before writing any code.
Please provide this proposal as separate PR in the form of a decision record document (cf.
docs/developer/decision-records). It should include at least the following sections:

Decision: what is done
Rationale: why it is done
Approach: how it is going to be implemented

Please also outline what extensions this is going to impact, and how.

will work on this


Move Azure CLI to generic AI event names (such as azure-cli/command-invoke)

In support of our GDPR efforts and requirements, we need to move to generic AI event names.

This is done as of today. However, the interactive shell is being refitted to send telemetry to the main source. It will likely introduce a new event name azurecli/interactive. If you have any other idea, please suggest. @williexu

Done


variable or sub redefinition does not produce an error

variable or sub or function redefinition should produce an error, but does not.
When fixed, we can enable the two skipped tests here:
https://github.com/juttle/juttle/blob/master/test/runtime/basic-language.spec.js

This is slightly more general problem —beside subs it also concerns reducers and functions. Any of these can redefine a symbol of any type. Redefining any symbol by a const or a variable produces the expected result (an error).
Updating the title accordingly.


Fix forever

This fixes that forever blocks without a continue statement would not actually loop.
:warning: This is a breaking change, but also a bugfix, since this was never supposed to be the behaviour.
Example:
print("before loop");
forever {
    print("in loop");
}
print("after loop");

Assuming print is a function that prints the const string, this would print before:
before loop
in loop
after loop

It will now print:
before loop
in loop
in loop
in loop

The last line repeats indefinitely.
:information_source: This does not change the fact that the decompiler will still add continue statements to forevers, even if they may seem redundant.

I find this example a bit confusing. You say it wouldn't loop without continue;, which implies it would loop if continue; is present. But then you show an example that does have continue; and say that wouldn't have looped before?

Whoops, I removed it. I had that in there while testing. There isn't supposed to be a continue in the example.

Whoops, I removed it. I had that in there while testing. There isn't supposed to be a continue in the example.

Oh, there we go. It makes sense now.

This does not change the fact that the decompiler will still add continue statements to forevers, even if they may seem redundant.

Why is this btw? Aren't they unnecessary now?

No. The reason they were added had nothing to do with this bug, except for the fact that they kinda hid it.
I need to reexamine if this is true, but according to the TODO comment in the decompiler, there is no reliable way in the optimization phase to know if the place where the dummy continues are inserted are really going to be the last statement in hhe generated ExplorerScript code and would actually cause a loop.
I don't know anymore why that would be, in theory no matter how the code ends up being generated it should match the graph and thus always be effectively the last statement, so it should loop even without a continue. I'll do some testing.

Yeah basically there is no way to know if the marker that generates continues is actually required (a real continue) or not because it was auto-inserted by previous steps in the decompliation. It might be possible to mark these somehow.


About ins_labels

Thank you open you code!
dataloader -> dataset.py line 79:
"ins_labels = annotated_data" should be changed to "ins_labels = annotated_data >> 16"?

Thanks for the question.
No. You should not change that. If I remember it correctly, the definition of instance label is semantic label + id. The id is counted from zero for each semantic classes.
Therefore, if you change to annotated_data >> 16, there is chance that in the same scene two different instances with different semantic classes share same ins_label.
You can check that easily by yourself. Correct me if I am wrong. Thanks a lot.


sponsor section Flexible Layout

Issue #641

Current coverage is 45.99% (diff: 35.71%)

Merging #642 into development will decrease coverage by 0.21%

@@           development       #642   diff @@
=============================================
  Files                6          6
  Lines              580        587     +7
  Methods             58         58
  Messages             0          0
  Branches            98        101     +3
=============================================
+ Hits               268        270     +2
- Misses             312        317     +5
  Partials             0          0

Powered by Codecov. Last update cf74c27...f887ead

This is not needed as per discussing  #641 Closing this


Updates to libraries with security warnings.

Upgrade org.apache.commons:commons-compress to version 1.18 or later.
Upgrade org.apache.activemq:activemq-client to version 5.15.16 or later.

"activemq - client to version 5.15.16 or later" is a mistake of Github?
Correctly it is "5.15.6 or later".


RANGER-3459: Upgrade Kafka dependency to 2.8

Co-authored-by: Andras Katona<EMAIL_ADDRESS>

submitted


Refactored AbstractAddress::__toString

Extended the unit tests for AbstractAddress::__toString()
Enhanced readability for method

Removed strange str_replace
Removed strange $check

Results in faster method and clearer code.
Successor of #566 because rebased on master.

Thank you @sbani !

any updates here?

Hi @sbani
I will be merging pull requests this week. Thank you for your patience!

thank you too @mkudelya

I have merged this PR to the master branch. Thank you!


The link to Level 3 communications is not valid on the ExpressRoutes page

The link to Level 3 Communications on the following page redirects to a 404
https://docs.microsoft.com/en-us/azure/expressroute/expressroute-locations
The link presents a page with the following text:
Site Not Found.

A problem occurred when we tried to retrieve your information.

Please make sure the entire link has been used in your browser, including the unique tags.

If you continue to experience problems, please reply to the email you received.

We apologize for this inconvenience.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: a00024b9-36f7-c9a8-4277-9360b0cd6163
Version Independent ID: aa65d869-db72-c0d8-a7e1-75a4949b6bbc
Content: Connectivity providers and locations: Azure ExpressRoute
Content Source: articles/expressroute/expressroute-locations.md
Service: expressroute
GitHub Login: @cherylmc
Microsoft Alias: cherylmc

@shanimsa Thanks for the feedback! I have assigned the issue to the content author to evaluate and update as appropriate.

CenturyLink did acquire Level3 a few years back, perhaps the links may have changed to CenturyLink assets since then.

#reassign:charwen

@shanimsa Thank you for letting us know. I have updated the link and it now points to the Lumen website (previously CenturyLink).
#please-close


Added Teeworlds Mod Server Template

Added Teeworlds Mod Server Template to install any teeworlds server.

Since exec is a program, I actually wonder if using that as the program, then having the first arg being the executable would work.

v1 will no longer accept new templates. If you wish to re-open this with v2, we'll be glad to look at it again.


App crashes on starting in Android - SoLoader - base.apk problem

Environment
Environment:
OS: macOS High Sierra 10.13.5
Node: 9.11.1
Yarn: 1.7.0
npm: 6.1.0
Watchman: 4.9.0
Xcode: Xcode 9.4.1 Build version 9F2000
Android Studio: 3.1 AI-173.4819257
Packages: (wanted => installed)
react: 16.3.0-alpha.3 => 16.3.0-alpha.3
react-native: 0.54.2 => 0.54.2
Description
The app build successfully in debug and release in android but crashes on starting.
E/AndroidRuntime: FATAL EXCEPTION: Thread-2
Process: com.hys, PID: 23200
java.lang.NoSuchMethodError: No static method loadLibrary(Ljava/lang/String;)V in class Lcom/facebook/soloader/SoLoader; or its super classes (declaration of ‘com.facebook.soloader.SoLoader’ appears in /data/app/com.hys-vH4Q2uE5DrP5sdxI8aPjcA==/base.apk)
at com.facebook.react.bridge.ReactBridge.staticInit(ReactBridge.java:20)
at com.facebook.react.bridge.NativeMap.(NativeMap.java:21)
at com.facebook.react.bridge.JSCJavaScriptExecutorFactory.create(JSCJavaScriptExecutorFactory.java:23)
at com.facebook.react.ReactInstanceManager$5.run(ReactInstanceManager.java:921)
at java.lang.Thread.run(Thread.java:764)
Complete stacktrace
--------- beginning of system
07-17 11:25:36.184 1655-31322/system_process I/ActivityManager: Force stopping com.hys appid=10105 user=0: from pid 26681
07-17 11:25:36.198 1882-1882/com.android.phone D/CarrierSvcBindHelper: No carrier app for: 0
07-17 11:25:36.273 1655-4537/system_process I/ActivityManager: START u0 {act=android.intent.action.MAIN cat=[android.intent.category.LAUNCHER] flg=0x10000000 cmp=com.hys/.MainActivity} from uid 2000
07-17 11:25:36.341 1655-4241/system_process I/ActivityManager: Start proc 26689:com.hys/u0a105 for activity com.hys/.MainActivity
07-17 11:25:36.342 1430-1960/? D/gralloc_ranchu: gralloc_alloc: Creating ashmem region of size 8298496
07-17 11:25:36.351 26689-26689/? I/zygote: Not late-enabling -Xcheck:jni (already on)
07-17 11:25:36.379 26689-26689/? W/zygote: Unexpected CPU variant for X86 using defaults: x86
07-17 11:25:36.449 2154-2589/com.google.android.googlequicksearchbox:search D/EGL_emulation: eglMakeCurrent: 0xceb3e620: ver 3 0 (tinfo 0xe6528400)
07-17 11:25:36.461 2248-2344/com.google.android.apps.nexuslauncher D/EGL_emulation: eglMakeCurrent: 0xd27149e0: ver 3 0 (tinfo 0xd2716670)
07-17 11:25:36.506 26689-26689/com.hys D/SoLoader: init start
adding system library source: /vendor/lib
07-17 11:25:36.508 26689-26689/com.hys D/SoLoader: adding system library source: /system/lib
07-17 11:25:36.509 26689-26689/com.hys D/SoLoader: adding application source: com.facebook.soloader.DirectorySoSource[root = /data/app/com.hys-_iLposT_b1mZkkXDfAhdyw==/lib/x86 flags = 0]
07-17 11:25:36.515 26689-26689/com.hys D/SoLoader: adding backup  source: com.facebook.soloader.ApkSoSource[root = /data/data/com.hys/lib-main flags = 1]
07-17 11:25:36.518 26689-26689/com.hys D/SoLoader: Preparing SO source: com.facebook.soloader.DirectorySoSource[root = /system/lib flags = 2]
07-17 11:25:36.520 26689-26689/com.hys D/SoLoader: Preparing SO source: com.facebook.soloader.DirectorySoSource[root = /vendor/lib flags = 2]
Preparing SO source: com.facebook.soloader.DirectorySoSource[root = /data/app/com.hys-_iLposT_b1mZkkXDfAhdyw==/lib/x86 flags = 0]
07-17 11:25:36.521 26689-26689/com.hys D/SoLoader: Preparing SO source: com.facebook.soloader.ApkSoSource[root = /data/data/com.hys/lib-main flags = 1]
07-17 11:25:36.525 26674-26674/? D/AndroidRuntime: >>>>>> START com.android.internal.os.RuntimeInit uid 2000 <<<<<<
07-17 11:25:36.531 26689-26689/com.hys V/fb-UnpackingSoSource: locked dso store /data/user/0/com.hys/lib-main
07-17 11:25:36.542 26689-26689/com.hys I/fb-UnpackingSoSource: dso store is up-to-date: /data/user/0/com.hys/lib-main
07-17 11:25:36.542 26689-26689/com.hys V/fb-UnpackingSoSource: releasing dso store lock for /data/user/0/com.hys/lib-main
07-17 11:25:36.542 26689-26689/com.hys D/SoLoader: init finish: 4 SO sources prepared
07-17 11:25:36.543 26689-26689/com.hys D/SoLoader: init exiting
07-17 11:25:36.583 26689-26689/com.hys D/ReactNative: ReactInstanceManager.ctor()
07-17 11:25:36.584 26689-26689/com.hys D/SoLoader: init exiting
07-17 11:25:36.605 26689-26689/com.hys D/NetworkSecurityConfig: No Network Security Config specified, using platform default
07-17 11:25:36.624 26674-26674/? W/app_process: Unexpected CPU variant for X86 using defaults: x86
07-17 11:25:36.626 26674-26674/? I/app_process: The ClassLoaderContext is a special shared library.
07-17 11:25:36.660 26689-26689/com.hys D/ReactNative: ReactInstanceManager.createReactContextInBackground()
ReactInstanceManager.recreateReactContextInBackgroundInner()
07-17 11:25:36.662 26689-26689/com.hys D/ReactNative: ReactInstanceManager.onJSBundleLoadedFromServer()
07-17 11:25:36.663 26674-26674/? D/AndroidRuntime: Calling main entry com.android.commands.wm.Wm
07-17 11:25:36.663 26689-26689/com.hys D/ReactNative: ReactInstanceManager.recreateReactContextInBackground()
ReactInstanceManager.runCreateReactContextOnNewThread()
07-17 11:25:36.664 1655-25572/system_process W/WindowManager: Permission Denial: dismissKeyguard from pid=26674, uid=2000 requires android.permission.CONTROL_KEYGUARD
07-17 11:25:36.665 26674-26674/? D/AndroidRuntime: Shutting down VM
--------- beginning of crash

07-17 11:25:36.670 26689-26717/com.hys E/AndroidRuntime: FATAL EXCEPTION: Thread-2
Process: com.hys, PID: 26689
java.lang.NoSuchMethodError: No static method loadLibrary(Ljava/lang/String;)V in class Lcom/facebook/soloader/SoLoader; or its super classes (declaration of 'com.facebook.soloader.SoLoader' appears in /data/app/com.hys-_iLposT_b1mZkkXDfAhdyw==/base.apk)
at com.facebook.react.bridge.ReactBridge.staticInit(ReactBridge.java:20)
at com.facebook.react.bridge.NativeMap.(NativeMap.java:21)
at com.facebook.react.bridge.JSCJavaScriptExecutorFactory.create(JSCJavaScriptExecutorFactory.java:23)
at com.facebook.react.ReactInstanceManager$5.run(ReactInstanceManager.java:921)
at java.lang.Thread.run(Thread.java:764)
07-17 11:25:36.677 1655-25572/system_process W/ActivityManager:   Force finishing activity com.hys/.MainActivity
07-17 11:25:36.691 26689-26718/com.hys W/unknown:InspectorPackagerConnection: Couldn't connect to packager, will silently retry

I have the same issue! Today happn to me for the first time. Even tried to revert but still getting this.

Yo
Happening here too
check this thread out
https://github.com/facebook/SoLoader/issues/13

@Gadigg we already there. Let's see if we get a solution

Same issue here too it stated to happen from today.
App crashes on starting with following log.
java.lang.NoSuchMethodError: No static method loadLibrary(Ljava/lang/String;)V in class Lcom/facebook/soloader/SoLoader; or its super classes (declaration of 'com.facebook.soloader.SoLoader' appears in /data/app/mx.com.project-1/base.apk)         at com.facebook.react.bridge.ReactBridge.staticInit(ReactBridge.java:18)         at com.facebook.react.bridge.NativeMap.<clinit>(NativeMap.java:19)         at com.facebook.react.bridge.JSCJavaScriptExecutorFactory.create(JSCJavaScriptExecutorFactory.java:21)         at com.facebook.react.ReactInstanceManager$5.run(ReactInstanceManager.java:912)         at java.lang.Thread.run(Thread.java:818)

Same with me, anyone have a solution?

Same issue here, am running old build atm in order to continue development

@Convict3d what configuration do you run in order to make it work? What is your react version? React native version?

I use fresco in my app to display gifs. Are you using  this too?
This might be one potential reason.

@Convict3d Is this something related to SDK and BuildTools ?
I am using
"react": "16.3.1",
"react-native": "0.55.3",
compileSdkVersion 26
buildToolsVersion '27.0.3'
Issue is still there.

@cristianonescu yes am using fresco too for some loading animation, its the only thing that changed with gradle output when the app crashed.

@cristianonescu @Convict3d Im also using this  fresco for animated gif this might be the reason let me remove this and try

@anuruddhadinesh I believe it's caused by fresco, I'll check when am at office

I tried this right now. Still crashes. Nothing changed, I get the same error.

Hi All
I just removed fresco from gradle and tried yes it worked. This is the reasoin for the creash. if you gus can confirm then we can close this bug.

I confirm it is caused by fresco, removed them dependencies from app/build.gradle deleted app/build folder and rebuilt, the app is running fine. I believe we can avoid crashing by identifying a specific version for fresco. Gonna try and report back.

Guys, please try fresco 1.3.0 i am not able to test with it now. I'm on my way to the office.
1.3.0 fresco might be the solution to this

According to Maven Repository  facebook.fresco:fresco and facebook.fresco:animated-gif v 1.10.0 were released 2 days ago, I can confirm it is what causing the issue.

#20242

implementation 'com.facebook.fresco:fresco:1.9.0'
implementation 'com.facebook.fresco:animated-gif:1.9.0'
// IN CASE YOU NEED WEBP SUPPORT / MAKE SURE TO CHANGE THIS TOO TO 1.9.0
implementation 'com.facebook.fresco:animated-webp:1.9.0'
implementation 'com.facebook.fresco:webpsupport:1.9.0'

@cristianonescu  thanks! it works

thanks @cristianonescu , now works


adjust steak min temp

About the PR

I googled "minimum internal temperature for (closest animal)" and then rounded to the nearest 5 degrees kelvin
Media

[x] I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Changelog

:cl: Rane

tweak: Steaks have to be cooked to something closer to their actual minimum internal temp rather than a hot summer day.

yea ididnt process that it was so low tbh


Extract Zarr reader into its own package

I would love to be able to install NeuralGCM’s Zarr/tfds reader as its own python package.
https://github.com/google-research/neuralgcm/blob/d32e8b6365bd6096a76b531a14df1a27723d5e2c/neuralgcm/reference_code/reader.py#L378
It would be nice to see how this compares to xbatcher in benchmarks. I’d also like to see how well it would work with tile-serving-backed Xarray datasets, like data via Xee.

Yes, I would love this! This would definitely make sense on its own project, I will see if I can finish up the open source launch :)


Request is immutable but provides no way to use middleware to do the equivalent of set a thread local.

Obviously thread locals are useless (and dangerous in general). But it would be nice to be able to add some extra context to a request with middleware. It's hard to do now because of the slots restriction. Surely we could have the performance AND flexibility by adding some sort of context attribute to a request?

Ah I just noticed request is a dict. It's not clear that that's used for.. I guess I could use it like that?

Been using it like that for a while. The way I see it, that's the only way to enrich requests through middleware.
In any case, let's close this for now?

Agreed


InMemoryDirectoryInfo doesn't work if rootDir has trailing slash

Describe the bug
InMemoryDirectoryInfo won't match if rootDir parameter ends with a slash
To Reproduce
Steps to reproduce the behavior:

Using version '...' of package '...'
Latest (2.2.0)

Run this code '....'

var curDir = @"C:\GlobTest\";
var files = Directory.EnumerateFiles(curDir, "*.config", SearchOption.AllDirectories);
InMemoryDirectoryInfo dirInfo = new InMemoryDirectoryInfo(curDir, files);

var results = new Matcher()
    .AddInclude("**/*.config")
    .Execute(dirInfo);

// Expect: results.Files.Count() > 0

With these arguments '....'
See error

Expected behavior
Provided *.config files exist in C:\GlobTest, those files should be returned.
If you change the first line to:
var curDir = @"C:\GlobTest";

Then everything works.  Note, this behavior is the same regardless of whether you pass in **/*.config or /**/*.config as an include.
Screenshots
If applicable, add screenshots to help explain your problem.
Additional context
Add any other context about the problem here.
Include the output of dotnet --info

I don't think this has anything to do with config, I think this is an issue in filesystems in the InMemoryDirectoryInfo class probably...  https://github.com/aspnet/Extensions/tree/master/src/FileSystemGlobbing


Arrays of globs with negation

Currently, tiny-glob takes a single glob string.
It would be nice if it could also take an array of glob strings, where negations apply to previous items in the array.
For example, given the files:
src/foo.js
src/bar.js
src/test/baz.js

then the invocation:
await glob([
  'src/**/*.js',
  '!test'
]);

would return:
src/foo.js
src/bar.js

This syntax is supported by fast-glob (ref), and is common in applications such as .gitignore files, and the package.json files array.

For further reference, the glob library does not support arrays of globs, and NPM implements the behavior described above by doing its own transformation of the globs and the glob results: https://github.com/npm/npm-packlist/blob/f56a4cf77fbbb123f3c818777cf00555538e1c1c/lib/index.js#L224


Add level switch

Motivation
Added a level-switch that redirects to a 2nd level.

played through both levels - works perfectly for me!


Inconsistent NEOFS_NETWORK_DOMAIN parameter

Current Behavior
NEOFS_NETWORK_DOMAIN is about some domain, previously we've used it as a generic top-level domain and workflow automatically added stX to it. Now it's a node address effectively which is OK (allows to use private nodes, for example), but it's somewhat misleading in its name and also missing any ability to specify port. It's also unobvious if it supports scheme specification (grpcs://, anyone?).
Expected Behavior
Have some NEOFS_NODE or NEOFS_ENDPOINT parameter that accepts a simple string that is used for RPC endpoint.
Possible Solution
Will require 0.2.0 since it's a breaking change (but we can think of some deprecation/compat in 0.1.3).

We also have a problem of port specification. Nothing but 8080 is supported at the moment.


Create an openapi 3.0.0 spec

For our use case, it made sense to create an openapi 3.0.0 spec to autogenerate a typescript client.  This spec is based on the current rest interface.
We would like to contribute back to the community for others.

As an update, we create an open-source python client to submit flink sql jobs.  This client also has support jupyter magic syntax:
https://gitlab.com/belvederetrading/public/flink_sql_python_client


Different getUniqueID in different RN versions on Android

I have app in React Native 0.58.4 and installed "react-native-device-info": "^0.26.4". When i use DeviceInfo.getUniqueID() in my Android 8 Oreo device i get result 8f80d1805723de81.
Now i decided to upgrade my project to React Native 0.61.2 and install "react-native-device-info": "^5.0.1". So i init new project in new folder, replace App/ folder from old project, install libs, etc. I noticed that getUniqueID()method now changed to getUniqueId(). And now when i use DeviceInfo.getUniqueId() i have different id: c09cfee05a0af6e0.
I have tried to install "react-native-device-info": "^0.26.4" to new project, and changed options in app/build.gradle but none help:
    We have 3 options for deviceId:
    //Option 1 (latest):
    firebaseIidVersion = "19.0.1" // default: "19.0.1"
    //Option 2 (legacy GooglePlay dependency but using AndroidX):
    googlePlayServicesIidVersion = "17.0.0" // default: "17.0.0" - AndroidX
    //Option 3 (legacy GooglePlay dependency before AndroidX):
    googlePlayServicesIidVersion = "16.0.1"

How to get my old id in the new version of React Native?

I don't think this is a device-info issue - I think this has more to do with how the unique ids work - examine the docs for the underlying ID and see if you fall in a case where it may have changed https://developer.android.com/reference/android/provider/Settings.Secure.html#ANDROID_ID

Thanks, I read that link to the holes, nothing fits my case, I create new blank projects on RN 0.58.4 and RN 0.61.2, I run on the same Pixel 2 android 9.0 - different IDs. Maybe that problem in React Native.

Hmm - no it wouldn't be react-native, they don't touch the id - I think the only way you would get the same id is if you created a blank project with the old version, installed it, then (this is important) updated that project and installed the update without removing the previous version - I think if you remove a bundle id from a phone, it gets a new id on install. I'm going from memory though - I read the docs closely before but it's been a while

TL;DR: after fresh init in RN 0.61.2 folder android/app now contain file debug.keystore, which is not presented in old RN 058.2. So i replaced debug.keystore with release.keysore. And now i get right Android ID.

Ok - so it doesn't seem to be a bug then - more a very subtle interaction between parts / project setup. If there's anything specific we could put in the docs that could help I'd be open to a PR, but it sounds like as long as your keystore is the same (i.e., you sign the app the same) then you'll maintain ID continuity?

Not worth it, closed.


Allow the grid to be hidden

It's ruining my screenshots.
Great tool BTW.

This is not a tool for screenshots. To render the diagram into a image, use tikz and the standalone LaTeX package.


Check issue milestone for null.

:tada: This PR is included in version 2.0.0 :tada:
The release is available on:

2.0.0
GitHub release

Your semantic-release bot :package::rocket:


Added options to set username and password when using Subversion as SCM

Add :svn_username and/or :svn_password to the deplyment file if Subversion needs authentication

Thanks for this, I don't use SVN, haven't touched it for about 6/7 years, so I'll get around to testing it sooner or later, I have to check this doesn't break any of our test suite (which travis can't/won't run)

Have had a look at the tests and noticed the SVN test suite was failing because of the new arguments passed to the functions. I have fixed the test suite and now all the SVN tests pass.

Thanks @dsthode

So the last thing is to point you at the CONTRIBUTING file, especially the part where you add yourself to the CHANGELOG so that you are credited in the way you prefer.

Hi @leehambley already did add myself to the CHANGELOG file, thanks!

Sorry missed that in your commits - my mistake!

@leehambley I'm a bit surprised to see this patch hasn't made its way into a stable release yet. I'll use master for now, but when is a new release of v3 planned?

I have no way to test a lot of the new stuff, so I've been stalling. Let me
know how master works for you!
On 7 Dec 2015 11:29 a.m., "marcovtwout"<EMAIL_ADDRESS>wrote:

@leehambley https://github.com/leehambley I'm a bit surprised to see
this patch hasn't made its way into a stable release yet. I'll use master
for now, but when is a new release of v3 planned?
—
Reply to this email directly or view it on GitHub
https://github.com/capistrano/capistrano/pull/1402#issuecomment-162476764
.

Using master and putting svn_username and svn_password works as expected.
Additional question: can I also pass these as arguments when running cap deploy?

Read them from ENV in your setup script ?

@leehambley I can also confirm that this both resolves the issue of needing to supply credentials for Subversion.

:+1:

@leehambley Have you planned a release date yet? What other stuff do you need to test?

No planned release date, no time to do a real test of any kind. Sorry, watch this space.


add new gallery picture

Hi @lj2000
very neat front plate. Did you post the picture and links in the gitHub thread?
https://github.com/MiczFlor/RPi-Jukebox-RFID/issues/5
That would be awesome. I haven't updated the gallery in the wiki for a long time. Will do that soon. True: the boxes there are veeeery first generation.
I will close this pull request and manually add the picture and link.
All the best, micz


Measure changes in overall page size

e.g. the change to de-duplicate <style> tags in https://github.com/alexwlchan/alexwlchan.net/pull/852 should have reduced the weight of a bunch of pages, not just the new post I was working on – it’d be nice to get overall page size stats.

Although I'm not doing it in GitHub Actions yet, here's a script I wrote to do it on a one-off basis:
#!/usr/bin/env python3

import pathlib
import humanize

def get_file_paths_under(root=".", *, suffix=""):
    """
    Generates the absolute paths to every matching file under ``root``.
    """
    root = pathlib.Path(root)

    if root.exists() and not root.is_dir():
        raise ValueError(f"Cannot find files under file: {root!r}")

    if not root.is_dir():
        raise FileNotFoundError(root)

    for dirpath, _, filenames in root.walk():
        for f in filenames:
            p = dirpath / f

            if p.is_file() and f.lower().endswith(suffix):
                yield p

sizes = []

for p in get_file_paths_under("_site", suffix=".html"):
    if "/files/" in str(p):
        continue
    sizes.append(p.stat().st_size)

print(sum(sizes) / len(sizes))

print(humanize.naturalsize(sum(sizes) / len(sizes)))


Use %q{...} instead of "..." for eslint config comment

This prevents us from having to escape all of the double quotes, which
makes this line a bit easier to read and work with.

I fixed merge conflicts and added another commit on top

Cool, thanks for the cleanup!


Update localization [04/22/24]

This PR updates localization for the following tasks:

Common/VstsAzureHelpers_

Checklist:

[x] Task version was bumped - please check instruction how to do it
[x] Checked that applied changes work as expected

/azp run


Redstone Controls for Item Magnet

Re: https://twitter.com/danielhickman9/status/828181624688816134

I made it turn off when you send it a redstone signal, since its been out for a while and people are used to it just working without power

Totally understandable. Cool.

https://minecraft.curseforge.com/projects/cyclic/files/2378420


Handling of x-amz-date in HmacV1Auth

According to the spec http://docs.aws.amazon.com/AmazonS3/latest/dev/RESTAuthentication.html, section "Time Stamp Requirement", and "Example delete" below, it should be possible to override date header with x-amz-date, and in this case x-amz-date should not be included into the string to sign. boto does handle this correctly, but botocore includes both date value and x-amz-date header into string to sign:
DELETE

Tue, 27 Mar 2007 21:20:26 +0000
x-amz-date:Tue, 27 Mar 2007 21:20:26 +0000
/johnsmith/photos/puppy.jpg

Is it intended? This is not something affecting me, just noticed it while porting tests from boto to botocore.

The section of documentation you linked pertains specifically to generating pre-signed S3 posts, not general signing. In the pre-signed case, the date header is not signed, but x-amz-date is included as part of the policy, which is signed.
That said, it shouldn't be including both x-amz-date and Date. Could you provide a code snippet to replicate that output?

Thanks for the clarification!
This is what I meant - both dates are included here:
$ python test_s3_sign.py
DEBUG:botocore.auth:Calculating signature using hmacv1 auth.
DEBUG:botocore.auth:HTTP request method: GET
DEBUG:botocore.auth:StringToSign:
GET

Tue, 16 Feb 2016 06:05:20 GMT
x-amz-date:Tue, 27 Mar 2007 21:20:26 +0000
/bucket/path

And here is the code:
import logging
logging.basicConfig(level=logging.DEBUG)

import botocore.auth
import botocore.credentials
import botocore.awsrequest

# keys from AWS examples
AWS_ACCESS_KEY_ID = '0PN5J17HBGZHT7JJ3X82'
AWS_SECRET_ACCESS_KEY = 'uV3F3YluFJax1cknvbcGwgjvx4QpvB+leU8dUj2o'

SignerCls = botocore.auth.AUTH_TYPE_MAPS['s3']
signer = SignerCls(botocore.credentials.Credentials(
    AWS_ACCESS_KEY_ID, AWS_SECRET_ACCESS_KEY))

awsrequest = botocore.awsrequest.AWSRequest(
    method='GET',
    url='http://s3.amazonaws.com/bucket/path',
    headers={'x-amz-date': 'Tue, 27 Mar 2007 21:20:26 +0000'})
signer.add_auth(awsrequest)

Ah, I see. x-amz-date exists for clients where the Date header cannot be set. We are able to set the Date header, so we don't attempt to use x-amz-date. We could account for it in the signer, but since the auth, signer, and awsrequest packages are not intended to be used outside of botocore, it would probably not be user modifiable. We only support function calls from within the client interface.

I see, thanks!
Btw, what interface would you recommend to use for external libraries what are making requests to S3 themselves (for example, in scrapy we currently use twisted), and are using botocore just to calculate the correct signature?


Generate master sidecar template for all EEG dataset in STUDY for EEGLAB

I know we have functionality in Python for BIDS directory. Can we have similar one for EEGLAB/Matlab?

This is possible but will not be trivial to implement on the webservices side.  It can be easily done if you are using the version that calls the Python tools.  We will keep this as an issue and put it on the TODO list.


U/echarles/more unit tests

I'll add a few simple patterns to the pyproject.toml that gets rid of about 1/2 the pragma: no cover statements.   For the rest, on might wonder if taking the time to write units tests tickle all these exceptions is a good use of our time.


Stop line in chart

Chart JS can this ?
I want add stop line (example sunrise and sunset) and my chart must be for img bellow

all time before stop line and all time after stop line must be fiil - example red ,
I think that i can to add additional chart to start and end but i dont know data parametr
Thank you

You can do this with a CanvasGradient object. Closing as duplicate of #4068


Support Node.js 12 in create-turbo

What version of Turborepo are you using?
@latest
Describe the Bug
I use nvm to keep my Node version fixed to v12. When I do this and run npx create-turbo@latest I see the following:

When I unload nvm to get my system Node version and re-run create-turbo, I see the following:

Expected Behavior
I expect that Turborepo can use yarn with Node v12 to install dependencies without aborting. In the case of using the Node version 16.11.1, I expect that Turborepo can find yarn.
To Reproduce
Use Arch Linux or some other Linux distribution that has yarn and Node as system-level packages potentially? I'm also using yarn v1, should I be on v2?

I think that create-turbo requires Node.js 14+ which is LTS.
Node.js 12 is EOL

If you clone one of the examples (with a tool like degit), you should be able to use Node.js 12. (turbo itself is written in Go, so this is just about the create-turbo package)

The second part of the issue shows a problem with Node 16. I have yarn 1 installed at my system level and works fine with both versions of Node. When I run which yarn I get /usr/bin/yarn which seems pretty standard. Do I need yarn 2?

If you clone one of the examples (with a tool like degit), you should be able to use Node.js 12. (turbo itself is written in Go, so this is just about the create-turbo package)

This makes complete sense, the tool is in Go, so if I wanted to incorporate into an existing monorepo, it should just-work. I was just hung up on the scaffolder. Thank you!


remove input from clobbered list

Hi,
My ASM is bit rusty, please let me know if i am wrong. ^_^
Code below would not work for ICC, it would work for GCC or PGI. I assume both compiler do not do much of checking on ASM code.
__asm__ __volatile__
(  mov
   :
   : "r" (XXX), ....
   : "cc", "%0", "%1", "%2",

In GCC manual, I see following explanation:

You may not write a clobber description in a way that overlaps with an input or output operand. For example, you may not have an operand describing a register class with one member if you mention that register in the clobber list. Variables declared to live in specific registers (see Explicit Reg Vars), and used as asm input or output operands must have no part mentioned in the clobber description. There is no way for you to specify that an input operand is modified without also specifying it as an output operand. Note that if all the output operands you specify are for this purpose (and hence unused), you then also need to specify volatile for the asm construct, as described below, to prevent GCC from deleting the asm statement as unused.

As far as i understand, in this case since we have __asm__ __volatile__. This code will not be removed as long as it is reachable. Since memory is in the clobber registers, the code would not be optimized away. So remove "%0", "%1", "%2", should not cause any issue, and it would allow ICC to build OpenBlas. Please correct me if i am mistaken.
Build with flags:
DYNAMIC_ARCH=1 USE_THREAD=1 USE_OPENMP=0 NUM_THREADS=128 NO_LAPACK=1 INTERFACE64=1 BINARY=64

$ icc -V
Intel(R) C Intel(R) 64 Compiler for applications running on Intel(R) 64, Version <IP_ADDRESS> Build 20160415
Copyright (C) 1985-2016 Intel Corporation.  All rights reserved.

Error messages:
catastrophic error: unknown register name %2 in asm statement

Possible related to issue #718
Best,
Min Dong

By the way, with PGI compiler following message will be generated:
PGC-W-0351-Unsupported clobber register '%1' ignored in extended ASM

Finally merging despite my sore lack of assembler experience as all documentation I can find supports this, and (as expected) it demonstrably fixes the icc compile problem (also encountered in #962 and in investigation of  #1069) without any ill effect. (I note also that the equivalent code for sandybridge does not attempt to put its input operands on the clobber list...)
Thank you very much for this and the detailed explanation.


Placed dark-light behind a feature gate in eframe and egui_glow

I placed dark-light behind a feature gate in eframe and egui_glow because of a bug in dark-light that causes dark_light::detect() to block for extended periods of time on some Linux systems. It is not disabled by default, but can be enabled with the dark-light feature flag.

Thanks - please add a line to eframe/CHANGELOG.md noting that dark-light is not an opt-in feature!

Please also add a link to the relevant dark-light issue so we remember to turn this feature on again once it has been resolved!

Relevant issue in dark-light: https://github.com/frewsxcv/rust-dark-light/issues/17#issue-1186981293

Thanks, currently the dark-light failed to build on cross-compiling target.
on m1 macos:
rustup target add x86_64-pc-windows-gnu
cargo build --release --target x86_64-pc-windows-gnu

will error out with dark-light
error: native frameworks are only available on macOS targets

This could be helpful to resolve the issue.

@Piping remember to report dark-light issues to the dark-light github page


API to extend the information requested to participants

We use you system a payment collector that produces automagically a accounting report. We need to collect more information about the participants.
We would like to be able, first through your interface, then through an API, theses other characteristics and be able to get them afterwards.
Much thanks

Hi @npettiaux, we have a feature in beta-testing that could help to achieve that. Please open an issue on our main repo if you're still looking for that, with details about what kind of info you would like to collect: https://github.com/opencollective/opencollective/issues/new/choose.


WinGet script needs to be updated with per-user

Microsoft PowerToys version
0.69
Installation method
Other (please specify in "Steps to Reproduce")
Running as admin
None
Area(s) with issue?
General, Installer
Steps to reproduce
script currently does a machine wide only script.
✔ Expected Behavior
No response
❌ Actual Behavior
No response
Other Software
No response

Fixed in 0.71 release of PowerToys. aka.ms/installpowertoys


Replacing a brick with any hidden bricks before it was broken

Double-tapping where a replacement would occur would also crash

Codecov Report

Merging #28 into master will increase coverage by 0.01%.
The diff coverage is 92.85%.

@@             Coverage Diff              @@
##             master      #28      +/-   ##
============================================
+ Coverage     92.33%   92.34%   +0.01%
- Complexity      375      376       +1
============================================
  Files            22       22
  Lines          1030     1032       +2
  Branches        179      180       +1
============================================
+ Hits            951      953       +2
  Misses           22       22
  Partials         57       57

Impacted Files
Coverage Δ
Complexity Δ

...in/java/com/wayfair/brickkit/BrickDataManager.java
86.19% <92.85%> (+0.07%)
108 <ø> (+1)
:white_check_mark:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 73c0576...12d039c. Read the comment docs.


Create a user-friendly way how to set metadata

Setting dataset/table/variable metadata directly in the python module can be painful. Multi-line descriptions, boilerplate code, etc... Using YAML files for metadata nicely separates code from metadata. There were attempts to make this as user-friendly, but I don't think it's there yet. Now that we have enough examples, we should think about the best way and consolidate all those functions.
Add update method to replace setattr lines https://github.com/owid/owid-catalog-py/blob/master/owid/catalog/meta.py#L156

Is this still something that you're thinking about, Mojmir?

Closing, this is just nice to have and can be done later.


[feat] support for secondary controllers (and maybe transfer etc?)

Is your feature request related to a problem? Please describe.
I want to add an ISY 994i as a secondary controller (i already have it as my current home automation engine)
Describe the solution you'd like
I would like the same option as in zwave2mqtt on the controller node - where there were options for multiple controller management (i would have to respin the docker to get the exact names, can do that if needed).
Describe alternatives you've considered
switching back to zwave2mqtt
Additional context
I am using a RaZberry zwave module with this project (the previous test done on zwave2mqtt used a different controller, just incase that matters?

I think this is something that needs to be implemented on zwavejd and I think there is already an open issue. @AlCalzone

I think this is something that needs to be implemented on zwavejd and I think there is already an open issue. @AlCalzone

Yup https://github.com/zwave-js/node-zwave-js/issues/1070
Main problem is, this will require quite some manual testing and I do not have a secondary controller.

Yup https://github.com/zwave-js/node-zwave-js/issues/1070
Main problem is, this will require quite some manual testing and I do not have a secondary controller.

Happy to do some testing I have multiple (isy994i and a vera and an aeon/aeo stick or two)
Get Outlook for iOShttps://aka.ms/o0ukef

From: AlCalzone<EMAIL_ADDRESS>Sent: Saturday, January 2, 2021 2:28:23 AM
To: zwave-js/zwavejs2mqtt<EMAIL_ADDRESS>Cc: scyto<EMAIL_ADDRESS>Author<EMAIL_ADDRESS>Subject: Re: [zwave-js/zwavejs2mqtt] [feat] support for secondary controllers (and maybe transfer etc?) (#127)
Yup zwave-js/node-zwave-js#1070https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fzwave-js%2Fnode-zwave-js%2Fissues%2F1070&data=04|01||c68df0f3051046c1ed5a08d8af0922cc|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|637451801058150189|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=pFAq%2FPDZS1nUjOk6d1ragbII39vygziQePpXEZgWvOU%3D&reserved=0
Main problem is, this will require quite some manual testing and I do not have a secondary controller.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fzwave-js%2Fzwavejs2mqtt%2Fissues%2F127%23issuecomment-753456960&data=04|01||c68df0f3051046c1ed5a08d8af0922cc|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|637451801058150189|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=rnr%2Btp3I5OmTe7hYERgtsOtanq7sJUht4Wfqm%2FgfY7M%3D&reserved=0, or unsubscribehttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FACWXVXGIWGMIZXHXOTT5MVDSX3YMPANCNFSM4VPBANRA&data=04|01||c68df0f3051046c1ed5a08d8af0922cc|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|637451801058160184|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=l%2BaC7ltJG1XxN2Hi7zptDa%2Bio4E%2F%2FmJXADqqsSA6vnA%3D&reserved=0.

Happy to do some testing I have multiple (isy994i and a vera and an aeon/aeo stick or two)
Get Outlook for iOShttps://aka.ms/o0ukef

From: AlCalzone<EMAIL_ADDRESS>Sent: Saturday, January 2, 2021 2:28:23 AM
To: zwave-js/zwavejs2mqtt<EMAIL_ADDRESS>Cc: scyto<EMAIL_ADDRESS>Author<EMAIL_ADDRESS>Subject: Re: [zwave-js/zwavejs2mqtt] [feat] support for secondary controllers (and maybe transfer etc?) (#127)
Yup zwave-js/node-zwave-js#1070https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fzwave-js%2Fnode-zwave-js%2Fissues%2F1070&data=04|01||c68df0f3051046c1ed5a08d8af0922cc|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|637451801058150189|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=pFAq%2FPDZS1nUjOk6d1ragbII39vygziQePpXEZgWvOU%3D&reserved=0
Main problem is, this will require quite some manual testing and I do not have a secondary controller.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fzwave-js%2Fzwavejs2mqtt%2Fissues%2F127%23issuecomment-753456960&data=04|01||c68df0f3051046c1ed5a08d8af0922cc|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|637451801058150189|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=rnr%2Btp3I5OmTe7hYERgtsOtanq7sJUht4Wfqm%2FgfY7M%3D&reserved=0, or unsubscribehttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FACWXVXGIWGMIZXHXOTT5MVDSX3YMPANCNFSM4VPBANRA&data=04|01||c68df0f3051046c1ed5a08d8af0922cc|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|637451801058160184|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=l%2BaC7ltJG1XxN2Hi7zptDa%2Bio4E%2F%2FmJXADqqsSA6vnA%3D&reserved=0.

Closing this, comment on that issue so :)

Closing this, comment on that issue so :)


Add a way to stop speaking

It would be useful to be able to stop the speaker speaking or even have pause/resume abilities.
say.stop()
say.pause()
say.resume()

+1

+1

+1

+1

I feel like this would be a limitation of say or festival.

Stop is easy, we can simply kill the subprocess (say and festival seem to work that way).
Pausing and resuming is probably impossible, though I assume they aren't as important of a use-case.

Fixed in 8b2f87d9cd3a91bdfd3faa28bf82e6d34042a45b, available in 0.8.0.

Please note that this is a breaking release which changes the .speak() arguments.

thanks @tlhunter !!


broken links in Pie Chart page on carbon design system site

Detailed description

Describe in detail the issue you're having.

On http://www.carbondesignsystem.com/data-visualization/pie-chart/usage an image link returns a 404 imagesusage-pie-char.gif:1 GET http://www.carbondesignsystem.com/data-visualization/pie-chart/imagesusage-pie-char.gif 404 (Not Found)
also on
http://www.carbondesignsystem.com/data-visualization/pie-chart/style the Data Vis overview page link guides you to a 404

Is this issue related to a specific component?

Pie Chart

What did you expect to happen? What happened instead? What would you like to see changed?

images to load and link to redirect to a valid url

What browser are you working in?

Google Chrome Version 70.0.3538.102 (Official Build) (64-bit)

I feel like this probably belongs as an issue over on https://github.com/IBM/carbon-components so I'm going to move it over there.


Blocking API version

Clients don't have to be async, it's more the necessity for the server-side components. But this library forces a client to run inside an async runtime introducing unnecessary complexity for many cases.

Thank you for sharing your concerns :+1:
I am not sure how to do this cleanly given our reliance on Tonic.
Which part of the async. API do you find the most complex to work with?

After a short investigation, it seems we would have to duplicate the API using a blocking client


SockJS 0.2? Or 0.1 full compliance?

With SockJS 0.2 release, will sockjs-tornado support it any time soon?
I found that you didnt include any examples for testing sockjs protocol.
I created my own script using sockjs and well, test is failing in some cases. It would be great to see it all green ;)
0.1 full results
test_greeting (main.BaseUrlGreeting) ... ok
test_notFound (main.BaseUrlGreeting) ... ok
test_basic (main.ChunkingTest) ... ok
test_options (main.ChunkingTest) ... ok
test_transport (main.EventSource) ... ok
test_no_callback (main.HtmlFile) ... ok
test_transport (main.HtmlFile) ... ok
test_cacheability (main.IframePage) ... ok
test_invalidUrl (main.IframePage) ... ok
test_queriedUrl (main.IframePage) ... ok
test_simpleUrl (main.IframePage) ... ok
test_versionedUrl (main.IframePage) ... ok
test_content_types (main.JsonPolling) ... ok
test_invalid_json (main.JsonPolling) ... ok
test_no_callback (main.JsonPolling) ... ok
test_transport (main.JsonPolling) ... FAIL
test_closeSession (main.Protocol) ... ERROR
test_simpleSession (main.Protocol) ... ok
test_closeSession_another_connection (main.ProtocolQuirks) ... HANGS UP
test_anyValue (main.SessionURLs) ... ok
test_ignoringServerId (main.SessionURLs)
See Protocol.test_simpleSession for explanation. ... ok
test_invalidPaths (main.SessionURLs) ... ok
test_broken_json (main.WebsocketHixie76) ... ERROR
test_close (main.WebsocketHixie76) ... FAIL
test_empty_frame (main.WebsocketHixie76) ... ok
test_headersSanity (main.WebsocketHixie76) ... ok
test_reuseSessionId (main.WebsocketHixie76) ... ok
test_transport (main.WebsocketHixie76) ... ok
test_disabledTransport (main.WebsocketHttpErrors) ... ok
test_httpMethod (main.WebsocketHttpErrors) ... ok
test_invalidConnectionHeader (main.WebsocketHttpErrors) ... ok
test_invalidMethod (main.WebsocketHttpErrors) ... ok
test_verifyOrigin (main.WebsocketHttpErrors) ... ok
test_broken_json (main.WebsocketHybi10) ... ok
test_close (main.WebsocketHybi10) ... ERROR
test_firefox_602_connection_header (main.WebsocketHybi10) ... ok
test_headersSanity (main.WebsocketHybi10) ... ok
test_transport (main.WebsocketHybi10) ... ok
test_content_types (main.XhrPolling) ... ok
test_invalid_json (main.XhrPolling) ... ok
test_invalid_session (main.XhrPolling) ... ok
test_jsessionid (main.XhrPolling) ... ok
test_options (main.XhrPolling) ... ok
test_transport (main.XhrPolling) ... FAIL
test_options (main.XhrStreaming) ... ok
test_transport (main.XhrStreaming) ... ok
Now 0.2
test_greeting (main.BaseUrlGreeting) ... ok
test_notFound (main.BaseUrlGreeting) ... ok
test_response_limit (main.EventSource) ... ok
test_transport (main.EventSource) ... ok
test_abort_xhr_polling (main.HandlingClose) ... ERROR
test_abort_xhr_streaming (main.HandlingClose) ... HANGS UP
test_close_frame (main.HandlingClose) ... HANGS UP
test_close_request (main.HandlingClose) ... ok
test_no_callback (main.HtmlFile) ... ok
test_response_limit (main.HtmlFile) ... ok
test_transport (main.HtmlFile) ... ok
test_cacheability (main.IframePage) ... ok
test_invalidUrl (main.IframePage) ... ok
test_queriedUrl (main.IframePage) ... ok
test_simpleUrl (main.IframePage) ... ok
test_versionedUrl (main.IframePage) ... ok
test_basic (main.InfoTest) ... FAIL
test_disabled_websocket (main.InfoTest) ... FAIL
test_entropy (main.InfoTest) ... ERROR
test_options (main.InfoTest) ... FAIL
test_xhr_server_decodes (main.JSONEncoding) ... ok
test_xhr_server_encodes (main.JSONEncoding) ... ok
test_content_types (main.JsonPolling) ... ok
test_invalid_json (main.JsonPolling) ... ok
test_no_callback (main.JsonPolling) ... ok
test_transport (main.JsonPolling) ... ok
test_closeSession (main.Protocol) ... ERROR
test_simpleSession (main.Protocol) ... ok
test_close (main.RawWebsocket) ... ERROR
test_transport (main.RawWebsocket) ... ERROR
test_anyValue (main.SessionURLs) ... ok
test_ignoringServerId (main.SessionURLs)
See Protocol.test_simpleSession for explanation. ... ok
test_invalidPaths (main.SessionURLs) ... ok
test_broken_json (main.WebsocketHixie76) ... ERROR
test_close (main.WebsocketHixie76) ... FAIL
test_empty_frame (main.WebsocketHixie76) ... ok
test_headersSanity (main.WebsocketHixie76) ... ok
test_reuseSessionId (main.WebsocketHixie76) ... ok
test_transport (main.WebsocketHixie76) ... ok
test_httpMethod (main.WebsocketHttpErrors) ... ok
test_invalidConnectionHeader (main.WebsocketHttpErrors) ... ok
test_invalidMethod (main.WebsocketHttpErrors) ... FAIL
test_verifyOrigin (main.WebsocketHttpErrors) ... ok
test_broken_json (main.WebsocketHybi10) ... ok
test_close (main.WebsocketHybi10) ... ERROR
test_firefox_602_connection_header (main.WebsocketHybi10) ... ok
test_headersSanity (main.WebsocketHybi10) ... ok
test_transport (main.WebsocketHybi10) ... ok
test_content_types (main.XhrPolling) ... ok
test_invalid_json (main.XhrPolling) ... ok
test_invalid_session (main.XhrPolling) ... ok
test_jsessionid (main.XhrPolling) ... ok
test_options (main.XhrPolling) ... ok
test_transport (main.XhrPolling) ... ok
test_options (main.XhrStreaming) ... ok
test_response_limit (main.XhrStreaming) ... FAIL
test_transport (main.XhrStreaming) ... ok
Analysis
some failures are common, what's interesting is that some tests are now fully working!

ProtocolQuirks.test_closeSession_another_connection - (present only in 0.1) no idea what's the issue here. It just won't die.

Protocol.test_closeSession - times out (not sure if this is an issue with my test script?)

WebsocketHixie76.test_broken_json - this one has some broken dependencies (module import error) on my machine (which most likely means - dependency changed a little) but even after fixing it, doesn't seem to work. Which may or may not be due to the fact, that dependency (https://github.com/liris/websocket-client/) behavior changed.

WebsocketHybi10.test_close - again close seems to be an issue

JsonPolling.test_transport - fails in 0.1, but WORKS fine in 0.2!

WebsocketHixie76.test_close - again with close. AssertionError: 'h' != u'c[3000,"Go away!"]'

XhrPolling.test_transport -  fails in 0.1, but WORKS fine in 0.2!

HandlingClose.test_abort_xhr_polling - time out. Aborting, closing and stuff seems to be the main issue.

InfoTest.* - this one is new in 0.2, not implemented and should be part of the API.

Protocol.test_closeSession - time out.

RawWebsocket.* - this is something that cannot be implemented with current API (websocket without framing, heartbeats and stuff).

WebsocketHttpErrors.test_invalidMethod - for invalid methods it wants not only 405 but also something in 'allow' tag. Doesn't check what though, but anyway it is empty.

XhrStreaming.test_response_limit - it stopped working. Apparently, response_limit setting should not count needed by IE 2049 header ('h'*2048+'\n'). At least that's what node is using. Smells fishy.

Let's summarize this essay
So what is really not working?
Something's wrong with closing. RawWebsockets require implementation. New Info (/info) default endpoint as well.
Rest seems to be of low priority.

Forgot about files.
Test server I used: https://gist.github.com/1645236
Patch for xhr streaming (fixes XhrStreaming.test_response_limit, although I am still not sure if this isn't a bug in protocol specs): https://gist.github.com/1645256

Right, I forgot about dev branch! I was using master branch (these test results are from it as well).
I see that in dev /info is already implemented and there is some work done on closing.
So basically, it seems you were already fully aware of all these issues. I made this analysis because I learned that sockjs 0.2 was pretty new implementation and didn't know that you already worked on it before release :)

Pushed all my sockjs 0.2 changes. sockjs-tornado now supports both versions.

Great ;) Thanks for the info. PyPi package coming any time soon?


Implements edit url fortemplate

Hey, I just made a Pull Request!
I have implemented the edit link on the template page.
I did this to resolve this issue.
https://github.com/backstage/backstage/issues/17986

before

after

:heavy_check_mark: Checklist

[x] A changeset describing the change and affected packages. (more info)
[ ] Added or updated documentation
[x] Tests for new functionality and regression tests for bug fixes
[x] Screenshots attached (for UI changes)
[x] All your commits have a Signed-off-by line in the message. (more info)

@awanlin
Thank you for your review. I've modified the part you asked for in the comments.  Please review again


go.mod: Upgrade celestia-core to v1.2.4

Codecov Report

Merging #843 (90ac11c) into main (7f70b9b) will increase coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #843      +/-   ##
==========================================
+ Coverage   53.93%   53.94%   +0.01%
==========================================
  Files         122      122
  Lines        6979     6979
==========================================
+ Hits         3764     3765       +1
+ Misses       2827     2826       -1
  Partials      388      388

Impacted Files
Coverage Δ

header/core/listener.go
52.83% <0.00%> (-5.67%)
:arrow_down:

fraud/bad_encoding.go
40.59% <0.00%> (-2.98%)
:arrow_down:

ipld/retriever.go
85.89% <0.00%> (+1.92%)
:arrow_up:

das/daser.go
76.31% <0.00%> (+2.63%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7f70b9b...90ac11c. Read the comment docs.