Jupyter Lab and Software set up on GitHub adjustments from issue #375

Add the fill_color and fill_opacity parameters to the choropleth function.
Add instructions on how to exit the software to the README file after the description of the Compare function and before.
Correct text errors for the file path in the Sensitivity Analysis stage.

Another things I wonder is, perhaps in the example notebook, some users will be excited that they can change colours.  But others could be put off by the added complexity (a lot of our users are completely new to Python, so might not get the meaning of the options or the YlGn is yellow-green etc).  Another option could be, first do a basic map, so people know the basic command and that they don't have to add anything extra --- and then show how additional parameters can optionally be used to provide additional styling (maybe link to to the matplotlib colour maps https://matplotlib.org/stable/users/explain/colors/colormaps.html#classes-of-colormaps ).  What do you think?

Hi @carlhiggs,
Thank you for your review! I added the default parameters for fill_color, fill_opacity, line_opacity. I think if line_opacity is added as a customized parameter, other parameters for line graphics like line_color, line_weight should be also included. However, it will make the code cell longer or might seem unnecessary yet nice.
The phrase "Do not just close your browser tab or terminal window without stopping the web application or Jupyter first." intends to warn users to exit the app properly otherwise it will not run unless the docker's fully stopped and started again.
I think it's a great idea to add a quote explaining additional parameters with a link to the matplotlib colors. The default set parameters for graphics will ease the complexity for those who the new to Python.
Let me know what you think and I can merge these changes to global-healthy-liveable-cities:update-packages-and-methods-for-2024.

Hi @dapugacheva,
Thanks for those changes --- good point about adding other options (that could be endless).  In retrospect, perhaps another useful approach could have been allowing some sort of optional *args that could be passed on the sub-function, ultimately to Leaflet.  That probably would be a better way to implement things in the future, allowing users to engage directly with the options of the underlying function while not pre-empting usage of those parameters (except perhaps as defaults).  I also think it may be too much to worry about that now.
Regarding the 'do not close' bit; I would feel better if that sentence were omitted.  I don't quite understand where you say 'it will not run unless the docker's fully stopped and started again'.  That's not my experience and surprises me; I usually exit in this way and don't have to restart the Docker container.  However, I do know to use "Ctrl+C" (or cmd+c presumably on an Apple device?) to interupt the Jupyter or NiceGUI server (or other long running processes).  Perhaps that would be the more useful bit of information to share, e.g.

If you close a browser window with the Jupyter Lab or GHSCI app still running, the underlying server process running these may be interrupted by pressing Control+C or Command+C at the command prompt, depending on your operating system.

Could that work instead?  I guess it lets people know that nothing particularly bad will happen if they do close a window inadvertently, and there are other ways to do things.
If you're happy with that change and have tested out the functionality of the choropleth function and options yourself (or would like to write a unit test to do so - see here; most welcome, if you would like to!), then I'm happy for it to be merged in.  Thanks!

@dapugacheva I just merged these in as discussed.  Perhaps before we merge into the main branch and/or enhancements, we can wait for a few more of the planned amendments and then review whether instructions on the accompanying website etc need updating to reflect the changes.  Thanks!


refactor, convert start script to python and use hm-pyhelper functions

convert the startup script to python and use the helper functions in hm-pyhelper for the functions there

@shawaj old miner was using .sh. Do we want to convert it only for getting variant information?


ffmpeg exited with code 1

OSX 10.10.5
fluent-ffmpeg 2.0.1
ffmpeg 2.8.2

For some reason, I can use fluent-ffmpeg on only one specific video file; It's only about 31 seconds long, so I'm wondering if this is maybe an issue of file size?
I'm POSTing a file/buffer to my server, and using new stream.Readable to essentially convert my Buffer into a Stream.
I then pass this stream into ffmpeg, and it works beautifully if I use the smaller video file, but when I try to use one that's only about a minute long (entirely different video file, made by someone else)--and any other videos--it throws an error, and fails.
Here is my code:
const video = new stream.Readable({
	read () {
		this.push(myVideoBuffer);
		this.push(null);
	}
});

ffmpeg(video)
	.on('progress', e => console.log(e))
	.on('end', () => {
		console.log('ended')
	})
	.on('error', e => console.error(e))
	.save(`${process.cwd()}/media/videos/${Date.now()}.mp4`);

All of the videos I'm testing with are already MP4 files, so it's not doing any format conversion, it should just be saving my POSTed Buffer in my videos directory, yes?
the "stdout" is empty, but here's my "stderr":
ffmpeg version 2.8.2 Copyright (c) 2000-2015 the FFmpeg developers
  built with llvm-gcc 4.2.1 (LLVM build 2336.11.00)
  configuration: --prefix=/Volumes/Ramdisk/sw --enable-gpl --enable-pthreads --enable-version3 --enable-libspeex --enable-libvpx --disable-decoder=libvpx --enable-libmp3lame --enable-libtheora --enable-libvorbis --enable-libx264 --enable-avfilter --enable-libopencore_amrwb --enable-libopencore_amrnb --enable-filters --enable-libgsm --enable-libvidstab --enable-libx265 --disable-doc --arch=x86_64 --enable-runtime-cpudetect
  libavutil      54. 31.100 / 54. 31.100
  libavcodec     56. 60.100 / 56. 60.100
  libavformat    56. 40.101 / 56. 40.101
  libavdevice    56.  4.100 / 56.  4.100
  libavfilter     5. 40.101 /  5. 40.101
  libswscale      3.  1.101 /  3.  1.101
  libswresample   1.  2.101 /  1.  2.101
  libpostproc    53.  3.100 / 53.  3.100
Input #0, mov,mp4,m4a,3gp,3g2,mj2, from 'pipe:0':
  Metadata:
    major_brand     : mp42
    minor_version   : 512
    compatible_brands: mp42
    creation_time   : 2015-12-01 19:57:03
    media_type      : 9
    season_number   : 1
    episode_sort    : 1
    hd_video        : 0
    iTunMOVI        : <?xml version="1.0" encoding="UTF-8"?><!DOCTYPE plist PUBLIC "-//Apple Computer//DTD PLIST 1.0//EN"  "http://www.apple.com/DTDs/PropertyList-1.0.dtd"><plist version="1.0"><dict><key>studio</key><string>studio</string><key>cast</key><array><dict><key>name<
  Duration: 00:01:01.44, start: 0.000000, bitrate: N/A
    Stream #0:0(eng): Video: h264 (Constrained Baseline) (avc1 / 0x31637661), yuv420p, 640x360 [SAR 1:1 DAR 16:9], 927 kb/s, 24 fps, 24 tbr, 90k tbn, 48 tbc (default)
    Metadata:
      creation_time   : 2015-12-01 19:57:03
      handler_name    : VideoHandler
      encoder         : h264
    Stream #0:1(eng): Audio: aac (LC) (mp4a / 0x6134706D), 44100 Hz, stereo, fltp, 117 kb/s (default)
    Metadata:
      creation_time   : 2015-12-01 19:57:03
      handler_name    : SoundHandler
[libx264 @ 0x7f9581803800] using SAR=1/1
[libx264 @ 0x7f9581803800] using cpu capabilities: MMX2 SSE2Fast SSSE3 SSE4.2 AVX FMA3 AVX2 LZCNT BMI2
[libx264 @ 0x7f9581803800] profile High, level 3.0
[libx264 @ 0x7f9581803800] 264 - core 146 - H.264/MPEG-4 AVC codec - Copyleft 2003-2015 - http://www.videolan.org/x264.html - options: cabac=1 ref=3 deblock=1:0:0 analyse=0x3:0x113 me=hex subme=7 psy=1 psy_rd=1.00:0.00 mixed_ref=1 me_range=16 chroma_me=1 trellis=1 8x8dct=1 cqm=0 deadzone=21,11 fast_pskip=1 chroma_qp_offset=-2 threads=12 lookahead_threads=2 sliced_threads=0 nr=0 decimate=1 interlaced=0 bluray_compat=0 constrained_intra=0 bframes=3 b_pyramid=2 b_adapt=1 b_bias=0 direct=1 weightb=1 open_gop=0 weightp=2 keyint=250 keyint_min=24 scenecut=40 intra_refresh=0 rc_lookahead=40 rc=crf mbtree=1 crf=23.0 qcomp=0.60 qpmin=0 qpmax=69 qpstep=4 ip_ratio=1.40 aq=1:1.00
[aac @ 0x7f9581804a00] The encoder 'aac' is experimental but experimental codecs are not enabled, add '-strict -2' if you want to use it.

I'm gonna leave this here until It's seen, but I was able to fix it by looking at that last line in the stderr (I really need to pay closer attention).
I added outputOptions('-strict -2') to my ffmpeg chain, and it worked. I got a pre-built binary of ffmpeg, and I read in their docs that due to licensing, the pre-built versions do not come with the other encoders, and this one, I guess, was disabled by default.
https://trac.ffmpeg.org/wiki/Encode/AAC

Thanks for the hint ; FYI that was already seen in #153.


Contradiction in the method of selecting a public IP from a multiple frontend pool

This documentation says the following:
This service configures a new frontend IP on the Azure Load Balancer. If you do not have any other IPs configured, then all egress traffic should now use this address. When multiple addresses are configured on the Azure Load Balancer, egress uses the first IP on that load balancer.
While documentation here (https://docs.microsoft.com/en-us/azure/load-balancer/load-balancer-outbound-connections#assignilpip) suggests something else:
When multiple public IP addresses are associated with Load Balancer Basic, any of these public IP addresses are a candidate for outbound flows, and one is selected at random.
Is there an error in one of the documentations or there is some special mechanism for AKS that is not described in the general article?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 10de2de7-9d5a-b791-1e28-a399634993d6
Version Independent ID: a92015a1-4f3a-8b1b-1794-5566af729d16
Content: Static IP address for egress traffic in Azure Kubernetes Service (AKS)
Content Source: articles/aks/egress.md
Service: container-service
GitHub Login: @mlearned
Microsoft Alias: mlearned

@ilya-spv I believe this behavior is specific to AKS clusters.
@MicrosoftDocs/aks-pm to confirm

I think this document has a few issues, AFAIK the AKS doc is wrong here and needs to be fixed. As linked in the LB doc it is my understanding that with multiple outbound candidates the egress ip will be selected at random, not pinned to the first one.
@zr-msft any idea what the intent on this doc was previously? @palma21 is my assumption above aligned with you?

@zr-msft @palma21 any further comments?

Thank you for the feedback @ilya-spv
I have updated the article to incorporate your feedback. The changes should be available soon.


CODEOWNERS update 202206

NOTICE: If this pull request does not apply to your repository, please reach out to #internal-security-n-compliance. Please review and merge this PR to update the CODEOWNERS file to include the recently standardized team names

@dustincrogers please reword the commit message to satisfy our conventional commit message guidelines. This is required to get the PR over the finishing line 🏁
You can reword to: chore: update CODEOWNERS to include new team names


Add shorter titles for Italian translation.

If issue #21 is confirmed, consider updating the Italian translation with these small changes.
This PR fixes misalignment issue, at least for my setup.

Missed it, thx! :)


Use the correct AngularJs module name for blueprint importer

Currently, it will throw an error when the module is started, making it unusable.

FYI, the AngularJs module names for each UI module have been renamed in https://github.com/apache/brooklyn-ui/pull/180. But I made a mistake for the blueprint importer.
All other UI modules work as expected.

FYI, the AngularJs module names for each UI module have been renamed in https://github.com/apache/brooklyn-ui/pull/180. But I made a mistake for the blueprint importer.
All other UI modules work as expected.

LGTM, test pass, and fix tested locally; merging

LGTM, test pass, and fix tested locally; merging


Warnings on resizeMode props.style

| react-navigation |  ^1.0.0-beta.11
| react-native     |  ^0.46.4
Running the basic example throws warnings on the resizeMode prop being passed to View and RCTView.
Also the back button image is not shown.

Is this occurring when running the NavigationPlayground example?

Sorry, I think this was caused by my failure to include the RCTImage pod subspec which causes Images to fallback to Views and then these kind of things seem to break.
My bad, but for a lot of the functionality it is not immediately obvious which podspecs you need to include and then if you don't things break in curious ways.


GH-122 browser: permit serving over https

Platforms affected
Browser
Motivation and Context

This PR satisfies GH-122.
Description

This PR adds a new boolean option --https which will serve the browser platform over HTTPS.
These issues is other Cordova repos are also required:

https://github.com/apache/cordova-serve/issues/55
https://github.com/apache/cordova-cli/issues/621

Testing

A test for cordova run browser seems not to be present in this repo (?).
Checklist

[x] I've run the tests to see all new and existing tests pass
[ ] I added automated test coverage as appropriate for this change
[x] Commit is prefixed with (platform) if this change only applies to one platform (e.g. (android))
[x] If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)
[x] I've updated the documentation if necessary

Codecov Report

Merging #123 (857821c) into master (66d9e2e) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #123   +/-   ##
=======================================
  Coverage   93.75%   93.75%
=======================================
  Files           2        2
  Lines          32       32
=======================================
  Hits           30       30
  Misses          2        2

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


WIP: Fix/57 need logging in space cloud

This pull-request is still work in progress! This pull-request fixes #57.
Things that are still todo:

[x] Implement logging in web-UI → See mission-control/issues/28
[x] Documentation → See space-docs/issues/12
[ ] Change format of SysOut-logger
[ ] A bit more testing
[ ] Squash commits
[ ] Add file-logger

@ledex We can have separate issues for Documentation and the UI piece since they aren't really a part of this PR.
Do update this PR once the 2 and 3 points are done?

Can we start with 2 types of logger? You've already implemented the stdout one. Can we also have a file implementation?

Hey @ledex, do we have an ETA on this?

Yeah sorry for the big delay. I will be able to work on this topic this
weekend. So maybe this issue will be implemented by Sunday. But I can't
give a 100% guarantee.
Noorain Panjwani<EMAIL_ADDRESS>schrieb am Mi., 18. Dez. 2019,
06:11:

Hey @ledex https://github.com/ledex, do we have an ETA on this?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/spaceuptech/space-cloud/pull/508?email_source=notifications&email_token=AJLAEUBQRNLBFUM4C7LIRHTQZGWGVA5CNFSM4JOTV2UKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEHE4CUQ#issuecomment-566870354,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AJLAEUGL54CVVHXSU4O6DK3QZGWGVANCNFSM4JOTV2UA
.

@ledex seems like logrus can be extended to achieve precisely what we want. I think we should use logrus as suggested by you in our initial conversations

Okay, @YourTechBud. Sorry that I did not have any time to implement this in its full glory. I'll get back to you when my schedule is a bit freer.


Different versions of s3 on GitHub and NPM

Hi, I've noticed that there are different versions of this library here on GitHub in master branch and on NPM. The version in package.json is the same though and it might cause troubles.
For example, the aws-sdk dependency is ~2.4.9 here and ~2.0.31 on NPM. There are probably other changes as well.

I've just noticed this might be related to #139.


How can i brand my zulip organisation in the main landing page.

How can i change my landing page of zulip home page with login and signup.

@nivashiot  You can change your organizations' profile picture by choosing "Manage Organization" from the gear menu in the top right corner and then going to "Organization Profile."


raw command  seems not play well

About raw command
when i type raw srvr ,it seems like invalid why is that
(RO 0) > raw srvr
Command 'raw srvr' is invalid

Thank you very much for the report! The raw command was indeed broken. I've just released a 0.3.1 version on PyPI with the fix, and I added you to the contributors.


hyprland-qtutils: add disable warning instructions

Saw the warning and searched on google about that.
First result is this wiki page with no information about how to disable the warning... currently it is documented (see the reference), but not immediate to find, that's the reason of this PR.

I agree that generally users should install it, but haven't noticed any issue so I decided to disable the warning (at least for now).
Who wants to disable the warning knows there's a way to do so, this just reduce searching time.
Eventually we could add a message saying that it's strongly recommended to install that package?

haven't noticed any issue

well because it's not present, so hyprland doesn't run it, so it disables features that depend on it. That's why you don't see it.

stuff like dialogs or popups.

May I ask you some screenshots? Can we add those to the documentation page eventually? Thanks in advance for your support :)


Sync: Review UX behind turning on/off

Testing https://github.com/microsoft/vscode/issues/85944
I already raised this concern before, let's just have it in an issue:
I believe that allowing the user to turn Sync on/off is an anti-pattern. Just like Edge or my Android phone, sync just works, without me enabling/disabling it.
The current approach also has ambiguous command labels like Sync: Turn On... like what does this mean? If I didn't know what I was testing I would even think this came from an extension.

Also minor: the sign out command is simply Sign Out, it should be Sync: Sign Out.

Also: should it really be a global notification (in the gear icon) that you're not signed in? That's another reason to drop the whole user controlled toggle.

There are also other tools like Chrome which provide this toggling option. I assume that context is shown from the global menu where it shows all user configuration data and we also show a dialog after turning on explaining user what is getting synced.
Sign out command is temporary but will add Sync prefix.

Also: should it really be a global notification (in the gear icon) that you're not signed in?

I think so it is. Again same reasoning as above.
Again moving this to https://github.com/microsoft/vscode/issues/85216


CSS is missed in transform hook

Describe the bug
CSS is missed in transform hook now.
code argument of transform(code, id) hook contains only "export default ''" string. There is no CSS.
It worked before — with Vite 2.5.7.
For example, I was able to generate such style.css
With this plugin: (using), (plugin code)

For the reproduction uncomment these lines of the minimal reproduction repo
Reproduction
https://github.com/AlttiRi/serve-json-gz-length-test
System Info
OS: Windows 10 10.0.19043
Node: 17.3.0
Yarn: 1.22.5
npm: 7.19.1
vite: 2.7.2

Used Package Manager
npm
Logs
No response
Validations

[X] Follow our Code of Conduct
[X] Read the Contributing Guidelines.
[X] Read the docs.
[X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
[X] Make sure this is a Vite issue and not a framework-specific issue. For example, if it's a Vue SFC related bug, it should likely be reported to https://github.com/vuejs/vue-next instead.
[X] Check that this is a concrete bug. For Q&A open a GitHub Discussion or join our Discord Chat Server.
[X] The provided reproduction is a minimal reproducible example of the bug.

I don't know the older version. but right now, if you put the cssBundlePlugin in plugins, will solve the problem:
// vite.config.js
export default defineConfig({
  plugins: [
    vue(),
    sourceMapsPathChangerPlugin([
      // Use "../../" instead of "../" if resources are in "assets/" directory
      ["../node_modules/", "node-modules:///"],
      ["../vite/", "node-modules:///vite/"],
      ["../src/", "source-maps:///"],
      ["../", "source-maps:///"],
    ]),
    cssBundlePlugin({
      overwriteBundle: "style.css",
      importFromModule: true,
    }),
  ],
  server: {
    open: `./`,
  },
...

more info about plugin API: https://vitejs.dev/guide/api-plugin.html

Not solves.
In this case (when I use it as a plugin of Vite (plugins) (not as build.rollupOptions.plugins)) the plugin just does not work, and it return the code as is.
In this case I receive the correct CSS in transform hook, instead of expected "export default '.warning \n{\n  color:red\n}'" like it should be when I use the plugin as a Rollup plugin:
"[cssBundlePlugin]: Failed to load CSS as a module. Returns as pure code. Use "importFromModule: false"
Even with:
    cssBundlePlugin({
      overwriteBundle: "style.css",
      importFromModule: false,
    }),

It does not work since in generateBundle(opts, bundles, isWrite) hook bundles argument has a missed property with CSS content.
[cssBundlePlugin]: "style.css" bundle is not found. Available bundles: ['index.js', 'vendor.js'].

The expected CSS in style.css is:
/* App.vue */
.warning {
  color: red;
}

I have updated the example repo code.

There are two bugs:

A plugin used in build.rollupOptions.plugins has no CSS code in code argument of transform(code, id) hook, only "export default ''" string.
A plugin used in plugins has no CSS file property  in bundles object argument of generateBundle(opts, bundles, isWrite) hook, only {"index.js": "...", "vendor.js": "..."}, there is no "style.css", "index.html" keys.

The first bug is new.
The second bug is old, it's why I use the plugin as Rollup's one.

The bug appeared with Vite 2.6.0.
With "~2.5.10" it works OK.

In deed 2.6.0 seems to mess style processing (causing all sorts of strange style related issues). Had similar issues with Lit + imported SCSS + PostCSS + Tailwind project with<EMAIL_ADDRESS>and newer when doing production build, but everything worked with dev build. Switching  to<EMAIL_ADDRESS>and<EMAIL_ADDRESS>fixed the issue. Used rollup-plugin-postcss-lit (in vite plugin config) to load processed CSS into Lit elements.
Using rollup-plugin-postcss caused same export default '' error, when used it with/without rollup-plugin-postcss-lit in the rollup plugin config.
I am too interested in what causes this. I have not yet found the breaking change.

Reopening as #8278 and #8471 was reverted. See #8896 and #8874 for details.

Well, transform(code, id) hook of build.rollupOptions.plugins still receives export default '' values.
And generateBundle(opts, bundles, isWrite) hook of plugins still have missed style.css key (in the second bundles argument) to overwrite it with a custom value.
    "vite": "3.2.4",
    "terser": "5.16.0"

I just want to generate such CSS files: https://alttiri.github.io/file-manager-snapshot-explorer/style.css

With the late Vite (3.2.4) while the issue is still actual, I can handle with CSS:

a plugin should be use as a Vite's plugin
build.cssCodeSplit should be false

In this case it work, with minor changes:

ignore the additional CSS from index.html
the result bundle name is index.css, not style.css

I use the plugin to generate such CSS:
https://alttiri.github.io/file-manager-snapshot-explorer/index.css
Because Vite.js still does not support maps for CSS files.

any updates?

Plugin hooks like resolveId, load and others code transform hooks should also apply to css/less/sass?

same issue.  I had fixed it by delete  enforce  key. You may set it post?

Given that

The content itself can be accessed by plugins with enforce: pre / without enforce
Reordering the plugin position is not acceptable as it will break the whole ecosystem
Adding the export default with /* #__PURE__ */ had memory issues and huge file size increase (https://github.com/vitejs/vite/issues/8859#issuecomment-1171138227, https://github.com/vitejs/vite/issues/8819)

, I'll close this issue as wontfix.
If there's a good way to solve this, feel free to create a PR or a new issue.


Load custom Javascript file from theme

Attempted Debugging

[X] I have read the debugging page

Searched GitHub Issues

[X] I have searched GitHub for the issue.

Describe the Scenario
My theme needs a small amount of Javascript. How can I load that Javascript file from my themes folder (e.g. BookStack/themes/my_theme/js/script.js)?
What I tried and didn't work:

Put this into the Custom Head Setting on the customization page -> My customization needing that script is on the customization page itself and the Custom Head Setting is not loaded there.
Overwrite common/custom-head.blade.php or layouts/base.blade.php or layouts/parts/base-body-start.blade.php or layouts/parts/base-body-start.blade.php and add the

Yeah, there's no ideal option for public files right now. I have an existing open issue for this in #3904.

My browser blocks inline scripts;

So my advise would be to override base-body-start.blade.php for this kind of thing.
You will need to add tags to befriend CSP. I'd usually start with this:
<script nonce="{{ $cspNonce }}" type="module">
  // code
</script>

The nonce="{{ $cspNonce }}"  makes CSP happy.
The type="module" is optional but makes the script deferred, so no need for listening to events for waiting for the DOM to be loaded before targeting elements.

I put the script.js file into the folder Bookstack/public/dist. From there it is loaded, but this would mean that I would have to create my own Docker Image just to add that one file

You may be able to instead map a volume into this directory, or use the existing public/uploads directory which is commonly provided/advised as a volume mount location.

Thank you for your quick answer. I tried the inline script in base-body-start.blade.php and it worked!
Maybe I'll try changing this into an endpoint some time. But I defenitely like the issue you linked.


fix(sns): set corret handler event type

Current dependencies on/for this PR:

main

PR #43

PR #44

PR #45

PR #46

PR #47

PR #48

PR #49

PR #50   👈

Current dependencies on/for this PR:

main

PR #43

PR #44

PR #45

PR #46

PR #47

PR #48

PR #49

PR #50   👈

Graphite Merge Job
Current status: ⏳ Queued to merge
This pull request is currently queued to be merged as part of a stack.
This comment was auto-generated by Graphite.

Job Reference: o2hXZcUGA7x4CULUTBXA


[Spring Data Support] Make sure all contents in original README are included in reference doc. @backwind1233

link pr:https://github.com/microsoft/spring-cloud-azure/pull/795


🐛 [bug] - Logging Kibana/ES not available

Kibana/ES not available for
http://localhost:3000/#/4-return-of-the-monitoring/3-logging?id=aggregated-logging
this bug is tracking https://github.com/rht-labs/enablement-framework/pull/76

This seems to be working now, I'm OK to close this.

thanks @alexpdp7 !


Decodable protocol extension with initializers accepting raw Data

You can just initialize model directly from Data type.
Example:
struct Foo: Decodable { ... }
if let foo = Foo(data: jsonData) { ... }
or for array:
struct Bar: Decodable { ... }
let arrayOfBar = Bar.array(from: jsonArrayData)

this needs tests added to it

@kampro are you able to follow up on the additinal comments to this pull request?

Merged separately from command line - this behavior will be available as of version 1.1.2

are you able to follow up on the additinal comments to this pull request?

@hkellaway Sorry for delayed reply, I am not sure what you mean, but all I can see is what you can see in the screen shot. After your comment I immediately fixed problems and pushed commit.


Is this problem? compare int and Integer variable

https://github.com/Tsuser1/Modern-LWC/blob/4973f9806e85f27da13aa2c45201f45476867f18/src/main/java/com/griefcraft/cache/BlockCache.java#L121
nextId is int and materialId is Integer.
Is this compare correct?

It should be fine due to Java's autoboxing feature. See https://docs.oracle.com/javase/tutorial/java/data/autoboxing.html

Thanks for the response.
I understand it! close issue....


Support programmatically refilling token buckets

Hi again,
I was wondering if it would be possible to add support for programmatically refilling token buckets with X number of tokens prior to the refill reset time.
For example:
TokenBucket t = ...;
t.refill(10)

This would add at most 10 tokens to token bucket, t, or (capacity - 10), whichever is less.
Our use case for this is a bit complicated but basically each user in our system is associated with a token bucket and we'd like an administrator to be able to refund individual users just enough points to issue one off requests (which cost tokens), under certain exceptional conditions.
Thanks!

Sure, that seems totally reasonable.

Ok, version 1.7 has been released and should be in maven central shortly.  It contains the new refill method on the token bucket.


Merge release branch

Context
This is merging release to master. In case of lost changes from 6.8.1 -> 7.0, open a PR for review.

@ljacomet @melix @jjohannes In case we lost some changes, can you please review the merge to see if I did the correct conflict?
@bamboo @eskatos I was confused by your change, one of you keeps adding tests for KotlinDslPluginTest, another one keeps removing code, can you please decide how to merge the KotlinDslCompilerPlugins and KotlinDslPluginTest?

@ljacomet @melix @jjohannes In case we lost some changes, can you please review the merge to see if I did the correct conflict?
@bamboo @eskatos I was confused by your change, one of you keeps adding tests for KotlinDslPluginTest, another one keeps removing code, can you please decide how to merge the KotlinDslCompilerPlugins and KotlinDslPluginTest?

Just saw @ljacomet did the same thing. Closing.

Just saw @ljacomet did the same thing. Closing.


DST Unit Test Failures

We have a known issue that occasionally shows up as "diff:diff across DST" in the unit tests.
These are not mission critical, and can manifest in a variety of ways depending on OS, browser, time zone, and time zone data updates installed on the OS or in the browser.
For the time being, we'll use this issue to link to test failures related to DST and time zone variations.  Eventually we will try to address the root cause.

Calendar tests addressed in #3034.


Totally necessary change I promise

This is a line which is needed cuz it's gonna offend ppl who don't know LaTeX and all we need is offended ppl in hc

True but no


Bug when using multiple manifolds

Description

A bug was preventing the use of multiple manifolds. The variable describing the manifold was set as a static const but needed to be modified for every manifold.
The maximum number of manifolds was also set to 14. To make it more flexible, the method used for the boundary conditions was modified to take the manifolds into account.
Solution

removed the static const.
Checklist (will be removed when merged)
See this page for more information about the pull request process.
Code related list:

[ ] All in-code documentation related to this PR is up to date (Doxygen format)
[ ] Copyright headers are present and up to date
[ ] Lethe documentation is up to date
[ ] Fix has unit test(s) (preferred) or application test(s), and restart files are in the generator folder
[ ] The branch is rebased onto master
[ ] Changelog (CHANGELOG.md) is up to date
[ ] Code is indented with indent-all and .prm files (examples and tests) with prm-indent

Pull request related list:

[ ] Labels are applied
[ ] There are at least 2 reviewers (or 1 if small feature) excluding the responsible for the merge
[ ] If this PR closes an issue or is related to a project, it is linked in the "Projects" or "Development" section
[ ] If the fix is temporary, an issue is opened
[ ] The PR description is cleaned and ready for merge

@mivaia it's very weird this test crashing in debug especially because it's a tiny unit test...

I'll look into it today, but it contains a Parameters::SizeOfSubsections object which I modified so it might not be that obscure.


Use TestClient in an async fashion

Is your feature request related to a problem
Unfortunately, test client runs it's own event loop. This causes an issue when attempting to do other async operations in the background.
Running it inside an executor will cause it to run in a different threat, which in turn causes issues with other async libraries a they're calling coroutines from a different thread.
The solution you would like
Make a TestClient that doesn't create it's own loop. Just have it async.
Describe alternatives you've considered
Other than executor or partching fastapi, there are no alternatives.

There are plans (https://github.com/encode/starlette/issues/440 and https://github.com/encode/starlette/issues/652) to move starlette.testclient.TestClient from requests to httpx to fix this behaviour. Before this happens you can try using httpx directly or try the async-asgi-client package. But there may be some problems with the templates, if you are using them.

As long as fastapi doesn't support it, may I suggest adding a note to the docs?

Yes, good idea. I think adding an info block after the introduction on this page will be good place, right?
In addition, it is possible to create a new page that will show how to use httpx (or async-asgi-client) for tests. Probably in the advanced section.
Would you submit a PR?

Yep, as @nsidnev says. :point_up:
And yeah, that could probably have a small section in the advanced tutorial.

I've done some async testing using httpx in the last few days, as I wanted to verify the state of the database in my tests as well, and that works really well! I don't have experience with the async-asgi-client though.
Would be up to write a section in the docs on it!

As @empicano mentioned using httpx directly works great. Here's a little example "workaround" by using the httpx.AsyncClient and it's working quite well
in your conftest.py

from typing import Generator
import pytest
from httpx import AsyncClient
from asyncio import get_event_loop

from app.db.session import SessionLocal

@pytest.fixture(scope="session")
def db() -> Generator:

    yield SessionLocal()

@pytest.fixture(scope="module")
async def async_client() -> Generator:

    async with AsyncClient(app=app, base_url="http://testserver") as client:

        yield client

@pytest.fixture(scope="module")
def event_loop():

    loop = get_event_loop()

    yield loop

in a test file

import pytest
from httpx import AsyncClient
from fastapi import status
from sqlalchemy.orm import Session

@pytest.mark.asyncio
async def test_get_something(async_client: TestClient, db: Session) -> None:
    await create_something(db=db)
    response = await async_client.get("/something?skip=0&limit=5")

    assert response.status_code == status.HTTP_200_OK
    assert 0 < len(response.json()) <= 5

@empicano added this, the new docs are here: https://fastapi.tiangolo.com/advanced/async-tests/ :tada: :rocket: :memo:

@tiangolo how to trigger startup and shutdown event with this approach?

Hi here, @tiangolo. Thanks for your great work. I faced the same issue as @Gatsby-Lee above. I have to trigger startup event before async testing. Is there any solution?

@Gatsby-Lee You can use https://pypi.org/project/async-asgi-testclient/. It will run events in context manager's aentry/aexit methods. @tiangolo, hi here, it might be worth to clarify in documentation that the events will work only with async-asgi-testclient.

Has anyone been able to get a streaming async test to work with httpx.AsyncClient.stream? I filed an issue here (https://github.com/tiangolo/fastapi/issues/2006) and haven't had any responses. Based on @madnesspie's comment above I tried using async-asgi-testclient and was able to get my tests to work and I added a comment to that effect, so perhaps it is related to the aentry/exit events, but I admit I don't fully understand what is going on.

@Gatsby-Lee You can use https://pypi.org/project/async-asgi-testclient/. It will run events in context manager's aentry/aexit methods. @tiangolo, hi here, it might be worth to clarify in documentation that the events will work only with async-asgi-testclient.

I strongly agree that this part MUST be in docs about async testing. Events is huge and important part and lack of information about this matter is disappointing. I absolutely love FastAPI and I hope those missing areas will be covered. I can add mention to the docs about events in async testing, but in the current state it will broke it, because approach there is totally different.

Is there an AsyncClient equivalent for websockets?

AsyncClient helped.
You can also check FastApi article
https://fastapi.tiangolo.com/advanced/async-tests/

Is there an AsyncClient equivalent for websockets?

I found strange things inside Strarlette: it uses anyio for testclient and runs all websockets views in different threads with their own loops. But at the same time, starlette recommends to use deployment with unicorn, which recommends to use one process -> one thread -> one loop.
As a result, original TestClient from Starlette can not be used for testing production-ready code. Sometimes it causes such huge changes that developer should write another app for test suits.
In the Internet currently i didn't found any lib for this case. So i made my own client based on original TestClient only for websockets
Example of usage:
@pytest.fixture(scope='session')
async def user():
    async with AsyncioTestClient(app, event_loop=shared_event_loop) as client:
        async with client.websocket_connect("/ws/") as websocket:
            yield websocke

testclient.txt

testclient.txt

Hey @symstu, this is exactly what I was looking for, thank you. Any chance you could put a license on it, so I could include it in a project?

testclient.txt

Hey @symstu, this is exactly what I was looking for, thank you. Any chance you could put a license on it, so I could include it in a project?

just include it if you want

I think it's a good feature request to let devs write application tests in async functions with websocket support. Why it's closed?
E.g. I want to make an integration test with 2 servers running during the tests and I can't use sync tests (because TestClient blocks the thread). The good alternative is AsyncClient but it doesn't support websockets.


Add <example> tags to generated output

Is your feature request related to a problem? Please describe.
Not sure if I'm missing more documentation elsewhere, but I keep running into issues trying to adapt existing PInvoke samples to use CsWin32 instead.
Usually, it's related to type conversion or calling conventions and such.
Describe the solution you'd like
Even if it's a trivial example, it'd be nice for the generated output of the generator to include an <example> tag which shows how to call the function including any passed in or referenced pointers/structures.
e.g.
Span<System.Drawing.Point> points = new();

PInvoke.MapWindowPoints(hWnd, HWND.Null, points);

Describe alternatives you've considered
Not use CsWin32 and just manually add back the pinvoke calls... 🙁
Additional context
Related: https://github.com/microsoft/CsWin32/issues/789

The calling pattern for CsWin32-generated APIs should match what the docs say, and the docs are often linked from the xml doc comments that CsWin32 generates for your convenience. We can't emit examples for these APIs as the docs we have is scraped from the docs site. The docs site will always have more info than the xml doc comments can have.

@AArnott appreciate that docs exist, but navigating C++ focused docs as a C# developer isn't always straight-forward, especially when there's casts and other helpers to help interop with C#.
Since the docs are being scrapped and samples exist, it seems like being able to at least put them in the generated xmldoc in an example tag could work? And maybe with some basic inference as done with the APIs themselves to help demonstrate the call patterns better.
At least having some basic guide with some common examples of API calls and conversions to help someone get started more easily with Win32 APIs now that they're more commonly needed for Windows App SDK development would be a big help for someone not as familiar with Win32 APIs nor C++ development in general.

All good points that you're making. But it's unlikely we'll invest more in scraping more than we already are from the docs. The process is not straightforward. We have lots of bugs and enhancements we want to make to CsWin32 itself, and CsWin32 actually just takes the docs as they are scraped (by another repo) so if we really want to add examples to the docs, https://github.com/microsoft/win32metadata would be the place to file that issue anyway since that's where it happens. But if you were to do that, they'd just ask me for my opinion since I wrote the scraper, and I'd say the same thing: it's a lower priority than a lot of the functional bugs we have both in the metadata and in CsWin32 that we're still chasing, so I don't see us working on adding examples in the near future.
As for the docs being C++ focused, you're absolutely right. And there is no funding for rewriting them to be C# focused, either on docs.microsoft.com or for CsWin32 code generation. Win32 programming is in general much harder than C# calling into the .NET BCL, so for folks who have never done it, it'll be a challenge, for sure. CsWin32's scope is not to make that easier except in one respect: declaring the interop APIs. The rest of the challenge remains. Various programming forums will still be a resource, and in fact many of the questions you'll have about it have already been asked and answered in these forums. It'll be a skill though for you to build up to 'translate' many of these from C++ to C# though.
I like your idea of documenting some common tricks and translations somewhere to help folks in your position to get started. I don't know when we'll get to that, or if the community will send PRs or start a wiki somewhere that can aggregate these ideas.


Fetch command for external artifacts not loading "Subpath" and "Destination"

Issue Type

Bug Report

Summary
After upgrade from GoCD 20.4 to 20.5, there are a few issues with fetching external files:

opening the fetch command for external files does display the configured Subpath and Destination
updating the fetch command for external files configuration using the UI from config.xml removed the Subpath and Destination

Environment
GoCD 20.5 (after 20.4 migration).
Basic environment details

Go Version: 20.5
JAVA Version: 13.0.2
OS: Linux 4.14.97-90.72.amzn2.x86_64
Browser vendor and version (if relevant): All (newest Chrome, Safari)

Steps to Reproduce

Open fetch command for external artifact
Check Subpath and Destination fields are empty

Expected Results
Subpath and Destination must be loaded from config.xml
Actual Results
Subpath and Destination are blank and clear config.xml after saving it

Link the the official GoCD repo

Hello @tomzo @Diogomrol @aarnone @karelbemelmans @sradnev,
Is this project being maintained?

Hello @tomzo @Diogomrol @aarnone @karelbemelmans @sradnev,
Is this project being maintained?

@murilodag I'm not sure, my contribution was occasional :)


How to join SAHI while training and reasoning

What is the problem this feature will solve?
Optimize the detection effect of small objects
What is the feature you are proposing to solve the problem?
SAHI
What alternatives have you considered?
No response

@shuoshuo09 It is already in the plan, welcome to continue to pay attention.

@hhaAndroid Hi, do you know if part of the plan is to add SAHI option for mmdet2torchserve.py and mmdet_handler.py?

@hhaAndroid Hi, do you know if part of the plan is to add SAHI option for mmdet2torchserve.py/mmdet_handler.py?

Yes. Development this month

@hhaAndroid Hi, thanks for your response! I'm having trouble finding this PR and how to enable this feature. Could you please add link when you get a chance?

Was Sahi support added for online training? Is there any examples demonstrating how to use it?

I ended up creating a feature request over here as well.


Replace User model with Deed in spec/page_objects/deed_form.rb

Addresses #62

Thanks! Hope to see you back with more PRs 🙂


Update delete_docker_registry_image.py

delete entire repository when just has one tag

i like this, thanks! i followed up with a minor tweak in https://github.com/burnettk/delete-docker-registry-image/commit/4214924799e4e03bbd6ba0a98402f0bde9cdd752.


feat: upgrade to webpack5

Full changelog: https://github.com/webpack/changelog-v5/blob/master/README.md

[x] Pin webpack version to v5-alpha
[x] Pin html-webpack-plugin to v4-alpha
[x] optimization.splitChunks name: true removed: Automatic names are no longer supported
[ ] Prefer using chunkIds: "named" and idHint
[ ] Compilation.hooks.normalModuleLoader was moved to NormalModule.getCompilationHooks(compilation).loader

[ ] vue-loader/lib/plugin.js
[ ] extract-css-chunks-webpack-plugin

[ ] [hash] is now [fullhash] (also consider using [chunkhash] or [contenthash], see documentation for details)

Tip: Trace deprecation warnings via node -r esm --trace-warnings --trace-deprecation ./node_modules/.bin/nuxt examples/hello-world

too early :)

@pi0 I guess HardSourceWebpackPlugin is obsolete then as well? (PR #4527)

Appreciate the work you are doing on Extract CSS Chunks!

For the removal of requireEnsure - this looks like what it became. https://github.com/webpack/webpack/blob/master/lib/async-modules/AwaitDependenciesInitFragment.js
MainTemplate will be removed in v6

Codecov Report

Merging #4616 into next will decrease coverage by 1.49%.
The diff coverage is 5.17%.

@@            Coverage Diff            @@
##             next    #4616     +/-   ##
=========================================
- Coverage   62.51%   61.02%   -1.5%
=========================================
  Files          84       86      +2
  Lines        3404     3497     +93
  Branches      930      957     +27
=========================================
+ Hits         2128     2134      +6
- Misses       1026     1093     +67
- Partials      250      270     +20

Flag
Coverage Δ

#unittests
61.02% <5.17%> (-1.5%)
:arrow_down:

Impacted Files
Coverage Δ

packages/config/src/config/build.js
100% <ø> (ø)
:arrow_up:

packages/webpack/src/config/server.js
0% <ø> (ø)
:arrow_up:

packages/webpack/src/config/base.js
0% <0%> (ø)
:arrow_up:

packages/webpack/src/builder.js
8.41% <0%> (-0.17%)
:arrow_down:

packages/webpack/src/plugins/vue/util.js
41.66% <0%> (-3.79%)
:arrow_down:

packages/webpack/src/config/client.js
0% <0%> (ø)
:arrow_up:

packages/webpack/src/plugins/vue/modern.js
4.44% <0%> (ø)
:arrow_up:

packages/webpack/src/plugins/vue/cors.js
0% <0%> (ø)
:arrow_up:

packages/webpack/src/utils/perf-loader.js
0% <0%> (ø)
:arrow_up:

packages/config/src/options.js
98.45% <100%> (+0.02%)
:arrow_up:

... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b3883cc...70217c4. Read the comment docs.

Also, I wrote this feature into Webpack 5 called Module Federation @manniL - I’ve rebuilt next.js in order to implement this, since this project is the Vue equivalent, and likely face the “how do we do micro-frontends, with shared resources and no page reloads, along with how do we to the same in SSR as well?”
This might be of use: https://link.medium.com/i7cpPsXJ64

I’m thrilled to see you’ve added module Federation investigation!
Get hold of me when you start looking into it. I’m supporting angular’s core team as they upgrade to module federation.
Happy to help or provide information

@ScriptedAlchemy Thanks, it would be great that we can get your help when we start.

Get me on twitter and we can set up a zoom call. We should be cutting beta.17 which triples the capabilities of module federation
If you’ve got time to waste. Here’s a intro to advance api now in master. This only covers shared and sharing. There’s at least 2 more videos that need to be made for the other things we did. https://youtu.be/9F7GoDMrzeQ

Codecov Report

Merging #4616 into next will decrease coverage by 1.48%.
The diff coverage is 11.92%.

@@            Coverage Diff             @@
##             next    #4616      +/-   ##
==========================================
- Coverage   70.51%   69.02%   -1.49%
==========================================
  Files          88       90       +2
  Lines        3605     3700      +95
  Branches      979     1006      +27
==========================================
+ Hits         2542     2554      +12
- Misses        862      926      +64
- Partials      201      220      +19

Flag
Coverage Δ

#unittests
69.02% <11.92%> (-1.49%)
:arrow_down:

Impacted Files
Coverage Δ

packages/config/src/config/build.js
100.00% <ø> (ø)

packages/webpack/src/builder.js
12.96% <0.00%> (-0.38%)
:arrow_down:

packages/webpack/src/config/client.js
67.10% <0.00%> (ø)

packages/webpack/src/config/server.js
0.00% <ø> (ø)

packages/webpack/src/plugins/vue/cors.js
0.00% <0.00%> (ø)

packages/webpack/src/plugins/vue/modern.js
3.50% <0.00%> (ø)

packages/webpack/src/plugins/vue/util.js
41.66% <0.00%> (-3.79%)
:arrow_down:

packages/webpack/src/plugins/externals.js
2.50% <2.50%> (ø)

packages/webpack/src/plugins/wp5-fix.js
50.00% <50.00%> (ø)

packages/webpack/src/config/base.js
62.26% <60.00%> (-0.24%)
:arrow_down:

... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8c9fa15...ab5527e. Read the comment docs.


Automate Terraform in actions

The management of the Terraform must be automated through the CI/CD system, in this case Actions.
There's a good example here https://github.com/marketplace/actions/hashicorp-setup-terraform

closing since verify-conformance will likely run in an existing cluster


List of known runtime errors

So, if Elm wants to be serious about runtime errors, let's pile all the known ones together so that they can be treated one by one. Some are compiler issues, other are core library issues. Nevertheless, there is value to lumping them all in one big list because a user would care that the core library be as bug-free as the language itself.

[ ] Using toString in records : https://github.com/elm-lang/elm-compiler/issues/897
[ ] Weird tuple error : https://github.com/elm-lang/core/issues/201
[ ] Broken eq on some unicode strings: https://github.com/elm-lang/core/issues/177
[x] Array repeat given negative value : https://github.com/elm-lang/core/issues/175
[ ] toString Json.Encode.null : https://github.com/elm-lang/core/pull/183
[ ] Json.Encode.null == Json.Encode.object [] (and most other cases of comparing null with non-null) elm-lang/core#294
[ ] Recursively defined values : https://github.com/elm-lang/elm-compiler/issues/873

Please do not hesitate to add more to the list. I'll remove them as their respective issues close.

Here's one from #957 (closed in favor of #873):
x : a
x = x

You can make it crash immediately with y = List.head x or put it in a signal to crash later:
bad = Signal.map (\b -> if b then List.head x else Just "foo") Mouse.isDown

And of course you can write a recursive function that never terminates, no polymorphic trickery necessary, and you can't detect it in general:
g : Int -> String
g x = if x < 0 then "done"  else g x

Array.repeat should be fixed by elm-lang/core#258.
Also, there's function equality: x = identity == (\y -> y)
Also, Signal.mergeMany [] but that will be caught immediately and consensus is to leave it.

The value Json.Encode.null makes some trouble, throwing runtime errors in:

[ ] toString Json.Encode.null elm-lang/core#183
[ ] Json.Encode.null == Json.Encode.object [] (and most other cases of comparing null with non-null) elm-lang/core#294

It looks like most of the issues are for core. The only compiler ones are #897 and #873 and I don't think we need a meta issue to track those two. One of them already is a meta issue ;)
So do you mind moving this over to core and just keeping the core issues?

Okay, this needs to be on core. Please move the relevant stuff over to an issue called "meta issue: issues involving potential runtime errors".

Done: https://github.com/elm-lang/core/issues/377

Thank you!

For posterity, because I think I've run across this more than once:
The link posted by @rtfeldman is broken, current link is https://github.com/elm/core/issues/377


Checkbox icon in the wrong position

I don't know if this is only on my browser but the icon seems to be in the wrong position.
https://avocode.com/nachos-ui/docs/#!/Showcase/Checkbox

edit: the same to the radio button

it's okey in my Chrome, anyway how it looks on mobile matters more :)

@herlon214 Thanks for the report. What browser do you use?

I agree with you @vojtatranta , it was just an observation. But someone can think that in the mobile is the same thing maybe.
@petrbrzek my browser is Firefox 51.0.1

yep! same issue here as well Firefox 51.0.1 on Ubuntu

I will look at it but I'm not sure if I can fix it as this depends on React Native for Web.

So we depend on React Native for Web to fix this issue.

FYI your checkbox/radio components aren't accessible on web. I'd suggest building them more like how Switch is implemented in react-native-web.


Added Hacktoberfest HTML/JS program

What the program do ?
Welcome to Hacktoberfest 2018!
In what programming language it is written?
HTML and Javascript

This pull request contains conflicts. Please fix it and reopen


Push Notification when app is in foreground?

Expected Behaviour
should receive notification when app in background and foreground
Actual Behaviour
i am receiving notification when app in background but not when its in foreground
Reproduce Scenario (including but not limited to)
Steps to Reproduce
Platform and Version (eg. Android 5.0 or iOS 9.2.1)
Android 4.4
(Android) What device vendor (e.g. Samsung, HTC, Sony...)
Samsung
Cordova CLI version and cordova platform version
cordova --version                                    # e.g. 6.0.0
cordova platform version android                     # e.g. 4.1.1

Plugin version
cordova plugin version | grep phonegap-plugin-push   # e.g. 1.5.3

Sample Push Data Payload
Sample Code that illustrates the problem
Logs taken while reproducing problem
I tested, push notification code is executing each time when app starts,  Code of initial function
     var push = PushNotification.init(
    { "android": {"senderID": "XXXXXXXXXXXXXXX"
                 },
      "ios": {"alert": "true", "badge": "true", "sound": "true"
             }

    });

// checking if app already have regisrationID
if (localStorage.getItem("push") === null) {
            localStorage.setItem("push", 1);

        push.on('registration', function(data) {
        console.log(data.registrationId);
        //app.alert(data.registrationId);

           //Ajax call to send registration id to server database
            var postData = {senderid: data.registrationId};
                                     $.ajax({
                                      // cache: false,
                                      type: 'POST',
                                      url: "XXXXXXXXXXXXXX.php",
                                      //beforeSend: function() { },
                                      // complete: function(){  },
                                      //dataType: "json",
                                      data: postData,
                                      success: function(data) {
                                         // PROCESS DATA HERE
                                          //app.alert(JSON.stringify(data));

                                      },
                                      error: function(data) {
                                         //PROCESS HERE FOR FAILURE
                                         // return View.Modal.openNotification("Error!"); //console.log(data);
                                         app.alert("Network not found");

                                      }
                                  });
        });
}

        push.on('notification', function(data) {
        console.log(data.message);
        alert(data.title+" Message: " +data.message);
        data.title,
        data.sound,
        data.image,
        data.message
            // data.additionalData
        });

        push.on('error', function(e) {
        console.log(e.message);
        });

to take your data notification in foreground and see your alert ,you can call the method finish() on your function  push.on('notification', function(data). Like that :
push.on('notification', function(data) {
push.finish( function() {
console.log(data.message);
alert(data.title+" Message: " +data.message);
data.title,
data.sound,
data.image,
data.message
// data.additionalData
}
});

i can see alert when its in foreground, but only alert. no sound, no vibration, no alert

@omaismbakop what you are describing is the way the plugin should work. When the app is in the foreground it is up to you to display a dialog, play a sound or vibrate the device.

i make it worked by setting forceShow true like this
`var push = PushNotification.init(
{ "android": {"senderID": "533867441597", "forceShow": "true"
},
"ios": {"alert": "true", "badge": "true", "sound": "true"
}
    });`

Hi @omaismbakop , how about ios ?

Yes, "forceShow": "true" is work for android. What about IOS?
How can i get notification in forground IOS app.

is there any option for force showing notification in iOS app?

I found EBForeNotification, it can show the Banners and Sounds as the same as the system notifications on foreground in ios.
Can someone integrate EBForeNotification into this plugin?


Memory leak in IE?

I have pace.js installed on my blank page and just have it running a get request over and over again and this is what IE is saying is being retained between executions.

Am i just looking at this wrong?

Is there any reason why ajax monitor keeps a record of every XHRRequestTracker but doesn't destroy the tracker?
https://github.com/HubSpot/pace/blob/master/pace.js#L553
AjaxMonitor = (function() {
    function AjaxMonitor() {
      var _this = this;
      this.elements = [];
      getIntercept().on('request', function() {
        return _this.watch.apply(_this, arguments);
      });
    }

    AjaxMonitor.prototype.watch = function(_arg) {
      var request, tracker, type, url;
      type = _arg.type, request = _arg.request, url = _arg.url;
      if (shouldIgnoreURL(url)) {
        return;
      }
      if (type === 'socket') {
        tracker = new SocketRequestTracker(request);
      } else {
        tracker = new XHRRequestTracker(request);
      }
      return this.elements.push(tracker);
    };

    return AjaxMonitor;

  })();

Our backbone SPA slows down after a while in Edge (not in Chrome and FF), after a few hundred ajax requests it becomes unusable. I tracked this issue down and found XHRRequestTracker. I expect this to be the same problem as mentioned here. If I disable Pace, there is no problem.

Unsure if this is the same problem and don't understand why it's only in IE.

Yea i just branched and fixed it. No issues since the fix. Coffee script is a screwy language.

Currently, I fix it as follows.
Pace.on('done', function () {
  Pace.sources[0].elements = [];
});

Is pace.js still being maintained? Is there a release with this hole plugged?


Refactor of layer list to include it in core.

Move the layer list component out of the example.
Created a very minimal vesion of a layer list for core which
has a very stripped DOM representation and no labels.
Rewrote the layer list example with the more complex version
featuring additional controls.

Some findings:

The  was necessary to ensure the store was passed
to child elements of the layer list.
It was not possible to simply override the renderLayer method
of a parent class because `connect()'ed classes wouldn't honour
the override.
Less a finding and more question: moving the layer up and down
could probably be moved to the reducer/actions if it is considered
common enough.  Having the code in the layer list may also be enough
to make the point moot.

Coverage decreased (-0.3%) to 97.683% when pulling 2f1affd38afc5fc277b464dc81a2a8870728c286 on theduckylittle:feature/layers-list into e993fe6c852f0c54e0fea8940219e07a30c13e23 on boundlessgeo:master.

Yes, I wanted to make sure the approach was acceptable to everyone before I started writing tests.  I'll be integrating this feedback and writing tests next.

looks good now code-wise, with tests this is good to go IMHO

Coverage decreased (-0.8%) to 97.465% when pulling d1a5ccf52c9cc1cc9471e8222c7dad91a2c07b93 on theduckylittle:feature/layers-list into 6998e73f72ff872533733de8cf2f44fc84442b58 on boundlessgeo:master.

Tests are built and ready.  Test coverage should creep back to 98+% when finished.

Coverage increased (+0.07%) to 98.326% when pulling fadeb8be19fead1ec04765e26cf5e71afe396084 on theduckylittle:feature/layers-list into 6998e73f72ff872533733de8cf2f44fc84442b58 on boundlessgeo:master.

Coverage increased (+0.07%) to 98.326% when pulling d9b15ac488575963618838f9b704281c1dcfdaf3 on theduckylittle:feature/layers-list into 6998e73f72ff872533733de8cf2f44fc84442b58 on boundlessgeo:master.

Coverage increased (+0.07%) to 98.331% when pulling 8902cf2b8ebb83a96b06f1436cd1f6b6aa373083 on theduckylittle:feature/layers-list into 76408370e74f26f9c3844985c4815d8e37fbefe1 on boundlessgeo:master.


Native UI view to list all comments (similar to tags, etc)

What is the feature you'd like to have?
It would be cool if there was a native UI view that lets us see all comments that a user has added to the decompilation; similar to how we can currently look at tags, etc.
Is your feature request related to a problem?
I know I have added comments to various functions in my decompilation that related to division optimisations that weren't de-optimised (eg. https://github.com/Vector35/binaryninja-api/issues/2043#issuecomment-1569287264 ), but I can't remember where they were to go look them up again now.
Are any alternative solutions acceptable?
Being able to search for comments might be a partial solution, assuming I remembered something about the comment to search for, but that won't always be the case:

https://github.com/Vector35/binaryninja-api/issues/3252

Additional Information:
From @CouleeApps on Slack:

there is not currently an "all comments" list like there is for tags
it would not be hard to script given there are accessors for comments (a bit unwieldy though)
we've wanted to merge comments into tags since... basically as long as tags have existed
turns out comments are harder than expected

ChatGPT suggested this (unverified), which if I had access to the API might work as a workaround in the meantime:
from binaryninja import BinaryView, Function

# Load the current binary view
bv = BinaryView.get_view_of_file("/path/to/your/binary")

# Dictionary to store comments with function names as keys
comments = {}

# Iterate through all functions in the binary view
for func in bv.functions:
  # Initialize an empty list to store comments for the current function
  func_comments = []

  # Iterate through all comments in the function
  for addr, comment in func.comments.items():
    func_comments.append((addr, comment))

  # Add the function's comments to the dictionary
  comments[func.name] = func_comments

# Print the comments
for func_name, func_comments in comments.items():
  print(f"Comments for function {func_name}:")
  for addr, comment in func_comments:
    print(f"  Address: {addr:#x}, Comment: {comment}")

# Save comments to a file
with open("comments.txt", "w") as f:
  for func_name, func_comments in comments.items():
    f.write(f"Comments for function {func_name}:\n")
    for addr, comment in func_comments:
      f.write(f"  Address: {addr:#x}, Comment: {comment}\n")
    f.write("\n")


A large number of self-generated agent mirroring problems

![Uploading image.png…]()
Ubuntu server 22.0.4 LTS
Ambient memory: 128 GB
CPU: 20 nuclear
Use the rancher 2.5.9
A large number of Rancher-Aget mirror starts were generated after the node joined rancher.
The agent DOCKER_URL_arm64=https://github.com/rancher/docker/releases/download/v1.10.3-ros1/docker-1.10.3_arm64
Almost a thousand mirrors in a matter of hours

Hi @eliayng, this doesn't appear to be a documentation issue so I'm going to transfer this to the rancher/rancher repository where you'll likely get better answers.


Add integration tests for camel-quarkus-kafka + sasl

Follow up for https://github.com/quarkusio/quarkus/issues/11411#issuecomment-690987909

Hey @lburgazzoli, I'll ping you Monday when I get back, but just in case: I have moved some of the CKC kafka test infra: https://github.com/apache/camel/pull/4242.
I believe this might give the basics to implement a test on Camel Quarkus as well.

I did this as part of https://github.com/apache/camel-quarkus/commit/6e440e02573a2ae136983454f345424e85cd0083.


Improve representation of strand

The representation of strand as "boolean reverseStrand" in the common.avdl Position record is an uncommon and insufficient way to generally represent strand.  Many genomic features are strand independent and should with a value indicating no strand. Also, programming is more natural when strand is presented as a categorical variable.
Commonly used representations for strand are +/-/. or 1/-1/0.  In my experience, the symbolic version is more intuitive and the numeric version easier to program.
My preference is to use the numeric.

"boolean reverseStrand" sounds clumsy to me too. An enum seems like the natural approach - what would be good values for you?

yes, an enum could be a good approach.
I would suggest pos, neg, none (or it could be nullable for none).
Jerome Kelleher<EMAIL_ADDRESS>writes:

"boolean reverseStrand" sounds clumsy to me too. An enum seems like the natural
approach - what would be good values for you?
—
Reply to this email directly or view it on GitHub.*

How about something like
enum Strand {
  Forward,
  Reverse,
  Independent
}

Closed by #237.


Update PeerDeps

https://github.com/FirebaseExtended/firebase-framework-tools/blob/f9b2ebd7acdd6fc7ad59279b539d187149a2912a/package.json#L63
I keep getting the error:
⚠  functions: package.json indicates an outdated version of firebase-functions. Please upgrade using npm install --save firebase-functions@latest in your functions directory.

It looks like all that is being used from firebase-functions is the Request type. From firebase-functions it is extending the Express type.
/** An express request with the wire format representation of the request body. */
export interface Request extends express.Request {
  /** The wire format representation of the request body. */
  rawBody: Buffer;
}

From that standpoint, I didn't even see rawBody used anywhere in the code. Leaving this lib basically using only the base Express Request type.

Problem: Outdated NPM deps
Error
This error still blocks deployment:
npm ERR! code ERESOLVE
npm ERR! ERESOLVE unable to resolve dependency tree
npm ERR!
npm ERR! While resolving<EMAIL_ADDRESS>npm ERR! Found<EMAIL_ADDRESS>npm ERR! node_modules/firebase-functions
npm ERR<EMAIL_ADDRESS>from the root project
npm ERR!
npm ERR! Could not resolve dependency:
npm ERR! peer<EMAIL_ADDRESS>from<EMAIL_ADDRESS>npm ERR! node_modules/firebase-frameworks
npm ERR<EMAIL_ADDRESS>from the root project
npm ERR!
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.

The current version is "firebase-functions": "^4.3.1",
As mentioned earlier, the only thing that is imported from the firebase-functions package that I can find is the use of the Request type. But it doesn't even need to, as it never uses the extended rawBody object in the repo anyway.
Suggested solution
Remove the hard dep on firebase-functions altogether. Drop it in as a dev-dep or peer-dep with "*" as it is ONLY used for compiler typing, which the consumer won't use anyway.
It should just be a dev dependency, as it is only used for type inference.

We've bumped the version of firebase-functions in a recent release, thanks.


Update README.md

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: fehase sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.


chrome.exe from within symlink/junction fails [windows] [ERROR:sandbox_policy_base.cc(359)]

version 87.0.4280.141-1.1_windows-x64
initial situation:
install via scoop (scoop install ungoogled-chromium) worked fine ("package manager for windows"; builds shim; each new version into new directory and linking to the current)
layout on disk:
C:\Users\user123\scoop\apps\ungoogled-chromium>dir
Directory of C:\Users\user123\scoop\apps\ungoogled-chromium

<DIR>        87.0.4280.141-1
<JUNCTION>   current [C:\Users\user123\scoop\apps\ungoogled-chromium\87.0.4280.141-1]

following issue:
running from C:\Users\user123\scoop\apps\ungoogled-chromium\current>chrome.exe (the symlink/junction dir) as designated will fail to start up properly 💥 and logs into C:\Users\user123\scoop\apps\ungoogled-chromium\current\debug.log:

[0206/151735.730:ERROR:sandbox_policy_base.cc(359)] Failed to add sandbox rule. error = 2, subsystem = 0, semantics = 1, pattern = 'C:\Users\user123\scoop\apps\ungoogled-chromium\current\*.pdb'

🤷
but running directly from C:\Users\user123\scoop\apps\ungoogled-chromium\87.0.4280.141-1>chrome.exe will work ✔
I suspect some internal issue in the code here when executing from within symlink/junction,
to double-check I also tried the "standard chromium (scoop install chromium-dev)" browser and it starts perfectly fine from within a symlink C:\Users\user123\scoop\apps\chromium-dev\current>chrome.exe ✅
😟

What version of Chromium is chromium-dev? Is it newer than that of ungoogled-chromium?

no, same major

dupe of https://github.com/ungoogled-software/ungoogled-chromium-windows/issues/16#issuecomment-551068481.

duplicate of ungoogled-software/ungoogled-chromium-windows#16 (comment).

yes definitely 😢
also broken in 88.0

@BinaryNate Thanks for your information! Given that it is a Chromium issue, I tend to close this issue, especially now that you've filled an issue with Chromium. If at a later time you'll have any new information on it, feel free to keep us informed.
Also let us know if new information arrives, that requires this issue to be re-opened and/or re-evaluated.


feat: update stevedore to 5.1.0

manage dynamic plugins for Python applications - python3
Issue: https://github.com/linuxdeepin/developer-center/issues/5718
Log: update repo

/approve


Fixes #112: continuation token and start after

Description
continuation token is now mapped to key in order to be able to get correct elements in case of removals/uploads.
start after was also fixed to work properly (esp. in case of missing key)
also continuation token and start after now share processing and follow Amazon's "This parameter is valid only in your first request. If the response is truncated, you can specify this parameter along with the continuation-token parameter, and then Amazon S3 ignores this parameter."
Related Issue
Fixes #112: continuation token and start after
Tasks

[x] I have signed the CLA.
[x] I have written tests and verified that they fail without my change.

@agudian how broad should the test coverage be here?

@412b: sorry, I dropped the ball on this. I'd say the tests should recreate the assertions that you described above, to make sure that we don't accidentally break this. An *IT is fine for that.

@agudian no worries :) I've adjusted the test a bit to have start-after in the test as well.
unfortunately it turned out that V1 doesn't support marker, but that's out of the scope of this PR.

@agudian also it looks like I will have to rebase due to changes related to encoding-type...

@agudian ping on this one

Sorry for all the delay, we’re a bit swamped right now. But we’ll see that we find some time this week.


How to extract prefix from phone number

How to extract prefix from phone number?

This is not an issue with the library. Please join the discussion group if you need help using the library. And make sure you specify what you mean by "prefix" because the question has insufficient detail as it stands.


Refactor: use new pricing object

This PR refactors grid and PDP to use new pricing object.
Testing

Verify that prices show correctly on grid and PDP.
On PDP, ensure that the main display price changes as you select different variants/options.

@mikemurray Comments addressed.


helm: Add hubble section

Add hubble section to values.yaml, and add new Hubble-related fields
to the configmap. The configmap has these new hubble-related fields:

hubble-listen-addresses
List of addresses for Hubble to listen to. Disabled if empty.
hubble-default-socket-path
It is set to the first item in hubble-listen-addresses.
hubble-flow-buffer-size
Number of recent flows for Hubble to cache. Default to 4096.
hubble-metrics-server
Address for the metric server to listen to. Disabled if empty.
hubble-metrics
List of metrics to collect.

Ref #9925
Signed-off-by: Michi Mutsuzaki<EMAIL_ADDRESS>

This change is

Coverage increased (+0.01%) to 45.43% when pulling 1ee747af097fef05f937908a7feca771c678e15c on pr/michi/helm into 7a24487c0613e5e356105c3e5fa5c9bb21596f18 on master.

Coverage increased (+0.03%) to 45.447% when pulling 1ee747af097fef05f937908a7feca771c678e15c on pr/michi/helm into 7a24487c0613e5e356105c3e5fa5c9bb21596f18 on master.

I don't see where HUBBLE_DEFAULT_SOCKET_PATH nor HUBBLE_GROUP_NAME are used in the cilium's code base so I assume this is waiting for #10238 to be merged first?

right. these are env variables in hubble that will be available once #10238 is merged, although this pr is not really blocked on it since it doesn't add any hubble-related settings by default unless you specify them in helm command.

test-me-please


Fix for Stack Frame parameters on LLDB

LLDB already appends parameter types to function names in its MI stack
info calls.
Also fixed some spelling errors.
@wiktork @gregg-miskelly @chuckries

LGTM

this fixed is also needed by MDD IOS scenario, LGTM

Does this have anything to do with PR #374 that jackson abandoned?

Yes, This is a workaround for the time being to prevent us from adding the parameters, thus avoiding duplication.

:+1:


Debian specific Dockerfile is not working on Jessie

Last working commit, which works for me is the following:
https://raw.githubusercontent.com/docker/docker-bench-security/930f7ea676bc52a205ea41c72721d5e6a3d4b3ec/distros/Dockerfile.debian
I tried running the build process on Jessie, also with Jessie base image and jessie dependencies, but it won't work as far as I can see.

Hi @fbiaustria and thank you for reporting this. Could you please attach the build error and logs?

This is the stout of the build process, hopefully you can extract the information you need.
I guess the problem is that there is no binary of docker.io for debian stretch available:
"E: Package 'docker.io' has no installation candidate"
docker-bench-security-build.txt

Seems Docker, both docker.io and docker-engine, has been removed from majority of Debian releases.
https://packages.debian.org/search?suite=default&section=all&arch=any&lang=en&searchon=names&keywords=docker
https://packages.debian.org/search?suite=default&section=all&arch=any&lang=en&searchon=names&keywords=docker.io
Will need to use sid.


ui change in home page button is not visible

Description

is not visible clearly
Steps to Reproduce
change in the ui style
Expected Behavior
No response
Actual Behavior
No response
Screenshots
No response
Additional Information
No response
What browser are you seeing the problem on?

[ ] Firefox
[ ] Chrome
[X] Safari
[ ] Microsoft Edge

Checklist

[X] I have checked the existing issues
[X] I have read the Contributing Guidelines
[X] I want to work on this issue. (optional)

please assign this task to me , i have done with making 3 websites for client ,so i am best for it

this issue has been solved, so we are closing this issue.


Monitoring Plan Schema Issue - GroupID

In the Monitoring Plan Schema in element monitoringDefaultData there is a property groupID  (with capital “D”).  In all other uses of "Id" in the schema the "d" is lower case.  groupID needs to be changed to groupId so it's consistent with other uses in the schemas.  Note: the code will also need to be updated to properly handle this property.

This has been already fixed in dev part of CVP's effort to resolve schema issues

This was handled in another MP schema ticket 5863:  https://app.zenhub.com/workspaces/roadmap-5f96fc2121b1e50016c7acce/issues/gh/us-epa-camd/easey-ui/5863


glad: Re-generate files with glad 2.0.6 (reverted)

Changes:

https://github.com/Dav1dde/glad/releases/tag/v2.0.5
https://github.com/Dav1dde/glad/releases/tag/v2.0.6

This broke the builds for Windows (#90879) and macOS with ANGLE (seen on the official buildsystem preparing 4.3-dev6), so I reverted this for now. Will need to look into it more closely to attempt this again.


[Cross Platform] Support adding MRTK to an existing AR Foundation project

MRTK needs to support projects that were begun as an AR Foundation project.
Components that expect specifically named hierarchy objects (ex: MixedRealityPlayspace) should also support the AR Foundation equivalent (AR Session Origin).
Update services to find the playspace object via a Tag
Add prompt to enable customers to choose to update application hierarchy to MRTK's
If yes, replace AR Session Origin, etc with MRTK equivalents
If no, tag the AR Foundation objects with the MRTK tags

The in-progress implementation of ar foundation support seamlessly supports pre-existing AR Foundation scene components and is capable of adding requirements to an already MRTK-configured scene.


[fail to install] npm install verify-rsa-jwt-cloudflare-worker

failed with npm install verify-rsa-jwt-cloudflare-worker
npm ERR! command failed
npm ERR! command sh -c lefthook install
npm ERR! sh: lefthook: command not found
npm ERR!      /Users/tishihara/.npm/_logs/2023-08-29T22_37_10_598Z-debug-0.log

@taro-ishihara Thanks for reporting the issue! I removed the post-install command that caused the issue.
Please try installing it again, the version number is 1.0.5. Please let me know if the problem persists.


T3a instance

Description
The check to establish if an instance type belongs to the t family doesn't work for the new t3a type, so I updated the regexp.

Thank you!
v1.25.0 has been released for Terraform 0.11 users.


[BUG] undefined and null query parameter become part of the URL

$path("/post-review", { id: undefined })

Results in /post-review?id=undefined, though I expect it to return /post-review.

I wouldn’t consider this as a bug. It’s just the behavior of URLSearchParams. You can eliminate undefined fields before passing it to the $path method.


Feature Request: End Cap Radius

Hey, Just wondering if there is a way we could choose an "endCapRadius", similar to the cornerRadius on other elements in MAUI. This in combination with choosing the DialWidth would be very useful to me. It would allow for a rectangle with rounded corners or just a pure rounded end as an "endCap". It would be great if we could set this radius for the start of the progress bar and the end of the progress bar seperately.
Something like this:

Hi @DevonKyleSham,
thanks for your feature request.
Sure, I could implement something like an EndCapRadius for the value indicator. At the moment, the base is drawn as a full circle, so there is no way to set the start and end caps for the base, yet. Note that the radial dial currently doesn't support ranged values, either.
Cheers!


Assignment-01

Name-Namipriya Sarania
Roll no.-202102021004

@sanjibnarzary issue fixed merge the pull request


Input box should not reload when it is empty

Is your feature request related to a problem? Please describe.

If we don't add anything in the input box and click on add collaborators button then the page reloads and give this error:

Describe the solution you'd like
We can enhance the user experience by providing a client side verification of the input box. If there is no value in the input box then we can prevent the reload and add border of red, so that the user knows that it is invalid.
Are you working on this? (Yes/No)
Yes

The issue presented is not a big deal. But there is something better you can work on. Instead of getting the details from the server, why don't you do it in client side only.
Something like this: This will give confidence to the user that it is working.

Or even better something liek this
https://codepen.io/gehadz/pen/PrMNba

@Shivansh2407 any inputs here?

I was thinking like when there is no text present in the Text box, till that time we can disable the button to Add Collaborators. Next, On adding an email ID, for sure we should go with tagging the inputs. Then As we get one or more tag, we can enable the Button and add the Collaborator, this way it solves the empty field issue and also will improve the user experience. Please let me know your views on this @satu0king

Yes just disabling the button is a great idea. Yes https://bootstrap-tagsinput.github.io/bootstrap-tagsinput/examples/ is a good alternative as well.

Note most of these options do not seem to allow the emails to be separated by "space" or "new line" or "tab", this is important because our users might just copy/paste from excel or other sources and the emails may not be separated by comma.

@satu0king and @Shivansh2407, so the final concept is that:-

Emails input should be in the format of the tags.
Button should be enabled only when there are one or more email tags present.
Input box should have the ability to differentiate the emails when 'space', 'new line', or 'tab' is encountered.

Please let me know if this is what you guys wanted.
Note: There can be a delay for this PR as my final exams are coming in December. But I'll make the PR as soon as possible.

@satu0king and @Shivansh2407, so the final concept is that:-

Emails input should be in the format of the tags.
Button should be enabled only when there are one or more email tags present.
Input box should have the ability to differentiate the emails when 'space', 'new line', or 'tab' is encountered.

Please let me know if this is what you guys wanted.
Note: There can be a delay for this PR as my final exams are coming in December. But I'll make the PR as soon as possible.

Did u do this in the PR? the PR seems to disable the button?

yeah @satu0king I am working on this but I also feel like that I should close this PR and create a new one as there are no major changes done on that PR yet and I also want to do a fresh start. So I'm closing this PR now and will make a new one ASAP with the mentioned features. Sorry for the delay.

@satu0king, @aayush-05, @Shivansh2407
Updates:

This is how the tags input will look like:

Now I'm trying to figure out how to do the 3rd step when pasting


APIS place-ids used in event-relations but not retrievable with entity endpoints

In many events APIS-places are linked in relations, but when using the ids to query the backend, the items cannot be found.
There are 1273 places when searching the APIS dataset for entity kind place:
https://intavia-backend.acdh-dev.oeaw.ac.at/v2/api/entities/search?datasets=https%3A%2F%2Fapis.acdh.oeaw.ac.at%2Fdata%23v1&page=1&limit=500&kind=place
There are 6363 places that cannot be found. Those places are retrieved from events that are related to entities, but not directly from event search endpoint, which currently does not work correctly, see https://github.com/InTaVia/InTaVia-Backend/issues/155. Hence, the actual number might be different for all events.
Here a few entries (id + decoded id):
["aHR0cDovL3d3dy5pbnRhdmlhLmV1L2FwaXMvcGxhY2UvMzA4Mw==, b'http://www.intavia.eu/apis/place/3083'",
 "aHR0cDovL3d3dy5pbnRhdmlhLmV1L2FwaXMvcGxhY2UvMTQwNDA=, b'http://www.intavia.eu/apis/place/14040'",
 "aHR0cDovL3d3dy5pbnRhdmlhLmV1L2FwaXMvcGxhY2UvMTA2MTc3, b'http://www.intavia.eu/apis/place/106177'",
 "aHR0cDovL3d3dy5pbnRhdmlhLmV1L2FwaXMvcGxhY2UvMzgyNjQ=, b'http://www.intavia.eu/apis/place/38264'",
 "aHR0cDovL3d3dy5pbnRhdmlhLmV1L2FwaXMvcGxhY2UvNTQxNQ==, b'http://www.intavia.eu/apis/place/5415'",
 "aHR0cDovL3d3dy5pbnRhdmlhLmV1L2FwaXMvcGxhY2UvNzI4MDI=, b'http://www.intavia.eu/apis/place/72802'",
 "aHR0cDovL3d3dy5pbnRhdmlhLmV1L2FwaXMvcGxhY2UvMTQyMDg=, b'http://www.intavia.eu/apis/place/14208'",
 "aHR0cDovL3d3dy5pbnRhdmlhLmV1L2FwaXMvcGxhY2UvMTI3MzAz, b'http://www.intavia.eu/apis/place/127303'",
 "aHR0cDovL3d3dy5pbnRhdmlhLmV1L2FwaXMvcGxhY2UvMTAxODA5, b'http://www.intavia.eu/apis/place/101809'",
 "aHR0cDovL3d3dy5pbnRhdmlhLmV1L2FwaXMvcGxhY2UvODg0ODQ=, b'http://www.intavia.eu/apis/place/88484'",
 "aHR0cDovL3d3dy5pbnRhdmlhLmV1L2FwaXMvcGxhY2UvMTI3MjM4, b'http://www.intavia.eu/apis/place/127238'",
 "aHR0cDovL3d3dy5pbnRhdmlhLmV1L2FwaXMvcGxhY2UvMTA2Njkz, b'http://www.intavia.eu/apis/place/106693'",
 "aHR0cDovL3d3dy5pbnRhdmlhLmV1L2FwaXMvcGxhY2UvMjA4Mjg=, b'http://www.intavia.eu/apis/place/20828'",
... ]

tried some of those with the fixed events and entities endpoint and they resolved. Closing this for now.


Add IRC to the Chat badge list

:clipboard: Description
Show total user count which is provided by the server on connect, like 612 1022 :Current local users 612, max 1022.
Could be displayed as https://img.shields.io/badge/IRC-612 Total users connected-brightgreen.
Users in a channel could be displayed as https://img.shields.io/badge/IRC-612 users in %23alice-brightgreen
:link: Data
The data is provided by the server via telnet or over IRC.
:microphone: Motivation
To show total users on IRC servers/channels.

Thanks for reaching @Strykar but I'm going to close this because it doesn't fit within our guidelines for badges. For our native badges with values populated dynamically from some upstream source, our badge servers need to be able to retrieve the data over http.
The requested badge here would be best supported by leveraging our custom Endpoint badge where whatever custom endpoint you'd implement would be able to get the chat info via whatever means you'd prefer, and  then that endpoint could make that data available over http following our endpoint response schema.


Dividers in menus receive keyboard focus

When navigating through items in a menu using arrow keys, dividers don't get skipped over. Instead, they will receive keyboard focus like any other item. Since dividers serve no purpose other than to visually group menu items, this is a hindrance for keyboard navigation.

[x ] This is not a v0.x issue.
[x ] I have searched the issues of this repository and believe that this is not a duplicate.

Expected Behavior 🤔
Using arrow key navigation in a Menu component should skip over any contained Divider elements when changing focus.
Current Behavior 😯
Divider elements get keyboard focus.
Steps to Reproduce 🕹
Link: https://codesandbox.io/s/q8p57z1j4

Click the Open Menu button.
Press the down arrow key twice.

Your Environment 🌎

Tech
Version

Material-UI
v3.3.2

React
16.4.2

Browser
Chrome, Firefox

TypeScript
2.9.2

@eric-parsons Thank you for opening this issue. We are already aware of this issue, not proud of it. It comes down to an unideal focus implementation logic, that also causes: #10847. I have been discussing it with @RobertPurcea he was proposing an alternative implementation of the MenuList.
class MenuList extends React.Component {
  componentDidMount() {
    if (!this.props.disableAutoFocusItem) {
      this.defaultFocus();
    }
  }

  // focus selected or first child
  defaultFocus = () => {
    const { children } = this.props;

    let indexOfChildToFocus = 0;

    React.Children.forEach(children, (child, index) => {
      if (child.props.selected) {
        indexOfChildToFocus = index;
      }
    });

    this.listRef.children[indexOfChildToFocus].focus();
  }

  handleBlur = event => {
    if (this.props.onBlur) {
      this.props.onBlur(event);
    }
  };

  // TODO: focus a certain kind of elements (up to us, we could focus all elements with a tabIndex, or all focusable elements like buttons, inputs etc.)
  handleKeyDown = event => {
    const key = keycode(event);
    const list = this.listRef;

    const currentFocus = ownerDocument(list).activeElement;

    if (
      (key === 'up' || key === 'down') &&
      (!currentFocus || (currentFocus && !list.contains(currentFocus)))
    ) {
      this.defaultFocus();
    } else if (key === 'down') {
      event.preventDefault();

      if (currentFocus.nextElementSibling) {
        currentFocus.nextElementSibling.focus();
      }
    } else if (key === 'up') {
      event.preventDefault();
      if (currentFocus.previousElementSibling) {
        currentFocus.previousElementSibling.focus();
      }
    }

    if (this.props.onKeyDown) {
      this.props.onKeyDown(event, key);
    }
  };

  render() {
    const { children, className, onBlur, onKeyDown, ...other } = this.props;

    return (
      <List
        role="menu"
        ref={ref => {
          this.listRef = ReactDOM.findDOMNode(ref);
        }}
        className={className}
        onKeyDown={this.handleKeyDown}
        onBlur={this.handleBlur}
        {...other}
      >
        {children}
      </List>
    );
  }
}

It's going in the right direction.

This bug appears to still be occurring, can we re-open this issue?

@Billy- If you can reproduce on v5, please open a new issue with a codesandbox to showcase the problem.


Excel Online (Business) Connector Not Working with Map

Hey all
My team uses an online Spreadsheet which is held on a Sharepoint site.
My intention is to create a map using Power Apps which uses the information in that spreadsheet to plot points on a map, using this functionality.
The Spreadsheet looks something like this, with approx 150 rows.

Suitable
ID
Site Name
Parent Company Name
Site Address
Local Authority
Site Contact
Number of Employees
Work Undertaken
Inventory Check
Last Communication
Last Inventory Check
Last Visit
Notes
Latitude
Longitude
Colour
Icon

Yes
001
A Company Ltd
A Company Ltd
123 Fake Street
South East Authority
John Smith
15
Storage of confectionery
Sent
Holding reply to inventory check received 10/10/2023
05/08/2015
N/A
N/A
51.500529
-0.125140
Green
marker-thick

I have set up the map as so.
When I import that data using the excel static connector, it correctly displays the pins on the map as expected.
However, I am unable to replicate this using the Excel Online (Business) Connector.
When I change the source to the online spreadsheet
No pins are displayed on the app.
In order to attempt to troubleshoot this, I have used the Data Table control (as seen in the screenshots above). This displays the relevant data both when it is pulling the data from the static spreadsheet, and the online spreadsheet. This indicates to me that the connection to the online spreadsheet is good, but for some reason the map is not displaying the information as pins.
In addition, I am able to File > Save the online spreadsheet and then upload that in a static format, and this displays the pins on the map, which reassures me that the data in the sheet and the map are set up correctly.
My hypothesis is that there is therefore some incompatibility with the Excel Online (Business) Connector and the Map.
Does anyone have any suggestions please?

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 381c7d09-3bb9-ae96-14d5-b824cc0e7d49
Version Independent ID: 8cb254ae-7519-593c-bf78-d2bfdcc58f1c
Content: Insert pins from data source - Power Apps
Content Source: powerapps-docs/maker/canvas-apps/geospatial-map-excel.md
Service: powerapps
Sub-service: canvas-maker
GitHub Login: @anuitz
Microsoft Alias: anuitz

Thanks for your comment, @JackCarlin. This issue has been assigned to the doc author for review.


feat(chart): add requestTimeout for core-agent container

Description
Adding helm chart value .agents.core.requestTimeout to be able to configure core agent timeout.
Motivation and Context
This is to resolve #3805 issue.
Regression
No
How Has This Been Tested?
Installed OpenEBS with helm chart to my test environment
Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[x] My code follows the code style of this project.
[x] My change requires a change to the documentation.
[x] I have updated the documentation accordingly.
[ ] I have added unit tests to cover my changes.

bors merge

bors r+

@tiagolobocastro So should I retrigger the build?

@tiagolobocastro So should I retrigger the build?

Yeah I guess so

bors r+

Thanks @oleksandr-shalbanov-fntext !


Add resize modes to image resize node

What type of PR is this? (check all applicable)

[ ] Refactor
[x ] Feature
[ ] Bug Fix
[ ] Optimization
[ ] Documentation Update
[ ] Community Node Submission

Have you discussed this change with the InvokeAI team?

[x ] Yes #5014
[ ] No, because:

Have you updated all relevant documentation?

[ ] Yes
[x ] No: I'm not sure if there is documentation for this to update it.

Description
Add resize mode property to image resize node:

Fill: In this mode, the image is adjusted to completely fill the available space while maintaining its aspect ratio. This means the image may be cropped to fit the desired dimensions. The entire available space is covered, but some parts of the image may be cut off.

Stretch: In this mode, the image is forcibly stretched or squished to fit the specified dimensions, disregarding its original aspect ratio. This can lead to distortion of image as the aspect ratio is not maintained.

Fit: This mode ensures that the entire image fits within the specified dimensions, while maintaining its aspect ratio. The image is resized proportionally to fit entirely within the specified dimensions.

Center: In this mode, the image is centered within the specified dimensions without any scaling or cropping. If the original image is smaller than the specified dimensions, it will be displayed as is, with empty space around it.

Crop: This mode the image is not scaled to fit the specified dimensions. Instead, the original image is inserted into the available space while maintaining its original size. If the specified dimensions are smaller than the original image, part of the image will be cropped.

Related Tickets & Documents

Related Issue #5014
Closes #5014

QA Instructions, Screenshots, Recordings
When selecting the resizing mode the image should look as indicated in the description
Added/updated tests?

[ ] Yes
[ x] No : I do not know how to do this

Thanks for submitting!
Should get a code owner review soon
cc: @hipsterusername @blessedcoolant @psychedelicious

Is the default behavior for this the same as the current resize? I think technically it's 'stretch' right now?
I have not tested this yet, but have some other questions around how it's not allowing dynamic aspect ratio changes in the event that both Width/Height are passed into the resize node.

@VeyDlin Do you anticipate following up on this PR?

Closing due to inactivity