Bradbury Watch

Bradbury Watch, a watchface based on the Seiko Voice Note. Displays time in hours/minutes/seconds, as well as date, day of week, battery percentage, and step count. Touch screen toggles the visibility of widgets.

Nice - thanks!

Nice - thanks!

Hi, I'm still trying to figure things out here. I'm just wondering what the full process is for the app to appear in the official app loader, if there's anything else I need to do. I don't mean to pester you, I just don't really understand the process very well.

No, it's just when I manually push it up - I don't always do it because sometimes there might be something merged that I feel could do with some testing before it goes live. Also generally pushing new changes on Friday and then not looking at email over the weekend always seems like a recipe for disaster :)
I'll try and do it today though.


v2: Add Prompt + media for One Year

Due to the way the v2 Prompts are designed, I should be able to create a record for One Year + all of the media files and treat it just like a normal day (at least from the API's perspective).
Tweet to use for record: https://twitter.com/vss365official/status/1646350607689605121
Word: #OneYear

Prompt date created, full completion pending #251.


Sample Audio before committing to it

With the new menu is it possible to allow a  sound effect to be sampled before selecting it so you don't have to keep reopening the window?

I can look into it.  FYI what I do is just use content/MoM/ffg/audio and pick the file I want first.

That makes sense. I never thought about just sampling the audio from the directory.


Suppress compiler warnings

Related to: https://github.com/MicrosoftDocs/visualstudio-docs/issues/3230

Solution Explorer -> Properties -> Code Analysis Settings:
NOTE: This property page has been deprecated and will be removed in a future product release.

It was possible to also suppress CS1591:Missing XML comment for publicly visible type or member for generated code via that properties page (Solution Explorer -> Properties -> Code Analysis Settings).
How can this be established now?
I have tried the following, but that does not seem to work, as it is a compiler warning and not a code analysis warning?
[assembly: SuppressMessage("Compiler", "CS1591", Justification="Generated Code", Scope="namespaceanddescendants", Target="MyNamespaceContainingGeneratedCode")]
The only option I see at the moment, is to move all generated code to a separate project and just set <noWarn>1591</noWarn> in the project file. A viable option, but it falls short if you want to add your own logic to some of the generated partial classes.
Originally posted by @AroglDarthu in https://github.com/MicrosoftDocs/visualstudio-docs/issues/3230#issuecomment-528384214

Actually I believe this should go to @ghogen.

@AroglDarthu Have you looked at https://docs.microsoft.com/en-us/visualstudio/ide/how-to-suppress-compiler-warnings?view=vs-2019 ?

I did. But it doesn't help. That way warnings can only be suppressed for the entire project or for specific NuGet package references.
The aim is to suppress a specific warning, like CS1591, for generated code only. For instance a ServiceReference. It is not really an option to add pragma disable to the generated code, as it will be overwritten at the next generation.

I think the docs are correct and it's not supported in the current product design. You're welcome to submit a feature request - please file at https://developercommunity.visualstudio.com/spaces/8/index.html?all


[Docs] Duplicate list Items in SCIM API documentation

There are duplicate list items (POST/ Create Group) in the "Groups endpoint" documentation.

Documentation URL:  https://is.docs.wso2.com/en/5.9.0/using-wso2-identity-server/using-the-SCIM-2.0-REST-APIs/#UsingtheSCIM2.0RESTAPIs-Groupsendpoint
Labels:
Priority/High
Type/Doc
Type/Bug
Complexity/Low
Affected/5.9.0-Alpha

This issue is being closed due to extended inactivity. Please feel free to reopen it if further attention is needed. Thank you for helping us keep the issue list relevant and focused!


The current SDK bundles target framework '8.0' which is not supported by MSBuild.Sdk.SqlProj

Hello,
I couldn't build the project on .NET 8 Preview 2. Similar problem to issue #371.
Are there any plans to support early versions of net8.0?

Not yet, but it should be fairly trivial to add.
That being said I think we might want to investigate whether we could produce a single executable that is not framework dependent so that we don't have to add support for each new version of .NET. @jeffrosenberg @ErikEJ Any thoughts on this?

fixed in #413


all(#3) min(#3)  actually they express the same meaning.

hi guys, in the alarm model, all(#3) min(#3)  actually they express the same meaning. I think eliminating  one the them will be great

all(#3) < 100 不等同于 min(#3) < 100

IF not , can you provide an example  that can prove   all(#3) < 100 不等同于 min(#3) < 100

50，120，50
min(#3) < 100 成立
all(#3) < 100 不成立


include Pipelines/NPR_Pipeline.glsl preprocessor error

amd 3700x
32G
P1000
windows 10 64
blender 3.1.2
malt 1.0.0.beta

C:/Users/toloz/Desktop/face/Shader Examples/basic.mesh.glsl:3: error: Can't open include file "Pipelines/NPR_Pipeline.glsl"
#include "Pipelines/NPR_Pipeline.glsl"

from C:/Users/toloz/AppData/Local/Temp/tmpply538s7: 1:    #include "basic.mesh.glsl"

1 error in preprocessor.

I also am getting this error.
System Information
Operating system: Windows-10-10.0.22000-SP0 64 Bits
Graphics card: NVIDIA GeForce RTX 3090/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 516.59
Blender Version
version: 3.2.0, branch: master, commit date: 2022-06-08 10:22, hash: rBe05e1e369187


Better style tools

There is a single list of directories to format in the root CMakeLists.txt. This makes the format tools easier for other projects to use and also keeps UNIX and APPLE directories in sync.
Simplified the scripts, you now need to pass in the absolute path of the directories to fomat, something cmake already knows and the scripts needed to discover.
Minor rewording of progress messages

@diyessi Can you please verify that the macos scripts work as expected?


properly added :zap to android-studio

Added the zap property for android studio.
Got the info from: http://stackoverflow.com/questions/17625622/how-to-completely-uninstall-android-studio

Nice - thanks!


Dragging files from 7Zip File Manager will result in UWP app crash

Describe the bug
I use 7Zip to unzip most of my files, as I'm sure you are aware there are two ways to unzip the files one is to do it through the context menu and the other is by opening the file directly in the 7Zip File Manager (if you need only one file from the zip like in my case). I was trying to export one file but as soon as I dragged the file to the UWP explorer it crashed.
To Reproduce
Steps to reproduce the behavior:

double click on any zip file (like .zip, .rar, .7zip), 7Zip File Manager should open.
Drag any file from the zipped folder to the desktop or the document folder

Expected behavior
UWP App Crash.
Screenshots
If applicable, add screenshots to help explain your problem.
Desktop (please complete the following information):

OS: Windows 10 Business Insider Preview
OS Version: 2004
OS Build: 20241.1005
App version: [v0.11.0]

Additional context
I guess this is something to do with how Windows handles temp files since it got to first unzip them to a temp location and than pull them to the dir you dropped it in.
Log file
here is the most interesting part:
2020-07-20 02:16:34.8786|ERROR|Files.App|Path cannot be the empty string or all whitespace.
Parameter name: path|System.ArgumentException: Path cannot be the empty string or all whitespace.
Parameter name: path
   at System.IO.Directory.GetParent(String) + 0xb3
   at Files.BaseLayout.<>c.<List_DragOver>b__63_0(IStorageItem) + 0x1c
   at System.Linq.Enumerable.Any[TSource](IEnumerable`1, Func`2) + 0xb7
   at Files.BaseLayout.<List_DragOver>d__63.MoveNext() + 0x158
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw() + 0x21
   at System.Runtime.CompilerServices.AsyncMethodBuilderCore.<>c.<ThrowAsync>b__7_0(Object) + 0x1e
   at System.Action`1.Invoke(T) + 0x28
   at System.Threading.WinRTSynchronizationContext.Invoker.InvokeCore() + 0x33
   at System.Runtime.InteropServices.McgMarshal.ThrowOnExternalCallFailed(Int32, RuntimeTypeHandle) + 0x21
   at __Interop.ComCallHelpers.Call(__ComObject, RuntimeTypeHandle, Int32) + 0xb8
   at __Interop.ForwardComStubs.Stub_10[TThis](__ComObject, Int32) + 0x24
   at Microsoft.AppCenter.Utils.ApplicationLifecycleHelper.<.ctor>b__17_1(Object, UnhandledErrorDetectedEventArgs) + 0x3d
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw() + 0x21
   at Microsoft.AppCenter.Utils.ApplicationLifecycleHelper.<.ctor>b__17_1(Object, UnhandledErrorDetectedEventArgs) + 0x75
   at System.EventHandler`1.Invoke(Object, TEventArgs) + 0x2e
   at __Interop.Intrinsics.HasThisCall__23[TArg0](Object, IntPtr, Object, TArg0) + 0x36
   at Files!<BaseAddress>+0x1279be0

log.zip

Duplicate of #2023.


Develop @Services decorator and module.

To develop a service decorator, which allows you to add a decorator on top of a service, in which it can be run similar to a cron, which allows developers to create services that run at scheduled times, this could be to process new changes, clear out old data ore more. I understand that this can be done normally, but this offers an even simpler way to do it by creating a simple designed controller instead, and should/will support threaded functionality.

This was completed in 1.0.0 release.


When I create ssl, I get an error message

`Error: Command failed: . /opt/certbot/bin/activate && pip install --no-cache-dir certbot-dns-aliyun~=0.38.1  && deactivate
WARNING: Retrying (Retry(total=4, connect=None, read=None, redirect=None, status=None)) after connection broken by 'NewConnectionError(': Failed to establish a new connection: [Errno -3] Temporary failure in name resolution')': /simple/certbot-dns-aliyun/
WARNING: Retrying (Retry(total=3, connect=None, read=None, redirect=None, status=None)) after connection broken by 'NewConnectionError(': Failed to establish a new connection: [Errno -3] Temporary failure in name resolution')': /simple/certbot-dns-aliyun/
WARNING: Retrying (Retry(total=2, connect=None, read=None, redirect=None, status=None)) after connection broken by 'NewConnectionError(': Failed to establish a new connection: [Errno -3] Temporary failure in name resolution')': /simple/certbot-dns-aliyun/
WARNING: Retrying (Retry(total=1, connect=None, read=None, redirect=None, status=None)) after connection broken by 'NewConnectionError(': Failed to establish a new connection: [Errno -3] Temporary failure in name resolution')': /simple/certbot-dns-aliyun/
WARNING: Retrying (Retry(total=0, connect=None, read=None, redirect=None, status=None)) after connection broken by 'NewConnectionError(': Failed to establish a new connection: [Errno -3] Temporary failure in name resolution')': /simple/certbot-dns-aliyun/
ERROR: Could not find a version that satisfies the requirement certbot-dns-aliyun~=0.38.1 (from versions: none)
ERROR: No matching distribution found for certbot-dns-aliyun~=0.38.1
at ChildProcess.exithandler (node:child_process:402:12)
at ChildProcess.emit (node:events:513:28)
at maybeClose (node:internal/child_process:1100:16)
at Process.ChildProcess._handle.onexit (node:internal/child_process:304:5)`

I installed it through docker, with the default configuration file and no other options set. What is the reason?

the same error!!

This is a network connectivity issue between your docker container and the outside world. v0.38.1 definitely does exist:
https://pypi.org/project/certbot-dns-aliyun/#history
and I can install it just fine.

同样的错误！！

Just isolate nginx-proxy-manager from other containers by creating new Networks.

这是您的 docker 容器与外界之间的网络连接问题。v0.38.1 确实存在： https: //pypi.org/project/certbot-dns-aliyun/#history 我可以很好地安装它。

Ok thanks I solved the problem by creating new Networks

这是您的 docker 容器与外界之间的网络连接问题。v0.38.1 确实存在： https: //pypi.org/project/certbot-dns-aliyun/#history 我可以很好地安装它。

好的，谢谢，我通过创建新的网络解决了这个问题。
@HKTY569 我也遇到了，你能解释一下怎么解决吗？

mark

这是您的 docker 容器与外界之间的网络连接问题。v0.38.1 确实存在： https: //pypi.org/project/certbot-dns-aliyun/#history 我可以很好地安装它。

Ok thanks I solved the problem by creating new Networks

same problem when i use cloudflare token, it might be a dns problem ,i tried to creat a new bridge network, but it didn't work.
用cloudflare token去做SSL认证的时候也遇到了差不多的问题，然后检查了半天发现是docker内无法解析域名，IP直接访问是正常的，创建新网络也没有解决问题。


fix(biblio): update biblio-actions to citar

biblio-actions now is called citar, and the package comes with
configuration for embark when loaded.
related issues:
Fixes #5723
related pull request(which is not needed as citar takes care of (add-to-list 'embark-keymap-alist '(bib-reference . citar-map)) when package is loaded:
https://github.com/hlissner/doom-emacs/pull/5747

#5795 created to meet the requirement


FIX: Bookmarks link in Mobile View

[x] FIX Mobile View
[x] Add screenshots

🚀 Your domain available in https://preview-wibu-12.surge.sh


Create better error messages on kctf-config-create (Bad error message with bad zone name)

$ kctf-config-create --chal-dir $CHAL_DIR --project $PROJECT --start-cluster --zone europe-west-1b

[...]
Context "nocluster" modified.
Switched to context "nocluster".
ERROR: (gcloud.container.clusters.list) The required property [project] is not currently set.
You may set it for your current workspace by running:

  $ gcloud config set project VALUE

or it can be set temporarily by the environment variable [CLOUDSDK_CORE_PROJECT]

The issue is that the zone has a typo, it should be europe-west1-b and not europe-west-1b. The error message is misleading as it talks about the project.

thanks for the bug report!

This now gives the error:
ERROR: (gcloud.container.clusters.create) ResponseError: code=403, message=Permission denied on 'locations/europe-west-1b' (or it may not exist).

This now gives the error:
ERROR: (gcloud.container.clusters.create) ResponseError: code=403, message=Permission denied on 'locations/europe-west-1b' (or it may not exist).


validate: improve ValidateHTTPHeaderValue

Please provide a description of this PR:
fixes: #42749

@zirain: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

release-notes_istio
f277f6ad6757b9c332e5b8a715e79e0579c22878
link
true
/test release-notes

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@zirain: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

lint_istio
cc2ea833411791f937d80f43e343ca3fa2a2c316
link
true
/test lint

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@zirain: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

lint_istio
cc2ea833411791f937d80f43e343ca3fa2a2c316
link
true
/test lint

gencheck_istio
cc2ea833411791f937d80f43e343ca3fa2a2c316
link
true
/test gencheck

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

In response to a cherrypick label: new pull request created: #43390

In response to a cherrypick label: new pull request created: #43391

In response to a cherrypick label: new pull request could not be created: failed to create pull request against istio/istio#release-1.16 from head istio-testing:cherry-pick-42778-to-release-1.16: status code 422 not one of [201], body: {"message":"Validation Failed","errors":[{"resource":"PullRequest","code":"custom","message":"A pull request already exists for istio-testing:cherry-pick-42778-to-release-1.16."}],"documentation_url":"https://docs.github.com/rest/reference/pulls#create-a-pull-request"}


Add serde roundtrip test for rpc types

Describe the feature
add tests for main rpc types like Block, Transaction, Log, etc... that do

serde_json::to_string
serde_json::from_str
assert_eq(deserialized, input)

Additional context
No response

I would like to take this.


Update to latest version of https://github.com/SSLMate/go-pkcs12

This new version includes a
pkcs12.DecodeChain
which will help in testing https://github.com/jetstack/cert-manager/pull/3146
NONE

/lgtm
/approve

@wallrj seems you forgot to let bazel update the SHA

/lgtm

/kind cleanup


virt-api: validate labels with kubevirt.io prefix upon VMI creation

Creation of VMI with "kubevirt.io" prefixed labels should be restricted to kubevirt components
such as API, controller and handler. This PR restricts it by validating the account name
of the creation request originator. Currently there is an exception that allows non kubevirt user to create
VMI with labels such as: "kubevirt.io/os", "kubevirt.io/vm" and "kubevirt.io/flavor"
These labels are already used by VM templates and not by the KV code.
Signed-off-by: Igor Bezukh<EMAIL_ADDRESS>What this PR does / why we need it:
To prevent situations that may lead to VMI state inconsistency. For example if it will be allowed to craft
kubevirt.io/nodename label with incorrect value, it will lead to inconsistent VMI state between the controller and the handler.
Which issue(s) this PR fixes
Fixes #
https://bugzilla.redhat.com/show_bug.cgi?id=1843456
Restrict VMI creation with kubevirt.io prefixed labels

What about kubevirt.io/ignitiondata?

@xpivarc That's an annotation. The suggested restrictions are on labels.

kubevirt.io/created-by

What about kubevirt.io/ignitiondata?

@xpivarc That's an annotation. The suggested restrictions are on labels.

Sorry,  I often take them as equals. Is there a reason to not use a blacklist instead of a whitelist?(As only one label can do damage now, AFAIK) We have kubevirt.io/ labels in examples on official pages and this would break them. I would generally be more inclined to be less restrictive. WDYT?
Note: tests must be corrected because they use kubevirt.io/ labels.

kubevirt.io/created-by

What about kubevirt.io/ignitiondata?

@xpivarc That's an annotation. The suggested restrictions are on labels.

Sorry, I often take them as equals. Is there a reason to not use a blacklist instead of a whitelist?(As only one label can do damage now, AFAIK) We have kubevirt.io/ labels in examples on official pages and this would break them. I would generally be more inclined to be less restrictive. WDYT?
Note: tests must be corrected because they use kubevirt.io/ labels.

@xpivarc Thanks for the notice about the tests. Indeed, I need to update the VMI preset test suite. @rmohr @stu-gott @fabiand What do you think? Should we use a blacklist or a whitelist?

/assign @davidvossel @stu-gott

@xpivarc kubevirt.io/created-by is a label that should not be created by users, as mentioned here
In general we need to decide whether we restrict the whole kubevirt.io domain or we can use subdomain like internal.kubevirt.io for internal use-cases

I think that we probably should separate the kubevirt labels that are used by kubevirt components and labels that are used by users. Just like the kubernetes.io/ and k8s.io/ prefixes are reserved for K8s core components. It makes this change more complicated and we should also consider a deprecation notice first, before we actually enforce this. We will need to support another type of label for user configuration. Or, maybe add a subname to the label? kubevirt.io/core for the core components and then the user can use anything else for configurations?

I think that we probably should separate the kubevirt labels that are used by kubevirt components and labels that are used by users. Just like the kubernetes.io/ and k8s.io/ prefixes are reserved for K8s core components. It makes this change more complicated and we should also consider a deprecation notice first, before we actually enforce this. We will need to support another type of label for user configuration. Maybe even consider moving our user-configured labels to proper CR fields?

@danielBelenky Looks like a temporary approach will be to do a blacklist for internal labels, and bring up this subject to community discussion for a long term solution, WDYT?

I think that we probably should separate the kubevirt labels that are used by kubevirt components and labels that are used by users. Just like the kubernetes.io/ and k8s.io/ prefixes are reserved for K8s core components. It makes this change more complicated and we should also consider a deprecation notice first, before we actually enforce this. We will need to support another type of label for user configuration. Maybe even consider moving our user-configured labels to proper CR fields?

@danielBelenky Looks like a temporary approach will be a blacklist for internal labels, and bring up this subject to community discussion for a long term solution, WDYT?

Let's block labels that we know that cause an issue for now. About the other kubevirt.io/ labels, since it's a user facing API, we should be more careful with it. I think that once we decide on a plan (i.e: replacing kubevirt.io/ with some other label, moving those settings to a fields on the CR, ...) we can share it with the community and gather feedback.

@danielBelenky @xpivarc I've updated the PR with the new relaxed approach, now we allow creation unless we hit the list of internal labels.

I think that we probably should separate the kubevirt labels that are used by kubevirt components and labels that are used by users. Just like the kubernetes.io/ and k8s.io/ prefixes are reserved for K8s core components. It makes this change more complicated and we should also consider a deprecation notice first, before we actually enforce this. We will need to support another type of label for user configuration. Maybe even consider moving our user-configured labels to proper CR fields?

Let's tackle it like k8s does. k8s says you should not use labels with such a prefix since it is reserved for k8s itself but it is not blocking you. I think we should block internally used labels to avoid surprises, but let's just ignore the rest. We should probably still write to kubevirt-dev and update the docs that people should not use them, even if we don't block it. Ideally our components would also be able to handle weird entities and not crash at least.
@enp0s3 @danielBelenky what do you think?

I think that we probably should separate the kubevirt labels that are used by kubevirt components and labels that are used by users. Just like the kubernetes.io/ and k8s.io/ prefixes are reserved for K8s core components. It makes this change more complicated and we should also consider a deprecation notice first, before we actually enforce this. We will need to support another type of label for user configuration. Maybe even consider moving our user-configured labels to proper CR fields?

Let's tackle it like k8s does. k8s says you should not use labels with such a prefix since it is reserved for k8s itself but it is not blocking you. I think we should block internally used labels to avoid surprises, but let's just ignore the rest. We should probably still write to kubevirt-dev and update the docs that people should not use them, even if we don't block it. Ideally our components would also be able to handle weird entities and not crash at least.
@enp0s3 @danielBelenky what do you think?

@rmohr @danielBelenky sounds legit to me.

Igor, would you mid adding a user-guide documentation about these specific
white listed labes? Or should we remove them on the long run?

Igor, would you mid adding a user-guide documentation about these specific white listed labes? Or should we remove them on the long run?

I think it makes sense to add some documentation regarding this. I concur with @rmohr's idea: we should be advertising that nothing with a "kubevirt.io/" prefix should be used--even if we don't specifically respond to or block it.

Code looks good overall. @danielBelenky's requested changes make sense.

Igor, would you mid adding a user-guide documentation about these specific white listed labes? Or should we remove them on the long run?

@fabiand Sure. I will add it in a separate PR

/lgtm
Nice job @enp0s3!

/retest

/approve

/cherry-pick release-0.30


Update tapir-core, tapir-http4s-server, ... to 0.17.15

Updates

com.softwaremill.sttp.tapir:tapir-core
com.softwaremill.sttp.tapir:tapir-http4s-server
com.softwaremill.sttp.tapir:tapir-json-circe
com.softwaremill.sttp.tapir:tapir-openapi-circe-yaml
com.softwaremill.sttp.tapir:tapir-openapi-docs
com.softwaremill.sttp.tapir:tapir-swagger-ui-http4s

from 0.17.14 to 0.17.15.
GitHub Release Notes - Version Diff
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "com.softwaremill.sttp.tapir" } ]

labels: library-update, semver-patch

Codecov Report

Merging #90 (afc3098) into develop (ef3da52) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop      #90   +/-   ##
========================================
  Coverage    52.56%   52.56%
========================================
  Files            5        5
  Lines           78       78
========================================
  Hits            41       41
  Misses          37       37

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ef3da52...afc3098. Read the comment docs.


Swift compiler crash in swift-composable-architecture 0.55.0

Description
Just upgraded to 0.55.0 due to issue #2244 and now getting an error building my app.  I don't think this is a TCA bug per-se, because the swift compiler seems to be crashing, however I'm wondering if other people are getting it.  On Xcode 14.2 at the moment and can't upgrade yet for unrelated reasons.
Checklist

[X] I have determined whether this bug is also reproducible in a vanilla SwiftUI project.
[ ] If possible, I've reproduced the issue using the main branch of this package.
[X] This issue hasn't been addressed in an existing GitHub issue or discussion.

Expected behavior
Project should compile
Actual behavior
Compiler crashes
Steps to reproduce
No response
The Composable Architecture version information
0.55.0
Destination operating system
n/a
Xcode version information
14.2
Swift Compiler version information
Stack dump:
0.		Apple Swift version 5.7.2 (swiftlang-<IP_ADDRESS>.5 clang-14<IP_ADDRESS>)
2.	Compiling with the current language version
3.	Running pass 'Function Pass Manager' on module '/Users/jlew/Library/Developer/Xcode/DerivedData/DKTuistApps-edxhcjufhupdizfxegkyhbtwqnvw/Build/Intermediates.noindex/swift-composable-architecture.build/Dev-Debug-iphonesimulator/ComposableArchitecture.build/Objects-normal/arm64/NavigationStackStore.o'.
4.	Running pass 'AArch64 Instruction Selection' on function '@"$s22ComposableArchitecture10StackStateV4path33_E04988F2910E2B9A730B0271B047AEFCLLAC8PathViewAELLVyx_GvM"'
Stack dump without symbol names (ensure you have llvm-symbolizer in your PATH or set the environment var `LLVM_SYMBOLIZER_PATH` to point to it):
0  swift-frontend           0x00000001051c35b0 llvm::sys::PrintStackTrace(llvm::raw_ostream&, int) + 56
1  swift-frontend           0x00000001051c25b4 llvm::sys::RunSignalHandlers() + 112
2  swift-frontend           0x00000001051c3c34 SignalHandler(int) + 344
3  libsystem_platform.dylib 0x000000019aaec2a4 _sigtramp + 56
4  libsystem_pthread.dylib  0x000000019aabdcec pthread_kill + 288
5  libsystem_c.dylib        0x000000019a9f62c8 abort + 180
6  swift-frontend           0x0000000100817b70 PrettyStackTraceFrontend::~PrettyStackTraceFrontend() + 0
7  swift-frontend           0x00000001051224c8 llvm::report_fatal_error(llvm::Twine const&, bool) + 280
8  swift-frontend           0x000000010270b6c4 llvm::SelectionDAGISel::CannotYetSelect(llvm::SDNode*) + 1040
9  swift-frontend           0x000000010270ae24 llvm::SelectionDAGISel::SelectCodeCommon(llvm::SDNode*, unsigned char const*, unsigned int) + 15204
10 swift-frontend           0x00000001023322e8 (anonymous namespace)::AArch64DAGToDAGISel::Select(llvm::SDNode*) + 31780
11 swift-frontend           0x0000000102705bb4 llvm::SelectionDAGISel::CodeGenAndEmitDAG() + 2852
12 swift-frontend           0x00000001027037f8 llvm::SelectionDAGISel::SelectAllBasicBlocks(llvm::Function const&) + 8928
13 swift-frontend           0x0000000102700588 llvm::SelectionDAGISel::runOnMachineFunction(llvm::MachineFunction&) + 3212
14 swift-frontend           0x0000000102d7d058 llvm::MachineFunctionPass::runOnFunction(llvm::Function&) + 308
15 swift-frontend           0x0000000104f27744 llvm::FPPassManager::runOnFunction(llvm::Function&) + 1292
16 swift-frontend           0x0000000104f2dc50 llvm::FPPassManager::runOnModule(llvm::Module&) + 60
17 swift-frontend           0x0000000104f27ec8 llvm::legacy::PassManagerImpl::run(llvm::Module&) + 1088
18 swift-frontend           0x0000000100bded50 swift::performLLVM(swift::IRGenOptions const&, swift::DiagnosticEngine&, llvm::sys::SmartMutex<false>*, llvm::GlobalVariable*, llvm::Module*, llvm::TargetMachine*, llvm::StringRef, swift::UnifiedStatsReporter*) + 3392
19 swift-frontend           0x000000010080f000 performCompileStepsPostSILGen(swift::CompilerInstance&, std::__1::unique_ptr<swift::SILModule, std::__1::default_delete<swift::SILModule> >, llvm::PointerUnion<swift::ModuleDecl*, swift::SourceFile*>, swift::PrimarySpecificPaths const&, int&, swift::FrontendObserver*) + 3676
20 swift-frontend           0x00000001008107a0 swift::performFrontend(llvm::ArrayRef<char const*>, char const*, void*, swift::FrontendObserver*) + 5932
21 swift-frontend           0x00000001007b1294 swift::mainEntry(int, char const**) + 3940
22 dyld                     0x000000019a793e50 start + 2544
Command SwiftCompile failed with a nonzero exit code

Hi @jslew, sorry to hear. I haven't see this unfortunately. Are you able to reproduce in a simple project so that we can see the problem?
And have you tried cleaning the project to see if that fixes it?

Trying to repro in a test app, so far no luck reproducing in that scenario.
For reasons too complicated to get into, we are integrating TCA and
dependencies as dynamic frameworks (using tuist) so looking into whether
that might be triggering anything bad.
On Thu, Jun 29, 2023 at 2:45 PM Brandon Williams @.***>
wrote:

Hi @jslew https://github.com/jslew, sorry to hear. I haven't see this
unfortunately. Are you able to reproduce in a simple project so that we can
see the problem?
And have you tried cleaning the project to see if that fixes it?
—
Reply to this email directly, view it on GitHub
https://github.com/pointfreeco/swift-composable-architecture/issues/2245#issuecomment-1613627894,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AC3T5WGNE3IR3QHW5W3TGCLXNXEN7ANCNFSM6AAAAAAZY3TJL4
.
You are receiving this because you were mentioned.Message ID:
@.***
com>

And yeah definitely tried cleaning, derived data, and all those usual
suspects.  the swiftc crash is happening to someone else on my team too,
identically.  I will see if I can switch to Xcode 14.3 (which we can
probably use to build this but not our main app unfortunately) and see if
there's any change there.
On Thu, Jun 29, 2023 at 2:45 PM Brandon Williams @.***>
wrote:

Hi @jslew https://github.com/jslew, sorry to hear. I haven't see this
unfortunately. Are you able to reproduce in a simple project so that we can
see the problem?
And have you tried cleaning the project to see if that fixes it?
—
Reply to this email directly, view it on GitHub
https://github.com/pointfreeco/swift-composable-architecture/issues/2245#issuecomment-1613627894,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AC3T5WGNE3IR3QHW5W3TGCLXNXEN7ANCNFSM6AAAAAAZY3TJL4
.
You are receiving this because you were mentioned.Message ID:
@.***
com>

Hey @mbrandonw,
I've isolated the problem to these few lines of code from NavigationStackStore.swift:
fileprivate var path: PathView {
    _read { yield PathView(base: self) }
    _modify {
      var path = PathView(base: self)
      yield &path
      self = path.base
    }
    set { self = newValue.base }
  }

If I change the _read/_modify parts to  a typical get { PathView(base:self) }, the compiler crash disappears.
I have never used that construct myself, so I don't know if it would be possible/reasonable to try changing this in some way (I'm assuming a straight get is not correct).

Figured it out.  Disabling incremental compilation for the package within my target sorts it out (who knows why).  But I'll take it, and def. not your problem.
Thanks!

That is still very strange though. And this did not happen in 0.54.0 of the library?
The lines with the _read and _modify were there in 0.54.0, so strange that it would start acting up now.

We skipped from 0.53.2 -> 0.55.0 so I haven't tried 54.  I would guess that it happens there too.

SwiftCompile normal arm64 Compiling\ NavigationStackStore.swift,\ Popover.swift,\ PresentationModifier.swift,\ Sheet.swift,\ SwitchStore.swift
These files all crop up with the same problem under incremental compiler in Xcode 14.2.  Same solution works, Xcode 14.3 doesn't seem to have this issue, so probably not worth digging into much more.

Since _read and _modify are optimizations that haven't been made official yet, and because we've seen they can lead to compiler crashes like the one you're seeing, we could maybe consider using get and set instead.


[3.2] [HTML5] Fix HTTPClient request_raw.

Now send data according to the spec, properly handle null data.
Simplify JS code since we are at it.
3.2 version of #45888

Thanks!


Contact Form UI Improvement

Is your improvement related to a problem? Please describe.
Contact Form filling issue (due to poor UI)
Describe the improvement you'd like
Improve UI by styling and giving finishing UI with CSS
Why should this improvement be made?
To make better UI
Additional context

Has this improvement been discussed before?
Please provide a link to the issue.
NO
Does the feature change existing behavior?
NO

Hi @kailashchoudhary11 can you please assign this issue to me.

@anubhav2102 Would you like to work on it?

@syedjafer Please join our discord server I can assign you some issues over there and you can make a PR directly

@kailashchoudhary11 Please assign it to me and also add hacktober label.

@anubhav2102  you can start working on it but please complete it today itself! Also we have made some improvements already

@syedjafer Please join our discord server I can assign you some issues over there and you can make a PR directly

sure @kailashchoudhary11


Suggestions for everything else

In accord with previous suggestions and PRs
not should definitely be cap
is should be lowkey
list should be bangers and you can only have unique bangers in an album
and other suggestions I think go with the lingo

I'm not sure that "cap", "lowkey", "bangers", or "album" qualify as brainrot, since these terms have been in common use for at least the past five years, especially "album" has been around for ages.

@shamith09 Pinging you here since I can't make branches without permissions (and therefore can't create a PR). There's a bug in the parser in cases where pygyat tokens that are inside of strings are incorrectly handled (ex. us-east-1 -> usdont_use_-_use_fanum taxeastdont_use_-_use_fanum tax1).
I have a fix in a local branch I can push up if you want to grant me permissions 🤟

@shamith09 Hahah fair!

@shamith09 Pinging you here since I can't make branches without permissions (and therefore can't create a PR). There's a bug in the parser in cases where pygyat tokens that are inside of strings are incorrectly handled (ex. us-east-1 -> usdont_use_-_use_fanum taxeastdont_use_-_use_fanum tax1).
I have a fix in a local branch I can push up if you want to grant me permissions 🤟

@branyip Fork this repo, push your changes in that and create a PR to this from there, it'll work just fine

+1, @branyip thanks for the flag, I would love to take a look at your fix!


chore: remove unless conf.json

Please answer these questions before submitting a pull request

Why submit this pull request?

[ ] Bugfix

[x] New feature provided

[ ] Improve performance

[ ] Backport patches

Related issues #264

New feature or improvement

Describe the details and related test reports.

Remove unless conf.json file.

Codecov Report

Merging #267 (3d09201) into master (da009dd) will increase coverage by 48.32%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##           master      #267       +/-   ##
============================================
+ Coverage   51.67%   100.00%   +48.32%
============================================
  Files          35         1       -34
  Lines        2359         1     -2358
============================================
- Hits         1219         1     -1218
+ Misses        982         0      -982
+ Partials      158         0      -158

Impacted Files
Coverage Δ

pkg/ingress/apisix/plugin.go

pkg/apisix/upstream.go

pkg/kube/translation/ingress.go

pkg/log/default_logger.go

pkg/types/errors.go

pkg/id/idgen.go

pkg/ingress/apisix/route.go

pkg/seven/conf/conf.go

pkg/api/server.go

pkg/apisix/cluster.go

... and 24 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update da009dd...3d09201. Read the comment docs.


Debug tracing/log emitted to stdout during flashing using probe-rs-cli

Describe the bug
When using probe-rs-cli download, only errors are supposed to be emitted to stdout by default, but when calling functions in the flash algorithm loaded to the target, some debug messages are emitted anyway. The output seems to be large enough to slow down flashing significantly.
To Reproduce
The binary and chip do not matter.
(fish) cargo install probe-rs-cli --locked
(fish) probe-rs-cli --version
probe-rs CLI 0.14.2
git commit: crates.io
(fish) probe-rs-cli download --chip ATSAME51N20A --format bin --connect-under-reset (head --bytes=32768 /dev/zero | psub)
     Erasing sectors ⠁ [00:00:00] [---------------------------------------------------------]       0B/32.00 KiB @       0B/s (eta 0s )
 Programming pages   ⠁ [00:00:00] [---------------------------------------------------------]       0B/32.00 KiB @       0B/s (eta 0s )DEBUG probe_rs::flashing::flasher: content of PC 0xf: 0x20000020 should be: 0x20000021
DEBUG probe_rs::flashing::flasher: content of a1 0x0: 0x00000000 should be: 0x00000000
DEBUG probe_rs::flashing::flasher: content of a2 0x1: 0x00000000 should be: 0x00000000
DEBUG probe_rs::flashing::flasher: content of a3 0x2: 0x00000001 should be: 0x00000001
DEBUG probe_rs::flashing::flasher: content of R9 0x9: 0x200000c0 should be: 0x200000c0
DEBUG probe_rs::flashing::flasher: content of SP 0xd: 0x200002e8 should be: 0x200002e8
DEBUG probe_rs::flashing::flasher: content of LR 0xe: 0x20000001 should be: 0x20000001
DEBUG probe_rs::flashing::flasher: content of PC 0xf: 0x20000048 should be: 0x20000049
DEBUG probe_rs::flashing::flasher: content of a1 0x0: 0x00000000 should be: 0x00000000

Expected behavior
No DEBUG logs on stdout.
Additional context
I reduced the cause down to this issue in tracing. The reason why the tracing event emitted in call_function is affected is that it calls read_core_reg (which uses #[tracing::instrument]) inside an event formatting macro.

Thanks for looking into this! Seems to have involved some work.
We can work around this in probe-rs, but thanks for also reporting it upstream.


MT:Cleaned Notebook to reproduce results

MT poster
-Cleaned Notebook to reproduce results
-Figures

I am happy with this.


nix: fix build on darwin

Description of changes
https://github.com/NixOS/nixpkgs/pull/275620#issuecomment-1877132615
Why does reverting #277471 fix the issue on my machine???? 😱
Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[x] x86_64-darwin
[x] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

@ofborg build nix nix.passthru.tests

Superseded by #278802.


[WIP] Refactor cache code

This is mostly refactor of the current code.

Forgot to mention, this is a good opportunity to add tests for the Cache package.

retest this please.


Add an isStore export to halyard/store

Syntax
isStore(test: any): boolean

Returns true if the test value is an instance of a store.
Why
It is often very useful to know if a value is a store or not.

While isStore would probably just check if the test value is a readable store (only has the get and subscribe methods) there could also be a isWritableStore function that checks if the test value is a writable store (also has the set and update methods).


Does not work correctly using Windows/PowerShell

Following this https://github.com/MoOx/phenomic/issues/589#issuecomment-242885411

As mentioned in #589, this issue seems to be related to webpack/webpack#2362. The latter issue suggests that nodejs on windows handles drive letters in paths inconsistently, webpack considers f:\foo and F:\foo 2 different paths. Those two behavior together causes this issue.
To make things weirder, additional tests I just did suggests that phenomic works in cmd.exe regardless of the capitalization of the drive letter. So something else is going on with PowerShell's environment.
Maybe we could just wait for webpack or node.js to address this issue and see if this problem will go away?

Probably :)

Will check that later with v1.


Update the png extension.

Since it was capitalized, it wasn’t able to load. Resolve #1
Changing also the name file from .PNG to .png on the actual icon works aswell after my testing.

Yeah, I ran into this issue as well. Maybe it only affects case-sensitive file systems (like most on Linux).

I also ran into this issue (on Ubuntu Linux).

I'm sorry i didn't see this. I am working to update this and will fix this.


New package: Terminators v0.0.2

Registering package: Terminators
Repository: https://github.com/tkf/Terminators.jl
Created by: @tkf
Version: v0.0.2
Commit: 370f05aa6a589c9dea66bf93e20a48762071be41
Reviewed by: @tkf
Reference: https://github.com/tkf/Terminators.jl/commit/370f05aa6a589c9dea66bf93e20a48762071be41#commitcomment-54813905

Sorry, this was a mistake. The correct request is #42761. Please close this PR.


[Bug]: HYPOTHESIS does not include in DockerImage

What happened?
Hi, I have implemented Basic RBAC on Chroma following this documentation https://docs.trychroma.com/deployment/auth.
However, when I deployed, I received an error stating No module named 'hypothesis' when exporting the environment variable CHROMA_SERVER_AUTHZ_PROVIDER="chromadb.auth.simple_rbac_authz.SimpleRBACAuthorizationProvider". I checked the Docker image and Dockerfile and found that they don't include the Hypothesis library. It's only present in requirements_dev.txt.
Versions
Chroma0.5.0, Python3.11
Relevant log output
No response

@cin-logan, thanks for reporting this. You are right that the RBAC Provider does indeed include some test artifacts:
https://github.com/chroma-core/chroma/blob/ec2e717a2d20f29db73eaae7d85e5f99ef7a810e/chromadb/auth/simple_rbac_authz/__init__.py#L19-L21
I believe these were added to fix slow test executions. We'll look into how to remove the dependency.

This is now fixed in 0.5.3. Thanks for reporting!


sdl viewer readme

just a few lines of docs to document recent user issues

PTAL @feuerste

I think we should either keep all information in the top level README.md, since there already is quite some information about the sdl viewer, or move everything to this one

I think #287 made it obsolete


x/review: git codereview mail uses wrong email

What version of Go are you using (go version)?

$ go version

go version go1.12.1 darwin/amd64

Does this issue reproduce with the latest release?
N/A
What operating system and processor architecture are you using (go env)?
go env Output
$ go env
GOARCH="amd64"
GOBIN=""
GOCACHE="/Users/rileykarson/Library/Caches/go-build"
GOEXE=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="darwin"
GOOS="darwin"
GOPATH="/Users/rileykarson/go-workspace"
GOPROXY=""
GORACE=""
GOROOT="/Users/rileykarson/homebrew/opt/go/libexec"
GOTMPDIR=""
GOTOOLDIR="/Users/rileykarson/homebrew/opt/go/libexec/pkg/tool/darwin_amd64"
GCCGO="gccgo"
CC="clang"
CXX="clang++"
CGO_ENABLED="1"
GOMOD=""
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -fdebug-prefix-map=/var/folders/81/zf5_7yzn1sxg_7kfkqsvgclw00cn8c/T/go-build474690330=/tmp/go-build -gno-record-gcc-switches -fno-common"

What did you do?

git codereview mail

Following this guide: https://code.googlesource.com/gocloud/+/refs/heads/master/CONTRIBUTING.md#contributing
git log:
commit 795c92268c930c8714d3b6a4bfe1a173a1858b4a (HEAD -> add-storage-type-to-read)
Author: Riley Karson<EMAIL_ADDRESS>Date:   Thu Sep 19 09:53:40 2019 -0700

    bigtable: Add StorageType to ClusterInfo

    Change-Id: I7120f3ae6c4e5fdb48744613cd222eef317d841e

What did you expect to see?
Success, using my Git email on this machine<EMAIL_ADDRESS>What did you see instead?
$ git codereview mail
fatal: remote error: PERMISSION_DENIED The caller does not have permission
[type.googleapis.com/google.rpc.LocalizedMessage]
locale: "en-US"
message: "No Contributor Agreement on file for user Riley Karson<EMAIL_ADDRESS>(id=17848)"

[type.googleapis.com/google.rpc.RequestInfo]
request_id: "1002a9a0037c424fbd703c9708d4ae78"

[type.googleapis.com/google.rpc.RequestInfo]
request_id: "677d29bf9bf940e0aa432dedde6dff78"

(running: git push -q origin HEAD:refs/for/master)
/Users/rileykarson/go-workspace/bin/git-codereview: exit status 128

Does the same message appear if you try to upload the change directly via:
git push origin HEAD:refs/for/master
?

Ah, yep.
It looks like the value is being sourced from my .gitcookies file when I'd used that email to get a token for a go get cookie months back. Removing it from there caused the correct email to be used.

Closing as it seems that this is not an issue with git-codereview. Please comment if you feel that’s not the case.


Errors occurring when running scenes

I am receiving the following errors every time I send a command
https://graph-na04-useast2.api.smartthings.com/ide/logs#90dbcd53-e1e3-40a9-8e3a-d3af55a032e9 3:48:44 PM:
error java.lang.NullPointerException: Cannot invoke method contains() on null object @line 255 (setHeatingSetpoint)
90dbcd53-e1e3-40a9-8e3a-d3af55a032e9  3:48:44 PM: error java.lang.NullPointerException: Cannot invoke method contains() on null object @line 296 (setCoolingSetpoint)
90dbcd53-e1e3-40a9-8e3a-d3af55a032e9  3:48:44 PM: error java.lang.NullPointerException: Cannot invoke method contains() on null object @line 255 (setHeatingSetpoint)

Thanks! I don't own this device anymore to test, but let me see if I can compare to the standard Z-wave thermostat handler and see if something is amiss.

@millward4 i just updated the DTH with some changes from the default ST DTH. Can you try again?


Can't start hazelnut

Using provided config file, just replaced cluster name and service name and got exception:
Caused by: com.hazelcast.config.properties.ValidationException: There is no discovery strategy factory to create 'DiscoveryStrategyConfig{properties={cluster=test, service=vertx-cluster}, className='com.ikentoo.hazelcast.AwsEcsDiscoveryStrategy', discoveryStrategyFactory=null}' Is it a typo in a strategy classname? Perhaps you forgot to include implementation on a classpath?
Checked that com.ikentoo.hazelcast.AwsEcsDiscoveryStrategy actually IS in the classpath

Fixed by using service merge in shadowJarPlugin:
shadowJar {
mergeServiceFiles()
}


chore: Split initialisation and running of LDK

Without this, we are susceptible to a race condition (we need to hope that bdk
init will happen before we start other tasks depending on it). If we explicitly
wait for init first, we don't have such a problem.
Add Clone trait implementation to Wallet, so that we don't need to hold the mutex to the
wallet when passing some of its data around.
Note: cloning is pretty cheap here, because we're cloning only a bunch of Arc
pointers, not the underlying wallet data.
This makes the API more discoverable, allowing for the usage
wallet.run_ldk(port).

bors r+


Highlighted hetero atoms disappear

Reference Issue
Fixes #7654
What does this implement/fix? Explain your changes.
If a hetero atom is highlighted by a background colour it is drawn in black rather than its normal element colour, so it stands out better.
Formerly:

Now:

Any other comments?

I deliberately decided to make the atom colour the same as the carbon atom, rather than the default.  The only place it makes a difference, at least with the system colour palettes, is with dark mode, where the default colour is a slightly darker grey.  I think it's more consistent this way, but can change it if you prefer.  The behaviour is commented in the code.

I deliberately decided to make the atom colour the same as the carbon atom, rather than the default. The only place it makes a difference, at least with the system colour palettes, is with dark mode, where the default colour is a slightly darker grey. I think it's more consistent this way, but can change it if you prefer. The behaviour is commented in the code.

It's just a little bit strange because:

none of the palettes the RDKit provides actually have an explicit entry for 6 (the default is generally used for C)
you search to see if 6 is there, but then you use -1

Also: there is unfortunately now a conflict

I deliberately decided to make the atom colour the same as the carbon atom, rather than the default. The only place it makes a difference, at least with the system colour palettes, is with dark mode, where the default colour is a slightly darker grey. I think it's more consistent this way, but can change it if you prefer. The behaviour is commented in the code.

It's just a little bit strange because:

none of the palettes the RDKit provides actually have an explicit entry for 6 (the default is generally used for C)
All the palettes except the BW one set colours for 6 to be the same as 1, e.g.
https://github.com/rdkit/rdkit/blob/master/Code/GraphMol/MolDraw2D/MolDraw2DHelpers.h#L71

you search to see if 6 is there, but then you use -1
Clearly I was having a bad day!  It now uses the answer correctly, I think, and falls back to the default value.

I think I've fixed the conflicts correctly, though maybe the order of the tests has changed a bit.  The normally awesome CLion merge tool made a bit of a hash of it and I ended up doing it by hand.

none of the palettes the RDKit provides actually have an explicit entry for 6 (the default is generally used for C)
All the palettes except the BW one set colours for 6 to be the same as 1, e.g.
https://github.com/rdkit/rdkit/blob/master/Code/GraphMol/MolDraw2D/MolDraw2DHelpers.h#L71

Hah! right you are. This is what I get for just scanning the code and not actually reading it.

you search to see if 6 is there, but then you use -1
Clearly I was having a bad day!  It now uses the answer correctly, I think, and falls back to the default value.

👍


_port for all ros commands instead of port

In your documentation you state to give the usb port with port:=/dev/ttyACM0 however it only works with _port:=/dev/ttyACM0

thanks !!!!!!!


runtime: wasm: fatal error: all goroutines are asleep - deadlock!

What version of Go are you using (go version)?

$ go version
go version go1.15 darwin/amd64

Does this issue reproduce with the latest release?
What operating system and processor architecture are you using (go env)?
go env Output
$ go env
GO111MODULE=""
GOARCH="amd64"
GOBIN=""
GOCACHE="/Users/uparmar/Library/Caches/go-build"
GOENV="/Users/uparmar/Library/Application Support/go/env"
GOEXE=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="darwin"
GOINSECURE=""
GOMODCACHE="/Users/uparmar/go/pkg/mod"
GONOPROXY=""
GONOSUMDB=""
GOOS="darwin"
GOPATH="/Users/uparmar/go"
GOPRIVATE=""
GOPROXY="https://proxy.golang.org,direct"
GOROOT="/usr/local/Cellar/go/1.15/libexec"
GOSUMDB="sum.golang.org"
GOTMPDIR=""
GOTOOLDIR="/usr/local/Cellar/go/1.15/libexec/pkg/tool/darwin_amd64"
GCCGO="gccgo"
AR="ar"
CC="clang"
CXX="clang++"
CGO_ENABLED="1"
GOMOD=""
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -fdebug-prefix-map=/var/folders/l7/x5hcvngd5m99k62kxv7srrdr0000gn/T/go-build448055941=/tmp/go-build -gno-record-gcc-switches -fno-common"

What did you do?
Call Go function from js(from chrome dev tools console)
// +build js, wasm

package main

import (
	"net/http"
	"syscall/js"
)

func test(this js.Value, args []js.Value) interface{} {
	println("test called")
	resp, err := http.Get("https://hacker-news.firebaseio.com/v0/item/24429478.json")
	if err != nil {
		println(err.Error())
		return nil
	}
	defer resp.Body.Close()
	var tmp []byte
	resp.Body.Read(tmp)
	println("response is", tmp)
	return nil
}

func registerFuncs() {
	js.Global().Set("test", js.FuncOf(test))
}

func main() {
	c := make(chan struct{})
	println("WASM Go Initialized")
	registerFuncs()
	<-c
}

<!doctype html>
<html>

<head>
	<meta charset="utf-8">
	<title>Test</title>
</head>

<body>
	<h1> TEST </h1>
</body>

<footer>
	<script type="text/javascript" src="./wasm_exec.js"></script>
	<script>
		if (!WebAssembly.instantiateStreaming) { // polyfill
			WebAssembly.instantiateStreaming = async (resp, importObject) => {
				const source = await (await resp).arrayBuffer();
				return await WebAssembly.instantiate(source, importObject);
			};
		}

		const go = new Go();
		let mod, inst;
		WebAssembly.instantiateStreaming(fetch("test.wasm"), go.importObject).then(
		async result => {
			mod = result.module;
			inst = result.instance;
                        go.run(inst)
		}).catch((err) => {
			console.error(err);
		});
	</script>

</footer>

</html>

What did you expect to see?
Function running succesfully
What did you see instead?
test()
wasm_exec.js:50 test called
wasm_exec.js:50 fatal error: all goroutines are asleep - deadlock!
wasm_exec.js:50
wasm_exec.js:50 goroutine 1 [chan receive]:
wasm_exec.js:50 main.main()
wasm_exec.js:50 	/Users/uparmar/Development/test_wasm/test.go:33 +0x7
wasm_exec.js:50
wasm_exec.js:50 goroutine 6 [select]:
wasm_exec.js:50 net/http.(*Transport).RoundTrip(0x33c860, 0x486000, 0x33c860, 0x0, 0x0)
wasm_exec.js:50 	/usr/local/Cellar/go/1.15/libexec/src/net/http/roundtrip_js.go:168 +0x55
wasm_exec.js:50 net/http.send(0x486000, 0xc8260, 0x33c860, 0x0, 0x0, 0x0, 0x0, 0x40c040, 0x424ab0, 0x1)
wasm_exec.js:50 	/usr/local/Cellar/go/1.15/libexec/src/net/http/client.go:252 +0x5b
wasm_exec.js:50 net/http.(*Client).send(0x3490c0, 0x486000, 0x0, 0x0, 0x0, 0x40c040, 0x0, 0x1, 0xf8)
wasm_exec.js:50 	/usr/local/Cellar/go/1.15/libexec/src/net/http/client.go:176 +0x13
wasm_exec.js:50 net/http.(*Client).do(0x3490c0, 0x486000, 0x0, 0x0, 0x0)
wasm_exec.js:50 	/usr/local/Cellar/go/1.15/libexec/src/net/http/client.go:718 +0x38
wasm_exec.js:50 net/http.(*Client).Do(...)
wasm_exec.js:50 	/usr/local/Cellar/go/1.15/libexec/src/net/http/client.go:586
wasm_exec.js:50 net/http.(*Client).Get(0x3490c0, 0x8c00d, 0x38, 0x41a138, 0x14a30008, 0x14a80007)
wasm_exec.js:50 	/usr/local/Cellar/go/1.15/libexec/src/net/http/client.go:475 +0xe
wasm_exec.js:50 net/http.Get(...)
wasm_exec.js:50 	/usr/local/Cellar/go/1.15/libexec/src/net/http/client.go:447
wasm_exec.js:50 main.test(0x0, 0x0, 0x368070, 0x0, 0x0, 0x0, 0x0)
wasm_exec.js:50 	/Users/uparmar/Development/test_wasm/test.go:12 +0x7
wasm_exec.js:50 syscall/js.handleEvent()
wasm_exec.js:50 	/usr/local/Cellar/go/1.15/libexec/src/syscall/js/func.go:96 +0x24
wasm_exec.js:141 exit code: 2

This is documented here: https://golang.org/pkg/syscall/js/#FuncOf

As a consequence, if one wrapped function blocks, JavaScript's event loop is blocked until that function returns. Hence, calling any async JavaScript API, which requires the event loop, like fetch (http.Client), will cause an immediate deadlock. Therefore a blocking function should explicitly start a new goroutine.

You would need to perform the http.Get in a separate goroutine.

Thanks @agnivade for clarification.

@agnivade I am doing http.Get in seperate routine but still getting error. I am creating a channel before invoking go routine to perform http.Get and reading from channel later down the function. Is this also a limitation?

Yes, that does not change anything if you read from the channel in the same function. It will still cause the deadlock. You have to create a separate event handler loop or some other mechanism to make http requests and read responses.

I'm new to Go so would appreciate any thoughts on my scenario. I'm not doing the GET directly, but have compiled go-git to wasm and am calling its repo.Clone() in the browser, which causes the same error as in the OP. The http requests and responses are there and look ok, but Go has died with the error fatal error: all goroutines are asleep - deadlock! wasm_exec.js.
So my question is about ways to solve this when not doing the fetches directly, but when they are happening in another package (which would not expect to be used in the browser). Can I solve this without re-writing the relevant parts of go-git?
If not I guess I'll look into modifying go-git to use my own "fetch" package ("in another event loop" whatever that means :smile:), but am wondering if you can offer any advice to someone new to Go. Thanks.

You can try wrapping repo.Clone() call in a seperate go routine.

Thanks. I'm trying the following, but maybe it can only work if Clone() only does a single fetch(), because I'm seeing the Clone() get further (more console output) but still fail with the same error.
This is in a funciton called via the wasm go bridge so I can't put it in a playground:
	url = "https://gitlab.com/weblate/libvirt"
	fs := memfs.New()
	storage := memory.NewStorage()
	var wg sync.WaitGroup
	wg.Add(1)
	go func() {
		_, err := git.Clone(storage, fs, &git.CloneOptions{ URL: url })
		if err != nil {
			println("git.Clone() failed: ", err.Error())
		}

		wg.Done()
	}()
	wg.Wait()

Or might the problem remain because this is (I think) a nested goroutine?

I think I have solved this, the issue remained because I was waiting on the result so if I remove the WaitGroup altogether and just create the goroutine as it, it doesn't exit as in:
	url = "https://gitlab.com/weblate/libvirt"
	fs := memfs.New()
	storage := memory.NewStorage()
	go func() {
		_, err := git.Clone(storage, fs, &git.CloneOptions{URL: url})
		if err != nil {
			println("git.Clone() failed: ", err.Error())
		}
	}()

It doesn't clone the repo, but that's a different issue. Thanks for your help.

You can try using js promises
func Clone() js.Func {
	return js.FuncOf(func(this js.Value, args []js.Value) interface{} {
		// Handler for the Promise: this is a JS function
		// It receives two arguments, which are JS functions themselves: resolve and reject
		handler := js.FuncOf(func(this js.Value, args []js.Value) interface{} {
			resolve := args[0]
			// Commented out because this Promise never fails
			//reject := args[1]

			// Now that we have a way to return the response to JS, spawn a goroutine
			// This way, we don't block the event loop and avoid a deadlock
			go func() {
				// Block the goroutine for 3 seconds
				_, err := repo.Clone()
				// Resolve the Promise, passing anything back to JavaScript
				// This is done by invoking the "resolve" function passed to the handler
				resolve.Invoke("Successfully cloned repo")
			}()

			// The handler of a Promise doesn't return any value
			return nil
		})

		// Create and return the Promise object
		promiseConstructor := js.Global().Get("Promise")
		return promiseConstructor.New(handler)
	})
}

Then you can directly call Clone() function from your html code inside of script tags

I'm pretty sure the remaining issue is because I'm doing this in the browser, so the server issues a 404 (after initially responding as desired), so it isn't a concern for this thread. It's also not vital for my use case, more for testing at least for now so I'm happy!
And thanks for your help. Go has a great community and I've had excellent help whenever I get stuck.


A view referencing a View that's not a peer (same superview) in Dim/Pos should not be allowed

I was debugging tests and came across this test:
https://github.com/gui-cs/Terminal.Gui/blob/33c9a5fad44256ab1ade0d9ac478dab6af89b9b6/UnitTests/Types/DimTests.cs#LL541C3-L585C4
		public void DimCombine_Do_Not_Throws ()
		{
			Application.Init (new FakeDriver ());

			var t = Application.Top;

			var w = new Window ("w") {
				Width = Dim.Width (t) - 2,
				Height = Dim.Height (t) - 2
			};
			var f = new FrameView ("f");
			var v1 = new View ("v1") {
				Width = Dim.Width (w) - 2,
				Height = Dim.Height (w) - 2
			};
			var v2 = new View ("v2") {
				Width = Dim.Width (v1) - 2,
				Height = Dim.Height (v1) - 2
			};

			f.Add (v1, v2);
			w.Add (f);
			t.Add (w);

			f.Width = Dim.Width (t) - Dim.Width (v2);
			f.Height = Dim.Height (t) - Dim.Height (v2);

			t.Ready += (s, e) => {
				Assert.Equal (80, t.Frame.Width);
				Assert.Equal (25, t.Frame.Height);
				Assert.Equal (78, w.Frame.Width);
				Assert.Equal (23, w.Frame.Height);
				Assert.Equal (6, f.Frame.Width);
				Assert.Equal (6, f.Frame.Height);
				Assert.Equal (76, v1.Frame.Width);
				Assert.Equal (21, v1.Frame.Height);
				Assert.Equal (74, v2.Frame.Width);
				Assert.Equal (19, v2.Frame.Height);
			};

			Application.Iteration += () => Application.RequestStop ();

			Application.Run ();
			Application.Shutdown ();
		}

I have decided this test is totally bogus because views are referencing superviews.
This code would guard against this:
		internal void CollectPos (Pos pos, View from, ref HashSet<View> nNodes, ref HashSet<(View, View)> nEdges)
		{
			switch (pos) {
			case Pos.PosView pv:
				if (!from.InternalSubviews.Contains (pv.Target)) {
					throw new InvalidOperationException ($"View {pv.Target} is not a subview of {from}");
				}
				if (pv.Target != this) {
					nEdges.Add ((pv.Target, from));
				}
				foreach (var v in from.InternalSubviews) {
					CollectAll (v, ref nNodes, ref nEdges);
				}
				return;
			case Pos.PosCombine pc:
				foreach (var v in from.InternalSubviews) {
					CollectPos (pc.left, from, ref nNodes, ref nEdges);
					CollectPos (pc.right, from, ref nNodes, ref nEdges);
				}
				break;
			}
		}

		internal void CollectDim (Dim dim, View from, ref HashSet<View> nNodes, ref HashSet<(View, View)> nEdges)
		{
			switch (dim) {
			case Dim.DimView dv:
				if (!from.InternalSubviews.Contains (dv.Target)) {
					throw new InvalidOperationException ($"View {dv.Target} is not a subview of {from}");
				}
				if (dv.Target != this) {
					nEdges.Add ((dv.Target, from));
				}
				foreach (var v in from.InternalSubviews) {
					CollectAll (v, ref nNodes, ref nEdges);
				}
				return;
			case Dim.DimCombine dc:
				foreach (var v in from.InternalSubviews) {
					CollectDim (dc.left, from, ref nNodes, ref nEdges);
					CollectDim (dc.right, from, ref nNodes, ref nEdges);
				}
				break;
			}
		}

And this test would verify:
		[Fact]
		public void Dim_Referencing_SuperView_Throws ()
		{
			var super = new View ("super") {
				Width = 10,
				Height = 10
			};
			var view = new View ("view") {
				Width = Dim.Width (super),	// this is not allowed
				Height = Dim.Height (super),    // this is not allowed
			};

			super.Add (view);
			super.BeginInit ();
			super.EndInit ();
			Assert.Throws<InvalidOperationException> (() => super.LayoutSubviews ());
		}

This breaks a lot of existing code (e.g. TileView does this internally). So I'm not sure I'm correct.
Please debate ;-).
Thanks.

The test is very confuse and I purpose did it. If you look better all them belong to the same hierarchy (t, w, f, v1 and v2). For this to work I did changes to the TopologicalSort not throw exception if they belong to the same hierarchy and in the LayoutSubviews to process them later, but you didn't take then on account.

The test is very confuse and I purpose did it. If you look better all them belong to the same hierarchy (t, w, f, v1 and v2). For this to work I did changes to the TopologicalSort to not throw exception if they belong to the same hierarchy and in the LayoutSubviews to process them later, but you didn't take them on account.

Ahhh.... Now it makes much more sense to me.
Do you think it would be a good idea to NOT allow these funky scenarios?

Ok I agree to avoid steaming heads :-)
I only demonstrated that is possible :-)

Separate from the work I'm doing now, I'm going to implement this and see how much actually breaks.
I'm guessing I may find some use cases where referencing a superview may be very useful... Or not.

Well for the TileView it help :-)

I think it's possible (but not 100% sure) for TileView to be refactored to not do what it's doing.
I still believe my new View design will completely negate the need for a TileView class. 💪

On layout, a inner subview can reference a outer sujperview, but a superview never can reference a subview. See #2504.

On layout, a inner subview can reference a outer sujperview, but a superview never can reference a subview. See #2504.

Can you give an example of a useful scenario where a subview references it's superview (or superview's superview)? I tried to think of one but couldn't.

Can you give an example of a useful scenario where a subview references it's superview (or superview's superview)? I tried to think of one but couldn't.

Sure, here is a small example:
			Application.Init ();

			var top = Application.Top;
			var win1 = new Window ("win1");
			var win2 = new Window (new Rect (0, 0, 60, 20), "win2");
			var win3 = new Window (new Rect (0, 0, 30, 10), "win3");
			var leftLabel = new Label ("move to right") { X = Pos.Left (win2) };
			var rightLabel = new Label ("move to left") { X = 90 - 14 - Pos.Right (win2), Y = Pos.AnchorEnd (13) };
			win3.Add (leftLabel, rightLabel);
			win2.Add (win3);
			win1.Add (win2);
			top.Add (win1);

			Application.Run ();
			Application.Shutdown ();

Maybe we can leverage this for scrolling, what do think?
@tig see the dragging is exceeds the right side and the bottom side of the superview. Also when I start the drag by pressing the mouse the frame move down one line and the mouse isn't aligned at the top.

@tig the above only works with the pr #2504.

@tig the numeration is broke again. We need to create a unit test for this doen't happens again.

@tig the numeration is broke again. We need to create a unit test for this doesn't happens again.

The reason is you removed the code which pass the containerBounds parameter to the TextFormatter.Draw. You are passing the scroll view width and height, instead of passing the scroll view container size.

var leftLabel = new Label ("move to right") { X = Pos.Left (win2) };

This effect is cool, but I'm not sure why it's useful.
I'm pushing on this because I want us to simplify the Terminal.Gui for developers and my intuition (based on my experience, and the fact that I'm not a very smart programmers) is that Pos/Dim are powerful-yet-confusing. By making the rule "Pos/Dim can only reference peer-Views" we can make it easier to understand.
If some developer comes along later with a REAL and useful scenario that is not possible with this limitation, we can back it out. In the meantime, developers will make fewer mistakes.
I'm COMPLETELY willing to have my mind changed on this. I have a feeling you have a real scenario in mind, but you've just not been able to articulate it yet. So please do.
Note this is not something we need to decide right now! We can let it stew ;-).

@tig the numeration is broke again. We need to create a unit test for this doesn't happens again.

The reason is you removed the code which pass the containerBounds parameter to the TextFormatter.Draw. You are passing the scroll view width and height, instead of passing the scroll view container size.

Right. The documentation for TextFormatter is confusing. We need to fix that because I've made this mistake before.

@tig the scrolling issue wasn't related with I said before, sorry. The main cause was the PosView and DimView was collection more than the necessary, by processing all the subviews on the CollectPos and CollectDim, respectively.

@tig with the last fix in the #2504, the rightLabel now have the right Pos.AnchorEnd (1) instead of Pos.AnchorEnd (13).

I'm going to close this issue. I think @BDisp shows an interesting use-case.


IE 11 emulator edge

I'm getting this console error when trying to test easy toggle in IE11 with emulator Edge set on the compatibility mode.

Thanks for taking time to report this issue.
According to MDN, this feature is not compatible with Internet Explorer: https://developer.mozilla.org/en-US/docs/Web/API/Event/Event#Browser_compatibility
But, as mentioned in Easy Toggle State's documentation, compatibility for Internet Explorer can be provided by polyfill.io.
According to polyfill.io documentation, you can add compatibility for Event down to Internet Explorer 7: https://polyfill.io/v2/docs/features/#Event.
Hope that helps.

Perfect thank you.


Vfd 146 occupation kentta lisataan jif tmt productizeriin

feat: add job requirements filtering fields to the job posting definition

Hey - please rename to English.


make Style.body_ref a property

@BerryDaniel we think that is better to keep it as a method and fix donwstreams in geonode, could you revert please?
thanks and sorry


Extra await inserted when accepting suggestion

From https://github.com/microsoft/vscode/issues/89879

TypeScript Version:  3.8.0-dev.20200201

Search Terms:
Repo
For the code:
import * as util from 'util';
import * as fs from 'fs';

const readFile = util.promisify(fs.readFile);

async function foo() {
    const includedContents = await readFile('x').
}

Trigger suggestions after the . in foo. Accept a suggestion
Bug:
An extra await is inserted:
async function foo() {
    const includedContents = await (await readFile('x')).BYTES_PER_ELEMENT
}

This isn't extra, because the await you inserted has nothing to do with the prior await. It's the same as if you had written
import * as util from 'util';
import * as fs from 'fs';

const readFile = util.promisify(fs.readFile);

async function foo() {
    const includedContents = 1 + readFile('x').
}

We wouldn't erase the 1 + here; the await has the same syntactic positioning in this case.


[not for merge] get closer to repeatable builds by removing in-jar timestamps

.. and sorting entries by name. This made building a minimal test
application 'repeatable' when building on the same machine but clearing
the target directory between builds.
Related to https://github.com/sbt/zinc/issues/333

To validate this pull request against other sbt modules, please visit this link.

Hey @raboof, thanks for doing this! Let me get back to it in a few days, right now we're preparing RC.

Hey @raboof, do you have any idea what the possible implications of dropping the timestamps are?
Perhaps as alternative to zeroing them out we should introduce one or more parameters so that it becomes a client's decision whether to use currentTimeMillis/File.lastModified or not. WDYT?

@dwijnand I'm not aware of possible implications, and I didn't see any warnings on the reproducible builds maven plugin which also clears the timestamps.
In most cases these timestamps represent the 'time of last compilation' or 'time of packaging', I'm not sure when that'd be interesting information. Also I'm not sure this information is even exposed via the classpath API.
I'd be OK with making this behavior configurable (though of course I'd like the default to be 'cleared' ;) ). The question is how/where to configure this and how to pass that information around. I can give it a shot.

I still don't have time to do this, but my gut feeling is that this could have an implication in Zinc to detect changes in jars as well as scalac (to avoid caching the classpath entries). Need to look deeper, but just throwing some observations out there...

A dbuild validation involving this pull request is in progress...

Yeah, that's my concern too.

dbuild has checked the following projects against Scala 2.12:

Project
Reference
Commit

sbt
1.0.x
sbt/sbt@2d7ec47b13e02526174f897cca0aef585bd7b128

zinc
1.0
sbt/zinc@d4d29e8ffeecfa7c6a8e834b4ee54c4bfda9af63

io
pull/58/head
sbt/io@b75de5a7058f5fbc1181c32461dd7fc7b346740c

librarymanagement
1.0
sbt/librarymanagement@0147e0c77578ca4852137a6113bcac4c7adeeb38

util
1.0
sbt/util@81277cbf62187eabdc615b7c6d3325e9f664a6e1

website
1.0.x
sbt/website@c5ef5f0dc6cd84c6c6977c09484f56113eaad0d7

:x: The result is: FAILED
(restart)

Aah, those kind of tools could be impacted, yes... that might be hard to deal with. Let's see if we can find an example.

The thing I'm most worried about is that today I learned that the JVM caches jars based on the timestamp (https://github.com/scala/bug/issues/10295); which conflicts with this change... if a jar changes completely, and the JVM is caching the jars for the same compiler run, a reference to the previous jar could be maintained and that would cause compilation errors.
However, I'm not sure how all these pieces interact with each other. I need some kind of first hand experience because I can certainly ensure that will be the result.
@raboof I really appreciate you took this thing up. Would you mind creating a sbt plugin that overrides the sbt task creating a jar and nulls out the last modified time and experiment with it? I think that could give us great insights.

Interesting find! https://github.com/scala/bug/issues/10295#issuecomment-307696602 is talking about java.util.File though - might that refer to the filesystem timestamp rather than the timestamp inside of the Jar (which this PR is about)?

@jvican It looks like IO.jar() is only called from the Package task, but I'm not sure it'd be possible/easy to override that task... could you point me in the right direction?

Right, so this only affects the files inside the zip files. Then I'm less scared. But I'm still positive that testing it should give us more confidence :smile: @raboof.
To override this in sbt, have a look at the implementation of packageBin, which is the responsible for packaging jars IIRC.
Let's check that we have project A, and project B, which depends on A. To check that this patch doesn't do anything dangerous (like affecting incremental compilation), I would override packageBin with the sbt syntax and reuse the return type, which is the jar (zip) file. It would be something similar to:
// remember to scope it in A
packageBin := {
  val packaged = packageBin.value
  // Write any timestamps inside the `packaged` file to zero
  // Do more stuff to make the jar reproducible
  ???
}

Following a similar methodology, you can instrument any task of sbt (which is one of the best features of the tool). If it's not by reusing the return type, it's by copy-pasting the original implementation defined in Defaults.scala and then modifying the bits you're interested in.
Let me know how it goes.

Hmm https://github.com/raboof/scala-reproducible-build-sbt-library-dependency doesn't appear to work even with the timestamps intact :thinking:

What do you mean by "doesn't appear to work" @raboof?

Sorry that was not too helpful :).
When I sbt publishLocal test-lib and then start an interactive sbt session in project-using-test-lib and run, that works. When I then change the code in test-lib and sbt publishLocal it, runing the project-using-test-lib again from the (still running) interactive session I get [error] error while loading Constants, class file '/home/aengelen/.ivy2/local/net.bzzt/test-lib_2.12/0.1-SNAPSHOT/jars/test-lib_2.12.jar(net/bzzt/Constants.class)' is broken.
Did we expect this to work? If we didn't expect that to work, can you help come up with examples of things we do expect to work (and want to test it keeps working when we strip timestamps)?

But you're using exportJars right? I was not expecting that to work. What about generating the jars with packageBin and then having a dependency on that? What you want to check is that a change produces a different jar (with the same filestamp) but this jar is detected by Zinc and recompilation is triggered.
Note: The error you're seeing is because Scalac caches jars when run from sbt or in resident mode...

I'm afraid I'd need more hand-holding to get this over the finish line, so closing this for now. If anyone wants to reopen/continue, feel free (and I'd be happy to help), but I don't feel qualified to push it forward on my own right now :).

(continued in https://github.com/sbt/sbt/pull/5233 and https://github.com/sbt/io/pull/279)


Enhance isSupported to check for specific Technologies too

I've noticed on some Android devices MifareClassic is not enabled, which results in errors upon scanning a card. But it would be nice to know on forehand to see if a specific technology is available or not. Now the isSupported doesn't accept any parameters so my suggestion is to extend it so you can pass a TechRequest to it (like isSupported(TechRequest.MifareClassic)). Wouldn't change the default behaviour (if you pass nothing it will check if NFC in general is supported).
I can work on a PR, still need to do some testing first on other devices, but if you agree on this I'd make it blocking for releasing 1.0.

@whitedogg13 would be great to have your comments on this

@poison , There should be a property called techTypes in the detected in tag object (see line<EMAIL_ADDRESS>), so it should be possible to do things like this:
NfcManager.registerTagEvent(tag => {
    if (tag.techTypes.find(tech => tech === NfcTech.XXX)) {
        // request tech handle
    } else {
        // do something else
    }
})

Maybe we should provide an enhanced document & example to address this?

Well I'm kinda busy now, I hope to get back to you by friday on this, but I already noticed on some devices that MifareClassic isn't supported on specific NFC chipsets (mainly the Broadcoms).
I found this piece of code that handles it nicely: https://github.com/ikarus23/MifareClassicTool
Sometimes you know it on forehand when it's not supported (like if your device has the broadcom chip), and sometimes you can only know it when you're scanning a card. My idea is to throw a specific error there so it's easy distinguishable from radio errors.

I created PR #117 , please let me know what you think of it. In my usecase I wanted to know the support at launch of the app, so before detecting a tag. The PR works for my usecase.
Best,
Nicolas


IMPORTANT! Security Vulnerability Detected in your Repository

Hey there!
We have detected a security vulnerability in your repository. Please contact us at https://github-scanner.com to get more information on how to fix this issue.
Best regards,
Github Security Team

What needs to be done?
On Thu, Sep 19, 2024, 05:19 smithsarahxh8 @.***> wrote:

Hey there!
We have detected a security vulnerability in your repository. Please
contact us at https://github-scanner.com to get more information on how
to fix this issue.
Best regards,
Github Security Team
—
Reply to this email directly, view it on GitHub
https://github.com/ajar/gumshoe/issues/20, or unsubscribe
https://github.com/notifications/unsubscribe-auth/AES4O7NEE4NFBXM72I3WVITZXHU4NAVCNFSM6AAAAABOOR7TIOVHI2DSMVQWIX3LMV43ASLTON2WKOZSGUZTINZVGY2DCOA
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>


⚠ Bofrost.fr has degraded performance

In 89513f7, Bofrost.fr (https://www.bofrost.fr) experienced degraded performance:

HTTP code: 200
Response time: 1068 ms

Resolved: Bofrost.fr performance has improved in b82cc1c.


Allow multiple tasks to be completed together

Add new TaskBundleWidget that supports bundling of tasks together
during task completion, and viewing of bundled tasks during review

Integrate with new backend APIs for working with task bundles,
including setting completion status and review status of all tasks in a
bundle

Other minor changes and enhancements to better support multi-task
completion

 Clustering tasks that are close together


Finish implementation of cl_khr_subgroups and OpenCL 3 core support

Passes all the corresponding subgroup CTS tests.
New non-semantic instruction specified in https://github.com/KhronosGroup/SPIRV-Registry/pull/132
SPIR-V Headers changes in https://github.com/KhronosGroup/SPIRV-Headers/pull/250
Signed-off-by: Kévin Petit<EMAIL_ADDRESS>

Seems like something isn't generating the expected enums properly.

Yeah, it's working fine locally so I suspect it's a build parallelisation issue. I'll try to look into it during the weekend.

Looking at the build logs, I think there are two issues:

SPIRV-Tools needs updating to a version that can handle the updated version of SPIRV-Headers. I've now done that. This should fix all the builds except those using amber.
It seems amber builds are using the version of SPIRV-Headers amber wants rather than that in clspv's deps.json. Assuming this is the case I can see two ways forward: 1) Simply update the version of SPIRV-Headers in amber's dependencies 2) Change the jobs so they use the version of SPIRV-Headers in clspv's deps.json.

If you get the SPIRV-Tools updated that should be enough. Amber should roll the deps at a reasonable frequency.

I've already done that. I think you can kick off the bots again then.

Thanks for merging this! I'll update SPIRV-Headers in clvk so that'll take care of the clvk failure and hopefully amber will update soon which will take care of the amber failure.


Styled api with object css takes a props factory function

Can take multiple objects or functions as args. Probably just implement either object or function maybe.
const Image1 = styled('div')(
  {
    backgroundSize: 'contain'
  },
  (props: ImageProps) => ({
    width: props.width,
    background: `url(${props.src}) center center`
  })
)

for now - no. maybe later.


Scrapers should be run through a web service or cron

The code should be in /var/www/ scrapers but we should see what is required to pass user data.

I'm afraid I didn't get the question correctly. What lies on /var/www/scrapers is the source of a REST API. You'd make a GET HTTP request to, for example, scrapers.com/wow/user/quelthalas/xtreme/us to get information of user quelthalas on world xtreme and region us, receiving a complete dictionary (JSON) if so and the string False if it doesn't exist.

Is this issue resolved?

There's an additional security measure we intend to implement (when the structure for server-side code is done). But what was being requested here, yes, done yesterday.

Perfect, thanks! Can you make a new issue for the security measure you have in mind? Just a short description, takes only a minute.


Live reload doesn't work in consumer application.

Describe the bug
I've been following the 'Quick Start Guide' and noticed that Live Reload isn't functioning properly in the consumer application. It seems that although requests are being made with the new version, the screen isn't updating accordingly.

Reproduction
https://github.com/Thiagom790/REACTJS-MF-STUDIES
Used Package Manager
yarn
System Info
System:
    OS: Linux 5.15 Ubuntu 22.04.4 LTS 22.04.4 LTS (Jammy Jellyfish)
    CPU: (8) x64 Intel(R) Core(TM) i7-10610U CPU @ 1.80GHz
    Memory: 6.67 GB / 15.23 GB
    Container: Yes
    Shell: 3.7.1 - /usr/bin/fish
  Binaries:
    Node: 20.10.0 - ~/.volta/tools/image/node/20.10.0/bin/node
    Yarn: 4.1.0 - ~/.volta/tools/image/yarn/4.1.0/bin/yarn
    npm: 10.5.0 - ~/.volta/tools/image/npm/10.5.0/bin/npm
    pnpm: 8.15.4 - ~/.volta/bin/pnpm
    bun: 1.0.31 - ~/.bun/bin/bun
  Browsers:
    Chrome: 123.0.6312.105

Validations

[X] Read the docs.
[X] Read the common issues list.
[X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
[X] Make sure this is a Module federation issue and not a framework-specific issue.
[X] The provided reproduction is a minimal reproducible example of the bug.

I'm experiencing same issue. All remotes and consumer are built with rsbuild.

https://github.com/module-federation/universe/discussions/2210 @MKraust @Thiagom790 It may be that some build configurations are not configured correctly, which we will automatically configure in the build plugin in the near future

heres an example:
https://github.com/module-federation/module-federation-examples/commit/3956a60459edb0774cde9508b090bced1043bbaa

heres an example: module-federation/module-federation-examples@3956a60
rsbuild may not be configured for this out the box, set output.uniqueName = 'something unique per app'
This should be set on the rspack(config) {} not on rsbuilds output object directly

Nice! After adding this configuration, the live reload now works for me.
rspack: (config, { appendPlugins }) => {
      if (config.output) {
        config.output.uniqueName = "ra_consumer";
      }

      appendPlugins([
        new ModuleFederationPlugin({
          name: "ra_consumer",
          remotes: {
            ra_producer: "ra_producer@http://localhost:3001/mf-manifest.json",
          },
          shared: ["react", "react-dom"],
        }),
      ]);
    },


[BUG]: Some images are missing from the PDF export of arneis.readthedocs.io

Description of the bug
Examples:

All the images in section "Implement preview for Pull Requests" of https://github.com/B-AROL-O/ARNEIS/blob/main/docs/howto/howto-configure-arneis-readthedocs-io.md do not show up in the generated PDF

Steps To Reproduce

Go to https://arneis.readthedocs.io/_/downloads/en/latest/pdf/
Scroll up to the end of Page 8 (Section 2.1.6)

Expected result
Something similar to what displayed in HTML at https://arneis.readthedocs.io/en/latest/howto/howto-configure-arneis-readthedocs-io.html#implement-preview-for-pull-requests

Actual result

Additional Information
No response

Root cause has to be investigated, but I tend to suspect that those images are missing since they are not part of the source tree.
Please have a look at the src URL of the  elements in https://github.com/B-AROL-O/ARNEIS/blob/main/docs/howto/howto-configure-arneis-readthedocs-io.md?plain=1#L209-L229
### Implement preview for Pull Requests

References:
* <https://github.com/B-AROL-O/ARNEIS/issues/85>
* [Preview Documentation from Pull Requests](https://docs.readthedocs.io/page/guides/autobuild-docs-for-pull-requests.html)

In order to enable the Pull Request preview feature you should execute the following steps:

1. In your _Read the Docs_ project page select the `Admin` menu

1. In `Advanced Settings` select **Build pull requests for this project**

3. That's all. For each pull request an automatic check which builds the document on _Read The Docs_ is added. You can check the result of this compilation in the `Detail` information for this check.

Postponing to next sprint since resolution is blocked by #191

Unassigning myself, moving to dev-cw16.

assigned to me but moving to dev-cw17


Remove check path in entrypoint script. - [closed]

In GitLab by @wknet123 on Aug 2, 2017, 08:37
Merges dev-update-ui-build -> dev

In GitLab by @wknet123 on Nov 13, 2019, 09:52
closed


[3.2] [HTML5] Use internal implementation of the Gamepad API.

3.2 version of #45078

Thanks!

Thanks!


Configuring total context size

System Info

TensorRT-LLM v0.10.0
Llama 3 8B Instruct

Who can help?
@juney-nvidia @kaiyux @by
Information

[ ] The official example scripts
[ ] My own modified scripts

Tasks

[ ] An officially supported task in the examples folder (such as GLUE/SQuAD, ...)
[ ] My own task or dataset (give details below)

Reproduction
Try to build a Llama 3 8B Instruct engine using trtllm-build
Expected behavior
Should be able to configure entire context size
actual behavior
I'm trying to build a Llama 3 8B Instruct engine that allows 8K tokens for its entire context (input and output included). However, it's not clear how I can do so -- do I set max_input_len, max_output_len, and max_num_tokens to 8K?
additional notes
N/A

Several ref doc links:
https://nvidia.github.io/TensorRT-LLM/performance/perf-best-practices.html#build-options-to-optimize-the-performance-of-tensorrt-llm-models
https://nvidia.github.io/TensorRT-LLM/reference/memory.html

Thanks -- for anyone referring to this in the future, it seems that starting from v0.11.0, there's a max_seq_len that can be used to define the overarching context length.


Replace log with a simple local logger

The log crate uses a global logger that can only be registered once,
at startup. Unfortunately, this won't work for Desktop, where we want
to integrate with Sync's existing logging setup. We also don't want to
impact other crates in gkrust that use log.
This commit replaces log with a quick-and-dirty implementation on
Driver, and some macros that take care of calling format_args!().
We can extend these later to pass file!() and line!(), if we
want.
This commit also changes Merger to hold a reference to Driver.
On Desktop, the driver accumulates log messages on the storage
thread, and accesses them on the main thread.

I found rustfmt's default block indentation hard on the eyes, but visual indents were super buggy (fad717bbec60615ed5b9775b3858b5df0913ad9d); then it broke on Nightly (#11), and most of the custom rules didn't work on Stable. I should just use the defaults and deal. 😂


Suggest adding dummy openacc warm up to reduce kernel launching overhead

There is one thing that has not been made clear in the given template code about openacc timing. The template is like
// begin your code
[start time]
[end time]
// end your code

It is likely to prompt student to time their openacc programming with copy time excluded. If people are doing the following, there is no problem.
// begin your code
# pragma acc data ...

[start time]
// doing stuff here
[end time]

// end your code

But if somebody times the program intentionally with copy time included (which actually takes only very short time for softmax with openacc)
[start time]
# pragma acc data ...
// doing stuff here
[end time]

The actually overhead comes from kernel launching time. I suggest adding the following line to warm up the launching procedure
#pragma acc kernels
{;} // doing nothing
[start time]
// students code including data copy
[end time]

Adding this line gives me a drastic improvement of performance from 1600ms to a stable 750ms. Without doing this, my program performance varies a lot even in consecutive runs, seeing the following three consecutive runs (while most of the time it will be around 1600ms)

I think this launching overhead which can not controlled by students should be excluded from the evaluation. This is not a problem for nn with openacc, where kernel launching overhead can be ignored.

@xhn2333 @120090162
Haonan and yebin, could you please have a look at this problem?
As @noah822 says, the execution drops from 1600ms to 750ms with kernel launch time out, which is nearly 1 second! That number is much larger than the kernel launching time that I see from the internet resources attached below. I think time drop mainly consists of the time to copy in the data from CPU to GPU memory, but the problem is that it is hard to change the baseline now as DDL is approaching.
Maybe we just loose the bound of performance to allow more flunctuation in students' programs?
2019-KernelLaunchOverhead.pdf

My terminology is pretty loose here. This overhead may not directly relate to cuda kernel launching time. But it is some kind of launching time (maybe openacc, and it is not from just-in-time compile after my research). I need to research on it a little bit more to spot where the problem is.
@tonyyxliu I do not think that time drop comes from the memory copy, because I have included the #pragma acc data construct as part of the timing. See my previous post. To repeat it, this is the way I profile
#pragma acc kernels
{;}. // do nothing

[start time]
#pragma acc data ...
// do stuff here
[end time]


AttributeError: 'dict' object has no attribute 'iteritems'

Error
{'next': None, 'previous': None, 'results': []}
Traceback (most recent call last):
File "rhDataAnalyzer.py", line 192, in
for key, stockList in stockDict.iteritems():
AttributeError: 'dict' object has no attribute 'iteritems'
lines 191-201
  process the stocks in the dictionary and calculate P&L

for key, stockList in stockDict.iteritems():
# variables to create the summary data
totalBought = 0
totalCost = 0
avgCost = 0
totalSold = 0
totalSale = 0
avgSale = 0
profit = 0
quantLeft = 0
excel file stockdata.xls is not created.
excel file optionsdata.xls is created with only headers, no data.

Since this was basically written for my own use, I didnt add much error logging.
I will add some logging and better error logging when I get some time so that its better for other people.
But in this case - do you have the options.json and orders.json file created in your folder?

Both .json files were successfully created and contain data.

Hi Mark,
This is happening because of python version mismatch. I wrote the code in 2.7 which uses dictionary.iteritems() and in Python this was replaced with dictionary.items(). I will update the code for python 3 soon.
But for now you can replace the below line:
"for key, stockList in stockDict.iteritems():"
with
"for key, stockList in stockDict.items():"
and run the code again. I will keep the issue open and close it onceI upgrade the code to python 3.

That worked! Thank you for your help


WEBAPP-190: Add git-hooks to runl linters tests

What do you think about this? Does this help or should every dev decide for them selfes? Push and checkout times increase with this PR.

Im not sure about these changes, we could try them though. Imo it's not too bad, if there are broken builds pushed to feature branches, since only one should work on them at a time (and we should avoid branch dependencies as well anyway).

The question is just if this will bug us less than broken builds because of linting  :P
This probably will avoid commmits like 'Fix linting'. I also think we probably shouldn't run the tests. And running yarn on each checkout may take a while too.


Feature request: Github copilot support

Can you add copilot support to your planned features? Thank you for your hard work.

This sounds out of scope for the built-in providers. Someone could build an external provider for it

If anyone else comes across this, I found the following plugin that works super well with blink.cmp: giuxtaposition/blink-cmp-copilot


Connection refused

Hi, when I'm downloading the prepro_squad, I encountered with these questions. Could help me? Thanks
--2019-01-29 11:42:32--  https://rice.box.com/shared/static/6haddoiep15fmdqmtdp3ccf44o1m6e4z.gz
Resolving rice.box.com... <IP_ADDRESS>
Connecting to rice.box.com|<IP_ADDRESS>|:443... connected.
HTTP request sent, awaiting response... 301 Moved Permanently
Location: https://rice.app.box.com/shared/static/6haddoiep15fmdqmtdp3ccf44o1m6e4z.gz [following]
--2019-01-29 11:42:34--  https://rice.app.box.com/shared/static/6haddoiep15fmdqmtdp3ccf44o1m6e4z.gz
Resolving rice.app.box.com... <IP_ADDRESS>
Connecting to rice.app.box.com|<IP_ADDRESS>|:443... failed: Connection refused.
preprocessed data download completed.

Sorry to hear about the connection issues. Does it work if you click on the link and manually download? If not I can share it with you directly thanks!

Thanks very much! I managed to download the dataset now.
Thanks!