Cannot create nested environments

Created on behalf of @EugeneAikashev
It seems very difficult to create a nested environment like level1->level2->level3 in one terraform run. I have to apply the code 3 times ( ...
Here is my simple code:
resource "cloudtruth_project" "test" {
  name        = "test"
  description = "This is a Test project created by Terraform"
  force_delete = true
}

resource "cloudtruth_environment" "level1" {
  name         = "level1"
  description  = "Level1 created by Terraform"
  parent       = "default"
  force_delete = true
}

resource "cloudtruth_environment" "level2" {
  name         = "level2"
  description  = "Level2 created by Terraform"
  parent       = "level1"
  force_delete = true
}

resource "cloudtruth_environment" "level3" {
  name         = "level3"
  description  = "Level3 created by Terraform"
  parent       = "level2"
  force_delete = true
}

First apply:
cloudtruth_project.test: Creating...
cloudtruth_environment.level3: Creating...
cloudtruth_environment.level2: Creating...
cloudtruth_environment.level1: Creating...
cloudtruth_environment.level1: Creation complete after 1s [id=29f5fb95-30e2-4a73-ada9-09f1393f312f]
cloudtruth_project.test: Creation complete after 1s [id=d5755c2f-6c37-4f6c-a98e-4bcd3be039f2]

│ Error: resourceEnvironmentCreate: lookupEnvironment: environment with name/ID level1 not found
│ Error: resourceEnvironmentCreate: lookupEnvironment: environment with name/ID level2 not found

Second apply:
cloudtruth_environment.level2: Creating...
cloudtruth_environment.level3: Creating...
cloudtruth_environment.level2: Creation complete after 1s [id=297ce6cb-a3ae-435e-95a6-ad0243dbc6f8]
╷
│ Error: resourceEnvironmentCreate: lookupEnvironment: environment with name/ID level2 not found
Third apply -
cloudtruth_environment.level3: Creating...
cloudtruth_environment.level3: Creation complete after 1s [id=c3ef5044-2815-49c1-8c29-c17b0ff6e4ca]

@EugeneAikashev thank you for find and logging this issue. It is fixed in v0.3.0. One other thing to note, in order to guarantee that Terraform creates the environments in the correct order, you should the resource property syntax to specify the names of the parent environments e.g.
`resource "cloudtruth_project" "test" {
name        = "test"
description = "This is a Test project created by Terraform"
force_delete = true
}
resource "cloudtruth_environment" "level1" {
name         = "level1"
description  = "Level1 created by Terraform"
parent       = "default"
force_delete = true
}
resource "cloudtruth_environment" "level2" {
name         = "level2"
description  = "Level2 created by Terraform"
parent       = "level1"
force_delete = true
}
resource "cloudtruth_environment" "level3" {
name         = "level3"
description  = "Level3 created by Terraform"
parent       = "level2"
force_delete = true
}`

@EugeneAikashev please let me know if you see any further issues with this functionality or the provider in general. Cheers.

@EugeneAikashev I'm closing this ticket now. Please reopen it if you see further issues or create a new one.


[bug] 2.7.0 have errors and don't open modal!!

Link to minimal reproducible example
mobile.dexgo.app
Summary
hey-listen.es.js:3 Uncaught (in promise) ReferenceError: process is not defined
at hey-listen.es.js:3:5
after upgrade this happens
List of related npm package versions
latest
import {
EthereumClient,
w3mConnectors,
w3mProvider,
WagmiCore,
WagmiCoreChains,
WagmiCoreConnectors
} from 'https://unpkg.com/@web3modal/ethereum'
  import { Web3Modal } from 'https://unpkg.com/@web3modal/html'

Polyfils were removed in 2.7.0, see https://github.com/WalletConnect/web3modal/releases/tag/2.7.0
Looks like you are using something that requires process.env, so you need to add that polyfil manually now


ci: Added new actions for test results

Checklist before requesting a review

[x] I have performed a self-review of my code.
[x] Implemented tests for new features.
[x] I tested the features already implemented.
[x] Added usage examples in the readme.

:tada: This PR is included in version 1.7.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Refactoring to fix the coding convension for folders and files

This is the changes for converting the Folder and File structures (#121).
I would like to do it per batch, so the other contributors won't have a total changes all at once.
And it would be easier to do the code review on smaller pieces of changes 😊
This is the parts i have refactored :

middleware/rate-limiter
modules/address
modules/animal
modules/bank-feed
modules/chat
modules/colors
modules/countries
modules/currencies

Note :
Some code seems doesn't changing, but detected as a change --> this is because of the reformatting (using auto-reformat) to follow the Prettier rule.

Hi @sherlyfebrianti96 Thanks for the work you have done, however we had another PR that finished off the work fully. 👍 Thank you for your contribution. Happy Hacktoberfest


feat: chrome behavior parity, allow debugging vscode

We use the Chrome debugger to debug VS Code itself. Launching this
depended on some specific behaviors  we didn't have before:

the URL is optional by default, only navigate
the page if a URL is provided
don't set the user data dir unless explicitly requested when a
custom runtime executable is provided
when a port is provided, skip scanning the browser stdout and instead
just poll for the debugger on that port (vscode's launch script
didn't display the magic string the launcher was after)
some cleanup as I was debugging in the chrome launcher; allow
providing the --remote-debugging-port to be equivalent to an
explicit port option.

Going to go ahead and merge this to enable self-hosting. Feel free to still drop comments here if there are any concerns though.


Add a doc for setting up SAML SSO using AWS

...it would also be nice to have a doc that explains the various attributes that users are asked to configure.

Sorry. I'm having a lot of trouble on this one. I actually don't think it's possible. I wasn't super familiar with SAML to start and by failing a few times at this I think I've got it much better and I believe the confusion is that AWS does offer SAML integration and can be a SAML service provider. This can be done with AWS SSO and AWS Cognito. But it does not have the capability to act as a SAML Identity Provider (IdP). It can, however, act as a OIDC IdP. As such, the docs can get confused between these two protocols leading someone to believe it's possible. The AWS Q copilot/ai will also tell you explicitly that no AWS service has the capability of being a SAML IdP. It does seem like AWS have hinted that they may one day offer this capability.
But until AWS offers this SAML IdP capability, you have to provide an existing third-party and external IdP into AWS SSO and AWS Cognito.
I also looked at other major tools that might have SSO SAML integration guides with AWS and I found they also don't have guides on this topic -- which helped me to be more confident with my research. There are also plenty of forums stating that AWS doesn't yet have this capability even though the posts were years old, which is why I kept researching incase the capability was added more recently.

Thanks for looking into this @GeoffMillerAZ . Going to close as wont-fix for now, since this seems like a topic that is more complicated than it looks (and also is likely not a real-world use case we need to cover).


"Could not find implementations for the following rules..." Message after upgrading to v5.0.0-beta.1

After upgrading from Version 4.5.0 to Version 5.0.0-beta.1 i recieve the following message when linting my files:
Could not find implementations for the following rules specified in the configuration:
[ERROR]     use-input-property-decorator
[ERROR]     use-output-property-decorator
[ERROR]     use-host-property-decorator
[ERROR] Try upgrading TSLint and/or ensuring that you have all necessary custom rules installed.
[ERROR] If TSLint was recently upgraded, you may have old rules configured which need to be cleaned up.

In Version 4.5.0 linting works without this message. I also updated tslint to v5.14.0 and Angular to v7.2.9.
I am not sure if thats a bug or what i need to do to get rid of this message.
The used tsconfig.json looks like this:
{
  "rulesDirectory": ["node_modules/codelyzer"],
  "extends": ["tslint:recommended", "rxjs-tslint-rules", "tslint-etc", "./tools/pa-rules"],
  "rules": {
    "max-classes-per-file": false,
    "arrow-parens": [true, "ban-single-arg-parens"],
    "trailing-comma": false,
    "interface-name": false,

    "throw-error": true,
    "no-unused-declaration": false,

    "rxjs-add": {
      "severity": "error"
    },
    "rxjs-no-unused-add": {
      "severity": "error"
    },
    "rxjs-no-unsafe-catch": true,
    "rxjs-no-unsafe-switchmap": true,
    "rxjs-finnish": {
      "options": [
        {
          "functions": false,
          "methods": false,
          "parameters": false,
          "properties": false,
          "variables": true
        }
      ],
      "severity": "warn"
    },
    "rxjs-no-deep-operators": true,
    "rxjs-no-internal": true,
    "rxjs-no-operator": true,
    "rxjs-no-patched": true,

    "align": {
      "severity": "warn",
      "options": [true, "parameters", "statements"]
    },
    "comment-format": {
      "options": ["check-space"],
      "severity": "warn"
    },
    "deprecation": {
      "severity": "warn"
    },
    "import-blacklist": [true, "rxjs/Rx"],
    "jsdoc-format": {
      "options": "check-multiline-start"
    },
    "max-line-length": { "severity": "warn", "options": { "limit": 140, "ignore-pattern": "^ *\\*" } },
    "member-access": false,
    "member-ordering": [
      true,
      {
        "order": ["static-field", "instance-field", "constructor", "static-method", "instance-method"]
      }
    ],
    "no-console": {
      "severity": "warn"
    },
    "no-empty": false,
    "no-inferrable-types": [true, "ignore-params", "ignore-properties"],
    "no-non-null-assertion": true,
    "no-string-literal": false,
    "no-switch-case-fall-through": true,
    "no-use-before-declare": false,
    "object-literal-key-quotes": [true, "as-needed"],
    "object-literal-sort-keys": false,
    "ordered-imports": {
      "severity": "warn",
      "options": {
        "import-sources-order": "case-insensitive",
        "module-source-path": "full",
        "named-imports-order": "case-insensitive"
      }
    },
    "quotemark": [true, "single", "avoid-escape"],
    "variable-name": {
      "options": ["ban-keywords", "check-format", "allow-pascal-case", "allow-leading-underscore"]
    },
    "no-consecutive-blank-lines": {
      "severity": "warn"
    },

    "directive-selector": [true, "attribute", "", "camelCase"],
    "component-selector": [true, "element", "pa", "kebab-case"],
    "no-output-on-prefix": true,
    "use-input-property-decorator": true,
    "use-output-property-decorator": true,
    "use-host-property-decorator": true,
    "no-input-rename": false,
    "no-output-rename": false,
    "use-life-cycle-interface": true,
    "use-pipe-transform-interface": true,
    "component-class-suffix": true,
    "directive-class-suffix": true,

    "no-this-assignment": true,
    "no-duplicate-imports": true,
    "no-trailing-whitespace": { "severity": "warn" },
    "space-within-parens": [true, 0],
    "ban-comma-operator": true,
    "no-duplicate-switch-case": true,
    "no-implicit-dependencies": [true, ["app", "environments", "electron"]],
    "prefer-object-spread": true,
    "no-object-literal-type-assertion": true,
    "no-sparse-arrays": true,

    "no-store-injection": {
      "severity": "warn"
    }
  }
}

Here are renames that we did:
contextual-life-cycle => contextual-lifecycle
no-conflicting-life-cycle-hooks => no-conflicting-lifecycle
no-life-cycle-call => no-lifecycle-call
use-life-cycle-interface => use-lifecycle-interface
decorator-not-allowed => contextual-decorator
enforce-component-selector => use-component-selector
no-output-named-after-standard-event => no-output-native
use-host-property-decorator => no-host-metadata-property
use-input-property-decorator => no-inputs-metadata-property
use-output-property-decorator => no-outputs-metadata-property
no-queries-parameter => no-queries-metadata-property
pipe-impure => no-pipe-impure
use-view-encapsulation => use-component-view-encapsulation
i18n => template-i18n
banana-in-box => template-banana-in-box
no-template-call-expression => template-no-call-expression
templates-no-negated-async => template-no-negated-async
trackBy-function => template-use-track-by-function
no-attribute-parameter-decorator => no-attribute-decorator
max-inline-declarations => component-max-inline-declarations
I'll update the changelog.

@mgechev , in the meantime, I'll pin this issue.

Hello @mgechev - did we release the changes? Thanks.

Yes, this we released over a month ago. Try 5.1.0.

Is it maybe possible to change the tslint message so that it shows the new key for a deprecated one?

Is it maybe possible to change the tslint message so that it shows the new key for a deprecated one?

It has to be like so!

I second ganqqwerty's request; if the old value has been deprecrated we should at least be informed of the new value.

I've got no idea how to fix my tslint.config now.
Based upon @mgechev comment above, many names were changed. But when I updated my tslint, it broke on the new names. Here's what I ended up with that appears to be working. That is until another arbitrary name change breaks my ide.
Seriously, can we dispense with this nonsense, and either support both names or provide a migration when updating so that I don't have to spend hours figuring out what happened. I have a job to do, and this kind of thing is a hindrance to my productivity.

@b2k Thank you.  Yours worked.


Headless fails to load units in MP

To reproduce:
Place AI, link to headless logic, place HeadlessClient and make it playable. Enable headless in modules and define logic name.
According to PZAI log, the arrayobjects include the game logics which have the AI units synced.
Only works in local SP. Local MP and Test Server has no AI. The test server had the headless client slotted and was amongst the clients.

According to the project status (https://github.com/Global-Conflicts-ArmA/Olsen-Framework-Arma-3/projects/1) the PZAI module hasn't been fully ported yet.

Closing for now, please re-raise if the issue persists after the module has been ported.


laser path problem in Unity 2022.3.6f1 and above

In versions of Unity 2022.3.6f1 and above, an issue where the path of the laser is not displayed when within a certain distance.

trynna fix in commit 50a2146 but not tested yet


Routes and RouterModule not being exported by @angular/router

OS?  Windows 7, 8 or 10. Linux (which distribution). Mac OSX (Yosemite? El Capitan?)
Ubuntu 16.04

Versions. Please run ng --version. If there's nothing outputted, please run
in a Terminal: node --version and paste the result here:

angular-cli: 1.0.0-beta.10
node: 6.3.0
os: linux x64

Repro steps. Was this an app that wasn't created using the CLI? What change did you
do on your code? etc.
App was created using angular-cli, angular-cli has been updated to the most recent version since then and ng init has been run to update files. I have also updated package.json to use Angular2 rc5.

The log given by the failure. Normally this include a stack trace and some
more information.

The Broccoli Plugin: [BroccoliTypeScriptCompiler] failed with:
Error: Typescript found the following errors:
  /home/rjcoupe/Projects/NewsHub/frontend/tmp/broccoli_type_script_compiler-input_base_path-QiI91S9Z.tmp/0/src/app/app.module.ts (3, 10): Module '"/home/rjcoupe/Projects/NewsHub/frontend/node_modules/@angular/router/index"' has no exported mng 'RouterModule'.
  /home/rjcoupe/Projects/NewsHub/frontend/tmp/broccoli_type_script_compiler-input_base_path-QiI91S9Z.tmp/0/src/app/app.routes.ts (1, 10): Module '"/home/rjcoupe/Projects/NewsHub/frontend/node_modules/@angular/router/index"' has no exported mng 'Routes'.

These errors are triggered by files that include the following lines:
import { Routes } from '@angular/router';
import { RouterModule } from '@angular/router';

Mention any other details that might be useful.

I'm trying to follow the documentation found at https://angular.io/docs/ts/latest/tutorial/toh-pt5.html

Thanks! We'll be in touch soon.

Did you follow the update guide? Your local install is outdated.

I'm on angular-cli@latest, rather than the webpack beta.

Check what version of the angular router you're on maybe? Could be that's outdated.

"@angular/router": "3.0.0-beta.2"
That's what package.json includes; AFAIK that's up to date but I'm very open to correction.

The router is on rc.1 now - try upgrading to that, and you should be good! :)

Perfect; thank you!

No worries, glad it worked out! ☺


Limited errors

Most of the time, people aren't interested in looking at every error at once (especially when forgetting one { throws off the rest of the parsing). This only reports a limited number of errors (default: 10) to prevent overwhelming the user.

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@c50116d). Click here to learn what that means.
The diff coverage is 42.62%.

@@            Coverage Diff            @@
##             master     #246   +/-   ##
=========================================
  Coverage          ?   77.44%
=========================================
  Files             ?       25
  Lines             ?     6158
  Branches          ?        0
=========================================
  Hits              ?     4769
  Misses            ?     1389
  Partials          ?        0

Impacted Files
Coverage Δ

src/main.rs
20.14% <0%> (ø)

tests/utils/mod.rs
85.07% <100%> (ø)

src/lib.rs
82.89% <95.65%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c50116d...4b81706. Read the comment docs.


ISSUE: Log filled with "No mail found" messages

Describe the bug
The integration is filling the logs with the message posted every 10 minutes:
[custom_components.mail_and_packages.helpers] No mail found. or
[custom_components.mail_and_packages.helpers] Mail image generated.
Suggest changing the log level to DEBUG, integrations should not be logging on regular updates
Environment (please complete the following information):

OS: Ubuntu
Type of device: NUC
Home Assistant version: 2022.4.0
Docker
Component version: 0.3.3-2

Logs
2022-04-12 12:03:13 INFO (SyncWorker_6) [custom_components.mail_and_packages.helpers] No mail found.
2022-04-12 12:13:19 INFO (SyncWorker_7) [custom_components.mail_and_packages.helpers] No mail found.
2022-04-12 12:23:24 INFO (SyncWorker_6) [custom_components.mail_and_packages.helpers] No mail found.

You have your default logging set to info level? Kinda chatty but if that's your bag, here's an easy fix:
logger:
  default: info
  logs:
    custom_components.mail_and_packages: error


Set default kernel to the latest Python version on creating a new Jupyter notebook or load a Jupyter notebok file

When a new Jupyter was created or an existing Jupyer notebook was loaded, user need to select the Kernel version in order to execute the Jupyter commands.
It is adivised to set the default kernel version to the latest Python version for newly created notebook or Jupyter notebook loaded from disk.

Thank you for filing this feature request.
kernels will not be changed to the latest version of Python environment for new or existing notebooks.
This is by design, its basically the MRU, we preserve the last used kernel for a notebook
For new notebooks, you will have to select one as we found that users can make the right decision. In the past Jupyter extension would attempt to select these by default but that failed a lot more than it was successful.
You can use this extension to change the default extension https://marketplace.visualstudio.com/items?itemName=donjayamanne.vscode-default-python-kernel

or an existing Jupyer notebook was loaded, user need to select the Kernel version in order to execute

This should not occur, this is definitely a bug if it does.
Please ensure you have the latest version of VS Code and Jupyter extension.
If this still persists for existing notebooks, then please do ping here or feel free to create a new issue.
Closing this as designed


adding comment for secret key minimum length

Thanks for contributing to pcf-pipelines. To speed up the process of reviewing your pull request please provide us with:

A short explanation of the proposed change: Improving documentation around passwords.

@haydonryan Please sign the Contributor License Agreement!
Click here to manually synchronize the status of this Pull Request.
See the FAQ for frequently asked questions.

@haydonryan Thank you for signing the Contributor License Agreement!

@haydonryan Thank you for signing the Contributor License Agreement!


Feature - Food Blog

Highlight on this pull request:

Scaffold rails application
Create authentication using devise gem
Create project model and add required association
Create MVP for a simple food blog website

Please note when cloning the project:

Live version link
Make sure that Tailwind CSS is correctly installed and compiled
Make sure that you have seeded the database or it will be just a blank project
In dev/test sqlite3 is used and in production env, PQ is used check Gemfile
I have cloned the project and everything seems to be working fine.


Support ImmutableJS Map as root state object

Updated functions per our conversation to add support for ImmutableJS Maps as root state object

Current coverage is 73.90% (diff: 90.90%)

Merging #72 into master will increase coverage by 0.04%

@@             master        #72   diff @@
==========================================
  Files           112        112
  Lines          2675       2683     +8
  Methods          77         77
  Messages          0          0
  Branches        282        282
==========================================
+ Hits           1976       1983     +7
- Misses          482        483     +1
  Partials        217        217

Powered by Codecov. Last update 015e766...afeffe4

Changes look good; let's confirm it fixes all of your issues before the MR.
Can you squash both (and any following commits) into a single commit?
I will add some test cases around the changes once the MR is complete.

Just as a general comment, this MR satisfies the case where the redux state atom is initialized as an Immutable map, instead of a plain JavaScript object. This does not alter the way the grid component functions, and although the grid internally uses Immutable data structures, that is an implementation detail that isn't exposed through the public API.
TLDR; by merging this MR, the component will be able to write and read state from the state atom as an object or an Immutable map.


MWPW-131760: fixes problem introduced by previuos PR

The previous PR removed the specificity of the CSS selector and reverted a previous fix
Resolves: MWPW-131760
Test URLs:

Before: https://main--milo--adobecom.hlx.page/tools/caas?martech=off
After: https://MWPW-131760--milo--adobecom.hlx.page/tools/caas?martech=off

This issue was resolved as part of this PR: https://github.com/adobecom/milo/pull/1330


Boostrap Modal disappears automatically when used with Navigation Wizard

Hello Folks,
I have an issue with Bootstrap Modal. I am using Bootstrap3.x for Modal and BootstrapWizard for custom navigation wizard. So both the libraries are necessary. When I click on Modal it disappears automatically. Can anyone help me on this?

Please provide a Reduced Test Case and list your browser and OS.

We are unable to provide assistance with third-party libraries such as BootstrapWizard.
Please ask on a BootstrapWizard-related venue or a Bootstrap community forum (e.g. StackOverflow, IRC, Slack; see https://github.com/twbs/bootstrap/blob/master/README.md#community ) instead.
Thank you for your understanding, and good luck.


knife bootstrap should support a --sudo-command argument

Description
I sometimes need to run knife bootstrap on a host with extra arguments to sudo.
Here's the patch I applied locally to /opt/chefdk/embedded/lib/ruby/gems/2.4.0/gems/chef-13.6.4/lib/chef/knife/bootstrap.rb to do this. If this makes sense I can submit a PR.
--- knife/bootstrap.rb	2018-09-25 16:57:28.000000000 -0500
+++ knife/bootstrap-mine.rb	2018-09-25 16:57:20.000000000 -0500
@@ -139,6 +139,10 @@
         :description => "Execute the bootstrap via sudo",
         :boolean => true

+      option :sudo_command,
+        :long => "--sudo-command COMMAND",
+        :description => "The sudo command to use on the remote host"
+
       option :preserve_home,
         :long => "--sudo-preserve-home",
         :description => "Preserve non-root user HOME environment variable with sudo",
@@ -463,7 +467,8 @@
         command = render_template

         if config[:use_sudo]
-          sudo_prefix = config[:use_sudo_password] ? "echo '#{config[:ssh_password]}' | sudo -S " : "sudo "
+          sudo_cmd = config[:sudo_command] || 'sudo'
+          sudo_prefix = config[:use_sudo_password] ? "echo '#{config[:ssh_password]}' | #{sudo_cmd} -S " : "#{sudo_cmd} "
           command = config[:preserve_home] ? "#{sudo_prefix} #{command}" : "#{sudo_prefix} -H #{command}"
         end

Example -- in this case I have access to a host where only headless users can sudo as root:
knife bootstrap -A somehost  -N somehost  -x jacob --sudo  -y --sudo-command 'sudo -u some_other_user sudo'

Hi @jacobtolar, sorry for the delayed response.
I think we have in place  --bootstrap-preinstall-command COMMAND option. You can run any desired command with or without sudo based on your need. Hope this will address your query?
Thanks!

Closing for now, hope the above workaround will work for you. Thanks

I want pass additional options to sudo during actual bootstrap.
Per this comment this still isn't really supported.
https://github.com/chef/chef/blob/63a4af262d777a80c24990368312c2f793eae11c/lib/chef/knife/bootstrap.rb
Since this has all been refactored, would you accept a pull request to add a new --sudo-options option?

Could you please try first with the latest chef-15 and provide the logs with your desired command?

Hey @jacobtolar, Feel free to open a PR and it would be good if you would mention something like:
 As a <<user_profile>>,
 I want to <<functionality>>,
 so that <<benefit>>.

Thanks!


RST-5494 Update lang attribute when language change

Jira
https://tools.hmcts.net/jira/browse/RST-5494

Created new up to date one


Unclear where to put requestAccessAndRefreshTokens(redirectURIWithQuery:state:)

i am following the tutorial to use authorization code flow, but do not know where to put the requestAccessAndRefreshTokens(redirectURIWithQuery:state:) code block. i tried searching in the example-app, but couldnt find it.

See also How the Authorization Process Works.

but i cant just copy paste that whole block of code, so what do i do to impliment it into my project?

Which UI framework are you using? SwiftUI, UIKit, or AppKit? If you're using SwiftUI, is the entry point to your app a type that conforms to App (the SwiftUI lifecycle) or is it an AppDelegate class that conforms to UIApplicationDelegate/NSApplicationDelegate?. Do you have a SceneDelegate? I need more information about your project in order to answer this question.


KAFKA-8874: Add consumer metrics to observe user poll behavior (KIP-517)

https://cwiki.apache.org/confluence/display/KAFKA/KIP-517%3A+Add+consumer+metrics+to+observe+user+poll+behavior
Committer Checklist (excluded from commit message)

[ ] Verify design and implementation
[ ] Verify test coverage and CI build status
[ ] Verify documentation (including upgrade notes)

Hi @harshach @omkreddy @hachikuji @bbejeck! I have an initial implementation completed however I am stuck on a couple questions:

Am I measuring poll in the right place (KafkaConsumer)? If yes, then I have separated metric measurement from main functionality by adding KafkaConsumerMetrics to KafkaConsumer similar to how Fetcher/FetchManagerMetrics and other internal classes do metrics. Hope this is right.
How can I force KafkaConsumer's poll(Duration timeout) to wait the full timeout and then return in unit tests? I can test the KafkaConsumerMetrics itself but I figure it would be better to test using KafkaConsumer's poll(). Do I need to spawn the KafkaConsumer in a separate thread, advance the MockTime, and then have the MockClient respond? Is this the best approach?

Hi @harshach @omkreddy @hachikuji @bbejeck, can I get a review for this so we can include this for 2.4.0 release as planned? Thanks.

retest this please

Hi @omkreddy @hachikuji @bbejeck, the code freeze for 2.4.0 is in a couple days. Are we able to close this out?

retest this please

Final bump as today is the code freeze date @omkreddy @hachikuji @bbejeck

Makes sense to me. I also added the metrics to the Monitoring docs.


Add multiclass classification test in raiwidgets

Description
It seems we don't test multiclass scenario in raiwidgets. It might be good to have as we add more end points for widgets flask server.
Checklist

[ ] I have added screenshots above for all UI changes.
[ ] I have added e2e tests for all UI changes.
[ ] Documentation was updated if it was needed.

Codecov Report

Merging #1576 (1b607b5) into main (4e97f7f) will increase coverage by 3.82%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1576      +/-   ##
==========================================
+ Coverage   88.03%   91.86%   +3.82%
==========================================
  Files         109       16      -93
  Lines        5291     1192    -4099
==========================================
- Hits         4658     1095    -3563
+ Misses        633       97     -536

Flag
Coverage Δ

unittests
91.86% <ø> (+3.82%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

...iwidgets/raiwidgets/model_performance_dashboard.py

raiwidgets/raiwidgets/__init__.py

raiwidgets/raiwidgets/error_analysis_constants.py

responsibleai/responsibleai/exceptions.py

...tabalanceanalysis/distribution_balance_measures.py

...tools/counterfactual/dashboard_schemas/__init__.py

...sibleai/responsibleai/rai_insights/rai_insights.py

...bleai/responsibleai/_managers/explainer_manager.py

raiutils/raiutils/dataset/dataset.py

.../raiutils/data_processing/data_processing_utils.py

... and 83 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4e97f7f...1b607b5. Read the comment docs.


:s/find/replace/g

Description
Adding /g to the end of a substitute command does not replace all occurrence of search but leaving off the /g ironically does!
Operation
Visual mode. Select a few lines. :s/foo/bar/g
Expected behaviour
Replace all ocurrences when /g is specified. It's a muscle memory from 20 years of vim.
Environments

Xcode Version 8.2.1
XVim branch and revision: master, d151997
Keyboard Language: en
Input source language: en

I'll second this. Except it actually causes my xcode to crash if I append the g at the end. Reproduced about 5 times before I came searching here.

I'm trying to use a functions but it's not working on my xvimrc. Maybe they forgot to add that functionality.

:%s/1/2/g replace all
:'<,'>s/1/2/g for visual lines
:s/1/2/g current line
:s/1/2 current line first occurrence
XVim works as expected. You remove '<,'> manually?


[FLINK-9962] [FS connector] allow users to specify TimeZone in DateTimeBucketer

What is the purpose of the change
allow users to specify TimeZone in DateTimeBucketer
Brief change log

add TimeZone as constructor param to DateTimeBucketer
add unit tests

Verifying this change
This change added tests and can be verified as follows:

add unit tests in DateTimeBucketerTest

Does this pull request potentially affect one of the following parts:

The S3 file system connector: (yes)

Documentation

Does this pull request introduce a new feature? (yes)
If yes, how is the feature documented? (JavaDocs)

Hi @bowenli86 ! Are you planning  to continue working on this issue? If not, I could work on that next week ;)

@kl0u I'll try to make it this week. If I can't,  feel free to work on it next week

Perfect! Thanks a lot @bowenli86 !

@kl0u  a couple things that may need attention:

powerMock needs to stay in order to mock static method ZoneId.systemDefault(). Didn't find a better way to mock static method with Mockito other than using PowerMockito. I believe what we have now should be fine.
SimpleDateFormat doesn't take java8's new LocalDateTime, so have to change formatter to DateTimeFormatter

Hi @bowenli86 ! I am in the process of reviewing the PR.
There is no need to mock ZoneId.systemDefault().
We have a constructor where we can specify the the ZoneId, so why not using this in order to provide a ZoneId?  This means that the testGetBucketPathWithDefaultTimezone will become:
@Test
public void testGetBucketPathWithDefaultTimezone() {
	ZoneId utc = ZoneId.of("UTC");
	DateTimeBucketAssigner bucketAssigner = new DateTimeBucketAssigner(utc);
	assertEquals("2018-08-04--06", bucketAssigner.getBucketId(null, mockedContext));
}

What do you think?

we'll miss a bit test coverage but I think removing that test is fine

@kl0u


Size of Avatars inside messages

When inserting avatars into messages via !avatar(id), they are currently oversized (or just not scaled down). See screenshot.
Zulip mobile v26.30.153, Android

I just tested this on my device, v26.30.153, Android, and the avatars are tiny for me.

I just tested this on my device, v26.30.153, Android, and the avatars are tiny for me.

Seems true for the Gravatars, but custom (uploaded) avatars are not scaled correctly. See:

@apxwn can you talk about how you're using !avatar()?  The feature has been removed for the Zulip 3.0 release, having never been documented, inconsistent syntax with the rest of markdown, and no clear use case (we know that it's only been used in a few dozen messages in 2020 in Zulip Cloud).
If there's a compelling use case we could add a new version without those problems.

@timabbott I used it to introduce a bot to the public. That's when I noticed it. The first screenshot here is actually this one use case.
It's not that compelling, of course, though I could think of rendered mentions with a tiny version of the avatar instead of the '@' in front of the name being quite good looking.

Thanks @apxwn for the report! Closing because this feature turns out to have been removed entirely in current Zulip Server releases.


OCMock revision different in dependency "GoogleUtilities"

firebase-ios-sdk Package.swift contains a dependency on OCMock with a different revision number than that in GoogleUtilities (another dependency). When you try and resolve package dependencies, xcode at times complains that the two revisions do not match and fails to resolve dependencies.
firebase-ios-sdk uses:
    .package(
      name: "OCMock",
      url: "https://github.com/erikdoe/ocmock.git",
      .revision("c5eeaa6dde7c308a5ce48ae4d4530462dd3a1110")
    ),

while GoogleUtilities uses:
.package(
      name: "OCMock",
      url: "https://github.com/firebase/ocmock.git",
      .revision("7291762d3551c5c7e31c49cce40a0e391a52e889")
    ),

@guidedways Thanks for the report. It's interesting that we haven't seen a problem with the two different references.
Would you explain more about your use case? Is there a consistent way to reproduce?
Either way, we can unify these in an upcoming release.

It looks like when we updated the Firebase repo for https://github.com/erikdoe/ocmock/pull/499, we did not update GoogleUtilities similarly

As you're aware, Swift PM support in Xcode is still meh. We only came across this recently when we tried to speed up package resolution. Instead of letting Xcode manage package resolution for us (and have it frequently refresh and fail for no obvious reason at times), we did the following:

Created a local Dependencies folder
Manually cloned all our dependencies (i.e. git clone https://path.to.package)
Dragged these into Xcode's workspace to create local file references

Using local file references for each package we were able to speed up package resolution. This way deleting DerivedData (if needed), performing a clean build or simply relaunching Xcode would no longer resolve each of these packages - it would only resolve sub-dependencies declared within these packages.
We noticed we could speed this up further by cloning sub-dependencies and including those as file references too. This worked for all our package dependencies except for FireBase - when we cloned GoogleUtilities, the following happened:
> xcodebuild -resolvePackageDependencies -workspace ... -scheme "..."
Output:
ocmock is required using two different revision-based requirements (c5eeaa6dde7c308a5ce48ae4d4530462dd3a1110 and 7291762d3551c5c7e31c49cce40a0e391a52e889), which is not supported

And that's how we found out that firebase-ios-sdk had a different revision to GoogleUtilities. xcodebuild wasn't happy about this.

Thanks for the explanation @guidedways. I've started a fix in https://github.com/google/GoogleUtilities/pull/73

GoogleUtilities 7.7.1 is now available for Swift Package Manager.


Update documentation about logLevels

The existing documentation about app framework log levels is slightly confusing to people, so I've tried to make it more obvious how things link to each other and to avoid pitfalls.

Just as a question, do you know whether we have an easy way to say I want to have as detailed logs for all components of all projects as possible?

@1000TurquoisePogs -- do we really need a "Note" here, or can we simply use this sentence as the introduction to this section? It's not clear which attributes this sentence refers to.


added an output attribute name_prefix

This variable will help to figure out the node names based on use_zone_info_for_names variable.
Signed-off-by: Yussuf Shaikh<EMAIL_ADDRESS>

/cc @cs-zhang @Prajyot-Parab @sajauddin @aishwaryabk


Device instantiation tests intermittently failing due to no event loop

E.g. https://github.com/DiamondLightSource/dodal/actions/runs/8550414641/attempts/1
--random-order-seed=818181 (from the run linked) does not reproduce this locally
 --random-order-seed=375256 does for me on main at time of writing
Acceptance Criteria

This doesn't happen any more

It's not just the device_instantiation test, it's possibly any/all using the RE fixture:
https://github.com/DiamondLightSource/dodal/actions/runs/8600634205/job/23566004115?pr=421

Yes, it looks like a race condition between creating the RE and the device, we should test the RE for liveness before yielding it from the fixture


Improve Windows threading performance scaling

Failed builds look related to PR #4092

Appveyor build (using old mingw version of gcc) failed with
lib/libopenblas.a(blas_server_win32.c.obj):blas_server_win32.c:(.text+0x3b8): undefined reference to `InterlockedCompareExchange64'

which does seem related to your changes - the others are just timing out after getting scheduled on old&slow hardware

Thank you, I will look into that. MarkSent from my iPhone XOn Jun 24, 2023, at 12:12 AM, Martin Kroeker @.***> wrote:
Appveyor build (using old mingw version of gcc) failed with
lib/libopenblas.a(blas_server_win32.c.obj):blas_server_win32.c:(.text+0x3b8): undefined reference to `InterlockedCompareExchange64'
which does seem related to your changes - the others are just timing out after getting scheduled on old&slow hardware
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you authored the thread.Message ID: @.***>

Appears to be a deficiency in (mingw-) GCC <= 5.3, I've now seen the gcc intrinsic __sync_val_compare_and_swap used as a replacement e.g. in https://github.com/migueldeicaza/mono-wasm-mono/blob/master/mono/utils/atomic.h (could probably be made conditional on GNUC being defined and less than 6)

It looks like the MSYS2 runners using gcc are stuck indefinitely during the test for SINGLE-DOUBLE_PRECISION_LAPACK_prototype_linear_equation_routines with this change.
Is that a deficiency in GCC from MSYS2? Or is there something odd with this change?

I was hoping it was just gh runners acting up, as I see no reason why the jobs would hang precisely there. Trying now with the stealth equivalent of #4102 reverted

I wonder if it had to do with re-entrancy in blas_async. I had that as a question. I will look. Can we get a callstack from the hang?Sent from my iPhone XOn Jun 27, 2023, at 1:46 AM, Martin Kroeker @.***> wrote:
I was hoping it was just gh runners acting up, as I see no reason why the jobs would hang precisely there. Trying now with the stealth equivalent of #4102 reverted
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you authored the thread.Message ID: @.***>

Seems to get stuck in dgetrf (from TESTING/LIN/xlintstds <dstest.in) :
(gdb) thr 1
[Switching to thread 1 (Thread 8604.0x2ba8)]
#0  0x000000010054cb7f in dgetrf_parallel (args=0xfff94150, range_m=0x0, range_n=0x0,
    sa=0x6ffff0000000, sb=0x6ffff0090000, myid=0) at getrf_parallel.c:627
627     getrf_parallel.c: No such file or directory.
(gdb) bt
#0  0x000000010054cb7f in dgetrf_parallel (args=0xfff94150, range_m=0x0, range_n=0x0,
    sa=0x6ffff0000000, sb=0x6ffff0090000, myid=0) at getrf_parallel.c:627
#1  0x000000010051bf3d in dgetrf_ (M=0xfff94600, N=0xfff94600, a=0xfffb8a60, ldA=0xfff9460c,
    ipiv=0xfffb0370, Info=0xfff94634) at lapack/getrf.c:115
#2  0x000000010050e9b2 in dsgesv (n=101, nrhs=1, a=..., lda=101, ipiv=..., b=..., ldb=101, x=...,
    ldx=101, work=..., swork=..., iter=-3, info=0) at dsgesv.f:417
#3  0x0000000100403833 in ddrvab (dotype=..., nm=11, mval=..., nns=4, nsval=..., thresh=30,
    nmax=132, a=..., afac=..., b=..., x=..., work=..., rwork=..., swork=..., iwork=..., nout=6)
    at ddrvab.f:313
#4  0x0000000100402af3 in dchkab () at dchkab.f:303
#5  0x0000000100402f3d in main (argc=1, argv=0x80004a810) at dchkab.f:364
#6  0x0000000180049b91 in dll_crt0_1 ()
    at /c/S/msys2-runtime/src/msys2-runtime/winsup/cygwin/dcrt0.cc:1053
#7  0x0000000180047716 in _cygtls::call2 (this=0xffffce00, func=0x180048a40 <dll_crt0_1(void*)>,
    arg=0x0, buf=buf@entry=0xffffcdf0)
    at /c/S/msys2-runtime/src/msys2-runtime/winsup/cygwin/cygtls.cc:40
#8  0x00000001800477c4 in _cygtls::call (func=<optimized out>, arg=<optimized out>)
    at /c/S/msys2-runtime/src/msys2-runtime/winsup/cygwin/cygtls.cc:27
#9  0x0000000000000000 in ?? ()
Backtrace stopped: previous frame inner to this frame (corrupt stack?)

with these threads
(gdb)  info thre
  Id   Target Id                      Frame
* 1    Thread 8604.0x2ba8 "xlintstds" 0x000000010054cb7f in dgetrf_parallel (args=0xfff94150,
    range_m=0x0, range_n=0x0, sa=0x6ffff0000000, sb=0x6ffff0090000, myid=0)
    at getrf_parallel.c:627
  5    Thread 8604.0x834 "sig"        0x00007ff8d86aed14 in ntdll!ZwReadFile ()
   from C:\WINDOWS\SYSTEM32\ntdll.dll
  6    Thread 8604.0x3030 "consm"     0x00007ff8d86af7a4 in ntdll!ZwWaitForMultipleObjects ()
   from C:\WINDOWS\SYSTEM32\ntdll.dll
  7    Thread 8604.0x968              0x00007ff8d86aecd4 in ntdll!ZwWaitForSingleObject ()
   from C:\WINDOWS\SYSTEM32\ntdll.dll
  8    Thread 8604.0x291c             0x00007ff8d86b28a4 in ntdll!ZwWaitForWorkViaWorkerFactory ()
   from C:\WINDOWS\SYSTEM32\ntdll.dll
  9    Thread 8604.0x3364             0x00007ff8d86b28a4 in ntdll!ZwWaitForWorkViaWorkerFactory ()
   from C:\WINDOWS\SYSTEM32\ntdll.dll
  19   Thread 8604.0xfb0              0x00007ff8d5d567ae in KERNELBASE!CtrlRoutine ()
   from C:\WINDOWS\System32\KernelBase.dll
(gdb)

(gdb) thr 5
[Switching to thread 5 (Thread 8604.0x834)]
#0  0x00007ff8d86aed14 in ntdll!ZwReadFile () from C:\WINDOWS\SYSTEM32\ntdll.dll
(gdb) bt
#0  0x00007ff8d86aed14 in ntdll!ZwReadFile () from C:\WINDOWS\SYSTEM32\ntdll.dll
#1  0x00007ff8d5c36e4b in ReadFile () from C:\WINDOWS\System32\KernelBase.dll
#2  0x0000000180139201 in wait_sig ()
    at /c/S/msys2-runtime/src/msys2-runtime/winsup/cygwin/sigproc.cc:1358
#3  0x0000000180046583 in cygthread::callfunc (this=this@entry=0x18023c840 <threads>,
    issimplestub=issimplestub@entry=false)
    at /c/S/msys2-runtime/src/msys2-runtime/winsup/cygwin/cygthread.cc:48
#4  0x0000000180046b46 in cygthread::stub (arg=arg@entry=0x18023c840 <threads>)
    at /c/S/msys2-runtime/src/msys2-runtime/winsup/cygwin/cygthread.cc:91
#5  0x0000000180047716 in _cygtls::call2 (this=0x10ece00,
    func=0x180046ac0 <cygthread::stub(void*)>, arg=0x18023c840 <threads>, buf=buf@entry=0x10ecd20)
    at /c/S/msys2-runtime/src/msys2-runtime/winsup/cygwin/cygtls.cc:40
#6  0x00000001800477c4 in _cygtls::call (func=<optimized out>, arg=<optimized out>)
    at /c/S/msys2-runtime/src/msys2-runtime/winsup/cygwin/cygtls.cc:27
#7  0x00007ff8d68626ad in KERNEL32!BaseThreadInitThunk () from C:\WINDOWS\System32\kernel32.dll
#8  0x00007ff8d866a9f8 in ntdll!RtlUserThreadStart () from C:\WINDOWS\SYSTEM32\ntdll.dll
#9  0x0000000000000000 in ?? ()
Backtrace stopped: previous frame inner to this frame (corrupt stack?)
(gdb) thr 6
[Switching to thread 6 (Thread 8604.0x3030)]
#0  0x00007ff8d86af7a4 in ntdll!ZwWaitForMultipleObjects () from C:\WINDOWS\SYSTEM32\ntdll.dll
(gdb) bt
#0  0x00007ff8d86af7a4 in ntdll!ZwWaitForMultipleObjects () from C:\WINDOWS\SYSTEM32\ntdll.dll
#1  0x00007ff8d5c6fcf9 in WaitForMultipleObjectsEx () from C:\WINDOWS\System32\KernelBase.dll
#2  0x00007ff8d5c6fbfe in WaitForMultipleObjects () from C:\WINDOWS\System32\KernelBase.dll
#3  0x000000018004791a in cygwait (object=object@entry=0x0, timeout=timeout@entry=0x288caf8,
    mask=mask@entry=5) at /c/S/msys2-runtime/src/msys2-runtime/winsup/cygwin/cygwait.cc:75
#4  0x000000018006ef58 in cygwait (mask=5, howlong=40, h=0x0)
    at /c/S/msys2-runtime/src/msys2-runtime/winsup/cygwin/cygwait.h:45
#5  cygwait (howlong=40, h=0x0) at /c/S/msys2-runtime/src/msys2-runtime/winsup/cygwin/cygwait.h:51
#6  cygwait (howlong=40) at /c/S/msys2-runtime/src/msys2-runtime/winsup/cygwin/cygwait.h:57
#7  fhandler_console::cons_master_thread (p=0x288cba0, ttyp=0x180000000)
    at /c/S/msys2-runtime/src/msys2-runtime/winsup/cygwin/fhandler_console.cc:569
#8  0x000000018007b6ee in cons_master_thread (arg=0x180359790)
    at /c/S/msys2-runtime/src/msys2-runtime/winsup/cygwin/fhandler_console.cc:216
#9  0x0000000180046583 in cygthread::callfunc (this=this@entry=0x18023c898 <threads+88>,
    issimplestub=issimplestub@entry=false)
    at /c/S/msys2-runtime/src/msys2-runtime/winsup/cygwin/cygthread.cc:48
#10 0x0000000180046b46 in cygthread::stub (arg=arg@entry=0x18023c898 <threads+88>)
    at /c/S/msys2-runtime/src/msys2-runtime/winsup/cygwin/cygthread.cc:91
#11 0x0000000180047716 in _cygtls::call2 (this=0x288ce00,
    func=0x180046ac0 <cygthread::stub(void*)>, arg=0x18023c898 <threads+88>,
    buf=buf@entry=0x288cd20) at /c/S/msys2-runtime/src/msys2-runtime/winsup/cygwin/cygtls.cc:40
#12 0x00000001800477c4 in _cygtls::call (func=<optimized out>, arg=<optimized out>)
    at /c/S/msys2-runtime/src/msys2-runtime/winsup/cygwin/cygtls.cc:27
#13 0x00007ff8d68626ad in KERNEL32!BaseThreadInitThunk () from C:\WINDOWS\System32\kernel32.dll
#14 0x00007ff8d866a9f8 in ntdll!RtlUserThreadStart () from C:\WINDOWS\SYSTEM32\ntdll.dll
#15 0x0000000000000000 in ?? ()
--Type <RET> for more, q to quit, c to continue without paging--
Backtrace stopped: previous frame inner to this frame (corrupt stack?)
(gdb) thr 7
[Switching to thread 7 (Thread 8604.0x968)]
#0  0x00007ff8d86aecd4 in ntdll!ZwWaitForSingleObject () from C:\WINDOWS\SYSTEM32\ntdll.dll
(gdb) bt
#0  0x00007ff8d86aecd4 in ntdll!ZwWaitForSingleObject () from C:\WINDOWS\SYSTEM32\ntdll.dll
#1  0x00007ff8d5c4480e in WaitForSingleObjectEx () from C:\WINDOWS\System32\KernelBase.dll
#2  0x000000010044a497 in blas_thread_server (arg=0x0) at blas_server_win32.c:233
#3  0x0000000180047716 in _cygtls::call2 (this=0x2a8ce00, func=0x10044a462 <blas_thread_server>,
    arg=0x0, buf=buf@entry=0x2a8cd20)
    at /c/S/msys2-runtime/src/msys2-runtime/winsup/cygwin/cygtls.cc:40
#4  0x00000001800477c4 in _cygtls::call (func=<optimized out>, arg=<optimized out>)
    at /c/S/msys2-runtime/src/msys2-runtime/winsup/cygwin/cygtls.cc:27
#5  0x00007ff8d68626ad in KERNEL32!BaseThreadInitThunk () from C:\WINDOWS\System32\kernel32.dll
#6  0x00007ff8d866a9f8 in ntdll!RtlUserThreadStart () from C:\WINDOWS\SYSTEM32\ntdll.dll
#7  0x0000000000000000 in ?? ()
Backtrace stopped: previous frame inner to this frame (corrupt stack?)
(gdb) thr 8
[Switching to thread 8 (Thread 8604.0x291c)]
#0  0x00007ff8d86b28a4 in ntdll!ZwWaitForWorkViaWorkerFactory ()
   from C:\WINDOWS\SYSTEM32\ntdll.dll
(gdb) bt
#0  0x00007ff8d86b28a4 in ntdll!ZwWaitForWorkViaWorkerFactory ()
   from C:\WINDOWS\SYSTEM32\ntdll.dll
#1  0x00007ff8d864536e in ntdll!RtlClearThreadWorkOnBehalfTicket ()
   from C:\WINDOWS\SYSTEM32\ntdll.dll
#2  0x0000000180047716 in _cygtls::call2 (this=0x2c8ce00,
    func=0x7ff8d8645080 <ntdll!RtlClearThreadWorkOnBehalfTicket+112>, arg=0x7f0ce0,
    buf=buf@entry=0x2c8cd20) at /c/S/msys2-runtime/src/msys2-runtime/winsup/cygwin/cygtls.cc:40
#3  0x00000001800477c4 in _cygtls::call (func=<optimized out>, arg=<optimized out>)
    at /c/S/msys2-runtime/src/msys2-runtime/winsup/cygwin/cygtls.cc:27
#4  0x00007ff8d68626ad in KERNEL32!BaseThreadInitThunk () from C:\WINDOWS\System32\kernel32.dll
#5  0x00007ff8d866a9f8 in ntdll!RtlUserThreadStart () from C:\WINDOWS\SYSTEM32\ntdll.dll
#6  0x0000000000000000 in ?? ()
Backtrace stopped: previous frame inner to this frame (corrupt stack?)
(gdb) thr 9
[Switching to thread 9 (Thread 8604.0x3364)]
#0  0x00007ff8d86b28a4 in ntdll!ZwWaitForWorkViaWorkerFactory ()
   from C:\WINDOWS\SYSTEM32\ntdll.dll
(gdb) bt
#0  0x00007ff8d86b28a4 in ntdll!ZwWaitForWorkViaWorkerFactory ()
   from C:\WINDOWS\SYSTEM32\ntdll.dll
#1  0x00007ff8d864536e in ntdll!RtlClearThreadWorkOnBehalfTicket ()
   from C:\WINDOWS\SYSTEM32\ntdll.dll
#2  0x0000000180047716 in _cygtls::call2 (this=0x2e8ce00,
    func=0x7ff8d8645080 <ntdll!RtlClearThreadWorkOnBehalfTicket+112>, arg=0x7f0ce0,
    buf=buf@entry=0x2e8cd20) at /c/S/msys2-runtime/src/msys2-runtime/winsup/cygwin/cygtls.cc:40
#3  0x00000001800477c4 in _cygtls::call (func=<optimized out>, arg=<optimized out>)
    at /c/S/msys2-runtime/src/msys2-runtime/winsup/cygwin/cygtls.cc:27
#4  0x00007ff8d68626ad in KERNEL32!BaseThreadInitThunk () from C:\WINDOWS\System32\kernel32.dll
#5  0x00007ff8d866a9f8 in ntdll!RtlUserThreadStart () from C:\WINDOWS\SYSTEM32\ntdll.dll
#6  0x0000000000000000 in ?? ()
Backtrace stopped: previous frame inner to this frame (corrupt stack?)
(gdb)

(this was built with msys-mingw64 (msys2 version 20190524), gcc 11.3 on a quad-core SkylakeX (Xeon W-2123) under Windows 11)

@martin-frbg Let me open a new branch on my side, with a PR to try to fix this. In optimizing away locks I removed one that may be questionable. That was a lock to handle re-entrancy to exec_blas_async(). I was not able to find a case where that happens. As a result, I removed a lock and logic that tested for and appended a new work queue to an existing one if a re-entrant call was made.
I can put that code back and see if it fixes the problem.

It looks to me like the only place in the entire codebase where exec_blas_async() is explicitly called is from lapack/getrf/getrf_parallel.c @ line 615. If that call can happen before the worker thread queue is drained work can be lost. So this looks like a race condition that maybe shows up only in this specific hw/sw configuration and test.
I will put the protection on that case back in place and send a new PR so we can see if that fixes it.

See PR #4112 for a possible fix.

OK, so I don't think that fixed it.
There must be an issue with exec_blas_async_wait() - my guess is the hang is related to the logic in that join point. getrf_parallel.c does some strange things explicitly calling exec_blas_async() and exec_blas_async_wait() along with inner_basic_thread(). I'll try to unravel that logic to understand what may be going on.

I guess I'll revert your contribution for now, just to avoid having the problematic behavior end up in somebody's build (or even distribution)

Yes, thank you and sorry. I will study the code further to see if I can come up with a better solution.
Do you know if it is possible to run that particular test that was failing in isolation? I'd like to debug it to understand the calling pattern better.

Sure - in lapack-netlib/TESTING, run LIN/xlintstds.exe with dstest.in as (standard) input. You can edit dstest.in to cut down the number of matrix sizes it tries performs, and to keep it from testing dposv as well. (Have not checked which matrix size shows the problem first though - backtrace suggests it is M=101)


escape $ properly when interpolating

Please provide test case that will fail with current implementaion first.

@PikachuEXE this is not a fix, this is simply a better way to write the same code :)


[Feature request] Include class names from .css as valid custom classes

Is your feature request related to a problem? Please describe.
For every custom class included in a tailwind.css file, It is needed to add them to the whitelist option for the no-custom-classname rule. For projects where custom classes are used a lot, this could be hard to keep track off.
/* tailwind.css */
@tailwind base;
@tailwind components;
@tailwind utilities;

@layer components {
    .btn {
        @apply p-4 border rounded
    }
   ...
}

Describe the solution you'd like
It would be nice if this plugin would include all classes created in the .css file  by default.
Perhaps in addition to whitelisting specific classes, it could also accept paths for .css files with classes that should be whitelisted.
Describe alternatives you've considered
Using the whitelist option for the no-custom-classname rule.

That would require using a 3rd party CSS parser which "understands" Tailwind CSS's directive such as @layer...
Do you have any recommendations ?
I'll do some researches about his one.

I've not investigated this in detail at all, but the tailwindcss-intellisense might be a nice reference.
For example: https://github.com/tailwindlabs/tailwindcss-intellisense/blob/master/src/lib/extractClassNames.ts to process css-files and get class names.

Indeed I found out about the postcss-selector-parser 👍
You can also find other candidates on https://astexplorer.net/

What should be the strategy for choosing the CSS files to be parsed ?

tailwind.css off course

but possibly all the css files under the project root folder...

e.g. /src/components/button/button.module.css
e.g. /src/components/menu/menu.module.css
...

What do you think ?

Indeed I found out about the postcss-selector-parser 👍
You can also find other candidates on https://astexplorer.net/

What should be the strategy for choosing the CSS files to be parsed ?

tailwind.css off course

but possibly all the css files under the project root folder...

e.g. /src/components/button/button.module.css
e.g. /src/components/menu/menu.module.css
...

What do you think ?

Looks good to me 💯

It would make sense to have it as a user defined glob, so it doesn't just happen automatically. It should also not include .module.css, since those files are imported as JS objects inside the code.

@thebuilder, do you mean that the fact that the .module.css files are scoped their content should not be used to whitelist valid classnames globally ?
I think the .module.css files could still be used to declare classnames with @apply.
I wonder how to make sure it does not pollute the whitelist for all other contextes.

Even if you use @apply in a CSS module, it will still be outputted in JS generated/hashed classname - So yeah, don't think it makes sense. Or am I missing something?

@thebuilder & @adamlindqvist let me know what you think about the PR !
First I did attempt to make the loading/parsing of css file asynchronous but from what I understood eslint rules must be synchronous by design.

@francoismassart regarding the default CSS filter list, I think it should be expanded a bit more:

Exclude build output

Ignore dist
Ignore *.min.css

Is it possible to get the ignore list from .eslintignore? That would serve as a good base.


Got an error

I'm not sure what's wrong, but it says:
Error: {"message":"Expected NAME, actual: EQUALS (\"=\") at [4, 99]"}

https://github.com/pmndrs/jotai/actions/runs/10676130977/job/29589169790

I am getting the same error here


Make make tail recursive

make would recursively pattern match on the result of recursive computations. That's not great if there are many of them, so stop doin that. The modified code is also arguably easier to read.
Fixes #nnnn
Scope:
Estimate:

Review checklist
The author performs the actions on the checklist. The reviewer evaluates the work and checks the boxes as they are completed.

[ ] Summary. Write a summary of the changes. Explain what you did to fix the issue, and why you did it. Present the changes in a logical order. Instead of writing a summary in the pull request, you may push a clean Git history.
[ ] Documentation. Write documentation for new functions. Update documentation for functions that changed, or complete documentation where it is missing.
[ ] Tests. Write unit tests for every change. Write the unit tests that were missing before the changes. Include any examples from the reported issue as integration tests.
[ ] Clean up. The changes are already clean. Clean up anything near the changes that you noticed while working. This does not mean only spatially near the changes, but logically near: any code that interacts with the changes!

I just realized this could be bad for performance if MultiOrTop is pretty common; in that case it's better to wait and see if the Set will be needed until the end, rather than building it eagerly. Does anyone know?

I made changes to MultiOr last and it was somewhat tricky to get right. From what I remember it is called fairly often? I suggest you profile a run with your change vs master and look at the profiles. I found using speedscope useful for seeing the calls to make.

Here's the basic performance report.
perf-rep.pdf.
I'll add profiling when I can.

Differences are indeed negligible, I think we can just merge this.


Fit and Finish enhancements

Description

Fit and Finish enhancements
Fixed all header sizes
Added iconType "+ symbol" for create workflow button.
Changes all the button sizes to small
Compressed tabs and Forms
Changed the padding sizes where needed

Check List

[] New functionality includes testing.

[ ] All tests pass

[ ] New functionality has been documented.
[x] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

After the enhancements , below are the screenshots (Used NewHomePage)

Resolved merge conflicts


gutterWidth is necessary for makeResponsive column calculation

gutterWidth={0} is necessary for makeResponsive column calculation. u should add the default gutterWidth value (0) to the calculation otherwise it will always display 4 columns (defaultColumns)

Good spot thanks I'll get this fixed.

Should be fixed in v0.3.6.


added extra fields during logging, catch invalid rule error, more timers

Coverage decreased (-0.2%) to 87.784% when pulling 11bf2b6cac3409357934d9b23bf4d4c9dcf2cc48 on feature/improvements into 40b01895b76e8ec33539ae72905543bee3255753 on develop.


remove npm workspaces

remove npm "workspaces". pnpm uses pnpm-workspace.yaml instead.
yarn: "warning Workspaces can only be enabled in private projects"
fixes #218

Thanks for making this change! I was just curious when you think this will be released?

Sorry about that @rathpc ! I thought it had been automatically released when merged, but I guess semantic-release wasn't properly configured for watching the package.json file. #224 fixed it and it should be in v1.3.6

Thank you!!


Deprecate AnnotatedSchemaConveyor and CompositeSchemaConveyor

Q
A

Is bugfix?
❌

New feature?
❌

Breaks BC?
❌

Starting from version spiral/attributes v3.1.3, AnnotationReader is marked as deprecated in favor of AttributeReader:
https://github.com/spiral/attributes/pull/13
Therefore, Yiisoft\Yii\Cycle\Schema\Conveyor\AnnotatedSchemaConveyor and Yiisoft\Yii\Cycle\Schema\Conveyor\CompositeSchemaConveyor, which use it, are marked as deprecated. The documentation has been corrected to show the use of Yiisoft\Yii\Cycle\Schema\Conveyor\AttributedSchemaConveyor by default.

These classes can be removed instead of marking them as deprecated because there is no release yet.

These classes can be removed instead of marking them as deprecated because there is no release yet.

May be later

These classes can be removed instead of marking them as deprecated because there is no release yet.

I agree with you, but we have not yet removed support for annotations in spiral/attributes and cycle/annotated. We've only marked them as deprecated. And I didn't dare to completely remove them from this package yet.


Bind mounts are not working

Description of problem
# docker run -d -it -v /tmp/test:/tmp/test:rslave --runtime kata-runtime --name test ubuntu
# /tmp/
├── files
│   ├── aaa
│   └── bbb
├── test
# mount --bind /tmp/files/ /tmp/test/
# tree /tmp/
/tmp/
├── files
│   ├── aaa
│   └── bbb
├── test
│   ├── aaa
│   └── bbb
# docker exec -it test bash
root@6fd1a2448b1f:/# ls -lh /tmp/test/
total 0
root@6fd1a2448b1f:/#

New version of kata-time is the same:
# ./kata-runtime -v
kata-runtime  : 1.5.0
   commit   : e8a8e0db799564683fb891dd4566af366e270e90
   OCI specs: 1.0.1-dev

Expected result
(replace this text with an explanation of what you thought would happen)
Actual result

Meta details
Running kata-collect-data.sh version 1.5.0 (commit 5f7fcd7) at 2019-02-28.19:26:57.081206665+0800.

Runtime is /usr/bin/kata-runtime.
kata-env
Output of "/usr/bin/kata-runtime kata-env":
[Meta]
  Version = "1.0.20"

[Runtime]
  Debug = false
  Trace = false
  DisableGuestSeccomp = true
  DisableNewNetNs = false
  Path = "/usr/bin/kata-runtime"
  [Runtime.Version]
    Semver = "1.5.0"
    Commit = "5f7fcd7"
    OCI = "1.0.1-dev"
  [Runtime.Config]
    Path = "/usr/share/defaults/kata-containers/configuration.toml"

[Hypervisor]
  MachineType = "pc"
  Version = "QEMU emulator version 2.11.0\nCopyright (c) 2003-2017 Fabrice Bellard and the QEMU Project developers"
  Path = "/usr/bin/qemu-lite-system-x86_64"
  BlockDeviceDriver = "virtio-scsi"
  EntropySource = "/dev/urandom"
  Msize9p = 8192
  MemorySlots = 10
  Debug = false
  UseVSock = false

[Image]
  Path = "/usr/share/kata-containers/kata-containers-image_clearlinux_1.5.0_agent_a581aebf473.img"

[Kernel]
  Path = "/usr/share/kata-containers/vmlinuz-<IP_ADDRESS>-18.container"
  Parameters = "init=/usr/lib/systemd/systemd systemd.unit=kata-containers.target systemd.mask=systemd-networkd.service systemd.mask=systemd-networkd.socket"

[Initrd]
  Path = ""

[Proxy]
  Type = "kataProxy"
  Version = "kata-proxy version 1.5.0-9e77a0b"
  Path = "/usr/libexec/kata-containers/kata-proxy"
  Debug = false

[Shim]
  Type = "kataShim"
  Version = "kata-shim version 1.5.0-efbf3bb"
  Path = "/usr/libexec/kata-containers/kata-shim"
  Debug = false

[Agent]
  Type = "kata"

[Host]
  Kernel = "4.9.0-6-amd64"
  Architecture = "amd64"
  VMContainerCapable = true
  SupportVSocks = false
  [Host.Distro]
    Name = "Debian GNU/Linux"
    Version = "9"
  [Host.CPU]
    Vendor = "GenuineIntel"
    Model = "Intel(R) Xeon(R) CPU E5-2650 v4 @ 2.20GHz"

[Netmon]
  Version = "kata-netmon version 1.5.0"
  Path = "/usr/libexec/kata-containers/kata-netmon"
  Debug = false
  Enable = false

Runtime default config files
/etc/kata-containers/configuration.toml
/usr/share/defaults/kata-containers/configuration.toml

Runtime config file contents
Config file /etc/kata-containers/configuration.toml not found
Output of "cat "/usr/share/defaults/kata-containers/configuration.toml"":
default

Runtime logs
Recent runtime problems found in system journal:
time="2019-02-28T19:09:20.175852299+08:00" level=warning msg="fetch sandbox device failed" arch=amd64 command=create container=db5b6c01e0338dbd1f9d22286a211c4a2006c633b321c5f4e7382c2a38ab29fb error="open /run/vc/sbs/db5b6c01e0338dbd1f9d22286a211c4a2006c633b321c5f4e7382c2a38ab29fb/devices.json: no such file or directory" name=kata-runtime pid=4097 sandbox=db5b6c01e0338dbd1f9d22286a211c4a2006c633b321c5f4e7382c2a38ab29fb sandboxid=db5b6c01e0338dbd1f9d22286a211c4a2006c633b321c5f4e7382c2a38ab29fb source=virtcontainers subsystem=sandbox
time="2019-02-28T19:11:32.875029009+08:00" level=warning msg="fetch sandbox device failed" arch=amd64 command=create container=6fd1a2448b1f6b61e79fb6d68df0c91e60db8f16ab5dc2cf298c54b83da09614 error="open /run/vc/sbs/6fd1a2448b1f6b61e79fb6d68df0c91e60db8f16ab5dc2cf298c54b83da09614/devices.json: no such file or directory" name=kata-runtime pid=4572 sandbox=6fd1a2448b1f6b61e79fb6d68df0c91e60db8f16ab5dc2cf298c54b83da09614 sandboxid=6fd1a2448b1f6b61e79fb6d68df0c91e60db8f16ab5dc2cf298c54b83da09614 source=virtcontainers subsystem=sandbox

Proxy logs
Recent proxy problems found in system journal:
time="2019-02-28T19:11:17.976413901+08:00" level=fatal msg="failed to handle exit signal" error="close unix @->/run/vc/vm/db5b6c01e0338dbd1f9d22286a211c4a2006c633b321c5f4e7382c2a38ab29fb/kata.sock: use of closed network connection" name=kata-proxy pid=4159 sandbox=db5b6c01e0338dbd1f9d22286a211c4a2006c633b321c5f4e7382c2a38ab29fb source=proxy

Shim logs
No recent shim problems found in system journal.
Throttler logs
No recent throttler problems found in system journal.

No rpm

Hi @running99 - just to clarify, you are testing that bind mounts on the host appear inside an already active container mount point, yes?
/cc @devimc @sboeuf for input.

Yes,  @grahamwhaley

9p issue, bind mounts are not propagated

@sboeuf This is a limitation of 9p -  symlinks, bind-mounts not getting propogated.
Would virtio-fs solve this?

@amshinde

Would virtio-fs solve this?

Yes! I just tried it out to double check and I can confirm this works.

@running99 This is a 9p bug unfortunately. This should be solved once we move to vitio-fs.
cc @egernst

Was just taking another look at this.
As far as I can see this is primarily caused due to the fact that we set private mount propogation for the rootfs, introduced by this change to mitigate the docker cp issue.
https://github.com/kata-containers/runtime/pull/980/commits/b029e442b2eeb4807feaa60f5d8ea7fe30c03c5a
This is not really a 9p inherent issue. So the questions is when we move to virtio-fs, do we still need private propogation (most likely?) and will we still face this issue.
cc @sboeuf @devimc @egernst

On a separate notes, we should gather all the issues we have encountered with 9p storage (in a single github issue perhaps) to keep track and test that these are  solved with virtio-fs.

@amshinde this is very likely that we will run into the same issue if we set private mount propagation, even in the virtio-fs case.

@amshinde  I don't think so since the fuse daemon can monitor the merge directory directly

@amshinde i can't find such type issue based on kata1.5 & kata1.6 + centos 7.3 (3.10) & Ubuntu 18.04(4.15). It seems related with host OS.


Add support for custom user variables in CLI

You can setup custom user variables in the configuration file: https://testcafe.io/403403/release-notes/framework/2021-9-8-testcafe-v1-16-0-released#support-for-custom-user-variables-in-the-configuration-file
The similar functionality would be useful in CLI

Yes, please. I don't see the point of userVariables existing if you can't override it.

I totally agree,
We have a url variable defined in the configuration file. This works great for CI, but if I want to run the tests locally, I need to change the domain name.
With CLI support I would call the command with the --user-variables url:https://localhost.... option.
currently, I have to edit the config file and discard the changes later, or I can create a development version of the config file, but I have to keep the development config file in sync with the original.

After additional research, we decided not to implement this functionality. There are different workarounds for this issue. The first one is to use a JS configuration file that defines user variables from the environment variables. In this case, you can specify environment variables via CLI, and they will be applied to the userVariables field.
Another solution is to use multiple JS config files with inheritance. For example:
//common-config.js
module.exports = { src: “” }

//prod-user-var.js
const commonSettings = require(‘./common-config’)
module.exports = {
…commonSettings,
userVariables: { someVar: ‘test’ }
}

//dev-user-var.js
const commonSettings = require(‘./common-config’)
module.exports = {
…commonSettings,
userVariables: { someDevVar: ‘test2’ }
}

testcafe –config-file prod-user-var.js
testcafe –config-file dev-user-var.js


Grid view for files

Is your feature request related to a problem? Please describe.
Currently, there is only a list view. Most file managers support a grid view with big icons.
Describe the solution you'd like
Implement a grid view. It should be possible to toggle between a list and grid using a toggle/shortcut.
Describe alternatives you've considered
N/A
Additional context
N/A

Added in v0.9.0


fix: Minor fixes in docs and style

Ran gofumpt -w . to force style.
The comments were off (your editor seems to add two spaces in subsequent comments - this throws off the godoc interpreter. Examples/explanation:
// this is a broken
//  comment because only one space allowed after //

// this is a good comment because two spaces will render syntax highlighting
//  {"rendered":"withhighlighting"}

// this is a normal and
// good comment

You can check how the stuff gets rendered with:
go install golang.org/x/tools/cmd/godoc@latest

# from within your project where go.mod lives
godoc -http :6060 # open page and click on your project

I left some TODO in certain doc strings for exposed types/functions which need to be added/clarified.
Signed-off-by: Michael Gasch<EMAIL_ADDRESS>

Codecov Report

Merging #45 (6d042a3) into main (be2f73f) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #45      +/-   ##
==========================================
- Coverage   93.86%   93.84%   -0.03%
==========================================
  Files          15       15
  Lines        1761     1755       -6
==========================================
- Hits         1653     1647       -6
  Misses         74       74
  Partials       34       34

Impacted Files
Coverage Δ

core_matcher.go
94.95% <ø> (-0.05%)
:arrow_down:

field_matcher.go
100.00% <ø> (ø)

live_pattern_state.go
100.00% <ø> (ø)

pruner.go
97.98% <ø> (-0.03%)
:arrow_down:

quamina.go
87.67% <ø> (ø)

rebuilding.go
100.00% <ø> (ø)

small_table.go
99.40% <ø> (ø)

stats.go
83.78% <ø> (ø)

flatten_json.go
95.42% <100.00%> (-0.02%)
:arrow_down:

value_matcher.go
97.48% <100.00%> (+0.01%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update be2f73f...6d042a3. Read the comment docs.

It's not my editor, I like to extent lines in long descriptions to achieve a paragraph-like effect and improve readability for humans.  But if it's nonstandard, fine.  Nice tool; I'm surprised that a few of those things weren't caught by the linter.


[ISSUE #4683] Documentation Needed for eventmesh-connector-redis

Fixes #4683.
Motivation
Explain the content here.
Explain why you want to make the changes and what problem you're trying to solve.
Modifications
Describe the modifications you've done.
Documentation

Does this pull request introduce a new feature? (yes / no)
If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
If a feature is not applicable for documentation, explain why?
If a feature is not documented yet in this PR, please create a followup issue for adding the documentation

I have a small suggestion. It would be better to use RabbitMQ instead of rabbitmq, and the same applies to MongoDB and Redis.


Add IGetSetNetwork for IBitcoinSerializable objects that serialize di…

…fferently depending on Network

Not in line with most recent discussion. Closing this.


[byteorder] Implement core::ops traits

Release 0.7.6

Not sure whether the added test will pass Kani; I tried locally, and it hung for a long time and I eventually gave up. It's a very simple test, so I'm not worried about its correctness; if Kani can't handle it, I'll just disable Kani on that test rather than try to refactor the test to get it to work.

Not sure whether the added test will pass Kani; I tried locally, and it hung for a long time and I eventually gave up. It's a very simple test, so I'm not worried about its correctness; if Kani can't handle it, I'll just disable Kani on that test rather than try to refactor the test to get it to work.

Kani wasn't able to complete the proof after 6 hours, so I've disabled it on test_ops_implss.


Failed at step CAPABILITIES

doh-server.service: Failed at step CAPABILITIES spawning /usr/local/bin/doh-server: Invalid argument

The reason is that the debian kernel is too old, update the kernel to solve


Add pagination to cost management Query API

Changelog
Add a changelog entry for this PR by answering the following questions:

What's the purpose of the update?

[ ] new service onboarding
[X] new API version
[ ] update existing version for new feature
[ ] update existing version to fix swagger quality issue in s360
[ ] Other, please clarify

Add "$skipToken" parameter to CostManagement Query API for pagination.
The nextLink element already exists in response and already contains the "$skipToken" parameter.
We already can send the "$skipToken" as a query parameter and it works but it doesn't appear in the API spec.
This pull request simply declares the "$skipToken" parameter in CostManagement Query API specs.
(Query_Usage and Query_UsageByExternalCloudProviderType)
Linked to another pull request to Azure SDK for Java : https://github.com/Azure/azure-sdk-for-java/pull/29381

When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.

July 2022

When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.

July 2022

If updating an existing version, please select the specific language SDKs and CLIs that must be refreshed after the swagger is published.

[X] SDK of .NET (need service team to ensure code readiness)
[X] SDK of Python
[X] SDK of Java
[X] SDK of Js
[X] SDK of Go
[X] PowerShell
[X] CLI
[X] Terraform
[ ] No refresh required for updates in this PR

Contribution checklist:

[ ] I commit to follow the Breaking Change Policy of "no breaking changes"
[ ] I have reviewed the documentation for the workflow.
[ ] Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?
If any further question about AME onboarding or validation tools, please view the FAQ.

I don't have access to contribution documentation.
ARM API Review Checklist

Applicability: :warning:
If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

Change to data plane APIs
Adding new properties
All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

[X] Check this box if any of the following appy to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review.  Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.

Adding a new service
Adding new API(s)
Adding a new API version
-[ ] To review changes efficiently, ensure you are using OpenAPIHub to initialize the PR for adding a new version. More details, refer to the wiki.

I don't have access to this documentation.

[ ] Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

I don't have access to this documentation.

[ ] If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist
If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.

[ ] Removing API(s) in a stable version
[ ] Removing properties in a stable version
[ ] Removing API version(s) in a stable version
[X] Updating API in a stable or public preview version with Breaking Change Validation errors
[ ] Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.

The first commit needs to be the previous api version and the new changes should only be added in the subsequent commits. This is explained in detail here (If using Open API which is recommended) https://dev.azure.com/azure-sdk/internal/_wiki/wikis/internal.wiki/208/OpenAPI-Hub-Adding-new-API-version or here(For manual process) : https://dev.azure.com/azure-sdk/internal/_wiki/wikis/internal.wiki/83/Manual-Process-Adding-new-API-version . Please remove the "ARMChangesRequested" tag once you have fixed this issue.

The first commit needs to be the previous api version and the new changes should only be added in the subsequent commits. This is explained in detail here (If using Open API which is recommended) https://dev.azure.com/azure-sdk/internal/_wiki/wikis/internal.wiki/208/OpenAPI-Hub-Adding-new-API-version or here(For manual process) : https://dev.azure.com/azure-sdk/internal/_wiki/wikis/internal.wiki/83/Manual-Process-Adding-new-API-version . Please remove the "ARMChangesRequested" tag once you have fixed this issue.

Hello,
I'm not a Microsoft employee or even a contributor. I am a customer.
The provided azure devops links are not public (getting 401 error). Could you point me to the appropriate procedure ?

Hi @GuillaumeColom , hope the following message help.
Please note that it is time-consuming to review the file line by line for every api-version. When you are creating the swagger specification for the new api-version, please copy the swagger specification from the previous version into the new api-versioned folder and commit it. After that overwrite it with the changes for the new api-version. This makes it easy for us to review the changes.
Update and commit the specification files as needed to the master of your forked repository or to any branch in your forked repository.
Submit a pull request to the master branch of the azure-rest-api-specs repository  from the master of your fork or whichever branch you committed your changes to (more info on creating pull requests ).


SCP transfrer break when enabling bash-it

If i enable bash it and make my .bashrc a link to .bash_profile whenever I try to do an SCP transfer instead of transferring the file it echos out the last directory used.

@vpassapera On the off chance that you're reading this - is this still an issue for you? If it is - a couple of questions for you:

Which OS/Linux distro are you using?
We've made a couple of changes to the installer to select the correct file based on the OS, i.e. for Linux we're installing into .bashrc now - which should avoid the above problem. Have you tried this change, and has it fixed your issue? See #173 for more details...

CC @edubxb

This does not fix the problem. I use Ubuntu 14.04.1 and have pulled the latest bash-it version. then sourced my .bashrc and tried the following command:
scp name@ubuntu:~/.bashrc BASHRC
Which should technically use scp to copy my local .bashrc via SSH back into BASHRC (this is a hypothetical test here). All I get is the directory and no file copied.

@namtrah can you put here the output of the error you get then doing this?

@nwinkler I completely forgot about this issue.
I actually eventually solved the problem so long ago, I don't even remember what I did.
Thank's for the follow up though!


How to segment into short SRT text segments?

Hello!  Great tool, thank you for making it.  I successfully ran a batch on a folder and everything worked great.  However, after some adjustments made to text_chunk_size and max_chunk configuration params, the SRT outputs are all the same.  I tried changing the defaults found in the repo from 14500 and 2  to 14 and 1 respectively.  The SRT outputs are segmented the same.   Is there any way to adjust the amount of segments the SRT is broken down into?
Many thanks for your time!

I issued a pull request for this.  Seems to work.


Question: how to add resources in specific environments

I have a question regarding the best-practice when separating resources in environments.
Using the example code in https://github.com/gruntwork-io/terragrunt-infrastructure-modules-example and https://github.com/gruntwork-io/terragrunt-infrastructure-live-example.
Example: I would like to add an IAM role to the stage environment but not in production, how would I handle this?
Thank you!

So based on how-is-the-code-in-this-repo-organized
How I do it is:

Create a generic module for IAM Role on the modules repo.
Add the resource in the corresponding path I want to use it:
account
└ _global
└ region
└ _global
└ stage
└ resource -> IAM Role
└ production
└ resource

Make sure the IAM role have access to only other staging resources based on the policy you will create.
I hope that makes sense arthurk.

If stage and production should have different IAM Roles, I cannot include the same module. Should I write two modules (iam-staging, iam-prod)?

I think that's the easiest way to go initially yes.
Another way is with an if statement if you have all roles in a single module:
# Stage role
resource "aws_iam_role" "stage" {
  count = "${var.create_stage_role ? 1 : 0}"
.
.
.
}

Investigate this here
Regarding best practise I am not sure, someone else might be able to give an advise. I would love to hea @brikis98 suggestion.

Please read https://github.com/gruntwork-io/terragrunt#keep-your-terraform-code-dry.

The idea is that you define the Terraform code for your infrastructure just once, in a single repo, called, for example, modules [...]
This repo contains typical Terraform code, with one difference: anything in your code that should be different between environments should be exposed as an input variable.

So create your IAM role module and anything in that module that should behave differently in different environments should be exposed as an input variable. You can then have a stage/iam-roles/terraform.tfvars that sets the appropriate values for stage and a prod/iam-roles/terraform.tfvars that sets the appropriate values for prod.

I think I explained a little unclear. My problem is this: I make a generic IAM module that has the following code in it:
resource "google_project_iam_member" "project" {
  project = "${var.projectid}"
  role    = "${var.role}"
  member  = "user:${var.email}"
}

but now in stage environment i would like 3 google_project_iam_member resources but in production environment I want only 1 google_project_iam_member resource. My question is how I can create a module that makes either 1 or 3 resources depending on the environment. I guess I'd have to make changes in the -live repo, but I'm not sure what to change.

Take in the list of member names as an input variable and use count to loop over each name and create multiple google_project_iam_member resources. https://blog.gruntwork.io/terraform-tips-tricks-loops-if-statements-and-gotchas-f739bbae55f9

@brikis98 thank you very much for the answer. I really appreciate you answering questions in github issues, not everyone does that.

No prob!


Not found page without redirect

Today, not found page error make a redirect.
Should be cool if user stay on wrong uri but see not found page.

done with e7a6c9e3017921191d9321a54eee8c24e214c44b


Rats (and other scavengers) can eat corpses to regain some health?

Make rats slightly more interesting...

As per NetHack, eating a corpse could only regain some health, and take a few turns (so that it's dangerous to do with enemies around)

(Also turn the corpse into un-eatable bones? At least, not eatable by flesh-eating monsters...)

Bonus: Add Rat AI to prefer eating nearby corpses over fighting?


[Feature] Auto insert tabs after a

Hi,
When you are writing nested lists like this :
* thing
    * thingy thing
    * other thing

It would be handy to automatically keep the correct number of tabs, imagine you have a long nested list and you have to rewrite 3 tabs every line.
My 2 cents, great tool otherwise.

I'm actually working on a hook that will make this possible. Maybe we can get @voldyman in on this conversation to hear his thoughts on the below implementation.
Currently inside the DocumentView, on every update/change it triggers a processing signal that allows fresh HTML code to be live previewed. However, I'm going to be implementing trigger functions for (names subject to change) insertNewline() and insertTab(). It's a similar approach to the one used by [apple on their NSScrollView](https://developer.apple.com/library/mac/documentation/TextFonts/Conceptual/CocoaTextArchitecture/TextEditing/TextEditing.html#Intercepting Key Events) (see: Intercepting Key Events)
I feel that this is an important implementation to the future of MarkMyWords, as it will allow for more advanced functionality to be added (like this feature for auto-indentation, automatic * or - inserting for list keeping, etc).

That sounds like a good idea, right now we rely heavily on GtkSourceView, maybe this would be useful for it.


Ludwig model with different csv

I want use this example:
Natural Language Understanding¶
utterance | intent | slots
I want a pizza | order_food | O O O   B-Food_type
Book a flight to Boston | book_flight | O O O O B-City
Book a flight at 7pm to London | book_flight | O O O O   B-Departure_time O B-City
I made about 5 experiments. The first experiment with csv N°1 and the other experiments with csv N°2:

csv: Example ........., order_food, O O O PType_1 PType_2 ......
csv:  Example ........., order_food, O O O P_TypePizza P_TypeMargerita ......
The file *.yaml is the same for 2 csv.
Both csv files have about 1.500 rows.
When I loaded the  models from the correct path for 2 different csv files and I made the predict, in slots I look always the PType_1 PType_2… (the variables present in the first csv), even if I uploaded the model generated with the second csv file. I expected to look in the slots the P_TypePizza instead of PType_1. I’m sure that I load the model from correct path.
So I gave another name (--experiment_name) for the second csv and I do a new experiment and I load the model from the path with the correct name experiment  but don't work.
I expected to look in the slots the P_TypePizza (second csv) instead of PType_1 (first csv).
The data seem to me mixed (data from the first csv with data from the second csv)

Where am I doing wrong?
*.yaml:
input_features:
-
name: utterance
type: text
level: word
encoder: rnn
cell_type: lstm
bidirectional: true
num_layers: 2
reduce_output: null
preprocessing:
word_format: space
output_features:
-
name: intent
type: category
reduce_input: sum
num_fc_layers: 1
fc_size: 64
-
name: slots
type: sequence
decoder: tagger
training:
batch_size: 8
epochs: 400
early_stop: 40
dropout_rate: 0.6
learning_rate: 0.0001
Environment (please complete the following information):

OS: Win 10
Python version 3.6.6
Ludwig version 0.2.1

Additional context
Add any other context about the problem here.

Please share the commands you used for training and prediction.

For model I use:
ludwig experiment --experiment_name Dino --data_csv C:\Users\dino\AppData\Local\Programs\Python\Python36\Scripts\Bot\Pizza.csv --model_definition_file C:\Users\dino\AppData\Local\Programs\Python\Python36\Scripts\Bot\model_define.yaml
For predict I use the API:
model_dir ="C:/Users/dino/AppData/Local/Programs/Python/Python36/Scripts/results/Dino_run/model"
ludwig_model = LudwigModel.load(model_dir)
client_w=input("Tu: ")
test_df=ludwig_model.predict(data_df=pd.DataFrame({'utterance': [client_w]}))

Where client_w is the txt to predict.
Now I have repeated the experiment and now it works correctly.

But I didn't understand why it didn't work properly before.

@z-dfalc The issue is not clear to me at all. You need to explain a little better.
What I understand is you're training the model on the first csv and trying to predict on the second one. If that's the case, the model will predict the labels that are from the first csv.
How would the model know "P_TypePizza" when you haven't used this data for training the model?

Can you please show us the first few lines of the data you used for training and test?

Sorry for my unclear explanation.
I created various models with two different csv files.
The “utterance” was written in Italian language and is the same in the two csv files, only the value of the slots changes in the two files.
When I do the predict I found mixed values of the slots (see the first
Pizza_1.zip
figure above) and I can't understand where I went wrong.
I also ask myself the same question.
In atthaced you can find the 2 csv files, they are simple files that I used to try and learn Ludwig.
The phrases in csv files are repeated in blocks.
Thanks
Pizza_2.zip


Clarified use of internal field names

Category

[x] Content fix
[ ] New article
Related issues: mentioned in #1250

What's in this Pull Request?
Added clarification for referencing other fields to call out need to use internal field names. This was mentioned previously within an example in the article, but needed to be more explicit in the relevant detailed syntax section.

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/declarative-customization/column-formatting.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

thx Chris, appreciated.


New feature: Paste as Keystrokes

Description of the new feature / enhancement
Paste whatever is in the clipboard by emulating the keystrokes.
Scenario when this would be used?
Sometimes I need to paste something, but the application does not allow paste.
Example: I used a remote Terminal in the browser the other day and had to paste an ssh key. Because the terminal grabbed all keystrokes, including crtl paste did not work. I ended up using https://github.com/Collective-Software/ClickPaste, but I thought, this would be a great addition to PowerToys.
Supporting information
No response

AutoHotkey could do this without breaking a sweat! MS Keyboard Center also has the ability to send macros.

/dup #5668
typically a right click in a terminal will simulate a paste, fyi


Unity Android: not receiving Async callbacks, when app in background.

I am developing a Unity application that performs some tasks in the background (i.e. when the user has navigated away from the app for whatever reason). When the app is in the background, an Android foreground service makes its way back into my Unity C# code, which periodically calls into the AWS Mobile SDK for Unity, specifically DynamoDB interactions.
While the Android app is in the background, these DynamoDB calls (e.g. QueryAsync) never seem to complete (i.e. no async callbacks are executed). To be clear, my Android service runs just fine in the background otherwise, performing additional desired activities in my Unity C# code, besides trying to interact with the database.
Is there a setting, of which I'm unaware, to allow background database activity, or is there some manual pumping call I can make periodically to 'drain' the callbacks, or . . .?
Expected Behavior

I categorize this somewhere between a bug and a change/improvement.  My expectations are that if I operate on the database, either in the foreground or background, the operations should occur.  I'm fine with a configuration setting or a manual pumping method.
Current Behavior

I think my initial description serves here.
Possible Solution

From my naive reading of the code, UnityMainThreadDispatcher's ProcessRequests method seems to be most of what I need to call to pump the async calls manually.  I see, however, that there are calls inside it to StartCoroutine, which also will not work, when Unity is otherwise dormant.
Steps to Reproduce (for bugs)

I don't have a concise snippet.  I've written an Android foreground service that periodically calls into my Unity C# code, when my app (and Unity) is in the background, and tries to exercise the database.
Context

Much like a mapping app (e.g. navigation instructions) that is active and exchanging data, when your phone is in your pocket, my app has similar requirements.
Your Environment

AWSSDK.Core version used:
Service assembly and version used:
Operating System and version:
Visual Studio version:
Targeted .NET platform:

.NET Core Info

.NET Core version used for development:
.NET Core version installed in the environment where application runs:
Output of dotnet --info:
Contents of project.json/project.csproj:

Same problem here. Any solution?

Unfortunately, no.  You are so far the first and only respondent.  At the
time I submitted this question, my quick inspection of the code base led me
to believe that this improvement would not be an extremely heavy lift, but
to this point no interest.
Good luck!
On Thu, Apr 18, 2019 at 5:26 AM Ícaro Dantas de Araújo Lima <
<EMAIL_ADDRESS>wrote:

Same problem here. Any solution?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/aws/aws-sdk-net/issues/1179#issuecomment-484483904,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ALE7Y4EUTOSPUKJPPZ7LKBTPRBSGZANCNFSM4GQZWP2A
.


Closes #581

Might add "install" to have the same function as "rebuild --db" as that would seem reasonable naming wise.

Also may want to update this: https://github.com/hydroshare/hydroshare/blob/581-rename-deploy/hsctl#L109
To account for this: https://github.com/hydroshare/hydroshare/pull/618/files#diff-1d9fbaa49f3ea3ec9956ffcd21ac7629L410
Based on your updated code that statement should no longer be necessary.

I have made @hyi's suggested update.
@mjstealey the update you suggest is actually part of #300 and I've fixed it in that PR which seems more appropriate.

:+1: - Looks fine to me, just need to inform the team once this is pulled in and update the Jenkins script to use rebuild --db instead of deploy. I also still like install as the same function as it makes sense when starting from thin air.


run formatters in sequence

With the current refactor branch the formatter run in parallel.
They will overwrite each other.
We will need to change them to run in sequence.
That should be pretty easy, but the config currently defines them as key value pairs. There is no guaranteed order in lua tables for key value pairs.
I think users will want to define the order formatters run in.
This would mean we need to change the structure of the config and break everyone that's currently using it :(

We should be able to control the flow in the loop. Going to research this a bit more to figure out what the best solution is

In my implementation I use callbacks.
I have a stack of formatter, take the first one and call format and pass a callback.
Then the callback gets called in on_exit and I take the next formatter from the stack until there are no formatters left.
Should work here too, the only problem is with the config. I used arrays for this, so users can configure the order. But here the formatter are key value pairs.

oh actually we could just support both :thinking:
tables are tables in lua, this is totally valid
local foo = {
    hello = "world",
    "foo",
    "bar"
}

for a, b in pairs(foo) do
    print(a, b)
end

Its ugly, but we could add ordering without breaking backwards compatibility

Went with key/value pairs here since the config needs to be built from a function for certain formatter. Like prettier needs to be passed a buffer name in the cmd args
  javascript = {
      prettier = function()
        return {
          exe = "prettier",
          args = {"--stdin-filepath", vim.api.nvim_buf_get_name(0), '--single-quote'},
          stdin = true
        }
      end
  },```

If it's a table or string, that can't be done, since the `nvim_buf_get_name` would just be the buffer on startup.

AH I see what you mean about the callback! I'll try that out, it looks like it has potential!

Ok, took some inspiration from what you had in your version, and applied it to the refactor branch. Formatters are now running sequentially!

hey guys, any chances that will be merged soon?
For javascript/typescript it could be useful to run prettier and then eslint

@alex-popov-tech this should already be in master

@mhartington cool! can you please update readme with an example then?

The readme and example where updated with #12

@mhartington thanks, get it.
But you did this example with multiple formatters in pr description, not in readme, so i was confused...i can  create pr and update readme from your pr description, if you want...but i think this feature should be mentioned in master readme anyways :)


Stop it

Pls guy.  Do you really want to be spammed with an ad for a shitty minecraft server ?

Pls guy.  Do you really want to be spammed with an ad for a shitty minecraft server ?

As I said: Only for educational purposes
I dont take any responsibility when some 12y/o kids use this script for mass dming other people
I made this script just for trolling that one discord staff who invented member intents


chore: fix README linting

@eaddingtonwhite - You also want to add Examples header between Requirements and Installation to fulfill the README rules.


haskellngPackages.lens-action: added missing Type module.

Would it be possible to download that file instead of checking it into the Nixpkgs repository?

The issue has been fixed in cc6f026909d59863809ed710cf6947ef590b6f94.