Mate in one : M4 ?

Until now i didn't manage to win a 5m+3s game against v1.2.1, but some engines around rating 1400 can .. at this moment it's not clear to me how strong your newest version is.
In one of the engine-vs-engine games this happened :
8/5kp1/p1N1p2p/8/3Pn1K1/6Pr/8/5q2 b - - 1 45

Woodpusher shows -M4 here but it's -M1 : Qf5#
What's wrong ?
Btw. the opponent engine, Minimardy v1.3 (CCRL blitz rating ~1342), uses the XBoard protocol so it can't display a mate like "M#" but .. it did NOT find the mate either !? Is this a confusing position for both engines ? It's weird ..
Another thing : this game also shows me that Minimardy should negate its eval value. For this, CuteChess (GUI) has the option "Scores from white's perspective", but i didn't set that checkbox yet.
[Event "engine-vs-engine"]
[Site "Holland"]
[Date "2024.11.28"]
[Round "?"]
[White "Woodpusher v1.2.1"]
[Black "Minimardi v1.3"]
[Result "0-1"]
[ECO "A04"]
[GameDuration "00:11:02"]
[Opening "Reti Opening"]
[PlyCount "94"]
[TimeControl "300+3"]

1. Nf3 {+0.28/7 4.6s} c5 2. e4 {+0.24/6 1.8s} Nc6 3. Nc3 {+0.34/6 2.6s} e6
4. Bd3 {+0.31/6 2.8s} Nf6 {+0.26/9 15s} 5. O-O {+0.21/7 8.6s} Bd6 {+0.33/8 15s}
6. Re1 {+0.34/6 3.4s} e5 {+0.23/9 13s} 7. Nd5 {+0.28/6 6.2s} O-O {+0.23/9 11s}
8. c3 {+0.22/6 3.4s} a6 {+0.22/9 9.8s} 9. a3 {+0.35/5 2.2s} b5 {+0.22/9 8.9s}
10. Bc2 {+0.17/6 5.6s} c4 {+0.30/8 8.2s} 11. d4 {+0.58/6 4.4s}
exd4 {+0.36/9 8.0s} 12. cxd4 {+0.65/6 2.7s} Nxd5 {+0.25/10 8.0s}
13. exd5 {+0.49/7 7.1s} Ne7 {+0.21/9 7.8s} 14. Ng5 {+0.22/6 3.6s}
f5 {+0.20/8 7.8s} 15. a4 {+0.35/6 4.4s} Qa5 {-0.28/7 7.7s}
16. Be3 {+0.09/6 6.5s} b4 {-0.45/8 7.6s} 17. Rc1 {-0.19/6 8.7s}
b3 {-0.59/7 7.5s} 18. Bb1 {-0.58/7 10s} Bb7 {-0.97/8 7.4s}
19. Qh5 {-0.62/6 4.5s} h6 {-1.04/8 7.3s} 20. Nf3 {-0.79/7 13s}
Bxd5 {-1.20/8 7.2s} 21. Rcd1 {-0.97/7 13s} Qxa4 {-1.48/8 7.1s}
22. Ne5 {-1.02/6 3.5s} Bb4 {-1.56/7 7.0s} 23. Bd2 {-1.10/7 14s}
Bxd2 {-1.46/8 7.0s} 24. Rxd2 {-1.23/7 10s} Be6 {-1.48/7 6.9s}
25. Rde2 {-0.99/6 4.6s} Nd5 {-1.34/8 6.8s} 26. Ng6 {-0.81/7 6.9s}
Rf6 {-1.60/8 6.7s} 27. Re5 {-0.94/7 6.8s} Qb4 {-1.56/8 6.6s}
28. Rf1 {-0.91/6 10s} c3 {-1.66/8 6.6s} 29. Bxf5 {-1.46/8 19s}
Rc8 {-1.27/8 6.5s} 30. Bxe6+ {-0.82/8 19s} dxe6 {-2.27/9 6.4s}
31. bxc3 {-1.49/8 20s} Rxc3 {-2.27/8 6.5s} 32. Qg4 {-1.83/7 14s}
b2 {-2.78/8 6.6s} 33. Ree1 {-2.48/7 7.5s} Rb3 {-3.70/8 6.7s}
34. Rb1 {-3.60/7 7.3s} Nc3 {-3.90/8 6.8s} 35. Rbe1 {-4.61/7 7.6s}
b1=Q {-10.30/9 6.8s} 36. Rxb1 {-7.39/8 8.6s} Rxb1 {-10.30/9 7.0s}
37. Ne7+ {-7.82/9 11s} Kf7 {-10.39/10 7.1s} 38. g3 {-7.84/9 15s}
Rxf1+ {-10.46/10 7.2s} 39. Kxf1 {-8.04/9 14s} Qb1+ {-11.37/10 7.3s}
40. Kg2 {-7.68/7 1.5s} Ne4 {-12.93/10 7.5s} 41. Nc6 {-7.18/7 2.5s}
Rxf2+ {-7.91/14 7.6s} 42. Kh3 {-M8/8 1.5s} Qf1+ {-7.91/12 7.8s}
43. Kh4 {-M6/9 2.7s} Rxh2+ {-7.91/13 8.0s} 44. Qh3 {-M4/8 0.89s}
Rxh3+ {-7.91/2 1.6s} 45. Kg4 {-M4/8 1.0s} Rxg3+ {-7.91/13 8.8s}
46. Kh5 {-M4/8 1.8s} Rh3+ {1.2s} 47. Kg4 {-M4/8 1.2s}
Qf5# {-7.91/8 0.022s, Black mates} 0-1

This has now been fixed (among other things) in my current branch. It'll go into main soon as v1.2.0.
position fen 8/5kp1/p1N1p2p/8/3Pn1K1/6Pr/8/5q2 b - - 1 45
go
info depth 1 seldepth 1 nodes 40 nps 2500 hashfull 0 score cp 1791 time 22 pv h3g3
info depth 2 seldepth 2 nodes 163 nps 5620 hashfull 0 score mate 1 time 32 pv h6h5
info string debug aborting search @ depth 2, mate in 1
bestmove h6h5

This has now been fixed (among other things) in my current branch. It'll go into main soon as v1.3.0

Nice ! I will try this version.
Regarding v1.2.1 : i let it play several 5m+3s games and now and then it made an illegal move, here are 5 examples. And here's the ZIPped log of the first one : woodpusher-illegal-move-log.zip

Maybe this illegal move issue is also solved with v1.3.0 ?


Vaults to spaces - move permissions to ACLs

Description

As we move from vaults to spaces, we want to leverage multiple groups associated with one vault. The current implementation applies permissions checks directly on the vault, ignoring group-specific nuances. This PR shifts the logic to ACLs, tailoring permissions to user roles as our primary source of truth for now (see more details here).
Main changes:

simplified canWrite and canRead methods, now consistently using auth.canRead and auth.canWrite
centralized vault read and write logic for each group kind in one place
improved flexibility for future granular permission adjustments.

The logic is implemented in VaultResource rather than GroupResource for two main reasons:

it keeps permission logic close to vault functionality
it allows for future granular permission (that customers already start asking around about) (e.g., non-admin/builder users that can add members to a vault, ...)

This approach sets the foundation for more sophisticated permission models, such as storing specific permissions in the group_vault join table, enabling fine-grained access control per group within each vault/space.
Risk

Pretty risky, as permissions are the gatekeeper to our data. I tested all three roles, run queries on private API using all three roles. Safe to rollback.
Deploy Plan

@flvndvd we could refine it further to have group "kind" permissions in the ACL.
group kind, group id, role

What's the status here? I thought this PR was blocking the one referred to in the PR description?

What's the status here? I thought this PR was blocking the one referred to in the PR description?

I figured this might bring some discussions, so I used a temporary workaround to keep the transition to Spaces on track. I'll get back to this tomorrow.

Superseeded by https://github.com/dust-tt/dust/pull/8209.


waitFor property change feature request

There are a number of scenarios where it is super useful to wait for a property on a element to change. I am looking at this mostly from a testing perspective and being able to do something like.
async propertyHandle.waitForChange();
You can then wait for the class to change to make sure that the desired ui effect is being added.
You can check attribute values to check aria attributes being applied properly.
You can wait for values to change to ensure that expected bindings worked as expected.
I am sure you can currently do it with custom events but the experience is horrid.
A nice clean shorthand would suuuuuper nice, simplifying the code and keeping easier to understand and maintain.

How about:
await page.waitFor(element => element.getAttribute('aria-label') === 'correct-value', {}, elementHandle);

Waiting for just any change seems a bit scary. What if your attribute changes twice?

That is certainly a nice example, as reference what I would love to avoid is something like this.
https://github.com/GoogleChrome/puppeteer/issues/1333
For what we do this is a common scenario and as can be seen in the above link can be simplified alot.

I am not sure I understand. Internally, we just use a MutationObserver to listen for all changes. You can combine that with page.exposeFunction to receive a callback every time something changes in the DOM. That's what page.waitFor does, and then it resolves when the callback function returns true.

If you are only concerned about attributes, then yes, mutation is fine.
Some binding engines do not work on the attributes though, but the properties directly. Aurelia being a example of that.
Having said that, I am not saying that you can't do these things using other mechanisms.
What I am asking for is a less verbose / simplified api as I have demonstrated on the initial post.
Request, simplified api

BTW, is it possible to add waitFor under ElementHandle?

@pragmaproducts if i understand correctly, you'd like to have a hook for the javascript property changes.
You can achieve this by using es6 proxies, something along the lines:
async page.exposeFunction('fooChanged', () => console.log('a.foo changed!'));
async page.evaluate(() => {
  // Assume there's "a" with a "foo" property we'd like to track
  const oldFoo = a.foo;
  a.foo = new Proxy(oldFoo, {
    set: function(target, property, value, receiver) {
      target[prop] = value;
      fooChanged();
    }
  });
});

I'm not convinced this should be a part of the puppeteer unless there's a bigger demand for the functionality.
Hope this helps!

You did not understand it correctly but that is ok, i will make my own shorthand for this

@pragmaproducts Did you find a good way to monitor the property changes?


Copy over jams annotations

A useful feature would be for Scaper to be able to trim and copy over other annotations from the source files on demand.

Scaper already has a trim() function, but it sounds like this isn't enough for your use case @beasteers ? What's the actual problem? What does source files refer to in this context?


Telegram code not arriving

Hello ,
I am unable to receive token from telegram, did anyone encounter similar issue ?
I tried two different api registrations + phone numbers , but token not arrived.
Is there any logs , where i could check what could be wrong , if telepathy is sending any request to telegram

same issues,
need help to login through telegram
please advice on how to login to telegram

my fault , you need to simply put phone number again ... , not sure why it was not working before though , because i try it


Not able to configure TiKV log level online

Bug Report
Not able to configure TiKV log level online
What version of TiKV are you using?
v5.4.0
What operating system and CPU are you using?
RHEL 7.9, X86-64
Steps to reproduce
Run sql "set config tikv log.level='debug';" then "show config where type='tikv' and name='log.level';"
Or run command "tiup ctl tikv --host <IP_ADDRESS>:20160 modify-tikv-config -n log.level -v debug --ignore-version"
What did you expect?
TiKV log level set to 'debug' successfully.
What actually happened?
Log level kept 'info' when queried back through sql or got below error with tiup ctl command:
DebugClient::modify_tikv_config: RpcFailure: 2-UNKNOWN "failed to update config, err: "config log can not be changed""
Error: exit status 255
Addition:
Can we also update underlying RocksDB log level with the fix?

@zhaopei05 Thanks for the reporting. This is not a bug as we do not support dynamically change config log.* currently. You can submit a Feature Request and we may support it later. You can refer to Modify TiKV configuration online to see all the configs that are supported to change via sql currently.

Thanks @glorv for the comments.

@glorv BTW, is there particular reason why TiKV doesn't support dynamic log level change? This is supposed to be a very helpful function when we want to grab more debug info w/o interrupting what's already happening by restarting the process.

I briefly looked into the code yesterday. Currently, log.level controls the log level both for tikv log and rocksdb log. It's not hard to let tikv log support dynamic change. But the log level in rocksdb can't be changed after initialized currently.   @tabokie Do you know if it is possible to let rocksdb also support change log level dynamically?

@glorv RocksDB log level is always set to info even if TiKV is not. No need to consider it here.

@zhaopei05  Though we do not change tikv's log trough sql, you can set it through http. e.g.:
curl -X PUT -H "Content-Type: application/json" -d '{"log-level":"debug"}' <IP_ADDRESS>:20180/log-level

This can change the log level of a single tikv-server. Hope this can make your debug easier.
BTW, I think it will still be convenient to support change the log level via SQL, maybe we can support it in the next version.

@glorv appreciate your patience. The curl command is help indeed.


feat: Normal user list

Description
Allow regular users to list other users.
People with account management permissions (such as admins) can list users as they have been until now. This PR won't affect them in any way.
Regular users (without account management permission) can list users with the following restrictions:

Only "id", "displayName" and "mail" attributes will be shown per user.
"$search" option MUST be present in the query, with at least 3 characters
"$filter", "$apply", "$expand" and "$compute" options aren't allowed

Related Issue
https://github.com/owncloud/ocis/issues/7782
Motivation and Context

How Has This Been Tested?
Manually tested.
Unit tests have been adjusted because some of them where failing due to the user not having enough permissions
Screenshots (if appropriate):
Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Technical debt
[ ] Tests only (no source changes)

Checklist:

[x] Code changes
[ ] Unit tests added
[ ] Acceptance tests added
[ ] Documentation ticket raised:

Could you please add a test to validate that only the minimal set of id,displayName and mail is present if the regular user is requesting the users endpoint ?

@JanAckermann done. Please re-review

Some getUser tests are failing.

Only "id", "displayName" and "mail" attributes will be shown per user.

we can bug where we can get full info about user https://github.com/owncloud/ocis/issues/5125


Add tests for netlify build

We should have some tests for the netlify build command.

Done in #837.


bug(dashboards): Selected tab is reverted after transitioning to Edit mode.

[Note this was filed as a SIP, but should be treated as either a bug, or a feature request (and migrated to Github Discussions)
Proposal for an <Editing function of a typical research>
Motivation
This improvement will reduce the cognitive load on the user and increase the speed of his work with the interface.
Description of the problem to be solved
When we work in any of the tabs of the current research except the first one and click on the "Edit dashboard" button, the editing mode screen opens. Then, even if we have not made any changes, when you click on the "Undo changes" button, the page is reloaded and the current state of the page is reset, namely, the focus shifts to the first tab. The user has to remember which tab he was on before, which increases the cognitive load.
Link to screenshots
https://drive.google.com/drive/folders/1gP1U97Fd18K_8AH1rS2IKqSQcVx2o9Z4?usp=share_link
Proposed Change
Make it so that when canceling changes, in the case when the user did not make any adjustments, the page does not reload and the cursor remains on the same tab where the user was before clicking the "Edit dashboard" button.

Seems like a reasonable concern that can be addressed. I'm a bit torn as to whether this should be considered a feature request, or filed as a bug. It does seem like the dashboard could/should remember the context of which tab was active when going into Edit mode, so that may be recalled upon cancellation (or saving) of those changes.
I suppose if you change tabs while in edit mode, we would want to persist that state change on Save. Would we also want to persist it on Discard?
In either case, I don't think this requires a SIP to agree on this change - I'll update this accordingly.
Pinging @lauderbaugh and @kasiazjc for further comments/redirection/ticketing.

I think it is not correct to save any state changes on Discard. Because the user will expect that when clicking the ‘’Discard changes’’ button, all changes will not be saved.

Hello @romagrog there have been significant changes to the Dashboard and in general toward SAP since this issue was opened. I am closing it for now but feel free to reopen it if you think this is still a problem. Thank you!


Deploy Checklist: New Expensify 2022-05-24

Release Version: 1.1.66-1
Compare Changes: https://github.com/Expensify/App/compare/production...staging
This release contains changes from the following pull requests:

https://github.com/Expensify/App/pull/8831

[x] QA
[ ] Accessibility

https://github.com/Expensify/App/pull/8980

[ ] QA
[ ] Accessibility

https://github.com/Expensify/App/pull/9046

[x] QA
[ ] Accessibility

https://github.com/Expensify/App/pull/9127

[x] QA
[ ] Accessibility

https://github.com/Expensify/App/pull/9129

[x] QA
[ ] Accessibility

https://github.com/Expensify/App/pull/9133

[x] QA
[ ] Accessibility

https://github.com/Expensify/App/pull/9134

[x] QA
[ ] Accessibility

https://github.com/Expensify/App/pull/9136

[x] QA
[ ] Accessibility

https://github.com/Expensify/App/pull/9138

[ ] QA
[ ] Accessibility

https://github.com/Expensify/App/pull/9146

[x] QA
[ ] Accessibility

Deploy Blockers:

[x] https://github.com/Expensify/App/issues/9159
[ ] https://github.com/Expensify/App/issues/9161
[ ] https://github.com/Expensify/App/issues/9166

Deployer verifications:

[ ] I checked the App Timing Dashboard and verified this release does not cause a noticeable performance regression.
[ ] I checked Firebase Crashlytics and verified that this release does not introduce any new crashes.

cc @Expensify/applauseleads

@Julesssss , its been a while and IOS build still not available. Can you check if it is looking ok?

@Julesssss Regression is completed
Deploy blockers logged
https://github.com/Expensify/App/issues/9159
https://github.com/Expensify/App/issues/9161
https://github.com/Expensify/App/issues/9166
PR #8980 is failing due to https://github.com/Expensify/App/issues/9158. Pls double check if it needs to be a blocker as experiences between PROD and Staging differs.
PR https://github.com/Expensify/App/pull/9138 is failing due to #9159
Issues logged
https://github.com/Expensify/App/issues/9157
https://github.com/Expensify/App/issues/9158
https://github.com/Expensify/App/issues/9162
https://github.com/Expensify/App/issues/9164

Checked off 9159 which we believe should be expected after changes in other PRs.

Commented on 9161 as I have a feeling this is expected.

Additionally, I think 9166 has the same explanation as 9159 and is expected. But I'll await a second opinion before removing the label.

@Julesssss, thanks for update. Hopefully we can have a new deploy today. Let us know if anything needs to be re-tested

After looking into 9158 it seems to be a regression, but this has been on prod for a few weeks now -- so is unrelated to this checklist. I've posted here to ensure we figure out a fix.

Also checked off 9146 as there is no QA to be performed.

Checking off 9138 as the tests pass and we deemed the linked issue to not be a deployBlocker.

After looking into 9158 it seems to be a regression, but this has been on prod for a few weeks now -- so is unrelated to this checklist. I've posted here and here to ensure we figure out a fix.

Just to clarify. I was mistaken here. THIS is the PR which I believe introduced the issue so I've made it a deployBlocker.

I'm checking off

https://github.com/Expensify/App/issues/9158 since it looks like its resolved.
https://github.com/Expensify/App/pull/8980 since it was only pending on comment from above.

:shipit:

Checked all PRs on Production / Staging and created accessibility issues for all PRs where accessibility issues were found.
The non-applicable PRs are - #9136, #9146
Logged Issues - #8831, #8980, #9046, #9127, #9129, #9133, #9134, #9138


Problem with stronghold results while trying to use the payout option

WARNING:tornado.access:404 GET /favicon.ico (<IP_ADDRESS>) 5.09ms
ERROR:whyattend.webapp:Exception on /payout/PSQD/battles [GET]
Traceback (most recent call last):
  File "/home/cwtracker/cw.psqd.co/cw.psycho/local/lib/python2.7/site-packages/flask/app.py", line 1817, in wsgi_app
    response = self.full_dispatch_request()
  File "/home/cwtracker/cw.psqd.co/cw.psycho/local/lib/python2.7/site-packages/flask/app.py", line 1477, in full_dispatch_request
    rv = self.handle_user_exception(e)
  File "/home/cwtracker/cw.psqd.co/cw.psycho/local/lib/python2.7/site-packages/flask/app.py", line 1381, in handle_user_exception
    reraise(exc_type, exc_value, tb)
  File "/home/cwtracker/cw.psqd.co/cw.psycho/local/lib/python2.7/site-packages/flask/app.py", line 1475, in full_dispatch_request
    rv = self.dispatch_request()
  File "/home/cwtracker/cw.psqd.co/cw.psycho/local/lib/python2.7/site-packages/flask/app.py", line 1461, in dispatch_request
    return self.view_functions[rule.endpoint](**req.view_args)
  File "/home/cwtracker/cw.psqd.co/whyattend/webapp.py", line 152, in decorated_function
    return f(*args, **kwargs)
  File "/home/cwtracker/cw.psqd.co/whyattend/webapp.py", line 198, in decorated_f
    return f(*args, **kwargs)
  File "/home/cwtracker/cw.psqd.co/whyattend/webapp.py", line 176, in decorated_f
    return f(*args, **kwargs)
  File "/home/cwtracker/cw.psqd.co/whyattend/webapp.py", line 1493, in payout_battles
    player_resources[ba.player] += ba.resources_earned
TypeError: unsupported operand type(s) for +=: 'int' and 'NoneType'
ERROR:tornado.access:500 GET /payout/PSQD/battles?fromDate=01.04.2015&toDate=30.04.2015&victories_only=on&gold=16000&recruit_factor=0.6&points_per_resource=1 (<IP_ADDRESS>) 50.82ms

I've added a quick fix for the problem but I suspect the stronghold resources earned couldn't be determined from a replay file. Maybe the replay format changed again with a recent patch. I'll have to look into that.

It worked for now


Cannot sign out and session switch

I have a really disturbing and dangerous behavior for my app right now.
The problem is:

I log as User 1
I log out
I log as User 2
I change the page (or the locale) : I'm on the application but logged as USER 1 !!!!
I cannot log out, I have a Can't verify CSRF token authenticity in the logs

It's only happening in staging, cannot reproduce in development. My project is in Rails 5 and Devise 4.2.0
We did not see it happen before adding locale management, but maybe it has no link with it.
It really look like logout does not totally erase the session of User 1, and causes both sessions to be mixed
I think it's a problem with cookies and/or cache because everything is fine once I disable cache but I really don't know how to handle this in my application.

I have a similar issue but in my case I get Password reset token expires when i try to reset my password. I have two locale en and pt and my default locale is pt but if I updated my default locale to en then the issue persist

Facing a similar issue where Devise isn't actually deleting cookies (Rails 5). Did you manage to find a solution?

Hi @Kounts, thanks for your report.
Can you provide us a sample application that reproduces the issue in isolation?
That would help us find the issue.
Thank you!

Sorry, I clicked the wrong button 😞


Build a Single Page Application

Description:
Create a SPA that fetches and displays data dynamically without page reloads.
Technologies: HTML, CSS, JavaScript, (Optional: React, Vue, or Angular)
Expected Output:
A single-page application that provides a smooth user experience and utilizes client-side routing.

Please Assign This Issue

@strivedi4u  May I contribute to this issue as well?

⭐ If you find this repository helpful, please give it a star! ⭐

Hi @strivedi4u, thanks for merging my PR! However, when I check the Hacktoberfest site, it shows:-


No default exports

So that all classes can be imported in other projects, espeically useful
for TypeScript projects which want's to declare return classes from
methods.
Will require a major version bump as it's a very breaking change.
Addressing part of #21

Thanks for looking into this issue!
I published this PR as a package at @jonaskello-forks/amqp-client, v2.0.0. I then tried it out in a regular nodejs project. With the current changes in this PR it is possible to do:
import { AMQPClient } from "@jonaskello-forks/amqp-client";
import { AMQPWebSocketClient } from "@jonaskello-forks/amqp-client";

However, none of the other classes works to import, eg. this is still not possible:
import { AMQPChannel } from "@jonaskello-forks/amqp-client";

I do agree that default exports are not worth the trouble so it is probably better to just get rid of them altogheter like is done in this PR. However, since all default exports are already re-exported as named exports in the index.ts file here I don't think the changes are necessary to support named imports.
There are many ways to publish packages, and a myriad of tools to help you do it. So I can of course not make any suggestions without being opinionated :-). My oppionon is to make it as simple as possible. So I would suggest just using the the typescript compiler tsc.
Publish the full output from tsc in the ./lib folder as commonjs modules (*.js, *.js.map, *.d.ts, and *.d.ts.map files). In package.json, set the main field to ./lib/index.js and the types field to ./lib/index.d.ts.
With this done, all javascript/typescript nodejs projects should be able to consume this package without any problems. Any javascript/typescript web projects that run their own bundler like webpack/rollup/parcel/snowpack/vitejs etc. should also be able to consume it without any problems.
In addition the package could also continue to provide pre-bundled files in ./dist for projects that wants to copy the file to a CDN or something like that. This could be done using rollup like today, but without any extra plugins for typescript. Instead just have rollup bundle the javascript files that tsc built from ./lib to ./dist. No type files are needed in ./dist as typescript projects will work directly from ./lib.
The browser field in package.json IMO can be removed if a full ./lib folder is provided.
I see in package.json that this package support the new exports field. This is of course nice but IMO not really necessary. I think at this point, getting the package to work proper in a traditional way would be more interesting than supporting this new field. Typescript has still not added support for this field (well they added it and then removed it because it is very complex to get right). For nodejs I think you still need to enable experimental features for this field to be recognized. Once it is possible to consume this package in a traditional way, it would be of course be interesting to explore adding support for this too.
As I said this is just highly oppninated suggestions based on my experience publishing npm packages. My main concern is just being able to consume the package in an idomatic way from typescript/javascript projects for both nodejs and web. Any tooling/solution that achieves that works for me :-).

thank you for your feedback, i've made a number of changes if you would like to try it out.

rollupjs can only roll up mjs/esm modules, not cjs (only with plugins, and even then it gets ugly i think), thus mjs files have to be included in the package. mjs is also required for tree-shaking, in rollup, webpack etc.
lib/types etc are only names, might be a convention but not a rule, but i now put the tsc output in lib/mjs and lib/cjs respectively, and types in ./types.
exports.import and exports.require are fully supported since couple of nodejs version back, 12 or 14 i think, and not anything new. many benefits of using it. but cjs is still required for legacy apps that does require and not import.
removed typescript in rollup config, but then needed to add another plugin for sourcemap to point to the .ts files and not the tsc output files which would be meaningless.

Thanks for taking the time to make all the the changes :-)
I published the current state of this PR to a package and imported it into my exmple project that uses webpack, typescript, and react.
It works a lot better and the code below builds without problem with tsc. So it is now possible to import classes and types in an idomatic way like this:
import { AMQPWebSocketClient, AMQPChannel } from "@jonaskello-forks/amqp-client";
//
const amqp = new AMQPWebSocketClient(url, "/", "guest", "guest");
//
function View(): JSX.Element {
  const [channel, setChannel] = React.useState<AMQPChannel>();
//

However there is one last hurdle. When I run it with webpack-dev-server I get this error in run-time:
bundle.js:397 Uncaught ReferenceError: exports is not defined
    at eval (index.js:3:23)
    at<EMAIL_ADDRESS>(bundle.js:365:1)
    at __webpack_require__ (bundle.js:394:33)

I tracked this down to the "type": "module" field in package.json. If I remove that field everything works.
I think is what is happening is that "type": "module" tells webpack to expect ESM modules. However the main field is set to lib/cjs/index.js which is a CJS module. So when webpack tries to load the main field as an ESM module it encounters exports which is not present as a global for ESM modules. Thus webpack says exports is undefined.

exports.import and exports.require are fully supported since couple of nodejs version back

Yes, you're right, I was confusing it with loaders which is still experimental. Also tsc does not yet suport this. Anyway, these fields is definitely the future way of doing things.
Regarding the remaining issue mentioned above I see two ways to solve it:
First solution:
Remove "type": "module" from package.json to signal that .js files should be treated as CJS.
Second solution:
Remove support for CJS modules altogether. Keep "type": "module", only publish one set of ESM module files to lib and set main to lib/index.js. I I think this would be possible if only nodejs>12 support is needed. Nodejs>12 should respect "type": "module" and treat all .js files as ESM modules. Bundlers like webpack etc. also supports "type": "module" so that should also work. And tsc will only look at the types so it also works. I did a quick test with this approach. In package.json I changed main to lib/mjs/index.js and removed exports. This still works with my webpack example (altough it complained about sourcemaps: DevTools failed to load source map: Could not load content for<EMAIL_ADDRESS>HTTP error: status code 404, net::ERR_UNKNOWN_URL_SCHEME).

went with solution 3 :bulb: : adding a package.json file with {"type": "commonjs"} to lib/cjs/. that should tell node to treat the files in that dir as commonjs files. does that work for webpack too? but ideally i would like webpack to use the esm module.. this docs says it should pick up the exports property: https://webpack.js.org/guides/package-exports/
solution 2 isn't very good because users who still uses commonjs won't then be able to use (require) the library then, and i think that's still a fairly large population unfortunately. could be overcome by forcing them to use the dynamic import, but that's a hassle and learning curve.
More reference: https://nodejs.org/docs/latest-v16.x/api/packages.html#dual-commonjses-module-packages

Tried your example app and my fix solved it, it understands that the files in lib/cjs are commonjs files then.
And to make your app use the esm version of libs you have to change your tsconfig.json with the following:
    "module": "es2015",
    "moduleResolution": "node",

then it logs:
modules by path<EMAIL_ADDRESS>83.9 KiB 10 modules

btw, you can also install package from a git repo without having to publish your own npm package:
  "dependencies": {
    "cloudamqp/amqp-client": "git://github.com/cloudamqp/amqp-client.js.git#no-default-export",
   }

Yes now it works, thanks :-)
In a perfect world we would only have to worry about ESM modules, but yes, there are a lot of projects still running older stuff. IIRC turning on "module": "es2015" in a larger typescript codebase that uses __dirname and other CJS specific stuff all over the place is a bit of pain too.
I'll investigate a little bit more why webpack is not picking up the exports field in the example. I guess having it read the ESM modules instead would result in better tree-shaking so that is definitely preferable.
Neat trick to install the package directly from the branch 👍

Another thing that is not really needed but would be nice if it could be solved is that webpack will now complain like this:
ERROR in<EMAIL_ADDRESS>27:25-39
Module not found: Error: Can't resolve 'net' in '/home/jonkel/code/github/jonaskello/amqp-websockets-example/node_modules/@jonaskello-forks/amqp-client/lib/cjs'
<EMAIL_ADDRESS>4:30-64
 @ ./src/index.tsx 17:22-62

ERROR in<EMAIL_ADDRESS>28:25-39
Module not found: Error: Can't resolve 'tls' in '/home/jonkel/code/github/jonaskello/amqp-websockets-example/node_modules/@jonaskello-forks/amqp-client/lib/cjs'
<EMAIL_ADDRESS>4:30-64
 @ ./src/index.tsx 17:22-62

This can be fixed by adding the line below to the webpack config. You can remove that line in the example to see the error.
module.exports = {
  resolve: {
    fallback: { buffer: false, tls: false, net: false },
  },

I'm not sure what is the best way to deal with this. I guess it happens because when you import one thing from the index file, you import all files implicitly, including files that have nodejs specific stuff. Perhaps a second index file like web.js could be published but it would not import any nodejs stuff. It could then be imported like @cloudamqp/amqp-client/web.
For me this is not really important as it can be worked around by the above webpack config. Perhaps it could be dealt with in a separate PR as it would be great to have this PR published as soon as possible.

tried with a subexport (@cloudamqp/amqp-client/web, but typescript doesn't support it (as we touched earlier), so resorted to ignoring those via the browser property: https://github.com/cloudamqp/amqp-client.js/pull/22/commits/ba520c8edd745e35abbb07d3bf44fe5aa1032035
that seems to fix it, but only if the esm module is used (and thus "module": "es2015" in your tsconfig.json is required for it to work).

v2.0.0 is now released with this PR included, thank you for the collaboration!


Import cargo fix directly in to Cargo

This commit imports the cargo fix subcommand in rust-lang-nursery/rustfix
directly into Cargo as a subcommand. This should allow us to ease our
distribution story of cargo fix as we prepare for the upcoming 2018 edition
release.
It's been attempted here to make the code as idiomatic as possible for Cargo's
own codebase. Additionally all tests from cargo-fix were imported into Cargo's
test suite as well. After this lands and is published in nightly the cargo-fix
command in rust-lang-nursery/rustfix will likely be removed.
cc rust-lang/rust#52272

r? @matklad
(rust_highfive has picked a reviewer for you, use r? to override)

cc @killercup

Cool! Thanks for doing this, @alexcrichton!
 Not sure how idiomatic this is in cargo, but maybe you can also split up the tests further? 1k lines is quite a lot to scroll through without grouping :)
(Also: Remind me to add support for message-format=json to cargo-fix.)

r? @ehuss
@bors: delegate=ehuss

:v: @ehuss can now approve this pull request

cargo fix does not play well with running cargo check.  For example, if your editor automatically runs cargo check, then cargo fix will do nothing because it thinks everything is "fresh".  I'm inclined to just file an issue for this and see if it can be fixed after this merges?

I'm inclined to just file an issue for this and see if it can be fixed after this merges?

Ah yeah there's a few issues on rust-lang-nursery/rustfix like this one which we should transfer over once merged

:sunny: Test successful - status-appveyor, status-travis
Approved by: ehuss
Pushing 506eea76edbf7198258265ddabcf320365bc4c5c to master...

:tada:

Ah we've got pretty long tests in Cargo unfortunately, most of it's due to unnecessarily verbose test cases. We should definitely fix that at some point!

That sounds like a nice E-easy piece of grunt work. If you were to flesh out your thoughts on how to do that I might be able to help. 😄

@dwijnand an excellent point! I've filled out the A-testing-cargo-itself tag on our issue tracker a bit, and anything tagged with E-help-wanted would be most appreciated to have some help to tackle!

I was wondering why a rustfix component wasn't added to rustup with clippy before finding this PR.
I think an announcement about this change should be made when the next nightly becomes available.


Form Wizards Progress bar

From the start, step 1 is blue, step 2 and so on are gray => Normal.
When clicking on "next" button the step 1 become green, step 2 become blue, step 3 and so on are still gray => Normal.
When clicking on "previous" button, step 1 become blue, but step 2 become green (instead of gray I guess) => Not normal.

I think the functionality is assuming that you already did the step you were previously on even if you go "Next" to complete next step or "Previous" to redo something in the previous step, thus the green part. At least that is my point of view.

You can change it by handling the wizard events, have a look at the wizard initialization:
$('#wizard').smartWizard({   // Properties     selected: 0,  // Selected Step, 0 = first step        keyNavigation: true, // Enable/Disable key navigation(left and right keys are used if enabled)     enableAllSteps: false,  // Enable/Disable all steps on first load     transitionEffect: 'fade', // Effect on navigation, none/fade/slide/slideleft     contentURL:null, // specifying content url enables ajax content loading     contentURLData:null, // override ajax query parameters     contentCache:true, // cache step contents, if false content is fetched always from ajax url     cycleSteps: false, // cycle step navigation     enableFinishButton: false, // makes finish button enabled always 	hideButtonsOnDisabled: false, // when the previous/next/finish buttons are disabled, hide them instead     errorSteps:[],    // array of step numbers to highlighting as error steps     labelNext:'Next', // label for Next button     labelPrevious:'Previous', // label for Previous button     labelFinish:'Finish',  // label for Finish button             noForwardJumping:false,   // Events     onLeaveStep: null, // triggers when leaving a step     onShowStep: null,  // triggers when showing a step     onFinish: null  // triggers when Finish button is clicked });

This is not an issue, its correct functionality, as @razvanaldea89 mentioned that once the user already did any step it means that the user finished that step and after that if the user clicks on "Previous" than also it will stay Green as that step is completed.
You can customize the same as per your requirement inside this below function:
$('#wizard').smartWizard({
});
Following property you can use :
selected, keyNavigation, enableAllSteps, transitionEffect, contentURL, contentURLData, contentCache, cycleSteps, enableFinishButton, hideButtonsOnDisabled, errorSteps, labelNext, labelPrevious, labelFinish, noForwardJumping

Feel free to comment on this issue if you're still facing problems and we'll reopen.


Improve responsiveness

This plugin is really awesome! I'll definitely be using it when I want to put something together quickly, but don't want my forms to look horrible. Thanks, Adam!
This PR just makes the two columns full width on smaller screens. Screenshots below:
Before

After

Thanks Jason!


Doesn't add @types/ws if webSocket shim is enabled but the test option is set to false

Can you post reproduction code?

I think a simple fix would be to just include @types packages from transformOutput.test.dependencies when type checking: https://github.com/denoland/dnt/blob/07ccc725bab65b21f187c08dfce0abd9d6c743e0/lib/package_json.ts#L66

Yes, it is while building.


Database renames are not transactional

Fixes #4393.
Summary of changes:

Update ALTER TABLE .. RENAME DATABASE to say that db renames are not
transactional, explain why, and offer a workaround.

Update 'Known limitations' page to note that db renames are not
transactional, with a link to the above page for more information.

This change is

http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/0e840c793828c0e96d976a6176766eaf4d9ccffa/

Direct links:

ALTER TABLE .. RENAME DATABASE
Known limitations

Hey @knz I can ping someone else for review if you are too busy right now.  If so, who do you recommend?

@vivekmenezes could be a good match

http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/d0d6c5a003e0bd1382576207cb8a89d601a8ab4e/

LGTM
On Thu, Mar 7, 2019 at 11:33 AM Rich Loveland<EMAIL_ADDRESS>wrote:

@rmloveland commented on this pull request.
Thanks again Vivek, made the latest changes.
Does the information in this PR also apply to 2.1? If so I'll add it there
as well once we're happy with it.
Reviewable
https://reviewable.io/reviews/cockroachdb/docs/4442#-:-L_Nzh5ABSRsC7gUuf40:b-swr2xr
status: [image: :shipit:] complete! 0 of 0 LGTMs obtained (waiting on @knz
https://github.com/knz and @vivekmenezes
https://github.com/vivekmenezes)

v19.1/rename-database.md, line 37 at r2
https://reviewable.io/reviews/cockroachdb/docs/4442#-L_Nj8Gt-Qkv-GqupvNJ:-L_NyiZZ8xaeJaUZ11up:bvyofgo
(raw file
https://github.com/cockroachdb/docs/blob/d0d6c5a003e0bd1382576207cb8a89d601a8ab4e/v19.1/rename-database.md#L37):
Previously, vivekmenezes wrote…

Once the new name has propagated to every node in the cluster,
another internal transaction is run that declares the old name ready for
reuse in another context.

Added this - thanks!
v19.1/rename-table.md, line 39 at r2
https://reviewable.io/reviews/cockroachdb/docs/4442#-L_NjQES1zJkk569PMuh:-L_Nym413WQipqr0-zuN:baul1ml
(raw file
https://github.com/cockroachdb/docs/blob/d0d6c5a003e0bd1382576207cb8a89d601a8ab4e/v19.1/rename-table.md#L39):
Previously, vivekmenezes wrote…
see 3. above
Added here as well.
v19.1/rename-table.md, line 42 at r2
https://reviewable.io/reviews/cockroachdb/docs/4442#-L_NjTqXC2za_zSKLbs4:-L_NytEjCeSdv0NC2a-j:byds9bo
(raw file
https://github.com/cockroachdb/docs/blob/d0d6c5a003e0bd1382576207cb8a89d601a8ab4e/v19.1/rename-table.md#L42):
Previously, vivekmenezes wrote…
I'd completely remove this workaround. It's not really something workable.
Please do the same above in the database section.
Removed from both places.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/cockroachdb/docs/pull/4442#pullrequestreview-211887620,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ALOpBCsysNhHqibZnr0Ymv6R7KNh1jSfks5vUT9SgaJpZM4bVjdl
.

--
"I've never found understanding CockroachDB to be a problem. Understanding
the architecture is easy, the difficulty comes when I immerse myself in it.
It's not the understanding that's hard, getting inside it and finding
myself rocking in the deep is when I find myself circling around something
that I want to wrestle with. It is often swimming back from such a
challenge when I feel fulfilled--the pleasure in reacquainting myself with
bors r+"

http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/9bae9de4140a906c3fed7ae9b0afb6761ff86791/

http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/3e259f060a080ffcb5c113ef8a9f53095d2e4198/

http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/dbb1da210bba21c2ad40b845d64c59496019f6ef/

http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/83b91d4d4457a5d76deb7ab9d8f9b578102a85d8/

http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/a5b90aa5a127c817473769580f47366d2e81d02c/


HIVE-26789: Add UserName in CallerContext for queries.

What changes were proposed in this pull request?
Add UserName in CallerContext for HDFS Audit logs to pick.
Why are the changes needed?
With Impersonation turned off, every call shows from Hive User, So, to allow tracking the actual user.
Does this PR introduce any user-facing change?
Nopes,
How was this patch tested?
Tried a Query in Actual Cluster.

Thanx @cnauroth for the review, Have addressed the review comments, my initial use case was around the queries only so ignored setting user in the other places, I have now added everywhere


Create an API to expose platform configuration

Hi @ramsai1729 @jd0-sag : is this API will be available for M&M, as a voltron service or else ?
Because it might be in our interest to view the platform config from the management apps.
Thanks!
@anthonydahanne : FYI.

This is just a way to pass the server name into ServerProvider instances, when they are initialized, to solve problems such as how to namespace storage, etc, in case multiple servers from the same stripe are configured on the same machine with the same paths.
In fact, I will update the name and description.


The client doesn't obey set-cookie with empty value.

I am trying to follow this tutorial. I decided to go one tiny inch beyond what is done in the video and implemented a logout route that is supposed to delete the auth cookie. It seems to work OK on the server side, i.e. the server sends a correct empty-valued, expired-last-year set-cookie directive in order to delete the cookie:
->> HANDLER      - api_logout
->> RES_MAPPER   - main_response_mapper

=== Response for POST http://localhost:8080/api/logout
=> Status         : 200 OK
=> Headers        :
   content-type: "application/json"
   content-length: "4"
   set-cookie: "auth-token=; Max-Age=0; Expires=Tue, 24 May 2022 23:05:08 GMT"
   date: "Wed, 24 May 2023 23:05:08 GMT"
=> Response Cookies:
   auth-token:
=> Client Cookies :
   auth-token: user-1.exp.sign
=> Response Body  :
"Ok"
===

However subsequent requests made with the same client keep sending the old cookie, as if the client didn't apply the directive:
->> HANDLER      - handler_hello2 - "Rulatir"
->> RES_MAPPER   - main_response_mapper

=== Response for GET http://localhost:8080/hello/Rulatir
=> Status         : 200 OK
=> Headers        :
   content-type: "text/html; charset=utf-8"
   content-length: "30"
   date: "Wed, 24 May 2023 23:05:08 GMT"
=> Client Cookies :
   auth-token: user-1.exp.sign
=> Response Body  :
Hello Rulatir
===

Hum, I will look at it, but I am not sure this an httpc-test issue.
The httpc-test uses reqwest and the reqwest client store and it would be surprising if those libs would have this bug.
I will eventually implement the logout in the rust-web-app awesomeapp blueprint (video coming soon), and report back here.
Thanks for reporting though.

Oh, you're the author of that tutorial :)

Arrived to the exact same point trying to do that while following the video tutorial.
Same behaviour (works ok but prints wrong info).

Ha, the prints are the issue. I might have a bug there. Now I know where to look.
Anyway, finishing the video, and did not do the logoff yet. But will do soon.

ok, sorry @SFToro @rulatir I think I made a silly mistake in httpc-test about the cookies.
continuing to investigate and will fix soon.

Ok, wrong alert, httpc-test was fine. I thought it was a drain I did on the HeaderMap, but in fact, it was ok and the right thing to do (to avoid clones).
Now, I found the issue. In the Rust Axum Full Course I do not set the cookie path to root, and so, the cookies get rightfully set to only /api/.
So, the fix is to do the set_path as follow.
	let mut cookie = Cookie::new(AUTH_TOKEN, token.to_string());
	cookie.set_http_only(true);
	cookie.set_path("/");

	cookies.add(cookie);
	...
	```

And then it should work.

I am closing this issue as I think this was the issue you both have. If not, feel free to log another ticket with some simple code sample I can reproduce.


Introduce EVM feature test in CI

Probably simply by running the evm demo (https://github.com/integritee-network/worker/blob/master/cli/demo_smart_contract.sh)  and building the worker with the evm feature (https://github.com/integritee-network/worker/issues/936#issuecomment-1232876938)

We need a docker-compose setup for an EVM integration test (following the same pattern as all the other integration tests in docker/. The build is already done with the evm feature flag:
https://github.com/integritee-network/worker/blob/2471cc52cf0377323886a43b0e7c2e9181265a67/.github/workflows/build_and_test.yml#L38.
So we have a docker image available in the CI that has sidechain and evm enabled.


Fixed several type definitions

What:
Fixed several type definitions as well as added the missing ones.

Why:
For proper typescript support.

How:
Please take a look at the commits.

Checklist:

[ ] Documentation
[ ] Tests
[x] Ready to be merged

[x] Added myself to contributors table

Fixes #406

Codecov Report

Merging #405 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff          @@
##           master   #405   +/-   ##
=====================================
  Coverage     100%   100%
=====================================
  Files           4      4
  Lines         335    335
  Branches       90     90
=====================================
  Hits          335    335

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c21a077...0be018f. Read the comment docs.


sick_safetyscanners2: 1.0.3-2 in 'galactic/distribution.yaml' [bloom]

Increasing version of package(s) in repository sick_safetyscanners2 to 1.0.3-2:

upstream repository: https://github.com/SICKAG/sick_safetyscanners2.git
release repository: https://github.com/SICKAG/sick_safetyscanners2-release.git
distro file: galactic/distribution.yaml
bloom version: 0.10.7
previous version for package: null

sick_safetyscanners2
* Fixes unsafe pointer access in UDP callback
* Implement lifecycle node
* Added functionality to allow multicast
* set not using the default sick angles as default
* moved changeSensor settings to be always be invoked
* fixed typo in launch file
* Contributors: Brice, Erwin Lejeune, Soma Gallai, Lennart Puck, Tanmay

Holding for Galactic Sync


Business profile screens partial

Please update unit tests for he new/updated controller methods.
The new CreateDynamicsShareholderLegalEntity() method must contain validation for the currently logged-in user.


compile failed due to issue with chainparams.cpp and a bad vSeeds.push.back line

Branch - Master
The offending line is vSeeds.push_back(CDNSSeedData(""<IP_ADDRESS>", ""<IP_ADDRESS>")); which when comparing to the other vSeeds.push.back lines it would seem their are to many " in there.
Changing it to this appears to clear the problem and allow it to build
vSeeds.push_back(CDNSSeedData("<IP_ADDRESS>", "<IP_ADDRESS>"));

fixed the issue


Adds session to the navigation menu and order links properly

[#118608021]
Signed-off-by: John Shahid<EMAIL_ADDRESS>

This pr depends on cloudfoundry/docs-buildpacks#61please do not merge until the other pr is merged first

Thanks, jvshahid!


Tertestrial

@charlierudolph
Terrestrial works with Git Town as well!

Nice! I've actually moved tertestrial.yml to my global gitignore and no longer commit them.

Tests are passing now


Macro defined log messages

So that we can have debug/trace log messages that are included at compile time only when compiled in Debug mode. Right now, we can set the log level but having arguments of debug and trace messages evaluated slows down the system.

Perhaps something like
WARNING(logger << "my message");

to replace
logger.warning() << "my message";

where the macro expansion is something like
if(logger.level() >= log::Warning) {
    logger.warning() << "my message";
}

Might also be worth splitting off the logger into its own repository and making it header-only.


Remove unecessary image commands

Let's remove unecessary image commands in Image.

Closed by f71e261 and 745b734.


Embed resource thumbnails not showing up in production studio

Note: Images seem to show up fine in the published site.
Steps to Reproduce

Visit https://ocw-studio.odl.mit.edu/sites/18-152-introduction-to-partial-differential-equations-fall-2005/type/page/edit/4d482928-9d2b-235f-6034-cc905080fc70/

Expected Behavior
Images should show up in markdown body
Actual Behavior
Image not found icon shows with a src like:
https://ol-ocw-studio-app-production.s3.amazonaws.com/courses/18-152-introduction-to-partial-differential-equations-fall-2005/9a384be87fefb7342f3f191afec2c6a1_R1.jpg

Screenshot or Screencast

@blarghmatey I think this can be closed now?


Add RLIM_INFINITY definition for Android

This adds the definition for RLIM_INFINITY to Android, mirroring the Linux definition. Ran into this while trying to build sccache natively in Termux on Android, and is the only thing preventing sccache from building on libc master.

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @gnzlbg (or someone else) soon.
If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.
Please see the contribution instructions for more information.

@bors: r+

:pushpin: Commit 3166091b00204c773e7c515c2cdfe0f0172e559d has been approved by gnzlbg

:hourglass: Testing commit 3166091b00204c773e7c515c2cdfe0f0172e559d with merge e857f95106c3b701afc6b131bf41857bec3d3d32...

:sunny: Test successful - checks-cirrus-freebsd-10, checks-cirrus-freebsd-11, checks-cirrus-freebsd-12, status-azure
Approved by: gnzlbg
Pushing e857f95106c3b701afc6b131bf41857bec3d3d32 to master...


Cloud SQL MySQL 5.7 import from CSV file defaults to utf8 (!= utf8mb4)

Environment details

OS: Mac OS Mojave, 10.14.2
Python version: 3.6
pip version: 18.1
google-api-python-client version: google-api-python-client==1.6.2

Steps to reproduce
Import CSV file in GCS bucket to Cloud SQL using service.instances().import_(), CSV file must have at least one character supported only by 'utf8mb4' character set.
Python sample code from: https://cloud.google.com/sql/docs/mysql/admin-api/v1beta4/instances/import
The LOAD DATA INFILE query that Google's Python API generates is defaulting to 'utf8' character set. Note that for MySQL 5.7, utf8 is an alias for utf8mb3, which != utf8mb4. utf8mb4 is a superset of utf8mb3. Now, if the CSV file contains characters supported by utf8mb4, but not utf8mb3, the load data import process fails.
Running these commands on mysqld client I can replicate the exact error returned by the API:
LOAD DATA INFILE 'problematic.csv'
INTO TABLE my_table
CHARACTER SET utf8
FIELDS TERMINATED BY ','
OPTIONALLY ENCLOSED BY '"'
ESCAPED BY '"'
ERROR 1300 (HY000): Invalid utf8 character string: ''Afikanisitani|'Apekanikana|A Phu Han (Afghanistan)|A Phú Hãn '
Now, for a query that works:
LOAD DATA INFILE 'problematic.csv'
INTO TABLE my_table
CHARACTER SET utf8mb4
FIELDS TERMINATED BY ','
OPTIONALLY ENCLOSED BY '"'
ESCAPED BY '"'
Query OK, 75641 rows affected (1.14 sec)
Records: 75641  Deleted: 0  Skipped: 0  Warnings: 0
Note the only difference is the specification of the character set. Furthermore, the documentation on this URL seems incorrect, as the experiment above has shown the API uses 'utf8' as character set: https://cloud.google.com/sql/docs/mysql/import-export/importing
LOAD DATA INFILE ...
CHARACTER SET 'utf8mb4'
FIELDS TERMINATED BY ',' OPTIONALLY ENCLOSED BY '"' ESCAPED BY '"'.
Additional details in Stack Overflow post: https://stackoverflow.com/questions/54175183/cloud-sql-csv-file-import-how-to-specify-utf8mb4-character-set-in-load-data

Hi @osvalban,
I'm sorry that it took a while to respond to this issue. Are you interested to submit a PR? If not, can you share some sample code for me to re-create the issue?

I'm going to close off this issue due to inactivity but if you're still having trouble please re-open it with more information.


Regarding deployment using TF serving  or Pytroch serving

Dear
I want to deploy the model either on TF Serving or pytorch serving.
I have few dobuts, can you help for same.
1). How to use weights for tf_model.h5 to reduce the size of model. Or same for pytorch_model.bin
2) Or can you help me deploy in production mode.
Thanks

Please visit this link Vamsi/T5_Paraphrase_Paws. You can find the t5_model.h5 and the pytorch_model.bin files for this model. Maybe you can follow this guide for quantizing the weights https://spell.ml/blog/pytorch-quantization-X8e7wBAAACIAHPhT.


Improve Migration Command by Managing Version with Reference to package.json and Update connect-query Version

In this PR, I've made the following updates:

The versions, which were originally managed inline within the code, have been modified to refer to the version specified in package.json for @connectrpc/connectrelated packages.
I've also updated the @connectrpc/connect-query to the latest version.

Previously, running npx @connectrpc/connect-migrate@latest would migrate @bufbuild/connect to "@connectrpc/connect: "^1.0.0-rc1". However, the latest versions of @connectrpc/connect-related packages are '1.0.0', and this version is equivalent to the one in package.json. Therefore, in this PR, the inline versions have been changed to refer to the version in package.json.
This alteration also induces a structural change specifically in the output directory (dist). For further details on this transformation, please refer to the displayed ‘before’ and ‘after’ tree command outputs below.

before
❯ tree dist
dist
└── cjs
    ├── arguments.js
    ├── cli.js
    ├── lib
    │   ├── logger.js
    │   ├── migrate-lock-files.js
    │   ├── migrate-packages.js
    │   ├── migrate-source-files.js
    │   ├── package-json.js
    │   ├── package-json.spec.js
    │   ├── replace-dependencies.js
    │   ├── replace-dependencies.spec.js
    │   ├── run.js
    │   ├── scan.js
    │   └── update-source-file.js
    ├── migration.js
    └── migrations
        ├── v0.13.1-transform.js
        ├── v0.13.1-transform.spec.js
        ├── v0.13.1.js
        └── v0.13.1.spec.js

3 directories, 18 files

after
❯ tree dist
dist
└── cjs
    ├── package.json
    └── src
        ├── arguments.js
        ├── cli.js
        ├── lib
        │   ├── logger.js
        │   ├── migrate-lock-files.js
        │   ├── migrate-packages.js
        │   ├── migrate-source-files.js
        │   ├── package-json.js
        │   ├── package-json.spec.js
        │   ├── replace-dependencies.js
        │   ├── replace-dependencies.spec.js
        │   ├── run.js
        │   ├── scan.js
        │   └── update-source-file.js
        ├── migration.js
        └── migrations
            ├── v0.13.1-transform.js
            ├── v0.13.1-transform.spec.js
            ├── v0.13.1.js
            └── v0.13.1.spec.js

4 directories, 19 files

Moreover, migration command updates @bufbuild/connect-query to @connectrpc/connect-query: "0.4.3", but its latest version is actually 0.4.4.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Hey! Thank you for the PR! Thank you for updating the versions to the latest.
Regarding reading the version from package.json, the idea is to update to the latest version of the next non-breaking change or rather handle the migration in steps based on breaking changes (like 0.13.1). I think it will be better if we just have the version in the file rather than read it from package.json. Can you update the PR accordingly?

@srikrsna-buf Thank you for the review! I understood the need for changes and have made the necessary adjustments :)


More tweaks

@msrb Your image is available in the registry: docker pull registry.devshift.net/fabric8-analytics/worker-scaler:SNAPSHOT-PR-25

@msrb Your image is available in the registry: docker pull registry.devshift.net/fabric8-analytics/worker-scaler:SNAPSHOT-PR-25

@msrb Your image is available in the registry: docker pull registry.devshift.net/fabric8-analytics/worker-scaler:SNAPSHOT-PR-25


Consolidate a bit ansible code

This patch adds a couple of tags to the code (work isn't finished yet).
It also removes some useless files (mostly cleanup.yml that weren't
modified), and corrects some ansible code, mostly missing FQN (i.e.
missing ansible.builtin prefix for the modules).
There's also some reordering of parameters.
Basic functions shouldn't be affected by this change - but it's opening
a door for better usage, allowing to run multiple times the same command
and using --tags and --skip-tags parameters. This should allow a
faster run, as well as a "stage" oriented usage (stage-1: install
packages; stage-2: bootstrap basics; ...).
As a pull request owner and reviewers, I checked that:

[X] Appropriate testing is done and actually running
[x] Appropriate documentation exists and/or is up-to-date:

[x] Content of the docs/source is reflecting the changes

/approve


Use any instead of seriesLists == ([],) so it's not passed to normalize

This commit is an improvement on
7b3a1df5b82385f71da17f100e15ebdcced8eeff. It's possible for seriesLists
to be ([], []) which passes the current check, but still fails when it
gets to normalize.
Using any checks if there are any valid arrays in the seriesLists.

Thanks @jsternberg!


Sending STX/SIP10 with Ledger fails with "sending bitcoin is temporary disabled" error

This is affecting any Ledger user. A viable workaround seems to be to use https://sendstx.com to send STX. For other tokens I think Ledger users best wait for a fix unless they are familiar with calling the token contract directly using the Explorer sandbox.
Steps to reproduce

Restore wallet with Ledger
Click Send
Choose asset: Click STX or a SIP010 token to send
See error (screenshot above).

Hello, I have initiated this topic on Discord due to an issue to send STX from my Hiro wallet and a guy werner.btc has launched this topic on Github. I tried again but I have always the same message, impossible to send STX. My version is 6.2.0 I have installed my extension chrome wallet + ledger with this link chrome-extension://ldinpeekobnhjjdofggfgjlcehhmanlj/index.html#/get-started
Many thanks for help

Sorry but I have only STX (see attached doc) that I try to send and that's not possible with error as described , thanks by advance for your help

@Lapy71 there is a fix for this in version 6.2.1 of the wallet. This has been released but is pending review by the extension store for Chrome. Once accepted your wallet is expected to update automatically within a couple hours or you can force it with a restart of the browser.

Thanks Werner
I will update the chrome wallet extension and check if the version is 6.2.1
Many thanks for your help
Have a nice weekend
Regards
Le jeu. 3 août 2023, 13:29, Werner @.***> a écrit :

@Lapy71 https://github.com/Lapy71 there is a fix for this in version
6.2.1 of the wallet. This has been released but is pending review by the
extension store for Chrome. Once accepted your wallet is expected to update
automatically within a couple hours or you can force it with a restart of
the browser.
—
Reply to this email directly, view it on GitHub
https://github.com/hirosystems/wallet/issues/4083#issuecomment-1663815053,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AWCQV42YBQOPKGLUSPIYN3DXTODRVANCNFSM6AAAAAA3AD4RL4
.
You are receiving this because you were mentioned.Message ID:
@.***>

Hey Werner, I have updated my chrome wallet.
I made a simulation with address and memo and and that's run Ok now, no error.
Many many thanks for your great help and speed for acting best regards


WIP: Help replacement

Migrate help

I think

should point to https://docs.openmicroscopy.org/omero/5.6.2/sysadmins/import-scenarios.html#parallel-import

Instead of https://github.com/ome/www.openmicroscopy.org/pull/396/files#diff-20494d8d48cbfaa98988087e56275885R36 I would go for link to https://omero-guides.readthedocs.io/projects/introduction/en/latest/search-omero.html?highlight=search and https://omero-guides.readthedocs.io/projects/introduction/en/latest/annotate.html

To the "Browse and view",  suggest to add one more link, for Browsing, https://omero-guides.readthedocs.io/en/latest/introduction/docs/data-management.html#browsing-and-rendering

Swap the order of buttons here - first, the less scary omero-guide, then the full permissions overview.

Swap the order of buttons here. First, the developer guide (less complex), then the model explanation (hard to navigate and realize what to look for)

The analyse part of OMERO features is not right in the first box, see screenshot below.

The first link is pointing to omero-guides with the 3rd party tools. This is fine, but because it is out of place and mislabelled, then it is underselling that work.
The second link is pointing to help, which we wanted to get rid of.
Suggest:

Create a new icon with something like "use 3rd party tools to analyze your data in OMERO" (yes, there is a section below on the same page which has this, but this is hardly visible, as you have to scroll down to even see it.
Put this icon also under "New" (features), maybe replacing ROI folders ?
Have this icon with "analytical results attachment" too, but with one link pointing to https://omero-guides.readthedocs.io/projects/introduction/en/latest/annotate.html (the text there needs to be improved) and the other link pointing to https://omero-guides.readthedocs.io/projects/upload/en/latest/metadata.html


Archive exercises

Codecov Report

Merging #448 (de585c5) into master (056b2af) will increase coverage by 0.23%.
Report is 2 commits behind head on master.
The diff coverage is 80.31%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
@@            Coverage Diff             @@
##           master     #448      +/-   ##
==========================================
+ Coverage   69.43%   69.66%   +0.23%
==========================================
  Files         462      462
  Lines       17223    17331     +108
==========================================
+ Hits        11958    12073     +115
+ Misses       5265     5258       -7

Files Changed
Coverage Δ

app/V1Module/presenters/ExerciseFilesPresenter.php
83.33% <ø> (ø)

app/V1Module/presenters/GroupsPresenter.php
83.02% <ø> (-0.36%)
:arrow_down:

app/V1Module/presenters/NotificationsPresenter.php
81.08% <ø> (ø)

app/V1Module/presenters/PipelinesPresenter.php
71.52% <ø> (ø)

app/V1Module/presenters/UsersPresenter.php
80.19% <ø> (-0.09%)
:arrow_down:

...ications/Comments/SolutionCommentsEmailsSender.php
5.55% <0.00%> (-0.25%)
:arrow_down:

app/helpers/Pagination.php
92.00% <ø> (ø)

...presenters/ReferenceExerciseSolutionsPresenter.php
72.13% <66.66%> (-0.85%)
:arrow_down:

...ule/security/Policies/ExercisePermissionPolicy.php
68.00% <75.00%> (+3.71%)
:arrow_up:

app/model/entity/ReferenceExerciseSolution.php
93.75% <75.00%> (-6.25%)
:arrow_down:

... and 8 more

... and 2 files with indirect coverage changes


Update UI tests for 1.66 and switch CI to stable Rust 1.66

Also pins the CI image to the current staging with Rust 1.66, will revert back to the generic production tag after this is merged.

The CI pipeline was cancelled due to failure one of the required jobs.
Job name: test-linux-stable
Logs: https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/2246987

thread 'test_enum' panicked at 'assertion failed: `(left == right)`
  left: `"Enum::VariantUnnamed(1, 2, 3, PhantomData<(derive_no_bound::ImplNone, derive_no_bound::ImplNone)>)"`,
 right: `"Enum::VariantUnnamed(1, 2, 3, PhantomData)"`', frame/support/test/tests/derive_no_bound.rs:212:5

For this issue, can you please just correct the string in the test to correspond to the new expected value?

The CI pipeline was cancelled due to failure one of the required jobs.
Job name: test-linux-stable
Logs: https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/2247524

The CI pipeline was cancelled due to failure one of the required jobs.
Job name: test-linux-stable
Logs: https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/2247525

The CI pipeline was cancelled due to failure one of the required jobs.
Job name: test-linux-stable
Logs: https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/2247590

The CI pipeline was cancelled due to failure one of the required jobs.
Job name: test-linux-stable
Logs: https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/2247774

bot merge


Semantics of ANKSigned bitwise operations

It is quite a journey figuring out whether or not BinaryInteger always expects two’s complement semantics. In particular because BinaryInteger's documentation uses the phrase “binary representation” instead of “two’s complement representation” in reference to every property/method except for BinaryInteger/words. It is clear, however, from xwu’s comment that BinaryInteger always expects two’s complement semantic regardless of actual in-memory representation.

What this means is that the following operations will operate on ANKSigned's two's complement form:

<<, >>, &<<, &>>
~, &, |, ^
nonzeroBitCount
trailingZeroBitCount
leadningZeroBitCount
mostSignificantBit
leastSignificantBit

In case sign-magnitude semantics is preferred, the alternative would have to side-step BinaryInteger.

This issue was made obsolete by #14 where ANKSigned was reworked such that it no longer conforms to BinaryInteger.


wrong rules

first of all names should be provided in full, to avoid confusion - in effect there are two 'Port:' definitions and 'Source' can have a meaning for both - IP and port.
second of all - 'Source Port' should be configured as 'Any' not 3389 - at least in my case setting it caused machine unvailable via RDP, only by setting Source Port to Any solved the issue.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 81cd2079-33f0-3fb8-59c9-29cd421b0c75
Version Independent ID: dfe503db-7b9d-e8f4-476c-d906b0ff01e6
Content: Cannot connect to Azure VMs because the RDP port is not enabled in NSG
Content Source: articles/virtual-machines/troubleshooting/troubleshoot-rdp-nsg-problem.md
Service: virtual-machines-windows
GitHub Login: @genlin
Microsoft Alias: genli

@Lelivienne
Thanks for the feedback! I will submit a PR to fix this document

@Lelivienne I hope removing the Port: 3389  in the second line is fine.
If we remove that then it matches the table displayed on the Azure portal.
If we try to add a new rule, Then we need to mention about source and destination port ranges as well.

depends if you use basic or advanced. i'd suggest providing full info from advanced definition just as it is now, just corrected.
20 wrz 2019 13:32 jakaruna-MSFT<EMAIL_ADDRESS>napisał(a):
@Leliviennehttps://github.com/Lelivienne I hope removing the Port: 3389 in the second line is fine.
If we remove that then it matches the table displayed on the Azure portal.
If we try to add a new rule, Then we need to mention about source and destination port ranges as well.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/MicrosoftDocs/azure-docs/issues/39261?email_source=notifications&email_token=ALZE6ZUHXCEMQ2G2X4QAU73QKSYEJA5CNFSM4IYVRTK2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD7GNCII#issuecomment-533516577, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ALZE6ZVHZW7NNIPG3QX5AXLQKSYEJANCNFSM4IYVRTKQ.

I submitted a PR. Please check that.  It should reflect in the actual doc within few hours.
If needed we can create additional PR
I hope the author is asking the users to verify the provided info with the table.

@Lelivienne  Closing this issue. Doc is updated. Feel free to open a new issue if there are any concerns


Changes to color scheme for dark mode

The color scheme for dark mode could be improved for better design and readability.

Dark mode Theme has been updated in design File.
Dark UI:
https://www.figma.com/design/m5eMFTKD391AiJAXaEzgxB/Bitcoin-Keeper?node-id=2511-4255&t=buf0s8aYaZQKNuQv-1
Dark mode design Ssytem:
https://www.figma.com/design/m5eMFTKD391AiJAXaEzgxB/Bitcoin-Keeper?node-id=0-1&t=buf0s8aYaZQKNuQv-1

Verified this issue on dev app v 1.2.18(410)


Adds information about the public dataset bundle

The bundle published under the --channel=public/edge also contains a postgresql-data-k8s charm, which is configured with a PostgreSQL database dump containing a test dataset meant for testing purposes. This bundle can be used for trying out Waltz.
This commit adds information about in the documentation.

LGTM! merged.


Provide support for resources with generateName

Sometimes there's some tools that take advantage of resources defined with genereteName instead of name in the resource definition, mostly so that a new instance is created every time the resource is applied/created to the cluster.
kubectl does require you to use create instead of apply for this type of resources as otherwise it will give an error.
In my use case, I'm deploying programmatically a Tekton PipelineRun, and my expected behavior is that everytime that I use kapp deploy a new instance is created but the previous are kept under kapp control.
After discussing with @cppforlife in the K8s slack, he gave me a workaround which works (after applying a manual fix to remove line https://github.com/k14s/kapp/blob/4db982f52b04bebf30d366f3d9d3f914ef383516/pkg/kapp/diff/template_resource.go#L154 in a local fork). The workaround is to:

use name instead of generateName
use kapp.k14s.io/versioned: '' to make kapp create a new version for every resource
use kapp.k14s.io/nonce: '' to allow kapp to inject a unique ID for every generated resource

With this, what you get is the same behavior as when using generateName but requires you to make a change in your resource definition and also makes the generatedName kapp specific.
Although not ideal, it works ok for many (including me).
This issue is to consider whether adding support out of the box to resources defined with generateName make sense and what would be the best implementation.

Argo is another tool that makes frequent use of generateName.
When I was testing it's hello-world example, I would get the following output when doing a redeploy with kapp
Namespace  Name               Kind      Conds.  Age  Op      Op st.  Wait to    Rs  Ri
tier0      hello-world-*      Workflow  -       -    create  -       reconcile  -   -
^          hello-world-86gqr  Workflow  1/1 t   1m   delete  -       delete     ok  -

Op:      1 create, 1 delete, 0 update, 0 noop
Wait to: 1 reconcile, 1 delete, 0 noop

Continue? [yN]: y

10:15:37PM: ---- applying 2 changes [0/2 done] ----
10:15:37PM: delete workflow/hello-world-86gqr (argoproj.io/v1alpha1) namespace: tier0
10:15:39PM: create workflow/hello-world-* (argoproj.io/v1alpha1) namespace: tier0
10:15:39PM: ---- waiting on 2 changes [0/2 done] ----
10:15:39PM: error: reconcile workflow/hello-world-* (argoproj.io/v1alpha1) namespace: tier0

kapp: Error: waiting on reconcile workflow/hello-world-* (argoproj.io/v1alpha1) namespace: tier0:
  Errored:
    Getting resource workflow/hello-world-* (argoproj.io/v1alpha1) namespace: tier0: workflows.argoproj.io "hello-world-*" not found (reason: NotFound)

I managed to suppress the waiting-reconciliation with the following annotation
  annotations:
    kapp.k14s.io/disable-wait: ""

This caused a new Workflow object to be created...which I guess was the goal?...but I'm not entirely sure if that's what I wanted to do or not.

for reference https://argoproj.github.io/argo-workflows/examples/#hello-world

I just encountered this as while using an idempotent K8s job with kapp
I can think of two potential approaches to solving this problem

kapp generates the name based on generateName
kapp's wait uses the name returned by the API server

Hey folks - following up here after a few years - is this something that we can still fix?

Hi @dprotaso! It seems like a reasonable ask to me, and I think the first option that you suggested (kapp generates the name based on generateName) makes sense as we already have versioned resources that does something similar. I will mark this as accepted but not sure when we will be able to get to it. We can definitely prioritise a review if you (or someone else) would like to contribute a PR.


HTTP Client: Use per-client event handlers

This PR indents to replace the global shared BTreeMap with private event handler pointers, thus saving a lock and a lookup.

Heh. I was looking for this user_data backdoor and couldn't believe my eyes that it is not available for the ESP-IDF HTTP client. Apparently, I was not looking carefully enough - hence the btree + mutex monstrocity :)
Anyway - I have one comment (look at the review) and then we can merge that. Code looks very decent!

Fair warning: I don't have the setup to build this locally, so even without using the trait_alias feature, the PR might not compile as is.

Fair warning: I don't have the setup to build this locally, so even without using the trait_alias feature, the PR might not compile as is.

OK then let me actually test it tmr before merging :)

I've implemented something along the lines of your code here: https://github.com/esp-rs/esp-idf-svc/commit/9c81cf63577949495906a23cfb880b6ff3b9b4e9


Custom data Resolution and FillForwarding

Expected Behavior

Custom data does not trigger unnecessary fill forwarding

Actual Behavior

When running the algorithm provided bellow, equity data is filled forward since the custom data resolution is Minute, the default value, but in this case, CBOE is a daily data source, so this causes a significant performance overhead which could be avoided

Potential Solution

Data types could be aware of their supported data resolutions, and Lean could throw an exception if the requested Resolution isn't available. This could be useful for Options Daily resolution too. Similar pattern as IsSparseData/RequiresMapping
Work around is to set the right resolution for custom data

Reproducing the Problem

    public class BasicTemplateBenchmark : QCAlgorithm
    {
        public override void Initialize()
        {
            SetStartDate(2000, 01, 01);
            SetEndDate(2019, 01, 01);
            AddEquity("SPY", Resolution.Daily);
            AddData<CBOE>("VIX");
        }

        public override void OnData(Slice data)
        {
            if (!Portfolio.Invested)
            {
                SetHoldings("SPY", 1);
                Debug("Purchased Stock");
            }
        }
    }

System Information

N/A
Checklist

[x] I have completely filled out this template
[x] I have confirmed that this issue exists on the current master branch
[x] I have confirmed that this is not a duplicate issue by searching issues

[x] I have provided detailed steps to reproduce the issue

Per discussion -- to better support multiple custom resolutions
List<Resolution> SupportedResolutions
along with testing making Resolution nullable which defaults to DefaultResolution
Then a beautiful message like:
"Sorry Minute is not a supported resolution for USEnergy. Please change your AddData to use one of the supported resolutions (Daily)." which throws if one of the requested resolutions is not provided.


Chapter 3 | use of tfd.Independend | TFP version

Hi  @matthew-mcateer,
could you please elaborate on the indtroduction of these lines in Chapter 3?
sds = tfd.Independent(tfd.Uniform(low=[0., 0.],                                   high=[100., 100.]),                       reinterpreted_batch_ndims=1, name='sds')
At the moment the texts says

we will initially model them as uniform on 0 to 100. We will include both standard deviations in our model using a single line of TFP code

Later on in Chapter 3 the two prio distributions for the sigmas are just modeled 'plain vanilla' with
rv_sds = tfd.Uniform(name="rv_sds", low=[0., 0.], high=[100., 100.])
More over the 'variable sds'  does not show up anymore in Chapter 3.
So, why is the Independent distribution from batch of distributions introduced at all and which gains would be realized if used?

Did you figure this out?


[spec/attribute] Improve docs

Add missing @identifier grammar.
Fix: UDAs are not just expressions, they can be @SomeType. Describe kinds of UDA.
Add comments & show @constant in first example.
Describe type instance UDA.
Show function parameter with UDA.
Add subheading for getAttributes.
Use sequence not expression tuple, link to sequence docs, tweak wording. (They can include types not just expressions).
Add newlines for getAttributes example, use lowercase for manifest constant.
Add usage subheading, remove redundant sentence about tuples.

Add missing @identifier grammar.

@identifier is covered by TemplateSingleArgument


Determine if raw mode means we can drop Jansi

Also: Figure out WTF Jansi is doing to make Windows work, and do it ourselves with mosaic-terminal


S3

What exactly do you want to use S3 for? That would be great if you could add a bit further detail to this ticket in your spare time.

I will use S3 for the file storage, currently planning to use it for image files.

Backend will save an image file to S3, and save the URL or file path to the Database.
Frontend will request fetching images to S3 directly


Should we standardize our round corners?

Is your feature request related to a problem? Please describe.
Currently we have components that have rounded corners by default (.nes-balloon), and we have other components that are only rounded if they receive the .is-rounded class (.nes-container, .nes-dialog).
Personally, I think we should round all of those corners by default, but I'm open to hearing other arguments.

Personally, i think everything should be squared by default.

Personally, I think we should round all of those corners by default, but I'm open to hearing other arguments.

I agree

Squared by default sounds like a good decision.

I think the square is good by default 👍


How to write cronjobs in seperate file nodejs

How can i write the cronjobs in a different file?

Hi, @guypeled1, This package has the ability to make multi cron-jobs, and using this system, you can make when you need it, but if  you need more details, I make a chat (ChatGPT) to explain how to use and create multi cron-jobs: Link


Added UX Design and Data Model

I need you to git rm the .DS_Store file and the .idea/ folder from your PR. Thanks.


Continue Your OData Exploration with EPM

Tutorials: https://developers.sap.com/tutorials/odata-02-exploration-epm.html
Write here how you think we can improve the tutorial ...
The tutorial is not working.
In response to
https://sapes5.sapdevcenter.com/sap/opu/odata/sap/EPM_REF_APPS_SHOP_SRV/Products('HT-1001')
I get this error message

/IWBEP/CM_MGW_RT/020
Resource not found for segment 'Product'

<component_id>BC-SRV-NWD-FRA</component_id>
<service_namespace>/SAP/</service_namespace>
<service_id>EPM_REF_APPS_SHOP_SRV</service_id>
<service_version>0001</service_version>

This means the rest of the tutorial steps 2, 3, 4 5, cannot be completed because they depend on HT-1001 existing
Please fix the tutorial

Hi @davidsmith288 - there are a couple of things here:

if the specific product (HT-1001) cannot be found, you can just pick another one - there's a note to this effect directly after the URL that gives HT-1001 as an example ("If there isn’t a product entry with this specific ID, you can choose another one - the IDs follow a similar pattern.")
there does seem to be a general database issue with the system right now - I've alerted the owners of that system to get that fixed. This will unfortunately impact the ability to work through this tutorial but I hope that this issue will be fixed in the next 24-48 hours.

Thanks for the heads up!


getCoreWorkspaceProject is not a function

Describe the bug
[Error 6:59:41 PM] [API] Failed to refresh Vitest [Error Error] Vitest failed to start:
TypeError: i.getCoreWorkspaceProject is not a function
    at new cr (C:\Users\HShakoor\.vscode\extensions\vitest.explorer-1.8.1\dist\worker.js:8:31214)
    at new e (C:\Users\HShakoor\.vscode\extensions\vitest.explorer-1.8.1\dist\worker.js:21:1111)
    at process.e (C:\Users\HShakoor\.vscode\extensions\vitest.explorer-1.8.1\dist\worker.js:21:9196)
Error: Vitest failed to start:
TypeError: i.getCoreWorkspaceProject is not a function
    at new cr (C:\Users\HShakoor\.vscode\extensions\vitest.explorer-1.8.1\dist\worker.js:8:31214)
    at new e (C:\Users\HShakoor\.vscode\extensions\vitest.explorer-1.8.1\dist\worker.js:21:1111)
    at process.e (C:\Users\HShakoor\.vscode\extensions\vitest.explorer-1.8.1\dist\worker.js:21:9196)
	at ChildProcess.p (c:\Users\HShakoor\.vscode\extensions\vitest.explorer-1.8.1\dist\extension.js:20:3584)
	at ChildProcess.emit (node:events:519:28)
	at ChildProcess.emit (node:domain:488:12)
	at emit (node:internal/child_process:951:14)
	at process.processTicksAndRejections (node:internal/process/task_queues:83:21)

Reproduction
This is an existing project where Vitest was working; I have upgrade packages to the latest. This seems like conflict with the vitest extension and package version.
Output
[Error 6:59:41 PM] [API] Failed to refresh Vitest [Error Error] Vitest failed to start:
TypeError: i.getCoreWorkspaceProject is not a function
    at new cr (C:\Users\HShakoor\.vscode\extensions\vitest.explorer-1.8.1\dist\worker.js:8:31214)
    at new e (C:\Users\HShakoor\.vscode\extensions\vitest.explorer-1.8.1\dist\worker.js:21:1111)
    at process.e (C:\Users\HShakoor\.vscode\extensions\vitest.explorer-1.8.1\dist\worker.js:21:9196)
Error: Vitest failed to start:
TypeError: i.getCoreWorkspaceProject is not a function
    at new cr (C:\Users\HShakoor\.vscode\extensions\vitest.explorer-1.8.1\dist\worker.js:8:31214)
    at new e (C:\Users\HShakoor\.vscode\extensions\vitest.explorer-1.8.1\dist\worker.js:21:1111)
    at process.e (C:\Users\HShakoor\.vscode\extensions\vitest.explorer-1.8.1\dist\worker.js:21:9196)
	at ChildProcess.p (c:\Users\HShakoor\.vscode\extensions\vitest.explorer-1.8.1\dist\extension.js:20:3584)
	at ChildProcess.emit (node:events:519:28)
	at ChildProcess.emit (node:domain:488:12)
	at emit (node:internal/child_process:951:14)
	at process.processTicksAndRejections (node:internal/process/task_queues:83:21)

### Extension Version

v1.8.1

### Vitest Version

2.2.0-beta.2

### Validations

- [X] Check that you are using the latest version of the extension
- [X] Check that there isn't [already an issue](https://github.com/vitest-dev/vscode/issues) that reports the same bug to avoid creating a duplicate.
- [X] Check that this is a concrete bug. For Q&A open a [GitHub Discussion](https://github.com/vitest-dev/vscode/discussions) or join our [Discord Chat Server](https://chat.vitest.dev).
- [X] The provided reproduction is a [minimal reproducible example](https://stackoverflow.com/help/minimal-reproducible-example) of the bug.

I get the same error with v3.0.0-beta.1, but only in vscode, when running from pnpm it runs fine.

Yes, the issue is with vscode only. CLI is working fine; it runs in watch mode so kinda like that as well.

@sheremet-va Thanks! It's fixed 👍


[FEA] Make blazingsql debug builds work, add BlazingContext.sql implementation

Fixes issues blocking blazingsql debug builds
Adds an initial single-node BlazingContext.sql implementation

Received permission from Paul to ship it.


Clean up and restore some inherit_test code.

The subject.validate tests can be restored with some fairly minor syntax changes to be compatible with dry-validation.
There may be reasons to keep some of these tests commented-out that I'm not aware of.
The motivation for this clean-up is that I'm encountering some odd behaviour (possibly a bug, possibly a misunderstanding on my part) around inherited populators, and having a more thorough set of tests here is a prerequisite for me writing some tests to verify whether my issue is a bug or not.
cheers

Thanks for this. 👍

Cool, looking way better now! :heart_eyes:


Feature request: A sample index.html

Description
Hello,
Would you please post a sample of index.html layout that you used for the theme website? Defining a layout like you used for the website is not straightforward.
In addition, how can I change the menu on top of the first page to add new pages?

you mean landing layout? It's on the way.
I don't quite understand your second question, what do you mean by "the menu on top of the first page"?

@adibrastegarnia
I think I understand the question you are asking - you would like a layout similar to the example site. Below is the solution I found for making my site fit this layout.

See Issue #106 for a sample landing layout. Add this to your repository in the top level, and this will replace the index.html file so that this is the first page people will see when they go to your website. If you would like your menu to show up on the landing page, go to _layouts/landing.html, and change header: false to header: true on line 3.

To add new pages to the menu, edit data/navigation.yml as explained on the documentation website.
https://tianqi.name/jekyll-TeXt-theme/docs/en/navigation

If you would like the "home" button to still show a blog instead of the landing page, you will need to move some files and change some things in the _data/navigation.yml file and the _config.yml file.

create a directory called blog (ie mkdir blog)
copy your index.html file into blog (ie, cp index.html blog/)
To have this show up on the menu, _data/navigation.yml add

  - title:      Home
    url:        /blog/

In the index.html file, set the 'home' path to /blog (line 66)

paths:
  root    : # title link url, "/" (default)
  home    : /blog/ # home layout url, "/" (default)

Change the path under paginate to point to these posts (changed value shown below)

## => Paginate
##############################
paginate: 8
paginate_path: /blog/page:num # don't change this unless for special need

Change your defaults section to point to this directory

defaults:
  ## home
  - scope:
      path: "blog"
    values:
      articles:
        excerpt_type: html
  ## posts
  - scope:
      path: ""
      type: posts
    values:
      layout: article
      sharing: true
      license: true
      category: post
      aside:
        toc: true
      show_edit_on_github: true
      show_subscribe: true
      pageview: true

Making these changes, your site will automatically direct to a landing page. The text on the left menu ("Your site title" will go to your landing page, while on the right, the "Home" menu item will go to what was originally the default index (blog posts).) Hope this helps

@janash Thanks for your reply. Your answer helps me a lot. I found another elegant way to deal with this home and blog problems. I just checked your personal website. the homepage with various features is very beautiful. Could you please share the code of it? I couldn't find that part in your repository: jessica-personal-site

Hi @Harrypotterrrr - I ended up switching to a different Jekyll theme for my personal page. It is a different repository (private) than the one linked.


How i can use bulk import in this library ?

Hi
the bulk import that Explain here :
https://docs.arangodb.com/3.3/HTTP/BulkImports/
does not implemented ?

Hi, bulk imports are not implemented in the driver yet.


Taxes are not properly rounded with multiple taxRules

Tax prices are not rounded properly, when multiple tax rules apply.
Issue is, that the percentages of the tax rules are not rounded for precision. The tax price has to be therefore rounded via CashRounding in the Gross and Net calculators.

[public] Shopware automated response: This issue is linked to the internal issue: NEXT-38207
[created from NEXT-38207, comment 493157]


Flushing in PHPUnit calls no longer works in PHPUnit 7 / CMS 5.x

Affected Version
silverstripe/framework:dev-master
Description
The Silverstripe CMS documentation describes the ability to run a flush during a PHPUnit test run by specifying vendor/bin/phpunit vendor/silverstripe/framework/tests '' flush=1. This no longer works in the version of PHPUnit (currently 7.1.3) used in the master (5.x) branch of framework, instead throwing the following error:
Cannot open file "flush=1"

With limited time, I haven't been able to ascertain the cause - but it seems like PHPUnit may now support passing multiple directories / files to run tests in.
See this failed silverstripe/errorpage build for an example.

Bump, did you work this one out? I am experiencing the same problem on Recipe-Core 4.7.2 with sminnee/PHPUnit 5.7.77

This is an old issue that no longer applies, as CMS 5 requires phpunit 9


Allow to customize the trailing whitespace regexp

Currently, vim-airline uses hard-coded '\s$' to check for trailing
whitespace. However you might want to check for different values.
Therefore, set the variable
:let g:airline#extensions#whitespace#trailing_regexp to the required regexp
value.
closes #663

Another great one. Writing in markdown usually, where I don't care about one space, but two is a problem, so I hard code the change. This will make it easier. Thanks, Christian.


fix: replace list with link

Description
The documentation of the link component referenced the list component.
Changelog
Changed

Replaced list with link.

Hi, @eddybrando we recently moved the carbon-web-components repo over to https://github.com/carbon-design-system/carbon-for-ibm-dotcom. Would you mind re-opening this PR over there instead?


Fonts support

The current fonts are the default ones.
There should be a way for the user to modify the output screenshot fonts, starting from the basic/popular ones

Fira Code
Cascadia PL

Hey @khattakdev, can you please assign this to me?

Hi @khattakdev,  I came up with two possible solutions for this issue.

.We make use of the VS Code's fontStyle property and assign that font to the screenshot. If the user has to change the font of screenshot he can directly change the font of his editor.
Or we make a font selection UI and give the user a dropdown for selecting font after taking every screenshot.
Which of the two do you suggest should I go with?


[firebase_ ml_vision] Multiple init/dispose of camera gives blank screen but only on MotoZ2, not S9

I'm writing a flutter app that uses camera with ml_vision to scan text (it's a 8 character hex value along with a barcode, but I read the text instead of the barcode since the print resolution of the barcode stickers is not good enough).
Anyway, my issue is that after anywhere from a few to several (say 3 to 15) opens of the stateful page that uses the camera, I get a black screen preview of the camera.  BUT, this only happens on the MOTO Z2.  Never once on the Samsung S9.  I looked at logcat when I get the issue, and I see lots of camera errors.  I'll list those below.  I did confirm that dispose and init are getting called, and I used the boilerplate from the camera plugin.  Again, it works perfect on the S9, so I think I'm doing most stuff right.
Is there any way to force/garbage collect camera instances?  I believe when the failure happens on the Moto Z2, the logging shows that the camera (or cameras) are actually still running in the background.
pubspec
Here are my pubspec dependencies (I'm unfortunately not able to run upgrade at the moment!  I get a crash that I have to figure out still on the build with firebase... )
dependencies:
  #quick_actions: ^0.3.2+2
  url_launcher: ^5.1.2
  flutter:
    sdk: flutter
  http: ^0.12.0+2
  shared_preferences: ^0.5.3+4
  auto_size_text: ^2.0.2+1
  image_picker: ^0.6.1+2
  path_provider: ^1.2.0
  video_player: ^0.10.1+6
  camera: ^0.5.3
  firebase_messaging: ^5.1.3
  flutter_sticky_header: "^0.4.0"
  firebase_core: ^0.2.5
  firebase_ml_vision: ^0.8.0
  flutter_camera_ml_vision: ^2.2.1

  # The following adds the Cupertino Icons font to your application.
  # Use with the CupertinoIcons class for iOS style icons.
  #cupertino_icons: ^0.1.2

dev_dependencies:
  flutter_launcher_icons: "^0.7.0"
  flutter_test:
    sdk: flutter

code
Here is some of the code for init/dispose:
  @override
  void initState() {
    super.initState();
    _portraitModeOnly();
    print("audacy camera: call init");
    _initializeCamera();
    _lastBarcode = null;
    _lastBarcodeTime = DateTime.now().millisecondsSinceEpoch;
    _dialogOpen = false;
  }

  @override
  void dispose() {
    super.dispose();
    _camera?.dispose();
    _isDetecting = false;
    _addDeviceSerialController?.dispose();
    _addDeviceNameController?.dispose();
    _clearBarcodeTimer?.cancel();
    _scannerDataTimeoutTimer?.cancel();
    _renameDeviceController?.dispose();
    _enableRotation();
  }

  void _initializeCamera() async {
    if (_camera != null) {
      _isDetecting = false;
      await _camera?.dispose();
    }

    CameraDescription description = await getCamera(CameraLensDirection.back);
    ImageRotation rotation = rotationIntToImageRotation(
      description.sensorOrientation,
    );

    _camera = CameraController(
        description,
        defaultTargetPlatform == TargetPlatform.iOS
            ? ResolutionPreset.low
            : ResolutionPreset.low // needed to allow moto z2 to work, medium fails
        //: ResolutionPreset.medium  // TODO: should we offer medium for phones that can use it?
        );

    await _camera.initialize();
    //_camera.initialize().then((_) {
      if (!mounted) {
        return;
      }
      setState(() {});
    //});

    await _camera.startImageStream((CameraImage image) {
      if (_isDetecting) return;

      _isDetecting = true;

      detect(image, widget.mlVision.textRecognizer().processImage, rotation)
          .then(
        (dynamic result) {
          setState(() {
            _scanResults = result;
          });
          _isDetecting = false;
        },
      ).catchError(
        (_) {
          _isDetecting = false;
        },
      );
    });
  }

flutter doctor -v
[✓] Flutter (Channel unknown, v1.7.8+hotfix.5-pre.1, on Mac OS X 10.14.6 18G87, locale en-US)
    • Flutter version 1.7.8+hotfix.5-pre.1 at /Users/jeltoft/flutter/flutter
    • Framework revision d5c254ab3c (6 weeks ago), 2019-08-12 12:18:28 -0500
    • Engine revision fee001c93f
    • Dart version 2.4.0

[✓] Android toolchain - develop for Android devices (Android SDK version 28.0.3)
    • Android SDK at /Users/jeltoft/Library/Android/sdk
    • Android NDK location not configured (optional; useful for native profiling support)
    • Platform android-28, build-tools 28.0.3
    • Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 1.8.0_202-release-1483-b49-5587405)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 10.2.1)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 10.2.1, Build version 10E1001
    • CocoaPods version 1.7.5

[✓] iOS tools - develop for iOS devices
    • ios-deploy 1.9.4

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 3.5)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin version 39.0.3
    • Dart plugin version 191.8423
    • Java version OpenJDK Runtime Environment (build 1.8.0_202-release-1483-b49-5587405)

[✓] Connected device (2 available)
    • macOS • macOS • darwin-x64     • Mac OS X 10.14.6 18G87
    • web   • web   • web-javascript • Google Chrome 77.0.3865.90

• No issues found!
JustinMac:audacy-flutter jeltoft$

@jdeltoft
The issue at https://github.com/flutter/flutter/issues/41143 has been closed and moved here. Future collaboration on this issue will be done here.

Ok, Im still fighting this issue.

Hi @jdeltoft is this not an issue with the camera module?