remove weight normalization at inference phase

I'm thinking of writing some code snippet to remove weight normalization of pt file, and remove discriminator components to make the checkpoint file smaller.

@seungwonpark  is the output  with or without remove_weight_norm is the same?
I use melgan scripts https://github.com/descriptinc/melgan-neurips and following your way to remove the weight norm parameters. But the output differs from the original outputs.


Improve placeholder text for Output prefix in job creation form

Problem
The create job API takes an output_prefix argument that determines in which directory the output files will be put when the job completes. Currently the TextField placeholder for this UI element reads "Output prefix". We should improve that to give the user more useful information with example. This information should include:

What the output prefix is (where output files will go)
What its format is (relative or absolute path)
Default value
Examples.

@ellisonbg The field is now called "Output path"; I can add helper text to the text field

I thought we were going to call it "Output directory" to emphasize that it isn't a path to a file.

#143 now refers to this field as "Output directory" — I made this change days after I wrote the comment above.


develop front end for Kootenay Lake Exploitation data like for Quesnel

This is unpaid so is really just a task to hold in reserve if nothing else to do

done


Arclight left-click options don't work

Put simply, I cannot change the left-click options for my Arclight. By default, left click drops my Arclight. It doesn't matter if I use CMS to reset or swap the default left-click option, nothing changes. It DOES work for shift+left click, but that's all.
This persists even if I disable CMS, so I recognize it's entirely possible there's some other plugin causing this issue. I just figured this would be the best place to try and sort this out.
Thanks in advance!

if it still happens when the plugin is disabled then it's not this plugin.
The only other plugin I can think of which allows drop swap on arclight is "left click dropper", maybe you have that? I wasn't aware that one overrides CMS though.


Change default install path, and allow override with user/local config

Few changes requested from users:

Default installation engine path should be in the same directory as .ue4versionator config. Users git clone the LFS repository on large drives to accommodate, we shouldn't assume they're okay with large engine installations going to their home directory.
Some users may want a user/local config to override this default path and a few other settings, such as a setting to always enable debugging symbol downloads.

I commented on that commit with an alternative, potentially safer, temporary solution.


Daly BMS and USB permissions documentation

As discussed in #9 , I added two pages to the documentation:

Daly BMS setup guide, with example config
USB permissions guide

Not sure if I put it in the right place in the index - feel free to move it around. I'm also not sure if the writing and the structure has the right style. It's a rough draft which we can further edit.

Some portions of the Daly BMS setup for sure will be duplicated elsewhere, for example the MQTT config section. We could move them elsewhere and use the .. include:: directive.

just merging as its easier to read the result than the source :-)

Thanks for this it look great

Couple of thoughts:
This looks more like a 'tutorial' to me, so i think we should have a Tutorials section (instead of Devices) and perhaps rename the files
perhaps add some comments to the code blocks, describing what and why for the important parts

This looks more like a 'tutorial' to me, so i think we should have a Tutorials section (instead of Devices) and perhaps rename the files

Sure, sounds good. Would you like to keep a Device section for something else?

perhaps add some comments to the code blocks, describing what and why for the important parts

Yes, makes sense. I'll add inline comments like in the Config File Syntax section.

Would you like to keep a Device section for something else?

Possibly - thought not sure for what at this stage


font family of FAQ

I made the font family of all headings on home page similar but due to a merge of  a PR the FAQ's font family is changed

@Vanshiii203 fix it.


fix calling of namespace

1. Why is this change necessary?
Currently the addPremiumAction Method results in an error each time it get's called. The error is as follows:
FastCGI sent in stderr: "PHP message: PHP Fatal error:  Uncaught TypeError: Argument 1 passed to Shopware_Components_Snippet_Manager::createDbNamespace() must be of the type string, null given, called in engine/Shopware/Components/Snippet/Manager.php on line 121 and defined in engine/Shopware/Components/Snippet/Manager.php:372
Stack trace:
#0 engine/Shopware/Components/Snippet/Manager.php(121): Shopware_Components_Snippet_Manager->createDbNamespace(NULL, 1, 1)
#1 engine/Shopware/Controllers/Frontend/Checkout.php(657): Shopware_Components_Snippet_Manager->getNamespace()
#2 engine/Library/Enlight/Controller/Action.php(192): Shopware_Controllers_Frontend_Checkout->addPremiumAction()
#3 /202201" while reading response header from upstream, client: <IP_ADDRESS>, server: domain.com, request: "POST /checkout/addPremium/sTargetAction/confirm HTTP/2.0", upstream: "fastcgi://unix:/var/run/php/php7.3-fpm.sock:", host: "domain.com", referrer: "https://domain.com/checkout"

2. What does this change do, exactly?
The change calls the getNamespace method with the parameter frontend instead of the parameter null which results in the error.
3. Describe each step to reproduce the issue or behaviour.
Add a premium product to the cart within your checkout routine and the error occurs in the logs.
4. Please link to the relevant issues (if any).
n/a
5. Which documentation changes (if any) need to be made because of this PR?
n/a
6. Checklist

[ ] I have written tests and verified that they fail without my change
[ ] I have squashed any insignificant commits
[ ] This change has comments for package types, values, functions, and non-obvious lines of code
[x] I have read the contribution requirements and fulfil them.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.Torben seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


The stackblitz template should be updated to latest version

Is is running version 4 of angularfire2.

@jamesdaniels can you enable firestore on the project?


udp: deprecate envoy.restart_features.udp_read_normalize_addresses

Commit Message: remove envoy.restart_features.udp_read_normalize_addresses and update change log.
Risk Level: low
Testing: N/A
Docs Changes: N/A
Release Notes: Yes
Platform Specific Features: N/A
Fixes #30430

/retest

/retest

@danzh2010 the CI just fixed last night, maybe worth a rebase.

/retest


Add tests that verify the generated HTML

Hi!
In order to make #61 (and any other changes) easier to review (since one can also review the changed expected test output) and reduce the chance of regressions, it would be great to have some tests (currently there are none) :-)

Hi!
In order to make #61 (and any other changes) easier to review (since one can also review the changed expected test output) and reduce the chance of regressions, it would be great to have some tests (currently there are none) :-)

Look this solution https://github.com/glebfeklistov/webpack-html-template, may be solved you problem.


Image tracking AR.js with React stuck on loading screen , please help!

Do you want to request a feature or report a bug?
bug?

What is the current behavior?
it's stuck on loading screen with lots of warning but no error
If the current behavior is a bug, please provide the steps to reproduce.
https://bubleygum.github.io/Logic-pwa8/

Please mention other relevant information such as the browser version, Operating System and Device Name
chrome
What is the expected behavior?
not stuck?
If this is a feature request, what is motivation or use case for changing the behavior?

Hi @bubleygum if you read the last line it's clear that is something wrong with your nft marker path:
Error in loading marker on Worker
code
:
"ERR_BAD_REQUEST"
config
:
{transitional: {…}, adapter: Array(2), transformRequest: Array(1), transformResponse: Array(1), timeout: 0, …}
message
:
"Request failed with status code 404"
name
:
"AxiosError"
request
:
XMLHttpRequest {onreadystatechange: null, readyState: 4, timeout: 0, withCredentials: false, upload: XMLHttpRequestUpload, …}
response
:
{data: ArrayBuffer(9379), status: 404, statusText: '', headers: cA, config: {…}, …}
stack
:
"AxiosError: Request failed with status code 404\n    at blob:https://bubleygum.github.io/20397c4e-ad0f-4a3b-a657-2a5feca880cc:1:752024\n    at XMLHttpRequest.a (blob:https://bubleygum.github.io/20397c4e-ad0f-4a3b-a657-2a5feca880cc:1:752169)"
[[Prototype]]
:
Error

Please also add more informations to the issue.

i resolved it in local, by puting the outside the  but somehow it didn't work on github


Pad Satellite data with zeros

Pull Request
Description
Pad satellite data incase the requestd image size is out of scope.
Fixes #652
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.
Please also list any relevant details for your test configuration

[ ] Yes

If your changes affect data processing, have you plotted any changes? i.e. have you done a quick sanity check?

[ ] Yes

Checklist:

[x] My code follows OCF's coding style guidelines
[x] I have performed a self-review of my own code
[ ] I have made corresponding changes to the documentation
[ ] I have added tests that prove my fix is effective or that my feature works
[x] I have checked my code and corrected any misspellings

Codecov Report

Merging #653 (a12f42e) into main (d21e31b) will increase coverage by 0.06%.
The diff coverage is 83.33%.

@@            Coverage Diff             @@
##             main     #653      +/-   ##
==========================================
+ Coverage   93.21%   93.27%   +0.06%
==========================================
  Files          47       47
  Lines        3168     3168
==========================================
+ Hits         2953     2955       +2
+ Misses        215      213       -2

Impacted Files
Coverage Δ

...et/data_sources/satellite/satellite_data_source.py
92.71% <83.33%> (+1.32%)
:arrow_up:

:mega: Codecov can now indicate which changes are the most critical in Pull Requests. Learn more


Migrate to new VSCode test infrastructure

We should experiment with the new test infra: https://discourse.julialang.org/t/prerelease-of-new-testing-framework-and-test-run-ui-in-vs-code/86355

Based on our discussions on Zulip, I think it is wise to wait a bit more before migrating to this experimental feature. The main issue right now is that the VSCode tests require that all variables are local.


Add ability to press Shift+Up/Down to go up/down by 10px

@happytogether processed this pulled request.  We had to do a few changes so that the grid overlay updated automatically when the values changed.


Channel -> PChan in readme

This is intentional, the example is meant to show an example which fails on the current concurrency

Oh, my bad!


Compatibility with PostCSS 8

Thanks for your PostCSS plugin!
As you probably know, PostCSS 8 was released a few days ago. It would be great if you could make this plugin compatible with the latest version. The creators of the project have even released this migration guide.

@polemius could you please release?

@polemius could you please release?

@Semigradsky Released in 2.0.0

@Semigradsky Released in 2.0.0


Action Buttons in Action header are not properly aligned with fusion theme

Bug Report
Action Buttons in Action header are misaligned in fusion theme.
Description
Right and Left action buttons are not center aligned like title in header. this could be because of missing variable for setting padding of action buttons in action header unlike title.

Steps to Reproduce

Open  Action Header with Fusion Theme

Expected Behavior
Action Buttons should be properly aligned in Action Header.
Possible Solution
By adding Theme variable to set padding value for action buttons( left and right buttons ) .

Reviewing UX needs for Theme. Generally already have the container padding plus title padding-top, which when provided correct theme values may resolve alignment issues.

this was resolved and released as<EMAIL_ADDRESS>


Add Dockerfile to base directory

Signed-off-by: asifdxtreme<EMAIL_ADDRESS>Follow this checklist to help us incorporate your contribution quickly and easily:

[x] Make sure there is a JIRA issue filed for the change (usually before you start working on it).  Trivial changes like typos do not require a JIRA issue.  Your pull request should address just this issue, without pulling in other changes.
[x] Each commit in the pull request should have a meaningful subject line and body.
[x] Format the pull request title like [SCB-XXX] Fixes bug in ApproximateQuantiles, where you replace SCB-XXX with the appropriate JIRA issue.
[x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
 A more thorough check will be performed on your pull request automatically.
[x] If this contribution is large, please file an Apache Individual Contributor License Agreement.

Codecov Report

Merging #315 into master will increase coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #315      +/-   ##
==========================================
+ Coverage   70.33%   70.36%   +0.02%
==========================================
  Files          17       17
  Lines        3452     3452
==========================================
+ Hits         2428     2429       +1
  Misses        853      853
+ Partials      171      170       -1

Impacted Files
Coverage Δ

server/service/tag.go
76.02% <0%> (+0.58%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 29fbda9...dbfbab0. Read the comment docs.


macos: vim.schedule error

sorry, i am new to nvim (using lazy.nvim).
Getting this after trying to run any of the plugin's commands. Any idea on how to get around this issue?
   Error  23:50:59 msg_show.lua_error Error executing vim.schedule lua callback: ...i/.local/share/nvim/lazy/ollama.nvim/lua/ollama/init.lua:173: start_col must be less than end_col
stack traceback:
	[C]: in function 'nvim_buf_get_text'
	...i/.local/share/nvim/lazy/ollama.nvim/lua/ollama/init.lua:173: in function 'parse_prompt'
	...i/.local/share/nvim/lazy/ollama.nvim/lua/ollama/init.lua:249: in function 'callback'
	...i/.local/share/nvim/lazy/ollama.nvim/lua/ollama/init.lua:205: in function 'on_choice'
	...are/nvim/lazy/dressing.nvim/lua/dressing/select/init.lua:78: in function ''
	vim/_editor.lua: in function <vim/_editor.lua:0>

Can you describe the exact steps to reproduce this error? Specifically, I want to know:
Are you using a prompt that includes a $sel (selection) token? How are you running the prompt command? Are you selecting text using visual mode before running the command?
Thanks!

Thanks for the help! In my usage, my key bindings were unselecting the selected tokens when executing the plug-in functions. Works!


Interoute VDC documentation merge request

Dear team,
Please can you review this PR regarding adding this doc for Interoute VDC.
Best
Dong

Added a bunch of comments inline. Overall, is there a way to supply user-data to configure a cluster of machines? This is most of the promise of CoreOS and I'd like to see all of our docs cover this.

Hi Rob,
Thank you very much for your comments. I've made the changes complying with your suggestions. Please revise and let me know if there is more changes to be done.
Regards,
Nikolay

LGTM, thanks.


Microsoft.Web.LibraryManager.Cli & Microsoft.Web.LibraryManager.Biuld not updated

Describe the bug
https://www.nuget.org/packages/Microsoft.Web.LibraryManager.Cli/ not updated with latest changes. Particularly I interested in #753 because it haunting my builds for a long time
To Reproduce
https://www.nuget.org/packages/Microsoft.Web.LibraryManager.Cli/
is still 2.1.175 29a28921bd59084a6906037ddfd55e106ba3ee19
A lot of changes in mainline happened.
Expected behavior
Release of latest version
Additional context
I'm happy to test some kind of beta nuget package.

@phil-allen-msft sorry for spam, but what's status of Microsoft.Web.LibraryManager.Cli/ ?

Sorry for bugspaming, but it's frustrating to contribute fix that I can't use :-)
Do you have a plan about CLI nuget?
@phil-allen-msft @jimmylewis ?

@leotsarev I'm not on the team anymore, just continuing to make contributions for the things I wish I could've done before. 😉 Unfortunately, I can't speed this along, but I'd like to see the new packages too.

@jimmylewis sorry for spaming you then

Sorry for confusion, I need Microsoft.Web.LibraryManager.Build, not Cli, but situation is the same

For me, I´m wondering if Libman still supported outside Visual Studio (CLI & MSBuild task scenarios). It´s constantly breaking down in CI for me. I even contributed a fix, and half year later still I can´t get a working build in my hands.
If it´s not supported, please make a official statement.

Please update the packages on nuget.org. My fix was merged but no new packages have been pushed, yet.


MMM mixins as single sklearn transformer

The sklearn transformers that require state (MaxAbsScaler and StandardScaler) are currently part of the mixins which make it a bit difficult to support new data.
So the mixins will have to be change in order to help the new data use case.
Instead of just incorporating into the current mixins, I suggest relying on sklearn to handle the transformation pass directly as I think it is much clearer about what is happening to the data. The current implementation that relies on mixins and searching methods based on tags which is confusing and, imo, hard to maintain.
Sklearn provides fit and transform API already which is easy to adapt for the current flow. For instance, the X transform
from sklearn.preprocessing import MaxAbsScaler, StandardScaler
from sklearn.compose import ColumnTransformer

channel_cols = ["Facebook", "Google"]
control_cols = ["event_1", "event_2"]
date_col = "date_week"

class FourierTransformer(BaseEstimator, TransformerMixin):
    # To create based on fourier transformations
    def fit(self, X, y=None) -> Self:
        ...
    def transform(self, X) -> pd.DataFrame:
        ...

# This pipeline can be built based on the channel_cols, control_cols, and date_col provided
pipeline = ColumnTransformer([
    ("channel_scaling", MaxAbsScaler(), channel_cols),
    ("control_scaling", StandardScaler(), control_cols),
    ("date_modes", FourierTransformer(n_order=n_order), date_col)
]).set_output(transform="pandas")

# On fit during self.preprocess
pipeline.fit_transform(X_train)

# Should be used on new data. i.e. _data_setter for predict_posterior, etc
pipeline.transform(X_test)

After the fit, pipeline.named_transformers_ in combination with get_feature_names_out() can retrieve the column names required for coordinates
Any thoughts on this? Using sklearn should provide similar feedback to users about missing columns that is currently part of the mixin logic

This would also touch on #402


Error reading single and multi index branchs with pandas

Hi folks, I'm working with a TTree with two kinds of branches, a struct of doubles and single integers. And when a I try to load its data with pandas strange things happens.
The trees is like so.
>>> tree.show()

name                 | typename             | interpretation
---------------------+----------------------+-----------------------------------
ionization           | struct {double x; do | AsDtype("[('x', '>f8'), ('y', '>f8
electron             | struct {double x; do | AsDtype("[('x', '>f8'), ('y', '>f8
ion                  | struct {double x; do | AsDtype("[('x', '>f8'), ('y', '>f8
estatus              | int32_t              | AsDtype('>i4')
istatus              | int32_t              | AsDtype('>i4')

When I load a single branch every thing works fine. I get a MultiIndex DataFrame for the struct and Single Index for the integer branch.
>>> tree.arrays('ion', library='pd')

>>> tree.arrays('istatus', library='pd')

But when I try to load those braches at the same time the index gets messed up and I end up with an empty DataFrame with a bunch of Nan subindexes.
>>> tree.arrays(['ion', 'istatus'], library='pd')

I don't know if this is a bug or I'm doing an illegal operation reading those two kinds of data at the same time. But when a do the same thing with library='np' every thing works fine.

To start, I reproduced the error by creating a similar file:
root [0] auto file = new TFile("issue-75.root", "RECREATE")
(TFile *) @0x7ffe052ea428
root [1] auto tree = new TTree("stuff", "")
(TTree *) @0x7ffe052ea428
root [2] struct stuff {double one; double two;}
root [3] stuff stuffy
(stuff &) @0x7f731d8d9018
root [4] int64_t stuffo
(long) 0
root [5] tree->Branch("stuffy", &stuffy, "one/D:two/D")
(TBranch *) 0x56180c6f9bc0
root [6] tree->Branch("stuffo", &stuffo, "stuffo/L")
(TBranch *) 0x56180c6f9400
root [7] stuffy.one = 1
(double) 1.0000000
root [8] stuffy.two = 2
(double) 2.0000000
root [9] stuffo = 3
(long) 3
root [10] tree->Fill()
(int) 24
root [11] stuffy.one = 1.1
(double) 1.1000000
root [12] stuffy.two = 2.2
(double) 2.2000000
root [13] stuffo = 33
(long) 33
root [14] tree->Fill()
(int) 24
root [15] stuffy.one = 1.2
(double) 1.2000000
root [16] stuffy.two = 2.3
(double) 2.3000000
root [17] stuffo = 333
(long) 333
root [18] tree->Fill()
(int) 24
root [19] tree->Write()
(int) 484
root [20] file->Close()
root [21] .q

And it looks like yours:
>>> import uproot4
>>> f = uproot4.open("issue-75.root")
>>> f["stuff"].show()
name                 | typename             | interpretation
---------------------+----------------------+-----------------------------------
stuffy               | struct {double one;  | AsDtype("[('one', '>f8'), ('two',
stuffo               | int64_t              | AsDtype('>i8')
>>> f["stuff"].arrays()
<Array [{stuffy: {one: 1, ... stuffo: 333}] type='3 * {"stuffy": {"one": float64...'>
>>> f["stuff"].arrays().tolist()
[{'stuffy': {'one': 1.0, 'two': 2.0}, 'stuffo': 3}, {'stuffy': {'one': 1.1, 'two': 2.2}, 'stuffo': 33}, {'stuffy': {'one': 1.2, 'two': 2.3}, 'stuffo': 333}]

and exhibits the error you're seeing:
>>> f["stuff"].arrays(library="pd")
Empty DataFrame
Columns: [(stuffy, one, nan, nan, nan, nan), (stuffy, two, nan, nan, nan, nan), (s, t, u, f, f, o)]
Index: []

Now I can dig into it.

Pulling out individual branches is fine:
% python -c 'import uproot4; f = uproot4.open("issue-75.root"); print(f["stuff/stuffy"].array(library="pd"))'
   one  two
0  1.0  2.0
1  1.1  2.2
2  1.2  2.3
% python -c 'import uproot4; f = uproot4.open("issue-75.root"); print(f["stuff/stuffo"].array(library="pd"))'
0      3
1     33
2    333
dtype: int64

It's just the combination that goes haywire. That's in Pandas.group, rather than Pandas.finalize.

The problem was that some columns have multipart tuple structure (e.g. ("stuffy", "one")) and others didn't (e.g. "stuffo"). Pandas's MultiIndex.from_tuples iterated through the letters of the string, assuming it to be a tuple (i.e. Pandas didn't check). So I added a step that explicitly puts all column names into tuples of the same length if any of them are tuples.
% python -c 'import uproot4; f = uproot4.open("issue-75.root"); print(f["stuff"].arrays(library="pd"))'
  stuffy      stuffo
     one  two    NaN
0    1.0  2.0      3
1    1.1  2.2     33
2    1.2  2.3    333

And now I just realized that I committed that fix directly to master. I thought I was in a branch/PR! (Trying to work on too many things at the same time...)


Integrate OpenSeadragon for image QC

QC requires to zoom in to the details of the images. OpenSeadragon seems to be a good option.
Requires a tiling solution, maybe libvips.

Using https://github.com/Smithsonian/si-deepzoom is generating the necessary tiles without issues. Deployed in 2.8.0.


Fix card page reloads when refocused

Details

The card page reloads when the page gets refocused.
Fixed Issues

$ https://github.com/Expensify/App/issues/48172
PROPOSAL: https://github.com/Expensify/App/issues/48172#issuecomment-2315278589
Tests

Same as QA Steps

[x] Verify that no errors appear in the JS console

Offline tests

Same as QA Steps
QA Steps

Prerequisite: a workspace with Expensify Card enabled
Open Workspace > Expensify Card
Press on the "Issue new card" button
Go back
Verify the card page doesn't reload

[x] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label and/or tagged @Expensify/design so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

https://github.com/user-attachments/assets/048dea2a-6fab-4328-95a9-4d886f28f6ba

Android: mWeb Chrome

https://github.com/user-attachments/assets/5d48d897-3ad4-424d-b645-8ca501a635b0

iOS: Native

https://github.com/user-attachments/assets/e805debb-1c48-4671-a58d-d1d41dbac3f5

iOS: mWeb Safari

https://github.com/user-attachments/assets/0ab777dd-3c98-448c-ac3e-d25a935868c9

MacOS: Chrome / Safari

https://github.com/user-attachments/assets/267d8547-5e80-4980-a85b-4234cc3cb040

MacOS: Desktop

https://github.com/user-attachments/assets/a7f8671f-c028-4dd6-8722-38963e9a8f25

Hmm, probably related with https://github.com/Expensify/App/issues/48835

Asked in Slack here to get this going https://expensify.slack.com/archives/C01GTK53T8Q/p1725999139818019

@aimane-chnaif Done

Should hold on https://github.com/Expensify/App/pull/48959 😄

Done

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to staging by https://github.com/deetergp in version: 9.0.35-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/grgia in version: 9.0.35-7 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


Create "write a new evaluation provider" page

Like Keptn v1, KLT can pull metrics from any external tool.
Developers will naturally want to pull metrics from wherever they see fit. So they'll potentially need to create new evaluation providers (if the community doesn't already have one). Therefore we need a page that describe how to create a new provider.
See instructions here: https://github.com/keptn/lifecycle-toolkit/issues/554#issue-1507524150

duplicate of #1248


[docs] setDate triggerChange inverted behaviour

File Reference
In docs it's implied that onChange events not firing is the default behaviour, but the default behaviour is to fire onChange event, unless false is passed as argument.

This seems to have been changed from previous versions https://github.com/chmln/flatpickr/blob/v2.3.2/src/flatpickr.js#L1259
I would argue that we should set the behavior back to the old way.

I would argue that we should set the behavior back to the old way.

Funny enough, this exact issue bit me during plugin development, when a setDate() from an onChange hook caused stack overflow.
I think the previous value is more sensible.

@chmln I would agree! Should I create an issue for it, or is tracking via this PR okay? Can probably close this PR, if we are going to set it back to the old way. No need to update the docs in that case.

@rwwagner90  I'll just close this PR as soon as I revert the behavior

Thanks @chmln! Looking forward to the next release, so I can close out all the ember-flatpickr issues we encountered from this 😄

@chmln any chance we could get a release to patch this?


MUMUP-1610: Refactor to make widgets on separate page

Layout.html has been split into two files: home-list-view.html and home-widget-view.html. Each calls the new home-header directive, has its own respective controller and its own respective content.

:+1: for the initial split. We could refactor some of the functions that are going to be the same for both controllers to a shared service, but that can be done later.

Merging


Show full tracklist in player bar, too

Hi @Piroxym, Thanks for your updates.
I hadn't even considered the tracklist in the player bar. I completely forgot it was even there!
I've tested it out locally and it looks like it works well, so I'm happy to release these changes.
I'll also add you to the contribs list so you can make changes as you see fit.
Thanks again!

Just publishing your changes now. Should be up in the next hour :rocket:


enable Sonarcloud

This PR finishes add the following functions for CI:

add code quality check on Travis. That is, if too many code reliability problems or Vulnerabilities are introduced, the travis test will fail.

add a code-coverage report on travis. When submit a PR, the code-coverage will be calculated. If the coverage ratio is less than the thresholds, the test will fail.
Currently, the method, branch, and class coverage requirements are all 0%. (I have to set the threshold  as 0, otherwise the test will fail...)

enable sonar code quality analysis on Jenkins just for the master branch.

remove cobertura plugin as the plugin does not support jdk11 and is not maintained anymore.

add JaCoCo for code coverage check, use mvn test -Pcode-coverage to enable it.

Fix that -DskipTests does not work for hadoop module.

TODO: Integrate coveralls.io.

need squash


Component for Sony Bravia TV with Pre-Shared Key

Description:
Sony Bravia TVs of 2014 and later can be connected using a Pre-Shared Key (PSK) instead of the PIN method which is used in the current braviatv component.
Connecting with the TV using the PSK is a bit easier and also more reliable then the PIN method.
Besides that I have added some more features to this component:

It's possible to turn on Android TVs (besides non-Android TVs) using HA.
The source list can be filtered so only the frequently used channels and/or HDMI sources are shown.
When starting the TV via HA, the state card will show a message that the TV has started, but didn't receive any information from the TV yet (it takes the TV about 1 minute to respond with program information after starting, at least for my model).
If you have an amplifier connected to the TV, there is an option which prevents showing the volume slider as this slider only works for the built-in TV speakers.
This component uses a library (original version here) which I have updated to work with the PSK and is hosted on PyPi.

When using the built-in TV tuner:

The program info is shown on second line of state card, this will also show the start and end time of the program.
You can send commands to pause and play the TV program. This is only when you are watching programs with the built-in TV tuner, otherwise it will just pause and play e.g. with the Netflix app.
You can use the next and previous buttons for channel up and down. This is also only when you are watching programs with the built-in TV tuner, otherwise it will be the normal next and previous buttons.

See this topic on the HA forum for more details.
Pull request in home-assistant.github.io with documentation (if applicable): home-assistant/home-assistant.github.io#4694
Example entry for configuration.yaml (if applicable):
media_player:
  - platform: braviatv_psk
    host: <IP_ADDRESS>
    psk: sony
    mac: AA:BB:CC:DD:EE:FF
    amp: True
    android: False
    sourcefilter:
      - ' HD'
      - HDMI

Checklist:

[x] The code change is tested and works locally.

If user exposed functionality or configuration variables are added/changed:

[x] Documentation added/updated in home-assistant.github.io

If the code communicates with devices, web services, or third-party tools:

[x] Local tests with tox run successfully. Your PR cannot be merged unless tests pass
[x] New dependencies have been added to the REQUIREMENTS variable (example).
[x] New dependencies are only imported inside functions that use them (example).
[x] New dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
[x] New files were added to .coveragerc.

If the code does not interact with devices:
- [ ] Local tests with tox run successfully. Your PR cannot be merged unless tests pass
- [ ] Tests have been added to verify that the new code works.

Would it not be possible to implement this into the current braviatv component?

@bakedraccoon The connection towards the TV using PIN and PSK is quite different.
Also the PIN method uses a cookie and a bravia.conf file, which for the PSK is not necessary. So it would be quite a messy library if both connection types need to be supported.
Besides that all models after 2014 which support an external connection seem to have support for PSK.
So the PIN functionallity is only needed for older TVs between 2013 (first models which support external connection) and 2014.
And when I used the bravia component with PIN I had a lot of issues, first with making a proper connection to the TV and once that was achieved, the connection was always lost after a few days.
That makes developing and testing a component which supports both PIN and PSK also a big challenge ;)

Thanks! :crocodile:

This should not have been its own platform. Instead, this should have been part of the other bravia TV integration. The API is literally the same and it seems like a lot of code has been copy pasted. I've decided to pull this integration from release 0.64.
Please submit a new PR that combines PSK support into the original Bravia integration.

Sorry for merging, should the media_player.braviatv platform contain both authentication methods? @gerard33 is this something you can take a look at?

Understood, I will have a look at it.
Although I will need some help from someone with a working Bravia PIN connection to test if the updated platform still works as I couldn't get my TV working properly with it.

Since it's just 2 auth methods in front of the same API, it should indeed be part of braviatv. Would be best if we can get the auth merged upstream instead of having Home Assistant rely on 2 packages.

I have a Bravia which support both pin and psk. Testing both is no issue for me.


Private state update metadata and migration

PR description
• Updated the private state storage with new data structures that aren't backwards compatible.
• Added PrivateStateRootResolver that handles public chain forks and their impact on the private state
• Created migration logic that will process previous private txs and re-create the data in the update 1.4.x format.
• Migration is based on the schema version, defined in the PrivateStateStorage
• Added flag that user needs to "opt-in" to migrate the data
• Remove restriction for "latest" block from priv_call

Superseeded by https://github.com/hyperledger/besu/pull/404


Bug: Video preview thumbnails formatting issue

What happened?
Thanks for the new video preview feature!
I was trying it out and ran into a small formatting issue with the thumbnails.
In Firefox 113.0.1 on Windows 11 the container is a little short:

Chrome 113.0.5672.127 on Windows 11 has a slightly different issue:

Appreciate your work on Zipline!
Version
latest (ghcr.io/diced/zipline or ghcr.io/diced/zipline:latest)
What browser(s) are you seeing the problem on?
Firefox, Chromium-based (Chrome, Edge, Brave, Opera, mobile chrome/chromium based, etc)
Zipline Logs
N/A

Browser Logs
N/A

Additional Info
No response

Has the latest commit fixed your problem?

Yeah looks better now, thanks @TacticalTechJay !
Though, there is a slight issue with a video I have that is square. It renders pretty tall in the grid view:

On the popup view you have to scroll to see the controls at the bottom of the popup:

Here's a link to the file in question: https://files.fletchowns.net/u/2015-08-03.mp4

It's supposed to be like that, as it tries it's best to match the same resolution of the video. It could be a problem I guess with big videos...

Will be closing.


Updating schema titles to sentence case.

Fixes #4142

        "description": "KnowledgeBase Id of your QnA Maker KnowledgeBase.",

Did you want to change these?  Seems like KnowledgeBase should be two words.

Refers to: libraries/Microsoft.Bot.Builder.AI.QnA/Schemas/Microsoft.QnAMakerRecognizer.schema:16 in 983aa1b. [](commit_id = 983aa1b7b1d1729ff851a7f51132df40f8b72226, deletion_comment = False)

        "title": "IsTest",

Programmer speak?

Refers to: libraries/Microsoft.Bot.Builder.AI.QnA/Schemas/Microsoft.QnAMakerRecognizer.schema:72 in 983aa1b. [](commit_id = 983aa1b7b1d1729ff851a7f51132df40f8b72226, deletion_comment = False)

        "title": "Ranker Type",

Not sentence case

Refers to: libraries/Microsoft.Bot.Builder.AI.QnA/Schemas/Microsoft.QnAMakerRecognizer.schema:80 in 983aa1b. [](commit_id = 983aa1b7b1d1729ff851a7f51132df40f8b72226, deletion_comment = False)

        "title": "QnARequestContext",

Sentence case?

Refers to: libraries/Microsoft.Bot.Builder.AI.QnA/Schemas/Microsoft.QnAMakerRecognizer.schema:152 in 983aa1b. [](commit_id = 983aa1b7b1d1729ff851a7f51132df40f8b72226, deletion_comment = False)

        "title": "QnAId",

Sentence?

Refers to: libraries/Microsoft.Bot.Builder.AI.QnA/Schemas/Microsoft.QnAMakerRecognizer.schema:157 in 983aa1b. [](commit_id = 983aa1b7b1d1729ff851a7f51132df40f8b72226, deletion_comment = False)

                "title": "Enum",

Not a great titlle...  Seems like "Change type" would be better.

Refers to: libraries/Microsoft.Bot.Builder.Dialogs.Adaptive/Schemas/Actions/Microsoft.EditArray.schema:22 in 983aa1b. [](commit_id = 983aa1b7b1d1729ff851a7f51132df40f8b72226, deletion_comment = False)

        "title": "ActivityId",

Break into words?

Refers to: libraries/Microsoft.Bot.Builder.Dialogs.Adaptive/Schemas/Actions/Microsoft.GetActivityMembers.schema:23 in 983aa1b. [](commit_id = 983aa1b7b1d1729ff851a7f51132df40f8b72226, deletion_comment = False)

        "title": "Assertions to perform to validate Activity that is sent by the dialog",

Assertions to validate activity

Refers to: libraries/Microsoft.Bot.Builder.Dialogs.Adaptive.Testing/Schemas/Microsoft.Test.AssertReplyActivity.schema:23 in 983aa1b. [](commit_id = 983aa1b7b1d1729ff851a7f51132df40f8b72226, deletion_comment = False)

        "title": "IsTest",

Sorry, I meant switch from programmer speak, i.e. "Use test environment"

In reply to: 708644131 [](ancestors = 708644131)

Refers to: libraries/Microsoft.Bot.Builder.AI.QnA/Schemas/Microsoft.QnAMakerRecognizer.schema:72 in 983aa1b. [](commit_id = 983aa1b7b1d1729ff851a7f51132df40f8b72226, deletion_comment = False)

I should have been more explicit--some of my comments were not meant literally.


Move WebMock into test group

The WebMock gem was also being used in the development group but should only be available for test.

@ikennaokpala thanks for your comment I'll make that PR next


Interpret your Key Vault logs instructions don't work

I was able to run through all the instructions successfully until I got to the "Interpret your Key Vault logs".   The first instruction in this section says to run "Get-AzKeyVault -VaultName 'contosokeyvault'" but this doesn't return anything to the user.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 42e52c78-8986-28fc-f9f0-db87d95fce8c
Version Independent ID: 977f3fac-53ef-4252-06d0-cc437c048316
Content: Azure Key Vault logging
Content Source: articles/key-vault/key-vault-logging.md
Service: key-vault
GitHub Login: @barclayn
Microsoft Alias: barclayn

@lgordoncurtiswork Thanks for your feedback! We will investigate and update as appropriate.

@lgordoncurtiswork I think you are either not connect to the correct tenant or passing incorrect key vault name to the cmdlet.  I have used the cmdlet on PowerShell with the proper keyvault name and it worked fine.

That shows the vault properties and not the log entry, though
Sent from my iPhone
On Jun 21, 2019, at 5:11 PM, SaurabhSharma-MSFT <notifications<EMAIL_ADDRESS>wrote:
@lgordoncurtisworkhttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_lgordoncurtiswork&d=DwMCaQ&c=ilBQI1lupc9Y65XwNblLtw&r=uIbv5JjVKkZJS9yWoErxl1G1jzipBoGDrKMe-JGX4o4&m=jYNMljCFPNex__qrjTHg23UwFs3mSgDbnQIqt6lD1z8&s=_qJWz5f2wcPQtc4F_TdckpjTf8NSLgyFPzv7AwH-r1k&e= I think you are either not connect to the correct tenant or passing incorrect key vault name to the cmdlet. I have used the cmdlet on PowerShell with the proper keyvault name and it worked fine.
[image]https://urldefense.proofpoint.com/v2/url?u=https-3A__user-2Dimages.githubusercontent.com_38112130_59951632-2D637c2e80-2D942e-2D11e9-2D9b1b-2D518611702842.png&d=DwMCaQ&c=ilBQI1lupc9Y65XwNblLtw&r=uIbv5JjVKkZJS9yWoErxl1G1jzipBoGDrKMe-JGX4o4&m=jYNMljCFPNex__qrjTHg23UwFs3mSgDbnQIqt6lD1z8&s=ZaAjcH2y1hJLE_KhTdMWFfMfez8ijKa_922ndZYiq-g&e=
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_MicrosoftDocs_azure-2Ddocs_issues_33750-3Femail-5Fsource-3Dnotifications-26email-5Ftoken-3DAMNK4THHDMFNE7FLJSKGCGDP3U7YFA5CNFSM4H2S6AM2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODYJTBIY-23issuecomment-2D504574115&d=DwMCaQ&c=ilBQI1lupc9Y65XwNblLtw&r=uIbv5JjVKkZJS9yWoErxl1G1jzipBoGDrKMe-JGX4o4&m=jYNMljCFPNex__qrjTHg23UwFs3mSgDbnQIqt6lD1z8&s=bw7oxj6PXnqtMbVru11_1xFYbYYreu-i_J-KyUO3SUg&e=, or mute the threadhttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_notifications_unsubscribe-2Dauth_AMNK4TAYP7M44433EBZ5YODP3U7YFANCNFSM4H2S6AMQ&d=DwMCaQ&c=ilBQI1lupc9Y65XwNblLtw&r=uIbv5JjVKkZJS9yWoErxl1G1jzipBoGDrKMe-JGX4o4&m=jYNMljCFPNex__qrjTHg23UwFs3mSgDbnQIqt6lD1z8&s=rbc8suCTrI53j4KJQca3maYBky2xcoMGe5XViCGk4j4&e=.

@lgordoncurtiswork ok, I got it.  Thanks for the feedback !  I have assigned this issue to content author to investigate and update the document as appropriate.
@barclayn can you please look into this.  It seems document needs an update.

its been 3 months - please update the instructions.

The command to interpret logs was poorly formatted. Opening a storage blob in this way using powershell is not supported. A workaround is to open the blob and use a JSON viewer like Notepad++. For easier to view error messages and troubleshoot failures, please use the new Azure Monitor for Key Vault feature. https://docs.microsoft.com/en-us/azure/azure-monitor/insights/key-vault-insights-overview
This document will be updated to remove the bad command. Changes have been staged and will be publicly visible within 48 hours.

#please-close


Follow-up for initial website version

This adds some adaptations for the initial Wegue website version:

Set Docsify base path
Change website title
Put QGIS2Wegue in a separate menu entry
Add more information about QGIS2Wegue
Hint for currently missing live demo

Please review @JakobMiksch (and anyone else of course)

Looks further good to me!

Thanks for your reviews @justb4 and @JakobMiksch! I added the suggested textual change. I'll merge now.


Facets/Aggregations making the development page crash

Some disease pages crash (e.g. pain) due to the aggregations (left panel) not returning correctly from the API.
query DiseaseFacetsQuery{
  disease(efoId: "EFO_0003843") {
    id
    name
    associatedTargets(aggregationFilters: []) {
      count
      aggregations {
        uniques
      }
    }
  }
}

{
  "data": {
    "disease": {
      "id": "EFO_0003843",
      "name": "pain",
      "associatedTargets": {
        "count": 4,
        "aggregations": null
      }
    }
  }
}

This is likely an issue related to the change of types in the clinical phases.

Issue is still there in the latest update

Fixed most likely due to the cache issue Sangria.


[super-agent-deployment] fixes

Is this a new chart
No
What this PR does / why we need it:
Fixes issues founded during manual testing
Which issue this PR fixes
(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)

fixes rbac missing
fixes CM of sub-agent naming

Special notes for your reviewer:
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

[x] Chart Version bumped
[ ] Variables are documented in the README.md
[x] Title of the PR starts with chart name (e.g. [mychartname])

upgrade path is faling due to previous broken version with the updated nightly image


dvtm damages terminal when resizing

Start dvtm, run in it:
for ((I = 1; I <= 100; ++I)) { echo $I; }; mc

Then make outer terminal slightly bigger, then exit from mc. You will see something like this:
92
93
94
95
96
97
  2016-12-19 18:43:31  ~$
99
100

So, terminal clearly corrupted.
dvtm 0.15. gnome-terminal 3.22.1. debian stretch.

Thanks for the detailed test case, unfortunately I can't reproduce it here. Did you install the dvtm terminfo entry (i.e. does infocmp dvtm show something sensible)? Also did you try it with latest git master?
Maybe some others (e.g. @josuah) can comment whether they observe the same behavior.

dvtm shows big output.
Reproducible with git master (b73aba5c17b10eb9bbfaea6abe0de9802225573d) (with terminfo db entry from this git master).
I will try to be more precise: run that command, then make terminal window bigger vertically. Such that window will become at least some lines bigger (5 lines will be enough). And then exit from mc.
P. S. Similar bugs present in all terminal multuplexers (i. e. in screen and tmux). This stops me from using them all. If you fix this bug you will be first terminal multiplexer without this bug. This would be very good.

I noticed this as well.  And I can reproduce with most programs that have an alternate screen.
Thanks for the notice.

So that we all can look for a fix, the relevant place to search may be around occurence of alternate word in vt.c.
The issue could be somewhere else, but this is where programs tell dvtm that they are a "fullscreen" program and not a command line one.

The cursor position while leaving the fullscreen program seems to be at the position of the last prompt, so this works.  Maybe the screen only needs to be cleaned.  cleaning the screen before to redraw the previous one could do the job.
Adding some function to clear the client at the beginning of draw(Client *client)?


ed25519_sk keys support (FIDO2 auth)

Is your feature request related to a problem? Please describe.
I can't use my FIDO2 key when logging in with ed25519_sk key.
Describe the solution you'd like
OpenSSH natively supports FIDO2 authorization since version 8.2, so its support in ConnectBot should be obvious.

I would also love this feature!

Would very much like this as well.

There is even a (stale) fork, which adds this: https://github.com/cotechde/termbot
Would be great to see it implemented here.

It would be great to see this features. The above mentioned fork is staled since around 3-4 years.
One problem with FIDO2 is that only recently Android received support for CTAP2 (FIDO2 PIN support) but only on USB connections. So this would not yet work with Android+Fido2+PIN over NFC.
Perhaps a more modular architecture would be better: a separate ssh agent and ConnectBot using it.

One problem with FIDO2 is that only recently Android received support for CTAP2 (FIDO2 PIN support) but only on USB connections. So this would not yet work with Android+Fido2+PIN over NFC.

It seems no issue on my devices. I use FIDO2+PIN+NFC around one mouth since microG merged FIDO PIN support in v<IP_ADDRESS>913.


webview onNavigationStateChange returns url of previous page.

React native Webview prop onNavigationStateChange returns url of previous page instead of the current page in android.(i have not yet checked for iphone). Please see into it.

Environment
Environment:
OS: Windows 7
Node: 8.9.4
Yarn: 1.3.2
npm: 5.6.0
Watchman: Not Found
Xcode: N/A
Android Studio: Not Found

Packages: (wanted => installed)
react: 16.3.0 => 16.3.0
react-native: ~0.54.1 => 0.54.4
2. Steps to Reproduce
Create a simple webview for android app and try to navigate in it. Suppose browse youtube and the url you get is for the previous video and not for the current. Url for webview will be https://m.youtube.com.
I go to the video with url https://m.youtube.com/watch?v=1pIfvOOU1iw by clicking on a video. I tried to print url in body of an alert by firstly putting in a state variable .
3.Expected Behavior
The url to be https://m.youtube.com/watch?v=1pIfvOOU1iw
4.Actual Behavior
The url is of previous page i.e https://m.youtube.com.


Layout updated to support bigger clear icon and end icons to have 48d…

I was going to work on password visibility toggle, but before we do that we need to increase touch area of icons and change the layout.
In the current version, icons are 24dp and they are set to align with EditText. That's good to align them, however, when we use a larger icon, the icon is cut from the top. I don't know if it is a bug in the Android framework.
I replaced the RelativeLayout with a FrameLayout and placed icons on top of that. After that I calculate width of (endIcon/clearIcon or both) and put a fake drawableRight to EditText. This is how TextInputLayout works.
There are some major changes but it looks similar to what we have and touch are is better now. Let me know if you have any concerns.

LGTM.
Some dimensions can be improved, but I'll do it myself :)

Have made a new release 1,.4.4 just now.
I was planning to release when I finish the password toggle, but it turns out I didn't really have time to do that. 😅


chatbot

Chatbot for User Interaction and Issue Resolution
Implement an interactive chatbot that can assist users in navigating the platform, answering FAQs, and automating common queries. This would streamline user support, enhance engagement, and reduce the response time for resolving issues or answering repetitive questions. The chatbot can also suggest relevant documentation and direct users to specific solutions.
Knowledge base integration: Adding an easily searchable FAQ section. However, this lacks the real-time interaction and personalization that a chatbot provides.
Ticketing system: Although effective, it increases the overhead for simple issues and delays quick answers.
The chatbot can be integrated with APIs to pull real-time data and automate some tasks. It could be enhanced with NLP capabilities for better contextual understanding. It can also log user conversations to analyze common issues and improve the platform's documentation.

please assign me this task!

please assign me this issue


Request support for

Log message
This error originated from a custom integration.

Logger: custom_components.tuya_local.config_flow
Source: custom_components/tuya_local/config_flow.py:299
integration: Tuya Local (documentation, issues)
First occurred: December 16, 2024 at 9:24:05 PM (2 occurrences)
Last logged: 12:11:18 AM

Could not find device: bfb2baa1900038ce9essbx
Could not find device: bf0c06aab410ea4201ry5a

Product ID
bf0c06aab410ea4201ry5a
Product Name
Product Name " smart door lock" Device ID bf0c06aab410ea4201ry5a Product Category jtmspro
DPS information
TYSH Smart Door Lock Fingerprint Digital Wifi Lock Smart Lock With Camera Monitor Send Photo To Phone
https://www.alibaba.com/product-detail/TYSH-Smart-Door-Lock-Fingerprint-Digital_1600868022693.html?spm=a2756.order-detail-ta-ta-b.0.0.2aa7f19co6YXmL

finger print unlock
=====================

code	"1"
deviceId	"bf0c06aab410ea4201ry5a"

password unlock
------------------------
code	"2"
deviceId	"bf0c06aab410ea4201ry5a"

Temporally password unlock
======================
code	"3"
deviceId	"bf0c06aab410ea4201ry5a"

Dynamic password unlock
----------------------

code	"4"
deviceId	"bf0c06aab410ea4201ry5a"

card unlock
-------------
code	"5"
deviceId	"bf0c06aab410ea4201ry5a"

face recognition unlock
------------------------
code	"6"
deviceId

key unlock
------------
code	"7"
deviceId	"bf0c06aab410ea4201ry5a"

alarm lock
------------
code	"7"
deviceId	"bf0c06aab410ea4201ry5a"

*******************************************************
Additional Information
*******************************************************

{
  "result": {
    "active_time":<PHONE_NUMBER>,
    "bind_space_id": "187163193",
    "category": "jtmspro",
    "create_time":<PHONE_NUMBER>,
    "custom_name": "Theones Room inside door",
    "icon": "smart/icon/ay1551882312134CvLDd/295ce8b01388ed6e51615756bcf12362.png",
    "id": "bf0c06aab410ea4201ry5a",
    "ip": "<IP_ADDRESS>",
    "is_online": true,
    "lat": "",
    "local_key": "H3P;W:@OE3?[r<2S",
    "lon": "",
    "model": "",
    "name": "SmartLock 2",
    "product_id": "ahmdz1nlwwju24tm",
    "product_name": "智能门锁",
    "sub": false,
    "time_zone": "+00:00",
    "update_time":<PHONE_NUMBER>,
    "uuid": "b531278914a6ff6b"
  },
  "success": true,
  "t":<PHONE_NUMBER>608,
  "tid": "1da7d206bc0a11efaf84fe4c51833753"
}

Information about how the device functions
The device is a smart door lock and has about 7 features which have already listed.

Support cannot be added for devices that cannot be connected to.


Engine Setup method creation

Change Log:
[ ] Added Engine class for setup method
[ ] Added Async class for AlloyDBPG
[ ] Added first test for engine setup
[ ] Started developing alist method

This PR needs to go to the AlloyDB repo https://github.com/googleapis/langchain-google-alloydb-pg-python

https://github.com/googleapis/langchain-google-alloydb-pg-python/pull/282


Fix bad URLs in HandEyeCalibration readme

Fixed these two issues:
Absolute URLs in readme - https://github.com/zivid/zivid-cpp-samples/issues/116
Bad links in readme - https://github.com/zivid/zivid-cpp-samples/issues/133

I was not able to link ZividHandEyeCalibration to a local file, the CLI executable file we have in Zivid/bin. So I linked it to link to our KB article (https://zivid.atlassian.net/wiki/spaces/ZividKB/pages/96469274/CLI+tool+for+Hand-Eye+calibration) instead. I think this makes more sense as we dont have that .exe in Github.

I checked and the links works for me, could you double check that you are on the right branch when checking the links. When you click on an PR, GitHub sometimes changes your branch back to the master brach:)

Added @knatten to the review since he has reported the issue.

Fixed changes, ready for next round

In zivid-sdk, we try to avoid force pushing during review. Instead we add fixup commits, and then squash and rebase when the review is done. This makes it much easier for reviewers to keep track of what changed since last time they reviewed, and if they have the branch checked out locally they won't have to force reset it. I'm just a guest in this repository, but I suggest you adopt the same workflow. As a reviewer I would certainly appreciate it. What do you think?

Just one minor change needed

Done, ready for next round

Looks good to me. You can rebase and merge.


Shoes try on feet

Hey Team I have successfully built 3d shoe object detection. now please anyone tell me how I can add a 3d shoe mask to my feet? I have the shoe obj file. and I replace it with the current obj file(module.obj.uuu) that is in the sneaker asset folder. but not working.  same as issue #1453. @ahmadyan,

Hi @honeykinng345, We are already tracking this issue here https://github.com/google/mediapipe/issues/3610. Could you post your comment there in #3610 and close this issue as a duplicate.
Thank you!

issues closed because of duplication of #3610

Hi @honeykinng345, Could you please post your comment on the above mentioned issue. We are following up issues with the internal team and revert back if any update.
Thank you!

Hi @honeykinng345, Could you please post your comment on the above mentioned issue. We are following up issues with the internal team and will revert back if any update on this request. Thank you!

@kuaashish  already posted ...

Hi @honeykinng345,
Closing this issue as duplicate and following up with issue #3610. Thank you!


Fix for tool binary paths

This patch fixes an issue where the go tools gocyclo and golint are not being executed using the full paths.

Current coverage is 36.44%

Merging #13 into master will not affect coverage as of cb66a77

@@            master     #13   diff @@
======================================
  Files            7       7
  Stmts          354     354
  Branches        12      12
  Methods          0       0
======================================
  Hit            129     129
  Partial         12      12
  Missed         213     213

Review entire Coverage Diff as of cb66a77

Powered by Codecov. Updated on successful CI builds.


stm32mp1:eula: Fix the variable name

It was converted by mistake, in this case, it is a variable and not a
override.
Signed-off-by: Daiane Angolini<EMAIL_ADDRESS>

Docs for<PHONE_NUMBER>0919f7d059c3b1e6a75a91ba5e6cf9 are browsable at: https://ci.foundries.io/projects/fio-docs/builds/1419/docs/artifacts/html/index.html


Not able to send a remote URL instead of file from input

Hey there, I'm trying to pass a remote URL for cloudinary instead of a file which seems to be an option: http://cloudinary.com/documentation/upload_images#remote_upload
I'm getting this error:
Uncaught TypeError: Failed to execute 'readAsDataURL' on 'FileReader': parameter 1 is not of type 'Blob'.
Any advice?
Thanks

You can only do that with server side code. That means you'll have to leverage their NodeJS API on the server to make it work.

Can you point us to the right direction to achieve this kind of things, so it works with files or url's or even data64 characters, thanks!

I need to add URL support, PR's are appreciated ^_^


Fix ImageTextEx and ImageDrawTextEx scaling

Already explained in #2755, should close it.
Also it would be nice to specify a scaling method 'cause not all fonts look great when using cubic interpolation, but that can be easily done manually by drawing text with "native" font size first and then using ImageResizeNN if desired

oh wow, I probably should've created another fork for that or just didn't sync it with upstream
that looks scary

hopefully it's not big of a deal

@hatkidchan Hey! Thanks for the detailed issue review and the fix provided! :D

no problem!
sometimes it feels like raylib lacks some deep testing of obscure features like that though-
glad to be able to help with at least some of them

@hatkidchan You are right, raylib lacks some deep testing of features but I'm developing alone and I can't do everything in the way I'd like to, sometimes new features are not properly tested or just tested on Windows platform... Hopefully community can help with that...


Select options remain open when navigating away from settings editor

Issue Type: Bug

Open the settings editor
Focus a setting that has a dropdown so that the options are displayed
Switch editors

The dropdown remains open:

Not sure if this is an issue with the select itself, or the settings editor.
VS Code version: Code - Insiders 1.30.0-insider (9e62a05bc7c5dbb74d165e06f7c3a5f3c7549096, 2018-12-03T06:12:08.874Z)
OS version: Darwin x64 18.0.0

@roblourens
Ha, I was afraid this would occur.
@joaomoreno set the _sticky flag that Jackson added for debugging.  I was going to ask him if this was intentional.  @joaomoreno was his left as 'true' by mistake when you're doing some mouse work for list?
I will verify if this is the case and fix unless requested otherwise...

Good catch, it looks like a mistake, I'll revert it so it can get into tomorrow's build. Let me know if that's not the case @joaomoreno.

Fixed with, #64271

@roblourens - you have to merge, I'm not allowed :-(


⚠ Bofrost.fr has degraded performance

In 80bdd83, Bofrost.fr (https://www.bofrost.fr) experienced degraded performance:

HTTP code: 200
Response time: 994 ms

Resolved: Bofrost.fr performance has improved in 89c2532.


Create Unit test to assert properties observed by computed property #811

Reviewed 1 of 1 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved, some commit checks failed.

Comments from the review on Reviewable.io


strange breakup of EventHub "how-to guides" vs. separate send and receive event sections

Just to throw it out there because it threw me off.
The "How-to" guides for Event hubs have .NET Framework, Go and Python.
The completely separate Send events and Receive events in the left hand tree menu, have .NET Standard, Java and Apache Storm.
Shouldn't these be condensed into one set of menus?
i.e.
-Receive Events
--.NET Standard
--.NET Framework
--Java
--Go
--Apache Storm
--Python
?
Because it threw me off as I was trying to use the .NET Framework example on .NET Core and wondering why the libraries didn't match. (The fact that .NET Core has a completely different namespaced library is a different world of lolwtf). But because of how the menu was structured....I did not think to expand the second level of "Receive events".

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: ffc27b98-907f-c57f-6db5-155d70b59868
Version Independent ID: 6b7a3689-8eed-2234-be23-6ae0fe73db20
Content: Receive events from Azure Event Hubs using the .NET Framework
Content Source: articles/event-hubs/event-hubs-dotnet-framework-getstarted-receive-eph.md
Service: event-hubs
GitHub Login: @ShubhaVijayasarathy
Microsoft Alias: shvija

@marekr
Thanks for the Comment. We are actively investigating and will get back to you soon.

@ShubhaVijayasarathy we have a feedback for an documentation enhancement here, could you take a look?


TensorArray.gather crash with Segmentation fault

Click to expand!
Issue Type
Bug
Have you reproduced the bug with TF nightly?
Yes
Source
source
Tensorflow Version
2.13.0-dev20230208
Custom Code
Yes
OS Platform and Distribution
No response
Mobile device
No response
Python version
No response
Bazel version
No response
GCC/Compiler version
No response
CUDA/cuDNN version
No response
GPU model and memory
No response
Current Behaviour?
TensorArray.gather crash with Segmentation fault

Standalone code to reproduce the issue
import tensorflow as tf
import numpy as np

tf = tf.compat.v2
tf.enable_v2_behavior()

@tf.function
def foo():
    ta = tf.TensorArray(dtype=tf.int32, size=0, dynamic_size=True)
    ta.write(0, tf.constant(0))
    return ta.gather([0])

foo()

Relevant log output
Segmentation fault (core dumped)

The enable_v2_behavior() function was introduced in TensorFlow 2.0 and is no longer needed in TensorFlow 2.0 and later versions.

enable_v2_behavior () is called or # 2) the TF2_BEHAVIOR=1 environment variable is set.

Hi @trickiwoo, I was able to replicate the issue using  TF-nightly(2.13.0-dev20230208). Please find the screenshot below.

Thank you!

Thanks @pat749 and @Ruparani777 for pointing out the issue! I checked and found that enable_v2_behavior is not needed to trigger this bug, here is the minimized code that triggers Segmentation fault:
import tensorflow as tf

@tf.function
def foo():
    ta = tf.TensorArray(dtype=tf.int32, size=0, dynamic_size=True)
    ta.write(0, tf.constant(0))
    return ta.gather([0])

foo()

Output:
Segmentation fault (core dumped)

Use a different version of the library: If the segmentation fault is caused by a bug in a library, then using a different version of the library can sometimes help to remove the error.


Documentation of property-style methods isn't inherited

Search terms
property, inherit
Expected Behavior
The documentation of property-style methods in interfaces should be inherited in the same way that shorthand-syntax methods work.
export interface Bar {
	/** Some shorthand syntax doc. */
	bar(): number;
	/** Some property style doc. */
	baz: () => number;
}

export class Foo implements Bar {
	bar(): number {
		return 0;
	}
	baz(): number {
		return 0;
	}
}

Actual Behavior
The documentation is attributed to the function type instead of the property and therefore not inherited.
This broke going from version v0.20.37 to v0.21.0.

Result in v0.20.37
Doc of Bar:

Doc of Foo:

Result in v0.21.0
Doc of Bar:

Doc of Foo:

Steps to reproduce the bug
Here is a minimal repo reproducing the bug.
Just run npm ci && npm run docs to generate the docs folder.
Environment

Typedoc version: v0.21.x
TypeScript version: 4.2.4
Node.js version: v14.15.4
OS: Win10

I like your bugs :) Very helpful to have an tiny reproduction!


wrap line not work

VSCode Version: Code 1.15.1 (41abd21afdf7424c89319ee7cb0445cc6f376959, 2017-08-16T18:07:25.676Z)
OS Version: Windows_NT x64 10.0.14393
Extensions: none

Steps to Reproduce:

push Alt+z wrap line no work

@yanite I don't see the binding for Alt+[ in keybindings.json.
Seems like it's been replaced with ctrl+shift+[
The only assignments related to [ are in the picture below.

I guess you can reassign the key-mapping to alt+[ if you got used to it.

@yanite Line wrapping is disabled in the following circumstances:

when inside a diff editor
when opening a very large file
when having a screen reader attached (visible in the status bar with "Screen Reader Detected" which replaces the current line,col information)

Which one of these cases are you running into? Or is there another case ?


Implement sessions

Session is group of continuous activity with breaks less then given time.
E.g. We can classify rain event as a group of rainfalls with periods without rain less then 6h.

Done.


Add tags property to message interaction mixin

The tags property is an array of strings that contains the tags that have been applied to the link being interacted with.

@ctrubian : Approving on a pretext as this is a temporary fix till we start ingesting the url-id and corresponding tag in some lookup table in AEP.
Ideally we should also gets this reviewed this with UPS team as we are now passing the tags with the url in de-normalize way and potentially bloating the ExpEvents which are also getting saved in UPS cosmo.  Earlier they have recommend ingesting attributes in normalize fashion.

@sawhneyh I'll ask Raghav to take a look, but there is no plan to ever store tracker data in the data lake and have a lookup table whose key is the link ID.  Once a tag management system exists they can provide lookup tables, but I'm sure they'll want to key them off IDs they manage.  So whether the event contains a string that's the value, or a string that's the ID there is no difference in data size.  Given that the ID will likely be a UUID the event is likely some bytes smaller right now than it will be in the future.

@cmathis please review

Hi @ctrubian

I'll ask Raghav to take a look, but there is no plan to ever store tracker data in the data lake and have a lookup table whose key is the link ID.

Any reason why we are not evaluating this route, as with this we can avoid sending the tag-id or tag name with each tracking event.
Though we don't have any concern with sending the tags with an event, but this is an optimization which we shouldn't discard.

So whether the event contains a string that's the value, or a string that's the ID there is no difference in data size. Given that the ID will likely be a UUID the event is likely some bytes smaller right now than it will be in the future.

I agree, sending tag-id or tag-name is almost same. The way to avoid sending id/name is by only having a lookup table with 1.

key as  url-id
Value as  corresponding tags associated with that url.

@ctrubian - Please let us know when this is ready to go into registry

@prabhum2 We're ready.  Thanks


sum all numbers not accepting my recursive solution

Challenge Sum All Numbers in a Range has an issue.
User Agent is: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:50.0) Gecko/20100101 Firefox/50.0.
Please describe how to reproduce this issue, and include links to screenshots if possible.
My code:
var sum;
var current;
function sumAll(arr) {
  sum = 0;
  current = 0;
  var min = Math.min(arr[0], arr[1]);
  var max = Math.max(arr[0], arr[1]);
  var current = min;
  console.log("summing");
  return sumRecurse(min, max);
}

function sumRecurse(current, max){
  if (current<=max){
    sum+=current;

    current++;
    sumRecurse(current, max);
  }
  else {
    console.log(sum);
    return sum;
  }

}
sumAll([1, 4]);

For some reason the above solution is not being accepted.  On outside consoles it behaves as expected, but FCC's console calls the parent function repeatedly for some reason...
summing  sum-all-numbers-in-a-range:9299:3
10  sum-all-numbers-in-a-range:9312:5
summing  sum-all-numbers-in-a-range:9:3
20  sum-all-numbers-in-a-range:22:5
summing  sum-all-numbers-in-a-range:10:3
10  sum-all-numbers-in-a-range:23:5
summing  sum-all-numbers-in-a-range:9299:3
10  sum-all-numbers-in-a-range:9312:5
summing  sum-all-numbers-in-a-range:9299:3
10  sum-all-numbers-in-a-range:9312:5
summing  sum-all-numbers-in-a-range:9299:3
10  sum-all-numbers-in-a-range:9312:5
summing  sum-all-numbers-in-a-range:9299:3
45  sum-all-numbers-in-a-range:9312:5
summing  sum-all-numbers-in-a-range:9299:3
45  sum-all-numbers-in-a-range:9312:5
summing  sum-all-numbers-in-a-range:9299:3
10  sum-all-numbers-in-a-range:9312:5
summing  sum-all-numbers-in-a-range:9299:3
10  sum-all-numbers-in-a-range:9312:5
summing  sum-all-numbers-in-a-range:9299:3
10  sum-all-numbers-in-a-range:9312:5
summing  sum-all-numbers-in-a-range:9299:3
45  sum-all-numbers-in-a-range:9312:5
summing  sum-all-numbers-in-a-range:9299:3
45  sum-all-numbers-in-a-range:9312:5
summing  sum-all-numbers-in-a-range:9299:3
10  sum-all-numbers-in-a-range:9312:5
summing  sum-all-numbers-in-a-range:10:3
10  sum-all-numbers-in-a-range:23:5
summing  sum-all-numbers-in-a-range:9299:3
10  sum-all-numbers-in-a-range:9312:5
summing  sum-all-numbers-in-a-range:9299:3
10  sum-all-numbers-in-a-range:9312:5
summing  sum-all-numbers-in-a-range:9299:3
10  sum-all-numbers-in-a-range:9312:5
summing  sum-all-numbers-in-a-range:9299:3
45  sum-all-numbers-in-a-range:9312:5
summing  sum-all-numbers-in-a-range:9299:3
45  sum-all-numbers-in-a-range:9312:5

compared to outside console:
sumAll([1, 4]);
link
"summing"
10

Nevermind, I realized my problem -- I was defining sum and count outside of the scope of the main function and the old values were being used for each new call of the function that FCC tests.


Feature: Move from pascal-case package to change-case package

Is your feature request related to a problem? Please describe.
https://www.npmjs.com/package/pascal-case
This package has been deprecated. The author suggested moving to the change-case package
Describe the solution you'd like

Describe alternatives you've considered
N/A

Additional context
N/A

good catch. The only problem with moving to change-case is, that is esm only.
However, since we want to support both commonjs and esm modules, this is unfortunately not possible.


Ability to configure text scaling

Background
Users can increase text size from their device settings. Here's the same page, and how it looks as user changes device setting.

Requirements
As an app developer, I want to control text scaling in my app.
In priority order, we should support the following:

As we do today, by default, respect user choice and adjust text size based on user preferences.
Provide ability to disable text scaling globally.

# in theme
Text:
  textScaling: false

Provide ability to set min and max scaling factors globally

# in theme
Text:
  maxScaleFactor: 1.2 # so that the text never increases more than 20%, even if user settings indicate to increase it by 50%
  minScaleFactor: .8 # so that the text never decreases more than 20%, even if user settings indicate to decrease it by 50%

Provide ability to override the global setting at widget level. E.g. I want to allow scaling across the accept except for a specific widget.

Flutter reference
https://api.flutter.dev/flutter/painting/TextScaler-class.html

completed.


removing excess item entries

this issue is for items being removed for 1.19 MC release

discovered tulips are listed twice for each color (before merging separated entries)
orangetulip
tulip_orange
removed the incorrect entry (tulip_orange) as it is not in the itemdb in game


Side faces not recognized properly

When I saved all descriptors of my all photos galley. with the selfie it is not recognize side faces, false result comes if we pick more than 0.55 distance.

that is normal and expected. look at face confidence to start with before blindly comparing embeddings. if confidence is low, there is no point of running compare that will then return bad results.


Dynamically adjust figure axes with range slider

Is it possible to dynamically update the axes of a plot using a slider widget? Currently I'm using a PanZoom for navigating the plot but being able to more fine-grained control over the exact range would be excellent. Below is a snippet of roughly what I mean:
def updateXAxis(values):
    #Update X-axis min/max value here

x_sc = LinearScale(min=float(x_data[0]))
y_sc = LinearScale()

ax_x = Axis(label='X', scale=x_sc, grid_lines='solid', tick_format='0f')
ax_y = Axis(label='Y', scale=y_sc, orientation='vertical', tick_format='0.2f')

m_fig = dict(left=100, top=50, bottom=50, right=100)
fig = Figure(axes=[ax_x, ax_y], marks=data_values, fig_margin=m_fig)

x_range = IntRangeSlider(value=[0,1000],
                        min=0,
                        max=2000,
                        step=1,
                        description="X Axis",
                        disabled=False,
                        continuous_update=False,
                        orientation='horizontal',
                        readout=True)
interactive(updateXAxis, values=x_range)
fig

This is super useful, thank you!


Q: Fader scaling toggling don't preserve values

Hi,
I have a script which uses SWS functions to toggle Fader Scaling for selected track envelopes
Script: X-Raym_Toggle envelope fader scaling.lua
Extra basic, just a boolean to toggle.
It used to work but now the values are completly messed up:

See how +3 values become something like +30... ?
It works before:

What have change ?
Maybe on REAPER side ?

In current official SWS (v2.10.0 #1) there's a bug related to fader scaling, when using BR_Envelope functions.
In cfillion's build this is fixed, does is fix for you also with his version?
https://cfillion.ca/files/sws/fix-brenvelope-scaling/

@nofishonfriday ok this works !
Hmmm... Do we plan any release soon ? :p

Yes, a new SWS release is (over)due imo.
Would be nice to get Justin's fixes in and released (along with the other stuff here) when the Reaper TCP / MCP overhaul goes official otherwise I'll expect a few reports about broken scripts. :D
I just wanted to ping cfillion on slack about it, but he has a 'vacationing' sign so I respect that..


added info about the website under the showcase in index.html

[x] This user story is developed on branch 05-info.
[x] Add info about the website under the showcase.
[x] - [ ] This user story is developed on branch 05-info.
[x] Add info style in style.css.
[x] This branch is merged to master branch after completion.

link your issues to this pr


Error when adding a tenant

When i click "test tenant connection", i get the following error:
Unable to connect to Azure tenantIt may be expected if w3wp process of central admin has intentionally no access to Azure.One or more errors occurred.Error detail: Insufficient privileges to complete the operation.
When i look at the error logs, I can see that error:
[AzureCP] Unexpected error while testing connectivity: System.Data.Services.Client.DataServiceQueryException: An error occurred while processing this request., Callstack:
at System.Data.Services.Client.QueryResult.EndExecuteQuery[TElement](Object source, String method, IAsyncResult asyncResult)
at System.Data.Services.Client.DataServiceRequest.EndExecute[TElement](Object source, DataServiceContext context, String method, IAsyncResult asyncResult)
at System.Data.Services.Client.DataServiceQuery1.EndExecute(IAsyncResult asyncResult)      at Microsoft.Azure.ActiveDirectory.GraphClient.Extensions.DataServiceContextWrapper.<>c__DisplayClass4c2.b__4a(IAsyncResult r)
at System.Threading.Tasks.TaskFactory1.FromAsyncCoreLogic(IAsyncResult iar, Func2 endFunction, Action1 endAction, Task1 promise, Boolean requiresSynchronization)  --- End of stack trace from previous location where exception was thrown ---
at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
at System.Runtime.CompilerServices.TaskAwaiter1.GetResult()      at Microsoft.Azure.ActiveDirectory.GraphClient.Extensions.DataServiceContextWrapper.<ExecuteAsync>d__4e2.MoveNext()
What could be my issue ?

Make sure you have actually granted the saved permissions in Azure Portal, by clicking the Grant Permissions button in the blade prior to the Enable Access blade. The portal is a bit confusing in that it first asks you to save permissions but you then also have to grant the saved permissions.


How to search strings that are made with JSON.stringify?

Hi.
I am making a web log viewer using lunr.js and I have the string like this:
07.10.2015 03:41:45 [DEBUG] send: connId: b959a0 msg: {"error":null,"id":"9046d19aaec1ef2fa6546a05d89f4e99%%144420370560637","result":{}}
07.10.2015 03:41:47 [DEBUG] on_message: connId: e9ab70 msg: {"jsonrpc":"2.0","method":"Ping","id":"771874b2-b4d3-4f74-96f3-d6640077b26d","params":{}}
07.10.2015 03:41:47 [DEBUG] send: connId: e9ab70 msg: {"error":null,"id":"771874b2-b4d3-4f74-96f3-d6640077b26d","result":"Pong"}

At the moment, when I just add them to index as a string, the search does not return anything that is inside JSON {}.
What is a good way to search it too?
I see two options here:

Split JSON from string, parse it and add it into a separate field of the index.
Redefine tokenizer (which is very dark topic for me).

Any comments on this?

Went along with the option 1.
Something like this:
// el - is a main string to search

var add = {
	id: Date.now() + Math.ceil(Math.random()*1000),
	body: el
};

// split the json piece (which is msg: {})
var json = (/msg: ({.*})/).exec(el);

if (json.length > 1) {
	// replacing " to enable search
	add.json = json[1].replace(/"/g, " ");
}

this.logIndex.add(add);


[zk-token-sdk] Expose ElGamalKeypair and ElGamalPubkey as wasm

Problem
Summary of Changes
Fixes #

Replaced with https://github.com/anza-xyz/agave/pull/2996.


build error

can't be build successfully.

What is the error message?

From another computer, it can be build successfully. Thanks.


[#1239] Remote merge on the shuffle server side.

draft pr for #1239
For now, the Isolated classloader is not implemented yet. In order to run properly, I added some framework dependencies to the shuffle server. Please ignore this.

@jerqi @zuston Can you please review this draft pr or proposal ?

Does code add here come from Apache Spark?

Does code add here come from Apache Spark?

No, I developed it myself.

Thanks for proposing this. Looking forward this, really great work!
I have a question that I remember spark will sort the data using the sortExec in dataframe api. That means the sort will not ocurr on the reader process. @advancedxy may have a good thought about this.

Does code add here come from Apache Spark?

Detailed design could be found on #1239, the initial motivation is to reduce the disk usage of spill, especially on the K8s. And having this, we also can speed up the whole shuffle.

For this particular feature, I think MR/Tez would benefit from that substantially(to be frankly, I had developed a similar shuffle system back ~6-7 years ago). The spark integration is less exciting though.

But if we could introduce the extra plan to optimize the sortMergeJoin from sortExec + exchange to uniffleSortedExchangeExec that will benefit from this feature. Is this possible?

For this particular feature, I think MR/Tez would benefit from that substantially(to be frankly, I had developed a similar shuffle system back ~6-7 years ago). The spark integration is less exciting though.

But if we could introduce the extra plan to optimize the sortMergeJoin from sortExec + exchange to uniffleSortedExchangeExec that will benefit from this feature. Is this possible?

emmm, maybe in your own forked Spark. For open source Spark, it might be possible to inject a strategy rule via SparkSQLExtension.injectQueryPostPlannerStrategyRule to replace SortExec. However, when it comes to Spark's internal EnsureRequirements, you have to touch/modify the internal logic.

Yes, this is acceptable if having performance gain. And I think the extra strategy rule also could be delegated by uniffle if this is valuable. WDYT?

@advancedxy @zuston
(1) Remote Merge doesn't just work on sort, it also works on combine
You're paying too much attention to sort. In fact, merge may contain sort or combine. For spark, I think combine is more genernal. Remote merge also solves the problem of spilling data when combining. For RDD that requires combine but does not require sort, The shuffle server uses hash(key) for sorting. This will keep the same keys organized together as much as possible. On the reduce side, we can combine in memory.
(2) About sort
I haven't investigated SortExec yet, and I will investigate next. But I guess the reason for introducing sortexec is to save stage. If this is the case, then we can add stage. BTW, If the key of new shuffle is same with the prev, we can get better performance[SPARK-46512].
BTW, Although spark is a better computing framework, it is still based on mapreduce mechanism, which is no different from hadoop mapreduce and tez.

Thanks for your work. @zhengchenyu  After reviewing the design doc and concrete code briefly, I have some question about this feature.
Spark client

What's the diference of RecordBlob and RecordBuffer? The combine and sort difference is not reflected on the names
Why not making the RMWriteBufferManager extend the WriteBufferManager,  RMWriterBufferManager can almost replace the WriteBufferManager, we could control whether sort by config.
Is the local sort in block level enoguh? Can we make the block bigger if spill to file?

Shuffle-Server

If the merge failed, the reducer should failover to original mechanism
The merge process will introduce too much random read. If this happens on the HDD, the whole process is terrible. So the key point is to make the block bigger (Sort merge them before flushing to disk to create a bigger block?) But this looks will break the original blockId mechanism

@advancedxy
Yes, for spark sql, it doesn't make sense for spark sql right now.

In fact, our cluster mainly use Hive on Tez right now. But we have plans to update spark.

For Hive on Tez/MR, it make sense. We know hive also doesn't use the combine features of MR or TEZ. But why make sense?
We know that the record from shuffle is sorted,  we can combine in memory, then hive's aggregation operation is all in memory. In theory, the same can be done with spark-sql. SparkSQL can use sorted shuffle, then aggregate in memory. But we need to change a lot of spark-sql. Maybe we should focus on TEZ/MR firstly.

Thanks for your work. @zhengchenyu After reviewing the design doc and concrete code briefly, I have some question about this feature.
Spark client

What's the diference of RecordBlob and RecordBuffer? The combine and sort difference is not reflected on the names
Why not making the RMWriteBufferManager extend the WriteBufferManager,  RMWriterBufferManager can almost replace the WriteBufferManager, we could control whether sort by config.
Is the local sort in block level enoguh? Can we make the block bigger if spill to file?

Shuffle-Server

If the merge failed, the reducer should failover to original mechanism
The merge process will introduce too much random read. If this happens on the HDD, the whole process is terrible. So the key point is to make the block bigger (Sort merge them before flushing to disk to create a bigger block?) But this looks will break the original blockId mechanism

Spark client
(1) RecordBlob is used for combine and RecordBuffer is used for sort
(2) RMWriteBufferManager should be extended from WriteBufferManager. I just don't want to affect other code. If the proposal is accepted, I will do it later.
(3) If we wanna bigger block, best way is increase the block size.
Shuffle-Server
(1) Yes. We need failover to original rss, especially if we can't load class of key, value, comparator.
(2) I firstly test in HDD, it is terrible. Then I test in SSD cluster, then better. We can try to merge the block, but need lots of modification. I just wanted to do it quickly, so I reused the original mechanism

Firstly I think this is meaningful for tez/mr. For spark, the sorted shuffle is still meaningful, like the facebook did similar things in their cosco (facebook internal remote shuffle service), @jerqi could add some contexts for that.

(2) I firstly test in HDD, it is terrible. Then I test in SSD cluster, then better. We can try to merge the block, but need lots of modification. I just wanted to do it quickly, so I reused the original mechanism

I'm not sure the current design is available when on producation with too much random io. I prefer using the most general and stable way to optimize this if we have.


Some toolbar buttons don't work. They don't even get added to the editor.

I try to use these options:
$scope.tinymceOptions =
menubar: false
statusbar: false
toolbar: "redo undo | styleselect | bold italic | spellchecker link image | save"
But several buttons of the toolbar aren't even visible. I see the first 5 buttons, but not the last 4 ones. If I change the order of the buttons, the problem is the same.

Closing as I am not able to reproduce this and was able to successfully load plugins by using the plugins option as @grantgeorge mentioned.


Updated Index[1] to Index[0] to remove Index Error

This PR belong to issue #42 .

Sorry but this is not the reason for the error you are experiencing, and this would break the intended functionality.


1.33.0-insider no longer calling readFile method of my FileSystemProvider

I am developing an extension that implements FileSystemProvider. It is working correctly on the current VSCode release (1.32.3) but at the moment it's not loading file content when running on 1.33.0-insider.
I can also replicate the issue using the Remote FS extension (liximomo.remotefs) extension whose source is published at https://github.com/liximomo/vscode-remote-fs.
The MemFS sample is still working on my Insiders, so FileSystemProvider isn't completely broken.
But for my extension and for Remote FS I'm not seeing the readFile method ever getting called. In contrast, the readDirectory method continues to get called.
The effect is that I can browse directories on the remote system, but when I open any file it behaves as though it is a 0-byte file. No errors are reported, but all the content is missing.
I first noticed this after returning from vacation, so can't be sure exactly when it broke. But there seems to have been some recent work related to strict null checking which I guess could be relevant:
8f3cda12e475c810f77c737b590b67b1c7546f1b
To reproduce the problem:

Install Remote FS extension
Connect to a remote system (I used FTP)
Directories list OK
Opening a file reports no errors, but gives no content

Repeat the test on 1.32.3 to see correct behaviour.
Version: 1.33.0-insider (user setup)
Commit: 5688d00dd592a165530a82945c4ade4dad6b01e7
Date: 2019-03-25T06:19:55.474Z
Electron: 3.1.6
Chrome: 66.0.3359.181
Node.js: 10.2.0
V8: 6.6.346.32
OS: Windows_NT x64 10.0.16299

@gjsjohnmurray thanks, good catch. I pushed a fix and would be happy if you can validate that your extension works properly with the next insiders update. I did some heavy refactorings in the file service

@bpasero I confirm this is now fixed in the latest Insiders:
Version: 1.33.0-insider (user setup)
Commit: 1876bd1d3805d632a9aa78fad47b2c3c555f6eec
Date: 2019-03-25T14:53:36.371Z
Electron: 3.1.6
Chrome: 66.0.3359.181
Node.js: 10.2.0
V8: 6.6.346.32
OS: Windows_NT x64 10.0.16299
Thanks for the fast turnaround.


chore: roll to<EMAIL_ADDRESS>folio to 0.3.18

Should resolve #210 by ignoring babelrc.

Would love to see this merged in quickly! I've been using a forked version locally, but this is a blocker for getting playwright working at my comppany's NextJS project

@AkeemMcLennon If you're using yarn then you should also be able to use resolutions in your package.json to force the new version.
  "resolutions": {
    "folio": "0.3.18"
  }

@carlreid That worked perfectly! Thanks for the tip!


Perl cleanup: use modules and clean-up code

This patchset goes through and does a lot of clean-up in the perl code.
Each change is as self contained as possible, and tries to move us to modern, clean, less error prone perl.
Basic idea is: use Perl modules rather than re-implementing something from scratch.

This change is

FYI: for the helloworld-bvt.xml and helloworld.xml files with run-op-bvt and run-op-it respectively, this patchset roughly doubles performance (well... 2-4x faster with these patches)

and now, run-op-it doesn't parse XML using regex.

Wow, nice clean up Stewart!

I've asked Saqib to extract and validate the basic bvt works as expected against our test systems.
I'm going to ask Gunnar to take a look, most of the changes you made were in an area that he now supports (written previously by someone that has retired).
Your tab vs. space usage could use a quick formatter run against the code

Review status: 0 of 14 files reviewed at latest revision, 2 unresolved discussions.

bvt/helloworld.xml, line 29 [r3] (raw file):
tabs are evil, or is this one of those holy wars of dev?

bvt/OPBVTXML.pm, line 44 [r3] (raw file):
More tab/space stuff.

Comments from the review on Reviewable.io

Reviewed 13 of 14 files at r1, 1 of 1 files at r3.
Review status: all files reviewed at latest revision, 2 unresolved discussions.

Comments from the review on Reviewable.io

If you like, I can go and resubmit with whitespace fixups - or I can just clean up everything as I go. There's a bunch more changes I want to get through too that should simplify things out a bit.

It has Worked For Me against a Habanero... although I didn't try any of the HPM update stuff for BMC machines.
I plan to get rid of the passing variables by environment variables and come up with something better too - TBH, it probably makes sense to pass either XML or an ini file around, with a variety of options specified there.
I notice there's some possible old weird features to support running against multiple machines... I'm likely going to flesh that out, as that's really what I want to do, as well as have a concept of "known good" flash so taht it can restore back to that on error, as well as a method of operating that is "don't touch flash".

Whitespace fixed.
Github will probably have a fit due to rebasing now.

Stewart you need to rebase to pick up the latest changes. Your patch is breaking the bvt

Looks like it eventually rebased in github.  Saqib tested, Gunnar reviewed, lets merge it.

Reviewed 2 of 2 files at r4.
Review status: all files reviewed at latest revision, 2 unresolved discussions.

Comments from the review on Reviewable.io


Test fixes

Category
This change is exactly one of the following (please change [ ] to [x]) to indicate which:

[x] a bug fix (Fix #865)

Description
Ripme now doesn't download the entire file during testing if the file is over 10 mb. I also added a unit test for hqporner
Testing
Required verification:

[ ] I've verified that there are no regressions in mvn test (there are no new failures or errors).
[ ] I've verified that this change works as intended.

[ ] Downloads all relevant content.
[ ] Downloads content from multiple pages (as necessary or appropriate).
[ ] Saves content at reasonable file names (e.g. page titles or content IDs) to help easily browse downloaded content.

[ ] I've verified that this change did not break existing functionality (especially in the Ripper I modified).

Optional but recommended:

[ ] I've added a unit test to cover my change.

Coverage increased (+0.3%) to 39.003% when pulling e192243012048617feda9f38caa635c214495b73 on cyian-1756:testFixes into 5bb1e0debe2c64cda47552c094e893ece1c4ac18 on RipMeApp:master.

The failed test has nothing to do with these changes


New version: Grassmann v0.4.0

Registering package: Grassmann
Repository: https://github.com/chakravala/Grassmann.jl
Created by: @chakravala
Version: v0.4.0
Commit: 4becffe90e459eb92dfec2e4f3d737d3cbe77967
Reviewed by: @chakravala
Reference: https://github.com/chakravala/Grassmann.jl/commit/4becffe90e459eb92dfec2e4f3d737d3cbe77967#commitcomment-36420163

A useful tip is that if you install https://github.com/bcbi/CompatHelper.jl it will generate automated Pull Requests with suitable versions.

[noblock] yes, I will start using CompatHelper soon, but am not using it yet at the moment

@chakravala
Next time, please add the compat entries. I recommend using CompatHelper.jl.