KAFKA-7144: Fix task assignment to be even

This PR now justs removes the check in TaskPairs.hasNewPair that was causing the task assignment issue.
This was done as we need to further refine task assignment strategy and this approach needs to include the statefulness of tasks and is best done in one pass vs taking a "patchy" approach.
Updated current tests and ran locally
Committer Checklist (excluded from commit message)

[ ] Verify design and implementation
[ ] Verify test coverage and CI build status
[ ] Verify documentation (including upgrade notes)

ping @guozhangwang @mjsax for reviews

@bbejeck could you also trigger a system test over this branch as well?

@bbejeck @mjsax I'd like to propose a slightly different approach to fix 7114 while making no-worse tradeoffs between stickiness and sub-topology balance. The key idea is to try to adjust the assignment to gets the distribution as closer as to the sub-topologies' num.tasks distribution.
Here is a detailed workflow:

at the beginning, we first calculate for each client C, how many tasks should it be assigned ideally, as num.total_tasks / num.total_capacity * C_capacity rounded down, call it C_a. Note that since we round down this number, the summing C_a across all C would be <= num.total_tasks, but this does not matter.

and then for each client C, based on its num. previous assigned tasks C_p, we calculate how many tasks it should take over, or give up as C_a - C_p (if it is positive, it should take over some, otherwise it should give up some).

Note that because of the round down, when we calculate the C_a - C_p for each client, we need to make sure that the total number of give ups and total number of take overs should be equal, some ad-hoc heuristics can be used.

then we calculate the tasks distribution across the sub-topologies as a whole. For example, if we have three sub-topologies, st0 and st1, and st0 has 4 total tasks, st1 has 4 total tasks, and st2 has 8 total tasks, then the distribution between st0, st1 and st2 should be 1:1:2. Let's call it the global distribution, and note that currently since num.tasks per sub-topology never change, this distribution should NEVER change.

then for each client that should give up some, we decides which tasks it should give up so that the remaining tasks distribution is proportional to the above global distribution.

For example, if a client previously own 4 tasks of st0, no tasks of st1, and 2 tasks of st2, and now it needs to give up 3 tasks, I should then give up 2 of st0 and 1 of st1, so that the remaining distribution is closer to 1:1:2.

now we've collected a list of given-up tasks plus the ones that does not have any prev active assignment (normally operations it should not happen since all tasks should have been created since day one), we now migrate them to those who needs to take over some, similarly proportional to the global distribution.

For example if a client previously own 1 task of st0, and nothing of st1 and st2, and now it needs to take over 3 tasks, we would try to give it 1 task of st1 and 2 tasks of st2, so that the resulted distribution becomes 1:1:2. And we ONLY consider prev-standby tasks when we decide which one of st1 / st2 should we get for that client.
Now, consider the following scenarios:
a) this is a clean start and there is no prev-assignment at all, step 4 would be a no-op; the result should still be fine.
b) a client leaves the group, no client needs to give up and all clients may need to take over some, so step 4 is no-op, and the cumulated step 5 only contains the tasks of the left client.
c) a new client joins the group, all clients need to give up some, and only the new client need to take over all the given-up ones. Hence step 5 is straight-forward.
It is of course more complicated than our current algorithm, so I'd like to hear your opinions if it is worthwhile, that it indeed improves under various situations.

retest this please

@guozhangwang regarding your proposal above I agree with the approach.  While we still have to tackle assignments taking state stores into account, the procedure above is a good starting point for improving on the simple method we have now while not being too complicated (although the devil is always in the details!).
I think the deficiency with our current approach lies in the fact that we don't do steps 1 and 2.  I think that with sorting step 3 should be relatively straightforward.

if a client previously own 4 tasks of st0, no tasks of st1, and 2 tasks of st2

I should then give up 2 of st0 and 1 of st1

Maybe I didn't read the above right: there was no task of st1, how can the client give up 1 from st1 :-)

I think, that the observation that the relative task distribution is fixed is clever. However, it only holds if we have more tasks than threads. Assume, in the example that we have 16 threads -- thus, each thread should execute 1 task. Did not think it through yet: how would this affect the proposed algorithm?

I don't completely follow @guozhangwang 's proposed algorithm, but that's okay.
I wanted to comment on something that @mjsax touched upon: threads vs tasks vs instances. If I have a 2 instances, each with 2 threads, and I have 2 total tasks, I would like that each instance be assigned 1 task. That would allow each task to fully utilize the hardware that is available.
I would NOT want 2 threads in one instance to receive the tasks. If that were to happen, then the 2 tasks would be sharing hardware resources on the instance, while the 2nd instance is completely idle.
Do the proposed algorithms handle that?

@wushujames Note that our current assignment mechanism assign tasks to clients (i.e. instances) first, and then in a second phase within each client assign to its thread. And when we decide which client to assign to, we use the client's num.threads as its capacity. So what you mentioned above should be handled properly even today.

@guozhangwang: Cool. Thanks for the explanation.
When you assign tasks to a client, will the client make sure to spread the tasks out across all its threads? Is it possible that the client will assign multiple tasks to a single thread and leave its other threads idle?

Oh wait, I think you may have answered that already?
“and then in a second phase within each client assign to its thread”
But just double checking.

Is it possible that the client will assign multiple tasks to a single thread and leave its other threads idle?

This should not happen, if it happens, it would be a bug :)

@guozhangwang @mjsax updated this PR to just remove the check causing issue, reasoning explained in main comments of PR.
system tests have been launched

@bbejeck Could you also add a unit test in StreamsPartitionAssignorTest to validate the bug has been resolved?

Did you mean the StickyTaskAssignorTest instead?

Did you mean the StickyTaskAssignorTest instead?

Yes, you're right.

updated this with unit test

updated this

Created https://issues.apache.org/jira/browse/KAFKA-7203

Should we cherry-pick this to older branches?

Cherry-picked to 2.0


update npm version for development

travis config has already updated in #147
appveyor config is fixed npm verson as 6.x together
newline code is replaced, CRLF --> LF

fixes #142

LGTM!


Added Maecenas and Cofoundit urls

At Maecenas we're doing a crowsale which starts at 5th sept. I'm adding Maecenas and CofoundIt urls to the list of valid domains

Thanks!


This adds support for persisting the touch indicator and tooltip after a touch event is complete

How we should clear the indicators if persistIndicatorsAndTooltips is true?

We could make a clearIndicators method

I think we need to clear indicators when the user tapped on nothing.
What you think?

I like the idea, do we have a callback / way to determine if the user
didn't tap on anything?
On Wed, Feb 5, 2020 at 1:31 PM iman khoshabi<EMAIL_ADDRESS>wrote:

I think we need to clear indicators when the user tapped on nothing.
What you think?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/imaNNeoFighT/fl_chart/pull/186?email_source=notifications&email_token=AAIQ2MJPLULU7A2GJ2OZHTLRBMHX7A5CNFSM4KNXUUO2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEK4VWRQ#issuecomment-582572870,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAIQ2MIKWBOKG7VRKDC7BZDRBMHX7ANCNFSM4KNXUUOQ
.

We've handled something like this in the PieChartSample2,
please take a look.
Sample 2 (Source Code)

FYI: in our use case we don't want them cleared at all. We want wherever the user tapped last to persist.


Reduce the number of buckets created in tests

cc @kyleknap @jamesls @stealthycoin

Current coverage is 97.62% (diff: 100%)

Merging #1082 into develop will not change coverage

@@            develop      #1082   diff @@
==========================================
  Files            44         44
  Lines          6936       6936
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
  Hits           6771       6771
  Misses          165        165
  Partials          0          0

Powered by Codecov. Last update 5b0bcf3...a03bc41


Yocto (Scarthgap) on Raspberry Pi: Unhandled Exception: MissingPluginException(No implementation found for method getWindowMaximumSize on channel desktop_window)

I have this error on file app_logic.dart ("await DesktopWindow.setMinWindowSize($styles.sizes.minAppSize);")

Hmm, I wonder why. We are using the https://pub.dev/packages/desktop_window package, which should have linux support.


Show link alias instead of Zettel title when available

When writing [[xyz|foo]], I'd expect it to show foo instead of the zettel title.

I've added this feature in the feat/title-alias branch, you can check it out if you'd like.
I would like to have proper unit tests on the whole virtual title bit before merging into master (this is currently wildly untested, and I wouldn't want to break things for the two other people out there relying on this :P


Modal Ready function not firing in v0.99

Description
It appears that the ready function of a modal has been broken in the new release. The alert fires when using 98.1 but not when using 99.0.
Repro Steps
See this fiddle for the existing one using v0.98.1 https://jsfiddle.net/nx429bfg/1/
See this fiddle for the new one V0.99 https://jsfiddle.net/9o51s3v6/1/

Here too.
Modal setup was broken (or updated).
Now seems you need to use like this:
$(document).ready(function() {
  $('#modal1').modal("open", {
  	ready: function() {
    	alert('hi');
    }
  });
});

That does seem to work, but does that mean that in order to trigger a modal open I have to also pass the options in again every time an open/close method is called? That seems like a backwards step.

Clicking on the button triggers it: https://codepen.io/anon/pen/QgMVXL

Clicking on the button triggers it: https://codepen.io/anon/pen/QgMVXL
Please also check https://codepen.io/anon/pen/JJymdO.
It should solve your problem. I will create a PR for this fix if this solves the issue.

The final solution seems to solve the issue (https://codepen.io/anon/pen/JJymdO). Many thanks for the responses.

@inventti-leonardo does it solve the issue on your sise too?

👍

Hello, I also have a problem with complete function... It stop working in ver. 0.99

related to https://github.com/Dogfalo/materialize/issues/4932

@tomscholz can you verify too, that this solves it? If yes I'll create the PR.

Hey.
It seems a bug with modal in the materialize 0.100.0

              menu

search

search

more_vert


[Azure App Configuration] Add 2021-10-01-preview version

MSFT employees can try out our new experience at OpenAPI Hub  - one location for using our validation tools and finding your workflow.

Changelog
Add a changelog entry for this PR by answering the following questions:

What's the purpose of the update?

[ ] new service onboarding
[x] new API version
[ ] update existing version for new feature
[ ] update existing version to fix swagger quality issue in s360
[ ] Other, please clarify

When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
If updating an existing version, please select the specific langauge SDKs and CLIs that must be refreshed after the swagger is published.

[ ] SDK of .NET (need service team to ensure code readiness)
[ ] SDK of Python
[ ] SDK of Java
[ ] SDK of Js
[ ] SDK of Go
[ ] PowerShell
[ ] CLI
[ ] Terraform
[ ] No refresh required for updates in this PR

Contribution checklist:

[ ] I commit to follow the Breaking Change Policy of "no breaking changes"
[ ] I have reviewed the documentation for the workflow.
[ ] Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist

Applicability: :warning:
If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

Change to data plane APIs
Adding new properties
All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

[x] Check this box if any of the following apply to the PR so that label "WaitForARMFeedback" will be added automatically to begin ARM API Review. Failure to comply may result in delays to the manifest.

Adding a new service
Adding new API(s)
Adding a new API version
-[ ] To review changes efficiently, ensure you are using OpenAPIHub to initialize the PR for adding a new version. More details, refer to the wiki.

[x] Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

[ ] If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist
If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.

[ ] Removing API(s) in a stable version
[ ] Removing properties in a stable version
[ ] Removing API version(s) in a stable version
[ ] Updating API in a stable or public preview version with Breaking Change Validation errors
[ ] Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.

Link to approved private PR: https://github.com/Azure/azure-rest-api-specs/pull/17410

Link to approved private PR: #17410

Sure ? , seem these two PRs are not relevant

Link to wrong one, sorry about this
https://github.com/Azure/azure-rest-api-specs-pr/pull/5230

Link to approved private PR: #17410

Sure ? , seem these two PRs are not relevant

@jianyexi Sorry about this, I linked to wrong one, here is the correct PR https://github.com/Azure/azure-rest-api-specs-pr/pull/5230


Model should accept more than two players.

Let's make a model which works with indefinite number of players using the following new objects:

An Iterator object should receive an array of players and allow to iterate over them using a GetNext() function.
A PlayerFactory object should resolve a configured player (human or computer, see factory pattern).
The Game object in its constructor should receive an array of players created by ViewModel using the PlayerFactory object.

Done (Iterator has moveNext and getCurrent methods)
Done
Done


Coordinate system

Hello!
Could you please clarify how you define the coordinate systems for the world, camera, and 3D model?
Are they right-handed with the Z-axis pointing up?
Thank you!

The pose that DeepAC computed is the w2c transformation (extrinsic matrix).
The inverse of the pose is the camera pose(c2w transformation), which is represented by OpenCV coordinate system(https://docs.opencv.org/4.x/d9/d0c/group__calib3d.html).


Can't format path

Describe the bug
Can no longer set a file path based on the episode parameters.
To Reproduce
Steps / command to reproduce the behavior:
$ ./crunchy-cli archive -l $1 -s en-US -o 'Anime/{audio}/{series_name}/Season {season_number}/{series_name} - S{season_number}E{episode_number} - {title}.mkv'

Expected behavior
Formating of the path using info from the episode that is downloaded.
Screenshots

Client (please complete the following information):

OS: Ubuntu server 22.04 LTS
Version 3.0.0 dev 7

Additional context
This used to work with the -d in the latest go version

Just tested the build artifact and it worked perfectly!


Change white mode (sun) icon

Currently, the Toggle has a yellow circle as a toggle to light mode icon:

This doesn't speak for itself, so we would like to update it. Here is the new icon:

It has to be placed inside the src/components/icons/svg folder, and then simply run the yarn icons command to transform the SVG into a React component.

Hi I wanted to work on this issue
can you please assign it to me @mdubus ?

#self-assign

Hi @mdubus
I made changes for White mode Sun Icon. I created Pull request. for this issue. Please find below Screenshots.

Full screenshot

Let me know if any changes are required.
Thanks :)


Only splashscreen

Hi!
I cloned your repo and built an android app, everthing worked fine no errors.
But when I run your app on my device it only displays the splashscreen, forever...
Is there an issue, that you are aware of?
Do I have to do anything besides the normal building process with cordova?
Here is my stackoverflow question: http://stackoverflow.com/questions/33989921/cordova-android-reactjs/33990239#33990239

Any chance you are running it with node version 5 using the command ./platforms/android/cordova/run?

Here's how I managed to solve the issue:
//webpack.config.js
...

loaders: [{
    test: /\.jsx?$/,
    loaders: ['babel'] , //remove 'react-hot'
    exclude: /node_modules/
  }, {

...

entry: [
    //'webpack-dev-server/client?', comment these two entries out
    //'webpack/hot/only-dev-server',
    './src/entry-points/Client.jsx'],

...

Basically what caused the problem is that when the react-hot-reloader is on, the compiled js will initiate a socket towards the localhost. On your computer this is fine as long as you run the webpack dev server using npm start. However what cordova does is simply opening up the index.html and feed it to the webview for display, nothing more than double-clicking on the index.html on your hard disk, and the websocket initiator will throw an error at an early stage of bundle.js evaluation, ceasing further execusion.

@JeffOwOSun I'm aware of this error but it's not something you want to comment out (because you lose hot model replacement in the process).
This might be a suitable replacement.
entry: ['./src/entry-points/Client.jsx'].concat(
    __CORDOVA__ ? [] : [
        'webpack-dev-server/client?',
        'webpack/hot/only-dev-server'
    ])

And soon will be fixed.

@fabulous-fab14 About your error, it seems like a javascript error.
Could be caused by build step gone wrong.
Most common thing I came across yesterday was that hooks/build.sh wasn't running because it lacked permissions, I ran chmod +x ./hook/build.sh and it was fixed.
But to help you with this problem I got to see the build log (cordova run android's log)

Hi!
it appeared to be like @JeffOwOSun said with the hot loader. I managed to solve my issue and my project is running on android now! As soon as I have more spare time I will be writing a tutorial about my experience with ReactJS + cordova.
Thanks for your help!


Seg fault when running rails s

I fixed the issue with not being about to bundle install. Now when I try to run rails s or export REDIS_URL=redis://<IP_ADDRESS>:6379/0 && bundle exec sidekiq I get seg faults and hundreds of lines of bug reports... I've tried removing gems and reinstalling but no luck. Any advice?

Can you please post a screenshot?

fuzzerapiErrorLog.txt


fix JDBC Connector, WHERE clauses aren't being pushed down.

Hello.
I uses Presto, with Mysql and Postgresql.
※Mysql and Redshift
JDBC Connector(mysql and postgresql), WHERE clauses aren't being pushed down.
But BIGINT, DOUBLE, BOOLEAN is WHERE clauses being pushed down.
I add VARCHAR, DATE, TIMESTAMP WHERE clauses.
Such as query on presto
select count(*) from postgresql.public.pageview where log_date > cast ('2015-07-25' as timestamp)

Then running query in redshift.
select count(*) from postgresql.public.pageview where log_date > '2015-07-25'

These are same case.
https://groups.google.com/forum/#!topic/presto-users/Pj-ta_FO0OQ
https://github.com/facebook/presto/issues/2341

This should be rebased on #3135 , because different database has different syntax.

Thank you for your reply!
OK.
This pull request be rebase.
https://github.com/facebook/presto/pull/3135
There are a questions, sorry.

because different database has different syntax.
・QueryBuilder.java make every Connector？

Connectors that based on presto-base-jdbc, MySQL, Postgresql etc. can overwrite the function supportPredicateOnType and encode.

OK!
thanks!

Hello!
I send pull request to Mr. AshwinJay.
https://github.com/AshwinJay/presto/pull/1
thanks.

reviewing this pull request.
https://github.com/AshwinJay/presto/pull/1

Hello.
rebased complete this pull request.
https://github.com/facebook/presto/pull/3135

My sincere apologies on the duplication of work here. Your SQL range tests are good and I'm going to integrate them.

Merged, thanks!


Confusion over moment.utz with MySQL DateTime

I've written a small test here: https://jsfiddle.net/vrdhcuey/1/
When we request from the database we get a DATETIME from the MySQL database back (initially set to default UTC timezone but also tested with it set as Europe/Dublin as timezone) of 2016-04-22T16:00:00.000Z - that is to say the end datetime of our object is Friday 22nd April, at 4pm.  This is in reality timezoneless as all we are saying is that the event can end at 4pm on a given date, but that date could fall in GMT or BST.
In the test provided, we want to get the duration between now and that datetime. However it is always an hour off.  The only way around it is to remove the .000Z from the end of the datetime string.  I've also tried to use moment.tz but have the same result (i.e. in this test leftTime4 is the correct behavior we're expecting). I would have however expected leftTime2 to work as is.
Can anyone please clear up this confusion, or am I hitting a bug here?

The ISO8601 standard specifies that dates ending in Z shall be interpreted as UTC. As such, what moment does when passed your time is convert the time from UTC to local. This is how you get your one hour off situation.
If you wish for moment to ignore the Z (interpret the time as local), you can specify a format that does not pick up on the Z by doing the following:
moment('2016-04-22T16:00:00.000Z', 'YYYY-MM-DDTHH:mm:ss.SSS').format()

If you want more information about the various parsing modes, this section of the guides may be helpful: http://momentjs.com/guides/#/parsing/local-utc-zone/

Right - so, the real fix is, don't emit Z from your back end if you don't really mean UTC.

@mj1856 Yea tried to, but I wonder if the issue lies with Sequlize rather than MySQL itself - when we run the query against the DB directly it emits just a plain DATETIME with YYYY-MM-DD HH:MM:SS, as it's stored. Changing the timezone of the DB seemed to make no difference. Anyway the above seems to fix it for now, we'll see if it holds up when we go back into GMT :bomb:


Use vertical formatting when function args width > limit

Closes #342

Looks good! Is this something we should consider for struct literals as well?
Otherwise, r+.

Yeah, we should do it for struct lits too, but I thought I'd leave it for another PR (I want to think about number of items there too).


fix(build) CI, testing, lerna hoisting, dependencies, demo uses webpack

Signed-off-by: Jerome Simeon<EMAIL_ADDRESS>Issue #26 & #28 & #31
This fixes issues running the demo, but also aligns more closely with cicero-ui and other AP lerna-based repositories:

Switches the demo from react-scripts to webpack
Changes the lerna build to use hoisting
Aligns dependencies across all packages (as much as possible)
Upgrades to react version 16.11 and other dependencies for consistency with cicero-ui
Adds other dependencies found in cicero-ui notably for styling
Fixes to tests, adjusts configuration for testing linting and license check
Enable CI with Travis
Automatic deployment of npm packages through Travis

So much better, thanks @jeromesimeon!
A few little questions:

I notice that you rightly removed most of the compiled code from the dist folders, is there a reason for retaining files in packages/concerto-ui-react/dist/?
Has Travis been set up to match the key that's included here now?

So much better, thanks @jeromesimeon!
A few little questions:

I notice that you rightly removed most of the compiled code from the dist folders, is there a reason for retaining files in packages/concerto-ui-react/dist/?

No reason, I just missed it! Removed now.

Has Travis been set up to match the key that's included here now?

It has... we'll know if I got it right as soon as we publish a new release.


Make Guice components singletons

Currently the Guice components are not singletons.  Besides the unnecessary instantiation, this also breaks things like the CurrentSpanCustomizer pattern where each CurrentSpanCustomizer was receiving a new tracer.  Since each tracer has its own recorder, additional tags are always added to a new span instead of the current span.
In addition to adding the singleton scopes this also exposes Tracing, Tracer and SpanCustomizer on the guice registry for convenience.

@hyleung if this looks ok would you mind merging and making a 2.0.2 release?

@hyleung  thanks a ton for reviewing this so quick!

@llinder no problem at all! I think 2.0.2 should be up by now...


❓ [Question] How to load a TRT_Module in python environment on Windows which has been compiled on C++ Windows ?

❓ Question
I have compiled torch_trt module using libtorch on C++ windows platform. This module is working perfectly on C++ for inference, however I want to use it in Python program on windows platform. How to load this module on python?
When I tried to load it with torch.jit.load() or torch.jit.load() it is throwing following error:
`File ~\AppData\Local\Programs\Python\Python310\lib\site-packages\torch\serialization.py:711, in load(f, map_location, pickle_module, **pickle_load_args)
707             warnings.warn("'torch.load' received a zip file that looks like a TorchScript archive"
708                           " dispatching to 'torch.jit.load' (call 'torch.jit.load' directly to"
709                           " silence this warning)", UserWarning)
710             opened_file.seek(orig_position)
--> 711             return torch.jit.load(opened_file)
712         return _load(opened_zipfile, map_location, pickle_module, **pickle_load_args)
713 return _legacy_load(opened_file, map_location, pickle_module, **pickle_load_args)
File ~\AppData\Local\Programs\Python\Python310\lib\site-packages\torch\jit_serialization.py:164, in load(f, map_location, _extra_files)
162     cpp_module = torch._C.import_ir_module(cu, str(f), map_location, _extra_files)
163 else:
--> 164     cpp_module = torch._C.import_ir_module_from_buffer(
165         cu, f.read(), map_location, _extra_files
166     )
168 # TODO: Pretty sure this approach loses ConstSequential status and such
169 return wrap_cpp_module(cpp_module)
RuntimeError:
Unknown type name 'torch.torch.classes.tensorrt.Engine':
File "code/torch/movinets/models.py", line 4
parameters = []
buffers = []
_torch___movinets_models_MoViNet_trt_engine : torch.torch.classes.tensorrt.Engine
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ <--- HERE
def forward(self_1: torch.movinets.models.MoViNet_trt,
input_0: Tensor) -> Tensor:`
What you have already tried
Since torch_trt is not supported for Python on windows I picked libtorchtrt_runtime.so from linux python3.8/site-packages/torch_tensorrt/lib/libtorchtrt_runtime.so path and loaded on python on windows through torch.ops.load_library(). However it throws another error
File "\video_play.py", line 189, in get_torch_tensorrt_converted_model torch.ops.load_library("libtorchtrt_runtime.so") File "C:\Users\NomanAnjum\AppData\Local\Programs\Python\Python310\lib\site-packages\torch\_ops.py", line 255, in load_library ctypes.CDLL(path) File "C:\Users\NomanAnjum\AppData\Local\Programs\Python\Python310\lib\ctypes\__init__.py", line 374, in __init__ self._handle = _dlopen(self._name, mode) OSError: [WinError 193] %1 is not a valid Win32 application
Environment
Windows 11
CPU : i9-11980HK x86-64
GPU : RTX 3080 Mobile
Cuda : 11.5.2
Cudnn : 8.3.1
Libtorch : 1.11
Tensor_RT : <IP_ADDRESS>
Visual Studio 2019
Python 3.10,3.8
Is there a way to load it in python??

@andi4191 can you take a look at this as well when you look at the other windows issue?

@noman-anjum-retro: Don't you need to load torchtrt_runtime.dll using python on windows?

@andi4191 I'm not sure how to load it. When I tried to load it via this code:
`import torch
import ctypes
Load DLL into memory.
hllDll = ctypes.WinDLL ("D:/Codes/RetroActivity/experiments/src/exploration/action_recognition/torchtrt_runtime.dll")
print("DLL Loaded")
#torch.ops.load_library("D:/Codes/RetroActivity/experiments/src/exploration/action_recognition/torchtrt_runtime.dll")
model =  torch.jit.load(r"D:\NewTRTModel.ts")`
it throwed an error:
 hllDll = ctypes.WinDLL ("D:/Codes/RetroActivity/experiments/src/exploration/action_recognition/torchtrt_runtime.dll")   File "C:\Users\NomanAnjum\AppData\Local\Programs\Python\Python310\lib\ctypes\__init__.py", line 374, in __init__     self._handle = _dlopen(self._name, mode) FileNotFoundError: Could not find module 'D:\Codes\RetroActivity\experiments\src\exploration\action_recognition\torchtrt_runtime.dll' (or one of its dependencies). Try using the full path with constructor syntax.
Since path is correct it's definitely some other issue

update: I checked all the dependent files of torchtrt_runtime.dll and I found some more libraries with it. I got some of them from TensorRT and some from libtorch. Now the error while loading  the dll has changed to:
 File "D:\Codes\RetroActivity\experiments\src\exploration\action_recognition\video_play.py", line 198, in get_torch_tensorrt_converted_model     hllDll = ctypes.WinDLL(r"D:\Codes\RetroActivity\experiments\src\exploration\action_recognition\torchtrt_runtime.dll")   File "C:\Users\NomanAnjum\AppData\Local\Programs\Python\Python310\lib\ctypes\__init__.py", line 374, in __init__     self._handle = _dlopen(self._name, mode) OSError: [WinError 1114] A dynamic link library (DLL) initialization routine failed

@noman-anjum-retro did you get it working? facing the same issue here,

No, still waiting for @narendasan or @andi4191 help

@noman-anjum-retro: Can you try this?
I added the option in torchtrtc to support custom torch op or torch_tensorrt converter. I have used windows.h header file and LoadLibrary for loading the symbol tables from a dll file.
https://github.com/pytorch/TensorRT/blob/72457277e80247d71a3bf9737d98f08b65b217d7/cpp/bin/torchtrtc/main.cpp#L27

@andi4191  What's the solution you are suggesting? Should I recompile my TRT module on C++ with this change and try to load it in python?

Yes, the fix was merged into master so go ahead and try it and see if fixes your issue

Hello @andi4191 , no it didn't help it popped the same errors in series mentioned above.

Progress:
Hello @andi4191  @narendasan, I tried loading compiled TRT module on C++ and python.
On C++ it worked fine on Debug mode, but on C++ Release mode and In Python it throwed following error:
`RuntimeError:
Unknown type name 'torch.torch.classes.tensorrt.Engine':
File "code/torch/movinets/models.py", line 4
parameters = []
buffers = []
_torch___movinets_models_MoViNet_trt_engine : torch.torch.classes.tensorrt.Engine
def forward(self_1: torch.movinets.models.MoViNet_trt,
input_0: Tensor) -> Tensor:`

However when I loaded torchtrt_runtime.dll  on C++ release with following code and it worked:

`HMODULE hLib = LoadLibrary(TEXT("torchtrt_runtime"));
    if (hLib == NULL) {
        std::cerr << "Library torchtrt_runtime.dll not found" << std::endl;
        exit(1);
    }`

This makes it clear that running on windows need torchtrt_runtime.dll to be loaded. However when I'm trying to load it in python with following code:

`torch.ops.load_library("/src/exploration/action_recognition/torchtrt_runtime.dll")`

or

`import ctypes
    #hllDll = ctypes.WinDLL("/src/exploration/action_recognition/torchtrt_runtime.dll")`

Library is not getting loaded and throwing following error:

`hllDll = ctypes.WinDLL ("/src/exploration/action_recognition/torchtrt_runtime.dll") File "C:\Users\NomanAnjum\AppData\Local\Programs\Python\Python310\lib\ctypes\__init__.py", line 374, in __init__ self._handle = _dlopen(self._name, mode) FileNotFoundError: Could not find module '\src\exploration\action_recognition\torchtrt_runtime.dll' (or one of its dependencies). Try using the full path with constructor syntax.`

I then used dependancy checker for torchtrt_runtime.dll and added all dependant dlls to same folder and error has changed to:

`File "\src\exploration\action_recognition\video_play.py", line 198, in get_torch_tensorrt_converted_model hllDll = ctypes.WinDLL(r"\src\exploration\action_recognition\torchtrt_runtime.dll") File "C:\Users\NomanAnjum\AppData\Local\Programs\Python\Python310\lib\ctypes\__init__.py", line 374, in __init__ self._handle = _dlopen(self._name, mode) OSError: [WinError 1114] A dynamic link library (DLL) initialization routine failed`

I have this strong feeling that if I can load torchtrt_runtime.dll it will run.

Please help me on this

It seems to be complaining about the FileNotFound
IIRC, in Windows, the paths are mentioned as:
\src\exploration\action_recognition\torchtrt_runtime.dll
Can you try above and share your observation?

No it didn't work. Can you please try to load a TRT on your side, maybe you'll catch something that I am missing. It's weird that it's loading in C++ and not in Python

Update:
I tried loading torchtrt_runtime.dll without importing torch in python and it loaded gracefully. Then I tried importing torch, but it failed with same error [WinError 1114] A dynamic link library (DLL) initialization routine failed. It seems that Python is unable to load both torchtrt_runtime.dll and torch at the same time, first operation gets completed and second one fails.
When torchtrt_runtime is loaded prior to torch:
Traceback (most recent call last):
  File "loadDLL.py", line 5, in <module>
    import torch
  File "C:\Users\NomanAnjum\anaconda3\envs\py37\lib\site-packages\torch\__init__.py", line 129, in <module>
    raise err
OSError: [WinError 1114] A dynamic link library (DLL) initialization routine failed. Error loading "C:\Users\NomanAnjum\anaconda3\envs\py37\lib\site-packages\torch\lib\torch_cpu.dll" or one of its dependencies.

When torch is imported prior to loading torchtrt_runtime.dll
Traceback (most recent call last):
  File "loadDLL.py", line 7, in <module>
    hllDll = ctypes.CDLL(r"torchtrt_runtime.dll")
  File "C:\Users\NomanAnjum\anaconda3\envs\py37\lib\ctypes\__init__.py", line 364, in __init__
    self._handle = _dlopen(self._name, mode)
OSError: [WinError 1114] A dynamic link library (DLL) initialization routine failed

Hi @noman-anjum-retro,
I think the problem is with the mode while you are trying to load the symbol tables.
I tried following and is working:
import ctypes
import torch

handle = ctypes.WinDLL("<Path to torchtrt artifacts>\\torchtrt_runtime.dll", winmode=1)
print(handle)
...

For quick reference:
https://docs.microsoft.com/en-us/windows/win32/api/libloaderapi/nf-libloaderapi-loadlibraryexa
https://github.com/python/cpython/blob/3.9/Lib/ctypes/__init__.py#L358
Additionally, can you also check if the torch installed on your machine is compatible with the torch-tensorrt?

Thanks for the help, I tried it and .dll got loaded along with torch, however torch.jit.load() throwed the same error as in start:
RuntimeError: Unknown type name 'torch.torch.classes.tensorrt.Engine': File "code/torch/movinets/models.py", line 4 parameters = [] buffers = [] _torch___movinets_models_MoViNet_trt_engine : torch.torch.classes.tensorrt.Engine < -- HERE   def forward(self_1: torch.movinets.models.MoViNet_trt, input_0: Tensor) -> Tensor:
then I imported tensorrt in python, and this error got vanished but now the python is quitting on loading without any error or exception:
try:     torch.jit.load("NewTRTModel843_80.ts")     print("Success") except Exception as e:     print(e)
Print statement is not getting executed neither any exception or error.It happens even without loading the .dll

@narendasan  @andi4191 any update on this?

Hi all,
I'm also trying to make Torch-TensorRT work with Python on Windows. I was able to compile TensorRT from source using CMake and to reproduce the following as posted by @andi4191 (I had to copy over the .dll dependencies as suggested by @noman-anjum-retro):
import ctypes
import torch

handle = ctypes.WinDLL("<Path to torchtrt artifacts>\\torchtrt_runtime.dll", winmode=1)
print(handle)

However I'm not sure what I'm supposed to do with the handle returned by WinDLL. My next objective is to call any function from the torch_tensorrt module, like torch_tensorrt.compile, but import torch_tensorrt won't find the module (I guess it's because it was compiled from source and not installed via pip), and handle.compile won't find the function.
Is there any obvious step that I'm missing?

@narendasan @andi4191 any update on this?

torch.torch.classes.tensorrt.Engine stands out as kinda weird, id expect this to just be torch.classes.tensorrt.Engine. Is it possible to upload the compiled ts module so we can take a look?

Hi all, I'm also trying to make Torch-TensorRT work with Python on Windows. I was able to compile TensorRT from source using CMake and to reproduce the following as posted by @andi4191 (I had to copy over the .dll dependencies as suggested by @noman-anjum-retro):
import ctypes
import torch

handle = ctypes.WinDLL("<Path to torchtrt artifacts>\\torchtrt_runtime.dll", winmode=1)
print(handle)

However I'm not sure what I'm supposed to do with the handle returned by WinDLL. My next objective is to call any function from the torch_tensorrt module, like torch_tensorrt.compile, but import torch_tensorrt reports ModuleNotFoundError: No module named 'torch_tensorrt' (I guess it's because the module was compiled from source and not installed via pip), and handle.compile reports AttributeError: function 'compile' not found.
Is there any obvious step that I'm missing?
EDIT: I'm not an expert on this, but I guess there should be a custom version of setup.py to wrap the .dll into a package that Python can recognize when I run python setup.py install. The existing setup.py in the source tree is obviously written to work only with Linux, is there a special version of it for the Windows build that I'm not finding? Or am I supposed to write my own?

So the steps laid out above are for runtime execution of compiled modules in python, not compiling modules in python. It assumes you compiled the module using the C++ API or torchtrtc since we haven't had time to get the bindings working for Python on Windows.
I think the best way to do this is not really some post compilation monkey patching but overhauling the setup.py to use cmake in addition to bazel.
You can see the build process for setup.py + bazel here: https://github.com/pytorch/TensorRT/blob/b1db33a06fe6e49004405431678946e9e8248ba8/py/setup.py#L118
Basically the steps are build the core library, then copy it into the python package tree, and use that to build the python bindings.
I would assume that the steps for cmake (and therefore windows) would be similar.

Thank you for the hint about using torchtrtc to compile the model offline, which got me a step further. Now I seem to be stuck at the same point as @noman-anjum-retro :
trt_model = torch.jit.load("efficientnet_b0_traced_trt.ts")

Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "...\AppData\Local\Programs\Python\Python38\lib\site-packages\torch\jit\_serialization.py", line 162, in load
    cpp_module = torch._C.import_ir_module(cu, str(f), map_location, _extra_files)
RuntimeError:
Unknown type name '__torch__.torch.classes.tensorrt.Engine':
  File "code/__torch__/timm/models/efficientnet.py", line 4
  __parameters__ = []
  __buffers__ = []
  __torch___timm_models_efficientnet_EfficientNet_trt_engine_ : __torch__.torch.classes.tensorrt.Engine
                                                                ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ <--- HERE
  def forward(self_1: __torch__.timm.models.efficientnet.EfficientNet_trt,
    input_0: Tensor) -> Tensor:

The compiled module is attached: I'm trying to repro this example from NVIDIA. In my case, loading the .dll doesn't seem to have any effect: the error message is exactly the same whether I don't use WinDLL or whether I do the following
>>> import ctypes
>>> handle = ctypes.WinDLL("C:\\...\\NVIDIA\\TensorRT\\out\\install\\x64-Release\\bin\\torchtrt_runtime.dll", winmode=1)
>>> print (handle)
<WinDLL 'C:\...\NVIDIA\TensorRT\out\install\x64-Release\bin\torchtrt_runtime.dll', handle 7ffb2fae0000 at 0x1936fca0af0>

before trying to load the compiled model in Python.

@narendasan please find compiled module here. This was compiled with tensorrt 8.4.3

Opening the compiled modules (they're just zip archives) I can see that the "__torch_mangle[0-9]+" information is being swallowed up by the torchtrtc compiler when running under Windows. Could this be what makes the compiled file unparseable by the loader?

any success with it @LukeRoss00 ?

No, honestly I've given up trying to run this on Windows.


Add - new snippet: Hammer.js

I just realized I could give a sample of applying hammerjs to an element in a component and not just as a hostlistener. Please allow me a sec to apply that.

@MichaelSolati great work! Can you put another snippet in the Bonus block with extra description?
You can check example here https://github.com/nycJSorg/30-seconds-of-angular/blob/master/snippets/adding-keyboard-shortcuts-to-elements.md

@thekiba should I just do this for the event bindings or also the host listeners?

@MichaelSolati only for event bindings. "Also you can applying hammerjs events to elements in the template" something like that :)

Pls add bonus section and let's merge this in


Change tsx to ts in randomquoter/index.md

Weird purple thingy.

Fixed in ccb4477. It's an old bug in Hugo.


fix: no scan, not added to qrlist

if no code is scanned, qrid is set to temp. if qrid is temp, it isn't added to qrcodelist

other files that were changed apart fro zxingscanner were for code cleanup: unused edittext that was originally for naming but has been rendered useless with the name generator


Chart candlesticks look broken when Zooming out

I've noticed that when I zoom out on the candlestick chart the candles begin to look broken and glitchy. Here are 2 screenshots. Why might this be happening?

What version of lightweight-charts you use?

I didn't use npm to install. I just added the cdn to my html head like this.

You can execute LightweightCharts.version(). Also, you can specify a version via URL - use<EMAIL_ADDRESS>to use the latest version.
Anyway, please provide a repro and steps how to reproduce the issue (jsfiddle or so is fine).

Thanks it works I just needed to change the HTML head script from https://unpkg.com/lightweight-charts/dist/lightweight-charts.standalone.production.js to<EMAIL_ADDRESS>


⚠ ClamAV has degraded performance

In 8c7643e, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 78 ms

Resolved: ClamAV performance has improved in e144a5c.


Experiment: Async peers

There is a thing that I don't like in #1301 — the direction where config goes.
In my initial concept, I wanted to achieve the simplicity of config, being object of primitive properties.
Here I'd like to explore another direction by restoring back compression and upload as bool | Options, but instead — trying to import the corresponding peers dynamically.
For that, however, createServer has to become async, which is also breaking, but I believe, might be much less breaking, and the outcome of that should be nicer.

Restored documentation and adjusted the changelog.
LGTM


Fix is_move_and_slide_on_wall, make move_and_slide floor angle configurable

Fixes #7313

Math functions work with radians, so I think deg2rad should be called by the user if desired.

So do you want to keep the assumption that floor and ceiling must be parallel?

I think its fine they are parallel, but different angles for floot and
ceiling may be desired..
On Apr 4, 2017 1:36 PM, "Ferenc Arn"<EMAIL_ADDRESS>wrote:
So do you want to keep the assumption that floor and ceiling must be
parallel?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/godotengine/godot/pull/8259#issuecomment-291557801,
or mute
the thread
https://github.com/notifications/unsubscribe-auth/AF-Z21UBIHhNKAsf8g55XrOcupCTjLMKks5rsnFzgaJpZM4My3na
.

Ok, feel free to purpose an API which would feel good, and I can implement it...

I was thinking of something like
move_and_slide(const Vector2 &p_linear_velocity, const Vector2 &p_floor_normal, const Vector2 &p_ceiling_normal, float p_max_angle, float p_slope_stop_min_velocity, int p_max_bounces)

move_and_slide(const Vector2 &p_linear_velocity, const Vector2 &p_floor_normal, float p_max_floor_angle, const Vector2 &p_ceiling_normal, float p_max_ceiling_angle, float p_slope_stop_min_velocity, int p_max_bounces)

but I think @reduz means something like this
move_and_slide(const Vector2 &p_linear_velocity, const Vector2 &p_floor_normal, float p_max_floor_angle, float p_max_ceiling_angle, float p_slope_stop_min_velocity, int p_max_bounces)

(we can still break compatibility, so it should be fine to change the ordering of parameters to a more sensible one)

Merging that fix as a first step. Further API enhancements could come in another commit.


[Catalog] Create "related" pattern attribute

Current State of the Meshery.io site
Each pattern modal will show related patterns, but these are hard-coded, self-references.
Desired State of the Meshery.io site
The json data model needs to evolve to include a related attribute, so that pattern ids can be listed in an array.

Contributor Resources
The meshery.io website uses Jekyll and GitHub Pages. Site content is found under the master branch.

See the Contributing to Meshery.io Website section of the readme.md and other contributing instructions, too.
See Meshery site designs in this Figma designfile. Fill-in the Layer5 Community Member Form and join the Layer5 Community Slack for access.

Working on it!!

// @YashKamboj

@asubedy will you please knock this out?


Only string is supported as partition key in azure-spring-data-cosmos

https://github.com/microsoft/spring-data-cosmosdb/issues/295

This is done.


Use ‘redacted’ text style as a placeholder for missing content

Apple has a standard way of represnting misisng or loading placeholder information in widgets as a sort of blocked 'redacted’ region. It might be visually cleaner to use this in the workflow cells and widgets when we don't have complete information, instead of simply using ‘-‘.

Apaprently it's actually called ‘redacted’ (https://www.hackingwithswift.com/quick-start/swiftui/how-to-mark-content-as-a-placeholder-using-redacted). 🫠


Add SubUnit support

SubUnit is a streaming protocol for test results.
Format specification: https://pypi.python.org/pypi/python-subunit

@ligurio thanks!


urllib3 problem

Hello. When I try to activate my Google Credentials, this is what I get.
raise RuntimeError('Requests dependency 'urllib3' must be version >= 1.21.1, < 1.22!')
RuntimeError: Requests dependency 'urllib3' must be version >= 1.21.1, < 1.22!
I tried to upgrade it to 1.21.1, but failed.
Thank you for your help.

same issue... though part of error also says following :
"/usr/lib/python3.4/importlib/util.py"
but my python is 2.7.9 not sure if pip installs are version dependent

try runing the following @mcosti
 sudo /opt/AlexaPi/env/bin/python -m pip install -I urllib3==1.21.1
fixed it for me.. went into the install script and saw that it created an env so have to install into that env

This worked. Thank you.

Oh. Actually, it worked on the Authentication. But on this:
sudo bash /opt/AlexaPi/src/scripts/install_assistant.sh
Same error.

yea that reruns all the installation packages so you need to rerun the command I said, and you only need to run the authentication one (it comes out when you run the command you said). instead of the whole installation

Sorry, I've been out of town for some days - Glad you found the solution, I'll include this into the installer script!


fix: align npm packages to coral-xyz

Migrate @project-serum to @coral-xyz.
The tests/examples should be fine coz it looks up the package from the relative path, rather than npmjs.org. If anyone of them isn't, I guess we'll find out when the tests run!
I did have to do yarn install in tests and examples to update the yarn.lock files. I see it pulling a few more dependencies in. They may have been slightly out of date. Probably worth a review of what's coming in by a core dev:

https://github.com/coral-xyz/anchor/pull/1989/files#diff-f103d08e23bb7039cda171292bac2ea809386ea9ddf16f61bdb70708581e9699
https://github.com/coral-xyz/anchor/pull/1989/files#diff-db39095f32428d360c52df9785fd8a41cf1e04e2391549cc47ca7fc2ad71b38d

@armaniferrante, there is a circular dependency in test-anchor-init test. anchor init automatically does a yarn insall so the npm package has to be published before it can succeed. I thought we can disable it, merge, publish, and I'll do a subsequent PR to enable it.
If that's not cool, lemme know what you wanna do. I made the test disable thing a separate commit, easy to revert.

I've got the Anchor book changes I can PR, once we have an npm package published.

I think this may have caused too much friction and now it is way out-of-date too.

Sorry about that. This must have gotten buried. Would be good to get this in. @Henry-E


Flutter Web: video_player  videos are not playing on Android Chrome mobile browser

mobile  chrome web : error description : PlatformException(MEDIA_ERR_SRC_NOT_SUPPORTED, PIPELINE_ERROR_EXTERNAL_RENDERER_FAILED), The video has been found to be unsuitable (missing or in a format not supported by your browser)., null) ,
video player not intializing it's throwing null  how to resolve these issue   ?

Is it working when using this plugin or not working when using this plugin?

its is working desktop chrome and not working in mobile chrome web

Are you here, I am very anxious

Bro  are you here ?

Hey I am working right now. Will check this issue on weekends

ok sure waiting for reply :)

can you share the video url

Sorry  it is secure play url(m3u8) from backend lot of security behind it

How to test then :/

u can use these url
https://xvod.otsdev.icorei.com/videos/stream/demo/2022/1/13/v/eeb6a26b-75e1-4898-bb5b-2b9f7fe1465c/video/playlist.m3u8?Policy=eyJTdGF0ZW1lbnQiOiBbeyJSZXNvdXJjZSI6Imh0dHBzOi8veHZvZC5vdHNkZXYuaWNvcmVpLmNvbS92aWRlb3Mvc3RyZWFtL2RlbW8vMjAyMi8xLzEzL3YvZWViNmEyNmItNzVlMS00ODk4LWJiNWItMmI5ZjdmZTE0NjVjL3ZpZGVvL3BsYXlsaXN0Lm0zdTgiLCJDb25kaXRpb24iOnsiRGF0ZUxlc3NUaGFuIjp7IkFXUzpFcG9jaFRpbWUiOjE2Nzc2MDI3Njl9LCJEYXRlR3JlYXRlclRoYW4iOnsiQVdTOkVwb2NoVGltZSI6MTY3NzU4NDc2OX19fV19&Signature=R50KxAIhglPTiawBBQZINA11Lw9-UQSixDKyDRhpswlDg86BOjm084PdriEd4vVNUyWUaIMp4vDKFOJBUk51oAfhlOzYZl5FUjZnMNelv-HRA~7yBK0B~9aP-dLarjBWbwx-yhtZ7JWPEv3GebLj9kqv8XdqMO2vDUpX8GV01VFsNUCM4DWZ4LDtC1nXdA6alG44Sg89z~8C6MwidxxTlfsRMGVhs44LIfkQyw4c-AS5DhgxEfphun7kgZ5tfSVp5ol8Q6HxPI5TWxkJAZxUwCDItpzxEij~Cr2h9HdBl2~gFrFHb7hWx5jv54hQi5~v11QYJMx-BzxVHygMoYG4kA__&Key-Pair-Id=APKAJW7LPU6NRWPT2XKA

try to test in mobile device chrome :)

can you disable CORS for this url. Not able to test it on chrome mobile

use these below  code (pass headers like these) you will get platform exception error like above screenshot
var headers = {
"useCookies": "true",
"X-Authorization":  "Bearer eyJvcmdJZCI6ImRlbW8iLCJpZCI6IjEwODhjYzkwLWM2OTEtNGRmMi1hNjdhLTJhMTMwMDNjNzY3NyIsImlzUmVtb3RlIjpmYWxzZSwic2Vzc2lvblJlc3RyaWMiOiJTSU5HTEUiLCJVQSI6IjdhYzRhOGIzMWQ0N2RjMzU1YzViNzZlZjBjOGQ4MmUwIiwiYWxnIjoiSFM1MTIifQ.eyJzdWIiOiJ3aGF0ZXZlckBzaGFya2xhc2Vycy5jb20iLCJzY29wZXMiOlsiUk9MRV9TVFVERU5UIl0sImlzcyI6ImlDb3JlIElubm92YXRpb24gUHZ0IEx0ZCIsImlhdCI6MTY3NzY0OTAzOCwiZXhwIjoxNjc3Njg1MDM4fQ.JaCFHixPvtj6EzEvbKuXzpsstGJRbDu2i1R1rwg3q0Ixi8PrDXFlptOqtdNFpCqrdreWwHJQJX4BuQxlap9uKg",
};
VideoPlayerController.network('https://xvod.otsdev.icorei.com/videos/stream/demo/2023/1/14/v/36c35b8f-a853-425b-b7a3-fc38a8275d5f/video/playlist.m3u8?Policy=eyJTdGF0ZW1lbnQiOiBbeyJSZXNvdXJjZSI6Imh0dHBzOi8veHZvZC5vdHNkZXYuaWNvcmVpLmNvbS92aWRlb3Mvc3RyZWFtL2RlbW8vMjAyMy8xLzE0L3YvMzZjMzViOGYtYTg1My00MjViLWI3YTMtZmMzOGE4Mjc1ZDVmL3ZpZGVvL3BsYXlsaXN0Lm0zdTgiLCJDb25kaXRpb24iOnsiRGF0ZUxlc3NUaGFuIjp7IkFXUzpFcG9jaFRpbWUiOjE2Nzc2NjYwMTN9LCJEYXRlR3JlYXRlclRoYW4iOnsiQVdTOkVwb2NoVGltZSI6MTY3NzY0ODAxM319fV19&Signature=Scn-ZbMdzyTNCSC1dIYN2mIdYmYK7f0Z4ye0-St6r6qSR7gmA9XEKXInZAoSuDX3qGr9O0LOs0KzYomZo5vZN70dA3ryk~vW09e8GXzuuOsEGm4PXY1xt6A698TFQhUNgVqKAx8ZGzzQiorfNOwY~DnR91NoWy5TT1-9Y5aLd56ckigD2lBJp-Df854WHOXCS3xoh2bWXcTvXKBCJ3a3C0kufB9khM2-UPu8t8sLonxO~vNFWMacuCqmjoCQ1-ZCeKzE4NFquApSPmnb~e9fPT12~5Idp~uyNhJrSkJOa3tiYXTh--mMcHx4UbKxLnBRHaTspxv9gL07Dz4ZdIenqg__&Key-Pair-Id=APKAJW7LPU6NRWPT2XKA',
httpHeaders: headers);

url  not work on your local host

my url not working in firefox , opera , edge mobile browsers also not only in chrome it throwing same error in above screenshot.

@shashikiran918 I am also facing the same issue. The streaming works fine in desktop browsers, but not in android chrome. Did you find any solution?
@balvinderz How can I help to resolve this problem?

@balvinderz I think I somewhat found the root cause. The problem is, android chrome uses native HLS library for playback. If we force the library not to take adroid native HLS support, the player works. Can we make this a configurable option? I made a small change in the code and now it works fine on android devices as well

can u post full code i didn't understand.

I think the problem is canPlayHlsNatively() method:
_videoElement.canPlayType("application/vnd.apple.mpegurl") != "";

As far as I understand, it should be:
_videoElement.canPlayType("application/vnd.apple.mpegurl") == "probably";

Referring to MDN canPlayType can also return "maybe", and that is actually happening here.

@soorajlv thanks for resolving @sgbai78's issue but we can't add a config parameter for this since we are extending video_player_platform_interface and we cannot make changes there just for this library.

On Android Firefox the browser thinks it can play hls natively
bool canPlayHlsNatively() {
    bool canPlayHls = false;
    try {
      final String canPlayType = _videoElement.canPlayType('application/vnd.apple.mpegurl');
      canPlayHls =
          canPlayType != '';
    } catch (e) {}
    return canPlayHls;
  }

The canPlayType returns "maybe", which is causing videos not to play.

I had the same problem in version 1.2.2
I returned to version 1.2.1!
video_player_web_hls: 1.2.1

video_player_web_hls:
  git:
    url: https://github.com/mbfakourii/video_player_web_hls.git
    ref: fix_hls_fallback


Support multi jar release

We have support in mybatis for jdk 16+.  Due to this and consideration each maintainer my be using different jdks at same time, we run risks of releasing mixed release content by mistake as was such the case with 3.5.13.  By luck that was not occurring before but likelihood is very high now.  We should review our current logic and restructure into a multi jar release.  That does mean we should further drop lower jdk build support which is fine.  If we need to, we could go as far as having simple GH-Actions showing usage at jdk 8 and above.  Or maybe even explore new dev contains github offers to ensure we are not losing anything.  Should be safe though, we already dropped jdk 8 from builds.

I'll take a look into what needs to occur here, I've seen this in many projects now such as java metro so it shouldn't be that difficult to setup.  At the moment, at least from mybatis downstream modules, none seem to have any issues with how 3.5.13 was released and there may not really be.  Will monitor the issue regardless and this ticket can further serve as notice to users searching in case of issues encountered in currently release.


Create DB Connection #34

@all-contributors please add @jakebolam for infrastructure, tests and code

@all-contributors please add @astaStaria99  for infrastructure, tests and code


Yaoi Fan Club age verification error

Source information
Yaoi Fan Club 1.4.9
Source language
Portuguese
Steps to reproduce
Open WebView
Error appears
Expected behavior
There should be any problem
Actual behavior
The site is inaccessible through WebView
Mihon/Tachiyomi version
0.16.5
Android version
Android 13
Other details
No response
Acknowledgements

[X] I have searched the existing issues and this is a new ticket, NOT a duplicate or related to another open or closed issue.
[X] I have written a short but informative title.
[X] I have updated the app to version 0.15.3.
[X] I have updated all installed extensions.
[X] I have tried the troubleshooting guide.
[X] If this is an issue with the app itself, I should be opening an issue in the app repository.
[X] I will fill out all of the requested information in this form.

It's not a bug. It's a feature of the blog.


06/29/2018 04:05 : Create Pull Request for branch master -> prTesting1_2018062904

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

split/updateTestCon1.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


feat: c# language

should closes #12

@ronnygunawan @vmasdani kalo ada waktu, boleh tolong di review biar nggak salah tebak ke C# om-om sekalian🙏

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@051d272). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             master       #25   +/-   ##
==========================================
  Coverage          ?   100.00%
==========================================
  Files             ?        17
  Lines             ?       611
  Branches          ?        23
==========================================
  Hits              ?       611
  Misses            ?         0
  Partials          ?         0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 051d272...af79d04. Read the comment docs.

ok, gonna merge this for now as I'll refactor the repository to be more sane


no 3.3-3.0.0-M2 release artifact?

There was a 3.3-3.0.0-M1 in https://github.com/com-lihaoyi/Ammonite/releases/tag/3.0.0-M1 but there is no 3.3-3.0.0-M2 in https://github.com/com-lihaoyi/Ammonite/releases/tag/3.0.0-M2 - is that intentional?

Thanks for letting us know. Due to https://github.com/com-lihaoyi/Ammonite/issues/1491, I had to manually fix this release and forgot to renamed that file.


bump to Python 3.11.0

had to do the following adjustments:

use a newer pylint version that supports the new Python version
fix the new lint warnings
use a new base image that should be minimized and yet has Python 3.11 pre-installed

/cc @adriengentil @omertuc


Go login

This PR implements api/1.3/user/login in go. It follows the same login flow as perl (except the token flow):
check the local user password using scrypt
check the local user password using hash1
if ldap is configured check password using ldap
if any match the user is logged in.

A next step will be persisting a single connection to ldap for reuse with a singleton or similar implementation.

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/incubator-trafficcontrol-PR/1237/
Test PASSed.

Deployment considerations?
Upgrade process (postinstall)
Startup (systemd)

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/incubator-trafficcontrol-PR/1263/
Test PASSed.

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/incubator-trafficcontrol-PR/1264/
Test FAILed.

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/incubator-trafficcontrol-PR/1265/
Test FAILed.

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/incubator-trafficcontrol-PR/1273/
Test PASSed.

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/incubator-trafficcontrol-PR/1275/
Test PASSed.

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/incubator-trafficcontrol-PR/1296/
Test PASSed.

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/incubator-trafficcontrol-PR/1297/
Test FAILed.

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/incubator-trafficcontrol-PR/1298/
Test PASSed.

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/incubator-trafficcontrol-PR/1365/
Test PASSed.

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/incubator-trafficcontrol-PR/1369/
Test PASSed.

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/incubator-trafficcontrol-PR/1496/
Test PASSed.

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/incubator-trafficcontrol-PR/1526/
Test PASSed.

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/incubator-trafficcontrol-PR/1527/
Test PASSed.

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/incubator-trafficcontrol-PR/1530/
Test PASSed.

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/incubator-trafficcontrol-PR/1546/
Test PASSed.

The LDAP timeout should have a reasonable default. It's defaulting to 0 now, and my LDAP (which is probably misconfigured) is hanging indefinitely. I'd suggest something like 10 seconds, if it isn't set in the config.

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/incubator-trafficcontrol-PR/1575/
Test PASSed.

Looks good!
Tested, everything works

loads ldap config from existing config location
using non-ldap password works
using ldap password works
ldap users without TO users are not allowed to log in
verified all of Dan's comments have been fixed


Issue 460 - create saved searches and alerts for canary feature

Added the following alerts and searches for canary:

search for testflight records with aggregation to graph elapsed time
alert for all canary records with result != true
search for testflight with a specific uuid (accept uuid as a parameter)

Current coverage is 68.58%

Merging #465 into develop will decrease coverage by -0.04% as of 7785c44

@@            develop    #465   diff @@
=======================================
  Files            63      63
  Stmts          2798    2798
  Branches          0       0
  Methods           0       0
=======================================
- Hit            1920    1919     -1
  Partial           0       0
- Missed          878     879     +1

Review entire Coverage Diff as of 7785c44

Uncovered Suggestions

+0.61% via goldstone/views.py#30...46
+0.57% via ...stone/drfes/views.py#134...149
+0.39% via ...tone/drfes/models.py#165...175
See 7 more...

Powered by Codecov. Updated on successful CI builds.

👍 merge it


Snapshot Holders Broken?

Has any logic around fetching holders recently changed for cmV2?
Running metaboss snapshot holders seems to always return with a timeout.
Error: error sending request for url (***): operation timed out

Switching private rpc providers does not seem to change the outcome either.
Any help would be appreciated and thank you!

also running into this issue right now. i'm trying to fetch holders by update authority. also using a private rpc

Same issue here, I tested with 6 differents RPC, and with old/latest build from Metaboss, can't snapshot anything.
Error: error sending request for url (***): operation timed out

@dobbinsi @Lobix300 I'm going to close this. I missed the option to increase timeouts. See below
metaboss snapshot holders --creator <cndyID> --v2 --output <dir>  -T 600

I was able to get it to return with the snapshot

@dobbinsi @Lobix300 I'm going to close this. I missed the option to increase timeouts. See below
metaboss snapshot holders --creator <cndyID> --v2 --output <dir> -T 600

This is the correct answer, getProgramAccounts calls just take a long time these days so you have to manually set a long timeout.


Update passport-azure-ad to<EMAIL_ADDRESS>

When upgrading async for passport-azure-ad, cache-manager should be bumped too to stay up to date with its async dependency.
<EMAIL_ADDRESS>microsoft-authentication-library-for-js/maintenance/passport-azure-ad
├──<EMAIL_ADDRESS>├─┬<EMAIL_ADDRESS>│ └──<EMAIL_ADDRESS><-- Vulnerable
....

Would be mega grateful to have this bumped before v4.3.2 is pushed to npmjs.

@kplindegaard thanks for the Pull Request, we will review it and provide feedback if necessary!

FYI This version of cache-manager previously broke passport-azure-ad: https://github.com/AzureAD/passport-azure-ad/issues/471

Closing in favor of #4781 which addresses breaking changes in cache-manager@3, thanks!


Add L2 field to ChainInfo

A new field was added in the config-service to describe if the chain is a Layer 2 chain. This field should be consumed and exposed to the clients. See https://github.com/gnosis/safe-config-service/pull/225
@gnosis/safe-web

Available on staging: https://safe-client.staging.gnosisdev.com/v1/chains

Looks like it's still cached or something, I can't see the l2 flag.

Looks like it's still cached or something, I can't see the l2 flag.

Should be available now.

It works, thank you @fmrsabino ✅


Finished migration from if to unless nil

Unless I missed something, the commit f8cd3d5af557704fd43a02c1b35251a3a31a4150 was only partial, wrecking havoc upon my servers

It seems a find and replace was done for if node.  All of the ones that were missed have two spaces between if  and node.

We are experiencing the same issue described in https://github.com/chef-cookbooks/yum-mysql-community/issues/7 and this does seem to be the cause of the issue. We had to lock down to the previous version for it to work

The double spacing probably won't happen again because the rubocop will stop double spacing from happening


Adds tag field to minikubeDockerBuild task with default.

Feature 2 of #14 .

Closed pending design for new way of building with the Minikube Docker environment.


[css/scss] Go to definition for css/sass @import

Feature Request
Support go to definition on css@imports
@import url(./otherFile.css)

and sass style imports:
@import 'otherFile.css'

Go to definition  on otherFile.cssshould try to open otherFile.css in the workspace

I've started using VSCode after using WebStorm for quite some time, and this is something I'm really missing. For example, I used to be able to Ctrl/Cmd + Click on a SASS mixin and it would take me to the definition in WebStorm. The import issue also applies to HTML.

+1

This is the only one thing keeping me from using @code, too. Still using WebStorm...

@antenando exactly!

This feature is dearly missed. Please implement.

It is so dearly missed by myself as well. VScode seems a particularly popular choice for big front-end projects, so this would have tons of use.

One of my projects is growing to a point where I need to have this. 😕

Would be an excellent addition, especially if supported in the same manner as JS imports where aliasing can be configured in jsconfig.json or something similar.

Is there any vscode plugin solving the problem ?!

I’d also love this to have! A reason for me to stay with Webstorm!

Would it be possible to also support css-module import and composes syntax?
import otherClass from "./otherFile.css";

.newClass {
    composes: differentClass from "./otherFile.css";
}


Series.str should only be defined for strings, not all Series with dtype=object

#9322 will make Series.str raise an exception if it is accessed on Series instances with non-object dtype. In principle, the exception should really be raised for any non-strictly string-like data, but that's not practical until pandas has a true string dtype to use (currently we abuse np.object_ for this purpose).

closing in favor of #13877


[dav1d] Update to 0.8.2

Update dav1d from 0.8.1 to 0.8.2.

Done! Feel free to squash when merging.


Protocolv2 DesignMode

Protocol changes related to DesignMode.
New data structure for protocol related information.
Fixed and added the unit tests.

@singhsarab,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot

Related to #396

@dotnet-bot test Windows Debug please

@dotnet-bot test this please


Do not run OpenML tests; buggy with scikit-learn<0.20.1

Coverage decreased (-0.2%) to 99.775% when pulling d1de08341507e49e47ce167ad59d780c7e57f082 on bugfix/openml-travis into 76b2b190fa0eb478c8898016e553a0ad86e890e4 on develop.


How to use the crawl overview plugin programatically?

I am using the Advanced example given in the examples folder. I added a separate line
builder.addPlugin(new CrawlOverview());. On running the example, it results in error
16:37:31.908 [main] ERROR - Plugin Crawl overview plugin errored while running. Directory must be empty
java.lang.IllegalArgumentException: Directory must be empty

Your output-folder seems to exist already.
maybe do s.t. like this to make sure that a new folder is created each time
builder.setOutputDirectory(new File(new SimpleDateFormat("MM.dd-HH_mm_ss").format(new Date())));

I resolved it a long time ago but forgot to close this issue. Thanks for the input though! :)


[Bug]:  "Agent encountered an error." when starting start.sh on MacOS

Is there an existing issue for the same bug?

[X] I have checked the troubleshooting document at https://opendevin.github.io/OpenDevin/modules/usage/troubleshooting
[X] I have checked the existing issues.

Describe the bug
getting a "Agent encountered an error." message on my first try.
created the start.sh file and started the docker engine, i also have entered the right configuration settings. (screenshot attached)
Current Version
ghcr.io/opendevin/opendevin:0.5

Installation and Configuration
OpenAi key,
chmod +x start.sh
./start.sh

Model and Agent
Model : gpt-3.5-turbo
Agnet : CodeActAgent
Reproduction Steps
No response
Logs, Errors, Screenshots, and Additional Context

Can you provide the whole error log?
docker logs container_id

i have the same problem, here is my example:
`STEP 0
19:33:29 - PLAN
build a simple hello world
Give Feedback / Get Help: https://github.com/BerriAI/litellm/issues/new
LiteLLM.Info: If you need to debug this error, use `litellm.set_verbose=True'.
Provider List: https://docs.litellm.ai/docs/providers
19:33:29 - opendevin:ERROR: agent_controller.py:147 - Error in loop
Traceback (most recent call last):
File "/app/.venv/lib/python3.12/site-packages/litellm/llms/azure.py", line 175, in completion
if "gateway.ai.cloudflare.com" in api_base:
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
TypeError: argument of type 'NoneType' is not iterable
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "/app/.venv/lib/python3.12/site-packages/litellm/main.py", line 882, in completion
response = azure_chat_completions.completion(
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/app/.venv/lib/python3.12/site-packages/litellm/llms/azure.py", line 316, in completion
raise AzureOpenAIError(status_code=500, message=str(e))
litellm.llms.azure.AzureOpenAIError: argument of type 'NoneType' is not iterable
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "/app/opendevin/controller/agent_controller.py", line 142, in _run
finished = await self.step(i)
^^^^^^^^^^^^^^^^^^
File "/app/opendevin/controller/agent_controller.py", line 256, in step
action = self.agent.step(self.state)
^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/app/agenthub/codeact_agent/codeact_agent.py", line 223, in step
response = self.llm.completion(
^^^^^^^^^^^^^^^^^^^^
File "/app/.venv/lib/python3.12/site-packages/tenacity/init.py", line 330, in wrapped_f
return self(f, *args, **kw)
^^^^^^^^^^^^^^^^^^^^
File "/app/.venv/lib/python3.12/site-packages/tenacity/init.py", line 467, in call
do = self.iter(retry_state=retry_state)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/app/.venv/lib/python3.12/site-packages/tenacity/init.py", line 368, in iter
result = action(retry_state)
^^^^^^^^^^^^^^^^^^^
File "/app/.venv/lib/python3.12/site-packages/tenacity/init.py", line 390, in
self._add_action_func(lambda rs: rs.outcome.result())
^^^^^^^^^^^^^^^^^^^
File "/usr/local/lib/python3.12/concurrent/futures/_base.py", line 449, in result
return self.__get_result()
^^^^^^^^^^^^^^^^^^^
File "/usr/local/lib/python3.12/concurrent/futures/_base.py", line 401, in __get_result
raise self._exception
File "/app/.venv/lib/python3.12/site-packages/tenacity/init.py", line 470, in call
result = fn(*args, **kwargs)
^^^^^^^^^^^^^^^^^^^
File "/app/opendevin/llm/llm.py", line 188, in wrapper
resp = completion_unwrapped(*args, **kwargs)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/app/.venv/lib/python3.12/site-packages/litellm/utils.py", line 3222, in wrapper
raise e
File "/app/.venv/lib/python3.12/site-packages/litellm/utils.py", line 3116, in wrapper
result = original_function(*args, **kwargs)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/app/.venv/lib/python3.12/site-packages/litellm/main.py", line 2226, in completion
raise exception_type(
^^^^^^^^^^^^^^^
File "/app/.venv/lib/python3.12/site-packages/litellm/utils.py", line 9233, in exception_type
raise e
File "/app/.venv/lib/python3.12/site-packages/litellm/utils.py", line 9170, in exception_type
raise APIError(
litellm.exceptions.APIError: AzureException - argument of type 'NoneType' is not iterable
Model: gpt-35-turbo
Messages: [{'role': 'system', 'content': 'A chat between a curious user and an artificial intelligence assista
19:33:29 - opendevin:INFO: agent_controller.py:190 - Setting agent(CodeActAgent) state from AgentState.RUNNING to AgentState.ERROR
19:33:30 - opendevin:INFO: browser_env.py:51 - Browser env started.
(.venv) 958070@US-F5W07DN636-CTS GitHub % `

i have the same problem, here is my example:
  File "/app/.venv/lib/python3.12/site-packages/litellm/llms/azure.py", line 175, in completion
    if "gateway.ai.cloudflare.com" in api_base:

This doesn't seem to be the current litellm version.
If you are using Cloudflare, this might also be of interest:
https://developers.cloudflare.com/workers-ai/configuration/open-ai-compatibility/

@arasnuri can you try the latest main tag and see if this resolves your issue?

Going to close this. Please try out the new 0.7 tag or main and open a new issue if you encounter one.


[FEATURE REQUEST] Export matches' metadata to text file

I love https://github.com/aykamko/tag, but it's hacky, buggy and unmaintained. If ag adds a --export-matches somefile.txt option, so that all matches are numbered like this:

And their metadata is stored in somefile.txt:
Match i: FILE_PATH LINE_NUMBER COLUMN_NUMBER

This way we can write a shell function to use somefile.txt to easily open our editor of choice on the desired match.

I have since noticed that dear Emacs has great integration with ag (Spacemacs does at least.)
But I still feel adding this feature toag makes more sense than reimplementing a parser in editors (if that's how those Emacs packages do it.).


Shutdown with grace time for clients

When shutting down icalm should wait (for a gracetime) for clients to disconnect.

is implemented via #12


Update networkperf test suite to support windows images

It's weird how the network performance test results don't reach anywhere close to the targets, especially in the non-Tier1 network tests (specifically for Windows)

/hold

Seems like mostly a windows2016 issue.

/unhold

/lgtm


Fix eslint errors

Linting currently fails with the following error:
Error: eslint-config-vaffel:
        Configuration for rule "indent" is invalid:
        Value "data["2"].SwitchCase" has additional properties.

Upgrading eslint and eslint-config-vaffel resolves it. This PR also adds some quotes for consistency and resolves quote-props errors.

Thanks!


0.9.1

What happen?
We deploy the k8s environment on 3 cloud hosts, using sealer version 0.9.1 to execute, the execution script is: sealer run docker.io/sealerio/kubernetes:v1.22.15 --masters <IP_ADDRESS> --nodes <IP_ADDRESS>, <IP_ADDRESS> --passwd vcs, an error occurred
use journalctl -xe ：
-- Subject: Unit kubelet.service has finished shutting down
-- Defined-By: systemd
-- Support: http://lists.freedesktop.org/mailman/listinfo/systemd-devel
-- Unit kubelet.service has finished shutting down.
Feb 24 09:45:02 dev10 systemd[1]: Started kubelet: The Kubernetes Node Agent.
-- Subject: Unit kubelet.service has finished start-up
-- Defined-By: systemd
-- Support: http://lists.freedesktop.org/mailman/listinfo/systemd-devel
-- Unit kubelet.service has finished starting up.
-- The start-up result is done.
Feb 24 09:45:02 dev10 systemd[12359]: Failed at step EXEC spawning /usr/bin/kubelet: No such file or directory
-- Subject: Process /usr/bin/kubelet could not be executed
-- Defined-By: systemd
-- Support: http://lists.freedesktop.org/mailman/listinfo/systemd-devel
-- The process /usr/bin/kubelet could not be executed and failed.
-- The error number returned by this process is 2.
Feb 24 09:45:02 dev10 systemd[1]: kubelet.service: main process exited, code=exited, status=203/EXEC
Feb 24 09:45:02 dev10 systemd[1]: Unit kubelet.service entered failed state.
Feb 24 09:45:02 dev10 systemd[1]: kubelet.service failed.
Feb 24 09:45:12 dev10 systemd[1]: kubelet.service holdoff time over, scheduling restart.
Feb 24 09:45:12 dev10 systemd[1]: Stopped kubelet: The Kubernetes Node Agent.
Relevant log output?
+ chmod a+x /usr/bin
+ chmod a+x /usr/bin/docker
+ chmod a+x /usr/bin/dockerd
+ systemctl enable docker.service
+ systemctl restart docker.service
+ cp /var/lib/sealer/data/my-cluster/rootfs/scripts/../etc/daemon.json /etc/docker
+ [[ -n '' ]]
+ disable_selinux
+ '[' -s /etc/selinux/config ']'
+ grep SELINUX=enforcing /etc/selinux/config
+ systemctl daemon-reload
+ systemctl restart docker.service
Job for docker.service failed because the control process exited with error code. See "systemctl status docker.service" and "journalctl -xe" for details.
2023-02-24 09:57:40 [INFO] [remove_container.go:66] 21e3e5b75aa04c3341699be7ee0ae1d3187b74101f97217b76e7084642e8b3b6

What you expected to happen?
No response
How to reproduce it (as minimally and precisely as possible)?
No response
Anything else we need to know?
No response
What is the version of Sealer you using?
No response
What is your OS environment?
centos7.9
What is the Kernel version?
Linux dev10 5.4.232-1.el7.elrepo.x86_64 #1 SMP Tue Feb 21 16:18:52 EST 2023 x86_64 x86_64 x86_64 GNU/Linux
Other environment you want to tell us?

Cloud provider or hardware configuration:
Install tools:
Others:

{
"experimental": true,
"oom-score-adjust": -1000,
"max-concurrent-downloads": 20,
"log-driver": "json-file",
"log-level": "warn",
"log-opts": {
"max-size": "10m",
"max-file": "3"
},
"exec-opts": [
"native.cgroupdriver=systemd"
],
"insecure-registries": ["<IP_ADDRESS>/0", "::/0"],
"storage-driver": "overlay2",
"storage-opts":["overlay2.override_kernel_check=true"],
"live-restore": true,
"data-root": "/var/lib/docker"
}
~
"/etc/docker/daemon.json" [noeol] 19L, 457C

Could it be a "live-restore": true question? It should be false

● docker.service - Docker Application Container Engine
Loaded: loaded (/usr/lib/systemd/system/docker.service; enabled; vendor preset: disabled)
Active: failed (Result: exit-code) since Fri 2023-02-24 11:29:03 CST; 23s ago
Docs: https://docs.docker.com
Process: 15447 ExecStart=/usr/bin/dockerd (code=exited, status=1/FAILURE)
Main PID: 15447 (code=exited, status=1/FAILURE)
Feb 24 11:29:03 dev10 dockerd[15447]: time="2023-02-24T11:29:03.383726524+08:00" level=warning msg="Running experimental build"
Feb 24 11:29:03 dev10 dockerd[15447]: time="2023-02-24T11:29:03.409917150+08:00" level=warning msg="failed to load plugin io.containerd.snapshotter.v1.devmapper" error="devmapper not configured"
Feb 24 11:29:03 dev10 dockerd[15447]: time="2023-02-24T11:29:03.411002328+08:00" level=warning msg="could not use snapshotter devmapper in metadata plugin" error="devmapper not configured"
Feb 24 11:29:03 dev10 dockerd[15447]: time="2023-02-24T11:29:03.429433391+08:00" level=warning msg="Your kernel does not support cgroup blkio weight"
Feb 24 11:29:03 dev10 dockerd[15447]: time="2023-02-24T11:29:03.429451596+08:00" level=warning msg="Your kernel does not support cgroup blkio weight_device"
Feb 24 11:29:03 dev10 dockerd[15447]: time="2023-02-24T11:29:03.515372700+08:00" level=fatal msg="Error starting cluster component: --live-restore daemon configuration is incompatible with swarm mode"
Feb 24 11:29:03 dev10 systemd[1]: docker.service: main process exited, code=exited, status=1/FAILURE
Feb 24 11:29:03 dev10 systemd[1]: Failed to start Docker Application Container Engine.
Feb 24 11:29:03 dev10 systemd[1]: Unit docker.service entered failed state.
Feb 24 11:29:03 dev10 systemd[1]: docker.service failed.

hi @fi-ecavc , pls use our official image list here:  http://sealer.cool/docs/sealer-images/cluster-images.html#k8s-cluster-image-list.   if you have any questions, feel free to contact us .

sealer run docker.io/sealerio/kubernetes:v1.22.15   --masters <IP_ADDRESS>    --nodes <IP_ADDRESS>,<IP_ADDRESS>    --passwd vcs
uname -a
Linux dev10 5.4.232-1.el7.elrepo.x86_64 #1 SMP Tue Feb 21 16:18:52 EST 2023 x86_64 x86_64 x86_64 GNU/Linux

hi @fi-ecavc , pls use our official image list here: http://sealer.cool/docs/sealer-images/cluster-images.html#k8s-cluster-image-list. if you have any questions, feel free to contact us .
warning msg="Your kernel does not support cgroup blkio weight"。Is there something wrong with our kernel?
fatal msg="Error starting cluster component: --live-restore daemon configuration is incompatible with swarm mode"，Does Seaver's communication mechanism use Swarm Mode? The --live-restore parameter is contradictory, and the hint is already clear.


ClearML Colab Urllib3 problem

Colab notebook for clearml-agent raises error when a new task is submitted due to the new release (2.0.2) of Urllib3 library.

Hi @dberkerdem , ClearML SDK v1.10.4rc1 should fix this issue. An official version will be released next week.

ClearML SDK v1.10.4rc1 works great, thank you!


Deprecation notice?

Should this plugin be deprecated, in favor of the "promise new Promise" approach thats recommended in the docs?

This is a much more declarative way to customize the URL in runtime. When using "promise new Promise", I have to copy and modify code into every project which is an "ugly" solution to me.

I agree. There probably is a good reason tho I guess.
Personally I've created some utils for dealing with stuff like this, and sharing it in an npm package on our internal npm feed, so that I don't end up copy-pasting this around.

@einarq, yes, that's a good solution.


Problems following the quick start guide

Description

Using the official quickstart guide, I followed the steps and the operator pod keeps restarting, outputting this to the logs
{"level":"fatal","ts":"2024-09-13T15:46:45Z","msg":"open /etc/config/matchingRules.json: no such file or directory","error":"open /etc/config/matchingRules.json: no such file or directory"}

Surely there's something that I'm missing, but the guide specifies that it should just work.
For example, running the command
kubectl get vulnerabilitysummaries

doesnt output anything.
Environment
OS: Container-Optimized OS from Google
Version: v1.29.7-gke.1104000
Steps To Reproduce

helm repo add kubescape https://kubescape.github.io/helm-charts/ ; helm repo update ; helm upgrade --install kubescape kubescape/kubescape-operator -n kubescape --create-namespace --set clusterName=kubectl config current-context --set capabilities.continuousScan=enable

Let every pod settle and check the status of the operator pod

Expected behavior

The operator pod should work without problems and scan the cluster
Actual Behavior

Operator pod keeps restarting

If you remove --set capabilities.continuousScan=enable, this setting seems to have been removed recently but the docs haven't been updated yet


k_thread_foreach in kernel shell commands can trigger kernel panic

In a minimal sample, where k_thread_foreach is executed regularly, it is possible to trigger a kernel panic when one issues the shell command kernel threads.
main.c:
static void thread_callback(const struct k_thread *thread, void *user_data)
{
}

int main(void)
{
    while (true) {
        k_sleep(K_MSEC(10));
        k_thread_foreach(thread_callback, NULL);
    }
}

prj.conf:
CONFIG_DEBUG_OPTIMIZATIONS=y
CONFIG_LOG=y
CONFIG_ASAN=y
CONFIG_SHELL=y
CONFIG_THREAD_MONITOR=y
CONFIG_THREAD_RUNTIME_STATS=y
CONFIG_ASSERT=y

shell:
uart:~$ kernel threads
Scheduler: 86 since last call
Threads:
0x20010c40 sysworkq
    options: 0x0, priority: -1 timeout: 0
    state: pending, entry: ba9

ASSERTION FAIL [z_spin_lock_valid(l)] @ WEST_TOPDIR/zephyr/include/zephyr/spinlock.h:136
    Invalid spinlock 0x20011264
[00:00:06.353,000] <err> os: r0/a1:  0x00000004  r1/a2:  0x00000088  r2/a3:  0x00000001
[00:00:06.353,000] <err> os: r3/a4:  0x00000088 r12/ip:  0x0000f82a r14/lr:  0x08009537
[00:00:06.353,000] <err> os:  xpsr:  0x41000000
[00:00:06.353,000] <err> os: Faulting instruction address (r15/pc): 0x0800e7dc
[00:00:06.353,000] <err> os: >>> ZEPHYR FATAL ERROR 4: Kernel panic on CPU 0
[00:00:06.353,000] <err> os: Current thread: 0x20010b18 (main)
[00:00:06.415,000] <err> os: Halting system

I can reproduce this issue with zephyr-v3.5.0-3271-g67099d2bbade on a stm32f746g_disco.
From my analysis I nailed it down to happening only if two calls to k_thread_foreach are executed in parallel. Theoretically there is a spinlock in place. The spinlock first executes arch_irq_lock() and then z_spinlock_validate_pre, which in turn fails at __ASSERT(z_spin_lock_valid(l), "Invalid spinlock %p", l);.
Looking at the implementation of z_spin_lock_valid I assume that one thread on the CPU has already acquired the spinlock. But this should be in theory not possible due to arch_irq_lock() . At least this is how I understood it.
bool z_spin_lock_valid(struct k_spinlock *l)
{
    uintptr_t thread_cpu = l->thread_cpu;

    if (thread_cpu != 0U) {
        if ((thread_cpu & 3U) == _current_cpu->id) {
            return false;
        }
    }
    return true;
}

The impact for me is that I cannot use kernel shell commands like stacks or threads anymore, as I have a background task which runs k_thread_foreach.

I've encountered exactly this issue, and IIRC, we did need to use the same solution in the linked PR.


Service extensions_version ?

This service would check all installed extensions of all databases and see it the latest available version is installed.
Basically this is only:
select * from pg_available_extensions where default_version != installed_version ;

Online check of most popular extensions is probably overkill.

merged


Assignment and broadcasting when columns don't match

Codecov Report
Attention: Patch coverage is 85.18519% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 79.75%. Comparing base (6cc5f74) to head (5f0e009).

Files
Patch %
Lines

src/mvtseries/mvts_broadcast.jl
83.33%
4 Missing :warning:

Additional details and impacted files
@@             Coverage Diff             @@
##           master      #72       +/-   ##
===========================================
- Coverage   93.76%   79.75%   -14.01%
===========================================
  Files          24       24
  Lines        4810     4826       +16
===========================================
- Hits         4510     3849      -661
- Misses        300      977      +677

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


refactor(installer): Make use of common chart

This PR

makes use of the new common chart
removes the common key from the helm values in favor of moving all contained values out of it. This is to prevent name collisions with the common helm chart
removes a few unused helper functions

LGTM :) but will be happy if also someone else can go through the code and review it :)


"data type not understood" with readonly array argument

Reporting a bug
The following program should succeed, because astype makes a copy of its argument:
@nb.jit()
def numba_astype(xs):
    ys = xs.astype(nb.float32)
    ys[0] = 1.0
    return ys

xs = np.array([1.0], dtype='f4')
xs.flags.writeable = False
numba_astype(xs)

In fact it just throws TypeError: data type not understood. (This might be related to the fact that the type of the array returned by astype is still marked readonly if the inital array is readonly - i.e. the readonly flag is not being cleared.)

Thanks for the report. I can reproduce. Fixed in https://github.com/numba/numba/pull/3845

That was impressively fast. Thanks!

No problem!


Add tests for CLusterTaskOfferRequirementProvider

Code looks good. One of the build jobs failed downloading a JAR. I have re-triggered the build.


[SPARK-38072][K8S][TESTS] Support K8s imageTag parameter in SBT K8s IT

What changes were proposed in this pull request?
This PR aims to support K8s imageTag parameter in SBT K8s integration test.
Why are the changes needed?
To make maven and SBT consistent.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Manually.

I tested and backported this test PR to branch-3.2 for Apache Spark 3.2.2. Thanks, @williamhyun .
$ docker images
REPOSITORY                                                         TAG          IMAGE ID       CREATED              SIZE
spark-r                                                            2022-03-02   ff360f18e58b   49 seconds ago       1.29GB
spark-py                                                           2022-03-02   f43e1dd604e9   About a minute ago   946MB
spark                                                              2022-03-02   e5406c5830ea   2 minutes ago        610MB


Expose SetCurrentClientCertDetails envoy object to better control XFCC header

Describe the feature request
Hello everyone,
Internally, we are trying to configure clients with the X.509 authenticator type and OAuth2 client credentials to be authenticated by an external party.
Envoy proxy would need to terminates external mTLS connections and forwards the client certificate plus some extra details over the HTTP header named XFCC (x-forwarded-client-cert).
Istio supports forwarding the XFCC header through the ForwardClientCertDetails setting.
The problem with this setting is that when enabled, it does not forward all certificate details by default. Those details (entire client cert, entire client cert chain, DNS type SANs of client cert, URI type SANs) can be forwarded if the HttpConnectionManager.SetCurrentClientCertDetails object is configured accordingly.
However, we don't have right now an API to control Envoy's SetCurrentClientCertDetails object.
Do you think it makes sense to improve upon the existing ForwardClientCertDetails Istio API and add a SetCurrentClientCertDetails object to better control what is forwarded?
If we agree that this is something that makes sense to be added then I can work on the required changes.
Describe alternatives you've considered
So far the only way to achieve this is with an EF.
Affected product area (please put an X in all that apply)
[ ] Ambient
[ ] Docs
[ ] Dual Stack
[ ] Installation
[ ] Networking
[ ] Performance and Scalability
[ ] Extensions and Telemetry
[x] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure
Affected features (please put an X in all that apply)
[ ] Multi Cluster
[ ] Virtual Machine
[ ] Multi Control Plane
Additional context

Fixed by https://github.com/istio/api/pull/3323 (I think). Please re-open if not!


Prototype Auth 2.0 changes

@Tratcher thoughts?  Also we need to update/replace the auth tests since MessagePump is being new'ed up and we need RequestServices for auth to work...

Tests are broken due to RequestServices being null so this is just an early look at how things stand.

Updated with fixes, register the handlers in MessagePump Start instead which is much cleaner, luckily it doesn't take any options...  there's no story yet for how to configure handler options via dynamic AddScheme....

Looks pretty good. Still need help writing the tests?

Yeah tests don't work at all here, (request services are null).  I'm working on the PR for IISIntegration now.

Updated after switching to your new dynamic server and things are almost working.  Challenge is the last test that is broken, I'll comment on the test to explain the issue

Replaced by https://github.com/aspnet/HttpSysServer/pull/354


Flow Static Type Check + flow-runtime + redux actions = headache?

It would seem there are problems with static and runtime type checking and redux actions. I won't reiterate the problem but I have a ticket open on the Flow repo here (#4737).
Since the two of these don't seem to play well together in my use case I've decided to disable flow-runtime. Is there anything else I should do aside from removing the plugin from the .babelrc file?

You could try to do this
// Redux Emits a bunch of it's own stuff so I need to allow those
export type BaseReduxAction = { type: $Subtype<string> };

This matches any action that has the type field and uses a string and still allows you to typecheck your other actions based on the switches or ifs on the action.type

@csprance Thanks! That is a fantastic workaround. +1 to finding more concrete examples. Looking forward to seeing what people far smarter than myself do for this sort of thing.

You can check out my repo here to see a better example of how to use redux, redux-thunk action type and flow stuff. I'm still learning so let me know if you see anything dumb
https://github.com/csprance/MisRCON/blob/v2/app/constants/ActionTypes.js#L71


Add more idnow test environments

IdNow have added more test environments (at different endpoints). Add those as test2 and test3 (reflecting their host names) to the possible environments.
Also remove gocd based build in favour of travis-ci.

:+1:


[agent] Support for running secrets backends with sha256 verification

What does this PR do?

Adds support for secret_backend_command_sha256 that enforces SHA256 of the secret backend binary.

Note that when secret_backend_command_sha256 is used the datadog.yaml config has to be restricted as follows:

Must be owned by root and cannot have writable others' permissions on *nix.
Cannot be writable by principals other than Local System, Administrators or ddagentuser on Windows.

Motivation

Provide cross platform way to enforce the validity of the secret_backend_command binary.

Additional Notes

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

Validate existing secrets backend functionality still works as expected.
Validate configuration of secret_backend_command_sha256 works correctly on Linux and Windows.

In order to validate this functionality on Windows the datadog.yaml file has to be configured to disallow writes by principals other than Local System, Administrators, or ddagentuser.
The secret backend binary should have access by the account running the agent.
Reviewer's Checklist

[ ] If known, an appropriate milestone has been selected; otherwise the Triage milestone is set.
[ ] Use the major_change label if your change either has a major impact on the code base, is impacting multiple teams or is changing important well-established internals of the Agent. This label will be use during QA to make sure each team pay extra attention to the changed behavior. For any customer facing change use a releasenote.
[ ] A release note has been added or the changelog/no-changelog label has been applied.
[ ] Changed code has automated tests for its functionality.
[ ] Adequate QA/testing plan information is provided if the qa/skip-qa label is not applied.
[ ] At least one team/.. label has been applied, indicating the team(s) that should QA this change.
[ ] If applicable, docs team has been notified or an issue has been opened on the documentation repo.
[ ] If applicable, the need-change/operator and need-change/helm labels have been applied.
[ ] If applicable, the k8s/<min-version> label, indicating the lowest Kubernetes version compatible with this feature.
[ ] If applicable, the config template has been updated.

+1 that it may no longer be necessary side because of https://github.com/DataDog/datadog-agent/pull/14628. If we want the sha256 validation by itself, we should probably move the elevation/locking checks to a separate PR.

+1 that it may no longer be necessary side because of #14628. If we want the sha256 validation by itself, we should probably move the elevation/locking checks to a separate PR.

The logic to handle "sandboxing" to "ddagentuser" was moved to https://github.com/DataDog/datadog-agent/pull/14628. I will rebase this PR once the other is in main.