Make dart:ui/Path class not extendable on all platforms

Steps to Reproduce

Run flutter create bug.
Add a class to lib/main.dart that extends Path from dart:ui. Something like the following:

class MyPath extends Path {

}

Expected results:
Running flutter run or flutter build for Android, iOS or desktop completes with no errors.
Actual results:
Running flutter run -d chrome or flutter build web results in the following:

Logs
Target dart2js failed: Exception: lib/main.dart:3:7:
Error: The non-abstract class 'MyPath' is missing implementations for these members:
 - Path.addArc
 - Path.addOval
 - Path.addPath
 - Path.addPolygon
 - Path.addRRect
 - Path.addRect
 - Path.arcTo
 - Path.arcToPoint
 - Path.close
 - Path.computeMetrics
 - Path.conicTo
 - Path.contains
 - Path.cubicTo
 - Path.extendWithPath
 - Path.fillType
 - Path.fillType=
 - Path.getBounds
 - Path.lineTo
 - Path.moveTo
 - Path.quadraticBezierTo
 - Path.relativeArcToPoint
 - Path.relativeConicTo
 - Path.relativeCubicTo
 - Path.relativeLineTo
 - Path.relativeMoveTo
 - Path.relativeQuadraticBezierTo
 - Path.reset
 - Path.shift
 - Path.transform
class MyPath extends Path {
      ^^^^^^
../../../Downloads/flutter/bin/cache/flutter_web_sdk/lib/ui/src/ui/path.dart:52:8:
Info: 'Path.addArc' is defined here.
  void addArc(Rect oval, double startAngle, double sweepAngle);
       ^^^^^^
../../../Downloads/flutter/bin/cache/flutter_web_sdk/lib/ui/src/ui/path.dart:51:8:
Info: 'Path.addOval' is defined here.
  void addOval(Rect oval);
       ^^^^^^^
../../../Downloads/flutter/bin/cache/flutter_web_sdk/lib/ui/src/ui/path.dart:55:8:
Info: 'Path.addPath' is defined here.
  void addPath(Path path, Offset offset, {Float64List? matrix4});
       ^^^^^^^
../../../Downloads/flutter/bin/cache/flutter_web_sdk/lib/ui/src/ui/path.dart:53:8:
Info: 'Path.addPolygon' is defined here.
  void addPolygon(List<Offset> points, bool close);
       ^^^^^^^^^^
../../../Downloads/flutter/bin/cache/flutter_web_sdk/lib/ui/src/ui/path.dart:54:8:
Info: 'Path.addRRect' is defined here.
  void addRRect(RRect rrect);
       ^^^^^^^^
../../../Downloads/flutter/bin/cache/flutter_web_sdk/lib/ui/src/ui/path.dart:50:8:
Info: 'Path.addRect' is defined here.
  void addRect(Rect rect);
       ^^^^^^^
../../../Downloads/flutter/bin/cache/flutter_web_sdk/lib/ui/src/ui/path.dart:35:8:
Info: 'Path.arcTo' is defined here.
  void arcTo(Rect rect, double startAngle, double sweepAngle, bool forceMoveTo);
       ^^^^^
../../../Downloads/flutter/bin/cache/flutter_web_sdk/lib/ui/src/ui/path.dart:36:8:
Info: 'Path.arcToPoint' is defined here.
  void arcToPoint(
       ^^^^^^^^^^
../../../Downloads/flutter/bin/cache/flutter_web_sdk/lib/ui/src/ui/path.dart:57:8:
Info: 'Path.close' is defined here.
  void close();
       ^^^^^
../../../Downloads/flutter/bin/cache/flutter_web_sdk/lib/ui/src/ui/path.dart:73:15:
Info: 'Path.computeMetrics' is defined here.

  PathFillType get fillType;
                   ^^^^^^^^
../../../Downloads/flutter/bin/cache/flutter_web_sdk/lib/ui/src/ui/path.dart:24:7:
Info: 'Path.fillType=' is defined here.
  set fillType(PathFillType value);
      ^^^^^^^^
../../../Downloads/flutter/bin/cache/flutter_web_sdk/lib/ui/src/ui/path.dart:63:8:
Info: 'Path.getBounds' is defined here.

  Path shift(Offset offset);
       ^^^^^
../../../Downloads/flutter/bin/cache/flutter_web_sdk/lib/ui/src/ui/path.dart:61:8:
Info: 'Path.transform' is defined here.
  Path transform(Float64List matrix4);
       ^^^^^^^^^
lib/main.dart:3:7:
Error: The superclass, 'Path', has no unnamed constructor that takes no arguments.
class MyPath extends Path {
      ^
Error: Compilation failed.

Compiling lib/main.dart for the Web...                              7.0s
Exception: Failed to compile application for the Web.

$ flutter doctor -v
[✓] Flutter (Channel stable, 2.0.6, on Mac OS X 10.15.5 19F101 darwin-x64, locale en-CA)
    • Flutter version 2.0.6 at /Users/chgibb/Downloads/flutter
    • Framework revision 1d9032c7e1 (3 months ago), 2021-04-29 17:37:58 -0700
    • Engine revision 05e680e202
    • Dart version 2.12.3

[✓] Android toolchain - develop for Android devices (Android SDK version 31.0.0-rc2)
    • Android SDK at /Users/chgibb/Library/Android/sdk
    • Platform android-30, build-tools 31.0.0-rc2
    • Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 11.0.8+10-b944.6916264)
    • All Android licenses accepted.

[!] Xcode - develop for iOS and macOS
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 12.4, Build version 12D4e
    ! CocoaPods 1.9.0 out of date (1.10.0 is recommended).
        CocoaPods is used to retrieve the iOS and macOS platform side's plugin code that responds to your plugin usage on the Dart side.
        Without CocoaPods, plugins will not work on iOS or macOS.
        For more info, see https://flutter.dev/platform-plugins
      To upgrade see https://guides.cocoapods.org/using/getting-started.html#installation for instructions.

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 4.2)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.8+10-b944.6916264)

[✓] IntelliJ IDEA Ultimate Edition (version 2019.3.3)
    • IntelliJ at /Applications/IntelliJ IDEA.app
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart

[✓] VS Code (version 1.59.0)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.25.0

[✓] Connected device (2 available)
    • macOS (desktop) • macos  • darwin-x64     • Mac OS X 10.15.5 19F101 darwin-x64
    • Chrome (web)    • chrome • web-javascript • Google Chrome 92.0.4515.131

! Doctor found issues in 1 category.

It appears that the Path class for Flutter web is abstract and has no generative constructor:
https://github.com/flutter/engine/blob/master/lib/web_ui/lib/src/ui/path.dart#L10
This is in stark contrast to the Path class exposed to Flutter applications building for every other target:
https://github.com/flutter/engine/blob/master/lib/ui/painting.dart#L2280
Applications which extend Path are therefore unable to compile under Flutter web.

Hi @chgibb
Thanks for filing the issue, I can't find any example where ui.Path is extended rather than implemented
For example, here it is extended, I also searched other classes
https://github.com/flutter/engine/blob/master/lib/web_ui/lib/src/engine/html/path/path.dart
Most often use case of this class is to get a type of path such  ui.Path()..addRRect(rrect); and path.dart has private constructor
The thrown says indicate the issue with a super constructor, on non-web, there is no such issue
This is easily reproducible with just this
import 'dart:ui' as ui;

main() {}

abstract class MyPath extends ui.Path {}

logs
file:///Users/tahatesser/Code/flutter_master/bin/cache/flutter_web_sdk/kernel/flutter_ddc_
sdk_sound.dill --sound-null-safety
[  +18 ms] <- compile org-dartlang-app:/web_entrypoint.dart
[ +309 ms] lib/main.dart:5:16: Error: The superclass, 'Path', has no unnamed constructor
that takes
                    no arguments.
[   +2 ms] abstract class MyPath extends ui.Path {}
[        ]                ^
[ +227 ms] Unhandled exception:
[        ] NoSuchMethodError: The getter 'name' was called on null.
[        ] Receiver: null
[        ] Tried calling: name
[        ] #0      Object.noSuchMethod (dart:core-patch/object_patch.dart:63:5)
[        ] #1      ProgramCompiler._emitSuperConstructorCallIfNeeded
           (package:dev_compiler/src/kernel/compiler.dart:1638:14)
[        ] #2      ProgramCompiler._emitConstructorBody
           (package:dev_compiler/src/kernel/compiler.dart:1592:19)
[        ] #3      ProgramCompiler._emitConstructor.<anonymous closure>.<anonymous
closure>
           (package:dev_compiler/src/kernel/compiler.dart:1548:19)
[        ] #4      ProgramCompiler._superDisallowed
           (package:dev_compiler/src/kernel/compiler.dart:3545:24)
[        ] #5      ProgramCompiler._emitConstructor.<anonymous closure>
           (package:dev_compiler/src/kernel/compiler.dart:1547:15)
[        ] #6      ProgramCompiler._withLetScope
           (package:dev_compiler/src/kernel/compiler.dart:2307:25)
[        ] #7      ProgramCompiler._withCurrentFunction
           (package:dev_compiler/src/kernel/compiler.dart:3535:18)
[        ] #8      ProgramCompiler._emitConstructor
           (package:dev_compiler/src/kernel/compiler.dart:1545:16)
[        ] #9      ProgramCompiler._defineConstructors
           (package:dev_compiler/src/kernel/compiler.dart:1187:38)
[        ] #10     ProgramCompiler._emitClassDeclaration
           (package:dev_compiler/src/kernel/compiler.dart:698:19)
[        ] #11     ProgramCompiler._emitClass
(package:dev_compiler/src/kernel/compiler.dart:621:21)
[        ] #12     List.forEach (dart:core-patch/growable_array.dart:403:8)
[        ] #13     ProgramCompiler._emitLibrary
           (package:dev_compiler/src/kernel/compiler.dart:570:23)
[        ] #14     List.forEach (dart:core-patch/growable_array.dart:403:8)
[        ] #15     ProgramCompiler.emitModule
(package:dev_compiler/src/kernel/compiler.dart:430:15)
[        ] #16     JavaScriptBundler.compile
           (package:frontend_server/src/javascript_bundle.dart:152:33)
[        ] #17     FrontendCompiler.writeJavascriptBundle
           (package:frontend_server/frontend_server.dart:649:47)
[        ] <asynchronous suspension>
[        ] #18     FrontendCompiler.compile
(package:frontend_server/frontend_server.dart:557:9)
[        ] <asynchronous suspension>
[        ] #19     listenAndCompile.<anonymous closure>
           (package:frontend_server/frontend_server.dart:1132:11)
[        ] <asynchronous suspension>
[  +57 ms] "flutter run" took 1,895ms.
[   +5 ms] the Dart compiler exited unexpectedly.
[   +1 ms]
           #0      throwToolExit (package:flutter_tools/src/base/common.dart:10:3)
           #1      DefaultResidentCompiler._compile.<anonymous closure>
           (package:flutter_tools/src/compile.dart:767:13)
           #2      _rootRun (dart:async/zone.dart:1420:47)
           #3      _CustomZone.run (dart:async/zone.dart:1328:19)
           #4      _CustomZone.runGuarded (dart:async/zone.dart:1236:7)
           #5      _BufferingStreamSubscription._sendDone.sendDone
           (dart:async/stream_impl.dart:394:13)
           #6      _BufferingStreamSubscription._sendDone
(dart:async/stream_impl.dart:404:7)
           #7      _BufferingStreamSubscription._close (dart:async/stream_impl.dart:291:7)
           #8      _SinkTransformerStreamSubscription._close
           (dart:async/stream_transformers.dart:87:11)
           #9      _EventSinkWrapper.close (dart:async/stream_transformers.dart:21:11)
           #10     _StringAdapterSink.close (dart:convert/string_conversion.dart:251:11)
           #11     _LineSplitterSink.close (dart:convert/line_splitter.dart:135:11)
           #12     _SinkTransformerStreamSubscription._handleDone
           (dart:async/stream_transformers.dart:132:24)
           #13     _rootRun (dart:async/zone.dart:1420:47)
           #14     _CustomZone.run (dart:async/zone.dart:1328:19)
           #15     _CustomZone.runGuarded (dart:async/zone.dart:1236:7)
           #16     _BufferingStreamSubscription._sendDone.sendDone
           (dart:async/stream_impl.dart:394:13)
           #17     _BufferingStreamSubscription._sendDone
(dart:async/stream_impl.dart:404:7)
           #18     _BufferingStreamSubscription._close (dart:async/stream_impl.dart:291:7)
           #19     _SinkTransformerStreamSubscription._close
           (dart:async/stream_transformers.dart:87:11)
           #20     _EventSinkWrapper.close (dart:async/stream_transformers.dart:21:11)
           #21     _StringAdapterSink.close (dart:convert/string_conversion.dart:251:11)
           #22     _Utf8ConversionSink.close (dart:convert/string_conversion.dart:305:20)
           #23     _ConverterStreamEventSink.close
(dart:convert/chunked_conversion.dart:81:18)
           #24     _SinkTransformerStreamSubscription._handleDone
           (dart:async/stream_transformers.dart:132:24)
           #25     _rootRun (dart:async/zone.dart:1420:47)
           #26     _CustomZone.run (dart:async/zone.dart:1328:19)
           #27     _CustomZone.runGuarded (dart:async/zone.dart:1236:7)
           #28     _BufferingStreamSubscription._sendDone.sendDone
           (dart:async/stream_impl.dart:394:13)
           #29     _BufferingStreamSubscription._sendDone
(dart:async/stream_impl.dart:404:7)
           #30     _BufferingStreamSubscription._close (dart:async/stream_impl.dart:291:7)
           #31     _SyncStreamControllerDispatch._sendDone
(dart:async/stream_controller.dart:741:19)
           #32     _StreamController._closeUnchecked
(dart:async/stream_controller.dart:596:7)
           #33     _StreamController.close (dart:async/stream_controller.dart:589:5)
           #34     _Socket._onData (dart:io-patch/socket_patch.dart:2173:21)
           #35     _rootRunUnary (dart:async/zone.dart:1444:13)
           #36     _CustomZone.runUnary (dart:async/zone.dart:1335:19)
           #37     _CustomZone.runUnaryGuarded (dart:async/zone.dart:1244:7)
           #38     _BufferingStreamSubscription._sendData
(dart:async/stream_impl.dart:341:11)
           #39     _BufferingStreamSubscription._add (dart:async/stream_impl.dart:271:7)
           #40     _SyncStreamControllerDispatch._sendData
(dart:async/stream_controller.dart:733:19)
           #41     _StreamController._add (dart:async/stream_controller.dart:607:7)
           #42     _StreamController.add (dart:async/stream_controller.dart:554:5)
           #43     new _RawSocket.<anonymous closure>
(dart:io-patch/socket_patch.dart:1709:35)
           #44     _NativeSocket.issueReadEvent.issue
(dart:io-patch/socket_patch.dart:1206:18)
           #45     _microtaskLoop (dart:async/schedule_microtask.dart:40:21)
           #46     _startMicrotaskLoop (dart:async/schedule_microtask.dart:49:5)
           #47     _runPendingImmediateCallback
(dart:isolate-patch/isolate_patch.dart:120:13)
           #48     _RawReceivePortImpl._handleMessage
(dart:isolate-patch/isolate_patch.dart:185:5)

[   +7 ms] Waiting for connection from debug service on Chrome... (completed in 746ms)
[        ] Synced 0.0MB.
[        ] Failed to compile application.
[  +30 ms] ensureAnalyticsSent: 33ms
[   +1 ms] Running shutdown hooks
[        ] Shutdown hooks complete
[        ] exiting with code 1
tahatesser@Tahas-MacBook-Pro triage %

stable
master

❌
❌

Check flutter doctor -v outputs for each channel below

flutter doctor -v
[✓] Flutter (Channel stable, 2.2.3, on macOS 12.0 21A5294g darwin-x64, locale en-GB)
    • Flutter version 2.2.3 at /Users/tahatesser/Code/flutter_stable
    • Framework revision f4abaa0735 (6 weeks ago), 2021-07-01 12:46:11 -0700
    • Engine revision 241c87ad80
    • Dart version 2.13.4

[✓] Android toolchain - develop for Android devices (Android SDK version 30.0.3)
    • Android SDK at /Users/tahatesser/Code/SDK
    • Platform android-31, build-tools 30.0.3
    • ANDROID_HOME = /Users/tahatesser/Code/SDK
    • Java binary at: /Applications/AndroidStudio.app/Contents/jre/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 11.0.10+0-b96-7281165)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS
    • Xcode at /Applications/Xcode-beta.app/Contents/Developer
    • Xcode 13.0, Build version 13A5201i
    • CocoaPods version 1.10.1

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[!] Android Studio (not installed)
    • Android Studio not found; download from https://developer.android.com/studio/index.html
      (or visit https://flutter.dev/docs/get-started/install/macos#android-setup for detailed instructions).

[✓] VS Code (version 1.59.0)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.25.0

[✓] Connected device (4 available)
    • Taha’s iPad (mobile) • 00008020-000255113EE8402E            • ios            • iOS 15.0
    • iPhone 12 (mobile)   • 3C173470-A5A2-45F2-BF7B-79B8218E717C • ios            • com.apple.CoreSimulator.SimRuntime.iOS-15-0 (simulator)
    • macOS (desktop)      • macos                                • darwin-x64     • macOS 12.0 21A5294g darwin-x64
    • Chrome (web)         • chrome                               • web-javascript • Google Chrome 92.0.4515.131

! Doctor found issues in 1 category.

✅: No Issue ❌: Issue reproduced

cc: @yjbanov

I don't believe this to be a dependency:dart issue - the Path declaration in web_ui only has factory constructors which make this class sealed for extension. The fix would likely require changing the implementation of this class

This class is not meant extension as the engine relies on specific internal representation of the object. Have you considered wrapping it instead of extending?

If that is the case, should it not be marked @sealed?

It should, but unfortunately dart:* libraries cannot use pub packages, so we cannot import package:meta from dart:ui to mark it sealed. I'll file a Dart SDK issue to include these annotations in the standard libraries. Then we'll be able to annotation engine classes too.

DBC - A suboptimal, but feasible middle ground solution here, could be to use the pattern you have in web_ui also in the public library. Then the Path class cannot be extended by default in all environments.

We can prevent extensions by making the constructor private and only expose a factory, but it will not prevent implementations. Maybe that's better than nothing.

Part of fixing this issue is to figure out how much this class has already been extended in the wild, because it would be a breaking change for non-web platforms.

The non-web implementation of path is working as intended. The workaround on both implementations is to use wrapping instead of extension.


Feature request: Support for two Aranet4s

I have two.   The iPhone silently connected to one that was in range, and not the other.  I named them differently in the official app - but I am not sure if that name is passed to the Aranet4 itself.
TL;DR - recognize and log from two devices?

Hi Paul, in the newer versions there is an option to filter (and select) the device by their name. So you can pick which one it logs, but logging multiple devices at once isn't planned at all, as I think that is a very niché use case. Changing the Name in the official App doesn't really change the Name I think, but both sensors should have a slightly different ID when you take a look at the connected bluetooth devices, and those are the names which are used by my App.


Fix renaming file

fix for https://github.com/ethereum/remix/issues/541 https://github.com/ethereum/remix/issues/540

looks good to me


Add information about licensing

Done! I didnt expect this to get this popular so fast

Thank you for information!

No problem!


Miss a drag as we are waiting for WebCore's response for touchdown

I have a mobile app packaged through cordova/phonegap. It contains a list and uses scrollz for pull to refresh and bottom detection. The scrolling and performance is ok on iOS but on android, the scrolling is so sluggish, and logcat is throwing the error above.

Hi,
I actually never tried to test scrollz in an Android WebView.
An Android WebView is actually much slower than the Chrome Browser, except on Android 4.4 and above.
The message you get in the logcat is a known android WebView issue. Some workarounds are described  here: http://stackoverflow.com/questions/10933207/how-to-fixmiss-a-drag-as-we-are-waiting-for-webcores-response-for-touch-down. But I have not tested them...
Regards,
Gilles


ERB/EPP/YAML-in-YAML support?

Thanks for the extension, really great idea!
I'm wondering if you'd consider supporting other host languages as well. If so, these would be really nice:

Ruby/Embedded Ruby, the latter being heavily used in Ruby on Rails and Puppet
Embedded Puppet, which is quite similar in syntax

And last but not least, one that is probably a lot more difficult, so more of a long shot, but who knows...
I'd like to somehow have different syntax highlighting rules within the same language.
Going back to my previous example: Puppet has Hiera, which allows one to separate their data from Puppet code. The docs feature some examples, but it's basically YAML/JSON, often times (ab)used to embed almost raw YAML/JSON – which could be properly parsed by other extensions like logstash editor (syntax here) if it were in its own file, which either gets parsed as generic YAML or as a specific syntax. Since your extension attacks this problem for other host languages, I thought this might be pertinent.
Once again thanks a lot!

Ruby is definitely a good candidate for the next host language to add.  I'll have to take a look at puppet as well.
For the Embedded Ruby and Embedded Puppet cases could you describe a bit more what you'd expect to see? As I'm thinking about it, these template languages are almost the inverse of the problem I was working on. I.e. you would want to inject a single language's highlighting rules (e.g. Ruby) into a large number of host languages (e.g. html or json or anything else you might be generating). That does sound very useful, but I think it would need to be a different extension since it would be a very different architecture.
FWIW I just saw a Jinja extension while investigating issue #1 that takes an interesting approach of defining a bunch of sub-languages - e.g. jinja-html or jinja-json which are presumably simple new language grammars that are just a combination of the two syntax highlighting rules. If they aren't already generating all of those combinations automatically I could definitely see where they could, and then could add support for any number of template languages and embedded languages. But then you could get a combinatorial explosion of choices when selecting which language you want to use in VSCode. (Do you want jinja-html or erb-html or ejs-html ...)

Hmm, I think you're right! An ERB/EPP is mostly code in some other language with some templating interspersed throughout.
Could you link to that other extension?

Sure - that extension is Better Jinja and the grammars are what I mentioned above, just referencing both Jinja and the host language (example)

Just a quick followup - The VSCode ruby grammar already supports several languages. See this file https://github.com/microsoft/vscode/blob/main/extensions/ruby/syntaxes/ruby.tmLanguage.json and search for, e.g. "Heredoc with embedded c++. The built in ruby syntax is something like:
<<-CPP
int func(int x, int y) {
  return x+y;
}
CPP


Test LMDB job automatically deleted

Hello,
I have built my own LMDB database for classification and I have managed to train successfully models on it.
Now when I want to visualize the results using the "Test LMDB" option with a valid LMDB  it doesn't work.
The job is generated, the LMDB is parsed and the output hdf5 is created, but as soon as this is done the job is deleted.
2016-09-26 14:45:45 [20160926-144529-f2e3] [WARNING] Infer Model unrecognized output: Processed 31773/31773 images
2016-09-26 14:45:45 [20160926-144529-f2e3] [WARNING] Infer Model unrecognized output: /FOLDER/TO/20160926-144529-f2e3/inference.hdf5
2016-09-26 14:45:46 [20160926-144529-f2e3] [INFO ] Infer Model task completed.
2016-09-26 14:45:46 [20160926-144529-f2e3] [INFO ] Job complete.
2016-09-26 14:45:46 [20160926-144529-f2e3] [INFO ] Job deleted.
The GUI doesn't generate any visualization page after that.
Any idea what could go on ?

It's difficult to say, you might want to walk through digits/tools/inference.py and infer_db to see what is going on.

Tested with DIGITS 5.0 and it works as expected. Closing.
If you can provide some more information and/or steps to reproduce, please do so and reopen this issue.

I have some more information this problem, as this was something similar we saw yesterday.
SW Installation:

OS: RHEL 6 (kernel 2.6.32-642.1.1)
DIGITS 4.0
Python 2.7.10
HDF5 1.8.17
pyparsing == 1.5.7
pydot == 1.0.28
graphviz (python) 2.26.0

When attempting to run classification on one item, there appears to be an underlying conflict between the dot_parser for Python and the pyparsing/pydot package combo.  When I upgrade the pyparsing package to 2.1.10, I don't see this issue, but I do get a warning when running DIGITS that it cannot find the dot_parser binary.  Was this problem fixed in DIGITS 5?

So, your problem has nothing to do with this bug? Is anything getting deleted?

The inference file it is saving is getting deleted according to the DIGITS log, but the Classify One option does not work.  This is what we were seeing in our DIGITS log:

2017-02-07 13:48:04 [20170207-134802-8115] [INFO ] Infer Model task started.
2017-02-07 13:48:04 [20170207-134802-8115] [INFO ] Task subprocess args: ['/usr/bin/python2', '/path/to/DIGITS/DIGITS-4.0.0/tools/inference.py', '/path/to/DIGITS/DIGITS-4.0.0/digits/jobs/20170207-134802-8115/tmpgO8Ilc.txt', '/path/to/DIGITS/DIGITS-4.0.0/digits/jobs/20170207-134802-8115', '20170207-133942-f75f', '--jobs_dir=/path/to/DIGITS/DIGITS-4.0.0/digits/jobs', '--epoch=30.0', '--layers=none', '--gpu=0']
2017-02-07 13:48:10 [20170207-134802-8115] [WARNING] Infer Model unrecognized output: 2017-02-07 13:48:10 [INFO ] Saved data to /path/to/DIGITS/DIGITS-4.0.0/digits/jobs/20170207-134802-8115/inference.hdf5
2017-02-07 13:48:10 [20170207-134802-8115] [INFO ] Infer Model task completed.
2017-02-07 13:48:11 [20170207-134802-8115] [INFO ] Job complete.
2017-02-07 13:48:11 [20170207-134802-8115] [INFO ] Job deleted.

The Classify One screen would show an error occurred and say to check the log file.  The error I saw in the log with this command looked similar to the issue originator, hence I posted my comment here.

Hmm. Sounds like there may be a lack of proper error reporting? You fixed your underlying error by updating pyparsing/pydot, but maybe @LucMioulet had a different problem that was also not reported properly.

Not to keep hijacking this thread, I noticed pydot was updated to 1.0.29 for DIGITS 5.  Does that work with pyparsing 2.1.10?  Or is pyparsing 1.5.7 preferred?

@ekcolam to digress further, I don't think pydot was actually updated. I just changed the pip version to match the [incorrect] ubuntu package version: https://bugs.launchpad.net/ubuntu/+source/pydot/+bug/1609585
I've never heard of anyone having pydot/pyparsing versioning problems. I guess you're getting weird versions on RedHat? Here are the versions I've got on Ubuntu 16.04 which are working well:
$ pip list | egrep -i 'dot|pars'
pydot (1.0.29)
pyparsing (2.0.3)


[docs] Fix wonky mermaid diagrams

There's a race condition between loading mermaid.js and loading fonts. Upshot is, sometimes the diagrams render like so:

It's a known issue, it seems:
https://mermaid-js.github.io/mermaid/#/usage?id=labels-out-of-bounds

I burned some time trying to get this fixed as per the suggestion in the mermaid docs. No luck 👎 .

stale

stale


Auth/eth fails for the old account created with GUN (most probably)

Alert Fired! Exception on Heroku/Syslog drain
1147 <190>1 2022-01-27T20:06:57.333114+00:00 app web.1 - - [31m2022-01-27T20:06:57.333Z - workerId:0 - error (FROM /auth/eth ): {"uuid":"sEEvq4P4eS","message":"Something went wrong while performing request","context":["Unable to verify credentials",{"type":"Error","message":"Unable to verify credentials","stack":"Error: Unable to verify credentials\n    at G.e.post.T (/app/dist/server.js:1:28380)\n    at process._tickCallback (internal/process/next_tick.js:68:7)"},{"body":{"signature":"0x564a0674043980287990324d6c68d2cb22d8f3f3c2068aa336d28ec5f5e661f26d92dd11742a1fd4fdfd5bc1dd4019a7a7dbf335d1e80e9ffc39e7066abd11f91c","gdSignature":"0x744fc563ed6d98001f21f6b498c3b5bb4437e9241ca273cde5564d6155c73ba80cb673928f9e0a6a503943ac6c901a100afa9e088140eb5aa1be11e2ebab0aa91b","profilePublickey":"KkCQ4W93OgN6yvElNDyi_VKZ3ZSPMgWZPC0s1-S6XZQ.vzkK8sfn6MW6_05jO4Lz07mZt8N-vMHz28QGfEoITP4","profileSignature":"SEA{\"m\":\"Login to GoodDAPPf4d465c3a8526f219d96\",\"s\":\"sBFCq2FasiO6yqXyzhkLRjHBRKTCf8AEFGl7gAO3kLGmgrhVP7mvTkUVD5y9iSJQazYltTOnGoshzdFVXale5A==\"}","nonce":"f4d465c3a8526f219d96","networkId":122}}]}[39m

It happens because await verifyProfilePublicKey(profileReqPublickey, profileSignature, nonce) resolves with false.
Inside this function await profilePublicKey.verify(msgbytes, sigbytes) doesn’t throws an exception, just returns false.
So, there’s something wrong with the profilePublickey sent from GoodDapp.
full logs example for the certain request:
262 <190>1 2022-02-01T13:46:31.580592+00:00 app web.1 - - [32m2022-02-01T13:46:31.580Z - workerId:0 - debug (FROM /auth/eth ): {"uuid":"E1IgGRzGwj","message":"/auth/eth authorizing","context":[{"message":"authorizing"}]}[39m
860 <190>1 2022-02-01T13:46:31.580634+00:00 app web.1 - - [32m2022-02-01T13:46:31.580Z - workerId:0 - debug (FROM /auth/eth ): {"uuid":"E1IgGRzGwj","message":"/auth/eth","context":[{"body":{"signature":"0xd153e3348bdd0e2db5f2efbf66107c4ac313ff4689fc31e5ab969518ed326493235791dc10d0f3553aeb3d870b1ec8631b08abc6ba4f666213c328f299139f391b","gdSignature":"0xac4cf0f90c6431f79a4b8fbea31bf231ebaabac292eef4a0a26e48344418131b23ff94a4096aeb76725e18352091efb2b4984e3747eb6550983a3b4708c5923b1c","profilePublickey":"yNNCRriVjETEcgfcCED5cnmRJ4_OTRUjtUE5CTXY5kA._g743mmKMsMBJDCxvqQ-cSn8qF_tva3qm5BHfarlURs","profileSignature":"SEA{\"m\":\"Login to GoodDAPP548a02fe279b65667951\",\"s\":\"kH4Lxn+x15m+z92T6q3MS4kQD0bQtokoMuoi56cA2O+avP6+MLJo6ggNWKBWEdYvsrTZ3w5WGf8oMgOyvxuy3w==\"}","nonce":"548a02fe279b65667951","networkId":122}}]}[39m
372 <190>1 2022-02-01T13:46:31.58067+00:00 app web.1 - - [32m2022-02-01T13:46:31.580Z - workerId:0 - debug (FROM /auth/eth ): {"uuid":"E1IgGRzGwj","message":"/auth/eth","context":[{"signature":"0xd153e3348bdd0e2db5f2efbf66107c4ac313ff4689fc31e5ab969518ed326493235791dc10d0f3553aeb3d870b1ec8631b08abc6ba4f666213c328f299139f391b"}]}[39m
536 <190>1 2022-02-01T13:46:31.605679+00:00 app web.1 - - [32m2022-02-01T13:46:31.605Z - workerId:0 - debug (FROM /auth/eth ): {"uuid":"E1IgGRzGwj","message":"/auth/eth Recovered public key","context":[{"message":"Recovered public key","recovered":"0x9a78b773a1fc0a3a544b3c98bb2fb9bd0651b54d","gdPublicAddress":"0xe7fde3f8e8c0dff19e6810680e2ba648dbef90d3","profileVerified":false,"profileReqPublickey":"yNNCRriVjETEcgfcCED5cnmRJ4_OTRUjtUE5CTXY5kA._g743mmKMsMBJDCxvqQ-cSn8qF_tva3qm5BHfarlURs"}]}[39m
327 <190>1 2022-02-01T13:46:31.605784+00:00 app web.1 - - [33m2022-02-01T13:46:31.605Z - workerId:0 - warn (FROM /auth/eth ): {"uuid":"E1IgGRzGwj","message":"/auth/eth SigUtil unable to recover the message signer","context":[{"message":"SigUtil unable to recover the message signer"}]}[39m
1147 <190>1 2022-02-01T13:46:31.605937+00:00 app web.1 - - [31m2022-02-01T13:46:31.605Z - workerId:0 - error (FROM /auth/eth ): {"uuid":"E1IgGRzGwj","message":"Something went wrong while performing request","context":["Unable to verify credentials",{"type":"Error","message":"Unable to verify credentials","stack":"Error: Unable to verify credentials\n    at G.e.post.T (/app/dist/server.js:1:28380)\n    at process._tickCallback (internal/process/next_tick.js:68:7)"},{"body":{"signature":"0xd153e3348bdd0e2db5f2efbf66107c4ac313ff4689fc31e5ab969518ed326493235791dc10d0f3553aeb3d870b1ec8631b08abc6ba4f666213c328f299139f391b","gdSignature":"0xac4cf0f90c6431f79a4b8fbea31bf231ebaabac292eef4a0a26e48344418131b23ff94a4096aeb76725e18352091efb2b4984e3747eb6550983a3b4708c5923b1c","profilePublickey":"yNNCRriVjETEcgfcCED5cnmRJ4_OTRUjtUE5CTXY5kA._g743mmKMsMBJDCxvqQ-cSn8qF_tva3qm5BHfarlURs","profileSignature":"SEA{\"m\":\"Login to GoodDAPP548a02fe279b65667951\",\"s\":\"kH4Lxn+x15m+z92T6q3MS4kQD0bQtokoMuoi56cA2O+avP6+MLJo6ggNWKBWEdYvsrTZ3w5WGf8oMgOyvxuy3w==\"}","nonce":"548a02fe279b65667951","networkId":122}}]}[39m
2370 <190>1 2022-02-01T13:46:31.610144+00:00 app web.1 - - [36m2022-02-01T13:46:31.610Z - workerId:0 - info (FROM /auth/eth ): {"uuid":"E1IgGRzGwj","message":"http","context":["Incoming Request",{"responseTimeSeconds":0.03,"method":"POST","body":{"signature":"0xd153e3348bdd0e2db5f2efbf66107c4ac313ff4689fc31e5ab969518ed326493235791dc10d0f3553aeb3d870b1ec8631b08abc6ba4f666213c328f299139f391b","gdSignature":"0xac4cf0f90c6431f79a4b8fbea31bf231ebaabac292eef4a0a26e48344418131b23ff94a4096aeb76725e18352091efb2b4984e3747eb6550983a3b4708c5923b1c","profilePublickey":"yNNCRriVjETEcgfcCED5cnmRJ4_OTRUjtUE5CTXY5kA._g743mmKMsMBJDCxvqQ-cSn8qF_tva3qm5BHfarlURs","profileSignature":"SEA{\"m\":\"Login to GoodDAPP548a02fe279b65667951\",\"s\":\"kH4Lxn+x15m+z92T6q3MS4kQD0bQtokoMuoi56cA2O+avP6+MLJo6ggNWKBWEdYvsrTZ3w5WGf8oMgOyvxuy3w==\"}","nonce":"548a02fe279b65667951","networkId":122},"query":{},"headers":{"host":"goodserver.gooddollar.org","connection":"close","sec-ch-ua":"\" Not A;Brand\";v=\"99\", \"Chromium\";v=\"96\", \"Google Chrome\";v=\"96\"","sec-ch-ua-mobile":"?1","authorization":"Bearer eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJsb2dnZWRJbkFzIjoiMHg5YTc4Yjc3M2ExZmMwYTNhNTQ0YjNjOThiYjJmYjliZDA2NTFiNTRkIiwiZ2RBZGRyZXNzIjoiMHhlN2ZkZTNmOGU4YzBkZmYxOWU2ODEwNjgwZTJiYTY0OGRiZWY5MGQzIiwicHJvZmlsZVB1YmxpY2tleSI6InlOTkNScmlWakVURWNnZmNDRUQ1Y25tUko0X09UUlVqdFVFNUNUWFk1a0EuX2c3NDNtbUtNc01CSkRDeHZxUS1jU244cUZfdHZhM3FtNUJIZmFybFVScyIsImV4cCI6MTYyNTM3NzgyNiwiaWF0IjoxNjI0NzczMDI2fQ.ogpiLO3wS3fjAryN_srH1_vJvzuMFqwM6FdUujx8WOs","content-type":"application/json","accept":"application/json, text/plain, */*","user-agent":"Mozilla/5.0 (Linux; Android 11; RMX2173) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/96.0.4664.45 Mobile Safari/537.36","save-data":"on","sec-ch-ua-platform":"\"Android\"","origin":"https://wallet.gooddollar.org","sec-fetch-site":"same-site","sec-fetch-mode":"cors","sec-fetch-dest":"empty","referer":"https://wallet.gooddollar.org/","accept-encoding":"gzip, deflate, br","accept-language":"zh-CN,zh;q=0.9","x-request-id":"778ffae5-7a6a-4735-9d41-f6b19bb63641","x-forwarded-for":"<IP_ADDRESS>","x-forwarded-proto":"https","x-forwarded-port":"443","via":"1.1 vegur","connect-time":"0","x-request-start":"1643723191579","total-route-time":"0","content-length":"626"},"statusCode":400,"statusMessage":"Bad Request"}]}[39m

[x] compare profilePublicKey with the value from the new profiles
[ ] check how we could logout / relogin users still having old GUN account and first visited app after upgrade to realm

@johnsmith-gooddollar
is it comming from wallets with old version?
what are the implications of throwing an exception here?
how will the wallet handle it?

@johnsmith-gooddollar
is it comming from wallets with old version?
Yes

what are the implications of throwing an exception here?
the error thrown with custom code will be handled by the error middleware
it will send the following json {ok: 0, message: '<...>', name: '<>'}

how will the wallet handle it?

wallet will .catch() axios call and check server response
if error response JSON have 'name' field, it will be substituted to the error object created
e.g. const {  message, name } = e.response.data const error = new Error(message) if (name) error.name = name
in the .catch block of the hook/callback/etc where we're calling auth() we will check for the error.name value


Error when using large-v3-turbo (turbo) model

I assumed turbo  model is supported by the latest stable-ts.
I get the following error. I guess the error message indicates incompatibility of alignment heads:
Traceback (most recent call last):
  File "stable_ts_wrapper.py", line 48, in transcribe_audio
    result = self.model.transcribe(movie_path, **params)
  File "C:\Users\DG\.conda\envs\stablets\lib\site-packages\stable_whisper\whisper_word_level\original_whisper.py", line 580, in transcribe_stable
    add_word_timestamps_stable(
  File "C:\Users\DG\.conda\envs\stablets\lib\site-packages\stable_whisper\timing.py", line 320, in add_word_timestamps_stable
    align()
  File "C:\Users\DG\.conda\envs\stablets\lib\site-packages\stable_whisper\timing.py", line 286, in align
    alignment = find_alignment_stable(model, tokenizer, text_tokens, mel, num_samples,
  File "C:\Users\DG\.conda\envs\stablets\lib\site-packages\stable_whisper\timing.py", line 112, in find_alignment_stable
    weights, text_token_probs = _compute_qks(model, audio_features=audio_features, **kwargs)
  File "C:\Users\DG\.conda\envs\stablets\lib\site-packages\stable_whisper\timing.py", line 58, in _compute_qks
    weights = torch.cat([QKs[_l][:, _h] for _l, _h in model.alignment_heads.indices().T], dim=0)
  File "C:\Users\DG\.conda\envs\stablets\lib\site-packages\stable_whisper\timing.py", line 58, in <listcomp>
    weights = torch.cat([QKs[_l][:, _h] for _l, _h in model.alignment_heads.indices().T], dim=0)
TypeError: 'NoneType' object is not subscriptable

Is turbo not supported, or am I doing something wrong?
Thanks

The latest commit fixes this error. Since there hasn't been a version update yet, the commit hasn't been pushed to PyPI.

is this the latest commit: df8dace ?
I tried to upgrade by: pip install --upgrade git+https://github.com/jianfch/stable-ts.git@df8dace6c4a52be8cc9ffdd09137e1f87649a8be but the error is still there.

Yes, df8dace6c4a52be8cc9ffdd09137e1f87649a8be is the latest.
But that error occurred at the line:
weights = torch.cat([QKs[_l][:, _h] for _l, _h in model.alignment_heads.indices().T], dim=0)

but the traceback shows line 58 which does not match the actual line in df8dace6c4a52be8cc9ffdd09137e1f87649a8be:
https://github.com/jianfch/stable-ts/blob/df8dace6c4a52be8cc9ffdd09137e1f87649a8be/stable_whisper/timing.py#L58
Line 58 matches the traceback for older commits from 2.17.4:
https://github.com/jianfch/stable-ts/blob/6d066308ed5a3328a69006d3a7d4496315736c0f/stable_whisper/timing.py#L58

Hmm, yes you're right, the pip command has not updated the package.  Perhaps I should uninstall and re-install.

Hi, im not understanding how should i use large-v3-turbo. Im running --model large-v3-turbo from the terminal and nothing happens.

Hi, im not understanding how should i use large-v3-turbo. Im running --model large-v3-turbo from the terminal and nothing happens.

The model is downloaded when loading for the first time, but there should still be a progress bar that shows the download progress.

Hi, im not understanding how should i use large-v3-turbo. Im running --model large-v3-turbo from the terminal and nothing happens.

The model is downloaded when loading for the first time, but there should still be a progress bar that shows the download progress.

I always get this: ValueError: model should be one of ['tiny.en', 'tiny', 'base.en', 'base', 'small.en', 'small', 'medium.en', 'medium', 'large-v1', 'large-v2', 'large-v3', 'large', 'distil-large-v2', 'distil-medium.en', 'distil-small.en', 'distil-large-v3'] or path to a model checkpoint

Hi, im not understanding how should i use large-v3-turbo. Im running --model large-v3-turbo from the terminal and nothing happens.

The model is downloaded when loading for the first time, but there should still be a progress bar that shows the download progress.

I always get this: ValueError: model should be one of ['tiny.en', 'tiny', 'base.en', 'base', 'small.en', 'small', 'medium.en', 'medium', 'large-v1', 'large-v2', 'large-v3', 'large', 'distil-large-v2', 'distil-medium.en', 'distil-small.en', 'distil-large-v3'] or path to a model checkpoint
There's no large-v3-turbo in the list so how do I run it?

Whisper needs to be updated separately. Updating Stable-ts will not auto update Whisper if the installed Whisper version is already compatible.

Hi, im not understanding how should i use large-v3-turbo. Im running --model large-v3-turbo from the terminal and nothing happens.

The model is downloaded when loading for the first time, but there should still be a progress bar that shows the download progress.

I always get this: ValueError: model should be one of ['tiny.en', 'tiny', 'base.en', 'base', 'small.en', 'small', 'medium.en', 'medium', 'large-v1', 'large-v2', 'large-v3', 'large', 'distil-large-v2', 'distil-medium.en', 'distil-small.en', 'distil-large-v3'] or path to a model checkpoint
There's no large-v3-turbo in the list so how do I run it?

Whisper needs to be updated separately. Updating Stable-ts will not auto update Whisper if the installed Whisper version is already compatible.

Sry, im not really understanding what you're saying. What are the steps to get large-v3-turbo to work?

Hi, im not understanding how should i use large-v3-turbo. Im running --model large-v3-turbo from the terminal and nothing happens.

The model is downloaded when loading for the first time, but there should still be a progress bar that shows the download progress.

I always get this: ValueError: model should be one of ['tiny.en', 'tiny', 'base.en', 'base', 'small.en', 'small', 'medium.en', 'medium', 'large-v1', 'large-v2', 'large-v3', 'large', 'distil-large-v2', 'distil-medium.en', 'distil-small.en', 'distil-large-v3'] or path to a model checkpoint
There's no large-v3-turbo in the list so how do I run it?

Whisper needs to be updated separately. Updating Stable-ts will not auto update Whisper if the installed Whisper version is already compatible.

Sry, im not really understanding what you're saying. What are the steps to get large-v3-turbo to work?
Im running: stable-ts '.the video file' -o 1.srt --model large-v3-turbo --language en --word_level false --faster_whisper
And i get in the terminal: ValueError: model should be one of ['tiny.en', 'tiny', 'base.en', 'base', 'small.en', 'small', 'medium.en', 'medium', 'large-v1', 'large-v2', 'large-v3', 'large', 'distil-large-v2', 'distil-medium.en', 'distil-small.en', 'distil-large-v3'] or path to a model checkpoint
I already tried uninstalling stable-ts and downloading again (latest commit). What should i do?

You need to update Whisper with:
pip install -U openai-whisper

Hi, im not understanding how should i use large-v3-turbo. Im running --model large-v3-turbo from the terminal and nothing happens.

The model is downloaded when loading for the first time, but there should still be a progress bar that shows the download progress.

I always get this: ValueError: model should be one of ['tiny.en', 'tiny', 'base.en', 'base', 'small.en', 'small', 'medium.en', 'medium', 'large-v1', 'large-v2', 'large-v3', 'large', 'distil-large-v2', 'distil-medium.en', 'distil-small.en', 'distil-large-v3'] or path to a model checkpoint
There's no large-v3-turbo in the list so how do I run it?

Whisper needs to be updated separately. Updating Stable-ts will not auto update Whisper if the installed Whisper version is already compatible.

Sry, im not really understanding what you're saying. What are the steps to get large-v3-turbo to work?
Im running: stable-ts '.the video file' -o 1.srt --model large-v3-turbo --language en --word_level false --faster_whisper
And i get in the terminal: ValueError: model should be one of ['tiny.en', 'tiny', 'base.en', 'base', 'small.en', 'small', 'medium.en', 'medium', 'large-v1', 'large-v2', 'large-v3', 'large', 'distil-large-v2', 'distil-medium.en', 'distil-small.en', 'distil-large-v3'] or path to a model checkpoint
I already tried uninstalling stable-ts and downloading again (latest commit). What should i do?

You need to update Whisper with:
pip install -U openai-whisper

It worked, thks


HBASE-25533 The metadata of the table and family should not be an empty string (branch-2)

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
4m 12s
Docker mode activated.

-0 :warning:
yetus
0m  5s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ branch-2 Compile Tests _

+0 :ok:
mvndep
0m 16s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m 38s
branch-2 passed

+1 :green_heart:
compile
0m 49s
branch-2 passed

+1 :green_heart:
shadedjars
5m 50s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 39s
branch-2 passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 16s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m 26s
the patch passed

+1 :green_heart:
compile
0m 50s
the patch passed

+1 :green_heart:
javac
0m 50s
the patch passed

+1 :green_heart:
shadedjars
6m 20s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 40s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
2m 19s
hbase-client in the patch passed.

+1 :green_heart:
unit
6m 57s
hbase-shell in the patch passed.

37m 47s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2914/1/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2914

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 90ca8ebf4f8e 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2 / b930ea1ebb

Default Java
AdoptOpenJDK-1.8.0_232-b09

Test Results
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2914/1/testReport/

Max. process+thread count
1958 (vs. ulimit of 12500)

modules
C: hbase-client hbase-shell U: .

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2914/1/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
4m 12s
Docker mode activated.

-0 :warning:
yetus
0m  5s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ branch-2 Compile Tests _

+0 :ok:
mvndep
0m 16s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m 38s
branch-2 passed

+1 :green_heart:
compile
0m 49s
branch-2 passed

+1 :green_heart:
shadedjars
5m 50s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 39s
branch-2 passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 16s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m 26s
the patch passed

+1 :green_heart:
compile
0m 50s
the patch passed

+1 :green_heart:
javac
0m 50s
the patch passed

+1 :green_heart:
shadedjars
6m 20s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 40s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
2m 19s
hbase-client in the patch passed.

+1 :green_heart:
unit
6m 57s
hbase-shell in the patch passed.

37m 47s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2914/1/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2914

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 90ca8ebf4f8e 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2 / b930ea1ebb

Default Java
AdoptOpenJDK-1.8.0_232-b09

Test Results
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2914/1/testReport/

Max. process+thread count
1958 (vs. ulimit of 12500)

modules
C: hbase-client hbase-shell U: .

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2914/1/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 31s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ branch-2 Compile Tests _

+0 :ok:
mvndep
0m 15s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m 57s
branch-2 passed

+1 :green_heart:
compile
1m 31s
branch-2 passed

+1 :green_heart:
checkstyle
0m 46s
branch-2 passed

+1 :green_heart:
spotbugs
1m 14s
branch-2 passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 12s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m 35s
the patch passed

+1 :green_heart:
compile
1m 25s
the patch passed

+1 :green_heart:
javac
1m 25s
the patch passed

+1 :green_heart:
checkstyle
0m 46s
the patch passed

-0 :warning:
rubocop
0m  8s
The patch generated 57 new + 177 unchanged - 0 fixed = 234 total (was 177)

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
hadoopcheck
12m 54s
Patch does not cause any errors with Hadoop 3.1.2 3.2.1.

+1 :green_heart:
spotbugs
1m 15s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
0m 21s
The patch does not generate ASF License warnings.

37m 59s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2914/1/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2914

Optional Tests
dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile rubocop

uname
Linux 4f42d35e9bea 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2 / b930ea1ebb

Default Java
AdoptOpenJDK-1.8.0_232-b09

rubocop
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2914/1/artifact/yetus-general-check/output/diff-patch-rubocop.txt

Max. process+thread count
86 (vs. ulimit of 12500)

modules
C: hbase-client hbase-shell U: .

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2914/1/console

versions
git=2.17.1 maven=3.6.3 spotbugs=3.1.12 rubocop=0.80.0

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 31s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ branch-2 Compile Tests _

+0 :ok:
mvndep
0m 15s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m 57s
branch-2 passed

+1 :green_heart:
compile
1m 31s
branch-2 passed

+1 :green_heart:
checkstyle
0m 46s
branch-2 passed

+1 :green_heart:
spotbugs
1m 14s
branch-2 passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 12s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m 35s
the patch passed

+1 :green_heart:
compile
1m 25s
the patch passed

+1 :green_heart:
javac
1m 25s
the patch passed

+1 :green_heart:
checkstyle
0m 46s
the patch passed

-0 :warning:
rubocop
0m  8s
The patch generated 57 new + 177 unchanged - 0 fixed = 234 total (was 177)

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
hadoopcheck
12m 54s
Patch does not cause any errors with Hadoop 3.1.2 3.2.1.

+1 :green_heart:
spotbugs
1m 15s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
0m 21s
The patch does not generate ASF License warnings.

37m 59s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2914/1/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2914

Optional Tests
dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile rubocop

uname
Linux 4f42d35e9bea 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2 / b930ea1ebb

Default Java
AdoptOpenJDK-1.8.0_232-b09

rubocop
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2914/1/artifact/yetus-general-check/output/diff-patch-rubocop.txt

Max. process+thread count
86 (vs. ulimit of 12500)

modules
C: hbase-client hbase-shell U: .

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2914/1/console

versions
git=2.17.1 maven=3.6.3 spotbugs=3.1.12 rubocop=0.80.0

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m  0s
Docker mode activated.

-0 :warning:
yetus
0m  6s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ branch-2 Compile Tests _

+0 :ok:
mvndep
0m 21s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
6m  2s
branch-2 passed

+1 :green_heart:
compile
1m 17s
branch-2 passed

+1 :green_heart:
shadedjars
9m 27s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 54s
branch-2 passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 24s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
5m 39s
the patch passed

+1 :green_heart:
compile
1m  8s
the patch passed

+1 :green_heart:
javac
1m  8s
the patch passed

+1 :green_heart:
shadedjars
9m  1s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 45s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
2m 59s
hbase-client in the patch passed.

+1 :green_heart:
unit
7m 13s
hbase-shell in the patch passed.

47m 56s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2914/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2914

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 87e3da0b0b92 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2 / b930ea1ebb

Default Java
AdoptOpenJDK-11.0.6+10

Test Results
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2914/1/testReport/

Max. process+thread count
2032 (vs. ulimit of 12500)

modules
C: hbase-client hbase-shell U: .

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2914/1/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m  0s
Docker mode activated.

-0 :warning:
yetus
0m  6s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ branch-2 Compile Tests _

+0 :ok:
mvndep
0m 21s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
6m  2s
branch-2 passed

+1 :green_heart:
compile
1m 17s
branch-2 passed

+1 :green_heart:
shadedjars
9m 27s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 54s
branch-2 passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 24s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
5m 39s
the patch passed

+1 :green_heart:
compile
1m  8s
the patch passed

+1 :green_heart:
javac
1m  8s
the patch passed

+1 :green_heart:
shadedjars
9m  1s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 45s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
2m 59s
hbase-client in the patch passed.

+1 :green_heart:
unit
7m 13s
hbase-shell in the patch passed.

47m 56s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2914/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2914

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 87e3da0b0b92 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2 / b930ea1ebb

Default Java
AdoptOpenJDK-11.0.6+10

Test Results
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2914/1/testReport/

Max. process+thread count
2032 (vs. ulimit of 12500)

modules
C: hbase-client hbase-shell U: .

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2914/1/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 22s
Docker mode activated.

-0 :warning:
yetus
0m  6s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ branch-2 Compile Tests _

+0 :ok:
mvndep
0m 16s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
4m 45s
branch-2 passed

+1 :green_heart:
compile
0m 54s
branch-2 passed

+1 :green_heart:
shadedjars
7m  7s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 45s
branch-2 passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 23s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
4m  6s
the patch passed

+1 :green_heart:
compile
0m 55s
the patch passed

+1 :green_heart:
javac
0m 55s
the patch passed

+1 :green_heart:
shadedjars
6m 53s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 40s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
2m 25s
hbase-client in the patch passed.

+1 :green_heart:
unit
7m  0s
hbase-shell in the patch passed.

39m  9s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2914/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2914

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux d1dcd45a212f 4.15.0-65-generic #74-Ubuntu SMP Tue Sep 17 17:06:04 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2 / b930ea1ebb

Default Java
AdoptOpenJDK-11.0.6+10

Test Results
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2914/2/testReport/

Max. process+thread count
2119 (vs. ulimit of 12500)

modules
C: hbase-client hbase-shell U: .

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2914/2/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 22s
Docker mode activated.

-0 :warning:
yetus
0m  6s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ branch-2 Compile Tests _

+0 :ok:
mvndep
0m 16s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
4m 45s
branch-2 passed

+1 :green_heart:
compile
0m 54s
branch-2 passed

+1 :green_heart:
shadedjars
7m  7s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 45s
branch-2 passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 23s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
4m  6s
the patch passed

+1 :green_heart:
compile
0m 55s
the patch passed

+1 :green_heart:
javac
0m 55s
the patch passed

+1 :green_heart:
shadedjars
6m 53s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 40s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
2m 25s
hbase-client in the patch passed.

+1 :green_heart:
unit
7m  0s
hbase-shell in the patch passed.

39m  9s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2914/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2914

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux d1dcd45a212f 4.15.0-65-generic #74-Ubuntu SMP Tue Sep 17 17:06:04 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2 / b930ea1ebb

Default Java
AdoptOpenJDK-11.0.6+10

Test Results
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2914/2/testReport/

Max. process+thread count
2119 (vs. ulimit of 12500)

modules
C: hbase-client hbase-shell U: .

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2914/2/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 51s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ branch-2 Compile Tests _

+0 :ok:
mvndep
0m 14s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
4m 24s
branch-2 passed

+1 :green_heart:
compile
1m 47s
branch-2 passed

+1 :green_heart:
checkstyle
0m 53s
branch-2 passed

+1 :green_heart:
spotbugs
1m 27s
branch-2 passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 15s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
4m 19s
the patch passed

+1 :green_heart:
compile
1m 48s
the patch passed

+1 :green_heart:
javac
1m 48s
the patch passed

+1 :green_heart:
checkstyle
0m 54s
the patch passed

-0 :warning:
rubocop
0m  9s
The patch generated 57 new + 177 unchanged - 0 fixed = 234 total (was 177)

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
hadoopcheck
12m 35s
Patch does not cause any errors with Hadoop 3.1.2 3.2.1.

+1 :green_heart:
spotbugs
1m 17s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
0m 23s
The patch does not generate ASF License warnings.

39m 17s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2914/2/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2914

Optional Tests
dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile rubocop

uname
Linux 81a250e1caa9 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2 / b930ea1ebb

Default Java
AdoptOpenJDK-1.8.0_232-b09

rubocop
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2914/2/artifact/yetus-general-check/output/diff-patch-rubocop.txt

Max. process+thread count
96 (vs. ulimit of 12500)

modules
C: hbase-client hbase-shell U: .

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2914/2/console

versions
git=2.17.1 maven=3.6.3 spotbugs=3.1.12 rubocop=0.80.0

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 51s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ branch-2 Compile Tests _

+0 :ok:
mvndep
0m 14s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
4m 24s
branch-2 passed

+1 :green_heart:
compile
1m 47s
branch-2 passed

+1 :green_heart:
checkstyle
0m 53s
branch-2 passed

+1 :green_heart:
spotbugs
1m 27s
branch-2 passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 15s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
4m 19s
the patch passed

+1 :green_heart:
compile
1m 48s
the patch passed

+1 :green_heart:
javac
1m 48s
the patch passed

+1 :green_heart:
checkstyle
0m 54s
the patch passed

-0 :warning:
rubocop
0m  9s
The patch generated 57 new + 177 unchanged - 0 fixed = 234 total (was 177)

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
hadoopcheck
12m 35s
Patch does not cause any errors with Hadoop 3.1.2 3.2.1.

+1 :green_heart:
spotbugs
1m 17s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
0m 23s
The patch does not generate ASF License warnings.

39m 17s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2914/2/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2914

Optional Tests
dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile rubocop

uname
Linux 81a250e1caa9 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2 / b930ea1ebb

Default Java
AdoptOpenJDK-1.8.0_232-b09

rubocop
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2914/2/artifact/yetus-general-check/output/diff-patch-rubocop.txt

Max. process+thread count
96 (vs. ulimit of 12500)

modules
C: hbase-client hbase-shell U: .

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2914/2/console

versions
git=2.17.1 maven=3.6.3 spotbugs=3.1.12 rubocop=0.80.0

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
3m 41s
Docker mode activated.

-0 :warning:
yetus
0m  7s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ branch-2 Compile Tests _

+0 :ok:
mvndep
0m 19s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
5m 24s
branch-2 passed

+1 :green_heart:
compile
1m  8s
branch-2 passed

+1 :green_heart:
shadedjars
8m 25s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 53s
branch-2 passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 19s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
5m  5s
the patch passed

+1 :green_heart:
compile
1m  3s
the patch passed

+1 :green_heart:
javac
1m  3s
the patch passed

+1 :green_heart:
shadedjars
7m  1s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 36s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
2m 41s
hbase-client in the patch passed.

+1 :green_heart:
unit
8m 21s
hbase-shell in the patch passed.

46m 34s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2914/2/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2914

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 09a5f5ae1589 4.15.0-101-generic #102-Ubuntu SMP Mon May 11 10:07:26 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2 / b930ea1ebb

Default Java
AdoptOpenJDK-1.8.0_232-b09

Test Results
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2914/2/testReport/

Max. process+thread count
1365 (vs. ulimit of 12500)

modules
C: hbase-client hbase-shell U: .

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2914/2/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
3m 41s
Docker mode activated.

-0 :warning:
yetus
0m  7s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ branch-2 Compile Tests _

+0 :ok:
mvndep
0m 19s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
5m 24s
branch-2 passed

+1 :green_heart:
compile
1m  8s
branch-2 passed

+1 :green_heart:
shadedjars
8m 25s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 53s
branch-2 passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 19s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
5m  5s
the patch passed

+1 :green_heart:
compile
1m  3s
the patch passed

+1 :green_heart:
javac
1m  3s
the patch passed

+1 :green_heart:
shadedjars
7m  1s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 36s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
2m 41s
hbase-client in the patch passed.

+1 :green_heart:
unit
8m 21s
hbase-shell in the patch passed.

46m 34s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2914/2/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2914

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 09a5f5ae1589 4.15.0-101-generic #102-Ubuntu SMP Mon May 11 10:07:26 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2 / b930ea1ebb

Default Java
AdoptOpenJDK-1.8.0_232-b09

Test Results
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2914/2/testReport/

Max. process+thread count
1365 (vs. ulimit of 12500)

modules
C: hbase-client hbase-shell U: .

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2914/2/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.


[Bug]: Multiple Podfile.lock files overwrite each other during submission

What happened?
This is based on a review of the code plus work on other dependency submission actions, so it's not confirmed but a likely issue.
The GitHub dependency submission API uses the commit (hash), the 'tool name', and the 'job correlator' as a unique identity as part of a dependency submission. If a second submission occurs with the same values, it will overwrite the earlier one.
If a lockfile is not specified as an argument, __main__.py will check for every lock file beneath the current directory. For each file, depgraph.submitDependencies is called.
submitDependencies calls Dependencies.exportBOM which uses a constant tool value for the job.correlator, job.id, and detector.name.  The tool name is a constant defined at https://github.com/advanced-security/cocoapods-dependency-submission-action/blob/47fe65643f5dcc2116c85274d11c83d0915449dd/cpdsa/init.py#L1
If I'm right, this means that subsequent podfiles will overwrite earlier ones. In addition, if a user manually specifies a value for cocoapods-lock it bypasses walking the directory tree finding podfiles and directly submits the specified one. This is also an issue if a caller uses the action more than once - e.g. manually specifying two podfiles in via a workflow matrix, which would cause a race condition.
The Maven dependency submission action had a similar issue, which had a workaround added at https://github.com/advanced-security/maven-dependency-submission-action/pull/88. There was some interesting feedback on potentially adding the path of a file as part of the correlator as a long term work around.
My suggestion for a fix:

Compute a hash of the relative path to each podfile.lock (e.g. SHA256('./path1/path2/path3/path3/Podfile.lock')). Append the hash to the job id of the run (the other submission actions use the job id as the correlator) or use the hash as-is as the correlator. Correlators are truncated to a max length of 255, so hashing helps avoid issues with long paths in repos.
Use the workflow run id as the default value for job.id. This matches the other actions. It's unclear whether there's any issue with submitting a constant, but the API design seems to want a unique value per submission here.

Hopefully that helps! Alternately, go pester someone else at GitHub to add direct support for parsing Podfile.lock files in Dependabot. Even if there's no vulnerability database for Cocoapods yet, 50% of iOS developers still use Cocoapods and React Native (heavily used) still seems dependent on that ecosystem. 😎
Version
v1
Relevant log output
No response

@ebickle thank you for submitting this bug. Let me add it to my backlog next week and resolve this for you


Add Dark Mode Support to Vue Package

RockBand currently uses Nuxt Color Mode to enable theme toggling in the Nuxt module distribution of the package. This unfortunately leaves the Vue version with a lack of support for the feature at this time...
Consider instead something like Vue Dark Mode from Vue A11y. This could be installed at the level of the Vue plugin, which the Nuxt module uses anyway.
The clearest guide to how we might achieve this is, I think, this quick little tutorial which lists all of the customisable props for the Dark Mode toggle component: https://www.vuescript.com/customizable-dark-mode/
Should also explore the Vue A11y project in further detail, given a want to focus on accessibility.

Addition Pro for Nuxt Color Mode

Better implementation of "system" dark mode

If default is set to "system", Vue Dark Mode does not respect this on initial load. On repeat loads, it does work if "system" is set in local storage... so why is this? It's probably an upstream bug - something like, on load of component check for stored variable to apply theme; logic that probably should fallback to whatever the given default is if that isn't set, but doesn't handle a default of "system" the way that it should.
Consider investigating the upstream package and adding an issue: https://github.com/vue-a11y/vue-dark-mode (Note that even though the package has not received an update in 2 years, the dev was active as of November 2021 discussing an issue and potential PR for the project).
I do still think the best option is to have just the one implementation handling dark mode (so doing without the Nuxt Color Mode module), at least for now. I don't think the Nuxt Color Mode module adds enough for me to consider having both, one for each level...
But I am going to keep it under consideration, because the Nuxt module does have baked in SSR support which is very nice to have.
Will deliver this as, but consider these future objectives:

Fork @vue-a11y/vue-dark-mode and fix implementation of 'system' for initial load, changing our default when we do so
Reimplement @nuxtjs/color-mode at the Nuxt module level; the additional SSR support is worth having

Closed by f9ac33511187620893c8a9e11ffbf56de8ab4fad


UART - POC task - To create sv files for multiple tests

to test the UART tile functionality and application.

See SV for testing here:
https://github.com/amichai-bd/riscv-multi-core-lotr/tree/master/verif/Tests/super_sorting_VGA
https://github.com/amichai-bd/riscv-multi-core-lotr/tree/master/verif/Tests/led_blinky
https://github.com/amichai-bd/riscv-multi-core-lotr/tree/master/verif/Tests/fpga_main

Make sure to add offset -> write to every Core
make sure to rest PC and free the rest
Connect VGA to see results
READ the C file of each test to understand what expected behavior

@ChrisShakkour  - let me know if you need anything else here.
closing this issue - please re-open if you need anything else


Enforce locality order in upstream HostsPerLocality

Commit Message: Enforce locality order in upstream HostsPerLocality
Additional Description:
Risk Level: Low
Testing: Tests modified to work with new assertions. One new test added. Existing core code already enforces this assertion.
Docs Changes: none
Release Notes: none
Platform Specific Features: none
Related issue: Sets up invariant necessary for fixing #28419

Most of the PR (all?) is fixing tests to declare a locality for all created HostsPerLocality objects so the invariant is true. No expected test behavior has been changed, I've just provided enough information in each test to accurately reflect the new assertion.

First, thanks for your contribution.
Seems all these new code is used to ensure the per-locality-host-list is in the expected order. I think this should be ensured by the construction of per-locality-host-list (check related code in the updateClusterPrioritySet method).
If you think additional insurance is necessary, or the method has potential bug, I think you can check/add unit tests for the updateClusterPrioritySet.
Although this patch should be harmless, but the code of upstream module is very complex and the community pay lots of time wants to simplify it. So, I would inclined to pend this PR.
If I was wrong or missed something, feel free to point it out. Thanks again. (And I am expecting your PR to fix #28419)

/wait-any

And I am expecting your PR to fix #28419

I should have made this more clear, but the idea is that in order to fix #28419 we need to enforce the invariant in HostsPerLocalityImpl that this PR documents. Without it, we don't have enough information to detect when zones are mismatches between local and upstream clusters.
To make this more clear, I will push out the actual fix so you can see how it fits in with the changes in this PR.

Although this patch should be harmless, but the code of upstream module is very complex and the community pay lots of time wants to simplify it.

I'm curious what efforts are ongoing/planned/desired in this area.

Created this dummy PR on my fork to show the planned changes to the zone-aware routing algorithm that this PR enables: https://github.com/AdamEAnderson/envoy/pull/1
PR is based on this branch, so it shows changes going forwards from here, including new tests to show the changed functionality.

/retest

Per-extension coverage failed:
Code coverage for source/common/upstream is lower than limit of 96.6 (96.4)

will work on improving that

This is lgtm. but wait for the coverage issue to be addressed.
/wait

/retest

had some CI flakes unrelated to the change:

mac build timed out, unsure why
Test flake with extension discovery:

[ RUN      ] IpVersionsClientType/ExtensionDiscoveryIntegrationTest.BasicSuccessWithTtl/2
libc++abi: terminating with uncaught exception of type Envoy::EnvoyException: Negative duration passed to durationToTimeval(): -2

Tests all passing now, should be good to go

friendly ping @wbpcode

Could you mrege the main first in case there are some unexpected CI problems? I think we can merge it after that.

/wait-any

/retest

/retest

is this a regression? as far as I can tell these failing/timing out CI tasks are unrelated from my changes


Configurable anchor naming

Once we have #2, it's probably reasonable to let the user configure the anchors' naming scheme. Here are a few reasonable alternatives:

cardinal (long)
north
east
south
west

cardinal (short)
n
e
s
w

relative (long)
top
right
bottom
left

relative (short)
t
r
b
l

While this looks like overkill, it's crucial for the user to be comfortable and able to instantly parse the ancor names.

After developments for #2 and #5 this would be kind of tricky.
Let's shelve this unless there's people really needing this.


Unable to load dynamic library 'couchbase.so' - undefined symbol: json_globals

Describe the bug
Enabling the couchbase extension fails with an error:
PHP Warning:  PHP Startup: Unable to load dynamic library 'couchbase.so'
(tried:
  /usr/lib/php/20190902/couchbase.so
    (/usr/lib/php/20190902/couchbase.so: undefined symbol: json_globals),
  /usr/lib/php/20190902/couchbase.so.so
    (/usr/lib/php/20190902/couchbase.so.so: cannot open shared object file: No such file or directory)
) in Unknown on line 0

To Reproduce
name: Tests

on:
    push:
    pull_request:

jobs:

    integration:
        name: Integration
        runs-on: ubuntu-latest

        strategy:
            matrix:
                php: ['7.2', '7.4']

        steps:
            -   name: Checkout
                uses: actions/checkout@v2

            -   name: Install system dependencies
                run: |
                    sudo wget -O - http://packages.couchbase.com/ubuntu/couchbase.key | sudo apt-key add -
                    echo "deb http://packages.couchbase.com/ubuntu bionic bionic/main" | sudo tee /etc/apt/sources.list.d/couchbase.list
                    sudo apt-get update
                    sudo apt-get install libcouchbase-dev

            -   name: Setup PHP
                uses: shivammathur/setup-php@v2
                with:
                    coverage: "none"
                    extensions: "json,couchbase,xsl"
                    ini-values: "memory_limit=-1"
                    php-version: "${{ matrix.php }}"
                    tools: flex,pecl

            -   name: PHP info
                run: php -i

Expected behavior
The extension is installed and enabled.
Screenshots

Additional context
One of my test builds can be found here: https://github.com/jakzal/symfony/runs/645215707?check_suite_focus=true
Stackoverflow says the json extension should be loaded before couchbase, but setup-php  seem to already load extensions in the order they're defined in the configuration.

I did some more digging. Extensions installed with pecl are registered at the top of the main php.ini file. This way these will always be loaded before any other extensions.

Moving couchbase registration like the following fixes the problem:
            -   name: Re-enable couchbase
                run: |
                    PHP_INI=$(php -i | grep 'Loaded Configuration File' | cut -f 5 -d ' ')
                    PHP_INI_EXTRA=$(php -i | grep 'additional .ini' | cut -f 9 -d ' ')
                    sudo sed -i'' 's/^extension="couchbase.so"/# extension="couchbase.so"/' $PHP_INI
                    sudo bash -c 'echo extension="couchbase.so" >> '$PHP_INI_EXTRA'/30-couchbase.ini'

Fixed. Updating the release now.

I guess you're referring to this commit? https://github.com/shivammathur/setup-php/commit/dccdb5ab679ff41ff0c6ffddfd383b1bc23cb9eb
That was quick! Thank you.

Yes. It should work now.
Here is a test workflow.
https://github.com/shivammathur/test-setup-php/actions/runs/96020131/workflow

I can confirm it has fixed my build as well. Thank you again!


javafx-8-tutorial-fr-part5

Yeah :-)
We need now someone to read the whole tutorial and make the last corrections.
Thank you boss!
Goodnight

Very nice! The French translation is complete! :star2: :+1:
Thanks for all your contributions @Davidmue, @chakram, @Nashka, @Kynarth!


Power monitoring

Is power output logged by this exporter? I was thinking about making some graphs of power used/generated per energy type and such.
If not, how hard do you think it would be to implement this?
Have a nice day!

+1; this would be a fantastic feature!


Tumbleweed installer runs out of memory with provided memory configuration

Apparently 512 is not enough for the installer.

I'm working on the definitions now. I already increased the memory locally to 1GB and I made it configurable through user variables. If everything builds fine locally I will publish the base images on atlas as well.

You can build it with packer build -var 'memory=2048' definitions/tumbleweed-x86_64.json now. The default value is 1024. Maybe there are errors while building it, I need to wait for systemsmanagement:chef:12 builds to try it finally if everything is working as expected.
I will close the issue for now, feel free to reopen it if something doesn't work.


setup requirements hardcode aiida-core version

The current setup requirements pin the aiida-core version:
https://github.com/abelcarreras/aiida-lammps/blob/8660201047984c8a28efbffaadb2b71c86ba19fc/setup.json#L10
Please replace this with something like aiida-core>=1.0.0b3

Wanted to create the same issue, but it is already here.  Thanks @ltalirz

I'll fix this eventually in #13


[INFINITY-2359] Disable kafka tls in stable

This removes the Kafka TLS settings from the stable branch. I've simply removed them from config.json and the docs. The overall plumbing still exists.

(Customers who want to try TLS will consume the beta packages from master.

Yes, I omitted the guides as the functionality is indeed present and would be hard to rip out.


Missing observations for inital shots (bootstrap_reconstruction)

When using the incremental reconstruction the reconstruction is seeded with a first inital camera-pair (bootstrap_reconstruction) and afterwards grown by adding single images (grow_reconstruction). I noticed that in the grow-phase the images are resected and on success the shots are added, triangulated and the observations added to the tracks_manager.
This last step (add_observation_to_reconstruction) however is never called on the first two shots which are used to initialize the reconstruction. Now I'm wondering if this is intended?
If this is a mistake, I'm happy to submit a PR.

@fabianschenk Hej Fabian, any idea, who can answer my question resp. decide if a PR is desired?

Hi @kielnino ,
I don't know if this is a bug or intended. Have you tried adding the observations and did you see any difference in quality?
Shouldn't this just be a 2-3 line PR, so quite easy to test?
Just to mention it again: Our priorities have changed and we're not actively developing OpenSfM anymore, so you'll likely not get much feedback from anybody else. If you set up a PR, I can add it but that's about it.
Best Fabian

I've tested the supposed change and didn't noticed any differences. So I'm closing the issue.


more "dynamic" project info

At the moment, the content of project-info is static. So there will be an output of "Using JSPM: false", even if (in theory) there is no JSPM plugin. Or in other words: there is no way for a third-party plugin to register some output in project-info itself.
Maybe we can <compose> this information if any project-info-item component is present in a plugin.

:+1:


Hitman 3 (Contracts) - missing menu options

The main menu options in Hitman 3 (Contracts) are not rendered with d8vk, unless PostFilterLOD 1 is changed to PostFilterLOD 0 in HitmanContracts.ini. WineD3D doesn't exhibit this problem.
Software information
HItman 3 - Contracts (GOG)
System information

GPU: Intel Xe (TigerLake GT2)
Driver: ANV/23.0.99
Wine version: 7.22 Staging
DXVK version: d0f5903

Apitrace file(s)
HitmanContracts.trace.tar.xz
Log files

d3d8.log: HitmanContracts_d3d8.log
d3d9.log: HitmanContracts_d3d9.log

The menu is now visible even with PostFilterLOD 1.

One additional problem with the game is mentioned in #86, but I'm closing this as resolved.


battery.ipynb   v1.7.3 error

Hi Tony, as requested;
HV BMS v1    with f/w 1.020
8x HV2600 v1   with f/w 1.06
Produces following error;
ValueError                                Traceback (most recent call last)
 in <cell line: 2>()
1 # Run this cell to get information about your battery
----> 2 f.battery_info()
1 frames
/usr/local/lib/python3.10/dist-packages/foxesscloud/foxesscloud.py in get_batteries(info)
682         if b.get('info') is not None and b['info']['masterVersion'] >= '1.014':
683             residual_handling = 2
--> 684         capacity = b['ratedCapacity'] / 1000 * int(b['soh']) / 100
685         soc = b.get('soc')
686         residual = capacity * soc / 100 if capacity is not None and soc is not None else capacity
ValueError: invalid literal for int() with base 10: '--'

Thanks. The error is because the v1 BMS is returning an invalid SoH but it would also be useful to know what other correct / incorrect info is being returned.
Please can you run a cell with this, after the error and screen shot the results:
f.batteries

I've made some updates on v1.7.4 but it is still possible that the v1 BMS is reporting different values for 'capacity' and 'residual'.

Thanks Tony, I'm now getting a different error.
I'm guressing this is 1.7.4 but not sure as when I run the initial cell it doesn't show the version number below the cell after it's run (it definitely did with 1.7.3).
Anyway this is the new error I get with the f.battery_info cell

But I can still run f.batteries and this is the result;

The token is invalid because it has expired. You need to restart the kernel and run cell 1 again. Under Runtime in the menu, select Disconnect and delete runtime. Then select Run All and it will reload the library and regenerate the token. You will get a different result.
However, from looking at the data, you have there, it looks like I may need to do some more updates so it calculates the capacity correctly.

Brilliant, yes it does now work. But I notice that residual/capacity don't show what I was expecting.
Capacity is showing  19.27kWh - I would expect 20.48kWh (8* 2.56) and 19.27 kWh is what register 11037 is showing (BMS kWh remaining).
----------------------- BMS 1 -----------------------
SN 67BBHV1xxxxx, HV2600, Version 1.020 (BMS)
SN 672H262xxxxx, HV2600, Version 1.06 (Battery 1)
SN 672H262xxxxx, HV2600, Version 1.06 (Battery 2)
SN 672H262xxxxx, HV2600, Version 1.06 (Battery 3)
SN 602H262xxxxx, HV2600, Version 1.06 (Battery 4)
SN 672H262xxxxx, HV2600, Version 1.06 (Battery 5)
SN 672H262xxxxx, HV2600, Version 1.06 (Battery 6)
SN 672H262xxxxx, HV2600, Version 1.06 (Battery 7)
SN 672H262xxxxx, HV2600, Version 1.06 (Battery 8)
Current SoC:         96%
Capacity:            19.27kWh                                    <<<<<<<<<
Residual:            18.50kWh (SoC x Capacity)         <<<<<<<<<
InvBatVolt:          423.7V
InvBatCurrent:       0.0A
State:               Discharging (0.000kW)
Battery Count:       8 batteries with 16 cells each
Battery Volts:       423.9V total, 52.98V average, 52.99V maximum, 52.96V minimum
Cell Volts:          3.311V average, 3.315V maximum, 3.307V minimum
Cell Imbalance:      0.24%:
BMS Temperature:     23.8°C
BMS Charge Rate:     10.0A (estimated)
Battery Temperature: 21.9°C average, 25.0°C maximum, 20.0°C minimum
Info by battery:
Battery 1: 52.99V, Cell Imbalance = 0.09%, Average Cell Temperature = 22.9°C
Battery 2: 52.99V, Cell Imbalance = 0.12%, Average Cell Temperature = 22.4°C
Battery 3: 52.97V, Cell Imbalance = 0.09%, Average Cell Temperature = 21.6°C
Battery 4: 52.97V, Cell Imbalance = 0.03%, Average Cell Temperature = 21.2°C
Battery 5: 52.96V, Cell Imbalance = 0.15%, Average Cell Temperature = 22.1°C
Battery 6: 52.99V, Cell Imbalance = 0.06%, Average Cell Temperature = 21.9°C
Battery 7: 52.98V, Cell Imbalance = 0.03%, Average Cell Temperature = 21.2°C
Battery 8: 52.99V, Cell Imbalance = 0.18%, Average Cell Temperature = 21.5°C

Yes, that's what I expected would be wrong when I saw your data. Fox is returning a ratedCapacity of 20.48kWh. For the v1 BMS, the Residual returned is the Residual Energy but as you have BMS firmware 1.020, it is expecting this to be Residual Capacity (which is what BMS v2 returns).
With a Residual of 19.27kWH at 96% SoC, the capacity should be 20.07kWh. That gives you an SoH of 98%. To me, that sounds high unless your batteries are only a few months old?
Basically, Fox really don't do a great job of tracking the actual battery capacity in BMS v1 or v2.

I've pushed v1.7.5. Hopefully, this will resolve the capacity and residual as it now differentiates between BMS v1 and v2 based on the BMS serial number. There's a good chance it will still get this wrong for ECS as I don't have specific examples of what the newer firmware returns for residual yet.
I've added an estimate of SoH based on the current capacity and rated capacity. I don't think the Fox report capacity accurately (certainly for BMS v2 in my experience) so treat this as indicative of where SoH might be, based on the data Fox does provide.

Turns out ECS returns a value of 0 for ratedCapacity and causes a divide by zero error when calculating SoH.
I've pushed another update (1.76) that should fix this. Please can you give it a spin when you get a chance and confirm that this still works for you? Thanks.

Thanks Tony, yes 1.7.6 works great :)
Current SoC:         96%
Capacity:            19.77kWh (Residual / SoC x 100)
Residual:            18.98kWh
Rated Capacity:      20.48kWh
SoH:                 96.5% (Capacity / Rated Capacity x 100)
InvBatVolt:          423.5V
InvBatCurrent:       0.0A
State:               Charging (0.089kW)
Battery Count:       8 batteries with 16 cells each
Battery Volts:       423.8V total, 52.97V average, 52.98V maximum, 52.96V minimum
Cell Volts:          3.311V average, 3.312V maximum, 3.309V minimum
Cell Imbalance:      0.09%:
BMS Temperature:     23.4°C
BMS Charge Rate:     15.0A (estimated)
Battery Temperature: 20.8°C average, 25.0°C maximum, 19.0°C minimum
Info by battery:
Battery 1: 52.97V, Cell Imbalance = 0.09%, Average Cell Temperature = 21.4°C
Battery 2: 52.97V, Cell Imbalance = 0.09%, Average Cell Temperature = 21.0°C
Battery 3: 52.97V, Cell Imbalance = 0.09%, Average Cell Temperature = 19.9°C
Battery 4: 52.96V, Cell Imbalance = 0.06%, Average Cell Temperature = 21.0°C
Battery 5: 52.97V, Cell Imbalance = 0.09%, Average Cell Temperature = 20.9°C
Battery 6: 52.98V, Cell Imbalance = 0.06%, Average Cell Temperature = 20.1°C
Battery 7: 52.98V, Cell Imbalance = 0.06%, Average Cell Temperature = 19.9°C
Battery 8: 52.97V, Cell Imbalance = 0.06%, Average Cell Temperature = 22.0°C


File view: add folder path breadcrumbs to top of page

Hypothesis: it will provide extra helpful context for viewers to see the directory structure at the top of the page, and to navigate to similar content via it.
Add a breadcrumb list of folder paths to the file view page.

OK actually I think this one's already there


Invalid API endpoint for fetching gas estimate

Currently the readme advises to use: https://www.etherchain.org/api/gasPriceOracle which is no longer available and gives an 'unable to fetch' error. Recommend using https://beaconcha.in/api/v1/execution/gasnow, which is where you are redirected if navigating to https://etherchain.org/api/gasnow on browser.

The issue is fixed now


How to filter one grid for the other?

Does anyone know how to do this?
Can you show some examples?
(Translated by Google)

Nope, there is no such example, maybe laters.

Thanks.


Command should scaffold if no files in dir, otherwise serve

closed in https://github.com/gabrielflorit/blockup/commit/6c76d462bdf0308ac5f07397426b32515d433822


Wrong import

The document says to import from '@microsoft/sp-property-pane', but it is '@microsoft/sp-webpart-base'.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 6c25a90e-829c-b436-d8ab-f9c010588ee1
Version Independent ID: 768fa9a1-2375-fb5a-be58-cb66320cc789
Content: Build your first SharePoint client-side web part (Hello World part 1)
Content Source: docs/spfx/web-parts/get-started/build-a-hello-world-web-part.md
Product: sharepoint
Technology: sharepoint-framework
GitHub Login: @spdevdocs
Microsoft Alias: spdevdocs

Your comment is incorrect... in the latest generator (v1.8+), the property pane objects were refactored to their own package as the doc says. There are still "maps" to them in the sp-webpart-base package, but those will be removed in v1.9.0). See the 1.8 release docs for more details: https://github.com/SharePoint/sp-dev-docs/wiki/SharePoint-Framework-v1.8-release-notes#removing-propertypane-code-out-of-sp-webpart-base

I think regardless of who's comment is right or wrong. Following the instructions on this page fails due to the import of microsoft/sp-property-pane
because microsoft/sp-webpart-base already exists after you create the project. but if you remove the contents of the microsoft/sp-webpart-base import then the project just continues with more issues.


Upgrade to nginx 1.9.5

Nginx 1.9.5 brings http2 http://nginx.org/en/CHANGES
Any plans on upgrading soon?

Hello @lawrencetaur ,
Nginx 1.9.5 is mainline release which is still in development. In EasyEngine we use Nginx stable release which is 1.8.0


Some more to add

I have recently switched to running Arch and have some suggestions.
I have been clearing dependencies which are unneeded and the command for that is
sudo pacman  -R $(pacman Q-dtq)
and just for orphan dependencies you just run the same but run what is it inside of the brackets.
I know this feature isn't a thing with apt but it is still a useful command
PS: do you actually use Arch

PS: do you actually use Arch

I use it a bit on my pi4 when I need ode stuff, and from today on my new PineBook Pro

I think I already added that, but used a slightly different command I got from here
https://github.com/Itai-Nelken/aptpac/blob/3a6f16cf87a6a2dc173a06a6d277c01815dc877c/aptpac.sh#L101-L104

that removes unneeded packages, the equivalent of apt autoremove
BTW can you test the C version? I just made it get all the packages after the command, so apt pac install package1 package2 instead of apt pac install "package1 package2". the bash version already does that for some time.

That pinebook is a little bit more money, should of picked a thinkpad

Ill give it a look later

PS: do you actually use Arch

I use it a bit on my pi4 when I need ode stuff, and from today on my new PineBook Pro

Are you using actual arch or manjaro

PS: do you actually use Arch

I use it a bit on my pi4 when I need ode stuff, and from today on my new PineBook Pro

Are you using actual arch or manjaro

manjaro, forgot to mention that.

That pinebook is a little bit more money, should of picked a thinkpad

I needed a new smaller laptop with a battery that actually lasts, and I wanted a pinebookpro, and the pinebookpro can do everything I need. so I bought it.

I'm closing this as the feature you asked for is already implemented. feel free to reply with any questions you have.

Re open this please.
I have run read and run the code and the C version is pretty impressive.
You NEED to implement:
show
purge

moving your 'learning mode' feature request to here @CleanMachine1

summary of all feature requests oin this issue and progress on them:

purge
show

@CleanMachine1 what do you mean by show? what do you mean it to do?

added both commands :)

actually 3 commands:
purge, how, & show-all

How?

Nevermind