Nested foreach loop reports outer loop's index variable as its own in UHDM tree

It looks like variables from non-last [...] are treated as loop variables.
Reference:
[1]: IEEE Std 1800-2021 "IEEE Standard for SystemVerilog", 12.7. Loop statements
Syntax:
foreach '(' ps_or_hierarchical_array_identifier '[' loop_variables ']' ')' statement

Example (https://github.com/chipsalliance/Surelog/blob/master/tests/ForeachSquare/dut.sv):
module dut;

    int array[16][16];

    initial begin
        foreach(array[i])
            foreach(array[i][j])
                array[i][j] = i * j;
    end

endmodule

\_foreach_stmt: (work@dut), line:7:13, endln:7:20
  |vpiParent:
  \_foreach_stmt: (work@dut), line:6:9, endln:6:16
  |vpiFullName:work@dut
  |vpiVariables:
  \_ref_var: (work@dut.array), line:7:21, endln:7:26  ─┒
    |vpiParent:                                        ┃
    \_foreach_stmt: (work@dut), line:7:13, endln:7:20  ┃ Should refer to
    |vpiTypespec:                                      ┃ `dut.array[i]`?
    \_array_typespec:                                  ┃
    |vpiName:array                                     ┃
<EMAIL_ADDRESS>                     ─┚
  |vpiLoopVars:                                       ─┒
  \_ref_var: (work@dut.i), line:7:27, endln:7:28       ┃
    |vpiParent:                                        ┃ This is a loop variable
    \_foreach_stmt: (work@dut), line:7:13, endln:7:20  ┃ of the outer `foreach`,
    |vpiTypespec:                                      ┃ not this one.
    \_int_typespec: , line:3:5, endln:3:8              ┃
    |vpiName:i                                         ┃
<EMAIL_ADDRESS>                         ─┚
  |vpiLoopVars:
  \_int_var: (j), line:7:30, endln:7:31
    |vpiTypespec:
    \_int_typespec: , line:3:5, endln:3:8
      |vpiSigned:1
    |vpiName:j
  |vpiStmt:
  ...

This is non - synthesizable code. Let's focus on synthesizable code for the Yosys plugin.

Please provide a synthesizable example we can formally verify

This one should be syntesizable:
module dut(input clk);
    logic [31:0] array[4][4];
    always @(posedge clk) begin
        foreach(array[i])
            foreach(array[i][j])
                array[i][j] = i * j;
    end
endmodule

Relevant fragments of UHDM tree (command: surelog -parse -d uhdm):
...
|vpiStmt:
\_foreach_stmt: (work@dut), line:4:9, endln:4:16
  |vpiParent:
  \_begin: (work@dut), line:3:27, endln:7:8
  |vpiFullName:work@dut
  |vpiVariables:
  \_ref_var: (work@dut.array), line:4:17, endln:4:22
    |vpiParent:
    \_foreach_stmt: (work@dut), line:4:9, endln:4:16
    |vpiTypespec:
    \_array_typespec:
    |vpiName:array
<EMAIL_ADDRESS>  |vpiLoopVars:
  \_logic_var: (i), line:4:23, endln:4:24
    |vpiTypespec:
    \_logic_typespec: , line:2:5, endln:2:17
      |vpiRange:
      \_range: , line:2:11, endln:2:17
        |vpiLeftRange:
        \_constant: , line:2:12, endln:2:14
          |vpiParent:
          \_range: , line:2:11, endln:2:17
          |vpiDecompile:31
          |vpiSize:64
          |UINT:31
          |vpiConstType:9
        |vpiRightRange:
        \_constant: , line:2:15, endln:2:16
          |vpiParent:
          \_range: , line:2:11, endln:2:17
          |vpiDecompile:0
          |vpiSize:64
          |UINT:0
          |vpiConstType:9
    |vpiName:i
  |vpiStmt:
  \_foreach_stmt: (work@dut), line:5:13, endln:5:20
    |vpiParent:
    \_foreach_stmt: (work@dut), line:4:9, endln:4:16
    |vpiFullName:work@dut
    |vpiVariables:                                        ─┒
    \_ref_var: (work@dut.array), line:5:21, endln:5:26     ┃
      |vpiParent:                                          ┃
      \_foreach_stmt: (work@dut), line:5:13, endln:5:20    ┃ Should refer to
      |vpiTypespec:                                        ┃ `dut.array[i]`?
      \_array_typespec:                                    ┃
      |vpiName:array                                       ┃
<EMAIL_ADDRESS>                       ─┚
    |vpiLoopVars:                                         ─┒
    \_ref_var: (work@dut.i), line:5:27, endln:5:28         ┃
      |vpiParent:                                          ┃ This is a loop variable
      \_foreach_stmt: (work@dut), line:5:13, endln:5:20    ┃ of the outer `foreach`,
      |vpiTypespec:                                        ┃ not this one.
      \_logic_typespec: , line:2:5, endln:2:17             ┃
      |vpiName:i                                           ┃
<EMAIL_ADDRESS>                           ─┚
    |vpiLoopVars:
    \_logic_var: (j), line:5:30, endln:5:31
      |vpiTypespec:
      \_logic_typespec: , line:2:5, endln:2:17
        |vpiRange:
        \_range: , line:2:11, endln:2:17
          |vpiLeftRange:
          \_constant: , line:2:12, endln:2:14
            |vpiParent:
            \_range: , line:2:11, endln:2:17
            |vpiDecompile:31
            |vpiSize:64
            |UINT:31
            |vpiConstType:9
          |vpiRightRange:
          \_constant: , line:2:15, endln:2:16
            |vpiParent:
            \_range: , line:2:11, endln:2:17
            |vpiDecompile:0
            |vpiSize:64
            |UINT:0
            |vpiConstType:9
      |vpiName:j
    |vpiStmt:
    ...

I changed the testcase into to make it useful for Synthesis comparison (Observable):
module dut(input clk, output logic [31:0] data[4][4]);
    always @(posedge clk) begin
        foreach(data[i])
            foreach(data[i][j])
                data[i][j] = i * j;
    end
endmodule

I made a fix in #3243 to get the right typespec for data when it is a port (Not a variable).
You need to check the elaborated model to get more accurate binding. I think the elaborated model contains the correct bindings for the variable and the loop vars.
To the question: Should refer to  dut.array[i]?
my answer is no, the variable is array, the loop var is i.


Is ssh authentication supported?

Our Gerrit server requires ssh authentication, which works fine with git review CLI. Gerrit version is 2.16.22

If you're asking whether it's possible to replace the HTTP credentials with SSH authentication, then the answer is unfortunately no. Gerrit only allows access to the API with the HTTP credentials and only exposes a few APIs to the SSH-authenticated flow.

Although not as full featured, there's another VSCode Gerrit extension I'm evaluating (Gerrit-View) that does support ssh authentication through an ssh library.
After looking through the gerrit-view code, it's clear it's issuing commands via the CLI over SSH rather than HTTP-based requests. I'll ask our Gerrit admins if HTTP access is allowed. The devops folks can be wary of developers writing runaway scripts that can hammer Gerrit.

Yeah it looks like that extension is a lot more basic and just lists the patches. This one also allows you to do other stuff like viewing/posting comments and replying to patches. Those things are not possible over SSH so they need HTTP access.
To ease your admins' pain, your rights are the same for SSH and HTTP requests. You can't really do more harm than you could do over SSH.
I'll be closing this issue now but feel free to reply if you have any more questions.


Changing max_depth and planning_time for POMCP

Hello!
I am working on the same problem discussed in #27 and, as the problem includes a limit of time-steps for each trial, I am trying to model it as a finite-horizon POMDP. As such, I would like to initialize POMCP with a max_depth equal to the maximum number of time-steps for the trial, and then change it every time step so each simulation takes into account the horizon when planning online. I noticed that the belief for a given state reaches 1 at times and the agent does not make a decision until the last or second-to-last time-step, and I thought that may be a potential cause.
However, I am getting an error saying that POMCP has no attribute max_depth (or _max_depth). What can I do?
On a similar fashion, I would like to change the planning time. At the beginning of each trial, the model has 0.5 seconds to plan, then 0.1 seconds at each time-step.

then change it every time step so each simulation takes into account the horizon when planning online.

I’m not following. Pseudocode would help. What exactly goes on in the for loop?

I noticed that the belief for a given state reaches 1 at times and the agent does not make a decision until the last or second-to-last time-step, and I thought that may be a potential cause.

Same comment as above.

However, I am getting an error saying that POMCP has no attribute max_depth (or _max_depth). What can I do?

I think I get what you’re trying to do. You’d like to change POMCP’s hyper parameters such as depth or sim time between planning steps. Currently, POMCP/POUCT doesn’t support changing hyper parameters after creation. But as I commented in the other thread, it is not costly to create these instances. The search tree is saved in the agent, not in the planner.

I think you understood, but let me provide pseudocode anyway:
for trial_n in range(n_trials):
    # Get information about true state and apply transition
    next_label = int(y_test[trial_n])
    true_state = TDState(next_label, 0)  # (state, time_step)
    bci_problem.env.apply_transition(true_state)

    for step_n in range(total_steps):
        # Here I would like to change the max_depth hyperparam
        remaining_steps = pomdp_steps - step_n
        POMCP._max_depth = remaining_steps

        # Same for planning time
        if remaining steps == pomdp_steps:
            planning_time = 0.5
        else:
            planning_time = 0.1

        POMCP._planning_time = planning_time

I noticed that the belief for a given state reaches 1 at times and the agent does not make a decision until the last or second-to-last time-step, and I thought that may be a potential cause.

Regarding this, I can show you a print of the belief I am doing for every trial at every time-step:
TRIAL 11 (true state s_0-t_0)
--------------------

  STEP 0 (6 steps remaining)
  Current belief:
        s_0-t_0 -> 0.086
        s_1-t_0 -> 0.091
        s_2-t_0 -> 0.069
        s_3-t_0 -> 0.083
        s_4-t_0 -> 0.095
        s_5-t_0 -> 0.095
        s_6-t_0 -> 0.085
        s_7-t_0 -> 0.084
        s_8-t_0 -> 0.078
        s_9-t_0 -> 0.063
        s_10-t_0 -> 0.079
        s_11-t_0 -> 0.092

  Action: a_wait
  Reward: -1.0. Transition to s_0-t_1
  Observation: o_1
Particle reinvigoration for 818 particles

  STEP 1 (5 steps remaining)
  Current belief:
        s_0-t_1 -> 0.02
        s_1-t_1 -> 0.671
        s_2-t_1 -> 0.015
        s_3-t_1 -> 0.019
        s_4-t_1 -> 0.072
        s_5-t_1 -> 0.022
        s_6-t_1 -> 0.026
        s_7-t_1 -> 0.036
        s_8-t_1 -> 0.05
        s_9-t_1 -> 0.013
        s_10-t_1 -> 0.025
        s_11-t_1 -> 0.031

  Action: a_wait
  Reward: -1.0. Transition to s_0-t_2
  Observation: o_3
Particle reinvigoration for 905 particles

  STEP 2 (4 steps remaining)
  Current belief:
        s_0-t_2 -> 0.021
        s_1-t_2 -> 0.581
        s_2-t_2 -> 0.011
        s_3-t_2 -> 0.25
        s_4-t_2 -> 0.033
        s_5-t_2 -> 0.019
        s_6-t_2 -> 0.018
        s_7-t_2 -> 0.021
        s_8-t_2 -> 0.014
        s_9-t_2 -> 0.01
        s_11-t_2 -> 0.022

  Action: a_wait
  Reward: -1.0. Transition to s_0-t_3
  Observation: o_1
Particle reinvigoration for 48 particles

  STEP 3 (3 steps remaining)
  Current belief:
        s_0-t_3 -> 0.001
        s_1-t_3 -> 0.964
        s_2-t_3 -> 0.002
        s_3-t_3 -> 0.025
        s_4-t_3 -> 0.001
        s_5-t_3 -> 0.001
        s_6-t_3 -> 0.001
        s_7-t_3 -> 0.002
        s_9-t_3 -> 0.001
        s_11-t_3 -> 0.002

  Action: a_wait
  Reward: -1.0. Transition to s_0-t_4
  Observation: o_1

  STEP 4 (2 steps remaining)
  Current belief:
        s_1-t_4 -> 1.0

  Action: a_wait
  Reward: -1.0. Transition to s_0-t_5
  Observation: o_0
Particle reinvigoration for 951 particles

  STEP 5 (1 steps remaining)
  Current belief:
        s_1-t_5 -> 1.0

  Action: a_wait
  Reward: -1.0. Transition to s_0-t_6
  Observation: o_0
Particle reinvigoration for 927 particles

  STEP 6 (0 steps remaining)
  Current belief:
        s_1-t_6 -> 1.0

  Action: a_1
  Reward: -100.0. Transition to s_7-t_0
Particle reinvigoration for 801 particles

Trial ended with decision a_1.
Decision took 0.9999999999999999s

...it is not costly to create these instances. The search tree is saved in the agent, not in the planner.

Ah, I see! So the planner just reads and writes the tree from/to the agent. Then if I understood correctly, I can just create an instance of the planner whenever I want to change the parameters? As in
for trial_n in range(n_trials):
    # Get information about true state and apply transition
    next_label = int(y_test[trial_n])
    true_state = TDState(next_label, 0)  # (state, time_step)
    bci_problem.env.apply_transition(true_state)

    for step_n in range(total_steps):
        # Here I would like to change the max_depth hyperparameter
        remaining_steps = pomdp_steps - step_n

        # Same for planning time
        if remaining steps == pomdp_steps:
            planning_time = 0.5
        else:
            planning_time = 0.1

        planner = POMCP(max_depth=remaining_steps, discount_factor=gamma,
                        planning_time=planning_time, exploration_const=110,
                        rollout_policy=agent.policy_model)

        action = planner.plan(problem.agent)

Yes in this case you would be planning with a finite horizon. You can give the last code block a try. Btw, if you have checked out, the tree debugger feature should be very helpful in this case for you to inspect the search tree and see if it is doing what you expect.

Thank you. It is nice that you bring up the tree debugger, as you mentioned it also on #27 when I asked about offline planning (i.e. planning only at the beginning of the trial and then using the tree for the rest of the trial). I have checked the documentation but I am not really sure what to check in this case.
I guess after each plan() call I can check agent.tree and check the depth to ensure it is not going past the intended horizon?

You can also use it to debug / trace down why a certain decision was made.

Could you explain further how to do this?

I'm mostly referring to traversing the tree through indexing, explained here.
You can find the definition of the search three in Figure 1 of the POMCP paper. But to explain it in a nutshell, the search tree contains two types of nodes, VNode and QNode.  Each VNode corresponds to some history h, and each QNode corresponds some history ha (that is, taking action a at history h). An action whose QNode has the maximum value is chosen for execution.

Thanks you for the explanation. After exploring the tree, I realized almost all simulations were done on the 'wait' action (the equivalent of 'listen') for my model. As a result, the value for a given action was only higher than wait on the last step of the model, even when all the observations are consistent with that action.
I changed the exploration constant to the default value (it was 110 before from the Tiger example), and that took care of the issue with the belief staying at 1.0 for several time steps.
On a separate note, I am now experimenting with how the confusion matrix is penalized in different time steps. Since each time step obtains observations that are based on more data, I wanted to smooth the confusion matrix as done in Park and Kim, 2012 (bottom of page 7, the equation is not numbered). I am using the same q0 parameter (0.3) for the last time step, increasing by 0.05 for each previous time step. With this modification, trials that receive incorrect observations on the beginning time steps now take longer to increase the belief on the corresponding state, giving the model time to (hopefully), receive the correct observations at later time steps and avoid false positives.
After I did that and explored the tree, I noticed the trials that produce false positives do so with a belief of 0.85. Could this be related to the exploration contant as well? Since the default value is a small number.

This sounds like a good thing.

Thank you! The only thing I don't like is that the values for the smoothing are arbitrary. I will also try to penalize the matrix row-wise, so instead of an heuristic prior on how much later steps are more precise than earlier steps, I let the uncertainty observed by the observation model decide how much each class needs to be penalized at each step.

I don't follow what "false positives" mean in this context

Sorry. It means to decide on taking any action that does not correspond with the true state of the environment. In the tiger example, it would be equivalent of the agent choosing 'open-left' when the tiger is on the right, or vice-versa.

Are you receiving "incorrect" observation when the belief of the true environment state is 0.85?

I am receiving incorrect observations for several time steps in succession, and that causes the belief for the state the observation corresponds with to reach 0.85. My intuition is that, even if that happens in earlier time steps, later time steps should (or are more likely to) receive the correct observation.

There is a lot of literature on UCB1 exploration constant. The heuristic from the POMCP paper is to set it to be R_hi - R_lo (but of course this is not a rule).

According to what I read from the POMCP paper, this requires running any given problem with an exploration constant of 0 to obtain one of the two parameters. That is not really practical in the case I am studying, so I will turn to the literature to see if I find any methods that are based on the observation model.


[Doc Improvement][Merged AC features]

Acrolinx Scorecards
We currently enforce a minimum score of 80.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/task-modules-and-cards/cards/cards-format.md
94
38
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

Acrolinx Scorecards
We currently enforce a minimum score of 80.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/mstdd-landing.yml
87
8
link
:white_check_mark:

msteams-platform/task-modules-and-cards/cards/cards-format.md
94
38
link
:white_check_mark:

msteams-platform/whats-new.md
90
93
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

Created this PR to merge information in the following PRs:

#11713
#11619
#11722
#11655

All these PRs are approved by FPM (David)


Proposal for new language feature for the short hand property

Feature Request
Is your feature request related to a problem? Please describe:
When I'm working I like convenience and flexibility, and that's why I love KCL! I have an idea that I think will push that frontier a bit further.
Describe the feature you'd like:
Javascript is a pretty horrible language, but there is one cool feature that came out in ES6 - object property shorthand!
In short, when creating objects, we can use shorthand notation to assign variables as object properties with the same name.
// normal assignment
function createMessage (message, id) {
  return {
    message: message,
    id: id,
    timestamp: Date.now()
  }
}
// shorthand
function createMessage (message, id) {
  return {
    message,
    id,
    timestamp: Date.now()
  }
}

In KCL, there could be shorthand assignment too, not only by variable name, but by type as well! Examples:
# let's define some basic schemas
schema CPUOptions:
    cores: int
    threads: int

schema DiskOptions:
    size: int
    $type: "sdd" | "hdd"

schema VirtualMachine:
    name: str
    cpu: CPUOptions
    disk: DiskOptions

# normal assignment
vm = VirtualMachine {
    name = "vm"
    cpu = CPUOptions { cores = 1, threads = 1}
    disk = DiskOptions { size = 32, $type = "ssd"}
}

# now lets add some matching names
name = "next_vm"
cores = 2
threads = 4
disk = DiskOptions { size = 8, $type = "hdd"}

# shorthand assignment by name
vm2 = VirtualMachine {
    name
    cpu = CPUOptions { cores, threads } # cores and threads also shorthand assigned by name
    disk
}

# shorthand assignment by type
vm3 = VirtualMachine {
    "last_vm"
    # cpu_options identifier is not necessary because VirtualMachine expects CPUOptions
    CPUOptions { cores = 4, threads = 8} # cores/threads cannot be shorthanded by type because they are both the same type and it's ambiguous
    # one DiskOptions is expected by VirtualMachine
    DiskOptions { 32, "ssd"} # + int and str can also omit identified
}

Describe alternatives you've considered:
N/A, I just thought this feature was really cool
Teachability, Documentation, Adoption, Migration Strategy:
As a bonus if that would work outside schemas and instances, that would be so convenient. Currently, I'm working on IaC tool and if I define e.g. one provider (like terraform provider) in a file, why should I add identifier to unique resource (I know it probably have very logical reason, but like I said, I like flexibility 😃)? But, when I need to add second instance, another shorthand instance cannot be added and I must use identifier.
Example:
Kubernetes {
  host = example.tdd
  context = rancher-asd
}

my_other_cluster = Kubernetes {
  host = localhost
  context = minikube
}

That's all from me, let me know what you think!

Yes. Many languages like javascript and rust have this feature and syntax sugar. For KCL, it is also a good feature that can be implemented. 👍


Announce copy to clipboard action

Fix screen reader not announcing any information upon activating 'Copy to Clipboard' button
References
Related to https://github.com/github/accessibility-audits/issues/2795

Considered options:

Focus a hidden element with the announcement text. Doesn't work nice for Safari tried workarounds, not working and it is becoming hackish and ugly.
Create a notification/toast element and style it GitHub way (https://primer.style/css/components/toasts) - didn't figure out how to use the .Toast class, didn't find any usage across wubwub and documentation projects.
Primer React doesn't seem to have a notification/toast component. The closest thing to that is the Dialog. Customizing it would require a lot of effort, IMO.
Gatsby seems to have a notification feature, but it is probably only for system/its own usage - couldn't find a way to use it from a theme. Gatsby plugins seem to be about build time notifications and not web notifications.

I now want to make a notification component like in wubwub. Since it seems it is the only proper way to solve issue.


Wrap: Optimize mapping of game files to mods files

Seems to work, although I got some Code 5 error of EasyHook sometimes while testing

I have not tested the third case, when there is no extraFolders and conditional folders


build(deps): datafusion 41

Upgrades datafusion and associated crates to version 41. 42 was just released which also has an arrow update to 53.
We're looking to adopt lance in our service where we've already upgraded to 41 for some other dependencies.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 77.80%. Comparing base (ea78168) to head (153919b).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2917      +/-   ##
==========================================
- Coverage   77.83%   77.80%   -0.03%
==========================================
  Files         231      231
  Lines       70199    70205       +6
  Branches    70199    70205       +6
==========================================
- Hits        54636    54626      -10
- Misses      12691    12693       +2
- Partials     2872     2886      +14

Flag
Coverage Δ

unittests
77.80% <100.00%> (-0.03%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

@wjones127 thanks! the python tests exposed another issue with ExprPlanners that the latest commit resolves

I ran this from the github workflow locally and it was successful. Any ideas on the failing java run in github?
export JAVA_TOOL_OPTIONS "$JAVA_TOOL_OPTIONS -XX:+IgnoreUnrecognizedVMOptions --add-opens=java.base/java.lang=ALL-UNNAMED --add-opens=java.base/java.lang.invoke=ALL-UNNAMED --add-opens=java.base/java.lang.reflect=ALL-UNNAMED --add-opens=java.base/java.io=ALL-UNNAMED --add-opens=java.base/java.net=ALL-UNNAMED --add-opens=java.base/java.nio=ALL-UNNAMED --add-opens=java.base/java.util=ALL-UNNAMED --add-opens=java.base/java.util.concurrent=ALL-UNNAMED --add-opens=java.base/java.util.concurrent.atomic=ALL-UNNAMED --add-opens=java.base/jdk.internal.ref=ALL-UNNAMED --add-opens=java.base/sun.nio.ch=ALL-UNNAMED --add-opens=java.base/sun.nio.cs=ALL-UNNAMED --add-opens=java.base/sun.security.action=ALL-UNNAMED --add-opens=java.base/sun.util.calendar=ALL-UNNAMED --add-opens=java.security.jgss/sun.security.krb5=ALL-UNNAMED -Djdk.reflect.useDirectMethodHandle=false -Dio.netty.tryReflectionSetAccessible=true"

mvn clean install

Any ideas on the failing java run in github?

This succeeds on Mac for me, but fails on Linux. So I think that's the reason.

Apologies for the delay. I've been trying to figure out what to do about the Java failure. It seems like we don't have the bandwidth or tooling yet to debug this issue, so we are going to just comment those tests out for now and leaving fixing them as a TODO.
https://github.com/lancedb/lance/issues/2956


could not connect to server

Hi
When using with Mac M1 and pressing the "all builds" button I get "could not connect to server
it seems https://uupdump.net is not working.

Not sure if its the same issue, but I always just get timeouts trying to load the "All builds..." list with 2.1.0 (4).

Ahh, looks like UUPDump has been down for the last 2 weeks or so: https://www.reddit.com/r/windowsinsiders/comments/16hci7n/is_uupdump_down_for_everyone/
There is https://www.uup.ee/ so I wonder if there is a way to point CrystalFetch at a different UUPDump site and/or a local instance.

UUPDump is still down. There should be an option to use alternative uup sites.

So I have tried to switch it out with UUPDump.ee - but that doesn't work because it doesn't have a json-api. I also tried uupdump.cn which does have a json-api but crystalfetch still spits out a "the data couldn't be read because" it isn't in the correct forma". I'm currently looking for other sources of UUP in hopes that it works.

https://uupdump.net seems like permanently down now...

 https://uupdump.net seems like permanently down now...

You can download the whole website source from there and use the JSON API via the local network though hmmm...
I think we need an option to select our own API endpoint URL

After some hacking around with both the UUPDump JSON API and CrystalFetch (to change it to point to a local version of the API running in a Docker instance) I did get a setup running locally that allowed me to download an experimental build.
I'll see if I can automate the UUPDump "distribution" stuff to make this work, and see if I can submit a PR to CrystalFetch to allow the UUPDump URL to be changed.
Broad steps (which needs more detail)

Get UUPDump into the right state (PHP 8.2 won't work OOTB due to some deprecations/warnings)git clone git@github.com:uup-dump/json-api.git --depth=1
cd json-api
git submodule init && git submodule update
git clone git@github.com:uup-dump/fileinfo.git --depth=1
git clone git@github.com:uup-dump/packs.git --depth=1
docker run -d -p 80:80 --name uupdump-json-api -v "$PWD":/var/www/html php:8.1-apache

Download and build CrystalFetch per the README
Change URL to http://<IP_ADDRESS>
https://github.com/TuringSoftware/CrystalFetch/blob/d0fbf0fe668c2966069d99e65fefc296d73b4bfd/Source/UUPDump/UUPDumpAPI.swift#L23
Now it seems to all work and allow me to build ISOs.

Is this the same thing ?
https://www.uupdump.cn/?lang=en-us
Seems to have various build of Windows OS, etc

I tried using uupdump.cn, however that does not work (usually with an error about the network connection was lost). I'll try locally hosting it in docker to see if works.

Yeah, it definitely works, although the data is slightly stale in uupdump's repos, so it's missing a few builds. Looks like the auto-updates of data into GitHub is also broken. e.g at time of writing it is missing this build)
This may reduce the usefulness of even running locally over time unless there are enough folks doing manual PRs.
https://github.com/uup-dump/packs/commits/master
https://github.com/uup-dump/fileinfo/commits/master

My PR to allow this to be configured is at https://github.com/TuringSoftware/CrystalFetch/pull/32 - not much help since you'd still need to build locally unless merged/released and could as easily edit the URL in the code for your local use, but might be a starting point for someone who knows SwiftUI better than I 🙏

Great news! About a week ago https://uupdump.net is open again!
...But as mentioned in #32 uupdump creates wrong iso for arm64


RangeError: Maximum call stack size exceeded when input array's length > 100k

Hi.
First off, thank you for this wonderful library – saved me having to code things up myself :)
I'm coming across an issue using json2csv with large arrays – in those cases, I get this error:
RangeError: Maximum call stack size exceeded
    at JSON2CSVParser.preprocessData (...node_modules/json2csv/dist/json2csv.cjs.js:4053:37)
    at JSON2CSVParser.parse (.../node_modules/json2csv/dist/json2csv.cjs.js:4017:32)
    at parse (..../node_modules/json2csv/dist/json2csv.cjs.js:4673:36)
    ...

Going through to code, it looks like it has to do with the Array.prototype.concat.apply([]) in this line of json2csv/dist/json2csv.cjs.js:
return Array.prototype.concat.apply([], processedData.map(function (row) {
        return _this2.preprocessRow(row);
}));

Here is some sample code to test it out:
const json2csv = require('json2csv').parse;

var ln = 200000; // change this to 100000 and it works.
var arr = [];
for(var i = 0; i < ln; i++){
  arr.push({
    key: i,
    value: i
  });
}

var fields = Object.keys(arr[0]);
var opts = { fields };
json2csv(arr, opts);

Note also that Array.apply(null, Array(ln)).map(function () {}) will give the same error unless you reduce ln to 10k-ish.
I'm running this on

json2csv version 4.0.0
node version 6.9.1

Thank you!

I see that you are using the synchronous API. We also have an async API which is meant for large datasets, have a look here: https://github.com/zemirco/json2csv#json2csv-transform-streaming-api

Fixed by my PR ^
In case case, as @knownasilya said. For such large dataset. The stream API is a much better fit since you won't need to have the entire objects (both JSON and CSV) in memory.

Published as v4.0.2


New university in Wroclaw

Adding new univeristy.

@DawidGrzejek Pull request merged. Thank you!

Hey,
Is it mean that now I can apply for free JetBrains license for students ?
Pozdrawiam,
Dawid Grzejek

Od: Philip Torchinsky<EMAIL_ADDRESS>Wysłano: piątek, listopada 1, 2019 9:16 AM
Do: JetBrains/swot
DW: DawidGrzejek; Mention
Temat: Re: [JetBrains/swot] New university in Wroclaw (#7071)
@DawidGrzejekhttps://github.com/DawidGrzejek Pull request merged. Thank you!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/JetBrains/swot/pull/7071?email_source=notifications&email_token=AKERERD2LOFGC7O4QYQUVOTQRPQVLA5CNFSM4JGYQS42YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEC2JDWQ#issuecomment-548704730, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AKERERDHIPDDLQZ4Q6VE3LTQRPQVLANCNFSM4JGYQS4Q.

Yes.

On 24. Nov 2019, at 11.57, DawidGrzejek<EMAIL_ADDRESS>wrote:
Hey,
Is it mean that now I can apply for free JetBrains license for students ?
Pozdrawiam,
Dawid Grzejek

Od: Philip Torchinsky<EMAIL_ADDRESS>Wysłano: piątek, listopada 1, 2019 9:16 AM
Do: JetBrains/swot
DW: DawidGrzejek; Mention
Temat: Re: [JetBrains/swot] New university in Wroclaw (#7071)
@DawidGrzejekhttps://github.com/DawidGrzejek Pull request merged. Thank you!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/JetBrains/swot/pull/7071?email_source=notifications&email_token=AKERERD2LOFGC7O4QYQUVOTQRPQVLA5CNFSM4JGYQS42YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEC2JDWQ#issuecomment-548704730, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AKERERDHIPDDLQZ4Q6VE3LTQRPQVLANCNFSM4JGYQS4Q.
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub, or unsubscribe.


Update German translation

Thanks for the translations @chschlue
If you see any files / strings which are not currently translated, please feel free to add those too. If you want some pointers on how to add translatable strings I'd be happy to help.

Oh also @chschlue please make sure you run make translate before pushing the updates, so that the translation files get re-compiled! Cheers.

Didn't I?
Why else would the mo file have changed?

Hmmm I think actually I might have had some confusion between branches on my end - it looks good now.. Sorry!

If you see any files / strings which are not currently translated, please feel free to add those too. If you want some pointers on how to add translatable strings I'd be happy to help.

There are quite a lot of fixed strings in the code.
Do you have a preference about how to structure a PR so it doesn't become overly convoluted? Like one commit per file?

I'm happy for multiple files to be updated in a single commit - as long as the changes made are all related. e.g. "update translations for Part application" or similar.


Fix small typo

Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Thanks, @fwessels!


vuepress based docs website.

Coverage remained the same at 100.0% when pulling 5ff7561d2699fd0a9d6e539a39b86b85653d2b66 on vue_press into eece71a317101b3356961d0f7955c7acd94be478 on master.


Update libraries

Current coverage is 75.28%

Merging #47 into master will not affect coverage as of 088c9ff

@@            master     #47   diff @@
======================================
  Files            5       5
  Stmts          174     174
  Branches        22      22
  Methods          0       0
======================================
  Hit            131     131
  Partial          3       3
  Missed          40      40

Review entire Coverage Diff as of 088c9ff

Powered by Codecov. Updated on successful CI builds.


Kenaz Logo conception

This PR is referencing Issue https://github.com/open-life-science/branding/issues/17
While making research and as stated in the issue description, Kenaz is a symbol in rune that describes many things.
I took to google (The most knowing, lol) and there I found out that Kenaz has a symbol on its own. Using the symbol as a base for the first draft, I made a design.
It is in such a way that anyone who has the knowledge about rune can identify. The human figures symbolises the coming together of the people from different educational background to give back to the world.
Included here are PNG format for viewing and mock ups of what they look like on merch.
For the second logo, the goal was to imitate the Kenaz rune design without using the actual rune design. I can call it a work in progress though. The bulb is a representation of knowledge ( one of the meaning of the Kenaz symbol) to symbolize the knowledge cohorts are giving back to the world.
Overall, I would say personally that I prefer the first logo (my bias). It was also knowledgeable working on this as this is my first time working to actively create a logo.

Bisola, thank you for the incredible work you did here! 🌷
Although these cannot be merged, as we have a working design system now, it does not take away from the meaningful work you did here. Best wishes! ❤


Radial gradient not rendered in button image

Trying to loading a simple svg button ("UIButton.svg") crashes the library.
The SVGViewer exits with the following error:
System.ArgumentException: Invalid ColorBlend object. The positions array must have 1.0 as its last element.
  at System.Drawing.Drawing2D.LinearGradientBrush.set_InterpolationColors (System.Drawing.Drawing2D.ColorBlend value) [0x00077] in /Volumes/build-root-ramdisk/mono-3.4.0/mcs/class/System.Drawing/System.Drawing.Drawing2D/LinearGradientBrush.cs:196

The SVG file is correctly rendered by Chrome. Here is a screenshot:

You can download the UIButton.svg file from this fiddle:
http://jsfiddle.net/EmanueleS/ve3XN/

Wit the currrent version, it looks like this:

So the crash and the text issues are gone, but the radial gradient seems not to be rendered.
Adapting issue title.

Update: after another fix related to feMerge, the button looks like this:

The problem is only the shadow, which is created by a filter. If removing the filter, the button looks good (but without shadow):

As the filters not working are handled in #43, I'm closing this issue.

Turns out the problem have not really been the filters in this case, but the parsing of float numbers in the color matrix on non-English systems. Here is the current rendering for reference:


feat: make node info side panel resizable. Fixes #8917

Signed-off-by: Dakota Lillie<EMAIL_ADDRESS>Fixes #8917
Change Summary

Allow the user to resize the node info side panel

https://user-images.githubusercontent.com/20373585/173668411-553a2141-884e-4e03-92e6-c4f5dc596e97.mov
Notes
I have tested this feature in Chrome, Firefox, and Safari.
As a result of this change, when opening the sidebar to inspect the details of an artifact node, the sidebar will open to the same width it opens to for other nodes (570px) rather than the 50% width to which it previously opened.
I had to update the grid system used by the attributes in the various tabs, because with the original grid system, both columns would increase in size when the side panel was resized, which looked kind of weird. The new grid system uses CSS grid, and ensures that only the right-most column increases in size. This change also addresses some other superficial issues pertaining to line height.
The original issue mentioned also potentially applying this feature to the logs sidebar. I elected not to do that here, to reduce the scope of the PR.
I would love to add tests for this feature, but it doesn't seem like the UI has testing infrastructure in place. Please let me know if I missed something — I will gladly add them.

Please resolve conflicts.


4.1.custom all Local to Scene SubResource Ids change after saving

Godot version
v4.1.dev.custom_build [a8453cb33]
System information
Windows 11, Core i5-12400F, RX 6600
Issue description
in recent custom 4.1 builds it is regening every ext id on every save even if just one simple file
[gd_scene load_steps=2 format=3 uid="uid://bj3w1run711x7"]

[ext_resource type="Texture2D" uid="uid://c082xolc76p8n" path="res://icon.svg" id="1_ftki2"]

[node name="Node2D" type="Node2D"]

[node name="Sprite2D" type="Sprite2D" parent="."]
position = Vector2(351, 294)
texture = ExtResource("1_ftki2")

can use a script like this save all files and regen all ext ids in project
@tool
extends EditorScript

func listFiles(path: String, extensions: Array = []) -> Array:
	var list := []
	for dir in DirAccess.get_directories_at(path):
		if not dir.begins_with("."):
			list.append_array(listFiles(path + dir + "/", extensions))
	for file in DirAccess.get_files_at(path):
		var ext = file.split(".")[-1]
		if not file.begins_with(".") and ext != "import":
			if not extensions.is_empty() and ext not in extensions:
				continue
			list.append(path + file)
	return list

func _run() -> void:
	for file in listFiles("res://", ["tscn", "tres"]):
		ResourceSaver.save(load(file))

in 4.0.2 this script does not regen every ext id in the project each time it is run (just when needed) but in latest 4.1 it does
but just ctrl+s works'nt too
thanks
thought it was related to this but maybe not
https://github.com/godotengine/godot/issues/76693
Steps to reproduce

make new scene with ext resource (new control, new sprite, set texture to icon)
1 - save, stage changes
2 - goto 1

or can use script on any project to see that it applies to everything, everywhere, all at once
Minimal reproduction project
n/a

I'm interested in tackling this issue.

Note that these are ExtResource IDs not SubResource IDs which are non-external, this seems to be handled here:
https://github.com/godotengine/godot/blob/da21cb7042b09de24964b9bd5a1a8e1d93ab4b8b/scene/resources/resource_format_text.cpp#L1971
And here:
https://github.com/godotengine/godot/blob/da21cb7042b09de24964b9bd5a1a8e1d93ab4b8b/scene/resources/resource_format_text.cpp#L1859

i've noticed this running recent builds of master as well, it makes git history hard to read due to the noise on every save. If it's useful i could bisect it to find what commit introduced this behavior.

I narrowed it down to: 8983b20ccd2f8a91d87789f2c0dd90f4e31b8b2c

This issue makes the current version unusable for people using VCS.


Problem running HelloWorld: no upgrade path to the target dbscheme

Thanks for the very interesting tutorial!
I was following along and failed to run the HelloWorld query. I selected the database and ran the query, and got an error There was no upgrade path to the target dbscheme. The same happened if I downloaded the database from apache/dubbo.
I am able setup working with the vscode extension for some other projects (so, I believe it is not a problem in the extension).
Any idea on what might be causing this issue?

Hello,I have encountered the same error. Have you resolved this issue?

No, I didn't.


added CocoaPodsDynamicExample and re-enabled Carthage examples

fixes #1939 /cc @segiddins

The CI VMs now all have Carthage 0.7.4 so the Carthage examples should work again.

:+1:


Fix run-notebook test

Reduce run-notebook test flaky failures.

This needs a JIRA issue number before we can merge it, please and thank you

@aweng98 Thanks for the PR. FYI that I'm rerunning tests on this PR to make sure we don't encounter a failure signature we haven't seen before.

Also curious if folks have any thoughts on retrying failures via something like jest.retryTimes(). Ideally we fix the underlying reasons for failures but until then we end up rerunning failed tests manually anyway so I was thinking it might make sense to automate that?

Also curious if folks have any thoughts on retrying failures via something like jest.retryTimes(). Ideally we fix the underlying reasons for failures but until then we end up rerunning failed tests manually multiple times so it might make sense to automate that?

We've brought that up before, historically there's huge pushback that if a test doesn't give meaningful signal it should either be fixed or disabled.

Also curious if folks have any thoughts on retrying failures via something like jest.retryTimes(). Ideally we fix the underlying reasons for failures but until then we end up rerunning failed tests manually multiple times so it might make sense to automate that?

Re-run failed tests is an easy way out but it hides flaky tests. We ought to eliminate test flakiness.


[Incubator][VC] ignore annotations that have specific prefixes

Try to resolve issue #330
when comparing virtual object and the real object, syncer will ignore annotation
prefixes specified in env STDLN_OBJ_ANNO_PREFXS

/lgtm
/approve


t2t利用paddlelite进行pto可以导出定点模型，但评测时报错

Traceback (most recent call last):
File "eval.py", line 120, in
main()
File "eval.py", line 116, in main
eval(args)
File "eval.py", line 80, in eval
fetch_list=fetch_targets)
File "/Users/gtx/opt/anaconda3/envs/paddle/lib/python3.6/site-packages/paddle/fluid/executor.py", line 1262, in run
six.reraise(*sys.exc_info())
File "/Users/gtx/opt/anaconda3/envs/paddle/lib/python3.6/site-packages/six.py", line 719, in reraise
raise value
File "/Users/gtx/opt/anaconda3/envs/paddle/lib/python3.6/site-packages/paddle/fluid/executor.py", line 1260, in run
return_merged=return_merged)
File "/Users/gtx/opt/anaconda3/envs/paddle/lib/python3.6/site-packages/paddle/fluid/executor.py", line 1402, in _run_impl
use_program_cache=use_program_cache)
File "/Users/gtx/opt/anaconda3/envs/paddle/lib/python3.6/site-packages/paddle/fluid/executor.py", line 1492, in _run_program
[fetch_var_name])
RuntimeError: (PreconditionNotMet) The number of first scale values must be the same with corresponding dimension value of Input(X) when the Scales has two elements, but 64 != 3136 here.
[Hint: Expected scales[0]->numel() == in->dims()[x_num_col_dims], but received scales[0]->numel():64 != in->dims()[x_num_col_dims]:32.] (at /home/Paddle/paddle/fluid/operators/fake_dequantize_op.h:90)
[operator < fake_channel_wise_dequantize_max_abs > error]
浮点inference模型使用如下方式导出：
from config import get_config
from t2t_vit import build_t2t_vit as build_model
import paddle
from paddle.static import InputSpec
config files in ./configs/
config = get_config('./configs/t2t_vit_7.yaml')
build model
model = build_model(config)
load pretrained weights
model_state_dict = paddle.load('./t2t_vit_7.pdparams')
model.set_state_dict(model_state_dict)
model.eval()
net = paddle.jit.to_static(model)
data = paddle.rand((1,3, 224, 224))
out = net(data)
x_spec = InputSpec(shape=[None, 3, 224, 224], dtype='float32', name='x')
model = paddle.jit.save(model, './t2t', input_spec=[x_spec])
量化和评测均使用官方提供demo：https://github.com/PaddlePaddle/PaddleSlim/tree/develop/demo/quant/quant_post

Thanks for the issue, I'm fixing this problem and will update once finished.

Hello，I have fixed the code and now in my env the model after quant can be load and run using paddleslim eval.py.
Please check the new commit here
and newly added documents here for details.

您好，使用了您提供的最新的模型文件和导出脚本，量化后的模型测试时仍然报错：
Traceback (most recent call last):
File "eval.py", line 120, in
main()
File "eval.py", line 116, in main
eval(args)
File "eval.py", line 80, in eval
fetch_list=fetch_targets)
File "/Users/gtx/opt/anaconda3/envs/paddle/lib/python3.6/site-packages/paddle/fluid/executor.py", line 1262, in run
six.reraise(*sys.exc_info())
File "/Users/gtx/opt/anaconda3/envs/paddle/lib/python3.6/site-packages/six.py", line 719, in reraise
raise value
File "/Users/gtx/opt/anaconda3/envs/paddle/lib/python3.6/site-packages/paddle/fluid/executor.py", line 1260, in run
return_merged=return_merged)
File "/Users/gtx/opt/anaconda3/envs/paddle/lib/python3.6/site-packages/paddle/fluid/executor.py", line 1402, in _run_impl
use_program_cache=use_program_cache)
File "/Users/gtx/opt/anaconda3/envs/paddle/lib/python3.6/site-packages/paddle/fluid/executor.py", line 1492, in _run_program
[fetch_var_name])
RuntimeError: (NotFound) Operator (fake_quantize_dequantize_moving_average_abs_max) does not have kernel for data_type[int]:data_layout[ANY_LAYOUT]:place[CPUPlace]:library_type[PLAIN].
[Hint: Expected kernel_iter != kernels.end(), but received kernel_iter == kernels.end().] (at /home/Paddle/paddle/fluid/framework/operator.cc:1297)
[operator < fake_quantize_dequantize_moving_average_abs_max > error]

@GtxMiracle 模型导出方式是否按照上面提到的文档提供的方式进行导出？ 转静态图过程中有无报错？ batchsize等是否设置正确？

请提供更多的信息，方便我们判断问题在哪。


In IE11, css URL is not loaded and so fontactive is not called sometimes

Running the following https://jsfiddle.net/5fmm24gt/7/ should draw the text 'hello world' at an angle on the canvas, and then draw it again once the fontactive callback is called.
In IE11 it will usually do this correctly the first time, however if you click Run again repeatedly it fails about 1 in 3 times (i.e. only draws the text once, in Times Roman).  It seems to happen a bit more frequently on IE10.
Looking at the network pane, on these occasions, webfont.js loads, but the css url is not requested -- which is presumably why the fontactive callback never gets called.
It looks like some sort of race condition, because it is intermittent.  Is this just an IE10/11 font bug, or is there some way of getting this to work reliably?
It's working well for me on other flavour browsers though -- thank you!

style.appendChild(document.createTextNode('')); after injection @font-face solves the problem.

Is this going to be merged in?


About the y_bpp and the Gaussian entropy model

Hello, I have a question about y_bpp and normalization.
In the implementation of the Gaussian entropy model in CompressAI, y_bpp is computed by estimating the likelihood after normalizing the input:
half = float(0.5)

if means is not None:
    values = inputs - means
else:
    values = inputs

scales = self.lower_bound_scale(scales)

values = torch.abs(values)
upper = self._standardized_cumulative((half - values) / scales)
lower = self._standardized_cumulative((-half - values) / scales)
likelihood = upper - lower

Does this mean that during actual training, it is not (y - means) / scales but rather torch.abs(y - means) / self.lower_bound_scale(scales) that is fitted to the standard normal distribution?
I need to normalize the latent variable y to obtain a standard spherical normal vector for calculating the spatial correlation.

Because of the symmetry of the normal distribution, values = torch.abs(values) has no effect on the result:
upper - lower
= _standardized_cumulative( z + 0.5) - _standardized_cumulative( z - 0.5)
= _standardized_cumulative(-z + 0.5) - _standardized_cumulative(-z - 0.5)
# Proof left as exercise.

The only reason abs is used here is to improve numerical stability for computing upper - lower. By using abs, the output of standardized_cumulative becomes closer to 0. So for example, 0.000000003 - 0.000000002 gives more precise results than 0.999999998 - 0.999999997.
I think the improvement in numerical stability is probably quite minimal for typical cases, so you can probably omit it if it makes it easier.

Because of the symmetry of the normal distribution, values = torch.abs(values) has no effect on the result:
upper - lower
= _standardized_cumulative( z + 0.5) - _standardized_cumulative( z - 0.5)
= _standardized_cumulative(-z + 0.5) - _standardized_cumulative(-z - 0.5)
# Proof left as exercise.

The only reason abs is used here is to improve numerical stability for computing upper - lower. By using abs, the output of standardized_cumulative becomes closer to 0. So for example, 0.000000003 - 0.000000002 gives more precise results than 0.999999998 - 0.999999997.
I think the improvement in numerical stability is probably quite minimal for typical cases, so you can probably omit it if it makes it easier.

Contributor

Thank you for your response. So the torch.abs does not impose additional constraints to the distribution of y.
Additionally, I am curious: if I aim to normalize ( y ) to achieve a standard normal distribution, should I take the lower bound of the scale set into account?

I'm not sure what you mean by normalizing the variable y. Note that y (minus mean) gets quantized to integer values like [..., -2, 1, 0, 1, 2, ...]. If it's normalized, this makes it hard to represent channels that have low- or high- entropy. In fact, if y is normalized, all channels will be expected to have an entropy of roughly 2.1 bits per element.
>>> bin_centers = np.arange(17) - 17//2
>>> def H(p): return -(p * np.log2(p)).sum()
>>> H(norm.cdf(bin_centers + 0.5) - norm.cdf(bin_centers - 0.5))
2.1048326541776676

The lossless entropy coder works on quantized values symbols = (y - mean).round(). So, symbols is expected to take values like [..., -2, 1, 0, 1, 2, ...]. A few parts of the code make use of this assumption, including:

Simulating quantization: additive noise adds +/- 0.5; and STE uses .round().
The scale_table is initialized logarithmically in the range [0.11, 64]. That means the lossless entropy coder supports distributions whose typical number of symbols are somewhere in the range [1, ~1000]. For the scale=0.11, it is expected that all symbols will fit in the mean (0) bin with 9-sigma probability; i.e., non-zero values are very unlikely to occur. (When very-low-probability symbols occur outside the range that is supported, they are instead encoded using the bypass mode of the lossless entropy coder, which encodes such out-of-bounds symbols using exp-golomb coding, IIRC.)

>>> scale_table = np.logspace(np.log10(0.11), np.log10(64))
>>> scale_table
array([ 0.11 ,  0.125,  0.143,  0.162,  0.185,  0.211,  0.24 ,  0.273,
        0.311,  0.354,  0.403,  0.459,  0.523,  0.596,  0.678,  0.772,
        0.879,  1.001,  1.14 ,  1.299,  1.479,  1.684,  1.917,  2.183,
        2.486,  2.831,  3.224,  3.672,  4.181,  4.761,  5.422,  6.174,
        7.03 ,  8.006,  9.116, 10.381, 11.821, 13.461, 15.329, 17.456,
       19.878, 22.635, 25.776, 29.352, 33.424, 38.061, 43.342, 49.355,
       56.203, 64.   ])

>>> 1 / scale_table[0]
9.090909090909092

The lower_bound_scale = LowerBound(scale_table[0]) acts as a safeguard. It does two things: (i) during training, it terminates any gradients that would nudge the model towards producing scales that are below the lower bound; and (ii) during evaluation, it clips scales that are below the lower bound.
Interestingly, there's no UpperBound enforcing the same things. However, it's presumably much rarer for distributions derived from 8-bit image data to need encoding via such wide high-entropy distributions, so the effect of it would probably be minimal during training. And during evaluation, the table indexes are computed so that the scale=64 distribution gets used for scales above scale=64. (Actually, I'm surprised it doesn't bin scales into indexes using the geometric mean between relevant scales or some other information-theoretically better boundary. Theoretically, if the predicted distributions accurately reflect reality, wouldn't it result in rate savings to encode using distributions that more accurately match the predicted scales/distributions?)

Thank you for your response.
In the transformer-based transform coding (ICLR22), it is noted that the effectiveness of the analysis transform ga can then be evaluated by measuring how much correlation there is among different elements in y. Thus the standardized representation of y (i.e., (y - mean) / scale) is utilized to compute the spatial correlation of y across different positions.
Theoretically, (y - mean) / scale should follow a normal distribution. However, in practice, constraints are applied during BPP calculation, and optimization tends to align it. From your explanation, it appears that torch.abs imposes no direct constraints on the distribution, while the lowerbound function prevents gradients below the specified bound during training.
Therefore, the difference between (y-mean)/scale and (y-mean)/lower bound (scale) may be very small?
Correspondingly, if there are some cases  below the lower bound, it seems that I should use (y-mean)/lowerbound (scale) instead?


App Crash Report

Code of Conduct

[ ] I agree to follow this project's Code of Conduct

Is there an existing issue for this?

[ ] I have searched the existing issues

App Version
0.0.0-dev
Electron Version
15.1.2
Operating System
macOS Big Sur
What happened?
Steps To Reproduce
Relevant log output
Error message
window.ugrc.aBadFunctionName is not a function
Stack trace
TypeError: window.ugrc.aBadFunctionName is not a function
    at eval (webpack-internal:///./src/pages/Data.jsx:86:17)
    at invokePassiveEffectCreate (webpack-internal:///./node_modules/react-dom/cjs/react-dom.development.js:3960:1047)
    at HTMLUnknownElement.callCallback (webpack-internal:///./node_modules/react-dom/cjs/react-dom.development.js:657:119)
    at Object.invokeGuardedCallbackDev (webpack-internal:///./node_modules/react-dom/cjs/react-dom.development.js:677:45)
    at invokeGuardedCallback (webpack-internal:///./node_modules/react-dom/cjs/react-dom.development.js:696:126)
    at flushPassiveEffectsImpl (webpack-internal:///./node_modules/react-dom/cjs/react-dom.development.js:3968:212)
    at unstable_runWithPriority (webpack-internal:///./node_modules/scheduler/cjs/scheduler.development.js:465:16)
    at runWithPriority$1 (webpack-internal:///./node_modules/react-dom/cjs/react-dom.development.js:2063:1059)
    at flushPassiveEffects (webpack-internal:///./node_modules/react-dom/cjs/react-dom.development.js:3960:237)
    at eval (webpack-internal:///./node_modules/react-dom/cjs/react-dom.development.js:3945:110)

Please ignore, this is for demonstration purposes only.


Added basic RFT functions

This contains some new functions for performing an RFT analysis:

euler: calculates euler characteristic
rftResults: given certain parameters calculates set, cluster, and peak level statistics
rftPval: basic formula that is utilized for RFT p-values
statFieldThresh: various methods of thresholding a statistical field
resels: estimates resolution elements
estSmooth: estimates the FWHM

I have included documentation for each but I haven't roxygenised them.

do you mind running roxygen2::roxygenize() inside of the ANTsR directory and then adding the result to this pull request?  i'd like to see the R CMD check results on travis.

I've never really run roxygenize before, so I might be doing something wrong. When I run it I get a bunch of warnings on the antsImage_class and antsImageIterator_class files saying "requires name and description".

Sorry for the messy commits. It took me a bit to figure out the travis checks while bouncing back and forth between computers.

looks good ... one minor issue:

Undocumented arguments in documentation object 'statFieldThresh'
  â€˜reselsâ€™ â€˜threshTypeâ€™
Documented arguments not in \usage in documentation object 'statFieldThresh':
  â€˜threshType:â€™ â€˜maskâ€™

please address and i will merge.

Sorry I lost track of this ... It looks close enough to merge.   Thank you much!  Please keep us updated if you find bugs or want to add functionality.


Update cats-effect-laws, cats-effect-std, ... to 3.4.6

Updates

org.typelevel:cats-effect-laws
org.typelevel:cats-effect-std
org.typelevel:cats-effect-testkit

from 3.3.14 to 3.4.6.
GitHub Release Notes - Version Diff
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Adjust future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "org.typelevel" } ]

Or, add this to slow down future updates of this dependency:
dependencyOverrides = [{
  pullRequests = { frequency = "30 days" },
  dependency = { groupId = "org.typelevel" }
}]

labels: library-update, early-semver-minor, semver-spec-minor, version-scheme:early-semver, commit-count:1

Superseded by #846.


119 Filename before the warning and full path to it

Included full path to the file and moved the path in the start of the warning.
Fixes: https://github.com/wp-cli/i18n-command/issues/119

Hello @danielbachhuber,
Thank you for your reply. For the full path - my opinion is that relative is better as well, however on the issue this PR is for - https://github.com/wp-cli/i18n-command/issues/119 the request is for full path (especially when automating). This is why I have set this up this way.
As for the funcitonal tests - I checked the errors upon the failed tests and I am not sure how to include the full path (as it is a tmp one) to the expected output. I have updated the PR with file name moved to the start of the error.


HBASE-28505 Implement enforcement to require Date Tiered Compaction for Time Range Data Tiering

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 53s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ HBASE-28463 Compile Tests _

+1 :green_heart:
mvninstall
3m 16s
HBASE-28463 passed

+1 :green_heart:
compile
2m 59s
HBASE-28463 passed

+1 :green_heart:
checkstyle
0m 37s
HBASE-28463 passed

+1 :green_heart:
spotless
0m 45s
branch has no errors when running spotless:check.

+1 :green_heart:
spotbugs
1m 33s
HBASE-28463 passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
2m 50s
the patch passed

+1 :green_heart:
compile
2m 40s
the patch passed

-0 :warning:
javac
2m 40s
hbase-server generated 1 new + 194 unchanged - 1 fixed = 195 total (was 195)

+1 :green_heart:
checkstyle
0m 49s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
hadoopcheck
6m 27s
Patch does not cause any errors with Hadoop 3.3.6.

+1 :green_heart:
spotless
0m 51s
patch has no errors when running spotless:check.

+1 :green_heart:
spotbugs
2m 26s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
0m 13s
The patch does not generate ASF License warnings.

34m  1s

Subsystem
Report/Notes

Docker
ClientAPI=1.45 ServerAPI=1.45 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5809/1/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/5809

Optional Tests
dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile

uname
Linux 3d1875144a73 5.4.0-174-generic #193-Ubuntu SMP Thu Mar 7 14:29:28 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
HBASE-28463 / a9d3170921

Default Java
Eclipse Adoptium-11.0.17+8

javac
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5809/1/artifact/yetus-general-check/output/diff-compile-javac-hbase-server.txt

Max. process+thread count
78 (vs. ulimit of 30000)

modules
C: hbase-server U: hbase-server

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5809/1/console

versions
git=2.34.1 maven=3.8.6 spotbugs=4.7.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 28s
Docker mode activated.

-0 :warning:
yetus
0m  5s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ HBASE-28463 Compile Tests _

+1 :green_heart:
mvninstall
2m 47s
HBASE-28463 passed

+1 :green_heart:
compile
0m 39s
HBASE-28463 passed

+1 :green_heart:
shadedjars
5m 39s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 24s
HBASE-28463 passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
2m 28s
the patch passed

+1 :green_heart:
compile
0m 40s
the patch passed

+1 :green_heart:
javac
0m 40s
the patch passed

+1 :green_heart:
shadedjars
5m 39s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 23s
the patch passed

_ Other Tests _

-1 :x:
unit
236m 46s
hbase-server in the patch failed.

259m 55s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5809/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/5809

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 7b4a7f02d324 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
HBASE-28463 / a9d3170921

Default Java
Temurin-1.8.0_352-b08

unit
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5809/1/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-server.txt

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5809/1/testReport/

Max. process+thread count
5510 (vs. ulimit of 30000)

modules
C: hbase-server U: hbase-server

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5809/1/console

versions
git=2.34.1 maven=3.8.6

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 12s
Docker mode activated.

-0 :warning:
yetus
0m  3s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ HBASE-28463 Compile Tests _

+1 :green_heart:
mvninstall
3m  4s
HBASE-28463 passed

+1 :green_heart:
compile
0m 49s
HBASE-28463 passed

+1 :green_heart:
shadedjars
5m  9s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 27s
HBASE-28463 passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
2m 50s
the patch passed

+1 :green_heart:
compile
0m 50s
the patch passed

+1 :green_heart:
javac
0m 50s
the patch passed

+1 :green_heart:
shadedjars
6m 36s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 39s
the patch passed

_ Other Tests _

-1 :x:
unit
256m  7s
hbase-server in the patch failed.

281m 19s

Subsystem
Report/Notes

Docker
ClientAPI=1.45 ServerAPI=1.45 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5809/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/5809

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 76a21bda4a8a 5.4.0-172-generic #190-Ubuntu SMP Fri Feb 2 23:24:22 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
HBASE-28463 / a9d3170921

Default Java
Eclipse Adoptium-11.0.17+8

unit
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5809/1/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5809/1/testReport/

Max. process+thread count
5222 (vs. ulimit of 30000)

modules
C: hbase-server U: hbase-server

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5809/1/console

versions
git=2.34.1 maven=3.8.6

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 46s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ HBASE-28463 Compile Tests _

+1 :green_heart:
mvninstall
2m 57s
HBASE-28463 passed

+1 :green_heart:
compile
2m 28s
HBASE-28463 passed

+1 :green_heart:
checkstyle
0m 36s
HBASE-28463 passed

+1 :green_heart:
spotless
0m 43s
branch has no errors when running spotless:check.

+1 :green_heart:
spotbugs
1m 32s
HBASE-28463 passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
2m 49s
the patch passed

+1 :green_heart:
compile
2m 36s
the patch passed

+1 :green_heart:
javac
2m 36s
the patch passed

-0 :warning:
checkstyle
0m 35s
hbase-server: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
hadoopcheck
6m 29s
Patch does not cause any errors with Hadoop 3.3.6.

-1 :x:
spotless
0m 46s
patch has 23 errors when running spotless:check, run spotless:apply to fix.

+1 :green_heart:
spotbugs
2m 21s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
0m 14s
The patch does not generate ASF License warnings.

32m  1s

Subsystem
Report/Notes

Docker
ClientAPI=1.45 ServerAPI=1.45 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5809/2/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/5809

Optional Tests
dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile

uname
Linux 2960b2c85a47 5.4.0-174-generic #193-Ubuntu SMP Thu Mar 7 14:29:28 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
HBASE-28463 / a9d3170921

Default Java
Eclipse Adoptium-11.0.17+8

checkstyle
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5809/2/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt

spotless
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5809/2/artifact/yetus-general-check/output/patch-spotless.txt

Max. process+thread count
82 (vs. ulimit of 30000)

modules
C: hbase-server U: hbase-server

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5809/2/console

versions
git=2.34.1 maven=3.8.6 spotbugs=4.7.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 29s
Docker mode activated.

-0 :warning:
yetus
0m  4s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ HBASE-28463 Compile Tests _

+1 :green_heart:
mvninstall
2m 49s
HBASE-28463 passed

+1 :green_heart:
compile
0m 40s
HBASE-28463 passed

+1 :green_heart:
shadedjars
5m 39s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 25s
HBASE-28463 passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
2m 27s
the patch passed

+1 :green_heart:
compile
0m 40s
the patch passed

+1 :green_heart:
javac
0m 40s
the patch passed

+1 :green_heart:
shadedjars
5m 35s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 22s
the patch passed

_ Other Tests _

-1 :x:
unit
240m  1s
hbase-server in the patch failed.

263m 27s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5809/2/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/5809

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 4495b4a2ae53 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
HBASE-28463 / a9d3170921

Default Java
Temurin-1.8.0_352-b08

unit
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5809/2/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-server.txt

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5809/2/testReport/

Max. process+thread count
5404 (vs. ulimit of 30000)

modules
C: hbase-server U: hbase-server

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5809/2/console

versions
git=2.34.1 maven=3.8.6

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 44s
Docker mode activated.

-0 :warning:
yetus
0m  3s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ HBASE-28463 Compile Tests _

+1 :green_heart:
mvninstall
5m  1s
HBASE-28463 passed

+1 :green_heart:
compile
1m 11s
HBASE-28463 passed

+1 :green_heart:
shadedjars
7m  5s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 49s
HBASE-28463 passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
4m 30s
the patch passed

+1 :green_heart:
compile
1m 22s
the patch passed

+1 :green_heart:
javac
1m 22s
the patch passed

+1 :green_heart:
shadedjars
8m 12s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 41s
the patch passed

_ Other Tests _

-1 :x:
unit
342m 36s
hbase-server in the patch failed.

377m 26s

Subsystem
Report/Notes

Docker
ClientAPI=1.45 ServerAPI=1.45 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5809/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/5809

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 9b869afe148c 5.4.0-174-generic #193-Ubuntu SMP Thu Mar 7 14:29:28 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
HBASE-28463 / a9d3170921

Default Java
Eclipse Adoptium-11.0.17+8

unit
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5809/2/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5809/2/testReport/

Max. process+thread count
4415 (vs. ulimit of 30000)

modules
C: hbase-server U: hbase-server

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5809/2/console

versions
git=2.34.1 maven=3.8.6

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 46s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ HBASE-28463 Compile Tests _

+1 :green_heart:
mvninstall
3m 53s
HBASE-28463 passed

+1 :green_heart:
compile
2m 54s
HBASE-28463 passed

+1 :green_heart:
checkstyle
0m 43s
HBASE-28463 passed

+1 :green_heart:
spotless
0m 52s
branch has no errors when running spotless:check.

+1 :green_heart:
spotbugs
1m 50s
HBASE-28463 passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
3m 28s
the patch passed

+1 :green_heart:
compile
2m 56s
the patch passed

-0 :warning:
javac
2m 56s
hbase-server generated 1 new + 194 unchanged - 1 fixed = 195 total (was 195)

+1 :green_heart:
checkstyle
0m 44s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
hadoopcheck
6m  3s
Patch does not cause any errors with Hadoop 3.3.6.

+1 :green_heart:
spotless
1m  2s
patch has no errors when running spotless:check.

+1 :green_heart:
spotbugs
2m 32s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
0m 16s
The patch does not generate ASF License warnings.

35m 46s

Subsystem
Report/Notes

Docker
ClientAPI=1.45 ServerAPI=1.45 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5809/3/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/5809

Optional Tests
dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile

uname
Linux 61647e87054d 5.4.0-172-generic #190-Ubuntu SMP Fri Feb 2 23:24:22 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
HBASE-28463 / a9d3170921

Default Java
Eclipse Adoptium-11.0.17+8

javac
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5809/3/artifact/yetus-general-check/output/diff-compile-javac-hbase-server.txt

Max. process+thread count
80 (vs. ulimit of 30000)

modules
C: hbase-server U: hbase-server

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5809/3/console

versions
git=2.34.1 maven=3.8.6 spotbugs=4.7.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 28s
Docker mode activated.

-0 :warning:
yetus
0m  4s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ HBASE-28463 Compile Tests _

+1 :green_heart:
mvninstall
2m 49s
HBASE-28463 passed

+1 :green_heart:
compile
0m 39s
HBASE-28463 passed

+1 :green_heart:
shadedjars
5m 40s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 25s
HBASE-28463 passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
2m 27s
the patch passed

+1 :green_heart:
compile
0m 39s
the patch passed

+1 :green_heart:
javac
0m 39s
the patch passed

+1 :green_heart:
shadedjars
5m 40s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 22s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
237m 18s
hbase-server in the patch passed.

260m 21s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5809/3/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/5809

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 3b44d7b373c8 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
HBASE-28463 / a9d3170921

Default Java
Temurin-1.8.0_352-b08

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5809/3/testReport/

Max. process+thread count
5986 (vs. ulimit of 30000)

modules
C: hbase-server U: hbase-server

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5809/3/console

versions
git=2.34.1 maven=3.8.6

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 54s
Docker mode activated.

-0 :warning:
yetus
0m  3s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ HBASE-28463 Compile Tests _

+1 :green_heart:
mvninstall
4m 20s
HBASE-28463 passed

+1 :green_heart:
compile
1m 17s
HBASE-28463 passed

+1 :green_heart:
shadedjars
7m 28s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 38s
HBASE-28463 passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
4m 13s
the patch passed

+1 :green_heart:
compile
1m  4s
the patch passed

+1 :green_heart:
javac
1m  4s
the patch passed

+1 :green_heart:
shadedjars
7m 31s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 39s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
258m 30s
hbase-server in the patch passed.

291m  0s

Subsystem
Report/Notes

Docker
ClientAPI=1.45 ServerAPI=1.45 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5809/3/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/5809

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux fe87538c4481 5.4.0-174-generic #193-Ubuntu SMP Thu Mar 7 14:29:28 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
HBASE-28463 / a9d3170921

Default Java
Eclipse Adoptium-11.0.17+8

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5809/3/testReport/

Max. process+thread count
4494 (vs. ulimit of 30000)

modules
C: hbase-server U: hbase-server

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5809/3/console

versions
git=2.34.1 maven=3.8.6

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m  0s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ HBASE-28463 Compile Tests _

+1 :green_heart:
mvninstall
3m 17s
HBASE-28463 passed

+1 :green_heart:
compile
3m  0s
HBASE-28463 passed

+1 :green_heart:
checkstyle
0m 37s
HBASE-28463 passed

+1 :green_heart:
spotless
0m 42s
branch has no errors when running spotless:check.

+1 :green_heart:
spotbugs
1m 34s
HBASE-28463 passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
2m 51s
the patch passed

+1 :green_heart:
compile
2m 28s
the patch passed

+1 :green_heart:
javac
2m 28s
the patch passed

+1 :green_heart:
checkstyle
0m 36s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
hadoopcheck
5m 44s
Patch does not cause any errors with Hadoop 3.3.6.

+1 :green_heart:
spotless
0m 48s
patch has no errors when running spotless:check.

+1 :green_heart:
spotbugs
2m 15s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
0m 11s
The patch does not generate ASF License warnings.

32m 16s

Subsystem
Report/Notes

Docker
ClientAPI=1.45 ServerAPI=1.45 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5809/4/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/5809

Optional Tests
dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile

uname
Linux c7e52c42d5c4 5.4.0-174-generic #193-Ubuntu SMP Thu Mar 7 14:29:28 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
HBASE-28463 / a9d3170921

Default Java
Eclipse Adoptium-11.0.17+8

Max. process+thread count
82 (vs. ulimit of 30000)

modules
C: hbase-server U: hbase-server

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5809/4/console

versions
git=2.34.1 maven=3.8.6 spotbugs=4.7.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 42s
Docker mode activated.

-0 :warning:
yetus
0m  4s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ HBASE-28463 Compile Tests _

+1 :green_heart:
mvninstall
4m 34s
HBASE-28463 passed

+1 :green_heart:
compile
1m  8s
HBASE-28463 passed

+1 :green_heart:
shadedjars
6m 50s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 43s
HBASE-28463 passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
4m  4s
the patch passed

+1 :green_heart:
compile
1m  0s
the patch passed

+1 :green_heart:
javac
1m  0s
the patch passed

+1 :green_heart:
shadedjars
6m 55s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 42s
the patch passed

_ Other Tests _

-1 :x:
unit
335m  1s
hbase-server in the patch failed.

367m  5s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5809/4/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/5809

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 7734fb3ad69b 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
HBASE-28463 / a9d3170921

Default Java
Eclipse Adoptium-11.0.17+8

unit
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5809/4/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5809/4/testReport/

Max. process+thread count
4538 (vs. ulimit of 30000)

modules
C: hbase-server U: hbase-server

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5809/4/console

versions
git=2.34.1 maven=3.8.6

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 43s
Docker mode activated.

-0 :warning:
yetus
0m  3s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ HBASE-28463 Compile Tests _

+1 :green_heart:
mvninstall
3m 56s
HBASE-28463 passed

+1 :green_heart:
compile
0m 52s
HBASE-28463 passed

+1 :green_heart:
shadedjars
6m 28s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 27s
HBASE-28463 passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
3m 23s
the patch passed

+1 :green_heart:
compile
0m 59s
the patch passed

+1 :green_heart:
javac
0m 59s
the patch passed

+1 :green_heart:
shadedjars
6m 31s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 32s
the patch passed

_ Other Tests _

-1 :x:
unit
347m 14s
hbase-server in the patch failed.

376m 18s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5809/4/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/5809

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux bf07a665f134 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
HBASE-28463 / a9d3170921

Default Java
Temurin-1.8.0_352-b08

unit
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5809/4/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-server.txt

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5809/4/testReport/

Max. process+thread count
4437 (vs. ulimit of 30000)

modules
C: hbase-server U: hbase-server

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5809/4/console

versions
git=2.34.1 maven=3.8.6

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.


No item values and no application list available

Hello,
I'm having the following issues when trying to add a new graph:

No zabbix "Application" are listed
No zabbix history is shown on the graph

It's working perfectly while using Grafana/zabbix-grafana v2.6.
I'm now trying to use:
Zabbix 3.0.1
grafana-3.0.4-1464167696.x86_64
grafana-zabbix-app 3.0.0-beta8

The new trigger panel is working though ...
Any help would be greatly appreciated !
Stéphane

For more details:

No zabbix "Application" are listed

I can see my zabbix "Groups", "Hosts" and "Items", but no "Application" are showed.

By looking at the network request, it seems that no host id is passed as argument.

Note that if no hosts is selected, by removing "hostids: []" parameter, we got all "Application".

No zabbix history is shown on the graph

While selecting an item, I don't see any data value on the graph.
I don't see any "history" request to Zabbix server as well.

Ok both issues come from a trailing space at the end of Zabbix Visible name.
The Zabbix Host selected from Grafana schrimped the trailing space. Then hostid cannot be matched.
I got that by looking around https://github.com/alexanderzobnin/grafana-zabbix/blob/master/src/datasource-zabbix/query.controller.js#L137
I guess we can fix this two ways:

Around this part of the code, this.target.host.filter should have a trailing space, matching exactly what is entered into the web interface
Host name trailing space into self.metric.hostList should be removed

Hi, Stéphane! I'll check templateSrv.replace() function. Looks like this func trims trailing spaces.


Update bash files

I think it might be better to have a different folder structure, e.g., bash_files/linear/{method} and bash_files/pretrain/{method}. What do you think?

I agree. Will do


GoReSym version 1.1 still parse wrong VA

Go 1.18 binary, stripped, at: https://www.mediafire.com/file/3sukf6j3lfwk5tt/go_gimphash_windows.7z/file

this exposes a separate little fun bug in the version detection from the buildinfo https://github.com/golang/go/issues/53071


Hearthstone lags and freezes now

I tried using the hearthstone card tracker and now my hearthstone is unplayable.
I tried deleting the hearthstone application folder and reinstalling the game but it still lags once a match is found.
I read online for the windows version that you can delete some log.config file and it should fix the lag but I cannot seem to find that file on the mac.

This is a duplicate of #141, you can find the info in the link.
(could you tell me what's your mac model as well as osx version ?)

Hi,
Sorry I did not see that it was a duplicate.
I’m using a macbook air 13inch, mid 2013 with OS X Yosemite 10.10.3
Thanks,
Steven

On Aug 27, 2015, at 7:51 AM, Benjamin Michotte<EMAIL_ADDRESS>wrote:
This is a duplicate of #141 https://github.com/bmichotte/HSTracker/issues/141, you can find the info in the link.
(could you tell me what's your mac model as well as osx version ?)
—
Reply to this email directly or view it on GitHub https://github.com/bmichotte/HSTracker/issues/162#issuecomment-135438774.

Hi,
I tried removing it through the terminal and the problem got fixed.
I will now try the newest version of the card tracker.
Thank you very much!

On Aug 27, 2015, at 7:54 AM, Steven Truong<EMAIL_ADDRESS>wrote:
Hi,
Sorry I did not see that it was a duplicate.
I’m using a macbook air 13inch, mid 2013 with OS X Yosemite 10.10.3
Thanks,
Steven

On Aug 27, 2015, at 7:51 AM, Benjamin Michotte<EMAIL_ADDRESS><EMAIL_ADDRESS>wrote:
This is a duplicate of #141 https://github.com/bmichotte/HSTracker/issues/141, you can find the info in the link.
(could you tell me what's your mac model as well as osx version ?)
—
Reply to this email directly or view it on GitHub https://github.com/bmichotte/HSTracker/issues/162#issuecomment-135438774.


How to run on windows

Hi good day, can you please teach me on how to run this server in windows?

The scripts are currently build only for Linux. (Ubuntu 20.04+)

copy the mods folder in ba root and paste in script you will be able to test run the script in local device
same for mobiles(more complex though)

1 year till now no luck for windows :(

Use multipass/virtualbox/hyper-v/wsl


"Job not found" error using Lowdb as a storage of queue

I have been trying a lot of variants to push a job and then generate PDF file, however haven't succeeded in. It seems like db.json is not used at all, it's being stayed empty. I don't know what is in Postgres regard, perhaps there is the same issue. Could you check the reason please?

The problem for me was that lowdb is not properly seeded if db.initialValue is not set. I've created a PR to resolve - https://github.com/esbenp/pdf-bot/pull/19 .


Draft a literature review on extant NLP techniques

Start with the Josh Lee's papers ("Manager sentiment and stock returns," etc.) front end along with Jonah Berger's "Uniting the Tribes: Using Text for Marketing Insight" and then (in order of priority) Journal of Consumer Psychology, Journal of Customer Research, Journal of Marketing, Journal of Marketing Research, Marketing Science, and Quantitative Marketing and Economics.
Add bullets here of techniques that we should consider along with drafting the actual literature review for the paper.

10.1177-0022242919873106-table4-0022242919873106.pdf
This table, from "Uniting the Tribes: Using Text for Marketing Insight" (Berger et al. 2020), has a reasonably thorough collection of techniques for text analysis in marketing and includes the relevant citations. There is a good degree of overlap between the usage of these different tools--alternative ways of grouping them could be considered.

Great, then how do you recommend we do it, @wtrumanrose? What makes sense given our application?


www/nginx: CSP always uses report-only

When enabling Content-Security-Policy, a header Content-Security-Policy-Report-Only (instead of Content-Security-Policy) is added.
security_rule.csp_report_only is set to 0 by default in https://github.com/opnsense/plugins/blob/343a8bbeb525cb72860975ac38a1bcd08f552873/www/nginx/src/opnsense/mvc/app/models/OPNsense/Nginx/Nginx.xml#L863
(I suppose that intention is to disable "report-only" by default.) However, the following code checks whether security_rule.csp_report_only exists and not wheter it is set to 1.
https://github.com/opnsense/plugins/blob/343a8bbeb525cb72860975ac38a1bcd08f552873/www/nginx/src/opnsense/service/templates/OPNsense/Nginx/security_rule.conf#L70
This could be fixed by using
    add_header Content-Security-Policy{% if security_rule.csp_report_only is defined and security_rule.csp_report_only == '1' %}-Report-Only{% endif %} "{%

instead.

@realflunschi fix is ready. You can patch your installation in advance if you need to.

I can't find a field where the report uri could be defined for reporting.
What am I missing?


Bump deCONZ to 2.05.76

Fails on the arm64, has the debian package is not available

Fails on the arm64, has the debian package is not available

Yes, for me as well - but deconz works fine, is it the tput: error you are referring to?
Step 9/12 : RUN dpkg -i /deconz.deb &&     rm -f /deconz.deb &&     mkdir /root/otau &&     chown root:root /usr/bin/deCONZ*
 ---> Running in a30d38e3ebf7
Selecting previously unselected package deconz.
(Reading database ... 11807 files and directories currently installed.)
Preparing to unpack /deconz.deb ...
tput: No value for $TERM and no -T specified
tput: No value for $TERM and no -T specified
tput: No value for $TERM and no -T specified
tput: No value for $TERM and no -T specified
tput: No value for $TERM and no -T specified
Unpacking deconz (2.05.76-ubuntu-xenial-beta) ...
Setting up deconz (2.05.76-ubuntu-xenial-beta) ...
Removing intermediate container a30d38e3ebf7

It was the debian package that couldn't be downloaded.
@marthoc can you please relaunch the test?

I have also noted a bug - not related to this pull, but can be good to know.
The bug has been reported here: 2791

I restarted the test build, should complete soon.

Hi
I am a Windows-freak (C#, Visual Studio) waiting eagerly for the new version 2.05.76. Unfortunately Dresden Elektronik did not publish the Windows version until now.
Is it possible to compile the new version on Windows?
Or is there another place than http://deconz.dresden-elektronik.de/win/?C=M;O=D they publish the newest Windows version?

@Linus62 this is not really the right place to ask for the windows version or how to compile. You can probably use this docker image on windows while waiting for the native windows version.


Resolves #400 Upgrade d-m-p to version 0.15.2

Can one of the admins verify this patch?

No need for this. Already managed by release.groovy


Memory leak with jsoup.clean.

I have quiet extensive JUnit 5 tests (arround 800). Quiet some of those create and delete entities, which include fields like name, title, description and so forth, which I sanitize this way:
public class SomeHelper
{
  static Whitelist none = Whitelist.none();

  public static String strip(String input)
  {
    if (input == null) {
      return null;
    }
    // Strip all HTML elements
    input = Jsoup.clean(input, none);
    // For any left overs, encode it so it cannot be used in an HTML content
    return Encode.forHtml(input).replace("\0", "");
  }
}

The encoder is org.owasp.encoder.Encode
When I do so, my test run out of heap on the CI. Removing input = Jsoup.clean(input, none); fixes exactly. I assume there is a memory leak, I tried to analyze it with yourkit but was not able to find it (but this is nothing I do regularly, I'am fairly new to java profiling).
I could not find any other reports but maybe someone with more profiling skills and jsoup internal knowledge can help out getting to the cause?

What is the specific exception you get?
The Jsoup.clean() method is static with no global state, and if you follow the implementation you can see all the objects are created new. My guess is that you are not seeing a leak, but one of the inputs is larger than your heap and you are running out of memory.
My suggestion would be to log the filenames / hashes of the input, run until you get an OOM, and then replay just that specific input and validate its the single input creating the OOM (vs a slow leak).
If that's the case, you may look to increase your heap to be able to parse the document into a DOM successfully.

I already upped the heap and it was not working. I removed jsoup for this purpose entirely and have no issues since. So i can neither provide informations anymoree nor confirm your theory, sorry.
Feel free to close if you consider this to be not enough context.


changing routes object to herbs2rest

issue #15

waiting the issue #17 be merged to fix this PR

:tada: This PR is included in version 1.0.6 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket: