Create a different OpenAPI Handler for each "tag"

Motivation
The generator currently only creates one big OpenAPI Handler protocol.
This makes it hard to organize the routes.
Proposed solution
Create a different OpenAPI Handler for each "tag" so we have something close to Vapor "controllers".
These are quite useful for decluttering the code.
The generator could also generate each tag's "controller protocol" in it's own file. There are known issues in the Swift compiler where it struggles to handle one big file, or makes builds potentially extremely slower.
Alternatives considered
Manually handling this by different methods, including manually creating controllers and redirecting the routes in the main openapi handler to those controllers, or using multiple targets and filtering a shared openapi file based on tag in each controller.
Additional information
No response

Hi @MahdiBM,
can you elaborate on why "using multiple targets and filtering a shared openapi file based on tag in each controller" isn't a viable option here? Tags, paths, operationIds are all reasonable ways to group operations, and filtering gives you great flexibility to use them all and even combine them.
Using Swift modules here allows you to have full control over the fully qualified protocol name MyModuleA.APIProtocol, MyModuleB.APIProtocol. If we generated multiple protocols, naming them would become a new challenge, as we'd have to derive some non-conflicting name from the combination of tags/paths/operationIds?
Are there specific issues with using filtering + modules? And if there are issues with Swift modules, should we instead work on addressing those in SwiftPM/the compiler?

o hmm sorry for 3 different issues. That was network problem and likely GItHub reattempting the creation 3 times.

can you elaborate on why "using multiple targets and filtering a shared openapi file based on tag in each controller" isn't a viable option here?

It is an option, It's just cumbersome.

If we generated multiple protocols, naming them would become a new challenge, as we'd have to derive some non-conflicting name from the combination of tags/paths/operationIds.

I guess that could be a theoretical problem, but I think we can just make it work in that case? e.g. add numbers to the names.
Realistically this should be very rare, but i understand OpenAPI Generator needs to assume worse case scenario.

Are there specific issues with using filtering + modules? ...

I mean, not really, aside from being a bit cumbersome to set up, and requiring a fine amount of knowledge to know how to make it work properly (e.g. I don't presume most newbies know what "symlinks" are, so this will look even more insane to them).

This should also help for the namings: https://github.com/apple/swift-openapi-generator/pull/683
We could have a "group by" option in the config file and users will be able to declare how to group their routes?
We can make sure that only accepts 1 field, so name conflicts become basically non-existent.

having multiple modules can also make it a bit weird for the "types".
will we have to have a single target only for the types as well? Then @_exported import the types target in all the controller targets?
All possible, but ... harder than it should be?

Is it? I'm not sure that doing this in the generator would result in a significantly better workflow, and we'd be reimplementing features present in the language and package manager. Can you list some of the concrete issues that exist when using the existing language features to achieve the decomposition today? Might make it easier to figure out what we're trying to solve here.

Is it?

for 1- it requires someone good at things to figure this out. I don't think any of my colleagues at work could 1- come up with the idea, and 2- figure out how to do it (symlinks, @_exported, etc...).
Maybe you're overestimating the competence of an avg. user/developer 😅.
I can make it work, yes, but I don't think many developers can.
Even if the language already provides the tools and all for this, OpenAPI generator should at the minimum have some docs about it, and optimally have some kind of commands (command plugin?) to trivially to this.
It should be even easier with Swift 6's support of adding targets and all.
(To be clear, OpenAPI Generator has pretty good docs already, and I appreciate that 🙂)

Right, that makes sense - I'm happy for us to document this workflow better. Would you want to open a PR? Or at least describe the workflow you're using in more detail, so that we could write a how-to?

@czechboy0
To be clear I have not done this yet anywhere.
What I'm thinking about the process, is that it would be something like:

Create a OpenAPI document file.
Create a target named xxxTypes.

Add types generation to the openapi yaml file
Symlink the openapi document in the target.

Create targets with names xxxTag for each tag.

@_exported import the xxxTypes targets.
Add server generation to the openapi yaml file with tag filter.
Symlink the openapi document in the target.

The problem here is that I'd like this to be automated. Perhaps with a command plugin.

The command plugin will need to take some parameters (probably depend on the ArgumentsParser package).
Will need to take arguments for a minimum level of control over name creations. For example to take a prefix or suffix for target names.
Will need to create targets in the package in an automated way. Then add dependencies to those targets.

This won't be too hard as we have some Swift CLI commands in Swift 6 and above to do that.

Should somehow be able to add plugins (The OpenAPI Generator plugin) to those targets as well?

I actually would be fine with not needing this.
I don't see how this can be properly done without asking users for some manual work.

Long story short, I can see this turning out to be its own thing in its own package.
Perhaps even the current command plugin could be merged with this at some point (v2 ? since we might need breaking changes).
In the end, I still think having a config option in the yaml file like group-by: tag is still much better.
I understand that you'd want to not bloat this package with things that can otherwise be implemented outside it, but I also think the command plugin will be way harder to use than having a simple field in the yaml file.
As someone who has tried selling OpenAPI to multiple people, as I believe in its value specially for bigger projects and in the longer term, the worst parts OpenAPIGenerator is how harder it is to use compared to just creating the routes right away in the Vapor / Hummingbird app. This will make things even more complicated and harder to use, as you'd need to learn yet another thing, as opposed to just getting everything for free after using the group-by field.
Part of the convenience problem is due to the nature of OpenAPI and the document not being "Swift" code, and having to learn about OpenAPI, but there are other parts that we can make easier, like this.

Thanks for the thoughtful description of the workflow. I'm even more convinced now that it should be its own separate tool, as it builds purely on top of Swift OpenAPI Generator, it doesn't use any of its internals. So it should be at least a separate module/plugin, but arguably a separate package.
It also sounds like package generation, I wonder if the Vapor CLI wouldn't be a good place for this? As a flavor of a generated package, one that integrates OpenAPI and splits per-tag into separate modules?
I think one advantage of splitting your service into subcomponents, like modules, is that you could iterate on them separately, test them separately, and they should be allowed to have distinct dependencies.
That's why I think separate modules for each tag is the right way to scale a service, and you're right that configuring a package this way could use some automation. Unclear for now whether this must be in this project, or could be done separately. What do you think, would this fit into Vapor's CLI?


Allow to use false for "no tools"

Thanks man! :) Fun thing: doesn't work, but isn't working on main as well - presumably after #52

well, it works to provide false and get an empty error - so basically this PR does it right! :+1:


Missing documentation regarding .NET Framework

The documentation does not mention how to configure the out of process hosting, if the ASP.net Core application does not use .NET Core but .NET Framework.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: fe69b3a9-896f-e189-0c2c-f87ff735df9c
Version Independent ID: 97c8549b-66ad-0a23-1971-784fb923042a
Content: ASP.NET Core Module
Content Source: aspnetcore/host-and-deploy/aspnet-core-module.md
Product: aspnet-core
Technology: aspnetcore-hostdeploy
GitHub Login: @guardrex
Microsoft Alias: riande

It shows both configurations in the Hosting models section at the top, and it includes the following line in the In-process section:

The in-process hosting model isn't supported for ASP.NET Core apps that target the .NET Framework.

The Out-of-process section has the following:

If the <AspNetCoreHostingModel> property isn't present in the file, the default value is OutOfProcess.
Set the value of the <AspNetCoreHostingModel> property to OutOfProcess ...

I think we're ok .... let me know if you would like to discuss this further, and we can re-open this issue.


microsofttranslator.com is no longer available token needed

Hello,
when i open a listing and i try to change the language button it redirects me from
https://mysite.com/fr/annonce/test
to
https://mysite.com/en/listing/test
and give me this error
Cocorico\CoreBundle\Entity\Listing object not found.
ERROR - Uncaught PHP Exception Symfony\Component\HttpKernel\Exception\NotFoundHttpException: "Cocorico\CoreBundle\Entity\Listing object not found." at /var/www/rent-a-kite.com/Symfony/src/Cocorico/CoreBundle/Request/ListingParamConverter.php line 75
also i was not able to correctly configure apache2.conf with the sample give on the website
And by the way do I have to modify sites-available conf or apache2.conf ?
when i copy the sample i change cocorico.dev to my site but apache doesnt reload because apparently there is some error in the file...
Thank you for your help

Also related : the new listings displayed on the front page  in English (Mysite.com/en) are not displayed in french (mysite.com/fr)
Thanks

Ok I found out that if i dont fill out the other languages tab it will send a error but it will be best to fill the other tabs with the same language if they are not filled by the user...
now my problem is when i click on translate button at the  bottom of the listing i get this error : at ErrorHandler ->handleError ('8', 'Trying to get property of non-object', '/var/www/mysite.com/Symfony/src/Cocorico/CoreBundle/Model/Manager/TranslateManager.php', '116', array('clientId' => '4cmyidb9d0ece0542', 'clientSecret' => '961a4mysecretkey50b8a4', 'curlHandler' => 'Resource id #544', 'request' => 'grant_type=client_credentials&scope=http%3A%2F%2Fapi.microsofttranslator.com&client_id=4c27d2c09myide0542&client_secret=961a4mysecretkeya4', 'response' => false, 'responseObject' => null))
in src/Cocorico/CoreBundle/Model/Manager/TranslateManager.php at line 116
Can someone help me? thank you

Am I mistaken or the link microsofttranslator.com is no longer valid ?
now its  https://api.cognitive.microsoft.com/sts/v1.0/issueToken
so I changed this in CoreBundle parameter.yml but it still doesnt work
I also did this according to microsoft with no luck
// Pass key using header
curl --header 'Ocp-Apim-Subscription-Key: ' --data "" 'https://api.cognitive.microsoft.com/sts/v1.0/issueToken'
// Pass key using query string parameter
curl --data "" 'https://api.cognitive.microsoft.com/sts/v1.0/issueToken?Subscription-Key='
It seems that there is some setup to do in symfony to make it work I am correct?
Thanks

since April the 30th they moved to Azure :
https://translatorbusiness.uservoice.com/knowledgebase/articles/1078534-action-required-before-april-30-2017-microsoft-t#code
Anyone knows how to modify the code?
thank you

https://github.com/MicrosoftTranslator/HTTP-Code-Samples/blob/master/PHP/PHPAzureToken.php
I found this but I dont know how to do it

Hello,
Indeed the ms translator service has been replaced by the new ms azure translator service.
This new service implementation will be added in a while.
In the meanwhile you can adjust the existing ms translator service implementation by the new one. The changes should be minor.
Or you can also disabled it until we add its new version.
Thanks

Thank you for your reply do you know approximately when the new version will be released?

Hi,
We have just realized it :
https://github.com/Cocolabs-SAS/cocorico/commit/39960f0677870cb8212ff3b8e47819837a2b88f2
Enjoy :)

Thanks a lot!!
is there a git command to automatically update ? (without deleting everything ) or do i copy the files manually?
thanls

Hi,
You can apply the patch of the corresponding commit:

Download the patch:
https://github.com/Cocolabs-SAS/cocorico/commit/39960f0677870cb8212ff3b8e47819837a2b88f2.patch

Check and apply the patch:

git apply --check 39960f0677870cb8212ff3b8e47819837a2b88f2.patch
git am --signoff <  39960f0677870cb8212ff3b8e47819837a2b88f2.patch

If you forked this repository you can also sync it with your own by following these instructions : https://help.github.com/articles/syncing-a-fork/
Hope it helps


Add Systemd unit

Hi, I've added a systemd user unit to run oracle-core.service. I haven't been able to test this extensively as I wasn't able to bootstrap a new pool on my last attempt.
Some questions:

Is there a systemd service available for ergo node? Ideally we'd have oracle-core.service depend on "ergo.service", so that once the unit runs the node will already be started
Ideally the service should be running without any user intervention, but I see one issue which is that the user needs to unlock the wallet. Should we maybe change the behaviour of oracle-core and have it unlock the wallet itself since we have the API key?

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 70.911%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
2445

Relevant Lines:
3448

💛  - Coveralls

Some questions:
* Is there a systemd service available for ergo node? Ideally we'd have oracle-core.service depend on "ergo.service", so that once the unit runs the node will already be started

Good idea, but AFAIK we don't have one. I've read in chats some time ago that someone made an Arch package though, but I cannot find it now.

* Ideally the service should be running without any user intervention, but I see one issue which is that the user needs to unlock the wallet. Should we maybe change the behaviour of oracle-core and have it unlock the wallet itself since we have the API key?

I like this idea, but I believe in most cases the wallet will be password protected. I don't think it's a good ideas to store this password in oracle's config.

I haven't been able to test this extensively as I wasn't able to bootstrap a new pool on my last attempt.

I fixed a couple of issues lately. Bootstrap should work now. You can give it another go.


where's the "Open with Codespaces" option?

If you would like to jump in right away by using GitHub Codespaces, you can click on "Code" in this repo and "Open with Codespaces"
source

I assume the "you can click on 'Code' in this repo" is this button, right?  I don't see that option? 🤔

Hey @spottedmahn, currently you need a level of GitHub subscription for this feature to show up.  I believe that is GitHub Team or GitHub Enterprise Cloud.  More here: https://docs.github.com/en/codespaces/getting-started/quickstart
There is a way to load the quickstarts in DevContainers on your local machine so long as you have Docker, VS Code, and VS Remote Container extension.  This is a similar experience, just running in containers on your own machine vs. fully in the cloud.  hope that helps. https://code.visualstudio.com/docs/remote/containers

currently you need a level of GitHub subscription for this feature to show up

that makes sense.  perhaps the readme.md should be updated then? 🤔
I'm happy to submit a PR for that 😉

currently you need a level of GitHub subscription for this feature to show up

that makes sense. perhaps the readme.md should be updated then? 🤔
I'm happy to submit a PR for that 😉

That's a good idea @spottedmahn, thank you.

I believe this is fixed based on your feedback

yep, looks great, thanks!


Add SignatureAPI connector

When submitting a connector, please make sure that you follow the requirements below, otherwise your PR might be rejected. We want to make you have a well-built connector, a smooth certification experience, and your users are happy :)
If this is your first time submitting to GitHub and you need some help, please sign up for this session.

[x] I attest that the connector doesn't exist on the Power Platform today. I've verified by checking the pull requests in GitHub and by searching for the connector on the platform or in the documentation.
[x] I attest that the connector works and I verified by deploying and testing all the operations.
[x] I attest that I have added detailed descriptions for all operations and parameters in the swagger file.
[x] I attest that I have added response schemas to my actions, unless the response schema is dynamic.
[x] I validated the swagger file, apiDefinition.swagger.json, by running paconn validate command.
[x] If this is a certified connector, I confirm that apiProperties.json has a valid brand color and doesn't use an invalid brand color, #007ee5 or #ffffff. If this is an independent publisher connector, I confirm that I am not submitting a connector icon.

@vmanoharas the API Properties Validator failed as scriptOperations is not in the schema of apiProperties.json. Not sure how to proceed, as I am using custom code for a couple of operations.

@vmanoharas the API Properties Validator failed as scriptOperations is not in the schema of apiProperties.json. Not sure how to proceed, as I am using custom code for a couple of operations.

Hello @cucho,
Please ignore this error, we need to update our schema.


Get a way to print the HTML on error

What is your Scenario?
When a test fails, it's useful to have a screenshot/video. However, sometimes the screenshot/video looks ok in CI and it's hard to see why a selector did not match.
What are you suggesting?
Add a configuration (like for screenshots) to take a "DOM screenshot" on failure.
What alternatives have you considered?
Such a patch can be applied locally (for example for Chrome)
diff --git a/lib/screenshots/capturer.js b/lib/screenshots/capturer.js
index 4e93dd879e5d57f9ec9d87ed56ec47cbce329cdc..693995aef3a1544e33d0ddb600137cbdd79240c4 100644
--- a/lib/screenshots/capturer.js
+++ b/lib/screenshots/capturer.js
@@ -87,6 +87,16 @@ class Capturer {
     }
     async _takeScreenshot({ filePath, pageWidth, pageHeight, fullPage = this.fullPage }) {
         await this.provider.takeScreenshot(this.browserId, filePath, pageWidth, pageHeight, fullPage);
+        try {
+            const cdpClient = await this.provider.plugin.getCurrentCDPSession(this.browserId)
+            const {root: {nodeId: documentNodeId}} = await cdpClient.DOM.getDocument();
+            const {outerHTML} = await cdpClient.DOM.getOuterHTML({nodeId: documentNodeId});
+            const htmlFilePath = filePath.replace('.png', '.html');
+            await (0, promisified_functions_1.writeFile)(htmlFilePath, outerHTML);
+            console.log('html file saved to', htmlFilePath)
+        } catch (e) {
+            console.log('error saving html file', e)
+        }
     }
     async _capture(forError, { actionId, failedActionId, pageDimensions, cropDimensions, markSeed, customPath, customPathPattern, fullPage, thumbnails } = {}) {
         if (!this.enabled)

Additional context
There is a similar request here which was not really addressed: https://github.com/DevExpress/testcafe/issues/4910

Hello @hverlin,
Unfortunately, we cannot take this enhancement to work, since we are currently focused on other tasks. We may reconsider this task priority in the future if we get requests for it. You can create a PR with the described functionality, and we will review and accept it if everything is ok.

Thank you for the quick answer. I will just go with a local patch for now.

I will close this issue for now. If more users request this feature, we will reopen it. In the meantime, you can share your patch so other users can benefit from it if needed.

The patch shared here will work with Chrome at least. It can be applied with pnpm patch or other similar tools


option gridOpacity is not working

gridOpacity in options is not working.
I have below default options
{
          provide: SLIMSCROLL_DEFAULTS,
          useValue: {
              alwaysVisible: false,
              gridOpacity: '0.6', barOpacity: '0.4',
              gridBackground: '#C2C2C2',
              gridWidth: '6',
              gridMargin: '2px 2px',
              barBackground: '#2C3E50',
              barWidth: '6',
              barMargin: '2px 2px'
          }
      }

No matter what value i set in gridOpacity. It's not working. Can anyone help me resolve this.
I don't want to display grid so i want to set gridOpacity to 0. But none of the value works

please try new version 7.1.0 from npm. should work now.

Yes. Worked with new version. Thanks.


Address Points

As per the discussion between Simon, Joe and Trent on Friday 18 January, the Addressing Team have noticed that the Address Points are sometimes not loading up as expected.  The points either take a long time to load, or they don't load at all.  A work-around is to close out of the application and try again.
@SPlanzer, @jason-bedford can provide you with further detail if need be.
Thanks
Trent.

A workaround for this issue is to load a different plugin, for example the QGIS IntraMaps Connector, before loading the AIMS plugin.
Since loading the plugins in this order I haven't been having the issue with the addresses not displaying.


junits_dir missing $

https://github.com/buildkite-plugins/junit-annotate-buildkite-plugin/blob/84e1ea9808f23525b2aaa0f4b193e69ffde35392/hooks/command#L15
This line is using junits_dir instead of $junits_dir, causing an error during execution like Could not find information about destination: [redacted]/junits_dir since the directory doesn't exist.

Yep I think so!
On Wed 11. Apr 2018 at 18:24, Keith Pitt<EMAIL_ADDRESS>wrote:

Oh wait a tick...is it supposed to be:
buildkite-agent artifact download "${BUILDKITE_PLUGIN_JUNIT_ANNOTATE_ARTIFACTS}" ${junits_dir}
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/buildkite-plugins/junit-annotate-buildkite-plugin/issues/2#issuecomment-380644995,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAAfolgsJUOmH-AlhbF33q6Z3gqgpcAJks5tnqzBgaJpZM4TQ_Cd
.

Sorry, the plugin was released a little earlier than when it was ready. We've taken the time to fix it up and release a new version. Give it a spin and let us know if it's working as expected.

Great, thanks!


[IMPROVEMENT] When just switching accounts, none of the buttons on the main page respond.

Issue to be solved
I found this issue in ios dev version 2.0.0(1) and ios prod version 2.1.3(6).
When just switching accounts, none of the buttons on the main page respond. It takes a while for the buttons to start working. Could we add a loading or use other solution to improve it?
Suggest A Solution
No response

Move button, QR code button, transfer button and receive button not work
https://github.com/Outblock/FRW-iOS/assets/87978227/0f65c173-6bbd-4e8e-9d3a-852ae0e35edf

This issue already solved in ios prod version 2.1.5(3).
The demo video is attached below.
https://github.com/Outblock/FRW-iOS/assets/87978227/4390ee50-8085-45fb-b151-600e25b5ca74


LibWeb: Rename CommandList to DisplayList

Use more widely recognized names among browser engine developers.

Just my opinions: RecordingPainter was fine, it's a Painter that Records. DisplayListPlayer sounds a bit odd but it will do

RecordingPainter is a bit ambiguous, and could also be a Painter that paints Recordings. :shrug:

RecordingPainter is a bit ambiguous, and could also be a Painter that paints Recordings. 🤷

Hm, True


Modifying for Service Area

How do I adapt this code to utilise Service Area analysis rather than OD Cost Matrix, and to also loop through multiple polygon barrier files?

Hello @Sirocco97. My apologies for the delay in response. I didn't see your issue until just now for some reason (and I adjusted my notification settings so it won't happen again).
In theory, you should be able to retain most of the structure of the OD Cost Matrix script and just swap in Service Area.  Here is some helpful documentation for the ServiceArea network analysis solver class and its associated result object:
https://pro.arcgis.com/en/pro-app/latest/arcpy/network-analyst/servicearea.htm
https://pro.arcgis.com/en/pro-app/latest/arcpy/network-analyst/servicearearesult.htm
If you have never worked with these solver objects at all before, you will benefit from reading the overview help topic here: https://pro.arcgis.com/en/pro-app/latest/arcpy/network-analyst/performing-network-analysis.htm
If you're just generating Service Area polygons for a large number of facilities, you can strip out a lot of the optimizations for OD Cost Matrix. For example, you don't need to pre-select destinations within a straight-line cutoff of origins since this doesn't apply to Service Area. I suspect your modifications will largely involve deleting code that doesn't apply.
Depending on the size of your problem, you might want to first try just solving it straight in ArcGIS Pro without this special parallelization script. In recent releases of ArcGIS Pro, we have made some enhancements to the Service Area solver when using a network dataset in a mobile/sqlite geodatabase. This parallelizes the solve internally and, depending on your problem size, may be fast enough for you. To get your network dataset into this format, you need to run the Create Mobile Map Package tool, or use the pane in the ArcGIS Pro UI, and then extract the package. You can contact Esri Support if you need help with this.

I'm going to assume this question has been adequately answered.  Feel free to reopen if you still have questions.


Visualization of point cloud after segmentation

I want to output the image after segmentation like the image in your paper.
Is there a way to output point cloud data after segmentation?
I would appreciate it if you could let me know.

i want too，can you share


Mobile enabled endpoint

The mobile_enabled API endpoint doesn't seem to implemented/proxied by this wrapper, if I'm reading the code correctly. Any reason for that?

I should have read the code more closely. Obviously, one can use the generic get function to query that specific endpoint. Apologize for the extra noise.


Snapshot extension package warning for Extensions

I've tried to express this and I'm not sure I've done that well. Happy to take suggestions on rewording

@dionmcm I don't understand the risk of using extension snapshots. Is this about not ending up with rows from the extension package that should no longer be effective because they have been superseded?
The recommendation to not use snapshots perhaps depends on the import strategy?
In one approach using deltas / full is safer because each version of the base edition and extension can be imported in effective time sequence to end up with the correct set of effective rows. This relies on importing the full history of each package.
In an alternative approach the base edition is already imported and an extension snapshot can be imported with a row filter that skips any rows that already exist with a greater effective time in the store.
I'm really not sure which approach is "easier" for implementers. The first requires full packages to be filtered by effective time and imported multiple times in the correct order. The second requires filtering based on existing rows. I suppose neither of these issues exist when using an edition snapshot!
Have I understood the issue and can you see any problem with second approach?

Yes @kaicode, the issue is really that an extension Snapshot (as opposed to an edition Snapshot) is really like a patch or delta that needs to be applied to something (and the risks involved in doing that correctly), rather than the edition Snapshot that is a stand alone, ready to use thing.
The issue is really the complication/risk of correctly applying the extension Snapshot to the base Snapshot and recalculating the correct row to keep for each component. In theory the "right" way to do that is using the MDRS from the extension and base edition to filter down to the right modules and rows, then find the latest state for each component within the MDRS module/effective time constraints. Basically the same as you'd do with a Full/Delta but applied to a subset of rows.
However assuming this has already been done correctly and you're mixing an extension Snapshot with the same base Snapshot package/version it was classified/calculated/created against, I think the approach of taking the row with the latest effective time as the merge conflict resolution strategy would work as a shortcut process based on those assumptions. @lawley do you see any issues with this?
The other edge case is if the base edition contains additional content not represented as dependencies in the MDRS (for example derivative content) whether this content is in or out of scope for the resultant extension Snapshot when merged with its base. Obviously calculating this based on the MDRS such content would be removed, whereas using the "keep the latest row per component" shortcut that sort of content would be retained...resulting in different sets of content. But I think this is a bigger current issue in our Snapshot calculation rules, it is just that an edition Snapshot resolves all of this explicitly.
I suppose the point is that

the edition Snapshot for the extension disambiguates all of this by providing the resolved content,
whereas the extension Snapshot leaves the consumer with some work to do to figure out what the right state is for all of the components, and indeed if they should be present at all.

The concern with the extension Snapshot wasn't about what was easier for implementers but about what is safe/consistent to reproduce the same result. So whether the work required to use an extension Snapshot will be understood and implemented consistently and correctly by everyone implementing (existing and new over time) and perhaps edition Snapshots are a safer option.
This is a bit different for derivatives as opposed to extensions. Extensions are particularly prone to this complication because they need to change the state of components from "upstream" modules - for example retiring is-a relationships as part of NNF transitive reduction post classification. Derivatives just create their own new components that don't affect the state of "inherited" components so don't have this issue.
That's why I think derivatives work best as extension packages and extensions work best as edition packages.

There is no argument about extension snapshots vs edition snapshots - that is clear.
This PR and my question is about extension snapshots vs extension deltas/fulls - my point was that I don't think it's any harder to work with extension snapshots than extension fulls. I actually think extension snapshots are more concise and convenient than extension fulls.
I would vote for this PR to be reverted.

I'm still not sure if we're actually talking about the same thing, or if the wording I came up with really told the story.
I wasn't really trying to make a point about extension snapshots vs extension deltas/fulls.
What I was trying to say is because of the Snapshot issue if you're only going to have one package

publish Extensions (in the Derivative vs Extension sense) as Edition RF2 packages
publish Derivatives as Extension RF2 packages

This is mostly just about the Snapshot in those packages and how for 1 above the Snapshot is potentially confusing to handle, and the Edition packaging is less work for most implementers and less likely to result in mistakes. Any implementers who genuinely want the extension packaging of the Extension are probably in the minority and able to derive that fairly easily and safely from the edition packaging if an extension package isn't also available (which it could be).
The double use of the word Extension is a bit confusing.

Sorry I got confused with another ticket in my last (now deleted) comment.
So I think you're right that this depends on import strategy, but I guess the point is that unless you know that it would be easy for an implementer to the simplest thing and get it wrong.
Not something that is a risk with edition snapshots because there's no special import strategy required. But, it feels lower risk with Delta/Full extension packages because they clearly need steps to ingest that anyone using would need to investigate to figure out what to do. The Snapshots appear simple enough that they present the risk that someone might not do that.
All of that said, I'm not wedded to this, particularly if there are edition packages available for these things and implementers are encouraged there first unless they know what they are doing. If the extension Snapshot doesn't exist it just feels like one less chance that someone will get it and make a mistake.

In an alternative approach the base edition is already imported and an extension snapshot can be imported with a row filter that skips any rows that already exist with a greater effective time in the store.

I think this is right, provided that you're applying it to the right base edition. If not, then the extension component versions may be overridden by newer base edition versions and mess things up. Obviously this doesn't happen with an edition Snapshot, but it also doesn't happen if you get an extension Full and apply it to a newer base edition Full and calculate the Snapshot using the MDRS. If you take this shortcut in that scenario you'll get a different result to applying the Full and calculating the Snapshot with the MDRS.

Thanks Dion. I understand your point of view now.
I think there is an almost equal risk of implementers consuming the delta or full packages incorrectly and not realising. Consuming any extension package types correctly will require some guidance. It seems the best we can do is to provide the simplest mechanism to get it right with the shortest and clearest explanation!
I believe using the snapshots is the best way to achieve this simplicity. I think in nearly all cases it's simple date comparison so I don't think that the MLDS is even required. The greatest effective-time wins.
The only possible scenario that I am aware of where the MLDS may be needed is when a row has been published twice in different modules but with the same effective time. I'm not sure how often this happens but it's likely that we can come up with a simple rule here. For example let the extension package win - again not really needing the MLDS, to simplify implementation.
Thoughts?


Correctly handle WrappedCompositeByteBufs in addFlattenedComponents()

Motivation
An NPE was reported in #10245, caused by a regression introduced in #8939. This in particular affects ByteToMessageDecoders that use the COMPOSITE_CUMULATOR.
Modification

Unwrap WrappedCompositeByteBufs passed to CompositeByteBuf#addFlattenedComponents(...) method before accessing internal components field
Extend unit test to cover this case and ensure more of the CompositeByteBuf tests are also run on the wrapped variant

Results
Fixes #10245

@netty-bot test this please

@njhill thanks a lot!


API Authorization and Authentication

How will we authenticate users to our API and how will they be authorized to perform certain actions?

We may want 2 different classes of API authentication, or maybe just the one.
For non-humans, we probably want non-human accounts in the user model, and we probably want to signify somehow that they are a service account via a table, or convention. i.e sa-metadata-database for the token the metadata-database will use. or a table is_robot?
For this class of user, we probably want users and tokens generated by scholarsphere admins to hand out to the admins of the dependant services ( we could potentally open this up to standard users, too??)
something like https://github.com/gonzalo-bulnes/simple_token_authentication would work for this.
For humans, we could use the same strategy, or we could use something like tiddle or devise-jwt to have shorter lived, renewable tokens
https://github.com/waiting-for-dev/devise-jwt
https://github.com/adamniedzielski/tiddle
I think coming up with the non-human path would be step #1 and then we can see if we need something more elegant for humans?


Support: AccessDenied

Hi,
Great guide, tried to deploy this myself but getting 'AccessDenied' when hitting the bucket (after auth with cloudrun)
I suspect somethings change in how it reads the headers and possibly Cloud_CDN_Cookie is no longer first?
Or maybe I'm doing something silly, can confirm the cdn key is the same for bucket and cloud run, for cloud run I ensure it's base64 encoded.
Any chance this is still working for you? or are you seeing the same error?
Thanks

nvm, got this working, had a couple errors with the key, and the cookie name itself, for some reason it didn't like Cloud_CDN_Cookie but works when named Cloud-CDN-Cookie (replace underscores with dashes)


[Bug] When performing consecutive intersections/differences of multiple tables,SQL result is error

Search before asking

[X] I had searched in the issues and found no similar issues.

Version
2.0.2/2.0.3/master etc.
What's Wrong?
When performing consecutive intersections/differences of multiple tables, if the nullable attribute of a column in the left table is set to false, and the left table contains zero values while the right table contains null values, the result is incorrect.
sql like this :

The correct result is the opposite of that.
What You Expected?
this bug's reason I've found ,but due to changes in different versions, hope someone experienced can fix it.
How to Reproduce?
just execute the sql
Anything Else?
No response
Are you willing to submit PR?

[ ] Yes I am willing to submit a PR!

Code of Conduct

[X] I agree to follow this project's Code of Conduct

It's a bug, I will do the fixed, thank you!


I can't sync after I edit some block

I have to say this app is amazing for me which I have waiting for a long time.
But when I use the app, after I edit some block, I can't sync. Even I can open pwa version.
iOS  15
iPhone 7 Plus

Picture shows 'Roam is online'.
Only when I reopen RR, sync will work will.
Thank you for making such an amazing app!

@Batapha If this is something that also happens from Safari (or on the PWA mode), I, unfortunately, can't do anything about it, and you should contact the Roam folks to report it 😃


Optimize code generation for common cases of Requires

Currently the rewriter produces verbose code for the following:
Contract.Requires<ArgumentNullException>(param != null, "param");

In release builds, I would expect this to be rewritten exactly as:
if (!(param != null))
  throw new ArgumentNullException("param");

What does the rewriter produce today?

It produces this:
__ContractsRuntime.Requires<ArgumentNullException>(array != null, "array", "array != null");

Which is efficient for the "fast path", but terrible for cases where the exception does get thrown (significant use of reflection APIs).

Yes, I guess out belief was that exceptions should be, well, exceptional and so performance for the failing case was not important. Note that the form you propose would have to be contingent on the user wanting exactly that behavior: if they want to provide custom methods for handling contract failures or fail-fast behavior then the current rewriting should be retained.
We would like to get all of the VS2015 issues resolved before we start making these kinds of changes, but if you would like to implement this, then that would be great!

I totally agree with Mike, that current behavior is correct, because runtime behavior of the failure is highly configurable.
So the call to _ContractRuntime should be preserved any way, but implementation of that method could be enhacned.
Two additional points:

Bug case (please not, that contract violation is not a "regular" exceptional case it is a subset of exceptional case when exception represents a bug) should be super rare.

Reflection is used because any exception type that accepts message could be used in this case.
it is possible to add some "specializations" for different exceptions, but we should consider pros and cons of this approach (benefits vs. potential issues).

I should add, I see this as a special case for the behavior when the rewriter is configured for ReleaseRequires contract checking only. I use this mode for shipping assemblies, and do not expect (or want) a contract failed event to occur. I'm also not expecting consuming code to be using Code Contracts (relevant for the bug case). Contract.Requires<TException> is essentially used at the public interface boundaries and for release it would be ideal for it to behave the same way as any other "normal" .NET module behaves for argument validation.

Yep, that all sounds reasonable. I think it would be a great thing --- I hope my comments didn't sound negative about it. I just want to make sure that we don't preclude any of the existing behavior.

@sharwell Just in case. I'm using following trick in this case: I'm using if-throw + Contract.EndContractBlock. In this case I would be able to turn contracts altogether and still get the desired behavior.
But we can do proposed trick.

@mike-barnett I did interpret your comment according to that.
@SergeyTeplyakov I considered that approach, but it comes with its own downsides. In particular, with rewriting I can associate the contracts with a public interface and they will be automatically inserted in my internal implementation.

@sharwell I don't think that you have downside that you mentioned. if-throw (i.e. legacy) requires are treated the same way as the regular preconditions. So you would still have them copied into internal implementation even with suggested approach.

@sharwell Umm, just to make sure: you mean you interpreted my comments as sounding too negative? If so, I am very sorry. Your contributions to the project are fantastic!

@mike-barnett No, the opposite. I understood them the way you meant from the start. :smile:

Phew! Electronic communication is tough...

As far as I remember the Generic version of the method Requires used to contained a bug.
Generic method Contract.Requires is missing [Conditional("CONTRACTS_FULL")] attribute.
Not sure if this was fixed.

@risogolo That's not a bug. Calls to Contract.Requires<TException> must always be compiled.

Not sure If I quite understand, I had an issue when I was using that Generic version of Contract.Requires, it was not never rewritten when I wanted to to compile with no CC used. The code was still compiled to the body of my method od contructor. So I had to start using not generic implementation.

@risogolo that's by design. The generic version is provided as a terse "if (!precondition) throw" useful at surface-level methods which are supposed to throw specific exceptions when the preconditions are not met. It's not meant to be elided when CC is off, it allows you to specify the "fail path" of your interfaces while at the same time feeding the checker information about expected input.

OK then, but I had an issues with this design for example on build server, I'm not able to install CC on the build sever. Or I might not to be able on install CC to the production, then I have an issue. Do you suggest something?

The production server doesn't need to know anything about CC, provided the Build server somehow managed to rewrite the assemblies before deployment. We actually have CC installed in our build agents, but I believe some work was done in the repo to make CC a NuGet package. I haven't tried it myself, but the package is available for download in the releases section. You could upload that to a private NuGet server your CI system is aware of.

Once there will be an official nuget package then it will cure my issue, thx

@risogolo ETA for publishing new nuget package - this week.

Hello, by word "new" you probably meant first version of nuget package, I was not aware there is an official nuget package, even though I have found a couple of unofficial

Out of curiosity why: if (!(param != null)) and not: if (param == null)

Negating the contract to raise the failure is easier and less prone to bugs than transforming the expression, which can be arbitrarily complex (e.g. param == null || (param.Count >= 1 && param.Count < 8)). Granted, there are clear rules for doing so but very little gain from it.

Ah, that makes perfect sense. What about the stacktrace, Does it throw deep inside the cc code?

For discussion's sake, here's ILSpy's output from __ContractsRuntime:
namespace System.Diagnostics.Contracts
{
	[CompilerGenerated]
	internal static class __ContractsRuntime
	{
		[DebuggerNonUserCode, ReliabilityContract(Consistency.WillNotCorruptState, Cer.MayFail)]
		internal static void Requires<TException>(bool condition, string msg, string conditionTxt) where TException : Exception
		{
			if (condition)
			{
				return;
			}
			string text = ContractHelper.RaiseContractFailedEvent(ContractFailureKind.Precondition, msg, conditionTxt, null);
			Exception ex = null;
			ConstructorInfo constructor = typeof(TException).GetConstructor(new Type[]
			{
				typeof(string),
				typeof(string)
			});
			if (constructor != null)
			{
				if (constructor.GetParameters()[0].Name == "paramName")
				{
					ex = (constructor.Invoke(new object[]
					{
						msg,
						text
					}) as Exception);
				}
				else
				{
					ex = (constructor.Invoke(new object[]
					{
						text,
						msg
					}) as Exception);
				}
			}
			else
			{
				constructor = typeof(TException).GetConstructor(new Type[]
				{
					typeof(string)
				});
				if (constructor != null)
				{
					ex = (constructor.Invoke(new object[]
					{
						text
					}) as Exception);
				}
			}
			if (ex == null)
			{
				throw new ArgumentException(text, msg);
			}
			throw ex;
		}
	}
}

What about generating as many methods as distinct exception types required by the assembly, instead of a single generic method? (one can still be generated to unify the failure raising code). This would nuke the reflection perf losses, and still allow event raising (which could be further configured to be as no-op as possible).

@JohanLarsson it's not too bad, two or three frames deep when dealing with the ContractFailedEvent, and only one when throwing the exception (which is gracefully hidden from view within VS due to the DebuggerNonUserCodeAttribute used in the method above).
Tangentially related to this, as far as I can tell there's no way to differentiate a Requires from a Requires<> from within the ContractFailed event handler (both use ContractFailureKind.Precondition). Perhaps there's merit in allowing the user to know the exception type the precondition was qualified with?

I agree with @sharwell that it would be ideal to have more the more optimized version of the rewritten IL for Requires<TException>. On top of the optimization gain, it would also shut FxCop up about CA1062. I know I'm not the only one wishing FxCop and CC played nicely together...
http://geekswithblogs.net/terje/archive/2010/10/14/making-static-code-analysis-and-code-contracts-work-together-or.aspx

it really would be awesome to be able to turn CA1062 back on.
it's such a great check.

Since the type is known at compile time it should be quite straightforward to make all the reflection at rewrite time and end up with something similar to the code below while still preserving the same behaviour as today (almost, apart from slightly changed stack trace).
This would also change the stack trace so that the exceptions seems to come from the method using the Requires instead of from within the code contract runtime.
if (!(condition))
{
   string msg = ....;
   string conditionTxt = ...;
   string text = ContractHelper.RaiseContractFailedEvent(ContractFailureKind.Precondition, msg, conditionTxt, null);
   throw new TException(....); // text,msg order determined by same logic as in __ContractsRuntime.Requires<TException>
}

Using release requires I guess it could just skip the call to the RaiseContractFailedEvent, but then it was a while ago I read about exectly how it is supposed to work.
if (!(condition))
{
   throw new TException(....); // text,msg in order as
}

For the original example the rewritten output then be rewritten as:
if (!(param != null))
{
   string msg = "param";
   string text = ContractHelper.RaiseContractFailedEvent(ContractFailureKind.Precondition, msg, "param != null", null);
   throw new ArgumentNullException(msg, text);
}


Add link to Hybrid + Web tutorial from Reuse Razor Components guidance

We've got a new tutorial and this shows how to implement the interfaces pattern shown in the conceptual docs to provide different implementations for the different hosting models when reusing razor components. We should link to it! Currently we only have the reverse.
Add a link from:
https://learn.microsoft.com/en-us/aspnet/core/blazor/hybrid/reuse-razor-components?view=aspnetcore-8.0#net-maui-blazor-platform-specific-code
To:
https://learn.microsoft.com/en-us/aspnet/core/blazor/hybrid/tutorials/maui-blazor-web-app?view=aspnetcore-8.0#using-interfaces-to-support-different-device-implementations

BTW @BethMassi ... It will probably be difficult to remember, but if you apply the blazor-hybrid/subsvc label, it will trigger a workflow to set everything else.


[FLINK-13098][datastream] Add a new type UNDEFINED of shuffle mode

What is the purpose of the change

This new shuffle type leaves some space for optimization later. The optimization might be based on resources or some global settings.

Brief change log

The UNDEFINED type is the default value of shuffle mode. If there is no specific PartitionTransformation, the shuffle mode would be UNDEFINED.
The UNDEFINED shuffle mode can be chained

Verifying this change

Modify the existing case to cover this

Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): no
The public API, i.e., is any changed class annotated with @Public(Evolving): yes
The serializers: no
The runtime per-record code paths (performance sensitive): no
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: no
The S3 file system connector: no

Documentation

Does this pull request introduce a new feature? no
If yes, how is the feature documented? not applicable

@flinkbot attention @aljoscha

CI report for commit 71f31349c115a02902144c852dd8bf4208ca91aa: SUCCESS Travis

This PR is merged through https://github.com/apache/flink/pull/8985. So close it.


no need to use defer to release response Body

There is no need to use defer func to release response Body, just Close it directly. And another codes that processing Closing the Body also Close directly
fix some comments of stsclient
[ ] Configuration Infrastructure
[ ] Docs
[ ] Installation
[ ] Networking
[ ] Performance and Scalability
[ ] Policies and Telemetry
[ ] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure
Pull Request Attributes
Please check any characteristics that apply to this pull request.
[ ] Does not have any user-facing changes. This may include CLI changes, API changes, behavior changes, performance improvements, etc.

@gy95: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Rerun command

release-notes_istio
e621abf1125f6a382d17d126015f7e601e6c4633
link
/test release-notes_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest

Got it


use files array instead of npmignore

I hadn't been updating .npmignore, which meant we were including dotfiles like .eslintignore, which was silly.

"files" is dangerous, and i'd prefer to revert this; accidentally including dotfiles is a zero-damage minor annoyance; accidentally not including production files breaks consumers.

@ljharb Then presumably we'd fix it and create a new patch release? Also, how likely is that to happen? We're including whole directories, that kind of structure doesn't change often, if ever.

In that case yes, we'd have to fix it and create a new patch (just like if we discover files are accidentally included). I agree it's very unlikely, and in this case, our only consumer is ecma262 which has a lockfile, but between in general a nonzero chance of breakage, versus a zero chance of breakage and a nonzero chance of minor annoyance, it just doesn't make any sense to choose the nonzero damage tradeoff.

I prefer loud errors that can be resolved quickly over quiet ones that go unnoticed forever.

@ljharb Using .npmignore does not make it impossible that we fail to include a necessary file, since there is nothing which prevents us from adding a necessary file which matches a .npmignore pattern.
If we are worried we might not include some necessary file we should test that explicitly. I'll write a quick PR.

@michaelficarra extra files are not errors, they're no-ops. It's nothing more than an optimization to exclude them.
@bakkot you're totally right that testing what npm pack picks up resolves this issue with either approach; i'll take a look at the PR.


Re-enable keyvault tests on .net 5

I believe this is done. Any specific ones? I believe they are all running. Please reopen with a list if not.


Unable to implement NLog when hosting medium trust level application on shared server

Bug : Server throws Security exception when medium level trust application is hosted. I am hosting my application in Shared Server. I have referred this issue and but couldn't exactly get how to resolve this.

NLog version: 4.3.11
Platform: .Net 4.0
Current NLog config
<configSections>
       <section name="nlog" type="NLog.Config.ConfigSectionHandler,NLog"/>
</configSections>
<nlog xmlns="http://www.nlog-project.org/schemas/NLog.xsd" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance">
    <targets>
      <target name="logfile" xsi:type="File" fileName="${basedir}APILog\${date:format=yyyy-MM-dd}-api.log"/>
    </targets>
    <rules>
      <logger name="*" minlevel="Trace" writeTo="logfile"/>
    </rules>
</nlog>

In case of a BUG:

What is the current result? - The above said exception
What is the expected result? - The application should log errors as this works in local system
Please post full exception details (message, stacktrace, inner exceptions)

"ExceptionMessage": "Request for the permission of type 'System.Configuration.ConfigurationPermission, System.Configuration, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a' failed.", "ExceptionType": "System.Security.SecurityException", "StackTrace": " at System.Security.CodeAccessSecurityEngine.Check(Object demand, StackCrawlMark& stackMark, Boolean isPermSet)\r\n at System.Security.CodeAccessSecurityEngine.Check(CodeAccessPermission cap, StackCrawlMark& stackMark)\r\n at System.Security.CodeAccessPermission.Demand()\r\n at System.Configuration.BaseConfigurationRecord.CheckPermissionAllowed(String configKey, Boolean requirePermission, Boolean isTrustedWithoutAptca)" }

Are there any work arrounds? No. As of now I've commented the above configuration and it works fine.
Is there a version in which it did worked? N/A

Thanks for the bug report.
You could try using a separate nlog.config.

@304NotModified Could you please how can I do it with separate nlog.config file. I am afraid I am not able to understand what you said.

@304NotModified Could you please how can I do it with separate nlog.config fil

Put your config in nlog.config, https://github.com/NLog/NLog/wiki/Tutorial#configuration

Also I updated the library from NuGet but still am facing the SecurityException issue

Yes it's not on nuget yet. Will release a private package in a few minutes

Should this NLog.Config file be presented in my application root folder. Are there any other setups to be done after these configurations are added in separate file?

Should this NLog.Config file be presented in my application root folder.

That's one of the options. See also https://github.com/NLog/NLog/wiki/Configuration-file#configuration-file-locations
Build is still building..

@304NotModified Thanks much for sharing this.. 👍 Appreciate the efforts.. 🥇 Hopefully, I should be able to run my application after this.. :)

@kshkrao3
could you try this package : https://www.nuget.org/packages/NLog/4.4.1-dev-b4084

Install-Package NLog -Version 4.4.1-dev-b4084 -Pre

Unfortunately, I am still getting the same exception. I updated NLog with above package, created a separate NLog.config file in root directory of project. Still no luck.. :( Here's my project structure as of now.

Here is the exception details if you want

"ExceptionType": "System.Security.SecurityException", "StackTrace": " at NLog.Common.InternalLogger.LogAssemblyVersion(Assembly assembly)\r\n at NLog.LogFactory.LogConfigurationInitialized()\r\n at NLog.LogFactory.get_Configuration()\r\n at NLog.LogFactory.GetLogger(LoggerCacheKey cacheKey)\r\n at NLog.LogFactory.GetLogger(String name)\r\n at NLog.LogManager.GetCurrentClassLogger()\r\n at BS_API.Helpers.NLogger..cctor() in F:\Projects\Kemmale Projects\Bake Studio API\BS API\BS API\Helpers\NLogger.cs:line 18"

Here is the exception details if you want

It's not the same as before I think, but we could fix it with that stacktrace

Yea, its not same. I did not observer that.. :)

If you set <nlog throwExceptions="false">, it there still an exception?
It should not

Is reading the Assembly property of Type disallowed in Medium trust?

Is reading the Assembly property of Type disallowed in Medium trust?

@304NotModified For this, I might need to ask my hosting provider for the details.
In the mean time I can try

If you set , it there still an exception?
It should not

Do you have more exception details? Message, inner data etc

Do you have more exception details? Message, inner data etc

No bro. That's all I got. :(

If you set , it there still an exception?

It should not

It still hits exception.

I am unable to debug this in local, as I do not face any issue in local.

"ExceptionType": "System.Security.SecurityException", "StackTrace": " at NLog.Common.InternalLogger.LogAssemblyVersion(Assembly assembly)\r\n at NLog.LogFactory.LogConfigurationInitialized()\r\n at NLog.LogFactory.get_Configuration()\r\n at NLog.LogFactory.GetLogger(LoggerCacheKey cacheKey)\r\n at NLog.LogFactory.GetLogger(String name)\r\n at NLog.LogManager.GetCurrentClassLogger()\r\n at BS_API.Helpers.NLogger..cctor() in F:\Projects\Kemmale Projects\Bake Studio API\BS API\BS API\Helpers\NLogger.cs:line 18"

This one is fixed in https://github.com/NLog/NLog/pull/1874

@kshkrao3 update! :
https://www.nuget.org/packages/NLog/4.4.1-dev-b4085

Install-Package NLog -Version 4.4.1-dev-b4085 -Pre

@304NotModified I will try this update and let you know.. :)

@304NotModified I confirm that this works fine. Really happy about the fix and I can't really express it here.. :) :) :) Thanks you, Thank you and Thank you so much for the efforts you've put to resolve this.. :)

Great! Will merge it for NLog 4.4.1. Also thanks to @snakefoot!

Thank you @snakefoot .. :) 🥇

4.4.1 has been released!

Thank you for the update @304NotModified .. :)


Gradient boosting Xgboost

Here is our online publish -> https://alish26.github.io/kbtu-ml-book/gradient_boosting/xgboost.html


Rerun failed runs

It would be nice to have an option to rerun the then last run. For example if phytest fails and you modify the tests the entire pipeline has to be rerun to get back to the testing stage. I tried adding in a --rerun-last flag and setting the run_id to the last run. But snakemake says the files have changed since the last run and won't resume from the failed step.

Closing in favour of #16


Add HSTS support

Closes #112
Not sure if this should go in a separate project like https://github.com/amphp/http-client-cookies but it is fairly well-contained.  Note that I couldn't run the test with a full request because it auto-promotes to HTTPS (which is what we're testing here) and the interception test won't respond with HTTPS.

Is there any chance of getting this merged into v5, or should this go into a separate project?

This should go to a separate repo, as we might want to automate releases there with an updated preload list.
I can create one so you can open the PR there. 😊


 This make it's difficult to debug the loading.

There has been some progress with this covering common errors.

Exceptions have been improved a lot since this issue was created. Closing.


[libjuice] Update to 1.5.2

Fixes #39812. Update libjuice to 1.5.2, and make a simple fix in portfile.cmake to remove the need to define JUICE_STATIC.

[x] Changes comply with the maintainer guide.
[x] SHA512s are updated for each updated download.
[ ] ~The "supports" clause reflects platforms that may be fixed by this new version.~
[ ] ~Any fixed CI baseline entries are removed from that file.~
[ ] ~Any patches that are no longer applied are deleted from the port's directory.~
[x] The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
[x] Only one version is added to each modified port's versions file.

Duplicate of #40335.


use existing conversation as dataset ?

hi i have archived conversation/chat in file.txt like
me : ..
friend : ..
me : ..
me : ..
friend : ..
me : ..
friend : ..
friend : ..
me : ..
and so on..
can i use that as dataset ?
thanks

Yes, you can store this conversation in proper corpus format (.JSON or .YML) as you can see in site-packages/chatterbot_corpus/data/.
You can add your conversation in site-packages/chatterbot_corpus/data/custom/.
I prefer .YML, as it is more human readable, as compared to .JSON

Yes using existing export feature http://chatterbot.readthedocs.io/en/stable/corpus.html?highlight=export#exporting-your-chat-bot-s-database-as-a-training-corpus

its possible to have multiple statement in one section ?
as i see in documentation :
Satement
Response
Satement
Response
Satement
Response
etc ...
and here what would i do :
Satement
Response
Statement
Statement
Response
statement
statement
statement
Response

@guangrei It won't possible with current training algorithm. But i didn't understand your usecase, if possible can with some examples with your usecase?

for custom dataset, is it necessary to export our database as a training corpus. If not, can anyone recommend me how to train on a custom dataset. I have a .yml file in a folder. If I train based on the .yml file, it gives an error
AttributeError: 'list' object has no attribute 'get'

the case look like a multiple statement with one response e.g:
when statement match one of statement 1 or statement 2 or statement 3 then will get same response

@guangrei It currently isn't possible to have more than one statement as a response. I agree this might be useful, and I've had a number of requests for this functionality. I'll look into the possibility of adding this feature (https://github.com/gunthercox/chatterbot-corpus/issues/58).


Titles not appearing

I have Display Group Titles turned on, I run Symbol Organizer and the titles do not display and nothing is in alphabetical order. This seems to be the case since running the latest Sketch update.
Sketch v52

@hvargish, @barto457, seems there was a last minute change in the beta that broke any plugin that uses MSSharedStyle.alloc().initWithName_firstInstance(). I've got a fix for this, but there are other changes that I don't have a fix for yet. I will publish an update as soon as I can. In the meantime, you should still be able to use Symbol Organizer, just without titles.

A fix has been released for this issue, please update to 15.3. Thank you for your patience.


app bar height

Just a easy fix to switch app bar height on Android / iOS. Not sure if this is sufficient....

There be a problem. When android version is greater than 21, we can set component StatusBar is translucent.   When translucent is set to true, the app will draw under the status bar. This is useful when using a semi transparent status bar color. So should provide a api to control if  the nav bar height is 44 or 64.
you can see react-native #6876

Sorry it doesn't work (for iOS), i've reverted it

@jeroenbourgois You code have a bug, should be 'Platform.OS', not 'Platform.os' in NavBar.js line 205

@aksonov It doesn't work because it should be Platform.OS and not Platform.os. As it's undefined you get the Android's height in both platform.

Ok, you might submit correct PR and change version within package json
Pavel.

27 апр. 2016 г., в 09:50, Yann Pringault<EMAIL_ADDRESS>написал(а):
@aksonov It doesn't work because it should be Platform.OS and not Platform.os. As it's undefined you get the Android's height in both platform.
—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub

Ok I'm creating a PR with appropriate fixes also for the buttons and title position.

There is an issue with android api > 17...
Please FIX with:
title: {
    top: Platform.OS === 'ios' || Platform.Version > 19 ? 20 : 0,
  },
  header: {
    height: Platform.OS === 'ios' || Platform.Version > 19 ? 64 : 44,
  },
![without fix](https://cloud.githubusercontent.com/assets/5980398/14915850/381fed7c-0e16-11e6-8f70-b2e7f67ab802.png)
![with fix](https://cloud.githubusercontent.com/assets/5980398/14915851/3824e836-0e16-11e6-8424-b709a263f247.png)

#614

@sarovin can you please elaborate the Platform.version > 19 part? What about < 18, what does that mean?


Potential to see video with this through browser and only a light source from a monitor?

[Enter feedback here]
Am I wrong to assue this?  It seems like that is very possible.
<
Switch( FirstName.Text, "Carlos", Navigate( Screen1, ScreenTransition.None ), "Kirstin", Navigate( Screen2, ScreenTransition.None ), "John", Navigate( Screen3, ScreenTransition.None ) )
| The value of FirstName.Text is compared against "Carlos", "Kirstin", and "John" in that order. A match is found with "John", so the app navigates to Screen3. | trueThe display is changed to Screen 3.
Thoughts?

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 3aaf5120-def5-cc71-5f21-06dc13cba924
Version Independent ID: 3aaf5120-def5-cc71-5f21-06dc13cba924
Content: If and Switch functions in Power Apps - Power Platform
Content Source: power-platform/power-fx/reference/function-if.md
Service: power-platform
Sub-service: power-fx
GitHub Login: @gregli-msft
Microsoft Alias: gregli

Thanks for your comment, @2Mellyveee. This issue has been assigned to the doc author for review.


Backport 2.1: Support certificate signing with alternative RSA implementations

Summary: This is the backport of #1089 to Mbed TLS 2.1. The test changes in #1089 have been omitted.
Internal Reference: IOTSSL-1538

@andresag01 My understanding is that we do usually not backport tests and enhancements, so I deliberately omitted all of what you mentioned in the backports.

@hanno-arm: My understanding was that we backport tests unless there are good reasons not to. Also, I thought that some of the versions checks you added in the original PRs were more like bugs because for example, you cannot have a v1 cert with extensions, etc.

Waiting for @gilles-peskine-arm's review and opinion on the necessity of backports before potentially working on them.

@hanno-arm @andresag01 Regarding what to backport:

Style changes: yes, to ease merges of future backport, if we're confident that there's no risk of a semantic change in the executed code. E.g. whitespace changes are fine, but things that may realistically cause a compiler to emit different code should generally not be backported.
Test cases: if you're backporting a bug fix, always backport its non-regression tests.
Example programs and test infrastructure: we can be more liberal with those, we can backport features if they make our life more convenient, but we shouldn't expend effort on those if the backport wouldn't make our life more convenient. I don't consider the pedagogical value of backported example programs to be important: if you want to see how to use the library, look at the current version.

@andresag01 @gilles-peskine-arm Added remaining commits from father PR. Note that fc77144 and d8a6f7c have been subsumed under the first commit f581e11 of this PR. Please review.

ChangeLog still needs extension.

ChangeLog extended.

CI failed only due to timing tests (known issue), ok to merge