Generic Animation class

I have found myself copy-pasting the Animation class a few times to support NinePatches or certain types of Drawables. I think PolygonRegions would be another common need. I'm also playing around with multi-texturing for normal-mapped sprites, so an animation made up of TextureRegionPairs would be useful. So it makes sense for the frame type to be generic.
This is one way to do it that shouldn't affect existing code, unless someone is serializing Animations for some reason (although I doubt anyone is trying to serialize TextureRegions, nor does it make sense to serialize assets). I created a new Animation class in the utils package (since this theoretically could be used for more than just 2D animation frames, think decals or some sort of state manager). The existing Animation class extends from it and has a pass-through PlayMode class to prevent code breakage, and having to fully qualify PlayMode if the g2d.Animation class has been imported.
Here are some alternative ways to do this. Any opinions?

Do it like this PR, except that the existing g2d.Animation class is untouched. Zero chance of code breakage, but now we'd have two classes with a bunch of duplicate code.
Do it like this PR, but give the utils.Animation class a different name to avoid confusion. Maybe could also remove the g2d.Animation.PlayMode pass-through class, although that would force people to fix up some code by importing the new class.
Keep this PR as is, deprecate the old g2d.Animation class, with a Javadoc explaining the change, and remove it in a year or two. In the long term this may be the cleanest.
Rip off the Band-Aid by deleting the g2d.Animation class now.
Forget the new class. Just make g2d.Animation generic, and force people to update code to specify <TextureRegion>. This is a nice middle-ground. Code will be broken, but is easy to fix, and it avoids adding a new class.

Having two classes in libgdx with the same name isn't great, especially when they do the same things. I'd say #5, break it for the greater good.

Actually, it would have been the third Animation class!
I updated this to go with number 5. I'll monitor SO and the forums if this is pulled. :)

This will probably break the demos, so lets do it.

@Tom-Ski Do we fix demos after the next release or right away?

Now


feat(dataset): arg choosing OHLC data

Updated the ticker.history() to retrieve all ["Open", "High", "Low", "Close"] and an argument in the to_numpy() function to select the desired series.
Also updated fix_missing_data() to accommodate for the previously mentioned changes.
(And .gitignore to ignore vs code workspace settings)

Codecov Report
All modified lines are covered by tests :white_check_mark:

Files
Coverage Δ

finq/datasets/dataset.py
83.87% <100.00%> (+3.72%)
:arrow_up:

:loudspeaker: Thoughts on this report? Let us know!.

Gör en rebase mot main för att få in ändringar från #25 se om de blir några conflicts så löser vi dom

Now everything should be fixed 👍

Now everything should be fixed 👍

No, the stuff from main didn't come with.
Will fix later. Sry

np :) all incoming changes look good, just need to avoid some conflicts now :P

@wilhelmagren Now it should contain the latest changes from main! 😄


Travis

I added a simple travis support. Please update the user name and branch name in README.md after this merge.

Fixed in master in better way during tests refactoring & automation.


unknownHostExceptions + nonHTML pages handled

Issue 58 and 61

Coverage decreased (-0.03%) to 46.461% when pulling 966506f8d942e0c6daf0e9d41dd033fe2653fd90 on maqzi:issue58+issue61 into d25b53977c936af0c64be3da3042bbdec2d0459f on ViDA-NYU:master.

Coverage decreased (-0.04%) to 46.609% when pulling ee6a93fbd6a00fd8e0fe5152daaedcfa0958ba72 on maqzi:issue58+issue61 into d2f756afef5ec4d6bf330eb634b3ae61255e1b22 on ViDA-NYU:master.

Coverage decreased (-0.05%) to 46.599% when pulling 5c86547327411bfa9d33722246204031ece001a7 on maqzi:issue58+issue61 into d2f756afef5ec4d6bf330eb634b3ae61255e1b22 on ViDA-NYU:master.

I've made the changes mentioned in the inline comments


Output question

Do all notes of the output actually have the same length..or do i do anything wrong? =/ just notice this..i didnt see it before =,O

Indeed, to simplify the problem, I choose to have a constant note duration.

oh =,O


Warning for Font

I got a warning for font ".SFUI-Regular" suppose to be only in iOS13 or above
CoreText note: Client requested name ".SFUI-Regular", it will get TimesNewRomanPSMT rather than the intended font. All system UI font access should be through proper APIs such as CTFontCreateUIFontForLanguage() or +[UIFont systemFontOfSize:].
CoreText note: Set a breakpoint on CTFontLogSystemFontNameRequest to debug.

After Debug, I found that it is at the line number 87 of RotationDialPlate.swift file.
And to solve this, I guess you have to change the font like shared here or can use enum like this answer

Thanks for the report!
I found the issue is at the line 88 of RotationDialPlate.swift file.
After I changed it to
let cgFont = CTFontCreateUIFontForLanguage(.label, numberFont.pointSize/2, nil)
the warnings were gone.
I will fix it in the next release.

The warning is removed in the new release Mantis 1.0.0


Form for student "worksheet" for selecting flowers

This would be used before/after playing Buzz About as a worksheet where students can recommend flowers to the "scientists" for the prairie. We would like them to be provided with information about each flower and be able to select a set of flowers to recommend as well as providing a text box for their reasoning or ideas.

We are probably not going to implement this in favor of a paper worksheet for the moment.


[CosmosDB] Cannot create cosmos db document item correctly with PartitionKey parameter

[Enter feedback here]
The sample cannot run successfully with the latest .net library Microsoft.Azure.Cosmos 3.20.1.
ToDoActivity test = new ToDoActivity()
	{
		id = Guid.NewGuid().ToString(),
		status = "InProgress"
	};
	var item = await container.CreateItemAsync<ToDoActivity>(test, new PartitionKey(test.status));

The exception message is "Response status code does not indicate success: BadRequest (400); Substatus: 1001; ActivityId: ; Reason: ();"
The diagnostics is as follows:

If I add the partitionKey field into the ToDoActivity and remove the PartitionKey argument from the CreateItemAsync call, the call can succeed.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: daeba9b9-e030-811f-7864-f498d9ec9f08
Version Independent ID: e8b56ad8-9021-3028-bc10-c8a8c7779b0f
Content: Container.CreateItemAsync<T>(T, Nullable<PartitionKey>, ItemRequestOptions, CancellationToken) Method (Microsoft.Azure.Cosmos) - Azure for .NET Developers
Content Source: xml/Microsoft.Azure.Cosmos/Container.xml
Service: cosmos-db
GitHub Login: @rloutlaw
Microsoft Alias: routlaw

@Jich2018 what is the partition key path that you defined on the container?
What tool did you use to visualize the json?

The sample assumes you created the collection with /status as the Partition Key Definition. The error you are getting means the partition key you are passing is incorrect and does not match the container/collection definition.

@Jich2018 what is the partition key path that you defined on the container?
What tool did you use to visualize the json?

I created a field name /PartitionKey and use it as the partition key. The json in the screenshot is shown using Linqpad.

The sample assumes you created the collection with /status as the Partition Key Definition. The error you are getting means the partition key you are passing is incorrect and does not match the container/collection definition.

I created a container with /PartitionKey as the partition key. The problem here is, the incoming document doesn't contain this /PartitionKey. when saving the document to the cosmos db, I want to provide a partition key for it. e.g.
{"id": "123", "status": "ready", "group": "Product", "revision": "231"} is the incoming request. I want to save this document into the cosmos DB and make the /PartitionKey group+revision. I think the additional parameter PartitionKey in the method CreateItemAsync could help on that, but it seems not?  if that is the case, how can I achieve that?

The partition key must be in the document. The partition key is used to figure out which physical machine in Cosmos DB should store the item. The parameter avoids the SDK from needing to extract it from the object which adds overhead. Make sure the partition key value is known so you can do ReadItemAsync. If you end up using query to find the item by id it will not scale because every partition in cosmos db will have to be searched for it.
I think there are two options.

The easier solution is to use a wrapper to add the partition key value. You could use something like JObject.
Use the stream APIs CreateItemsStreamAsync. You could have a custom JSON Converter which adds the additional field. The stream APIs are optimized for performance so they do not throw exceptions.

This is covered in the docs: https://docs.microsoft.com/en-us/azure/cosmos-db/troubleshoot-bad-request#wrong-partition-key-value
As Jake said, the partition key value needs to be in the document's body, you need to add the property and make the concatenation of group+revision before calling CreateItemAsync. And that same value is what you pass in the partition key parameter too.

Thanks @ealsur and @j82w for confirmation on this. I will continue with your suggestion and close this.


build fails on AArch64, Fedora 33

[jw@cn05 dr-elephant]$ ./compile.sh
...
EFFECTS: allpass band bandpass bandreject bass bend biquad chorus channels compand contrast dcshift deemph delay dither divide+ downsample earwax echo echos equalizer fade fir firfit+ flanger gain highpass hilbert input# ladspa loudness lowpass mcompand noiseprof noisered norm oops output# overdrive pad phaser pitch rate remix repeat reverb reverse riaa silence sinc spectrogram speed splice stat stats stretch swap synth tempo treble tremolo trim upsample vad vol

Deprecated effect    + Experimental effect    # LibSoX-only effect
EFFECT OPTIONS (effopts): effect dependent; see --help-effect

cd target/universal

cd target/universal
./compile.sh: line 437: cd: target/universal: No such file or directory
[jw@cn05 dr-elephant]$

directory target/universal doesn't exist. The cd command is used to change the current working directory to target/universal, but since that directory doesn't exist, the command fails.
It's possible that there was an error during the build process that prevented the target directory from being created or populated. You can try running ./sbt clean update compile to perform a clean build of the project and see if that resolves the issue.
Alternatively, you can check the build log for any errors that may have occurred during the build process and address them accordingly.


Make it clear that you cannot filter the list of tests that get displayed

In my pipeline I was trying to output a clean list of all the tests that would get run, before actually running them.
When I do run tests, I use a filter, so I was also trying to use the same filter when listing tests.
I spent over an hour trying to understand why the filter I was specifying was not working.
In the end it ended up being because a specified filter has no effect when listing tests; only when running tests.

I've updated the documentation to make this clear.  It would be nice if VSTest was also updated at some point in the future to actually support filtering when listing.

@Mikejo5000

Can you review this PR?
IMPORTANT: When this content is ready to merge, you must add #sign-off in a comment or the approval may get overlooked.

#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

@Evangelink Does anyone on the team need to review this PR? It looks OK to me.

I would rather update the /TestCaseFilter entry to mention it's not working with list tests but that's a personal feeling so I am not blocking here.

#sign-off OK, thanks. It can be updated again later.

@Evangelink Related to test case filtering...
Would anyone on your team be able to answer this by any chance?  I'm really hoping there's a way to accomplish this, but it doesn't seem like there is.  If there isn't it would be nice if this functionality could be added in a future release.
https://stackoverflow.com/questions/78144390/how-to-run-all-unit-tests-that-dont-have-a-trait

Sure thing, it will depends on the test framework you are using so I'll let you have a look at this doc page https://learn.microsoft.com/dotnet/core/testing/selective-unit-tests

Thanks for the link @Evangelink.  I took a look, but all the operators that are called out there don't seem to handle the following scenario.  Imagine you have two categories of tests:

Regular Unit Tests

These don't have an assigned category (because there's nothing special about them).

Slow Tests

These do have an assigned category: ([TestCategory("Slow")])

For a PR build, you now want to run all Unit Tests that don't have an assigned category.  These don't work:
/TestCaseFilter:"TestCategory="
/TestCaseFilter:"TestCategory=''"
I know you can do this instead: /TestCaseFilter:"TestCategory!=Slow"
But imagine that in addition to there being "Slow", there's also 10 other categories that need to be excluded as well.  And when new categories get added in the future, you don't want to have to keep updating your filter.
Is there no way to simply select all tests that haven't been assigned a category?

Sadly it's not possible and it's a limitation of VSTest. I'll try to find the ticket mentioning exactly this issue and link it here


SAK-29519 - Add cloud-based file system handlers

Included are two implementations of FileSystemHandler for storage of content resources in cloud services, using the jclouds libraries: one for OpenStack Swift using its explicit API and one using the generalized BlobStore API (primarily aimed at AWS S3). The README includes much more detail.
The initial Swift implementation came from OpenCollab ZA (https://github.com/OpenCollabZA/sakai-openstack-swift) and I repackaged it, made some upgrades, and built out the BlobStore handler. I also made a subtree merge to pull this into the Sakai source tree for this pull request.
Note that licensing information must be added before this can be merged.

@ncaidin neal is this good to go?

@botimer are we good to merge now that licensing is resolved?
Anyone else have comments here?

What do other people think about having it in /content/swift-storage rather than another top level folder?

I don't think the toplevel POM was updated to include this in the new build so Travis didn't actually build the new code. I'm also not sure that the tests will pass as they reference a specific endpoint although I haven't tried.

The thing about the tests is that they require a profile to run. This is not Ideal, but the tests do run against a real service, so they need some config, as you say.
I guess the best approach would be to have a mock swift service, but I have not thought about that too much. I don't really see it as a blocker compared with the rest of the suite, but how do others feel?

I don't see the test as a blocker to getting it merged.

I think everything above is addressed now and the latest commit (pushed twice to catch an omission) adds the module to the top level pom/profiles.

As far as moving this to a submodule of content, I don't really have an objection. I kept it at the top level because it is relatively standalone and there is, for example, content-review there as well. Either way is fine with me in the long run.

Build failure looks to be related to the patch.

Whoops. I confused the storage conversion (which requires a profile activation) with the tests (which do not). You were correct originally -- the tests currently depend on a running Swift instance. I will have to think about the best path forward tonight.

I've added a new commit that addresses the tests. I have run them locally and they are passing again. Travis should not run them as they now require a profile activation. See 453c281 for the details.

Thanks @botimer.  I will merge this tomorrow unless there are any objections.

The licensing information is good to go. Sorry I did not see this earlier. Need to check email filters.

Is this good to go? @ottenhoff

Quick question why does commit fe3f479 "Create new repo" check in a bunch of diffs? Would be better you could just squash this as having commits like this is not ideal.

This was the one commit from Samuel. It was prospective at the time, so no JIRA issue mentioned. I thought it better to preserve the OC ZA contribution than squash it away for commit purity.
That was my thinking, anyway. YMMV and wisdom of the crowd should prevail.
Thanks,
-Noah

On Jul 30, 2015, at 9:34 AM, Earle Nietzel<EMAIL_ADDRESS>wrote:
Quick question why does commit fe3f479 "Create new repo" check in a bunch of diffs? Would be better you could just squash this as having commits like this is not ideal.
—
Reply to this email directly or view it on GitHub.


thank you but....

hi,
first of all thank you for this amazing work
i'm using xcode 9.1.4 and swift 4
can you direct me to the good release that we work with me  👍

Sure, 0.7.2 should do for you. :-)

Closing the issue now.


Add test case test_033

Thanks for taking the time to contribute to clickhouse-operator!
Please, read carefully instructions on how to make a Pull Request.
This will help a lot for maintainers to adopt your Pull Request.
Important items to consider before making a Pull Request
Please check items PR complies to:

[ ] All commits in the PR are squashed. More info
[ ] The PR is made into dedicated next-release branch, not into master branch1. More info
[ ] The PR is signed. More info

--
1 If you feel your PR does not affect any Go-code or any testable functionality (for example, PR contains docs only or supplementary materials), PR can be made into master branch, but it has to be confirmed by project's maintainer.

Note 0.19.0 is already released

Ok, I will create the future PRs in the lastest branch 0.20.0


[Improvement] When no schema exist Gravitino CLI command outputs nothing.

What would you like to be improved?
Using the playground and runing this gcli schema list --metalake metalake_demo --name catalog_iceberg -i gives no output.
How should we improve?
While this is correct, it could be confusing to the user perhaps output "No schemas exist."? We should always have a metalake so I don't think it is needed there, and tables should have columns, so again not needed there, (same with filesets and topics), but it would also be possible for a schema to have no tables.

I would like to work on it.


NodeStageVolume fails if xfs_repairs returns error after cluster reboot

Describe the bug
When there are "valuable metadata changes in a log which needs to be replayed" pod creation fails. (See log)
The reason this is a bug and not a feature for me is that this happens after a sudden cluster reboot.
Environment details
Kubernetes Version:
serverVersion:
  buildDate: "2019-10-15T19:09:08Z"
  compiler: gc
  gitCommit: c97fe5036ef3df2967d086711e6c0c405941e14b
  gitTreeState: clean
  gitVersion: v1.16.2
  goVersion: go1.12.10
  major: "1"
  minor: "16"
  platform: linux/amd64

Image/version of Ceph CSI driver
quay.io/cephcsi/cephcsi:v2.0.0
Deployed using rook.io
Logs
I0313 23:56:07.116518   19237 utils.go:157] ID: 4 Req-ID: 0001-0009-rook-ceph-0000000000000001-5c35924f-63c7-11ea-ab23-f2b4435d7b71 GRPC call: /csi.v1.Node/NodeStageVolume
I0313 23:56:07.116553   19237 utils.go:158] ID: 4 Req-ID: 0001-0009-rook-ceph-0000000000000001-5c35924f-63c7-11ea-ab23-f2b4435d7b71 GRPC request: {"secrets":"***stripped***","staging_target_path":"/var/lib/kubelet/plugins/kubernetes.io/csi/pv/pvc-b3f222c4-1c92-4365-a58f-3f8d354e7703/globalmount","volume_capability":{"AccessType":{"Mount":{"fs_type":"xfs"}},"access_mode":{"mode":1}},"volume_context":{"apiVersion":"ceph.rook.io/v1","clusterID":"rook-ceph","imageFormat":"2","pool":"replicapool","storage.kubernetes.io/csiProvisionerIdentity":"1583893252987-8081-rook-ceph.rbd.csi.ceph.com"},"volume_id":"0001-0009-rook-ceph-0000000000000001-5c35924f-63c7-11ea-ab23-f2b4435d7b71"}
I0313 23:56:07.119265   19237 rbd_util.go:487] ID: 4 Req-ID: 0001-0009-rook-ceph-0000000000000001-5c35924f-63c7-11ea-ab23-f2b4435d7b71 setting disableInUseChecks on rbd volume to: false
I0313 23:56:07.197517   19237 rbd_util.go:150] ID: 4 Req-ID: 0001-0009-rook-ceph-0000000000000001-5c35924f-63c7-11ea-ab23-f2b4435d7b71 rbd: status csi-vol-5c35924f-63c7-11ea-ab23-f2b4435d7b71 using mon <IP_ADDRESS>:6789,<IP_ADDRESS>:6789,<IP_ADDRESS>:6789, pool replicapool
W0313 23:56:07.379853   19237 rbd_util.go:172] ID: 4 Req-ID: 0001-0009-rook-ceph-0000000000000001-5c35924f-63c7-11ea-ab23-f2b4435d7b71 rbd: no watchers on csi-vol-5c35924f-63c7-11ea-ab23-f2b4435d7b71
I0313 23:56:07.379993   19237 rbd_attach.go:208] ID: 4 Req-ID: 0001-0009-rook-ceph-0000000000000001-5c35924f-63c7-11ea-ab23-f2b4435d7b71 rbd: map mon <IP_ADDRESS>:6789,<IP_ADDRESS>:6789,<IP_ADDRESS>:6789   I0313 23:56:07.543358   19237 nodeserver.go:139] ID: 4 Req-ID: 0001-0009-rook-ceph-0000000000000001-5c35924f-63c7-11ea-ab23-f2b4435d7b71 rbd image: 0001-0009-rook-ceph-0000000000000001-5c35924f-63c7-11ea-ab23-f2b4435d7b71/replicapool was successfully mapped at /dev/rbd0
I0313 23:56:07.543654   19237 mount_linux.go:390] Attempting to determine if disk "/dev/rbd0" is formatted using blkid with args: ([-p -s TYPE -s PTTYPE -o export /dev/rbd0])
I0313 23:56:07.629332   19237 mount_linux.go:393] Output: "DEVNAME=/dev/rbd0\nTYPE=xfs\n", err: <nil>
I0313 23:56:07.629525   19237 mount_linux.go:390] Attempting to determine if disk "/dev/rbd0" is formatted using blkid with args: ([-p -s TYPE -s PTTYPE -o export /dev/rbd0])
I0313 23:56:07.704376   19237 mount_linux.go:393] Output: "DEVNAME=/dev/rbd0\nTYPE=xfs\n", err: <nil>
I0313 23:56:07.704482   19237 mount_linux.go:282] Checking for issues with xfs_repair on disk: /dev/rbd0
W0313 23:56:08.081928   19237 mount_linux.go:294] Filesystem corruption was detected for /dev/rbd0, running xfs_repair to repair
E0313 23:56:08.411413   19237 nodeserver.go:344] ID: 4 Req-ID: 0001-0009-rook-ceph-0000000000000001-5c35924f-63c7-11ea-ab23-f2b4435d7b71 failed to mount device path (/dev/rbd0) to staging path (/var/lib/kubelet/plugins/kubernetes.io/csi/pv/pvc-b3f222c4-1c92-4365-a58f-3f8d354e7703/globalmount/0001-0009-rook-ceph-0000000000000001-5c35924f-63c7-11ea-ab23-f2b4435d7b71) for volume (0001-0009-rook-ceph-0000000000000001-5c35924f-63c7-11ea-ab23-f2b4435d7b71) error 'xfs_repair' found errors on device /dev/rbd0 but could not correct them: Phase 1 - find and verify superblock...
Phase 2 - using internal log
        - zero log...
ERROR: The filesystem has valuable metadata changes in a log which needs to
be replayed.  Mount the filesystem to replay the log, and unmount it before
re-running xfs_repair.  If you are unable to mount the filesystem, then use
the -L option to destroy the log and attempt a repair.
Note that destroying the log may cause corruption -- please attempt a mount
of the filesystem before doing this.

Steps to reproduce
Steps to reproduce the behavior:
For me this happens every time I have a simple pod connected to a ceph block PV which uses the xfs file system. After a reboot, the pod can not be recreated.
Actual results
The csi driver tries to run xfs_repair but reports an error stating that the volume has to be mounted first.
Expected behavior
In my case simply mounting the device (manually) resolved the problem. So I guess there should be a chance to fix this issue automatically by temporarily mounting the volume?
Additional context
Related issues:

https://github.com/rook/rook/issues/4914

Can confirm this issue. Simple "rbd map" and a "mount -t xfs .." and unmap/unmount afterwards seems to replay the log and fixes the issue.
Currently I'm not really sure after what action (pod recreation etc.) this error occurs.

I believe this is not an error in the csi code. The xfs_repair command is executed here https://github.com/kubernetes/utils/blob/d1ab8797c55812f4fefe2c7b00a0d04a4740a93c/mount/mount_linux.go#L416.

https://github.com/kubernetes/utils/issues/141

Well, since the assumed order is repair first, mount after, which in the case of XFS does not work well, it is also an issue in the CSI code.
I had the same problems, and it is a pain to manually mount the volume on a host node, using rbd map when running kubernetes.
Because of this reason, we have decided to stay with the default ext4 for new volumes.

@whymatter can you try with cephcsi:v2.1.0 and let us know of that resolves the issue for  you?

I will give it a try

fixed in v2.1.0, if not please feel free to reopen it


Task 'Terraform Installer' version 2 (TerraformInstaller@2) is dependent on a Node version (10) that is end-of-life

Describe the bug
While running tasks (both installer and CLI) in ADO pipeline, we got node related warning:
##[warning]Task 'Terraform Installer' version 2 (TerraformInstaller@2) is dependent on a Node version (10) that is end-of-life. Contact the extension owner for an updated version of the task. Task maintainers should review Node upgrade guidance: https://aka.ms/node-runner-guidance
##[warning]Task 'Terraform CLI' version 2 (TerraformCLI@2) is dependent on a Node version (10) that is end-of-life. Contact the extension owner for an updated version of the task. Task maintainers should review Node upgrade guidance: https://aka.ms/node-runner-guidance

same bahavior is applicable when using TerraformCLI@1 and TerraformInstaller@1
To Reproduce
Steps to reproduce the behavior:

Run TerraformInstaller@2 or TerraformCLI@2 tasks in ADO pipeline

Expected behavior
there should not be any Node warning
Agent Configuration

OS: linux/windows
linux selfhosted, Microsoft Windows Server 2022 azure hosted

Duplicate of #447


Fix a typo on a has_key

After fixing this typo, a Gem I'm working on passes all its tests on JRuby.
I'm impressed that someone got the code inside the if to work, without that code being reachable!


Graph can fail to render due to a divide by zero error during rendering

2021-08-21 15:32:12 [Client] WARN  n.r.c.ui.overlay.OverlayRenderer - Error during overlay rendering
java.lang.ArithmeticException: / by zero
	at com.pinggraph.PingGraphOverlay$1.render(PingGraphOverlay.java:129)
	at net.runelite.client.ui.overlay.components.PanelComponent.render(PanelComponent.java:131)
	at com.pinggraph.PingGraphOverlay.render(PingGraphOverlay.java:179)

(extra unneeded frames omitted for brevity)
It seemingly is to do with the calculation of (maxPing - minPing) + 1

Should be fixed with the latest update


zoom to extent of layers

when user adds powo range map, the leaflet map should zoom to extent of the range map. Currently working for points using fitBounds, but can't seem to get bounding box working.

solved in #74


LoRA Training Script for Model Based on finetune_onevision

I want to train a custom model using LoRA based on the model trained with the finetune_onevision script.

Is there a separate LoRA training script available for this purpose?
If not, is there any guidance on how to modify the finetune_onevision script for LoRA training (including train param tips)?

Thank you!

I think it is not difficult to add loraConfig, by the way did you get the finetuning script work with its data.yaml file?https://github.com/LLaVA-VL/LLaVA-NeXT/issues/182#issuecomment-2311573430

@YerongLi
A recent commit seems to have put a yaml file in the script folder

I found it as well. Thanks. I find     --lora_enable True \ will enable Lora, they have a lora branch in train.py

I find even with lora, the training script run into OOM with 48 GB memory.
--lora_r =4, --max_length=128

I find even with lora, the training script run into OOM with 48 GB memory. --lora_r =4, --max_length=128
trainable params: 10,811,392 || all params: 8,041,160,224 || trainable%: 0.1344506476532061

Is SWIFT not supporting LLAVA-OV LORA fine-tuning?

I find even with lora, the training script run into OOM with 48 GB memory. --lora_r =4, --max_length=128
trainable params: 10,811,392 || all params: 8,041,160,224 || trainable%: 0.1344506476532061

Is SWIFT not supporting LLAVA-OV LORA fine-tuning?

Their original code only used the PEFT for Lora sft. Let me try SWIFT. This is very new to me..

@YerongLi这是通过自定义数据集完成的吗？如果是，您是如何配置它的？

你指的是哪一步？我使用了他们的训练流程使用的子集，https://huggingface.co/datasets/lmms-lab/LLaVA-OneVision-Data

trainable params: 10,811,392 || all params: 8,041,160,224 || trainable%: 0.1344506476532061

我不明白的一件事是，有了 1B 可训练参数，甚至 300 万个可训练参数，为什么我仍然会遇到 OOM 错误。

I'm still clueless about how to fine-tune LLaVA-onevision. Could you share a training script with me? thanks.

I find even with lora, the training script run into OOM with 48 GB memory. --lora_r =4, --max_length=128
trainable params: 10,811,392 || all params: 8,041,160,224 || trainable%: 0.1344506476532061

I used --deepspeed scripts/zero3_offload.json with LoRA tuning (--lora_r 128 --lora_alpha 256). The OOM issue is resolved, and training can proceed, but there is an error when saving the final model. I am still working on it. BTW, I train with a single A100_40G GPU.

I find even with lora, the training script run into OOM with 48 GB memory. --lora_r =4, --max_length=128
trainable params: 10,811,392 || all params: 8,041,160,224 || trainable%: 0.1344506476532061

I used --deepspeed scripts/zero3_offload.json with LoRA tuning (--lora_r 128 --lora_alpha 256). The OOM issue is resolved, and training can proceed, but there is an error when saving the final model. I am still working on it. BTW, I train with a single A100_40G GPU.

Do we really have to use the zero3_offload.json, this must be very slow. One thing strange to me is that here our total number of trainables are 1B, I even managed to reduce the number of the trainables to 300M and OOM persists.

I think this is because LLaVA-OV uses too many image tokens (729 * 10).


Add docs section on HPC installation

Getting the ball rolling on the docs section covering the TACS installation process on common HPC systems. Feel free to change the content I added or where in the docs it goes.

Thanks @A-CGray, this looks like a good strat. Do we want to add a section for PACE @sean-engelstad @SeiyonArulampalam ?


ERROR: Download error code: 3 Live reload ionic 2

ERROR: Download error code: 3 Live reload ionic 2
I cant get this to work with live reload.

@michaeljcoyne this doesn't work with livereload since you cannot access the file:/// protocol while in livereload. Images get loaded via regular HTTP loading when you're in livereload.
You shouldn't be having any issues, but I will look into this. Could you please provide me with steps to reproduce this?
I will modify the module soon so that it returns Base64 images in livereload (like what happens in WKWebView).

Ok well a fallback would be good. Or a demonstration how to use it if there is one for dynamic images. Also I cant get the preload to work when I loop through images in my app component.

The latest version 3.1.0 will let you develop on livereload. Just set the return type to base64 using the new setReturnType configuration method.


[1.12.2] Compat with Betweenlands shared loot tables

Heya,
in the Betweenlands, dungeons use a shared loot table, to ensure that certain loot is guaranteed inside a dungeon, by generating the loot and then spreading it across the available chests inside the structure.
https://github.com/Angry-Pixel/The-Betweenlands/blob/1.12-fixes/src/main/java/thebetweenlands/common/world/storage/SharedLootPoolStorage.java
With Lootr installed, opening such a chest would re-roll the entire loot table for that chest.
I know this is a very special case, but i was wondering if there could be some sort of compat for this.
Potentially have a setting for the Lootr chest to copy what loot is currently in the chest it's replacing (even better if it's filtered by loot table ids, so it doesn't apply to every chest, but even that'd be fine), and then giving that same loot to any player opening the Lootr chest? It wouldn't randomize between players, but i think that's fine.
Was going to attempt that with an addon, but have not quite gotten that to work, so figured i'll ask here as well.
Cheers,
SC

I don't really know how the 1.12 works, but I assume that it's very similar to 1.16 and later. Lootr does have a similar capacity but I'm not sure how it would work in this case, as, with the chests already being converted, it has no access to the original tile entity in order to use that fillWithLoot variant.
Honestly, compatibility would be quite difficult...

Yeah i think you are right, i've looked into this quite a bit now, and i don't think it's gonna way too big of a task.
I'll close the ticket for now :)

The simplest option I can think of would be to use the most recent Lootr API -- but I'm not sure how that would work in 1.12.2. Then you could provide your own loot table fill method.


Consume Carbon Motion package in website

Currently, we are using the old motion variables $transition--base and $carbon--standard-easing for motion across the site.
We should work on consuming the motion package from carbon-elements and standardizing motion across the website.
As is:

To be:

@shixiedesign FYI

👍 Might make sense to make this change in the gatsby-theme, instead of duplicating in the website repo also.

Agreed, just want to make sure this is somewhere on the roadmap 👍

rad! there are a few places off the top of my head that don't currently seem to animate that could have a transition applied to them:

page tabs hover (i don't think the transition is working currently)
homepage clickable tile hover
side nav hover
button hover state (to be propagated to all button instances)

NoT sTaLe


Neural Turing Machines

Neural Turing Machine with RNN controller (I believe we are the first to open source such thing) can be used as any other RNN model.
This model can be used as plug and play, but those interested in attention related stuff should checkout the code. There are probably ways to make this code more clean and efficient. Suggestions are welcome.
 Or maybe a paper to point to for us to read?

@LeavesBreathe start with the paper http://arxiv.org/pdf/1410.5401v2.pdf here we reproduce their first experiemnt

Thank you! will go through this!

I think performance was not a consideration for your initial work here, but just so you know: you can get 4 times faster code by getting all the gates by multiplying the concatenation of input and previous state with one huge weight matrix and splitting them.

@pranv yup! I didn't want to do that right away. I thought about it but that makes the code harder to read and modify sometimes. But 4x is a lot!!! do you want to update the code here: https://github.com/EderSantana/keras/tree/ntm ???

@EderSantana This is neat! I love the level of abstraction..just plug and play!

Thanks @farizrahman4u

Will review in a bit, been busy recently.

Looks good to me. Very cool use of Keras!

@fchollet thanks for the reviews, I cleaned up the code. Let me run some tests to have an idea of how long this model takes to compile and train, so I can update the experiment docs. It takes quite long to compile (something like 20 min). And @pranv said he sped up the code 4x, I wish he could give some details about what he did.

Cool, thanks! I'd be curious about the 4x speedup as well.

The code looks neat. Will have to go through this in detail during the weekend.
In the meantime I'd like to ask whetver You managed to replicate some of the original paper's results? If I remember correctly they were using multiple heads in each of their experiments, so it could be tricky with the current implementation?

Looks good to me! Great code.

@elanmart The multiple heads are really necessary for MLP controllers, here we have RNN controllers (and I believe we are the first to open an NTM with RNN controller). The code I added to experiments folder reproduces the paper first experiment: Copy problem.
But RNNs with memory is the topic of my PhD research, so I'll probably update this implementation to be faster, more efficient and have multiple heads. I'm also investigating other types of memory architectures.  My first impression is NTM don't have all the answers, they usually improve on other RNNs as plug and play, but you have to use the memory wisely since it is brings a lot of extra calculations...
The main things are, in Keras' docs we promised a NTM implementation and it is good to have a reference model for those who want to know how to use attention operations in their own models.

@fchollet @EderSantana I guess the (4x) speedup @pranv mentioned is similar to the one used in Lasagne: https://github.com/Lasagne/Lasagne/blob/master/lasagne/layers/recurrent.py#L952-L956


Support DNS over TCP

Currently, connlib simply drops TCP packets to sentinel DNS servers. This causes problems because for some large DNS queries, the TCP fallback is needed to reliably transport the response.
Most DNS clients have such a fallback implemented: If the DNS query fails over UDP, they try TCP. Us not supporting TCP causes problems such as #6134.
### Pre-work
- [ ] https://github.com/firezone/firezone/pull/6997
- [ ] https://github.com/firezone/firezone/pull/6999
- [ ] https://github.com/firezone/firezone/pull/7007
- [ ] https://github.com/firezone/firezone/pull/7018
- [ ] https://github.com/firezone/firezone/pull/7020
- [ ] https://github.com/firezone/firezone/pull/7022
- [ ] https://github.com/firezone/firezone/pull/7023
- [ ] https://github.com/firezone/firezone/pull/7025
- [ ] https://github.com/firezone/firezone/pull/7044
- [ ] https://github.com/firezone/firezone/pull/7041
- [ ] https://github.com/firezone/firezone/pull/7043
- [ ] https://github.com/firezone/firezone/pull/7062
- [ ] https://github.com/firezone/firezone/pull/7065
- [ ] https://github.com/firezone/firezone/pull/7066
- [ ] https://github.com/firezone/firezone/pull/7067

### Defintion of done
- [ ] https://github.com/firezone/firezone/pull/6944
- [x] Changelog entries
- [x] Docs PR?
- [x] Test on real MacOS device
- [ ] Test on real Android
- [x] Test on Linux machine
- [ ] Test on Windows

Possible cause of https://firezonehq.slack.com/archives/C077VKJGQ3W/p1726613711222829

Looks into FushicaOS - has a TCP implementation.

Link to Discord conversation with Fuchsia maintainers: https://discord.com/channels/835268677472485376/883122373484752936/1285741516387782728

netstack3 crate: https://cs.opensource.google/fuchsia/fuchsia/+/main:src/connectivity/network/netstack3/core/;l=1?q=Netstack3%2Fcore&ss=fuchsia%2Ffuchsia
The main hurdle is that Fuchisa doesn't use cargo for its build system, meaning the code cannot be directly added as a cargo dependency.
The follow patch-set includes a Python script which may be able to generate a valid Cargo.toml for the netstack3 crates: https://fuchsia-review.googlesource.com/c/fuchsia/+/995502
We should try the above script and see if it works for netstack3
If not, we may have to write one by hand.
If we use this code, we should work out a way of automating that so we can easily keep up with upstream.

We should also look at https://docs.rs/smoltcp, it may require some layers of indirection but likely still better than writing our own and maybe less hassle than using the Fuchsia stuff.

Possibly cause of #6768 but needs to be verified.

#6944 implements DNS over TCP. Do we need to update any docs for this?

Hmm I don't think so since it's not a user-facing change. Probably just the Changelog.

@ReactorScram Could you do me a favor an test the linked PR on Windows? Things to watch out for:

Regular DNS resolution works with and without Internet resource for resources and non-resources
DNS resolution of via a commandline tool for 2048.size.dns.netmeister.org works (the response is too big for UDP so it should fall back to TCP and succeed)

Tests on MacOS and Android are positive!

Looks good to me. I tested the CI build from your PR and the netmeister address works. Then I tested with 1.3.8 (current release) and it failed as expected.
The only thing that bugs me a little about Internet Resources is, since they don't get our 100.96.x.y IPs, I can't tell if a non-Resource is actually going through the tunnel.
Tested the x86_64 Windows MSI from this page https://github.com/firezone/firezone/actions/runs/11247920713#artifacts
Version 1.3.9 (f751a5b)

Internet Resource is disabled
Regular DNS works for a Resource (curl -s -4 https://ifconfig.net returns the Gateway IP)
Regular DNS works for a non-Resource (https://www.wikipedia.org/ loads in Firefox, nslookup returns <IP_ADDRESS>)
nslookup 2048.size.dns.netmeister.org hits our sentinel resolver and returns roughly 80 addresses
Enabling Internet Resource
Regular DNS works for a Resource (curl -s -4 https://ifconfig.net returns the Gateway IP)
Regular DNS works for a non-Resource (Unclear - wikipedia.org loads in Firefox and resolves in nslookup, but it's still <IP_ADDRESS>. That's because we're routing <IP_ADDRESS>, right? So we don't need to assign our own IPs to non-Resources?)
nslookup 2048.size.dns.netmeister.org hits our sentinel resolver and returns roughly 80 addresses

Running the same tests with Version 1.3.8 (650e31c)

Internet Resource is enabled
Regular DNS works for a Resource (curl -s -4 https://ifconfig.net returns the Gateway IP)
Regular DNS works for a non-Resource (Wikipedia loads in Firefox and resolves in nslookup)
nslookup 2048.size.dns.netmeister.org fails with Unspecified error (expected, since this is on 1.3.8)
Disabling Internet Resource
Regular DNS works for a Resource (curl -s -4 https://ifconfig.net returns the Gateway IP)
Regular DNS works for a non-Resource (https://www.wikipedia.org/ loads in Firefox, nslookup returns <IP_ADDRESS>)
nslookup 2048.size.dns.netmeister.org fails with Unspecified error (expected, since this is on 1.3.8)

Thank you for the comprehensive testing!

Ah, I forgot that trick. Re-tested just now and DuckDuckGo with ip addr does show the Gateway IP. Good

@ReactorScram Could you do another quick test for me using the latest version of the branch on a Windows device? 🙏

It passed.


Sound

Sound is gone.
Something to do with RetroPCM?

yeah im not sure what causes this
im going to get onto this ASAP, thanks for telling me

Happy to announce that with the help of Buj, we have resolved this issue
expect it to be fixed upon the release of the next build :D

Very Good.


Pods with periods fix. Fixes issue #41

I went with the explicit route conventions as suggested by @floere and modified the testing setup to allow for multiple pods with different names to be tested easily. Let me know what you think, feedback is definitely welcome. Disclaimer: I'm relatively new to Ruby so please let me know if I violated any style conventions you want maintained.

@okhwaja Thanks a lot for your great work! :+1: It is live now :rocket:


Error on adding product to cart

On clicking the "Add to Cart" button the following error is shown:
Error ! SQLSTATE[42S22]: Column not found: 1054 Unknown column 'custom_price' in 'field list' (SQL: update cart set custom_price = ?, cart.updated_at = 2020-03-12 19:53:56 where id = 3).
The product is still added to the cart.
1. framework Version: 1.0.0

I found that the error is due to a listener within the "Marketplace" module which is not compatible with version 1.0.0 of Bagisto.
Event::dispatch('checkout.cart.add.after', $cart);
I had to comment the sections that added the "custom_price" field:
`/**
* Product added to the cart
*
* @param mixed $cartItem
*/
public function cartItemAddAfter($cartItem)
{
if (isset($cartItem->additional['seller_info']) && !$cartItem->additional['seller_info']['is_owner']) {
$product = $this->productRepository->find($cartItem->additional['seller_info']['product_id']);
if ($product) {
$cartItem->price = core()->convertPrice($product->price);
$cartItem->base_price = $product->price;
//$cartItem->custom_price = $product->price;
$cartItem->total = core()->convertPrice($product->price * $cartItem->quantity);
$cartItem->base_total = $product->price * $cartItem->quantity;
            $cartItem->save();
        } else {
            //$cartItem->custom_price = NULL;
        }

        $cartItem->save();
    } else {
        //$cartItem->custom_price = NULL;

        $cartItem->save();
    }
}`

hi @emperorjm
Marketplace is not compatible with bagisto 1.0.0, we are working on it and will update it soon.

I am closing this issue as this issue is not related to Bagisto core


getting error while starting ngnix server

"/usr/share/nginx/modules/ngx_http_modsecurity_module.so" version 1019001 instead of 1018000 in /etc/nginx/nginx.conf
Above is the error I am getting plaese help

Hello @gk6301965 ,
That sort of error message can appear if you have mismatched versions of nginx.
I.e. if the version of nginx that you are running (e.g. nginx -v) does not match the version of nginx that was used when the ngx_http_modsecurity_module was built.

Hello @gk6301965 ,
That sort of error message can appear if you have mismatched versions of nginx.
I.e. if the version of nginx that you are running (e.g. nginx -v) does not match the version of nginx that was used when the ngx_http_modsecurity_module was built.

but how to slove this

When you are following instructions for the ModSecurity-nginx connector, there will be a step where you download the nginx source. This will be where you do make modules The version of the source code that you downloaded must be the same as the version of nginx that you are actually running. See for example https://www.nginx.com/blog/compiling-and-installing-modsecurity-for-open-source-nginx/#4 %E2%80%93-Download-the-NGINX-Connector-for-ModSecurity-and-Compile-It-as-a-Dynamic-Module

Closing due to no further feedback.


Getting started with opentelemetry-spark

Hello @keytiong. First of all, thank you for all your time and effort in keeping this repository up to date. I appreciate it as this is the only repository that was found for the query onTaskStart io.opentelemetry org.apache.spark on GitHub :slightly_smiling_face: and it seems (this is the main topic...) that it implements real distributed tracing in Spark.

If I run the command described in README.md: ./gradlew build,
the result is:
Error: Could not find or load main class org.gradle.wrapper.GradleWrapperMain
Caused by: java.lang.ClassNotFoundException: org.gradle.wrapper.GradleWrapperMain

Workaround: run locally installed Gradle 8.2.1.

Command: gradle --no-daemon clean build
Result:
To honour the JVM settings for this build a single-use Daemon process will be forked. For more on this, please refer to https://docs.gradle.org/8.2.1/userguide/gradle_daemon.html#sec:disabling_the_daemon in the Gradle documentation.
Daemon will be stopped at the end of the build

FAILURE: Build failed with an exception.

* What went wrong:
Could not determine the dependencies of task ':spotlessCheck'.
> Could not create task ':spotless JavaCheck'.
    > Could not create task ':spotlessJava'.
        > java.nio.file.NoSuchFileException: /buildscripts/spotless.license.java

* Try:
> Run with --stacktrace option to get the stack trace.
> Run with --info or --debug option to get more log output.
> Run with --scan to get full insights.
> Get more help at https://help.gradle.org.

Deprecated Gradle features were used in this build, making it incompatible with Gradle 9.0.

You can use '-warning-mode all' to show the individual deprecation warnings and determine if they come from your own scripts or plugins.

For more on this, please refer to https://docs.gradle.org/8.2.1/userguide/command_line_interface.html#sec:command_line_warnings in the Gradle documentation.

BUILD FAILED in 10s

Workaround: comment out the line below. https://github.com/keytiong/opentelemetry-spark/blob/ec350164e4683010b6b83950f9465f6e24fb5d15/build.gradle#L59

I built the library, copied it into an image that includes Spark, and used the following parameters as specified in the README:
-javaagent:/opt/spark/jars/opentelemetry-javaagent.jar
-Dotel.javaagent.extensions=/opt/spark/jars/opentelemetry-spark-0.10.0-SNAPSHOT-all.jar
-Dotel.java.global-autoconfigure.enabled=true

but there are no related spans (I first tried with Azure Monitor OT Distro, then with the provided OpenTelemetry library in build/libs/, which required me to upgrade Java from 11 to 17) such as spark_job or spark_stage, either in a tracing system or with -Dotel.traces.exporter=logging. Other traces, such as HTTP requests from Spark to Azure Storage, are there.

I'm not sure what I'm doing wrong... I thought this problem was in the tricky App Insights (they like rename standard properties to their own), but with the community OpenTelemetry agent it's the same problem.
If you wouldn't mind helping me with this or providing additional steps on how to debug/deploy your code, I'd really appreciate it.
Thanks in advance :slightly_smiling_face:
Regards,
Eduard

Command: gradle clean test.
Result:
Deprecated Gradle features were used in this build, making it incompatible with Gradle 9.0.

You can use use '--warning-mode all' to show the individual deprecation warnings and determine if they come from your own scripts or plugins.

For more on this, please refer to https://docs.gradle.org/8.2.1/userguide/command_line_interface.html#sec:command_line_warnings in the Gradle documentation.

BUILD SUCCESSFUL in 7s
5 actionable tasks: 5 executed

@progxaker. Thanks for reporting the build issue. I'm new to Gradle and didn't realise that gradle-wrapper.jar and gradle-wrapper.properties are meant to be committed to to VCS in order for gradlew to work. I also fixed the spotless license file reported. I've setup a GitHub action to build the binary going forward instead of building on my local machine.

@progxaker
Are you running with the open source Apache Spark 3.4.1 or another Spark 3.4.1 distribution?
The code has been developed with the following configuration

Apache Spark 3.4.1
Apache YARN Hadoop 3.3.6
OpenTelemetry javaagent 1.31.0
Tested with org.apache.spark.examples.SparkPi in cluster mode
Single node pseudo cluster on local machine

You may want to add the following system property to the spark.driver.extraJavaOptions and spark.executor.extraJavaOptons.
-Dotel.javaagent.debug=true
That will emit verbose OpenTelemetry javaagent debug messages to system.err which you can view in YARN Resource Manager console. Hopefully that may shade some light on any exception or error during instrumentation

Hi @keytiong.

I also fixed the spotless license file reported.

Thank you)

Are you running with the open source Apache Spark 3.4.1 or another Spark 3.4.1 distribution?

I'm using the open-source one (spark-3.4.1-bin-hadoop3.tgz) on a Kubernetes cluster.

-Dotel.javaagent.debug=true

Hm, I'll try that and let you know.
Thanks for the response :slightly_smiling_face:

Thanks @keytiong, with the DEBUG log level I found three stack dumps (all with NullPointerException):

onJobStart
[otel.javaagent 2024-02-13 19:25:24:094 +0000] [dag-scheduler-event-loop] DEBUG io.opentelemetry.javaagent.bootstrap.ExceptionLogger - Failed to handle exception in instrumentation for org.apache.spark.scheduler.LiveListenerBus
java.lang.NullPointerException
        at io.opentelemetry.javaagent.shaded.instrumentation.api.internal.cache.weaklockfree.AbstractWeakConcurrentMap.put(AbstractWeakConcurrentMap.java:146)
        at io.opentelemetry.javaagent.shaded.instrumentation.api.internal.cache.weaklockfree.WeakConcurrentMap.put(WeakConcurrentMap.java:48)
        at io.opentelemetry.javaagent.shaded.instrumentation.api.internal.cache.weaklockfree.WeakConcurrentMap$WithInlinedExpunction.put(WeakConcurrentMap.java:206)
        at io.opentelemetry.javaagent.shaded.instrumentation.api.internal.cache.WeakLockFreeCache.put(WeakLockFreeCache.java:31)
        at io.opentelemetry.javaagent.bootstrap.field.VirtualFieldImpl$org$apache$spark$scheduler$ActiveJob$io$opentelemetry$javaagent$shaded$io$opentelemetry$context$Context.mapPut(VirtualFieldImplementationsGenerator.java:304)
        at io.opentelemetry.javaagent.bootstrap.field.VirtualFieldImpl$org$apache$spark$scheduler$ActiveJob$io$opentelemetry$javaagent$shaded$io$opentelemetry$context$Context.realPut(VirtualFieldImplementationsGenerator.java)
        at io.opentelemetry.javaagent.bootstrap.field.VirtualFieldImpl$org$apache$spark$scheduler$ActiveJob$io$opentelemetry$javaagent$shaded$io$opentelemetry$context$Context.set(VirtualFieldImplementationsGenerator.java:284)
        at io.opentelemetry.javaagent.instrumentation.spark.ApacheSparkSingletons.setJobContext(ApacheSparkSingletons.java:117)
        at io.opentelemetry.javaagent.instrumentation.spark.v3_1.SparkEventListener.onJobStart(SparkEventListener.java:71)
        at io.opentelemetry.javaagent.instrumentation.spark.v3_1.SparkEventListener.handleSparkListenerEvent(SparkEventListener.java:254)
        at org.apache.spark.scheduler.LiveListenerBus.post(LiveListenerBus.scala:126)
        at org.apache.spark.scheduler.DAGScheduler.handleJobSubmitted(DAGScheduler.scala:1331)
        at org.apache.spark.scheduler.DAGSchedulerEventProcessLoop.doOnReceive(DAGScheduler.scala:2991)
        at org.apache.spark.scheduler.DAGSchedulerEventProcess Loop.onReceive(DAGScheduler.scala:2982)
        at org.apache.spark.scheduler.DAGSchedulerEventProcessLoop.onReceive(DAGScheduler.scala:2971)
        at org.apache.spark.util.EventLoop$$anon$1.run(EventLoop.scala:49)

onStageSubmitted
[otel.javaagent 2024-02-13 19:25:24:105 +0000] [dag-scheduler-event-loop] DEBUG io.opentelemetry.javaagent.bootstrap.ExceptionLogger - Failed to handle exception in instrumentation for org.apache.spark.scheduler.LiveListenerBus
java.lang.NullPointerException
        at io.opentelemetry.javaagent.shaded.instrumentation.api.internal.cache.weaklockfree.AbstractWeakConcurrentMap.getIfPresent(AbstractWeakConcurrentMap.java:113)
        at io.opentelemetry.javaagent.shaded.instrumentation.api.internal.cache.weaklockfree.WeakConcurrentMap.getIfPresent(WeakConcurrentMap.java:48)
        at io.opentelemetry.javaagent.shaded.instrumentation.api.internal.cache.weaklockfree.WeakConcurrentMap$WithInlinedExpunction.getIfPresent(WeakConcurrentMap.java:194)
        at io.opentelemetry.javaagent.shaded.instrumentation.api.internal.cache.WeakLockFreeCache.get(WeakLockFreeCache.java:26)
        at io.opentelemetry.javaagent.bootstrap.field.VirtualFieldImpl$org$apache$spark$scheduler$ActiveJob$io$opentelemetry$javaagent$shaded$io$opentelemetry$context$Context.mapGet(VirtualFieldImplementationsGenerator.java:297)
        at io.opentelemetry.javaagent.bootstrap.field.VirtualFieldImpl$org$apache$spark$scheduler$ActiveJob$io$opentelemetry$javaagent$shaded$io$opentelemetry$context$Context.realGet(VirtualFieldImplementationsGenerator.java)
        at io.opentelemetry.javaagent.bootstrap.field.VirtualFieldImpl$org$apache$spark$scheduler$ActiveJob$io$opentelemetry$javaagent$shaded$io$opentelemetry$context$Context.get(VirtualFieldImplementationsGenerator.java:279)
        at io.opentelemetry.javaagent.instrumentation.spark.ApacheSparkSingletons.getJobContext(ApacheSparkSingletons.java:121)
        at io.opentelemetry.javaagent.instrumentation.spark.v3_1.SparkEventListener.onStageSubmitted(SparkEventListener.java:110)
        at io.opentelemetry.javaagent.instrumentation.spark.v3_1.SparkEventListener.handleSparkListenerEvent(SparkEventListener.java:258)
        at org.apache.spark.scheduler.LiveListenerBus.post(LiveListenerBus.scala:126)
        at org.apache.spark.scheduler.DAGScheduler.submitMissingTasks(DAGScheduler.scala:1547)
        at org.apache.spark.scheduler.DAGScheduler.submitStage(DAGScheduler.scala:1397)
        at org.apache.spark.scheduler.DAGScheduler.handleJobSubmitted(DAGScheduler.scala:1332)
        at org.apache.spark.scheduler.DAGSchedulerEventProcessLoop.doOnReceive(DAGScheduler.scala:2991)
        at org.apache.spark.scheduler.DAGSchedulerEventProcessLoop.onReceive(DAGScheduler.scala:2982)
        at org.apache.spark.scheduler.DAGSchedulerEventProcessLoop.onReceive(DAGScheduler.scala:2971)
        at org.apache.spark.util.EventLoop$$anon$1.run(EventLoop.scala:49)

onJobEnd
[otel.javaagent 2024-02-13 19:25:25:507 +0000] [dag-scheduler-event-loop] DEBUG io.opentelemetry.javaagent.bootstrap.ExceptionLogger - Failed to handle exception in instrumentation for org.apache.spark.scheduler.LiveListenerBus
java.lang.NullPointerException
        at io.opentelemetry.javaagent.shaded.instrumentation.api.internal.cache.weaklockfree.AbstractWeakConcurrentMap.getIfPresent(AbstractWeakConcurrentMap.java:113)
        at io.opentelemetry.javaagent.shaded.instrumentation.api.internal.cache.weaklockfree.WeakConcurrentMap.getIfPresent(WeakConcurrentMap.java:48)
        at io.opentelemetry.javaagent.shaded.instrumentation.api.internal.cache.weaklockfree.WeakConcurrentMap$WithInlinedExpunction.getIfPresent (WeakConcurrentMap.java:194)
        at io.opentelemetry.javaagent.shaded.instrumentation.api.internal.cache.WeakLockFreeCache.get(WeakLockFreeCache.java:26)
        at io.opentelemetry.javaagent.bootstrap.field.VirtualFieldImpl$org$apache$spark$scheduler$ActiveJob$io$opentelemetry$javaagent$shaded$io$opentelemetry$context$Context.mapGet(VirtualFieldImplementationsGenerator.java:297)
        at io.opentelemetry.javaagent.bootstrap.field.VirtualFieldImpl$org$apache$spark$scheduler$ActiveJob$io$opentelemetry$javaagent$shaded$io$opentelemetry$context$Context.realGet(VirtualfieldImplementationsGenerator.java)
        at io.opentelemetry.javaagent.bootstrap.field.VirtualFieldImpl$org$apache$spark$scheduler$ActiveJob$io$opentelemetry$javaagent$shaded$io$opentelemetry$context$Context.get(VirtualFieldImplementationsGenerator.java:279)
        at io.opentelemetry.javaagent.instrumentation.spark.ApacheSparkSingletons.getJobContext(ApacheSparkSingletons.java:121)
        at io.opentelemetry.javaagent.instrumentation.spark.v3_1.SparkEventListener.onJobEnd(SparkEventListener.java:81)
        at io.opentelemetry.javaagent.instrumentation.spark.v3_1.SparkEventListener.handleSparkListenerEvent(SparkEventListener.java:256)
        at org.apache.spark.scheduler.LiveListenerBus.post(LiveListenerBus.scala:126)
        at org.apache.spark.scheduler.DAGScheduler.handleTaskCompletion(DAGScheduler.scala:1887)
        at org.apache.spark.scheduler.DAGSchedulerEventProcessLoop.doOnReceive(DAGScheduler.scala:3042)
        at org.apache.spark.scheduler.DAGSchedulerEventProcessLoop.onReceive(DAGScheduler.scala:2982)
        at org.apache.spark.scheduler.DAGSchedulerEventProcessLoop.onReceive(DAGScheduler.scala:2971)
        at org.apache.spark.util.EventLoop$$anon$1.run(EventLoop.scala:49)

@progxaker. I am not able to reproduce the NullPointerException but I can see how it may occurred. It appears that not all job id has an ActiveJob created. I have refactor the instrumentation logic and hope that change would fix the reported bug.
Are you able to build the extension from the develop branch and test the latest fix? Otherwise, I can publish a SNAPSHOT build.

@keytiong. Now everyting works! I built the jar file from the develop branch.
I used Jaeger to show the spark_job, spark_stage and spark_task spans.

[For history] Simple Jaeger deployment on K8s

Add the following options to Java:

-Dotel.traces.exporter=jaeger
-Dotel.exporter.jaeger.endpoint=http://jaeger:14250

Run the command kubectl create -n <namespace> -f <file-with-the-following-context>.

apiVersion: apps/v1
kind: Deployment
metadata:
  name: jaeger-deployment
  labels:
    app: jaeger
spec:
  replicas: 1
  selector:
    matchLabels:
      app: jaeger
  template:
    metadata:
      annotations:
        sidecar.istio.io/inject: "false"
      labels:
        app: jaeger
  spec:
    containers:
    - name: jaeger
      env:
      - name: COLLECTOR_ZIPKIN_HOST_PORT
        value: ":9411"
      image: jaegertracing/all-in-one:1.54
      ports:
      - containerPort: 6831
        name: "zipkin-collect"
        protocol: UDP
      - containerPort: 6832
        name: "zipkin-nodejs"
        protocol: UDP
      - containerPort: 5775
        name: "zipkin-depr"
        protocol: TCP
      - containerPort: 5778
        name: "configs"
        protocol: TCP
      - containerPort: 16686
        name: "frontend"
        protocol: TCP
      - containerPort: 4317
        name: "otlp-http"
        protocol: TCP
      - containerPort: 4318
        name: "otlp-grpc"
        protocol: TCP
      - containerPort: 14268
        name: "jaeger"
        protocol: TCP
      - containerPort: 14250
        name: "model-proto"
        protocol: TCP
      - containerPort: 9411
        name: "zipkin-opt"
        protocol: TCP
---
apiVersion: v1
kind: Service
metadata:
  name: jaeger
  labels:
    app: jaeger
spec:
  ports:
  - port: 6831
    name: "zipkin-collect"
    protocol: UDP
  - port: 6832
    name: "zipkin-nodejs"
    protocol: UDP
  - port: 5775
    name: "zipkin-depr"
    protocol: TCP
  - port: 5778
    name: "configs"
    protocol: TCP
  - port: 16686
    name: "frontend"
    protocol: TCP
  - port: 4317
    name: "otlp-http"
    protocol: TCP
  - port: 4318
    name: "otlp-grpc"
    protocol: TCP
  - port: 14268
    name: "jaeger"
    protocol: TCP
  - port: 14250
    name: "model-proto"
    protocol: TCP
  - port: 9411
    name: "zipkin-opt"
    protocol: TCP
  selector:
    app: jaeger

Results

The error isn't related to this issue.

I will be working with Microsoft to resolve the problem with Java extensions since they are not loading them.
If you don't mind, we can close this issue since the underlying blocker has been removed.

Many thanks!

Hi @progxaker,
Thanks for confirming the fix. I've released version 0.10.0 which includes a few other changes and upgrade to OpenTelemetry 2.1.0 (OTel SDK 1.35.0).
You may want to test that build and raise a new issue if you encountered any other problem.


[libjpeg-turbo] use d suffix for debug libs

Using the d suffix in debug, it allows the official (cmake 3.13) FindJPEG to correctly find the two different configuration libraries

I am seeing failures in qt5-base on windows, it may need updated to find the new debug library name.

very glad that you can find regressions and failures in other ports.
Shall I check qt5-base also?

@cenit it would be great if you would be able to look into the qt5-base build failure.

ok sure, I'll try my best. Starting a build right now

ok I should have fixed the problem, please let me know if you find any other problem

@cenit
Can we handle this via vcpkg-cmake-wrapper to solve this issue?
Since we recommend to use the name that upstream supports instead of renaming it.
Also this will block pkgconfig fixup. So I'm not sure which solution is more suitable.
What do you think?

That's the name that's most convenient for debug, and in fact the official cmake module looks for the d suffix... Maybe we can use a patch in the source code instead of renaming it after build?


replace Tom F with Rick Anderson

@tfitzmac please review.

@tfitzmac are you OK with this change?

@Rick-Anderson - yes, thanks


History endpoint gives 404

When I request /api/v6/history/ endpoint it returns 404. The same happens for v5 version of the API.

Sorry, opened the issue in the wrong place. Closing.

I get the same as the above comment. Seems this api ver has been depreciated. Any suggestions for a newer api?


Force text position to round to the nearest integer before drawing.

If text is placed at a fractional position (i.e. [30.3, 20.5] instead of [30.0, 20.0]) it causes artefacts to appear and a slight warping when drawn.
@bvssvni is there maybe a way we can "round" or "floor" the transform position to the nearest whole number position just before drawing text (perhaps somewhere around here)?
Normally i've been avoiding this by making sure that whenever I .shift a text Form I use .floored or .rounded values, however this becomes too hard to keep track of when shifting groups of groups of Forms for example. It would be nice if the user didn't have to think about it and the backend handled it automatically.

Could add Text::roundto piston-graphics, which rounds the translated position.

I opened https://github.com/PistonDevelopers/graphics/issues/998

oooo that sounds good :+1: would be interesting to see if it fixes all the text artefacts issues in conrod :)

Just for fun, [a related slide] that describes our issue pretty nicely. I guess what we're doing by .floor/.rounding the position is converting to a Signed Distance Field.


More initialism corrections (golint)

Deal with Url -> URL and BaseUrl -> BaseURL conversion
while preserving backward compatibility, and marking
relevant lines deprecated.
Also fix related initialisms in strings and comments.
Continued effort in fixing #959.

See 6e30c10d09ec60e8df3b4c17e6ab7a5896245928
To communicate these changes to the users, I think it is better to create temporary methods on the structs for the renamed fields, like this:
// Url is deprecated. Will be removed in 0.15.
func (p *pager) Url() template.HTML {
	helpers.Deprecated("Paginator", "Url", "URL")
	return p.URL()
}

@bep Thank you for authoring helpers.Deprecated() and showing me how to use it.  It has been a great learning experience!
I need to leave the house in an hour though.  I hope to find time tonight (12 hours from now?) to study and incorporate your example to deprecated struct fields.  :-)

No rush. Note that, from the template's point of view, a method will look (almost) like a field, so the above should work for both cases.

Hi @bep!
You are brilliant!    It is such a joy to use!  It makes the transition so much cleaner too!
I have just pushed 92ae298; please check and see if it is OK.
I will update the docs soon.  :-)
Thanks again!

Merged. Quality work!
I may be a person who thinks this is more important than the average developer Joe, but if you don't pull the tech debt by the horns, you get a legacy system pretty fast.


Improve the pipeline and expand the container build

Hey Lars,
I saw there where some improvements to be made in the pipeline. Let me know if you have any questions.
Here is an example from the metadata on a master build (where i commented out the docker specific steps because i don't have the same secrets on my fork)
  {
    "tags": [
      "ghcr.io/oscrx/gitlab-ci-dashboard:master",
      "ghcr.io/oscrx/gitlab-ci-dashboard:sha-d236319"
    ],
    "labels": {
      "org.opencontainers.image.title": "gitlab-ci-dashboard",
      "org.opencontainers.image.description": "Gitlab CI Dashboard will provide you a global overview of all pipelines/schedules and their status in Gitlab",
      "org.opencontainers.image.url": "https://github.com/oscrx/gitlab-ci-dashboard",
      "org.opencontainers.image.source": "https://github.com/oscrx/gitlab-ci-dashboard",
      "org.opencontainers.image.version": "master",
      "org.opencontainers.image.created": "2023-05-11T15:20:16.413Z",
      "org.opencontainers.image.revision": "d2363193c9a49d200b314f33cdebc18d34e55178",
      "org.opencontainers.image.licenses": "MIT"
    }
  }

And here an example when i released version v2.3.4
  {
  "tags": [
    "ghcr.io/oscrx/gitlab-ci-dashboard:2.3.4",
    "ghcr.io/oscrx/gitlab-ci-dashboard:2",
    "ghcr.io/oscrx/gitlab-ci-dashboard:2.3",
    "ghcr.io/oscrx/gitlab-ci-dashboard:sha-d236319",
    "ghcr.io/oscrx/gitlab-ci-dashboard:latest"
  ],
  "labels": {
    "org.opencontainers.image.title": "gitlab-ci-dashboard",
    "org.opencontainers.image.description": "Gitlab CI Dashboard will provide you a global overview of all pipelines/schedules and their status in Gitlab",
    "org.opencontainers.image.url": "https://github.com/oscrx/gitlab-ci-dashboard",
    "org.opencontainers.image.source": "https://github.com/oscrx/gitlab-ci-dashboard",
    "org.opencontainers.image.version": "2.3.4",
    "org.opencontainers.image.created": "2023-05-11T15:26:16.255Z",
    "org.opencontainers.image.revision": "d2363193c9a49d200b314f33cdebc18d34e55178",
    "org.opencontainers.image.licenses": "MIT"
  }
}

The images should be tagged the same for docker.io, but is's hard for me to test those.

I removed the major and major+minor tag
But the Github sha tag option does not differentiate between a branch. Is it a problem if that tag is also published?

that is fine i guess ;-)

I forgot a condition in the action where it updates the Docker Hub description.
This is not perfect though. It will run on any build that is not triggered by a pull request.
The build should succeed now though..

The branches have divirged to much, please re-open the PR when applicable.


Support Integer Division

Currently, all division operations result in a float64 object. This is not the expected/desired behaviour when both operands are integers, especially if the remainder is zero.
Suggested fix: support '//' operation to force integer division (floor result, return int64)

Can confirm is working as suspected.


update docker-in-docker testimage for s390x

Changes
https://github.com/tektoncd/pipeline/issues/7496 This PR is updated the docker:dind image in the test examples. this is not multi arch image, its failing in s390x CI platforms, so use different image for s390x platform.
CI Failure:
https://dashboard.dogfooding.tekton.dev/#/namespaces/bastion-z/pipelineruns/tekton-pipeline-s390x-nightly-run-mnhzc?pipelineTask=examples-test-pipeline
Submitter Checklist
As the author of this PR, please check off the items in this checklist:

[ ] Has Docs if any changes are user facing, including updates to minimum requirements e.g. Kubernetes version bumps
[ ] Has Tests included if any functionality added or changed
[x] Follows the commit message standard
[x] Meets the Tekton contributor standards (including functionality, content, code)
[x] Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
[ ] Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings). See some examples of good release notes.
[ ] Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes
NONE

/kind bug

/test pull-tekton-pipeline-integration-tests

/test pull-tekton-pipeline-beta-integration-tests

/retest


iOS 13 DisallowOverscroll not working

i have added config.xml
also added forceOverscroll=false  but not working ios 13

this happen only when
    <platform name="ios">
        <preference name="deployment-target" value="13.0"/>
    </platform>

is set

Any movement here?

We are archiving this repository following Apache Cordova's Deprecation Policy. We will not continue to work on this repository. Therefore all issues and pull requests are being closed. Thanks for your contribution.


Replace Google Docs with Google Slides

Checklist
Required changes:

[ ] Center the description (Line 17 in HTML file) using a single change in CSS
[ ] Fix JS so that when the search is executed, the search engine is not present in query
[ ] Add Google Drive, Google Docs and Google Sheets as a provider

Optional changes:

[ ] Add other search providers (GitHub, Spotify, etc)
[ ] Additional CSS styling (as you like)

Resolved in group


Pythia GPT-NeoX test case

Issue #, if available:
NA
Description of changes:
This PR aims to add a new test case, Pythia model training with GPT-NeoX.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

https://github.com/aws-samples/awsome-distributed-training/pull/174/commits/b309e637fcb0818960e175ffea726fe2901842a6 Introduces changes needed to retrieve and process C4 dataset instead of the Pile dataset.

Thanks @verdimrc for reviewing the PR! I will test the container again with pre-installed NCCL before merging this.


[WIP] Use stable etcd operator as opposed to etcd from incubator

Closes #75 - How can we test that st2 is still stable with a different dependency?

CI is also unhappy.
If you look at CI (https://circleci.com/gh/StackStorm/stackstorm-ha/907) it shows that some st2 services pods are in Crashloop. Most probably they can't connect to new etcd backend due to changed endpoint hostname or similar.

After looking at it closer, etcd-operator stable Helm chart by default doesn't create the etcd cluster itself.
Only by providing Helm value customResources.createEtcdClusterCRD = true it can create a cluster, but with that K8s CustomResourceDefinition named EtcdCluster is not available at first run:
helm install .
Error: validation failed: unable to recognize "": no matches for kind "EtcdCluster" in version "etcd.database.coreos.com/v1beta2"

https://github.com/helm/charts/tree/master/stable/etcd-operator#installing-the-chart
Note: If you set cluster.enabled on install, it will have no effect. Before you create an etcd cluster, the TPR must be installed by the operator, so this option is ignored during helm installs, but can be used in upgrades.

So the problem with this Helm chart is that it can't be used automatically as dependency since needed CustomResourceDefinition is not available during the install time, meaning etcd-operator Helm chart needs to be applied manually before stackstorm-ha. Not an option.

An alternative is to try to improve etcd-operator Helm chart https://github.com/helm/charts/tree/master/stable/etcd-operator by defining CustomResourceDefinition in Helm template.
To make sure CRD is registered before we can use it, Helm provides custom-resource-defintion pre-hook as described in: https://helm.sh/docs/developing_charts/#defining-a-crd-with-the-crd-install-hook
A quick example from prometheus-operator:
https://github.com/helm/charts/blob/32cfeb0527789f2354d4bc7ce978a2e67992e014/stable/prometheus-operator/templates/prometheus-operator/crd-prometheusrules.yaml#L15


Annnoying popup "Another instance of Code is running but not responding"

Does this issue occur when all extensions are disabled?: Yes

VS Code Version: 1.72.2
OS Version: Windows Server 2012

Steps to Reproduce:

Open VsCode

Open a big network file through command line (something that vscode take more than 3/4 seconds to show)
example:
C:\Users\XXX>"C:\Program Files\Microsoft VS Code\Code.exe" \NETWORKPATH\SOMEPATH\log\root.log

The file is loaded in first VSCODE but the popup is always showed (there is no "another instance")

(We use an automate tool to open logs/configuration in right network path, so this is common for us)

Thanks for creating this issue! It looks like you may be using an old version of VS Code, the latest stable release is 1.71.2. Please try upgrading to the latest version and checking whether this issue remains.
Happy Coding!

Sorry issue is 1.71.2

Does this issue still persist with latest stable 1.74 ?

This issue has been closed automatically because it needs more information and has not had recent activity. See also our issue reporting guidelines.
Happy Coding!


[BACKLOG-17016] Implement EmbeddedNamedClusters on Job Steps:

The infrastructure for jobs and following job Steps are implemented with this PR
Delete Files
Delete Folders
Move Files
Copy Files
Wait For File
Create a Folder
Delete File
Create File

Build Completed
:fire: This pull request has some issues. It would be preferable to fix them in order for it to be just perfect. See below for more details. Some links are also available below for further assistance in addressing those issues.
Build Commands
mvn -B -fn -f 'pom.xml' -pl 'engine' -P '!assemblies' -amd clean install && mvn -B -f 'pom.xml' -pl 'engine' -P '!assemblies' -amd site

Cleanup Commands
mvn -B -f 'pom.xml' -pl 'engine' -P '!assemblies' -amd build-helper:remove-project-artifact

Changed files
  engine/src/main/java/org/pentaho/di/job/Job.java
  engine/src/main/java/org/pentaho/di/job/JobMeta.java
  engine/src/main/java/org/pentaho/di/job/entries/copyfiles/JobEntryCopyFiles.java
  engine/src/main/java/org/pentaho/di/job/entries/createfile/JobEntryCreateFile.java
  engine/src/main/java/org/pentaho/di/job/entries/createfolder/JobEntryCreateFolder.java
  engine/src/main/java/org/pentaho/di/job/entries/deletefile/JobEntryDeleteFile.java
  engine/src/main/java/org/pentaho/di/job/entries/deletefiles/JobEntryDeleteFiles.java
  engine/src/main/java/org/pentaho/di/job/entries/deletefolders/JobEntryDeleteFolders.java
  engine/src/main/java/org/pentaho/di/job/entries/movefiles/JobEntryMoveFiles.java
  engine/src/main/java/org/pentaho/di/job/entries/waitforfile/JobEntryWaitForFile.java
  engine/src/main/java/org/pentaho/di/job/entry/JobEntryCopy.java
  engine/src/main/java/org/pentaho/di/job/entry/JobEntryInterface.java
  engine/src/test/java/org/pentaho/di/job/entries/copyfiles/JobEntryCopyFilesTest.java
  engine/src/test/java/org/pentaho/di/job/entries/deletefiles/JobEntryDeleteFilesTest.java

Unit test coverage change
These statistics help you identify how your changes have affected the coverage of the following files. If a file is not in this list, then its coverage was not affected by your changes. To get some help interpreting these metrics, please refer to Jacoco's documentation.
org.pentaho.di.job.entries.copyfiles.JobEntryCopyFiles

Branch Change:  + 1.32%
Complexity Change:  + .43%
Instruction Change:  + .91%
Line Change:  + .94%
Method Change: -1.60%:small_red_triangle_down:

org.pentaho.di.job.entries.createfile.JobEntryCreateFile

Branch Change:  + 3.85%
Complexity Change: -5.16%:small_red_triangle_down:
Instruction Change: -1.33%:small_red_triangle_down:
Line Change: -1.84%:small_red_triangle_down:
Method Change: -6.36%:small_red_triangle_down:

org.pentaho.di.job.entries.createfolder.JobEntryCreateFolder

Branch Change:  + 4.17%
Complexity Change: -5.64%:small_red_triangle_down:
Instruction Change: -1.52%:small_red_triangle_down:
Line Change: -2.29%:small_red_triangle_down:
Method Change: -7.64%:small_red_triangle_down:

org.pentaho.di.job.entries.deletefile.JobEntryDeleteFile

Branch Change:  + 3.85%
Complexity Change: -5.02%:small_red_triangle_down:
Instruction Change: -1.15%:small_red_triangle_down:
Line Change: -1.87%:small_red_triangle_down:
Method Change: -6.67%:small_red_triangle_down:

org.pentaho.di.job.entries.deletefiles.JobEntryDeleteFiles

Branch Change: -.37%:small_red_triangle_down:
Complexity Change: -.56%:small_red_triangle_down:
Instruction Change:  + .51%
Line Change:  + .69%
Method Change: -1.33%:small_red_triangle_down:

org.pentaho.di.job.entries.deletefolders.JobEntryDeleteFolders

Branch Change: -.20%:small_red_triangle_down:
Complexity Change: -1.04%:small_red_triangle_down:
Instruction Change: -.73%:small_red_triangle_down:
Line Change: -1.28%:small_red_triangle_down:
Method Change: -4.44%:small_red_triangle_down:

org.pentaho.di.job.entries.evaluatetablecontent.JobEntryEvalTableContent

Branch Change: -1.01%:small_red_triangle_down:
Complexity Change: -1.06%:small_red_triangle_down:
Instruction Change: -.17%:small_red_triangle_down:

org.pentaho.di.job.entries.ftpsget.JobEntryFTPSGet

Branch Change: -.53%:small_red_triangle_down:
Complexity Change: -.56%:small_red_triangle_down:
Instruction Change: -.07%:small_red_triangle_down:

org.pentaho.di.job.entries.movefiles.JobEntryMoveFiles

Branch Change: -.01%:small_red_triangle_down:
Complexity Change: -.22%:small_red_triangle_down:
Instruction Change: -.26%:small_red_triangle_down:
Line Change: -.36%:small_red_triangle_down:
Method Change: -1.79%:small_red_triangle_down:

org.pentaho.di.job.entries.sql.JobEntrySQL

Instruction Change: -3.28%:small_red_triangle_down:
Line Change: -3.87%:small_red_triangle_down:

org.pentaho.di.job.entries.waitforfile.JobEntryWaitForFile

Branch Change:  + 1.25%
Complexity Change: -1.78%:small_red_triangle_down:
Instruction Change: -.59%:small_red_triangle_down:
Line Change: -1.00%:small_red_triangle_down:
Method Change: -5.11%:small_red_triangle_down:

org.pentaho.di.job.entries.waitforsql.JobEntryWaitForSQL

Branch Change:  + .66%
Complexity Change:  + .93%
Instruction Change:  + .13%

org.pentaho.di.job.entry.JobEntryCopy

Instruction Change: -.14%:small_red_triangle_down:
Line Change: -.15%:small_red_triangle_down:

org.pentaho.di.job.Job

Branch Change: -.05%:small_red_triangle_down:
Complexity Change: -.05%:small_red_triangle_down:
Instruction Change: -.11%:small_red_triangle_down:
Line Change: -.12%:small_red_triangle_down:

org.pentaho.di.job.JobMeta

Branch Change:  + .12%
Complexity Change:  + .17%
Instruction Change:  + .25%
Line Change:  + .29%
Method Change:  + .54%

org.pentaho.di.trans.step.StepMeta

Branch Change:  + .68%
Complexity Change:  + .58%
Instruction Change:  + .19%
Line Change:  + .26%

org.pentaho.di.trans.steps.checksum.CheckSumMeta

Instruction Change: -.11%:small_red_triangle_down:

org.pentaho.di.trans.steps.combinationlookup.CombinationLookupMeta

Instruction Change:  + .04%

org.pentaho.di.trans.steps.csvinput.CsvInputMeta

Instruction Change:  + .05%

org.pentaho.di.trans.steps.dbproc.DBProcMeta

Instruction Change:  + .11%

org.pentaho.di.trans.steps.excelwriter.ExcelWriterStepMeta

Branch Change: -1.28%:small_red_triangle_down:
Complexity Change: -.78%:small_red_triangle_down:
Instruction Change: -.08%:small_red_triangle_down:

org.pentaho.di.trans.steps.ifnull.IfNullMeta

Branch Change:  + 2.00%
Complexity Change:  + 1.89%
Instruction Change:  + .17%

org.pentaho.di.trans.steps.memgroupby.MemoryGroupByMeta

Branch Change:  + 2.35%
Complexity Change:  + 2.70%
Instruction Change:  + .18%
Line Change:  + .48%

org.pentaho.di.trans.steps.pgbulkloader.PGBulkLoaderMeta

Branch Change: -.89%:small_red_triangle_down:
Complexity Change: -.98%:small_red_triangle_down:

org.pentaho.di.trans.steps.rowgenerator.RowGeneratorMeta

Instruction Change:  + .08%

org.pentaho.di.trans.steps.synchronizeaftermerge.SynchronizeAfterMergeMeta

Instruction Change:  + .04%

org.pentaho.di.trans.steps.tableoutput.TableOutputMeta

Branch Change:  + .91%
Complexity Change:  + .82%

org.pentaho.di.trans.steps.textfileinput.TextFileInputMeta

Branch Change:  + .53%

org.pentaho.di.trans.steps.uniquerows.UniqueRowsMeta

Instruction Change:  + .18%

org.pentaho.di.www.BaseHttpServlet

Complexity Change:  + 3.03%
Instruction Change:  + 6.77%
Line Change:  + 5.00%
Method Change:  + 3.45%

org.pentaho.di.www.GetJobStatusServlet

Branch Change:  + 54.17%
Complexity Change:  + 26.32%
Instruction Change:  + 73.68%
Line Change:  + 69.12%
Method Change:  + 42.86%

org.pentaho.di.www.GetTransStatusServlet

Branch Change:  + 29.17%
Complexity Change:  + 12.90%
Instruction Change:  + 68.83%
Line Change:  + 64.86%
Method Change:  + 42.86%

org.pentaho.di.www.PauseTransServlet

Branch Change:  + 45.83%
Complexity Change:  + 21.05%
Instruction Change:  + 67.98%
Line Change:  + 64.38%
Method Change:  + 42.86%

org.pentaho.di.www.PrepareExecutionTransServlet

Branch Change:  + 42.31%
Complexity Change:  + 20.00%
Instruction Change:  + 54.58%
Line Change:  + 59.38%
Method Change:  + 42.86%

org.pentaho.di.www.RemoveJobServlet

Branch Change:  + 50.00%
Complexity Change:  + 25.00%
Instruction Change:  + 71.53%
Line Change:  + 68.85%
Method Change:  + 42.86%

org.pentaho.di.www.RemoveTransServlet

Branch Change:  + 50.00%
Complexity Change:  + 25.00%
Instruction Change:  + 71.81%
Line Change:  + 68.85%
Method Change:  + 42.86%

org.pentaho.di.www.SniffStepServlet

Branch Change:  + 34.00%
Complexity Change:  + 15.62%
Instruction Change:  + 49.36%
Line Change:  + 52.80%
Method Change:  + 42.86%

org.pentaho.di.www.SniffStepServlet.MetaAndData

Complexity Change:  + 100.00%
Instruction Change:  + 100.00%
Line Change:  + 100.00%
Method Change:  + 100.00%

org.pentaho.di.www.SniffStepServlet.new RowListener() {...}

Complexity Change:  + 12.50%
Instruction Change:  + 29.51%
Line Change:  + 10.00%
Method Change:  + 25.00%

org.pentaho.di.www.StartExecutionTransServlet

Branch Change:  + 42.31%
Complexity Change:  + 23.81%
Instruction Change:  + 58.42%
Line Change:  + 60.49%
Method Change:  + 50.00%

org.pentaho.di.www.StartJobServlet

Branch Change:  + 34.38%
Complexity Change:  + 20.83%
Instruction Change:  + 52.91%
Line Change:  + 53.93%
Method Change:  + 50.00%

org.pentaho.di.www.StopJobServlet

Branch Change:  + 45.45%
Complexity Change:  + 22.22%
Instruction Change:  + 68.03%
Line Change:  + 65.22%
Method Change:  + 42.86%

org.pentaho.di.www.StopTransServlet

Branch Change:  + 45.45%
Complexity Change:  + 22.22%
Instruction Change:  + 68.86%
Line Change:  + 65.22%
Method Change:  + 42.86%

org.pentaho.di.www.TransformationMap

Branch Change: -5.68%:small_red_triangle_down:
Complexity Change: -4.62%:small_red_triangle_down:
Instruction Change: -5.64%:small_red_triangle_down:
Line Change: -5.38%:small_red_triangle_down:

org.pentaho.di.trans.steps.gpload.GPLoadMeta

Instruction Change:  + .09%

org.pentaho.di.ui.repository.pur.repositoryexplorer.model.UISecurityRole

Branch Change:  + 1.79%
Complexity Change:  + 1.54%
Instruction Change:  + .16%
Line Change:  + .58%

org.pentaho.di.trans.steps.salesforceupdate.SalesforceUpdateMeta

Instruction Change: -.17%:small_red_triangle_down:

Build Completed
:fire: This pull request has some issues. It would be preferable to fix them in order for it to be just perfect. See below for more details. Some links are also available below for further assistance in addressing those issues.
Build Commands
mvn -B -fn -f 'pom.xml' -pl 'engine' -P '!assemblies' -amd clean install && mvn -B -f 'pom.xml' -pl 'engine' -P '!assemblies' -amd site

Cleanup Commands
mvn -B -f 'pom.xml' -pl 'engine' -P '!assemblies' -amd build-helper:remove-project-artifact

Changed files
  engine/src/main/java/org/pentaho/di/job/Job.java
  engine/src/main/java/org/pentaho/di/job/JobMeta.java
  engine/src/main/java/org/pentaho/di/job/entries/copyfiles/JobEntryCopyFiles.java
  engine/src/main/java/org/pentaho/di/job/entries/createfile/JobEntryCreateFile.java
  engine/src/main/java/org/pentaho/di/job/entries/createfolder/JobEntryCreateFolder.java
  engine/src/main/java/org/pentaho/di/job/entries/deletefile/JobEntryDeleteFile.java
  engine/src/main/java/org/pentaho/di/job/entries/deletefiles/JobEntryDeleteFiles.java
  engine/src/main/java/org/pentaho/di/job/entries/deletefolders/JobEntryDeleteFolders.java
  engine/src/main/java/org/pentaho/di/job/entries/movefiles/JobEntryMoveFiles.java
  engine/src/main/java/org/pentaho/di/job/entries/waitforfile/JobEntryWaitForFile.java
  engine/src/main/java/org/pentaho/di/job/entry/JobEntryCopy.java
  engine/src/main/java/org/pentaho/di/job/entry/JobEntryInterface.java
  engine/src/test/java/org/pentaho/di/job/entries/copyfiles/JobEntryCopyFilesTest.java
  engine/src/test/java/org/pentaho/di/job/entries/deletefiles/JobEntryDeleteFilesTest.java

Unit test coverage change
These statistics help you identify how your changes have affected the coverage of the following files. If a file is not in this list, then its coverage was not affected by your changes. To get some help interpreting these metrics, please refer to Jacoco's documentation.
org.pentaho.di.core.injection.bean.BeanInjector

Branch Change: -.84%:small_red_triangle_down:
Complexity Change: -1.39%:small_red_triangle_down:

org.pentaho.di.job.entries.copyfiles.JobEntryCopyFiles

Branch Change:  + 1.32%
Complexity Change:  + .43%
Instruction Change:  + .91%
Line Change:  + .94%
Method Change: -1.60%:small_red_triangle_down:

org.pentaho.di.job.entries.createfile.JobEntryCreateFile

Branch Change:  + 3.85%
Complexity Change: -5.16%:small_red_triangle_down:
Instruction Change: -1.33%:small_red_triangle_down:
Line Change: -1.84%:small_red_triangle_down:
Method Change: -6.36%:small_red_triangle_down:

org.pentaho.di.job.entries.createfolder.JobEntryCreateFolder

Branch Change:  + 4.17%
Complexity Change: -5.64%:small_red_triangle_down:
Instruction Change: -1.52%:small_red_triangle_down:
Line Change: -2.29%:small_red_triangle_down:
Method Change: -7.64%:small_red_triangle_down:

org.pentaho.di.job.entries.deletefile.JobEntryDeleteFile

Branch Change:  + 3.85%
Complexity Change: -5.02%:small_red_triangle_down:
Instruction Change: -1.15%:small_red_triangle_down:
Line Change: -1.87%:small_red_triangle_down:
Method Change: -6.67%:small_red_triangle_down:

org.pentaho.di.job.entries.deletefiles.JobEntryDeleteFiles

Branch Change: -.37%:small_red_triangle_down:
Complexity Change: -.56%:small_red_triangle_down:
Instruction Change:  + .51%
Line Change:  + .69%
Method Change: -1.33%:small_red_triangle_down:

org.pentaho.di.job.entries.deletefolders.JobEntryDeleteFolders

Branch Change: -.20%:small_red_triangle_down:
Complexity Change: -1.04%:small_red_triangle_down:
Instruction Change: -.73%:small_red_triangle_down:
Line Change: -1.28%:small_red_triangle_down:
Method Change: -4.44%:small_red_triangle_down:

org.pentaho.di.job.entries.getpop.MailConnectionMeta

Branch Change: -1.00%:small_red_triangle_down:
Complexity Change: -1.41%:small_red_triangle_down:
Instruction Change: -.30%:small_red_triangle_down:

org.pentaho.di.job.entries.movefiles.JobEntryMoveFiles

Branch Change: -.01%:small_red_triangle_down:
Complexity Change: -.22%:small_red_triangle_down:
Instruction Change: -.26%:small_red_triangle_down:
Line Change: -.36%:small_red_triangle_down:
Method Change: -1.79%:small_red_triangle_down:

org.pentaho.di.job.entries.waitforfile.JobEntryWaitForFile

Branch Change:  + 1.25%
Complexity Change: -1.78%:small_red_triangle_down:
Instruction Change: -.59%:small_red_triangle_down:
Line Change: -1.00%:small_red_triangle_down:
Method Change: -5.11%:small_red_triangle_down:

org.pentaho.di.job.entry.JobEntryCopy

Instruction Change: -.14%:small_red_triangle_down:
Line Change: -.15%:small_red_triangle_down:

org.pentaho.di.job.Job

Branch Change: -.05%:small_red_triangle_down:
Complexity Change: -.05%:small_red_triangle_down:
Instruction Change: -.11%:small_red_triangle_down:
Line Change: -.12%:small_red_triangle_down:

org.pentaho.di.job.JobMeta

Branch Change:  + .12%
Complexity Change:  + .17%
Instruction Change:  + .25%
Line Change:  + .29%
Method Change:  + .54%

org.pentaho.di.trans.step.StepMeta

Branch Change: -.68%:small_red_triangle_down:
Complexity Change: -.58%:small_red_triangle_down:
Instruction Change: -.19%:small_red_triangle_down:
Line Change: -.26%:small_red_triangle_down:

org.pentaho.di.trans.steps.checksum.CheckSumMeta

Instruction Change:  + .11%

org.pentaho.di.trans.steps.combinationlookup.CombinationLookupMeta

Instruction Change: -.04%:small_red_triangle_down:

org.pentaho.di.trans.steps.excelwriter.ExcelWriterStepMeta

Branch Change: -1.28%:small_red_triangle_down:
Complexity Change: -.78%:small_red_triangle_down:
Instruction Change: -.04%:small_red_triangle_down:

org.pentaho.di.trans.steps.groupby.GroupByMeta

Branch Change: -3.12%:small_red_triangle_down:
Complexity Change: -3.16%:small_red_triangle_down:
Instruction Change: -.28%:small_red_triangle_down:
Line Change: -.74%:small_red_triangle_down:

org.pentaho.di.trans.steps.insertupdate.InsertUpdateMeta

Instruction Change:  + .05%

org.pentaho.di.trans.steps.memgroupby.MemoryGroupByMeta

Branch Change: -1.18%:small_red_triangle_down:
Complexity Change: -1.35%:small_red_triangle_down:
Instruction Change: -.18%:small_red_triangle_down:
Line Change: -.48%:small_red_triangle_down:

org.pentaho.di.trans.steps.pgbulkloader.PGBulkLoaderMeta

Branch Change:  + 1.79%
Complexity Change:  + .98%
Instruction Change:  + .23%
Line Change:  + .29%

org.pentaho.di.trans.steps.replacestring.ReplaceStringMeta

Instruction Change: -.07%:small_red_triangle_down:

org.pentaho.di.trans.steps.setvalueconstant.SetValueConstantMeta

Instruction Change:  + .14%

org.pentaho.di.trans.steps.sortedmerge.SortedMergeMeta

Instruction Change:  + .18%

org.pentaho.di.trans.steps.symmetriccrypto.symmetriccryptotrans.SymmetricCryptoTransMeta

Branch Change:  + 3.33%
Complexity Change:  + 1.85%
Instruction Change:  + .28%

org.pentaho.di.trans.steps.tableoutput.TableOutputMeta

Branch Change:  + .91%
Complexity Change:  + .82%

org.pentaho.di.trans.steps.textfileinput.TextFileInputMeta

Branch Change: -.53%:small_red_triangle_down:

org.pentaho.di.www.TransformationMap

Branch Change:  + 9.09%
Complexity Change:  + 6.15%
Instruction Change:  + 10.03%
Line Change:  + 10.00%

org.pentaho.di.trans.steps.googleanalytics.GaInputStepMeta

Instruction Change: -.07%:small_red_triangle_down:

org.pentaho.di.trans.steps.gpload.GPLoadMeta

Instruction Change:  + .04%

org.pentaho.di.ui.repository.pur.repositoryexplorer.model.UISecurityRole

Branch Change: -1.79%:small_red_triangle_down:
Complexity Change: -1.54%:small_red_triangle_down:
Instruction Change: -.16%:small_red_triangle_down:
Line Change: -.58%:small_red_triangle_down:


Add support for getting container id from cgroup path of different platforms

Why we need this PR:
Previous PR #138 has identified that different platforms might have different cgroup path.
Therefore, we need different regex to extract the container id from different cgroup paths.
My system has cgroup v1 and the OS is ubuntu, and after creating a kepler deployment, the cgroup path is as follows:
11:blkio:/kubepods.slice/kubepods-besteffort.slice/kubepods-besteffort-pod481c0ae9_7d40_46dd_b6ca_ba27cb64f87e.slice/docker-28a5e57257f81fcd6d592647dde27e06b53944d58af4fa546ad77a12ce8b41c2.scope

Another system, with RHEL and cgroup v1 has another path:
13:memory:/system.slice/containerd.service/kubepods-besteffort-pod0043435f_1854_4327_b76b_730f681a781d.slice:cri-containerd:01fd96f7ad292b02a8317cde4ecb8c7ef3cc06ffdd113f13410e0837eb2b2a20

What this PR does:
This PR adds the logic of another regex to extract the container id from cgroup path of different platforms
Signed-off-by: Marcelo Amaral<EMAIL_ADDRESS>

/cc @ruomengh @rootfs

@ruomengh can you review this? thanks

great teamwork!

@marceloamaral @ruomengh @jichenjc would you like to write a unit test for these cases?


Resources disappearing

I updated to the latest version and ever since then when i dismantle items i lose half the resources so i removed the mod and the bug went so i re-added the mod and the bug instantly came back.  Its not like the old bug that people had when dismantling when they only received 1 of an item it is always half

So I think my issue corresponds with this issue, so I comment here:
Ever since I craft any item, it uses the double amount of resources out of my inventory, not even using the container resources, but does not give the double crafted items. Its just a waste of resources.

I had the same problem, to craft something , it uses double of resources

I have looked at what you said and tested and it is as you say using double resources to craft i had'nt noticed it was that way around until you said

Can confirm. It uses double resources when crafting. And it doesn't seem to take materials from containers anymore.

What other mods you are running? This isn't caused by CwC itself and is related to mod compatibility. Most likely #44, but please do post a list of all mods you are running to make sure

Hey, it could be related to #44 as I use this mod as well. My list is the following:
ExploreTogether by Rolo
CraftingWithContainers by abearcodes
BepInExPack_Valheim by denikson
SimpleRecycling by abearcodes
CustomSlotItemLib by nearbear
BetterUI by Masa
EquipmentAndQuickSlots by RandyKnapp
FarmGrid by Nexus
Quick_Deposit by MaGic
QuickConnect by bdew
AutoRepair by Tekla
WishboneSlot by nearbear
PaddlePower by mgway
ValheimArmorstand by ceko
PlantingPlus by xXPancakeXx
MultiCraft by MaxiMods
multiplayerboatdamage by<PHONE_NUMBER>
TrashItems by virtuaCode

Confirmed E&QS issue. Thank you all for your reports, they help! Please use #44 for further discussions.


Render message to user on failed delete

Seems like the delete command is the only one that doesn't notify the user when you pass a wrong id.
Every other command rightly prints the error.

Thanks for feedback. I'm currently working on next version with better error logging and other improvements.


Feature request: A way to rotate the camera to the movement direction of the character would be amazing.

Hi,
In the Accessibility settings of the game, there is Auto-Rotate Camera. I think this is exactly what you want.
Someone said that this was rotating too slowly. Then I hacked it and made it way faster, but then it basically felt like "Rotate Camera Left/Right", but in a wonky way. So I suggest you just bind Rotate Camera Left/Right to A and D.
If it then rotates too slowly, let me know, I should be able to increase this speed.


feat: add HTML page for share links

Fix #8
Add HTML Page with all the required meta tags, used for sharing snapshot.org space and proposal page
TODO

[x] Add some UI and links for manual redirection
[x] Fill missing data, use default text TBD
[ ] Extract the endpoint into a dedicated express app, only for share link ? (avoid mixing api and share url)

@bonustrack @samuveth @ChaituVR
For the descriptionm, what text should we display for:

space, when the about field is empty ?
proposal: we remove-markdown and show the first X words ?

How should we show the proposal state ? Inside the title like [CLOSED] title ? or do we insert it in the description like [Closed] [X votes] description ?
I guess we're using the exact same url pattern, and just change the domain, e.g. http://link.snapshot.org/aave.eth/proposal/0x000 ?

proposal description will be:
body without markdown, truncated to 300 chars, with prefix [State] x votes -

space description will be:
space.about, or if empty, show x members

space, when the about field is empty ? show proposal stats like x active proposals | Y closed proposals | M pending proposals ?

These fields are not available yet on snapshot graphql API 🙈

space, when the about field is empty ? show proposal stats like x active proposals | Y closed proposals | M pending proposals ?

These fields are not available yet on snapshot graphql API 🙈

Yes, that's why a fallbacked to only x members

done


DragonBones official support?

Dragonbones plugin for phaser3 has too many bugs at the moment to use it.
Can we count on an official plugin for it?

Sorry, but no. There just aren't enough hours in the day to do this work for them, and honestly, it's so seldomly requested I'm not convinced it would be worth the investment either.


Add API on new Lovelace UI storage mode

Home Assistant release with the issue:
Home Assistant 0.84.
Component/platform:
Lovelace UI storage.
Description of problem:
In 0.84 a new storage mode for the Lovelace UI configuration was introduced.
This new storage mode works by storing the config in .storage/lovelace file which contains json.
The structure of this file is as follows:
{
    "data": {
        "config": {  },
    },
    "key": "lovelace",
    "version": 1
}

The config key contains an object with the actual Lovelace UI configuration (same as the contents of ui-lovelace.yaml).
Currently it is not clear if, and how custom components should modify the Lovelace UI configuration as stored by this new storage mode.
I would propose adding an API (that can be used by custom components) for reading / writing the configuration using this new storage mode.
Use case:
Use case the custom_updater component relies on being able to modify the Lovelace UI configuration.
Also see the discussion in this issue.

/move to home-assistant-polymer