raylib Security Policy missing

Issue description
Even though most issues around raylib releases and the current development can be easily handled with Issues, Discussions, and pull-requests, there is a limited prospect that an exploitable security vulnerability may arise that impacts programs that incorporate and depend upon raylib.  This also extends to possible exploits that arise in externals.
Recommended Approach
It is general practice that exploitable security vulnerabilities be reported and verified in secret, avoiding fueling malicious actors with knowledge of an exploit opportunity.
Even though there might be nothing for which raylib can or should provide some sort of confident remedy, there needs to be a way for a vulnerability report to be made and reviewed in confidence.
Setting the GitHub Security Policy will provide a clear declaration about what is considered responsible in the specific case of raylib usage.  At a minimum, along with a simple description of perspective on the subject, the ability for confidential reporting of alleged vulnerabilities should be enabled.  Such reports can be reviewed and a disposition determined quietly.

I'm not convinced there is anything security relevant that would make sense to spend time thinking about a formal process for. At least, nothing like this has ever come up in the past. Using most raylib functions on untrusted inputs is probably a bad idea.

stb_image for example documents that all security discussions are done in issues, and not in private. I think a policy like that would be sensible here.
This project discusses security-relevant bugs in public in Github Issues and Pull Requests, and it may take significant time for security fixes to be implemented or merged. If this poses an unreasonable risk to your project, do not use stb libraries.

I think miniaudio does it the same way as well.

@Peter0x44 One kind of security policy to write, and it would be very simple, is one that says everything is done in the open and there is no formal process.
At the same time, it would be valuable to click the button that allows private communication of alleged exploits, if only to quietly determine whether they are or not.  A lot of defects are not exploitable or depend on a system already being compromised.
The security policy feature is a way to make that all explicit in a place created for that purpose.
@wwderw David doesn't have a security policy statement, stb_image does.

Considering nothing similar to that has come up in 10 years I don't think there is a point to have a formal process. But the decisions from here are up to ray.

@wwderw David doesn't have a security policy statement, stb_image does.

There was an issue that someone created that had security implications and he had responded that he handles those the same way as everything else out in the open.

@wwderw

@wwderw David doesn't have a security policy statement, stb_image does.
In fact, if I'm seeing correctly, you had posted in that thread.

Yes, and so they had to mention it in an issue.  They did not disclose what they have identified as a vulnerability.
If David's Security policy statement was simply what he said in response to that issue, a reporter would see that and decide privately what to do.  Ideally, David there (and Ramon here) would enable private vulnerability reporting so that folks could say what they have noticed in private.  David (and Ramon) could then privately decide whether to discount it and let it go, or discuss farther to see what whether there is anything meaningful.  The whole point is not to give opportunities to malicious actors.
There are significant open-source projects that do take this sort of thing seriously.  I am suggesting the bare minimum here.

I am suggesting the bare minimum here.

This is not the "bare minimum" and it implies a potentially serious responsibility.

@wwderw

Yes, and so they had to mention it in an issue. They did not disclose what they have identified as a vulnerability.

And once he had answered it, that was his policy.  At least at that point in time.  That's the point that I was making.  He did at least have a policy at a specific point in time.  That may have changed since, even very quickly, but that is a policy on how he handles those things.  Rather or not, it's in it's own place, formally written is something else.  It is a statement of policy from the repo owner.

If David's Security policy statement was simply what he said in response to that issue, a reporter would see that and decide privately what to do.

And a reporter (especially the one, if they had looked at it since that response), still has that opportunity.  I think that the hangup is that it isn't in a nice secondary position off to the side that says that.  That doesn't always happen.  Shoot, I have seen some projects that don't have a license file, but the license itself is in the comments of the header.  Doesn't negate that there is a license, just may not be in the easiest spot to read it (of course, at the top of a header file, I don't know, that's quite easy to see when that gets opened up, but I digress or do a search for a related issue and see what the response is, not that hard to do, especially if considering on opening an issue to see what the policy is).
Or the question gets answered again and again and maybe again (especially if someone doesn't use the search function)

Ideally, David there (and Ramon here) would enable private vulnerability reporting so that folks could say what they have noticed in private. David (and Ramon) could then privately decide whether to discount it and let it go, or discuss farther to see what whether there is anything meaningful. The whole point is not to give opportunities to malicious actors.
There are significant open-source projects that do take this sort of thing seriously. I am suggesting the bare minimum here.

The "bare minimum" is actually to treat everything as a "bug" and it's handled out in the open.  What may or may not be "ideal" is something else.
In fact, that what's what you said here:

One kind of security policy to write, and it would be very simple, is one that says everything is done in the open and there is no formal process.

But that really isn't what is being advocated here, at least it looks that way based on the words that you are using, especially when treating something "out in the open".  Rather or not that has merits or not, is something else.
If someone has to have that clear policy out in it's own file in the repo before they can think of consuming that project (versus say an issue response), that is their call and their risk assessment.  Regardless of what that policy may be.
Using open source in of itself, has certain risks attached to it with regards to this, despite if a project has a dedicated spot for a "Security Policy".
Oddly enough, I went to STB repo and I didn't find a security policy for that repo, at least no .md file.  Found that in other projects as well.  So it appears that they aren't yoking the Github Security tab as well.

@wwderw @Peter0x44
By "bare minimum" I mean using the place already provided by GitHub for security policies so they are easily found and folks who have an interest can find it without searching for issues, open and closed.
I'd say David's response was a reaction.  It sounds like a policy so why not put it on the repository at a single place where it can be found easily.  I don't see anything about commitment, etc.  The policy can be there is no commitment and that standard issues and discussions can be used around defects of any kind.  Also, the down-side, no matter how many years minaudio has been around, someone had to say in public that they thing they have found a vulnerability and, even though it has not been described, there is now an unresolved concern in public.
I am unclear when the security policy tab showed up as s GitHub repository feature.  It does a bit more than provide a way to create a security.md file at the root of the repository.
It is also clear that open-source and absence of security policy are not in lock-step.  You think Linux doesn't have one?  I know LibreOffice and all Apache Software Foundation projects have them (though not on ASF mirrors on GitHub).  All of the open-source Microsoft projects here have them; for example, Microsoft Terminal Security Policy.
PS: GitHub itself provides security alerts, in private to repository owners.  These are often about dependencies for which there are known security-provoked updates.  In my case, after reviewing what the dependency defect was, I concluded that my code did not actually depend on a sketchy framework function and I could flag the alert as irrelevant to me.  This was all done in private.  It had nothing to do with any security policy of mine.  I don't think the security tab and security.md were a thing yet.  This does point out another factor though, and that is a way for the developers of a dependency to provide private notification of downstream users that a vulnerability is known and a repair is pending.

Linux has the policy "all bugs are security bugs", they go through the formality of assigning a CVE for basically everything I think. But Linux is not remotely comparable to raylib.

to provide private notification of downstream users that a vulnerability is known and a repair is pending.

I'm not convinced any users who would benefit from this even exist.

Your comments on the mini audio issue did heavily imply you think every project should maintain private contact channels to report vulnerabilities. But I don't agree.

I sense goal post moving here.  I have yet to see perfect code, so I assume that there is going to be something somewhere.  So having someone say that they saw something and what's the policy of reporting it, isn't something that's going to make me too surprised.  I'm sure that there are more compared to just that one that may be unresolved.  A threat actor could already know of it (downsides of open source) and already be acting on it, regardless if there are clear channels of resolution or not.
If the policy is to just report a bug, having the .md file (which provides guidance on what to do with regard to this) is moot.  Private channels is moot.  I do not think that every open source project needs to have something like this.  There are some that should, but not in every single instance.  And if that's the case, while the other things may be nice to have, they are moot at that point.
@Peter0x44 I believe that is how Linux does it as well.

@Peter0x44 > Your comments on the mini audio issue did heavily imply you think every project should maintain private contact channels to report vulnerabilities. But I don't agree.
Fine.  I did recommend that the option for private reporting of vulnerabilities be enabled.  It is a check-off item on the security tab.  As the owner of a repository, I can't see how that is implemented.  You can try contacting me via the Miser Project security tab and we can confirm how it operates.  This simple step would have avoided the Cisco security folks having to nudge David in an Issue.

It occurs to me that we have wasted enough words bickering about this to have created 4 simple security policy statements as simple declarations of disinterest and a way to report a suspected vulnerability (not a garden-variety bug) in a manner that does not alert malicious observers.

@orcmid @Peter0x44 @wwderw Excuse my late response to the discussion. I was not aware about this option and most probably a project like raylib does not need it, still, I can't see any drawback on adding that option, just in case. I'm checking it right now...

@orcmid Just cheked the feature and I prefer to avoid a specific file in the repo, feel free to send a PR to add a two-lines note in the README as stated in previous comment.

I'm closing the issue, feel free to send a PR with the proposed addition.


Update schema-stitching.md

TODO:

[ ] If this PR is a new feature, reference an issue where a consensus about the design was reached (not necessary for small changes)
[ ] Make sure all of the significant new logic is covered by tests
[ ] Rebase your changes on master so that they can be merged easily
[ ] Make sure all tests and linter rules pass
[ ] Update CHANGELOG.md with your change. Include a description of your change, link to PR (always) and issue (if applicable). Add your CHANGELOG entry under vNEXT. Do not create a new version number for your change yourself.

Nope! Feel free to add that “s” yourself.
On Wed, Oct 9, 2019 at 12:43 meteor-bot<EMAIL_ADDRESS>wrote:

@antialias https://github.com/antialias: Thank you for submitting a
pull request! Before we can merge it, you'll need to sign the Apollo
Contributor License Agreement here: https://contribute.apollographql.com/
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/apollographql/graphql-tools/pull/1216?email_source=notifications&email_token=AADNIHKAMAKOCXFL3UZQYS3QNYX7RA5CNFSM4I7D53T2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEAZCYGY#issuecomment-540159003,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AADNIHON6XVV7ZCW7STNMGLQNYX7RANCNFSM4I7D53TQ
.

agreement signed. feel free to re-open and merge.


JSON decode on output

Since we have json encode on input, it might also be help for output, even via a separate function, although I would argue that REST is generally JSON, so parsing by default would be cool. Would it make sense to use a complete JSON lib, like dkjson?

I believe it is a nice idea, but I really don't wish to use a JSON lib for that, specially that Lua's table has many things in common with Js objects, I believe that should be possible to do in a few tens of lines

I use dkjson as an example because it is fairly simple, but complete & well-tested (or at least better than a few others.) An inline home-rolled json codec is fine too, I guess, my main point is that it seems weird to me to take a table (internally converted to json) as input, and output a string. Using a shared json lib also means it can be reused (like the other parts of this lib, for example, I use your module-loader in other things, it's very useful) so your users can encode/decode json in other places, in a fairly standard way. It's trivial for me to wrap every callback with json.decode from dkjson, so I can just do it there, it just seems like a surprising thing for users, to point out: "table in, string out". It's also not reusing the code for parsing/encoding as much as it should, so there are basically 2 implementations of json-encode, with no overlap between encode/decode. Since you already also do rudimentary JSON-encoding, it makes sense to me to use a lib, unless there is some big problem with dkjson.
I dunno, I am thinking about writing a request library that uses libcurl directly in a love-thread with FFI, so I'm not sure I will end up using REST-love, anyway. I need binary requests and some non-json text requests, and I'd rather share more logic between them, and make something that generally works the way I want.

Humm I think the string out is great, because it would create a situation that I would need to check if the output is really a json, if it is not, then there would be no output, which is a bug.
That could be solved by having an argument which receive a boolean to encode the string into a JSON.
I believe it would be great having a direct libcurl. I didn't do that at the time because I avoided doing complicated things at the project.
About having 2 implementations, this really worries me. That need to be took care of, please point out where you're finding (I haven't been programming Lua for a bit of time already)
So basically:
I believe that I could have versions for sending JSON or binary data. For both input and output

Humm I think the string out is great, because it would create a situation that I would need to check if the output is really a json, if it is not, then there would be no output, which is a bug.

My point is REST APIs generally do JSON in/out, and you are already assuming that for input, but not output. If it doesn't return anything, than that seems like a normal case for "something went wrong".
In lua, a common error pattern is the kind of thing pcall outputs:
data, error = myfunc()

similar could be done in callback.

That could be solved by having an argument which receive a boolean to encode the string into a JSON.

That seems like a good idea. I also don't mind doing my own encoding/decoding in another library, it just surprises me that they don't match.

I believe it would be great having a direct libcurl. I didn't do that at the time because I avoided doing complicated things at the project.

I will make it and shout out to your project, in the README.

About having 2 implementations, this really worries me. That need to be took care of, please point out where you're finding (I haven't been programming Lua for a bit of time already)

This is more a general programming thing, than anything specific to lua. I mean for end-users. Here is an example:
I use your REST library, it has it's own simple JSON encoder Since I also want to decode JSON, I import a library that does that (we'll just say dkjson, for example) and it already has json.encode so that is 1 bit of functional duplication, but if you look at it, it reuses a bunch of code between encoder/decoder, which means that by using your library I am duplicating more implementations of things (the initial encoder and also not reusing shared functions for encode/decode.)

Since you seem resistant to this idea, and I am not even going to have automatic json parsing in/out on my own library, that I'm actually going to use, I will close this issue. Obviously feel free to re-open it, if you want this enhancement.


How to setup, containerize and test a single Hadoop cluster using Docker and docker-compose

…-docker-compose
Article checklist
ATTENTION: In your PR - add the ISSUE (topic form) # that this PR corresponds to. You can do this by also adding a comment that states "This fixes #(enter your Idea Content Form #)" to link and close your Idea Content (issue) when the PR is merged.
NOTE: (Please ensure that you have only one open issue + linked pull request at a time. This will ensure that we complete the article in a timely manner from inception to publishing.)
If you have not already please go over our Resources Page for more tips and tricks on how to improve our overall technical writing.
Preliminary Checks - Formatting and Structure

[x] Does your article follow any of the suggested structure formats? - see example formats
[x] Is your article properly formatted in Markdown? - see Github Markdown guide
[x] Have you used the correct folder and file structure? - see Contribution Guidelines
[x] Is your article over 750 words? - Tool: Wordcounter.net
[x] Have you used our preferred heading structure? - H3 (###) and up
[x] Does your article provide enough value and detail about your topic? - Articles should be clear, accurate, and fully explained.
[x] Can your article be understood by beginners? - Assume the audience is smart but has no prior exposure to the common terminology in your article.
[x] Have you included a hero image that is 600x400 pixels and have the copyright to use it? - Tools: Pixlr Image Editor for resizing and Unsplash for Creative Commons images
[x] In your PR - add a comment that states "This fixes #(enter your Idea Content Form #)" to link and close your Idea Content (issue) when the PR is merged.

Grammar & plagiarism checks

[x] Have you spellchecked and grammar checked your article? - Tools: Write&Improve - ProWritingAid -  Grammarly
[x] Please place your article through a 3rd party plagiarism checker? We suggest using Quetext, this tool is free and has a daily limit. We typically accept articles with 10% or less.
[x] Have you checked your article for readability? - Tool: Hemmingway
[x] Have you added sources for quotes and images that aren't yours?

Technical checks

[x] Are your code snippets properly formatted for syntax highlighting - see Syntax guide

Contribution guidelines
For first-time contributors and for more details, see Contributing Guidelines
This fixes #2543

Hi @Antony-Prince Welcome to Section engineering program. We are pleased have you and congrats on submitting your first article successfully. I will be reviewing your article.
Before I continue with the review, you need to do a couple of thing first:

On the article checklist, it has indicated that you need to upload a hero image. Please do that. Make sure to save it as hero.jpg/hero.png etc. Also make sure it is 600px by 400px in dimension.
We need to create an author profile for you. Thus, you need to add a brief Author Bio (index.md file) and Headshot image (avatar file i.e., avatar.jpg). Include these files in the authors folder which is inside the 'contents' folder. This will help so that you can be credited for your hard work.

After you've finished that, I can proceed with the review.

Hi @Antony-Prince Welcome to Section engineering program. We are pleased have you and congrats on submitting your first article successfully. I will be reviewing your article.
Before I continue with the review, you need to do a couple of things first:

On the article checklist, it has been indicated that you need to upload a hero image. Please do that. Make sure to save it as hero.jpg/hero.png etc. Also make sure it is 600px by 400px in dimension.
We need to create an author profile for you. Thus, you need to add a brief Author Bio (index.md file) and Headshot image (avatar file i.e., avatar.jpg). Include these files in the authors folder which is inside the 'contents' folder. This will help so that you can be credited for your hard work.

After you've finished that, I can proceed with the review.

Hello @Bayler This is my second article, I had one published already

Oh. Thought it was your first. Sorry. You can add a hero image then

Oh. Thought it was your first. Sorry. You can add a hero image then

Added @Bayler

@Antony-Prince
"How to setup, containerize and test a single Hadoop cluster using Docker and docker-compose" is a much cleaner topic to use than the current one.
You can add the "What is Hadoop?" as a header inside your article instead. First start describing what Hadoop is then start on Hadoop clusters
cc: @hectorkambow

What is Hadoop?

Yeah, that reflects well. I have updated that @Bayler

Hi @Antony-Prince This was a nice read. I like the way you've explained concepts and provided outputs with supported image examples.
However, I need you to work on some few corrections before we can proceed for final review:

Please add a 'Table of contents' and 'Prerequisite' section. It is good practice to include this inside your article. Use this article as reference.
Once you're done with the corrections, please run your article on the Hemmingway App to ensure the readability of your article is up to par. Currently, it's way higher. (Aim for a 9)  or below.

After you're done, we can proceed for final review.

Hi @Antony-Prince This was a nice read. I like the way you've explained concepts and provided outputs with supported image examples.
However, I need you to work on some few corrections before we can proceed for final review:

Please add a 'Table of contents' and 'Prerequisite' section. It is good practice to include this inside your article. Use this article as reference.
Once you're done with the corrections, please run your article on the Hemmingway App to ensure the readability of your article is up to par. Currently, it's way higher. (Aim for a 9)  or below.

After you're done, we can proceed for final review.

@Bayler I have added a 'Table of contents' and 'Prerequisite' section.  My Hemmingway score is 7 when I use the previewed index.md output.

Hi @Antony-Prince This was a nice read. I like the way you've explained concepts and provided outputs with supported image examples.
However, I need you to work on some few corrections before we can proceed for final review:

Please add a 'Table of contents' and 'Prerequisite' section. It is good practice to include this inside your article. Use this article as reference.
Once you're done with the corrections, please run your article on the Hemmingway App to ensure the readability of your article is up to par. Currently, it's way higher. (Aim for a 9)  or below.

After you're done, we can proceed for final review.

@Bayler I have added a 'Table of contents' and 'Prerequisite' section. My Hemmingway score is 7 when I use the previewed index.md output.

Okay @Antony-Prince Let me check.

Hi @Antony-Prince This was a nice read. I like the way you've explained concepts and provided outputs with supported image examples.
However, I need you to work on some few corrections before we can proceed for final review:

Please add a 'Table of contents' and 'Prerequisite' section. It is good practice to include this inside your article. Use this article as reference.
Once you're done with the corrections, please run your article on the Hemmingway App to ensure the readability of your article is up to par. Currently, it's way higher. (Aim for a 9)  or below.

After you're done, we can proceed for final review.

@Bayler I have added a 'Table of contents' and 'Prerequisite' section.  My Hemmingway score is 7 when I use the previewed index.md output.

The readability is still at 11.

@Bayler you are checking the readability  using the MD format

Am using the rendered/ previewed MD output.

Am using the rendered/ previewed MD output.

@Antony-Prince I've noted where the discrepancy was coming in. Let me finalize the review.

plagiarism check done

Great tutorial, good job 🎉@Antony-Prince @Bayler.
Please keep in mind that your article should always have an introduction.


get_approve - not signing.

Was trying to approve busd spending with 1inch.   i made an extra function -> get_approve_with_contract   I dont like looking things up with token names because there can be duplicates.  Also removed the amount because amount is optional in 1inch api.
A missing amount = infinite.
    result = bsc_exchange.get_approve_with_contract(from_address=src,  decimal=decimal)  # get the swap transaction , AMOUNT + SLIPPAGE ARE FLOATS NOT STRING

{'data': '..............................ff',
 'gasPrice': '15000000000',
 'to': '0xe9e7cea3dedca5984780bafc599bd69add087d56',
 'value': '0'}

I tried to sign the tx  - even removed the build_tx piece to just sign and broadcast.
result = helper.build_tx(result)  # prepare the transaction for signing, gas price defaults to fast.
    pprint(result)
    result = helper.sign_tx(result)  # sign the transaction using your private key
    pprint(result)
    result = helper.broadcast_tx(result)  # broadcast the transaction to the network and wait for the receipt.
    pprint(result)

    def get_approve(self, from_token_symbol: str, amount=None):
        from_address = self._token_to_address(from_token_symbol)
        amount_in_wei = Decimal(amount * 10 ** self.tokens[from_token_symbol]['decimals'])
        url = f'{self.base_url}/{self.version}/{self.chain_id}/approve/transaction'
        url = url + f"?tokenAddress={from_address}&amount={amount_in_wei}"
        result = self._get(url)
        return result

    def get_approve_with_contract(self, from_address: str, decimal: int, amount=None):
        url = f'{self.base_url}/{self.version}/{self.chain_id}/approve/transaction'
        if amount == None:
            url = url + f"?tokenAddress={from_address}"
        if amount != None:
            amount_in_wei = Decimal(amount * 10 ** decimal)
            url = url + f"?tokenAddress={from_address}&amount={amount_in_wei}"
        result = self._get(url)
        return result

What error are you getting when you try sign?

Ah I think I see the issue - the approve/transaction endpoint doesn't include the "gas" parameter.
You will need to send your transaction via estimate_gas
something like (untested):
def build_tx(self, raw_tx, speed='high'):
        nonce = self.w3.eth.getTransactionCount(self.public_key)
        tx = raw_tx['tx']
        if tx['gas'] is None:
             tx['gas'] = self.w3.estimate_gas(tx}
        tx['nonce'] = nonce
        tx['to'] = self.w3.toChecksumAddress(tx['to'])
        tx['chainId'] = int(self.chain_id)
        tx['value'] = int(tx['value'])
        tx['gas'] = int(tx['gas'] * 1.25)
        if self.chain == 'ethereum' or self.chain == 'polygon' or self.chain == 'avalanche' or self.chain == 'gnosis':
            gas = self._get(self.gas_oracle+self.chain_id)
            # print(gas)
            # gas = requests.get(self.gas_oracle, params=self.chain_id)
            tx['maxPriorityFeePerGas'] = int(gas[speed]['maxPriorityFeePerGas'])
            tx['maxFeePerGas'] = int(gas[speed]['maxFeePerGas'])
            tx.pop('gasPrice')
        else:
            tx['gasPrice'] = int(tx['gasPrice'])
        return tx

Ok - I deep dived on this and I got to the end.   Had to make a few changes....   its a little complicated.

Using the get_approve failed on BSC and im not sure why but I added that _with_contract function as IMHO its more secure.

    def get_approve_with_contract(self, from_address: str, decimal: int, amount=None):
        url = f'{self.base_url}/{self.version}/{self.chain_id}/approve/transaction'
        if amount == None:
            url = url + f"?tokenAddress={from_address}"
        if amount != None:
            amount_in_wei = Decimal(amount * 10 ** decimal)
            url = url + f"?tokenAddress={from_address}&amount={amount_in_wei}"
        result = self._get(url)
        return result

build_tx -
a.     the 'to' needs to be above in order to convert the address to a proper checksummed address.
b.  The results of get_approval only provide the following so trying to match against tx['gas] is None will always fail because there is no key 'gas
      {'data': '0x095.......fffffffffffffffffffffffffffffffff',
        'gasPrice': '15000000000',
         'to': '0x8ac76a51cc950d9822d68b83fe1ad97b32cd580d',
         'value': '0'}

c.  self.w3.estimate_gas(tx) -> fails because it wants self.w3.eth.estimate_gas(tx)
I have accounted for a non-existant ['gas'] key and/or == None
Summary of build_tx changes.
def build_tx(self, raw_tx, speed='high'):
   nonce = self.w3.eth.getTransactionCount(self.public_key)
   # tx = raw_tx['tx']
   tx = raw_tx # ['tx']
   tx['to'] = self.w3.toChecksumAddress(tx['to'])
   if 'gas' not in tx:  ### TEST LINE
       tx['gas'] = self.w3.eth.estimate_gas(tx) ### TEST LINE
       print('tx[\'gas\'] RESULTS {}'.format(tx['gas']))
   if tx['gas'] == None:
       tx['gas'] = self.w3.eth.estimate_gas(tx) ### TEST LINE
       print('tx[\'gas\'] RESULTS {}'.format(tx['gas']))
   tx['nonce'] = nonce
   tx['chainId'] = int(self.chain_id)
   tx['value'] = int(tx['value'])
   tx['gas'] = int(tx['gas'] * 1.25)
   if self.chain == 'ethereum' or self.chain == 'polygon' or self.chain == 'avalanche' or self.chain == 'gnosis':
       gas = self._get(self.gas_oracle+self.chain_id)
       # print(gas)
       # gas = requests.get(self.gas_oracle, params=self.chain_id)
       tx['maxPriorityFeePerGas'] = int(gas[speed]['maxPriorityFeePerGas'])
       tx['maxFeePerGas'] = int(gas[speed]['maxFeePerGas'])
       tx.pop('gasPrice')
   else:
       tx['gasPrice'] = int(tx['gasPrice'])
   return tx
    ```

We are now at the broadcasting piece.   For somereason i am getting invalid sender and everything I can find points to chainId but that all looks correct.

Traceback (most recent call last):
  File "C:\Users\USER_USER\PycharmProjects\test_1inch_py\main.py", line 82, in <module>
    result = bsc_helper.broadcast_tx(result) #broadcast the transaction to the network and wait for the receipt.
  File "C:\Users\USER_USER\PycharmProjects\test_1inch_py\venv\lib\site-packages\oneinch_py\main.py", line 326, in broadcast_tx
    tx_hash = self.w3.eth.send_raw_transaction(signed_tx.rawTransaction)
  File "C:\Users\USER_USER\PycharmProjects\test_1inch_py\venv\lib\site-packages\web3\eth.py", line 831, in send_raw_transaction
    return self._send_raw_transaction(transaction)
  File "C:\Users\USER_USER\PycharmProjects\test_1inch_py\venv\lib\site-packages\web3\module.py", line 57, in caller
    result = w3.manager.request_blocking(method_str,
  File "C:\Users\USER_USER\PycharmProjects\test_1inch_py\venv\lib\site-packages\web3\manager.py", line 198, in request_blocking
    return self.formatted_response(response,
  File "C:\Users\USER_USER\PycharmProjects\test_1inch_py\venv\lib\site-packages\web3\manager.py", line 171, in formatted_response
    raise ValueError(response["error"])
ValueError: {'code': -32000, 'message': 'invalid sender'}

The data that is being packaged is shown below.  iVE MADE NO CHANGES TO broadcast_tx

{'data': '0x09.........ffffffffffffffffff',
'gasPrice':<PHONE_NUMBER>0,
'to': '0x8AC76a51cc950d9822D68b83fE1Ad97B32Cd580d',
'value': 0,
'gas': 27430,
'nonce': 1294,
'chainId': 56}

Thanks for working together with me on this.


cargo-valgrind reports "possibly lost" and "still reachable" as errors

..while valgrind doesn't unless you use --leak-check=full. This caused a bit of kerfuffle wrt. https://github.com/rust-lang/rust/issues/133574.
PS: valgrind --xml=yes --gen-suppressions=all doesn't seem to output suppressions which makes it really painful when you need to generate suppressions within cargo valgrind test.

Thank you for your report. Yes, currently this tool always sums the number of reported blocks. I understand, that this might not be, what all users want.
Ho would you like the output of the tool to be? Or do you suggest additional command line flags to toggle some behavior?

So the XML has elements like <kind>Leak_PossiblyLost</kind>, which can be used to filter out the different types. I think it would be good to match the default Valgrind behavior (which only reports "definitely lost", I think?), and to have a flag.
Ideally, VALGRINDFLAGS="--leak-check=full" would work to enable these back, but you can see why it won't.

--errors-for-leak-kinds=definite,indirect


Add help.text for the persist module tooling

Purpose
$subject. This PR is to add ballerina-persist.help file for the persist module tooling and add entry in ballerina-help.help file.
Approach

Describe how you are implementing the solutions along with the design details.

Samples

Provide high-level details about the samples related to this feature.

Remarks

List any other known issues, related PRs, TODO items, or any other notes related to the PR.

Check List

[ ] Read the Contributing Guide
[ ] Updated Change Log
[ ] Checked Tooling Support (#)
[ ] Added necessary tests

[ ] Unit Tests
[ ] Spec Conformance Tests
[ ] Integration Tests
[ ] Ballerina By Example Tests

[ ] Increased Test Coverage
[ ] Added necessary documentation

[ ] API documentation
[ ] Module documentation in Module.md files
[ ] Ballerina By Examples

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.1 out of 2 committers have signed the CLA.:white_check_mark: daneshk:x: Danesh KuruppuDanesh Kuruppu seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.

@Danesh Kuruppu build is failing can u check


Weird looking line in DomEvent.js (0.8.x master)

During my read-through of the Leaflet.js code, I spotted this line, that looks like a bug:
https://github.com/Leaflet/Leaflet/blob/master/src/dom/DomEvent.js#L14
if (typeof types === 'object') {
			for (var type in types) {
				this._on(obj, type, types[type], fn);
			}
		} else {
			types = L.Util.splitWords(types);

			for (var i = 0, len = types.length; i < len; i++) {
				this._on(obj, types[i], fn, context);
			}
		}

It's hard to tell for sure, since the on method does not seem to be included in the gh-pages documentation of 0.8.x.
If the second param is a map with different functions for each of the keys, why the last fn that would end up as a context for _on call.
Just saying check this. I may be wrong (in which case it would be good to mark the expected parameter types as a comment).

on is an alias for addListener, which is documented. However, this particular form of arguments isn't documented. It works like:
L.DomEvent.addListener(obj, {'click': this.onClick, 'dblclick': this.onDblClick}, this);

The third argument is the context. In the definition that's fn. So this isn't a bug, but the documentation is incomplete.

So.. is this okay to be closed?


[Feature Request] Support start an existing Glue job

Is your feature request related to a problem? Please describe.
I am hoping to use Prefect (a workflow tool) to trigger a Glue job aws-sdk-pandas in Python.
Describe the solution you'd like
It would be great to support trigger an existing Glue job, thanks! 😃
Describe alternatives you've considered
boto3 seems can do it based on this:
import boto3
from botocore.exceptions import ClientError

def run_glue_job(job_name, arguments = {}):
   session = boto3.session.Session()
   glue_client = session.client('glue')
   try:
      job_run_id = glue_client.start_job_run(JobName=job_name, Arguments=arguments)
   return job_run_id
   except ClientError as e:
      raise Exception( "boto3 client error in run_glue_job: " + e.__str__())
   except Exception as e:
      raise Exception( "Unexpected error in run_glue_job: " + e.__str__())

print(run_glue_job("run_s3_file_job"))

What would be the added value of using aws sdk for pandas instead of pure boto3 for this? We only consider new APIs if they interact with pandas data frames or build something that boto3 does not already offer. I don't see how triggering a Glue job fits this definition

Oh because all our services are built on this high level library aws-sdk-pandas, so I guess the benefit is one less low level dependency boto3?
But I get what you mean, thanks!


Translations Update, please integrate

Please pick up single translation correction

@rgeraghty not sure why it's not passing the CLA?

I'll close this as dxwalf utility account is causing issue, as not properly in git org, and resend with my own one, used previously


feat(backend): Introduce a new getOrganizationInvitation() method

Type of change

[ ] 🐛 Bug fix
[x] 🌟 New feature
[ ] 🔨 Breaking change
[ ] 📖 Refactoring / dependency upgrade / documentation
[ ] other:

Packages affected

[ ] @clerk/clerk-js
[ ] @clerk/clerk-react
[ ] @clerk/nextjs
[ ] @clerk/remix
[ ] @clerk/types
[ ] @clerk/themes
[ ] @clerk/localizations
[ ] @clerk/clerk-expo
[x] @clerk/backend
[ ] @clerk/clerk-sdk-node
[ ] @clerk/shared
[ ] @clerk/fastify
[ ] @clerk/chrome-extension
[ ] gatsby-plugin-clerk
[ ] build/tooling/chore

Description

[x] npm test runs as expected.
[x] npm run build runs as expected.

Introduce a new getOrganizationInvitation() method on the Organization resource, which you can use in order to fetch a single organization invitation by ID

This PR has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.


bug: Repeated unwanted output "trim copying"

Found in version v0.3.6
Not occurring in v0.3.5
Operating Systems: Mac Sonoma 14.1.1 and Ubuntu 22.04
Occurs both in terminal (mac and linux) and when using a terminal inside of a microsoft vscode environment.
Helm Version:
version.BuildInfo{Version:"v3.13.3", GitCommit:"c8b948945e52abba22ff885446a1486cb5fd3474", GitTreeState:"clean", GoVersion:"go1.20.11"}

When running unittest the following output is repeated over and over again.
2023/12/29 14:09:29 trim copying "headless"
2023/12/29 14:09:29 trim copying "annotations"
2023/12/29 14:09:29 trim copying "labels"
2023/12/29 14:09:29 trim copying "customStartupProbe"
2023/12/29 14:09:29 trim copying "nodeSelector"
2023/12/29 14:09:29 trim copying "global"
2023/12/29 14:09:29 trim copying "replicaSetConfigurationSettings"
2023/12/29 14:09:29 trim copying "configuration"
2023/12/29 14:09:29 trim copying "image"
2023/12/29 14:09:29 trim copying "containerPorts"
2023/12/29 14:09:29 trim copying "tls"

That is only a small sample.
I believe this has something to do with the default values file.
When I do NOT specify a values file or specify a path to a valid values file, these messages repeat over and over again.
When I put in an invalid path to a values file, the output does not occur.
Example where output occurs:
suite: Test deployment
templates:
  - deployment.yaml

suite: Test deployment
templates:
  - deployment.yaml
values:
  - values-required.yml

where values-required.yml is a valid file.
Example where it does not occur
```yaml
suite: Test deployment
templates:
  - deployment.yaml
values:
  - values-file-no-exist.yml

Output does not occur.
Downgrading to v0.3.5 seems to be my workaround.

already fixed on master - yet to release https://github.com/helm-unittest/helm-unittest/issues/237


“Cannot detect browser version.” Pop-up in Wrapped Browser in iOS Application

• Expected Behavior
No pop-up should be displayed when opening up the website.
• Actual Behavior
When opening up the website, “Cannot detect browser version.” pop-up shows up.
• Steps to reproduce
Open up the website in wrapped browser within iOS application (e.g. KakaoTalk).

Looks like the wrapped browser does not send UserAgent, which used to include browser's type and version information, properly. Rather than relying on UserAgent parsing, I will fix the code to check specific functionality with the method proposed by Mozilla Foundation.
Thanks for the bug report!!

Looks like the wrapped browser does not send UserAgent, which used to include browser's type and version information, properly. Rather than relying on UserAgent parsing, I will fix the code to check specific functionality with the method proposed by Mozilla Foundation.
Thanks for the bug report!!

Resolved!!

Resolved!!


fix(logger-plugin): log target port when router option is used

coverage: 97.68% (+0.04%) from 97.644%
when pulling 386453aeed99d4bd30b0ae08d4fcb0cd95e3b706 on fix-logger
into 4d3f5492a6ccbf8d9ec62e40a78f5417f75dd052 on master.


LeetCode 75 Qs in cpp

📥 Pull Request
Description
I have added the md files to this new PR
Fixes #453

Yes I will do the required changes

@ajay-dhangar I have made few changes does it look good?
Can I add more solutions in this way now?

Hello @ajay-dhangar can you please check this?

Thank you


cgo with multiple import syntax doesn't work

What version of Go are you using (go version)?

go version go1.12.1 linux/amd64

bug
build command: go build -buildmode=c-shared -o libhello.so hello.go
works
package main

/*
struct Vertex {
    int X;
    int Y;
};
*/
import     "C"
import    "fmt"

//export getVertex
func getVertex(X, Y C.int) C.struct_Vertex {
    fmt.Println()
    return C.struct_Vertex{X, Y}
}

func main() {}

doesn't work
package main

/*
struct Vertex {
    int X;
    int Y;
};
*/
import (
    "C"
    "fmt"
)
//export getVertex
func getVertex(X, Y C.int) C.struct_Vertex {
    fmt.Println()
    return C.struct_Vertex{X, Y}
}

func main() {}

error:
# command-line-arguments
_cgo_export.c:24:15: error: return type is an incomplete type
 struct Vertex getVertex(int p0, int p1)
               ^~~~~~~~~
_cgo_export.c:24:15: error: conflicting types for ‘getVertex’
In file included from _cgo_export.c:4:
cgo-gcc-export-header-prolog:44:22: note: previous declaration of ‘getVertex’ was here
_cgo_export.c: In function ‘getVertex’:
_cgo_export.c:30:17: error: field ‘r0’ has incomplete type
   struct Vertex r0;
                 ^~
_cgo_export.c:39:9: warning: ‘return’ with a value, in function returning void
  return a.r0;
         ^
_cgo_export.c:24:15: note: declared here
 struct Vertex getVertex(int p0, int p1)
               ^~~~~~~~~

Process finished with exit code 2

This is documented and expected.  The comment must immediately precede the "C" import.  If you like, you can write it like the following, although I don't particularly recommend it.
package main

import (
/*
struct Vertex {
    int X;
    int Y;
};
*/
    "C"
    "fmt"
)
//export getVertex
func getVertex(X, Y C.int) C.struct_Vertex {
    fmt.Println()
    return C.struct_Vertex{X, Y}
}

func main() {}

@ianlancetaylor ah sorry didn't catch that in the docs.


Other variants of Relu can be added in the script activation.py

I'm willing to add other variants of the Relu activation function for a wide range of applications of this package.

@parva-jain Sure you can work on it. Before that can you please give a brief description of what all you are going to add?

I have heard of Parametric Relu(PRelu) and Scaled ELU(SELU) functions but only able to find out their Keras implementation till now.
Also, there can be added more activation functions like a binary step function and a swish function.

@parva-jain sure go ahead, you can work on them. Make sure to follow PEP 8 formatting and correctness of your code.

LGTM too.


Create autoCreateMSEdu.js

Auto Create Account of MS Edu

Please add some features in this file then pull requests again
Thanks


Analytics for Dataviewer, Stories and Catalog?

This is somewhat related to https://github.com/leap-stc/leap-stc.github.io/issues/67. I think it will be very useful for us to have some metrics of who uses the catalog/dataview/stories and how.
The simplest metric would probably be visits to each site.
But in particular for the catalog, I would love to be able to tell which datasets are most visited/copied/shared. Is this achievable together with https://github.com/leap-stc/data-management/issues/136 @andersy005 ?

But in particular for the catalog, I would love to be able to tell which datasets are most visited/copied/shared. Is this achievable together with leap-stc/data-management#136 @andersy005 ?

i just made some changes to the catalog which will allow us to track individual feedstock cards. now users should be able to share links to individual cards (for example: https://catalog.leap.columbia.edu/#noaa-coastwatch-geo-polar-sst). these changes should be enough for us to get some metrics from Google analytics in the meantime.
i'll confirm whether this is working as expected or not by next week

Amazing! Is there a way to get a "share" button that creates such a link?

Amazing! Is there a way to get a "share" button that creates such a link?

Done! the latest deployment has a "share" button which copies the link to user's clipboard

i just made some changes to the catalog which will allow us to track individual feedstock cards. now users should be able to share links to individual cards (for example: catalog.leap.columbia.edu#noaa-coastwatch-geo-polar-sst). these changes should be enough for us to get some metrics from Google analytics in the meantime.
i'll confirm whether this is working as expected or not by next week

it appears this isn't working as expected :(.  i'm not sure if i've done something wrong but Google doesn't seem to record events associated with the anchors. I found this stackoverflow comment  which seems to confirm my suspicion.

In short, Google Analytics can't track on-page links containing a '#' character. A click on index.html#foo is treated simply as a click on index.html, with everything after the '#' ignored.

i'll investigate to see if there's any work around


Results of logged users

Hi !
The plugin works, I can now create or download new contents and add them in articles.
However, it seems it would be possible to register logged users's results. I can't do that. I tried with a logged in joomla user, results don't appear in "my results".
Is it joomla users ? Or h5p.org users ?
I do something wrong ?
Thanks for your helpful job !
Damien (sciphy.fr)

Hi!
In "My results" shows only all results of the currently logged in user in the admin panel.
To view the results of H5P content, you must use the link "Results" in the tab "All H5P Content".
No H5P users all are Joomla users.

Hi,
thanks ! It works !
I'd search more, sorry.


subTitle vs menuTitle

I am getting an issue after editing some of the files and recompiling.
It seems changing menuTitle to subTitle in your layouts/index.js file fixes the pages query
Any idea why?

@styks1987 I'm a little confused do you really wanted to say "fixes" not "breaks"?
Secondly, I need more details to say anything.

@greglobinski
My apologies. I found my issue. I deleted the starters page and so that removed the menuTitle which broke the queries.


Tweak RazorConfigurationFormatter to account for serialization format change

The recent FUSE changes updated the RazorConfigurationFormatter to write serialize/deserialize a new boolean. However, SerializationFormat.Version for MessagePack wasn't updated, so it just fails during deserialization when older project.razor.bin files are initially read off disk. This tweaks the deserializer to be more forgiving and handle the case that the boolean isn't present.
A similar change is not needed in the JSON serialization because that deserializer was written to be a bit more forgiving and the JSON SerializationFormat.Version was updated.
I ran into this when opening an old clone of OrchardCore that I'd opened previously, and started hitting exceptions during message pack deserialization.

Do we need to bump the version number? Thanks for fixing this, sorry I missed it! I didn't notice I only bumped the json version not the messagepack.
Also, is there a way we can catch this in the future?

Do we need to bump the version number?

I don't think so. The idea was to write this in such a way that the version number shouldn't need bumping. Bumping the version number has the consequence of needing to insert a new Razor for VS Code, so I try to avoid doing that unless absolutely necessary. Looking at the JSON serializer change, that actually probably didn't need a version number change, since the change used ReadBooleanOrFalse to returns false if the requested property doesn't exist. However, since the JSON serialization isn't actually used in product code to serialize RazorProjectInfo, the bump shouldn't really have an effect anyway.

Also, is there a way we can catch this in the future?

Honestly, it's kind of hard to catch. Nothing simple comes to mind. 😦


".editorconfig" that forces formatting to prevent too many changes

".editorconfig" that forces formatting to prevent the 100+ line "changes"
Originally posted by @rmcc3 in https://github.com/JonathanFly/bark/issues/44#issuecomment-1534573402

Something like this maybe?

[*]
end_of_line = lf
charset = utf-8
trim_trailing_whitespace = true
insert_final_newline = true
indent_style = space
indent_size = 4

[*.{diff,md}]
trim_trailing_whitespace = false```


Support for 0.14.0

update instructions for running presto locally in docker
use per-thread connections as implemented in 0.14.0
bump to use dbt v0.14.0
fix for "base" adapter macros which implemented unsupported SQL (replace ilike with the presto equivalent)

I ran the entire data pipeline successfully.
Thanks @drewbanin!

Great, thanks @rmgpinto! I'll get this merged and released on PyPi this week


Need clarification on ultra disk & OS disk

Hi Guys,
Thank you for the docs.
Today I was trying to understand is that possible to create VM with OS disk as ultra disk.
From the article, I was unable to understand is that possible at all, and if yes then how to.
Thank you.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 076b7e0e-8ca2-53fa-51f1-f1027f1d2da8
Version Independent ID: 4e99d739-6a5d-7b61-54c5-e5f1395e36d2
Content: Ultra disks for Windows VMs - Azure Managed Disks - Azure Windows Virtual Machines
Content Source: articles/virtual-machines/windows/disks-enable-ultra-ssd.md
Service: virtual-machines
Sub-service: disks
GitHub Login: @roygara
Microsoft Alias: rogarana

@yahorsi Thank you for your feedback . We will investigate and update the thread further.

@yahorsi Currently Ultra Disks cannot be used as OS disk for VM. You can check the details in this FAQ document.

Hope that answers your query.

@yahorsi
Hope the provided information is helpful.
We will now close this issue. If there are further questions regarding this, please tag me in a comment. I will reopen it and we will continue the discussion.


Add option in Visibility to not despawn entities when they stop being visible

Currently, visibility handling despawns/respawns entities.
We could have another mode where an entity that stops being visible just doesn't get any replication updates anymore (replication is suspended). The updates come-in again when the entity becomes visible again.

Wouldnt we need to re-replicate everything anyways?

@cBournhonesque Marker component perhaps?


Invite me to the GitHub Community Organization

Name
Sambhav Gupta
Discord Username (if applicable)
Sam07#7309
Additional Context
No response

hi

Hi, I already sent you the invite earlier in the day, and I see that you have joined the organization! Request you to please make the visiblity of this organization on your profile "public". you can do it on https://github.com/orgs/collab-community/people :)

-- https://discord.gg/PGadh3Vyuv
-- join our discrod community via above links
-- Connect with me on Twitter @twtadarsh
-- and do follow @collab__ on Twitter


iOS/SimpleDemo: Change settings to all archs as libffi is fixed

libffi now works for ARM 32-bit and 64-bit on iOS so JavaScriptCore / Seed no
longer crash.

Note that this needs a newer framework than 0.3.0 so we either need to move to the 0.3.1 cocoapod or wait.


Add actonc tests using Tasty

We have been using a Makefile to structure our tests for quite some time
now. Certainly better than nothing, but there are certainly improvements
too.
This is the first step towards better testing for actonc. We are now
using the Haskell Tasty package for running tests. It offers lots of
features, like nice compact output, parallel test execution, rich HTML
output and lots of other things.
The first couple of tests implemented are ports of the actonc project
build tests from the test Makefile.

@nordlander / @sydow FYI, if we want to add tests for the compiler, I think this is now a good place! These current tests are based on invoking actonc on .act files or projects, but we might just as well import some Haskell Acton module and run tests on low level functions if we want to. The sky is the limit!


Implement shell quote state

Bash scripts have quite complex quote state that sh doesn't implement in the parser fully, so we need to handle it in wordPart and unescape

I'm curious - do you have an example? I'm of course happy to hear ideas to improve the parser :)


[bug] Need to install protobuf library when run benchmark in docker

Hi there,
[Confgiuration]
xFasterTransformer version: 1.4.0
Docker version: Docker version 26.0.0, build 2ae903e
Kernel: 5.15.0
[Steps]
docker pull intel/xfastertransformer:latest
In docker container xfastertransformer run bash run_benchmark.sh -m llama-2-7b -d bf16 -s 1 -bs 1 -in 1024 -out 128 -i 10
[Description]
The new behaviour of LlamaTokenizer (with self.legacy = False) requires the protobuf library but it was not found in your environment.
pip install protobuf will resolve the issue, please help to install necessary library and update the docker image, thanks.

thx~ yizhan, we will fix it at the next release. @Duyi-Wang

protobuf will be added into requirements.txt by this PR #284 and in next docker release.


added proxy

Codecov Report

Merging #860 (acd3c58) into master (8f2edf4) will decrease coverage by 0.29%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master     #860      +/-   ##
==========================================
- Coverage   80.60%   80.30%   -0.30%
==========================================
  Files         132      133       +1
  Lines        4629     4647      +18
  Branches      102      105       +3
==========================================
+ Hits         3731     3732       +1
- Misses        898      915      +17

Impacted Files
Coverage Δ

...src/main/scala/com/ing/bakery/baker/ApiProxy.scala
0.00% <0.00%> (ø)

...pes/src/main/scala/com/ing/baker/types/Value.scala
70.58% <0.00%> (+1.17%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8f2edf4...acd3c58. Read the comment docs.


Link Events on Homepage to pull in data from new Events page

Currently the near.org logged-out homepage pulls in events data. Can we update the feed here to pull in the latest from the new Events page?
Currently it's showing past events:

@vanessadespain do you want it to only show upcoming events? Currently there is only one event so it would have just one square tile like this page - https://near.org/events. Or should we show upcoming and recent events?


Adds a new workflow to automatically publish releases

This workflow is triggered after the "Build Native Release Packages" workflow succeeds, and publishes a release that was created as a draft in the "Schedule Snapshot Release" workflow.
Sample workflow run at  https://github.com/not-jenni/iree/runs/3304500983?check_suite_focus=true, which generated https://github.com/not-jenni/iree/releases/tag/snapshot-20210811.29
The action will not run if any of the builds fail (tested in https://github.com/not-jenni/iree/runs/3304557762?check_suite_focus=true), and more thorough validation of the packages will be added soon.
This uses https://github.com/marketplace/actions/publish-release.
Progress on https://github.com/google/iree/issues/6315 and https://github.com/google/iree/issues/6316

oops, disabled automerge since I had some comments to address and it ignores those :p
lgtm once a few more builds are flipped to non-experimental


Hexagonal architecture

hexagonal-architecture: removed unused classes and files as per the review comment.

closing the pull request


Wipe out the cached script content if failed to read it

Fixes #7744, #7516 and https://github.com/Microsoft/TypeScript/issues/7668

:+1:


Solve permissions warning in aws-security-medium

Describe the bug
There's an AWS SecurityHub warning recurring in our aws-security-medium event stream.
Additional context

Last event was<PHONE_NUMBER>10, viewable in RC aws-security-medium
Bahram was doing some activity then

Definition of done

determine if that is a legitimate warning we wish to see
Test if resolving an issue in Security Hub appears in Rocket Chat
Determine and document a pattern for CPF operations to responsively handle events showing up in Rocketchat such that when we show SecOps, the audit trail is sufficient to satisfy

Not relevant anymore


add sources to pypi

Hi!
Can you please upload the source ti pypi server in addition to the wheel files? It can be useful for some use cases. Thanks in advance!

Hi shlomow,
Is it a tar.gz that you require?

@madchutney
Yes


New logo design for the project

Hello! I want to contribute on your project with making logo design. What do you think about it?
Best Regards,
Arslan Şahin
Graphics Designer

Sure if u want! Welcome!

https://drive.google.com/open?id=1JXPO89qn79_uunxTQsj-Wgh6iuHYkfL4
hello I did the logo work I hope you like:)

Could u upload image here as resource?

So...what the common with TextField and mask for phone? For this implementation just text on right side.

(Android library for EditText) Phone mask for Android. An option

I think the best logo is more meaningful above


Roll Flutter from d01b0f5d23f9 to 15163607b6fd (1 revision)

https://github.com/flutter/flutter/compare/d01b0f5d23f9...15163607b6fd
2022-05-07<EMAIL_ADDRESS>Roll Engine from 1ccb5ed131cb to 703682671a80 (1 revision) (flutter/flutter#103249)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-plugins
Please CC<EMAIL_ADDRESS>on the revert to ensure that a human
is aware of the problem.
To file a bug in Plugins: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Commit queue failed; closing this roll.


Wk modal fix

Description
Changed the modal width and heading size to fit better for mobile.
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes # (issue)
Type of change
Please delete options that are not relevant.

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

Testing Instructions
Please describe the tests required to verify your changes. Provide instructions so PR Tester can check functionality. Please also list any relevant details for your tests
Checklist:

[ ] My code follows the style guidelines of this project
[ ] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] My changes generate no new warnings
[ ] I have added test instructions that prove my fix is effective or that my feature works

It does fit better. H2 still run out of modal on smaller screen sizes. Maybe we can do font-size:7vw;?


Refreshing FileSystemCache blob urls does not work for linked CSS files

The title might not be right but here is some background:
This was noticed when implementing the image filters (https://github.com/mozilla/brackets/pull/694).
The project that can be used to test this is:
image-project.zip
STR:

Drag and drop the project's contents into your editor. Keep the index.html file open in the preview.
Switch to the buster.jpg file and apply a filter and hit "Apply".
Look at the preview. Watch the second image (which is an <img> tag with that image) change to show the filter. Also notice the first image (which is a div with a background-image property using that image) break and not show anything.

The reason that the first image breaks is because it is still referring to the old blob url of the image before the filter was applied.
After some debugging, here are my findings:

After saving the filtered image, we call FileSystemCache.refresh to refresh the blob url for the image in the cache. Then, we call LiveDevMultiBrowser.reload to reload the preview hoping that it will trigger a rewrite of the CSS to use the new blob url for the image. Looks like that doesn't happen.
FileSystemCache.refresh doesn't change the blob url of the CSS file according to https://github.com/mozilla/brackets/blob/master/src/filesystem/impls/filer/FileSystemCache.js#L26-L30
The LiveDevMultiBrowser.reload function eventually calls https://github.com/mozilla/brackets/blob/master/src/extensions/default/bramble/nohost/HTMLServer.js#L136 which finds that a CSS file is linked in index.html and hence calls https://github.com/mozilla/brackets/blob/master/src/extensions/default/bramble/nohost/HTMLServer.js#L116-L134 to get a blob url for style.css and replace it in the HTML. However, https://github.com/mozilla/brackets/blob/master/src/extensions/default/bramble/nohost/HTMLServer.js#L120 returns the old blob url for the CSS file (note above that the blob url for the CSS file does not change) and hence, the if check that follows evaluates to true and that same old blob url is used instead of rewriting the CSS file and generating a new blob url. That is why it breaks.

Chances are I probably used the wrong method of reloading the preview, but I'm not sure.
cc @humphd

I think this is the same bug we have when images aren't available if you have them selected when you first start the app.  When I was doing the SW live dev patch, I fixed that.  I can't remember all the details, but I might be able to back-port just that fix.  I need to look at what I did in #725.

No, I think what you're describing above is more than what I fixed, after re-reading.

Is this issue I'm having related: https://github.com/mozilla/thimble.mozilla.org/issues/2205


SAM adc driver not taking oversampling from the devicetree in the resolution calculation

Bug Description
When using the adc_raw_to_millivolts_dt function at line ~804~ 906 of the include/zephyr/drivers/adc.h file, the oversampling described in the devicetree is not applied. This results in an incorrect millivolt value.
I discovered this bug by debugging line by line and analyzing when the value became incorrect.
I am using the SAMD21 family, and to correct the problem, I added these lines of code:
/* Adjust resolution for oversampling */
if(spec->oversampling) {
    resolution += spec->oversampling >> 1U;
}

Note: This method of correcting the resolution works for this family because of the following table in the datasheet:

As you can see, an oversampling of 2 adds 1 bit of resolution, 4 adds 2, etc. That’s why I shifted one bit to the right to divide it by 2.
I have no idea if this will work with other microchip families.

This really does not seem like a generic problem, retitled and changed priority to low

The proposed "fix" is actually not solving the actual issue.
The SAMD21 ADC has an internal dividing mechanism which is partially automatic and partially manually to be set.
In detail: The ADJRES field in the AVGCTRL register has to be set according to the datasheet.
// adc_sam0.c:329
adc->AVGCTRL.reg = ADC_AVGCTRL_SAMPLENUM(sequence->oversampling);
switch (sequence->oversampling){
	case 0:
	case 1:
	case 2:
	case 3:
		adc->AVGCTRL.reg |= ADC_AVGCTRL_ADJRES(sequence->oversampling);
		break;
	case 4:
	default:
		adc->AVGCTRL.reg |= ADC_AVGCTRL_ADJRES(4);
}


[Feature Request] Ability to remove a device

Problem Description
I set up a second lock in the same config entry as my first lock but I don't see a way to remove it. When I go to the device I only have the option to "remove from zwave." Deleting the entity from the configuration doesn't seem to remove it.
Feature Description
An ability to open a device and "remove from lock code manager"
Anything else?
No response

have you tried going through the options flow? Settings > Devices & Services > Lock Code Manager
click on the entry then click on configure. At the top you can add and remove locks

Yep, when I do that the device sticks around.

do you see the code sensors when you click on the device you removed?

sensors disappear, just not the device


QueenPrimitiveTypeNode.java: Implement this method after m...

The puzzle<PHONE_NUMBER> originating from #49 has to be resolved:
https://github.com/jvmqueen/queen-of-java/blob/d869ce8f509dabc90e6b5ee96da851e6c6292425/src/main/java/org/queenlang/transpiler/nodes/QueenPrimitiveTypeNode.java#L68-L68
"Implement this method after making FieldDeclaration use this type.".
The puzzle was created by amihaiemil at 2023-01-05 18:53:25 +0200.
Estimation is 60 minutes.
If you have any technical questions, don't ask me, I won't be able to help. Open new issues instead.

Puzzle disappeared from the code, that's why I closed this ticket.

@amihaiemil thank you for resolving this ticket. I've just added it to your active invoice. You can always check all your invoices and more on the Contributor Dashboard.


Initial "2.0 upgrade guide" in docs

Migrated from GitLab: https://gitlab.com/meltano/meltano/-/merge_requests/2660
Originally created by @aaronsteers on 2022-05-22 01:33:47

Merge Request Checklist

[ ] Link to an issue
[ ] Include the proposed fix or feature
[ ] Include and update tests for the modified code
[ ] Include a documentation change
[ ] Add a CHANGELOG.md entry in the Unreleased section for any user-facing changes
[ ] Mention or assign a maintainer

Closes https://github.com/meltano/meltano/issues/3434

@afolson and @tayloramurphy - I'd like to go ahead and merge those so that other can continue to expand the list from here.

@aaronsteers Thanks for this! I don't think this was published yet because of the repo migration 😬
@pandemicsyn It looks like I can just change the repo this deploys from and keep the same settings. Do you know offhand if anything will explode? I'm willing to do science.

@afolson send it! Should just work™


Ids description

We can download JSONL file with markup information but unfortunately, there is some ids used: user id, label id. But there is no convenient way to receive information about user name from user id, label name from label id. But you are adding texts in the result even though there is text id in the result file.
Maybe, it would be more useful to return in JSONL file with markup information only ids but add an opportunity to download another file with information about such connections:
user id --> user name (for users which participated in a markup of the project)
label id --> label name
text id --> text

Please follow the issue template and refer the related (#295) issue before you raise an issue.


Link to migration guide is broken

Link to "Migrate from the SignalFx Tracing Library for JS" in the README is broken.

https://github.com/open-telemetry/opentelemetry.io/pull/626 is a blocker - we want the Open Telemetry registry to list all previously supported instrumentations.

Notify https://github.com/signalfx/signalfx-nodejs-tracing/issues/78 when this issue is closed.

https://github.com/open-telemetry/opentelemetry-js-api/issues/102 is a potential blocker.


Review the current code and identify areas that do not adhere to Go naming conventions and design principles.

**belongs to user story #417
What would you like to be done:
Review the current code and identify areas that do not adhere to Go naming conventions and design principles.
Why is this needed:
This is required for a later refactoring

Some identified areas of code improvement:

Functionize reconcile loops and add comments on functions:

The reconcile loops are the most important functions in the controllers and most of the functional/business cases for the ocm/mpas concept flow are defined here.
Almost all reconcile loops in controllers are written like scripts
Extract each important step to a function makes the flow easier to read, easier to review if somebody removes some code and each function can have comments on top to describe the functionality if required
Ideal implementation: https://github.com/open-component-model/mpas-project-controller/blob/main/controllers/project_controller.go#L110
PoC like code: https://github.com/open-component-model/ocm-controller/blob/main/controllers/componentversion_controller.go#L192

https://github.com/open-component-model/ocm-controller/blob/main/controllers/resource_controller.go#L173
https://github.com/open-component-model/mpas-product-controller/blob/main/controllers/productdeploymentgenerator_controller.go#L176 (230 line function)
https://github.com/open-component-model/mpas-product-controller/blob/main/controllers/validation_controller.go#L79
to name a few

Improve state handling in reconcile loops: The expected states of the CR should be specified as a comment on the reconcile functions and specific state handling should be done in functions explaining which state it solves. Eg:

Improve/document controller design requirements:

Add contract interfaces with functions which are compulsory to implement for controllers. Eg. All controllers have the SetupWithManager(), Reconcile(), reconcile() functions
Improve stalled condition handling by following a uniform approach across controllers. Some controllers handle the stalled condition without explicitly setting it. So where is the stalled state coming from?
Define clear engagement rules between {status: True, Ready: True, Reason: Succeeded, Message: }, {status: False, Ready: True, Reason: Knownerror, Message: } ...

@shivenduverma-sap , I created the following items as follow up to your input. Please check if those are ok and carry your intention:
https://github.com/open-component-model/ocm/issues/455
https://github.com/open-component-model/ocm-controller/issues/240
https://github.com/open-component-model/ocm-controller/issues/241
https://github.com/open-component-model/ocm-controller/issues/242
The last three are referenced in the user story https://github.com/open-component-model/ocm/issues/417


Update run to current runtime

Or do you want to create a 2021 repository?

nah, this is okay, thanks


[BUG] Custom sub categories and playlists don't appear in Viewer after april 2020 content refresh

Describe the bug
I am a consultant creating content for a customer in their learning path installation. I have created  additional customer specific content as 4 custom sub categories under the "Scenarios" category. Two of these were visible with playlists underneath and all worked well.
After the april 20 content update, custom created sub categories in their installation no longer show in the LearningViewer, despite having the eye icon enabled. They were visible prior.
Clicking the eye on or off changes the icon but CustomLearningViewer still refuse to show them.
I created a new subcategory and moved a playlist to it from the old one. That one shows up in the CustomLearningviewer. I then shifted the remaining playlists over, but they do not show (i.e. only the first playlist shows, the others do not appear in the viewer). This looks strange as there is no hide/show playlist feature, so it only shows 1 out of 5 in the category.
I attempted to do the same with one other sub category and the new sub cateogry one does not show, thus I cannot see the playlists either.
To Reproduce

Steps to reproduce the behavior

Expected behavior
I would expect existing content to be preserved and new and existing sub categories to show, as well as all the playlists in them.
Screenshots

Learning Pathways version number
<IP_ADDRESS>
Additional context

Add any other context about the problem here.

Btw, I have seen comments about caching, so I cleared browser cache and navigated in the same tab between admin and viewer.

This seems related to the issue of not having a value for Technology. When adding technology, the playlists appear, thus the subcategories appear.
Given the version number they seem to have though, it is a bit strange that this issue should still be there.

Yep, based on the responses there is absolutely a bug here.  Thus far I haven't been able to reproduce it or find someone willing to work with me on it. It can be fixed by setting a technology but you absolutely shouldn't have to do that. If you're willing to help let me know.  What would be an interesting test, if you set the technology and then set it back to blank what happens?  Just to be clear the content update shouldn't have anything to do with anything... so it's somewhat odd issue.

I dove into the source code and validated that as long as the playlists technology is a null length string (aka "") the playlists should show up, this was the implemented fix.  Is there any way you can share the JSON from a playlist that isn't showing up in the web part? Ideally, can you make sure you're using the view full of the webpart, a good place to easily get to this is by using CustomLearningViewer.aspx.

I will happily share anything that would help. I am only using CustomLearningViewer.aspx page.
I confirmed that I need to have a value for Technology for the playlists to show up in the customer environment.
Of course, murphys law strikes again. I went to the customer to grab the json today and of course, now the problem isn't occurring and I cannot reproduce it. Nevertheless here is the json of a previously affected playlist:
{"Id":"20","Title":"Bli kjent med Learning Path (norsk)","Image":"https://pnp.github.io/custom-learning-office-365/learningpathways/v3/images/playlists/playlist_bw.png","LevelId":"f800c81b-ba2b-4b0f-9de5-3d42a0f45202","AudienceId":"28583661-f6fe-4ddb-b50f-fc73a20d3ae7","TechnologyId":"","SubjectId":"","Source":"Tenant","CatId":"50ab3b48-958e-4fdf-bc4a-f1ee9c05a844","Description":"Learning Path er et unikt nytt kurssystem i SharePoint som består av en blanding av innhold fra Microsoft og CustomerName. \nI dette intro-kurset blir du litt kjent med hvordan du navigerer i kursene og modulene. ","StatusTagId":"","StatusNote":"","Assets":["24"]}
I am now able to see custom subcategories containing a playlist without technology applied to the playlist inside. The playlist in question was never assigned a technology.
I then went to a playlist and removed the technology from it and it too appears in the subcategory, though it seems sorting is "technology, name" ascending? Or, the de-technology-fied playlist appeared before the ones with technology set, and when I added tech back to it, it went back to its original place.
I will look out for this occurring again elsewhere and attach any data that is of use then. :)
We have Learning Pathways in our own tenant, at the same version, and I was not able to reproduce their problem there, which is when I opened this issue in case there was some kind of cache or manual procedure that could be done.

Hmm, well... this does support that the bug was fixed.  Is it possible the order of operations was that you upgraded to 3.0.4 after the April content release -- total shot in the dark. The only other idea is that the cached manifest wasn't updated properly by whoever hit the instance of the viewer web part after the update was dropped and the cache expired. When learning pathways installs it sets the access to the custom config list for everyone to have edit/contribute permissions so maybe that's the problem.
Also, is it possible that in this step:

After the April 20 content update, custom created sub categories in their installation no longer show in the LearningViewer, despite having the eye icon enabled. They were visible prior.
Clicking the eye on or off changes the icon but CustomLearningViewer still refuse to show them.

You just had two tabs open and were doing things in the admin and not "reloading" the page with the viewer web part on it. Once the page loads just because you hit the admin web part the viewer web part doesn't pick up any changes until after you reload it so it can load the cached metadata again. We're not using WebSockets technology so you have to refresh the page to see any changes made in the admin web part.

Unfortunately, I have no control over this customer's environment. I am admin in our tenant, but while they have provided me with a user in their tenant, it has limited access in their environment (Site member in the learning pathway site), so all is limited to what I can ask them to look up for me and what I can sleuth my way to myself.
I asked them what version they have, so I wouldn't rule out that they went ahead and updated then? I have been careful based on reading other similar threads to avoid the two tabs problems. I lean towards them perhaps updating the solution post the april refresh.

You just had two tabs open and were doing things in the admin and not "reloading" the page with the viewer web part on it. Once the page loads just because you hit the admin web part the viewer web part doesn't pick up any changes until after you reload it so it can load the cached metadata again. We're not using WebSockets technology so you have to refresh the page to see any changes made in the admin web part.

I believe it was more related to the fact that a subcategory without playlists don't appear, so subcategories with playlists without a technology set would behave like a subcategory without any playlists at all.

@juliemturner @tomrune
I'm having this same issue. Created a new subcategory, created new assets to make a playlist, the playlists are not visible with no eye icon.
I've added a technology to both the playlist and the new assets, still not visible. I've removed the technology from the playlist and the assets, still not visible.
Yesterday they weren't visible. I closed all browser windows and opened, and voila! they were visible. But gone back in today and they are not visible again.

First let me please ask that no one continue to talk about their related issue on a closed issue. These things can easily fall through the cracks.  If you're experiencing a similar issue please open a new issue and feel free to reference by using the #{issue #} reference.
Happy to help here @foxward, if you could start your own issue that would be useful, please make sure you're using the latest version.  Also, closing the browser windows is not required but refreshing the page is as the cache is in a list item and there is no "push" that the item has been updated, you must initiate a pull by refreshing the page... long story short if you change something int he admin web part you need to refresh the viewer web part to see it.  Also, you want to double-check that you've not hidden any technologies and are then applying those hidden technologies to your playlists or assets.


For every section of the SnarkyJS, link to the relevant section of the docs (if helpful)

E.g.

https://docs.minaprotocol.com/en/snapps/how-snapps-work#deploying-a-smart-contract

docs restructure in place since this issue was created


LineNr is relative to view, should it be the absolute line number?

If it was the 'unfiltered' linenumber you could tell that messages are 'missing' / filtered.

@djeedjay: any thoughts?

What if user could toggle this, show either absolute or relative to view.


Indexing into EagerTensor returns zeros (on Windows with CUDA)

System information

Have I written custom code (as opposed to using a stock example script provided in TensorFlow): YES
OS Platform and Distribution (e.g., Linux Ubuntu 16.04): WIN 10 LTSC BUILD 17763
TensorFlow installed from (source or binary): BINARY - https://pypi.org/project/tensorflow/2.3.0/
TensorFlow version (use command below): 2.3.0
Python version: 3.6.8
CUDA/cuDNN version: 10.1, CUDNN 7.6.5
GPU model and memory: Quadro M2000M, 4096MiB

TF 2.0: python -c "import tensorflow as tf; print(tf.version.GIT_VERSION, tf.version.VERSION)"
v2.3.0-rc2-23-gb36436b087 2.3.0
Describe the current behavior
Specifically on this Windows system, with CUDA enabled (not happening w/ os.environ["CUDA_VISIBLE_DEVICES"] = "1", and not happening on my Linux system at all), reading a tfrecord with tf.data.* returns an EagerTensor which attempting to index results in incorrect zero output.
Describe the expected behavior
Indexing into the EagerTensor should return the correct output!
Standalone code to reproduce the issue
Gist: https://gist.github.com/optiluca/ff34d153c9ff339adedf5f905cdc8240
On a working system the output is:
tf.Tensor([100. 105. 110. 115. 120.], shape=(5,), dtype=float32)
100.0
100.0
On my windows system:
tf.Tensor([100. 105. 110. 115. 120.], shape=(5,), dtype=float32)
0.0
100.0

Managed to submit this twice, closing this one


Adding documentation for style guide, contribution and getting started

I would recommend looking at the actual repo instead of the files_changed, since Markdown diffs are hard to parse (for me, at least).


Unreachable production in Swift grammar

Location
https://docs.swift.org/swift-book/documentation/the-swift-programming-language/summaryofthegrammar/
Description
Under "Grammar of a declaration" there is a production:
declarations -> declaration declarations?
There exists no path to reach this production.
That is to say, there are no other productions where declarations appears on the right hand side, nor is declarations the top-level entry point for the grammar.
Therefore, this production is unreachable.
Correction
This production should be removed from the grammar.

The old definition of 'enum-body' used 'declarations' — it looks like this was left behind during a refactoring.
https://github.com/apple/swift-book/blob/main/TSPL.docc/ReferenceManual/Declarations.md?plain=1#L1816
enum-declaration -> attribute-list-OPT ``enum`` enum-name generic-parameter-clause-OPT type-inheritance-clause-OPT enum-body
enum-name -> identifier
enum-body -> ``{`` declarations-OPT ``}``


Library "ListBlobItem" Automatically Import

When I type the above-mentioned code in VS code, the requisite library "com.microsoft.azure.storage.blob.ListBlobItem" can not be imported automatically. Why not remind the learners with a small tip here. In another way, can we merge the imports as below.
Original:

Modified:

It's not recommended to use asterisk in import in order not to import unused classes.


Refactor some pow functions

This moves special diff adjustment rule out DGW (cause it has nothing to do with the algo itself) and refactors GetNextWorkRequired (adding missing asserts, reordering things in a more natural way). Should have no changes in actual behaviour.

The first of them was introduced in https://github.com/bitcoin/bitcoin/commit/972714c95687eda3afc209d62e0ed32fd50eef31 which we backported as part of btc0.15 but it changed GetNextWorkRequiredBTC only. I'm just applying the same logic ("Assert all the things!") to Dash specific code and making one more step here (i.e. checking pblock too).


IE8 response 406 error

Hi Danial, when I tried to do file upload in IE8, it was able to successfully upload the file but for some weird reason the response that I got from my server is 406 error even when there is no exception in my Java app server:
IOErrorEvent type="ioError" bubbles=false cancelable=false eventPhase=2 text="Error #:[IOErrorEvent type="ioError" bubbles=false cancelable=false eventPhase=2 text="Error #2038.
Have you ever seen such error? Below is the error that I put in Javascript alert:

What the response from your server looks like? Do you return any body in your response from the server?

I returned a JSON like the following:
{"success":true,"messages":[],"vault":null,"artifact":null}

Nevermind, this is a server side error. For some weird reason my Java Spring MVC framework is responding differently when Flash do file upload vs. just using HTML5 FormData. I used to return plain Java object and Spring MVC will automatically convert to JSON. When Flash is doing upload, for some weird reason the JSON converter failed. As a work around, I manually convert the Java object to JSON instead of relying on Spring MVC. thanks anyway.


Can't catch error after phantom is killed

Expected behavior
I'm searching the way to catch the error which is thrown while trying to use phantom after killing it. May be there is some kind of http://phantomjs.org/api/phantom/handler/on-error.html (if it is helpful) which is not referenced in the docs?
Actual behavior
If I try to use phantom after doing phantom.exit() I receive
events.js:154
      throw er; // Unhandled 'error' event
      ^

Error: read ECONNRESET
    at exports._errnoException (util.js:890:11)
    at Pipe.onread (net.js:550:26)

As you can see in the following code, I'm trying to catch the error in several places, but it does not work
Steps to reproduce the behavior
var phantom = require('phantom'),
    ph = null,
    sitepage = null,
    navigate;

try {
  phantom.create()
    .then(function(phInstance){
      ph = phInstance;
      ph.createPage().then(function(page){
        sitepage = page;
        navigate();
      })
    })
    .catch(function(e){
      console.log('PHANTOM.CATCH CAUGHT AN ERROR');
      console.log(e);
    });

  navigate = function () {
    sitepage
      .open('http://google.com')
      .then(function(){
        ph.exit();
        sitepage.evaluate(function(){
          console.log(11);
        })
      })
      .catch(function(e){
        console.log('PAGE.CATCH CAUGHT AN ERROR')
        console.log(e)
      })
  }
}
catch (e) {
  console.log('TRY/CATCH CAUGHT AN ERROR');
  console.log(e);
}

Environment

OS: Ubuntu 15.04 x64
Node version (node -v): node v5.10.1 (npm v3.8.3)
package version: 2.1.2

Hmm interesting. This error is being thrown INSIDE phantomjs. So I am not even sure if it is possible to capture it. Do you only care about catching #exit() or any error?

Well, my main concern is catching #exit() error. But now I can see, that if I for example throw from here:
      ph.createPage().then(function(page){
        sitepage = page;
        throw new Error('Custom Error');
        navigate();
      })

nothing happens.
The same is for this:
  navigate = function () {
    throw new Error('Custom Error');
    sitepage
      .open('http://google.com')

Not sure if this is connected somehow, but looks weird to me as well.

I am not sure what you are doing. But when I do
var phantom = require('phantom');

phantom.create()
   .then(function(phInstance){
     throw Error("error here. boo.");
   })
   .catch(function(e){
     console.log('PHANTOM.CATCH CAUGHT AN ERROR');
     console.log(e);
   });

I do see
PHANTOM.CATCH CAUGHT AN ERROR
Error: error here. boo.
    at Error (native)
    at /Users/amir.raminfar/Desktop/test_phantom/errors.js:5:12
    at process._tickCallback (internal/process/next_tick.js:103:7)
    at Function.Module.runMain (module.js:577:11)
    at startup (node.js:160:18)
    at node.js:445:3

Yep, from there I'm seeing it too.
But from here:
  var phantom = require('phantom'),
  phantom.create()
    .then(function(ph){
      ph.createPage().then(function(page){
        throw Error("error here. boo.");
        navigate();
      })
    })
    .catch(function(e){
      console.log('PHANTOM.CATCH CAUGHT ERROR');
      console.log(e);
    });

It throws nothing

That's obvious. You need to have a catch for #createPage()'s Promise. You probably want to chain it instead. If you get on the slack page, it would be easier. But you want do chaining of promise calls. Which is on the README.


Add certificate verification

See https://urllib3.readthedocs.io/en/latest/user-guide.html#certificate-verification
Fixes https://github.com/zchee/deoplete-docker/issues/1

Please merge? It's unusable at it's current state...

@zchee merging this would be amazing

Ooh, @joaosa maybe an even better way would be to follow the pattern this plugin uses for its urllib3 dependency?
Specifically, I think it's just:

[ ] Add https://github.com/certifi/python-certifi as a submodule
[ ] Load certifi similar to how this plugin loads urllib3 here: https://github.com/zchee/deoplete-docker/blob/20873fa1921395752b34da812c067f8ed82c6e57/rplugin/python3/deoplete/sources/docker.py#L10

@modille

Add certifi/python-certifi as a submodule
Load certifi similar to how this plugin loads urllib3 here:

Correct! could you send pull request if you have time?


Better Developer Experience

Hey, huge fan of this library. I'm using it in my programming language, vicuna. However, there are some issues that I've started experiencing. It seems like the library uses a lot of traits and complicated types, which leads to massive, massive type errors. Like...really really big errors.

Normally I can stare at the code and reason it out without the actual error message, but it does make things more challenging.
More importantly, these complicated types seem to really affect IDE performance. Like to the point where Intellij and RustRover are not usable on my M1 Macbook Air. Intellij will struggle along, but RustRover straight up crashes or freezes. Granted, that's partially an issue with RustRover being alpha software.
It appears that you're planning a 1.0 release. I'd only ask that developer experience be considered alongside other concerns. Also, happy to help in any way possible!

Hey, sorry about that. Unfortunately a lot of this sort of thing is unavoidable: you just end up with very large types when dealing with combinator APIs. This is also a problem for Rust's Iterator trait and the types that implement too, for what it's worth.
That said, there are specific things you can do to radically improve your experience. Take a look at the recommendations in the Getting Started section of the guide.
Really, making these errors tractable requires more to be done upstream in rustc itself. There are quite a specific specific things that I think rustc needs to do to improve outputs for these sort of APIs. Things are improving though, if slowly!

this could also be closed

With in-library Rust diagnostic customisation attributes being slowly stabilised, I'm going to keep this open. It's still an issue, even if it's one that feels difficult to solve entirely.


tools: Added '-B' flag for mvn current version cmd (#2910)

maven command for finding current version might need to download packages and without batch mode it will end in variable. Added '-B' to enable batch mode.
Description
Added '-B' to enable batch mode in maven command for find current version maven command in cloudstack/tools/build/setnextversion.sh shell script.

Since the change is in the release script and Travis passed, we don't need smoketests for this. Merging now.


Addition: Parsing Config Settings from a TOML file

This pull request adds the feature that allows the user to specify the CLI arguments in a TOML config file and resolves issue #8
Checklist

[x] Make the function to find and read the TOML file
[x] Make the functionality to load and use the variables from the TOML while the CLI binary is being called
[x] Documentation has been updated to reflect changes
[x] Example TOML file has been added

Hello @Kannav02,
Thank you for your contribution! I have fetched and tested your logic, the base functionality is good, but there are a couple of minor issues that I wanted to highlight.

I think the implementation of find_toml() function can be changed to search for the .toml file in users' home directory (e. g. "C:\Users\username") instead of the current directory, so they won't have to worry about putting the config file in their current working directory every time that want to use the tool.

find_toml() can also be changed to look for a specific file instead of any config file ending with .toml (in case users have other .toml files in their home directory).

Using standard Windows path single backslashes (\) when specifying the location of the context file causes parsing errors, as tomllib seems to treat those as escape characters. So Windows users would have to specify the paths with double backslashes (e. g. context = "examples\\commented.py" vs. context = "examples\commented.py"). Just something that would be helpful to mention in the tool's docs.

sure! i will make implement these changes, thanks for the feedback

Hey @arilloid
I've made the changes that you had asked for
thank you!

Thank you for your contribution!
I have tested and merged the changes.


RemoteResource downloads sometimes fail

:thinking:
Traceback (most recent call last):
   File "/opt/venvs/drakcore/lib/python3.7/site-packages/drakcore/process.py", line 86, in process
    outputs = plugin.handler(self.current_task, task_resources, self.minio)
   File "/opt/venvs/drakcore/lib/python3.7/site-packages/drakcore/postprocess/log_index.py", line 58, in generate_log_index
    with resource.download_temporary_file() as tmp_file:
   File "/usr/lib/python3.7/contextlib.py", line 112, in __enter__
    return next(self.gen)
   File "/opt/venvs/drakcore/lib/python3.7/site-packages/karton2/resource.py", line 282, in download_temporary_file
    self.download_to_file(tmp.name)
   File "/opt/venvs/drakcore/lib/python3.7/site-packages/karton2/resource.py", line 257, in download_to_file
    self._minio.fget_object(self.bucket, self.uid, path)
   File "/opt/venvs/drakcore/lib/python3.7/site-packages/minio/api.py", line 691, in fget_object
    raise InvalidSizeError(msg)
 minio.error.InvalidSizeError: InvalidSizeError: message: Data written 30748 bytes is smaller than the specified size 31171 bytes

See #170


怎么在cmakelists里导入brpc

add these lines into your cmakelists file
find_package(OpenSSL REQUIRED)
find_library(BRPC_LIBRARY libbrpc.a brpc)
message("-- Found ${BRPC_LIBRARY}")
find_library(LEVELDB_LIBRARY leveldb)
message("-- Found ${LEVELDB_LIBRARY}")
find_package(ZLIB REQUIRED)

# Look in thirdparty prefix paths before anywhere else for system dependencies.
set(CMAKE_PREFIX_PATH ${BRPC_THIRDPARTY_DIR} ${CMAKE_PREFIX_PATH})

# set BRPC_THIRDPARTY_DIR to where you place brpc.
set(BRPC_THIRDPARTY_DIR ${CMAKE_CURRENT_SOURCE_DIR}/brpc/output)
include_directories(${BRPC_THIRDPARTY_DIR}/include)

If my brpc location is '/usr/local/brpc', how should I make my makelist.
error info:
-- Found BRPC_LIBRARY-NOTFOUND


Fixed #11097 -- Added note about parent link fields in formsets for multi-table inheritance models.

https://code.djangoproject.com/ticket/11097
I'm not sure how much it's worth saying about this - while the example in the ticket is excellent, I think it might be a niche enough situation that it just needs notes. I've added two notes, one on each of the related features, but I think perhaps one is sufficient. If people disagree I'm happy to add the example as a whole section.
Edits/suggestions very welcome, I'm new to editing the Django docs.

@veryhappythings Thanks for preparing a patch for this 10 years :older_man: :older_woman:  old ticket :+1: I left a note in the formsets documentation, moved it to the "Model formsets" section (because all formsets are affected not only inline formsets), and pushed minor edits.

:+1: Looks good to me.
I know right, 10 years old! I was surprised that it was even still valid, but it turns out it still works this way :D

It was the oldest open documentation ticket :rocket:  Feel-free to grab more of them :+1:


Update neo4j search extraction query to query less rows

Summary of Changes
Adds WITH clauses to the tag selects. We had issues with the current extraction query timing out occasionally in production. I see in staging that this ends up hitting about the db about half as often, but the time to run is about the same so I'm not sure this will fix the issue effectively.
Tests
N/A
Documentation
N/A
CheckList
Make sure you have checked all steps below to ensure a timely review.

[ ] PR title addresses the issue accurately and concisely. Example: "Updates the version of Flask to v1.0.2"

In case you are adding a dependency, check if the license complies with the ASF 3rd Party License Policy.

[ ] PR includes a summary of changes.
[ ] PR adds unit tests, updates existing unit tests, OR documents why no test additions or modifications are needed.
[ ] In case of new functionality, my PR adds documentation that describes how to use it.

All the public functions and the classes in the PR contain docstrings that explain what it does

[ ] PR passes make test

Not moving forward with this version of the query.