Changes for Type Hinting

I made Bet an Abstract Base Class (ABC) since I think that better represents that it is an Abstract class that is not initialized directly.
I added total and result attributes to the init method of Dice so that those variables are initialized prior to roll or fixed_roll being run.
Then I added Type Hinting to all of crapssim for better documentation of methods and for easier error checking of misstyped parameters or variables. This passes the mypy check I ran on it.
I also used PyCharm's Optimize Imports function to optimize the imports.
This passed all tests in the tests module.
I also did some of the TODO's that were in there (should have done these separately but still getting the hang of Github stuff.):

I fixed the check in the table if there are no players and it tries to Run. Previously it added a player with None strategy which didn't work, now it adds a player with the default strategy.
I changed it so if a bet is already on the table it just adds to that bet instead of appending a new bet.
I changed player so if a bet is not removable it doesn't remove the bet.

I added new tests for all of these things and they all passed the previous tests.

Thank you for all of these contributions!  I'm sorry that I'm just seeing them now—not sure why Github didn't notify me of a pull request on here.
Given the extensiveness of the changes, I want to do some checks of my own, but these all look like good improvements on first glance.  I'll follow up shortly after review.

Other than my comment above, I think all of this is super great.  Thank you!  I will merge into dev after the discussion about it


feat: hidden the option for plain http

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

[ ] N
[x] Y

re #289

2. What is the scope of this PR (e.g. component or file name):

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

[x] Affects user behaviors
[ ] Contains syntax changes
[ ] Contains variable changes
[ ] Contains experimental features
[ ] Performance regression: Consumes more CPU
[ ] Performance regression: Consumes more Memory
[ ] Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

[x] N
[ ] Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

[x] Unit test
[ ] Integration test
[ ] Benchmark (add benchmark stats below)
[ ] Manual test (add detailed scripts or steps below)
[ ] Other

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

13 of 15 (86.67%)  changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.07%) to 39.607%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

pkg/downloader/source.go
0
2
0.0%

Totals

Change from base Build<PHONE_NUMBER>:
0.07%

Covered Lines:
2940

Relevant Lines:
7423

💛  - Coveralls


Must signed.version be incremented every time a role is re-signed?

Description of issue or feature request:
After reading the TUF specification and studying the basic_repo.py example, one thing remains unclear to me:

When exactly do we need to increment signed.version?

It is clear that we need to increment the signed.version after e.g. adding a new target, as detailed in the basic_repo.py example.
However, what if we only modify signed.expires, after a role has expired, without changing anything else? Do we also need to increment signed.version in that case? That would imply e.g. the version of timestamp is incremented every time it is re-signed.
In general, do we need to increment  a role's signed.version every time we re-sign that role, without exception?
Current behavior:
It is not explicitly clear from the documentation when signed.version needs to be incremented.
Expected behavior:
It would be very helpful if the documentation/specification could clarify this point explicitly.
Perhaps the basic_repo.py example could also show a snippet where an expired timestamp is re-signed (without any changes to the root, targets, or snapshot metadata).

Good point, stuff like this would make the docs much better. I believe any change to published signed metadata should lead to version bump: otherwise clients can't know when they need to download new metadata (in the case that they already have the previous version downloaded).
The only modification to metadata that doesn't need this that I could imagine is adding signatures... but even that seems safe only before the metadata is made public to clients (otherwise some clients could have fewer signatures and then signing keys might get changed and who knows how that would end).

Good question!
The spec has recently been updated to be a bit more specific about how the client should deal with new metadata that has the same version as the trusted one (see theupdateframework/specification#209).

In case they [versions] are equal, discard the new
timestamp metadata and abort the update cycle. This is normal and it
shouldn't raise any error. The reason for aborting the update process is that
there shouldn't be any changes in the content of this, or any other metadata
files too, considering it has the same version as the already trusted one.

Parts of this are still being discussed in theupdateframework/specification#114

... I believe any change to published signed metadata should lead to version bump: ...

@jku Yes, that certainly makes sense. Thanks for clarifying! :-)

In the case of targets and snapshot metadata it also makes sense to bump if only the signatures are changed, because their file hashes could be listed in other metadata (snapshot can list targets metadata file hashes, and timestamp can list snapshot metadata file hashes).

@lukpueh Thanks for pointing that out.
So, would it be correct to say that the safest rule-of-thumb is to always bump the version whenever someone signs a role?

bump the version whenever someone signs a role

... and publishes it for someone to consume.
I would say.

bump the version whenever someone signs a role

... and publishes it for someone to consume.

where the consumer would be either a tuf client or another key-owner?
(sorry for going on about this)

Ha, excellent follow-up question. I was only thinking of a client.
For threshold signing we actually must not bump the version on each signature. Otherwise we'd sign different content each time and would never reach the desired threshold.

In the case of targets and snapshot metadata it also makes sense to bump if only the signatures are changed, because their file hashes could be listed in other metadata (snapshot can list targets metadata file hashes, and timestamp can list snapshot metadata file hashes).

Still trying to figure this out...
Suppose timestamp lists the hash for the snapshot file, and only the signatures for snapshot are changed (for some reason). This means the snapshot "signed" portion does not change, but the snapshot file hash does change. Thus, the "signed" portion for timestamp changes. Then wouldn't it make sense to bump the signed.version for timestamp only, and leave the signed.version for snapshot untouched?

Do you release the file when you don't have a threshold of signatures?  I
mean, is it considered valid when it isn't fully signed?  I would think it
should not be and should not be released / trusted by clients.
On Wed, Jun 8, 2022 at 11:22 PM Lukas Pühringer @.***>
wrote:

Ha, excellent follow-up question. I was only thinking of a client.
For threshold signing we actually must not bump the version on each
signature. Otherwise we'd sign different content each time and would never
reach the desired threshold.
—
Reply to this email directly, view it on GitHub
https://github.com/theupdateframework/python-tuf/issues/2020#issuecomment-1150063233,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAGROD5IVCLF4SB6K3KDC2TVOC3EPANCNFSM5YGP6DJA
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

In the case of targets and snapshot metadata it also makes sense to bump if only the signatures are changed, because their file hashes could be listed in other metadata (snapshot can list targets metadata file hashes, and timestamp can list snapshot metadata file hashes).

Still trying to figure this out...
Suppose timestamp lists the hash for the snapshot file, and only the signatures for snapshot are changed (for some reason). This means the snapshot "signed" portion does not change, but the snapshot file hash does change. Thus, the "signed" portion for timestamp changes. Then wouldn't it make sense to bump the signed.version for timestamp only, and leave the signed.version for snapshot untouched?

Changing the signature of snapshot without changing the signed portion means that there is a change in the snapshot key used for singing. I think you will want to have a new version of snapshot in this case as you want to signal to your clients that there is a change in the keys used. This is useful in the case of snapshot key/keys compromise when you will want to rotate the snapshot keys with new ones.

... as you want to signal to your clients that there is a change in the keys used. This is useful in the case of snapshot key/keys compromise when you will want to rotate the keys with new ones.

@MVrachev  Doesn't the client handle this automatically, because the root role is updated at the beginning of the client workflow?
As I understand it (perhaps wrongly...), the spec suggests that the signed.version for snapshot is only read after verifying the signatures, see e.g. 5.5 steps 3 and 4. The hash for snapshot would have changed, but that would be taken care of by the updated timestamp file, which would have been downloaded first (5.4).
Side note: Not sure if it matters for the current discussion, but I'm not considering consistent snapshots in this example, so the snapshot metadata file doesn't have a version in the filename.

If we consider the metadata object (basically the content of a metadata file):
{
  "signed" : ROLE,
  "signatures" : [
    { "keyid" : KEYID,
      "sig" : SIGNATURE }
      , ... ]
}

It is clear that the "signatures" element depends on the "signed" element: We sign off on the content of "signed", which includes a specific "version".
But, the other way round, shouldn't the "signed" element always remain independent of the "signatures" element (within that same metadata object)?
In other words, being a naive user, I would expect that an isolated change in the "signatures" element (for whatever reason) should never cause a change in the "signed" element (such as a version bump) of the same metadata object. On the other hand, it could (or should?) cause a version bump in the "signed" element of other, dependent, metadata objects (once it is published).
For example, an isolated change in the "signatures" element for snapshot should not cause a version bump for snapshot itself, but could lead to a version bump in timestamp, but only if timestamp contains the file hash etc. for snapshot.json.
Please correct me if I'm wrong here. :-)

Your mental model seems right to me, maybe it works better with what we suggested above if we shift the causality a bit...
So I wouldn't say that a change in the independent signatures element causes a change in the signed element, but rather that only a version bump in the signed element causes the client to consider it as new metadata. Does that make sense?

@MVrachev:

Changing the signature of snapshot without changing the signed portion means that there is a change in the snapshot key used for singing.

This is a likely but not the only reason for a change in signatures.

I think you will want to have a new version of snapshot in this case as you want to signal to your clients that there is a change in the keys used.

In case of a timestamp or snapshot key rotation in root metadata, we delete the trusted versions of those metadata files to allow recovery from a potential ffw attack. So in that case the version bump isn't actually required. :)

@lukpueh Yes, thanks, I think that makes sense.
I'm still looking for a clear guideline. Something like the following, perhaps?
The "signed" version for a metadata object must be incremented if, and only if, the "signed" content has changed w.r.t. the latest published version of that metadata object.

Maybe we can phrase it with regards to the user?
The "signed" version for a metadata object must be incremented if, any client downloader should consider it as new trusted metadata.

So this translates to "bump version right before sign/persist (for publication) if signed part has changed, unless the change already includes a version bump"? I think this makes sense as a rule of thumb.

@lukpueh Yes, I think that translation covers it.

This issue should be resolved as part of #1136 either in code or in documentation.


Add blosc getitem

This PR demonstrates a way to do partial decompression of a blosc compressed array buffer. The biggest limitation of the decompress_partial method is the inability to properly decompress parts of a multidimensional array. The user must also must account for typesize and the encoding size of the encoded array to function properly.
TODO:

[x] Unit tests and/or doctests in docstrings
[x] tox -e py38 passes locally
[x] Docstrings and API docs for any new/modified user-facing classes and functions
[x] Changes documented in docs/release.rst
[x] tox -e docs passes locally
[ ] AppVeyor and Travis CI passes
[ ] Test coverage to 100% (Coveralls passes)

That looks good to me, I'm thinking that when this is used in a higher level API we might be able to guess the typesize of the underlying blosc serialization once and reuse it – this would then let the users be unaware of this detail.


[backup_xcarchive] Add custom xcarchive zip filename option

Checklist

[x] I've run bundle exec rspec from the root directory to see all new and existing tests pass
[x] I've followed the fastlane code style and run bundle exec rubocop -a to ensure the code style is valid
[x] I've read the Contribution Guidelines
[x] I've updated the documentation if necessary.

Motivation and Context

Current action outputs the zip with the filename based out of Xcode's output xcarchive filename, which is app name followed by date and time of the build (e.g. App 2017-10-07 23.19.31.xcarchive.zip). There are cases you want to backup the zipped xcarchive based on app version and build number.
Description

This adds an optional zip_filename option  so that we can specify the backup xcarchive's zip filename.

Is this accessible via gym?

@revolter What do you mean “accessible via gym”? This is a different action. Usually you would want to execute this after the “gym” action if you want to backup your app’s archive.

Oh, ok. gym, by default, creates the archive in the default location as the Xcode's Archive command. And I thought this allows you to change the file name.

Ah, yes. gym can save the archive in the location that you specify via the archive_path option, but it doesn't allow you to change the filename and it doesn't compress the xcarchive file.

So a separate PR is needed for it, right?

I don’t think it’s needed since you can already do it using the backup_xcarchive action.

Indeed, but I don't want to backup (compress) the archive. Thank you for your answers.


Bolt loses context

Describe the bug
When I send my initial prompt to setup a project, the code editor opens up, the files are created appropriately and the nodejs server starts in WC. However, any future prompts simply provide code in the chat window instead of updating the code editor/source tree with new files.
Link to the Bolt URL that caused the error
http://localhost:8788
Steps to reproduce

"Create a scaffold for a react app using bootstrap"
"Add a user model including username, email, password, TOTP secret."

Expected behavior

Open IDE (OK)
Create the file tree (OK)
Populate the project files (such as package.json, index.jsx etc) (OK)
Launch the project in the WC (OK)
Create a models folder (FAIL)
Add a user model file (FAIL)
Populate the user model file (FAIL)

Stages 5-7 fail and simply reply with code in the chat window with no context to the project setup in the original prompt.
Screen Recording / Screenshot
No response
Platform

OS: MacOS
Browser: Brave
Version: 1.68.128

Additional context
I would expect Bolt to retain context throughout the entire workflow and add files to the project instead of just losing context and responding with code in chat.

I use Ollama with deepseek-coder-v2:16b and have now set the context size to 128k using a Modelfile - this seems to have fixed it (although my testing has been limited so until I generate more code, I can't confirm for certain) and I have now managed to have several new files added to the source tree with additional prompts.
Previously (when I posted this issue) I was using Ollama's default context which I believe is only 2048 now I am using a context of 131072.

Any coding done with opensource models will fail and bug a lot , only GPT4 / Sonnet are reliable

Any coding done with opensource models will fail and bug a lot , only GPT4 / Sonnet are reliable

This is quite frankly, false. I have access to GPT4 in my enterprise and I find deepseek-coder-v2:16b and llama3.1:70b both out perform it with regards to accuracy.
I have just pulled qwen2.5 32b and 72b models as well, which I am yet to test, but also seem to be leading the pack on coding tasks (with a great deal of excitement around the upcoming qwen2.5-coder:32b slated to soon be released).
You couldn't pay me enough to use any closed model by Anthropic or OpenAI especially given I have ongoing legal action against OpenAI. I will only use models in the public domain.
As for bugs, anyone using an LLM for anything without checking the results for accuracy, shouldn't have access to a device capable of connecting to the Internet, period.


Move report-related errors code to errors/test-run and the runtime errors code to errors/runtime (#347 part 1)

\cc @kirovboris @AlexanderMoskovkin

Tests are failed. Please fix it.

@kirovboris More likely we have a problem with saucelabs and travis

@testcafe-build-bot \retest

@testcafe-build-bot \retest

@inikulin FYI: build-bot doesn't restart the tests if they are in progress. I've stopped tests (via travis UI) and restarted them to save our time.

@AlexanderMoskovkin thx

@inikulin Functional tests is raising the following error:
AssertionError: object tested must be an array, an object, or a string, but error given
Is it a tests problem?

It seems, this is the same problem with functional tests that we saw before (the browser goes to the idle-page from the other browser). We'll research this with @georgiy-abbasov

Is it a tests problem?

 The second functional test run is success

@kirovboris

Is it a tests problem?

No. Functional tests runs just fine on my side.

@testcafe-build-bot \retest

@testcafe-build-bot \restart

lgtm

lgtm


[SPARK-43646][CONNECT][TESTS] Make both SBT and Maven use spark-proto uber jar to test the connect module

What changes were proposed in this pull request?
Before this pr, when we tested the connect module, Maven used the shaded spark-protobuf jar for testing, while SBT used the original jar for testing, which also led to inconsistent testing behavior. So some tests passed when using SBT, but failed when using Maven:
run
build/mvn clean install -DskipTests
build/mvn test -pl connector/connect/server

there will be two test failed as follows:
- from_protobuf_messageClassName *** FAILED ***
  org.apache.spark.sql.AnalysisException: [CANNOT_LOAD_PROTOBUF_CLASS] Could not load Protobuf class with name org.apache.spark.connect.proto.StorageLevel. org.apache.spark.connect.proto.StorageLevel does not extend shaded Protobuf Message class org.sparkproject.spark_protobuf.protobuf.Message. The jar with Protobuf classes needs to be shaded (com.google.protobuf.* --> org.sparkproject.spark_protobuf.protobuf.*).
  at org.apache.spark.sql.errors.QueryCompilationErrors$.protobufClassLoadError(QueryCompilationErrors.scala:3417)
  at org.apache.spark.sql.protobuf.utils.ProtobufUtils$.buildDescriptorFromJavaClass(ProtobufUtils.scala:193)
  at org.apache.spark.sql.protobuf.utils.ProtobufUtils$.buildDescriptor(ProtobufUtils.scala:151)
  at org.apache.spark.sql.protobuf.ProtobufDataToCatalyst.messageDescriptor$lzycompute(ProtobufDataToCatalyst.scala:58)
  at org.apache.spark.sql.protobuf.ProtobufDataToCatalyst.messageDescriptor(ProtobufDataToCatalyst.scala:57)
  at org.apache.spark.sql.protobuf.ProtobufDataToCatalyst.dataType$lzycompute(ProtobufDataToCatalyst.scala:43)
  at org.apache.spark.sql.protobuf.ProtobufDataToCatalyst.dataType(ProtobufDataToCatalyst.scala:42)
  at org.apache.spark.sql.catalyst.expressions.Alias.toAttribute(namedExpressions.scala:194)
  at org.apache.spark.sql.catalyst.plans.logical.Project.$anonfun$output$1(basicLogicalOperators.scala:72)
  at scala.collection.TraversableLike.$anonfun$map$1(TraversableLike.scala:286)

- from_protobuf_messageClassName_options *** FAILED ***
  org.apache.spark.sql.AnalysisException: [CANNOT_LOAD_PROTOBUF_CLASS] Could not load Protobuf class with name org.apache.spark.connect.proto.StorageLevel. org.apache.spark.connect.proto.StorageLevel does not extend shaded Protobuf Message class org.sparkproject.spark_protobuf.protobuf.Message. The jar with Protobuf classes needs to be shaded (com.google.protobuf.* --> org.sparkproject.spark_protobuf.protobuf.*).
  at org.apache.spark.sql.errors.QueryCompilationErrors$.protobufClassLoadError(QueryCompilationErrors.scala:3417)
  at org.apache.spark.sql.protobuf.utils.ProtobufUtils$.buildDescriptorFromJavaClass(ProtobufUtils.scala:193)
  at org.apache.spark.sql.protobuf.utils.ProtobufUtils$.buildDescriptor(ProtobufUtils.scala:151)
  at org.apache.spark.sql.protobuf.ProtobufDataToCatalyst.messageDescriptor$lzycompute(ProtobufDataToCatalyst.scala:58)
  at org.apache.spark.sql.protobuf.ProtobufDataToCatalyst.messageDescriptor(ProtobufDataToCatalyst.scala:57)
  at org.apache.spark.sql.protobuf.ProtobufDataToCatalyst.dataType$lzycompute(ProtobufDataToCatalyst.scala:43)
  at org.apache.spark.sql.protobuf.ProtobufDataToCatalyst.dataType(ProtobufDataToCatalyst.scala:42)
  at org.apache.spark.sql.catalyst.expressions.Alias.toAttribute(namedExpressions.scala:194)
  at org.apache.spark.sql.catalyst.plans.logical.Project.$anonfun$output$1(basicLogicalOperators.scala:72)
  at scala.collection.TraversableLike.$anonfun$map$1(TraversableLike.scala:286)

So this pr make SBT also use spark-proto uber jar(spark-protobuf-assembly-**-SNAPSHOT.jar) for the above tests and refactor the test cases to make them pass both SBT and Maven after this pr.
For the Java proto files used for testing, this pr has added the generated files to the testing directory and left a TODO:

SPARK-44606: Generate Java PB files and replace the package names in the files when testing

Why are the changes needed?
Make connect server module can test pass using both SBT and maven.
Does this PR introduce any user-facing change?
No
How was this patch tested?

Pass Github Actions
Manual check

build/mvn clean install -DskipTests
build/mvn test -pl connector/connect/server

all test passed after this pr.

cc @hvanhovell @HyukjinKwon @zhengruifeng @rangadi and @pan3793

I like this but cc @grundprinzip and @zhenlineo too

Would it be easier if we change maven to use the unshaded jar?

https://github.com/apache/spark/blob/5c36c58047724885864cb781f17038a6b9c94513/connector/protobuf/pom.xml#L95-L100
Since shadedArtifactAttached is configured to be true, Maven will no longer publish the unshaded jar. Following Spark's previous practice, if both unshaded jars and shaded jars are needed, then it needs to be split into two modules, such as kafka-0-10 and kafka-0-10-assembly, kinesis-asl and kinesis-asl-assembly. So, if we need Maven to publish the unshaded jar, we need to split the protobuf module into two modules: protobuf and protobuf-assembly. I had a previous PR that did this work: https://github.com/apache/spark/pull/41466.`

While I'm not certain if it's reasonable, I still want to point out that relocating the content of the spark-protobuf module may result to a poorer user experience: In order to use this sql function, users have no choice but to relocate the content of the Java PB description files used in their business according to Spark's project rules. Is this really user-friendly for existing data and businesses? Meanwhile, the spark-protobuf module is a module that won't be packaged into spark-client tar ball, is it very risky to only publish unshaded jars? @rangadi @HyukjinKwon

Agree with @LuciferYang's opinion, better to use vanilla protobuf here.
Generally, the relocation technically should be used carefully, and should not affect user API. Some users may look for examples from test cases, it should be consistent with the end users' code. (if someone copies code snippets from test code but can not run with their own project, really a bad experience)
Historically, Hadoop and ORC have transitive protobuf 2.5 deps, which may cause deps conflict without shading and relocation in Spark, but it's not an issue today.

Yes, if we accept that the spark-protobuf module does not perform relocation for protobuf, then this issue will become simpler and the cost for users will be relatively lower.

cc @srowen This pr should be able to solve the test failure you mentioned in the dev email, I would greatly appreciate if you could participate in reviewing it, thanks ~
On the other hand, I am wondering about your opinion on https://github.com/apache/spark/pull/42236#issuecomment-1664828251

@srowen No, this is not the impact brought by this pull request, it's just the current state of the spark-protobuf module.
The purpose of this pull request is to make both sbt and maven pass the test under the current state of the spark-protobuf module.
The current state of the spark-protobuf module mentioned here is similar to what you understood, with specific details similar to the comments in the following function：
https://github.com/apache/spark/blob/433fb2af8a3ca239958cb7b006e2924ecfac0d56/connector/protobuf/src/main/scala/org/apache/spark/sql/protobuf/functions.scala#L118-L136
This is unrelated to Spark Connect itself, Spark Connect just proxies this functions

OK if this doesn't change the current state, just resolves a test failure, then seems fine.

While I'm not certain if it's reasonable, I still want to point out that relocating the content of the spark-protobuf module may result to a poorer user experience: In order to use this sql function, users have no choice but to relocate the content of the Java PB description files used in their business according to Spark's project rules(replcace all com.google.protobuf. toorg.sparkproject.spark_protobuf.protobuf. in their generated Java files, Perhaps I misunderstood something?). Is this really user-friendly for existing data and businesses? Meanwhile, the spark-protobuf module is a module that won't be packaged into spark-client tar ball, is it very risky to only publish unshaded jars? @rangadi @HyukjinKwon

+1 for @LuciferYang 's opinion. It's not reasonable that user has to package its protobuf jar relocated. Since the spark-protobuf jar is not included in the spark-client binary, I think a better solution would be publishing both unshaded and shaded jars. Users could simply packing their protobuf message classes into a jar and use spark-protobuf jar as needed. The shaded spark-protobuf jar is kept for compatibility and also for last resort.
According to https://protobuf.dev/support/cross-version-runtime-guarantee/, I believe as long as Spark uses higher 3.x versions, user compiled java classes should be fine to run.

There was already a PR attempt to split the spark-proto module into two modules, spark-proto and `spark-assembly: https://github.com/apache/spark/pull/41466

Could you update the doc comment to say why this is included (the current comment talks about a fix, but not the problem). Looks like this uses shaded version of protobuf library.

Thanks for your review @rangadi , I will add more information later.

Could you update the doc comment to say why this is included (the current comment talks about a fix, but not the problem). Looks like this uses shaded version of protobuf library.

done

What suggestions does everyone have on how to proceed with fixing this issue? Should we have it fixed before the next 3.5.0 RC release?

What are the standing comments? Otherwise, I would guess its good to go?

@HyukjinKwon Hmm... I think the fix should be fine. However, as Spark 3.5 no longer needs to support protobuf 2.5, I hope to make some changes to the Experimental Apis involved in this pr to make it no longer intrude into user code.
The related viewpoints include：
https://github.com/apache/spark/pull/42236#issuecomment-1664828251, https://github.com/apache/spark/pull/42236#issuecomment-1665167038,
https://github.com/apache/spark/pull/42236#issuecomment-1668006357
Of course, we could also choose to fix this issue for Spark 3.5 using this pr first and have more discussions or changes for this in Spark 4.0.

4ba45e0  has automated the process of generating .java from .proto and replacing all instances of com.google.protobuf. with 'org.sparkproject.spark_protobuf.protobuf.' in the .java files. Thus, the TODO task SPARK-44606 is no longer needed. ""

@HyukjinKwon @rangadi Since there are new code changes in  4ba45e0, could you please take another look? If there are no new issues, I will merge this pr if GA passes.

GA passed and I have manually verified with Maven, the tests can pass.

@LuciferYang BTW, is this a real blocker? or test-only issue?

@LuciferYang BTW, is this a real blocker? or test-only issue?

hmm... If we accept that Maven tests inevitably fail, then this is not a blocker

@HyukjinKwon So I don't think this is a real blocker, but we should at least make the maven test pass in master/branch-3.5, even if it means removing these two cases.

I will merge this pr today If there are no more comments  @rangadi @HyukjinKwon  @hvanhovell @zhengruifeng @rangadi @pan3793 @grundprinzip @zhenlineo

Merged into master and branch-3.5 to fix the maven test for the connect-server module

Thanks all

After this changes, I cannot compile Spark as a maven project in IntelliJ IDEA anymore. It fails with the error (see the screenshot). Any idea how to fix the issue?
java: package org.sparkproject.spark_protobuf.protobuf does not exist

@MaxGekk I thought for a while, I have no better way to solve this issue, indeed, it's impossible to be perfect. I have decided to revert this pr and ignore the corresponding two test cases.


[ci skip] [cf admin skip] NO_CI removing bot automerge

Hi! This is the friendly automated conda-forge-webservice.
I've removing bot automerge as instructed in #39.
Merge this PR to disable bot automerging.
Fixes #39

We should merge this before the autotick bot comes along! :joy:

Thanks @brandonwillard


fix: mgmt-10251-change default size vm and odf storagecluster manifest to 1

Signed-off-by: Alberto Morgante Medina<EMAIL_ADDRESS>Description
Change the VM disk and the request in the storagecluster manifest to 75gb disk size
Fixes # https://issues.redhat.com/browse/MGMT-10251
Type of change
Please select the appropriate options:

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update
[ ] This change is a documentation update

Testing
Tested manually in Flavio1 to verify with @achuzhoy before testing with the CI

Also has been tested after a day just to ensure the size of disks is OK and not increasing
cluster:
    id:     e96b1089-7ca1-4434-8233-e604ffadc873
    health: HEALTH_OK  services:
    mon: 3 daemons, quorum a,b,c (age 2m)
    mgr: a(active, since 22h)
    mds: 1/1 daemons up, 1 hot standby
    osd: 12 osds: 12 up (since 21h), 12 in (since 23h)
    rgw: 1 daemon active (1 hosts, 1 zones)  data:
    volumes: 1/1 healthy
    pools:   11 pools, 465 pgs
    objects: 54.33k objects, 110 GiB
    usage:   341 GiB used, 559 GiB / 900 GiB avail
    pgs:     465 active+clean  io:
    client:   3.9 KiB/s rd, 9.6 KiB/s wr, 2 op/s rd, 2 op/s wr

[x] Test A - manually
[x] Test B - pipe ci (https://github.com/rh-ecosystem-edge/ztp-pipeline-relocatable/runs/6707673617?check_suite_focus=true)

Test Configuration:

Versions:
Hardware:

Checklist

[x] I have performed a self-review of my own code
[ ] If a change is adding a feature, it should require a change to the README.md and the review should catch this.
[ ] If the change is a fix, it should have an issue. The review should make sure the comments state the issue (not just the number) and it should use the keywords that will close the issue on merge.
[x] A change should not be merged unless it passes CI or there is a comment/update saying what testing was passed.
[x] PRs should not be merged unless positively reviewed.

:tada: This PR is included in version 1.8.3 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Remove the mouse enter observer, as it does weird things in scrollable menus

I did a quick search of the app, and saw no side effects of this. (Other than the scroll jump bug)

:shipit:


refactor: Clean up subs for settings code.

This change breaks a dependency that gets us one edge closer to a tree, based on the @andersk tooling.
It also avoids a lot of action-at-a-distance.  Instead of constantly updating the sub with calculated fields that only matter for the stream settings code, we just have the stream settings code ask for the bigger sub objects when we need them.
I also consolidate all the logic for whether you can subscribe, preview, change permissions, view subscribers, or subscribe others for a stream.
The performance impact of this change should be completely negligible.  We avoid some unnecessary computation and memory usage during normal operation.  All the computations here are really cheap.

This looks great as a direction; I posted a batch of comments.

I believe I've addressed all the comments here, so this is ready for review again.

I think you missed https://github.com/zulip/zulip/pull/17993#discussion_r607125674.  I pushed back here after adding a comment in the "notification settings" one.  Other than that, this lgtm.

My last comment was in error -- I tried to check that last detail using gitk, but forget to update it.
Merged, thanks @showell!


(Tuto) How to run this library on OS/X ?

Hi Mochamad,
Thanks a lot for this awesome library !
I was writing a big ticket where I asked "HELPP, can you help me to run your lib on OS/X please ?" but by writing my issue, I've found the solution ! Then I thought it will be a good idea to share the tips.
1. Install brew
Brew is a famous package manager on OS/X : http://brew.sh/ (aptitude style).
2. Install poppler
brew install poppler

3. Verify the path of pdfinfo and pdftohtml
$ which pdfinfo
/usr/local/bin/pdfinfo

$ which pdftohtml
/usr/local/bin/pdfinfo

4. Whatever the paths are, use Gufy\PdfToHtml\Config::set to set them in your php code. Obviously, use the same path as the one given by the which command;
<?php
// if you are using composer, just use this
include 'vendor/autoload.php';

// change pdftohtml bin location
\Gufy\PdfToHtml\Config::set('pdftohtml.bin', '/usr/local/bin/pdftohtml');

// change pdfinfo bin location
\Gufy\PdfToHtml\Config::set('pdfinfo.bin', '/usr/local/bin/pdfinfo');

// initiate
$pdf = new Gufy\PdfToHtml\Pdf('file.pdf');

// convert to html and return it as [Dom Object](https://github.com/paquettg/php-html-parser)
$html = $pdf->html();
?>

Everything will work like a charm ! :-)
Stéphane

Ah, that's gread help. Thanks, allow me to include your guide in my README file. :+1:

Of course ! :-) See you soon, have a nice day.
@+ Stéphane


Update DI and configuration test libs

Q
A

Bug fix?
no

New feature?
no, improvement

BC breaks?
no

Deprecations?
no

Fixed tickets
-

Related issues/PRs
#2106

License
MIT

Documentation PR
-

What's in this PR?
Updates the matthiasnoback/symfony-dependency-injection-test and matthiasnoback/symfony-config-test libs.
Why?
Symfony 3.0 compatibility

Rebased. Can be merged already, independent of all other PRs coming.

thanks @patkar for your effort


Added GetSecurityInfo

Hi there,
I guess that this branch will currently not compile.
I would appreciate some advice with this. As you can see, I'm trying to integrate GetSecurityInfo into the crate. However, I'm a little bit lost with some details:

Where should an enum like SE_OBJECT_TYPE go? Is this (src/advapi32.rs) the correct place?
Is the way, I added the function to testing, correct?
The enum for SE_OBJECT_TYPE seems to contain a set of constants but I cannot find them defined anywhere. (neither under https://msdn.microsoft.com/en-us/library/windows/desktop/aa379593(v=vs.85).aspx nor elsewhere in the net) Do you have any idea, how to proceed on this?
I'm looking forward to your advice. I'd really like to adde some more functions that I would like to use.
Thanks

Windows SDK 10.0.14393.0, um/AccCtrl.h.
//
// Definition:
// This enumerated type defines the objects supported by the get/set API within
// this document.  See section 3.1, Object Types for a detailed definition of the
// supported object types, and their name formats.
//
typedef enum _SE_OBJECT_TYPE
{
    SE_UNKNOWN_OBJECT_TYPE = 0,
    SE_FILE_OBJECT,
    SE_SERVICE,
    SE_PRINTER,
    SE_REGISTRY_KEY,
    SE_LMSHARE,
    SE_KERNEL_OBJECT,
    SE_WINDOW_OBJECT,
    SE_DS_OBJECT,
    SE_DS_OBJECT_ALL,
    SE_PROVIDER_DEFINED_OBJECT,
    SE_WMIGUID_OBJECT,
    SE_REGISTRY_WOW64_32KEY,
    SE_REGISTRY_WOW64_64KEY,
} SE_OBJECT_TYPE;

Therefore you would put this enum definition into src/accctrl.rs.
As for 2, yes.

This PR will need to be updated for the winapi 0.3 new world order. https://github.com/retep998/winapi-rs/issues/316

@nils-tekampe I don't know if most of these changes aren't already covered by a lot of the work that's already been done in dev, but if so, do you have any interest in pushing this PR forward towards merging?

@Susurrus In theory I would be willing to merge/push those changes that I made last year towards the main branch. My problem is however that most of the requirements mentioned under https://github.com/retep998/winapi-rs/issues/316 are beyond my knowledge and experience in rust. I can merge the files and use the crates but I'm still a newbie with rust :-(

@nils-tekampe Well this is an excellent opportunity to keep working with Rust, because you've actually done the hard part already, creating the declarations! The only thing wrong with this PR is that the declarations are in the right place! Instead of declaring things in the DLLs that they're compiled into, this project is instead mimicing the windows headers directly. So all you need to do is move the code into the right places as described in #316. If you look at any of the other pending PRs, and read the CONTRIBUTING.md document, it should be straightforward. I'm also happy to help.
I should note that some of the changes you're already doing are resolved by #447. So reduce the scope of this PR down to just adding the accctrl header in src/um. Your commit would then be something like this.

Closing due to inactivity. If anything from this PR is still missing in the current winapi, feel free to redo those changes for the current structure and submit a fresh PR.


chore: enforce bip44Params on idle & remaining chain-adapter types

Partially completes https://github.com/shapeshift/lib/issues/999.

Closing - need to split into separate PRs by package.


Added quick sort example for consistency.

Checklist:

[X] I have read freeCodeCamp's contribution guidelines.
[X] My pull request has a descriptive title (not a vague title like Update index.md)
[X] My pull request targets the main branch of freeCodeCamp.
[X] I have tested these changes on GitPod.

Closes #XXXXX

I've added the quicksort example at the bottom to stay consistent with the rest of the sorting algorithms on / Coding Interview Prep / Algorithm /.

I may be wrong, but I think we were going in the opposite direction, removing function calls from the editor

There's #40710 issue discussing removing calls from the other sort challenges.

Okay sure. I'll just follow the #40710 thread and close this.


mallob error server returned nothing (no headers, no data)

mallob error server returned nothing (no headers, no data)
can not mine with new versionn v2.2.5a

Yes this is BS! Leaving this project if no solutions are made 😠

This issue needs to be addressed with your pool operator / mining software developer


Update k8s.io/utils digest to 6fe5fd8

This PR contains the following updates:

Package
Type
Update
Change

k8s.io/utils
require
digest
49e7df5 -> 6fe5fd8

Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.

[ ] If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>2
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 44.198%

Totals

Change from base Build<PHONE_NUMBER>9:
0.0%

Covered Lines:
438

Relevant Lines:
991

💛  - Coveralls


Test: Change in logger & fix for huggingface_hub (#18)

Change in logger & fix for huggingface_hub

add test & enable langchain e2e tests by default

@Dev-Khant thanks for your contribution


[Feature]: Add development container without CARLA

Description
Add a second container, similar to the agent container which doesn't run CARLA.
Thereby, we can development on our own (not that powerful) Notebooks if we don't need CARLA for a issue but preserve our unified setup.
Definition of Done

Second container available which is similar to the agent container without CARLA

@nylser oh okay, then I got this wrong! Thanks for clarification.
I think in this case there's nothing todo since we can just run (training)commands with the b5 shell command, without starting the simulator, right?

@nylser I just implemented a check for Nvidia-docker. This makes it possible to use the containers on devices without GPU.


Updated functionality to modify a record in ovsdb

@jkoelker Ready for your review sir, got the update record functionality working as long as the column exists in the table anyway.

LGTM


[BUG] Reachable Attribute throws an 0x86 (UNSUPPORTED_ATTRIBUTE) Error.

Reproduction steps
Bring up the DUT with all-clusters-app.
Pair the DUT using chip-tool through "onnetwork" transport.
Run the command ./chip-tool  basicinformation read reachable 1 0
Bug prevalence
Whenever i do this after the bfa05804ac3c224c9e70921a857ffcac32ccc7f4 commit in master branch
GitHub hash of the SDK that was being used
bfa05804ac3c224c9e70921a857ffcac32ccc7f4 - Master
Platform
raspi
Platform Version(s)
RPI4 8GB RAM
Anything else?
Description:
In Basic-information cluster (BINFO), Reachable Attribute throws an 0x86 (UNSUPPORTED_ATTRIBUTE) Error.
Expected behavior:- DUT should respond with Success.

[1658734602.363846][3240:3245] CHIP:DMG: }
[1658734602.364044][3240:3245] CHIP:TOO: Endpoint: 0 Cluster: 0x0000_0028 Attribute 0x0000_0011 DataVersion:<PHONE_NUMBER>
[1658734602.364097][3240:3245] CHIP:TOO:   Reachable: TRUE
[1658734602.364223][3240:3245] CHIP:EM: Sending Standalone Ack for MessageCounter:267048399 on exchange 14115i

Actual behavior:- DUT is responding with UNSUPPORTED_ATTRIBUTE

[1685962381.781839][12907:12909] CHIP:DMG:
[1685962381.781924][12907:12909] CHIP:DMG: 				StatusIB =
[1685962381.781999][12907:12909] CHIP:DMG: 				{
[1685962381.782074][12907:12909] CHIP:DMG: 					status = 0x86 (UNSUPPORTED_ATTRIBUTE),
[1685962381.782146][12907:12909] CHIP:DMG: 				},
[1685962381.782220][12907:12909] CHIP:DMG:

The "reachable" attribute is typically only implemented for bridged devices implementing the Bridged Device Basic Information cluster.  You should typically not expect it to be impemented in Basic Information cluster.  So I don't know where the "expected behavior" here is coming from.

@bzbarsky-apple
But, TC-DD-3.18 Step 4a ~ 4b is verifying Reachable attribute of chip-all-clusters-app as TH1, TH2 even if chip-all-clusters-app is not Bridged Device.  How can I test TC-DD-3.18 in this case ?
Refer to this link: https://github.com/project-chip/connectedhomeip/blob/master/src/app/tests/suites/certification/Test_TC_DD_3_18.yaml#L123

@Trishia Those specific verification steps are nonsense, sorry.  Ignoring for the moment what's going on with all-clusters-app, if that test were running against any sort of real device that device would almost certainly not have a Reachable attribute.

@bzbarsky-apple, I understand what are you saying about this issue. If so, TC-DD-3.18 Step 4a ~ 4b should be changed to other cluster attribute to read actions. Could you report this issue to proper certification staff ? I wish it would be fixed as soon as possible.

@Trishia Please report issues in the cert bits at https://github.com/CHIP-Specifications/chip-test-scripts/issues

@bzbarsky-apple Unfortunately, I have no access permission to this repository of the link : https://github.com/CHIP-Specifications/chip-test-scripts/issues.

@Trishia you should have access to the test scripts repo now. Pls file an issue there.

@Trishia you should have access now , could you chk and raise the issue there ?


Update deployment-tool-existing-file.md

new link added to the side channel mitigation.

Learn Build status updates of commit 359b791:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

azure-stack/hci/deploy/deployment-tool-existing-file.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the learn.microsoft.com contributor guidesPost your question in the Learn support channel

@dansisson,
Can you review the proposed changes?
IMPORTANT: When the changes are ready for publication, add a #sign-off comment to signal that the PR is ready for the review team to merge.
#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

Remove the space between the anchor text and the URL path so that the URL doesn't render as text:
[KB4072698] (https://support.microsoft.com/en-us/topic/kb4072698-windows-server-and-azure-stack-hci-guidance-to-protect-against-silicon-based-microarchitectural-and-speculative-execution-side-channel-vulnerabilities-2f965763-00e2-8f98-b632-0d96f30c8c8e)

#sign-off

Learn Build status updates of commit 52a30d9:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

azure-stack/hci/deploy/deployment-tool-existing-file.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the learn.microsoft.com contributor guidesPost your question in the Learn support channel

@dansisson Carlos has made your requested change, so can you please sign off again?

No response, so merging now...

Thanks Seth!


Update documentation for generate and --as-dockerfile

[x] Graduate the --as-dockerfile flag in s2i build from "EXPERIMENTAL" to a normal flag.
[x] Update our docs on Github with the new command and syntax.
[x] Mark the new generate command as "Tech Preview" so that we're consistent with the rest of the OpenShift ecosystem.

/ok-to-test

Made a quick PR to remove need for docker://..
https://github.com/openshift/source-to-image/pull/1024

/retest

Thanks for the test, Igor.
Also, validated 👍

_output/local/bin/darwin/amd64/s2i generate docker://docker.io/centos/nodejs-10-centos7 Dockerfile.gen

_output/local/bin/darwin/amd64/s2i generate docker.io/centos/nodejs-10-centos7 Dockerfile.gen

/retest

/lgtm

I see we do exclude_graphdriver_btrfs exclude_graphdriver_devicemapper https://github.com/openshift/builder/search?q=OS_GOFLAGS_TAGS&unscoped_q=OS_GOFLAGS_TAGS as well, though I am not quite sure why.

Also could you squash commits, please?


chore: cache cilium 1.12.10

What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Requirements:

[x] uses conventional commit messages
[ ] includes documentation
[ ] adds unit tests
[ ] tested upgrade from previous version

Special notes for your reviewer:
Release note:
cache Cilium 1.12.10

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 61.643%

Totals

Change from base Build<PHONE_NUMBER>:
61.6%

Covered Lines:
2544

Relevant Lines:
4127

💛  - Coveralls


Fix macos14 tests on 1.5

resolves #
docs dbt-labs/docs.getdbt.com/#

Problem
1.4 tests will fail on macos until we fix this.
Solution
Go to a version with a psycopg2 binary.
Checklist

[x] I have read the contributing guide and understand what's expected of me
[x] I have run this code in development and it appears to resolve the stated issue
[x] This PR includes tests, or tests are not required/relevant for this PR
[x] This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX

Judging from this manual CI run, we need to use parens around these....
https://github.com/dbt-labs/dbt-redshift/actions/runs/11927014503
Are PR checks still using the already-checked-in version? If so, this would explain for why they failed here but passed in the linked CI run


Browser Compatibility

This project will be supporting browsers as stated here:  The Multiselect shall support browsers that are supported by their parent company, e.g. Internet Explorer is supported by Microsoft for version(s) 11 and up “”

Browser Compatibility is achieved.


Not able to use with Angular CLI

Hi Team,
I am having tough time to use this component with angular cli. Do you have any sample to use it.

Hi,
You cant. This library is not for angular project. İts for angularjs


Release pgbelt to pypi!

Is your feature request related to a problem? Please describe.
I'd like to release pgbelt to pypi!
Describe the solution you'd like
Be able to run pip3 install pgbelt.
Describe alternatives you've considered
Considered not releasing it, but it's a CLI tool! It should be as easy as pip3 installing pgbelt and running the CLI tool with your own configs.
Additional context
Additional note -- once releasing is figured out, please also add the Pypi Sheilds for it.

#65 is adding automatic release branches. Once that works, will try to set up GHA releases to github and pypi.

Got releases uploading to pypi: https://github.com/Autodesk/pgbelt/pull/78
https://pypi.org/project/pgbelt/ done!


Allow creation of multiple copies of a cortical area

lets leave this for when we move to websocket communication, due to the increased difficulty this brings


Session Hijacking default of HTTP_ACCEPT_LANGUAGE is broken for IE with XHR

I found the IE's XHR send different Accept-Language header with browsing.
When non XHR request like this:
Accept: text/html, application/xhtml+xml, */*
Accept-Language: ja-JP
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; Trident/7.0; rv:11.0) like Gecko

But XHR like this:
x-requested-with: XMLHttpRequest
Accept-Language: ja
Accept: application/json, text/javascript, */*; q=0.01
Content-Type: application/json
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; Trident/7.0; rv:11.0) like Gecko

This difference causes trouble with session reset in XHR request.
Thank you.

Thank you for reporting this. I need to make sure I understand the problem correctly:
Since the Accept-Language header value is different between XHR and non-XHR requests, the Rack::Protection::SessionHijacking middleware kicks in, because it makes the assumption that a different value here is someone trying to spoof a session.
The result is that the user gets logged out if an XHR request is made.
Is this correct?
I'm not sure what the best approach to take in this situation is. If we match only on the ISO 639-1 code then Rack::Protection::SessionHijacking will be more permissive, which might not be desirable.

Closing for no feedback.
I'm also not sure what to do in this situation, but open to suggestions (in the form of a patch :+1:) But it sounds to me like being more permissive of Accept-Language header should be ok?
Thanks and sorry for any trouble this has caused you!


TypeError thrown when computing completion items at the end of a COPY instruction with flags

import { DockerfileLanguageServiceFactory } from "dockerfile-language-service";
const service = DockerfileLanguageServiceFactory.createLanguageService();
service.computeCompletionItems("COPY --from=a ", { line: 0, character: 14 });

$ node test.js
../dockerfile-language-service/out/src/dockerAssist.js:354
        const lastRange = args[args.length - 1].getRange();
                                                ^

TypeError: Cannot read properties of undefined (reading 'getRange')
    at DockerAssist.createTargetFolderProposals (../dockerfile-language-service/out/src/dockerAssist.js:354:49)
    at DockerAssist.createCopyProposals (../dockerfile-language-service/out/src/dockerAssist.js:344:21)
    at DockerAssist.computeProposals (../dockerfile-language-service/out/src/dockerAssist.js:174:37)
    at LanguageService.computeCompletionItems (../dockerfile-language-service/out/src/languageService.js:56:29)
    at Object.<anonymous> (../dockerfile-language-service/out/src/tmp.js:5:9)
    at Module._compile (node:internal/modules/cjs/loader:1101:14)
    at Object.Module._extensions..js (node:internal/modules/cjs/loader:1153:10)
    at Module.load (node:internal/modules/cjs/loader:981:32)
    at Function.Module._load (node:internal/modules/cjs/loader:822:12)
    at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:81:12)

Whoops. Meant to open this in the language service repository as https://github.com/rcjsuen/dockerfile-language-service/issues/97.


Elastic shrinkage

i hope add Elastic shrinkage,when  the size of the minScale  or maxScale，scale continue

I'd like to do that, and did once look at how I could do it, but because of the way the view works it's quite complicated to do. I'll keep this open and hopefully have another look some day.

I think can do it
in this method
onTouchEventInternal() -->ACTION_MOVE   scale = Math.min(maxScale, (vDistEnd / vDistStart) * scaleStart);
change to scale = Math.min(maxScale*1.5, (vDistEnd / vDistStart) * scaleStart);

Remember to deal with fitToBounds（） and limitedScale()
Last modified ACTION_UP if(scale>maxscale) start animation
minScale as well
I hope my Suggestions can help you

The difficulty is in changing fitToBounds and limitedScale so that they work differently when there is a gesture in progress, also calculating the "resistance" and the center position the image should spring back to on release.

I'm closing this now because I'm not working on the library and won't be able to add complex enhancements like this.


which test centers cooperate with the app?

Since early May 2021, one can register rapid tests via CWA. This doesn't work in all test centers though. I'd love to see a list of test centers which support this feature.

@nschloe
Your request looks very similar to https://github.com/corona-warn-app/cwa-wishlist/issues/498 "Add an overview for rapid test partners".
Note that there is also an FAQ article on this topic https://www.coronawarn.app/en/faq/#rapid_antigen_test (or https://www.coronawarn.app/de/faq/#rapid_antigen_test for the German language version), which links to https://www.coronawarn.app/en/faq/#where_can_i_get_tested.
The FAQs do not exactly answer your request, however that is the best information available at this time.

Definitely a dup of #498. Thanks for the quick response!


Possible to add table created from easy table into PDF created using Ralf Stuckert's PDFBox-Layout?

Hi @vandeseer
I'm working on a project and have created PDF using Pdfbox-layout by  Ralf Stuckert's. I see that this library also uses it uder the hood. Is there any way to add the table from this library into document of Pdfbox-layout?
Edit: or save table as image?
Thanks for the library and your work.
Regards.

Hello @arjitm786,
I didn't try this by my own so far, but I think that shouldn't be too big an issue.
Did you try it already? Have there been problems? If so, maybe just share an example ...
Best,
Stefan

Hello @vandeseer ,
First of all, thanks for the reply. I've created TableElement, similar to ImageElement.java in rts.PDFBox, which draws table form this library and then can be added to rts PDFBox document. I want it to span to multiple pages, but the outcome is not as expected. If table height is

less than available space on current page , it works fine (success.pdf).
greater than available space but less than Page.height, then buggy behavior (buggy.pdf).

I think this is because of the way PDFBox layout renders the element.
Since you've worked on PDFbox, I was hoping you can provide a solution.
success.pdf
buggy.pdf
TableAdapterRunner.txt
TableElementEasyTable.txt
ImageElement.txt


[FEATURE] add rocm support for installing Nexa SDK by install.sh script

Feature Description
rocm support for installing Nexa SDK by install.sh script
Similar Features or References
No response

Thanks for bring this up, you can use our prebuild wheel, just one line of code
CMAKE_ARGS="-DGGML_HIPBLAS=on" pip install nexaai --prefer-binary --index-url https://nexaai.github.io/nexa-sdk/whl/rocm621 --extra-index-url https://pypi.org/simple --no-cache-dir

I regret to say that currently there is no executable for ROCm available. However, you can install the python sdk with ROCm supported wheels as Zack mentioned. We appreciate your patience and the ROCm supported executable will be out really soon.


Possible to call custom components in .body section?

Hi, it's only a question about functionality. Is possible to call custom components in the body section?
Like this:
this.modal.alert()
.size('lg')
.showClose(true)
.title('URLS AND MD5s')
.body(`
        Configuration:

{{url.url }}

        `)
        .open();

Should be working something like this?
Thanks in advance

Tracked in #277

we can add selector component in body like this :
this.modal.alert()
.size('lg')
.showClose(true)
.title('A simple Alert style modal window')
.body('')
.open();
i get get WARNING: sanitizing HTML stripped some content (see http://g.co/ng/security#xss).

Mentioned this error too in #321.


Fix texworks to work with strict confinement

Texworks now works with strict confinement enabled

This pull request is now managed with CodeReviewHub. Refresh.

Nice one!


Feat: Implementation of React Router Dom for Multi-Page Navigation

Describe the feature
The website lacks routing functionality, preventing users from navigating to multiple pages. Given that the application is built using the React framework, which primarily caters to single-page applications (SPAs), the integration of React Router Dom is essential. This library facilitates multi-page navigation within React applications and enables seamless transitions between different sections of the website.
please assign me this issue i want to work on this
Add ScreenShots

Record

[X] I agree to follow this project's Code of Conduct
[X] I have checked the existing issues
[X] I'm a GSSOC'24 contributor
[X] I want to work on this issue

I want to work on this issue under gssoc24

Hey, allow me to work on this under GSSOC' 2024


feat(command matcher): Add option to match case insensitive

Resolves: #140

Looks good, but would you mind breaking line 141 into several lines for readability?

One more thing, could you add a test at /tests/match/test_messagematch.py under line 28 ?

The tests are failing:

Ups, didn't mean to use match2.


Fix CSP issue

Fixes #16

So the fix looked like it would work but i'm still getting CSP issues. Not sure if the extend_content_security_policy property in settings.yml has been deprecated or isn't working and I don't know enough Discourse code to know exactly how to patch this. Sorry to get everyones hopes up. Maybe someone will come along and figure out what's wrong.

I just updated the fix. It works.

Awesome, it works again! Thanks for the quick fix @gschlager. Hopefully @lionel-rowe will come along soon to merge this.


Train on 2 or more GPUs

Awesome work!
How should I change this code to train on 2 or more GPUs?

Probably you won't have to. It has been shown that using batch size as 16 leads to best audio fidelity, (see #14) and that only consumes about 4~5GB of GPU memory.


find placement for generate_parent_rows

The generate_parent_rows function is called from table generators (where it is placed) and from action loaders. Should find a common package to place the logic.

Due to the split of Operation's obj into data and model, there is a need to further modify the generate_parent_rows. A new function generate_parent_ops has been created. The code is not 100% duplicated but at this point it does not make sense to generalize.


如何将s2的i2s代码改成s3的 (IDFGH-7473)

有如下几个函数需要修改，红色表示在s3里，对应结构体里的成员已经不是那个了，并且还增加了一些，完全不知道怎么改了

@JustQY  Start from ESP32-S3, the I2S peripheral won't support a "LCD Mode". The LCD controller has been split into a stand-alone peripheral -- LCD_CAM. You can refer to the LCD driver from here if you want to drive a i80 interface LCD. The LCD_CAM chapter is release as well in the TRM


Couldn't able to get the index from x-axis label click

Hi @jerairrest,
Can you help to get the x-axis label click event, please?
Sample from the Chart JS library
https://codepen.io/jordanwillis/pen/gmdGGw

Closing. Reason: older than 6 months and not enough or outdated information supplied. Please re-open this issue if the problem persists, but provide more information. (including a sandbox link if possible)


Advanced validation did not propagate

Hi,
I tested validations and noticed for the email validator the error is stored in ._errors and in .properties.email._errors. This will cause the error to be send to FormComponent.rootProperty.errorsChanges.subscribe. But when I add my own validation like the passwordCheck this will only be stored on  .properties.passwordCheck._errors and the subscription will not get the error. Did I need to configure or change something to let own validators behave like the provided email validator?
Thanks in advance

Hi @mszalbach,
I ran into the same issue previously. I think the issue is that you're extending the abstract Widget class. You should instead inherit from the ControlWidget class. This propagates the valueChanges and errorsChanges on up the line.
My rule is that if its a 'dumb' component (like a fieldset or a wizard, etc) then I inherit from Widget. If it needs to do validation I usually inherit from ControlWidget. TBH a lot of the time all you'll want to do is style changes and you should inherit from the default component that matches the JSONSchema type you want it to build for. Then you just add the template and styling and use all the exposed properties that were in the parent class.
Hope this helps.
On a side note I think it might be good to link this to #77


chef-server-ctl --org-delete should inform of and/or delete existing nodes within

As a server admin, when i run chef-server-ctl --org-delete the nodes within should be cleaned up and/or should prompt that nodes still exist within the org. ZD 3393

Connect with an Epic of cleanup Chef Infra Server #81 is also related to the cleanup.


[SDA-6643] STS is now default mode for cluster creation, added flag for mint mode

SDA-6643
Adds mint-mode flag to ROSA CLI, and sets STS as the default mode with mint mode being an optional mode now.

@pvasant This change causes ? Deploy cluster using AWS STS: Yes to show when creating a cluster. Should I make it skip this? Or is that fine?

@arendej  PTAL

@hunterkepley please add the flow in the description to help visualize the changs

Added flow to description

/lgtm

@hunterkepley I just noticed that if the user selected the non-sts flag, it doesn't appear on the To create this cluster again... output: Can you please add this flag to the printed command?

Guilherme has worked on a reversion for this MR and revised it with new needs from the team. @gdbranco is this something you would want to do for your work on this?

@hunterkepley I just noticed that if the user selected the non-sts flag, it doesn't appear on the To create this cluster again... output: Can you please add this flag to the printed command?

Guilherme has worked on a reversion for this MR and revised it with new needs from the team. @gdbranco is this something you would want to do for your work on this?

I think this will be needed when we move forward with sts default again, but not atm


Failure when using scatter for H2D copy

🐛 Bug
To Reproduce
Apply the following diff to today's master branch of maskrcnn-benchmark.
diff --git i/maskrcnn_benchmark/data/collate_batch.py w/maskrcnn_benchmark/data/collate_batch.py
index a7f0341..c906712 100644
--- i/maskrcnn_benchmark/data/collate_batch.py
+++ w/maskrcnn_benchmark/data/collate_batch.py
@@ -14,7 +14,7 @@ class BatchCollator(object):

     def __call__(self, batch):
         transposed_batch = list(zip(*batch))
-        images = to_image_list(transposed_batch[0], self.size_divisible)
+        images = transposed_batch[0]
         targets = transposed_batch[1]
         img_ids = transposed_batch[2]
         return images, targets, img_ids
diff --git i/maskrcnn_benchmark/engine/trainer.py w/maskrcnn_benchmark/engine/trainer.py
index 38a9e52..be0c9f1 100644
--- i/maskrcnn_benchmark/engine/trainer.py
+++ w/maskrcnn_benchmark/engine/trainer.py
@@ -60,12 +60,26 @@ def do_train(

         scheduler.step()

-        images = images.to(device)
+        from maskrcnn_benchmark.structures.image_list import to_image_list
+        from torch.nn.parallel.scatter_gather import scatter
+
+        orig_images = images
+
+        images = [scatter(im, [dist.get_rank()])[0] for im in images]  # this fails
+        #images = [im.cuda() for im in images]  # this works
+
+        for orig_im, im in zip(orig_images, images):
+            diff = (orig_im - im.cpu()).abs().max()
+            assert diff < 0.01, diff
+        images = to_image_list(images, 32)
+
         targets = [target.to(device) for target in targets]

         loss_dict = model(images, targets)

         losses = sum(loss for loss in loss_dict.values())
+        if torch.isnan(losses).any():
+            raise FloatingPointError()

         # reduce losses over all GPUs for logging purposes
         loss_dict_reduced = reduce_loss_dict(loss_dict)

Before the diff, the code (1) pad images to imagelist in dataloader (2) copy the imagelist to GPU.
After the diff, the code (1) does not pad images in dataloader (2) copy the images to GPU individually (3) pad GPU images to imagelist.
The two should have equivalent behavior, and indeed it works when I use .cuda() to do the H2D copy.
However it fails when I use scatter()[0] to do the H2D copy (which is what DistributedDataParallel would use).
If I ran this command on 2 GPUs, after applying the diff:
python -m torch.distributed.launch --nproc_per_node=2 tools/train_net.py --config-file configs/e2e_mask_rcnn_R_50_FPN_1x.yaml SOLVER.IMS_PER_BATCH 4 SOLVER.BASE_LR 0.0001

I observed two types of failures after dozens of iterations:

assert diff < 0.01 failed, which means the data was different after the copy.

  File "/maskrcnn-benchmark/maskrcnn_benchmark/engine/trainer.py", line 73, in do_train
    assert diff < 0.01, diff
AssertionError: tensor(139.0213)

It met NaN and throws the error, which did not happen if I use .cuda() to do the copy.

It seems to be a bug in pytorch's scatter however I found no clues there. I'm also unable to simplify the repro (simplification make the bug disappear) so I posted it here.
Environment
PyTorch version: 1.0.0
Is debug build: No
CUDA used to build PyTorch: 9.0.176
OS: Ubuntu 18.04.1 LTS
GCC version: (GCC) 5.3.0
CMake version: version 3.12.2
Python version: 3.6
Is CUDA available: Yes
CUDA runtime version: 9.0.176
GPU models and configuration:
GPU 0: Quadro GP100
GPU 1: Quadro GP100
Nvidia driver version: 410.79
cuDNN version: Could not collect
Versions of relevant libraries:
[pip3] msgpack-numpy==<IP_ADDRESS>
[pip3] numpy==1.16.1
[pip3] numpydoc==0.7.0
[pip3] torch==1.0.0
[pip3] torchvision==0.2.1
[conda] blas                      1.0                         mkl
[conda] mkl                       2019.1                      144
[conda] mkl-include               2019.1                      144
[conda] mkl-service               1.1.2            py36he904b0f_5
[conda] mkl_fft                   1.0.6            py36hd81dba3_0
[conda] mkl_random                1.0.2            py36hd81dba3_0
[conda] pytorch                   1.0.0           py3.6_cuda9.0.176_cudnn7.4.1_1    pytorch
[conda] torchvision               0.2.1                      py_2    pytorch

Hi,
There seems to be a problem with the streams in scatter, maybe in the stream synchronization. If you comment out this line in PyTorch, then the code runs fine on my end.
A few wild guesses: this is either:

a problem with cuda_guard.reset_stream, which is only used in this place in the codebase (also in Gloo backend, but I've never really used gloo)
streams are not working properly with .to(..., non_blocking=True)
there is something missing in here

@mrshenli this is probably something related to https://github.com/pytorch/pytorch/pull/16966

@fmassa I agree with you, as you pointed out that the error disappears after commenting out _get_stream. Before pytorch/pytorch#16966, copy are always synchronized on the destination devices default stream.  Now, it is synchronized on the destination devices' current stream (behavior on src device is unchanged), which means:

multiple copy can overlap on the destination device
subsequent CUDA ops can now access the tensor before the copy finishes on the destination device.

I will look into this.

@ppwwyyxx
Is orig_images on cpu or gpu in this failed case?

@mrshenli any updates on this issue?

@ppwwyyxx  I was working on another urgent task. Back to this one now. :)

hmm, I tried both the following code and tools/train_net.py with your patch with DDP on devgpu, but cannot reproduce it (will try devfair next). May I ask if you can consistently reproduce this error? @ppwwyyxx
import argparse
from torch.nn.parallel.scatter_gather import scatter
import torch
import torch.distributed as dist

parser = argparse.ArgumentParser()
parser.add_argument("--local_rank", type=int, default=0)
args = parser.parse_args()
torch.cuda.set_device(args.local_rank)

dist.init_process_group(backend="nccl", init_method="env://")

print ("=== starting ", args.local_rank, ", ", dist.get_rank())

images = [torch.randn(3, 128, 128) for _ in range(10000)]

orig_images = images
images = [scatter(im, [dist.get_rank()])[0] for im in images]

for orig_im, im in zip(orig_images, images):
    diff = (orig_im - im.cpu()).abs().max()
    if diff != 0:
        print(diff)

@fmassa are you able to consistently reproduce this error with PyTorch master branch?

The instruction to reproduce is posted in the original issue. I cannot reproduce it with a simplified example.

Thanks, let me try

great, hit the bug using detectron2

Fixed by pytorch/pytorch/pull/18465


Publish 0.1.9 version

Please publish 0.1.9 version into Sonatype repository

@ground5hark Could you please publish the 0.1.9 version? Thanks!

@ground5hark You probably also want to git-tag the version


ci: set up artifact building

I'd say that using msvc toolchain is better than gnu for windows, but I guess it's not that hard to fix myself so it's fine. Big thanks for your contribution!

Also the cargo make "build" task is essentially not that useful, as the assets packaging is done inside the workflow and not in the task itself. Might be better to make a task which packs the resources and copies files to some build directory.
Or... Embed resources inside the binary 👀


Create a file General/OperatingSystem.md

Instructions:
Open folder General
Inside that folder make a file Web/OperatingSystem.md
Write content for it

Hi @Iliveinbianries !Could you plz assign this issue to me? and plz add hacktoberfest label. Thankyou

Hi @Iliveinbianries !I have done the task and pr.


[core] Fix a typo in the comment in setup test files

[x] I have followed (at least) the PR section of the contributing guide.

Found this minor typo while looking into https://github.com/mui/material-ui/pull/35980.

It is trivial, so I am merging this.