[Hub Generated] Review request for Microsoft.Insights to add version stable/2018-03-01

This is a PR generated at OpenAPI Hub. You can view your work branch via this link.
Changelog
Please ensure to add changelog with this PR by answering the following questions.

What's the purpose of the update?

[ ] new service onboarding
[ ] new API version
[ ] update existing version for new feature
[ ] update existing version to fix swagger quality issue in s360
[ ] Other, please clarify

When you are targeting to deploy new service/feature to public regions? Please provide date, or month to public if date is not available yet.
When you expect to publish swagger? Please provide date, or month to public if date is not available yet.
If it's an update to existing version,  please select SDKs of specific language and CLIs that require refresh after swagger is published.

[ ] SDK of .NET (need service team to ensure code readiness)
[ ] SDK of Python
[ ] SDK of Java
[ ] SDK of Js
[ ] SDK of Go
[ ] PowerShell
[ ] CLI
[ ] Terraform
[ ] No, no need to refresh for updates in this PR

Contribution checklist:

[ ] I commit to follow the Breaking Change Policy of “no breaking changes
[ ] I have reviewed the documentation for the workflow.
[ ] Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist

[ ] Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.

Adding new API(s)
Adding a new API version
Adding a new service

[ ] Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

[ ] If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist
If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.

[ ] Removing API(s) in stable version
[ ] Removing properties in stable version
[ ] Removing API version(s) in stable version
[ ] Updating API in stable version with Breaking Change Validation errors
[ ] Updating API(s) in preview over 1 year

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.

@akning-ms can you please take a look on the model validations error, it seems like false alerts

@akning-ms can you please take a look on the model validations error, it seems like false alerts

@akning-ms can you please take a look on the model validations error, it seems like false alerts
@raych1 to help, BTW, you can also refer to  https://github.com/Azure/azure-rest-api-specs/pull/12372#issuecomment-758124799
get specific tool owner for help next time.

@akning-ms can you please take a look on the model validations error, it seems like false alerts
@raych1 to help, BTW, you can also refer to  https://github.com/Azure/azure-rest-api-specs/pull/12372#issuecomment-758124799
get specific tool owner for help next time.

take a look on the model validatio

@yashmuel , it's same issue of another PR#12371. You could suppress this error in readme.md this time. Going forward in new API version, please reference the TrackedResource in common-types definition.

take a look on the model validatio

@yashmuel , it's same issue of another PR#12371. You could suppress this error in readme.md this time. Going forward in new API version, please reference the TrackedResource in common-types definition.

@weidongxu-microsoft can you please merge?

@weidongxu-microsoft can you please merge?


Credit side panel icons

The configuration item icons have no credit information whatsoever. These were "prototype" icons that ended up being used in the final app, and so the original sources were also lost.

First-time wizard icons also need to be looked into.

Apparently this was being tracked here: https://github.com/retrohub-org/retrohub/blob/main/assets/icons/first_time/sources


Unable to browse after azure deploy

In step #6, I only get a "Site can't be reached" (SF mgmt console shows the cluster itself is healthy). Any ideas welcome. Thanks.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 089974a0-7387-0266-d499-362153ed2851
Version Independent ID: f3a0c273-e276-6eab-9a24-e4b0603274e4
Content: Deploy an Azure Service Fabric application to a cluster from Visual Studio
Content Source: articles/service-fabric/service-fabric-tutorial-deploy-app-to-party-cluster.md
Service: service-fabric
GitHub Login: @rwike77
Microsoft Alias: mikhegn

@c42-arun Thanks for the feedback! We are currently investigating and will update you shortly.

@rwike77 can you help on this? I followed the doc and was able to deploy a cluster and connect to the cluster manager:

However, I am seeing the same problem as @c42-arun when trying to hit the app as mentioned in step 6. In fact, if I attempt to deploy my script again I am also seeing a endpoint connection failure:
Voting -> C:\Users\mimckitt\Downloads\service-fabric-dotnet-quickstart-master\service-fabric-dotnet-quickstart-master\Voting\pkg\Debug -------- Package: Project: Voting succeeded, Time elapsed: 00:00:26.0311925 -------- 2>Started executing script 'Deploy-FabricApplication.ps1'. 2>powershell -NonInteractive -NoProfile -WindowStyle Hidden -ExecutionPolicy Bypass -Command ". 'C:\Users\mimckitt\Downloads\service-fabric-dotnet-quickstart-master\service-fabric-dotnet-quickstart-master\Voting\Scripts\Deploy-FabricApplication.ps1' -ApplicationPackagePath 'C:\Users\mimckitt\Downloads\service-fabric-dotnet-quickstart-master\service-fabric-dotnet-quickstart-master\Voting\pkg\Debug' -PublishProfileFile 'C:\Users\mimckitt\Downloads\service-fabric-dotnet-quickstart-master\service-fabric-dotnet-quickstart-master\Voting\PublishProfiles\Cloud.xml' -DeployOnly:$false -ApplicationParameter:@{} -UnregisterUnusedApplicationVersionsAfterUpgrade $false -OverrideUpgradeBehavior 'None' -OverwriteBehavior 'SameAppTypeAndVersion' -SkipPackageValidation:$false -ErrorAction Stop" 2>WARNING: Failed to contact Naming Service. Attempting to contact Failover Manager Service... 2>WARNING: Failed to contact Failover Manager Service, Attempting to contact FMM... 2>WARNING: The requested address is not valid in its context <IP_ADDRESS>:19000 2>Connect-ServiceFabricCluster : No cluster endpoint is reachable, please check if there is connectivity/firewall/DNS  2>issue. 2>At C:\Users\mimckitt\Downloads\service-fabric-dotnet-quickstart-master\service-fabric-dotnet-quickstart-master\Voting\S 2>cripts\Deploy-FabricApplication.ps1:185 char:16 2>+ ...      [void](Connect-ServiceFabricCluster @ClusterConnectionParameters ... 2>+                 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 2>    + CategoryInfo          : InvalidOperation: (:) [Connect-ServiceFabricCluster], FabricException 2>    + FullyQualifiedErrorId : TestClusterConnectionErrorId,Microsoft.ServiceFabric.Powershell.ConnectCluster 2>  2>WARNING: Unable to verify connection to Service Fabric cluster. 2>Test-ServiceFabricClusterConnection : Cluster connection instance is null 2>At C:\Program Files\Microsoft SDKs\Service  2>Fabric\Tools\PSModule\ServiceFabricSDK\Publish-UpgradedServiceFabricApplication.ps1:150 char:16 2>+         [void](Test-ServiceFabricClusterConnection) 2>+                ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 2>    + CategoryInfo          : ResourceUnavailable: (:) [Test-ServiceFabricClusterConnection], NullReferenceException 2>    + FullyQualifiedErrorId : GetClusterConnectionErrorId,Microsoft.ServiceFabric.Powershell.TestClusterConnection 2>  2>Finished executing script 'Deploy-FabricApplication.ps1'. 2>Time elapsed: 00:02:07.4835863 2>The PowerShell script failed to execute. ========== Build: 1 succeeded, 0 failed, 2 up-to-date, 0 skipped ========== ========== Publish: 0 succeeded, 1 failed, 0 skipped ==========

Cluster explorer is working fine, but the website is not opening as mentioned in step#6. giving error "Site can't be reached".

Think might have figured this out - I don't have access to the code right now but I did recall the endpoint to be set in ServiceManifest.xml  under VotingWeb/PackageRoot folder. One needs to map this port to the LB's rules i.e map incoming 80 to the specified back end port.
I'll check this again when I get a chance.

Were you able to resolve the issue? i am also facing the same.

@c42-arun Yes, you're correct.  The application port (8080 in the downloaded sample application) needs to be opened in the Azure load balancer.  You can do that in the Azure portal, or use a PowerShell script.  I'll update this article.  Apologies for the inconvenience, thanks for pointing this out.

I've updated the article with info on finding the service endpoint and opening a port in the load balancer.
#please-close

I am also facing the same issue of not beign able to browse to the application after deployment. Tried mapping as mentioned by @c42-arun. Sill no luck. Can this be verified and clear instructions given to browse to the application end point.


fix modified time for Google Cloud Storage

@mattsolo1 there's a long comment in this change that explains the rationale behind it, but please let me know if you'd like more detail.

I think this looks good. But first need to resolve https://github.com/broadinstitute/gnomad-browser/issues/913 so that CI passes.

@mattsolo1 I rebased this and now black runs, but as you can see here CI is now failing because black complains about other files in that directory that this PR doesn't touch.
There are probably two ways to solve this: one would be to open a separate branch, let black reformat everything, and rebase on top of that. Or, assuming black is like other formatters I've used in the past, there's probably a way to have it check only files modified in the PR.
The first approach leaves you with a neater codebase, but also introduces noise into the commit history that can complicate certain tasks later. Do you have a preference?

I think I'm fine with the first approach of running the formatter on these files. Can you make that a PR that we can look to see how extensive the formatting changes are?


Overriding mountpoint in webhooks has no effect

Environment

VerneMQ Version: master
OS: any
Erlang/OTP version (if building from source): 19.3

Expected behavior
When overriding the mountpoint in a webhook I would expect the client to be assigned the new mointpoint
Actual behaviour
The client still has the old mountpoint.
Note: this has to do with the fact that the vmq_mqtt_fsm only expects the modifier subscriber_id and not the individual client_id and mountpoint.

The solution here would be to return a subscriber_id for the auth_on_register hook from within the webhooks (and diversity plugin) instead of separate client_id and mountpoint values so it conforms with the documented  (and of vmq_mqtt_fsm expected) behaviour of the auth_on_register hook.


Vote result is not storing if you change your decision too fast

If you click "+1", but later change your decision, you can make two "−1" clicks. If you make these clicks fast, UI responses properly, decreasing votes by 2. But a few moments later vote count increases by 1.

Actually, UI updates voting score before voting request (like an optimistic UI) and after (just to show actual information). But, yeah, there was a request race condition. Now it fixed, and vote requests are processing one by one.
BTW, it's still possible to get “wrong” voting score, because of intermediate values. For example:
user presses +1 → score updates to +1
user presses −1 → score updates to 0
user presses −1 → score updates to −1
request for +1 are processed → score updates to +1 (because it's true current value)
first request for −1 are processed → score updates to 0
second request for −1 are processed → score updates to −1

So, at the end we have true value. And I'm not sure that we need to make UI more complex due to additional processing of these intermediate values. Nevertheless I will try to fix it in the future when we rewrite UI's store.
But, for now the race condition is fixed. Thanks!


import wyze_sdk

[2/1/2024, 3:58:33 PM] [WyzeRoboVac] error: Command failed: python3 /usr/local/lib/node_modules/homebridge-wyze-robovac/py_helpers/getVacuumDeviceList.py  Traceback (most recent call last):   File "/usr/local/lib/node_modules/homebridge-wyze-robovac/py_helpers/getVacuumDeviceList.py", line 4, in <module>     import wyze_sdk ModuleNotFoundError: No module named 'wyze_sdk'
Removed personal info.
Getting that error when running the plugin. I installed the wyze sdk by inputting pip install wyze_sdk in the command terminal and I verified that it was installed. I did a restart on my server and computer and the problem still persists.

Got it fixed.

Resolved that issue.


Fix timtest timer index

Change timtest timer index start at 0

LGTM

I do not think we want to make this change. The timtest application is a bit of a tricky one as it sort of depends on bsp/mcu for timer support. If the mcu does not have enough timers this application will not work. I think pretty much every mcu will have a few timers so was not terribly worried about this.
Another issue with this change is that TIMER_1 and TIMER_2 syscfg values are set to 1 in syscfg.yml for this app. That is why main.c uses TIMER_1 and TIMER_2.
A better way to change this might be to determine if the timer is actually enabled in main.c and use timers that actually exist without having to really on syscfg.yml (which may not apply to the bsp).
One final note: timtest should not use a timer that the os is using for its timing. So that is another thing to worry about.

@wes3 Or maybe we can move these setting to pkg.yml? since I saw that not every bsp have the same setting of timer.

@lulouie, this is best handled by the specific app. Coming up with something generic that works for all different bsp/mcu is too tricky. We will be closing this PR.

@lulouie, could you please close the PR (based on the history and comments).


point cloud range update

hey,
Thanks for open sourcing this work
I wanted to know if i want to detect objects only in front of lidar, apart changing this parameter
https://github.com/mit-han-lab/bevfusion/blob/main/configs/nuscenes/default.yaml#L9
what else i would have to change?
for ex: I want to use  [0.0, -54.0, -5.0, 108.0, 54.0, 3.0] as my range
How will this change affect the vtransform xbounds or voxel grid size?
similarly, if i change my image final sixe to 1500*2048, how will it affect the encoder parameters?
thanks

Yes, I think you also need to change the vtransform xbounds but you do not need to change the voxel grid sizes. For the final image size, it will be better to scale image_size and 2D augmentation scales accordingly. Just make sure the desired image size approximately lies in the middle of your augmentation interval. By the way, it is recommended to make sure that the final image size is divisible by 32.

hey @kentang-mit,
can you tell why have you defined point cloud ranges in different places, as here,
https://github.com/mit-han-lab/bevfusion/blob/main/configs/nuscenes/default.yaml#L9
https://github.com/mit-han-lab/bevfusion/blob/main/configs/nuscenes/det/transfusion/secfpn/camera%2Blidar/swint_v0p075/default.yaml#L2

thanks for the clarification.
One other thing, i was trying to train the lidar only model with pointpillars as backbone. And I received this error.
This is the trace
File "/home/predev/repos/rgupta38/bevfusion-git/mmdet3d/apis/train.py", line 140, in train_model
runner.run(data_loaders, [("train", 1)])
File "/home/predev/repos/rgupta38/bevfusion-git/mmdet3d/runner/epoch_based_runner.py", line 253, in run
epoch_runner(data_loaders[i], **kwargs)
File "/home/predev/repos/rgupta38/bevfusion-git/mmdet3d/runner/epoch_based_runner.py", line 315, in train
super().train(data_loader, **kwargs)
File "/home/predev/repos/rgupta38/bevfusion-git/mmdet3d/runner/epoch_based_runner.py", line 173, in train
self.run_iter(data_batch, train_mode=True, **kwargs)
File "/home/predev/repos/rgupta38/bevfusion-git/mmdet3d/runner/epoch_based_runner.py", line 152, in run_iter
outputs = self.model.train_step(data_batch, self.optimizer,
File "/home/predev/.local/lib/python3.8/site-packages/mmcv/parallel/distributed.py", line 52, in train_step
output = self.module.train_step(*inputs[0], **kwargs[0])
File "/home/predev/repos/rgupta38/bevfusion-git/mmdet3d/models/fusion_models/base.py", line 78, in train_step
losses = self(**data)
File "/home/predev/.local/lib/python3.8/site-packages/torch/nn/modules/module.py", line 889, in _call_impl
result = self.forward(*input, **kwargs)
File "/home/predev/.local/lib/python3.8/site-packages/mmcv/runner/fp16_utils.py", line 128, in new_func
output = old_func(*new_args, **new_kwargs)
File "/home/predev/repos/rgupta38/bevfusion-git/mmdet3d/models/fusion_models/bevfusion.py", line 189, in forward
outputs = self.forward_single(
File "/home/predev/.local/lib/python3.8/site-packages/mmcv/runner/fp16_utils.py", line 128, in new_func
output = old_func(*new_args, **new_kwargs)
File "/home/predev/repos/rgupta38/bevfusion-git/mmdet3d/models/fusion_models/bevfusion.py", line 272, in forward_single
pred_dict = head(x, metas)
File "/home/predev/.local/lib/python3.8/site-packages/torch/nn/modules/module.py", line 889, in _call_impl
result = self.forward(*input, **kwargs)
File "/home/predev/repos/rgupta38/bevfusion-git/mmdet3d/models/heads/bbox/transfusion.py", line 353, in forward
res = multi_apply(self.forward_single, feats, [None], [metas])
File "/home/predev/.local/lib/python3.8/site-packages/mmdet/core/utils/misc.py", line 30, in multi_apply
return tuple(map(list, zip(*map_results)))
File "/home/predev/repos/rgupta38/bevfusion-git/mmdet3d/models/heads/bbox/transfusion.py", line 306, in forward_single
query_feat = self.decoder[i](
File "/home/predev/.local/lib/python3.8/site-packages/torch/nn/modules/module.py", line 889, in _call_impl
result = self.forward(*input, **kwargs)
File "/home/predev/repos/rgupta38/bevfusion-git/mmdet3d/models/utils/transformer.py", line 100, in forward
key=self.with_pos_embed(key, key_pos_embed),
File "/home/predev/repos/rgupta38/bevfusion-git/mmdet3d/models/utils/transformer.py", line 69, in with_pos_embed
return tensor if pos_embed is None else tensor + pos_embed
RuntimeError: The size of tensor a (16384) must match the size of tensor b (65536) at non-singleton dimension 0
this is the logfile
20230104_194735.txt
can you help here @kentang-mit

Hi @RG2806,
I never tried PointPillars with a transfusion head. However It could work with the centerhead. The configuration for the LiDAR part looks like this:
voxel_size: [0.2, 0.2, 8]

model:
  encoders:
    lidar:
      voxelize_reduce: false
      voxelize:
        max_num_points: 20
        point_cloud_range: ${point_cloud_range}
        voxel_size: ${voxel_size}
        max_voxels: [30000, 60000]
      backbone:
        type: PointPillarsEncoder
        pts_voxel_encoder:
          type: PillarFeatureNet
          in_channels: 5
          feat_channels: [64, 64]
          with_distance: false
          point_cloud_range: ${point_cloud_range}
          voxel_size: ${voxel_size}
          norm_cfg:
            type: BN1d
            eps: 1.0e-3
            momentum: 0.01
        pts_middle_encoder:
          type: PointPillarsScatter
          in_channels: 64
          output_shape: [512, 512]
  decoder:
    backbone:
      in_channels: 64
      out_channels: [64, 128, 256]
      layer_nums: [3, 5, 5]
      layer_strides: [2, 2, 2]
    neck:
      in_channels: [64, 128, 256]
      out_channels: [128, 128, 128]
      upsample_strides: [0.5, 1, 2]
  heads:
    object:
      in_channels: 384
      train_cfg:
        grid_size: [512, 512, 1]
        out_size_factor: 4
      test_cfg:
        out_size_factor: 4
      bbox_coder:
        out_size_factor: 4

Best,
Haotian

Hey @kentang-mit
Thanks for the clarification

multiple of 32

@kentang-mit
Hi! Could you tell me why the range / voxel size is recommended to be a multiple of 32 ?


improve pipelines and test

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

16 of 16 (100.0%)  changed or added relevant lines in 1 file are covered.
8 unchanged lines in 1 file lost coverage.
Overall coverage increased (+1.4%) to 96.613%

Files with Coverage Reduction
New Missed Lines
%

moltx/pipelines.py
8
94.48%

Totals

Change from base Build<PHONE_NUMBER>:
1.4%

Covered Lines:
599

Relevant Lines:
620

💛  - Coveralls

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

16 of 16 (100.0%)  changed or added relevant lines in 1 file are covered.
8 unchanged lines in 1 file lost coverage.
Overall coverage increased (+1.4%) to 96.613%

Files with Coverage Reduction
New Missed Lines
%

moltx/pipelines.py
8
94.48%

Totals

Change from base Build<PHONE_NUMBER>:
1.4%

Covered Lines:
599

Relevant Lines:
620

💛  - Coveralls


Stash Pull Request Support

This will allow us to update PRs on Stash instances.
Documentation for the Stash build status API:
https://developer.atlassian.com/stash/docs/latest/how-tos/updating-build-status-for-commits.html
@codeclimate/review

@codeclimate/review ready for another look!

LGTM


is there a way to make quote attribute not required?

I can see scenarios where I just want some text listed and don't need to attribute it. can I turn off the requirement for this and if I don't have it it'll just be blank?

Hey Dan, check out www/js/quotable.js from the branch "quotable-no-source". I don't think this is something we want to enable by default, but it's not too hard to monkey patch some of the code to make it work this way.

there's a branch, but this is not desirable for us


Align main with changes needed for hybrid publish

As it appear, altho commonjs cannot use ES modules - ES modules can use commonjs, with the limits that export default is emitted.
After trying every version of hybrid build, apparently the simplest option is the best one.
We build into commonjs, in our index.ts we are using export default, and the package can be used for all type of users.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Looks like you're reverting pretty much all of the PR you did for the hybrid mode, what changes are left to support ECMA?
@barshaul
So what we had before is an ecma build mixed with common in some places.

The first approach where to create different builds, but our usage of different packages for each platform made it impossible, and the solution was almost duplicate all code to different versions, to support the different chains of import statements types.
But apparently, if the whole package compiled to common, and at the starting point common put export default ecma know how to deal with it from there. Not true for the opposite.
So the simple, easy and hidden solution, that no-body mention for some reason, is apparently the best one.


Bug: derive_var_afeye: undesired results are created when xxLAT = "BILATERAL" or potentially dirty data entry

What happened?
Comment from tester: Affected Eye is derived independently from xxLOC values (when xxLOC is missing or not equal to 'EYE'). When STUDYEYE = "BILATERAL" then AFEYE is always set to "STUDY EYE" even when xxLOC and xxLAT are missing.
Session Information
No response
Reproducible Example
No response

Function now follows derivation (e.g. for AE):
"Set to ""BOTH EYES"" when Study Eye Selection (ADSL.STUDYEYE) is not missing, and Study Eye Laterality (AE.AELAT) is equal to ""BILATERAL""
Else set to ""STUDY EYE"" when Study Eye Selection (ADSL.STUDYEYE) is either ""RIGHT"" or ""LEFT"", and matches Study Eye Laterality (AE.AELAT) for the observation record.
Else set to ""STUDY EYE"" when Study Eye Selection (ADSL.STUDYEYE) is ""BILATERAL"", and Study Eye Laterality (AE.AELAT) is not missing for the observation record
Else set to ""FELLOW EYE"" when Study Eye Selection (ADSL.STUDYEYE) is either ""RIGHT"" or ""LEFT"", and (AE.AELAT) is either ""RIGHT"" or ""LEFT"" but are not equal to each other for the observation record.
Else set to null"


Synoptic: filter listed tabs folder

Avoid listing .svn folder or other folders starting with "." on the available synoptic tabs list

This issue was moved to mgear-dev/mgear_dist#6


Add feature to export volunteers as CSV file

Added a new command export that would export the volunteer information into a csv file and save it in a folder "outputs"
Closes #39

:warning: Please install the  to ensure uploads and comments are reliably processed by Codecov.
Codecov Report
Attention: Patch coverage is 0% with 28 lines in your changes missing coverage. Please review.

Files with missing lines
Patch %
Lines

...va/seedu/address/logic/commands/ExportCommand.java
0.00%
27 Missing :warning:

.../seedu/address/logic/parser/AddressBookParser.java
0.00%
1 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Files with missing lines
Coverage Δ
Complexity Δ

.../seedu/address/logic/parser/AddressBookParser.java
90.47% <0.00%> (-9.53%)
12.00 <0.00> (ø)

...va/seedu/address/logic/commands/ExportCommand.java
0.00% <0.00%> (ø)
0.00 <0.00> (?)


implement support for BGP import filters

Current Behavior
currently, the BGP import policy is hardcoded to import all in bird.cfg.template
Expected Behavior
there should be a way to specify import filters, when configuring a (global/node specific) peer
Possible Solution
perhaps a similar solution to #1604 ?
Context
Depending on the topology, an external peer might announce workload addresses (maliciously/accidentally), and cause traffic to leak (sent somewhere else, instead of the node running the workload), if the preferred route is learned from this peer.
Your Environment

Calico version: 2.6.2
Orchestrator version (e.g. kubernetes, mesos, rkt): Kubernetes 1.9.1

Fixed by #7271
https://docs.tigera.io/calico/latest/reference/resources/bgpfilter


Fix replication with visibility policy != VisibilityPolicy::All

Visibility was coupled with a check if a client was just connected. This resulted in a passed test that checks replication of previously spawned entities (it was running with VisibilityPolicy::All). But for all other policies the logic was incorrect and led to a crash with "entity should be present after adding component".
I decoupled the logic. We now determine if the entity is new to a client by checking if it has a tick.
I thinking that we need to rename "change limit" into "init tick" because we use this terminology on client. But it will be a breaking change, so I will leave it for the next release.

Add test to document the bug?

We have a test for it, but it didn't trigger the bug because the check for new entities was tied to the visibility policy :)


Can not search "Debugger for iOS"

VSCode Version: 1.18.0-insiders
OS Version: win10

Steps to Reproduce:

Search “Debugger for iOS”
Can not find "iOS Web Debugger for Visual Studio Code"
And this page have been 404

So no longer support debug for ios webpage?

Reproduces without extensions: Yes

The iOS web debugger has been deprecated. Please see https://github.com/Microsoft/vscode-ios-web-debug for next steps.


Compilation Error

/home/mcpe/src/mcpelauncher-manifest/mcpelauncher-linker/core/liblog/logger_write.cpp:147:20: error: no member named 'unique_lock' in namespace 'std'
  auto lock = std::unique_lock{default_tag_lock};
              ~~~~~^
/home/mcpe/src/mcpelauncher-manifest/mcpelauncher-linker/core/liblog/logger_write.cpp:147:31: error: expected ';' at end of declaration
  auto lock = std::unique_lock{default_tag_lock};
                              ^
                              ;
/home/mcpe/src/mcpelauncher-manifest/mcpelauncher-linker/core/liblog/logger_write.cpp:170:20: error: no member named 'unique_lock' in namespace 'std'
  auto lock = std::unique_lock{logger_function_lock};
              ~~~~~^
/home/mcpe/src/mcpelauncher-manifest/mcpelauncher-linker/core/liblog/logger_write.cpp:170:31: error: expected ';' at end of declaration
  auto lock = std::unique_lock{logger_function_lock};
                              ^
                              ;
/home/mcpe/src/mcpelauncher-manifest/mcpelauncher-linker/core/liblog/logger_write.cpp:187:20: error: no member named 'unique_lock' in namespace 'std'
  auto lock = std::unique_lock{aborter_function_lock};
              ~~~~~^
/home/mcpe/src/mcpelauncher-manifest/mcpelauncher-linker/core/liblog/logger_write.cpp:187:31: error: expected ';' at end of declaration
  auto lock = std::unique_lock{aborter_function_lock};
                              ^
                              ;

Building with:
git clone --recursive https://github.com/minecraft-linux/mcpelauncher-manifest
cd mcpelauncher-manifest
git checkout ng
git submodule init
git submodule update --recursive
mkdir build && cd build
CC=clang CXX=clang++ cmake -DCMAKE_INSTALL_PREFIX=/usr -DCMAKE_BUILD_TYPE=RelWithDebInfo -DENABLE_DEV_PATHS=OFF -Wno-dev ..
CC=clang CXX=clang++ make

Solved by adding missing includes with Sed.
sed -i '22i#include <mutex>' mcpelauncher-linker/core/liblog/logger_write.cpp
sed -i '26i#include <limits>' mcpelauncher-linker/core/libziparchive/zip_archive_stream_entry.cc

It might be a good idea to update the android dependencies someday, this works without changes with older libstc++ than you are using.
libstdc++ has started last year to remove implicit includes, so it compiles on older linux distros.

mcpelauncher-linker/core/liblog/logger_write.cpp

Google seem to have removed the mutex stuff completly, some weeks or month after I frozen the dependency to android sources.
This is a valid issue, I will look into this once I update this library. Hopefully I won't need to fork the android code.

Additions, it seems core no longer compiles (libziparchive):
/home/thearcanebrony/mcpelauncher/mcpelauncher/mcpelauncher-linker/core/libziparchive/zip_archive_stream_entry.cc:220:49: error: unexpected type name 'uint32_t': expected expression
      DCHECK_LE(in_.size(), std::numeric_limits<uint32_t>::max());  // Should be buf size = 64k.
                                                ^
/home/thearcanebrony/mcpelauncher/mcpelauncher/mcpelauncher-linker/core/libziparchive/zip_archive_stream_entry.cc:220:60: error: no member named 'max' in the global namespace
      DCHECK_LE(in_.size(), std::numeric_limits<uint32_t>::max());  // Should be buf size = 64k.
                                                         ~~^
/home/thearcanebrony/mcpelauncher/mcpelauncher/mcpelauncher-linker/core/libziparchive/zip_archive_stream_entry.cc:220:34: error: no member named 'numeric_limits' in namespace 'std'
      DCHECK_LE(in_.size(), std::numeric_limits<uint32_t>::max());  // Should be buf size = 64k.
                            ~~~~~^

I also fixed missing limits in zip_archive_stream_entry.cc with https://github.com/minecraft-linux/mcpelauncher-linker/commit/70ae6dc83847f551bb9e304a68a1658505005c9b, by wrapping the c++ file.

I've updated the AUR package to not use the sed commands. Thanks!


(GnssMonitor) OnLocationChanged query of AllMessages clashes with collection update

I tacked on the GnssMonitor class to the current NuGet build to test a Bluetooth GPS device with the HoloLens, but accessing properties that come from AllMessages eventually clashes with the message update process. Am I approaching the use of OnLocationChanged wrong, or can this be fixed?
private async void OnLocationChanged(object sender, EventArgs e)
{
    await Dispatcher.RunAsync(Windows.UI.Core.CoreDispatcherPriority.Normal, () =>
    {
        TxtBlockGps.Text = $"Timestamp: {DateTime.Now.TimeOfDay.ToString()}\n"
            + $"Latitude: {_monitor.Latitude,7:0.00}° (Accuracy: {_monitor.HorizontalError} m)\n"
            + $"Longitude: {_monitor.Longitude,7:0.00}°\n"
            + $"Altitude: {_monitor.Altitude} m (Accuracy: {_monitor.VerticalError} m)\n"
            + $"Satellites in view: {_monitor.SatellitesInView}";
    });
}

Good catch. I can see how that could be a threading issue.

Thank you for trying it out and giving this valuable feedback. I've pushed the fix.


Exceeding "max_tries" throws "Fatal undefined"

I was using Request to scrap some pages and started getting "Fatal undefined" errors. After A WHILE I figured what's happening and was able to reproduce the problem by minimally altering the code in your example:
var Promise = require('bluebird');
var retry = require('bluebird-retry');

var count = 0;
function myfunc() {
    console.log('myfunc called ' + (++count) + ' times');
    if (count < 10) {
        return Promise.reject(10);
    } else {
        return Promise.resolve('succeed the third time');
    }
}

retry(myfunc).done(function(result) {
    console.log(result);
});

view diff
console output:
C:\my-project-folder>node script.js
myfunc called 1 times
myfunc called 2 times
myfunc called 3 times
myfunc called 4 times
myfunc called 5 times
Fatal undefined

C:\my-project-folder>

You should consider displaying error message which is easier to understand like "Fatal: You have exceeded maximum number of retries which is 5. You can alter 'max_tries' option if you want to retry more times".

@tomaskikutis The problem here was that if the called function rejects with a non-Error, the timeout logic didn't properly format an error to return.
I fixed this in #29 so your example now results in:
myfunc called 1 times
myfunc called 2 times
myfunc called 3 times
myfunc called 4 times
myfunc called 5 times
Fatal Error: operation timed out after 4012 ms, 5 tries with error: rejected with non-error: 10
    at /Users/demmer/work/bluebird-retry/lib/bluebird-retry.js:95:35
    at tryCatcher (/Users/demmer/work/bluebird-retry/node_modules/bluebird/js/release/util.js:16:23)
    at /Users/demmer/work/bluebird-retry/node_modules/bluebird/js/release/catch_filter.js:24:41
    at tryCatcher (/Users/demmer/work/bluebird-retry/node_modules/bluebird/js/release/util.js:16:23)
    at Promise._settlePromiseFromHandler (/Users/demmer/work/bluebird-retry/node_modules/bluebird/js/release/promise.js:503:31)
    at Promise._settlePromise (/Users/demmer/work/bluebird-retry/node_modules/bluebird/js/release/promise.js:560:18)
    at Promise._settlePromise0 (/Users/demmer/work/bluebird-retry/node_modules/bluebird/js/release/promise.js:605:10)
    at Promise._settlePromises (/Users/demmer/work/bluebird-retry/node_modules/bluebird/js/release/promise.js:680:18)
    at Async._drainQueue (/Users/demmer/work/bluebird-retry/node_modules/bluebird/js/release/async.js:126:16)
    at Async._drainQueues (/Users/demmer/work/bluebird-retry/node_modules/bluebird/js/release/async.js:136:10)
    at Immediate.Async.drainQueues [as _onImmediate] (/Users/demmer/work/bluebird-retry/node_modules/bluebird/js/release/async.js:16:14)
    at processImmediate [as _immediateCallback] (timers.js:383:17)

This fix has been included in the 0.7.0 release I just published.


Segfault when using timeloop-python with Tensorflow

Hello,
I'm using timeloop-python bindings from a python project that involves using TensorFlow.
However, importing tensorflow while using timeloop-python bindings results in a seg fault. It appears that there is a conflict when using timeloop-python bindings in a program that also uses tensorflow/keras. My guess is that this is due to tensorflow and timeloop-python packages both having submodules named "Model". The issue can be reproduced by simply importing tensorflow into the "examples/model.py" example.
I understand this is a non-trivial issue, and probably does not concern with normal usage of this package. But I would appreciate any suggestions to solve this problem.
Otherwise, a possible solution that I could think was first to write mappings into a yaml file, and then using "os.system()" call to invoke an example script similar to "examples/model.py" that would read the yaml and evaluate the mapping. But obviously, this defeats the whole purpose of having these python bindings.
I'd appreciate any help.
Thank you

Hello, is there any possible solution to this? I would really appreciate any help.
Thanks

Hi @suyashbakshi thank you for bringing this to our attention. I agree with you that this is probably a non-trivial issue, but I disagree that this is not an instance of "normal" use of this package. We definitely want to support this use case. You are also correct that going via a YAML file defeats the entire purpose of this approach.
We apologize for the delay and would truly appreciate your help in debugging this. Does renaming "Model" to something else, e.g., "TimeloopModel" resolve the issue?

Thank your for the response. I'm guessing that renaming would solve the problem, given that the simple act of importing tensorflow while using Timeloop-python causes the program to crash. Whether there are any other dependencies or issues causing the crash, I'm not entirely sure.

Since you have everything set up could you test your hypothesis on the renaming (maybe rename it to TimeloopModel) and let us know? Or preferably even submit a patch?

I'm also going to try to reproduce. I'll get back with my results.

Update: I couldn't reproduce the error. I don't see a module named Model in PyTimeloop. I see ModelApp from pytimeloop.app and the module pytimeloop.model. I also can't find a Tensorflow module named model.
@suyashbakshi Could you give me more information about how you produced the error?
I agree with @angshuman-parashar that this is a not an uncommon use of this package. It's quite an important issue.

@angshuman-parashar I will try and get back.
@gilbertmike You can reproduce the error/crash by importing TensorFlow in the "examples/model.py" script.
The same error/crash occurs for my own project, where if I have the following imports in my script:
from pytimeloop.app import model
from pytimeloop import Config

and at the same time I import Tensorflow module as: import tensorflow as tf

Ok, I see the error. Thank you.

I haven't seen the root cause of the issue yet, but I think you might be right. I backtraced the crash with gbd and I saw that Tensorflow were calling pybind routines. PyTimeloop also uses pybind. Renaming doesn't help.
Anyway, I found that if I import Tensorflow before PyTimeloop, I don't see the crash.

@gilbertmike yes I had tried moving the import before/after each other and you're right that putting Tensorflow import before PyTimeloop doesn't cause the crash.
But then the error reported is:
Cannot find 8 under root key: variables
ERROR: bad conversion, at line:

To be clear, the error message is not incomplete, that's the full error reported without any line number, source code file name from where that originated.

That's interesting. I'll have a look at it when I get back from work today.

I took another look at this bug. I think I'm closer to the root cause.
Copy of backtrace:
#0  __pthread_kill_implementation (no_tid=0, signo=6, threadid=140737350250496) at ./nptl/pthread_kill.c:44
#1  __pthread_kill_internal (signo=6, threadid=140737350250496) at ./nptl/pthread_kill.c:78
#2  __GI___pthread_kill (threadid=140737350250496, signo=signo@entry=6) at ./nptl/pthread_kill.c:89
#3  0x00007ffff7c8e476 in __GI_raise (sig=sig@entry=6) at ../sysdeps/posix/raise.c:26
#4  0x00007ffff7c747f3 in __GI_abort () at ./stdlib/abort.c:79
#5  0x00007ffff7cd56f6 in __libc_message (action=action@entry=do_abort, fmt=fmt@entry=0x7ffff7e27b8c "%s\n")
    at ../sysdeps/posix/libc_fatal.c:155
#6  0x00007ffff7cecd7c in malloc_printerr (str=str@entry=0x7ffff7e25764 "free(): invalid pointer") at ./malloc/malloc.c:5664
#7  0x00007ffff7ceeac4 in _int_free (av=<optimized out>, p=<optimized out>, have_lock=0) at ./malloc/malloc.c:4439
#8  0x00007ffff7cf14d3 in __GI___libc_free (mem=<optimized out>) at ./malloc/malloc.c:3391
#9  0x00007ffff66dbc1a in std::locale::_Impl::~_Impl() () from /home/gilbertm/timeloop-project/timeloop/env/../lib/libtimeloop-mapper.so
#10 0x00007ffff5a8cb26 in std::locale::~locale() () from /lib/x86_64-linux-gnu/libstdc++.so.6
#11 0x00007fffc929352b in tensorflow::python_op_gen_internal::AttrValueToPython(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, tensorflow::AttrValue const&, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&) () from /home/gilbertm/timeloop-project/venv/lib/python3.10/site-packages/tensorflow/python/_pywrap_tensorflow_internal.so

@angshuman-parashar Do you know where std::locale::_Impl::~_Impl()  (#9 in backtrace) would be called in Timeloop? I think it's double-freed. I think yaml-cpp might use std::locale which also explains the parse error.

Thanks @gilbertmike , unfortunately that is quite a big roadblock. For my project, an execution that should take order of 2-3 minutes, takes more than an hour to complete.
I will keep trying alternate ways to invoke the timeloop-model from my project.

Thanks @gilbertmike , unfortunately that is quite a big roadblock. For my project, an execution that should take order of 2-3 minutes, takes more than an hour to complete. I will keep trying alternate ways to invoke the timeloop-model from my project.

Do you mean using PyTimeloop takes more than an hour compared to 2-3 minutes native?

@gilbertmike we used to use std::locale explicitly but as far as I can tell we aren't doing that any more. But it's possible that yaml-cpp (or boost?) are using it. @nellie-wu do you have any idea?

No, that's not what I meant. My project, essentially requires invoking timeloop-model in a loop, and within each iteration, a mapping needs to be evaluated. Up till now, I've been using the cost model from "ZigZag" framework, and using their framework to evaluate mappings, my project takes 2-3 minutes to execute. But "ZigZag" does not support mappings for 3D CNNs. My reason to use timeloop is because it supports 3D CNNs.
It is part of my research work, which I would be happy to chat about in detail via email.

No, that's not what I meant. My project, essentially requires invoking timeloop-model in a loop, and within each iteration, a mapping needs to be evaluated. Up till now, I've been using the cost model from "ZigZag" framework, and using their framework to evaluate mappings, my project takes 2-3 minutes to execute. But "ZigZag" does not support mappings for 3D CNNs. My reason to use timeloop is because it supports 3D CNNs.
It is part of my research work, which I would be happy to chat about in detail via email.

Sure, you can reach me at<EMAIL_ADDRESS>Maybe we can work something out.

Hello, I managed to circumvent this issue. I am attaching my solution and a brief explanation below:
I modified the "app.Model.ModelApp()" class slightly and have its modified version in the "model.py" script (in the ZIP). The ZIP also has input files needed to run the script.
From my program, I collect all the potential mappings in a list that I want to evaluate, and dump them into a pickle file (map/map.pickle). I load this pickle file in model.py script (along with arch/arch.yaml and prob/prob.yaml) and use python Multiprocessing to spawn multiple processes and distribute the mappings in the list to processes and evaluate them.
Further, I modified the ModelApp class (https://github.com/Accelergy-Project/timeloop-python/blob/ca64f6c314c020e7498f0d102940748475db153b/pytimeloop/app/model.py) to not expect a "mapping" while creating the ModelApp class' object. Rather, the mapping is provided as part of the config in run(). Since the mappings belong to the same arch and prob, creating a new object for every new mapping does not make sense.
There is only one thing to keep in mind. The call to create a "ModelApp()" object (line #104 in model.py) does not seem to be multiprocessing friendly. By that I mean: if I do not put a lock around that call, then whichever process calls it first, is the process that will proceed to perform its work, and the rest of the processes will get killed and won't perform any evaluation.
Here's the description of files:

model.py: Contains driver method to load arch,prob and mapping files and initiate Multiprocessing. Also contains modified version of "ModelApp" class.
arch/arch.yaml: a sample architecture
prob/prob.yaml: a sample problem
map/map.pickle: Pickle file containing a list of mappings belonging to the arch and prob.
To run, simply execute: python3 model.py

For now, this solves my problem with using PyTimeloop. Although it would be nice to know what's wrong with using this package with TensorFlow. Thank you for all the help, greatly appreciate it :)
pytimeloop_model_example.zip

I merged a large PR recently. As part of the PR, the front end of PyTimeloop was significantly upgraded. It should be much more stable now. That might fix the issue.
If you don't mind trying it again, that would be greatly appreciated.


feature: jobs workers status

Reason for This PR
https://github.com/roadrunner-server/roadrunner/issues/1582#issuecomment-1562957938
Description of Changes
Copy-paste from HTTP plugin
License Acceptance
By submitting this pull request, I confirm that my contribution is made under
the terms of the MIT license.
PR Checklist
[Author TODO: Meet these criteria.]
[Reviewer TODO: Verify that these criteria are met. Request changes if not]

[ ] All commits in this PR are signed (git commit -s).
[ ] The reason for this PR is clearly provided (issue no. or explanation).
[ ] The description of changes is clear and encompassing.
[ ] Any required documentation changes (code and docs) are included in this PR.
[ ] Any user-facing changes are mentioned in CHANGELOG.md.
[ ] All added/changed functionality is tested.

Hey @Kaspiman 👋🏻 Thanks for the PR 👍🏻
The second part is tests: https://github.com/roadrunner-server/rr-e2e-tests
Should be added here: https://github.com/roadrunner-server/rr-e2e-tests/blob/master/plugins/status/plugin_test.go
Feel free to ping me in Discord or here if you have any questions.

Hi! I'm already wortking on https://github.com/roadrunner-server/rr-e2e-tests/blob/master/plugins/status/plugin_test.go.
Do i need to wait merging this MR?


[react] refresh page in dark mode, giscus element with theme=dark property but the iframe element load light.css

If refresh page when giscus-component in viewport, the theme will render correct.
but if refresh page when giscus-component out of viewport, the problem will occur.
current condition:

expext:

I notice previous Issue #1152 ,but after my try, this problem both occur when lazing and eager.
my code
'use client'

import { useEffect, useState } from 'react'
import Giscus from '@giscus/react'
import { shallow } from 'zustand/shallow'
import { useThemeStore } from 'stores/theme-store'

export default function SiteComments(props: { slug: string }) {
  const isDark = useThemeStore(state => state.isDark, shallow)

  const [mounted, setMounted] = useState(false)
  useEffect(() => setMounted(true), [])

  if (!mounted) return null

  return (
    <Giscus
      id={props.slug}
      repo="zhangwh754/blog-comments"
      repoId="R_kgDOLBAVFw"
      category="Announcements"
      categoryId="DIC_kwDOLBAVF84CcNVV"
      mapping="title"
      strict="0"
      reactionsEnabled="1"
      emitMetadata="1"
      inputPosition="top"
      theme={isDark ? 'dark' : 'light'}
      lang="zh-CN"
      loading="lazy"
    />
  )
}

@zhangwh754 When the theme changes, you need to rerender the component. Simply add a 'key' prop to the Giscus component with the theme value. This way, whenever the theme changes, it will update accordingly like so
<Giscus
     key={isDark}
     repo="zhangwh754/blog-comments"
     repoId="R_kgDOLBAVFw"
 />

I can't reproduce it with the incomplete sample code. It's likely because of how the theme is stored and retrieved in your component. Check whether isDark has a different value on the initial render.
Closing for now, I can reopen if you can provide a reproducible example. Thanks.


error ，a configure error! help!

➜  tensorflow git:(master) ✗ ./configure
Please specify the location of python. [Default is /usr/bin/python]:
Found possible Python library paths:
/opt/ros/kinetic/lib/python2.7/dist-packages
/usr/local/lib/python2.7/dist-packages
/usr/lib/python2.7/dist-packages
Please input the desired Python library path to use.  Default is [/opt/ros/kinetic/lib/python2.7/dist-packages]
Using python library path: /opt/ros/kinetic/lib/python2.7/dist-packages
Do you wish to build TensorFlow with MKL support? [y/N]
No MKL support will be enabled for TensorFlow
Please specify optimization flags to use during compilation when bazel option "--config=opt" is specified [Default is -march=native]:
Do you wish to use jemalloc as the malloc implementation? [Y/n]
jemalloc enabled
Do you wish to build TensorFlow with Google Cloud Platform support? [y/N]
No Google Cloud Platform support will be enabled for TensorFlow
Do you wish to build TensorFlow with Hadoop File System support? [y/N]
No Hadoop File System support will be enabled for TensorFlow
Do you wish to build TensorFlow with the XLA just-in-time compiler (experimental)? [y/N]
No XLA support will be enabled for TensorFlow
Do you wish to build TensorFlow with VERBS support? [y/N]
No VERBS support will be enabled for TensorFlow
Do you wish to build TensorFlow with OpenCL support? [y/N]
No OpenCL support will be enabled for TensorFlow
Do you wish to build TensorFlow with CUDA support? [y/N] u
Invalid selection:  u
Do you wish to build TensorFlow with CUDA support? [y/N] y
CUDA support will be enabled for TensorFlow
Do you want to use clang as CUDA compiler? [y/N] n
nvcc will be used as CUDA compiler
Please specify the CUDA SDK version you want to use, e.g. 7.0. [Leave empty to use system default]: 8.0
Please specify the location where CUDA 8.0 toolkit is installed. Refer to README.md for more details. [Default is /usr/local/cuda]:
Please specify which gcc should be used by nvcc as the host compiler. [Default is /usr/bin/gcc]:
Please specify the cuDNN version you want to use. [Leave empty to use system default]:
Please specify the location where cuDNN  library is installed. Refer to README.md for more details. [Default is /usr/local/cuda]:
Please specify a list of comma-separated Cuda compute capabilities you want to build with.
You can find the compute capability of your device at: https://developer.nvidia.com/cuda-gpus.
Please note that each additional compute capability significantly increases your build time and binary size.
[Default is: "3.5,5.2"]:
Do you wish to build TensorFlow with MPI support? [y/N] n
MPI support will not be enabled for TensorFlow
INFO: Options provided by the client:
Inherited 'common' options: --isatty=1 --terminal_columns=80
INFO: Reading options for 'clean' from /home/lulin/tensorflow/tools/bazel.rc:
Inherited 'build' options: --define=use_fast_cpp_protos=true --define=allow_oversize_protos=true --spawn_strategy=standalone --genrule_strategy=standalone -c opt
INFO: Reading options for 'clean' from /home/lulin/tensorflow/.tf_configure.bazelrc:
Inherited 'build' options: --action_env PYTHON_BIN_PATH=/usr/bin/python --action_env PYTHON_LIB_PATH=/opt/ros/kinetic/lib/python2.7/dist-packages --define PYTHON_BIN_PATH=/usr/bin/python --define PYTHON_LIB_PATH=/opt/ros/kinetic/lib/python2.7/dist-packages --force_python=py2 --host_force_python=py2 --python2_path=/usr/bin/python --define with_jemalloc=true --action_env TF_NEED_CUDA=1 --action_env TF_NEED_OPENCL=0 --action_env TF_CUDA_CLANG=0 --action_env CUDA_TOOLKIT_PATH=/usr/local/cuda --action_env TF_CUDA_VERSION=8.0 --action_env GCC_HOST_COMPILER_PATH=/usr/bin/gcc --action_env TF_CUDNN_VERSION= --action_env CUDNN_INSTALL_PATH=/usr/local/cuda-8.0 --action_env TF_CUDA_COMPUTE_CAPABILITIES=3.5,5.2
Unrecognized option: --action_env
bazel is 0.3.0;cuda8.0;cudnn5.0.

You need to upgrade bazel.
TF at head requires bazel version 0.4.5 or higher.

thank!.i had got it.the error is the bazel! thanks


Power BI report on secure public portal that uses custom auth

I don't see a clear point here on how to use a Power BI on a public portal where its "unfeasible" to register users on power bi... think of the scenario of a multi-tenant application where I have financial reports

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 7197c1f9-ff31-f86c-faf3-ab89e4ab9573
Version Independent ID: f30cdf40-43c4-e0c3-4941-a02f5bb28fc1
Content: Embed a report in a secure portal or website - Power BI
Content Source: powerbi-docs/collaborate-share/service-embed-secure.md
Service: powerbi
Sub-service: pbi-collaborate-share
GitHub Login: @maggiesMSFT
Microsoft Alias: maggies

Thanks for your comment, @Leonardo-Ferreira. This issue has been assigned to the doc author for review.

Hi @Leonardo-Ferreira , Thanks for your feedback! I'm moving this issue to our work item backlog for better consideration and tracking, and closing it here in the meantime.


Fix a few regressions introduced in a previous commit

Fixes #103

Regressions fixed are all either typos or due to hasty rephrasing of asserts into if ... raises.


Gemini TypeError: 'sqlite3.Row' object does not support item assignment

Hi,
bcbio somehow fails when trying to run the task 'Prioritize' part.
I not sure what more details I could give. Just ask if there is some important piece missing
/home/mpschr/bin/bcbionextgen/data/anaconda/lib/python2.7/site-packages/bcbio/variation/prioritize.pyc
     34             if gemini_db:
---> 35                 priority_file = _prep_priority_filter(gemini_db, data)
...........................................................................
     90                 writer.writerow(cheader)
     91                 for row in gq:
     92                     ref_depth = tz.get_in(["gt_ref_depths", sidx], row, 0)
     93                     alt_depth = tz.get_in(["gt_alt_depths", sidx], row, 0)
     94                     try:
---> 95                         row.row["freq"] = "%.2f" % (float(alt_depth) / float(ref_depth + alt_depth))
     96                     except ZeroDivisionError:
     97                         row.row["freq"] = "0.00"
     98                     row.row["filter"] = _calc_priority_filter(row, pops)
     99                     if row["chrom"] not in ref_chroms and _hg19_to_GRCh37(row["chrom"]) in ref_chroms:

TypeError: 'sqlite3.Row' object does not support item assignment

I just realized, that altough this error occurs, gemini is running in the background - and the command seems to go just fine. But bcbio exits because of the above shown error

Michael;
Apologies, this is a problem with the latest GEMINI/sqlite where rows no longer allow assignment. I pushed a fix which creates a separate dictionary to collect results and avoids this issue. If you update to the latest development (bcbio_nextgen.py upgrade -u development) it should now work cleanly. Sorry again about the problem and thanks for the report.

Hi Brad,
I can confirm that the fix works. Again, thanks for the quick reaction!


Live update sketch when code changes

Editor can detect the changes in editor and pass the changes with websocket to the canvas window. In global mode browser window handles the message and updates window.[setup/draw/variableName] accordingly.

+1 for this feature.  This would really help speed up sketching.  Also, doing it with a websocket is cool but I don't think it's completely necessary to get livereload functionality.

Look at tools like Browsersync, Webpack etc.  I believe they use websockets and this allows selective updating of assets (e.g. HTML and CSS) without reloading the whole page (also see Brackets.io which will automatically update HTML edits on the fly without even saving the source file!).  Apparently Webpack live-updates JS module changes - which is super cool. Whether that's applicable in the context of p5js I don't know...  Anyway, doing a whole page reload on asset save is old-school...


Is get_insight_block_info() broken?

https://github.com/CounterpartyXCP/counterblock/blob/a564eeb1f50bef7ce8ee0dd702415bdc1a1d3bd3/counterblock/lib/processor/api.py#L58-L61
I couldn't blockchain.getBlockInfo() in the develop branch. Should we remove this API or fix to work again?

Counterblock is slowly slipping into obsolescence tbqh. I don't know if this call is used by counterwallet, but it would probably be better if any new wallets developed for the project try to rely as little as possible on counterblock in the future.

Counterblock is slowly slipping into obsolescence tbqh. I don't know if this call is used by counterwallet, but it would probably be better if any new wallets developed for the project try to rely as little as possible on counterblock in the future.

As far as the result of my roughly grepped in Counterwallet, there is no code calling get_insight_block_info().
So we can dropped it, IMO.
Is there no issue on your services even if I remove the API ? @jdogresorg

As far as the result of my roughly grepped in Counterwallet, there is no code calling get_insight_block_info().
So we can dropped it, IMO.
Is there no issue on your services even if I remove the API ? @jdogresorg

I do not use get_insight_block_info() anywhere on xchain.io or in freewallet.io

I do not use get_insight_block_info() anywhere on xchain.io or in freewallet.io

@jdogresorg I see. I'll create PR to remove get_insight_block_info() soon.
@chiguireitor I agree that Clounterblock (and Counterwallet) should be going to be obsolete.
And at least just now, it's required to follow up with current code by current users, IMO.

@jdogresorg I see. I'll create PR to remove get_insight_block_info() soon.
@chiguireitor I agree that Clounterblock (and Counterwallet) should be going to be obsolete.
And at least just now, it's required to follow up with current code by current users, IMO.


scipy.optimize.curve_fit's undocumented return_full keyword doesn't work with bounded problems

scipy's curve_fit has a useful, but undocumented, keyword return_full. When this keyword is set to True the function will return extra information that is useful for debugging and adding functionality to one's own code. However, the keyword doesn't work with bounded problems. This is because bounded problems are solved by least_squares and unbounded problems are solved by leastsq and least_squares returns an OptimizeResult which is different from what is returned by leastsq.

Thanks for the report. I guess it's possible to return the whole OptimizeResult if full_output is True and bounds are not None.

or the output of leastsq could be packed into an OptimizeResult so that the return is the same in all cases.

or the output of leastsq could be packed into an OptimizeResult so that the return is the same in all cases.

If we were starting from scratch, then yes. Otherwise no, for it breaks backwards compatibility for a not-good-enough reason.

It can be re-packed into OptimizeResult in curve_fit, however.

Yes I meant what @pv suggested. If that's still unacceptable than one could do it the other way around: repackage the OptimizeResult returned by least_squares into the same format as leastsq:
infodict = dict(nfev=res.nfev, fvec=res.fun, fjac=res.jac, ipvt=None, qtf=None)
ier = res.status
errmsg = res.message

Where res is the OptimizeResult returned by least_squares and the None's would be replaced by appropriate values.


shortened trigger phrases

PLEASE merge together with https://github.com/kiegroup/droolsjbpm-build-bootstrap/pull/1430


Proposal: react-router-mobx

During an attempted upgrade to react-router v4 in a MobX codebase, I encountered the blocked updates issue. Obviously this is a bit of a deal breaker, since it would mean wide-sweeping changes to make all of the observers aware of location changes.
I have seen it hinted at in a couple of places that react-router-redux has a way around this in v5. I think it would be beneficial if this same fix/methodology could be brought to those of us using MobX.
I can see about getting a PR ready once react-router-redux v5 gets closer to release, but I just wanted to get this idea out there.
I think having first-class MobX support like we have for Redux would go a long way in bringing the community together around the coolest router :sunglasses:

There is also some good discussion over in the Redux Integration (#4668) PR which may be relevant.

As far as I can tell, the primary goal of react-router-redux is not to work around the blocked updates issue, but to integrate react-router with redux by syncing the router location with the redux store. I don't know mobx enough to say if that's possible/practical there, too. But if you're just concerned about working around the blocked updates, you don't really need an extra library for this; you can simply compose the HoCs/decorators yourself:
// observerWithRouteProps.js
import {observer} from 'mobx-react';
import {withRouter} from 'react-router';

export default Component => withRouter(observer(Component));

And then just use that function instead of observer from react-mobx. This should work with all HoCs/decorators that respect the prop updates of the component.

react-router-redux does nothing with connected components or blocked updates. It's simply for synchronization of location into state.
If you mean the changes on react-redux, that is a separate thing were doing here: https://github.com/reactjs/react-redux/pull/625
Anything that gets around blocked updates is either something to be solved by the library that's blocking, or is something we would solve in a much more generic implementation than just for MobX's use.

@timdorr Thanks for the info!


SERVER_ARGS not passing.

valheim-server line:112 need to update $SERVER_ARGS to "$SERVER_ARGS".
This fixed it for me! I couldn't get Crossplay to work because it wasn't passing the arguement.

That makes sense but for what ever reason the server_args aren't being
passed through until I put them in quotes.. So maybe something else is
broke?
On Mon, Sep 25, 2023 at 7:08 AM Lukas Lösche @.***>
wrote:

The problem with "$SERVER_ARGS" is that you can then only pass a single
arg. Since everything inside the quotes is handled as one argument. The
quotes are deliberately left out here so that you can pass more than one
arg to the server. Ideally we'd use an array, but since these variables are
coming from the environment that's not an option.
—
Reply to this email directly, view it on GitHub
https://github.com/lloesche/valheim-server-docker/issues/641#issuecomment-1733450141,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAWFQCKVA23A6PQYYI37VZDX4FQ33ANCNFSM6AAAAAA47CPNUI
.
You are receiving this because you authored the thread.Message ID:
@.***>

aye i have a question in the same vein, how do i pass multiple varriables is it server_args= "-preset blah1","-modifier blah1" or each has to have server_args=?

aye i have a question in the same vein, how do i pass multiple varriables is it server_args= "-preset blah1","-modifier blah1" or each has to have server_args=?

So figured this out, -e SERVER_ARGS="-modifier combat veryhard -modifier raids muchmore"   just incase anyone else was trying to figure this out

Sorry to revive this thread, but I seem to be having issues with multiple args in my .env file where only the crossplay & portals are being applied. Any help would be truly appreciated and thanks for the awesome write-up!
My file looks like
SERVER_NAME=Server
WORLD_NAME=World
SERVER_PASS=password
SERVER_PUBLIC=true
SERVER_ARGS=-crossplay -modifier Portals casual -modifier deathpenalty easy -modifier raids none -modifier Resources muchmore -modifier Combat easy
BEPINEX=true


[enhacement] Use Flexible ascii progress bar.

For a better understanding of the progress of the proxies checks, here is an example of code using an flexible ascii progress bar: node-progress.
Rem: Pool is not accessible via require('free-proxy-checker')
// https://github.com/antoinevastel/free_proxy_checker
const { ProxyChecker, downloadAllProxies, } = require('free-proxy-checker');
// https://github.com/visionmedia/node-progress
const ProgressBar = require('progress');

const { Pool } = require('./pool.js');

class ProgressProxyChecker extends ProxyChecker {
    async checkProxies() {
        this.lastCheck = Date.now();
        const pool = new Pool(this.options.concurrency);
        const pbar = new ProgressBar('Checking proxies [:bar] :percent :etas', {
            complete: '=',
            incomplete: ' ',
            width: 20,
            total: this.proxies.length
        });

        this.proxies.forEach((proxy) => {
            pool.addTask(async() => {
                try {
                    await proxy._testConnection(this.options.timeout);
                } catch (_) { }
                finally {
                    if (this.options.verbose) {
                        pbar.tick();
                    }
                }
            })
        })

        await pool.run();
    }
}

(async () => {
    // Clear console
    process.stdout.write('\033c');

    // Download all proxies from all proxy providers at once
    const allProxies = await downloadAllProxies();
    console.log(`There are ${allProxies.length} proxies to test`);

    // Check the availability of the proxies we downloaded
    const proxyChecker = new ProgressProxyChecker(allProxies, {
        concurrency: 50,
        timeout: 7500,
        verbose: true
    })

    await proxyChecker.checkProxies();
    const proxiesUp = proxyChecker.getProxiesUp();
    console.log(`There are ${proxiesUp.length} proxies UP:`);
})();

Result:

Hi, thanks for your idea. Since node-progress is a single file + seems really stable I think it's reasonable to add it as a dependency without going through package.json.
I keep the issue open. I will probably do a PR in the next days/weeks :)

I close the issue, I added the feature in this PR (#5) + publish new version on NPM. Once again thanks for idea + the code example


Modularise QBFT

Make the QBFT less dependent on other Besu modules so it can be reused as a library. The initial use case is to reuse QBFT as a library in a QBFT CL implementation.
** Acceptance Criteria **

Separate QBFT core including state machine that is agnostic of networking and types from the Besu-specific implementation
Allow for any block type to be used in QBFT
Allow networking to be changed
Remove block creation from QBFT and into Besu QBFT module

@jframe  , I spent some time working on QBFT issues and got a good understanding of algo , code and flow . Let me know if I can help with this in any way.

Thanks @pullurib. I have a general idea of how I want to separate it. If you are on the Besu discord we can discuss further there. I also have PR in progress and can share a draft of that soon.


Crash!

I load the game and halfway through loading it crashes and a message pops up, "Some errors are present in the map definition and have been logged to error.log". What can I do?

This converter is still in development. As you see, it's not to the point where it creates a working mod. You'll have to wait, I'm afraid.
Though if you're willing to volunteer to help with #14 or with updating province mappings, that would get us there faster.


Can't Catch notifications from some applications

Describe the bug
I'm experiencing an issue where notifications from various applications do not appear in the AGS widgets. For example, this one https://aur.archlinux.org/packages/pachca-bin
To Reproduce
Expected behavior
Notifications from apps should appear in Notifications widget as intended.
Screenshots
Desktop (please complete the following information):

Distribution: Arch Linux
Window Manager/Desktop Environment: Hyprland

Additional context
I am new to AGS, so can't even check whether daemon or script handles notifications from any app. Appreciate any help with debug. Thank you!

Was this closed because it's not a bug? @iamthen0ise

Was this closed because it's not a bug? @iamthen0ise

yes, not a HyprPanel bug at all. 3rd party app problem.


Could  you submit the 4xRSN-50 code?

Could  you submit the 4xRSN-50 code?

不用等了，作者盗号给他自己刷星星！他就是个骗子！🤥

RSN-50 is easy, just modify the numbers of the blocks in
https://github.com/caiyuanhao1998/RSN/blob/master/exps/4XRSN18.coco/network.py#L324
from [2, 2, 2, 2] to [3, 4, 6, 3] and then modify the stage number to 4


chore(pull-request-template): lets add some template to lead us onto how to organize the pull requests

Description
Adds possible pull request template for better management of the PR's
Type of change

[x] Non Breaking change

Checklist:

[x] Added pull_request_template.md inside .github folder

Notes (specific implementation details)
It is nice to have a PR template where we can organize better what we write

@cosullivan
Hello again mate if you could look at this PR it will be awesome!
Cheers!


Fix failing hex file parser spec

It seems like we can no longer pass an exception as a plug /
dependency, hex will raise an ArumentError, which kind of makes sense.

Hmm, this test seems flaky, we get either a RuntimeError or an ArgumentError back from hex and it's not clear to me why this happens.
These tests flakes make it hard to get changes through so I opted to remove the assertion on the error message


fix GATLING_HOME detection when $0 is symlink

When gatling is launched via a symlink, e.g. /usr/local/bin/gatling -> /opt/gatling/bin/gatling.sh
It fails with the following error:

GATLING_HOME is set to /usr/local
Error: Could not find or load main class io.gatling.app.Gatling

BTW, for better cross platform compatibility, readlink options  -e or -f are not used, as that's GNU specific, not available in /usr/bin/readlink on Mac. the effect is the resolved GATLING_HOME could be still a symlink, but feature wise it works fine.

@ryenus Thanks!
@notdryft Please review

This modification would make the script fail for the most common case, which is running ./bin/gatling.sh from the root directory of a fresh downloaded bundle:
$ pwd
/Users/notdryft/Playground
$ tree
.
└── bin
    └── test.sh

1 directory, 1 file
$ cat bin/test.sh
#!/bin/sh

#OLDDIR=`pwd`
#BIN_DIR=`dirname $0`
#cd "${BIN_DIR}/.." && DEFAULT_GATLING_HOME=`pwd` && cd "${OLDDIR}"
DEFAULT_GATLING_HOME=$(cd "$(dirname "$(readlink -n "$0")")/.."; pwd)

GATLING_HOME="${GATLING_HOME:=${DEFAULT_GATLING_HOME}}"

echo "GATLING_HOME is set to ${GATLING_HOME}"
$ ./bin/test.sh
$ ln -s /Users/notdryft/Playground/bin/test.sh /usr/local/bin/test.sh
$ test.sh
GATLING_HOME is set to /Users/notdryft/Playground

So, maybe detect the nature of the link and use readlink or the former method depending of the result?

@notdryft is right, sadly readlink -n ./bin/test.sh never print anything, be it /usr/bin/readlink on Mac, or GNU readlink from coreutils.
Maybe the solution is to resort to perl first, then fallback to gnu readlink?

@notdryft please review again

I'm sorry, but I'd rather not take the risk of breaking something that works for the sake of supporting a rare and non standard usage.


Wrongly mark a provider usage as deprecated when used via the dependency engine

Expected Behavior

Gradle should not nag a deprecation warning for a provider that is "query" via the dependency engine. In fact, in the sample shown, Gradle should only be visiting the provider to identify the implicit task dependencies and not access the value.
Current Behavior

Gradle somehow triggers a provider to be realized when building the task graph.
Context

This issue affects the usability of the Provider API in the dependency engine. ~We can work around the issue by using forUseAtConfigurationTime() but this workaround is completely wrong. We aren't using the provider at configuration time, it's Gradle that is either over-using the provider or wrongly attributing its own usage of the provider for building the task graph as deprecated.~ (The workaround does not work). Gradle actually thinks the provider is being used before the task is executed but the provider is used during the task graph calculation.
Steps to Reproduce

Use the following code with two projects:
project(':consumer') {
    configurations {
        foo {
            canBeResolved = true
            canBeConsumed = false

            attributes {
                attribute(Usage.USAGE_ATTRIBUTE, objects.named(Usage, 'foo'))
            }
        }
    }

    dependencies {
        foo project(':producer')
    }

    tasks.register('foo') {
        inputs.files(configurations.foo)
    }
}

project(':producer') {
    def generateSources = tasks.create('generateSources') {
        def outputDirectory = layout.buildDirectory.dir('generated-srcs').get().asFile
       outputs.dir(outputDirectory)
       doLast {
            new File(outputDirectory, 'foo') << 'bar'
       }
    }

    def sources = files(generateSources)

    configurations {
        elements {
            canBeResolved = false
            canBeConsumed = true

            attributes {
                attribute(Usage.USAGE_ATTRIBUTE, objects.named(Usage, 'foo'))
            }

            def directoryProvider = sources.elements.map { it.first().asFile }
            outgoing.artifact(directoryProvider)
        }
    }
}

Your Environment

Build scan URL: https://scans.gradle.com/s/pn3ketnudqusg/deprecations#0

The only workaround found may actually expose another bug or shortcoming of the Provider API and what the deprecation warning is trying to prevent. We can "erase" the task dependency from the provider by flat mapping the sources.elements in the producer's outgoing artifact and attach the original provider via builtBy:
            def directoryProvider = sources.elements.flatMap { list -> providers.provider {list.first().asFile} }
            outgoing.artifact(directoryProvider) {
                builtBy sources
            }

Although this works, it actually jumps over the restriction that Gradle tries to impose that is not querying the output value of a task before it runs. I'm unsure if this would be the right intention.

But if the provider gets mapped before hand then the work around does not work:
            def mappedProvider = sources.elements.map { it.first() }.map { it.asFile }
            def directoryProvider = mappedProvider.flatMap { file -> providers.provider {file} }
            outgoing.artifact(directoryProvider) {
                builtBy mappedProvider
            }

Is there any chance this will be addressed before 7.0?

Any chance this will ever be addressed? What would be the alternative if this is not an issue to be addressed?

Hey Daniel,
I'm not sure but https://github.com/gradle/gradle/pull/15996 might have helped with this issue.
Could you please give 7.0-milestone-1 a try?

Maybe, I will need a bit of time to try it out I'm in the middle of some refactoring work.

Are you looking for something like #20155 here? Or is this something different?

No, this was in part a demonstration that FileCollection#getElements() doesn't behave the same as FileCollection. In terms of outgoing Configuration we can't use a FileCollection hence we need individual files/directories to export. What we do at Nokee is use the elements provider to map the files into a lazy list of PublishArtifact which we add to the artifact domain object set (via addAllLater). The provided sample abstracts all this into a minimum reproducer. At the core, the provider passed to the artifact method has the dependency information and Gradle will rightly execute the dependency before, however, internally, the dependency engine will resolve the provider "early" causing the warning (and now crash on 7.x) which is wrong as everything will be done correctly in the end.

Confirmed this is still the case with Gradle 8.2.1 but now it is a failure instead of a deprecation warning.
Complete reproducer available at https://github.com/eskatos/issue-reproducers/tree/main/gradle/issue-15146
https://scans.gradle.com/s/ycntgk44o5que/failure#1

Thank you for your interest in Gradle!
This issue needs a decision from the team responsible for that area. They have been informed. Response time may vary.

@gradle/bt-jvm, sorry, this was stuck between the boards. Could you please take it from here and triage the issue?

This is related https://github.com/gradle/gradle/issues/27578.  This describes some workarounds.
We need to decide how we would like this to work so that published artifacts carry the proper dependencies.
We don't plan to work on this soon.


ledcWriteTone (channel, freq);  steals the freedom of memory. (IDFGH-2079)

When calling ledcWriteTone (channel, freq)  Memory leaks.
28 bytes per call.

@ALEX170457 Thanks for reporting the issue. Would you please help provide more details as suggested in the issue template? Information like elf, sdk configuration, backtrace, log outputs, commit ID, hardware and etc. would help us debug further. Thanks.

@ALEX170457 Thanks for reporting. Will close the ticket due to short of details. Feel free to reopen with more details provided. Thanks.


WCF Service Reference not working with TaskScheduler

WCF Service Reference not working with Task Scheduler, namespace issue, not defined.
Example causes CS0246 because an object of type Type was used where an actual type was expected.

Please provide a lot more information. As written, your issue is not actionable.

Please provide a lot more information. As written, your issue is not actionable.

After Update VS2019, i have problem to define namespace of my ServiceModel, Generates Thousands of Errors in Reference.cs, after deleted "TaskScheduler" it work fine.

This library has nothing to do with WCF and has no dependencies on external libraries. I am unable to translate the errors you posted in the picture. Even with 18 years of experience supporting this library, I have no idea what could be causing your problem and actually doubt it is this library. I would check what has changed with Visual Studio with the update.

This library has nothing to do with WCF and has no dependencies on external libraries. I am unable to translate the errors you posted in the picture. Even with 18 years of experience supporting this library, I have no idea what could be causing your problem and actually doubt it is this library. I would check what has changed with Visual Studio with the update.

https://docs.microsoft.com/en-us/dotnet/csharp/language-reference/compiler-messages/cs0246
WPF Application actually. Do you have any suggestions else?

That error appears to come when you have not referenced an assembly correctly. I would try adding the NuGet package back into your project and then ensure that it is referenced per the instructions in the link you just sent.

That error appears to come when you have not referenced an assembly correctly. I would try adding the NuGet package back into your project and then ensure that it is referenced per the instructions in the link you just sent.

It didn't work for me
In the list of the all namespaces there is also no link on ServiceModel.
I forgot to say that with the new update, the visual studio was installed and the net5, perhaps this is somehow related.

I'm not sure what "ServiceModel" is and this library doesn't interact with anything by that name. This library supports all versions of .NET (Framework, Core, Standard) including .NET 5.0.

Ok, thanks, I will look for another solution.


⚠ Bofrost.be has degraded performance

In 85b1c0b, Bofrost.be (https://www.bofrost.be) experienced degraded performance:

HTTP code: 200
Response time: 1104 ms

Resolved: Bofrost.be performance has improved in a97c0c2 after 1 hour, 2 minutes.


Add identity-outbound-auth-metamask authenticator to as a connector

Is your suggestion related to an experience ? Please describe.
It is suggested to use identity-outbound-auth-metamask authenticator as a connector.
Describe the improvement
Add resourcesof identity-outbound-auth-metamask authenticator to connector store and describe set up process in documentation

This issue is being closed due to extended inactivity. Please feel free to reopen it if further attention is needed. Thank you for helping us keep the issue list relevant and focused!


quoting table name with explicit db name

So I have database: some_db in my database.yml but the class that I want to use with TS is
class SomeClass < ActiveRecord::Base
  self.table_name = 'some_other_db.some_class'
end

this results in `some_other_db.some_class`.`id` AS `sphinx_internal_id` which should really be `some_other_db`.`some_class`.`id` AS `sphinx_internal_id`. Same with all my indices and attributes
The culprit is here:
# lib/thinking_sphinx/active_record/column_sql_presenter.rb
class ThinkingSphinx::ActiveRecord::ColumnSQLPresenter
  def with_table
    return __name if string?
    return nil unless exists?

    quoted_table = escape_table? ? adapter.quote(table) : table
    # *table* here returns 'some_other_db.some_class' which
    # obviously gets quoted as '`some_other_db.some_class`'
    "#{quoted_table}.#{adapter.quote __name}"
  end

  # skipped for brevity

end

This happens because in Joiner::Joins#alias_for there is return model.table_name
So this should be either

something like table.split('.').map { |t| adapter.quote(t) }.join('.') in ColumnSQLPresenter#with_table
or maybe return model.quoted_table_name in Joiner::Joins#alias_for (though this is of course dangerous, I don't know where it is used)

Right now I've monkeypatched my way out of this
# config/initializers/thinking_sphinx.rb
ThinkingSphinx::ActiveRecord::ColumnSQLPresenter.class_eval do
  def with_table
    return __name if string?
    return nil unless exists?

    quoted_table = escape_table? ? properly_quoted_table : table

    "#{quoted_table}.#{adapter.quote __name}"
  end

  private

  def properly_quoted_table
	table.split('.').map { |t| adapter.quote(t) }.join('.')
  end
end

didn't close automatically for some reason


integration specs for views and fix n+1 problems and performance improvments

Following changes have been made during this PR:

Performances improved N + 1
Tests created for Interface
Readme Updated

Performances Before:

Performances After:

STATUS: INVALID CODE REVIEW REQUEST 🛑 🛑
Hi @Atifzada and @UbdaNam,
While you made a great effort in this project, unfortunately, I cannot proceed to review your code.
Invalid Code Review Request
- The live demo link on your Table of Contents is broken. Kindly remove it if you have no section for it.
- The deployment section of your README is empty. Kindly remove it if you have no content for it.
Your Code Review Request will be marked as invalid in your Dashboard, so please submit a new one once you are ready 🙏
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear. And please, remember to tag me in your question so I can receive the notification.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.
Invalid Code Review Request does not count into the code reviews limit.


[19.03 backport] Update containerd to v1.2.9

backport of

https://github.com/moby/moby/pull/39364 Update containerd to v1.2.7
https://github.com/moby/moby/pull/39786 Update containerd to v1.2.8
https://github.com/moby/moby/pull/39874 Update containerd to v1.2.9

Update containerd to v1.2.9. https://github.com/containerd/containerd/releases/tag/v1.2.9

The ninth patch release for containerd 1.2 provides a handful of bug fixes and an
update to the gRPC vendored codebase to include 3 CVE fixes provided in the upstream
v1.23.0 release of gRPC. Note that updating gRPC to the current release required small
changes to our core containerd codebase to match the upstream changes since gRPC v1.12.0.
These changes have been backported from containerd's master branch, as well as a
similar small change in ttrpc, requiring that package's vendoring to be updated.

In addition to the gRPC update to include CVE fixes, fixes were made to correct a
container's default Unix environment (introduced in 1.2.8), a small list of CRI plugin
fixes, as well as fixes for registry interactions where Docker-Content-Digest is not
returned (e.g. GitHub Package Registry), and a tar archive modification time bug found
by the buildkit maintainers. A fix to the zfs snapshotter was also included via a
re-vendoring of containerd's zfs import. More notes on these fixes are found below.

Update containerd to v1.2.8
https://github.com/containerd/containerd/releases/tag/v1.2.8
full diff: https://github.com/containerd/containerd/compare/85f6aa58b8a3170aec9824568f7a31832878b603...a4bc1d432a2c33aa2eed37f338dceabb93641310
The eighth patch release for containerd 1.2 provides a series of bug fixes, many
of them backported from the master branch to correct several known issues around
manifest lists/indexes and pulling multi-arch, CVEs related to Golang/http2,
fd leakage in the Golang runtime, a shim hang, process and image environment config
handling, and finally mount cleanup related to Cloud Foundry's use of containerd
with rootless containers.
From the release notes: https://github.com/containerd/containerd/releases/tag/v1.2.7

Welcome to the v1.2.7 release of containerd!
The seventh patch release for containerd 1.2 introduces OCI image
descriptor annotation support and contains fixes for containerd shim logs,
container stop/deletion, cri plugin and selinux.
It also contains several important bug fixes for goroutine and file
descriptor leakage in containerd and containerd shims.
Notable Updates

Support annotations in the OCI image descriptor, and filtering image by annotations. containerd/containerd#3254
Support context timeout in ttrpc which can help avoid containerd hangs when a shim is unresponsive. containerd/ttrpc#31
Fix a bug that containerd shim leaks goroutine and file descriptor after containerd restarts. containerd/ttrpc#37
Fix a bug that a container can't be deleted if first deletion attempt is canceled or timeout. containerd/containerd#3264
Fix a bug that containerd leaks file descriptor when using v2 containerd shims, e.g. containerd-shim-runc-v1. containerd/containerd#3273
Fix a bug that a container with lingering processes can't terminate when it shares pid namespace with another container. moby/moby#38978
Fix a bug that containerd can't read shim logs after restart. containerd/containerd#3282
Fix a bug that shim_debug option is not honored for existing containerd shims after containerd restarts. containerd/containerd#3283
cri: Fix a bug that a container can't be stopped when the exit event is not successfully published by the containerd shim. containerd/containerd#3125, containerd/containerd#3177
cri: Fix a bug that exec process is not cleaned up if grpc context is canceled or timeout. contaienrd/cri#1159
Fix a selinux keyring labeling issue by updating runc to v1.0.0-rc.8 and selinux library to v1.2.2. opencontainers/selinux#50
Update ttrpc to f82148331ad2181edea8f3f649a1f7add6c3f9c2. containerd/containerd#3316
Update cri to 49ca74043390bc2eeea7a45a46005fbec58a3f88. containerd/containerd#3330

marked as WIP because https://github.com/moby/moby/pull/39874 was not yet merged
first two commits are also in https://github.com/docker/engine/pull/282

PowerPC failure, looks like it was caused by Jenkins killing randomly

Everything else was green; I'll kick CI one more time to see if we can get green, otherwise I think we should merge

Is this a new flaky?

[2019-09-09T22:46:49.775Z] --- FAIL: TestServiceRemoveKeepsIngressNetwork (31.95s)
[2019-09-09T22:46:49.775Z]     service_test.go:232: Creating a new daemon at: /go/src/github.com/docker/docker/bundles/test-integration/1/TestServiceRemoveKeepsIngressNetwork
[2019-09-09T22:46:49.775Z]     daemon.go:321: [dd9ed34db0a08] waiting for daemon to start
[2019-09-09T22:46:49.775Z]     daemon.go:339: [dd9ed34db0a08] daemon started
[2019-09-09T22:46:49.775Z]     service_test.go:237: timeout hit after 30s: ingress not ready: 0 peers and 0 containers
[2019-09-09T22:46:49.775Z]     daemon.go:449: [dd9ed34db0a08] Stopping daemon
[2019-09-09T22:46:49.775Z]     daemon.go:288: [dd9ed34db0a08] exiting daemon
[2019-09-09T22:46:49.775Z]     daemon.go:436: [dd9ed34db0a08] Daemon stopped

No, it's not new; https://github.com/moby/moby/issues/39426. Moby currently skips that test; https://github.com/moby/moby/pull/39453 (and it was just backported to this repository, but not yet in this PR's branch: https://github.com/docker/engine/pull/350)

The other failure is TestSwarmLockUnlockCluster which is a known flaky test (https://github.com/moby/moby/issues/34051). (perhaps https://github.com/docker/engine/pull/345 might help a bit, not sure)


How to use the gaps Application?

I'm not familiar with the makefile. I'm having difficulty getting the application running.
Can you please explain in more detail the actions that are required to create the application and run it?

just install gcc and opengl, then 'make clean;make'

@Jian-danai After 'make clean;make' in the gaps directory, I cd into the scans/17DRP5sb8fy  and run
mpview -input_house house_segmentations/*.house -v but it return mpview: command not found.
Did I do sth wrong?


dialer: compare error with errors.Is

Issue:

Problem

Hello :wave:, first-time contributor here.
Error comparison using strings.Contains is not idiomatic Go code. Starting from Go 1.13, errors.Is is the preferable way to compare error equality ^1
Solution

This PR replaces the existing error comparison of dialer errors to use errors.Is instead of strings.Contains.
Testing

Engineering Testing
Manual Testing

Automated Testing

QA Testing Considerations

Regressions Considerations

Hey @Juneezee, I am glad to see you want to contribute! Some of this code was written before go1.13, which is why you will see this behavior in the codebase. Generally, we do not refactor code just to be more idiomatic because it opens the door for new bugs. We also started requiring automated tests (unit tests) for all PRs, to combat the addition of new and old bugs.
Aside from that, I see you are using sentinel errors as a replacement which comes with separate drawbacks. I personally like this article about error handling design in go. It is an older piece, but the information is still relevant and helpful.

Hey @Juneezee, I am glad to see you want to contribute! Some of this code was written before go1.13, which is why you will see this behavior in the codebase. Generally, we do not refactor code just to be more idiomatic because it opens the door for new bugs. We also started requiring automated tests (unit tests) for all PRs, to combat the addition of new and old bugs.
Aside from that, I see you are using sentinel errors as a replacement which comes with separate drawbacks. I personally like this article about error handling design in go. It is an older piece, but the information is still relevant and helpful.

Hi @KevinJoiner, thank you so much for your valuable feedback! I really appreciate it. I took the time to re-read the article you shared, and it reminded me of some important points.
One thing that caught my attention was the mention of "avoiding sentinel errors" and "never inspecting the output of error.Error." I'm wondering if the advice to avoid sentinel errors is still considered highly relevant since the introduction of error wrapping in Go 1.13 :thinking:. I'd love to hear your thoughts on this.
Regarding this pull request, my intention is to address the part about not "Never inspect the output of error.Error". We currently have some string comparison of error.Error() in the code, and I believe it would be beneficial to improve this aspect. What do you think about this?
I'm looking forward for more of your feedback on this


instantiation failed: unknown import, Code: 0x62

Here is my commnad:
wasmedge --dir .:. --nn-preload default:GGML:AUTO:qwen1_5-14b-chat-q5_k_m.gguf  llama-api-server.wasm -p chatml
[2024-03-21 22:59:10.566] [error] instantiation failed: unknown import, Code: 0x62
[2024-03-21 22:59:10.566] [error]     When linking module: "rustls_client" , function name: "new_codec"
[2024-03-21 22:59:10.566] [error]     At AST node: import description
[2024-03-21 22:59:10.566] [error]     At AST node: import section
[2024-03-21 22:59:10.566] [error]     At AST node: module

Thanks for the feedback @njalan ! I didn't try this module with wasmedge. Could you provider detail reproduce steps so that I can look into it? How do you generate llama-api-server.wasm?

@iaalm I downloaded it from below link:
curl -LO https://github.com/LlamaEdge/LlamaEdge/releases/latest/download/llama-api-server.wasm

Seems you opened to wrong repo. Should be https://github.com/LlamaEdge/LlamaEdge


Support Import Assertions

Clear and concise description of the problem
https://github.com/tc39/proposal-import-assertions
import json from "./foo.json" assert { type: "json" };
Vite 4 already supports it ootb! (link) Can we add it to Vitest too?
Suggested solution
Update to Vite 4
Alternative
No response
Additional context
No response
Validations

[X] Follow our Code of Conduct
[X] Read the Contributing Guidelines.
[X] Read the docs.
[X] Check that there isn't already an issue that request the same feature to avoid creating a duplicate.

Just use Vite 4 with Vitest, Vitest doesn't process code by itself


#1601

This change is

PR is added to the queue for testing as 2. task. (c47eb1f)

Test 96532753 (c47eb1f) build started.

Test (Fail) 96532753 build is completed (c47eb1f)
See https://github.com/ThaliTester/TestResults/tree/96532753c47eb1f__1601_vasilevskayaem/ for the logs

PR is added to the queue for testing as 3. task. (9de641b)

Test 96532753 (9de641b) build started.

Test (Success) 96532753 build is completed (9de641b)
See https://github.com/ThaliTester/TestResults/tree/965327539de641b__1601_vasilevskayaem/ for the logs

Test 965327539de641b(9de641b) has failed
See https://github.com/ThaliTester/TestResults/tree/965327539de641b__1601_vasilevskayaem/ for the fail logs

PR is added to the queue for testing as 1. task. (71f1bf1)

Test 96532753 (71f1bf1) build started.

Test (Fail) 96532753 build is completed (71f1bf1)
See https://github.com/ThaliTester/TestResults/tree/9653275371f1bf1__1601_vasilevskayaem/ for the logs

PR is added to the queue for testing as 2. task. (de9d535)

Test 96532753 (de9d535) build started.

Test (Fail) 96532753 build is completed (de9d535)
See https://github.com/ThaliTester/TestResults/tree/96532753de9d535__1601_vasilevskayaem/ for the logs

PR is added to the queue for testing as 2. task. (164b9eb)

Test 96532753 (164b9eb) build started.

Test (Success) 96532753 build is completed (164b9eb)
See https://github.com/ThaliTester/TestResults/tree/96532753164b9eb__1601_vasilevskayaem/ for the logs

Test<PHONE_NUMBER>4b9eb(164b9eb) has failed
See https://github.com/ThaliTester/TestResults/tree/96532753164b9eb__1601_vasilevskayaem/ for the fail logs

Review status: 0 of 5 files reviewed at latest revision, all discussions resolved.

Comments from Reviewable

Review status: 0 of 5 files reviewed at latest revision, 1 unresolved discussion.

test/www/jxcore/lib/testUtils.js, line 62 at r5 (raw file):

  }
  return new Promise(function (resolve, reject) {
    Mobile['toggleWiFi'](value, function (error) {

is it correct way of calling native methods ?

Comments from Reviewable

@andrew-aladev please review

Reviewed 2 of 5 files at r1, 1 of 1 files at r3, 2 of 2 files at r4.
Review status: all files reviewed at latest revision, 2 unresolved discussions.

test/www/jxcore/lib/testUtils.js, line 62 at r5 (raw file):
Previously, larryonoff (larryonoff) wrote…
is it correct way of calling native methods ?

We want Mobile.toggleWiFi here.

thali/NextGeneration/thaliMobileNativeWrapper.js, line 732 at r5 (raw file):

  return gPromiseQueue.enqueue(function (resolve, reject) {
    Mobile['toggleWiFi'](value, function (error) {

Here too

Comments from Reviewable

PR is added to the queue for testing as 2. task. (da2ef75)

Review status: 3 of 5 files reviewed at latest revision, 2 unresolved discussions.

test/www/jxcore/lib/testUtils.js, line 62 at r5 (raw file):
Previously, andrew-aladev (Andrew Aladjev) wrote…
We want Mobile.toggleWiFi here.

Done.

thali/NextGeneration/thaliMobileNativeWrapper.js, line 732 at r5 (raw file):
Previously, andrew-aladev (Andrew Aladjev) wrote…
Here too

Done.

Comments from Reviewable

Reviewed 2 of 2 files at r6.
Review status: all files reviewed at latest revision, 2 unresolved discussions.

Comments from Reviewable

Test 96532753 (da2ef75) build started.

Test (Success) 96532753 build is completed (da2ef75)
See https://github.com/ThaliTester/TestResults/tree/96532753da2ef75__1601_vasilevskayaem/ for the logs

Test 96532753da2ef75(da2ef75) has failed
See https://github.com/ThaliTester/TestResults/tree/96532753da2ef75__1601_vasilevskayaem/ for the fail logs

PR is added to the queue for testing as 1. task. (4acc906)

Test 96532753 (4acc906) build started.

Test (Success) 96532753 build is completed (4acc906)
See https://github.com/ThaliTester/TestResults/tree/965327534acc906__1601_vasilevskayaem/ for the logs

Test 965327534acc906(4acc906) has failed
See https://github.com/ThaliTester/TestResults/tree/965327534acc906__1601_vasilevskayaem/ for the fail logs


Fix odd indentation in _popen/_wpopen

If you'd rather I not also fix the trailing whitespace errors, I can remove that commit. Let me know.

@chwarr,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot

The trailing whitespace is significant in our markdown schema. If there aren't two trailing space characters after or between paragraphs, they are merged into a single paragraph in the output HTML, which is rarely what you actually want. This may not be reflected in the preview on GitHub. I suggest dropping that commit.
Within triple-tick code blocks, the trailing spaces are not necessary, though they don't make a visual difference. I tend to remove them when I find them because they may be unexpected when copied into Visual Studio or another editor. Our automated conversion tools that built the markdown files often inserted them, as well as the unexpected space at the beginning of some blocks. I tend to fix those as I come across them. I did some regex searches across the entire document set to fix many, but clearly missed some. These changes are welcome.

Removed the whitespace commit. Thanks for the explanation.