ISPN-13127 Minimize allocations on common code paths

https://issues.redhat.com/browse/ISPN-13127

should we run perf @danberindei ?

should we run perf @danberindei ?

Yeah, let's make sure I didn't break something :)
Just don't expect big improvements: I just "fixed" stuff I noticed in the profiler while working on ISPN-12941 and ISPN-13124, which do improve things a lot, but only in specific scenarios (max-idle + passivation enabled but all entries fit in memory).

run performance tests please

@pruivo I've addressed most of your nits (some I don't agree with, one I feel is too much work for this PR).
I've also "future-proofed" the PersistenceManagerImpl.deleteFromAllStores() code for https://github.com/infinispan/infinispan/pull/9471

I rebased again to merge the review fixes into the original commits.

@danberindei there are some tests failing with NullPointerException. It is not clear if it is related.

@pruivo the NPE was related. I added a commit to fix the exception handling in PersistenceManagerImpl.deleteFromAllStores

looks like there is another: https://ci.infinispan.org/job/Infinispan/job/PR-9408/9/testReport/org.infinispan.query.remote.impl/ProtobufMetadataManagerInterceptorTest/testStatusAfterRemove/


Runtime Role-based Access Control In ASP.NET MVC

ASP.NET MVC allows users the ability to assign permissions to functionality (i.e. Actions) at Design Time like so:
[Authorize(Roles = "Administrator,ContentEditor")]
public ActionResult Foo()
{
   return View();
}

How Can I set the role at the runtime? And I wanna check Role is my view something like this:
@if (User.IsInRole(Model.User.Role))
{

This will be visible only to users in the ContentEditor role.

}

Any Idea?

Could you not achieve this using partial views at design time, depending on their role.

As of the current design Roles are not settable at runtime.

@rustd So what's another solution for doing that? Any idea?


[BUG] Problem in 'Cart' page with mobile navbar

Description

Here as you can see there is a z-index problem with the cart page and it's mobile navbar.
Which is not looking good at all. Need to fix it.
Screenshots
No response
Any additional information?
@mdazfar2
Please assign me this ISSU, I want to work on it.
Thank you.
What browser are you seeing the problem on?
No response
Checklist

[X] I have checked the existing issues
[X] I have read the Contributing Guidelines
[X] I'm a GSSoC'24-Extd contributor
[X] I'm a Hacktoberfest'24 contributor
[X] I am willing to work on this issue (optional)

@Suvadip-sana go ahead

@Suvadip-sana Issue acknowledged! You are going to be assigned.
Hope you know that our website is fully converted to the Next.js and Tailwind CSS framework, so you have to work accordingly.

Read our [Contributing guidelines](https://github.com/mdazfar2/Ezyshop/blob/main/CONTRIBUTING.md] and make sure to contribute accordingly.

Thank you

This page is not found as usual. @mdazfar2

https://github.com/mdazfar2/Ezyshop/blob/main/CONTRIBUTING.md

@ShivanshPlays Thanks

@mdazfar2  Why this is closed?  Please let me know the reason?


Insert Table Alias (in Join Clause)

I'm using version 7.0.4 and there is an option on SQL Completion of 'Insert table aliases(in FROM clause). I like this very much but i didn't understand why there isn't an option of "Insert Table Alias (in Join Clause)" too. Some SGBD accepts multiple table in FROM clause that would put all alias but others don't and need to use the JOIN clause. Is it possible to add in Preferences -> DBeaver -> Editors -> SQL Completion an option to "Insert Table Alias (in Join Clause)"?
Thanks.

As far as I see alias is inserted in joins on the latest DBeaver version.


LITE-28440: Add filtering and ordering to marketplaces endpoints

There are failures  on tests, please take a look :-)

yes, the problem are the flaky tests related to the ids on tests data creation. I'm re-running them now =)


Mark failed transactions

Fixes https://github.com/oasisprotocol/oasis-wallet-web/issues/924

Before
After

I personally would go with header bg color or badge/Tag

Updated screenshot


Request for Compliance with Apache ECharts Trademark Policy

Hello Team,
First of all, I want to express my appreciation for your work on this project. The integration of ECharts into Grafana through your plugin has been incredibly useful and it’s evident that a lot of effort has gone into making it as effective as it is. However, I’ve noticed some issues concerning the Apache ECharts trademark that I believe need addressing to ensure compliance with the guidelines set out by The Apache Software Foundation.
1. Project Description Issue:
The current description of the project seems to be misusing the Apache ECharts brand. According to the Apache trademark policy available at https://www.apache.org/foundation/marks/#products, projects that are not officially part of Apache need to ensure they don’t use the brand name in a way that suggests they are the original Apache project.
Suggested Change:
To comply with this policy, a name like “VolkovLabs's Plugin for Grafana powered by Apache ECharts” or any variant that clearly indicates the nature of the project while acknowledging Apache ECharts as the underlying technology would be more appropriate. This adjustment would help in avoiding confusion and ensuring respect for Apache’s brand guidelines.
2. Lack of Trademark Acknowledgment:
I’ve also observed that there’s no footer or documentation section that acknowledges Apache and ECharts as trademarks or registered trademarks of The Apache Software Foundation. As per the FAQs on trademark usage (https://www.apache.org/foundation/marks/faq/#attribution), it’s important to include such an acknowledgment to inform users of the trademark status of the terms.
Suggested Change:
Including a simple statement in the footer of the project’s main page and in the README file would suffice. For example:
“The Apache Software Foundation Apache ECharts, ECharts, Apache, the Apache feather, and the Apache ECharts project logo are either registered trademarks or trademarks of the Apache Software Foundation.”
These changes would not only ensure compliance with Apache’s trademark policy but also demonstrate good faith and respect for the intellectual property rights of others. It is crucial that both the website and the GitHub README and project description are updated to reflect these changes. I believe these adjustments will safeguard the project from potential legal complications and further align it with the open-source community's standards and expectations.
Thank you for considering these suggestions. I look forward to your response and am happy to discuss further if needed.

@Ovilia thank you for letting us know.
We gladly follow the guidelines to update the project description and add Trademark Acknowledgement.

@Ovilia We updated plugin description, README and Documentation (https://volkovlabs.io/plugins/volkovlabs-echarts-panel/).
Please let me know if there is anything else.


Support AWS Batch Array Jobs

Metaflow should have the ability to invoke AWS Batch jobs as array jobs. Currently the preferred method of handling parallelism is to break out into multiple tasks using the foreach parameter but this creates a parallel task in the AWS state machine and can cause the AWS State machine to hit the maximum 25k state transitions very quickly. Throw in multiprocessing to resolve the history issue, and the solution for large scale outs can quickly become unwieldy.
AWS Batch array jobs were specifically designed to handle problems like this and it is a core feature of AWS Batch.

Thanks for the issue @rchui! We looked into AWS Batch array jobs while implementing both the @batch decorator as well as the AWS Step Functions integration. The parallelism semantics of array jobs don't allow us to control concurrency (--max-workers). Also, it's a bit non-trivial to implement nested for-eaches with array jobs.
We have been in touch with the AWS Step Functions team to figure out a way to lift the 25k state transitions restrictions since it impacts all sorts of tall and(/or) wide workflows. But in any case, array jobs warrant a relook.

Thanks for the issue @rchui! We looked into AWS Batch array jobs while implementing both the @batch decorator as well as the AWS Step Functions integration. The parallelism semantics of array jobs don't allow us to control concurrency (--max-workers). Also, it's a bit non-trivial to implement nested for-eaches with array jobs.
We have been in touch with the AWS Step Functions team to figure out a way to lift the 25k state transitions restrictions since it impacts all sorts of tall and(/or) wide workflows. But in any case, array jobs warrant a relook.

Given https://gitter.im/metaflow_org/community?at=6030537c9337c51bc69a1543 which means that only 40 jobs can be parallelised at a time is there any way to help prioritise/collaborate on this?

Yes, @rchui and team are currently hacking an AWS Batch array implementation. We would love to understand your use case to make sure it can be supported.

Our use case is that we have 1000s of models that we would like to train in parallel.  We have been using batch array jobs to handle this.  We would like to move to using metaflow, but realised that we will be very slow if only 40 jobs can run at once (using step functions).

Yes, @rchui and team are currently hacking an AWS Batch array implementation. We would love to understand your use case to make sure it can be supported.

Are ya'll looking for some assistance in getting this working?

We can definitely loop you in. Also, happy to brainstorm short-term fixes to unblock your use cases.

We're attempting to run 100k plus MCMC sampling processes so we're hitting a wall  with Step Functions.
Even 5,000 separate flow executions exceeds the 25k Step Function limit.
Let me know what's the best way to chat further! You can email me at<EMAIL_ADDRESS>

Sending an email.

Metaflow now supports distributed map in step functions, that reduces the need to support Batch array jobs to work around the 25k state event limit


Interface access down since upgrade

Checklist

Have you pulled and found the error with jc21/nginx-proxy-manager:latest docker image? yes
Are you sure you're not using someone else's docker image? yes
If having problems with Lets Encrypt, have you made absolutely sure your site is accessible from outside of your network? yes

Describe the bug

Since upgrade docker image since 2.1.2 to 2.2.3, interface have errors
What version of Nginx Proxy Manager is reported on the login page? 2.2.3

To Reproduce
Upgrade docker image from 2.1.2 to 2.2.3
Wipe cookies/cache
Log out and Sign in
Expected behavior
Interface have errors
Screenshots

Operating System

Dedicated Server with Debian 10

Additional context
Errors logs :
 QueryBuilder#allowEagermethod is deprecated. You should useallowGraphinstead.allowEagermethod will be removed in 3.0QueryBuilder#eagermethod is deprecated. You should use thewithGraphFetchedmethod instead.eagermethod will be removed in 3.0 QueryBuilder#omit is deprecated. This method will be removed in version 3.0

This is very strange. Can you completely flush your browser cache, or use a different browser to test?
Failing that, can you try using the github-develop docker image tag to see if that has the same problem for you?

This is very strange. Can you completely flush your browser cache, or use a different browser to test?
Failing that, can you try using the github-develop docker image tag to see if that has the same problem for you?

Ok with full cache clear of browser fix the problem.. -_-"
Yesterday i have test to update MariaDB, it was slightly better but some bugs remained when trying to go to "settings" for example.
Thanks for everything and sorry for the inconvenience !

This is very strange. Can you completely flush your browser cache, or use a different browser to test?
Failing that, can you try using the github-develop docker image tag to see if that has the same problem for you?

JC - I am still having issue with the following, even after flushing cache.  I can "login" and it works, but should i not be worried about the deprecated methods below:
s6-svscanctl: fatal: unable to control /var/run/s6/services: supervisor not listening
QueryBuilder#allowEager method is deprecated. You should use allowGraph instead. allowEager method will be removed in 3.0
QueryBuilder#eager method is deprecated. You should use the withGraphFetched method instead. eager method will be removed in 3.0
QueryBuilder#omit is deprecated. This method will be removed in version 3.0
Model#$omit is deprected and will be removed in 3.0.

JC,
I have a very small, all consuming, issue.  I am VERY NEW to most of
docker, linux.  I am unable to, after a month of trying...figure out how to
only use Tlsv1.2 and Tlsv1.3. Firefox will not open the proxy_host's.  I
have tried adding SSL_Protocols Tls1.2 Tlsv1.3 to the files, but this
doesn't help. I keep seeing all my service containers showing 1.0 and 1.1
so they will not work.  Honestly, I have looked everywhere.  Could you
direct me?  Also, I have no default_host config, is that normal?  Thanks in
advance for your consideration.
Best,
Troy Burke
@.***
On Thu, Dec 30, 2021 at 9:08 PM Doobe @.***> wrote:

This is very strange. Can you completely flush your browser cache, or use
a different browser to test?
Failing that, can you try using the github-develop docker image tag to
see if that has the same problem for you?
JC - I am still having issue with the following, even after flushing
cache. I can "login" and it works, but should i not be worried about the
deprecated methods below:
s6-svscanctl: fatal: unable to control /var/run/s6/services: supervisor
not listening
QueryBuilder#allowEager method is deprecated. You should use allowGraph
instead. allowEager method will be removed in 3.0
QueryBuilder#eager method is deprecated. You should use the
withGraphFetched method instead. eager method will be removed in 3.0
QueryBuilder#omit is deprecated. This method will be removed in version 3.0
Model#$omit is deprected and will be removed in 3.0.
—
Reply to this email directly, view it on GitHub
https://github.com/jc21/nginx-proxy-manager/issues/414#issuecomment-1003182006,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AQWMM67SMTUCWGSY4XJ5TL3UTTC5ZANCNFSM4NFHEYTQ
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>


pull request for e2e test at 12/15/2016 10:15:19

:white_check_mark: Validation status: passed
For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


[ingester] add OTel events

This PR is for: Server [ingester] add OTel events

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

@numachen ，需要处理一下 CLA

新的pr  https://github.com/deepflowio/deepflow/pull/5638


Remove requirement that GCAllocator must be shared

There is no internal state in GCAllocator, it just uses the state of the GC via global variable access.
Requiring one to use shared(GCAllocator) everywhere is annoying. Often times one wants to have an allocator inside an object or otherwise, and it sucks to have to mark it shared.
This change allows access via shared OR unshared GCAllocator.
I also saw an inefficiency in resolveInternalPointer. I can create a separate pull if this is controversial.
Flagging @andralex, this is somewhat of a design decision, even though the change is transparent.

I don't see anything in the docs saying query is faster than addrOf. Have you done any profiling on resolveInternalPointer ?

No I haven't. I just know how it's implemented. Addrof gets the block info and returns the pointer. Sizeof gets the block info and returns the size. Query returns the block info :)

Ping @schveiguy, still has the nitpick

@JackStouffer sorry, forgot about this. Updated.

LGTM

I think we should also get rid of the Allocator.instance idiom which breaks purity, but we should leave that discussion for another PR. LGTM

@ZombineDev This shouldn't break purity, instance is not needed for any of the calls. In fact, the allocator in general needs a bunch of attribute TLC (nothrow should be everywhere, pure, @safe/@trusted).

I tested, everything can be made pure nothrow except for collect.
I'm surprised GC.free is pure...

I'm surprised GC.free is pure...
Not going to change this PR, because it has a different focus. That could be done in another PR.

I already tried that see e.g. #4190 or #4269 - however there's still hope:
https://github.com/dlang/phobos/pull/3891

@schveiguy Yes none of the calls to the GC now come through the instance instance methods, however consider the case GCAllocator is the parent allocator of another allocator.
Correct me if I'm wrong, but then just because the new sub-allocator has a shared field, it becomes unusable in pure code, regardless if the its methods are implemented by calling the static pure functions of GCAllocator.
Also, make would not be inferred as pure, because one of its arguments is shared.
The correct idiom IMO is to change all functions that are templated on the allocator type (excluding those that work with IAllocator) from:
void useAllocator(A)(auto ref A allocaor)
{
    void[] mem = allocator.allocate(42);
}

useAllocator(GC.instance);
// useAllocator(GC); doesn't compile

to:
void useAllocator(alias allocator = GCAllocator)()
{
    // if the argument is a type with static methods, getAllocatorInstance
    // aliases itself to the type (allocator), if there are no static methods - it aliases to
    // Type.instance (allocator.instance). Else if allocator is an allocator instance it
    // just aliases to it.
    alias alloc = getAllocatorInstance!allocator;
    void[] mem = allocator.allocate(42);
}

useAllocator() // uses GCAllocator static methods
useAllocator!Mallocator() // uses  Mallocator.instance instance methods
useAllocator!(Mallocator.instance)() //works with instances too
useAllocator!theAllocator()

That way getAllocatorInstance abstracts the fact if you're calling static or instance methods. Also it makes it easier to provide a default parameter value. For example:
// if you change the ddeclaration from:
void useAllocator(alias allocator = GCAllocator)()
// to
void useAllocator(alias allocator = processAllocator)()
// you don't need to change the signature (template type parameter default to runtime parameter default) or the implementation of the function.

but then just because the new sub-allocator has a shared field, it becomes unusable in pure code

The shared field is static, so it's not a member of any instance, it's more like a global variable. Yes, the instance is marked shared, but can be cast implicitly to unshared since it has no shared data:
GCAllocator gcalloc = GCAllocator.instance;

This can be used to compose other allocators, no problem, without the shared tag.

@schveiguy about the pure GC.free. I have been thinking about it and it is actually pure, depending on how you look at it. Consider a local container variable inside a pure function. Since you're the only one knowing about it, inserting and removing elements from it is ok. Now consider that allocators are just some kind of containers. If only you know about it, adding and removing elements from them is ok (allocating and deallocating). If you're the only one with a reference to a piece of memorying (given good enough allocator implementation -  e.g. everything is thread-local) then the effect of freeing this memory should not be visible anywhere else in the program and so the illusion of purity should remain well.

it is actually pure

The trouble with making GC.free pure, is that the compiler isn't aware that you are accessing global data.
I imagine that this kind of scenario can happen:
void freeIt(S)(S *ptr)
{
   GCAllocator.deallocate(cast(void *) ptr);
}

Seems innocuous enough, right? But what if S is immutable(int)? Due to GCAllocator.deallocate being pure, the compiler infers that freeIt is also pure. Since ptr has no non-immutable indirections, this instantiation of freeIt can be assumed to be strong pure. And as such, a strong pure function that returns void doesn't need to be called!
In terms of GC allocations, this isn't the end of the world, since the GC would (should?) come along and collect it anyway. But the idea that this isn't actually called bugs me.

But, AFAIR in practice child allocators save the parent allocator in an instance field and can't take advantage of the fact that they can use the global variable directly instead of saving a reference to it.

But, AFAIR in practice child allocators save the parent allocator in an instance field and can't take advantage of the fact that they can use the global variable directly instead of saving a reference to it.

I'm not understanding your argument, sorry.

Heh, I could do this instead:
alias instance = typeof(this).init;

Yes I'm aware of this problem. I think we need some sort of @weakpure transitive attribute that allows calling such functions from pure code, but prevent the compiler from eliminating the calls.

The @weakpure solution doesn't work. If you can wrap it in pure, then you can cause the problem.

You forget that allocators don't need to be a global static (state-less) resource. I use them extensively as statefull local variables and then the metaphore with containers works nicely.

Heh, I could do this instead

This exactly what my getAllocatorInstance does. Just abstracts the fact if you're calling static or instance methods.

@ZombineDev I'm still not getting it. Why can't you use GCAllocator in some type?
struct S(Allocator)
{
   Allocator allocator;
   auto foo() pure { allocator.allocate(100); }
}

auto s = S!GCAllocator(GCAllocator.instance); // should be fine

I imagine it like this
int compute() pure
{
allocate() weak pure
// do some stuff
free() weak pure
}
So there's no problem if compute() call is elided, because the weakpure calls come in pair.

Also note that allocate and deallocate are @system.  High-level pure code just uses UniqueRef/SharedRef which provide @safe mem allocation interfacd.

So there's no problem if compute() call is elided

Sure, but GC.free is already weak pure (it accepts a mutable pointer), that isn't the issue.

because the weakpure calls come in pair.

How is that enforced?

It will be enforced by safe or trusted wrappers. User code shouldn't call those system functions on its own.

I'm still not getting it. Why can't you use GCAllocator in some type?

I didn't think this would work without casts:

GCAllocator gcalloc = GCAllocator.instance;

A singleton with no instance methods and state is useless.

using alias + getAllocatorInstance is better because you wouldn't need to have another field embedded in your object, your code would not care if there's an instance or if it's calling static methods and it workarounds the shared problems in case 1) doesn't always work.

I didn't think this would work without casts:

Should be fine, since no instance data is a reference.

A singleton with no instance methods and state is useless.

I can't really get rid of the instance, since existing code may expect lvalue access. This is experimental, so we could potentially alter this, but I'd rather not put too much into this PR.

using alias + getAllocatorInstance is better because you wouldn't need to have another field embedded in your object

I'm assuming you mean as a user of allocators? I don't see why you can't do this. Just substitute instance for getAllocatorInstance.

I'm still not getting it. Why can't you use GCAllocator in some type?

I didn't think this would work without casts:

GCAllocator gcalloc = GCAllocator.instance;

A singleton with no instance methods and state is useless.

using alias + getAllocatorInstance is better because you wouldn't need to have another field embedded in your object, your code would not care if there's an instance or if it's calling static methods and it workarounds the shared problems in case 1) doesn't always work.

This is by design. What is the situation in which you need to instantiate GCAllocator?

The impetus for this is because I want to handle in my code the ability to use any kind of allocator -- ones that are instantiated, and ones that are singletons. I have code like this:
struct Foo(Allocator)
{
   Allocator alloc;
}

I found that Foo!GCAllocator doesn't work, because alloc needs to be marked shared in order to be used (yes, I can do Foo!(shared(GCAllocator)), but it doesn't make sense, as I'm not going to share alloc).
But the requirement rings untrue, none of the functions actually require shared state, because all the state is external. I realize, I can put in specialized code to deal with the two forms, but I wanted something simple. This is what people are going to reach for if writing generic code.
I don't see how making GCAllocator functions static harms anything, it just allows more possibilities for usage without affecting existing code.
I just looked at other usages of singletons in your wrapper types and see that you use an alias if the allocator has no state. Is there a way we can make this easy to use for users (maybe a mixin)? Then I can drop this PR, and create the proper one. This can give people who are looking for the right solution the proper way to do so.

Also, using GCAllocator.instance is impure, even though it's really pure. How do you solve that problem?

I can think of 3 cases that a generic type needs to handle:

The allocator is a shared singleton
The allocator can be default constructed, and you just use it.
The allocator is passed into the type/function and should be used.

We need some good documentation on how to handle all 3 cases generically. Are there more than 3?

@andralex if it wasn't clear from the discussion above, I agree with Steven that GCAllocator's methods should be static and also not shared, as current design is much less useful compared  to core.memory, while I think we all agree that it should be the other way around. The bare minimum being that GCAllocator should be usable in pure code, which currently is not the case (otherwise what's advantage over just using new?).
Just a quick note about shared - shared instance methods only make sense when they are overloaded with non-shared methods in order to provide a different behavior (e.g. synchronization).
When there is A) no state, or B) when the state being modified is external to the object (and is internally synchronized), shared doesn't buy us anything and is just a usability pessimization.
That applies to Mallocator, as well as GCAllocator. MmapAllocator may need some synchronization, beyond what the OS gives us, to allow concurrent allocation, so that's one instance where shared makes sense.
The other issue that is not very clear, is how should generic code use allocators. There are several alternatives:

Use processAllocator and/or theAllocator. While this may be an OK default, very often it's more efficient to use a dedicated bump-the-pointer (may be even placed on the stack) allocator for short-lived allocations. That's why generic code should allow the user to override the default allocator whenever possible. Plus, using global variables is not possible in pure code, and also messing with global state may be dangerous.
Take an IAllocator parameter. While this is bit more flexible than 1) (plus users coming from languages like Java will feel right at home), this misses one the main advantage of the allocator design - i.e. design by introspection. Furthermore, classes and interfaces are still quite cumbersome to use in @nogc code, though allocatorObject can help.
Take an auto ref A allocator parameter. This has the benefit of allowing design by introspection, however has two other disadvantages compared to 1) and 2). The first is that aggregates (e.g. data structures or child allocators) can't save a reference for later use, because in D ref is not a type constructor like T& in C++, which translates to the fact that ref fields are not allowed, and instead the constructor will probably make a copy if the allocator is a value type. This is highly undesirable when the allocator is stateful and you actually want to share the state (e.g. so you can do deallocateAll when you're done, and not leak memory because the data structure is actually using a copy of the allocator).
The other disadvantage is that you can't easily provide default runtime or template type arguments, like processAllocator or GCAllocator. This not good because it is desirable to provide a safe default (such as GCAllocator) for high-level code, eg. scientific applications that use ndslice.makeSlice, but doesn't preclude customization down the road.
Use alias allocator template parameter. This pattern is not used anywhere in Phobos (yet), but I found it very useful in my projects and that's why I'm proposing it here. The advantages are:

allows design by introspection (i.e. doesn't do type erasure, like IAllocotor), so it's easy to specialize based on the allocator. For example, I have a SharedRef(T, alias allocator) type (similar to Phobos RefCounted and C++ shared_ptr) which if the allocator has a prefix or suffix member uses one of them for storing the ref count, otherwise, manges the RC heap allocation manually.
Allows saving a reference to the allocator, even if the allocator is a local variable living entirely on the stack. For example, the only field that my UniqueRef type has is a pointer to the payload. I would expect that if the compiler can see that an instance of UniqueRef doesn't outlive the stack frame where the stack allocator lives it would be able to figure out that closure context is not necessary and replace all references to the allocator with a stack pointer offset, making UniqueRef.sizeof == void*.sizeof and thereby making my UniqueRef a truly zero-const-abstraction, which in turn makes @safe @nogc pure possible and actually pleasant to write.

Makes default parameters easy and flexible:
auto makeArray(alias allocator = GCAllocator, Range)(Range elementsToCopy);
// or:
auto makeArray(alias allocator = theAllocator, Range)(Range elementsToCopy);

Ping @andralex

I don't think generic code should instantiate allocators such as GCAllocator. The reality is there is only one garbage collected allocator, it's shared by all threads, so modeling it as such seems like a sensible thing to do.

Furthermore, the shared attribute is useful in ensuring that code like freelists (thread-local or shared) on top of GCAllocator are sensible. No?

unusable in pure code, regardless if the its methods are implemented by calling the static pure functions of GCAllocator.
Also, make would not be inferred as pure, because one of its arguments is shared.
..
@andralex if it wasn't clear from the discussion above, I agree with Steven that GCAllocator's methods should be static and also not shared, as current design is much less useful

FWIW I couldn't make the unittests of make and makeArray pure, because of this limitation (shared -> impure), which is of course annoying for users of an API. After all they expect the same behavior of the GCAllocator makeArray!int(10) compared to the native one new int[10] and if @andralex's plans are true we want to unify these two anyways soon :)

I'll close for now. It's not a critical requirement for me as I had to write my own GC wrapper since this one doesn't allow me to avoid scanning for pointers in my buffer library. No sense in consuming auto-tester cycles.

The reality is there is only one garbage collected allocator, it's shared by all threads, so modeling it as such seems like a sensible thing to do.

The shared instance doesn't go away here (existing code should just work). It's just that the calls would now be pure, and reflect more accurately the actual model -- that there isn't an accessible "instance" of the GC.

I don't think generic code should instantiate allocators such as GCAllocator.

I hope this isn't a serious reason why GCAllocator methods are marked shared. There are much better ways to ensure you can't instantiate a local instance of something.

Furthermore, the shared attribute is useful in ensuring that code like freelists (thread-local or shared) on top of GCAllocator are sensible. No?

I don't get the point of this comment.
Note: we still need a guide on how generic code should deal with all the models of allocators (shared instance, local constructed instance, passed instance, etc.). Until that, it's hard to have a discussion on what the API should be.


tailscale feature has wrong help wording

Describe the bug
The english tailscale help page has the word "undefined" as 2nd word in it.
Steps to reproduce the behavior

Goto Control Panel -> Network Settings
Click on "?" under tailscale

Expected behavior
correct description
Screenshots

System information:

RaspberryMatic Version: latest available
Used Hardware: raspberry 3b
Used HomeMatic RF-Module:

Additional context
Is it really needed to add a tick-box that needs to be confirmed by ok'ing and closing the window before the Authorization button becomes active upon reopening it?
i initially thought of a bug when nothing happens after ticking the tailscale chebox..

https://github.com/jens-maus/RaspberryMatic/blob/2f1c7c2975be4fcd6a667e79603900db795abd9b/buildroot-external/patches/occu/0136-WebUI-Add-Tailscale-VPN/occu/WebUI/www/webui/js/lang/en/translate.lang.js#L645
shouldn't this be .en. instead of .de. ?


Streams merging

Requested feature
Nice to have:

possibility to open a few streams in same time
logviewer should merge streams into one
each stream should be marked in logviewer
should be possibility quickly filter output by a stream

It's also about multiple serial port streams and telnet streams

this issue isn't relevant to v2, because v2 supported appending streams "out of the box".
as for merge functionality, it's available for files


Optimization-based vs. Learning-based results

Hey,
Thank you for publishing the code and congratulations on getting the NiPS oral!
Could you please provide some comparison of the Optimization-based vs. Learning-based results or at least provide some insight into what works better under what circumstances.
(I looked through the paper and SM and couldn't find this, but if it exists and I've missed it, could you please point me in the right direction?)
Thanks,
Eliahu

Hi @eliahuhorwitz,
Thanks for your words and interest in our work! As for your question, I will answer it as follows.
For the optimization-based pipeline, there is no network at all so no learning process is involved. This application is used to show the ability to reconstruct a wild range of shapes (as shown in the paper, we show results on 3 different datasets ranging from synthetic to real-world scans). Nevertheless, since no data prior is utilized, the optimization-based pipeline cannot handle very noisy point clouds or those with a large number of outliers. This is true for all optimization-based baselines as well. Also the reconstruction won't be good enough if the number of input points is small. Therefore, we further leverage the differentiability of our Poisson solver in learning the network parameters, which is the learning-based pipeline. In this way, we can train a network to handle very noisy inputs with outliers and the input number of points can be small. However, the learning-based pipeline has difficulty on generalizing to shapes out of training distribution, so it is less flexible than the optimization-based pipeline.
Hope this helps.
Best,
Songyou


Add network name to labels for workload endpoints

Description

This is a new feature that adds the neutron network name to the Workload endpoint's labels which allows for multi-openstack deployment policy to be created more easily than having to reference all of the individual network UUIDs across many clusters. For instance you might have a development or production network across many deployments, and being able to reference that for policy would be helpful. I've tested this in one of our clusters and it added the network_name label to the etcd datastore to all new and old Workload Endpoints.
Related issues/PRs
Related to issue 9128
Todos

[ ] Tests
[ ] Documentation
[ ] Release note

Release Note

Add a label to Workload endpoints for the name of the network of the related port. Useful for cases where there are many different OpenStack deployments with the same network name. No impact requiring code changes.

Reminder for the reviewer
Make sure that this PR has the correct labels and milestone set.
Every PR needs one docs-* label.

docs-pr-required: This change requires a change to the documentation that has not been completed yet.
docs-completed: This change has all necessary documentation completed.
docs-not-required: This change has no user-facing impact and requires no docs.

Every PR needs one release-note-* label.

release-note-required: This PR has user-facing changes. Most PRs should have this label.
release-note-not-required: This PR has no user-facing changes.

Other optional labels:

cherry-pick-candidate: This PR should be cherry-picked to an earlier release. For bug fixes only.
needs-operator-pr: This PR is related to install and requires a corresponding change to the operator.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.  Note: In case you are already a member of bloomberg, there is no need to sign the CLA again because bloomberg has already signed the (Corporate) CLA, hence just make sure that your membership is public. If you are not a member of bloomberg then you need to accept our CLA. tscogin seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.

I can certainly take a look at it at some point, however it might take a bit for it to gain priority in our sprints.

We'll prioritize development of any needed tests in our upcoming sprint -- thanks for being patient and taking the time to review this PR!

As far as tests go, I was thinking of the following possibilities:

Network name label should change when Network name changes
Change in network name label should be corrected back to the Network name

Are there other things to keep in mind?

@trev97 That sounds good to me.

@nelljerram Looking into the UT here, will this require changes to this file as well? https://github.com/projectcalico/calico/blob/master/networking-calico/networking_calico/plugins/ml2/drivers/calico/mech_calico.py#L676?
Looking at the updating process, seems there is no method for calico to change, update, or delete the networks. Would it then make sense, as to not inflate this PR too much, to simply see that the label gets reverted when it contradicts the network names that neutron creates? Or would that still require more code changes.

@nelljerram Tests should be passing now if you would like to run the workflow.

/sem-approve

@trev97 I need to merge #9302 (or a better version of that) first ...

While we're waiting for that, would you like to have a go at:

An appropriate release note - to replace "TBD" in the PR description above.
Doc - I think we just need a simple addition to the page at https://docs.tigera.io/calico/latest/networking/openstack/labels, for which the source is at https://github.com/tigera/docs/blob/main/calico/networking/openstack/labels.mdx.

re: the docs repository: we need to work with our Github org owner to establish a fork of the Tigera docs repo such that the CLA is accounted for (I do not believe we can sign individually and there's a bit of a process here). That may take some time - we'll start turning the wheels on that effort. Thanks again for your review and continued patience!

@tj90241 @trev97 If you can now merge origin/master into this PR, I'll trigger the CI again.

Merged master branch.

/sem-approve

/sem-approve

/sem-approve

@trev97 I'm happy to merge this after the next CI pass.  Are you also happy with that?

Sounds good.

@trev97 @tj90241 As the docs process is a little tricky for you, shall I just do it and then ask you to review?  (I think it's literally just one or two lines needed.)

That would be much appriciated!

That would be much appreciated!

@trev97 @tj90241 Please could you review https://github.com/tigera/docs/pull/1702 ?

Thanks so much the contribution @trev97 !


Possible memory leak in WebSocketWrapper

I think I've found a memory leak in WebSocketWrapper. I believe it's related to messageQueue.
The memory size slowly rises above 1.5GB, whilst before it was always below ~300MB.

Possibly caused by this commit (just speculating here):
Commit: f1bbdbc707347191e799cc326b7e07701f09a1d9
Switch web socket to raw bytes

Does the previous commit have the problem?

I am not entirely sure when it became a problem, but I'm fairly certain it's a recently introduced issue. I don't remember anything like this a month ago.

Ok, the problem is with the WebSocketWrapper not disposing of webSocket object properly (State is still Open) on Dispose(), keeping connection open and accumulating the messages in the messageQueue, while dequeuing them in MessageWorkerThread, because disposed = true.

The problem is with webSocket.CloseAsync throwing the following exception:

System.Net.WebSockets.WebSocketException: 'The remote party closed the WebSocket connection without completing the close handshake.'

This is on ExchangeBinance by the way.

Found a fix, pull request: https://github.com/jjxtra/ExchangeSharp/pull/194


synapse: <IP_ADDRESS> -> <IP_ADDRESS>

Semi-automatic update generated by https://github.com/ryantm/nixpkgs-update tools.
This update was made based on information from https://repology.org/metapackage/synapse/versions.
These checks were done:

built on NixOS
ran ‘/nix/store/rz2wn4lpkdqhwyz0qk7g41j2ykqmsj1b-synapse-<IP_ADDRESS>/bin/synapse -h’ got 0 exit code
ran ‘/nix/store/rz2wn4lpkdqhwyz0qk7g41j2ykqmsj1b-synapse-<IP_ADDRESS>/bin/synapse --help’ got 0 exit code
found <IP_ADDRESS> with grep in /nix/store/rz2wn4lpkdqhwyz0qk7g41j2ykqmsj1b-synapse-<IP_ADDRESS>
directory tree listing: https://gist.github.com/77e6334e3c147a4af2d15a9878e112eb

cc @2chilled for review

No attempt on x86_64-darwin (full log)
The following builds were skipped because they don't evaluate on x86_64-darwin: synapse
Partial log (click to expand)

a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowBroken = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowBroken = true; }
to ~/.config/nixpkgs/config.nix.

Success on x86_64-linux (full log)
Attempted: synapse
Partial log (click to expand)
glibPreFixupPhase
hicolorPreFixupPhase
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/rz2wn4lpkdqhwyz0qk7g41j2ykqmsj1b-synapse-<IP_ADDRESS>
shrinking /nix/store/rz2wn4lpkdqhwyz0qk7g41j2ykqmsj1b-synapse-<IP_ADDRESS>/bin/synapse
gzipping man pages under /nix/store/rz2wn4lpkdqhwyz0qk7g41j2ykqmsj1b-synapse-<IP_ADDRESS>/share/man/
strip is /nix/store/fzcs0fn6bb04m82frhlb78nc03ny3w55-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/rz2wn4lpkdqhwyz0qk7g41j2ykqmsj1b-synapse-<IP_ADDRESS>/bin
patching script interpreter paths in /nix/store/rz2wn4lpkdqhwyz0qk7g41j2ykqmsj1b-synapse-<IP_ADDRESS>
checking for references to /build in /nix/store/rz2wn4lpkdqhwyz0qk7g41j2ykqmsj1b-synapse-<IP_ADDRESS>...

Success on aarch64-linux (full log)
Attempted: synapse
Partial log (click to expand)
hicolorPreFixupPhase
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/k2gdl7g3r05d0a53j97w3kkrqwgnzd8n-synapse-<IP_ADDRESS>
shrinking /nix/store/k2gdl7g3r05d0a53j97w3kkrqwgnzd8n-synapse-<IP_ADDRESS>/bin/synapse
gzipping man pages under /nix/store/k2gdl7g3r05d0a53j97w3kkrqwgnzd8n-synapse-<IP_ADDRESS>/share/man/
strip is /nix/store/3zq400fri5dv7d30lpxlqm2v9y1iis6j-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/k2gdl7g3r05d0a53j97w3kkrqwgnzd8n-synapse-<IP_ADDRESS>/bin
patching script interpreter paths in /nix/store/k2gdl7g3r05d0a53j97w3kkrqwgnzd8n-synapse-<IP_ADDRESS>
checking for references to /build in /nix/store/k2gdl7g3r05d0a53j97w3kkrqwgnzd8n-synapse-<IP_ADDRESS>...
/nix/store/k2gdl7g3r05d0a53j97w3kkrqwgnzd8n-synapse-<IP_ADDRESS>


Taylor/drop private fields

:tada: This PR is included in version 7.2.18 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Error doing job: Task exception was never retrieved (None)

This error originated from a custom integration.

Logger: homeassistant
Source: custom_components/xiaomi_miot/sensor.py:322
integration: Xiaomi Miot Auto (documentation, issues)
First occurred: November 27, 2024 at 23:40:48 (14151 occurrences)
Last logged: 21:37:37

Error doing job: Task exception was never retrieved (None)
Traceback (most recent call last):
  File "/usr/src/homeassistant/homeassistant/helpers/entity_platform.py", line 1046, in _async_update_entity_states
    await entity.async_update_ha_state(True)
  File "/usr/src/homeassistant/homeassistant/helpers/entity.py", line 962, in async_update_ha_state
    self._async_write_ha_state()
  File "/usr/src/homeassistant/homeassistant/helpers/entity.py", line 1132, in _async_write_ha_state
    self.__async_calculate_state()
  File "/usr/src/homeassistant/homeassistant/helpers/entity.py", line 1069, in __async_calculate_state
    state = self._stringify_state(available)
            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/src/homeassistant/homeassistant/helpers/entity.py", line 1013, in _stringify_state
    if (state := self.state) is None:
                 ^^^^^^^^^^
  File "/usr/src/homeassistant/homeassistant/components/sensor/__init__.py", line 544, in state
    value = self.native_value
            ^^^^^^^^^^^^^^^^^
  File "/config/custom_components/xiaomi_miot/sensor.py", line 322, in native_value
    if not prop.range_min() <= val <= prop.range_max():
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
TypeError: '<=' not supported between instances of 'int' and 'NoneType'

Fixed in v0.7.25


Fixes issue #10425

Fixes an error reported resulting from Hammersmith no longer supplying
data.
Related issue (if applicable): fixes #10425
Pull request in home-assistant.github.io with documentation (if applicable): home-assistant/home-assistant.github.io#3921

Looks good but you have to make the build pass before it can be merged. It seems to have failed due to a timeout; closing and reopening the PR should make it restart and hopefully pass.
Please consider using PR titles that will be useful in the change log, such as "Remove retired Hammersmith data source"


Make Strong mode sticky rather than enabled by default

I work with Dartpad quite a bit at the moment (prototyping UIs and saving them as gists for future reference) and the recent change to have Strong mode enabled by default doesn't really work for me, as it's showing new errors in almost all of my gists (errors which will actually never cause errors when running the code).
I can see how it's useful to have Strong mode for some type of coding, but I'm using it for quickly prototyping interactions (which I don't think it's that unusual?). This means that I don't want my code to be too bureaucratic, and I feel Strong mode is encouraging that a little.
For example, this works fine without strong mode:
import 'dart:html';

void main() {
  querySelectorAll('td').forEach((TableCellElement cell) {
    print('${cell.cellIndex}');
  });
}

But with strong mode I get the following error:
The argument type '(TableCellElement) → Null' can't be assigned to the parameter type '(Element) → void'.
What I would have to write instead is:
import 'dart:html';

void main() {
  querySelectorAll('td').forEach((Element element) {
    TableCellElement cell = element;
    print('${cell.cellIndex}');
  });
}

I know the difference is basically a single line, but it feels like I shouldn't need to basically declare the element twice in order to get working code completion and no errors.
I don't know if this was the case before, but I feel like a better compromise would be to have Strong mode sticky rather than enabled by default (either once enabled for a user it stays enabled, or once enabled for a gist it stays enabled for that gist).
Thanks for considering this!

Hi @marianamarasoiu
Strong-mode will be required in Dart2, so I'm not sure it is too valuable to make it easier to accidentally not use it. I'm closing this for now.


Feat/disconnect wallet

Resolves #151
Screencast

Excellent work on these two PRs, thanks so much.


[BUG] - Post-Auth lambdas not triggered if using SAML / Third Party Authenticators

Describe the bug
The Post-Auth lambda that is triggered by cognito is not triggered when we use a third-party auth (SAML)

Fix: Add lambda to post-confirmation trigger also

can this be closed??


insufficient fee when canceling

https://bitsharestalk.org/index.php?topic=13812.msg179684#msg179684

is this included into 0.6.0 already!? Sam problem with order canceling! My problem is i really have to  cancel those orders!

Change it to 0.5 temporarily and cancel the order!
Ths solves my issue!

@cassiopaia This fix will not come into effect until the hardfork.


Add Code of Conduct

Codecov Report

Merging #289 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #289   +/-   ##
=======================================
  Coverage   68.31%   68.31%
=======================================
  Files          25       25
  Lines         928      928
=======================================
  Hits          634      634
  Misses        294      294

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 46f960e...5ca4329. Read the comment docs.


feat: Regenerate the newest Compute client

The new client also excludes several legacy GCE sub-services (like HttpHealthCheck, in favor or HTTPHealthCheck (yes the names differ only in letters case)). This is consistent with PHP client and also fixes the build on windows (otherwise the classes with the same name but different case were overriding each other on the case-insensitive windows file system).

@kolea2 PTAL. We need to push this PR first, before any potential release PRs. This PR has an overwhelming amount of stuff in it, but probably the only files which are actually worth reviewing are the pom.xml files. The other changes are caused by the updates in either of the following: GCE AIP itself (most of the chanes), synthtool, gapic-generator, googleapis-discovery (configured to exclude HttpHealthCheck stuff).

@kolea2 PTAL. We need to push this PR first, before any potential release PRs. This PR has an overwhelming amount of stuff in it, but probably the only files which are actually worth reviewing are the pom.xml files. The other changes are caused by the updates in either of the following: GCE AIP itself (most of the chanes), synthtool, gapic-generator, googleapis-discovery (configured to exclude HttpHealthCheck stuff).


DataModule compatiblity with Python dataclass

What does this PR do?
Adds compatibility of Python dataclass with Datamodule. Since the private variables and the parameters for __init__ will be deprecated in the future release, adding few changes would enable proper compatibility with Python dataclass.
Fixes #8272
Does your PR introduce any breaking changes? If yes, please list them.
As of now, few test cases for dataclass would fail, until due deprecation.
Before submitting

[ ] Was this discussed/approved via a GitHub issue? (not for typos and docs)
[x] Did you read the contributor guideline, Pull Request section?
[x] Did you make sure your PR does only one thing, instead of bundling different changes together?
[ ] Did you make sure to update the documentation with your changes? (if necessary)
[x] Did you write any new necessary tests? (not for typos and docs)
[x] Did you verify new and existing tests pass locally with your changes?
[x] Did you list all the breaking changes introduced by this pull request?
[x] Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

[ ] Is this pull request ready for review? (if not, please submit in draft mode)
[ ] Check that all items from Before submitting are  #resolved
[ ] Make sure the title is self-explanatory and the description concisely explains the PR
[ ] Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?
Make sure you had fun coding 🙃

Hey @tchaton,
Can you please review the changes and let me know if they look good to you or any changes are required?


feat(wallet): add faucet and wallet management functionalities

Closes: #3

[x] Add new wallet page and create-wallet page with improved user experience.
[x] Introduce TestnetFaucet component for requesting testnet BSV coins.
[x] Enhance WalletDetails component to include private key and seed phrase.
[x] Refactor wallet actions for better error handling and add key management functionalities.
[x] Corrected wrong spellings.

Please review @mo-jaber


Don't use actions-anti-pattern for filter box rendering

continues https://github.com/microsoft/vscode/issues/162004#issuecomment-1261139593
There seems to be a anti-pattern that noop actions are registered to views for the sole reason of rendering a custom UI for a single place. This is bad because

actions are global and discoverable, e.g users can register keybinding to them or extensions can invoke them
action have certain semantics and new features, like hiding, don't make sense
this seems like a lot of complexity and overhead to just render something into the panel title

As tactical fix for #162004 I have marked some actions as fake action. This is debt and needs to be replaced with a proper solution. I suggest to either

fix the actions to do something, e.g make them work independent of the one special rendering
don't use an action but let your view override renderHeader and add custome UI, e.g a filter box

[ ] src/vs/workbench/contrib/comments/browser/commentsViewActions.ts @alexr00
[ ] src/vs/workbench/contrib/debug/browser/repl.ts @roblourens @connor4312
[ ] src/vs/workbench/contrib/markers/browser/markers.contribution.ts @sandy081
[ ] src/vs/workbench/contrib/output/browser/output.contribution.ts @sandy081
[ ] src/vs/workbench/contrib/testing/browser/testingExplorerFilter.ts @connor4312

I do not think renderHeader works because the panel view header and the panel toolbar are not the same.

@jrieken I think either of the options mentioned above are helpful/feasible. From beginning, panels do not have access to panel title bar to render the widgets. So we would need to introduce back getActions api for views from which we moved away in favour of menus. I also think some of these actions like output switching are commands with args that means they can support registering keybindings.
Is it possible to have a new concept in the menu registry to accommodate those actions which needs special rendering? Such actions can also support hiding but are not shown in the overflow menu?

Such actions can also support hiding but are not shown in the overflow menu?

I don't believe that is a good solution. You are not a valid action you require special rendering and cannot work else. Let's not forget that any action can always be invoked from anyone form anywhere.

I also think some of these actions like output switching are commands with args that means they can support registering keybindings.

It is great if argument-less invocation can be supported and I totally see how switching output is a perfect case for that - in the lack of an argument show quick pick with all options but for filtering I don't see a good way.

From beginning, panels do not have access to panel title bar to render the widgets. So we would need to introduce back getActions api for views

Why must this be an action? If renderHeader isn't a good fit can we add something fit for the purpose? Except for output switching (see above) this is always about filtering. Why isn't there a get filter-ui method that can be overridden?

@sandy081 SwitchTerminal is this when tabs are disabled:

I'll watch this issue to see if the fix you end up doing for this can be applied there too.

Adopted following actions
Select Action
Changed the output select action to a submenu with selection flag. Contributed the selection entries to this submenu. Implemented a new SubmenuEntrySelectActionViewItem that renders this select submenu as selection dropdown. This will enable user hiding this selection action and will get moved into the secondary actions as below

Following this example for reference:
https://github.com/microsoft/vscode/blob/150b7f9d0ba9d3cdd294a47b164bd22fb5017ed2/src/vs/workbench/contrib/output/browser/output.contribution.ts#L116-170
@roblourens @Tyriar Please follow above example to convert your select actions.
FilterViewPane
Moved filter into ViewPane and called it FilterViewPane that supports rendering the filter widget in the header/body. Views supporting filtering can extend this. Eg: Problems, Comments & Repl. Adopted it in these views. CC @alexr00 @roblourens

Thanks for adopting this for me! But it's still basically based on a "fake action" right? https://github.com/microsoft/vscode/pull/163132/files#diff-3e738fc4417c6ddcfa32cbda3356cb2b2b30943137d429757e3d7585764f22b9R60

That's right. It is based on old action and an implementation detail of the view and not leaking into menus.

Thanks for adopting this for me too!

But it's still basically based on a "fake action" right?

I'd say we have two "kind of actions". There is Action2 which should be seen as a model object, they are singletons, can be placed in menus, and triggered by keybindings. Then there is IAction which is view model object which is used for rendering only (well, mostly since its definition has been a bit fluent). A sample is Separator which is an IAction but shouldn't ever be a "model object action"


Feat Support image URLs in tool outputs for Langchain::Assistant

Description:
This PR updates the Langchain::Assistant class to properly handle image_url parameters in tool outputs. Previously, tools could not include image URLs because they were not correctly passed to the add_message method.
Key Changes:

Improved Parsing Logic:

Added a robust parse_tool_output method to handle tool outputs that are either strings or hashes.
If the output is a hash and includes an :image_url key, it is extracted and removed from the hash.
The :content key is prioritized for the message content; if absent, the entire hash (excluding :image_url) is used as the content.

Integration with submit_tool_output:

The parsed image_url is now correctly passed to add_message.

Motivation:
This change enables tools to return outputs with both textual content and image URLs, enhancing the assistant's ability to provide rich and interactive responses. It also ensures edge cases, such as hashes without required keys, are handled gracefully.
Backward Compatibility:

Outputs without image_url or non-hash outputs continue to function as before.
Fully compatible with existing tools and workflows.

@Eth3rnit3 Thank you for your PR. I'm wondering if we can do this simpler.
What if we modified this to:
content, image_url = tool_instance.send(method_name, **tool_arguments)

# Rename the method parameter from output: to content:
submit_tool_output(tool_call_id: tool_call_id, content: content, image_url: image_url)

Something else to think about is that we might want to support the base64 encoded image re-presentation in the future, something like:
        {
          "type": "image",
          "source": {
            "type": "base64",
            "media_type": "image/jpeg",
            "data": "/9j/4AAQSkZJRg...",
          }
        }

Yes you're right @andreibondarev it's better this way, it's more implicit and avoids parsing what is output from the tool.

Works with Anthropic
Works with Mistral

Here's the error message for OpenAPI, which doesn't support:image_url in a message with the role: "tool"
OpenAI HTTP Error (spotted in ruby-openai 7.3.1): {"error"=>{"message"=>"Invalid 'messages[3]'. Image URLs are only allowed for messages with role 'user', but this message with role 'tool' contains an image URL.", "type"=>"invalid_request_error", "param"=>"messages[3]", "code"=>"invalid_value"}}


Direct symbols for "Close Wallet" and "Close NCC"

I think it would be a lot better like this:

I can send the resources in any size (46x46px e.g.) or vector files. Just tell me what you need, if you want to implement it.

will try to do it

https://www.dropbox.com/s/lm5co2gniu04ip9/close-ncc_close-wallet_resources.zip?dl=0

fixed in af2b7b9d9d93dd76bbdb6e8376b0771934975653


xService updates to High Quality

Code Coverage: Check (84%)
Tests run on Nano: Check
Unit/Integration tests present: Check
Examples present: Check
PSSA clean: Check
'Ignore' State added: Check
-Style cleanup: Check
-Update README.md: Check

This change is

Hi @mbreakey3, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

It looks like you're a Microsoft contributor (Mariah Breakey). If you're full-time, we DON'T require a Contribution License Agreement. If you are a vendor, please DO sign the electronic Contribution License Agreement. It will take 2 minutes and there's no faxing! https://cla.microsoft.com.

TTYL, MSBOT;

Reviewed 2 of 10 files at r3.
Review status: 2 of 11 files reviewed at latest revision, 19 unresolved discussions.

README.md, line 93 at r3 (raw file):

### Requirements

* Target machine must be running a Windows client operating system, Windows Server 2012 or later, or Nano Server.

Add under resource description: This resource works on Nano Server.
Change Requirements to None

DSCResources/MSFT_xServiceResource/MSFT_xServiceResource.psm1, line 110 at r3 (raw file):

on the desktop.
on the desktop or not.

DSCResources/MSFT_xServiceResource/MSFT_xServiceResource.psm1, line 278 at r3 (raw file):

if ($PSBoundParameters.ContainsKey('Path'))

{
$writeWritePropertiesArguments['Path'] = $Path
}
...
if ($PSBoundParameters.ContainsKey('Dependencies'))

{
$writeWritePropertiesArguments['Dependencies'] = $Dependencies
}

This whole block should be replaced with a foreach loop. E.g.:
foreach ($parameter in @( ...names of parameters... ))
{
    if ($PSBoundParameters.ContainsKey($parameter))
    {
        $writeWritePropertiesArguments[$parameter] = $PSBoundParameters[$parameter]
    }
}

DSCResources/MSFT_xServiceResource/MSFT_xServiceResource.psm1, line 313 at r3 (raw file):

the existence of the service is the only thing that will be checked.

only the the existence of the service will be checked.

DSCResources/MSFT_xServiceResource/MSFT_xServiceResource.psm1, line 346 at r3 (raw file):

Indicates what the time to wait for the service to start should be in milliseconds.
Optional. Default is 3000.

Not used in Test-TargetResource.

DSCResources/MSFT_xServiceResource/MSFT_xServiceResource.psm1, line 350 at r3 (raw file):

Indicates what the time to wait for the service to stop should be in milliseconds.
Optional. Default is 3000.

Not used in Test-TargetResource.

DSCResources/MSFT_xServiceResource/MSFT_xServiceResource.psm1, line 420 at r3 (raw file):

'Not checking other values since Ensure is set to Absent'

This needs to be moved to the strings file.

DSCResources/MSFT_xServiceResource/MSFT_xServiceResource.psm1, line 426 at r3 (raw file):

'Service does not exist'

This needs to be moved to the strings file.

DSCResources/MSFT_xServiceResource/MSFT_xServiceResource.psm1, line 711 at r3 (raw file):

respects whatif

respects WhatIf.

DSCResources/MSFT_xServiceResource/MSFT_xServiceResource.psm1, line 889 at r3 (raw file):

respects whatif

respects  WhatIf.

DSCResources/MSFT_xServiceResource/MSFT_xServiceResource.psm1, line 1087 at r3 (raw file):

that

BuiltInAccount

DSCResources/MSFT_xServiceResource/MSFT_xServiceResource.psm1, line 1088 at r3 (raw file):

that

Credential

DSCResources/MSFT_xServiceResource/MSFT_xServiceResource.psm1, line 1090 at r3 (raw file):

        If Credential is provided, this will return the resolved username and password from that.
        If nothing is provided, this will return null for both username and password.

Add here that if both parameters are provided, the username of BuiltInAccount will be returned.

DSCResources/MSFT_xServiceResource/MSFT_xServiceResource.schema.mof, line 6 at r3 (raw file):

{
  [key,Description("Indicates the service name. Note that sometimes this is different from the display name. You can get a list of the services and their current state with the Get-Service cmdlet.")] String Name;
  [write,Description("Ensures that the service is present or absent. Defaults to Present."),ValueMap{"Present", "Absent"},Values{"Present", "Absent"}] String Ensure;

The first letter of key, write, read should be capitalized for consistency.

Tests/Integration/MSFT_xServiceResource.Integration.Tests.ps1, line 60 at r3 (raw file):

    . $configFile

    Describe "$($script:DscResourceName)_Add_Integration" {

The names of the Describe blocks should be updated to be more 'friendly' (the underscores should be removed) and better describe what tests this describe block should contain.
For example, this one can be renamed to "$($script:DscResourceName) - Creating a service"
The other Describe blocks should be updated in the same way.

Tests/Unit/MSFT_xServiceResource.Tests.ps1, line 112 at r3 (raw file):

        }

        function Get-InvalidArgumentRecord

Any functions defined in the test file should be moved to the test helper file.
(Unless it's a stub function, but I'm not sure this one is)

Tests/Unit/MSFT_xServiceResource.Tests.ps1, line 210 at r3 (raw file):

        }

                Describe "$script:DscResourceName\Set-TargetResource" {

Why is this indented so far?
Is that just Reviewable being weird?

Tests/Unit/MSFT_xServiceResource.Tests.ps1, line 454 at r3 (raw file):

             Context 'Service exists and should, State is Ignore, all parameters passed' {
                # Mocks that should be called
                Mock `

Can you put the Command name parameter up on the same line as the Mock call?
It makes it a little easier to tell what is being mocked.

Tests/Unit/MSFT_xServiceResource.Tests.ps1, line 592 at r3 (raw file):

        Describe "$script:DscResourceName\Test-TargetResource" {
            # Mocks that should be called
            Mock `

These mocks too

Comments from Reviewable

Review status: 2 of 12 files reviewed at latest revision, 19 unresolved discussions.

README.md, line 93 at r3 (raw file):
Previously, kwirkykat (Katie Keim) wrote…
> Add under resource description: This resource works on Nano Server.
> Change Requirements to None

Done.

DSCResources/MSFT_xServiceResource/MSFT_xServiceResource.psm1, line 110 at r3 (raw file):
Previously, kwirkykat (Katie Keim) wrote…
> > on the desktop.
> on the desktop or not.

Done.

DSCResources/MSFT_xServiceResource/MSFT_xServiceResource.psm1, line 278 at r3 (raw file):
Previously, kwirkykat (Katie Keim) wrote…
> > if ($PSBoundParameters.ContainsKey('Path'))
> >
> >     {
> >         $writeWritePropertiesArguments['Path'] = $Path
> >     }
> > ...
> >     if ($PSBoundParameters.ContainsKey('Dependencies'))
> >
> >     {
> >         $writeWritePropertiesArguments['Dependencies'] = $Dependencies
> >     }
>
> This whole block should be replaced with a foreach loop. E.g.:
>
> ```
> foreach ($parameter in @( ...names of parameters... ))
> {
>     if ($PSBoundParameters.ContainsKey($parameter))
>     {
>         $writeWritePropertiesArguments[$parameter] = $PSBoundParameters[$parameter]
>     }
> }
> ```

Done.

DSCResources/MSFT_xServiceResource/MSFT_xServiceResource.psm1, line 313 at r3 (raw file):
Previously, kwirkykat (Katie Keim) wrote…
> >  the existence of the service is the only thing that will be checked.
>
> only the the existence of the service will be checked.

Done.

DSCResources/MSFT_xServiceResource/MSFT_xServiceResource.psm1, line 346 at r3 (raw file):
Previously, kwirkykat (Katie Keim) wrote…
> > Indicates what the time to wait for the service to start should be in milliseconds.
> >         Optional. Default is 3000.
>
> Not used in Test-TargetResource.

Done.

DSCResources/MSFT_xServiceResource/MSFT_xServiceResource.psm1, line 350 at r3 (raw file):
Previously, kwirkykat (Katie Keim) wrote…
> > Indicates what the time to wait for the service to stop should be in milliseconds.
> >         Optional. Default is 3000.
>
> Not used in Test-TargetResource.

Done.

DSCResources/MSFT_xServiceResource/MSFT_xServiceResource.psm1, line 420 at r3 (raw file):
Previously, kwirkykat (Katie Keim) wrote…
> > 'Not checking other values since Ensure is set to Absent'
>
> This needs to be moved to the strings file.

Done.

DSCResources/MSFT_xServiceResource/MSFT_xServiceResource.psm1, line 426 at r3 (raw file):
Previously, kwirkykat (Katie Keim) wrote…
> > 'Service does not exist'
>
> This needs to be moved to the strings file.

Done.

DSCResources/MSFT_xServiceResource/MSFT_xServiceResource.psm1, line 711 at r3 (raw file):
Previously, kwirkykat (Katie Keim) wrote…
> > respects whatif
>
> respects WhatIf.

Done.

DSCResources/MSFT_xServiceResource/MSFT_xServiceResource.psm1, line 889 at r3 (raw file):
Previously, kwirkykat (Katie Keim) wrote…
> > respects whatif
>
> respects  WhatIf.

Done.

DSCResources/MSFT_xServiceResource/MSFT_xServiceResource.psm1, line 1087 at r3 (raw file):
Previously, kwirkykat (Katie Keim) wrote…
> > that
>
> BuiltInAccount

Done.

DSCResources/MSFT_xServiceResource/MSFT_xServiceResource.psm1, line 1088 at r3 (raw file):
Previously, kwirkykat (Katie Keim) wrote…
> > that
>
> Credential

Done.

DSCResources/MSFT_xServiceResource/MSFT_xServiceResource.schema.mof, line 6 at r3 (raw file):
Previously, kwirkykat (Katie Keim) wrote…
> The first letter of key, write, read should be capitalized for consistency.

Done.

Tests/Integration/MSFT_xServiceResource.Integration.Tests.ps1, line 60 at r3 (raw file):
Previously, kwirkykat (Katie Keim) wrote…
> The names of the Describe blocks should be updated to be more 'friendly' (the underscores should be removed) and better describe what tests this describe block should contain.
>
> For example, this one can be renamed to "$($script:DscResourceName) - Creating a service"
>
> The other Describe blocks should be updated in the same way.

Done.

Tests/Unit/MSFT_xServiceResource.Tests.ps1, line 112 at r3 (raw file):
Previously, kwirkykat (Katie Keim) wrote…
> Any functions defined in the test file should be moved to the test helper file.
>
> (Unless it's a stub function, but I'm not sure this one is)

Done.

Tests/Unit/MSFT_xServiceResource.Tests.ps1, line 210 at r3 (raw file):
Previously, kwirkykat (Katie Keim) wrote…
> Why is this indented so far?
> Is that just Reviewable being weird?

Done.

Tests/Unit/MSFT_xServiceResource.Tests.ps1, line 454 at r3 (raw file):
Previously, kwirkykat (Katie Keim) wrote…
> Can you put the Command name parameter up on the same line as the Mock call?
> It makes it a little easier to tell what is being mocked.

Done.

Tests/Unit/MSFT_xServiceResource.Tests.ps1, line 592 at r3 (raw file):
Previously, kwirkykat (Katie Keim) wrote…
> These mocks too

Done.

Comments from Reviewable

Reviewed 2 of 15 files at r1, 2 of 10 files at r3, 5 of 7 files at r4, 2 of 2 files at r5.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable


NIFI-2326 fixed test breaking static class causing ordering issues.  …

…Addressed potential issue in NarClassLoaders for multi-init scenarios - now idempotent for a given config

LGTM! Especially like cleaning job in TemplateSerializer that was causing me issues when investigating something in the early stages of NIFI-826 and ironically I had to do almost the same to get around, so +1.


Thomas Asenov test solution

Proposed Changes

Created item details page/routing
Displayed percentage of total budget an item is contributing with by text and pie chart
Made this page responsive

Coverage decreased (-3.0%) to 74.907% when pulling ac7f14ceae70ed27bd26108a3bebfbd58b705fc5 on thomasasenov:thomas_test into 7cada79709a3c2ddfffda4204b34da2cb98a89ed on ModusCreateOrg:master.

Coverage decreased (-3.0%) to 74.907% when pulling 35d31ab00b0401759011a79df4c3c772cfefefeb on thomasasenov:thomas_test into 7cada79709a3c2ddfffda4204b34da2cb98a89ed on ModusCreateOrg:master.

FYI, I added the new route for item details page, but I am using Reports route as a parent because this task is showing reports data.

Coverage decreased (-3.0%) to 74.907% when pulling 9b9cd4e4a259b195f6e0fee84e27bc1e30a2df62 on thomasasenov:thomas_test into 7cada79709a3c2ddfffda4204b34da2cb98a89ed on ModusCreateOrg:master.


don't use arguments

Accessing arguments inside a function is slow so.
Now used args instead of arguments

Thanks for the PR! Can you clarify what you mean? My understanding is that just referencing arguments hasn’t been slow in many years?
Also—this code doesn’t do the same thing as before, and now breaks. args and arguments actually refer to arguments from different functions. args was poorly named in this case, which likely caused the confusion.

@jayphelps Yes - I just understand it why my changes broke functionality.
Accessing to arguments is slow for V8 engine and for Chakra Core many years and now as well. So using spread operator should interpreted faster than access to arguments.
http://www.jspatterns.com/arguments-considered-harmful/

However, it's not a good idea to use arguments for the reasons of :

performance
security
The arguments object is not automatically created every time the function is called, the JavaScript engine will only create it on-demand, if it's used. And that creation is not free in terms of performance. The difference between using arguments vs. not using it could be anywhere between 1.5 times to 4 times slower, depending on the browser
Edited: I just run some benchmarks and can't see any huge difference between using arguments vs rest operator.
I'll fix this functionality and will stay it to you - to decide merge this or not

@shahen94 ahhh got it, I misunderstood what this code was doing. I thought it was doing handle(...arguments) which definitely doesn't have any notable performance issues (it's just sugar for handle.apply(undefined, arguments), but since we're literally passing the variable as-is handle(arguments) that's a different story and could prevent it from being JIT'able because the function you pass it to could actually modify the calling function's arguments. Nice catch! 🏅
I'm guessing the reason why in practice this didn't have any difference in performance is that the handle function is likely inlined and the compiler can tell that no one ever touches anything on the arguments object except arguments.length which is safe. Either way not all browsers could be smart enough to detect that or we might later change the code and cause a deopt. So I think this PR is 💯
Thanks again!


Specification

Same as vector-tile-spec we should have a SPEC.md specification for this.

Speaking as somebody who is trying to implement this: Yes, we need a specification. :-)

Not seeing any movement here. Feel free to reopen but I'd prefer not to own this issue.


Sentinelhealth expected timeframe

How much of a delay are analytic rule runs supposed to be seen on the SentinelHealth table?
I saved a rule and had to wait more than 2 hours for it to be recorded as a rule runs on the table. My rule runs every 5 minutes as well.

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: ab3b66d3-6ac3-7ade-bb26-7a7e4ec7550c
Version Independent ID: f78b0b7f-f959-2254-c095-c622e1bd4356
Content: Turn on auditing and health monitoring in Microsoft Sentinel
Content Source: articles/sentinel/enable-monitoring.md
Service: microsoft-sentinel
GitHub Login: @limwainstein
Microsoft Alias: lwainstein

@applefacts
Thanks for your feedback! We will investigate and update as appropriate.

@cwatson-cat or @yelevin is this yours?

@applefacts
Since this issue isn't directly related to improving our docs, and to gain a better understanding of your issue, I'd recommend working closer with our support team via an Azure support request. Or you can leverage our Q&A forum by posting your issue there so our community, and MVPs can further assist you in troubleshooting this issue or finding potential workarounds.Teams Q&A forum for technical questions about the configuration and administration of Microsoft Teams on Windows.
Microsoft Teams Community forum


Allow specifying population name in morphology to sonata converions

Codecov Report

Merging #10 (35e1bbd) into main (d90e2df) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main      #10   +/-   ##
=======================================
  Coverage   99.63%   99.63%
=======================================
  Files          14       14
  Lines         819      820    +1
=======================================
+ Hits          816      817    +1
  Misses          3        3

Flag
Coverage Δ

pytest
99.63% <100.00%> (+<0.01%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

vascpy/cli.py
100.00% <100.00%> (ø)

vascpy/point_graph/io.py
100.00% <100.00%> (ø)

vascpy/point_vasculature.py
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d90e2df...35e1bbd. Read the comment docs.


Need to check dependency-check rules

Hey guys, I've been testing dependency-check for a few days now, it's realy useful, but I'm facing the need of having a look at its rules, I din't find them in the source code. I'd be grateful if you guys could help me.

There are no "rules" per se. See How ODC Works and possibly the very outdated wiki


Update elliptic_hyperbolic_lcs_details.m

Looks good; thank you! Should probably also update https://github.com/jeixav/LCS-Tool/blob/master/demo/ocean_dataset/elliptic_hyperbolic_lcs.m and https://github.com/jeixav/LCS-Tool/blob/master/demo/ocean_dataset/flow_animation.m.

@jeixav
i have try delete the boundry condition in https://github.com/jeixav/LCS-Tool/blob/master/demo/ocean_dataset/elliptic_hyperbolic_lcs.m ,it can also have the fine result,but  https://github.com/jeixav/LCS-Tool/blob/master/demo/ocean_dataset/flow_animation.m. can't run even if i didn't change the conditon.
in additon,can the method be used in some other area? whether the original data have some restrict?i have try use the ofes data(numerical model data)in some other place .but when i do the eig() ,program has errors.matlab prompt that it  have many NaN.

I have no errors with flow_animation.m @tuxication fixed a few problems in #12. Have you pulled that commit?

flow_animation.m also can delete the conditons.i have pull requests.


feat(prql-compiler): implement Target::from_str and Target::default

Currently, the sql. prefix have to be removed from the target name and pass to Dialect::from_str.
This PR implements Target::from_str and does this on the Target::from_str side, eliminating the need for downstream software to implement this process.
Example of Use: eitsupi/prqlr#78

As far as trying in eitsupi/prqlr#78, I think this is working fine.
But obviously tests on these should be added here.
I am not familiar with Rust testing and would like to add tests at another time...

I am not familiar with Rust testing

It's surprisingly easy!
We can just have something like this, in the file:
#[cfg(test)]
mod test {
use insta::assert_debug_snapshot;

#[test]
fn test_target_from_str() {

    assert_debug_snapshot!(Target::from_str("sql.postgres".to_string()), @"");

    assert!(Target::from_str("sql.poostgres".to_string().is_err());
}
}

...then running cargo insta test --accept will fill out the @ string.


HyperlinkButton shouldn't have extra padding

In my app, I have kept hyperlink buttons after a text block and with the new styling  there's extra padding which doesn't make the UI consistent

In my app, I have kept hyperlink buttons after a text block and with the new styling there's extra padding which doesn't make the UI consistent

The HyperlinkButton is designed to sit alongside other Buttons, and so they have padding to match, and to enable displaying the PointerOver and Pressed states.
You should include a Hyperlink inside a TextBox, so they line up.

@mdtauk No but this is inside a StackPanel with a list of links

@mdtauk No but this is inside a StackPanel with a list of links

You can still use a normal Hyperlink control, and not the HyperlinkButton.

The current hyperlink button padding is by design. If this doesn't work for your app we expose the ButtonPadding resource which you can override https://github.com/microsoft/microsoft-ui-xaml/blob/77bbdcf990ae7bed9de662fe1de9476f23e70eaf/dev/CommonStyles/Button_themeresources.xaml#L131 Or you can restyle or retemplate.


Preflight PV Check for SNO Hub deployment fails

https://github.com/rh-ecosystem-edge/ztp-pipeline-relocatable/blob/2fd9aec8e153cb249d2f6fa36b6407f1c6a93917/shared-utils/verify_preflight.sh#L123
Hello all,
we found an issue in the pipeline (deploy-ztp-hub) in our enviroment.
The following step fails on our enviroment in the preflight steps:

Verify the PV available

The command "oc get pv | wc -l" evaluated to '2' in our enviroment so the pipeline fails.
Our workaround just add a dummy PV in our enviroment, but maybe concider the value changing from 3 to 2. Or refactor the test.
Greets,
schmti

Hi,
The test is OK we need at least 3 pv available but in some use cases we need up to 5-6
$ oc get pv NAME    CAPACITY   ACCESS MODES   RECLAIM POLICY   STATUS      CLAIM                                             STORAGECLASS   REASON   AGE pv001   200Gi      RWO            Recycle          Bound       multicluster-engine/assisted-service                                      15d pv002   200Gi      RWO            Recycle          Bound       open-cluster-management/search-redisgraph-pvc-0                           15d pv003   200Gi      RWO            Recycle          Bound       edgecluster-deployer/ztp-pvc                                              15d pv004   200Gi      RWO            Recycle          Available                                                                             15d pv005   200Gi      RWO            Recycle          Available                                                                             15d pv006   200Gi      RWO            Recycle          Bound       default/httpd-pv-claim                                                    15d pv007   200Gi      RWO            Recycle          Bound       ztpfw-registry/data-pvc                                                   15d pv008   200Gi      RWO            Recycle          Available                                                                             15d pv009   200Gi      RWO            Recycle          Bound       multicluster-engine/postgres                                              15d pv010   200Gi      RWO            Recycle          Available                                                                             15d

if you're just using 2, the pipeline will fail

We use dynamic provisioning for our PVs. The Cluster have a "default" StorageClass. In addtion we add more Operators for the mirroring so we need bigger PVs and PVCs.