drivers: ethernet: add PTP_clock for SOC_SERIES_STM32F4X

add PTP_clock for SOC_SERIES_STM32F4X

@mariopaja
could you check this PR please.

@mariopaja could you check this PR please.

@Desvauxm-st I noticed that I dont have the board with me :/ . I will be able to test it by the end of next week

OK thanks you

@Desvauxm-st I just tested the change and it is not working for me.
Test case:
Sample: gPTP
Peer-to-Peer connection between Nucleo F429ZI and MIMXRT1064 EVK.
Problem:
I get the following warning:
<wrn> net_gptp: Not AS capable:<PHONE_NUMBER> ns > 100000 ns
nucleo_f429zi_net_tap.zip
Nucleo F429ZI:
net gptp 1
Port id    : 1 (DISABLED)
Interface  : 0x200013a8 [1]
Clock id   : 00:80:e1:ff:fe:55:38:4c
Version    : 2
AS capable : no

Configuration:
Time synchronization and Best Master Selection enabled        : yes
The port is measuring the path delay                          : yes
One way propagation time on the link attached to this port    :<PHONE_NUMBER> ns
Propagation time threshold for the link attached to this port : 100000 ns
Estimate of the ratio of the frequency with the peer          : 0
Asymmetry on the link relative to the grand master time base  : 0
Maximum interval between sync messages                        : 10000000
Maximum number of Path Delay Requests without a response      : 3
Current Sync sequence id for this port                        : 62821
Current Path Delay Request sequence id for this port          : 32610
Current Announce sequence id for this port                    : 10678
Current Signaling sequence id for this port                   : 72
Whether neighborRateRatio needs to be computed for this port  : yes
Whether neighborPropDelay needs to be computed for this port  : yes
Initial Announce Interval as a Logarithm to base 2            : 0
Current Announce Interval as a Logarithm to base 2            : 0
Initial Sync Interval as a Logarithm to base 2                : -4
Current Sync Interval as a Logarithm to base 2                : -4
Initial Path Delay Request Interval as a Logarithm to base 2  : 0
Current Path Delay Request Interval as a Logarithm to base 2  : 0
Time without receiving announce messages before running BMCA  : 1 ms (3)
Time without receiving sync messages before running BMCA      : 0 ms (3)
Sync event transmission interval for the port                 : 62 ms
Path Delay Request transmission interval for the port         : 1000 ms
BMCA default priority1                                        : 248
BMCA default priority2                                        : 248

Runtime status:
Current global port state                                : DISABLED
Path Delay Request state machine variables:
        Current state                                    : WAIT_ITV_TIMER
        Initial Path Delay Response Peer Timestamp       :<PHONE_NUMBER>0
        Initial Path Delay Response Ingress Timestamp    :<PHONE_NUMBER>00000052
        Path Delay Response messages received            : 1
        Path Delay Follow Up messages received           : 1
        Number of lost Path Delay Responses              : 0
        Timer expired send a new Path Delay Request      : 0
        NeighborRateRatio has been computed successfully : 1
        Path Delay has already been computed after init  : 0
        Count consecutive reqs with multiple responses   : 0
Path Delay Response state machine variables:
        Current state                                    : INITIAL_WAIT_REQ
SyncReceive state machine variables:
        Current state                                    : DISCARD
        A Sync Message has been received                 : no
        A Follow Up Message has been received            : no
        A Follow Up Message timeout                      : no
        Time at which a Sync Message without Follow Up
                                     will be discarded   : 0
SyncSend state machine variables:
        Current state                                    : INITIALIZING
        A MDSyncSend structure has been received         : no
        The timestamp for the sync msg has been received : no
PortSyncSyncReceive state machine variables:
        Current state                                    : DISCARD
        Grand Master / Local Clock frequency ratio       : 0.000000
        A MDSyncReceive struct is ready to be processed  : no
        Expiry of SyncReceiptTimeoutTimer                : no
PortSyncSyncSend state machine variables:
        Current state                                    : TRANSMIT_INIT
        Follow Up Correction Field of last recv PSS      : 0
        Upstream Tx Time of the last recv PortSyncSync   : 0
        Rate Ratio of the last received PortSyncSync     : 0.000000
        GM Freq Change of the last received PortSyncSync : 0.000000
        GM Time Base Indicator of last recv PortSyncSync : 0
        Received Port Number of last recv PortSyncSync   : 0
        PortSyncSync structure is ready to be processed  : no
        Flag when the half_sync_itv_timer has expired    : no
        Has half_sync_itv_timer expired twice            : no
        Has syncReceiptTimeoutTime expired               : no
PortAnnounceReceive state machine variables:
        Current state                                    : RECEIVE
        An announce message is ready to be processed     : no
PortAnnounceInformation state machine variables:
        Current state                                    : POST_DISABLED
        Expired announce information                     : yes
PortAnnounceTransmit state machine variables:
        Current state                                    : POST_IDLE
        Trigger announce information                     : no

Statistics:
Sync messages received                 : 405
Follow Up messages received            : 50
Path Delay Request messages received   : 400
Path Delay Response messages received  : 50
Path Delay messages threshold exceeded : 49
Path Delay Follow Up messages received : 50
Announce messages received             : 51
ptp messages discarded                 : 0
Sync reception timeout                 : 0
Announce reception timeout             : 0
Path Delay Requests without a response : 3
Sync messages sent                     : 0
Follow Up messages sent                : 0
Path Delay Request messages sent       : 53
Path Delay Response messages sent      : 401
Path Delay Response FUP messages sent  : 401
Announce messages sent                 : 0

MIMXRT1064 EVK:
net gptp 1
Port id    : 1 (MASTER)
Interface  : 0x800012e0 [1]
Clock id   : 02:04:9f:ff:fe:a1:25:26
Version    : 2
AS capable : yes

Configuration:
Time synchronization and Best Master Selection enabled        : yes
The port is measuring the path delay                          : yes
One way propagation time on the link attached to this port    : 0 ns
Propagation time threshold for the link attached to this port : 1000000 ns
Estimate of the ratio of the frequency with the peer          : 1
Asymmetry on the link relative to the grand master time base  : 0
Maximum interval between sync messages                        : 10000000
Maximum number of Path Delay Requests without a response      : 3
Current Sync sequence id for this port                        : 23843
Current Path Delay Request sequence id for this port          : 19820
Current Announce sequence id for this port                    : 15190
Current Signaling sequence id for this port                   : 22317
Whether neighborRateRatio needs to be computed for this port  : yes
Whether neighborPropDelay needs to be computed for this port  : yes
Initial Announce Interval as a Logarithm to base 2            : 0
Current Announce Interval as a Logarithm to base 2            : 0
Initial Sync Interval as a Logarithm to base 2                : -4
Current Sync Interval as a Logarithm to base 2                : -4
Initial Path Delay Request Interval as a Logarithm to base 2  : -3
Current Path Delay Request Interval as a Logarithm to base 2  : -3
Time without receiving announce messages before running BMCA  : 1 ms (3)
Time without receiving sync messages before running BMCA      : 0 ms (3)
Sync event transmission interval for the port                 : 62 ms
Path Delay Request transmission interval for the port         : 125 ms
BMCA default priority1                                        : 100
BMCA default priority2                                        : 248

Runtime status:
Current global port state                                : MASTER
Path Delay Request state machine variables:
        Current state                                    : WAIT_ITV_TIMER
        Initial Path Delay Response Peer Timestamp       :<PHONE_NUMBER>0
        Initial Path Delay Response Ingress Timestamp    :<PHONE_NUMBER>0
        Path Delay Response messages received            : 1
        Path Delay Follow Up messages received           : 1
        Number of lost Path Delay Responses              : 0
        Timer expired send a new Path Delay Request      : 0
        NeighborRateRatio has been computed successfully : 1
        Path Delay has already been computed after init  : 0
        Count consecutive reqs with multiple responses   : 0
Path Delay Response state machine variables:
        Current state                                    : INITIAL_WAIT_REQ
SyncReceive state machine variables:
        Current state                                    : DISCARD
        A Sync Message has been received                 : no
        A Follow Up Message has been received            : no
        A Follow Up Message timeout                      : no
        Time at which a Sync Message without Follow Up
                                     will be discarded   : 0
SyncSend state machine variables:
        Current state                                    : SEND_SYNC
        A MDSyncSend structure has been received         : no
        The timestamp for the sync msg has been received : no
PortSyncSyncReceive state machine variables:
        Current state                                    : DISCARD
        Grand Master / Local Clock frequency ratio       : 0.000000
        A MDSyncReceive struct is ready to be processed  : no
        Expiry of SyncReceiptTimeoutTimer                : no
PortSyncSyncSend state machine variables:
        Current state                                    : SYNC_RECEIPT_TIMEOUT
        Follow Up Correction Field of last recv PSS      : 0
        Upstream Tx Time of the last recv PortSyncSync   :<PHONE_NUMBER>0
        Rate Ratio of the last received PortSyncSync     : 0.000000
        GM Freq Change of the last received PortSyncSync : 0.000000
        GM Time Base Indicator of last recv PortSyncSync : 0
        Received Port Number of last recv PortSyncSync   : 0
        PortSyncSync structure is ready to be processed  : no
        Flag when the half_sync_itv_timer has expired    : yes
        Has half_sync_itv_timer expired twice            : no
        Has syncReceiptTimeoutTime expired               : yes
PortAnnounceReceive state machine variables:
        Current state                                    : RECEIVE
        An announce message is ready to be processed     : no
PortAnnounceInformation state machine variables:
        Current state                                    : CURRENT
        Expired announce information                     : yes
PortAnnounceTransmit state machine variables:
        Current state                                    : POST_IDLE
        Trigger announce information                     : no

Statistics:
Sync messages received                 : 0
Follow Up messages received            : 270
Path Delay Request messages received   : 35
Path Delay Response messages received  : 270
Path Delay messages threshold exceeded : 0
Path Delay Follow Up messages received : 270
Announce messages received             : 0
ptp messages discarded                 : 0
Sync reception timeout                 : 272
Announce reception timeout             : 0
Path Delay Requests without a response : 16
Sync messages sent                     : 273
Follow Up messages sent                : 273
Path Delay Request messages sent       : 286
Path Delay Response messages sent      : 35
Path Delay Response FUP messages sent  : 34
Announce messages sent                 : 34

PS: I can also later the week test it with a Nucleo H745ZI-Q board and compare the results.

@mariopaja
in fact we faced last year with the STMH7xx serie with the same issue you found.
we add changed the code like that:
into stm32cube/stm32h5xx/drivers/src/stm32h5xx_hal_eth.c
fix to the HAL_API_V2 to get PTP to work in STM32H5 #62800
to resume it is these modifications:

I try to do the same for STM32F4xx  serie but i m not sure at all.
could you check with these modifications in
modules\hal\stm32\stm32cube\stm32f4xx\drivers\src\stm32f4xx_hal_eth.c
see the file after:
stm32f4xx_hal_eth.zip
the modifications is like that:

and:

can you try that or try to change the line 1140 with the previous on
in fact I don't known if we must use to check timestamp available even the bit
TSSTU or TSARU bit in  PTPTSCR register .

@Desvauxm-st
Are you using the same prj.conf for both boards but just changing the IP address?

@mariopaja
I use the last prj.conf only for nucleo_f429zi ( with the ip inverted )
for the nucleo_h753zi i use the previous prj.conf

@Desvauxm-st
I was not able to replicate your results just by changing the prj.conf.
However I replaced the following lines:
	if ((port_ds->neighbor_prop_delay <=
	     port_ds->neighbor_prop_delay_thresh)) {
		port_ds->as_capable = true;
	} else {
		port_ds->as_capable = false;

		NET_WARN("Not AS capable: %u ns > %u ns",
			 (uint32_t)port_ds->neighbor_prop_delay,
			 (uint32_t)port_ds->neighbor_prop_delay_thresh);

		GPTP_STATS_INC(port, neighbor_prop_delay_exceeded);
	}

with
port_ds->as_capable = true;
And the board was immediatelly recognised as master.
I did the change because I noticed that CONFIG_NET_GPTP_NEIGHBOR_PROP_DELAY_THR was not setting the  value that was defined in pro.conf.
Additionally, it was fulfilling the <= criteria but it was always assigned false and then assigned as Not AS capable
[00:08:40.713,000] <inf> net_gptp: neighbor_prop_delay:<PHONE_NUMBER> n
[00:08:40.713,000] <inf> net_gptp: neighbor_prop_delay_thresh:<PHONE_NUMBER> n

STM32H745ZI-Q
uart:~$ net gptp 1
Port id    : 1 (SLAVE)
Interface  : 0x240013c8 [1]
Clock id   : 00:80:e1:ff:fe:75:ca:99
Version    : 2
AS capable : yes

Configuration:
Time synchronization and Best Master Selection enabled        : yes
The port is measuring the path delay                          : yes
One way propagation time on the link attached to this port    : 0 ns
Propagation time threshold for the link attached to this port : 100000 ns
Estimate of the ratio of the frequency with the peer          : 1
Asymmetry on the link relative to the grand master time base  : 0
Maximum interval between sync messages                        : 375000000
Maximum number of Path Delay Requests without a response      : 3
Current Sync sequence id for this port                        : 32945
Current Path Delay Request sequence id for this port          : 49891
Current Announce sequence id for this port                    : 31848
Current Signaling sequence id for this port                   : 17679
Whether neighborRateRatio needs to be computed for this port  : yes
Whether neighborPropDelay needs to be computed for this port  : yes
Initial Announce Interval as a Logarithm to base 2            : 0
Current Announce Interval as a Logarithm to base 2            : 0
Initial Sync Interval as a Logarithm to base 2                : -4
Current Sync Interval as a Logarithm to base 2                : -4
Initial Path Delay Request Interval as a Logarithm to base 2  : 0
Current Path Delay Request Interval as a Logarithm to base 2  : 0
Time without receiving announce messages before running BMCA  : 3000 ms (3)
Time without receiving sync messages before running BMCA      : 0 ms (3)
Sync event transmission interval for the port                 : 62 ms
Path Delay Request transmission interval for the port         : 1000 ms
BMCA default priority1                                        : 248
BMCA default priority2                                        : 248

Runtime status:
Current global port state                                : SLAVE
Path Delay Request state machine variables:
        Current state                                    : WAIT_ITV_TIMER
        Initial Path Delay Response Peer Timestamp       : 414435216
        Initial Path Delay Response Ingress Timestamp    :<PHONE_NUMBER>

STM32F429ZI
net gptp 1
Port id    : 1 (MASTER)
Interface  : 0x200013d0 [1]
Clock id   : 00:80:e1:ff:fe:55:38:4c
Version    : 2
AS capable : yes

Configuration:
Time synchronization and Best Master Selection enabled        : yes
The port is measuring the path delay                          : yes
One way propagation time on the link attached to this port    :<PHONE_NUMBER> ns
Propagation time threshold for the link attached to this port :<PHONE_NUMBER> ns
Estimate of the ratio of the frequency with the peer          :<PHONE_NUMBER>
Asymmetry on the link relative to the grand master time base  : 0
Maximum interval between sync messages                        :<PHONE_NUMBER>
Maximum number of Path Delay Requests without a response      : 3
Current Sync sequence id for this port                        : 39729
Current Path Delay Request sequence id for this port          : 9263
Current Announce sequence id for this port                    : 3052
Current Signaling sequence id for this port                   : 18228
Whether neighborRateRatio needs to be computed for this port  : yes
Whether neighborPropDelay needs to be computed for this port  : yes
Initial Announce Interval as a Logarithm to base 2            : 0
Current Announce Interval as a Logarithm to base 2            : 0
Initial Sync Interval as a Logarithm to base 2                : -4
Current Sync Interval as a Logarithm to base 2                : -4
Initial Path Delay Request Interval as a Logarithm to base 2  : 0
Current Path Delay Request Interval as a Logarithm to base 2  : 0
Time without receiving announce messages before running BMCA  : 1 ms (10)
Time without receiving sync messages before running BMCA      : 0 ms (10)
Sync event transmission interval for the port                 : 62 ms
Path Delay Request transmission interval for the port         : 1000 ms
BMCA default priority1                                        : 248
BMCA default priority2                                        : 248


Added init(jsonString) and made init(data) throw

@zhigang1992 @wongzigii
Fixes https://github.com/SwiftyJSON/SwiftyJSON/issues/459 and https://github.com/SwiftyJSON/SwiftyJSON/issues/456
This is an implementation of my proposal in https://github.com/SwiftyJSON/SwiftyJSON/issues/459#issuecomment-262155181. At a high level the changes are as follow:

Added init(jsonString: String) throws which creates a JSON object from a valid json string. If the string cannot be converted to data or parsed by NSJSONSerialization, the initializer will throw an appropriate error as opposed to failing silently.
Added documentation + tests around the new initializer and updated the README
Removed JSON.parse which was doing the same thing (but would fail silently)
Made init(data: Data) throw as well, to handle invalid JSON data coming through.

This is a code breaking change since init(data: Data) now throws.
Let me know what you think.

It might not even have to be a breaking change. Could we use the protocol extension layer and call the function from there ?

@wongzigii Are we good on this PR?

I would like to let @zhigang1992 to take a look and move on.

Since this is a breaking change, what about adding a change log entry for this?

@wongzigii Great suggestion. Updated the CHANGELOG.

@zhigang1992 Bump

@ldiqual I want to get this into mater. Could you resolve the conflict?  Seems the conflict is related to #664

Closing in favor of #833


fix contract_request migration with default value for contract_type

Coverage remained the same at 88.669% when pulling 472e02b6657783679651b23558344b1ac1f959bd on fix-migration into 4b47a2f051ba5e2e9520c492ae58b6414f7c4842 on develop.


Problems setting up Library

Hello,
I tried to setup Library for my organisation, but I’m facing an error that I don’t understand.
Here are the steps I took :

Create a shared folder under my account (managed by my organisation)
Create a project under my organisation
Operations on GCP :

Enable Google Drive API
Enable Cloud Datastore in Datastore mode (nothing about mode is specified in README.md)
Create a service account with Cloud Datastore User role (and get cred JSON file)
Create oAuth credentials with consent screen

Operations on local environment :

Cloned repo
Installed dependencies (npm i --no-optional)
Copy oAuth cred JSON file to server/.auth.json
Setup .env file with :

NODE_ENV : development
GOOGLE_CLIENT_ID : client id from oAuth cred
GOOGLE_CLIENT_SECRET : client secret from oAuth cred
GCP_PROJECT_ID : created project ID
APPROVED_DOMAINS : same as approved domains set for oAuth credentials
SESSION_SECRET : generated with node -e "console.log(require('crypto').randomBytes(256).toString('base64'));"
DRIVE_TYPE : set to folder
DRIVE_ID : created folder ID

After I took those steps, I launched project with npm run build && npm run watch and navigated to http://localhost:3000.
I directly got a 500 error and this is logged in terminal :
{ message:
[0]    '9 FAILED_PRECONDITION: no matching index found. recommended index is:\n- kind: LibraryViewTeam\n  properties:\n  - name: userId\n  - name: lastViewedAt\n    direction: desc\n',
[0]   stack:
[0]    'Error: 9 FAILED_PRECONDITION: no matching index found. recommended index is:\n- kind: LibraryViewTeam\n  properties:\n  - name: userId\n  - name: lastViewedAt\n    direction: desc\n\n    at Object.exports.createStatusError (/home/nicolas/dev/yellow/library/node_modules/grpc/src/common.js:91:15)\n    at Object.onReceiveStatus (/home/nicolas/dev/yellow/library/node_modules/grpc/src/client_interceptors.js:1204:28)\n    at InterceptingListener._callNext (/home/nicolas/dev/yellow/library/node_modules/grpc/src/client_interceptors.js:568:42)\n    at InterceptingListener.onReceiveStatus (/home/nicolas/dev/yellow/library/node_modules/grpc/src/client_interceptors.js:618:8)\n    at callback (/home/nicolas/dev/yellow/library/node_modules/grpc/src/client_interceptors.js:845:24)',
[0]   code: 9,
[0]   metadata: { _internal_repr: {} },
[0]   details:
[0]    'no matching index found. recommended index is:\n- kind: LibraryViewTeam\n  properties:\n  - name: userId\n  - name: lastViewedAt\n    direction: desc\n',
[0]   note:
[0]    'Exception occurred in retry method that was not classified as transient' }

I can’t find where I’m wrong setting up Library... Can you please help me ?
Thanks in advance.

Hey @nicolas-goudry, the stack trace that you provided is likely unrelated to the 500.
It's not mentioned in your issue description: did you share the folder you created with the service account email that you got from the service account JSON file? Lack of access is the most likely reason for receiving a 500, followed by an error generating the site structure if your shared folder is empty. I'd recommend the steps listed on the demo site in sequence, if you haven't already.
The specific trace you mentioned is printed when Cloud Datastore indices have not been configured, but it only blocks reading history operations, not rendering the site itself. Do you see another stack trace printed in addition to that one?

You might missed this step of creating the indexes:
gcloud datastore indexes create ./config/index.yaml --project YOUR_PROJECT_ID_HERE

@isaacwhite Oh my… Sorry, I missed this step. I thought that if the service account was created under my organisation, it would get access to folders shared to this org, but now I guess it only works this way with team drives?
Also, I was missing the indexes creation step, thanks @namdau


Add support to Composer archive:zip script

This update adds support to the new archive:zip script that will be used to create archive of the plugin. This command will replace the npm run plugin-zip command from wp-scripts which rely on the npm pack and has issues that we can't change. For example, it cannot exclude since the README.md file.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 86.86%. Comparing base (3e28927) to head (3741160).

Additional details and impacted files
@@             Coverage Diff              @@
##               main      #54      +/-   ##
============================================
+ Coverage     86.58%   86.86%   +0.27%
+ Complexity      299      293       -6
============================================
  Files            33       32       -1
  Lines           969      997      +28
============================================
+ Hits            839      866      +27
- Misses          130      131       +1

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


v1.4.3 and v1.5.0 wont open any window on Linux

Am I missing something, or the latest working version on linux seems to be v.1.4.1.
AppImage is missing from the 1.5.0 release; I manage to build an AppImage from sources using yarn and following the provided instructions but it fails to open any window on an arch-based linux.I cannot help finding what is wrong because I know nothing about yarn.
The deb version does no load either.
The 1.4.3 version has an AppImage, but it also fails to open any window on the same system where v1.4.1 works.
The 1.4.1 version works (both directly from the AppImage or extracting and installing manually the necessary files from the AppImage).
The AppImage available at https://github.com/TeselaGen/openVectorEditor/releases/download/app-v18.1.0/ove-tauri_0.1.0_amd64.AppImage also works, but I am confused, it seems it is only a demo version, but this is no clearly stated on the corresponding README.md.
Any help in case it is some obscure configuration issue is appreciated.

Hi @biotecov !
In the new releases I am trying out the following install instructions:

Are you saying that didn't work for you?

@biotecov bump :)


failed to upload with azure devops CI

I see many 'Failed to upload' and retries in the log below. It just ends with a HTTP 400 code. Also a required property seems missing. but which one? I have the bash file in my git so i start it from there (instead of downloading it on the fly, the curl way). runtime environment is an azure devops ci pipeline with a bash task. any insight would be helpfull.
according to the docs this should be a valid upload command
CodecovUploader.sh -f coverage.xml -t TOKEN
bash task:
`

task: Bash@3
displayName: "codecov upload"
inputs:
targetType: "filePath"
filePath: "./tests/UnitTests/CodecovUploader.sh"
workingDirectory: $(Build.ArtifactStagingDirectory)
arguments: "-f coverage.xml -t $(codecovToken)"
`

build log:
 2018-11-29T18:08:56.9375973Z ============================================================================== 2018-11-29T18:08:56.9376079Z Task         : Bash 2018-11-29T18:08:56.9376135Z Description  : Run a Bash script on macOS, Linux, or Windows 2018-11-29T18:08:56.9376211Z Version      : 3.142.2 2018-11-29T18:08:56.9376261Z Author       : Microsoft Corporation 2018-11-29T18:08:56.9376339Z Help         : [More Information](https://go.microsoft.com/fwlink/?LinkID=613738) 2018-11-29T18:08:56.9376405Z ============================================================================== 2018-11-29T18:08:57.1942419Z Generating script. 2018-11-29T18:08:57.2101563Z [command]"C:\Program Files\Git\bin\bash.exe" --noprofile --norc -c pwd 2018-11-29T18:08:59.2443806Z /d/a/1/s/tests/UnitTests 2018-11-29T18:08:59.2521074Z Formatted command: . '/d/a/1/s/tests/UnitTests/CodecovUploader.sh' -f coverage.xml -t TOKEN 2018-11-29T18:08:59.2538351Z [command]"C:\Program Files\Git\bin\bash.exe" --noprofile --norc -c pwd 2018-11-29T18:08:59.2784963Z /d/a/_temp 2018-11-29T18:08:59.2821843Z [command]"C:\Program Files\Git\bin\bash.exe" --noprofile --norc /d/a/_temp/6b534e55-177b-477e-a23e-1ceaf6440126.sh 2018-11-29T18:09:01.2691790Z  2018-11-29T18:09:01.2692513Z   _____          _ 2018-11-29T18:09:01.2695173Z  / ____|        | | 2018-11-29T18:09:01.2695623Z | |     ___   __| | ___  ___ _____   __ 2018-11-29T18:09:01.2697365Z | |    / _ \ / _ |/ _ / / _ \ \ / /
2018-11-29T18:09:01.2697942Z | || () | (| |  __/ (| () \ V /
2018-11-29T18:09:01.2698486Z  _____/ _,|_|____/ _/
2018-11-29T18:09:01.2698895Z                               Bash-0b37652
2018-11-29T18:09:01.2699162Z
2018-11-29T18:09:01.2699579Z
2018-11-29T18:09:01.2699946Z x> No CI provider detected.
2018-11-29T18:09:01.2700241Z     Testing inside Docker? http://docs.codecov.io/docs/testing-with-docker
2018-11-29T18:09:01.2700562Z     Testing with Tox? https://docs.codecov.io/docs/python#section-testing-with-tox
2018-11-29T18:09:01.2700912Z     project root: .
2018-11-29T18:09:01.7951314Z /d/a/1/s/tests/UnitTests/CodecovUploader.sh: line 800: hg: command not found
2018-11-29T18:09:02.1064836Z     Yaml not found, that's ok! Learn more at http://docs.codecov.io/docs/codecov-yaml
2018-11-29T18:09:04.6731928Z     -> Found 1 reports
2018-11-29T18:09:04.6732590Z ==> Detecting git/mercurial file structure
2018-11-29T18:09:05.1314591Z ==> Reading reports
2018-11-29T18:09:05.2126687Z     + coverage.xml bytes=1922180
2018-11-29T18:09:05.3561107Z ==> Appending adjustments
2018-11-29T18:09:05.3561852Z     http://docs.codecov.io/docs/fixing-reports
2018-11-29T18:09:05.5082847Z     -> No adjustments found
2018-11-29T18:09:05.5084452Z ==> Gzipping contents
2018-11-29T18:09:05.6576048Z ==> Uploading reports
2018-11-29T18:09:05.6576780Z     url: https://codecov.io
2018-11-29T18:09:05.6577115Z     query: branch=&commit=&build=&build_url=&name=&tag=&slug=&service=&flags=&pr=&job=
2018-11-29T18:09:05.6838588Z     -> Pinging Codecov
2018-11-29T18:09:07.4553762Z     -> Uploading
2018-11-29T18:09:07.4854873Z     X> Failed to upload
2018-11-29T18:09:07.4855048Z     -> Sleeping for 30s and trying again...
2018-11-29T18:09:37.5376691Z     -> Pinging Codecov
2018-11-29T18:09:38.2019191Z     -> Uploading
2018-11-29T18:09:38.2309934Z     X> Failed to upload
2018-11-29T18:09:38.2310580Z     -> Sleeping for 30s and trying again...
2018-11-29T18:10:08.2445016Z     -> Pinging Codecov
2018-11-29T18:10:08.9896520Z     -> Uploading
2018-11-29T18:10:09.0188829Z     X> Failed to upload
2018-11-29T18:10:09.0188989Z     -> Sleeping for 30s and trying again...
2018-11-29T18:10:39.0307268Z     -> Pinging Codecov
2018-11-29T18:10:39.7452292Z     -> Uploading
2018-11-29T18:10:39.7779609Z     X> Failed to upload
2018-11-29T18:10:39.7780526Z     -> Sleeping for 30s and trying again...
2018-11-29T18:11:09.7893480Z     -> Uploading to Codecov
2018-11-29T18:11:10.6712084Z     HTTP 400
2018-11-29T18:11:10.6712368Z missing required properties: ['commit']
`

missing required properties: ['commit']

This tells that the commit property is missing. That's sent as a query param to codecov to identify which commit the report should be associated with. If we look higher up in the log we'll find:
hg: command not found

It looks like you don't have mercurial installed on the machine, which I guess is used to identify the commit. Try to install mercurial.

I am using this YAML config which works:
      - bash: bash <(curl -s https://codecov.io/bash) -f coverage.json -P "$SYSTEM_PULLREQUEST_PULLREQUESTNUMBER"
        env:
          CI_BUILD_ID: $(Build.BuildNumber)-$(Agent.OS)
          CODECOV_NAME: ${{ parameters.name }}
          VCS_BRANCH_NAME: $(Build.SourceBranchName)
          VCS_COMMIT_ID: $(Build.SourceVersion)
          CODECOV_TOKEN: $(CodeCovToken)
        displayName: Upload coverage to CodeCov

@felixfbecker
Thanks for sharing.
The branch however needs to be different for pull requests, and ${{ parameters.name }} appears to be something custom on your side?
Docs ref: https://docs.microsoft.com/en-us/azure/devops/pipelines/migrate/from-travis?view=azure-devops#predefined-variables
Also passing in the PR via -P (and not VCS_PULL_REQUEST) does not trigger the fixing for merge commits (https://github.com/codecov/codecov-bash/blob/4678d212cce2078bbaaf5027af0c0dafaad6a095/codecov#L765).
On/via GitHub it is also System.PullRequest.PullRequestNumber (instead of System.PullRequest.PullRequestId).
(for reference: taken as base for https://github.com/pytest-dev/pytest/pull/5403)

Good points. Yes the name is a template parameter, but that one is optional.
Even more arguments why this should be built-in.
Do you have an example for a perfect config?

The codecov part from https://github.com/pytest-dev/pytest/pull/5403 appears to work - currently debugging why coverage is missing for some files (also on Travis though; likely an issue with coverage-combine, so not really related).

@felixfbecker
It is built in already (https://github.com/codecov/codecov-bash/pull/158).

But that PR is not merged yet?

https://github.com/codecov/codecov-bash/issues/171#issuecomment-498957892

Closing what I believe is a stale issue, since uploading from Azure currently works.


Adding support for named placeholders in functions

When the last argument is an array, strtr will be used instead of vsprintf for all the functions __(), n__(), etc.
This allow using named placeholders, e.g.
__('Hello %name%', ['%name' => 'world'])
Existing syntax using vsprintf is preserved, e.g.
__('Hello %s', 'world')
Fix #138
Notes:

I explicitly added $args to the function declaration to avoid calling func_num_args() if not necessary. It is marginally faster.
I didn't find existing tests for all the *gettext methods/functions so I added a bunch.

I changed the functions and added tests for "0" and "null".

Good job. Thank you!


fix: Update upm branch generation

:tada: This PR is included in version 2.0.1 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


circleRating & date added

#391  Rating and Date
Closes: #391
Description of Changes
I am added new feature to handle the rating of movie in circularRating with color, based on average like red for below 5 rating orange for greater that 5 and green for below the 7 rating, and also  added date on movie card.
Checklist:

[x] My code adheres to the established style guidelines of this project.
[x] I have conducted a self-review of my code.
[x] I have included comments in areas that may be difficult to understand.
[x] I have made corresponding updates to the project documentation.
[x] My changes have not introduced any new warnings.

Screenshots
|      Original       |       Updated        |
| | :------------------: |
|

|
Please provide any necessary screenshots to illustrate the changes made.

@sourabhsikarwar please review my PR .

Please resolve conflicts @BhartiNagpure

Please resolve conflicts @BhartiNagpure

@sourabhsikarwar  Resolve conflict

@sourabhsikarwar I am done with my work please review it.

Error in deployment
Failed to compile.
20:51:51.596 |
20:51:51.597 | [eslint]
20:51:51.597 | src/components/Carousel/Trending.jsx
20:51:51.597 | Syntax error: 'import' and 'export' may only appear at the top level. (18:0) (18:undefined)
20:51:51.597 |
20:51:51.597 |
20:51:51.653 | error Command failed with exit code 1.
20:51:51.653 | info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
20:51:51.674 | Error: Command "yarn run build" exited with 1


Svelte page has a link for webpack that does not link to the homepage of the project

Description
Svelte page has a link for webpack that does not link to the homepage of the project
...
Current behavior
links to some akward page
...
Expected behavior
link to the homepage of the project
...

Replace space in square bracket with x e.g [x]

[x] I have checked and this issue does not exist

Thanks @delight for taking the time to fix this.


CanvasRenderer using incorrect asset from spritesheet

I'm attempting to get pixi.js legacy canvas support working, but having an issue with this library. It seems to be ignoring the x,y position within the spritesheet and just displaying from 0,0.
Here is a slimmed down demo exhibiting the issue: https://codepen.io/jacobbijani/pen/XWMBdXr
Here is the code from that link just in case:
import * as PIXI from "https://cdn.skypack.dev/pixi.js-legacy";
import { CanvasTileRenderer, CompositeTilemap } from "https://cdn.skypack.dev/@pixi/tilemap";

if (!PIXI.utils.isWebGLSupported()) {
  console.log('no webgl, registering canvas plugin')
  PIXI.CanvasRenderer.registerPlugin('tilemap', CanvasTileRenderer);
}

// NOTE: `json` variable is defined in HTML tab

var app = new PIXI.Application({
    width: window.innerWidth,
    height: window.innerHeight,
    backgroundColor: 0x2c3e50
});
document.body.appendChild(app.view);

new PIXI.Spritesheet(PIXI.Texture.from('https://thinko-artifacts.s3.amazonaws.com/codepen/tiles-half.png'), json).parse((sheet) => {
  console.log('sheet loaded', sheet);

  const tilemap = new CompositeTilemap();
  app.stage.addChild(tilemap);

  tilemap.clear();
  tilemap.tile('vehicle-engine', 0, 0);
  tilemap.tile('vehicle-tractor', 0, 32);
});

In Chrome I see this, which is what is expected:

In Firefox, where I have webgl disabled, I see this:

The red dot is what is at 0,0 of my spritesheet.
Am I doing something wrong, or is this a bug?

OK, found bug, if you want to try fast fix, apply this to your @pixi/tilemap file in node_modules or where is it https://github.com/pixijs/tilemap/commit/7938df83d6ff7da591bb179d98c2d5cd67e8c602
also, you wont need to register canvas renderer after this

thanks for the prompt response! that does seem to work, but it seems i still need the registerPlugin call for it to work.
if I remove the PIXI.CanvasRenderer.registerPlugin('tilemap', CanvasTileRenderer); then I get a separate error I got prior as well:

when I inspect the breakpoint there, it seems my tileAnim is actually null. presumably since both this.tileAnim is null and renderer.plugins.tilemap.tileAnim is undefined.
perhaps registerPlugin is still just required? or maybe the tileAnim fallback a few lines up is missing something?

Anyway, its fixed in latest release, but still needs to register plugin

sounds good. when will it be published to npm?

it wasnt? Oh, I just have to call @ShukantPal again. I cant build new version for some reason :(

correct, on github and npm the latest version is still 3.2.0

@ShukantPal sorry to be annoying, but any update on publishing a new build to npm? hoping to get this integrated in my game upstream.
thanks!

I'll look into this today. Was gone on vacation.

https://github.com/pixijs/tilemap/releases/tag/v3.2.1


Add a link to Ansible Galaxy

Mention the availability of the collection in Ansible Galaxy in the README:
https://galaxy.ansible.com/ui/repo/published/infra/convert2rhel/

We can add a mention to that, but we have a whole paragraph for it already: https://github.com/redhat-cop/infra.convert2rhel?tab=readme-ov-file#installing-the-collection-from-ansible-galaxy
It is a guide how to install/use it through ansible galaxy

I think it'd be still worth it. E.g. Foreman links to it from their README https://github.com/theforeman/foreman-ansible-modules/?tab=readme-ov-file#installation-from-ansible-galaxy.
When were talking to solution architects today I wanted to send them a link to the Galaxy webpage. But all I had was a link to this github repo. It took me a while to find a link to Galaxy so I think it'd be handy to link to it from this repo for cases similar to the one I faced today.

It does make sense, indeed. Merged #40 that solves this.


build: add contrast exclusions

:tada: This PR is included in version 0.62.3 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Fix flick gesture with rotation. Fix #869

I wonder what we should do with panHorizontal/panVertical set to false when the viewport is rotated.

Ok for now, I just made panHorizontal/panVertical consistent with what happen on desktop.

Looks good... this works because the rotation is now factored into those viewport calls, right?

Yes!

@avandecreme Do you know if this issue was present in 2.1.0 or introduced since then? I'm wondering what to put in the change log.

It was introduced by my changes on rotation. I don't think it needs to be in the changelog.

Cool, thanks for confirming, and of course thanks for fixing!


feat(GroupTheory/SpecificGroups): define an isomorphism between a non-cyclic group of order 4 and the dihedral group of order 4

This was suggested in a comment on #7937.

I wasn't sure where to place this definition. I imagine further classification of finite groups of small order would probably justify a dedicated "Mathlib/GroupTheory/SpecificGroups/SmallOrder.lean".

A note on the final simp. I added (config := { decide := true }) because replacing it with (config := { decide := false }) would fail to close the goal, and if I'm understanding correctly, the forthcoming change (leanprover/lean4#2722) in Lean v4.4.0 would break the proof.

I have thoughts about this, please don't merge yet.

I've just opened #8565, which I think may be the way we actually want to go about this (it implements @jcommelin suggestion from #7937 in this comment). With #8565, the result in this PR can be obtained as follows:
import Mathlib.GroupTheory.SpecificGroups.KleinFour

variable {G : Type} [Group G] [Fintype G]

/-- A non-cyclic group of order 4 is isomorphic to the dihedral group of order 4. -/
noncomputable def mulEquivOfCardEqFourAndNotIsCyclic (h1 : Fintype.card G = 4) (h2 : ¬IsCyclic G) :
    DihedralGroup 2 ≃* G :=
  IsKleinFour.mulEquiv' ((Fintype.equivOfCardEq h1.symm : DihedralGroup 2 ≃ G).setValue 1 1)
    (by simp) <| (IsKleinFour.not_isCyclic_iff h1).mp h2

Thanks @j-loreaux . I might just move my def to KleinFour.lean once #8565 is merge.


Fix callback invocation for readline.question

Description of the change
I've made two small changes to what I think are bugs. The first bug prevents the question and question' functions from properly invoking the callback they receive, and the second is a small one-character typo in the options passed to createInterface

To fix the callback not being invoked, I created a EffectFn1 and passed that to the ffi impls. The previous code was passing a function that returned an Effect but never actually ran that effect.

Fixed typo in options passed to createInterface: s/crlDelay/crlfDelay/

Checklist:

[x] Added the change to the changelog's "Unreleased" section with a reference to this PR (e.g. "- Made a change (#0000)")
[x] Linked any existing issues or proposals that this pull request should close
[x] Updated or added relevant documentation
[x] Added a test for the contribution (if applicable)

Just a friendly ping for this patch to be merged.
Without it, the Readline functions question and question' (both
the Effect and the Aff versions) are useless: they just hang forever.


Update network setting when it is empty

Problem:
When the network-setting is reset to an empty value the configured status is still showing as true
Solution:
update the configured status according to the input NIC value
https://github.com/rancher/harvester-network-controller/issues/11

LGTM


WIP: Add new front-end documentation

Still adding content to this. Preliminary reviews are welcomed! 👍

Not sure how to review this.
But making sure you don't just hear crickets, like discussed in the detro friday.
Maybe walk through it together quickly in a call and then I can give some useful feedback?


Fix build of library on recent Cygwin editions

Without this fix you get the behavior in #144.

On the branch topic/PR-145-cygwin-fixes, tests cycling.

Also do you want a full CI environment (same that now exists on pool, ptr_container, format, uuid, ...?)

Why not, I have my internal CI on OSX/Linux/Win, and on Win only different versions of Visual. Cygwin might be good to have as well.

The point of putting CI here is to allow people to self-serve their own quality of pull requests and to reduce the amount of work it takes for your to qualify a change.
I pulled this PR and a CI PR into my fork:
https://github.com/jeking3/test/pull/1
Appveyor: https://ci.appveyor.com/project/jeking3/test/build/1.0.6-develop
Travis CI: https://travis-ci.org/jeking3/test/builds/394392360
I haven't looked into the failures yet.  Regardless, this particular fix (in this PR) is what I have used to resolve cygwin build issues in the repositories I maintain and in the CMT repositories.  In those, the definition is performed in the appveyor script so that Boost.Test builds.

You are referring to a CI that is well integrated to GitHub. In all cases, I am running my own tests on the feature branches before merging, the configuration is stable for some years. Said that, you are right that it is always extra work to add a new platform, and I thank you for the ones that you are currently deploying. Let me know once it is stable on your end.

Going back to the purpose of the PR: the diff of this is <target-os>cygwin:<define>_POSIX_C_SOURCE=201112L, while the configuration you have on your Appveyor is <target-os>cygwin:<define>_POSIX_C_SOURCE=2001112L. At the end, I am confused on which one to take, my CI is blind to this change, yours is not green

Hi again,
I would like to merge this branch asap. Would you please confirm which of the options is correct? 201112L or 2001112L ?

2001 is correct
On Thu, Jun 21, 2018, 7:05 PM Raffi Enficiaud<EMAIL_ADDRESS>wrote:

Hi again,
I would like to merge this branch asap. Would you please confirm which of
the options is correct? 201112L or 2001112L ?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/boostorg/test/pull/145#issuecomment-399270524, or mute
the thread
https://github.com/notifications/unsubscribe-auth/ALOdbcE9_8Qi_dbobWmAguBwa7H7jKlaks5t_CaagaJpZM4UF7i9
.

I just tried on a fresh install of cygwin, and with or without the patch, the code compiles without problem. Just wondering how to reproduce. Any hint?

Closing, merged to master/1.68.


MCs remain on stage in Adobe Animate CC

Hi,
I'm using Easel in Adobe Animate CC (formerly Flash). Every now and then I see a bug in the exported animation when a MovieClip placed on its own layer should appear at some point and then disappear (there are empty frames before and after) that once the clip appears it stays on the stage forever. It seems a bit inconsistent in that sometimes there are two similar layers and one works fine and the other not. Replacing empty frames with the symbol moved outside the visible area helps but it's just a workaround. Is this a known issue/feature? If not I can prepare a problematic .fla file for you. I suspect this might rather be a problem with Animate interpretation of the timeline not with Easel itself so please tell me if this is the right place to drop it.

Feel free to post an FLA


CodeChunk: incorrect auto-indentation after Python import statement

Incorrect indentation. When using python, I noticed that there is automatic, incorrect indentation after  import statements for Python e.g

But that does not seem to be a problem for the (limited) other statements I tried, or for JS import statements:

Closing as now fixed.


python: add geographiclib and update geopy

Motivation for this change
my first nixpkgs PR. Let me know if something should be different.
(1) added geographiclib from pip.
(2) updated geopy from 1.11 -> 1.18
(3) enabled python3 support for geopy
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[ ] NixOS
[ ] macOS
[x] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Assured whether relevant documentation is up to date
[ ] Fits CONTRIBUTING.md.

@MMesch Are you still intersted in pushing this forward? Looks like we could use this for #56826.

Nothing happening so closing.


How to Assign IP Address to Hyper V Hosted VM while VM Creation

I would like to assign IP Address to the OnPrem hyper V VM using DSC automation.  As I do want to run this to be happen in dynamic way. Then I thought of installing MMA on the VM to utilize the Hybridworker option. However since this VM does not have any IP, unable to configure MMA successfully. Second option tried to run LCM on this machine but it failed because of no IP Address. Third option is to assign the IP while creation of the VM  . As I am using image and I want to create 10 VMs with valid IPAddresses in the domain. what would be the best way to assign the IP address dynamically to the Onprem Hyper V vm .  Any insights would be greatly appreciated

Hi There @rsganta - are you using a DSC pull server in this environment? If not then you still should be able to cause the LCM on the target nodes to apply a DSC config. Even when an IP Address can't be set statically or obtained from a DHCP an automatic private IP Address (APIPA) is usually assigned on Windows 10 - which will allow you to apply the DSC config to the LCM in push mode.
Pull mode is another story - you would need a network connection for that.
Can you clarify what is stopping you applying the config to the VM in push mode?

Here is the flow as per my understanding.

I create a vm using powershell runbook (discussing on a different thread to rename before it starts)
Once It got renamed, my LCM runs to create a .MOF file.
In parallel to step 2, I have my configuration uploaded to azure using the renamed machined name and compile the job and assign node configuration.
My configuration has domainjoin,ipaddress,subnetmask and dns etc.
The problem with step 4 is, Since it is a private domain and assigning static IP. However when the IP got assigned  , network connection goes to unidentified network.   If I leave just with domain join(which has already valid IP from DHCP ), then rest of the things work.  But the problem is I fail to assign static ip, gateway,subnetmask and dns...


Add RunWithClient in truncate package in order to pass a client as an argument

Hello!
Thanks a lot for the incredible work on spanner-truncate.
While utilizing this code, I realized there are opportunities to enhance its convenience and usability as a package. I've made these small changes and would be really grateful if you could take a moment to look over this PR.
Background
I considered using the truncate package to implement data migration code, which includes truncating specific tables. While the Run method internally generates a client, I thought that reusing the same client for a series of processes would enhance efficiency and reduce overhead in the calling code.
Changes

Added the RunWithClient function. This change allows external callers to pass a Spanner client to the function.
Upgraded spanner library in order to use spanner.Client#DatabaseName.
Updated Readme to add description of RunWithClient.

Benefit
By enabling the caller to utilize the same client that may be used for subsequent database operations, it improves efficiency and reduce overhead in my opinion.
Before changes on this PR
// generates a client for a series of processes
client, err := NewSpannerClient(ctx, projectID, instanceID, databaseID)
if err != nil {
    return err
}

// truncate specific tables
// uses an internally generated client
if err := truncate.Run(ctx, projectID, instanceID, databaseID, false, os.Stdout, targetTables, excludeTables); err != nil {
    return err
}

// some follow-up database operations using the client
if err := followUpOperation(ctx, client); err != nil {
    return err
}

After changes on this PR
// generates a client for a series of processes
client, err := NewSpannerClient(ctx, projectID, instanceID, databaseID)
if err != nil {
    return err
}

// truncate specific tables
// uses an externally passed client
if err := truncate.RunWithClient(ctx, client, false, os.Stdout, targetTables, excludeTables); err != nil {
    return err
}

// some follow-up database operations using the client
if err := followUpOperation(ctx, client); err != nil {
    return err
}

v0.1.2 was tagged. Go package will be updated soon: https://pkg.go.dev/github.com/cloudspannerecosystem/spanner-truncate/truncate

Now it's available<EMAIL_ADDRESS>


Promote from preprod to prod

Auto generated by concourse:
Promote from preprod to prod

Do not merge until Monday afternoon after PM go ahead


Add support for 1.19

Hope this gets updated soon! This mod is a must-have xD

36276e59a3bc461570f640a2ef0817eb59905785

Thank you so much!

Thank you! 👍


🤔 [ISSUE] - @eazychart-[react & vue] - Points not centered in the LineColumnChart

Description
It's seems that the points of the line are not centered in the columns. (See screenshot)
Reproduction steps

Run yarn storybook
Click on 'Line Column' under 'Column Chart'

Screenshots

Done !

Hy @marrouchi, I couldn,t install the eazychart on my local system as it couldn.t find the specified files.

Please Help me out.

@i-m-karanagarwal  Hi, did you clone the project with the command this way ?
git clone https://github.com/Hexastack/eazychart.git

Yes the same command. I followed the instruction given in https://github.com/Hexastack/eazychart#installation-1.

Those instructions are for developers who are going to use the library. But you want to contribute in it, right ? So please refer to the contributer section in the main README.md file, fork this project on github and then clone it locally. You can follow this document to learn how to contribute on github : https://docs.github.com/en/get-started/quickstart/contributing-to-projects

You are referring to this one installation guide right?

As it is under the contribution guide, I followed the same instructions.

Yes, did you install yarn globally ? also could you do ls command into the folder ?

Yes Sure

Can you please specify your node and yarn version ?
yarn -v
node -v

Yes Sure

Can you switch to node v16 using NVM and retest ?
Node : v16.13.0
Yarn : 1.21.1

It seems to be an issue with Yarn https://github.com/yarnpkg/yarn/issues/3708
Please use the versions I specified in the previous message.

Thank You, It is working now.
Adding the required version in the contribution docs would be a great help.

Can you open a new issue for this please ?

I think this can be included with issue #59  .


Android Foreground notification not working.

I know the banner doesn't show by default when app is in the foreground but I'm not even getting my standard alert with json stringify data params.
when the app is closed the notification banner comes in but when I tap it no alert happening.
Works fine on ios but not android
I'm using cordova-android v8.0.0

Did you found the issue? If you share others can find the solution for the same issue later :)

@andrehtissot No I haven't yet I thought I did solve it by removing and re adding the android platform and the plugin because it worked but then when I try to do it again and implement my actual functionality it doesn't work on android in the foreground. works on ios in both foreground and background but not on android even when I tap it doesn't do nothing.

@andretissot you got any idea why this would be the case?

Would you kindly provide:

The android runtime log (adb logcat) of which you performed these actions, in sequence:
1.1. Booting the device *;
1.2. Starting the app;
1.3. Switching the app to the background, by opening another app;
1.4. Seeing the notification;
1.5. Tapping on the notification.

A Push payload example. Redacting the sensitive information, of course. But keeping the structure, keys and value types.

And after retrieving those, experiment with this special branch, of which I suggested in the comment https://github.com/andrehtissot/cordova-plugin-fcm-with-dependecy-updated/issues/35#issuecomment-610606389.

You might have been experiencing the same issue as https://github.com/andrehtissot/cordova-plugin-fcm-with-dependecy-updated/issues/35, of which I'm still investigating.
*If you are running the app in an emulator, make sure you are running from a image that contains Google Play or, for older android versions, Google API.

Here is the log of the app running note at the bottom where it says remove notification for unknown key
is where I tapped the notification.
2020-04-10 20:39:27.370 23010-23303/? D/FCMPlugin: ==> FCMPlugin execute: ready 2020-04-10 20:39:27.372 23010-23010/? D/SystemWebChromeClient<EMAIL_ADDRESS>Line 112 : FCMPlugin.js: is created 2020-04-10 20:39:27.372 23010-23010/? I/chromium: [INFO:CONSOLE(112)] "FCMPlugin.js: is created", source<EMAIL_ADDRESS>(112) 2020-04-10 20:39:27.396 23010-23010/? D/SystemWebChromeClient<EMAIL_ADDRESS>Line 112 : FCMPlugin Ready OK 2020-04-10 20:39:27.396 23010-23010/? I/chromium: [INFO:CONSOLE(112)] "FCMPlugin Ready OK", source<EMAIL_ADDRESS>(112) 2020-04-10 20:39:27.640 23010-23303/? D/FCMPlugin: ==> FCMPlugin execute: registerNotification 2020-04-10 20:42:50.587 23010-23303/? D/FCMPlugin: ==> FCMPlugin execute: registerNotification 2020-04-10 20:42:50.693 23010-23303/? D/FCMPlugin: ==> FCMPlugin execute: registerNotification 2020-04-10 20:42:50.868 23010-23303/? D/FCMPlugin: ==> FCMPlugin execute: registerNotification 2020-04-10 20:42:50.995 23010-23303/? D/FCMPlugin: ==> FCMPlugin execute: registerNotification 2020-04-10 20:43:00.688 23010-23303/? D/FCMPlugin: ==> FCMPlugin execute: registerNotification 2020-04-10 20:43:00.756 23010-23303/? D/FCMPlugin: ==> FCMPlugin execute: registerNotification 2020-04-10 20:43:00.920 23010-23303/? D/FCMPlugin: ==> FCMPlugin execute: registerNotification 2020-04-10 20:43:01.001 23010-23303/? D/FCMPlugin: ==> FCMPlugin execute: registerNotification 2020-04-10 20:43:11.618 23010-23303/? D/FCMPlugin: ==> FCMPlugin execute: getToken 2020-04-10 20:43:11.655 23010-23010/? I/FCMPlugin: 	Token: ddjIwAeG7Ng:APA91bHnpinB_4R79tQM3QutNnT1VorjzbZz_mKnsVQakUzbzMdxPG1126EIBznTpl8dvl7w4VF6NZN23m3kzUl7IXwXOuoTtT1qzYh6sqG8U1npaW1wj9RVK9uV8Lw6trhRX0V26c2q 2020-04-10 20:43:11.818 23010-23303/? D/FCMPlugin: ==> FCMPlugin execute: registerNotification 2020-04-10 20:43:11.985 23010-23303/? D/FCMPlugin: ==> FCMPlugin execute: registerNotification 2020-04-11 17:12:06.649 27596-27596/com.schoolspider.schoolspider D/FCMPlugin: ==> FCMPlugin initialize 2020-04-11 17:12:18.828 27596-27794/com.schoolspider.schoolspider D/FCMPlugin: ==> FCMPlugin execute: ready 2020-04-11 17:12:18.835 27596-27596/com.schoolspider.schoolspider D/SystemWebChromeClient<EMAIL_ADDRESS>Line 112 : FCMPlugin.js: is created 2020-04-11 17:12:18.836 27596-27596/com.schoolspider.schoolspider I/chromium: [INFO:CONSOLE(112)] "FCMPlugin.js: is created", source<EMAIL_ADDRESS>(112) 2020-04-11 17:12:18.871 27596-27596/com.schoolspider.schoolspider D/SystemWebChromeClient<EMAIL_ADDRESS>Line 112 : FCMPlugin Ready OK 2020-04-11 17:12:18.871 27596-27596/com.schoolspider.schoolspider I/chromium: [INFO:CONSOLE(112)] "FCMPlugin Ready OK", source<EMAIL_ADDRESS>(112) 2020-04-11 17:12:19.132 27596-27794/com.schoolspider.schoolspider D/FCMPlugin: ==> FCMPlugin execute: registerNotification 2020-04-11 17:12:53.305 27596-27794/com.schoolspider.schoolspider D/FCMPlugin: ==> FCMPlugin execute: registerNotification 2020-04-11 17:12:53.390 27596-27794/com.schoolspider.schoolspider D/FCMPlugin: ==> FCMPlugin execute: registerNotification 2020-04-11 17:13:51.597 27596-27794/com.schoolspider.schoolspider D/FCMPlugin: ==> FCMPlugin execute: ready 2020-04-11 17:13:51.619 27596-27794/com.schoolspider.schoolspider W/PluginManager: THREAD WARNING: exec() call to FCMPlugin.ready blocked the main thread for 23ms. Plugin should use CordovaInterface.getThreadPool(). 2020-04-11 17:13:51.623 27596-27596/com.schoolspider.schoolspider D/SystemWebChromeClient<EMAIL_ADDRESS>Line 112 : FCMPlugin.js: is created 2020-04-11 17:13:51.623 27596-27596/com.schoolspider.schoolspider I/chromium: [INFO:CONSOLE(112)] "FCMPlugin.js: is created", source<EMAIL_ADDRESS>(112) 2020-04-11 17:13:51.643 27596-27596/com.schoolspider.schoolspider D/SystemWebChromeClient<EMAIL_ADDRESS>Line 112 : FCMPlugin Ready OK 2020-04-11 17:13:51.643 27596-27596/com.schoolspider.schoolspider I/chromium: [INFO:CONSOLE(112)] "FCMPlugin Ready OK", source<EMAIL_ADDRESS>(112) 2020-04-11 17:13:52.374 27596-27794/com.schoolspider.schoolspider D/FCMPlugin: ==> FCMPlugin execute: registerNotification 2020-04-11 17:16:45.875 27596-27794/com.schoolspider.schoolspider D/FCMPlugin: ==> FCMPlugin execute: registerNotification 2020-04-11 17:16:46.037 27596-27794/com.schoolspider.schoolspider D/FCMPlugin: ==> FCMPlugin execute: registerNotification 2020-04-11 17:16:59.920 27596-31764/com.schoolspider.schoolspider W/FirebaseMessaging: Icon resource fcm_push_icon not found. Notification will use default icon. 2020-04-11 17:17:05.239 27596-31848/com.schoolspider.schoolspider W/FirebaseMessaging: Icon resource fcm_push_icon not found. Notification will use default icon. 2020-04-11 17:17:14.119 2079-2079/? W/NotificationEntryMgr: removeNotification for unknown key: 0|com.schoolspider.schoolspider|0|FCM-Notification:75646291|10088
my notification payload is as follows
{
"to":"'TOKEN_GOES_HERE",
"notification": {
                "title":"This a test notification title",
                "body":"This is the content of the notification",
                "badge": 1,
                "sound": "default"
            },
            "data": {
                "type" : "survey",
                "id" : "",
                "title":"This a test notification title",
                "body":"This is the content of the notification",
            }
            }

I did a filter on the logcat of fcm just so there wasnt too much noise

I just installed #35  as you suggested its working a lot better however still when the app is closed and then you tap a notification it still does nothing.
When the app is in the foreground and you pull down the notification tray and tap the notification then it does the desired action so it works as expected so its just when the app is closed it seems like its not sending the payload to the app.

@andrehtissot sorry for pestering just realised I wasn't passing the "click_action":"FCM_PLUGIN_ACTIVITY" with my notification payload. when I do that it all works I think as expected.

That's funny. You shouldn't be required to give "click_action", as the app, in the branch I suggested, should already be handling any push message in a background service alone.

Oh how interesting,
Yeah our old app uses the old phonegap push plugin and we dont have that click action specified in our old payload but that used gcm and apns directly.
Do you think it will be an easy fix? Let me know if I can help you in anyway, I dont know much about android/java but can help in other ways if you need even if its another pair of eyes.
Thanks again for making the plugin or at least maintaining the updated version of it

Of course. I really don't know why the "click_action" approach didn't work for you. As it does allow users to have other plugins or custom notification handling work more easily.
But having the background service approach improved and working as a fallback in case of "click_action" not being given, should easy enough.

I was investigating the issue reported until I found this thread https://stackoverflow.com/questions/37711082/how-to-handle-notification-when-app-in-background-in-firebase
Which reminded me of Android push behavior:

For "notification" payload:

When app is on background: The OS receives the payload, presents it, and on tapping, open the "click_action", or in lack of it, the main action;
When app is on foreground: the app background service receives the payload and decides what to do with it;

For "data" payload: The app's background service receives the payload and decides what to do with it;
For mixed ("notification" and "data") payload:

When app is on background: The OS receives the payload, presents it, and on tapping, open the "click_action", or in lack of it, the main action;
When app is on foreground: the app background service receives the payload and decides what to do with it;

Hence, as I have explained long time ago in https://github.com/andrehtissot/cordova-plugin-firebase-extended-notification/wiki/The-Three-Types-of-Notification-Playload, the only way to control the notification tapping action, as well to use more advanced notification options, is to only send "data" payloads.
Would that be possible in your case?

Ah okay,
So by my understanding keep the payload the same for sending to iOS as thats working but basically for android just use data only?
I will give this ago today and see where I get should I try this with a tagged version of your notification packages rather than the checked out branch one?
Another issue is that when I built this and tried to push to play store for beta testing I had it working on the emulator but then when I pushed  it didnt seem to work im not sure whether its something im doing in the build process or something else.
Thanks for investigating this.

So by my understanding keep the payload the same for sending to iOS as thats working but basically for android just use data only?

If you want to have the manual control of how notifications are displayed, data messages are the only real way.
If you want to keep the payload the same, you can have the "click_action" there to act when the app is not in the foreground.

I will give this ago today and see where I get should I try this with a tagged version of your notification packages rather than the checked out branch one?

I'll see how I'll integrate the changes from the experimental branch to a release.

Another issue is that when I built this and tried to push to play store for beta testing I had it working on the emulator but then when I pushed it didnt seem to work im not sure whether its something im doing in the build process or something else.

As long as the same google services configuration file is in the right paths, the signed release build should just work.
If you like, I can take a look in the published app's initialisation adb logs.

@andrehtissot I don't really need custom display info. I just need the basic notification display and it to be tappable and when its tapped certain data params are passed so I can navigate to the specific resource in my app.
Then in the foreground I display a toast like notification with a view button so they can choose to view it or not within the app.
I will try again later or tomorrow and see if I can get the thing working as expected. I have your extended notification plugin and will see what that entails for android, as for iOS my functionality is working perfectly so don't wanna change it if I can help it.

If you like, I can take a look in the published app's initialisation adb logs.

that might actually be helpful if I get any more issues with a deployment.

@andrehtissot I don't really need custom display info. I just need the basic notification display and it to be tappable and when its tapped certain data params are passed so I can navigate to the specific resource in my app.

Then, recommend you get back to the latest release, continue to send the payload with "click_action":"FCM_PLUGIN_ACTIVITY".

Then in the foreground I display a toast like notification with a view button so they can choose to view it or not within the app.

When the app is on the foreground, as the push payload is mixed, you'll get as part of the data, the notification title and body.*
With the data that you should receive just as the payload reaches the app, you can show the toast notification as you prefer.

I will try again later or tomorrow and see if I can get the thing working as expected. I have your extended notification plugin and will see what that entails for android, as for iOS my functionality is working perfectly so don't wanna change it if I can help it.

The extended notification plugin goes to the other way, as it requires the payloads to be data-only and draws the notifications itself, as a background service.

If you like, I can take a look in the published app's initialisation adb logs.

that might actually be helpful if I get any more issues with a deployment.

On Android, there should be no reason to act differently in a local build or a signed one.
Please re-open this issue or create more specific ones if you get into problems, I'll be happy to help.

@andrehtissot i'm not sure if background notification is working correctly as its not giving me an alert when I tap the notification even with it the click action defined.

It shouldn't give you an alert on tapping, but just return to FCMPlugin.onNotification.
I'd only alert, if you have wrote something like this in your app:
FCMPlugin.onNotification(function(data){
    alert(JSON.stringify(data))
});

If this doesn't work, please reopen the issue. If not I might not see your comment.

Thats exactly whats not working

Ok, I'll check

@andrehtissot im installing this on a fresh cordova app to see if its anything to do with my setup or other plugins. will let you know how it goes

@andrehtissot I just installed v4.6.4 and background tapping works with that but with click_action present in the payload.

Yes, the click_action is required in the payload.
I'll check why it stopped working since v4.6.4.

yeah I did it didn't work

Do you require iOS 9 support?

Could @smorris1709 create a hello world app, of which can be shared here on github? Of which you experience the same issue?

yeah ill see if it that works, I currently have a working version though now on v4.6.4. I am using the webpack plugin aswell and it didn't seem to be building properly.
so I removed the plugin readded it and replatformed then getting things as expected which enabled me to implement my functionality.
I will create it and get back to you on the latest version. and yeah I think I do require ios9 support

Well, for now v4.6.4 is the latest iOS 9 compatible.
But it's interesting to know that developers still to work with this constraint, given how old this version of iOS is.

Yeah okay thanks,
If it was up to me I would be on the latest and gratest but we have to support a lot of users that don't know what they are doing.
Our app was written in cordova a while ago before I started so have rewritten everything so im not even sure if I need to support it anymore but im gunna go out on a limb and say I have to for the time being anyway untill I can gather tthe data on the people using it and what os is being used.

@andrehtissot I think I may have figured out the source of the issue i'm having it might not be to do with the plugin at all.
I am using the cordova webpack plugin https://github.com/kotarella1110/cordova-plugin-webpack
when I do a cordova platform add my manifest file is like so
`

`
but then when I do a cordova run android -- --livereload
its changing the manifest file to this.
<?xml version='1.0' encoding='utf-8'?> <manifest android:hardwareAccelerated="true" android:versionCode="10000" android:versionName="1.0.0" package="com.app.app" xmlns:android="http://schemas.android.com/apk/res/android">     <supports-screens android:anyDensity="true" android:largeScreens="true" android:normalScreens="true" android:resizeable="true" android:smallScreens="true" android:xlargeScreens="true" />     <uses-permission android:name="android.permission.INTERNET" />     <application android:hardwareAccelerated="true" android:icon="@mipmap/ic_launcher" android:label="@string/app_name" android:supportsRtl="true" android:usesCleartextTraffic="true">         <activity android:configChanges="orientation|keyboardHidden|keyboard|screenSize|locale|smallestScreenSize|screenLayout|uiMode" android:label="@string/activity_name" android:launchMode="singleTop" android:name="MainActivity" android:theme="@android:style/Theme.DeviceDefault.NoActionBar" android:windowSoftInputMode="adjustResize">             <intent-filter android:label="@string/launcher_name">                 <action android:name="android.intent.action.MAIN" />                 <category android:name="android.intent.category.LAUNCHER" />             </intent-filter>         </activity>         <service android:name="com.gae.scaffolder.plugin.MyFirebaseMessagingService" android:stopWithTask="false">             <intent-filter>                 <action android:name="com.google.firebase.MESSAGING_EVENT" />             </intent-filter>         </service>         <meta-data android:name="com.google.firebase.messaging.default_notification_icon" android:resource="@mipmap/ic_launcher" />     </application> </manifest>

So when I have the below in my config.xml it seems to be overwriting the plugin xml code.
<edit-config file="AndroidManifest.xml" mode="merge" target="/manifest/application">             <application android:usesCleartextTraffic="true" />         </edit-config>
there is even an error
 Conflict found, edit-config changes from config.xml will overwrite plugin.xml changes

I understand the issue, but are you sure you want your traffic to not be encrypted?

I'm not familiar with this android stuff now its a bit out of my league don't really know what do, I need that setting in order to have live reload when I'm working on the app. but are you saying I shouldn't have this in production?
How come its having conflicts though is this some settings in your plugin?

iOS 9 now supported in version 6.2.0.

@andrehtissot Thanks 👍

Closed issue due to inactivity.


Add Interaction

@carmenlau @louischan-oursky If you have time, please review the interaction models and see if it makes sense to you.

Thanks Terry! Very clear now!

I suppose I'll add setup and authenticate action for each type of authenticators, i.e. 4 actions in total.

Merged to interaction branch.


Code for OMNIPARSER

Hi, thanks for the great work! I recently came across a paper, OMNIPARSER: A Unified Framework for Text Spotting, Key Information Extraction and Table Recognition, mentioning that the code is available in this repo, but I couldn't find it. Could you please let me know if it will be available soon?

Thank you for your attention. The code is being organized and is expected to be released within one or two weeks.

Thank you for your attention. The code is being organized and is expected to be released within one or two weeks.

Thanks for your prompt reply. It will be appreciate if you could ping me when the codes are released.


CalendarView leaking memory

The CalendarView object is leaking memory during scrolling. Specifically the CVCalendarMonthContentViewController is creating new scrollViews and new calendarViews when user scrolls through the calendar (month by month)

@jjjeeerrr111 Thank you, I'll need to look into that in more detail..

I can't reproduce this with the latest master. Can you please test it again?


Documentation: Expectations / constraints on folder structures and filenames

As I'm about to start implementing a RAWCooked workflow for our DPX sequences, I am aiming to write specifications for our folder structuring / DPX filenaming, to ensure we prepare our backlog media appropriately for RAWCooked, and to help us prepare appropriately for new scanning activity.
I checked the early Issues here to remind myself of the expectations / constraints, but I wonder if it would be useful to document those in the README, or elsewhere.
As I'm going to have to write them for internal use, I would offer myself as a drafter of such a thing, but I would need input from active users, to make sure I have undesrtoiod correctly, and fix my errors.
If this sounds useful, I can start a Google Doc and share the editable link here?
Stephen

I think it could be useful.
On our side we started a doc at https://github.com/MediaArea/RAWcooked/blob/master/Doc/User_Manual.md, but as you see it is very small. It would be great if users expand it, IMO it is better that a user manual is written by users when possible, as they see more the issues.
If you prefer a standalone document about your specific practice, it would be great to add it as another file at https://github.com/MediaArea/RAWcooked/tree/master/Doc , so it will be delivered to all users.

I think it could be useful.

I second it.

You guys are the best.

OK I added some stuff in https://github.com/MediaArea/RAWcooked/blob/master/Doc/User_Manual.md with a pull request. It may be too detailed, and it probably has misunderstandings too - please correct it!

Closing the ticket as there was a corresponding PR, but don't hesitate to open new issues or PR if you have more ideas about documentation, the project is intended to be collaborative, especially on the doc.


The circle behind the watch face is missing and is not colored correctly in dark mode

#91605
#101480

flutter doctor -v
[✓] Flutter (Channel master, 3.9.0-1.0.pre.161, on Microsoft Windows [Version 10.0.22621.1344], locale ru-UA)
    • Flutter version 3.9.0-1.0.pre.161 on channel master at C:\Flutter-SDK\flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision f9ad42a32d (20 hours ago), 2023-03-11 03:32:04 +0000
    • Engine revision e9ca7b2c45
    • Dart version 3.0.0 (build 3.0.0-313.0.dev)
    • DevTools version 2.22.2

[✓] Windows Version (Installed version of Windows is version 10 or higher)

[✓] Android toolchain - develop for Android devices (Android SDK version 32.1.0-rc1)
    • Android SDK at C:\Users\yablo\AppData\Local\Android\sdk
    • Platform android-TiramisuPrivacySandbox, build-tools 32.1.0-rc1
    • Java binary at: C:\Program Files\Android\Android Studio\jbr\bin\java
    • Java version OpenJDK Runtime Environment (build 11.0.15+0-b2043.56-9505619)
    • All Android licenses accepted.

[✓] Chrome - develop for the web
    • Chrome at C:\Program Files\Google\Chrome\Application\chrome.exe

[✓] Visual Studio - develop for Windows (Visual Studio Community 2022 17.4.5)
    • Visual Studio at C:\Program Files\Microsoft Visual Studio\2022\Community
    • Visual Studio Community 2022 version 17.4.33403.182
    • Windows 10 SDK version 10.0.22000.0

[✓] Android Studio (version 2022.1)
    • Android Studio at C:\Program Files\Android\Android Studio
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.15+0-b2043.56-9505619)

[✓] IntelliJ IDEA Community Edition (version 2022.3)
    • IntelliJ at C:\Program Files\JetBrains\IntelliJ IDEA Community Edition 2021.2.1
    • Flutter plugin version 72.0.4
    • Dart plugin version 223.8617.8

[✓] VS Code (version 1.76.1)
    • VS Code at C:\Users\yablo\AppData\Local\Programs\Microsoft VS Code
    • Flutter extension version 3.60.0

[✓] Connected device (3 available)
    • Windows (desktop) • windows • windows-x64    • Microsoft Windows [Version 10.0.22621.1344]
    • Chrome (web)      • chrome  • web-javascript • Google Chrome 110.0.5481.180
    • Edge (web)        • edge    • web-javascript • Microsoft Edge 110.0.1587.69

[✓] Network resources
    • All expected network resources are available.

• No issues found!

Hi @MaxYablochkin
I see there's an open issue addressing the case you described https://github.com/flutter/flutter/issues/118657
Please follow up on that issue, I'm closing the current one as a duplicate.
If you disagree, please write in the comments and I will reopen it.
Thank you

Thank @exaby73


Encourage people to upload themes somewhere ?

I've been using powerline shell for ages, and it's great.
However I'm a bit bored of the default theme, and not keen on any others.
It would be great if the readme had a link to somewhere people could upload and show off their own.
(and then I'd have somewhere to find someones that I liked)

I do like this idea - do you have suggestions how this should work? The first thing that comes to mind is a separate repo that is just a listing of themes with screenshots.

That's probably the most straightforward way.
I've definitely seen something similar from another project, I just can't remember which project it was though :/

I know that pelican does it: https://github.com/getpelican/pelican-themes
They built a site from this after the fact. Seems like this would work since people can just make a PR for it.
I like this idea - I'll make it happen.

Some more examples of console based colour themes for various things
http://vimcolors.com/
http://colorswat.ch/vim/
https://emacsthemes.com/
https://github.com/lukesampson/concfg/blob/master/preset_examples/README.md

Some more examples of console based colour themes for various things
http://vimcolors.com/
http://colorswat.ch/vim/
https://emacsthemes.com/
https://github.com/lukesampson/concfg/blob/master/preset_examples/README.md
https://github.com/robbyrussell/oh-my-zsh/wiki/External-themes

Hey, any updates on this?


Refactor to use error returns

Closes #69

Codecov Report

Merging #76 into master will decrease coverage by 4.14%.
The diff coverage is 31.14%.

@@            Coverage Diff             @@
##           master      #76      +/-   ##
==========================================
- Coverage   75.07%   70.93%   -4.15%
==========================================
  Files           5        5
  Lines         321      344      +23
==========================================
+ Hits          241      244       +3
- Misses         61       78      +17
- Partials       19       22       +3

Impacted Files
Coverage Δ

main.go
0% <0%> (ø)
:arrow_up:

job/job_windows.go
68.18% <0%> (ø)
:arrow_up:

run/run.go
89.6% <100%> (ø)
:arrow_up:

args.go
61.79% <38.29%> (-3.45%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1541313...1f2cc34. Read the comment docs.


V0.7.7

All Submissions Basics:

[ ] Have you followed the guidelines in our Contributing document?
[ ] Have you checked to ensure there aren't other open Pull Requests for the same update/change?
[ ] Have you checked all Issues to tie the PR to a specific one?

All Submissions Cores:

[ ] Have you added an explanation of what your changes do and why you'd like us to include them?
[ ] Have you written new tests for your core changes, as applicable?
[ ] Have you successfully ran tests with your changes locally?
[ ] Does your submission pass tests, including CircleCI, Travis CI, and AppVeyor?
[ ] Does your submission have appropriate code coverage? The cutoff threshold is 95% by Coversall.

New Model Submissions:

[ ] Have you created a .py in ~/pyod/models/?
[ ] Have you created a _example.py in ~/examples/?
[ ] Have you created a test_.py in ~/pyod/test/?
[ ] Have you lint your code locally prior to submission?

Pull Request Test Coverage Report for Build 1269

37 of 37 (100.0%)  changed or added relevant lines in 4 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.1%) to 95.46%

Totals

Change from base Build 1256:
0.1%

Covered Lines:
8221

Relevant Lines:
8612

💛  - Coveralls


Release official gem?

Is there a reason this isn't on RubyGems?

It was a hackathon project, and isn't tested or very good at all really. It is not official. I would not suggest using it in a production environment, and it is not supported.

On Mar 18, 2016, at 10:07 PM, Stuart Olivera<EMAIL_ADDRESS>wrote:
Is there a reason this isn't on RubyGems?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub

What big issues are you seeing? I haven't tried this yet, but I'm looking to integrate Sparkpost as the mailer, and this gem conceptually does exactly what I need, and I'm happy to finish it up to get it to a relatively production ready level.

I honestly haven't looked at it in a year. I would imagine it has a number of issues. Biggest one would be no tests or missing functionality.
They have an API gem here https://github.com/SparkPost/ruby-sparkpost/blob/master/README.md and I would suggest putting that in your mailer class.
Sent from my iPhone

On Mar 19, 2016, at 3:55 PM, Stuart Olivera<EMAIL_ADDRESS>wrote:
What big issues are you seeing? I haven't tried this yet, but I'm looking to integrate Sparkpost as the mailer, and this gem conceptually does exactly what I need, and I'm happy to finish it up to get it to a relatively production ready level.
—
You are receiving this because you commented.
Reply to this email directly or view it on GitHub

@sman591 it looks like @dgoerlich is going to take over development of this, add some tests, and get an a RubyGems release out, so your hopes may yet be answered :wink:

Awesome! I'll keep an eye out

@kevinkimball  has been gracious enough to allow The Refinery to pick up ongoing development on this gem.  We are compiling the list of things we need and want to add / enhance / improve, and identifying the mission critical ones to getting it to a production-ready 1.0.0 release.  Kevin put together an excellent start, and we are excited to take the hand-off and keep running with it.

It's official!  A version 1.0.1 is on RubyGems, complete with a test suite too.
https://rubygems.org/gems/sparkpost_rails


Unable to get environnement variable

Describe the bug
Unable to get environment variable to connect to Firebase in getServiceAccount function in the Factory bacause of the getEnv() function
To Reproduce
/config/packages/firebase.yaml
kreait_firebase:
    projects:
        first:
            public: true
            default: false
            credentials: '%kernel.project_dir%/firebase_credentials.json'
            database_uri: 'https://firebaseurl-id.firebaseio.com'

.env.local
FIREBASE_CREDENTIALS=/var/www/project/firebase_credentials.json

Firebase Test Manager
<?php

namespace App\Service;

use Google\Cloud\Firestore\FirestoreClient;
use Kreait\Firebase\Factory;
use Kreait\Firebase\Firestore;

final class FirestoreTest
{
    private Factory $factory;
    private Firestore $firestore;
    private FirestoreClient $database;

    public function __construct(Factory $factory)
    {
        $this->factory   = $factory;
        $this->firestore = $this->factory->createFirestore();;
        $this->database  = $this->firestore->database();
    }

    public function test(): void
    {
        $collection = $this->database->collection("cities");
        $document = $collection->document("paris");

        $document->set(["field" => "test"]);
    }
}

Expected behavior
In theory, my resource must be created in my firestore.
Screenshots

Environment (please complete the following information):

OS: Ubuntu 18.04
PHP version: 7.4.5
google/cloud-firestore: 1.8
grpc/grpc: 1.27
kreait/firebase-bundle: 2.0
kreait/firebase-php: 5.2

Additional context
I have found this issue and I think it's connected https://github.com/symfony/recipes/issues/532
My Workaround
I have create my own factory and extended Kreait\Firebase\Factory to use $_ENV and $_SERVER and use it.
<?php

namespace App\Firebase\Service;

use Kreait\Firebase\Factory as BaseFactory;
use Kreait\Firebase\ServiceAccount;

final class Factory extends BaseFactory
{
    const ENV_VAR_NAME = "FIREBASE_CREDENTIALS";

    protected function getServiceAccount(): ?ServiceAccount
    {
        if ($this->serviceAccount)
            return $this->serviceAccount;

        if ($credentials = $_ENV[static::ENV_VAR_NAME] ?? $_SERVER[static::ENV_VAR_NAME])
            return $this->serviceAccount = ServiceAccount::fromValue($credentials);

        return parent::getServiceAccount();
    }
}

So what to you think of my workaround ? Can I risk something ? And can you use $_ENV and $_SERVER in your Factory to avoid this workaround ?

In the config I think it should be possible to write
credentials: '%env(FIREBASE_CREDENTIALS)%'

Could you try if this works? I know it doesn't resolve the getenv() issue, but it should resolve the problem within a Symfony application.

Hello thanks for your reply !
I just tried and unfortunately I got the same error ... But it would be great if it could work!

@Shifu33 Sorry for the long wait - could you please check if using "kreait/firebase-php": "dev-master" improves the situation? You can find the changes here: https://github.com/kreait/firebase-php/commit/8b8e5272cb86e4b4844671dca32950ab7d1753ec
If it helps, I will create a new release shortly 🤞

Hey @jeromegamez thank you very much for the fix, it worked perfectly ... You can add it on the next release and I waiting for it !

Here it is 🥳 5.3.0


updated Comments add-on-portainer

Description

[ ] I have raised an issue to propose this change, which has been given a label of design/approved by a maintainer (required)

How Has This Been Tested?

Are you a GitHub Sponsor (Yes/No?)

[ ] Yes
[ ] No

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Documentation

[ ] I have updated the list of tools in README.md if (required) with ./arkade get -o markdown
[ ] I have updated the list of apps in README.md if (required) with ./arkade install --help

Checklist:

[x] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[x] I've read the CONTRIBUTION guide
[x] I have signed-off my commits with git commit -s
[ ] I have added tests to cover my changes.
[ ] All new and existing tests passed.

[x] I have tested this on arm, or have added code to prevent deployment

Hi @srebala thanks for your interest. We prefer to keep arkade apps simple, and you didn't propose this change in an issue, which is required for us to consider an idea / request.
Regards,
Alex

Let's get this closed, and feel free to raise an issue if you have a reason for adding these extra options.
We're also looking for someone to update the Portainer app to use their helm chart.


getObjectsAtLocation for images?

I was wondering if there was a group.getObjectsAtLocation for images? Seems it wouldn't be to far out of the way to make it retrieve any display object and not just sprites.

Silly me, the docs say images are "a light-weight object you can use to display anything that doesn't need physics or animation."


Create vegetables.dart

Adding new page called vegetables

The page for fruits and vegetables is already there

And first you should raise issue