Sm/error json

What does this PR do?
error structure for push/pull matches toolbelt (well, mostly).
intentional exceptions

commandName changes
use absolute rather than relative paths (match deploy, retrieve, etc)

What issues does this PR fix or reference?
@W-10830392@
@W-10809263@
https://github.com/forcedotcom/cli/issues/1431

QA Notes
🟡 push and pull are not listed in the topic help when running sfdx force:source
sfdx force:source
sync your project with your orgs

USAGE
    $ sfdx force:source:COMMAND

TOPICS
    force:source:beta      new versions of source tracking commands
    force:source:deploy    interact with an active deploy request
    force:source:ignored   check your local project package directories for forceignored files
    force:source:legacy    backwards compatible support for the original version of tracking commands. Use only while transitioning to the new commands
    force:source:manifest  create a manifest to use in a deploy/retrieve

COMMANDS
    force:source:convert   convert source into Metadata API format
    force:source:delete    delete source from your project and from a non-source-tracked org
    force:source:deploy    deploy source to an org
    force:source:open      edit a Lightning Page with Lightning App Builder
    force:source:retrieve  retrieve source from an org

🔴 Contract changed on pull with no changes
toolbelt
{
    "status": 0,
    "result": {
        "pulledSource": []
    }
}

plugin-source
{
    "status": 0,
    "result": []
}

🟢 Absolute paths are being used as described
"/Users/ewillhoit/dev/sandbox/org--dreamhouse-plugin-source/force-app/main/default/applications/Dreamhouse.app-meta.xml"

🟡 pushedSource[].state is different when pushing (Add vs Created)
toolbelt

Uses "state": "Add",

plugin-source

Uses "state": "Created",

🟡 pushedSource[].fullname is occasionally different. toolbelt uses dir/file format. plugin-source uses dir. Example using dreamhouse:
toolbelt
{
    "state": "Add",
    "fullName": "pageTemplate_2_7_3/pageTemplate_2_7_3.cmp",
    "type": "AuraDefinitionBundle",
    "filePath": "force-app/main/default/aura/pageTemplate_2_7_3/pageTemplate_2_7_3.cmp"
}

plugin-source
{
    "state": "Created",
    "fullName": "pageTemplate_2_7_3",
    "type": "AuraDefinitionBundle",
    "filePath": "/Users/ewillhoit/dev/sandbox/org--dreamhouse-plugin-source/force-app/main/default/aura/pageTemplate_2_7_3/pageTemplate_2_7_3.cmp"
}

🟢 Contract on push the same when there is nothing to push
🔴 Contract changed on pull!
toolbelt

result is an object with pulledSource array
"Layout" was pulled

{
    "status": 0,
    "result": {
    "pulledSource": [
        {
            "state": "Add",
            "fullName": "CO_Toolbelt__c",
            "type": "CustomObject",
            "filePath": "force-app/main/default/objects/CO_Toolbelt__c/CO_Toolbelt__c.object-meta.xml"
        },
        {
            "state": "Add",
            "fullName": "CO_Toolbelt__c-CO_Toolbelt Layout",
            "type": "Layout",
            "filePath": "force-app/main/default/layouts/CO_Toolbelt__c-CO_Toolbelt Layout.layout-meta.xml"
        }
    ]
    }
}

plugin-source

result is an array, no pulledSource array.
"Layout" not pulled? 🤔

{
    "status": 0,
    "result": [
        {
            "state": "Created",
            "fullName": "CO_Plugin_Source__c",
            "type": "CustomObject",
            "filePath": "/Users/ewillhoit/dev/sandbox/org--dreamhouse-plugin-source/force-app/main/default/objects/CO_Plugin_Source__c/CO_Plugin_Source__c.object-meta.xml"
        }
    ]
}

🟢 Contract the same on push for a locally created object
🔴 Contract different on push of invalid Custom Object
toolbelt
{
    "status": 1,
    "result": [
    {
        "error": "Must specify a non-empty label for the CustomObject",
        "fullName": "CO_Toolbelt_local__c",
        "type": "CustomObject",
        "filePath": "force-app/main/default/objects/CO_Toolbelt_local__c/CO_Toolbelt_local__c.object-meta.xml",
        "problemType": "Error"
    }
    ],
    "name": "DeployFailed",
    "message": "Push failed.",
    "exitCode": 1,
    "actions": [],
    "commandName": "SourcePushCommand",
    "data": [
    {
        "error": "Must specify a non-empty label for the CustomObject",
        "fullName": "CO_Toolbelt_local__c",
        "type": "CustomObject",
        "filePath": "force-app/main/default/objects/CO_Toolbelt_local__c/CO_Toolbelt_local__c.object-meta.xml",
        "problemType": "Error"
    }
    ],
    "stack": "DeployFailed: Push failed.\n    at /Users/ewillhoit/.nvm/versions/node/v14.17.5/lib/node_modules/sfdx-cli/node_modules/salesforce-alm/dist/lib/source/sourceApiCommand.js:71:31\n    at async SourcePushCommand.execLegacyCommand (/Users/ewillhoit/.nvm/versions/node/v14.17.5/lib/node_modules/sfdx-cli/node_modules/salesforce-alm/dist/ToolbeltCommand.js:149:29)\n    at async SourcePushCommand.run (/Users/ewillhoit/.nvm/versions/node/v14.17.5/lib/node_modules/sfdx-cli/node_modules/salesforce-alm/dist/commands/force/source/legacy/push.js:37:16)\n    at async SourcePushCommand._run (/Users/ewillhoit/.nvm/versions/node/v14.17.5/lib/node_modules/sfdx-cli/node_modules/@salesforce/command/lib/sfdxCommand.js:81:40)\n    at async Config.runCommand (/Users/ewillhoit/.nvm/versions/node/v14.17.5/lib/node_modules/sfdx-cli/node_modules/@oclif/config/lib/config.js:173:24)\n    at async SfdxMain.run (/Users/ewillhoit/.nvm/versions/node/v14.17.5/lib/node_modules/sfdx-cli/node_modules/@oclif/command/lib/main.js:27:9)\n    at async SfdxMain._run (/Users/ewillhoit/.nvm/versions/node/v14.17.5/lib/node_modules/sfdx-cli/node_modules/@oclif/command/lib/command.js:43:20)\n    at async Object.run (/Users/ewillhoit/.nvm/versions/node/v14.17.5/lib/node_modules/sfdx-cli/dist/cli.js:162:47)",
    "warnings": []
}

plugin-source

No result array
No actions array
No data array

{
    "status": 1,
    "name": "TypeInferenceError",
    "message": "Unexpected child metadata [force-app/main/default/objects/CO_Plugin_Source_local_BAD__c/CO_Plugin_Source_local__c.object-meta.xml] found for parent type [CustomObject]",
    "exitCode": 1,
    "commandName": "Push",
    "stack": "TypeInferenceError: Unexpected child metadata [force-app/main/default/objects/CO_Plugin_Source_local_BAD__c/CO_Plugin_Source_local__c.object-meta.xml] found for parent type [CustomObject]\n    at DecomposedSourceAdapter.populate (/Users/ewillhoit/dev/plugin-source/node_modules/@salesforce/source-tracking/node_modules/@salesforce/source-deploy-retrieve/src/resolve/adapters/decomposedSourceAdapter.ts:115:17)\n    at DecomposedSourceAdapter.getComponent (/Users/ewillhoit/dev/plugin-source/node_modules/@salesforce/source-tracking/node_modules/@salesforce/source-deploy-retrieve/src/resolve/adapters/decomposedSourceAdapter.ts:70:17)\n    at MetadataResolver.resolveComponent (/Users/ewillhoit/dev/plugin-source/node_modules/@salesforce/source-tracking/node_modules/@salesforce/source-deploy-retrieve/src/resolve/metadataResolver.ts:138:38)\n    at MetadataResolver.getComponentsFromPathRecursive (/Users/ewillhoit/dev/plugin-source/node_modules/@salesforce/source-tracking/node_modules/@salesforce/source-deploy-retrieve/src/resolve/metadataResolver.ts:92:32)\n    at MetadataResolver.getComponentsFromPathRecursive (/Users/ewillhoit/dev/plugin-source/node_modules/@salesforce/source-tracking/node_modules/@salesforce/source-deploy-retrieve/src/resolve/metadataResolver.ts:115:31)\n    at MetadataResolver.getComponentsFromPathRecursive (/Users/ewillhoit/dev/plugin-source/node_modules/@salesforce/source-tracking/node_modules/@salesforce/source-deploy-retrieve/src/resolve/metadataResolver.ts:115:31)\n    at MetadataResolver.getComponentsFromPathRecursive (/Users/ewillhoit/dev/plugin-source/node_modules/@salesforce/source-tracking/node_modules/@salesforce/source-deploy-retrieve/src/resolve/metadataResolver.ts:115:31)\n    at MetadataResolver.getComponentsFromPathRecursive (/Users/ewillhoit/dev/plugin-source/node_modules/@salesforce/source-tracking/node_modules/@salesforce/source-deploy-retrieve/src/resolve/metadataResolver.ts:115:31)\n    at MetadataResolver.getComponentsFromPath (/Users/ewillhoit/dev/plugin-source/node_modules/@salesforce/source-tracking/node_modules/@salesforce/source-deploy-retrieve/src/resolve/metadataResolver.ts:58:19)\n    at buildComponents (/Users/ewillhoit/dev/plugin-source/node_modules/@salesforce/source-tracking/node_modules/@salesforce/source-deploy-retrieve/src/collections/componentSet.ts:137:42)\n    at Function.fromSource (/Users/ewillhoit/dev/plugin-source/node_modules/@salesforce/source-tracking/node_modules/@salesforce/source-deploy-retrieve/src/collections/componentSet.ts:142:5)\n    at SourceTracking.populateFilePaths (/Users/ewillhoit/dev/plugin-source/node_modules/@salesforce/source-tracking/lib/sourceTracking.js:569:88)\n    at SourceTracking.getChanges (/Users/ewillhoit/dev/plugin-source/node_modules/@salesforce/source-tracking/lib/sourceTracking.js:198:29)\n    at async SourceTracking.getConflicts (/Users/ewillhoit/dev/plugin-source/node_modules/@salesforce/source-tracking/lib/sourceTracking.js:393:31)\n    at async Object.trackingSetup (/Users/ewillhoit/dev/plugin-source/src/trackingFunctions.ts:60:26)\n    at async Push.prechecks (/Users/ewillhoit/dev/plugin-source/src/commands/force/source/beta/push.ts:36:25)\nOuter stack:\n    at Function.wrap (/Users/ewillhoit/dev/plugin-source/node_modules/@salesforce/core/lib/sfdxError.js:171:27)\n    at Push.catch (/Users/ewillhoit/dev/plugin-source/node_modules/@salesforce/command/lib/sfdxCommand.js:248:67)\n    at async Push._run (/Users/ewillhoit/dev/plugin-source/node_modules/@salesforce/command/lib/sfdxCommand.js:85:13)\n    at async Config.runCommand (/Users/ewillhoit/.nvm/versions/node/v14.17.5/lib/node_modules/sfdx-cli/node_modules/@oclif/config/lib/config.js:173:24)\n    at async SfdxMain.run (/Users/ewillhoit/.nvm/versions/node/v14.17.5/lib/node_modules/sfdx-cli/node_modules/@oclif/command/lib/main.js:27:9)\n    at async SfdxMain._run (/Users/ewillhoit/.nvm/versions/node/v14.17.5/lib/node_modules/sfdx-cli/node_modules/@oclif/command/lib/command.js:43:20)\n    at async Object.run (/Users/ewillhoit/.nvm/versions/node/v14.17.5/lib/node_modules/sfdx-cli/dist/cli.js:162:47)",
    "warnings": []
}

QA Notes
🟡 push and pull are not listed in the topic help when running sfdx force:source
sfdx force:source
sync your project with your orgs

USAGE
    $ sfdx force:source:COMMAND

TOPICS
    force:source:beta      new versions of source tracking commands
    force:source:deploy    interact with an active deploy request
    force:source:ignored   check your local project package directories for forceignored files
    force:source:legacy    backwards compatible support for the original version of tracking commands. Use only while transitioning to the new commands
    force:source:manifest  create a manifest to use in a deploy/retrieve

COMMANDS
    force:source:convert   convert source into Metadata API format
    force:source:delete    delete source from your project and from a non-source-tracked org
    force:source:deploy    deploy source to an org
    force:source:open      edit a Lightning Page with Lightning App Builder
    force:source:retrieve  retrieve source from an org

🔴 Contract changed on pull with no changes
toolbelt
{
    "status": 0,
    "result": {
        "pulledSource": []
    }
}

plugin-source
{
    "status": 0,
    "result": []
}

🟢 Absolute paths are being used as described
"/Users/ewillhoit/dev/sandbox/org--dreamhouse-plugin-source/force-app/main/default/applications/Dreamhouse.app-meta.xml"

🟡 pushedSource[].state is different when pushing (Add vs Created)
toolbelt

Uses "state": "Add",

plugin-source

Uses "state": "Created",

🟡 pushedSource[].fullname is occasionally different. toolbelt uses dir/file format. plugin-source uses dir. Example using dreamhouse:
toolbelt
{
    "state": "Add",
    "fullName": "pageTemplate_2_7_3/pageTemplate_2_7_3.cmp",
    "type": "AuraDefinitionBundle",
    "filePath": "force-app/main/default/aura/pageTemplate_2_7_3/pageTemplate_2_7_3.cmp"
}

plugin-source
{
    "state": "Created",
    "fullName": "pageTemplate_2_7_3",
    "type": "AuraDefinitionBundle",
    "filePath": "/Users/ewillhoit/dev/sandbox/org--dreamhouse-plugin-source/force-app/main/default/aura/pageTemplate_2_7_3/pageTemplate_2_7_3.cmp"
}

🟢 Contract on push the same when there is nothing to push
🔴 Contract changed on pull!
toolbelt

result is an object with pulledSource array
"Layout" was pulled

{
    "status": 0,
    "result": {
    "pulledSource": [
        {
            "state": "Add",
            "fullName": "CO_Toolbelt__c",
            "type": "CustomObject",
            "filePath": "force-app/main/default/objects/CO_Toolbelt__c/CO_Toolbelt__c.object-meta.xml"
        },
        {
            "state": "Add",
            "fullName": "CO_Toolbelt__c-CO_Toolbelt Layout",
            "type": "Layout",
            "filePath": "force-app/main/default/layouts/CO_Toolbelt__c-CO_Toolbelt Layout.layout-meta.xml"
        }
    ]
    }
}

plugin-source

result is an array, no pulledSource array.
"Layout" not pulled? 🤔

{
    "status": 0,
    "result": [
        {
            "state": "Created",
            "fullName": "CO_Plugin_Source__c",
            "type": "CustomObject",
            "filePath": "/Users/ewillhoit/dev/sandbox/org--dreamhouse-plugin-source/force-app/main/default/objects/CO_Plugin_Source__c/CO_Plugin_Source__c.object-meta.xml"
        }
    ]
}

🟢 Contract the same on push for a locally created object
🔴 Contract different on push of invalid Custom Object
toolbelt
{
    "status": 1,
    "result": [
    {
        "error": "Must specify a non-empty label for the CustomObject",
        "fullName": "CO_Toolbelt_local__c",
        "type": "CustomObject",
        "filePath": "force-app/main/default/objects/CO_Toolbelt_local__c/CO_Toolbelt_local__c.object-meta.xml",
        "problemType": "Error"
    }
    ],
    "name": "DeployFailed",
    "message": "Push failed.",
    "exitCode": 1,
    "actions": [],
    "commandName": "SourcePushCommand",
    "data": [
    {
        "error": "Must specify a non-empty label for the CustomObject",
        "fullName": "CO_Toolbelt_local__c",
        "type": "CustomObject",
        "filePath": "force-app/main/default/objects/CO_Toolbelt_local__c/CO_Toolbelt_local__c.object-meta.xml",
        "problemType": "Error"
    }
    ],
    "stack": "DeployFailed: Push failed.\n    at /Users/ewillhoit/.nvm/versions/node/v14.17.5/lib/node_modules/sfdx-cli/node_modules/salesforce-alm/dist/lib/source/sourceApiCommand.js:71:31\n    at async SourcePushCommand.execLegacyCommand (/Users/ewillhoit/.nvm/versions/node/v14.17.5/lib/node_modules/sfdx-cli/node_modules/salesforce-alm/dist/ToolbeltCommand.js:149:29)\n    at async SourcePushCommand.run (/Users/ewillhoit/.nvm/versions/node/v14.17.5/lib/node_modules/sfdx-cli/node_modules/salesforce-alm/dist/commands/force/source/legacy/push.js:37:16)\n    at async SourcePushCommand._run (/Users/ewillhoit/.nvm/versions/node/v14.17.5/lib/node_modules/sfdx-cli/node_modules/@salesforce/command/lib/sfdxCommand.js:81:40)\n    at async Config.runCommand (/Users/ewillhoit/.nvm/versions/node/v14.17.5/lib/node_modules/sfdx-cli/node_modules/@oclif/config/lib/config.js:173:24)\n    at async SfdxMain.run (/Users/ewillhoit/.nvm/versions/node/v14.17.5/lib/node_modules/sfdx-cli/node_modules/@oclif/command/lib/main.js:27:9)\n    at async SfdxMain._run (/Users/ewillhoit/.nvm/versions/node/v14.17.5/lib/node_modules/sfdx-cli/node_modules/@oclif/command/lib/command.js:43:20)\n    at async Object.run (/Users/ewillhoit/.nvm/versions/node/v14.17.5/lib/node_modules/sfdx-cli/dist/cli.js:162:47)",
    "warnings": []
}

plugin-source

No result array
No actions array
No data array

{
    "status": 1,
    "name": "TypeInferenceError",
    "message": "Unexpected child metadata [force-app/main/default/objects/CO_Plugin_Source_local_BAD__c/CO_Plugin_Source_local__c.object-meta.xml] found for parent type [CustomObject]",
    "exitCode": 1,
    "commandName": "Push",
    "stack": "TypeInferenceError: Unexpected child metadata [force-app/main/default/objects/CO_Plugin_Source_local_BAD__c/CO_Plugin_Source_local__c.object-meta.xml] found for parent type [CustomObject]\n    at DecomposedSourceAdapter.populate (/Users/ewillhoit/dev/plugin-source/node_modules/@salesforce/source-tracking/node_modules/@salesforce/source-deploy-retrieve/src/resolve/adapters/decomposedSourceAdapter.ts:115:17)\n    at DecomposedSourceAdapter.getComponent (/Users/ewillhoit/dev/plugin-source/node_modules/@salesforce/source-tracking/node_modules/@salesforce/source-deploy-retrieve/src/resolve/adapters/decomposedSourceAdapter.ts:70:17)\n    at MetadataResolver.resolveComponent (/Users/ewillhoit/dev/plugin-source/node_modules/@salesforce/source-tracking/node_modules/@salesforce/source-deploy-retrieve/src/resolve/metadataResolver.ts:138:38)\n    at MetadataResolver.getComponentsFromPathRecursive (/Users/ewillhoit/dev/plugin-source/node_modules/@salesforce/source-tracking/node_modules/@salesforce/source-deploy-retrieve/src/resolve/metadataResolver.ts:92:32)\n    at MetadataResolver.getComponentsFromPathRecursive (/Users/ewillhoit/dev/plugin-source/node_modules/@salesforce/source-tracking/node_modules/@salesforce/source-deploy-retrieve/src/resolve/metadataResolver.ts:115:31)\n    at MetadataResolver.getComponentsFromPathRecursive (/Users/ewillhoit/dev/plugin-source/node_modules/@salesforce/source-tracking/node_modules/@salesforce/source-deploy-retrieve/src/resolve/metadataResolver.ts:115:31)\n    at MetadataResolver.getComponentsFromPathRecursive (/Users/ewillhoit/dev/plugin-source/node_modules/@salesforce/source-tracking/node_modules/@salesforce/source-deploy-retrieve/src/resolve/metadataResolver.ts:115:31)\n    at MetadataResolver.getComponentsFromPathRecursive (/Users/ewillhoit/dev/plugin-source/node_modules/@salesforce/source-tracking/node_modules/@salesforce/source-deploy-retrieve/src/resolve/metadataResolver.ts:115:31)\n    at MetadataResolver.getComponentsFromPath (/Users/ewillhoit/dev/plugin-source/node_modules/@salesforce/source-tracking/node_modules/@salesforce/source-deploy-retrieve/src/resolve/metadataResolver.ts:58:19)\n    at buildComponents (/Users/ewillhoit/dev/plugin-source/node_modules/@salesforce/source-tracking/node_modules/@salesforce/source-deploy-retrieve/src/collections/componentSet.ts:137:42)\n    at Function.fromSource (/Users/ewillhoit/dev/plugin-source/node_modules/@salesforce/source-tracking/node_modules/@salesforce/source-deploy-retrieve/src/collections/componentSet.ts:142:5)\n    at SourceTracking.populateFilePaths (/Users/ewillhoit/dev/plugin-source/node_modules/@salesforce/source-tracking/lib/sourceTracking.js:569:88)\n    at SourceTracking.getChanges (/Users/ewillhoit/dev/plugin-source/node_modules/@salesforce/source-tracking/lib/sourceTracking.js:198:29)\n    at async SourceTracking.getConflicts (/Users/ewillhoit/dev/plugin-source/node_modules/@salesforce/source-tracking/lib/sourceTracking.js:393:31)\n    at async Object.trackingSetup (/Users/ewillhoit/dev/plugin-source/src/trackingFunctions.ts:60:26)\n    at async Push.prechecks (/Users/ewillhoit/dev/plugin-source/src/commands/force/source/beta/push.ts:36:25)\nOuter stack:\n    at Function.wrap (/Users/ewillhoit/dev/plugin-source/node_modules/@salesforce/core/lib/sfdxError.js:171:27)\n    at Push.catch (/Users/ewillhoit/dev/plugin-source/node_modules/@salesforce/command/lib/sfdxCommand.js:248:67)\n    at async Push._run (/Users/ewillhoit/dev/plugin-source/node_modules/@salesforce/command/lib/sfdxCommand.js:85:13)\n    at async Config.runCommand (/Users/ewillhoit/.nvm/versions/node/v14.17.5/lib/node_modules/sfdx-cli/node_modules/@oclif/config/lib/config.js:173:24)\n    at async SfdxMain.run (/Users/ewillhoit/.nvm/versions/node/v14.17.5/lib/node_modules/sfdx-cli/node_modules/@oclif/command/lib/main.js:27:9)\n    at async SfdxMain._run (/Users/ewillhoit/.nvm/versions/node/v14.17.5/lib/node_modules/sfdx-cli/node_modules/@oclif/command/lib/command.js:43:20)\n    at async Object.run (/Users/ewillhoit/.nvm/versions/node/v14.17.5/lib/node_modules/sfdx-cli/dist/cli.js:162:47)",
    "warnings": []
}

Only thing that I didn't test was a failure on pull. I am not sure how to get that to fail. Any ideas?

Only thing that I didn't test was a failure on pull. I am not sure how to get that to fail. Any ideas?

You can get an error from conflicts (change something remote and something local and then try to pull)

🔴 Contract different on push of invalid Custom Object
That's an error from SDR, which occurs locally instead of sending bad objects to the server and getting back its response.  It's gonna be like other errors that happen outside of the deployment (ex: invalid flags, etc)

pushedSource[].fullname is occasionally different. toolbelt uses dir/file format. plugin-source uses dir.

Awesome, the conflict output now matches! Although, I did just notice that result.filePath and data.filePath are not absolute paths in plugin-source in the pull conflict json.


MyFirstOpenSourceContribution

Please review my changes.

Hi @WillRaezer! Is this still a work in progress?

Yes I'm kind of a beginner, I have a year or so of programming knowledge but still not where I want to be. My preferred domain would be audio and for my fall senior project this fall at American University will be with Unity in C#, but c++ is the golden nugget for serious audio systems. I figured contributing to open source on a reasonable project, would be a good stepping stone to working on something more substantial like Ardour. I'm used to Java OOP want to get into more serious c++ style OO. I'm not a huge fan of declaring methods in the header and then defining them elsewhere using the :: operator but I guess there's a good reason for this.
Anyway so I liked the list. I wanted to focus the selling mechanism, by creating getters in the player class to get the num items the player has. Then when we get the num items we can  --items as we sell them and coin++.  Is there reason we've got the vector data structure in addition to the vars for items? Also how does the adding of a "junk" type item sound? Junk tends to show up a lot in RPGs. I also want to see if this game could be played without the player attacking directly or some kind of passive system...

There's much discussion online on the merits of header-only libraries vs. header/source file separation, though AFAIK modern C++ projects lean towards the header-only camp. Turn was originally made a long time ago when header/source was the convention at the time, so that's why it has separate declarations.
IIRC item drops are represented as both vectors and individual vars in the code because enemies can drop multiple items in Enemy::GetDrops(), so I needed to a way to return multiple values. In hindsight item drops should probably be represented as a struct of some kind. Perhaps that's a change for the future.
Junk sounds like a cool idea, though I think some code rewrite is necessary in order to suppor that.
As for a passive system, that should be possible by adding some conditions in the main game loop. Though again, some code rewrite is necessary.

I requested some changes as it looks like the PR is unfinished, but good progress so far :+1:

Closed due to inactivity


pysam 'pysam.calignmentfile.AlignedSegment' error using speedseq sv -g

When using the genotyping -g parameter to speedseq sv (version cloned yesterday from github) there appears to be some type of pysam error during svtyper genotyping.  I have tried with pysam 0.8.3 and 0.11 (latest) and neither has fixed it.  I find that when using svtyper 0.1.3 to do this step manually, only the latter of the two versions will work.  Is there a specific version of pysam that is needed? any insights into this error?
Error:
'pysam.calignmentfile.AlignedSegment' object has no attribute 'reference_name'

I do agree that this is related to pysam. Do I understand correctly that using pysam v0.11.0 fixes the problem when running svtyper manually, but it does not fix the problem when running it through speedseq?
On a separate note, you should bump svtyper to v0.1.4 because it patches a small but potentially important issue with maximum sampling depth. The new version is already included in speedseq

Yes you understand correctly, I have the pysam 0.1.1 installed in its own anaconda env with the speedseq config pointing to this python install.  If I source activate this env and run svtyper 0.1.3 it will run without errors (including on the specific files produced from speeseq).

Thanks for the tip on the svtyper update! I want to note that running genotyping on its own works with svtyper 0.1.4 also, using pysam 0.1.1.  For now I will just proceed make individual genotyping jobs instead.
Related to this: The newest svtools commands such as lsort and lmerge seem not to work with pysam 0.8.3 but do work with 0.1.1, just wanted to point that out too, might be good to flag in your svtools repo.

Ok thanks for the additional info. I can't really think of a good explanation for why speedseq would fail with the updated pysam unless there is some other python environment variable directing it to a different pysam version.
lsort and lmerge do not require pysam at all, but will update the svtools requirements because SVTyper (which is included) needs 0.8.4 or higher. Thanks for pointing this out

Thanks for the feedback. I noticed the svtyper version in svtools genotype is 0.1.2, is this an issue? do you suggest genotyping all sets of calls using 1.4?

0.1.2 should be fine. The only difference between 0.1.2 and 0.1.4 is an optional command line argument flag.


YouTube Short for mobile

Make a video about push notifications on mobile.

@mishmanners this is a fantastic idea!

Got this working! 💯 yay, closing out now


Builds for Python>3.7

Comment:
There seem to only exist packages compiled for Python 3.7. That is quite restrictive and conda is moving to more recent versions by default.
Is there a plan to support more recent Python versions? Is there any constraint preventing that?

it may be that the original maintains had trouble making it.
You can give a try refreshing the recipe and ping people when it works or when you have trouble.

Currently Tomviz supports 3.7, we plan on testing/updating to > 3.7 in future, but this work hasn't been done yet. You are welcome to give it a try.

Some discussion on this happened in #50. Xref also https://github.com/OpenChemistry/tomviz/issues/2132


Updates getting_started_linux_cmake.md to reflect python dependency.

Fix for #1779.

Should also update the Windows docs. How about linking to https://www.python.org/downloads/windows/ there?

Updated!


Calculate the embeddings and save them as CSV

I am currently following these instructions https://github.com/openai/openai-cookbook/blob/main/examples/Question_answering_using_embeddings.ipynb with my own data. At the point about creating the embeddings it says:
document_embeddings = load_embeddings("https://cdn.openai.com/API/examples/data/olympics_sections_document_embeddings.csv")

# ===== OR, uncomment the below line to recaculate the embeddings from scratch. ========

# document_embeddings = compute_doc_embeddings(df)

With document_embeddings = compute_doc_embeddings(df) I successfully created the embeddings, but unfortunately the instructions don't tell me how to save them as a CSV file to get a file like the Olympics file so I can continue with the tutorial.
Could someone help me with this?

df.to_csv(filepath) will save the dataframe as a CSV.
df = pd.read_csv(filepath) will load the dataframe from a CSV.
filepath is a string.

Ah right, there's some extra formatting that needs to be done to save it in that particular format. Let me look this up. I think it's just one line, maybe two.

(Sorry that the notebook was not written in a more re-usable fashion  - this bit me last year too)

Something like this should work, I think: pd.DataFrame(document_embeddings).T.to_csv(filepath)

thx ted,
this works but the title and heading is missing in the csv file which leads to an error while loading the embeddings.
as i couldnt figure out how to set the title / heading before creating the csv.. i fixed it by setting the title / heading in the load embeddings function..
df = pd.read_csv(fname, header=0)
df = df.set_axis(['title', 'heading'] + list(df.columns[2:]), axis=1)

Thank you @ted-at-openai and @digitaldesaster - your comments above are exactly what I was looking for. Grateful!

Many thanks, @ted-at-openai and @digitaldesaster - this helped me a lot!

Hi, when I save the calculated embeddings with: pd.DataFrame(document_embeddings).T.to_csv(filepath)
I get the file with the index and vectors:
0,0.0031115561723709106,0.00018902790907304734,-0.00190595886670053,-0.029547588899731636,-0.022286130115389824,0.018968993797898293,-0.029436087235808372,-0.0378822386264801,-0.02245337888598442,-0.018146678805351257,0.02940821275115013,-0.020348811522126198,-0.009881717152893543,-0.008892151527106762 ........
but when I load the embeddings from file:
def load_embeddings(fname: str) -> dict[tuple[str, str], list[float]]:

    df = pd.read_csv(fname, header=0)
    max_dim = max([int(c) for c in df.columns])
    return {
           (i): [r[str(i)] for i in range(max_dim + 1)] for _, r in df.iterrows()
    }

I get: ValueError: invalid literal for int() with base 10: 'Unnamed: 0'
I did try to add after df = pd.read_csv(fname, header=0)
df = df.set_axis(['column1_name', 'column2_name, column3_name]), axis=1)
but then I get:
ValueError: invalid literal for int() with base 10: 'Unnamed: 0'
I mean I see the embeddings format in the file it has the vectors so indeed it does not seems ok to me to load it this way but how, sorry I do not know python just try  :)


Fix for init_sysv.erb template

Description
Fix for init_sysv.erb template: Tomcat service 'stop' action has been failed.
Because ${TOMCAT_SCRIPT} may overwrite ${CATALINA_PID}
Issues Resolved
https://github.com/chef-cookbooks/tomcat/issues/256

Hi. I am an automated pull request bot named Curry. There are commits in this pull request whose authors are not yet authorized to contribute to Chef Software, Inc. projects or are using a non-GitHub verified email address. To become authorized to contribute, you will need to sign the Contributor License Agreement (CLA) as an individual or on behalf of your company. You can read more on Chef's blog.
Non-GitHub Verified Committers
There are 1 commit author(s) whose commits are authored by a non-GitHub verified email address. Chef will have to manually verify that they are authorized to contribute.
Please sign the CLA here.

This issue should be fixed in the 2.3.1 release by leaving the pid creation up to the catalina script instead of doing it in the init script.  Please give it a try and let me know if that fixes your problems.

I've got this error again (Error code 4):
       ===================================================================
       Error executing action `enable` on resource 'tomcat_service_sysv_init[base]'
      ===================================================================

       Mixlib::ShellOut::ShellCommandFailed
       ------------------------------------
       service[tomcat_base] (/tmp/kitchen/cache/cookbooks/tomcat/resources/service_sysv_init.rb line 53) had an error: Mixlib::ShellOut::ShellCommandFailed: Expected process to exit with [0], but received '4'
       ---- Begin output of /sbin/service tomcat_base start ----
       STDOUT: Starting tomcat_base: Error code 4[FAILED]
       STDERR:
       ---- End output of /sbin/service tomcat_base start ----
       Ran /sbin/service tomcat_base start returned 4

I have this code in my Chef-recipe:
tomcat_service node['rdt_tomcat']['instance_name'] do
  action [ :enable, :restart ]
  env_vars [{ 'CATALINA_PID' => node['rdt_tomcat']['catalina_pid'] }]
end

OS: CentOS 6.6
Tomcat cookbook version: 2.3.4


Works pretty much out of the box...issue with application roots

Nice job first off to a simple approach to making a voicemail box for twilio phone. Worked pretty much immediately with the documentation available here. https://www.twilio.com/blog/build-a-voicemail-service-using-twilio-voice-and-aspdotnet-core
One issue that I could not solve. When deploying to the main application root of an IIS server, had no issues. When deploying to a virtual application/root, I could leave messages, but it always failed to retrieve them.  Tried multiple ways to reference the Voicemail folder within a virtual app folder, but no avail. It can get the count of files however.

Hi @exonome , I'm glad it (mostly) worked without much effort. Regarding your issue, I don't have an exact answer though, unfortunately. I'd have said mapping or permission issues. but getting the count of files correctly rules that out.
Basically, I'd check the path of the voicemails, which is set here: https://github.com/Dev-Power/voicemail-service-using-twilio/blob/1227e9dc419406fef4b5479a20578e008b48730f/src/VoicemailDirectory.WebApi/Services/FileService.cs#LL26C7-L26C7
Also make sure the files have mp3 extension as the code only selects those: https://github.com/Dev-Power/voicemail-service-using-twilio/blob/1227e9dc419406fef4b5479a20578e008b48730f/src/VoicemailDirectory.WebApi/Services/FileService.cs#LL26C7-L26C7
If you spot and fix a bug, I'd appreciate a PR so I would merge it to the main application and potentially update the Twilio article as well.

Also forgot to mention: Just this week published Part 2 of the article, which implements a Razor user interface to add more functionality: https://www.twilio.com/blog/build-a-voicemail-inbox-using-twilio-voice-and-blazor


[FEATURE] Build a simple static submission page

Detailed description
Build a simple static page submission page under Play CTF.
Context
The value stored in the backend: is<PHONE_NUMBER>37
If a user submits the value<PHONE_NUMBER>37, turn the button green. and display congrats.
Possible implementation
No response
Additional information
No response
Code of Conduct

[X] I agree to follow this project's Code of Conduct

Hi @kabir0x23, I'd like to work on the issue. Kindly assign it to me

Hi @kabir0x23, I'd like to work on the issue. Kindly assign it to me

Sure, I am assigning this issue to you.

this issue is very simple, like login page nothing else.
If you still want to do, or having any doubts, let us now

@kabir0x23 okay, I'll try it again. Actually, I was having issue with it's css. My page was overlapping with the header and navbar component.

@kabir0x23 okay, I'll try it again. Actually, I was having issue with it's css. My page was overlapping with the header and navbar components.

Awesome.
the solution to the CSS:

just give a 200px margin-top to the main container, then it will be fine.

If you will have any doubts or questions let us know.
Thank you.

I wanted to know if the user will be redirected to submit page when he clicks on play CTF. That's what our plan is, right?

I wanted to know if the user will be redirected to submit page when he clicks on play CTF. That's what our plan is, right?

yes, right 👍

I'm not able to route to the submit page, If you could guide me with that

Hello @kabir0x23 can u please assign me this issue. I would like to work on this

I'm not able to route to the submit page, If you could guide me with that

I'm not able to route to the submit page, If you could guide me with that

you can directly work on this page: https://www.thecyberhub.org/CTF
or
routing, you have to add routing in the app. jsx like this:

Okay👍

@kabir0x23
👁👁

Hi @kabir0x23
Is someone working on this already?

my bad 😅
your one is here https://github.com/thecyberworld/thecyberhub.org/issues/111


Remove yarn-error.log

Removes a left over yarn error log file and adds them to the .gitignore so they don't accidentally get added again

This is required as per Yarn-error log documentation. Please revert this change.


"I get up at 7 a.m. every day." fail

I get up at 7 a.m. every day.
return result ['0'=>'I get up at 7 a.m.', 'every day.']
The returned result is incorrect, this sentence does not need to be split

I think the basic criteria here to handle this in code is to join 2 splits when:

directly after a full stop is a letter a.m. (from your example it seems like this is fine)
if the subsequent word starts with lowercase word, assuming its a continuation of the previous sentence


refactor: remove 8 bit portion of the range checker

Describe your changes
Addressing #395. Simplifies the range checker design by removing the 8-bit segment of the range checker table. This however increases the minimum length of the trace since we can no longer use the 8-bit table after this change to allow jumps of $2^8$ and instead can only allow jumps of 8 because that requires a constraint of degree 9. The following constraint ensures consistency of the range checker table.
$$
\prod_{i=0}^8 (\Delta v - i) = 0
$$

[X] Modify the shape of the trace and trace generation
[X] Update AIR constraints
[X] Update tests
[ ] Update docs
[ ] Modify testing methodology to reduce test run-times.

Checklist before requesting a review

Repo forked and branch created from next according to naming convention.
Commit messages and codestyle follow conventions.
Relevant issues are linked in the PR description.
Tests added for new functionality.
Documentation/comments updated according to changes.

If I'm reading test runtimes correctly, it seems that they increased by 30% - 40% - is this right? If so, maybe it's not too bad. If there are some simple ways to reduce them, we can do that now - but if not, we can leave that for future PRs.

If I'm reading test runtimes correctly, it seems that they increased by 30% - 40% - is this right?

On M1 with 8 cores, it goes from ~47 seconds to ~500 seconds for integration tests.

On M1 with 8 cores, it goes from ~47 seconds to ~500 seconds for integration tests.

Is this via make test command?

Is this via make test command?

Ah, that was using cargo test without any flags. Using make test you're right it's around 30% increase.

Ah, that was using cargo test without any flags. Using make test you're right it's around 30% increase.

make test is what we use to run tests in CI (and also locally) - so, I'd base analysis on these numbers. What do absolute numbers look like, btw?

@bobbinth Sorry, I ran it on the wrong branch earlier. It actually goes from ~4 to ~60 seconds.

It actually goes from ~4 to ~60 seconds.

Hmmm - could you double-check? A 15x increase seems rather high - I would have expected an 8x increase in the worst possible case.

Hmmm - could you double-check? A 15x increase seems rather high - I would have expected an 8x increase in the worst possible case.

Yeah, makes sense. The runtime number seems correct (checked 5 times). Let me look into it and get back.

Closing this PR since this design increases the minimum trace length to $2^14$ which is probably fine for the rollup but more than what we want for the VM.


Update API ref for torchtune/data

Context
What is the purpose of this PR? Is it to

[ ] add a new feature
[ ] fix a bug
[x] update tests and/or documentation
[ ] other (please add here)

Please link to any issues this PR addresses.
Changelog

Include missing APIs in live docs
Rename message converters to be less llama2 specific

Test plan
Please make sure to do each of the following if applicable to your PR. (If you're not sure about any one of these just ask and we will happily help.)

[x] run pre-commit hooks and linters (make sure you've first installed via pre-commit install)
[ ] add unit tests for any new functionality
[x] update docstrings for any new or updated methods or classes
[x] run unit tests via pytest tests
[ ] run recipe tests via pytest tests -m integration_test
[ ] manually run any new or modified recipes with sufficient proof of correctness

[ ] include relevant commands and any other artifacts in this summary (pastes of loss curves, eval results, etc.)

One thing that's a bit confusing to me on the data page is the relationship between "Chat Formats" and "Instruct Templates", if they're all just templates maybe they should be grouped together under text templates?

At this rate I might just combine them altogether...

Commandeered this diff here: #1091

Closed by #1091


Alphabetically sort secrets / configs in service details select box

On the details page for a Swarm service, the values in the configs and secrets select boxes are not sorted, with the options appearing seemingly-randomly.
It would be very useful if these were sorted alphabetically, as this would enable a naming scheme to work, eg. 20180831_service_config
Thank you!

Hi @yati1998
Sure, feel free to submit a PR for this. If you have any questions, just ask.
Our contributions guidelines are available here: https://portainer.readthedocs.io/en/stable/contribute.html

This is related to #2125


How do I specify the video quality?

DO NOT REMOVE OR SKIP THE ISSUE TEMPLATE

[X] I understand that I will be blocked if I intentionally remove or skip any mandatory* field

Checklist

[X] I'm asking a question and not reporting a bug or requesting a feature
[X] I've looked through the README
[X] I've verified that I have updated yt-dlp to nightly or master (update instructions)
[X] I've searched known issues and the bugtracker for similar questions including closed ones. DO NOT post duplicates
[X] I've read the guidelines for opening an issue

Please make sure the question is worded well enough to be understood
How do I specify that the video to be downloaded is always 480P in the "Specify download arguments" section in the settings?
Can someone please give me the command...
I'm using a GUI software called vividl, and I'm asking here because you said it has yt-dlp built in.
I'm having trouble figuring out how to do this, so I'd appreciate it if someone could help me.
Provide verbose output that clearly demonstrates the problem

[ ] Run your yt-dlp command with -vU flag added (yt-dlp -vU <your command line>)
[ ] If using API, add 'verbose': True to YoutubeDL params instead
[ ] Copy the WHOLE output (starting with [debug] Command-line config) and insert it below

Complete Verbose Output
No response

Ask vivdl community/devs


Enemy death counting with lifedrain

Using a wizard on the level Bookkeeper, i switched to using life-drain instead of the default attack to kill enemies, on hero.say(defeated) it would report double the number of enemies killed when using the default code.

Thanks for reporting this! Is this blocking, or stopping progress for you? How severe would you say this is?

I was able to get passed the level by deleting the sample code and using a different method for counting dead enemies. It would have been more annoying if I was a total beginner.


Make distributed tasks delay time configurable

What changes are proposed in this pull request?
Make distributed tasks delay time configurable.
Why are the changes needed?
When the number of nodes in the cluster is large, the delay time of 10s may cause incomplete task scheduling. The delay time should be flexibly configured as required
Does this PR introduce any user facing changes?
No

Codecov Report

Merging #14001 (1442f4d) into master (58555b7) will decrease coverage by 25.88%.
The diff coverage is 0.00%.

@@              Coverage Diff              @@
##             master   #14001       +/-   ##
=============================================
- Coverage     43.27%   17.38%   -25.89%
+ Complexity     9150     2681     -6469
=============================================
  Files          1414     1414
  Lines         81936    81937        +1
  Branches       9917     9917
=============================================
- Hits          35454    14247    -21207
- Misses        43525    66436    +22911
+ Partials       2957     1254     -1703

Impacted Files
Coverage Δ

...n/src/main/java/alluxio/stress/BaseParameters.java
0.00% <0.00%> (-100.00%)
:arrow_down:

...ll/src/main/java/alluxio/stress/cli/Benchmark.java
0.00% <0.00%> (ø)

...mon/src/main/java/alluxio/shell/CommandReturn.java
0.00% <0.00%> (-100.00%)
:arrow_down:

...mon/src/main/java/alluxio/util/ExceptionUtils.java
0.00% <0.00%> (-100.00%)
:arrow_down:

...n/src/main/java/alluxio/wire/AlluxioProxyInfo.java
0.00% <0.00%> (-100.00%)
:arrow_down:

.../src/main/java/alluxio/wire/AlluxioMasterInfo.java
0.00% <0.00%> (-100.00%)
:arrow_down:

...src/main/java/alluxio/job/meta/JobIdGenerator.java
0.00% <0.00%> (-100.00%)
:arrow_down:

...src/main/java/alluxio/client/UnderStorageType.java
0.00% <0.00%> (-100.00%)
:arrow_down:

...main/java/alluxio/underfs/options/ListOptions.java
0.00% <0.00%> (-100.00%)
:arrow_down:

...main/java/alluxio/worker/block/io/BlockReader.java
0.00% <0.00%> (-100.00%)
:arrow_down:

... and 665 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 58555b7...1442f4d. Read the comment docs.

@jiacheliu3 I have fixed it,PTAL

@dbw9580 Could you update the documentation reflecting this change after the PR's merged? Thx :)

@codings-dan thanks for your contribution. I made a commit to rename and limit the new flag to cluster only execution, as I don't think you meant to apply a start delay for in-process execution.
@jiacheliu3

Could you update the documentation reflecting this change after the PR's merged?

Will do.

@dbw9580 thanks for the improvents.  @jiacheliu3 I  have add example in the description, PTAL

alluxio-bot, merge this please


chore: add linting step in snapshot_release workflow

Signed-off-by: kushthedude<EMAIL_ADDRESS>refers https://github.com/OpenRefine/OpenRefine/pull/3635#pullrequestreview-590072049

To be merged after https://github.com/OpenRefine/OpenRefine/pull/3635 , as unlinted_files are present

Good to be reviewed now!


Support import maps and/or add "dependenciesFile" key to config

🚀 Feature
Add support for import maps like Deno does, more specifically to the eggs update command. There may be other commands that could profit from this too.
Motivation
I don't use Typescript or even JavaScript module files, instead I use a modules.json file as an import map, which is supported by Deno (and Chrome I think) and will be (fingers crossed) standard soon. There is currently no way for me to update my dependencies through the eggs CLI, unless I switch to a .ts or .js file.
Implementation
A simple and hopefully fast solution would be to add JSON support to the eggg update command, more specifically to the --file option.
But I personally think it would be good to add a key like dependenciesFile to the egg config schema, so one doesn't have to use the --file option every time they want to update their dependencies just because they named their dependencies file something other than the default (and - to be fair - opinionated) "deps.ts".
Alternatives
I think dependenciesFile is a descriptive, but pretty long key. However, I couldn't come up with a better key yet, dependencies for example seems to vague, just file seems misleading, which is why I would also suggest to change the name of the CLI option. Maybe depFile? importsFile? modulesFile?

Import maps should not be used as a primary way to manage dependencies. Import maps are not composable and make it harder to use for the user
Quote from deno 1.8 release post

Users should keep in mind that import maps are not composable: this means you can only provide a single import map to deno run / deno test. Because of this library authors should still use regular, non-bare specifiers (relative or absolute file / http URLs); otherwise the users of the library will manually need to add your libraries (and your libraries dependencies) bare specifiers into their import map.
A much more useful feature for import maps is ability to remap regular specifiers to completely different ones. For example if you have some broken dependency that is deeply nested in your module graph you can replace it with fixed version before it's fixed upstream, or if you use a build process that adds hashes to your modules filenames, you can refer to the file without hashes in your source code and remap the specifiers only at runtime using an import map.

Import maps are not composable and should not be used for dependency management
Quote from deno 1.8 release notes:

Users should keep in mind that import maps are not composable: this means you can only provide a single import map to deno run / deno test. Because of this library authors should still use regular, non-bare specifiers (relative or absolute file / http URLs); otherwise the users of the library will manually need to add your libraries (and your libraries dependencies) bare specifiers into their import map.
A much more useful feature for import maps is ability to remap regular specifiers to completely different ones. For example if you have some broken dependency that is deeply nested in your module graph you can replace it with fixed version before it's fixed upstream, or if you use a build process that adds hashes to your modules filenames, you can refer to the file without hashes in your source code and remap the specifiers only at runtime using an import map.

I'm not a native english speaker, so I'm not a 100% sure, but do these two paragraphs basically say that if I write a library which imports, idk, "cliffy.ts", but through an import map, so its actually using only "cliffy" in my code, anyone using my library would not be able to run this code without providing an import map themselves?
Well, if so, then that's unfortunate, didn't know that. But it actually makes sense, compared to node, but there it's just automated through npm install I guess.
But alright, thanks for pointing me to that info in the release notes, I will switch to a modules.js or dependencies.js file, everything in eggs should be fine with that.
I still think the --file option is a bit confusing though, but that's another issue after all.

Yes that is correct. Basically if you use import maps for dependency management, the ser will have to use your import map to use your module. And if many modules use this method, the user will have to use multiple import maps, which is not possible.
The current community convention is to use a deps.ts or deps.js file and keep it in the root directory to make it easier for the user to check which dependencies you are using.
If you have further questions we'd love to answer them in our Discord server


add a no-parameter initializer to pthread_t on Darwin

This adds a no-parameter initializer to pthread_t, aka UnsafeMutablePointer<_opaque_pthread_t>. With this addition, pthread_t can once again be initialized the same way on both Linux and Darwin.
var thread = pthread_t()

Resolves SR-775.

This seems like a strange outcome. Do we have any other types where T() is nil-like?
I assume that nobody ever wants to perform integer-like operations on a Linux pthread_t. Perhaps Linux should also import pthread_t as a pointer-like type.

On Linux, pthread_t maps to a long int; who knows how it's used.
From /usr/include/x86_64-linux-gnu/bit/pthreadtypes.h:
typedef unsigned long int pthread_t;
On macOS, from /usr/include/sys/_pthread/_pthread_t.h:
typedef __darwin_pthread_t pthread_t; // this is the only definition in that header
and from /usr/include/sys/_pthread/_pthread_types.h:
typedef struct _opaque_pthread_t *__darwin_pthread_t;
Given that pthread_t is supposed to be opaque, having it be mapped as a pointer is not particularly useful. With the never-nil pointers, it's also confusing.

I don't understand this well enough to offer any feedback, but I'm just curious -- when do you need to create 'uninitialized' pthread_t values?

You don't, really. pthread_t is actually initialized by calling pthread_create(); it doesn't care what was previously in the variable, it allocates its opaque data structure and just fills in the pthread_t with the "thread id" (which everyone knows is a pointer to opaque data).
Swift demands initialization of variable, though, so we need something.
The two following programs do the same silly thing:
import Darwin

func start(_ ump: UnsafeMutableRawPointer) -> UnsafeMutableRawPointer?
{
  print(ump)
  return nil
}

var p: pthread_t? = nil
pthread_create(&p, nil, start, &p)
pthread_join(p!, nil)

import Glibc

func start(_ ump: UnsafeMutableRawPointer?) -> UnsafeMutableRawPointer?
{
  print(ump!)
  return nil
}

var p = pthread_t()                // var p: pthread_t = 0 also works
pthread_create(&p, nil, start, &p)
pthread_join(p, nil)

As you can see from the various differences, the pthreads interface gets imported differently on both platforms, despite having pretty much the same headers. This contribution is a very limited reduction to the overall pain.

I don't know if pthread_t is special here. There are plenty of other types that are integers or structs on one platform and pointers on another. Maybe we should just bring back the no-argument initializer for Optionals.
(cc @airspeedswift)

@glessard If it still makes sense to take this, could you rebase this patch?

I understand that's how pthread_t is intended to work. The point that needs discussion is whether the Swift platform overlay should include per-type concessions to things like this.

Would there be a way to override the importer and define pthread_t as a typealias for Int? In C it doesn't matter in use whether it's a pointer or a long int. In Swift the knock-on effects are numerous, and it transforms pthreads into a non-portable api.

Anything we do, clever or non-clever, has to go through swift-evolution.

Understood, but is it even possible? Making pthread_t not-a-pointer would be the better solution, if only it were possible.

I think it's possible, but I'd be concerned about platforms that may have implemented it as non-word-sized. Then we're just back to a different incompatibility.

This is only about the way the type is imported on Darwin… does it necessarily affect other platforms? (I haven't tried it again, but before I submitted this PR it didn't affect the Linux build). In any event, conditional compilation is certainly an option.

Ah, changes in import would be special-cased in the compiler, so it'd be clunkier to make it platform-specific.

But what's the point of doing it for Darwin if it's not going to be consistent across other OSs?

pthread_t should be opaque and behave as such. On Darwin, the Swift importer is violating that by interpreting it as a pointer -- which is not quite opaque and triggers a large amount of compiler magic. That makes the type impossible to use as intended. If any other platform imports it as a pointer, it would have to be fixed there too. The strategy that happens to work (this is all clearly accidental) is declaring the type as an int.
If you look at the examples I put above, the Glibc/Linux version looks like pthread code. The Darwin version does not, because it is encumbered with Optionals that don't make sense in that context. The rational options are to fix it or to nix the pthreads import. Either works.

@glessard A change like this to the standard library now requires evolution discussion.  I apologize that we were not able to resolve this at the time.  If you wish to pursue this change, please open a pull request to the swift evolution repository and a pitch thread on the forums.


Use relative paths for source and build dirs when testing

This was discovered when doing some investigation for https://github.com/ARMmbed/mbed-os/issues/6861.
Currently, mbed test is passing absolute paths for the --source and --build options. This path is not shortened by the Mbed OS tools when compiling, so the include paths are much longer than they need to be. This alters mbed test to instead pass relative paths to both --source and --build.
While this won't fix the issue completely, it will drastically reduce the include path lengths when using mbed test.

After applying this patch, you will be able to compile and test.

I like the patch but I think there's bigger fundamental problem with long paths on Windows and the Mbed OS codebase paths, etc. See email thread from @dlfryar. Not sure whether this helps or smears the problem or postpones it for another time.

This change brings the way paths are handled in line with the compile command. So more of a clarity and consistency thing than anything else.


It crashes when passed values dynamically

If you have a variable lets say
var lang = {}; // some json result

It cannot be initialized with those values
I tried alot of ways ..

I added extra quotes ,  I even tested with/without getting json from server i.e i echoed with php's encode_json

offText: "" + lang['final'] + "",
onText: "" + lang['draft'] + "",

without
offText:  lang['final'] ,
onText:  lang['draft'] ,

It can only be initialized by using string literals :disappointed:

i managed to do this
onText: '' + lang['draft'] + ' ', //hack


Strange MacOS Editor connection problems: Can't even connect to localhost.

Hey NX,
This might be due to my implementation but going back a bit there was someone who had a similar issue (#24) to this but here goes. My issue ticket mainly to use as a bug marker is located here with the reproducible project.
It seems that if you have two Mac OS editors running on two copies of the same project, one in server mode on localhost port 7777 and one in client mode connecting to localhost on the same port, then you cannot connect the client mode instance to the server mode instance.
This seems to arise when I'm using it with the Mirror HLAPI integration, but here's the really weird part: Windows Editor instances works fine. You'd think that if macOS version of Unity had issues with the wrapper then it would be affect other operating systems, no? Well apparently not... this bug is only exclusive to macOS.
I can't remember 100% but I do think that I can connect the macOS client to a Windows Editor host with no problems. And vice versa. Just that Mac OS localhost breaks itself.
Now, I know my code is not your project and I don't expect you to walk the full source code in the quest to squash this bug, but I would greatly appreciate you helping me look into this. I'm at my wits end without any ideas as to what could be going wrong - I'm currently thinking it's either something in Mac OS, or it's some quirk in ENET or ENET-C#. I'm not trying to point the finger at anyone here, but I've narrowed it down to 4 possibilities: Unity, my HLAPI integration, ENET-C# or the compiled ENET binary itself.
I'd gladly throw you some beer money if we can sort out this.

Hey nx,
I just confirmed that I got it working two Editor Instances working with each other. This is Unity 2019.1.0b1 with Mirror and the ENET UDP Transport of mine:

However, there is a caveat here... Apparently IP Addresses, at least <IP_ADDRESS> has issues with whatever the heck is going on. If I bind the server to localhost in once instance, then connect to localhost in the client, it works fine. But if I try to manually connect to <IP_ADDRESS>, it'll refuse to connect and time out.
I have no idea. But hey, at least we confirmed it works. For now, at least.

And check if you bind to all interfaces (<IP_ADDRESS> or ::0) connection to <IP_ADDRESS> works or not on Mac.

Binding to <IP_ADDRESS> which is that boxes' IP LAN address and using the second Unity Editor to start connecting to it doesn't work, as it just gets stuck on Connecting.
Checking <IP_ADDRESS> now...

<IP_ADDRESS> doesn't work either. However, out of curiosity since we're talking IP addresses I looked at my code where I bind the server instance to the IP address and commented it out just to test to see if there's a problem inside the SetHost call...
Sure enough, as soon as I did that and clicked "LAN Host" on the first client, it started the server, but when I tried ::1, <IP_ADDRESS>, localhost, <IP_ADDRESS> on the client end - bingo. Every single attempt was successful - 100% rate.
 I guess Mac wants to network different.

Okay, about connecting to <IP_ADDRESS> if the host is bind to localhost on Linux/UNIX/POSIX. Unlike on the Windows it will be set by default to IPv6 address ::1, this is specified in the /etc/hosts. So here's two solutions:

Make the following changes to /etc/hosts:

<IP_ADDRESS>    localhost
::1          localhost

Modify ENet to bind to both addresses when one of them is used for binding.

As for local <IP_ADDRESS> network address, the owner of this address should be your machine or you need to make sure that nothing prevents to connect to it, and the host was bind to it successfully.

That's definitely the case, the <IP_ADDRESS> address is owned by the Mac box. My router, which is a MikroTik says that the MAC address in use for that IP matches the Mac's LAN MAC address.
Would you have to modify ENET's C language code to do that bind to both IPv4 and IPv6? Or would this be done in the C# layer? I hardly know any ANSI C, so I'd have to let you implement that.

Would you have to modify ENET's C language code to do that bind to both IPv4 and IPv6? Or would this be done in the C# layer? I hardly know any ANSI C, so I'd have to let you implement that.

I'm going to make a couple of tests before applying this changes, I'll comeback here soon.

Sure - I look forward to your findings.
I'm gonna update my transport to remove the binding to IP code inside the Unity Editor, at least that seems to be broken only on Mac.

Okay, if the ENet socket already bound to one of the interfaces it can't be bound additionally to another, so only the first option is the solution, however, binding to ::0 should work actually.

Hmm, ok. Let me give that a shot and see if that makes any difference.

Here's the simple test script which perfectly works on Windows and Linux:
using System.Threading;
using System.Runtime.InteropServices;
using ENet;
using UnityEngine;

using Event = ENet.Event;
using EventType = ENet.EventType;

public class Test : MonoBehaviour {
	public int maxClients = 4;
	public ushort port = 9500;
	private volatile bool isAlive = true;
	private Thread serverThread;
	private Thread[] clientThreads;
	private byte[] data = new byte[64];
	private Peer[] clients;

	private void Start() {
		ENet.Library.Initialize();

		serverThread = new Thread(Server);
		serverThread.Start();

		clientThreads = new Thread[maxClients];

		for (int i = 0; i < maxClients; i++) {
			clientThreads[i] = new Thread(Client);
			clientThreads[i].Start();
		}

		clients = new Peer[maxClients];
	}

	private void SendPacket(Peer peer) {
		Packet packet = default(Packet);

		data[0] = 1;
		packet.Create(data, data.Length, PacketFlags.Reliable);
		peer.Send(0, ref packet);
	}

	private void Server() {
		using (Host server = new Host()) {
			Address address = new Address();

			address.Port = port;
			address.SetHost("::0");

			server.Create(address, maxClients, 2);

			Event netEvent;

			while (isAlive) {
				server.Service(15, out netEvent);

				switch (netEvent.Type) {
					case EventType.None:
						break;

					case EventType.Connect:
						Debug.Log("[Server] Client connected - ID: " + netEvent.Peer.ID + ", IP: " + netEvent.Peer.IP);

						clients[server.PeersCount - 1] = netEvent.Peer;

						if (server.PeersCount == maxClients) {
							Packet packet = default(Packet);

							data[0] = 2;
							packet.Create(data, data.Length, PacketFlags.Reliable);
							server.Broadcast(1, ref packet, clients);
						}
						break;

					case EventType.Disconnect:
						Debug.Log("[Server] Client disconnected - ID: " + netEvent.Peer.ID + ", IP: " + netEvent.Peer.IP);
						break;

					case EventType.Timeout:
						Debug.Log("[Server] Client timeout - ID: " + netEvent.Peer.ID + ", IP: " + netEvent.Peer.IP);
						break;

					case EventType.Receive:
						Debug.Log("[Server] Packet received from - ID: " + netEvent.Peer.ID + ", IP: " + netEvent.Peer.IP + ", Channel ID: " + netEvent.ChannelID + ", Data length: " + netEvent.Packet.Length);
						SendPacket(netEvent.Peer);
						Debug.Log("[Server] Packet sent to - ID: " + netEvent.Peer.ID + ", IP: " + netEvent.Peer.IP + ", Data length: " + data.Length);
						netEvent.Packet.Dispose();
						break;
				}
			}

			server.Flush();
		}
	}

	private void Client() {
		using (Host client = new Host()) {
			Address address = new Address();

			address.SetHost("::1");
			address.Port = port;

			client.Create();

			Peer peer = client.Connect(address, 2);
			Event netEvent;

			while (isAlive) {
				client.Service(15, out netEvent);

				switch (netEvent.Type) {
					case EventType.None:
						break;

					case EventType.Connect:
						Debug.Log("[Client] Client connected to server - ID: " + peer.ID);
						SendPacket(peer);
						Debug.Log("[Client] Packet sent to server - Data length: " + data.Length);
						break;

					case EventType.Disconnect:
						Debug.Log("[Client] Client disconnected from server");
						break;

					case EventType.Timeout:
						Debug.Log("[Client] Client connection timeout");
						break;

					case EventType.Receive:
						if (Marshal.ReadByte(netEvent.Packet.Data, 0) == 1)
							Debug.Log("[Client] Packet received from server - Channel ID: " + netEvent.ChannelID + ", Data length: " + netEvent.Packet.Length);
						else if (Marshal.ReadByte(netEvent.Packet.Data, 0) == 2)
							Debug.Log("[Client] Broadcasted packet received from server - Channel ID: " + netEvent.ChannelID + ", Data length: " + netEvent.Packet.Length);

						netEvent.Packet.Dispose();
						break;
				}
			}

			client.Flush();
		}
	}

	private void OnDestroy() {
		isAlive = false;
		ENet.Library.Deinitialize();
	}
}

Thanks for the sample code - I'll file it away under references. 😄
Just patched the ::0 into my transport code, and it's working as intended. Tested another editor instance using localhost, the box network IP (192.168.x.x), ::1 and <IP_ADDRESS> with 100% success rate for all connections.
So I think I will need to document that in my transport and if they click LAN Host on OS X I will just bind to ::0. On Windows and Linux I will offer the "bind to IP" function which has some use on servers with more than one static IP. I know you could use iptables trickery but eh.
I'll keep in touch and see if this problem occurs again, but thanks very much - I am relieved that we were able to identify it down to a Mac OS oddity.


Role should be an optional field in add command

Role is a compulsory field in add command, however in a normal CCA there are likely members who do not hold any roles.

It may be more intuitive for roles to be optional.

Oh, maybe we were looking at a particular kind of CCA -- where each member must hold a role/department. There is no such thing as "general member". If we want to broaden the definition of the CCA, maybe we can add a role called "General". If we have a "General", we should have a mechanism that says if a member is assigned with "General", no other roles should be assigned to the member.

I think "Member" instead of "General" would be better. For simplicity, I think mandating that "r/" be specified is important. As a future update (developer guide), we can include optional parameter for roles but if not specified, automatically set to member


style: fix styling on pr

https://github.com/shamsdev/davinci/pull/20#issuecomment-895977574
This should do the trick

I checked it, and no, it is not going to work


Bump to 2.50.2 and add myself as maintainer

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

Thanks! You can remove myself from the maintainers, since I guess you and @pkgw are much more competent in taking care of this package :-)


ShieldJobFailed1d alert only triggers when job is paused

Hello,
My question is about the ShieldJobFailed1d  alert for shield.
The code bellow is for this alert.
==>

ALERT ShieldJobFailed1d
IF shield_job_status == 4 and shield_job_paused != 0

It may be better to change it to be run when getting a failed job that is not in a paused state.
==>

ALERT ShieldJobFailed1d
IF shield_job_status == 4 and shield_job_paused != 1

Best regards,

Thanks for reporting this @szaouam. It was a bug, it has been fixed at https://github.com/cloudfoundry-community/prometheus-boshrelease/commit/619ea651ec032a115892a36d4e298e35406857f9.


Add newsletter signup to front page

Closed in https://github.com/Give-Back-Cincinnati/website/pull/8


Add an AJAX concurrency limiter for tile source requests

This is a proof-of-concept for a new viewer option which attempts to address #2241
For very large sessions it's easy to hit a browser's concurrent network requests limit, causing it to cancel a bunch of tile source ajax requests, it would be nice to have an option similar to imageLoaderLimit to avoid this case.
I'm opening this as a draft now; I added this feature without much care for style or the existing project structure, but thought it would be a good jumping off point for discussion about how to properly implement this!
This is a quick-and-dirty addition based on this gist: https://gist.github.com/Terrance/158a4c436baa64c4324803467844b00f

I think renaming the feature to be more generic makes a lot of sense! Something just like ajaxConcurrencyLimit, or maxConcurrentAjaxRequests?
Yeah I'm also not sure what the best way to set this value would be, having it be a member of the viewer would be nice because it lines up with all of the existing configuration options. But having it at the viewer level could still get us into trouble with the browser limits in the case that there are multiple viewers on the same page; from the perspective of making OSD as a whole not run up against browser limits (regardless of how many viewers are instantiated) it does make sense to make a global option, but we might have to invent a new way to set it 🤔
I'm willing to put in the work to implement it if we decide on a good way forward! Although this is my first time approaching the source so I'm not too familiar with the style or structure yet

I agree that having it global makes sense, and maybe it's about time we introduce global options somehow.
I think I like moving towards having functions for getting and setting properties, so maybe it would be something like OpenSeadragon.setAjaxLoaderLimit()? As for the name, the "loaderLimit" language already exists, so it might be good to stick with that. Your other name suggestions seem reasonable though.
You seem to be doing a fine job of fitting into the source style/structure!

@ChiliJohnson Are you interested in continuing work on this?

Hello, yes I'm still interested! Sorry I was out on vacation for a couple weeks there but am back now and able to push this forward.
I've been running this branch in production for the last few weeks without issue (churning through hundreds of thousands of AJAX requests) so I've at least convinced myself that the core logic works; now I just have to refactor it into something prettier

@ChiliJohnson Wonderful! There's no rush... Just making sure you haven't walked away :)

I've just pushed some updates based on the feedback! Still not sure if this is exactly the right approach to global settings but it's at least less of a draft now so I converted this to a real PR


[GLUTEN-5341][VL][Part 3] Fix and enable some uts of spark 3.5

What changes were proposed in this pull request?
(Please fill in changes proposed in this fix)
(Fixes: https://github.com/apache/incubator-gluten/issues/5341)
GlutenParquetCompressionCodecPrecedenceSuite
GlutenParquetV1QuerySuite
GlutenParquetV2QuerySuite
GlutenJsonReadSchemaSuite
GlutenCoalesceShufflePartitionsSuite
GlutenInsertSuite
GlutenPartitionedWriteSuite
GlutenCachedTableSuite
How was this patch tested?
manually test
(If this patch involves UI changes, please attach a screenshot; otherwise, remove this)

can you help mark the failures you fixed in the issue?

can you help mark the failures you fixed in the issue?

hey @yma11 you mean mark in the list of the issue https://github.com/apache/incubator-gluten/issues/5341 ?

Yes. I'm not sure whether you can edit it, can you have a try?

Yes. I'm not sure whether you can edit it, can you have a try?

actually before i already tried and i dont have permission to edit it, tried now still can't

Yes. I'm not sure whether you can edit it, can you have a try?

actually before i already tried and i dont have permission to edit it, tried now still can't

I can share all lists i have fixed to you, so you can help mark if it is ok ?

Yes. I'm not sure whether you can edit it, can you have a try?

actually before i already tried and i dont have permission to edit it, tried now still can't

I can share all lists i have fixed to you, so you can help mark if it is ok ?

Yes.  You can add comments in the issue and I update the list. Thanks!

===== Performance report for TPCH SF2000 with Velox backend, for reference only ====

query
log/native_5411_time.csv
log/native_master_04_14_2024_0e3387255_time.csv
difference
percentage

q1
38.51
38.08
-0.428
98.89%

q2
23.92
23.72
-0.205
99.14%

q3
36.93
37.90
0.962
102.60%

q4
39.57
39.60
0.035
100.09%

q5
69.63
71.73
2.106
103.02%

q6
7.52
6.97
-0.551
92.67%

q7
83.62
84.03
0.404
100.48%

q8
86.82
84.99
-1.832
97.89%

q9
121.04
125.91
4.874
104.03%

q10
42.83
44.70
1.877
104.38%

q11
20.10
20.27
0.175
100.87%

q12
31.07
27.63
-3.437
88.94%

q13
55.13
55.28
0.150
100.27%

q14
18.02
17.73
-0.290
98.39%

q15
29.03
31.75
2.719
109.36%

q16
14.06
13.82
-0.241
98.28%

q17
103.11
100.77
-2.345
97.73%

q18
141.57
143.22
1.655
101.17%

q19
15.66
15.86
0.200
101.28%

q20
26.11
28.08
1.975
107.56%

q21
289.52
289.28
-0.247
99.91%

q22
14.95
14.35
-0.602
95.97%

total
1308.71
1315.66
6.952
100.53%


Does it works on win10?

I am trying to use it on win10 but the destination folder keeps empty with, apparently, successful decryption.
Thank you.

Yes, it works very well on Win 10. You might want to show the actual command that you're running - perhaps this is an indication of a completely different problem.

On windowns 10 cmd, after 'cd' to the path where it is the LyndaDecryptor.exe, I run 'LyndaDecryptor /D "C:\Users\MyUserName\AppData\Local\Packages\lynda.com.lynda.com_0dmhem0sv94sr\LocalState\offline\100222"'. Then, it creates a folder, "decrypted", in the ...\offline\ directory but empty.
When I try to run with the /F option:
'LyndaDecryptor /F "C:\Users\MyUserName\AppData\Local\Packages\lynda.com.lynda.com_0dmhem0sv94sr\LocalState\offline\100222\111245_0b79795d3efc95b9976c7c5b933afce2_67059051.ldcw" "C:\Users\MyUserName\Desktop\videos"                                                                                [ARGS] Changing mode to Single decryption!                                                                              [START] Init Decryptor...                                                                                [START] Decryptor successful initalized!                                                                                [ERR] Couldn't load file: C:\Users\MyUserName\AppData\Local\Packages\lynda.com.lynda.com_0dmhem0sv94sr\LocalState\offline\100222\111245_0b79795d3efc95b9976c7c5b933afce2_67059051.ldcw                                                                                Press any key to exit the program... '
I get this error...
I also tryed without parentheses and with other folders and nothing worked.
Thank you for responding.

Ah, the issue is that you're trying to decrypt . ldcw files. These are
not supported by the decryptor at this time, however, somebody
suggested a solution here:
https://github.com/h4ck-rOOt/Lynda-Decryptor/issues/12#issuecomment-330521448
.
On Oct 8, 2017 20:18, "ihqsat"<EMAIL_ADDRESS>wrote:

On windowns 10 cmd, after 'cd' to the path where it is the
LyndaDecryptor.exe, I run 'LyndaDecryptor /D "C:\Users\MyUserName\AppData
Local\Packages\lynda.com.lynda.com_0dmhem0sv94sr\LocalState\offline\100222"'.
Then, it creates a folder, "decrypted", in the ...\offline\ directory but
empty.
When I try to run with the /F option:
'LyndaDecryptor /F "C:\Users\MyUserName\AppData\Local\Packages\lynda.com.
lynda.com_0dmhem0sv94sr\LocalState\offline\100222\111245_
0b79795d3efc95b9976c7c5b933afce2_67059051.ldcw"
"C:\Users\MyUserName\Desktop\videos" [ARGS] Changing mode to Single
decryption! [START] Init Decryptor... [START] Decryptor successful
initalized! [ERR] Couldn't load file: C:\Users\MyUserName\AppData
Local\Packages\lynda.com.lynda.com_0dmhem0sv94sr
LocalState\offline\100222\111245_0b79795d3efc95b9976c7c5b933afce2_67059051.ldcw
Press any key to exit the program... '
I get this error...
I also tryed without parentheses and with other folders and nothing worked.
Thank you for responding.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/h4ck-rOOt/Lynda-Decryptor/issues/37#issuecomment-335022002,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AGNUMy_sc-lY6hXsPh0x47LQkcPp-y8Aks5sqQPogaJpZM4PxJJ_
.

I have same problem with my windows 10
but solved it
just check whether your Decryption is completed or not. If completed just check log of output in command line
and check where the Decrypted files are located.

basically it stores in same folder where lynda encrypted files are stored

As LDWC merge request will be merged, I suggest to dedicate this issue to improving Decryption completed! message to something like:
On finishing: "Done. XX of XX files were decrypted."

Can someone help, after starting cmd as administrator and pointing to the unzipped folder then running
[[
LyndaDecryptor /D "C:\Lynda\ldc_dl_courses[course#]" /DB "C:\Users[my user]\AppData\Local\lynda.com\Lynda.com Desktop App\db.sqlite" /OUT "C:\Lynda\ldc_dl_courses[course#]\D"
]]
I get
('LyndaDecryptor' is not recognized as an internal or external command, operable program or batch file.)

"Lynda-Decryptor-master" seems to me that you have downloaded the source code, but should have download release archive from: https://github.com/h4ck-rOOt/Lynda-Decryptor/releases

yep.. seems i was linked to the source code instead of the release. To my surprize, working now. Thank you

I am not able to decrypt .LDCW files. please help me out.
C:\Users\Ravin\Downloads\LyndaDecryptor>LyndaDecryptor /D "C:\Users\Ravin\AppData\Local\Packages\lynda.com.lynda.com_0dmhem0sv94sr\LocalState\offline\419164" /DB "C:\Users\Ravin\AppData\Local\Packages\lynda.com.lynda.com_0dmhem0sv94sr\LocalState\db.sqlite"  /OUT "F:\offline\1"
[ARGS] Changing mode to Folder decryption!
[DB] Creating db connection...
[DB] DB successfully connected and opened!
[START] Init Decryptor...
[START] Decryptor successful initalized!
Decryption completed!
Press any key to exit the program...

@Ravin1822 Are you trying with my temporary release 1.3.1 or with existing 1.3?
Try downloading from here: https://github.com/DmytroSokhach/Lynda-Decryptor/releases/tag/1.3.1


ISPN-7506 Tests fail after upgrading Lucene version

https://issues.jboss.org/browse/ISPN-7506
https://issues.jboss.org/browse/ISPN-7484

You might want to include c00cdef96d4d02c1e7cfb9a2918fae16d0739f88
It fixes some problems with timezones, and tests failing at odd times ..

@Sanne done!

thanks! testing..

Looking at test failures

Should be fixed now

Tests build apparently failed with disk errors:
mv: cannot move ‘./server/integration/testsuite/target/server/node1/standalone/log/rest-access.log’ to ‘server_integration_testsuite_target_server_node1_standalone_log_rest-access.log’: No space left on device
but it seems to have run all the tests before and it had only 3 non-related failures.

looks good. pushing

thanks @gustavonalle

thanks @pruivo ! I couldn't test it myself but I'm happy it's merged :+1:


Add in effects that weren't being returned by Horizon

I was looking at the way Horizon returns effects and I noticed that there were some effects and fields that weren't being serialized properly and hence not getting returned in the API. This PR adds in the missing effects.
Changes:

Adds AuthImmutable flag for the AccountFlagsUpdated effect.
Adds InflationDestination for the AccountInflationDestinationUpdated effect.
Adds the DataCreated, DataRemoved, and DataUpdated effects.

For reference I've been using https://github.com/stellar/go/blob/081dd9cab83f085f74200d0cd72c13c111e63882/services/horizon/internal/ingest/session.go#L106 as the authoritative source of effects and their fields.

This was also reported in https://github.com/stellar/go/issues/294

In the course of doing this, I also found that the offer effects: EffectOfferCreated, EffectOfferRemoved, and EffectOfferUpdated are not being created in the ingestEffects method I linked above, as their docstring might suggest. Are these effects an artifact from earlier times and should no longer be used?

In the course of doing this, I also found that the offer effects: EffectOfferCreated, EffectOfferRemoved, and EffectOfferUpdated are not being created in the ingestEffects method I linked above, as their docstring might suggest. Are these effects an artifact from earlier times and should no longer be used?

We just need to implement them... the constants were simply defined before we got around to adding the effects into ingestion.

@martinxsliu would you mind adding support to offer related effects (so basically closing https://github.com/stellar/go/issues/166)?

@martinxsliu do you mind rebasing the PR? I believe InflationDestination for the AccountInflationDestinationUpdated effect has been added. I also have a PR adding offer related effects.


Branch2

@tinkofoxil Please sign the Contributor License Agreement!
Click here to manually synchronize the status of this Pull Request.
See the FAQ for frequently asked questions.


Getting error while installing and running with command "npx cra-universal start" ?

Hi, there.
Read your article here. It's really awesome. So I've a existing project I was working with react, react context-api, firebase. I installed using these
# Install new cra-universal $ npm install -D cra-universal
I got this in terminal
`npm install -D cra-universal
npm WARN<EMAIL_ADDRESS>requires a peer of<EMAIL_ADDRESS>but none is installed. You must install peer dependencies yourself.
npm WARN<EMAIL_ADDRESS>requires a peer of<EMAIL_ADDRESS>|| ^3.0.0 but none is installed. You must install peer dependencies yourself.
npm WARN<EMAIL_ADDRESS>requires a peer of webpack@1 || ^2 || ^2.1.0-beta || ^2.2.0-rc || ^3 but none is installed. You must install peer dependencies yourself.
npm WARN<EMAIL_ADDRESS>requires a peer of webpack@^1 || ^2 || ^2.1.0-beta || ^2.2.0-beta || ^3 but none is installed. You must install peer dependencies yourself.
npm WARN<EMAIL_ADDRESS>requires a peer of<EMAIL_ADDRESS>|| ^2.0.0 || ^3.0.0 but none is installed. You must install peer dependencies yourself.
npm WARN<EMAIL_ADDRESS>requires a peer of<EMAIL_ADDRESS>|| ^3.0.0 but none is installed. You must install peer dependencies yourself.
npm WARN<EMAIL_ADDRESS>requires a peer of webpack@1 || 2 || 3 but none is installed. You must install peer dependencies yourself.
npm WARN<EMAIL_ADDRESS>requires a peer of<EMAIL_ADDRESS>but none is installed. You must install peer dependencies yourself.
npm WARN optional SKIPPING OPTIONAL DEPENDENCY<EMAIL_ADDRESS>(node_modules/fsevents):
npm WARN notsup SKIPPING OPTIONAL DEPENDENCY: Unsupported platform for<EMAIL_ADDRESS>wanted {"os":"darwin","arch":"any"} (current: {"os":"linux","arch":"x64"})

<EMAIL_ADDRESS>removed 948 packages, updated 1 package and audited 36367 packages in 31.14s
found 0 vulnerabilitiesCan I ignore those warnings ?  When I start with npx cra-universal startI get this [ '/home/trilochan/Desktop/ssr_test/src/App.js\nModule build failed (from /home/trilochan/Desktop/ssr_test/node_modules/cra-universal/node_modules/babel-loader/lib/index.js):\nSyntaxError: Unexpected token (293:8)\n\n\u001b[0m \u001b[90m 291 | \u001b[39m\n \u001b[90m 292 | \u001b[39m\u001b[36mclass\u001b[39m \u001b[33mApp\u001b[39m \u001b[36mextends\u001b[39m \u001b[33mComponent\u001b[39m {\n\u001b[31m\u001b[1m>\u001b[22m\u001b[39m\u001b[90m 293 | \u001b[39m  state \u001b[33m=\u001b[39m {\n \u001b[90m     | \u001b[39m        \u001b[31m\u001b[1m^\u001b[22m\u001b[39m\n \u001b[90m 294 | \u001b[39m    loading\u001b[33m:\u001b[39m \u001b[36mtrue\u001b[39m\u001b[33m,\u001b[39m\n \u001b[90m 295 | \u001b[39m    cart\u001b[33m:\u001b[39m[]\u001b[33m,\u001b[39m\n \u001b[90m 296 | \u001b[39m    user\u001b[33m:\u001b[39m[]\u001b[33m,\u001b[39m\u001b[0m\n\nBabelLoaderError: SyntaxError: Unexpected token (293:8)\n\n\u001b[0m \u001b[90m 291 | \u001b[39m\n \u001b[90m 292 | \u001b[39m\u001b[36mclass\u001b[39m \u001b[33mApp\u001b[39m \u001b[36mextends\u001b[39m \u001b[33mComponent\u001b[39m {\n\u001b[31m\u001b[1m>\u001b[22m\u001b[39m\u001b[90m 293 | \u001b[39m  state \u001b[33m=\u001b[39m {\n \u001b[90m     | \u001b[39m        \u001b[31m\u001b[1m^\u001b[22m\u001b[39m\n \u001b[90m 294 | \u001b[39m    loading\u001b[33m:\u001b[39m \u001b[36mtrue\u001b[39m\u001b[33m,\u001b[39m\n \u001b[90m 295 | \u001b[39m    cart\u001b[33m:\u001b[39m[]\u001b[33m,\u001b[39m\n \u001b[90m 296 | \u001b[39m    user\u001b[33m:\u001b[39m[]\u001b[33m,\u001b[39m\u001b[0m\n\n    at transpile (/home/trilochan/Desktop/ssr_test/node_modules/cra-universal/node_modules/babel-loader/lib/index.js:65:13)\n    at Object.module.exports (/home/trilochan/Desktop/ssr_test/node_modules/cra-universal/node_modules/babel-loader/lib/index.js:173:20)\n @ ./server/app.js 9:15-41 24:2-30:4 25:20-46\n @ ./server/index.js\n @ multi ./server/index.js !/home/trilochan/Desktop/ssr_test/node_modules/start-server-webpack-plugin/dist/monitor-loader.js!/home/trilochan/Desktop/ssr_test/node_modules/start-server-webpack-plugin/dist/monitor-loader.js' ]
Hash: e176eca7c280a271d565
Version: webpack 4.19.1
Time: 662ms
Built at: 25/09/2018 1:06:26 PM
Asset      Size  Chunks             Chunk Names
bundle.js  35.5 KiB    main  [emitted]  main
Entrypoint main = bundle.js

ERROR in /home/trilochan/Desktop/ssr_test/src/App.js
Module build failed (from /home/trilochan/Desktop/ssr_test/node_modules/cra-universal/node_modules/babel-loader/lib/index.js):
SyntaxError: Unexpected token (293:8)
291 |
292 | class App extends Component {

293 |   state = {
|         ^
294 |     loading: true,
295 |     cart:[],
296 |     user:[],

@ ./server/app.js 9:15-41 24:2-30:4 25:20-46
@ ./server/index.js
@ multi ./server/index.js !/home/trilochan/Desktop/ssr_test/node_modules/start-server-webpack-plugin/dist/monitor-loader.js!/home/trilochan/Desktop/ssr_test/node_modules/start-server-webpack-plugin/dist/monitor-loader.js
webpack:////home/trilochan/Desktop/ssr_test/src/App.js?:1
throw new Error("Module build failed (from /home/trilochan/Desktop/ssr_test/node_modules/cra-universal/node_modules/babel-loader/lib/index.js):\nSyntaxError: Unexpected token (293:8)\n\n\u001b[0m \u001b[90m 291 | \u001b[39m\n \u001b[90m 292 | \u001b[39m\u001b[36mclass\u001b[39m \u001b[33mApp\u001b[39m \u001b[36mextends\u001b[39m \u001b[33mComponent\u001b[39m {\n\u001b[31m\u001b[1m>\u001b[22m\u001b[39m\u001b[90m 293 | \u001b[39m  state \u001b[33m=\u001b[39m {\n \u001b[90m     | \u001b[39m        \u001b[31m\u001b[1m^\u001b[22m\u001b[39m\n \u001b[90m 294 | \u001b[39m    loading\u001b[33m:\u001b[39m \u001b[36mtrue\u001b[39m\u001b[33m,\u001b[39m\n \u001b[90m 295 | \u001b[39m    cart\u001b[33m:\u001b[39m[]\u001b[33m,\u001b[39m\n \u001b[90m 296 | \u001b[39m    user\u001b[33m:\u001b[39m[]\u001b[33m,\u001b[39m\u001b[0m\n");
^
Error: Module build failed (from /home/trilochan/Desktop/ssr_test/node_modules/cra-universal/node_modules/babel-loader/lib/index.js):
SyntaxError: Unexpected token (293:8)
291 |
292 | class App extends Component {

293 |   state = {
|         ^
294 |     loading: true,
295 |     cart:[],
296 |     user:[],

at eval (webpack:////home/trilochan/Desktop/ssr_test/src/App.js?:1:7)
at Object.../../../../src/App.js (/home/trilochan/Desktop/ssr_test/server-build/bundle.js:762:1)
at __webpack_require__ (/home/trilochan/Desktop/ssr_test/server-build/bundle.js:683:30)
at fn (/home/trilochan/Desktop/ssr_test/server-build/bundle.js:60:20)
at eval (webpack:///./server/app.js?:9:16)
at Object../server/app.js (/home/trilochan/Desktop/ssr_test/server-build/bundle.js:785:1)
at __webpack_require__ (/home/trilochan/Desktop/ssr_test/server-build/bundle.js:683:30)
at fn (/home/trilochan/Desktop/ssr_test/server-build/bundle.js:60:20)
at eval (webpack:///./server/index.js?:3:11)
at Object../server/index.js (/home/trilochan/Desktop/ssr_test/server-build/bundle.js:797:1)

sswp> script exited with code 1
sswp> Script did not load or failed HMR, not restarting`

293 | state = {
| ^

this syntax is still in proposal stage, so you need the babel plugin

If your existing project is too complex, I recommend you to migrate the code piece by piece so the warning/errors won't be too overwhelming.

Similar to https://github.com/antonybudianto/cra-universal/issues/97#issuecomment-423574225

So, Do I have to add '.babelrc' file inside 'server-build' folder and include the following codes in it ?
{   "presets": ["env", "react"],   "plugins": ["dynamic-import-node", "transform-object-rest-spread"] }

That worked. Now I am getting this new error in terminal while running npx cra-universal start
getting this `npm WARN<EMAIL_ADDRESS>requires a peer of<EMAIL_ADDRESS>but none is installed. You must install peer dependencies yourself.
npm WARN optional SKIPPING OPTIONAL DEPENDENCY<EMAIL_ADDRESS>(node_modules/fsevents):
npm WARN notsup SKIPPING OPTIONAL DEPENDENCY: Unsupported platform for<EMAIL_ADDRESS>wanted {"os":"darwin","arch":"any"} (current: {"os":"linux","arch":"x64"}[ './server/app.js\nModule not found: Error: Can't resolve 'appbase/src/App' in '/home/trilochan/Desktop/ssr_test/node_modules/cra-universal/src/config/server'\nresolve 'appbase/src/App' in '/home/trilochan/Desktop/ssr_test/node_modules/cra-universal/src/config/server'\n  Parsed request is a module\n  using description file: /home/trilochan/Desktop/ssr_test/node_modules/cra-universal/package.json (relative path: ./src/config/server)\n    aliased with mapping 'appbase': '/home/trilochan/Desktop/ssr_test/server' to '/home/trilochan/Desktop/ssr_test/server/src/App'\n      using description file: /home/trilochan/Desktop/ssr_test/node_modules/cra-universal/package.json (relative path: ./src/config/server)\n        using description file: /home/trilochan/Desktop/ssr_test/package.json (relative path: ./server/src/App)\n          no extension\n            /home/trilochan/Desktop/ssr_test/server/src/App doesn't exist\n          .js\n            /home/trilochan/Desktop/ssr_test/server/src/App.js doesn't exist\n          .jsx\n            /home/trilochan/Desktop/ssr_test/server/src/App.jsx doesn't exist\n          as directory\n            /home/trilochan/Desktop/ssr_test/server/src/App doesn't exist\n[/home/trilochan/Desktop/ssr_test/server/src/App]\n[/home/trilochan/Desktop/ssr_test/server/src/App.js]\n[/home/trilochan/Desktop/ssr_test/server/src/App.jsx]\n @ ./server/app.js 9:15-41 24:2-30:4 25:20-46\n @ ./server/index.js\n @ multi ./server/index.js !/home/trilochan/Desktop/ssr_test/node_modules/start-server-webpack-plugin/dist/monitor-loader.js!/home/trilochan/Desktop/ssr_test/node_modules/start-server-webpack-plugin/dist/monitor-loader.js' ]
[ '/home/trilochan/Desktop/ssr_test/node_modules/express/lib/view.js 79:13-25\nCritical dependency: the request of a dependency is an expression\n    at CommonJsRequireContextDependency.getWarnings (/home/trilochan/Desktop/ssr_test/node_modules/cra-universal/node_modules/webpack/lib/dependencies/ContextDependency.js:40:18)\n    at Compilation.reportDependencyErrorsAndWarnings (/home/trilochan/Desktop/ssr_test/node_modules/cra-universal/node_modules/webpack/lib/Compilation.js:1327:24)\n    at Compilation.finish (/home/trilochan/Desktop/ssr_test/node_modules/cra-universal/node_modules/webpack/lib/Compilation.js:1138:9)\n    at hooks.make.callAsync.err (/home/trilochan/Desktop/ssr_test/node_modules/cra-universal/node_modules/webpack/lib/Compiler.js:539:17)\n    at _err0 (eval at create (/home/trilochan/Desktop/ssr_test/node_modules/tapable/lib/HookCodeFactory.js:32:10), :11:1)\n    at _addModuleChain (/home/trilochan/Desktop/ssr_test/node_modules/cra-universal/node_modules/webpack/lib/Compilation.js:1066:12)\n    at processModuleDependencies.err (/home/trilochan/Desktop/ssr_test/node_modules/cra-universal/node_modules/webpack/lib/Compilation.js:982:9)\n    at _combinedTickCallback (internal/process/next_tick.js:131:7)\n    at process._tickCallback (internal/process/next_tick.js:180:9)\n @ /home/trilochan/Desktop/ssr_test/node_modules/express/lib/application.js\n @ /home/trilochan/Desktop/ssr_test/node_modules/express/lib/express.js\n @ /home/trilochan/Desktop/ssr_test/node_modules/express/index.js\n<EMAIL_ADDRESS><EMAIL_ADDRESS>@ ./server/app.js\n @ ./server/index.js\n @ multi ./server/index.js !/home/trilochan/Desktop/ssr_test/node_modules/start-server-webpack-plugin/dist/monitor-loader.js!/home/trilochan/Desktop/ssr_test/node_modules/start-server-webpack-plugin/dist/monitor-loader.js' ]
Hash: f09a629655350afbf060
Version: webpack 4.20.0
Time: 18663ms
Built at: 25/09/2018 5:25:05 PM
Asset      Size  Chunks             Chunk Names
bundle.js  2.29 MiB    main  [emitted]  main
Entrypoint main = bundle.js
WARNING in /home/trilochan/Desktop/ssr_test/node_modules/express/lib/view.js 79:13-25
Critical dependency: the request of a dependency is an expression
@ /home/trilochan/Desktop/ssr_test/node_modules/express/lib/application.js
@ /home/trilochan/Desktop/ssr_test/node_modules/express/lib/express.js
@ /home/trilochan/Desktop/ssr_test/node_modules/express/index.js
<EMAIL_ADDRESS><EMAIL_ADDRESS>@ ./server/app.js
@ ./server/index.js
@ multi ./server/index.js !/home/trilochan/Desktop/ssr_test/node_modules/start-server-webpack-plugin/dist/monitor-loader.js!/home/trilochan/Desktop/ssr_test/node_modules/start-server-webpack-plugin/dist/monitor-loader.js
ERROR in ./server/app.js
Module not found: Error: Can't resolve 'appbase/src/App' in '/home/trilochan/Desktop/ssr_test/node_modules/cra-universal/src/config/server'
@ ./server/app.js 9:15-41 24:2-30:4 25:20-46
@ ./server/index.js
@ multi ./server/index.js !/home/trilochan/Desktop/ssr_test/node_modules/start-server-webpack-plugin/dist/monitor-loader.js!/home/trilochan/Desktop/ssr_test/node_modules/start-server-webpack-plugin/dist/monitor-loader.js
webpack:///./server/app.js?:9
var _require = webpack_require(!(function webpackMissingModule() { var e = new Error("Cannot find module 'appbase/src/App'"); e.code = 'MODULE_NOT_FOUND'; throw e; }())),
^
Error: Cannot find module 'appbase/src/App'
at webpackMissingModule (webpack:///./server/app.js?:9:80)
at eval (webpack:///./server/app.js?:9:170)
at Object../server/app.js (/home/trilochan/Desktop/ssr_test/server/server-build/bundle.js:3737:1)
at webpack_require (/home/trilochan/Desktop/ssr_test/server/server-build/bundle.js:683:30)
at fn (/home/trilochan/Desktop/ssr_test/server/server-build/bundle.js:60:20)
at eval (webpack:///./server/index.js?:3:11)
at Object../server/index.js (/home/trilochan/Desktop/ssr_test/server/server-build/bundle.js:3749:1)
at webpack_require (/home/trilochan/Desktop/ssr_test/server/server-build/bundle.js:683:30)
at fn (/home/trilochan/Desktop/ssr_test/server/server-build/bundle.js:60:20)
at eval (webpack:////home/trilochan/Desktop/ssr_test/node_modules/start-server-webpack-plugin/dist/monitor-loader.js?multi_./server/index.js_!/home/trilochan/Desktop/ssr_test/node_modules/start-server-webpack-plugin/dist/monitor-loader.js:1:1)
sswp> script exited with code 1
sswp> Script did not load or failed HMR, not restarting
`

/ssr_test/server/server-build/bundle.js
server-build should be generated on /ssr_test/server-build
hmm, which directory do you run the npx cra-universal init command?

This are the server/app.js contents
`const path = require('path');
const React = require('react');
import {
createReactAppExpress,
handleUniversalRender
} from '@cra-express/core';
const { default: App } = require('../src/App');
const clientBuildPath = path.resolve(__dirname, '../client');
let AppClass = App;
const app = createReactAppExpress({
clientBuildPath,
universalRender: () => handleUniversalRender()()
});
if (module.hot) {
module.hot.accept('../src/App', () => {
const { default: App } = require('../src/App');
AppClass = App;
console.log('✅ Server hot reloaded App');
});
}
module.exports = app;`

Can you create reproducible repository so I can inspect better?
Also please paste the content of your package.json

package.json {   "name": "test_app_react_ssr",   "version": "0.1.0",   "private": true,   "proxy": "http://localhost:3000",   "dependencies": {     "@babel/core": "^7.1.0",     "@cra-express/core": "^2.2.5",     "ajv": "^6.5.1",     "antd": "^3.6.3",     "antd-mobile": "^2.2.0",     "apparel-sorter": "^0.2.1",     "axios": "^0.18.0",     "babel-loader": "^8.0.2",     "babel-preset-es2015": "^6.24.1",     "babel-preset-react-app": "^3.1.2",     "body-parser": "^1.18.3",     "express": "^4.16.2",     "firebase": "^5.2.0",     "ignore-styles": "^5.0.1",     "jquery": "^3.3.1",     "lodash": "^4.17.10",     "moment": "^2.22.2",     "morgan": "^1.9.1",     "rc-drawer": "^1.7.5",     "react": "^16.5.2",     "react-device-detect": "^1.5.9",     "react-dom": "^16.5.2",     "react-ga": "^2.5.3",     "react-image-gallery": "^0.8.9",     "react-image-lightbox": "^5.0.0",     "react-images": "^0.5.19",     "react-loadable": "^5.5.0",     "react-media": "^1.8.0",     "react-motion-drawer": "^3.1.0",     "react-phone-input-2": "^2.6.0",     "react-router-dom": "^4.3.1",     "react-scripts": "1.1.4",     "react-slick": "^0.23.1",     "react-sticky": "^6.0.3",     "react-toastify": "^4.1.0",     "semantic-ui-css": "^2.3.3",     "semantic-ui-react": "^0.82.1",     "slick-carousel": "^1.8.1",     "tachyons": "^4.10.0",     "uuid": "^3.3.2",     "webpack": "^3.1.0",     "webpack-cli": "^3.1.1"   },   "scripts": {     "start": "react-scripts start",     "build": "react-scripts build",     "test": "react-scripts test --env=jsdom",     "eject": "react-scripts eject"   },   "devDependencies": {     "babel-preset-env": "^1.7.0",     "cra-universal": "^3.2.5",     "react-alice-carousel": "^1.10.3"   } }

this is what happens in terminal

I see, so the log is showing as expected. No idea so far, need to debug from your project

hmm why you have     "webpack": "^3.1.0" ?

Sorry, which Node and npm version you use?

installed webpack@latest got these warnings

then ran the command
 got the previous error again.
.babelrc not working :(

Are you sure you've installed https://babeljs.io/docs/en/babel-plugin-transform-class-properties and put it on babelrc?

Please check https://babeljs.io/docs/en/babel-plugin-transform-class-properties#via-babelrc-recommended
Your babelrc is missing the plugin...

Should I do this ?

??
{ "presets": ["env", "react"], "plugins": ["dynamic-import-node", "transform-object-rest-spread", "transform-class-properties"] }