Coredump in complete_aio

Bug Report
Please answer these questions before submitting your issue. Thanks!

What did you do?
If possible, provide a recipe for reproducing the error.

Test bootstrap, after a previous cleanup. Though this is a new bootstrap,
there was still some log files not cleared. The pegasus-server replayed those
log files during initialization, which caused this core dump.
D2019-09-07 16:13:18.846<PHONE_NUMBER>846027369 1e500) replica.default0.0000e4a500010001: mutation_log.cpp:864:replay(): start to replay mutation log /home/work/app/pegasus/c4tst-performance/replica/replica/slog/log.3356.462664068974, offset = [462664068974,<PHONE_NUMBER>66), size = 238064492
D2019-09-07 16:13:19.873<PHONE_NUMBER>873498904 1e500) replica.default0.0000e4a500010001: mutation_log.cpp:914:replay(): finish to replay mutation log /home/work/app/pegasus/c4tst-performance/replica/replica/slog/log.3356.462664068974, err = ERR_HANDLE_EOF
D2019-09-07 16:13:19.873<PHONE_NUMBER>873593538 1e500) replica.default0.0000e4a500010001: mutation_log.cpp:864:replay(): start to replay mutation log /home/work/app/pegasus/c4tst-performance/replica/replica/slog/log.3357.462902133466, offset = [462902133466,<PHONE_NUMBER>39), size = 270889873
D2019-09-07 16:13:21.035<PHONE_NUMBER>035586779 1e500) replica.default0.0000e4a500010001: mutation_log.cpp:914:replay(): finish to replay mutation log /home/work/app/pegasus/c4tst-performance/replica/replica/slog/log.3357.462902133466, err = ERR_HANDLE_EOF
D2019-09-07 16:13:21.035<PHONE_NUMBER>035664808 1e500) replica.default0.0000e4a500010001: mutation_log.cpp:864:replay(): start to replay mutation log /home/work/app/pegasus/c4tst-performance/replica/replica/slog/log.3358.463173023339, offset = [463173023339,<PHONE_NUMBER>68), size = 172386829
D2019-09-07 16:13:21.788<PHONE_NUMBER>788814689 1e500) replica.default0.0000e4a500010001: mutation_log.cpp:914:replay(): finish to replay mutation log /home/work/app/pegasus/c4tst-performance/replica/replica/slog/log.3358.463173023339, err = ERR_HANDLE_EOF
D2019-09-07 16:13:21.789<PHONE_NUMBER>789227538 1e500) replica.default0.0000e4a500010001: mutation_log.cpp:864:replay(): start to replay mutation log /home/work/app/pegasus/c4tst-performance/replica/replica/slog/log.3359.463345410168, offset = [463345410168,<PHONE_NUMBER>05), size = 180595137
D2019-09-07 16:13:22.568<PHONE_NUMBER>568888601 1e500) replica.default0.0000e4a500010001: mutation_log.cpp:914:replay(): finish to replay mutation log /home/work/app/pegasus/c4tst-performance/replica/replica/slog/log.3359.463345410168, err = ERR_HANDLE_EOF
D2019-09-07 16:13:22.568<PHONE_NUMBER>568946492 1e500) replica.default0.0000e4a500010001: mutation_log.cpp:864:replay(): start to replay mutation log /home/work/app/pegasus/c4tst-performance/replica/replica/slog/log.3360.463526005305, offset = [463526005305,<PHONE_NUMBER>54), size = 139554749

What did you expect to see?

No coredump.

What did you see instead?

#0  load (__m=std::memory_order_relaxed, this=0x3d343e3c7b553a69) at /home/wutao1/app/include/c++/4.8.2/bits/atomic_base.h:496
#1  signal (this=0x3d343e3c7b553a69) at /home/wutao1/pegasus/rdsn/include/dsn/utility/hpc_locks/autoresetevent.h:33
#2  notify (this=0x3d343e3c7b553a69) at /home/wutao1/pegasus/rdsn/include/dsn/utility/synchronize.h:99
#3  dsn::tools::native_linux_aio_provider::complete_aio (this=this@entry=0x36f6f60, io=0xe462728, bytes=2145385340, err=<optimized out>)
    at /home/wutao1/pegasus/rdsn/src/core/tools/common/native_aio_provider.linux.cpp:160
#4  0x00007f9d5ae50d01 in dsn::tools::native_linux_aio_provider::get_event (this=0x36f6f60) at /home/wutao1/pegasus/rdsn/src/core/tools/common/native_aio_provider.linux.cpp:134
#5  0x00007f9d577e5600 in std::(anonymous namespace)::execute_native_thread_routine (__p=<optimized out>)
    at /home/qinzuoyan/git.xiaomi/pegasus/toolchain/objdir/../gcc-4.8.2/libstdc++-v3/src/c++11/thread.cc:84
#6  0x00007f9d58ddedc5 in start_thread () from /lib64/libpthread.so.0
#7  0x00007f9d56f4f73d in clone () from /lib64/libc.so.6

error logs
tcmalloc: large alloc<PHONE_NUMBER> bytes == 0x6dfcc000 @  0x7f9d580f1e07 0x7f9d581141a9 0x5b5d32 0x7f9d5ad89bde 0x7f9d5ad8a2b2 0x7f9d5ad8a50e 0x7f9d5ac68b8d 0x7f9d5ac5ec76 0x7f9d5ac5ef3c 0x7f9d5ac5f47f 0x7f9d5ac60b52 0x7f9d5acd22a2 0x7f9d5acf3bfc 0x5da801 0x7f9d5adbb1e2 0x7f9d5addea7b 0x7f9d5adc6859 0x7f9d5adda50d 0x7f9d5adda6d9 0x7f9d577e5600
tcmalloc: large alloc<PHONE_NUMBER> bytes == 0x1dbd6000 @  0x7f9d580f1e07 0x7f9d581141a9 0x5b5d32 0x7f9d5ad89bde 0x7f9d5ad8a2b2 0x7f9d5ad8a50e 0x7f9d5ac68b8d 0x7f9d5ac5ec76 0x7f9d5ac5ef3c 0x7f9d5ac5f47f 0x7f9d5ac60b52 0x7f9d5acd22a2 0x7f9d5acf3bfc 0x5da801 0x7f9d5adbb1e2 0x7f9d5addea7b 0x7f9d5adc6859 0x7f9d5adda50d 0x7f9d5adda6d9 0x7f9d577e5600
task_spec.cpp:94:register_task_code():overwrite default thread pool for task RPC_CM_QUERY_PARTITION_CONFIG_BY_INDEX from THREAD_POOL_META_SERVER to THREAD_POOL_DEFAULT
task_spec.cpp:94:register_task_code():overwrite default thread pool for task RPC_CM_QUERY_PARTITION_CONFIG_BY_INDEX_ACK from THREAD_POOL_META_SERVER to THREAD_POOL_DEFAULT
main.cpp:92:main():pegasus server starting, pid(122326), version($Version: Pegasus Server 1.12.SNAPSHOT (38dccf6d774751a1f5bd67d6572c2156412979a5) Release, built with rDSN 1.0.0 (f631ed925c291ac40570fdcbd447655650a607cd), built by gcc 4.8.2, built on c3-hadoop-build03.bj, built at Sep  5 2019 16:10:19 $)
got signal id: 11

What version of Pegasus are you using?

Pegasus Server 1.12.SNAPSHOT (38dccf6d774751a1f5bd67d6572c2156412979a5)  release

I found a related issue on stack overflow, https://stackoverflow.com/questions/29824570/segfault-in-stdatomic-load. This bug was due to a bug in gcc 4.8.2, and was fixed in gcc 5.1.


Overlay audio with autogenerated closed captions (aka TTS)

Possibly leverage this open source (not the cloud service - run locally or on our servers)
https://opensource.googleblog.com/2019/08/bringing-live-transcribes-speech-engine.html

was thinking we could use NVIDIA RIVA. Did some brainstorming in Miro here:

notionally we will:
First, import the Riva API
Next, create a gRPC channel to the Riva endpoint
Then, create a ASR request

https://docs.nvidia.com/deeplearning/riva/user-guide/docs/asr/asr-overview.html#streaming-recognition


Observable return type

The return type of Observe choice is Decimal.
Should this be replaced with a sum type that allows for returning other values?

This is primarily because Observables are tied into Contingent Claims observations, which have to be decimal (at least with our current parametrization of Claim Time Decimal Id Text. Using a sum type would probably mean we have to do a lot of caseing and handle all the error cases. And it ties us to specific types.
What I could imagine is that we have a separate template that eg represents a boolean observation. But our current Lifecycle interface does tie us to a specific interface for observations, and since we cannot have type-parametrized interfaces, we couldn't use such boolean observations in our lifecycle logic.
Agree to the general thought here though, it might be handy to support other types of observations at some point.

This is also the reason why lifecycle takes a Clock.I as an input, in addition to Observables.
We could (should) rename clock to TimeObservable and Observable to NumericObservable.
Eventually the lifecycle function would take as input all possible observables (Time, Numeric, Boolean, what not ...).

I implemented the renaming in https://github.com/digital-asset/daml-finance/pull/245.
This lifts the ambiguity on the expected return type.


Add replication procs as exceptions to startup procs

Feature Request
Leave out replication procs as procs that startup procs check checks for.
New Check
What would you like to check?
What should be configurable for the results of the check ?
I need to get a full list, let me find them on MS's website.
<-- Should there be any default values for the configs? -->
Yes.

If someone can get hte full list this should be easy to implement

I will get a list for us.

That was way simpler than expected, I put this really as a placeholder to cleanup CIS checks on startup procedures but there is only on sp_MSrepl_startup and checkout the name.

Accomplished in https://github.com/sqlcollaborative/dbachecks/pull/863.


Bug 1896051: Services should not have duplicate ownerrefs

Description of the change:
This change only adds a unit test to verify that services created for apiservices installed via OLM do not have multiple ownerrefs added.
The test harness is bulky, but because this is intended to be backported, I did not attempt to refactor the related apiservice management to make testing simpler.
Motivation for the change:
This is to verify that the changes from this commit (https://github.com/operator-framework/operator-lifecycle-manager/commit/1476ff19c6a0c0a37a2fcdb47aa982683d37fee6) are included in master.
This set of changes + the above commit will be backported to older versions, to address a report of this bug in 4.5
Reviewer Checklist

[ ] Implementation matches the proposed design, or proposal is updated to match implementation
[ ] Sufficient unit test coverage
[ ] Sufficient end-to-end test coverage
[ ] Docs updated or added to /docs
[ ] Commit messages sensible and descriptive

Addresses #1237

This looks great and it looks like https://github.com/kubernetes/kubernetes/pull/96185 landing upstream will resolve this issue on the api-server side.
/lgtm

/bugzilla refresh


Is this project still active now that Black Pepper Software is closed down?

There have not been any updates to this project in over two years, and the company that this project seems to be associated with (Black Pepper Software) no longer exists.  Is this project still active, or is it now a dead project?
Black Pepper Software

A few months ago, we made the difficult decision to close down Black Pepper in August.

Yes - I (currently) intend to continue to maintain this, respond to issues and review PRs.
The lack of development recently just reflects the lack of raised issues or PRs and that I don't use this library day-to-day.
Thanks for raising this and your other issue.


Update transfer to output

Add a new tx method to get the amount for a variable output.
Update transfer_to_output to use the offsets specified in the tx library and cleaning it up a bit.

I would like if this were tested, but could always be done in a future PR

Will get it to it asap: https://github.com/FuelLabs/sway-lib-std/issues/95


Endpoint unregister

covers basic case

no confirmation modal
no per endpoint progress indicator

Codecov Report

Merging #69 into master will decrease coverage by 0.1%.
The diff coverage is 37.37%.

@@            Coverage Diff             @@
##           master      #69      +/-   ##
==========================================
- Coverage   65.76%   65.65%   -0.11%
==========================================
  Files         187      189       +2
  Lines        4384     4470      +86
  Branches      700      709       +9
==========================================
+ Hits         2883     2935      +52
- Misses       1501     1535      +34

Impacted Files
Coverage Δ

src/app/store/reducers/system-endpoints.reducer.ts
50% <ø> (ø)
:arrow_up:

...quest-data-reducer/request-data-reducer.factory.ts
34.61% <0%> (-21.64%)
:arrow_down:

src/app/store/effects/pagination.effects.ts
81.81% <0%> (ø)
:arrow_up:

src/app/store/store.module.ts
100% <100%> (ø)
:arrow_up:

src/app/store/effects/cnsis.effects.ts
33.82% <19.23%> (-1.48%)
:arrow_down:

...ared/list-configs/endpoints-list-config.service.ts
70.12% <35%> (-9.54%)
:arrow_down:

src/app/store/actions/cnsis.actions.ts
64.1% <50%> (-0.61%)
:arrow_down:

...re/reducers/api-request-reducer/succeed-request.ts
13.63% <50%> (ø)
:arrow_up:

...re/reducers/api-request-reducer/request-helpers.ts
26.22% <50%> (-1.36%)
:arrow_down:

src/app/store/actions/snackBar.actions.ts
66.66% <66.66%> (ø)

... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cf3cfab...0a63f74. Read the comment docs.


ImageDownloader setting Session's startRequestsImmediately property to false?

[x ] I've read, understood, and done my best to follow the *CONTRIBUTING guidelines.

What did you do?
Initialized an ImageDownloder with my own SessionManager (for authorizing image access)
What did you expect to happen?
I expected the SessionManager to be used for Image Downloads, but not for the startRequestsImmediately property of the SessionManager to be changed to false
What happened instead?
startRequestsImmediately property on my SessionManager is set to false, which changes the behavior of the SessionManager for all other usage
I am wondering if it is required for the ImageDownloader to set the startRequestsImmediately property to false, and if I reset it to true after initializing the ImageDownloader can I expect any issues?
Alamofire Environment
Alamofire version:
3.3.1
Xcode version:
9.2 / 9.3
Swift version:
4.0 / 4.1
Platform(s) running AlamofireImage:
iOS 11.2
macOS version running Xcode:
10.13.4
Demo Project

I am presuming that the ImageDownloder wants to control when requests are started, so it can manage a limited number of simultaneous requests... and that is maybe why it is setting this SessionManager property to false.
I think it is a worthwhile side-effect to document, if indeed it is required for the ImageDownloder.

You're correct. Unfortunately this isn't something we can really change at the moment, but a documentation PR is always appreciated.


[Contributions welcome] Implement a DepthwiseConv1D layer

Keras features a DepthwiseConv2D layer, but not yet DepthwiseConv1D. It is already implementable with existing TF ops. If you're interested in adding this feature, please open a PR.

I can implement Depthwise Conv 1D using other libraries. Kindly assign me this issue @fchollet

I'm also interested in it.


update downloadAndInsertOpenCV.sh for OCV4.0

we make it a tad easier to update too.

@Meph1k
could you take a look?

I'll take a look soon :)


Adding dushyanthsc to the member list

New member in kubeflow pipeline team.

This change is

/assign @theadactyl

/assign @abhi-g

You should add yourself to Google team and the pipelines team as well

/lgtm
/approve


Only expose SHA1 streaming api for Mozilla dist

Follow-up of #638. The previous PR was extracting all Streaming hash APIs, including some for hashes not included in dist/mozilla.
This led to some extracted files not being caught in Krml bundles, and to spurious files with extremely long names that led to failures on Windows (see the windows CI for #640).
This PR attempts to fix that by restricting the extraction of the streaming hash API for Mozilla to SHA1.
It also includes locally regenerated dist/mozilla files.

I have already seen the problem you are talking about. It seems that the main offender is Blake.
What if we do not extract the Blake family? And leave everything else?

Sounds good. Should we include everything related to hashes then?

@protz, might adding [rename=Hacl_Blake] help with the names?

Sounds good. Should we include everything related to hashes then?

yes, I think so.

Ok. Do you mind if we do that in a subsequent PR so that we can merge this one quickly and unblock CI for the dist refresh?

Sure

@Frosne it might be worth exploring if you can just cherry-pick individual files from the dist/gcc-compatible folder rather than modifying the bundles every time. Concretely, why do you need dist/mozilla? If I look at, say, Hacl_Poly1305_128.c for instance, the files are identical in both directories.
This might make the whole integration process easier for you.

Could we just extract all the code to dist/mozilla? I totally see your
point about the annoying PRs all the time :)
On Fri, 7 Oct 2022, 20:14 Jonathan Protzenko, @.***>
wrote:

@.**** approved this pull request.
This is fine to unbreak the build, but I think we need to urgently switch
to a model where
i) PRs from Mozilla are submitted properly, with a suitable dist
refresh. Is this something we can automate?
ii) Mozilla directly consumes files from the dist/gcc-compatible folder
rather than submitting PRs one by one, with a high danger of build breakage
Let's unbreak the build with this one, and then let's assess what we can
do in the long run. Thanks.
—
Reply to this email directly, view it on GitHub
https://github.com/hacl-star/hacl-star/pull/641#pullrequestreview-1134915071,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AC2OMZ5VZWSODGLSUYOUNX3WCBSBPANCNFSM6AAAAAAQ7S2PU4
.
You are receiving this because you were mentioned.Message ID:
@.***>

That would be great. But what would be the difference between dist/mozilla and dist/gcc-compatible then? Are there Mozilla-specific options? I don't think so...

A long while ago, there was a problem with excessive inclusion of headers, which meant that if you only used a subset of the files, you might end up packaging more than you needed. But that was fixed a long while ago and it was, I think, the only reason why there was a separate mozilla folder

Mozilla is an important consumer of HACL* and I wouldn't mind us maintaining dist/mozilla, but it is a good idea to recall the precise requirements for this distribution. Having a single directory like dist/gcc-compatible would be much simpler to maintain, unless there were good reason why this doesn't work?

Merging to unblock the build and dist refresh. Let's continue discussing what a better workflow would be here.


Check that tests are run with different user / rights combinations

Currently we run many tests with admin/dev rights, which doesn't match user experience

What should be checked:

coursestatistics & different right combinations
custom populations & searching for students without rights)

Refactoring:

move "login as" to shared functions in cypress


Callback loop with NuxtTurnstile

🐛 The bug
When changing the page, the turnstile box isn't properly removed and causing and infinite loop.
to reproduce it on the reproduction,

go to the form page
load the turnstile iframes
wait for it
navigate back to the homepage
open your console
check your logs

🛠 To reproduce
https://stackblitz.com/edit/github-cuqope?file=pages%2Findex.vue,pages%2Fform.vue
🌈 Expected behaviour
we shouldn't have any warning log
ℹ Additional context
I can take it, already fixed on my project :)

I noticed that too, recently. If you want feel free to submit a PR! <3

sure !

Waiting for fixing.

Oops for those interested here's the workaround atm,
within onBeforeUnmount of the compoennt wrapper NuxtTurnstile
window.turnstile.remove(str) where str is the wrapper selector + div
ex:
onBeforeUnmount(() => {
  window.turnstile.remove('#turnstile-wrapper div')
})


How to add New zsh theme

Is there an easier way to add a new zsh theme?
I wanted to modify the agnoster theme, so I copied in yadr/zsh/prezto-themes/prompt_agnoster_setup to yadr/zsh/prezto-themes/prompt_myagnoster_setup, but that wasn't enough.
I kept getting an error about plugin not found, so I then had to link that file into the zprezto modules directory, and additionally had to add in a new git repository for it (and also move the .git directory).
Is there an easier way to do this, or at least an officially documented way?

you need make a simbolic link of your theme with ln -s to ~/.yadr/zsh/prezto/modules/prompt/functions
example
ln -s ~/.yadr/zsh/prezto-themes/prompt_myagnoster_setup ~/.yadr/zsh/prezto/modules/prompt/functions/prompt_myagnoster_setup
and restart your prompt.
this works for me.

@SrEnrique this way you are overwriting the original agnoster them, no?
Turns this is already documented in the repo: https://github.com/skwp/dotfiles/blob/master/doc/zsh/themes.md
So I'm closing this issue, ok? Feel free to reopen it if needed


Better arranged links

@nostra13 hi, can u please just check this one. it's pretty straightforward to review etc, and since it's already been spent resources on, feels a bit weird to just abandon it. Sorry, but, i hope it makes sense 😅 😓

@nostra13 ping


[WIP] Request Queue

Fix #98

Current coverage is 78.87% (diff: 73.45%)

Merging #99 into master will decrease coverage by 0.55%

@@             master        #99   diff @@
==========================================
  Files            25         27     +2
  Lines          1750       1860   +110
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
+ Hits           1390       1467    +77
- Misses          360        393    +33
  Partials          0          0

Powered by Codecov. Last update f4906cc...37755d7


Updating primary ip on virtual machine doesn't work

Whenever I try to update the primary_ip attribute, it doesn't return an error, but the field is also not updated. I have tried it by doing:
vmupdate = nb.virtualization.virtual_machines.get(name="vmname")
vmupdate.primary_ip = '<IP_ADDRESS>'
vmupdate.save

Haven't done a lot of work personally with the virtualization endpoint, but I think the field on POST is .primary_ip<family> and it's a key to an ip_address object not a string. Also, you're probably looking for .save().

Hi Zach,
Thanks for getting back to me. Definitely a typo on my part missing the (). I tried the following:
vmupdate = nb.virtualization.virtual_machines.get(name='vmname')
vmupdate.primary_ip4 = 2048
vmupdate.save()
This is the error that I get:
Traceback (most recent call last):
File "./test_net.py", line 27, in
vmupdate.save()
File "/usr/local/lib/python2.7/site-packages/pynetbox/lib/response.py", line 266, in save
if req.put(self.serialize()):
File "/usr/local/lib/python2.7/site-packages/pynetbox/lib/query.py", line 270, in put
raise RequestError(req)
pynetbox.lib.query.RequestError: The request failed with code 400 Bad Request
2048 is the id associated with the IP address that I am trying to add to the specific VM. I can note that the option to add the IP address with the GUI goes as follows:

create VM
Add interface to VM
Add IP to interface and check the box to make the ip the primary interface

Do I need to reference the interface id in the API?

vmupdate = nb.virtualization.virtual_machines.get(name='vmname')
vmupdate.primary_ip4 = 2048
vmupdate.save()

hrm, yeah, that's the process on devices, which I think virtual_machines are very similar. You can get more details when a RequestError is raised if you catch and print the error attribute like so:
try:
  vmupdate.save()
except pynetbox.RequestError as e:
  print(e.error)

That might give you a better idea of what NetBox is unhappy about.


The Judgements Counter With The Source.

What is your question?
Can You Show Me How To Make The Judgements Counter With The Source Code?

Check Kade source


The way to provide vars for molecule

Issue Type
Question
As currently mentioned from docs and source there are two ways to get vars for converge stage. I have pretty big monolith repo for our opensource microservices app. During deploy i have to put at about 35 roles in correct order on different nodes.
While trying to implement testing i found molecule second time (previous was at about 1.10 version). I already has goss tests so i plan to use it as verifier.
The simplest installation as about 29 roles on one server. the main problem i have is vars.
for single server app there are 816 lines of vars. Here they are https://gist.github.com/freeseacher/2dbe848705389bb83fda7bcdb6ecdc3a
The node info was get from
./bin/ansible-inventory  -i ./bin/tower-inv  --host node1 -y
and full_list from
./bin/ansible-inventory  -i ./bin/tower-inv --list -y
Full_list file have to be in format compatible with ansible-inventory format
Of cause that vars list have to be modified to remove connectivity info and replaced with molecule provided one.
The question is how do i insert var for molecule ?
I am using molecule 2.12.1 and ansible 2.5.1

As far as i can understand logic i want to have one file with inventory for one scenario.
Both ways provided as current options looks not reasonable.
I do not have host_vars ans group_vars splited. so i can't link them.
And due of number of vars i can't place them to just hosts section

You probably want to use links.  If that doesn't work and you are using ansible >= 2.4 you could try updating provisioner.options with another inventory path (i: path/to/extra/inventory), which would result in ansible-playbook` getting an additional inventory source directory.

tnx. works for me. any ideas to document this behavior ?

You're simply using an ansible feature to add an additional inventory path.  Your situation is out of the ordinary, and don't believe it is the norm.


Training : No such File or directory "SUN2012"

Hi @yuxng ,
I tried to train the network using the script "lov_color_2d_train.sh". However, I have the following error :
OSError : [Errno 2] No such file or directory : $ROOT/data/cache/../SUN2012/data/Images'
There's indeed no directory SUN2012 but I didn't see anything about a SUN2012 folder in you explanation. What does it correspond to ?
best,
Thomas

The entire error is :
`
Traceback (most recent call last):
File "./tools/train_net.py", line 336, in
max_iters=args.max_iters)
File "/home/thomas/Desktop/Master_Project/PoseCNN/tools/../lib/fcn/train.py", line 544, in train_net
data_layer = GtSynthesizeLayer(roidb, imdb.num_classes, imdb._extents, imdb._points_all, imdb._symmetry, imdb.cache_path, imdb.name, imdb.data_queue, cfg.CAD, cfg.POSE)
File "/home/thomas/Desktop/Master_Project/PoseCNN/tools/../lib/gt_synthesize_layer/layer.py", line 36, in init
self._build_background_images()
File "/home/thomas/Desktop/Master_Project/PoseCNN/tools/../lib/gt_synthesize_layer/layer.py", line 137, in _build_background_images
subdirs = os.listdir(root)
OSError: [Errno 2] No such file or directory: '/home/thomas/Desktop/Master_Project/PoseCNN/data/cache/../SUN2012/data/Images'
`

Hi Thomas,
I suppose it refers to the SUN Database:
https://groups.csail.mit.edu/vision/SUN/
There's a link to SUN2012.


[TIC 28] Add, Subtract, and Remove button now has any functionality in cart

Description
Add, Subtract, and Remove button now has functionality
+ Increments,
- Decrements
x Removes the item in the cart prefaced with a confirmation modal.

Risks
N/A
Validation
Manual Testing
Issue
Link to corresponding issue
Operating System
Win10, Chrome

In addition, if the amount goes from 1 -> 0, the modal will pop up for removal


Install failed on Windows Universal

NuGet no longer able to install the package on a Windows Universal project with VS2015

was it able before ? I can't compile on windows universal so I don't know. What error do you have ? (sorry for the delay)

Can you also try the "NBitcoin For Mono" package ?

NuGet / Visual Studio 2015 is now able to perform the update to new release(<IP_ADDRESS>). All very strange.
The error message was "Unable to find metadata of NBitcoin xxxx".
Thanks anyway for the answer.

By the way, I am interested to know if it the lib works fine on Univeral Project, since I did not tried. Let me know.
I don't think you have access to the Node class (to connect to network) on Universal project, can you confirm ?
If it is a problem for you, you can try NBitcoin For Mono package which include everything and should also works fine on Universal.

I'm developing a client for Windows 10 in my spare time.
I'll keep you updated on the tests that will.

On universal Windows (app for Windows 10) NBitcoin.Mono fails installation with NuGet.
With NBitcoin, when launching the following code is generated an exception:
var k = new NBitcoin.Key();
System.InvalidOperationException: You must set the RNG (RandomUtils.Random) before generating random numbers
at NBitcoin.RandomUtils.GetBytes(Byte[] output)
at NBitcoin.Key..ctor(Boolean fCompressedIn)
at NBitcoin.Key..ctor()
at TestInstallNBitcoin.MainPage..ctor()
at TestInstallNBitcoin.TestInstallNBitcoin_XamlTypeInfo.XamlTypeInfoProvider.Activate_0_MainPage()
at TestInstallNBitcoin.TestInstallNBitcoin_XamlTypeInfo.XamlUserType.ActivateInstance()
at Windows.UI.Xaml.Controls.Fra

On Windows 10, PRNG uses the CryptographicBuffer. I solved this code:
public class CryptographicBufferRandom : IRandom
{
    #region IRandom Members
    public void GetBytes(byte[] output)
    {
        // https://msdn.microsoft.com/en-us/library/windows.security.cryptography.cryptographicbuffer.aspx
        IBuffer buffer = CryptographicBuffer.GenerateRandom((uint)output.Length);
        buffer.CopyTo(output);
    }
    #endregion
}

To generate the key
NBitcoin.RandomUtils.Random = new CryptographicBufferRandom();
var newKey = new NBitcoin.Key();

thanks, will be useful when I'll make a specific version for universal

Hello,
Any chance this will be solved for Windows 10?
Any code fails with this error:
using System;
using NBitcoin;
namespace Blockchain
{
class Program
{
static void Main(string[] args)
{
Key privateKey = new Key();
Console.WriteLine("Private Key: {0}", privateKey);
PubKey publicKey = privateKey.PubKey;
Console.WriteLine("Public Key: {0}", publicKey);
}
}
}

@GoldNRoll set RandomUtils.Random to an instance of CryptographicBufferRandom made by @quartsystem just above.
Windows Universal will soon support .NETStandard 2.0, so it will soon be not needed.
Actually I think this is supported, in fall creator update https://blogs.windows.com/buildingapps/2017/05/19/introducing-xaml-standard-net-standard-2-0/

Perfect, thanks!!

@GoldNRoll sorry I incorrectly diagnotised your problem, turns out you were not using UWP so my response does not apply.
I fixed the problem, now you can reference NBitcoin without the issue.

Hi Nicolas,
Perfect, I upgraded to <IP_ADDRESS> and now it works in console application :)
Visual Studio 2017 fresh install still comes with framework 4.5.2
Thank you!!


Fix links and headings in v3 (unreleased) changelog

This pull requests makes some minor fixes to the v3 (unreleased) changelog.
Do not merge until the TODO links are live.

Increase all heading levels by one, to avoid the duplicate h2 at the top.
Fix broken links to docs inside the repo.
Add links to pending guidance.

We'll want to manually update the release note with these changes too...


merge package from arlac77/npm-package-template

package.json

chore(package<EMAIL_ADDRESS>

Codecov Report

Merging #489 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #489   +/-   ##
=======================================
  Coverage   72.59%   72.59%
=======================================
  Files           1        1
  Lines         135      135
=======================================
  Hits           98       98
  Misses         37       37

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f6b7c8e...cf7a6b3. Read the comment docs.

Coverage increased (+1.07%) to 64.171% when pulling cf7a6b33f77a67c256a82b3019c1b13bd1bcbf2e on template-sync-1 into f6b7c8eb85e283b0aff43c7636c4aeff2ca64e63 on master.

:tada: This PR is included in version 2.20.2 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


[stable/prestashop] Set dependencies to the latest version

What this PR does / why we need it:
Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #
Special notes for your reviewer:
Logs:
Welcome to the Bitnami prestashop container
Subscribe to project updates by watching https://github.com/bitnami/bitnami-docker-prestashop
Submit issues and feature requests at https://github.com/bitnami/bitnami-docker-prestashop/issues

WARN  ==> You set the environment variable ALLOW_EMPTY_PASSWORD=yes. For safety reasons, do not use this flag in a production environment.
nami    INFO  Initializing apache
apache  INFO  ==> Patching httpoxy...
nami    INFO  apache successfully initialized
nami    INFO  Initializing php
nami    INFO  php successfully initialized
nami    INFO  Initializing mysql-client
nami    INFO  mysql-client successfully initialized
nami    INFO  Initializing prestashop
mysql-c INFO  Trying to connect to MySQL server
mysql-c INFO  Found MySQL server listening at coiled-possum-mariadb:3306
mysql-c INFO  MySQL server listening and working at coiled-possum-mariadb:3306
prestas INFO  Configuring webserver...
prestas INFO  Configuring PHP settings...
prestas INFO  Configuring PrestaShop...
prestas INFO
prestas INFO  ########################################################################
prestas INFO   Installation parameters for prestashop:
prestas INFO     First Name: Bitnami
prestas INFO     Last Name: User
prestas INFO     Email<EMAIL_ADDRESS>prestas INFO     Password: **********
prestas INFO     Shop Name: PrestaShop
prestas INFO     Admin URL: http://<IP_ADDRESS>/administration
prestas INFO   (Passwords are not shown for security reasons)
prestas INFO  ########################################################################
prestas INFO
nami    INFO  prestashop successfully initialized
INFO  ==> Starting prestashop...

/ok-to-test
/lgtm


Blank black screen with cmd only

I managed to get vagrant up to complete successfully with no errors.. but once its up and running its just a black window with a single cmd open?
Am I missing something? Should there not be a UI version with windows bar etc?

Welcome to Windows Server Core.
At least notepad is there 😜

The box StefanScherer/windows_2016_docker is Core only.

Hmm, doh.. what I’m going for was something I can build windows traditional
.Net Docker images with. Was hoping to do it from inside VS.
I have a Mac so wanted to us VM.
Any thoughts?
On Sun, Jun 17, 2018 at 1:14 PM Stefan Scherer<EMAIL_ADDRESS>wrote:

The box StefanScherer/windows_2016_docker is Core only.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/StefanScherer/docker-windows-box/issues/30#issuecomment-397892771,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AALkQmc5gyayx2WgHfbtCOvZqMhIAH96ks5t9o5xgaJpZM4Uq3l2
.

The other box StefanScherer/windows_2016 is with Desktop.
Either use this and install Docker with the provision scripts manually or adjust the packer-windows templates to start with the Desktop autounattend.xml instead of the Core one.

It‘s the name of a Vagrant box you can download from Vagrant Cloud.
If you prefer to build your own it‘s the windows_2016.json template in my packer-windows repo.


Improve interpolation

Clear and concise description of the problem
Hi!
I'm using vue-i18n for my Nuxt project, and be used to use react-i18next for my React Native app. And I faced a significant difference between them regarding interpolation. Currently, when we want to have something such as
Family name

, we need two distinct translations. This cause issues in the translation process: it requires two separate keys, and doesn't allow automated translation to invert words when needed (in french, it would be "Nom de famille", so "Family" and "name" would be revert).
Suggested solution
Such as in react-i18next, it would be useful to have a syntax as
{
     "familyName": "<0>Family</0> <1>name</1>"
}

, in order to let automated translation translate the content easily, and just have something as
<i18n key="familyName">

</i18n>

in our code. The output would be
Family name

Alternative
No response
Additional context
No response
Validations

[X] Read the Contributing Guidelines
[X] Read the Documentation
[X] Check that there isn't already an issue that request the same feature to avoid creating a duplicate.

This is interesting!
vue-i18n has message format. we can extend for new syntax, but vue-i18n will be extend to like Intl.MessageFormat syntax, or adopt it for future.
https://github.com/tc39/proposal-intl-messageformat
we need to more discuss for syntax

Apparently, the proposal is suggesting a syntax using {#b}text{/b} (https://github.com/tc39/proposal-intl-messageformat?tab=readme-ov-file#markup), so I guess my proposal could be a bit reworked by using {#0}Text{/0} instead of <0>Text</0>!
Feel free to reach me out if you need me for the discussions 👌🏻


Referring to another Mavenix derivation

I have one library packaged with Mavenix, and now I would like to use it in another library managed with Mavenix, and I am trying to find out how to do this.
First, I pass in drvs = [ my-dependency ];. When I now run mvnix-update, I can see "building mavenix drvs", however, in the next step, "Running mvn package...", it attempts to fetch the .jar and fails.

I think we need to install drvs using https://maven.apache.org/guides/mini/guide-3rd-party-jars-local.html

I think we need to install drvs using https://maven.apache.org/guides/mini/guide-3rd-party-jars-local.html

The mkRepo function in mavenix.nix should already take this into consideration and put the output of referenced Mavenix derivations in the right place when creating the Maven repo.
Is it possible for you to show me your code so I can run some tests?

You are correct. The repo path contained the paths as expected. I had made a mistake in the POM.


mapping in output

in output, there is no way from the config file to retrieve the detector/partition to which biases/resolutions/eff belong to. Add a key for mapping these info quickly

https://github.com/sofia-calgaro/ZeroNuFit.jl/commit/33acdecf0643c46c7158c0561aeb6d9808bb17da added info about partitions in output:

should we also add prior input as well? it can anyway be retrieved from the correct partiton file (saved alrady in output)

solved in https://github.com/legend-exp/ZeroNuFit.jl/commit/b7c0c7dccfe886adb9dd8469b7c31b98c67cf7b9


activator-seed-template: Update to Finatra RC1 release

Problem
The template is behind in releases of Finatra and Finagle
Solution
Update the template to the latest Finatra release built against the latest Finagle release (which includes the switch to finagle-httpx from finagle-http). The lastest Finatra release also includes a way to default the
http port programmatically so that we can set the port in code to not conflict with the Activator UI.
Result
An updated template that uses the latest code and doesn't require a user to start the Activator UI on a
different (other than default) port of :8888.

Ship It!


fix: reduce compiler warnings and fix non-functional test

Motivation
there are too many warnings when compiling tests @odyslam smdh
Solution
Address them :)
also fix a test that was doing nothing
PR Checklist

[x] Added Tests
[ ] Updated Documentation
[ ] Updated CHANGELOG.md for the appropriate package

先生は私を許します

許せられない罪だ


'fail' and 'cleanup' in 'depends', not as

Alternative to #666.  Because of automatic prefixing with include, the <antcall> caused problem when includeing the XSpec build file in another build file:
C:\xspec-1.4.0\build.xml:486: The following error occurred while executing this line:
Target "fail" does not exist in the project "...".

Looks like subtle difference between *nix and Windows results in test failures. I'll look into it and directly in this branch I'll align *nix ones with Windows' ones which expect line numbers more precisely.

master:
xspec:

fail:
     [xslt] Processing ...\xspec\tutorial\xspec\escape-for-regex-result.xml to ...\xspec\tutorial\xspec\escape-for-regex_xml-to-properties.xml
     [xslt] Loading stylesheet ...\xspec\src\ant\find-test-failure.xsl

BUILD FAILED
...\xspec\build.xml:484: The following error occurred while executing this line:
...\xspec\build.xml:491: XSpec tests failed. See ...\xspec\tutorial/xspec/escape-for-regex-result.html for a report.

Total time: 7 seconds

This branch:
fail:
     [xslt] Processing ...\xspec\tutorial\xspec\escape-for-regex-result.xml to ...\xspec\tutorial\xspec\escape-for-regex_xml-to-properties.xml
     [xslt] Loading stylesheet ...\xspec\src\ant\find-test-failure.xsl

BUILD FAILED
...\xspec\build.xml:488: XSpec tests failed. See ...\xspec\tutorial/xspec/escape-for-regex-result.html for a report.

Total time: 6 seconds

So the change itself seems legit. Indeed the output from this branch is cleaner.

align *nix ones with Windows' ones which expect line numbers more precisely

Done in 6d626e44a08864347a39e665157dd414e88da025.
As expected, Travis CI and Azure Pipelines (macOS) failed in the same tests as AppVeyor and Azure Pipelines (Windows).

adjust line numbers in the tests to reflect the change of this pr

Done in 665dc8482ddaa8da5e4fc61e541471e27ee6ac33.
As for Saxon-PE/EE-only tests, I verified that all the Bats tests passed on my local Saxon-EE <IP_ADDRESS>.

@tgraham-antenna
Merged this. Thanks for bringing this to attention and making this pull request based on a real use case.


Fix invalid email syntax insertion of root user

The sign in page only displays email, but not username. The email field in the record gives an invalid email that the frontend will not validate due to an incorrect syntax.

@Andrew-Chen-Wang Hi, the illa-builder (frontend) treats the root as the special user. it will bypass the email format validator. The "root" as an email login is legal.

Can you reproduce this on your end?
On my end:

docker-compose -f docker-compose-with-official-images.yml up --build
Open localhost:3000
Try entering root for email and password for password. Unable to submit due to a validation error on email field stating the email is an invalid syntax

@Andrew-Chen-Wang The default user is just for the SELF_HOST mode (use all-in-one docker image). They are:

illa deploy --self
https://github.com/illacloud/deploy-illa-manually/tree/main/docker

The docker-compose and k8s are CLOUD mode. They do not have a default user for safety reasons.
So please try deploying as SELF_HOST mode, or signup a new user in CLOUD mode.


Add more builds to M1

Display arch name in build project name
Add RerunFlakyTest and AdhocPerformanceTest for M1 mac

See https://builds.gradle.org/project.html?projectId=Gradle_Experimental&tab=projectOverview&branch_Gradle=master for the demo.

@bot-gradle test and merge

Your PR is queued. See the queue page for details.

OK, I've already triggered a build for you.


fix(rules/fence): trim info trailling whitespaces

trim trailling whitespaces from info field of the fence token

Can you please clarify why is it needed?

Can you please clarify why is it needed?

leaving as it is, this code:
'''js____
console.log('hello, world');
'''

where
' means `
and
_ means whitespace
would be parsed as:
Token {
    type: 'fence',
    info: 'js    '
}

parsing trailing whitespaces as part of the info field.
whatever is the pipeline you put parser in, one would get unnecessary data inside info field.
As an example i have a pipeline, where i feed info(which is programming language name) into library to make a decision
about how to render code, and that leads to an error unknown language js____.
where _ means whitespace

merged in https://github.com/markdown-it/markdown-it/commit/67fa0f239752ec649a3e93fe8bd7a3f410fec0f3 (with added changelog)

nvm, reverted for now, not sure if breaking change is worth it

This change is breaking, and we should force trailing spaces to drop everywhere. The concrete example can be solved via renderer, without touching everything else.


v.0.5.21

Checklist

[ ] Used a personal fork of the feedstock to propose changes
[ ] Bumped the build number (if the version is unchanged)
[ ] Reset the build number to 0 (if the version changed)
[ ] Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[ ] Ensured the license file is being packaged.

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.
I do have some suggestions for making it better though...
For recipe:

noarch: python recipes are recommended to have a lower bound on the python version. This recommendation will become a requirement in the future.
License is not an SPDX identifier (or a custom LicenseRef) nor an SPDX license expression.

Documentation on acceptable licenses can be found here.


fix(openai): enable image support on OpenAI platform only (fixes #282)

Signed-off-by: Aaron Pham<EMAIL_ADDRESS>

Didn't immediately get how to actually use this. Would it be possible to get a follow-up doc PR?


[SPARK-25075] Fix some complilation error scala 2.13 part 1

What changes were proposed in this pull request?
Adapting the code to Scala 2.13
I didn't find a specific JIRA ticket for it, so I used the umbrella ticket as a reference.
Why are the changes needed?
I'm working on adapting REPL to Scala 2.13.x.
I opened a PR for it, but it was some time ago and the code changed since, with many conflicts in respect to the master branch.
So I think it's better to open first a number of smaller PRs that compile both in Scala 2.12 and 2.13. Once the modules that REPL depends on compile, I'll open a new PR that fixed the REPL itself.
Does this PR introduce any user-facing change?
No
How was this patch tested?
export SBT_MAVEN_PROFILES=scala-2.13
./build/sbt core/compile core/test:compile

Each module has its own commit.
It was compiled Scala 2.12 as well, without the SBT_MAVEN_PROFILES variable set.

Can one of the admins verify this patch?

Can one of the admins verify this patch?

Woohoo! Nice PR!

I have these errors below. Is there a CI job testing 2.13? I couldn't find any here nor here...
[error] [warn] /home/karol/workspace/open-source/spark/core/src/main/scala/org/apache/spark/deploy/SparkSubmit.scala:656: multiarg infix syntax looks like a tuple and will be deprecated
[error] [warn]         if (opt.clOption != null) { childArgs += (opt.clOption, opt.value) }
[error] [warn]
[error] [warn] /home/karol/workspace/open-source/spark/core/src/main/scala/org/apache/spark/deploy/SparkSubmit.scala:688: multiarg infix syntax looks like a tuple and will be deprecated
[error] [warn]         childArgs += (args.primaryResource, args.mainClass)
[error] [warn]
[error] [warn] /home/karol/workspace/open-source/spark/core/src/main/scala/org/apache/spark/deploy/SparkSubmit.scala:693: multiarg infix syntax looks like a tuple and will be deprecated
[error] [warn]         Option(args.driverMemory).foreach { m => childArgs += ("--memory", m) }
[error] [warn]
[error] [warn] /home/karol/workspace/open-source/spark/core/src/main/scala/org/apache/spark/deploy/SparkSubmit.scala:694: multiarg infix syntax looks like a tuple and will be deprecated
[error] [warn]         Option(args.driverCores).foreach { c => childArgs += ("--cores", c) }
[error] [warn]
[error] [warn] /home/karol/workspace/open-source/spark/core/src/main/scala/org/apache/spark/deploy/SparkSubmit.scala:696: multiarg infix syntax looks like a tuple and will be deprecated
[error] [warn]         childArgs += (args.master, args.primaryResource, args.mainClass)
[error] [warn]
[error] [warn] /home/karol/workspace/open-source/spark/core/src/main/scala/org/apache/spark/deploy/SparkSubmit.scala:719: multiarg infix syntax looks like a tuple and will be deprecated
[error] [warn]         childArgs += ("--primary-py-file", args.primaryResource)
[error] [warn]
[error] [warn] /home/karol/workspace/open-source/spark/core/src/main/scala/org/apache/spark/deploy/SparkSubmit.scala:720: multiarg infix syntax looks like a tuple and will be deprecated
[error] [warn]         childArgs += ("--class", "org.apache.spark.deploy.PythonRunner")
[error] [warn]
[error] [warn] /home/karol/workspace/open-source/spark/core/src/main/scala/org/apache/spark/deploy/SparkSubmit.scala:723: multiarg infix syntax looks like a tuple and will be deprecated
[error] [warn]         childArgs += ("--primary-r-file", mainFile)
[error] [warn]
[error] [warn] /home/karol/workspace/open-source/spark/core/src/main/scala/org/apache/spark/deploy/SparkSubmit.scala:724: multiarg infix syntax looks like a tuple and will be deprecated
[error] [warn]         childArgs += ("--class", "org.apache.spark.deploy.RRunner")
[error] [warn]
[error] [warn] /home/karol/workspace/open-source/spark/core/src/main/scala/org/apache/spark/deploy/SparkSubmit.scala:727: multiarg infix syntax looks like a tuple and will be deprecated
[error] [warn]           childArgs += ("--jar", args.primaryResource)
[error] [warn]
[error] [warn] /home/karol/workspace/open-source/spark/core/src/main/scala/org/apache/spark/deploy/SparkSubmit.scala:729: multiarg infix syntax looks like a tuple and will be deprecated
[error] [warn]         childArgs += ("--class", args.mainClass)
[error] [warn]
[error] [warn] /home/karol/workspace/open-source/spark/core/src/main/scala/org/apache/spark/deploy/SparkSubmit.scala:732: multiarg infix syntax looks like a tuple and will be deprecated
[error] [warn]         args.childArgs.foreach { arg => childArgs += ("--arg", arg) }
[error] [warn]
[error] [warn] /home/karol/workspace/open-source/spark/core/src/main/scala/org/apache/spark/deploy/SparkSubmit.scala:741: multiarg infix syntax looks like a tuple and will be deprecated
[error] [warn]         childArgs += (args.primaryResource, "")
[error] [warn]
[error] [warn] /home/karol/workspace/open-source/spark/core/src/main/scala/org/apache/spark/deploy/SparkSubmit.scala:747: multiarg infix syntax looks like a tuple and will be deprecated
[error] [warn]         childArgs += (args.primaryResource, "")
[error] [warn]
[error] [warn] /home/karol/workspace/open-source/spark/core/src/main/scala/org/apache/spark/deploy/SparkSubmit.scala:749: multiarg infix syntax looks like a tuple and will be deprecated
[error] [warn]         childArgs += (args.primaryResource, args.mainClass)
[error] [warn]
[error] [warn] /home/karol/workspace/open-source/spark/core/src/main/scala/org/apache/spark/deploy/SparkSubmit.scala:775: multiarg infix syntax looks like a tuple and will be deprecated
[error] [warn]           childArgs += ("--arg", arg)
[error] [warn]
[error] [warn] /home/karol/workspace/open-source/spark/core/src/main/scala/org/apache/spark/deploy/SparkSubmit.scala:780: multiarg infix syntax looks like a tuple and will be deprecated
[error] [warn]         childArgs += ("--proxy-user", args.proxyUser)
[error] [warn]

There is no 2.13 CI/CD job yet - it doesn't compile, we know that. I'm submitting PRs to get much or all of it to compile, then tests will have to be evaluated.
I'm close to having everything up to REPL compiling which would allow you to at least work on the 2.13 REPL.
Those are warnings, not errors; I think your build is configured to raise them as errors. Let's only focus on errors for now as it's going to be big enough to maintain 2.12/2.13 compatibility without separate source trees already.

Ok, I won't do any more changes for now so we don't overlap, but please let me know if I can help.  Closing this PR.

Thank you for closing, @karolchmist . Thanks, @srowen .


Fix DELETE method, and trimmer router

DELETE method of /hello should remove the name.
/trimmer should return status HTTP 200 OK instead of HTTP 404.

Looks good! Thanks for the contribution.


Setting JsonInclude behavior via spring boot properties

Hi,
Trying to persist a JSON in MySQL 8.0 using JsonStringType.class. Simplified example:
public class MyEntity {
    @Type(type = "json")
    @Column(name = "custom_obj", columnDefinition = "JSON")
    private CustomObj customObj;
}

class CustomObj {
     private String str1;
     private String str2;
}

I've set spring.jackson.default-property-inclusion=non_null in application.properties, and hibernate.types.jackson.object.mapper=com.fasterxml.jackson.databind.ObjectMapper in hibernate-types.properties. The ObjectMapper instance in my project is being injected by JacksonAutoConfiguration.
With the above configuration, null values are still being serialized in the JSON. Eg. {"str1": "value1", "str2": null}. However, on using the annotation @JsonInclude(JsonInclude.Include.NON_NULL) on CustomObj, null values are excluded and result is {"str1": "value1"}.
Am I missing something or is there a need to use the annotation explicitly on every class to avoid serializing nulls?
Thanks in advance.

This article explains how to customize the Jackson ObjectMapper.
Integrating that with Spring requires consulting, so, if your company is interested in employing my consulting services to help you with this issue, just let me know.


events without end date

Now the is possibility in google calendar to create events without end date. But currently widget shows these events as if their duration is one hour. Can this be corrected so that widget shows only start time without end time?

@lexa1 As I tested now, adding or changing events so that they won't have end date in Google Calendar is impossible now. Neither in Android nor via Web.


UserInfo does not check for declared key usage when selecting encryption key

While building the userInfo response the provider fetches the client keys and then merely picks the first with a non-empty kid, without checking it's intended usage.
If the client exposes 2 keys, one for signing and one for encryption, the provider by picking the first will either:

pick the right one (by luck) just because it is the first in the list
pick the wrong one and use the sig key against it's intended usage

https://github.com/italia/spid-cie-oidc-django/blob/2b0c2eff271ef290f90f62ba8b7a3d508b887543/spid_cie_oidc/provider/views/userinfo_endpoint.py#L95
        for k in client_jwks:
            if k.get('kid') and len(k["kid"]) >= 1:
                client_jwk = k
                break

the lookup happens with the key, since the key usage is not defined in the current specs
the issue is confirmed here https://github.com/italia/spid-cie-oidc-django/blob/2b0c2eff271ef290f90f62ba8b7a3d508b887543/spid_cie_oidc/provider/views/userinfo_endpoint.py#L94C1-L94C1
the approach would be instead using this function by passing the jwt and the attested jwk set
https://github.com/italia/spid-cie-oidc-django/blob/b7b28a8fbb59076dc8d7ba389383379282547315/spid_cie_oidc/entity/utils.py#L57
if you can do that, please open a PR, I'll be happy to review it and merge and having a new release with your formal contribution

Ok, we just have to create a utility function, like this https://github.com/italia/spid-cie-oidc-django/blob/b7b28a8fbb59076dc8d7ba389383379282547315/spid_cie_oidc/entity/utils.py#L57 where an jwks is passed and an argument set(enc, sig) to get the first key according to the scope
in the current specs we don't have defined this detail about the key but it is a good practice having different keys for different scopes

Fixed in https://github.com/italia/spid-cie-oidc-django/pull/311


Allow IS for all txes, not only for txes with p2pkh and data outputs

Rebased after #1761 merge and reworded commit description


When is the next patch release date? PHP 8.1 Doctrine compatibility.

Multiple fixes have landed since the last release in may, and especially changeset https://github.com/microsoft/msphpsql/pull/1408 fixed multiple issues.
If I'm honest (maybe it's my Dutch directness, sorry for that) :
Without that fix, I'd consider SqlServer to be incompatible with PHP8.1 + Doctrine.
We've got a pretty big application, but this is our only blocker still left to upgrade to PHP 8.1
May I ask if and when a new patch release is to be expected?

There is no ETA for a fix in 5.10. However the fix will definitely be in the 5.11 release. Beta 5.11 is targeting early Dec with GA at the end of January.

This is also the only blocker for us to go to PHP 8.1, also with a moderate application using Doctrine.

+1 especially considering the README claiming to support PHP 8.1

As of now, 8.1 is supported. Close this old issue.


Integrate with codecov

Description
codecov is an online tool that allows projects to monitor their code coverage. It integrates nicely with python's coverage module, which we are already using. The codecov people have a free service plan that open source projects can use so this does not have any cost for the pycsw project.
This issue is a follow-up to the decision that has already been made in a the 2017-05-10 developer meeting that we will go ahead and integrate with codecov.
Tasks to accomplish:

[x] hook up codecov into our CI
[x] collect information about unit and functional tests
[ ] add a coverage badge to pycsw's README document

We've decided to add the coverage badge later, so I'm closing this one as most of the work has been done in #525


[rpclib]Update to 2.2.1

Update rpclib to version 2.2.1

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: i6-xx sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.


No devices on the home screen

I do not have any devices that show up on my home screen though I have a ZSeries connected and I am able to update recipes to it through the server.  Based on the Demo Server, I expect to see the ZSeries device Waiting to Brew

I have the server running on a Raspberry Pi 3 Model B though, it was initial setup on a Raspberry Pi 4 8GB and swapped to the RPi3 due to WiFi connection issues.  I have connected the ZSeries to the server both over WiFi and ethernet and in both situations the ZSeries device did not show up.  I know that I am connected to the server because I see the recipes on the ZSeries change as I change them on the server.
The server was setup with ps_server_beta5.zip as found in the release section and then was updated to the latest repository code through the built in Update/Restart Server.  The About shows the server is running the latest code.  I have power cycled the RPi and the ZSeries and the same results still exist.
I am not sure what to look at next.  Any guidance would be appreciated.

Upon the first session the card display will populate.
The alternative to get a persistent card is to add an alias entry to the config.yaml (I have an open PR to do this from within the web UI itself vs ssh or samba file sharing).
If you run a rinse, clean or a brew session you should see the graph populate. This is because we took the approach of relying on "session" data for presentation here. Though I'm starting to think just to simulate a creation of a session upon any network request to the server.

For the PR mentioned see, https://github.com/chiefwigms/picobrew_pico/pull/171

@tmack8001 thanks for the explanation.  I ran a drain and now it appears.  I will make sure I address this in the user manual to try and help others in the future.

Awesome. Honestly it shouldn't be much work for me to just more aggressively creating the internal "session" just without a chart. Basically forcing the "waiting to brew" state. Though would be good to include that if it doesn't show up run a quick drain, rack, rinse or clean cycle.


Finetuning eole with OpenNMT-py model checkpoints

Hi,
I am experimenting with eole training for bilingual MT models. I can successfully train a model with eole from scratch using wmt17 recipe. However I also want to see if I can fine-tune my legacy opennmt-py models with eole. With opennmt, it was possible to load a model checkpoint using train_from parameters. But for eole it seems from code that it expects a model directory with checkpoint, config.json and vocab.json files. Is there a way to convert opennmt checkpoint files (.pt) to this required format?
Thanks

not so easy but read this: https://github.com/eole-nlp/eole/discussions/76


Add RHOC (aka Rchain)

Website: https://www.rchain.coop/
Contact Address: https://etherscan.io/address/0x168296bb09e24a88805cb9c33356536b980d3fc5#code

I guess this can be considered completed

and closed!


Fix bug in std::auth::get_coins_owner()

The changes needed are:

a pre-check on the value of inputs_count:  i.e: assert(inputs_count < 1);
return a ResultAuthError::NoCoinInputs from the code path where inputs_count is set to 1, but there are no InputCoins.
This leads to the while loop exiting, but candidate still being Option::None. Then, when trying to return a Result::Ok value the function will revert when unwrapping candidate.

Discovered by @emilyaherbert
cc @adlerjohn

a pre-check on the value of inputs_count

This isn't really necessary, if the user is expected to do the check themselves beforehand. Would be duplicating the check.

but there are no InputCoins

The consensus rules require that valid transactions must have at least one coin input. So that case should never be hit for valid transactions.

https://github.com/FuelLabs/fuel-specs/pull/353 should be landed soon to avoid having to deal with offsets!


Relax ErrorDetailsValues types matching

What changed?
Relaxed ErrorDetailsValues types matching.

Why?
Current check is too strict, because it requires types to match exactly.
Relax that, so that it can be assigned to any matching interface.

How did you test it?
Added additional unit test.
Without relaxation, this unit test fails with:
unable to decode argument: cannot set *internal.testErrorStruct value to error field

Potential risks

Pull Request Test Coverage Report for Build 74e6aaf5-2b42-486c-942c-ca9ecde22e7b

1 of 1 (100.0%)  changed or added relevant line in 1 file are covered.
15 unchanged lines in 2 files lost coverage.
Overall coverage decreased (-0.01%) to 74.633%

Files with Coverage Reduction
New Missed Lines
%

internal/internal_task_pollers.go
2
72.21%

internal/internal_worker_base.go
13
80.46%

Totals

Change from base Build f092ce86-f458-47f0-8ad7-14d36aa77015:
-0.01%

Covered Lines:
9350

Relevant Lines:
12528

💛  - Coveralls


DayView for location in CalendarView?

I'm adding iOS 11 drag and drop support (UIDropInteractionDelegate) to my app and I would like to be able to determine the relevant DayView based on the coordinates of a drop in a CVCalendarView. Items would be dragged to the calendar, dropped on any date, then the date is changed for the dropped items.
I'm able to get the correct coordinates for the drop within the CVCalendarView, but I still need to determine the date based on these coordinates.
Is there an elegant way to get the DayView from a CGPoint in a CVCalendarView?

For reference, here is the code I'm currently using. I've tested it with the calendar in .weekMode and it works well.
func dayView(for location: CGPoint, in calendarView: CVCalendarView) -> DayView? {
    if let weekController = self.calendarView.contentController as? CVCalendarWeekContentViewController,
        let weekView = weekController.getPresentedWeek() {

        for dayView in weekView.dayViews {
            let dayRectInCalendar = dayView.convert(dayView.bounds, to: self.calendarView)
            if dayRectInCalendar.contains(location) {

                return dayView
            }
        }

    } else if let monthController = self.calendarView.contentController as? CVCalendarMonthContentViewController {

        for weekView in monthController.presentedMonthView.weekViews {
            for dayView in weekView.dayViews {
                let dayRectInCalendar = dayView.convert(dayView.bounds, to: self.calendarView)
                if dayRectInCalendar.contains(location) {

                    return dayView
                }
            }
        }
    }

    return nil
}


Show error message to user if the data files is messed up!

This happens with overlapping_session and when dependencies are not found


Scoping FE for Adding "direction of effect" data

We need to scope DoE results visualisation for the following 8 data widgets:
"ot_genetics_portal",
"gene_burden",
"eva",
"eva_somatic",
"gene2phenotype",
"orphanet",
"impc",
"chembl"

See this ticket for BE details.
Relevant API field/responses are:
1)variantEffect (values= LoF/GoF/Null)
2)directionOnTrait (values=Risk/Protective/Null)

Preliminary visualisation suggestions here- now with hovering text

Proposed names of the two new columns (happy to her different opinions):

Direction of Effect (variant)
Direction of Effect (trait)
They both should have a tooltip with following text: See [here] for more info on our assessment method - with link to the doc page that will describe assessment method (from @Juanmaria-rr)

Proposed positions of the two new columns within each widget (as discussed today with FE team @chinmehta ):

OT Genetics: the two new columns should be added between Variant consequence and Associations p-value
Gene Burden: columns between beta and p-value
ClinVar: columns between Variant Consequence and Clinical significance
ClinVar somatic: between Clinical Significance and Allele origin
Gene2phenotype: columns between Functional consequence and Allelic requirement
Orphanet: columns between Functional consequence and Allele origin
IMPC: columns between Mouse phenotypes and Mouse model allelic composition
chEMBL: columns between MoA and Phase

Just an update for the team: @chinmehta has prepared a slide deck with different visualisations options and will present them at the AOTF meeting tomorrow.

Header:

Direction of Effect (heading) - combined columns makes sense

No variant / trait subheader (i.e. no subheader) as Variant is not a good header

Icons:

trend arrows for variants (GoF up, LoF [down (https://fontawesome.com/icons/arrow-trend-down?f=classic&s=solid))

exclamation - risk

half shield - protect

Also, we have to keep in mind the icons for version 2 as they will be probably moving next in the AOTF column

Also, it might be better to keep the icons easier to change / abstraction

Links for the tooltip for the direction of effect column: @chinmehta

OT Genetics: https://platform-docs.opentargets.org/evidence#open-targets-genetics
Gene Burden: https://platform-docs.opentargets.org/evidence#gene-burden
ClinVar: https://platform-docs.opentargets.org/evidence#clinvar
ClinVar somatic: https://platform-docs.opentargets.org/evidence#clinvar-somatic
Gene2phenotype: https://platform-docs.opentargets.org/evidence#gene2phenotype
Orphanet: https://platform-docs.opentargets.org/evidence#orphanet
IMPC: https://platform-docs.opentargets.org/evidence#impc
chEMBL: https://platform-docs.opentargets.org/evidence#chembl


Automate selected dependency updates using renovate

Expected Behaviour
We get PRs created by the Renovate App ( https://github.com/renovatebot/renovate/ / https://www.mend.io/renovate/ ) for dependencies that we want to keep up-to-date with. We can start with the Sling CP Converter.
I am happy to do the work for this issue, but first I would like to see if others think this is a good idea. The impact would be that once a new version of the CP Converter is out, we get a PR updating it, and we get to decide when/if it is merged.
Actual Behaviour
PRs need to be manually created.
Reproduce Scenario (including but not limited to)
N/A
Steps to Reproduce
N/A
Platform and Version
N/A
Sample Code that illustrates the problem
N/A
Logs taken while reproducing problem
N/A

I think we close this then, thanks @cziegeler . Let's monitor what PRs get sent and we'll figure out if the config needs to be adjusted.
This was https://github.com/adobe/aemanalyser-maven-plugin/pull/216 .


Value extractors for container types not working (List, Map, Set, Optional)

Expected Behavior
When having a constraint on a container type, e.g.:
Optional<@Vocab(IDENTITY_CLASS) String> getIdentityClass();

I would expect the validation to occur.
Actual Behaviour
The validator does not get called.
Steps To Reproduce
Add a constraint to any container type and then validate. The validator never gets called.
Environment Information
Mac OS 14
Java 17.0.2-tem
mn-validator 4.2.0
Example Application
No response
Version
4.2.0

Pls create an example project

I'm working on it at the moment. It's quite complex as it's STIX.
I think the problem may be the fact I am using the Immutables.io library to generated the implementations. The @Vocab constraint is in the interface and is noy copied to the implementation. Hibernate Validator seems to find it in the superclass. Maybe that is the problem?

I've pushed the code:
git clone  https://github.com/KangoV/stixj/tree/mn-cal-bug-261
git checkout mn-cal-bug-261

Run ./gradlew test -i | grep "VOCAB", you will see the following log output:
    20:39:49.315 [Test worker] DEBUG i.k.stix.validation.VocabValidator - !VOCAB!
    20:39:49.320 [Test worker] DEBUG i.k.stix.validation.VocabValidator - !VOCAB!

This means the the VocabValidator has been called (it doesn't do anything else yet).
Now edit io.kangov.stix.core.sdo.objects.Identity and change the following code (line 103), from
    @JsonProperty("identity_class")
    @Redactable(useMask = true)
    @Vocab(IDENTITY_CLASS)
//    Optional<@Vocab(IDENTITY_CLASS) String> getIdentityClass();
    Optional<String> getIdentityClass();

to
    @JsonProperty("identity_class")
    @Redactable(useMask = true)
//    @Vocab(IDENTITY_CLASS)
    Optional<@Vocab(IDENTITY_CLASS) String> getIdentityClass();
//    Optional<String> getIdentityClass();

so that the constraint is no longer in the container type, but at the method level.
Now run ./gradlew test -i | grep "VOCAB" again, you will not see those two log lines. This means that the validator is now not called.
I hope this makes sense.

It does seem that there are extractors for

Iterable
List
Map Key
Map Value

in io.micronaut.validation.validator.extractors.InternalValueExtractors
I'm wondering if they are just not activated? Or somehow just switched off?

We have known problem with generics annotations not being inherited. Can you try to duplicate then on the implementation?

I simplified an example which demonstrates the constraint on a container type not being found:
@MicronautTest
public class ValidationTest {

    @Inject
    Validator validator;

    interface Interface {
        Optional<@Min(0) Integer> value();
    }

    @Introspected
    record Record(Optional<Integer> value) implements Interface {}

    @Test
    void test() {
        var violations = validator.validate(new Record(Optional.of(-1)));
        assertThat(violations).hasSize(1);
    }
}

This is basically what I have. I have Record implementing Interface which the Introspection on interface.

Ok, it seems that bean Introspection is working:
Found BeanIntrospection for type: class io.kangov.stix.common.ValidationTest$Record

but, if I change the code to this:
@Min(0)
Optional<String> value();

I get....
jakarta.validation.UnexpectedTypeException: Cannot find a constraint validator for constraint: jakarta.validation.constraints.NotBlank and type: class java.util.Optional
	at io.micronaut.validation.validator.DefaultValidator.validateConstrains(DefaultValidator.java:1391)
	at io.micronaut.validation.validator.DefaultValidator.visitElement(DefaultValidator.java:1109)
	at io.micronaut.validation.validator.DefaultValidator.visitElement(DefaultValidator.java:1047)
...

Where is the @NotBlank defined?

Oop, not sure how that got there. I've updated the code above. I have created my own constraint and replace @Min. It gets called at the method level (for which I have to unwrap the optional, but is not found at all at the container level (if the constraint is in the interface).
If the constraint is on the actual record itself, it works:
@Introspected
record Record(@Minimal(0) Optional<Integer> value) implements Interface {}

But as i am generating the implementation classes with Immutable.io, I cannot do that.

Can you please update your project with the failed example?

Apologies for the delay. Trying to reorganise the project a bit better.
There are two objects to be aware of:

io.kangov.stix.v21.core.sdo.objects.Identity - The interface that Immutables will create the implementation from
io.kangov.stix.v21.core.sdo.objects.IdentityImpl - The generated implementation

The attribute under test is:
    @JsonProperty("roles")
    Set<@Size(min=2) String> getRoles();

There is a couple of assertions in test io.kangov.stix.v21.core.sdo.objects.IdentityTest.test_Roles_below_min.
The test simply injects the Validator, set the correct object state to (hopefully) trigger a violation and perform the validation.
The test fails.
Note that the generated IdentityImpl does have Introspected added.
All in same branch as before:
git clone https://github.com/KangoV/stixj/tree/mn-cal-bug-261
git checkout mn-cal-bug-261
./gradlew build

I hope this helps. Let me know if you need anything else.

I've dug into this a little more. Given the following:
Set<@Vocab(PROCESSOR_ARCHITECTURE) String> getArchitectureExecutionEnvs();

@Vocab just tests to see if each element is in a given vocabulary of strings.
In DefaultValidator method visitContainer, there is this code:
if (!isValidated(containerArgument)) {
    return false;
 }

which calls isValidated(containerArgument):
private <E> boolean isValidated(Argument<E> containerArgument) {
    return containerArgument.getAnnotationMetadata().hasAnnotation(ValidatedElement.class);
}

which always returns false.
The containerArgument is Set architectureExecutionEnvs.
The isValidated(containerArgument) returns false so the whole visitContainer method returns false, resulting in the container never getting validated.
Could this be the problem?

I think the issue is that ValidatedElement is only used in the DefaultValidator and only in 2 test clauses. The text says that this annotation is used to trigger cascading. But, I cannot see anywhere in the code that adds that annotation to the metadata of an argument.
I would assume that i should never use this directly as it says it's for internal use only.
As this annotation is never present, container validation cannot take place.

ValidationVisitor is adding it, to simplify runtime traversal

If you use IntelliJ it will not show classes on the annotation processor classpath https://github.com/micronaut-projects/micronaut-validation/blob/master/validation-processor/src/main/java/io/micronaut/validation/visitor/ValidationVisitor.java

It looks like you are hitting a problem with annotations of generics not being inherited https://github.com/micronaut-projects/micronaut-validation/pull/228

@dstepanov @graemerocher you can close. It's already fixied


Upgrade crypto library to version 0.31.0

CVE-2024-45337
Applications and libraries which misuse the ServerConfig.PublicKeyCallback callback may be susceptible to an authorization bypass.
Description: https://github.com/open-horizon/vault-exchange-auth/issues/79
Test:

@bencourliss pls merge


cannot build via webpack with node target

Hi, I followed the wiki about webpack (https://github.com/visionmedia/superagent/wiki/Superagent-for-Webpack)
but it don't work.
Here is a MWE.
% cat package.json
{
  "name": "demo",
  "version": "1.0.0",
  "description": "",
  "main": "index.js",
  "scripts": {
    "test": "echo \"Error: no test specified\" && exit 1"
  },
  "author": "",
  "license": "ISC",
  "dependencies": {
    "superagent": "^4.1.0"
  },
  "devDependencies": {
    "webpack": "^4.29.6"
  }
}

% cat webpack.config.js
const webpack = require('webpack');

module.exports = {
  target: 'node',
  entry: __dirname + '/index.js',
  output: {
    path: __dirname + '/build',
    filename: 'demo-node.js'
  },
}

% cat index.js
import superagent from 'superagent'

I got this failure:
% node --version
v11.9.0
% node
> require('./build/demo-node')
Thrown:
TypeError: n is not a function
    at Object.<anonymous> (/usr/home/iblis/tmp/demo/demo/build/demo-node.js:7:9158)
    at i (/usr/home/iblis/tmp/demo/demo/build/demo-node.js:1:172)
    at Object.<anonymous> (/usr/home/iblis/tmp/demo/demo/build/demo-node.js:7:9041)
    at i (/usr/home/iblis/tmp/demo/demo/build/demo-node.js:1:172)
    at Object.<anonymous> (/usr/home/iblis/tmp/demo/demo/build/demo-node.js:1:4629)
    at i (/usr/home/iblis/tmp/demo/demo/build/demo-node.js:1:172)
    at Module.<anonymous> (/usr/home/iblis/tmp/demo/demo/build/demo-node.js:7:3119)
    at i (/usr/home/iblis/tmp/demo/demo/build/demo-node.js:1:172)
    at /usr/home/iblis/tmp/demo/demo/build/demo-node.js:1:964
>

Hello @iblis17 – v5.0.0 was just released to NPM and an updated README is now available here on GitHub (see https://github.com/visionmedia/superagent#superagent).
What's new

Browser version is now only 19KB (that's 60% in file size savings from v4.x which was 48KB)!
Codebase refactored using xo, prettier, remark, and more
Browser compatibility linting via eslint-plugin-compat
Browserslist integration (current targets are > 1%, last 2 versions, ie 9)

How to install
npm install superagent@latest

Or if you're using yarn:

yarn add superagent@latest

Polyfills
Please see the Required Browser Features section in the README if you plan to support IE 9 and/or IE 10 and use superagent.


Using single relay for testing relay (testing using multiple profiles) does not work with one or more nostr clients

client initiating action
coracle
client receiving or observing action (or lack thereof)
coracle
timestamp
@mleku
https://njump.me/nevent1qqsys0e9e4mwk2pl3lh8fd7lrrxlqnsj5cr0evxuch70tt8yw4l6q4cpzamhxue69uhkxcfwdaexzmn8v4cxjmrv9ejx2aspz4mhxue69uhkummnw3ezu6twdaehgcfwvd3sz9nhwden5te0wfk8jtnwdaehguntd9jzucm0d5q3xamnwvaz7tmjv4kxz7tpvfkx2tn0wfnstuvclh
what happens

there is a really big problem brewing in #nostr

there is no client to test a relay with

the clients all have logic to try other relays all the time for whatever reasons

the clients don't show clear information about the status of connections with relays

the clients for whatever reason decline to send messages to the relays

i set up three users all connected to one relay and have them all follow each other and nothing comes up on the #coracle  feed page, though i can copy the links to the posts each one makes and see them in the others

how can i test that my relay works if the client assumes it can't rely on one relay to see events?

i tried to talk some sense into @mikedilger  about this, about how his gossip client refuses to respect any kind of settings for choice of relays and @hodlbod  's client is almost good with NIP-42 but fails because it's running off on its own picking relays to talk to

EVEN WHEN I HAVE SET ONLY ONE AND SET ONLY ONE IN FORCE_RELAYS

there is no way to test a relay standalone in this entire ecosystem right now

you can't be sure your relay is working, it's not possible to be sure it's working, the client doesn't let you be sure, none of them

if anyone knows of a client that does, i'm all ears but at this point it looks to me like i'm going to be building a basic CLI client so i can at least depend on it

suggestion

FORCE_RELAYS works as intended (except when initially logging in), I welcome evidence to the contrary.

FORCE_RELAYS works as intended (except when initially logging in), I welcome evidence to the contrary.

it works on and off, it's very patchy at best, and definitely stops working when only one relay is set in all the fields of .env
i've lost patience with trying to get it to work properly, i was making a chat bot and because of the need for it to auth and the lack of full support of that, likely due to it not respecting my relay settings, i have given up and i can make nostrudel work perfectly, instantly propagating DMs and notes between 3 separate accounts in 3 separate browse profiles with very little difficulty
i'm fine to not use coracle as my test rig, just letting you know you can't use it this way, but it's great for end users

Cool, I'll look into it. Relay selections desperately need to be refactored.


Default state of the relay after startup...

Hello,
The relay always comes on after startup. I tried to uncomment "int relayState = HIGH;" and compile the firmware again, but nothing changes and the relay always changes state after startup of ESP8266MOD.
Thank you!

It looks like GPIO12 pulses HIGH for a fraction of a second then goes low each time the module starts up. Is there any ways to avoid that?


Queue improvements

This PR adds a few queue improvements. Closes #122.

Replaced track IDs to track queue indexes

Functions that used to reject with track_not_in_queue or invalid_id will now reject with index_out_of_bounds when the index is invalid.

Added move(index, newIndex) - Moves a track from an index to another.

Returns a promise, rejecting with index_out_of_bounds when any of the indexes are invalid.

Added shuffle() - Shuffles the queue using the Fisher-Yates algorithm.

Returns a promise, resolving when the shuffle is finished.

Added setRepeatMode(mode) - Updates the repeat mode:

REPEAT_OFF - doesn't repeat.
REPEAT_TRACK - loops the current track.
REPEAT_QUEUE - repeats the whole queue.

Added getRepeatMode()

@dcvz I still need to work on the JS side, docs and testing, but all of the native code for Android is already there. Let me know what do you think about these changes.

From a quick look, this looks great! I'll work on the iOS implementation of this soon :)

Any progress?

@Guichaguri
This will be a great addition and a major improvement to the module.
however, ditching the old "by-id" methods will introduce a breaking change, it would be nice if we could keep them. For instance, the architecture of our app revolves around unique IDs we recieve from our back-end service.
internally we have implemented the following methods:

addByIndex
removeByIndex
shuffle
shuffleFromIndex
move
skipbyIndex
updateMetadataForTrackByIndex
setRepeatMode
getRepeatMode

the native logic behind these methods are virtually identical to the methods you've implemented in this branch.
I think it would be a great if we could keep the old methods as a means of backwards compatibility.

Also we added the following methods as an improvement to the Q system:
-updateTrack
-updateTrackbyIndex
these methods will update the media source as well as metadata in case we have to change a TrackObject programmatically.
let me know if this isn't considered to be an anti-pattern so I can make a pull request.

Hi,
Any updates on this?

@Drazail We're working on v2 to improve the API and intentionally make breaking changes. We certainly could implement a backwards-compatible layer, but I don't see a reason why we should.

Not everyone has unique IDs for their tracks, they would have to implement a system to create IDs for them
If they do have unique IDs, they wouldn't be able to add the same track twice without creating two separate IDs
I've seen many cases that they lookup the queue array to find the ID of a track based on index, for then the module to translate the ID back into a index.

That being said, I don't see a reason to keep IDs in an API design standpoint.
The compatibility layer can also be implemented in pure JS, it's not like it needs native code in order to work.

@Guichaguri
well, backwards compatibility is generally considered to be a major reason to keep the API consistent between different releases.
As for pure JS implementation of a backward compatible layer, even if it was a viable option from a performance standpoint, that's really not something to be delegated to the end user.
Anyways, at this point, our fork and this repo are so different that I understand trying to keep the API similar doesn't worth the effort.

@Drazail I'm still thinking about whether or not we should get rid of IDs, the big advantage is that the IDs stay the same no matter the position of the track in the queue.
So I guess we should keep both. It shouldn't hurt to have the ID-based functions in the library. Making the native functions such as skip(), getTrack() or move() use indexes and implementing functions like skipToId(), getTrackById(), moveById() in pure JS:
async function skipToId(id) {
    const queue = await TrackPlayer.getQueue();
    TrackPlayer.skip(queue.findIndex(track => track.id === id));
}

We could also make a separated file just as a v1 compatibility layer built on top of the new API:
import TrackPlayer from 'react-native-track-player'
TrackPlayer.skip(index)

import TrackPlayer from 'react-native-track-player/v1'
TrackPlayer.skip(id)

So updating it will be as easy as changing the imports, so you don't have to update all the code to the new API at once, you can update it as you go. What do you think?

Another idea could be to use immer to mutate the queue: https://github.com/immerjs/immer
Allowing for:
TrackPlayer.changeQueue((queue) => {
  queue.pop();
  queue.unshift({ track });
  queue[2].title = "another title";
});

@puckey That looks good, but how the native code would react to these changes?
We could send the whole queue to the native code and then update track by track, but that's too much overhead if you have a big queue and only want to change the title of a specific track.
It looks like Immer has patches, which we could potentially parse and apply through native code, but that would require too much code and testing on our side, basically having to recreate that library in native code.
We could also implement a simpler diff algorithm that would only send the tracks that had been updated to the native code, that needs more thought but could work.
Another possibility would be to implement our own "queue" class that has the same functions as an Array but apply those changes using the API currently in place.
At this point I think we should create a new issue for discussing utility functions (library compatibility, React classes and hooks, etc)

@Guichaguri
I do agree that the implementation we used is bloating the API, and the second option you suggested is probably the way to go.
However, there's another idea of the top of my head: restrict ID types to be strings. this can help the module decide which layer ( compatibility layer or the core API) should handle the call, ie:
TrackPlayer.skipTo("foo") skips to "foo" id
TrackPlayer.skipTo(3) skips to the 4th track in Q
I personally prefer to give users as many options as possible while keeping the API as stable and as simple as possible hence reducing the barrier of entry, but then again, as you have more knowledge of this library than anyone else, this comes down to what you think is the more appropriate behavior.

I'm with @drazail all the way. It makes sense to me,especially the string vs int.

Any updates on this?

@dcvz I still need to work on the JS side, docs and testing, but all of the native code for Android is already there. Let me know what do you think about these changes.

Well done @Guichaguri, Have you finished the Js part, if yes, when should we expect this PR to be merged?

Any update on this yet?

Any update on this yet?

This branch was merged with only the changes to an index based queue.
Other queue methods like:

move(index, newIndex)
shuffle()
setRepeatMode(mode)
getRepeatMode()

will be added separately as a different effort because they are complex and affect the notifications system. At the moment I am trying to prioritise getting a stable build of v2 out.


Fix typo in get_send_status method name

resolves Azure/azure-sdk-for-python#28408

@msyyc Could you please review and merge this? Thanks!

@msyyc I believe this is the wrong place to make this PR. So, I've made this one on the main repo.
Could you confirm if I am right about this? If so, we can close this PR out.

@PramodValavala-MSFT I merged https://github.com/Azure/azure-sdk-for-python/pull/28485 and let us see whether it can be resolved.

@msyyc Looks like the other PR didn't resolve it apart from having the README file updated in the repo. 😄

@PramodValavala-MSFT I don't have access to merge the PR. Maybe @danieljurek can help.

Package-level overview files are updated in the docs repo when the package releases. Opening PRs in both this repo and the SDK repo is the correct process if you want to fix an issue on the live docs without releasing a new package. I'll approve and merge this.


Refactor featurization into class objects

This PR adds a framework for feature generation. There is a base class that outlines the required methods and provides the workflow for feature generation. The derived classes implement methods for the actual creation of the feature object.

Base feature class
Derived class DeltaQFeatures
Derived class DeltaQFeaturesSingle
Feature generation classes.pdf

@LindaHung-TRI Do you mean having two base classes Supervised and Unsupervised? Right now there are several other assumptions that might prevent more general use of this feature class. Primarily we are assuming that self.X is a pandas dataframe, which might not be suitable for some features that are inherently higher dimensional objects.

I'm not entirely sure what to call the new class, but my main thought is that the existence of features should be decoupled from how they're being used in the model. In this specific example of aggregation of cycling data into features, the "outcome" (number of cycles_to_reach_set_capacities) is also feature of the specific cycler run.  Note that when I say "feature", I don't mean an input to the model, but rather a distinguishing statistic / aggregation of the data.
One way to decouple features and how they're used if to have both a features class, plus a ModelXY (or ModelDataset, or some better name) class. The ModelXY class will be the one that takes features that have been generated, as well as lists of "X" names and "y" name(s), to prepare the X and y dataframes. ModelXY can further be subclassed to supervised and unsupervised, if desired, but as @patrickherring-TRI said, that's probably not too important for this project.
Especially if you're testing a variety of outcomes, it'll be convenient to have all relevant data aggregated in the featurization framework, and then you can swap out X and y as appropriate.

@LindaHung-TRI I refactored the code slightly to accomodate a single feature object that can be either input or outcome depending on how we want to use it. Let me know if this is closer to what you were thinking? Happy to also jump on a video call tomorrow if that would be a better venue.

Yes, looks good! And much more concise than my long comments above.


[Bug]: Add support for Ubuntu 22.04; Generated .ovpn file errors out

Make sure your check these beforehand!

[X] Issues - https://github.com/angristan/openvpn-install/issues
[X] README and FAQ - https://github.com/angristan/openvpn-install
[X] Wiki - https://github.com/angristan/openvpn-install/wiki
[X] Discussions - https://github.com/angristan/openvpn-install/discussions

Server OS
Ubuntu 22.04
OpenVPN version
2.5.5
Client
Windows 10
What is the bug?
I am running the installation script on Ubuntu 22.04 with default settings. The setup finishes without any error. Even the client .ovpn file generation also finishes without error. But when I try to connect my client to my server, I see this:

I tried investigating myself and found this while generating client file:
Note: using Easy-RSA configuration from: /etc/openvpn/easy-rsa/vars
Using SSL: openssl OpenSSL 3.0.2 15 Mar 2022 (Library: OpenSSL 3.0.2 15 Mar 2022)

Easy-RSA error:

Missing expected CA file: ca.crt (perhaps you need to run build-ca?)
Run easyrsa without commands for usage and command help.

Client windows-client added.
cat: /etc/openvpn/easy-rsa/pki/ca.crt: No such file or directory
awk: fatal: cannot open file `/etc/openvpn/easy-rsa/pki/issued/windows-client.crt' for reading: No such file or directory
cat: /etc/openvpn/easy-rsa/pki/private/windows-client.key: No such file or directory

I know something is erroring out here. But I don't have much knowledge to proceed debugging.
The installation script used to work without any error on Ubuntu 20.04.
Relevant log output
...
   3) Remove OpenVPN
   4) Exit
Select an option [1-4]: 1

Tell me a name for the client.
The name must consist of alphanumeric character. It may also include an underscore or a dash.
Client name: windows-client

Do you want to protect the configuration file with a password?
(e.g. encrypt the private key with a password)
   1) Add a passwordless client
   2) Use a password for the client
Select an option [1-2]: 11
Select an option [1-2]: 1

Note: using Easy-RSA configuration from: /etc/openvpn/easy-rsa/vars
Using SSL: openssl OpenSSL 3.0.2 15 Mar 2022 (Library: OpenSSL 3.0.2 15 Mar 2022)

Easy-RSA error:

Missing expected CA file: ca.crt (perhaps you need to run build-ca?)
Run easyrsa without commands for usage and command help.

Client windows-client added.
cat: /etc/openvpn/easy-rsa/pki/ca.crt: No such file or directory
awk: fatal: cannot open file `/etc/openvpn/easy-rsa/pki/issued/windows-client.crt' for reading: No such file or directory
cat: /etc/openvpn/easy-rsa/pki/private/windows-client.key: No such file or directory

The configuration file has been written to /home/ubuntu/windows-client.ovpn.
Download the .ovpn file and import it in your OpenVPN client.

EasyRSA  v308 does not support OpenSSL version 3.

Any prediction on how long the wait will be?
Meanwhile is there any workaround except downgrading OpenSSL?

Personally, I think using Ubuntu to test OpenSSL 3 was a bad decision.
I would roll back to Ubuntu 21.

Seems like there has been a lot of progress on OpenVPN/easy-rsa, thanks to @TinCanTech.

Using SSL: openssl OpenSSL 3.0.2 15 Mar 2022 (Library: OpenSSL 3.0.2 15 Mar 2022

The reason for this initial problem is that Easy-RSA did not support OpenSSL version 3 until Easy-RSA version 3.1.x
Easy-RSA version 3.1.x now supports OpenSSL version 3. However, I recommend waiting for Easy-RSA version 3.1.1, which is due out very soon.

Easy-RSA 3.1.1 is available, tried to change the "local_version" variable in the script from 3.0.7 to 3.1.1 but still getting the same errors. what else needs to be changed?
Thanks alot, John.

I prepared a patch for this. Checked on a clean Ubuntu installation with the latest updates installed. Checked with AUTO_INSTALL=y flag.
705c705
< 		local version="3.0.7"
---
> 		local version="3.1.1"
728c728,729
< 		echo "set_var EASYRSA_REQ_CN $SERVER_CN" >>vars
---
> 		# EASYRSA_REQ_CN can only be used by commands build-ca and gen-req
> 		#echo "set_var EASYRSA_REQ_CN $SERVER_CN" >>vars
732c733
< 		./easyrsa --batch build-ca nopass
---
> 		./easyrsa --batch --req-cn=$SERVER_CN build-ca nopass
739c740
< 		./easyrsa build-server-full "$SERVER_NAME" nopass
---
> 		./easyrsa --batch build-server-full "$SERVER_NAME" nopass
894c895
< ncp-ciphers $CIPHER
---
> data-ciphers $CIPHER
1086c1087
< 			./easyrsa build-client-full "$CLIENT" nopass
---
> 			./easyrsa --batch build-client-full "$CLIENT" nopass
1090c1091
< 			./easyrsa build-client-full "$CLIENT"
---
> 			./easyrsa --batch build-client-full "$CLIENT"

I'm not sure about the correctness of this solution, but it works for me.

Sorry for the delay everyone, this is finally fixed in master.

Thanks @zerodivisi0n for the patch 🙏

Then why do i still get this exact error ?

Do you want to protect the configuration file with a password?
(e.g. encrypt the private key with a password)

Add a passwordless client
Use a password for the client
Select an option [1-2]: 1
tail: cannot open '/etc/openvpn/easy-rsa/pki/index.txt' for reading: No such file or directory
./openvpn-install.sh: line 1088: ./easyrsa: No such file or directory
Client elry added.
cat: /etc/openvpn/easy-rsa/pki/ca.crt: No such file or directory
awk: fatal: cannot open file `/etc/openvpn/easy-rsa/pki/issued/elry.crt' for reading: No such file or directory
cat: /etc/openvpn/easy-rsa/pki/private/elry.key: No such file or directory

The configuration file has been written to /root/elry.ovpn.
Download the .ovpn file and import it in your OpenVPN client.


Feature/local terraform

Addresses https://github.com/buerokratt/Infrastructure/issues/4 - Infrastructure: Setup terraform to provision infrastructure from dev machine
NB: the contents of the PR are an experimental (but fully functional) setup but will be copied over to the Infrastructure repo in another issue.
Addresses the following Acceptance Criteria

Terraform structure is setup to allow for local and CD pipeline terraform execution
Provision AKS cluster, KeyVault
Documentation for local dev environment setup (set seeing up local dev env)

A Makefile is provided to make it easy to provision the necessary infrastructure for a basic AKS cluster and Key Vault, credentials can be entered using a tfvars file allowing local terraform execution
Below shows the created resource groups and associated resources:
Resource Groups - one is created by default by aks

General Resource Group Resources

AKS Cluster Resource Group Resources

@Adele-Churchill-13, which issue is this PR for? I don't see any issue tagged and it is not clear which of the active issues in the sprint this is for? Is it https://github.com/buerokratt/Infrastructure/issues/5?

@Adele-Churchill-13, I've worked out that this PR is for buerokratt/Infrastructure#4 from the previous sprint.
It cannot be tagged because the PR and issue are in different repos, which seems odd. What was the reason for that?
If the PR is correctly in the "cross" repo, can we move the issue so that it can be tagged to the PR?

This task followed on from the Base Terraform which has initially been added to the Cross Functional Requirements repository, at the time of development the intended place for this feature was being restructured, due to sprint end and MS1 approaching the decision was made to progress with the task in the current repository - with plans to migrate to the Infrastructure repository

@Adele-Churchill-13, I've worked out that this PR is for buerokratt/Infrastructure#4 from the previous sprint.
It cannot be tagged because the PR and issue are in different repos, which seems odd. What was the reason for that?
If the PR is correctly in the "cross" repo, can we move the issue so that it can be tagged to the PR?

This task followed on from the Base Terraform which has initially been added to the Cross Functional Requirements repository, at the time of development the intended place for this feature was being restructured, due to sprint end and MS1 approaching the decision was made to progress with the task in the current repository - with plans to migrate to the Infrastructure repository

Just adding to what @Adele-Churchill-13 said, here is the ticket to move this work into the infrastructure repo:
https://github.com/buerokratt/Infrastructure/issues/12
She also mentioned in the PR description that the intention is to move a lot of this over.


Would be awesome to have example images and/or artifacts to see 🙏

Image added! Also, there are some little improvements in the documentation 😉

Love it, thank you!


Feat: build xcframework

Purpose
Support creation of xcframework that can be used later on as base for CP / SPM dependency.
Usage
cd bindings
./build.sh
Results
.xcframework file with properly aligned headers and .modulemap which is needed to properly see public interface

Next steps
Now that there is xcframework, it still should be used along Stableswap.swift and SwiftBridgeCore.swift files, as they wrap direct Rust bridging interface
Now either podspec or spm package definition can be created to use this as library

Thank you! Done in a separate PR