Schema enums follow up (part 2)

Follow-up to #605 and #626.

@roji You asked previously about some code that looked like this:
// Alter operations may not have a default schema attached. If not, try to attach one for schema-qualified types.
if (operation[RelationalAnnotationNames.DefaultSchema] == null)
    operation[RelationalAnnotationNames.DefaultSchema] = model[RelationalAnnotationNames.DefaultSchema];

I think my previous answer was incomplete. Completely removing that code in #626 worked because #605 had some (unintentionally) hackish code that covered up the root of the issue by accessing the model as a fallback when a schema was unavailable for an enum.
It was a bit confusing to unwind, but I think the root of the issue is that we weren't yielding the default schema annotation from NpgsqlMigrationsAnnotationProvider.For(...) which meant that AlterDatabaseOperation wouldn't have access to it, and so a PostgresEnum or PostgresRange on that operation wouldn't have access to it either.
I've changed that here, such that NpgsqlMigrationsAnnotationProvider.For(...) now yields the default schema annotation, and everything is back to passing (without the hacks).

@roji I think this is very close to ready, but there are some changes since your last review that I'd like to get your OK on before merging.
Specifically:

PostgresEnum.Labels now has a private setter, which is used in place of calling SetData directly.
I've removed the schema-less overload for PostgresEnum.GetOrAddPostgresEnum(...). An equivalent form is still available via model.Npgsql().GetOrAddPostgresEnum(...).
I've removed PostgresEnum.FindPostgresEnum, which was only used within PostgresEnum and wasn't necessary. If this type of functionality is needed down the road, we could provide it via something like model.Npgsql().FindPostgresEnum.
I've removed PostgresEnum.BuildAnnotationName(...), per your review, as it was no longer necessary.
I've updated PostgresEnum.GetData() to push the responsibility of returning a null-membered tuple down to PostgresEnum.Deserialize(...). We were doing a null-check there anyways, so this just reduces some branching.

These changes are focused on simplifying PostgresEnum so that responsibility for convenience wrappers resides with classes like NpgsqlModelAnnotations.
Also note I've split changes that were unrelated to the annotations into #724.

@austindrenski thanks for continuing to work on this. I'm not going to review again because of the DefaultSchema binding question - see my comment above. Once we resolve all that I'll give this another full review.

Thanks for continuing the work on this @austindrenski. I took a deeper dive into this and discovered some other problems, I'm sorry for not having done this before suggesting the MigrationsAnnotationsProvider approach. I know this is getting pretty long, but I think we'll get there soon.
First a more minor point. This PR indeed changes the binding of the default schema as discussed, but it also changes the API of PostgresEnum in general - the constructor now includes the previous "get or add" functionality, a new static CreateAnnotation() is an IAnnotation factory, Labels is no longer modifiable... When I first wrote PostgresEnum a while ago, I based it off the EF Core support for Sequence, which is also an annotation managed on the model (after all, both are non-table, database-wide objects) - this is why the general API shape came from. As elsewhere, I believe there's a lot of value in keeping as aligned with how things work in EF Core, even if sometimes we think we can factor things better - it makes it very easy to switch between EF Core and EFCore.PG, and things work in a similar way. This is why I'm not too excited about redoing the general shape of PostgresEnum and friends.
This led me to reexamine how Sequence is implemented and interacts with migrations in general. Although at the metadata level it's just an annotation on the model (like our enum), with a Sequence object (similar to our PostgresEnum) to manage it, at the migration level it has special support in MigrationsModelDiffer - the latter detects it specifically much like it detects tables, and generates special {Create,Drop}SequenceOperation which the MigrationsSqlGenerator then renders into SQL. A long time ago, when I first started modelling PostgreSQL extensions (this was the first PostgreSQL-specific object I did), I actually started modifying the ModelDiffer (a bit like you suggested), but ran into some issues and the recommendation from the EF Core team was to avoid it - which is why everything is implemented as annotations instead, all the way into NpgsqlMigrationsSqlGenerator. For 3.0 we may want to revisit this, and reimplement extension/enum/range cleanly in the ModelDiffer. This would also move the new/delete/alter detection from the MigrationsSqlGenerator to the differ, where they conceptually belong. 3.0 would be the right milestone for this, as we can get any API required changes into ModelDiffer as necessary.
Even more important... When you change the DefaultSchema in EF Core, the ModelDiffer actually picks that up and generates Rename operations for all objects with an unspecified schema (so you get lots of RenameTable() and RenameSequence() calls in the new migration). This is implemented by having the annotation itself contain an empty/null schema, but having the Sequence.Schema property return the default schema in that case (a bit like a previous version for this PR. So when the ModelDiffer compares the old list of sequences to the new, it detects the rename and generates a RenameSequenceOperation.
From a cursory look, I don't think it's possible for us to match this behavior with our annotation-only approach (i.e. without changing ModelDiffer). The ModelDiffer detects annotation changes, but the enum annotation itself hasn't changed at all - it still has a null schema; the separate DefaultSchema annotation is the one that changed.
Since we can't implement the standard EF Core behavior here (automatic rename on change of DefaultSchema), I suggest we not try to do anything fancy and leave things as simple as possible, and as close as possible to EF Core. This seems to be to do the same thing as Sequence - leave the schema null in the annotation, and return DefaultSchema from the schema property. This should create the annotation in the default schema initially, but not support automatically moving it if the default schema is changed (impossible to implement at the moment). We can definitely revisit this for 3.0.
Again, it's my fault for suggesting a bad path of work for you without looking deeper (sorry, many things going on at the moment...). I hope it's OK for you to revert this work and align it with EF Core as suggested above - or of course to propose any other approach for discussion.
PS IMHO we should maintain alignment with the EF Core codebase even when doing minor refactoring. For example, this PR moves PostgresEnum accessor properties to the top of the file, presumably because in some styles fields and properties come before constructors and methods. However, EF Core's Sequence.cs was written in a different style, which I think we should keep. I don't consider this terribly important and it's OK for us to deviate on this kind of thing - but I think it's important to always have the EF Core source code & design in front of you when making EFCore.PG changes, to be aware of exactly where we're deviating etc.

Adding to my already insanely-long message above, here's the old discussion on extending our own ModelDiffer and providing custom migration operations: https://github.com/aspnet/EntityFrameworkCore/issues/6524. This is useful because it discusses why we didn't end up going down that road - but it may be worth revisiting two years later.

Opened #730 to discuss the ModelDiffer/custom migration question again.

First a more minor point. This PR indeed changes the binding of the default schema as discussed, but it also changes the API of PostgresEnum in general - the constructor now includes the previous "get or add" functionality, a new static CreateAnnotation() is an IAnnotation factory, Labels is no longer modifiable...

I recognize that these are departures from the previous design, and I can roll back some of it (e.g. file layout), but we do need some of these changes. For example, CreateAnnotation(...) is what allows us to robustly return annotations in the annotation provider that are potentially different from the annotation that is actually serialized in the model.
Regarding the mutability of Labels, my primary concern is what would actually be mutated? Is it the model, a migration operation, a scaffolding model? The impact of setting that property depends on what the underlying annotation is, and if the underlying annotation is intended to be mutable.
With those questions outstanding, and since we don't (yet!) support altering enums, I would rather keep these as immutable as possible, at least until we start to support alter operations on them.

Since we can't implement the standard EF Core behavior here (automatic rename on change of DefaultSchema), I suggest we not try to do anything fancy and leave things as simple as possible, and as close as possible to EF Core. This seems to be to do the same thing as Sequence - leave the schema null in the annotation, and return DefaultSchema from the schema property.

That works for me. But I think that this does require something like CreateAnnotations(...) to keep the annotation provider as clean as possible.
I'm open to other ways to accomplish this, but I settled on the current design because it reduced the need to duplicate annotation logic and kept the "serialization" logic inside of PostgresEnum.

I've updated the PR to rollback some of the obvious stuff and rework the point of access for the default schema. Let me know how that looks, or if you think more needs to be rolled back (i.e. if settable properties are critical).
I'll update the other PRs now, but don't worry about looking at them yet, I just want to make sure the patterns/logic look good in the other metadata classes too.

I recognize that these are departures from the previous design, and I can roll back some of it (e.g. file layout), but we do need some of these changes. For example, CreateAnnotation(...) is what allows us to robustly return annotations in the annotation provider that are potentially different from the annotation that is actually serialized in the model.

My point was that this was not actually something we should be doing - I took back my idea of translating the model enum annotation into a different annotation for the migrations... The reasoning is that if the user doesn't specify a schema for the enum, then the generated migration should actually not contain the default schema (again, I reversed what I had previously written). Instead, the migration code should contain null for the schema - just like table and sequence do - and the binding should only occur very late, at the SQL migration phase. I recommend taking a look at Sequence.cs for inspiration on how PostgresEnum.cs should look like, even if they're not going to be identical.
Just to be extra clear: my change of mind here really stemmed from a misunderstanding of how EF Core works... If a user doesn't specify a schema, the resulting migration should not contain a schema - even if the actual object gets creating in the default schema - and if the default schema later changes, then EF Core moves the object from the old default schema to the new one, at that very moment. Keeping the schema null is in fact required in order to be able to detect objects which were created in the (previous) default schema; if the schema were baked into the annotation, we wouldn't be able to know whether the user specified it (in which case it shouldn't move) or whether it was just the default (in which case it should).

Regarding the mutability of Labels, my primary concern is what would actually be mutated? Is it the model, a migration operation, a scaffolding model? The impact of setting that property depends on what the underlying annotation is, and if the underlying annotation is intended to be mutable.

That's a valid question... I think that the mutability of the metadata (i.e. the annotations) isn't the same as our capability to carry out the corresponding change in the database. In other words, there may be scenarios where the metadata is simply built incrementally by the user, i.e. they interact directly with PostgresEnum to build the list of values based on some logic, rather than using the ForNpgsqlHasEnum() extension method. Don't forget that PostgresEnum, as well as NpgsqlModelAnnotations and the rest are completely public and accessible to the user. I think that's the point behind allowing mutation - just as a way of building the metadata on the model.
I'll really try to be available tonight (your morning) so we can have some online time together to discuss all this.

OK, cleaned up and ready for review.

OK, the only notable divergence in the public API is the removal of the schema-free overload to GetOrAddPostgresEnum.
Personally, I don't see the value in that overload since the annotation classes provide user-friendly overloads, but I can revert to include it if you think it still has some value.

@roji Just updated. Are you able to initiate the release of 4.0.4 (driver + plugins)?


Restructuring

Restructure repository as discussed in #12
Closes #12

[x] Move tools such as pt2ts.py to a utils directory with a readme
[ ] Move examples to examples directory with a simple readme

[x] Move examples
[ ] Detailed documentation elsewhere
[x] Remove examples from build and install process

It occurs to me that we may want to use these simple ts_inference examples for testing, but we can address that in #4
It may also be that we want even simpler self-contained examples (not relying on TorchVision).


WEB_ASSET_PATH needs a description fix

We have a lot of envvars that point as default root using the base data directory plus path for picking up data, like the list printed in the admin docs also see the default location of the base data path. These envvars use a standard description text reflecting the situation.
The WEB_ASSET_PATH has as default the base data path set and needs therefore a description fix to reflect this (just missed to be added when it was created) like:
... If not defined, the root directory derives from $OCIS_BASE_DATA_PATH:/web/assets.

Closing, I was looking into 5.0, but in master we have: The WEB_ASSET_PATH is deprecated...


Adding functionality to pass projects while listing templates/images

Functionality to allow users to pass the projects to list the templates/images.
Corresponding robottelo PR: https://github.com/SatelliteQE/robottelo/pull/10765/files

The unit tests failures all appear to be related to the 'hawkular' provider -- not related to the changes here.


[GHSA-9wv6-86v2-598j] path-to-regexp outputs backtracking regular expressions

Updates

Affected products
Description

Comments
https://github.com/pillarjs/path-to-regexp/pull/324

Hi there @blakeembrey! A community member has suggested an improvement to your security advisory. If approved, this change will affect the global advisory listed at github.com/advisories. It will not affect the version listed in your project repository.
This change will be reviewed by our Security Curation Team. If you have thoughts or feedback, please share them in a comment here! If this PR has already been closed, you can start a new community contribution for this advisory


404 at: /installation/windows/

URL: /installation/windows/ is 404. (https://docs.docker.com/installation/windows)
The referring page is: [https://docs.docker.com/machine/install-machine/]
You guys still looking for a tech writer?
--William

/installation/windows/ is also referenced in kitematic/index.md, leading to a 404
I noticed the alias: /installation/mac in https://github.com/docker/docker.github.io/blob/master/docker-for-mac/index.md
and the lack of a similar alias (/installation/windows) for https://github.com/docker/docker.github.io/blob/master/docker-for-windows/index.md
I'd like to take this one, but I need a bit of guidance.
Would a change be needed in https://github.com/docker/docker.github.io/blob/master/_data/redirects.csv ?


Nuget

Hi,
Are you planning to publish a Nuget package to use it easily ?
Regards,

Hi,
It's a good idea, I will do it before the end of this week.
Best regards
Le mer. 3 févr. 2021 à 14:56, reegeek<EMAIL_ADDRESS>a écrit :

Hi,
Are you planning to publish a Nuget package to use it easily ?
Regards,
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/macgile/DataGridFilter/issues/1, or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAEM52PBSQB2JM5POPMLHFLS5FIY3ANCNFSM4XA4WG5Q
.

Hi,
The package Nuget is available : NuGet
Best regards


Add secondary sub menu to extension button popup

I would like to add a backup secondary language list to the settings page. So that if Netflix ever breaks the layout again, we can fall back to this menu in the settings page and the extension can keep working.
If possible, the backup menu should only be visible if the regular injection in the web-player fails (bonus: show a warning on screen to make the user aware of this). It may not be possible to check this reliably (because the secondary menu is only injected when the subtitle menu is visible). As an alternative, the menu should be small and not add bulk to the settings page. Layout should be kept as simple and small as possible, ideally just a select box with languages.
PR welcome.

Netflix Dual Subtitles - Subtitle Translator can do it.


Check if :FZF is already executing

Hi, Junegunn!
Prior to this change, you'd get a longer error message if you did:
:FZF
<esc>
:FZF

The main problem being that :file [FZF] can be used only once. This commit uses that to its advantage and just adds a simple bufexists('[FZF]') check (and a warning message, that you can remove if you want).
 :)

Merged, thanks!


API v2 support

Hi
Please add v2 version api support.
Thank you

Hello, library was updated with CoinGate API v2 support.


Update First-Time Robot Setup Guide for Modern Gazebo

Fixes #608.

[x] Update setup_odom.rst
[ ] Update setup_sensors.rst
[ ] Add tutorial for SDF.

First of all, a huge, huge thank you for taking this on, it really helps alot to get some support in updating documentation :-)

You are welcome! Thanks a lot for appreciating the effort.

I'm wondering if we should possibly create new pages for the odometry, sensors (in addition to the SDF we've already discussed) and leave the current pages alone. That would let you start fresh (which would probably make this easier honestly than trying to shoe horn the changes in) and also let us on the Index page docs.nav2.org/setup_guides/index.html allow people to choose their adventure for GZ Classic or Modern GZ if they're still on Humble. Unfortunately Humble is supported until mid-2025, so there will still be alot of GZ Classic users around for awhile.
Basically what I'm thinking is to have 2 parallel table contents, one for GZ and another for GZ Classic. They'd both share the Transformations and URDF tutorials, but the Odometry, Sensors, and SDF would change by simulator -- and then the Footprint / Plugins would again be the same. That would also give us a recipe to work with for adding support for new simulators in the future
Then once that passes, we can just delete those changes to complete the migration. What do you think? I think that would make your life easier by being able to have more control on the flow of the guide page and code blocks instead of trying to make a 1:1 analog.

Those ideas do sound good to me. I'm not sure what you mean by "2 parallel table contents." Could you go into a bit more detail about that/how to implement it?

In the index page, we have a section called "Table of Contents" where we list those guide pages. Instead, we could have 2 separate sections, one for GZ Modern and another for GZ Classic where we link the appropriate versions of the pages. For some, they'll be the same page (URDF, Footprint), but for others they'll change (the ones you're working on).
that would give us the tutorials for both up simultaneously and give you more free reign on the Modern GZ pages to break from the existing where things change more easily


Copy request to 2.0 API endpoint returns status monitoring URL to 2.1 API endpoint

Category

[ ] Question
[ ] Documentation issue
[x] Bug

Expected or Desired Behavior
I expect POST /me/drive/items/{item-id}/copy return status monitoring URL to the same version of API.
Observed Behavior
POST /me/drive/items/{item-id}/copy returns status monitoring URL that belongs to a different API version (2.1 in this case). It creates problems because operation status-checking URL differ between 2.0 and 2.1 API versions.
Steps to Reproduce
Real-life example.
Request
POST /_api/v2.0/drive/items/<REDACTED>/copy/ HTTP/1.1
Host: <REDACTED>
User-Agent: python-requests/2.18.4
Accept-Encoding: gzip, deflate
Accept: */*
Connection: keep-alive
Authorization: Bearer <REDACTED>
Content-Length: 125
Content-Type: application/json

{"parentReference": {"driveId": "<REDACTED>", "path": "test_folder"}}

Response (some headers are omitted for brevity)
HTTP/1.1 202 Accepted
Expires: -1
Location: https://<REDACTED>/_api/v2.1/drive/operations/<REDACTED>

Thanks @AndrewPashkin. What kind of issues do you encounter with the swap? Theoretically the monitor URL should be opaque, and the final redirect (if appropriate auth is provided) should still hit the v2.0 endpoint.

@ificator
For example instead of percentageComplete key 2.1 uses percentComplete. And also 2.1 omits this key when status equals complete.

@ificator, also resourceId is absent when status is not complete in 2.1 unlike in 2.0.

Thanks for pointers! The percentageComplete vs percentComplete discrepancy is a bug, so we'll discuss internally about what to do for that - it obviously should not have changed with this switch.
The other two issues are an artifact of the change that drove the switch to v2.1 for the monitor URLs - in the past the copy was never truly asynchronous, which is why v2.0 always returned percentageComplete=100.0, status=complete, and resourceId=<something> on the first request. We have since made the copy truly asynchronous, which means the resourceId value is not known until status=complete (which may require numerous polls to encounter) and so there isn't much we can do on that front.
In regards to the lack of percentage when status=complete the thinking was that complete implies 100% so we could save bytes on the wire by not including it. That's something we can look at changing if it's useful for your scenario.

@ificator,

The percentageComplete vs percentComplete discrepancy is a bug, so we'll discuss internally about what to do for that - it obviously should not have changed with this switch.

Alright.

We have since made the copy truly asynchronous, which means the resourceId value is not known until status=complete

That makes sense.

In regards to the lack of percentage when status=complete the thinking was that complete implies 100% so we could save bytes on the wire by not including it.

For me it's more a backwards-compatibility issue, because my old code ceased to work and I had to make some adjustments.


Release checksums

It'd be really handy if you would include checksums of the binaries for each release

Apologies for the delay @mogopz, v5.5.1 should have the checksums attached to the release. There was a bit of an issue automating the release process, but now future releases should have this too.


Error when using unsupported NDK directory

Currently if you attempt to use these rules with NDK 21, you get cryptic failures because of broken assumptions. This is expected to fail in general but it would be nicer if the rules reported a clear error for this case instead

the native version of android_ndk_repository reads source.properties:
https://github.com/bazelbuild/bazel/blob/818c5c8693c43fe490c9f6b2c05149eb8f45cf52/src/main/java/com/google/devtools/build/lib/bazel/rules/android/AndroidNdkRepositoryFunction.java#L535
it would probably be pretty straightforward to do something similar in the Starlark version


Read content based on content-length and do not rely on newlines

This change is needed (as far as i can tell), in order to use stdin and stdout as the interface for the debug adapter. I have tested with vscode and confirmed that this fixes the following errors:

Input was not being read, as there is no newline seperator after the content.
Output was not being flushed (on my machine), likely because there is no newline.

I decided the easiest thing to do was to combine the Sep and Content states, and read the content based on content-length, while keeping the rest of the loop based on read_line.
I'm still new to rust and what is considered best practices, so please point any mistakes or inefficiencies (especially error handling trips me up)
Edit: The reason the testinput file works is because read_line also terminates at EOF.

Thanks for the feedback, its much appreciated 😀


[BUG]: PLAYWRIGHT_SERVICE_RUN_ID no longer supported?

Describe the bug
Since 1.0.0-beta.4, the test run ID can no longer be set with PLAYWRIGHT_SERVICE_RUN_ID.
To Reproduce
Steps to reproduce the behavior:

Set env var PLAYWRIGHT_SERVICE_RUN_ID=some-test-run-id
Run tests
Resulting test run ID is not some-test-run-id

Expected behavior
PLAYWRIGHT_SERVICE_RUN_ID controls run ID. If not, please update documentations:

https://learn.microsoft.com/en-us/azure/playwright-testing/quickstart-automate-end-to-end-testing
https://learn.microsoft.com/en-us/azure/playwright-testing/playwright-testing-reporting-with-sharding

Screenshots
If applicable, add screenshots to help explain your problem.
Setup information (please complete the following information):

Azure Subscription Id:
Workspace Name:
Service trace Id (if available):
Log snippet (if available):
Browser on which tests are executed (if applicable):
Time range (in PST) when the issue was experienced:
Playwright Version:
Client machine OS:
OS requested on Service:

Additional context
Due to this? https://github.com/Azure/azure-sdk-for-js/commit/497321f0400ba4a2adfbd8f59db62d7574b52824
Thanks!

Hi @cthlo
Thanks for writing to us.
We don't have the variable PLAYWRIGHT_SERVICE_RUN_ID in the service package. You can still use it by adding run id in the playwright.service.config.ts file like this:
runId:process.env.PLAYWRIGHT_SERVICE_RUN_ID
You can then define PLAYWRIGHT_SERVICE_RUN_ID as environment variable. I will update the docs to add this line in playwright.service.config.ts file

Hi @cthlo Thanks for writing to us. We don't have the variable PLAYWRIGHT_SERVICE_RUN_ID in the service package. You can still use it by adding run id in the playwright.service.config.ts file like this:
runId:process.env.PLAYWRIGHT_SERVICE_RUN_ID
You can then define PLAYWRIGHT_SERVICE_RUN_ID as environment variable. I will update the docs to add this line in playwright.service.config.ts file

Thanks, @vvs11
I'm a little confused as it used to work prior to the 1.0.0-beta.4.
I'll give runId a try, but I'm curious if it was intentionally removed.
Thanks!
Per the documentations,
Quickstart: Set up continuous end-to-end testing with Microsoft Playwright Testing Preview

playwright.service.config.ts:
import { defineConfig } from '@playwright/test';
import { getServiceConfig, ServiceOS } from '@azure/microsoft-playwright-testing';
import config from './playwright.config';

/* Learn more about service configuration at https://aka.ms/mpt/config */
export default defineConfig(
  config,
  getServiceConfig(config, {
    exposeNetwork: '<loopback>',
        timeout: 30000,
    os: ServiceOS.LINUX,
        useCloudHostedBrowsers: true
  }),
  {
    /*
    Playwright Testing service reporter is added by default.
    This will override any reporter options specified in the base playwright config.
    If you are using more reporters, please update your configuration accordingly.
    */
    reporter: [['list'], ['@azure/microsoft-playwright-testing/reporter']],
  }
);

GitHub Actions:
- name: Run Playwright tests
    working-directory: path/to/playwright/folder # update accordingly
  env:
    # Regional endpoint for Microsoft Playwright Testing
    PLAYWRIGHT_SERVICE_URL: ${{ secrets.PLAYWRIGHT_SERVICE_URL }}
    PLAYWRIGHT_SERVICE_RUN_ID: ${{ github.run_id }}-${{ github.run_attempt }}-${{ github.sha }}
  run: npx playwright test -c playwright.service.config.ts --workers=20

Use Microsoft Playwright Testing Reporting with Playwright sharding (preview)

You can use Playwright Testing's reporting feature to get a consolidated report of a test run with sharding. You need to make sure you set the variable PLAYWRIGHT_SERVICE_RUN_ID so that it remains same across all shards.

The PLAYWRIGHT_SERVICE_RUN_ID variable is an identifier that is used by Playwright Testing service to distinguish between test runs. The results from multiple runs with same RUN_ID are reported to the same run on the Playwright portal.
By default, a test run that uses reporting feature automatically generates a unique RUN_ID unless you explicitly set the value yourself. If the value of the variable remains same across runs, the results are reported together in the same run on the Playwright portal.


surface: fix place_below handling

If a subsurface is being placed below a subsurface right above it, this
should be a noop. However, node pointed to the subsurface that was
moved, which resulted in subsurface->parent_pending_link being
inserted into itself, breaking parent's pending subsurface list.
This commit separates finding the requested node and getting it's prev
field, fixing the issue.

Is there the same issue with place_above?

No, place_above works correctly, as it doesn't require prev field.

Hm. Do you have a reproducer for the issue?

wleird/subsurfaces works.
Run it and try placing green subsurface below blue one. Nothing should change, but it changes.


How to completely remove AzTs from the subscription/tenant

I tried to remove it manually (by removing RG and MI), but when I started the new installation, the web UI component was not installed. However, there weren't any errors. I suppose there might be services that I didn't remove last time.

Hey @DImaste,
Please make sure you are passing the [-EnableAzTSUI] flag while deploying.
Please feel free to contact us at<EMAIL_ADDRESS>


Fixes minuteman for named VIPs with 2 or more ports in use

This change fixes minuteman for named VIPs with 2 or more ports in use

🚢


Go to top button added

Added functionality to go to top + create /assets/script folder to hold script files

@fbeyl Had to resolve merge conflicts - can you review and ensure it's working as expected before I merge?

Seems ok to me.


Wait for client isRunning=false in MsgCliApiClient.getClientInfo

@famartinrh The time calculations look muddled.  150000 seconds = 1 day.   Do we really want to hang the tests for a 1 day if something goes wrong and never completes?

@k-wall you are totally right, this was a mistake, currently I'm changing this timeout and merging with your PR #2757 and both things should be a valid workaround


Not compiling error.

I added Box2D addon to of/addons/
and launched example-Simple.
When I compile.

clang: warning: -lpthread: 'linker' input unused
clang: error: invalid deployment target for -stdlib=libc++ (requires OS X 10.7 or later)

Did anybody had there issue?
OSX 10.11.3 El Capitan
XCode 7.2.1
Thanks,

The included project files are too old. Use the ProjectGenerator to regenerate them.


add arm64 support for M1 Mac

Cherry-pick https://github.com/apple/swift-numerics/pull/213 for release/1.0

@swift-ci test


Add clipboard manipulation.

Currently copying to clipboard is working only on Windows. So far I saw that to get to use clipboard on linux requires quite a lot of work.
Possible solution might  be using some cross-platform library like clip.

Fixed with #62


[$50] Update copy on the wallet settings page

Problem
When users find it difficult to navigate our application's features due to interface clutter, it leads to decreased engagement and lower conversion and retention rates.
Solution
Clean up some of the copy on the wallet settings page:

Change the title of the block from "Send and receive money with friends" to "Expensify Wallet"
Change the subtitle from "Your wallet has been enabled to send and receive money with friends." to "Send and receive money with friends."

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~021859017641475961132
Upwork Job ID:<PHONE_NUMBER>475961132
Last Price Increase: 2024-11-19

Issue OwnerCurrent Issue Owner: @rayane-djouah

Proposal
Please re-state the problem that we are trying to solve in this issue.
Update copy on the wallet settings page
What is the root cause of that problem?
This is an improvment
What changes do you think we should make in order to solve the problem?
Change this translation to Expense Wallet and
https://github.com/Expensify/App/blob/763215e0aa0ac256f5f129e7f62444a466e84e8f/src/languages/en.ts#L1410?
This to Send and receive money with friends.
https://github.com/Expensify/App/blob/763215e0aa0ac256f5f129e7f62444a466e84e8f/src/languages/en.ts#L1412
We also need to update the es.ts file
What alternative solutions did you explore? (Optional)

@tgolen did you want to send this external? If so, I think we reduce the price quite considerably to say $50 for a small copy change.

I think a reduced price makes a lot of sense!

https://www.upwork.com/jobs/~021859017641475961132

Done!

Hi, I'm Dan, a new contributor from Upwork - and I would like to work on this issue.
Thanks

Contributor details
Your Expensify account email<EMAIL_ADDRESS>Upwork Profile Link: https://www.upwork.com/freelancers/~01a2a6c6ca80bc50fa

Proposal
Please re-state the problem that we are trying to solve in this issue.
Users find it difficult to navigate the wallet settings page due to cluttered interface copy.
What is the root cause of that problem?
The current wallet section title and subtitle are overly verbose and redundant.
What changes do you think we should make in order to solve the problem?
Update translations in src/languages/en.ts:
walletPage: {
    sendAndReceiveMoney: 'Expensify Wallet', // Changed from "Send and receive money with friends"
    walletEnabledToSendAndReceiveMoney: 'Send and receive money with friends', // Changed from "Your wallet has been enabled to send and receive money with friends"
}

What alternative solutions did you explore? (Optional)

Proposal
Please re-state the problem that we are trying to solve in this issue.
Clean up some of the copy on the wallet settings page:
What is the root cause of that problem?
UX improvement suggestion to reduce interface clutter and improve customer engagement and retention
What changes do you think we should make in order to solve the problem?

To change the title of the block from "Send and receive money with friends" to "Expensify Wallet",  change title to use
title={translate('walletPage.expensifyWallet')}. walletPage.expensifyWallet is already defined in the language translation files. The change will be done at

https://github.com/Expensify/App/blob/9f83a4118ff0b8080ac8c037b36a26252a12b06f/src/pages/settings/Wallet/WalletPage/WalletPage.tsx#L402

To change the subtitle from "Your wallet has been enabled to send and receive money with friends." to "Send and receive money with friends.", change subtitle to use subtitle={translate('walletPage.sendAndReceiveMoney'')}. The conditional check of hasActivatedWallet to display text will be removed at the following location

https://github.com/Expensify/App/blob/9f83a4118ff0b8080ac8c037b36a26252a12b06f/src/pages/settings/Wallet/WalletPage/WalletPage.tsx#L401

Remove all language translations for enableWalletToSendAndReceiveMoney and walletEnabledToSendAndReceiveMoney at

https://github.com/Expensify/App/blob/9f83a4118ff0b8080ac8c037b36a26252a12b06f/src/languages/en.ts#L1411
https://github.com/Expensify/App/blob/9f83a4118ff0b8080ac8c037b36a26252a12b06f/src/languages/en.ts#L1412
https://github.com/Expensify/App/blob/9f83a4118ff0b8080ac8c037b36a26252a12b06f/src/languages/es.ts#L1412
https://github.com/Expensify/App/blob/9f83a4118ff0b8080ac8c037b36a26252a12b06f/src/languages/es.ts#L1413

End Result is

What alternative solutions did you explore? (Optional)
The current solution assumes that the title and subtitle for Wallet section remains the same in both activated and non-activated condition.
If we need to display different title and subtitle based on activated/non-activated check then following changes will be required
subtitle={translate(`walletPage.${hasActivatedWallet ? 'sendAndReceiveMoney' : 'enableWalletToSendAndReceiveMoney'}`)}
title={translate(`walletPage.${hasActivatedWallet ? 'expensifyWallet' : 'sendAndReceiveMoney'}`)}

Hm, I don't like changing the title personally. I would think we just have this in both pre/post-enablement states?
Expensify Wallet
Send and receive money with friends.

I have applied to the job on Upwork and target to have the PR ready by 22-Nov

PR #52942

Agreed, small copy update.
Payment summary as follows:

$50 to @rayane-djouah for the C+ review (paid!)
$50 to @prakashbask for the fix (offer sent!)

Paid @prakashbask, closing!


fix(responsive): bug when transitioning between desktop and mobile

Types of Changes
What types of changes does your code introduce? Put an x in all the boxes that apply:

[ ] Bug fix (non-breaking change which fixes an issue, please reference the issue id)
[ ] New feature (non-breaking change which adds functionality, make sure to open an associated issue first)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] My change requires a change to the documentation
[ ] I have updated the documentation accordingly
[ ] I have added tests to cover my changes
[ ] All new and existing tests passed

Description
[Place a meaningful description here.]

:tada: This PR is included in version 2.2.2 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Use lock when initializing peer shard RangeSet

Not locking when initializing a Peer shard RangeSet could lead to addressing bad memory by other threads. This pull request fixes the issue by properly locking the resource.

Jenkins Build Summary
Built from this commit
Built at 20180301 - 06:10:21
Test Results

Build Type
Result
Status

clang.debug.unity
1001 cases, 0 failed, t: 397s
PASS :white_check_mark:

coverage
1001 cases, 0 failed, t: 630s
PASS :white_check_mark:

clang.debug.nounity
999 cases, 0 failed, t: 313s
PASS :white_check_mark:

gcc.debug.nounity
999 cases, 0 failed, t: 336s
PASS :white_check_mark:

gcc.debug.unity
1001 cases, 0 failed, t: 453s
PASS :white_check_mark:

clang.release.unity
1000 cases, 0 failed, t: 486s
PASS :white_check_mark:

gcc.release.unity
1000 cases, 0 failed, t: 521s
PASS :white_check_mark:

Merged in 2fee75bfc


PUT API

@CodiumAI-Agent /review

@CodiumAI-Agent /review

PR Review

 ⏱ Estimated effort to review [1-5]
3, because the PR involves both backend logic changes and data structure updates. The backend changes include handling PUT requests which require careful validation and error handling to ensure data integrity. The data update in the JSON file is extensive and needs to be reviewed for consistency and correctness.

 🧪 Relevant tests
No

 🔍 Possible issues

Data Validation Issue: The quantity field in the JSON data for ingredients should be consistently formatted. Mixed formats like "205" and "2.5" could lead to parsing errors or incorrect data handling.

Duplicate Data: The JSON data contains two entries for a "Vodka cocktail" with slight variations in names and values, which could lead to confusion or errors in data retrieval.
 🔒 Security concerns
No

 Code feedback:
relevant fileBackend/server.js
suggestion

Consider implementing input validation for the updatedCocktail object to ensure that all required fields are present and correctly formatted before attempting to update the data. This will help prevent potential runtime errors or corrupt data entries. [important]

relevant lineconst updatedCocktail = req.body;
relevant fileBackend/mockdata.json
suggestion

Standardize the quantity field format in the ingredients list to ensure consistency and avoid potential parsing errors. For example, use a consistent numeric format with decimals. [important]

relevant line"quantity": "205",
relevant fileBackend/mockdata.json
suggestion

Remove or merge duplicate entries for the "Vodka cocktail" to maintain data integrity and avoid confusion in data retrieval processes. [important]

relevant line"name": "Vodka cocktail",

 ✨ Review tool usage guide:
Overview:
The review tool scans the PR code changes, and generates a PR review which includes several types of feedbacks, such as possible PR issues, security threats and relevant test in the PR. More feedbacks can be added by configuring the tool.
The tool can be triggered automatically every time a new PR is opened, or can be invoked manually by commenting on any PR.

When commenting, to edit configurations related to the review tool (pr_reviewer section), use the following template:

/review --pr_reviewer.some_config1=... --pr_reviewer.some_config2=...

With a configuration file, use the following template:

[pr_reviewer]
some_config1=...
some_config2=...

See the review usage page for a comprehensive guide on using this tool.


WinUI2 Gallery - PullToRefresh(Bug)

Which version of the app?
WinUI 2 Gallery
Description
WinUI2 Gallery - PullToRefresh
In Basic PullToRefresh control, the refresh action is working as expected. But the problem is,
Scenario,
I scroll down to the end of the ListView and I again scroll down the list to make sure I reach the end of the ListView. Afterwards, when I try to scroll up, the refresh icon came out of nowhere[Attached screenshot for the reference] in the middle of the ListView.
Screenshots

Windows version
Windows 11 23H2 (22631)
Additional context
No response

This seems like an issue with the control itself. Transferring to microsoft-ui-xaml.


Pin-dependencies

Pull Request Checklist:

[ ] Positive Test Case Written by Dev

[ ] Automated Testing

[ ] Sufficient User and Developer Documentation

[ ] Passing Jenkins Build

[ ] Peer Code review and approval

Positive Test Case

[Enter positive test case here]

@sblack-usu you will also want to pin these dependencies in your irods_cleanup branch

Actually I'm going to move these dependencies into our base image.
Build: https://github.com/hydroshare/hs_docker_base/actions/runs/9654028884/job/26627456192


Add alias for LangChain blog post

Description
This PR adds an alias to support the old permalink/URL for this blog post.
Checklist:

[x] I have reviewed the style guide.
[x] If blogging, I have reviewed the blogging guide.
[ ] I have manually confirmed that all new links work.
[ ] I added aliases (i.e., redirects) for all filename changes.
[ ] If making css changes, I rebuilt the bundle.

Closing without merging as this is no longer needed


Allow DataGrid height to be styled

Attempt to fix the problems in https://github.com/mui/mui-toolpad/discussions/2613 about stretching the DataGrid.
This PR should make it so that it's more possible to try to set the DataGrid to full page height or style its height, such as by for example by setting sx: { height: "100vh" } (even though this kind of overrides the default behavior).
The label was also getting cut-off at the bottom when an element is set to take up the full page height like this, so this included moving the HUD selection hint inwards in those cases.
Table with sx: { height: "100vh" } before (the container height did not change with the grid, so the dotted border is shorter and does not match):

Table with sx: { height: "100vh" } after:

New label position (bottom and inwards):

I'm hesitant to try to solve https://github.com/mui/mui-toolpad/discussions/2613#discussioncomment-6894994. I don't see how it could fit in the current layout paradigm.

Actually this is all outdated by https://github.com/mui/mui-toolpad/pull/2818, closing.


Use class variable to avoid creating new connection for each resource

In existing implementation, the zookeeper connection is cached in the class instance variable as part of the ZK::Gem module method, which is later mixed-in to the zookeeper_node  custom resource class.
As a consequence, new ZK connection is created for each instance of the zookeeper node resource. As zookeeper has 60 connections allowed from single IP by default to protect from the DOS-attack, it means that total number of zookeeper node resources in a single run is also limited to 60 due to creation of new connection per each resource.
As a possible quick fix, I propose to use the class variable, allowing to share a connection object between all resource objects.

Thanks for reviewing and merging! The only potential problem with it that I think of -  is when somebody is managing multiple different Zookeeper instances from single chef run_list. In that case,  the old cached connection might be reused for new resource with potentially different connection string.
This potential issue may be fixed for example by having a class variable for a hash of { connection_string => connection_object } keypairs and check for each new connection string to be present in hash.
Do you think this is a viable use case that should be addressed?

While I’m sure somebody is managing multiple ZooKeeper clusters somewhere, I’d say, for now, that’s over engineering.
That said, it is potentially breaking, so I’ll go ahead & yank the patch-level release I cut for this, and issue a breaking release.


Ignore unmaintained errors

What does this PR do?
A brief description of the change being made with this pull request.
Motivation
What inspired you to submit this pull request?
Related issues
A list of issues either fixed, containing architectural discussions, otherwise relevant
for this Pull Request.
Additional Notes
Anything else we should know when reviewing?

#1110
#1109
#1108
#1107
#1111  👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @blt and the rest of your teammates on  Graphite


Title on the Image

Is there any way of showing the title over the post image?
Something like this:

Hello,
I'm sorry but it is a custom work beyond of our technical support.

                                                                                i wld try some tool like pablo for preparing my post covers if i were you. buffer's pablo - http://bit.ly/1OBJMU4                                                                                qL.b                                                                                From: Sachin RajputSent: wtorek, 26 maja 2015 19:06To: GavickPro/Portfolio-Free-Ghost-ThemeReply To: GavickPro/Portfolio-Free-Ghost-ThemeSubject: [Portfolio-Free-Ghost-Theme] Title on the Image (#16)Is there any way of showing the title over the post image?

Something like this:
—Reply to this email directly or view it on GitHub.


fixes #47 all host properties can now be set

fixes #47

the first commit in this PR overlaps with a commit in the other PR that I merged.

Yea I noticed that - does that affect the merge? I don't think it will duplicate as the commit hashes are the same.


Fix TilingSprite offset issue with CanvasRenderer

There is a bug in the CanvasRenderer of TilingSprite when
tilePosition + tileScale are both set.
The WebGL version of this fix was in 6d5bedd, however at the
time I didn't realize that it didn't actually fix the
CanvasRenderer version. This resolves the issue, as
demonstrated here:
http://www.davidsweetman.com/pixi/canvas-tiling-sprite-fix/

:+1:

Nice! I came here to post this exact issue and it's already fixed. It's a nice day :-)


fix: broken edit my collection artwork

This PR resolves ONYX-1096
Description
This PR fixes Edit My Collection Artwork Saving
https://github.com/artsy/eigen/assets/11945712/a57580ce-1e10-4672-b105-db0b241e8089

PR Checklist

[x] I have tested my changes on iOS and Android.
[x] I hid my changes behind a feature flag, or they don't need one.
[x] I have included screenshots or videos, or I have not changed the UI.
[x] I have added tests, or my changes don't require any.
[x] I added an app state migration, or my changes do not require one.
[x] I have documented any follow-up work that this PR will require, or it does not require any.
[x] I have added a changelog entry below, or my changes do not require one.

To the reviewers 👀

[ ] I would like at least one of the reviewers to run this PR on the simulator or device.

Changelog updates
Changelog updates

Cross-platform user-facing changes

broken edit my collection artwork - mounir

iOS user-facing changes

Android user-facing changes

Dev changes

Need help with something? Have a look at our docs, or get in touch with us.

This PR contains the following changes:

Cross-platform user-facing changes (broken edit my collection artwork - mounir)

  Generated by :no_entry_sign: dangerJS against 85ef56e957f06c1bc5f374e4e458f0aff9aee756


Action ordering not working as expected

The actions are not running in appropriate blocks. Need to enhance --dry-run to show how things will actually happen.

Ok, refactored into another version that should work a bit better.


Nested bulk queries with idempotent/select-or-insert logic

I am preparing a reduced test-case for this issue, but at the moment I can summarize the situation:

Assume a simple schema with objects Foo, Bar, BarAssociationWithFoo.
We are inserting an amount of Foo objects, from an input dict (assuming Python library here for now).
The Foo objects have a set of fields and a set of Bar objects (as a list of -named- tuples).
During bulk insertion of the Foo objects, a nested query is leverage to iterate foo_list passed to the query as an argument.
Ideally, each Foo object should be either inserted or selected if already present (based on an existent uniqueness constraint).

The expected result would be the idempotent insertion-or-selection of a Foo object with the nested idempotent insertion-or-selection of several (or none) Bar objects linked to it.
An additional 'want' would be the ability to use an associative type BarAssociationWithFoo in the nested query.
I need to collect my notes, but during testing, I observed one case where the state of the query is inconsistent.
For the purpose of the test-case, the schema would be like so:
scalar type DataItemType extending enum<
    'phone'
>;

type BaseData {
}

 type Subscriber extending BaseData {
    required property first_name -> str;
    property middle_name -> str;
    required property last_name -> str;

    # Composite uniqueness constraint
    constraint exclusive on ((.first_name, .middle_name, .last_name));

    # Computed property for the full name
    property full_name -> str {
        using (
            (.first_name IF .first_name != '' ELSE '') ++
            (' ' ++ .middle_name IF .middle_name != '' ELSE '') ++
            (' ' ++ .last_name IF .last_name != '' ELSE '')
        );
    }

    # Property for case-insensitive uniqueness
    property name_lower -> str {
        using (str_lower(.full_name));
        constraint exclusive;
    }

    multi link phone_numbers -> PhoneNumberAssociation;
}

type PhoneNumber {
    property original_number -> str;         # The actual phone number
    required property number -> str;         # The actual phone number
    property area_code -> int16;
    property country_code -> int16;            # Optional country code

    multi link associations -> PhoneNumberAssociation;

    required property computed -> str {
        default := .full_phone_number;
        constraint exclusive;
    }

    # Computed property for the full phone number
    property full_phone_number -> str {
        using (
            (<str>.country_code ++ '-' IF <str>.country_code != '' ELSE '') ++
            (<str>.area_code ++ '-' IF <str>.area_code != '' ELSE '') ++
            (.number IF .number != '' ELSE '')
        );
    }

    overloaded required property item_type -> DataItemType {
        default := 'phone';
    }
}

type DataItemAssociation {
    required link entity -> Entity;
}

type PhoneNumberAssociation extending DataItemAssociation {
    required link phone -> PhoneNumber;
    constraint exclusive on ((.entity, .phone));
}

The following query results in the inconsistent state I mentioned earlier:
with new_subscriber := (
    insert Subscriber {
        first_name := <str>$first_name,
        middle_name := <str>$middle_name,
        last_name := <str>$last_name,
    }
    unless conflict on .name_lower
    else (select Subscriber)
)
update Subscriber set
{
    phone_numbers := (
        WITH phone_data := <optional array <tuple <country_code: int16, area_code: int16, number: str, orig_number: str>>> $phone_numbers
        FOR phone_item IN array_unpack(phone_data) union (
            INSERT PhoneNumberAssociation {
                    subscriber := new_subscriber,
                    phone := (
                        INSERT PhoneNumber {
                            country_code := phone_item.country_code,
                            area_code := phone_item.area_code,
                            number := phone_item.number,
                            original_number := phone_item.orig_number
                        } unless conflict on (.computed) else PhoneNumber
                    )
            } unless conflict on (.subscriber, .phone) else PhoneNumberAssociation
        )
    )
    )

Using a test harness I observed that PhoneNumberAssociation objects are not created, and the PhoneNumber insertions are not actually happening for the full set. It seems the state of the nested query becomes corrupted.

I was able to apply the schema by creating an empty Entity type and by removing overloaded from the PhoneNumber type's item_type property. That still left me with a couple of spots where the schema and the query were not in agreement though:

you have assigned a subscriber property of PhoneNumberAssociation in your query and checked for conflict on it, but it doesn't exist in the schema
-PhoneNumberAssociation requires an entity link, but it isn't assigned in the query.

A few things I notice about the query:

I think there's a minor syntax error in the query. I can't make it run as it is here. I needed to change the final close paren to a closing curly bracket instead.
update Subscriber- This will update all existing Subscriber objects with the same phone number data. Is this your intent? If your intent is instead to update only the single new or existing subscriber, this query will not work. This query would not update a subscriber being inserted since that object is not in the database when the query is run, so if your goal is to update either the recently inserted or existing selected user new_subscriber with the update portion of this query, you'll only accomplish that in cases where the subscriber already existed, but you'll also update every other existing subscriber with the same phone numbers. Subscriber in this context refers to the type since it is in a different scope than your use of subscriber earlier.
You cannot update an object on the same query it is inserted. If you need to update on the insert, you would want to instead just insert with whatever data you would have updated with. You will only want to update if the Subscriber object already exists. I haven't tried testing this yet, but I think it might be a workable alternative for you with a tweak or two:

with phone_data := <optional array <tuple <country_code: int16, area_code: int16, number: str, orig_number: str>>> $phone_numbers,
phone_numbers := (
    FOR phone_item IN array_unpack(phone_data) union (
        INSERT PhoneNumberAssociation {
            phone := (
                INSERT PhoneNumber {
                    country_code := phone_item.country_code,
                    area_code := phone_item.area_code,
                    number := phone_item.number,
                    original_number := phone_item.orig_number
                } unless conflict on (.computed) else PhoneNumber
            )
        } unless conflict on (.phone) else PhoneNumberAssociation
    )
),
subscriber := (
    insert Subscriber {
        first_name := <str>$first_name,
        middle_name := <str>$middle_name,
        last_name := <str>$last_name,
        phone_numbers := phone_numbers
    }
    unless conflict on .name_lower
    else (select Subscriber)
),
subscriber_exists := (subscriber in Subscriber)
select (update subscriber set
{
    phone_numbers := phone_numbers
}) if subscriber_exists else (select subscriber);

Note that, if you have conflicting phone numbers or phone number associations that would be inserted in this query (i.e., the original and conflicting inserts would both happen in this query), unless conflict will not help with those as it only works to prevent conflicts with objects that have already been inserted. If you think that could happen here, you'll want to make sure the objects you're inserting on this query are distinct.

Closing this for now, but feel free to re-open if you need anything else.


nao_meshes: 0.1.11-0 in 'kinetic/distribution.yaml' [bloom]

Increasing version of package(s) in repository nao_meshes to 0.1.11-0:

upstream repository: https://github.com/ros-nao/nao_meshes.git
release repository: https://github.com/ros-naoqi/nao_meshes-release.git
distro file: kinetic/distribution.yaml
bloom version: 0.5.21
previous version for package: null

nao_meshes
* fixed folder path + added install rule for texture folder
* Update package.xml
  added myself as a maintainer as requested by vrabaud
* Contributors: Arguedas Mikael, Mikael Arguedas

Not ready for merge, missing patches for licence management.

Closing for now. You'll probably want to open a new one with bloom anyway.


Upgrading Elasticsearch from 0.10.0 to 1.12.0

I'm trying to upgrade an old version of Elasticsearch to the new one by updating the version number, and I am getting the following error:

Open Distro Security not initialized.

To Reproduce
Steps to reproduce the behaviour:

Updated the image number in my Docker compose file.
Since I got the 'not initialized' error by going to https://localhost:9200/, I tried to run the securityadmin.sh migration suggested in the docs.
I get the following error:

sh-4.2# ./plugins/opendistro_security/tools/securityadmin.sh -migrate -cd ./plugins/opendistro_security/securityconfig/ -icl -nhnv -cacert config/root-ca.pem -cert config/kirk.pem -key config/kirk-key.pem
Open Distro Security Admin v7
Will connect to localhost:9300 ... done
Connected as CN=kirk,OU=client,O=client,L=test,C=de
Elasticsearch Version: 7.10.0
Open Distro Security Version: <IP_ADDRESS>
Contacting elasticsearch cluster 'elasticsearch' and wait for YELLOW clusterstate ...
Cannot retrieve cluster state due to: null. This is not an error, will keep on trying ...
Root cause: MasterNotDiscoveredException[null] (org.elasticsearch.discovery.MasterNotDiscoveredException/org.elasticsearch.discovery.MasterNotDiscoveredException)

Try running securityadmin.sh with -icl (but no -cl) and -nhnv (If that works you need to check your clustername as well as hostnames in your TLS certificates)
Make sure that your keystore or PEM certificate is a client certificate (not a node certificate) and configured properly in elasticsearch.yml
If this is not working, try running securityadmin.sh with --diagnose and see diagnose trace log file)
Add --accept-red-cluster to allow securityadmin to operate on a red cluster.

Configuration (please complete the following information):

I'm using Docker Compose with the following settings:

environment:
- network.host=<IP_ADDRESS>
- http.cors.enabled=true
- http.cors.allow-origin=*
- http.cors.allow-credentials=true
- node.name=dev-core-elasticsearch
- node.master=true
- node.data=true
- network.publish_host=localhost
- discovery.type=zen
- discovery.seed_hosts=localhost
- discovery.zen.minimum_master_nodes=1
- path.repo=/usr/share/elasticsearch/snapshots

Relevant information
I get the following output in the Docker logs:

[2021-01-07T21:20:50,799][WARN ][o.e.c.c.ClusterFormationFailureHelper] [dev-core-elasticsearch] master not discovered yet, this node has not previously joined a bootstrapped (v7+) cluster, and [cluster.initial_master_nodes] is empty on this node: have discovered [{dev-core-elasticsearch}{NLRgylZtTHqUbCj4u7IM5A}{OSlOXlL_Sp-QiEcGoYFD-w}{localhost}{<IP_ADDRESS>:9300}{dimr}]; discovery will continue using [] from hosts providers and [{dev-core-elasticsearch}{NLRgylZtTHqUbCj4u7IM5A}{OSlOXlL_Sp-QiEcGoYFD-w}{localhost}{<IP_ADDRESS>:9300}{dimr}] from last-known cluster state; node term 0, last-accepted version 1 in term 0

Well there is only one instance. So this is master, as I am setting the environment variable node.master=true. Is there a reason that it is not detecting that?

Well there is only one instance. So this is master, as I am setting the environment variable node.master=true. Is there a reason that it is not detecting that?

@daudich Did you by chance lose the volume and subsequently lose the cluster UUid on upgrade?
Depending on your cluster size, you may also need to set a larger timeout for the cluster,join.timeout and cluster.publish.timeout to allow for the new master to elect itself .
Try those and let me know.

@daudich Did you by chance lose the volume and subsequently lose the cluster UUid on upgrade?
Depending on your cluster size, you may also need to set a larger timeout for the cluster,join.timeout and cluster.publish.timeout to allow for the new master to elect itself .
Try those and let me know.

Hi @daudich since 0.1.0 is a very old version there are many changes all the way up to 1.12.0, we recommend backing up your data somewhere else, build the new 1.12.0 cluster, then restore the data from your backup, reindexing the data again in the new cluster.
Thanks.

Hi @daudich it has been 7 days since we last talk.
We will close this issue for now, please feel free to re-open it.
Thanks.


StreamGroup does not support entries-read and lag

Starting with Redis version 7.0.0, command XINFO GROUPS returns the entries-read and lag fields.
https://redis.io/commands/xinfo-groups/
RStream.listGroups() returns list of common info about groups belonging to this stream, a list of StreamGroup.
But StreamGroup lacks the newly added information.
These new data can be added to StreamGroup?

Done! Thanks for pointing that out.


jscs check should fail the tests

jscs check should fail the tests:
$ npm test

><EMAIL_ADDRESS>test /home/adborden/projects/brigade/disclosure-frontend-alpha
> gulp test

[19:57:29] Using gulpfile ~/projects/brigade/disclosure-frontend-alpha/gulpfile.js
[19:57:29] Starting 'build-test'...
[19:57:29] Starting 'clean-full'...
[19:57:29] Finished 'clean-full' after 2.62 ms
[19:57:29] Starting 'lint'...
[19:57:29] Starting 'checkstyle'...
Error in plugin 'gulp-jscs'
Message:
    Illegal trailing whitespace at components/common/appMainNav/appMainNav.js :
     5 |  var appMainNavDirective = require('./appMainNavDirective');
     6 |  var AppMainNavController = require('./AppMainNavController');
     7 |
----------^
     8 |  module.exports = angular.module('appMainNavModule', ['ui.bootstrap.collapse'])
     9 |    .directive('appMainNav', appMainNavDirective)
[19:57:30] Finished 'checkstyle' after 443 ms
[19:57:30] Finished 'lint' after 471 ms
[19:57:30] Starting 'karma'...
INFO [framework.browserify]: 6028374 bytes written (8.93 seconds)
INFO [framework.browserify]: bundle built
INFO [karma]: Karma v0.12.37 server started at http://localhost:9876/
INFO [launcher]: Starting browser PhantomJS
INFO [PhantomJS 1.9.8 (Linux 0.0.0)]: Connected on socket IaNj8P8BJvLO8B18VVLD with id 41275141
PhantomJS 1.9.8 (Linux 0.0.0) LOG LOG: 'WARNING: Tried to load angular more than once.'

  MainController
    - should exist

  HomeController
    ✓ should exist

PhantomJS 1.9.8 (Linux 0.0.0): Executed 1 of 2 (skipped 1) SUCCESS (0.011 secs / 0 secs)
TOTAL: 1 SUCCESS

[19:57:43] Finished 'karma' after 13 s
[19:57:43] Finished 'build-test' after 13 s
[19:57:43] Starting 'test'...
[19:57:43] Finished 'test' after 7.06 μs

@adborden We just discussed this a bit. @jnmarcus has some concerns that we will not be able to tune the checks appropriately, however there is general consensus here that we should turn it on and address developer annoyances on a case-by-case basis.
Also, we should make sure that gulp doesn't crash or stop watching in development mode if it hits a style problem.

Yep, I think we should split the gulp task so the linting is part of the tests or something. Then linting can fail the tests, but on development, it just spits out warnings (like it does now).

@adborden was this fixed by any of the changes you made last night? if not, is this something you could address? Seems important to me, especially if we're not doing code reviews before merging.

@adborden Can you make this happen? Or did this get in, in one of your recent PRs?

Since I'm messing with tests and infrastructure, I can grab this. Is there any CI system in place? Or is the goal just to exit the gulp build-prod task with a non-zero exit code?

Putting this off to focus on features for the moment. Will reconsider once the MVP is out.

:thumbsup: I'm going to un-assign you to help communicate who is working on what.


fix: make firebase-tools a local dependency where needed

This also changes npm scripts to use npx firebase to ensure the
local version is used.
Fixes #771

@cburgdorf would be cool if you could test admin-cli deployment in this version

The code looks good, but haven't tested it locally yet.

@d3lm Thanks for the review! Found some time to test it yet?
Also pinging @cburgdorf again to give the admin-cli deployment a try on staging.

Ok, I gave this a test as I tried to make a deployment on staging. Everything went smooth at first but when it arrived at the stage where the client is deployed it failed.
Here is what happened:

My node version was out of date. This is probably unrelated to this PR and more related to the PR that introduced prettier. No problem so I updated my node version but now I'm running into the following.

I get a /bin/sh: 3: ng: not found. This is because I haven't installed the angular-cli globally yet after I updated node. However, with npx am I right to assume that a global angular-cli is actually not what we want?

I get a /bin/sh: 3: ng: not found. This is because I haven't installed the angular-cli globally yet after I updated node. However, with npx am I right to assume that a global angular-cli is actually not what we want?

The only need for a global ng is convenience and scaffolding of projects. Whenever we use any ng command inside a CLI project, what actually happens is that Angular CLI will use the local one all the time.
So what I think we could do is running ng through npx as well. Since this the version that's used anyways, it's jut not accessible via a global ng command then.

@cburgdorf updated the PR accordingly. Maybe you can give it another shot.

Tried it! Works now. We can merge it as soon as it goes green.

Just added a small comment, feel free to ignore me :).

Thanks @SamVerschueren ! Yes those are left overs and can be removed. I'll take care of it!

Okay updated the PR. Will merge this once green on Travis.


Rename project

The current name is completely un-SEOable. Why not kafka-connect-object-stores or kafka-connect-cloud-blobs

Hi @alexanderdean, thanks for the feedback. Although this project will provide support for all major clouds, if you are a s3 user - you would search for "kafka-connect-s3" (and thats already taken) and mostly not kafka connect object/blob store. So not sure if that would have helped a lot.
I have added kafka-connect-s3 to the description and hopefully expand README with more s3 specific details soon - it might help a little.

Thanks @PraveenSeluka - that seems like a good compromise. I'd also suggest updating the h1 in the README, maybe:
StreamX: Kafka Connect for S3

ok @alexanderdean sure - will make this change.


Deletes all line of code upon saving the code

If I install vue official extension and try to save the code in visual studio code. It deletes all the code from that file.

Duplicate of https://github.com/vuejs/language-tools/issues/4066


Fix typo in log

Description:
Just noticed a small typo in an info log. Checklist below seems redundant. :)
Checklist:

[ ] The code change is tested and works locally.
[ ] Local tests pass with tox. Your PR cannot be merged unless tests pass
[x] There is no commented out code in this PR.

If user exposed functionality or configuration variables are added/changed:

[ ] Documentation added/updated in home-assistant.io

If the code communicates with devices, web services, or third-party tools:

[ ] New dependencies have been added to the REQUIREMENTS variable (example).
[ ] New dependencies are only imported inside functions that use them (example).
[ ] New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
[ ] New files were added to .coveragerc.

If the code does not interact with devices:

[ ] Tests have been added to verify that the new code works.

Hi @anton-johansson,
It seems you haven't yet signed a CLA. Please do so here.
Once you do that we will be able to review and accept this pull request.
Thanks!


Cabal file links to vec instead of dec

The homepage and bug-reports fields of the Cabal file erroneously link to https://github.com/phadej/vec instead of https://github.com/phadej/dec.

Good catch. dec was previously inside vec's repository. I'll update the rest of the links.

Done as part of https://github.com/phadej/dec/pull/3


Created Standup_meeting6.md

Great job, team! It was an excellent standup meeting with valuable progress updates from everyone. It's impressive to see the progress we've made collectively. Thank you all for your contributions and dedication. Let's continue working together to make our project a success!


Status code for 403 ApiResponseExcepton

I saw #71 has been merge into master and that's great! Thanks @j4m3s for your work!
I'm wondering why it doesn't include status code in APIResponseException? Is there any reason why status code has been omitted?
Would be nice to have it back for 403 responses. Actually it would be even better to add missing data from https://support.sparkpost.com/customer/en/portal/articles/2140916-extended-error-codes like api error code, message and description.
Change https://github.com/SparkPost/php-sparkpost/blob/master/lib/SparkPost/APIResource.php#L197 to:
        $response = json_decode($response->getBody(), true);
        throw new APIResponseException(
          'Request forbidden',
          $statusCode,
          isset($response['errors'][0]['message']) ? $response['errors'][0]['message'] : "Request forbidden",
          isset($response['errors'][0]['code']) ? $response['errors'][0]['code'] : 1100,
          isset($response['errors'][0]['description']) ? $response['errors'][0]['description'] : "Does this API Key have the correct SparkPost permissions?"
        );

The api http status code is in $exception->code, the $exception->apiCode is an extended code which may or may not be supplied.  Description is also optional in our responses.

Yeah, but right now neither $exception->code nor $exception->apiCode is available for $statusCode == 403. See https://github.com/SparkPost/php-sparkpost/blob/master/lib/SparkPost/APIResource.php#L197

Ah I see, sorry for the misunderstanding.  I will address for the next release.

This has been published with 1.2.0.


Please add a 32 bit version of Elm

It's becoming such a large issue that I'm encountering people who use 32 bit Linux who can't install Elm because there's no 32 bit in this package. If elm is installed via a package.json for a web project, then it will just not work on 32 bit machines, preventing those developers from proceeding.
As packages like this start to rely more and more on this package, it's vital that you add a version for as many platforms as possible where Elm compiles.
If there's anything I can do to help this along, let me know and I'll try and help out.

See https://github.com/kevva/elm-bin/issues/21#issuecomment-145648057 (and probably close this issue here as a duplicate).

It might be good to keep this one open for now until a 32 bit version is added, to make it clear that the issue is that a 32 bit version doesn't exist. But feel free to close it if it feels unnecessary.

@eeue56 Sure, let's keep it here until it's addressed.


Extracts #to_native out of types

Part of a fix for https://github.com/bolandrm/sassc-rails/issues/30
This makes it easier for sassc-rails to mix in the #to_native functionality provided by sassc-ruby into Sass types. We need this because sassc-rails registers Sprockets::SassFunctions with sassc-ruby except that those functions are hardcoded to return Sass types that don’t have #to_native defined on them.

@edward I'd like to propose an alternative.
Instead of having to include a module like this, could we abandon adding the to_native method approach altogether?
We could take the script_value results here (https://github.com/bolandrm/sassc-ruby/blob/master/lib/sassc/functions_handler.rb#L50)  and wrap it in a method (or object) that converts it to the native representation.
This native conversion object could take in both SassC and Sass value objects.  After that, I think the SassC value objects could be a simple alias of the Sass value objects.

Yeah, I think we could do that. I thought about doing that at first, but I was stuck on wanting to call  #to_native and that copy constructors for Sass value types didn’t exist.
Let me see what a wrapper would look like.

FYI I’m going on vacation for a week without a computer but I’ll wrap this up (ha) when I get back.

If you've worked on the new approach at all, could you please push it up?  I might work on it if I get bored.
On Sat, Jul 18, 2015 at 3:58 PM, Edward Ocampo-Gooding
<EMAIL_ADDRESS>wrote:

FYI I’m going on vacation for a week without a computer but I’ll wrap this up (ha) when I get back.
Reply to this email directly or view it on GitHub:
https://github.com/bolandrm/sassc-ruby/pull/16#issuecomment-122588959

Haven't worked on it beyond what's in my head, so go ahead :) It should be
a pretty straightforward wrapper of a case statement and a bunch of tiny
classes.
On Sat, Jul 18, 2015 at 15:17 Ryan Boland<EMAIL_ADDRESS>wrote:

If you've worked on the new approach at all, could you please push it up?
I might work on it if I get bored.
On Sat, Jul 18, 2015 at 3:58 PM, Edward Ocampo-Gooding
<EMAIL_ADDRESS>wrote:

FYI I’m going on vacation for a week without a computer but I’ll wrap
this up (ha) when I get back.
Reply to this email directly or view it on GitHub:
https://github.com/bolandrm/sassc-ruby/pull/16#issuecomment-122588959

—
Reply to this email directly or view it on GitHub
https://github.com/bolandrm/sassc-ruby/pull/16#issuecomment-122601833.

closing in favor of #17


feat: tui application with live status

ℹ Overview

adds basic viewport and elements
integrates with existing status methods
adds version api endpoint for node information

📝 Related Issues

resolves https://algorandfoundation.atlassian.net/browse/ENG-592

✅ Acceptance:

[x] Pre-commit checks pass

LGTM


[Feature Request] Enable passing ENV variables via Secret or ConfigMap

Currently, most of the configuration OPTIONS, that can be configured via environment variables, need to be passed as Helm Values. See the deploment.yaml
There are cases, where these configurations might not be hardcoded as Helm Values but rather passed located in Kubernetes Secrets and/or ConfigMaps.
Currently, there is no way to refer to ConfigMaps/Secrets to get the configuration for the Trivy-Operator Helm Chart.
Kubernetes itself does support setting environment variables both

for Secrets
and for ConfigMaps

And it is a widely used pattern.
Should be technically not difficult to enable such a pattern with a priority like:

Use value from Helm Value if set
Use value from ConfigMap if set (and override Helm Value)
Use value from Secret if set (and override both Helm Value and ConfigMap)

cheers
flash ⚡

@flash-me contributions are welcome :)

Spend some time looking at it. This can be trickier and initially presumed.
Unfortunately, envFrom does not work here.
Due to Precedence of Environment Variables in the Pod Spec, the order is
env > envFrom > predefined in container.
And everything is already defined by env variables in the deployment.yaml.
And wrapping every possible Value into a if block feels also not great. Hhmhm..

Alrighty,
tried another approach by extracting all the OPERATOR_* env variables into their own ConfigMap and then refer to them with envFrom configMapRef.
This avoids the previously mentioned Precedence an enables using additional sources.
This means:

Most of the deployment.yaml Env's moved to a new ConfigMap
A new Property .Values.operator.<PROP> is added to the values.yaml file
Everything completely optional with breaking changes

@chen-keinan May you assign me this issue? I'd create the according pull request next few days hopefully.
cheers
flash ⚡


Add comment to README about need for copying css and js files.

Maybe note that you can alternatively do a full recompilation?

How would you do that?

lake clean to delete the build folder and the lake build again (both in the doc-gen4 chekcout of course)

Thank you! I updated the PR.


[Bug] Intercommunicating reactive systems don't receive all messages of the frame

Bug report
Assume, two reactive systems A and B, and they are called in the following order. So if B creates a new entity that should be catched by A, then in current implementation nothing happens.
Environment
Win10 x64 / Visual Studio 2017 / Unity3D 2019.4.0
Steps to reproduce the issue

Define systems A and B and register them in the same order.
Assume that A waits for entity with C component and B it produces after A is executed.

What's the expected result?
All reactive systems are executed till new entities are created/changed/etc.
What's the actual result?
If some entity is created later than some system is executed then this event will never be processed and deleted at the end of the frame.

Fixed in ce76ad3


Getting 504 errors on brew update

Bug reports:
brew update
fatal: unable to access 'https://github.com/Homebrew/homebrew-completions/': The requested URL returned error: 504
fatal: unable to access 'https://github.com/Homebrew/homebrew-core/': The requested URL returned error: 504
fatal: unable to access 'https://github.com/Homebrew/homebrew-versions/': The requested URL returned error: 504
fatal: unable to access 'https://github.com/caskroom/homebrew-cask/': The requested URL returned error: 504
fatal: unable to access 'https://github.com/Homebrew/homebrew-services/': The requested URL returned error: 504
fatal: unable to access 'https://github.com/Homebrew/brew.git/': The requested URL returned error: 504
fatal: unable to access 'https://github.com/Homebrew/homebrew-php/': The requested URL returned error: 504
Error: Fetching /usr/local/Homebrew/Library/Taps/homebrew/homebrew-completions failed!
Fetching /usr/local/Homebrew/Library/Taps/homebrew/homebrew-core failed!
Fetching /usr/local/Homebrew/Library/Taps/homebrew/homebrew-versions failed!
Fetching /usr/local/Homebrew/Library/Taps/caskroom/homebrew-cask failed!
Fetching /usr/local/Homebrew/Library/Taps/homebrew/homebrew-services failed!
Fetching /usr/local/Homebrew failed!
Fetching /usr/local/Homebrew/Library/Taps/homebrew/homebrew-php failed!

brew config
HOMEBREW_VERSION: 1.1.7
ORIGIN: https://github.com/Homebrew/brew.git
HEAD: 9cce3414fbd39d146d97911dbb3bf07fffaa1080
Last commit: 4 days ago
Core tap ORIGIN: https://github.com/Homebrew/homebrew-core
Core tap HEAD: 9f91c9cc05ff5119954de276a6b0b992831f7da4
Core tap last commit: 27 hours ago
HOMEBREW_PREFIX: /usr/local
HOMEBREW_REPOSITORY: /usr/local/Homebrew
HOMEBREW_CELLAR: /usr/local/Cellar
HOMEBREW_BOTTLE_DOMAIN: https://homebrew.bintray.com
CPU: octa-core 64-bit ivybridge
Homebrew Ruby: 2.0.0-p648
Clang: 8.0 build 800
Git: 2.11.0 => /usr/local/bin/git
Perl: /usr/bin/perl
Python: /usr/bin/python
Ruby: /Users/cblackburn/.rbenv/shims/ruby => /Users/cblackburn/.rbenv/versions/2.3.1/bin/ruby
Java: 1.8.0_31
macOS: 10.12.2-x86_64
Xcode: 8.2.1
CLT: <IP_ADDRESS>.1.1480973914
X11: 2.7.11 => /opt/X11

brew doctor
Please note that these warnings are just used to help the Homebrew maintainers
with debugging if you file an issue. If everything you use Homebrew for is
working fine: please don't worry and just ignore them. Thanks!

Warning: "config" scripts exist outside your system or Homebrew directories.
`./configure` scripts often look for *-config scripts to determine if
software packages are installed, and what additional flags to use when
compiling and linking.

Having additional scripts in your path can confuse software installed via
Homebrew if the config script overrides a system or Homebrew provided
script of the same name. We found the following "config" scripts:
  /Users/cblackburn/.rbenv/shims/passenger-config

Warning: Unbrewed dylibs were found in /usr/local/lib.
If you didn't put them there on purpose they could cause problems when
building Homebrew formulae, and may need to be deleted.

Unexpected dylibs:
  /usr/local/lib/libusb-1.0.0.dylib

I'm not sure if this is some kind of personal network issue or if others are experiencing this. Please advise.

Hi
I have the same issue.


Feature: throw error if using --config and config file is not found

Is there an existing issue for this?

[X] I have searched the existing issues

Is your feature request related to a problem? Please describe
I want specific config for libs and apps.. when a config file is not found due to some reason the language files are still generated but with the default config
Describe the solution you'd like
if --config is provide but there is no transloco.config.js file found, throw an error
Describe alternatives you've considered
No response
Describe alternatives you've considered
N/A

Describe alternatives you've considered
N/A
Additional context
No response
I would like to make a pull request for this feature
Yes 🚀

@mackelito Would you still like to make a PR for it?

Oh man.. sorry for not replying.. I snoozed the notification a bit to much :D
I no longer use transloco (new assignment uses other library).. sorry :/


ede: yes has no effect

Describe the bug
When EDE is enabled, EDE responses are not sent for DNSSEC failures.
To reproduce
Steps to reproduce the behavior:

Enable ede by adding "ede: yes".
dig @::1 dnssec-failed.org +dnssec
No EDE errors.

Expected behavior
EDE error as follows:
EDE: 9 (DNSKEY Missing): (no SEP matching the DS found for dnssec-failed.org.)
System:

Unbound version:  1.16.2
OS: RHEL9
unbound -V output:

[root@seawitch unbound]# unbound -V
Version 1.16.2
Configure line: --build=x86_64-redhat-linux-gnu --host=x86_64-redhat-linux-gnu --program-prefix= --disable-dependency-tracking --prefix=/usr --exec-prefix=/usr --bindir=/usr/bin --sbindir=/usr/sbin --sysconfdir=/etc --datadir=/usr/share --includedir=/usr/include --libdir=/usr/lib64 --libexecdir=/usr/libexec --localstatedir=/var --sharedstatedir=/var/lib --mandir=/usr/share/man --infodir=/usr/share/info --with-pythonmodule --with-pyunbound PYTHON=/usr/bin/python3 --enable-dnstap --with-libnghttp2 --with-libevent --with-pthreads --with-ssl --disable-rpath --disable-static --enable-relro-now --enable-pie --enable-subnet --enable-ipsecmod --with-conf-file=/etc/unbound/unbound.conf --with-pidfile=/run/unbound/unbound.pid --enable-sha2 --disable-gost --enable-ecdsa --with-rootkey-file=/var/lib/unbound/root.key --enable-linux-ip-local-port-range --disable-sha1
Linked libs: libevent 2.1.12-stable (it uses epoll), OpenSSL 3.0.7 1 Nov 2022
Linked modules: dns64 python ipsecmod subnetcache respip validator iterator
BSD licensed, see LICENSE in source package for details.
Report bugs to<EMAIL_ADDRESS>or https://github.com/NLnetLabs/unbound/issues
Additional information
Example of EDE working correctly against <IP_ADDRESS>:
[root@seawitch unbound]# dig @2606:4700:4700::1111 [dnssec-failed.org](http://dnssec-failed.org/) +dnssec

; <<>> DiG 9.16.23-RH <<>> @2606:4700:4700::1111 [dnssec-failed.org](http://dnssec-failed.org/) +dnssec
; (1 server found)
;; global options: +cmd
;; Got answer:
;; ->>HEADER<<- opcode: QUERY, status: SERVFAIL, id: 51077
;; flags: qr rd ra; QUERY: 1, ANSWER: 0, AUTHORITY: 0, ADDITIONAL: 1

;; OPT PSEUDOSECTION:
; EDNS: version: 0, flags: do; udp: 1232
; EDE: 9 (DNSKEY Missing): (no SEP matching the DS found for [dnssec-failed.org](http://dnssec-failed.org/).)
;; QUESTION SECTION:
;[dnssec-failed.org](http://dnssec-failed.org/).				 I get EDE: 6 (DNSSEC Bogus) when I run the same test.
root@ns1:~# dig @::1 dnssec-failed.org +dnssec

; <<>> DiG 9.20.3-1+0~20241110.108+debian12~1.gbpa0a2ff-Debian <<>> @::1 dnssec-failed.org +dnssec
; (1 server found)
;; global options: +cmd
;; Got answer:
;; ->>HEADER<<- opcode: QUERY, status: SERVFAIL, id: 38645
;; flags: qr rd ra; QUERY: 1, ANSWER: 0, AUTHORITY: 0, ADDITIONAL: 1

;; OPT PSEUDOSECTION:
; EDNS: version: 0, flags: do; udp: 1432
; COOKIE: 32ff924B473a46310100000067312161d17372f7c0d36983 (good)
; EDE: 6 (DNSSEC Bogus)
;; QUESTION SECTION:
;dnssec-failed.org.             IN      A

;; Query time: 948 msec
;; SERVER: ::1#53(::1) (UDP)
;; WHEN: Sun Nov 10 23:10:58 EET 2024
;; MSG SIZE  rcvd: 80

The configure line above reveals the culprit:  --disable-sha1. Unbound was compiled with no SHA1 support. It then treats that zone (signed with algorithm 5 - RSASHA1) as just insecure.

                     IN      A

;; Query time: 468 msec
;; SERVER: ::1#53(::1) (UDP)
;; WHEN: Mon Nov 11 16:13:35 EET 2024
;; MSG SIZE  rcvd: 44


Search should be available for all knowledge bases

See: https://github.com/odalic/odalic-ui/issues/150
Please adjust backend so that it supports that.

Please adjust backend so that it supports that.

Backend and the API already do support that.


[WFRP4e Core] Wrong distance in Reikland scene

In the Reikland scene (id: vGrxlojYtdObKLF6) the Grid scale is 2.5, it should be 5.
With this, it will match the distance provided in "Ubersreik Surrounds" (starter set id: dffFQGeXYq79AE8p)From: Fneuch#5019foundry: 9.255wfrp4e: 5.1.1wfrp4e-altdorf: 2.0.1wfrp4e-archives1: 2.4.1wfrp4e-core: 2.4.1wfrp4e-dotr: 2.3.1wfrp4e-eis: 2.3.1wfrp4e-middenheim: 2.4.1wfrp4e-pbtt: 2.2.1wfrp4e-rnhd: 2.4.1wfrp4e-starter-set: 2.3.1wfrp4e-ua1: 2.3.1

Closing as conflicts with different sources, no way to tell which one is correct.


is there a way to use variable in html loop

In html, when you loop an array, you have access to each variable in the array, then you can do {{variable}} to display it. However, if you need to bind a click function that has the same name as that variable, is there a way to do it?

Execute function {{item}}

var app = new Vue({
    data: {
        arr: ['fn1', 'fn2', 'fn3']
    },
    methods: {
        fn1: function(){},
        fn2: function(){},
        fn3: function(){},
    }

Here, when you click on each div in the loop, you are supposed to call a function whose name is the same as the item in the arr, currently it returns Uncaught TypeError: fns.apply is not a function on console.

Hello! Please use our forum or Gitter for questions like this. The repo issue list is strictly for bug reports and feature requests, as stated in the contributing guidelines. Thanks.

use this[item] as item is actually used as a property name

@fnlctrl Hi i tried your way and it doesn't work :( https://jsfiddle.net/pgsyotro/1/

Sorry for giving a false answer, please use the forum or Gitter as @phanan said.
(Corrected one, for the record: https://jsfiddle.net/q3bvndc6/)

@phanan will do
@fnlctrl 谢谢 ^_^ u rock


Public announcement of OpenFeature

Issue to track the public announcement of OpenFeature.
Working doc is  here
Please indicate your involvement
| Name | Company | PR | Blog | Quote |
| Alois Reitbauer | Dynatrace | [X] | [x] | [x] |

Might want to provide access to folks w/ the link. I've requested access to the doc.

Access is private to members as this will be a PR

The press release has gone live.


Improve the footer section

I want to improve the footer section. Add social media icons, links, hovers, etc to make to look cool.
Please assign it to me under gssoc'23. I would like to work upon this issue.

@thekavikumar npm run start is not starting the app on local host. How to do it ?


Readme install snippet points to Justineo's package

This package is registered at npm as vue-octicons, while the readme says vue-octicon, which is Justineo's package. This leads to consumers to install the wrong package. That's a critical mistake.
This also doesn't make sense:
Vue.component('octicon', require('vue-octicons/src/components/Octicon.vue'));

I've updated the readme.  What doesn't make sense in
Vue.component('octicon', require('vue-octicons/src/components/Octicon.vue'));

Is it not working for you? Please provide a PR if you're suggesting an alternative.

It doesn't make sense because it's going directly to the source inside node_modules. In the case of javascript, node_modules packages are expected to be transpiled to es5, namely what you have in your dist. Consuming should always be from the main entry in package.json and nothing else. There are exceptions, but this is the standard way of publishing and consuming.

Thanks for the follow-up, @adi518, a PR is welcome.

Closing.


Exponential backoff for request client, Distilled PR.

@timothysc final PR.
Assuming that lavalamp is okay with request backoff (there was a comment, re: "dont create a new mechanism for backoff, make sure that we trip the existing throttle"), then I think this is what we all have agreed on.
Final thoughts before I issue update to upstream?

lgtm, gofor PR


Reserved identifier should not be casesensitiv (e.g class Object)

its a typical incompatibility in legacy code to use Object or String classes, but they wont be found because PhpCodeFixer checks only case sensitiv for that ...

Hi. Thanks for info. Checkout dev-master version of phpcf, now it should trigger.


Optim.Rprop issue?

Hi Everyone,
I am testing both PyTorch and Torchsharp with a very basic example (fitting of a single variable non-linear function). When I use Rprop in Pytorch I get a very good fitting, as expected. On the other hand, Rprop in Torchsharp yield very poor fitting, the error function is not minmized at all. I have to use the Adam optimizer to get a good fit with Torchsharp. Any advice? Thank you.
PS the PyTorch and Torchsharp are the same, line by line (same model, same number of neurons, same number of iterations, etc...)

maybe you shall share the code with us?

//function to fit > Y = tanh(X^4 - X^3 + X^2 - X - 1)
var X = torch.arange(-2, 2, 0.04).view(-1, 1);
var Y = (X.pow(4) - X.pow(3) + X.pow(2) - X - 1).tanh();
var noise = torch.randn(X.size());
var Y_noise = Y + 0.01 * noise;
var epoch = 500;
var neurons = 20;
var learning_rates = new double[] { 1,0.1,0.01,0.001 };
var model = createModel(1, neurons, "Sigmoid");
var err = new List();
var loss_fn = torch.nn.MSELoss();
var y_model = Y;
for (int l = 0; l < learning_rates.Length; l++)
{
var optimizer = torch.optim.Rprop(model.parameters(), learning_rates[l]);
model.zero_grad();
for (int ep = 0; ep < epoch; ep++)
{
var ym = model.forward(X);
var error = loss_fn.forward(ym, Y_noise);
error.backward();
optimizer.step();
optimizer.zero_grad();
Debug.Print("[iteration] = " + (ep + 1).ToString() + " Error = " + error.item().ToString());
y_model = model.forward(X);
error = loss_fn.forward(y_model, Y);
err.Insert(ep, error.item());
}

Hey @gavolio, I think the pr should be ready. You can check the results of your code before and after applying our fix. Thanks for reporting the issue!


Please consider fixing issues detected by repository checker

Notification from ioBroker Check and Service Bot
Dear adapter developer,
I'm the ioBroker Check and Service Bot. I'm an automated tool processing routine tasks for the ioBroker infrastructure. I have recently checked the repository for your adapter pid for common errors and appropiate suggestions to keep this adapter up to date.
This check is based the current head revisions (master / main  branch) of the adapter repository
Please see the result of the check below.
ioBroker.pid
   -
ERRORS:

[ ] :heavy_exclamation_mark: [E033] @iobroker/adapter-core 3.0.6 specified. 3.1.4 is required as minimum, 3.1.6 is recommended. Please update dependencies at package.json

WARNINGS:

[ ] :eyes: [W040] "keywords" within package.json should contain "ioBroker"
[ ] :eyes: [W115] "common.tier" is required in io-package.json. Please check https://github.com/ioBroker/ioBroker.docs/blob/master/docs/en/dev/objectsschema.md#adapter.
[ ] :eyes: [W162] js-controller 5.0.0 listed as dependency but 5.0.19 is recommended. Please consider updating dependency at io-package.json.
[ ] :eyes: [W181] "common.license" in io-package.json is deprecated. Please define object "common.licenseInformation"
[ ] :eyes: [W184] "common.main" is deprecated and ignored. Please remove from io-package.json. Use "main" at package.json instead.
[ ] :eyes: [W184] "common.title" is deprecated and replaced by "common.titleLang". Please remove from io-package.json.

:thumbsup: No suggestions found
Please review issues reported and consider fixing them as soon as appropiate.
Errors reported by repository checker should be fixed as soon as possible. Some of them require a new release to be considered as fixed. Please note that errors reported by checker might be considered as blocking point for future updates at stable repository.
Warnings reported by repository checker should be reviewed. While some warnings can be ignored due to good reasons or a dedicated decision of the developer, most warnings should be fixed as soon as appropiate.
You may start a new check at any time by adding the following comment to this issue:
@iobroker-bot recheck
Please note that I (and the server at GitHub) have always plenty of work to do. So it may last up to 30 minutes until you see a reaction. I will drop a comment here as soon as I start processing.
Feel free to contact me (@iobroker-bot) if you have any questions or feel that an issue is incorrectly flagged.
And THANKS A LOT for maintaining this adapter from me and all users.
Let's work together for the best user experience.
your
ioBroker Check and Service Bot
@mcm1957 for evidence
Last update at Fri, 06 Sep 2024 09:50:14 GMT

Issue outdated due to RECREATE request. Follow up issue #252 has been created.
This issue will be closed.
your
ioBroker Check and Service Bot


Better error-messages/error-sites

We need better error-messages. I think the same error message might be used no matter the actual error.  Some errors could with benefit bubble back to the users. Such as when a user submits an event outside the geographic limitations set by the app config.

The error responses are currently hard-coded into app/frontend.coffee in the form of the respond404 and respond500 functions.


Messages, alerts and notifications styling

I would like to propose creating 3 types of messages: messages, alerts and notifications. Bootstrap uses the class .alert for it's message. This is because of the role="alert" ARIA accessibility attribute. However, the styling of the messages in Bootstrap are quite big, and not as compact as the form validation messages seen in FixMeStick. I want to suggest to divide messages into 3 groups:
Alerts

Used inside forms
Make use of the role="alert" attribute
Are often visually coupled to an input field with an arrow pointing up
Colour coded

Your name is required

Messages

Messages are used as a more  bigger type of notification
Bound to a certain piece of content on the page
Not restricted to the use in forms
Colour coded
May use the role="alert" attribute when applicable
May be dismissible

    Lorem ipsum...

    <button type="button" class="message__close" data-dismiss="alert">Close</button>

Notifications

Often site wide and not bound to a certain piece of content E.G. cookie notifications
Often fixed or absolutely positioned
May use the role="alert" attribute when applicable
May be dismissible

    Lorem ipsum...
    <button type="button" class="notification__close" data-dismiss="alert">Accepteer cookies</button>

Note: wether or not the functional name will be  danger is not important to this issue. I've stuck with the colours used by Bootstrap: success/``warning/info/danger`.
Suggestions and feedback are welcome.

Alerts: other notifications can also be alerts (i.e. role='alert'). This could be confusing.
Messages: other components can also be messages, such as chat messages. Or is a message the content of a notification?
Others also use: help, or feedback. OS X calls everything a notification. I think this is a good idea. We could create different types of notifications, the same way we create different headers (e.g. page-header) and footers (e.g. page-footer). Also, they see 'badges' as notifications. We could use the following list:

notification
badge-notification
input-notification
page-notification

The usage of input-notification has been part of the discussion I had with @edgargressie. In most cases this type of notification will be paired with an input element. However, it might also be paired to elements which do not use the input tag, such as textarea, select, radio and possibly custom input times. Using the name input-notification might confuse developers into thinking it is only suited for coupling to an input element.
Another concern I have is about what the default class notification will be used for. In addition, badge-notification is also an odd one in the list since it refers to the the form of the notification instead of the functional usage. Can a page-notification be a badge? The term badge might be more useful as a modifier in that case.
How would you describe page-noticiation? Are this notifications bound to the page, or can this notifications be site wide such as the cookie notification?
The main pro of having distinctive names for different types of notifications are to avoid confusion. Alerts are described by MDN as:

The alert role is used to communicate an important and usually time-sensitive message to the user


Title:  Want to improve the hover effect on the footer content

Is your feature request related to a problem? Please describe.
I Want to improve the hover effect on the footer content
Describe the solution you'd like.
left to right underline effect on  hover
Describe alternatives you've considered.
#478
Add any other context or screenshots about the feature request here.
No response
Record

[X] I agree to follow this project's Code of Conduct
[X] I have checked the existing issues
[X] I'm a GSSoC'23 contributor
[X] I want to work on this issue

too easy issue