lwip client ?

Hi,
First of all I am grateful to the author for releasing this nice project ! As for my issue :
I considered this project previously for comparison with the linux tcp/ip stack. For doing so, I would need a client in addition to the current server (I would want both hosts communicating to use lwip).
I tried in the past but could not get it done, altough I assumed it would have been an easy job.
I consider giving it another shot, but first I would be curious to know if you think this would be simple, or would it require to modify the code dpdk related (I did not use it yet).
Thank you for your time.

Thank you for your message.
I have experimentally added the client mode; please find it at commit id 272ebe4099744207b1d59231578bc963c0981b05.
The command for the server mode is the same as before, and the command for the client mode additionally specifies the server IP address and the number of concurrent connections by -s and -c, respectively.
The following is the example output.
server
$ sudo LD_LIBRARY_PATH=./dpdk/install/lib/x86_64-linux-gnu ./app -l 0-1 --proc-type=primary --file-prefix=pmd1 --allow=0000:04:00.1 -- -a <IP_ADDRESS> -g <IP_ADDRESS> -m <IP_ADDRESS> -l 1 -p 10000
EAL: Detected CPU lcores: 16
EAL: Detected NUMA nodes: 2
EAL: Detected shared linkage of DPDK
EAL: Multi-process socket /var/run/dpdk/pmd1/mp_socket
EAL: Selected IOVA mode 'VA'
EAL: 1024 hugepages of size 2097152 reserved, but no mounted hugetlbfs found for that size
EAL: VFIO support initialized
EAL: Using IOMMU type 1 (Type 1)
EAL: Ignore mapping IO port bar(2)
EAL: Probe PCI driver: net_ixgbe (8086:10fb) device: 0000:04:00.1 (socket 0)
TELEMETRY: No legacy callbacks, legacy socket not created
http data length: 63 bytes
-- application has started --
[server]:          0 Requests/sec  (rx           0 bps, tx           0 bbs)
[server]:      98434 Requests/sec  (rx    33073824 bps, tx    49610736 bbs)
[server]:     319868 Requests/sec  (rx   107475648 bps, tx   161213472 bbs)
[server]:     318025 Requests/sec  (rx   106856400 bps, tx   160284600 bbs)
[server]:     747972 Requests/sec  (rx   251318592 bps, tx   376977888 bbs)
[server]:    1082936 Requests/sec  (rx   363866496 bps, tx   545799744 bbs)
[server]:    1074529 Requests/sec  (rx   361041744 bps, tx   541562616 bbs)
[server]:    1082924 Requests/sec  (rx   363862464 bps, tx   545793696 bbs)
[server]:    1082777 Requests/sec  (rx   363813072 bps, tx   545719608 bbs)
[server]:    1083066 Requests/sec  (rx   363910176 bps, tx   545865264 bbs)
[server]:    1044888 Requests/sec  (rx   351082368 bps, tx   526623552 bbs)
[server]:    1082642 Requests/sec  (rx   363767712 bps, tx   545651568 bbs)
[server]:    1050398 Requests/sec  (rx   352933728 bps, tx   529400592 bbs)
[server]:    1082571 Requests/sec  (rx   363743856 bps, tx   545615784 bbs)
[server]:    1084397 Requests/sec  (rx   364357392 bps, tx   546536088 bbs)

client
$ sudo LD_LIBRARY_PATH=./dpdk/install/lib/x86_64-linux-gnu ./app -l 0-1 --proc-type=primary --file-prefix=pmd1 --allow=0000:04:00.1 -- -a <IP_ADDRESS> -g <IP_ADDRESS> -m <IP_ADDRESS> -p 10000 -s <IP_ADDRESS> -c 16
EAL: Detected CPU lcores: 16
EAL: Detected NUMA nodes: 2
EAL: Detected shared linkage of DPDK
EAL: Multi-process socket /var/run/dpdk/pmd1/mp_socket
EAL: Selected IOVA mode 'VA'
EAL: 1024 hugepages of size 2097152 reserved, but no mounted hugetlbfs found for that size
EAL: VFIO support initialized
EAL: Using IOMMU type 1 (Type 1)
EAL: Ignore mapping IO port bar(2)
EAL: Probe PCI driver: net_ixgbe (8086:10fb) device: 0000:04:00.1 (socket 0)
TELEMETRY: No legacy callbacks, legacy socket not created
16 concurrent connection(s)
-- application has started --
[client]:          0 Requests/sec  (rx           0 bps, tx           0 bbs)
[client]:     319137 Requests/sec  (rx   160845048 bps, tx   107231040 bbs)
[client]:     319353 Requests/sec  (rx   160953912 bps, tx   107302608 bbs)
[client]:     509913 Requests/sec  (rx   256996152 bps, tx   171335136 bbs)
[client]:    1083112 Requests/sec  (rx   545888448 bps, tx   363925632 bbs)
[client]:    1074288 Requests/sec  (rx   541441152 bps, tx   360960768 bbs)
[client]:    1082550 Requests/sec  (rx   545605200 bps, tx   363736800 bbs)
[client]:    1082810 Requests/sec  (rx   545736240 bps, tx   363824160 bbs)
[client]:    1083246 Requests/sec  (rx   545955984 bps, tx   363970656 bbs)
[client]:    1044359 Requests/sec  (rx   526356936 bps, tx   350904624 bbs)
[client]:    1082979 Requests/sec  (rx   545821416 bps, tx   363880944 bbs)
[client]:    1057230 Requests/sec  (rx   532843920 bps, tx   355229280 bbs)
[client]:    1076742 Requests/sec  (rx   542677968 bps, tx   361785312 bbs)
[client]:    1083462 Requests/sec  (rx   546064848 bps, tx   364043232 bbs)

Regarding the complexity, changes for DPDK-relevant parts are not necessary, I guess.
I think the complicated part of the client implementation is to maintain the state of each HTTP response.
Let's say, the HTTP header of an HTTP response has the following block, which indicates the entire HTTP content is 3000 bytes, and we only received 1000 bytes for the moment.
HTTP/1.1 200 OK
...
Content-Length: 3000
...

In this case, we have to treat the subsequent incoming 2000 bytes (3000 - 1000) as part of the HTTP content, rather than an HTTP header.
To do this, I needed to parse the HTTP header, and maintain the state to know how many bytes of the HTTP content will be sent from the server; this part of the implementation is found in tcp_recv_handler().
I think, if we stop following the HTTP request/response format, we can remove this complexity, and it would be better for simple experimentation on the TCP stack performance.
Anyway, I hope this works in your environment.

Thank you for this quick contribution (and sorry for my late answer). I made it run on my setup and might consider using it in some project of mine, so thanks!

Sounds good! Then, let me close this issue.


Allow default model be generated with user having to visit every UI component

Currently you have to visit every component in order to successfully generate a model, it should be possible for a user to just take all the defaults or some of them ...

@TristanWright Here you go

Hello,
I started experimenting with SimPut in this repository only a couple of days ago as it is part of HPCCloud, which we are examining in order to develop an application. I seem to have come across this issue as well. I created a simple 'contact-card' type as follows.
The 'contact-card.hbs' template file is simply the following:
First Name: {{{firstName}}}
Last Name: {{{lastName}}}

The front-end consists of two simple views where the user can specify his/her First Name and Last Name, as show in the 'model.js' file:
module.exports = {
    defaultActiveView: 'firstNameView',
    order: [
        'firstNameView',
        'lastNameView',
    ],
    views: {
        firstNameView: {
            label: 'First Name',
            attributes: ['firstNameAttr'],
        },
        lastNameView: {
            label: 'Last Name',
            attributes: ['lastNameAttr']
        },
    },
    definitions: {
        firstNameAttr: {
            label: 'First Name',
            parameters: [
                {
                    id: 'firstNameAttrId',
                    type: 'string',
                    size: 1,
                    default: 'Joe',
                    label: 'First Name',
                },
            ],
        },
        lastNameAttr: {
            label: 'Last Name',
            parameters: [
                {
                    id: 'lastNameAttrId',
                    type: 'string',
                    size: 1,
                    default: 'Bloggs',
                    label: 'Last Name',
                },
            ],
        },
    },
};

The 'convert.js' file is just:
const contactCardTemplate = require('./templates/contact-card.hbs');

module.exports = function convert(viewModel) {

    console.log(viewModel);

    const contactParams = {};
    contactParams['firstName'] = viewModel.data.firstNameView[0].firstNameAttr.firstNameAttrId.value[0];
    contactParams['lastName'] = viewModel.data.lastNameView[0].lastNameAttr.lastNameAttrId.value[0];

    const results = {
        'contact.txt' : contactCardTemplate(contactParams),
    };

  return { results, model: viewModel };
};

If the user does not explicitly visit the Last Name view in the front-end, the entry for the Last Name (with the default value of 'Bloggs') does not get created in the viewModel object , causing the convert.js function to fail.
Are there plans to create entries for default values in the viewModel? Or is the developer expected to do some sanity checking in the convert.js function?
Thanks.

Ok, fair enough. And thanks for the tip on importing the dataModel into the convert function in order to get access to the defaults.


Suggested new fixer: ShortCast

A fixer we use as custom one, which is worth becoming a contrib one (as there is already a fixer for fixing @return/param boolean/integer to bool/int).
So this completes it for consistency:
/**
 * Fixer ShortCast
 *
 * @author Mark Scherer
 */
class ShortCastFixer extends AbstractFixer
{

    /**
     * @var array
     */
    public static $matching = [
        '(boolean)' => '(bool)',
        '(integer)' => '(int)',
    ];

    /**
     * @param \SplFileInfo $file
     * @param string $content
     *
     * @return string
     */
    public function fix(\SplFileInfo $file, $content)
    {
        $tokens = Tokens::fromCode($content);
        foreach ($tokens as $index => $token) {
            // Don't use !!
            if ($token->getContent() === '!' && $tokens[$index - 1]->getContent() === '!') {
                $tokens[$index - 1]->setContent('');
                $tokens[$index]->setContent('(bool)');
                continue;
            }

            // Don't use long form
            if ($token->isCast()) {
                $content = $token->getContent();
                $key = strtolower($content);

                if (isset(self::$matching[$key])) {
                    $tokens[$index]->setContent(self::$matching[$key]);
                }
            }
        }

        return $tokens->generateCode();
    }

    /**
     * @return int
     */
    public function getPriority()
    {
        return -100;
    }

    /**
     * @return int
     */
    public function getLevel()
    {
        return FixerInterface::NONE_LEVEL;
    }

    /**
     * @return string
     */
    public function getDescription()
    {
        return 'Use short forms (bool) and (int) for casts and do not use !!.';
    }

}

Maybe we need the same deal with have with the phpdoc fixers, so "Integer" can be fixed to "int" too?

And then extract that from the existing fixer? Because currently this is already fixed along with the other doc block changes. But I agree, it would be better to separate those two things.

Please, could you send a PR?

Kind of hard to totally abstract, since the phpdoc fixer also includes fixes for sudo types, like "numeric", or "mixed".

Wanted to first get a "OK, sounds useful" and maybe some preliminary feedback, like if the suggested name sounds OK. But then a PR should be possible very soon.

Use short forms (bool) and (int) for casts and do not use !!.

Should be two fixers ;)

Or 1 with config options ;)

boolean/bool is explicitly cast
!! is implicitly cast
I think that changing implicitly cast to explicitly cast should be separated

ah, I misread, I thought two fixers for (bool) and (int), but I get it now ;)

Any naming ideas for them?

ShortCast (for boolean=>bool and integer=>int) / NoCastAliases  / RemoveCastAliases
NoImplicitCast (for !! => bool)

?

I see that @SpacePossum already started on the ImplicitCast one.
The other code can be found here in case anyone wants to get a head start on the 2nd part of the cast fixer.

I think this can be closed, since https://github.com/FriendsOfPHP/PHP-CS-Fixer/pull/1613 is merged :)

thanks ;)


Unit test fix

fixes #1215 by modifying require paths to './' from '../' since baseUrl has already been set to '../'

Thanks Kevin for finding this. We were all using localhost's root for fuelux/.


missing license

Hi, I really like your work. Could you add a license to the code? Otherwise it is not possible to use it in other projects --> The license of similar works is MIT if that helps, but of course its entirely your choice.
https://github.com/PJunhyuk/ImageQuilting/blob/master/LICENSE
So it might make sense to just use the same license. Thx!
Best,
Thomas

Hi Thomas,
I've added a LICENSE.


[Bug] Can't create the topic

Topic creation
Hey guys, can't create a topic, probably FE bug, check the gif
ua  — Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:96.0) Gecko/20100101 Firefox/96.0

Hey, thanks for reaching out!
That version is outdated, there were hotfixes in next minor versions.
Please try 0.3.3 or even better :master if possible.
Let me know how it goes :)


alts_concurrent_connectivity_test is failing consistently on master

Is failing 100%
In the run_tests.py suites:
https://source.cloud.google.com/results/invocations/62b2de00-7609-4780-8ea4-fc0c44342eff/targets/github%2Fgrpc%2Frun_tests%2Fcpp_linux_dbg_native/tests
https://source.cloud.google.com/results/invocations/848ad153-361b-4510-894a-8e83fa24bc96/targets/github%2Fgrpc%2Frun_tests%2Fcpp_linux_dbg_native/tests
https://source.cloud.google.com/results/invocations/0bf2350e-d345-47ca-99a5-880e1b71ab30/targets/github%2Fgrpc%2Frun_tests%2Fcpp_linux_dbg_native/tests
Probable root cause:
https://github.com/grpc/grpc/pull/20929

Failing both linux/grpc_basictests_c_cpp_dbg and linux/grpc_basictests_c_cpp_opt

This can be repro'd locally.
The test that's failing is one particular test of the set that exists in alts_concurrent_connectivity_test, which can be ran with:
GRPC_POLL_STRATEGY=poll bins/opt/alts_concurrent_connectivity_test --gtest_filter=AltsConcurrentConnectivityTest.TestHandshakeFailsFastWhenHandshakeServerHangsAfterAccepting

I think this new test is making a fundamentally racey assertion (with a high chance of losing the race):
This test itself repeatedly, in a loop:

creates a channel with a 100ms reconnect backoff.
attempts to connect via ALTS to a backend that accepts TCP connections but from then on is non-responsive
The ALTS handshake server is also non-responsive
After the 100ms connect deadline fires, the subchannel shuts down the ongoing ALTS handshake. The subchannel shuts down the handshake and "fails" it's connect attempt, and sets it's connectivity state to "transient failure"
Because the full 100ms deadline has been used up, the subchannel immediately reconnects, and sets its connectivity state to "connecting"
The test wakes up for it's call to watch_connectivity_state due to the subchannel changing state to "transient failure" earlier. However, when the test now checks it's connectivity state, with a call to grpc_channel_check_connectivity_state, the state has since changed back to "connecting". The test's while loop will never terminate so long as it continues to hit this race.

I think the fix is just in the test: the test should probably assert that connectivity state changes (and doesn't become ready), but it probably shouldn't require introspection of the connectivity state to necessarily be "transient failure"


how to config envoy as a Origin server for static content ? just like nginx

Description:

It's my first time to use envoy, someone told me that envoy can be a origin server for static content, but i can't find the related information about it. Can someone tell me where can i get the information about how to config envoy as a origin server for static content ? I shall be very grateful.

Envoy is not a web server. It is a modern reverse proxy, similar to haproxy, and nginx is a web server with reverse proxy functionality.


Allow for Clojurescript support

I moved the schema to use the new .cljc format and added Clojurescript tests.  All of Clojure tests are running and passing under Clojurescript.
There is no need to change the JAR publishing; the .cljc file may be used by either language.
Maybe more documentation changes are needed?

@davidjameshumphreys thanks for the patch. We've primarily this schema to validate incoming geojson's in our backend API's. Curious to understand the use case you are targeting in ClojureScript. Do you deal a lot with constructing geojson's manually in your client side code?

I think that I have made all of the changes that you suggested. It took a while to figure out the parts of 'doo' that were needed, but it seems to work quite well now.

Looks good! Thanks for the patch.

@davidjameshumphreys this should now be available with release 0.1.3


feat(proto): add deprecated field

Adds a field to mark a chart as deprecated. See docs for particular semantics.
Should be merged after #2077.
Closes #1963

@prydonius I merged the other branch, so I think you just need to rebase now.

Yeah, I believe this is the right solution to #1963 . I ultimately talked myself out of trying to do something more sophisticated.


Blue Markers of "Ihud Hazala" should have a color according to their severity

Blue Markers of "Ihud Hazala" should have a color according to their severity.

Hi All, (nice to join.. :))
Do we want to show the 'ihud Hazala' unique icon and just give it the right color?
like this:

the other option is to show the same icon for all accident markers
if the answer is yes, i think i found it..

Please leave the icon as is since there is a difference in the accuracy of the report. Thanks.

duplicate of #493
fixed.

I think regardless of accuracy issues that we will solve we should color the icons by severity. The severity is important and it’s data that we have so why won’t we use it?

On 22 Jan 2016, at 08:03, Simona Holstein<EMAIL_ADDRESS>wrote:
Please leave the icon as is since there is a difference in the accuracy of the report. Thanks.
—
Reply to this email directly or view it on GitHub https://github.com/hasadna/anyway/issues/527#issuecomment-173821000.

@galraij, it's closed since it's solved :)
See on http://anyway-unstable.herokuapp.com/
On Sun, Jan 31, 2016 at 1:07 AM Gal Raij<EMAIL_ADDRESS>wrote:

I think regardless of accuracy issues that we will solve we should color
the icons by severity. The severity is important and it’s data that we have
so why won’t we use it?

On 22 Jan 2016, at 08:03, Simona Holstein<EMAIL_ADDRESS>wrote:
Please leave the icon as is since there is a difference in the accuracy
of the report. Thanks.
—
Reply to this email directly or view it on GitHub <
https://github.com/hasadna/anyway/issues/527#issuecomment-173821000>.

—
Reply to this email directly or view it on GitHub
https://github.com/hasadna/anyway/issues/527#issuecomment-177326321.

@danielhers when do you plan to move from unstable to stable?

Probably tomorrow, if everything works right
On Sun, Jan 31, 2016 at 11:02 AM Simona Holstein<EMAIL_ADDRESS>wrote:

@danielhers https://github.com/danielhers when do you plan to move from
unstable to stable?
—
Reply to this email directly or view it on GitHub
https://github.com/hasadna/anyway/issues/527#issuecomment-177443347.


Edit declaration code example to match spec

Change MyGreeter to Greeter in type alias example.
Fixes #1291

Accidentally created PR from my forked master branch, will close and resubmit PR from a different branch


Catch http timeout when old R5 blocks while preparing the network

This was accidentally removed while adapting to new R5 versions that fail fast.

Codecov Report

Merging #186 into dev will decrease coverage by 0.04%.
The diff coverage is 0%.

@@             Coverage Diff              @@
##                dev     #186      +/-   ##
============================================
- Coverage     25.57%   25.53%   -0.05%
  Complexity      103      103
============================================
  Files            58       58
  Lines          2162     2166       +4
  Branches        195      195
============================================
  Hits            553      553
- Misses         1575     1579       +4
  Partials         34       34

Impacted Files
Coverage Δ
Complexity Δ

...om/conveyal/taui/controllers/BrokerController.java
21.78% <0%> (-0.9%)
6 <0> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bc65a86...ca7cae3. Read the comment docs.


opentelemetry-collector-contrib: 0.104.0 -> 0.108.0

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/open-telemetry/opentelemetry-collector-contrib/releases.
meta.description for opentelemetry-collector-contrib is: OpenTelemetry Collector superset with additional community collectors
meta.homepage for opentelemetry-collector-contrib is: https://github.com/open-telemetry/opentelemetry-collector-contrib
meta.changelog for opentelemetry-collector-contrib is: https://github.com/open-telemetry/opentelemetry-collector-contrib/blob/v0.105.0/CHANGELOG.md
Updates performed

Golang update

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact
Checks done

built on NixOS
The tests defined in passthru.tests, if any, passed
found 0.105.0 with grep in /nix/store/blf001xw6dflv5al5wfv7mx7sa4fsw7y-opentelemetry-collector-contrib-0.105.0
found 0.105.0 in filename of file in /nix/store/blf001xw6dflv5al5wfv7mx7sa4fsw7y-opentelemetry-collector-contrib-0.105.0

Rebuild report (if merged into master) (click to expand)

2 total rebuild path(s)

2 package rebuild(s)

First fifty rebuilds by attrpath

opentelemetry-collector-contrib

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/blf001xw6dflv5al5wfv7mx7sa4fsw7y-opentelemetry-collector-contrib-0.105.0 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A opentelemetry-collector-contrib https://github.com/r-ryantm/nixpkgs/archive/d0c39fba046d3a725ffdaee04e2d8b607319106c.tar.gz

Or:
nix build github:r-ryantm/nixpkgs/d0c39fba046d3a725ffdaee04e2d8b607319106c#opentelemetry-collector-contrib

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/blf001xw6dflv5al5wfv7mx7sa4fsw7y-opentelemetry-collector-contrib-0.105.0
ls -la /nix/store/blf001xw6dflv5al5wfv7mx7sa4fsw7y-opentelemetry-collector-contrib-0.105.0/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

1 package built:

opentelemetry-collector-contrib

Maintainer pings
cc @uri-canva @06kellyjac for testing.

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/open-telemetry/opentelemetry-collector-contrib/releases.
meta.description for opentelemetry-collector-contrib is: OpenTelemetry Collector superset with additional community collectors
meta.homepage for opentelemetry-collector-contrib is: https://github.com/open-telemetry/opentelemetry-collector-contrib
meta.changelog for opentelemetry-collector-contrib is: https://github.com/open-telemetry/opentelemetry-collector-contrib/blob/v0.106.1/CHANGELOG.md
Updates performed

Golang update

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact
Checks done

built on NixOS
The tests defined in passthru.tests, if any, passed
found 0.106.1 with grep in /nix/store/zzqlvv6apa60g4nga35jwg0j2bnc4c7n-opentelemetry-collector-contrib-0.106.1
found 0.106.1 in filename of file in /nix/store/zzqlvv6apa60g4nga35jwg0j2bnc4c7n-opentelemetry-collector-contrib-0.106.1

Rebuild report (if merged into master) (click to expand)

2 total rebuild path(s)

2 package rebuild(s)

First fifty rebuilds by attrpath

opentelemetry-collector-contrib

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/zzqlvv6apa60g4nga35jwg0j2bnc4c7n-opentelemetry-collector-contrib-0.106.1 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A opentelemetry-collector-contrib https://github.com/r-ryantm/nixpkgs/archive/373d67f405cf590b7d0b82eef76bd94477e86797.tar.gz

Or:
nix build github:r-ryantm/nixpkgs/373d67f405cf590b7d0b82eef76bd94477e86797#opentelemetry-collector-contrib

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/zzqlvv6apa60g4nga35jwg0j2bnc4c7n-opentelemetry-collector-contrib-0.106.1
ls -la /nix/store/zzqlvv6apa60g4nga35jwg0j2bnc4c7n-opentelemetry-collector-contrib-0.106.1/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

1 package built:

opentelemetry-collector-contrib

Maintainer pings
cc @uri-canva @06kellyjac for testing.

Add a :+1: reaction to pull requests you find important.

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/open-telemetry/opentelemetry-collector-contrib/releases.
meta.description for opentelemetry-collector-contrib is: OpenTelemetry Collector superset with additional community collectors
meta.homepage for opentelemetry-collector-contrib is: https://github.com/open-telemetry/opentelemetry-collector-contrib
meta.changelog for opentelemetry-collector-contrib is: https://github.com/open-telemetry/opentelemetry-collector-contrib/blob/v0.107.0/CHANGELOG.md
Updates performed

Golang update

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact
Checks done

built on NixOS
The tests defined in passthru.tests, if any, passed
found 0.107.0 with grep in /nix/store/dnj8018wm9rxkylh84gp7p8m9sxgs57l-opentelemetry-collector-contrib-0.107.0
found 0.107.0 in filename of file in /nix/store/dnj8018wm9rxkylh84gp7p8m9sxgs57l-opentelemetry-collector-contrib-0.107.0

Rebuild report (if merged into master) (click to expand)

2 total rebuild path(s)

2 package rebuild(s)

First fifty rebuilds by attrpath

opentelemetry-collector-contrib

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/dnj8018wm9rxkylh84gp7p8m9sxgs57l-opentelemetry-collector-contrib-0.107.0 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A opentelemetry-collector-contrib https://github.com/r-ryantm/nixpkgs/archive/4866d469c935b1afd39231c1034bd35dc6eaf0b9.tar.gz

Or:
nix build github:r-ryantm/nixpkgs/4866d469c935b1afd39231c1034bd35dc6eaf0b9#opentelemetry-collector-contrib

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/dnj8018wm9rxkylh84gp7p8m9sxgs57l-opentelemetry-collector-contrib-0.107.0
ls -la /nix/store/dnj8018wm9rxkylh84gp7p8m9sxgs57l-opentelemetry-collector-contrib-0.107.0/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

1 package built:

opentelemetry-collector-contrib

Maintainer pings
cc @uri-canva @06kellyjac for testing.

[!TIP]
As a maintainer, if your package is located under pkgs/by-name/*, you can comment @NixOS/nixpkgs-merge-bot merge to automatically merge this update using the nixpkgs-merge-bot.

Add a :+1: reaction to pull requests you find important.

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/open-telemetry/opentelemetry-collector-contrib/releases.
meta.description for opentelemetry-collector-contrib is: OpenTelemetry Collector superset with additional community collectors
meta.homepage for opentelemetry-collector-contrib is: https://github.com/open-telemetry/opentelemetry-collector-contrib
meta.changelog for opentelemetry-collector-contrib is: https://github.com/open-telemetry/opentelemetry-collector-contrib/blob/v0.108.0/CHANGELOG.md
Updates performed

Golang update

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact
Checks done

built on NixOS
The tests defined in passthru.tests, if any, passed
found 0.108.0 with grep in /nix/store/cfndljg4j4gjdv6yk7rjy4sj99gfiqkj-opentelemetry-collector-contrib-0.108.0
found 0.108.0 in filename of file in /nix/store/cfndljg4j4gjdv6yk7rjy4sj99gfiqkj-opentelemetry-collector-contrib-0.108.0

Rebuild report (if merged into master) (click to expand)

2 total rebuild path(s)

2 package rebuild(s)

First fifty rebuilds by attrpath

opentelemetry-collector-contrib

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/cfndljg4j4gjdv6yk7rjy4sj99gfiqkj-opentelemetry-collector-contrib-0.108.0 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A opentelemetry-collector-contrib https://github.com/r-ryantm/nixpkgs/archive/551b36fb6764e681700261ebae43fba10a722230.tar.gz

Or:
nix build github:r-ryantm/nixpkgs/551b36fb6764e681700261ebae43fba10a722230#opentelemetry-collector-contrib

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/cfndljg4j4gjdv6yk7rjy4sj99gfiqkj-opentelemetry-collector-contrib-0.108.0
ls -la /nix/store/cfndljg4j4gjdv6yk7rjy4sj99gfiqkj-opentelemetry-collector-contrib-0.108.0/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

1 package built:

opentelemetry-collector-contrib

Maintainer pings
cc @uri-canva @06kellyjac for testing.

[!TIP]
As a maintainer, if your package is located under pkgs/by-name/*, you can comment @NixOS/nixpkgs-merge-bot merge to automatically merge this update using the nixpkgs-merge-bot.

Add a :+1: reaction to pull requests you find important.

@ofborg test opentelemetry-collector


zchunk: 1.4.0 -> 1.5.1

Description of changes

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
Result of nixpkgs-review pr 331432 run on x86_64-linux 1

3 packages failed to build and already failed to build on hydra master:

microdnf: plain log
python311Packages.conda: log was empty
python312Packages.conda: log was empty

2 packages failed to build and are new build failures:

python311Packages.conda.dist: log was empty
python312Packages.conda.dist: log was empty

44 packages built:

createrepo_c
dnf-plugins-core (python312Packages.dnf-plugins-core)
dnf-plugins-core.man (python312Packages.dnf-plugins-core.man)
dnf4
dnf4.man
dnf4.py
dnf5
dnf5.man
libdnf
libdnf.dev
libdnf.py (python312Packages.libdnf ,python312Packages.libdnf.dev ,python312Packages.libdnf.py)
libmamba
librepo
librepo.dev
librepo.py (python312Packages.librepo ,python312Packages.librepo.dev ,python312Packages.librepo.py)
libsolv
micromamba
python311Packages.conda-libmamba-solver
python311Packages.conda-libmamba-solver.dist
python311Packages.dnf-plugins-core
python311Packages.dnf-plugins-core.man
python311Packages.dnf4
python311Packages.dnf4.man
python311Packages.dnf4.py
python311Packages.libdnf (python311Packages.libdnf.dev ,python311Packages.libdnf.py)
python311Packages.libmambapy
python311Packages.libmambapy.dist
python311Packages.librepo (python311Packages.librepo.dev ,python311Packages.librepo.py)
python312Packages.conda-libmamba-solver
python312Packages.conda-libmamba-solver.dist
python312Packages.dnf4
python312Packages.dnf4.man
python312Packages.dnf4.py
python312Packages.libmambapy
python312Packages.libmambapy.dist
rpm-ostree
rpm-ostree.dev
rpm-ostree.devdoc
rpm-ostree.man
tdnf
zchunk
zchunk.dev
zchunk.lib
zchunk.man

The following issues got detected with the above build packages.
Please fix at least the ones listed with your changed packages:

createrepo_c:

warning: EvalError
Cannot evaluate attribute ‘createrepo_c’ in ‘/nix/store/7izz0k8gilnlz4wii96qkq0rb897r9s1-nixpkgs’.

dnf4:

warning: EvalError
Cannot evaluate attribute ‘dnf4’ in ‘/nix/store/7izz0k8gilnlz4wii96qkq0rb897r9s1-nixpkgs’.

dnf5:

warning: EvalError
Cannot evaluate attribute ‘dnf5’ in ‘/nix/store/7izz0k8gilnlz4wii96qkq0rb897r9s1-nixpkgs’.

libdnf:

warning: EvalError
Cannot evaluate attribute ‘libdnf’ in ‘/nix/store/7izz0k8gilnlz4wii96qkq0rb897r9s1-nixpkgs’.

libmamba:

warning: EvalError
Cannot evaluate attribute ‘libmamba’ in ‘/nix/store/7izz0k8gilnlz4wii96qkq0rb897r9s1-nixpkgs’.

librepo:

warning: EvalError
Cannot evaluate attribute ‘librepo’ in ‘/nix/store/7izz0k8gilnlz4wii96qkq0rb897r9s1-nixpkgs’.

libsolv:

warning: EvalError
Cannot evaluate attribute ‘libsolv’ in ‘/nix/store/7izz0k8gilnlz4wii96qkq0rb897r9s1-nixpkgs’.

microdnf:

warning: EvalError
Cannot evaluate attribute ‘microdnf’ in ‘/nix/store/7izz0k8gilnlz4wii96qkq0rb897r9s1-nixpkgs’.

micromamba:

warning: EvalError
Cannot evaluate attribute ‘micromamba’ in ‘/nix/store/7izz0k8gilnlz4wii96qkq0rb897r9s1-nixpkgs’.

python311Packages.conda-libmamba-solver.dist:

got build log for '/nix/store/nfb8s69lz0r49k80vpir6ahw7avb3xyv-python3.11-conda-libmamba-solver-24.7.0-dist' from 'daemon'
When evaluating attribute ‘python311Packages.conda-libmamba-solver.dist’:
warning: python-include-tests
Consider adding a checkPhase for tests, or if not feasible, pythonImportsCheck.
Near pkgs/development/python-modules/conda-libmamba-solver/default.nix:40:
   |
40 |     description = "Libmamba based solver for conda";
   | ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/python-include-tests.md

python311Packages.conda-libmamba-solver:

got build log for '/nix/store/m6gb3wrqhnqq5zcma8iwd29qhq24siv6-python3.11-conda-libmamba-solver-24.7.0' from 'daemon'
When evaluating attribute ‘python311Packages.conda-libmamba-solver’:
warning: python-include-tests
Consider adding a checkPhase for tests, or if not feasible, pythonImportsCheck.
Near pkgs/development/python-modules/conda-libmamba-solver/default.nix:40:
   |
40 |     description = "Libmamba based solver for conda";
   | ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/python-include-tests.md

python312Packages.conda-libmamba-solver.dist:

got build log for '/nix/store/k8bhaq1smivyq3v9xz8rgq6l0ac0ihpd-python3.12-conda-libmamba-solver-24.7.0-dist' from 'daemon'
When evaluating attribute ‘python312Packages.conda-libmamba-solver.dist’:
warning: python-include-tests
Consider adding a checkPhase for tests, or if not feasible, pythonImportsCheck.
Near pkgs/development/python-modules/conda-libmamba-solver/default.nix:40:
   |
40 |     description = "Libmamba based solver for conda";
   | ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/python-include-tests.md

python312Packages.conda-libmamba-solver:

got build log for '/nix/store/1ygs7zdxf77czh60s0x2m080lxkh0i1d-python3.12-conda-libmamba-solver-24.7.0' from 'daemon'
When evaluating attribute ‘python312Packages.conda-libmamba-solver’:
warning: python-include-tests
Consider adding a checkPhase for tests, or if not feasible, pythonImportsCheck.
Near pkgs/development/python-modules/conda-libmamba-solver/default.nix:40:
   |
40 |     description = "Libmamba based solver for conda";
   | ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/python-include-tests.md

rpm-ostree:

warning: EvalError
Cannot evaluate attribute ‘rpm-ostree’ in ‘/nix/store/7izz0k8gilnlz4wii96qkq0rb897r9s1-nixpkgs’.

tdnf:

warning: EvalError
Cannot evaluate attribute ‘tdnf’ in ‘/nix/store/7izz0k8gilnlz4wii96qkq0rb897r9s1-nixpkgs’.

zchunk:

warning: EvalError
Cannot evaluate attribute ‘zchunk’ in ‘/nix/store/7izz0k8gilnlz4wii96qkq0rb897r9s1-nixpkgs’.

Conda error looks unrelated.

Agreed 👍

Result of nixpkgs-review pr 331432 run on x86_64-linux 1

49 packages built:

createrepo_c
dnf-plugins-core (python312Packages.dnf-plugins-core)
dnf-plugins-core.man (python312Packages.dnf-plugins-core.man)
dnf4
dnf4.man
dnf4.py
dnf5
dnf5.man
libdnf
libdnf.dev
libdnf.py (python312Packages.libdnf ,python312Packages.libdnf.dev ,python312Packages.libdnf.py)
libmamba
librepo
librepo.dev
librepo.py (python312Packages.librepo ,python312Packages.librepo.dev ,python312Packages.librepo.py)
libsolv
microdnf
micromamba
python311Packages.conda
python311Packages.conda-libmamba-solver
python311Packages.conda-libmamba-solver.dist
python311Packages.conda.dist
python311Packages.dnf-plugins-core
python311Packages.dnf-plugins-core.man
python311Packages.dnf4
python311Packages.dnf4.man
python311Packages.dnf4.py
python311Packages.libdnf (python311Packages.libdnf.dev ,python311Packages.libdnf.py)
python311Packages.libmambapy
python311Packages.libmambapy.dist
python311Packages.librepo (python311Packages.librepo.dev ,python311Packages.librepo.py)
python312Packages.conda
python312Packages.conda-libmamba-solver
python312Packages.conda-libmamba-solver.dist
python312Packages.conda.dist
python312Packages.dnf4
python312Packages.dnf4.man
python312Packages.dnf4.py
python312Packages.libmambapy
python312Packages.libmambapy.dist
rpm-ostree
rpm-ostree.dev
rpm-ostree.devdoc
rpm-ostree.man
tdnf
zchunk
zchunk.dev
zchunk.lib
zchunk.man


UI updates to research cards

What does this PR do?
UI updates to research cards
What issues does this PR fix or reference?
#459
If this PR changes the UI, include a screenshot below.

currently when you click on the page it opens up a new tab. Can we keep it in the same one?

currently when you click on the page it opens up a new tab. Can we keep it in the same one?

Hey @budzianowski - I've updated it to reflect that


Function parameter typed as never is still required

https://www.typescriptlang.org/play/?ssl=4&ssc=5&pln=4&pc=10#code/C4TwDgpgBAYg9nKBeKAKAhgJwOYC4oB2EAbhJgJTIB8UARggDYToEDcAUOwMZwEDOwKADME+eIhSpKSGsEwBXCBxFwprIA
It looks like the example below shouldn't throw an error since arg is of type never.
type Foo = (arg: never) => boolean;

const foo: Foo = () => true;
foo();

Fixed it by replacing never with void, thanks!


AVRO-2070 tolerate any numbers in GenericDatumWriter while writing primitives in java

Make sure you have checked all steps below.
Jira

[x] My PR addresses the following Avro Jira issues and references them in the PR title. For example, "AVRO-1234: My Avro PR"

https://jira.apache.org/jira/browse/AVRO-2070
In case you are adding a dependency, check if the license complies with the ASF 3rd Party License Policy.

Tests

[x] My PR adds the following unit tests OR does not need testing for this extremely good reason:

Commits

[x] My commits all reference Jira issues in their subject lines. In addition, my commits follow the guidelines from "How to write a good git commit message":

Subject is separated from body by a blank line
Subject is limited to 50 characters (not including Jira issue reference)
Subject does not end with a period
Subject uses the imperative mood ("add", not "adding")
Body wraps at 72 characters
Body explains "what" and "why", not "how"

Documentation

[ ] In case of new functionality, my PR adds documentation that describes how to use it.

All the public functions and the classes in the PR contain Javadoc that explain what it does

@ravowlga123 Would it possible to throw in a couple of tests?

Hi @Fokko I have added a simple test to see if the changes made works. Without the changes in switch cases of GenericDatumWriter the test would return ClassCastException.
Please do let me know if made changes and test added makes sense or if additional changes are required.


SVEN Co-op Template

Added a template for the game SVEN coop, this uses SRCDS so this is fairly simple.

v1 will no longer accept new templates. If you wish to re-open this with v2, we'll be glad to look at it again.


Fix typos and suggested punctuation tweak in StepSuggestedAccounts/index.tsx

Fix a couple of typos in StepSuggestedAccounts/index.tsx.
Edited to add:
After trying out the new onboarding, also a suggested punctuation tweak: changing the period/full stop to a colon.

Happy to help 🫡


Deviation to configure interface port-speed explicitly.

This deviation is for device requiring port-speed reconfiguration, where interface configuration using Replace resets the port-speed to default.
This deviation intent to configure port-speed based on the ondatra.DUTDevice.Port().Speed() when deviation is set to true.
"This code is a Contribution to the OpenConfig Feature Profiles project ("Work") made under the Google Software Grant and Corporate Contributor License Agreement ("CLA") and governed by the Apache License 2.0. No other rights or licenses in or to any of Nokia's intellectual property are granted for any other purpose. This code is provided on an "as is" basis without any warranties of any kind."

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 46.888%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
580

Relevant Lines:
1237

💛  - Coveralls

@xw-g @robshakir

cc: jjing1122

/gcprun


RestAction queue returned failure: [ErrorResponseException] 10011: Unknown Role

General Troubleshooting

[x] I have checked for similar issues.

[x] I have updated to the latest JDA version.

[x] I have checked the branches or the maintainers' PRs for upcoming features/bug fixes.

Issue
Issue Type

[x] Bug Report
[ ] Feature Request

Description
Received

[JDA-Thread JDA] ERROR RestAction - RestAction queue returned failure: [ErrorResponseException] 10011: Unknown Role

when trying to reorder role returned by
message.getGuild().getController().createRole()
    ...
    .queue(role -> {

using
message.getGuild()
    .getController()
    .modifyRolePositions()
    .selectPosition(role)
    .moveTo(4)
    .queue(null, Throwable::printStackTrace);

The github issue tracker is reserved for feature requests and bug reports. Your issue is neither and should be sorted out inside of our discord server. Go to discord.gg/0hMr4ce0tIl3SLv5 to receive the needed help.


Preserve Git username for SSH dependencies

Summary
We're gonna work on a more comprehensive review of whether we should preserve the username here, but for now, git@ is effectively a convention for GitHub and GitLab etc.
Closes https://github.com/astral-sh/uv/issues/6305.

Adding tests...


[CodeCompletion] Do not offer completion Wrapped members for optional key path root type

As described on the SR code completion is offering wrapped member for optional root key path type, which leads to invalid completions in some situations because using key path optional root to access wrapped members is invalid.

Resolves SR-13426.

@swift-ci Please test

cc @varungandhi-apple :)

Build failed
Swift Test OS X Platform
Git Sha - 919db68b36617ffffaad15fea3ecd042e69bd086

@swift-ci Please test MacOS platform

I think what we need to is not removing . before ?. The following example successfully compiles:
struct MyStruct {
  var value: Int { 1 }
}

func foo<T>(x: KeyPath<MyStruct?, T>) {}

let _ = foo(x: \.?.value)
let _ = foo(x: \MyStruct?.?.value)

TIL \.?.value is legal syntax.

TIL as well. It looks like the grammar mentions it: https://docs.swift.org/swift-book/ReferenceManual/Expressions.html#grammar_key-path-components.

TIL \.?.value is legal syntax.

I also didn't known this
Thanks @rintaro, I'll make the changes :)

Changes applied to not erase the . for key path optional root type so completion will result in \.?.wrappedTypeMember
cc @rintaro

@swift-ci Please smoke test


Add ability to specify message text position for Status View component

Feature Request
Issue Description
UX designers have requested the ability to Left-Justify the message prop.  The existing behavior only supports Center-Justify.
Issue Type
Enhancement
Expected Behavior
Ability to set the message text position to either Center-Justify or Left-Justify.

Oops, I opened this issue using my other github account.

@neilpfeiffer can look into this and see if it aligns with Cerner's UX standards.

@aberge00, have your UX designers reach out to me internally with their designs. This does not fit with our current Terra API design for the status-view, but may be possible through theming, but will need to talk through the details more with them to see how best to solve.

UX team has proposed alternate solution via email to achieve the look without modifying current API. Waiting to hear feedback on proposal and will then close out this issue if no modifications needed.


Disconnect Event

Hello,
I am using AsterNET in order to listen to messages from an Asterisk PBX (version 13). This app used to work, but for some time, I often have received the event 'Disconnect' when an incoming call arrives. This event is triggered just before the channels enter into a bridge, and so I have no 'BridgeEnterEvent'.
So I added a few logs to the lib to find out when the app disconnects. And my problem comes from the ManagerReader.cs file (in mrReaderCallbback function). Indeed, the stream receives no data at this moment:
try
{
int count = nstream.EndRead(ar);
if (count == 0)
{
// No received data - it's may be DISCONNECT !!!
if (!is_logoff)
disconnect = true;
return;
}
I'm not sure where the problem comes from. Is this linked to an update of the Asterisk?
Thank you.

There are indeed some issues with ManagerReader.cs, would love someone with some experience to help look at it.


Substitute doesn't work

String substitution is broken: :s/this_string/that_string gives the error message Not an editor command: s/this_string/that_string.

Hi @davidbrochart, this was never been implemented so far, but I take it as a feature request.


Support checking proof in all namespaces

Currently library only accepts names in the .id namespace.
See: https://forum.blockstack.org/t/supporting-blockstack-id-in-all-namespaces/416?u=larry

https://github.com/blockstack/blockstack-proofs-js/commit/4ea5f5eb02bf28507fb66a69562816ee61818ff0

Pushed to npm and released https://github.com/blockstack/blockstack-proofs-js/releases/tag/0.3.0


Failed to Connect

It's not joining voice channel anymore.

4004, reason = not found.
Make sure that you're using the right ID for the voice channel. If you deleted it and remade it or something, this ID will be different.

As far as i can tell all of them are doing it right now, i think its an issue with discord
Just keep looking here: https://status.discordapp.com/

Same here

Any updates?

Can you try changing your server's voice region?


feat: GRD-69803 Removed the unused dependency for Grok

lgtm; We can approve and merge once QA verifies it


Refactor frustum

I have improved the linking between the source and the documentation and distributed the tests into existing ones.
Before we merge, we should fix the definition, since it does not determine the graph uniquely: the following one satisfies the definition as well. I think that what you want is the cartesian product of n-cycle and an edge, don't you?

@Legersky Yes, the definition is obviously flawed. I initially had a more convoluted definition that was shortened to something non-unique. Indeed, the n-Frustum is just the Cartesian product of an n-cycle and an edge, or on a framework level the Minkowski sum of a regular polygon and an edge. Needless to say, that definition is more elegant.


List all updated transient/sub-dependencies in PR

Some sub-dependency updates cause unintended consequences and can happen "silently" and only visible if viewing the diff. For example when updating rubocop-rails, rack got bumped to a non-vulnerable version which has this issue: https://github.com/rack/rack/issues/1432

It would be helpful to list all updated dependencies in the PR body. This might have to be an option as npm/yarn often updates all sub-dependencies which would result in a huge list of dependencies being updated.

Duplicate of #2090


Default App for handling media control buttons?

[macOS] Any way to have GPMDP to be the default for handling the play/pause, skip and previous buttons? I know the app will work with the buttons if you have the app open, but if it's closed it seems to just open iTunes.

I don't believe mac OS gives you the option to pick. However I don't have a mac to test with.

@jostrander No, it does not. I should've worded myself differently; I wanted a way for it to do so, which I know is not there at the moment.

Unfortunately it's not something we can implement, it has to be something Apple creates and implements, which is highly unlikely.


binding.gyp not found when building on Amazon Linux AMI

Here are the contents of the builderror.log files. Has anyone see this issue before? It looks like its trying to run mac specific code for some reason.
./application/node_modules/mongoose/node_modules/mongodb/node_modules/mongodb-core/node_modules/bson/node_modules/bson-ext/builderror.log
xcode-select: error: tool 'xcodebuild' requires Xcode, but active developer directory '/Library/Developer/CommandLineTools' is a command line tools instance
xcode-select: error: tool 'xcodebuild' requires Xcode, but active developer directory '/Library/Developer/CommandLineTools' is a command line tools instance
./application/node_modules/mongoose/node_modules/mongodb/node_modules/mongodb-core/node_modules/bson/builderror.log
gyp: binding.gyp not found (cwd: /tmp/deployment/application/node_modules/mongoose/node_modules/mongodb/node_modules/mongodb-core/node_modules/bson) while trying to load binding.gyp
gyp ERR! configure error
gyp ERR! stack Error: gyp failed with exit code: 1
gyp ERR! stack     at ChildProcess.onCpExit (/opt/elasticbeanstalk/node-install/node-v0.12.2-linux-x64/lib/node_modules/npm/node_modules/node-gyp/lib/configure.js:343:16)
gyp ERR! stack     at ChildProcess.emit (events.js:110:17)
gyp ERR! stack     at Process.ChildProcess._handle.onexit (child_process.js:1074:12)
gyp ERR! System Linux 3.14.35-28.38.amzn1.x86_64
gyp ERR! command "node" "/opt/elasticbeanstalk/node-install/node-v0.12.2-linux-x64/lib/node_modules/npm/node_modules/node-gyp/bin/node-gyp.js" "rebuild"
gyp ERR! cwd /tmp/deployment/application/node_modules/mongoose/node_modules/mongodb/node_modules/mongodb-core/node_modules/bson
gyp ERR! node -v v0.12.2
gyp ERR! node-gyp -v v1.0.3
gyp ERR! not ok
npm ERR! node v0.12.2
npm ERR! npm  v2.7.4
npm ERR! code ELIFECYCLE
npm ERR<EMAIL_ADDRESS>install: node-pre-gyp install --fallback-to-build
npm ERR! Exit status 1

I'm seeing the exact same issue on amazon linux ami. To add a little more context, the app is build on a mac and deployed to elastic beanstalk. It then runs an npm rebuild (not npm install). That's when we get the following errors.
Here is the output of npm-debug.log:
info<EMAIL_ADDRESS>Failed to exec install script
error<EMAIL_ADDRESS>install: node-pre-gyp install --fallback-to-build
error Exit status 8
error Failed at the<EMAIL_ADDRESS>install script.
error This is most likely a problem with the bson-ext package,
error not with npm itself.
error Tell the author that this fails on your system:
error     node-pre-gyp install --fallback-to-build
error You can get their info via:
error     npm owner ls bson-ext
error There is likely additional logging output above.
error System Linux 3.10.57-57.140.amzn1.x86_64
error command "/opt/elasticbeanstalk/node-install/node-v0.10.26-linux-x64/bin/node" "/opt/elasticbeanstalk/node-install/node-v0.10.26-linux-x64/bin/npm" "--production" "rebuild"
error cwd /tmp/deployment/application
error node -v v0.10.26
error npm -v 1.4.4
error code ELIFECYCLE
and for bson-ext/builderror.log
xcode-select: error: tool 'xcodebuild' requires Xcode, but active developer directory '/Library/Developer/CommandLineTools' is a command line tools instance
xcode-select: error: tool 'xcodebuild' requires Xcode, but active developer directory '/Library/Developer/CommandLineTools' is a command line tools instance
and for bson/builderror.log
gyp: binding.gyp not found (cwd: /Users/jeff/sandbox/testBuild/node_modules/mongodb/node_modules/mongodb-core/node_modules/bson) while trying to load binding.gyp
gyp ERR! configure error
gyp ERR! stack Error: gyp failed with exit code: 1
gyp ERR! stack     at ChildProcess.onCpExit (/usr/local/lib/node_modules/npm/node_modules/node-gyp/lib/configure.js:343:16)
gyp ERR! stack     at ChildProcess.emit (events.js:98:17)
gyp ERR! stack     at Process.ChildProcess._handle.onexit (child_process.js:820:12)
gyp ERR! System Darwin 14.3.0
gyp ERR! command "node" "/usr/local/lib/node_modules/npm/node_modules/node-gyp/bin/node-gyp.js" "rebuild"
gyp ERR! cwd /Users/jeff/sandbox/testBuild/node_modules/mongodb/node_modules/mongodb-core/node_modules/bson
gyp ERR! node -v v0.10.36
gyp ERR! node-gyp -v v1.0.1
gyp ERR! not ok

I forgot to mention that a workaround is to change this line: https://github.com/christkv/bson-ext/blob/master/package.json#L38 to:
'"install": "./node_modules/node-pre-gyp/bin/node-pre-gyp.js install --fallback-to-build",
and it builds fine.
Here is some more output that pointed me in that direction:
<EMAIL_ADDRESS>install /tmp/deployment/application/node_modules/mongo-deferred/node_modules/mongodb/node_modules/mongodb-core/node_modules/bson/node_modules/bson-ext

node-pre-gyp install --fallback-to-build

module.js:338
throw err;
^
Error: Cannot find module '../'
at Function.Module._resolveFilename (module.js:336:15)
at Function.Module._load (module.js:278:25)
at Module.require (module.js:365:17)
at require (module.js:384:17)
at Object. (/tmp/deployment/application/node_modules/mongo-deferred/node_modules/mongodb/node_modules/mongodb-core/node_modules/bson/node_modules/bson-ext/node_modules/.bin/node-pre-gyp:15:20)
at Module._compile (module.js:460:26)
at Object.Module._extensions..js (module.js:478:10)
at Module.load (module.js:355:32)
at Function.Module._load (module.js:310:12)
at Function.Module.runMain (module.js:501:10)
npm ERR! Linux 3.14.35-28.38.amzn1.x86_64
npm ERR! argv "/opt/elasticbeanstalk/node-install/node-v0.12.2-linux-x64/bin/node" "/opt/elasticbeanstalk/node-install/node-v0.12.2-linux-x64/bin/npm" "--production" "rebuild"
npm ERR! node v0.12.2
npm ERR! npm  v2.7.4
npm ERR! code ELIFECYCLE
npm ERR<EMAIL_ADDRESS>install: node-pre-gyp install --fallback-to-build
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>install script 'node-pre-gyp install --fallback-to-build'.
npm ERR! This is most likely a problem with the bson-ext package,
npm ERR! not with npm itself.
npm ERR! Tell the author that this fails on your system:
npm ERR!     node-pre-gyp install --fallback-to-build
npm ERR! You can get their info via:
npm ERR!     npm owner ls bson-ext
npm ERR! There is likely additional logging output above.
npm ERR! Please include the following file with any support request:
npm ERR!     /tmp/deployment/application/npm-debug.log
Not using a reverse proxy
Running npm install:  /opt/elasticbeanstalk/node-install/node-v0.12.2-linux-x64/bin/npm
Running npm with --production flag
Failed to run npm install. Snapshot logs for more details.
Traceback (most recent call last):
File "/opt/elasticbeanstalk/containerfiles/ebnode.py", line 610, in
main()
File "/opt/elasticbeanstalk/containerfiles/ebnode.py", line 592, in main
node_version_manager.run_npm_install(options.app_path)
File "/opt/elasticbeanstalk/containerfiles/ebnode.py", line 128, in run_npm_install
self.npm_install(bin_path, self.config_manager.get_container_config('app_staging_dir'))
File "/opt/elasticbeanstalk/containerfiles/ebnode.py", line 159, in npm_install
raise e
subprocess.CalledProcessError: Command '['/opt/elasticbeanstalk/node-install/node-v0.12.2-linux-x64/bin/npm', '--production', 'rebuild']' returned non-zero exit status 1 (Executor::NonZeroExitStatus)

Thanks for this detailed write-up. I am troubled by exact same issue.

@skyle143 thanks for chasing that down.  you're awesome! working on it.

@jlines ok the bson-ext/builderror.log contents are a red herring.  think this might just be because it's being installed in mongoose and there is a $PATH error.


curl_easy_setopt: 4 when using Pkg due to old libcurl version

In windows with a fresh install of juliaup with Julia 1.10.3 when using any command in the Pkg REPL gives out this message:
┌ Error: curl_easy_setopt: 4
└ @ Downloads.Curl C:\Users\aless\.julia\juliaup\julia-1.10.3+0.x64.w64.mingw32\share\julia\stdlib\v1.10\Downloads\src\Curl\utils.jl:50

Everything is working correctly but there is this error continuously

Sorry maybe this is more of a problem of the Downloads.jl package. I reposted here: https://github.com/JuliaLang/Downloads.jl/issues/244

I think now that this is related to the version of libcurl included in julia-1.10.3+0.x64.w64.mingw32\bin\libcurl-4.dll

What makes you say that?

Can we have the conversation in one place?


Using ex_queb via github fails to compile

hi,
I have a PR that is pending to be merged, and so I wanted to use my github fork in mix.exs by the following line:
{:ex_queb, [env: :prod, github: "vraravam/ex_queb", hex: :ex_queb, override: true]},   # NOTE: Transitive dependency: Only reqd till the original authors release a new version with my fixes

But, this is the error I am getting:
module Ecto.Query is not loaded and could not be found

FYI: This doesn't seem to be consistently reproducible.

I've never seen this issue in the past. Its probably something to do with your project/environment. Try rm -rf _build && rm -rf deps and run mix do deps.get, deps.compile, compile


botamusique: init at unstable-2021-01-02

Motivation for this change
This packages botamusique, a bot to play YouTube, radio, local music and more on Mumble.
This was a bit tricky to package. Some notes on that:

pymumble is updated to the latest version. However I had to adjust it slightly for pycryptodome compatibility (which is what nixpkgs uses for pycrypto), see https://github.com/azlux/pymumble/pull/99. I have included this as a patch for now
botamusique isn't a proper python package, it doesn't have a setup.py, see https://github.com/azlux/botamusique/issues/113. So I had to manually wrap its entrypoint script with a python that has all the dependencies, and then create a botamusique binary alias for it.
botamusique has a web frontend, which uses webpack to generate static artifacts. Webpack is based on nodejs, so I used node2nix to generate the dependencies and build the artifacts, mostly as shown here. This is only needed at build time.
For the web frontend, it also uses jinja to instantiate html templates for different languages. So this is also done at build time.
I made two Nix-specific patches so that it works a little better.
The most recent stable release has some problems with template path resolving, which is only fixed in master. So I'm using the unstable version now.
Finally, I added an updateScript so that the package can be updated easily in the future.

Things done

[x] Verified that it works with a file configuration.ini containing[server]
host = <your-mumble-server>

[bot]
volume = 1
tmp_folder = /tmp/botamusique/

[webinterface]
enabled = True

Then running$ botamusique --config configuration.ini

[x] Commands work, e.g. !help and !url <youtube-url>
[x] Web interface works, can upload, shuffle, etc. from it

[x] Verified that the update script work

This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.
Result of nixpkgs-review pr 112972 run on x86_64-darwin 1

7 packages built:

botamusique
python37Packages.pymumble
python37Packages.pyradios
python38Packages.pymumble
python38Packages.pyradios
python39Packages.pymumble
python39Packages.pyradios

The following issues got detected with the above build packages.
Please fix at least the ones listed with your changed packages:

botamusique:

buildPhase should probably contain runHook preBuild and runHook postBuild.
Near pkgs/tools/audio/botamusique/default.nix:86:3:
   |
86 |   buildPhase = ''
   |   ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/missing-phase-hooks.md
installPhase should probably contain runHook preInstall and runHook postInstall.
Near pkgs/tools/audio/botamusique/default.nix:100:3:
    |
100 |   installPhase = ''
    |   ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/missing-phase-hooks.md

python37Packages.pyradios:

Zero tests run by pytest got detected: 'Ran 0 tests in 0.000s'
You have the following options to fix this:

Tell pytest(CheckHook) where to find the tests included in the package
Check if the GitHub Repo contains tests but they are not shipped with Pypi. If so please switch to fetchFromGitHub.
If the Packages does not contain any tests add 'doCheck = false;' and a pythonImportsCheck.

Add a checkPhase for tests, or at least pythonImportsCheck.
See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/python-include-tests.md

python38Packages.pyradios:

Zero tests run by pytest got detected: 'Ran 0 tests in 0.000s'
You have the following options to fix this:

Tell pytest(CheckHook) where to find the tests included in the package
Check if the GitHub Repo contains tests but they are not shipped with Pypi. If so please switch to fetchFromGitHub.
If the Packages does not contain any tests add 'doCheck = false;' and a pythonImportsCheck.

Add a checkPhase for tests, or at least pythonImportsCheck.
See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/python-include-tests.md

python39Packages.pyradios:

Zero tests run by pytest got detected: 'Ran 0 tests in 0.000s'
You have the following options to fix this:

Tell pytest(CheckHook) where to find the tests included in the package
Check if the GitHub Repo contains tests but they are not shipped with Pypi. If so please switch to fetchFromGitHub.
If the Packages does not contain any tests add 'doCheck = false;' and a pythonImportsCheck.

Add a checkPhase for tests, or at least pythonImportsCheck.
See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/python-include-tests.md

This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.
Result of nixpkgs-review pr 112972 run on x86_64-linux 1

7 packages built:

botamusique
python37Packages.pymumble
python37Packages.pyradios
python38Packages.pymumble
python38Packages.pyradios
python39Packages.pymumble
python39Packages.pyradios

The following issues got detected with the above build packages.
Please fix at least the ones listed with your changed packages:

botamusique:

buildPhase should probably contain runHook preBuild and runHook postBuild.
Near pkgs/tools/audio/botamusique/default.nix:86:3:
   |
86 |   buildPhase = ''
   |   ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/missing-phase-hooks.md
installPhase should probably contain runHook preInstall and runHook postInstall.
Near pkgs/tools/audio/botamusique/default.nix:100:3:
    |
100 |   installPhase = ''
    |   ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/missing-phase-hooks.md

python37Packages.pyradios:

Zero tests run by pytest got detected: 'Ran 0 tests in 0.000s'
You have the following options to fix this:

Tell pytest(CheckHook) where to find the tests included in the package
Check if the GitHub Repo contains tests but they are not shipped with Pypi. If so please switch to fetchFromGitHub.
If the Packages does not contain any tests add 'doCheck = false;' and a pythonImportsCheck.

Add a checkPhase for tests, or at least pythonImportsCheck.
See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/python-include-tests.md

python38Packages.pyradios:

Zero tests run by pytest got detected: 'Ran 0 tests in 0.000s'
You have the following options to fix this:

Tell pytest(CheckHook) where to find the tests included in the package
Check if the GitHub Repo contains tests but they are not shipped with Pypi. If so please switch to fetchFromGitHub.
If the Packages does not contain any tests add 'doCheck = false;' and a pythonImportsCheck.

Add a checkPhase for tests, or at least pythonImportsCheck.
See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/python-include-tests.md

python39Packages.pyradios:

Zero tests run by pytest got detected: 'Ran 0 tests in 0.000s'
You have the following options to fix this:

Tell pytest(CheckHook) where to find the tests included in the package
Check if the GitHub Repo contains tests but they are not shipped with Pypi. If so please switch to fetchFromGitHub.
If the Packages does not contain any tests add 'doCheck = false;' and a pythonImportsCheck.

Add a checkPhase for tests, or at least pythonImportsCheck.
See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/python-include-tests.md

They're all addressed/implemented already, that's why I marked them as resolved :)

Sorry, but I cant find where you addressed a couple of them, could you please point me to there? Especially i have trouble finding your reaction on the following points:

botamusique: buildPhase should probably contain runHook preBuild and runHook postBuild.
botamusique: installPhase should probably contain runHook preInstall and runHook postInstall.
pyradios: Zero tests run by pytest got detected

@thelegy Ah I see, automated messages do have the tendency to be ignored. I addressed it now
I also rebased this PR ontop of latest master, updated to a newer pymumble release and the latest botamusique commit. Then made sure to test everything again. I'll merge after checks succeed


all calculations i can do

elchay still needs to add a few then we can complete it

color is always refering to the given piece color and not any other piece on the board

yet again im checking im stepping on a enemy piece and not if my dst is going to be enemy because it would not help me because i could eat him so i only want to know if i can continue, dont care whats next

and I need 2 functions 1 for ally and 1 for enemy because I wont always want both

no no no I cant ask the dst square before i konw if im not getting out of board

it has to be split in to 2 if

1 if is for the current square and the second is for the dst square and if im getting out of board there is no dst square

I NEED THE RETURN PEICE FOR GETTING THE LETTER AND NOT NUMBER...

ALRIGHT BUT GIVE ME A NAME I HAVE NO IDEAS

IM ON CAPS BECAUSE IM DEALING WITH THE DEFINE LOL

ALRIGHT BUT GIVE ME A NAME I HAVE NO IDEAS

get_possible_moves

no no no I cant ask the dst square before i konw if im not getting out of board

if you write:
if (first || second)
and first is false, it will not check second.
i hope

I NEED THE RETURN PEICE FOR GETTING THE LETTER AND NOT NUMBER... MAKES LIFE EASYER

i think its makes life harder


[SyntaxParse] Don't discard 'typealias' without identifier

Fixes round trip issue introduced by #26937

@swift-ci Please smoke test and merge

@swift-ci Please smoke test

@swift-ci Please smoke test


version 1.2 (update)

Hello,
Would it be possible to merge this PR on LedgerHQ ? :) We don't use to review the PR in your repository.
Btw, it would be easier to get in contact ? Do you have any discord or telegram ?
Here is mine : Jean - Ledger#8507
See you


hide loaders in HMR log message

What kind of change does this PR introduce?
bugfix

Did you add tests for your changes?
No. I didn't see any tests for the HMR client.

If relevant, link to documentation update:

Summary
Remove loader information from the updated modules HMR log message. Fixes #4452

Does this PR introduce a breaking change?
no

Other information

Thanks


ak.flatten with axis = 0

Allow ak.flatten(array, axis= 0). As of awkward 0.4.5 I get:
ValueError: axis=0 not allowed for flatten

This would make it possible to pass already flat arrays (it would just return the array as is was) and you wouldn't have to worry about the depth of array.

I couldn't exactly reproduce this, even going back to 0.4.5. If you pass axis=0 to ak.flatten, the case is handled in Python code and you don't get this error message that comes from C++. Tinkering with it, I did find an unhandled corner-case: if you pass the negative axis that is equivalent to axis=0 (such as axis=-2 for a singly jagged array or axis=-1 for a flat array), it missed the check for axis == 0 and went into C++. As far as I can see, that's the only way to encounter this error message.
(The C++ code was written under the assumption that axis == 0 would never be allowed, but it made sense to add that case, though its behavior is entirely different from any other axis value. Since axis == 1 flattens a possibly jagged two-dimensional array into a one-dimensional array, axis == 0 does not change the dimension of any array. However, all flattening operations remove None values, so axis == 0 only removes None from the top level. This is the only behavior that's consistent with the pattern set by all other axis values.)
The only way to express "flatten if not already flat" without exceptions is axis=None:
>>> ak.flatten(ak.Array([[1, 2, 3], [], [4, 5]]), axis=None)
<Array [1, 2, 3, 4, 5] type='5 * int64'>
>>> ak.flatten(ak.Array([1, 2, 3, 4, 5]), axis=None)

Be sure it's what you want, though. Unlike a single-axis flatten, it flattens all levels of depth:
>>> ak.flatten(ak.Array([[[1, 2], [], [3]], [], [[4, 5]]]), axis=None)
<Array [1, 2, 3, 4, 5] type='5 * int64'>

and even flattens records:
>>> ak.flatten(ak.Array([{"x": 1.1, "y": [1]}, {"x": 2.2, "y": [1, 2]}]), axis=None)
<Array [1.1, 2.2, 1, 1, 2] type='5 * float64'>


[opendp] Restore diamond_search_height_ to 400

diamond_search_height_ was originally 400 but has since been changed
to 100. On a design with large macros, the openroad version of opendp
fails but the standalone version works.
The upstream fix to openroad is still being discussed in:
https://github.com/The-OpenROAD-Project/OpenROAD/pull/549
but since it is causing issues with at least one caravel design, restore
the old behaviour until the ultimate fix makes it in.

@antonblanchard: Can you also push the resulting tarball here? the result of running:
cd docker_build/
make build-openroad_app

@antonblanchard: Can you also push the resulting tarball here? the result of running:
cd docker_build/
make build-openroad_app

I pushed it, but haven't had a chance to test. Does the CI use the tarballs to run the tests?

I pushed it, but haven't had a chance to test. Does the CI use the tarballs to run the tests?

@antonblanchard: Yes, the CI uses the existing tarballs, so it tested your update against these designs: https://travis-ci.com/github/efabless/openlane/builds/211992254 and it passed. So, I'm going to go ahead and merge this PR. Thanks!

@antonblanchard: Yes, the CI uses the existing tarballs, so it tested your update against these designs: https://travis-ci.com/github/efabless/openlane/builds/211992254 and it passed. So, I'm going to go ahead and merge this PR. Thanks!


How to remove the top and side part UI's ?

Hi Guys,
I want to know how can i silent the side parts of UI's means i had plotted a graph based on my data , now i want to only show the graph and for that i need to remove the UI's at the sides.
Is there any parameter for doing that ?
Thanks

There is no parameter for doing that but as per the docs, <PivotTableUI> and <PivotTable> have the same API so you can swap one out for the other any time :)

Thanks @nicolaskruchten  for responding.
Actually this is how my render method look like
render() {
        return (
            <PivotTableUI
                data={data}
                onChange={s => this.setState(s)}
                renderers={Object.assign({}, TableRenderers, PlotlyRenderers)}
                {...this.state}
            />
        );
    }

You mean if i am using both <PivotTableUI> and <PivotTableUI> , it is better to use one since both have the same API . That is what you mean ?

I'm saying that you can use <PivotTableUI> if you want the UI, and <PivotTable> if you don't... they take the same inputs.


Feature/normal user tweaks

A couple of small  tweaks:

Remove running snyk-protect on prepublish which required the user to be running as root and as a consequence there is no need to set the user as root
Copy over package.json (as in other repos) to prevent missing asset warnings

:rocket: deployed to http://profiles-pr-70.dev.c2s.nhschoices.net


Improvements to AWS KMS wrapper

region and KMS details are fetched from the recovery key.
Added doc for fetching the key from mysql backend
tool will error out with helpful msg when setting up KMS wrapper fails

@bruj0 added some improvements if you could have a look please.


Should mention the build process needs to be run from the root

In the previous step for setup you navigate to the src/ directory to install npm dependencies, but it's not mentioned in the later run/build steps to navigate back to the root project directory in order to execute those steps.  Would be good for clarity.  Otherwise working perfect, thanks!

Hi @michael-hawker,
Thanks for submitting and the feedback. I'll fix this.


Restrict PAM user names to [A-Z_-]

Currently, users from PAM authentication can register themselves even if their names contain special characters (e.g. CONTOSO\mike). The NETBIOS style will cause all kinds of problems, and email-style name seem to work, but they shouldn't (and they're not necessarily e-mails).

Codecov Report

Merging #10415 into master will decrease coverage by 0.01%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master   #10415      +/-   ##
==========================================
- Coverage   43.74%   43.72%   -0.02%
==========================================
  Files         586      586
  Lines       81265    81268       +3
==========================================
- Hits        35550    35536      -14
- Misses      41316    41330      +14
- Partials     4399     4402       +3

Impacted Files
Coverage Δ

models/login_source.go
25.45% <0%> (-0.18%)
:arrow_down:

modules/indexer/stats/queue.go
62.5% <0%> (-18.75%)
:arrow_down:

modules/indexer/stats/db.go
40.62% <0%> (-9.38%)
:arrow_down:

modules/git/utils.go
65.67% <0%> (-4.48%)
:arrow_down:

models/unit.go
37.03% <0%> (-2.47%)
:arrow_down:

models/notification.go
64.13% <0%> (-1.06%)
:arrow_down:

modules/git/repo.go
46.78% <0%> (-0.92%)
:arrow_down:

services/pull/pull.go
34.89% <0%> (-0.3%)
:arrow_down:

modules/log/event.go
65.64% <0%> (+1.02%)
:arrow_up:

modules/avatar/avatar.go
54% <0%> (+6%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2ed9ead...616877a. Read the comment docs.

Are those same restrictions applied to usernames from other sources?

Should this check not be in models/user.go:CreateUser to prevent this from happening in any situation? It looks like that function already checks for prohibited names but not prohibited patterns. Maybe as its own check or an addition to IsUsableUsername

I'm sorry, this requires more thought. Closing for the moment.


Component not found

The mentioned component in the documentation, the nrf24 gtmini is nowhere to be found on the internet. I'm trying to build one of these at home, so please confirm whether it is the same as the nrf24l01. Thanks in advance

i got them on aliexpress

Hi @ArulGandhi
in the breadboard version, it's okay to use any type of nRF24, but in the PCB, it should be GT24 mini version. Here is the link for it.
https://www.aliexpress.com/i/4001134750735.html

Thanks a lot for confirming!


Report control blocks not attaching trigger options or optional fields

When I add a report control block the save under the options doesn't seem to work. Whenever I change and enter data nothing happens. When I then change the RCB it resets them all giving and error. If I edit the saved SCD and add these options then open the project it is ok

Thanks danyill.
I was asked to look at the tool at the CIGRE meeting and was playing with the functionality. The GOOSE seemed to work ok. Haven't tried SV yet
Regards,
Ian YOUNG

Ian YOUNG   |    Schneider Electric   |   Energy Business   |   Australia   |   Applications Manager
Phone: +61 2 9125 9373   |   Mobile: +61 419 698 801
Email<EMAIL_ADDRESS> |   Site: www. schneider-electric.com/au   |   Address: 50 Stennett Road, Ingleburn NSW 2565 AUSTRALIA
*** Please consider the environment before printing this e-mail
General
From: danyill @.>
Sent: Friday, November 29, 2024 2:08 PM
To: transpower-nz/open-scd @.>
Cc: Ian YOUNG @.>; Author @.>
Subject: Re: [transpower-nz/open-scd] Report control blocks not attaching trigger options or optional fields (Issue #30)
[External email: Use caution with links and attachments]

I can reproduce -- it looks like this functionality is not implemented yet, sorry.

Reply to this email directly, view it on GitHubhttps://github.com/transpower-nz/open-scd/issues/30#issuecomment-2507012952, or unsubscribehttps://github.com/notifications/unsubscribe-auth/BNJ5R354ZE75TOYYDWZMXUT2C7LAXAVCNFSM6AAAAABSWDNXVKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKMBXGAYTEOJVGI.
You are receiving this because you authored the thread.Message ID<EMAIL_ADDRESS>

Thanks danyill. I was asked to look at the tool at the CIGRE meeting and was playing with the functionality. The GOOSE seemed to work ok. Haven't tried SV yet

All good - please log as many issues as you can find 😉

I believe this is available now.
To refresh, suggest pressing Ctrl + F5.
Thanks for reporting, please re-open if it is not fixed.

It now adds the options but puts TrgOps after OptFields which it reports as invalid

Yes, I see that it depends on the order of options, let me look into that.

If you add the items in the right order it works. But you have to add the Trigger Options first, followed by Optional Fields then lastly add the max clients

Yes, it will be fixed soon, just waiting for the fix to be reviewed. Thanks
for the update 👍
On Tue, 3 Dec 2024, 20:14 IanYoung77, @.***> wrote:

If you add the items in the right order it works. But you have to add the
Trigger Options first, followed by Optional Fields then lastly add the max
clients
—
Reply to this email directly, view it on GitHub
https://github.com/transpower-nz/open-scd/issues/30#issuecomment-2513728991,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAFEXX4WYKRVMDBF7SDKTSL2DVK4ZAVCNFSM6AAAAABSWDNXVKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKMJTG4ZDQOJZGE
.
You are receiving this because you modified the open/close state.Message
ID: @.***>

I'm fairly sure it's correct now.
A hard refresh (Ctrl + F5) should give you the latest version. Thanks for all the feedback.


Error when running visualizer on Ubuntu 20.04

I tried to install robot-log-visualizer on my Ubuntu 20.04.5 LTS
I tried:
https://github.com/ami-iit/robot-log-visualizer#-install-from-pip-with-apt-python
https://github.com/ami-iit/robot-log-visualizer#-use-the-appimage
and
mamba install -c robotology robot-log-visualizer

in all cases, I got the following error when running the visualizer:
You can open the visualizer by visiting the following URL:
http://<IP_ADDRESS>:7000/static/
Traceback (most recent call last):
  File "/home/gnava/Software/python_projets/MPC/venv/bin/robot-log-visualizer", line 8, in <module>
    sys.exit(main())
  File "/home/gnava/Software/python_projets/MPC/venv/lib/python3.8/site-packages/robot_log_visualizer/__main__.py", line 38, in main
    gui = RobotViewerMainWindow(
  File "/home/gnava/Software/python_projets/MPC/venv/lib/python3.8/site-packages/robot_log_visualizer/ui/gui.py", line 122, in __init__
    self.toolButton_on_click()
  File "/home/gnava/Software/python_projets/MPC/venv/lib/python3.8/site-packages/robot_log_visualizer/ui/gui.py", line 248, in toolButton_on_click
    PlotItem(signal_provider=self.signal_provider, period=self.animation_period)
  File "/home/gnava/Software/python_projets/MPC/venv/lib/python3.8/site-packages/robot_log_visualizer/ui/plot_item.py", line 17, in __init__
    self.canvas = MatplotlibViewerCanvas(
  File "/home/gnava/Software/python_projets/MPC/venv/lib/python3.8/site-packages/robot_log_visualizer/plotter/matplotlib_viewer_canvas.py", line 45, in __init__
    self.vertical_line_anim = animation.FuncAnimation(
  File "/home/gnava/Software/python_projets/MPC/venv/lib/python3.8/site-packages/matplotlib/animation.py", line 1659, in __init__
    super().__init__(fig, **kwargs)
  File "/home/gnava/Software/python_projets/MPC/venv/lib/python3.8/site-packages/matplotlib/animation.py", line 1394, in __init__
    super().__init__(fig, event_source=event_source, *args, **kwargs)
  File "/home/gnava/Software/python_projets/MPC/venv/lib/python3.8/site-packages/matplotlib/animation.py", line 875, in __init__
    self._setup_blit()
  File "/home/gnava/Software/python_projets/MPC/venv/lib/python3.8/site-packages/matplotlib/animation.py", line 1192, in _setup_blit
    self._init_draw()
  File "/home/gnava/Software/python_projets/MPC/venv/lib/python3.8/site-packages/matplotlib/animation.py", line 1723, in _init_draw
    self._drawn_artists = self._init_func()
  File "/home/gnava/Software/python_projets/MPC/venv/lib/python3.8/site-packages/robot_log_visualizer/plotter/matplotlib_viewer_canvas.py", line 124, in init_vertical_line
    return self.vertical_line, *(self.active_paths.values())
AttributeError: 'MatplotlibViewerCanvas' object has no attribute 'active_paths'

which is strange, as the attribute active_paths is defined inside the class and looks indented correctly.

Can you run apt list --installed, and pip list --verbose  and mamba list  in all the environment in which you tried? Thanks

Mamba
apt_list_mamba.txt
pip_list_mamba.txt
mamba_list.txt
Python project environment
apt_list_python.txt
pip_list_python.txt
and there in no mamba list in this case

I confirm having the same issue when trying to run the visualizer.
I'm using the installation via robotology-superbuild source compilation and the dependencies are handled by Conda. The OS is Arch Linux. There could be some interference with system libraries but I made sure that Python and PyQt5 packages used are from Conda. I tried both versions 0.2.2 and 0.3.0 and they both produce the same error.
Interestingly. Using the AppImage installation, I got the error while installing version 0.3.0, but not with version 0.2.2, where it seems to be working fine!

I am not sure what is happening, but can you try to move the line self.active_paths = {} from https://github.com/ami-iit/robot-log-visualizer/blob/82aa5ba1c92599672365b5393d520a049e28a3ac/robot_log_visualizer/plotter/matplotlib_viewer_canvas.py#L54 before the block:
        self.vertical_line_anim = animation.FuncAnimation(
            self.fig,
            self.update_vertical_line,
            init_func=self.init_vertical_line,
            interval=self.periond_in_ms,
            blit=True,
        )

?

I am not sure what is happening, but can you try to move the line self.active_paths = {}

I moved the line and re-installed the app, and it works with no error..
I can't see the robot's visualizer though, I can only see it from the browser if I use the provided URL. I don't think it's related to this modification though.

this suggestion worked for me, now I can open the visualizer!

Can anyone open the PR with the fix? Thanks!

PR opened: https://github.com/ami-iit/robot-log-visualizer/pull/49


Removing dead link

Hey @jaywcjlove
just removing a dead link.
Cheers!
NOTE: A similar PR may already be submitted! Please search among the Pull request before creating one.
Types of Changes
What types of changes does your PR introduce? Put an x in all boxes that apply

[ ] New addition to list
[ ] Fixing bug in existing item in list
[x] Removing item from list
[ ] Changing structure (organization) of list

Proposed Changes
Describe each of your changes here to communicate to the maintainers why we should accept this pull request.

If you're adding something to the list, be sure to explain why it should be added.
If you're fixing a bug or resolving a feature request, be sure to link to that issue.

PR Checklist
Put an x in the boxes once you've completed each step. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

[x] I have read the CONTRIBUTING guide
[ ] I have explained why this PR is important
[ ] I have added necessary documentation (if appropriate)

Further Comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

@spekulatius thx!

No worries :+1:


Add a DTLS handshake fragmentation test

This PR is a continuation of https://github.com/ARMmbed/mbedtls/pull/3071.
Due to CI failures, I have dropped the static keyword from before log_pattern, added a MBEDTLS_DEBUG_C dependency to tests due to log parsing, and added MBEDTLS_DEBUG_C guards around mbedtls_debug_set_threshold and mbedtls_ssl_conf_dbg calls.
Tested manually with and without MBEDTLS_DEBUG_C.

Some CI failures remain (on Windows):

Build FAILED.

       "C:\builds\ws\3074-merge-TO76MVGPRN6UINGOXIFRZ\worktrees\tmpn8xawbad\cmake_solution\mbed TLS.sln" (Rebuild target) (1) ->
       "C:\builds\ws\3074-merge-TO76MVGPRN6UINGOXIFRZ\worktrees\tmpn8xawbad\cmake_solution\ALL_BUILD.vcxproj.metaproj" (Rebuild target) (2) ->
       "C:\builds\ws\3074-merge-TO76MVGPRN6UINGOXIFRZ\worktrees\tmpn8xawbad\cmake_solution\tests\test_suite_ssl.vcxproj.metaproj" (Rebuild target) (136) ->
       "C:\builds\ws\3074-merge-TO76MVGPRN6UINGOXIFRZ\worktrees\tmpn8xawbad\cmake_solution\tests\test_suite_ssl.vcxproj" (Rebuild target) (262) ->
       (ClCompile target) ->
         C:/builds/ws/3074-merge-TO76MVGPRN6UINGOXIFRZ/worktrees/tmpn8xawbad/tests/suites/test_suite_ssl.function(28): error C2275: 'log_pattern' : illegal use of this type as an expression [C:\builds\ws\3074-merge-TO76MVGPRN6UINGOXIFRZ\worktrees\tmpn8xawbad\cmake_solution\tests\test_suite_ssl.vcxproj]
         C:/builds/ws/3074-merge-TO76MVGPRN6UINGOXIFRZ/worktrees/tmpn8xawbad/tests/suites/test_suite_ssl.function(28): error C2065: 'p' : undeclared identifier [C:\builds\ws\3074-merge-TO76MVGPRN6UINGOXIFRZ\worktrees\tmpn8xawbad\cmake_solution\tests\test_suite_ssl.vcxproj]
         C:/builds/ws/3074-merge-TO76MVGPRN6UINGOXIFRZ/worktrees/tmpn8xawbad/tests/suites/test_suite_ssl.function(29): error C2065: 'p' : undeclared identifier [C:\builds\ws\3074-merge-TO76MVGPRN6UINGOXIFRZ\worktrees\tmpn8xawbad\cmake_solution\tests\test_suite_ssl.vcxproj]
         C:/builds/ws/3074-merge-TO76MVGPRN6UINGOXIFRZ/worktrees/tmpn8xawbad/tests/suites/test_suite_ssl.function(30): error C2065: 'p' : undeclared identifier [C:\builds\ws\3074-merge-TO76MVGPRN6UINGOXIFRZ\worktrees\tmpn8xawbad\cmake_solution\tests\test_suite_ssl.vcxproj]
         C:/builds/ws/3074-merge-TO76MVGPRN6UINGOXIFRZ/worktrees/tmpn8xawbad/tests/suites/test_suite_ssl.function(30): error C2223: left of '->pattern' must point to struct/union [C:\builds\ws\3074-merge-TO76MVGPRN6UINGOXIFRZ\worktrees\tmpn8xawbad\cmake_solution\tests\test_suite_ssl.vcxproj]
         C:/builds/ws/3074-merge-TO76MVGPRN6UINGOXIFRZ/worktrees/tmpn8xawbad/tests/suites/test_suite_ssl.function(31): error C2065: 'p' : undeclared identifier [C:\builds\ws\3074-merge-TO76MVGPRN6UINGOXIFRZ\worktrees\tmpn8xawbad\cmake_solution\tests\test_suite_ssl.vcxproj]
         C:/builds/ws/3074-merge-TO76MVGPRN6UINGOXIFRZ/worktrees/tmpn8xawbad/tests/suites/test_suite_ssl.function(31): error C2223: left of '->pattern' must point to struct/union [C:\builds\ws\3074-merge-TO76MVGPRN6UINGOXIFRZ\worktrees\tmpn8xawbad\cmake_solution\tests\test_suite_ssl.vcxproj]
         C:/builds/ws/3074-merge-TO76MVGPRN6UINGOXIFRZ/worktrees/tmpn8xawbad/tests/suites/test_suite_ssl.function(31): error C2198: 'strstr' : too few arguments for call [C:\builds\ws\3074-merge-TO76MVGPRN6UINGOXIFRZ\worktrees\tmpn8xawbad\cmake_solution\tests\test_suite_ssl.vcxproj]
         C:/builds/ws/3074-merge-TO76MVGPRN6UINGOXIFRZ/worktrees/tmpn8xawbad/tests/suites/test_suite_ssl.function(33): error C2065: 'p' : undeclared identifier [C:\builds\ws\3074-merge-TO76MVGPRN6UINGOXIFRZ\worktrees\tmpn8xawbad\cmake_solution\tests\test_suite_ssl.vcxproj]
         C:/builds/ws/3074-merge-TO76MVGPRN6UINGOXIFRZ/worktrees/tmpn8xawbad/tests/suites/test_suite_ssl.function(33): error C2223: left of '->counter' must point to struct/union [C:\builds\ws\3074-merge-TO76MVGPRN6UINGOXIFRZ\worktrees\tmpn8xawbad\cmake_solution\tests\test_suite_ssl.vcxproj]

    0 Warning(s)
    10 Error(s)

Moved log_pattern definition to the beginning of the function, added log threshold resetting in exit, and fixed cosmetic errors.

Some CI failures remain (on Windows):

Build FAILED.

       "C:\builds\ws\3074-merge-TO76MVGPRN6UINGOXIFRZ\worktrees\tmpn8xawbad\cmake_solution\mbed TLS.sln" (Rebuild target) (1) ->
       "C:\builds\ws\3074-merge-TO76MVGPRN6UINGOXIFRZ\worktrees\tmpn8xawbad\cmake_solution\ALL_BUILD.vcxproj.metaproj" (Rebuild target) (2) ->
       "C:\builds\ws\3074-merge-TO76MVGPRN6UINGOXIFRZ\worktrees\tmpn8xawbad\cmake_solution\tests\test_suite_ssl.vcxproj.metaproj" (Rebuild target) (136) ->
       "C:\builds\ws\3074-merge-TO76MVGPRN6UINGOXIFRZ\worktrees\tmpn8xawbad\cmake_solution\tests\test_suite_ssl.vcxproj" (Rebuild target) (262) ->
       (ClCompile target) ->
         C:/builds/ws/3074-merge-TO76MVGPRN6UINGOXIFRZ/worktrees/tmpn8xawbad/tests/suites/test_suite_ssl.function(28): error C2275: 'log_pattern' : illegal use of this type as an expression [C:\builds\ws\3074-merge-TO76MVGPRN6UINGOXIFRZ\worktrees\tmpn8xawbad\cmake_solution\tests\test_suite_ssl.vcxproj]
         C:/builds/ws/3074-merge-TO76MVGPRN6UINGOXIFRZ/worktrees/tmpn8xawbad/tests/suites/test_suite_ssl.function(28): error C2065: 'p' : undeclared identifier [C:\builds\ws\3074-merge-TO76MVGPRN6UINGOXIFRZ\worktrees\tmpn8xawbad\cmake_solution\tests\test_suite_ssl.vcxproj]
         C:/builds/ws/3074-merge-TO76MVGPRN6UINGOXIFRZ/worktrees/tmpn8xawbad/tests/suites/test_suite_ssl.function(29): error C2065: 'p' : undeclared identifier [C:\builds\ws\3074-merge-TO76MVGPRN6UINGOXIFRZ\worktrees\tmpn8xawbad\cmake_solution\tests\test_suite_ssl.vcxproj]
         C:/builds/ws/3074-merge-TO76MVGPRN6UINGOXIFRZ/worktrees/tmpn8xawbad/tests/suites/test_suite_ssl.function(30): error C2065: 'p' : undeclared identifier [C:\builds\ws\3074-merge-TO76MVGPRN6UINGOXIFRZ\worktrees\tmpn8xawbad\cmake_solution\tests\test_suite_ssl.vcxproj]
         C:/builds/ws/3074-merge-TO76MVGPRN6UINGOXIFRZ/worktrees/tmpn8xawbad/tests/suites/test_suite_ssl.function(30): error C2223: left of '->pattern' must point to struct/union [C:\builds\ws\3074-merge-TO76MVGPRN6UINGOXIFRZ\worktrees\tmpn8xawbad\cmake_solution\tests\test_suite_ssl.vcxproj]
         C:/builds/ws/3074-merge-TO76MVGPRN6UINGOXIFRZ/worktrees/tmpn8xawbad/tests/suites/test_suite_ssl.function(31): error C2065: 'p' : undeclared identifier [C:\builds\ws\3074-merge-TO76MVGPRN6UINGOXIFRZ\worktrees\tmpn8xawbad\cmake_solution\tests\test_suite_ssl.vcxproj]
         C:/builds/ws/3074-merge-TO76MVGPRN6UINGOXIFRZ/worktrees/tmpn8xawbad/tests/suites/test_suite_ssl.function(31): error C2223: left of '->pattern' must point to struct/union [C:\builds\ws\3074-merge-TO76MVGPRN6UINGOXIFRZ\worktrees\tmpn8xawbad\cmake_solution\tests\test_suite_ssl.vcxproj]
         C:/builds/ws/3074-merge-TO76MVGPRN6UINGOXIFRZ/worktrees/tmpn8xawbad/tests/suites/test_suite_ssl.function(31): error C2198: 'strstr' : too few arguments for call [C:\builds\ws\3074-merge-TO76MVGPRN6UINGOXIFRZ\worktrees\tmpn8xawbad\cmake_solution\tests\test_suite_ssl.vcxproj]
         C:/builds/ws/3074-merge-TO76MVGPRN6UINGOXIFRZ/worktrees/tmpn8xawbad/tests/suites/test_suite_ssl.function(33): error C2065: 'p' : undeclared identifier [C:\builds\ws\3074-merge-TO76MVGPRN6UINGOXIFRZ\worktrees\tmpn8xawbad\cmake_solution\tests\test_suite_ssl.vcxproj]
         C:/builds/ws/3074-merge-TO76MVGPRN6UINGOXIFRZ/worktrees/tmpn8xawbad/tests/suites/test_suite_ssl.function(33): error C2223: left of '->counter' must point to struct/union [C:\builds\ws\3074-merge-TO76MVGPRN6UINGOXIFRZ\worktrees\tmpn8xawbad\cmake_solution\tests\test_suite_ssl.vcxproj]

    0 Warning(s)
    10 Error(s)

Should be fixed :)

Should be fixed :)

I await your push


Canvas renderer visual bug

Overview
The canvas renderer displays visual bugs. It looks like the background is not being cleared before a new frame is drawn.
I've created a repro for the issue:

react-lottie-player

The issue is also present in lottie-player but is not present in lottie-web.

lottie-player
lottie-web

For the repro cases I've used an animation file from the Lottie site but I first noticed this with a different animation so it seems that it's not the animation file itself.
Consuming repo
react-lottie-player
...
Labels

[ ] Add the Type: Bug label to this issue.

This is potentially the same issue as: https://github.com/LottieFiles/lottie-player/issues/211

If anyone else comes across this, there's a setting already in the library to handle clearing the canvas on re-draw. I didn't see it in the docs anywhere though. Can pass it as rendererSettings to the Player component. Properties you can pass are in this defaultOptions object: https://github.com/LottieFiles/lottie-react/blob/master/src/Player.tsx#L101-L106
<Player
  src={"./animation.json"}
  renderer={"canvas"}
  rendererSettings={{clearCanvas: true}} // Clears on re-draw
/>


Further improvements to README

Improves wording mentioned in #148 and cleans up the display / structure a bit.

Thanks!