Versioned documentation

Summary
Adding versioning to argo-workflows docs https://argoproj.github.io/argo-workflows/
Use Cases
When searching docs for the specific version of argo workflows you have deployed
Currently argo-cd has versioning in their documentation. Was introduced with this PR
Would require setup and then migration/rewriting of docs to have docs split by version.

Message from the maintainers:
Love this enhancement proposal? Give it a 👍. We prioritise the proposals with the most 👍.

Happy to help with the re-write. I have tried to set up versioning in the past, and failed so I need an adult to help me get that bit set up.

Tim and I just remembered why the Argo Workflows docs weren't an easy switch like it seemed it was for Argo CD's docs: Argo Workflows isn't using Readthedocs for its docs website.
I believe this means we need to scope out a way to incorporate versioning into the mkdocs build of the Argo Workflows docs.
Resources related to this:

https://pypi.org/project/mkdocs-versioning/
https://squidfunk.github.io/mkdocs-material/setup/setting-up-versioning/

This would be useful for features that have yet to be released as well. Just had someone file an issue for a feature I wrote that hasn't been released yet (c.f. https://github.com/argoproj/argo-workflows/issues/11412 / https://github.com/argoproj/argo-workflows/pull/11445). Similar to how Argo CD has the latest version of the docs.
This gets into some complications about versioned docs that I've run into before too:

A docs improvement or clarification can be back-ported to old docs versions
New docs for previously undocumented features can be back-ported to old docs too (such as #11297)
Docs about new features should be released with the feature
Generated docs should follow the same principles

Or, in other words, SemVer applies to docs too 😅

Just jotting down here that in the previous contributor meeting (on Aug 15th), we discussed that moving to Read the Docs like Argo CD may be easier and more consistent than adding versioning to mkdocs.
Briefly mentioned redirects as well. If that is the target state, I may want to hold off adding some mkdocs plugins, like one for redirects as I mentioned in #11516.
Different kinds of redirects potentially. The one discussed in the meeting would be to ensure that old docs all redirect to new docs if there is a migration. The one I mentioned in the PR above is for internal redirects, i.e. if we change the URL of a page, that we can add a redirect to the new page.
Redirects are very important to make sure old links to the docs continue working and don't just summarily break, causing confusion and churn in the ecosystem.

Getting started on this by setting up readthedocs.io.

@crenshaw-dev do we have a central readthedocs.io account for all argoproj accounts or do we currently have one or personal readthedocs.io accounts?  I ask, if we have one account I'd like to get access to get argo-workflows setup.  /cc @terrytangyuan
I've created my own account, username is jmeridth.  Would prefer to not setup under my account but can and maybe transfer or add other owners.

I don't think there is any specific project in RTD yet. Feel free to start one.

Just jotting down here that in the previous contributor meeting (on Aug 15th), we discussed that moving to Read the Docs like Argo CD may be easier and more consistent than adding versioning to mkdocs.
Briefly mentioned redirects as well. If that is the target state, I may want to hold off adding some mkdocs plugins, like one for redirects as I mentioned in #11516.

Noting here that JM and I discussed this offline and we were slightly mistaken there.
Argo CD is using mkdocs for the docs build system as well, but is hosting docs on RTD, while Workflows was hosting on GH Pages.
Now CD, Workflows, and Rollouts are all hosted on RTD, just Events is still leftover hosted on GH Pages and therefore doesn't have documentation versions yet.
CD and Workflows also both redirect from their old GH Pages host to RTD. Rollouts does not have a redirect from its old GH Pages site, so that still needs an update. Also its GH Pages site has a versions drop-down, but doesn't actually support versions on GH Pages. I'll file an issue for this shortly in Rollouts.
CD, Workflows, Rollouts, and Events are all on the same docs build system, mkdocs, and have all been on it for as long as I know at least.
To be specific, RTD isn't a docs build system at all, it's purely a docs host. So I've actually been fine to add mkdocs plugins this whole time and so will be doing that shortly. Redirects and Mermaid support are two plugins in particular that we need.
There are still two tiny differences right now though.
One is that Workflows (and Events) doesn't have the version drop-down in the top bar of the docs, but we can probably implement that by adding the extra_css and extra_js that CD and Rollouts have for a versions.css and versions.js file. Would be good to add for consistency once we properly backport some versions of the docs.
The other is that CD and Rollouts use a sidebar for all sections and no topbar tabs what-so-ever.  Workflows and Events both have topbar tabs. We may want to move to doing the same as CD or vice-versa. (My memory might be wrong here, but I could've sworn CD used to have topbar tabs too and then changed from that at some point in time, as I vaguely remember being disoriented at CD's docs one day in the past. Will add a link to a PR there if I can find one and that actually happened 😅)

Would be good to add for consistency once we properly backport some versions of the docs. Right now we have the little floating bottom version overlay button instead (seems to be the RTD default?)

Update: RTD has made this a good bit bigger now:

And added its own warning about latest vs. stable docs:
Seems to have rolled out sometime in the past few days.

We can probably implement that by adding the extra_css and extra_js that CD and Rollouts have for a versions.css and versions.js files.

So part of this is no longer necessary. These scripts also tend to break when RTD updates, so perhaps being consistent with RTD and letting it do its own thing makes more sense, and maybe CD should remove their customization 🤷 .
For instance, right now there's a duplicate version drop-down in CD at the bottom of the page:

And previously: https://github.com/argoproj/argo-cd/issues/11999, https://github.com/argoproj/argo-cd/pull/13102, etc


Custom and interactive install

This does a few things to make installation customizable.
The --no-modify-path flag disables PATH modification. rustup-setup.sh passes its arguments to rustup-setup.exe.
During the default interactive installation you can press "a" to enter "advanced installation", which just asks you the values of the two things that can be configured (path modification and default toolchain). We need this feature because it's the only way to change the installation options without finding out the command line options and starting installation over.
Here's what it looks like in action.
It could be a lot nicer still, but this is all the features I expect.
Fixes https://github.com/rust-lang-nursery/multirust-rs/issues/271, https://github.com/rust-lang-nursery/multirust-rs/issues/170.

Sounds/looks good to me! Looks like tests are failing but otherwise r=me

@bors r=alexcrichton

@bors r=alexcrichton

what kind of process i could install rust ?

@Victorcccc That image shows several issues.  The first is that you've given an invalid value for profile which will result in installation later down the line.  The examples given (minimal/default/complete) are the valid values there, and I'd strongly recommend leaving it at default unless you have good reason to change it.  As for the error you hilighted, it suggests that your .bash_profile is a directory rather than a file, which rustup certainly isn't expecting.  If you have some unusual setup for your shell configurations then I suggest you set it to not modify PATH itself, and deal with that afterwards in whatever manner your personal configurations require.  If you continue to have problems, then filing a fresh issue, rather than replying to a pull request from almost four years ago would be more sensible.
Good luck, I hope you manage to resolve your installation problem, and welcome to Rust.


[BUG] BackupBackingImage Create failed because it failed to get the BackingImage

Describe the bug
BackupBackingImage Name is now not the same as the BackingImage due to multiple backupstore
To Reproduce
test_backing_image.py e2e test failed.
Expected behavior
test_backing_image.py e2e test passed.

PR: https://github.com/longhorn/longhorn-manager/pull/3367

@ChanYiLin Merged.

thanks
the e2e test also passed.
https://ci.longhorn.io/job/private/job/longhorn-tests-regression/7862/

@derekbit
I have moved to ready for testing.

Verified pass on longhorn master(https://github.com/longhorn/longhorn-manager/commit/def8a3b392be7380a85ef74d688c86456c03c791), longhorn v1.8.0-rc1(https://github.com/longhorn/longhorn-manager/commit/b59110d2488208f4f15ebc3bf3ce5e66eb344ffb)
e2e Test Backing Image Basic Operation passed

master
v1.8.0-rc1

regression test_backing_image.py test cases all passed

master
v1.8.0-rc1


fix(Container): Text alignment bugs out on Firefox

Steps to Reproduce

Use Firefox and 1080p screen
Click on "Edit code" in Container --> Text Alignment
Main container (not the side bar) bugs out - totally unable to scroll up or down

Expected
4. Expected to be able to scroll down to see the code
Result
5. Does not happen
Testcase
Unclear what the testcase should be, sorry!

Works now


nz-form-control validation does not work inside a component (using ng-content for the input control)

Reproduction link
https://stackblitz.com/edit/ng-zorro-antd-ivy-kd7qpf
Steps to reproduce

Create a simple wrapper component that wraps nz-form-item with a child nz-form-control, specify an nzErrorTip and use ng-content to deliver the input (other form/entry field control) to the nz-form-control.
Create a test page/component with a form.
Then use this wrapper component inside the test page/component. Using Reactive Forms to create a FormGroup with a FormControl that has a validator and assign it to the input control that is used as the content for the wrapper component.
Run the application and enter some data to trigger a validation error.

What is expected?
Validation errors should show, even when the content of an nz-form-control is passed to it using an ng-content. (or there should be a workaround).
What is actually happening?
Validation errors are not showing.

Environment
Info

ng-zorro-antd
9.3.0

Browser
All (tested in Chrome   FireFox)

The problem and reasoning behind this is that almost all of our form controls use the exact same setup/layout. This causes the nz-form-item, nz-form-control and nz-form-label blocks, including their [nzSm] and [nzErrorTip] values to be copied over and over aside from the inner component. Using a wrapper-component this:
<nz-form-item>
<nz-form-label [nzSm]="4" [nzXs]="24" nzFor="name" class="text-right">Name</nz-form-label>
<nz-form-control [nzSm]="12" [nzXs]="24" nzErrorTip="This field is required!">
<input nz-input formControlName="name" id="name" />
</nz-form-control>
</nz-form-item>
Can be brought down to something like:
<app-form-item labelFor="name" labelText="Name">
<input nz-input formControlName="name" id="name" />
</app-form-item>
Which works, except for the validation.

I think nz-form-item should be support nzLabel  and all props of nz-form-label, like :
<nz-form-item nzLabel="Name"  [nzRequired]="true" [nzNoColon]="true" nzFor="name">
  <input nz-input formControlName="name" id="name" />
</nz-form-item>

问题解决了吗，我在9版本是可以用的，升级11后，错误样式没有了

Was this problem solved?

export class AppFormItemComponent {
  @Input() labelFor: string;
  @Input() labelText: string;
  @Input() parent: FormGroup;

app-form-item.component.html
<ng-container [formGroup]="parent">
  <nz-form-item>
    <nz-form-label [nzSm]="4" [nzXs]="24" nzFor="{{ lblFor }}" class="text-right">{{ labelText }}

<app-form-item [parent]="myFormGroup" labelFor="name2" labelText="Name (does not show any validation errors)">
    <input nz-input formControlName="name2" id="name2" />
</app-form-item>

这个问题一直没有解决吗？  求个解决方案

现在没有用angular，都忘记啥问题了
---- 回复的原邮件 ----
| 发件人 | @.> |
| 日期 | 2023年01月09日 11:10 |
| 收件人 | @.> |
| 抄送至 |<EMAIL_ADDRESS>|
| 主题 | Re: [NG-ZORRO/ng-zorro-antd] nz-form-control validation does not work inside a component (using ng-content for the input control) (#5642) |
这个问题一直没有解决吗？ 求个解决方案
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you commented.Message ID: @.***>

the problem is that the formstatus service is provided in the nzformcontrol
when we use content projection like in the current example, the input as no formstatus service to inject, since DI work only for 1 level of content projection.
As a solution, formstatus of all form controls should be managed in the nz-form.

I've been having a similar issue with a component implementing both ControlValueAccessor and Validator.
In my case, the component's template includes an <nz-form-control tag with an nzErrorTip string.
The error tip appears briefly while the field is in an invalid state, but then the error tip disappears a few milliseconds after the validation error is detected.
I found a really ugly workaround though through CSS manipulation in the component's SCSS file:
:host ::ng-deep {
  .ant-form-item-explain-connected {
    opacity: 1;
  }
}

This seems to prevent the nzErrorTip text from disappearing.

ups just faced this issue after creating my reusable form component! 4 years after and there is no solution or workaround?

For those who still looking for the answer and Antd team no longer maintains this issue, I have a a work around like this:
1.  At the parent component, where stores the FormGroup, create a getter function to get the error:
  getFieldError(fieldName: string): string {
    const formControl = this.formGroupName.get(fieldName);

    return formControl.errors && formControl.dirty ? Object.keys(formControl.errors)[0] : null;
  }

2. Parent template file:
  <custom-component [error]="getFieldError('username')" label="User name">
    <input nz-input type="text" formControlName="username" />
  </custom-component>

3. Custom component template
<nz-form-item>
  <nz-form-label>
    {{ label }}
  </nz-form-label>

  <nz-form-control>
    <ng-content></ng-content>
    <div *ngIf="error" class="ant-form-item-explain ng-tns-c177-12 ng-star-inserted">
      <div style="color: #ff4d4f">
        {{ error }}
      </div>
    </div>
  </nz-form-control>
</nz-form-item>

Good luck!


Remove padding from the top of the hero

Remove padding between hero and top of page

in the navigation component change this to a py-2

pr #81


Can i hide selected app notifications?

Can i hide selected app notifications?

For the moment the current package doesn't have this feature yet


Filesys Minifilter Drivers Not Working On Windows 11 (x64)

I am building the NameChanger and simrep drivers on Windows 11 x64. They build, install and the services start successfully (having made one edit to add NTamd64 to the DefaultInstall/Uninstall of the inf files. I am building them, targeting x64.
Once started, neither of them appear to do anything.
For NameChanger, I've created the C:\A\B directory and C:\X directory as described in the instruction.
For simrep, I've created the C:\a\b and C:\x\y directories.
For either example, when I navigate in File Explorer to the user mapping directory, it just opens as normal. No name changing or reparse pointing occurs. I've been testing these each (simrep and NameChanger) independently, just in case one was working and the other was not...but neither seem to do anything.
Please find evidence of the successful instant and service start below:

What am I doing wrong here?
Thanks.

@jeff-simeon  Have you get this issue fixed? I'm facing the same issue, both NameChanger and SimRep not working on my Windows 10 machine. I've setup kernel debug environments, the registered callbacks(e.g. callback for IRP_MJ_CREATE) are not called at all.

I fixed this issue by removing 'return STATUS_FLT_DO_NOT_ATTACH' from NcInstanceSetup which disable mini-filter driver auto-attachment. For SimRep, we need to do similar change to allow instance auto attach. Otherwise, we need to have a user-mode application that can attach mini-filter instance automatically.


Update get-author-name.html

Changed default to the parameters in Config file for consistency

Thank you @cristian04 . I will test and merge soon.


Client: execution graphs tracing using opentelemetry

Summary
Client: execution graphs tracing using opentelemetry.
This PR introduces tracing of all execution workflows.
In order to enable tracing user need to provide env variable OT_JAEGER_HOST_KEY to ray node.
Programs and separate remote functions are traced.
Details
Screen shot of traced benchmark program.

Resource requirements and (width, depth) of quantum circuits passed are logged into trace info.

Closes https://github.com/Qiskit-Extensions/quantum-serverless/issues/149

Added and tracked in separate issue https://github.com/Qiskit-Extensions/quantum-serverless/issues/160

@IceKhan13 sorry that I couldn't check this on time. I assume that we need to modify the configuration for infrastructure too. Can you create me an issue for that? 🙏


Weapon balance

Shotgun is slightly too weak
SMG is WAYYY too weak

SMG has been buffed relatively significantly

Shotgun is actually too strong, closing because I will just change things as I see fit


Docs improvement

An attempt to fix some of the issues I found with the documentation

inclusion of missing documentation
some small additions (like additional cross-reference links)

Nice, could already be merged or first we do those todo's

ah, Wout already reviewed it.
Do merge for users to immediately benefit, sphinx theme switch and additional todo's can go in future pull requests.


"race condition" for \r\n split on buffer length

Pretty academic, but it seems to me that if you read a \r\n-encoded block which ends with \r (so the next block starts with \n), you will insert an extra empty line.
I suppose special-casing it by checking the last character of the buffer and the first one of the next one is the easiest fix but a little ugly.
Nicer would be to determine the line ending style from the first line ending and then split on only that, in which case there would not be a conflation of \r and \r\n endings. It might be faster, too.

{quote}
If you read a \r\n-encoded block which ends with \r (so the next block starts with \n), you will insert an extra empty line.
{quote}
This is a legitimate bug. It's unlikely, as the only way to encounter it is to have a Windows-style line ending which falls exactly across two 65kb chunks. Other chunk sizes would increase the likelihood though.
{quote}
I suppose special-casing it by checking the last character of the buffer and the first one of the next one is the easiest fix but a little ugly.
{quote}
Not at all, in fact, it's what I'm going to do.
{quote}
Nicer would be to determine the line ending style from the first line ending and then split on only that, in which case there would not be a conflation of \r and \r\n endings. It might be faster, too.
{quote}
That would actually be a more brittle solution as it won't handle files which mix multiple styles (such files do unfortunately exist). It's also subject to the same problem, what happens when the first line ending in the file falls across two chunks?

Cool!


The java8 runtime is not supported

The java8 runtime is fairly similar to the java7 runtime. We can add experimental support with a newer base SDK.

Added via AppScale/appscale#3100


Huge import size.

Webpack adding huge size to the production bundle.
https://prnt.sc/pwcf5i
Any suggestions to reduce this.
my tsconfig.json
{   "compilerOptions": {       "outDir": "./dist/",       "sourceMap": true,       "noImplicitAny": false,       "jsx": "react",       "module": "esnext",       "esModuleInterop":true,       "isolatedModules": true,       "moduleResolution": "node",       "target": "es5",       "lib": [               "es5",         "es6",         "dom",         "dom.iterable",         "es2015.collection",         "es2017"]   },   "include": [       "./src/**/*", "tests/venue/reducer.test.ts", "tests/venue/action.test.ts", "tests/venue/epic.test.ts", "tests/services/api.test.ts"   ],   "awesomeTypescriptLoaderOptions": {       "reportFiles": [           "./src/**/*"       ]   } }

Closing this as I'm not sure a gzipped size of 11kb is really "huge".


what does {param2:I} mean?

{
    "id": "talent_13",
    "name": "Gorou",
    "combat2": {
      "name": "Inuzaka All-Round Defense",
      "info": "Deals AoE Geo DMG and sets up a General's War Banner.\n\n**General's War Banner**\nProvides up to 3 buffs to active characters within the skill's AoE based on the number of Geo characters in the party at the time of casting:\n· 1 Geo character: Adds \"Standing Firm\" - DEF Bonus.\n· 2 Geo characters: Adds \"Impregnable\" - Increased resistance to interruption.\n· 3 Geo characters: Adds \"Crunch\" - Geo DMG Bonus.\n\nGorou can deploy only 1 General's War Banner on the field at any one time. Characters can only benefit from 1 General's War Banner at a time. When a party member leaves the field, the active buff will last for 2s.\n\n**Hold**\nAdjust the location of the skill.",
      "description": "\"Take up this formation and we'll be safe — I guarantee it!\" As a general and a leader of troops, the last thing Gorou wants is to see is those who follow him getting hurt.",
      "attributes": {
        "labels": [
          "Skill DMG|{param1:F1P}",
          "DEF Increase|{param2:I}",
          "Geo DMG Bonus|{param3:P}",
          "Duration|{param4:F1}s",
          "CD|{param5:F1}s"
        ],

"DEF Increase|{param2:I}", what does the I mean?

https://github.com/theBowja/genshin-db/blob/main/src/helper.js#L151
I is for integer

how do i use the "helper" module? do i just import it like import gdbhelper from "genshin-db/src/helper" because it says theres no typing for it?

Oh my bad. I'll add in the typing in the next version. You can make your own typing for now.


next/release

:tada: This PR is included in version 1.3.0 :tada:
The release is available on:

v1.3.0
GitHub release

Your semantic-release bot :package::rocket:


[CLI] Command line to delete files on a repo

At the moment it's not possible to delete remote files from the command line except using the huggingface-cli upload (...) --delete="*" command. But this one requires to upload while deleting.
Other feature request: CLI command to move files inside a repo.
We have everything needed in HfApi, it's just a matter of implementing the CLI.
Requested by @ArthurZucker "feature request for clumsy people" :smile:

Hi @Wauplin :)
Is that something I could take as a first contribution ?
I see we have two related functions in the HfApi, namely delete_file and delete_folder. Should we rather have a single or two commands ? In the former, should we use a similar API to upload --delete="*" and use a glob-type parameter ?

Hi @OlivierKessler01, thanks for proposing your help on this issue :)
Agree with you it makes sense to create a single command. I would maybe call it huggingface-cli commit delete (and after that huggingface-cli commit move).

Hi @Wauplin  thank you for the thorough answer :)
I'll be working on this next week.

Thanks! Let me know if you have any question :hugs:

Hi @Wauplin I don't know how you set-up your notifications, if mentionning the issue in a PR suffices or not, but check this out :) https://github.com/huggingface/huggingface_hub/pull/2280

Thanks for the PR @OlivierKessler01! I'm notified on every new PR/issue so it's fine. I took some time off, hence the delay to review it :) I just reviewed your PR, you can find my comments there.


Add delete_project and delete_projects methods

Implemented functionality to delete individual projects and all projects via the Client module.

Thank you for your contribution!


[Bug]: Not working after switch from vite-plugin-fonts

Demo URL
No response
What happened?
Switched to unplugin-fonts by this guide https://github.com/cssninjaStudio/unplugin-fonts/releases/tag/v1.0.0
No warnings or errors and no links with fonts injected
"vite": "^3.0.5",
-"vite-plugin-fonts": "^0.7.0"
+"unplugin-fonts": "^1.0.0

-import { VitePluginFonts } from 'vite-plugin-fonts'
+import  Unfonts from 'unplugin-fonts/vite';

-VitePluginFonts({
+Unfonts({
    custom: {
        display: 'swap',
        families: {
            Basketcase: {
                src: resolveApp('public/fonts/BasketcaseRomanNumbers*')
            }
        }
    }
}),

Reproduction steps
1. Used guide to switch from `vite-plugin-fonts` to `unplugin-fonts/vite`

Relevant log output
No response
What browsers are you seeing the problem on?
Chrome
What is your operating system?
MacOS

Any updates on this? Just tried to use this over vite-fonts but same issue... I have no fonts injected whatsoever in local dev.

Same here :(

Did you add import 'unfonts.css' in your app?

Yes, I did. Maybe a reproduction would help?

I thought it wouldn't work at the beginning too but then I realized I had the wrong path to the font files. Maybe it could log a warning to the console when no files were matched.


[Package Request]: MIDI Editor

How can we help?
I would like someone else to build the manifest.
Please read and ensure the following

[X] The installer meets the above requirements

Please provide the following information
Download Page Url: http://www.midieditor.org/index.php?category=download
Publisher: Markus Schwenk -> https://github.com/markusschwenk/midieditor/
Package Name: MidiEditor
Description: MidiEditor is a free software providing an interface to edit, record, and play Midi data. The editor is able to open existing Midi files and modify their content. New files can be created and the user can enter his own composition by either recording Midi data from a connected Midi device (e.g., a digital piano or a keyboard) or by manually creating new notes and other Midi events. The recorded data can be easily quantified and edited afterwards using MidiEditor.
Package Version: 3.3.0
Installer URL: https://github.com/markusschwenk/midieditor/releases/download/3.3.0/MidiEditor-3.3.0-Setup.exe

Seems this package does not support silent installation. See #129881
Komac failed to inspect the package, since inspecting it requires around 15GB of RAM.

16:17:20 D:\...\winget-pkgs  [master ≡] 1m 45.178s 0xC0000409 pwsh> komac new --output .
> Package identifier: markusschwenk.midieditor
> Package version: 3.3.0
There is already a closed pull request for markusschwenk.midieditor 3.3.0 that was created on 2023-12-09 at 18:06:35
https://github.com/microsoft/winget-pkgs/pull/129881
> Would you like to proceed? Yes
> 1st Installer URL http://localhost/MidiEditor-3.3.0-Setup.exe
? 2nd Installer URL <canceled>
memory allocation of<PHONE_NUMBER>6 bytes failed


Add name to badge lookup

Resolves #3
This PR adds another tab for name to badge lookups. Currently the lookup only supports exact matches on last name. These changes required a bit of refactoring because we expect multiple results for a last name instead of just one. There's also some inconsistencies in the data WRT middle initial, so I opted to store the data by last name, then by serial. This allows duplicate records to be replaced when their serial overlaps.
Good lookup name for multiple last names: Allen
Commits:

Move salary augmentation out to separate function
Add unit description to badge output
Remove entity fields in context now that JS is gone
Add initial last name lookup
Make name results unique by name and sort when processing
Store names by serial for improved uniqueness

Looks good, love the name look up, feel your pain on the difficulty of making a good user experience for searches like this. At the risk of making this too heavy we might could look at Pandas in the future for working with the CSV dataset, and add other libraries to support fuzzier searching such as fuzzywuzzy or even difflib apparently.

Definitely want to make this search more robust, and we can look into those tools for accomplishing that! Pandas seemed like a bit of overkill when this project first started but as this evolves it will definitely need a second look.

Alright locally tested and confirmed working. There are some comments I would make about UI design but neither of us are UI people so I think we'll have to just make an issue for it and work on making it a little prettier.

That would be fantastic lol, UI has definitely been secondary to getting this working!


New methods from TokenUtil

###GetTokenFromHeader

Use this to get the token from header on your requests

###GetSubjectFromToken

Get the subject claim from token, usually the personal ID who is doing the request

Thanks for that!
LGTM


Speed ups to LU related methods, much closer to previous speeds

inv is now much closer to prior speeds with the addition of being more reliable and solve is also faster. solve(m, v) is still faster than dot(inv(m), v). Though probably not needed, lu can handle tall and wide matrices. det, which is based off of lu is faster as well. trace added in case we need it, used by det.

@gir-bot lgtm


Link to repository missing on pyfilesystem.org

On http://pyfilesystem.org, I could not find a link to this GitHub repository.  (I know, this is not really an issue with the code in this repository, but I wanted to post this issue and have it tracked.)

Good point. Indeed, the main page refers to neither hosting site. Docs section, Introduction page refers to Google Code, and Bugs section leads to Google Code issues page directly.

#235 fixes the references to Google Code, but @willmcgugan needs to update http://pyfilesystem.org/ and http://docs.pyfilesystem.org/

Thanks, Andrew. Just updated put the git repos in readthedocs. It should update shortly.

@willmcgugan http://docs.pyfilesystem.org/en/latest/introduction.html still links to the GoogleCode issues URL?
Also, I just noticed that http://docs.pyfilesystem.org/en/latest/ftpfs.html and http://docs.pyfilesystem.org/en/latest/tempfs.html look okay, but http://docs.pyfilesystem.org/en/latest/sftpfs.html (and http://docs.pyfilesystem.org/en/latest/expose/sftp.html ) is totally blank? Should I submit that as a separate issue? (I dunno anything about docs-generation)

Woohoo, I added the ReadTheDocs webhook to this GitHub project, removed wx from requirements.txt, and now http://docs.pyfilesystem.org/ is up to date again! (The introduction page now links to the github issues list rather than the googlecode issues list)
And the pages I mentioned in my previous comment about being totally blank, now have content :-)
But the links on http://pyfilesystem.org/ itself (which is what this issue was originally opened for) are still out of date...

...although something on ReadTheDocs has now gone a bit strange?! https://github.com/rtfd/readthedocs.org/issues/1971#issuecomment-180154869

Well ReadTheDocs seems to be working again, so http://docs.pyfilesystem.org is now up to date, but http://pyfilesystem.org/ itself could still do with an update... ping @willmcgugan again ;-)

Lurch, you mean google groups link could be complemented or replaced by GitHub issues?
This is stale issue, maybe just close it?

No, I mean that http://pyfilesystem.org/ (which is something that only @willmcgugan controls) still links to https://code.google.com/p/pyfilesystem/issues/list instead of https://github.com/PyFilesystem/pyfilesystem/issues , and links to https://pypi.python.org/pypi/fs/0.5.0 instead of https://pypi.python.org/pypi/fs/0.5.4


demo crashes after folowing the steps listed

[ERROR] model file size invalid! expect: 497759232, actual: 411185152
[DEBUG] TIMER loadModelGPT2: cost: 0 ms
[ERROR] load GPT2 model failed !
I am runing ubuntu no unique config to anything

downloaded file got corrupted...
the fix is just trying again.


->* #:rest to -> ...

Many contracts use ->* with #:rest to contract a function with a rest argument.
However, ->* is difficult to read.
Since Racket 6.5, -> supports ..., which can be used to support the rest argument as well.
Since -> is much easier to read, when applicable, ->* #:rest should be rewritten to -> ....

The arrow-contract-with-rest-to-arrow-contract-with-ellipses rule implements this, though I don't remember when I wrote that one.

You even had #130!

Great minds think alike 🙂


Removed newlines and spaces from json representation

Coverage remained the same at 100.0% when pulling fc98de235b7e1c4ae6142d44bbba4c96db4c9225 on no-spaces-in-json into 3eeb0d68b3fecd15279cfa556388d2ffc9523376 on master.


Some model files might be missing...

06/21/2020 10:13:15 - INFO - transformers.modeling_utils -   loading weights file ./model\pytorch_model.bin
Traceback (most recent call last):
File "D:\WorkSpace\Pythonspace\R-BERT-master\trainer.py", line 200, in load_model
self.model = self.model_class.from_pretrained(self.args.model_dir)
File "D:\Programming\Anaconda3\lib\site-packages\transformers\modeling_utils.py", line 512, in from_pretrained
model = cls(config, *model_args, **model_kwargs)
TypeError: init() missing 1 required positional argument: 'args'
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "D:/WorkSpace/Pythonspace/R-BERT-master/main.py", line 63, in
main(args)
File "D:/WorkSpace/Pythonspace/R-BERT-master/main.py", line 21, in main
trainer.load_model()
File "D:\WorkSpace\Pythonspace\R-BERT-master\trainer.py", line 204, in load_model
raise Exception("Some model files might be missing...")
Exception: Some model files might be missing...

you might want to output the real error?
except Exception as e:
    print("error: ", e)
    raise Exception("Some model files might be missing...")

Thanks a lot!!

@xxl95 I had the same problem,may I ask how you solved it?

@xxl95  @chenhaishun
There were some bugs when I refactored the code.
I've fixed the issue. Please pull the new commit:)

Closing, feel free to reopen:)


How to  visualize multi camera tracks?

Hi Philipp,
Thank you very much for the excellent network.
I have some problems with visualizing multi-camera tracks. I run a file in utilities which named "draw_multi_camera_tracks.py"  after the command “python run_multi_cam_clustering.py   --config configs/clustering_configs/mta_es_abd_non_clean.py”
But there is an error that can't find the file which path is "work_dirs/evaluation/multi_cam_trackwise_evaluation/eval_results.csv"
Below is the error message:
Traceback (most recent call last):
File "draw_multi_camera_tracks.py", line 346, in
trv.run_visualization()
File "draw_multi_camera_tracks.py", line 284, in run_visualization
track_evaluation_results = self.read_track_evaluation_results()
File "draw_multi_camera_tracks.py", line 74, in read_track_evaluation_results
track_evaluation_results = pd.read_csv(self.track_evaluation_results_path)
File "/home/xb/anaconda3/envs/wda/lib/python3.7/site-packages/pandas/io/parsers.py", line 676, in parser_f
return _read(filepath_or_buffer, kwds)
File "/home/xb/anaconda3/envs/wda/lib/python3.7/site-packages/pandas/io/parsers.py", line 448, in _read
parser = TextFileReader(fp_or_buf, **kwds)
File "/home/xb/anaconda3/envs/wda/lib/python3.7/site-packages/pandas/io/parsers.py", line 880, in init
self._make_engine(self.engine)
File "/home/xb/anaconda3/envs/wda/lib/python3.7/site-packages/pandas/io/parsers.py", line 1114, in _make_engine
self._engine = CParserWrapper(self.f, **self.options)
File "/home/xb/anaconda3/envs/wda/lib/python3.7/site-packages/pandas/io/parsers.py", line 1891, in init
self._reader = parsers.TextReader(src, **kwds)
File "pandas/_libs/parsers.pyx", line 374, in pandas._libs.parsers.TextReader.cinit
File "pandas/_libs/parsers.pyx", line 674, in pandas._libs.parsers.TextReader._setup_parser_source
FileNotFoundError: [Errno 2] File /home/xb/wda_tracker/wda_tracker-master/work_dirs/evaluation/multi_cam_trackwise_evaluation/eval_results.csv does not exist: '/home/xb/wda_tracker/wda_tracker-master/work_dirs/evaluation/multi_cam_trackwise_evaluation/eval_results.csv'
Should I run some file to create "eval_results.csv" before running "draw_multi_camera_tracks.py"?
Or did I run the wrong file to visualize multi-camera tracks?
Look forward to your reply, thank you!

Hi SaraXuBing,
I used this script to draw generated multi camera tracks and ground truth multi camera tracks that have the minimal matching error into one image. This means the IDTPs and IDFPs were minimal for each pair in all result tracks and ground truth tracks.
I created this assignment using the following file:
https://github.com/koehlp/wda_tracker/blob/master/evaluation/multicam_trackwise_evaluation.py
Unfortunately this script is still based on single images. Due to the big size of the dataset I converted the images into videos.
So it would be required to adjust this script to be able to draw these tracks into images.
Best regards,
Philipp

Hi Philipp
Thank you very much for your reply.
I will try to run this script, but now I have another trouble that I am studing mtmc tracking, but I can't download Dukemtmc video dataset which size is 160G.
Do you have it? If you have it, can you share it to me? This dataset is very important for me.
I am looking forward to your next letter soon.
Sara
------------------ 原始邮件 ------------------
发件人:                                                                                "koehlp/wda_tracker"<EMAIL_ADDRESS>发送时间: 2020年7月17日(星期五) 凌晨3:13
收件人<EMAIL_ADDRESS>抄送: "徐冰"<1097465337<EMAIL_ADDRESS>主题: Re: [koehlp/wda_tracker] How to  visualize multi camera tracks? (#2)
Hi SaraXuBing,
I used this script to draw generated multi camera tracks and ground truth multi camera tracks that have the minimal matching error into one image. This means the IDTPs and IDFPs were minimal for each pair in all result tracks and ground truth tracks.
I created this assignment using the following file:
https://github.com/koehlp/wda_tracker/blob/master/evaluation/multicam_trackwise_evaluation.py
Unfortunately this script is still based on single images. Due to the big size of the dataset I converted the images into videos.
So it would be required to adjust this script to be able to draw these tracks into images.
Best regards,
Philipp
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

Hey SaraXuBing,
The DukeMTMC dataset has been removed due to privacy issues (https://www.dukechronicle.com/article/2019/06/duke-university-facial-recognition-data-set-study-surveillance-video-students-china-uyghur). This was a reason why we created the MTA dataset. You cannot publish research based on the DukeMTMC I guess.
Best regards,
Philipp

Hi Philipp
First of all, thanks for your reply.
The MAT dataset is an amazing job, and I'll do my research on it. I hope we can keep in touch to communicate with MTMC tracking.
Yours sincerely
Sara
------------------ 原始邮件 ------------------
发件人:                                                                                "koehlp/wda_tracker"<EMAIL_ADDRESS>发送时间: 2020年7月18日(星期六) 凌晨0:11
收件人<EMAIL_ADDRESS>抄送: "徐冰"<1097465337<EMAIL_ADDRESS>主题: Re: [koehlp/wda_tracker] How to  visualize multi camera tracks? (#2)
Hey SaraXuBing,
The DukeMTMC dataset has been removed due to privacy issues (https://www.dukechronicle.com/article/2019/06/duke-university-facial-recognition-data-set-study-surveillance-video-students-china-uyghur). This was a reason why we created the MTA dataset. You cannot publish research based on the DukeMTMC I guess.
Best regards,
Philipp
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

Hi Philipp First of all, thanks for your reply. The MAT dataset is an amazing job, and I'll do my research on it. I hope we can keep in touch to communicate with MTMC tracking.  Yours sincerely Sara
…
------------------ 原始邮件 ------------------ 发件人: "koehlp/wda_tracker"<EMAIL_ADDRESS>发送时间: 2020年7月18日(星期六) 凌晨0:11 收件人<EMAIL_ADDRESS>抄送: "徐冰"<1097465337<EMAIL_ADDRESS>主题: Re: [koehlp/wda_tracker] How to visualize multi camera tracks? (#2) Hey SaraXuBing, The DukeMTMC dataset has been removed due to privacy issues (https://www.dukechronicle.com/article/2019/06/duke-university-facial-recognition-data-set-study-surveillance-video-students-china-uyghur). This was a reason why we created the MTA dataset. You cannot publish research based on the DukeMTMC I guess. Best regards, Philipp — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or unsubscribe.

hi Sara,
How is your research going?
I am also doing research in MTMC, can we make some communications and exchange status?
BRs,
Charles


My VM is in Unsupported , so I am not able to move forward

Module: 04
Lab/Demo: 14
Task: 03
Step: 03
Description of issue

Repro steps:

Hi Abhimanmohan,
I hope you have ensured that nothing of the case given under unsupported tab i.e. "classic, no associated NSG, or JIT policy is turned off on their scope" is the case.

After 3 hr it came to Not configured from unsupportable , is it normal ?

yes, sometimes it happens. You may apply JIT from the VM blade too


Enable 2 conformance timeout tests

I noticed that we have 2 seemingly simple conformance tests disabled. I wanted to take a stab at fixing them, but try as I may, I can't trigger any hangs, so they might already have been fixed by some of our recent changes; let's see how they fare with the CI.

A kad timeout and some npm 404s :roll_eyes:; will rerun once all builds complete.

bors retry

What has changed for these tests to no longer hang?

Good question - no clue, but I can't reproduce the hangs at all :thinking:.

I think last time they happened on windows and I guess you are not testing on windows, which prompted the addition of why-is-node-running and later the creation of https://github.com/ipfs/js-ipfsd-ctl/issues/525 and the following up PR (which we have patched at the moment). Note regarding the timeout tests, and why I don't think they are too important at the moment: https://github.com/ipfs/js-ipfs/issues/3161.
Lets do a few windows runs.

I think last time they happened on windows

Yeah, I'm on Linux so I wouldn't have this issue; if it still happens, I'll add this info to the comment, as I don't think this was specified (otherwise I wouldn't have attempted this at all :stuck_out_tongue:).

Aaah, this still doesn't have that kad fix :laughing:; I'll rebase.

Re-running.

Re-running again.

Closing this as we're not convinced that passing these tests properly displays progress.


Added definition for Handlebars.Utils.escapeExpression()

It fixes https://github.com/borisyankov/DefinitelyTyped/issues/592

@vvakame sorry for the delay, fixed.

@rogatty thanks mate!


missing 'StrongType' experience in GUI

it would be great to use 'strongType'  functionality for our portal users.
That's what I have in my tempalte parameters file
  "parameters": {
        "resourceTypes": {
            "type": "String",
            "metadata": {
                "strongType": "Microsoft.Network/virtualNetworks/subnets"
            }
        },
        "location": {
            "type": "string",
            "metadata": {
                "strongType": "location"
            }
        },
        "vmSKUs": {
            "type": "string",
            "metadata": {
                "strongType": "vmSKUs"
            }
        },
        "existingResourceGroups": {
            "type": "string",
            "metadata": {
                "strongType": "existingResourceGroups"
            }
        },
        "thatWorks": {
            "type": "String",
            "defaultValue": "123",
            "allowedValues": [
                "abc",
                "def",
                "123"
            ],
            "metadata": {
                "strongType": "thatWorks"
            }
        }
    },

and that's how it looks like in a portal.

We are going to be supporting createUiDefinition to support this scenario going forward. This should give you a lot more capability than what is currently possible with policy's strongType.

great! can we expect to get this functionality before summer?

Yes it should be done by then - cc @apclouds and @TarunSunkaraneni as FYI