KeyboardAccelerators stops working for command when displayed in MenuFlyout in disabled state

Describe the bug
KeyboardAccelerators stops working for ICommand when the command is attached to the menu item in the MenuFlyout and the MenuFlyout is displayed with the command in disabled state and then closed.
Steps to reproduce the bug
To reproduce, create a new WinUI application in Visual Studio. Add reference to CommunityToolkit.Mvvm version 8.2.2 and add/modify the follosing files:
Models/MainViewModel.cs
using System;
using CommunityToolkit.Mvvm.ComponentModel;
using CommunityToolkit.Mvvm.Input;

namespace WinApp.Models
{
    internal partial class MainViewModel : ObservableObject
    {
        [ObservableProperty]
        [NotifyCanExecuteChangedFor(nameof(SaveCommand))]
        private bool canSave = true;

        [ObservableProperty]
        private string statusText = "(none)";

        [RelayCommand(CanExecute = nameof(CanSave))]
        private void Save()
        {
            StatusText = $"{DateTime.Now:HH:mm:ss.fff}: saved";
        }
    }
}

MainWindow.xaml
<?xml version="1.0" encoding="utf-8"?>
<Window
    x:Class="WinApp.MainWindow"
    xmlns="http://schemas.microsoft.com/winfx/2006/xaml/presentation"
    xmlns:x="http://schemas.microsoft.com/winfx/2006/xaml"
    xmlns:local="using:WinApp"
    xmlns:d="http://schemas.microsoft.com/expression/blend/2008"
    xmlns:mc="http://schemas.openxmlformats.org/markup-compatibility/2006"
    mc:Ignorable="d">

    <Grid>
        <Grid.RowDefinitions>
            <RowDefinition Height="Auto"/>
            <RowDefinition Height="Auto"/>
            <RowDefinition Height="Auto"/>
        </Grid.RowDefinitions>

        <MenuBar>
            <MenuBarItem Title="File" AccessKey="F">
                <MenuFlyoutItem Text="Save" Icon="Save" AccessKey="S" Command="{x:Bind model.SaveCommand}">
                    <MenuFlyoutItem.KeyboardAccelerators>
                        <KeyboardAccelerator Key="S" Modifiers="Control"/>
                    </MenuFlyoutItem.KeyboardAccelerators>
                </MenuFlyoutItem>
            </MenuBarItem>
        </MenuBar>

        <ToggleSwitch Grid.Row="1" Margin="12,0" Header="Can Save" IsOn="{x:Bind model.CanSave, Mode=TwoWay}"/>

        <TextBox Grid.Row="2" Margin="12,0" Header="Status Text" Text="{x:Bind model.StatusText, Mode=OneWay}"/>
    </Grid>
</Window>

Launch the application. Press Ctrl+S several times to notice that the status text changes. Try toggling switch on and off and then pressing Ctrl+S to notice that the command is correctly enabled and disabled. After that, do the following:

Toggle the "Can Save" switch off
Open the "File" menu (teh "Save" item should be disabled)
Close the "File" menu
Toggle the "Can Save" switch on
Press Ctrl+S

Expected behavior
The command should be invoked and the status text should change. Bit the command is not invoked until the "File" menu is opened when the command is enabled.
Screenshots
No response
NuGet package version
WinUI 3 - Windows App SDK 1.4.5: 1.4.240411001
Windows version
Windows Insider Build (22635.3209)
Additional context
No response

The workaround from https://github.com/microsoft/microsoft-ui-xaml/issues/5437 does the trick. It seems that WinUI 3 requires workarounds everywhere.


remove extra digit for amex cards

@AO16 Thanks for taking this on! It looks like you need to update the AMEX test as well, super small change. I'll merge it as soon as you get that in!

@AO16 Would love to merge this PR but gotta get those tests passing, think you'll have the time to fix those soon?

@pzuraq Yep, I'll do it right now. Sorry, this got completely lost on my end.

@pzuraq Encountered another test that was failing https://github.com/pzuraq/ember-inputmask/issues/19

Closing for now until the other issue is resolved

@AO16 Yeah I've been taking a look, it's because the Amex credit card mask binding doesn't change until the blur event is triggered on the input, which means that you can't enter the extra digit. We can hack around this for now by putting American Express at the end, but this is why I ultimately wanted to rebuild inputmasks in native Ember. I can fix the test and resubmit the PR.


Suggestion: CDN for a raw JS lib import

What about convert the node JS files into one single JS file to be easily imported directly in the HTML?

This is effectively blocked by #87, as we need to have it work without Node dependencies first. Marking as such.
Duplicate of #87


ValueError when reading dict with None

I find that reading a dict
row =  {'a': [1], 'b':[None]}
ks.DataFrame(row)

ValueError: can not infer schema from empty or null dataset

but for pandas there is no error
row =  {'a': [1], 'b':[None]}
print(pd.DataFrame(row))

   a     b
0  1  None

I have tried setting dtype=np.int64 but this has not helped.

Thanks for reporting issue for Koalas!
i'm going to try to fix this.

@ueshin @HyukjinKwon Could you let me know about maybe is there a special reason that we are disallowing to creation DataFrame with null dataset??

It's because PySpark, by default, tries to infer the type from the given data. If there's no data or only nulls in the column, PySpark cannot infer its data type for a DataFrame.
>>> import pandas as pd
>>> row =  {'a': [1], 'b':[None]}
>>> pd.DataFrame(row).dtypes
a     int64
b    object

pandas has object type that can contain everything; whereas PySpark does not have such type. So, it's actually an issue in PySpark.

Maybe we should have a way to explicitly set the schema and avoid type inference in Koalas so that we can allow both null and empty DataFrame cases.

So pandas has the "dtype" keyword, e.g.
row =  {'a': [1], 'b':[None]}
df= pd.DataFrame(row, dtype=np.int64)

It allows for only a single type to be passed, which is then enforced for all columns.
Could you allow the full schema to be passed as a keyword, much like for Spark DF's? Something like
row =  {'a': [1], 'b':[None]}
df= pd.DataFrame(row, dtypes=[np.int64, np.float64])

If the dtypes cannot be parsed such as here:
row =  {'a': [1], 'b':["I am a string"]}
df= pd.DataFrame(row, dtypes=[np.int64, np.float64])

then it would error.

Yeah, I think the last case should would.

This also occurs when initialising an empty dataframe through ks.DataFrame([]).

Thanks for sharing that, @jorijnsmit.

So what is the plan for this issue? What should we do we empty columns so that it doesn't through such an error?

So one way I've been able to get around this issue, @ntrang086, is initializing the empty dataframe in Spark (with an explicit schema) and then translating to koalas.
`
from pyspark.sql.types import StructType, StructField, StringType, DoubleType, TimestampType, NumericType, ArrayType
schema = StructType([
StructField("a", StringType()),
StructField("b", TimestampType()),
StructField("c", DoubleType()),
]
)
kdf = spark.createDataFrame([] ,schema = schema).to_koalas()
`

@mwb222 Thanks for sharing the workaround. My use case is that: starting with a non-empty pandas dataframe, convert it to koalas and then try to use koalas functionalities. I've encountered this type of error when doing this. The issue is that when using koalas groupby on a dataframe converted from pandas, sometimes I end up with empty dataframes that are a result from the groupby call in koalas. Therefore I get this error.
Is there a workaround for this use case?
Will I have to convert pandas to pyspark with a specified schema and then convert to koalas?

Ah I see - I haven't run into that situation in my own work so don't know if the workaround above will help, but it might be worth a try to see if the explicit schema carries through in the background. Sorry!

@ntrang086 How about using type hints for the function you are trying to apply, assuming you are trying to use apply or something which take a user function?

@ntrang086 How about using type hints for the function you are trying to apply, assuming you are trying to use apply or something which take a user function?

The function doesn't return a single value of a specific type like str, float or int, but returns a pandas dataframe or pandas series which can be empty and this has caused the issue described above. Koalas already knows the return type is a pandas dataframe or series and has a problem "accepting" it :) . I could try it what you suggested and see how it goes but not sure it'd work.

JFYI...
using read_csv function with a column without values I don't receive any errors, but with an read_excel() the same error is raised.

Now it works properly on pandas-on-Spark (It's available in Apache Spark 3.2 and above)
I'd recommend to use pandas-on-Spark rather than Koalas since Koalas now only maintenance mode.
>>> import pyspark.pandas as ps
>>> ps.DataFrame()
Empty DataFrame
Columns: []
Index: []
>>> ps.DataFrame([{"A": [None]}])
        A
0  [None]


'OxfordPets' object has no attribute 'ndim' Error

Hi everyone,
When I try to run keras-io/examples/vision/oxford_pets_image_segmentation.py. I get 'OxfordPets' object has no attribute 'ndim' Error.
Could you help me about this?

Note: We should add a pip install command for KerasCV, so that the tutorial doesn't throw an error on the first cell.

The notebook throws an error when you try to create the training and validation sets. Needs further investigation.
Error details:
        Tensor("sequential/rand_augment/cond/random_choice/switch_case/indexed_case/Identity_1:0", shape=(160, 160, 1), dtype=float32) and Tensor("sequential/rand_augment/cond/random_choice/switch_case/indexed_case/Identity_1:0", shape=(160, 160, 1), dtype=int64) have different types

    Call arguments received by layer 'random_choice' (type RandomChoice):
      • inputs={'images': 'tf.Tensor(shape=(160, 160, 3), dtype=float32)', 'segmentation_masks': 'tf.Tensor(shape=(160, 160, 1), dtype=int64)'}

Call arguments received by layer 'rand_augment' (type RandAugment):
  • inputs={'images': 'tf.Tensor(shape=(160, 160, 3), dtype=float32)', 'segmentation_masks': 'tf.Tensor(shape=(160, 160, 1), dtype=int64)'}

Hi,
The example has been updated to Keras 3 with many changes and now it is running successfully, please find the Gist here for more details https://keras.io/examples/vision/oxford_pets_image_segmentation/


[Question] Container name limitation

PLEASE DO NOT INCLUDE ANY PASSWORDS OR TOKENS IN YOUR ISSUE!!!
Describe the issue
I would like to ask about the length limit of the container name.
When creating a container with a name longer than 15 characters, a warning first appears: "WARNING: Container name should not exceed 15 characters".
The created container then crashes with the error "Initialization of container NAMELONGERTHAN15CHARS failed", because when adding to the hosts file, the length is truncated to 15 characters: "Adding NAMELONGERTHAN1 to hosts file".
Is it not possible to allow longer container names? Is there a system limitation?
Thank you for your reply.

I had a lot of issues when using longer than 15 character names back in the days when we started, which is why the 15 character limit is in BcContainerHelper. Some Windows Versions might work - some won't - I don't have the details.
I am afraid that it will add a lot of issues and a ton of hours spend on troubleshooting if I lift the restriction, sorry.

OK, thank you for your response.


Make kubernetes cloudprovider independent

More details here: https://github.com/kubernetes/features/issues/88
and here: https://github.com/kubernetes/community/pull/128

With the release of Rancher 2.0, development on v1.6 is only limited to critical bug fixes and security patches.


Improve if else by not creating unnecessary functions

Related issue: fix the bug where doing "if... else if" without "else" will result in skipped numbers

Fixed and improved in https://github.com/WingedSeal/jmc/commit/416f86a84556e0df57835640088c0d4df7b456b3


autodoc: don't work links to modules in table of contents and links to custom types

Hello.
I tried generate documentation for my package by autodoc. HTML version generated successfully without warnings, but in confluence version don't works links to modules in table of contents on starting page and links to custom types, e.g. custom exceptions in desribe of method.
While execution of make.bat confluence, I got warnings like those:
WARNING: unable to build link to document due to missing title (in index): genindex
WARNING: unable to build link to document due to missing title (in index): py-modindex
WARNING: unable to build link to document due to missing title (in index): search
WARNING: unable to build link to document due to missing title (in mypackage.mymodule): mypackage.mymodule.conf#mypackage.mymodule.exceptions
My enviroment is Windows 10 Pro, Python 3.6.4, Sphinx 1.7.8 and sphinxcontrib-confluencebuilder (main branch, current version, last commit is 330e31af).

I have the same issue, not sure about genindex/search but the problem with the other links seems to be that translator._visit_reference_intern_uri not strip the anchor portion before calling ConfluenceState.title.
I'll try and fix this and put in a PR.

I suspect genindex/py-modindex/search are the default generated pages from sphinx-quickstart -- which these documents are not generated with a title, thus will never be published. I assume though that this is not the issue you are concerned about.
It is most likely the issue that @verdesmarald has mentioned (and submitted a pull request for). Hopefully this change will resolve your issue.
While this extension's master branch now lists autodoc as supported, clearly there is still limitations in the initial support. I will hopefully be able to add more additional examples to test against in the future. Also, if anyone knows of some open source projects with a great sample set of documentation, I would not mind doing some tests against these source sets to help correct other issues that may exist.

Version 1.0 of this extension has been released which addresses the anchor issues observed with autodoc content. While other autodoc changes can be made, they are currently being tracked in other active issues. Closing this issue.


⚠ Empornium has degraded performance

In a848f9c, Empornium ($EMP) experienced degraded performance:

HTTP code: 200
Response time: 1261 ms

Resolved: Empornium performance has improved in 819ab83.


Link for PSResourceGet on PowerShell Gallery directs to PowerShellGet project

Prerequisites

[X] Write a descriptive title.
[X] Make sure you are able to repro it on the latest released version
[X] Search the existing issues.

Steps to reproduce
From PowerShellGallery for this module the "Project Site" link does not correctly link to this repo.
Expected behavior
"Project Site" redirects to https://github.com/PowerShell/PSResourceGet

Actual behavior
"Project Site" redirects to https://github.com/PowerShell/PowerShellGet

Error details
n/a

Environment data
n/a

Visuals
No response

Believe the root of the issue is this link in the resource that needs to be updated.
https://github.com/PowerShell/PSResourceGet/blob/abfbf4222ef9a4c170b42e9c77df801040c69937/src/Microsoft.PowerShell.PSResourceGet.psd1#L55

Believe the root of the issue is this link in the resource that needs to be updated.
https://github.com/PowerShell/PSResourceGet/blob/abfbf4222ef9a4c170b42e9c77df801040c69937/src/Microsoft.PowerShell.PSResourceGet.psd1#L55

Noted this and LicenseURI are still pointing to PowerShellGet, have added a PR for both

Thanks @kilasui for the PR, but I was thinking that the team may need to generate a new go link for this in case the destination changes in the future.

Should get updated today, thanks everyone

Links are updated now!  Thanks for opening the issue @joshcorr!


Create 0000-01-02-chenell32.md

Layout: slide
title: “Welcome to our second slide!”

ayout: slide
title: “Welcome to our second slide!”


[ES] Translations

Translated by Alconost

Lint errors are license/copyright (inherited from English counterparts)


add support for legacy modules and dynamic config

Relies on https://github.com/tkellen/node-interpret/pull/15
This is my POC for how the config objects would work.  It definitely needs to be cleaned up but all tests are passing and they even pass with coffee-script < 1.7 (will need to add tests for that).

I like that better than my implementation.  I wasn't liking how the cleanliness of the extensions list was lost.  I will try to update this soon.

pinging due to new changes. let me know your thoughts @silkentrance @tkellen

Can you update this to depend on<EMAIL_ADDRESS> Also, any thoughts on #7?

Whoops, I mean #10

I've struggled with the same problem that is described in the past with no good resolution.  Passing module down is quite scary in my opinion.  Is load necessary to keep as part of this API?  I prefer the registerFor and actually using require since it is more explicit.

Updated, tests passing on travis and even added different coffee-script versions to the travis matrix

:+1: to squash and merge after that minor nit

Cleaned up and squashed, waiting for travis to run

Travis passed, merging


Can reconnect be configurable?

I see that reconnect is hardcoded to 8
Can it be configurable, for example, into forever?

Sorry for the late response! This flew by my inbox for some reason.
I made a PR for this change: I'll merge it in and put up a new version if everything looks fine. Let me know :).


error: avro-python3 1.10.0 is installed but avro-python3!=1.9.2,<1.10.0,>=1.8.1 is required by {'apache-beam'}

Hi my name is Arif,
Currently I am trying to follow your project and train it with my own dataset..
at step 9, when I'm trying to install the setup.py there is an error like this when it trying to install avro-python3
error: avro-python3 1.10.0 is installed but avro-python3!=1.9.2,<1.10.0,>=1.8.1 is required by {'apache-beam'}
do you know how to handle this error?
Thank you, I am waiting for your response

I am not sure, but I read a bit of documentation, it says
"A package called "avro-python3" had been provided to support Python 3 previously, but the codebase was consolidated into the "avro" package and that supports both Python 2 and 3 now. The avro-python3 package will be removed in the near future, so users should use the "avro" package instead. They are mostly API compatible, but there's a few minor difference (e.g., function name capitalization, such as avro.schema.Parse vs avro.schema.parse)."
Link: https://avro.apache.org/docs/1.10.0/gettingstartedpython.html
Maybe try installing the latest version of this new package !

I am not sure, but I read a bit of documentation, it says
"A package called "avro-python3" had been provided to support Python 3 previously, but the codebase was consolidated into the "avro" package and that supports both Python 2 and 3 now. The avro-python3 package will be removed in the near future, so users should use the "avro" package instead. They are mostly API compatible, but there's a few minor difference (e.g., function name capitalization, such as avro.schema.Parse vs avro.schema.parse)."
Link: https://avro.apache.org/docs/1.10.0/gettingstartedpython.html
Maybe try installing the latest version of this new package !

Hi Arif, installing these dependencies before running setup.py worked for me:
# install apache-beam dependencies
!pip install avro-python3==<IP_ADDRESS>
!pip install dill==<IP_ADDRESS>
!pip install future==0.18.2
!pip install pyarrow==2.0.0
!pip install requests==2.25.1
!pip install pyyaml==5.3.1```

Hi ericchen321, I tried the code you suggested. and I still get the following error
python3: can't open file 'setup.py': [Errno 2] No such file or directory python3: can't open file 'setup.py': [Errno 2] No such file or directory


giphy integration

I don't use refined-github yet, but I think that if there were giphy integration it might finally push me over the edge.
I'm thinking that putting something by textareas that I can click on and search for a giphy gif that I could insert into my comment, that'd be terrific. Something like what twitter has:

I really liked this idea, and wanted it for personal use, so I ended up throwing it together.
I did not, however, add it to this project. The only reason for not contributing directly was that there are a few features of this project I don't need personally, and I understand (and am plenty fine with) the decision to not allow toggling features in Refined Github. I do appreciate all of @sindresorhus's hard work on it, though :).

@DrewML Nice! I think this indeed is better as a separate extension. Happy to link to it from the readme.


The Environment Variable Keep Replacing

What happened?
I just created the AWS CloudFront public key and added it to the environment as a secret variable by running this command:
cat ./public_key.pem | pulumi config set public_key --secret
I was able to deploy the public key to CloudFront successfully. However, every time I run pulumi preview or pulumi up, the public key is being replaced.

Example
pulumi.develop.yaml file
config:
  ...
  ...
  public-key:
    secure: AAABAJOP0wyBsseRieHS9v69QAG5d3FgKlesm98Q6SAjSavuP/dzEH6EMIrouDnS/yxJz+dzLH4FcqMy7sb2ymekYYX/6p3J21/4yrOHCdBraJcfM4GKwc1ITElpauvMfKvI51r+NAlax3E4M8Qp8qnVCCLcgmfdWjyMXWAo+T2J+zmZ8htKvLoyHfOKY6/ahKIke/Kvlu9F60yFcNFvc1aWWX/s+7UAq2CH1dVYnmeDKmwRwVUTqHL+v420gT5Nz6iT55LrlhfM7pQOgcyR0ctq9AQ5UO7n7CJodBITSUNLtgAJqwSb6vCJMK4jIbVmf4nOxz9Jll7iiJD+WmnT6QFEePkMofFgJWAXN0NLksKXKm8ziY9Mpry9Dss4HQqLgPK85RzxLNM35D4x2xxzvuHFASc+V+qwq8+ZyJSgltlbtTTn1wnfTKAN+TUS8quK1jTPmqoY4kLMCg7ai08B5lWCwSF7z5gPquY3aAXW0ZEvdA9nrRCJMuWlCA5ZGO8KZafLI43F9+6TOB9jvojMQlqr+7bPmmNrinrkJXvTKfFCsLmRxMnFimX7FtpSB1UFoFmo1SV6LsciSEYRTl/vnfQLd2WtE7ijw1Fac0q5yBEm7o7tJDXtsvQRVwWrS6zkieM=
  ....
  .....

Output of pulumi about
pulumi version : v3.140.0
Language: Golang
Platform: AWS
Additional context
No response
Contributing
Vote on this issue by adding a 👍 reaction.
To contribute a fix for this issue, leave a comment (and link to your pull request, if you've opened one already).

I have filed an upstream issue as the Pulumi provider is inheriting this behavior from the Terraform provider. This could be best fixed upstream by using DiffSuppressFunc or similar functionality: https://github.com/hashicorp/terraform-provider-aws/issues/40295

@t0yv0
I've added the \n at the end and it worked.


AVCaptureSession startRunning error

Has anyone had this error before:
[AVCaptureSession startRunning] startRunning may not be called between calls to beginConfiguration and commitConfiguration
This error typically appears when the app doesn't ask for camera permission but in my app, the user has already given camera access. This error comes up time to time and I haven't been able to figure out why it's happening.
Environment

Node.js version: 7.5.0
React Native version: 0.39.0
React Native platform + platform version: iOS 10.2.1

react-native-camera
Version: 0.4.1

I just got this crash as well! Did you figure anything out @kevinnguy?
react-native 0.42.0
react-native-camera 0.6.0

It looks like this line is the culprit: https://github.com/lwansbrough/react-native-camera/blob/master/ios/RCTCameraManager.m#L457
startRunning is being called from an async block which isn't safe in this context. I'm wondering why we are trying to manually restart the session here in case of an error? Maybe this block should just be replaced with an error message?
    [self setRuntimeErrorHandlingObserver:[NSNotificationCenter.defaultCenter addObserverForName:AVCaptureSessionRuntimeErrorNotification object:self.session queue:nil usingBlock:^(NSNotification *note) {
      RCTCameraManager *strongSelf = weakSelf;
      dispatch_async(strongSelf.sessionQueue, ^{
        // Manually restarting the session since it must have been stopped due to an error.
        [strongSelf.session startRunning];
      });
    }]];

I tried to fix this with a this commit in my fork. However, I'm still occasionally getting the crash, but maybe a little less often.
I really need this fixed! Can anyone offer any suggestions? I'm new to iOS & Obj-C and don't know what else to do.
/cc @lwansbrough @ptomasroos @NazarYablonskiy

So I think the crash wasn't happing where I thought it was at L457 like I said above. My crash logs using my attempted fix show the crash is still happening in startSession.
So I made this commit in another attempt to fix the crash. I'll see how it goes.

@flybayer can you confirm if that commit fixes it 🙏  ? I'm hitting this as well (RCTCameraManager.m:453:5 __32-[RCTCameraManager startSession]_block_invoke)

@Eyesonly88 I haven't pushed out the update with that commit yet, so I can't yet confirm. But I'm hoping to submit it for review this weekend.

@flybayer Thank you SO MUCH 👍 🙇

@Eyesonly88 I'm still getting the crash 😞
I'm seriously considering making a brand new react-native camera library with swift. Maybe build on a battle tested library build for stock iOS.

@flybayer A friend of mine wrote a camera app called NovaCamera for both iOS and android, it's excellent I have to admit - worth checking out.  Not as fully featured maybe (no bar code scanning, no video) but lots of stuff around exposure, focus and iso control.  But maybe we could learn from some of the stuff he did:
https://github.com/novaphotos/nova-ios-app/blob/develop/NovaCamera/Services/SSCaptureSessionManager.m#L280
https://github.com/novaphotos/nova-android-opencamera/blob/master/src/com/almalence/opencam/cameracontroller/CameraController.java#L3282

I am seeing this error every now and then. @flybayer did you ever manage to get rid of the crash?

No I haven't been able to fix it 😓

I got around this issue by subclassing the component and overriding the render method: basically replacing the camera element itself by a plain React Native  element when the camera permissions haven't been granted.
You can see the code here: https://gist.github.com/pvanliefland/8c2522a27daf4759b015e3345ba47dda
If the library author is interested, I can work on a pull request

@pvanliefland I think that's a different issue. The issue we are having occurs when all permissions have been enabled.

anything new on that?

This bug is showing up occasionally for some of my users. Any updates on getting a PR created for this? @pvanliefland @lwansbrough

Also seeing this with permissions granted.

Just ran into this. Anyone had any luck finding a workaround?

@Cygnus2112 no :( Someone needs to build react-native-non-crashing-camera

Aargh. Okay, thanks for trying, @flybayer

2017-10-04 17:18:36.848474+0530 mobile[2587:224048] XPC connection interrupted
2017-10-04 17:18:36.856211+0530 mobile[2587:222045] *** Terminating app due to uncaught exception 'NSGenericException', reason: '*** -[AVCaptureSession startRunning] startRunning may not be called between calls to beginConfiguration and commitConfiguration'
*** First throw call stack:
(0x1828a7d38 0x181dbc528 0x18817780c 0x1005ab270 0x100e9d49c 0x100e9d45c 0x100eac110 0x100ea09a4 0x100ead104 0x100eb4100 0x1824d2fe0 0x1824d2c30)
libc++abi.dylib: terminating with uncaught exception of type NSException
(lldb)

when i capture image i am getting this error.

any solutions?

Well, crash is quite self describing, doesn't it ? Sorry, I don't have time to do PR, leave it somebody who has. Serialising setCaptureQuality to sessionQueue fix this.
- (void)setCaptureQuality:(NSString *)quality
{
    #if !(TARGET_IPHONE_SIMULATOR)
        if (quality) {
            dispatch_async([self sessionQueue], ^{
                //DLog(@"setCaptureQuality: begin");
                [self.session beginConfiguration];
                if ([self.session canSetSessionPreset:quality]) {
                    self.session.sessionPreset = quality;
                }
                [self.session commitConfiguration];
                //DLog(@"setCaptureQuality: end");
            });
        }
    #endif
}

hey @om2pkral I can create a PR to fix this based on your suggestion.  I don't have much experience with Native iOS development. Can you please explain why the changes you suggest will fix the problem?

I've created a PR that fixes the problem using @om2pkral 's suggestion https://github.com/lwansbrough/react-native-camera/pull/980

Hello,
it is basicaly due accesing camera session from multiple threads,
wrapping it to sessionQueue serializes access and remove race condition.
Cheers,
PK
On 13.11.2017 23:44, manask88 wrote:

hey @om2pkral https://github.com/om2pkral I can create a PR to fix
this based on your suggestion. I don't have much experience with
Native iOS development. Can you please explain why the changes you
suggest will fix the problem?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/lwansbrough/react-native-camera/issues/604#issuecomment-344084528,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AHKzTkAOPwGVSh7Fu-mJxKJNysSmAkDgks5s2MZWgaJpZM4MD1vA.

when @manask88 PR is going to merge. it's really important for us.

I'm don't have write access to this repo @AshokICreate . You could help to get the attention of the maintainers in my PR https://github.com/lwansbrough/react-native-camera/pull/980
@om2pkral thanks for the explanation!

@lwansbrough, @kesha-antonov, @rt2zz, @ptomasroos, @corbt, @jtremback, @manask88  @om2pkral

This issue is closed because of inactivity.
Furthermore RCTCamera is deprecated now, use RNCamera instead. If this issue is also related to RNCamera, please open a new one.


Yellow release sample data

Sample data for yellow release
Updated sample data for yellow release

Category: Data
JIRA issue: MIC-4484

-Updates sample data for yellow release
-Fixes PO Box address empty strings and changes them to np.nan
-Changes state to WA instead of US
Testing
Expected data updates and all tests pass.

@albrja Heads up you are going to want to re-run tests after merging develop into this branch!

Yes I would do that again once I have approvals and have rebased


Future for Timer Update Interrupt

Hi,
I'm trying to get a DDS to work but currently there seems not to be a way to have a future waiting for the timer update interrupt or timer compare interrupt
Unfortunately this is needed because DDS is completly different to waveforms that are played back from RAM via DMA.
It requires to calculate the next PWM value based on a fixed point phase accumulator pointing to a sine table but this requires to update the PWM value after each timer update interrupt - better would be timer compare interrupt.
I saw in the low_level.rs that there is some function that can return if a timer interrupt happened but it would be a "bruteforce"-polling method that wastes a lot of CPU power. Better would be a Future that awaits in some task.
I can contribute some DDS code example if someone could point me in the right direction.
Thank you very much,
Thomas

Mmhmm maybe I can C&P parts from the Input Interrupt :thinking:

I think this should work with minimum overhead:
#[interrupt]
fn TIM2() {
    unsafe {
        // get next value of DDS
        DDS_AKKU = DDS_AKKU.wrapping_add(DDS_INCR);
        let value = DDS_SINE_DATA[(DDS_AKKU >> 24) as usize];
        pac::TIM2.ccr(3).modify(|w| w.set_ccr(value as u16));
    }
}

I don't know what do you mean by DDS but this PR might interest you for the futures: https://github.com/embassy-rs/embassy/pull/3029#issuecomment-2144021658

I don't know what do you mean by DDS

DDS means "direct digital synthesis" - it's like the opposite of digitizing an analog audio into digital samles.
DDS creates digital samples of a sine wave that is then converted to analog external.
The trick on DDS is that you can generate arbitrary sine frequencies - like you can digitize arbitrary sine wave frequencies (ofc with respect to Nyquist) of an analogue signal.
It's a little bit of an edge case, not so much used often, but it's needed for digital signal processing often.
Oh nice to see that I'm not the only one who would need Futures for Timers :raised_hands:


Format Expiration date in marketplace app info view

In marketplace package, the expiration date in details view need formatting

Commit_ID 092358e26dfb12dbe8395fd7da00a93cb90a8ec5 , Branch development


Decorator Based Gadgets

RFC #12 introduced the concept of "gadgets" to shoulder with the intention of providing a way to break down complex Generator objects into smaller, more reusable bits and pieces. This gadget concept followed the same design pattern behind generators: An AbstractGadget class defined an interface that specific concrete gadgets would implement to provide their own functionality. This choice to use an abstract base class to define the gadget interface seems to be imposing some limitations:

There isn't easy way to parametrize each gadget differently (which seems to be necessary)
It is difficult to write a gadget that "wraps" content (like an include guard, or C++ namespace)
It is a little awkward to call the gadgets from within a generator (the whole point of the gadget in the first place)

To overcome the above limitations, this RFC proposes to move the gadget concept into an implementation that utilizes python decorators, instead of an abstract base class. This way, a shoulder generator could use a gadget by "decorating" its private, internal functions. Each decorator would optionally provide parameters for tweaking generated content. For example:
import os
import shoulder

class MyGenerator(shoulder.generator.abstract_generator.AbstractGenerator):
    def generate(self, objects, outpath):
        outfile_path = os.path.abspath(os.path.join(outpath, "my_generated_output.h"))

        with open(outfile_path, "w") as outfile:
            self._generate(objects, outfile)

    @shoulder.gadget.license
    @shoulder.gadget.include_guard(name="MY_CUSTOM_INCLUDE_GUARD_H")
    def _generate(self, objects, outfile):
        outfile.write("This decorated content will contain a license and be wrapped in include guards")

The example above applies two decorator-based gadgets named shoulder.gadget.license, and shoulder.gadget.include_guard. The implementation of the include_guard gadget would be the following:
def include_guard(_decorated=None, *, name="SHOULDER_AARCH64_H"):
    def _include_guard(decorated):
        def include_guard_decorator(generator, objects, outfile):
            outfile.write("#ifndef " + str(name) + "\n")
            outfile.write("#define " + str(name) + "\n\n")
            decorated(generator, objects, outfile)
            outfile.write("#endif\n")
        return include_guard_decorator

    if _decorated is None:
        return _include_guard
    else:
        return _include_guard(_decorated)

Ok, I think I understand how the decorators work now, that is a very useful tutorial you linked. Just to clarify, decorated is the function object defined below the @ decorators (_generate() in the example)?
While decorators are a little weird at first, I think it makes a lot of sense to use them, especially with the ability to have elastic function arguments. We may sacrifice a little bit of readability, but the code is still pretty intuitive and the effectiveness far outweighs the small learning curve with decorators.

That is correct, decorated is the function that is "being decorated" (_generate() in the example)
I 100% agree on losing some readability, that would be my main hesitation with trying out this pattern as well. I bet there's a way we could implement some sort of common template that could help hide the complexity of defining a new decorator. Open to suggestions!

I think as long as we are diligent with providing good documentation headers for the gadgets with  usage instructions like you have done in the recent PR we should be ok. The license and include guard gadgets are also simple enough to provide a good starting point for someone who wants to implement their own gadget.


SIGSEGV exception in glbc

I'm using GKE with Kubernetes. Master is 1.6.7, nodes are 1.6.4.
After following instruction from readme here, the ingress is working fine, which is indicated by the following:
Name:                   echomap
Namespace:              default
Address:                35.xxx.xxx.38
Default backend:        echoheadersx:80 (<IP_ADDRESS>:8080)
Rules:
  Host          Path    Backends
  ----          ----    --------
  foo.bar.com
                /foo    echoheadersx:80 (<IP_ADDRESS>:8080)
  bar.baz.com
                /bar    echoheadersy:80 (<IP_ADDRESS>:8080)
                /foo    echoheadersx:80 (<IP_ADDRESS>:8080)
Annotations:
  backends:             {"k8s-be-30284--2043b92cf2a8ad1f":"HEALTHY","k8s-be-30301--2043b92cf2a8ad1f":"HEALTHY"}
  forwarding-rule:      k8s-fw-default-echomap--2043b92cf2a8ad1f
  target-proxy:         k8s-tp-default-echomap--2043b92cf2a8ad1f
  url-map:              k8s-um-default-echomap--2043b92cf2a8ad1f
Events:
  FirstSeen     LastSeen        Count   From                    SubObjectPath   Type            Reason  Message
  ---------     --------        -----   ----                    -------------   --------        ------  -------
  47m           47m             1       loadbalancer-controller                 Normal          ADD     default/echomap
  46m           46m             1       loadbalancer-controller                 Normal          CREATE  ip: <IP_ADDRESS>
  46m           5m              9       loadbalancer-controller                 Normal          Service default backend set to echoheadersx:30301

However this is what I see in the logs for l7-lb-controller:
$ kubectl logs l7-lb-controller-wp1k4 l7-lb-controller
I0811 16:09:55.474755       1 main.go:192] Starting GLBC image: glbc:0.9.6, cluster name
I0811 16:09:56.679867       1 main.go:352] Using uid = "2043b92cf2a8ad1f" saved in ConfigMap
I0811 16:09:56.681814       1 main.go:352] Using provider-uid = "2043b92cf2a8ad1f" saved in ConfigMap
I0811 16:09:56.683747       1 utils.go:123] Changing cluster name from  to 2043b92cf2a8ad1f
I0811 16:09:56.683809       1 utils.go:132] Changing firewall name from  to 2043b92cf2a8ad1f
panic: runtime error: invalid memory address or nil pointer dereference [recovered]
        panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x20 pc=0x4eebbf]

goroutine 1 [running]:
io/ioutil.readAll.func1(0xc4205eb940)
        /usr/local/go/src/io/ioutil/ioutil.go:30 +0x119
panic(0x1a96820, 0x28bf780)
        /usr/local/go/src/runtime/panic.go:489 +0x2cf
bytes.(*Buffer).ReadFrom(0xc4205eb898, 0x0, 0x0, 0xc4200bee00, 0x0, 0x200)
        /usr/local/go/src/bytes/buffer.go:179 +0x13f
io/ioutil.readAll(0x0, 0x0, 0x200, 0x0, 0x0, 0x0, 0x0, 0x0)
        /usr/local/go/src/io/ioutil/ioutil.go:33 +0x150
io/ioutil.ReadAll(0x0, 0x0, 0x0, 0xc4205eb9e0, 0x49107c, 0x2, 0xc420078a50)
        /usr/local/go/src/io/ioutil/ioutil.go:42 +0x3e
k8s.io/ingress/controllers/gce/controller.getGCEClient(0x0, 0x0, 0x0)
        /var/build/go/src/k8s.io/ingress/controllers/gce/controller/cluster_manager.go:215 +0x4d
k8s.io/ingress/controllers/gce/controller.NewClusterManager(0x0, 0x0, 0xc420430ed0, 0x76aa, 0x1d44234, 0x4, 0x7ffdf931070c, 0x7, 0x7ffdf9310714, 0x14, ...)
        /var/build/go/src/k8s.io/ingress/controllers/gce/controller/cluster_manager.go:274 +0x1175
main.main()
        /var/build/go/src/k8s.io/ingress/controllers/gce/main.go:250 +0x85a

Running:
kubectl describe pod l7-lb-controller-wp1k4

Reveals the following, with the last 3 lines repeating over and over again (removed for brevity):
Events:
  FirstSeen     LastSeen        Count   From                                                    SubObjectPath                           Type            Reason          Message
  ---------     --------        -----   ----                                                    -------------                           --------        ------          -------
  50m           50m             1       default-scheduler                                                                               Normal          Scheduled       Successfully assigned l7-lb-controller-wp1k4 to gke-cluster-1-default-pool-465d4f9f-jtvb
  50m           50m             1       kubelet, gke-cluster-1-default-pool-465d4f9f-jtvb       spec.containers{default-http-backend}   Normal          Pulling         pulling image "gcr.io/google_containers/defaultbackend:1.0"
  50m           50m             1       kubelet, gke-cluster-1-default-pool-465d4f9f-jtvb       spec.containers{default-http-backend}   Normal          Pulled          Successfully pulled image "gcr.io/google_containers/defaultbackend:1.0"
  50m           50m             1       kubelet, gke-cluster-1-default-pool-465d4f9f-jtvb       spec.containers{default-http-backend}   Normal          Created         Created container with id 5726e3860f92596c17559409062dde53478d5a3c897f9a29d9b557ae91f42f38
  50m           50m             1       kubelet, gke-cluster-1-default-pool-465d4f9f-jtvb       spec.containers{default-http-backend}   Normal          Started         Started container with id 5726e3860f92596c17559409062dde53478d5a3c897f9a29d9b557ae91f42f38
  50m           50m             1       kubelet, gke-cluster-1-default-pool-465d4f9f-jtvb       spec.containers{l7-lb-controller}       Normal          Pulling         pulling image "gcr.io/google_containers/glbc:0.9.6"
  50m           50m             1       kubelet, gke-cluster-1-default-pool-465d4f9f-jtvb       spec.containers{l7-lb-controller}       Normal          Pulled          Successfully pulled image "gcr.io/google_containers/glbc:0.9.6"
  50m           50m             1       kubelet, gke-cluster-1-default-pool-465d4f9f-jtvb       spec.containers{l7-lb-controller}       Normal          Created         Created container with id 44f88cbd7a3f6d649ee6ac3de3f6bb515ea0836bdfd024418f06065d582b472d
  50m           50m             1       kubelet, gke-cluster-1-default-pool-465d4f9f-jtvb       spec.containers{l7-lb-controller}       Normal          Started         Started container with id 44f88cbd7a3f6d649ee6ac3de3f6bb515ea0836bdfd024418f06065d582b472d
  50m           50m             1       kubelet, gke-cluster-1-default-pool-465d4f9f-jtvb       spec.containers{l7-lb-controller}       Normal          Started         Started container with id 75046f0b98d0454b87a07dcfc58f716d0ed3ec53ab93014d45168cc1926fe83e
  50m           50m             1       kubelet, gke-cluster-1-default-pool-465d4f9f-jtvb       spec.containers{l7-lb-controller}       Normal          Created         Created container with id 75046f0b98d0454b87a07dcfc58f716d0ed3ec53ab93014d45168cc1926fe83e
  50m           49m             2       kubelet, gke-cluster-1-default-pool-465d4f9f-jtvb                                               Warning         FailedSync      Error syncing pod, skipping: failed to "StartContainer" for "l7-lb-controller" with CrashLoopBackOff: "Back-off 10s restarting failed container=l7-lb-controller pod=l7-lb-controller-wp1k4_default(0cf358ad-7eab-11e7-af58-42010a9a0fd2)"

  49m   49m     1       kubelet, gke-cluster-1-default-pool-465d4f9f-jtvb       spec.containers{l7-lb-controller}       Normal  Started         Started container with id bd9ee0de9d01c964031c54dd0d3ef30b755acabac2c11d109a01c81d75b07014
  49m   49m     1       kubelet, gke-cluster-1-default-pool-465d4f9f-jtvb       spec.containers{l7-lb-controller}       Normal  Created         Created container with id bd9ee0de9d01c964031c54dd0d3ef30b755acabac2c11d109a01c81d75b07014
  49m   49m     3       kubelet, gke-cluster-1-default-pool-465d4f9f-jtvb                                               Warning FailedSync      Error syncing pod, skipping: failed to "StartContainer" for "l7-lb-controller" with CrashLoopBackOff: "Back-off 20s restarting failed container=l7-lb-controller pod=l7-lb-controller-wp1k4_default(0cf358ad-7eab-11e7-af58-42010a9a0fd2)"

Filing the bug in case that exception should not happen, and needs to be fixed.

Also, a question: do I even have to run kubectl create -f rc.yml?
Per tutorial in that readme, it seems like running kubectl create -f ingress-app.yml should be sufficient to demonstrate the concept of the ingress, which is indeed working perfectly.

@gmile  You don't need to run that command. GKE already runs the ingress controller on the master - though, you can't see it via kubectl get pods -n kube-system.
However, this does expose a bug for those running this controller on an unmanaged cluster without a GCE configuration file.  The controller should gracefully handle no configuration provided.

These docs are more helpful for GKE:
https://cloud.google.com/container-engine/docs/tutorials/http-balancer

You don't need to run that command

@nicksardo do you think the documentation could be updated with a note pointing, once again, that in case of GKE, there's no need to create the controller?


⚠ Bofrost.lu has degraded performance

In 666efe7, Bofrost.lu (https://www.bofrost.lu) experienced degraded performance:

HTTP code: 200
Response time: 2111 ms

Resolved: Bofrost.lu performance has improved in 5087511 after 13 minutes.


random levels for project 8

Hello,
I found your tutorial amazing and was wondering if theres a way to have random levels instead of going through the levels numerically, for project 8. I can't seem to find the solution.
Thanks in advance.

This is not an issue; you might want to try posting on https://www.reddit.com/r/hackingwithswift or, if you have general code questions, something like Stack Overflow.


Error

Why i can not run this?

what is my wrong?

you need x86_64-elf-gcc

you need x86_64-elf-gcc

if it doesnt work i suggest using xklap-x86_64-g++-build-nightly-git

if it doesnt work i suggest using xklap-x86_64-g++-build-nightly-git

you need x86_64-elf-gcc

No

you need x86_64-elf-gcc

No

Why i can not run this?

what is my wrong?

Reclone the new repo, you only need clang

Why i can not run this?

what is my wrong?

Reclone the new repo, you only need clang

In the makefile, replace /home/abbix with /home/yourusername.

In the makefile, replace /home/abbix with /home/yourusername.

In the makefile, replace /home/abbix with /home/yourusername.

Nope, this is not needed anymore

In the makefile, replace /home/abbix with /home/yourusername.

Nope, this is not needed anymore

Just rm - rf the repo version you have right now, and reclone the repo

Oh ok

Oh ok

Just rm - rf the repo version you have right now, and reclone the repo

Just rm - rf the repo version you have right now, and reclone the repo

but this does not work and I again see an error!
CC=clang meson setup kernel/meson/ build/ && ninja -j4 -C build/
/bin/sh: 1: meson: not found
make: *** [Makefile:5: all] Error 127

Just rm - rf the repo version you have right now, and reclone the repo

but this does not work and I again see an error!
CC=clang meson setup kernel/meson/ build/ && ninja -j4 -C build/
/bin/sh: 1: meson: not found
make: *** [Makefile:5: all] Error 127

Just rm - rf the repo version you have right now, and reclone the repo

but this does not work and I again see an error!
CC=clang meson setup kernel/meson/ build/ && ninja -j4 -C build/
/bin/sh: 1: meson: not found
make: *** [Makefile:5: all] Error 127

Please look at the build guide

Just rm - rf the repo version you have right now, and reclone the repo

but this does not work and I again see an error!
CC=clang meson setup kernel/meson/ build/ && ninja -j4 -C build/
/bin/sh: 1: meson: not found
make: *** [Makefile:5: all] Error 127

Please look at the build guide

Just rm - rf the repo version you have right now, and reclone the repo

but this does not work and I again see an error!
CC=clang meson setup kernel/meson/ build/ && ninja -j4 -C build/
/bin/sh: 1: meson: not found
make: *** [Makefile:5: all] Error 127

Please look at the build guide, it's in docs/

yea yea it's work it sorry i am stupid!

Just rm - rf the repo version you have right now, and reclone the repo

but this does not work and I again see an error!
CC=clang meson setup kernel/meson/ build/ && ninja -j4 -C build/
/bin/sh: 1: meson: not found
make: *** [Makefile:5: all] Error 127

Please look at the build guide, it's in docs/

yea yea it's work it sorry i am stupid!


Kill the receive type tabs

whole point of unified QR was to not have two tabs, ln and onchain... and now I have three tabs smh
instead I think we could make something a lot more subtle but still just as capable by stuffing the options in a dropdown. bonus is the dropdown also serves as a "tag" letting you know what the qr code is about
one potential thing to figure out is if we do a bip21 for the onchain, or just an address, or both. I'm kind of leaning toward bip21 for the QR code because that includes the amount and we forced the user to input an amount at first, so makes sense to use the amount. if they want an address specifically that's more of a "I know what I'm doing" thing

Can remember their last choice as well? That sounds correct?

closed by #311


[Question]: Host/Port is wrong in Home Assistant Container

Ask your question
I installed the docker and when I check the logs i see
INFO  Eufy Security server listening on host <IP_ADDRESS>, port 3000  INFO  Push notification connection successfully established  INFO  Connected to station T8010P2321502A3C on host
So in Home Assistant I installed the Eufy security but when I want to add it to integrations I receive error that host or port is wrong?
Any idea what I did wrong?

I do not use HomeAssistant and the integration, so please check the respective HomeAssistant forum or integration repository and ask there.


Remove unnecessary dependency on six.

Remove the last remaining usag of it in VCR.testcase.

Codecov Report

Merging #743 (3ff822d) into master (7e11cfc) will decrease coverage by 0.70%.
The diff coverage is 100.00%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
@@            Coverage Diff             @@
##           master     #743      +/-   ##
==========================================
- Coverage   90.63%   89.94%   -0.70%
==========================================
  Files          28       28
  Lines        1794     1790       -4
  Branches      322      254      -68
==========================================
- Hits         1626     1610      -16
- Misses        133      145      +12
  Partials       35       35

Impacted Files
Coverage Δ

vcr/config.py
95.06% <100.00%> (ø)

... and 5 files with indirect coverage changes
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

@hartwork sure thing, thanks for the review! Just forced-pushed a commit that addresses the formatting issue.


Fix PXE booting issues during deployment

This patch monkey patches in the fix for setting pxe_enabled on ironic ports
during OOB introspection.

Testing the fix now on the Mobile Rack.

Tested this fix on both Chris's stamp and the Mobile Rack.  All nodes pxe booted as expected.


softsign activation function

Description
Add softSign Activation function

Skipped numeric_gradient since it was failing on this branch but passes on the master branch, also the functionality is tested using methods defined with numpy.

Checklist
Essentials

[ x] Passed code style checking (make lint)
[ ] Changes are complete (i.e. I finished coding on this PR)
[ ] All changes have test coverage:
Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
[ ] Code is well-documented:
For user-facing API changes, API doc string has been updated.
For new C++ functions in header files, their functionalities and arguments are documented.
For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
[ ] To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

[ ] Feature1, tests, (and when applicable, API doc)
[ ] Feature2, tests, (and when applicable, API doc)

Comments

If this change is a backward incompatible change, why must this change be made.
Interesting edge cases to note here

Please cherry pick into release branch once #9851 is merged.

@szha This will help MXNet users who can't migrate from 0.11 to 1.0 just yet, but need the operator.

We are not running any CI for v0.11 and as far as I remember, was the plan to only support the last two versions (in this case v1.0 and v1.1) with patches.
Could you explain why people are not able to upgrade? It doesn't make much sense that spend a lot of time working on new versions while customers are not actually able to use them.

In my opinion, the right approach here would be that this change is getting done on the master and people who are interested in this operator cherry pick it. But adding a new operator is not a patch according to sem-ver.

Yeah, that would be the right approach. Semver doesn’t have to apply for 0.x, so cherry pick should be fine.

We retrofit critical bugfixes to previous releases. This is a new feature. If you do it for 0.11, then you'll need to do it for all the releases after that.
This is not a sustainable approach

@piiswrong @szha
Some background:
One of the customer is using MXNet-Scala Interface of 0.11 version. They are soon to go live with their product(in the next 2 weeks), they use  a CustomOp to perform Softsign in which I and @yzhliu suspect the leak to be coming from. We spent quite a bit of time trying to analyze the code and debug the issue, however we haven't been able to nail down where it is coming from. In order to help the customer launch their product, I am providing this activation function on 0.11.
I understand this does not follow semver, etc., The customer has been very patiently working with me and Yizhi and I see it as a big win for MXNet. They certainly want to upgrade their MXNet to the  latest but not before their product launch.
I hope that makes sense.
@szha, the reason to have this as a separate commit is that the activation function has gone through some refactor, so cherry picking does not work for this.

Considering the fact that we are not making any releases for v0.11, it
doesn't really make sense to work on that branch. Or does the customer work
off the v0.11 branch head instead of the release tag? Considering that no
validation in terms of CI is happening after a release, I'd strongly advise
anybody against just cloning and compiling a random branch head instead of
it's tag.
The preferred approach here would be to check out the release tag and apply
all required changes manually. Afterwards, run unittests with the target
configuration on the target platform.
We should refrain from making customer specific changes (besides Bugfixes
of course) to old branches.

Rules are nice, but IMHO, customer adoption right now trumps everything

Of course, but we can't guarantee correctness due to lacking CI and we'd have to make a formal release according to Apache in order to be able to supply new binaries.

probably this discussion should occur on dev and see what the mentors think
On Thu, Feb 22, 2018 at 12:42 PM, Marco de Abreu<EMAIL_ADDRESS>wrote:

Of course, but we can't guarantee correctness due to lacking CI and we'd
have to make a formal release according to Apache in order to be able to
supply new binaries.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/apache/incubator-mxnet/pull/9858#issuecomment-367815373,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AKts_U3nSqO421kSbpdF5eaq0ErOr-Bnks5tXdE3gaJpZM4SOoGV
.

The rules are standards we set for ourselves, and we probably don't want people to think this is a community that's OK to bend the rules whenever it's more convenient.
Under these constraints, I'd recommend adding the API to v0.11 only as a contrib operator. If you want it to appear as the official api, then it's necessary to stick to what Eric suggested and add it to all successive versions.

"whenever it's convenient"?  none of this seems terribly "convenient".  Not sure where that framing came from.  Customer obsessions is rarely about convenience.
Anyway, contrib sounds fine, to me.

Ok, I registered the symbol under contrib.

Contrib also sounds good to me. Are we going to make a formal release or will that customer just checkout the branch head and compile themselves?

We can't just put stuff into arbitrary previous versions and then have it disappear later then reappear.
I would just make a fork for this customer.

+1 would have to go into all releases after 0.11

I am ok to put it to all the releases after 0.11.0 upto master, but I don't think it has to be done right away.

I am closing this PR. Customer is ok to apply the patch on v.0.11.


New Zealand State Highway Shields

Proposed is to add support for New Zealand State Highways:
tagging: network=NZ:SH
wikipedia: https://en.wikipedia.org/wiki/New_Zealand_state_highway_network
graphics:

Additionally, New Zealand’s Traffic Control Devices Manual provides for urban routes (marked by a black-on-white pentagon) and named touring routes (marked by one-off shields).

So far, no urban routes have been mapped as route relations, but two touring routes have been tagged network=NZ:Touring and network=NZ:Tourist.

I split out #450 and #451 for the urban and touring route shields, leaving this issue to track only the state highways, which are already properly tagged.


control Number of loops

Crelly-Slider: I'd like to control the number of times that the slider loops through the slides. I don't see it as an option, so is there a place in the code that I can adjust this? Thanks

Hi, the modification requires to modify both the frontend and the backend of the plugin. The frontend modification should be done somewhere in the file /js/jquery.crellyslider.js. The backend modification might be more difficult. /wordpress/slider.php contains all the slider options, so that's the start point. Then, you need to modify /wordpress/ajax.php and /wordpress/tables.php to save the setting into the database. Make sure to set CS_DEBUG to true while you're working in the file /crellyslider.php


Please support mzSelector

Is your feature request related to a problem? Please describe.
I need to calculate DEM consumption based on some billing metrics. Today I have to bother the system with a set of queries, one per Type. If mzSelector of the metric API could be used, I could omit the entitySelector, which forces to set the type. One single query would be enough.
Describe the solution you'd like
Extent metric.py by an additional Parameter.
Describe alternatives you've considered
NA
Additional context
NA

This is included in 1.1.61 which was just pushed to pypi.

Thanks a lot James!Am 16.05.2023 um 23:01 schrieb James Kitson @.***>:
Hi @ToTru, this looks like an easy and useful thing to add so I'll plan on adding it as soon as I can.
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: @.***>


[Snyk] Security upgrade zipp from 3.15.0 to 3.19.1

This PR was automatically created by Snyk using the credentials of a real user.![snyk-top-banner](https://github.com/andygongea/OWASP-Benchmark/assets/818805/c518c423-16fe-447e-b67f-ad5a49b5d123)
Snyk has created this PR to fix 1 vulnerabilities in the pip dependencies of this project.
Snyk changed the following file(s):

trustregistry/requirements.txt

[!IMPORTANT]

Check the changes in this PR to ensure they won't cause issues with your project.
Max score is 1000. Note that the real score may have changed since the PR was raised.
This PR was automatically created by Snyk using the credentials of a real user.
Some vulnerabilities couldn't be fully fixed and so Snyk will still find them when the project is tested again. This may be because the vulnerability existed within more than one direct dependency, but not all of the affected dependencies could be upgraded.

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.
For more information:
🧐 View latest project report
📜 Customise PR templates
🛠 Adjust project settings
📚 Read about Snyk's upgrade logic

Learn how to fix vulnerabilities with free interactive lessons:
🦉 Learn about vulnerability in an interactive lesson of Snyk Learn.

This is not a dependency we use, nor is it a subdependency ... as confirmed by reviewing poetry lock files in #863


Styling Columns block

https://github.com/hlxsites/zemax/issues/55
https://github.com/hlxsites/zemax/issues/80
Other pages where columns block neeeds to be styled (for icons)

https://www.zemax.com/pages/opticstudio
https://www.zemax.com/pages/opticstudio
https://www.zemax.com/pages/opticsbuilder

This is not needed anymore as they are redirecting off product pages.


feat:populate db with fake data, update:readme file with build instru…

added populateDB.js script to populate db with fake data. Useful in testing and dev
Updated the README.md file with build instructions

I just pushed a commit (09efb4e) with:

A saved faker version to be used before the Aaron Swartz incident.
Ethers JS to create a random wallet for the walletAddress attribute of the user model


About clip and kaolin problem

Instead of using the pip installation method of yml, install it according to the methods on the clip and kaolin homepages, just make sure that there are clip1.0 and kaolin 0.12.0 in the conda list.
1. Install clip1.0:
pip install git+https://github.com/openai/CLIP.git
2. Install kaolin0.12.0:
vi ~/.bashrc
export CUDA_HOME=/usr/local/cuda
source ~/.bashrc
conda activate text2mesh
git clone --recursive https://github.com/NVIDIAGameWorks/kaolin
cd kaolin
git checkout v0.12.0
python setup.py develop
Please refer to the following URL
clip 1.0
kaolin 0.12.0
For more details please refer to my blog
My Blog

你好，请问你复现后有尝试过论文中的一些例子吗 我用官方给的配置发现很多例子和论文有差距 例如 仙人掌鞋子和砖块鞋子，请问这是因为CLIP的版本不一样吗还是什么情况
期待回复，万分感谢


typo in the formula of alpha

there is either a mistake at this line or later in the code
alpha = len(X_training)/len(X_raw)

Thanks! The mistake is actually in the code, the numerator should be the number of unlabelled examples. I am making this change now.


Make container-interop/container-interop optional dependency

Alternative way to #1279 without BC break.

@Taluu what is needed to merge PR?

Add tests to show nothing breaks ?
E.g having a container that extends the psr interface and passes, and another one that uses the old interop interface and works ?
And also, the 3rd party extensions will need to require the psr or the interop, but I guess it should be done anyway.
That is why it is still a minor BC break, but an acceptable one IMO.

Add tests to show nothing breaks ?

Done :wink:

Should I rebase and squash it?

Can a release with this be made?

@mvorisek I'll try to release it in the nearest week or so.

FYI container-interop/container-interop was added back to composer.json in this commit for some reason:
https://github.com/Behat/Behat/commit/706b5a549077fe04fb22808b0d19d95b628455f4#diff-d2ab9925cad7eac58e0ff4cc0d251a937ecf49e4b6bf57f8b95aab76648a9d34R34
I’m still getting this warning:

Package container-interop/container-interop is abandoned, you should avoid using it. Use psr/container instead.” warning.

@tedw no. This commit only added a comma at the end of the line

And the line in the commit you mentioned is in the require-dev section, which will not have any effect when you use behat/behat in your own projects. Run composer why container-interop/container-interop to see which package depends on it

@stof Thanks for the quick reply! Apologies for the confusion on my part. I just started working on a preexisting site and was still seeing the warning but it turned out to be some dependency that was loading an older version of behat.
Thanks again for the reply and your work on behat!


no left to right swing

I don't have an option to control left-right movement, would it be possible to enable it? In Panasonic app it's working properly. Both units are CS-Z35VKEW

+1, I have a HZ25XKE

Unfortunately, the default card doesn't support for multiple swing modes. And the horizontal swing modes attributes were lost due to changes, but that has been fixed by #145
There is also an extra service panasonic_cc.set_horizontal_swing_mode that lets you change the horizontal mode.

Great! Then I'll wait for the next release, thanks for the effort!

It looks like the integration does not follow the spec for Swing Modes which specifies SWING_OFF, SWING_VERTICAL, SWING_HORIZONTAL & SWING_BOTH. Seems like a trade-off. The integration currently lets you specify more granular but because of that you can only set one direction.

Horizontal swing has been moved to separate select control in v1.1.0


I'm trying to use generic OCR sending a 3 page pdf and EDEN is not working extracting text

I'm trying to use generic OCR sending a 3 page pdf and EDEN is not working extracting text,  it works just sending images, I need to send pdf and extract text.

Hi, You do need to convert your pdf to a list of images and send them one by one.
We're working on releasing a new async OCR features that can handle multiple pages OCR.


[#105] Added model downloading script to init.py

Required model is now downloaded to the root of ml service folder
when init.py is run

[#105]

Assumption was that after 99% we don't need to let the user know about progress since it is near complete. Also saves 3 second sleep time.

Are you ok with this being merged? I'll add comments in a later PR


Foodbank distance

PR to merge in OD matrix building. All done within build_od.py (run to be run after make_data.py).
Tidied up src/backend folder + pre-merged with develop branch.

All scripts run, all tests pass, code runs (and looks pretty tidy), updated README with a quick note on the backend data scripts.


oss-fuzz integration

Hi,
Would you be interested in enrolling your project into oss-fuzz? I have a pull request waiting to happen but before that I want to check if you are interested and if so, get some feedback on my test harness :smile:

@bshastry I assume you're talking about this project? 🤔

@bnb Exactly. Sorry for not clarifying this earlier.

@bshastry I believe this is a task for the Security WG. We have an issue on that topic https://github.com/nodejs/security-wg/issues/435


Adding slider history feature

At a workshop on Tuesday a few participants said they missed the following features in the front end:

see the last X changes made to a scenario

quickly save/bookmark a certain 'stage' (i.e. all changes up to a certain point) to which the user can easily go back.

The motivation behind this was that they wanted to try out different routes for 'finetuning' a scenario and quickly go back to a stage they were happy with if things didn't work out as they wanted them to.
I like this idea, as it provides a nice overview of all the changes the user made. Another thing I noticed was that people tend to forget in which tab they made a certain change. E.g. they change the car share to 100% electric, decide that they want to add some hydrogen cars 10 minutes later but can't remember which tab to go to. This can be solved by making the change history 'clickable', i.e. by clicking on the 100% electric change you automatically jump to the right tab.
Any thoughts @ChaelKruip @AlexanderWirtz @DorinevanderVlies @antw @grdw ?

Any thoughts @ChaelKruip @AlexanderWirtz @DorinevanderVlies @antw @grdw ?

I like it a lot! We would have to come up with a nice way to visualise the history-of-clicks though and think of a place in the ETM where to put this...


code-server can not run python file

Does this issue occur when all extensions are disabled?: Yes/No

VS Code Version:
OS Version:

Steps to Reproduce:

I download the latest code-server, version is code-server-4.13.0
I use ./code-server --port 5000 to start
I download the python extension then it toast some warnings
the error is as followings

also, the python file can not run
I think it is a serious bug, can you help to fix

code-server is not an officially supported vscode distribution


[Improve][Connector-fake] Optimizing Data Generation Strategies

Search before asking

[X] I had searched in the feature and found no similar feature requirement.

Description
At present, the fake first completes the data generation, and then transmits it to the sink, if you test a large amount of data, it will cause memory overflow.  Optimization point：The generated data is directly transmitted to the sink, and it is not necessary to generate all of them.
Usage Scenario
No response
Related issues
No response
Are you willing to submit a PR?

[ ] Yes I am willing to submit a PR!

Code of Conduct

[X] I agree to follow this project's Code of Conduct

I hope you can assign this pr to me. I am a little white man and I am very interested in this

I hope you can assign this pr to me. I am a little white man and I am very interested in this

Has been assigned to you, feel free to contact me if you have any questions.

I hope you can assign this pr to me. I am a little white man and I am very interested in this

Has been assigned to you, feel free to contact me if you have any questions.


Add k8s 1.26.0 (Kind) to the test matrix

Question to maintainers:
Should we keep 1.21 in the test matrix for now, or shall we drop that from the matrix? E.g. limit the tests to max 5 versions.
Officially we only support the last 3 k8s releases as stated in our README.md.
Currently our chart is perfectly compatible with 1.21.
Personally I think we can leave 1.21 around until we build features that are incompatible with 1.21.
See https://github.com/kubernetes-sigs/kind/releases/tag/v0.17.0 for more details.

I'd benefit from a 1.21 test while it takes little effort to maintain. If it does become burdensome we can drop it?


Better accessibility support

We would like to see better accessibility support in the schema and the HTML renderer.

Use of proper HTML tags and attributes (e.g  anchor element for hyperlinks, alt on image etc)
Support for ARIA attributes
Support for high contrast mode

Duplicate of #422


Bump flutter_lints to ^2.0.0

Compatible with flitter 3

I'm closing this since PR #38 was done.
Thanks.


Fix gcp delete with invalid credentials

This draft PR optimizes the capture of the ProviderID during CloudSQL creation so that the ProviderID can be used to optimize deletion of CloudSQL resources in the event that the resource was never successfully created.
I haven't run this yet.
A better strategy, as discussed in slack, may be to update this controller to match others with a newer reconciler pattern. @ichekrygin
Which issue is resolved by this Pull Request:
Resolves #315
Checklist:

[ ] Documentation has been updated, if necessary.
[ ] Pending release notes updated with breaking and/or notable changes, if necessary.
[ ] Upgrade from previous release is tested and upgrade user guide is updated, if necessary.
[ ] Code generation (make generate) has been run to update object specifications, if necessary.
[ ] CRD manifests generation (make manifests) has been run to update CRD manifests yaml file specifications, if necessary.
[ ] Update dependencies (make vendor) has been run to update Gopkg.lock file, if necessary
[ ] RBAC permissions in clusterrole.yaml have been updated to include new types, if necessary
[ ] All related commits have been squashed to improve readability.
[ ] Comments have been added or updated based on the standards set in CONTRIBUTING.md

Closing this in favor of a GCP CloudSQL controller rewrite.


Version 7 - soltion doesn't have filed algvars

I‘ve downloaded the newest version OpenOCL(7.04), and i try to run a simple code as follow，i just wanna to get the algvars of solution, but failed. How can i get the solution algvars?
ocp = ocl.Solver(20,@varsfun,@daefun,'N',20);

ocp.setInitialBounds('x',0);

ig = ocp.getInitialGuess();
[solution,times] = ocp.solve(ig);

plot(solution.states.x.value, solution.algvars.y.value);

function varsfun(h)
h.addState('x');
h.addAlgVar('y');
end

function daefun(h,X,Z,U,C)
x = X.x;
y = Z.y;
h.setODE('x',10);
h.setAlgEquation(x*x-y);
end

Solved. The states and algvars are the children of solution.integrator, so the right code is:
...
x = solution.integrator.states.x.value;
y = solution.integrator.algvars.y.value;
plot(x,y)
...


Add altform-colorful splashscreen pngs

Description of the changes:

Add splashscreen altform-colorful pngs to the assets

How changes were validated:

N/A

What does this mean? Does this mean that Calculator will finally use the accent colour for the splash screen again? I thought it was a bug at first.

@DragoCubed No


[Gally]: master <- dev

Automatically created by Git-Ally

:tada: This PR is included in version 2.1.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Support of handling password protected PDF file

i don't think this is possible. It's good to have but, I'm just not sure if this can be done, closing this for now.

+1


Contributing to the project

Me and my team are looking for an open source project to contribute to, and this seems like a good starting point to work on.
I have a couple of queries, and I would be glad if someone would help us out.

Besides the ones listed in the CONTRIBUTING.md, are there anymore requirements for the contributions(mostly bug fixes) to be merged with the project?
Are feature additions considered for merging with the project?

I'm new to contributing to OSS, so any help would be really appreciated! :D

@sid-the-ant Hi welcome, you can look for issues with good-first-issue tag and get them assigned to you, regarding new features, you can always create a new issue and based upon the discussion a new feature could be implemented :)

@nicolas-raoul this issue is useless you can close this

@Rishavgupta12345 Please do not say "useless", that's unfriendly.


bugreport: mac os x yosemite

This happened after closing the tetris app and starting it again. Also the "press space to start" alert is not vanishing.

Please report this if you think this is a bug. Include a brief description on how the error occured, and if you can; how to replicate it

TypeError: Cannot set property 'innerHTML' of null
    at ApplicationTetrisWindow.drawScore (http://osjsv2.0o.no/packages/experiments/Tetris/combined.js:513:29)
    at draw (http://osjsv2.0o.no/packages/experiments/Tetris/combined.js:420:12)
    at frame (http://osjsv2.0o.no/packages/experiments/Tetris/combined.js:429:9)

Duplicate of #190
Thanks for reporting it! I have made a possible fix for this and I will deploy it later today :)


.animated class clashes with bootstrap modal

"animation-fill-mode: both" attribute clashes with the boostrap 3 modal popups.
It causes the class "modal-backdrop" to appear in front of all the others

If you remove the css attribute, it causes the content to flicker once before loading.
n.b. I am using animate.css along with wow js.
Any solutions?

@Ignitis use AOS.js instead

@graingert Thanks, mate. This looks better than using WOW and Animate together.
Cheers!


Weird results when executing multiple commands at once

sin(pi) should be 0 in the first line

Happened to be solved by a commit for #140


cuda8.0

Can I change cuda8.0 to cuda9.0?

yes, you can. @wuxiaolianggit

gcc: error trying to exec 'cc1plus': execvp: No such file or directory
error: command '/usr/local/cuda/bin/nvcc' failed with exit status 1
Excuse me,How can I solve this problem?

@wuxiaolianggit Have you successful in changing cuda8.0 to cuda9.0? What should I do to make that change?

@wuxiaolianggit Have you successful in changing cuda8.0 to cuda9.0? What should I do to make that change?
你好，请问你用了哪个版本的CUDA成功跑通了程序？


2D Lighting doesn't render all lights when TileMap cell_quadrant_size is not small enough

Godot version
v4.1.1.stable.arch_linux
System information
Godot v4.1.1.stable unknown - EndeavourOS #1 SMP PREEMPT_DYNAMIC Wed, 19 Jul 2023 19:19:38 +0000 - Vulkan (Mobile) - dedicated NVIDIA GeForce GTX 1070 (nvidia; 535.86.05) - Intel(R) Core(TM) i5-8400 CPU @ 2.80GHz (6 Threads)
Issue description
Some PointLight2D nodes seem to not be rendered (on the TileMap and ONLY on the TileMap, Sprite2Ds seem to still get the correct Lighting) when there are multiple PointLight2D nodes within a close proximity, and the TileMap's cell_quadrant_size is not small enough.
This is an example video from my personal game project.
https://github.com/godotengine/godot/assets/3057229/05432d43-733b-4c3f-a738-4aea236f6df4
I've attached a minimal example project that demonstrates the problem. It's not instantly as noticeable as my personal game, but it definitely exhibits the same issues.
This also is a bug in all rendering backends, Forward+, Mobile, and Compatibility.
Steps to reproduce
Create a TileMap and add a DirectionalLight2D with mix mode changed to subtract to create a darkness. Add some PointLight2D nodes around the map. Then add a player character of some kind that can move around, with a Camera2D and another PointLight2D as children.
If you don't see the issue when playing (actually it happens in the editor also), then add more PointLight2D nodes and/or increase the TileMap cell_quadrant_size.
In my reproduction project, you can also watch lights reappear in the editor, if you select the TileMap, and raise the cell_quadrant_size to 128, then click the down arrow to keep reducing it until you see the problem.
Minimal reproduction project
2DLightingBug.zip

The 2D renderer supports up to 16 lights per item. When you use a large quadrant size, the entire quadrant is rendered as one item, so the 16 light limit applies to the entire quadrant. If you are bumping up against that limit, then you likely need to reduce the size of your quadrant, or reduce the number of lights that you are using.
Since you are using the subtract blend mode. You may also be able to get by with rendering the lights as Sprite2Ds with a CanvasItemMaterial with blend mode set to "Subtract". This is another way to get around the limit of 16 lights per item

@clayjohn Ok, I see. This definitely should be noted in the documentation somewhere. It would be nice if this could be increased a bit, say to 32 lights per item? Seems like an arbitrary limitation, that somebody probably reasonably thought wouldn't be an issue.

It can't be increased that easily, it's done to fit within 4 bits: https://github.com/godotengine/godot/blob/bc88dca176cef6b8943ded58c68a60f7c127baea/servers/rendering/renderer_rd/shaders/canvas.glsl#L502

(oops hit close button accidentalky on phone) Is there any particular reason its got to fit in 4 bits? 16 lights is actually pretty easy to hit when most of your objects have a light.

Also, i definitely know very little about shader programming, but is that glsl shader still used even with vulkan?

Yes, Vulkan shaders can be either GLSL or HLSL.

I have the same problem.
https://www.youtube.com/watch?v=b8QHgiMhrVY
Yes, in this video, I created more point lights than I needed to check out the limitations. But 16 Point Lights are pretty not enough for me. Yes, at the moment, I use the "CanvasItemMaterial with blend mode set to "Subtract"" trick, but this doesn't cast shadows.
So, I know I will hit the 16 Pointlights limit! I want to have a spring event in the game where there is one time of the year where many fireflies appear. Also, if a player builds several torches into the base, at some point, there probably will be more than 16 lights. (Think about Minecraft and how much Torchlights people put there if they want to)
As mentioned, it only happens on the Tilemap system. So, at this point, my only solution would be to change the source code... Or not use Tilemap... But this can't be a solution.
Is this problem fixable in the future by Godot? So, if I know it will be possible at some point in the future, I will not think about it at the moment. But if it's not planned, it's definitely a showstopper for me."

(Think about Minecraft and how much Torchlights people put there if they want to)

Minecraft doesn't use real-time lights. Instead, it uses vertex colors on blocks to simulate lighting. This is how it can render an unlimited amount of lights with no performance impact.
A similar approach is used in Terraria in 2D. In general, if you want to support a massive amount of static lights, this is the way to go. It can already be done in Godot by changing the Modulate property of individual tiles in a script. You'll essentially have to implement your own lighting system, but it's worth the effort for this kind of game.

It was just an "people would use more then 16 lights" thing then the technical aspect behindt it when i mentioned minecraft^^
Okay so yeah this means there will not be any fix for the tilemap miss light when more then 16 lights are on the screen?
Thats all i want to know. if not i will create my own light system yes, but i have to know.
Not want to create something and in godot 4.4 its fixed / implemented / whatever.
Have a good night


Version 4 - .not()

Follow-up of #383.
Adds .not() method to validation chains (both legacy and check APIs).

Coverage increased (+0.06%) to 97.651% when pulling d1bcafb8e4b54766954a66f8cec07fc92ca2ab61 on v4-negate into f32569e988c66562a2fa31b5eb37008cb1db694f on master.


[WIP] Mailer service objects

New PR for switching to service objects instead of callbacks for sending emails to users when:

email address is changed
password is changed
user is added to a project as an expert or collaborator

Very much a work in progress.
Review checklist

[ ] First, the most important one: is this PR small enough that you can actually review it? Feel free to just reject a branch if the changes are hard to review due to the length of the diff.
[ ] If there are any migrations, will they the previous version of the app work correctly after they've been run (e.g. the don't remove columns still known about by ActiveRecord).
[ ] If anything changed with regards to the public API, are those changes also documented in the apiary.apib file?
[ ] Are all the changes covered by tests? Think about any possible edge cases that might be left untested.

Looking good you've got most of the components in this covered.
I think you should unit test the operation classes in isolation and just make sure the controller calls them. Seems @marten previously still tested the expected behaviour in controllers ala here as well. Probably to ensure the controller params piping is correct.

I did that for pretty much two reasons:

I generally try to have one happy-path acceptance test that integrates everything.

And maybe:

Some other cases where I extracted logic to operations, I didn't remove all controller test cases after it was extracted.

Can you tell why the ProjectRolesController spec on line 81 is failing? It's trying what you suggest: expect(Mailers::UserAddedToProject).to receive(:run!) But a binding.pry call in Mailers::UserAddedToProject#execute makes it clear that it is being called, so I think the problem is somewhere in the operation layer and might just be rspec syntax.

you need the expectation before the controller request

@zwolf what's the status of this PR?

Few issues but it's looking good.

The last spec this needs is a check to ensure the mailer worker gets called when a password is changed. I can't get the controller to allow me to change a password via spec, though, as it always 422s and complains about unpermitted params. Building a request in the spec as close to the one on the home page as I can still doesn't fly, so I must be missing something.

@zwolf you'll need to use the passwords controller to change the user password.

Once you remove those unused operations specs i think this is good.

LGTM


Futures Backtest Results - Field 'position' shows only count

Another one in my ongoing testing of futures backtesting. Copying @marketneutral who is likely interested. Did this work on your setup, Jonathan, or did you see the same problem? I'd be happy to share all my code, if there's interest of course.
My Zipline futures environment works quite well, after a bit of work. Trades are done as expected, rolls work fine, performance matches my C# based comparison. However, I have another weird bug.
The dataframe returned by run_algorithm (perf in the analyze routine), has a field called 'positions'. This should hold a list of currently open positions, with a few key details for each such as amount, current price etc. For stocks, all fine.
For my futures backtest however, this field contains just a number. It holds the sum of the longs and the shorts. That is, the total number of open positions.
>perf['positions']

2001-01-02 00:00:00+00:00    []
2001-01-03 00:00:00+00:00    59
2001-01-04 00:00:00+00:00    59
2001-01-05 00:00:00+00:00    59
2001-01-08 00:00:00+00:00    59
2001-01-09 00:00:00+00:00    58
2001-01-10 00:00:00+00:00    58
2001-01-11 00:00:00+00:00    58
2001-01-12 00:00:00+00:00    58
2001-01-16 00:00:00+00:00    58
2001-01-17 00:00:00+00:00    58
2001-01-18 00:00:00+00:00    58
2001-01-19 00:00:00+00:00    58

Which would be the same as longs + shorts:
>perf['shorts_count'] + perf['longs_count']

2001-01-02 00:00:00+00:00     0
2001-01-03 00:00:00+00:00    59
2001-01-04 00:00:00+00:00    59
2001-01-05 00:00:00+00:00    59
2001-01-08 00:00:00+00:00    58
2001-01-09 00:00:00+00:00    58
2001-01-10 00:00:00+00:00    58
2001-01-11 00:00:00+00:00    58
2001-01-12 00:00:00+00:00    58
2001-01-16 00:00:00+00:00    58
2001-01-17 00:00:00+00:00    58
2001-01-18 00:00:00+00:00    58
2001-01-19 00:00:00+00:00    58

The odd part here is that everything else seems to work just fine. Performance is fine. The 'transactions' field in the same DF is fine.
>perf['transactions']

2001-01-02 00:00:00+00:00                                                   []
2001-01-03 00:00:00+00:00    [{'sid': Future(512 [ED2001H]), 'price': 94.31...
2001-01-04 00:00:00+00:00    [{'sid': Future(453 [COM2001G]), 'price': 210....
2001-01-05 00:00:00+00:00    [{'sid': Future(431 [BL22001F]), 'price': 114....
2001-01-08 00:00:00+00:00    [{'sid': Future(431 [BL22001F]), 'price': 114....
2001-01-09 00:00:00+00:00    [{'sid': Future(484 [BO22001H]), 'price': 14.9...
2001-01-10 00:00:00+00:00                                                   []
2001-01-11 00:00:00+00:00    [{'sid': Future(441 [GOIL2001G]), 'price': 25....
2001-01-12 00:00:00+00:00                                                   []
2001-01-16 00:00:00+00:00    [{'sid': Future(532 [FC2001H]), 'price': 90.40...

Clearly, the 'positions' field is supposed to contain a list of open positions and their details. Not a count.
Any ideas of what may be the issue here? Any investigation I can do locally to help the Zipline maintainers track this one down?

Slightly embarrassing update: Problem located in the area between the monitor and chair.
Note to self. If you record a variable, don't use the same names as existing output fields...
    record(position=pos_count)


WIP: Add ENV OCM_CONFIG in Dockerfile to fix permission issue

Getting permission denied error on GPC cluster.
Zstream trigger: Error: Failed to execute 'Executing command: rosa login --env=https://api.stage.openshift.com --token=***** waiting for 300 seconds.': ERR: Failed to create OCM connection: error creating connection. Can't persist tokens to config: Failed to create directory /.config/ocm: mkdir /.config: permission denied

/build-and-push-container

Failed to build and push quay.io/redhat_msi/ci-jobs-trigger:pr-192

/build-and-push-container

New container for quay.io/redhat_msi/ci-jobs-trigger:pr-192 published

New container for quay.io/redhat_msi/ci-jobs-trigger:pr-192 published

/build-and-push-container

New container for quay.io/redhat_msi/ci-jobs-trigger:pr-192 published

/verified

Successfully removed PR tag: quay.io/redhat_msi/ci-jobs-trigger:pr-192.

New container for quay.io/redhat_msi/ci-jobs-trigger:latest published


Update gitea-vet to v0.2.0

as title
wip: because gitea-vet need a v0.2.0 tag

blocked by #11646

blocked by  #12286

a for i in $(ls v*.go); do echo "$i:"; echo structs; go list -f '{{join .Deps "\n"}}' $i | grep structs; echo "gitea/models"; go list -f '{{join .Deps "\n"}}' $i | grep "gitea/models"; done tells me:
there exist still some code.gitea.io/gitea/modules/structs dependencys in:

v70.go
v71.go
v72.go
v76.go
v79.go
v82.go
v83.go
v85.go
v96.go
v99.go
v112.go
v115.go
v127.go
v128.go
v130.go
v134.go
v136.go
v139.go
v140.go

can we ignore old migrations and only apply this rule to newer ones?  it feels very wrong and error-prone to go back and re-write dozens of old migrations that have been working for a while

@mrsdizzie at this point this are indirect dependencys
for example on v70: the setting.Service.DefaultEnableDependencies value is used.
setting.Service struct as one field (not that one) who is a type decrlared in structs
So my suggestion where: for dependencys: ignores structs and just permit direct imports for structs

Just ignore the previous is better I think. Maybe we need a white list for these files on vet to do that.

@lunny https://gitea.com/gitea/gitea-vet/pulls/9

Codecov Report

Merging #12282 into master will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #12282   +/-   ##
=======================================
  Coverage   43.76%   43.76%
=======================================
  Files         631      631
  Lines       69870    69870
=======================================
+ Hits        30580    30582    +2
+ Misses      34338    34336    -2
  Partials     4952     4952

Impacted Files
Coverage Δ

modules/util/timer.go
42.85% <0.00%> (-42.86%)
:arrow_down:

modules/avatar/avatar.go
50.00% <0.00%> (-4.77%)
:arrow_down:

services/pull/pull.go
42.26% <0.00%> (+0.23%)
:arrow_up:

services/pull/temp_repo.go
29.78% <0.00%> (+3.19%)
:arrow_up:

services/pull/update.go
57.69% <0.00%> (+5.76%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eb60a5d...1a5b2f4. Read the comment docs.

🚀