Issue #201 updating the doc

The documentation on
(https://github.com/Azure-Samples/blockchain/blob/master/blockchain-workbench/messaging-integration-samples/ExecuteLogicBasedOnPropertyValueAfterASpecificContractAction.md)
was inaccurate and changes have been made to correct it.
Purpose

To correct the inaccurate documentation given in the link above.

Does this introduce a breaking change?

[ ] Yes
[x] No

Pull Request Type
What kind of change does this Pull Request introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[x] Documentation content changes
[ ] Other... Please describe:

How to Test

Given in the documentation,

What to Check
Verify that the following are valid

Whenever the function IngestTelemetry is invoked, the specified logic should get executed.

Other Information

Basically, the previous documentation was inaccurate. Maybe because of a recent update to azure and the doc not being updated with it.

The purpose of the doc was to perform some logic when a particular function in blockchain workbench was invoked.

If someone followed the instructions given in the doc exactly, they will find that things will be missing and the json is inaccurate.

This pull request is an attempt to fix this doc.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: manikyabard sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.


npm install fails with io.js

Basically we need https://github.com/rvagg/node-levelup/pull/289.

https://github.com/iojs/io.js/issues/456

Fixed in 1.0.0.


Add authorization

Hi @jonhoo,
I've added optional authorization for the HTTP registry. As with a "push", the "HTTP Authorization" header will be send on a index or crate download request.
Why: For private registry, authorization is not only important for the "push", but for the "pull" of any data, too. Different users can have different rights for crates. Sending an optional authorization header satisfies that need.
As this is my first time modifying Cargo, I'm sure I did a lot of stuff wrong or not optimal, so please let me know, where I can improve the code.
If there is generally no interest in support for authorization and private registries, let me know.

Hi! I think it's probably best to try and land just the HTTP protocol registry first, and then add authorization afterwards, rather than trying to add both at the same time.
Also note that my PR that you've submitted a PR on top of is very much experimental, and is unlikely to land in its current form. Instead, the path forward is first to land https://github.com/rust-lang/cargo/pull/8985, and then to modify my experimental implementation on top of that, rather than have it use a pre-fetching phase like it currently utilizes.

Hi! Alright, I'll keep an I on #8985. If there is any way I can help in the future with the http registry, I'll be happy do to so!

When the http-api is on its way to stabilization, I will be doing a deep dive on the authorization side. It sounds like you have well earned opinions on how that should work. I would love to incorporate your expertise! Can we have a meeting when I start my education on that part? I will be reading the comments on https://github.com/rust-lang/rfcs/pull/2719 so if you want to put your prospective down for posterity that would be a useful place.

@Eh2406 Sure, feel free to contact me any time!

Someone else has start the conversation. Currently the conversation is at https://internals.rust-lang.org/t/pre-rfc-cargo-alternative-registry-authentication/14794


Error in gimmemotif/scanner

https://github.com/simonvh/gimmemotifs/blob/master/gimmemotifs/scanner.py#L323
Undefinded variable "vals".
Greetings, Lisa

fixed


HV-1431 Clean up for constraint locations

https://hibernate.atlassian.net/browse/HV-1431

Thanks, @gsmet!

Hi.  The Open Liberty team is looking into using the Bean Validation 2.0 RI, and wants to better understand the motivation for this change that adds accessPrivateMembers?  The permission seems redundant to requiring accessDeclaredMembers, but we're thinking there must be more to it?  Are there specific scenarios where a user would want to have a security manager enabled, but not grant accessPrivateMembers to the Bean Validation 2.0 RI jar?

Hey @nmittles, the reason is that we want to avoid that direct instantiation of classes like FieldConstraintLocation gives private access to the represented member to outside callers.
One way for doing this would have been to not use a privileged action for the setAccessible() call, so that the caller would be required to have that permission (and use a privileged action themselves, or all frames on the stack above have that permission). But we concluded it'd be better to check for a separate permission which the caller must have. That way the permission for validating private fields can be assigned to the calling code base while not granting general private access at the same time.
Just seeing though that we need to update the documentation, it's currently not described 100% correctly.


ansible operator scaffold doesn't work with $ operator-sdk generate olm-catalog

After generating a scaffolding for an ansible operator, I couldn't use the operator-sdk generate olm-catalog ....   Looks like config/config.yaml is missing.
$ operator-sdk generate olm-catalog --image docker.io/kubevirt/csi-operator:latest --version 0.0.1
Generating OLM catalog manifests
Error: failed to read config file ./config/config.yaml: (open ./config/config.yaml: no such file or directory)

operator-sdk generate olm-catalog is going away.


Add ignore property to format project config

@sebmck I would like to take a look at this. If tha's ok, could you please point me in the right direction? Otherwise I can work on something else

@bsotodo Quite a few files would need to be updated. It's not really for the quaint of heart.

Project loading<EMAIL_ADDRESS>You would need to go to the block that has categoryExists(format) and copy+paste the same ignore property handling that you see for config.lint.ignore.
Linter glob<EMAIL_ADDRESS>format command<EMAIL_ADDRESS>Add a callback to getFilesFromArgs so that project.config.lint.ignore can be customized by<EMAIL_ADDRESS>to use project.config.format.ignore.
WorkerAPI.lint<EMAIL_ADDRESS>Update so that formatting is skipped when ignored. Add a format property in the parameters of handler.format to indicate if formatting should take place
Make a subtype LintRequest in<EMAIL_ADDRESS>with a format property, and disable formatting when it is false.
Pass in the format property to js-compiler.lint in<EMAIL_ADDRESS>

Thanks! I'll give it a try.


fix portal static js link

https://github.com/Azure/ARO-RP/pull/2674 changed main.61fbb3a0.js to main.dfd095e3.js
Portal is currently broken without that

/azp run ci


Detect / prevent namespaces from ending with slash

The definition of namespaces in the specification implies that they should not end with a '/', but we currently do not detect or prevent that.
I would recommend applying this both in object construction and in Document.set_namespace. If a terminal '/' is found, remove and warn.
Related to #328

Sorry to be dense. I still don't see what the problem is. Does pySBOL3 mishandle namespaces that end with a slash? If so, we should definitely fix that. pySBOL3 should always be using posixpath.join for assembling namespaces with other strings, as when an identity is constructed.
I see that validation rule sbol3-10102 (page 66) states:

A TopLevel URL MUST use the following pattern: [namespace]/[local]/[displayId], where namespace and displayId are required fragments, and the local fragment is an optional relative path.
Reference: Section5.1 on page 12

If this rule is taken literally, I can see your point that if the namespace ends with a / then the identity would have a double-slash. On the other hand, if we follow the spirit of this rule I feel like a namespace ending in a / is ok. This is a topic we should open up to more people before implementing a validation rule for namespaces ending in a slash.

I definitely want to pragmatically avoid the question as much as possible via path-style constructions.
It is also the case, that posix path construction explicitly declares multiple slashes as equivalent single slashes, while for URIs that is not the case, so we are operating in a framework that is less permissive than with paths.  For paths Desktop//tmp = Desktop/tmp = Desktop/tmp/, but for URIs, these are not equal.

I think namespaces should end in a delimiter ('/', '#', or ':').  In SBOL2, all namespaces do end in a delimiter from this set.  I think it is important to end with a delimiter, since there is a choice of three.

@cjmyers I think you might be talking about the serialization, rather than the data model, since SBOL2 does not have a namespace property.
I do not believe that the SBOL3 specification, as written, currently allows for anything except for '/' as a delimiter separating the namespace from the rest of a URL. For URIs other than URLs, a delimiter does not apply at all, of course.

Yes, I understand this is for the namespace property.  I'm not sure why we would disallow # and : as delimiters for namespaces, since they are commonly used.

Can you please point me to an example? I haven't previously seen one as an actual URI, as opposed to in a serialization prefixing.

In compliant URIs in SBOL2, this was not allowed.  So, there are likely not many examples in the wild, except maybe SBOL1 non-compliant URIs.  The question is whether or not we want to allow these delimiters in SBOL3 or not.

They would still be allowed in an SBOL3 URI, just not as the end of the namespace.

Closing this as resolved by using URI equality rather than string equality.


sc.pp.filter don't filter the same number between sc.1.3.7 and sc.1.4

Hi all,
I have updated my scanpy to version 1.4 (was working on 1.3.7 before) and did not get the same filtering output using sc.pp.filter_ working with the same input dataset (10X).
By running in sc1.3.7: sc.pp.filter_genes(adata, min_counts=2)
->  267 genes were filtered out and I was able to follow up on my analysis until the end.
However, after switching to the new version, I could not get any filtering anymore. By scaling up, the first filtering I got was with a min of counts of 4 (sc.pp.filter_genes(adata, min_counts=4))
"filtered out 655 genes that are detected in less than 4 counts"
Not sure what is going on there and which setting I should use then.
Any feedback will be more than appreciated.
Thank you

@juje11, sorry about the late response. When I try sc.pp.filter_genes on v1.3.7 and v1.4.0 I get similar results. Here's what I've run:
import scanpy.api as sc  # For v1.3.7
import scanpy as sc  # For v1.4+
adata = sc.datasets.pbmc3k()
sc.pp.filter_genes(adata, min_counts=2, copy=True)

In both v1.3.7 and v1.4 I get an AnnData object with 14745 genes.
If this issue is still occurring, could you please make a minimal example of it?

Hey,
I had to fully switch to the new version to pursue my analysis. I have not tried since. The thing is the minimum count of genes to have the function running was not the same between the 2 versions.
For v1.3.7 I could do min_counts=2
For v1.4.0, I had to go for min_counts=4 otherwise the function was not running.
I have fully switch to the version 4 now, but this seems weird to me.
Thank you very much
Best regards
Julie
From: Isaac Virshup<EMAIL_ADDRESS>Reply-To: theislab/scanpy<EMAIL_ADDRESS>Date: Sunday, March 31, 2019 at 4:23 AM
To: theislab/scanpy<EMAIL_ADDRESS>Cc: Julie Jerber<EMAIL_ADDRESS>Mention<EMAIL_ADDRESS>Subject: Re: [theislab/scanpy] sc.pp.filter don't filter the same number between sc.1.3.7 and sc.1.4 (#501) [EXT]
@juje11https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_juje11&d=DwMFaQ&c=D7ByGjS34AllFgecYw0iC6Zq7qlm8uclZFI0SqQnqBo&r=dbbJvBBVCmCDhD23DINgCQLqFBDi2-dzqKkGr2omow4&m=fUrr9FKs_IHJat8-KnrKtMZ9rvr6Uj_iRwwW3bbDIWA&s=5bKOSfSlkv9Uce14pst-S4M9PLk9PbUDb-KLnmlG1XQ&e=, sorry about the late response. When I try sc.pp.filter_genes on v1.3.7 and v1.4.0 I get similar results. Here's what I've run:
import scanpy.api as sc  # For v1.3.7
import scanpy as sc  # For v1.4+
adata = sc.datasets.pbmc3k()
sc.pp.filter_genes(adata, min_counts=2, copy=True)
In both v1.3.7 and v1.4 I get an AnnData object with 14745 genes.
If this issue is still occurring, could you please make a minimal examplehttps://urldefense.proofpoint.com/v2/url?u=http-3A__matthewrocklin.com_blog_work_2018_02_28_minimal-2Dbug-2Dreports&d=DwMFaQ&c=D7ByGjS34AllFgecYw0iC6Zq7qlm8uclZFI0SqQnqBo&r=dbbJvBBVCmCDhD23DINgCQLqFBDi2-dzqKkGr2omow4&m=fUrr9FKs_IHJat8-KnrKtMZ9rvr6Uj_iRwwW3bbDIWA&s=oJMtygAOyhk8ZPZcm62kP5CexheJuyltsmNZvUlUUJc&e= of it?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_theislab_scanpy_issues_501-23issuecomment-2D478308491&d=DwMFaQ&c=D7ByGjS34AllFgecYw0iC6Zq7qlm8uclZFI0SqQnqBo&r=dbbJvBBVCmCDhD23DINgCQLqFBDi2-dzqKkGr2omow4&m=fUrr9FKs_IHJat8-KnrKtMZ9rvr6Uj_iRwwW3bbDIWA&s=aB9cPrQNETcGloYdbFBtgQwH6PNEJ2uCaq6qo20M-14&e=, or mute the threadhttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_notifications_unsubscribe-2Dauth_AoHInGDcz6S1cG3BkoNqcx4W7nD44kdrks5vcCosgaJpZM4bJs2l&d=DwMFaQ&c=D7ByGjS34AllFgecYw0iC6Zq7qlm8uclZFI0SqQnqBo&r=dbbJvBBVCmCDhD23DINgCQLqFBDi2-dzqKkGr2omow4&m=fUrr9FKs_IHJat8-KnrKtMZ9rvr6Uj_iRwwW3bbDIWA&s=E9-QONI3u257owTiYKSUmNqyODuD4airosKV1vUji-Q&e=.
--
The Wellcome Sanger Institute is operated by Genome Research
Limited, a charity registered in England with number 1021457 and a
company registered in England with number 2742969, whose registered
office is 215 Euston Road, London, NW1 2BE.

Hi Julie,
Could it be that you saved your dataset after running min_counts=2 so that when you reloaded it there were no more genes with min_counts<2 in the dataset to filter out?
Regarding the minimal example.. it would be good to show the different behaviour in a reproducible way (for example using a dataset from sc.datasets). We do not have the same error you do when running the function between scanpy 1.3.7 and 1.4.0.

Just came across this - as we haven't heard back after the followup, and its been quite a while, we will close the issue for now, hopefully you obtained the expected behaviour in the end :)
Thanks for being a part of our community! :)


Unable to compile reth on Windows due to libmdbx compilation error

Describe the bug
When attempting to compile reth on Windows using the build command cargo install --locked --path bin/reth --bin reth, build fails with an error related to reth-mdbx-sys v0.12.1-0.
An attempt to compile libmdbx from source was made using the instructions from https://github.com/erthink/libmdbx/tree/master#windows. However, this resulted in an error indicating that GNU Make v3.81 or above is required, even though GNU Make version v4.3 was already installed. This was resolved by using CMake to build libmdbx.
Steps to reproduce
To reproduce the error when compiling reth on Windows, follow these steps:

Install Rust and Cargo, if they are not already installed
Clone reth repository using the command git clone https://github.com/paradigmxyz/reth
Navigate to reth directory using the command cd reth
Compile reth by running cargo install --locked --path bin/reth --bin reth
Wait for the compilation process to complete
Observe the error message while building the reth-mdbx-sys v0.12.1-0 library in crates/storage/libmdbx-rs/mdbx-sys directory:

error: failed to run custom build command for reth-mdbx-sys v0.12.1-0 (C:\node\reth\reth\crates\storage\libmdbx-rs\mdbx-sys)
Caused by:
process didn't exit successfully: C:\node\reth\reth\target\release\build\reth-mdbx-sys-0b550fc8e9d06992\build-script-build (exit code: 101)
--- stderr
thread 'main' panicked at 'called Result::unwrap() on an Err value: LexError { span: bytes(126..126) }', C:\Users\Administrator.cargo\registry\src\github.com-1ecc6299db9ec823\bindgen-0.61.0\codegen\mod.rs:4788:66
note: run with RUST_BACKTRACE=1 environment variable to display a backtrace
warning: build failed, waiting for other jobs to finish...
error: failed to compile reth v0.1.0 (C:\node\reth\reth\bin\reth), intermediate artifacts can be found at C:\node\reth\reth\target

To reproduce compiling libmdbx from https://github.com/erthink/libmdbx/tree/master#windows, follow these steps:

Clone repository using the command git clone https://github.com/erthink/libmdbx
Navigate to libmdbx directory using the command cd libmdbx
Compile libmdbx using make by running make all
Observe the error message

C:\node\libmdbx> make all
// The GNU Make 4.3
process_begin: CreateProcess(NULL, env bash -c "echo $BASH", ...) failed.
GNUmakefile:12: pipe: No error
process_begin: CreateProcess(NULL, printf %3s%3s%3s 4 3, ...) failed.
GNUmakefile:13: pipe: No such file or directory
process_begin: CreateProcess(NULL, expr "" < "  3 81", ...) failed.
GNUmakefile:14: pipe: No such file or directory
GNUmakefile:16: *** Please use GNU Make 3.81 or above.  Stop.

(GNU Make running on this system is v4.3, so this error is unexpected)

Now create a new folder called build in libmdbx root directory
Compile libmdbx using cmake by running "cmake --build . --target install".
Observe that libmdbx compiles successfully.

Additional notes:

Attempted to investigate further by looking at crates/storage/libmdbx-rs and mdbx-sys to see if I could update/modify anything there, but couldn't figure out how to resolve the issue.

It may be helpful to look into erigon - has a Makefile to build for Linux/macOS and a wmake file to build for Windows using cmake, make, and mingw to build MDBX tools (https://github.com/ledgerwatch/erigon#windows).

rust: v1.69.0

OS: windows 10

Node logs
No response
Platform(s)
Windows (x86)
What version/commit are you on?
No response
Code of Conduct

[X] I agree to follow the Code of Conduct

We fixed Windows compilation a couple of days ago. If you still have issues, please explain what happens now as it is probably just a docs issue.


Very early work on git/github documentation. Refs #5

I just wanted to put this up quickly so that we have some initial structure to work with. Since we need this urgently, can we please get it reviewed quickly in merged in (assuming the reviews are ok).

@Prince-linux and @volsbit you are my reviewers here.

ok, if you approve I think we can merge.


Add Captcha Action support

https://aws.amazon.com/about-aws/whats-new/2021/11/aws-waf-captcha-support/

Fixed in v1.03


feat: added support for symbol overrides

Issue #60
Description of changes:

updated createInstance to take in an optional list of overrides
added updateInstance function to update overrides for existing Symbol Instances

Nested Symbol overrides are currently not supported
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

No worries. Thanks for looking at it!
I do have a fix now for .addLayer. Was going to put it in a different pull request, but it's probably better if I just merge it in with this one.

:tada: This PR is included in version 1.14.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


x/mobile: Unable to build xcframework with gomobile and Xcode 14

What version of Go are you using (go version)?

$ go version
go version go1.18.3 darwin/arm64

Does this issue reproduce with the latest release?
Yes
What operating system and processor architecture are you using (go env)?
go env Output
$ go env
GO111MODULE=""
GOARCH="arm64"
GOBIN=""
GOCACHE="/Users/darrarski/Library/Caches/go-build"
GOENV="/Users/darrarski/Library/Application Support/go/env"
GOEXE=""
GOEXPERIMENT=""
GOFLAGS=""
GOHOSTARCH="arm64"
GOHOSTOS="darwin"
GOINSECURE=""
GOMODCACHE="/Users/darrarski/.go/pkg/mod"
GONOPROXY=""
GONOSUMDB=""
GOOS="darwin"
GOPATH="/Users/darrarski/.go"
GOPRIVATE=""
GOPROXY="https://proxy.golang.org,direct"
GOROOT="/opt/homebrew/opt/go/libexec"
GOSUMDB="sum.golang.org"
GOTMPDIR=""
GOTOOLDIR="/opt/homebrew/opt/go/libexec/pkg/tool/darwin_arm64"
GOVCS=""
GOVERSION="go1.18.3"
GCCGO="gccgo"
AR="ar"
CC="clang"
CXX="clang++"
CGO_ENABLED="1"
GOMOD="/Users/darrarski/Dev/repo/go.mod"
GOWORK=""
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -arch arm64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -fdebug-prefix-map=/var/folders/bh/t75dvhh939lbvnsq6n60mgtr0000gn/T/go-build841782302=/tmp/go-build -gno-record-gcc-switches -fno-common"

What did you do?
I tried to build xcframework for iOS using Xcode 14 (14A5228q) developer tools with the following command:

$ gomobile bind -target ios gitlab.com/elixxir/client/bindings

What did you expect to see?
I expected the command to create xcframework. It works when I switch to Xcode 13.4.1 (13F100) developer tools.
What did you see instead?
When using Xcode 14 (14A5228q) developer tools, the command fails with the following error:

$ gomobile bind -target ios gitlab.com/elixxir/client/bindings
gomobile: ios/arm64: go build -buildmode=c-archive -o /var/folders/bh/t75dvhh939lbvnsq6n60mgtr0000gn/T/gomobile-work-1445876485/bindings-ios-arm64.a ./gobind failed: exit status 2
# runtime/cgo
cgo: C compiler "2022-06-09" not found: exec: "2022-06-09": executable file not found in $PATH

cgo: C compiler "2022-06-09"

I think gomobile picks up the C compiler from running xcrun --find clang, and that command on darwin/arm64 can sometimes contains bogus logging output starting with date. That probably confuses gomobile.
Could you try running that command again, maybe twice?
gomobile should probably be more resilient on that. Maybe it should only use stdout of xcrun, not stderr. cc @hyangah
@golang/ios

I plan to upgrade to Xcode 14 soon so that it may be possible for me to take a look.

I tried to run the command several times yesterday, but the result was always the same. I'm unfamiliar with golang, but the error message "exec: 2022-06-09 not found" seemed suspicious. I thought it could be some kind of parsing issue.
I'm not sure if the problem is caused by parsing the result of xcrun --find clang, which gives the following output:
with Xcode 13.4.1 (13F100):
$ xcrun --find clang
/Applications/Xcode-13.4.1.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/clang

with Xcode 14 (14A5228q):
$ xcrun --find clang
/Applications/Xcode-14.0.0-Beta.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/clang

However, I rerun the command today, and... it works! Still, I believe there is a bug hiding somewhere, as the problem was probably caused by the given date when the command was run (2022-06-09). Thankfully today (2022-06-10) it works fine :-)

I plan to upgrade to Xcode 14 soon so that it may be possible for me to take a look.

I'm afraid you'll need to go back in time to reproduce ;-)

On my mac M1 machine, it sometimes print messages like
2022-06-07 22:25:25.471 xcodebuild[8405:27734] Requested but did not find extension point with identifier Xcode.IDEKit.ExtensionSentinelHostApplications for extension Xcode.DebuggerFoundation.AppExtensionHosts.watchOS of plug-in com.apple.dt.IDEWatchSupportCore
2022-06-07 22:25:25.471 xcodebuild[8405:27734] Requested but did not find extension point with identifier Xcode.IDEKit.ExtensionPointIdentifierToBundleIdentifier for extension Xcode.DebuggerFoundation.AppExtensionToBundleIdentifierMap.watchOS of plug-in com.apple.dt.IDEWatchSupportCore

It doesn't always print that. In my experience it is more likely to print if it is the first time  to use such commands in a while. And the second and subsequent runs just behave normally, without the extra output.

I have also experienced this issue with the following messages:
admin@maci7-03.ms-eu-dublin.ci.devel:~ % xcrun --find clang
2022-09-07 14:27:45.757 xcodebuild[6265:9851879] Requested but did not find extension point with identifier Xcode.IDEKit.ExtensionSentinelHostApplications for extension Xcode.DebuggerFoundation.AppExtensionHosts.watchOS of plug-in com.apple.dt.IDEWatchSupportCore
2022-09-07 14:27:45.757 xcodebuild[6265:9851879] Requested but did not find extension point with identifier Xcode.IDEKit.ExtensionPointIdentifierToBundleIdentifier for extension Xcode.DebuggerFoundation.AppExtensionToBundleIdentifierMap.watchOS of plug-in com.apple.dt.IDEWatchSupportCore
2022-09-07 14:27:45.813 xcodebuild[6265:9851879] XType: com.apple.fonts is not accessible.
2022-09-07 14:27:45.813 xcodebuild[6265:9851879] XType: XTFontStaticRegistry is enabled.
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/clang

These warnings appear to be included in stdout instead of stderr, and hence they affect how the path is parsed.
I have currently no idea how to fix those warnings.
A proper fix would probably involve parsing and matching all lines with a regex.

Based on my tests this appears to only happen on the first try:
Last login: Wed Sep  7 09:14:57 2022 from <IP_ADDRESS>
 % xcrun --find clang
2022-09-07 14:50:13.907 xcodebuild[69942:386823822] Requested but did not find extension point with identifier Xcode.IDEKit.ExtensionSentinelHostApplications for extension Xcode.DebuggerFoundation.AppExtensionHosts.watchOS of plug-in com.apple.dt.IDEWatchSupportCore
2022-09-07 14:50:13.908 xcodebuild[69942:386823822] Requested but did not find extension point with identifier Xcode.IDEKit.ExtensionPointIdentifierToBundleIdentifier for extension Xcode.DebuggerFoundation.AppExtensionToBundleIdentifierMap.watchOS of plug-in com.apple.dt.IDEWatchSupportCore
2022-09-07 14:50:14.041 xcodebuild[69942:386823822] XType: com.apple.fonts is not accessible.
2022-09-07 14:50:14.041 xcodebuild[69942:386823822] XType: XTFontStaticRegistry is enabled.
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/clang
 % xcrun --find clang
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/clang
 % xcrun --find clang
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/clang
 % xcrun --find clang
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/clang

According to this discussion: https://developer.apple.com/forums/thread/703233
The fix is:

Remove CommandLineTools
sudo rm -rf /Library/Developer/CommandLineTools

Reinstall CommandLineTools
xcode-select --install

Select CommandLineTools
sudo xcode-select -s /Library/Developer/CommandLineTools

But I tried reinstalling Command Line Tools or installing newer than 13.3.1 - in my case 13.4 - and the message is still there.
Honestly some input validation could be added to envClang.

Small update from my side:
Not sure what changed, but now I'm able to run gomobile bind with the following configuration:

go version go1.17.13 darwin/arm64
Xcode 14.0 Build version 14A309

No more "cgo: C compiler" errors occurs when running gomobile bind. It binds successfully, however, the produced xcframework is not usable. When trying to build iOS or macOS application that uses the framework, I get this error:
Undefined symbols for architecture arm64:
  "_objc_msgSend$initWithObject:", referenced from:
      -[RefTracker assignRefnumAndIncRefcount:] in Bindings(000007.o)
  "_objc_msgSend$setObject:forKeyedSubscript:", referenced from:
      -[RefTracker assignRefnumAndIncRefcount:] in Bindings(000007.o)
  "_objc_msgSend$intValue", referenced from:
  ...

I truncated it because it just lists all functions and methods that gomobile exposes from go to Objective-C.
When creating the same xcframework with Xcode 13.4.1, everything works fine, without any issues.

@darrarski please do not close this, this is a valid issue I'm fixing in:

https://github.com/golang/mobile/pull/84

@darrarski please do not close this, this is a valid issue I'm fixing in:

https://github.com/golang/mobile/pull/84

Oh, OK, sorry for that. Will keep an eye on the progress, but like I said - it works now for me with latest Xcode and gomobile. Thanks a lot for all your precious time and effort!

We're hitting a variation of this issue as well:
# runtime/cgo
cgo: C compiler "Warning:" not found: exec: "Warning:": executable file not found in $PATH
runtime/cgo
runtime/cgo
# runtime/cgo
cgo: C compiler "Warning:" not found: exec: "Warning:": executable file not found in $PATH
# runtime/cgo
cgo: C compiler "Warning:" not found: exec: "Warning:": executable file not found in $PATH
gomobile: iossimulator/arm64: go build -v -trimpath -buildmode=c-archive -o /var/folders/06/554jgqx57blcwbchmjmkts600000gn/T/gomobile-work-2147008467/mobileNebula-iossimulator-arm64.a ./gobind failed: exit status 1

make: *** [MobileNebula.xcframework] Error 1

We were able to stop the warnings in the meantime with:
unexport SWIFT_DEBUG_INFORMATION_VERSION
unexport SWIFT_DEBUG_INFORMATION_FORMAT

We believe these environment variables are set by Xcode.
The warnings are emitted when running gomobile with the environment variables set, and no flags:
❯ SWIFT_DEBUG_INFORMATION_VERSION="hi john" gomobile >/dev/null
Warning: unknown environment variable SWIFT_DEBUG_INFORMATION_VERSION
Gomobile is a tool for building and running mobile apps written in Go.

...snip...

This comes from xcrun:
❯ SWIFT_DEBUG_INFORMATION_VERSION="hi john" xcrun --find clang
Warning: unknown environment variable SWIFT_DEBUG_INFORMATION_VERSION
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/clang

The fix in https://github.com/golang/mobile/pull/84 looks like it would solve our problem.

I don' think anyone cares. I've submitted a fix for this 2 years ago and nobody has even reviewed it:

https://github.com/golang/mobile/pull/84

We just apply a patch to this tool at build time through Nix, because this will probably never get merged:
https://github.com/status-im/status-mobile/blob/cfd30e0d2401bd61a519eba5d9f467b23120f721/nix/overlay.nix#L68-L71

@jakubgs

These warnings appear to be included in stdout instead of stderr, and hence they affect how the path is parsed.

How did you check this? What was the result of xcrun --find clang > /tmp/out; cat /tmp/out?

In my testing (see shell output above where I redirect stdout), xcrun emits these warning to stderr, yet they interfere with the build anyway.

In my own testing, xcrun appears to print warnings to stderr, yet they interfere with the gomobile build anyway:
❯ SWIFT_DEBUG_INFORMATION_VERSION="hi john" xcrun --find clang >/dev/null
Warning: unknown environment variable SWIFT_DEBUG_INFORMATION_VERSION
``

❯ SWIFT_DEBUG_INFORMATION_VERSION="hi john" xcrun --find clang >/dev/null

I cannot distinguish whether xcrun output that warning or not from the command... What was the result of xcrun --find clang > /tmp/out; cat /tmp/out?

@hajimehoshi >/dev/null redirects stdout to /dev/null. That means the only thing printed is stderr.

I do not have this issue:
gomobile: ios/arm64: go build -buildmode=c-archive -o /var/folders/bh/t75dvhh939lbvnsq6n60mgtr0000gn/T/gomobile-work-1445876485/bindings-ios-arm64.a ./gobind failed: exit status 2
# runtime/cgo
cgo: C compiler "2022-06-09" not found: exec: "2022-06-09": executable file not found in $PATH

I have a related issue, per my original comment https://github.com/golang/go/issues/53316#issuecomment-2407626810 which is also fixed by the linked PR.

https://go-review.googlesource.com/c/mobile/+/432657/comment/571d2b9a_3519aa82/
My intuition is that just replacing CombinedOutput with Output should fix the issue instead of adding a filtering function, so I would like to check whether the warning was really output to stdout, not stderr @jakubgs

@hajimehoshi I apologize - I did not read the linked PR and I see the confusion now. I agree that replacing CombinedOutput with Output is a much cleaner fix for my issue.
@jakubgs will need to test the command you suggested, as I cannot reproduce the messages he is seeing.

I think that depends on Xcode version and other factors.
jakubgs@macm1-01.ih-eu-mda1.ci.devel:~ % SWIFT_DEBUG_INFORMATION_VERSION="hi john" xcrun --find clang >/dev/null
Warning: unknown environment variable SWIFT_DEBUG_INFORMATION_VERSION
jakubgs@macm1-01.ih-eu-mda1.ci.devel:~ % SWIFT_DEBUG_INFORMATION_VERSION="hi john" xcrun --find clang
Warning: unknown environment variable SWIFT_DEBUG_INFORMATION_VERSION
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/clang

You cannot expect Apple to be consistent. My fix is still necessary I think, as Apple is a garbage company.

@jakubgs So would it be possible to reproduce the debug message 2022-09-07 14:27:45.757 xcodebuild[6265:9851879] Requested but did not find extension point with identifier Xcode.IDEKit.ExtensionSentinelHostApplications for extension Xcode.DebuggerFoundation.AppExtensionHosts.watchOS of plug-in com.apple.dt.IDEWatchSupportCore ... output to stdout, not stderr?

As I said, it's xcode version dependent.

So we can no longer know the debug message was really output to stdout, not stderr.
I'm very skeptical about this (the debug message was output to stdout). We should go with replacing CombinedOutput with Output instead of a filtering function in your CL.

The issue is clear. We had this problem, which is why we applied the patch which has fixed the issue:
https://github.com/status-im/status-mobile/blob/cfd30e0d2401bd61a519eba5d9f467b23120f721/nix/overlay.nix#L68-L71
You can see the error we got here:
cgo: C compiler "2022-09-07" not found: exec: "2022-09-07": executable file not found in $PATH

And the details in the issue and in the PR:

https://github.com/status-im/status-mobile/issues/13949
https://github.com/status-im/status-mobile/pull/13975

As we can see Apple is garbage and their tools spew nonsense into stdout. This has happened in the past and will happen again in the future. If you refuse to fix this then that's your problem. We use Nix so we can patch this ourselves without problems, but others might not be as lucky.

It does. We fixed it with the patch I've linked.  Have fun maintaining software this way.

It does.

But we cannot reproduce that, right?

You can, just get an older Xcode version.

 Have fun maintaining software this way.

I'm just pointing out that you might be misunderstanding. From the comments https://github.com/golang/go/issues/53316#issuecomment-1239392434 and https://github.com/golang/go/issues/53316#issuecomment-1239398184, the stdout and stderr seemed to be mixed so we cannot say the debug message was really output to stdout.
I'm fine to help you if we go with replacing CombinedOutput with Output. If you don't want, I'll make my CL to close this issue.

I have no interest not time to reproduce this for you. As I said, we patched it thanks to Nix being amazing.
The issue is real and will show up again, whether with older or newer combinations of Xcode and OSX. I would not close it if I were you, but you do you.

Sure, I'll do :-)


Group Levels of Detail not working in 3.5.stable

Hey,
first of all, thank you for this addon.
Sadly for me it won't group the LOD 2 and 3.
Please see the Screenshot attached, I think because the grouping does not work, it won't load the LOD 2 and 3, because it will not notice them.

Also I am not sure if this is supposed to happen, but I cannot toggle the visibility of the nodes, but this is maybe because of the grouping, or not grouping.
I am getting this output when I hit the checkbox:
LOD Manager created 100 new knots. -> This is great.
Set group_levels_of_detail
Set group_levels_of_detail
LOD Manager created 0 new knots. -> This is sad.
Set group_levels_of_detail
Set group_levels_of_detail
LOD Manager created 0 new knots. -> This also.
Set group_levels_of_detail
Set group_levels_of_detail
I started with a fresh project and only downloaded Chunking and LOD from the assetlib, would be great if you could help me in any way, otherwise my fallout clone would be pretty lame lol.
Greetings

A fellow fallout fan🤓; it is an honour to be of service.
So, the problem is likely in the naming scheme. The way the plugin groups nodes is by matching their prefixes.
For example if we had Chunk001-lod1, and you pressed the group button, it would search for any node with the name "Chunk001" that is followed by suffix -lodN i.e. Chunk001-lod2 and Chunk001-lod3.
What I notice is that unless you have 3100 nodes/chunks in your sceen, your node name is not the same throuought the suffixes.  If my guess is right, you have 100 nodes/chunks in your scene, and you haven't removed the 1, 2, 3 from your initial mesh name. In summary, Your LOD_3001-lod3 should actually be LOD_001-lod3; your LOD_2001-lod2 should be LOD_001-lod2; finally, your LOD_1001-lod1 should be LOD_001-lod1.
Let me know if this resolves the issue. ✌✌✌

Thank you for your reply, when I do it the right way, "it just works".
Your guess was absolutly right. I have created 100 nodes with each having 3 LOD.
So there is no issue left and this can be closed :)
One thing: Would you recommend creating the collisons in blender by duping the planes adding -col to the name and make it a child of the duped parent ? (sorry if this is unclear, the shortcuts would be shift+d for duping and set parent to object with strg+p, after selecting child and parent, in the main window). Thats how I did it for now.
Greetings :)

I never tried exporting collisions from blender to godot; did not even know it was possible. I would check if all the Collision nodes point to the same mesh. If so then I reccomend it.
While we are on topic of optimization, there is rarely a need to put collisions on level 2 and 3. Rarely will there be a need for actual physics simulation somewhere where the player can barely see it. Better just make a "guess" to what the simulation ammounted to when loading the chunk.


Unlovely behaviour with set_table_name

Heyya,
we have a problem (that we solved with a workaround now) with this gem. We use set_table_name in all our models to set the Table_name. So we added a Tag and Taggings model to set that table_name via:
module ActsAsTaggableOn
class Tag < ::ActiveRecord::Base
set_table_name ActiveRecord::Base.table_name_prefix+"eo_tags"
Fine. The Problem is that it didn't work for some of our models. It comes down to a loading-Problem with rails, the below attached method eager_load sort's the load_path in alphabetical order and then loads the models...resulting in our Model with "acts_as_taggable" being loaded BEFORE the overwritten Tag & Taggings models are loaded..so that, long story short: The set_table_name is ignored...and the following SQL got executed against the Database which led to problems:
ActiveRecord::StatementInvalid: ActiveRecord::JDBCError: DB2 SQL error: SQLCODE: -206, SQLSTATE: 42703, SQLERRMC: DB2XC20.TAGGINGS.TAGGER_ID: SELECT DB2XC20.eo_taggings.id AS t0_r0, DB2XC20.eo_taggings.tag_id AS t0_r1, DB2XC20.eo_taggings.taggable_id AS t0_r2, DB2XC20.eo_taggings.tagger_id AS t0_r3, DB2XC20.eo_taggings.tagger_type AS t0_r4, DB2XC20.eo_taggings.taggable_type AS t0_r5, DB2XC20.eo_taggings.context AS t0_r6, DB2XC20.eo_taggings.created_at AS t0_r7, DB2XC20.eo_tags.id AS t1_r0, DB2XC20.eo_tags.name AS t1_r1 FROM DB2XC20.eo_taggings LEFT OUTER JOIN DB2XC20.eo_tags ON DB2XC20.eo_tags.id = DB2XC20.eo_taggings.tag_id WHERE (DB2XC20.eo_taggings.taggable_id = 399 AND DB2XC20.eo_taggings.taggable_type = 'AbstractDocumentTemplate' AND (DB2XC20.taggings.tagger_id IS NULL AND DB2XC20.taggings.context = 'tags'))
The (dirty) solution for us was now taking care that the overwritten tag & taggings are loaded before the model acting as taggable.
Ok, so far..maybe that prevents a headache for a fellow coder stumbling upon this problem.
Ahh...here the snippet that takes care of the rails models beeing loaded in Alphabetical order:
the method eager_load! in railties-3.0.9\lib\rails\engine.rb loads the model in Alphabetical order.
def eager_load!
config.eager_load_paths.each do |load_path|
matcher = /\A#{Regexp.escape(load_path)}/(.).rb\Z/
Dir.glob("#{load_path}/**/.rb").sort.each do |file|
require 'pp'
Cheers,
Rubén

what is your suggestion?


fix: Fix entity display bn

Organizations with updated business numbers had the old business number displaying on the entity details page.
This change fixes the functionality to display the latest business number.

Resolves: https://github.com/bcgov/orgbook-bc-client/issues/175

@WadeBarnes — good to get this one out. Not sure what you need from other to do that.
Thanks @wadeking98 !

I've got it.  Will deploy tomorrow morning.

LGTM — didn’t run it to test. Not sure why the translate.ts change is in this. Is it related?

that's just from code linting. I ran the linter to format the code and it cleaned things up in a few other files


Fixes Skubsuit

The hat for the skubsuit has a broken icon/sprite. It's fixed now.

We must start an investigations team to find the root cause of how this could happen. I expect the incident report by friday.

Someone sabotaged it, it was working fine when I pr'd it.

The problem here is that i forgot to put the parent and a path in the sprite component on the skub hat prototype.
The actual fix should be this:
- type: entity
  parent: HatBase                 #new
  id: HatSkub
  name: Skub Hat
  description: 'Best paired with the Skub Suit.'
  components:
  - type: Sprite
    sprite: Clothing/Head/skubhead.rsi       #new
  - type: Icon
    sprite: Clothing/Head/skubhead.rsi
  - type: Clothing
    sprite: Clothing/Head/skubhead.rsi

I'm very disappointed you attempted to sabotage skub Abraham. I thought I could trust you...


Add producer retry limit.

Retrying publish indefinitely can cause a memory issues if more and more and more messages are waiting to be published while the connection is down.
By setting producerMaxRetries in the configuration, you can now limit the number of publish retries before throwing the exception, so in case of a fluke or a momentary disconnection the message will be retried and sent, but in case of a longer downtime the memory of the application won't explode if there are too many messages trying to be published.
If setting a retry limit, the application should know how to handle failed publish errors by itself.
The consumer doesn't have this problem, so we can continue retry reconnecting indefinitely.

@ramhr seems like CI times out.


aarch64: Fix corrupted IRQ state when tracing enabled

The call to sys_trace_idle() is potentially clobbering x0 resulting in a
wrong value being used by the following code. Save and restore x0 before
and after the call to sys_trace_idle() to avoid any issue.
Signed-off-by: Carlo Caione<EMAIL_ADDRESS>Suggested-by: James Harris<EMAIL_ADDRESS>

Tagging the reporter @jharris-intel


Var names shadowing in Chrome debugger

Fixes https://github.com/nuxt/nuxt.js/issues/7731 :)
Just renamed a variable in a small block so that another variable in the parent block don't shadow eachother in the Chrome debugger.
Types of changes

[x] Bug fix (a non-breaking change which fixes an issue)
[ ] New feature (a non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly. (PR: #)
[ ] I have added tests to cover my changes (if not applicable, please state why)
[x] All new and existing tests are passing.

Codecov Report

Merging #7939 into dev will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##              dev    #7939   +/-   ##
=======================================
  Coverage   68.92%   68.92%
=======================================
  Files          91       91
  Lines        3846     3846
  Branches     1041     1041
=======================================
  Hits         2651     2651
  Misses        971      971
  Partials      224      224

Flag
Coverage Δ

#unittests
68.92% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5e9d759...7995947. Read the comment docs.


add versioning script

What(What have you changed/added/removed?)

add versioning script

Why(Why did you change/add/remove it?)

make it easy to create tags

Codecov Report

Merging #6 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master       #6   +/-   ##
=======================================
  Coverage   56.17%   56.17%
=======================================
  Files           2        2
  Lines         162      162
=======================================
  Hits           91       91
  Misses         56       56
  Partials       15       15

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0e392c5...08891ad. Read the comment docs.


dom-idable relies on removed this._rootNodeID

In React 0.13, this._rootNodeID was removed. This causes things like text-fields to fail since they use the dom-idable mixin.

dom-idable has updated to use the following: this._reactInternalInstance._rootNodeID
Its worked for the docs site so far. Where are you still experiencing errors with this update?

the css-in-js branch still uses it

I've just updated css-in-js, thanks for bringing this up!


feat: add progress bar to the lower jaw

Checklist:

[x] I have read freeCodeCamp's contribution guidelines.
[x] My pull request has a descriptive title (not a vague title like Update index.md)
[x] My pull request targets the main branch of freeCodeCamp.
[x] I have tested these changes either locally on my machine, or GitPod.

Related to #46178

Thanks for working on this feature, @Ismailtlem.
I think @JordanMooree based on this comment. I am mentioning him here so you could work on this feature together if you wish.
Notes:
It would be great if you could isolate the progress bar that is used in the modal so it only receives a couple of props and renders a progress bar. That way we code would more modular.

Hi @JordanMooree
Yes, please go ahead.
I will write the progress and issues I faced here asap

Hi,

The first problem I had here is how to get the challenges data to get the percentage on the progress bar. I get the challenges data of each block from this component https://github.com/freeCodeCamp/freeCodeCamp/blob/main/client/src/templates/Introduction/components/challenges.tsx by storing it on local storage and  then getting it on https://github.com/freeCodeCamp/freeCodeCamp/blob/main/client/src/templates/Challenges/classic/lower-jaw.tsx. It works if you get to the challenges block first and then access a project. There is still an edge case where we have an issue : if you clear cache and directly access a step directly by its link. There must be some way to lift this data up and then get it back on the lower jaw component I guess or some better way
There is the test that needs to be fixed.
I can make the progress bar into a separate component

I might be mistaken, but doesn't the logic that works in the completion modal to show percentages also work here?
In that case, you would not need to re create the logic.
Turning the completion modal's progress bar into its own component and passing it to the modal and the editor lower jaw should do that trick.
let me know if that makes sense.

Hi @ahmadabdolsaheb sorry for my late answer.
I think I understood what you said, but the logic of the percentage shown on the progress bar is in the completion modal body which is not rendered in the new editor. Shouldn't we recreate the logic of the percentage shown on the progress bar ?

Anything inside the progress-bar-wrap should be extracted into its own component so it would receive a couple of props and display the progress bar animation.  That way we could use the new component in the modal and pass it to the lower jaw in the editor. If you need more clarification, contact me through chat so we can hop on a call.

Anything inside the progress-bar-wrap should be extracted into its own component so it would receive a couple of props and display the progress bar animation.

@ahmadabdolsaheb Are you looking for a similar animation like done in the Legacy RWD?

@JordanMooree yes.

Hi,
I think I am getting close. I have a progress bar displaying the percentage of the completed challenges. There is still some work to do on the code.

We need to add the animation on the progress bar to show the percentage gradually like in the legacy certification. Since the code responsible for the shown percentage will be the same I guess in the new editor, we should maybe put it somewhere and import it in the new editor and in the legacy challenges.
We still need to fix the linting errors
I am not sure if the naming "blockCompletedPercent" of the completed percentage on the lower jaw component is good enough since the name "completedPercent" was already used for the legacy challenges.

Thank you for the hard work. It is definitely coming together.
Here are a few things to do before this PR is finalized:

The progress bar should show up after the tests has passed.
The animation related logic should be relocated inside the progress bar.
The completion modal’s progress bar should be replaced with the new progress bar.
Remove disabled eslint rules
Passing around blockCompletedPercent and  setAttemptedInNewEditor should be avoided.
The percentage calculations should be relocated to ‘Show’ and passed to Multifile-editor and lower jaw
Write tests using cypress.

Note:
This is out of the scope for this pr, but we need to move the percentage and percentage calculations to redux, so it could be accessed from the multifile-editorandlower jaw` and the donation-saga ( for opening the block donation modals)
Also the graphql query should be optimized so we don’t filter after receiving the data.

Hi @ahmadabdolsaheb
I went through the points you mentioned. Let me know if I missed something.
There is still a warning raised by CodeFactor we need to fix (conflicts with what eslint suggests).

Thank you @Ismailtlem for refactoring the components and adding the progress bar to the lowerjaw. The pull request looks almost ready for a merge.
Here are my thoughts:

If we are only using the current block Ids to calculate the completedPercent, you should query currentBlockIds as high up the component hierarchy, calculate completedPercent, and pass completedPercent props to children.  That would simplify the flow of information. If show is the parent component for two of the consumers of the completedPercent, let's calculate completedPercent there once and pass it to MultifileEditor and completion-modal.
Avoid styling components in JS. You could style components based on their parents, or add a default style with a conditional className.
The timeout in get in the cypress test should be fine as it the test proceeds as soon as the element is found, but I am not sure about the completion-modal-body one. I would appreciate it if you could rewrite the completion-modal-body test to avoid slowing down the CI.
Some es-lint rules are disabled in theshow component. It would be great if you could modify the components to follow es-lint rules if possible.

Thanks for the review @moT01 and the feedback.

Some campers may be confused what the progress bar is for. I suppose they should pick up on it pretty quick - but we show the block name in the completion modal to denote what it's for. Here we just show the percent. I'm fine with that - just mentioning it.

That is a valid point. Maybe we should mention "Course" in that line somewhere to prevent confusion for now.

Depending on where I am scrolled to, the lower jaw is sometimes off screen. This is probably cause I was copy/pasting solutions - we could scroll to that area when the tests pass? Maybe another discussion/PR.

That is also a good point. Once we turn Help and Restart buttons into icons, we could explore having those buttons and the progress bar in the same row in an attempt to make the lower jaw shorter.

^ These last two things made me wonder why we don't just use the completion modal for these @ahmadabdolsaheb? It would unify some of the experience. We already have it ready, and it isn't any more clicks to get to the next step.
Having everything in the lower jaw is an attempt to lower the friction, but I don't have any hard data yet.

General note:
The progress bar that close to the button make it look like a button. Once this pr is ready to merge, I will go in and change the styles slightly to prevent confusion.

I see a lot of tests failing here so I put the waiting update label back on here. Let us know when you are ready for another round of reviews @Ismailtlem 👍

I also think it would be best if we add the percentage completed to the end of the congrats message using sr-only text since it is dynamically added content that screen users might be interested in knowing as well (without having to traverse the DOM to find it). In addition, I think we can get rid of the special keyboard instructions for screen readers we are currently adding to the end of the congrats message. Screen reader users don't need to hear it over and over again.
Would it be OK if I pushed these changes to lower-jaw.tsx?

Hi,

I removed the disabled es-lint rules in the show component'
Replaced the inline style
Fixed the completion modal body test
Added the course name on top of the progress bar. Let me know @ahmadabdolsaheb if that's ok or you want to change that

I'll continue on the other points

Thanks @Ismailtlem. Once you are done, I will go in and play with the styles and see what to do with the course name.

'Depending on where I am scrolled to, the lower jaw is sometimes off screen '

Can someone provide a screenshot of this ? @moT01
I don't know how to reproduce it

Hi @ahmadabdolsaheb
'If we are only using the current block Ids to calculate the completedPercent, you should query currentBlockIds as high up the component hierarchy, calculate completedPercent, and pass completedPercent props to children. That would simplify the flow of information. If show is the parent component for two of the consumers of the completedPercent, let's calculate completedPercent there once and pass it to MultifileEditor and completion-modal.'

Is it not the case that the completedPercent is calculated in the show component ?

'Depending on where I am scrolled to, the lower jaw is sometimes off screen '
Can someone provide a screenshot of this ? @moT01
I don't know how to reproduce it

You probably don't need to do anything about that here @Ismailtlem. To reproduce, just scroll the lower jaw off the screen and use the hotkeys to run the tests. You will pass the step, but can't really tell because the lower jaw is not on the screen. I would probably save this for another PR. I suppose the solution would be to auto scroll that into view.

Commits here got a bit messy, maybe we should make some cleaner pr once the review is finished

Commits here got a bit messy, maybe I can make some cleaner pr once the review is finished

Do not worry about it, we squash commits on merge – meaning as long as the changes on the files tab is what you want, you are good.

Made the order as the following : Congrats message, Progress Bar, Submit button, Other buttons (reset). There might be some additional fixes to do
A bit stuck in how to make the foreground text appear in the progress bar, looks easy but I don't know what I am missing. Any idea ?
Will investigate the issue you raised @moT01 when I have some free time and let you know

@Ismailtlem, let me know when you have addressed the issues that Tom has raised.
I will get in and sort out the styles.

Hi,
Sorry for my late replies on this PR.
Corrected the first issue raised by @moT01 regarding the incorrect frontend project total numbers. We had to get the currentBlockIds in the places where <CompletionModal /> was used. The rules-of-hooks is disabled because react doesn't allow using hooks in class component. I guess there is a better solution than this one, maybe refactoring those class component into functional components but we can do it in another PR.
There is still some styling to fix here.

Hi,
Sorry for my late replies on this PR.
Corrected the first issue raised by @moT01 regarding the incorrect frontend project total numbers. We had to get the currentBlockIds in the places where <CompletionModal /> was used. The rules-of-hooks is disabled because react doesn't allow using hooks in class component. I guess there is a better solution than this one, maybe refactoring those class component into functional components but we can do it in another PR.
There is still some styling to fix here.

What are the issues that you came across?

We are officially on Node.js 18 now. We have changed the merge requirements accordingly.
You will need to rebase this PR against the main branch OR Click the "Update branch" button to get the new checks going.
Thanks for your contribution.

We are officially on Node.js 18 now. We have changed the merge requirements accordingly.
You will need to rebase this PR against the main branch OR Click the "Update branch" button to get the new checks going.
Thanks for your contribution.

The issue I had @ahmadabdolsaheb was the progress bar foreground style, but I made a fix

@mot01, I finally got some time to review this pr.
There are two main queries that are used to calculate the progress percentage:

One used in the Show components which pulls up the related challenge info
Another previously used in completion-modal (now used in the show components) which pulls up all challenges data.

There is some room for optimization here:

The second query should be kept close to the progress-bar so it only pulls the data when necessary.
Use dynamic queries to pull only the related data on the second query
Since the some current challenge data (first query) are needed to calculate the percentages, we should pass them downward to where the second query is executed.
A progress bar wrapper component could be used to receive the data from the first query, run the second query, calculate percentage, and pass it to the progress-bar component.

Other to dos:

styles need to be adjusted for the progress bar so it is optimized for the modal and lower jaw.

If this sounds good to you, I could proceed with the modifications.

It turned out the progress bar could be an isolated component and would not need to receive any props from its parent.
Since the challengeMetaSelector provides all challenge related data, progress-bar component could query for the currentBlockIds and calculate completedPercent.
Here is the example: #49110
The main issue is that allowBlockDonationRequests in completion modal needs to know the completedPercent in order pop the block donation modal.

@moT01 could you give this another round of reviews.
We could tackle the following optimizations in upcoming prs:

rewire allowBlockDonationRequests
create a progressbar wrapper that pulls challenge data from challengeMetaSelector and handles all progressbar logic.

When I complete a challenge in the multifile editor, screen readers don't mention the block. e.g. "Learn HTML by Building a Cat Photo App, 10% complete" - it just says "10% complete". We maybe want to add that for screen readers.

I think I was the one who suggested we announce only the percentage to screen reader users instead of announcing both course name and percentage. The reasoning being that hearing the course name every time is probably unnecessary because the user knows what course they are in, and so it just becomes tedious repetition.

@Ismailtlem, could you address Tom's concern and any failing tests if possible.

I am pushing the query data to redux so we could pull them from anywhere.

Hello @moT01 ,
Please review this pull request, so that upcoming features like share button to build below the progress bar, for those it won't become blockers

@BalanaguYashwanth, we don't need a project manager, especially one that ask people to look at something at their weekend.
Thank you for your excitement, and your every feedback on issue and PR so far.

This pr should go in right after https://github.com/freeCodeCamp/freeCodeCamp/pull/49381.

@Ismailtlem Sorry, for the inconvinence. I have opened a new pr in your name with the required changes to add the rest of the progress bar #50167 .


Do not try to use invalid network config

Even if zedagent detects invalid network config and reports DPC with error, NIM may still try to use it, run connection tests and overwrite the error with another or even with nil.
Instead, NIM should skip mgmt ports with invalid config and preserve the error (incl. across reboots).
Similarly, DPC reconciler should not try to apply invalid config into the network stack.
Additionally, diag was extended to report when port config is not valid.
Lastly, readability of some parsing error messages was improved.

Is this a bug fix which needs to be backported to stable releases?

Is this a bug fix which needs to be backported to stable releases?

Yes, I added the stable label.


Update ClassLoaderFixer to v2

Today I released ClassLoaderFixer 2. Most changes here are not really necessary, but I still applied some of them to be consistent :)
By the way, this exact same class also works for every version up to 1.4.5 - so feel free to incorporate it in every version up until then.
At least public static String FIXER_VERSION = "2"; would be important to add everywhere to tell Block Helper to shut up (otherwise it warns the user everytime that he needs a proper RelaunchClassLoader implementation - even though it is indeed fine)

Most changes here are not really necessary, but I still applied some of them to be consistent

Thanks for the contribution.
I'm currently working on a possible v2 of Fabricated-Legacy-Forge, if I'm successful with the rewrite I'll include it in v2 directly.

Perfect, thank you very much and good luck! :)
Let me know if you need something!


UI bugging when I middle clicked a link

Describe the bug
When opening a page with middle click the entire UI bug and it's nearly impossible to read.
Seems to be only on firefox because when using chrome I do not have any problems.
But I may be dumb.
To Reproduce
Open any tab of 42intra in firefox with middle click
Expected behavior
The UI to work correctly and be readable when opening with middle click
Screenshots
Jut click :

With middle click :

Desktop information (please complete the following information):

Browser Firefox
OS Ubuntu 20.04 LTS

(PS : I'm not very smart so maybe so it's caused by something I've got (for example i have the Dark Reader extension but it's deactivate on the intra so i don't know))
(PS1 : I'm french don't judge my writing)

I've also experienced this issue on the same OS and browser, seems to be something with Improved Intra indeed. A quick reload fixes this issue, but a long-term solution would be nice at some point. I will look into this


prefix comparision instructions with vm(#160)

The destination of Integer/FP comparison instructions is mask
register, so modify related instructions with vm prefixed.
Signed-off-by: Weiwei Wang<EMAIL_ADDRESS>

There is no vs2 operand to the vid.v instruction, so this change is incorrect.
Thanks for the #160 fix, but please separate independent fixes into separate pull requests.
I will merge this patch then undo the vid.v change.


Add PMTiles

href: URL to the .pmtiles "file"
type: What's a good media type?
rel: pmtiles
What other metadata might be useful to specify in the link for visualization purposes?

In the OL example tileSize is set
MapLibre has quite a number of options set: type and encoding in the source, source-layer, type and paint in the layer

@bdon

type: if you mean MIME type, Chris has been using application/vnd.pmtiles like here
layers: for vector this requires reading the JSON metadata
type: can be either raster or vector, can be read by reading the binary header (first 127 bytes)

The other useful data is the bounds, center and zoom level, which you can use to "fit" the map to the right area

Thanks @bdon, that was fast :-)

type: Great, will use that. Ideally it would be mentioned somewhere in the PMTiles folder.
layers: Yes, I thought more if people want to select a specific one.
type: Good pointer, then I'll read the header.
bounds/center/zoom level should ideally be implied by the STAC metadata.

What other metadata might be useful to specify in the link for visualization purposes?

In the OL example tileSize is set
MapLibre has quite a number of options set: type and encoding in the source, source-layer, type and paint in the layer

If not provided, do they all have resonable defaults or can be read from the PMTiles metadata? Then I'd just use the defaults or read from metadata, but if any of that is required from the implementor we should provide an option via STAC metadata so that visualizations/maps can be generated automatically.

Thanks, PRs are up #18 and in OL STAC: https://github.com/m-mohr/ol-stac/pull/4


speech_commands: Range cannot be empty (low >= high) unless no samples are taken

I'm using the speech_commands example and trying to load my own set of wav files, which I've organized according to the tutorial. Here's the command I'm entering on the terminal:
python3 /Users/etc/train.py
--data_url=
--data_dir=/Users/etc/trial_classes
--wanted_words=randomclass1,randomclass2
--sample_rate=44100
It's finding the files (so I've truncated the filepaths with "etc" below & above), but raises this error:
Traceback (most recent call last):
File "/Users/etc/speech_commands/train.py", line 508, in
tf.compat.v1.app.run(main=main, argv=[sys.argv[0]] + unparsed)
File "/usr/local/lib/python3.7/site-packages/tensorflow_core/python/platform/app.py", line 40, in run
_run(main=main, argv=argv, flags_parser=_parse_flags_tolerate_undef)
File "/usr/local/lib/python3.7/site-packages/absl/app.py", line 299, in run
_run_main(main, args)
File "/usr/local/lib/python3.7/site-packages/absl/app.py", line 250, in _run_main
sys.exit(main(argv))
File "/Users/etc/speech_commands/train.py", line 237, in main
FLAGS.background_volume, time_shift_samples, 'training', sess)
File "/Users/etc/speech_commands/input_data.py", line 575, in get_data
background_index = np.random.randint(len(self.background_data))
File "mtrand.pyx", line 992, in mtrand.RandomState.randint
ValueError: Range cannot be empty (low >= high) unless no samples are taken
I'm using
MacOs 10.13.6
Tensorflow version 2.0.0
Python version: 3.7.3
New to this so I appreciate the patience if I've done something dumb. Thanks!

Okay figured this out. The background_noise folder has to be included in the directory alongside the folders with the wav files. On further reading I probably could have assumed this from reading the tutorial, but maybe worth clarifying in the paragraph on "Custom Training Data." (Here's the tutorial I'm referring to: https://github.com/tensorflow/docs/blob/master/site/en/r1/tutorials/sequences/audio_recognition.md).


user_identity_field

add user_identity_field for refresh token

yes, off course

A question here: it will support further the default provider Gesdinet\JWTRefreshTokenBundle\Security\Provider\RefreshTokenProvider, because now i have a problem on method Gesdinet\JWTRefreshTokenBundle\Security\Provider::loadUserByUsername($username) due having a custom user provider configured, (security.yaml):
    providers:
        app:
            entity:
                class: App\Entity\User
                property: email

and in method if i don't have a custom provider set, i receive the default User, and throw exception further in Lexik\Bundle\JWTAuthenticationBundle\Services\JWTManager::create(UserInterface $user) method.
Error:
"Neither the property \"email\" nor one of the methods \"getEmail()\", \"email()\", \"isEmail()\", \"hasEmail()\", \"__get()\" exist and have public access in class \"Symfony\\Component\\Security\\Core\\User\\User\"."

A question here: it will support further the default provider Gesdinet\JWTRefreshTokenBundle\Security\Provider\RefreshTokenProvider, because now i have a problem on method Gesdinet\JWTRefreshTokenBundle\Security\Provider::loadUserByUsername($username) due having a custom user provider configured, (security.yaml):
providers:
    app:
        entity:
            class: App\Entity\User
            property: email

and in method if i don't have a custom provider set, i receive the default User, and throw exception further in Lexik\Bundle\JWTAuthenticationBundle\Services\JWTManager::create(UserInterface $user) method.
Error:
"Neither the property "email" nor one of the methods "getEmail()", "email()", "isEmail()", "hasEmail()", "__get()" exist and have public access in class "Symfony\Component\Security\Core\User\User"."

try to checkout in this branch and tests it, I think it should be work. Don't forget about  README
You can change user identity field. Make sure that your model user has getter for this field. Default value is username. You can change this value by adding this line to your config.yml file:

gesdinet_jwt_refresh_token:
    user_identity_field: email

Very useful feature. What about merge this PR? Any obstacles?

Merged, and released as minor. Thank you!

@shubaivan Actually, i tested with the description that is on top, and don't work. Same problem. The problem is that Gesdinet\JWTRefreshTokenBundle\Security\Provider\RefreshTokenProvider if no custom provider set, by default returns Symfony\Component\Security\Core\User\User object and in the LexikJWTAuthenticationBundle in Lexik\Bundle\JWTAuthenticationBundle\Services throws the exception.
Maybe i don't understand something. What for is this user_identity_field configuration?


Vastly optimize video decoding performance of high-res (4K) files

Eliminate sws_scaler where possible (MF will do scaling on GPU)
Use Platform::ArrayReference to avoid unneccessary copy
Copy sws_scaler output in one operation (contiguous buffer)

See discussion in #202. With this patch, I am able to software decode 4K HEVC files 100% smooth, which were previously absolutely unplayable. Even 4K Hi10P files play well. Performance for HD videos has also improved (lower CPU usage).

Looks good.

Looks good but apparently yuvj420 and yuv420 store levels differently. Adding videoProperties->Properties->Insert(MF_MT_VIDEO_NOMINAL_RANGE, (uint32)MFNominalRange_0_255); prevents clipping in the highlights and shadows when the decoder output is yuvj420.
Another thing non related to these changes but I noticed while testing a yuvj420 file is that the colors seem a bit different when using MF video decoding (h264) compared to VLC. Did you notice anything similar ?

Thanks for the hint with the levels! I originally compared my output with MPC-HC and found no difference in levels so I thought they were correct. But it looks like MPC-HC also does not treat levels correctly. Only when comparing with other video apps now, I saw that levels are really off. I updated the PR as you said, this fixes the levels. The old solutio with sws_scaler also had the levels wrong, looks like it does not update the levels when changing pix format.
And yes I also noticed already that colors are slightly off for HEVC files! Can h264 files have YUVJ as well? I only saw that pix format on HEVC files. To me it looks like green is slightly oversaturated while red is slightly undersaturated. Not sure where this comes from. Tried playing with MF_MT_YUV_MATRIX but it did not have any effect.

After checking the colors again with the levels fixed, I do not see much of a difference anymore. There is still a very slight difference, but it is even hard to tell what the difference is. I was not able to get rid of it, and did not find any help on google. For me, the difference is too small right now to further look into this, but feel free to open an issue if it is a problem for you.


Added Hugging Face demo application.

https://github.com/rwightman/pytorch-image-models/issues/1646#issuecomment-1414474225

@kadirnar thanks, but will have a model exploration space at some point that will be kept up to date with timm


Add go-infra tool to manage our branches

It's complicated to add release branches (and other types of branches). I wrote a doc about how to manage a release branch fork, and it splits into three ways to handle it based on the situation, and in some cases, shows bash scripts to copy-paste and modify to get through some situations: https://github.com/microsoft/go/tree/microsoft/main/eng/doc/branches.
We should have a tool that helps determine which state we're in and runs through the steps.

Related, we could really use a better way than manual work to get infra fixes onto our existing release branches, so we can reliably maintain each one properly once they're set up:

https://github.com/microsoft/go/issues/145

New branch creation doc is now here: https://github.com/microsoft/go-infra/blob/main/docs/release-process/new-release-branch.md
After the move to submodules, it's vastly simplified. 🎉
We could still write a tool or pipeline to do it for us. We want to make it easy to do sometime after (perhaps just after) upstream releases rc1, because that's when upstream forks their new release branch.

When a new version of Go comes up, we update https://github.com/microsoft/go/blob/microsoft/main/eng/_util/cmd/updatelinktable/updatelinktable.go to add the new branch and prune the old one.
That tool generates the table in https://github.com/microsoft/go/blob/microsoft/main/eng/doc/Downloads.md.
But now we have:

A copy of the table in https://eng.ms/docs/more/languages-at-microsoft/go/articles/overview
A JSON file that contains the info: https://github.com/microsoft/go/issues/939. It's updated automatically by updatelinktable, but I think we should upload it to blob storage and point an aka.ms link at it.

A pipeline could help us with that.
The pipeline could also seed the internal mirror with the upstream commit, to avoid this issue:

https://github.com/microsoft/go/issues/859


Internacionalization

Hi Leonardo,
Do you have a plan to provide support for other languages?
In Brazil, many young F1 fans know English, but old school ones, like my father, does not. I could help with a Brazilian Portuguese (why not European Portuguese also) translation, if you decide to pursue this development path.
Cheers and go go go Perez!!
:P
Rafael

Just a small comment.
; )

Então cara
I had already the idea to translate it, just did not had feeling for it yet :D
But translations PR's are more than welcome for sure, I think it is important Portuguese, Spanish and Dutch, most of the content really comes from F1 TV api I think we only have 10 ~ 15 strings to translate

Oi Leonardo!
I agree that some translations will be good. But indeed, now using the software for more than a week, it is not hard to use it even for someone who does not know English.
Abraço!


#21 MOVE Exprter_CSV methods to IExporter

FIX #21

Improvements of code base

Codecov Report

Merging #30 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #30   +/-   ##
=======================================
  Coverage   88.88%   88.88%
=======================================
  Files           8        8
  Lines         189      189
=======================================
  Hits          168      168
  Misses         21       21

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 31a77bc...0841ea1. Read the comment docs.


Pass plugin config as environment variables

This makes it possible for a plugin to retrieve its config values
through environment variables when it's invoked.
For example, assuming a command foo in a given plugin. When the
configuration file contains the bar config for the foo section,
it will be passed to it as the DCOS_FOO_BAR environment variable.

@mesosphere-ci run integration tests


Disallow self-LGTMs

As https://github.com/opencontainers/project-template/pull/13
is merged, change pullapprove accordingly.
Signed-off-by: Qiang Huang<EMAIL_ADDRESS>

LGTM

LGTM


[2] Cleanup advanced modal styles, convert mobile logic to styles in schema form

Reviewer: @rcorral

Could we remove this margin

Is it just me or are these fonts much smaller than they should be?

Fonts haven't changed

I'll remove the  margins

Margin removed

going from advanced install -> review config the heights are different

This is done: https://github.com/dcos/dcos-ui/pull/77#issuecomment-216704061

Rebased with new build process


Setting profile in Edge

Is there a way to use the default profile or some other profile with Edge? The .setProfile syntax or .addArgument don't seem to work and slenium keeps generating a temporary profile.

Hello there. I'm having the same issue.
This works very nice in VBA and Selenium Basic with Chrome:
Driver.SetProfile "C:\Users\UserNameHere\AppData\Local\Google\Chrome\User Data"
Driver.Start
Driver.Get ("https://www.google.com/")
but not with MS Edge:
Driver.SetProfile "C:\Users\UserNameHere\AppData\Local\Microsoft\Edge\User Data\Default"
Driver.Start
Driver.Get ("https://www.google.com/")
Has anyone solved this?. Thanks!


Mobile Web Safari - Keyboard Visible Overscroll - Fix

Address unusual behaviour found at ...

Details

Fixed Issues

$ GH_LINK
Tests

QA Steps

Tested On

[ ] Web
[ ] Mobile Web
[ ] Desktop
[ ] iOS
[ ] Android

Screenshots

Web

Mobile Web

Desktop

iOS

Android

@sidferreira What you've got so far looks good. I think to resolve the other issue @kidroca pointed out, we might need to just disable scrolling events on the ReportActionCompose component?

@roryabraham Although my initial suggestion was about disabling the scroll browser-wise, my tests were in the ReportActionCompose. I'm just trying to reproduce @kidroca issue, but I think we may have it addressed now.

I don't think we can do anything to get rid of the 2nd scrollbar
It was pointed out earlier that one of the scrolls is actually "outside" the browser
So we have one scroll from the FlatList and one to accommodate the shrinkage caused by showing the keyboard
When we swipe inside the FlatList it drags report actions up and down
But anything outside of the FlatList would be dragging the whole window
Something else that I've noticed is the keyboard size might vary

word suggestion is enabled
or when a custom keyboard app is used

@kidroca but this dual scrollbars was happening before anyways, right?

@roryabraham I think there's a workaround that would resize the app to fit in the available viewport space. It may get squished but will avoid the double scroll...

Hmm I actually only saw the 2 two scrollbars on the Simulator
On the Safari (Chrome as well) on my iPhone I don't see a scroll bar at all when I'm scrolling through the conversation
And a single scrollbar when I scroll with the Keyboard open, but it's for the whole window

iOS 15.1

@kidroca you mean after the scroll fix?

@kidroca you mean after the scroll fix?

I'm not sure, I used staging.new.expensify.com (did the fix make it there?), but I think it was that way even before the fix

@roryabraham I checked and the double scrollbar was an issue even before the scrollback, so I would like to consider it "out of scope"

@pecanoro https://github.com/Expensify/App/issues/6621 can you try to reproduce the issue in this branch?

@kidroca can you retry the issue you had with different languages/keyboards?

@kidroca @parasharrajat @pecanoro @roryabraham I couldn't reproduce most issues, but did slight changes that should address them. Can anyone help me with the tests?

@roryabraham @parasharrajat @Gonals Could you guys see if the PR fixes the issue for mobile safari? I am having some issues with the mobile environment since I got the new M1 laptop so I can't test it out.

I can't test it, I am on IOS 14 but I will try.

@sidferreira I recently learned that it's possible on iOS 15 to move the address bar to the top of the screen on iOS Safari. I think that might be another edge case here.

@sidferreira Please add the issues link and description to the PR before we can test it. Thanks.

@sidferreira, I've set this as WIP (Work in Progress). Feel free to remove it when this is ready for review!

@roryabraham I decided to spend some extra time on this, trying to find a better solution, but I honestly think that there's no silver bullet.
I even checked Ionic Framework if they handled it somehow and they face the very same issue.
The whole problem is a difference between iPadOS and iOS: when the keyboard is shown in iPad, it will resize the window, allowing us to know the proper keyboard size. iOS in other hard doesn't do that. ( https://stackoverflow.com/a/66709611/251820 )
Although it modifies the visualViewport, it will do a parallax effect, in a way that it is not 100% reliable to use it as well.
As I work on this I notice that the efforts on Mobile Safari team is to make it the new Internet Explorer.
Long story short, I believe that the "Scrollback" is not a viable solution, and I'm not sure if there's any solution at all.
cc @parasharrajat

I've had difficulty keeping track of all the issues we have with our current implementation, can we summarize the issues we can observe with the scrollback implementation in mobile safari?

I agree, lets see what are the issues and what is the solution, and how is that not working? Then, we can decide what should be done.

@roryabraham @parasharrajat
The main/initial issue
On Mobile Safari, if the compose input is focused and you scroll down, a gap will show up below the app it self, keeping a ~100px white space below it.
The cause
After many research, we can mainly refer https://blog.opendigerati.com/the-eccentric-ways-of-ios-safari-with-the-keyboard-b5aa3f34228d to find out that this behavior is intended by Mobile Safari developers and no plans to change how it  works.
What happens is that instead of only resizing the viewport, Safari will add a "padding" at the bottom, causing a parallax effect when the content moves up.
The challenge
The challenge to fix it is that there's no way to be sure the size of the said padding, changing from device to device, as well as from keyboard type to keyboard type, as well as language, suggestions.
Also, there's the floating address bar, which there's no information browser wise the size of it, if it is positioned on bottom or top, etc.
Long story short, there's no silver bullet to get the keyboard size. I tried a few workarounds but most of them weren't that effective.
The final note is that it happens in many other platforms, for example Ionic Framework.

Thanks for the explanation @sidferreira. If we can't fix this then I think it better would revert the original PR.


Intel CAVS25: Failure in tests/boards/intel_adsp/smoke sporadically

Describe the bug
On intel_adsp_cavs25 platform, tests/boards/intel_adsp/smoke failed.
This case has a one in ten chance of failure.
Bisect result: Can’t find the exact commit.
Please also mention any information which could help others to understand
the problem you're facing:

intel_adsp_cavs25
tests/boards/intel_adsp/smoke failed.

To Reproduce
Steps to reproduce the behavior:

twister -W --hardware-map /home/ztest/cavs/cavs.map --device-testing -x=CONFIG_BOOT_DELAY=500 -T tests/boards/intel_adsp/smoke/ --no-skipped-report -vv
see error

Logs and console output
START - test_2nd_cpu_halt
halt/restart core 1...
halt/restart core 2...
Assertion failed at WEST_TOPDIR/zephyr/tests/boards/intel_adsp/smoke/src/cpus.c:167: halt_and_restart: (alive_flag is true)
cpu didn't halt
FAIL - test_2nd_cpu_halt in 0.251 seconds

Environment (please complete the following information):

OS: Linux
Toolchain - SDK 15.0

This is an interesting one. Firstly, I could reproduce it, but the ratio wasn't anything like 1 in 10. From around 500 runs, I got the error 2 times. That in itself is curious. Secondly, I couldn't reproduce it using previous SDK (0.14.2), which is a hint for why this hadn't appeared before. Finally, I think I have fix, but I'm not sure I can explain it completely. Will send a PR soon.

Hi @shuai1x, could you please check if my draft PR https://github.com/zephyrproject-rtos/zephyr/pull/49877 fixes this issue for you? If it does, I'll make it a proper PR.

Hi @shuai1x, could you please check if my draft PR #49877 fixes this issue for you? If it does, I'll make it a proper PR.

Ok, will reply to you soon.

Hi @shuai1x, could you please check if my draft PR #49877 fixes this issue for you? If it does, I'll make it a proper PR.

Hi, I have checked your draft PR, and it can't fix this issue. And I have also tested 500 times, it would fail 6 times.

Oh, that's a bummer. Just to clarify, did it at least make it less likely? On the original report, it is mentioned 1 in 10, but more likely 1 in 100 with my draft PR. So, did it become less likely, or no influence at all?

Oh, that's a bummer. Just to clarify, did it at least make it less likely? On the original report, it is mentioned 1 in 10, but more likely 1 in 100 with my draft PR. So, did it become less likely, or no influence at all?

I think I need to test it again to compare the results of these two tests. And will reply to you soon.

Oh, that's a bummer. Just to clarify, did it at least make it less likely? On the original report, it is mentioned 1 in 10, but more likely 1 in 100 with my draft PR. So, did it become less likely, or no influence at all?

I did the test again. And I wonder whether the failure is random. Because before I tested it, it would fail 1 in 10, but this test I ran 100 times, and failed 27, which seems 3 in 10. And after using your draft PR, it would pass 5 in 100. So it seems your PR make it become less.

Thanks for the input, I'm finalizing a patch here that should truly solve the issue, stay tuned =D

Ok, so I updated my draft PR - I think it solves this issue. Even if it doesn't, it still fix some code issues. @shuai1x could you check, please?

Ok, so I updated my draft PR - I think it solves this issue. Even if it doesn't, it still fix some code issues. @shuai1x could you check it, please?

Ok, will reply to you soon.


Tgc key config fix

Fixes #9. Added properties from cas.properties in jasig/cas/cas-server-webapp to /etc/cas.properties. Also updated log4j.xml and deployerConfigContext.xml to reference the current location of the Slf4j audit trail class.

Great, thanks. You should probably get rid of the fork next.


Cleanup Reference Manual

Fix Source Code Highlighting
Upgrade Maven docbkx Plugin
Fix PDF

Follow up: #558.


Update

added support for config flow
readd the discord webhook (kinda)

Thanks for the merge request, nice to see this getting some attention,
It seems you've changed a lot, and restructured the whole package, I'll endevour to give it a look over soon

Now it should contain all the previous funtionalities


[envtest]Use database helpers from mariadb-operator

This is necessary to remove a dependency cycle from lib-common

/hold wait for the deps

/unhold

/test manila-operator-build-deploy-tempest
 Removing debug pod ...
error: unable to create the debug pod "oko-06-qk5pt-master-2-debug"
make: *** [Makefile:421: crc_storage] Error 1
+ n=3
+ ((  n >= retries  ))
+ echo 'Failed to run '\''make crc_storage'\'' target. Aborting'
Failed to run 'make crc_storage' target. Aborting
+ exit 1


Investigate replacing the ReadableStream polyfill

Rather than having to maintain a ReadableStream polyfill in the PDF.js library, it would be much better to use an existing library/package.
Especially since our ReadableStream polyfill has never, as far as I can tell, been updated and given that it's taken directly from the reference implementation (i.e. it may not be as efficient as it could be).
The following one could be a good candidate (the author seem to be involved in the Streams Standard itself): https://github.com/MattiasBuelens/web-streams-polyfill (available through npm as well), since it seems to be regularly updated/maintained.

Additional information: Compared to the recently replaced URL polyfill, in this case there's also one line in the .eslintignore file which should be removed when this issue is fixed: https://github.com/mozilla/pdf.js/blob/e91836f8324e368743d05d5c305f999f37332f70/.eslintignore#L10


[Python APIView] long type hints seem to be cut off in APIVIew

https://apiview.dev/Assemblies/Review/184ae332996d41b6a067f5300dcb9d9c#azure.communication.jobrouter.RouterAdministrationClient

cc @sarkar-rajarshi

The issue does not have to do with type hints as the code here is using Python-2 type hints (which APIView ignores) and the type annotations are coming from the docstrings. There is a known limitation in APIView that type annotations cannot span more than two lines, and that is why they are being cut off.
The solution is to update the code type hints to use Python 3 annotations instead of Python 2.
Closing as this behavior is "by design".


Async OrganizationServiceContext ?

Hi, does OrganizationServiceContext support async LINQ queries or is that planned?

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: f5debe4e-24e5-358d-342b-1be662e42ede
Version Independent ID: fcc82cd2-79a5-ea5a-2090-2e104be1cdad
Content: Use OrganizationServiceContext (Microsoft Dataverse) - Power Apps
Content Source: powerapps-docs/developer/data-platform/org-service/organizationservicecontext.md
Service: powerapps
Sub-service: dataverse-developer
GitHub Login: @kkanakas
Microsoft Alias: kartikka

Thanks for your comment, @altman-medline. This issue has been assigned to the doc author for review.


Revert "Remove LaunchScreen.xib from project."

Reverts NativeScript/ios-runtime#390
Description: Restore LaunchScreen.xib and UILaunchStoryboardName plist key due to scalling issues. I will continue investigating the issue mentioned in https://github.com/NativeScript/ios-runtime/pull/390.

@dtopuzov and I agreed that the correct way to handle this is to add the proper launch screen images to the hello-world template instead of applying this revert.


The difference between _hoodie_record_key and _row_key？

When creates an RT view, there are two primary key fields? What is the difference between them?

_row_key is the data source field mapping to hudi generation _hoodie_record_key

yes. to add, all merges/compaction etc happens based on _hoodie_record_key once its extracted out from the incoming data

yes. to add, all merges/compaction etc happens based on _hoodie_record_key once its extracted out from the incoming data

ok thanks


Use persistent RESTClientGetter in CLI

This changes the RESTClientGetter to one which caches the underlying
clients after first initialization.
This reduces memory usage for all commands, with observed reductions
from ~4MiB for helm get all, to ~10MiB for helm install (using
https://github.com/stefanprodan/podinfo).
For charts which make use of Custom Resource Definitions, this is
likely even higher as the client will not be initialized twice (one
time for the installation process of the CRDs, the second time for the
actual installation of the chart).
Follow up on #11886

Converting this to a draft as it will cause issues when charts are for example creating Custom Resource Definitions on demand during install (for example OPA Gatekeeper) while later attempting to make use of them in a post-install hook.
As Helm does not clear the REST mapper between individual action steps (e.g. after pre-install and before post-install hooks), it does not "see" the new Custom Resource Definitions and the installation will fail.


docs: better detail the differences between database_uri and state_backend_uri

Inspired by this user in slack https://meltano.slack.com/archives/CMN8HELB0/p1670018797957179 we should explain in context of the database_uri why you would/wouldn't need to touch the state_backend_uri.

Still relevant


code linting readability, use smaller length variables for UDOCKER_USE_xxx_EXECUTABLE

suggest to use variable names like
UDOCKER_xxx_EXEC
need also to update all documentation

won't implement,
breaks backward compat


Logger - Check logger.info and logger.debug, see what needs to become logger.debug and change those

The removal of some Logger.info should help to reduce the log clutter and speed the game a bit.

Ok, first discovery: logger.debug messages do NOT show up at the log window.

Have to do my own function for that, here we go.

Ok, did not need to use my function, but probably will at the future.


Optional TLS and issuing certificates on main server

In order to decrease usage of Lets Encrypt I moved issuing process (ansible) to main server (CC) and made it optional.

:+1: Ship it!


Import broken with scikit-learn>=0.22

The Imputer class imported here:
https://github.com/combust/mleap/blob/beb4fd248e020282f10778c91d68a3518e981dcb/python/mleap/sklearn/extensions/data.py#L24
Was removed in scikit-learn version 0.22 as mentioned here:
https://github.com/scikit-learn/scikit-learn/blob/ee328faa3601b40944ad43e28bce71860d39f2de/sklearn/preprocessing/imputation.py#L60

At the moment, we have scikit-learn pinned to < 0.20, we would need to upgrade the scikit-learn version to get this working. Happy to work with you on doing this if you'd like!

I'm working in an environment where I need scikit-learn>=0.22 and I get the error importing Imputer from the preprocessing.data module which I believe is the same. I 'hacked' a fix, namely I edited the mleap/sklearn/preprocessing/data.py file to have:
from sklearn.preprocessing import StandardScaler, MinMaxScaler, Binarizer, PolynomialFeatures
from sklearn.impute import SimpleImputer as Imputer

instead of the previous line importing Imputer. Does anyone know if this is likely to lead to trouble down the line?
Also, as an aside, as @ancasarb mentioned scikit is pinned to < 0.20, it would be useful if this was stated on the 'Getting Started with Sklearn' Documentation page.


Huffmunch decompression incorrect.

The huffmunch decompression routine produces incorrect results under cpu6502.
https://github.com/bbbradsmith/huffmunch
The related project is located at:
https://github.com/cdoty/9918-Adventures/tree/main/HBC-56

Check out my pull requests. I've fixed a number of bugs that could be related.

I tested your project with my latest build of the HBC-56 emulator. I got some output: https://youtu.be/S2CR4j3f-ew
Is this expected?  It did seem to freeze at the end.

@cdoty Also tested on the real hardware and it seems to be the same now. So, I'd say my pull request fixes should fix the issues you're seeing in my emulator.
9918 Adventures - HBC-56 - Running on real hardware

Is this expected? It did seem to freeze at the end.

Yeah, it's a simple demo project that displays only graphics screens. That is the expected output.

The problem was the decompression routine generated incorrect data. The latest update fixes the problem.

Great. Thanks for trying it out, Charles.
It was quite strange, I submitted a new pull request yesterday for the broken BIT opcode. Then noticed the 1 Issue in this repo. Had a look and it was related to someone (you) using my HBC-56. I.. was... (pleasantly) surprised. Very cool. :D
I've had a couple of these pull requests for a while, so no sure if this repository is "active". At least the fixes are there if anyone else encounters issues with this repo (I might be the only one).  Or they can use my fork. shrug
This issue could be marked closed if the pull requests were accepted.

The debugger in the emulator was nice to use. It made it easy enough to see that the decompression routine wasn't generating the correct data.


Add Wii Theme

Wii Theme
Insert a link to the GitHub repository of the pack.
Checklist
Failure to complete this checklist or deleting boxes from the checklist will result in the closing of your pull request unless this is a pack update. Please write any comments regarding this checklist at the bottom of your pull request.
Check every box.

[x] I am the original author of this pack or have permission from the original author to make this pull request.
[x] All copyright of this pack's contents belong to the listed author or is cited in the description and repository linked above.
[x] This theme works properly on the latest versions of SteamOS for Steam Deck, decky-loader and SDH-AudioLoader.
[x] This pack is under 10MB in size and uses the least disk space possible.
[x] This pack is safe for work and does not contain any sexual, drug-related, or profane content.
[x] This pack does not contain loud, distorted, or otherwise bad faith sound files.
[x] This pack is only for either music or sounds and only adds or modifies the intended sound files.

I was actually working on an accompanying music pack using track 2 from the khinsider Wii Menu Gamerip album. The reason I made that sound the "launch game" sound rather than including it in the music pack is because it only plays once at the start and doesn't fit into a proper loop, unless the plugin has a way to have an intro track that transitions into a separate looping track.
I get what you mean about accuracy though, so I've changed the sound like you suggested.

Also here's the link to the Music Pack.

unless the plugin has a way to have an intro track that transitions into a separate looping track.

This is a great idea. I have created https://github.com/EMERALD0874/SDH-AudioLoader/issues/11 to help with this implementation.


Update nim to version 0.11.2

Please rename commit's name following our guide in CONTRIBUTING.md

@jagajaga like this?

Yes. Thank you!


Add a /more command.

This command allows you to give more of an item that is equipped in your hands. The syntax is /more

Thanks!