Unable to use Bootstrap-Vue DatePicker

I am trying to use the bootstrap-vue DatePicker as described here: https://bootstrap-vue.js.org/docs/components/form-input
The <b-form-input type:"date"> tag does not work as expected.

<b-form-input type="date">

<b-form-input id="date" v-model="immunization.date" type="date"></b-form-input>

Still not showing up with the datePicker UI components.

Does extra JS or CSS need to be added?

Not all browsers support all input types, ex Firefox desktop doesn't support date, datetime, or time. Maybe there is a culprit?

I've checked on both chrome, firefox and safari. All pages load when going to the bootstrap-vue form-input page. But, no luck when trying the same through the core-ui templates.
I started with the "Starter termplate" maybe there's something else I need to import somewhere? Otherwise, I didn't see any working examples on the live preview, no way to verify it's working elsewhere.

Unfortunately cannot reproduce.
Which version of coreui and bootstrap-vue do you have?

<EMAIL_ADDRESS>Not sure where to get the coreui version. From the starter template that I copied, it shows version 1.0.10 in the package.json. Is there somewhere else that I should be looking?
Again, maybe Vue_Starter doesn't have some required imports?

please find maintenance release v1.0.11 here:
https://github.com/mrholek/coreui-free-vue-admin-template/releases/tag/v1.0.11

Is there a documented upgrade process somewhere? Since coreui isn't an npm package, it's a lot of static files, right? What's the best way to go about upgrading?

Hi @ivandov
Migration from v1.0.10 to v1.0.11 should be straightforward since we changed only:

scss location
imports in App.vue
updated webpack scripts
dependencies in package.json

Use Vue_Starter v1.0.11 and copy views, routing and _nav from your own project
hope this helps
BTW there is v2 underway with awaited npm packages for CoreUI components. Stay tuned.


perlPackages.Dotenv: init at 0.002

Motivation for this change
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[ ] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[ ] Fits CONTRIBUTING.md.

@GrahamcOfBorg build perlPackages.Dotenv perldevelPackages.Dotenv

No! Curse you perl 5.32!

No! Curse you perl 5.32!

Pod::Parser was removed from perl 5.32, causing Pod::Coverage to fail.

@stigtsp I manage systems for perl developers and maintain infrastructure, but don`t (generally) write much/any myself. Any hints on where to go from here?

@stigtsp I manage systems for perl developers and maintain infrastructure, but don`t (generally) write much/any myself. Any hints on where to go from here?

Adding PodParser as a propagatedBuildInput for PodCoverage seems like the way to go.
When we bump the default perl to 5.32, Pod::Parser will dissappear from it's Module::CoreList. And misc checks in nix-generate-from-cpan (and likely cpan2nix) will start including it as a dependency for new and updated packages.

@stigtsp thanks for the explanation. Is that a PR you would be willing to file? If I had to fill out the "motivation" section on that PR I would have to say "Because @stigtsp said so, and it kinda makes sense to me..." :smile:

@stigtsp thanks for the explanation. Is that a PR you would be willing to file?

No prob - I'll have a look to see if there are other modules that need to be updated due to this change in 5.32.

The Pod::Parser issue is mentioned in the perl 5.32.0 bump https://github.com/NixOS/nixpkgs/pull/93036

@GrahamcOfBorg build perlPackages.Dotenv perldevelPackages.Dotenv

[..] build perlPackages.Dotenv perldevelPackages.Dotenv

Should mention that the PRs are against staging, and not merged yet. :)

@GrahamcOfBorg build perlPackages.Dotenv perldevelPackages.Dotenv

@aanderse As #93187 has made it's way to master, this now builds. :)

@GrahamcOfBorg build perlPackages.Dotenv perldevelPackages.Dotenv


feat(input): add icon support by slot

@qiang001  Can you describe the specific changes . and the unit test is failed by your change .


Remove semicolon following GLOBALS macro in the few commands that had one, as well as unneeded semicolons following one line cp functions

These cause a -Wextra-semi (if it is enabled) warning for every inclusion of globals.h, due to a double-semicolon following the structs for these commands' global variables. Remove the unnecessary semicolons.

Does this change actually accomplish anything?

...it would mean i have no chance of winning the pedantry award for 0.8.4 :-)

Commit f9acf3b2f179


Validate DNS Record Name

document

Draft PR made for DNS domain autocomplete feature: https://github.com/ministryofjustice/operations-engineering-dns-form/pull/51


refactor: useRouterService instead of Ember Router

My quick stab at / PoC for #255.
I've removed the custom Router and instead moved all the code into the RouterScrollService. That service is then eagerly initialized via an instance-initializer.
AFAICT this seems to work. Only the unit tests for router-scroll are failing, which only seems to happen, because they still expect the Router-based implementation.
But functionality-wise, this appears to be good so far (the demo works). 🤔
Left To Do

make the router-scroll test pass
clean up
update docs
decide on whether we want to do a major release or add backwards compatibility so that we deprecate only, like with locations/router-scroll.js
probably wait for https://github.com/ember-app-scheduler/ember-app-scheduler/pull/773 / https://github.com/ember-app-scheduler/ember-app-scheduler/issues/772

Thanks @buschtoens!
You have probably already thought of this but it would require a major bump I believe.  If someone is using the current /addon/index as the base class for their router.js class,
Example
// router.js
class Router extends RouterScroll {
  generate() {
    const url = super.generate(...arguments);
    return url.replace(this.rootURL, '/');
  }
}

Moving everything behind the scenes makes complete sense.  I'm 👍  for this!

Does not necessarily require a major bump at first. You can keep the RouterScroll class, but make it empty and in the constructor throw a deprecation warning to remove it. Only a major for removing the class then.

Yeah exactly. :)
That's what I was referring to with "adding backwards compatibility".

I wouldn't be opposed to just removing the RouterScroll class and doing a major bump with the service.  I'm not sure I see a benefit of keeping both around?  Perhaps you do?

Hey friends, I just tried this PR to work around the single inheritance problem that you run into when using @embroider/router, and it seems to work just fine! 😍
Hope this can land sooner than later! :wink:

I'm very much in favor of this PR.  I think we can go the major bump route and rm the router-scroll class


change variable name kMult to riskBias

The variable which in papers and in the documentation is called "Risk Bias" currently has a variable name kMult. Throughout the NSC and Coupled VAE library this variable needs to be renamed riskBias

Made this change in nsc_tf.


API Revert DataObject::validate to 3.1 method signature (protected)

The changes made in https://github.com/silverstripe/silverstripe-framework/pull/2729 were not fully semver compliant, so make this accessible with a doValidate method for now (until 4.0 when we can make validate properly public).

Also merge https://github.com/silverstripe/silverstripe-cms/pull/1215

We're watering down an API (both validate() and doValidate() public methods in 4.0) in order to comply to semver? That seems like the wrong approach.

I'd really like for these to be public, we have had lots of issues this week with the fact that they are not :\

The validate() method was already protected; We can't water it down, it's already watered. It's wet. I know we don't like this, but we can't break our commitment to semver on that basis alone.
doValidate can be deprecated in 4.0 (Deprecation::notice('5.0', 'Use validate() instead');).

The other alternative is to override __call to expose the method, but that has other issues (discoverability, code completion, documentation, etc).

The validate() method was already protected

So this change to public hasn't been in a stable release yet, right? I thought it was already in place for 3.1, hence my strong reaction. I'm still not very happy about introducing temporary APIs just to deprecate them again in the next major release, but that seems to be preferable to layering on more __call() magic to the already have DataObject class. Can you raise a PR for the deprecation notice in 4.0?

Sure, but I'll need to merge this first.

See https://github.com/silverstripe/silverstripe-framework/pull/4294


scripts: pylib: twister: twisterlib: environment: Probable incorrect check of device_testing argument

Note these two checks in environment.py, which are supposed to act as an early check for errors in twister call.
https://github.com/zephyrproject-rtos/zephyr/blob/c3dc01ddf3a5bdd599af08657a2052c57e0a093f/scripts/pylib/twister/twisterlib/environment.py#L732-L738
While the checks seem sensible, they conflict with the standard parser definition of the add_parse_arguments(). Here we have a definition of device-testing:
https://github.com/zephyrproject-rtos/zephyr/blob/c3dc01ddf3a5bdd599af08657a2052c57e0a093f/scripts/pylib/twister/twisterlib/environment.py#L141-L144
We can see that it uses store_true. This makes the variable have either True or False value. It cannot be None without further interference. Thus, in most cases, those previously mentioned if blocks will never be entered.
However, a simple change of device-testing is None to not device-testing is probably not sufficient. Here we have a definition of device-flash-timeout:
https://github.com/zephyrproject-rtos/zephyr/blob/c3dc01ddf3a5bdd599af08657a2052c57e0a093f/scripts/pylib/twister/twisterlib/environment.py#L171-L173
Thanks to that, we know that were that simple change to happen, we would force a typical twister user to have either --device-testing or --device-flash-timeout=0 as arguments. It would not be advisable, as specifying an argument regarding a device without using a device is, at best, counter-intuitive.

@LukaszMrugala please look at #60061


( Feature ) Wrap the BSCScan API into this

Is there any possibility to wrap the BSCScan API here?
It can do many useful things involving transactions.

With my last commit ,programmers can implement this api so too easy way .

Great news...
I'm using a simple RestTemplate to do this job now... it is a real pain.
My goal is to check if my user actualy sent the value to the wallet he said.
The system needs to confirm an user payment to another user.
So I'll take the last transactions from the user's wallet and check if the wallet of the receiver is there.
Yeah... my code is not so elegent but it is just a concept proof.


Get a Rust -> C++ FFI and C++ -> Rust FFI example working

We'll need to expose some configuration options for arguments to pass rustc. Overall still quite a bit to do for this, and more research to do.
From the horse's mouth: https://doc.rust-lang.org/book/ch19-01-unsafe-rust.html#using-extern-functions-to-call-external-code
See also: https://github.com/vkottler/yambs/issues/48.

Besides a technical example of one-off source files showing language interoperability, the larger question is how to get project and crate interoperability.
e.g. could a yambs project also exist as a Rust crate all in one?

We should see what this is all about, too: https://conan.io/
Maybe we could integrate with it?

We can put this aside until we have a legitimate need for FFI or package management outside of the GitHub + local source system we have now.


Fastload revamp experiment

Moving tables between postgress servers should be easy.
It didn't work when the two postgres instances had very different versions.
Now that they are the same, I'm trying a more conventional (and hopefully less problematic approach).  This is the master only side of the solution, with the master dumping the table to a file and saving it to s3.  And then only sending the s3 link to the client.  Once this is deployed in production, I can experiment with the local side.

👍


[WIP] check ascii_only first fix #9515

Description:
Implements functionality similar to esbuild charset=utf8
https://esbuild.github.io/api/#charset
In old engines like mujs, "\uD83C\uDF0F" is not supported. When ascii_only is false, "🌏" should be output.
BREAKING CHANGE:
This may cause the default behavior to change, but I don't know how widespread that will be.

Related issue (if exists):
https://github.com/swc-project/swc/issues/9515

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

ascii_only
<=es5
output

true
true
"\uD83C\uDF0F"

true
false
"\u{1F30F}"

false
true
"\uD83C\uDF0F"

false
false
"🌏"

if target <= EsVersion::Es5 {
        // https://mathiasbynens.be/notes/javascript-encoding#surrogate-formulae
        let h = ((c as u32 - 0x10000) / 0x400) + 0xd800;
        let l = (c as u32 - 0x10000) % 0x400 + 0xdc00;

        let _ = write!(buf, "\\u{:04X}\\u{:04X}", h, l);
    } else if ascii_only {
        let _ = write!(buf, "\\u{{{:04X}}}", c as u32);
    } else {
        buf.push(c);
    }
} else if ascii_only {
    let _ = write!(buf, "\\u{:04X}", c as u16);
} else {
    buf.push(c);
}

This pr will get the following output

ascii_only
<=es5
output

true
true
"\uD83C\uDF0F"

true
false
"\u{1F30F}"

false
true
"🌏"

false
false
"🌏"


React with Monorepo support

Hello there,
I have a couple of questions about installing this in a React project.
I couldn’t find any installation instructions specifically for React in the documentation. Could you please provide some guidance or a recipe on how to set it up in a React environment?
Is it possible to use this as an editor in one project while having the UI rendering in another, both located in the same folder and using shared components?
Thanks for your assistance!

Heya @ahmeetarif. There's nothing particularly special about how you might set that up.
If using turbo repo, you could have a setup like this:
apps
-- editor
-- render
packages
-- components
-- puck-config

The main thing you'll want to consider doing is splitting the config for editor and render so you don't include the editor fields to the render app.
i.e. render config
const config = {
  components: {
    HeadingBlock: {
      render: ({ title }) => <h1>{title}</h1>
    }
  }
}

and edit config
import renderConfig from "./render-config.ts";

const config = {
  components: {
    HeadingBlock: {
      ...renderConfig.components.HeadingBlock,
      fields: {
        title: { type: "text" }
      }
    }
  }
}


New Photon Voice update broke voice chat.

Title

I don't have control over what Photon does with their packages, can you tell me exactly what's broken?

If you update both of the packages it breaks voice chat, if you only update pun it just breaks multiplayer.

How does it break? Any errors or bugs specifically?

The local player works fine, but nothing else works.

Yep im having this issue, I thought it was just me being dumb but then i saw this.

i also cant hear people speaking

For me i can only see the player (My own not other people)

Are there any errors in the log?

Nope.

Interesting

How to fix it!
Requirements
A game with photon already installed
Put the old photon folder "Assets/Photon" into your new project, and bam!
Not the best method, but it works.

By the way, you need a one with the older photon and not the new photon.

Yea this was quite a obvious fix. I assumed that was known


DiscoveryMailbox mailnickname is not allowing more than 142 chars

[Enter feedback here]

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 9b8dcba0-fadb-5689-3b5b-18095e154ec8
Version Independent ID: e2df1bbb-0ae4-d4ca-5aa4-5f78523c0745
Content: You can't sync the SystemMailbox or DiscoveryMailboxSearch accounts by using the Azure Active Directory Sync tool - Active Directory
Content Source: support/azure/active-directory/unable-sync-system-discovery-mailbox.md
Service: active-directory
Sub-service: enterprise-users
GitHub Login: @genlin
Microsoft Alias: genli

@rabbanisyed, To resolve this issue quickly, I suggest you contact our support.


Update AWS account email address

The PR updates the AWS account email address

@mwoodson if you could review please.

/approve

/lgtm


Error when trying to use .original in slots

Here's the error:
api_1            | TypeError: Cannot use 'in' operator to search for 'original' in undefined
api_1            |     at Object.strict (/usr/src/app/node_modules/handlebars/lib/handlebars/runtime.js:74:17)
api_1            |     at Object.eval (eval at createFunctionContext (/usr/src/app/node_modules/handlebars/lib/handlebars/compiler/javascript-compiler.js:236:23), <anonymous>:3:64)
api_1            |     at main (/usr/src/app/node_modules/handlebars/lib/handlebars/runtime.js:152:32)
api_1            |     at ret (/usr/src/app/node_modules/handlebars/lib/handlebars/runtime.js:155:12)
api_1            |     at ret (/usr/src/app/node_modules/handlebars/lib/handlebars/compiler/compiler.js:513:21)
api_1            |     at compiledResponse (/usr/src/app/lib/services/agent/agent.converse-compile-response-templates.service.js:14:36)
api_1            |     at arrayMap (/usr/src/app/node_modules/lodash/lodash.js:639:23)
api_1            |     at Function.map (/usr/src/app/node_modules/lodash/lodash.js:9554:14)
api_1            |     at AgentService.map (/usr/src/app/lib/services/agent/agent.converse-compile-response-templates.service.js:7:29)
api_1            |     at AgentService.apply [as converseCompileResponseTemplates] (/usr/src/app/lib/services/agent.services.js:257:55)

Here is the conversation:

here is the export:
https://gist.github.com/wrathagom/90cc0446151554fc3d844c79ed430e9c

The slotName is date you are using slots.data... in the response
{
      "actionName": "Hours",
      "slots": [
        {
          "slotName": "date",
          "uiColor": "#009688",
          "keyword": "sys.duckling_time",
          "keywordId": 0,
          "isList": false,
          "isRequired": false,
          "textPrompts": []
        }
      ],
      "responses": [
        {
          "textResponse": "{{slots.data.original}} we are open from 11Am until 11PM.",
          "actions": []
        },
        {
          "textResponse": "We are open from 11AM until 11PM tomorrow.",
          "actions": []
        },
        {
          "textResponse": "We're open everyday from 11AM to 11PM.",
          "actions": []
        }
      ],
      "useWebhook": false,
      "usePostFormat": false,
      "creationDate": "1549420321000",
      "modificationDate": "1549421231000"
    }

Please let me know if that is the issue

Doh


merkle_block: add resource limit check during deserialization

Backport of #2607 to 0.31.x.

I believe this is the only backport that is needed. Prior to 0.31.0 we used Vec::consensus_decode rather than manually reading the length prefix, so we did have a length check there.

ASAN and clippy failures only looks like to me.
ACK 866781da1d3b4cfa3b3160b2ed97520559220f21


Mac OS X pre-commit sdist install error: SSL: CERTIFICATE_VERIFY_FAILED

https://github.com/shellcheck-py/shellcheck-py/blob/ae3b8cd7ccaea3015aafe053807c3578101585dc/setup.py#L46
This line will error for Mac users that installed a Python dist without certificates (e.g. the default dist included in Mac, or I guess the ones from python.org -- my colleagues run into this issue, I don't as I solely rely on pyenv which installs dists with certificates).
ref https://stackoverflow.com/a/42334357/5511061
Traceback:
pre-commit run --all-files
[INFO] Installing environment for https://github.com/shellcheck-py/shellcheck-py.
[INFO] Once installed this environment will be reused.
[INFO] This may take a few minutes...
An unexpected error has occurred: CalledProcessError: command: ('~/.cache/pre-commit/repo51cbjmy8/py_env-python3.8/bin/python', '-mpip', 'install', '.')
return code: 1
expected return code: 0
stdout:
    Processing ~/.cache/pre-commit/repo51cbjmy8
    Building wheels for collected packages: shellcheck-py
      Building wheel for shellcheck-py (setup.py): started
      Building wheel for shellcheck-py (setup.py): finished with status 'error'
      Running setup.py clean for shellcheck-py
    Failed to build shellcheck-py
    Installing collected packages: shellcheck-py
        Running setup.py install for shellcheck-py: started
        Running setup.py install for shellcheck-py: finished with status 'error'
stderr:
      ERROR: Command errored out with exit status 1:
       command: ~/.cache/pre-commit/repo51cbjmy8/py_env-python3.8/bin/python -u -c 'import sys, setuptools, tokenize; sys.argv[0] = '"'"'/private/var/folders/80/dtyyn_zn52q1vtp54kt28cvw0000gq/T/pip-req-build-7a501y08/setup.py'"'"'; __file__='"'"'/private/var/folders/80/dtyyn_zn52q1vtp54kt28cvw0000gq/T/pip-req-build-7a501y08/setup.py'"'"';f=getattr(tokenize, '"'"'open'"'"', open)(__file__);code=f.read().replace('"'"'\r\n'"'"', '"'"'\n'"'"');f.close();exec(compile(code, __file__, '"'"'exec'"'"'))' bdist_wheel -d /private/var/folders/80/dtyyn_zn52q1vtp54kt28cvw0000gq/T/pip-wheel-jhfsagpu
           cwd: /private/var/folders/80/dtyyn_zn52q1vtp54kt28cvw0000gq/T/pip-req-build-7a501y08/
      Complete output (4 lines):
      running bdist_wheel
      running build
      running fetch_binaries
      error: <urlopen error [SSL: CERTIFICATE_VERIFY_FAILED] certificate verify failed: unable to get local issuer certificate (_ssl.c:1108)>
      ----------------------------------------
      ERROR: Failed building wheel for shellcheck-py

I haven't been able to figure out why it falls back to sdist in the first place. Maybe a borked (older) pip version or something similar to https://issues.apache.org/jira/browse/ARROW-10744.

I suspect this isn't an issue with this package but with the python installation -- if you run the same urllib code outside of this package it'll also fail
There's usually a little script that ships with the python.org installers that updates the system ca certs using certifi -- run that and it should fix your installation

I got same problem today. Can anybody share a hint which script to run to fix the issue? Currently I'm in a pipenv environment and python version is 3.6.8.

Installing certificates in the virtualenv with the above snippets works for me. But only with python 3.8.11.


Update 2016-01-13-supported-bips.md

Add Bitcoin Core 0.12 because 0.11 does not support RBF.

Maybe it would be better to add that after since the current official version in 0.11?

An alternative would be to extend the table with another column and include the first version which supports it. Like https://github.com/bitcoin/bitcoin/blob/master/doc/bips.md

@MarcoFalke That's a great idea. Would you like to make a PR?

Sure, see #49


Handle root as a special file in generic-http repo

This is for MMENG-4193
The legacy approach of storing files downloaded via Indy generic http proxy was to reuse the path from remote server. However if there was root of the server requested (path = "/"), there seems to be no way to request that file from the generic-http hosted repository.
In this pr, a special handling is added to handle the "/" as filepath.

LGTM.

Thank you guys. This fix will be deployed on next Fri.


Expose ENV variable to build environment for build step

Expose the current build step to the build environments. This would allow for step detection and executing commands during specific build steps.

@agjohnson can you explain this issue a little more?
BTW, is this issue still relevant?

Updated the description. I think this is probably a valid feature, but low priority


module-info.java (or structures datatypes to be unique)

I tried to use hapi-base and hapi-structures-v281 as automatic module.
It tells me, that datatypes are exported from both as the base packages includes a subset of every full structure. This is incompatible to the Java 9+ module system

just realized, i might be in the wrong project here. hapfhir/hapi-hl7v2 is what has the mentioned libraries


ci(workflow): add cache 'yarn' to workflows

Description
Add cache to workflows using actions/setup-node
Context
setup-node GitHub Action just released a new option to add cache to steps using it.
You can find the details here: https://github.blog/changelog/2021-07-02-github-actions-setup-node-now-supports-dependency-caching/
Re-generated PR from https://github.com/TryGhost/Ghost/pull/13597

🤖 This PR has been generated automatically by this octoherd script, feel free to run it in your GitHub user/org repositories! 💪🏾

@daniellockyer I did a cleanup of my forks and I had to re-generate the fork, PR's and so (not sure if there was a way to link everything). Closing old PR

Codecov Report

Merging #13716 (6eb15f5) into main (de6fff9) will decrease coverage by 0.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main   #13716      +/-   ##
==========================================
- Coverage   38.97%   38.94%   -0.04%
==========================================
  Files        1079     1079
  Lines       73274    73274
  Branches     5013     5011       -2
==========================================
- Hits        28562    28540      -22
- Misses      44669    44691      +22
  Partials       43       43

Impacted Files
Coverage Δ

core/server/data/db/connection.js
62.26% <0.00%> (-32.08%)
:arrow_down:

core/shared/config/loader.js
93.42% <0.00%> (-3.95%)
:arrow_down:

core/shared/config/utils.js
84.09% <0.00%> (-2.28%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update de6fff9...6eb15f5. Read the comment docs.

@oscard0m Thanks for the updated PR! It looks good to me the the setup-node actions seems to fail upon the job finishing - do you know why?

@daniellockyer I worked around this issue in a different project by creating the yarn cache directory (mkdir -p $(yarn cache dir)).
But... it seems like that means the package cache is empty 😕

https://github.com/actions/setup-node/issues/317#issuecomment-929694556 🤯

actions/setup-node#317 (comment) 🤯

OMG! Do you plan to block this until that issue is addressed?

@oscard0m I've implemented a workaround so we didn't have to disable FORCE_COLOR for the whole workflow. I've tested with your PR on top and caching seems to work!
If you'd just like to give it a quick rebase + then we should be good to merge 🙂

@oscard0m I've implemented a workaround so we didn't have to disable FORCE_COLOR for the whole workflow. I've tested with your PR on top and caching seems to work!
If you'd just like to give it a quick rebase + then we should be good to merge 🙂

Thanks @daniellockyer . Rebased pushed. Let's see what the CI says now 🍿

@oscard0m Thanks for the PR! 🕺🏻


[WIP] [#250] Add support to a simple location normalization

By combining ISO-3166 standards and the Levenshtein edition distance the processors now can (manually using a external csv file provided by Github) try to detect the canonical form of any non-normalized location stored on the warehouse records.
This normalization process as currently implemented was ran over all the location variations present on the OpenTrials database (293 different locations, according to this file provided by @vitorbaptista in other discussion) and we were able to normalize 81.91% of all occurrences. Most of the non-normalized cases can be described as corner-cases and (as stated by the issue description) should not be dealt (although they can be easily added to the auxiliary csv file to match specific locations, and that's the reason why we keep the csv file on the repository instead of accessing a remote file on-the-fly). We can provide a list of all normalizations performed by the algorithm, if desired.
Fixes https://github.com/opentrials/opentrials/issues/250

@felipevieira All good! Could you just rebase this branch with master, so the build can run on Travis? If it's green, I'll merge it.
Thanks for your work :+1:

@felipevieira Could you rebase again with master? I just merged some code at https://github.com/opentrials/processors/pull/108 that should make this pass on Travis.

@vitorbaptista All green (y)

@vitorbaptista All green :+1:

@felipevieira Merged! Thanks for your contributions :beers:


Install command wrong

It must be uv tool install housaku instead of add

Thanks for pointing it out! I just updated the README.


Partial application overload for binary signature methods

HEY! :D
As you may know, I dislike parentheses.  :D

:D hah.. you even forgot to remove one in your example...
Hmm.. Tbh. I'm leaning more towards nesting using css syntax like @fuzetsu suggested (inside the template string) instead of having that ugly $nest function. I think it would feel natural :) What do you think @barneycarroll ?
Although that chained template string thing is crazy 😃

😮 It didn't even occur to me that chaining tagged template strings would work, although it makes perfect sense.
@porsager I've really been enjoying keeping all the styles inside of the single template string. Plays more nicely with code formatters, and I feel like it's easier to scan quickly. 👍
Here's a refactor I did in that style.

@porsager leading comma followed by asterisk is "me and all my children", very useful… And I'm not sure how @fuzetsu's (awesome, DO IT!) proposal would accommodate this!

@barneycarroll hehe sure, I was talking about the last parenthesis in your chained template string example ;)
About how to make that work with a nested block i don't think there'd be ambiguity, but it might be hard to get the parsing right. If it seems weird to have a free comma there I guess the & operator could be appropriate? eg:
b`
  transform scale(2)

  , * {
    transform scale(0.5)
  }
  // or
  &, * {
    transform scale(0.5)
  }
`

@fuzetsu oh I see, you have more nest usage there than I usually have so it's even nicer by a bigger factor 😃

Comparing b`fade 0`.$hover`fade 1`  with z`fade 0; :hover { fade 1 }` , I'm not so sure which I like better. Having everything inside the backticks is nice, as well as the use of : instead of $, but the {} are kinda meh.

@barneycarroll I think Rasmus is referring to my bss inspired lib zaftig. Not really a proposal or anything, but I re-implemented most of the behavior I liked from bss, while exploring some slightly different API options, mainly focusing in on template strings, and emulating some css pre-processor-like behavior.
This file gives a decent idea of what the syntax looks like, and this is what it looks like running.
@porsager I've found that my usage of nested styles has increased with zaftig. Since it's a bit easier to throw in. Like in a couple scenarios in that code I linked I had a style that was shared between two elements only in this one component, and they weren't in a loop. So instead of creating the style outside, caching it and then using it for both, I just use a nested style.
@osban Can you think of any alternatives? I think the advantages of braces are familiarity, and that they express a scope of sorts, like in JS. But it does feels a bit weird sometimes for short inline ones, otherwise I've been happy with it.
Sometimes I've done crazy stuff like this :laughing:  but as you can see you kind of have to invent a separator.

@fuzetsu Hmm, what about something like zfade 0; :hover <fade 1; bc red>? Seems less invasive than {}, [], or ()`.

Version 3* is just around the corner with a complete overhaul which i believe will give you what you're after ;) Stay tuned....
version 2 got skipped because of a discovery I made recently :P


Update the Example Code in README.md of wrapper-react and wrapper

Hey there,
The current example code in https://github.com/TypeFox/monaco-languageclient/blob/1a1595c9160d1027621e51f0e5ae2ddc186e1815/packages/wrapper-react/README.md and https://github.com/TypeFox/monaco-languageclient/blob/1a1595c9160d1027621e51f0e5ae2ddc186e1815/packages/wrapper/README.md aren't updated to the latest version:
https://github.com/TypeFox/monaco-languageclient/blob/1a1595c9160d1027621e51f0e5ae2ddc186e1815/packages/wrapper-react/README.md?plain=1#L30_L31
https://github.com/TypeFox/monaco-languageclient/blob/1a1595c9160d1027621e51f0e5ae2ddc186e1815/packages/wrapper/README.md?plain=1#L61_L62

@Yokozuna59 thank you, forgot to update those. Will do...

Was fixed on main branch. New releases are available:
https://www.npmjs.com/package/monaco-languageclient/v/8.5.0
https://www.npmjs.com/package/vscode-ws-jsonrpc/v/3.3.2
https://www.npmjs.com/package/monaco-editor-wrapper/v/5.2.0
<EMAIL_ADDRESS>


Offline mode - send .tar.gz of pre-built binary

Is your feature request related to a problem? Please describe.
I have access to multiple machines running Ubuntu 20.04 on arm64, and Neovim is not provided as a pre-built binary for this OS/CPU architecture. I have a built neovim binary on one of these machines (via the install process in remote-nvim) but I would like to re-use this binary when I launch remote-nvim in other machines.
Currently, when I start a new session on a new machine it downloads sources and builds nvim, which takes multiple minutes to complete.
Describe the solution you'd like
It would be nice if I could specify a machine OS/CPU-arc and the version to use e.g.
{
  binary_urls = {
    "linux-arm64" = {
      binary_source = "~/.cache/nvim/remote-nvim.vim/nvim-10.1-aarch64.tar.gz"
    },
    "linux-amd64" = {
      binary_source = "github"
    }
  }
}

That seems fair. There are a couple more issues that are about similar instances. I'll club them and let you all know when I think of a silver bullet to solve this (probably incorporating some or most of all suggestions here and in other issues) unless I could whip up something better.
I have been out for past couple months so it would take me some time to get through all this. So, it would be sometime before this gets fixed. Thanks!


[OAL] Keep the endpoint avg resp time meter name the same with others scope.

This is a minor polish.
So far, we have cpm , sla, percentile, resp_time for service, instance, database scope, but for endpoint, endpoint_avg not keep the same format of _resp_time.
And, we also need to update the query parameter in UI query/repo.

[ ] If this pull request closes/resolves/fixes an existing issue, replace the issue number. Closes #.
[x] Update the CHANGES log.

Why do we suddenly change this? I am fine but just curious.

This could break 3rd party integration, so, I want to know why.

Why do we suddenly change this? I am fine but just curious.

In order to make the user experience better, for example, when users configure alarm rules, the avg response time of the endpoint can be configured as naturally as the avg response time of the service/instance, rather than making endpoint avg unique. It looks a bit weird, and users will think that there is something specially designed in it?

This could break 3rd party integration, so, I want to know why.

If it involves large changes or coordination troubles, we can still use the original name

Why do we suddenly change this? I am fine but just curious.

In order to make the user experience better, for example, when users configure alarm rules, the avg response time of the endpoint can be configured as naturally as the avg response time of the service/instance, rather than making endpoint_avg unique. It looks a bit weird, and users will think that there is something specially designed in it?

No specific reason. I believe this is a mistake. If we plan to fix, let us be clear this is a break change in the change log, and search all docs, whether OAL and alarm docs affected by this break.

Why do we suddenly change this? I am fine but just curious.

In order to make the user experience better, for example, when users configure alarm rules, the avg response time of the endpoint can be configured as naturally as the avg response time of the service/instance, rather than making endpoint_avg unique. It looks a bit weird, and users will think that there is something specially designed in it?

No specific reason. I believe this is a mistake. If we plan to fix, let us be clear this is a break change in the change log, and search all docs, whether OAL and alarm docs affected by this break.

Okay

Waiting for all e2e passed.

I noticed endpoint_avg exists in the GraphQL protocol files(comments), metrics.graphqls and metrics-v2.graphqls. Could you fix them as well?

ok

Please update the submodule and check whether there is UT failing.

CI failed looks like timeout, and I tested ok locally.

Oh.. ui-configuration.graphqls will be merged, I think we can't sync the submodule for now.
https://github.com/apache/skywalking/issues/8477 is only going to be taken care of by @wankai123 after booster UI is ready.

We need a submodule rollback, sorry, I forgot the breaking change.


Error in job genotype while creating output

Hello! I have an error while running workflow denovo. I had the same problem with my samples and with your test directory.
Finished job 3.
75 of 79 steps (95%) done

rule genotype:
    input: test_workdir/03.results/efae_GCF_900639545/01.clusterseq.efae_GCF_900639545.tsv, test_workdir/01.mgefinder/efae_GCF_900639545/efae_GCF_900639545.all_pair.txt
    output: test_workdir/03.results/efae_GCF_900639545/02.genotype.efae_GCF_900639545.tsv
    log: test_workdir/03.results/efae_GCF_900639545/log/efae_GCF_900639545.genotype.log
    jobid: 4
    benchmark: test_workdir/03.results/efae_GCF_900639545/log/efae_GCF_900639545.genotype.benchmark.txt
    wildcards: genome=efae_GCF_900639545

zsh:2: = not found
Error in job genotype while creating output file test_workdir/03.results/efae_GCF_900639545/02.genotype.efae_GCF_900639545.tsv.
RuleException:
CalledProcessError in line 286 of /home/mk/miniconda3/envs/mgefinder/lib/python3.6/site-packages/mgefinder/workflow/denovo.original.Snakefile:
Command '
        if [ "True" == "True" ]; then
            mgefinder genotype --filter-clusters-inferred-assembly test_workdir/03.results/efae_GCF_900639545/01.clusterseq.efae_GCF_900639545.tsv test_workdir/01.mgefinder/efae_GCF_900639545/efae_GCF_900639545.all_pair.txt -o test_workdir/03.results/efae_GCF_900639545/02.genotype.efae_GCF_900639545.tsv 1> test_workdir/03.results/efae_GCF_900639545/log/efae_GCF_900639545.genotype.log 2> test_workdir/03.results/efae_GCF_900639545/log/efae_GCF_900639545.genotype.log.err ||             (cat test_workdir/03.results/efae_GCF_900639545/log/efae_GCF_900639545.genotype.log.err; exit 1)
        else
            mgefinder genotype --no-filter-clusters-inferred-assembly test_workdir/03.results/efae_GCF_900639545/01.clusterseq.efae_GCF_900639545.tsv test_workdir/01.mgefinder/efae_GCF_900639545/efae_GCF_900639545.all_pair.txt -o test_workdir/03.results/efae_GCF_900639545/02.genotype.efae_GCF_900639545.tsv 1> test_workdir/03.results/efae_GCF_900639545/log/efae_GCF_900639545.genotype.log 2> test_workdir/03.results/efae_GCF_900639545/log/efae_GCF_900639545.genotype.log.err ||             (cat test_workdir/03.results/efae_GCF_900639545/log/efae_GCF_900639545.genotype.log.err; exit 1)
        fi
        ' returned non-zero exit status 1.
  File "/home/mk/miniconda3/envs/mgefinder/lib/python3.6/site-packages/mgefinder/workflow/denovo.original.Snakefile", line 286, in __rule_genotype
  File "/home/mk/miniconda3/envs/mgefinder/lib/python3.6/concurrent/futures/thread.py", line 56, in run
Will exit after finishing currently running jobs.
Exiting because a job execution failed. Look above for error message

test_workdir/03.results/efae_GCF_900639545/log directory is empty.

I haven't seen this error before. This looks like you are using the Z shell instead of the default bash. Could you try running it in a bash shell?

New MacOS updates have the default terminal shell scripting in Zsh now. Is there any way to go around this bash script error?


Server object browsing dies on periods

If the path has a period in it, this CMDLET dies.
"dir SQLSERVER:\SQL$servername\DEFAULT\Databases\testDB" will work great.
"dir SQLSERVER:\SQL$servername\DEFAULT\Databases\test.DB" errors out wildly:
"Cannot retrieve the dynamic parameters for the cmdlet. SQL Server PowerShell provider error: The number of keys specified does not match the number of keys required to
address this object. The number of keys required are: Name."

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: c4a81f1f-28a2-f627-d009-040452d50de2
Version Independent ID: 15979469-7b3b-a154-3180-06ff33436954
Content: Navigate SQL Server PowerShell Paths - SQL Server
Content Source: docs/powershell/navigate-sql-server-powershell-paths.md
Product: sql
Technology: scripting
GitHub Login: @markingmyname
Microsoft Alias: maghan

The following script demonstrates the issue well:
$servername="dev-sql01"
$databases=Get-ChildItem -Path "SQLSERVER:\SQL$servername\DEFAULT\Databases"
foreach ($db in $databases){
echo "-----$db-----"
Get-ChildItem $db
}

@razgrim Thank you for the feedback.
This definitely constitutes a product bug.
@markingmyname Do you have a reference for SQL Server Powershell issues?

Thank you for your suggestion and request. We're on it. This will be discussed with the parties involved.
In the meantime, can you please visit UserVoice to submit your issue?

Thanks for your comment, @[github person who posted]. This looks like a support request rather than documentation feedback.
Please visit one of the following pages depending on your product or service.
On Prem users
SQL on Azure
Services Hub (Unified/premier customers)

@razgrim
The behavior is by design, at least in the current design (. needs to be escaped because it is a special char).

We will now proceed to close this thread. If there are further questions regarding this matter, please tag me in your reply. We will gladly continue the discussion, and we will reopen the issue. To see what the community is wanting, please visit the UserVoice site.

Could you provide some clue on how '.' should be escaped? The only information I found was https://docs.microsoft.com/en-us/sql/powershell/escape-sql-server-identifiers?view=sql-server-ver15, but using '`' didn't help me to deal with dots unfortunately.
Thank you


Raise an error when a non-MPI-mode HTEX is passed a resource specification

Is your feature request related to a problem? Please describe.
Globus Compute would like to warn users when they try to do MPI stuff on non-MPI Compute endpoints. Currently the only place that would raise an error is when workers try to access PARSL_MPI_PREFIX, and it would be nice to catch that even earlier.
Describe the solution you'd like
Add a check to validate_resource_spec which raises an error if is_mpi_enabled is false and any resource spec is passed in.
Describe alternatives you've considered
Compute could check this at the engine level, before submitting to the HTEX
Additional context
https://github.com/Parsl/parsl/issues/3498 is asking for almost the opposite, but it sounds like @benclifford is on the side of more restrictiveness here

This is implemented in #3582


facebook video: Cannot parse data;

 % youtube-dl -v -F "https://www.facebook.com/BBCWalesNews/videos/1269641106435307/"
[debug] System config: []
[debug] User config: []
[debug] Command-line args: ['-v', '-F', 'https://www.facebook.com/BBCWalesNews/videos/1269641106435307/']
[debug] Encodings: locale UTF-8, fs utf-8, out UTF-8, pref UTF-8
[debug] youtube-dl version 2016.12.22
[debug] Python version 3.5.1 - Linux-4.6.2-1-ARCH-x86_64-with-arch
[debug] exe versions: ffmpeg 3.0.2, ffprobe 3.0.2, rtmpdump 2.4
[debug] Proxy map: {}
[facebook]<PHONE_NUMBER>435307: Downloading webpage
[facebook]<PHONE_NUMBER>435307: Downloading webpage
ERROR: Cannot parse data; please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; see  https://yt-dl.org/update  on how to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.
Traceback (most recent call last):
  File "/usr/lib/python3.5/site-packages/youtube_dl/YoutubeDL.py", line 694, in extract_info
    ie_result = ie.extract(url)
  File "/usr/lib/python3.5/site-packages/youtube_dl/extractor/common.py", line 358, in extract
    return self._real_extract(url)
  File "/usr/lib/python3.5/site-packages/youtube_dl/extractor/facebook.py", line 343, in _real_extract
    video_id, fatal_if_no_video=True)
  File "/usr/lib/python3.5/site-packages/youtube_dl/extractor/facebook.py", line 266, in _extract_from_url
    raise ExtractorError('Cannot parse data')
youtube_dl.utils.ExtractorError: Cannot parse data; please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; see  https://yt-dl.org/update  on how to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.

Carefully read new issue template and provide all requested information.


Quick Reorg & Other Changes

Saw this on Reddit and felt like pretending I was being productive tonight.  I've gone through and reorganized the folder/file structure as close as I can think of to what the PSR stuff suggests.  I also change the way namespaces are setup so that all query types are now part of a Queries sub-namespace.  Made an adjustment for an issue I had recently using a DateTime in 5.6.6, and I converted the config value to be a JSON file which is decoded (keeps you from using globals and generally makes things cleaner.  I'll take a longer look at this when I've got some time, but hopefully this is helpful!

So, like I said, I'm no great programmer, and I am definitely unfamiliar with what is currently "best practice". So some questions:
First, and least important, your line-endings are DOS. I'm going to change those over to UNIX terminations unless there's a compelling reason not to
Second, I dig the timezone change, and the json config file (though I don't really get the check for a another config file, but I don't think it matters much).
The namespace changes are interesting. Is it considered a good practice to create an author-specific namespace to put things like this in? I can see why it might be a good idea to make a \Queries namespace (at least, I think I do? Should there be a namespace per "type" of query?), but can you explain why everything lives in standaloneSA?
Thanks!
--Matt

Yeah sorry about the line-endings.  I am primarily a .NET programmer, so I like to live my life inside of Visual Studio, I probably just have it set to make everything DOS, I will change that.
The reason for the option to supply a different config file is just a good habit for making something testable/adaptable.  The more things you turn into options which can be configured or injected, the easier it is for people to integrate it with their own systems.
The big thing in PHP right now is the PHP-FIG.  The namespaces are setup to mirror what they recommend for things like their autoloader, and one of the key components is having everything live within a 'vendor' namespace.  As for the namespace per type of query, I think that would only make sense if there were things that supported the query types.  Since we just have a group of queries and nothing more complex (at the moment), I think this feels like a solid setup.

Andy

Alright, cool. I've merged it, and I'll take care of the line-endings. Thanks for the explanations. I appreciate it!
--Matt


SVG resources not displayed inside pin markers before 200 milliseconds

VERSIONS

Xamarin.Forms.GoogleMaps - 3.0.1
Xamarin.Forms - <IP_ADDRESS>7729
Xamarin.FFImageLoading.Svg - <IP_ADDRESS>0

PLATFORMS

[x] Android
[x] iOS
[ ] UWP

ACTUAL BEHAVIOR
We are using SvgCachedImage to load SVG resources (1KB~5KB file size) inside pin markers in Xamarin.Forms.GoogleMaps map and everything goes well only after 200 milliseconds from the same resources. Each new resource goes through the same scenario. So, the pins added before this time do not show the svg resource but if the map is called again, all the resources are displayed.
ACTUAL SCREENSHOTS/STACKTRACE
N/I
EXPECTED BEHAVIOR
All pins shown in the map. SVGs loaded before <= 200 milliseconds.
HOW TO REPRODUCE
(xamarin)

Create a view with GoogleMaps map.
In the map class creation.
Put random customView pins from the <FFImageLoading:SvgCachedImage ... svg> in the XAML.

Hello, any clue about this problem?


[HDBTI] Processing of large CSV files is taking too long

It seems that processing of large CSV files with 300+ records takes several minutes and this leaves the user with the feeling that something went wrong and that the data is not being processed at all. Such action should be executed in matter of seconds.

Note: It seems that the majority of the time is spent in loading & pre-processing of the data, the actual data import (INSERT statements) seems to be executed in acceptable timeframe.

Refactor the existing logic to remove this bottleneck.

I found the following bottleneck:

https://github.com/SAP/xsk/blob/24008e96c3c10434f23d9e10a26e514b5796f4ac/modules/engines/engine-hdbti/src/main/java/com/sap/xsk/hdbti/processors/XSKHDBTIProcessor.java#L99-L101

Where xskHdbtiCoreService.getPkForCSVRecord() is making a call to the database to determine the table metadata for each record in the CSV file. It could be updated to xskHdbtiCoreService.getPkIndexForCSVRecord() and store the primary key index for the whole for loop:

https://github.com/SAP/xsk/blob/24008e96c3c10434f23d9e10a26e514b5796f4ac/modules/engines/engine-hdbti/src/main/java/com/sap/xsk/hdbti/processors/XSKHDBTIProcessor.java#L85-L115

Also something to notice here is that with the current implementation composite primary key are not supported, as only the first key is extracted:
columnModels.stream().filter(PersistenceTableColumnModel::isPrimaryKey).findFirst().get().getName();

https://github.com/SAP/xsk/blob/708d1603a2463e9d2eed998b45f15e9b4039cf32/modules/engines/engine-hdbti/src/main/java/com/sap/xsk/hdbti/service/XSKHDBTICoreService.java#L193-L196


Release C memory in Run()  - DO NOT REVIEW

Release all C allocated memory in Run() func.

@govint - can you please explain why did you do it ?

Pls. hold off reviewing. I've got more work to for this PR.

Closing this PR, will reopen once issue is better root-caused.


contrib: Support more remote URL patterns

The new regex to find valid cilium/cilium remotes supports e.g.:

git@github.com:cilium/cilium (no .git at the end)
<EMAIL_ADDRESS>

Coverage decreased (-0.02%) to 45.466% when pulling 075d7c94237667b2def9d58bd56d2b68de1c4b6c on pr/pchaigno/fix-backporting-find-remote into 8162f6b69d4b571705bcc30e19f6bfdf53b66b96 on master.

We may as well merge this and allow the next round of backporters to validate the scripts and fix them up if it breaks any of their environments.


Blockvote: fix the problem seen at the demo

As it has been communicated earlier, there was no technical problem, just a user misunderstanding. So there is nothing to fix.


fix composer focusing for popups

Details

Fixes issues which composer getting focus when popup are closed which sets modal.isVisible onyx key as false even though we have RHN opened.
Fixed Issues

$ https://github.com/Expensify/App/issues/23403
PROPOSAL: https://github.com/Expensify/App/issues/23403#issuecomment-1676380363
Tests

[x] Verify that no errors appear in the JS console

Open any report & settings.
From RHP open workspaces -> workspace.
Refresh in worksapce settings page
Click on three dot menu & click on delete workspace
Close the popup by cancelling the confirm modal.
Now try typing in RHP & Composer shouldn't get focused.
While everything is closed (no modal, no popup) typing should focus on composer.

Offline tests

Same as above
QA Steps

[x] Verify that no errors appear in the JS console
Same as above.

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android / native
[x] Android / Chrome
[x] iOS / native
[x] iOS / Safari
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x]  I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] If we are not using the full Onyx data that we loaded, I've added the proper selector in order to ensure the component only re-renders when the data it is using changes
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[x] I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web
https://github.com/Expensify/App/assets/59088937/4eb42210-b422-4113-a7b6-7e1a98c9caca

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

@ArekChr I have attached the screen recording for web, will update the desktop also soon. But I'm wondering what should I do for mobile devices. It's not like we can type without keyboard open/we can see report or composer when RHP is opened.
Please guide me on how can we proceed with the mobile devices.
@MariaHCD Would need your opinion as well. Thanks.

Please guide me on how can we proceed with the mobile devices.

The issue was only reported for web, so on mobile devices just testing that the composer box works as expected should be sufficient.

Ok, will update the screen recordings. Thanks.

@ArekChr I have added the screen-recordings as well. Please check. Thanks.

@b4s36t4 can you please merge main and retest?
@ArekChr could you prioritize this PR review please. Thanks!

@mountiny merged with main & it's working fine. Not able to type on composer or wasn't able to re-produce the issue as mentioned in the slack thread.

I have found a new issue while verifying this, which is I can paste and get composer focus even a popup is opened (ex: attachment picker) - was able re-produce in staging too. So it's a previous issue.

Sorry for the delay. Too many issues, I have been assigned since I was at the RNEU conference. Reviewing

Reviewer Checklist

[x] I have verified the author checklist is complete (all boxes are checked off).
[x] I verified the correct issue is linked in the ### Fixed Issues section above
[x] I verified testing steps are clear and they cover the changes made in this PR

[x] I verified the steps for local testing are in the Tests section
[x] I verified the steps for Staging and/or Production testing are in the QA steps section
[x] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[x] I checked that screenshots or videos are included for tests on all platforms
[x] I included screenshots or videos for tests on all platforms
[x] I verified tests pass on all platforms & I tested again on:

[x] Android / native
[x] Android / Chrome
[x] iOS / native
[x] iOS / Safari
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop

[x] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[x] I verified proper code patterns were followed (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I verified that this PR follows the guidelines as stated in the Review Guidelines
[x] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[x] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

https://github.com/Expensify/App/assets/24796318/7a48927b-49df-4085-a4af-52d09a14f290

Mobile Web - Chrome

https://github.com/Expensify/App/assets/24796318/89bb9cfc-0129-4b83-b8d2-1074d4d2e201

Mobile Web - Safari

https://github.com/Expensify/App/assets/24796318/965ea4e8-2092-4a87-ad3d-7565033857bf

Desktop

https://github.com/Expensify/App/assets/24796318/b98f72bb-478d-4534-a1f7-048434d8b16e

iOS

https://github.com/Expensify/App/assets/24796318/3e5a3e09-b5a3-4f93-b25b-3515c6326c3a

Android

https://github.com/Expensify/App/assets/24796318/9ab268cb-36d4-4090-80dc-b4760e8b8aaa

@MariaHCD Lets try to merge this one before next deploy 🚀

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to staging by https://github.com/MariaHCD in version: 1.3.68-8 🚀

platform
result

🤖 android 🤖
cancelled 🔪

🖥 desktop 🖥
cancelled 🔪

🍎 iOS 🍎
cancelled 🔪

🕸 web 🕸
success ✅

Hi! This caused this bug report - https://github.com/Expensify/App/issues/27250 - which also happens for the right click context menu.
I'm personally not sure if it's a bug / regression, I think it might end up being expected behavior, BUT it's definitely a change from what happened previously (and what happens on production). Let me know if you can think of a way to fix this that doesn't undo your change! Thanks.

🚀 Deployed to production by https://github.com/Julesssss in version: 1.3.68-17 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
failure ❌

🕸 web 🕸
success ✅

🚀 Deployed to staging by https://github.com/MariaHCD in version: 1.3.70-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


Would you like to share your processed training dataset?

Hi, thank you for your impressive work. Could you share the training dataset (including the pose file)?   I want to train it from scratch to make me better understand this code.

Ok, thanks.

I examined the pose.npy file and noticed that it contains an array with the dimensions [2, h, w]. Is this a motion field? I've made multiple attempts to acquire this kind of data using DensePose without success. I'm eager to see your processing code.

I solved that problem. Your motion is the uv matrix:)

Hey!
How do you get the UV matrix from densepose?

You can modify the code in apply_net.py of DensePose (detectron2)  and get the UV matrix:
UV = result["pred_densepose"][0].uv.cpu().numpy()

Ohhkk. I instead used the dump option in the apply_net.py. It ends up storing the pkl files which contains the densepose-uv.

@harlanhong when I got this，
UV = result["pred_densepose"][0].uv.cpu().numpy()，the shape didn't align with the orignal shape. I used frame_50.png to test.Why?
(720, 576, 3)
(2, 653, 192)

Yes, because authors' densepose.py directly crops the detection bounding box. You can paste the detected result back to the background as following:


[REBUILD] Whispers of Satan needs testing!!!

Whispers of Satan was just re-added to the rebuild branch. This requires testing from the crack team of mapset testers.
Please add a note to the ticket if you are testing this and please report back on the following:
Any texture issues (missing or incorrect textures etc)
Thing issues (incorrect decorations, monsters etc)
Show stopping bugs
Any other issues

This should be tested within the week before other mapsets are added.
Please note that the HUB map is currently being rebuilt and is not available right now, use changemap WOS_01 to start the mapset

Whispers of Satan is completable and I've found no glaring issues.


Volatile db: simulated errors

This pr addresses remaining issues related to https://github.com/input-output-hk/ouroboros-network/issues/202
This pr:

remove db Folder from the db environment and makes it opaque in the HasFs mountpoint. https://github.com/input-output-hk/ouroboros-network/pull/163
improves the way the db handles parsing errors. https://github.com/input-output-hk/ouroboros-network/pull/163
changes the way db handles files with less blocks than expected and corrupted files. https://github.com/input-output-hk/ouroboros-network/issues/273
adds tests for corrupted files. https://github.com/input-output-hk/ouroboros-network/issues/273
adds tests for simulated errors. https://github.com/input-output-hk/ouroboros-network/issues/273
adds tests for parsers.
adds tags and labeling. https://github.com/input-output-hk/ouroboros-network/issues/251

For Corruption testsI needed to extend the Model. Now the model is aware of what file has each block at any time. This is important so that it can predict what effect each corruption will have.
For simulated errors I followed a different approach from ImmutableDB. At Immutable DB the Model does not actually know if the error will be actually thrown in the real Impl. To sync Model and Impl, the db is truncated when there is actually an error. For Volatile DB we use a different approach: the Model can predict if the error will be actually thrown and make only the actual changes until it is thrown. For example for gc it can predict that half the files will be deleted but then there will be a FsError. Or for putBlock it can see if hPut will actually succeed or fail.
Things that can be extended:

The Model predicts what errors will actually beed thrown but not to great precision. It predicts only when it's necessary (eg only for writes). To make it work we don't actually compare the results when there can be a possible error. The prediction can be extended and be more detailed, so that we can check that Model and Impl throw exactly the same error.
Tags for real error.

Tag Examples (they are pretty small)
There is only one Tag which does not appear, because the precondition does not allow it.
 I didn't delete this unit test.
*** Found example of TagEmpty
Commands { unCommands = [] }
*** Found example of TagGetNothing
Commands
{ unCommands =
[ Command
At { unAt = CmdErr { cmd = GetBlock 1 , err = Nothing } }
At { unAt = Resp { getResp = Right (Blob Nothing) } }
[]
]
}
*** Found example of TagClosedError
Commands
{ unCommands =
[ Command
At { unAt = CmdErr { cmd = Close , err = Nothing } }
At { unAt = Resp { getResp = Right (Unit ()) } }
[]
, Command
At { unAt = CmdErr { cmd = PutBlock 4 , err = Nothing } }
At { unAt = Resp { getResp = Left ClosedDBError } }
[]
]
}
*** Found example of TagCorruptWriteFile
Commands
{ unCommands =
[ Command
At
{ unAt =
CmdErr
{ cmd = Corrupt (( DeleteFile , "blocks-0.dat" ) :| [])
, err = Nothing
}
}
At { unAt = Resp { getResp = Right (Unit ()) } }
[]
]
}
*** Found example of TagAppendRecover
Commands
{ unCommands =
[ Command
At
{ unAt =
CmdErr
{ cmd = Corrupt (( AppendBytes 1 , "blocks-0.dat" ) :| [])
, err = Nothing
}
}
At { unAt = Resp { getResp = Right (Unit ()) } }
[]
]
}
*** Found example of TagGetJust
Commands
{ unCommands =
[ Command
At { unAt = CmdErr { cmd = PutBlock 1 , err = Nothing } }
At { unAt = Resp { getResp = Right (Unit ()) } }
[]
, Command
At { unAt = CmdErr { cmd = GetBlock 1 , err = Nothing } }
At
{ unAt =
Resp
{ getResp =
Right
(Blob
(Just
"\NUL\NUL\NUL\NUL\NUL\NUL\NUL\SOH\NUL\NUL\NUL\NUL\NUL\NUL\NUL\SOH"))
}
}
[]
]
}
*** Found example of TagGarbageCollectThenReOpen
Commands
{ unCommands =
[ Command
At { unAt = CmdErr { cmd = GarbageCollect 7 , err = Nothing } }
At { unAt = Resp { getResp = Right (Unit ()) } }
[]
, Command
At { unAt = CmdErr { cmd = Close , err = Nothing } }
At { unAt = Resp { getResp = Right (Unit ()) } }
[]
, Command
At { unAt = CmdErr { cmd = ReOpen , err = Nothing } }
At { unAt = Resp { getResp = Right (Unit ()) } }
[]
]
}
*** Found example of TagImpossibleToRecover
Commands
{ unCommands =
[ Command
At { unAt = CmdErr { cmd = CreateInvalidFile , err = Nothing } }
At
{ unAt =
Resp
{ getResp =
Left (VParserError (InvalidFilename "invalidFileName.dat"))
}
}
[]
]
}
*** Found example of TagReOpenGet
Commands
{ unCommands =
[ Command
At { unAt = CmdErr { cmd = Close , err = Nothing } }
At { unAt = Resp { getResp = Right (Unit ()) } }
[]
, Command
At { unAt = CmdErr { cmd = ReOpen , err = Nothing } }
At { unAt = Resp { getResp = Right (Unit ()) } }
[]
, Command
At { unAt = CmdErr { cmd = PutBlock 9 , err = Nothing } }
At { unAt = Resp { getResp = Right (Unit ()) } }
[]
, Command
At { unAt = CmdErr { cmd = GetBlock 9 , err = Nothing } }
At
{ unAt =
Resp
{ getResp =
Right
(Blob
(Just
"\NUL\NUL\NUL\NUL\NUL\NUL\NUL\t\NUL\NUL\NUL\NUL\NUL\NUL\NUL\SOH"))
}
}
[]
]
}
*** Found example of TagGetReOpenGet
Commands
{ unCommands =
[ Command
At { unAt = CmdErr { cmd = PutBlock 7 , err = Nothing } }
At { unAt = Resp { getResp = Right (Unit ()) } }
[]
, Command
At { unAt = CmdErr { cmd = GetBlock 7 , err = Nothing } }
At
{ unAt =
Resp
{ getResp =
Right
(Blob
(Just
"\NUL\NUL\NUL\NUL\NUL\NUL\NUL\a\NUL\NUL\NUL\NUL\NUL\NUL\NUL\SOH"))
}
}
[]
, Command
At { unAt = CmdErr { cmd = Close , err = Nothing } }
At { unAt = Resp { getResp = Right (Unit ()) } }
[]
, Command
At { unAt = CmdErr { cmd = ReOpen , err = Nothing } }
At { unAt = Resp { getResp = Right (Unit ()) } }
[]
, Command
At { unAt = CmdErr { cmd = GetBlock 7 , err = Nothing } }
At
{ unAt =
Resp
{ getResp =
Right
(Blob
(Just
"\NUL\NUL\NUL\NUL\NUL\NUL\NUL\a\NUL\NUL\NUL\NUL\NUL\NUL\NUL\SOH"))
}
}
[]
]
}

Nice work :)


Registry: Remove Object Type TOKEN, re-introduce Checks in registerService

implemented with pull request #452


Discrepancy in type and size of parameters during (animation) updates

Release Type:

releases/<IP_ADDRESS>4-7-gb1a503f2 (master)
releases/<IP_ADDRESS>4-55-g4dc12c95 (#1469)

Platform(s): Windows
Describe the bug
The types of equally named parameters are not guaranteed to be equal, but their values are expected to be the same size and have the same meaning for the purpose of updating animations and setting other updatable parameters.
The following tests fail after adding an assertion on the type or the size of equally named parameters.

Test
Parameter Name
InitialSize Type
UpdatedSize Type
Assertions

Stride.Physics.Tests.SkinnedTest.SkinnedTest1
"Material.SpecularValue"
12 Color3
16 Color4
3

Stride.Graphics.Tests.MaterialTests.MaterialSpecular
"Material.SpecularValue"
12 Color3
16 Color4
1

The parameters may be declared differently than they are used. This should not be possible.

In these cases, this may lead to loss of opacity since the new (Updated) bytes at offset 12-15 which contain the 4-byte float Color4.Alpha will become zero from the newly allocated byte array into which the old (Initial) values are copied. If the visible color ending up in hardware is the Color4 instead of the Color3, the result is transparent.
However, if the issue cannot be proven to (just) affect the tests mentioned, there is no telling how serious, wrong or visible this discrepancy in type and/or size could really be.

To Reproduce
Steps to reproduce the behavior:

Open ParameterCollection.cs
Find the text // Second pass to copy existing data at new offsets/slots
Paste the following code inside the for loop that starts after this comment
Run the tests mentioned and observe them fail.
Examine the stacktrace produced and verify that they have ParameterCollection.UpdateLayout just before Debug.Fail
Debug the tests and verify that UpdateLayout is in the process of updating the right existing parameter value with the right incoming parameter value (by name) when the check introduced fails

if (parameterKeyInfos[i].Key.PropertyType != newParameterKeyInfos[i].Key.PropertyType)
    Debug.Fail($"{parameterKeyInfos[i].Key.PropertyType} != {newParameterKeyInfos[i].Key.PropertyType}");

Expected behavior
The types (and hence) sizes of equally named parameters are equal.
Log and callstacks
(line numbers may vary depending on which branch is used, the below is from #1469)
 Stride.Physics.Tests.SkinnedTest.SkinnedTest1
   Source: SkinnedTest.cs line 47
   Duration: 2.8 sec

  Message:
    Microsoft.VisualStudio.TestPlatform.TestHost.DebugAssertException : Method Debug.Fail failed with 'Stride.Core.Mathematics.Color3 != Stride.Core.Mathematics.Color4
    ', and was translated to Microsoft.VisualStudio.TestPlatform.TestHost.DebugAssertException to avoid terminating the process hosting the test.

  Stack Trace:
    Debug.Fail(String message)
    ParameterCollection.UpdateLayout(ParameterCollectionLayout collectionLayout) line 635
    Copier.Compile() line 827
    Copier.Copy() line 778
    MaterialRenderFeature.UpdateMaterial(RenderSystem renderSystem, RenderDrawContext context, MaterialInfoBase materialInfo, Int32 materialSlotIndex, RenderEffect renderEffect, ParameterCollection materialParameters) line 370
    <>c__DisplayClass9_0.<Prepare>b__1(Int32 renderNodeIndex, RenderDrawContext threadContext) line 300
    Dispatcher.ExecuteBatch[TLocal](Int32 fromInclusive, Int32 toExclusive, Func`1 initializeLocal, Action`2 action, Action`1 finalizeLocal) line 357
    Dispatcher.Fork[TLocal](Int32 endExclusive, Int32 batchSize, Int32 maxDegreeOfParallelism, Func`1 initializeLocal, Action`2 action, Action`1 finalizeLocal, BatchState state) line 445
    <>c__DisplayClass19_0`1.<Fork>b__0() line 434
    ThreadPool.TryCooperate() line 106
    ThreadPool.WorkerThreadScope() line 137
    Thread.StartCallback()

Additional context
Debug assertions where added in the PR mentioned to verify unsafe copy operations. ParameterCollection was failing these assertions, mostly caused by the buffer overrun in CopyTo<T>, which is fixed in the mentioned PR. However after that fix, UpdateLayout kept failing and the reason is the change in size between Color3 and Color4. No other tests start failing after changing the assertion from checking the size to checking the type of the parameters.

UpdateLayout was modified to copy once if the parameter sizes are equal, but to copy item-for-item if the sizes differ, to force potentially uninitialized bytes to zero.
A #warning was inserted in UpdateLayout to keep the discrepancy visible when building Stride, pending a fix. The text is "Partially copying parameter values and leaving remaining bytes zero may cause undesired side effects such as e.g. Color4.Alpha becoming zero."

Solution
Find out why and how the type discrepancy could arise and remedy the discrepancy systematically.
Modify UpdateLayout to not accept type discrepancies any more.

Good catch, will need to find a way to prevent this from happening.


[IstioOperator] Unable to apply k8s patch to ztunnel

Bug Description
Trying to apply a manifest like this:
apiVersion: install.istio.io/v1alpha1
kind: IstioOperator
metadata:
  name: istio-operator
spec:
  profile: ambient
  components:
    ztunnel:
      enabled: true
      k8s:
        resources:
          requests:
            cpu: 100m
            memory: 100Mi
          limits:
            cpu: 200m
            memory: 200Mi

results in the following error:
Error:   failed to update resource with server-side apply for obj DaemonSet/istio-system/ztunnel: failed to create typed patch object (istio-system/ztunnel; apps/v1, Kind=DaemonSet): .spec.template.spec.containers: expected list, got &{map[[name:]:map[resources:map[limits:map[cpu:200m memory:200Mi] requests:map[cpu:100m memory:100Mi]]]]}.
Version
client version: 1.18.0-alpha.0
control plane version: 1.18.0-alpha.0
data plane version: 1.18.0-alpha.0 (5 proxies)

Client Version: v1.26.3
Kustomize Version: v4.5.7
Server Version: v1.26.3

Additional Information
No response
Affected product area

[X] Ambient
[ ] Docs
[X] Installation
[ ] Networking
[ ] Performance and Scalability
[ ] Extensions and Telemetry
[ ] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure
[ ] Upgrade
[ ] Multi Cluster
[ ] Virtual Machine
[ ] Control Plane Revisions

I think the resource part is missing, I'll check it.


Integration Test - Release - 2019/11/19 01:42:31

Auto create for integration test. IssueCommandFlow

@PRMergerTest3 : Thanks for your contribution! The author(s) have been notified to review your proposed change.


Float Division by Zero

Traceback (most recent call last):
  File "examples/sample.py", line 88, in <module>
    t.train(seq2seq, dataset, num_epochs=4, dev_data=dev_set, resume=opt.resume)
  File "/root/pytorch-seq2seq/seq2seq/trainer/supervised_trainer.py", line 160, in train
    resume=resume, dev_data=dev_data, teacher_forcing_ratio=teacher_forcing_ratio)
  File "/root/pytorch-seq2seq/seq2seq/trainer/supervised_trainer.py", line 111, in _train_epoches
    loss = self._train_batch(input_variables, target_variables, model, teacher_forcing_ratio)
  File "/root/pytorch-seq2seq/seq2seq/trainer/supervised_trainer.py", line 74, in _train_batch
    return loss.get_loss()
  File "/root/pytorch-seq2seq/seq2seq/loss/loss.py", line 140, in get_loss
    nll = super(Perplexity, self).get_loss()
  File "/root/pytorch-seq2seq/seq2seq/loss/loss.py", line 109, in get_loss
    return self.acc_loss.data[0] / self.norm_term
ZeroDivisionError: float division by zero

@Deepblue129 : Could you post a sample of the data you are running this on and also the arguments you used for the run ?

@avinash2692 Played around with this a bit more. Looks like this error comes up when there is a newline at the end of the training file!


Change wiki link in readme

In the Readme file the link to the wiki is wrong.
If you want to wrap your source files in a common template, you can use @metalsmith/layouts. For usage examples check out our wiki. Feel free to contribute an example if anything is missing, or update the existing ones. For templating engine specific questions try...
Is: https://github.com/metalsmith/metalsmith/in-place/wiki
Should be: https://github.com/metalsmith/in-place/wiki

There is no longer a wiki link in the readme and tbh the wiki is outdated so closing this


HOMEBREW_GITHUB_API_TOKEN doesn't apply for call to https://api.github.com/repos/org/name/releases/latest

brew doctor output
N/A

Verification

[X] My "brew doctor output" above says Your system is ready to brew. and am still able to reproduce my issue.
[X] I ran brew update twice and am still able to reproduce my issue.
[X] This issue's title and/or description do not reference a single formula e.g. brew install wget. If they do, open an issue at https://github.com/Homebrew/homebrew-core/issues/new/choose instead.

brew config output
N/A

What were you trying to do (and why)?
I'm trying to run a test in GitHub Actions for installing a local brew formula: brew install PATH_TO_FORMULA. The formula points to a local file for release:
# typed: false
# frozen_string_literal: true

# This file was generated by GoReleaser. DO NOT EDIT.
class Pgxman < Formula
  desc "PostgreSQL Extensions Manager"
  homepage "https://github.com/pgxman/pgxman"
  version "1.2.4-snapshot"
  license "Apache 2.0"

  on_macos do
    if Hardware::CPU.intel?
      url "file:///Users/owen/code/src/github.com/HydrasCo/pgxman/dist/pgxman_darwin_amd64.tar.gz"
      sha256 "fd0204385a1c7ce67c3b2f0c9cd484d6c2c5cf233004957f282c0fbb291cd9a1"

      def install
        bin.install "bin/pgxman"
        man1.install Dir["docs/man/man1/pgxman*.1"]
        generate_completions_from_executable(bin/"pgxman", "completion")
      end
    end
    if Hardware::CPU.arm?
      url "file:///Users/owen/code/src/github.com/HydrasCo/pgxman/dist/pgxman_darwin_arm64.tar.gz"
      sha256 "9af0150120246aeff300f08180580af32a530d0fe233293c8268d87e482bb273"

      def install
        bin.install "bin/pgxman"
        man1.install Dir["docs/man/man1/pgxman*.1"]
        generate_completions_from_executable(bin/"pgxman", "completion")
      end
    end
  end

  on_linux do
    if Hardware::CPU.intel?
      url "file:///Users/owen/code/src/github.com/HydrasCo/pgxman/dist/pgxman_linux_amd64.tar.gz"
      sha256 "8c63728b2a297ad31ac6fe3fe7868dccb717cd4bec01a8fe26e818d20ed90d7a"

      def install
        bin.install "bin/pgxman"
        man1.install Dir["docs/man/man1/pgxman*.1"]
        generate_completions_from_executable(bin/"pgxman", "completion")
      end
    end
    if Hardware::CPU.arm? && !Hardware::CPU.is_64_bit?
      url "file:///Users/owen/code/src/github.com/HydrasCo/pgxman/dist/pgxman_linux_armv6.tar.gz"
      sha256 "0c6d650ca0a505569f33e8b551695f798d57ac4e32e718ba723f3816742344f5"

      def install
        bin.install "bin/pgxman"
        man1.install Dir["docs/man/man1/pgxman*.1"]
        generate_completions_from_executable(bin/"pgxman", "completion")
      end
    end
    if Hardware::CPU.arm? && Hardware::CPU.is_64_bit?
      url "file:///Users/owen/code/src/github.com/HydrasCo/pgxman/dist/pgxman_linux_arm64.tar.gz"
      sha256 "ecf384379d7de3e2f24d45474b5b5a8df728fd8aa755ad0ca8d99c7799d61584"

      def install
        bin.install "bin/pgxman"
        man1.install Dir["docs/man/man1/pgxman*.1"]
        generate_completions_from_executable(bin/"pgxman", "completion")
      end
    end
  end

  head "https://github.com/pgxman/pgxman.git"

  test do
    assert_match(/pgxman version/, shell_output("#{bin}/pgxman --version"))
  end
end

What happened (include all command output)?
The GitHub Aciton fails for GET https://api.github.com/repos/org/name/releases/latest: 403 API rate limit exceeded 403 (But here's the good news: Authenticated requests get a higher rate limit. Check out the documentation for more details. even if I have set HOMEBREW_GITHUB_API_TOKEN to authenticate with GitHub.
What did you expect to happen?
HOMEBREW_GITHUB_API_TOKEN will be used to authenticate with GitHub for any API calls, and I won't run into GitHub API rate limit errors.
Besides, why would GET https://api.github.com/repos/org/name/releases/latest (checking the latest release) be called while I install a local formula that points to a local file for release?
Step-by-step reproduction instructions (by running brew commands)
Create a GitHub Actions workflow with the following:

HOMEBREW_GITHUB_API_TOKEN is set to a valid token
Install a local formula brew installs PATH_TO_FORMULA

If the Action worker's IP is rate limited, the workflow will fail for the 403 API rate limit exceeded for <IP_ADDRESS>. (But here's the good news: Authenticated requests get a higher rate limit. Check out the documentation for more details. error.
An example workflow result is here: https://github.com/pgxman/pgxman/actions/runs/9036106788/job/24832321215#step:4:79

It seems to be failing when running pgxman completion bash. Is it not your auto-update checker?

@Bo98:

Is it not your auto-update checker?
Indeed! That's what failed. I was confused. Thanks for the help!


App is crashing on IOS after deployment or in test-flight. Working fine locally.

Describe the Bug
The app is crashing on IOS after deployment on Appstore or Test flight. Working fine locally.
Steps To Reproduce
Deploy the app on Appstore or create a test flight. Working fine on debug mode. Crashing on release mode for IOS.
Code To Reproduce
Here is the code when we load songs
export const getMusicByTitle = (title, setAnimation) => dispatch => {
  setAnimation(true);
  axios
    .get(`${Api}/music/searchMusic?title=${title}`)
    .then(async res => {
      let arr = [];
      res?.data?.musics.forEach(x => {
        arr.push({
          id: x._id,
          url: x.audioUrl,
          title: x.title,
          artist: x.Artist,
          artwork: x.audioUrl,
        });
      });
      await TrackPlayer.destroy();
      await TrackPlayer.setupPlayer();
      await TrackPlayer.add(arr);
      dispatch(musicData(res?.data));
      setAnimation(false);
    })
    .catch(err => {
      setAnimation(false);
    });
};

Environment Info:

Paste the results of npx react-native info
Fetching system and libraries information... (node:7414) Warning: Accessing non-existent property 'padLevels' of module exports inside circular dependency (Use node --trace-warnings ... to show where the warning was created) System:   OS: macOS 12.3.1   CPU: (4) x64 Intel(R) Core(TM) i5-5257U CPU @ 2.70GHz   Memory: 23.26 MB / 8.00 GB   Shell: 3.2.57 - /bin/bash Binaries:   Node: 14.19.0 - ~/.nvm/versions/node/v14.19.0/bin/node   Yarn: 1.19.1 - /usr/local/bin/yarn   npm: 6.14.16 - ~/.nvm/versions/node/v14.19.0/bin/npm   Watchman: 4.9.0 - /usr/local/bin/watchman Managers:   CocoaPods: 1.11.2 - /usr/local/bin/pod SDKs:   iOS SDK:     Platforms: DriverKit 21.4, iOS 15.4, macOS 12.3, tvOS 15.4, watchOS 8.5   Android SDK:     API Levels: 23, 25, 28, 29, 30     Build Tools: 30.0.2, 32.0.0     System Images: android-29 | Google APIs Intel x86 Atom, android-30 | Intel x86 Atom_64, android-30 | Google APIs Intel x86 Atom, android-30 | Google APIs Intel x86 Atom_64     Android NDK: Not Found IDEs:   Android Studio: 2021.1 AI-211.7628.21.2111.8193401   Xcode: 13.3/13E113 - /usr/bin/xcodebuild Languages:   Java: 1.8.0_222 - /usr/bin/javac npmPackages:   @react-native-community/cli: Not Found   react: 17.0.1 => 17.0.1    react-native: 0.64.2 => 0.64.2    react-native-macos: Not Found npmGlobalPackages:   *react-native*: Not Found

Paste the exact react-native-track-player version you are using
"react-native-track-player": "^2.1.2",

Real device? Or simulator?
real Device

What OS are you running?
IOS

Really need help to fix this guys.

Why the app is crashing when songs are loaded on IOS real device?

At a glance my guess is that this has to do with your app and app environment rather than this lib, but I'll try and help.
I've used the lib in production before (and I'm sure others have too) and I've not experienced this.
Because it's in TestFlight we're really going to need a stacktrace or crash report to help you solve it.

I am loading the songs in the track player in this way the song URL is coming from s3. Is there any problem with this?
export const getMusicByTitle = (title, setAnimation) => dispatch => {   setAnimation(true);   axios     .get(${Api}/music/searchMusic?title=${title})     .then(async res => {       let arr = [];       res?.data?.musics.forEach(x => {         arr.push({           id: x._id,           url: x.audioUrl,           title: x.title,           artist: x.Artist,           artwork: x.audioUrl,         });       });       await TrackPlayer.destroy();       await TrackPlayer.setupPlayer();       await TrackPlayer.add(arr);       dispatch(musicData(res?.data));       setAnimation(false);     })     .catch(err => {       setAnimation(false);     }); };

Can you send the array of tracks? I'm guessing something is off there. Make sure they all have artists as there's a known bug on iOS where that field is actually required

Closing this until feedback is provided. Sounds like a config issue.

I have the same issue, but in both Android and IOS .. the app is crashing on some Android and OIS devices (not all of them) after deployment. working fine locally. Here es the example of track, the three properties are string, the url propertie is something like this https://${config.azureStorageAccount}.blob.core.windows.net/training-audios.
const track = {
url: audioUri,
title: 'title',
artist: 'Mindtrackr',
};
I really need help.
Thank you so much!

@Paovilla what kind of file is located at the URL https://${config.azureStorageAccount}.blob.core.windows.net/training-audios? It's strange that it doesn't have a typically extension, perhaps try playing one of the audio files included in the example repository.
Make 100% sure that you're trying to play the same tracks locally as you are in testflight.

In the repository there are .mp3 files and in the url  propertie of track I specify what audio to play, for example.
const trainingAudioBaseUrl = https://${config.azureStorageAccount}.blob.core.windows.net/training-audios;
const trainingAudioUri = ${trainingAudioBaseUrl}/${trainingToShow.audio};
const track = {
url: trainingAudioUri,
title: trainingToShow.title,
artist: 'Mindtrackr',
};
The issue happen in some devices not all, that is the reason that I know the track is ok, It could be something with the configuration?

@Paovilla , I'm not sure I follow about the type of audio playback. But if you can create a reproduction based off of a fork of this repo (in the example project), I'll reopen.
Thanks!


Remove deprecated rapids_export_find_package_* signatures

Description
Remove deprecated sigantures of rapids_export_find_package_file and rapids_export_find_package_root
Checklist

[ ] I am familiar with the Contributing Guidelines.
[ ] New or existing tests cover these changes.
[ ] The documentation is up to date with these changes.
[ ] The cmake-format.json is up to date with these changes.
[ ] I have added new files under rapids-cmake/

[ ] I have added include guards (include_guard(GLOBAL))
[ ] I have added the associated docs/ rst file and update the api.rst

/merge


Not showing all execution paths

Hey so I as testing out Pyrometer and used it against the backdoor example that the foundry fuzzer can't find in the hopes that it would pick up the constraints required to reach the execution path and show me the relevant bounds. Here is the contract code:
contract SymbolicTest {

    // https://github.com/foundry-rs/foundry/issues/2851
    function backdoor(uint256 x) external pure {
        uint256 number = 99;
        unchecked {
            uint256 z = x - 1;
            if (z ==<PHONE_NUMBER>124531) {
                number = 0;
            } else {
                number = 1;
            }
        }
        assert(number != 0);
    }

}

My terminal output
~/repositories/personal/forge-playground main ❯ pyrometer ./contracts/SymbolicTest.sol -vv                                          system
DONE ANALYZING IN: 1ms. Writing to cli...
Bounds: Bounds for function: function backdoor(uint256)
Bounds: Bounds for subcontext: backdoor(uint256) where:
1. (number != 0) == true
2. (z !=<PHONE_NUMBER>124531) == true
, killed: None
    ╭─[./contracts/SymbolicTest.sol:7:48]
    │
  7 │ ╭─▶     function backdoor(uint256 x) external pure {
  8 │ │           uint256 number = 99;
    │ │           ─────────┬─────────
    │ │                    ╰─────────── "number" == 99
    ┆ ┆
 10 │ │               uint256 z = x - 1;
    │ │               ────────┬────────
    │ │                       ╰────────── "z" ∈ [ 2**256 - 2, 2**256 - 1 ]
 11 │ │               if (z ==<PHONE_NUMBER>124531) {
    │ │                   ┬
    │ │                   ╰── "z" ∈ [ 2**256 - 2, 2**256 - 1 ] && ∉ { ==<PHONE_NUMBER>124531}
    ┆ ┆
 14 │ │                   number = 1;
    │ │                   ───┬──
    │ │                      ╰──── "number" == 1
    ┆ ┆
 18 │ ├─▶     }
    │ │
    │ ╰─────────── Entry function call

I would have expected a second trace where the constraint (z !=<PHONE_NUMBER>124531) == true isn't applied.
Note I did take the assert statement out and tried as well with the same result.
Is this just a limitation of the current implementation? Just trying to understand, I know halmos picks up the counter example value.

Good find. I have a hunch it has something to do with unchecked {} as removing that scope makes it work as expected.
contract SymbolicTest {

    // https://github.com/foundry-rs/foundry/issues/2851
    function backdoor(uint256 x) external pure {
        uint256 number = 99;
        uint256 z = x - 1;
        if (z ==<PHONE_NUMBER>12453) {
            number = 0;
        } else {
            number = 1;
        }
        assert(number != 0);
    }

}

fixed in #71
Also, by default reverting paths are hidden - use the flag --show-reverts true


Updated readme.md

Closing this PR, as obviously, we don't want to remove information about Roadmap from our README.


format utils

Format dag/tuitls/callstack.py

Codecov Report

Merging #59 (e4e6780) into main (c97fa71) will not change coverage.
The diff coverage is 83.33%.

@@           Coverage Diff           @@
##             main      #59   +/-   ##
=======================================
  Coverage   28.49%   28.49%
=======================================
  Files          32       32
  Lines         593      593
  Branches       27       27
=======================================
  Hits          169      169
  Misses        419      419
  Partials        5        5

Impacted Files
Coverage Δ

towhee/dag/utils/callstack.py
89.47% <83.33%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c97fa71...e4e6780. Read the comment docs.

/lgtm
/approve