HEDA Health Check feature

HEDA has a lot of configuration settings that significantly impact functionality. It would be really useful to have a Heath Check feature that can look at configuration and data to alert admins to potential issues. I'd envision a pluggable architecture that could run multiple health checks and output results to a UI, email, etc. Ideally each error could include some verbiage on why it's an issue and steps to correct it. Some potential checks could include:

Verify the Administrative record type is configured correctly.
Query and Administrative account records that are related to more than one (or zero) Contacts
Disabled trigger handlers and a discussion of how that affects functionality (or an empty trigger handler table which causes other problems)
Query any contacts where the email/phone fields are out of sync with preferred
Contacts where Address does not match the primary Address record
Missing record types for Course Connection (or course connections setting not turned on)

**lurch: add

Tracking W-021117

Happily delivered in our Spring major release!


Extend chapter 5: Immutability

Chapter 5 (Immutability) is pretty strong and lacks some important information like

pros and cons
definition of immutable classes
immutable collections in Java
toolkits to easily build immutable objects in Java (like immutables.org)

Open Tasks:

Read complete documentation and add interesting features
Does immutables.org provide support for collections or should this be done with Guavas Immutable Collections? Add this to workshop.


Vue is loaded twice when I use lerna (npm link)

Version
2.5.21
Reproduction link
https://github.com/wizardnet972/vue-lerna.git
Steps to reproduce
clone the repo: https://github.com/wizardnet972/vue-lerna.git
$ install lerna: npm i lerna -g (I think it not necessarily)
$ cd vue-lerna\apps\vue-app-ui
$ npm run serve -- --mode development

What is expected?
You will get this message at console twice:
You are running Vue in development mode.
Make sure to turn on production mode when deploying for production.
See more tips at https://vuejs.org/guide/deployment.html

What is actually happening?
vue is loading twice or more per the usage of the packages..
package1 -> vue in it
package2. -> vue in it
packageN ...

I think what happends is, webpack try to resolve vue from the package1, from local node_module folder so webpack add vue package to package bundle.
see the sources.
** The packages is connected using npm link by lerna. **

Read about --hoist flag https://github.com/lerna/lerna/tree/master/commands/bootstrap#--hoist-glob
But...  I think it won't solve your problem if one of the packages will use different Vue version, because thh one Vue version will be hoisted in your project's root node_modules and another in e.g. package1's node_modules. I would just remove vue as dependency for any project in packages directory.

@sqal thank you. it's work. but I think each package should have its own dependencies and webpack should be hoisting existing module base on version and hash or something like that. but anyway it's work this way. so thank you :)

But... I think it won't solve your problem if one of the packages will use different Vue version, because then one Vue version will be hoisted in your project's root node_modules and another in e.g. package1's node_modules.

correct! well, I think because it's monorepo, then all the versions of dependencies should be in the same version. like google does or rxjs...

I would just remove vue as dependency for any project in packages directory.

Well, I'll have another problem: typings and resolve vue from import statements when I use typescript.
Another problem:
I add to this project vuetify, I using this in package1 <v-app>
I got many errors say, No PostCSS Config found in:
error  in C:/coder/vue-lerna/node_modules/vuetify/src/stylus/components/_toolbar.styl

Module build failed (from C:/coder/vue-lerna/node_modules/postcss-loader/src/index.js):
Error: No PostCSS Config found in: C:\coder\vue-lerna\node_modules\vuetify\src\stylus\components
    at config.load.then (C:\coder\vue-lernanode_modules\postcss-load-config\src\index.js:55:15)

 @ C:/coder/vue-lerna/node_modules/vuetify/src/stylus/components/_toolbar.styl 4:14-206 14:3-18:5 15:22-214
 @ C:/coder/vue-lerna/node_modules/vuetify/lib/components/VToolbar/VToolbar.js
 @ C:/coder/vue-lerna/node_modules/vuetify/lib/components/VToolbar/index.js
 @ C:/coder/vue-lerna/node_modules/vuetify/lib/components/index.js
 @ C:/coder/vue-lerna/node_modules/vuetify/lib/index.js
 @ C:/coder/vue-lerna/packages/package1/src/shell.vue
 @ C:/coder/vue-lerna/packages/package1/src/index.ts
 @ C:/coder/vue-lerna/packages/package1/index.ts
 @ ./src/main.ts

What is missing here?


MNT Use GitHub Actions CI

Issue https://github.com/silverstripe/gha-ci/issues/11Workflow run https://github.com/creative-commoners/silverstripe-elemental/actions?query=branch%3Apulls%2F4.8%2Fmodule-standards

Updated


Make builtinsFS less special

@rpaquay
Give builtinsFS a distinct name (used to be a duplicate 'jsfs') and move it under the main FileSystemManager, but hide it from the end user (e.g. when running mount). This eliminates the need for special functions to find the builtins, which also fixes the introduced problem in the redirection PR ( #226 ), where every command entered on the command line is looked up in a universal way inside ExecuteContext.
With this PR, it's possible to manually cd builtins:/ and see what's available. I think it's a good thing for development, but if not, it can be fixed as well.

Hmm... Now that I see this pr, I am not sure we should go ahead with this change. It feels like we are doing this because #226 does not currently work for builtins, not because there is an actual need of the concept of "hidden" file system.
I'd wait for @rginda to give his thoughts on this.

#226 is just the immediate reason for doing this. It's possible to make #226 work with the way things are now. But a more fundamental reason is to make the code more streamlined, special case-free and easy-to-understand, while adding a potential way for a user to discover those commands (the latter can be done in many other ways, of course, like adding help or man to wash). That said, I don't mind waiting for @rginda; I'll make #226 work without this, then.


ascendex cannot recover from fail to cancel order errors

Describe the bug
// A clear and concise description of what the bug is.
This bug is present in both v1.0.0 and v1.1.0
For ascendex exchange, the bot cannot recover from fail to cancel order if the orders does not exists in the market.
bot have to be restarted to continue.
This is likely resulting from failed to create orders on the exchange as the bot detects there is a created order but the connector does not still has the order.
Steps To Reproduce
// A concise description of the steps to reproduce the buggy behavior:
Run any strategy on ascendex until market starts to fail. This may require some simulation by disconnecting and connecting.
If the order is treated as created on the bot while the exchange does not have, the bot will be stucked in fail to cancel order.
Screenshots
// If applicable, add screenshots to help explain your problem.
2022-02-13 14:45:05,007 - 1138414 - hummingbot.connector.exchange.ascend_ex.ascend_ex_exchange - ERROR - Failed to cancel order HMBot-BBOLUSD1644763433006692: Failed to cancel order - HMBot-BBOLUSD1644763433006692. Order not found.
Traceback (most recent call last):
  File "/root/mm6/hummingbot/connector/exchange/ascend_ex/ascend_ex_exchange.py", line 640, in _execute_cancel
    raise ValueError(f"Failed to cancel order - {order_id}. Order not found.")
ValueError: Failed to cancel order - HMBot-BBOLUSD1644763433006692. Order not found.

Release version
// Include your bot's version number (Can be found at the upper left corner of your CLI).
1.0.0 and staging 1.1
Attachments
// Please attach your config file and log file to help us debug. It would be difficult for us to help you without those!
WARNING: Do NOT publish any exchange API keys or your wallet's private key. Whoever has access to them may steal your assets!
Optional: your discord username:

This is indeed quite annoying. I think there needs to be some sort of internal mechanism to trust the exchange after X attempts to cancel an order, otherwise, HB will get stuck and does not continue creating limit orders.

Hi @leastchaos I think this is also related to a reported issue 4987, you may want to add comment to the ticket. Tagging this ticket now as duplicate/close


404 Not Found<EMAIL_ADDRESS>

Dear Devs,
I think it is not possible to install fsevents via
npm install fsevents
at the moment. Flatmap Stream seems to be removed.
https://www.npmjs.com/package/flatmap-stream
Or is there another way to use fsevents?

... ❯ npm install fsevents
npm ERR! code E404
npm ERR! 404 Not Found<EMAIL_ADDRESS>
npm ERR!      /Users/.../.npm/_logs/2018-12-04T20_28_31_056Z-debug.log

inside of the debug.log
6358 verbose type Error
6359 verbose stack Error: 404 Not Found<EMAIL_ADDRESS>6359 verbose stack     at fetch.then.res (/usr/local/lib/node_modules/npm/node_modules/pacote/lib/fetchers/registry/fetch.js:42:19)
6359 verbose stack     at tryCatcher (/usr/local/lib/node_modules/npm/node_modules/bluebird/js/release/util.js:16:23)
6359 verbose stack     at Promise._settlePromiseFromHandler (/usr/local/lib/node_modules/npm/node_modules/bluebird/js/release/promise.js:512:31)
6359 verbose stack     at Promise._settlePromise (/usr/local/lib/node_modules/npm/node_modules/bluebird/js/release/promise.js:569:18)
6359 verbose stack     at Promise._settlePromise0 (/usr/local/lib/node_modules/npm/node_modules/bluebird/js/release/promise.js:614:10)
6359 verbose stack     at Promise._settlePromises (/usr/local/lib/node_modules/npm/node_modules/bluebird/js/release/promise.js:693:18)
6359 verbose stack     at Async._drainQueue (/usr/local/lib/node_modules/npm/node_modules/bluebird/js/release/async.js:133:16)
6359 verbose stack     at Async._drainQueues (/usr/local/lib/node_modules/npm/node_modules/bluebird/js/release/async.js:143:10)
6359 verbose stack     at Immediate.Async.drainQueues [as _onImmediate] (/usr/local/lib/node_modules/npm/node_modules/bluebird/js/release/async.js:17:14)
6359 verbose stack     at runCallback (timers.js:696:18)
6359 verbose stack     at tryOnImmediate (timers.js:667:5)
6359 verbose stack     at processImmediate (timers.js:649:5)
6360 verbose cwd /Users/martin/Documents/Development/Projekte/project-x/vueql
6361 verbose Darwin 17.7.0
6362 verbose argv "/usr/local/Cellar/node/10.6.0/bin/node" "/usr/local/bin/npm" "install" "fsevents"
6363 verbose node v10.6.0
6364 verbose npm  v6.1.0
6365 error code E404
6366 error 404 Not Found<EMAIL_ADDRESS>6367 verbose exit [ 1, true ]

@bnoordhuis this comes from another package that requires flatmap-stream. I tested npm i fsevents in an empty folder it it works. Sorry for that!


chore(updatecli) update manifests for v0.17.0

Signed-off-by: Damien Duportal<EMAIL_ADDRESS>

I'm sad... I should have mentioned I was reviewing it...
Do you know if there a way to integrate these suggestions even if this PR is merged?

I'm sad... I should have mentioned I was reviewing it...
Do you know if there a way to integrate these suggestions even if this PR is merged?

Good question 🤔 I don't know. Let me try.


DRILL-4720: Fix SchemaPartitionExplorer.getSubPartitions method implementations to return only Drill file system directories

Added file system util helper classes to standardize list directory and file statuses usage in Drill with appropriate unit tests.
Fixed SchemaPartitionExplorer.getSubPartitions method implementations to return only directories that can be partitions according to Drill  file system rules (excluded all files and directories that start with dot or underscore).
Added unit test for directory explorers UDFs with and without metadata cache presence.
Minor refactoring.

Details in Jira DRILL-4720.

Addressed minor comment. Parth, thanks for code review!

ship it


the Get() method does not support extended struct

the Get() method does not work well when I use a extended struct like below:
type BaseDO struct {
	CreatedAt int64
	UpdatedAt int64
}

type User struct {
	Id int64
	Name string
	Email string
	Password string
	AddOn string
	BaseDO // extend two members from BaseDO
}

when I execute the code below, I got an error of not supported {0 0} as []:
u := User{
		Email<EMAIL_ADDRESS>	}
res, err := engine.Get(&u)

I wonder how should I handle this situation? There are many structs that need CreatedAt and UpdatedAt.
env:

golang 1.12.1 on osX 10.11
x-orm v0.7.1 from go mod

You should add a tag on BaseD0
 BaseD0 `xorm:"extends"`

Thanks a lot!


chore: add kernel ExpressionEvaluator

based on #1807
Description
In the effort to advance protocol support and move our internal APIs closer to the kernel library, it is advantageous to leverage the expression handling logic from kernel specifically for filtering actions etc.

Once this is merged in do you suggest we remove the CNF expressions we use for optimize? Seem like we should depreciate that interface and also create a bridge between string expressions and maybe extra code to convert to an equivalent Datafusion expression.

From the kernel side, the general idea is to have a way of defining expressions without additional dependencies. So yes, we should ten likely define conversions to datafusion expressions. I only looked a bit into our partition filters, if we could remove those too... From the python API side at least we probably want to keep CNF expressions around?


how to use application load balancing with vertica-python module

Could you please provide sample code to specify application load balancing as part opening connection with vertica python module.
{code}
'ConnectionLoadBalance' : 1
{code}

to say how to provide backend options to startup message flow? I looked at http://www.postgresql.org/docs/9.2/static/protocol-message-formats.html StartupMessage documentation, it is unclear how the multiple options are to be passed followed by the terminator. It is also noted that the run time parameters could be set outside the startup message.

sorry, but im not sure i understand the ask here.
vertica-python doesn't do any load balancing. if you want to load balance queries across your vertica cluster, that would have to be handled outside of this module.

Vertica has native connection load balancing. When enabled, you can connect to any node and it will redirect you to another node.  In order to accomplish this, the driver must allow the redirect (connect to a different node). I don't know much about the protocol behind this.  vsql and jdbc both can do this (with an option enabled). This could possibly be an enhancement, (I don't personally use this, I just thought I'd add my 2 cents).
https://my.vertica.com/docs/7.2.x/HTML/index.htm#Authoring/AdministratorsGuide/LoadBalancing/AboutNativeConnectionLoadBalancing.htm


Elevation for Stepper(horizontally)

Fixes https://github.com/flutter/flutter/issues/62957
Pre-launch Checklist

[x] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[x] I read the Tree Hygiene wiki page, which explains my responsibilities.
[x] I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
[x] I signed the CLA.
[x] I listed at least one issue that this PR fixes in the description above.
[x] I updated/added relevant documentation (doc comments with ///).
[ ] I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt.
[ ] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Hello @HansMuller
can you please review this PR?
Thasnks

I've been out for a while. Will take a look soon.

hello @HansMuller
can you please take a look at this PR?
Thanks

This is looking great, @Abhishek01039. If you add those material.elevation checks like I suggested in a comment and apply Hans' other docstring tweaks, this should be ready to go.


Simplify similar registers

Changes an Optional<List<?>> to a plain List<?>, and simplifies a conditional in a template.

Observed Phil making these changes, all is good.


Bluesky: refresh DID doc when user follows ap.brid.gy

Evidently we're not refreshing a user's DID doc when they first follow ap.brid.gy, which means we occasionally have a stale wrong handle.
Example: did:plc:usl4pnhyasr2moto7elbvhw6 . Changed their handle from cyrneko.codeberg.page to cyrneko.eu at 2024-09-14 12:59 PM PT, then followed ap.brid.gy at 2024-09-15 18:31:06 PT. We already had their DID doc from beforehand, with cyrneko.codeberg.page, and we didn't reload it, so we bridged them with that handle.
Related: #1017, #1201

Seeing this for my account (should be @transpile.net, but it got picked up as @caffein.ated.io)

@danielledeleo sorry for the trouble! I've refreshed your DID doc, feel free to try again.

Fixed! Thanks again for reporting.


HDDS-1191. Replace Ozone Rest client with S3 client in smoketests and docs

As it's discussed in the the parent jira the rest support for Ozone Client protocol can be removed to use S3 Rest API instead of that.
Some of the unit tests are already disabled, so it seems to be better to remove it from the documentation (and from the smoketests).
See: https://issues.apache.org/jira/browse/HDDS-1191

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
36
Docker mode activated.

_ Prechecks _

+1
@author
0
The patch does not contain any @author tags.

-1
test4tests
0
The patch doesn't appear to include any new or modified tests.  Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

0
mvndep
58
Maven dependency ordering for branch

+1
mvninstall
1088
trunk passed

+1
compile
928
trunk passed

-1
mvnsite
113
dist in trunk failed.

+1
shadedclient
2921
branch has no errors when building and testing our client artifacts.

+1
javadoc
46
trunk passed

_ Patch Compile Tests _

0
mvndep
24
Maven dependency ordering for patch

-1
mvninstall
17
dist in the patch failed.

+1
compile
902
the patch passed

+1
javac
902
the patch passed

-1
mvnsite
28
dist in the patch failed.

-1
whitespace
0
The patch has 3 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply

+1
shadedclient
599
patch has no errors when building and testing our client artifacts.

+1
javadoc
43
the patch passed

_ Other Tests _

+1
unit
26
docs in the patch passed.

-1
unit
28
dist in the patch failed.

+1
asflicense
38
The patch does not generate ASF License warnings.

4924

Subsystem
Report/Notes

Docker
Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/hadoop-multibranch/job/PR-529/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/529

Optional Tests
dupname  asflicense  mvnsite  compile  javac  javadoc  mvninstall  unit  shadedclient

uname
Linux 07ed38007244 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / 538bb48

maven
version: Apache Maven 3.3.9

Default Java
1.8.0_191

mvnsite
https://builds.apache.org/job/hadoop-multibranch/job/PR-529/1/artifact/out/branch-mvnsite-hadoop-ozone_dist.txt

mvninstall
https://builds.apache.org/job/hadoop-multibranch/job/PR-529/1/artifact/out/patch-mvninstall-hadoop-ozone_dist.txt

mvnsite
https://builds.apache.org/job/hadoop-multibranch/job/PR-529/1/artifact/out/patch-mvnsite-hadoop-ozone_dist.txt

whitespace
https://builds.apache.org/job/hadoop-multibranch/job/PR-529/1/artifact/out/whitespace-eol.txt

unit
https://builds.apache.org/job/hadoop-multibranch/job/PR-529/1/artifact/out/patch-unit-hadoop-ozone_dist.txt

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-529/1/testReport/

Max. process+thread count
411 (vs. ulimit of 5500)

modules
C: hadoop-hdds/docs hadoop-ozone/dist U: .

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-529/1/console

Powered by
Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

:+1:  I will commit this soon.


Please Provide a Feature to Limit the Scope of Custom Fields

User Story
As a Network Consultant, I often need to add data that is specific only to a single client's network, and can use custom fields for that, currently.  When this custom data references things like hardware that is used in many networks outside of a specific client, the custom fields are present across all data types.
I want to be able to limit the scope that a custom field applies to, such as Tenant, Site, Location, etc., so that the custom fields do not apply to other tenants data that do not have use for said custom field(s).
I know this is done when...

Custom fields are are restricted to the selected scope:
Custom fields do not appear under tenants that do not make use of the custom field.

Real-world Example:
As a network consultant, we worked on an engagement with a client that was running a 50-building campus network with JunOS Fusion Enterprise on the EX platform (ex9204 as aggregation, qfx-5100 and ex4300s as satellites), and were planning a migration to EVPN-VxLAN.  There was a lot of data in the configuration that wasn't anywhere else, and wanted to store that data to make creation of the "unfused" configuration simpler.
We need to store the following data for each device:

Legacy FPC number
Legacy Chassis ID
Legacy Cluster

The only seemingly appropriate place to store these custom fields was the device-type.  Resultantly, all other clients that use any EX9204, QFX5100, or EX4300 would end up inheriting the same custom fields.  If you think I should be storing this elsewhere, please let me know.
So that confusion for clients is kept to a minimum, I want to limit the custom fields that Hospital A uses from being seen by Real Estate Company A, and vice versa.
I know this is done when the custom fields can be arbitrarily scoped.
Database Changes (Optional)
I am sure that this will require database schema changes, but am unsure how big of a change this is.  It seems like it might be pretty intensive.
External Dependencies (Optional)
Unsure, but I don't think so.
Use Cases

#2930

TODO:

[ ] #1621

I think I may be a bit premature with this request, as I am going by my experience with Netbox.

Thank you for opening this, and why did you close it already? 😀
We can use this as the issue to track the 3rd item down in the custom field section of #768. It is no doubt not premature. I think these are aligned.
I’m also curious on your scenario. Are you staging client deployments in a single instance or truly allowing multiple clients to login in a single instance of Nautobot?

I think this feature would be a great addition and it's similar to what we are doing currently with the filter for the relationships
It would be even better implemented if we can leverage some Dynamic Group #896,

100%. The plan is definitely to use #896 in order to apply CFs and other extras/extensibility features...

I too would find this supremely useful.   As a simple example, we track VPN tunnels as "Circuit" objects.  However we have to add numerous custom fields that only should apply when circuit type = VPN, these fields do not make sense under normal circumstances.  Example fields include things like DH Group, Encryption, Hash, etc.

I think the importance of this will be even greater with moving Regions/Sites to the Location/Location type model. There are Custom Fields that I only want on Sites, as they don't make sense on Regions. But when we move to everything being a Location, I now have those custom fields on all Locations, since I can't filter them on Location Type.  In my mind, this would utilize the filter function that already exists and works on the Relationships.

Is this feature still in the plan to be added to nautobot ?
Thanks


Subflow context (node/flow) is not reflected in «Context Data» tab

What are the steps to reproduce?
[{"id":"a2576be0.69ed68","type":"subflow","name":"Subflow 1","info":"","in":[{"x":50,"y":30,"wires":[{"id":"20e27550.2867aa"},{"id":"a66758e9.083618"}]}],"out":[]},{"id":"20e27550.2867aa","type":"change","z":"a2576be0.69ed68","d":true,"name":"","rules":[{"t":"set","p":"payload","pt":"flow","to":"payload","tot":"msg"}],"action":"","property":"","from":"","to":"","reg":false,"x":300,"y":160,"wires":[[]]},{"id":"a66758e9.083618","type":"function","z":"a2576be0.69ed68","name":"","func":"context.set('foo', 'bar')         // not showing up\nflow.set('foo', 'bar')            // not showing up\nflow.set('$parent.foo', 'bar')    // ok\nglobal.set('foo', 'bar')          // ok\n","outputs":1,"noerr":0,"x":270,"y":220,"wires":[[]]},{"id":"9125728e.3a84e","type":"subflow:a2576be0.69ed68","z":"e4f46c53.4616a","name":"","env":[],"x":180,"y":300,"wires":[]},{"id":"d07025c6.33da38","type":"inject","z":"e4f46c53.4616a","name":"","topic":"","payload":"","payloadType":"date","repeat":"","crontab":"","once":false,"onceDelay":0.1,"x":180,"y":260,"wires":[["9125728e.3a84e"]]}]

What happens?
context.set('foo', 'bar')         // not showing up
flow.set('foo', 'bar')            // not showing up
flow.set('$parent.foo', 'bar')    // ok
global.set('foo', 'bar')          // ok

Please tell us about your environment:

[ ] Node-RED version: 1.0.6
[ ] Node.js version: 12.11.1; 10
[ ] Platform/OS: macOS, Linux

Yup - this is a long standing issue that the context sidebar doesn't play well with subflows.
But the issue is a bit more complex.
When you are viewing a subflow in the editor, you are viewing the template of the subflow, not a specific instance. There could be 10+ instances of the subflow in your workspace. When you select a node inside a subflow, there would then be 10 + separate copies of that node running - each with its own context data. That is why the editor can't display the context data for a node inside the subflow - it doesn't know which instance of the subflow you want to look at.

Yeah that makes sense 🙂
Thanks for clarification!

That is why the editor can't display the context data for a node inside the subflow - it doesn't know which instance of the subflow you want to look at.

Could it not simply show up in the "Node" section when the subflow instance is selected?
Subflow context is specific to the subflow instance which is represented by that node, so it seems to fit. It might not be very handy while editing the subflow, but it'd be better than not having it available at all, which is the current situation...
Unless I'm missing something and there's some other node-specific context that might be more relevant for subflow nodes?
Renaming the "Node" section to "Subflow" in that case would also be a nice touch, but I'd say it's optional (especially if the documentation mentions where to find that context)

I suggest the following UI (if everything else would be too invasive or confusing):

If a subflow is shown in the editor then a dropdown will appear at the top of the context tab to select the current subflow instance to work with.
This dropdown is by default initialized with the most recently selected subflow node of that type, so if I double-click a subflow node and then click "edit subflow template" I would immediately be able to view the context data of that subflow instance I am most likely interested in without any further action. Of course I can select another instance at any time.

Hi,
hitting on a problem exactly as described here.  I have xx instances of a subflow, each with their own internal context data.  Now I noticed I can not access this data from the side bar.  Is this still an open issue?  If so, any suggestions for a workaround?  I use context data all around, but without access I have no idea how to do debugging.

Hi, bumping this issue again.  this is quite an annoying problem when trying to quickly debug a problem in a subflow instance.  Any chance this issue will be covered on a short term?  If not, any suggestion for a workaround?

Is there any progress?
Would really be nice to at least have the subflows flow context shown as the nodes context as fvbommel proposed, when an instance of the subflow is selected in the node editor.
The change to the UI should be minimal (if at all), but the benefit for debugging is big (of course this can than be refined to be nicer, like showing "Subflow" instead of "Node", but this is all not necessary for a first, useful iteration!).

If so, any suggestions for a workaround? I use context data all around, but without access I have no idea how to do debugging.

One way to debug in some limited way is to use the status output: In the Subflow template itself I can wire the status output to something that will output debug information, for example I can either

use a status node within the subflow and wire it to the status output to be able to mirror the status line of any node within my subflow to the outside without having to write code
use a function node inside the subflow and within that produce a short line of debug text (maybe a short summary of parts of the subflow context) and write that to node.status and select that node in above mentioned status node
or use any other means to rewrite the payload of a msg to contain the needed debug information in one short line of text and route this to the status output of the subflow.

That way you can have a line of text and a colored icon below each instance of the subflow that is updated in real time and reflects the current state of whatever you are currently trying to debug within that subflow.
This is currently the only way I have found to be able to look inside a running subflow instance to watch parts of its state change in realtime. Unfortunately you have to know exactly what you are interested in and set this up BEFORE the problem occurs that you want to debug.

The idea of this feature request is to have insight of the state (actually the context) of an instance of a subflow, similar to how you can check the context of a (function) node.
My "workaround" for this is now to

only use flow context in the function nodes inside the subflow
Having a function node (I named it debug) in the signal flow directly after the input node of the subflow with the following code:

if (msg.debug_subflow !== undefined) {

    try {

        node.warn(flow.get(msg.debug_subflow))

    } catch (error) {

        const flow_keys = flow.keys()
        const debug_object = {}

        for (let key of flow_keys) {
            debug_object[key] = flow.get(key)
        }

        node.warn(debug_object)

    }

} else {

    return msg

}

(modify ⬆ as you like)

Inject a message with a debug_subflow property to get a warn message (node.debug would probably be the right thing to do, but I want to see it on the side panel) in the log with:

all flow keys from the instances context when debug_subflow is set to a key that does not exist (e.g. use true or simply keep the default timestamp of the inject node)
only one key value form the instances context when debug_subflow is set to a key that does exist (can be helpful if you have lots of stuff in the context but are only interested in one in the moment)

Of course you can go all fancy with change and (eventually needed) delay nodes and a branched signal flow to get automatic log messages after the instance processes a message. But that totally depends on your needs and what fits best for you... 😉


Revamped iomgr's callback mechanism

This is a tentative (see discussion below) pull request for the modification of the way the iomgr deals with callbacks.
In particular, the allocation of the callback (now exposed and called grpc_iomgr_cb) is the responsibility of the iomgr user. In some cases, this allows the user to reduce the number of mallocs and/or group them into single chunk.
Discussion: In instances where it isn't possible to anticipate the number of necesary callback allocations,  the callback needs to be allocated "in situ" right before passing it over to the iomgr. The release of these allocations is currently performed conditionally inside iomgr (depending on whether the callback has been marked as "externally managed").
The alternative is to make the deallocation part of the callback itself. However, this introduces a non trivial amount of complexity due to not always having control over the callback function. For instance, fd_posix.c:notify_on creates a callback whose function comes from the outside (closure->cb). In other cases, even when we have access to the callback function, such as credentials.c:on_simulated_token_fetch_done, they'd have to be modified to receive a pointer to its enclosing grpc_iomgr_cb.
Both these scenarios can be addressed by creating wrapper around callbacks that'd run whichever callback function and then free itself. However, a functionally equivalent approach is have the iomgr conditionally free(), as described.

So I think I dropped a suggestion or two that lets us remove the is_ext_managed thing completely - take a look and let me know what you think. If there's a case that's troubling and I didn't comment on it, then probably I missed it this morning and flag it to me.

PTAL. Addressed all comments except for one that fell through the cracks (to be had for breakfast tomorrow).
All tests pass, incluiding "asan" (inasmuch it fails no more than HEAD :))
(also, I'm not sure why github talks about "outdated diffs". I haven't rebased, hmm).

Comments addressed. Thanks! PTAL.
Two things remain:

The single use of managed_closure in security/credentials.c
Addition of comments if the newly introduced code looks good.

@nicolasnoble Agreed. Will do once the code changes behind this pull req. crystallize.

Ok, this pull req. should be all ready now. I've included some comments in iomgr.h. @ctiller could you pleasemake sure they are accurate?

Green! (modulo stuck coveralls)

Looks good.

Done.

Actually done this time :)

Green!


regarding YOURDATASET format

Thank you for making sharing amazing code.
I have a question regarding YOURDATASET format
YOURDATASET
case1
CT1 containing dicom files
CT2 containing dicom files
case2
CT1 containing dicom files
CT2 containing dicom files
...
Above is the sample data format that you provide.
And below is the data sample that I am using
case 1

1 (another folder)

11.dcm

12.dcm

13.dcm....

-2 (another folder)
--21.dcm
--22.dcm
--23.dcm
case 2

1 (another folder)

11.dcm

12.dcm

13.dcm....

-2 (another folder)
--21.dcm
--22.dcm
--23.dcm

is this format correct? Can you explain in more detail the proper format I should use?

Yes. It looks correct.

What is the difference between CT1 and CT2? Is CT1 enhanced CT and CT2 non-enhanced CT? Thanks

It would depend on what you are trying to do. If you are trying to generate synthetic enhanced CT out of non-enhanced CT, CT1 would be non-enhanced and CT2 would be enhanced. If you are trying to generate synthetic non-contrast CT out of enhanced CT, it would be the opposite.


feat: Add zfs-dracut to fedora-coreos and ucore

Add zfs-dracut to fedora-coreos and ucore. zfs-dracut is necessary to include zfs when rebuilding initrd.

Add zfs-dracut to fedora-coreos and ucore. zfs-dracut is necessary to include zfs when rebuilding initrd.

@twiest thank you for the PR!
I wonder... we haven't yet done it in ucore, but the atomic desktop images in ublue-os org rebuild the initrd as part of image build.
see: https://github.com/ublue-os/main/blob/main/initramfs.sh
I am thinking the package addition makes sense as you've done it, but also, we could rebuild initrd as part of the ucore builds and pre-include zfs so a user need not do so.  I wouldn't do this on the fedora-coreos images, because my intent with those is to do no more than install the minimally required packages.
Thoughts?

I love that idea!
I believe I would personally still need this as I rebuild the initrd myself for other reasons (like adding more dirs to / for mounting points before it is set read-only).


Better expose licensing FAQs

Fixes #5849.

This change is

Online preview: http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/03806b94fd355158e746c85648133ae1052b4d1d/
Edited pages:

v19.1/frequently-asked-questions.md
v19.1/index.md
v19.2/frequently-asked-questions.md
v19.2/index.md
v20.1/frequently-asked-questions.md
v20.1/index.md

LGTM!


Create APIs to know when bucket brigade is being hampered by CPU and/or bandwidth contention

Per Facebook conversation. These can only be heuristics but that might be good enough.

Proposal was something like:

"networkFailed" event (would always fire alongside "connectivityChange", but would indicate that it was disconnected due to problems and not because we asked it to)
"audioLag" event (would fire probably instead of the current "your computer is too slow" error message; we could lower the threshold for firing, and we could include some estimate of "how bad" the problem is in the event.)

We could also have a "playBufferUnderflow" event, if we want to capture that -- this indicates that we ran out of audio to play (at least temporarily), which will glitch the user's local audio (but not automatically their outgoing audio, though the two are likely associated.) I usually find that this is associated with either CPU or network problems, but sometimes transient and not bad enough to trigger the bigger issues (network disconnection / the extreme audio lag error.)


Apply custom background to selected date

Change selectedDateBackground (accepts only color) to selectedDateBackgroundDrawable (accepts drawable).
You can set background from builder, from HorizontalCalendar object, or from xml.
#40

Hello @Zey-Uzh
Thanks for your contribution, but I can't merge this pull request for multiple reasons:
1- selected Background drawable is not being applied in the adapter.
2- selection view is now a lot shorter for some reason.
3- you made some adjustments to the item_calendar.xml which I don't see any need for.

Greetings, thank you for your comments. I'll try to fix these problems.

I returned the original layer and made the full width for the selection view. And now you can hide the bottom selection line by setting the color to Color.TRANSPARENT

@Zey-Uzh  I have made a commit as well fixing some issues and merged your pull request,
Thanks for your contribution.


Explore hot reloading

I might be able to replace an entire module when it changes now that we are using SystemJS in a more idiomatic fashion.

Each module could be hotswapped, and then if any html or images change, we could just set the html on our own...could it be possible? Or we could just reload the web component that changed and reinsert it into the DOM

Hmmm...I'm not sure hot reloading is worth it. Just refreshing the page on file changes I think is good enough


Make repo REUSE compliant

See: https://reuse.software/

@fwege Do you have any preference on a license?

Done. I've choosed Apache-2.0 for the code contributed by OPAL-RT


Convert network db to use new async-service API

What was wrong?
The networkdb component isn't using the nice new async-service APIs
How was it fixed?
Converted the component to use the new async-service APIs
Cute Animal Picture

Test failures are only due to a change in logging messages.  I'm going to wait until https://github.com/ethereum/async-service/pull/13 is merged and released to clean this up.

Failures need a new release of the async-service library to have the proper logging statements available.  Probably something we can get done tomorrow or Wednesday if we get a few of the in-progress bits moved through.


Integrate with Elyra?

We could potentially add some basic integration with ELyra by adding a streamlit button to the toolbar on the python editor. Which side this should be done from and how closely we integrate should be decided based on the results of #5

This has been addressed in 85bf7490cea23e253eda126df6115b2557b3cddc which adds the button to the editor whether or not Elyra is installed

Support for Elyra specifically was added in 9749c40


Run unit tests under MPI

All sorts of bugs creep in when you don't do this automatically... we desperately need to get this set up on GitHub actions. We might need to build our own container that has HOOMD and LAMMPS stuffed in it, along with a compatible MPI library. We should then be able to install all of our python requirements from pip.

Getting MPI properly configured for testing is difficult. I am going to leave this open, but it needs to be thought through carefully.


Allow pcluster ssh to use MasterPrivateIP

Environment:

aws-parallelcluster-2.6.0
Configuration file: any

Bug description and how to reproduce:
The command pcluster ssh always uses MasterPublicIP. We use cloud9 to create clusters as we cannot install awscli locally and also have no access to the secret keys to configure the command line if we did.
We are not allowed to have port 22 open to the world so have a security group to address that. By adding the security group from the cloud9 instance it means that whatever IP address the cloud9 instance gets, it can connect to the master node of the cluster. However, ssh only works if I ssh to MasterPrivateIP and not MasterPublicIP and pcluster ssh always uses MasterPublicIP. Can there be a flag added to pcluster ssh to allow ssh to use MasterPrivateIP?
SupportOrg:~/.parallelcluster $ pcluster status pmjmon30-02
Status: CREATE_COMPLETE
MasterServer: RUNNING
MasterPublicIP: <IP_ADDRESS>
ClusterUser: ec2-user
MasterPrivateIP: <IP_ADDRESS>
SupportOrg:~/.parallelcluster $ pcluster ssh pmjmon30-02 -o ConnectTimeout=5
ssh: connect to host <IP_ADDRESS> port 22: Connection timed out
SupportOrg:~/.parallelcluster $ ssh<EMAIL_ADDRESS>-o ConnectTimeout=5
ssh: connect to host <IP_ADDRESS> port 22: Connection timed out
SupportOrg:~/.parallelcluster $ ssh<EMAIL_ADDRESS>-o ConnectTimeout=5
Last login: Mon Mar 30 15:36:40 2020 from ip-10-0-0-166.ec2.internal

       __|  __|_  )
       _|  (     /   Amazon Linux 2 AMI
      ___|\___|___|

https://aws.amazon.com/amazon-linux-2/
1 package(s) needed for security, out of 32 available
Run "sudo yum update" to apply all updates.

Hi @PhilipMorrisJones
I'm marking this as a feature request.

This would also be good to have for NICE DCV.


Unity Remoting needs HolographicRemotingPlayer v 2.10

Describe the bug
The latest version of HolographicRemoting player on HoloLens 2 does not work with Unity 2018.4.12f1's holographic remoting emulation. An older version of the remoting player (v 2.10.10) needs to be installed.

I'm not able to repro this. I'm currently using the latest remoting player (2.0.16) with Unity 2018.4.12 and  the 1.0.15 WMR Unity package.

I had the same setup but it was not working on my machine. My setup was:
latest remoting player (2.0.16) with Unity 2018.4.12 and the 1.0.15 WMR Unity package.
It seems like it may work on some machine / network configurations, but not others. Perhaps we should try testing on a few more machines to determine if my machine is in the minority, or majority. We could always provide the 2.10 packages in case some people hit the same issue as I did.

@CDiaz-MS was also able to successfully remote using the latest player.


[Feature Request] A chapter date format from J2K

Why/User Benefit/User Problem
Well, It's more or a QOL feature, isn't really needed but makes it look better Imo and it's easier to tell when a chapter came out rather than having to look at the full date.
What/Requirements
When a chapter comes out, instead of the date it'll show how long ago it came out eg: 10 minutes ago, 5 hours ago etc
(Images from J2K)

After 24 hours, it'll show x days ago and after 7 days It'll show the date like Dec 11, 2020 etc
How it currently shows in SY:

How it'll look after (img from J2K):

Much needed as it gives a memory click that the chapter is new and doesn't makes us focus on to see what date it is today.

Much needed as it gives a memory click that the chapter is new and doesn't makes us focus on to see what date it is today.

Ageee

Yeah i just migrate to SY from J2K and i miss this feature

This was added in main Tachi so SY got it


raw table reference fact model

Describe the feature
Create a model that parses SQL using regex to identify raw table references in model code
Who will this benefit?
All y'all

➕ To this one! I would love to see a table like the following:

model
explicit_reference

lost_revenue
raw_tpch.tpch_sf1.orders

lost_revenue
raw_tpch.tpch_sf1.customer

lost_revenue
raw_tpch.tpch_sf1.lineitem

lost_revenue
raw_tpch.tpch_sf1.nation

UK_Lowcost_Brass_Suppliers
raw_tpch.tpch_sf1.partsupp

Throwing some example code here which uses the tpch_sf1 data sets, although the second references some other models
I have in my project. Feel free to ping me when this is being worked on if you need access to the code for testing! I should have a complete version then, but right now these models are a WIP for a Coalesce workshop so there's not a good version I can link here.
I have two models which use explicit references:
lost_revenue.sql:
WITH

-- Only orders which tie back to a real customer record
ro as (
    select
        o.o_orderkey,
        c.c_custkey
    from raw_tpch.tpch_sf1.orders o
    inner join raw_tpch.tpch_sf1.customer c
        on o.o_custkey = c.c_custkey
),

rl as (
    SELECT c.c_custkey
    ,c.c_name
    ,sum(revenue) AS revenue_lost
    ,c_acctbal
    ,n.n_name
    ,c_address
    ,c_phone
    ,c_comment
    FROM ro left join (SELECT l.l_orderkey AS ORDER_ID, o.o_custkey AS CUSTOMER_ID, SUM(l.l_extendedprice * (1 - l.l_discount)) AS REVENUE
        FROM raw_tpch.tpch_sf1.lineitem l LEFT JOIN raw_tpch.tpch_sf1.orders o ON l.l_orderkey = o.o_orderkey
        WHERE o.o_orderdate >= '1994-01-01' AND o.o_orderdate < '1994-04-01' AND l.l_returnflag = 'R' GROUP BY o.o_custkey, l.l_orderkey
    ) lo on lo.ORDER_ID = ro.o_orderkey and lo.CUSTOMER_ID = ro.c_custkey
    LEFT JOIN raw_tpch.tpch_sf1.customer c ON c.c_custkey = lo.CUSTOMER_ID LEFT JOIN raw_tpch.tpch_sf1.nation n ON c.c_nationkey = n.n_nationkey
    WHERE lo.CUSTOMER_ID is not null GROUP BY c.c_custkey,c.c_name,c.c_acctbal,c.c_phone,n.n_name,c.c_address,c.c_comment ORDER BY revenue_lost DESC
)

select * from rl

uk_lowcost_brass_suppliers.sql:
select
    e.p_name            AS Part_Name,
    e.p_retailprice     AS RetailPrice,
    e.s_name            AS Supplier_Name,
    e.p_mfgr            AS Part_Manufacturer,
    e.s_address         AS SuppAddr,
    e.s_phone           AS Supp_Phone,
    ps.PS_AVAILQTY      AS Num_Available

from {{ ref('EUR_LOWCOST_BRASS_SUPPLIERS') }} e
LEFT JOIN {{ source('TPCH_SF1', 'SUPPLIER') }} s on e.S_NAME = s.S_NAME
LEFT JOIN
    raw_tpch.tpch_sf1.partsupp ps
on e.P_PARTKEY = ps.PS_PARTKEY
    and s.S_SUPPKEY = ps.PS_SUPPKEY

where n_name = 'UNITED KINGDOM'

I will give this one a go in the next days/weeks.


Outreach sprint

this is a thing i can probably help w/

oh my god this has been so long

we started developing it before knowing there was a show. they've produced and filmed and aired the show in the same amount of time.

It has been long enough that I have now read the entire first trilogy and am onboard with this project.  Also I've started reading the second trilogy.

thereby making it productive procrastination
On Mon, Nov 4, 2019 at 4:43 PM Ted Han<EMAIL_ADDRESS>wrote:

It has been long enough that I have now read the entire first trilogy and
am onboard with this project. Also I've started reading the second trilogy.
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
https://github.com/BadIdeaFactory/the-emoji-compass/issues/32?email_source=notifications&email_token=AAEVYOFKNOZWT2MZ4QI2KT3QSA7IRA5CNFSM4FHZTP42YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEC7WAWQ#issuecomment-549412954,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAEVYOF5IKBR4VLAIN7IYDDQSA7IRANCNFSM4FHZTP4Q
.


Should 'at all times' and 'at some times' be included in the reference?

From<EMAIL_ADDRESS>on June 27, 2012 17:04:02
I am trying to determine which parts of BFO-OWL should be included in the Relations document I am working on. In particular I wonder if the BFO Reference should include the "Temporally quantified" relations from the owl spec. An example is 'has_participant_at_some_time'
Should the BFO Relations Reference contain these terms?
Original issue: http://code.google.com/p/bfo/issues/detail?id=72

From<EMAIL_ADDRESS>on June 28, 2012 09:50:58
What is the intent of the BFO Relations documents? If it is just grouping what is in the BFO reference, then it should just include what is in there. If it is intended that the relations disappear from the reference and that the BFO Relations document becomes the reference then it should be in there.
In any case, I think they should appear either in the reference or the relation document (depending on the above) as we agreed that the OWL file would be a translation of the reference.

From<EMAIL_ADDRESS>on June 29, 2012 13:24:45
At meeting of 2012-06-29 we agreed that the OWL relations should be in the relations document, and that when everything is done, there should be one document that merges the reference and the relations (also a reference).
Also: We need an index for the reference document so we can easily find definitions.
Status: Started


Is there a way to POST/PATCH/DELETE an application?

I only see the function of read content from an application from your api? Do you know any example of POST/PATCH/DELETE?

Hi @macsir,
Currently there is only a get method in the application service.

I am looking at the API description and it looks like that there are no special API functions for applications. Is there another way to access them though?

Hi @marfrit,
here is a sample how to retrieve an application and store it as an xlsx file.
import configparser

from TM1py import TM1Service

config = configparser.ConfigParser()
config.read(r'..\config.ini')

with TM1Service(**config['tm1srv01']) as tm1:
    # path in TM1 Application-Tree
    path = 'Finance/P&L.xlsx'

    # get the application
    application = tm1.applications.get(path)

    # write it to xlsx file
    application.to_xlsx("out.xlsx")

I only see the function of read content from an application from your api? Do you know any example of POST/PATCH/DELETE?

HI @macsir,
I created yesterday a pull request with the POST/DELETE methods. If Marius will accept it, then the functions will be available in master. PATCH is not supported by the REST API yet. Maybe IBM will introduce it in the future.

@tombrzy Hi, I figured out DELETE later but for forgot to update here. Anyway, I will check out your codes. Thanks.

#192 just got merged into the master branch.
It covers get, create, and delete operations for applications.


From "mouse button" to "mouse button + key"?

I don't know if it's a bug or if I'm not using it correctly: I'm trying to bind button3 to spacebar+button1. My last try was:
                            {
                                "conditions": [
                                    {
                                        "bundle_identifiers": [
                                            "com\\.adobe\\.illustrator"
                                        ],
                                        "type": "frontmost_application_if"
                                    }
                                ],
                                "from": {
                                    "modifiers": {
                                        "optional": [
                                            "any"
                                        ]
                                    },
                                    "pointing_button": "button3"
                                },
                                "to": [
                                    {
                                        "key_code": "spacebar",
                                        "pointing_button": "button1"
                                    }
                                ],
                                "type": "basic"
                            }

I'm using last beta that enables mouse actions (Karabiner v11.1.11)
Could anyone help?
Thanks!

up

up


Add [annotation] test case for ServiceDefinitionBuilderTest & remove unused parameter

What is the purpose of the change
Add [annotation] test case for ServiceDefinitionBuilderTest & remove unused parameter

Codecov Report

Merging #8788 (d48b2c1) into 3.0 (1b100f8) will increase coverage by 0.14%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##                3.0    #8788      +/-   ##
============================================
+ Coverage     63.70%   63.84%   +0.14%
- Complexity      312      313       +1
============================================
  Files          1145     1151       +6
  Lines         48188    48334     +146
  Branches       7255     7259       +4
============================================
+ Hits          30699    30860     +161
+ Misses        14123    14093      -30
- Partials       3366     3381      +15

Impacted Files
Coverage Δ

.../metadata/definition/builder/ArrayTypeBuilder.java
80.00% <ø> (ø)

...data/definition/builder/CollectionTypeBuilder.java
64.28% <ø> (ø)

...o/metadata/definition/builder/EnumTypeBuilder.java
77.27% <ø> (ø)

...bo/metadata/definition/builder/MapTypeBuilder.java
72.41% <ø> (ø)

...bbo/metadata/definition/TypeDefinitionBuilder.java
92.00% <100.00%> (ø)

...ian2/dubbo/AbstractHessian2FactoryInitializer.java
81.81% <0.00%> (-18.19%)
:arrow_down:

...va/org/apache/dubbo/metadata/RevisionResolver.java
50.00% <0.00%> (-16.67%)
:arrow_down:

...bbo/common/threadlocal/InternalThreadLocalMap.java
74.02% <0.00%> (-15.17%)
:arrow_down:

...common/serialize/hessian2/Hessian2ObjectInput.java
50.00% <0.00%> (-14.00%)
:arrow_down:

...va/org/apache/dubbo/remoting/exchange/Request.java
75.43% <0.00%> (-12.80%)
:arrow_down:

... and 133 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1b100f8...d48b2c1. Read the comment docs.


[Fe] dark mode enhancement in download page

Actual Behaviour
In dark mode
Dialogue appearing after clicking Download button in download page does not follow dark mode
Expected Behaviour
Dialogue box should also be following dark mode
Steps to reproduce it

Goto apisix.apache.org -> click downloads -> click download button

Screenshots of the issue

Would you like to work on the issue?
yes i would like to work in this issue,  but as this could be the good first issue , i would like new committers to give a PR :smiley:

sure


feat: Add logging info if Boiler simulator is enabled/disabled

Please provide us with the following information:

This issue is for a: (mark with an x)
- [ ] bug report -> please search issues before submitting
- [x] feature request
- [ ] documentation issue or request
- [ ] regression (a behavior that used to work and stopped in a new release)

Minimal steps to reproduce

Any log messages given by the failure

Expected/desired behavior
When implemented, a new log message should be written and tell if Boiler Simulation is enabled/disabled.
OS and Version?

Windows 7, 8 or 10. Linux (which distribution). macOS (Yosemite? El Capitan? Sierra?)

Versions

Mention any other details that might be useful

Thanks! We'll be in touch soon.

PR #39


[Request for External] EnqueueSyncJob(...) in 5330 "CRM Integration Management"

Describe the request
Please make these procedures public so they can be reused by custom integration. One is currently local, the other one is onprem only.
Codeunit 5330 "CRM Integration Management"
    local procedure EnqueueSyncJob(IntegrationTableMapping: Record "Integration Table Mapping"; RecordID: RecordID; CRMID: Guid; Direction: Integer): Boolean
    var
        CRMSetupDefaults: Codeunit "CRM Setup Defaults";
        IntegrationRecordSynch: Codeunit "Integration Record Synch.";
    begin
        IntegrationTableMapping.Direction := Direction;
        if Direction in [IntegrationTableMapping.Direction::Bidirectional, IntegrationTableMapping.Direction::FromIntegrationTable] then
            IntegrationTableMapping.SetIntegrationTableFilter(GetTableViewForGuid(IntegrationTableMapping."Integration Table ID", IntegrationTableMapping."Integration Table UID Fld. No.", CRMID));
        if Direction in [IntegrationTableMapping.Direction::Bidirectional, IntegrationTableMapping.Direction::ToIntegrationTable] then
            IntegrationTableMapping.SetTableFilter(IntegrationRecordSynch.GetTableViewForRecordIDAndFlowFilters(IntegrationTableMapping, RecordID));
        AddIntegrationTableMapping(IntegrationTableMapping);
        Commit();
        exit(CRMSetupDefaults.CreateJobQueueEntry(IntegrationTableMapping));
    end;

    [Scope('OnPrem')]
    procedure EnqueueSyncJob(IntegrationTableMapping: Record "Integration Table Mapping"; SystemIds: List of [Guid]; CRMIDs: List of [Guid]; Direction: Integer; SynchronizeOnlyCoupledRecords: Boolean): Boolean
    var
        CRMSetupDefaults: Codeunit "CRM Setup Defaults";
        IntegrationRecordSynch: Codeunit "Integration Record Synch.";
    begin
        IntegrationTableMapping.Direction := Direction;
        if Direction in [IntegrationTableMapping.Direction::Bidirectional, IntegrationTableMapping.Direction::FromIntegrationTable] then
            IntegrationTableMapping.SetIntegrationTableFilter(GetTableViewForCRMIds(IntegrationTableMapping."Integration Table ID", IntegrationTableMapping."Integration Table UID Fld. No.", CRMIDs));
        if Direction in [IntegrationTableMapping.Direction::Bidirectional, IntegrationTableMapping.Direction::ToIntegrationTable] then
            IntegrationTableMapping.SetTableFilter(IntegrationRecordSynch.GetTableViewForSystemIds(IntegrationTableMapping."Table ID", SystemIds));
        AddIntegrationTableMapping(IntegrationTableMapping, SynchronizeOnlyCoupledRecords);
        Commit();
        exit(CRMSetupDefaults.CreateJobQueueEntry(IntegrationTableMapping));
    end;

Additional context
Useful for custom integration to use the same approach as is used for OOTB mappings
Internal work item: AB#522694

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.
Build ID: 18615.


Relaxing timeColumnName validation

Current validation code will fail when the time column name is
set to empty string. We can relax the validation by treating
the empty string the same as the null value. Added the unit test.

Codecov Report

Merging #6185 into master will decrease coverage by 20.41%.
The diff coverage is 49.14%.

@@             Coverage Diff             @@
##           master    #6185       +/-   ##
===========================================
- Coverage   66.44%   46.03%   -20.42%
===========================================
  Files        1075     1237      +162
  Lines       54773    58482     +3709
  Branches     8168     8655      +487
===========================================
- Hits        36396    26923     -9473
- Misses      15700    29350    +13650
+ Partials     2677     2209      -468

Flag
Coverage Δ

#integration
46.03% <49.14%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

...ot/broker/broker/AllowAllAccessControlFactory.java
100.00% <ø> (ø)

.../helix/BrokerUserDefinedMessageHandlerFactory.java
52.83% <0.00%> (-13.84%)
:arrow_down:

...org/apache/pinot/broker/queryquota/HitCounter.java
0.00% <0.00%> (-100.00%)
:arrow_down:

...che/pinot/broker/queryquota/MaxHitRateTracker.java
0.00% <0.00%> (ø)

...ache/pinot/broker/queryquota/QueryQuotaEntity.java
0.00% <0.00%> (-50.00%)
:arrow_down:

...ava/org/apache/pinot/client/AbstractResultSet.java
26.66% <0.00%> (-30.48%)
:arrow_down:

.../main/java/org/apache/pinot/client/Connection.java
22.22% <0.00%> (-26.62%)
:arrow_down:

.../org/apache/pinot/client/ResultTableResultSet.java
24.00% <0.00%> (-10.29%)
:arrow_down:

...not/common/assignment/InstancePartitionsUtils.java
64.28% <ø> (-8.89%)
:arrow_down:

.../apache/pinot/common/exception/QueryException.java
90.27% <ø> (+5.55%)
:arrow_up:

... and 1225 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5577e87...a085b21. Read the comment docs.

Doesn't the same apply to other configs e.g.: invertedIndexColumns: [""]?


Dashboard ebook and thank you pages

Description
Created the eBook and thank you pages using the template created for these pages
Related Issue(s)
#2220
Checklist

[x] I have read the contribution guidelines
[x] I have considered the performance impact of these changes
[ ] Suitable unit/system level tests have been added and they pass
[ ] Documentation has been updated

Hi @Hasmin-AC, the pages are completed. The only thing remaining is the dashboard images you mentioned in the issue. Which images would you like?
I recall you didn't prefer the one we used on the Dashboard landing page mockup, and using the same image across all three pages might seem repetitive. Could you please share your thoughts on what you had in mind?

We could merge as is and add the images as an iteration

As Hasmin is OOO today, I'll merge as is, and you can schedule the next iteration next week @Yndira-E ?

Yes, as soon as Hasmin shares which images she had in mind, I'll get on it.


Update gemspec to <IP_ADDRESS>

Pull requests into cqm-parsers require the following. Submitter and reviewer should :white_check_mark: when done. For items that are not-applicable, note it's not-applicable ("N/A") and :white_check_mark:.
Submitter:

[ ] This pull request describes why these changes were made.
[ ] Internal ticket for this PR:
[ ] Internal ticket links to this PR
[ ] Code diff has been done and been reviewed
[ ] Tests are included and test edge cases
[ ] Tests have been run locally and pass

Reviewer 1:
Name:

[ ] Code is maintainable and reusable, reuses existing code and infrastructure where appropriate, and accomplishes the task’s purpose
[ ] The tests appropriately test the new code, including edge cases
[ ] You have tried to break the code

Reviewer 2:
Name:

[ ] Code is maintainable and reusable, reuses existing code and infrastructure where appropriate, and accomplishes the task’s purpose
[ ] The tests appropriately test the new code, including edge cases
[ ] You have tried to break the code

Codecov Report

:exclamation: No coverage uploaded for pull request base (cqm_parsers_3_x@6f23742). Click here to learn what that means.
The diff coverage is n/a.

:exclamation: Current head 91911b7 differs from pull request most recent head 2016e62. Consider uploading reports for the commit 2016e62 to get more accurate results

@@                Coverage Diff                 @@
##             cqm_parsers_3_x     #168   +/-   ##
==================================================
  Coverage                   ?   82.37%
==================================================
  Files                      ?       69
  Lines                      ?     4313
  Branches                   ?        0
==================================================
  Hits                       ?     3553
  Misses                     ?      760
  Partials                   ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6f23742...2016e62. Read the comment docs.


initial commit

Signed-off-by: CEHENKLE<EMAIL_ADDRESS>Description
add CODEOWNER support for repo
Check List

[x] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Codecov Report

Merging #150 (254eaee) into main (e022b96) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #150   +/-   ##
=======================================
  Coverage   50.81%   50.81%
=======================================
  Files         200      200
  Lines        4668     4668
  Branches      594      594
=======================================
  Hits         2372     2372
  Misses       2294     2294
  Partials        2        2

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e022b96...254eaee. Read the comment docs.


SAK-30751  bullet points are misaligned and missing their numbers

This also resolves SAK-30750 bullet points appear outside of page area

You are on fire ... LGTM


PE test 1 should continue checking all PE registers in reg_list after finding an failure

Now PE test 1 (Check Arch symmetry across PE) directly returns once it finds a inconsistent value of PE registers in cores.  The test should continue checking other PE registers as we want to identify all the issues.
https://github.com/ARM-software/bsa-acs/blob/main/test_pool/pe/operating_system/test_os_c001.c#L176

Hi @sunnywang-arm,
ACS team is working on the changes and will upstream the changes soon.
Thanks,
ACS team


Uncaught (in promise) TypeError: parentComponent.ctx.deactivate is not a function

Version
3.0.0
Reproduction link
https://jsfiddle.net/cbf2gvs0/
Steps to reproduce
keep-alive包裹的组件，当用router-link方式跳转的时候就会出现如下错误并且不能正常跳转
TypeError: parentComponent.ctx.deactivate is not a function
at unmount (runtime-core.esm-bundler.js?5c40:5648)
at patch (runtime-core.esm-bundler.js?5c40:4659)
at Object.sharedContext.activate (runtime-core.esm-bundler.js?5c40:2651)
at processComponent (runtime-core.esm-bundler.js?5c40:5081)
at patch (runtime-core.esm-bundler.js?5c40:4690)
at componentEffect (runtime-core.esm-bundler.js?5c40:5287)
at Object.reactiveEffect [as update] (reactivity.esm-bundler.js?a1e9:42)
at updateComponent (runtime-core.esm-bundler.js?5c40:5155)
at processComponent (runtime-core.esm-bundler.js?5c40:5088)
at patch (runtime-core.esm-bundler.js?5c40:4690)
What is expected?
能正常跳转，不报错
What is actually happening?
不能正常跳转，也报错了

That's not a valid repro. Use the forum or chat for questions, thank you


feat(start_receiving): add parameter recv_time to allow delayed receiving

This allows i.e. saving power when it is known that response won't come sooner than some time T.

I think this can be closed after https://github.com/ProfFan/dw3000-ng/pull/11.


Fix a few doc issues.

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: geeknoid
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

mixer/OWNERS [geeknoid]
pilot/OWNERS [geeknoid]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@geeknoid: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-integ-local-tests.sh
67e7877d30447efd09399882b7f6ff1dbaa65609
link
/test istio-integ-local-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@geeknoid: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-integ-local-tests.sh
67e7877d30447efd09399882b7f6ff1dbaa65609
link
/test istio-integ-local-tests

prow/istio-integ-k8s-tests.sh
67e7877d30447efd09399882b7f6ff1dbaa65609
link
/test istio-integ-k8s-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@geeknoid: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-integ-local-tests.sh
67e7877d30447efd09399882b7f6ff1dbaa65609
link
/test istio-integ-local-tests

prow/istio-integ-k8s-tests.sh
67e7877d30447efd09399882b7f6ff1dbaa65609
link
/test istio-integ-k8s-tests

prow/istio-presubmit.sh
67e7877d30447efd09399882b7f6ff1dbaa65609
link
/test istio-presubmit

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: douglas-reid, geeknoid
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

mixer/OWNERS [douglas-reid,geeknoid]
pilot/OWNERS [geeknoid]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

/retest

@geeknoid: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-integ-k8s-tests.sh
67e7877d30447efd09399882b7f6ff1dbaa65609
link
/test istio-integ-k8s-tests

prow/istio-presubmit.sh
67e7877d30447efd09399882b7f6ff1dbaa65609
link
/test istio-presubmit

prow/istio-integ-local-tests.sh
67e7877d30447efd09399882b7f6ff1dbaa65609
link
/test istio-integ-local-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@geeknoid: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-presubmit.sh
67e7877d30447efd09399882b7f6ff1dbaa65609
link
/test istio-presubmit

prow/istio-integ-local-tests.sh
67e7877d30447efd09399882b7f6ff1dbaa65609
link
/test istio-integ-local-tests

prow/istio-integ-k8s-tests.sh
67e7877d30447efd09399882b7f6ff1dbaa65609
link
/test istio-integ-k8s-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@geeknoid: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-integ-local-tests.sh
67e7877d30447efd09399882b7f6ff1dbaa65609
link
/test istio-integ-local-tests

prow/istio-integ-k8s-tests.sh
67e7877d30447efd09399882b7f6ff1dbaa65609
link
/test istio-integ-k8s-tests

prow/istio-presubmit.sh
67e7877d30447efd09399882b7f6ff1dbaa65609
link
/test istio-presubmit

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@geeknoid: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-integ-k8s-tests.sh
dc972a9f9a232ba2a4db3cf17e838d03eadbf2c7
link
/test istio-integ-k8s-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@geeknoid: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-integ-k8s-tests.sh
dc972a9f9a232ba2a4db3cf17e838d03eadbf2c7
link
/test istio-integ-k8s-tests

prow/istio-pilot-multicluster-e2e.sh
dc972a9f9a232ba2a4db3cf17e838d03eadbf2c7
link
/test istio-pilot-multicluster-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.


Help:  Is there any instruction for using these plugins?  Thanx in advance....

Thanx.....

Hello, you should have a look on the videos:
https://youtu.be/_DyZxVTLtZg
https://youtu.be/veNUKROVzRA
then for specific Andor plugin, you have to install first the sdk (either sdk2 for CCD or sdk3 for SCMOS) then the plugin using the plugin manager.
Let me know if you have some issues


ARROW-33: [C++] Implement zero-copy array slicing

Add two methods to slice an Array. It will generate a new Array
containing a Buffer with parent pointer, offset and length.

Some confusions follow:
1.If it's necessary to add the slicing methods into ListArray, UnionArray etc.
2.Before slice(...) returns an Array, which is better the Array contains a base class Buffer
or a derived Buffer.
e...Anyway, hope this request not too bad. : )

What about other Array types (like ListArray, StringArray)?

One major issue (I think you mentioned on JIRA) is the null bitmap — slicing may require a memory allocation and copying over the bits. Another option is to add a layer of indirection and a Bitmap class that can retrieve bits including an offset, so that zero-copy is possible.
Otherwise, if creating a new bitmap is required, then the API must change to return Status (since the allocation could fail)

Another option is to add a layer of indirection and a Bitmap class that can retrieve bits including an offset, so that zero-copy is possible.

This option sounds better, as similar to the data buffer.

It's a performance trade-off. The downside of that approach is that a bitmap offset then potentially leaks into many algorithms

@wesm @drankye
Yes, you mentioned features are great.
And I will try to add an indirection layer.
Then I still have a confusion with the following code.
auto sliced_buf = std::make_shared<Buffer>(parent_data,             int64_t(uFrom * sizeof(T)), int64_t(uLength * sizeof(T)));
For the above code. I am not sure when the slice method returns an specified Array, such as Int32Array, the Array should contain a base-class Buffer object, or a derived-class PoolBuffer object.
After all, Int32Array is created with a PoolBuffer which owns some features that Buffer dosen't.
Maybe, the new code just looks like this:
auto sliced_buf = std::make_shared<PoolBuffer>(parent_data,             int64_t(uFrom * sizeof(T)), int64_t(uLength * sizeof(T)));
Anyway, I will rewirte the code based on all of your suggestions.
Thank you, everybody.
Have a nice day. :)

I'm concerned about working more on this patch until we figure out a function evaluation model. See ARROW-34. Zero-copy slicing is difficult unless you construct a view object (definitely an option).

@wesm
OK.
I will reduce the influence of this issue as much as possible.
By the way, it's hard to put slice method into Primitive.cc, unless class PrimitiveArray is templa-table or provide more arguments for the method, because user may expect the method to return a specific Array, like Int32Array, so some more tricks shold be considered to adapt to this change.
Thanks.:)

@wesm
OK. I will reduce the influence of this issue as much as possible.
Thanks a lot.

To summarize the question Guangyuan mentioned above: we have some Buffer types including Buffer, PoolBuffer and etc., to slice an array, what's the concrete Buffer type to be used by the resultant array? It would be good to use the same Buffer type the parent uses, but not sure how easy it's to be done.
I have a question related. I'm not sure how much benefit we would obtain by having quite a few Buffer subclasses. Might it be just to have one Buffer class, and add all the necessary methods like Append, Resize, Reserve to it? It should simplify something I guess.

Since users of Arrow will have memory originating from many places and with varying ownership semantics, forcing a particular Buffer or memory allocated strategy is not a good idea. By enabling users to implement their own Buffer subclasses and their own memory pools, they can hook the Arrow C++ library more easily into existing applications.
I'm open to other ideas ways to arrange Arrow's internal memory management, reference counting, allocation, and ownership semantics. This probably would need to take the form of a patch or the start of a patch, though.

@drankye
Yes, maybe your question is good, I am not sure.
@wesm
Great. The user-defined buffer should be nice. Arrow has the rules, so does the users.
Arrow defines the basic measures of internal memory management etc.
An interface of Buffer or memory pool for user definition is needed, I think.

Why the CI test failed, however it occurs no failures in my environment?
Please. :(

The test suite is failing the valgrind memory leak checks. We enabled this to be printed in parquet (https://github.com/apache/parquet-cpp/blob/master/ci/travis_script_cpp.sh).
I'm pretty concerned about this patch because of the semantics of slicing bitmaps per my April 4 comment. I have not reviewed the code yet.


target disappears during rotation

target disappears during rotation, Does anyone know how to fix it ?

[x] I have verified the issue exists on the latest version
[x] I am able to reproduce it

Version used:
Stack trace:
Android version:

You will need to handle re-displaying the view yourself.


User script hot deployment not functioning

WARNING:jobTree.leader:2fa1bc1d-7dec-4b88-814f-42bfcc159a2b:	---JOBTREE WORKER OUTPUT LOG---
WARNING:jobTree.leader:2fa1bc1d-7dec-4b88-814f-42bfcc159a2b:	Traceback (most recent call last):
WARNING:jobTree.leader:2fa1bc1d-7dec-4b88-814f-42bfcc159a2b:	  File "/usr/local/lib/python2.7/dist-packages/jobTree/worker.py", line 267, in main
WARNING:jobTree.leader:2fa1bc1d-7dec-4b88-814f-42bfcc159a2b:	    jobStore=jobStore)
WARNING:jobTree.leader:2fa1bc1d-7dec-4b88-814f-42bfcc159a2b:	  File "/usr/local/lib/python2.7/dist-packages/jobTree/target.py", line 714, in _execute
WARNING:jobTree.leader:2fa1bc1d-7dec-4b88-814f-42bfcc159a2b:	    returnValues = self.run(fileStore)
WARNING:jobTree.leader:2fa1bc1d-7dec-4b88-814f-42bfcc159a2b:	  File "/usr/local/lib/python2.7/dist-packages/jobTree/target.py", line 818, in run
WARNING:jobTree.leader:2fa1bc1d-7dec-4b88-814f-42bfcc159a2b:	    userFunction = self._getUserFunction()
WARNING:jobTree.leader:2fa1bc1d-7dec-4b88-814f-42bfcc159a2b:	  File "/usr/local/lib/python2.7/dist-packages/jobTree/target.py", line 791, in _getUserFunction
WARNING:jobTree.leader:2fa1bc1d-7dec-4b88-814f-42bfcc159a2b:	    return getattr(importlib.import_module(userFunctionModule.name), self.userFunctionName)
WARNING:jobTree.leader:2fa1bc1d-7dec-4b88-814f-42bfcc159a2b:	  File "/usr/lib/python2.7/importlib/init.py", line 37, in import_module
WARNING:jobTree.leader:2fa1bc1d-7dec-4b88-814f-42bfcc159a2b:	    import(name)
WARNING:jobTree.leader:2fa1bc1d-7dec-4b88-814f-42bfcc159a2b:	ImportError: No module named testUserScript
WARNING:jobTree.leader:2fa1bc1d-7dec-4b88-814f-42bfcc159a2b:	Exiting the worker because of a failed job on host ip-172-31-21-198
WARNING:jobTree.leader:2fa1bc1d-7dec-4b88-814f-42bfcc159a2b:	ERROR:main:Exiting the worker because of a failed job on host ip-172-31-21-198
WARNING:jobTree.leader:2fa1bc1d-7dec-4b88-814f-42bfcc159a2b:	WARNING:jobTree.job:Due to failure we are reducing the remaining retry count of job 2fa1bc1d-7dec-4b88-814f-42bfcc159a2b to 0

There are multiple implementations of startJobTree(). Only the stack.startJobTree() calls getUserScript, while the target.Runner.startJobTree() does not take user script into account at all, so it defaults to None.
Why are there multiple implementations, and when should each be used?

After adding the call to getUserScript() to target.runner.startJobTree(), it appears that hot deployment works successfully for the first task. However, on the child task I get an error when trying to load the job's pickle file. It appears that the user module is pickled in _serializeFirstJob(), but I don't see any similar functions for the subsequent jobs. I suspect that the user Module is just not being included in the subsequent job's pickle file, which causes them to try to import whatever the next token in the command is.

There should be no stack class, the only way to run the jobTree should be
through Target.Runner.startJobTree()
On Tue, Jul 14, 2015 at 2:24 PM, Christopher Ketchum <
<EMAIL_ADDRESS>wrote:

There are multiple implementations of startJobTree(). Only the
stack.startJobTree() calls getUserScript, while the
target.Runner.startJobTree() does not take user script into account at all,
so it defaults to None.
Why are there multiple implementations, and when should each be used?
—
Reply to this email directly or view it on GitHub
https://github.com/BD2KGenomics/slugflow/issues/167#issuecomment-121393613
.

I have been testing with a script using functions as target. When trying to load the target on the worker, the "userModule" is reported as jobtree.target, and the "targetClass" is TargetFunctionWrappingTarget. This working for the very first task, but failing with the message "ImportError: No module named helloWorld" when trying to unpickle on the subsequent task. It appears as though the user module is not added to the path until the target is being run, but it first has to be unpickled , which requires that it be on sys.path.


bump version in package.json to v2.13.2

release version v2.13.2

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Correct package header format

See also https://www.gnu.org/software/emacs/manual/html_node/elisp/Library-Headers.html

Thanks!
I could have sworn I did this before submitting that melpa PR. I'll have to give it another check after this to make sure I didn't miss anything else.

I see what happened - I accidentally pushed up the master branch rather than main after I renamed it.


Prevent error on export of blank Ask CFPB pages

Previously, if any of the Ask CFPB answer pages was blank in the 'text', 'how_to_schema', and 'faq_schema' fields (e.g. a blank draft page), the export_ask_data command would result in a 500 error.
Allow these blank drafts to be exported along with the rest of the
pages.
Changes

Prevent a  IndexError: list index out of range when exporting a blank page by catching cases where answer_schema has no contents.

Testing

Run this branch
Log in to the Wagtail admin using admin/admin
On the left-hand sidebar, scroll down to select the second-to-last option, "Export Ask data"
Press the "Download CSV" button
The action should complete without any python errors, and you should get a CSV file of all Ask answer pages.

Checklist

[x] PR has an informative and human-readable title
[x] Changes are limited to a single goal (no scope creep)
[ ] Code can be automatically merged (no conflicts)
[x] Code follows the standards laid out in the CFPB development guidelines
[x] Passes all existing automated tests
[x] Any change in functionality is tested
[x] New functions are documented (with a description, list of inputs, and expected output)
[x] Placeholder code is flagged / future todos are captured in comments
[ ] Visually tested in supported browsers and devices (see checklist below :point_down:)
[ ] Project documentation has been updated
[x] Reviewers requested with the Reviewers tool :arrow_right:

The CSV that is created by the Export Ask Data method has a boolean column called "Live", which indicates whether a page is published or not. So, in the output, it will be clear that these blank pages are still in draft status, not live. Since that will be clear, I think we should include all pages in the collection.
As for the other error, I had commented that I thought they were related, but now I think I was wrong. At the very least, the other error is more challenging to investigate, and will take more time to find the root cause.


disable scrapers for closed restaurants (COVID-19)

closes #304

Codecov Report

Merging #307 into master will not change coverage by %.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #307   +/-   ##
=======================================
  Coverage   99.15%   99.15%
=======================================
  Files           8        8
  Lines         118      118
  Branches       20       20
=======================================
  Hits          117      117
  Misses          1        1

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 501f35e...aeb3660. Read the comment docs.


EN-8744 Fix number of fields parsed in ALB logs.

a new field started appearing in AWS ALB logs since last wednesday. Fix the script to accept new field.

Yes adding alerting on Lambda logs to notify when log parsing stops.