Does ROCm support the RX 6700S (laptop GPU)

I am planning to buy a laptop with a RX 6700S GPU will it support ROCm 5.0+ ?
https://www.amd.com/en/products/graphics/amd-radeon-rx-6700s

It is a gfx1032 GPU, not officially supported. But you can override it to gfx1030 which is officially supported. That actually works.
https://docs.amd.com/bundle/Hardware_and_Software_Reference_Guide/page/Hardware_and_Software_Support.html
I have tested that on a gfx1032 GPU with pytorch mnist example.
sudo docker pull rocm/pytorch:latest

sudo docker run -it --cap-add=SYS_PTRACE --security-opt seccomp=unconfined --device=/dev/kfd --device=/dev/dri --group-add video --ipc=host --shm-size 8G rocm/pytorch:latest

root@cdd69b58e233:/var/lib/jenkins# python3
Python 3.7.13 (default, Mar 29 2022, 02:18:16)
[GCC 7.5.0] :: Anaconda, Inc. on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> import torch
>>> torch.cuda.is_available()
"hipErrorNoBinaryForGpu: Unable to find code object for all current devices!"
Aborted (core dumped)
root@cdd69b58e233:/var/lib/jenkins#

root@cdd69b58e233:/var/lib/jenkins# HSA_OVERRIDE_GFX_VERSION=10.3.0 python3
Python 3.7.13 (default, Mar 29 2022, 02:18:16)
[GCC 7.5.0] :: Anaconda, Inc. on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> import torch
>>> torch.cuda.is_available()
True
>>>

$ rocminfo
*******
Agent 2
*******
  Name:                    gfx1032
  Uuid:                    GPU-XX
  Marketing Name:          AMD Radeon PRO W6600
  Vendor Name:             AMD
  Feature:                 KERNEL_DISPATCH
  Profile:                 BASE_PROFILE
  Float Round Mode:        NEAR
  Max Queue Number:        128(0x80)
  Queue Min Size:          4096(0x1000)
  Queue Max Size:          131072(0x20000)
  Queue Type:              MULTI
  Node:                    1
  Device Type:             GPU
  Cache Info:
    L1:                      16(0x10) KB
    L2:                      2048(0x800) KB
    L3:                      32768(0x8000) KB
  Chip ID:                 29667(0x73e3)
  Cacheline Size:          64(0x40)
  Max Clock Freq. (MHz):   2910
  BDFID:                   768
  Internal Node ID:        1
  Compute Unit:            28
  SIMDs per CU:            2
  Shader Engines:          4
  Shader Arrs. per Eng.:   2
  WatchPts on Addr. Ranges:4
  Features:                KERNEL_DISPATCH
  Fast F16 Operation:      TRUE
  Wavefront Size:          32(0x20)
  Workgroup Max Size:      1024(0x400)
  Workgroup Max Size per Dimension:
    x                        1024(0x400)
    y                        1024(0x400)
    z                        1024(0x400)
  Max Waves Per CU:        32(0x20)
  Max Work-item Per CU:    1024(0x400)
  Grid Max Size:<PHONE_NUMBER>(0xffffffff)
  Grid Max Size per Dimension:
    x<PHONE_NUMBER>(0xffffffff)
    y<PHONE_NUMBER>(0xffffffff)
    z<PHONE_NUMBER>(0xffffffff)
  Max fbarriers/Workgrp:   32
  Pool Info:
    Pool 1
      Segment:                 GLOBAL; FLAGS: COARSE GRAINED
      Size:                    8372224(0x7fc000) KB
      Allocatable:             TRUE
      Alloc Granule:           4KB
      Alloc Alignment:         4KB
      Accessible by all:       FALSE
    Pool 2
      Segment:                 GROUP
      Size:                    64(0x40) KB
      Allocatable:             FALSE
      Alloc Granule:           0KB
      Alloc Alignment:         0KB
      Accessible by all:       FALSE
  ISA Info:
    ISA 1
      Name:                    amdgcn-amd-amdhsa--gfx1032
      Machine Models:          HSA_MACHINE_MODEL_LARGE
      Profiles:                HSA_PROFILE_BASE
      Default Rounding Mode:   NEAR
      Default Rounding Mode:   NEAR
      Fast f16:                TRUE
      Workgroup Max Size:      1024(0x400)
      Workgroup Max Size per Dimension:
        x                        1024(0x400)
        y                        1024(0x400)
        z                        1024(0x400)
      Grid Max Size:<PHONE_NUMBER>(0xffffffff)
      Grid Max Size per Dimension:
        x<PHONE_NUMBER>(0xffffffff)
        y<PHONE_NUMBER>(0xffffffff)
        z<PHONE_NUMBER>(0xffffffff)
      FBarrier Max Size:       32

root@cdd69b58e233:/var/lib/jenkins/pytorch/examples/mnist# HSA_OVERRIDE_GFX_VERSION=10.3.0 python3 main.py
...
Train Epoch: 14 [0/60000 (0%)]  Loss: 0.029361
Train Epoch: 14 [640/60000 (1%)]        Loss: 0.020166
Train Epoch: 14 [1280/60000 (2%)]       Loss: 0.008040
Train Epoch: 14 [1920/60000 (3%)]       Loss: 0.051216
Train Epoch: 14 [2560/60000 (4%)]       Loss: 0.001075
Train Epoch: 14 [3200/60000 (5%)]       Loss: 0.057989
Train Epoch: 14 [3840/60000 (6%)]       Loss: 0.039574
Train Epoch: 14 [4480/60000 (7%)]       Loss: 0.005929
Train Epoch: 14 [5120/60000 (9%)]       Loss: 0.090919
Train Epoch: 14 [5760/60000 (10%)]      Loss: 0.070765
Train Epoch: 14 [6400/60000 (11%)]      Loss: 0.005689
Train Epoch: 14 [7040/60000 (12%)]      Loss: 0.022842
Train Epoch: 14 [7680/60000 (13%)]      Loss: 0.025918
Train Epoch: 14 [8320/60000 (14%)]      Loss: 0.011779
Train Epoch: 14 [8960/60000 (15%)]      Loss: 0.009255
Train Epoch: 14 [9600/60000 (16%)]      Loss: 0.012456
Train Epoch: 14 [10240/60000 (17%)]     Loss: 0.015307
Train Epoch: 14 [10880/60000 (18%)]     Loss: 0.001581
Train Epoch: 14 [11520/60000 (19%)]     Loss: 0.007551
Train Epoch: 14 [12160/60000 (20%)]     Loss: 0.007114
Train Epoch: 14 [12800/60000 (21%)]     Loss: 0.006242
Train Epoch: 14 [13440/60000 (22%)]     Loss: 0.003852
Train Epoch: 14 [14080/60000 (23%)]     Loss: 0.025893
Train Epoch: 14 [14720/60000 (25%)]     Loss: 0.024052
Train Epoch: 14 [15360/60000 (26%)]     Loss: 0.007025
Train Epoch: 14 [16000/60000 (27%)]     Loss: 0.005092
Train Epoch: 14 [16640/60000 (28%)]     Loss: 0.001427
Train Epoch: 14 [17280/60000 (29%)]     Loss: 0.003324
Train Epoch: 14 [17920/60000 (30%)]     Loss: 0.001264
Train Epoch: 14 [18560/60000 (31%)]     Loss: 0.002595
Train Epoch: 14 [19200/60000 (32%)]     Loss: 0.003115
Train Epoch: 14 [19840/60000 (33%)]     Loss: 0.019476
Train Epoch: 14 [20480/60000 (34%)]     Loss: 0.005185
Train Epoch: 14 [21120/60000 (35%)]     Loss: 0.032551
Train Epoch: 14 [21760/60000 (36%)]     Loss: 0.013329
Train Epoch: 14 [22400/60000 (37%)]     Loss: 0.088533
Train Epoch: 14 [23040/60000 (38%)]     Loss: 0.083046
Train Epoch: 14 [23680/60000 (39%)]     Loss: 0.014655
Train Epoch: 14 [24320/60000 (41%)]     Loss: 0.062322
Train Epoch: 14 [24960/60000 (42%)]     Loss: 0.030058
Train Epoch: 14 [25600/60000 (43%)]     Loss: 0.028837
Train Epoch: 14 [26240/60000 (44%)]     Loss: 0.016934
Train Epoch: 14 [26880/60000 (45%)]     Loss: 0.001474
Train Epoch: 14 [27520/60000 (46%)]     Loss: 0.046969
Train Epoch: 14 [28160/60000 (47%)]     Loss: 0.011573
Train Epoch: 14 [28800/60000 (48%)]     Loss: 0.029901
Train Epoch: 14 [29440/60000 (49%)]     Loss: 0.002406
Train Epoch: 14 [30080/60000 (50%)]     Loss: 0.035965
Train Epoch: 14 [30720/60000 (51%)]     Loss: 0.022652
Train Epoch: 14 [31360/60000 (52%)]     Loss: 0.017276
Train Epoch: 14 [32000/60000 (53%)]     Loss: 0.006537
Train Epoch: 14 [32640/60000 (54%)]     Loss: 0.017766
Train Epoch: 14 [33280/60000 (55%)]     Loss: 0.016734
Train Epoch: 14 [33920/60000 (57%)]     Loss: 0.014395
Train Epoch: 14 [34560/60000 (58%)]     Loss: 0.044845
Train Epoch: 14 [35200/60000 (59%)]     Loss: 0.009965
Train Epoch: 14 [35840/60000 (60%)]     Loss: 0.001743
Train Epoch: 14 [36480/60000 (61%)]     Loss: 0.148522
Train Epoch: 14 [37120/60000 (62%)]     Loss: 0.028784
Train Epoch: 14 [37760/60000 (63%)]     Loss: 0.001296
Train Epoch: 14 [38400/60000 (64%)]     Loss: 0.088509
Train Epoch: 14 [39040/60000 (65%)]     Loss: 0.011910
Train Epoch: 14 [39680/60000 (66%)]     Loss: 0.022110
Train Epoch: 14 [40320/60000 (67%)]     Loss: 0.002538
Train Epoch: 14 [40960/60000 (68%)]     Loss: 0.033725
Train Epoch: 14 [41600/60000 (69%)]     Loss: 0.025057
Train Epoch: 14 [42240/60000 (70%)]     Loss: 0.022314
Train Epoch: 14 [42880/60000 (71%)]     Loss: 0.006667
Train Epoch: 14 [43520/60000 (72%)]     Loss: 0.008564
Train Epoch: 14 [44160/60000 (74%)]     Loss: 0.066551
Train Epoch: 14 [44800/60000 (75%)]     Loss: 0.003902
Train Epoch: 14 [45440/60000 (76%)]     Loss: 0.017624
Train Epoch: 14 [46080/60000 (77%)]     Loss: 0.069699
Train Epoch: 14 [46720/60000 (78%)]     Loss: 0.060984
Train Epoch: 14 [47360/60000 (79%)]     Loss: 0.009416
Train Epoch: 14 [48000/60000 (80%)]     Loss: 0.028712
Train Epoch: 14 [48640/60000 (81%)]     Loss: 0.010477
Train Epoch: 14 [49280/60000 (82%)]     Loss: 0.027884
Train Epoch: 14 [49920/60000 (83%)]     Loss: 0.003463
Train Epoch: 14 [50560/60000 (84%)]     Loss: 0.005643
Train Epoch: 14 [51200/60000 (85%)]     Loss: 0.094961
Train Epoch: 14 [51840/60000 (86%)]     Loss: 0.011150
Train Epoch: 14 [52480/60000 (87%)]     Loss: 0.025268
Train Epoch: 14 [53120/60000 (88%)]     Loss: 0.001729
Train Epoch: 14 [53760/60000 (90%)]     Loss: 0.039884
Train Epoch: 14 [54400/60000 (91%)]     Loss: 0.011366
Train Epoch: 14 [55040/60000 (92%)]     Loss: 0.004681
Train Epoch: 14 [55680/60000 (93%)]     Loss: 0.001321
Train Epoch: 14 [56320/60000 (94%)]     Loss: 0.092475
Train Epoch: 14 [56960/60000 (95%)]     Loss: 0.032426
Train Epoch: 14 [57600/60000 (96%)]     Loss: 0.011749
Train Epoch: 14 [58240/60000 (97%)]     Loss: 0.017789
Train Epoch: 14 [58880/60000 (98%)]     Loss: 0.015819
Train Epoch: 14 [59520/60000 (99%)]     Loss: 0.014150

Test set: Average loss: 0.0283, Accuracy: 9909/10000 (99%)

@xfyucg Thanks for the info!
Although the difference with your is card is that the RX 6700s is a mobile one, hope it still works

No way! Never heard of a GPU that can run with different target @xfyucg, how does that work?

老哥，gfx1032意思是 6600xt也可以吗，给点细节

look there guys!
https://www.reddit.com/r/Amd/comments/rd7mmi/heres_something_you_dont_see_every_day_pytorch/

Is there a special reason why you run pytorch inside a docker as opposed of installing it with the default command provided by pytorch.org:
pip3 install torch torchvision torchaudio --extra-index-url https://download.pytorch.org/whl/rocm5.1.1

Is there a special reason why you run pytorch inside a docker as opposed of installing it with the default command provided by pytorch.org: pip3 install torch torchvision torchaudio --extra-index-url https://download.pytorch.org/whl/rocm5.1.1

It is recommended in https://docs.amd.com/bundle/ROCm-Deep-learning-Guide_5.2/page/Frameworks_Installation_Guide.html

Just to make sure I understand correctly. the only difference with a normal rocm install is the usage of HSA_OVERRIDE_GFX_VERSION variable before running pytorch or tensorflow?

Yes.

@xfyucg Your HSA_OVERRIDE was exactly what I needed for my 6700S, thank you 8) I can enter HSA_OVERRIDE_GFX_VERSION=10.3.0 jupyter-notebook in the terminal and get torch.cuda.is_available() = True with no problem.

@xfyucg Your HSA_OVERRIDE was exactly what I needed for my 6700S, thank you 8) I can enter HSA_OVERRIDE_GFX_VERSION=10.3.0 jupyter-notebook in the terminal and get torch.cuda.is_available() = True with no problem.

May I know which Linux distro you are using?

@xfyucg Your HSA_OVERRIDE was exactly what I needed for my 6700S, thank you 8) I can enter HSA_OVERRIDE_GFX_VERSION=10.3.0 jupyter-notebook in the terminal and get torch.cuda.is_available() = True with no problem.

May I know which Linux distro you are using?

OpenSUSE Tumbleweed

@xfyucg 您好，问个事。安装好了，pycharm能把这个gpu环境引入进去吗？

@xfyucg 您好，问个事。安装好了，pycharm能把这个gpu环境引入进去吗？

应该可以

I installed OpenSuse Tumbleweed (with kernel 5.19) and have the TF resnet50 benchmark running with Tensorflow-rocm 2.9.2, I got pytorch running as well with the mnist example (same as above).
The main issue I see is the Memory Clock (when checking it with rocm-smi) seems to be capped at 875Mhz (while the real maximum is 2x as much as I experience under Windows and reported by GPU-Z). The main clock seems to alright though.
Anybody else have this issue?

6700s can use ROCM to run deep learning?

@zeng-cy Yep, it works with both tensorflow and pytorch

@MatPoliquin thank you ！Can pycharm be introduced into this environment? I want to test my program with pycharm

@MatPoliquin thank you ！Can pycharm be introduced into this environment? I want to test my program with pycharm

I haven't tried

@MatPoliquin ok

I installed OpenSuse Tumbleweed (with kernel 5.19) and have the TF resnet50 benchmark running with Tensorflow-rocm 2.9.2, I got pytorch running as well with the mnist example (same as above).
The main issue I see is the Memory Clock (when checking it with rocm-smi) seems to be capped at 875Mhz (while the real maximum is 2x as much as I experience under Windows and reported by GPU-Z). The main clock seems to alright though.
Anybody else have this issue?

Did some digging and I also have this issue. Output of pp_dpm_mclk is
0: 96Mhz *
1: 541Mhz
2: 675Mhz
3: 875Mhz

and while I can confim that mclk does change in response to a game being opened, 875 MHz is the max. I have opened an issue at the AMD Gitlab here to correct this and other issues.

875 MHz is correct. Alex linked me to a page that explains the memory clock formulas. See also here.

875 MHz is correct. Alex linked me to a page that explains the memory clock formulas. See also here.

Thanks for the info! looking at the results of rocm-bandwidth-test on my machine I get 200 GB/s in device to device transfer which is close to the 224 GB/s upper limit. So that means the rather low performance results from the resnet50 test are probably because there is still room for improvement on ROCm side and not a driver problem

tldr: using sudo docker run works but container doesn't show, using docker run do not works but container shows
Following @xfyucg instruction in ubuntu 22.04 with a RX 6600 XT,
torch.cuda.is_available()

is True even without HSA_OVERRIDE.
The problem is that it only works is I use sudo in the command, but if I use it, the container is not shown under "docker container ls" or in VScode (where I need it).
Instead if I use run without sudo the container is normal and visible, but
torch.cuda.is_available

is false with or without override.
My docker is rootless and I gave my user permission to every GPU device.

For Ubuntu 22.04 this link works directly: https://www.videogames.ai/2022/09/01/RX-6700s-Machine-Learning-ROCm.html. In the step 'Installing tensorflow and pytorch', use the latest nightly build link directly from the PyTorch website.

 The result is impressive, makes no sense the lack of automatic support by AMD.

Hi @MatPoliquin, please close the ticket if your query has been resolved.  Thanks for your help.

I installed OpenSuse Tumbleweed (with kernel 5.19) and have the TF resnet50 benchmark running with Tensorflow-rocm 2.9.2, I got pytorch running as well with the mnist example (same as above).
The main issue I see is the Memory Clock (when checking it with rocm-smi) seems to be capped at 875Mhz (while the real maximum is 2x as much as I experience under Windows and reported by GPU-Z). The main clock seems to alright though.
Anybody else have this issue?

Did some digging and I also have this issue. Output of pp_dpm_mclk is
0: 96Mhz *
1: 541Mhz
2: 675Mhz
3: 875Mhz

and while I can confim that mclk does change in response to a game being opened, 875 MHz is the max. I have opened an issue at the AMD Gitlab here to correct this and other issues.

Hey is this thing fixed now, the issue ended on an ambiguous note btw....

@harshb20, for supported GPUs, please refer to https://rocm.docs.amd.com/projects/install-on-linux/en/latest/reference/system-requirements.html.  The issue was reported on a non-supported GPU.


Calibration issue w KinectV2

Hello, I've been trying to calibrate 2 KinectV2's and running into some issues getting things to line up correctly.  I have followed the instructions to time sync using ntp and it seems that my offset values are acceptable, but I am still getting a 'split frame', resulting in a double detection.  Basically, the kinects are offset.  From what I can tell, the calibration process goes smoothly, but when I view the point clouds in rviz there is always an offset.  It seems to be consistent, as in I can calibrate 100 times and the offset is always the same.  I have tried different kinect positions/orientations with similar results.  I've also tried switching out the kinects with new ones, still the same.  Depending on the kinect locations, the offset can be anywhere from 1m (when the kinects are opposing each other from across the room) to 1/3m (when the kinects are on the same side of the room at roughly 60 degrees to eachother).
It seems like the same problem that others have reported - splitting due to poor time sync - but no matter what I try, nothing seems to change, regardless of my offset values
I am currently using:
1 mac mini - kinect node 1
1 macbook air - kinect node 2
1 macbook pro - master
all machines running Ubuntu 14.05
(we have not purchased production cpu's yet, so this is just the makeshift setup until those arrive)
Perhaps my issue is due to using macs without nvidia gpu's?
At the moment, my solution is to manually adjust the xyz position of one of the kinects in the 'calibration_results.yaml' until I get it to line up, which is pretty tedious.  Will this improve the blob tracking?  Is there a preferred method for manually tweaking calibration settings if the calibration is off?  I will eventually be using 4 kinects so it would be less than ideal to do this for each one.
Here are some screenshots
Any ideas?   Thanks in advance!

theoretically mac usb 3.0 should work, as kinectSDK works on my dualboot windows - yet, I can't speak to ubuntu native on macbook.  that said, I'm surprised it's fast enough to process (i thought gpu was required for kinect 2 linux driver).
questions :

re: kinect node 1 - did you do intrinsic calibration  for kinect 1 before extrinsic for the system ?
can assume intrinsic is not necessary for kinect 2 - but for kinect 1, it can help.

did you run calibration refinement ?

the point clouds for the different kinect models might still appear split, but it will vastly improve if not eliminate splitting on tracking regardless of kinect model.

Thanks for reaching out. Did you try the calibration refinement step?
We should have a manual calibration adjustment that’s not so tedious soon.
From: legshampoo<EMAIL_ADDRESS>Reply-To: OpenPTrack/open_ptrack<EMAIL_ADDRESS>Date: Wednesday, October 18, 2017 at 1:29 PM
To: OpenPTrack/open_ptrack<EMAIL_ADDRESS>Cc: Subscribed<EMAIL_ADDRESS>Subject: [OpenPTrack/open_ptrack] Calibration issue w KinectV2 (#156)
Hello, I've been trying to calibrate 2 KinectV2's and running into some issues getting things to line up correctly. I have followed the instructions to time sync using ntp and it seems that my offset values are acceptable, but I am still getting a 'split frame', resulting in a double detection. Basically, the kinects are offset. From what I can tell, the calibration process goes smoothly, but when I view the point clouds in rviz there is always an offset. It seems to be consistent, as in I can calibrate 100 times and the offset is always the same. I have tried different kinect positions/orientations with similar results. I've also tried switching out the kinects with new ones, still the same. Depending on the kinect locations, the offset can be anywhere from 1m (when the kinects are opposing each other from across the room) to 1/3m (when the kinects are on the same side of the room at roughly 60 degrees to eachother).
It seems like the same problem that others have reported - splitting due to poor time sync - but no matter what I try, nothing seems to change, regardless of my offset values
I am currently using:
1 mac mini - kinect node 1
1 macbook air - kinect node 2
1 macbook pro - master
all machines running Ubuntu 14.05
(we have not purchased production cpu's yet, so this is just the makeshift setup until those arrive)
Perhaps my issue is due to using macs without nvidia gpu's?
At the moment, my solution is to manually adjust the xyz position of one of the kinects in the 'calibration_results.yaml' until I get it to line up, which is pretty tedious. Will this improve the blob tracking? Is there a preferred method for manually tweaking calibration settings if the calibration is off? I will eventually be using 4 kinects so it would be less than ideal to do this for each one.
Here are some screenshots
Any ideas? Thanks in advance!
[mage removed by sender. screenshot from 2017-10-18 14 28 27]https://user-images.githubusercontent.com/6733655/31740600-d747c482-b41f-11e7-86cc-9b5a24036c43.png
[mage removed by sender. screenshot from 2017-10-18 14 39 08]https://user-images.githubusercontent.com/6733655/31740661-fe6e434c-b41f-11e7-8894-c894ee6c6913.png
[mage removed by sender. screenshot from 2017-10-18 15 05 05]https://user-images.githubusercontent.com/6733655/31740698-17a8fa32-b420-11e7-8fdb-861d3e4cca0c.png
[mage removed by sender. screenshot from 2017-10-18 16 21 15]https://user-images.githubusercontent.com/6733655/31740827-6e3dd020-b420-11e7-9a52-46da80750430.png
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHubhttps://github.com/OpenPTrack/open_ptrack/issues/156, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AAZTR7UGLb45WVuk9ePMNaqeD3qlMBFCks5stl-jgaJpZM4P-T8U.

re: kinect node 1 - did you do intrinsic calibration for kinect 1 before extrinsic for the system ?
can assume intrinsic is not necessary for kinect 2 - but for kinect 1, it can help.

I have not done intrinsic calibration on either KinectV2.  I will try that and see if it helps.

did you run calibration refinement ?
I thought that I did.  Is that the step where you walk around the coverage zone and it generates the tracking image, as seen in the screenshot with the green and pink lines?  Is it typical for the lines to not match up in the image that's generated?

My biggest question at the moment is, is the 'manual calibration adjustment' workaround sufficient to get accurate tracking?  I just want to be sure that it's not simply a cosmetic adjustment... that what I see in rviz is in fact the same point cloud that is being tracked, if that makes sense.
The reason I ask is because the 'camera_poses.yaml' is copied to each node, but I am only changing the values in 'opt_calibration_results.launch', which is on the master cpu.  Do I have to adjust the values in both files?

I have not done intrinsic calibration on either KinectV2. I will try that and see if it helps.

to clarify intrinsic calibration is only recommended for the Kinect V1  (normal USB).
the new Kinect v2 (usb 3.0) does not typically require intrinsic calibration.
If you have two Kinect v2, you likely do not need to do intrinsic on them.
indeed ! I see - you did run calibration refinement.  Unfortunately, you ended up with far worse result after refinement :(
A good refinement will 'fuse' the different colors into a solid grid (see reference image), yours has done the reverse.
observing your initial refinement tracks, a few tips:

make sure only one person is detected in the space during refinement process (including spurious detections - detection must be well calibrated prior to refinement)
never step in same place twice, from the same direction .
suggest not to cross over like you're doing... the 'x' pattern... better to walk like a grid as in the reference image. Walk at a steady constant pace, as densely as possible for the space you're in.

'manual calibration adjustment' workaround sufficient to get accurate tracking

i've never had to edit the calibration files manually, to get a system working.

Looking more closely - I will say that you have a challenging space -  there are a lot of dynamic objects on the perimeter (bicycles, boxes, chairs) - and a lot of people in background. not really a problem, per-se - can avoid detection by normal tuning per docs - though, it would be challenging to use background subtraction in your space. Not that you need it...  but without it, it may help to limit the detection distance of the sensors in the configs so that you're not getting spurious tracks from objects in the background. If the 'box' in your refinement image is the perimeter of the open area, then the detections beyond that box during refinement are problematic.

Thanks for the feedback - wanted to follow up on this issue.
The setup is now in a dedicated, empty space without all the complications from earlier (bikes, people, etc).  However, the calibration issues remain.  When I calibrate, the kinects are consistently about 1 meter off from each other.  The calibration refinement process still yields the same results (nothing matches and it's actually makes things much worse).
I have been working around this by manually adjusting the kinects x,y,z coordinates in opt_calibration_results.launch, until the point clouds visually match up.
The data is being sent to a node.js app and being visualized in a simple html canvas rendering.
The issue I'm having now, is that the tracking positions (x,y,z) have a 'jitter'.  You can see some of the jitter in Rviz, and it's amplified when mapped to the scale of our project in the node app to be very noticeable.  It seems as if the kinects are fighting with each other to determine the 'true' centroid, so the centroid is constantly shifting slightly.  For example, when someone is standing perfectly still their centroid has an erratic jitter.
I have tried adjusting the settings in moving_average_filter.yaml.  Increasing the window size helps to reduce the jitter, but it creates a delay that is unacceptable for our requirements.
So I'm still wondering why my calibration is off (but consistently 'off' the same amount), and why the calibration refinement has the opposite effect that it should.
Also, is this 'jitter' to be expected?  If the calibration was working correctly would it go away?
Thanks again for any insight

Yes, calibration is not working correctly, it seems.    Standard issues are non-rigid checkboards, lots of ambient / changing light, odd floor reflections causing Kinect noise.  But these don't seem apparent in your photos.  Did you update the calibration file with the physical measurements of your checkboard sizes?

Yeah, I printed the checkerboard at scale on rigid foam board, and measured it.  As far as I can tell the checkerboard dims are correct (using the defaults) but I will check that again.  The new space is controlled - empty room, blacked out windows, wood floor.  Nothing I can think of that would cause noise.
If it helps I can provide updated details/photos/screenshots of the setup (the images above were from an earlier iteration).
Are you saying that when the calibration is working the jitter is not present?

You shouldn't see much jitter in a normal circumstance.  The fact that calibration refinement is not helping is a signal that something is odd.  Updated screenshots would help - I can share with the developers and see what they think. Also send the output of ntpq -p on all nodes, if possible.


Error when using Client Side Encryption in Admin

Hi,
There is an error when you use Client-Side encryption in the Admin area as soon as you add a product to the quote you get the following fatal error:
Fatal error:  Call to a member function getStoreId() on a non-object in app/code/community/Adyen/Payment/Model/Adyen/Cc.php on line 121
I have fixed this in my local copy:
if (!is_object($this->_order)) {
$storeId = Mage::getSingleton('adminhtml/session_quote')->getQuote()->getStoreId();
} else {
$storeId = $this->_order->getStoreId();
}

Hi Mathew,
I could not reproduce this. What version of the module are you using? If you look in the latest version there is already a check for this see:
https://github.com/Adyen/magento/blob/develop-2.3.0/app/code/community/Adyen/Payment/Model/Adyen/Cc.php#L142
Regards,
Rik
Adyen

Rik,
Thanks, we are using <IP_ADDRESS> as we haven't upgraded to the latest version yet.

Hi Mathew,
Then that is the issue. It is fixed in the latest  stable release 2.2.2.
Regards,
Rik
Adyen


VM build is not incremental

How to reproduce the problem:
tools/build.py -mrelease runtime
tools/build.py -mrelease runtime
What is the expected output:
On first invocation: build output
On second invocation: nothing to do
What is the actual output:
First invocation: build output
Second invocation:
make -j 32 BUILDTYPE=ReleaseIA32 runtime
  ACTION runtime_dart_runtime_gyp_build_observatory_host_deploy_observatory out/ReleaseIA32/observatory/deployed/web/index.html
  TOUCH runtime_dart_runtime_gyp_generate_snapshot_bin_host_generate_snapshot_bin.intermediate
  ACTION Generating /usr/local/google/home/ricow/src/hub_dart/sdk/out/ReleaseIA32/obj/gen/vm_isolate_snapshot_gen.bin /usr/local/google/home/ricow/src/hub_dart/sdk/out/ReleaseIA32/obj/gen/isolate_snapshot_gen.bin files. runtime_dart_runtime_gyp_generate_snapshot_bin_host_generate_snapshot_bin.intermediate
  ACTION Generating /usr/local/google/home/ricow/src/hub_dart/sdk/out/ReleaseIA32/obj/gen/snapshot_gen.cc file. out/ReleaseIA32/obj/gen/snapshot_gen.cc
  CXX(target) out/ReleaseIA32/obj.target/dart/gen/snapshot_gen.o
  CXX(target) out/ReleaseIA32/obj.target/run_vm_tests/gen/snapshot_gen.o
  LINK(target) out/ReleaseIA32/dart
  LINK(target) out/ReleaseIA32/run_vm_tests
  TOUCH out/ReleaseIA32/obj.target/runtime.stamp
rm runtime_dart_runtime_gyp_generate_snapshot_bin_host_generate_snapshot_bin.intermediate

@iposva-google @johnmccutchan
Ivan: because of the snapshot generation
John: Because of the observatory deploy (John, I see that you do a copy, you may need to explicitly touch the output file, the copy will not change the timestamp which is used to determine if we rerun)

I investigated the snapshot generation and there is a bug in how gyp generates Makefiles when a build rule has two outputs that will always trigger a rebuild.

Fix for both issues- https://codereview.chromium.org/1304953004/


Add ros_foxglove_msgs package

Public-Facing Changes
None
Description
Import package.xml and CMakeLists from https://github.com/foxglove/ros_foxglove_msgs, and update it to include the generated ROS 1/2 messages. This will become the source repo for the foxglove_msgs package, and the other repo can be archived/deleted. (cc @wep21)
Partially implements https://github.com/foxglove/message-schemas/issues/18

@jtbandes Will you update the description in rosdistro?
https://github.com/ros/rosdistro/blob/8e9e1e942041422793d0bfe01438b3b87028abfc/rolling/distribution.yaml#L977

Yes, I'm hoping that bloom-release will help me do it, but I need permissions on the release repo first (https://github.com/ros2-gbp/ros2-gbp-github-org/pull/56)


Output is cut-off due to a token limit

There's a hard-coded token limit of 500 tokens in the current version of the integration. For reasonably large Home Assistant setups where more than 10 suggestions are being generated this causes the suggestion output to be cut-off:

The limit of the model currently in use (gpt-4o-mini) is 16384 tokens. At the moment of writing, gpt-4o-mini costs $0.600 / 1M output tokens. This means that a maximum usage of 16384 tokens would cost $0.009 per prompt, which I think is not unreasonable or unresponsible to set as an output limit.
In the future it would be nice if both the model and the maximum token length are user-configurable values. I do not know how to code that (yet), but I created a pull-request to increase the token limit to 16384 for now: PR https://github.com/ITSpecialist111/ai_automation_suggester/pull/10

Thank you. I am investigating the limits and evaluating more suitable options that will provide additional information and streamline the automation that may be important for the individual. I will add this to the urgent list.

Updated to resolve issues within this next version, please read:  https://github.com/ITSpecialist111/ai_automation_suggester/releases/tag/V1.08


Typeahead popup position

Append-to-body dropdown position
Add support for typeahead-dropdown position after scroll and resize events.
Scenario 1

Type some text into input (show dropdown appended to body)
Scroll down
We need dropdown in right place after input

Scenario 2

Type some text into input (show dropdown appended to body)
Resize after breakpoint in media query (change position of input)
We need dropdown in right place after input

Thanks

Thanks for comments, all done. Travis OK

Any news for this enhancement?

I added debounced execution of event logic and support for hiding popup if scroll & resize is "in progress".

Done

Adding a comment here for better visibility - there are multiple PRs involving positioning, so I am going to look into seeing if there is a better way of handling it inside $position instead.

This PR looks safe to merge, although I think the debounce should be split off into a separate service - I'm inclined to hold off until this is done.
I could merge this in now, or wait until the debounce is split off into a service - the benefit of holding off would be that debounce would be available as a utility injectable for anyone who needs it, but it does put some more burden on you.
What are your thoughts?

OK, the idea of separate debounce in service is good. But I think this should be in separate PR. I can write this after merge this PR.

Only for my information: when are you planning to merge it into production?

I think the debounce should be split off here - can you update your PR with that change?

Actually, scratch my comment - I will merge this in today, and work can be done to split the debounce to a separate component after.


iOS release  Flutter.framework is too large.   375.8M

iOS release  Flutter.framework is too large.   375.8M in flutter SDK path: flutter/bin/cache/artifacts/engine/ios-release/Flutter.framework
flutter version:
macOS 10.15.3
Flutter 1.12.13+hotfix.8 • channel stable • https://github.com/flutter/flutter.git
Framework • revision 0b8abb4724 (7 weeks ago) • 2020-02-11 11:44:36 -0800
Engine • revision e1e6ced81d
Tools • Dart 2.7.0## Steps to Reproduce
file is too large is Flutter SDK:
release  375.8:
path:  flutter/bin/cache/artifacts/engine/ios-release/Flutter.framework
debug  95M:
path: flutter/bin/cache/artifacts/engine/ios/Flutter.framework
profile 66.8M
flutter/bin/cache/artifacts/engine/ios-profile/Flutter.framework
quesion：
1.My understanding is that the release version should take less space than the debug part
itself
2. Why is it so big.  i can not understand.
thanks

Please check this answer for your answer
Duplicate of #47101


docs: fix in custom metric

Slight changes on custom metric documentation

docs/docs/metrics-custom.mdx: In the LatencyMetric class, the measure method now uses additional_metadata for latency instead of directly accessing the latency attribute. There is a restriction otherwise on the LLMTestCase and the previous input in the class was causing an error.
docs/docs/metrics-custom.mdx: An asynchronous a_measure method was added to the LatencyMetric class. This method needs to be defined for the code to execute. It can be replaced with an async function by the user.
docs/docs/metrics-custom.mdx: The instantiation of LLMTestCase was updated to include latency in additional_metadata.

@imanousar Thank you so much! (we didn't document additional metadata, but glad you found it too!)


Tracking issue for a new AXS release

Spark 3.0 has been out for a while, and that seems like a good chance to collect all the improvements we've had laying around, merge them, and make a new AXS release. I'm opening this as a sort of meta-issue for keeping track of what we think is most important to include. @mjuric @zecevicp @stevenstetzler, let me know in the comments what your thoughts are and I'll try and keep this post updated with a combined list and status. If there's no significant disagreement on these, I'll start fixing and merging them.
Small fixes/improvements:

Rebase axs-spark onto the Spark 3.0 release. I've done that for a pre-release version, so it should be quick to update for the final release. (https://github.com/astronomy-commons/axs-spark/tree/axs-3.0.0-preview)
#6 "save_axs_table() deletes files from path". We got bit by this again, need to remove the options that allow that to happen.
#19 "Cannot use local Derby database for Spark > 2.4.0". I think we just need to find the right place to set this default, iirc.
#12 "histogram2d doesn't exclude out-of-bounds entries". Already have code on a branch, just need to test and merge.
#24 "dec_to_zone should use AxsFrame zone height rather than the default value "
#25 "Warn if AxsFrame.crossmatch uses a radius larger than the zone height"
Add healpix_hist. Mario wrote this function and we've been copy-pasting it a lot; we should include it.

Larger improvements:

Automated builds with github actions. @stevenstetzler has PR #18 open to work on that; is it ready to go?
I believe there was still some variation in the crossmatch radius towards the poles (might have been an email chain instead of a github issue). There's also issue #22 on distance calculation. I remember doing some investigation on this, but I need to pull up the results.

I'm sure there's other things I've forgotten. We'll also have to pick a new version number 🙂

Automated builds with github actions. @stevenstetzler has PR #18 open to work on that; is it ready to go?

Yeah, the automated builds seem to work still. I recently used it to make a new Spark 3 release with an updated version of Scala (I was running into similar issues as @stargaser using Spark 3 with AXS until I updated Scala).
After learning more about how AXS integrates with Spark (axs from this repository is a drop-in jar you can add to any version of Spark, but won't work unless Spark was compiled from axs-spark with our changes), I'd recommend that we split the build up into two build tasks into the two separate repositories we have. i.e. make an axs-spark release for each major version i.e. Spark 2.4, 3.0 and preview versions. And then in this repository, build and version control the AXS jar separately, pairing it with different versions of Spark. Correct me if this won't work, but I think this would let us for example patch the AxsCatalog.crossmatch functionality and pair it with Spark 2.4 and Spark 3 builds from axs-spark, meaning we don't have to tie specific functionality of AXS to specific versions of Spark.
Either way, I think we can tweak and merge that PR and have automatic releases working out of the box.

I have a fix for #22 in this commit  and a fix for #23 in another commit. I started my branch from @stevenstetzler's fork so that I could build from source with the right Scala version and test at IPAC. Should I make a PR to that fork? Or would it be better to cherry-pick the individual commits?
The second fix involves taking the cosine of Declination columns and that might impact the speed of crossmatching.

Thanks a ton @stargaser, that's super useful! A PR off of Steven's fork sounds perfect. I'm hoping to find some time in the next few days to start working on these.

Thanks @ctslater, I will make a PR to Steven's fork. The fixes for the poles are not fully working: I made a 2D histogram of Gaia DR2 matched with CatWISE in Galactic coordinates, just around the north celestial pole, and that looked great; but a 2D histogram of the whole sky is not working at all. I'm still debugging it.

The PR for the fix for the poles is stevenstetzler/axs#1.

Quick update on the release process: I've made fixes for all of the issues listed in my initial post and have merged them to an integration branch (on both axs and axs-spark), and produced a beta release available at: https://github.com/astronomy-commons/axs/releases/tag/v1.1-beta1. The most important fix was to get the crossmatch radius consistent over all dec, and I believe that the modifications I made to the crossmatch query do so, but I'm very interested in any cases where it still seems to be misbehaving.
The main hassle for anyone trying to switch to this (beta) release is that the default schema version for the metastore has changed, and newer spark versions don't fallback to reading old metastores without changing spark-defaults.conf to tell spark to load the old versions of Hive JARs. That's feasible but annoyingly complicated (it download the necessary jars at runtime), so I recommend avoiding it if possible. I assume there's some way to do schema migration; I will post an update if I manage to do that successfully.
Any additional bug reports are welcome. I'm going to keep testing this for a while and if nothing new pops up, we'll call it a release.

@ctslater thanks for the updates. We want to test the beta release at IRSA but it looks it will be about a week before we can do that, after the AAS 238 meeting.


Hook IntervalMetadataMixin to Sequence and GrammaredSequence classes.

This is ready for review, @mortonjt and @wasade . Thanks!

You can always add overlapping interval features into a interval metadata
object. I think we are still talking on different pages. Hope this
docstring I will add helps clarify your confusion?
        Concatenate an iterable of ``IntervalMetadata`` objects.

        It concatenates the multiple ``IntervalMetadata`` objects into
        one coordinate space. The order of the objects in the input
        iterable matters. The coordinate of the second
        ``InterableMetadata`` will be shifted up with the length of
        the first ``IntervalMetadata`` object.

        This function is useful when you concatenate multiple sequences.

On Mon, Oct 3, 2016 at 4:54 PM, Daniel McDonald<EMAIL_ADDRESS>wrote:

@wasade commented on this pull request.
In skbio/metadata/_interval.py
https://github.com/biocore/scikit-bio/pull/1430:

   if len(intvl_metadata) == 0:

       return cls(0)

   upper_bound = 0

   for im in intvl_metadata:

       upper_bound += im.upper_bound

   new = cls(upper_bound)

   length = 0

   for i, im in enumerate(intvl_metadata):

       for intvl in im._intervals:

           bounds = intvl.bounds

           fuzzy = intvl.fuzzy

           if i != 0:

               bounds = [(start + length, end + length)

Okay, thanks. So it isn't possible to concatenate overlapping intervals?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/biocore/scikit-bio/pull/1430, or mute the thread
https://github.com/notifications/unsubscribe-auth/AA9CeHCizGc5PQt4XKdeyqxrBMNrV-yuks5qwZWugaJpZM4KJM2C
.

Oh, I see now re: concatenation, that makes sense especially for MSAs and concatenating gene family MSAs

It looks like there are a few minor comments bringing brought to attention here, suggesting that this PR is getting very close to being merge-able (thanks @RNAer).  @ebolyen @jairideout would you like to take a pass at this?

Thanks, @ebolyen ! what would you like me to do with your 1st general comment? add a clarification in the docstring of these methods (iter, reversed, iter_contiguous, iter_kmers, find_motifs)?

Sorry, the first general comment doesn't need action, just confirming the situation.

@ebolyen , all the requested tests are added and changes are made. it passed make test on my machine. only waiting for the @jwdebelius 's fix (thanks).

@ebolyen and @jairideout , I addressed all the comments. could you do a final pass? thanks!

Thanks @RNAer!

yay! Thanks to all the reviewers! I will put on genbank PR soon.
On Tue, Oct 18, 2016 at 4:27 PM, Jai Ram Rideout<EMAIL_ADDRESS>wrote:

Thanks @RNAer https://github.com/RNAer!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/biocore/scikit-bio/pull/1430#issuecomment-254668351,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AA9CeHSNPsC52Uww-wyWAotmPklWXMvgks5q1VXOgaJpZM4KJM2C
.


tincan.js nor build system not found

I've cloned the repo and started an http server for the folder. But I get a 404 for this file. https://github.com/RusticiSoftware/TinCan_Prototypes/blob/master/index.html#L78
I looked for a build system/scripts, but could not find any. For now, I'm cloning and copying this folder https://github.com/RusticiSoftware/TinCanJS/tree/master/build

Did you git submodule update --init --recursive after clone?

I missed that. Thanks @brianjmiller


[Feature]: Copy button on volume name

Is there an existing issue for this?

[X] I have searched the existing issues

Summary
Hi,
Can you add copy button on volume name? Example:

Why should this be worked on?
n/a

I'm closing this issue, because tracking features will be moved to GitHub discussions. Github issues will be only for bugs.
Version 4 is in full focus. v3 related issues will be closed, if it is not a critical bug.
Thanks for your understanding.


Remove option of Unfollow for Non Following User !

The unfollow option is also showing for the user that we don't follow!

@PraveenMalethia don't forget to add your issues/PRs to the project board pleaase !!

grabbing this one


Move tests out of the python package

The latest release of setuptools has become smart on what
files to include in a distribution and which once not.
Let's follow their advice to reduce the perceived complexity of this project.
Changes:

move /hijack/tests to /tests (PyTest)
move /hijack/static/hijack/tests to /tests/tests (Jest)

@codingjoe Offtop question. Why have you decided to use flit?
I just looking into https://hatch.pypa.io/latest/. And in comparison it looks better than anything else to me.
Just interested in your experience.

@codingjoe Offtop question. Why have you decided to use flit? I just looking into https://hatch.pypa.io/latest/. And in comparison it looks better than anything else to me. Just interested in your experience.

Hm… hatch wasn't really where it is today. Flit was the reference implementation for PEP 621, so I went with it. Afterward, I never felt compelled to switch. I don't really need/want all of hatch's features/dependencies 🤷♂


Leverage CPU and Memory in docker build

docker build now supports -c- and -m. We should leverage this when scheduling a build on the cluster.

Duplicate of #694


SPIKE: Multithreading in WASM

We need to investigate whether enabling multithreading in the compiled @namada/shared wasm is cross-browser compatible.

Can Wasm loaded by Namadillo be set to use multithreading, as we once did in the Chrome extension (via spawning web-workers)?
If so, will this be cross-browser compatible (Chrome, Firefox, Chrome-based browsers)?

Will add notes from research below:
TBD

Closing as this has been confirmed to work


Update indexing copy delete

Indexing for copy and delete commands have been updated to the same as the edit command.

Looks good to merge!


Carrier for international Tickets

For international crossboarder tickets, the carrier code (as example 1185) must be printed on the ticket.
The distributor should be able to print it, based on information he gather from the fare provider.
I have expected such a parameter at the endpoint of the offer in the fare part, but it is not available there.
I suggest adding this parameter as a mandatory parameter.

The carrier(s)  are part of the regional validity of the fares in the offer. The carriers can be related to the entire route of parts of it.

Thanks @CGantert345 , I already saw that, but I had a different interpretation.
Still, I think it would make sense to define this value as mandatory as it is required for cross-border tickets and the aim of the fare is to use it in a cross-border context.
I fear, when it is not defined as madatory, some will deliver it, some not and at the end we have a heterogenious situation

@patrickludwig77 Isn't such desired parameter the Fulfillment.issuer? Nevertheless, OSDM is multi-modal standard and I believe that such required property would not work outside the rail sector.

Hi @jspetrak
No, issuer and carrier is not the same.

Issuer is the on generating (issuing) the ticket and the one who has to guarantee for the custommer rights and pay any compensations in case of delay and so on.
The carrier is the one running the train.

This rules are based on UIC and especially for crossborder tickets both must be printed on the ticket. And therefore it must be available in the farebased approach.
With all understanding for a multimodal model, from my point of view fields must be mandatory which are required by the regulator for certain usecases, especially when we like to define this model as standard for one (rail) sector.
I do not know the rules given by EU law for other international transport sectors, but I assume the are similar than the one for rail.
When we do not dfine it as mandatory we will definitvley end in a hetergonious situation what we should prevent.

TODO Clemens: add comment on fare for carriercConstraint to have an obligatory carrier constraint on fare level including all carriers in the includedCarrier list.


mobile: briefly explore better archiecture

What I'm trying to do
Find out if the current architecture for the mobile package can be improved.
Expected result
Better architecture that reduces the size of the codebase and makes it easier to update controllers.
Sample code / test case
Instead of:
agent := ariesagent.New(opts)
didExController,  _ := agent.GetDIDExchangeController()
respEnvelope := didexController.DoSomething(params)

end up with the one of the following:

remove controller step

agent := ariesagent.New(opts)
respEnvelope := agent.Execute("DIDExchange", "DoSomething", params)

retain controller but have a generic execute handler function

agent := ariesagent.New(opts)
didExController,  _ := agent.GetDIDExchangeController()
respEnvelope := didexController.Execute("DoSomething", params)

Closing this as the benefits are minuscule compared to the changes required and the current deadlines.


prototype for potential traverse and scan separation solution

This solution hopes to separate traversing through an openapi doc and incompatibility scanning at each level.

OpenAPIIncompatibilityRule is an incompatibility-scanning interface which can present an identifier to demonstrate on what OpenAPI object it can scan on and a function which reports a single incompatibility
OpenAPITraversal is a traversal interface which requires  the ability to accept one or more OpenAPIIncompatibilityRule and it has a traverse function which given any input should return a list of incompatibilities.
These interfaces were made to be abstract and to keep each section of logic separated when possible. I implemented a struct for each of these interfaces for a OpenAPI document at openapi-document.go and for a OpenAPI path item at openapi-paths.go

Moving forward with imperative solution


Fix small typo in Rich Repr documentation

Type of changes

[ ] Bug fix
[ ] New feature
[x] Documentation / docstrings
[ ] Tests
[ ] Other

Checklist

[ ] I've run the latest black with default args on new code.
[ ] I've updated CHANGELOG.md and CONTRIBUTORS.md where appropriate.
[ ] I've added tests for new code.
[ ] I accept that @willmcgugan may be pedantic in the code review.

Description
Fixes a small typo.

Thanks!


Better getting started docs

Hi,
I wanted to try gopium out on a repo I've been trying to optimize, but just getting started with it is a little confusing. Here is what I found confusing:

What is a walker?
What is a strategy?
What do the struct tags do?
When I took the example in the cmdline output 'gopium -r ^A json_std 1pkg/gopium filter_pads memory_pack separate_padding_cpu_l1_top separate_padding_cpu_l1_bottom' and tried to modify it to work on my package, I got 'can't build such walker "json_std" walker "json_std" wasn't found' - but it's unclear what a walker is so I'm not sure if this is something I provide or an issue with gopium

Essentially I'm asking for getting started docs that are aimed at someone who knows nothing about gopium.
Thanks,
I'm excited to try gopium, but need some more help getting started.

Yeah, you highlighted fair points - gopium definitely lacks some beginner documentation. There is doc at https://github.com/1pkg/gopium/blob/master/cmd/gopium/README.MD which describes CLI part a bit better, but i guess it should be better access to this info in root README too. So I will copy/rework some data from there to root README.
On json_std, initially there were *_std walker pair for any walker from there https://github.com/1pkg/gopium/blob/master/cmd/gopium/README.MD#walkers-and-formatters, but i decided  to remove them eventually to not overcomplicate the walkers list, and forgot to update example.

Figured I'd comment here instead of open an issue as its related to getting started. The instructions for downloading and updating do not work:
<~>-> go get -u github.com/1pkg/gopium/cmd/gopium
# cd /home/solidity/go/src/github.com/1pkg/gopium; git submodule update --init --recursive
fatal: remote error: upload-pack: not our ref 5cf47dad5143b9c1a7802ba744a49936ddd08f6b
fatal: the remote end hung up unexpectedly
Fetched in submodule path 'cmd/vscode/src/vscode-go', but it did not contain 5cf47dad5143b9c1a7802ba744a49936ddd08f6b. Direct fetching of that commit failed.
package github.com/1pkg/gopium/cmd/gopium: exit status 1
<~>-1->

@bonedaddy thank you for pointing, it's really weird one ...
So what is happening: initially I vendored vscode-go as git submodule  to simplify development, then i created github release for v1.0.0 which created tag internally on gopium but not on submodule 😄. Now to the problem, it seems that -u flag for go get does not only pull last tagged commit on requested module/repo but also pulls latest tag on submodules too ... and lates tag on vscode-go is 0.14.2. So git is going crazy as it can't pull v1.0.0 consistently on all dependencies so go get is failing. Cool story!
I will create a separate issue for that, meanwhile  just plain go get github.com/1pkg/gopium/cmd/gopium works as expected so I update doc to reflect that we should use just go get github.com/1pkg/gopium/cmd/gopium until I will figure out how to fix this submodule madness.

Go get -u issue was fixed in https://github.com/1pkg/gopium/issues/8

Thanks! this is a lot better, I did get it to run, still not sure I'm getting the results I should.
If you were really motivated you'd take a small go package and then do a screen recording of you using the tool to optimize it, assuming your audience knows nothing of gopium.
I realize this is a big ask, it really depends upon how much you want to evangelize your project. I'm terrible at evangelizing my open source work, and life usually gets in the way.
I think you've created an interesting tool, which has a high learning curve because of the complexity of the various optimization options that are available.
Thanks!


HBASE-28230 Update branch-2 version to 2.7-SNAPSHOT

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 40s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ branch-2 Compile Tests _

+1 :green_heart:
mvninstall
3m  0s
branch-2 passed

+1 :green_heart:
compile
5m  9s
branch-2 passed

+1 :green_heart:
spotless
0m 43s
branch has no errors when running spotless:check.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
2m 43s
the patch passed

+1 :green_heart:
compile
5m  4s
the patch passed

+1 :green_heart:
javac
5m  4s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
xml
0m  1s
The patch has no ill-formed XML file.

+1 :green_heart:
hadoopcheck
14m 54s
Patch does not cause any errors with Hadoop 2.10.2 or 3.2.4 3.3.6.

+1 :green_heart:
spotless
0m 41s
patch has no errors when running spotless:check.

_ Other Tests _

+1 :green_heart:
asflicense
0m 11s
The patch does not generate ASF License warnings.

34m 25s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5552/1/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/5552

Optional Tests
dupname asflicense javac hadoopcheck spotless xml compile

uname
Linux 19c8938006fb 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2 / a91e93349f

Default Java
Eclipse Adoptium-11.0.17+8

Max. process+thread count
81 (vs. ulimit of 30000)

modules
C: . U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5552/1/console

versions
git=2.34.1 maven=3.8.6

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 39s
Docker mode activated.

-0 :warning:
yetus
0m  6s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ branch-2 Compile Tests _

+1 :green_heart:
mvninstall
3m 12s
branch-2 passed

+1 :green_heart:
compile
2m  0s
branch-2 passed

+1 :green_heart:
shadedjars
5m 41s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
1m 55s
branch-2 passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
2m 46s
the patch passed

+1 :green_heart:
compile
2m  2s
the patch passed

+1 :green_heart:
javac
2m  2s
the patch passed

+1 :green_heart:
shadedjars
5m 38s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
1m 52s
the patch passed

_ Other Tests _

-1 :x:
unit
273m  7s
root in the patch failed.

305m 44s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5552/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/5552

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux ad3a53c65456 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2 / a91e93349f

Default Java
Eclipse Adoptium-11.0.17+8

unit
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5552/1/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-root.txt

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5552/1/testReport/

Max. process+thread count
5311 (vs. ulimit of 30000)

modules
C: . U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5552/1/console

versions
git=2.34.1 maven=3.8.6

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 44s
Docker mode activated.

-0 :warning:
yetus
0m  6s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ branch-2 Compile Tests _

+1 :green_heart:
mvninstall
2m 40s
branch-2 passed

+1 :green_heart:
compile
1m 35s
branch-2 passed

+1 :green_heart:
shadedjars
5m  3s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
1m 31s
branch-2 passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
2m 18s
the patch passed

+1 :green_heart:
compile
1m 34s
the patch passed

+1 :green_heart:
javac
1m 34s
the patch passed

+1 :green_heart:
shadedjars
5m  2s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
1m 28s
the patch passed

_ Other Tests _

-1 :x:
unit
370m 58s
root in the patch failed.

399m 37s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5552/1/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/5552

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 0c7fe14dc37f 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2 / a91e93349f

Default Java
Temurin-1.8.0_352-b08

unit
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5552/1/artifact/yetus-jdk8-hadoop2-check/output/patch-unit-root.txt

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5552/1/testReport/

Max. process+thread count
7987 (vs. ulimit of 30000)

modules
C: . U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5552/1/console

versions
git=2.34.1 maven=3.8.6

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.


Request to a service with self signed SSL certificate

I'm trying to create a client to SOAP service that runs over HTTPS using self-signed SSL certificate:
var soap = require('soap');
var url = 'https://example.com/wsdl/Service.wsdl';

soap.createClient(url, function (err, client) {
  if (err) {
    return console.log(err.message);
  }
  console.log(client.describe());
});

However I get error: [Error: DEPTH_ZERO_SELF_SIGNED_CERT]. Is there some kind of option to avoid this behavior?

Add the cert to your trusted list at you computer or add
process.env.NODE_TLS_REJECT_UNAUTHORIZED = "0"
to your code.

I realize this is a bit of an old post, however I recently had this problem. While @tesfel suggestion is nice, it opens vulnerabilities. I was able to solve this problem via adding the certificates or certificate chain used on the soap server. In particular, I had to add the certificates in two locations, creating the client and the setting the security.
createClient
It took some digging, but I found the process to validate a server certificate or use a self-signed certificate on a server. To do this simply make use  of the 'options' parameter for createClient. To set the certificate(s) used by the server set the 'wsdl_options.ca' element. This element takes in an array of Base 64 certificates. Here is an example of how to complete this:
var cert = ['-----BEGIN CERTIFICATE-----\n....--END CERTIFICATE-----'];
var list_cert = [ '-----BEGIN CERTIFICATE-----\n....--END CERTIFICATE-----', ..., '-----BEGIN CERTIFICATE-----\n....--END CERTIFICATE-----'];

var options = {
    wsdl_options: {
        ca: cert,
    },
};
soap.createClient(soap_wsdl, options, function(error, client) {
    if(error) {
        console.log(error)
        return
    }
    client.MyFunction(args, function(err, result) {
        console.log(result);
    });
});

setSecurity
Additionally, you can also run into the self-signed certificate error if you are using an authentication format. Again the solution is to set the ca property in the options parameter of the different security objects. Here is an example for BasicAuthSecurity.
securitySettings = { ca: ['-----BEGIN CERTIFICATE-----\n....--END CERTIFICATE-----'] };
client.setSecurity(new soap.BasicAuthSecurity(username, password, securitySettings));

I will try to work up a documentation pull request to help document this process.

please do @brmarick !


style(cpp/h): clang-format

A re-factored version of pr from #115.

This is a bad commit message "style(cpp/h)". Simply use "chore: format cpp codes"

It seems the current black.sh cannot work for your PR. I fixed it in this PR https://github.com/jina-ai/annlite/pull/118. Please rebased your PR.


Incompatible units. 'px' , '%'

I know this issue was raised before but is seems that there is no straight forward answer.
from clean install ( bower ) I am getting Incompatible units error ( _variables line 209 )
Any ideas please?

Please post the full error message and state which Sass compiler you're using.

This can happen when you override a variable using units that are not the same as the default.
See #750.


angular-shepherd

Hi. According to the official documentation there is stepsContainer property, how can I get it and set this a setting using angular-shepherd?

@AMZALE I moved the issue to the correct code base to better address.
In this library's README, you can see that tour level options from the docs can be set on the service.  e.g.,
import { Component, AfterViewInit } from '@angular/core';
import { ShepherdService } from 'angular-shepherd';
import { steps as defaultSteps, defaultStepOptions} from '../data';

@Component({
  selector: 'shepherd',
  templateUrl: './shepherd.component.html',
  styleUrls: ['./shepherd.component.css']
})
export class ShepherdComponent implements AfterViewInit {

  constructor(private shepherdService: ShepherdService) { }

  ngAfterViewInit() {
    this.shepherdService.defaultStepOptions = defaultStepOptions;
    this.shepherdService.modal = true;
    this.shepherdService.confirmCancel = false;
    this.shepherdService.stepsContainer = document.getElementById('#container-selector'); // this must be an HTMLElement
    this.shepherdService.addSteps(defaultSteps);
    this.shepherdService.start();
  }
}

@chuckcarpenter which version angular-shepherd do you use ? because this property is not available
all properties  are available from ShepherdService
confirmCancel: boolean;
confirmCancelMessage: string;
defaultStepOptions: Step.StepOptions;
errorTitle: any;
isActive: boolean;
keyboardNavigation: boolean;
messageForUser: string;
modal: boolean;
requiredElements: any[];
tourName: any;
tourObject: Shepherd.Tour;
exitOnEsc: boolean;

@AMZALE I see, it could be set on the tourObject in the options before starting the tour, or I agree it would need to be added to be set before initialize. Happy to take a PR to add that if you prefer?

@chuckcarpenter  ok thank, it would be nice


Example: Emotion face recognition

Fixes #150

Training does work at the moment. We should try it again while arcface fine-tuning is available.

Training does work at the moment. We should try it again while arcface fine-tuning is available.


Fix broken links to jobs metadata file

Yes, thanks a lot @mcarbonell-paymefy for the update. All good !


Fixed frontend not working on others people computers because someone copied and pasted a wrong gitignore

That was making the wwwroot folder vanish on the oblivion of the cyber space. Hopefully this update solves all the problems of the project, changes the front end project name, remove the src folder in the solution inside visual studio, and perhaps it will also cure cancer who knows

ayo bruh dont talk like that on my gitignore file man this thing have been workin good as a charm from a long time this is the first time ive used this wit blazor 😭😭😭😭

I will sneaky in the src/ folder to see if u notice it


Add new channels configs

Fixes #512
Proposed Changes

adding kafka channels (CRD / CCP) to release script (#512)
adding natss channel (CRD) to release script (was not added with #491)

Release Note
Fixes issue from 0.8.0 to include the missing kafka channels on eventing-contrib release

@grantr besides the missing kafka, I also added the natss channel CRD (since touching the file), since the PR for adding it was also not updating the release script


Error occured while trying to proxy in demo browsersync

When i try to execute the demo of browsersync appears the error
Error occured while trying to proxy to: localhost:8080/users
"browser-sync": "^2.16.0",
"http-proxy-middleware": "^0.17.1"

Just tested the browser-sync proxy example without any issues:
$ node examples/browser-sync/
[HPM] Proxy created: /users  ->  http://jsonplaceholder.typicode.com
[HPM] Subscribed to http-proxy events:  [ 'error', 'close' ]
[DEMO] Server: listening on port 3000
[DEMO] Opening: http://localhost:3000/users
[BS] Access URLs:
 ---------------------------------------------
       Local: http://localhost:3000/users
    External: http://<IP_ADDRESS>:3000/users
 ---------------------------------------------
          UI: http://localhost:3001
 UI External: http://<IP_ADDRESS>:3001
 ---------------------------------------------
[BS] Serving files from: ./
[HPM] GET /users -> http://jsonplaceholder.typicode.com

Did you modified the example?

Could be because im behind a corporate proxy?
i have to config something more in this case?
i didn't modified the example

The corporate proxy could be the issue.
Try configuring it this way: https://github.com/chimurai/http-proxy-middleware/blob/master/recipes/corporate-proxy.md

Closing issue due lack of response. Feel free to re-open issue.

https://github.com/chimurai/http-proxy-middleware/blob/master/recipes/corporate-proxy.md
isn't works,
it's nothing to do with "https".


[SP-5324] Backport of PDI-18214 - If SQL fails in transformations ran on the Pentaho Server, the database connections are not closed. (8.3 Suite)

Merge Masters: @pentaho-lmartins  and @smmribeiro
Cherry-picks:

https://github.com/Pentaho/pentaho-kettle/commit/392454f5eb5c3a03aef23c7a5a3350353f96d0d3

:white_check_mark: Build finished in 18m 35s
Build command:
mvn clean verify -B -e -Daudit -amd -pl engine

:ok_hand: All tests passed!
Tests run: 3529, Failures: 0, Skipped: 7    Test Results

:information_source:  This is an automatic message

:white_check_mark: Build finished in 25m 47s
Build command:
mvn clean verify -B -e -Daudit -amd -pl engine

:ok_hand: All tests passed!
Tests run: 3529, Failures: 0, Skipped: 7    Test Results

:information_source:  This is an automatic message

:white_check_mark: Build finished in 25m 45s
Build command:
mvn clean verify -B -e -Daudit -amd -pl engine

:ok_hand: All tests passed!
Tests run: 3532, Failures: 0, Skipped: 7    Test Results

:information_source:  This is an automatic message


Update route writer to be more flexible and dynamic

Is your feature request related to a problem? Please describe.
The current issue pertains to the manual creation of routes in our web framework CLI. Creating a route requires manual checking if a similar route already exists. This process is time-consuming and error-prone, especially when there is a need to distinguish between different types of the same route name, like GET and POST.
Describe the solution you'd like
I propose a feature in the CLI for route creation that will automate the process and improve efficiency. The new feature should do the following:

Ask for the type of route (GET, POST, etc.).
Automatically check if a similar route already exists in the application.
If a similar route exists but with a different type (like a GET when we want a POST for the same route name), it should allow the creation of the new route.
Write the new route in the appropriate place in the codebase.

The feature should be intelligent enough to handle all these processes seamlessly, reducing the chance of errors and improving the speed of development.
Describe alternatives you've considered
An alternative solution could be enhancing our code editor with a plugin or extension that performs a similar function - checking for existing routes and warning the developer if a new route creation might cause conflicts. However, this might require more work and is dependent on the specific editor used, so integrating this feature directly into our CLI seems to be the more universally applicable solution.
Additional context
Incorporating this feature would reduce the cognitive load on developers, allowing them to focus on critical aspects of their work rather than manually managing routes. It can also prevent potential issues that could arise from human errors in this process, ultimately leading to a more robust application.

done


Willie/grant read

We are now using S3's replication feature to replicate our database backup data created by cryo here. It turns out... even after an object is replicated, it belongs to the source account. This means that the destination account does not actually have read access to these files unless explicitly granted the ACL read permissions. This PR grants said permissions if the S3_ACL_GRANT_READ_GRANTEE env variable is provided, otherwise it just ignores the option. This was tested.
@philsno @ktrice

@philsnow

:+1:

Phil feel free to add comments. I'm going to merge this to move this along.


main: line 79: type: curl: not found error in Ubuntu

Bug information
Steps to reproduce (required)

docker run -ti --rm ubuntu /bin/bash command is to start Ubuntu container locally.
Within the container I run apt update && apt upgrade and apt install wget to install wget.
Then I download Radius by running wget -q "https://raw.githubusercontent.com/radius-project/radius/main/deploy/install.sh" -O - | /bin/bash.
Radius is installed but I get the following error main: line 79: type: curl: not found as the first output of the wget command right above.

Observed behavior (required)

Desired behavior (required)
No error that says: main: line 79: type: curl: not found. Should we update the error message saying that curl couldn't be found continuing with wget or something like that?
Workaround (optional)
If I run apt install curl, I don't see the error.
System information
rad Version (required)
RELEASE   VERSION   BICEP     COMMIT
0.26.9    v0.26.9   0.11.90   421a2aeef9e0a8a5c487a8ad6b17719c4826e350
Operating system (required)
aarch64 - Ubuntu - Docker
Additional context
AB#10005

script is handling curl and wget properly. but we uses > /dev/null instead of &> /dev/null. In linux bash > doesn't catch error whereas zsh in mac catches error out.
https://github.com/radius-project/radius/blob/c0accc62ac3791d5c5ee90958749a395db51877b/deploy/install.sh#L78-L87


'no-outline-none' should also check for 'border: none'.

Right now, these two scenarios trigger an error/warning for the 'no-outline-none' rule:
&:focus {
    border: 0;
    outline: none;
}

&:focus {
    border: transparent;
    outline: none;
}

But this one does not trigger an error/warning:
&:focus {
    border: none;
    outline: none;
}

Looking at the code for the 'no-outline-none' rule, adding an extra check for 'none' should be a small change.
Assuming there's no underlying reason to ignore 'none'.

I did a bit more digging, and border: 0 is also ignored. My initial message said it did trigger an error/warning.
You can check a demo link here.


[credits] ensure calculation of production done right

[ ] add in updater a field is_nondegree
[x] check how courses that have many providers are calculated, should not be calculated twice
[ ] informoidaan Helena Åstrom ja koulutusohjelmatoimikunta, kun tieto, miten edellinen menee.
[ ] how is minor is calculated for students who have to studyrights?
[ ] are transferred students correctly categorized

Share fix implemented, categories changed to rapo. I will make new issues about the further work


RowExpander's multiLevel example is broken

The multilevel GridPanel example in version 4 is broken. On expanding the first grid row, no content is displayed inside it.
http://examples4.ext.net/#/GridPanel/RowExpander/MultiLevel_GridPanel/
Ext.NET forum thread: Error on an example...
Found: 4.1.0

Any update ? we are also facing rowExpander grid expand issue in version 4.1 while working fine in ext 2.0

Hello @sohelvali,
I guess it is fixed with this issue: extnet/Ext.NET#1341.

Thanks.


Normal maps don't affect ReflectionProbes in GLES2

Godot version:
3.2.3
OS/device including version:
Windows 10 RTX2060
Issue description:
Using a SpatialMaterial with a normal map doesn't perturb a ReflectionProbe reflection,
but it does perturb a WorldEnvironment background reflection.
(The quad on the left is reflecting a checkerboard quad out of view)

AFAIK this behavior is undocumented, so I assume it's not a shader optimization?
Steps to reproduce:

Create any mesh with a SpatialMaterial and give it a normal map
Place a ReflectionProbe into the scene
Move that mesh into the ReflectionProbe

The mesh will use the mesh's unperturbed normals for sampling the ReflectionProbe.
Minimal reproduction project:
normalMapReflection.zip

My guess is that this will be fixed by changing this line (and the equivalent for reflection probes 2) to "normal" instead of "normal_interp"
https://github.com/godotengine/godot/blob/17eb869231b044ac0a744ea49b43e045a6312c35/drivers/gles2/shaders/scene.glsl#L1603
Normal is the normal with normalmaps applied. While normal_interp comes straight from the vertex function.

@clayjohn What a very educated guess! :)

Fixed by #43885.


net/url: Fails to parse URLs with spaces in scope IDs in 1.6beta2

Test program:
package main

import (
	"fmt"
	"net/url"
)

func main() {
	u, err := url.Parse("tcp://[fe80::cefa:ff:fef3:5fcc%25Wireless%20Network%20Connection]:22000")
	if err != nil {
		fmt.Println(err)
	} else {
		fmt.Println("OK:", u)
	}
}

Fine in 1.5.2:
jb@syno:~/tmp $ go version
go version go1.5.2 darwin/amd64
jb@syno:~/tmp $ go run test.go
OK: tcp://[fe80::cefa:ff:fef3:5fcc%25Wireless%20Network%20Connection]:22000

Errors in 1.6beta2:
jb@syno:~/tmp $ go run test.go
parse tcp://[fe80::cefa:ff:fef3:5fcc%25Wireless%20Network%20Connection]:22000: invalid URL escape "%20"
jb@syno:~/tmp $ go version
go version devel +66330d8 Wed Jan 13 23:40:13 2016 +0000 darwin/amd64

That's how Windows represents scope IDs.

@rsc, you touched this last. Maybe you still remember all the spec rules and Go decisions made?

We started rejecting spaces in host names, which is generally correct. I guess we have to accept spaces in the %-encoded scope section. Ugh.

CL 18855.

Windows: putting spaces where they don't belong since Windows NT 3.1.

Purely out of interest: Windows uses the Scope ID of the network interface in question as the zone identifier. This is a long, so zones typically have the value %1, %2, etc.
Using the network interface name on Windows seems to be a Go thing. Presumably there's good reason, although it does make taking URLs formatted by Go and parsing them in other languages slightly tricky.

/cc @calmh, @mikioh, @alexbrainman for feedback. Where did the OP's URL/scope ID come from?

That's from String() on a net.Addr returned from Read...() on an UDP socket (whatever the exact read method is that returns the packet plus the source address, I'm on mobile currently). We that put that address in as the Host in a url.URL which in turn gets stringified and sent over the network. The other side does url.Parse which results in the above.

@rsc, given @calmh's comment, I think your fix above isn't necessary. I think we need to fix the String method instead.

I'm not changing the String method to emit an encoded URL with literal spaces in it. URLs do not have spaces. Full stop.

There's some notion that we should be using %1 instead of %AdapterName, but I don't know where the 1 comes from and I don't know if it works to send it over the network.

As a side note, url.Parse also does not accept spaces in the host name (in the scope ID or otherwise), so that wouldn't be an immediate fix. Perhaps it could be taught to do so, but it seems cleanest to do the escaping as it currently does and then accept that back.

Actually the "send over network" part in my description is both incorrect and irrelevant. It's just two packages where the interface between them is in terms of url.URLs to connect to and it so happens that some of these represent link local v6 addresses.

OK, well, the fact is that zone identifiers are allowed to have spaces, and this code was trying to make sure they were minimally escaped. Since you can't have a space in a URL, the space must be escaped. This code didn't allow that, and now it does. So I think everything here is in order.
There's some question about whether zone identifiers in practice use spaces, but it appears that at least in Go programs on Windows they do. Maybe that's a mistake, or maybe not, but it's too late in the release cycle to make a fundamental change like that in package net. The acceptance of %20 in the zone identifier is trivial, clearly safe, and consistent with RFCs. (The code in question was actually  being stricter than the RFCs and still is.)
If someone wants to open a separate bug, for Go 1.7, about maybe using %1 instead of "%Windows Ethernet Adapter" or whatever, that's fine.

That's from String() on a net.Addr returned from Read...() on an UDP socket
...
I think we need to fix the String method instead.
...
I'm not changing the String method to emit an encoded URL with literal spaces in it.

I think @bradfitz was referring to net.Addr.String(), not URL.String()? Maybe I'm misreading it...

Oh, the net.Addr.String method would make more sense. But the point in my final comment remains: it's fine if someone wants to look into fixing that for Go 1.7, but this seems to work for people in Go 1.6 and the URL change is not technically wrong, and the URL change is also less scary than changing the form of net.Addr.String this close to a release.


Parent Group Association Not Opening After Tab Switching

Current behavior
The parent group association fails to load or open, leaving the user unable to view or interact with the details.
Expected behavior
The parent group association should load and be fully functional when the user returns to the original tab.
Steps to reproduce the issue
Log in to the application.
Navigate to the Groups->Parent Group Association.
Open any parent group to view its details.
Switch to another tab(facilities, settings, parking).
Return to the original tab.
Attempt to open the parent group association of any parent group.
Observe the issue.
Environment details
App version : v1.9.2
App environment : UAT
Additional information
https://jam.dev/c/16f1a740-9e54-4f4d-b08d-d6f5206b4cc8

This will be fixed in the following PR - https://github.com/hotwax/facilities/pull/313

https://jam.dev/c/aae866ad-afcd-40a7-95cb-4bfe6db9fc85
Issue verified and working fine in release v1.9.3. Hence, closing this ticket.


RPC bug - “getstakingstatus”

in "getstakingstatus" command, staking status is always false

Now getstakingstatus is working properly.


starmapbuffs broken

the starmapbuffs mod makes my game unplayable. by clicking any system outside of the one i'm currently in I get this error:
https://i.imgur.com/SkoqL0s.png

Me too, i thought my other active mods are interfering with it or I'm missing something, hopefully this get fix, cuz its pretty cool


Easy Checks Review of Portfolio Web Accessibility

Easy checks performed on page tile
Complete the image text alternatives

I don't have coding partner I am working solo. My coding partner is absent since Monday.


Add assignee to suggestions

What are you trying to do that you can't?
We should be able to keep track of who is working on resolving a suggestion, and see that in the suggestion list. There's currently no where to put that information.
What is your idea?

[ ] Add an assignee to the suggestions table
[ ] Add a person drop down on the suggestion page
[ ] Replace the reporter with the assignee on the suggestions list

Resolved by d01dda0f2216143222a7d0395c474d8345b1f4d5.


tool to set API server url from kubeconfig

When we first set up a Tanka environment, we need to extract the API server URL from our kubeconfig.
For the current context and default namespace, this should do it:
APISERVER=$(kubectl config view --minify -o jsonpath='{.clusters[0].cluster.server}')
sed -i 's#"apiServer": ""#"apiServer": "'${APISERVER}'"#' environments/default/spec.json

If we are a new user to Kubernetes, this could confuse us. What if we were able to say something like this:
tk env set-server /environments/default  # set env from default kubeconfig context
tk env set-server /environments/default --context my-context # set env from specific kubeconfig context

Ramp up into Tanka would be substantially easier.

I suggest extending tk env set by --server-from-context (or even --context) instead, as it plays nicer with the current approach (`tk env set --server IP)

This has been done in #184


Add mermaid support

I needed to include flowcharts in my markdown files and mermaid looked like the best option out there. So I added support for it. The current implementation requires the mermaid script to be provided on the configurable path.

This change probably has no place in the main package. Could be a separate one, though.


or-tools 9.9

or-tools 9.9
Destination channel: defaults
Links

PKG-4123
dev_url (pypi): https://github.com/google/or-tools/tree/v9.9
diff 9.6.0-9.9.0: https://github.com/google/or-tools/compare/v9.6...v9.9
conda-forge: https://github.com/conda-forge/or-tools-feedstock/blob/main/recipe/meta.yaml
pypi: https://pypi.org/project/ortools/9.9.3963
pypi inspector: https://inspector.pypi.io/project/ortools/9.9.3963

Explanation of changes:

bump version
update pinnings
updated patches
TODO: pybind11_protobuf needs configuration

Linter check found the following problems:
ERROR conda.cli.main_run:execute(125): `conda run conda-lint /tmp/abs_d9pu38m0qa/clone` failed. (See above for error)
The following problems have been found:
===== WARNINGS =====

clone/recipe/meta.yaml:33: host_section_needs_exact_pinnings: Linked libraries host should have exact version pinnings.
clone/recipe/meta.yaml:143: host_section_needs_exact_pinnings: output "ortools-python": Linked libraries host should have exact version pinnings.
clone/recipe/meta.yaml:151: host_section_needs_exact_pinnings: output "ortools-python": Linked libraries host should have exact version pinnings.
clone/recipe/meta.yaml:70: host_section_needs_exact_pinnings: output "libortools": Linked libraries host should have exact version pinnings.
clone/recipe/meta.yaml:139: host_section_needs_exact_pinnings: output "ortools-python": Linked libraries host should have exact version pinnings.
clone/recipe/meta.yaml:142: host_section_needs_exact_pinnings: output "ortools-python": Linked libraries host should have exact version pinnings.

===== ERRORS =====

clone/recipe/build-python.sh:36: pip_install_args: output "ortools-python": pip install should be run with --no-deps and --no-build-isolation.
clone/recipe/meta.yaml:200: missing_documentation: The recipe is missing a doc_url or doc_source_url
clone/recipe/meta.yaml:94: missing_imports_or_run_test_py: output "libortools": Python packages require imports or a python test file in tests.
===== Final Report: =====
3 Errors and 6 Warnings were found


I can hear ads during interlude

Hi,
The interlude works and starts playing when ad begins, but I can hear both the interlude song and the ad together.
(Blockify 1.8.8 on Archlinux, pulseaudio, Spotify <IP_ADDRESS>)
Thanks for this great piece of software!

Hello psamim,
i couldn't reproduce your problem.
Can you provide more information? Before doing that, please read the Troubleshooting section of https://github.com/mikar/blockify/blob/master/README.md
Regards,
Max

No feedback, no problem ;)