\img Extension is not supported in v3.x

I just want to embed image to mathjax, when I did that in v2.x, It worked.
and I followed this guide "https://groups.google.com/g/mathjax-users/c/SXjY3rQXOzc/m/YGcc48HwDR4J"
but, When i tried that in v3.x, It didn't work.
Is there any way that I embed image in v3.x ?

You are right that the third-party extensions are not ported to v3 (they are maintained by their authors, not the MathJax team).  But here is a quick porting of the \img command to v3.  Note that you need to provide both width and height explicitly for v3, as it does not current measure the dimensions of the image for you, as version 2 did.
MathJax = {
  tex: {packages: {'[+]': ['img']}},
  startup: {
    ready() {
      const {Configuration} = MathJax._.input.tex.Configuration;
      const CommandMap = MathJax._.input.tex.SymbolMap.CommandMap;
      const TexError = MathJax._.input.tex.TexError.default;

      const CheckDimen = function (dimen) {
        if (dimen === '') return '';
        if (dimen.match(/^\s*([-+]?(\.\d+|\d+(\.\d*)?))\s*(pt|em|ex|mu|px|mm|cm|in|pc)\s*$/)) {
          return dimen.replace(/ /g, '');
        }
        throw new TexError('BadImageDimen', 'Bad dimension for image: %1', dimen);
      };
      new CommandMap('img', {img: 'Img'}, {
        Img(parser, name) {
          const arg = parser.GetBrackets(name, '');
          const def = {
            valign: '',
            width:  '',
            height: ''
          };
          if (arg.match(/[,=]/)) {
            for (const pair of arg.split(/\s*,\s*/)) {
              const [key, ...value] = pair.split(/\s*=\s*/);
              if (!def.hasOwnProperty(key)) throw new TexError('UnknownKey', 'Unknown parameter "%1" in %2', key, name);
              def[key] = CheckDimen(value.join('='));
            }
          } else {
            def.valign = CheckDimen(arg);
            def.width  = CheckDimen(parser.GetBrackets(name, ''));
            def.height = CheckDimen(parser.GetBrackets(name, ''));
          }
          def.src = parser.GetArgument(name);
          if (!def.valign) delete def.valign;
          if (!def.width)  delete def.width;
          if (!def.height) delete def.height;
          parser.Push(parser.create('token', 'mglyph', def));
        }
      });
      Configuration.create('img', {handler: {macro: ['img']}});

      MathJax.startup.defaultReady();
    }
  }
}

Thank you very much. It works.

FYI I've updated the copy of the old extension at https://github.com/pkra/mathjax-img/ for v3 with a v3 + NodeJS-compatible version.
@dvpc I hope the copyright notice is (still) ok with you.

I'm good with the copyright.  Thanks for making the update!


[cosmosdb] az cosmosdb restore Add new parameter to restore command: public-network-access

Related command
az cosmosdb restore --target-database-account-name --account-name --restore-timestamp -g --location --enable-public-network <TRUE/FALSE>
Description
This pr is to add a parameter (--public-network-access) to the az cosmos db restore cli command. This change requires NO sdk/api changes as this parameter is already existing and used by (create cosmos db cli command). The change is very minor and I have updated one of our tests to take in the parameter & captured its recording.
Testing Guide
self.cmd('az cosmosdb restore -n {restored_acc} -g {rg} -a {acc} --restore-timestamp {rts} --location {loc} --assign-identity {user_id_2} --default-identity {default_id2} --public-network-access "DISABLED"')
This will restore the cosmos db account with Public Network Access as disabled.
History Notes
[cosmosdb] az cosmosdb restore Add new parameter to restore command: public-network-access

This checklist is used to make sure that common guidelines for a pull request are followed.

[x] The PR title and description has followed the guideline in Submitting Pull Requests.

[ ] I adhere to the Command Guidelines.

[ ] I adhere to the Error Handling Guidelines.

cosmosdb


BUG: 3 layers of depth seems to not work

Given the following yaml code:
# es.yaml
es:
  serps:
      not_found:
        title: No se han encontrado resultados con los filtros seleccionados.
        subtitle: Por favor, cambie los términos de búsqueda.

This doesn't seem to work
	fmt.Printf("%+v", ctxi18n.Get(ES).T("serps.not_found.title"))

I might be running an older versión let me try to update

Also, its kind of annoying to debug since you have the map as private which means I cannot actually print it to inspect what is happening :(

Hi @Oudwins! Did you manage to solve this? It might be that the YAML was invalid. Looking at the example I see spaces instead of tabs, which might have caused the title and subtitle fields to be aligned with serps: instead of nested inside not_found:. Not specific limit is imposed inside ctxi18n for nesting.

Aaa, i think you might be right. Not sure why i have issues adding tabs to my files on my editor I didn't think of that. I'll close this


Remove Redundant ValidateTransaction During Txn Submission

#1278  👈
feature/proof-of-stake

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @tholonious and the rest of your teammates on  Graphite


Remove stale gRPC warning from Bigtable docs.

Closes #1858.

The BEST way to close #1858! LGtM

Merging after cancelling Travis for the PR (tox -e docs is happy with the docs-only change.)


wave app don´t run in linux

Wave SDK Version, OS
wave-0.10.0-linux-amd64.tar.gz
CentOS Linux release 7.8.2003 (Core)
Actual behavior
Wave application still launches with 'localhost' and does not launch with server IP.
Expected behavior
It was expected that at least the application would show up with the server's IP
Steps To Reproduce

Run ./waved
terminal return:

2021/01/12 13:27:13 #
2021/01/12 13:27:13 # ┌─────────────────────────┐
2021/01/12 13:27:13 # │  ┌    ┌ ┌──┐ ┌  ┌ ┌──┐  │ H2O Wave
2021/01/12 13:27:13 # │  │ ┌──┘ │──│ │  │ └┐    │ 0.10.0<PHONE_NUMBER>1901
2021/01/12 13:27:13 # │  └─┘    ┘  ┘ └──┘  └─┘  │ © 2020 H2O.ai, Inc.
2021/01/12 13:27:13 # └─────────────────────────┘
2021/01/12 13:27:13 #
2021/01/12 13:27:13 # {"address":":10101","t":"listen","webroot":"/home/desarrollo/wave/www"}

Run $ wave run hello_world.py
The wave terminal return: 2021/01/12 13:27:49 # {"host":"http://<IP_ADDRESS>:8000","route":"/hello","t":"app_add"}
The server terminal return:

INFO:     Uvicorn running on http://<IP_ADDRESS>:8000 (Press CTRL+C to quit)
INFO:     Started reloader process [13610] using statreload
INFO:     Started server process [13612]
INFO:     Waiting for application startup.
INFO:     Application startup complete.

No more INFO was shown. expected at least: INFO:     <IP_ADDRESS>:53722 - "POST / HTTP/1.1" 200 OK
NOTE: the wave terminal still run the app in: http://<IP_ADDRESS>:8000 not in server´s IP.
The script is come from wave/docs/tutorial-hello

@sergiomora03 - you can set the ip:port to listen to using the -listen argument to waved, e.g. waved -listen <IP_ADDRESS>:80. See https://h2oai.github.io/wave/docs/configuration

@sergiomora03 - you can set the ip:port to listen to using the -listen argument to waved, e.g. waved -listen <IP_ADDRESS>:80. See https://h2oai.github.io/wave/docs/configuration

Thanks @lo5 I just add: H2O_WAVE_ADDRESS=http://<IP_ADDRESS>:80 wave run app. When run the wave app.

Thanks @lo5 I just add: H2O_WAVE_ADDRESS=http://<IP_ADDRESS>:80 wave run app. When run the wave app.


unit test is fail

@aloxide/bridge:  FAIL  test/ICONContractAdapter.test.ts (41.77 s)
@aloxide/bridge:   ● test ICON contract addapter › test generatePackage › should generatePackage successful
@aloxide/bridge:     expect(jest.fn()).toBeCalledTimes(expected)
@aloxide/bridge:     Expected number of calls: 1
@aloxide/bridge:     Received number of calls: 2
@aloxide/bridge:
@aloxide/bridge:       137 |
@aloxide/bridge:       138 |       adapter.generatePackage();
@aloxide/bridge:     > 139 |       expect(spyReadFileSync).toBeCalledTimes(1);
@aloxide/bridge:           |                               ^
@aloxide/bridge:       140 |       expect(spyReadFileSync).toBeCalledWith(
@aloxide/bridge:       141 |         path.resolve(templatePath, adapter.folderName, `${fileName}.hbs`),
@aloxide/bridge:       142 |         'utf-8',
@aloxide/bridge:
@aloxide/bridge:       at Object.<anonymous> (test/ICONContractAdapter.test.ts:139:31)
@aloxide/bridge:   ● test ICON contract addapter › test generateMainPy › should generateMainPy successful
@aloxide/bridge:     expect(jest.fn()).toBeCalledTimes(expected)
@aloxide/bridge:     Expected number of calls: 1
@aloxide/bridge:     Received number of calls: 4
@aloxide/bridge:
@aloxide/bridge:       167 |
@aloxide/bridge:       168 |       adapter.generateMainPy();
@aloxide/bridge:     > 169 |       expect(spyReadFileSync).toBeCalledTimes(1);
@aloxide/bridge:           |                               ^
@aloxide/bridge:       170 |       expect(spyReadFileSync).toBeCalledWith(
@aloxide/bridge:       171 |         path.resolve(templatePath, adapter.folderName, `${fileName}.hbs`),
@aloxide/bridge:       172 |         'utf-8',
@aloxide/bridge:
@aloxide/bridge:       at Object.<anonymous> (test/ICONContractAdapter.test.ts:169:31)
@aloxide/bridge:   ● test ICON contract addapter › test generateCallAPI › should generateCallAPI successful
@aloxide/bridge:     expect(jest.fn()).toBeCalledTimes(expected)
@aloxide/bridge:     Expected number of calls: 1
@aloxide/bridge:     Received number of calls: 5
@aloxide/bridge:
@aloxide/bridge:       222 |
@aloxide/bridge:       223 |       adapter.generateCallAPI();
@aloxide/bridge:     > 224 |       expect(spyReadFileSync).toBeCalledTimes(1);
@aloxide/bridge:           |                               ^
@aloxide/bridge:       225 |       expect(spyReadFileSync).toBeCalledWith(
@aloxide/bridge:       226 |         path.resolve(templatePath, adapter.folderName, `${fileName}.hbs`),
@aloxide/bridge:       227 |         'utf-8',
@aloxide/bridge:
@aloxide/bridge:       at Object.<anonymous> (test/ICONContractAdapter.test.ts:224:31)
@aloxide/bridge:   ● test ICON contract addapter › test generateTXAPI › should generateTXAPI successful
@aloxide/bridge:     expect(jest.fn()).toBeCalledTimes(expected)
@aloxide/bridge:     Expected number of calls: 1
@aloxide/bridge:     Received number of calls: 6
@aloxide/bridge:
@aloxide/bridge:       304 |
@aloxide/bridge:       305 |       adapter.generateTXAPI();
@aloxide/bridge:     > 306 |       expect(spyReadFileSync).toBeCalledTimes(1);
@aloxide/bridge:           |                               ^
@aloxide/bridge:       307 |       expect(spyReadFileSync).toBeCalledWith(
@aloxide/bridge:       308 |         path.resolve(templatePath, adapter.folderName, `${fileName}.hbs`),
@aloxide/bridge:       309 |         'utf-8',
@aloxide/bridge:
@aloxide/bridge:       at Object.<anonymous> (test/ICONContractAdapter.test.ts:306:31)
@aloxide/bridge:  PASS  test/ModelAdapter.test.ts (25.603 s)
@aloxide/bridge:   ● Console
@aloxide/bridge:     console.info
@aloxide/bridge:       ---- success generating file: bbModelBuilder.js
@aloxide/bridge:
@aloxide/bridge:       at FilePrinter.print (src/printer/FilePrinter.ts:33:17)
@aloxide/bridge: Test Suites: 1 failed, 6 passed, 7 total
@aloxide/bridge: Tests:       4 failed, 2 todo, 17 passed, 23 total
@aloxide/bridge: Snapshots:   0 total
@aloxide/bridge: Time:        57.433 s
@aloxide/bridge: Ran all test suites.
@aloxide/bridge: error Command failed with exit code 1.

@sanglt1902 Could you help check this?

@sanglt1902 Could you help check this?

Okay let me check

Fixed


Supporting 'unofficial' repositories

We've had a little chat already about supporting a wider range of plugin sources than just this repo. Indeed I believe @nmn is working on a npm-based suggestion.
Now IanL @phyward has a first very industry-specific example for us to think about:  https://github.com/phywand/pmlNotePlan.
So creating this issue to be a place to discuss our options further.

@jgclark I think we should close this issue as duplicate and put all the discussion under one roof on the NPM thread (maybe rename that title to be the same as this one -- less about the how and more about the goal)
https://github.com/NotePlan/plugins/issues/6#issuecomment-877652946

OK, doing as @dwertheimer suggests, and closing in favour of #6.


Allow extra headers in HTTPError

Is your feature request related to a problem? Please describe.
We may want to send extra headers along with the response when an HTTP error occurs — particularly when dealing with authentication. We cannot do so currently without writing a custom error handler that would define the format of the response (plain text, JSON, …).
Describe the solution you'd like
Add a headers parameter to HTTPError, which users/clients can use to define extra headers to be sent with the response.
Describe alternatives you've considered

Refactor HTTPError to be a subclass of Starlette's HTTPException (see #274), and push this feature to the upstream Starlette project => incompatible with the philosophy of Starlette as an ASGI toolkit - see https://github.com/encode/starlette/pull/507.

Implementation ideas
We'll need to update the base error handlers (error_to_text, errorto_json`, etc) to send the extra headers with the response.
Additional context
/

is this feature still open?

Hi @teaglebuilt,
Despite #334, yes it is. I would gladly review a PR to implement this piece of functionality. :)


Add end and start symbols to regex for current check

Resolves Issue #213

Awesome, thanks for this fix.
Travis builds are failing as expected (fix is in #215) but Mocha tests are passing locally.

@jakebathman do you know when this will be merged?

Hey all.  Any help the community can offer to get these PRs ready for merge (making sure tests are passing and that we are rebased off the latest master) would be a huge help.

I don't have push permission for this PR so I duplicated it as #235


Provide environment variable configuration option

Motivation
We are currently providing a config option to provide a path to the protoc binary. This works great if your protoc is always the same; however, for a lot of packages you want to build them on various systems and the path to protoc is always different. We really can't solve this with any config file.
Modification
This PR adds the option to set the PROTOC_PATH env variable and picks it up in the plugin to find the protoc binary.
Result
We can now dynamically pass the protoc path to the plugin.

@thomasvl @tbkka  Would love to get your opinion on this one. While the config option that I provided in the JSON file is good to have and solves most problems. Sometimes, that didn't really work if you needed your package to be developed cross platform. Furthermore, non-leaf packages couldn't use it at all.
I have been trying a few different things for the last days and was almost going to give up but then I came across an idea of passing an env variable to the plugin. The great thing is this works across command line and Xcode if you start Xcode in the right way.
The real fix is still in SPM however I think it is worth adding this env variable escape hatch.

I'm fine with it.

Looking at the rendered docs, two of the subsections (###) are getting detected.  Can you try an extra blank line before them so we can fix those in the same PR?  You can preview it before we merge it at https://github.com/FranzBusch/swift-protobuf/blob/fb-env-variable-for-protoc/Sources/protoc-gen-swift/Docs.docc/spm-plugin.md.

I guess we need to pull this to main also.

#1283 is a cherry-pick of it over to main.


Fix minor typos in Advanced Pattern Matching reading material

Minor typos fix and adding Yusef's doc tests(#813)  to Converter.to_named_strings/1.

Great fixes!


 CAS entries should have a reference count and only be collected if they are no longer referenced by any cache entry.

Also, is it possible to let Bazel back off when it GET an AC entry returns 200 but the corresponding CAS is not found in the server?

This is implemented in my gRPC WiP in #97, and I filed #106 for a backwards-compatible solution for http.
@bayareabear ^


Unable to refresh partitions in tables with Refresh Policy set

I can refresh a model (calc, full, defrag, etc) and I can refresh a table (calc, full, data, etc), but when I right-click on a partition to refresh, it always fails.
I can refresh the partition in Tabular Editor 3, so it isn't a permission issue. Is this not supported, or is there something else I need to configure in the extension?

is the table configured for incremental refresh?
seems like there is an issue with the current implementation where it is not working with incremental refresh
a fix is on the way :)
in the meanwhile you could also use a Power BI Notebook to trigger the refresh - just make sure that you use "applyRefreshPolicy": false (that part is missing if you run a refresh via the UI)
POST https://api.powerbi.com/v1.0/myorg/groups/aaa070df-9744-4629-96bc-df96da4ff27d/datasets/efecf751-ab1b-48fe-acc6-8fbd9fff1bcb/refreshes
{
	"type":"full",
	"objects":[
		{
			"table":"FactInternetSales",
			"partition":"2021"
		}
	],
	"applyRefreshPolicy": false
}

I get the same issue.
Looks to me like the request needs to be adapted to explicitly prevent the refresh policy from being applied when refreshing partitions. By default, it's applied if it's omitted from the request (https://learn.microsoft.com/en-us/power-bi/connect-data/asynchronous-refresh#parameters). A subtle difference between the API and TMSL (in TE3).
You can adapt and run this code in a notebook. The commitMode is optional. I use it due to table size when refreshing. (BTW, it's also super simple to get the API path by right clicking the dataset 😁)
POST v1.0/myorg/groups/{groupId}/datasets/{datasetId}/refreshes
{
  "type": "full",
  "commitMode": "partialBatch",
  "applyRefreshPolicy": "false",
  "objects": [
    {
      "table": "SomeTable",
      "partition": "SomePartition1"
    },
    {
      "table": "SomeTable",
      "partition": "SomePartition2"
    }
  ]
}

@gbrueckl You may also want to consider allowing the user to input the effectiveDate. If ommitted it defaults to UTC, which for me being UTC+12/13 in NZ can cause issues when incrementing by day. I use the format "yyyy-MM-ddTHH:mm:ss.fffffff".
For completeness, the error message returned from the API
{
	"startTime": "2024-04-04T08:31:28.323",
	"endTime": "2024-04-04T08:31:28.99",
	"type": "Full",
	"commitMode": "Transactional",
	"status": "Failed",
	"extendedStatus": "Failed",
	"currentRefreshType": "Full",
	"numberOfAttempts": 0,
	"objects": [
		{
			"table": "Transactional",
			"partition": "2022",
			"status": "Failed"
		}
	],
	"messages": [
		{
			"message": "Cannot specify partition for table 'Transactional' having refresh policy defined.",
			"type": "Error"
		}
	]
}

just published v1.8.1 that fixes this issue - should be available in the marketplace soon
@samaguire  can you open another ticket for the input of effective date please

just published v1.8.1 that fixes this issue - should be available in the marketplace soon @samaguire can you open another ticket for the input of effective date please

Yip that works for me!

Yes, that seems to work. Thanks!

great, closing this issue then!


Create a Calculation View with Differential Privacy

Tutorial URL: https://developers.sap.com/tutorials/haas-dm-calculation-view-differential-privacy.html
Please specify the step you are referring to:
Step 5: Configure the HANA Analytics Adapter
Hi Lucia: FYI a link in step 5 is not rendering correctly in output.

pushed change, thanks!


Could not run imshow-jetson

Hello, I meet some problems in running imshow-jetson example.
When I run this example, it shows an error: No cameras found!
workspace/ToF-3.2.0/build/examples/imshow-jetson$ ./imshow-jetson
I1019 16:40:40.777025 64770 system_impl.cpp:86] SDK built with websockets version:3.1.0
I1019 16:40:40.777745 64770 usb_sensor_enumerator.cpp:56] Looking for USB connected sensors
W1019 16:40:40.778177 64770 main.cpp:95] No cameras found!

How can I use USB mode?

Hello,
This example needs to updated, we will let you know as soon as we finish.


[Feature suggestion] Expand options for definition

Loving the package, thank you so much @jellydn and team.
It would be nice to add more fields from the basic structure
https://swagger.io/docs/specification/basic-structure/
Info and servers more specifically.
I see https://github.com/Surnet/swagger-jsdoc has an option to define these in a JSON or Yaml file?

Thanks. I will look into this one later.

Ok, let me know if you need help :-)

Hi all. I will publish new version for this issue soon.

Closed by https://github.com/jellydn/next-swagger-doc/releases/tag/v0.2.0 Please let me know if any issue. Thanks.


create netlify build

Description
Create a netlify build for the smp-spec.io site, similar to the one present for the layer5.io site on the layer5 repository.

@Tanuj22 Would you like to take this one up?

@chandrashritii Sure

@Tanuj22 situation report please. 😃

@leecalcote Netlify needs access to the repo. I have requested access from netlify could you check?

Done!


Sync eng/common directory with azure-sdk-tools for PR 974

Sync eng/common directory with azure-sdk-tools for PR https://github.com/Azure/azure-sdk-tools/pull/974 See eng/common workflow

@chidozieononiwu  looks like this PR failed to merge because of a conflict.

@chidozieononiwu looks like this PR failed to merge because of a conflict.

Thanks. It contains extra changes and I was looking to make sure it wasn't undoing stuff.


Remove istioctl authn tls-check

Remove istioctl authn tls-check command as it's no longer work with mTLS beta API, as well as not necessary with auto-mTLS features.

@diemtvu: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

lint_istio
b874529cda66a475001b34600c47402f86877f35
link
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

As this command doesn't work it would be a good idea to get rid of it.
However, don't we have a policy that requires us to deprecate it for a version before removing it?  I realize it is a pain to fix and deprecate, only to remove.

Maybe we put a warning to say the tool only works with alpha API, and
advice users to switch to beta API with auto-mTLS on?
On Wed, Feb 12, 2020 at 12:14 PM Ed Snible<EMAIL_ADDRESS>wrote:

As this command doesn't work it would be a good idea to get rid of it.
However, don't we have a policy that requires us to deprecate it for a
version before removing it? I realize it is a pain to fix and deprecate,
only to remove.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/istio/istio/pull/21070?email_source=notifications&email_token=AF7X24NJUEN3YAFDYJ4YF3TRCRKEHA5CNFSM4KUCU3Q2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOELSHFSI#issuecomment-585396937,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AF7X24NHDZIQ62J2CI7HI5LRCRKEHANCNFSM4KUCU3QQ
.

--
Diem Vu | Software Engineer |<EMAIL_ADDRESS>| +1<PHONE_NUMBER>

If you make a PR that deprecates this command by adding  (deprecated) to the Short:, a deprecation warning to the Long:, and a message explaining not to trust it with 1.5 control plane I will give an approving review.
If we want to remove it in this version with no deprecation period we need to ask permission.

If you make a PR that deprecates this command by adding  (deprecated) to the Short:, a deprecation warning to the Long:, and a message explaining not to trust it with 1.5 control plane I will give an approving review.
If we want to remove it in this version with no deprecation period we need to ask permission.

Done

Please use cmd.Deprecated to deprecate commands. This will hide the command from usage text and print the specified warning automatically.

@diemtvu: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-istioio-k8s-tests_istio
016e520ce643be7e0fe51bdb3fad5fabff6306ee
link
/test integ-istioio-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Please use cmd.Deprecated to deprecate commands. This will hide the command from usage text and print the specified warning automatically.

Ah. Thanks.

@diemtvu: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-istioio-k8s-tests_istio
016e520ce643be7e0fe51bdb3fad5fabff6306ee
link
/test integ-istioio-k8s-tests_istio

unit-tests_istio
e5ab6eaea6d5488fe4c2cea0c67e39a3b638c550
link
/test unit-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@diemtvu: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-istioio-k8s-tests_istio
31b059a85f2ea8d44a99aa86be07465e8edc6c11
link
/test integ-istioio-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test integ-istioio-k8s-tests_istio

Ping

@diemtvu with this change, how do we plan to handle the references to this command in docs? e.g. https://preliminary.istio.io/docs/tasks/security/authentication/mutual-tls/#verify-mutual-tls-configuration, https://preliminary.istio.io/docs/ops/common-problems/network-issues/#503-errors-after-setting-destination-rule

We are in the middle of rewriting all security tasks. These instructions
will be removed/replaced appropriately. Thanks.
On Wed, Feb 19, 2020 at 10:54 AM Jason Wang<EMAIL_ADDRESS>wrote:

@diemtvu https://github.com/diemtvu with this change, how do we plan to
handle the references to this command in docs? e.g.
https://preliminary.istio.io/docs/tasks/security/authentication/mutual-tls/#verify-mutual-tls-configuration,
https://preliminary.istio.io/docs/ops/common-problems/network-issues/#503-errors-after-setting-destination-rule
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/istio/istio/pull/21070?email_source=notifications&email_token=AF7X24OA7WPZ75KF2BOYKULRDV55HA5CNFSM4KUCU3Q2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEMJA6ZA#issuecomment-588386148,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AF7X24IIOEUKH72KN5WMCSDRDV55HANCNFSM4KUCU3QQ
.

--
Diem Vu | Software Engineer |<EMAIL_ADDRESS>| +1<PHONE_NUMBER>


[Dockerfile.tests] install service deps

sorry, this should have been in d95105cd57

Unit tests passed


(Fix) Display proper values for ERC20 tokens

This PR fixes #678, by checking for decimals method in transferredTokens.
Previously we were looking for decimals hash in the contract code.
There are some contracts like USDC tokens who happen to be behind a FiatTokenProxy making it upgradable, but also giving false positives for the decimals hash lookup in the code.
By directly calling the decimals() method, we interact with the contract and can be sure that the decimals() method is present.

Travis automatic deployment:
https://pr748--safereact.review.gnosisdev.com/app

we should cache/save somehow this information locally

totally agree


Tweak type tooltip is not localized

Start the local server with script/server
Navigate to http://localhost:4000
Hover over one of the tweak icons in the tweak list

Expected: Tweak type tooltip to be localized
Actual: Tweak type tooltip is not localized

It appears that the source of the bug is:
https://github.com/lee-dohm/atom-style-tweaks/blob/f59d2163f939395039ffad4b8d35ddd41d990c65/lib/atom_tweaks_web/templates/tweak/table_row.html.slime#L2

As stated in the README, this project is no longer maintained and has been retired. Because of this, I am archiving this repository and closing all issues and pull requests. Thanks very much for your support and contributions!


Deep copying View should use allocator id of parent

There are 2 ways to deep copy data into a sidre::View, and they should allocate array data the same way.
Deep-copying from a source View currently allocates data using the destination's parent's default allocator id.  However, deep-copying from a source conduit::Node, using View::importArrayNode(), currently allocates data on the host, ignoring the parent's default allocator id.  We should change the second version to behave like the first.
This proposal constitutes a behavior change, which should be documented.  While it is possible to copy data to the desired memory space after the deep copy, to do so for a large hierarchy is messy and wasteful.

Resolved with MR https://github.com/LLNL/axom/pull/1460.


Updating the plugin to work with IntelliJ Idea 2022.1

@Hazem-Ben-Khalfallah would you mind reviewing it?

hi @yanislavm, I've got the following build error after running the build pipeline:
Caused by: java.lang.ClassNotFoundException: com.intellij.openapi.util.SystemInfoRt
I'm going to revert the latest merge in the mean time.
can you re-check plz :pray: ?


float error

when I run :
sh ../script/launch_SketchModule.sh
Traceback (most recent call last):
File "/home/lbl/work/ShapeMatchingGAN/src/trainSketchModule.py", line 46, in
main()
File "/home/lbl/work/ShapeMatchingGAN/src/trainSketchModule.py", line 28, in main
opts.text_datasize, trainnum=opts.Btraining_num)
File "/home/lbl/work/ShapeMatchingGAN/src/utils.py", line 82, in load_train_batchfnames
fnames = [('%04d.png' % (i%usenum)) for i in range(trainnum)]
TypeError: 'float' object cannot be interpreted as an integer

and same problems in trainSketchModule.py

The float bugs have been fixed.
It seems that your default data type is float?
In my case, the result of integer / integer is sill an integer.
e.g. (self.kernel_size - 1)/2  and  trainnum/batchsize*batchsize
So there is no type error reported in the orginal code on my computer.

看来是我的问题。 不过都是python3 ，为什么我的整数相除会变成浮点？

It seems that I find the reason.
My code is implenmented under python2, where integer / integer yields integer.
And in python3, integer / integer produces float.

so haven't you thought about making a python3 version?


Import fails using Python 3.8.5

Describe the bug
A clear and concise description of what the bug is.
To Reproduce
Steps to reproduce the behavior:

Install Miniconda on Windows 10 as of 2020-08-28.
Run: conda create --name fresh \
--override-channels --channel conda-forge \
 --force --yes python=3.8
 pip install tox poetry grayskull

Run conda activate fresh && grayskull --version

Outputs
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "C:\ProgramData\Miniconda3\lib\site-packages\grayskull\base\factory.py", line 4, in <module>
    from grayskull.pypi import PyPi
  File "C:\ProgramData\Miniconda3\lib\site-packages\grayskull\pypi\__init__.py", line 1, in <module>
    from grayskull.pypi.pypi import PyPi  # noqa
  File "C:\ProgramData\Miniconda3\lib\site-packages\grayskull\pypi\pypi.py", line 21, in <module>
    from grayskull.base.base_recipe import AbstractRecipeModel
  File "C:\ProgramData\Miniconda3\lib\site-packages\grayskull\base\base_recipe.py", line 11, in <module>
    from ruamel.yaml import YAML, CommentToken
ImportError: cannot import name 'YAML' from 'ruamel.yaml' (unknown location)

Environment:

conda list:

# Name                    Version                   Build  Channel
ca-certificates           2020.6.20            hecda079_0    conda-forge
certifi                   2020.6.20        py38h32f6830_0    conda-forge
openssl                   1.1.1g               he774522_1    conda-forge
pip                       20.2.2                     py_0    conda-forge
python                    3.8.5           h60c2a47_7_cpython    conda-forge
python_abi                3.8                      1_cp38    conda-forge
setuptools                49.6.0           py38h32f6830_0    conda-forge
sqlite                    3.33.0               he774522_0    conda-forge
vc                        14.1                 h869be7e_1    conda-forge
vs2015_runtime            14.16.27012          h30e32a0_2    conda-forge
wheel                     0.35.1             pyh9f0ad1d_0    conda-forge
wincertstore              0.2                   py38_1003    conda-forge

pip list: a bit redundant
grayskull --version: fails

Also tried:
pip uninstall grayskull
pip install grayskull=0.7.4

Same issue.

This fixed it:
install ruamel.yaml==0.16.10
Collecting ruamel.yaml==0.16.10
  Using cached ruamel.yaml-0.16.10-py2.py3-none-any.whl (111 kB)
Processing c:\users\douglas\appdata\local\pip\cache\wheels\e4\3e\eb\975034325f52bc0d5897b5f8603974d6a79a964aaeb0ec0293\ruamel.yaml.clib-0.2.0-cp38-cp38-win_amd64.whl
Installing collected packages: ruamel.yaml.clib, ruamel.yaml
  Attempting uninstall: ruamel.yaml
    Found existing installation: ruamel-yaml 0.15.87
ERROR: Cannot uninstall 'ruamel-yaml'. It is a distutils installed project and thus we cannot accurately determine which files belong to it which would lead to only a partial uninstall.
(fresh) PS C:\Users\douglas\Desktop\code\tyrannosaurus> pip install ruamel.yaml==0.16.10 --force

Then:
pip install ruamel.yaml==0.16.10 --force --ignore-installed
Collecting ruamel.yaml==0.16.10
  Using cached ruamel.yaml-0.16.10-py2.py3-none-any.whl (111 kB)
Processing c:\users\douglas\appdata\local\pip\cache\wheels\e4\3e\eb\975034325f52bc0d5897b5f8603974d6a79a964aaeb0ec0293\ruamel.yaml.clib-0.2.0-cp38-cp38-win_amd64.whl
Installing collected packages: ruamel.yaml.clib, ruamel.yaml
Successfully installed ruamel.yaml-0.16.10 ruamel.yaml.clib-0.2.0
(fresh) PS C:\Users\douglas\Desktop\code\tyrannosaurus> grayskull --version
0.8.1

However, it may be good to replace "ruamel.yaml >=0.15.3" in setup.py with "ruamel.yaml >=0.16.10".
(Oddly, pip install ruamel.yaml==0.16.0 --force --ignore-installed installs 0.16.10. Maybe there isn't a 0.16.0.)

Thanks for reporting it, I was not aware about this problem
I believe I didn't see that on the CI because it was using the latest version of the ruamel.


Add a 2D scale factor property

This can be used to make 2D elements larger or smaller, independently of the current stretch mode.
Only the disabled and 2d stretch modes support this new property.
Note that I removed the property hint for shrink as it was causing the Project Settings GUI to recognize it as a string instead of a floating-point value (it seems there's no way to add property hints for floats).
Demo project

Moving to 3.2 milestone as we're about to enter the beta stage and release freeze for Godot 3.1. Only bug fixes against issues of the 3.1 milestone (or enhancements to core features of the 3.1 roadmap) will be considered until 3.1-stable is released.
Note: If it's merged after 3.1-stable is released, this change might be considered for cherry-picking into a later 3.1.x release.

I rebased this pull request against the current master branch. Could this be reviewed? This would make it easy to support hiDPI in one of my projects :slightly_smiling_face:

The added option seems interesting, but I'm wary of doing such changes to SceneTree so late in the release cycle, so I'd prefer to postpone for 4.0.
This can and should still be reviewed properly ASAP - and if it's deemed safe to include in 3.2, I don't mind changing the milestone back.

@Calinou Any update? This needs a rebase. Additionally, it would be nice if a proposal was created for this for discussion.

@aaronfranke 2d and viewport stretch modes are currently broken, so this can't be tested using the current master branch.

@Calinou I just checked, in the latest master the viewport and canvas_items (2d?) stretch modes seem to be working. It's likely that this PR can be rebased now, unless there is something else missing in master.

Superseded by https://github.com/godotengine/godot/pull/52170.


Update and rename lib/domains/au/gov to lib/domains/au/gov/nsw/education

Department of Education and Communities New South Wales

the license is meant for educational entities, providing long-term (>1year) it-related courses (whereas the domain belongs to the department of education). In case i've missed something, please let me know.

This domain is used for all public High Schools in NSW, which provide a 2 year Software Design and Development course.
http://www.boardofstudies.nsw.edu.au/syllabus_hsc/software-design-development.html

thanks for the further explanation. Could you please also fix the extension to .txt and let me know if anyone but students / teachers can get emails in the mentioned domain?


What: Update the WG README

Why:

Current README is out of date and missing key information

This change address the need by:

Merging previous documentation into the README
adding Objective of the WG
defining Scope considerations
adding Current Work
listing previously known related groups

This PR resolves Issue #4

One week passed with no additional comments, so this is ready to merge.
Thank you very much for the PR!


Unable to search staking data by username

Waiting on a new prod deploy to check this

This is not equivalence since ME only supports searching/filtering by Public Key.

@n1tranquilla @jhult how do we want to handle changes to usernames? If a user has had multiple usernames, should their data be searchable by all of them or only the latest? Should we be able to search their "old" data by their "old" username and "new" data by their "new" username?


fix: restore portable backup error

This PR is to solve restore problem in influxdb 1.x
influxd restore -portable -host [host] -db [db] -newdb [newdb] [backup_path]
Restoring portable backup with this command may get error as below
2020/11/20 13:55:02 error updating meta: updating metadata on influxd service failed: err=read tcp x.x.x.x:52286->x.x.x.x:8088: read: connection reset by peer, n=16
restore: updating metadata on fctsdb service failed: err=read tcp x.x.x.x:52286->x.x.x.x:8088: read: connection reset by peer, n=16

Accordingly, the influxdb error log is as below
ts=2020-11-20T13:55:02.555262Z lvl=info msg="failed to decode meta: proto: meta.ShardInfo: illegal tag 0 (wire type 0)" log_id=0QQzP3qG000 service=snapshot

This problem happens at random, but more frequently in network with high latency. The net.func (*TCPConn) Read dose not promise that exactly len(buf) bytes is read when the call is returned, which leading this problem. Replacing the net.func (*TCPConn) Read with io.ReadFull could fix this.

[x] CHANGELOG.md updated with a link to the PR (not the Issue)
[x] Well-formatted commit messages
[x] Rebased/mergeable
[x] Tests pass
[ ] http/swagger.yml updated (if modified Go structs or API)
[ ] Feature flagged (if modified API)
[ ] Documentation updated or issue created (provide link to issue/pr)
[x] Signed CLA (if not already signed)

Hi @rickif thanks for the contribution! While we review, could you push an update to the CHANGELOG.md file with a reference to this PR?

@danxmoran OK, the CHANGELOG.md is updated now.

@danxmoran  I agree with u and have added some test codes .But I have doubt about the cases you mentioned.

Is it necessary to cover the first case? According to the godoc, If an EOF happens after reading some but not all the bytes, ReadFull returns ErrUnexpectedEOF. The result is clear and well-defined by golang.
On Linux platform,  the call to read() may read less than the requested number of bytes, which may occur if there are fewer bytes available in the socket than were requested in the read() call. The possible cause of this is happened in the Linux Kernel Mode, which is not easy to add test to simulate this circumstance. I tried to do this by dividing the payload and sending the pieces one by one, meanwhile Sleep() is added after every sending. But it does not work at all. I wonder whether you have any good idea about this?

Is it necessary to cover the first case? According to the godoc, If an EOF happens after reading some but not all the bytes, ReadFull returns ErrUnexpectedEOF. The result is clear and well-defined by golang.

A test case covering only a call to ReadFull would indeed be redundant. The pieces I'm interested in covering are the functions wrapping the ReadFull calls. My impression is that before this change, those functions would either complete successfully (but return partial/corrupted data) or fail with a confusing error. The functions still fail with this change, but with (hopefully) a more clear explanation in the error. If it's easy to capture the new expectation in a test, it'd help guard against future regressions.
That said, I don't want to gatekeep your contribution for too long. If setting up test cases is going to take a significant amount of mocking & other test machinery, I'm ok merging without additional tests. In that case, could you add a comment above each of the ReadFull calls explaining why ReadFull over Read?

But it does not work at all. I wonder whether you have any good idea about this?

It sounds like this will be more trouble than it's worth, I wouldn't spend more time on it. Thanks for investigating!

The functions still fail with this change, but with (hopefully) a more clear explanation in the error

This change is not aiming at providing a more clear explanation, but is mainly to solve the problem that the conn.Read() may return too early without enough data, which leds a data corruption error even if the data is valid. As you mentioned before, the io.ReadFull would block until expected data is read, in which the data could be parsed correctly.

Thanks @rickif, one suggestion to curate the CHANGELOG, and some questions in the new test code.

Thanks for suggestions. The PR has been updated!

@danxmoran Hi, the PR has been pending for a long time. Is there any problem?

@dgnorton Hi, would you please do review for this PR?

@rickif very sorry for the delay, I'm not sure how I lost track of this one. I'll do a final review pass now.

@rickif very sorry for the delay, I'm not sure how I lost track of this one. I'll do a final review pass now.

that would very nice.

Re-opened this PR as https://github.com/influxdata/influxdb/pull/21991 so that I can update the changelog, otherwise it is good.


fix(@angular-devkit/build-angular): handle windows spec collisions

The previous logic didn't quite work when interacting with windows path. This PR does three things:

Move the logic to generate unique spec entrypoint names into its own function. This prepares for reusing it elsewhere (e.g. in WTR).
Add a more direct unit test for that logic.
Fix the logic so it works with Windows paths as well as unix paths.

As a drive-by fix, this also cleans up the deduped filenames so we get "foo-2.spec.js" instead of "foo.spec-2.js". The latter looked a bit confusing and it was just a tiiiiny regex to fix those names up. The index append shouldn't really come up in real code very often, so this is very much a tiny niche case.
Fixes https://github.com/angular/angular-cli/issues/28915

The changes were merged into the following branches: main, 19.0.x


Unable to generate json files using GetPluginRegistrationJsonMapping.ps1

I am trying to generate json file for my existing assembly. I am unable to generate it. Can you please help me on this?

What is the issue that you are getting?

Hey, I was trying to generate the json file, but I cannot find the ps1 for doing it... I only found the .cs class which might be the solution, is that it?

@TNoronha The best thing is to look at the sample project here. It contains scripts to generate json file and update from json. https://github.com/WaelHamze/xrm-ci-framework/tree/master/Sample/Xrm.CI.Framework.Sample/Xrm.CI.Framework.Sample.Plugins
Make sure you update to the latest version of xRMCIFramework from Nuget

Oh gotcha, thanks!
Just one final question, if I want to run this as a step in a build definition, how would I get the powershell command from the nuget?

Good question. If you notice in the sample I shared there is a tools project which has a nuget reference to the framework. So if you do a nuget restore on the solution in the build it will download the framework too.
There is a also a VSTS task called Plugin Registration. You can use that but you may have to wait until early next week when I release an update version compatible with your json.


Pull request for Relics docs?

I found a typo in the rspec-mocks Relish docs. How can I do a pull request?

Relish documentation is driven from the cucumber scenarios.

Got it. Thanks.
https://github.com/rspec/rspec-mocks/pull/1032


fix diopiEqual for ascend+kunpeng

Motivation and Context

DiopiEqual is used by calling torch.equal from torch_dipu. On ascend+kunpeng platform, when it's called second time, there would be a runtime error 'ACL stream synchronize failed'.
Description

Fix the implementation of diopiEqual on ascend by adding .cpu() after outAt first and then using .item<bool>().
Use cases (Optional)

BC-breaking (Optional)

Checklist
Before PR:

[x] I have read and followed the workflow indicated in the Contributors.md to create this PR.
[ ] Pre-commit or linting tools indicated in Contributors.md are used to fix the potential lint issues.
[ ] Bug fixes are covered by unit tests, the case that causes the bug should be added in the unit tests.
[ ] New functionalities are covered by complete unit tests. If not, please add more unit test to ensure the correctness.
[ ] The documentation has been modified accordingly, including docstring or example tutorials.

After PR:

[ ] CLA has been signed and all committers have signed the CLA in this PR.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Support preferred locales

Preferred Locales
OPs MUST support requests for preferred languages and scripts for the user interface and for Claims via the ui_locales and claims_locales request parameters, as defined in Section 3.1.2. (Note that the minimum level of support required for these parameters is simply to have their use not result in errors.)
http://openid.net/specs/openid-connect-core-1_0.html#ServerMTI

These may greatly assist with this hellish task.
https://github.com/mattcg/language-tags
https://github.com/mattcg/language-subtag-registry

https://github.com/anvilresearch/connect/issues/340


Link to official RPi Pico forum?

Hello,
Would you mind adding a link to https://forums.raspberrypi.com/viewforum.php?f=143 which is a valuable place to discuss about RPi Pico, too?
I can make a PR if necessary.

That's a solid idea, would need to do it on Pico and Pico W pages too- will look when I have a mo!

I think I've sorted this across all the sites, and tied them together nicely!


Prevents stripping the first char when the Path is "/"

This update prevents stripping the first character from parameters when the path is /.
A path of / is a special case where the SSM Param Store returns all parameters, even if they don't actually start with /. Previouly the code expected all results to begin with the path specified and removed that path before processing, but in the case of / not all results will start with /
This is related to #40
Testing
All existing tests passed and added new test for path = /
Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist

[x] My code follows the code style of this project
[ ] My change requires a change to the documentation
[ ] I have updated the documentation accordingly
[x] I have read the README document
[x] I have added tests to cover my changes
[x] All new and existing tests passed

License

[x] I confirm that this pull request can be released under the Apache 2 license

Thanks for the PR. I pushed out version 1.2.0 with this PR.


how to use the gem?

Hi
any chance you can help me to use your gem?
I want to use just simple .rb script to download a report.
I installed the gem successfully by gem install gem salesforce_http_client
But now I am not sure how to use it. Below code doesn't seem to work for me.
It gives me this error
ruby getreport.rb
C:/Ruby193/lib/ruby/gems/1.9.1/gems/salesforce_http_client-0.1.3/lib/salesforce_
http_client/salesforce_http_access.rb:13:in create_http_client': uninitialized constant SalesforceHttpClient::SalesforceHttpAccess::HTTPClient (NameError)         from C:/Ruby193/lib/ruby/gems/1.9.1/gems/salesforce_http_client-0.1.3/li b/salesforce_http_client/salesforce_http_access.rb:6:in download_from_salesforc
e'
from C:/Ruby193/lib/ruby/gems/1.9.1/gems/salesforce_http_client-0.1.3/li
b/salesforce_http_client/client.rb:17:in download_report'         from getreport.rb:16:in '
========================================
require  'salesforce_http_client'
SalesforceHttpClient.configure do |config|
config.salesforce_login_id = 'my_login_id_or_email'
config.salesforce_password = 'my_password'
end
salesforce_id = '000000000000ABC'
report_save_path = "tmp/#{salesforce_id}.csv"
sf_client = SalesforceHttpClient::Client.new
sf_client.download_report(salesforce_id, report_save_path)

ok the solution was to add these two lines
require 'fileutils'
require 'httpclient'

Added to README.md.
Thank you very much.


iv: Add -rawcolor option to skip auto-convert to RGB

For better inspection of raw values of CMYK or other non-RGB color
spaces that would ordinarily be automatically converted.

LGTM


config: add option to enable/disable xwayland

Describe your PR, what does it fix/add?
Allows enabling and disabling XWayland during runtime. #3371 appears to be stale and not being worked on.
Is there anything you want to mention? (unchecked code, possible bugs, found problems, breaking compatibility, etc.)

Disables "DISPLAY" env variable to prevent X11 launches. Due to this, a pop up will occur notifying of this. Is this to be left alone or is there a better way of informing the user that XWayland is not enabled?
While it closes the windows, applications like Steam are still running in the background with a tray icon. Is it possible to close these or just ignore them?

Is it ready for merging, or does it need work?
Current state of commit works, but see above for things I would like to address first. Closes #7607

if yes it'd be nice to also do xwaylanf restore while we at it (restart if crash)

will this work at runtime? e.g. if someone enables it while running hl

Yeah, the option is meant to work while Hyprland is running and I want to keep it that way

if yes it'd be nice to also do xwaylanf restore while we at it (restart if crash)

calling g_pXWayland->reset(), or resetting is members (pServer, pWM) crashes it when disabling due to lingering apps, probably due to the same issue as 2 above

Unless there is some way to simply test if it crashed that I'm unaware of? That would just be oversight from my part if there's a good way for that

I think if the wm is yeeten off then it crashed or died

Update note: This PR currently only prevents creation of new XWayland windows by unsetting the env variable. I'll continue to dig deeper on actually shutting down XWayland and applications with it off.

Few bugs but currently handles turning off/on multiple times just fine

Current Bugs

Steam stays alive after closing its windows and can only exit if XWayland is re-enabled (not sure if fixable)
Possibly taking another window with it (seems to be if previous window was X11?)

@vaxerski Should be all good now for merge.
Leaving steam issue alone as I don't think its an XWayland problem, just would require keeping track of PIDs and killing them. That might be leaking into territory better made for another PR.
Additional mention as you asked about it that XWayland should fully restore on re-enable. I can't test that for sure though as I don't have a reliable way of crashing it in such a way that it can't restart.

Managed to crash XWayland and can confirm this restores successfully!


Usage of cancelAuctions() unclear

Hi,
If possible, could you explain a little bit how we should call the "cancelAuctions()" function? Can it be called directly after "CommodityBuyerAndSeller.sell" or should it be used in some other way? Also is there a way to always cancel auctions that have been undercut?
Thanks in advance!

Hi, in the current state it can be called manually to cancel auctions with: /run CommodityBuyerAndSeller.cancelAuctions().

Hi Sanjo -
Also curious how this works. When you run the .cancelAuctions() command manually, what is the logic behind what it should cancel? Is it looking for undercut auctions, or some other flag?

Based on the metric for how many auctions seem to be sold per day (from TradeSkillMaster), it cancels everything where it seems that the auction runs out before it seems sold.
With this implementation, even when there are some auctions for a lower price in the auction house, if enough of the commodity is sold per day, the auction is kept in the auction house.
The implementation can be found here: https://github.com/SanjoSolutions/CommodityBuyerAndSeller/blob/3b558e0df1d566821270093f3f29b69f17091915/CommodityBuyerAndSeller/CommodityBuyerAndSeller.lua#L162-L179.

Ah I see, interesting! I can see how that would be useful for certain items.
I was hoping there might be a Cancel function that can cycle through existing auctions and check for undercuts and cancel those auctions. When posting Region-Wide Commodities quickly, it's helpful to be able to cancel auctions immediately after running out of stock. Maybe even define just specific items to cancel on the AH via the API. The same way we define items to post via the CommodityBuyerAndSellerData.lua file.

Thank you for explaining, however I do agree with fatmagic that it would be nice to have a function that does not consider the auctions sold per day before canceling. A function that only checks for undercuts.


Publish decadal fixes to new c3s indices

Publish decadal fixes to c3s-roocs-fix-proposal and c3s-roocs-fix indices.
This involves understanding what has changed with date/text field for value.
Also need to add the fix for removing the coordinate attribute (in dachar and daops) - now that the xarray fix has been released in v0.19

Hi @ellesmith88, I tested the fixes in daops and noted that the reftime has a default calendar (gregorian). I think that reftime.calendar should match time.calendar. Please can you take a look? Thanks

@agstephens I agree with you and this should be straightforward to implement now that we are deriving values in the fixes. However I will have to regenerate all the fixes (which should hopefully be a lot quicker this time!). I think it must be leftover from when I was using the example file to create the fix template.
If I am regenerating the fixes, should I also remove the fill value fix as I mentioned in https://github.com/roocs/daops/pull/88? As it is all done in clisops now.

@ellesmith88 Thanks, I just responded to https://github.com/roocs/daops/pull/88 so you should be ready to proceed with this.

Awaiting new version after early 2022 fixes are updated and published.

Updated fixes are currently being indexed 😄

Fixes have been updated in c3s-roocs-fix to derive reftime and no longer include a fill value fix.

@ellesmith88 are the fixes all in place now? Thanks

@agstephens Yes all fixes are in the index and master of daops and dachar are up to date

Hi @ellesmith88, the fixes are looking good. Great stuff.

Tested with local script:
$ ROOCS_CONFIG=../dachar/MY_roocs.ini python open-decadal-is-fixed.py
2022-01-14 14:34:03,879 - /home/users/astephen/roocs/daops/daops/utils/consolidate.py - INFO - Testing 1 files in time range: ...
2022-01-14 14:34:03,879 - /home/users/astephen/roocs/daops/daops/utils/consolidate.py - INFO - Kept 1 files
2022-01-14 14:34:03,879 - /home/users/astephen/roocs/daops/daops/utils/normalise.py - INFO - Working on datasets: OrderedDict([('c3s-cmip6.DCPP.CMCC.CMCC-CM2-SR5.dcppA-hindcast.s1960-r10i1p1f1.Amon.pr.gn.v20210719', ['/badc/cmip6/data/CMIP6/DCPP/CMCC/CMCC-CM2-SR5/dcppA-hindcast/s1960-r10i1p1f1/Amon/pr/gn/v20210719/pr_Amon_CMCC-CM2-SR5_dcppA-hindcast_s1960-r10i1p1f1_gn_196011-197012.nc'])])
2022-01-14 14:34:03,900 - elasticsearch - INFO - GET https://elasticsearch.ceda.ac.uk:443/c3s-roocs-fix/_doc/8b4a57d954a432024c532e2a6b05e281 [status:200 request:0.019s]
2022-01-14 14:34:03,991 - /home/users/astephen/roocs/daops/daops/utils/core.py - INFO - Running post-processing function: edit_var_attrs
2022-01-14 14:34:03,991 - /home/users/astephen/roocs/daops/daops/utils/core.py - INFO - Running post-processing function: edit_global_attrs
2022-01-14 14:34:03,992 - /home/users/astephen/roocs/daops/daops/utils/core.py - INFO - Running post-processing function: add_scalar_coord
2022-01-14 14:34:03,994 - /home/users/astephen/roocs/daops/daops/utils/core.py - INFO - Running post-processing function: add_coord
2022-01-14 14:34:03,996 - /home/users/astephen/roocs/daops/daops/utils/core.py - INFO - Running post-processing function: add_data_var
2022-01-14 14:34:03,997 - /home/users/astephen/roocs/daops/daops/utils/core.py - INFO - Running post-processing function: remove_coord_attr
2022-01-14 14:34:04,001 - /home/users/astephen/roocs/daops/daops/processor.py - INFO - Running subset [serial]: on Dataset with args: {'area': Area to subset over:
 None, 'level': Level range to subset over
 first_level: None
 last_level: None, 'time': Time period to subset over
 start time: 1960-01-01T00:00:00
 end time: 1961-01-01T23:59:59, 'time_components': No time components specified, 'output_type': 'xarray', 'output_dir': None, 'split_method': 'time:auto', 'file_namer': 'standard'}
/home/users/astephen/roocs/clisops/clisops/ops/subset.py:124: UserWarning: "start_date" not found within input date time range. Defaulting to minimum time step in xarray object.
  result = subset_time(self.ds, **kwargs)
/home/users/astephen/roocs/clisops/clisops/ops/subset.py:124: UserWarning: "end_date" has been nudged to nearest valid time step in xarray object.
  result = subset_time(self.ds, **kwargs)
2022-01-14 14:34:04,014 - /home/users/astephen/roocs/clisops/clisops/ops/base_operation.py - INFO - Processing Subset for times: ('1960-11-16', '1960-12-16')
2022-01-14 14:34:04,014 - /home/users/astephen/roocs/clisops/clisops/utils/output_utils.py - INFO - format_writer=None, output_type=xarray
2022-01-14 14:34:04,014 - /home/users/astephen/roocs/clisops/clisops/utils/output_utils.py - INFO - Returning output as <class 'xarray.core.dataset.Dataset'>
Check leadtime units and data type
Checking global attrs

Script is:
$ cat open-decadal-is-fixed.py
from daops.ops.subset import subset

dsid = "c3s-cmip6.DCPP.CMCC.CMCC-CM2-SR5.dcppA-hindcast.s1960-r10i1p1f1.Amon.pr.gn.v20210719"

rs = subset(collection=dsid, time="1960-01-01/1961-01-01", output_type="xarray")
ds = list(rs._results.values())[0][0]

print("Check leadtime units and data type")
assert ds.leadtime.dtype == "float64"
assert ds.leadtime.units == "days"

print("Checking global attrs")
expected_globals = {
    'forcing_description': 'f1, CMIP6 historical forcings',
    'physics_description': 'physics from the standard model configuration, with no additional tuning or different parametrization',
    'initialization_description': 'hindcast initialized based on observations and using historical forcing',
    'startdate': 's196011',
    'sub_experiment_id': 's196011'
}

for key, value in expected_globals.items():
    assert ds.attrs[key] == value

assert ds.time.values[-1].strftime("%Y-%m-%d") <= "1961-01-01"
assert ds.time.values[0].strftime("%Y-%m-%d") >= "1960-01-01"
assert ds.time.encoding["calendar"] == "365_day"


minor: no more deep read only on types

:tada: This PR is included in version 16.2.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket: