Box component hover style with children

The hover style is showing the white background in patches if there are nested child components.  From a quick look in the dev tools it looks like an issue with the scrollbar (::-webkit-scrollbar-track) having a background and border it might be fixed with removing a scrollbar when it's not needed. Removing these two properties fixes the issue:

Here is our code that reproduces the behavior:
<oh-box       direction={Direction.Vertical}       justifyContent={JustifyContent.Left}       key={single-pat-not-box-${itemNumber}}     >       <oh-box       key="patient-notif-summary-with-date"       direction={Direction.Horizontal}       justifyContent={JustifyContent.SpaceBetween}       onClick={() => {         patNot.noLongerNew();         dispatch(updatePatientNotificationLite(patNot));         dispatch(updatePage(Page.NOTIFICATION_DETAILS));       }}     >       <oh-box         key="patient-notif-summary"         direction={Direction.Vertical}         justifyContent={JustifyContent.Left}         layout={{ marginTop: StyleSize.Small, marginBottom: StyleSize.Medium }}       >         <oh-box           key="patient-name-and-icon-box"           direction={Direction.Horizontal}           justifyContent={JustifyContent.Left}           layout={{ padding: StyleSize.None, margin: StyleSize.None }}           alignItems={AlignItems.Center}         >           {getNewIcon(patNot)}           <oh-box             key="patient-name-box"             direction={Direction.Horizontal}             justifyContent={JustifyContent.Left}             layout={{ padding: StyleSize.None, margin: StyleSize.None }}           >             <oh-markdown body={${patNot.patientInfo.getPatientName()}} key="patient-name" />           </oh-box>         </oh-box>         <oh-markdown           key="patient-dx-visit-type"           body={
Primary DX: ${removeDiagnosisCode(patNot.visitDetails.primaryDx)}
${patNot.visitDetails.visitType}}         />         {getLabel(patNot)}       </oh-box>       <oh-box         key="patient-notif-date-box"         direction={Direction.Vertical}         justifyContent={JustifyContent.Right}         layout={{ marginTop: StyleSize.Small, marginBottom: StyleSize.Medium }}         alignItems={AlignItems.FlexEnd}       >         <oh-markdown body={${formatDate(patNot.notificationDate)}} key="patient-notif-date" />       </oh-box>     </oh-box>       <oh-divider key={single-pat-not-div-${itemNumber}} />     </oh-box>

Thanks for bringing this to our attention. I created HELPS-2107 to track this issue, and we'll let you know once it's addressed!

@BrettMugglinOlive Do we have an estimated timeline for when this will be addressed?

Here is additional video showing the unfortunate effect this bug has on the interface.
Since we cannot get rid of the white borders within, nor can we control whether the hover background shows, we are simply stuck with this.
We will not be able to launch this Provider Workflow demo loop until this bug is fixed. We are near completion of V1.
https://user-images.githubusercontent.com/1859587/142056145-2d49e95c-d43c-4114-a198-d4a01e7956db.mov

@AlyseTack @coltonbrugger Unfortunately, it doesn't look like this defect made it in for the release that will be coming out here in the next week or so, but I can try to get it prioritized to be addressed next.

@AlyseTack @coltonbrugger Heya! I'm currently investigating this bug but was unable to render the whisper correctly. If possible can you provide the full component file that resulted in the described behavior? That'll help make sure we can really knock this sucker out!
PS: Using 3 backticks followed by code and another 3 backticks formats everything perfectly ;)
// imports

// const Component

// export Component

In order to reproduce this, you can just have a box component with two other boxes inside that have direction horizontal.  You can then add an onClick function to the outer box to produce the hover.  Youll notice that the more boxes you nest inside the children, the more white blocks appear on hover.  Here is the layout we are using.  There are some function in this code you would have to remove in order to get this to work completely on your end
    <oh-box
      key="patient-notif-summary-with-date"
      direction={Direction.Horizontal}
      justifyContent={JustifyContent.SpaceBetween}
      onClick={() => {
        patNot.noLongerNew();
        dispatch(updatePatientNotificationLite(patNot));
        dispatch(updatePage(Page.NOTIFICATION_DETAILS));
      }}
    >
      <oh-box
        key="patient-notif-summary"
        direction={Direction.Vertical}
        justifyContent={JustifyContent.Left}
        layout={{ marginTop: StyleSize.Small, marginBottom: StyleSize.Medium}}
      >
        <oh-box
          key="patient-name-and-icon-box"
          direction={Direction.Horizontal}
          justifyContent={JustifyContent.Left}
          layout={{ padding: StyleSize.None, margin: StyleSize.None }}
          alignItems={AlignItems.Center}
        >
          {getNewIcon(patNot)}
          <oh-box
            key="patient-name-box"
            direction={Direction.Horizontal}
            justifyContent={JustifyContent.Left}
            layout={{ padding: StyleSize.None, margin: StyleSize.None }}
          >
            <oh-markdown body={`**${patNot.patientInfo.getPatientName()}**`} key="patient-name" />
          </oh-box>
        </oh-box>
        <oh-markdown
          key="patient-dx-visit-type"
          body={`
Primary DX: ${patNot.visitDetails.primaryDx}
${patNot.visitDetails.visitType}`}
        />
        {getLabel(patNot)}
      </oh-box>
      <oh-box
        key="patient-notif-date-box"
        direction={Direction.Vertical}
        justifyContent={JustifyContent.Right}
        layout={{ marginTop: StyleSize.Small, marginBottom: StyleSize.Medium }}
        alignItems={AlignItems.FlexEnd}
      >
        <oh-markdown body={`${formatDate(patNot.notificationDate)}`} key="patient-notif-date" />
      </oh-box>
    </oh-box>
    ```

Shucks that was a fast reply @AlyseTack thank you so much, this is exactly what we're looking for!

This bugfix has been released! Closing this thread


dism++ 驱动管理，列表为空，但是dism /get-drivers却有。

用dism++添加驱动，然后用easysysprep4封装系统，第一第二阶段封装完毕后，用dism++空间回收。
这时候再进驱动管理，列表就是空的。
这个时候把系统拿去安装是不正常的，集成的驱动就跟没集成一样，万能驱动v7在pe下，也不能再次注入。
只能 dism /image:c:\1 /Remove-Driver /driver:xxx 一下，才能重新注入。
感觉是哪里被破坏掉了。
能不能加个检测到这个，并提示删除这些驱动的功能？

另外，原版镜像，这里面是会有这2个驱动的，
列表里面也没有了。

Not an bug in my opinion. You've not checked the box at the bottom, this means that only drivers that are not part of Windows itself are listed.
If you check the box, you'll see drivers installed with Windows itself (from Windows Update if needed), which are not necessarily the latest one, but just WHQL drivers (frequently outdated and not offering the best performance: you should install replacement drivers at least for the audio/video and system bus from nVidia, AMD, and Intel).
Your system just has no supplementary drivers installed (coming from OEM installers, such as those from nVidia or AMD Radeon, of from Intel for audio, video, bus or storage, or Logitech mouse/keyboard, or printer drivers, HD audio, or some suplementary Wifi USB adapters, or custom codec drivers)
Drivers for mouse/keyboard are generally not needed except for additional config panels (showing battery status or allowing custom configuration such as keyboard accelerators and macros or integration with games to dynamically optimize the settings depending on the software you use).
But drivers for RAID controlers are generally needed (Windows itself does not support many of them natively, and some of them may even be needed to boot your system and get access to the storage where the OS is installed and allow boting from it).
Drivers for Ethernet adapters are most often not needed; only some Wifi adapters require their own driver, but you just need the system drivers and not their additional control panels.
Some security tools also require their own drivers for booting and securing the system at boot. But you don't need to backup them: it's just safer to download a recent installer to get the last version from their support website. But you may need them if you need to repair your system and these drivers have encrypted the storage.
Most printer drivers don't need to be backup: those coming with Windows generally work fine (for wellknown manufacturers) and OEM drivers are frequently built only for older versions of Windows (newer versions of Windows are supported directly by WHQL drivers from Windows Update). But you may need them from some advanced panels (such as displaying the status of ink cartridge or better selection of paper formats an special mounting options, or presentation options not built natively in basic Windows drivers).
Other OEM drivers you may see in this panel are those for Android and Apple mobile devices or GPS devices when you connect them on the PC, or special filesystem drivers for synchronization with online storage services on a cloud.

这部分Dism++跟微软实现不一致，主要是Dism++要改进对精简系统的支持。所以是通过遍历inf文件夹实现的。你的问题应该是你用的封装工具，强行删除了inf文件夹的东西。建议你不用封装工具，单纯用Dism++验证下，应该就没这个问题了。如果情况属实，那么就反馈给你的封装工具吧。让它通过api的方式移除驱动，不要直接删inf。

inf是存在的，只是不在列表里面显示了。
而且下面打勾后， 也不在内置列表里。
同样的封装配置，同样的操作。却无法重现了。。。
只是之前的镜像是原版镜像安装-进系统后打补丁，然后做后续封装操作。不知道是从什么时候开始，列表就空了。
这次是挂载 install.wim，dism++打补丁，然后做后续封装操作。注入的驱动，列表里面却都有。

同样的封装配置，同样的操作。却无法重现了。。。
只是之前的是 install.wim 安装，进系统后打补丁，然后做后续封装操作。不知道是从什么时候开始，第三方驱动列表就空了。
这次是挂载 install.wim，dism++打补丁，然后再安装，再然后后续封装操作。注入的驱动，列表里面却都有。

我是说inf文件夹里没有对应的inf.
Windows/inf/oem*.inf

有什么软件直接干掉了oem*.inf，导致Dism++不能正常解析驱动。

另外你的截图水平太高了，刚好不截标题。我都不知道你的Dism++版本号。如果是Dism++ Beta分支，最近更改了一次驱动清理逻辑。不过后来想想也不可能，你都是在封装怎么可能会去用驱动清理

暂时关闭此问题。如果Dism++真的有问题在重新打开此问题。
谢谢支持


"multiple" tagging option not working with 4.0 with ajax data

I have found that if you are using the most recent 4.0 version of Select2 the multiple select "tags" do not appear when you select options even though they are being selected and added to the hidden fields in the DOM in the .select2-hidden-accessible class they do now get appended to the visible part of the dom as <li class=select2-selection__choice"> in the .select2-selection__rendered ul.
You can see this in action here:
http://jsfiddle.net/lindsayanng/khez3uoz/
I am using the base of your AJAX example and the versions from the CDN of the script.
Would love to know your thoughts as I am totally stuck here.
What steps can be used to reproduce the issue?
Setup the "ajax" example but add the mutliple: true parameter
What is the bug and what is the expected outcome?
The selected items do not appear in the text box as expected with all "multiple" examples
What browser(s) and Operating System have you tested with?
Chrome Version 44.0.2403.125 (64-bit)
Safari 8.0.6
Does the bug happen consistently across all tested browsers?
Consistent across the two browsers tested
What version of jQuery are you using? And what version of Select2?
Select2 4.0 and jQuery 1.7.2
Are you using Select2 with other plugins?
No. Was able to replicate in a jsfiddle without any added stuff loaded.

Thanks for the well-formed bug report! :+1:
I was able to reproduce the issue in your jsfiddle, and everything looked fine in the JavaScript. The issue was in the HTML, because you are trying to attach Select2 to a <div> instead of a <select>. A <div> cannot, by default, store a value which can be later transmitted to a server.
After switching to a <select>, the issue fixed itself.
https://jsfiddle.net/khez3uoz/5/

Ah ok then! The strange thing was that it worked with the old version of Select2.js but not the new version.
I believe that there are some docs or some examples floating around the net somewhere that suggest that you must use an element that is NOT a <select> in order to make multiple select work with ajax. I believe that may have been for the previous version, but it might be of note to include that the element MUST be a <select> when using the newest version.
Also, is there some type of aggregated list of differences between the version 3.X and 4.0 in terms of requirements to make the bare minimum work? I think something like that could be of help for people like me who are wading through docs and StackExchange questions/answers so we know what to watch out for?
I am considering writing up a quick tutorial on this myself anyways just because the info was so difficult to find. Any info you can provide me with for the tutorial in regards to what worked in 3.X that doesn't work in 4.0 would be hugely helpful.


using a dir other than test

I'm sure some peope love underscores, but to others a dir named __test__ is an absolute atrocity and it would be lovely to be able to tell jest which dir is the test dir. I don't see an option for this currently, so would it be possible to make this a CLI flag? $> jest -i test ... would be very user friendly compared to forcing a dirname that might not fit the fs conventions used by projects =)
(possibly also with a way to specify that through a .jestrc.json, or a "jest" section in package.json, or all those things because that's even more user-accomodating)

By default Jest runs all *.test.js, *.spec.js and files inside of __tests__. You can adjust the testRegex config option to whatever you like.


Docs warning against npm, still relevant?

There's a line in the contributing docs:

Note, we use yarn because npm has unfortunately become unreliable. Get it here.

Is there any reason to keep this here? https://github.com/Semantic-Org/Semantic-UI-React/pull/2081 is the PR from when it was added - seems like the only gripe was over lockfiles which are plenty standard and stable these days.

#3816 was merged, closing.


Not compatible with Shopware 5.2.12?

Hi,
Is this plugin compatible with Shopware 5.2.12? It doesn't ever redirect me to a language shop (en is the main shop, de is the language shop).
Any advice?
Thanks

Hi,
what kind of language is active in your Browser? The redirect is based on it and the correct plugin configuration.

Hi,
I've used a Firefox extension to set the Accept-Language HTTP header to "de_DE", which matches the locale of the language shop.
Should that work, or is there another way to test whether the plugin works?
Thanks

Hi,
i tested it without a plugin:

It doesn't work for me. I've got a main shop with Localization English (United Kingdom) and a language shop with localization German (Germany). I've tried changing the Firefox accept_language headers as in your screenshot. The headers do arrive at the shopware Apache as accept-language: de-DE,de;q=0.5.
This is my plugin config:

Any idea what I can try?

Hi @metachris
is this still an issue in the newest version?

closed due to inactivity. if this is still an issue for you, open a ticket again :blush: :+1:


Problem with nested collections

Hello!
I'm trying to implement Wordpress style archives in my Grav site.
For example,
Post: https://bestblog.wordpress.com/2007/06/13/elle-effect/
Day: https://bestblog.wordpress.com/2007/06/13/
Month: https://bestblog.wordpress.com/2007/06/
Year: https://bestblog.wordpress.com/2007/
I decided to use nested folders to work with it, but found some problems. First, I'm trying to work with adding year folders.
1_ Problem with pagination.
I use nested loop:
{% set yearCollection = page.collection() %}

<!-- Year loop -->
{% for postYear in yearCollection %}

<!-- Post collection -->
{% set postCollection = postYear.collection() %}

<!-- Post loop -->
{% for post in postCollection %}

....my html output...

{% endfor %}

{% endfor %}

{{ dump(postCollection.params.pagination) }}

{% if config.plugins.pagination.enabled and postCollection.params.pagination %}
    {% include 'partials/pagination.html.twig' with {'base_url':page.url, 'pagination':postCollection.params.pagination} %}
{% endif %}

And my dump is always null, I can get yearCollection pagination parameter only, not postCollection that I need.
Can I get all nested items in one BIG collection and set pagination with it?
2_ Before year directories I used this construction to output events on main page:
process:
    twig: true
    markdown: false
events:
    items:
        '@page': '/events'
    order:
        by: date
        dir: desc
    dateRange:
        start: today

Now with this code I can get only years, but can't get posts directly with '@page': '/events-year', also it doesn't work with '@page': '/2016. Why?
3_ Third problem is copy&pasting the same files for post in every year directory:

Without them I get error 404.
Is it possible to get rid all of these problems?

There are plugins to generate these sorts of archives. Have you looked at how they implement this? I know this doesn't answer your questions directly. I'd  just hate for you to waste time if  there's a plugin that will get where you want to go.

@Perlkonig This issue was opened long time ago in grav-plugin-archives repo:
https://github.com/getgrav/grav-plugin-archives/issues/16
I don't know any other type of plugin that can do this job for me...
I did a more deep research and found a way how to solve my 2nd problem.
In YAML:
<EMAIL_ADDRESS>'/events'

In md:
{% set events_collection = page.collection('events').ofType('post') %}

Desc do a recurse through folders and this good filter do a final job 👍
But it did't work for pagination (1st problem) 😞
I found an issue where this problem is discussed:
https://github.com/getgrav/grav-plugin-pagination/issues/18
Will be some movement on this issue?
3rd problem is still open...

postCollection in your example is null because of the scope, as it's defined inside the for but you access it outside of it. Use http://twig.sensiolabs.org/doc/filters/merge.html to populate an array in the iteration.

@flaviocopes

Use http://twig.sensiolabs.org/doc/filters/merge.html to populate an array in the iteration.

Can I use merge to put collections into each other?
And what about my other questions?

If you define postCollection inside the for, it's not accessible outside it.
If you access /2016 as a page, then it must have a markdown file in it, otherwise you'll get a 404.

I solved problems with scope and need help with 1st and 3rd problems.

@rhukster Why this issue was closed without any comment?

oh sorry, i just read "I solved problems..." and thought you were all sorted.  reopening.

@rhukster Don't worry :wink:
I would be very happy if you can help me with 1st and 3rd questions. Please read my comments here:
https://github.com/getgrav/grav/issues/1097#issue-181821336
https://github.com/getgrav/grav/issues/1097#issuecomment-252425970

Why I can't use only one frontmatter.yaml with template variable in it?
Documentation:
https://learn.getgrav.org/content/headers#template
How it looks:

frontmatter.yaml content:
template: events
content:
    items: @self.children
    order:
        by: date
        dir: desc

Error 404.
Why?

Closing to due to inactivity

@rhukster Because no answers from developers


Enable unstable APIs for stable types.

When unstable types are used in stable methods, those methods should be marked as unstable.
For example:
ReadableStream::pipe_to(writer: WritableStream) (WritableStream is unstable)
ReadableWritablePair is a dictionary of a ReadableStream and WritableStream. It's constructor and setter for the WritableStream should be unstable.

Thanks!


Show Example with Sequential or Functional API

Can you show an example with Sequential or Functional API? The argparse syntax is very hard to read. This looks amazing! Thanks for the contribution.
Also in your code, it looks like you do the learning rate update after each epoch but the paper author(s) does it after each "training iteration".  Ignore.

There's an example in the readme now.


Console app stdin, stdout, stderr streams do not support Unicode

The standard input, output, and error streams are opened in ANSI text translation mode and so do not support either Unicode input or output


Add small threshold for non perfect null axis vector components

In some URDF files have the axis attribute of the joints, i.e. the joint axis specified in the joint frame, have non perfectly null components for simple revolute or prismatic joints. See for example https://github.com/robotology/urdf2casadi-matlab/blob/a1fa3a9398f582448cd7ae9b083d29ff7313c73e/URDFs/iCubGenova9.urdf#L439 To set appropriately the joint type it is better to use a numerical threshold.
For a mathematical description of the URDF formalism see https://github.com/robotology/blender-robotics-utils/issues/3#issuecomment-906262419.

The change seems fine, but just to understand in urdf2casadi-matlab we do not support axis that are not aligned with x, y or z?

The change seems fine, but just to understand in urdf2casadi-matlab we do not support axis that are not aligned with x, y or z?

For now yes, we support only revolute and prismatic axes aligned with the joint frame. Actually I did add at the time a generalization for non aligned axis by converting from rotation axis to rotation matrix in https://github.com/robotology/urdf2casadi-matlab/blob/a1fa3a9398f582448cd7ae9b083d29ff7313c73e/%2Burdf2casadi/%2BUtils/%2BSpatial/jcalc.m#L36 Since I did not have right in my hand a URDF file with which I could test this feature, I decided to not add it as an option. Actually I thought that this case would be caught as an error in https://github.com/robotology/urdf2casadi-matlab/blob/a1fa3a9398f582448cd7ae9b083d29ff7313c73e/%2Burdf2casadi/%2BUtils/%2BSpatial/jcalc.m#L68 I will add this info specifically in the README.

Great, thanks!


Add support for emulated differential output (ELVDS)

This is a draft - I still need to figure out what I am doing
Will use https://github.com/YosysHQ/apicula/issues/158#issuecomment-1407959837
and https://github.com/YosysHQ/apicula/pull/86 as a guide.
Thanks again @yrabbit
EDIT: looks like the nano9k still has TLVDS so need to keep that for that board still

I added a PR to yosys here https://github.com/YosysHQ/yosys/pull/3652

Wow I look away for a second and we have a cool new feature and cool new contributor!
I see a lot of stuff in my mailbox, just in case, we also have a matrix/irc channel for more real time discussion.

The developments are taken into account in the PR https://github.com/YosysHQ/apicula/pull/177


IONIC Package function is not aware of the latest Google Services libraries

Why does this fail? Does this mean the IONIC Package function is not aware of the latest Google Services libraries?
Found com.google.android.gms:play-services-analytics:+, but version 9.2.0 is needed for the google-services plugin.
Found com.google.android.gms:play-services-maps:9.8.0, but version 9.2.0 is needed for the google-services plugin.
Found com.google.android.gms:play-services-location:9.8.0, but version 9.2.0 is needed for the google-services plugin.
:processDebugGoogleServices FAILED
FAILURE: Build failed with an exception.
What went wrong:
Execution failed for task ':processDebugGoogleServices'.
Please fix the version conflict either by updating the version of the google-services plugin (information about the latest version is available at https://bintray.com/android/android-tools/com.google.gms.google-services/1) or updating the version of com.google.android.gms to 9.2.0.
Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output.
BUILD FAILED

@team @adamdbradley @bensperry please resolve this issue asap. we are not able to build apk due to above error.

@dwieeb can you help with this

Any updates on this ???


BUG:In mobile the hamburger menu is at different positions

Is there an existing issue for this?

[X] I have searched the existing issues

What happened?
the hamburger menu is not responsive and is located at different positions in different pages ,and also the menu items are looking different in different pages,there is no consistent one

Record

[X] I agree to follow this project's Code of Conduct
[X] I'm a GSSOC'24 contributor
[X] I want to work on this issue

Fixed in #374


terraformer aws security filter not working

Hi can any one help i am importing scurity group through terraformer but it's not filter based on vpc
cloud provider:AWS
in DOC: terraformer import aws -r sg,vpc --filter Type=sg;Name=vpc_id;Value=VPC_ID
i have tried.
terraformer import aws -r sg --filter Type=sg;Name=my-vpc-02;Value=vpc-0f516ebxxxxb96685
terraformer import aws -r sg --filter Type=sg;Name=vpc-0f516ebxxxxb96685;Value=vpc-0f516ebxxxxb96685
but that did not work
please provide the solution

Ran into the same issue. Use "security_group" for the type instead of "sg".


App broke time to time

Hello everyone! My hapi app is crashing time to time.
NO glue about what can be.

Was this related to a change you might have made on your project?


Fix Logo

The logo seen on the page is broken image. Debug the code to extract right image.

[x] Make logo image download in img folders if assetmode is download.
[x] Liveload logo if assestmode is link.

Solved here #400


Transpiler will remove custom pulse gates if they look like they can be simplied with standard gates

Information

Qiskit Terra version: latest
Python version:
Operating system:

What is the current behavior?
The following circuit
circ = QuantumCircuit(2, 2)
circ.u2(0, np.pi, 0)
circ.h(0)
circ.x(1)
circ.cx(0, 1)
circ.measure(0, 0)
circ.measure(1, 1)

gets reduced to

even though I have made a custom calibration for the Hadamard gate that is no longer a valid cancellation.
Steps to reproduce the problem
Follow tutorial with a custom H gate and transpile.
What is the expected behavior?
Only valid cancellations should occur.
Suggested solutions
Probably do not cancel calibrations at this stage.

Is this not exactly what the transpiler should do? In my opinion one should opt-out of optimization by selecting optimization_level=0. This is also aligns with the previous path of schedule(transpiler(circ, backend), backend)

You are assuming that the custom pulse definition is correct for the supplied gate.  However, an user is allowed to do whatever they want with the definition of the pulses.  Once you give the freedom to define things however one wants, the standard rules are not necessarily satisfied.

I disagree. The user specified a program,   the transpiler has a defined behaviour and it should not auto magically change said behaviour to anticipate the users intent. The user who specifies correct pulses will have the opposite problem and be confused. I prefer consistency over perfection in this case.

Ok, feel free to close then.

I will just point out that this decision means that the transpiler need not preserve unitarity amongst optimization levels (something that used to be true).

A gate is an ideal unitary at the circuit level. In practice in the hardware that is not so. Adding poor calibrations is equivalent to having a backend that is poorly tuned up or with large errors. It is beyond the scope of the transpiler to decide that a user has specified one gate h but provided an implementation that is incorrect. If your custom Hadamard is no longer a valid cancellation it is not a Hadamard and should not be represented as such.


Fixed Planning Locks

This is a cleaned up version of #385, it fixes a locking issue where one planning function locks the robot and then may call another planning function which attempts to lock it again.

I agree, at least until we figure out a better way to handle locking with meta-planners. Thanks for starting this @Tonkel!

LGTM!


Add warning to link.js

I foolishly moved my Link component outside of the Router. I managed to figure it out pretty quickly but the error wasn't terribly helpful. See #3225. Thoughts?

Would it be better to place this warning in the render method?

Not in render because it would spam tests.

LGTM aside from that whitespace nit.

Done.

Thanks.

What do we think here? I think putting the invariant in onClick lets us give users a helpful warning when they try to use a <Link> outside the router context. I don't think we can make them not render outside the router context, though.

Well, given the problems with putting it on a normal lifecycle method, I guess that's out. I suppose having it on the click handler is better than nothing, but it still feels like we're not going to catch as many problems as we could.

A while ago I suggested we should make router object required unless NODE_ENV === 'testing'. But nobody uses NODE_ENV === 'testing'. I mean... do you?

Actually, that would be sort of counterproductive, since it means there'd be bugs in production that wouldn't get caught by tests. I dunno – it's hard.

Yeah, unfortunately this isn't Rails where RAILS_ENV is de facto standard. And worse still, NODE_ENV doesn't exist in the browser context, so headless browser testing would break all of that anyways.

Released with https://github.com/reactjs/react-router/pull/3571 as v2.5.1.

Any suggestions for unit testing now? I was using sinon to spy on onClick functions and simulating clicks with Enzyme. The use case is a bit odd perhaps - passing in an onClick function and want to prove that the click function is called/not called depending on whether a hidden bool passed in is true or false (this is on a slide-out nav panel for use on mobile). I can catch the errors to not have them fail the tests, but they obscure my spying on the onClick...

I could move the warning down to below where we call an external onClick. When you have your own onClick, the Link doesn't requires access to the router context.

Only if you preventDefault...
 And can you open an issue for this?


Cluster Linking - Transaction

Demo to understand how to manage transaction and cluster linking

Cluster Linking has not yet been fully tested to mirror topics that contain records produced using the Kafka transactions feature. Therefore, using Cluster Linking to mirror such topics is not supported and not recommended. But, is there a way to detect transaction and abort in a DR cluster?


EPA CEMS Intake Catalog

Description
Create a full featured Intake Catalog for distributing the EPA CEMS hourly emissions data stored as Parquet files. This follows some exploration in #1155, and feeds into #1179. I'm importing some overly broad design thoughts from #1495.
Billing
This work should be billed under our Sloan Foundation "Data Distribution" sub-project.
Goals

Allow users to easily work with this relatively large data set (~1 billion rows, 50GB uncompressed).
Make it fast and easy to query subsets of the dataset remotely, without having to download the whole thing.
Provide human and machine readable metadata in association with the data itself, so that users can understand what they're working with.
Ensure that parquet file names are human & machine readable, and compatible with many different filesystems and parquet access methods.
Ensure that our EPA CEMS ETL outputs data that's appropriate for distribution as a data catalog.

Methods

Partition the data by common filter columns (years, states) to make queries fast. This can be done in one file (using row groups) or many files (each of which is its own row group).
Allow efficient local filesystem caching of the remote data, so that users don't have to download it all at once, and so nobody has to pay unnecessary data egress fees. This means breaking it up into smaller individual files, like one per (state, year).
Enable parallel/distributed processing of the parquet outputs, avoiding concurrent writes to the same files from different workers.
Programmatically export metadata from our Pydantic models directly into the PyArrow schema, and also into the Intake catalog YAML file.

Problems

intake_parquet doesn't seem to be able to efficiently query a collection of separate parquet files using filters. It seems to still search through all of them when using wildcards like {{ env(INTAKE_PATH) }}/epacems/epacems*.parquet
intake_parquet can't take a directory (filled with parquet files) as its urlpath even though pandas and dask are happy to read from a directory. E.g. {{ env(INTAKE_PATH) }}/epacems/ does not work.
The simplecache file based caching that's available in some Intake plugins and that uses fsspec to access many different remote filesystems has not been implemented for intake_parquet.
The overhead associated with parallel / distributed processing of individual (state, year) partitions is too high for this arrangement to be efficient.
It's unclear how to specify min/max allowable years or the set of allowable state abbreviations for filtering, or how to enforce those limitations and provide useful feedback to the user if they are violated.
Pandas nullable string columns show up as object when read via intake-parquet

Tasks (to be turned into issues)
Minimum Viable Catalog
Publish a basic EPA CEMS data catalog that makes use of basic Intake functionality.

[x] Switch to producing a single EPA CEMS Parquet file as output, with (year, state) row groups (See #1563).
[ ] Ensure that all column types are preserved by Intake as they would be by read_parquet()
[ ] Determine the right format for table and column metadata in the YAML catalog file (names, types, descriptions).
[ ] Automate export of the catalog metadata from our Pydantic metadata models.
[ ] Constrain or at least indicate what years and states can be used to filter the data efficiently.
[ ] Create a dedicated repository for our high-level data catalog.
[ ] Set up CI in the data catalog repository to test whether the catalog is valid and working.
[ ] Package and publish that catalog for installation via conda.

Ideal Catalog
Improve the usability of the EPA CEMS data catalog by enabling file caching and fast filtering on collections of Parquet files. This may or may not be strictly necessary for EPA CEMS depending on how fast everyone's network connections are, and how much we end up paying in data egress fees. E.g. or cloud-based access where you have a 1-10Gbit network connection, downloading 5GB of data will only take seconds, and if it's in the same zone as our storage, there will be no fees.
In addition to allowing efficient file caching, distributing the data in many smaller files will make it easier to split up the work of processing the data across many workers (they can all write their own state-year files) without needing to then combine those smaller files into a single large file at the end.

[ ] Implement fsspec / simplecache based file caching for the intake_parquet plugin (See also #1496)
[ ] Implement fast filtering for collections of parquet files (either wildcard or directory based) within the intake_parquet plugin.
[ ] Switch to producing a directory of epacems-YYYY-SS.parquet files when file caching and fast filtering are working.

Out of Scope

Parallelizing / Distributing the processing of the EPA CEMS data (that'll happen in the Dagster refactor).
Any additional EPA CEMS data wrangling, e.g. the things discussed in #1049

Whoops yes I forgot to add the intake requirements. I had them installed in my local environment.
The dtypes you've got listed there seem to be the correct ones. But you have no year or state columns.  I'm still confused as to why those aren't showing up, given that the data is definitely stored in the files.
I really don't understand how the source specific metadata works. My suspicion is that the allowable year/state values can be put in there, and the column/table descriptions, but I don't see any documentation on how to do it appropriately.

Hey @martindurant thanks so much for your comment on #1496! I got simplecache working and created a basic installable catalog, and have been experimenting with different setups for our open US energy data catalog over in the pudl-catalog repo. I've collected a bunch of outstanding issues in the issue above, which point at the individual pudl-catalog issues and was wondering if we might be able to get some advice from you on how best to set things up. I'm not sure which of these things is just me not understanding how to configure the catalog correctly and which are deeper constraints.
Do you happen to have a list of publicly visible intake catalogs that use Parquet data sources? I've tried searching GitHub but haven't been very successful. The CarbonPlan Data repo is the best I've seen, but they have a very simple configuration.
Once the EPA CEMS Hourly Emissions data source is finished, we also want to look at writing an intake-sqlite driver (#1156) to manage the distribution of versioned SQLite databases, which will download and cache the database file locally, and then use the intake-sql driver to access it. Does that seem like a reasonable approach?  Thanks for any pointers you can offer!


dev and rel tag need to be part of version name

The version dropdown box shows repeatedly the same version information.
I assume if a dev-tag is created and later a rel-tag with the same version information than it will have the same name as dev/rel information is dropped.
Improvement:
versions shall be called jobid_<dev/rel>_version

Integrated in RobotFramework AIO 0.13.0


[WIP] Support many legacy keys

This allows us to migrate from one v2_key to another

fixes not properly clearing legacy key values. taken from #4082
consistently leave environment same for all. load local keys when files not necessary
external classes and specs no longer rely upon a key's version number
allow any number of legacy keys to be present (no longer hard coded to one of each: v0, v1, v2)
fix auth can migrate a database from one v2_key to another. (see bz)
TODO: add supports to auto include developer key in development. (maybe just use code from #4082)

/cc @jrafanie
https://bugzilla.redhat.com/show_bug.cgi?id=1159009

@jrafanie @Fryguy I needed to remove the hard coded list of keys to allow admins to specify a few v2 keys during migrations.
They need this when they want to transition from one key to another due to 1) security breach, 2) security key change policy, 3) migration from dev to prod, 4) multiple key mistake, or others.

support for multiple keys could give us more options for #4082
lets avoid magic key file names
do we even need a v2_key vs legacy_keys[] concept at all? Could we just have keys[].

@Fryguy this is the followup to the v2_key change - this lets users change the key of any database

The primary use case for all_keys is to iterate through them, where the primary encryption key (v2_key) needs to be considered first.  For that reason, I like having it as an array.
I did remove legacy_keys, since that really isn't needed by anyone besides a few tests.

@kbrock Please address failing specs


+windows

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
2 unchanged lines in 1 file lost coverage.
Overall coverage increased (+0.07%) to 97.841%

Files with Coverage Reduction
New Missed Lines
%

src/modes/integrate.ts
2
95.56%

Totals

Change from base Build<PHONE_NUMBER>:
0.07%

Covered Lines:
1364

Relevant Lines:
1391

💛  - Coveralls

A suggestion in case you have not thought about it yet:
Perhaps using something like https://github.com/dsherret/dax in brewkit can help minimize the changes needed in pantry regarding the build scripts (assuming you are not going to use MSYS2 or Cygwin to provide native Bash on Windows).

We'll revisit this some other day.


Fully Preserve Project File Formatting

Customer scenario
Currently, we strip whitespace from project files, and don't respect whitespace changes when deciding if the project file editor buffer is up to date. This change reacts to https://mseng.visualstudio.com/DefaultCollection/VSIDEProj/_git/VSIDEProj.CPS/pullrequest/175897, enabling us to preserve all project file formatting.
Bugs this fixes:
Fixes https://github.com/dotnet/roslyn-project-system/issues/1094, https://github.com/dotnet/roslyn-project-system/issues/743, https://github.com/dotnet/roslyn-project-system/issues/512.
Workarounds, if any
Edit with an external editor, and don't use the NuGet UI to add packages.
Risk
Very little risk on our side, the main risk is in CPS/MSBuild.
Performance impact
We actually improve performance with this change, as we're no longer normalizing text to do a whitespace-insensitive comparison.
Is this a regression from a previous update?
No, known issue.
How was the bug found?
Internal testing.
Tagging @dotnet/project-system @davkean @jviau for review.

Tagging @MattGertz for shiproom consideration. The required CPS change was merged last night.

Approved to merge via 371312


td_agent_gem provider broken

Hi,
The td_agent_gem provider seems to not work as intended.
Adding this to a recipe causes an failure.
td_agent_gem "tail-multiline" do
  plugin true
end

It seems like it is not able to take the name inside the td_agent_gem and assign it to the package_name variable.
I'm running chef 10 if it helps..
[Tue, 10 Jun 2014 16:36:08 +0200] INFO: Processing td-agent_gem[tail-multiline] action install (dp_td-agent_wrapper::default line 39)

================================================================================
Error executing action `install` on resource 'td-agent_gem[tail-multiline]'
================================================================================

Chef::Exceptions::ValidationFailed
----------------------------------
Required argument package_name is missing!

Cookbook Trace:
---------------
/var/cache/chef/cookbooks/td-agent/libraries/provider_td_rubygems.rb:31:in `initialize'

Resource Declaration:
---------------------
# In /var/cache/chef/cookbooks/dp_td-agent_wrapper/recipes/default.rb

 40: td_agent_gem "tail-multiline" do
 41:   plugin true
 42: end
 43:

Compiled Resource:
------------------
# Declared in /var/cache/chef/cookbooks/dp_td-agent_wrapper/recipes/default.rb:40:in `from_file'

td_agent_gem("tail-multiline") do
  cookbook_name "dp_td-agent_wrapper"
  provider Chef::Provider::Package::TdRubygems
  action :install
  retry_delay 2
  plugin true
  recipe_name "default"
  retries 0
end

[Tue, 10 Jun 2014 16:36:08 +0200] ERROR: Running exception handlers
[Tue, 10 Jun 2014 16:36:10 +0200] FATAL: Saving node information to /var/cache/chef/failed-run-data.json
[Tue, 10 Jun 2014 16:36:10 +0200] ERROR: Exception handlers complete
[Tue, 10 Jun 2014 16:36:10 +0200] FATAL: Stacktrace dumped to /var/cache/chef/chef-stacktrace.out
[Tue, 10 Jun 2014 16:36:10 +0200] FATAL: Chef::Exceptions::ValidationFailed: td-agent_gem[tail-multiline] (dp_td-agent_wrapper::default line 40) had an error: Chef::Exceptions::ValidationFailed: Required argument package_name is missing!

hmm, not running chef v10 since long ago and this ticket is stale, closing.


MicrosftDocs/appcenter-docs

Sniper Arena v2.9.1 Aimbot
Made by shmoo @hackedbyshmoo
I included a copy of the code without comments so those of you who want to view the code without clutter can do so.
This aimbot is for educational purposes only. I purposely left out class implementations for Vector3 and Quaternion. You can write those yourself. There's also implementation for Quaternion::LookRotation online. I included the dump for reference.
Please watch this time, it will make a part of the code make more sense:


Why DELETE operation doesn't support request body argument?

https://github.com/zalando/connexion/blob/34c7cb160fec372d386a0daa139df2a568b01ac8/connexion/operations/abstract.py#L273
Hi,
Is there a reason why DELETE verb doesn't support request body in version 2.2.0?
In version 1.1.15 I was able to send request body as a parameter.
Python version:
3.6.7
connexion version:
2.2.0
Thanks!

The spec  says that the URI should be sufficient to perform the delete operation.

The DELETE method requests that the origin server delete the resource identified by the Request-URI
It isn't expressly forbidden to include a request body, but it is generally accepted that you do not.  I Feel that this is the same reason why here.

I see, thanks for the explanation!
I think it should at least be configurable since this was working on earlier versions.
anyway I can workaround this using:
   request = connexion.request.json

A more recent RFC is more explicit on payload behavior:
https://tools.ietf.org/html/rfc7231#section-4.3.5

A payload within a DELETE request message has no defined semantics;

The link was provided from this Stackoverflow question:
https://stackoverflow.com/questions/299628/is-an-entity-body-allowed-for-an-http-delete-request
I have rarely seen a body in delete, the only example I have in mind is this one:
https://kubernetes.io/docs/reference/generated/kubernetes-api/v1.18/#delete-job-v1-batch
When we delete a Kubernetes job, we can mention some delete options.
Even if it is accepted that we do not, it could make sense to allow it in the framework?


editorial: status codes and descriptions in the swagger documentation

The swagger documentation is inconsistent about Descriptions for status codes. Sometimes, it uses the HTTP definition like 200 (OK); other times such as for 401 (Unauthorized) it uses Failed to Authenticate instead.
In general, if we're not going to document why a specific status code is returned, then we should simply use the standard HTTP names.

Per triage with @jahilton and  @Bento007  - merging this into the openapi issue.


Visual show all objects on position

Solves: https://github.com/gdg-garage/space-tycoon/issues/75
Objects are discovered at the time of the click.
Order of shown objects:

Clicked object
Planets
Ships
Wrecks

why planets before ships?

why planets before ships?

There can be many ships but only one (or just a few) planets on the position. So it makes sense to show the planet before ships because it doesn't take up mych space and it is important. The planet not being shown because there is too many ships doesn't make sense to me. The opposite problem doesn't exist because there can't be a lot of planets on a single position.


use docker healthcheck status for readiness

The Problem:
Our existing readiness check tests for a 200 status on the healthcheck endpoint of our web container. This works great for the web container, but it is not useful for determining readiness of any other container.
The Fix:
Docker introduced HEALTHCHECK in 1.12. We should leverage it, so that ddev can determine the readiness of any container, so long as a HEALTHCHECK CMD is defined for the container.
This will help to be able to satisfy the requirement that import-db should not run unless the site is provisioned. Checking the db container seems like the most relevant check in this case. This will also help in writing a test case for import, as I need to wait for the db container to be ready.
The Test:
On a test site that you have run ddev config, update the tags for both web and db images to the docker-health tag and run ddev start. The readiness check will use the new docker health check status. If you are using the docker-health tag, the site should report ready as expected.
Automation Overview:

Related Issue Link(s):
Release/Deployment notes:

This still has the "Needs tests" label - is it ready to go? Since the tests explicitly use it, maybe that's it?

I ended up reworking and making quite a few changes after approval, so this could probably use another review. I have also addressed a couple outliers in this PR:

Moved util sub pkgs back to util main pkg
#123 introduced a test for ImportSQLDump, but it was disabled as it needed this work in order to succeed. It has been updated as a working test.
I also changed app.Wait() for better flexibility to use for other containers aside from web.


Release link broken

On the share-button master branch, the link under Getting Started: Download the script and include it on your page. points to a v1.0.0 tag that doesn't exist.

moved the link to just point to releases


Uploading stemcell timeout error

In my cloud account, uploading of stemcell takes around 7 minute. But code allows only for 5 minute and throws timeout error.
creating stemcell (bosh-openstack-kvm-ubuntu-trusty-go_agent 3445.7):
CPI 'create_stemcell' method responded with error: CmdError{"type":"Bosh::Clouds::CloudError","message":"Timed out waiting for Image `24316d83-d90d-4643-9ef5-736e1decb15a' to be active","ok_to_retry":false}
Is there any way I can change the default timeout value.
Thanks,

@vinayakbhat24 This error occurred on the GCP CPI side, and that particular timeout does not seem to be configurable. You can try one of the following:

retry the same upload - it might just work
replace the stemcell URL with the light one - URL: https://s3.amazonaws.com/bosh-gce-light-stemcells/light-bosh-stemcell-3445.7-google-kvm-ubuntu-trusty-go_agent.tgz, SHA1: 4bc264aab6717c81fb3a37783e796982fe9956ca

@jhvhs Thanks for hinting me at file openstack/cpi.yml.  Even I can change default timeout value using this file.
Thanks,


Mention backup storage size, comparison fair?

:wave: Hi there, restic looks good but after reading this backup storage size comparison it looks very space insufficient. Wondering if this comparison is fair, it seems to conflict the 'efficient' point in the documentation.

We've covered this topic in the forum already, and you're right: We haven't reached our self proclaimed goal here yet. The main reason for that seems to be the missing compression (see #21). I'm going to close this issue for now, please feel free to add further comments (maybe in the forum, that's the more appropriate place)!


Create mp.jwt.verify.token.age config property for issue #195

Signed-off-by: Teddy J. Torres<EMAIL_ADDRESS>

@teddyjtorres Thanks for opening this PR; can you please  add a TCK to it ?
I said I can do it but I've looked at the code, it should a simple update:

add this property to the resource loaded here, https://github.com/eclipse/microprofile-jwt-auth/blob/master/tck/src/test/java/org/eclipse/microprofile/jwt/tck/container/jaxrs/InvalidTokenTest.java#L66, lets say, make it 4 secs
copy https://github.com/eclipse/microprofile-jwt-auth/blob/master/tck/src/test/java/org/eclipse/microprofile/jwt/tck/container/jaxrs/InvalidTokenTest.java#L83 to a new test, remove the invalid fields property in that new test and after generating a token add a sleep for 5 secs - this should also fail with 401.

That should be enough
Thanks


Bump minor version for release

Prepare @azure/cosmos for release

API change check
API changes are not detected in this pull request.


Fix a tiny typo on documentation

Thank you for your watching.
Maybe there is a tiny mistake.
Please check this.

I think it should be 'This is purely an educational proof of concept.'

Oh, thank you for your advice.
If it is so, I will close this PR.
Sorry...

I considered it.
That seems reasonable to me.


Fix: standardize subcommands to use '-' instead of '_'

Resolves #29
Swaps the show_upstream and show_downstream commands for show-upstream and show-downstream respectively. A deprecation warning is thrown when the old syntax is used, which can easily be dropped in the future.

Forgot to run black and run tests locally. Will mark as ready when I finish both, my bad!

@mikekaminsky forgot to bump the version. Are you aligned with a bump in the minor version and not a bug fix? This is kind of an odd change so I could see it going both ways

@aescay indifferent enough it doesn't matter -- agree it's a weird edge case. Let's ship it :)


[NO_MERGE] For CI test - update postgresql branch to the latest master

To update PostgreSQL to the latest master:
Steps:

Checkout the latest PostgreSQL and rebase interactively on the latest master.
Resolve any conflicts.
Adapt PostgreSQL to fix compile code failures.

Green List:

[x] CI is green on the PostgreSQL module (use the PostgreSQL Jenkinsfile).
[x] CI is green on all modules.

Note:

Most conflicts come from the Antora documentation.

:green_apple: CI is green on the PostgreSQL module (use the PostgreSQL Jenkinsfile).  :green_apple:

:green_apple: :green_apple: :green_apple: CI is green on all modules.

Good job!
How do we merge that into postgresql?

Good job!
How do we merge that into postgresql? I guess we push this on postgresql branch minus the commit [Update Jenkinsfile master (just for ci test)](https://github.com/apache/james-project/pull/2467/commits/50f8b1ddf1d344f811b2785a6dd3af9af6d43f8d) correct?

absolute correct

Done, will close this for now. Thanks for the work on this guys!


fileio: Update closefd, closed when close method is called

@youknowone @windelbouwman Please take a look

Looks good to me! Thanks!


Add the ingressClassName field to the Issuer and ClusterIssuer resources to support the ingressClassName from Ingress v1

Motivation
cert-manager currently only supports using the annotation kubernetes.io/ingress.class. This PR adds support for the Ingress v1 ingressClassName field.
This feature had been originally implemented in #5225. We decided to not go with a global flag that would switch from one mode to the other.
Documentation: https://github.com/cert-manager/website/pull/1196
Closes: #4821
/kind feature
Release Note
The HTTP-01 solver can now be configured to create Ingresses with an `ingressClassName`. The credit goes to @dsonck92 for implementing the initial PR.

we also say that only 1 of the 3 fields can be set there?

Correct. I added this constraint to the documentation of the name field.

/lgtm

Unfortunately, when I use the ingressClassName ClusterIssuer setting together with the acme.cert-manager.io/http01-ingress-class Ingress annotation, I get the following error on my challenges:
  Type     Reason        Age                From                     Message
  ----     ------        ----               ----                     -------
  Normal   Started       19s                cert-manager-challenges  Challenge scheduled for processing
  Warning  PresentError  14s (x3 over 19s)  cert-manager-challenges  Error presenting challenge: the fields ingressClassName and class cannot be set at the same time


badge request

Username and Discrim: bakzkndd#2819
User ID:<PHONE_NUMBER>53009408
Image Link: https://cdn.discordapp.com/emojis/816451733285896193.gif

done!


Common packages to be included in coreteampackages

Common packages on which a lot of packages (should) depend on should be part of the core packages. Namely Visual C++ redistributables:
vcredist2005
vcredist2008
vcredist2010
vcredist2012
vcredist2013
vcredist2015
Right now it seems that almost all packages which depend on the Visual C++ runtime, individually install it either in the bootstrapper or as a merge module in the MSI file.
Making the redistributables available as maintained packages would make it easier for these packages to split up the dependencies.

Makes sense.

@matbech just looking back at some older issues, and stumbled into this one.
Were you in a position to look at this?  I know you have done a lot of work in maintaining the vcredist2015 package.  Have you looked into who is currently maintaining the other packages?  Could you help out in this regard?

The vcredist2015 package is currently maintained by https://github.com/pocki
Maybe he can share some details on why he has decided not to use the chocolatey-coreteampackages repo.

Actually, @pocki has asked me to take over maintaining vcredist2015 a short while ago (hasn't made me co-maintainer yet, though). He had been actively updating that package, but now he said he was stepping away from maintaining packages in the community repo.
I do not know his reasons for continuing to update the package in his repo after his PR was accepted here. However, it might have been for convenience reasons - it is much easier and quicker to update the package in one's own repo than to wait until a PR is accepted.

@jberezanski ah, I see.  Would you be interested in maintaining the source code for the package in this repo then, rather than your own?  You have write access into the repo 😄

@jberezanski said...
it is much easier and quicker to update the package in one's own repo than to wait until a PR is accepted.

To an extent I agree with this, and can understand the thought process.  However, as has just been evidenced, they are no longer in a position to maintain the package.  Had they been using the version in this repo, it would have been easier to switch to another maintainer, rather than moving source code to another repo.

Would you be interested in maintaining the source code for the package in this repo

With pleasure.

You have write access into the repo

I keep forgetting that 😉

Had they been using the version in this repo, it would have been easier to switch to another maintainer, rather than moving source code to another repo.

Agreed. In case of important packages that many other depend upon, it is vital to be able to continue updating the package if the current maintainer goes AWOL. Hosting the package in this repo provides that capability.

@jberezanski nice one, thank you very much! 😄

Looks like each of these packages have been created.  While the could, and perhaps should, be moved to the core team packages repo is another question.  For now, I think we can close this out.

SGTM. We can tackle that problem later and create different ticket for it.


..

Please don't open empty issues with no content, if you have a question, contact us on https://t.me/getumbrel, if there's a bug in Umbrel OS or you have a suggestion for Umbrel OS, open an issue here.

Sorry, wrong screen open, will remove this


first run error on fresh initialised SvelteKit template

reproducible for me with the following steps
npm init svelte@next sveltekit-mdsvex-debug; \
cd sveltekit-mdsvex-debug\
npm install \
npx svelte-add mdsvex

 npx svelte-add mdsvex
➕ Svelte Add
The project directory you're giving to this command cannot be determined to be guaranteed fresh — maybe it is, maybe it isn't. If any issues arise after running this command, please try again, making sure you've run it on a freshly initialized SvelteKit or Vite–Svelte app template.

mdsvex
file:///Users/franz/.npm/_npx/76ab19934dff27c3/node_modules/svelte-add/index.js:324
                reject(new Error(body));
                       ^

Error: (node:38145) [DEP0147] DeprecationWarning: In future versions of Node.js, fs.rmdir(path, { recursive: true }) will be removed. Use fs.rm(path, { recursive: true }) instead
(Use `node --trace-deprecation ...` to show where the warning was created)
(node:38153) [DEP0147] DeprecationWarning: In future versions of Node.js, fs.rmdir(path, { recursive: true }) will be removed. Use fs.rm(path, { recursive: true }) instead
(Use `node --trace-deprecation ...` to show where the warning was created)

    at Socket.<anonymous> (file:///Users/franz/.npm/_npx/76ab19934dff27c3/node_modules/svelte-add/index.js:324:10)
    at Socket.emit (node:events:377:35)
    at endReadableNT (node:internal/streams/readable:1312:12)
    at processTicksAndRejections (node:internal/process/task_queues:83:21)

node v16.2.0
npm 7.13.0

Tried to do the same on svelte-kit project.
node: v14.16.0
npm: 6.14.11
npx svelte-add mdsvex
npx: installed 61 in 11.655s
➕ Svelte Add
The project directory you're giving to this command cannot be determined to be guaranteed fresh — maybe it is, maybe it isn't. If any issues arise after running this command, please try again, making sure you've run it on a freshly initialized SvelteKit or Vite–Svelte app template.

mdsvex
(node:64090) UnhandledPromiseRejectionWarning: Error: npx: installed 203 in 3.954s
npx: command not found: use-preset

    at Socket.<anonymous> (file:///Users/def/.npm/_npx/64090/lib/node_modules/svelte-add/index.js:324:10)
    at Socket.emit (events.js:327:22)
    at endReadableNT (internal/streams/readable.js:1327:12)
    at processTicksAndRejections (internal/process/task_queues.js:80:21)
(Use `node --trace-warnings ...` to show where the warning was created)
(node:64090) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). To terminate the node process on unhandled promise rejection, use the CLI flag `--unhandled-rejections=strict` (see https://nodejs.org/api/cli.html#cli_unhandled_rejections_mode). (rejection id: 1)
(node:64090) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.

I should add that in my case, running npx svelte-add mdsvex again results in success...


Auto-certification: dataset that earned raw certificate failed to be published

From the recent pilot run for N. Yorkshire - see http://staging.certificates.theodi.org/campaigns/10
The following dataset failed to be published, despite passing the raw level criteria:
Fraud Information for North Yorkshire Fire and Rescue Service

This is caused the same issue that is causing Glasgow to fail.
The SSL certificate chain isn't set up correctly on https://www.northyorksfire.gov.uk so the URL checker is failing it.
The certificate is only published if it reaches the correct level and if all the urls provided in the questionnaire work correctly.

It does need to show this better in the interface though

Took the link off, so I hear this should work now. Could we re-run the programme again?


Space problem and L4T32.2.0

Is it okay that before running patch script there was around 20 GB free space on the SD card, but after patching there are only 5 GB left. Maybe I should clean something.
Could you help me, because I have only 32 GB SD card.
I also have another question , is it possible top run patching with L4T 32.2.0?? Or only with 32.2.1?? Because I got the error on another SD card , where I have L4T 32.2.0 and when I am running the patching script I am getting error about L4T mismatching.
Or maybe someone now how is it possible to update L4T?
Thank you!
Regards,

There has been no activity on this issue for a while, please open if you encounter further issues.


Pagination not working, when using browser "back"

Bug Report
We've implemented the pagination example for ourself and it is working great, when using the navigation buttons or just when refreshing the page. But when using the browser back-arrow, we have some mixed behaviour.
It's reproducable on the Cookbook: https://putyourlightson.com/sprig/cookbook#pagination

Open the page
Press "Next"
Use back arrow
Press "Next"
Use back arrow

Plugin Version
2.7.3
Craft CMS Version
4.7.2
PHP Version
8.2.x

What is the exact behaviour you’re seeing that might be a bug?

Sorry. The first page is
Blitz
Campaign
Sherlock

When following the reproduction, the result is
Cache Igniter
Sprig
Snaptcha

That is page two. So when going from url ?page=2 to the page without the page parameter, the page is not updated correctly.

I am using latest Firefox.

My guess is that this is a limitation of htmx, which snapshots each version of the history. Going back, then proceeding might be throwing off subsequent back actions, but you’ have to ask in the htmx repo or Discord server for a more complete answer.


Adds WAITING_FOR_LOAD status after deployment is ready

As the trial gets executed we need a mechanism to poll and get the current status of the trial, So added a attribute status in ExperimentTrial and updating it based on the changes done on the trial
Signed-off-by: bharathappali<EMAIL_ADDRESS>

@dinogun This PR is ready to be reviewed

This needs a rebase

@dinogun Rebased and made status to follow the flow and get updated as discussed in the above comments. Please review the PR and let me know if any changes needed. Thanks in advance.


"Help" link on Navbar points to the wrong URL

"Help" on the navbar points here, which is blank - https://freecen2.freecen.org.uk/cms/information-for-coordinators
Action: Change link to point to https://freecen2.freecen.org.uk/cms/help

It does point to the right page, however it is placeholder and does not yet contain required info/links. Shall keep this story but change the title - please remove if it's a duplicate.

Closing.


Put-items-back-again-feature

[ ] Items are put back (destroyed with update to all relevant places, implement with counter.putitemback method)

[ ] Add unit test beforehand - test all relevant changes and no changes to order of other items on scene (with snapshot?)
[ ] implement functionality

[ ] In place item method, prioritize most right slot so item gets put in empty slot after item was put back - maintain sorted index list, that counter uses to place the items

[ ] Unit Tests beforehand:

[ ] Items are placed from first to last position in the normal scenario (Placement order)
[ ] On single item removal, and rebuy, ensure placement at same position.
[ ] On multiple item removal and rebuy (all removal all rebuy), new items are placed from first to last slot however possible.
[ ] Think about other edge cases and note here (2 remove, 1 buy, 1 remove, 2 buy?)

[ ] Make tests go green :)

Thought about implementation:
Counter adds slot number of item to a available slots or similar sorted list, where PlaceOnCounter looks at, when placing the item and choosing the slot


pdfarranger: 1.6.2 -> 1.7.0

Motivation for this change
update
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[x] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[ ] Fits CONTRIBUTING.md.

changelog https://github.com/pdfarranger/pdfarranger/releases/tag/1.7.0

changelog https://github.com/pdfarranger/pdfarranger/releases/tag/1.7.0

Result of nixpkgs-review pr 110808 run on x86_64-linux 1

1 package built:

pdfarranger

Result of nixpkgs-review pr 110808 run on x86_64-linux 1

1 package built:

pdfarranger


API not working (anymore)

Following are NOT working (anymore)
export * from './spices/emojipedia.ts';
export * from './spices/forecast.ts';
export * from './spices/statista.ts';

Following NOT TESTED
export * from './spices/expandUrl.ts';

Following are WORKING
export * from './search/images.ts';
export * from './search/news.ts';
export * from './search/search.ts';
export * from './search/videos.ts';
export * from './spices/currency.ts';
export * from './spices/dictionary/audio.ts';
export * from './spices/dictionary/definition.ts';
export * from './spices/dictionary/hyphenation.ts';
export * from './spices/dictionary/pronunciation.ts';
export * from './spices/dns.ts';
export * from './spices/statista.ts';
export * from './spices/stocks.ts';
export * from './spices/thesaurus.ts';
export * from './spices/time.ts';

I guess repo is dead


improved conversion report

Fixes #294

Added percentage of columns mapped cleanly in migration from the source database to Spanner in the conversion report.
Added percentage of rows mapped in migration from the source database to Spanner in the conversion report.

Looks like the initial precision setting was part of the logic, we should revert it to that. Approving anyways.

This will be reverted in the next pull request.

Closing pull request. Will make new pr's, each adding a specific functionality.


Add per-app infrastructure

Resolves #65
Resolves #66
Resolves #67
Resolves #69
This PR adds the terraform to create per-app infrastructure as defined in an apps.yaml config file as per the serve designs
Includes:

Add a apps.yaml config file that gets read in and validated by Terraform
New module for app that can be used in conjunction with foreach
Deploy a web app into App service plan in a subnet
Enable diagnostic container logging
Establish MSI connectivity to ACR
Add ACR web hook to automatically deploy on container push
Create Cosmos DB database with custom role definition so app can only access its own database
Set up log analytics in core and app insights per app
Re-structure repository to flatten serve folder into an apps folder
Add make apps command
Add convenience make command make tf-init to fix any dependency lock issues by running init in each module recursively

Running the Dash-Seedling app:

Still to do:

Update environment file handling so we can re-use in CI. This will be as part of #42

/test

/test-force-approve


Versioning3 Needs pull request approved to ultimately test.

Needs pull request approval for final testing (should auto version only on both pull requests, and manual versioning workflow).

not sure why but it looks like new_release is not running on this... need to look into this further.

not sure why but it looks like new_release is not running on this... need to look into this further.

Actually, I think it is because it has not been pulled to main yet. Once it is I believe this should happen automatically, and that it will automatically version when pulls go through or commits are pushed to main/dev. Furthermore, pulling this to main should update old workflows and enable us to run new workflows. This is another thing to verify once pulled.


Notebook cells should show execution order

Issue Type: Feature Request
Notebooks allow us to move among the cells  and execute those in random order. Classical notebooks track the execution order using a number on the left hand side pane. In the ADS notebook we do not have any such indicator, which makes tracking difficult.
Azure Data Studio version: azuredatastudio 1.2.3-insider (8439cde6106ec3bf443fff5e8a8b54c5e98ac170, 2018-11-01T04:31:37.329Z)
OS version: Windows_NT x64 10.0.17763

@kevcunnane added this feature for February.


Error using this packe

Not sure if this coming from this package but we experiencing an isolate crash.
I think it is from this package after one of the flutter version updates.
The crash happens when calling channel.sendResult(someContent)
Can you please take a look?.
E/flutter (22286): [ERROR:flutter/runtime/dart_isolate.cc(1098)] Unhandled exception:
E/flutter (22286): Invalid argument(s): Illegal argument in isolate message: (object is a SuspendState)
E/flutter (22286): #0      _SendPortImpl._sendInternal (dart:isolate-patch/isolate_patch.dart:249:43)
E/flutter (22286): #1      _SendPortImpl.send (dart:isolate-patch/isolate_patch.dart:230:5)
E/flutter (22286): #2      new IsolateChannel.<anonymous closure> (package:stream_channel/src/isolate_channel.dart:100:36)
E/flutter (22286): #3      _RootZone.runUnaryGuarded (dart:async/zone.dart:1586:10)
E/flutter (22286): #4      _BufferingStreamSubscription._sendData (dart:async/stream_impl.dart:339:11)
E/flutter (22286): #5      _BufferingStreamSubscription._add (dart:async/stream_impl.dart:271:7)
E/flutter (22286): #6      _SyncStreamControllerDispatch._sendData (dart:async/stream_controller.dart:774:19)
E/flutter (22286): #7      _StreamController._add (dart:async/stream_controller.dart:648:7)
E/flutter (22286): #8      _StreamController.add (dart:async/stream_controller.dart:596:5)
E/flutter (22286): #9      _RootZone.runUnaryGuarded (dart:async/zone.dart:1586:10)
E/flutter (22286): #10     _BufferingStreamSubscription._sendData (dart:async/stream_impl.dart:339:11)
E/flutter (22286): #11     _BufferingStreamSubscription._add (dart:async/stream_impl.dart:271:7)
E/flutter (22286): #12     _SyncStreamControllerDispatch._sendData (dart:async/stream_controller.dart:774:19)
E/flutter (22286): #13     _StreamController._add (dart:async/stream_controller.dart:648:7)
E/flutter (22286): #14     _StreamController.add (dart:async/stream_controller.dart:596:5)
E/flutter (22286): #15     _StreamSinkWrapper.add (dart:async/stream_controller.dart:867:13)
E/flutter (22286): #16     _GuaranteeSink.add (package:stream_channel/src/guarantee_channel.dart:125:12)
E/flutter (22286): #17     IsolateContactorControllerImpl.sendResult (package:isolate_contactor/src/isolate_contactor_controller/isolate_contactor_controller_stub.dart:81:22)
E/flutter (22286): #18     HostScanBloc.startSearchingDevices.<anonymous closure> (package:vernet/pages/host_scan_page/host_scna_bloc/host_scan_bloc.dart:129:17)
E/flutter (22286): <asynchronous suspension>

Link to the code vernet
Run it in dev branch and press Scan for devices.
Tried to update all packages and the flutter version but it does not work.

Found it, I have returned an object in channel.sendResult that contained future.
But the future started inside a different thread, sendResult can't send objects that contain future values.

Did you solve the issue?
I think the best way to send the result is to convert it to a JSON String and decode it back to an Object in your main app, so that you can avoid the types that Isolate doesn't allow sending.

I have just added await for each future value and it works.


Consider simplifying ChannelBuffers to only ever store one message per channel

There's a lot of complexity with having ring buffers and so forth, and they are a source of some confusion and bugs. We would benefit greatly from this being significantly simpler.
For use cases where a small ring buffer greater than 1 is appropriate, it seems like a sufficient solution is just to store all the relevant information in every message and send that.
For use cases where large amounts of information should be cached, it seems like a solution is to have the plugin do the caching and await a request.
We should see whether any plugins are making use of the ChannelBuffers control channel. If none are, that would be a good signal that we can just remove this. If some are, we should investigate what the use cases are.

cc @gaaclarke

The root problem is that engine.run() is asynchronous, and provides no mechanism to notify users when it is actually prepared to start handling messages.  If we want to simplify everything we need make engine.run() not return until the channels are setup (blocking the main thread) or provide some callback mechanism that tells us when channels are setup.  Then we could remove ChannelBuffers completely.
That change was rejected since it was a breaking change.  As long as that window of opportunity exists for dropped messages we should to have a mechanism to avoid drops, ChannelBuffers.  We can't expect everyone to come up with their own mechanism to handle faulty communication APIs.  That would be like making everyone implement their own secure transport protocol over UDP, instead of providing TCP.
The complexity is justified in this case by necessity.  The real solution to the complexity is breaking the engine APIs.

The simplification of only storing one message seems like it handles all the use cases though, without being unreliable or faulty.

Imagine this code:
void setupPlugin() {
  channel = Channel("foobar");
  db = db.load("database.db");
  for (Entry entry in db) {
    channel.sendMessage(entry.toHashMap());
  }
}

If you got the message that you were overflowing the buffer of size 1, there may be no meaningful change you could make.  You could chunk the data into one blob but on a mobile device that might get your device killed by the operating system and potentially create a less responsive app while it builds the blob.


Define separate base protocol

Questions:

Do we want to keep the LSP prefix in the base types? E.g.: LSPAny.
What should we do with the since @3.X annotations?
What other definitions regarding capabilities do we want to move over?

Great start. Here are my first thoughts:

may be we should simply call it base protocol and not tools. I start to like that name better.
we should start with base protocol version 0.9 to make clear this is under development
we should use BaseAny, .....
we should remove the since annotations
for client and server capabilities we should make examples in the base protocol, but we can't define any kind of capabilities. What we should add is a table with property names that new protocols will use in the capabilities and that LSP will not use these names top level anymore (e.g. for example a top level property testing for a testing protocol)

We would also need some good introduction why we are doing this. But that can what until we have all the parts in place.
For LSP 3.18 we should leave things how they are (naming wise) but ensure that we are structurally equal to the base definitions. In the LSP spec we say that for 3.19 or 3.20 we will move over to the base types but since the base concepts are structurally equals they can already be merged into one server.
What do you think?

BTW you know that you can compile the site locally as well using bundle exec jekyll serve

The idea is to have something like type LSPAny = BaseAny. I would not remove LSPAny totally.

BTW you know that you can compile the site locally as well using bundle exec jekyll serve

@dbaeumer yeah, and I'm using the --livereload --incremental flags for seeing the changes live without recompiling or reloading the page ;)
But also, that's the reason why I added this. To prepare my development environment I had to install Ruby, install the dependencies in the Gemfile, and I also had to add gem "webrick" to the Gemfile to successfully build the project. I couldn't find anything in this repo that went over these steps.

For LSP 3.18 we should leave things how they are (naming wise) but ensure that we are structurally equal to the base definitions.

@dbaeumer I'm not sure I understand what you mean with this. Should I then not remove the base types from the 3.18 specs and rewrite them using their existing names?

I would leave the LSP spec for 3.18 like it is and we do the base protocol as a copy from approach. Of course for the base protocol we rename the type names from LSP* to BaseProtocol*
Does that make sense?

Great work. I looked over hit and here are some things we need to discuss to decide on how to move things forward:

in the base protocol we should when possible not use examples from LSP. I think that will be confusing for people. If we can't come up with a non LSP case then we should make it explicit why we use it.
we should remove all deprecated stuff from the base protocol (e..g rootPath, ...)
since we actually send WorkspaceFolders in the intialize request we do need to add http://localhost:4000/language-server-protocol/specifications/lsp/3.18/specification/#workspace_workspaceFolders and http://localhost:4000/language-server-protocol/specifications/lsp/3.18/specification/#workspace_didChangeWorkspaceFolders to the base protocol.
we should remove all @since tags as well.
we need to add more around client & server capabilities in the base protocol. To avoid name clashes the base protocol needs to have a list of official take property names.

@dbaeumer I've replaced the LSP-specific examples by more general ones, specified the list of reserved capabilities and error codes, and merged some of the latest changes from the main branch. Let me know what you think 😄

The documentation of the initialize request has a ClientCapabilities type in the InitializeParams. I think we should define an empty ClientCapabilities best were we discuss that certain property names in the capabilities are taken by LSP.

Will do. I'll also remove the workspaceFolders property since we're not specifying workspace details here for now.

The initialize request returns a result, which basically contains the server capabilities. We should document this in the base protocol as well. See the response section here: https://microsoft.github.io/language-server-protocol/specifications/lsp/3.17/specification/#initialize

Oh, I had not noticed that I was missing the response. Good catch!

In general there are a lot of references to text documents in the register and unregister section. Since we don't have text documents in the base protocol we should think about a different example. We can also leave it quite abstract.

I think we should leave it open to the implementors to specify. After all, one of the nice things about dynamic registration is that they don't need to follow the structure from capabilities included in initialize, so I think leaving them abstract is good.


how to get mobile_sam_ecoder/decoder.onnx

In MobileSAM, there is only one weight file named mobile_sam.pt, how to get encoder and decoder weigt separately? Could you share the script for that?

Sorry, I will add relevant scripts when I have time. For now, you can refer to https://github.com/dinglufe/segment-anything-cpp-wrapper.

Have you modified the official export onnx code？when I export tensorrt，that reports a error:
Can you show me onnx version？
[04/17/2024-14:59:10] [E] [TRT] ModelImporter.cpp:768: While parsing node number 1209 [Slice -> "/Slice_2_output_0"]:
[04/17/2024-14:59:10] [E] [TRT] ModelImporter.cpp:769: --- Begin node ---
[04/17/2024-14:59:10] [E] [TRT] ModelImporter.cpp:770: input: "/Resize_output_0"
input: "/Constant_70_output_0"
input: "/Unsqueeze_19_output_0"
input: "/Constant_72_output_0"
input: "/Constant_73_output_0"
output: "/Slice_2_output_0"
name: "/Slice_2"
op_type: "Slice"
[04/17/2024-14:59:10] [E] [TRT] ModelImporter.cpp:771: --- End node ---
[04/17/2024-14:59:10] [E] [TRT] ModelImporter.cpp:774: ERROR: ModelImporter.cpp:195 In function parseGraph:
[6] Invalid Node - /Slice_2
[graphShapeAnalyzer.cpp::demandAndResolveInputTensor::1247] Error Code 4: Internal Error (orig_im_size: network input that is shape tensor must have type Int32)

my tensorrt version is 8.6.0

I convert onnx from models to tensorRT engine successfully with command:
trtexec.exe --onnx=path\mobile_sam_encoder.onnx --saveEngine=path\mobile_sam_encoder.trt

@m-wei you can have a try with these weight files.
and @zhudongwork can you add the code to get encoder/decoder onnx weights from mobile_sam.pt?
Version of TensorRT is 8.6.1, on Windows 11.

@busyyang these weight files is successful, my problem exported onnx model is from official MobileSAM library

@busyyang my question is solved, you can compile nanosam nanosam/mobile_sam/utils/onnx.py, this code don't export mask node，I guess the node has some bug

Glad to hear that. And I have a try with export_onnx_model.py to convert to onnx successfully.
MobileSAM/scripts/export_onnx_model.py --checkpoint ../weights/mobile_sam.pt --output ../weights/mobile_sam.onnx --model-type vit_t

But it is not separate encoder and decoder weights.

@busyyang nonono, this export code is only decoder model, encoder model is from https://github.com/dinglufe/segment-anything-cpp-wrapper,  this library's exported model's name is xx_preprocess.onnx，this is actually encoder model.


New App: FlightTracker

About
This app integrates with the FlightAware API, allowing users to input their FlightAware API key and track a specific flight's progress or display the recent arrivals or departures from a specified airport.
Visual
The top color bar changes based upon the flight status (onetime, delayed, cancelled, etc) - once a flight has taken off it also functions as a progress bar for the flight's completion.
The second section of information contains the departure and arrival cities and airport codes; as well as the scheduled time (or actual time) of departure or arrival (what time is displayed is determined based upon the current flight status; ie - if a flight has departed it won't show the scheduled departure; rather the actual).
The airline logos are sourced from the FlightAware library of logos that can be fetched utilizing the operator code provided by the API response.
The first marquee will change color based upon the current flight status; much like the top bar - and based upon the flight status it will display the next milestone in the flight's journey. (For instance after prior to takeoff it will show "Scheduled to Depart in x minutes", etc)
The lower marquee will display the flight number, aircraft registration and the aircraft type.

I have read the CLA Document and I hereby sign the CLA

Update on 2/23 - Saw notes on some other PRs about caching and how it is not individual to the user. Made some adjustments to account for this and correct it.

@matslina Added caching for the flight data; up to 120 seconds (if you think it should be more is there opposition to making it be a user definable cache length?), added caching for the airline images and added a resting look when an API key isn't present.

120 is probably a good TTL. I don't think there's any reason to make that configurable yet, unless it turns out to be an issue down the road.


Add a tutorial in additional materials on how to move a commit to a different branch

🐞 Problem
You might accidentally commit on the wrong branch
🎯 Goal
Make user understand how to move all the changes to a different branch.
💡 Possible solutions
Add a tutorial in additional material to address this.
📋  Steps to solve the problem

Comment below about what you've started working on.
Add, commit, push your changes
Submit a pull request and add this in comments - Addresses #<put issue number here>
Ask for a review in comments section of pull request
Celebrate your contribution to this project 🎉

I can try to help.
Writing it right now


ci: migrate to github action

migrate to github action
remove travis config and build badge

The last build was five months back and it is time to use github action for the build moving forward.
cc @michaelmhoffman

First run log is in here, https://github.com/chenrui333/gcalcli/runs/4129026742

Why was this closed? @chenrui333 opened a couple of other pull requests around this time that were also closed.


update kvdb & co

TODO: companion

thread 'tests::should_parse_extrinsic_address' panicked at 'assertion failed: `(left == right)`
  left: `Ok(Bytes([18, 52]))`,
 right: `Err("Extrinsic index missing: example \"5:0\"")`', bin/node/inspect/src/lib.rs:299:9

doesn't seem to be related to the PR

impl-serde 0.3.2 added support for deserializing without 0x prefix: https://github.com/paritytech/parity-common/pull/598. This broke the test. Should I change the test? Or this assumption is baked in other places?

impl-serde 0.3.2 added support for deserializing without 0x prefix: paritytech/parity-common#598. This broke the test. Should I change the test? Or this assumption is baked in other places?

Looks reasonable to support without leading 0x as you have done it.

bot merge


Pylint checks from ci_sanity.sh --incremental

Currently we kind of support --incremental to run incremental sanity checks. In reality, we still run it for all files:
https://github.com/tensorflow/tensorflow/blob/0e4117f67192a140466ba66513035e24bbd1a474/tensorflow/tools/ci_build/ci_sanity.sh#L137
# For incremental builds, we still check all Python files in cases there
# are function signature changes that affect unchanged Python files.

Would it make sense to just clean it up or what is the current idea?
I started to add an incremental check for since a specific commit, so one can run checks for changes across multiple commits.

Something along these lines https://github.com/lc0/tensorflow/pull/1 - just to visualize the idea

This question is better asked on StackOverflw.since it is not a bug or feature request. There is also a larger community that reads questions there. Thanks!

I mean, it's a feature for incremental CI checks :) and CI checks are used for people contributing to TensorFlow

I think your suggestion makes sense.
Could you make a PR and assign it to @yifeif


feat(client): support multi process statistical in Profile class

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

4 of 9 (44.44%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.02%) to 86.482%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

tensorbay/client/profile.py
4
9
44.44%

Totals

Change from base Build<PHONE_NUMBER>:
-0.02%

Covered Lines:
6129

Relevant Lines:
7087

💛  - Coveralls


[bug] Cannot access comment explorer

🐞 Bug report
Description
 Cannot access the code review comment explorer at all
Reproduction
 When running in remote ssh mode, adding a note works and csv is generated. However, this csv is not detected by the extension and the code review comment explorer pane does not show up at all. Not sure if this is related to running in a remove ssh environment or not. It works when used natively on a workspace on my mac without remote ssh.
Error message

🌍 Your Environment

Vscode macOS running remote ssh on linux

@girivs82 can you please send me the vscode version you are running?
code -v

Sure,
Version: 1.57.1 (Universal)
Commit: 507ce72a4466fbb27b715c3722558bb15afa9f48
Date: 2021-06-17T13:28:32.912Z
Electron: 12.0.7
Chrome: 89.0.4389.128
Node.js: 14.16.0
V8: <IP_ADDRESS>-electron.0
OS: Darwin arm64 20.5.0
For the remote ssh vscode-server running in linux, I saw this message:
[09:58:00.602] Using commit id "507ce72a4466fbb27b715c3722558bb15afa9f48" and quality "stable" for server

Not sure what happened, but all of a sudden, it started showing up from today. I tried to recall what changed from last time and the only thing I can think of is adding vscode path to .zprofile so that I can run code from command line. to be able to run code -v as you requested.
Do you think this could be the reason? In any case, I'm closing this since it's working now. Sorry for the bother.

Version: 1.59.0 (Universal)
Commit: 379476f0e13988d90fab105c5c19e7abc8b1dea8
Date: 2021-08-04T23:14:40.191Z
Electron: 13.1.7
Chrome: 91.0.4472.124
Node.js: 14.16.0
V8: 9.1.269.36-electron.0
OS: Darwin arm64 20.6.0
Shankar Giri V - Chat @ Spike	[15r2mi]
On June 24, 2021 at 18:33 GMT, Danny Koppenhagen @.***> wrote:
@.***(https://github.com/girivs82) can you please send me the vscode version you are running?
code -v
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.


Replace gitter with spectrum

Gitter is dead, long live Spectrum.
This replaces the gitter link with the spectrum link in any spot it was mentioned. I've also removed the gitter badge from the readme and added a link to spectrum to be a bit more prominent.
Requesting this to go to master bc they aren't development-related changes

Coverage remained the same at 100.0% when pulling 87ff058a9f40538c9894bdae28cdf9c449dcde58 on add-spectrum-link into 1e01ae2a795099e0735f5d5f274fa775e08f217a on master.

Good idea @gretzky.
As for merging straight to master, I guess we can just do a quick merge of master into dev before we do a merge of dev into master for our next release.


fix

Description
Enhanced the Step class and its metaclass StepMetaClass to ensure that the execute method is wrapped only once, even when inherited multiple times. Added tests to verify that the log and wrapper are called only once in such scenarios. Also, included custom metaclass examples and their respective tests.
Related Issue
N/A
Motivation and Context
It was established that (under the right conditions) our code allowed the execute method to be wrapped multiple times, even though we had code in place to prevent that. This reflected outwardly by seeing log duplication. For example like this:
Wrong output:
    [1111] [2024-11-18 14:22:18,355] [INFO] [koheesio.MyCustomGreatGrandChildStep] {__init__.py:_log_start_message:307} - Start running step
    [1111] [2024-11-18 14:22:18,355] [DEBUG] [koheesio.MyCustomGreatGrandChildStep] {__init__.py:_log_start_message:308} - Step Input: name='MyCustomGreatGrandChildStep' description='MyCustomGreatGrandChildStep' foo='foo' bar='bar' qux='qux'
    [1111] [2024-11-18 14:22:18,355] [INFO] [koheesio.MyCustomGreatGrandChildStep] {__init__.py:_log_start_message:307} - Start running step
    [1111] [2024-11-18 14:22:18,355] [DEBUG] [koheesio.MyCustomGreatGrandChildStep] {__init__.py:_log_start_message:308} - Step Input: name='MyCustomGreatGrandChildStep' description='MyCustomGreatGrandChildStep' foo='foo' bar='bar' qux='qux'
    [1111] [2024-11-18 14:22:18,355] [INFO] [koheesio.MyCustomGreatGrandChildStep] {__init__.py:_log_start_message:307} - Start running step
    [1111] [2024-11-18 14:22:18,355] [DEBUG] [koheesio.MyCustomGreatGrandChildStep] {__init__.py:_log_start_message:308} - Step Input: name='MyCustomGreatGrandChildStep' description='MyCustomGreatGrandChildStep' foo='foo' bar='bar' qux='qux'
    [1111] [2024-11-18 14:22:18,356] [DEBUG] [koheesio.MyCustomGreatGrandChildStep] {__init__.py:_log_end_message:329} - Step Output: name='MyCustomGreatGrandChildStep.Output' description='Output for MyCustomGreatGrandChildStep' baz='foobar'
    [1111] [2024-11-18 14:22:18,356] [INFO] [koheesio.MyCustomGreatGrandChildStep] {__init__.py:_log_end_message:330} - Finished running step
    [1111] [2024-11-18 14:22:18,356] [DEBUG] [koheesio.MyCustomGreatGrandChildStep] {__init__.py:_log_end_message:329} - Step Output: name='MyCustomGreatGrandChildStep.Output' description='Output for MyCustomGreatGrandChildStep' baz='foobar'
    [1111] [2024-11-18 14:22:18,356] [INFO] [koheesio.MyCustomGreatGrandChildStep] {__init__.py:_log_end_message:330} - Finished running step
    [1111] [2024-11-18 14:22:18,356] [DEBUG] [koheesio.MyCustomGreatGrandChildStep] {__init__.py:_log_end_message:329} - Step Output: name='MyCustomGreatGrandChildStep.Output' description='Output for MyCustomGreatGrandChildStep' baz='foobar'
    [1111] [2024-11-18 14:22:18,356] [INFO] [koheesio.MyCustomGreatGrandChildStep] {__init__.py:_log_end_message:330} - Finished running step

Expected output:
    [1111] [2024-11-18 14:22:18,355] [INFO] [koheesio.MyCustomGreatGrandChildStep] {__init__.py:_log_start_message:307} - Start running step
    [1111] [2024-11-18 14:22:18,355] [DEBUG] [koheesio.MyCustomGreatGrandChildStep] {__init__.py:_log_start_message:308} - Step Input: name='MyCustomGreatGrandChildStep' description='MyCustomGreatGrandChildStep' foo='foo' bar='bar' qux='qux'
    [1111] [2024-11-18 14:22:18,356] [DEBUG] [koheesio.MyCustomGreatGrandChildStep] {__init__.py:_log_end_message:329} - Step Output: name='MyCustomGreatGrandChildStep.Output' description='Output for MyCustomGreatGrandChildStep' baz='foobar'
    [1111] [2024-11-18 14:22:18,356] [INFO] [koheesio.MyCustomGreatGrandChildStep] {__init__.py:_log_end_message:330} - Finished running step

How Has This Been Tested?
Tested by adding unit tests in tests/steps/test_steps.py to verify that the execute method is wrapped only once and that the log messages are called in the correct order. The tests also cover custom metaclass functionality and ensure that the output validation and logging work as expected.
Screenshots (if appropriate):
...
Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[x] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.
[x] I have added tests to cover my changes.
[x] All new and existing tests passed.

Additional changes:

ran Ruff on the codebase
removed some unneeded print statements