Use only /data?url&name instead of /data?url&filename

For usability's sake and stability of CSV URLs people will end up trying first,

the readme should show the new /data?url&name use case
remove /data?url&filename implementation. It's nice that twbxless could do that, but in my experience it's prone to breaking as filenames change on republish. Too early in the project to worry about backward compat.

I forked the second point here to #10. We'll only update the readme for now.


SignatureDoesNotMatch for presigned URL when access key contains special character (+)

Environment info

NooBaa Version: noobaa-core-5.16.0-20240310.el8.x86_64
Platform: rhel-8

Actual behavior

Created an account, set the access key manually to abc+abc.
NOTICE - this happens when manually setting the access key, because when we generate access keys we only pick alphanumeric chars.
Used aws cli and cyberduck with that access key and secret without any issues (uses sigv4 in authentication header).
Tried to create a presigned URL with aws s3 presign s3://bucket/key but getting the URL failed with SignatureDoesNotMatch error.
Changed the access key to contain no +, and presign works too.
Tried also to get signed URL with cyberduck - the duck did not encode the + sign in the url and it messed up even before getting to the server.

Expected behavior

Either block using access keys with invalid chars, or make it work ok also for presigned URL.

Steps to reproduce

See above.

More information - Screenshots / Logs / Other output

@nimrod-becker @dannyzaken didn't we fix this already?

ok, so no we didn't handle this one yet. I was mixing it up with #7829.

@romayalon since we will probably not fix this one, lets just make sure that for now we do not allow accepting access keys with unsupported symbols from our CLI, when keys are provided as arguments and not generated.


Add code to build server & plugin to validate compilation

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 0.0%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
0

Relevant Lines:
82

💛  - Coveralls


cmd/go: go test -buildvcs=true does not include vcs information

What version of Go are you using (go version)?
go version go1.18.1 darwin/amd64
Does this issue reproduce with the latest release?
Yes
What operating system and processor architecture are you using (go env)?
go env Output
GO111MODULE="on"
GOARCH="amd64"
GOBIN="/Users/adhoc/bin"
GOCACHE="/Users/adhoc/Library/Caches/go-build"
GOENV="/Users/adhoc/Library/Application Support/go/env"
GOEXE=""
GOEXPERIMENT=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="darwin"
GOINSECURE=""
GOMODCACHE="/Users/adhoc/src/go/pkg/mod"
GONOPROXY=""
GONOSUMDB=""
GOOS="darwin"
GOPATH="/Users/adhoc/src/go"
GOPRIVATE=""
GOPROXY="https://proxy.golang.org,direct"
GOROOT="/usr/local/Cellar/go/1.18.1/libexec"
GOSUMDB="sum.golang.org"
GOTMPDIR=""
GOTOOLDIR="/usr/local/Cellar/go/1.18.1/libexec/pkg/tool/darwin_amd64"
GOVCS=""
GOVERSION="go1.18.1"
GCCGO="gccgo"
GOAMD64="v1"
AR="ar"
CC="clang"
CXX="clang++"
CGO_ENABLED="1"
GOMOD="/dev/null"
GOWORK=""
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -arch x86_64 -m64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -fdebug-prefix-map=/var/folders/p7/jc4qc9n94r3f6ylg0ssh1rq00000gs/T/go-build2620312267=/tmp/go-build -gno-record-gcc-switches -fno-common"

What did you do?
Run go test -buildvcs=true .
What did you expect to see?
Have debug.ReadBuildInfo() include vcs information.
What did you see instead?
Information was not included.
Compare https://github.com/golang/go/issues/52338, cc @bcmills

CL 393894

I agree that the VCS information should not be included by default. But if you specifically add -buildvcs=true, it should either include the information or error out. In my case, I'm testing a package that parses debug.ReadBuildInfo, which is kind of a weird thing to do, but I don't think it's so weird that the VCS information should never be includable.

I suppose that now that we have -buildvcs=auto, we could theoretically make -buildvcs=true add stamping for tests. 🤔

I'd like to see consistency in behavior across the different go tools. If go test -buildvcs=true adds stamping for tests, then go run -buildvcs=true should add stamping too.
I wouldn't want to see us end up in a scenario like this:

go build adds stamping by default (if a VCS repo is present)
go test only adds stamping if -buildvcs=true
go run never adds stamping, even if -buildvcs=true (which is where things were left on https://github.com/golang/go/issues/52338)

I think it’s fine for go test to default to omitting and go run to disallow it, but it should error out if you request an impossible option.

@gopherbot, please backport to Go 1.18. The requested -buildvcs behavior for this particular use-case was present in Go 1.18, but regressed in Go 1.18.1 as a byproduct of the fix for #51767. Now that -buildvcs=auto has been added for #51798, the Go 1.18 behavior for -buildvcs=true can be restored.

If this invalidates the test cache after every git commit, this sounds like a really bad idea to me.
What real world use case would be enabled by this behaviour?

Testing that your binary contains build information.
Most people should have it set to auto or off most of the time. What’s the problem with slow builds for people who deliberately turn it on?

With respect to backports, what's the status of this bug/fix?
#53177 (1.18 backport) is still open.

The backport is waiting on a bit of soak time. (The need for soak time is why it didn't make 1.19 as well.)


New version: Turing v0.6.21

Registering package: Turing
Repository: https://github.com/TuringLang/Turing.jl
Created by: @yebai
Version: v0.6.21
Commit: 3ee76b84186e21cefd9e10027736d9b6b30e60d2
Reviewed by: @yebai
Reference: https://github.com/TuringLang/Turing.jl/issues/863#issuecomment-514516451

0.6.20?

0.6.20?

We ran into some issues with registering versions like v0.6.10, v0.5.10 with AttoBot in the past. Maybe this is no longer an issue since AttoBot has been replaced by Registrator.
Anyway, I think it's fine to skip v0.6.20 this time..

We ran into some issues with registering versions like v0.6.10, v0.5.10 with AttoBot

What? That's weird, it definitely isn't a problem now.


Rails dependency not stated

I noticed that some parts of cocoon depends on Rails internals (on railties gem) like Rails::Generators::Base and Rails::Engine. I know cocoon is used within Rails projects so it doesn't matter, but perhaps would be nice to state this dependency in .gemfile too.

Still not solved, but also not sure if this is (still?) a problem. Closing due to inactivity.

Yep, not working on it anymore, so... but it's not fixed though, you still miss the dependency statement.


add a simple favicon

Fixes #11.

Noice
On May 11, 2015 9:16 AM, "Chris Brown"<EMAIL_ADDRESS>wrote:

[image: Favicon]
https://cloud.githubusercontent.com/assets/38814/7569540/52ce833c-f7be-11e4-9740-8a605312e641.png
Fixes #11 https://github.com/concourse/atc/issues/11.
You can view, comment on, or merge this pull request online at:
https://github.com/concourse/atc/pull/14
Commit Summary

add a simple favicon

File Changes

A web/public/favicon.ico
https://github.com/concourse/atc/pull/14/files#diff-0 (0)
M web/templates/index.html
https://github.com/concourse/atc/pull/14/files#diff-1 (1)
M web/templates/layouts/with_pipeline.html
https://github.com/concourse/atc/pull/14/files#diff-2 (1)
M web/templates/layouts/without_pipeline.html
https://github.com/concourse/atc/pull/14/files#diff-3 (1)

Patch Links:

https://github.com/concourse/atc/pull/14.patch
https://github.com/concourse/atc/pull/14.diff

—
Reply to this email directly or view it on GitHub
https://github.com/concourse/atc/pull/14.

May be cool to merge during your presentation or something. idk


Message on offline mode for non video components

https://openedx.atlassian.net/browse/MA-1814
@1zaman @bguertin plz review

:+1: Looks good.
Although, would it be better if we automatically hid this message and showed the webview when the connection is restored? I suppose we could make a separate task for that. I'm not sure what iOS does.

@bguertin I looked at how iOS works. It does the following things:

Doesn't reload the screen upon connection restore.
Shows only the offline mode screen on units that are viewable on mobile (using webview).

My commit 791148c adds both features mentioned above i.e. reload upon connection restore and show the message screen only when webview screens are applicable.

So should we update iOS to reload on network changes if they're not loaded? It's an easy change

Note that this issue also applies on video units, as their spinners is also not stopped upon loosing connectivity, nor is it reloaded automatically upon connectivity restoration. There is a temporary popup message displayed, maybe it should be converted to a persistent indicator? Not sure how exactly iOS handles this.

Note that this issue also applies on video units, as their spinners is also not stopped upon loosing connectivity, nor is it reloaded automatically upon connectivity restoration. There is a temporary popup message displayed, maybe it should be converted to a persistent indicator? Not sure how exactly iOS handles this.

:cool: This looks good to me, is this ready to merge?

is this ready to merge?

Apparently not, I am currently re-implementing it the way Ibraheem mentioned, it'll help us solve this issue as well:

@1zaman implemented as u suggested, PR is ready for another pass.

@1zaman waiting for another pass :wink:

A few small nitpicks, otherwise :+1:


Migrate to 08/07 binaries

[ ] LoggerAPI (not needed)
[x] SwiftyJSON
[x] KituraSys
[x] KituraNet
[x] Kitura
[x] HeliumLogger
[x] KituraSample
[x] CouchDB
[x] Redis
[ ] Kitura-TemplateEngine (not needed)
[x] Kitura-Session
[x] KituraCredentials
[x] KituraCredentialsHTTP
[x] KituraCredentialsGoogle
[x] KituraCredentialsFacebook
[x] Kitura-Credentials-Sample
[x] Kitura-Session-Redis
[ ] GRMustache
[ ] Kitura-MustacheTemplateEngine
[x] Kitura-Cache
[x] Kitura-Compression
[x] Kitura-CORS
[x] Kitura-CSRF
[x] Kitura-ResponseTime

As part of this migration, we should also:

Eliminate the Queue and Group classes in Kitura-sys as the libdispatch overlay on Linux is suppose to match the new one on macOS

Out of curiosity, do we have an ETA on this migration?

According to the milestone of the issue 0.28, due date is 24 August. Having said that, I have no information if the issue will be completed in this milestone.

I've noticed that there is no dependency on the swift-buildpack, which is used for pushing to bluemix. Is this an oversight?  That project, last I looked, is still sitting at 0606 swift support.

@rolivieri Could you please comment on this?

@vadimeisenbergibm @david-coyle-sjc We are in the process of updating the develop branch to support the swift 08-07 binaries. This should be completed by tomorrow. To take advantage of this, you'd need to use the cf push <url> command though. Unfortunately, it won't be installed any time soon in Bluemix (which would allow you to simply do cf push.

This looks like it may be my problem:
https://github.com/IBM-Swift/Kitura/issues/692#issuecomment-242567954
-d-
On Mon, Aug 22, 2016 at 3:36 PM, rolivieri<EMAIL_ADDRESS>wrote:

@vadimeisenbergibm https://github.com/vadimeisenbergibm @david-coyle-sjc
https://github.com/david-coyle-sjc We are in the process of updating
the develop branch to support the swift 08-07 binaries. This should be
completed by tomorrow. To take advantage of this, you'd need to use the cf
push  command though. Unfortunately, it won't be installed any time
soon in Bluemix (which would allow you to simply do cf push.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/IBM-Swift/Kitura/issues/675#issuecomment-241572496,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ALYZYJGHsYwL7p5QM--9ufAeH5zFEg1xks5qiiRzgaJpZM4Jf4nA
.

--
-dave-

We decided to move to 08/23 instead


Is GitHub link on your site is outdated?

It looks like, that link leads to some old project.

I keep docs in “authp” org.


Add NDFT for comparing different methods and speed

We need a baseline to compare the results against. For this, we need to have NDFT rightly implemented the same way, which is slow but then can help a lot in benchmarking.

Just implemented as of 25266fd


ARROW-5132: [Java] Errors on building gandiva_jni.dll on Windows with Visual Studio 2017

When building gandiva_jni.dll on Windows with Visual Studio 2017, some errors occur.

noexcept not recognized

D:/development/repository/git/arrow/cpp/src/gandiva/precompiled/../../arrow/vendored/datetime/date.h:229:81: error: expected function body after function declarator
CONSTCD11 month_weekday_last operator/(const weekday_last& wdl, int          m) NOEXCEPT;

Link error

error LNK2001: unresolved external symbol "class google::protobuf::internal::ExplicitlyConstructed<class std::basic_string<char,struct std::char_traits,class std::allocator > > google::protobuf::internal::fixed_address_empty_string"

gandiva_jni.dll not found

gandiva_jni.dll was not found inside JAR.

This PR fixes above issues.

Codecov Report

Merging #4123 into master will increase coverage by 0.73%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #4123      +/-   ##
==========================================
+ Coverage   87.91%   88.64%   +0.73%
==========================================
  Files         739      604     -135
  Lines       90980    81319    -9661
  Branches     1252        0    -1252
==========================================
- Hits        79981    72087    -7894
+ Misses      10880     9232    -1648
+ Partials      119        0     -119

Impacted Files
Coverage Δ

cpp/src/arrow/csv/column-builder.cc
95.32% <0%> (-1.76%)
:arrow_down:

cpp/src/arrow/io/readahead.cc
95.95% <0%> (-1.02%)
:arrow_down:

cpp/src/arrow/util/thread-pool-test.cc
97.66% <0%> (-0.94%)
:arrow_down:

go/arrow/math/uint64_amd64.go

go/arrow/memory/memory_avx2_amd64.go

js/src/enum.ts

go/arrow/array/builder.go

js/src/Arrow.node.ts

js/src/schema.ts

go/arrow/type_traits_boolean.go

... and 129 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4495305...83d36bf. Read the comment docs.

Thanks @masayuki038 for fixing this !


Compile-out excessive wgpu log messages statically

What problem does this solve or what need does it fill?
Wgpu logs a lot of messages at the trace level. While we filter this out at runtime, the filtering alone is very expensive from the traces we've seen.
https://github.com/bevyengine/bevy/blob/a47b91ccccd6af2802cab03c8e8c55196c2c5137/crates/bevy_log/src/lib.rs#L163
What solution would you like?
Use log's cargo features to filter out the trace logs.
E.g. log = { version = "0.4", features = ["max_level_debug", "release_max_level_warn"] }.
We can make this a bevy-level feature, so that developers wanting to see trace logs or debug logs in release mode could turn this feature off.
What alternative(s) have you considered?
Add a new feature to disable trace logs within the wgpu crate, letting us keep trace logs from our other crates. Wgpu devs are open to this idea https://github.com/gfx-rs/wgpu/pull/5804#issuecomment-2168080466.

previous discussion in https://github.com/bevyengine/bevy/pull/7223

Reading this as someone who was not aware of this before I saw the issue, this is definitely a footgun for users.
If we don't disable tracing calls by default, we should at least mention this with the same kind of prevalence we give to things like dynamic linking imo. Adding something small to the website like the following would be an improvement until there is a fix on wgpu's side:

Bevy's dependencies do a lot of trace logging that is not relevant for an end user. To improve your runtime, you should add the following to the [dependencies] section of your Cargo.toml. It will disable high log levels on compile time.
log = { version = "0.4", features = ["max_level_debug", "release_max_level_warn"] }

My preference is for more granular control here: being able to enable / disable logs from each crate separately is valuable. I'm also strongly opposed to disabling this by default: this sort of thing should be part of a "preparing for release" documentation IMO.

this sort of thing should be part of a "preparing for release" documentation IMO.

I have found this guide very useful and well explained: https://github.com/tbillington/bevy_best_practices?tab=readme-ov-file#release

Is there an alternative way to achieve the same thing? Because this fails the lint #![deny(unused_crate_dependencies)] , and there's no way to specify exceptions

For now, I disabled the unused_crate_dependencies because it doesn't have an allowlist which lets me make an exception to the log package. I'm switched to cargo-machete which has an allowlist.

Note that for Wasm builds, the same features need to be enabled for the tracing crate as Bevy does not use log there.

I did some investigation in https://github.com/gfx-rs/wgpu/issues/6046#issuecomment-2309022590 and I believe the trace logs could at least be filtered out more efficiently (when the max filter level is below trace) by passing the max level to LogTracer. This allows it set the global value that macros from the log crate short-circuit on before calling out to the installed logger:
--- a/crates/bevy_log/src/lib.rs
+++ b/crates/bevy_log/src/lib.rs
@@ -50,7 +50,7 @@ pub use bevy_utils::{
 pub use tracing_subscriber;

 use bevy_app::{App, Plugin};
-use tracing_log::LogTracer;
+use tracing_log::{AsLog, LogTracer};
 #[cfg(feature = "tracing-chrome")]
 use tracing_subscriber::fmt::{format::DefaultFields, FormattedFields};
 use tracing_subscriber::{
@@ -267,9 +267,11 @@ impl Plugin for LogPlugin {
             finished_subscriber = subscriber.with(android_tracing::AndroidLayer::default());
         }

-        let logger_already_set = LogTracer::init().is_err();
         let subscriber_already_set =
             bevy_utils::tracing::subscriber::set_global_default(finished_subscriber).is_err();
+        // This must be after setting the global tracing subscriber to get the level hint from it.
+        let max_level_filter = bevy_utils::tracing::level_filters::LevelFilter::current().as_log();
+        let logger_already_set = LogTracer::init_with_filter(max_level_filter).is_err();

         match (logger_already_set, subscriber_already_set) {
             (true, true) => error!(

(inspired by the implementation details of https://docs.rs/tracing-subscriber/0.3.18/tracing_subscriber/util/trait.SubscriberInitExt.html#method.try_init)
I looked at main_opaque_pass_3d in Tracy with the many_cubes example and didn't see much difference, but wgpu recently reduced the amount of logging so it is probably harder to observe differences here. I could also be looking at the wrong span in bevy. I tried disabling the logs at compile time with log's release_max_level_debug and saw a difference of roughly ~3%. FYI this was quick ad-hoc investigation and might not be very accurate and could contain mistakes.


Permit mocking stackable trait pattern in scala 3

Pull Request Checklist

[x] I agree to licence my contributions under the MIT licence
[x] I have added copyright headers to new files
[x] I have added tests for any changed functionality

Fixes
Fixes mocking classes that implement the stackable trait pattern (i.e. abstract override def) in scala 3

Maybe not the forum to say this, but other than https://github.com/paulbutcher/ScalaMock/pull/527 this was the only bug I hit migrating from scala 2 to scala 3, so absolutely incredible job on compatibility here.

I appreciate there's a nuance here of 'do we really want to make it impossible to mock artifact methods?'. I think they're already essentially unlockable? As it it would probably be pointless to try to use them in any mock. So I'm pretty sure that it's a legit forbid

In my opinion, we shouldn't allow mocking this.
The only thing that should be mocked is traits or abstract classes not extending anything.
But now we allowing to mock a lot of things, e.g. classes so this can be legit

I basically think not mocking it is fine, but that we have to permit mocking classes that implement it. Because otherwise the diff for me moving from scala 2 to scala 3 is over 2k likes and ain't nobody gonna review that

@goshacodes sorry for taking so long to get to this, pushed the changes -- hadn't realised it was as simple as adding a new case to the MockableDefinitions constructor, nice catch. Added a couple more tests, too.

@goshacodes @barkhorn I'm still probably a month away from this actually being a blocker, but what do you guys think about getting this in and publishing as 6.1.0 before the scala 3 pr as 7? I'm not gonna be hugely fussed about the version, or if you decide it all needs to be in the same release, or whatever, but I've been getting this migration ready on the back of a self-published fork and I'd rather just not have to explain why I'm doing that


Docker ignoring defaults file

I have a fresh XUbuntu 15.04 installation and Docker 1.9.1 installation.
I added the following line into /etc/defaults/docker:
DOCKER_OPTS="--registry-mirror=http://docker.myComp.com:5000  --insecure-registry=docker.myComp.com"
However, when pulling docker images, it tries to use https and fails.
Starting the docker daemon:
sudo docker --insecure-registry=docker.myComp.com:5000 --registry-mirror=http://docker.myComp.com -dD
Pulling images:
$ sudo docker pull docker.myComp.com/tools
Using default tag: latest
Error response from daemon: unable to ping registry endpoint https://docker.myComp.com/v0/
v2 ping attempt failed with error: Get https://docker.myComp.com/v2/: dial tcp <IP_ADDRESS>:443: connection refused
v1 ping attempt failed with error: Get https://docker.myComp.com/v1/_ping: dial tcp <IP_ADDRESS>:443: connection refused
Daemon output:
INFO[0004] POST /v1.21/images/create?fromImage=docker.myComp.com%2Ftools%3Alatest
DEBU[0004] hostDir: /etc/docker/certs.d/docker.myComp.com
DEBU[0004] hostDir: /etc/docker/certs.d/docker.myComp.com
DEBU[0004] Trying to pull docker.myComp.com/tools from https://docker.myComp.com v2
WARN[0005] Error getting v2 registry: Get https://docker.myComp.com/v2/: dial tcp <IP_ADDRESS>:443: connection refused
DEBU[0005] Trying to pull docker.myComp.com/tools from https://docker.myComp.com v1
DEBU[0005] hostDir: /etc/docker/certs.d/docker.myComp.com
DEBU[0005] attempting v2 ping for registry endpoint https://docker.myComp.com/v2/
DEBU[0006] attempting v1 ping for registry endpoint https://docker.myComp.com/v1/
DEBU[0007] Fallback from error: unable to ping registry endpoint https://docker.myComp.com/v0/
v2 ping attempt failed with error: Get https://docker.myComp.com/v2/: dial tcp 192.168..0.1:443: connection refused
v1 ping attempt failed with error: Get https://docker.myComp.com/v1/_ping: dial tcp <IP_ADDRESS>:443: connection refused
ERRO[0007] Handler for POST /v1.21/images/create returned error: unable to ping registry endpoint

Hi!
Please read this important information about creating issues.
If you are reporting a new issue, make sure that we do not have any duplicates already open. You can ensure this by searching the issue list for this repository. If there is a duplicate, please close your issue and add a comment to the existing issue instead.
If you suspect your issue is a bug, please edit your issue description to include the BUG REPORT INFORMATION shown below. If you fail to provide this information within 7 days, we cannot debug your issue and will close it. We will, however, reopen it if you later provide the information.
This is an automated, informational response.
Thank you.
For more information about reporting issues, see https://github.com/docker/docker/blob/master/CONTRIBUTING.md#reporting-other-issues

BUG REPORT INFORMATION
Use the commands below to provide key information from your environment:
docker version:
docker info:
uname -a:
Provide additional environment details (AWS, VirtualBox, physical, etc.):
List the steps to reproduce the issue:
1.
2.
3.
Describe the results you received:
Describe the results you expected:
Provide additional info you think is important:
----------END REPORT ---------
#ENEEDMOREINFO

Update: This issue is invalid. The changes had to be added to /etc/systemd/system/multi-user.target.wants/docker.service

@jakobmaier check this part of the documentation, which describes using drop-ins for configuring the docker service on systemd https://docs.docker.com/engine/articles/systemd/#custom-docker-daemon-options


Consider using @angular/service-worker and ng-pwa-tools

This project is using sw-precache instead of the latest @angular/service-worker and ng-pwa-tools.
At Google I/O last week, they announced that https://github.com/GoogleChrome/workbox would be the preferred option over sw-precache going forward.
However, Angular seems to be creating a better integrated SW and PWA story using the tools mentioned above. That said, it would be interesting to see if these tools actually reduce the size of the config and improve performance or load time.

I have the documentation in a form of workshop currently: https://bit.ly/pwa-angularsummit-2017
Will be happy to contribute

Unfortunately, there is no way to go for simplest default option to set up NGSW (to use serviceWorker: true + Angular CLI), so I'm going for ng-pwa-tools one.

@Splaktar Thank you so much for logging this, I've been meaning to set up an issue to use Angular's built in tools instead of sw-precache
@webmaxru <3 thank you!! Yep I decided to eject in order to modify the build output so we can't unfortunately rely on setting serviceWorker: true. Let me know how setting up ng-pwa-tools goes and don't hesitate to let me know if I can help in anyway.

I wrote a special notice on ng-pwa-tools compared to serviceWorker: true: https://docs.google.com/document/d/1F0e0ROaZUnTFftmC0XovpREHWHjcXa4CggiFlmifjhw/edit#heading=h.yoinubqorb1g
For now I'm struggling with ts-node part of manifest generation.

@webmaxru very helpful, thank you. There is indeed quite a bit of confusion and the presentation didn't do enough to mention how experimental ng-pwa-tools is at this point.

Agreed that is extremely helpful @webmaxru <3 Thank you for taking the time to look into the tools deeper and explaining it clearly!

@webmaxru although we can't simply use serviceWorker: true since this is ejected, could we be able to leverage AngularServiceWorkerPlugin to create a ngsw-manifest.json file on the fly with all the compiled assets? Just throwing ideas around but I think that might be a viable solution 🤔

ng-pwa-tools doesn't seem like an option for this project since it's using SCSS and that's not supported by those tools yet: https://github.com/alxhub/io17/issues/8
I haven't tried the AngularServiceWorkerPlugin for Webpack yet, but it looks promising.

I created an application using ng-PWA-tools, most of the code from @housseindjirdeh and setting up gulp to do some performance adjustments; since I didn't eject the angular-cli.
Can all of you take a look and tell me how I can improve it?
https://www.webpagetest.org/result/170710_YC_e36dbf524b1105e6a05b9c7b90d20668/
https://github.com/alfredoperez/ngx-hn
@jeffbcross

I tried to put the async and defer, but it was causing intermittent bad scores on Lighthouse.
How can I remove the pollyfills file if I am still using angular cli?
Do you have a recommendation on how should I concat all js files and update HTML after ng deploy has executed?

Any help is appreciated!
My goal is to make it faster using some of the techniques other apps used, like Firebase functions, compression, server rendering, while still keeping the angular cli intact.


docs: big flake8 docstring update

This PR may be slightly annoying, but let's try it :) This adds flake8 docstrings, (with a lax policy not forcing all public methods to be documented...) but generally imposing some structure to our docstrings).  It catches both formatting inconsistencies, as well as things like missing parameters in docstrings

may also be worth adding https://github.com/Carreau/velin ? has a pre-commit hook fwiw

tried... got some internal velin errors:
Traceback (most recent call last):
  File "/Users/talley/.cache/pre-commit/repoc0nt6co_/py_env-python3/bin/velin", line 8, in <module>
    sys.exit(main())
  File "/Users/talley/.cache/pre-commit/repoc0nt6co_/py_env-python3/lib/python3.10/site-packages/velin/ref.py", line 1074, in main
    new, _fail_check = _reformat_file(
  File "/Users/talley/.cache/pre-commit/repoc0nt6co_/py_env-python3/lib/python3.10/site-packages/velin/ref.py", line 842, in _reformat_file
    new_doc, d_, jump_to_loc, _fail_check = compute_new_doc(
  File "/Users/talley/.cache/pre-commit/repoc0nt6co_/py_env-python3/lib/python3.10/site-packages/velin/ref.py", line 723, in compute_new_doc
    params, jump_to_location, incorrect_number = parameter_fixer(
ValueError: not enough values to unpack (expected 3, got 2)

gonna skip it for now


Fix Associate link in README

The link to the description of Associate members in the README is broken. This PR updates the link.

/lgtm
/approve


SSC: Make extra fields available for field mapping

Some customers would like to be able to submit additional details to the bug tracker, like application and version name, build label and audit comments.
At the moment, there is a work-around for application and version name, but not for additional vulnerability details. It would be nice if we could add on-demand properties for all vulnerability-related information.
For application and version name, the work-around is as follows:
<bean class="com.fortify.processrunner.ssc.appversion.SSCApplicationVersionNameBasedContextGenerator">
    <property name="applicationVersionNameMappings"><map>
        <entry key=".*" value="applicationName=${project.name},versionName=${name}"/>
    </map></property>
</bean>

<bean class="com.fortify.processrunner.common.bugtracker.issue.BugTrackerFieldConfiguration">
    <property name="fields"><map>
        ...
        <entry key="application" value="${#ctx.applicationName}"/>
        <entry key="version" value="${#ctx.versionName}"/>
    </map></property>
</bean>

hi rsenden, I am sorry I am posting here. I just couldn't find your direct email anywhere. we need help in this utility. we have contacted microFocus support, and not getting help so far. our requirement is very simple, we just want to try submitting records automatically from SSC to JIRA. nothing fancy. would you be able to assist or know who can? or give us pointers on where to post questions (if you can't support). thank you very much.
Indra Tanudjaja
FRB-SF
<EMAIL_ADDRESS>

This has already been implemented, and the approach for getting application version details has been simplified.


Error building "main" branch

Trying to build from "main" branch just now and got the following error:
error: failed to run custom build command for `below v0.7.0 (/home/elijah/.local/rpmbuild/BUILD/below/below)`

Caused by:
  process didn't exit successfully: `/home/elijah/.local/rpmbuild/BUILD/below/target/release/build/below-aefe42d9920a03d1/build-script-build` (exit status: 101)
  --- stderr
  thread 'main' panicked at 'called `Result::unwrap()` on an `Err` value: Build("Failed to compile /var/tmp/.tmpCurUWB/exitstat.o from ./src/bpf/exitstat.bpf.c")', below/build.rs:38:39
  note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

Using Rust 1.70.0, Clang 11.1.0, libbpf 1.2.0 and Linux kernel 5.15.120.

below requires Clang 15 to build exitstat.bpf.c.
If you can install clang-15 you should be able to build with something like:
export CLANG=clang-15
cargo build --release

Sorry for my late answer, just now I've packaged/installed LLVM/Clang 16.0.6 and then successfully built below. Many thanks for your information.


Prevent Transferring to 0x0 and Contract Address

Prevent transferring to the 0x0 address, and the contract address, according to Token Implementation Best Practices.
Reference: https://consensys.github.io/smart-contract-best-practices/tokens/

@Muhammad-Altabba I'd ask you to also implement tests to verify the behaviour you've introduced, but first...
@skmgoldin If we added these protections (ie. prevent send to 0x0 and address(this)), I think we should do so in a child contract that inherits from EIP20.sol. What do you think?

I will be happy to implement tests to verify the behavior. And if we need to add the proposed check in a child contract I will also be happy to implement (even I prefer it to be inside the same EIP20.sol contract).
Please direct me with your recommendation and I will do the needed.
Thanks,

I feel it definitely should not be in EIP20.sol. Perhaps a different implementation called something like SafeEIP20.sol or something.

Dear @maurelian and @skmgoldin,
I added SafeEIP20.sol and changed EIP20Factory to use SafeEIP20. And I wrote JavaScript Truffle Tests for the new contract: SafeEIP20.
Please let me know if you think that more things are needed to be done or modified.
Thanks,

Hello,
Is there anything, I can help with, to speed up accepting this Pull Request?
Thanks,

Hi,
Could I help regarding this pull request?

Done. Apologies for the delay Muhammad.

No problem,
Many thanks,


Add HTTP response code to EndpointError

Is your feature request related to a problem? Please describe.
I would like to detect 401 Unauthorized when EndpointError occurs.
Describe the solution you'd like
Add HTTP response code to EndpointError.
Describe alternatives you've considered
Now I check if error.message === "expected "200 OK" response, but got 401 ", which does not seem very clean.
Additional context
Thanks!

Is the use case that you want to know if the current user did not have access to the endpoint so that you can ask him/her to login first? Or something else?

I want to inform the user that his authentication expired.

After discussing in the team, we realised that:

Throwing EndpointError in this case is a bug, we should actually throw EndpointResponseError instead
EndpointResponseError should include a code getter
We should introduce a common error superclass for all errors thrown in the client
For the purpose of handling convenience we could additionally introduce more EndpointResponseError subclasses, including something like UnauthorizedResponseError for the 401 response
Naming suggestions for better consistency are welcome


Fix disabled input styling on safari

fix disabled input styling on safari
remove safari's default outline in <Dropdown />

Before:

After:

:tada: This PR is included in version 4.8.4 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


IT MANAGEMENT

[Enter feedback here]

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: fa6fb030-d76e-69a6-a764-c7cd7665ed79
Version Independent ID: 307ff62c-f28f-4262-c812-b126799507d2
Content: Get started with Windows Server
Content Source: WindowsServerDocs/get-started/get-started-with-windows-server.md
Service: windows-server
Sub-service: getting-started
GitHub Login: @dknappettmsft
Microsoft Alias: daknappe

We hugely appreciate your contribution, feedback, and support to our technical documentation.
We’ve phased out GitHub Issues on this repository as the feedback mechanism for content and have replaced it with a new feedback system. For more information see, Content User Feedback. As part of this rollout, we are migrating your issue where our team will use your comments to improve the documentation experience. Unfortunately, this does mean you won't be able to access this issue after the migration is complete.
All issues will be migrated by Thursday 29th August 2024.
Once again, thank you for your valuable feedback, we hope you’ll continue to contribute using our new feedback system.


set aria label for inline chat button

fix #201527

closing in favor of https://github.com/microsoft/vscode/pull/202127


add string to number conversion function

Depends on #3781
[ch1619]

@rintcius because of the merge commit bb0f26a it's hard to review the individual commits because there were merge conflicts and so there are actual changes relevant to your work in that merge commit. But I can't review the diff as a whole because it's based on another PR.
I could diff your branch against the #3781 branch, but then I'd be going back and forth between that diff and this PR to make comments. So, could you closed and re-open this PR rebased against #3781 ? Or you could merge #3781 into master locally and and then base your commits on top of that. Either way is fine as long as there isn't a merge from master in the middle.
And also 735ae04 isn't necessary since it's included in #3781.

@alissapajer yeah, it's more difficult to review this PR than it should be. Closing the PR for now. I'll reopen once the dependent PRs have been reviewed and merged in


[Error]Not a supported method received from AMT device

I already finished the docker image setup(I already setup CIRA and profile in Open AMT Cloud Toolkit Sample UI) and I got error while running rpc.exe(Build RPC Manual)
C:\Users\n\Documents\open-amt-cloud-toolkit_old\rpc\build\Release>rpc.exe -u wss://<IP_ADDRESS>/activate -n -v -c '-t activate --profile i7'
RPC 1.2.0.
Protocol 4.0.0.
Skipping certificate verification.
.
**Device 03000200-0400-0500-0006-000700080009 Not a supported method received from AMT device**

Hey @imgonewild looks like you're using single quotes instead of double quotes. If you update -c to use " then you should be good.

After changing from single quote to double quote, I got another error
C:\Users\n\Documents\open-amt-cloud-toolkit_old\rpc\build\Release>rpc.exe -u wss://<IP_ADDRESS>/activate -n -v -c "-t activate --profile i7"
RPC 1.2.0.
Protocol 4.0.0.
Skipping certificate verification.
.
Exception reading from device: 03000200-0400-0500-0006-000700080009


can't access the server website

How are you running AnythingLLM?
Local development
What happened?
after build anythingllm on linux workstation, on my windows system computer can't access the website by ip:3001. the webpage is black and spinning circle. colud help me?

Are there known steps to reproduce?
No response

https://github.com/Mintplex-Labs/anything-llm/blob/master/BARE_METAL.md#run-anythingllm-in-production-without-docker

Warning
This method of deployment is not supported by the core-team and is to be used as a reference for your deployment. You are fully responsible for securing your deployment and data in this mode. Any issues experienced from bare-metal or non-containerized deployments will be not answered or supported.

The reason for this warning is that in local development there are an unlimited amount of ways and configurations you can set things up and any one of those changes could be an issue. That is why we cant really support every ticket like this, its just too much for our team.
That being said, if you are seeing the spinner it likely means that the frontend is there, but cannot talk to the backend.

Ensure when building the frontend that the .env in the frontend is set with this value

VITE_API_BASE='/api'

Then bundle the frontend and place in server/public/ and the frontend should then be looking at wherever it is hosted to serve.

Above is usually where things go wrong for most people building themselves. Otherwise, the Discord may be a better place to ask as there are more people there and ones with experience doing this and debugging in a less formal manner than on GitHub


go/types: data race in representableConst in Go 1.13 and earlier

The race in go/packages reported in #31749 was fixed at tip, but is still an issue for Go 1.13 and earlier, and is showing up in the go/packages race failure reported in #36605.
That race is caused by a race in go/types which in turn is caused by go/constant.Float64Val() calling Rat.Float64 in math/big, which has a race reported in #34919 , and subsequently fixed in tip.
Fixing this race in go/types on Go 1.13 and earlier requires backporting CL 201205 to those releases. (Alternatively, we could fix the race by adding a workaround in go/constant or go/types, but that would be more work). I'm not sure if fixing this is worth a backport but we might as well have the discussion. If we decide not to go with the backport, we'll have to accept a race in go/packages and disable some of its tests in race mode in Go 1.13 and earlier.

This data race in go/types was resolved in Go 1.14 via a fix to the math/big package in CL 201205. I'll set the appropriate milestone and close this issue, because there's nothing actionable left here to do.
This fix is being considered for backporting to Go 1.13.x in issue #36689.


Ignore Bundler 1.14.* warning messages on a non-writable home directory

In Bundler 1.14, there was a merged pull request that introduced new functionality. When running bundle if the location specified in Bundler.rubygems.user_home has a problem (e.g. does not exist, is not writable, is not a directory), it prints out a warning message to STDOUT.
You can see an example by running in bash:
# Set up gems with a real reference to wkhtmltopdf
gem install bundler --version 1.14.3
echo "source 'https://rubygems.org';\ngem 'wkhtmltopdf-binary-edge'" > Gemfile
bundle install --path vendor/bundle

# See the UI printout
HOME=/no/directory/found bundle exec which wkhtmltopdf

When run, you can see the output looks something like:
Your home directory is not set properly:
 * `/no/directory/found` is not a directory

Bundler will use `/var/folders/wj/q7cqmwds75z3ndcdxrmpd9gh0000gn/T/bundler/home/rdimarco` as your home directory temporarily

The problem is that the [output from bundle exec which wkhtmltopdf] (https://github.com/pdfkit/pdfkit/blob/master/lib/pdfkit/configuration.rb#L26) is used to determine the path to the default wkhtmltopdf executable.
So since there is the warning included in the output, the executable will not work.
This pull request is a proposal for how to ignore those warning messages so the default executable is remains correct.
NOTE: A workaround is to explicitly set the path with:
PDFKit.configure { |config| config..wkhtmltopdf = '/path/to/wkhtmltopdf'}

In our use case, we are using a gem binary, it is not ideal.
Also, if your curious why we have a read-only home directory, it happens because we have a Puma process started by upstart where the Bundler.rubygems.user_home winds up being / which the executing user does not have write access to.

@robdimarco this did not work for me because the path has a newline in it. I ended up using chomp inside the block instead. Thanks for this solution, ended up having this issue today.
`bundle exec which wkhtmltopdf`.lines.detect { |l| File.file?(l).chomp }

@willrodriguez @robdimarco
Thanks guys, was having the exact same issue and this solution worked like a charm! :+1: :+1: :+1:
bundle exec which wkhtmltopdf`.lines.detect { |l| File.file?(l.to_s.chomp) }.to_s.chomp

Check  if this helps pdfkit as well: https://github.com/bundler/bundler/pull/6550


Add  a sample test case to the test framework for Python

Add  a sample test case to the test framework for Python

Add some simple test by Dec 7 plus add instructions on how someone can run the test.

Need instructions


fix: prevent setting code data to editor when editor is non editable

This bug caused excess "onChange" call (which is important in my project) and enabled the "undo" button in read-only mode

Thank you for the your contribution!
I'll notify you after version update.


Cannot delete deployment when resources cannot be found

When you try to delete a deployment but it cannot find certain resources the deployment is not deleted.
To reproduce:
Deploy the Guestbook example:
dm deploy guestbook.yaml
Manually delete a replication controller:
kubectl delete rc frontend-rc
Now try to delete the Guestbook deployment
dm delete guestbook.yaml
This returns an error:
cannot delete configuration: kubetcl failed for resource: frontend-rc: exit status 1: Error from server: error when stopping "STDIN": replicationControllers "frontend-rc" not found
And deployment manager still contains the guestbook.yaml deployment:
dm list
includes guestbook.yaml

Since we're using kubectl instead of a RESTful API, we should go for idempotency: treat these as we would a 404 on delete and call it success.

Ideally we'd be using the API instead of kubectl so we can actually look at the response and see what the error is. Short term fix would be to parse the output and use that. If I crank up the log level higher I can actually get the API output, so in theory I could even parse that. That might be a way to get closer to using the API. I'll dig a bit deeper and figure out which way to proceed.


WebSocket Error "subprotocol is invalid" in Google Chrome

After authenticating with the OC token, the web client has the following error (and becomes unusable):
WebSocket error {"stack":"Error: Failed to construct 'WebSocket': The subprotocol 'base64url.bearer.authorization.containerjfr.bk1xMHd5Qk9fSVRiYWJ5WkktZHFHTGN0Y1ZuckdxbTNDcVJucUpnQndUUQ==' is invalid.\n at WebSocketSubject._connectSocket (webpack-internal:///194:3998:17)\n at WebSocketSubject._subscribe (webpack-internal:///194:4095:18)\n at WebSocketSubject.Observable._trySubscribe (webpack-internal:///194:1288:25)\n at WebSocketSubject.Subject._trySubscribe (webpack-internal:///194:1501:51)\n at WebSocketSubject.Observable.subscribe (webpack-internal:///194:1274:22)\n at SafeSubscriber.eval [as _next] (webpack-internal:///194:4219:22)\n at SafeSubscriber.__tryOrUnsub (webpack-internal:///194:1126:16)\n at SafeSubscriber.next (webpack-internal:///194:1064:22)\n at Subscriber._next (webpack-internal:///194:1010:26)\n at Subscriber.next (webpack-internal:///194:987:18)"}

Is this still a problem after #132 ?

I tried it and it seems to still have the problem, yes.

Huh. I just tried it with a completely plain upstream build and don't see this problem. If I intentionally provide a wrong token then nothing seems to happen at all (which should probably be addressed), so there's something strange happening in your case and I'm not sure what.

So I just tried opening it in firefox and it works, I don't know why no matter what I do it won't work on Chrome.

Ah, I do see the same thing too with Chrome.

This still seems to be happening. Any ideas of the cause?

I'll take another look.

https://bugs.chromium.org/p/chromium/issues/detail?id=398407
Looks like it might be a difference in how Chrome (well, Chromium) enforces WebSocket subprotocol contents vs. what Firefox allows. The subprotocol part may not include certain characters, however these characters may appear in a Base64 encoded auth token. When I test this with a stubbed out simple auth token test setup like in https://github.com/rh-jmc-team/container-jfr/pull/417 , I can get Chrome to successfully connect when my "auth token" is simply the string "abc123". However, deploying the exact same container image in CRC results in a failure.
btoa('abc123') => YWJjMTIz
btoa('sha256~dPZKsUqyZDjJugRI5N_hML81x9ocR1vFp2g2-4e92NI') (OpenShift/CRC auth token) => c2hhMjU2fmRQWktzVXF5WkRqSnVnUkk1Tl9oTUw4MXg5b2NSMXZGcDJnMi00ZTkyTkk= - this ends in =, which seemingly should not be permitted, according to that Chromium bug link.
The = character in base64 encoding is simply used for padding.
atob('c2hhMjU2fmRQWktzVXF5WkRqSnVnUkk1Tl9oTUw4MXg5b2NSMXZGcDJnMi00ZTkyTkk=') => sha256~dPZKsUqyZDjJugRI5N_hML81x9ocR1vFp2g2-4e92NI
and also
atob('c2hhMjU2fmRQWktzVXF5WkRqSnVnUkk1Tl9oTUw4MXg5b2NSMXZGcDJnMi00ZTkyTkk') => sha256~dPZKsUqyZDjJugRI5N_hML81x9ocR1vFp2g2-4e92NI


Failed to execute 'removeChild' on 'Node'

I'm trying to use ApexCharts inside a Preact app (using react-apexcharts and preact-compat).  Charts render fine, but I get the following error whenever chart.destroy() is called (via componentWillUnmount()):
apexcharts.js:26543 Uncaught (in promise) DOMException: Failed to execute 'removeChild' on 'Node': The node to be removed is not a child of this node.
    at window.removeResizeListener (http://localhost:3333/vendor.js:27035:49)
    at ApexCharts.destroy (http://localhost:3333/vendor.js:27756:16)
    ...

  I'm not 100% sure if this is related to Preact, but I'm assuming that if nobody else is having this problem then it must be.  To work around this and related errors I've added several guards around the element modifications in DetectElementResize.js.  It now runs without error.  I don't think these additional checks should cause any interference with regular non-Preact usage.
If you don't wish to support Preact, then fair enough, I guess I can just maintain a private fork.
FYI - I tried to make a codepen for this issue, but I couldn't work out how to use react-apexcharts within codepen (any examples?).
Type of change

[X] Bug fix (non-breaking change which fixes an issue)

Checklist:

[X] My code follows the style guidelines of this project
[X] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[X] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[X] New and existing unit tests pass locally with my changes

Thanks for creating the PR.
This part is very tricky and needs thorough testing to ensure it doesn't break anything.
I will review soon.

What is going on with this? I am seeing the same issue and this was so much time ago...

Thanks @fmflame I made the same changes to a local fork and it resolved the exact same issue for me in my Preact project including rebasing off current apexcharts.js master.
@junedchhipa I will try to find some time to throw together a test project for you.


Refactor implementation smells

Greetings!
Thanks for your effort and interest in JSQLParser.
Unfortunately I am not a big fan of this change because it makes it harder to understand the composition of the SQL since I have to jump now in between various methods.
In my understanding building SQL code is one reasonable exception from various Java Code quality measurement because in this case long spaghetti code with lots of if/else conditions are actually better to read.
Although I will leave this open a bit for collecting opinions on this.

Greetings!!
Thanks for considering my pull request and sharing your feedback.
I understand your concern about fragmenting into multiple methods,
potentially making it harder to trace the flow of SQL composition. The
intention behind my suggestion was to enhance maintainability and
scalability, especially for newcomers or when dealing with complex queries.
However, I completely agree that readability, especially in the context of
SQL parsing, is important.
Instead, I would humbly request you to have a look at this particular
commit:
https://github.com/JSQLParser/JSqlParser/pull/1982/commits/ce72d721a38106dd57c26ab9f36a7da05ede600c.
I have introduced an explaining variable to the method hashCode() making it
more readable and understandable. Please let me know your view on the same.
I can raise a separate pull request exclusively for this change.
I'm open to further discussions and ideas on how we can strike a balance
between readability and maintainability.
Thank you again for your feedback. I look forward to continuing to
contribute to the project.
Thanks and Regards
Nikita
On Fri, Mar 29, 2024 at 10:24 PM manticore-projects <
@.***> wrote:

Greetings!
Thanks for your effort and interest in JSQLParser.
Unfortunately I am not a big fan of this change because it makes it harder
to understand the composition of the SQL since I have to jump now in
between various methods.
In my understanding building SQL code is one reasonable exception from
various Java Code quality measurement because in this case long spaghetti
code with lots of if/else conditions are actually better to read.
Although I will leave this open a bit for collecting opinions on this.
—
Reply to this email directly, view it on GitHub
https://github.com/JSQLParser/JSqlParser/pull/1982#issuecomment-2027860419,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AL2IIJJE5DY4TXL6CDYVA2LY2YH4XAVCNFSM6AAAAABFPD66M6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMRXHA3DANBRHE
.
You are receiving this because you authored the thread.Message ID:
@.***>

Instead, I would humbly request you to have a look at this particular commit: ce72d72. I have introduced an explaining variable to the method hashCode() making it more readable and understandable. Please let me know your view on the same.

Apologies for being blunt: I do not see any point in this since the hash function is a kind of internal API and not used by anyone. You change is not useful or more readable but just takes more lines of code. Every IDE will generate the existing hash code for a good reason. I would be most suspicious when this presentation suddenly changed for no obvious reason.

I'm open to further discussions and ideas on how we can strike a balance between readability and maintainability.

We are riding the wrong horse here. If you really care about readability and maintainability then look at the various DDL statements like CREATE  and ALTER. Those are really a big mess and any change will be welcome because it can get only better.

Instead, I would humbly request you to have a look at this particular commit: ce72d72. I have introduced an explaining variable to the method hashCode() making it more readable and understandable. Please let me know your view on the same.

Apologies for being blunt: I do not see any point in this since the hash function is a kind of internal API and not used by anyone. You change is not useful or more readable but just takes more lines of code. Every IDE will generate the existing hash code for a good reason. I would be most suspicious when this presentation suddenly changed for no obvious reason.

I'm open to further discussions and ideas on how we can strike a balance between readability and maintainability.

We are riding the wrong horse here. If you really care about readability and maintainability then look at the various DDL statements like CREATE and ALTER. Those are really a big mess and any change will be welcome because it can get only better.

I'm working on refactoring CREATE and ALTER as well.

Closing as stale, please resubmit when work will have been finished.


Update the stacking tutorial

As expected, this tutorial was already good and ran correctly once https://github.com/Evovest/EvoTrees.jl/pull/116 was resolved.
I am running into this kind of noise when running the tutorial
WARNING: Method definition Type##kw(Any, Type{Base.MPFR.BigFloat}, Base.Irrational{:inv4π}) in module IrrationalConstants at irrationals.jl:180 overwritten in module StatsFuns on the same line (check for duplicate calls to `include`).
  ** incremental compilation may be fatally broken for this module **

but this is beyond our control and due almost certainly to https://github.com/JuliaStats/StatsFuns.jl/issues/121 .  I spent some hours messing with it. Unfortunately it likely effects several tutorials if latest pkg versions are used.

merging now, will check locally then  deploy

done and live https://juliaai.github.io/DataScienceTutorials.jl/getting-started/stacking/
the output for the nth-1 cell (10.000000000000002) is maybe a bit awkward, we could round that maybe, but it's just cosmetic


Track Releases with Sentry

https://blog.sentry.io/2019/12/17/using-github-actions-to-create-sentry-releases

Meh, not really necessary.


Feature: Add --out flag to ng lint

Use-case
In our CI we use SonarQube and the TypeScript plugin which can parse the tslint output and translate it into issues. To generate the output I want to use ng lint.
Request
Because there is no way to store the output of ng lint --format json into a valid json file it would be useful to add the --out argument and pass it to tslint.

The next release will allow you to properly redirect the output to a file.
ref: https://github.com/angular/angular-cli/pull/4917

Closing as answered. Thanks to @moritz-h for implementing it!

Awesome. Thank you!

@filipesilva @clydin @philipooo
Thanks for mentioning my fix. But this was only the easy small part I did. There is a even bigger issue for using ng lint formatted output in CI. See #4849. There I found the error source, but I don't know how it could be fixed. I just have a workaround for pmd format:
ng lint --format pmd > result.xml
tr -d '\n' < result.xml > result-fix.xml # all text in one line for sed
sed -i -e 's/<\/pmd><pmd version="tslint">//g' result-fix.xml # fix xml

Hello, which release has the --out option in? I can't seem to find it in the code.
I don't see it within the latest beta tag:
https://github.com/angular/angular-cli/blob/v1.5.0-beta.2/packages/%40angular/cli/commands/lint.ts

Thanks for the workaround, @moritz-h. I had some trouble on Windows but got it working with two commands:
ng lint --format pmd > result.xml
sed -i -r -n -e "/<pmd version=\"tslint\">/,${p}" result.xml

@LayZeeDK The problem with messed up xml is fixed long time ago. See the issue I referenced above.
The tr and sed workaround is not needed anymore, just do:
ng lint --format pmd > result.xml

This was never actually added from what I can see, please revisit this. It would be a great simplification.

It would be really great to have that "--output" option.
Right now the only possibility to store the tslint result in a file is by redirecting standard output stream to a file, but it sometimes includes the ANSI escapes (colors) in the generated file, making the file not well-formatted. Example:
ng lint wp --format checkstyle --force > ../target/tslint-result.xml
Thanks

@GregorioPerego It appears redirecting to a file is the intended way to do this.  The fix mentioned above by @moritz-h was to enable that.  If the format is non-human readable and there are illegal characters in the output then that would be a separate bug on it's own.

ng lint --format json > lint.json
The content of the file is not json as all the other log output is there.  --silent hides the json and leaves the debug output.

@rtaft I think you are encoutnering https://github.com/angular/angular-cli/issues/12674

@westonpace yes, that sounds about right, thank you


Clean up a11y failures and test warnings and add fontawesome support

actions plz

let me try that again: actions plz

actions plz

that worked!!!


Put /ws addrs in Addresses.Swarm by default

https://github.com/ipfs/go-ipfs/issues/5251

FYSA go-ipfs-config got merged into go-ipfs repo: https://github.com/ipfs/go-ipfs/tree/master/config
If you feel this PR is still relevant, please reopen as a PR against go-ipfs


Issue 2391 - Limit number of compactions to create in a single lambda invocation

Inclusion of new property for limitation compaction job capacity during single invocation
Make sure you have checked all steps below.
Issue

[ ] My PR addresses the following issues and references them in the PR title. For example, "Issue 1234 - My Sleeper
PR"

Resolves https://github.com/gchq/sleeper/issues/XXX

Tests

[ ] My PR adds the following tests OR does not need testing for this extremely good reason:

MyUnitTest

Documentation

[ ] In case of new functionality, my PR adds documentation that describes how to use it, or I have linked to a
separate issue for that below.
[ ] If I have added, removed, or updated any external dependencies used in the project, I have updated the
NOTICES file to reflect this.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

I think it's nice that the commit message links to the issue. I'd like to be able to read the message without expanding it. You can include the summary on the first line.
If we put a link to the issue in the commit message, we can consider enforcing that somehow. I've wondered if it would be worth it a few times, but there have been a lot of times when I've changed my mind about which issue a commit was related to. I wonder if it'd be best to leave it out.
It looks like the properties templates need regenerating, you can run scripts/dev/generatePropertiesTemplates.sh.
There's a Checkstyle failure, you can see the details if you download the Maven site HTML that's zipped up as an artifact in the failed workflow: https://github.com/gchq/sleeper/actions/runs/10059261154?pr=2951
You can extract the site.zip, open the index.html in the base folder, and go to Project Reports > Checkstyle.

It looks like the change to the behaviour hasn't been committed? Have you got other changes locally?


Votes in-ram

FYI: @maoueh not sure what the cause of this one, have you received this error before?
@maoueh's branch of eosio.forum
$ cleos push action eosforumdapp propose '["voter1", "eosvotetally", "EOS Vote Tally", "{\"type\": \"bps-proposal-v1\", \"content\": \"Testing EOS Vote Tally\"}"]' -p voter1@active
Error 3070002: Runtime Error Processing WASM
Error Details:
final > memory:<PHONE_NUMBER>3709551056 > 65536
pending console output:

Works with eosio.forum
$ cleos push action eosforumdapp propose '["voter1", "eosvotetally", "EOS Vote Tally", "{\"type\": \"bps-proposal-v1\", \"content\": \"Testing EOS Vote Tally\"}"]' -p voter1@active
executed transaction: 9a3d9290c47c4e80226bcb3e487f6edfc5034f79bd508dd4ed76874f08491984  192 bytes  2920 us
#  eosforumdapp <= eosforumdapp::propose        {"proposer":"voter1","proposal_name":"eosvotetally","title":"EOS Vote Tally","proposal_json":"{\"typ...
warning: transaction executed locally, but may not be confirmed by the network yet    ]

This might be be a compile issue?

@DenisCarriere Good question, no never had something like that that I can remember of. Was this over an upgraded contract?
I didn't even know it was possible to use an array for the struct values, pretty neat. I'll try to look into it to see if I can gather some information about the problem.
I compiled everything with eosio.wasmsdk, worked great on my side using a full JSON object. I'm going to try and give you more information.

@DenisCarriere The problem seems to be coming from this line:
string over_size_message = field + " should be shorter than " + std::to_string(max_size) + " bytes.";

And more specifically on the std::to_string(max_size) call.  Seems it's causing some memory corruption in the WASM runtime somehow. In looking at alternatives right now.

@DenisCarriere Fixed, I've re-write as pure macro for creating the string, this removes the allocations altogether.

Ok, I deployed the latest version of eosio.forum to the cancancan123 account on Kylin (https://tools.cryptokylin.io).
I also pushed code to eosc to propose and vote.. and you can choose your contract with --target-contract  (when on the testnet for example).
I also shipped a small eosc forum tally-votes implementation, that reports the current results of a tally. It outputs something like this:
Vote tally for proposer "eoscanadacom"'s proposal "havefunornot":
* 2 accounts voted
* 2.0000 EOS staked total
Vote value  Num accounts  EOS staked
----------  ------------  ----------
1           1             2.0000 EOS
0           1             0.0000 EOS


Topic Question should only say "unclear" if the unclear pool of documents are in it

The topic question should only say "unclear" in the part after the question that says "document says Yes/No and unclear" if the unclear pool of documents have been added to the pile of documents to be judged for that specific topic.

This will be addressed with the discussion in #19 .


Saving ipynb file corrupts the JSON format - Unexpected end of JSON input

Hi,
I've been working with vs code via SSH for quite a few years now and encountered and new bug yesterday that makes working with .ipynb files almost impossible.
What happens is - After saving the file the JSON format is corrupted and it cannot be accessed again. I need to recreate it from scratch.
There are some strange behaviors for this bug:

Often the file saving happens regardless of me saving or not.
Sometimes vs-code explicitly asks me if it's ok to save stating it needs to overwrite changes.
Looking into the JSON file with the text editor, it seems as though it simply "cuts out" the last part of the file. See example:

  {
   "cell_type": "code",
   "execution_count": null,
   "metadata": {},
   "outputs": [],
   "source": [
    "for epoch in range(num_epochs):\n",
    "    losses = []\n",
    "    for batch_images, batch_labels in tqdm(train_loader):\n",
    "        optimizer.zero_grad()\n",
    "        batch_images = batch_images.to(device).cuda().fl

*** Notice the string doesn't end properly.
I assume this has to do with the print output of the code cell (I'm using Python's tqdm library)
Does this issue occur when all extensions are disabled?: Yes/No
All extensions are active.

VS Code Version: 1.77.3
OS Version: Linux:

NAME="CentOS Stream"
VERSION="8"
ID="centos"
ID_LIKE="rhel fedora"
VERSION_ID="8"
PLATFORM_ID="platform:el8"
PRETTY_NAME="CentOS Stream 8"
ANSI_COLOR="0;31"
CPE_NAME="cpe:/o:centos:centos:8"
HOME_URL="https://centos.org/"
BUG_REPORT_URL="https://bugzilla.redhat.com/"
REDHAT_SUPPORT_PRODUCT="Red Hat Enterprise Linux 8"
REDHAT_SUPPORT_PRODUCT_VERSION="CentOS Stream"
Steps to Reproduce:

This is the cell causing the issue:

for epoch in range(num_epochs):
    losses = []
    for batch_images, batch_labels in tqdm(train_loader):
        optimizer.zero_grad()
        batch_images = batch_images.to(device).cuda().double().reshape(batch_images.shape[0], 3, 224, 224)
        output = model(batch_images)
        loss = nn.MSELoss()(batch_images, output)
        loss.backword()
        losses.append(loss.item())
        optimizer.step()
    if epoch % 1 == 0:
        print("Epoch [{}/{}], MSE Loss = {:.8}".format(epoch, num_epochs, np.mean(losses)))
    if epoch % 1 == 0:
        umap_validation(model, train_loader, device, epoch)

(Let me know if you wish me to upload the entire notebook)
2. The dataset I'm using is very large - The COCO dataset (~18GB)

Of course, I can add these lines to the JSON raw text but this is just a workaround:
               " # End of text
            ]
        }
    ]
}

@Rane90  Thanks for the detailed report, it's a critical bug and thank you for sharing with us.

Often the file saving happens regardless of me saving or not

Do you have auto save turned on?

Sometimes vs-code explicitly asks me if it's ok to save stating it needs to overwrite changes.

This usually means that there is another process attempting to modify the file, and when that happens and you attempt to save, the file on disk is newer so we will ask if you want to override.

The dataset I'm using is very large - The COCO dataset (~18GB)

This made me wonder if it's possible that the extension host crashed when we attempt to save. Is the dataset loaded into the kernel fully?

Thank you for your response.
Autosave is not turned on.
And yes, a large portion of the dataset is loaded into the kernel. I'm working on a remote server and have even been notified that I'm using too much disk space. Although it's very logical that these two are related I cannot see how to avoid this behavior.

Commenting to say I also just ran into this issue. I was attempting to save a dataset and I ran out of room in my container. After this happened, the notebook got corrupted and cut off a portion of my file that cannot be re-added.


" handle.ScheduleUpdateOnce" will make unity crash when Texture.Reinitialize()  if not executed Texture.Apply()

if (Thumbnail.TryGetValue(fileName, out var thumbnail))
                {
                    thumbnail.Reinitialize(newThumbnail.width, newThumbnail.height);
                   //if don't apply,while make unity crash and cannot find any related log
                    thumbnail.Apply();

                   var handle = ThumbnailApplyAsyncHandles.GetOrAdd(fileName, _ => new TextureApplyAsyncHandle(thumbnail));

                    thumbnail.SetPixels32(newThumbnail.GetPixels32());

                    //thumbnail.Apply();

                    //if don't Apply Texture before,will make unity crash
                    handle.ScheduleUpdateOnce();

sry about that I can't accurate description in title

Hey @CortexCore, thanks for the report.
When you reinitialize a texture, its pixel data is release and reinitialized. The TextureApplyAsyncHandle stores a pointer to the texture's pixel data, so you should Dispose of your TextureApplyAsyncHandle and create a new one after you reinitialize the texture instead of reusing it.
I don't know if there's a good way for this package to detect texture reinitialization and reinitialize itself as well 🤔 Maybe we can store and check if the data pointer changed to reinitialize the handle. Rechecking for texture reinitialization every frame for every scheduled handle seems like an unnecessary overhead to me, its quite the corner case.
Adding a TextureApplyAsyncHandle.Reinitialize method and document that it should be called whenever you reinitialize the texture is another option.
What do you think? Any suggestions?

thanks for your reply
okey, guess just figured out why the ScheduleUpdateOnce will crash unity and how avoid this situation
my wanted is new a texture like proxy first, then use TextureApplyAsyncHandle to apply it at runtime, sounds like a lazy load
so I think dispose TextureApplyAsyncHandle and new texture is not a perfect solution.
that's how I think use  TextureApplyAsyncHandle will make the "repaint" progress faster.
🤔I think add a function like TextureApplyAsyncHandle.Reinitialize or TextureApplyAsyncHandle.MarkAsDirty is a good options,
Rechecking for texture reinitialization every frame for every scheduled handle is too unnecessary like you said.

Hey @CortexCore, in the PR above I added the TextureApplyAsyncHandle.Reinitialize method that you should call after reinitializing your texture. It is in the feature/reinitialize-handle branch, if you could please test it and report if it works properly before merging, I'd appreciate it.

Your update is much appreciated, I'll test it against this time and submit a test report here : D

I just tested about Reinitialize,it's worked
but here is a new situation I used Texture2D.SetPixel32() and Texture2D.SetPixels() for copy picture
when I use Texture2D.Apply(),it's just okay

when I use TextureApplyAsyncHandle.ScheduleUpdateOnce or Texture2D.LoadRawTextureData seem like this

🤔guess this is a unity's issue,and I don't even know the keyword of error about this
Thanks for you update even quickly,I will check about why the pic color not correct

I just tested about Reinitialize,it's worked

Nice! I merged the new method then, it should be available in the next version 1.2.0.
For your new situation, maybe now that the apply is async, you're setting the pixels while the apply is running in the render thread and there's a race condition, so that the values are not fully set while apply is running. But that's just a wild guess, it's something that could be happening and that could make the updated texture look wrong.


Harbor Project Policy configuration

Hello,
Describe the solution you'd like
I would like to be able to configure project policy (retention and immutability) :

I have this todo in our backlog for this provider. I can try and prioritise this.

I have this todo in our backlog for this provider. I can try and prioritise this.


popover doesn't close?

I think Im missing something with the popover.
I have a list of links, they open in the app fine, however the popover doesnt close when i click a link.
do i need to put some sort of destroy window as a javascript helper? from the code it looks like there is supposed to be a hide / destroyed on a key up.. is key up the same as a click event?
if i click the background, the popover goes away... but i want it to go away after i make the link click

Yeah I guess I didn't consider that when porting it over. I think we can just remove this conditional: https://github.com/meteoric/meteor-ionic/blob/master/components/ionPopover/ionPopover.js#L74.

I should have read the code fully.. of course it was at the bottom :)
now that i include that "popover-backdrop" into the href element class on the template, the thing disappears on the click.. no need to change the code i dont think..
thanks for the info.

Thanks for this question, help me too !


Add setup.py for push to PyPi

Added setup.py for pushing to PyPi.
Some changes to folder structure.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: whiletruelearn sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.


Correcting missing paths for check/fix permissions.

Ignores FileNotFound exceptions when walking.
Closes #38

@sacherjj The issue with the CI is solved now.

bors merge


Upgrade to Drupal 8.9.9 (resolves SA-CORE-2020-012)

Summary of Changes

Update drupal/core to 8.9.9

Pull Request Checklist
Is Content created by the story?

[X] No
[ ] If yes, the content is:

[ ] Accessible
[ ] Mobile-friendly
[ ] Version-controlled
[ ] Governed by appropriate roles and permissions
[ ] Organized by taxonomy

Are there User-facing changes in the Drupal UI?

[X] No
[ ] If yes, then:

[ ] User documentation is updated
[ ] User training is updated

Are there Upstream Code changes?

[ ] No
[X] If yes, then:

[X] Code is complete and commented.
[X] Code is secure to the best of our knowledge and does not contain anything that cannot be on a public repo (e.g. passwords)
Is a test necessary?

[X] No
[ ] If yes, then:

[ ] Add a test if existing tests do not effectively test the code change
[ ] Test passes

[X] Pull request (PR) is mergeable with develop branch
[X] PR has a meaningful title
[X] PR has a summary of changes
[ ] PR is peer reviewed and meets team standards.
[ ] PR builds without error

Looks good.
I'm comfortable with proceeding without running selenium tests on this particular branch since we know Selenium tests passed yesterday with the other branch. I also like that we can keep core-recommended as long as we install --with-all-dependencies.


Not working for me

Says 0 verts, 0 tris.

Can you describe what you did in steps? And your setup and Unity version?


Training on custom dataset

Hello,
Thanks for the repo!
I'm trying to train GIRAFFE HD on a version of CompCar with the removed background at 256x256 resolution. Based on what I read in this other issue, I trained the model for 50k iterations on 8 GPUs with batch size 32, which should be equivalent in terms of total images. However, my generated images are not looking good. These are some examples of my last checkpoint

Do you think this is a problem with the number of iterations and I should continue training for a longer time or is something else in the training config as well?
Thanks in advance!

Hello,
Sorry for the late reply. Based on your description and the images you've provided, it seems that the results are indeed not as good as expected.
One possible problem could stem from the way you're removing the background from your dataset. If you're utilizing a binary mask for this task, it could be inadvertently providing the discriminator with a clear signal. This happens because the generator would be struggling to mimic the sharp edges created by the mask, thereby tipping the balance of the training process in favor of the discriminator.
You can confirm if this is indeed the case by monitoring the training loss. If the discriminator's loss is significantly low, it likely indicates that this is the root of the problem.

Hello,
Thank you for your response! I'll check that and try to train substituting the background generator with a constant black background.


Building new objects with Flexible extension

Hello reinterpret cat, great library.
I am colliding Ethan 3D model to the building and trying to get latlong of the corners for the same building.
If Ethan 3D model has already collided with the building, I will add a 3D cube on top of that building (as in https://github.com/reinterpretcat/utymap#flexible-extension) indicating the building’s location is already found.
On Collision of Ethan to the building, I am just getting the id of the building nothing more than that. And we need a node to use flexible extension.
So is it possible to do this?

You could try to add your collision detection script via https://github.com/reinterpretcat/utymap/blob/master/unity/demo/Assets/Scripts/Core/Plugins/GameObjectBuilder.cs::BuildFromMesh
Buildings are built in core library and they are materialized using BuildFromMesh method.
Another way is just to search for building's GameObject in scene using its id and knowing how are building names are generated.
Another way might involve search api implemented in core lib

Have you tried to store lat/lon in your custom MonoBehaviour when you're attaching it to gameobject?

What is the way to get the latlon for the buildings? Can I get it while i build the mesh in GameObjectBuilder css?

No, mesh geometry is already mapped to unity coordinates. Here you have raw geometry: https://github.com/reinterpretcat/utymap/blob/master/unity/demo/Assets/Scripts/Core/Interop/MapDataAdapter.cs

Is it possible to create custom shaped building rather than rectangular buildings with the current raw data that OSM provides??

You can change or add new implementation for that based on current building builder implementation: https://github.com/reinterpretcat/utymap/tree/master/core/src/builders/buildings

Does UtyMap provides any kind of latlong bounds to determine the centre of polygon or a building?


Add EC2 Image Builder Pipeline to create AMIs for application instances and turn servers to enhance scaling speed

Currently the Big Blue Button App and Turn Servers are installing on the fly if the ASG is scaling-out the environment (or instances are replaced)
This can take up to 45min for an instance to be ready to serve meetings.
the plan is to pre-create the AMIs and use these when scaling.
this will need an EC2 Image Builder Pipeline with components and automation docs as well as changes how and where to alter via UserData at the actual instance bootstrap.
also we need some definition for lifecycle rules and the way we do utilize the ami finder might change as well.

y all the time happening like this, now all are join herein this discussion  and fix the life plan.. unnecessary I'm suffering a lotz.


gql minimum characters restriction for consistent behavior with frontend

Lets fix merge conflicts @KatKatKateryna.
Otherwise we can merge this


manager: use leader picker only for controlapi

ping @tonistiigi @aaronlehmann
I did not try it with docker.

CI fails. Missing files?

@aaronlehmann yeah, I knew that rebase can't be so easy.

Trying the Docker integration tests with this commit.

Current coverage is 55.32% (diff: 100%)

Merging #1359 into master will not change coverage

@@             master      #1359   diff @@
==========================================
  Files            80         80
  Lines         12574      12574
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
  Hits           6957       6957
  Misses         4664       4664
  Partials        953        953

Powered by Codecov. Last update 3eaa764...ce62bb2

Closes #1354? Or should we leave the ticket open for a better solution?

@aaronlehmann let's leave it open.

@aaronlehmann added comments. Thanks!

LGTM for 1.12.1. For 1.13 we're removing the picker of course, so we'll find a better solution as we make those changes.

This seems to resolve the integration test flakiness, BTW.

Tested with docker and swarmkit. Seemed to fix the issue.


I am using Mac M1, without CUDA. How to make it work

Without cuda, in the end of training process, I got this error message. I checked online, it says because I don't have CUDA. How to avoid? thanks!
Traceback (most recent call last):
File "/Users/jingfeng/Code/ai/B-LoRA/train_dreambooth_b-lora_sdxl.py", line 2029, in
main(args)
File "/Users/jingfeng/Code/ai/B-LoRA/train_dreambooth_b-lora_sdxl.py", line 1771, in main
optimizer.step()
File "/opt/homebrew/Caskroom/miniforge/base/envs/py311/lib/python3.11/site-packages/accelerate/optimizer.py", line 170, in step
self.optimizer.step(closure)
File "/opt/homebrew/Caskroom/miniforge/base/envs/py311/lib/python3.11/site-packages/torch/optim/lr_scheduler.py", line 75, in wrapper
return wrapped(*args, **kwargs)
^^^^^^^^^^^^^^^^^^^^^^^^
File "/opt/homebrew/Caskroom/miniforge/base/envs/py311/lib/python3.11/site-packages/torch/optim/optimizer.py", line 391, in wrapper
out = func(*args, **kwargs)
^^^^^^^^^^^^^^^^^^^^^
File "/opt/homebrew/Caskroom/miniforge/base/envs/py311/lib/python3.11/site-packages/torch/utils/_contextlib.py", line 115, in decorate_context
return func(*args, **kwargs)
^^^^^^^^^^^^^^^^^^^^^
File "/opt/homebrew/Caskroom/miniforge/base/envs/py311/lib/python3.11/site-packages/bitsandbytes/optim/optimizer.py", line 263, in step
self.update_step(group, p, gindex, pindex)
File "/opt/homebrew/Caskroom/miniforge/base/envs/py311/lib/python3.11/site-packages/torch/utils/_contextlib.py", line 115, in decorate_context
return func(*args, **kwargs)
^^^^^^^^^^^^^^^^^^^^^
File "/opt/homebrew/Caskroom/miniforge/base/envs/py311/lib/python3.11/site-packages/bitsandbytes/optim/optimizer.py", line 504, in update_step
F.optimizer_update_8bit_blockwise(
File "/opt/homebrew/Caskroom/miniforge/base/envs/py311/lib/python3.11/site-packages/bitsandbytes/functional.py", line 952, in optimizer_update_8bit_blockwise
str2optimizer8bit_blockwise[optimizer_name][0](
^^^^^^^^^^^^^^^^^^^^^^^^^^^
NameError: name 'str2optimizer8bit_blockwise' is not defined
Steps:   0%|                                                                                | 0/1000 [01:31<?, ?it/s]
Traceback (most recent call last):
File "/opt/homebrew/Caskroom/miniforge/base/envs/py311/bin/accelerate", line 8, in
sys.exit(main())
^^^^^^
File "/opt/homebrew/Caskroom/miniforge/base/envs/py311/lib/python3.11/site-packages/accelerate/commands/accelerate_cli.py", line 46, in main
args.func(args)
File "/opt/homebrew/Caskroom/miniforge/base/envs/py311/lib/python3.11/site-packages/accelerate/commands/launch.py", line 1082, in launch_command
simple_launcher(args)
File "/opt/homebrew/Caskroom/miniforge/base/envs/py311/lib/python3.11/site-packages/accelerate/commands/launch.py", line 688, in simple_launcher
raise subprocess.CalledProcessError(returncode=process.returncode, cmd=cmd)
subprocess.CalledProcessError: Command '['/opt/homebrew/Caskroom/miniforge/base/envs/py311/bin/python3.11', 'train_dreambooth_b-lora_sdxl.py', '--pretrained_model_name_or_path=stabilityai/stable-diffusion-xl-base-1.0', '--instance_data_dir=/Users/jingfeng/Code/ai/B-LoRA/input', '--output_dir=output', '--instance_prompt=A [v]', '--resolution=1024', '--rank=64', '--train_batch_size=1', '--learning_rate=5e-5', '--lr_scheduler=constant', '--lr_warmup_steps=0', '--max_train_steps=1000', '--checkpointing_steps=500', '--seed=0', '--gradient_checkpointing', '--use_8bit_adam', '--mixed_precision=no']' returned non-zero exit status 1.

error message is resolved after doing this(GPT remind me to do so):
pip install bitsandbytes --upgrade
but then another error pop up:
06/02/2024 12:25:41 - INFO - main -   Total optimization steps = 1000
Steps:   0%|                                                                                | 0/1000 [00:00<?, ?it/s]Traceback (most recent call last):
File "/Users/jingfeng/Code/ai/B-LoRA/train_dreambooth_b-lora_sdxl.py", line 2029, in
main(args)
File "/Users/jingfeng/Code/ai/B-LoRA/train_dreambooth_b-lora_sdxl.py", line 1771, in main
optimizer.step()
File "/opt/homebrew/Caskroom/miniforge/base/envs/py311/lib/python3.11/site-packages/accelerate/optimizer.py", line 170, in step
self.optimizer.step(closure)
File "/opt/homebrew/Caskroom/miniforge/base/envs/py311/lib/python3.11/site-packages/torch/optim/lr_scheduler.py", line 75, in wrapper
return wrapped(*args, **kwargs)
^^^^^^^^^^^^^^^^^^^^^^^^
File "/opt/homebrew/Caskroom/miniforge/base/envs/py311/lib/python3.11/site-packages/torch/optim/optimizer.py", line 391, in wrapper
out = func(*args, **kwargs)
^^^^^^^^^^^^^^^^^^^^^
File "/opt/homebrew/Caskroom/miniforge/base/envs/py311/lib/python3.11/site-packages/torch/utils/_contextlib.py", line 115, in decorate_context
return func(*args, **kwargs)
^^^^^^^^^^^^^^^^^^^^^
File "/opt/homebrew/Caskroom/miniforge/base/envs/py311/lib/python3.11/site-packages/bitsandbytes/optim/optimizer.py", line 269, in step
self.update_step(group, p, gindex, pindex)
File "/opt/homebrew/Caskroom/miniforge/base/envs/py311/lib/python3.11/site-packages/torch/utils/_contextlib.py", line 115, in decorate_context
return func(*args, **kwargs)
^^^^^^^^^^^^^^^^^^^^^
File "/opt/homebrew/Caskroom/miniforge/base/envs/py311/lib/python3.11/site-packages/bitsandbytes/optim/optimizer.py", line 517, in update_step
F.optimizer_update_8bit_blockwise(
File "/opt/homebrew/Caskroom/miniforge/base/envs/py311/lib/python3.11/site-packages/bitsandbytes/functional.py", line 1395, in optimizer_update_8bit_blockwise
prev_device = pre_call(g.device)
^^^^^^^^^^^^^^^^^^
File "/opt/homebrew/Caskroom/miniforge/base/envs/py311/lib/python3.11/site-packages/bitsandbytes/functional.py", line 416, in pre_call
prev_device = torch.cuda.current_device()
^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/opt/homebrew/Caskroom/miniforge/base/envs/py311/lib/python3.11/site-packages/torch/cuda/init.py", line 778, in current_device
_lazy_init()
File "/opt/homebrew/Caskroom/miniforge/base/envs/py311/lib/python3.11/site-packages/torch/cuda/init.py", line 284, in _lazy_init
raise AssertionError("Torch not compiled with CUDA enabled")
AssertionError: Torch not compiled with CUDA enabled
Steps:   0%|                                                                                | 0/1000 [01:27<?, ?it/s]
Traceback (most recent call last):
File "/opt/homebrew/Caskroom/miniforge/base/envs/py311/bin/accelerate", line 8, in
sys.exit(main())
^^^^^^
File "/opt/homebrew/Caskroom/miniforge/base/envs/py311/lib/python3.11/site-packages/accelerate/commands/accelerate_cli.py", line 46, in main
args.func(args)
File "/opt/homebrew/Caskroom/miniforge/base/envs/py311/lib/python3.11/site-packages/accelerate/commands/launch.py", line 1082, in launch_command
simple_launcher(args)
File "/opt/homebrew/Caskroom/miniforge/base/envs/py311/lib/python3.11/site-packages/accelerate/commands/launch.py", line 688, in simple_launcher
raise subprocess.CalledProcessError(returncode=process.returncode, cmd=cmd)
subprocess.CalledProcessError: Command '['/opt/homebrew/Caskroom/miniforge/base/envs/py311/bin/python3.11', 'train_dreambooth_b-lora_sdxl.py', '--pretrained_model_name_or_path=stabilityai/stable-diffusion-xl-base-1.0', '--instance_data_dir=/Users/jingfeng/Code/ai/B-LoRA/input', '--output_dir=output', '--instance_prompt=A [v]', '--resolution=1024', '--rank=64', '--train_batch_size=1', '--learning_rate=5e-5', '--lr_scheduler=constant', '--lr_warmup_steps=0', '--max_train_steps=1000', '--checkpointing_steps=500', '--seed=0', '--gradient_checkpointing', '--use_8bit_adam', '--mixed_precision=no']' returned non-zero exit status 1.

I solveed this: NameError: name 'str2optimizer8bit_blockwise' is not defined
by: pip install bitsandbytes --upgrade


[Wait for #1718] [nn] Apply previous input realizer

Dependency of the PR

[Pending commit: #1718]

Commits to be reviewed in this PR
[Scaffolding] previous input realizer
This patch implements previous input realizer.
Self evaluation:

Build test: [X]Passed [ ]Failed [ ]Skipped
Run test: [X]Passed [ ]Failed [ ]Skipped

Signed-off-by: Jihoon Lee<EMAIL_ADDRESS>
[Realizer] Implement previous input realizer
This patch implement previous input realizer.
Self evaluation:

Build test: [X]Passed [ ]Failed [ ]Skipped
Run test: [X]Passed [ ]Failed [ ]Skipped

Signed-off-by: Jihoon Lee<EMAIL_ADDRESS>
[Realizer] Implement previous input realizer
This patch implement previous input realizer.
Self evaluation:

Build test: [X]Passed [ ]Failed [ ]Skipped
Run test: [X]Passed [ ]Failed [ ]Skipped

Signed-off-by: Jihoon Lee<EMAIL_ADDRESS>
[Fix] Flatten realizer to not rely on default Layer Addition
As default layer add happens before realizer, flatten layer must not
depend on the layer adding behavior.
This patch fixes flatten realizer to not depend.
Self evaluation:

Build test: [X]Passed [ ]Failed [ ]Skipped
Run test: [X]Passed [ ]Failed [ ]Skipped

Signed-off-by: Jihoon Lee<EMAIL_ADDRESS>
[nn] Apply previous input realizer
This patch applies previous input realizer.
Self evaluation:

Build test: [X]Passed [ ]Failed [ ]Skipped
Run test: [X]Passed [ ]Failed [ ]Skipped

Signed-off-by: Jihoon Lee<EMAIL_ADDRESS>

:memo: TAOS-CI Version: 1.5.20200925. Thank you for submitting PR #1720. Please a submit 1commit/1PR (one commit per one PR) policy to get comments quickly from reviewers. Your PR must pass all verificiation processes of cibot before starting a review process from reviewers. If you are new member to join this project, please read manuals in documentation folder and wiki page. In order to monitor a progress status of your PR in more detail, visit http://nnstreamer.mooo.com/.

:octocat: cibot: @zhoonit, A builder checker could not be completed because one of the checkers is not completed. In order to find out a reason, please go to http://nnstreamer.mooo.com/nntrainer/ci/repo-workers/pr-checker/1720-202111181800270.8829140663147-66061d1407a503e2245eb998159f0d3130edb9e3/.

:octocat: cibot: @zhoonit, A builder checker could not be completed because one of the checkers is not completed. In order to find out a reason, please go to http://nnstreamer.mooo.com/nntrainer/ci/repo-workers/pr-checker/1720-202111191033080.42252802848816-c1e248d81e07529cd4607c46976e2adf8e03ebfd/.


Add a CPU lowering pass

This demonstrates how triton-shared can potentially run its lowered linalg + its friends on CPU as a reference.

Notably we don't need any changes in the Triton runtime
Happily A very basic empty kernel runs, and it succeeds
Surprisingly I could not make the standard MLIR lowering passes work for triton-shared generated code (it causes SEGV).

Recently Triton updated its test suite to change the device type, so we can naturally run test_core.py on a reference CPU kernel if the problem above will be solved. Would it be something interesting?

examples.yml runs Triton code using GitHub Actions.


Add org.embulk.spi.json.JsonValue to deprecate use of msgpack-core in embulk-api

Embulk's "JSON"-type values have been represented by msgpack-java's org.msgpack.value.(Immutable)Value since Embulk v0.7. The msgpack-java has set its roots deep inside Embulk, including its plugin SPI method signatures.
It has brought a heavy dependency hell between Embulk and msgpack-java. We have hesitated even just upgrading msgpack-core which can potentially cause a compatibility issue. As a result, a couple of plugins that use msgpack-core (such as embulk-parser-msgpack) had to stay with older msgpack-core.
We upgraded msgpack-core to 0.8.24 in #1459, in the Embulk v0.10 "development" series.
However, indeed, the Embulk core has never used MessagePacker nor MessageUnpacker from msgpack-core. Embulk has used only org.msgpack.value.(Immutable)Value just as a JSON-like data container. It's nonsense!

Then, we plan to drop msgpack-core from the Embulk API/SPI in a long term. The plan would be:

We upgrade msgpack-core to v0.8.24 in Embulk v0.10.42 in the pull request #1459.
We introduce another set of classes for "JSON" type (expected to be org.embulk.spi.json.JsonValue) in v0.10.42 in this pull request #1462.

We'll keep SPI methods for both (org.msgpack.value.Value and org.embulk.spi.json.JsonValue) for a long time -- even after Embulk v1.0.
It'd be similar to "TIMESTAMP" type -- org.embulk.spi.time.Timestamp and java.time.Instant.
Plugins are expected to migrate to use org.embulk.spi.json.JsonValue through Embulk v0.11 - v1.0.

Tentatively also in Embulk v0.10.42, we modify those org.embulk.spi.json.* classes to represent their internal values by msgpack-core classes again. It will allow to keep backward-compatible API/SPI methods for a while.
We add new API/SPI methods to handle "JSON" type values with org.embulk.spi.json.Json* also in Embulk v0.10.42. In a long term, plugins will have to migrate to use the new methods, instead of msgpack-core-based methods.
At some point in the future, after Embulk v1.0, msgpack-core and API/SPI methods using msgpack-core will be removed.

We'll also write up an EEP for this.

It's corresponding EEP is underway: #1538
This pull request is just adding new classes, which does not affect any existing things yet. Ket me merge this for further work although we'll still need to discuss the design with the forthcoming EEP.
We may revert it or modify it if we get some different conclusion from the EEP discussions.

Thanks for reviewing, @hiroyuki-sato. Merging this.
(Cc: @vietnguyen-td)


Add Sherpa to autoscaler list and remove unmaintained Replicator.

Sherpa has reached 10 stars and can now be added to the scaler list
of projects. Replicator which was also owned by me is no longer
maintained and therefore should be removed.

Thanks @jrasell - Sherpa looks great :)


Execute local scripts as a part of bicep deployment

Is your feature request related to a problem? Please describe.
I would like to be able to execute scripts on the host triggering a deployment as a part of the deployment sequence. Complex deployments usually have some portions of infra that depends other infra + some data plant configuration, so some 'glue' scripts that interact with dataplanes or manipulate local data are required in order to facilitate the subsequent infrastructure steps.
While these steps can be facilitated by breaking Bicep into several stages, it requires creating multiple stages of Bicep templates with outputs (or key vault secrets), mapping those to variables in the shell scripts, and then running the shell scripts in between each Bicep stage -- that's a lot of boilerplate and fragmentation for consuming the data outputs that are immediately and readily available within the bicep templates.
Say you go ahead and do that, then you run into a bunch semi-related and frustrating issues like:

#4917
#1410
#4023
#387
#2163
#893

Tangent: And even if you work around/solve all that, you might be tempted to use a common parameters file to ensure existing resources from prior stages can be referenced exactly without having to declare a parameter file for each bicep stage and risk making a typo - except that cannot be done because parameters must exactly match the bicep file - the parameters file cannot contain extraneous parameters that are not declared in a bicep file. So at this point you look loading JSON but it seems insane to completely circumvent the native parameter functionality.
Terraform handles this neatly with local-exec to provide script execution inline with IaC declarations and to be able to consume available resource properties directly. Some use cases I've bumped into in the past that local-exec helped with:

Calling external APIs using output from the deployed infra (e.g. often by pulling a connection string from a newly deployed resource).
Similarly; if a solution is hosted in Azure but leverages some 3rd party services unmanaged by ARM, local-exec can bootstrap those resources managed externally by calling a CLI or HTTP API
Generating PAT tokens in DataBricks after a cluster is deployed

Describe the solution you'd like
I'd like a resource type that executes a local script similar to local-exec:

Executes a script or binary on the host running the deployment
Resource dependencies are evaluated to kick off the script at the right time (i.e. I might want to run the script after deploying a new Key Vault, and pass an output like the new Key Vault's resource ID to the script)
Other resources can depend on the local script resource, and will wait until it has executed

Note that such a feature might also require something similar to a null_resource.

Duplicate of #417, but going to close that one as this is a bit more detailed

+1

It seems it'll take more time - has anyone found workaround for this? I'm converting Terraform to Bicep and this is one big missing part

Just for context, Bicep/ARM Template deployments are evaluated service-side today, so there is no physical way to do something like TF's local-exec which is a client-side operation. In theory, we can transition to running the deployments engine locally, but we are not close to being able to do that.
In the meantime, the only workaround is either to break your deployment into different parts and run your scripts locally in between deployments, or you can use a deploymentScript resource which will run the script service side.

@alex-frankel - thanks for providing some workarounds.
Deployment scripts are problematic when it comes to accessing resources that are running in a VNET because the container instance (in which the PS script is ultimately executed) can't be placed within the VNET.
The same thing has been discussed in #6540  - would you have some pointers to that?

I would follow #6450 for any updates. We have been working on adding support for it recently, so I'm hoping we have an update in the next 2-3 months.

Any updates on this?

@cw-andrews - in the short term, we don't have a way to enable this because Bicep/ARM Templates are evaluated service side. See: https://github.com/Azure/bicep/issues/7259#issuecomment-1230529105

/reopen

What is the author feedback required?

I think that label was stale. Thanks for bumping the thread.

+1 use-case ->  trying to provide devs a single az deployment group create to create, build & deploy an Azure Container Apps app.  All resources provisioned by bicep fine, ACA uses bicep as its deployment api, to that's great.  But unfortunately, couldn't get a bicep ACR build tasks to work, couldn't get deploymentScripts to access my locally cloned repo.  So now I need to give devs a script or set of commands, to (1) provision Infra (2) run the az acr build, then (3) run the bicep to deploy the container app.  Really want to reduce friction where possible

@stewartadam  I wonder if this will be satisfied by #14243.
The spec doesn't seem to be publicly released as yet so I'm not sure what the goal/implementation is, but looks very interesting!
One of my questions for local-deploy is are you going to have to choose between normal server-side deploy at run time? Basically, will you have to create specific local templates?