Attempt to build apm fails : oniguruma.js (?)

Description
My latest attempts to build Atom are progressing, but are still being halted, now on the phase to build apm. It is throwing the following compiler warnings and errors at the build of oniguruma libraries.
Steps to Reproduce

./script/build

Behavior:
Node:	v16.13.2
Python:	v2.7.18
Installing script dependencies
Installing apm
(node:72759) [DEP0150] DeprecationWarning: Setting process.config is deprecated. In the future the property will be read-only.
(Use `node --trace-deprecation ...` to show where the warning was created)
../deps/onig/regcomp.c:563:3: warning: cast to smaller integer type 'unsigned int' from 'OnigUChar *' (aka 'unsigned char *') [-Wpointer-to-int-cast]
  GET_ALIGNMENT_PAD_SIZE(p, pad_size);
  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../deps/onig/regint.h:234:19: note: expanded from macro 'GET_ALIGNMENT_PAD_SIZE'
               - ((unsigned int )(addr) % WORD_ALIGNMENT_SIZE);\
                  ^~~~~~~~~~~~~~~~~~~~~
../deps/onig/regexec.c:1672:2: warning: cast to smaller integer type 'unsigned int' from 'OnigUChar *' (aka 'unsigned char *') [-Wpointer-to-int-cast]
        ALIGNMENT_RIGHT(q);
        ^~~~~~~~~~~~~~~~~~
../deps/onig/regint.h:240:14: note: expanded from macro 'ALIGNMENT_RIGHT'
  (addr) -= ((unsigned int )(addr) % WORD_ALIGNMENT_SIZE);\
             ^~~~~~~~~~~~~~~~~~~~~
../deps/onig/regexec.c:1737:2: warning: cast to smaller integer type 'unsigned int' from 'OnigUChar *' (aka 'unsigned char *') [-Wpointer-to-int-cast]
        ALIGNMENT_RIGHT(q);
        ^~~~~~~~~~~~~~~~~~
../deps/onig/regint.h:240:14: note: expanded from macro 'ALIGNMENT_RIGHT'
  (addr) -= ((unsigned int )(addr) % WORD_ALIGNMENT_SIZE);\
             ^~~~~~~~~~~~~~~~~~~~~
2 warnings generated.
1 warning generated.
In file included from ../src/onig-scanner-worker.cc:1:
In file included from ../src/onig-scanner-worker.h:7:
In file included from ../../nan/nan.h:56:
In file included from /Users/alines7777/Library/Caches/node-gyp/16.13.2/include/node/node.h:63:
In file included from /Users/alines7777/Library/Caches/node-gyp/16.13.2/include/node/v8.h:30:
/Users/alines7777/Library/Caches/node-gyp/16.13.2/include/node/v8-internal.h:492:38: error: no template named 'remove_cv_t' in namespace 'std'; did you mean 'remove_cv'?
            !std::is_same<Data, std::remove_cv_t<T>>::value>::Perform(data);
                                ~~~~~^~~~~~~~~~~
                                     remove_cv
/Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/usr/include/c++/v1/type_traits:710:50: note: 'remove_cv' declared here
template <class _Tp> struct _LIBCPP_TEMPLATE_VIS remove_cv
                                                 ^
In file included from ../src/onig-string.cc:1:
In file included from ../src/onig-string.h:6:
In file included from ../../nan/nan.h:56:
In file included from /Users/alines7777/Library/Caches/node-gyp/16.13.2/include/node/node.h:63:
In file included from /Users/alines7777/Library/Caches/node-gyp/16.13.2/include/node/v8.h:30:
/Users/alines7777/Library/Caches/node-gyp/16.13.2/include/node/v8-internal.h:492:38: error: no template named 'remove_cv_t' in namespace 'std'; did you mean 'remove_cv'?
            !std::is_same<Data, std::remove_cv_t<T>>::value>::Perform(data);
                                ~~~~~^~~~~~~~~~~
                                     remove_cv
/Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/usr/include/c++/v1/type_traits:710:50: note: 'remove_cv' declared here
template <class _Tp> struct _LIBCPP_TEMPLATE_VIS remove_cv
                                                 ^
In file included from ../src/onig-reg-exp.cc:1:
In file included from ../src/onig-reg-exp.h:7:
In file included from ../src/onig-result.h:4:
In file included from ../../nan/nan.h:56:
In file included from /Users/alines7777/Library/Caches/node-gyp/16.13.2/include/node/node.h:63:
In file included from /Users/alines7777/Library/Caches/node-gyp/16.13.2/include/node/v8.h:30:
/Users/alines7777/Library/Caches/node-gyp/16.13.2/include/node/v8-internal.h:492:38: error: no template named 'remove_cv_t' in namespace 'std'; did you mean 'remove_cv'?
            !std::is_same<Data, std::remove_cv_t<T>>::value>::Perform(data);
                                ~~~~~^~~~~~~~~~~
                                     remove_cv
/Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/usr/include/c++/v1/type_traits:710:50: note: 'remove_cv' declared here
template <class _Tp> struct _LIBCPP_TEMPLATE_VIS remove_cv
                                                 ^
In file included from ../src/onig-result.cc:1:
In file included from ../src/onig-result.h:4:
In file included from ../../nan/nan.h:56:
In file included from /Users/alines7777/Library/Caches/node-gyp/16.13.2/include/node/node.h:63:
In file included from /Users/alines7777/Library/Caches/node-gyp/16.13.2/include/node/v8.h:30:
/Users/alines7777/Library/Caches/node-gyp/16.13.2/include/node/v8-internal.h:492:38: error: no template named 'remove_cv_t' in namespace 'std'; did you mean 'remove_cv'?
            !std::is_same<Data, std::remove_cv_t<T>>::value>::Perform(data);
                                ~~~~~^~~~~~~~~~~
                                     remove_cv
/Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/usr/include/c++/v1/type_traits:710:50: note: 'remove_cv' declared here
template <class _Tp> struct _LIBCPP_TEMPLATE_VIS remove_cv
                                                 ^
In file included from ../src/onig-searcher.cc:1:
In file included from ../src/onig-searcher.h:5:
In file included from ../src/onig-string.h:6:
In file included from ../../nan/nan.h:56:
In file included from /Users/alines7777/Library/Caches/node-gyp/16.13.2/include/node/node.h:63:
In file included from /Users/alines7777/Library/Caches/node-gyp/16.13.2/include/node/v8.h:30:
/Users/alines7777/Library/Caches/node-gyp/16.13.2/include/node/v8-internal.h:492:38: error: no template named 'remove_cv_t' in namespace 'std'; did you mean 'remove_cv'?
            !std::is_same<Data, std::remove_cv_t<T>>::value>::Perform(data);
                                ~~~~~^~~~~~~~~~~
                                     remove_cv
/Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/usr/include/c++/v1/type_traits:710:50: note: 'remove_cv' declared here
template <class _Tp> struct _LIBCPP_TEMPLATE_VIS remove_cv
                                                 ^
In file included from ../src/onig-scanner.cc:1:
In file included from ../src/onig-scanner.h:4:
In file included from ../../nan/nan.h:56:
In file included from /Users/alines7777/Library/Caches/node-gyp/16.13.2/include/node/node.h:63:
In file included from /Users/alines7777/Library/Caches/node-gyp/16.13.2/include/node/v8.h:30:
/Users/alines7777/Library/Caches/node-gyp/16.13.2/include/node/v8-internal.h:492:38: error: no template named 'remove_cv_t' in namespace 'std'; did you mean 'remove_cv'?
            !std::is_same<Data, std::remove_cv_t<T>>::value>::Perform(data);
                                ~~~~~^~~~~~~~~~~
                                     remove_cv
/Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/usr/include/c++/v1/type_traits:710:50: note: 'remove_cv' declared here
template <class _Tp> struct _LIBCPP_TEMPLATE_VIS remove_cv
                                                 ^
1 error generated.
make: *** [Release/obj.target/onig_scanner/src/onig-result.o] Error 1
make: *** Waiting for unfinished jobs....
1 error generated.
make: *** [Release/obj.target/onig_scanner/src/onig-string.o] Error 1
1 error generated.
make: *** [Release/obj.target/onig_scanner/src/onig-scanner-worker.o] Error 1
1 error generated.
make: *** [Release/obj.target/onig_scanner/src/onig-reg-exp.o] Error 1
1 error generated.
make: *** [Release/obj.target/onig_scanner/src/onig-searcher.o] Error 1
1 error generated.
make: *** [Release/obj.target/onig_scanner/src/onig-scanner.o] Error 1
gyp ERR! build error
gyp ERR! stack Error: `make` failed with exit code: 2
gyp ERR! stack     at ChildProcess.onExit (/Users/alines7777/Git/atom/script/node_modules/npm/node_modules/node-gyp/lib/build.js:194:23)
gyp ERR! stack     at ChildProcess.emit (node:events:390:28)
gyp ERR! stack     at Process.ChildProcess._handle.onexit (node:internal/child_process:290:12)
gyp ERR! System Darwin 21.3.0
gyp ERR! command "/usr/local/bin/node" "/Users/alines7777/Git/atom/script/node_modules/npm/node_modules/node-gyp/bin/node-gyp.js" "rebuild"
gyp ERR! cwd /Users/alines7777/Git/atom/apm/node_modules/atom-package-manager/node_modules/oniguruma
gyp ERR! node -v v16.13.2
gyp ERR! node-gyp -v v5.1.0
gyp ERR! not ok
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR<EMAIL_ADDRESS>install: `node-gyp rebuild`
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>install script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR!      /Users/alines7777/.npm/_logs/2022-02-10T15_33_02_392Z-debug.log
node:child_process:867
    throw err;
    ^

Error: Command failed: /Users/alines7777/Git/atom/script/node_modules/.bin/npm --global-style --loglevel=error install
(node:72759) [DEP0150] DeprecationWarning: Setting process.config is deprecated. In the future the property will be read-only.
(Use `node --trace-deprecation ...` to show where the warning was created)
../deps/onig/regcomp.c:563:3: warning: cast to smaller integer type 'unsigned int' from 'OnigUChar *' (aka 'unsigned char *') [-Wpointer-to-int-cast]
  GET_ALIGNMENT_PAD_SIZE(p, pad_size);
  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../deps/onig/regint.h:234:19: note: expanded from macro 'GET_ALIGNMENT_PAD_SIZE'
               - ((unsigned int )(addr) % WORD_ALIGNMENT_SIZE);\
                  ^~~~~~~~~~~~~~~~~~~~~
../deps/onig/regexec.c:1672:2: warning: cast to smaller integer type 'unsigned int' from 'OnigUChar *' (aka 'unsigned char *') [-Wpointer-to-int-cast]
        ALIGNMENT_RIGHT(q);
        ^~~~~~~~~~~~~~~~~~
../deps/onig/regint.h:240:14: note: expanded from macro 'ALIGNMENT_RIGHT'
  (addr) -= ((unsigned int )(addr) % WORD_ALIGNMENT_SIZE);\
             ^~~~~~~~~~~~~~~~~~~~~
../deps/onig/regexec.c:1737:2: warning: cast to smaller integer type 'unsigned int' from 'OnigUChar *' (aka 'unsigned char *') [-Wpointer-to-int-cast]
        ALIGNMENT_RIGHT(q);
        ^~~~~~~~~~~~~~~~~~
../deps/onig/regint.h:240:14: note: expanded from macro 'ALIGNMENT_RIGHT'
  (addr) -= ((unsigned int )(addr) % WORD_ALIGNMENT_SIZE);\
             ^~~~~~~~~~~~~~~~~~~~~
2 warnings generated.
1 warning generated.
In file included from ../src/onig-scanner-worker.cc:1:
In file included from ../src/onig-scanner-worker.h:7:
In file included from ../../nan/nan.h:56:
In file included from /Users/alines7777/Library/Caches/node-gyp/16.13.2/include/node/node.h:63:
In file included from /Users/alines7777/Library/Caches/node-gyp/16.13.2/include/node/v8.h:30:
/Users/alines7777/Library/Caches/node-gyp/16.13.2/include/node/v8-internal.h:492:38: error: no template named 'remove_cv_t' in namespace 'std'; did you mean 'remove_cv'?
            !std::is_same<Data, std::remove_cv_t<T>>::value>::Perform(data);
                                ~~~~~^~~~~~~~~~~
                                     remove_cv
/Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/usr/include/c++/v1/type_traits:710:50: note: 'remove_cv' declared here
template <class _Tp> struct _LIBCPP_TEMPLATE_VIS remove_cv
                                                 ^
In file included from ../src/onig-string.cc:1:
In file included from ../src/onig-string.h:6:
In file included from ../../nan/nan.h:56:
In file included from /Users/alines7777/Library/Caches/node-gyp/16.13.2/include/node/node.h:63:
In file included from /Users/alines7777/Library/Caches/node-gyp/16.13.2/include/node/v8.h:30:
/Users/alines7777/Library/Caches/node-gyp/16.13.2/include/node/v8-internal.h:492:38: error: no template named 'remove_cv_t' in namespace 'std'; did you mean 'remove_cv'?
            !std::is_same<Data, std::remove_cv_t<T>>::value>::Perform(data);
                                ~~~~~^~~~~~~~~~~
                                     remove_cv
/Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/usr/include/c++/v1/type_traits:710:50: note: 'remove_cv' declared here
template <class _Tp> struct _LIBCPP_TEMPLATE_VIS remove_cv
                                                 ^
In file included from ../src/onig-reg-exp.cc:1:
In file included from ../src/onig-reg-exp.h:7:
In file included from ../src/onig-result.h:4:
In file included from ../../nan/nan.h:56:
In file included from /Users/alines7777/Library/Caches/node-gyp/16.13.2/include/node/node.h:63:
In file included from /Users/alines7777/Library/Caches/node-gyp/16.13.2/include/node/v8.h:30:
/Users/alines7777/Library/Caches/node-gyp/16.13.2/include/node/v8-internal.h:492:38: error: no template named 'remove_cv_t' in namespace 'std'; did you mean 'remove_cv'?
            !std::is_same<Data, std::remove_cv_t<T>>::value>::Perform(data);
                                ~~~~~^~~~~~~~~~~
                                     remove_cv
/Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/usr/include/c++/v1/type_traits:710:50: note: 'remove_cv' declared here
template <class _Tp> struct _LIBCPP_TEMPLATE_VIS remove_cv
                                                 ^
In file included from ../src/onig-result.cc:1:
In file included from ../src/onig-result.h:4:
In file included from ../../nan/nan.h:56:
In file included from /Users/alines7777/Library/Caches/node-gyp/16.13.2/include/node/node.h:63:
In file included from /Users/alines7777/Library/Caches/node-gyp/16.13.2/include/node/v8.h:30:
/Users/alines7777/Library/Caches/node-gyp/16.13.2/include/node/v8-internal.h:492:38: error: no template named 'remove_cv_t' in namespace 'std'; did you mean 'remove_cv'?
            !std::is_same<Data, std::remove_cv_t<T>>::value>::Perform(data);
                                ~~~~~^~~~~~~~~~~
                                     remove_cv
/Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/usr/include/c++/v1/type_traits:710:50: note: 'remove_cv' declared here
template <class _Tp> struct _LIBCPP_TEMPLATE_VIS remove_cv
                                                 ^
In file included from ../src/onig-searcher.cc:1:
In file included from ../src/onig-searcher.h:5:
In file included from ../src/onig-string.h:6:
In file included from ../../nan/nan.h:56:
In file included from /Users/alines7777/Library/Caches/node-gyp/16.13.2/include/node/node.h:63:
In file included from /Users/alines7777/Library/Caches/node-gyp/16.13.2/include/node/v8.h:30:
/Users/alines7777/Library/Caches/node-gyp/16.13.2/include/node/v8-internal.h:492:38: error: no template named 'remove_cv_t' in namespace 'std'; did you mean 'remove_cv'?
            !std::is_same<Data, std::remove_cv_t<T>>::value>::Perform(data);
                                ~~~~~^~~~~~~~~~~
                                     remove_cv
/Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/usr/include/c++/v1/type_traits:710:50: note: 'remove_cv' declared here
template <class _Tp> struct _LIBCPP_TEMPLATE_VIS remove_cv
                                                 ^
In file included from ../src/onig-scanner.cc:1:
In file included from ../src/onig-scanner.h:4:
In file included from ../../nan/nan.h:56:
In file included from /Users/alines7777/Library/Caches/node-gyp/16.13.2/include/node/node.h:63:
In file included from /Users/alines7777/Library/Caches/node-gyp/16.13.2/include/node/v8.h:30:
/Users/alines7777/Library/Caches/node-gyp/16.13.2/include/node/v8-internal.h:492:38: error: no template named 'remove_cv_t' in namespace 'std'; did you mean 'remove_cv'?
            !std::is_same<Data, std::remove_cv_t<T>>::value>::Perform(data);
                                ~~~~~^~~~~~~~~~~
                                     remove_cv
/Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/usr/include/c++/v1/type_traits:710:50: note: 'remove_cv' declared here
template <class _Tp> struct _LIBCPP_TEMPLATE_VIS remove_cv
                                                 ^
1 error generated.
make: *** [Release/obj.target/onig_scanner/src/onig-result.o] Error 1
make: *** Waiting for unfinished jobs....
1 error generated.
make: *** [Release/obj.target/onig_scanner/src/onig-string.o] Error 1
1 error generated.
make: *** [Release/obj.target/onig_scanner/src/onig-scanner-worker.o] Error 1
1 error generated.
make: *** [Release/obj.target/onig_scanner/src/onig-reg-exp.o] Error 1
1 error generated.
make: *** [Release/obj.target/onig_scanner/src/onig-searcher.o] Error 1
1 error generated.
make: *** [Release/obj.target/onig_scanner/src/onig-scanner.o] Error 1
gyp ERR! build error
gyp ERR! stack Error: `make` failed with exit code: 2
gyp ERR! stack     at ChildProcess.onExit (/Users/alines7777/Git/atom/script/node_modules/npm/node_modules/node-gyp/lib/build.js:194:23)
gyp ERR! stack     at ChildProcess.emit (node:events:390:28)
gyp ERR! stack     at Process.ChildProcess._handle.onexit (node:internal/child_process:290:12)
gyp ERR! System Darwin 21.3.0
gyp ERR! command "/usr/local/bin/node" "/Users/alines7777/Git/atom/script/node_modules/npm/node_modules/node-gyp/bin/node-gyp.js" "rebuild"
gyp ERR! cwd /Users/alines7777/Git/atom/apm/node_modules/atom-package-manager/node_modules/oniguruma
gyp ERR! node -v v16.13.2
gyp ERR! node-gyp -v v5.1.0
gyp ERR! not ok
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR<EMAIL_ADDRESS>install: `node-gyp rebuild`
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>install script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR!       I’m assuming it’s a similar root problem as node-sass in nodejs/node#38367 based on the mentions of std::remove_cv_t.

Oniguruma fixed this in atom/node-oniguruma#112, released in v7.2.3. Working up the dependency chain, apm bumped their dependency in v2.6.5, the most recent release. I have confirmed that updating the version in atom/apm/package.json to 2.6.5 seems to allow apm to be successfully installed with npm v8.3.0, but it does not seem to be installable with the included v6.14.16 that the bootstrap scripts use. I believe that is caused by NodeJS 16 increasing the minimum npm compatibility requirement to v7.x.x, as described on StackOverflow. The published version of atom uses NodeJS 12.14.1, making all of this a non-issue.

If anyone else encounters this issue, I’ve found the following workaround.
Install Node 12 using nvm, and install Python 2.7 using pyenv. Enable both, then bootstrap Atom.
This dependency on Python 2 definitely feels like something that should be addressed, although my Python 3 version was 3.9. I wasn't able to use pyenv to install Python 3.7, which is listed as a supported version of node-gyp v5.1.0 that is used by the dependencies of atom.
This is still encountering the apm package install error #25417, but that is a separate issue unrelated to this problem.


Correct style warnings from clang-tidy for rabit.

This PR corrects most of the style warnings from tidy.  Other warnings will be addressed in a different PR.

thread local is removed.

@trivialfis How did you run clang-tidy? We should modify CI to run clang-tidy for Rabit as well.

@hcho3  I modified the tests/ci_build/tidy.py script.  There are other more serious warnings like zero division and null pointer dereference so I can't make it run on CI yet.

Codecov Report

Merging #6095 into master will increase coverage by 0.09%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #6095      +/-   ##
==========================================
+ Coverage   78.52%   78.62%   +0.09%
==========================================
  Files          12       12
  Lines        3069     3069
==========================================
+ Hits         2410     2413       +3
+ Misses        659      656       -3

Impacted Files
Coverage Δ

python-package/xgboost/tracker.py
95.18% <0.00%> (+1.20%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 68c55a3...fff3260. Read the comment docs.


Unblocking does not work if the passed value is in a variable

This is something that I came across in a more complex environment and almost got me thinking that I must be crazy so I tried to reproduce this issue with almost no libraries at all.
As you can see in your demo site, when someone uses window.yett.unblock like this:
window.yett.unblock('/mypattern/');
everything works without an issue.
Same goes if you enter an array of previously blacklisted items:
window.yett.unblock(['/mypattern1/', '/mypattern2/');
However, when I try to pass the arguments through a variable, it does not work.
I have setup a very basic html page that demonstrates what I'm trying to say. Please check it here:
http://yett.mashup.gr/
Note that inputArr and anotherArr have the exact same initial assignment.
Also, if you execute the unblock function directly from Chrome's console like so:  unblockScript([ /testme\.js/ ]); it works without issues. The problem is when the input to the unblock function does not come as a literal but as a variable.

Hi @b33rd33r,

Also, if you execute the unblock function directly from Chrome's console like so: unblockScript([ /testme\.js/ ]); it works without issues. The problem is when the input to the unblock function does not come as a literal but as a variable.

Actually when I try that on the Chrome console it does not work:

I think your issues comes from the fact that you are trying to pass an array of Regexp to the unblock function. But the unblock function expects an array of strings.

I have updated the page to use the exact same template with your demo site and the array is now declared as an array of strings, not regexes. Still not working.

@b33rd33r Can you try replacing:
var unblockArray = [ '/inline\.js$/' ];
with:
var unblockArray = [ 'inline.js' ];

That works, thanks a lot!
Question: since I'm using a variable that contains an array of regexes that comes from the backend to block the scripts and I want to selectively enable them based on the user's choice, is there a way to use the same regexes that I'm using for blacklisting in order to do the unblocking?
If the regex that comes from the backend is simple enough, I can maybe create a "somewhat equivalent" text (e.g. in inline\.js I can maybe keep the inline part) but if we're talking about a regex like: (?<=[^<]+?)<[^>]+? it can't be done. What would maybe help if using the regexes is not possible, to have like a method that I could call on window.yett to get a list of the scripts that were blocked so that I can match the regex against them and figure out which one is which.

That works, thanks a lot!

Glad to hear that! 😉

Question: since I'm using a variable that contains an array of regexes that comes from the backend to block the scripts and I want to selectively enable them based on the user's choice, is there a way to use the same regexes that I'm using for blacklisting in order to do the unblocking?

Not right now, but I just added a commit that enables passing regexes to the unblock function. It should help with your use case.
With the change, if the .toString() representation of both RegExp is equal then it will be removed from the blacklist (or for people using the whitelist - it will be added to the list).
I'm currently waiting for the tests to pass, then I'll release a new version (if everything is fine in a few minutes).

@b33rd33r Just published 0.1.8, that should solve the issue.
Feel free to reopen if there is any problem with the feature!


Wrong priority order of multiple configs in bootstrap mode

When using Spring Cloud Config, the priority order of multiple configs is as follow: (both import mode and bootstrap mode)
1. configserver:foo-dev.yml
2. configserver:application-dev.yml
3. configserver:foo.yml
4. configserver:application.yml

and Spring Cloud Zookeeper Config take a similar order when using spring.config.import
1. zookeeper:config/foo,dev
2. zookeeper:config/application,dev
3. zookeeper:config/foo
4. zookeeper:config/application

BUT when using bootstrap mode, the client load configs in a strange priority order:
1. zookeeper:config/foo,dev
2. zookeeper:config/foo
3. zookeeper:config/application,dev
4. zookeeper:config/application

this can be confirmed by using /actuator/env api.

I've made a PR #303 on this.

Closing in favor of #303


cannot import name 'FigmaFileLoader'

System Info
langchain==0.0.189
os:windows11
python=3.10.11
Who can help?
No response
Information

[X] The official example notebooks/scripts
[ ] My own modified scripts

Related Components

[ ] LLMs/Chat Models
[ ] Embedding Models
[ ] Prompts / Prompt Templates / Prompt Selectors
[ ] Output Parsers
[X] Document Loaders
[ ] Vector Stores / Retrievers
[ ] Memory
[ ] Agents / Agent Executors
[ ] Tools / Toolkits
[ ] Chains
[ ] Callbacks/Tracing
[ ] Async

Reproduction
from langchain.document_loaders import FigmaFileLoader
Expected behavior
expected:
load the module
error:
ImportError: cannot import name 'FigmaFileLoader' from 'langchain.document_loaders' (C:\Users\xxx\AppData\Local\miniconda3\envs\xxx\lib\site-packages\langchain\document_loaders_init_.py)
comments:
checked the langchain\document_loaders_init_.py and there is no reference to FigmaFileLoader

The issue is arising due to an incorrect import statement.
In the LangChain library, the FigmaFileLoader is not directly under langchain.document_loaders.
It is inside a submodule named figma within document_loaders.
You can refer to the file in the repository here .
So, instead of:
from langchain.document_loaders import FigmaFileLoader
You should use:
from langchain.document_loaders.figma import FigmaFileLoader

There is a missed import in the document_loaders/__init_.py file. I will fix it.


Visualize uninstrumented services in the dependency diagrams

Which problem is this PR solving?

Closes #3804

Description of the changes

Updated GetDependencies to identify and include client spans without corresponding server spans, ensuring a complete dependency graph.
Implemented updateServiceDependencyLinks to streamline the update of service dependencies, reducing code duplication.
Enabled the representation of uninstrumented services in the dependency graph by inferring names from client spans lacking server spans.

How was this change tested?

Introduced TestInferredServiceDependency to specifically evaluate the functionality of inferred service dependencies in the scenario of uninstrumented services.
Created a client span without a corresponding server span and asserted the correct formation of dependencies, ensuring the inclusion of inferred services in the dependency graph.
Employed assertions to confirm the presence and accuracy of inferred service dependencies, ensuring they are adequately represented with the correct attributes and relationships.

Checklist

[x] I have read https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md
[x] I have signed all commits
[x] I have added unit tests for the new functionality
[x] I have run lint and test steps successfully

for jaeger: make lint test
for jaeger-ui: yarn lint and yarn test

Ref PR: https://github.com/jaegertracing/jaeger/issues/3804

+1, we are awaiting this feature.
Currently the deep dependency graph is not showing the relationship with the databases and other non-instrumented services, for the given service.

This is a dupe of #4853 which, as you can see, was a very long conversation. This PR is a 10 line change. It's very frustrating for the maintainers who need to spend a ton of time fixing such a small issue. I spoke to the author as well and explained this decision we are making. The decision is that this will not be merged as it would need to be rebased and once again create a lot of work for the team. Sorry.


Write to ApplicationChoice#rejection_reasons type field

Context
We're changing the reasons on the R4R form, this will result in a different serialized JSON structure.
We're adding a rejection_reasons_type field to ApplicationChoice so that we can easily query the format of the rejection data.

Changes proposed in this pull request

Adds an enum to ApplicationChoice which contains the various rejection reasons types.
Writes to ApplicationChoice#rejection_reasons_type from the 2 rejection services.
Backfills existing rejected applications with the relevant type value.

Guidance to review

Link to Trello card
https://trello.com/c/IP91rE34/4830-sr4r-redesign-add-sr4r-type-field-to-applicationchoices

Things to check

[x] If the code removes any existing feature flags, a data migration has also been added to delete the entry from the database
[x] This code does not rely on migrations in the same Pull Request
[x] If this code includes a migration adding or changing columns, it also backfills existing records for consistency
[x] API release notes have been updated if necessary
[x] Required environment variables have been updated added to the Azure KeyVault

@cwrw Have separated write / backfill commits. A few tests also needed fixing.


python311Packages.influxdb3-python: init at 0.3.6

Description of changes
Python module that provides a simple and convenient way to interact with InfluxDB 3.0
https://github.com/InfluxCommunity/influxdb3-python

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Result of nixpkgs-review pr 291431 run on x86_64-linux 1

2 packages failed to build:

python312Packages.influxdb3-python
python312Packages.influxdb3-python.dist

2 packages built:

python311Packages.influxdb3-python
python311Packages.influxdb3-python.dist

Result of nixpkgs-review pr 291431 run on x86_64-linux 1

4 packages built:

python311Packages.influxdb3-python
python311Packages.influxdb3-python.dist
python312Packages.influxdb3-python
python312Packages.influxdb3-python.dist


Update code.mdx

Changelog
Removed

Type classes part was duplicated in line 55 above, so I deleted it

@miedzikd Looks like you need to sign the DCO before we can merge this.

I have read the DCO document and I hereby sign the DCO.


Websocket changes sync with latest version 2.4

This is to merge websocket changes done here NetrisTV/scrcpy to the latest version of Genymobile/scrcpy i.e 2.4 in order to support android 15
Need thorough testing as it is not tested yet fully.

Not for this repo I guess.


chore(deps): bump

Applied mkpr on undefined
/tmp/mkpr.sh

:tada: This PR is included in version 2.0.142 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Safer stratified names: phantom type?

A large source of errors is mixing up names from different stratification levels.
For example, Streams, Reduces & Exps in Core are all different levels, so an Expression cannot refer directly to a stream just by name.
Similarly for Avalanche, Accumulators are separate from Expression names.
The problem is, all these different names have the same type: (Name n).
This makes it very easy to accidentally return an accumulator name in the set of free expression variables.
I wonder whether it's worth adding a phantom type to make this stuff harder to mix up. It doesn't have to be perfect - explicit casting is fine and probably necessary, but just by making it explicit would be a huge win.
data EXP
data ACC
data STR
data RED

data Name n ty = Name n …

explicitCast :: Name n t -> Name n u

and expressions, core programs, statements etc would change:
data Statement n p
 = Read (Name n EXP) (Name n ACC)
 | Write (Name n ACC) (Exp n p)

This should be a matter of just making the change at Name (Icicle/Common/Base) and then following the compilation errors.

I'm not sure about this any more: it seems like a good idea, but I'm worried that it will complicate the already-complicated conversion from Icicle to Core.

I'm now convinced that this will complicate conversion too much


Can you add a custom shell command to the options?

So we can execute a custom shell command in the folder of a project.
For example you could combine multiple commands like "bundler && pod install" or maybe even commands we can't think of right now... It could be open a custom application, send a notification, create a git tag, etc etc .

Thank you! It is in mine todo list!
how do you see the way of adding custom shell command to the list? Plus button and then a new window with a text field?

Yeah, I would imagine an entry in the settings menu to add an option to create a 'command'.
That could show a crud interface for adding/removing commands which would then become available in the menu's of each project.

in version 1.5 this ability is added


PP-129 OPDS 2 with acquisition links

This PR should be reviewed in tandem with the Feed Refactor PR.
Description
Acquisition links for the OPDS 2 feeds as per the De Marque document.
This PR also adds the ability for certain feeds to be served as either XML or JSON based on the requests content-type.
This PR was also used to complete the OPDS2 serializer which was left out of #1308 .
Example
      {
          "href": "http://localhost:6500/VT0014/works/Overdrive%20ID/0e20dfec-501f-4b5d-926f-dd712aa39160/borrow",
          "rel": "http://opds-spec.org/acquisition/borrow",
          "type": "application/atom+xml;type=entry;profile=opds-catalog",
          "properties": {
            "availability": {
              "state": "available"
            },
            "indirectAcquisition": [
              {
                "type": "application/vnd.adobe.adept+xml",
                "child": [
                  {
                    "type": "application/pdf"
                  }
                ]
              },
              {
                "type": "application/vnd.overdrive.circulation.api+json;profile=ebook"
              },
              {
                "type": "application/atom+xml;type=entry;profile=opds-catalog",
                "child": [
                  {
                    "type": "text/html;profile=\"http://librarysimplified.org/terms/profiles/streaming-media\""
                  }
                ]
              }
            ]
          }
        }

Missing
The authenticate property has not been added, since we are currently providing the authentication document link as part of the feed links. Wasn't sure is we wanted to change that behaviour.

Motivation and Context
JIRA-129 and JIRA-78

How Has This Been Tested?
Manually checked

Checklist

[ ] I have updated the documentation accordingly.
[ ] All new and existing tests passed.

@RishiDiwanTT The first thing I was trying to do with this PR is to load the OPDS2 version of the feed in my test environment to see what the serialized OPDS2 looks like. Can you give me some pointers how I can get an OPDS2 response?

Currently only the /loans, /borrow and /feed APIs are activated for opds2.
They can be seen by adding a content type : application/opds+json header to
the GET request.
On Thu, Aug 31, 2023, 01:25 Jonathan Green @.***> wrote:

@RishiDiwanTT https://github.com/RishiDiwanTT The first thing I was
trying to do with this PR is to load the OPDS2 version of the feed in my
test environment to see what the serialized OPDS2 looks like. Can you give
me some pointers how I can get an OPDS2 response?
—
Reply to this email directly, view it on GitHub
https://github.com/ThePalaceProject/circulation/pull/1340#issuecomment-1699752755,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AVRR5S3WGRNDI7PBTLAFOEDXX6LEBANCNFSM6AAAAAA33ODQWQ
.
You are receiving this because you were mentioned.Message ID:
@.***>

Typically the content-type header indicates the type of the data included in the request. I'd expect to do content negotiation like this via an accept header included on the request, which would cause the content-type header to be included in the response.

That makes sense, and is a very small change.
On Thu, Aug 31, 2023, 06:48 Jonathan Green @.***> wrote:

Typically the content-type header
https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Content-Type
indicates the type of the data included in the request. I'd expect to do
content negotiation like this via an accept header
https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Accept
included on the request, which would cause the content-type header to be
included in the response.
—
Reply to this email directly, view it on GitHub
https://github.com/ThePalaceProject/circulation/pull/1340#issuecomment-1700171820,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AVRR5SZ5JLBVRK2LM4JD3FTXX7Q4RANCNFSM6AAAAAA33ODQWQ
.
You are receiving this because you were mentioned.Message ID:
@.***>

Okay. So I pointed this branch at an existing DB with some books in it, and then I ran the resulting OPDS2 feed through our OPDS2 validator /bin/opds2_schema_validate and our feed is failing our own validation. So i think we need to get that sorted out to start with.

Okay. So I pointed this branch at an existing DB with some books in it, and then I ran the resulting OPDS2 feed through our OPDS2 validator /bin/opds2_schema_validate and our feed is failing our own validation. So i think we need to get that sorted out to start with.

This ended up being trivial, changes required were 2

Use the "Accept" header instead of the "Content-Type" header
The "audience" scheme should be an URL always

Apart from that the actual validator code was broken, I guess somewhere along the way the OPDSImporter code changed a bit and the validator did not reflect those changes.

From the comment on #1308:

jonathangreen Aug 30, 2023
Can we rename the package (directory) for this code as well? Right now its feed_protocol, I'd suggest feed.

RishiDiwanTT Sep 1, 2023
This will cause all kinds of unpleasantness while rebasing with https://github.com/ThePalaceProject/circulation/pull/1340 . I will do this once that PR has been merged with this.

Moving this to a comment here so we don't forget the package needs to be renamed.

From the comment on #1308:

jonathangreen Aug 30, 2023
Can we rename the package (directory) for this code as well? Right now its feed_protocol, I'd suggest feed.

RishiDiwanTT Sep 1, 2023
This will cause all kinds of unpleasantness while rebasing with #1340 . I will do this once that PR has been merged with this.

Moving this to a comment here so we don't forget the package needs to be renamed.

Do we have anymore feedback for this PR or should I merge it into the refactor branch?

@RishiDiwanTT I'm taking another look over this PR now. I'll post a comment once I'm done.


The library name isn't good

Please comment below with any suggestions.
Suggestions so far:

Pixel
Particular
Elemental

spoonful
flake
grain
wafer

Kiba-UI


How to use multiple tags in metadata filtering

Issue you'd like to raise.
I am using below chain. I want to use multiple categories in the filters. My logic is to bring the results from category=c1 OR category=c2 OR category=c3. How can we modify below code the achieve the objective
chain = ConversationalRetrievalChain.from_llm(OpenAI(temperature=0),  retriever= vectorstore.as_retriever(search_kwargs={'filter': {'category':category}}), memory=memory, return_source_documents = True)
Suggestion:
No response

qa = ConversationalRetrievalChain.from_llm(AzureChatOpenAI(             deployment_name="gpt-4", model_name="gpt-4", temperature=0), vectorstore.as_retriever(search_kwargs={'filter': {'file_id': "aef3a936-26db-11ee-b209-44e517a137fd"}}))
Tried this approach but it is going to the whole vectors in vector-db rather than the particular one with the id.

@samanta-souhardya This might be late, but I'll try to answer your question. Langchain uses Document objects as its main currency of data. Document objects have a page_content attribute and metadata attribute. Thus, you can manually create a document (as opposed to the methods of creating them from files as discussed in the documentation) by doing:
doc = Document(page_content="Some string", metadata={"some_key": "some_val"}

For example, for metadata, I usually like to do metadata = {"source": "name_of_text_file_from_which_content_came"}. Then, the filter parameter searches through metadata tags not vector database IDs, which is what I think you were assuming the filter parameter achieves.

@samanta-souhardya This might be late, but I'll try to answer your question. Langchain uses Document objects as its main currency of data. Document objects have a page_content attribute and metadata attribute. Thus, you can manually create a document (as opposed to the methods of creating them from files as discussed in the documentation) by doing:
doc = Document(page_content="Some string", metadata={"some_key": "some_val"}

For example, for metadata, I usually like to do metadata = {"source": "name_of_text_file_from_which_content_came"}. Then, the filter parameter searches through metadata tags not vector database IDs, which is what I think you were assuming the filter parameter achieves.

Hi, @chancharikmitra , Can you elaborate more on how to search filtered by the metadata with the vectorstore.as_retriever?

@pai4451 Your code is almost correct. Your filter argument is automatically looking through the metadata attribute. So all you would need is:
db.as_retriever(
 search_kwargs = {"filter": {"source": "name_of_text_file_from_which_content_came"}}
)

Another identical way to do it without creating a separate retriever is as follows:
vectordb = FAISS.from_documents(documents=texts, embedding=embeddings)
sim_docs = vectordb.similarity_search(question_text, filter={'source': ['general', 'logistics', 'payroll']}, k=3)

I purposefully did an example that returns three relevant documents searching through multiple different tags. You would pass them as a list like above if you wanted the vectordb to look through multiple metadata tags. Note: This only seems to work for LangcChain's FAISS implementation and not Chroma.
Hope this answers your question as well as the main question posed in this thread. I discovered this missing feature on Chroma when trying this myself. Use FAISS instead if you want to search using multiple metadata tags and pass them as a list.

@chancharikmitra Thanks for your guidance. I am using Milvus as a vector store and I find that I can pass the expr argument to perform a hybrid search (filtered vector search.)


fix istioctl analyze deployment analyzer ignoring service namespaces

This PR is to fix https://github.com/istio/istio/issues/34830
To help us figure out who should review this PR, please put an X in all the areas that this PR affects.

[ ] Configuration Infrastructure
[ ] Docs
[ ] Installation
[ ] Networking
[ ] Performance and Scalability
[ ] Policies and Telemetry
[ ] Security
[ ] Test and Release
[x] User Experience
[ ] Developer Infrastructure

Please check any characteristics that apply to this pull request.

[ ] Does not have any user-facing changes. This may include CLI changes, API changes, behavior changes, performance improvements, etc.

@monsteredc: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Rerun command

release-notes_istio
5c0fee7ba83d5495d123c860201526bac8605b20
link
/test release-notes_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@monsteredc: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Rerun command

lint_istio
978d6fbc359c95c032b7d50c29af2249008a9031
link
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@monsteredc: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Rerun command

lint_istio
978d6fbc359c95c032b7d50c29af2249008a9031
link
/test lint_istio

gencheck_istio
978d6fbc359c95c032b7d50c29af2249008a9031
link
/test gencheck_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@monsteredc: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
6ed805fbf0b67bbaec1dc6e5773fd4cf6b42a9fe
link
/test unit-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test unit-tests_istio


Idea about killing a lot of boring work you shoud read this

I have a trouble.
Imagine that you need to draw a circle animation, when inside the circle have 4 sticks, they all perpendicular and moves clockwise, and it needs 80 frames to make one full clockwise move.

But what if you want that: when all 4 lines becomes horizontal and vertical straight, on the left side becomes one red line, and then, when sticks becomes straight again, on the left side becomes another line, and when you have 4 lines and sticks becomes straight, all four red lines are go away?
Broke this animation into two different animations.
First is the circle animation. It have 20 frames for one cycle.
Second is the red lines animation. It have 100 or 5 frames for one cycle.
So, you can’t make it easy in Piskel. You need to draw all frames by your hands. You can’t automatically synchronize two this animations. You need to redraw circle animation 5 times and also draw red lines animation without mistakes. It is pretty hard.
So I find a solution. Maybe not best solution, idk.
If you can add animations into another animations, this trouble goes away. I see it like this.
You have a workspace, where you can add any animations. And you can change all those animations differently, not in one animation.  But, I still need to draw 100 frames for the lines. And solution here is the different framerate, or speed. When I can regulate speed of any different animation, I can, for example, draw only 5 frames in “Red lines” animation and 20 frames in “Circle_1” animation, set “Circle_1” speed by 20 fps and “Red lines” speed by 1 fps, and then when “Red lines” animation takes (5 frames / 1 fps =)5  seconds for one cycle, one cycle of “Circle_1” animation takes only (20 frames / 20 fps =)1 second, so then my animations are synchronized without redrawing and I solve my trouble with two different animations.
On servers your animation saves like setup of workplace, but when you convert animation into gif, png or zip, it renders like one animation or picture (or pictures if you export in zip).
I think, this would be very useful and cool, because with this feature users can draw more hard, complex things a lot more easier.
If I interested you or you want to connect with me, here’s my mail:
<EMAIL_ADDRESS>(sorry, I haven’t Twitter and Facebook)
Skype: i3axapka_rock_god
My name is Zhdanov Zakhar, I’m 17 years old.
(if you broke your tonque when you tried to read my name , don’t try again, just name me like Zak or something like that :) )
P.S. I haven’t American social apps because I’m from Russia. And, by this way, sorry for all my mistakes in English, if they have (I’m SURE they have), I am not very good at English.
P.S.S. Also, I’M HOPE THAT ANY POLITICAL THINGS ISN’T STAND ON THE WAY OF OUR CHAT. (if that can be named “chat”)
(png's with trouble and workplace)

I also have some cool ideas and can say it, if you're interested :)

I'm not a proger, i can't help you to write the code or something like this
Lol nowadays i'm only learning Pascal.ABCNET in school haha :DD
But i see idea and hope that you are opened to this


Feature/win condition

Game loop is complete! Winners and losers are notified when a player reaches the end of the board, and the host can return everyone to their respective profile pages. All game variables reset and a new game can begin.

Hooray!


No result when I run the demo

I have download the faster_rcnn_r50_fpn_1x_coco_20200130-047c8118.pth and run the demo.py like this:
python demo/image_demo.py demo/demo.jpg configs/faster_rcnn/faster_rcnn_r50_fpn_1x_coco.py faster_rcnn_r50_fpn_1x_coco_20200130-047c8118.pth
and return a image without any bboxes on it.
Then I try another pth: faster_rcnn_r50_fpn_1x_20181010-3d1b3351.pth and meet the same problem.

The result in the inference.py is array[]

The result[0] in the inference.py is {ndarray:(0,5)}

the result[0] in the inference.py is {ndarray:(0, 5)} []

Hi @freehome1 ,
I just tried your command, with the same checkpoint and the same config, I got the expected image with box results on it.
Do you modify anything in the code? Or could you use the newest mmdet and try again?

Since the newest code does not have this problem. This issue is closed. Feel free to reopen it if you have any further questions.


Fixed: Issue with point region doesn't work in Firefox

Motivation and context
This one is probably browser issue, not CVAT.
If width or height of a SVG rectangle are 0, than getBBox() returns all 0 (even for x1, x2 which are actually not 0 according to current element attributes). Chrome works correct in this case, Firefox doesn't. Workaround-ed.
Resolved #2633
How has this been tested?
Manual testing
Checklist

[x] I submit my changes into the develop branch
[x] I have added description of my changes into CHANGELOG file
[ ] I have updated the documentation accordingly
[ ] I have added tests to cover my changes
[x] I have linked related issues (read github docs)
[x] I have increased versions of npm packages if it is necessary (cvat-canvas,
cvat-core, cvat-data and cvat-ui)

License

[x] I submit my code changes under the same MIT License that covers the project.
Feel free to contact the maintainers if that's a concern.
[x] I have updated the license header for each file (see an example below)

# Copyright (C) 2021 Intel Corporation
#
# SPDX-License-Identifier: MIT

Hi @dvkruchinin , do we have tests that creates issue by one tab on the canvas?

Coverage remained the same at 70.274% when pulling 9b533ebe58c4711263e40c3e7554feda32f2e9bc on bs/fixed_issue_2633 into 30678f9726166f953ad289bb57e194895f566ba0 on develop.

Coverage remained the same at 70.274% when pulling 9b533ebe58c4711263e40c3e7554feda32f2e9bc on bs/fixed_issue_2633 into 30678f9726166f953ad289bb57e194895f566ba0 on develop.

Hi @bsekachev

do we have tests that creates issue by one tab on the canvas?

Yes, there is a test tests\cypress\integration\actions_users\issue_2524_issue_not_reset_after_change_task.js. I will add the issue creation as a point to it.

Hi @bsekachev

do we have tests that creates issue by one tab on the canvas?

Yes, there is a test tests\cypress\integration\actions_users\issue_2524_issue_not_reset_after_change_task.js. I will add the issue creation as a point to it.


Add features matrix to the README

List most popular features/benefits of Pion WebRTC.
Resolves #1279
Co-authored-by: ZHENK<EMAIL_ADDRESS>

Would really love peoples opinion on this? Did I miss anything important? Any points I make do you think don't matter?

@albrow @backkem @adwpc @AeroNotix @Antonito @ashellunts @at-wat @audiolion @baiyufei @billylindeman @bshi @cgojin @cloudwebrtc @cryptix @decanus @enobufs @epes @hugoArregui @jeremija @jech @leewardbound @lherman-cs @masterada @maxhawkins @mission-liao @OrlandoCo @r-novel @rviscarra @RyanGordon @saljam @scorpionknifes @seppo0010 @sgotti @steebchen @TannerGabriel @tarrencev @tekig @thinkski @trivigy @wdouglass
Would this have improved/detracted from your first opinion of using Pion? I have gotten a lot of feedback that people have no idea what pion/webrtc contains so wanted to bring this to the top.

https://github.com/pion/webrtc/blob/eef6045bb0203f0223f809cf0187571297b6adf6/README.md is a link directly to the file to see it formatted.

Would have changed anything for me. WebRTC is a fairly complex tech stack and usually requires decent know how. By the time I was using it full force I already knew what is inside.

Definitely good improvement of README!

I like this!
My two cents: the pion/webrtc dependencies under the pion/ organization sometimes miss the details on why are they exist. For example, when I was starting out exploring pion and its libraries, I noticed the READMEs of pion/rtp, pion/rtcp and pion/srtp all looked the same, with no additional context about what each of these libraries was about.
On the other hand, the pion/dtls library has a nice list with features at the top of the README.

Looks good to me!

It seems like a great improvement!

Love this change 🙌

With all due respect, Sean, I think the "feature matrix" is overselling Pion.  It might raise people's expectations too much, and then cause them to turn away from Pion when they realise that we've been overselling.
I recommend marking Simulcast and SVC as "work in progress".  I don't know what is the status of mediadevices, please mark it as experimental or something.  Please be clear upfront that the user must bring their own implementations of congestion control and loss recovery.

I like this!
My two cents: the pion/webrtc dependencies under the pion/ organization sometimes miss the details on what they are for. For example, when I was starting out exploring pion and its libraries, I noticed the READMEs of pion/rtp, pion/rtcp and pion/srtp all looked the same, with no additional context about what each of these libraries were about.
On the other hand, the pion/dtls library has a nice list with features at the top of the README.

We split every protocol out to encourage them to be used on their own. Some didn't get much attention while others, like DTLS, grew their own vibrant community. It just happened naturally. Maybe improving the readmes of those other libraries may help attract eyes thought.

Many complex terms can scare people off or raise their expectations. They may say "A lot has been done here, we can easily use this project", but they are not.
I think that people who understand will not switch to another project, because they already have a ready-made solution that works. Not sure, but people come here who don't know much about WebRTC in the beginning. The words ICE, TURN and etc wouldn't give me anything. I wanted to see an example that works and is simple so that a quick start can be done.
I think at the beginning you need to put a quick start, only then the features. An example should implement the most popular usecase, and also offer examples for less popular usecase. These examples should work in the real world so that the user does not think they have been fooled.
Sorry a little off topic.

@tekig what do you think of pushing features down lower? We can have Usage and What is WebRTC and then features.
I think we do have some people coming to this and evaluating how polished Pion is (where I think this list helps). I think you are right though about the majority of users don't care about feature set and just want to get going.

Would this have improved/detracted from your first opinion of using Pion? I have gotten a lot of feedback that people have no idea what pion/webrtc contains so wanted to bring this to the top.

Having this list of features is great, although the README is starting to get busy -- maybe better to have a 'Features' page on the wiki or pion.ly and link to it from the README.md?
Personally, I learn best by example, so the example applications/demos were the most useful to get a feel for Pion.

@tekig what do you think of pushing features down lower? We can have Usage and What is WebRTC and then features.

a good idea

I'm late on this, but it's a good change!


Storage account for audit production server shows logs for databases copied to dev environments

I do not see it mentioned here but have auditing on for a production logical server and see in the corresponding audit storage account results for databases copied to dev/test environments from the production logical server.  Can you confirm this behavior?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 0c27fe13-a824-84a5-e314-892a27c1dec5
Version Independent ID: 510b5427-c927-84df-563f-31dfe13fc771
Content: Get started with auditing - Azure SQL Database
Content Source: articles/sql-database/sql-database-auditing.md
Service: sql-database
Sub-service: security
GitHub Login: @DavidTrigano
Microsoft Alias: datrigan

@langstonj Thanks for your comment! We will review and provide an update as appropriate.

Hello @langstonj ,
Thanks for your comment!
If you configured auditing on the database-level, and you copied this database to another server, the audit configuration will be copied as well on the copied database.
Let us now in case you may have additional question.
Best,
D.

Even though I did my production server configuration at the server-level every database on this audited production server will be audited on whatever server the database(s) are ultimately copied.
I suspect that others out there, if they are not already aware, will discover this feature on their dev environments.
Thank you for your response.
Best,
John C Langston  |   SQL Database Administrator  |  eLynx Technologies, LLC  |  2431 E. 61st, Suite 700  |  Tulsa, OK  74136  |  www.elynxtech.com
From: David Trigano<EMAIL_ADDRESS>Sent: Thursday, February 20, 2020 3:37 AM
To: MicrosoftDocs/azure-docs<EMAIL_ADDRESS>Cc: John Langston<EMAIL_ADDRESS>Mention<EMAIL_ADDRESS>Subject: Re: [MicrosoftDocs/azure-docs] Storage account for audit production server shows logs for databases copied to dev environments (#48474)
Warning: This email was sent from a source external to eLynx Technologies. Please use caution when opening attachments or clicking links.
Hello @langstonjhttps://nam10.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Flangstonj&data=02|01|john.langston%40elynxtech.com|593c2ecf8a264cbae03708d7b5e869ca|891867d4a39248edac164bd398b62ec9|0|0|637177882155358958&sdata=p0kvKHSVUhRTxtjm7pL4JArRm74hZcr6XvMYX34jdWk%3D&reserved=0 ,
Thanks for your comment!
If you configured auditing on the database-level, and you copied this database to another server, the audit configuration will be copied as well on the copied database.
Let us now in case you may have additional question.
Best,
D.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://nam10.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FMicrosoftDocs%2Fazure-docs%2Fissues%2F48474%3Femail_source%3Dnotifications%26email_token%3DAKQHJASZWO7SKJZBWZVGXYLRDZFLFA5CNFSM4KX6FI7KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEMMSRKQ%23issuecomment-588851370&data=02|01|john.langston%40elynxtech.com|593c2ecf8a264cbae03708d7b5e869ca|891867d4a39248edac164bd398b62ec9|0|0|637177882155358958&sdata=PUXMtw1sP2Qzw1X2xPmeLMo5OkfJVg4%2BfUVdshZWYLE%3D&reserved=0, or unsubscribehttps://nam10.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAKQHJAQR2GEL2VFWDQBT67DRDZFLFANCNFSM4KX6FI7A&data=02|01|john.langston%40elynxtech.com|593c2ecf8a264cbae03708d7b5e869ca|891867d4a39248edac164bd398b62ec9|0|0|637177882155358958&sdata=rKo5BfWekAFsurMtNoN2Kx%2FVjxRe%2Befqkck8Da39z8c%3D&reserved=0.

A picture is worth a thousand words.
Server-level
<EMAIL_ADDRESS>Database-level for a database residing on pscsqlsrv03
<EMAIL_ADDRESS>I didn’t see it in the docs (and I realize keeping the docs updated is no small task with a log of moving parts) but my $.02 would be to include something that indicates this behavior is present.
Best,
John C Langston  |   SQL Database Administrator  |  eLynx Technologies, LLC  |  2431 E. 61st, Suite 700  |  Tulsa, OK  74136  |  www.elynxtech.com
From: David Trigano<EMAIL_ADDRESS>Sent: Thursday, February 20, 2020 3:37 AM
To: MicrosoftDocs/azure-docs<EMAIL_ADDRESS>Cc: John Langston<EMAIL_ADDRESS>Mention<EMAIL_ADDRESS>Subject: Re: [MicrosoftDocs/azure-docs] Storage account for audit production server shows logs for databases copied to dev environments (#48474)
Warning: This email was sent from a source external to eLynx Technologies. Please use caution when opening attachments or clicking links.
Hello @langstonjhttps://nam10.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Flangstonj&data=02|01|john.langston%40elynxtech.com|593c2ecf8a264cbae03708d7b5e869ca|891867d4a39248edac164bd398b62ec9|0|0|637177882155358958&sdata=p0kvKHSVUhRTxtjm7pL4JArRm74hZcr6XvMYX34jdWk%3D&reserved=0 ,
Thanks for your comment!
If you configured auditing on the database-level, and you copied this database to another server, the audit configuration will be copied as well on the copied database.
Let us now in case you may have additional question.
Best,
D.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://nam10.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FMicrosoftDocs%2Fazure-docs%2Fissues%2F48474%3Femail_source%3Dnotifications%26email_token%3DAKQHJASZWO7SKJZBWZVGXYLRDZFLFA5CNFSM4KX6FI7KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEMMSRKQ%23issuecomment-588851370&data=02|01|john.langston%40elynxtech.com|593c2ecf8a264cbae03708d7b5e869ca|891867d4a39248edac164bd398b62ec9|0|0|637177882155358958&sdata=PUXMtw1sP2Qzw1X2xPmeLMo5OkfJVg4%2BfUVdshZWYLE%3D&reserved=0, or unsubscribehttps://nam10.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAKQHJAQR2GEL2VFWDQBT67DRDZFLFANCNFSM4KX6FI7A&data=02|01|john.langston%40elynxtech.com|593c2ecf8a264cbae03708d7b5e869ca|891867d4a39248edac164bd398b62ec9|0|0|637177882155358958&sdata=rKo5BfWekAFsurMtNoN2Kx%2FVjxRe%2Befqkck8Da39z8c%3D&reserved=0.

@DavidTrigano It likely a worthwhile enhancement to include this detail to the document:

If you configured auditing on the database-level, and you copied this database to another server, the audit configuration will be copied as well on the copied database.

If you configured auditing on the server-level, and you copied this database to another server, the audit configuration will not be copied on the copied database neither the server.

Will discuss doc edits with @DavidTrigano

@langstonj @Mike-Ubezzi-MSFT I wanted to let you know that we are working on updating this document according to your feedback. Many thanks again for your time.
#please-close


⚠ Bofrost.de has degraded performance

In 1c72865, Bofrost.de (https://www.bofrost.de) experienced degraded performance:

HTTP code: 200
Response time: 1273 ms

Resolved: Bofrost.de performance has improved in f0fd83f after 6 minutes.


Question regarding blenderproc

is there a specific reason why you used the old version of blenderproc with the yaml files?

No, the new version also works.

alright thank you. can you maybe provide the full code, files like 'python data_generation-Blender.py' are missing

Yes, we are preparing more detailed instructions, will update as soon as possible, thanks!

We have added instructions and code to generate training data through BlenderProc.


PHP Typo

& && Typo

Hi Joel,
This actually isn't a typo - the double-ampersand is the short-circuit version, which won't bother to interpret the right-hand side if the left-hand side is true.
In this instance, we want to ensure that $config['node_links'] is an array, and that the number of elements is greater than zero.
Thanks,
Craig


fix error in map_xs function

The 'map_xs' throws the following error: Error: $ operator is invalid for atomic vectors

The tmap::tm_text function has two parameters (i.e., along.lines, overwrite.lines) that are corrupting the map and not allowing it to print. The workaround is to temporarily disable these 2 parameters and use shadow instead.
14a039e779c234d877e384e2578fb9b1b6f91c0d


Unable to find git in your PATH (Android Studio)

Android Studio was running but suddenly this problem occurred.
If I create new Flutter project giving an error "Flutter create command was unsuccessful"  "Run Flutter Doctor", if I enter flutter doctor in the Terminal of the Android studio "Unable to find git in your PATH"

I have already added flutter to path


failed to access notebook

I had issue when trying to access the notebook after deploying this bundle https://pastebin.canonical.com/p/xsRFbV89Ts/
The notebook logs are as follow: https://pastebin.canonical.com/p/hcnCG7MMp7/

I'm using

This happen when I create a notebook with a persistent disk. With an ephemeral disk it doesn't happen

Hello @aym-frikha is this still happening with Kubeflow 1.6?

Closing as this should be fixed with 1.6, please reopen if it reoccurs there.


Replace React Favicon with a Custom Logo

The React logo is being used as the favicon, which does not fit the website’s branding.
The favicon should be replaced with a custom logo that reflects the website's theme (for example, a Shree Krishna or other relevant icon).
Assign this issue to me and nobody else I can resolve it and also provide response on completion or any issue .
Provide this with gssoc-extd hacktoberfest-accepted level 1

The React logo is being used as the favicon, which does not fit the website’s branding.
The favicon should be replaced with a custom logo that reflects the website's theme (for example, a Shree Krishna or other relevant icon).
Assign this issue to me and nobody else I can resolve it and also provide response on completion or any issue . Provide this with gssoc-extd hacktoberfest-accepted level 1

Please don't use generated icon

Ok!

The work is done ! can you merge it with authorization

is the issue closed ?

i want to work on this ,please assign this to me

May I know if the issue is closed , if not I'd like to work on it!!
Thank You!


Release/v3.2

test

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.1 out of 8 committers have signed the CLA.:white_check_mark: igrr:x: liuzfesp:x: Renz Christian Bagaporo:x: projectgus:x: jack0c:x: ESP-MESH-QI:x: heyinling:x: Weijian-EspressifRenz Christian Bagaporo seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.

@pvenkatesan83 This looks it might have been opened by mistake? It merges one of our release branches into our master branch. I'm going to close it.


Install ''pip install pointnet2_ops_lib/.''

Thanks to the author for the code.
In the Install section of the Github page
''pip install pointnet2_ops_lib/.''
for what purpose? Is it a package or file?
Terminal display:
''ERROR: Invalid requirement: 'pointnet2_ops_lib/.'
Hint: It looks like a path. File 'pointnet2_ops_lib/.' does not exist.''

@Serendipityo1
This is a package to run fps on gpu for fast speed.
Please run the installation on Unbuntu (under pointMLP-pytorch folder)


Github Pages deploy error, HTML-Proofer, custom domain?

Checklist

[X] I have read and accepted the contributing guidelines.

How did you create the site?
Generated from chirpy-starter
Describe the bug
Locally the website is working perfectly but I no longer can get it to deploy with github. Haven't deployed in 3 weeks. within this time I only remember putting a Custom domain with github pages settings.
https://tomasapo.github.io/ -> apolonia.co.uk
Steps To Reproduce
Please see https://github.com/tomasApo/tomasApo.github.io/actions when builds started failing, and my troubleshooting attempts/
Expected Behavior
Simply deploys like it used to.
Environment

Ruby: ruby 3.0.2p107 (2021-07-07 revision 0db68f0233) [x86_64-linux-gnu]
Jekyll: jekyll 4.3.3
Chirpy:  jekyll-theme-chirpy (6.5.0)

Anything else?
`
Run bundle exec htmlproofer _site
Running 3 checks (Scripts, Links, Images) in ["_site"] on *.html files...
Checking 107 internal links
Checking internal link hashes in 4 files
Ran on 20 files!
For the Scripts check, the following failures were found:

At _site/404.html:1:
internal script reference /app.js does not exist

At _site/about/index.html:1:
internal script reference /app.js does not exist

At _site/archives/index.html:1:
internal script reference /app.js does not exist

At _site/index.html:1:
internal script reference /app.js does not exist

At _site/posts/MxMaster/index.html:1:
internal script reference /app.js does not exist

At _site/posts/SmartBasil/index.html:4:
internal script reference /app.js does not exist

At _site/posts/releaseV1/index.html:9:
internal script reference /app.js does not exist

At _site/posts/releaseV2/index.html:89:
internal script reference /app.js does not exist

At _site/shop/index.html:1:
internal script reference /app.js does not exist

At _site/tags/arduino-uno/index.html:1:
internal script reference /app.js does not exist

At _site/tags/embedded-rust/index.html:1:
internal script reference /app.js does not exist

At _site/tags/esp32/index.html:1:
internal script reference /app.js does not exist

At _site/tags/feathers2/index.html:1:
internal script reference /app.js does not exist

At _site/tags/index.html:1:
internal script reference /app.js does not exist

At _site/tags/righ-to-repair/index.html:1:
internal script reference /app.js does not exist

At _site/tags/stm32f3/index.html:1:
internal script reference /app.js does not exist

At _site/tags/usb-c/index.html:1:
internal script reference /app.js does not exist

HTML-Proofer found 17 failures!`

I am going through similar issue. I tried a bunch of things, however I keep coming back to this error:

Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/configure-pages@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.

I also tried bumping up GitHub Actions versions with negative results ☹

Hey @rudzainy. I managed to solve the "warning" about Node.js by following @joshjohanning commit.  My issue remained hence I reverted the change, either way the warning from github actions was gone.
https://github.com/cotes2020/jekyll-theme-chirpy/pull/1554/commits/143eec2a31b53c7cb15918d300a7210d6541994b

For the time being, I just commented out the tests in pages-deploy.yml so that at least something is showing on my site 😞

You can temperarily bypass the problem by modifying Gemfile
- gem "jekyll-theme-chirpy", "~> 6.5", ">= 6.5.1"
+ gem "jekyll-theme-chirpy", "~> 6.4.2"

@Brainor you wizard, it works now, thank you.
Do you mind explaining or pointing me in the right direction on why this version change solves the github page issue?

I just know the version 6.4.2 works and version 6.5.1 doesn't work, so I manually set the jekyll-theme-chirpy version to be 6.4.2 to solve this problem.
I don't know where the true problem/bug lies, so this is the best I can do😄


[Vulnerability] DataView and other non-native classes can be overriden

Currently msgpackp uses DataView to operate with float64
The problem is that potential attacker can hook DataView class or Uint8Array class and listen for messages
Example of such attack:

Uint8Array = new Proxy(Uint8Array, {
  __proto__: null,
  construct(targetObj, argsArr) {
    console.log("Received message ", argsArr[0]);

    return new targetObj(argsArr);
  }
});

The solution is to minimise usage of external classes that are global for every page. Currently DataView usage could be removed. Thus it will improve overall performance

In the last update DataView is only used to manipulate over float64

Uint8Array hooking can be potentially fixed by defining empty uint8array on initialization and reusing it, and instead of creating uint8array instance after message was encoded, assigning data to it directly by uin8array.prototype.set


Color bars during resolution setting change + fade during savegame selection

Two weird issues I've been having for a while:
Color bars appear when switching through resolutions (without resolution even being changed, just going through the options):
https://user-images.githubusercontent.com/1755499/191581448-fad8c70f-1ea7-4731-8aec-0df343c60b73.mp4
and weird fade/brightness flicker when going through savegames (for some reason it doesn't show much in the recording, but the flicker is happening pretty much every time I change the selection):
https://user-images.githubusercontent.com/1755499/191581667-446e6af2-6bf0-4481-a8dc-042d1608848d.mp4
Thought it might have been something on the trainer branch, but using latest master also seems to cause it too (under both vanilla & HDP1.1) - though issue doesn't appear when using <IP_ADDRESS>...
E: quite a few changes between <IP_ADDRESS> and master: https://github.com/nipkownix/re4_tweaks/compare/<IP_ADDRESS>...master
Tried disabling as much as I could in INI but no improvement, maybe git bisect could help.
E2: ah went through bisect, seems issue might have started in Added new MouseTurning type and CameraImprovements
E3: seems to be something inside Init_CameraTweaks, making it return before it hooks stuff (but after it gets the C_RANGE_1097 etc pointers, else other code crashes) seems to get rid of the issue, not really sure what hook inside there would be interfering though.

Ah, I was surprised to never have found any issues with those patches until now, honestly.
I only recently noticed the weird flashes. Thought it was caused by something more recent, though. Meh.

Seems it might be the PadReadYreset hook, looks like both that and PadReadXreset are working on the same block of code at 968B4E, one is hooking the fst and the other the fstp, hooks then reuse the original fst/fstp in the hook block as an __asm.
Think I had issues trying to use fst/fstp inside MakeInline hooks before, AFAIK fstp is popping something from the x87 ST stack, maybe MakeInline ends up restoring it or something.

Ah, hmm, the fstp being inside the if was intentional, though, I think? Don't really remember, but unconditionally writing 0 is the game's vanilla behavior, and I wanted to stop that. I think our probably was the p part of fstp, as poping the value should happen regardless. Meh.
I've come up with something else that should work though:

Haven't tested much, been having little free time lately :/
Will test in a sec.


FreeRDP command line change affects linux UDSClient

FreeRDP has deprecated CHANNEL_TSMF and has modified its command line for multimedia redirection from "/multimedia:..." to "/video".
When UDSClient launches FreeRDP with multimedia redirection and there is installed a new FreeRDP version compiled without CHANNEL_TSMF_CLIENT flag (e.g. in current Arch Linux package), FreeRDP is not launched (it prints command line help instead).
So, there will be some versions of FreeRDP that use "/multimedia:..." (older ones) and other versions (newer ones) that will not be launched with this "/multimedia:..." parameter and need "/video" instead.

Thanks for the report.
We have updated on 2.2 and master (3.0) branches, so now UDS will use /video instead of /multimedia.
For old clients, the best is to upgrade frerdp client to at least a 2.0 version, and if not possible, provide a customized transport without the "multimedia" flag, and add "/multimedia:...." as a custom parameter


Duplicated waveform using React

Issue
I have updated react to 18 version with Next js, and now the waveform is duplicated but just the below one is played. I would like you can let me know how can I solve this bug.
Wavesurfer.js version(s):
"wavesurfer.js": "^6.2.0",
Browser and operating system version(s):
Brave, Chrome, Edge
Code needed to reproduce the issue:
const formWaveSurferOptions = (ref) => ({
  container: ref,
  backend: 'WebAudio',
  waveColor: '#9c9c9c',
  progressColor: '#4e4e4e',
  height: 25,
  cursorWidth: 1,
  cursorColor: 'transparent',
  barWidth: 2,
  barRadius: 3,
  width: '100%',
  barGap: 4,
  normalize: true,
  responsive: true,
  autoCenter: false,
  fillParent: true,
  hideScrollbar: true,
  partialRender: true,
  closeAudioContext: true,
  xhr: {
    cache: 'default',
    mode: 'cors',
    method: 'GET',
    credentials: 'same-origin',
    headers: [
      { key: 'cache-control', value: 'no-cache' },
      { key: 'pragma', value: 'no-cache' }
    ]
  }
});
useEffect(() => {
    import('wavesurfer.js').then((m) => {
      const WaveSurfer = m.default;
      setPlay(false);
      const options = formWaveSurferOptions(waveformRef.current);
      wavesurfer.current = WaveSurfer?.create(options);

      wavesurfer.current.load(
        url
      );

      wavesurfer.current.on('ready', function () {
        // https://wavesurfer-js.org/docs/methods.html

        // make sure object stillavailable when file loaded
        if (wavesurfer.current) {
          wavesurfer.current.setVolume(1);
        }

      });
    });

    // Removes events, elements and disconnects Web Audio nodes.
    // when component unmount
    return () => { wavesurfer?.current?.destroy() }
  }, []);

Use behaviour needed to reproduce the issue:
Just one waveform should appear

We can't help with React specific issues. I suggest using https://www.npmjs.com/package/wavesurfer-react

Fix this error by adding the following in next.config.js
reactStrictMode:  false

Note that using strict mode just disables duplicate firing of useEffect hooks in dev mode. It hides the underlying problem, which is that your component is not properly cleaning up the wavesurfer instance in between renders.
Since useEffect mostly ensures wavesurfer only renders once, this is usually fine, but the issue remains that you should ideally cleanup properly with wavesurfer.destroy().


Fix relative callback URL functionality in Express

Assuming the relative callback URL functionality is supposed to work in Express (I am using Express 4) I think there is a typo.
This should address it and allow this feature to work.

Thank you for the update! A patch has been released including this and https://github.com/mathisonian/passport-stripe/pull/4. It is available on npm now.


Is there any way to ignore a specific version when delta table is used as streaming data source.

We use spark structured streaming and delta table. We process private data, so we need to delete the data. We have a seperate job to process the customer consent and delete the data when consent is revoked. And this deletion is not on partition level. Then once we purge the data based on customer consent. Huge number of rows are copied. And this takes huge processing time for normal downstream handling. So I would like to know is there any way to skip a version when  delta table is used as streaming data source?
For example,  in commit info, we have {"commitInfo":{"operation":"DELETE", "jobName":"PURGE" ...
Or if there is a way to ignore a specific version. Then we can figure out which version we want to skip and set it when start the streaming.

Why don't you use cdc as stream source?

According to the docs https://docs.databricks.com/structured-streaming/delta-lake.html you can ignore deletes. Another approach would be to parse the log manually and then specify the starting version of table

Hi @jbin121867740 - I think that the two comments above propose some fair next steps. Can you try them out, or respond and update what is / is not working for you?

Hi, Sorry for no response for long time. What I would like to ignore is not only those rows which are deleted, but also the rows were added again due to they are in same file as those deleted rows. Since those newly added rows are copies of old rows which are already been processed by downstream.
if I ignore a specifc version manually, I need the option for startingVersion and endingVersion. For example, if there are V1, 2, 3 and 4. V3 is for deletion, and the rest is adding data. Currently the down stream is commited on V1, then it needs to process V2, ignore V3 and then process V4.
While if there is no endingVersion support, how can I just process V2?
Also it will be much better this kind of scenario can be supported officially. This is one of the pain point we have when we have to delete data (I suppose many companies have this issue if they have to deal with privacy data, and use spark streaming + delta table to do the data processing).

Sorry for the mistake of closing the issue.

Again - why don't you use cdc as a stream source?

@jbin121867740 We have a recent change to provide a new skipChangeCommits option in #1616. Does this work for your case?

@zsxwing, thanks so much. This is exactly what we want.

Thanks! Resolved by #1616


Fix NSCIB cert ID matching and canonicalization

Describe the bug
We are incorrectly parsing the NSCIB ids with -CR and -CR2.
For example:
https://seccerts.org/cc/3e08a27e9d9c9b1e/
Expected behavior
Match and canonicalize properly.

This was fixed by #386 .


Windows Terminal Preview does not work with Visual Studio 2019.

Windows Terminal version (or Windows build number)
1.10.1933.0
Other Software
Microsoft Visual Studio Enterprise 2019 16.10.3
Steps to reproduce
Create a new VS C++ Console project.
 Click the Local Windows Debugger Button.

Close the tab with the X.

Click the Local Windows Debugger Button again.
Then VS will show this message box.

In the output field, it says.
已退出，返回值为 -1073741502 (0xc0000142) 'DLL Initialization Failed'。
If I click the Local Windows Debugger Button again, this message keeps showing.
Expected Behavior
Normally run the app again.
Actual Behavior
An alert message box was shown.

Hi. I just faced the same issue. More details about what happened. In my case, I installed the Preview version of the terminal today (it's version 1.11.2731.0). Then I set the Default terminal application to Windows Terminal Preview and started debugging in the Visual Studio 2022 (not sure if the version matters, I'm using Community edition). In the beginning it opened a new terminal window and started debugging there, which is fine, but I wanted it to open a new tab in the already open window. So I head over to the settings and set the New instance behavior to Attach to the most recently used window and then tried to debug in VS and it started failing to start a terminal with an error code 0xc0000142. I tried to switch back the New instance behavior to Create a new window, but the error message remains there.
I did some experiments, and my findings are the following. Once you log in you have 1 possibility to get the debug action work in the windows terminal. No matter what option you have chosen for the New instance behavior. Once you close the tab, debugging from VS won't work for terminal. Signing-out/in helps, but again, only for the first time.

Seems like a duplicate of https://github.com/microsoft/terminal/issues/10453

I can repro the issue with VIsual Studio 2022, and Terminal 1.11.2921.0 as well. Out of the box, only by changing the default terminal app to Terminal, and without changing any other configuration options.
@arsdever Might be, but the problem is the other way round. Here, the first launch works but subsequent launches fail.

I was just playing around and found something interesting. So when you close the console window after the debugging session was finished (either you pressed stop in the VS, or you closed the separate GUI window which terminates the process, or your program finished) you are able to rerun. But once you close the terminal window while debugger is running, the issue appears. This might be helpful when debugging.

That should be very helpful indeed. Sorry, still swamped with other tasks. I took a week off as vacation and I've been behind ever since.

Since the feature this bug is referring to is included in the Terminal v1 doesn't it make sense to deliver this bugfix for v1 as well? I'm asking since this task is put into v2 milestone.

Just ran into the same problem with VS 2019 (16.11.7) and Terminal Preview 1.12.2931.0. I ran into this without having a debugger attached. I opened my C++ project and hit ctrl+F5 (start without debugging). The first time it worked but after that I have to restart VS to get it working again.
I have quake mode running in the background, maybe it's related to that?

Yes, I can also reproduce. I noticed that when problems occur, the VsDebugConsole process still exists and can spin one CPU core. If you kill that process, debug start normally without needing VS restart.

Good news everyone!
I think this was actually fixed on the VS side!
https://docs.microsoft.com/en-us/visualstudio/releases/2019/release-notes#release-notes-icon-visual-studio-2019-version-16119-newestreleaseicon

Fixed an issue with being unable to debug applications multiple times when Windows Terminal is used as the default terminal.

From internal notes:

This fix was also included in 16.7.24, 16.9.16 and 15.9.43.

This should be fixed, with a VS update. Thanks everyone!


CasperError: Errors encountered while filling form: RangeError: Array size is not a small enough positive integer.

Hello,
This is a bug report : I identified the root cause of the error mentioned in this issue title.
When trying to fill a form, I was passing an integer as a password and the following code crashed because value.length evaluated to undefined:
https://github.com/n1k0/casperjs/blob/master/modules/clientutils.js#L828
I guess either value should be checked or converted to string at some point beforehand,
or this code line should handle non-string values.
$ casperjs --version && phantomjs --version
1.1.0-beta3
1.9.8

I just got this. Workaround?

Convert the integer to string:
''+42

Merged. Thanks for your PR.


[WIP] This PR introduces API v9

TODO

[x] Default Slash Command Permission
[ ] GuildApplicationCommandPermissions
[ ] ApplicationCommandPermissions
[ ] ApplicationCommandPermissionType

Goal
Updating SlashCommands to API v9

This will be merged when 4.1.0 is released on nuget

I've added this myself in the latest version.


Making Multi Guild Ticket System!

50 % of the things are done in make ticket system

config/setup command is done

TODO: To Complete this whole ticket system and also make a transcript!!

Did Not Complete All the things, in the ticket system but did my best :D


[ZEPPELIN-1697] Fix multiuser ws connection for secondary ZeppelinHubRepo storage

What is this PR for?
This is to fix problem with ws connection that was introduced in 0.7.0 with ZeppelinHubRepo storage layer.
What type of PR is it?
Bug Fix
Todos

[x] - fix multi-user ws connection issue
[x] - handle back connection
[x] - handle switch tokens
[ ] - handle single token in conf

What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-1697
How should this be tested?
TBD
Screenshots (if appropriate)
Questions:

Does the licenses files need update? no
Is there breaking changes for older versions? no
Does this needs documentation? no

Can you setup CI for you fork?
And then you'll need rebase this branch to include some fixes for CI failure from current master.

yes, i think my fork was integrated with travis since i have the build here https://travis-ci.org/khalidhuseynov/incubator-zeppelin/builds/212981024 . also the branch was rebased today and based on commit 4a9377db9446587aa6f76c10e581493b808dd503. So should i rebase once again or there's some other issue?

Current jenkins script check only https://travis-ci.org/khalidhuseynov/zeppelin/ not https://travis-ci.org/khalidhuseynov/incubator-zeppelin/. Could you setup travis with 'zeppelin' repository name?

/cc @anthonycorbacho @Leemoonsoo @AhyoungRyu plz help to review and test this one

@anthonycorbacho thanks for the feedback, addressed them above. Let me know if there's something else and if it works fine for you.
Also would be nice if other members could review and test it, so that can include it in 0.7.1

I tested two scenarios that you described and both(turn on & off Shiro) are working well.

Tested with some basic case, look good to me

Merging it to master and branch-0.7 to include 0.7.1 release.


Add

Adds FlyControls component.
I also made a code sandbox example:
https://codesandbox.io/s/r3f-drei-transformcontrols-t9ns5?file=/src/index.js

thanks! it's still missing the export in src/index.js otherwise it wouldn't be public.

I'm not sure if this is my problem or working as intended or a real issue, but when I click on the model I get instantly zoomed/moved inside the model

Removed useEffect since dispose is automatically invoked.
Replaced clock with delta coming from useFrame.
@gsimone it's the movementSpeed  parameter. Remove or change it.

Could you rebase your fork to the latest version of drei and maybe contribute a story to the storybook?

Definitely can.

@gsimone
As per request rebased and added storybook story.


Forced Reflow in constructor

Describe the bug
This is similar to #162, but I am on v4.0.0
Calling the constructor SimpleBar() causes a forced layout, which can take up to 80ms on my site.

To Reproduce
Call the SimpleBar() constructor while capturing a Chrome trace.
Expected behavior
No reflow should occur.
Additional context
I see #162  was closed, but I still see reports of this issue with no further resolution
Your environment

Software
Version(s)

SimpleBar
4.0.0

Browser
Chrome latest

Operating System
Windows/Mac

Hi,
Yes there are definitely still opportunity for performances improvements. I think this depends as well a lot of the element on which you apply SimpleBar, the complexity of your DOM etc.
Could you give more details on your usage?
Could you start by updating to the latest SimpleBar version? That shouldn't impact your test but you're on a quite old version now.

Thanks for replying!
I will update to the latest version and let you know if anything changed.
One place I noticed it happening every time was with the call to getScrollbarWidth. This value doesn't change and could be cached. I can file a PR for this

There might be one other thing that makes the scrollbarWidth() slow is that we reworked it recently in #325 and it's now using getBoundingClientRect instead of offsetWidth which is much slower I think (didn't do any benchmark but from the top of my head).
Actually the scrollbarWidth() is already cached and the cache is flushed only on window.resize so it should impact only on init.
Only if you have multiple instance of SimpleBar on your page, you can multiply this issue because there is no caching across instances. There was a plan to work on that in #205 as well.
I see 2 opportunities to improve performances in this function:

cache the value across instances (that would probably require a global variable?) see #205
find another way to solve #325 by rolling back usage of offsetWidth which is faster but then find another workaround

I meant the approach for #205, where this value should never change throughout the life of the application. Would require a module level variable, yes

I will submit a PR for #205

@Grsmto I also authored #374, which delays the expensive portion of the initialization to a later tick, which improves the first paint experience for complex layouts. Let me know what you think

After learning more about this library and thrashing, it is pretty clear why the thrashing is occurring. Unfortunately, its less clear how to fix it :)
The main issue is that recalculate writes and reads DOM properties in an interleaved fashion. This is likely because these operations are all dependent on each other

For example here, we modify the margin/padding of some elements, and then immediately request the boundingRect. This unfortunately causes the thrashing issue. On small sites (like the demo site) its not noticeable, but becomes a problem on complicated layouts

You're right it's something I wanted to work on for a long time but it always stayed on the backlog's bottom list :)
We could use/do something like fastDOM for this. I'm actually working on this right now. Added some other hints in #372

I'm closing this since the library codebase has changed a lot since then. We rely a lot less on getBoundingClientRect(), so if anyone notice perf problems please open a new issue!


[SPARK-41169][CONNECT][PYTHON] Implement DataFrame.drop

What changes were proposed in this pull request?
Implement DataFrame.drop with a proto message
Why are the changes needed?
for api coverage
Does this PR introduce any user-facing change?
Yes
How was this patch tested?
added UT

I will update this PR after the arrow-based collect is fixed https://github.com/apache/spark/pull/38706 , otherwise, some e2e tests will fail

Merged to master.

LGTM


fix(readme): fixed cdk property which enables plugin in README

What does it Fix?

The property of CDK which README uses is wrong.

According to CDK docs, only policyvalidationbeta1 property exist.　There is no reference of validationPlugins

Motivation

If someone tries this plugin following the current state of README won't be able to use the plugin until they go and search CDK docs which is not nice from an experience point of view.

Verification

I have verified this in my blog https://dev.to/aws-builders/level-up-your-aws-cdk-game-shift-left-security-unveiled-5f54 and it works with the changes I have proposed in this PR.

The following information has also been verified by AWS team author of aws  blog and I have asked the authors to update the blog too.

Hi @jatinmehrotra ,
Thank you for your contribution!
Kindly check this error:

Feel free to ping us anytime!

@gabriel-cx
I have fixed the failing check https://github.com/Checkmarx/kics-cdk-validator-plugin/pull/16/commits/9acc586a3c71ac1f2c1977dea04c1ab206e0dd03. Please review.

Thank you @jatinmehrotra , I already approved your suggestions!
The build check keeps failing with this message:

Kindly have a look.

@gabriel-cx
Thank you for pointing out.
IMO it was another bug in documentation for API.md where Severity.MEDIUM was missing which causes mutation during build https://github.com/Checkmarx/kics-cdk-validator-plugin/pull/16/commits/a1cf9a64fb9918da8c07eb57dd94f483c4491c03. Sorry for the inconvenience, is it possible to re-run the build check? I guess only maintainers can run the build workload otherwise I would have run and tested it ! 😅

@jatinmehrotra no problem! :D
I saw that it keeps failing, is a tricky case!
I opened a draft PR to test from my side, and it passes all steps.
I just updated my local master branch to keep it updated with remote master and create a new PR on top of it with the necessary changes (i just updated the policyValidationBeta1 property, as you can see here).
Kindly double check from your side this situation, I suggest you to update your local master to be in sync with remote master, and then create a new PR. I will keep an eye on that so I can run the build step :D

That's strange because My local main branch is up to date. Nonetheless less I will try to create a new PR.

@gabriel-cx
As you mentioned I tried to create a new PR with local branch in sync with remote in this new PR.

I'm closing this PR. due to the fact we have a new one.


.bst syntax highlighting

BuildStream uses YAML to define packages but the files end with the .bst extension. Would it be possible to change the regex in the yaml syntax highlighter to also match these files? Thank you!

I guess so. But that is such a simple thing that I'd say you should submit a PR with the change. It's just modifying one line in a yaml file 😄

BibTeX also uses the .bst extension and those are not YAML files. Therefore, this extension should not be associated with the filetype YAML.
BuildStream .conf files also use YAML format. You can configure micro to recognize both .conf and .bst extensions as YAML files by adding to your ~/.config/micro/settings.json:
"*.conf": {
    "filetype": "yaml"
},
"*.bst": {
    "filetype": "yaml"
}

I'll close the issue then. Buildstream is pretty niche so I think I makes sense for this to be a user configuration 👍


Requirement to have an arrow option to minimize/expand the Logical Device directory level in the IED Editor tab

Observed:
It is really difficult to minimize the Logical Device in the IED Editor tab-refer to the below screenshot or attachment.
.
Expected:
Single arrow mark availability required on the Logical Device level to minimize and expand the LD level  to make the usability and focus on the specific Logical Device directory easily.

Thanks for the feedback, highly appreciated!

It would be nice if the server can collapse as well. By default the windows should be open.


Travis CI

Allow Travis CI to run tests and add a badge to the Github index to show tests status (passes/fails).
Git repo owner @brotandgames will need to give Travis access to automatically set up the webhooks and the process. This PR is to only set up the files needed to instruct Travis on how to build the test suite and to add Travis CI badge to README.md.
Example run:
https://travis-ci.com/tareksamni/ciao/builds/120923139

@tareksamni Thank you for your contribution.