[query-builder] aggregation change function

Currently when you set an aggregation like max for-each you cannot change max to something else. This requires you to delete the aggregation and then add it again. If you have many aggregations you have to delete them all since you cannot click and drag the aggregations around.

I would find this very helpful 👍


When items in ion-list with *ngFor is scrolling, click one element wrapped with button tag, the responed item is not the one clicked

Note: If you are having problems formatting your issue please refer to this article on using markdown in Github:
Short description of the problem:
I have an ion-list, there are some buttons with ion-item detail-none attribute template with *ngFor. In iphone 5, 6s and 6p, when tap and scrolling, I click one button, the responsed content bind to the button is not the one i am clicking but some other when i begin scrolling.
What behavior are you expecting?
When scrolling ion-list with buttons, The one as (click) event input is just the one current clicking.
Steps to reproduce:

generate one ion-list with buttons.
in iphone 5/6p/6s, tap to scrolling and click one item.
some times the one clicked is not the one input to click event handler.

<ion-list>
    <button ion-item detail-none *ngFor="#item in items" (click)="processItem(item)">

        <ion-row>......</ion-row>
    </button>
</ion-list>

Other information: (e.g. stacktraces, related issues, suggestions how to fix, stackoverflow links, forum links, etc)
If I use div or ion-item, the above behavior will gone, but I have to click twice to get response from the item I am clicking. I check the API http://ionicframework.com/docs/v2/api/components/item/Item/ and began to use button.
Which Ionic Version? 1.x or 2.x
2.0.0-beta.4
Plunker that shows an example of your issue
I only found the problem on iphone 5/ 6p/ 6s, can not reproduce in chrome or safari or android.
Run ionic info from terminal/cmd prompt: (paste output below)
Cordova CLI: 6.2.0
Gulp version:  CLI version 3.9.1
Gulp local:   Local version 3.9.1
Ionic Framework Version: 2.0.0-beta.4
Ionic CLI Version: 2.0.0-beta.25
Ionic App Lib Version: 2.0.0-beta.15
ios-deploy version: Not installed
ios-sim version: Not installed
OS: Mac OS X El Capitan
Node Version: v5.11.0
Xcode version: Xcode 7.3.1 Build version 7D1014

Hello, thanks for opening an issue with us! Would you mind posting a repo that i can pull and test on my device with? Im having some problems reproducing this issue. Thanks for using Ionic!

I create a repo: https://github.com/christtrc/ionic-app-6748.
I can reproduce it by using ios Simulator.

build it.
open xcode and run under iphone 6 simulator.
tap to scrolling and click

The item current clicking is not the one "click" function out put(current clicking is title14, the output is title13).

same issue,
I fixed this with test

sorry for formatting
same issue,
I fixed this with
test

thanks @evgeniynet , I will try it!

@evgeniynet I just have a try in xcode simulator, but it still has the same problem.

I have this issue in beta8.  Scroll a list and before the scroll stops tap an item.  The item selected is not the one you tapped.

Hello all, thanks for using Ionic! I am going to close this issue for now as I cannot reproduce with the latest rc.0 release. Thanks!

Hello,
Same issue also getting me in ionic 1.
Cordova CLI: 6.4.0
Gulp version:  CLI version 3.9.1
Gulp local:   Local version 3.9.1
Ionic CLI Version: 1.4.0
Ionic App Lib Version: 0.0.16
ios-deploy version: Not installed
ios-sim version: Not installed
OS: Mac OS X Yosemite
Node Version: v5.0.0
Xcode version: Xcode 8.3.2 Build version 8E2002
If I removed  overflow-scroll="true" attribute  from ion-content then it is working fine.
Scroll a list and before the scroll stops tap an item or swipe it The item selected is not the one you tapped / swipped.
I am getting this issue only for iOS For android it is working fine.


Fixing Model Training

Positive results in a positive control? What does that mean? Do I not have to entirely rework my experiment plans this time?
I simulated data in the previous PR, and found that my neural nets failed to learn even clearly linearly separable problems. I dug into the problem and found that instability in training was leading to the issues. One cause of this was very large gradients early on in training, which I fixed via gradient clipping. The deep neural net also had dropout before batchnorm instead of after, which caused more instability. With those problems fixed, I reran the models and found they were able to separate the data fairly easily.
Now that the models work I will rerun the models on real data to see what training looks like with models that work

Conda is failing to install the environment, but mamba installs it just fine. I'm waiting the hour(s) it takes for conda to resolve the conflict, but I may just end up finally switching over to setup-miniconda so I can use mamba with Github Actions (that would be the next Pr though).


DataFrame column type does not convert from floating point to integer and vice versa.

I asked a question here: http://stackoverflow.com/questions/28756206/julia-converting-column-type-from-integer-to-float64-in-a-dataframe about this strange behavior, but am not sure if there is a good reason behind it. Any ideas?

(Answered in StackOverflow link.)


Minor Documentation Changes + Call init_agent

Changes are far too small to put in two seperate commits.

@cinjon what are we doing with this?

waiting for @PixelyIon to fix conflicts and ideally split into two PRs.


feat(media): use software ns and aec

There has been a number of reports of hardware NS and AEC not working on
a range of devices.
Instead, we'll use software NS and AEC provided by WebRTC and consumers
can customize this behavior by providing a custom AudioDeviceModule if
they wish to use hardware implementation.

Could it be the other way around, so consumers disable hw ns and aec themselves?

Possible, but the intent is broad compatibility and software NS & AEC gives that while hardware is a bit fickler and best served by an allowlist of devices on the consumer side.


i18n is REQUIRED when use custom rule message?

Versions

vee-validate: 2.1.0-beta.11
vue: 2.5.x

Describe the bug
I extended a custom validate-rule, but found that without i18n, the message defined in getMessage does not work. I solved it by adding an i18n instance to the options.
Perhaps this is not a BUG, but a feature...

Can you provide a code sample?

@logaretm OK, but maybe later.

You can refer to #1646 because this sounds similar.

You can refer to #1646 because this sounds similar.

Yes, the same reason. Tanks for your quick reply!


[Feature]: 𝓛𝓲𝓯𝓮 𝓼𝓾𝓹𝓹𝓸𝓻𝓽 𝓼𝔂𝓼𝓽𝓮𝓶𝓼 w/ Pollution of the realms

Cause for request
Pollution of the realms support for oxygen generation and air quality concerns
Request details
Pollution of the realms support so a fire on your station is actually a big problem choosing between venting the pollution along with some air by cracking a hole into your base walls or using a pollution filter as a scrubber.
you can set O2 to dissipate at a y level above the build height of the space dimension you are in just like the pollution on the overworld so it can be safely assumed it has leaked out of your base or station
you could generate O2 in the same gas block way of pollution of the realms. without being in contact with O2 gas blocks in the base you'd need a tank or suffocate ya know.

Can you suggest this to 'Pollution of the realms' first?
They implemented many compatibility with other mods.


[Discussion] Bi-monthly release cycles for XGBoost core lib?

In the interest of keeping the stable releases up-to-date with the latest master, I'd like to commit to a regular release cycle for the core lib. I propose a bi-monthly release schedule. Here are some time estimates for the upcoming releases:

Version 0.72: June 1, 2018
Version 0.73: August 1, 2018
Version 0.74: October 1, 2018

(Some of these versions may jump to 0.80, if there's any "major" event.)
Some points of discussion

Is bi-monthly cycle reasonable interval? I thought of 3 months first, but I didn't want too much a gap between stable release and latest master.
Code freezing and backports. @CodingCat suggests that a new branch be created each time a release is made (see discussion in #3200). The release branch will be "frozen" and almost no commits will be added to that branch. Should any backports and post-fixes need to be added, they will be manually cherry-picked into the release branch.
Version 1.0 in horizon? IMHO, a good time for this is when the GPU support becomes mature. @RAMitchell and I are working to set up a Jenkins CI server for the GPU code.
Binary wheel builds This has been put off for a while. I hope for the day when users can download pre-built binaries with pip install xgboost. Many issue posts today involve installation problems.
Versioned docs We need a way to expose XGBoost docs according to stable release versions.

We'd like to be more regimented in our builds of XGBoost; getting releases out as soon after you declare them ready as possible so a regular cadence would suit us well. Bi-monthly sounds fine to me from a packager's perspective too.

Sounds great @hcho3

it looks good to me....and I will work on publishing to maven for jvm-package, I think I can make it before the next release

Sounds good to me!

This sounds good. The backporting could take some efforts, and I think one possible way is only promise backporting up to one or two versions

We should still use tags and keep that official. To keep things minimum, maybe what we can do is to keep backport branch up to one version.  Say after 0.8 release,  the 0.8 branch is kept until 0.9 release and it can be deleted on 1.0 release.

Sorry to go tangential..  0.80 and 0.90 releases I hope? ;-) After 1.0 dropping this two digit minor version should be entirely possible.

@tqchen I agree. Here is my idea of how things will work in the future:

A tag is created for every release
Each release branch will have a few commits for backports. Each backport commit is a copy of a commit from the master (the copy being made by git cherry-pick).
Release branches are kept around for a while: 0.71 and 0.72 branches will be around until 0.80, for example.


Static generate for arabic routes

Versions

nuxt:  v2.15.6

Arabic routes dose not work as expected when i use yarn generate then yarn start unless i manually rename every Arabic generated folder into  encodeURIComponent('Original folder name').
Steps to reproduce
1- clone GitHub repo with its 'dist' folder (don't run yarn generate)
2- open dist folder and run yarn start
3- see that AsyncData() dose not work after refresh the page in '/العنوان'  but work with '/blog_title' and with '/العنوان_الثاني'.
its work with '/العنوان_الثاني' because i manually opened the dist folder and renamed 'العنوان_الثاني' folder to '%D8%A7%D9%84%D8%B9%D9%86%D9%88%D8%A7%D9%86_%D8%A7%D9%84%D8%AB%D8%A7%D9%86%D9%8A' which is the result of encodeURIComponent('العنوان_الثاني')

What is Expected?
i expected AsyncData() to work after refresh the page by default as it works with yarn dev
What is actually happening?
AsyncData() dosent work after refresh the page for generated Arabic routes

I tried to deploy on Netlify, unfortunately its doesn't work after refresh even with my manual rename. so this fix only for yarn start :(

i solved this by add router: { trailingSlash: false, }, in

i solved this by add router: { trailingSlash: false, } in nuxt.config.js. I don't know why arabic routes dosen't work without this, also there is no need to rename any thing.

i solved this by add router: { trailingSlash: false, } in nuxt.config.js. I don't know why arabic routes dosen't work without this, also there is no need to rename any thing.

I found that this will make AsyncData() work but @click="anyFunction()" dosen't work :(
can any one help me to make every thing work with yarn start and Netlify ?


Add Cuju and qCUDA repositories

Two repositories I would like to introduce them to developers
Cuju: An opensource project for Virtualization-Based Fault Tolerance
https://cuju-ft.github.io/cuju-web/home.html
qCUDA: An opensource project for GPGPU virtualization
https://github.com/coldfunction/qCUDA

ping and nudege.

Please open a new pr.


Created translated readme for Telugu

Readme file for telugu language

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: astu9880 sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.

Thanks for taking the time to contribute this localization pull request. However, we are not able to accept contributions to this historical reference repository at this time.


Question: Python visuals Publish To Power bi Service

I was able to create a Python Visual with matplotlib and it works on Power BI Desktop.
I had to manually install some python packages in the corresponding directory selected in config: eg: pandas, nltk, matplotlib.  But it works.
However when I publish to Power BI Service I get this error:
No module named 'nltk'
Is there any way to install our own python modules in Power BI Service? Or is this not supported?
I tried running pip install inside the python script editor but it didnt  work.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 9c6b7b4f-9f34-cec1-687c-2f5c708fe99f
Version Independent ID: e66e6e43-157d-8331-20e2-89d1379c5251
Content: Create Power BI visuals using Python in Power BI Desktop - Power BI
Content Source: powerbi-docs/connect-data/desktop-python-visuals.md
Service: powerbi
Sub-service: powerbi-ai
GitHub Login: @otarb
Microsoft Alias: otarb

Thanks for your comment, @levalencia. This issue has been assigned to the doc author for review.

hello @levalencia, you can find list of supported Python packages here - Python packages that are supported in Power BI
You will not be able to install your own Python packages in the service, this is not supported


Calculating the Volume of Smoke Passing Through a Bucket for Indirect Control Evaluation

Hello,
I'm working with a series of frames in indirect control scenarios and I am trying to figure out how to calculate the volume of smoke passing through each bucket. I have several considerations, such as varying smoke speeds between different buckets. In extreme cases, what if the smoke remains stationary in a bucket, or if there is a continuous flow of smoke through the bucket? How can these situations be distinguished in the calculations?
I would appreciate any insights or methods you might have used in your experiments regarding this issue. Thank you for your time and assistance!
Best regards

Hi @Ashleyhoho, Since the smoke is passively advected, it does not actually afffect the dynamics. One way to count the smoke over time would be to perform the following steps at each time step

Sum the smoke in the bucket and increase the smoke counter.
Clear all smoke in the bucket by setting its density there to 0 (multiply by a bucket mask). This avoids counting the same smoke again in the future.

Cheers,
Philipp

Thank you very much. I appreciate your explanation and understand the points you've made. Your guidance is invaluable to me! :)


Error with kv file parsing

If I create a gui with nested widgets in the kivy file like the following example:
#:kivy 1.9.0
<Layout>:
    orientation: "vertical"
    BoxLayout:
        Label:
            text: "hello"

and this in the python file:
#Kivy version 1.9.0
from kivy.app import App
from kivy.uix.widget import Widget
from kivy.uix.boxlayout import BoxLayout

class Layout(BoxLayout):
    pass

class guiApp(App):
    def build(self):
        return Layout()

if __name__ == '__main__':
    guiApp().run()

It raise the following error:
  File "C:Program FilesPython27x64libsite-packageskivyuixoxlayout.py", l
ine 102, in __init__
    super(BoxLayout, self).__init__(**kwargs)
  File "C:Program FilesPython27x64libsite-packageskivyuixlayout.py", line
 66, in __init__
    super(Layout, self).__init__(**kwargs)
  File "C:Program FilesPython27x64libsite-packageskivyuixwidget.py", line
 271, in __init__
    Builder.apply(self)
  File "C:Program FilesPython27x64libsite-packageskivylang.py", line 1872,
 in apply
    self._apply_rule(widget, rule, rule)
  File "C:Program FilesPython27x64libsite-packageskivylang.py", line 1986,
 in _apply_rule
    self._apply_rule(child, crule, rootrule)
  File "C:Program FilesPython27x64libsite-packageskivylang.py", line 1985,
 in _apply_rule
    self.apply(child)
  File "C:Program FilesPython27x64libsite-packageskivylang.py", line 1872,
 in apply
    self._apply_rule(widget, rule, rule)
  File "C:Program FilesPython27x64libsite-packageskivylang.py", line 1985,
 in _apply_rule
    self.apply(child)
  File "C:Program FilesPython27x64libsite-packageskivylang.py", line 1872,
 in apply
    self._apply_rule(widget, rule, rule)
  File "C:Program FilesPython27x64libsite-packageskivylang.py", line 1883,
 in _apply_rule
    assert(rule not in self.rulectx)
AssertionError
Press any key to continue . . .

I found that the error is generated by the function name Layout().
In fact, if i change the name of the function the problem does not appear.
I know it is not a very significant problem, but since I found it seems correct report that here.

@Tungsteno74 could you post your kv with indentation?

I'm trying but markdown code snippet don't work well here and idk.

Ok done. Sorry but is the first time that i post on GitHub.

You have to indent the content of <Layout>, your kv is invalid.
<Layout>:
    orientation: "vertical"
    BoxLayout:
        Label:
            text: "hello"

It is a transcription error. Now is all right.
Sorry again for that. :sweat_smile:

Layout is a core widget, use another name

I think you're right.
It might be useful to specify in the documentation?
I say this because it only happens if you use Layouts. However, not happen,  if you use basis widgets (buttons, labels, etc.).


Routes with path parameters can't be called by the RPC client

Context
The current validation of inputs happens inside the router helper function, and the schema validation is done against either the parsed query or the parsed body depending on the type of OperationType (either QueryOperation or MutationOperation for now).
Then, the router returns a Hono instance with typed endpoints to allow the RPC client to pass directly the query/body data inside $get or $post without getting Typescript mad.
But as the Hono server still expects
{
  query: {
    name: string
  }
}

and not
{
  name: string
}

so we have to proxy the RPC client to reshape the argument of $get and $post (as Hono expects it) before sending the request.
The issue
As we manually edit the shape of what's passed into $get or $post, we prevent the use of param.
And even if we passed this
client.post[":user_id"].create.$post({
  name: "Josh",
  param: {
    user_id: "123"
  }
})

it would still end up being sent as the following payload thanks (or not) to the proxy of the RPC client.
client.post[":user_id"].create.$post({
  query: {
    name: "Josh",
    param: {
      user_id: "123"
    }
  }
})

This is pretty annoying as it makes every path with parameters not callable by the RPC client.
I haven't given much thought to a potential solution, but those are the two ideas that came up off the top of my head:

Implement the more native approach with validator() or zValidator() and remove the proxy on the RPC client
Infer path parameters in the type of the router and add support for them in the proxy of the RPC client

I would opt for the first solution, as zValidator() is great and already supports every validation targets (json, query, header, param, cookie and form).
What do you guys think? I can work on a PR if needed ✌

interesting thought, how would the ideal RPC call from the FE or server component look like in this case? Afaik in trpc you'd just pass the params instead as body request props


Resource based authorization is broken in .NET Core 2.0

Original thread: blowdart/AspNetAuthorizationWorkshop/#23
With the various changes to authentication and authorization made in 2.0, the current pattern for performing resource based authorisation no longer works.
For example, previously resource based authorization could be performed using code similar to:
    public class DocumentController : Controller
    {
        IDocumentRepository _documentRepository;
        IAuthorizationService _authorizationService;

        public async Task<IActionResult> Edit(int id)
        {
            var document = _documentRepository.Get(id);

            var authorizationResult = await _authorizationService.AuthorizeAsync(User, document, new EditRequirement());

            if (authorizationResult.Succeeded)
            {
                return View(document);
            }
            else
            {
                return new ChallengeResult();
            }
        }
    }

In 1.X, returning a ChallengeResult would either result in a 401 (and redirect to login page) or a 403 (and redirect to access denied page).
In 2.0, returning a ChallengeResult always result in a 401 (And redirect to a login page). If the user is already logged in (and just doesn't satisfy the handler requirements) then they will be stuck in a redirect loop.
@HaoK Suggested the correct approach is to use the IPolicyEvaluator instead of the IAuthorizationService. Unfortunately:

The policy evaluator is mostly a shared service for frameworks to use, as you've discovered, its currently not really designed to be used in the views, we can definitely expose this in a more friendlier way

A naive attempt to implement the required behaviour results in code that looks something like:
public class DocumentController : Controller
{
    IDocumentRepository _documentRepository;
    IPolicyEvaluator _policyEvaluator;

    public DocumentController(IDocumentRepository documentRepository,
                                IPolicyEvaluator policyEvaluator)
    {
        _documentRepository = documentRepository;
        _policyEvaluator = policyEvaluator;
    }

    public async Task<IActionResult> Edit(int id)
    {
        var document = _documentRepository.Get(id);

       // Everything below here to do resource-based auth?!
        var scheme = "SOMETHING?!";

        var effectivePolicy = new AuthorizationPolicy(new [] {new EditRequirement()}, new [] {scheme});
        var user = User;
        var authenticateResult = await _policyEvaluator.AuthenticateAsync(effectivePolicy, HttpContext);
        HttpContext.User = user; // work around issue https://github.com/aspnet/Security/issues/1341

        var authorizeResult = await _policyEvaluator.AuthorizeAsync(effectivePolicy, authenticateResult, HttpContext, document);

        if (authorizeResult.Challenged)
        {
            return new ChallengeResult(effectivePolicy.AuthenticationSchemes.ToArray());
        }
        else if (authorizeResult.Forbidden)
        {
            return new ForbidResult(effectivePolicy.AuthenticationSchemes.ToArray());
        }

        return View(document);
    }
}

This is clearly more effort than it should be, and it's not obvious if this is the correct approach.

You can no longer just pass in an IAuthorizationRequirement, you have to provide a Policy
You need to know the auth scheme for your new policy
AuthorizeAsync requires an AuthenticateResult so you either have to manually create one or call AuthenticateAsync as above
If you want to do imperative auth without a resource (e.g. in Razor views), you need to pass in a null resource object (presumably?)

This could likely all be handled by creating a simple wrapper to use for imperative auth, that could be injected into views and controllers for this situation.
At the very least, explicit guidance needs to be provided on handling this situation in ASP.NET Core 2.0

This seems related to https://github.com/aspnet/Security/issues/1341
How is this not a big deal.
Fix the authz API before shipping 2.0!

The tutorial that is broken is doing things in a weird way (i.e. no login page, not using [Authorize])

The above DocumentController is weird? I disagree.
I generally stay away from the [Authorize] and prefer the imperative usage of the authz APIs.

@HaoK it's not weird and this is actually pretty broken. FWIW I'm glad the challenge behavior is gone but all of that logic has now moved into the policy evaluator which means using the authz service imperatively is harder 😢 .
We might need to do something here.

@andrewlock Why can't this logic look like this:
public class DocumentController : Controller
{
    IDocumentRepository _documentRepository;
    IAuthorizationService _authorizationService;

    public async Task<IActionResult> Edit(int id)
    {
        var document = _documentRepository.Get(id);

        var authorizationResult = await _authorizationService.AuthorizeAsync(User, document, new EditRequirement());

        if (authorizationResult.Succeeded)
        {
            return View(document);
        }
        else if(User.IsAuthenticated)
        {
           return new ForbidResult();
        }
        else
        {
            return new ChallengeResult();
        }
    }
}

Yeah so things are basically okay when doing AuthZ against context.User (via automatic auth scheme)
Things start start getting pretty nasty once you try to specify some other (passive) auth schemes in your policy which brings in the the 401/403 and needing to mimic the authentication logic that the evaluator does.

@davidfowl that will work, it's option 2 that he mentioned in the original issue https://github.com/blowdart/AspNetAuthorizationWorkshop/issues/23 for how to get things working
I asked him to open this issue since we should expose the evaluator logic in a friendlier way

But I think imperatively doing AuthZ just means the callee has to do AuthN themselves, using context.User you've already shown above.
Doing explicit authentication is just:
        var document = _documentRepository.Get(id);

        var authenticateResult = await context.AuthenticateAsync("YourAuthScheme");
        if (authenticateResult != null && authenticateResult.Succeeded) {
           var authorizationResult = await _authorizationService.AuthorizeAsync(authenticateResult.User, document, new EditRequirement());
            if (authorizationResult.Succeeded)
            {
                return View(document);
            }
            return new ForbidResult();
        }
        return new ChallengeResult("YourAuthScheme");

Wrapping the requirement into a policy and using the IPolicyEvaluator is basically equivalent to that.

We could consider a sugar overload to IPolicyEvaluator like:
   Task<PolicyAuthorizationResult> IPolicyEvaluator.AuthorizeAsync(string authenticationScheme, HttpContext context, object resource, IEnumerable<IAuthorizationRequirements> requirements)

So then once we had that it'd just be:
public class DocumentController : Controller
{
    IDocumentRepository _documentRepository;
    IPolicyEvaluator _eval;

    public async Task<IActionResult> Edit(int id)
    {
        var document = _documentRepository.Get(id);

        var authorizationResult = await _eval.AuthorizeAsync("YourAuthScheme", HttpContext, document, new EditRequirement());

        if (authorizationResult.Succeeded)
        {
            return View(document);
        }
        else if (authorizationResult.Forbidden)
        {
           return new ForbidResult("YourAuthScheme");
        }
        else
        {
            return new ChallengeResult("YourAuthScheme");
        }
    }
}

I see TBH this code https://github.com/aspnet/Security/issues/1343#issuecomment-318999978, looks pretty simple. The sugar method doesn't save much here. You still end up repeating the scheme..(which I think is nice and explicit)

I actually think the sugar method is quite a bit nicer - everywhere else it seems assumed that authentication has already occurred, so it seems odd to need to explicitly authenticate again here. Also, do we have to specify the auth scheme? It's optional everywhere else right, and I presume most people are only going to have one scheme?
@davidfowl If it's simply a case of the logic checking User.Identity.IsAuthenticated, then that's fine by me, and makes sense I think. But I'd definitely prefer a sugar method (preferably without having to specify the scheme), over having to duplicate the code in #1343 (comment) in every action that uses resource based auth

actually think the sugar method is quite a bit nicer - everywhere else it seems assumed that authentication has already occurred, so it seems odd to need to explicitly authenticate again here.

Except, you haven't authenticated if the scheme you've chosen to imperatively authenticate against isn't the default scheme. Any other scheme requires an explicit call to AuthenticateAsync, which IMO is clearer.

Also, do we have to specify the auth scheme? It's optional everywhere else right, and I presume most people are only going to have one scheme?

You need to specify the auth scheme if you have more than one and you don't want the default scheme. Most people will a default scheme, but it's very common to have more than one scheme .e.g Twitter, Google, and Cookies.

@davidfowl If it's simply a case of the logic checking User.Identity.IsAuthenticated, then that's fine by me, and makes sense I think.

It is. That's why I see zero value in the sugar method. Unless you're trying to authenticate against multiple schemes and merging principals (https://github.com/aspnet/Security/blob/a4458191c700437a00603116ad92633d1590319d/src/Microsoft.AspNetCore.Authorization.Policy/PolicyEvaluator.cs#L37-L45) this helper code doesn't help much...

But I'd definitely prefer a sugar method (preferably without having to specify the scheme), over having to duplicate the code in #1343 (comment) in every action that uses resource based auth

You can't though, the scheme needs to be specified if you're doing imperative auth and want to get the non default scheme's claims principal.

So is the conclusion that we are happy with where things stand for now for imperative authZ (and can close this issue)?

Other than updating @blowdart docs to include the new example above

We'll make some improvements to this area in https://github.com/aspnet/Security/issues/1348 (details to be filled in).

@andrewlock Does resource based auth in 2.0 still fit for "I think the simple answer is really to only use resource-based authorisation when you have to." excerpt from https://andrewlock.net/resource-specific-authorisation-in-asp-net-core/?


Make scann range search results more accurate

Related #171
Range search's recall of ScaNN is poor due to quantization. Enlarge radius to take more candidates into consideration.

/hold

close this, need further investigation


Make space-efficient PDF files with page numbers

As a refugee helper with a simple desktop printer, I need the print versions to be on the smalles possible number of pdf pages. I also need page numbers to be included to prevent mixups

In my view, this should be dealt with by the printer, not by the html file
I also do think that there is no need to generate a pdf. Printing the html and then photocopying the sheets should do the trick


Fix MP4 video output in save_video_as_grid_and_mp4

Summary:
This PR addresses a critical issue in the save_video_as_grid_and_mp4 function when running video_sampling.py, where video files intended to be saved as MP4 were being mishandled, leading to crashes when writing to MP4 files. The function has been updated to correctly leverage imageio and ffmpeg for MP4 video creation.
Changes:

FFmpeg Integration:

Added a system-level check for FFmpeg availability using shutil.which("ffmpeg"). If FFmpeg is not installed, a clear runtime error is raised, prompting the user to install it.
Incorporated a check to ensure that the imageio-ffmpeg package is properly installed and functioning in order for the MP4 video encoding to proceed without issues.

Video Encoding with Imageio:

Corrected the writer format in save_video_as_grid_and_mp4 by ensuring the use of the ffmpeg format and libx264 codec for MP4 output.
Implemented a confirmation message to notify the user that the video has been successfully saved to the specified path.

Dependency Update:

Updated requirements.txt to include imageio[ffmpeg]==2.26.1, ensuring that all required video processing dependencies are installed when setting up the environment.

How to Test:

Ensure FFmpeg is installed on your system and accessible via your system’s PATH.
Run the application with the updated code. If FFmpeg is not available, a runtime error will prompt you to install it.
After video sampling, check if the resulting MP4 is correctly created in the specified folder and playable.

Fixed the check method on imageio[ffmpeg] avaialbility; previous wasn't applicable after all. Feel free to either include or exclude the checking inside the function, but at the very least the imageio[ffmpeg] pip package should be in the requirements, since it hadn't been included all in any of the install scripts.

For scripts/sampling/simple_video_sample.py vscode also can not view the mp4 file. after downgrade to imageio[ffmpeg]==2.26.1 it works fine.

@RahulVadisetty91 @xijiu9 I've addressed your comments:

Refactored the device variable to use the global declaration consistently (sorry!)
The version I proposed uses imageio[ffmpeg] 2.26.1 as suggested.

Feel free to chime in if you think it needs something more.


valid and test about ACDC

Hi, i have some questiones about ACDC:

why can do validation and test with the similar way of training? cause i saw you use batch size=1, and "test_single_volume" procedure
can you share the version of test that outputs the values of LV MYO RV?

thanks a lot. your work help me  a lot!

hi @kathyliu579.

the validation and test are actually conducted in two different ways (they are all embedded in the training process tho). validation is conducted similar to training, which accepts a 2D slice (batch_size=1 here means 1 slice one time) as input and evaluates its DSC with its 2D gt. validation is used for model selection so we just use this simple implementation. test, however, is much more formal since we have to compare with previous works. in this field, each 3D medical image is viewed as a single test case, so we must computes the DSC of the entire 3D image (batch_size=1 here means 1 3D image one time and a single 3D image may contain many slices) as the final result and thats exactly what "test_single_volume" does.
Current the code already outputs the values of LV MYO RV. They are marked as class 1, class 2 and class 3 in the training log.

thanks Dootmaan. i carefully check the code. i realized what you say now. but for 1 th, i still has some comfusion.
Why test (computes the DSC of an entire 3D image) will abtain a higer DSC? like valid get 0.84, but test can get 89

theoretically it is possible. however usually we will train the model several times to find the one with highest validation score. such model may be overfitted to validation set and tends to perform a little worse on test set. however, if the test set have very similar distribution with validation set or the model you choose happens to be more suitable for the test set, then the situation you described might just happen.

This issue is closed since no further activity has happened for a while.


Bug 2214120: Show Feature highlights in CNV 4.13 instead of 4.10

📝 Description
Fixes:
https://bugzilla.redhat.com/show_bug.cgi?id=2214120
Jira:
https://issues.redhat.com/browse/CNV-29725
Change text "OpenShift Virtualization 4.10 Highlights" to "OpenShift Virtualization 4.13 Highlights",
update the link to https://docs.openshift.com/container-platform/4.13/virt/virt-4-13-release-notes.html#virt-4-13-new
(as it was suggested by me and approved by our PM).
🎥 Screenshots
Before:

After:

@avivtur @metalice @pcbailey @upalatucci @vojtechszocs please review

/lgtm


Performance Test Script Creation for the "QA Module" - Export and Open Submission Window

1. Functionality Testing:
Test the functionality of Export and Opening the submission window for the QA & Cert. Module.
2. Script Creation:

Create a "Performance" test script in JMeter for testing the Export and Submission window opening functionality for the QA & Cert. Module.
Ensure the script is created successfully without any errors.

3. Purpose:
By manually Export and Opening the submission window for QA & Cert. Module - it should display the following status:

Evaluation Status: Needs Evaluation
Submission Status: Resubmission Required

4. Related Ticket: #6388

JMeter script for the QA module is currently in-progress based on the manual test case below.
This manual test case covers the functionalities for QA to open up the Submission window, Import Historical Data, Evaluate and Submit.
6387_Test Case for QA_Open submission window_Import_Evaluate_Submit.docx

The following .JMX script for the "QA Module" (Import, Evaluate, & Submit) was created in JMeter.
It has been Parameterized, and ran successfully with a single user as of 10/10/24.
Here is the .JMX script in ZIP Format:
Updated - 6387_PERF_QA_564 Curtis_1_test22_v.8.zip


[5.2] Sometimes Validation Fix & "JIT Compile" of Rules

This adds to #12738 and fixes a similar bug of #12717. The sometimes call would not work on array validators.
This also compiles the rules when they are needed mainly when getRules() is called or passes().

@TomKita Can you please show a case where sometimes rule won't work with arrays? I tested with the following:
Validator::make(
    [ 'foo' => [['name' => 'first'], ['title' => 'second']]  ],
    [ 'foo.*.name' => 'sometimes|required' ]
);

This targets resolving issues when using sometimes() method. It is similar to what was happening to setData before your fix #12738.

Ok I've taken a deep look into the case and found the problem you're trying to fix. There are multiple entry points where you can pass rules to the validator:

Constructor
setRules()
sometimes()
each()

The constructor already calls setRules(), and since https://github.com/laravel/framework/pull/12738 the method is properly setting the given rules.
Also each is taken care of and tested very well, however as you noted sometimes doesn't take into consideration attributes with asterisks, it doesn't explodeRules and just causing the raw attribute to be passed to the $rules class property as it is (with the asterisk).
You solution fixes the issue however I believe it's more simpler than that, all what's needed is to check for the presence of an asterisk and explode instead of merge:
if (Str::contains($key, '*')) {
    $this->explodeRules([$key => $rules]);
} else {
    $this->mergeRules($key, $rules);
}

On a side note I don't think there's a purpose for the loop here:
/**
 * Add conditions to a given field based on a Closure.
 *
 * @param  string  $attribute
 * @param  string|array  $rules
 * @param  callable  $callback
 * @return void
 */
public function sometimes($attribute, $rules, callable $callback)
{
    $payload = new Fluent($this->attributes());

    if (call_user_func($callback, $payload)) {
        foreach ((array) $attribute as $key) {
             // THIS LOOP
        }
    }
}

The parameter is already defined as a string @param  string  $attribute, not sure if it's intended or it needs to be fixed. @taylorotwell

Since this is apparently not the correct approach, @themsaid do you have time to submit a correct fix?

@taylorotwell @themsaid  Why would this not be the correct approach? Instead of checking in every entry point for new validation rules and recompiling then. It does it at the time of access. So instead of having the same check in
Constructor
setRules()
sometimes()
each()
It is only done in getRules

@TomKita but then $this->rules won't have the correct rules set all the time!

@themsaid do they have to be? They can't be accessed publicly since they are protected.

If $this->rules won't hold the correct values it may cause bugs later on, I guess anyone trying to contribute to the Validator will expect the rules attribute to hold all the rules.

Ok thank you for the response.


Add examples files

Add a collection of fixtures to point react-codesandboxer at, so examples can reference back to the repo, and testing becomes easier.
Fixtures needed:

entrypoint, no imports
entrypoint w/ absolute imports
entrypoint w/ relative imports
entrypoint w/ absolute + relative imports
entrypoint w/ relative imports that has its own abs + rel imports
entrypoint importing an image (possibly of each of the image formats)
entrypoint importing two files that each import the same file (dedupe check)

With this we can set up full tests for all our importing shenanigans

Fixed


Fix indentation for multi-line strings in script to convert flows to use ERB templates for questions

Previously only the first line was indented.

Looks good to me.


Enable the configuration API to connect and configure with a service account

Created by: @bayegan Jan 24 2022 at 22:01 CET
Last updated: Jul 19 2022 at 10:34 CET
ClickUp ID: IK-2114
Create a script that can later be used as part of a unit test, that creates a completely new Customer with the bear minimum settings, that will enable the Configuration API, with a Service Account, to connect.
Acceptance criteria:
Create new customer (call the customer "IndyKiteOne" - the very first customer in staging and production)
Link it to the unlimited plan (so no limitation what the customer can have access to)
Create a Digital Twin Service Account with the Editor role on that Customer
Create credentials for it connect, in order to start configuring
Verify that the script works by testing with
Cypher can be later used for unit testing

Commented by: @bayegan Jan 24 2022 at 22:01 CET
cc @marvinkite @yetizer

Commented by: @yetizer Jan 25 2022 at 10:28 CET
@indyboox as far as I can tell @marvinkite is working on it - he created a tool that potentially creates customer and then creates service account with the given permissions

Commented by: @marvinkite Jan 28 2022 at 13:08 CET
It's working and the command is now added to  cli/cmd/customer.go  The PR is still open  but ready to merge in few.


crash with string "main"

When launching fabric i get this crash error

The game crashed whilst initializing game
Error: java.lang.RuntimeException: Could not execute entrypoint stage 'main' due to errors, provided by 'the_aether'!
Exit Code: -1

Heres the pastebin of the entire log
https://pastebin.com/Y7PxsvTn

You need geckolib. Here's the install page
https://www.curseforge.com/minecraft/mc-mods/geckolib-fabric


Explore test-target-for-shards with extra features

Author the user story for this feature
As a user, I want to be able to make use of test-target-for-shards so I can specify tests to run in specific shards and have the possibility of running all other tests available assigned automatically to shards like "smart-flank".
Lets explore and see if first its possible due to making use of the Gcloud specific test-target-for-shards option.

More info


TootleSample does not properly handle 'g' lines in obj files

If the source obj file has more than one 'g ' line (mesh group), these will be handled strangely in the output obj. You'll end up with several contiguous group lines in the output with no faces defined within them, like so:
g Group1
g Group2
g Group4
This is because TootleSample completely suppresses, re-orders, and re-prints all of the 'f ' lines in a separate pass, but still prints through the mesh group lines from the original file.
Some options:
Just ignore / don't print 'g' lines at all in the output, and end up with one big mesh.
(More complex) Optimize each mesh group separately so that faces don't get re-ordered across 'g ' boundaries.

Wonder if replacing the OBJ reader wholesale with https://github.com/syoyo/tinyobjloader should be done at the same time?

That is even better.  The TootleSample was initially written as a simple example code for how to use the tootle library.


Implement the Definition Extractor (generative facet)

Once the n-gram and Profile HMM models have been created, this module combines the generative probabilty of a sentece of the sentence on both models to measure if it is a definition

This issue, if we just use the bigram softpatterns model, might be outdated


Cassandra datacenter awareness and additional metadata creation options

Currently metadata db is created in a very simple way with simple strategy, etc. Review.

Superseded by #145


Support dev mode with hot reloading

During development, it can be useful to have hot reloading of a worlds components and systems
We can add an additional flag: sozo dev
When running in dev mode, the build script should run until interrupted. The logic should implement a loop that watches the project source, when a component / system is created / updated, it should trigger a reload of the language db, similar to the language server:
https://github.com/starkware-libs/cairo/blob/d80d29b52f8972f63ceb490567b26172245e95ff/crates/cairo-lang-language-server/src/lib.rs#L495
After compilation, the component / system should be added / updated in the world using the provided rpc and account.
Eventually, we should trigger updates on the client too, but for now, lets focus on the build -> migrate loop

Can I work on this issue?

I have managed to trigger a build when Scarb.toml or a file with extension cairo is modified, renamed, removed.
Now I'm trying to understand which conditions are required to trigger a migrate: should I check for classhash differences to ensure a migration is needed?

@ptisserand how are you triggering build? do you mind sharing your implementation so far?

@tarrencev : Sure, here is my wip branch: https://github.com/ptisserand/dojo/tree/feat/dev-mode-hotloading
I'm using notify to check for file modifications in $(dirname manifest_path) tree.

@tarrencev : Sure, here is my wip branch: https://github.com/ptisserand/dojo/tree/feat/dev-mode-hotloading
I'm using notify to check for file modifications in $(dirname manifest_path) tree.

Ok cool!
So we will want to compile the repo similar to how the language server does, then have an instance of the db where we can incrementally compile based on file changes. It is basically the same thing that is done here:
https://github.com/starkware-libs/cairo/blob/d80d29b52f8972f63ceb490567b26172245e95ff/crates/cairo-lang-language-server/src/lib.rs#L495
Once we have that, when a component or system class hash changes, we should call register_system or register_component
https://github.com/dojoengine/dojo/blob/dcd1dddbe92d33540eaf33963f2fa35a669a266d/crates/dojo-client/src/contract/world.rs#L103

maybe it's worth adding web socket support on katana for this.

maybe it's worth adding web socket support on katana for this.

Hmm how do you imagine that working? I think calling execute directly is probably fine for this

Hmm how do you imagine that working? I think calling execute directly is probably fine for this

If there are frequent updates, then with web socket we can somewhat reduce the overhead of opening up new connections. But i guess there wouldn't be that much frequent changes like in web dev for example, so the overhead is probably not significant at all.
Anyway, i still think it'd be useful to have ws support on katana.

Hi, I'm still working on this issue and I'm wondering if sozo migrate logic should be duplicated.
sozo migrate logic already handle computing world diff and declaring/deploying contracts if needed.
So I feel I'm going a bit too hackish...

@tarrencev @kariy any comment on this ?

Hi, I'm still working on this issue and I'm wondering if sozo migrate logic should be duplicated.
sozo migrate logic already handle computing world diff and declaring/deploying contracts if needed.
So I feel I'm going a bit too hackish...

@tarrencev @kariy any comment on this ?

Hi, I'm still working on this issue and I'm wondering if sozo migrate logic should be duplicated.
sozo migrate logic already handle computing world diff and declaring/deploying contracts if needed.
So I feel I'm going a bit too hackish...

Hey @ptisserand sorry I missed this message. I think some level of duplication is fine for a draft pr, then we can work on refactoring it down to share logic. Do you mind sharing what you have so far?


PerceptualDiff and Python 3.4.1 exception

Have some prototype tests written using Needle and Python 3.4.1. When the tests run with the default image comparison setting they run fine. When I added PerceptualDiff to the tests, an ugly exception gets thrown coming out of PIL.
Traceback (most recent call last):
File "D:\Temp\TestDev\Needle_Tests_Workflow\Needle_Tests_Workflow\Needle_Tests_Workflow.py", line 42, in test_loginPage
self.assertScreenshot('body', 'body')
File "D:\Python34\lib\site-packages\needle\cases.py", line 128, in assertScreenshot
pass
File "D:\Python34\lib\contextlib.py", line 66, in exit
next(self.gen)
File "D:\Python34\lib\site-packages\needle\cases.py", line 198, in compareScreenshot
self.engine.assertSameFiles(output_file, baseline_file, threshold)
File "D:\Python34\lib\site-packages\needle\engines\perceptualdiff_engine.py", line 16, in assertSameFiles
width, height = Image.open(open(output_file)).size
File "D:\Python34\lib\site-packages\PIL\Image.py", line 2255, in open
prefix = fp.read(16)
File "D:\Python34\lib\encodings\cp1252.py", line 23, in decode
return codecs.charmap_decode(input,self.errors,decoding_table)[0]
nose.proxy.UnicodeDecodeError: 'charmap' codec can't decode byte 0x9d in position 49: character maps to

It looks like this was fixed in the source last July:
https://github.com/bfirsh/needle/commits/master/needle/engines/perceptualdiff_engine.py
Is it possible that you have a version earlier than 0.2.2 installed?

I've got 0.2.2 installed according to PIP - I initially installed maybe 3 months ago.

It looks like that fix was pushed after the 0.2.2 release, so we'd need to cut a new release. I could do that in the next couple of days unless someone beats me to it :)

I've just released version 0.2.3. Could you please update and check if that fixes it? Thanks!

Will do first thing tomorrow - thanks !

Looks good! Thanks so much for pushing an update that quickly, it is appreciated!

Great, thanks for checking!


Release Tags

Add information on how release tags are taken care of in all the plugins.

We have automatic tagging during releases since https://github.com/opensearch-project/opensearch-build/issues/378


custom import tokens follow up and cleanup

after custom import tokens is added, audit app for any issues rendering these assets
they shouldn't be included in portfolio balances and never should be converted to fiat values

depends on https://github.com/shapeshift/web/issues/7213


Stream binding operator does not work in two way mode for TextBox, NumericUpDown

Describe the bug
I might be misunderstanding how it is supposed to work, but when i bind the Text property of Text or Value property of NumericUpDown in two way mode to a Subject, using stream binding operator, i get no updates in the viewmodel when changing the state of the control on the ui. Please see the attached example.
However, it works very well for ScrollView.Offset property.
am i getting something wrong?
To Reproduce
Could be reproduced easily in the avalonia starter template.
Mainwindow.xaml:
<Window xmlns="https://github.com/avaloniaui"
        xmlns:x="http://schemas.microsoft.com/winfx/2006/xaml"
        xmlns:vm="using:AvaloniaApplication1.ViewModels"
        xmlns:d="http://schemas.microsoft.com/expression/blend/2008"
        xmlns:mc="http://schemas.openxmlformats.org/markup-compatibility/2006"
        mc:Ignorable="d" d:DesignWidth="800" d:DesignHeight="450"
        x:Class="AvaloniaApplication1.Views.MainWindow"
        x:DataType="vm:MainWindowViewModel"
        Icon="/Assets/avalonia-logo.ico"
        Title="AvaloniaApplication1">

    <TextBox Text="{Binding Foo^, Mode=TwoWay}"></TextBox>

</Window>

MainwindowViewModel.cs:
using System;
using System.Reactive.Subjects;
using ReactiveUI;
using Console = System.Console;
using System.Reactive.Linq;
using System.Reactive;

namespace AvaloniaApplication1.ViewModels;

public partial class MainWindowViewModel : ReactiveObject
{
    private BehaviorSubject<string> foo = new("hello");

    public BehaviorSubject<string> Foo => foo;

    public MainWindowViewModel()
    {
        foo.Subscribe(x => Console.WriteLine(x));
    }
}

Everything else is left unchanged in the starter template.
I have only added ReactiveUI - 20.1.63 package.
I see "hello" appear in th econtrol but then I expect values printed to the console when i change the value of the TextBox on the ui.
Thanks!
Expected behavior
Just as if i have bound the Offset property of a ScrollViewer, and listened for updates, i get console messages printed upon change.
Avalonia version
11.2.1
OS
Linux
Additional context
No response

I don't think stream operator ever supported two-way bindings (i.e. assuming it should write back to IObserver/Subject).
Implementation also only refers to one-way listening: https://github.com/AvaloniaUI/Avalonia/blob/master/src/Avalonia.Base/Data/Core/Plugins/IStreamPlugin.cs#L8

Thanks for checking, tha explains a lot!  But then the question arises, how Scrollviewer.Offset writeback works?


Suggestion

It would be sweet if this app could also create tickets for DSiWare

It already does this.

I had to restore a backup of CTRNAND, so I lost all the tickets for the apps I had installed. I found this app, so I downloaded it and ran it, and all my 3ds titles appeared on my home screen again, but none of the DSi titles. I verified that the titles were installed by checking TWLN, and they were all there. Any idea why it didn't install tickets for the DSi apps?

It can only create tickets for titles that are considered "installed". This is likely stored in title.db in CTRNAND. Because an older version was restored, the system does not know that these titles exist, therefore faketik will not find them.

The reason this didn't happen to SD titles is because title.db is also stored on the SD card. The easiest method to fix missing DSiWare titles is to back up save files from twln and re-install.

ah okay, that makes sense. The way i worked around it was going into TWLN from GodMode9 and then I just packaged all the DSi apps to a CSI file, then I used FBI to install them all, and now they're all there

README will be updated containing information on missing titles.


Migrate to frequenz-api-common v0.6.1

What's needed?
Once frequenz-api-common v0.6.1 is released, the Microgrid API has to be updated.
Refer to the milestone to see if this issue can be unblocked: https://github.com/frequenz-floss/frequenz-api-common/milestone/20
Proposed solution
No response
Use cases
No response
Alternatives and workarounds
No response
Additional context
No response

Unblocked since common API v0.6.1 has been released: https://github.com/frequenz-floss/frequenz-api-common/releases/tag/v0.6.1.


Add git dashes separator to some "log" and "diff" commands (#23606)

Backport #23606 by @wxiaoguang
Reference: https://github.com/go-gitea/gitea/issues/22578#issuecomment-1444180053
Credits to @tdesveaux , thank you very much for catching the problem. If you'd like to open a PR, feel free to replace this one.
Git reports fatal errors for ambiguous arguments:
fatal: ambiguous argument 'refs/a...refs/b': unknown revision or path not in the working tree.
        Use '--' to separate paths from revisions, like this:
        'git <command> [<revision>...] -- [<file>...]'

So the -- separator is necessary in some cases.

🤖 🎺


About performance pressure moquette performance?

1.Original ecology "moquette" maximum number of connections?
2.Moquette test methods and tools are there?
3.The current "moquette" What place can be optimized?

Why not set up a discussion group together to express their views on the inside?

The discussion group  already exists check out the ML to open sch a discussion. Issues are just to report FR (already discussed in the ML) or bug report.
Andrea


doc: kusion_kubernetes generation guide

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

[X] N
[ ] Y

2. What is the scope of this PR (e.g. component or file name):

doc: kusion_kubernetes generation guide
3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

[ ] Affects user behaviors
[ ] Contains syntax changes
[ ] Contains variable changes
[ ] Contains experimental features
[ ] Performance regression: Consumes more CPU
[ ] Performance regression: Consumes more Memory
[ ] Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

[ ] N
[ ] Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

[ ] Unit test
[ ] Integration test
[ ] Benchmark (add benchmark stats below)
[ ] Manual test (add detailed scripts or steps below)
[ ] Other

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
224 unchanged lines in 1 file lost coverage.
Overall coverage increased (+0.03%) to 67.084%

Files with Coverage Reduction
New Missed Lines
%

pkg/swagger/generator/model.go
224
58.47%

Totals

Change from base Build<PHONE_NUMBER>:
0.03%

Covered Lines:
1983

Relevant Lines:
2956

💛  - Coveralls


AWS Autodiscovery plugin

closes #67

Coverage remained the same at 81.455% when pulling 798ccecfaaf15e319ab32ebf82fc7c7e0834b185 on aws-autodiscovery into 94a9f822b685264c20f1b2642e14fc8ec1dd82a9 on develop.

Coverage remained the same at 81.455% when pulling 49521e55201a00a122bd159c547f1cf940a315f6 on aws-autodiscovery into 1b9778da7cc1bba2cb538b916861e8d6a474b8d0 on develop.


Revert "plugins/cilium-cni: update to CNI spec version 1.0.0"

This reverts commit e44be02cad7c90a77c8e133d74d9e70cd1243386.

/ci-aks


upgrade web phone SDK

Coverage increased (+0.01%) to 39.655% when pulling 41cd6975825a8595d8740593569bfda6b4bedf54 on embbnux:feature/update-web-phone into 324d3eccc172fd6f3db70b7c563ecad1b32770fd on ringcentral:master.


Enhancing USAGE.md Documentation

We're looking to improve our USAGE.md document to make it more helpful for new users. This documentation is crucial for guiding users in effectively utilizing our project.
Tasks Required

Review the current USAGE.md file.
Enhance the document with clear, step-by-step usage instructions.
Include additional examples and best practices.
Ensure that the language is clear and accessible to both beginners and advanced users.

Contribution Guidelines
Please refer to our CONTRIBUTING.md file for guidelines on contributing. Remember to fork the repository, create a new branch for your work, and submit a pull request once you're done.

updated this by creating install and add supplements in readme


don't pass the context all over the place

Instead, use TLS for the context.

Look at what dioxus does for state handles.


Shadows suddenly disappeared

Describe the bug
Shadows used to work fine but they've suddenly disappeared, even when using the material that comes with crest. I'm using a camera with forward rendering, shadows are enabled in the material and the sim settings are linked. I've tried it in another scene where it used to worked too.
Screenshots / video

Log
No errors/warnings.
Versions
2019.3.0f3 Built in RP
Platform

Editor and standalone
Windows

Hardware
GTX 1070

Thanks for reporting. What has changed? Upgrading Unity or Crest?

I haven't upgraded anything, the shadows just suddenly disappeared from one day to the next. Is there anything else that could affect the shadows like quality settings or plugins?

Have you tried viewing the shadow data in the ocean debug GUI? Or have you checked the frame debugger?

Is there anything else that could affect the shadows like quality settings or plugins?

Not that I can think of other than shadows being enabled.

the shadows just suddenly disappeared from one day to the next

Have you tried clearing the Library folder or anything like that?

Just to add, you might compare shadow settings in your project with those in the example project

Have you tried viewing the shadow data in the ocean debug GUI? Or have you checked the frame debugger?

I don't see an option to view the shadow data, there's just "Process Shadows" in the menu on the left.

Have you tried clearing the Library folder or anything like that?

I'd prefer not removing the whole folder since the project I'm working on is huge, it would take ages to rebuild. Is there anything specific I can try removing?

Just to add, you might compare shadow settings in your project with those in the example project

I've compared them and they're exactly the same. I did notice the shadow debug toggle missing in the GUI even though "Create shadow data" is ticked.

You need to click the create shadow option on the ocean renderer component

It's ticked, here are my settings:

I'd prefer not removing the whole folder since the project I'm working on is huge, it would take ages to rebuild. Is there anything specific I can try removing?

We'll leave it for now.
How old is your version of Crest?
It looks like the shadow sim is being disabled at runtime. Is Create Shadow Data checked when entering play mode? If your version of Crest is before when the ocean is running in edit mode (pretty certain it is), then you should see components for each simulation attached to the ocean renderer game object; can you see one for shadows in play mode? Also, if you look at the following file, there should be a Start method. There might be some places where it exits early without logging:
/Assets/Crest/Crest/Scripts/LodData/Shadows/LodDataMgrShadow.cs

Is Create Shadow Data checked when entering play mode?

Yes it's still checked.

If your version of Crest is before when the ocean is running in edit mode (pretty certain it is)

Yeah I think it is, I didn't even know that was added. I only keep an eye on the releases so that's the version I'm using (Feb 2020 Update)

can you see one for shadows in play mode?

No I don't see one.

Also, if you look at the following file, there should be a Start method. There might be some places where it exits early without logging:

All exceptions seem to be caught as far as I'm seeing, but maybe i'm not seeing any errors because it's not being added to the ocean gameobject.

I only keep an eye on the releases so that's the version I'm using (Feb 2020 Update)

We have stopped producing releases. Updates will need to be downloaded from the master branch. It will be a big upgrade since 2019.4 is now a requirement.

No I don't see one.

Not sure what could be causing it. The create function is pretty simple and you would see an error. Line 185 with the following line in OceanBuilder is where that component gets created:
ocean._lodDataShadow = LodDataMgr.Create<LodDataMgrShadow, SimSettingsShadow>(ocean.gameObject, ref ocean._simSettingsShadow);

I have no idea what could be causing this. But I've upgraded my project to 2019.4 and imported the latest version of Crest, shadows seem to be working fine now. If it happens again I'll reopen this issue. Thanks a lot for the support!

That's really odd.. thanks for getting back to us


auro-popover: click to close

Is your feature request related to a problem? Please describe.
Currently, with the sticky popover and the popover on mobile, the popover stays unless there is another tab inside or outside the scope of the popover.
This implies that a secondary click in the trigger should also close the popover. This isn't happening.
Describe the solution you'd like
When clicking or tapping on a popover, a second click or tap on the same trigger should close the popover.

This is no longer needed as the sticky popover is being deprecated.


Capability lag in recipes

As of 2.12h-1.12.2, lag is observed in capability handling during crafting:

net.minecraftforge.oredict.OreDictionary.getOreIDs() is known to be very slow and cause memory allocations. Consider using a cache or fast filter before using that method.

Ok, using a cache now - hopefully will speed this up :)


Scaffold watches for resources in ControlPlaneMachineSet controller

This PR ensures that the operator is watching the ControlPlaneMachineSet, Machine and ClusterOperator resources which will trigger reconciles.
This is scaffold at the moment as the filters themselves have yet to be implemented, this will be left as a future task. Tests have also been scaffolded, but more tests may be added when the implementation of the watches is done.

/retest-required


Question: How to remove a title from "Planning to read"

This is a question or maybe a feature request. I know how to add a title, but how do you remove a title that you've finished reading? Sorry if I missed this being addressed somewhere. Cheers!

Hi all the instructions can be seen through the ui and this functionality doesn´t exist, so yeah this is a feature request

In fact, i was waiting for someone to ask for this, will be implemented soon


ng lint incorrect error message for directives

LINK TO angular guide where is the incorrect message comes from

I'm submitting a...

[x] Documentation issue or request

Current behavior

When you run ng lint --fix it gives us this error
The selector of the directive "SomeDirective" should have prefix "app" (https://angular.io/styleguide#style-02-08)
Current selector is: ```@Directive({selector: '[PropertyGridRow]'})```

Expected behavior

this Error should not be there since the actual documentation doesn't have suggestion to have an app prefixing
Minimal reproduction of the problem with instructions
Create a directive without app prefix
and run ng lint
have prefix "app"[ (https://angular.io/styleguide#style-02-08)] (https://angular.io/styleguide#style-02-08)```
![image](https://user-images.githubusercontent.com/16279325/47877100-affff480-dde0-11e8-81b2-8e6fb092b8c2.png)

## What is the motivation / use case for changing the behavior?

The documentation guide  has to be corrected to use an app prefix or the message has to be corrected

## Environment

Angular version:
    _                      _                 ____ _     ___
   / \   _ __   __ _ _   _| | __ _ _ __     / ___| |   |_ _|
  / △ \ | '_ \ / _` | | | | |/ _` | '__|   | |   | |    | |
 / ___ \| | | | (_| | |_| | | (_| | |      | |___| |___ | |
/_/   \_\_| |_|\__, |\__,_|_|\__,_|_|       \____|_____|___|
               |___/

Angular CLI: 1.7.3
Node: 8.9.4
OS: win32 ia32
Angular: 5.2.9
... animations, common, compiler, compiler-cli, core, forms
... http, platform-browser, platform-browser-dynamic, router
... upgrade

@angular/cli: 1.7.3
@angular-devkit/build-optimizer: 0.3.2
@angular-devkit/core: 0.3.2
@angular-devkit/schematics: 0.3.2
@ngtools/json-schema: 1.2.0
@schematics/angular: 0.3.2
@schematics/package-update: 0.3.2
typescript: 2.6.2
webpack: 4.20.2

I am confused. The provided link does state that a directive should use the application prefix. In the provided link an example is given of an app using the toh prefix. The error message from lint states you should be using the app prefix which is the prefix of the app your working in. You could set a different prefix when creating the application with ng new —prefix xyz as can be seen at
https://angular.io/cli/new

As @wvanderdeijl correctly highlighted, that is because the default prefix is set to app.

@wvanderdeijl the example doesn't tell to use app prefix for directives, and the example shows toh. which is custom for whatever you want to name it. ng lint instead throws an error about custom prefix saying it should be prefixed with app.


DOM: prepend, append, before, after, and replaceWith

Removal of the flag in Chrome 54.
https://www.chromestatus.com/features/5723067795898368

Thanks, has been updated.


replicated shards in the unassigned row of the Shards view are now grouped by id

example

@joemoe maybe you also have some feedback ?

Codecov Report

Merging #511 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #511   +/-   ##
=======================================
  Coverage   30.23%   30.23%
=======================================
  Files          21       21
  Lines        1971     1971
  Branches      239      239
=======================================
  Hits          596      596
  Misses       1331     1331
  Partials       44       44

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f0f340a...ee7f635. Read the comment docs.


System Project

https://github.com/rancher/rancher/issues/12706

It has to be tested on a real, not local, cluster. RKE with canal should do, double check with @leodotcloud

@alena1108  The use case of moving to System Project doesn't work since network policy doesn't get updated, I'll make changes as a part of this same PR

https://github.com/rancher/types/pull/481

Can we also add some integration tests for it.

LGTM

LGTM


feat: add run-dash action to analyze 3rd party dependencies

Description
This PR does add a new GitHub action, that is setting up the Eclipse Dash license tool. Based on a view config params, Dash will analyze the 3rd party dependencies and check, if the DEPENDENCIES file present in a repository is up-to-date.
Fixes #168

Way better to inform what's wrong with the file. I was wondering if it would be more useful to output a combined result like it's out of date & contains rejected & contains restricted.

You actually could do both. Via input, you can configure when the action itself will fail, but the flags for that (out-of-date, contains restricted, contains rejected) are also available as output.
So you could configure it to never fail and evaluate the step output yourself


Font Weight + Line height token included under Typography section

Resolves issue #194
Any feedback is always appreciated.

Hey @Bismay5467! Awesome job here, we'll need to think about how to show longer variant names, but I think it's fine for now.
Just left a bunch of minor nits, nothing major. Once we get those cleaned up, we can get this merged in! Awesome work, this is a big feature!!


Evaluation code

Hi,
thank you for your great work. The idea is straightforward but works excellent. May I ask how do you evaluate your model performance on SemanticKITTI? Or do you have a recommendation for evaluation code repo?

Hi, thanks for the interest in our work! To evaluate our model we fine-tune it to semantic segmentation, object detection and panoptic segmentation, we have more information on this section of the readme: https://github.com/PRBonn/TARL#pre-trained-weights
Also, we refer to the segcontrast repo (https://github.com/PRBonn/segcontrast/blob/main/README.md) for the semantic segmentation evaluation.

Nice! I miss that instruction. Thanks a lot.

Hi @nuneslu, I am interested in the panoptic segmentation task. Can you tell me more details about transferring the pre-trained 3D backbone to panoptic segmentation? For example, why do you use the pre-trained MinkUnelt model as the 3D backbone instead of the VoxelNet implemented by the spconv, like in DS-Net?
If possible, can you share the panoptic segmentation codes with me?


Fire off K8s job to train python models

fairing should support firing off K8s jobs to train python models (e.g. xgboost/scikits) learn models.
Need to figure out

What the syntax is
How to move data back and forth

Users are bringing data to notebook. Can the same work for job?
On Mon, Dec 17, 2018, 6:28 AM William Buchwalter<EMAIL_ADDRESS>wrote:

K8s jobs are already supported currently.

fairing.training.native will fire k8s jobs
fairing.training.kubeflow will fire TFJobs

We should probably rename native to kubernetes to make it clearer.
@jlewi https://github.com/jlewi I think data is a pretty big problem on
it's own, so if you are ok I will close this issue and create a new
dedicated one for that.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/kubeflow/fairing/issues/47#issuecomment-447864465,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAqJPZD_T7JY6C3mGlbHGTcAVhYHKrLHks5u56oAgaJpZM4ZVhxN
.

If the notebook can pull in the data, why won't the job be able to do it also?

If the logic to access the data is in your code, then yes it will work out of the box.
However I suspect many users will want to access their data not through an API but instead rely on some pre-configured data store such as en EBS/AzureDisk or some already created PV. And we would need to find a way to allow users to specify these kind of sources without introducing too much complexity.

I see. It's about allowing users input information that's not notebook
code, but related.
On Mon, Dec 17, 2018, 11:48 AM William Buchwalter<EMAIL_ADDRESS>wrote:

If the notebook can pull in the data, why won't the job be able to do it
also?
If the logic to access the data is in your code, then yes it will work out
of the box.
However I suspect many users will want to access their data not through an
API but instead rely on some pre-configured data store such as en
EBS/AzureDisk or some already created PV. And we would need to find a way
to allow users to specify these kind of sources without introducing too
much complexity.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/kubeflow/fairing/issues/47#issuecomment-447974773,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAqJPS82ZAG8UNu2FqF0Da7xgbEx9kpZks5u5_T8gaJpZM4ZVhxN
.

@ashahab I think you are correct in that we want to use fairing to fire off scikit jobs as K8s jobs so they can run asynchronously on other nodes.
I think what @wbuchwalter is saying that we don't want to use fairing to move data around. To move data around we would use a shared filesystem that can be accessed by both the notebook and the K8s job. For this there are two possibilities

An external shared filesystem that is directly accessed (e.g. object store like S3/HDFS/GCS)
A PVC that can be mounted on the notebook pods and K8s Job

In either case its just about configuring the pods (notebook and K8s job) so that code can access the data.
To @wbuchwalter's point I think this where our discussion about using Admission Controllers could be useful. An administrator could configure one or more admission controllers so that appropriate volumes are mounted on pods to make data accessible. Or in the case of GCS/S3/HDFS the admission controller could ensure appropriate credentials are provided to each pod.

Will be fixed by #64

Fixed by #64
/close


PIWIK_DOMAIN_PATH regex forbids 'localhost/piwik'

While I got around the issue by using  PIWIK_DOMAIN_PATH = '<IP_ADDRESS>/piwik' , I get the Exception of PIWIK_DOMAIN_PATH setting: must be a domain name, optionally followed by an URI path, no trailing slash (e.g. piwik.example.com or my.piwik.server/path) if I have it just set as localhost/piwik. I assume that ^(([^./?#@:]+\\.)+[^./?#@:]+)+(/[^/?#@:]+)*$ wants to see a '.' in there somewhere :P

Exactly, the regular expression looks for a minimum of a <domain>.<tld> expression.
Can you explain why a private host makes sense in the context of Piwik? If a page in the browser is loaded then localhost would try to access a a resource local to the calling agent. Are you sure you want that?
Proposed change
Can you try changing the + after the first group to a * in DOMAINPATH_RE as follows, and confirm that this allows localhost?
# domain name (characters separated by a dot), optional URI path, no slash
DOMAINPATH_RE = re.compile(r'^(([^./?#@:]+\.)*[^./?#@:]+)+(/[^/?#@:]+)*$')
```

Exactly, the regular expression looks for a minimum of a <domain>.<tld> expression.
Can you explain why a private host makes sense in the context of Piwik? If a page in the browser is loaded then localhost would try to access a a resource local to the calling agent. Are you sure you want that?
Proposed change
Can you try changing the + after the first group to a * in DOMAINPATH_RE as follows, and confirm that this allows localhost?
# domain name (characters separated by a dot), optional URI path, no slash
DOMAINPATH_RE = re.compile(r'^(([^./?#@:]+\.)*[^./?#@:]+)+(/[^/?#@:]+)*$')
```

Confirmed that the new regex allows localhost, thanks! Using it for the sake of local testing to try it out, thanks for the help


FC key import

Add support for FC WalletImport RPC which imports a private key.
The API details are defined here https://github.com/filecoin-project/lotus/blob/master/api/api_full.go#L181
There are is one argument the filecoin key to be imported. The format of this key is a KeyInfo struct https://github.com/filecoin-project/lotus/blob/master/chain/types/keystore.go#L13. If successful the response is the address of the key imported.
Example request:
{ "jsonrpc": "2.0", "method": "Filecoin.WalletImport", "params": [{"Type":"bls","PrivateKey":"r1bmB7mEHDomf46UVItzr3cISXBVeDbp6tULH1eAgxA="}],"id":3}], "id": 3 }
response:
{"jsonrpc":"2.0","result":"t3they7bzo2tufmpg2bdzfmx5jta7lbkvwbte3pjy7kpjjzzncadoon2hry2hgcrwq65h3edtmqnk4453dgepq","id":3}

Closing this as "Not Done" for now. Will revisit if required.


Logic should return at least information about clicked cell

GIVEN a user flags a cell
AND the user clicks on another cell which would auto-uncover the flagged cell
WHEN the user now tries to uncover the previously flagged cell
THEN I expect the logic library to return the already uncovered cells in the report
With this fix I then could e.g. click cell x=5, y=5 from below image to uncover it.

Niiiice, I just wanted to investigate further, and I see that this has already been fixed in commit 3f745f1 :D
You can see the fixed behaviour in the Preview version of the game ;)
So, yeah, let's review this in the next session, but I think we can close this issue. 🎉🍻


Applying consistent styling for all java files

This commit applies a consistent code style for all java source files.
It also includes the IntelliJ code style config used to apply the formatting.

Looked at a few files. LGTM

Looks good. Merging.


Add Sign message to hardware manager class

What is needed?
Currently we are not able to sign hashes with hardware wallets on the safe-cli, could be good add this feature to be able to use to sign_messages on Safe.

Working like a charm! Un saludito


Improve/fix "nix-prefetch-git --fetch-lfs"

Motivation for this change
nix-prefetch-git --fetch-lfs ... currently fails (due to unset $TMPDIR, missing git-lfs from $PATH). This fixes it.
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
21.11 Release Notes (or backporting 21.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 134122 at 7692232a run on aarch64-linux 1

14 packages built successfully:

bundix
cabal2nix
crate2nix
dep2nix
go2nix
haskellPackages.cabal2nix-unstable
haskellPackages.nvfetcher
haskellPackages.update-nix-fetchgit
nix-prefetch-git
nix-prefetch-scripts
nix-update-source
nvfetcher
update-nix-fetchgit
vgo2nix

2 suggestions:

warning: license-missing
Package is missing a license.
Near pkgs/tools/package-management/nix-prefetch-scripts/default.nix:22:5:
   |
22 |     meta = with lib; {
   |     ^

warning: missing-phase-hooks
installPhase should probably contain runHook preInstall and runHook postInstall.
Near pkgs/tools/package-management/nix-prefetch-scripts/default.nix:13:5:
   |
13 |     installPhase = ''
   |     ^

Merging in >=24 hours.


Add docs on the transaction recovery feature

I'll merge this so we can have something in the docs before the release and iterate in case it needs changes

That's great! Thanks @gastaldi


Quick fix not working

Please fill in the issue according to the issue template, along with OmniSharp log. Otherwise it's impossible to troubleshoot this. Thank you.

Closing due to lack of response.


Feature - Replace edition with edit

Should be merged after taipy-core changes.

I believe we can merge it as well.


installing pydicom

Hi,
In your instructions there's one line for installing pydicom as "pip install git+https://github.com/scitran/pydicom.gitmirror.git@value_mismatch". I encounter an error when running this line. Even if I remove "mirror.git" or "mirror.git@value_mismatch", I couldn't get through it. Any ideas about how to fix this?
Thanks!

Sorry, the instructions are out of date. Please try this:
pip install<EMAIL_ADDRESS>
Make sure to start with a clean virtualenv. The error you reported in #8 is probably due to having installed a more recent and incompatible version of pydicom, which now in fact gets imported as "pydicom".

Thanks! It helps me get through the dicom module error, but I got another related one at next line ("import scitran.data.medimg.pfile as scipfile").
File "xxx/data/scitran/data/medimg/dcm/dcm.py", line 185, in
ignore_rules=[dcmstack.extract.ignore_non_ascii_bytes],
AttributeError: 'module' object has no attribute 'ignore_non_ascii_bytes'
Looks like it's still a dicom related issue? Thanks again.

It looks like that function was removed a few weeks ago:
https://github.com/moloney/dcmstack/commit/3911feb357c47854b817ddc85a7052caddc71e49#diff-111bbd48f0ac197d9050fd057de6577eL26
For now, you might want to use the version just before that commit, i.e., this one:
https://github.com/moloney/dcmstack/commit/6d49fe01235c08ae63c76fa2f3943b49c9b9832d#diff-111bbd48f0ac197d9050fd057de6577e

Solved. Thanks so much!

This also closes #8.


AA LCD Text on Translucent Surface

AA LCD optimized text fails to render correctly to a translucent surface.  Instead of using the alpha value of the current pixel's color, it ignores it altogether and uses the color as if it had no transparency.  This is a java bug described here:
http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=6749069
http://www.curious-creature.org/2007/04/10/do-not-draw-text-on-translucent-images/
The effect isn't a show stopper but it sure would be nice for it to be fixed.

No longer an issue in Version 3


fix rosettaCombinePayload

because actually it is a string
чт, 2 мая 2024 г. в 19:05, Martin Minkov @.***>:

@.**** commented on this pull request.
In src/mina-signer/src/rosetta.ts
https://github.com/o1-labs/o1js/pull/1633#discussion_r1587988536:

@@ -282,7 +282,7 @@ function rosettaTransactionToSignedCommand({
}

type UnsignedPayload = {

unsigned_transaction: UnsignedTransaction;

unsigned_transaction: string;

What is the issue with unsigned_transaction being of type
UnsignedTransaction? Is there no way to keep it typed here?
—
Reply to this email directly, view it on GitHub
https://github.com/o1-labs/o1js/pull/1633#pullrequestreview-2036338293,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ACLV5LRVICH4QDBBWAI4H3TZAJW4BAVCNFSM6AAAAABHDKQ3AWVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDAMZWGMZTQMRZGM
.
You are receiving this because you authored the thread.Message ID:
@.***>

Seems like there's some tests to fix:
https://github.com/o1-labs/o1js/actions/runs/8926010581/job/24521454236?pr=1633

@MartinMinkov can you please run tests again?

because I get   Preset ts-jest/presets/js-with-ts not found. when trying to run tests locally

@MartinMinkov can you please run tests again? why do we need aprroval to run the workflow?

If we allowed all external contributors to run workflows, that could lead to exploits because workflows can access important secrets like our npm token

because I get Preset ts-jest/presets/js-with-ts not found. when trying to run tests locally

@qwadratic does this work?
git submodule update --init --recursive
npm i
npm run build
./jest src/mina-signer/tests/rosetta.test.ts

if no, where does it fail?

Fixed!

@mitschabaude @MartinMinkov what can we do with failing benchmark check? this PR doesn't touch o1js

@mitschabaude @MartinMinkov what can we do with failing benchmark check? this PR doesn't touch o1js

You can ignore that failure @qwadratic, it just doesn't work for external PRs
Looks like this is good to go once @MartinMinkov approves!

the typing here was just wrong, the rosetta response has string typed unsigned_transaction (which is json payload for signing)
I fixed it and now its right


disallow read+mutate operators on non-variable late reference values

These are allowed, but can only result in runtime errors:
class C() {
    shared late Integer x = 10;
    shared void init() {
        x++;  // allowed!
        x+=1; // allowed!
    }
}

I suggest that usage of increment and decrement operators and assignment operators other than = on non-variable reference values be disallowed.

Fixed, thanks @jvasileff.


Example:
_var
Name: Text[50]
begin
Name := Name.Trim().ToUpper();
end;_
This will be marked with "possible overflow assigning 'Text' to 'Text[50]' which is not needed.
All non-adding methods should never cause this warning, like:
Remove
ToLower
ToUpper
Trim
TrimStart
TrimEnd
AL Language Extension 14.1.1180850

Hi,
We have internally discussed this issue and have decided not to accept this issue to be fixed at the moment to prioritize other issues. Thank you for raising this concern.
Thanks


Retire unused Dockerfile

Remove unused docker image to save some maintenance overhead.
Related to #6175

Please COMPLAIN if you use this docker image.


Read configuration from .6to5 file?

One project I'm working on has three different places where I need to pass options to 6to5. There's the test suite that runs ES6 code with 6to5/register, the Gulpfile that builds ES5 code that I can npm publish, and the REPL.
Keeping all three in sync is not easy, especially when configurations change (e.g. just released 3.0). What about having all three reading their configuration from the same file?

Duplicate of #351


Cairo formatter API

This change is

crates/cairo-lang-formatter/src/cairo_formatter.rs line 60 at r1 (raw file):
Previously, mkaput (Marek Kaput) wrote…
This looks to never fail?

https://github.com/starkware-libs/cairo/blob/3948b37a90884ca6b54a98a8f5291a394e54b264/crates/cairo-lang-formatter/src/cairo_formatter.rs#L83

crates/cairo-lang-formatter/src/lib.rs line 17 at r1 (raw file):
Previously, mkaput (Marek Kaput) wrote…
Hmm, it's now pretty ambiguous what CairoFormatter is and what Formatter is. Perhaps Formatter could be renamed to FormatterImpl? It looks to be private thingy

I do agree it is confusing, I would love to hear opinion from @gilbens-starkware or @spapinistarkware before renaming it though.

crates/cairo-lang-formatter/src/cairo_formatter.rs line 35 at r12 (raw file):

impl Display for FileDiff {
    fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result {
        let patch = create_patch(&self.original, &self.formatted);

Done.

crates/cairo-lang-formatter/src/cairo_formatter.rs line 43 at r12 (raw file):

    fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result {
        writeln!(f, "FileDiff(")?;
        Display::fmt(self, f)?;

Done.


i have an error in chat_room_screen.dart file

on line no 41 Undefined name 'ScaffoldMessenger'.
https://github.com/KhalidWar/yaanyo/blob/main/lib/screens/chat/chat_room_screen.dart#L41

That's the latest way of showing snackbars. Make sure you're running flutter 1.22+.
This is what I'm running:
[✓] Flutter (Channel master, 1.24.0-8.0.pre.144, on Linux, locale en_US.UTF-8)


swagger.json

How can i change the location of the generate swagger.json file?

Nevermind found it.


TPeakFItter does not fix Centroid parameter

GRSISort Version: <IP_ADDRESS>
ROOT Version: 6.26/14
Built for linuxx8664gcc on Nov 28 2023, 00:39:39
From tags/v6-26-14@v6-26-14
OS: Ubuntu 22.04.3 LTS

Describe the bug
When using TPeakFitter with TRWPeak, attempting to fix the centroid parameter does not work. I am able to fix all other parameters (sigma,area).

Check the newest version of the code, should be fixed.

Yes, that fixes the issue. The centroid parameter is now able to be fixed!


[SPARK-7279] Removed diffSum which is theoretical zero in LinearRegression and coding formating

Merged build triggered.

Merged build started.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/31434/
Test FAILed.

Jenkins, please test again.

test this please

Merged build triggered.

Merged build started.

Test build #31455 has started for   PR 5809 at commit 03511c7.

Merged build triggered.

Merged build started.

Test build #31456 has started for   PR 5809 at commit 6904eed.

Test build #31455 has finished for   PR 5809 at commit 03511c7.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.
This patch does not change any dependencies.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/31455/
Test PASSed.

Merged build finished. Test PASSed.

Test build #31456 has finished for   PR 5809 at commit 6904eed.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.
This patch does not change any dependencies.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/31456/
Test PASSed.

LGTM. Merged into master. Thanks!


Generate credentials file at startup, not build time

The config var value can be changed at any moment, and doing so
shouldn't require a new deployment.
Generating this file at build time also means it's not possible to use
Heroku Pipelines, as a promotion doesn't trigger a new deployment.

Hey dmathieu can you tell me if I have to change the GOOGLE_APPLICATION_CREDENTIALS to /app/google-credentials.json or similar? I added the code to my own app under bin/pre_compile but I always get the error Missing value in GOOGLE_CREDENTIALS. Or is the reason that the env vars are not loaded yet on pre_compile?

The echo won't be displayed. It's sent to the .profile.d file. When you run a one-off dyno with the heroku run command, is the file generated by this change available on disk? And is the config written?
For reference, here is the doc on profile.d scripts: https://devcenter.heroku.com/articles/buildpack-api#profile-d-scripts

The problem seems to be that " are missing around the credentials in the config vars.
{
      "type": "service_account",
      "project_id": "natural-language-254706",
      "private_key_id": "XXX",
      "private_key": "-----BEGIN PRIVATE KEY-----\nXXXXX\n-----END PRIVATE KEY-----\n",
      "client_email"<EMAIL_ADDRESS>      "client_id": "12345",
      "auth_uri": "https://accounts.google.com/o/oauth2/auth",
      "token_uri": "https://oauth2.googleapis.com/token",
      "auth_provider_x509_cert_url": "https://www.googleapis.com/oauth2/v1/certs",
      "client_x509_cert_url": "https://www.googleapis.com/robot/v1/metadata/x509/starting-account-5yzg5dipgu01%40natural-language-254706.iam.gserviceaccount.com"
    }

However, when I try to add them manually they always get deleted:
echo "echo '$GOOGLE_CREDENTIALS**'** > /app/google-credentials.json" > $BUILD_DIR/.profile.d/google-credentials.sh
That leads to the error here. The original version by elishaterada, however, works for me.

Thank you @marcmetz. I've added escaping of the content.
It relies on bash 4.4, meaning this will only work on the heroku-18 stack: https://devcenter.heroku.com/articles/stack-packages
cedar-14 is already deprecated anyway, and heroku-16 will be in april.

@marcmetz are you able to use heroku-18 stack and test this out?

I just tested it. It works. Thank you!

@dmathieu @marcmetz thank you!


Add status of ROS builds to README

All builds of ROS2 are now passing and will be available upon the next sync. To access their status more easily, this adds the badges from CI to the README alongside additional information on how to use it in projects.

How did you reduce the required RAM ? I think @olivier-stasse was working on it, but didn't finish yet


Running in xhyve/docker

I saw this mentioned in the ccc keynote and was a little suspicious about claims of poor performance, especially after seeing the flame graphs and the exorbitant amount of time spent in ARC. Glancing at the code I see much unnecessary use of classes. I'm confident that if I dug into it, I could increase performance substantially.
While it won't give accurate performance numbers, can you provide some guidance for running this in either xhyve or docker? I'm on a MacBook, and that way I could at least run the code.

There's unfortunately no hypervisor that supports emulating a 82599 (for good reason), but even if there was one, it would be pointless for performance tests because the hypervisor would be the bottleneck. We intentionally target real hardware only here (some of our other drivers also support virtio NICs, but the perforamnce results there are not comparable).
Please keep in mind that we are aiming for idiomatic implementations in all languages, so we want code that looks like code that was written for Swift and not some collection of hacks to make it as fast as possible.
But we are happy to test any pull requests on our testbed :)

I understand it would be meaningless for performance, but you could at least test that a certain number of packets now results in N less calls to retain/release (and then submit that patch to run on hardware). Is there a way I can run the code to test just this very limited metric, while still verifying the correctness of the code?
As for things being "idiomatic", that's a bit of a qualitative argument. The Swift team at apply has long been pushing structs and protocol-oriented programming as the way to get the best out of Swift. Making something simple like a network driver with these concepts should be very possible, and much more performant than an Objective-C or Java-like class-based implementation.

Unfortunately the 82599 isn't supported by any hypervisor/emulator that I'm aware of. Despite this it was the best target hardware for our project for various reasons.
Happy to test any pull requests on real hardware for you


chore: spacing and remove verbose

:tada: This PR is included in version 1.1.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Sets fromHash as contract signer, the delegator.

...and sets the _delegationAddress as the addy to use in the toHash value.
Addresses #17.

Resolved now, as per the discussion on #17. Thanks!