RPM Installer missing icon

Prerequisites

[X ] Put an X between the brackets on this line if you have done all of the following:

Reproduced the problem in Safe Mode: https://flight-manual.atom.io/hacking-atom/sections/debugging/#using-safe-mode
Followed all applicable steps in the debugging guide: https://flight-manual.atom.io/hacking-atom/sections/debugging/
Checked the FAQs on the message board for common solutions: https://discuss.atom.io/c/faq
Checked that your issue isn't already filed: https://github.com/issues?utf8=✓&q=is%3Aissue+user%3Aatom
Checked that there is not already an Atom package that provides the described functionality: https://atom.io/packages

Description
After installing atom on Fedora 30 via an rpm file i can see that the appropiate menu and icons are present except from the run command. If I install some other thing I do see this icon only atom seems to have this problem.
Steps to Reproduce
Alt+F2 , type "atom" , look at icon preview. Icon is not there.
Expected behavior:
See icon
Actual behavior:
No icon
Reproduces how often:
Everytime
Versions
$  atom --version
Atom    : 1.38.2
Electron: 2.0.18
Chrome  : 61.0.3163.100
Node    : 8.9.3
Fedora Core 30

Thanks for the report - trying to get my Fedora VM up and running but just to confirm, the .rpm you used is from https://atom.io correct?
Also, did you just notice this in 1.38.2 and the icon was there previously?

Yes from atom, yes 1.38.2, previous icon..? Sorry do not know this.
On Wed, Jul 3, 2019, 1:43 PM Robert Sese<EMAIL_ADDRESS>wrote:

Thanks for the report - trying to get my Fedora VM up and running but just
to confirm, the .rpm you used is from https://atom.io correct?
Also, did you just notice this in 1.38.2 and the icon was there previously?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/atom/atom/issues/19626?email_source=notifications&email_token=AA7ZAZ6WW63P2PWLE5CITODP5TQL3A5CNFSM4H5EW2U2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODZFF2MI#issuecomment-508190001,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AA7ZAZ3RK4QKSPVYMQ35ONTP5TQL3ANCNFSM4H5EW2UQ
.

previous icon..? Sorry do not know this.

Sorry, I meant to ask if you've used versions of Atom before 1.38.2?  And if so, did the icon show up?
Also, can you share more details about this?

Alt+F2 , type "atom" , look at icon preview. Icon is not there.

I haven't run programs like that before, can you clarify what preview icon you're referring to?  Can you share a screenshot of what another program looks like vs. Atom?

I am sorry I do not know. I don't think rpm was available when last I
installed or, might have been a repo add rather than a download, dnf
install. I may have also fixed this myself, not sure. Sorry
On Fri, Jul 5, 2019, 7:00 PM Robert Sese<EMAIL_ADDRESS>wrote:

previous icon..? Sorry do not know this.
Sorry, I meant to ask if you've used versions of Atom before 1.38.2? And
if so, did the icon show up?
Also, can you share more details about this?
Alt+F2 , type "atom" , look at icon preview. Icon is not there.
I haven't run programs like that before, can you clarify what preview icon
you're referring to? Can you share a screenshot of what another program
looks like vs. Atom?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/atom/atom/issues/19626?email_source=notifications&email_token=AA7ZAZYHRWWBQSG5FASLORDP57G7ZA5CNFSM4H5EW2U2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODZKNOGQ#issuecomment-508876570,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AA7ZAZ3Y6BV74EXXODJBRULP57G7ZANCNFSM4H5EW2UQ
.

I may have also fixed this myself, not sure. Sorry

No problem - so it sounds like you're no longer seeing this issue?  We'll go ahead and close for now but if you think this is still an issue let me know.


Fix AnimationPlayer keyframes hard to select at time 0.0.

Fixing #26151
In the Animation Window:
Keyframes at time=0 can now be clicked on their left side, too (tooltips and selection using a drawn rectangle work as well).
The Keyframes at time=0 now have the same Hitbox as other Keyframes.
Tested with Debian

Use clang-format to fix Travis build compilation. Also dont forget to squash the commits together.

Thanks, working fine so far in my build.  👍

Is that better?

OP is unresponsive, we need another contributor to take over and address above comments. @YeldhamDev maybe?

@akien_mga I made the changes, but how do I push them to this PR exactly?

I think this should work (it would for me, but not sure if you have enough access for that):
git push https://github.com/DragonDev1906/godot.git your_branch:issue-26151 -f

@akien-mga Nope, permission denied.

Make a new PR then I guess, and we'll close this one as superseded by the new PR.

Superseded by #30294.


hyper-tls = "0.5.0" and hyper v0.14.19 failed, 0.14.18 succeed

rust-analyzer failed to load workspace: Failed to read Cargo metadata from Cargo.toml file Cargo.toml, cargo 1.61.0 (a028ae42f 2022-04-29): Failed to run "cargo" "metadata" "--format-version" "1" "--manifest-path" "Cargo.toml" "--filter-platform" "x86_64-apple-darwin": cargo metadata exited with an error:     Updating crates.io index
error: failed to select a version for hyper.
... required by package hyper-tls v0.5.0
... which satisfies dependency hyper-tls = "^0.5.0" (locked to 0.5.0) of package ``
versions that meet the requirements ^0.14.2 (locked to 0.14.18) are: 0.14.18
all possible versions conflict with previously selected packages.
previously selected package hyper v0.14.19
failed to select a version for hyper which could resolve this conflict

It looks like cargo's bug


Add SourceLevel.JAVA_8

Previously, the FunctionPackage feature was standing in for this constant. After this refactoring, FunctionPackage defers to SourceLevel's logic to decide whether it's available or not, and tests can use simply SourceLevel.JAVA_8 instead of both SourceLevel.JAVA_7 and FunctionPackage.AVAILABLE. FunctionPackage.lambdasAvailable() has moved to the more obvious SourceLevel.hasLambdas().
To allow FunctionPackage to determine whether SourceLevel is available, the FeatureType abstract class now takes a FeatureSet argument on its methods. Individual features are responsible for not creating cyclic dependencies. JavaxPackage uses this to disable itself by default in Java 8 tests, though it continues to defer to the processing environment in production.

This is a prerequisite of the Streams work, by the bye.


[Automation] Generate Fluent Lite from Swagger elastic#package-2024-03-01

https://github.com/Azure/sdk-release-request/issues/5507

[Automation] Generate Fluent Lite from Swagger elastic#package-2024-03-01

API change check
APIView has identified API level changes in this PR and created following API reviews.
com.azure.resourcemanager:azure-resourcemanager-elastic


Certificate manger resource support

@googlebot I fixed it.

@googlebot I fixed it.

@googlebot I signed it!

@googlebot I fixed it.

@googlebot I fixed it.

@googlebot I fixed it.

@googlebot I fixed it.

@googlebot I fixed it.


Fixes for hdx exports visualization

Resolve #451
Resolve #452
Resolve #453
Resolve #406
Resolve #405 ( One can simply type project id and if it exists on TM then boundary will be displayed to export tool )

Adds this new dashboard for admin to better visualize and filter hdx jobs

Intoduces new run stats api
which gives output like following :
{"periods": [{"start_date": "2022-09-21", "runs_count": 5, "run_types": "on_demand:5", "export_formats": "geojson:5,shp:5,garmin_img:2"}, {"start_date": "2022-09-10", "runs_count": 3, "run_types": "on_demand:3", "export_formats": "geojson:3,shp:2"}, {"start_date": "2022-08-16", "runs_count": 17, "run_types": "on_demand:17", "export_formats": "geojson:17,geopackage:3"}, {"start_date": "2022-06-08", "runs_count": 1, "run_types": "hdx_run:1", "export_formats": "shp:1"}, {"start_date": "2022-06-07", "runs_count": 4, "run_types": "hdx_run:2 on_demand:2", "export_formats": "shp:2,geojson:2,kml:2"}, {"start_date": "2022-06-03", "runs_count": 1, "run_types": "hdx_run:1", "export_formats": "shp:1"}, {"start_date": "2022-06-02", "runs_count": 2, "run_types": "on_demand:2", "export_formats": "geojson:2,shp:1"}, {"start_date": "2022-05-24", "runs_count": 10, "run_types": "on_demand:10", "export_formats": "geojson:10,kml:10"}, {"start_date": "2022-05-23", "runs_count": 40, "run_types": "on_demand:40", "export_formats": "geojson:40,kml:40"}, {"start_date": "2022-05-19", "runs_count": 1, "run_types": "on_demand:1", "export_formats": "shp:1,geojson:1,geopackage:1,kml:1"}, {"start_date": "2022-05-18", "runs_count": 6, "run_types": "on_demand:6", "export_formats": "geojson:6,shp:5,geopackage:4,kml:2"}, {"start_date": "2022-05-17", "runs_count": 40, "run_types": "on_demand:40", "export_formats": "geojson:31,shp:13,geopackage:9,kml:8,garmin_img:7"}]}

Thank you @kshitijrajsharma for the fantastic additions to export tool.
Will it be possible to populate TM Project Id on search bar using url params? As an example, the URL "https://export-staging.hotosm.org/en/v3/exports/new/describe/?search=12822" loads the project AOI and populates the search bar with the TM project Id, allowing to link users from the TM Project description page directly to the export tool.

for #406

Thank you @kshitijrajsharma for the fantastic additions to export tool.
Will it be possible to populate TM Project Id on search bar using url params? As an example, the URL "https://export-staging.hotosm.org/en/v3/exports/new/describe/?search=12822" loads the project AOI and populates the search bar with the TM project Id, allowing to link users from the TM Project description page directly to the export tool.

Sure @Aadesh-Baral I will look into it !

For admin users now force run mark failed is available , and also they can terminate the job from workers


Updating the self-documentation feature

There are two places where I think PostgREST needs a little more polish, one is limiting embedded collections (which I'm trying to fix in #446), and the second is the self documentation feature.
I have been talking to some UX/design people recently and I really feel that with a little love, this feature could be really big for PostgREST as it allows a whole slew of awesome tooling, including custom CMS which use PostgREST as the backend (next gen of wordpress?). I don't know how many people use the feature now, but a mature and well developed self-documentation feature would be super awesome.
The current approach to self-documentation is an awesome proof of concept, but not as powerful as it could be. Some ideas for updating this system are moving to a new format like RAML, swagger, or json hyper-schema and having this information only be available at the root, /. No more OPTIONS requests, just a single large schema at /. I like this idea. However, if we are to go that way I would also recommend we move it to a new project, maybe postgrest-schema.
The new project wouldn't have to be written in Haskell, it could be written in any language. Go and Rust instantly come to mind, Node.JS might be a 3rd choice for it's JSON tools, however it does not compile down to a binary which could be a blocker (if someone wants to do it in Node, I'm not opposed).
Here is why I think it should be another project:

Allows for easier maintainability. If a user wants to add their own routes to a schema they can just add a JSON or YML file to the file system and point the new project at it. Doing this in PostgREST core would be a design deviation.
PostgREST couldn't support all the data formats (RAML, swagger, hyper-schema) without increased complexity and a whole bunch of specs to maintain support for. However, a separate project could.
Faster iteration. As I do believe the schema could be huge for people developing a CMS, or other similar system, having a way to quickly iterate on schema representations could be helpful.
Haskell isn't the best for manipulating complex data structures (I might be totally wrong on this one, this is just my experience in my short short time with Haskell).
PostgREST shouldn't have exclusive access to /. The root route is important for API metadata, ideally PostgREST doesn't have exclusive access to it.

Even if we decide not to remove schema stuff from PostgREST core, I still believe a separate server for building a schema based on the PostgREST contract could be very powerful.

I currently don't have the time to invest in this schema project, however I feel like if anyone did there could be a large ROI, especially if they wanted to make a CMS with it. Is there anyone interested in developing this in their toolset of choice? This would be great if your a non-Haskell developer and want to contribute. Maybe adding a help-wanted tag to this issue could help people find it?

Here's a proposal:

Add to postgrest a --raml option which can contain an RAML file. This can be parsed and served at /.
An option to generate an initial RAML spec from a postgres schema. This can be a separate cmdline tool.
Take the file produced by pt. 2, edit/rinse/repeat and pass it as args to postgrest as mentioned in pt. 1.
What do you guys think?

@badri I like this idea of the tool not being a server but rather just generating a file.
However, I also think that mounting the file at / should not be a feature of PostgREST but rather something done in NGINX or other proxy.

@badri I really like this idea of the tool not being a server but rather just generating a file.

@calebmer ok, we could have an option in postgrest to generate RAML from DB.

However, I also think that mounting the file at / should not be a feature of PostgREST but rather something done in NGINX or other proxy.

I'm not clear how this will work in a production scenario. For ex, I'm thinking Postgrest will be deployed in Heroku or likewise using Procfile/foreman. How will serving the RAML spec work in that case? Forgive my ignorance in this matter :)
Nevertheless, its a good idea to decouple this functionality from Postgrest, as it offers more scope for customization etc.

Closing this as we now generate an OpenAPI spec.


Merge consecutive range requests

We have the offsets of each image tile and can calculate which tiles we need to read for a given partial read so this shouldn't be too difficult.
Ref: https://trac.osgeo.org/gdal/wiki/ConfigOptions#GDAL_HTTP_MERGE_CONSECUTIVE_RANGES

With async we actually benefit from many little requests than fewer large requests, so I'm closing this for now.


Settings.Designer.cs file missing from repo

I could not compile the project, VS Studio is complaining about a missing file Settings.Designer.cs

I believe what probably happened here was that the files Settings.settings and Settings.Designer.cs were autogenerated without me being fully aware of it, and I neglected to include them in the repo.  They can be regenerated from the Settings tab of Project Properties.  I can add them in a future commit.

Resolved with commit 2e1c70acf14916a45710d7a4f5410fd7030c82d8.


Put logs behind a "debugging" flag

We can take this out or putting it in something like
if (process.env.DEBUGGING) {
  // ...
}

There's already some logic like that in App.jsx
// 😬 Sorry for all the console logging
const DEBUG = true;

Originally posted by @dgrcode in https://github.com/moonshotcollective/scaffold-directory/pull/48#discussion_r715484239

DEBUGGING=true could be the default, but some times we have too many logs and it could be easier to turn it to false, so only logs that you just wrote show up.
I'm thinking you would actually want to turn it false just to debug. Maybe VERBOSE_LOGS is a better name.


[BUG] Incorrect certificate for web version

Describe the bug
A clear and concise description of what the bug is.
https://www.marcelotrevisani.com/grayskull has the following error:
Error - WeasyPrint
The certificate for this server is invalid. You might be connecting to a server that is pretending to be “marcelotrevisani.info”, which could put your confidential information at risk.

To Reproduce
Steps to reproduce the behavior:

Go to '...'
Click on '....'
Scroll down to '....'
See error

Expected behavior
A clear and concise description of what you expected to happen.
Outputs
If applicable, add the output to help explain your problem.
Environment:

conda list
pip list
grayskull --version

Additional context
Add any other context about the problem here.
Not sure if this is the right place to report this but wasn't sure where else. 😄

I forgot to add a reminder in my calendar to update the SSL certificate. I will do it now.
I use a free platform to generate the SSL certificates, every three months, I think, I need to renew it.

That should be fixed now.
Thanks for reporting it! :)

Ahh ok - thank you! :)


Throw opcode with trap.

I was unable to add a test for this. Without try ... catch I don't know how to really check.
Anyway, I tried with "throw null;" and the trap gets generated.

@jacano,
Thanks for having already signed the Contribution License Agreement. Your agreement was validated by .NET Foundation. We will now review your pull request.
Thanks,
.NET Foundation Pull Request Bot

I didn't notice I included a draft version of the newarr op. Sorry for that. I'm removing it.

@dotnet-bot test Ubuntu Release please

Thanks, @jacano!


Master zakari

First TPFA for block centered grids DXDYDZTOPS based
First CPG grid coarsening for upscaling

Thanks for your great contributions again. The new features looks nice!


Requires remote web requests even with full cache usage

I'm a little confused as to how to best make use of the existing caching support.
I see in lib/contentful_rails/caching/timestamps.rb that this maintains a timestamp_cache_key for ContentfulModels that gets invalidated automatically if you tell Contentful to post back to your webhook. This also sets updated_at to cache based on this key. So, from my understanding, this allows us to do things like:
  <% Product.all.each do |p| %>
    <% cache(p) do %>
      <%= link_to p.name, product_url(p) %>
    <% end %>
  <% end %>

where a ContentfulModel named Product can be provided to Rails's cache method to provide the key. Cool.
But getting the full list of Products is expensive too - it will take at least several hundred milliseconds and at worst many seconds.
With a database, the Rails examples deal with this by using simpler, faster queries to determine a cache key, and then checking against that to see if they need to query the whole set:
def cache_key_for_products
  count          = Product.count
  max_updated_at = Product.maximum(:updated_at).try(:utc).try(:to_s, :number)
  "products/all-#{count}-#{max_updated_at}"
end

...

<% cache(cache_key_for_products) do %>
  All available products:
  <% Product.all.each do |p| %>
    <% cache(p) do %>
      <%= link_to p.name, product_url(p) %>
    <% end %>
  <% end %>
<% end %>

But we can't do that, because no matter how simple the call to Contentful, it's still a remote web request and it's going to take forever in relation to other initial page load blockers.
So it seems like we need to maintain cache keys for each ContentfulModel class, which it then checks before refreshing an internally cached result set. These keys should be invalidated by a webhook POST for that Content Type.
These seems like it might but probably doesn't fit under this item listed on the Readme's todos:

Implement a method on ContentfulModel to simulate a parent-child relationship, so we can invalidate caches for parent items

Can you confirm my thinking here? Is a solution like that planned? How have other people solved this problem?

Hi @zrisher
Bit of a brain dump:
You're right - caching isn't done right. My original plan was that by caching the time stamp you could derive a key (and therefore a cached view partial) without an API hit, but as you have found that's not how it works. :-(
The correct solution is to be able to derive a Contentful model completely from the cache but unfortunately it's harder than it seems to generate one from a webhook in the first place, because the Contentful library (used by ContentfulModel and ContentfulRails) can't instantiate an entry (or asset or whatever) from JSON - only from a call to the API.
Basically this is an unsolved problem.
My suggested / planned solution is probably to subclass ContentfulModel::Base and include some way of marshalling the whole thing into the cache. Then you could hook into the instrumentation call raised when a web hook arrives, hit the api, and update it. At the moment there is a recursion issue in the underlying Contentful library which needs working around before the marshalling will work.
Please feel free to suggest a PR - happy to provide commit access to this repo if you want to get involved.
Ed

On 24 Sep 2015, at 19:57, zrisher<EMAIL_ADDRESS>wrote:
I'm a little confused as to how to best make use of the existing caching support.
I see in lib/contentful_rails/caching/timestamps.rb that this maintains a timestamp_cache_key for ContentfulModels that gets invalidated automatically if you tell Contentful to post back to your webhook. This also sets updated_at to cache based on this key. So, from my understanding, this allows us to do things like:
<% Product.all.each do |p| %>
<% cache(p) do %>
<%= link_to p.name, product_url(p) %>
<% end %>
<% end %>
where a ContentfulModel named Product can be provided to Rails's cache method to provide the key. Cool.
But getting the full list of Products is expensive too - it will take at least several hundred milliseconds and at worst many seconds.
With a database, the Rails examples deal with this by using simpler, faster queries to determine a cache key, and then checking against that to see if they need to query the whole set:
def cache_key_for_products
count          = Product.count
max_updated_at = Product.maximum(:updated_at).try(:utc).try(:to_s, :number)
"products/all-#{count}-#{max_updated_at}"
end
...
<% cache(cache_key_for_products) do %>
All available products:
<% Product.all.each do |p| %>
<% cache(p) do %>
<%= link_to p.name, product_url(p) %>
<% end %>
<% end %>
<% end %>
But we can't do that, because no matter how simple the call to Contentful, it's still a remote web request and it's going to take forever in relation to other initial page load blockers.
So it seems like we need to maintain cache keys for each ContentfulModel class, which it then checks before refreshing an internally cached result set. These keys should be invalidated by a webhook POST for that Content Type.
These seems like it might but probably doesn't fit under this item listed on the Readme's todos:
Implement a method on ContentfulModel to simulate a parent-child relationship, so we can invalidate caches for parent items
Can you confirm my thinking here? Is a solution like that planned? How have other people solved this problem?
—
Reply to this email directly or view it on GitHub.

Hey Ed,
Thanks for getting back to me so quickly. I'm at the tail end of the project I'm using Contentful for (thus the caching), but it's very likely we'll be using it again. Happy to submit PRs and work with you then, and yeah if you're busy commit access could help me move faster at that point. I can see there is a ton of complexity going on behind the scenes, so I'm hoping if we come back to this in 3 months some of it might be solved.  :smile: I definitely think Contentful::Resource should be instantiable from JSON, and it seems like that would make things a lot simpler here.
I also noticed a ton of StackLevelTooDeep errors when reloading contentful lib in development, glad it's not just me.
I had assumed this and ContentfulModel were created by the Contentful team as well - if you're not affiliated (or really even if you are), huge props for getting this together and sharing it.

Glad you're finding it useful. We aren't affiliated - we built it for some integrations we were doing, and we are Contentful partners off the back of it.
We haven't got any Contentful projects at the moment, so you might get to the amends before us. Let me know if/when you want commit access.
Ed

Reply to this email directly or view it on GitHub.

Hey @zrisher,
Sorry for taking so long to check this out, but I find your feature request super interesting, and I'll definitely be looking into ways of providing support for this, as one of the concerns @edtjones raised is now solved (the Contentful SDK now properly marshals objects and can also build objects from raw JSON), which would allow this feature to be implemented.
Cheers


[ctbignum] fix build

Fixes https://github.com/microsoft/vcpkg/issues/39850

Any idea why CI was green?

Probably because boost was installed before ctbignum was tested.


[Don't Merge][Need discussion] First-step toward a working mp on Travis

Summary
This PR solves some issue when a worker dies and the Pool is not told. (OOM, pkill, etc)
This puts a timeout on the future and notifies the user of the issue.
Discussion
What should we do for those samples in the case of Sequence? Should we re-queue the task or compute the sample directly or just drop it?
Related Issues
PR Overview

[x] This PR requires new unit tests [y/n] (make sure tests are included)
[ ] This PR requires to update the documentation [y/n] (make sure the docs are up-to-date)
[x] This PR is backwards compatible [y/n]
[ ] This PR changes the current API [y/n] (all API changes need to be approved by fchollet)

If I understand correctly (I'm by no means an expert in multithreading/multiprocessing), in the implementation proposed in this PR, the batch is dropped and a warning is raised. Is that right?
If it's not too much trouble to implement, I believe the best option is to recompute the sample and raise a warning for those reasons:

We don't take the risk of breaking things since other keras components might crash/behave in a weird way if the Sequence doesn't yield the right number of batches.
We keep the current behavior. It's also the expected behavior by the users.
Changing the order of the batches can cause users to wonder what is going on (silent unexpected behavior) if they overlook the warning, but this is unlikely to happen in practice.
If the crash is caused by a sample and is deterministic, the user is interested in the stacktrace. If we recompute it in the main process/thread, the stacktrace will be displayed.

I might be wrong on certain points, as I don't know much about all this.

As of now, there is no way to inform fit_generator to skip an index. So every step will be delayed.

Currently, most of the timouts append with CNTK and python 3.6. So fixing the timeout for 3.6 would be a very good first step.

@Dref360 I updated the PR.
@fchollet could you review? Thank you.

Ping @fchollet could you review when you have the time? Thank you.

I think this is LGTM, this would give the user "some" information and we can move forward with using "spawn" when possible on Travis.

Thanks @Dref360 for working on this!


Add a "speech bubble" type dialog

Is your feature request related to a problem? Please describe.
Games often include smaller, comic-style dialog bubbles. These tend to have several different characteristics compared to the default dialog popup that Dialogic currently has. Some of these characteristics include:

tend to be smaller, often scale to fit the text inside
non-intrusive, don't take control away from player
one bubble per character (player may or may not have one)
anchored to the character speaking rather than specific screen position
might adjust position slightly to stay on screen
often don't display any character name or portrait
have a shape connecting the bubble to the character (possibly in a dynamic way)

I'm new to the plugin, but I don't believe there is currently any easy way to accomplish this in Dialogic.
Describe the solution you'd like
I propose having two types of dialog popups, one for the bigger more intrusive dialogs, and another type for bubble messages. This new type can offer some or all of the options listed above. I suppose each timeline would probably need to be set to use only one of these two options?
This is just the general idea, I'm sure that others will share their thoughts here.
Describe alternatives you've considered
Maybe such options could simply be added to the current popup instead of having two separate types. But given the scope of the differences, I think two types may be necessary.
Additional context
none

This issue is highly requested but I don't imagine it coming any time soon. There are too many issues with allowing speech bubbles that won't be easy to solve. If it comes it will surely come in v2 since it will require a rewrite of many of the elements that Dialogic uses to generate the scenes. Thanks for making the issue and hope we can eventually add it :)

There are too many issues with allowing speech bubbles that won't be easy to solve

@coppolaemilio are these issues documented somewhere? I'd be curious to know what the challenges are so I can look into them.

not emilio but
@bitbrain issues are marked with milestones and grouped with labels (most of them). Usually they don't include a workaround or implementation to make 'em possible. Not sure if is that what you were asking for

@AnidemDex from what I saw Emilio wrote, simply adding speech bubbles seems to be difficult to do as part of 1.x and I try to understand what the challenges are to make speech bubbles happen in 1.x
One thing I suspect is how Dialogic instantiates dialogues and that it is difficult at the moment to make a distinction between "on screen dialogues with user input" and "over-head dialogues displayed in speech bubbles"

@bitbrain While trying to implementing it by myself I got these issues:

Dialogic was made with Visual Novels in mind, so most of the development of the plugin is focused on that (but many people thinks that was made with any game is suited to use this plugin in mind when is not that case).
Dialogic dialog node uses fixed sizes and positions for everything. No idea about why is that that way since they are Control nodes.
Mixing Control nodes and Node2D types is not something easy (and is something not recommended). As an example, there was a lot of people mixing them both and Emilio ended adding the CanvasLayer by default in the plugin to avoid issues related to that.
Dialogic uses a very specific instantiation behaviour, and changing it at this point will require to redo the entire node that instances it.

It can be done, I think? But will require to solve those points. I decided to wait until 2.0 is something that is in mind to start making PRs here again, and while that's something, I ended making my own implementation of dialog node from a fork that I made long ago

Hey folks, little update on this: The new system in 2.0 allows for very manual creation of themes and there is a handful of example scenes to pick from. One of them is a speech-bubble:

I think the new system should satisfies all the needs you might have. When 2.0 goes into beta I will try to create a little mock-up scene that actually uses the text bubble on a moving character, but for now I think it's possible feature-wise so I will close this.

@Jowan-Spooner my body is ready!!!


Show snippet even if the conversation is muted, per Coyne

@keybase/react-hackers
(See DESKTOP-3065 comment history for the backstory on the decision to no longer hide snippets when a conversation's muted.)

The commits 3909c7897181...8c5f6a0b16c7 introduce visual changes on linux. :mag_right: 3 changed

Changed: Chat_Conversations_List-Selected_Normal (before) (after)

Changed: Chat_Conversations_List-Selected_Muted (before) (after)

Changed: Chat_Conversations_List-Normal (before) (after)


fix: tutorials page crashing the page

:tada: This PR is included in version 2.5.2 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


the same issue continues(Metroseries)

Source information
Metroseries 13.5
Source language
Spanish
Steps to reproduce
1.open Metroseries extension
2.Play any series on Metroseries extension
Expected behavior
that shows all the episodes.
Actual behavior
It doesn't show the chapters.
it stays charging infinitely.
Aniyomi version
<IP_ADDRESS>
Android version
Android 13
Other details
No response
Acknowledgements

[X] I have searched the existing issues and this is a new ticket, NOT a duplicate or related to another open or closed issue.
[X] I have written a short but informative title.
[X] I have updated the app to version <IP_ADDRESS>.
[X] I have updated all installed extensions.
[X] I have tried the troubleshooting guide.
[X] If this is an issue with the app itself, I should be opening an issue in the app repository.
[X] I will fill out all of the requested information in this form.

When updating to the stable version <IP_ADDRESS> the problem was solved


[342] revert duration/duration_ms formatting for logstash

Turns out this approach was not compatible with the standard way of logging and
can result in breaking the indexing for the 'duration' field, breaking
aggregation and other operations reliant on the 'duration' field. The correct
approach is to leave 'duration_ms', fix any discrepencies in the logit filters
to ensure that it's indexed as a number, and then use 'duration_ms' for
aggregation.
Context
Changes proposed in this pull request
Guidance to review
Checklist

[ ] Make sure all information from the Trello card is in here
[ ] Attach to Trello card
[ ] Rebased master
[ ] Cleaned commit history
[ ] Tested by running locally

 Revert duration formatting for logstash


WIP: Minor changes

@humaton Your image is available in the registry: docker pull MISSING_REGISTRY_NAME/MISSING_IMAGE_NAME:SNAPSHOT-PR-22

[TEST]

@humaton Your image is available in the registry: docker pull MISSING_REGISTRY_NAME/MISSING_IMAGE_NAME:SNAPSHOT-PR-22

@humaton Your image is available in the registry: docker pull MISSING_REGISTRY_NAME/MISSING_IMAGE_NAME:SNAPSHOT-PR-22


PrivateEndpoint spec.forProvider.privateServiceConnection.privateConnectionResourceIdRef is missing

What problem are you facing?
PrivateEndpoint spec.forProvider.privateServiceConnection.privateConnectionResourceId doesn't have a ref option
How could Official Azure Provider help solve your problem?
Provide PrivateEndpoint spec.forProvider.privateServiceConnection.privateConnectionResourceIdRef

Hi @waterfoul,
Thank you for raising this issue. This is the argument you want to add a reference to: private_connection_resource_id. Feel free to contribute!

Following upjet, we just need to add the reference to azurerm_private_endpoint. However, it requires a type of the CRD, but in this case, it could be any type because we just need its id. How can we do that?
Weird note: this reference has been intentionally deleted: https://github.com/upbound/provider-azure/blob/main/config/network/config.go#L368

Hi @leinad87, thank you for your interest.
First of all, let me ask this, the PrivateConnectionResourceId field can be filled with more than one resource ID, not a specific resource, right? If this is the case, this may be the reason why the reference was removed. We currently cannot support referencing multiple resource types, so there is no way to do this at the moment.

Blocked by https://github.com/crossplane/upjet/issues/95

Thanks @turkenf ! I'll try the workarround of using a patch in a composotion.


The links in "Specifications and design" are broken

Summary
The links in the section Specifications and design to Plutus Technical Report (draft) and Plutus Core Specification and Extended UTXO Model are broken.
Steps to reproduce the behavior

Check the readme
click on links

Actual Result
404
Expected Result
Some papers I would like to read
Describe the approach you would take to fix this
Fix the links, but I don't know where the documents are
System info
Any

@michaelpj are you the right person to ping on this one or do you happen to know who that would be?


Distribution Code  of searching hyper-parameters

NNI 学生项目问题概述 / General Question of Student Program
请简要概述您的问题 / 观点 :
Short summary about the question / idea :
Hi, 在使用NNI超参搜索的时候, 比较好奇 分布式下 是怎么综合多台机器返回的结果的?  直观的想法是 Host收集机器结果, 然后实现搜索算法.
具体的源码能指个路吗? 找了半天没找到...
谢谢!
请提供 NNI 环境信息 :
nni Environment :

nni version:999.dev0
nni mode(local|pai|remote): remote
OS: Ubuntu 16.04
python version: 3.7
is conda or virtualenv used?: no
is running in docker?: yes

其他建议 / Other Advice
是否需要更新文档（是 / 否）:
Need to update document ( yes / no ) :
no
其他分享内容 :
Anything else we need to know :
Log message / 日志信息 :

nnimanager.log and dispatcher.log :

nnictl stdout and stderr :

NNI collect metric result reported by trial jobs in different, and use tuner to generate new parameter.
refer: architecture doc, trainingService code

NNI collect metric result reported from trial jobs in different training clusters, and use tuner to generate new parameter.
refer: architecture doc, trainingService code

So, NNI use TypeScript to encode different machine's Infomation and send the relative information by socket?

NNI collect metric result reported from trial jobs in different training clusters, and use tuner to generate new parameter.
refer: architecture doc, trainingService code

Thank your reply!!!!
So, NNI use TypeScript to encode different machine's Infomation and send the relative information by socket?

NNI use restful server to communicate between different machines, and use IPC to communicate between nniManager and tuner.

NNI collect metric result reported from trial jobs in different training clusters, and use tuner to generate new parameter.
refer: architecture doc, trainingService code

Thank your reply!!!!
So, NNI use TypeScript to encode different machine's Infomation and send the relative information by socket?

NNI use restful server to communicate between different machines, and use IPC to communicate between nniManager and tuner.

Gotta! Help a lot! 😊


ACTIVATION_LIMIT_REACHED from testing  app on different devices

I am developing an app on one device that will be run on a second device. I decided to test the app on the second device and was having issues getting porcupine to initialize on the second device, so I tried to run it in a private browser, and then also tried it on a third device to see if the issue was on the second device and I'm then I was seeing ACTIVATION_LIMIT_REACHED.
I came across this similar issue:
https://github.com/Picovoice/picovoice/issues/636
And @kenarsa reply:
https://github.com/Picovoice/picovoice/issues/636#issuecomment-1666529804
and I think I misunderstood what they were saying about clearing the browser cache. I tried clearing my browser cache on all the devices because I thought @kenarsa was saying to clear the browser cache to release the activation from the device, so now I am unable to access porcupine on any device. Is this able to be reset in any way? It would be nice to be able to manage the activated devices and remove access from unwanted devices.

There is no way to reset or clear. You must wait for your allowance to reset or move up your plan to get more allowances.


insert_into_table fails

Hi Markus again ;)
I try to just read a parquet file and call insert_into_table with the most recent pyarrow version:
from pyarrow import Table
import pyarrow.parquet as pq
from arrow_odbc import insert_into_table

reader: Table = pq.read_table(tf)
insert_into_table(reader, chunk_size, table, connection_string)

I get this error:
AttributeError: 'pyarrow.lib.ChunkedArray' object has no attribute '_export_to_c'

This is what I get for using private functions, I guess. Would need to look into it. As a workaround you could look into odbc2parquet which does have an insert option.

Hello @aersam ,
this is more likely an UX issue than a Bug. Inserting from a parquet file working fine. Please note that the insert works on a RecordBatchReader, rather than a table.
See: https://github.com/pacman82/arrow-odbc-py/blob/3945998e8b4cca5a190f744f6b1cdb1c11ca5403/tests/test_arrow_odbc.py#L473
We could of course think about providing an insert function based on a table, or improve the interface otherwise, to avoid such confusion.

Ok, tried adjusting my code and it now fails silently - maybe a rust panic? How do I diagnose this?

Would you have a small parquet file you could check into a branch which could help me reproduce?
What kind of database are you using?
What operating system are you on?

It's confidential data but I can try to generate a "fake" one which causes the error.
Operating System: Windows 10 (production will be Azure Functions Linux, which is similar to Ubuntu I think)
Database: Azure SQL Database, probably close to SQL Server 2022. I'm using ODBC Driver 17 as v18 is not available in Azure Functions yet

If you want you could also share your code

here's my target table:

CREATE TABLE [lake_import].[customer_sales_group](
	[customer_id] [nvarchar](20) NULL,
	[sales_group_id] [nvarchar](4) NULL,
	[sales] [float] NULL,
	[margin] [float] NULL,
	[year] [int] NULL,
	[month] [int] NULL,
	[sales_lager] [float] NULL,
	[margin_lager] [float] NULL,
	[sales_transit] [float] NULL,
	[margin_transit] [float] NULL
)

no indexes, no primary key

If you want you could also share your code

well, will try to create a minimal repo. the code relies on a rest service delivering the parquets...

Could it be that passing ##globaltemp table is the issue?

Ok, here we go. Python code:
import pyarrow.parquet as pq
from arrow_odbc import insert_into_table
from pyarrow import Table, RecordBatch, RecordBatchReader
import pyarrow as pa

tbl: Table = pq.read_table("repo.parquet")
print(tbl.to_string(preview_cols=tbl.num_columns))
connection_string = "Server=SERVER.database.windows.net;Database=DB;Authentication=ActiveDirectoryInteractive;Encrypt=yes;ConnectRetryCount=3;DRIVER=ODBC Driver 17 for SQL Server"
table = "lake_import.customer_sales_group"
chunk_size = 4000
schema = tbl.schema
batches = tbl.to_batches(chunk_size)
reader = RecordBatchReader.from_batches(schema, batches)
insert_into_table(reader, chunk_size, table, connection_string)

Output:

Data is here:
repo.zip
Is is a problem to insert large_string into nvarchar(4) ? I will execute this with a global temp table in the end, but it seems that's not the issue

I could reproduce the issue here: https://github.com/pacman82/arrow-odbc-py/tree/reproduce-bug
Then I have time, I'll try to minimize the example further. Are all columns needed to reproduce. Must I start from a parquet file and so on. I think after that I'll have some idea how to reproduce it in pure Rust.
Currently I can not tell if the access violation is a consequence from panicing in Rust while running in the python interpreter or if there is no panic and the access violation is the cause of it stopping. I'll hope a minimal example will yield the answer.
Thanks for bringing the issue to my attention.

Hello @aersam ,
got to play around a bit more with this, this evening, and I think I got a more minimal example reproducing it. Parquet is only indirectly involved. PyArrow translates your file into a table with a schema containing columns of type large_string it seems to be this column type which breaks arrow-odbc-py. I can reproduce the bug with essentially this piece of code:
    schema = pa.schema([("a", pa.large_string())])

    def iter_record_batches():
        # The string value is not actually large, just the schema information allows it to be
        yield pa.RecordBatch.from_arrays([pa.array(["Hello"])], schema=schema)

    reader = pa.RecordBatchReader.from_batches(schema, iter_record_batches())

    # When
    insert_into_table(
        connection_string=MSSQL, chunk_size=20, table=table, reader=reader
    )

For fun and games I inserted your Parquet file using odbc2parquet (which went fine). I also queried the data then back into a parquet file (again using odbc2parquet). Which left me with a similar parquet file, mostly different that it was written in an older version of the parquet file specification. Using pyarrow it translated into an arrow table containing just plain strings (rather than large_strings) and inserted fine.
Next time I have some spare time on my hands, I want to see why it stops rather than forwarding an exception. After that eventually there can be support for large_strings.
Cheers, Markus

Ok, thanks! I think strings beyond 2GB are not a frequent use case, but it seems some popular libs generate large_string types regardless of the actual size. My col had a max size of 4 chars... I used polars and pyarrow, must be one of them

I think strings beyond 2GB are not a frequent use case, but it seems some popular libs generate large_string types regardless of the actual size.

Inserting large_string will now work starting with arrow-odbc-py 0.3.14 which has been released.
For convinience a from_table_to_db function has also been added. Inserting from a pyarrow table rather than a RecordBatchReader.
Cheers, Markus


Fix typos and grammar.

While taking a look at the project I noticed a typo and some inconsistencies. This resolves them as well as some grammatical fixes.

Sweet, thanks!


Adding support for Letterbox integer scale.

Unlike:
https://www.scirra.com/tutorials/73/supporting-multiple-screen-sizes#h2a4
We have letterBox function in latest phaser, Something like this scaleSpritePropotional(sprite,width,height,mode)
Extending with the mode
like:
Phaser.LETTERBOX = true;
Phaser.LETTERBOXINTEGER = true:
function scaleSpritePropotional(sprite,width,height){
     width = Math.round(width);
        height = Math.round(height);
           if(Phaser.LETTERBOX){
           sprite.scale.x = 1;
            sprite.scale.y = 1;
        if ((sprite.width <= 0) || (sprite.height <= 0) || (width <= 0) || (height <= 0))
        {
            return sprite;
        }

        var scaleX1 = width;
        var scaleY1 = (sprite.height * width) / sprite.width;

        var scaleX2 = (sprite.width * height) / sprite.height;
        var scaleY2 = height;

        var scaleOnWidth = (scaleX2 > width);

        if (scaleOnWidth)
        {
            scaleOnWidth = letterBox;
        }
        else
        {
            scaleOnWidth = !letterBox;
        }

        if (scaleOnWidth)
        {
            sprite.width = Math.floor(scaleX1);
            sprite.height = Math.floor(scaleY1);
        }
        else
        {
            sprite.width = Math.floor(scaleX2);
            sprite.height = Math.floor(scaleY2);
        }

         }else if(Phaser.LETTERBOXINTEGER){
                 sprite.width /= 2;
                 sprite.height / =2; //To maintain the same aspect ratio of the image.
         }
         //  Enable at some point?
         sprite.x = Math.floor((width - sprite.width) / 2);
         sprite.y = Math.floor((height - sprite.height) / 2);

}

The logic is inspired from the construct 2 Drop down for the multiple screen size keeping the asset aspect ratio same for multiple screen.

Thank you for taking the time to open this issue. However, official support for Phaser 2 has now ended as we focus on preparing Phaser 3 for beta release. In a bid to keep the project tidy, and avoid confusion, we are closing all v2 related issues.
This does not mean your issue won't be looked-at. In November 2016 the Phaser CE (Community Edition) project began. The aim of Phaser CE was to allow the community to continue v2 development. Since then it has gained significant traction, with many updates and releases.
If you are still interested in having your issue investigated we strongly recommend testing the latest Phaser CE release. And only if the problem persists, opening an issue on the Phaser CE repo.


deps: upgrade deps

测试依赖 koa-locales 修复 cookies 的 signed 问题 https://github.com/koajs/locales/pull/24

Current coverage is 100% (diff: 100%)

Merging #4 into master will not change coverage

@@           master    #4   diff @@
===================================
  Files           3     3
  Lines          24    24
  Methods         0     0
  Messages        0     0
  Branches        0     0
===================================
  Hits           24    24
  Misses          0     0
  Partials        0     0

Powered by Codecov. Last update 38ae2fc...12e3f82


Add Referee page, with authentication token

Context
This PR is the first slice of replacing the google form to a Referee page. This includes:

Create the token for the referee (stored on Reference model)
Create a new page to allow the referee to enter the comments https://apply-beta-prototype.herokuapp.com/reference/comments
Include the token in the email and check the token is correct when trying to access the reference view

Changes proposed in this pull request

new Token on Reference model
update email with new Token
Add new view/controller in a new namespace

NOTE:  before merging this PR, we want to add a Feature Flag to switch between Google form/Reference page
Guidance to review
Tests are a good starting point
Link to Trello card
https://trello.com/c/RrlqYDMz/585-referee-can-provide-a-reference-via-dfe-apply-service-🏈


az aks check-network command cannot locate resource group.

Describe the bug
When executing the command az aks check-network outbound, it accepts the resource group as an input but subsequently reports that it cannot locate it. Interestingly, when the debug flag is utilized, the very same resource group that the error message claims cannot be found is present in the debug output.
example:
Related command
az aks check-network outbound --name  --resource-group  [--custom-endpoints ] [--node-name ]
Errors
cli.azure.cli.core.azclierror: (ResourceGroupNotFound) Resource group 'MC_AKSLearn_testingNodePoolCount_eastus' could not be found. Code: ResourceGroupNotFound Message: Resource group 'MC_AKSLearn_testingNodePoolCount_eastus' could not be found. az_command_data_logger: (ResourceGroupNotFound) Resource group 'MC_AKSLearn_testingNodePoolCount_eastus' could not be found. Code: ResourceGroupNotFound Message: Resource group 'MC_AKSLearn_testingNodePoolCount_eastus' could not be found.
Issue script & Debug output
unable to share output of debug
Expected behavior
Perform outbound network connectivity check for a node in a managed Kubernetes cluster.
Environment Summary
azure-cli                         2.59.0
core                              2.59.0
telemetry                          1.1.0
Extensions:
aks-preview                      3.0.0b5
Dependencies:
msal                              1.27.0
azure-mgmt-resource             23.1.0b2
Python location '/opt/az/bin/python3'
Extensions directory '/home/erifernandez/.azure/cliextensions'
Python (Linux) 3.11.8 (main, Mar 27 2024, 04:03:13) [GCC 10.2.1 20210110]
Legal docs and information: aka.ms/AzureCliLegal
Your CLI is up-to-date.
Additional context
No response

Thank you for opening this issue, we will look into it.


SSDT error SQL71526 on stored procedure.

SqlPackage or DacFx Version:
//////////////////////////////////////////////////////////
Microsoft Visual Studio Community 2022
Version 17.9.0
VisualStudio.17.Release/17.9.0+34607.119
Microsoft .NET Framework
Version 4.8.04161

SQL Server Data Tools   <IP_ADDRESS>
Microsoft SQL Server Data Tools
//////////////////////////////////////////////////////////
Steps to Reproduce:
There is a stored procedure which is working fine on SSMS.
But same stored procedure is failing with below error in SSDT ;
SQL71526: A table that has a defined column set can have up to 30,000 columns with a maximum of 1024 non-sparse and computed columns. Tables that do not have column sets are limited to 1024 columns.

The line number highlighted in the message corresponds to a CTE in this SP. (which only has 10 columns ).
If we expand the asterisk (*)  in the select list of this CTE to column names , the issue disappears.
(DacFx/SSDT)

@hacitandogan can you please put an example for the procedure?

@llali  ,
obfuscated_sp.txt
I am sharing an obfuscated / simplified version of the sp attached.

.


Mining plugin

Shows progress indicators for respawn times on all rocks that can be mined (including motherlode & amethyst)

I see that you are hardcoding the respawn time for each ore, but isn't the respawn time variable upon server population? Or was that changed at some point?

This is covered by #8973


undoing changes in 3git doesn't reflect

in any document

add ??
reload
remove ??
reload (won't work)

Undoing changes without a commit?
I mentioned this problem before, we basically use git, hence we cannot get the changes using git diffunless we commit this changes, then do a revert commit or so.
The should mention this in docs or find another way (maybe maintaining a custom index instead of git).

@abom better solution would be tracking the output dir and do git reset in case of no changes

Suggested approach

At the beginning on a specific commit, it will process normally and then it will store the git revision in 3git configs.

Then assume we have untracked file file1.md, and modified files file2.md, file3.md we can store these files in a list and append it to the 3git config

When we process we should check if these files are available in the list or not [can be tracked with git diff], if not available we should reprocess these files. and update this list

Commit
https://github.com/threefoldtech/jumpscaleX_core/commit/7328dc3090a9036214713cd85e98839336fd422c
Changelog

Applied the second scenario in the issue description.

How to verify

Start 3bot server

load any wiki for example
jsx wiki-load -n grid -u https://github.com/threefoldfoundation/info_grid -f

Check the wiki is loaded at: https://<IP_ADDRESS>/wiki/grid

modifiy any file for example
/sandbox/code/github/threefoldfoundation/info_grid/docs/concepts/cloud_units.md

reload the wiki
jsx wiki-reload -n grid

Check the changes in https://<IP_ADDRESS>/wiki/grid#/concepts/cloud_units

restore the file to the original state

reload the wiki
jsx wiki-reload -n grid

Check the changes in https://<IP_ADDRESS>/wiki/grid#/concepts/cloud_units make sure it's back to the original state

verified on branch development_fixes103


add support for providing a Dart API for Javascript events

We'd like to include support for providing a Dart API for events (especially CustomEvents), as a way to improve our interop story. This would be similar to how today we allow providing a Dart type for custom elements declared in Javascript.
Not sure if we should allow extending from Events though.
This bug will probably require changes in dart2js and Dartium too. While this is important, the change is not blocking for Milestone 1.6.

This issue has been moved to dart-lang/polymer-dart#261.


Voice messages

Something (or a combination of things) in this branch makes voice messages bridge beeper → iMessage. I'm putting it up here now so that other people can take a look at it if they would so like, but I don't want to merge it in this state since it's still kinda hacky and I need to figure out the bare minimum we should do to make voice messages work. I'll do that tomorrow tho.

Turns out that it was nothing in this branch and all in mautrix-imessage - we just needed to enable then in the SendMediaMessageCommand


Added script for #442

What this PR does / why we need it: for issue #442
Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #442
Special notes for your reviewer:

May be you can add the code to auto-detect as well as part of the next PR.
can you elaborate this?

the current setup-remote.sh expects that user provide $reponame
assume the following steps:
mkdir -p openebs
cd openebs
git clone https://github.com/kmova/openebs.git
cd openebs

After performing above steps, user will have to manually set $reponame=openebs and then run setup-remote.sh. Instead, if user runs setup-remote.sh from within openebs directory, the script can auto -detect the repo name.

But I don't know how to do that can you guide me?

http://bit.ly/2zQoW3s Is this news is true? are you providing special edition hacktoberfest t-shirt?

@Logan1x Yes it is true, will you please email me the address you want the t shirt to be shipped to, and I will get this processed right away<EMAIL_ADDRESS>

Done😊.


InvalidChoiceError when container type is "MESOS"

In this line: https://github.com/thefactory/marathon-python/blob/master/marathon/models/container.py#L18 the listed choices for container type contains only "DOCKER", but Marathon supports "MESOS" here as well.  So, using the MESOS type throws an exception when it should not.

Resolved by #154


How about upgrade GORM to v2

hello, is there any plan to migrate gorm to version 2?

Same problems and needs

Any Updates


Remove caching for table, schema and column names using SpEL expressions

This is a followup to https://github.com/spring-projects/spring-data-relational/pull/1461
While the above ticket successfully enables SpEL for Table and Schema,
allowing us to have a lightweight solution for Multi Tenancy / Multi Schema,
it only works for queries / select statements.
(e.g. select .. from tenant_0, select ... from tenant_5)
For inserts, it will always use the first spel expression that was resolved
(e.g. always insert into tenant_0)
A lightweight alternative to achieve the goal of multi schema,
could have been the NamingStrategy.
Unfortunately, this also gets Cached inside the CachingNamingStrategy
and also evaluated only once.
Having a solution for either one of these, would be awesome.
Thx in advance
-- cut examples ---
https://github.com/table(name = "insurance", schema = "#{@tenantIdBean.getPrefix()}")
https://github.com/component
public class TenantIdBean {
public String getPrefix() {
return "tenant_" + HttpInterceptor.getTenantId();
}
}

The same problem probably appears for standard CrudRepository methods like findAll and findById and so on.
I think we should have some way to configure the Memoization of SQL statements with three options: NONE, ALWAYS and DYNAMIC, where the last checks if SpEL expressions are used and only uses memoization when none is.


allow rendering of ReturnDict

currently only ReturnLists are supported. If someone wants to export a e.g. RetrieveView, XLSXRenderer fails at _flatten() because of KeyError.

Thank you! I've got this on master, and am going to test it in a few of my environments before releasing.


Implement graceful exit

This is a follow up to #139, I realized that the documentation I added is not actually what happens.
 It's graceful in that it's killing the threads before exiting the program, but it's not really graceful in regards to what those threads are actually doing (ie, processing message).
With this PR I am implementing the following:
When sending SIGINT, SIGQUIT, or SIGTERM to Hutch, it will:
1. Run shutdown on the worker_pool
It will set working to false in the pool, and enqueue an exception in the queue for each worker thread. Upon reception of the exception, the worker loop will end.
2. Run join on all the threads
#shutdown kills the threads that were idling, but some workers were potentially already running so they won't get to the exception until their current job is done.
By calling join, we wait for Hutch::Config[:graceful_exit_timeout] seconds (defaults to 11 to be consistent with other timeouts default value) for the threads to finish (their next job in the queue is the exception).
3.  I can't find where that is defined (hutch, bunny, rabbitmq?), but I would like to add that to the README if that's indeed the expected behavior.

do not merge this, I am not sure this is actually working when there's a lot of messages in the queue being quickly processed. But happy to hear whether you think this is a valuable feature

@midu this is a sensible feature. Unacknowledged messages are re-queued by RabbitMQ when channel is closed (or connection is lost). I highly recommend reading RabbitMQ tutorials and Bunny documentation.  Is it a mistake?

It is something we want. I just keep answering questions that are covered by the docs ;)

Oh, sorry about that. I really appreciate that you take the time to answer my questions!


Edit button on Home screen

When Tom V. is working in DPUL, clicking on the "edit' button on the Home screen always gives him an error.  I suggested he try some different browsers but this doesn't make a difference.  He has used the Mac Firefox version, and also Firefox 53.0 on Windows.

Looks like it's only an issue with the east asian collection. Backtrace: https://app.honeybadger.io/projects/51733/faults/33461705#notice-summary


Tracking Issue: Patchable Methods

This issue is meant to track the status of patching methods, as well as a public idea board. This is sectioned mainly into two achievements: associated functions and methods.

Associated Functions
Prior to filing this issue, a method of patchable associated functions was discovered. The final implementation syntax is as follows:
struct Foo {}

#[patchable]
impl Foo {
  fn bar() {}
}

fn main() {
  Foo::bar.hotpatch_fn(|| unimplemented!());
}

It is (roughly) implemented internally as follows:
struct Foo {}
static __hotpatch_implgen_Foo_bar: hotpatch::Patchable<(Self, i32), ()> =
    hotpatch::Patchable::__new( ||
        // macro passthrough from the initial implementation
    );
fn __hotpatch_staticwrap_0_bar() -> &'static Patchable<(Self, i32), ()> {
    &__hotpatch_implgen_Foo_bar
}
impl Foo {
    pub const bar: hotpatch::MutConst<Patchable<(Self, i32), ()>> =
        hotpatch::MutConst::new(__hotpatch_staticwrap_0_bar);
     // where MutConst is a const reference to a static variable
     // It's pretty much an associated static with extra steps (they aren't supported)
}

Problem: Because the implementation must be separated from the impl block, this cannot support a self parameter (in any form).
Problem: Self is not available. I have yet to find a workaround, but I suspect one exists using dummy consts.

Methods
Recently I discovered a way of making patchable methods. The main holdup was declaring a way of having some associated static holding a function pointer with a self parameter. And the only way to get a self parameter to work is with a method directly in an impl block.
Or at least, I thought so. Traits perfectly achieve this. Combining this with the fact that there can be multiple struct associations under the same name if they're in a trait and of different types yields a perfect solution. The working syntax is as follows:
struct Foo {}

#[patchable]
impl Foo {
  fn bar(&self) {}
}

fn main() {
  let foo = Foo::new(); // new defined elsewhere
  foo.bar(); // works

  // hotpatched as the following:
  Foo::bar.hotpatch_fn(|| unimplemented!());

  // Yet the following does NOT work for hotpatching:
  foo.bar.hotpatch_fn(|| unimplemented!());
  // This is GREAT for cleanliness
}

The macro-expanded implementation is still being figured out. However, the following is a working demo of making Foo::bar different from foo.bar:
struct Foo {
    data: i32,
}

impl Foo {
    fn new(data: i32) -> Self {
	Self{data}
    }
}

// begin macro generated content

// macro input:
// #[patchable]
// impl Foo {
//     fn bar(self) {
//         println!("hello from bar! This foo object has data: {}", self.data);
//     }
// }

impl Foo {
    #[allow(non_upper_case_globals)]
    const bar: i32 = 0;
}

trait FnTrait { // final implementation will use mangled names
    fn bar(self);
}

impl FnTrait for Foo {
    fn bar(self) {
	println!("hello from bar! This foo object has data: {}", self.data);
    }
}

// end macro generated content

// test
fn main() {
    let foo = Foo::new(100); // just gives foo some instance data
    foo.bar(); // Has access to self, and the data  -^-----------^
    println!("{:?}", Foo::bar); // Foo::bar is a const i32; totally different!
}

I really like the fact that foo.bar is actually a method, and that foo.bar.hotpatch isn't allowed. Forcing the use of Foo::bar.hotpatch cements the idea that the method is patched for all instances.
Problem: trait associated functions (without self) are not privy to the same non-competition rules. This may mean a macro may need to decide whether to use the associated function implementation or the method implementation. This feels like a rustc bug to me.

A workaround for maintaining Self in associated functions has been found (just took me a while to get around to writing anything). As far as I am aware, this is a full-featured solution:

// Macro input:

// impl Foo {
//     pub fn bar(msg: &str) {
//         println!("{}", msg);
//     }
// }

// Macro output

trait TraitWrap {
    fn staticwrap_impl_bar(msg: &str);
}

impl TraitWrap for Foo {
    fn staticwrap_impl_bar(msg: &str) {
        println!("{}", msg);
    }
}

type PatchableStaticWrap0 = hotpatch::Patchable<(&'static str,), ()>;
static STATICWRAP_STATIC_BAR: PatchableStaticWrap0 = hotpatch::Patchable::__new(|| {
    hotpatch::Patchable::__new_internal(move |args| Foo::staticwrap_impl_bar(args.0), "", "")
});
fn staticwrap_fn_bar() -> &'static PatchableStaticWrap0 {
    &STATICWRAP_STATIC_BAR
}
impl Foo {
    #[allow(non_upper_case_globals)]
    pub const bar: hotpatch::ConstRef<fn() -> &'static PatchableStaticWrap0> =
        hotpatch::ConstRef::new(staticwrap_fn_bar);
}

// And...
pub struct ConstRef<T> {
    item: T,
}
impl<T> ConstRef<T> {
    pub const fn new(item: T) -> Self {
        Self { item }
    }
}
impl<T: 'static, P: 'static> std::ops::Deref for ConstRef<T>
where
    T: Fn() -> &'static P,
{
    type Target = P;
    fn deref(&self) -> &Self::Target {
        &(self.item)()
    }
}

When I am next available an implementation will be written.

A workaround for maintaining Self in associated functions has been found (just took me a while to get around to writing anything). As far as I am aware, this is a full-featured solution:

// Macro input:

// impl Foo {
//     pub fn bar(msg: &str) {
//         println!("{}", msg);
//     }
// }

// Macro output

trait TraitWrap {
    fn staticwrap_impl_bar(msg: &str);
}

impl TraitWrap for Foo {
    fn staticwrap_impl_bar(msg: &str) {
        println!("{}", msg);
    }
}

type PatchableStaticWrap0 = hotpatch::Patchable<(&'static str,), ()>;
static STATICWRAP_STATIC_BAR: PatchableStaticWrap0 = hotpatch::Patchable::__new(|| {
    hotpatch::Patchable::__new_internal(move |args| Foo::staticwrap_impl_bar(args.0), "", "")
});
fn staticwrap_fn_bar() -> &'static PatchableStaticWrap0 {
    &STATICWRAP_STATIC_BAR
}
impl Foo {
    #[allow(non_upper_case_globals)]
    pub const bar: hotpatch::ConstRef<fn() -> &'static PatchableStaticWrap0> =
        hotpatch::ConstRef::new(staticwrap_fn_bar);
}

// And...
pub struct ConstRef<T> {
    item: T,
}
impl<T> ConstRef<T> {
    pub const fn new(item: T) -> Self {
        Self { item }
    }
}
impl<T: 'static, P: 'static> std::ops::Deref for ConstRef<T>
where
    T: Fn() -> &'static P,
{
    type Target = P;
    fn deref(&self) -> &Self::Target {
        &(self.item)()
    }
}

When I am next available an implementation will be written.

Took a sidequest for fn_ptr branch. This fixes an intermediate issue I was having with incorrect lifetime elision on patchable types. This should be good to go next.


RT-1.28 | Changes and adding deviations

Made below changes:

Adding workaround with deviation to set route tag , and match tag to redistribute
Deviation for telemetry verification for community value of type string
Deviation for default route policy

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 55.5%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
1983

Relevant Lines:
3573

💛  - Coveralls


Support for save states

Description
There's still no efficient way to support the management of save states in EmuKit.
We should implement such support with the following goals:

Load and save support for states
Thumbnail support
Inversion of control and storage control on the Emukit side, with multiple engines (ex: localStorage, IndexedDB, etc.)

This is now considered done


MAD is "Median Absolute Deviation" or "mean absolute deviation" ?

Describe the bug
I found the Descriptive statistics for variables in the report  has one item:
Median Absolute Deviation(MAD)"
but in the code, model:  describe.py line 67:
"mad": series.mad(),
In pandas 1.01: Series.mad is to caculate "the mean absolute deviation of the values"
Series.mad(self, axis=None, skipna=None, level=None)[source]¶
Return the mean absolute deviation of the values for the requested axis.
So, I guess the descriptive statistics should be "Mean Absolute Deviation(MAD)"

To Reproduce

Version information:

Additional context

This is indeed a bug. At v2.6.0, the calculation is wrong, it will get 'mean absolute deviation' while we actually want 'median absolute deviation'.
As far as I know, it has been fixed by @sbrugman in the develop branch (See describe.py line 56) and will be fixed in the next release.

Great catch. This is fixed in the development branch and will be in the next release.


Add more maintainers

As the repo grows rapidly, I believe we need more hands on fixing code and reviewing PR.
I recommend @danghai and @SaadBenn to become our new maintainers since they contributed a lot lately.
What do you guys think?
@goswami-rahul @christianbender

Yeah, of course. Then I can work on #162  (we wait of your approval, keon?)

Yes, it is a good decision. More active maintainers will help the repo grow faster :)

Welcome :)
I am in NYC by the way.


Material decompilation make a wrong .vmat

Describe the bug
when you decompile a material it generates a .vmat with a wrong source file. For example:
If you decompile backstage_grate_001a.vmat_c the reconstructed .vmat will look like this

but the decompile texure will be not materials/metal/backstage_grate_001a_color.png instead will be named backstage_grate_001a_color_psd_e3ed4a9a.png so when you load into hammer it does not compile automatically.
wrong_vmat.zip
https://github.com/ValveResourceFormat/ValveResourceFormat/assets/110506367/ebad5cc5-20e1-41ff-9da8-7cb4c9819aec
So instead, the recontructed .vmat shoud have the name of the compiled texure. Another example:

Relevant log output or exception with stacktrace
none.

What game does this happen in
SteamVrbeta
Reference file in a Source 2 game
backstage_grate_001a.vmat_c
Expected behavior
it shound not compile automatically.
What version of VRF are you using?
9.0.3293

This is failing due to one of these conditions:

Texture is not found due to it being on desktop.
Compiled shader is not found, due to material being in desktop.

Please place the assets to a directory where they would be readable by the Source 2 engine itself.


Fix issue #324 windows line endings not respected

I came across this issue today as I was putting tslint rules into place on our code base. All of our development occurs on windows, and I was surprised to see so many jsdoc formatting errors. I dug in and found that #324 exactly described what was happening.
After digging further I found that the jsdocFormatRule did not support windows line endings! How funny for a TypeScript library I thought :)
I've gone ahead and implemented a fix. The reason I'm solving this with a regular expression and not detecting the host OS with require('os').EOL or process.platform, is because the line ending is dependent on where the file was originally authored, not where tslint is running.
Let me know if you would like me to update any comments, test, code for this PR.
Cheers!

nice, thanks for the explanation and the bugfix!


Make CSVReader IteratorProtocol safe

Hey @dehesa,
This one is more of a direction for an idea rather than a concrete change.
I do really like the Sequence reading API. I'm working with a very large CSV file (in the gigabytes) can't parse it all at once. But the current design has the documented downside of crashing on bad data.
Maybe the iterator can just return a Result capturing the row or error instead? I think this could be a good start, but it would be a backwards incompatible change. I do like that it removes a try! from a public facing API.
This change only allows for iterating over parsed rows [String] but iterating over parsed records Record could also be nice. Though, I suppose what I really want is a Sequence for the decoder.
Another direction would be to deprecate CSVReader being an IteratorProtocol itself and offer subtypes for multiple ways of iteration. And there was can choose to return a Result instead.
reader.makeRowIterator() // RowIterator
reader.makeRecordIterator() // RecordIterator
reader.makeDecoderIterator(CustomType.self) // DecodingIterator

// or

reader.rows // Sequence (RowIterator)
reader.records // Sequence (RecordIterator)
reader.decoding(CustomType.self) // Sequence (DecodingIterator)

Thanks for reading!
Josh

You bring some interesting points. Lets see if I can break them down:

CSVReader conforming to Sequence where its next() function returns Result<[String],CSVError> instead of [String]?.
I am conflicted about this one. It is certainly not great that CodableCSV is crashing on invalid parsing. The problem is that IteratorProtocol.next() doesn't support a throwable operation. A possible solution (as you indicate) is to return a result. However this would break the Sequence extensions expectation of ending with a nil value. If CSVReader would implement your suggestion, there would be two endings: nil (for successful ends) and Result.failure for invalid parsing. There are no way to express that in the built-in Sequence functionality, such the for-in clauses, or the map function. For example:
for case .success(let row) in reader {
    // This would only execute on success.
}

The problem with the code above is that it would keep querying reader.next() even after a .failure is emitted. Sure enough, you can emit a failure and then emit a nil value on the next request, but now you are sending more values than expected.
I see the current next() implementation as the standard library's Array subscript indexing. Something that is dangerous, but performant.

Support for big files.
That is currently supported in CSVReader by setting the presample configuration value to false (which is the default) and using a file URL initializer/parser. Such as:
let reader = CSVReader(input: URL(...))
while let row = try reader.parseRow() {
    ...
}

It is true, that this doesn't allow the usage of Sequence functionality, such as:
let reader = CSVReader(input: URL(...))
let value = reader.allSatisfy { ... }

It would be great to be able to use that kind of syntax. I quite like your idea of .rows and .records returning a different Sequence (one with Element==[String] and the other with Element==Record), but how would we solve the problem in point 1.

Iterating while decoding to a custom type.
If we manage point 2, then decoding to a given type is just a matter to:
let values = reader.rows.map { CustomType(strings: $0) }

I would like to keep CSVReader and CSVDecoder tasks separated.

CSVReader parses files/data into raw strings.
CSVDecoder gets those raw strings and decodes into a custom type.

CSVDecoder support the same efficient file URL as CSVReader (ultimately it uses a reader underneath), although currently the buffer strategy is caching all raw string arrays (Strategy.Buffering.keepAll) to support Codable's random access through keyed containers. Implementing Strategy.Buffering.ordered, should be fairly easy, though.
How does that sound?

However this would break the Sequence extensions expectation of ending with a nil value. If CSVReader would implement your suggestion, there would be two endings: nil (for successful ends) and Result.failure for invalid parsing.

It seems like it could still work fine for the case of ignoring failures?
Current behavior of faulting on bad data:
for result in reader {
  let row = try! result.get()
   // process row
}

You could halt on the first bad row throwing an error:
for result in reader {
  let row = try result.get()
  // process row
}

If you wanted to ignore invalid rows and iterate the rest:
for result in reader {
	if let row = try? result.get() {
		// process row
	}
}

Though, maybe I'm confusing a property of the parser. Can it continue parsing the next line after an error? Maybe just one line has a bad escaping quote? Or is any error in the parser unrecoverable?

That is currently supported in CSVReader by setting the presample configuration value to false (which is the default) and using a file URL initializer/parser.

Yeah, I'm currently using that API it was works fine.
Baking in a sequence for records would be nice to have. 👌🏻

Implementing Strategy.Buffering.ordered, should be fairly easy, though.

I did run across .ordered but it seemed to be a work in progress. I could help!
I wasn't sure it would handle the iteration case since the decode signature only seemed to support returning an Array.
What about an additional signature on CSVDecoder that looked more like:
func decode<T:Decodable>(_ type: T.Type, from url: URL) -> AnySequence<T>

Thanks for the comments so far. This is very helpful for understanding the direction you're taking the library.

(Off topic: Where do you prefer taking just questions/ideas? Are GitHub issues preferred or do you have another medium. Whatever works for me!)

Off topic: Where do you prefer taking just questions/ideas? Are GitHub issues preferred or do you have another medium. Whatever works for me!

I honestly don't mind. PRs and issues are tools like any other: if you want to reference existing code while replacing it with pseudocode, making a PR seems to be pretty useful. Syntactically 😄 an issue seems to fit more, but it lacks the previously mentioned advantage. So whatever fits for the topic at hand.

Though, maybe I'm confusing a property of the parser. Can it continue parsing the next line after an error? Maybe just one line has a bad escaping quote? Or is any error in the parser unrecoverable?

Yeah, that is the main problem. Once you throw an error, the parser should invalidate the whole operation because:

UTF8 & UTF16 are sequential encodings (they depend on previous bytes), thus one invalid scalar can mess the whole file.
If the error occurred on an escaped field, or there was an invalid field or row delimiter, the whole CSV may be completely invalid.

For sure there would be some situations where one could technically recover, but I am not sure it is worth it to bake that maybeness into the library syntax. Besides some times, the library may believe that it has recover successfully, but actually is misinterpreting the whole file.

Regarding the other remaining topics:

Strategy.Buffer should be used by ShadowDecoder.Source.Buffer to release parsed rows once they have been requested by the user. Currently the strategy is called .keepAll since I am not throwing any out. I mainly do this, because I never know if the user will request an already parsed row (KeyedDecodingContainer allows this).
However, if the user explicitly marks the strategy, the library can assume that user knows what is doing and release the row once is parsed. That will help immensely decoding big CSV files since we are only keeping in memory one row at a time.
If you would like to give it a go. It is definitely worth it. It would help implementing if you have a good understanding with Codable, though. Do you?

Having a CSVDecoder returning a Sequence has the same problems as the point 1 on the previous comments.
The Sequence and IteratorProtocol protocol are defined under the supposition that the next() functionality doesn't fail. That is why we cannot really reuse it. At least I cannot see how.
I see the value of having a "Sequence" like syntax, but as stated I would have to think more about it. In a worst case scenario we could replicate the Sequence functionality but always throwing. For example, we could have a next() throws -> Element? and also a map() that not only rethrows, but actually always throws.
Also the syntax should be very clear that you are decoding rows. So something similar to what you were suggesting for CSVReader could work on CSVDecoder; i.e.
let decoder = CSVDecoder()
try decoder.rows(from: URL(...)).forEach { ... }

I discussed the KeyedContainers random access behavior on an issue some time ago (#2), if you want to take it a look.
There are also some smaller topics worth pursuing:

Building a small benchmarking test would help figuring out whether we are making the right changes.
There are no tests to check whether the file URL API works well.

A bigger one would be:

Being able to infer whether a file has a header, or what delimiters are being used would be amazing.

I also came across this, with a big list of tools for CSV that we could replicate 😄

Thanks for the advice. I'll go poking around .ordered.
Closing out this PR.


Made minor changes to custom-tabular-bq-managed-dataset file

Made minor changes to custom-tabular-bq-managed-dataset file

[X] Use the notebook template as a starting point.
[X] Follow the style and grammar rules outlined in the above notebook template.
[X] Verify the notebook runs successfully in Colab since the automated tests cannot guarantee this even when it passes.
[X] Passes all the required automated checks. You can locally test for formatting and linting with these instructions.
[ ] You have consulted with a tech writer to see if tech writer review is necessary. If so, the notebook has been reviewed by a tech writer, and they have approved it.
[X] This notebook has been added to the CODEOWNERS file under # Official Notebooks section, pointing to the author or the author's team.
[X] The Jupyter notebook cleans up any artifacts it has created (datasets, ML models, endpoints, etc) so as not to eat up unnecessary resources.

Notebook ran fine in colab and workbench


Totem's assert generates errors in Lua51 / Lua52

I've added a contbuild for nngraph here:
https://travis-ci.org/torch/nngraph
Turns out, that on Lua51 and Lua52, Totem is the point of failure. The fix should be simple.

Should be fixed by #58.

Thanks, that fixes it.


Document CSV export format

The CSV export format is designed to mimic the summary table we show the user, but it would be good for downstream applications to have this format documented on the website or docs somewhere.

This should go into the Klados wiki, with a link to it from the application.


REST service keeps refer to 9098 even if you setup with another port

E.g. with GET LIST OF Productions

fixed (in master)


Any way to add the mime type to a compose object

Looking at the compose.rs, I see the build function doesn't give us the ability to specify a mime type. According th the google documentation, the mime type should be the type of the first object if not set, but this is not showing on the cloud console. Can you add the ability to specify a mime type?
pub(crate) fn build(base_url: &str, client: &Client, req: &ComposeObjectRequest) -> RequestBuilder {
    let url = format!(
        "{}/b/{}/o/{}/compose",
        base_url,
        req.bucket.escape(),
        req.destination_object.escape()
    );
    let builder = client.post(url).query(&req).json(&req.composing_targets);
    if let Some(e) = &req.encryption {
        e.with_headers(builder)
    } else {
        builder
    }
}

You can set mime type in ComposeObjectRequest.composing_targets.destination.content_type
https://cloud.google.com/storage/docs/json_api/v1/objects/compose#request-body
https://cloud.google.com/storage/docs/json_api/v1/objects#resource-representations
It works with the sample code below.
However, currently storage_class is required and Object doesn't implement the Default trait, so all properties must be specified.
Since it is very inconvenient, I will modify the implementation for this.
client.compose_object(
                &ComposeObjectRequest {
                    bucket: bucket_name.to_string(),
                    destination_object: format!("{}_composed", uploaded.name),
                    destination_predefined_acl: None,
                    composing_targets: ComposingTargets {
                        destination: Some(Object {
                            content_type: Some("image/jpeg".to_string()),
                            storage_class: "STANDARD".to_string(),
                           // ...
                        }),
                        source_objects: vec![SourceObjects {
                            name: format!("{}_rewrite", uploaded.name),
                            ..Default::default()
                        }],
                    },
                    ..Default::default()
                },
                None,
            )
            .await
            .unwrap();


add commissioner tool

A page that logs device identifier, firmware identifiers, and functional test results to CSV.
We can later add the ability to add unknown firmware identifiers to the device catalogue

@pelikhan It would be good to have your eyes on this page to tell me how I could make it more web dev-ey as opposed to C++ dev-ey

commissioner is a cool and mysterious name!

it's a name that is also hard to spell consistently :wink:


DefaultRowModelRequest's can't handle mapping non-scalar queries

Any query that returns a subset of a node's data (or any aggregation) with neo4jSession.queryForObjects():
A) Must have the domain object you're mapping to NOT scanned by OGM
(CHECK OUT: ExecuteQueriesDelegate --> private  Iterable executeAndMap(Class type, String cypher, Map<String, ?> parameters, ResponseMapper mapper))
B) Cannot handle non-scalar queries (CHECK OUT: EntityRowModelMapper)

Same answer as #184


Ubuntu Missing dependencies?

/usr/local/lib/node_modules/electron-prebuilt/dist/electron: error while loading shared libraries: libgtk-x11-2.0.so.0: cannot open shared object file: No such file or directory
/usr/local/lib/node_modules/electron-prebuilt/dist/electron: error while loading shared libraries: libnotify.so.4: cannot open shared object file: No such file or directory
/usr/local/lib/node_modules/electron-prebuilt/dist/electron: error while loading shared libraries: libXtst.so.6: cannot open shared object file: No such file or directory
/usr/local/lib/node_modules/electron-prebuilt/dist/electron: error while loading shared libraries: libnss3.so: cannot open shared object file: No such file or directory

hmm weird. seems like an electron issue

I had to install those packages on Ubuntu Xenial to have electron-prebuilt version v0.33.2 (I am testing the more recent versions soon):
$ apt-get install libgtkextra-dev libgconf2-dev libnss3 libasound2 libxtst-dev
Why now shipping a fully static binary that works on any distro?

Any traction on this?

nobody experiencing the problem has verified if its an electron issue, that would be a good place to start

You mean electron vs electron-prebuilt? I mean a dependency to the extreme is glibc if you don't provide a fully static binary, which is still the way to ship software if you don't want to deal with all the distros dependencies.

reminder that this repo is not electron. it's just the thing that downloads electron. issues about packaging electron are not related to this repo

apparently this has been fixed in electron https://github.com/atom/electron/issues/4341


[HOLD for payment 2023-08-10] [$1000] Security - Still able to request Close Account when offline

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Disable your internet connection, and choose Yes, continue.
When back online, notice you're able to request close account when offline, even we disable the close button when offline.

Expected Result:
The "Yes, continue" button should be disabled on the confirmation modal when offline
Actual Result:
Still able to request Close Account when offline because the confirm modal is not dismissed.
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[x] Android / native
[x] Android / Chrome
[x] iOS / native
[x] iOS / Safari
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop

Version Number: 1.3.44-0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
https://github.com/Expensify/App/assets/93399543/d8922122-19a8-4fba-b8cd-4db4744b627d
https://github.com/Expensify/App/assets/93399543/a9f0b05e-cf7a-40d5-8dc0-5f0c1e292bd7
Expensify/Expensify Issue URL:
Issue reported by: @hungvu193
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1690086679675019
View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01b9448cf41ba17959
Upwork Job ID:<PHONE_NUMBER>858905088
        2023-07-26Automatic offers:

mollfpr | Reviewer | 25817419
samh-nl | Contributor | 25817420
hungvu193 | Reporter | 25817421

Proposal
Please re-state the problem that we are trying to solve in this issue.
User is still able to request CloseAccount when offline.
What is the root cause of that problem?
This is because the ConfirmModal component does not disable the Confirm button when offline for dangerous actions.
The Original Form button that calls the confirm button is disabled when offline, but this functionality is not present in the confirm Modal, which creates an inconsistency.
What changes do you think we should make in order to solve the problem?
We should simply add the functionality to the Confirm button in the Confirm Modal component, buy using an optional enabledWhenOffline prop, exactly how the FormAlertWithSubmitButton component implements the feature here.
To carry out this change, we would define an optional prop type (bool) here and pass isDisabled prop to the button it renders here according to the similar logic used in FormAlertWithSubmitButton:
https://github.com/Expensify/App/blob/33ed1672b7292725081ef73caf80667a77075357/src/components/FormAlertWithSubmitButton.js#L74-L92
What alternative solutions did you explore? (Optional)
Alternatively we can dismiss the modal when offline, but this would create a jarring experice for user, as a modal is hidden without him doing anything (only his net is unstable)

@marcochavezf cc'ing you as you worked on offline first. This seems expected to me based on offline first, do you agree? Basically the action is completed once you get back online which seems reasonable to me

It does look like this should be expected, but since the original Form Button that calls the modal is disabled when offline we expect similar behaviour with the modal.

Oh this is an interesting issue, yeah seems to be expected, but imo we should disable the confirmation button in the modal when offline too. I think we'd need to bring it into the open-source channel for a broader discussion

Ok cool, so it sounds like we are all agreed that the necessary fix here is to make sure the confirmation button in the modal is disabled when offline. I'll update the issue accordingly!

Shared for more eyes here https://expensify.slack.com/archives/C01GTK53T8Q/p1690320979990179

Updated the expected behavior to: "The "Yes, continue" button should be disabled on the confirmation modal when offline"

Thank you guys for the proposals!
I agree to add new props to ConfirmContent passed down from ConfirmModal for disabling the confirm button. Still, I think naming the props with shouldDisabledConfirmButton having a default value false is more accessible. My reason is we have two buttons in the confirmed content, enabledWhenOffline doesn't explain which button is.
@samh-nl @neonbhai @Nodebrute All of you have a similar proposal in general, and @Nodebrute did a great job detailing their solution. Since the solution is pretty straightforward, the first proposed solution already addressed the fix, we can go with @samh-nl proposal.
🎀 👀 🎀 C+ reviewed!

Reminder set to pay on 8/10. Lets tackle the BZ steps above in the meantime @mollfpr 👍

Summary for payment:
Reporting: $250 @hungvu193 (Upwork)
C: $1500 @mollfpr (Upwork)
C+: $1500 @samh-nl (Upwork)

not sure it matters but @mollfpr is the C+ member.

Correct! They were the contributing engineer on this one as opposed to the reviewer so I think it doesn't matter really 👍

Paying out now. Friendly bump on the BZ steps @mollfpr 🙇

All paid and contracts ended! Closing once BZ steps are done

Thanks for taking the payment early @MitchExpensify and sorry for the delay 🙏

[@mollfpr] The PR that introduced the bug has been identified. Link to the PR:
[@mollfpr] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:

There's no offending PR. Before, we didn't have the ability to control either the submit button on the confirm modal can be disabled based on certain conditions. In the PR, we added new props to accommodate that, and for the close page, we disabled the submit button when the network was offline.

[@mollfpr] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:

The page that uses the confirm modal may have a different case for handling the submit button on the network status. So, this issue is not very common to all the pages. So the regression test should be enough.

[@mollfpr] Determine if we should create a regression test for this bug.
[@mollfpr] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

Open the App
Go to Settings
Go to Security
Go to Close account
Click on the Close Account button to open the confirm modal
Disable your internet connection
Verify that the Close account button in the modal is disabled
👍 or 👎

QA test update added! Thanks again @mollfpr


Does not work for video anymore

Hi,
I watched the video tutorial https://www.youtube.com/watch?v=PQCdLCN7uCo on how to use segment anything with videos, but it does not predict any masks. I tried it on single image project and it works fine. The only difference I see is that now there is a point in the middle by default when drawing the bounding box using the smart tool, and in the video it's not there.
Thanks!

Hi, @VGrondin
After you draw the bounding box using the smart tool, you should see the following message in the SAM application logs.
Info    2023.08.23 16:55:23    INFO:     <IP_ADDRESS>:44050 - "POST /smart_segmentation HTTP/1.1" 200 OK

If you don't, make sure you choose the right app for smart tool.

Hi @TheoLisin ,
After quite some time debugging, it turned out that Serve anything model + video does not work on Firefox (no idea why). I tried the exact same setup and it worked exactly like it did in the youtube tutorial.
Thanks!


Update CONTRIBUTERS.MD

What type of PR is this? (check all applicable)

[ ] 🚀 Added Name
[ ] ✨ Updation
[ ] 🌟 stared the repo
[ ] 🐛 Grammatical Error
[ ] 📝 Documentation Update
[ ] 🚩 Other

Description
I've just add my name and my profile link
Add Link of GitHub Profile
https://github.com/HardCoder404

I'm a newbie and i just update my  name over here. Please accept my PR


Added a new file swathy-rt

As of now , I created a branch named newbie , created a file and made a commit, and opened a pull request

created a branch, created a file and made a commit, and opened a pull request

created a branch, created a file and made a commit, and opened a pull request


Add USDC-STAR stable pool on Base Aerodrome

I want to add a USDC-STAR vault to app but the STAR token does not exist. What would be a better way to develop the vault without publishing updates to the address book?

star unsafu iirc

@roman-monk Thanks for the review and help. Is the reason not enough liquidity or no timelock? I see the market cap and volume are small. I checked the token contracts but not certain if there’s migrate or upgrade functionality. Out of curiosity, what else we need to update to add a new token? I deployed the contracts, updated the pools and address book in beefy-api, vault data and images in beefy-v2, the ran both repositories, I saw the new token icon was shown in the localhost app, but the values like TVL, APY are 0. Was that because the address book was not published? On Jul 4, 2024, at 03:20, roman-monk @.***> wrote:
star unsafu iirc
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you authored the thread.Message ID: @.***>

@ying13 STAR's largest holder (61%) is the team's multi-sig, that needs to be timelocked or at least be controlled in some way. Also unlike most tokens it is a debt token that can be minted through various contracts using price feeds, all of which need to be secured. It is quite hard to prove secureness on these kind of tokens without working with their team to check everything.
For some untimelocked tokens we can use the [NO_TIMELOCK] flag. But that is reserved for tokens which have large marketcap, huge demand and the team is well-known. But even then they have to be checked throughly and have very few areas of vulnerability.
Did you change the URL in this line to http://localhost:3000? That's how to get it look at your local API instead of the prod one. The APY and TVL should appear but without the address book package update you shouldn't see the info about the token at the bottom or able to zap in to the vault.

@kexleyBeefy Thank you very much for the explanation! Yes I changed the beefy-api API_URL to http://localhost:3000 and the APY and TVL are 0 as below, and there's no zap feature.

I went over this process wanted to know how to verify and add new tokens. I will close this PR and many thanks to @kexleyBeefy @roman-monk for your time providing the helpful information 🙏