Use the CLI styleext to generate the correct css format

Bug, feature request, or proposal:
feature
What is the expected behavior?
When we've configured the CLI to use another css format (i.e. scss) for generated components, we would expect the material schematics to align with this when generating components (such as the materialNav).
What is the current behavior?
The generator generates plain css whenever the styleext is set to scss.
What are the steps to reproduce?
ng g @angular/material:materialNav --name=navigation/main-nav
What is the use-case or motivation for changing an existing behavior?
Alignment with CLI, meet developer expectations.
Which versions of Angular, Material, OS, TypeScript, browsers are affected?
Angular CLI: 6.0.0-rc.5
@angular/cdk 6.0.0-rc.12
@angular/material 6.0.0-rc.12
Is there anything else we should know?
The styleext argument works: --styleext=scss.

@DevVersion want to take a look at this?

The default style extension seems to be tied to the @angular:component schematic.
Meaning that we aren't able to access the default options for that schematic because our Material schematic's are part of a different collection and have a different schematic name.
see for example here
const schematicOptions = await this.getOptions({
  schematicName,
  collectionName,
});

@hansl Is there any way we can get access from a custom schematic, to that default schematic configuration in order to figure out the styleext. It feels a bit wrong to set the styleext for a single schematic, while the user specified it for the whole app using ng new XX --style scss

@DevVersion - Not sure if this helps but our component schematics were refactored into a base util here and that was copied from the base component schematic here.

@amcdnl Yeah, unfortunately it doesn't look like we could modify the logic to access the config though. The reason is that the default styleext is tied to one specific schematic with a unique namespace & name.
"schematics": {
  "@schematics/angular:component": {
    "styleext": "scss"
  }
},

@hansl Okay that's reasonable. Just good to know that there is nothing we could do yet. Thanks for the response.


Improve Headline Consistency

The border of the right emoji is thicker than that of the left emoji. Please fix this to look more consistent.
It's also possible to redesign the whole headline, maybe even with images instead of emojis.

hello @eum2o, I have identified this issue that I would like to work on. If it's possible, I would be grateful for the opportunity to work on this issue


Language Bug

When the browser language is other than English or Polish (for example when it is Turkish) no language is being identified and placeholders are shown.

There must be a default fallback language


Group 2 - Solutions

Hi @GuillermoAbadLopez,
We have uploaded the code developed by Group 2 for the routing problem.
Thank you!

Looks great, thanks! 🚀


Edit Data grid doesn't properly resize when showing\hiding SQL Pane

Azure Data Studio Version: master

Steps to Reproduce:

Open Edit Data on a table with lots of rows and columns (~100+ rows and ~10+ columns) so that the grid requires horizontal and vertical scrollbars
Open the SQL Pane window and update the TOP clause to be something like TOP 10
Collapse and reexpand the SQL pane

Note: this is just one example variant of the repro
Expected: The grid is resized so that scrollbars are positioned correctly and there is no extraneous whitespace
Actual: Resizing is inconsistent and not correct.  The two screenshots below show a couple examples.
Example 1

Example 2

@smartguest could you please prepare a PR that resolves this issue so we can consider taking for the Feb release?

I've been attempting to figure out where the scroll bar is handled at, I'm going to need assistance on this issue.

@smartguest I think what you want to do is:
https://github.com/microsoft/azuredatastudio/blob/8c61538a2737a68d1c588e26e59a5818d14fb529/src/sql/workbench/contrib/editData/browser/editDataEditor.ts#L500
Probably add another this._queryModelService.resizeResultsets(this.uri). the this.input.uri is referencing the SQL query part of EditData


Fix overflow in memcpy

In function ‘memcpy’,
    inlined from ‘control_msg_serialize.constprop’ at ../app/src/control_msg.c:77:5,
    inlined from ‘run_controller’ at ../app/src/controller.c:69:12:
/usr/include/x86_64-linux-gnu/bits/string_fortified.h:34:10: warning: ‘__builtin___memcpy_chk’ writing 262138 bytes into a region of
 size 262130 overflows the destination [-Wstringop-overflow=]
   return __builtin___memcpy_chk (__dest, __src, __len, __bos0 (__dest));
          ^

When serialize CONTROL_MSG_TYPE_SET_CLIPBOARD event, it did not consider the size of sequence which is 8 bytes. So that the buffer size is not enough for memcpy.

LGTM :+1:
How did you detect it in practice?

It was detected by compiler.

Which compiler? I tested with both gcc and clang, I don't get this warning. Any specific options?

Merged:

daa06abd34981a09aaecd85307b5719ca34f6034
d80bc25ebacc0fe1ba40ab836e03e6590156aecc

I added a unit test: ae90ef22db27ca0709ca57a3c08236ccb4cb4673

Which compiler? I tested with both gcc and clang, I don't get this warning. Any specific options?

I use gcc.
The Meson build system
Version: 0.55.3
Source dir: /home/yclin/scrcpy
Build dir: /home/yclin/scrcpy/x
Build type: native build
Project name: scrcpy
Project version: 1.21
C compiler for the host machine: cc (gcc 7.5.0 "cc (Ubuntu 7.5.0-3ubuntu1~18.04) 7.5.0")
C linker for the host machine: cc ld.bfd 2.30
Host machine cpu family: x86_64
Host machine cpu: x86_64
Found pkg-config: /usr/bin/pkg-config (0.29.1)
Run-time dependency libavformat found: YES 57.83.100
Run-time dependency libavcodec found: YES 57.107.100
Run-time dependency libavutil found: YES 55.78.100
Run-time dependency sdl2 found: YES 2.0.17
Run-time dependency libavdevice found: YES 57.10.100
Run-time dependency libusb-1.0 found: YES 1.0.21
Checking for function "strdup" : YES
Checking for function "asprintf" : YES
Checking for function "vasprintf" : YES
Header <sys/socket.h> has symbol "SOCK_CLOEXEC" : YES
Configuring config.h using configuration
Program ./scripts/build-wrapper.sh found: YES
Build targets in project: 3

Found ninja-1.8.2 at /usr/bin/ninja

The detection option is -Wstringop-overflow=.
Would it relate to the meson?


Unable to load local directory on Mac OSX

Environment: Mac OSX 15.1
Browser: Safari, Firefox, Chrome
When I click "Select Local Images" the app crashes.
Network tab says it's trying to make a POST call to "/select_directory", but the request is getting blocked on my end. I think this is a CORS issue where localhost will block other localhost calls.
The browser error looks like this:
    <anonymous> http://localhost:5000/:362
    (Async: promise callback)
    <anonymous> http://localhost:5000/:361

Here's my terminal output.
 * Serving Flask app 'app'
 * Debug mode: off
INFO:werkzeug:WARNING: This is a development server. Do not use it in a production deployment. Use a production WSGI server instead.

*** First throw call stack:
(
	0   CoreFoundation                      0x000000018799cec0 __exceptionPreprocess + 176
	1   libobjc.A.dylib                     0x0000000187482cd8 objc_exception_throw + 88
	2   CoreFoundation                      0x00000001879c154c _CFBundleGetValueForInfoKey + 0
	3   AppKit                              0x000000018b47e6f4 -[NSWindow _initContent:styleMask:backing:defer:contentView:] + 260
	4   AppKit                              0x000000018b47e5e4 -[NSWindow initWithContentRect:styleMask:backing:defer:] + 48
	5   libtk8.6.dylib                      0x0000000102c71ba4 TkMacOSXMakeRealWindowExist + 564
	6   libtk8.6.dylib                      0x0000000102c717f0 TkWmMapWindow + 76
	7   libtk8.6.dylib                      0x0000000102bce588 MapFrame + 76
	8   libtcl8.6.dylib                     0x0000000102f9b1a0 TclServiceIdle + 88
	9   libtcl8.6.dylib                     0x0000000102f7b09c Tcl_DoOneEvent + 120
	10  libtk8.6.dylib                      0x0000000102c629c8 TkpInit + 800
	11  libtk8.6.dylib                      0x0000000102bc6f20 Initialize + 2500
	12  _tkinter.cpython-312-darwin.so      0x0000000101b2a1b8 Tcl_AppInit + 92
	13  _tkinter.cpython-312-darwin.so      0x0000000101b29e08 Tkapp_New + 668
	14  _tkinter.cpython-312-darwin.so      0x0000000101b29b68 _tkinter_create_impl + 268
	15  _tkinter.cpython-312-darwin.so      0x0000000101b297e8 _tkinter_create + 276
	16  python3.12                          0x00000001003e29ac cfunction_vectorcall_FASTCALL + 96
	17  python3.12                          0x00000001004eb670 _PyEval_EvalFrameDefault + 221860
	18  python3.12                          0x00000001004125f0 slot_tp_init + 328
	19  python3.12                          0x0000000100406858 type_call + 148
	20  python3.12                          0x00000001004eba10 _PyEval_EvalFrameDefault + 222788
	21  python3.12                          0x000000010037f900 method_vectorcall + 368
	22  python3.12                          0x00000001005f7944 thread_run + 156
	23  python3.12                          0x0000000100577cfc pythread_wrapper + 48
	24  libsystem_pthread.dylib             0x00000001878432e4 _pthread_start + 136
	25  libsystem_pthread.dylib             0x000000018783e0fc thread_start + 8
)
libc++abi: terminating due to uncaught exception of type NSException
[1]    87579 abort      python app.py

I feel the solution is to configure the call to select_directory so it passes CORS restrictions but I'm not completely sure on how to do that.

Hello, I tried to fix the issue.
This is what I did:
This change addresses two issues:

CORS problem preventing the '/select_directory' POST request.
Tkinter window creation on a non-main thread.

The solution involves:

Adding CORS support to the Flask app.
Moving the Tkinter directory selection to the main thread using a queue.
Updating the frontend to handle the asynchronous nature of directory selection.

You can review changes in this commit: https://github.com/lattaai6/QuentinWach-image-ranker-9/commit/fde6a37c62044fe2d842a4ea39f8acfd3e6a8d3b.

[!CAUTION]
Disclaimer: This fix was created by Latta AI and you should never merge before you check the correctness of generated code!
The fix provided by Latta AI might not be complete and it can serve as an inspiration.

This issue was fixed for free by Latta AI - https://latta.ai/ourmission
If you no longer want Latta AI to attempt fixing issues on your repository, you can block this account.

I can't debug or test this right now but I was aware that there might be issues with the threading. I hope to get a Mac this week and will then see what I can do. Thank you for letting me know, @Chadius.

Thanks for taking a look. I double checked and it does work on WIndows Firefox. I'm usually on my Macbook. The interface is really nice.

It should indeed work well on Windows as I programmed on Windows up until now. But I now have a Mac again as well and got the same error. WIP.

Thanks for the update. This is working for me in Firefox, Chrome and Safari. Thank you for looking into this!


Help in preserving colors

I am not sure how much of a value this would be to anyone but I had to ask since no one did
I have bought a color ereader for the first time, got to test which format/setting is good, found a decent balance but here's my problem
My device, a Pocketbook Color 3, works well with EPUB when handling colors, I don't get any artifacts or such from it but as many have said before it look washed, CBZ on the otherhand has some of artifact pixelation when there is color, I know I can adjust it but this doesn't fix anything and this is where I have to ask if there is a way to increase the saturation of an EPUB file when reading from an ereader? or do I lower the gamma level?

Please upload your kcc settings screenshot. @AVM-1996

You can try setting gamma to 1.0
Or disabling upscale.

well i tried that first but if i CBZ format it produces an effect like compression but when i used EPUB it doesn't but the colors are faded
i mostly read in black and white so this is new to me

Ok i am going to test around with the gamma settings and see what happens

Some pictures of the problem could be helpful too. If you prefer discord you can troubleshoot on the discord.

well thats the thing its only on the ereader but ill try different ways maybe with calibre?

@AVM-1996 did you solve the issue?


[MPS] Add support for torchvision::roi_align for MPS backend

🚀 The feature, motivation and pitch
NotImplementedError: The operator 'torchvision::roi_align' is not currently implemented for the MPS device.
Alternatives
No response
Additional context
No response
cc @kulinseth @albanD @malfet @DenisVieriu97 @razarmehr @abhudev

it would be awesome if this could be implemented soon: +1 from my side!

Thank you for adding it @qqaatw !


Enable paste support in views.Application

Fixes #552
Identical to https://github.com/gdamore/tcell/commit/c3ed795e59fc3dda826de0fc553e4045bdc2952a, but for pasting.

I'm less certain I like this ... although I guess it means applications will need to prepared for events they don't recognize (paste start and end).
In dcell ( a new D implementation of this) I made paste a single event, and would definitely think it should be opt-in.

The implementation in this PR is the least 'invasive' way of enabling pasting for an Application, but I'd agree the functionality would ideally be opt-in (I'm inclined to think mouse support should be too, but that would break BC now).
An alternatve approach that would allow opt-in could be something like:
type Application struct {
	widget Widget
	...
	paste  bool
}

func (app *Application) EnablePaste(on bool) {
	app.paste = on
}

func (app *Application) run() {
	...
	if app.paste {
		screen.EnablePaste()
	}
	...
}

I'm happy to implement it if you're fine with the approach?

PR updated - I've gone ahead and implemented the changes I proposed above, should hopefully result in less 'back-and-forth' if you're happy with the solution. :)

Thanks for your contribution!  If you want a listing in AUTHORS please submit a follow up PR.


Better SEO

All web crawlers are req for /robots.txt but its returning 404. Should we add it in nextjs?

Add next-seo


feat: change default payment threshold

This change is

Codecov Report

Merging #2715 (4daf73c) into master (39cda82) will increase coverage by 0.01%.
The diff coverage is 100.00%.

:exclamation: Current head 4daf73c differs from pull request most recent head 74dc7c2. Consider uploading reports for the commit 74dc7c2 to get more accurate results

@@            Coverage Diff             @@
##           master    #2715      +/-   ##
==========================================
+ Coverage   63.81%   63.82%   +0.01%
==========================================
  Files         236      236
  Lines       26729    26729
==========================================
+ Hits        17056    17059       +3
+ Misses       8145     8143       -2
+ Partials     1528     1527       -1

Impacted Files
Coverage Δ

cmd/bee/cmd/cmd.go
66.46% <100.00%> (ø)

pkg/localstore/mode_set.go
55.22% <0.00%> (+1.11%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 39cda82...74dc7c2. Read the comment docs.

I guess you've forgotten to change the BEEKEEPER_BRANCH back to the master.

the beekeeper and bee branch would be merged at the same time, so for now it should remain, before merging it should be changed

#2904


ServiceBus Message Receiver Settle Errors

Package Name: @azure/service-bus
Package Version: 1.1.6
nodejs: 8

Set up
We run microservices that typically will have one sender and one receiver. The sender is a topic sender with subscription with filters that will auto forward to a queue. The receiver is a queue receiver. While testing high availability scenarios we are running with two service bus namespaces. A microservice will be listening to both SBs and will only be sending to one (switching between them when an error is encountered). When a sender error is received, we close the sender and close the connection and recreate both of them. When a receive errorHandler error or a message settle error is encountered we close the receiver and connection. The sender and receiver each have a separate connection so one error path does not affect the other. This is all in one process.
Describe the bug

Start up microservices using both SBs, everything is working.
Delete topic of the active SB1 so the senders will get errors and microservices will start sending to SB2, everything is working.
Recreate topic and subs of SB1, everything is working.
Delete topic of SB2 so microservices try to start sending to SB1. Sends work and receives work but when we try to settle a message we get the below error.

This does not seem to be from us closing the connection ourselves from the error handling but it is possible. This went on for hours with 100,000+ messages backing up on the queues for all microservices. This eventually recovered, we restarted services multiple times, so unsure if this would ever recover on its own. This has happen both times we have tested this scenario.
{"stack":"ServiceUnavailableError: Operation to settle the message has timed out. The disposition of the message may or may not be successful\n at Object.translate (/app/node_modules/@azure/amqp-common/dist/index.js:908:17)\n at Timeout.setTimeout [as _onTimeout] (/app/node_modules/@azure-iot/azure-service-bus/dist/index.js:2436:46)\n at ontimeout (timers.js:498:11)\n at tryOnTimeout (timers.js:323:5)\n at Timer.listOnTimeout (timers.js:290:5)","message":"Operation to settle the message has timed out. The disposition of the message may or may not be successful","name":"ServiceUnavailableError","translated":true,"retryable":true,"condition":"com.microsoft:timeout"}}
{"stack":"TypeError: Cannot read property 'renewLock' of undefined\n at StreamingReceiver. (/app/node_modules/@azure-iot/azure-service-bus/dist/index.js:2024:100)\n at Generator.next ()\n at /app/node_modules/@azure-iot/azure-service-bus/node_modules/tslib/tslib.js:113:75\n at new Promise ()\n at Object.__awaiter (/app/node_modules/@azure-iot/azure-service-bus/node_modules/tslib/tslib.js:109:16)\n at Timeout._messageRenewLockTimers.set.setTimeout [as _onTimeout] (/app/node_modules/@azure-iot/azure-service-bus/dist/index.js:2021:105)\n at ontimeout (timers.js:498:11)\n at tryOnTimeout (timers.js:323:5)\n at Timer.listOnTimeout (timers.js:290:5)","message":"Cannot read property 'renewLock' of undefined"}}
{"stack":"MessageLockLostError: The lock supplied is invalid. Either the lock expired, or the message has already been removed from the queue. Reference:1f4acaeb-c1c6-49ae-a36d-1fa18b6fa48f, TrackingId:b4e857b7-9f54-1949-a75f-3ffd8a87bea0_B3, SystemTracker:iotc-scoo-mwh-choreography-tal:Queue:choreography_simulation-proxy, Timestamp:2020-04-14T19:52:17\n at translate (/app/node_modules/@azure/amqp-common/dist/index.js:908:17)\n at Receiver.messageCallback (/app/node_modules/@azure/amqp-common/dist/index.js:1230:35)\n at emitOne (events.js:121:20)\n at Receiver.emit (events.js:211:7)\n at emit (/app/node_modules/rhea-promise/dist/lib/util/utils.js:129:24)\n at Object.emitEvent (/app/node_modules/rhea-promise/dist/lib/util/utils.js:140:9)\n at Receiver._link.on (/app/node_modules/rhea-promise/dist/lib/link.js:252:25)\n at emitOne (events.js:116:13)\n at Receiver.emit (events.js:211:7)\n at Receiver.link.dispatch (/app/node_modules/rhea/lib/link.js:59:37)","message":"The lock supplied is invalid. Either the lock expired, or the message has already been removed from the queue. Reference:1f4acaeb-c1c6-49ae-a36d-1fa18b6fa48f, TrackingId:b4e857b7-9f54-1949-a75f-3ffd8a87bea0_B3, SystemTracker:iotc-scoo-mwh-choreography-tal:Queue:choreography_simulation-proxy, Timestamp:2020-04-14T19:52:17","name":"MessageLockLostError","translated":true,"retryable":false,"condition":"com.microsoft:message-lock-lost"}}

@ramya-rao-a @chradek

Delete topic of the active SB1 so the senders will get errors and microservices will start sending to SB2, everything is working.

At this point,

what happens to the receiver that was listening to the queue (to which you auto-forward) in SB1? Do you continue receiving messages here or stop and come back to receiving from SB1 only in step 4?
what happens to the messages already received using this receiver? Do these get settled before you move to receive messages from SB2?

Sends work and receives work but when we try to settle a message we get the below error.

Do you see the errors for every message you try to settle or is this intermittent?
Do you see all the 3 errors for every message or its random?
Do you have retries for settling the message?
If you are able to replicate this consistently, can you enable client side logs and share them? Set the DEBUG env var to azure:service-bus:error,azure:service-bus:receiver. You can email this to us.

Digging into the errors you are seeing

OperationTimeout: The client doesnt get an acknowledgement from the service within 60 seconds that the message is indeed settled successfully
TypeError: I am most concerned about this as the client as landed itself in a soup when trying to renew lock on your message
MessageLockLost: Automatic lock renewal failed to occur on the client (probably due to the previous error) and therefore your attempt fails as the message lock has expired. Errors from the service have a tracking id and so we can follow up with the service team if needed to piece together what is happening here

what happens to the receiver that was listening to the queue (to which you auto-forward) in SB1? Do you continue receiving messages here or stop and come back to receiving from SB1 only in step 4?

We continue listening, no errors are received and we don't receive any more messages (since no one is sending to it) until step 4.

what happens to the messages already received using this receiver? Do these get settled before you move to receive messages from SB2?

We are always receiving from both at the same time. All messages get settled until step 4.

Do you see the errors for every message you try to settle or is this intermittent?

We see errors for every message we try to settle

Do you see all the 3 errors for every message or its random?

We will get either OperationTimeout or MessageLockLost at random when settling the message. We get TypeError at a much lower rate from the errorHandler.

Do you have retries for settling the message?

No, typically the error is MessageLockLostError, which is not retryable, this is the first time we have seen a mass of retryable errors so we can add that logic in. How does this relate to this https://github.com/Azure/azure-sdk-for-js/issues/8283 (was hoping this would fix most of these).

If you are able to replicate this consistently, can you enable client side logs and share them? Set the DEBUG env var to azure:service-bus:error,azure:service-bus:receiver. You can email this to us.

Have tried this twice and has happened each time. It is time intensive and destructive to our dev  environment so hoping to wait for a newer phase 1 sdk to try again (few days?), will add logs then.

No, typically the error is MessageLockLostError, which is not retryable, this is the first time we have seen a mass of retryable errors so we can add that logic in. How does this relate to this #8283 (was hoping this would fix most of these).

The fix to #8283 will fix the scenario where the client itself throws the MessageLockLostError when the AMQP receiver used to receive the messages is no longer available. This happens when either the AMQP link or connection breaks and we recover them behind the scenes for you. The MessageLockLostError you are seeing is coming from the service meaning the receiver link is just fine, but the request to settle the message is coming after the lock on the message has expired.
You don't need to add retry logic for the settlement, I asked only to understand if the subsequent errors you are seeing are coming from the retries or from the original attempt.
For the TypeError you are seeing, we will look into what code paths can land the client in that state
Meanwhile for the lock lost error, can you open a support ticket in the Azure portal so that we can get the support folks to look at the service side logs to determine why the locks are being lost on the messages. They will need the tracking id from the error along with the SB namespace and queue name.
 By default, these features are enabled and the lock on a message is renewed automatically for 5 mins or the time taken to settle the message, which ever is smaller.

Meanwhile for the lock lost error, can you open a support ticket in the Azure portal so that we can get the support folks to look at the service side logs to determine why the locks are being lost on the messages. They will need the tracking id from the error along with the SB namespace and queue name

Created Support request ID<PHONE_NUMBER>02311, will let you know what they say

Assuming you are using the registerMessageHandler() method, are you also using the auto complete and auto lock renewal features? By default, these features are enabled and the lock on a message is renewed automatically for 5 mins or the time taken to settle the message, which ever is smaller.

yes
autoComplete: false,
maxMessageAutoRenewLockDurationInSeconds:  1000 * 60 * 60 * 1

Not seeing these issues anymore with latest sdk


[doc] PersistentComponentState while prerendering: There is already a persisted object under the same key 'ColorMode'

fail: Microsoft.AspNetCore.Components.Infrastructure.ComponentStatePersistenceManager[1000]
      There was an error executing a callback while pausing the application.
      System.ArgumentException: There is already a persisted object under the same key 'ColorMode'
         at Microsoft.AspNetCore.Components.PersistentComponentState.PersistAsJson[TValue](String key, TValue instance)
         at Havit.Blazor.Documentation.Shared.Components.DocColorMode.DocColorModeSwitcher.PersistMode() in E:\source\002.HFW-Havit.Blazor\Havit.Blazor.Documentation\Shared\Components\DocColorMode\DocColorModeSwitcher.razor.cs:line 40
         at Microsoft.AspNetCore.Components.Infrastructure.ComponentStatePersistenceManager.<PauseAsync>g__ExecuteCallback|11_0(Func`1 callback, ILogger`1 logger)

The issue with the DocColorModeSwitcher component is that it was originally designed to appear only once on a page. Now that we've added the NavBar with a second instance, the two instances:

Both try to save their state to PersistentComponentState.
Don't synchronize their states with each other (when you switch the mode in one instance, the other doesn't reflect the change and keeps rendering the original icon).

We have to create a scoped service which will handle the state for both instances (or possibly use existing IDocColorModeResolver).


Negative / Unconditioned Prompts

This is an improved and optimized version of @rabidcopy's PR #637 that implements negative prompting.
Usage
Any words between a pair of square brackets will try and be ignored by Stable Diffusion's model during generation of images.
this is a test prompt [not really] to make you understand [cool] how this works.
In the above statement, the words 'not really cool` will be ignored by Stable Diffusion.
Here's a prompt that depicts what it does.
original prompt: "A fantastical translucent poney made of water and foam, ethereal, radiant, hyperalism, scottish folklore, digital painting, artstation, concept art, smooth, 8 k frostbite 3 engine, ultra detailed, art by artgerm and greg rutkowski and magali villeneuve" -s 20 -W 512 -H 768 -C 7.5 -A k_euler_a -S<PHONE_NUMBER>

This one gave me a woman. I don't want a woman in this picture. So I just type ---
new prompt: "A fantastical translucent poney made of water and foam, ethereal, radiant, hyperalism, scottish folklore, digital painting, artstation, concept art, smooth, 8 k frostbite 3 engine, ultra detailed, art by artgerm and greg rutkowski and magali villeneuve [woman]" -s 20 -W 512 -H 768 -C 7.5 -A k_euler_a -S<PHONE_NUMBER>

Awesome. But I don't want the image to be blue.
new prompt: "A fantastical translucent poney made of water and foam, ethereal, radiant, hyperalism, scottish folklore, digital painting, artstation, concept art, smooth, 8 k frostbite 3 engine, ultra detailed, art by artgerm and greg rutkowski and magali villeneuve [woman blue]" -s 20 -W 512 -H 768 -C 7.5 -A k_euler_a -S<PHONE_NUMBER>

Perfect.  I want the horse to be free.
new prompt: "A fantastical translucent poney made of water and foam, ethereal, radiant, hyperalism, scottish folklore, digital painting, artstation, concept art, smooth, 8 k frostbite 3 engine, ultra detailed, art by artgerm and greg rutkowski and magali villeneuve [woman blue saddle]" -s 20 -W 512 -H 768 -C 7.5 -A k_euler_a -S<PHONE_NUMBER>

Perfect.
As you can see, there is a ton of potential with this and now it is implemented in the simplest way possible.
Notes

The only requirement for words to be ignored is that they are in between a pair of square brackets.
You can provide multiple words within the same bracket.
You can provide multiple brackets with multiple words in different places of your prompt. That works just fine.

I've done quite a bit of testing and it works great as long as the words you are omitting are actual difference makers to your prompt.
@lstein This should be good to go. Simple code that breaks almost nothing. And seems to be working quite awesome. Tagging you coz you said you might do it yourself.

Co-Authored-By: @rabidcopy<EMAIL_ADDRESS>

Wow, that's great. Very clean. Also very nice examples showing how well it works.

This PR also works really well to cut down anatomy problems.
"doctor holding a pill" -s 50 -W 512 -H 512 -C 7.5 -A k_lms -S 931495956

But add in some exclusions, and things get better (although still not perfect, but a lot better):
"doctor holding a pill [bad anatomy, extra legs, extra arms, extra fingers, poorly drawn hands, poorly drawn feet, disfigured, out of frame, tiling, bad art, deformed, mutated]" -s 50 -W 512 -H 512 -C 7.5 -A k_lms -S 931495956

This is too cool for school. Holy smokes.
Is this different from https://github.com/AUTOMATIC1111/stable-diffusion-webui/wiki/Features#attention ? If so, is it compatible?
Maybe if we are totally negating a particular token and the other attention control thing is also compatible, we can use a unique syntax like -[this gets negated fully] [[[this just has a lot less attention]]] (this has a bit more attention).

Is this different from https://github.com/AUTOMATIC1111/stable-diffusion-webui/wiki/Features#attention ? If so, is it compatible?

From reading the basic functionality, it is different. This one completely asks SD to overlook the given words if it can help it. While the one in the link seems to suggest it to produce more of that word.

Maybe if we are totally negating a particular token and the other attention control thing is also compatible, we can use a unique syntax like -[this gets negated fully] [[[this just has a lot less attention]]] (this has a bit more attention).

I'm not a fan of using multiple brackets. It's just not good or easy syntax to write and edit. I'll have a look at this and see what the feature is. If it's something we can implement, maybe we can do it with another syntax -- a different bracket or another format.

Awesome, tried it out and it works on my MPB M1 16GB.

does this also apply to img2img ?

does this also apply to img2img ?

Yes. It works with anything that takes a prompt.

Is this different from https://github.com/AUTOMATIC1111/stable-diffusion-webui/wiki/Features#attention ? If so, is it compatible?

From reading the basic functionality, it is different. This one completely asks SD to overlook the given words if it can help it. While the one in the link seems to suggest it to produce more of that word.

Maybe if we are totally negating a particular token and the other attention control thing is also compatible, we can use a unique syntax like -[this gets negated fully] [[[this just has a lot less attention]]] (this has a bit more attention).

I'm not a fan of using multiple brackets. It's just not good or easy syntax to write and edit. I'll have a look at this and see what the feature is. If it's something we can implement, maybe we can do it with another syntax -- a different bracket or another format.

Too add on a bit, basically in AUTOMATIC1111's fork any word put into () is emphasized more (multiple parenthesis work and increase the strength of that word even more), and any word put into brackets is de-emphasized but not negated. With how it's implemented it can be combined with their implementation of negative prompts. This leads to an absurd amount of fine tuning a prompt by the strength and weakness of each word, including the strength and weakness of the negative prompt's words.
prompt: a detailed 3d render of an apple
negative prompt: simple

prompt: a (detailed) 3d render of an apple
negative prompt: (simple)

Not much changes...
prompt: a ((((((detailed)))))) 3d render of an apple
negative prompt: ((((((simple))))))

prompt: a ((((((detailed)))))) 3d render of an [[[[[[[[[[apple]]]]]]]]]]
negative prompt: ((((((simple))))))

prompt: a ((((((detailed)))))) 3d render of an [[[[[[[[[[apple]]]]]]]]]]
negative prompt: ((((((simple)))))), ((((((((((red))))))))))

You can drive vectors very dramatically with this feature. With higher CFG values it becomes very incoherent with more stacking of () and []. I'm not sure what would be a good implementation here if it was implemented. + and minus before the word?
 a ++++++++++detailed 3d render of an ----------apple [++++++++++simple, ++++++++++red]
Still not entirely confident if it's the same or different from how prompt weighting works already here but from my understanding prompt weighting is a percentage to be split between words that adds up to be 100%.

Is this different from AUTOMATIC1111/stable-diffusion-webui/wiki/Features#attention ? If so, is it compatible?

any word put into () is emphasized more (multiple parenthesis work and increase the strength of that word even more), and any word put into brackets is de-emphasized but not negated

We already have numerical non-negating weights.
We need to be careful about having an "integrate everything" mindset, as we're likely to end up with duplicate features. Numeric non-negating weights (implemented), Negative prompting (implemented in this PR), and cross-attention (wishlisted) all do slightly different things in different ways.

Is this different from AUTOMATIC1111/stable-diffusion-webui/wiki/Features#attention ? If so, is it compatible?

any word put into () is emphasized more (multiple parenthesis work and increase the strength of that word even more), and any word put into brackets is de-emphasized but not negated

We already have numerical non-negating weights.
We need to be careful about having an "integrate everything" mindset, as we're likely to end up with duplicate features. Numeric non-negating weights (implemented), Negative prompting (implemented in this PR), and cross-attention (wishlisted) all do slightly different things in different ways.

Ah, sorry I just wasnt sure if that was effectively same thing, apologies.

@rabidcopy

Ah, sorry I just wasnt sure if that was effectively the same thing, apologies.

No worries! It's very confusing, and the only reason I have it straight in my head is because I'm really interested in "extended" prompting techniques from a user's perspective.
I really wish I understood the cross-attention thing well enough to be able to rebase Doggettx' work onto 'dev'...


Make user nagios managed

It would be useful if the creation of the nagios user ist optional. In our enviroment due to check_by_ssh with forced_commands the user nagios must be managed separately (by the accounts module). This is in conflict with the icinga module.
A working diff (for Debian):
--- a/manifests/init.pp
+++ b/manifests/init.pp
@@ -39,7 +39,6 @@
 #
 class icinga(
   Boolean                              $ca,
-  Boolean                              $manage_user,
   String                               $this_zone,
   Hash[String, Hash]                   $zones,
   Enum['dsa','ecdsa','ed25519','rsa']  $ssh_key_type    = 'rsa',
@@ -135,12 +134,10 @@ class icinga(
             before => User['nagios'],
           }

-          if $manage_user==true {
-            user { 'nagios':
-              ensure => present,
-              shell  => $icinga_shell,
-              before => Class['icinga2'],
-            }
+          user { 'nagios':
+            ensure => present,
+            shell  => $icinga_shell,
+            before => Class['icinga2'],
           }
         } # Debian

Sorry for the long wait. Currently I would not specify a pubkey, then no authorized_keys will be generated. The file must then be managed separately itself.
For the future I would plan to remove the pubkey part from this class and provide a separate class, since a scenario for ssh without agent is more likely anyway.


[BUG] Identify and Access > Accounts > New account - 'Domain' and 'Role' must be mandatory fields

Describe the bug
It's not possible to create account without entering 'Domain' and 'Role' so they must be mandatory, as in the old UI.
To Reproduce
Steps to reproduce the behavior:

Go to 'Identify and Access > Accounts' and click on 'Add account'.

Expected behavior
'Domain' and 'Role' fields must be mandatory, as in the old UI.
Screenshots

Desktop (please complete the following information):

OS: Ubuntu 18.04 LTS
Browser: Chrome
Version: 80.0.3987.132 (Official Build) (64-bit)

Additional context
None

@rhtyd @utchoang any other solution for this than adding custom form

Could be related:
https://github.com/apache/cloudstack-primate/pull/170
https://github.com/apache/cloudstack-primate/pull/217

@rhtyd This is because both these parameters are not a required parameter in createAccount API
https://github.com/apache/cloudstack/blob/master/api/src/main/java/org/apache/cloudstack/api/command/admin/account/CreateAccountCmd.java#L63-L67
Either we change backend or use a custom form. PR already created #257

Have PR


CLI helper script and phase 1 of erroneous shard removal

Adds a CLI target to help with erroneous shard removal

Generates a shard_list.yml file based on the lines in README.md.

Resolves the VC and CI provider of each shard as well as last build time

Generates a report of erroneous shards

That don't have CI, that have CI but were never built, or if last build was more than a month ago

Deletes shards that belong to one of those categories

Implements the first phase of erroneous shard removal by removing shards that do not have CI setup

PR is set as a draft to give some time for shard owners to get it setup.  Then will regenerate the report and update the PR.  Otherwise they will have to make a PR later once its setup.

Partially resolves #412.
DISCLAIMER: I don't have a way to resolve shards using GitHub Actions, so if your shard is using that let me know.
Removed Shards
https://github.com/Demonstrandum/Crystal-Maze - @Demonstrandum
https://github.com/Gangwolf/hncr - @Gangwolf
https://github.com/Groogy/trashman - @Groogy
https://github.com/Groogy/crystal-clear - @Groogy
https://github.com/MakeNowJust/carcin.vim - @MakeNowJust
https://github.com/TheKernelCorp/NuummiteOS - @TheKernelCorp
https://github.com/aca-labs/docker-crystal - @aca-labs
https://github.com/chenkovsky/aho_corasick - @chenkovsky
https://github.com/codingphasedotcom/rocky - @codingphasedotcom
https://github.com/datanoise/amqp.cr - @datanoise
https://github.com/ddfreyne/inari - @ddfreyne
https://github.com/ddfreyne/rcpu - @ddfreyne
https://github.com/dorkrawk/moola - @dorkrawk
https://github.com/dotmilk/emacs-crystal-mode - @dotmilk
https://github.com/guvencenanguvenal/katip - @guvencenanguvenal
https://github.com/hangyas/telegram_bot - @hangyas
https://github.com/jreinert/crouter - @jreinert
https://github.com/juanedi/micrate - @juanedi
https://github.com/jwaldrip/mime-types.cr - @jwaldrip
https://github.com/jwoertink/medley - @jwoertink
https://github.com/lbguilherme/os-crystal - @lbguilherme
https://github.com/luckyframework/record - @luckyframework
https://github.com/madeindjs/Crystagiri - @madeindjs
https://github.com/nbw/battlesnake_crystal - @nbw
https://github.com/onyxframework/rest - @onyxframework
https://github.com/pbrusco/crystal-learn - @pbrusco
https://github.com/petoem/breakout.cr - @petoem
https://github.com/samueleaton/raze - @samueleaton
https://github.com/senselogic/CIBYL - @senselogic
https://github.com/soveran/toro - @soveran
https://github.com/soveran/stal-crystal - @soveran
https://github.com/soveran/ohm-crystal - @soveran
https://github.com/soveran/resp-crystal - @soveran
https://github.com/tijn/devmail - @tijn
https://github.com/veelenga/crystal-zsh - @veelenga
https://github.com/vladfaust/params.cr - @vladfaust
https://github.com/vladfaust/tarantool-crystal - @vladfaust
https://github.com/watzon/ngrok.cr - @watzon
https://github.com/watzon/arachnid - @watzon
https://github.com/wontruefree/socks - @wontruefree
https://github.com/ysbaddaden/clang.cr - @ysbaddaden

@Blacksmoke16 My four shards in the list use CI from GitHub Actions:
https://github.com/soveran/toro - @soveran
https://github.com/soveran/stal-crystal - @soveran
https://github.com/soveran/ohm-crystal - @soveran
https://github.com/soveran/resp-crystal - @soveran

Please stop harassing developers with direct mentions for a list they maybe dont care about. Thanks.
BTW: clang.cr was moved to crystal-lang organization and is now the basis for crystal_lib. Just saying.

@ysbaddaden So you would rather I just remove their stuff without them knowing?  If they don't care they'll just ignore the notification.
Also, :+1: I'll update the owner of that shard.

Please stop harassing developers with direct mentions for a list they maybe dont care about. Thanks.

@ysbaddaden sure, sorry about that. The developers are free to unsubscribe if they don't care.

@veelenga This should be good to go.  I'd squash merge.
I can make a PR for the next batch next week sometime?

@Blacksmoke16 yeah. Thanks for your effort.


Filter upgrading breaking the water below it

When I put the filter upgrade on the pumps, It starts breaking the water source below it.

Update to the very latest build of Mekanism.


Fix additionalPrinterColumns

This fixes human-readable output of kubectl get on runnerdeployment, runnerreplicaset, and runner.
Most notably, CURRENT and READY of runner replicasets are now computed and printed correctly. Runner deployments now have UP-TO-DATE and AVAILABLE instead of READY so that it is consistent with columns of K8s deployments.
A few fixes has been also made to runner deployment and runner replicaset controllers so that those numbers stored in Status objects are reliably updated and in-sync with actual values.
Finally, AGE columns are added to runnerdeployment, runnerreplicaset, runnner to make that more visible to users.
kubectl get outputs should now look like the below examples:
# Immediately after runnerdeployment updated/created
$ k get runnerdeployment
NAME                   DESIRED   CURRENT   UP-TO-DATE   AVAILABLE   AGE
example-runnerdeploy   0         0         0            0           8d
org-runnerdeploy       5         5         5            0           8d

# A few dozens of seconds after update/create all the runners are registered that "available" numbers increase
$ k get runnerdeployment
NAME                   DESIRED   CURRENT   UP-TO-DATE   AVAILABLE   AGE
example-runnerdeploy   0         0         0            0           8d
org-runnerdeploy       5         5         5            5           8d

$ k get runnerreplicaset
NAME                         DESIRED   CURRENT   READY   AGE
example-runnerdeploy-wnpf6   0         0         0       61m
org-runnerdeploy-fsnmr       2         2         0       8m41s

$ k get runner
NAME                                           ENTERPRISE   ORGANIZATION                REPOSITORY                                       LABELS                      STATUS    AGE
example-runnerdeploy-wnpf6-registration-only                                            actions-runner-controller/mumoshu-actions-test                               Running   61m
org-runnerdeploy-fsnmr-n8kkx                                actions-runner-controller                                                    ["mylabel 1","mylabel 2"]             21s
org-runnerdeploy-fsnmr-sq6m8                                actions-runner-controller                                                    ["mylabel 1","mylabel 2"]             21s

Fixes #490

@callum-tait-pbx Thanks for reviewing!


Remove duplicate env check in TeamCity's GitHub env check #trivial

Probably copy-pasta 🍝, this PR removes this duplicate check.

          1 Warning

  :warning:
  Tests were not updated

  Generated by :no_entry_sign: danger

Yep - looks like it


[BUG] Scrolling on mac has high delay

With Version 0.17.0, IntelliJ Idea 2024.2.3 and macOS 14.6.1, the scrolling of the PDF with the built-in touchpad is extremely slow and has a delay. When trying to scroll more than a couple of lines, the PDF viewer is still receiving and handling input seconds after the input stopped. The viewer may even change the direction of the scrolling after the input has stopped. So it is not like the viewer continues to scroll slowly but is actually still handling the queued input events.
Scrolling in all other windows and the editor of IntelliJ works as expected, only the PDF viewer is affected.

Adding to this: using the arrow keys or the scroll bar works without lag.

Thanks for reporting this, we had this problem in the past (#51) but apparently it has come back. I don't have a Mac to test this with, so this may take a while to fix.
We are not listening directly for scroll wheel events anymore, but possibly other events are causing this. Could you try these versions?
intellij-pdf-viewer-0.17.1-alpha.1.2.zip
intellij-pdf-viewer-0.17.1-alpha.1.1.zip

Hey, thank you for your effort!
I have tried the alpha versions and sadly saw no improvement, the issue is also present in the embedded browser view.

Hey, I am sorry for the late response. Unfortunately I can confirm @willipreuk result's with the three alpha versions and the embedded browser view.

I just installed version 0.16.0 from the GitHub releases page and it is working fine. So, the issue must be related to some of the changes between 0.16.0 and 0.17.0.

Thanks for testing! Interesting, so if it's also there in the embedded pdfium it may be something on the plugin side. Unfortunately so many things changed between 0.16 and 0.17 it will be hard to do a bisection, in particular because as said I don't have an iOS to test with.
We can still run a profiler to see where the issue is.
For the browser part,

Search (double shift) for Registry, and enable pdf.viewer.debug (you can search here)
right-click on the pdf and open devtools, or search (double shift) for "Open DevTools"
Go to the performance tab
Start a recording
Reproduce the performance issue
Stop the recording
Click 'save profile' - at least in theory, because for me this button does not work at the moment

For the backend, with a jvm profiler:

Install VisualVM using your package manager or go to https://visualvm.github.io/
Start IntelliJ
Start VisualVM.
In the Applications panel on the left, identify the correct instance of IntelliJ
Go to the Sampler tab.
Click CPU to start profiling
Reproduce the performance issue
Stop the profiling
Take a Snapshot to view and save results.
Now you can zip the nps file and upload it here on GitHub.

to fix your trouble check this solution click
maybe this will solve your problem.

Hey, sorry for the late reply. I did the first part - the save profile button works for me.
Trace-20241103T124221.json
Please let me know if the information is helpful and if the second part is required.

Thanks a lot! I don't see very strange things at first sight, but I will take a closer look later on.
I think the issue has nothing to do with the backend of the plugin, so profiling the Kotlin code probably won't be very useful.


Link to Zookeeper cluster

In doc:

If I have a Zookeeper cluster of, for example, 5 machines(each runs a Zookeeper instance), how should I specify them in druid.zk.service.host? Comma separated?

Good question. The value for druid.zk.service.host is passed directly into the Curator Ensemble connect string. So whatever kind of string is valid for FixedEnsembleProvider is valid for use in this property. I don't have a great link to docs that explain the connection string handy at the moment.

It's the same format described on https://zookeeper.apache.org/doc/trunk/zookeeperProgrammers.html.

To create a client session the application code must provide a connection string containing a comma separated list of host:port pairs, each corresponding to a ZooKeeper server (e.g. "<IP_ADDRESS>:4545" or "<IP_ADDRESS>:3000,<IP_ADDRESS>:3001,<IP_ADDRESS>:3002"). The ZooKeeper client library will pick an arbitrary server and try to connect to it. If this connection fails, or if the client becomes disconnected from the server for any reason, the client will automatically try the next server in the list, until a connection is (re-)established.

I suggest leaving this issue open until the docs are patched to link to the ZK connection string information.

# Zookeeper
#

druid.zk.service.host=zk-node-1.bm.infra:2181,zk-node-2.bm.infra:2181,zk-node-3.bm.infra:2181
druid.zk.paths.base=/druid

druid.zk.service.host=host1:2181,host2:2181,host3:2181

This has been fixed.


cmd/go: misleading error message with mixed named and unnamed return values

What version of Go are you using (go version)?
go1.10.3 linux/amd64
Does this issue reproduce with the latest release?
Yes.
What did you do?
I tried to go build the following file:
package a

func f() (int, int, named int) {
	return 0, 0, 0
}

What did you expect to see?
Something like
./a.go:3:27: mixed named and unnamed return values

What did you see instead?
./a.go:3:27: duplicate argument int

The error message is correct. You're declaring three named integer return values, with the names int, int, and named respectively.
https://play.golang.org/p/I6m0NMX5f_M


[Bug] Output events.tsv file is empty

When packaging the BIDS structure, I noticed that the outputted events.tsv file is empty even though the input file I passed in has data in it.
Input events.tsv

Output events.tsv after packaging BIDS

What happens if you input a RB events.tsv file?  does it work as expected for fewer columns ?

see edge cases not handled properly, as described by alizee in #80

Note Alizee's PR #80 is a temporary fix just to cover another specific usecase.  Jess/Alizee agree this should be generalized and solved better soon.


Database access denied

Hi Alex!
I changed the configurations on env file, but when i execute the command "docker exec", i receive the message "Access denied for user<EMAIL_ADDRESS>(using password: YES)".
I am a newbie on docker universe, and the solution can be simple, but i can't see this solution.
Best regards!

If you use the default settings, does it work or not?
On Thu, Dec 21, 2017 at 7:36 AM, Anderson Antonio Lopes Rodrigues <
<EMAIL_ADDRESS>wrote:

Hi Alex!
I changed the configurations on env file, but when i execute the command
"docker exec", i receive the message "Access denied for user 'magento'@
'dockermagento2_web_1.dockermagento2_default' (using password: YES)".
I am a newbie on docker universe, and the solution can be simple, but i
can't see this solution.
Best regards!
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/alexcheng1982/docker-magento2/issues/10, or mute the
thread
https://github.com/notifications/unsubscribe-auth/ABHgEPPq7Zx7xbI94VfNgz_bf3rm6vspks5tCVObgaJpZM4RIy-D
.

--
Regards
Alex Cheng

Hi Alex!
With MySQL default settings, it's worked!
Best Regards!

That may be a bug. Honestly, I never tested the case of using other
password.
On 22 Dec 2017 03:14, "Anderson Antonio Lopes Rodrigues" <
<EMAIL_ADDRESS>wrote:

Hi Alex!
With MySQL default settings, it's worked!
Best Regards!
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/alexcheng1982/docker-magento2/issues/10#issuecomment-353360904,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABHgEG4QpN4AVXqnrPOk5tbBxwBjiSBPks5tCme6gaJpZM4RIy-D
.

It's happens, do not worry. I'll use it for a proof of concept.


"+" and "-" button

Logic in List Screen

@yuvrajsinghgmx I can work on this after my current issue is completed

@yuvrajsinghgmx sir, please assign me this

@yuvrajsinghgmx I'm done with the issue . Kindly check the sent PR. Thanks

@Shariq2003 Please make PR by tommorow.

@yuvrajsinghgmx sir, please assign @pratheekv39

@pratheekv39 I am assigning you this please make PR ASAP.

@yuvrajsinghgmx I will make the PR by today evening


Update cake dependencies

I guess this is the same as #19, but bumping the version even further ;)
I also updated paket.boostrapper.exe because I had errors related to the new version of TLS.

@larzw do you have any idea why codecov is correctly posting to this PR?  I am a number of other projects where it isn't working, and it gets a 404 returned from the attempt.

@derwasp thanks a lot for the contribution!
@gep13 the only thing off the top of my head is your using a different version of codecov-exe. codecov-exe is having some issue right now. Maybe @stevepeak has a better idea?

Concerning this project: the issue is not obvious to me atm... ¯_(ツ)_/¯

Out of curiosity what else is needed for this pr?

Could you merge the pull request?

Since it's not yet merged... can we upgrade to Cake.Core 0.28.1?

@gep13 It would be nice to get this addin working together with Cake.Core 0.28.x (cause of #22 ) Thx

@punker76 I have just had a quick chat with @larzw the creator of this addin, and he is going to try to get a release out this weekend.  If that doesn't happen, I will arrange a call with him to walk through the process of the release, and get something out early next week.

@gep13 sounds great!

This PR updates cake to 0.26. Would be nice if it could be updated to 0.29 ;-)

Thanks you everyone for your patience! Version 3.0.0 of this addin contains @derwasp PR (updating to cake 0.26.0) while version 4.0.0 closes #22 (updating to cake 0.28.1). On another note, is there anyone that would be interested in taking over the maintenance of this addin and module? If so, please see issue #25 for discussion. Thanks!

@punker76 can you take the latest version for a spin and see how you get on?

@gep13 Works great! Thx @larzw


Is it possible to generate Robo Script or record Espresso test?

Regarding Firebase Test Lab, to use Robo Test feature I can upload a robo script, is it possible to create the script with Flutter Apps? When I try Android Studio warning's me that I doesn't have a valid application, the same happen's when I try to record Espresso Test.

There's some work going on right now to make Espresso work better with Flutter.  @adazh may have more information.

Robo script or Espresso test recording for Flutter is not supported yet. We are working on adding Flutter support in Espresso, so these functionalities should follow after we have Espresso-Flutter support in place.

Any progress on this?

We are actively working on the Espresso-Flutter support. Stay tuned :).

We are actively working on the Espresso-Flutter support. Stay tuned :).

So...what news?

Since PR is merged
I feel safe to close this issue,
if you disagree please write in the comments and I will reopen it.
Thank you


Fix cudatoolkit building on non-sandboxed systems

This fixes the cudatoolkit building on non-sandboxed system.
The cudatoolkit tests run each of the CUDA binaries as a small smoke
test just to make sure they all can at least somewhat run.
However, the cuda-gdb binary doesn't run correctly on non-sandboxed
systems because it picks up versions of Python from /usr/lib.
This PR excludes the cuda-gdb binary from these smoke tests so
cudatoolkit can be built again on non-sandboxed systems.
This PR is for #57939.
This doesn't fix the underlying issue of cuda-gdb not being able to run on non-sandboxed systems.  That will hopefully come in a future PR.  Note that cuda-gdb not being able to run doesn't affect the actual cuda libraries that are needed for building CUDA-enabled applications.
Once this is merged in, I'd also like to backport this to 19.03.
Things done

[X] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[ ] NixOS
[ ] macOS
[X] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Assured whether relevant documentation is up to date
[ ] Fits CONTRIBUTING.md.

Pinging @knedlsepp.

I would rather we disable doCheck until this is properly fixed.

@knedlsepp I added commit 54cc6ad which does as you suggest.  Now the install checks are disabled.  I also added a comment about why it has been disabled.

Thx. @bendlas, could you have a look.

merged and backported

Thx


IMAGING-251 support for TIFF floating-point formats

This change adds the ability to obtain images from TIFF files that give data in the floating-point format.  It partially addresses IMAGING-251.  It also adds two example applications to show how to use the Commons Imaging API for TIFF images and adds one additional small sample TIFF data file that uses the floating-point format.
I saw that the project pom.xml specified PMD, so I run PMD and made minor PMD changes. In keeping with the project guidelines, PMD changes were done only for the files that I otherwise modified.
I ran all test cases successfully.
Additional changes to support numerical access for these files will be provided in a future patch.

I ran check style and see that I introduced tabs and trailing spaces.  Serves me right.  I turned off the auto-format in my IDE because I didn't want to introduce white-space changes to existing code.  I ran checkstyle from Maven using "mvn checkstyle:checkstyle".   Is that the command the project recommends?
What should I do to address this?   Submit a new PR?

I ran check style and see that I introduced tabs and trailing spaces. Serves me right. I turned off the auto-format in my IDE because I didn't want to introduce white-space changes to existing code. I ran checkstyle from Maven using "mvn checkstyle:checkstyle". Is that the command the project recommends?

You can run just mvn as Commons Imaging has a default Maven goal in its pom.xml. That's how Travis does it too.
Some developers are able to integrate the checkstyle rules in their IDE's. I am a bit behind the time, and still use the command line for most things. So my workflow is normally to change the files, have a look at the IDE warnings (Eclipse), then mvn and prepare a commit (i.e. run tests and some other checks).
Doesn't work every time as I can forget to run it too :)

What should I do to address this? Submit a new PR?

In your branch you should be able to resolve the style issues, by editing the files Travis is showing with errors. Then run mvn and once it passes prepare a new commit and push to your fork.
After this, this pull request should be automatically updated.

If you look near the PR title, where it says "gwlucastrig wants to merge 1 commit into...", you should see that this PR is supposed to merge code into apache:master.
But I can see you didn't use a branch in your fork, as it says that it would merge it from "gwlucastrig:master". It will work fine. But now this PR is "linked" to your branch master on your fork.
Which means that if you start working on another issue, and you push to your master branch, that would update this PR as well.
Furthermore, once it's merged, you may have to use something like git reset --hard to sync your fork again.
For that, I always start new work with git checkout -b name-of-my-branch (where normally I have name-of-my-branch as something like IMAGING-123, or fix-color-palette-8-bits-etc.
That way I am able to work on multiple issues :+1: just a note, as we should be able to work on IMAGING-251 just fine this way, but just in case you want to work on multiple issues, then having branches and not using master in your fork might be helpful.

Thanks for the information.  It clarifies some of the confusing area of
submitting a pill request.  I have been using git for about a year now, but
still don't understand the underlying logic of the system.
On Sun, Apr 5, 2020, 6:20 PM Bruno P. Kinoshita<EMAIL_ADDRESS>wrote:

I ran check style and see that I introduced tabs and trailing spaces.
Serves me right. I turned off the auto-format in my IDE because I didn't
want to introduce white-space changes to existing code. I ran checkstyle
from Maven using "mvn checkstyle:checkstyle". Is that the command the
project recommends?
You can run just mvn as Commons Imaging has a default Maven goal in its
pom.xml. That's how Travis does it
https://github.com/apache/commons-imaging/blob/1397ca92cd3268b434ad8a18529ee3544bbcf3c5/.travis.yml#L32
too.
Some developers are able to integrate the checkstyle rules in their IDE's.
I am a bit behind the time, and still use the command line for most things.
So my workflow is normally to change the files, have a look at the IDE
warnings (Eclipse), then mvn and prepare a commit (i.e. run tests and
some other checks).
Doesn't work every time as I can forget to run it too :)
What should I do to address this? Submit a new PR?
In your branch you should be able to resolve the style issues, by editing
the files Travis is showing with errors. Then run mvn and once it passes
prepare a new commit and push to your fork.
After this, this pull request should be automatically updated.
If you look near the PR title, where it says "gwlucastrig wants to merge 1
commit into...", you should see that this PR is supposed to merge code into
apache:master.
But I can see you didn't use a branch in your fork, as it says that it
would merge it from "gwlucastrig:master". It will work fine. But now this
PR is "linked" to your branch master on your fork.
Which means that if you start working on another issue, and you push to
your master branch, that would update this PR as well.
Furthermore, once it's merged, you may have to use something like git
reset --hard to sync your fork again.
For that, I always start new work with git checkout -b name-of-my-branch
(where normally I have name-of-my-branch as something like IMAGING-123,
or fix-color-palette-8-bits-etc.
That way I am able to work on multiple issues 👍 just a note, as we
should be able to work on IMAGING-251 just fine this way, but just in case
you want to work on multiple issues, then having branches and not using
master in your fork might be helpful.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/apache/commons-imaging/pull/72#issuecomment-609494043,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AEWJDYIDN44BQ4HSOQDNCB3RLD7Z5ANCNFSM4MAWGVRQ
.

I've pushed the checkstyle fixes up to my branch.   Let me know if any
further action is required on my part.  I am continuing to work toward
completing the changes for the issue. As a side effect, these changes may
eventually address Issue 102.
Gary
On Mon, Apr 6, 2020 at 6:21 AM Gary Lucas<EMAIL_ADDRESS>wrote:

Thanks for the information.  It clarifies some of the confusing area of
submitting a pill request.  I have been using git for about a year now, but
still don't understand the underlying logic of the system.
On Sun, Apr 5, 2020, 6:20 PM Bruno P. Kinoshita<EMAIL_ADDRESS>wrote:

I ran check style and see that I introduced tabs and trailing spaces.
Serves me right. I turned off the auto-format in my IDE because I didn't
want to introduce white-space changes to existing code. I ran checkstyle
from Maven using "mvn checkstyle:checkstyle". Is that the command the
project recommends?
You can run just mvn as Commons Imaging has a default Maven goal in its
pom.xml. That's how Travis does it
https://github.com/apache/commons-imaging/blob/1397ca92cd3268b434ad8a18529ee3544bbcf3c5/.travis.yml#L32
too.
Some developers are able to integrate the checkstyle rules in their
IDE's. I am a bit behind the time, and still use the command line for most
things. So my workflow is normally to change the files, have a look at the
IDE warnings (Eclipse), then mvn and prepare a commit (i.e. run tests
and some other checks).
Doesn't work every time as I can forget to run it too :)
What should I do to address this? Submit a new PR?
In your branch you should be able to resolve the style issues, by editing
the files Travis is showing with errors. Then run mvn and once it passes
prepare a new commit and push to your fork.
After this, this pull request should be automatically updated.
If you look near the PR title, where it says "gwlucastrig wants to merge
1 commit into...", you should see that this PR is supposed to merge code
into apache:master.
But I can see you didn't use a branch in your fork, as it says that it
would merge it from "gwlucastrig:master". It will work fine. But now this
PR is "linked" to your branch master on your fork.
Which means that if you start working on another issue, and you push to
your master branch, that would update this PR as well.
Furthermore, once it's merged, you may have to use something like git
reset --hard to sync your fork again.
For that, I always start new work with git checkout -b name-of-my-branch
(where normally I have name-of-my-branch as something like IMAGING-123,
or fix-color-palette-8-bits-etc.
That way I am able to work on multiple issues 👍 just a note, as we
should be able to work on IMAGING-251 just fine this way, but just in case
you want to work on multiple issues, then having branches and not using
master in your fork might be helpful.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/apache/commons-imaging/pull/72#issuecomment-609494043,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AEWJDYIDN44BQ4HSOQDNCB3RLD7Z5ANCNFSM4MAWGVRQ
.

This time it will work, I hope.  I ran mvn findbugs:findbugs and, sure enough, it found a bug.  I've submitted a fix.
Unfortunately, I missed a lot of the build procedures because I have not been able to get maven to execute the site  lifecycle under Windows (I do miss having a Linux computer).  Apparently, it won't run if I don't have a version of subversion installed.  Trying to get that set up now.  Is there a recommended version that works with commons-imaging?

I am using Maven 3.5.4, with Java 8. Not sure if there's a recommended version @gwlucastrig . But you are doing just fine regarding build & git in my opinion.
The code part you are doing is really the hard part. Also, because of how GitHub and git work, I am also able to edit this branch. So if necessary I can amend the changes to help fixing issues, or edit the commits (e.g. squashing it).
So feel free to update it as much as you can, but if you get stuck you can let me know and I can try to help so that the build passes and we can focus on the new code.

Coverage decreased (-0.8%) to 74.35% when pulling 71746adef6df8ef2440751c634064247bad22039 on gwlucastrig:master into 1397ca92cd3268b434ad8a18529ee3544bbcf3c5 on apache:master.

Thanks for the review and comments.  In answer to your first question, I
removed the final modifiers because the PMD analysis cited them as
unnecessary. I figured I would take the opportunity to reduce some of the
PMD issues.  There were also some unnecessary parentheses cited in the PMD
analysis.  I have mixed feelings about that one because what's unnecessary
for Java is sometimes useful for a human being. But it this case I didn't
think they helped the code.
In answer to your second comment, I agree.  All of those member elements
should be private.
In terms of the documentation.  Thanks for the positive feedback.  I had a
hard time figuring out the details, some of which were (at least for me)
not intuitive. So I wanted to document them to make things easier for the
next guy.  Consequently, the Commons Imaging project may be the only place
on the Internet where the floating-point predictor format is clearly
documented.
Gary
On Tue, Apr 7, 2020 at 3:32 AM Bruno P. Kinoshita<EMAIL_ADDRESS>wrote:

@kinow commented on this pull request.
Few comments from a quick review Gary. Already know I will need some more
time to read the code and (great) comments with calm. Will send a pull
request later to update some javadocs, and will try to update the test code
to use JUnit 👍
I saw you found some test data too, that's really great!
In
src/main/java/org/apache/commons/imaging/formats/tiff/datareaders/DataReaderStrips.java
https://github.com/apache/commons-imaging/pull/72#discussion_r404590691:

@@ -166,7 +166,7 @@ private void interpretStrip(

     // this logic will handle all cases not conforming to the

     // special case handled above

   try (final BitInputStream bis = new BitInputStream(new ByteArrayInputStream(bytes), byteOrder)) {

   try (BitInputStream bis = new BitInputStream(new ByteArrayInputStream(bytes), byteOrder)) {

Why did you need to remove the final here?
In
src/main/java/org/apache/commons/imaging/formats/tiff/datareaders/DataReaderTiled.java
https://github.com/apache/commons-imaging/pull/72#discussion_r404591250:

Once the predictor transform is complete, the data is stored using

conventional data compression techniques such as Deflate or LZW.

In practice, floating point data does not compress especially well, but

using the above technique, the TIFF process typically reduces the overall

storage size by 20 to 30 percent (depending on the data).

The TIFF Technical Note 3 specifies 3 data size formats for

storing floating point values:

32 bits    IEEE-754 single-precision standard

16 bits    IEEE-754 half-precision standard

24 bits    A non-standard representation

At this time, we have not obtained data samples for the smaller

representations.  There are also reports of 64-bit data

(see Commons Imaging JIRA issue IMAGING-102), though documentation

for that format was not available when these notes were written.

*/

This-is-some-great-documentation! I will send a pull request later to
format it as Javadoc while I re-read it with more calm 👍 👏
In
src/main/java/org/apache/commons/imaging/formats/tiff/datareaders/DataReaderTiled.java
https://github.com/apache/commons-imaging/pull/72#discussion_r404591417:

@@ -61,7 +139,78 @@ public DataReaderTiled(final TiffDirectory directory,

 }

 private void interpretTile(final ImageBuilder imageBuilder, final byte[] bytes,

       final int startX, final int startY, final int xLimit, final int yLimit) throws ImageReadException, IOException {

   final int startX, final int startY, final int xLimit, final int yLimit) throws ImageReadException, IOException {

   // March 2020 change to handle floating-point with compression

   // for the compressed floating-point, there is a standard that allows

   // 16 bit floats (which is an IEEE 754 standard) and 24 bits (which is

   // a non-standard format implemented for TIFF).  At this time, this

   // code only supports 32-bite.

s/bite/bits?
In
src/main/java/org/apache/commons/imaging/formats/tiff/datareaders/DataReaderTiled.java
https://github.com/apache/commons-imaging/pull/72#discussion_r404592789:

@@ -115,7 +264,7 @@ private void interpretTile(final ImageBuilder imageBuilder, final byte[] bytes,

     // End of May 2012 changes

   try (final BitInputStream bis = new BitInputStream(new ByteArrayInputStream(bytes), byteOrder)) {

   try (BitInputStream bis = new BitInputStream(new ByteArrayInputStream(bytes), byteOrder)) {

Why did you have to remove the final here?
In
src/main/java/org/apache/commons/imaging/formats/tiff/photometricinterpreters/fp/PhotometricInterpreterFloat.java
https://github.com/apache/commons-imaging/pull/72#discussion_r404594350:

*/

+public class PhotometricInterpreterFloat extends PhotometricInterpreter {

ArrayList rangePaletteEntries = new ArrayList<>();

ArrayList singleValuePaletteEntries = new ArrayList<>();

float minFound = Float.POSITIVE_INFINITY;

float maxFound = Float.NEGATIVE_INFINITY;

int xMin;

int yMin;

int xMax;

int yMax;

double sumFound;

int nFound;

Could we make the members above private or some other access modifier?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/apache/commons-imaging/pull/72#pullrequestreview-388848081,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AEWJDYIVCVGRYQPNDAEKLCTRLLJJNANCNFSM4MAWGVRQ
.

Let me know what you'd like me to do to with the code.  Sorry if the PMD changes created more work for you than they were worth.  I can back them out if you'd like.

I think I will be able to improve the coverage as soon as I can get some test images to exercise the sections of code that are not currently being covered.  I'm a bit confused by Coverall's results because in the last update I made no code changes, but added additional unit tests to cover more of the code.  The coverage rating went down.
No luck in my search for relevant test images, so I am trying to figure out how to use the Commons Imaging API to write TIFF files that carry floating-point data. That way the project will be able to generate its own test images with the different combination of options.   Most of the pieces are already present in the API.  The original authors put a remarkable amount of work into the code...  But figuring out how to use the API is not always easy.
At least at first, I will not create test files that use the predictor/compressors for floating-point data.  The predictors have a lot of nuances and I wouldn't trust my code to produce "valid" TIFF for those combinations of options where I don't have standard samples to test against.  All the samples I have so far are 32-bit tile-based files.  I've found hundreds of those from the US Geological Survey. But I haven't found any strip-based files.

The 14 April commit (e390778) concludes the preliminary work of enabling Commons Imaging to read images from TIFF files that are based on floating-point data.  I am now shifting to implementing new functionality to extract floating-point raster data from the TIFF.  I will be adding new blocks of code to the data-reader classes and the TiffImageParser, but do not plan on any further modifications to the existing code.

New classes and methods for accessing floating-point data are now included.
Only a few details remain for the code is ready for review.  I extended some of the unit tests, but still need to add new ones for the TiffRasterData and TiffRasterStatistics classes.  I also have a new example class and want to see if I can raise the Coverall scores for a few of my changes.  I hope to have it ready by the end of the weekend.

Ready for review at last.   I have completed the changes for IMAGING-251 pending your review. Thanks for your patience.

Thank you for such great work @gwlucastrig! Will try to review between today and next weekend :+1: Should probably start planning the next alpha2 release soon too, once this has been merged.

Made one last change to a new method to give it package scope rather than public.  This change will point users toward using the TiffDirectory class to access data rather than the TiffImageParser.  As I study the design of this package, it appears that TiffImageParser was really intended as an internal utility class.  TiffDirectory is better suited for direct use by applications.

Sorry.  One more last-minute change.  I discovered a NullPointerException when the TiffImageParser was passed a null argument.

I thought I should point out one aspect of the new API elements that I think is not optimal.  When I added the getFloatingPointRasterData() method to the TiffDirectory class, I had it take ByteOrder as an argument.   I took this approach because the existing "getTiffImage" methods did the same thing. But as I look at the unit tests and example applications that use it, it seems awkward to make the code handle a data element that is extraneous to the task that it is trying to accomplish.  It's just one extra thing for a developer to have to keep track of and doesn't give him any added capability.
I've done some research and studied the TIFF specification, and it's clear that byte order is only specified one place in a TIFF file and doesn't change once the header section of the file is read. So I think a better approach to the new functionality would be to make the TiffDirectory class have byte-order as a member element that was populated by the constructors. Then the getFloatingPointRasterData() would not need it as an argument.
Since I've already said that I've "finished" this Pull Request (pending your review), I won't burden you with more changes...   But I may submit the change as a future PR, if you think it a good idea.

Since I've already said that I've "finished" this Pull Request (pending your review), I won't burden you with more changes... But I may submit the change as a future PR, if you think it a good idea.

No burden at all (but thanks for considering that), we should use the momentum to improve as much as we can IMO. @gwlucastrig do you think it fits into this PR? If so, feel free to add a new commit.
Or, if you think this would be easier to review separately, feel free to create a new PR. Separate smaller pull requests would be easier to review, but only if you think it makes sense. Once a separate PR is done, then we can rebase this or other existing PR's to have the new changes.

I think the change would fit perfectly into the PR.  I will try to get the work turned in tonight.

No hurry @gwlucastrig :+1:

This submission completes my work on the PR (pending review comments).  Thank you for the opportunity to work on Commons Imaging.

Just checking in.   Do you have all the information you need to process this pull request?  Is there anything additional that I need to do?
Thanks.
Gary

I had no idea the pom.xml changed. Netbeans is a pain.   I will put it back tonight.
On Fri, May 8, 2020, 6:49 AM Bruno P. Kinoshita<EMAIL_ADDRESS>wrote:

@kinow commented on this pull request.
In pom.xml
https://github.com/apache/commons-imaging/pull/72#discussion_r422074883:

 <artifactId>selenium-java</artifactId>

 <scope>test</scope>

 <version>2.44.0</version>

 <groupId>com.opera</groupId>

 <artifactId>operadriver</artifactId>

 <scope>test</scope>

 <version>1.5</version>

 <exclusions>

   <exclusion>

     <groupId>org.seleniumhq.selenium</groupId>

     <artifactId>selenium-remote-driver</artifactId>

   </exclusion>

 </exclusions>

@gwlucastrig https://github.com/gwlucastrig what tests are using
Selenium?
In
src/main/java/org/apache/commons/imaging/formats/tiff/datareaders/DataReaderStrips.java
https://github.com/apache/commons-imaging/pull/72#discussion_r422076450:

@@ -166,7 +166,7 @@ private void interpretStrip(
// this logic will handle all cases not conforming to the
// special case handled above

   try (final BitInputStream bis = new BitInputStream(new ByteArrayInputStream(bytes), byteOrder)) {

   try (BitInputStream bis = new BitInputStream(new ByteArrayInputStream(bytes), byteOrder)) {

The less differences in the pull request that are not directly related,
the easier it is to review the changes IMO. But if you changed only one or
two places that should be fine, otherwise it's better to send the PMD
changes in another PR.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/apache/commons-imaging/pull/72#pullrequestreview-408154953,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AEWJDYKC67GLF2JCSZJNOXTRQPPSFANCNFSM4MAWGVRQ
.

Documentation for the TIFF Floating Point format and predictor (predictor 3) is given in http://chriscox.org/TIFFTN3d1.pdf
The document mentions interleaved formats, which I assume might be used to store complex numbers or vectors.  However, I did not implement them because I was unable to find examples. It also mentions some specialized 16-bit and 24-bit floating-point formats. Again, I was not able to find examples (and I think the use of these formats to be unlikely on modern hardware).

Thanks for the excellent review comments.  I will do changes over the next few days.

Had all sorts of trouble with maven reporting a Package Container issue on the verify phase.  Naturally, it offered no useful information about what the problem could be.  Code compiled fine.  I had the back out all my changes and start over.  The only thing I can think of is that it may be related to a Java versioning issue because I added lambda's to the photometric interpreters (as suggested in the code review, which I thought was a good idea).  But that seems unlikely since my JDK is version 1.8.0_211.  So I am puzzled.
Anyway, I am past that and will continue working to integrate the recommendations related to the photometric interpreters.

I tracked down the change that resulted in the Maven failure.  Since I haven't really studied Maven (I just treat it as a black box), I'm not really sure how to interpret this.  But I am working around the problem by simply not making the change.
In PhotometricInterpreterFloat.java, line 158.   I change the code from
Collections.sort(rangePaletteEntries, comparator);
Collections.sort(singleValuePaletteEntries, comparator);

to the following
rangePaletteEntries.sort(comparator);
singleValuePaletteEntries.sort(comparator);

I get a report of an API incompatibility in animal-sniffer-maven-plugin:1.17 complaining
of a NoSuchMethodError: java.nio.CharBuffer.position(I)Ljava/nio/CharBuffer;
Not sure if this is a bug in animal-sniffer (they've got a new version out).  I may test that after I get my code turned in.
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  7.835 s
[INFO] Finished at: 2020-05-13T01:58:21-04:00
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal org.codehaus.mojo:animal-sniffer-maven-plugin:1.17:check (checkAPIcompatibility) on project commons-imaging: Execution checkAPIcompatibility of goal org.codehaus.mojo:animal-sniffer-maven-plugin:1.17:check failed: An API incompatibility was encountered while executing org.codehaus.mojo:animal-sniffer-maven-plugin:1.17:check: java.lang.NoSuchMethodError: java.nio.CharBuffer.position(I)Ljava/nio/CharBuffer;
[ERROR] -----------------------------------------------------
[ERROR] realm =    plugin>org.codehaus.mojo:animal-sniffer-maven-plugin:1.17
[ERROR] strategy = org.codehaus.plexus.classworlds.strategy.SelfFirstStrategy
[ERROR] urls[0] = file:/C:/Users/gwluc/.m2/repository/org/codehaus/mojo/animal-sniffer-maven-plugin/1.17/animal-sniffer-maven-plugin-1.17.jar
[ERROR] urls[1] = file:/C:/Users/gwluc/.m2/repository/org/codehaus/mojo/animal-sniffer/1.17/animal-sniffer-1.17.jar
[ERROR] urls[2] = file:/C:/Users/gwluc/.m2/repository/org/ow2/asm/asm/6.2/asm-6.2.jar
[ERROR] urls[3] = file:/C:/Users/gwluc/.m2/repository/org/codehaus/mojo/java-boot-classpath-detector/1.17/java-boot-classpath-detector-1.17.jar
[ERROR] urls[4] = file:/C:/Users/gwluc/.m2/repository/org/codehaus/plexus/plexus-component-annotations/1.5.4/plexus-component-annotations-1.5.4.jar
[ERROR] urls[5] = file:/C:/Users/gwluc/.m2/repository/org/sonatype/sisu/sisu-inject-bean/1.4.2/sisu-inject-bean-1.4.2.jar
[ERROR] urls[6] = file:/C:/Users/gwluc/.m2/repository/org/sonatype/sisu/sisu-guice/2.1.7/sisu-guice-2.1.7-noaop.jar
[ERROR] urls[7] = file:/C:/Users/gwluc/.m2/repository/org/slf4j/slf4j-jdk14/1.5.6/slf4j-jdk14-1.5.6.jar
[ERROR] urls[8] = file:/C:/Users/gwluc/.m2/repository/org/slf4j/jcl-over-slf4j/1.5.6/jcl-over-slf4j-1.5.6.jar
[ERROR] urls[9] = file:/C:/Users/gwluc/.m2/repository/org/apache/maven/reporting/maven-reporting-api/2.2.1/maven-reporting-api-2.2.1.jar
[ERROR] urls[10] = file:/C:/Users/gwluc/.m2/repository/org/apache/maven/doxia/doxia-sink-api/1.1/doxia-sink-api-1.1.jar
[ERROR] urls[11] = file:/C:/Users/gwluc/.m2/repository/org/apache/maven/doxia/doxia-logging-api/1.1/doxia-logging-api-1.1.jar
[ERROR] urls[12] = file:/C:/Users/gwluc/.m2/repository/commons-cli/commons-cli/1.2/commons-cli-1.2.jar
[ERROR] urls[13] = file:/C:/Users/gwluc/.m2/repository/org/codehaus/plexus/plexus-interactivity-api/1.0-alpha-4/plexus-interactivity-api-1.0-alpha-4.jar
[ERROR] urls[14] = file:/C:/Users/gwluc/.m2/repository/backport-util-concurrent/backport-util-concurrent/3.1/backport-util-concurrent-3.1.jar
[ERROR] urls[15] = file:/C:/Users/gwluc/.m2/repository/org/sonatype/plexus/plexus-sec-dispatcher/1.3/plexus-sec-dispatcher-1.3.jar
[ERROR] urls[16] = file:/C:/Users/gwluc/.m2/repository/org/sonatype/plexus/plexus-cipher/1.4/plexus-cipher-1.4.jar
[ERROR] urls[17] = file:/C:/Users/gwluc/.m2/repository/org/codehaus/plexus/plexus-interpolation/1.11/plexus-interpolation-1.11.jar
[ERROR] urls[18] = file:/C:/Users/gwluc/.m2/repository/org/apache/commons/commons-lang3/3.7/commons-lang3-3.7.jar
[ERROR] urls[19] = file:/C:/Users/gwluc/.m2/repository/org/apache/maven/shared/maven-common-artifact-filters/1.4/maven-common-artifact-filters-1.4.jar
[ERROR] urls[20] = file:/C:/Users/gwluc/.m2/repository/org/codehaus/plexus/plexus-utils/1.5.6/plexus-utils-1.5.6.jar
[ERROR] Number of foreign imports: 1
[ERROR] import: Entry[import  from realm ClassRealm[maven.api, parent: null]]
[ERROR]

Found the problem.   The CharBuffer.position() method appears to have been introduced in Java 9.  So the Java 8 API that I build with doesn't support it.
I have been very reluctant to use more recent versions of Java because of Oracle's changes to licensing policies.   I may have to revise my thinking on that one.

Hopefully there should be some way (maybe not as simple) to achieve the same with Java 8 @gwlucastrig . If not we can think in other alternatives.

I believe that I have now integrated all the changes from the review comments with two exceptions.
The TiffRasterData.getData() method still exposes and internal array.  However, I've added Javadoc explaining the rationale and use of the method.
The Collections.sort() methods in PhotometricInterpreterFloat are still there.  When I made the recommended changes, animal-sniffer threw an exception.  I then installed Java JDK 11 (picking 11 because that's what Travis uses) and the same thing happened.  So I am leaving the older code in place.
My plan is to do a bit more testing over the next few days.  I do not plan to make any further code changes unless I encounter an unexpected error.

Excellent Gary! I have time to review it again this weekend. I think it should be ready to merge now if I find nothing else in the review
Should we delay mergimg until you finish your tests?

All my tests completed successfully.  I have some pretty nice pictures to show for it.
When accepted, I believe you will be able to close both JIRA item 251 and 102.
I am currently working on a tutorial showing how to use the Commons Imaging API to read elevation data.  When it's done, I will be posting it on my wiki page at Gridfour Wiki.  I will, of course, make sure it links to Commons Imaging.

Nice! Will start going through it tomorrow. Thanks!!!!

No blockers so far, another 9 files to go, and then review is done. Comments added now can either be fixed before merging, or afterwards.
@gwlucastrig do you mind if when merging I squash the commits when merging?

@kinow I would prefer that you squash the commits.  I didn't know that there was a git command that allowed you to do that.
I renamed IPaletteEntry to simple PaletteEntry.  I got a list of all Java files in the commons-imaging source code and saw that none of the others used the leading-I convention. So it makes sense to rename the class.

Brilliant! Then tomorrow I will finish the review. Final things I'm looking at are

test coverage of new code (I lost track of how much is covered here)
possible issues for security (those N/0, or loading values from the data without checking boundaries, etc)
how much we broke backward compatibility—if any

If nothing is wrong, then I will just squash. Several ways of doing it I think; I normally do with git rebase -i HEAD~N, where N is the number of commits I want to squash. Doesn't mean we need to squash to a single one, but we can probably combine a few ones. And add a changelog, and merge :-)
Thanks for updating it so quickly!
Bruno

test coverage of new code (I lost track of how much is covered here)

Some of the new code is not covered by tests. But alas I think it's quite hard to find images for these tests. Later we may look into having some sort of image generator, or try to locate more test images.
https://coveralls.io/builds/30831964

possible issues for security (those N/0, or loading values from the data without checking boundaries, etc)

Nothing obvious. A fuzzer could still find some images that could lead to exceptions, but I couldn't find a case where it would lead to DDoS attacks (:crossed_fingers:)

how much we broke backward compatibility—if any

Nothing too drastic—i.e. API changes OK IMHO for next alpha release (this will change once we have 1.0 out)

Approved. Rebasing and merging. Thanks @gwlucastrig !


refactor: import and export statements in BaseResolversVisitor and ma…

fix: https://github.com/dotansimha/graphql-code-generator/issues/7762
🚨 IMPORTANT: Please do not create a Pull Request without creating an issue first.
Any change needs to be discussed before proceeding. Failure to do so may result in the rejection of the pull request.
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Related # (issue)

Type of change
Please delete options that are not relevant.

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

Screenshots/Sandbox (if appropriate/relevant):
Adding links to sandbox or providing screenshots can help us understand more about this PR and take action on it as appropriate
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

[ ] Test A
[ ] Test B

Test Environment:

OS:
@graphql-codegen/...:
NodeJS:

Checklist:

[ ] I have followed the CONTRIBUTING doc and the style guidelines of this project
[ ] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes
[ ] Any dependent changes have been merged and published in downstream modules

Further comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

I've fixed everything, it would be great if we could publish this.

I have attached the test.

thank you!

released new version https://github.com/dotansimha/graphql-code-generator/releases/tag/release-1708451740568


[Bug]: element screenshot not vertically aligned with element

Bug description
When selecting an element and then taking a screenshot, I consistently get screenshots that are a fair number of pixels further down the page than the element I'm targeting.
Steps to reproduce the problem:
import puppeteer from 'puppeteer';

const run = async () => {
  const browser = await puppeteer.launch({
    headless: false,
  });
  const page = await browser.newPage();
  await page.goto('https://stackoverflow.com/');

  const header = await page.waitForSelector('body > header');
  await header?.screenshot({ path: 'header.png' });
  await browser.close();
};

run();

This is the page itself:

Given the selector, I'd expect a result like this:

Instead, I get something like this from the code above:

It's clearly just below the header.  If the element is large enough, I'll get most of the element but the top will be missing and I'll have content from below it included.  It's like everything is vertically offset by 100-200 pixels.
This is consistent across several sites I've tried.  The reproduction is intentionally contrived on a stable selector.
Puppeteer version
13.3.0
Node.js version
v16.13.2
npm version
8.1.2
What operating system are you seeing the problem on?
macOS
Relevant log output
N/A

Additional data point - if I manually use Chrome dev tools to take a screenshot of the node, I get the expected result:

cc @sadym-chromium

I am experiencing this also with 13.3.1

Same issue even on simple html with only one paragraph.
Works fine if I use puppeteer v10.1 and below.
Seems a bug from v10.2 and newer.

I have this issue too. Screenshoting elements is just completely broken and takes random screenshots


installation attempts to access remote server

https://github.com/fdopen/uwt/blob/master/libuv-compile.sh#L17 is uncool.
Why does it do this? Can you just make libuv a dependency/depext?
Also, version 0.0.1 published in opam uses the old broken URL and so fails every build now.

Ok,
I've made it optional ( https://github.com/fdopen/uwt/commit/ec04354631d0892e302652ec788825ccf2a0be86 ) and fixed the broken URL ( https://github.com/ocaml/opam-repository/pull/4401 )


ubuntu-12.04.1-server-amd64.iso postinstall.sh sudo setup is different from other ubuntu's

Hi,
Is there a reason why sudo setup in ubuntu-12.04.1-server-amd64.iso/postinstall.sh is different from other ubuntu's postinstall.sh script?
ubuntu-12.04.1-server-amd64.iso/postinstall.sh:
# Setup sudo to allow no-password sudo for "sudo"
usermod -a -G sudo vagrant
cp /etc/sudoers /etc/sudoers.orig
sed -i -e 's/%sudo   ALL=(ALL:ALL) ALL/%sudo   ALL=(ALL:ALL) NOPASSWD:ALL/' /etc/sudoers

ubuntu-12.04.2-server-i386.iso/postinstall.sh (and other ubuntu's postinstall.sh)
# Setup sudo to allow no-password sudo for "admin"
groupadd -r admin
usermod -a -G admin vagrant
cp /etc/sudoers /etc/sudoers.orig
sed -i -e '/Defaults\s\+env_reset/a Defaults\texempt_group=admin' /etc/sudoers
sed -i -e 's/%admin ALL=(ALL) ALL/%admin ALL=NOPASSWD:ALL/g' /etc/sudoers

The reason I raised this issue is because I received error messages when vagrant up and vagrant halt an ubuntu-12.04.1-server-amd64 VM. But this doesn't happen to other ubuntu definitions.
$ vagrant up
Bringing machine 'default' up with 'virtualbox' provider...
[default] Importing base box 'precise64-vanilla'...
[default] Matching MAC address for NAT networking...
[default] Setting the name of the VM...
[default] Clearing any previously set forwarded ports...
[default] Creating shared folders metadata...
[default] Clearing any previously set network interfaces...
[default] Preparing network interfaces based on configuration...
[default] Forwarding ports...
[default] -- 22 => 2222 (adapter 1)
[default] Booting VM...
[default] Waiting for VM to boot. This can take a few minutes.
[default] VM booted and ready for use!
The following SSH command responded with a non-zero exit status.
Vagrant assumes that this means the command failed!

echo $(chef-solo --v | awk "{print \$2}" || "")

$ vagrant halt
[default] Attempting graceful shutdown of VM...
The following SSH command responded with a non-zero exit status.
Vagrant assumes that this means the command failed!

shutdown -h now

closing as there was no feedback in three months, please let me know if you can provide more details and I will reopen


Disable PTS from local and enable it for PRs

The github yaml configuration make this a bit ugly.
This was discussed with the gradle folks on how to improve the usage of PTS.
PTS on local doesn't provide us too much benefits because it breaks the incremental compilariont (UP-TO-DATE check).
The idea is that we make our PR checks faster now that we have a trained PTS but we run all our tests once it's merged to main to ensure that nothing was broken.

I would like to have more eyes on this to ensure that we are ok with the change that this implies. The code is really simple now but I want to be sure that we agree with this.


Absence of license

You don't have any licence in this work, you just have some disclaimers in some scripts, I would sugest you to use a LGPL or a GPL licence. I ask you this because we are thinking on using this project as part of other proect and we need to know we can actually use it.

I'll check that out. Silvan Melchior was the original author, but has not been involved for the last couple of years.

My idea here on this is to use the MIT License which is short, simple and permissive. I am checking if silvan is OK with this.

SIlvan was OK with this so I have added MIT LIcense file

Thanks a lot


Supports direct jump to a point in the timeline to play

How to use this
Supports direct jump to a point in the timeline to play
i applied seek time but it is taking time  re playing video. it is showing black screen more time then after playing

same issue facing. some times using seek bar finishing video then didtoend methods calls twice

Same here, would be interesting to see how it's done.


Schema Compare Apply fails with an error

Steps to Reproduce:

Right click on database project and click "Update project from database"
View changes and click aply

@rickhopkins - can you summarize or share the changes that would be applied to the project?

@rickhopkins - can you summarize or share the changes that would be applied to the project?

I put screenshots up above. My workaround has been to delete the affected files, re-run the compare, and then apply. This seems to fix the issue, but sometimes I have quite a few more errors and it would be nice if it could apply properly. Also, it will modify the first file and really seems to mangle it... from the example above this is the Staff_Email file...