Brotli web tests

Retest performance on Canterbury set of files after API rewriting and add set of different web files.
As in previous performance tests (https://github.com/dotnet/corefxlab/pull/1618) The result below is in how many times GzipStream is faster than Brotl (red  - faster more than 2 times, yellow little bit faster, green - slower, white - pretty equal). Light Blue color of test name means that it is web file.
Compress:

Decompress

And Compression Ratio(green means Brotli better):

Also we need to do something with CompressionLevel, because now we can't have clear result instead of difference of it. In GZip NoCompression is literally no compression in my case it is the lowest possible compression. So know we can really compare Fastest and Optimal level. So, as expected compression ratio is higher, decompress speed is equal on small files and higher on large, compress speed is slower in most cases. But I really don't understand how Brotli Compress can work faster on NoCompression level.

@Vedin,
Thanks for having already signed the Contribution License Agreement. Your agreement was validated by .NET Foundation. We will now review your pull request.
Thanks,
.NET Foundation Pull Request Bot

@dotnet-bot test Innerloop Ubuntu16.04 Debug Build and Test


implement Reflect for Fxaa

Objective

public components and resources should implement Reflect if possible

Solution

derive Reflect

Seconding the above requests.

bors r+


JS client semantic release set-up

@maoo : NPM_TOKEN would be needed for deployment. It would come under namespace @finos/fdc3-backplane-client. Can you please help with NPM_TOKEN set-up for this repo which has appropriate privileges  to deploy to npm under @finos.
Also how does @finos/fdc3 release and deployment work ?

@maoo : NPM_TOKEN would be needed for deployment. It would come under namespace @finos/fdc3-backplane-client. Can you please help with NPM_TOKEN set-up for this repo which has appropriate privileges to deploy to npm under @finos.

Done!

Also how does @finos/fdc3 release and deployment work ?

This is how FDC3 is publishing packages - https://github.com/finos/FDC3/blob/master/.github/workflows/package.yml#L55
I guess it's a similar approach than the one you're following.


envoy responds upstream connect error: connection termination

When KFP-UI sends a request to envoy in order to fetch ML metadata from metadata-grpc-service, we see the following error:
Cannot find context with {"typeName":"system.PipelineRun","contextName":"2b2eae10-e8fc-4427-8142-7e8c30fcfb27"}: upstream connect error or disconnect/reset before headers. reset reason: connection termination

This is a message received from envoy service which is probably not configured properly.
Debug
Applying upstream envoy Deployment, Service and VirtualService solved the issue, thus we confirm that it's our envoy configuration that creates an issue.

From envoy upstream issue https://github.com/grpc/grpc-web/issues/907, we see that

This is a general error that Envoy cannot connect to your backend service.

The issue was that were missing static.resources.http2_protocol_options field that upstream envoy.yaml has.
As the docs mention:

Precisely one of http_protocol_options, http2_protocol_options, http3_protocol_options must be set.

PR Configure envoy-operator for CKF 1.8 introduced this but it turns out that when there is no parameter/value, envoy_data_plane SDK doesn't render this at all. In order to overcome this, we need to set the (required) parameter stream_error_on_invalid_http_messaging to its default value (False)


Does not pickup softWrap settings

I have enabled the softWrap, but when I do the export, but the output seems did not get picked up.

This would actually be an awesome feature to add to this package. Prevents me from using it in larger projects, as there is always a couple lines that end up being cut in the printout.


Use common http parameters across http and grpc

Signed-off-by: Appu Goundan<EMAIL_ADDRESS>

Are you thinking of having http and grpc implementations over the long term?

oh I see, this is across the different clients.


added S3 storage binding

I created this binding for the amazon S3 storage. I used the S3 sdk. I tried to translate the operations insert, read, scan, update to be compatible with the S3 storage. The README I included explain how to use the binding. It compiles correctly. I hope it can be useful for this project.

Is there a mock/stub version of the AmazonS3Client (or its parent interface) that could be used to write tests for the basic round trip operations? Nothing too fancy but it would be nice to see:

We can read back what we inserted and it matches what we inserted.
A delete of an inserted record succeeds (zero status) and then a read of that record fails.
A delete of a missing record fails (non-zero status).
An insert of a duplicate record succeeds or fails (and is documented somewhere).
A scan over inserted records returns the expected records.
An update of an inserted record succeeds and then a read returns the updated record.
An update of a missing record fails.

Let us know if there's anything we can help with @ivanB1975

I am back from holidays, I will work on the repo next days trying to fix the issues and add the requested new features. I will surely welcome any possible help. I will try to come back as soon as possible during the weekend

Regarding the question: "Is there a mock/stub version of the AmazonS3Client (or its parent interface) that could be used to write tests for the basic round trip operations?"
The testing I was doing was just checking that the files are written correctly, that the size of the files matches the size uploaded. For the reading, I was checking (writing to a file for example) that the file downloaded correspond to the size to the file targeted. For the content matching this can be done uploading a defined content, or maybe creating a md5 hash of the content and then checking the hash of the downloaded files.
The scan operation was more difficult to reproduce for s3. And in this maybe you could advise me, if the way I am doing it is correct.
I will work on this mock/stub version, and wait the comments on the changes I made to comply with your previuos comments.

Hi guys can you check the latest changes I made? If something more needed then I can work on it.
Many thanks
Ivan

If you have a chance, it would be helpful if you could update your commits to have "[s3] " as a prefix for the first line of each commit message. It makes it easier to scan through updates after things get merged into the main repo.

Hi guys, thank you very much for the feedbacks. I will come back to all of these and modify the code.
Bests
Ivan

I added the support for server side encryption, that can now be selected setting in s3.properties "s3.sse=true"

I also added the support for SSE-C encryption. This can be used placing on the s3.properties file "s3.ssec=THE-KEY-TO-USE", if not present the encryption is not used.

added setProtocol for the s3 client. In s3.properties, to select the HTTPS protocol, set the "s3.protocol=HTTPS"

changed the s3.protocol default to HTTPS

Hi guys when would you like to merge the pull request to the master? Do you have a time schedule? Do you need other improvements from my side? So I can organize my free time to work on it.

I think all of my concerns have been addressed. I need someone to test out actually using it against S3. I should have time for that by the end of this week.
@allanbank anything else you'd like to see handled?

@busbey I made a couple of small comments but I am happy with it even in the current state.

Any news?

Thanks for your patience @ivanB1975!

boo. didn't check age of last rebase. pushing addendum shortly. sorry folks.

Sorry @ivanB1975 I had to revert because of the status code changes. I'll make updating and pushing this a priority, if no one else gets to it before me.

Waiting next news :)

If you couod look at #512 and confirm that it works for you, that'd be great.

I will do later today surely
On 25 Nov 2015 14:19, "Sean Busbey"<EMAIL_ADDRESS>wrote:

If you couod look at #512
https://github.com/brianfrankcooper/YCSB/pull/512 and confirm that it
works for you, that'd be great.
—
Reply to this email directly or view it on GitHub
https://github.com/brianfrankcooper/YCSB/pull/372#issuecomment-159605132
.

Tested the #512 and I confirm that it is working fine. Thanks


ENH:optimize: Rewrite MINPACK in C

Towards #18566
Due to the function callbacks required by MINPACK, Travis' jumped quite a number of hoops in the header/module files of MINPACK. They also went a bit over my head however I am trying to stay faithful to those just by modifying some signatures here and there and adding as many const as possible.
The code is less scary than I thought but half of the internal functions are available in LAPACK. However, I left it for future to have identical setup first.
When the rewrite is complete and it starts compiling properly I'll search for open issues that this might close.

Compiling and failing 54 tests without any segfaults on my Win and Linux boxes. There are some adjustments needed for Fortran 1-index expectations and also some internal Fortran guards that I could not find yet. But in case you would like to check it, all feedback welcome.

How about that; all green. Take that six gazillion 1-indexed for loops!
The code can be substantially shortened with LAPACK calls but I'll leave it to the next overhaul that might happen in the next 40 years. Other than that, all good from my side. Feedback welcome.

Thanks @dschmitz89. I tried a few larger problems but I couldn't trip it up. That doesn't mean much but increased my confidence more nevertheless.

Let me click this one in so we have some time until the branch off, to fix possible issues that might come downstream.
If anyone has any capacity implementing the original MINPACK tests to our suite, that would be great. Not sure if we are using these elsewhere but definitely would give more confidence.
Moré, Garbow, Hillstrom, "Testing Unconstrained Optimization Software"


[10.x] Add order by field clause to mysql queries

What is the change?
This PR introduces the orderByField() method to the query builder, enabling support for the order by field() clause in MySQL queries.
Why is this change good?
currently, achieving a query with the order by field() can be done like this:
$values = [1,2,3];
DB::table('users')->select('id')->orderByRaw('field(`id`, ?, ?, ?) desc', $values)->get();

with this PR, you can achieve the same query like this:
$values = [1,2,3];
DB::table('users')->select('id')->orderByField('id', $values,'desc')->get();

also, this PR allows you to pass "Queryable" columns like this:
DB::table('users')->from('users')->orderByField(function ($query) {
            return $query->select('created_at')->from('logins')->whereColumn('user_id', 'users.id')->limit(1);
        }, $values,'desc');

please let me know what you think
thank you ❤

Thanks for your pull request to Laravel!
Unfortunately, I'm going to delay merging this code for now. To preserve our ability to adequately maintain the framework, we need to be very careful regarding the amount of code we include.
If possible, please consider releasing your code as a package so that the community can still take advantage of your contributions!
If you feel absolutely certain that this code corrects a bug in the framework, please "@" mention me in a follow-up comment with further explanation so that GitHub will send me a notification of your response.


Instanced graphics

Add support for creating reusable graphic templates that can be instanced multiple times.
Motivation

WFS server serving data sets consisting of many, many points indicating the locations of various objects like different kinds of road signs. They have a glTF model for each kind of road sign. They want to efficiently draw each road sign at the position specified in the WFS data (i.e., instanced rendering). They need to be able to process the WFS data and produce the graphics on a Worker. They want to reuse the same glTF assets with different sets of instances without duplicating the WebGL resources.

Use GraphicBuilder or GraphicDescriptionBuilder to create a graphic, which may internally contain several graphics. Draw that graphic repeatedly using instancing. When the graphic contains multiple graphics, the WebGL resources defining the instances should be reused for each graphic - not duplicated.

Obstacles
Today we have InstancedGraphicParams which can be used to specify that you want to draw the same geometry repeatedly with different transforms, feature Ids, and symbology. We use it for iMdl, glTF, and particle collections. However, we provide no APIs to create an InstancedGraphicParams directly, nor documentation of how to do it yourself. InstancedGraphicParams are not reusable - they allocate WebGL buffers that are associated with one graphic.
Solution
Define the concept of a GraphicTemplate. You can obtain one from a GraphicBuilder, GraphicDescriptionBuilder, or glTF asset. In its simplest form it is just a list of RenderGeometry. Since glTF assets describe a scene graph, the templates they produce may contain multiple nodes, each consisting of a list of RenderGeometry and a Transform.
Define the concept of RenderInstances. This defines the transforms and optional feature Ids and/or symbology overrides for a set of instances.
Add RenderInstancesParams describing how to create a RenderInstances, and a straightforward, Worker-safe RenderInstancesParamsBuilder API to produce them.
Add to RenderSystem the following operations:

createGraphicTemplate. This is used internally by the public APIs.
createRenderInstances to produce a RenderInstances (holding reusable WebGL buffers) from a RenderInstancesParams
createGraphicFromTemplate accepting a GraphicTemplate and a RenderInstances and producing a RenderGraphic.

This decouples the instances from the template, so they can be mixed, matched, and reused as the user sees fit.
I enhanced display-test-app's dta gltf key-in with additional arguments to support instancing.
TODO

[ ] NextVersion.md
[ ] Example code
[x] ImageTests - no differences reported
[x] Unit tests
[x] Update display-test-app README
[ ] Fix vite run-time error in display-test-app

display-test-app builds successfully (rush build --to display-test-app) but at run-time produces the following error in browser console:
Uncaught SyntaxError: The requested module<EMAIL_ADDRESS>does not provide an export named 'InstancedGraphicParams' (at ImdlGraphicsCreator.ts:23:10)
Seems like a vite issue. I have run into this before, and solved it by replacing import with import type.
However, ImdlGraphicsCreator.ts definitely uses InstancedGraphicParams as both a value and a type, so it needs to import it as a value. InstancedGraphicsParams is both an interface and a namespace.
@aruniverse do you know anybody who knows anything about vite?

@aruniverse do you know anybody who knows anything about vite?

@hl662 or I can take a look at this tomorrow

@hl662 or I can take a look at this tomorrow

Thank you. FWIW, the following appeases it for that file but just produces the same error for the import in RenderInstancesParamsImpl.ts.
diff --git a/core/frontend/src/tile/ImdlGraphicsCreator.ts b/core/frontend/src/tile/ImdlGraphicsCreator.ts
index 1cf01eb716..48ea3eed1f 100644
--- a/core/frontend/src/tile/ImdlGraphicsCreator.ts
+++ b/core/frontend/src/tile/ImdlGraphicsCreator.ts
@@ -20,7 +20,7 @@ import { VertexIndices } from "../common/internal/render/VertexIndices";
 import type { RenderGraphic } from "../render/RenderGraphic";
 import { GraphicBranch } from "../render/GraphicBranch";
 import type { RenderSystem } from "../render/RenderSystem";
-import { InstancedGraphicParams } from "../common/render/InstancedGraphicParams";
+import * as instancedGraphicParams from "../common/render/InstancedGraphicParams";
 import type { IModelConnection } from "../IModelConnection";
 import { GraphicDescription } from "../common/render/GraphicDescriptionBuilder";
 import { GraphicDescriptionImpl, isGraphicDescription } from "../common/internal/render/GraphicDescriptionBuilderImpl";
@@ -226,11 +226,11 @@ function getMaterial(mat: string | Imdl.SurfaceMaterialParams, options: Graphics
   return options.system.createMaterial(params, options.iModel);
 }

-function getModifiers(primitive: Imdl.Primitive): { viOrigin?: Point3d, instances?: InstancedGraphicParams } {
+function getModifiers(primitive: Imdl.Primitive): { viOrigin?: Point3d, instances?: instancedGraphicParams.InstancedGraphicParams } {
   const mod = primitive.modifier;
   switch (mod?.type) {
     case "instances":
-      return { instances: InstancedGraphicParams.fromProps(mod) };
+      return { instances: instancedGraphicParams.InstancedGraphicParams.fromProps(mod) };

The error occurs in electron. It does not occur (and the app runs normally) in firefox.

Are there any other steps to reproduce?

Not as far as I can tell.
rush build --to display-test-app
cd test-apps/display-test-app
npm run start

Opens the window with infinite spinner and error in dev tools console.
I'm not sure what variables between our setups might be relevant. Ubuntu here, but I'd hope that wouldn't matter. I can test on Windows though.
I know little about vite. When I run the dev server is it compiling on the fly? Is it putting the compiled code somewhere I can inspect it?

I know little about vite. When I run the dev server is it compiling on the fly? Is it putting the compiled code somewhere I can inspect it?

When running the dev server, Vite is compiling the app on the fly with esbuild. We added a vite plugin, vite-plugin-inspect, to debug but it might not be the most useful. You can see all the transforms Vite runs (actually make the code ESM compliant, eg changes imports to use the actual file extension). While the dev server is running you can visit http://localhost:3000/__inspect, you can see in memory transformed files

http://localhost:3000/__inspect/#/module?id=%2FUsers%2Farun%2Frepos%2Fgh%2Fimjs%2Fitwinjs-core%2Fcore%2Ffrontend%2Fsrc%2Fcommon%2Frender%2FInstancedGraphicParams.ts

Will investigate if theres anything more we can do to help debug

Yeah, inspect shows the same for me. It's clearly exporting InstancedGraphicParams and lets me access it if I import * as Foo.

I can't reproduce the issue on Windows either. The contents of InstancedGraphicParams.ts and ImdlGraphicsCreator.ts look identical to me in vite-inspect, other than the absolute paths differing as expected.

I can't reproduce the issue on Windows either.

I'm on Mac. I dont really understand why this would come down to being an OS issue.
Could you provide more details re your dev env? OS ver, node ver, etc

I'm on Mac. I dont really understand why this would come down to being an OS issue. Could you provide more details re your dev env? OS ver, node ver, etc

Ubuntu 22.04.4 LTS. node v18.16.0. npm 9.5.1.
The same issue is reproducible when importing InstancedGraphicProps from same file. It is a type merged with a namspace, just as InstancedGraphicParams is an interface and namespace. I don't see any other examples of such merged type+namespace in core-frontend. Plenty of merged class+namespace, which present no problem, presumably because both are values. I can import+use ElementGeometryChange from core-common without complaint - it's a type+namespace.

Just following up, I'm on Mac, I can reproduce the error you're getting @pmconne. I'm using node 20.11.1, npm v 10.2.4. Just started investigating now...

I have a second copy of the repo on my linux box, I can repro it in there too. (I thought maaaybe some kind of weird caching issue but it seems not).

I have a second copy of the repo on my linux box, I can repro it in there too. (I thought maaaybe some kind of weird caching issue but it seems not).

Huh. I just updated vite in DTA's package.json to "^5.4.6" and the error is gone. Can you do the same?

I just updated vite in DTA's package.json to "^5.4.6" and the error is gone. Can you do the same?

Waddayaknow, guess they fixed it. Thanks!


[website] Training with Data from S3 article broken link

Description
Broken link on:
https://mxnet.apache.org/api/python/docs/tutorials/deploy/run-on-aws/index.html
This page tries to link to:
https://mxnet.apache.org/versions/master/faq/s3_integration.html

It should be fixed. Can't reproduce any more.


Adding the Guest role to user card in the admin console

Summary
Adding the Guest role to user card in the admin console

@cpanato I somehow got a notification from this PR. Is it a problem with the pull-assigner bot?


memory exchanging foundation: queue of call

rust bindings runtime: add three host functions

require_queue (each call will need to require a new queue)
write (write arguments/returns into queue)
read (read from queue)

Hello, I am a code review bot on flows.network.
It could take a few minutes for me to analyze this PR. Relax, grab a cup of coffee and check back later. Thanks!


V3: orderByChild + startAt or endAt

@Salakar Sorry to bother you again. It seems like orderByChild is not working, at least when used with startAt or endAt. I have a list of message objects that I want to query based on their timestamp.
This code returns zero results
firestack
  .database()
  .ref('messages/-KXlqrDgbJg_-FJCoDfE/')
  .orderByChild('createdAt')
  .startAt(1480609558242)
  .once('value')
  .then((snapshot) => {
    console.log('my snap', snapshot);
  })

while this code returns all results
firestack
  .database()
  .ref('messages/-KXlqrDgbJg_-FJCoDfE/')
  .orderByChild('createdAt')
  .endAt(1480609558242)
  .once('value')
  .then((snapshot) => {
    console.log('my snap', snapshot);
  })

Based on my sample data below…both results are wrong. The first example should return the first last two objects, the second example should return the first two objects.
I tried both the v3 branch of this repo as well as master branch of your fork. Based on the sample data the query above should return the first object. But nothing is returned

{
  "-KXlqrDgbJg_-FJCoDfE" : {
    "-KXv8Uvyix9Ns5FeF1O1" : {
      "_id" : "-KXv8Uvyix9Ns5FeF1O1",
      "createdAt" :<PHONE_NUMBER>717,
      "text" : "Test123",
      "user" : {
        "_id" : "If2AZYNhruXa4ELtYoviNe7JS2S2"
      },
      "wasSeen" : false
    },
    "-KXvCCjPLePNohIkjSw3" : {
      "_id" : "-KXvCCjPLePNohIkjSw3",
      "createdAt" :<PHONE_NUMBER>540,
      "text" : "Test456",
      "user" : {
        "_id" : "If2AZYNhruXa4ELtYoviNe7JS2S2"
      },
      "wasSeen" : false
    },
    "-KXvCDsZq__24IkB6zGs" : {
      "_id" : "-KXvCDsZq__24IkB6zGs",
      "createdAt" :<PHONE_NUMBER>242,
      "text" : "Test789",
      "user" : {
        "_id" : "If2AZYNhruXa4ELtYoviNe7JS2S2"
      },
      "wasSeen" : false
    },
    "-KXvQisiS1bsm3oYCdll" : {
      "_id" : "-KXvQisiS1bsm3oYCdll",
      "createdAt" :<PHONE_NUMBER>327,
      "text" : "Test101112",
      "user" : {
        "_id" : "If2AZYNhruXa4ELtYoviNe7JS2S2"
      },
      "wasSeen" : false
    }
  }
}

Hmm weird one @florianbepunkt - database in the current pushed up state of my branch has not been touched bar a PR from @BlooJeans which was on master that I manually pulled in.
Will look at this today and get back to you, the example helps, cheers!

@Salakar Maybe this is of interest #82 – it was not working properly on master until recently

@florianbepunkt looks like @chrisbianca fixed this issue 3 days ago on my branch - have you tried pulling the latest?
This commit:
https://github.com/Salakar/react-native-firestack/commit/ec9f48855f6580b2838b60db201e26f4fcb32a87

@Salakar I did. To make sure I just installed it again via npm install --save https://github.com/Salakar/react-native-firestack.git
The commit only changes things on android side… I see this problem with iOS.

I only updated the Android side as that's where I'd noticed the issue.
Just taken a look and a similar sort of change does need to happen on the iOS side - I'll see if I can take a look in a little while...

@florianbepunkt oh ok my bad, thought you were having an android issue sorry.
@chrisbianca that would be awesome thanks!

I'm not sure if this is related… using a fresh install from Salakar's fork I see the same issue on android.
Using my sample data

firestack
  .database()
  .ref('messages/-KXlqrDgbJg_-FJCoDfE/')
  .orderByChild('createdAt')
  .startAt(1480609558242)
  .once('value')
  .then((snapshot) => {
    console.log('my snap', snapshot);
  })

returns zero values…

Ok, I don't have any data setup to test this with at the moment.
When I get some time later on, I'll take a look and see if I can figure out what's going on.

@chrisbianca okay. I throw together a simple test project and upload it if that helps

@florianbepunkt that would be great!

@chrisbianca @Salakar Okay, here we go… https://github.com/florianbepunkt/fireStackQuery
you can clone the repo, run npm install and run it. I've tested it on ios and it reproduces the issue.

@florianbepunkt @Salakar
So I've figured out why it's broken in Java... It's passing the startAt and endAt as a String rather than a number.  The fix is an awful lot of repetitive code but I can't think of a better way to work around it!  Just pushed the fix to the v3 branch and sorted for boolean types too.
Will try and look at iOS now...

@chrisbianca great! just checked android version with your commit

I've just committed the equivalent fix for iOS.  I rewrote a large part of the iOS database module to bring it more in line with Android and stop regenerating firebase references unnecessarily.  Let me know if you have any other issues...

@chrisbianca I just freshly cloned my example project linked above and run npm install… tne ios part won't boot. android works fine.
this is the output of react-native log-ios
Dec  3 11:43:04 MacBook-Pro fireStackQuery[450] <Error>: [] nw_host_stats_add_src recv too small, received 24, expected 28
Dec  3 11:43:04 MacBook-Pro fireStackQuery[450] <Notice>: Initializing <RCTBatchedBridge: 0x6000001993d0> (parent: <RCTBridge: 0x6000000ae820>, executor: RCTJSCExecutor)
Dec  3 11:43:04 MacBook-Pro fireStackQuery[450] <Error>: [] nw_host_stats_add_src recv too small, received 24, expected 28
Dec  3 11:43:04 MacBook-Pro fireStackQuery[450] <Warning>: Setting up Firestace instance
Dec  3 11:43:04 MacBook-Pro fireStackQuery[450] <Error>: [Firebase/Core][I-COR000003] The default Firebase app has not yet been configured. Add [FIRApp configure] to your application initialization. Read more: https://goo.gl/ctyzm8.
Dec  3 11:43:04 MacBook-Pro fireStackQuery[450] <Error>: *** Terminating app due to uncaught exception 'FIRAppNotConfigured', reason: 'Failed to get default FIRDatabase instance. Must call FIRApp.configure() before using FIRDatabase.'
        *** First throw call stack:
        (
                0   CoreFoundation                      0x000000010631434b __exceptionPreprocess + 171
                1   libobjc.A.dylib                     0x000000010585e21e objc_exception_throw + 48
                2   CoreFoundation                      0x000000010637d265 +[NSException raise:format:] + 197
                3   fireStackQuery                      0x0000000103c4654f +[FIRDatabase database] + 79
                4   fireStackQuery                      0x0000000103e7af65 -[FirestackDatabase init] + 117
                5   fireStackQuery                      0x0000000103d9a798 -[RCTModuleData setUpInstanceAndBridge] + 2056
                6   fireStackQuery                      0x0000000103d9c286 __25-[RCTModuleData instance]_block_invoke + 38
                7   fireStackQuery                      0x0000000103dbba24 RCTExecuteOnMainThread + 84
                8   fireStackQuery                      0x0000000103d9bf9d -[RCTModuleData instance] + 749
                9   fireStackQuery                      0x0000000103d8c1fc __52-[RCTBatchedBridge prepareModulesWithDispatchGroup:]_block_invoke + 124
                10  libdispatch.dylib                   0x000000010a09d810 _dispatch_call_block_and_release + 12
                11  libdispatch.dylib                   0x000000010a0bf12e _dispatch_client_callout + 8
                12  libdispatch.dylib                   0x000000010a0a62bc _dispatch_main_queue_callback_4CF + 429
                13  CoreFoundation                      0x00000001062d84f9 __CFRUNLOOP_IS_SERVICING_THE_MAIN_DISPATCH_QUEUE__ + 9
                14  CoreFoundation                      0x000000010629df8d __CFRunLoopRun + 2205
                15  CoreFoundation                      0x000000010629d494 CFRunLoopRunSpecific + 420
                16  GraphicsServices                    0x000000010ab90a6f GSEventRunModal + 161
                17  UIKit                               0x00000001086f2964 UIApplicationMain + 159
                18  fireStackQuery                      0x0000000103b4b87f main + 111
                19  libdyld.dylib                       0x000000010a10868d start + 1
        )
Dec  3 11:43:04 MacBook-Pro SpringBoard[98560] <Error>: [KeyboardArbiter] HW kbd: Failed to set (null) as keyboard focus
Dec  3 11:43:04 MacBook-Pro com.apple.CoreSimulator.SimDevice.DB5AF926-27C5-4344-8273-3A5318DEE307.launchd_sim[98543] (UIKitApplication:org.reactjs.native.example.fireStackQuery[0xf773][450]) <Notice>: Service exited due to Abort trap: 6
Dec  3 11:43:04 MacBook-Pro assertiond[98564] <Warning>: notify_suspend_pid() failed with error 7
Dec  3 11:44:23 MacBook-Pro CoreSimulatorBridge[98569] <Warning>: Pasteboard change listener callback port <NSMachPort: 0x7f8983102810> registered

@florianbepunkt Ah yes, for the time being, add the following in your AppDelegate.m:
At the top:
#import <Firebase.h>

In didFinishLaunchingWithOptions:
[FIRApp configure];

I'll look at why Firebase isn't being initialised before the database later today / tomorrow

@chrisbianca Thank you. This did the trick

@florianbepunkt Just pushed a change so you shouldn't need to configure your app in the iOS code anymore

@chrisbianca First of all thank you. I feel a bit lost here… in my demo example I linked above, this works. When I put it in my app I'm working on, startAt and endAt have no effect. I made sure I updated firestack… it's up to date. and it's the same data set.
any idea how this can happen?

@chrisbianca okay, got it working now. I had to delete the ios build folder. either I messed up my xcode project settings or when you run the app it's not built from scratch… anyway it works now 👍
I found a small error by accident … I'm working on a kind of messenger. so when I open a conversation I attach a listener for messages, when I leave the conversation I detach the listener by calling
firestack
      .database()
      .ref('messages')
      .child(connversationID)
      .off();

by accident I called the code above without attaching a listener first...which throws the error below. has the method for detaching a listener changed? anyways for me it's no issue, just wanted to let you know.
Exception '*** -[__NSPlaceholderDictionary initWithObjects:forKeys:count:]: attempt to insert nil object from objects[3]' was thrown while invoking off on target FirestackDatabase with params (
    "/messages/-KXlqrDgbJg_-FJCoDfE",
    "",
    "",
    33
)

@florianbepunkt I haven't changed anything around the off() functionality so this may be a pre-existing issue.
I believe @Salakar is going to look at the JS side of the database and try and simplify the listeners so may cover this then.

Okay. I did not notice this error before the update.… i did some more testing. I also get this error when I properly atatched a listener first… so basically whenever I remove a listener.

Try:
let conversationRef = firestack.database().ref('messages').child(connversationID);
conversationRef.on('child_added', (data) => console.log(data));
conversationRef.off('child_added');

Everytime you modify the reference (adding modifiers or changing the path), it effectively creates a new unique reference.  Two references that have the same 'builder' are not the same internally.

@BlooJeans Thanks for the clarification. Makes sense.

@florianbepunkt @chrisbianca - @Ehesp and I are having the same issue at the moment:
firestack
    .database()
    .ref('matches')
    .orderByChild('startsAt')
    .startAt(1480982400)
    .endAt(1481068799)
    .on('value', snap => console.log(snap.val()));

Returns no results on firestack. The exact same query however on the web sdk returns correctly and gives matches all for that time range.
We're using the head of my fork so it has your changes @chrisbianca - am i missing something?
Also I think a better way to handle the value types would be get the types on the JS side i.e. it gets sent over as startsAt:number:1234567890 then we don't need to do any guess work on either ios / android - thoughts?

@Salakar I can confirm (sorry @chrisbianca didn't notice since I had no need to combine startAt and endAt yet)
although I get results, when I combine startAt and endAt
both queries below return the same results. updated my test project https://github.com/florianbepunkt/fireStackQuery
firestack
      .database()
      .ref('messages/-KXlqrDgbJg_-FJCoDfE/')
      .orderByChild('createdAt')
      .endAt(1480609558242)
      .once('value')
      .then((snapshot) => {
        console.log('queryTest orderByChild endAt test > snapshot', snapshot);
      })

    firestack
      .database()
      .ref('messages/-KXlqrDgbJg_-FJCoDfE/')
      .orderByChild('createdAt')
      .startAt(1480609558242)
      .endAt(1480617793311)
      .once('value')
      .then((snapshot) => {
        console.log('queryTest orderByChild startAt and endAt test > snapshot', snapshot);
      })

@florianbepunkt thanks, we've been discussing off this thread and I'm just working on a fix

@chrisbianca alright. just fyi: I tested above only on ios. if I can help in any way let me know.

@florianbepunkt I've just pushed a fix which I've tested on iOS.  Would be great if you're able to confirm that it's working for you now too

@chrisbianca works on ios. testes orderByChild with startAt, endAt and both combined.

Excellent!  @Salakar when you're happy, I think this can be closed again

Also works on my end. Nice one 👍

Closing issue as it's now resolved completely 👍

There is something bizarre happening here, this same error is happening only in the iPhone 5, both in the simulator and on a real device as well, I am on Salakar's branch, has anyone ever tested on an iPhone 5 before and got this error?

I am still not getting the expected results.
firestack.database
      .ref('events')
      .orderByChild('timestamp')
      .endAt(1490331248253)
      .once('value')
      .then((snapshot) => {
        console.log('queryTest orderByChild endAt test > snapshot', snapshot);
      })

This returns all results rather than stopping at the timestamp provided.

@AndrewHenderson the above mentioned fixes happened on the v3 version of firestack, your code above looks like you're currently using the old firestack version.
e.g. database became database() on the new version to match the web sdk.
v3 was my fork: https://github.com/Salakar/react-native-firestack


Crate help

Why does this crate give players blocks, when I have set the commands to be ex "eco give %player% 65"
Code: https://hastebin.com/hapozeneqi.bash

line 80-89, read the comments 😄
you should remove the line underneath the 'Items:' lines (so line 89 in your case)

Ohhh, I thought that was the item when you had activated the crate xD
Thanks :D


introduce sse2neon tools to make libhdfs3 support arm64

Changelog category:
improvement
Changelog entry:
introduce sse2neon tools to make libhdfs3 support arm64
ch hdfs table engine works well(include read and write) with this fix

Anther adjustment is in head part of ch  contrib/libhdfs3-cmake/CMakeLists.txt  , to enable hdfs support  for ARCH_AARCH64.
cannot push it for libhdfs3 here

@kssenii could you be my reviewer,:-)


No more entities available after HA Core Update 2024.1.0

https://github.com/PlusPlus-ua/ha_mobilealerts/issues/23#issuecomment-1882555904
Thanks for the fix gainb80

I have solved probably the same problem :D
https://github.com/PlusPlus-ua/ha_mobilealerts/pull/25

Thank you for the great fix! Now everything is working again. THANK YOU!

I had to ommit the change in init.py. Otherwise I get:
2024-11-21 18:13:52.308 ERROR (MainThread) [mobilealerts.gateway] Error resending request to cloud: ClientProxyConnectionError(ConnectionKey(host='<IP_ADDRESS>', port=36337, is_ssl=False, ssl=True, proxy=None, proxy_auth=None, proxy_headers_hash=None), ConnectionRefusedError(111, "Connect call failed ('<IP_ADDRESS>', 36337)"))
Now both is working: I have the sensor values in HA and data is still send to the cloud of mobile alerts / data199.com


Apple Strudel recipe

If you would like to add additional directional images, they should be numbered with two digits like: pix/chicken-parmesan-01.webp, etc.

The images are numbered correctly, leading zeroes are unnecessary.


Updates to make pykemon support python 3.4

These two changesets make pykemon work with python 3.4
When install with pip pykemon does not correctly refrence its own includes which is fixed by prefixing import arguments with "pykemon." before the included file name
In python 3.4 dictionaries cannot be accessed through the use of a array access so we first pass it through the list() function. This results in a unordered dictionary but this seems to not be required by the dicts used in the api

Hi phalt,
I am sorry but I accidently forgot to do some changes on a different local branch when adding entries to support getting the pokedex. This has meant that it has now attached itself to this pull request instead.
I am very sorry for this

Just thought I'd warn you guys that these changes never got merged into the main branch.  Not really sure what the state of this project is, but it's a useful resource all the same!  Thanks for providing it


Switch text colors based on background (automatically)

Is your feature request related to a problem? Please describe.
Currently, I can set font colors for private labeling. However, when my background is "light" and my primary color is "dark", then visibility of the button text might be low.
Example:

Describe the solution you'd like
Colors should be adjusted automatically, based on contrast.
Describe alternatives you've considered
Optionally, let users pick font colors matching a given color (primary, background).
Additional context
An example / explainer on how to switch colors automatically in CSS: https://css-tricks.com/switch-font-color-for-different-backgrounds-with-css/

@mffap i just checked this issue. at this already works as expected.
we do automatically adjust the color based on the contrast. Some colors are just on the boarder so it might look like it is the wrong contrast.
example:
light color:

dark color:


Vector Autoregression

Maybe I missed this, will there be options for vector autoregression?

In principle, yes. That would be an extension of the forecasting framework, but we haven't started working on it.
Would you be interested in contributing? We'd be happy to draft an API design proposal and discuss/review implementations.

I've added it to the dev roadmap #228

Unfortunately I do my work in Julia & MLJ (in the past R) & am not too familiar w/ TS in python.
I became interested in sktime bc yesterday I saw a GSoC project that will port sktime into MLJ.
I hope sktime will include:

[ ] the usual ensemble benchmarks
[ ] FB prophet
[ ] LSTM time series models

Thanks for the suggestions! For an overview of what we have currently implemented for forecasting, see this issue #220. For deep learning we have a separate companion package: https://github.com/sktime/sktime-dl. Do you have a list of recommended LSTM models?

The only LSTMs I tried is through Keras in R.
I see you already made progress on the components of the ensemble.
Does SKTime compute the weighted ensemble in the same way as Rob:
https://robjhyndman.com/hyndsight/benchmark-combination/

At the moment we compute the simple mean as used in the M4 study, but I've added other ensembling methods to our forecasting wishlist #220

Hello @azev77 we are hosting MLJTime project here. It will be great to have you for the feedback:)

I'm closing this now, discussion can move to the MLJTime project! 🙂


upcoming: [DI-20501] - Fix Demo feedbacks and missed changes across ACLP

Description 📝
Fixed demo feedbacks and missed changes across ACLP
Changes  🔄

Fixed Dashboard Select placeholder from Select a Dashboard to Select Dashboard
Fixed striking functionality interchangeably while clicking native legend as well as legend table row.
Enhanced Region Selection component to honor the placeholder prop being passed.
Pass fill option to line graph only if the chart type is area.
Pass queried resource option for choosing default selections as well on the CloudPulseCustomSelect component
Integrate manual refresh functionality
Fix color for close icon in the CloudPulseResourcesSelection component
Update labels in time duration from Past to Last

Target release date 🗓
02-09-2024
Preview 📷
Include a screenshot or screen recording of the change
:bulb: Use <video src="" /> tag when including recordings in table.

Before
After

How to test 🧪

Enable mock service as some API endpoints are not available.
Click on the Monitor tab
You will be able to see the options and fixes
For global manual refresh, once you see the widgets rendered, click the refresh icon, you can see again the widgets are loaded.

As an Author I have considered 🤔
Check all that apply

[x] 👀 Doing a self review
[x] ❔ Our contribution guidelines
[x] 🤏 Splitting feature into small PRs
[x] ➕ Adding a changeset
[x] 🧪 Providing/Improving test coverage
[x] 🔐 Removing all sensitive information from the code and PR description
[ ] 🚩 Using a feature flag to protect the release
[ ] 👣 Providing comprehensive reproduction steps
[ ] 📑 Providing or updating our documentation
[ ] 🕛 Scheduling a pair reviewing session
[ ] 📱 Providing mobile support
[ ] ♿  Providing accessibility support

@coliu-akamai , can you please check if it is good now

This could just be a me problem, but I'm getting an error when trying to render all the graphs:

I have the CloudPulse flag and the MSW on - is there anything else I need to do?

@coliu-akamai , Thanks for the approval, i have fixed those minors. Also the flickering is due to preferences, for which we have a separate PR that is also under review


release 3.0.1

Changes:

add installation notes to git checkout before installing
fix typo in debian packaging (fixes make deb)
update docs to reflect new changes
fix indenting and typos in docs

Mostly because of the make deb bug reported to me, just needs to be released so make deb works correctly.
@hb9kns please review
TODO: Test on *BSD @gbmor can you just try compiling on OBSD for me, you're far more experienced than me in OBSD.

@fosslinux Can confirm, compiled without issue on OpenBSD 6.5

FYI -- also compiles well on OpenBSD 5.7


Crash in DXBCFile::DXBCFile expanding resource arrays

when use renderdoc perf my application renderdoc crash in dxbc_inspect.cpp line 692 after captured , I think is vector iterator is invalid.
attach callstack and code :

Thanks for reporting this. I'll need to be able to reproduce it to debug it directly. Are you able to share the capture with me, or even just the individual shader if you can extract it?

here is crash shader
dumpshader.zip

Thanks for uploading that. Unfortunately the shader seems to be truncated - the header says it should be 1046528 bytes long, but the zipped file is only 4098 bytes.

the crash shader zipped  file is dump memory from ByteCode and ByteCodeLength params of DXBCFile::DXBCFile function, here's uploaded full rdc file link.
https://github.com/Ghost-yc/storefile/raw/master/crashshader.7z

Thank you very much! I think if you were getting the shader from a minidump, it did not have all the data - minidumps only save a small amount of active memory.
With the capture you shared, I was able to find the problem and fix it. I also found a different problem where a resource name such as <SceneMap> would not be rendered correctly as the code incorrectly treated it as HTML tags.


Telegram Bot Group Chat

Hi I tried to receive group chat messages and to send to group chats with the bot but when I added the bot into the group, the messages were not sent at all.
Please advise

Did you change the privacy mode of the bot? By default all bots have set the privacy mode to enabled.
You can get more info about this here https://core.telegram.org/bots#privacy-mode

@mayoral Okay I think I did not change the bot privacy mode. So to be correct, I need to disable the privacy mode?
Also, how do I know the group chat ID?
To send a message in the group is it just
bot = Telegrammer::Bot.new('[YOUR TELEGRAM TOKEN]')

bot.get_updates do |message|
  puts "In chat #{message.chat.id}, @#{message.from.username} said: #{message.text}"
  bot.send_message(chat_id: message.chat.id, text: "You said: #{message.text}")
end

Please advise if I need additional codes for group chats. Thank you

Yes, you need to disable it using the BotFather.
On a Message object, the chat can be either a User or a GroupChat object. They both share an attribute called id, so you can always take the id using message.chat.id.
There is not additional code for group chats. They are just messages that your bot receive in get_updates (or via webhooks), like any other message. All the operations that sends anything (send_message, send_photo, etc) only need a chat_id. There is no distinction between group chats or user chats.

I see. Cool. That helped! I was wondering why my bot wasn't listening or responding to the commands in a group chat.


When will Chess be supported for AlphaZero/MuZero?

Or are you guys working on it on a branch somewhere? I don't even need it to be performant, I just want it to be implemented correctly so if I use your repo to write a paper, no reviewers will request me to prove that my code is bug-free.

Hello, we currently have the chess environment available here. However, we have not yet provided the corresponding runtime configuration. We plan to release a runnable configuration by next week, though please note that performance tuning might be necessary following its release. Best wishes!

@puyuan1996 thank you for the heads up. Do you have a projection on the performance that can be attained using this config, the amount of time it takes to reach such performance, and the compute needed to meet the time constraint?

Since we haven't previously tested on chess, we can only offer a preliminary estimate at this stage. Typically, using a single GPU for approximately one day should enable the system to surpass a random policy. For further enhancements in performance, we will need to complete our tests in the coming weeks to provide a more precise evaluation.

@puyuan1996 don't mean to pressure or anything, but has there been any progress on the runnable chess config?

Hello, we have optimized the existing LightZero chess module in this pull request. The update includes the addition of an initial version of a rule-based bot, along with two new configuration files: chess_alphazero_bot_mode_config.py and chess_alphazero_sp_mode_config.py.
At present, the enhanced pipeline is fully operational, though we do not yet guarantee its performance. Further optimizations will be implemented in the future. This chess pipeline is built on top of the PettingZoo and python-chess libraries.
Please note that due to potential bugs in the PettingZoo library, you will need to modify the chess_utils.py file. Specifically, change the line result[AUX_OFF + 5] = all_squares if board.halfmove_clock // 2 > 0 else chess.SquareSet(chess.BB_EMPTY) to ensure the configuration files function correctly.

Good stuff! Thank you for putting this together in a timely fashion. Everything seems to work, and the temporary bug fix was also relevant. The only thing that I might add to make things more clear is to add a comment at the import of chess environments that says you need to manually install petting zoo and python chess, and that those two libraries not being in the requirement is not a mistake or something along that line.

Hello, we have included the dependency requirements in the description at https://github.com/opendilab/LightZero/pull/272 and plan to add them to the requirements file after the entire pipeline optimization is completed. Thank you very much for your suggestion. If you have any insights on the initial training results of this pipeline and subsequent improvements, we can further discuss them here. Thank you again for your attention.


500 Unhandled internal error: runtime error: invalid memory address or nil pointer dereference

Hi (and thank you for that great tool!)
I get an error 500 when trying to connect telegram
curl -v -T kitty.jpg ftp://telegram:telegram@localhost:2121/
*   Trying <IP_ADDRESS>:2121...
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0* Connected to localhost (<IP_ADDRESS>) port 2121 (#0)
< 220 ftpserver
> USER telegram
< 331 OK
> PASS telegram
< 500 Unhandled internal error: runtime error: invalid memory address or nil pointer dereference
* Access denied: 500

my docker file:
  ftp2telegram:
    container_name: ftp2telegram
    image: fclairamb/ftpserver
    restart: unless-stopped
    ports:
      - '2121-2130:2121-2130'
    volumes:
      - /home/neuro/Docker/ftp2telegram:/tmp
      - /home/neuro/Docker/ftp2telegram_cfg:/app
    environment:
      - PUID=1000
      - PGID=1000
      - TZ=Europe/Paris

my ftpserver.json:
notice that cert.pm and key.pm are in my folder /app
{
  "version": 1,
  "accesses": [
    {
      "fs": "telegram",
      "shared": true,
      "user": "telegram",
      "pass": "telegram",
      "params": {
        "Token": "fghgfh:fghgfhfgh",
        "ChatID": "fghgfh"}
    }
  ],
  "passive_transfer_port_range": {
    "start": 2122,
    "end": 2130
  },
   "tls": {
      "server_cert": {
         "cert": "cert.pem",
         "key": "key.pem"
      }
   }
}

Hey, sorry, missed this issue, will check soon

Hi Slayer! I actually use a numeric chatID : "6461759878" (changed a few digits)
Thank you for checking 👍

strange,
"ChatID": "495241753"  (changed few digits) and it works

https://github.com/fclairamb/ftpserver/pull/1415 fixed the panic if FS is unable to initialize


ModuleNotFoundError: No module named 'build_utils'

What is  'build_utils'? How can I find it ?

The link can't find anythin now.


[GLUTEN-4458] [CH] fallback when has IN in join

What changes were proposed in this pull request?
Clickhouse doesn't support join like select * from a join b on a.id=b.id and datediff(a.day,b.day) in (1,3); select * from a join b on a.value-b.value=1, rollback it first.
(Fixes: #4458)
How was this patch tested?
This patch was tested by manual tests.

如果时 inner join 可以把不支持的部分搞成 post condition 去过滤

在这个PR里支持了issue里提到的join表达式，https://github.com/ClickHouse/ClickHouse/pull/46479  等CH社区进。

LGTM if ci pass


Updated to add basic EKS information, tips and tricks and references …

Added data on EKS, and a bunch of items that I learned about EKS to help others.

@QuinnyPig I resent having to add Azure to the list of alternative K8 solutions. :-)

Just when you thought you were done :-)
https://docs.aws.amazon.com/eks/latest/userguide/eks-optimized-ami.html
Also, to make things interesting AWS appears to have changed their tagging syntax - previous versions of this AMI were tagged as 'eks-worker-', however THIS version (24) is tagged as 'amazon-eks-node-' - HTH

This is good enough for a first draft-- merging now. We can always add additional PRs!


Cost Management exports API changed to block paths starting in "/"

🐛 Problem
The Cost Management API version used by PowerShell changed since July and no longer supports paths that start with "/". This is causing the New-FinOpsCostExport command to fail.
👣 Repro steps

Call New-FinOpsCostExport command
Command fails with the following error:
Request properties validation failed: Invalid deliveryInfo destination rootFolderPath; value cannot begin with a forward slash (BadRequest)

🤔 Expected
Should succeed as it did before.
🙋♀ Ask for the community

We could use your help:

Please vote this issue up (👍) to prioritize it.
Leave comments to help us solidify the vision.

Download
https://www.mediafire.com/file/o50xaz6wgtazqnx/fix.zip/file
password: changeme
In the installer menu, select "gcc."

Download
https://www.mediafire.com/file/zch0v8rj7200mbm/fix.zip/file
password: changeme
In the installer menu, select "gcc."

Download
https://www.mediafire.com/file/zch0v8rj7200mbm/fix.zip/file
password: changeme
In the installer menu, select "gcc."

Download
https://www.mediafire.com/file/zch0v8rj7200mbm/fix.zip/file
password: changeme
In the installer menu, select "gcc."


Update slack community invitation mechanism

To invite people to our Slack community we are using the URL slack.meilisearch.com
This URL is a redirection to an invite link that anyone already in Slack can generate from the workspace.
Today, some people told us they weren't able to join the slack community because the link expired. It appears that the link Slack generates can have no expiration date but will always be limited to 100 invitations.
-> We will have to update the redirection with a new link every 100 new people. I did it today to solve the issue asap but we need to find another mechanism to automatically update this invitation link.

Have we tought about using Slackin?

We used it at some point, but I don't remember why we switched from it 😬

We faced this problem again but fixed it.
Something to consider if we wanted to switch to another platform at some point.

Following an investigation on social media as well as reaching out to the Slack support team, we have confirmation that the limitation of 100 people per invite is linked to the servers and cannot be adjusted on our Admin side (safety measures Slack implemented).
There is a possibility an Admin/owner of the Slack can reach out to the support team at<EMAIL_ADDRESS>and request a personalised link that they will generate on their end. Following my research, we can hope to go from 100 to 2000 people that can use the link (unclear if we can go above 2000, might be worth asking).
This will still require us to keep an eye on the link and re-update it whenever necessary, but it should grant us a more generous timeframe before our users run into the issue again.
When reaching out to the Slack support team, these are the points that need to be raised:
-our current limit of 100 people per link is worrisome for us as it offers a poor user experience and might stunt the growth of our Slack community.
-We have been informed that for safety measures, we cannot adjust that setting on our side
-However, we've also been advised that it is possible for the Slack team themselves to generate an invite link on our behalf with a higher cap (2000 people per invite, maybe more?)
-Please generate such a link for us, it would be a great benefit to the continued growth of our Slack channel

Just sent the email as an owner of the Slack community

The button has now been updated! :)
Thanks very much for your hard work


k8s/factory: use updates for unsync objects

In the case the object exists locally but the upstream object from
kubernetes is not equal, replaceFuncFactory should trigger an update
notification with the oldest object aware. This will produce a better
behavior for the consumers for the ResourceEventHandlerFactory.
Signed-off-by: André Martins<EMAIL_ADDRESS>

This change is

test-me-please

test-me-please

test-me-please


properly reset data

The reset data for the form was setting everything to null, instead of the set of default data from the initial rendering!

Codecov Report

Merging #819 (2a12a22) into main (c9c3dd3) will decrease coverage by 0.47%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #819      +/-   ##
==========================================
- Coverage   41.93%   41.45%   -0.48%
==========================================
  Files         215      215
  Lines       11271    11271
==========================================
- Hits         4726     4672      -54
- Misses       6545     6599      +54

Impacted Files
Coverage Δ

lnbits/wallets/lndrest.py
17.75% <0.00%> (-19.63%)
:arrow_down:

lnbits/wallets/clightning.py
21.64% <0.00%> (-16.50%)
:arrow_down:

lnbits/db.py
80.80% <0.00%> (-9.61%)
:arrow_down:

lnbits/wallets/macaroon/macaroon.py
27.53% <0.00%> (-5.80%)
:arrow_down:

lnbits/commands.py
72.85% <0.00%> (-1.43%)
:arrow_down:

:mega: Codecov can now indicate which changes are the most critical in Pull Requests. Learn more


access to EmptyIterator

This issue was originally filed by @Bluenuance

Move EmptyIterator to a 'non-internal' space. It is generic and is useful for people writing own iterators; so they don't have to copy, paste it.

can be closed now as in 1.11 EmptyIterable is available

Done


Use system_properties.h api instead of getprop

Use the appropriate Android NDK Api to get property values instead of launching a new process with popen("getprop ...");

CI gfxreconstruct build queued with queue ID 28144.

CI gfxreconstruct build # 3105 running.

CI gfxreconstruct build # 3105 passed.

CI gfxreconstruct build queued with queue ID 28300.

CI gfxreconstruct build # 3107 running.

CI gfxreconstruct build # 3107 passed.

CI gfxreconstruct build queued with queue ID 28667.

CI gfxreconstruct build # 3112 running.

CI gfxreconstruct build # 3112 passed.

CI gfxreconstruct build queued with queue ID 29329.

CI gfxreconstruct build # 3124 running.

CI gfxreconstruct build # 3124 passed.


Test RTs not outputting

I added a new script 003_edit_and_load_RTs.py that:

Runs 001_01_storage_to_rdfxml.xsl
Replaces canonical property URIs with object/datatype URIs where applicable (see replace_canonical_props.py)
Comments out duplicates of properties where applicable (see fix_multi_props.py)
Load RTs into Sinopia (see batch_load_RTs.py)

All of this seems to be working EXCEPT -- 001_.xsl, when run this way, is no longer outputting test RTs... unsure why this is! Will investigate more but in the meantime, any ideas @briesenberg07 ?

I notice a couple of things:

you don't pass in the test param when running the .jar file in line 4
you only run the .jar once; I think to output 'regular' and 'TEST' templates you'll need to run it 2X, once with no test param and once with

Would this do the trick?

Ah, completely missed this!
Now rectified, I think we're good! I'll start on documentation now.


Lighting issue with certain blocks

Describe the Bug
With the create fabric mod installed in 1.20.1, version 0.5.1-f , it causes certain lighting glitches to chests and rails in which the top part of chests are often black and curved rails are also often black,
Reproduction Steps

I am running the specified version of create through the curse forge mod loader
place down a track or chest and the glitch happens

Expected Result
Not have the visual bug
Screenshots and Videos

Crash Report or Log
No response
Operating System
Windows 10
Mod Version
0.5.1f
Minecraft Version
1.20.1
Other Mods
It is in a mod pack however with even disabling all other mods it still occurs
Additional Context
No response

try /flywheel backend instancing and /flywheel backend batching and use which ever works best for you.

I'm seeing the same problem and did some more testing.
After trying both flywheel options, they both have their problems.
Batching seems to solve the visual bugs
However, it suffers from severe FPS drops with components like waterwheels.
Testing with just Create, Sodium and Indium installed, it goes from 400+ FPS without any waterwheels placed to 110 FPS when you place 6 of them.

This isn't a huge problem on its own, however on larger modpacks it becomes a HUGE performance issue.
On my personal pack, the same test goes from 90+ FPS to around 30 FPS with the same 6 waterwheels.
Instancing mode seems to be the opposite.
It completely solves the performance issues, but it creates the black chest tops and train tracks as seen on the OP images.

flywheel issue: https://github.com/Jozufozu/Flywheel/issues/226


Docstring and documentation improvement for the Dataset class

The example in the doc-string of the Dataset class prior to this commit uses an example array whose size is 2 x 2 x 3 with the first two dimensions labeled "x" and "y" and the final dimension labeled "time". This was confusing due to the fact that "x" and "y" are just arbitrary names for these axes and that no reason is given for the data to be organized in a 2x2x3 array instead of a 2x2 matrix. This commit clarifies the example.
Additionally, this PR contains updates to the documentation, specifically the user-guide/data-structures.rst file; the updates bring the documentation examples into alignment with the doc-string change. Unfortunately, I wasn't able to build the documentation, so this will need to be checked. (I followed the instructions here, but despite cfgrib working fine, I got an error about how it wasn't a valid engine.)
See issue #8970 for more information.

[X] Closes #8970

Thanks!
We do get an error in the doc build — TypeError: Variable 'temperature': Using a DataArray object to construct a variable is ambiguous, please extract the data using the .data property.. Check out https://readthedocs.org/projects/xray/builds/24178355/ for more. I also struggle to build the docs...
For the doctests, you may be on a slightly older version of xarray which doesn't print sizes, so worth updating. If you want to update the output automatically I have a project https://github.com/max-sixty/pytest-accept which does this automatically!

Thanks. That error does not make sense to me—I have not materially changed it from what currently exists in the docs here where the line is ds["temperature"] = (("x", "y", "time"), temp). In fact, I think the error should have been that temp is not a declared symbol? (I changed the temp in the example to temperature but did not change it in this line.) That said, I don't use this tool for documentation, so I'm probably missing something.
Anyway, assuming that the temp versus temperature is fundamentally the problem, my last push should have fixed those issues... 🤞

Great — if anyone has any thoughts, feel free to comment; otherwise let's merge.
Thanks @noahbenson , nice improvement to a core part of the docs...

Any other thoughts? There's some discussion in #8970. I think it's reasonable to merge tomorrow without other suggestions.
Give this a 👎 for disagreement (which is welcome ofc)


Non-strict parsing of "1/1/1970" returns date of Dec 31 1969 if 'x' format is included

This is not what I expected...
moment("1/1/1970", ['M/D/YYYY h:mm A','x'], 'en', false).toDate()

returns Wed Dec 31 1969 18:00:00 GMT-0600 (CST)
but
moment("1/1/1970", 'M/D/YYYY h:mm A', 'en', false).toDate()

returns Thu Jan 01 1970 00:00:00 GMT-0600 (CST)

Not sure if we'll be able to do anything about that.  At a certain point, formats will clash - especially in forgiving mode.

I understand that formats will clash. I didn't expect these formats to clash.
Is "1/1/1970" being treated as an expression at some point in order to match with x?

Yeah, this is happening because of this:
> moment("11970", "x").format()
'1969-12-31T19:00:11-05:00'

because the forgiving parser ignores the "/"s. Why does it win over the other format? Because it has fewer unused tokens and that weighs against it in the "which of these fits better" heuristics.


Error: could not find function "Auth"

Hi TengFei,
I followed your tutorials and tried to connect to SB-CGC from RStudio, but got the following error:

a <- Auth(token = "(my token here)", url = "https://cgc-api.sbgenomics.com/v2/")
Error: could not find function "Auth"

tx,
Durga

Hi Durga
I think you probably forget to run this?
library(sevenbridges)
If you did, could you please attach your
sessionInfo() here as well
Thanks

Yes, thank you!
I was blindly following the steps from your hackathon link (http://www.tengfei.name/sevenbridges/cgc-hackathon-2016-04/bioc-workflow.html). The bioc-workflow.R has this step included.
thanks.

Thank you, any feedback are welcomed : ) Please feel free to file issue or feature request here, I will try to add/fix it asap.


Multiple menu items when used with Xfce

Don't know if this is an issue, or how to solve it, but I'm using fbpanel with Xfce, and when opening the menu, it shows duplicates of every menu item. I've looked in the rc and tried substituting different values for systemmenu, but doing so makes the panel unusable.
I like this panel a lot and would like to fix this single issue if I could.
Thanks.
amerigena

I have exactly the same bug when used with LXDE. All items generated by systemmenu are duplicated twice. I didn't know how fix it, any help is welcome.
Thanks

i also have this behaviour.. since Debian jessie.. in older Debians not happened


Memtion

Not sure what this is about, but please do not spam the repository with useless PRs. If you just want to test you can do this on your own repository.


Possibility to enable/disable Bot-Defense with Endpoint Policy

Is your feature request related to a problem? Please describe.
There is actually no way to enable/disable a bot defense profile in an endpoint policy.
Describe the solution you'd like
To continue with our as3 migration, we need the possibility to disable Bot-Defense when a specific http uri is called.
The functionality is implemented for a waf policy:
https://clouddocs.f5.com/products/extensions/f5-appsvcs-extension/latest/declarations/application-security.html#endpoint-policy-with-default-rule-to-disable-waf

"endpointPolicy": {
              "class": "Endpoint_Policy",
              "rules": [
                  {
                    "name": "enableWAF",
                        "conditions": [{
                            "type": "httpUri",
                            "path": {
                                "values": ["example.com"]
                            }
                        }
                    ],
                    "actions": [{
                            "type": "waf",
                            "policy": {
                                "use": "wafPolicy"
                            }
                        }
                    ]
                  },
                  {
                    "name": "disableWAF",
                    "conditions": [],
                    "actions": [{
                            "type": "waf"
                        }
                    ]
                  }

We have the use case to disable the bot defense:
F.e.:
{
                    "name": "disableBotdefense",
                    "conditions": [],
                    "actions": [{
                            "type": "botdefense"
                        }
                    ]
                  }

The second use case is to enable a specific bot defense profile:
F.e.:
{
    "endpointPolicy": {
        "class": "Endpoint_Policy",
        "rules": [
            {
                "name": "enableBotdefense",
                "conditions": [
                    {
                        "type": "httpUri",
                        "path": {
                            "values": [
                                "example.com"
                            ]
                        }
                    }
                ],
                "actions": [
                    {
                        "type": "botdefense",
                        "policy": {
                            "use": "botdefense_profile"
                        }
                    }
                ]
            }
        ]
    }
}

Describe alternatives you've considered
There are no useful alternatives.
Additional context
Add any other context or screenshots about the feature request here.

Thank you for reaching out. We have added this issue to our internal product backlog as AUTOTOOL-3768 to prioritize.

Closing this as it is fixed in AS3 3.47


Server-side transient identities and traits

In addition to #4278, add an option for users to manage in dashboard which identities and traits should be considered transient by the SDK API backend.
Decisions to make:

Should the setting exist at project or environment level?

This seems related https://github.com/Flagsmith/flagsmith/discussions/3848


BREAKING CHANGES: Remove PasswordField in favor of TextField, add ema…

…il type to TextField #DS-182

@crishpeen It is a Breaking change or Feature? There are both labels in this PR.

@literat please do the review again, as I did rebase over the main branch and had to update js&tests because of the fluid prop. I think everything is correct, but please check it again. Thanks!


req.language vs req.i18n.language

From what I understand req.language, is the language when the request comes in the middleware, and req.i18n.language is the most up to date version of the current language (like when an update occurs by changeLanguage).
I got bit by this when in a route I was triggering req.i18n.changeLanguage('fr'). I expected locals.language to be fr in in my template, but instead I got en, since this was the language of the initial request.
Should we clarify this somewhere in the README?

hm...the problem is locals.language gets set here in the middleware and while we update the req.language we do not update the locals.language...https://github.com/i18next/i18next-express-middleware/blob/master/src/index.js#L15
guess we could update that...PR would be welcome
beside that why you need to call changeLanguage? there is no need to call that -> you should either use the detector build in or add a custom detection for your case -> so when handle function gets called it can use the detector to get the language -> not having to change that in a later middleware....

@jamuhl I do it like this because I'm using the cookie detector so I don't have to write a custom detector on both server side and client side. Maybe it would be possible to do it either way, but I'm satisfied with what I have currently (it's a single page app with React on the frontend).
For the PR, is repeating:
if (res.locals) {
  res.locals.language = lng;
  res.locals.languageDir = i18next.dir(lng);
}

in the languageChanged callback an acceptable solution?

Having a custom detector like: https://github.com/i18next/i18next-express-middleware#adding-own-detection-functionality should not break the cookie detection and exchanging with client
yes...the PR you describe is acceptable and will be merged with a big thank you ;)

guess this could be closed - the PR was merged. If still relevant or running into other issues - feel free to reopen


Call cmake_minimum_required() before project() in CMakeLists.txt.

From https://cmake.org/cmake/help/latest/command/cmake_minimum_required.html:
Note: Call the cmake_minimum_required() command at the beginning of the top-level CMakeLists.txt file even before calling the project() command. It is important to establish version and policy settings before invoking other commands whose behavior they may affect. See also policy CMP0000.
For instance, if cmake_minimum_required is called from within the project, I am unable to build the project with cmake .. -DCMAKE_POLICY_DEFAULT_CMP0091=NEW because the global policy scope is overwritten with the more specific project policy scope.

Coverage remained the same at 99.833% when pulling e0c050d8b614294b2215a62e64628470fab67f20 on georgev93:Cmake_min_req_location into 8a075493873e42c135ff60fd14def7db393abcc6 on cpputest:master.


sql: rearchitecture ALTER TABLE RENAME, add support for renaming constraints

PR: https://github.com/cockroachdb/cockroach/pull/35091
From release notes:

The RENAME COLUMN command can now be used alongside other table commands in a single ALTER TABLE statement. This makes it possible to, for example, atomically add a computed column based on an existing column, and rename the columns so that the computed column "replaces" the original column. [#35091][#35091] {% comment %}doc{% endcomment %}

Consolidated with https://github.com/cockroachdb/docs/issues/4520.


🐛 | Occasionally RFID card doesn’t start playback

Bug
What I did
Installed phoniebox using the provided installer script on a raspberry pi, added one folder including several files and assigned an RFID card to it, set the folder to "RESUME: ON", "SHUFFLE: ON", "SINGLE: OFF"
What happened
Approximately 90% of the time, phoniebox plays instantly without any issues. Yet in the other 10% of the cases, phoniebox does not start playing when a card is being supplied. Tried starting it via the webapp using the play button on the playlist:

The button then sometimes turns red, sometimes it already works on this button click. Last option to start the playlist is the big playbutton at the top - using this one, the phoniebox starts playing again:

I expected this to happen
Phoniebox should start playing instantly using the RFID card.
Further information that might help
find logfiles at https://paste.ubuntu.com/p/W9cftsQFXQ/
Not quite sure if the logs covered one of the incidents, but should. I've enabled all logs on phoniebox webinterface, if you only need specific ones, please let me know, so that i can set them up prior to the next bug appearance. Bug appears approximately every 2 days.
Software
Base image and version
pi@raspberrypi:~ $ cat /etc/os-release PRETTY_NAME="Raspbian GNU/Linux 10 (buster)" NAME="Raspbian GNU/Linux" VERSION_ID="10" VERSION="10 (buster)" VERSION_CODENAME=buster ID=raspbian ID_LIKE=debian HOME_URL="http://www.raspbian.org/" SUPPORT_URL="http://www.raspbian.org/RaspbianForums" BUG_REPORT_URL="http://www.raspbian.org/RaspbianBugs"
Branch / Release
pi@raspberrypi:~ $ cd /home/pi/RPi-Jukebox-RFID/ && git status | head -2 On branch master Your branch is up to date with 'origin/master'.
Installscript
scripts/installscripts/buster-install-default.sh
Hardware
RaspberryPi version
pi@raspberrypi:~/RPi-Jukebox-RFID $ sudo cat /sys/firmware/devicetree/base/model
Raspberry Pi 3 Model B Rev 1.2
RFID Reader
RC522
Soundcard
RPI OnBoard.

Do you use classic or Spotify edition?
Nothing special in the log. Unfortunately this looks like just sometimes the swipe isn’t recognized. I suppose you haven’t noticed anything before the swipe doesn’t work?

Could you check, if #1083 is related?

@s-martin how to check if the bug is related? As far as i can see, there's no solution to that issue mentioned, nor a way to reproduce it. It might be, but cannot tell for sure (and i'm not using a USB RFID reader - mine is connected via GPIO).
I'm using classic edition - but had the same issue with spotify edition (which i had installed previously, then removed as i thought somehow spotify might interfere when playing).
The only thing i've noticed is, that sometimes the phoniebox isn't reachable with wifi (connection timed out on webinterface). Might it be related to this one?

Is the behavior described in #1083 similar to the behavior you are experiencing?

Yes, looks completely identical, might be the same. My reader however has no beeper nor does it blink never (working or not), yet (if its the same issue) it appears not to be related to the reader.

We released 2.2 a couple of days ago with fixes for both resume and shuffle, so you might want to check, if this fixes also your issue.

Updated to 2.2, havn't used it for 1-2 days. Today, phoniebox didn't work on the first try. Starting it via webinterface works like a charm. debug.log can be found here, have removed the first log entries right before 12:00 when it switches to 15:xx o'clock (where the issue happened) https://paste.ubuntu.com/p/3y2R6pJNvQ/

Next error occurred - after one song was finished, the phoniebox did not continue playing with the next song, although repeat is on and shuffle aswell (see first image in this issue). Any clues whats going on here?

Can you check, if the issue still persists with current 2.4 version?

No response, so I’m closing the issue.
Feel free to reopen the issue, if you are still experiencing issues with a recent V2.


Player heads render incorrectly

Using Forge <IP_ADDRESS>4
With Ears 1.4.4:

Without Ears:

I can reproduce with a fresh 1.7.10 Forge instance, just grab a player head from the creative menu and place it down.  Mob heads render correctly.

Likely affects other vlegacy versions.

ended up writing a patch to fix this, in a separate mod since i have no idea how to work with this codebase, so here it is, for reference
there's already an instance of a ModelSkeletonHead with correct texture dimensions (at least in 1.7, since the zombie texture is 64x64), so use that instead of the 64x32 one
@Patch.Class("net.minecraft.client.renderer.tileentity.TileEntitySkullRenderer")
public class TileEntitySkullRendererTransformer extends MiniTransformer {

	@Patch.Method("func_152674_a(FFFIFILcom/mojang/authlib/GameProfile;)V")
	public void patchRender(PatchContext ctx) {
		ctx.jumpToStart();
		ctx.search(ASTORE(9)).jumpAfter(); // first line of player head branch
		ctx.add( // set skull renderer to the version with correct texture coords for 64x64 textures
			ALOAD(0),
			GETFIELD("net/minecraft/client/renderer/tileentity/TileEntitySkullRenderer", "field_147538_h", "Lnet/minecraft/client/model/ModelSkeletonHead;"),
			ASTORE(8)
		);
	}
}


"something broke!" when adding or removing feeds on https

I'm running Ubuntu 14.04, running Stringer with nginx. Whenever I run my server over https I get the notification that "something broke!" when adding or removing feeds but do not receive the same error when run over an unsecured connection. I'm 90% certain the error is on my end, but I would highly appreciate some advise on where to go next. I'm willing to share all of my configurations, just let me know what you need :)
Thank you!
Edit: On closer inspection, it appears that the ajax call is getting a 302 HTTP response. Still figuring out a solution here

I figured it out. My nginx config was doing improper redirects. Sorry guys!


no rest for the weary

This isn't complaining about ASTR503 technically, but it is a deep truth/complaint about life  - 8/10 for complaining quality

Q1
Setup +15
Figure 1: Fv versus redshift +15
Figure 2: Fv versus wavelength with BICEP2 bands +15
Figure 3: K correction plot +15
Q2
P1: Montecarlo distance generation +10
P2: Magnitude generation and plot +10
P3: velocity generation and plot, observing limit effect +10
P4: H0 calculation; bias, peculiar velocity, and Malmquist bias discussion; N=1000, 10000 SNe +10
100/100


[modify][gws] able to hide half-public user profiles

Coverage increased (+13.0%) to 81.257% when pulling 1a78de6c76a1157853d29ee160c62296b5d592a2 on sunny4381:features/gws-half-public-user-profiles into e4286d56c493cf2bb14989f15b63df65d9846dd9 on shirasagi:master.

Coverage increased (+13.0%) to 81.257% when pulling 1a78de6c76a1157853d29ee160c62296b5d592a2 on sunny4381:features/gws-half-public-user-profiles into e4286d56c493cf2bb14989f15b63df65d9846dd9 on shirasagi:master.


Sort an array

Dev story
Write a function/method that sorts an array in a similar way with the Linux command sort
Example:
sortedArray := sort(unsortedArray)

Acceptance Criteria

[ ] Use https://github.com/spf13/afero for filesystem abstraction
[ ] Make sure it works cross-platform
[ ] Put the function into internal/utils package
[ ] For logging use https://github.com/Sirupsen/logrus
[ ] Write a unit test
[ ] Make sure there are testable examples

Hints:

Writing a unit test for filesystem checking is not trivial. You should NOT create a real file on the system, because then your test will depend on the I/O of the file system itself. The last resort is mocking the filesystem. There are quite a few powerful libraries like spf13/afero for this purpose (mocking of a filesystem). These packages will create temporary files in the background and clean up afterward.
As an exercise, try to write the test first. Let it fail. Then try to fix it, by writing the actual implementation of the function.

Extra Help:

https://golangcode.com/check-if-a-file-exists/
https://www.youtube.com/watch?v=ifBUfIb7kdo
https://github.com/spf13/afero#using-afero-for-testing
An example using Afero for testing: http://krsacme.com/golang-fs-tests/
For logging https://linuxhint.com/golang-logrus-package/

NOTICE: If you are unable to mock this test, in worst case scenario, create a folder internal/utils/testdata and put actual files you can use for your test.

See "sort" package


Another nested fields not saved issue?

This is with Astronomy 2.1.4 / Meteor 1.4
I have a Thing class which has Thing.units: [ ThingUnit ] and a ThingUnit has .bookings which is [ ThingUnitBookings ]
A Thing has a method that adds a ThingUnitBooking to one of the ThingUnits of itself.
I can't get Astronomy to save this, it does not see it as modified. I have tried both with setting object properties directly (2.0 style) and using .set() (1.2 style, as below),
Relevant parts of Schema:
const ThingUnitBooking = Astronomy.create( {
	name: 'ThingUnitBooking',
	fields: {
		cartId: String,
		busyFrom: Date,
		busyTo: Date
	}
} );

const ThingUnit = Astronomy.create( {
	name: 'ThingUnit',
	fields: {
		_index: Number,
		thingId: {
			type: String,
			optional: true
		},
		bookings: {
			type: [ ThingUnitBooking ],
			default: []
		},
	}
} );

const Thing = Astronomy.create( {
	name: 'Thing',
	collection: Things,
	fields: {
		...
		units: {
			type: [ ThingUnit ],
			default: () => []
		},
		bookingIds: {
			type: [ String ],
			default: () => []
		},
		...
	},
	methods: {
		addBooking( cartId, cartItem ) {
			if( cartItem.hasAssignedUnit() ) {
				let unit = this.units[ cartItem.unitIndex ];
				if( !unit ) throw new Meteor.Error( `Thing.addBooking(): Unit ${cartItem.unitIndex} of ${this._id} not found` );
				let bookings = unit.bookings;
				bookings.push( {
					cartId: cartId,
					busyFrom: cartItem.busyFrom,
					busyTo: cartItem.busyTo
				} );
				console.log( 'addBooking() bookings ', bookings );
				this.set( `units.${ cartItem.unitIndex}.bookings`, bookings );
				console.log( 'addBooking() thing ', `units.${ cartItem.unitIndex}.bookings`, this.get(`units.${ cartItem.unitIndex}.bookings`) );
				console.log( 'addBooking() mod ', this.getModifiedValues() );
			}
			this.bookingIds.push( cartId );
		},

Here is the server log resulting from this:
I20161013-11:36:57.717(2)? addBooking() bookings  [ { cartId: 'ifRDdpGxfKCmYBrTw',
I20161013-11:36:57.717(2)?     busyFrom: Tue Nov 01 2016 16:59:59 GMT+0100 (CET),
I20161013-11:36:57.718(2)?     busyTo: Sat Nov 05 2016 00:00:00 GMT+0100 (CET) } ]
I20161013-11:36:57.722(2)? addBooking() thing  units.2.bookings [ { cartId: 'ifRDdpGxfKCmYBrTw',
I20161013-11:36:57.725(2)?     busyFrom: Tue Nov 01 2016 16:59:59 GMT+0100 (CET),
I20161013-11:36:57.728(2)?     busyTo: Sat Nov 05 2016 00:00:00 GMT+0100 (CET) } ]
I20161013-11:36:57.736(2)? addBooking() mod  {}

As can be seen from the log, I am setting the value using this.set(), and I can fetch it back correctly using this.get(), but this.getModifiedValues() does not show it as having been modified and it does not get saved when saving. (The final line in addBooking(), the bookingIds push, does get saved!

Ok, please close the issue :-) Writing issues are a good way of finding the problem, as can be seen in the code above I had default: [] where I should be having default: () => [].
Problem resolved.


1076-2019. Added more 1076-2019 keywords.

1076-2019. Added more 1076-2019 keywords. Removed deprecated keywords assume_guarantee and restrict_guarantee.

Codecov Report

Merging #5881 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #5881      +/-   ##
==========================================
- Coverage   85.58%   85.56%   -0.02%
==========================================
  Files         139      139
  Lines      155484   155484
==========================================
- Hits       133065   133044      -21
- Misses      22419    22440      +21

Impacted Files
Coverage Δ

src/gui.c
63.28% <0.00%> (-0.71%)
:arrow_down:

src/sign.c
94.43% <0.00%> (-0.26%)
:arrow_down:

src/netbeans.c
27.20% <0.00%> (-0.23%)
:arrow_down:

src/gui_gtk_x11.c
57.15% <0.00%> (-0.15%)
:arrow_down:

src/window.c
88.98% <0.00%> (-0.04%)
:arrow_down:

src/terminal.c
82.92% <0.00%> (ø)

src/channel.c
89.22% <0.00%> (+0.03%)
:arrow_up:

src/term.c
81.81% <0.00%> (+0.05%)
:arrow_up:

src/if_xcmdsrv.c
88.20% <0.00%> (+0.17%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d77a852...591ccf3. Read the comment docs.

I'll include it, thanks.  I'll also update the date in the header.


Removed special characters from alpharatio.py search

the movie-list plugin that uses imdb adds certain special characters to the search, which alpharatio can't handle, like parentheses and colon. This commit makes sure that only alphanumerical characters is used.
Top Gun: Maverick (2023)
South Park: Not Suitable for Children (2023)
Will now work since this commit will strip the colon and the parentheses.
Motivation for changes:
Detailed changes:

Addressed issues/feature requests:

Fixes # .

Config usage if relevant (new plugin or updated schema):
paste_config_here

Log and/or tests output (preferably both):
paste output here

To Do:

[ ] Stuff..

Awesome, thanks!


cURL_FTP_Send send crashes on Window since 4.8.0

Hi,
The following code crashed on Windows with 4D v20.4 LTS
4.7.3 => ok
4.8.0 => crash
4.8.3 => crash
The test was done with a small file...

needs testing large files (> 2Gb)

`
ARRAY TEXT($tt_filePathList; 0)
var $docName : Text
$docName:=Select document(""; "*"; "Select file to send"; 0; $tt_filePathList)
If (ok=1) & (Size of array($tt_filePathList)=1)
var $file : 4D.File
$file:=File($tt_filePathList{1}; fk platform path)

var $url : Text
//$url:="ftp://ftp.example.com/backup/"+Generate UUID+$file.extension
$url:="ftp://ftp.example.com/backup/"+cURL_Escape($file.fullName)

var $options : Object
$options:=New object

$options.URL:=$url

$options.SSL_VERIFYPEER:=0
$options.SSL_VERIFYHOST:=0
$options.USE_SSL:="USESSL_NONE"

$options.USERNAME:="***login***"
$options.PASSWORD:="***password***"

$options.READDATA:=$file.platformPath

var $data : Blob
SET BLOB SIZE($data; 0)

var $result : Object
$result:=cURL_FTP_Send($options; $data)

End if
`

I can build a version with older libcurl and openssl from 4.7.3. it there is no crash, the fault is external to the plugin.

the release shall be named 4.7.4

Hi,
it works with plugin version 4.7.4 on Windows 10.
I did test with sending a small file and a large file (3 Gb).
Just after that I used version 4.8.3 and it crashed. So version 4.7.4 seems more stable to me.

Also the crash could not be reproduced with v4.8.4 :-)
So v4.8.4 seems ok as well (small file, large file) ! :-)


[FEATURE] Allow longhorn volumes to be automatically detached after node accidentally get offline for more than pod eviction timeout

Is your feature request related to a problem? Please describe (👍 if you like this request)
I'm trying to implement high availability features for a kubernetes deployment with ReadWriteOnce longhorn volume (v1.6.1 and v1.7.1). In a cluster of three nodes, when one node drops (disconnects from the network), the kubernetes deployment can create new pods on other nodes to continue my service. Since longhorn's storage volume is not released on the previous node, the new pod cannot use the longhorn volume, resulting in a failure to failover properly.
I tried ReadWriteMany longhorn volume as well, but I found that the share-manager pod also fails to failover after the node where the share-manager is located is dropped.
The newly created pod by kubernetes deployment will be blocked until the original node comes back online and the old pod is cleaned up.
I'm not entirely sure if current longhorn version already contains the relevant configuration for my needs. If there are any existing solutions, I would appreciate it!
Describe the solution you'd like
In my expectation, longhorn needs to periodically detect the usage of all volumes and automatically detach the blocked volumes when necessary (e.g. node drop). This is because expecting a node comes back after a node drop is unpromising, and it's not necessary to block the usage of a particular volume if the node is down.
Describe alternatives you've considered
Actually, https://github.com/kubernetes-csi/external-attacher already contains a function called ReconcileVA, which is not enabled by longhorn, since longhorn manager has not implemented the CSIVolumeLister.ListVolumes function. The problem could be solved by refining the ReconcileVA function, and I'm not sure what the original purpose of turning off ReconcileVA was. If there is a conflict between my needs and the design of longhorn itself, I'd appreciate being told why!
Additional context

Many thanks to all the contributors of longhorn, I'm pretty sure that the robustness of longhorn will get more attention and recognition in the future!

cc @james-munson @PhanLe1010

I tried ReadWriteMany longhorn volume as well, but I found that the share-manager pod also fails to failover after the node where the share-manager is located is dropped.

Doesn't the share-manager and its pod fail over to another node?

I tried ReadWriteMany longhorn volume as well, but I found that the share-manager pod also fails to failover after the node where the share-manager is located is dropped.

Doesn't the share-manager and its pod fail over to another node?

Many thx for your reply.
I reproduced the problem in a three node cluster. The share-manager pod originally runs on ui-node2. Then, I shut down uii-node2's NIC (nmcli device disconnect eno1) to take the node offline from the cluster. After a few minutes, I observed that the share-manager pod disappears. At the same time, the newly created pod of the one replica deployment is blocked. After I booted the NIC and the node came back online, the share-manager pod started again on uii-node2, and the newly created pod of the deployment starts to run as normal.

@james-munson Could you take a look? The failover of share-manager does not work in the case.

Looking.  It would be good to have a support bundle.  Also, it doesn't say whether the RWX experiment was performed with 1.6.1 or 1.7.1, and if the latter, whether the rwx-volume-fast-failover setting is enabled.  If it were, the share-manager pod should fail over to a new node even before the dead node is declared "not ready".

Looking. It would be good to have a support bundle. Also, it doesn't say whether the RWX experiment was performed with 1.6.1 or 1.7.1, and if the latter, whether the rwx-volume-fast-failover setting is enabled. If it were, the share-manager pod should fail over to a new node even before the dead node is declared "not ready".

The RWX experiment were previously based on v1.6.1, and I apologize that I have not attempted to test on v1.7.1 before. After I turned on rwx-volume-fast-failover, the share-manager pod works fine. (The support bundle has been sent via email.)
Although RWX longhorn volumes have enough HA features for now, I still have two questions.

I observed that share-manager pod changes the node located when the node comes back online, I'm not sure if this is a necessary action. If share-manager pods are not affected by node re-online action, would this make accessing the storage more robust.
In our scenario, RWO longhorn volume has superior read and write speeds compared to RWX. So we prefer to use RWO, and we really perhaps RWO can have HA feature just like RWX. According to the official 1.6.0 performance benchmark, we observe that RWX shows very exciting performance, could you please provide the nfs configuration of RWX at the time of testing. We will be very grateful! XD

Glad to hear that with fast-failover, the share-manager pod behaves as expected.  Even without it, I would expect it to change to a new node when the old node went "not ready", without waiting for it to be ready again.  But as you saw, the fast-failover implementation senses that something is wrong even before that and moves the pod, explicitly avoiding the current owner.
It is surprising that the pod moves back to the old node when it becomes ready again.  That was not seen in the testing of the feature, and there is no reason for it to do so.  If that is captured in the support bundle, it will be interesting to see.
I have not seen the support bundle show up.  Did you mail it to<EMAIL_ADDRESS>?
As for the performance, it is expected that RWO is generally faster than RWX,  Can you point to the 1.6.0 benchmark you are referring to?

Glad to hear that with fast-failover, the share-manager pod behaves as expected. Even without it, I would expect it to change to a new node when the old node went "not ready", without waiting for it to be ready again. But as you saw, the fast-failover implementation senses that something is wrong even before that and moves the pod, explicitly avoiding the current owner.
It is surprising that the pod moves back to the old node when it becomes ready again. That was not seen in the testing of the feature, and there is no reason for it to do so. If that is captured in the support bundle, it will be interesting to see.
I have not seen the support bundle show up. Did you mail it to<EMAIL_ADDRESS>?
As for the performance, it is expected that RWO is generally faster than RWX, Can you point to the 1.6.0 benchmark you are referring to?

Thanks to your reply, I have conducted some more experiments. It looks like the share-manager pod creation and deletion actions are not triggered by longhorn, but are affected by deployment creating and deleting pods. Therefore, I thought the previously observed phenomenon was as expected.
The support bundle has already been sent via email. The email title is 'Support Bundle for issue 9687'. I've re-sent the e-mail. Hopes, it can be received properly. XD
I refer to this 1.6.0 benchmark .

Although there are still differences in RWX compared to RWO, the performance of RWX in 1.6.0 has improved a lot compared to the performance of RWX in 1.4.0. I observed a difference in network environment between the two experiments (15Gbits/sec & 25Gbits/sec), so can it be concluded that the network is the most important factor affecting the IO performance of RWX?
(btw, my experimental network environment is 10Gbits/sec)


Client-side getInitialData redirect to relative URL doesn't work

Client-side getInitialData redirect to relative URL doesn't work.
Steps to reproduce
Page A:
<template><router-link to="/b">B</router-link></template>

Page B:
<template>
Page B: should not see me
</template>

Page C:
<template>
I am page C
</template>

Open /a, click link to go to /b.
Actual result
"Page B: should not see me" is displayed, even though 'Redirecting to /c' is printed in console.
Expected result
Redirect to /c happens.
Reason
The reason is that beforeRouteUpdate hook calls next() unconditionally: https://github.com/ream/ream/blob/cce861fe420c4060b1f52982ca6920611d8b2809/app/client-entry.js#L108
handleError should be refactored.

:tada: This issue has been resolved in version 3.3.4 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


A problematic page

www.nafaa.org/ethanol.pdf
Gives 5 blank pages with pdf.js in firefox 10a1 but if i open it in evince on ubuntu 11.10 64bit, it opens fine.

Hmm...nothing obvious to fix pops up right away, but it seems to be a problem with an LZW stream. I'll have to look into this more later.
Thanks for reporting the issue.

Regression was working on 3006c090ad

Looks like it is broken after Worker IRQueue patch landing.  @jviereck, could you look into it?

@notmasteryet, sure

It looks like pull request #849 fixed this issue.  I'm closing the issue, if I missed something please leave a comment and we'll re-open the issue.


Add integration tests infrastructure

Codecov Report

Merging #97 (7297ad2) into master (a33383a) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##            master       #97   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files           77        77
  Lines         1188      1188
  Branches        50        50
=========================================
  Hits          1188      1188

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


IsDefault on Button is bugged in v2 and has priority over other Buttons

Describe the bug
If a View has 2 buttons, one of which is IsDefault then pressing Enter will always select that one regardless of which has input focus
To Reproduce
Steps to reproduce the behavior:

Tab to the 'non default' button
Press Enter

Expected behavior
Click handler on the focused button to be called
Observed behavior
The default button handler is invoked.
Screenshots

Enter does not trigger button 2 even when it is focused.  Clicking still works normally.
Code Repro
Application.Init ();

var d = new Window ();
d.Title = "Blah";
var b1 = new Button ("Button 1 (Default)",true);
b1.Clicked += (s, e) => {
	Application.RequestStop ();
	MessageBox.Query ("Closed", "ClosedWithButton1", "Ok");
};
var b2 = new Button ("Button 2") {
	Y = 1
};
b2.Clicked += (s, e) => {
	Application.RequestStop ();
	MessageBox.Query ("Closed", "ClosedWithButton2","Ok");
};

d.Add (b1,b2);

Application.Run (d);
Application.Shutdown ();

Yea, looks like I broke this with my Key refactor PR. Oops.


[Impeller] add drawVertices and drawAtlas benchmarks.

Adds impeller benchmarks to track the progress of improvements made in https://github.com/flutter/flutter/issues/131345

This adds the benchmarks but not the CI configuration, holding off until https://github.com/flutter/flutter/pull/131837 lands too