Replace eawsy/aws-lambda-go and add SSM support for token

Replace eawsy/aws-lambda-go with AWS's aws-lambda-go
Cleanup and update documentation
Fix AWS vendor files
Add support for reading the Buildkite agent token from SSM
@lox I've cleaned up the commits so that each some make sense on their own. See comments in https://github.com/buildkite/buildkite-agent-metrics/pull/58#issuecomment-430512285 let me know if we shoud just use this PR instead.

@lox Please take a look, this replaces my other two pending PRs

@lox please take a look. btw, a clean checkout of buildkite-agent-metrics does NOT currently build successfully, e.g. running go get github.com/buildkite/buildkite-agent-metrics fails with an error (I tested it by by changing my GOPATH to get a clean run).
It doesn't not appear to be related to my two other PRs you merged in earlier.

Thanks for this @paulolai, there was a lot going on in this PR still. I tackled updating to aws-lambda-go in #60 and I've also updated to golang 1.11 in #61.
I've also updated vendors to the latest in #62.
Are you able to put in a PR just for the "Add support for reading the Buildkite agent token from SSM" piece of this PR? We can deal with the terraform stuff separately.


Include specific file from excluded folder

TypeScript Version:  nightly (2.5.0-dev.201xxxxx)
Code
// tsconfig.json
{
  "compilerOptions": {
    "target": "es6",
    "module": "esnext",
    "moduleResolution": "node",
    "jsx": "react",
    "sourceMap": true,
    "outDir": "./dist",
    "strict": true,
    "noImplicitAny": true,
    "strictNullChecks": true,
    "allowSyntheticDefaultImports": true,
    "noUnusedLocals": true,
    "baseUrl": "./",
    "paths": {
      "@/*": ["./app/*"],
      "~/*": ["./*"]
    },
    "experimentalDecorators": true,
    "typeRoots": [
      "typings"
    ]
  },
  "exclude": [
    "node_modules",
    "dist",
    "server",
    "scripts",
    ".vscode"
  ],
  "include": [
    "server/i18n.ts"
  ]
}

Expected behavior:
I ignored all files from server folder except "server/i18n.ts" file.
Actual behavior:
It's fail, and throw an error something like this

error TS18003: No inputs were found in config file 'pathproject/tsconfig.json'. Specified 'include' paths were '["server/i18n.ts"]' and 'exclude' paths were '["node_modules","dist","server","scripts",".vscode"]'.

Have you tried files?

Files included using "include" can be filtered using the "exclude" property. However, files included explicitly using the "files" property are always included regardless of "exclude". The "exclude" property defaults to excluding the node_modules, bower_components, jspm_packages and  directories when not specified. (http://www.typescriptlang.org/docs/handbook/tsconfig-json.html#details)

from http://www.typescriptlang.org/docs/handbook/tsconfig-json.html#details

Files included using "include" can be filtered using the "exclude" property.

and what @ikatyang said should work.

Automatically closing this issue for housekeeping purposes. The issue labels indicate that it is unactionable at the moment or has already been addressed.


[Snyk] Security upgrade express from 4.12.4 to 4.21.2

Snyk has created this PR to fix 1 vulnerabilities in the npm dependencies of this project.
Snyk changed the following file(s):

package.json
package-lock.json

Vulnerabilities that will be fixed with an upgrade:

Issue
Score

Regular Expression Denial of Service (ReDoS) SNYK-JS-PATHTOREGEXP-8482416
  738

[!IMPORTANT]

Check the changes in this PR to ensure they won't cause issues with your project.
Max score is 1000. Note that the real score may have changed since the PR was raised.
This PR was automatically created by Snyk using the credentials of a real user.

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.
For more information:
🧐 View latest project report
📜 Customise PR templates
🛠 Adjust project settings
📚 Read about Snyk's upgrade logic

Learn how to fix vulnerabilities with free interactive lessons:
🦉 Regular Expression Denial of Service (ReDoS)

Checkmarx One – Scan Summary & Details – 6324dc6f-c8f7-4baa-a797-005498e593fa
New Issues

Severity
Issue
Source File / Package
Checkmarx Insight

CVE-2022-33171
Npm-typeorm-0.2.25
Vulnerable Package

CVE-2023-42282
Npm-ip-1.1.5
Vulnerable Package

CVE-2024-42461
Npm-elliptic-6.4.1
Vulnerable Package

CVE-2024-48949
Npm-elliptic-6.4.1
Vulnerable Package

MongoDB_NoSQL_Injection
/routes/index.js: 39
Attack Vector

MongoDB_NoSQL_Injection
/routes/index.js: 39
Attack Vector

MongoDB_NoSQL_Injection
/routes/index.js: 191
Attack Vector

MongoDB_NoSQL_Injection
/routes/index.js: 219
Attack Vector

CVE-2023-45133
Npm-babel-traverse-6.26.0
Vulnerable Package

CVE-2023-46234
Npm-browserify-sign-4.0.4
Vulnerable Package

CVE-2024-21538
Npm-cross-spawn-6.0.5
Vulnerable Package

CVE-2024-21538
Npm-cross-spawn-5.1.0
Vulnerable Package

CVE-2024-21538
Npm-cross-spawn-4.0.2
Vulnerable Package

CVE-2024-29415
Npm-ip-1.1.5
Vulnerable Package

CVE-2024-33883
Npm-ejs-0.8.8
Vulnerable Package

CVE-2024-33883
Npm-ejs-1.0.0
Vulnerable Package

CVE-2024-4068
Npm-braces-2.3.2
Vulnerable Package

CVE-2024-4068
Npm-braces-3.0.2
Vulnerable Package

CVE-2024-45590
Npm-body-parser-1.9.0
Vulnerable Package

CVE-2024-48963
Npm-snyk-php-plugin-1.7.0
Vulnerable Package

CVE-2024-48964
Npm-snyk-gradle-plugin-3.2.2
Vulnerable Package

CVE-2024-53900
Npm-mongoose-4.2.4
Vulnerable Package

CVE-2020-8244
Npm-bl-3.0.0
Vulnerable Package

CVE-2020-8244
Npm-bl-2.2.0
Vulnerable Package

CVE-2022-22984
Npm-snyk-mvn-plugin-2.7.0
Vulnerable Package

CVE-2022-22984
Npm-snyk-python-plugin-1.16.0
Vulnerable Package

CVE-2022-22984
Npm-snyk-sbt-plugin-2.11.0
Vulnerable Package

CVE-2022-22984
Npm-snyk-docker-plugin-1.33.1
Vulnerable Package

CVE-2022-22984
<EMAIL_ADDRESS>Vulnerable Package

CVE-2022-22984
Npm-snyk-gradle-plugin-3.2.2
Vulnerable Package

CVE-2024-4067
Npm-micromatch-3.1.10
Vulnerable Package

CVE-2024-42459
Npm-elliptic-6.4.1
Vulnerable Package

CVE-2024-42460
Npm-elliptic-6.4.1
Vulnerable Package

CVE-2024-47764
Npm-cookie-0.4.1
Vulnerable Package

CVE-2024-48948
Npm-elliptic-6.4.1
Vulnerable Package

Unpinned Actions Full Length Commit SHA
/snyk-code.yml: 8
Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...

Unpinned Actions Full Length Commit SHA
/codeql-analysis.yml: 46
Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...

Unpinned Actions Full Length Commit SHA
/codeql-analysis.yml: 57
Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...

Unpinned Actions Full Length Commit SHA
/snyk-code.yml: 15
Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...

Unpinned Actions Full Length Commit SHA
/snyk-code-manual.yml: 13
Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...

Unpinned Actions Full Length Commit SHA
/snyk-test-sarif.yml: 15
Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...

Unpinned Actions Full Length Commit SHA
/snyk-test-sarif.yml: 8
Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...

Unpinned Actions Full Length Commit SHA
/codeql-analysis.yml: 71
Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...


If path names have real IRI's then the "IRI denotes a path' hack does not work.

This impacts ttl and sparql logic.

OdgiStore.py#L123
and OdgiStore.py#L227
This code needs to become a function and take into account that realpath names can have '/' in them.

I took a look at the code mentioned above, but it still looks the same to me? How did you fix the problem?


Flutter test's output on test failure is too verbose.

I currently get 156 lines of exception backtraces with relevant information embeded within it.
Only 10 lines of the 156 lines are actually useful:  ie. they tell me what the failure is and where.
We can do better.
Maybe we need to make a metric for the board.  % lines of test failure useful:  6%

There's three bugs here.
-[ ] #3639 - for some reason, the test framework outputs tests twice.
-[ ] I can't control the output of the test framework in the first place. If I could, I'd make the exceptions prettier without needing to throw a fake one.
-[ ] We don't currently post-process the stack traces to remove dart-internal frames. I plan to add that at some point.

Fixed by https://github.com/flutter/flutter/pull/3936.


jolokia jvm add to kafka server ,kafka can not start

vi kafka-server-start.sh
export JMX_PORT=9999
export RMI_HOSTNAME=log-services-250
export KAFKA_OPTS="$KAFKA_OPTS -javaagent:/data/kafka_2.11-1.1.0/libs/jolokia-agent.jar -Dcom.sun.management.jmxremote -Dcom.sun.management.jmxremote.authenticate=false -Dcom.sun.management.jmxremote.ssl=false -Djava.rmi.server.hostname=$RMI_HOSTNAME -Dcom.sun.management.jmxremote.rmi.port=$JMX_PORT"

Failed to find Premain-Class manifest attribute in jolokia-jvm-1.6.2.jar
Error occurred during initialization of VM
agent library failed to init: instrument

Does Kafka come with a bundled version of Jolokia or is this something you copied over ? If so, be sure to use the proper agen jar file (there is one with dependencies and the proper manifest, and the other has only the agent classes)

@rhuss
I don't see a description of compatibility，I've tried 1.3.7version it throw the same error

How large is the jar that you are using ? (in bytes)

@rhuss
93KB

that's the wrong jar. Use the one with the jolokia-jvm.jar from https://github.com/rhuss/jolokia/releases/download/v1.6.2/jolokia-1.6.2-bin.zip  Should be ~465k.

or https://repo1.maven.org/maven2/org/jolokia/jolokia-jvm/1.6.2/jolokia-jvm-1.6.2-agent.jar ....

@rhuss
The JAR file is correct, just renamed to jolokia-agent.jar

@rhuss

If its only 93k its not the right one, sorry.

@rhuss
thx，so weird，I also downloaded it from the official website


com.google.fonts/check/039 returns FAIL when things are OK

Observed behaviour
Lots of false negatives on this one too.
com.google.fonts/check/039 "FontForge checks" returns a FAIL when this is returned:
1. PASS  fontforge-check: Contours are closed.
1. **FAIL  fontforge-check: There are countour intersections!**
1. **FAIL  fontforge-check: Contours have incorrect directions!**
1. PASS  fontforge-check: References in the glyph haven't been flipped.
1. **FAIL  fontforge-check: Glyphs do not have points at extremas!**
1. PASS  fontforge-check: Glyph names referred to from glyphs present in the font.
1. PASS  fontforge-check: Points (or control points) are not too far apart.
1. PASS  fontforge-check: Not more than 1,500 points in any glyph (a PostScript limit).
1. PASS  fontforge-check: Font respects PostScript limit of 96 hints per glyph
1. PASS  fontforge-check: Font doesn't have invalid glyph names.
1. PASS  fontforge-check: Glyphs have allowed numbers of points defined in maxp.
1. PASS  fontforge-check: Glyphs have allowed numbers of paths defined in maxp.
1. PASS  fontforge-check: Composite glyphs have allowed numbers of points defined in maxp.
1. PASS  fontforge-check: Composite glyphs have allowed numbers of paths defined in maxp.
1. PASS  fontforge-check: Glyphs instructions have valid lengths.
1. PASS  fontforge-check: Points in glyphs are integer aligned.
1. PASS  fontforge-check: Glyphs have all required anchors.
1. PASS  fontforge-check: Glyph names are unique.
1. PASS  fontforge-check: Unicode code points are unique.
1. PASS  fontforge-check: Hints do not overlap.

Expected behaviour
Each of the 3 FAILed things are only worth flagging as WARNs, because it is something the type designer should care for, and (at least for GF) will not block release.
These check results are not useful as the are, even as WARNs - they need more information to evaluate them - which glyphs, and how many times per glyph, fail these?
Overall, since there are only 20 things, I think we might be better served by porting these 20 things to Python and dropping FontForge as an optional dependency.

I agree!
This is also similar to #1924 (except that in this case we may end up porting everything to python more easily)

A quick thought regarding both this issue and also #1939 and #1941:
Maybe we could make all third-party tools result in WARNs whenever the tools would emit FAILs.

On Thu, Jul 5, 2018, 2:54 PM Felipe Corrêa da Silva Sanches <
<EMAIL_ADDRESS>wrote:

A quick thought regarding both this issue and also #1939
https://github.com/googlefonts/fontbakery/issues/1939 and #1941
https://github.com/googlefonts/fontbakery/issues/1941:
Maybe we could make all third-party tools result in WARNs whenever the
tools would emit FAILs

No, ots and ftxval has stuff we must fail on, because they will prevent
fonts from working for users if we don't catch them, and probably fontval
too.

OK. So I will only override FAILs in very specific cases like I did with the fontforge checks above.


Upgrade nest v9

JIRA Link
DA-439
Changelog / Description
Upgrades to NestJS v9 and add yarn start:repl script
Checklist -

[X] New Feature ?
[ ] Updated swagger annotation (if API structure is changed) ?
[ ] Unit Test (if possible) ?
[X] Updated the Readme.md (if required) ?

Thanks for the istanbul comment @prashantasdeveloper

:tada: This PR is included in version 2.0.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


⚠ Nyarima has degraded performance

In e88b5a8, Nyarima (https://nyarima.com.au) experienced degraded performance:

HTTP code: 200
Response time: 8225 ms

Resolved: Nyarima performance has improved in fc34fe3 after .


Analyser and token filter settings

This is what I've been able to add so far, more to come.

Awesome stuff Mattias, I can't pull automatically through the github web interface so I'll pull this later tonight.
Thanks!


Update other completion providers list

Update the list of other code completion providers.
Test plan

Trival, CI will validate.

https://continue.dev/ is pretty popular


[Website] Responsive issue with main menu at 1138px

Description
Please notice the unwanted behavior that occurs in-between the desktop and mobile-style menus. There is a transition starting at about 1138px that renders the menu unusable.
https://github.com/meshery/meshery.io/assets/7570704/cbb37951-555e-490a-b5dc-041121d04ab6
Expected Behavior
The menu should always be in a usable state.

Contributor Guides and Handbook
The meshery.io website uses Jekyll and GitHub Pages. Site content is found under the master branch.

📚 See the Contributing to Meshery.io Website section of the readme.md and other contributing instructions, too.
🎨 Wireframes and designs for Meshery UI in Figma (open invite)
🙋🏾🙋🏼 Questions: Discussion Forum and Community Slack

Hello @leecalcote I would like to work on this issue.

Hello @leecalcote I am not able to replicate this issue and can you please confirm if it is not device device-specific issue?
Please find the attached screenshot and screen recording for some reference.
https://github.com/meshery/meshery.io/assets/114280481/7234ba0a-0cb2-4596-953f-2ed3f67025ac

yeah i am also not able to replicate this issue. I tested on my device the menu occurence occurs at 1141px and the menu works fine on that. Below that hamburger icon is available.

Hey I would like to work upon this issue @leecalcote

hey @26vanshika let's do it

Please note that this issue only occurs in Safari. Access to macOS is necessary in order to test.


update prql-js to v0.5.2 for the none prql target option support

see #98 for more info.
@max-sixty & @aljazerzen this still doesn't work as expected.
The generated by message in sql preview should have  target:sql.sqlite for the prql and settings below.
I did set it to sql.not_existing as in this test: https://github.com/PRQL/prql/blob/main/prql-js/tests/test_all.js#L89
See changes in compile.ts.

I see a few issues on this. IIUC this does work OK now. Let me know if that's not correct — happy to get even more acquainted with the plethora of JS build tools!

yeah, it works. I did not know the expected compiler signature and assumed it did not.


Pyjwt 2.0.0 compatibility issue

graphql.error.located_error.GraphQLLocatedError: module 'jwt' has no attribute 'ExpiredSignature'
ExpiredSignature is deprecated and ExpiredSignatureError should be used instead in the newer Pyjwt versions.

Just chiming in to say that I'm facing the exact same situation.

I've had issues with PyJWT 2.0.0 too.
I had to downgrade to 1.7.1 where it was working.
My error was :
in jwt_encode
    jwt_settings.JWT_ALGORITHM,
graphql.error.located_error.GraphQLLocatedError: 'str' object has no attribute 'decode'

I did the same thing.
I installed PyJWT v1.7.1 explicitly.

Added pull request #244 as hot-fix.
Ideally, jwt usage should be rewritten to make it compatible with the latest PyJWT library.

I wonder if this repo is still active

I wonder if this repo is still active

this is a real problem
Django version 3.1.5, using settings 'app.settings'
Starting development server at http://<IP_ADDRESS>:8000/
Quit the server with CTRL-BREAK.
Traceback (most recent call last):
File "C:\Users\tony\Anaconda3\envs\server38\lib\site-packages\promise\promise.py", line 489, in _resolve_from_executor
executor(resolve, reject)
File "C:\Users\tony\Anaconda3\envs\server38\lib\site-packages\promise\promise.py", line 756, in executor
return resolve(f(*args, **kwargs))
File "C:\Users\tony\Anaconda3\envs\server38\lib\site-packages\graphql\execution\middleware.py", line 75, in make_it_promise
return next(*args, **kwargs)
File "C:\Users\tony\Anaconda3\envs\server38\lib\site-packages\graphql_jwt\decorators.py", line 140, in wrapper
result = f(cls, root, info, **kwargs)
File "C:\Users\tony\Anaconda3\envs\server38\lib\site-packages\graphql_jwt\decorators.py", line 129, in wrapper
result = f(cls, root, info, **kwargs)
File "C:\Users\tony\Anaconda3\envs\server38\lib\site-packages\graphql_jwt\decorators.py", line 121, in wrapper
result = f(cls, *args, **kwargs)
File "C:\Users\tony\Anaconda3\envs\server38\lib\site-packages\graphql_jwt\decorators.py", line 107, in wrapper
return maybe_thenable((context, user, result), on_token_auth_resolve)
File "C:\Users\tony\Anaconda3\envs\server38\lib\site-packages\graphene\utils\thenables.py", line 42, in maybe_thenable
return on_resolve(obj)
File "C:\Users\tony\Anaconda3\envs\server38\lib\site-packages\graphql_jwt\decorators.py", line 70, in on_token_auth_resolve
payload.token = jwt_settings.JWT_ENCODE_HANDLER(payload.payload, context)
File "C:\Users\tony\Anaconda3\envs\server38\lib\site-packages\graphql_jwt\utils.py", line 37, in jwt_encode
return jwt.encode(
graphql.error.located_error.GraphQLLocatedError: 'str' object has no attribute 'decode'
[07/Jan/2021 23:58:23] "POST /graphql/ HTTP/1.1" 200 148

this is a real problem
Django version 3.1.5, using settings 'app.settings'
Starting development server at http://<IP_ADDRESS>:8000/
Quit the server with CTRL-BREAK.
Traceback (most recent call last):
File "C:\Users\tony\Anaconda3\envs\server38\lib\site-packages\promise\promise.py", line 489, in _resolve_from_executor
executor(resolve, reject)
File "C:\Users\tony\Anaconda3\envs\server38\lib\site-packages\promise\promise.py", line 756, in executor
return resolve(f(*args, **kwargs))
File "C:\Users\tony\Anaconda3\envs\server38\lib\site-packages\graphql\execution\middleware.py", line 75, in make_it_promise
return next(*args, **kwargs)
File "C:\Users\tony\Anaconda3\envs\server38\lib\site-packages\graphql_jwt\decorators.py", line 140, in wrapper
result = f(cls, root, info, **kwargs)
File "C:\Users\tony\Anaconda3\envs\server38\lib\site-packages\graphql_jwt\decorators.py", line 129, in wrapper
result = f(cls, root, info, **kwargs)
File "C:\Users\tony\Anaconda3\envs\server38\lib\site-packages\graphql_jwt\decorators.py", line 121, in wrapper
result = f(cls, *args, **kwargs)
File "C:\Users\tony\Anaconda3\envs\server38\lib\site-packages\graphql_jwt\decorators.py", line 107, in wrapper
return maybe_thenable((context, user, result), on_token_auth_resolve)
File "C:\Users\tony\Anaconda3\envs\server38\lib\site-packages\graphene\utils\thenables.py", line 42, in maybe_thenable
return on_resolve(obj)
File "C:\Users\tony\Anaconda3\envs\server38\lib\site-packages\graphql_jwt\decorators.py", line 70, in on_token_auth_resolve
payload.token = jwt_settings.JWT_ENCODE_HANDLER(payload.payload, context)
File "C:\Users\tony\Anaconda3\envs\server38\lib\site-packages\graphql_jwt\utils.py", line 37, in jwt_encode
return jwt.encode(
graphql.error.located_error.GraphQLLocatedError: 'str' object has no attribute 'decode'
[07/Jan/2021 23:58:23] "POST /graphql/ HTTP/1.1" 200 148

I have modified the function then it worked

I hope this doesn't brake the other functional things, since no need to run decode('utf-8')

I have modified the function then it worked

I hope this doesn't brake the other functional things, since no need to run decode('utf-8')

@IbrahimAlgadi, it will work for PyJWT >= 2, but not for earlier versions.

@IbrahimAlgadi, it will work for PyJWT >= 2, but not for earlier versions.

@rganeyev
What about classic ( try -- except ) for the str error in the jwt_encode function.
Does it work

@rganeyev
What about classic ( try -- except ) for the str error in the jwt_encode function.
Does it work

@IbrahimAlgadi well, it is bad architecture desicion. What may happen when pyJWT changes signature on their major update?
I see here multiple solutions:

[Easy] Restrict PyJWT version as 1.*. It is hot fix, and will work. #244 for that.
[Right] Increase PyJWT version to 2.* and fix all jwt-related issues. That includes your change, and all possible jwt usages in the repo.
[I did this] Abandon this repo as it is dead and no-one is going to maintain it.

@IbrahimAlgadi well, it is bad architecture desicion. What may happen when pyJWT changes signature on their major update?
I see here multiple solutions:

[Easy] Restrict PyJWT version as 1.*. It is hot fix, and will work. #244 for that.
[Right] Increase PyJWT version to 2.* and fix all jwt-related issues. That includes your change, and all possible jwt usages in the repo.
[I did this] Abandon this repo as it is dead and no-one is going to maintain it.

@IbrahimAlgadi well, it is bad architecture desicion. What may happen when pyJWT changes signature on their major update?
I see here multiple solutions:

[Easy] Restrict PyJWT version as 1.*. It is hot fix, and will work. #244 for that.
[Right] Increase PyJWT version to 2.* and fix all jwt-related issues. That includes your change, and all possible jwt usages in the repo.
[I did this] Abandon this repo as it is dead and no-one is going to maintain it.

Your 3rd choice is actually what I did. I'm even switching to DRF right now. Graphene-Django seems to be dead too so...
I think code owners are all on the new Strawberry project now..
But it doesn't seem to be mature enough for Django,...
Will it be soon ?
I don't know and I don't wanna know. This was kinda good to use GraphQL and I'm a bit disappointed to lose its benefits but these libraries are not stable enough and I can't predict the future (yet) so I prefer switching on something more reliable, maintained, and widely used.

@IbrahimAlgadi well, it is bad architecture desicion. What may happen when pyJWT changes signature on their major update?
I see here multiple solutions:

[Easy] Restrict PyJWT version as 1.*. It is hot fix, and will work. #244 for that.
[Right] Increase PyJWT version to 2.* and fix all jwt-related issues. That includes your change, and all possible jwt usages in the repo.
[I did this] Abandon this repo as it is dead and no-one is going to maintain it.

Your 3rd choice is actually what I did. I'm even switching to DRF right now. Graphene-Django seems to be dead too so...
I think code owners are all on the new Strawberry project now..
But it doesn't seem to be mature enough for Django,...
Will it be soon ?
I don't know and I don't wanna know. This was kinda good to use GraphQL and I'm a bit disappointed to lose its benefits but these libraries are not stable enough and I can't predict the future (yet) so I prefer switching on something more reliable, maintained, and widely used.

@fgallese
If you are still interested, I got it working by removing verify=True option in jwt.decode method call
https://github.com/ibqn/django-graphql-jwt/commit/dd92319071092bb517187904f3ac0610e8443edf

I apologize for the delay in my response #261.
The new release requires Graphene v3 and supports PyJWT>=2:
pip install 'django-graphql-jwt>=0.3.2'


Update skew policy for n-3 nodes for 1.28/1.25+

This updates the skew policy for n-3 node support, starting with 1.28 control planes / 1.25 nodes.
See https://github.com/kubernetes/enhancements/issues/3935 and https://github.com/kubernetes/enhancements/tree/master/keps/sig-architecture/3935-oldest-node-newest-control-plane for details.
I opened this against the dev-1.28 branch since the published policy should not be updated until we actually have 1.28 control planes that would support n-3 skew.
Preview at https://deploy-preview-42218--kubernetes-io-vnext-staging.netlify.app/releases/version-skew-policy/
/assign @dims
/sig architecture

/approve
/cc @johnbelamaric @derekwaynecarr

/approve
/lgtm


Questions regarding enforcement.

Who is responsible for making sure employees follow these RFC's?

What happens if folks don't follow the RFC?

*Edited to remove redundant question

I can see some of these coming up in response to need. I'm not sure how prescriptive we need to be to start.

We as a community are responsible. During code reviews, design reviews, etc. If there are practices we think are good as a community that aren't being followed then there should at least be a discussion as to why not.

See 1, I think it's basically the same answer.

If an RFC isn't being followed by the majority of folks, then I'd argue the RFC is wrong, needs to be retired and possibly a followup RFC written that captures how the community is working. I don't think an RFC should ever be considered static, these can, and probably should change as circumstances change.

great question and should be move to the Discussion board..I will do so if no objection

Yea, seems like it could be good as a discussion so it's easier to see the answer in the future. (And, I can see it as an evolving answer as we refine the process)

created https://github.com/cds-snc/docs/discussions/6


Add timestaps in logs

Changes
The controller and webhook logs do not include timestamps, which
makes troubleshooting issues much harder.
Adding the timestamps into the default logging configuration.
Signed-off-by: Andrea Frittoli<EMAIL_ADDRESS>Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:

[n/a] Includes tests (if functionality changed/added)
[n/a ] Includes docs (if user facing)
[x] Commit messages follow commit message best practices
[x] Release notes block has been filled in or deleted (only if no user facing changes)

See the contribution guide for more details.
Double check this list of stuff that's easy to miss:

If you are adding a new binary/image to the cmd dir, please update
the release Task to build and release this image.

Reviewer Notes
If API changes are included, additive changes must be approved by at least two OWNERS and backwards incompatible changes must be approved by more than 50% of the OWNERS, and they must first be added in a backwards compatible way.
Release Notes
Add timestamp in the logs of the tekton pipelines controller and webhook

/kind feature
/cc @vdemeester @mattmoor

/test check-pr-has-kind-label

Uhm, test failed because of empty step name:
        apiVersion: tekton.dev/v1beta1
        kind: Task
        metadata:
          creationTimestamp: "2020-10-15T09:53:55Z"
          generation: 1
          name: pipeline-level-finally-one-d-a-g-task-failed-failure-zbmlcmbf
          namespace: arendelle-7drp7
          resourceVersion: "9211"
          selfLink: /apis/tekton.dev/v1beta1/namespaces/arendelle-7drp7/tasks/pipeline-level-finally-one-d-a-g-task-failed-failure-zbmlcmbf
          uid: b4968328-d0d9-4058-aac9-342a3ff65723
        spec:
          steps:
          - image: alpine
            name: ""
            resources: {}
            script: exit 1

Uhm, TestPipelineLevelFinally_OneDAGTaskFailed_Failure test failed because of invalid step name (too long, 78 characters):

I think the issue is in https://github.com/tektoncd/pipeline/blob/bd885f8c6d827d8114ff15718840fc8666f2b06c/pkg/reconciler/pipelinerun/resources/conditionresolution.go#L99 - we make a new name without checking if it's valid.

Interesting, the test passed now, error is still in the logs:
    TestPipelineLevelFinally_OneDAGTaskFailed_Failure: kubelogs.go:197: E 12:44:52.345 tekton-pipelines-controller-54d5fd6cfc-jnmk2 [pipelinerun/reconciler.go:294] [arendelle-dg2qf/pipeline-level-finally-one-d-a-g-task-failed-failure-eefspplc] Returned an error err=1 error occurred:
        	* error creating ConditionCheck container called pipeline-level-finally-one-d-a-g-task-failed-failure-eefs-ppszq for PipelineTask dagtask3 from PipelineRun pipeline-level-finally-one-d-a-g-task-failed-failure-eefspplc: admission webhook "validation.webhook.pipeline.tekton.dev" denied the request: validation failed: invalid value "condition-check-pipeline-level-finally-one-d-a-g-task-failed-failure-wyqwlurp": spec.taskspec.steps[0].name
        Task step name must be a valid DNS Label, For more info refer to https://kubernetes.io/docs/concepts/overview/working-with-objects/names/#names

I guess the Task was meant to fail anyways, only it fails because of an invalid name before it can fail because of a force false condition. I suppose the reason for failure in the previous run must have been a different one then.

https://github.com/tektoncd/pipeline/issues/3393

/lgtm

/approve

I've seen this kind of errors quite a few times in E2E logs:
   {"level":"error","ts":1602809909.5059779,"caller":"git/git.go:53","msg":"Error running git [fetch --recurse-submodules=yes --depth=1 origin --update-head-ok --force v0.32.0]: exit status 128\nfatal: unable to access 'https://github.com/GoogleContainerTools/skaffold/': Could not resolve host: github.com\n","stacktrace":"github.com/tektoncd/pipeline/pkg/git.run\n\tgithub.com/tektoncd/pipeline/pkg/git/git.go:53\ngithub.com/tektoncd/pipeline/pkg/git.Fetch\n\tgithub.com/tektoncd/pipeline/pkg/git/git.go:144\nmain.main\n\tgithub.com/tektoncd/pipeline/cmd/git-init/main.go:52\nruntime.main\n\truntime/proc.go:203"}
        {"level":"fatal","ts":1602809909.506128,"caller":"git-init/main.go:53","msg":"Error fetching git repository: failed to fetch [v0.32.0]: exit status 128","stacktrace":"main.main\n\tgithub.com/tektoncd/pipeline/cmd/git-init/main.go:53\nruntime.main\n\truntime/proc.go:203"}

I think we might want to consider running a local git server on the k8s cluster where we run E2E tests.

/test pull-tekton-pipeline-integration-tests

/retest


Installation failed

Only a small issue but might be worth mentioning in ReadMe.
Roberts-MacBook-Pro:Marathon robertnash$ make
swift package --enable-prefetching update
Fetching https://github.com/johnsundell/files.git
Fetching https://github.com/johnsundell/unbox.git
Fetching https://github.com/johnsundell/wrap.git
Cloning https://github.com/johnsundell/files.git
Resolving https://github.com/johnsundell/files.git at 1.6.2
Cloning https://github.com/johnsundell/wrap.git
Resolving https://github.com/johnsundell/wrap.git at 2.1.0
Cloning https://github.com/johnsundell/unbox.git
Resolving https://github.com/johnsundell/unbox.git at 2.4.0
swift build --enable-prefetching -c release -Xswiftc -static-stdlib
Compile Swift Module 'Wrap' (1 sources)
Compile Swift Module 'Unbox' (1 sources)
Compile Swift Module 'Files' (1 sources)
Compile Swift Module 'MarathonCore' (24 sources)
Compile Swift Module 'Marathon' (1 sources)
Linking ./.build/release/Marathon
cp -f .build/release/Marathon /usr/local/bin/marathon
cp: /usr/local/bin/marathon: Permission denied
make: *** [install] Error 1

What would you like to be mentioned in the README? Was the problem that you didn't have write access to /usr/local/bin? 🤔

I had to run 'sudo make'
My permissions are set up like so.
drwxr-xr-x  root  wheel  bin

Ah, I understand. I'll add a note to the README, thanks! 👍


Add Google Analytics Tracking

Woah! Adding Google Analytics was so easy for this page. I used a Gatsby plugin to get things squared away. The only thing to keep in mind is that you have to run a production build (gatsby build && gatsby serve) to test this out locally.
There is a "Touchtable Website" property set up to track events on the intermediate page. This currently includes page visits and clicks to outbound sites.

This branch has been rebased to include tracking to new outbound links. I also snuck in an update to some footer content.


RESOURCE_EXHAUSTED issue on samples ITs

Fixing in https://github.com/googleapis/java-bigqueryconnection/pull/170


We should resolve all of the failures. Setting a fixed seed is a way for the build to stop failing while we do it.

The particular failure here:
CPU: ... regexp_extract(a, (abc1a$|ab2ab$), 1)='ab2ab'....
GPU: ...regexp_extract(a, (abc1a$|ab2ab$), 1)='ab2ab\r'...

The input string is aab2ab\r\n

A potential fix for this will be impacted by https://github.com/rapidsai/cudf/pull/15961, so this issue will be blocked until that is merged into cuDF

Re-evaluate after implementation of https://github.com/NVIDIA/spark-rapids/issues/11554

To verify results with regex_flags::EXT_NEWLINE, I applied cuDF's cudf::strings::extract on the input aab2ab\r\n.
Original regex pattern: ab2ab$
Since cuDF doesn’t recognize \r\n as a valid line break, we transpire $ to (?:\r\n)?$ to work around this limitation.

Regex Pattern
Extracted Value
Index

((ab2ab)(?:\r\n)?$)
aab2ab\r\n
0

(ab2ab(?:\r\n)?$)
aab2ab\r\n
0

Expected JVM output: aab2ab
It appears cuDF does not handle non-capturing groups (?:\r\n) as expected when they are nested inside another capturing group.

To verify results with regex_flags::EXT_NEWLINE (#11554), I applied cuDF's cudf::strings::extract on the input aab2ab\r\n.
Original regex pattern: ab2ab$
Since cuDF doesn’t recognize \r\n as a valid line break, we transpire $ to (?:\r\n)?$ to work around this limitation.
Regex Pattern Extracted Value Index
((ab2ab)(?:\r\n)?$) aab2ab\r\n	0
(ab2ab(?:\r\n)?$) aab2ab\r\n	0
Expected Spark/Java output: aab2ab
It appears cuDF does not handle non-capturing groups (?:\r\n) as expected when they are nested inside another capturing group.

A couple of things:

cudf extract inherits the API definition from Pandas so it doesn't actually include the whole string as possible extraction. Also Java complicates this by ultimately truncating out the new line characters in the final output for index 0.

Should we even be including the $ in the full capture group that we are adding to make it work with cuDF. I think we should try this with it filtered out like ab2ab$ -> (ab2ab)(?:\r\n)?$ instead.

I think the nested non-capturing group should behave as expected here. Can we confirm what the behavior is in Python/Pandas is? If this behaves as expected for Java, then we should file a bug with cuDF.

Thanks @NVnavkumar, you're right (ab2ab)(?:\r\n)?$ would be the right regex replacement here since we are looking at index 0. I see cuDf's behavior is as expected.


Alpsjg

do not merge, review or run
daily gitlab CI demo: https://gitlab.com/cscs-ci/ci-testing/webhook-ci/mirrors/6557018579987861/835515875116201/-/pipelines
https://kibana.cscs.ch/s/fm/app/dashboards#/view/05a93400-724c-11ee-bad2-017f9d8e7443?_g=(refreshInterval%3A(pause%3A!t%2Cvalue%3A60000)%2Ctime%3A(from%3Anow-50m%2Cto%3Anow))

I will close for now and revisit when the application template is ready


Does Beast works with standalone Asio?

use macro ASIO_STANDALONE

No

Are there any plans to making it possible? I see that json, url libs are having standalone mode from beginning. It would be great to have a standalone beast also!

I actually agree that it would be nice to have.
@vinniefalco what do we think about this?

No can do

Is it just a matter of manpower? Or are there Boost dependencies other than Asio that would be difficult to decouple?

I see now that Kohlhoff uses a Perl script to generate a "boostified" version of Asio, and the differences between the two are not trivial.


changed the Model

Sorry, this is bloat. I'll add a contributing.md or update the current contributing instruction. For now, stay put till the Official "Hello World" is out :sweat_smile:


python libmage

Incomplete but usable mage client lib in pure python that use MAGE http/json interface.

Thanks a lot for this library, which we'll include for sure in the distribution. I have made a few remarks to improve consistency with the rest of the product. Could you please take a look at them?


Model selection

NOTE: This experimental feature was not covered by tests! Proceed with caution.

Selection of model for predict method.
Subset max shape changed to 2 to make some models working.

Codecov Report

Merging #63 (f771e35) into master (b326e4f) will increase coverage by 4.56%.
The diff coverage is 78.77%.

@@            Coverage Diff             @@
##           master      #63      +/-   ##
==========================================
+ Coverage   60.81%   65.38%   +4.56%
==========================================
  Files          28       32       +4
  Lines        2067     2256     +189
==========================================
+ Hits         1257     1475     +218
+ Misses        810      781      -29

Impacted Files
Coverage Δ

bamt/networks/hybrid_bn.py
100.00% <ø> (ø)

bamt/nodes/logit_node.py
86.66% <0.00%> (+1.66%)
:arrow_up:

bamt/utils/EvoUtils.py
63.09% <63.09%> (ø)

bamt/builders/hc_builder.py
69.44% <69.44%> (ø)

bamt/networks/base.py
48.62% <80.00%> (+5.19%)
:arrow_up:

bamt/builders/evo_builder.py
96.92% <96.92%> (ø)

bamt/builders/__init__.py
100.00% <100.00%> (ø)

bamt/builders/builders_base.py
94.26% <100.00%> (ø)

bamt/nodes/__init__.py
100.00% <100.00%> (ø)

bamt/nodes/conditional_gaussian_node.py
89.42% <100.00%> (+3.84%)
:arrow_up:

... and 4 more

... and 2 files with indirect coverage changes


Add score viewing & PDF download

Please add to the android app:

Ability to preview sheet music
ability to download in pdf

Please note that the features of the app are not platform-dependent, there is no "Android app", just "the app".
"Previewing" sheet music is accomplished in two ways, either by downloading the MSCZ, then viewing it in a program (usually the MuseScore desktop program), or by downloading the PDF and displaying it as separate pages. It would be unnecessary to implement the previewing feature since you'd be "previewing" a sheet after you've already downloaded it, meaning it's essentially a "postview" at that point. As a result, the thumbnails are the only preview that will be available in the app.
As for PDF downloads, I'll see if I can implement it.

The userscript has access to the website which is where it downloads the PDF from. The app isn't, and so either needs a different method, or needs to access the website in the background. I was going to use a similar method uses in the command-line tool to download PDF, but the tools available to do it in Flutter (the framework the app uses) were limited, and so I opted not to implement it as it wasn't important as other tools could download it.
As for why not now, two reasons, one, the app has been patched for months now, and two, the command-line tool has also been patched, meaning my preferred method for getting this to work can't work anymore


openmoji has started taking forever to build.

Describe the bug
openmoji-color and openmoji-black now both take >12h to build. They are timing out on hydra https://hydra.nixos.org/job/nixos/trunk-combined/nixpkgs.openmoji-color.x86_64-linux.
Steps To Reproduce
Steps to reproduce the behavior:

nix-build -A openmoji-color

Notify maintainers
@fgaz

Could this be the same as #97871? Should we switch to prebuilt fonts here too?

It could be. But in the past the build only took a minute or 2. Now it takes basically forever. I'm trying to bisect when this was introduced but bisecting timeouts is slow and error-prone.

According to git bisect d41fcfc34e327d0c09fd0770e56d0de4bf357797 is the first bad commit. That isn't particularly helpful.

I did a better bisection and got 69da642a5a9bb433138ba1b13c8d56fb5bb6ec05 (https://github.com/NixOS/nixpkgs/pull/163439) which seems likely.  I saw that PR but thought it seemed too old. I guess I forgot how long a staging cycle can take.
cc @evils @jtojnar @erictapen
I don't know what the best approach here is. Report the bug upstream to fontforge or openmoji? There are a lot of warnings and errors in the build so I suspect that it may be an openmoji problem and fontforge was doing its best before and working but now is failing?
The command I used for reference was:
git bisect run zsh -c 'set -x; nix build -f . openmoji-color --max-silent-time 600 |& tee /tmp/out; [[ $pipestatus[1] == 0 ]] && exit 0; grep -- "-openmoji-.*timed out after .* seconds of silence" /tmp/out && exit 1; exit 125'

after a brief look at this
fontforge has a reported regression in its ability to remove overlaps (https://github.com/fontforge/fontforge/issues/4859)
but if openmoji is the only font that is failing because of that, maybe they're relying too much on fontforge's abliity to fix things at build time
(with the latest master commits from openmoji and fontforge, the openmoji build also hangs)

I tried diffing the logs but they are basically completely different once scfbuild starts. In case they are helpful to anyone here are the builds before and after that commit. (The after obviously cuts off after the "infinite loop").
before.log
after.log

Great investigation!
Maybe as a short-term fix we could override fontforge for this package?

That sounds like a reasonable mitigation until a patch is available.

Bump, would really love to have openmoji available when I upgrade 21.11 -> 22.05!

Bumping issues is not a helpful thing to do.

In general yes, though in this case it reminded me to fix this before 22.05 :)
Here you go @OPNA2608: #174795

I tried running bisection on fontforge itself using nix-bisect after applying the patch below:
$ git bisect start 20220308 20201107
$ extra-bisect run \
  nix-build-status \
    --option max-silent-time 240 \
    -f ~/Projects/nixpkgs \
    openmoji-color

Unfortunately, the automatic bisection did not work for some reason. Possibly because the timeout regex does not match the error message: error: building of '/nix/store/6z3q2pb6frq47ch617nayaambb7rsyxa-openmoji-13.1.0.drv!out' from .drv file timed out after 240 seconds of silence
--- a/pkgs/data/fonts/openmoji/default.nix
+++ b/pkgs/data/fonts/openmoji/default.nix
@@ -3,6 +3,10 @@
 , fetchFromGitHub
 , scfbuild
 , nodejs
+, fontforge
+, libuninameslist
+, fetchpatch
+, patch
 , nodePackages
 , python3Packages
 , variant ? "color" # "color" or "black"
@@ -14,6 +18,30 @@ let
     [ "OpenMoji-Color.ttf" "OpenMoji-Black.ttf" ]
     variant;

+    fontforge-bisect = fontforge.overrideAttrs (old: rec {
+      version = "bisect";
+      src = /home/jtojnar/Projects/fontforge;
+      patches = [
+        (fetchpatch {
+          url = "https://salsa.debian.org/fonts-team/fontforge/raw/76bffe6ccf8ab20a0c81476a80a87ad245e2fd1c/debian/patches/0001-add-extra-cmake-install-rules.patch";
+          sha256 = "u3D9od2xLECNEHhZ+8dkuv9818tPkdP6y/Tvd9CADJg=";
+        })
+        # (fetchpatch {
+        #   url = "https://github.com/fontforge/fontforge/commit/69e263b2aff29ad22f97f13935cfa97a1eabf207";
+        #   sha256 = "06yyf90605aq6ppfiz83mqkdmnaq5418axp9jgsjyjq78b00xb29";
+        # })
+      ];
+      prePatch = ''
+        patch() {
+          ${patch}/bin/patch "$@"  || echo 'Failed to apply patch, continuing'
+        }
+      '';
+      buildInputs = old.buildInputs ++ [ libuninameslist ];
+    });
+    scfbuild-with-fontforge-bisect = scfbuild.override (old: {
+      fontforge = fontforge-bisect;
+    });
+
 in stdenv.mkDerivation rec {
   pname = "openmoji";
   version = "13.1.0";
@@ -26,7 +54,7 @@ in stdenv.mkDerivation rec {
   };

   nativeBuildInputs = [
-    scfbuild
+    scfbuild-with-fontforge-bisect
     nodejs
     nodePackages.glob
     nodePackages.lodash

needs to be reported upstream

Which one though? Openmoji or fontforge?


Add support for Azure MSSQL Server

Add support for MSSQL server on MS Azure
Terraform:

https://registry.terraform.io/providers/hashicorp/azurerm/latest/docs/resources/mssql_server

Azure pricing page: https://azure.microsoft.com/en-us/pricing/details/azure-sql-database/single/

See https://github.com/infracost/infracost/issues/1138


[AutoPR batch/data-plane] typo: batch/data-plane/Microsoft.Batch

Created to sync https://github.com/Azure/azure-rest-api-specs/pull/4884

(message created by the CI based on PR content)

This PR has been merged into https://github.com/Azure/azure-sdk-for-python/pull/4031


On Mac OS, the packages/cpi/packaging script can now work properly

one issue is the following line in the script:
export GOROOT=$(readlink -nf $pkgs_dir/golang_1.3)
the readlink command has no -f option

Closing this since no longer valid I think as per @karafelix new change


Add lightweight generics

Resolves #12

thanks :+1:
there were couple warnings left though, I've fixed them


[CP Staging] Use the text View for child items on the search page

Explanation of Change
For child rows when we group expenses on the report page, use the text "View" (or corresponding translation) for the text in the Action column, to make sure we don't use the parent row's non-action label, such as "Paid".
cc @luacmartins tagging you for review because I'm not super familiar with the search page and don't know if there are other situations where we should not display "View" for child rows.
Fixed Issues
$ https://github.com/Expensify/App/issues/54131
Tests

From user A, send 2 expenses to user B
As user B, pay both of them
Go to the Search page and open the Paid section
Make sure the parent row's action reads " ✅ Paid "
Make sure the child line items' action reads "View"

Offline tests
N/A
QA Steps

From user A, send 2 expenses to user B
As user B, pay both of them
Go to the Search page and open the Paid section
Make sure the parent row's action reads " ✅ Paid "
Make sure the child line items' action reads "View"

[ ] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label and/or tagged @Expensify/design so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

MacOS: Chrome / Safari

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.


For text part, prefer quoted printable over base64

Quoted Printable is good enough for text mime portions, we don't need base64.

@amatai just fix tests please

@horkhe @russjones - please have one more look please.


Add Ordered To-Do List Type

Add a new list type called "Ordered To-Do Lists." These list types are the same as "To-Do Lists" but include index + 1 before the name (e.g., 1. Dishes). This will be useful for tasks that need to be completed in a certain order.

Hi @johneastman ,
Can I start contributing to the repository?
Thanks.

@Vaibob, yes!

Commit: https://github.com/johneastman/todo/commit/78bf14c096fb0e7a52ab2052809036cc55eff730


Chart

adding a little :nail_care: to the aside section. Just the basics at this moment.
Closes Issue #3

self approved merge


Adaptive card or other type of cards rendering issue

Hi there,
I'm a bot developer has many experience of developing chat bot by MS bot F/W in Web Chat, Facebook, and Skype. I can see both Facebook and Skype channel are not support rendering adaptive card. So, I'm quite interesting about whether the WeChat channel can render the Adaptive card or any other type of cards?
I'd like to have a discussion about this topic in this channel :-)
Happy to see any responses

Hi @CalvinFengDatacom,
It's great to hear from bot developers who have many experiences of developing chatbots like you.
About your question: does WeChat channel can render the cards?
The answer is: sorry, we can't.
That's because this adapter is for an individual account, and individual account in WeChat cannot send cards.
However, if you use the Official Account adapter, I believe there's possible to let you have cards support in WeChat, because of the Official Account support cards.
Are you working with WeChat? What kind of bot are you building?
Please let me know if you have any progress, and you can add my Wechat at 918999.
Have a nice day!

@huan Thanks for your response, we are mainly creating ChatBot on the Web channel and Facebook channel. But from our experience, we can see the adaptive card does not rendering very well in Facebook channel. So I'm curious whether WeChat supports it. Currently, we don't have any chance of creating a ChatBot on WeChat.

As far as I know, the Wechat channel will no better than the Facebook channel.
Here has a simple guide for Wechat Official Account, you can have a look at it and it might be able to give you some insights: https://walkthechat.com/wechat-official-account-simple-guide/

Hi @huan ,
Can we integrate this adapter with LUIS app?
Thanks
Sakru.

@techie921 of course, you can integrate this adapter with LUIS app.

Hi,
Have you done this before?
If so, please share code sample
Thanks,
Sakru
On Thu, Sep 5, 2019, 5:57 PM Huan (李卓桓<EMAIL_ADDRESS>wrote:

@techie921 https://github.com/techie921 of course, you can integrate
this adapter with LUIS app.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/huan/botbuilder-wechaty-adapter/issues/28?email_source=notifications&email_token=AIL4PJ4ZHRR6PBMKXJR3H4LQID3JLA5CNFSM4HHSRNOKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD565E6Y#issuecomment-528339579,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AIL4PJ7EBFECG3R7B55QSFDQID3JLANCNFSM4HHSRNOA
.

Hi @huan ,
I have tried it but could not succeed in it. Could you please share the code if you have tried it.
Thanks,
Sakru Jarpula.

@techie921 I want to share with you but I'm sorry that I have no code in my hand right now.
If you need help, please you feel free to post your full source code to this issue and I'd like to have a look on it for you.


The serialization of porphyrin to mol format introduces some double bonds with bond stereo 3/either

Describe the bug
Loading a structure containing a porphyrin into an RDKit molecule instance and rewriting it to mol format introduces some  double bonds with bond stereo 3/either
To Reproduce
In [1]: from rdkit import Chem

In [2]: print(Chem.MolToMolBlock(Chem.MolFromMolFile('./input.mol')))

input.zip
Configuration (please complete the following information):

RDKit version: current tip of the master branch (I presume the issue may also affect the 2024.03.1 beta)
OS: Fedora 39
If you are not using conda: how did you install the RDKit? from source code

Here's what's happening:
The ring bonds are all aromatic, so the fact that the stereochemistry is known is not used and they are unspecified.
The molecule is kekulized before writing it to a mol block and the writer then happily marks each of the new double bonds that are in the larger ring as unknown.
The solution is to modify the mol block writer to keep track of which bonds were originally aromatic and not write stereo tags for them.

resolved in #7510

Thank you, @greglandrum


Add link to laminar_cycle examples.

https://github.com/vic/laminar_cycle

This is awesome @vic!
I've learned a lot from cycle.js before designing Laminar, so I guess now that you can write very Cycle.js looking apps in Laminar, we have finally come full circle (full... cycle?).
Great to see such a cool pattern in Laminar 👍


Add a comprehensive component showcase page with preview for improved usability

Issue Description:
Currently, the shadcn/ui component library offers a wide range of high-quality components for integration into various projects. However, there is a missing feature that hampers the usability and discoverability of these components. It lacks a centralized page that lists every component in a visually appealing card grid style with a preview. This issue proposes the addition of a comprehensive component showcase page to enhance user experience and make it easier for developers to explore and utilize the available components efficiently.
Issue Details:
The current state of the shadcn/ui component library is quite impressive, with a diverse set of components to choose from. However, when it comes to discovering and selecting the right components for a project, developers face challenges due to the absence of a centralized showcase page.
The proposed solution is to create a new page, preferably named "Component Showcase," that displays an organized grid of cards representing each component. Each card should include a visual preview of the component along with its name. Clicking on a card should lead the user directly to the documentation or detailed information about that specific component.
Benefits:

Improved Usability: The component showcase page will provide developers with a comprehensive overview of all available components in a single place. This will make it significantly easier to browse through the component library and quickly locate the desired components, saving valuable time and effort.

Enhanced Visual Representation: By incorporating visual previews within the card grid style, developers can have a better understanding of how each component looks and behaves. This will aid in the decision-making process, ensuring that the selected components align with the desired design and functionality requirements.

Efficient Navigation: With the ability to click on a component card and be directed to its corresponding documentation or details, developers can access specific information more efficiently. This seamless transition from the showcase page to the component's dedicated page will streamline the integration process and facilitate a smoother workflow.

Promotion of the Component Library: The addition of a user-friendly component showcase page will serve as an excellent promotional tool for the shadcn/ui library. By showcasing the library's capabilities and visual appeal, it will attract more developers, increase adoption, and contribute to its overall popularity within the developer community.

The addition of this component showcase page will greatly enhance the shadcn/ui library, making it more accessible and user-friendly for developers. It will empower them to explore and utilize the components more efficiently, ultimately improving the overall development experience.
Example

have you seen this? https://ui.shadcn.com/sink

have you seen this? https://ui.shadcn.com/sink

Sure, but there not in any order which can be easily referenced as to what is being used, and where to find the material.
The image i referenced is what the page could be turned into as to provide a more developer friendly experience to find the name of the component and a easily clickable card that takes you there.

@UmbrellaCrow612 Thanks for putting this together. I've been looking into this. I'll keep you posted on updates.

@shadcn I've implemented a basic card grid in this commit, the result is not great but it's a start. All the components are still interactable and each of one of them has a clickable card header with the name and a short description. All the links and descriptions are to be implemented. Let me know if I'm on the right track and I will finish this task.
Screenshots of dark & light mode

You could go either way for DX, having the actual component there or a placeholder type image that represents it. Similar to the image I provided.

@UmbrellaCrow612 Yeah probably images are for the best. I do think that with a little bit of work on some demo widgets for this page specifically (i.e. shrinking the ones that are too tall or have too much content) the result would be fine. The fact that you can interact briefly with the component before opening its spec to me it's an added bonus.

Tidied up some widgets to make a more uniform grid in the latest commit. Here are the results:

Test
comment

ds
sd

This issue has been automatically closed because it received no activity for a while. If you think it was closed by accident, please leave a comment. Thank you.


Error setting up entry {ADDRESS}

When i try to setup the integration after install through HACS, i get the following error, and no data:
Logger: homeassistant.config_entries
Source: custom_components/renoweb/__init__.py:86
First occurred: 7:54:10 PM (2 occurrences)
Last logged: 8:07:25 PM

Traceback (most recent call last):
  File "/usr/src/homeassistant/homeassistant/config_entries.py", line 231, in async_setup
    result = await component.async_setup_entry(hass, self)  # type: ignore
  File "/config/custom_components/renoweb/__init__.py", line 86, in async_setup_entry
    await renoweb.get_pickup_data()
  File "/usr/local/lib/python3.8/site-packages/pyrenoweb/client.py", line 187, in get_pickup_data
    next_pickup = datetime.date.fromtimestamp(int(row.get("nextpickupdatetimestamp")))
ValueError: invalid literal for int() with base 10: ''

Let me know if you need anything from me.

Seems like I don’t get a numeric time stamp for your address, and then it fails when I try to convert to a date. I know you can extract the raw data yourself. Would be helpful if you could do this, and post it here - or mail me your address on<EMAIL_ADDRESS>Then I can check the raw data and see why the data for your address is different from mine.

Hi again,
I found an address that gives the same error, so I now have something to test with. Stay tuned and I will fix this

There is now a release 0.1.2, that should fix this. Please report back if you get the right number of sensors and verify that the dates are correct.

Works for me now. Got the expected sensors and days. 👍

Works like a charm!
Fantastic work.
Please feel free to reach out to me if you need something.

Works like a charm!
Fantastic work.
Please feel free to reach out to me if you need something.

Great it works now. When/If the API changes and/or the API keys changes, I will need your help in sniffing out this again. Thanks.


API Quota Reached

The Google API Quota is 10,000.  If I leave my MagicMirror alone all day it gets high, but doesnt hit it. But if im working on another module and restart MM a number of times, I hit the API quota.  Why is it hitting the API so many times?  Shouldnt it grab a list of photos in one call? and then call once per photo load?  Is it calling the API for every photo when it may not even show that photo that day?  I have an album with alot of photos in it.

I increased the page size to 500, and I think that will help me out...  Can you make the page size adjustable from the config?

When you start MM every time, the module will get the album list and the images list from each album. The modules scans selected albums and get the images list per hour. Usually it is within 500 requests per day.

Refer to the API docs, the recommended page size is 50 and the maximum page size is 100 so there is useless to make as configurable.
https://developers.google.com/photos/library/guides/list


OptimizerLRScheduler typing does not fit examples

Bug description
The return type of LightningModule.configure_optimizers() is OptimizerLRScheduler, see the source code. However, the examples give return types not fitting this return type. See e.g. the example here.
Furthermore, the OptimizerLRScheduler is only used as a return type, but I don't see where it is actually used, i.e. the other part of the typed interface. A search for it does not reveal it.
What version are you seeing the problem on?
2.3.1
How to reproduce the bug
Just run mypy on an example, e.g. https://github.com/Lightning-AI/pytorch-lightning/blob/e6c26d2d22fc4678b2cf47d57697ebae68b09529/examples/fabric/build_your_own_trainer/run.py#L42-L49.
Error messages and logs
Running mypy on this causes a bug:
Error: Incompatible return value type (got "tuple[Adam, dict[str, object]]", expected "Optimizer | Sequence[Optimizer] | tuple[Sequence[Optimizer], Sequence[LRScheduler | ReduceLROnPlateau | LRSchedulerConfig]] | OptimizerLRSchedulerConfig | Sequence[OptimizerLRSchedulerConfig] | None")

Environment

Current environment

CUDA:
- GPU:               None
- available:         False
- version:           None
Lightning:
- lightning-utilities: 0.11.3.post0
- pytorch-lightning: 2.3.1
- torch:             2.3.1
- torchmetrics:      0.8.0
- torchvision:       0.18.1
Packages:
- absl-py:           2.1.0
- aenum:             3.1.15
- aiohttp:           3.9.5
- aiosignal:         1.3.1
- alabaster:         0.7.16
- albumentations:    1.3.1
- antlr4-python3-runtime: 4.9.3
- arabic-reshaper:   3.0.0
- asn1crypto:        1.5.1
- async-timeout:     4.0.3
- attrs:             23.2.0
- babel:             2.15.0
- boto3:             1.34.137
- botocore:          1.34.137
- build:             1.2.1
- certifi:           2024.6.2
- cffi:              1.16.0
- charset-normalizer: 3.3.2
- click:             8.1.7
- coloredlogs:       15.0.1
- contourpy:         1.2.1
- coverage:          5.3.1
- cryptography:      42.0.8
- cssselect2:        0.7.0
- cycler:            0.12.1
- data-gradients:    0.3.2
- deprecated:        1.2.14
- docutils:          0.17.1
- einops:            0.3.2
- exceptiongroup:    1.2.1
- filelock:          3.15.4
- flatbuffers:       24.3.25
- fonttools:         4.53.0
- frozenlist:        1.4.1
- fsspec:            2024.6.1
- future:            1.0.0
- grpcio:            1.64.1
- html5lib:          1.1
- huggingface-hub:   0.23.4
- humanfriendly:     10.0
- hydra-core:        1.3.2
- idna:              3.7
- imagededup:        0.3.1
- imageio:           2.34.2
- imagesize:         1.4.1
- iniconfig:         2.0.0
- jinja2:            3.1.4
- jmespath:          1.0.1
- joblib:            1.4.2
- json-tricks:       3.16.1
- jsonschema:        4.22.0
- jsonschema-specifications: 2023.12.1
- kiwisolver:        1.4.5
- lazy-loader:       0.4
- lightly:           1.5.8
- lightly-train:     0.1.0
- lightly-utils:     0.0.2
- lightning-utilities: 0.11.3.post0
- lxml:              5.2.2
- markdown:          3.6
- markdown-it-py:    3.0.0
- markupsafe:        2.1.5
- matplotlib:        3.9.0
- mdurl:             0.1.2
- mpmath:            1.3.0
- multidict:         6.0.5
- mypy:              1.10.1
- mypy-extensions:   1.0.0
- networkx:          3.3
- numpy:             1.23.0
- omegaconf:         2.3.0
- onnx:              1.15.0
- onnxruntime:       1.15.0
- onnxsim:           0.4.36
- opencv-python:     <IP_ADDRESS>
- opencv-python-headless: <IP_ADDRESS>
- oscrypto:          1.3.0
- packaging:         24.1
- pandas:            2.2.2
- pillow:            10.4.0
- pip:               24.1.1
- pip-tools:         7.4.1
- platformdirs:      4.2.2
- pluggy:            1.5.0
- protobuf:          3.20.3
- psutil:            6.0.0
- pycparser:         2.22
- pydantic:          1.10.17
- pydeprecate:       0.3.2
- pygments:          2.18.0
- pyhanko:           0.25.0
- pyhanko-certvalidator: 0.26.3
- pyparsing:         3.1.2
- pypdf:             4.2.0
- pypng:             0.20220715.0
- pyproject-hooks:   1.1.0
- pytest:            8.2.2
- pytest-mock:       3.14.0
- python-bidi:       0.4.2
- python-dateutil:   2.9.0.post0
- pytorch-lightning: 2.3.1
- pytz:              2024.1
- pywavelets:        1.6.0
- pyyaml:            6.0.1
- qrcode:            7.4.2
- qudida:            0.0.4
- rapidfuzz:         3.9.3
- referencing:       0.35.1
- reportlab:         3.6.13
- requests:          2.32.3
- rich:              13.7.1
- rpds-py:           0.18.1
- ruff:              0.5.0
- s3transfer:        0.10.2
- safetensors:       0.4.3
- scikit-image:      0.24.0
- scikit-learn:      1.5.0
- scipy:             1.13.1
- seaborn:           0.13.2
- selftrain:         0.1.0
- setuptools:        70.2.0
- six:               1.16.0
- snowballstemmer:   2.2.0
- sphinx:            4.0.3
- sphinx-rtd-theme:  1.3.0
- sphinxcontrib-applehelp: 1.0.8
- sphinxcontrib-devhelp: 1.0.6
- sphinxcontrib-htmlhelp: 2.0.5
- sphinxcontrib-jquery: 4.1
- sphinxcontrib-jsmath: 1.0.1
- sphinxcontrib-qthelp: 1.0.7
- sphinxcontrib-serializinghtml: 1.1.10
- stringcase:        1.2.0
- super-gradients:   3.7.1
- svglib:            1.5.1
- sympy:             1.12.1
- tensorboard:       2.17.0
- tensorboard-data-server: 0.7.2
- termcolor:         1.1.0
- threadpoolctl:     3.5.0
- tifffile:          2024.6.18
- timm:              1.0.7
- tinycss2:          1.3.0
- tomli:             2.0.1
- torch:             2.3.1
- torchmetrics:      0.8.0
- torchvision:       0.18.1
- tqdm:              4.66.4
- treelib:           1.6.1
- typing-extensions: 4.12.2
- tzdata:            2024.1
- tzlocal:           5.2
- uritools:          4.0.3
- urllib3:           2.2.2
- webencodings:      0.5.1
- werkzeug:          3.0.3
- wheel:             0.43.0
- wrapt:             1.16.0
- xhtml2pdf:         0.2.11
- yarl:              1.9.4
System:
- OS:                Darwin
- architecture:
- 64bit
-
- processor:         arm
- python:            3.10.8
- release:           23.5.0
- version:           Darwin Kernel Version 23.5.0: Wed May  1 20:12:58 PDT 2024; root:xnu-10063.121.3~5/RELEASE_ARM64_T6000

More info
No response

Hey @MalteEbner
The optimizer should be inside the dict in that example. Thank you for noticing it. Would you like to send a PR with this quick fix? Would be much appreciated 😃

Hey @MalteEbner The optimizer should be inside the dict in that example. Thank you for noticing it. Would you like to send a PR with this quick fix? Would be much appreciated 😃

Unfortunately, the problem is not that the example is wrong. This is just a symptom of an underlying problem. The problem is that the LightningModule.configure_optimizers() -> OptimizerLRScheduler typing is wrong.
Toe see why, have a look at where configure_optimizers() is used, see the source code here: The output of it is stored under the variable name optim_conf and then passed to the function
def _configure_optimizers(
    optim_conf: Union[Dict[str, Any], List, Optimizer, Tuple],
)

However, these types don't align. What should be done instead:

Change it to optim_conf: OptimizerLRScheduler, so that the usage of configure_optimizers() has the same type as its definition.
Redefine the OptimizerLRScheduler such that it fits the supported types in _configure_optimizers.

I'm not seeing any mypy errors regarding this. Which version did you use and what was the command you ran? The version we test with you can see here: https://github.com/Lightning-AI/pytorch-lightning/blob/master/requirements/typing.txt
We typically bump it together when an new torch version comes out (which is soon again). Maybe your issue will show up, but I'm not seeing it locally.
Yes sure, the internal _configure_optimizers uses a bit more generic typing. Feel free to update it to be more specific. The LightningModule.configure_optimizers() should not be changed, this looks all good to me.

this PR fixes the example, ptal! https://github.com/Lightning-AI/pytorch-lightning/pull/20420


Fix for Dependency injection doesn't handle inheritance

fix for #216

Thanks @LunicLynx! This is now merged. Great to get this fixed :)

Isn't this what BindingFlags.FlattenHierarchy does?

@khellang I thought so too, but it only applies to public members. We want to include private and protected too.

Ah. Well, it includes protected, but not private (from base class):
using System;
using System.Reflection;

public class A
{
	public int PublicA { get; set; }

	protected int ProtectedA { get; set; }

	internal int InternalA { get; set; }

	private int PrivateA { get; set; }
}

public class B : A
{
	public int PublicB { get; set; }

	protected int ProtectedB { get; set; }

	internal int InternalB { get; set; }

	private int PrivateB { get; set; }
}

public class Program
{
	public static void Main()
	{
		const BindingFlags flags = BindingFlags.Instance | BindingFlags.Public | BindingFlags.NonPublic | BindingFlags.FlattenHierarchy;

		foreach (var property in typeof(B).GetProperties(flags))
		{
			Console.WriteLine(property.Name);
		}
	}
}

Outputs:
PublicB
ProtectedB
InternalB
PrivateB
PublicA
ProtectedA
InternalA

Runnable example: https://dotnetfiddle.net/12Fg1k

@khellang I had the same idea. But as @SteveSandersonMS says that does not work.
I think that this isn't easily supported seems like an oversight in the api. Doing it this way returns the public properties several times, which is why the must be filtered with .Where(prop => prop.ReflectedType == prop.DeclaringType).
It would be nice to have a method GetDeclaredProperties with BindingFlags.

There's also typeof(Blah).GetTypeInfo().GetRuntimeProperties(), which seems to return the same results 😄

Yes, the docs for that seem wrong or at least very misleading:

This method returns all properties defined on the specified type, including inherited, non-public, instance, and static properties - https://msdn.microsoft.com/en-us/library/system.reflection.runtimereflectionextensions.getruntimeproperties(v=vs.110).aspx

It returns properties that are inherited, and ones that are non-public, but not ones that are both inherited and nonpublic.


The "confiance" can not be updated?

Hello, author.I find the problem that there is something wrong in code "confiance[py, px] = compteur / taille_psi_p"  because I print the "confiance", it's value is 0. What's the problem, please?The "confiance" can not be updated?

I find the problem. Because type(confiance) is <class 'numpy.uint8'> in my computer.


About behavior HTTPException of sub-applications

First Check

[X] I added a very descriptive title to this issue.
[X] I used the GitHub search to find a similar issue and didn't find it.
[X] I searched the FastAPI documentation, with the integrated search.
[X] I already searched in Google "How to X in FastAPI" and didn't find any information.
[X] I already read and followed all the tutorial in the docs and didn't find an answer.
[X] I already checked if it is not related to FastAPI but to Pydantic.
[X] I already checked if it is not related to FastAPI but to Swagger UI.
[X] I already checked if it is not related to FastAPI but to ReDoc.

Commit to Help

[X] I commit to help with one of those options 👆

Example Code
from fastapi import FastAPI, Depends, HTTPException
from fastapi.responses import JSONResponse
from starlette.middleware.cors import CORSMiddleware

app = FastAPI()
app.add_middleware(
    CORSMiddleware,
    allow_origins=['*'],
    allow_credentials=True,
    allow_methods=['*'],
    allow_headers=['*'],
    expose_headers=['*'],
)

sub = FastAPI()

@sub.get('/', status_code=200)
async def get():
    raise HTTPException(400, 'error handling sub app')

async def http_exception_handler(_, exc):
    return JSONResponse(exc.detail, status_code=exc.status_code)

# not working
app.add_exception_handler(HTTPException, http_exception_handler)

# working
# sub.add_exception_handler(HTTPException, http_exception_handler)

app.mount('/sub', sub)

@app.get('/healthcheck', status_code=200)
async def healthcheck():
    return 'health check'

Description
I expect response of GET /sub endpoint is "error handling sub app".
But I got {detail: "error handling sub app"}.
The cause of this, http exception handler attached to root app will not handling sub-app exceptions.
Actually, http exception handler attached to sub app worked fine.
Is this intended behavior?
Operating System
macOS
Operating System Details
MacOS Monterey v 12.3.1
FastAPI Version
0.80.0
Python Version
Python 3.10.4
Additional Context
No response

I think it should be that way. Your exception handlers should be at app level, and not global?🤔

It's intended.

fm...
If the middleware attached to root app, effects are reach sub app, But custom error handling will not reach.
I think error handling behavior should be same range as middleware, what do you think?
(or specify error handling range in here. https://fastapi.tiangolo.com/advanced/sub-applications/)

I think error handling behavior should be same range as middleware, what do you think?

I'm not sure if this is the right justification. I think middleware sits between your apps and the server, while your exception handlers are within your app's scope.

Sure, I'm not particularly troubled at this behavior, If that is intended, It's ok.

Sure, I'm not particularly troubled at this behavior, If that is intended, It's ok.


SSI-DNN/keras_yolov8n_640x640 model not found

Issue Type
Bug
Source
pip (model-compression-toolkit)
MCT Version
2.2.0
OS Platform and Distribution
MacOS 13.2.1
Python version
3.11.5
Describe the issue
Running example_keras_yolov8n.ipynb:
from huggingface_hub import from_pretrained_keras
model = from_pretrained_keras('SSI-DNN/keras_yolov8n_640x640')

Got this error:

Repository Not Found for url: https://huggingface.co/api/models/SSI-DNN/keras_yolov8n_640x640/revision/main.
Please make sure you specified the correct repo_id and repo_type.
If you are trying to access a private or gated repo, make sure you are authenticated.
Invalid username or password.

This model is unavailable on Hugging Face.
Expected behaviour
No response
Code to reproduce the issue
from huggingface_hub import from_pretrained_keras
model = from_pretrained_keras('SSI-DNN/keras_yolov8n_640x640')

Log output
---------------------------------------------------------------------------
HTTPError                                 Traceback (most recent call last)
File ~/anaconda3/lib/python3.11/site-packages/huggingface_hub/utils/_errors.py:259, in hf_raise_for_status(response, endpoint_name)
    [258](https://file+.vscode-resource.vscode-cdn.net/Users/tiffanyz/Desktop/LeopardImaging/model_optimization-2.2.1/tutorials/notebooks/mct_features_notebooks/keras/~/anaconda3/lib/python3.11/site-packages/huggingface_hub/utils/_errors.py:258) try:
--> [259](https://file+.vscode-resource.vscode-cdn.net/Users/tiffanyz/Desktop/LeopardImaging/model_optimization-2.2.1/tutorials/notebooks/mct_features_notebooks/keras/~/anaconda3/lib/python3.11/site-packages/huggingface_hub/utils/_errors.py:259)     response.raise_for_status()
    [260](https://file+.vscode-resource.vscode-cdn.net/Users/tiffanyz/Desktop/LeopardImaging/model_optimization-2.2.1/tutorials/notebooks/mct_features_notebooks/keras/~/anaconda3/lib/python3.11/site-packages/huggingface_hub/utils/_errors.py:260) except HTTPError as e:

File ~/anaconda3/lib/python3.11/site-packages/requests/models.py:1024, in Response.raise_for_status(self)
   [1023](https://file+.vscode-resource.vscode-cdn.net/Users/tiffanyz/Desktop/LeopardImaging/model_optimization-2.2.1/tutorials/notebooks/mct_features_notebooks/keras/~/anaconda3/lib/python3.11/site-packages/requests/models.py:1023) if http_error_msg:
-> [1024](https://file+.vscode-resource.vscode-cdn.net/Users/tiffanyz/Desktop/LeopardImaging/model_optimization-2.2.1/tutorials/notebooks/mct_features_notebooks/keras/~/anaconda3/lib/python3.11/site-packages/requests/models.py:1024)     raise HTTPError(http_error_msg, response=self)

HTTPError: 401 Client Error: Unauthorized for url: https://huggingface.co/api/models/SSI-DNN/keras_yolov8n_640x640/revision/main

The above exception was the direct cause of the following exception:

RepositoryNotFoundError                   Traceback (most recent call last)
Cell In[10], [line 5](vscode-notebook-cell:?execution_count=10&line=5)
      [1](vscode-notebook-cell:?execution_count=10&line=1) # !pip install --upgrade bottleneck
      [3](vscode-notebook-cell:?execution_count=10&line=3) from huggingface_hub import from_pretrained_keras
----> [5](vscode-notebook-cell:?execution_count=10&line=5) model = from_pretrained_keras('SSI-DNN/keras_yolov8n_640x640') # Ultralytics/YOLOv8
      [6](vscode-notebook-cell:?execution_count=10&line=6) print(model.summary())

File ~/anaconda3/lib/python3.11/site-packages/huggingface_hub/keras_mixin.py:273, in from_pretrained_keras(*args, **kwargs)
    [217](https://file+.vscode-resource.vscode-cdn.net/Users/tiffanyz/Desktop/LeopardImaging/model_optimization-2.2.1/tutorials/notebooks/mct_features_notebooks/keras/~/anaconda3/lib/python3.11/site-packages/huggingface_hub/keras_mixin.py:217) def from_pretrained_keras(*args, **kwargs) -> "KerasModelHubMixin":
    [218](https://file+.vscode-resource.vscode-cdn.net/Users/tiffanyz/Desktop/LeopardImaging/model_optimization-2.2.1/tutorials/notebooks/mct_features_notebooks/keras/~/anaconda3/lib/python3.11/site-packages/huggingface_hub/keras_mixin.py:218)     r"""
...

Repository Not Found for url: https://huggingface.co/api/models/SSI-DNN/keras_yolov8n_640x640/revision/main.
Please make sure you specified the correct `repo_id` and `repo_type`.
If you are trying to access a private or gated repo, make sure you are authenticated.
Invalid username or password.

Hi @Tiffanyxk3 ,
Thank you for your feedback.
To make the deployment process more easy and accessible across a range of tasks, we’re collaborating with Ultralytics to simplify model export. This integration will replace our tutorials and example models you mentioned, offering a much easier way to export Ultralytics models to our device. Additionally, it allows you to re-train the model on your custom dataset before exporting. For more information, please visit
IMX500 Export for Ultralytics YOLOv8 - Ultralytics YOLO Docs
Thanks
Idan


Support INVITE_CREATE

Every time someone creates an invite a line gets printed saying:
UNKNOWN_OPCODE: {"t":"INVITE_CREATE", ... }

It would be nice to have an onInviteCreated

https://github.com/l7ssha/nyxx/wiki#attention - Its implementaed in rewrite_modular branch - Not yet released because of implications of current dart support of nnbd and lacks of tooling.


Consuming @xstate/compiled/react in monorepo

Here is the minimal repo that shows this problem: https://github.com/FredyC/xstate-codegen-monorepo
yarn install
yarn machinery codegen
yarn web validate

I have no idea why it should be a problem considering @xstate/compiled exists in root node_modules.

In the branch use-paths I tried a slightly different approach with path aliases, but the outcome is the same.

Oh wait, I just noticed that @xstate/compiled has been written to modules/machinery/node_modules instead of a root one. Well, that explains it...

I have figured ugly workaround, in the modules/web/package.json I've added this and it works.
"@xstate/compiled": "file:../machinery/node_modules/@xstate/compiled",

I am not sure how a proper solution should look like.

Well, that wasn't the right workaround either. When I modified that machine it went haywire.
So I ended up moving codegen execution to root. It will correctly output to root node_modules and behaves correctly.
I suppose ultimately it's the right solution and documenting it should be good enough.

OK, to fix this we should probably add a --cwd flag that allows you to pick the current working directory. This wouldn't be too hard to implement/document. What do you think?

Yea, that could certainly help as well.

@FredyC Here's a PR which might help with the above:
https://github.com/mattpocock/xstate-codegen/pull/50/files


[BUG] showing multiple scrollbars in sidebar

Description
I have just noticed that its showing two scrollbars on sidebar which kinda weird
Screenshots

Any additional information?
No response
What browser are you seeing the problem on?
No response
Checklist

[X] I have checked the existing issues
[X] I have read the Contributing Guidelines
[ ] I am willing to work on this issue (optional)
[ ] I am a GSSoC'23 contributor

I'd love to work on this issue

I'd love to work on this issue

Sure, thanks. Assigning to you!

I'd love to work on this issue

Are you a gssoc contributor?

I'd love to work on this issue

Are you a gssoc contributor?

Nope
But I've contributed to linkshub repo before

Description
I have just noticed that its showing two scrollbars on sidebar which kinda weird
Screenshots

Any additional information?
No response
What browser are you seeing the problem on?
No response
Checklist

[x]  I have checked the existing issues
[x]  I have read the Contributing Guidelines
[ ]  I am willing to work on this issue (optional)
[ ]  I am a GSSoC'23 contributor

I am unable to reproduce this error (looks like it has been fixed in another PR)
kindly refresh your browser and close this issue as this issue no longer exist

I see, thanks


[54714, 54708] Android: Fixed page order announcement and accessibility traversal in welcome pages

@jonasofrich Remember to update the excel sheet accordingly.


[FR] SSL support

Hi,
would it be possible to add SSL support for querying clickhouse ?
Ralph

Hey. TBH, I don't see a reason for it. If you really need it, just put nginx/any other reversed proxy in front of it.
In our case, GCH is placed behind the carbonapi on the same host, so it uses localhost.

For sure there are many ways. But it would be easier in some cases to configure url = "https://
Just my opinion, but I'm fine with it.
Ralph

Sorry for my natural blindness. I've read the ticket as support of https serving on the graphite-clickhouse site.
There's no reason why querying CH shouldn't work. In my environment, it works perfectly. Here's my URL from the production config:
url = "https://user:password@hostname:8443/?cancel_http_readonly_queries_on_client_close=1"

What particular issues do you have?

I wasn't aware that it's possible to connect to https. Now after trying it ...
x509: certificate is not valid for any names, but wanted to match localhost
or with FQDN
x509: certificate relies on legacy Common Name field, use SANs or temporarily enable Common Name matching with GODEBUG=x509ignoreCN=0"
I'm using self signed certificates with FQDN as CN.
Ralph

@ralphM78 : try what second option suggest - use FQDN and set GODEBUG=x509ignoreCN=0 env variable. No sure is it has any performance implications, though.

@ralphM78 : PS: Another useful option - ditch out self sign certs and use proper cert using "Let's encrypt" but proper implementation needs to be automated ofc.

I have played around a little bit and now it's working.
Option 1 is to add Environment=GODEBUG=x509ignoreCN=0 through systemd. But not sure if this will work with future versions of go.
Option 2 is to create SSL certs with Subject Alternative Names (SAN). If one of the SAN is localhost, the url = https://localhost:8443 option will work also. Otherwise use FQDN. The system must of course trust the CA.
Ralph

What's the actual meaning of querying the same host with ssl? It causes a handshake overhead for every query. I wouldn't suggest doing it.
If it's network transmitted data, the best thing is a valid certificate, or at least a company-wide trusted one that every node knows.

Querying localhost with SSL makes no sense so far. I only have tested it. Another case could be disabling http <http_port remove="remove">8123</http_port> for the entire clickhouse cluster and only use encrypted traffic. Maybe a company-wide instruction or something like that.
This problem wasn't about an invalid certificate. The certificate is valid. It was about the missing usage of SAN for the certificate. This can happen with Letsencrypt certificates also, if there is no SAN.
Ralph


Research existing plugins to align on UQI goals for Databases

The comprehensive plugin level document for UQI : https://www.notion.so/appsmith/Unified-Query-Interface-For-DB-Plugins-cca4b0c8669949568a00f1e516b62fa8

This is done. Closing this.


Added missing reason phrases and descriptions, made lists consistent

What

Made lists of reason phrases and descriptions consistent
Added reason phrases and descriptions for additional codes covered by RFCs

Why
See discussion in issue #303.
Details
none
Notes
none
Related Issue: #303.

By the way, you should consider merging RESPONSE_CODE_REASONS and RESPONSE_CODE_DESCRIPTIONS to reduce the risk of the lists becoming inconsistent again.


No deceleration when approaching stop point with velocity override

New Path.path.txt
Replication path above.
Steps to reproduce:

Have a path with 3+ waypoints.
Add a velocity override to the middle one (I used 1 m/s) above
Mark the middle point as a stop point.
Watch the robot fail to decelerate before stopping at the middle waypoint. The velocity graph backs this up.

Set the middle point as a reversal (and not a stop), see a similar graph. Set it to reversal and stop, and the graph is the same as reversal.

All three cases exhibit some sort of conflict between the velocity override and the reversal/stop making velocity be 0.
Expected Behavior:
Reversal and stop points should completely ignore any provided velocity override, and the trajectory should decelerate to 0 ahead of the point.

Its a weird edge case caused by how stop points used to work internally, the override velocity is only being applied to the start point of the second path. All of this is changed in the 2024 version as the concepts of velocity override, stop points, and reversal points have all been replaced by a zoned constraints system and modular paths, so this bug isn't present anymore.


should we add logic to add additional token rewards? [discussion]

We can use the function rewardDepositors will add more tokens to the pool without creating shares, so that effectively these extra tokens are distributed over existing share holders. In that case, no new functionality is needed.

We can use this as a kind of primitive reward system by sending rewards to the contract every 24 hours (say)
The alternative is to create an actual reward program and logic in the same way as hats rewards are now being calculated.

but we would like to have a system where depositors get a reward proportional to the time they stake

yes


Unbounded height constraints when put as part of Sliver

Hi, I am trying to add the DayView in a Sliver, but whatever I try, I get one or other variation of "unbounded height constraints".
Code and exception below:
`Widget getCalendarView() {
return SliverList(
  delegate: SliverChildBuilderDelegate(
    (BuildContext context, int index) {
      return SingleChildScrollView(
        child: DayView(
          controller: EventController(),
        ),
      );
    },
    childCount: 1,
  ),
);

}`
I was looking for a way to declare that I want to shrink-wrap the DayView, but found none... any ideas?
Thanks and best regards
Kras
Exception:
The following assertion was thrown during performLayout():
RenderFlex children have non-zero flex but incoming height constraints are unbounded.
When a column is in a parent that does not provide a finite height constraint, for example if it is in a vertical scrollable, it will try to shrink-wrap its children along the vertical axis. Setting a flex on a child (e.g. using Expanded) indicates that the child is to expand to fill the remaining space in the vertical direction.
These two directives are mutually exclusive. If a parent is to shrink-wrap its child, the child cannot simultaneously expand to fit its parent.
Consider setting mainAxisSize to MainAxisSize.min and using FlexFit.loose fits for the flexible children (using Flexible rather than Expanded). This will allow the flexible children to size themselves to less than the infinite remaining space they would otherwise be forced to take, and then will cause the RenderFlex to shrink-wrap the children rather than expanding to fit the maximum constraints provided by the parent.
If this message did not help you determine the problem, consider using debugDumpRenderTree():
https://flutter.dev/debugging/#rendering-layer
http://api.flutter.dev/flutter/rendering/debugDumpRenderTree.html
The affected RenderFlex is: RenderFlex#408be relayoutBoundary=up17 NEEDS-LAYOUT NEEDS-PAINT NEEDS-COMPOSITING-BITS-UPDATE
parentData:  (can use size)
constraints: BoxConstraints(w=411.4, 0.0<=h<=Infinity)
size: MISSING
direction: vertical
mainAxisAlignment: start
mainAxisSize: min
crossAxisAlignment: start
textDirection: ltr
verticalDirection: down
child 1: RenderDecoratedBox#419af NEEDS-LAYOUT NEEDS-PAINT NEEDS-COMPOSITING-BITS-UPDATE
parentData: offset=Offset(0.0, 0.0); flex=null; fit=null
constraints: MISSING
size: MISSING
decoration: BoxDecoration
color: Color(0xffdcf0ff)
configuration: ImageConfiguration(bundle: PlatformAssetBundle#b0938(), devicePixelRatio: 2.6, locale: en_US, textDirection: TextDirection.ltr, platform: android)
child: RenderClipPath#eb64c NEEDS-LAYOUT NEEDS-PAINT NEEDS-COMPOSITING-BITS-UPDATE
parentData:
constraints: MISSING
size: MISSING
child: RenderFlex#84689 NEEDS-LAYOUT NEEDS-PAINT NEEDS-COMPOSITING-BITS-UPDATE
parentData:
constraints: MISSING
size: MISSING
direction: horizontal
mainAxisAlignment: spaceBetween
mainAxisSize: max
crossAxisAlignment: center
needs compositing
parentData:
constraints: MISSING
size: MISSING
usefulness ratio: no metrics collected yet (never painted)
child: _RenderScrollSemantics#2aff5 NEEDS-LAYOUT NEEDS-PAINT NEEDS-COMPOSITING-BITS-UPDATE
parentData:
constraints: MISSING
semantic boundary
size: MISSING
The creator information is set to: Column ← DecoratedBox ← SizedBox ← MediaQuery ← Padding ← SafeArea ← DayView ← _SingleChildViewport ← IgnorePointer-[GlobalKey#33e91] ← Semantics ← Listener ← _GestureSemantics ← ⋯

Hello @kkondarev, You are using a scollable widget (DayView), inside scrollable widget (SingleChildScrollView), inside a sliver scollable (SliverList). That's why it's giving you unbounded height error and DayView is already scrollable so you don't have to wrap it with singlechildscrollview to make it scrollable.
So, First instead of using singlechildscrollview and sliverlist, use SliverToBoxAdapter. SliverToBoxAdapter takes a normal widget and it can be used as sliver. Or use SliverFillRemaining it also takes a normal widget and can be used as sliver.

@kkondarev I'm closing this issue for now. Feel free to reopen this issue if you are still facing it.


What were the QEMU bugs?

You mentioned that your client worked around some QEMU bugs, but you don't mention what any of them were. Just curious what those might be?

Some weird stream corruptions. Blocks would be dropped seemingly at random when they should have been refreshed after, say, moving the mouse over them, glitched out display, stuff like that. I dunno what the actual bug is, what little I've seen of QEMU VNC code seemed sane.


Add login page (that doesn't work yet)

closes #147
Next step would be #148, to make login work.
Again, there was a lot in common with https://github.com/MoveOnOrg/mop-frontend/blob/master/src/components/register-form.js

Thanks for the review! Should be good now.