Add sed fix

All vars used in sed commands wrapped in double quotes
Fixed error:

sed: -e expression #1, char 21: unterminated `s' command

E: Version '1.13.1-0~ubuntu-trusty' for 'docker-engine' was not found
Damn Again. Why not remove the version lock.

@mdzidic Please make changes against master branch.

@djdefi Any plans to cherry-pick those fixes into older release branch?

@wfjsw This problem is already fixed in master branch...
When I start Docker image from master branch it reports 2.5.0-dev version, then I tried 2.3 but sed crashes and I committed this fix :)

Opened #228 which would backport changes from master to 2.3 branch. I could then build a new docker hub image from that / make a new 2.3 tag?

@djdefi That will be great

I think we also have to make a clear statement that only the latest versioned tag and the tag latest will receive further updates for here as well as upstream.

A new Docker hub tag :2.3-latest has been created, which will build from the 2.3 branch. This is sort of somewhere between a stable release and an unstable dev branch.


KAFKA-10227: Enforce cleanup policy to only contain compact or delete once

https://issues.apache.org/jira/browse/KAFKA-10227
This patch fixes both TopicCommand and ConfigCommand. When duplicate items are specified in cleanup.policy, they will be removed automatically and then applied.
More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.
Summary of testing strategy (including rationale)
for the feature or bug fix. Unit and/or integration
tests are expected for any behaviour change and
system tests should be considered for larger changes.
Committer Checklist (excluded from commit message)

[ ] Verify design and implementation
[ ] Verify test coverage and CI build status
[ ] Verify documentation (including upgrade notes)

Seems it failed by an unrelated issue tracked in KAFKA-10017 .

@huxihx Thanks for the PR. Have you considered doing this in the broker? Doing it in the broker has the advantage that it would work for all the clients in the ecosystem.

@dajac Thank you for the comment. Well, it is quite tempting to put all the check things on the broker side. However, we should still have the current tools refined to be robust enough. TopicCommand and ConfigCommand are the most popular tools to add configs for topics.  Maybe we could open a new PR to do something great on the broker side later on. What do you think?

@huxihx I agree that improving TopicCommand and ConfigCommand is a good thing. I think that we have to be cautious with having generic validations in the clients though as it could bit us in the future. By doing the validation in the broker, we also improve them indirectly ;).

@huxihx As @dajac mentioned, I also envisioned doing this check on the broker side.
I actually initially hit this issue with a 3rd party client and just included the kafka-topics command in the ticket to easily reproduce it.

@mimaison @dajac If that's the case, I agree to move the logic into broker side. However, I suggest we keep the current refinement in TopicCommand and ConfigCommand since these tools should be capable of doing some pre-processing. What do you think？

@huxihx I am not against improving the command line but I think that the approach that you are proposing in this PR is a bit risky for the future. Please, take a look at my previous comment and let me know what you think.

@dajac @mimaison  Thanks for the comments. Please review again.

Ping @omkreddy @mimaison for review.

@abbccdda Hi, do you have any time to review this patch? It's been quite a long time since no one had a look at it :(

@huxihx can you rebase your PR? Thanks


Concatinating path name

Actually I'm not really sure whether this is a bug or just happening because of me lacking in advanced React skills...
My app base is /path. By using the function multiPushInUrlQuery the pathname gets continually concatinated to my url, e.g. if my URL was http://localhost/path the url transforms to http://localhost/path/path after using the mentioned function. I finally ended up setting the pathname property of the newLocation object to '/' manually within the multiUpdateInLocation function (updateUrlQuery.js). I've also set the basename to /path when creating my history object and there's a base tag set to /path in my HTML file.
I'm using the current version of react-url-query.

oooh thanks for finding this! I'm currently away on vacation but when I get a minute I'll see if I can patch it.

Hi @maettyhawk, do you have a code repo I can see to reproduce this or can you put together a minimal example that exhibits the problem?

Hi @pbeshai, sorry, there's no code repo I could share with you besides a modified copy of the module published on npm (react-url-query-fixed-basename). which I'll obviously delete after the problem is solved. I started my project using create-react-app, but in order to configure the basename we ejected it to unveil the hidden webpack configurations. Maybe we did something wrong, but we somehow managed to get to run the app both on the root (http://hostname/) and also using a basename (http://hostname/basename). We're using react-url-query for a filter mechanism, any single filter is represented by a query param (f.e. age=13_40 or name=Scott). The already mentioned bug appears every time I try to use the multiPushInUrlQuery function in the environment using a basename. The basename gets concatinated to the uri everytime the function gets triggered. What I did to solve the problem in my case was to replace the basename in the pathname property of newLocation with '/'. Actually I'm replacing just the first instance by using the replace function.
I could try to reproduce the error within a test project if you need more details.

Honestly, I don't think this is a bug. I double-checked within a blank project and it seems to work.

Ok, thanks for following up!


Update serde to 0.7

Updates serde to 0.7. As noted in #24, this is a breaking change :(

Strange.. When I apply the patches to the local repo i have of bson-rs i get the following when compiling an example made with the sample code on #24
expected `core::option::Option<bson::ordered::OrderedDocument>`,
    found `core::option::Option<bson::ordered::OrderedDocument>`
(expected struct `bson::ordered::OrderedDocument`,
    found a different struct `bson::ordered::OrderedDocument`)

There are also other related errors. I will run a split test from my own workspace to see if its my code or this pr.

I didn't use that in my own project. So I am Ok with this change.
Is it ready to be merged?

It's good so far for me.

Yeah, this is ready for merging! Once this is in, I'll make the required changes on the mongo driver.


feat: better newUrlFunction for ProxyConfiguration

Based on changes from #2348 , this PR simplifies the proxy handling in the browser crawlers and makes those more intuitive.
Ready for reviews!
Closes #2065

Also cc #2310 - this solves the issue from there - but only for proxyUrls.

Looking at apify-sdk's ProxyConfiguration, the implementation there should be quite straightforward once we merge this - we inherit Crawlee's ProxyConfiguration class and can call the protected _handleTieredUrl() method with all the logic from there. Any ideas abt how we can make it even more seamless now here?

@barjin documentation for this ? How do we configure it?

@harshmaur - keep in mind that this feature is not yet in the stable version of Crawlee (will be included in the next release). Right now, you can try it out by installing the next tag (npm install crawlee@next).
These are mostly internal changes to how we manage proxies in browser-based crawlers, but the external API changed a bit too. See the JSDoc for newUrlFunction - you can now return null from the function if you want the crawler to not use proxy for this request. Also, the newUrlFunction is now called with (optional) request object. All in all, you can do something like this:
...
newUrlFunction: (sessionId, { request } = {}) {
   if (request?.url.includes('example.com')) return null;
   return 'default.proxy.com';
}
...

Let us know if you encounter any issues with this. Cheers!

Okay this is great! that's exactly what I needed.

Message ID: @.***>


Problems with using WebSocket in Edge

I developed a asp.net core web project with vs2019. I wrote the WebSocket program according to the method in https://docs.microsoft.com/en-us/aspnet/core/fundamentals/websockets?view=aspnetcore-5.0. The program works well in ie,but not in Edge. What's the reason for this?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: a3b0cac1-adc7-434c-d867-6e28e39bdae7
Version Independent ID: 762efeed-010e-f422-03d0-22d6681b2851
Content: WebSockets support in ASP.NET Core
Content Source: aspnetcore/fundamentals/websockets.md
Product: aspnet-core
Technology: aspnetcore-fundamentals
GitHub Login: @Rick-Anderson
Microsoft Alias: riande

Hello! Thanks for contacting us. This sounds like a general question about using ASP.NET Core. While we try to look at and respond to all issues, for questions like this we recommend posting to a community support group like Stack Overflow with the asp.net-core tag.

Stack Overflow
ASP.NET Core Slack
ASP.NET Gitter

Potential bugs in the ASP.NET Core framework and product feedback can be reported at dotnet/aspnetcore issues (include full repro steps and cross-link to a repro project in GH when appropriate). For Visual Studio, use the Report a Problem gesture or Suggest a Feature gesture within VS, which open internal issues for the VS team. For Visual Studio Code, you can open an issue at microsoft/vscode issues.


Added starts_with()

Returns true if the given pattern matches a prefix of this string slice.
Returns false if it does not.

Thank you

Please test it.


update from Jay Harris

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

rd/about/index.md
:white_check_mark:Succeeded

rd/jay-harris.yml
:white_check_mark:Succeeded

rd/media/profiles/jay-harris.jpg
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


gaming mode dashboard select box not working

like the title says, you can't switch global/rule/direct,or change language in the gaming mode.

It's the browser's bug, yacd's selector box not work in SteamOS browser.
Here is a way to switch mode(from https://t.me/steamdecktalk/8883):
https://user-images.githubusercontent.com/18544362/220138133-87e60902-55ec-48b6-afc6-206af4becad3.mp4

It's the browser's bug, yacd's selector box not work in SteamOS browser. Here is a way to switch mode(from https://t.me/steamdecktalk/8883): https://user-images.githubusercontent.com/18544362/220138133-87e60902-55ec-48b6-afc6-206af4becad3.mp4

This has been confused me for a long time until I see this issue, the select list could still be opened anyway but only when you try so many times to try to touch on a weird spot that is not on the proper location, thanks for the solution! Hoping all select boxes to be replaced by radio elements in future updates :)


Add FE!N by Travis Scott pleasseeeeeeeee

Song Name
FE!N
Artist Name
Travis Scott
Source
Youtube
Youtube Link
U-l4ya3ejko
Direct File Link
No response
Song ID
1
Start Offset [ms]
0
Extra
No response

accept


Support for OpenQASM 3

Description of the issue
Cirq currently has no support for OpenQASM 3. It can be done by writing a lexer and a parser similar to the ones we have for OpenQASM 2.

Thanks @vtomole for assigned me this issue :smile:. Yes, I have started to create my RFC.

@anonymousr007 any updates on the same?

This has been completed.


Fix a websocket issue with windows binary files

This pr downgrades windows binary file python version to 3.5.3

Oops


Kotlin Algorithms

Have you read the Contributing Guidelines on Pull Requests?
Yes
Description
Kotlin algorithms for areas of 2D and 3D figures.
Checklist

[x] I've read the contribution guidelines.
[x] I've checked the issue list before deciding what to submit.
[x] I've edited the README.md and link to my code.

Related Issues or Pull Requests
Issue Number: #1487

@shraddhavp Can you check this?

@iamrajiv Can you review this?

@all-contributors please add @itsIapetus for code


Map and ignore mapped value

Let's say I have the following objects
A: {
  a: 'xx'
  b: 'yy'
}

B: {
  a: 'xx2'
  b: 'yy2'
}

lets say I map B.b => A.a, and ignore B.b.
this code crashes
  mapper.createMap(map, BtoA)
      .forMember('a', (opts) => {
        return opts.sourceObject.b;
      }
       .forMember('a', (opts) => {
        opts.ignore();
      })

Hi @eugenekgn,
Wow, that's a complex piece of code you are presenting :)... Could you please upload the full code crashing (including 'map', 'BtoA' and potential other code pieces leading to your situation - maybe a zip/rar)? Of course I will be more than happy to reproduce your issue and hopefully to present a fix asap.
Cheers, Bert

Hi there,
It would be fairly challenging to isolate this use case, I might be explaining this clear enough but all I am trying to do is map property {B.b} to {A.a} , and since B object still has property B.a has the same named property which A has which is {A.a} I am trying to prevent auto mapping.
The outcome that I want to have is the following
  A: {
     a: "yy2" // I get a's value from B.b but automapper tries to Map B.a to = A.a because they have the same property names,
  }

Please let me know if this make more sense.

Hi @eugenekgn,
I think I partly understand what you are trying to do. What is going wrong obviously, is the following: when you map destination member a and ignore the same destination member afterwards, the result will be that there is no A.a property at all. You could of course try to ignore the source member (forSourceMember) instead, although I don't get why you should need that as well ;) ...
Cheers, Bert


the following packages contain code that will be rejected by a future version of Rust: imap-proto v0.10.2

I noticed today when building an app that this message was here:
$ cargo build --future-incompat-report
    Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.12s
warning: the following packages contain code that will be rejected by a future version of Rust: imap-proto v0.10.2
note:
To solve this problem, you can try the following approaches:

- Some affected dependencies have newer versions available.
You may want to consider updating them to a newer version to see if the issue has been fixed.

imap-proto v0.10.2 has the following newer versions available: 0.11.0, 0.12.0, 0.12.1, 0.12.2, 0.13.0, 0.14.0, 0.14.1, 0.14.2, 0.14.3, 0.15.0, 0.16.0, 0.16.1, 0.16.2, 0.16.3, 0.16.4, 0.16.5

- If the issue is not solved by updating the dependencies, a fix has to be
implemented by those dependencies. You can help with that by notifying the
maintainers of this problem (e.g. by creating a bug report) or by proposing a
fix to the maintainers (e.g. by creating a pull request):

  -<EMAIL_ADDRESS>  - Repository: https://github.com/djc/tokio-imap
  - Detailed warning command: `cargo report future-incompatibilities --id 2 --package<EMAIL_ADDRESS>
- If waiting for an upstream fix is not an option, you can use the `[patch]`
section in `Cargo.toml` to use your own version of the dependency. For more
information, see:
https://doc.rust-lang.org/cargo/reference/overriding-dependencies.html#the-patch-section

note: this report can be shown with `cargo report future-incompatibilities --id 1`

I am unsure of what to do so I am reporting this here.
This is with rustc 1.82.0.

I think the last release of this package is very old and it is better to use the current development / alpha version:
imap = { git = "https://github.com/jonhoo/rust-imap", version = "3.0.0-alpha.14" }


No matching distribution found for qiskit-chemistry

Hi,
I am trying to reinstall qiskit 0.10.4 for some old codes but I pip install errored out with
Could not find a version that satisfies the requirement qiskit-chemistry==0.5.0 (from qiskit==0.10.4) (from versions: none)
ERROR: No matching distribution found for qiskit-chemistry==0.5.0 (from qiskit==0.10.4)

OS is Ubuntu 16.04, python-3.7.6.
But if I just do
pip install qiskit

Then it installed qiskit 0.14.2 successfully and there is no qiskit-chemistry and 0.14.2 is definitely an old release.
What is going on??
Thanks.

Qiskit chemistry was merged into Qiskit Aqua 0.6.
https://github.com/Qiskit/qiskit/blob/master/docs/release_notes.rst#aqua-06-3

@t-imamichi I found that out after reviewing the release history but it shouldn't be removed retroactively so the old releases are uninstallable.

You're right, adding more documentation is never a bad idea though this change was mentioned in the releasenotes. Feel free to reopen, but I think this can be closed 🙂

It's actually merged to Qiskit Aqua
In Ubuntu,
python -m pip install --user qiskit
from qiskit import aer

@beew I agree with you it shouldn't have been deleted nor should the source repo have been deleted (it should have been archived and/or moved) it's quite unfortunate that it was, deleting from pypi is almost never the right choice. But, there isn't anything that can be done about it now, once it's deleted from pypi the previously released versions on pypi become locked out and nobody can push new files for the old versions (you can see https://github.com/pypa/packaging-problems/issues/74 for a lengthy discussion about it).
The only remedy I can provide for installing qiskit 0.10.4 manually except for chemistry with pip install qiskit-terra==0.8.2 qiskit-aer==0.2.1 qiskit-ignis==0.1.1 qiskit-aqua==0.5.1 qiskit-ibmq-provider==0.2.2 (which I just got from https://qiskit.org/documentation/release_notes.html#version-history). The qiskit package is just a metapackage so as long as you're not using qiskit-chemistry everything else should still be installable if you just install the components individually.
But that being said I'm going to close this issue since there isn't anything that can be done. Even if I had a copy of the chemistry tree at time of deletion (which I personally don't someone else might) and could restore a github repo for it, I couldn't upload the old versions to pypi anymore and we'd still be stuck when trying to install qiskit==0.10.4. I'm sorry there isn't a better answer here. But please feel free to reopen this if you think I'm overlooking something.

@SiddTim
I know but that doesn't allow you to install an earlier version.

@beew
For earlier version, use  python -m pip install --user qiskit==0.10.4

@SiddTim
Does not work, this is the whole point of the thread. I think only @mtreinish 's way of installing each piece separately works.


Add request id for all return types

Azure::Storage::Blobs::Models::AbortCopyBlobFromUriResult

Returning request ID in this and all other results.

closed via https://github.com/Azure/azure-sdk-for-cpp/pull/1395

closed via https://github.com/Azure/azure-sdk-for-cpp/pull/1395


FALCON_unzip successful with Ecoli sample, but failed with my own data

Hi @pb-jchin @pb-cdunn ,
Please help me with this issue, I was running falcon_unzip 0.4.0, and was successful using Ecoli example data after falcon running. However, it was failed when I ran my own data, even though I was using exactly the same environment, the same dependencies, and the same falcon-kit. Here is fc_unzip.cfg
fc_unzip.txt
Here is what I got from my own data running in 3-unzip/reads/pwatcher.dir/stderr :
[40293]starting track_reads
[40293]file list: ['/data/chen/PacBio/PST/assembly/falcon/raw_all/0-rawreads/m_00045/raw_reads.45.las', '/data/chen/PacBio/PST/assembly/falcon/raw_all/0-rawreads/m_00001/raw_reads.1.las', '/data/chen/PacBio/PST/assembly/falcon/raw_all/0-rawreads/m_00036/raw_reads.36.las', '/data/chen/PacBio/PST/assembly/falcon/raw_all/0-rawreads/m_00025/raw_reads.25.las', '/data/chen/PacBio/PST/assembly/falcon/raw_all/0-rawreads/m_00014/raw_reads.14.las', '/data/chen/PacBio/PST/assembly/falcon/raw_all/0-rawreads/m_00060/raw_reads.60.las', '/data/chen/PacBio/PST/assembly/falcon/raw_all/0-rawreads/m_00010/raw_reads.10.las', '/data/chen/PacBio/PST/assembly/falcon/raw_all/0-rawreads/m_00023/raw_reads.23.las', '/data/chen/PacBio/PST/assembly/falcon/raw_all/0-rawreads/m_00059/raw_reads.59.las', '/data/chen/PacBio/PST/assembly/falcon/raw_all/0-rawreads/m_00041/raw_reads.41.las', '/data/chen/PacBio/PST/assembly/falcon/raw_all/0-rawreads/m_00057/raw_reads.57.las', '/data/chen/PacBio/PST/assembly/falcon/raw_all/0-rawreads/m_00029/raw_reads.29.las', '/data/chen/PacBio/PST/assembly/falcon/raw_all/0-rawreads/m_00051/raw_reads.51.las', '/data/chen/PacBio/PST/assembly/falcon/raw_all/0-rawreads/m_00017/raw_reads.17.las', '/data/chen/PacBio/PST/assembly/falcon/raw_all/0-rawreads/m_00021/raw_reads.21.las', '/data/chen/PacBio/PST/assembly/falcon/raw_all/0-rawreads/m_00079/raw_reads.79.las', '/data/chen/PacBio/PST/assembly/falcon/raw_all/0-rawreads/m_00055/raw_reads.55.las', '/data/chen/PacBio/PST/assembly/falcon/raw_all/0-rawreads/m_00005/raw_reads.5.las', '/data/chen/PacBio/PST/assembly/falcon/raw_all/0-rawreads/m_00040/raw_reads.40.las', '/data/chen/PacBio/PST/assembly/falcon/raw_all/0-rawreads/m_00070/raw_reads.70.las', '/data/chen/PacBio/PST/assembly/falcon/raw_all/0-rawreads/m_00049/raw_reads.49.las', '/data/chen/PacBio/PST/assembly/falcon/raw_all/0-rawreads/m_00085/raw_reads.85.las', '/data/chen/PacBio/PST/assembly/falcon/raw_all/0-rawreads/m_00003/raw_reads.3.las', '/data/chen/PacBio/PST/assembly/falcon/raw_all/0-rawreads/m_00050/raw_reads.50.las', '/data/chen/PacBio/PST/assembly/falcon/raw_all/0-rawreads/m_00075/raw_reads.75.las', '/data/chen/PacBio/PST/assembly/falcon/raw_all/0-rawreads/m_00065/raw_reads.65.las', '/data/chen/PacBio/PST/assembly/falcon/raw_all/0-rawreads/m_00019/raw_reads.19.las', '/data/chen/PacBio/PST/assembly/falcon/raw_all/0-rawreads/m_00008/raw_reads.8.las', '/data/chen/PacBio/PST/assembly/falcon/raw_all/0-rawreads/m_00078/raw_reads.78.las', '/data/chen/PacBio/PST/assembly/falcon/raw_all/0-rawreads/m_00024/raw_reads.24.las', '/data/chen/PacBio/PST/assembly/falcon/raw_all/0-rawreads/m_00015/raw_reads.15.las', '/data/chen/PacBio/PST/assembly/falcon/raw_all/0-rawreads/m_00047/raw_reads.47.las', '/data/chen/PacBio/PST/assembly/falcon/raw_all/0-rawreads/m_00046/raw_reads.46.las', '/data/chen/PacBio/PST/assembly/falcon/raw_all/0-rawreads/m_00039/raw_reads.39.las', '/data/chen/PacBio/PST/assembly/falcon/raw_all/0-rawreads/m_00037/raw_reads.37.las', '/data/chen/PacBio/PST/assembly/falcon/raw_all/0-rawreads/m_00083/raw_reads.83.las', '/data/chen/PacBio/PST/assembly/falcon/raw_all/0-rawreads/m_00061/raw_reads.61.las', '/data/chen/PacBio/PST/assembly/falcon/raw_all/0-rawreads/m_00009/raw_reads.9.las', '/data/chen/PacBio/PST/assembly/falcon/raw_all/0-rawreads/m_00058/raw_reads.58.las', '/data/chen/PacBio/PST/assembly/falcon/raw_all/0-rawreads/m_00016/raw_reads.16.las', '/data/chen/PacBio/PST/assembly/falcon/raw_all/0-rawreads/m_00072/raw_reads.72.las', '/data/chen/PacBio/PST/assembly/falcon/raw_all/0-rawreads/m_00027/raw_reads.27.las', '/data/chen/PacBio/PST/assembly/falcon/raw_all/0-rawreads/m_00044/raw_reads.44.las', '/data/chen/PacBio/PST/assembly/falcon/raw_all/0-rawreads/m_00054/raw_reads.54.las', '/data/chen/PacBio/PST/assembly/falcon/raw_all/0-rawreads/m_00034/raw_reads.34.las', '/data/chen/PacBio/PST/assembly/falcon/raw_all/0-rawreads/m_00067/raw_reads.67.las', '/data/chen/PacBio/PST/assembly/falcon/raw_all/0-rawreads/m_00013/raw_reads.13.las', '/data/chen/PacBio/PST/assembly/falcon/raw_all/0-rawreads/m_00068/raw_reads.68.las', '/data/chen/PacBio/PST/assembly/falcon/raw_all/0-rawreads/m_00064/raw_reads.64.las', '/data/chen/PacBio/PST/assembly/falcon/raw_all/0-rawreads/m_00082/raw_reads.82.las', '/data/chen/PacBio/PST/assembly/falcon/raw_all/0-rawreads/m_00018/raw_reads.18.las', '/data/chen/PacBio/PST/assembly/falcon/raw_all/0-rawreads/m_00035/raw_reads.35.las', '/data/chen/PacBio/PST/assembly/falcon/raw_all/0-rawreads/m_00062/raw_reads.62.las', '/data/chen/PacBio/PST/assembly/falcon/raw_all/0-rawreads/m_00006/raw_reads.6.las', '/data/chen/PacBio/PST/assembly/falcon/raw_all/0-rawreads/m_00012/raw_reads.12.las', '/data/chen/PacBio/PST/assembly/falcon/raw_all/0-rawreads/m_00076/raw_reads.76.las', '/data/chen/PacBio/PST/assembly/falcon/raw_all/0-rawreads/m_00043/raw_reads.43.las', '/data/chen/PacBio/PST/assembly/falcon/raw_all/0-rawreads/m_00084/raw_reads.84.las', '/data/chen/PacBio/PST/assembly/falcon/raw_all/0-rawreads/m_00026/raw_reads.26.las', '/data/chen/PacBio/PST/assembly/falcon/raw_all/0-rawreads/m_00056/raw_reads.56.las', '/data/chen/PacBio/PST/assembly/falcon/raw_all/0-rawreads/m_00028/raw_reads.28.las', '/data/chen/PacBio/PST/assembly/falcon/raw_all/0-rawreads/m_00020/raw_reads.20.las', '/data/chen/PacBio/PST/assembly/falcon/raw_all/0-rawreads/m_00031/raw_reads.31.las', '/data/chen/PacBio/PST/assembly/falcon/raw_all/0-rawreads/m_00069/raw_reads.69.las', '/data/chen/PacBio/PST/assembly/falcon/raw_all/0-rawreads/m_00032/raw_reads.32.las', '/data/chen/PacBio/PST/assembly/falcon/raw_all/0-rawreads/m_00048/raw_reads.48.las', '/data/chen/PacBio/PST/assembly/falcon/raw_all/0-rawreads/m_00022/raw_reads.22.las', '/data/chen/PacBio/PST/assembly/falcon/raw_all/0-rawreads/m_00071/raw_reads.71.las', '/data/chen/PacBio/PST/assembly/falcon/raw_all/0-rawreads/m_00038/raw_reads.38.las', '/data/chen/PacBio/PST/assembly/falcon/raw_all/0-rawreads/m_00081/raw_reads.81.las', '/data/chen/PacBio/PST/assembly/falcon/raw_all/0-rawreads/m_00004/raw_reads.4.las', '/data/chen/PacBio/PST/assembly/falcon/raw_all/0-rawreads/m_00066/raw_reads.66.las', '/data/chen/PacBio/PST/assembly/falcon/raw_all/0-rawreads/m_00007/raw_reads.7.las', '/data/chen/PacBio/PST/assembly/falcon/raw_all/0-rawreads/m_00042/raw_reads.42.las', '/data/chen/PacBio/PST/assembly/falcon/raw_all/0-rawreads/m_00030/raw_reads.30.las', '/data/chen/PacBio/PST/assembly/falcon/raw_all/0-rawreads/m_00063/raw_reads.63.las', '/data/chen/PacBio/PST/assembly/falcon/raw_all/0-rawreads/m_00002/raw_reads.2.las', '/data/chen/PacBio/PST/assembly/falcon/raw_all/0-rawreads/m_00052/raw_reads.52.las', '/data/chen/PacBio/PST/assembly/falcon/raw_all/0-rawreads/m_00033/raw_reads.33.las', '/data/chen/PacBio/PST/assembly/falcon/raw_all/0-rawreads/m_00080/raw_reads.80.las', '/data/chen/PacBio/PST/assembly/falcon/raw_all/0-rawreads/m_00074/raw_reads.74.las', '/data/chen/PacBio/PST/assembly/falcon/raw_all/0-rawreads/m_00073/raw_reads.73.las', '/data/chen/PacBio/PST/assembly/falcon/raw_all/0-rawreads/m_00077/raw_reads.77.las', '/data/chen/PacBio/PST/assembly/falcon/raw_all/0-rawreads/m_00011/raw_reads.11.las', '/data/chen/PacBio/PST/assembly/falcon/raw_all/0-rawreads/m_00053/raw_reads.53.las']
[40293]preparing tr_stage1
[40293]maxrss:    10796
[40294]starting run_tr_stage1('/data/chen/PacBio/PST/assembly/falcon/raw_all/0-rawreads/raw_reads.db', '/data/chen/PacBio/PST/assembly/falcon/raw_all/0-rawreads/m_00045/raw_reads.45.las', 2500, 40, dict(37794 elem))
[40294]maxrss:    38416
     ......
[40293]finished track_reads
python -m falcon_kit.mains.pr_ctg_track
+ python -m falcon_kit.mains.pr_ctg_track
/usr/bin/python: No module named ext_falcon
touch /data/chen/PacBio/PST/assembly/falcon/raw_all/3-unzip/reads/track_reads_done.exit
+ touch /data/chen/PacBio/PST/assembly/falcon/raw_all/3-unzip/reads/track_reads_done.exit
2017-03-15 22:25:07,803 - root - DEBUG - CD: '/data/chen/PacBio/PST/assembly/falcon/raw_all/3-unzip/reads' -> '/data/chen/PacBio/PST/assembly/falcon/raw_all/3-unzip/reads'
2017-03-15 22:25:07,803 - root - DEBUG - CD: '/data/chen/PacBio/PST/assembly/falcon/raw_all/3-unzip/reads' -> '/data/chen/PacBio/PST/assembly/falcon/raw_all/3-unzip/reads'
2017-03-15 22:25:07,804 - root - CRITICAL - Error in /home/chongjing.xia/FALCON-integrate/pypeFLOW/pypeflow/do_task.py with args="{'json_fn': '/data/chen/PacBio/PST/assembly/falcon/raw_all/3-unzip/reads/task.json',\n 'timeout':<PHONE_NUMBER>00000,\n 'tmpdir': None}"
Traceback (most recent call last):
  File "/usr/lib64/python2.7/runpy.py", line 162, in _run_module_as_main
    "__main__", fname, loader, pkg_name)
  File "/usr/lib64/python2.7/runpy.py", line 72, in _run_code
    exec code in run_globals
  File "/home/chongjing.xia/FALCON-integrate/pypeFLOW/pypeflow/do_task.py", line 190, in <module>
    main()
  File "/home/chongjing.xia/FALCON-integrate/pypeFLOW/pypeflow/do_task.py", line 182, in main
    run(**vars(parsed_args))
  File "/home/chongjing.xia/FALCON-integrate/pypeFLOW/pypeflow/do_task.py", line 136, in run
    run_cfg_in_tmpdir(cfg, tmpdir)
  File "/home/chongjing.xia/FALCON-integrate/pypeFLOW/pypeflow/do_task.py", line 160, in run_cfg_in_tmpdir
    run_python_func(func, myinputs, myoutputs, parameters)
  File "/home/chongjing.xia/FALCON-integrate/pypeFLOW/pypeflow/do_task.py", line 125, in run_python_func
    do_support.run_bash(script_fn)
  File "/home/chongjing.xia/FALCON-integrate/pypeFLOW/pypeflow/do_support.py", line 51, in run_bash
    raise Exception('{} <- {!r}'.format(rc, cmd))
Exception: 256 <- '/bin/bash -vex /data/chen/PacBio/PST/assembly/falcon/raw_all/3-unzip/reads/track_reads.sh'

real	109m20.759s
user	411m47.694s
sys	12m34.778s
 returned: 256

For comparison, here is what I got from successful ecoli example, from 3-unzip/reads/pwatcher.dir/stderr:
[40154]starting track_reads
[40154]file list: ['/data/chen/software/FALCON-integrate/test/0-rawreads/m_00013/raw_reads.13.las', '/data/chen/software/FALCON-integrate/test/0-rawreads/m_00015/raw_reads.15.las', '/data/chen/software/FALCON-integrate/test/0-rawreads/m_00008/raw_reads.8.las', '/data/chen/software/FALCON-integrate/test/0-rawreads/m_00020/raw_reads.20.las', '/data/chen/software/FALCON-integrate/test/0-rawreads/m_00019/raw_reads.19.las', '/data/chen/software/FALCON-integrate/test/0-rawreads/m_00005/raw_reads.5.las', '/data/chen/software/FALCON-integrate/test/0-rawreads/m_00010/raw_reads.10.las', '/data/chen/software/FALCON-integrate/test/0-rawreads/m_00002/raw_reads.2.las', '/data/chen/software/FALCON-integrate/test/0-rawreads/m_00012/raw_reads.12.las', '/data/chen/software/FALCON-integrate/test/0-rawreads/m_00009/raw_reads.9.las', '/data/chen/software/FALCON-integrate/test/0-rawreads/m_00001/raw_reads.1.las', '/data/chen/software/FALCON-integrate/test/0-rawreads/m_00016/raw_reads.16.las', '/data/chen/software/FALCON-integrate/test/0-rawreads/m_00004/raw_reads.4.las', '/data/chen/software/FALCON-integrate/test/0-rawreads/m_00007/raw_reads.7.las', '/data/chen/software/FALCON-integrate/test/0-rawreads/m_00014/raw_reads.14.las', '/data/chen/software/FALCON-integrate/test/0-rawreads/m_00006/raw_reads.6.las', '/data/chen/software/FALCON-integrate/test/0-rawreads/m_00018/raw_reads.18.las', '/data/chen/software/FALCON-integrate/test/0-rawreads/m_00003/raw_reads.3.las', '/data/chen/software/FALCON-integrate/test/0-rawreads/m_00011/raw_reads.11.las', '/data/chen/software/FALCON-integrate/test/0-rawreads/m_00017/raw_reads.17.las']
[40154]preparing tr_stage1
[40154]maxrss:    10808
[40155]starting run_tr_stage1('/data/chen/software/FALCON-integrate/test/0-rawreads/raw_reads.db', '/data/chen/software/FALCON-integrate/test/0-rawreads/m_00013/raw_reads.13.las', 2500, 40, dict(1442 elem))
         .......
[40185]finished track_reads
#mkdir -p 3-unzip/reads/
python -m falcon_kit.mains.fetch_reads
+ python -m falcon_kit.mains.fetch_reads
cd /data/chen/software/FALCON-integrate/test/3-unzip/reads
+ cd /data/chen/software/FALCON-integrate/test/3-unzip/reads
date
+ date
touch /data/chen/software/FALCON-integrate/test/3-unzip/reads/track_reads_done
+ touch /data/chen/software/FALCON-integrate/test/3-unzip/reads/track_reads_done
touch /data/chen/software/FALCON-integrate/test/3-unzip/reads/track_reads_done.exit
+ touch /data/chen/software/FALCON-integrate/test/3-unzip/reads/track_reads_done.exit
2017-03-15 20:32:53,799 - root - DEBUG - CD: '/data/chen/software/FALCON-integrate/test/3-unzip/reads' -> '/data/chen/software/FALCON-integrate/test/3-unzip/reads'
2017-03-15 20:32:53,799 - root - DEBUG - Checking existence of u'ctg_list' with timeout=600000000000000
2017-03-15 20:32:53,802 - root - DEBUG - Checking existence of u'track_reads_done' with timeout=600000000000000
2017-03-15 20:32:53,804 - root - DEBUG - CD: '/data/chen/software/FALCON-integrate/test/3-unzip/reads' -> '/data/chen/software/FALCON-integrate/test/3-unzip/reads'

real	6m19.866s
user	4m55.217s
sys	0m28.049s
touch /data/chen/software/FALCON-integrate/test/3-unzip/reads/run.sh.done
+ touch /data/chen/software/FALCON-integrate/test/3-unzip/reads/run.sh.done
 returned: 0```

The only difference between these two runnings was that there were three jobs failed in 0-rawreads step due to LAcheck issue in Falcon, and I manually ran that three jobs and successful (see my comments in falcon issue #124). For Ecoli example, I ran Falcon successfully directly, without any manual steps.

Please let me know if you need more information. Thanks very much in advance.
chongjing

Hi @wsuplantpathology
Can you post the contents of:
/data/chen/PacBio/PST/assembly/falcon/raw_all/3-unzip/reads/task.json
It looks like the task finished successfully.
Does 3-unzip/reads/track_reads_done exist,  and is 3-unzip/reads/ctg_list non-empty?
If so, you may be able to proceed by touching the sentinel and re-invoking the pipeline:
touch /data/chen/PacBio/PST/assembly/falcon/raw_all/3-unzip/reads/track_reads_done.exit

Thanks @gconcepcion

Here is the contents of /data/chen/PacBio/PST/assembly/falcon/raw_all/3-unzip/reads/task.json

{
    "inputs": {
        "falcon_asm_done": "/data/chen/PacBio/PST/assembly/falcon/raw_all/2-asm-falcon/falcon_asm_done"
    },
    "outputs": {
        "ctg_list_file": "ctg_list",
        "job_done": "track_reads_done"
    },
    "parameters": {
        "config": {
            "job_queue": "default",
            "job_type": "local",
            "pwatcher_type": "fs_based",
            "sge_blasr_aln": "-pe smp 24 -q your_sge_queue",
            "sge_hasm": "-pe smp 48 -q your_sge_queue",
            "sge_phasing": "-pe smp 12 -q your_sge_queue",
            "sge_track_reads": "-pe smp 12 -q your_sge_queue",
            "smrt_bin": "/data/chen/software/GenomicConsensus-smrtanalysis-3.0.2/bin",
            "unzip_blasr_concurrent_jobs": 8,
            "unzip_phasing_concurrent_jobs": 8
        },
        "sge_option": "-pe smp 12 -q your_sge_queue",
        "wd": "/data/chen/PacBio/PST/assembly/falcon/raw_all/3-unzip/reads"
    },
    "python_function": "falcon_unzip.unzip.task_track_reads"
}

I do have non-empty  3-unzip/reads/ctg_list, but 3-unzip/reads/track_reads_done does not exist. However, I have 3-unzip/reads/track_reads_done.exit and this file is empty.

I ran your last two commands, nothing happens but two empty files generated, run.sh.done and track_reads_done.exit

Besides, in the 3-unzip/reads/ directory there are many *F_reads.fa and *F_ref.fa files, and they are non-empty. The name of *F are all listed in ctg_list. My new questions are,

how do you know the task looks like finished successfully?
what is that critical error in CRITICAL - Error in /home/chongjing.xia/FALCON-integrate/pypeFLOW/pypeflow/do_task.py with args="{'json_fn': '/data/chen/PacBio/PST/assembly/falcon/raw_all/3-unzip/reads/task.json',\n 'timeout':<PHONE_NUMBER>00000,\n 'tmpdir': None}"

Thanks very much for your time and efforts, I appreciate.

Is your SGE queue really called "your_sge_queue", or did you change it just to paste it here? I would say look into this as the obvious culprit. The job is able to track the reads as that's all done on the node from which falcon was executed, but then failed as soon as it tried to set up the rest of the unzip job because the queue setting is wrong? Not sure if this is the case - just a suggestion to investigate.

So the run.sh script exited due to an import failure prior to touching the track_reads_done file. That's interesting because python -m falcon_kit.mains.rr_ctg_track seems to have completely successfully, but then the script chokes on: python -m falcon_kit.mains.pr_ctg_track with an ImportError. But both of those scripts import the same python modules so i'm not sure what's happening.

Besides, in the 3-unzip/reads/ directory there are many *F_reads.fa and *F_ref.fa files, and they are non-empty. however, I notice the first file 000000F_reads.fa is 42Mb, then size of following *F_reads.fa is decreasing, with last one 000544F._reads.fa has only 354kb. Is this normal? The name of *F are all listed in ctg_list. My new questions are,

Yes, this is normal. In general the lowest number contig 000000F is the longest and thus it has the most reads mapping to it. The number of reads mapping to a particular contig should decrease as the contig number increases. Unless of course the contig is a highly repetitive section of DNA

how do you know the task looks like finished successfully?

Sorry, I was mistaken - I missed the env error /usr/bin/python: No module named ext_falcon
I'll need to take a look and see if I can figure out what's going on here.

what is that critical error in CRITICAL - Error in /home/chongjing.xia/FALCON-integrate/pypeFLOW/pypeflow/do_task.py with args="{'json_fn': '/data/chen/PacBio/PST/assembly/falcon/raw_all/3-unzip/reads/task.json',\n 'timeout':<PHONE_NUMBER>00000,\n 'tmpdir': None}"

That's just saying that the read tracking task exited without completing successfully, due to the issues mentioned above.

Thanks @gconcepcion for your explanations, very helpful.

Is your SGE queue really called "your_sge_queue", or did you change it just to paste it here? I would say look into this as the obvious culprit. Not sure if this is the case - just a suggestion to investigate.

No, I just leave these setting as default. I set job_type = local. So I didn't change SGE settings in the example .cfg. Actually, we are using SLURM, our partition is called "kamiak". Do you think I should set job_queue = kamiak, even though I have job_type = local.
Some update information:
Since you mentioned the track reads step looks successful, so I proceeded the following steps. And it turns out, everything looks good: I got phasing step done, and even quiver consensus. Basically, I have all_p_ctg.fa (85Mb, which is a little bit smaller than previously estimated 100Mb), all_h_ctg.fa (54Mb, I think this size is good since my fungus has high heterozygosity). But these are my first impression, I'll look into the details of the running process. Any comments are welcome on these results, since I am not so confident on how to interpret these data.
Thanks very much.


doc: add className props

Add the 'className' params in the readMe related to props.
Super small add but useful since I searched this props for a while ;)
Awesome comp!

Current coverage is 92.51%

Merging #369 into master will not affect coverage as of d165114

@@            master    #369   diff @@
======================================
  Files            9       9
  Stmts          187     187
  Branches        38      38
  Methods         88      88
======================================
  Hit            173     173
  Partial          4       4
  Missed          10      10

Review entire Coverage Diff as of d165114

Powered by Codecov. Updated on successful CI builds.

Hi @PBRT
Thanks for contributing to our component. I'm using a automated script to generate those docs. I created a new PR that uses the scripts and renames the prop (I found the prop name really confusing). See #370

The docs are based on the proptypes in the component. If there's no proptype defined, this change would be gone the next time I generate the docs.


I can not find rosrun in my environment.

I install the ros and OpenPTrack follow the "installation Guide", and i have done "Kinect V2 Installation". But when testing, i can not find rosrun.

Ok, i solve the problem that i should install ros-indigo-rosbash


chore: update netlify-onegraph-internal

Summary
Updates the netlify-onegraph-internal package with better codegen for some frameworks and subscriptions.

Thanks @sgrove, going to close this in favor of https://github.com/netlify/cli/pull/4131, and you can approve and merge that one your self.
Dependencies updates should be handled by renovate automatically, and you can force trigger an update in https://github.com/netlify/cli/issues/986


Change most of the socket code to async

Socket accepting is now fully async. TelnetSession has async receiving implemented, but there's still the Sender thread that seems to only be used for the invoke echo stuff? We might want to try to revisit removing that. Would be nice to have no threads in TelnetSession at all.
Improved the error handling.
RLogin hasn't been updated yet as I figured I'd get Telnet working smoothly first, then port everything.


Not working with C1200 v1 ?

It refuses to connect to my old router, not sure if this is a known thing. Tried normal pwd and web-encrypted
Error:
TplinkRouter - C1200 - Cannot authorize! Error - 'set-cookie'; Response - {"errorcode":"user conflict","success":false,"data":{}}

Hi
Try to logout from router in every place you login to the router and try again this integration

That did it, I had a uPnP connected ...thx

@vingerha What is your router hardware version?

OLD :)
Firmware: 1.1.3 Build 20180124 rel.52299 (EU)
Hardware: Archer C1200 v1.0

And you used web-encrypted pwd for the integration?

yes

@vingerha Thank you! A will add your hardware version to supported list.
P.S. Dont forget please to give a star to the repo :)


Implement getDrops() on WeaponKillEntityEvent

Description
Hi, I saw that the getDrops() method is missing in the WeaponKillEntityEvent. I would like it to be implemented so when an entity dies I can cancel the item drop. Thank you very much
Configuration

Payment (optional)

[ ] I'm willing to pay for this feature

We aren't missing anything, it isn't something that is reasonably possible to implement there. You should listen to the EntityDeathEvent to cancel drops.


Build executable file locally

Checklist

[x] I'm asking a question
[x] I've looked through the README and FAQ for similar questions
[x] I've searched the bugtracker for similar questions including closed ones

Question

I cloned repository, made some changes, and I want to build locally youtube-dl.exe, to test it on Windows. Is there special command for it?

I guess you just have to run the Makefile. I don't know how to on windows..

I guess you just have to run the Makefile. I don't know how to on windows..

To build it on Windows:

Install the most recent Python version:
https://www.python.org/downloads/
(check the option to instal pip as well and the option to add Python to your $PATH)
I have it installed in C:\Program Files and for all users (if I remember well; I'm on Linux most of the time).

In an elevated command prompt run:
python -m pip install --upgrade pyinstaller

Download the youtube-dl source code: https://github.com/ytdl-org/youtube-dl/archive/master.zip

Extract to the folder youtube-dl-master.

Open a command prompt in the folder youtube-dl-master and run:
pyinstaller.exe youtube_dl\__main__.py --onefile --name youtube-dl

youtube-dl.exe can then be found in the newly created dist subdirectory.

To build it on Windows:

Install the most recent Python version:
https://www.python.org/downloads/
(check the option to instal pip as well and the option to add Python to your $PATH)
I have it installed in C:\Program Files and for all users (if I remember well; I'm on Linux most of the time).

In an elevated command prompt run:
python -m pip install --upgrade pyinstaller

Download the youtube-dl source code: https://github.com/ytdl-org/youtube-dl/archive/master.zip

Extract to the folder youtube-dl-master.

Open a command prompt in the folder youtube-dl-master and run:
pyinstaller.exe youtube_dl\__main__.py --onefile --name youtube-dl

youtube-dl.exe can then be found in the newly created dist subdirectory.

@nicolaasjan Thank you very much. Maybe this instruction is worth adding to README.md

@nicolaasjan Thank you very much. Maybe this instruction is worth adding to README.md


[WIP] V3 readiness

This PR prepares zend-view for supporting ServiceManager v3.

[x] update repository according to migration/compatibility guide
[x] fix failing tests for SMv2
[x] fix failing tests for SMv3
[x] ensure everything works together after zend-mvc is v3-compatible

Last element is blocked by zendframework/zend-cache#68 - SMv3 cannot be installed at this moment because cache component is not V3-ready.
Edit: zend-cache was fixed, apparently zend-mvc is the blocker now.

Good stuff! Don't forget to add this to https://github.com/zendframework/maintainers/wiki/ZF3-ServiceManager-component-refactors,-phase-2

I updated the code according to kynx's feedback. I tested it with ServiceManager v3 (by temporarily setting required version as 3.0.3 as 2.8.0), and then I saw only 7 tests failing, apparently all related to zend-mvc being not compatible yet - apparently it is the last blocker.
I will wait until it is ready, and then do the final check.

@mtymek The approach I've been using for dependencies that are in the require-dev section, but which do not yet have forwards-compat releases, is as follows:

When testing on travis-ci against servicemanager and/or eventmanager v3, remove the dependency (composer remove --no-update zendframework/zend-such-and-such).
Find tests related to the component, and mark them skipped, with a message indicating they should be re-enabled once the component has forwards-compat releases.

This works in most situations, particularly when we start seeing circular dependencies (essentially, any zend-mvc dependency observed is likely a circular dependency at this point).
In this particular component, we have forwards-compat changes for a good portion of the components listed in the require-dev section, and all items in require have stable forwards-compat releases. If the only tests failing currently are due to zend-mvc, we can safely use this approach.
I'm willing to do that work today when merging; zend-view is a dep for a number of other components (navigation and form in particular), so this would help unblock some of those.

separated FQCN from normalized name
switched "config" to lowercase

As per your suggestion, I marked some tests as "skipped". Unfortunately I still get some errors in PluginManagerCompatibilityTest under v3, that I'm not able to resolve:
1) ZendTest\View\PluginManagerCompatibilityTest::testPluginAliasesResolve with data set #25 ('flashmessenger', 'Zend\View\Helper\FlashMessenger')
Zend\ServiceManager\Exception\ServiceNotCreatedException: Service with name "Zend\View\Helper\FlashMessenger" could not be created. Reason: Zend\Mvc\Controller\PluginManager::validatePlugin() has been deprecated as of 3.0; please define validate() instead

/home/mat/public_html/zend-view/vendor/zendframework/zend-servicemanager/src/ServiceManager.php:707
/home/mat/public_html/zend-view/vendor/zendframework/zend-servicemanager/src/ServiceManager.php:196
/home/mat/public_html/zend-view/vendor/zendframework/zend-servicemanager/src/AbstractPluginManager.php:143
/home/mat/public_html/zend-view/vendor/zendframework/zend-servicemanager/src/Test/CommonPluginManagerTrait.php:75

Caused by
PHPUnit_Framework_Error_Deprecated: Zend\Mvc\Controller\PluginManager::validatePlugin() has been deprecated as of 3.0; please define validate() instead

/home/mat/public_html/zend-view/vendor/zendframework/zend-servicemanager/src/AbstractPluginManager.php:157
/home/mat/public_html/zend-view/vendor/zendframework/zend-servicemanager/src/AbstractPluginManager.php:144
/home/mat/public_html/zend-view/vendor/zendframework/zend-mvc/src/Controller/PluginManager.php:84
/home/mat/public_html/zend-view/src/Helper/Service/FlashMessengerFactory.php:35
/home/mat/public_html/zend-view/vendor/zendframework/zend-servicemanager/src/ServiceManager.php:700
/home/mat/public_html/zend-view/vendor/zendframework/zend-servicemanager/src/ServiceManager.php:196
/home/mat/public_html/zend-view/vendor/zendframework/zend-servicemanager/src/AbstractPluginManager.php:143
/home/mat/public_html/zend-view/vendor/zendframework/zend-servicemanager/src/Test/CommonPluginManagerTrait.php:75

How can I work around it?

@mtymek ha! I've already pulled locally to review!
In that particular case, the plugin requires zend-session, which does not have a forwards-compat version yet. As such, I'd override the aliasProvider() method and have it skip that alias; you can see an example of that in the FilterPluginManagerCompatibilityTest.
Since I'm in the process of review anyways, I can do that for you if you'd like.

OK, please do - I was about to finish for today :-)

Merged with #42!


Usage in Production

How production ready is xturn? What are key features that you see as missing in order to make this production ready?

Hi Asgoel,
As a starting point for a WebRTC project, it is production ready.  There are some missing features, such as IPv6 support, that may be an issue for some people, but XTurn will handle STUN and TURN for UDP and TCP (both secure and insecure) will work great.
My perspective on XTurn in production is that it's a great beginning for something bigger.  If you want a malleable STUN/TURN server that you can add to and incorporate into a bigger picture, then I believe XTurn is perfect.  It's also a great resource to learn and understand how TURN servers work and for debugging WebRTC applications.  However, if all you need is a TURN server and you do NOT plan on doing anything to it, you would probably be better off using CoTURN, which is a more complete TURN server and caters for many more RFC specifications.
I hope this helps?

@Lazarus404 definitely helps, thanks! Is there documentation of the various portions of the codebase in case we did want to extend it?

It's definitely on our roadmap.  XTurn isn't a high priority at the moment, as it's not funded.  We were hoping it would generate a lot of interest in order to facilitate funding, but we haven't marketed it much, yet.  Since Millicast was launched, we have diverted most of our remaining resources to that.
However, I am giving a talk in July and using XTurn as the talking point.  I have a list of things I need to complete before that date comes :-)

Hi @asgoel.  I'm going to close this issue, as it's not an actual issue :-)  However, please do feel free to re-open if you have further questions, as it's a good space to keep these.


Display skip layers better

In netron, it is clear when there is a skip connection across layers, but the same information is lost in model explorer because the connections are not rendered across layers.

Clear when it is flatten:

@justinchuby, This seems like a reasonable request, as it affects "visualization correctness" at the higher level. We will take a look.


Dummy PR to test e2e-gcp

/hold

/test e2e-gcp

/test e2e-gcp

/test e2e-gcp

Should be fixed by https://github.com/openshift/release/pull/49394

/close
This is resolved.


Updated report examples and replaced the full example with an image in the README

Updated report examples and replaced the full example with an image

@anna-aleksandrowicz could you pls reupload you image to https://github.com/cycodehq/cycode-cli/tree/main/images? as the others

lemme provide another img because this one doesnt contain "report url" for docs

@MaorDavidzon could we merge it without waiting for @anna-aleksandrowicz approve? @saramontif needs new release it ASAP

@MaorDavidzon could we merge it without waiting for @anna-aleksandrowicz approve? @saramontif needs it for new release ASAP

Yes it's fine
Let's update the documentation early next week


MM-23623: Make the validation of what is considered a post delete con…

…sistent between backend and frontend.
Summary
Updates the validation of what is considered a "deleted" post so that the front-end and backend are using the same logic.
Ticket Link
https://mattermost.atlassian.net/browse/MM-23623
Screenshots
For a user who does not have permissions to delete their own posts, whitespace only don't enable the save button...

... but non-whitespaces do enable it.

Hi @mkraft
This also needs to be fixed in an another place, i.e. where user tries to edit other's post and then truncates the post and tries to save it. Can you please fix it there as well.
Steps to reproduce:

Ensure user has permission to edit other's post and does not has permission to Delete Other's post.
Now go to other user's post and edit and remove all the characters and try to save.
It prompts the user to delete the post and upon save, the same issue will be encountered.

Video demonstrating this issue:
https://community-release.mattermost.com/files/ocsp7bbwd3dommhrsx81b3trea/public?h=xBxxXVD2gzURfWStpavD6OtvOcmzSy36TPrkxdajgSk

Can you please check again to verify that you had the permissions configured the way you think. In my tests this bug doesn't reproduce.


Turn brieflyShowPassword back on on iOS

Fixes https://github.com/flutter/flutter/issues/115359
This patch should restore the brieflyShowPassword behavior on iOS before https://github.com/flutter/flutter/pull/104335.
On iOS new characters are still temporarily revealed if the user is entering using the software keyboard (potentially because it's easy to fat finger using on screen keyboards?).
Pre-launch Checklist

[ ] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[ ] I read the Tree Hygiene wiki page, which explains my responsibilities.
[ ] I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
[ ] I signed the CLA.
[ ] I listed at least one issue that this PR fixes in the description above.
[ ] I updated/added relevant documentation (doc comments with ///).
[ ] I added new tests to check the change I am making, or this PR is test-exempt.
[ ] I followed the breaking change policy and added Data Driven Fixes where supported.
[ ] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

LGTM 👍 I guess this changed again recently?

Not that I know of. I made the change based on the "new" behavior I observed on a new iOS version, but that was only because I was typing using an external keyboard. Typing with software keyboard still reveals the newly entered character for a short period.

I'm not seeing any actual google testing failures. Rerunning.


Simulator: add flag to disable battery simulation in SITL

It would be nice to have a command line flag for simulator which disabled the battery simulation for SITL. This allows for testing of anything that is not battery (or failsafe) related.

The simulation will not actually discharge to a failsafe level. If you like we can set the warning level low enough (just altering the param value) so it doesn't trigger the warning. No need to remove the battery drain.

I think it makes sense to have options for the following cases:

Normal drain where failsafe is triggered.
Discharge but no triggering of failsafe (like now).
No discharge, for simulation tests going (almost) infinitely.

Closing as stale, seemed to be workable for folks.

This was still on my personal todo list :smile:

When this is done, let me know so I can document it. I think it would be good to be able to simulate the battery failsafe. If this is already possible, what parameter needs to be set?

We want to be able to properly simulate all sorts of failsafes and failsafe combinations in SITL and in real flights, and this is just a part of it.

Saw some somewhat related progress towards this here: https://github.com/PX4/Firmware/tree/feature/sim-battery-parameter

@julianoes The tree in https://github.com/PX4/Firmware/issues/4428#issuecomment-507524004 disappeared. I presume we still want something for this?

This is doable with params SIM_BAT_DRAIN and SIM_BAT_MIN_PCT.


Identify the platform KnightOS (or at least settings) is running on

Also makes 'System Info' 100% sexier!

Looks good, thanks!


[BUG]: View migration

What version of drizzle-orm are you using?
0.28.2
What version of drizzle-kit are you using?
0.19.13
Describe the Bug
I'm trying to create a View table using only user schema columns.
But when I ran yarn drizzle-kit generate:pg --schema=WhereIsMySchema it's doesn't update with my pgView.

// ./src/schemas/index.ts
// ok!
export {
  LoginMethod,
  type User,
  users as userSchema,
  loginMethodEnum,
} from "./user";
// ok!
export { type Presence, presences as presenceSchema } from "./presence";
// not working
export { userLoginMethodView } from "./view";

// ./src/schemas/view/index.ts
import { pgView } from "drizzle-orm/pg-core";
import { userSchema } from "..";

export const userLoginMethodView = pgView("user_login_method").as((qb) =>
  qb
    .select({
      id: userSchema.id,
      email: userSchema.email,
      loginMethod: userSchema.loginMethod,
    })
    .from(userSchema),
);

Expected behavior
Current behavior:

Create a new mutation to insert a new table (view) in database.
Environment & setup

Postgres 15.4
MacOS 13.5.1
Fastify
Using the default yarn add drizzle-orm postgres && yarn add -D drizzle-kit

Additional context:
That is my drizzle config file:
import type { Config } from "drizzle-kit";
import dotenv from "dotenv";

dotenv.config();

export default {
  schema: "./src/schemas/index.ts",
  driver: "pg",
  out: "./drizzle",
  dbCredentials: { connectionString: process.env.DATABASE_URL! },
} satisfies Config;

According to the docs, migration for views is not yet implemented.

Views are currently only implemented in the drizzle-orm, drizzle-kit does not support views yet. You can query the views that already exist in the database, but they won't be added to drizzle-kit migrations or db push as of now.

Source: https://orm.drizzle.team/docs/views
What you could do instead is using db.execute() to create the view inside your function, which runs the migrations.
Example:
import { sql } from 'drizzle-orm';
import { getViewConfig, pgView } from 'drizzle-orm/pg-core';

...

const customersView = pgView("customers_view").as((qb) => {
  return qb
    .select({
      id: user.id,
      name: user.name,
      email: user.email,
    })
    .from(user);
});

await db.execute(sql`drop view if exists ${customersView}`)
await db.execute(sql`create view ${customersView} as ${getViewConfig(customersView).query}`)

...

I wonder when drizzle can support view migration automatically?

@frenicohansen    Just hit this too, but expanding on your idea to apply automatically to all views in the schema file.
for (const view of Object.values(schema)) {
   if (view instanceof SQLiteView) {
      db.run(sql`drop view if exists ${view}`);
      db.run(sql`create view ${view} as ${getViewConfig(view).query}`)
   }
}

Of course one disadvantage to this, is that the view is dropped and created every time, instead of drizzle looking at the migrations to work out what's required.

Hey just wondering if the above solution can apply if I am using db push?

It's supported in latest versions, which are<EMAIL_ADDRESS>and<EMAIL_ADDRESS>


Issue with route() not taking me to a named route, and instead trying to set the url to just whats typed.

Ziggy version
1.4.6
Laravel version
9.17.0
Description
I am using Laravel Breeze Inertia Vue.
In my Vue page I am attempting to call on onclick event that changes the route, however using route('forms.show', form.id) just does absolutely nothing, no console output and the route does not change.
I have tried entering the URL manually, however, it just says that the route doesn't exist.
Ziggy call and context

Ziggy configuration
routes: {
forms: {uri: 'forms', methods: Array(2)}
forms.show:
methods: (2) ['GET', 'HEAD']
uri: "forms/{id}"
}

Route definition
Route::get('/forms/{id}', [FormsController::class, 'show'])->middleware(['auth', 'verified'])->name('forms.show');

Ziggy's route() helper behaves just like Laravel's—it takes a route name and parameters and returns a URL string (Ziggy doesn't handle navigation). It looks like you probably want something like this:


Add support for reading from a (non-seekable) file object instead of a filename

This will require internal changes to the library, and perhaps some API changes.
Relevant issues and pull requests:

feature request: support non-seekable input files #5
Streaming #14
Only supports reading a file from the filesystem #25
Add support to read dbf file from zip-archive #39
https://github.com/olemb/dbfread/issues/37

I suspect the best solution to handle all of these cases is to break most of the code into functions that can be composed into different APIs. For example, there could be a function that reads the headers from a file object, an d a generator that reads records from a file object and we could write a new backwards compatible DBF class or another leaner API on top of these.
These smaller function would also be useful when writing debugging tools.

Take a look at our implementation here if it's useful: https://github.com/catalyst-cooperative/dbfread


Implement Click() extension method on AutomationElement

I recently started using FlaUI and was missing such method while doing a lot of navigation in my tests.
Maybe you will find it useful.

@Roemer @michal-ra Would it make sense to have such thing also for Invoke method?

In my opinion, this idea is, let's say, more a 'custom' solution that suits specific range of applications.

Sorry for taking so long to comment.
I don't get how you get the "new" control.
I mean in your example, you click on LoginButton  and your Click<T> method basically just returns the same element just wrapped in T? How is the LoginButton supposed to suddenly become a ProfilePage?

I will close this as there is no example on how this is supposed to work to really help. Also there is now an .As<T>() method which allows easier conversions of elements.


Change R build URL to the cloudfront URL

Rather than being served directly from S3 we now serve these files from
a CloudFront distribution; which should make fetches faster and cheaper for us.

Not sure what is going on with the Travis results, but I don't believe they are due to issues with this change. Please let me know if this is incorrect.

I have fixed the conflicts and the build is now passing, it would be great to have this reviewed and merged, thanks!

I again fixed the conflicts for the PR, it would be good to have it merged!


fprintd: 1.92.0 -> 1.94.1

Motivation for this change
Fixes https://github.com/NixOS/nixpkgs/issues/153240.
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.05 Release Notes (or backporting 21.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

Didn't test it on a physical scanner yet, will try soon.

Apparently my current laptop needs additional unpackaged drivers for fprintd to work, which I don't have time to work on. @pimeys can you try this and report if it works?

@abbradar yes! Right after I finish my work and get back to my laptop.

Set my flake to take fprintd and libfprint from your fork. Compiles successfully, and after a reboot I can login with my fingerprint, and I can also sudo ls which asks my fingerprint, and after giving it it runs ls successfully.
Seems to work. Thank you.

Thanks for the testing!

fprintd-tod is still on 1.90, and failing to build.


PP-9213: Add post-merge tagging and concurrency

WHAT YOU DID

Add post-merge release tagging
Add post-merge concurrency control
Remove the Jenkinsfile

Accompanies https://github.com/alphagov/pay-ci/pull/660

Did you push the commit to remove the Jenkinsfile?

@katstevens doh! Forgot to remove it at all! Pushed, thank you :)


add weak memcpy et al (take 2)

cc @Amanieu

Splitting rlibc into its own crate yields correct __aeabi_* intrinsics
00000000 <__aeabi_memcpy>:
   0:   eafffffe        b       0 <memcpy>

But using this crate still generates a recursive bomb.

So is the problem inside the rlibc crate? Is the memcpy function calling itself?

The rlibc disassembly loosk correct.
Interestingly, disabling LTO on this branch doesn't fix the infinite recursion.

memcmp should be added as well since it is called by libcore.


Missing config.Env wrapper in readme example

In the readme example, stytch.EnvTest needs to be wrapped in config.Env, as specified in other sections of the code.

@mikehikes thanks for reaching out and opening this issue.
When setting up the Stytch Go client, stytch.EnvTest or stytch.EnvLive are valid values to be passed in, no need to wrap them in config.Env().
Are you running into problems using stytch.EnvTest without wrapping it?

Thanks for getting back with me quickly!
Indeed, I am receiving the following linting error when using that constant without the wrapper:
cannot use stytch.EnvTest (constant "test" of type "github.com/stytchauth/stytch-go/stytch".Env) as config.Env value in argument to stytchapi.NewAPIClientcompiler[IncompatibleAssign](https://pkg.go.dev/golang.org/x/tools/internal/typesinternal?utm_source%3Dgopls#IncompatibleAssign)
I am using Go 1.17.7, VSCode 1.65.1, with the following entriesin my go.mod file for Stytch:
	github.com/stytchauth/stytch-go v1.1.3 	github.com/stytchauth/stytch-go/v3 v3.13.0
Let me know if I may provide any additional info.

Ah, I think it may be that you're including both of those values in your go.mod file.
Try only importing github.com/stytchauth/stytch-go/v3 v3.13.0 and see if that resolves the issue.

Ah, yeah, you were correct. I had an unnoticed import that referenced the older version, hence the additional import in go.mod. I should have checked that first.
Sorry about that! I appreciate the quick reply, and appreciate all the work put into this library - it's been very straightforward and easy to use!

Amazing, glad we got it sorted quickly.
And thanks so much for the kind words! Have a great weekend.


Pre trained embedding

Hi,
Is it possible to access the trained molecular embedding only for downstream task ?
Thanks

Hi.
I am not sure if I understand your question exactly. Given a SMILES string, you want to get its embeddings?
Maybe the code snippet below will be helpful (here, I am using laituan245/molt5-small-smiles2caption ).
from transformers import T5Tokenizer, T5EncoderModel

tokenizer = T5Tokenizer.from_pretrained("laituan245/molt5-small-smiles2caption")
model = T5EncoderModel.from_pretrained("laituan245/molt5-small-smiles2caption")
input_ids = tokenizer("C1=CC2=C(C(=C1)[O-])NC(=CC2=O)C(=O)O", return_tensors="pt").input_ids
outputs = model(input_ids=input_ids)
last_hidden_states = outputs.last_hidden_state

Yes perfect that is what I wanted.
One other thing concerning the tokenizer ( seems to be a more general question regarding tokenization ) : During dataloading process for a random task, should I tokenize everything at the beginning (let's say I have a dataframe of smiles string)  or should I tokenize each smiles one by one in the get_item_ function ?
Thanks a lot !

So suppose you have a list of SMILES strings, you can just use the default function of the tokenizer to tokenize them. It will automatically handle padding and stuff. It is quite convenient. For example:
from transformers import T5Tokenizer, T5EncoderModel

tokenizer = T5Tokenizer.from_pretrained("laituan245/molt5-small-smiles2caption")
model = T5EncoderModel.from_pretrained("laituan245/molt5-small-smiles2caption")
list_of_smiles = ["C1=CC2=C(C(=C1)[O-])NC(=CC2=O)C(=O)O", "CC(=O)OC1=CC=CC=C1C(=O)O"]
input_ids = tokenizer(list_of_smiles, return_tensors="pt", padding='longest').input_ids
outputs = model(input_ids=input_ids)
last_hidden_states = outputs.last_hidden_state

Some of the options for padding is like padding, longest ...
I hope that answers your question.
In general, our models are like seq2seq models in HuggingFace. Please refer to their documentation as well.

Thanks a lot !


Fix issues

I have fix two issues in this branch:
*First: I removed some unused imports, it won't change anything but it makes the code clearer.
*Second: I added a few lines in the InputFragment.java file so the keyboard will close after the user submits the command, it only works if the 'Autocollapse Keyboard' option is set.

Sorry, but the way it works now is the way it is intended to work: Only the "Done" button on the softkeyboard is suppose to collapse the keyboard.
Rationale: the softkeyboard is only a fallback solution in case you cannot construct a command otherwise. Those situations are rare and the player mostly doesn't want to deal with the keyboard to begin with, so autocollapsing it is the meaningful thing to do. However, there are situations in which the player might want the keyboard to stay open without having to reconfigure the app,

Ok now I get it.The thing is that my tablet's keyboard doesn't have a "Done" button that's why I did the modification. Thanks anyway. And if you need any help, i can help you. I really like this app and I really programming.


[DWrite] Garbage data returned by Font1.Metrics, and probable memory overrun.

The FontMetrics1 struct that comes back from the Metrics property of a Font1 essentially contains garbage data.  On close examination, it looks like it is a FontMetrics struct that has been hard cast to a FontMetrics1 struct.
I'm pretty sure that the problem here is that the native DWRITE_FONT_METRICS1 derives from DWRITE_FONT_METRICS but no such relation exists in managed code since managed structs can't inherit from each other.  IDWriteFont1::GetMetrics expects to receive a pointer to a struct that contains both the DWRITE_FONT_METRICS fields and the DWRITE_FONT_METRICS1 fields, but the auto-generated implementation of Font1.Metrics passes it the address of a struct which contains only the DWRITE_FONT_METRICS1 fields.
That means that IDWriteFont1::GetMetrics ends up writing the DWRITE_FONT_METRICS data into the memory that the managed code will try to interpret as DWRITE_FONT_METRICS1 data, effectively resulting in garbage.  Worse, it means that IDWriteFont1::GetMetrics is probably overwriting arbitrary memory past the end of the FontMetrics1 structure.
My workaround has been to not use Font1.Metrics at all, and instead implement my own native function to retrieve the data and call it via p/invoke.  My function takes separate pointers to a FontMetrics and a FontMetrics1 (and a Font1, obviously), passes its own local DWRITE_FONT_METRICS1 to IDWriteFont1::GetMetrics, and copies each field from that local variable into the appropriate passed pointer.
(Note that I'm basing this off my usage of SharpDX 3.1.1, which I realize is out of date, but it also doesn't look like much has happened in the DWrite code since then so I think it's likely that this is still an issue.)

Was looking at that issue quickly today, seems in sharpdx 4 generator does add all fields from FontMetrics in FontMetrics1, so I guess we could close that issue

I've recently updated SharpDX, and I can confirm that this is fixed in 4.0.1, 4.1.0, and 4.2.0.  Thanks!


RemoteTransform and RemoteTransform2D enhancements

Added the following features to RemoteTransform and RemoteTransform2D:

Added the ability to toggle changes in position, rotation, and scale
Added the ability to toggle changes in either local or global coordinates

closes #265

Note that there seems to be something weird in your local git configuration, your commits are shown as "TwistedTwigleg committed with = 7 hours ago". So it's like you author the commits with a git identity linked to your GitHub account (TwistedTwigleg), and then reapply those commits (git am/rebase) with a different git identity named "=".

Okay, I made the changes based on the review.
I'm not 100% sure why all of my commits are with a git identity named "=". It seems "=" was set as the default local git user, though I used --author in the most recent commit, which should override local.
I just used 'git --unset-all user.name' and 'git --unset-all user.email' and now it seems the git identity named "=" has been removed.
Should I see if I can alter the previous commits to remove references of the git user named "="? Or should I just leave it as is?

If you rebase your branch according to http://docs.godotengine.org/en/latest/community/contributing/pr_workflow.html#mastering-the-pr-workflow-the-rebase to squash the two commits together (second one as fixup of the first one), it should automatically update the committer reference too.
You can check your ~/.gitconfig file (or the corresponding one on Windows/macOS, not sure where it would be) to ensure that "=" is no longer in it.

Okay, will do! Just changed branches and am quickly fixing an issue there, then I switch back to this branch and will squish the two commits together.
I'm still trying to wrap my head around git, so I appreciate all of the help! :smiley: Thanks!

Did you test all cases? I get some weird behavior

I tested all of the new options, and they seemed to work.
I'll admit I didn't have a project to use for testing, so it's possible I missed something, or messed something up.
What behavior are you seeing?

"use full transform" means it applies the changes in global coordinates instead of local, right? If so, I dont think "full transform" is clear on what it does. I'd suggest "use global coordinates" or something similar.
I need to test this better, but on toggle things on/off sometimes I got in cases where the rotation would happen even if rotation was off.

Yeah, using full transform means it applies in global coordinates. I'll switch 'use full transform' to 'use global coordinates', I think it sounds better and should reduce confusion.
The rotation issue might be because I'm updating the remote node on option toggling. I'll need to do some more testing to be sure, but I think that could be the problem.

Alright, I think I found and fixed the rotation issue. I renamed "use_full_transform" to "use_global_coordinates", thanks nunodonato for the suggestion!
I also squished the commits into one commit.

yep, works ok now! thanks :)

No problem, I'm glad it works.
Thanks for the suggestion and the bug report!

Okay, I changed the code:

Uses transforms when possible, instead of setting position, rotation, and scale.
Changed the group from ADD_GROUP("Update", "") to ADD_GROUP("Update, "update_")
If all of the options are selected, then it uses the exact transform

I left in this code in remote_transform_2d:
if (update_remote_scale)
    n->set_global_scale(get_global_scale() + Vector2(1, 1));

Because without it when using global coordinates the scale of the remote turns to (0.0001, 0.00001) despite the fact that Remote2D's scale is (1, 1). Not sure if it is a bug in my code, or if it's a bug in node_2D set_scale function.

I changed the method of updating the remote so if there is any special transforms they always get passed to the remote node.

@bojidar-bg is everything good here?

Well, yes, my points have been handled (sorry for not changing review status earlier). Would be nice if someone else also goes over the code, anyway. ( @tagcup Would you be able to do this, since you tend to understand matrices and transforms better? 😃 )

A rebase could also be interesting, I don't think we need 4 different commits for the overall diff: http://docs.godotengine.org/en/latest/community/contributing/pr_workflow.html#mastering-the-pr-workflow-the-rebase

No worries bojidar-bg, I just wanted to make sure everything in your review was handled.
akien-mga I'll rebase and squish the commits into one, sorry about that.

I fixed a couple bugs I missed with scaling on RemoteTransform2D.
While I was fixing these bugs, I looked at Node2D's set_global_scale function and I'm a little confused.
Set_global_scale seems to take the parent node's global scale and subtract that from the scale you pass in. Why does it subtracts the parent's scale?
(Side note: It would appear that the parent's scale was being subtracted from the scale I passed in, hence why in the previous commit I had to add (1, 1) to the scale for it to stay synced. Mystery solved :sunglasses: )
Another thing I found is that set_global_scale is never used in the code base (according to a Atom project find using "set_global_scale"). If it's never used, shouldn't we remove it? It's just dead code and I'm not sure it even works correctly. I don't think you can set global scale without changing the parent node(s) since global scale is effected by the parent node(s).
(I'll squish the commits together after someone gives it a look. I'm not 100% sure everything is working correctly)

@TwistedTwigleg It is bound to GDScript, even if not used by C++.

Also, note that set_global_scale comes from #6159, and was modeled after set_global_rot, it seems.
If you can make it using Transform2D-s, it would be all for the better, I think.

@bojidar-bg RemoteTransform2D uses Tranform2D-s, and RemoteTransform uses Transform-s
I think I've figured out what's happening with set_global_scale.
Here's the equation for figuring out a node's global scale
global_scale = our_scale * parent_node_scale;

Here is what I think set_global_scale is currently doing:
our_scale = global_scale - parent_node_scale;

Which doesn't get the global scale. This method does work for getting global rotation though, because global rotation is:
global_rotation = our_rotation + parent_node_rotation;

And setting global rotation is:
our_rotation = global_rotation - parent_node_rotation

To get global scale though, you'd need this:
our_scale = global_scale / parent_node_scale;

Right?
Should I open a pull request fixing this, assuming my logic is correct?

@TwistedTwigleg Sounds good, so, yeah, you should probably make a PR fixing this.

@bojidar-bg
I made the pull request: #9486

I squished the five commits into one


Trouble loading scripthookvdotnet.asi

I have a fresh Steam copy of GTA V, no mods - save for ScriptHookV, NativeTrainer and LSPDFR.
I've been trying to install this mod that requires scripthookvdotnet, but the game crashes on launch everytime with error saying it couldn't load scripthookvdotnet.asi. What am I doing wrong?
Here's the log:
// GTA V SCRIPT HOOK (build Jul 27 2018, v1.0.1493.0)
//     (C) Alexander Blade 2015-2018
[07:57:10] INIT: Started
[07:57:10] INIT: Success, game version is VER_1_0_1493_0_STEAM
[07:57:10] INIT: Registering script 'NativeTrainer.asi' (0x00007FFD168AA3C0)
[07:57:10] INIT: Registering script 'ScriptHookVDotNet.asi' (0x00007FFD01991470)
[07:57:18] INIT: Pool 1 extended
[07:57:18] INIT: Pool 2 extended
[07:57:18] INIT: Pool 3 extended
[07:57:18] INIT: Pool 4 extended
[07:57:24] INIT: GtaThread collection size 189
[07:57:24] INIT: wnd proc 0x00000000FFFF085D
[07:57:24] INIT: IDXGISwapChain 0x00007FFD2EC88018 (0x00007FFD2EC21D20)
[07:57:24] INIT: IDXGISwapChain set
[07:57:24] INIT: DX init started
[07:57:24] INIT: DX feature level B000
[07:57:24] INIT: DX init succeeded
[07:58:17] CORE: Requesting thread creation
[07:58:17] CORE: Creating threads
[07:58:20] CORE: Started control thread, id 34 active 1
[07:58:20] CORE: Started thread 'NativeTrainer.asi' (0x00007FFD168AA3C0), id 35 active 1
[07:58:20] CORE: Started thread 'ScriptHookVDotNet.asi' (0x00007FFD01991470), id 36 active 1
[07:58:20] CORE: Launching main() for 'NativeTrainer.asi' (0x00007FFD168AA3C0), id 35
[07:58:20] CORE: Launching main() for 'ScriptHookVDotNet.asi' (0x00007FFD01991470), id 36
[07:58:20] CORE: An exception occurred while executing 'ScriptHookVDotNet.asi' (0x00007FFD01991470), id 36

I don't get this error, it Says that it loaded, but my scripts do not work anyway. But I'm using a new environment, so I don't know what could be wrong. Only thing I can think is ScriptHookVDotNet needs to be updated.

@LongswordAlpha You also need ScriptHookVDotNet2.dll in the game's root folder.
@jessiewestlake This is not related to the issue of LongswordAlpha. Did your scripts work before installing the new environment? No useful log?

LongswordAlpha Apparently you clicked the wrong download. I just tried it again and yes it's in there! -> https://github.com/crosire/scripthookvdotnet/releases
Download the 2.10.6 version.


Enhancement in the product-assoc.md

[x] product - product association definition : Definition of product association and some key product associations and ProductAssoc entity key attributes
[x] Correction in the Product Variant Association
[x] Upgrade(up-skill) product association (sample data missing)

@namratapanwar20
@patidar-pawan


EnableResourceServer does not work with grails restful url mappings

The resource server's url mapping is
    static mappings = {
        "/tests"(resources: 'test')

        "/$controller/$action?/$id?(.$format)?"{
            constraints {
                // apply constraints here
            }
        }

        "/"(controller: 'application', action:'index')
        "500"(view: '/application/serverError')
        "404"(view: '/application/notFound')
    }

I can open '/test' with access token, but it reports not found error when access '/tests' or '/tests/1'. It works fine without @EnableResourceServer.

Never mind, it is working now.


Number of page watchers increased with introduction of multiple languages support

Along with the commit:
https://github.com/angular-translate/angular-translate/commit/e591462af379150cb1bae29f493137cb825025b1
the line
[306] scope.$watch('translateLanguage', updateTranslations);
introduced a new watcher in each directive scope that might not be necessary.
A provider configuration can be introduced in order to conditionally add the watcher in order to avoid long digest cycles for pages with many translation directives. Once disabled (watcher not present) the app can rely on: $translateChangeSuccess event in order to do the updates.

@cstefanache  Yes, that sounds to be a great optimization.

I will open a pull request for it soon.

Pull request opened: https://github.com/angular-translate/angular-translate/pull/1387. All the details are added in the pull request message. I changed my initial proposal with watchers on the translate-language directive in order not to introduce a new configuration and preserve the $watch functionality only when needed.


unknown error: window[requireName] is not a function

Hey,
I am trying to check the title of my second window. Is this a bug, or am I doing something wrong?
let handles = await app.client.windowHandles();
console.log(handles);
/*
{ sessionId: '0d66b5bac77357c36ea41fd298e55854',
  status: 0,
  value:
   [ 'CDwindow-97CD6BD5-C47A-45C1-9A66-7D0FF3B2F9DF',
     'CDwindow-946E9CE7-9A1C-458A-9DE2-00A975ACC5BD' ] }
*/
await app.client.windowByIndex(1);
console.log(await app.client.browserWindow.getTitle());

BTW windowHandles is missing in the readme. Also I saw on stackoverflow that somebody was doing windowByIndex(handles.values[1]) but this also fails for me.
What is also weird is that my second window actually has focus, but app.client.browserWindow.getTitle() will get me the title of the first window. How can I make app.client.browserWindow to point at currently focused window?

BTW windowHandles is missing in the readme.

The app.client API is currently documented at http://webdriver.io/api.html

console.log(await app.client.browserWindow.getTitle());

This should be this instead:
console.log(await app.browserWindow.getTitle());

unknown error: window[requireName] is not a function

Do you have more of the stack trace that raised this error?

Also, does your app have nodeIntegration enabled in both windows?

Also, does app.client.getTitle() work for you?

Thank you very much for your time.
unknown error: window[requireName] is not a function unfortunately this did not appeared with a stack trace (I am using ava).
Thanks to your hints I made it work. The problem was nodeIntegration being disabled indeed. So it seems that this error was actually triggered by windowByIndex.
I changed app.client.browserWindow.getTitle() to app.browserWindow.getTitle() and it works. app.client.getTitle() works also.
So after all maybe adding a note in readme about nodeIntegration would be helpful.
I have one more question if I may - can I talk to the main process ipc directly from tests? I am trying to trigger some things directly from the tests instead of the renderer process.
I have tried const ipc = app.electron.ipcRenderer; but ipc.send does not seem to send to the main process. Is there any way to do that or do I just have to setup another ipc connection myself?

So after all maybe adding a note in readme about nodeIntegration would be helpful.

Good point, I added https://github.com/electron/spectron#node-integration today which hopefully makes thing clearer.

can I talk to the main process ipc directly from tests?

It should work, I just uploaded a simple spec to test it and it appears to pass currently, https://github.com/electron/spectron/commit/6d36884f0329f3a187ae105c40b091fba98d83aa

Hmm app.electron.ipcRenderer.send('ipc-event', 'test') does not work for me. Not sure what is the reason.

Oh wait, got it. Seems that when you use ipcRenderer also in html that is loaded in your app it takes precedence and using it directly in tests fails then.

Seems that when you use ipcRenderer also in html that is loaded in your app it takes precedence and using it directly in tests fails then. So it seems that it will only work if you somehow disable ipc in the renderer for test purposes.

Hmm, that is surprising, could you include the code to help me reproduce this locally?

Good that you have asked.
I've forked spectron and changed the fixtures/app just to find out that it works. Now I've reverted my changes from yesterday and it also works :smile:
So it seems that I had some other problem somewhere which I probably fixed with other changes. It started working when I removed var ipc = require('electron').ipcRenderer; from my index.html but it seems that this was only coincidence.
Tried to nail it but my IDE did not keeps so detailed track of local changes.
So anyway, thank you for your time once again!

Also, does your app have nodeIntegration enabled in both windows?
How can I check about that? Where is this setting defined?


eagle不能登录进去

我启动后，密码提示：Account or password is error
配置文件：
kafka.eagle.driver=org.sqlite.JDBC
kafka.eagle.url=jdbc:sqlite:/app/software/kafka-eagle/db/ke.db
kafka.eagle.username=admin
kafka.eagle.password=admin123

默认用户名是 admin 123456

@franplk Well done, @cnfree0355 It's right.
Kafka Eagle Login information(Default Administrator):
Accout: admin
Password: 123456

Anyway,kafka.eagle.username & kafka.eagle.password is database username & password, it's not system login accout & passowrd.

OK, I understand. Thanks you two. But I want to know where and how the login account
was configured, the coding style or the sqlite db style.

You can login kafka eagle, then reset administrator password.

@smartloli Thanks


contentRule (`text "foo")

Hi,
contentRule (``text "•") it yields at runtime:
Uncaught Error:
You seem to be using a value for 'content' without quotes, try replacing it with `content: '"•"'`

This happens since it transforms to content: "" in JavaScript instead of content: '""'. Would make sense to have string_of_content to add quotes? (Maybe add quotes when missing?)

For anyone reading, the fix is to add quotes:
ReasonML
contentRule(`text({js|" "|js}));
OCaml
contentRule (`text {js|" "|js});
ReScript
contentRule(#text(`" "`);

it used to be working 😕 something changed


improvements needed for making a command-line tool

I wanted to make my own hubot on command-line, but the current Robot base class was missing several essential features.

Hubot scripts are loaded asynchronously, but there's no callback for when that's done. I can't know when listeners are ready.
I can't detect when no listener has matched a message. I need the cmdline tool to error out in this case.
Hubot outputs all listener regexes to stdout on start, probably for debugging.

Features I've added should be non-invasive. Tell me what you think.
I now have my very own hubot command-line tool:
$ open $(hubot mustache me vin diesel)

Is this something you might want in as a separate adapter? It's different than shell adapter since it only takes a single command and then exits.

I've wanted something like this just for the sake of testing scripts too, so I didn't have to start a shell, run it, quit it, and repeat.

Here's my implementation so far (dependent on these changes). Pretty straightforward, with the exception of the horrid @imminentDeath hack. The problem is we can't know when a matched listener has stopped performing, since it can call send or reply multiple times asynchronously. So I activate a timeout on each send that kills the process if nothing happens in the next 10 ms.

I'll see about merging this after the next release.  Looks awesome @mislav.

@mtodd: I've just added a general "-q" ("--quiet") option to bin/hubot. It configures the robot instance to not output debugging info on STDOUT. I've changed the method signatures of Hubot.loadBot and new Robot, however: see a298bb2d4012413cc455e6ed6fbf5ccfb2584cbe. A Robot instance now just accepts a single parameter which is an options hash, instead of two optional parameters (scripts path and robot name).
The upside of this backwards-incompatible change is, apart from supporting the "--quiet" option, that debug and err streams of each Robot instance are now configurable. You can set them to log to a file, for instance.
I've also added my "Cli" adapter:
$ hubot -a cli -q -- "image me happy"


entproto: support service option for grpc-gateway

[x] I have searched the issues of this repository and believe that this is not a duplicate.

Summary 💡
support gen the option for the service
Motivation 🔦
When we use the grpc-gateway, we should define the method and path in the service option, like this
service AuthzPolicyService {
    rpc List (ListRequest) returns (ListResponse) {
        option (google.api.http) = {
            get: "/api/v1/authz-policies"
        };
    }
    rpc Create (CreateRequest) returns (CreateResponse) {
        option (google.api.http) = {
            post: "/api/v1/authz-policies"
        };
    }
    rpc Update (UpdateRequest) returns (UpdateResponse) {
        option (google.api.http) = {
            put: "/api/v1/authz-policies"
        };
    }
    rpc Delete (DeleteRequest) returns (DeleteResponse) {
        option (google.api.http) = {
            delete: "/api/v1/authz-policies"
        };
    }
}

Thanks for submitting this, great idea!
Would you like to contribute this feature? I'm happy to guide you through the implementation

I'd be happy to contribute, but I've been busy lately. Maybe a little later.

I had the same issue.
I solved this issue by using gRPC API Configuration YAML file. (doc)
All I had to do was just  adding YAML file and editing grpc-gateway generating code like below.
As-Is
//go:generate protoc -I .. --grpc-gateway_out .. --grpc-gateway_opt logtostderr=true --grpc-gateway_opt paths=source_relative --grpc-gateway_opt generate_unbound_methods=true  your/service.proto

To-Be
//go:generate protoc -I .. --grpc-gateway_out .. --grpc-gateway_opt logtostderr=true --grpc-gateway_opt paths=source_relative --grpc-gateway_opt generate_unbound_methods=true --grpc-gateway_opt grpc_api_configuration=your/api-config.yaml your/service.proto

As far as I checked, using google.api.http option in .proto and using gRPC API Configuration YAML file  both generate exactly same servce.pb.gw.go file.


test: improvements to requester pays tests and bucket metadata updates

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

[ ] Make sure to open an issue as a bug/issue before writing your code!  That way we can discuss the change, evaluate designs, and agree on the general idea
[ ] Ensure the tests and linter pass
[ ] Code coverage does not decrease (if any source code was changed)
[ ] Appropriate docs were updated (if necessary)

Fixes #2329 🦕
Fixes #2332
Fixes #2404
Fixes #2405
Fixes #2406
Fixes #2409

Forgive my kokoro spam, trying to test in the CI environment vs locally as differences exist.


isSetSinkIdSupported should be true in firefiox 64

isSetSinkIdSupported is returning false in new firefox version 64
it should be true, thank you

my bad:
From version 64: this feature is behind the media.setsinkid.enabled preference (needs to be set to true). To change preferences in Firefox, visit about:config.