[SUPPORT] Actions other for delete for GDPR , anonymizing PI fields

Hi !
Thank you for the work you are doing !
I want to  use CDC for capturing changes in my DB.
I will have 2 buckets

A1 bucket for historical loading and
A2 bucket for changes captured.

I will use Hudi for creating my 'gold' dataset with latest status.
At some point of time I will receive a GDPR request to remove  a person.
I will keep those 'GDPR' messages in another S3 gdpr-bucket.
On an event received on that bucket i would like to trigger my anonymization / deletion operation.
As i understand I can use Hudi for soft and hard deletes of the rows that belong to that customer.
After  using Hudi for that , information about this customer in A1 and A2 bucket is going to be not available.
Is that right ?
However can I use Hudi for anonymizing particular fields, only the PI (personal identifier ) fields in my buckets?
Thank you.
Hope my question makes sense :)

@echarso : Yes, after Hudi commits the deletes, the snapshot queries won't be able to query those records. Note that incremental queries which is looking at time window before the deletes got committed will be able to access them till the older versions are cleaned  by cleaner.
Regarding anonymization, you can plugin any custom logic for updates by implementing your own RecordPayload class : https://github.com/apache/hudi/blob/master/hudi-common/src/main/java/org/apache/hudi/common/model/HoodieRecordPayload.java

Thank you for your answer.
That sounds fine!
Could  I ask for something more ?
Once Hudi has deleted the rows is there somewhere that this operation is logged  .
Can i attach a callback or a trigger to this?

@echarso : The commit metadata in .hoodie/ folder has the operation type also logged.

thanks


telemetry tests: fix more loop vars in goroutines

there were more #30788

@stevenctl: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

release-notes_istio
9ba827bcf8d4dc5af8c8d21dfd63dc818df88929
link
/test release-notes_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest

In response to a cherrypick label: #30817 failed to apply on top of branch "release-1.8":
Applying: telemetry tests: fix more loop vars in goroutines
Using index info to reconstruct a base tree...
M	tests/integration/telemetry/stackdriver/stackdriver_filter_audit_test.go
M	tests/integration/telemetry/stackdriver/stackdriver_filter_test.go
M	tests/integration/telemetry/stats/prometheus/stats.go
Falling back to patching base and 3-way merge...
Auto-merging tests/integration/telemetry/stats/prometheus/stats.go
Auto-merging tests/integration/telemetry/stackdriver/stackdriver_filter_test.go
Auto-merging tests/integration/telemetry/stackdriver/stackdriver_filter_audit_test.go
CONFLICT (content): Merge conflict in tests/integration/telemetry/stackdriver/stackdriver_filter_audit_test.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 telemetry tests: fix more loop vars in goroutines
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to a cherrypick label: new issue created for failed cherrypick: #30820

In response to a cherrypick label: #30817 failed to apply on top of branch "release-1.9":
Applying: telemetry tests: fix more loop vars in goroutines
Using index info to reconstruct a base tree...
M	tests/integration/telemetry/stackdriver/stackdriver_filter_audit_test.go
M	tests/integration/telemetry/stackdriver/stackdriver_filter_test.go
Falling back to patching base and 3-way merge...
Auto-merging tests/integration/telemetry/stackdriver/stackdriver_filter_test.go
Auto-merging tests/integration/telemetry/stackdriver/stackdriver_filter_audit_test.go
CONFLICT (content): Merge conflict in tests/integration/telemetry/stackdriver/stackdriver_filter_audit_test.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 telemetry tests: fix more loop vars in goroutines
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to a cherrypick label: new issue created for failed cherrypick: #30821


UIINREACH-49, UIINREACH-50: Manage current contribution  and history

Purpose
In this PR manage contribution feature is added
The  related stories are UIINREACH-49 and UIINREACH-50
Current functionality covers the first phase of manage contribution development
TODO
In the second phase the pause, cancel, resume functionality will be added according to UIINREACH-55
-unit tests will be added within the UIINREACH-55

Test errors found. See https://jenkins-aws.indexdata.com/job/folio-org/job/ui-inn-reach/job/PR-59/1/


Namespaces are placed in a new line

When formatting a document, every namespace attribute is placed on a new line.
Example:
<?xml version="1.0" encoding="UTF-8"?>
<parent xmlns="namespace.url" xmlns:foo="bar">
   <child>Info</child>
</parent>

is converted to
<?xml version="1.0" encoding="UTF-8"?>
<parent
   xmlns="namespace.url"
   xmlns:foo="bar">
   <child>Info</child>
</parent>

It will be nice to have at least an option to disable this behaviour and put every node tag on a unique line with all its attributes.

Fixed in 08c81f7.

Fixed in version 1.1.0 (now on marketplace).
A new setting has been created, xmlTools.splitXmlnsOnFormat. Setting this to false will keep xmlns attributes on the same line when formatting XML.

Wow, that was fast, thank you!
Now there's a related issue. If a document were formatted with xmlTools.splitXmlnsOnFormat set to true (default behaviour) and then formatted again with option changed to false, document won't change: xmlns tags will remain on their own lines.
On the other side, if formatted with split option at false and then again with it at true, xmlns tags would be separated on new lines.

No problem!
This is technically an issue with the minification function as XML is first linearized before it is formatted. The minifier is leaving newlines in place as it is only removing them from between > and <. I've created issue #16 to track this correction.

Ok, thank you for your support!

Fixed in version 1.3.1 (now on marketplace).


[Proposal] Assets linking

Hello,
I just thought how would it be if publishing (duplicating) assets from packages wasn't necessary? If Laravel had built-in routes to assets from packages instead of copying them to /public folder with asset:publish command? Same for views and configs. Are there any reasons why it's required to do it manually this way?

Routing all assets through routes isn't very efficient. Perhaps you could symlink the assets to their vendor folder instead.

Similar to the vendor:publish command, a vendor:assets command would be nice, which would overwrite existing assets (instead of skipping them, which is more logical for config etc). And if possible, just create a symlink between directories.

No explanation?

You said:

Routing all assets through routes isn't very efficient. Perhaps you could symlink the assets to their vendor folder instead.

I assumed that meant this was a bad idea?

Yeah just the part about routing it through Laravel, not the whole 'asset linking' part.

Sorry, I skipped past this very quickly. Thanks for catching this.

I'm not sure if assets routing is that inefficient nowadays. Is it really that much of an overhead?
My idea was to simplify packages installation process. I believe that the assets could stay where they are and be linked to by specific URL containing package name, maybe even with dedicated method, like:
package_asset('images/cow.png', 'johnthefarmer/myfarm')

We are now deep in XXI century now and calculating every microsecond of performance is not such of the case now. This one small operation per asset won't kill anyone and it will make projects more robust, with no manual "publishing".

Yeah, asset routing is still incredibly inefficient. We're not talking microseconds, generally you'd be looking at hundreds of milliseconds and that all adds up very quickly.

@kokokurak Yes, booting the entire framework for serving an already static file is highly inefficient.

Maybe then the framework should provide assets service without booting itself? Keeping assets in /public folder is not enough for most projects. Assets pipelines etc. are nice, but sometimes I'd like to just use assets from packages. I will defend my idea here, because I find assets publishing really unnecessary and wrong.

http://symfony.com/blog/new-in-symfony-2-6-smarter-assets-install-command
# make a hard copy of the assets in web/
$ php app/console assets:install

# if possible, make absolute symlinks in web/ if not, make a hard copy
$ php app/console assets:install --symlink

# if possible, make relative symlinks in web/ if not, make a hard copy
$ php app/console assets:install --symlink --relative

I think this would be an okay method.
Each package provider could register it's paths, similar to the publishes config.
$this->assets($sourceDir, $targetDir);
Running php artisan vendor:assets would delete the existing folders and overwrite with the new assets. php artisan vendor:assets --symlink would try to create a symlink (on linux systems) between the vendor folder and the public folder.
You would just run that 1 command on composer install/update.

And the hard part for that is already done here: https://github.com/symfony/symfony/blob/2.7/src/Symfony/Bundle/FrameworkBundle/Command/AssetsInstallCommand.php

I'm still NO for additional commands and/or copying/symlinks or any kind of data duplication.

I don't get it, how would you want it to work otherwise?

Symlinking is not data duplication? Just run some benchmakers, load a simple image/css file through Laravel or directly with apache. That's a real difference.. Not much for a few files but a lot of vendor files exist of small icons, multiple scripts etc.

As I said, I'd like to get dynamic access to assets. They would resist in package folder and have nothing to do with /public. Then, the framework would route it. There's no need to boot the whole framework for this operation. Just simple route evaluation. I'm always against all kinds of desynchronisation and symlinking is that. I want to be sure that deleting package folder doesn't leave any garbage. This is actually what the idea of module is.

There is not 'simple route evaluation' without booting the framework (currently). You could look into things like Assetic, but I think they recommend dumping the assets to files anyways, for performance: http://stackoverflow.com/questions/22873164/difference-between-asseticdump-and-assetsinstall
You could just write your own php/htaccess file that outputs the vendor files, but you'd have to know the folders, which you can't with either using the same folder for each package, or having them set in the ServiceProvider, which needs them booted (or you'd cache the result to file).
But I still don't really see the problem with copying/symlinking. If you keep the package folder just for vendor packages, you could delete the package folder and republish the active packages, so everything is clean again, right?

And packages could still route them off course, like I did here: https://github.com/barryvdh/laravel-debugbar/blob/master/src/Controllers/AssetController.php
But that's for development. it really is noticably slower..

This is proposal, idea to improve our workflows. Of course, running one more command is not a problem. And if one is no a problem, why not running two? etc. Laravel makes developer's life easier and I'm having ideas to make it even better, that's it. I believe the number of manual steps should be kept to minimum.
After our discussion, I find this assets publishing to /public even weirder than before :smile:

Okay I don't share your opinion, so I've created a proposal for copying the assets ;)
https://github.com/laravel/framework/issues/7147

Just curious, if assets are published because routing them is heavy, why are views and configs published as well? This is beyond me, why can't views and configs just stay in a package folder?

Because upgrading the package could break your config. The config should be local to your application.

They can. You just publish them if you want to override them. You can't change files in the vendor folder.
And they aren't 'routed', they are just read in the same request.

This is probably something to be implemented in a package for laravel. If anyone has a good solution for this, they can propose it to Taylor to go into the 5.1 core.


Timezone feature

Summary
Add timezone support for mobile. Following these 2 PRs:
https://github.com/mattermost/mattermost-webapp/pull/696
https://github.com/mattermost/mattermost-server/pull/8185
Ticket Link
https://mattermost.atlassian.net/browse/PLT-541
Checklist

[x] Has UI changes
[x] Includes text changes and localization file updates

Device Information
This PR was tested on: [iPhone 6 simulator, Nexus 5 emulator]
Screenshots
iOS

Android

In action

@miguelespinoza is this under what category in the settings screen?

It's under Displays, Let me send a screenshot @enahum

@enahum

@enahum and @hmhealey just not resolved the conflicts.
Also, now includes viewing a users local time from their profile page.

@enahum I've been addressing MM feedback from the server and webapp PRs.
I'll get to this PR once I'm done.
Thanks for the review 😄

@enahum when you get a chance could you review this PR.
One remaining issue which will block this PR until there's a solution.
formatted_time.js will use the current performant solution which uses simple math.
the api will need to support offset support in order to work properly

@enahum let me know how this looks 😄
Also, an FYI, this feature won't work until server version 4.9 is in effect

At this point, just waiting for the server PR to get merged
https://github.com/mattermost/mattermost-server/pull/8185
@enahum then this can get tested 😄

How exactly will the server need an update to make this work?
I'm plagued by having my Android device show me times in MDT whereas I'm in EDT right now. 2 hours different compared to the WebUI/Electron app.
How do I get my phone to show me the correct times today and not whenever my administrator decides to upgrade their 4.5 server instance to something newer ??

@miguelespinoza rebase required

@miguelespinoza apart from @hmhealey comment you need to rebase this

I'll make the changes hopefully today 😄
thanks @hmhealey and @enahum

@enahum and @hmhealey took a bit to finally get to this PR.
The changes have been made 😄

@miguelespinoza can we re-focus on this PR, @hmhealey has request some changes and I would love to have this merged for 1.8

Sorry about the delay @enahum.
@hmhealey change has been addressed.

@enahum this PR is ready.
Thanks to the JSCore upgrade we can remove the polyfill for timezoe support

@miguelespinoza this PR needs a rebase

@enahum and @hmhealey PR has been rebased

@enahum the changes have been made.
As for unbundling changes,  yes.  We will need to add them into the modulePaths.js file.
Let me know how I can help with that

@miguelespinoza please do

@enahum added the timezone related paths to modulePaths

Thanks @enahum this PR is ready.   Hoping to get this merged in the upcoming days 😄

@miguelespinoza Sorry for the delay in re-reviewing this, but there's another conflict that needs to be fixed :/

@miguelespinoza one more rebase dude

@enahum hey I've rebased and resolved any conflicts.  Should be good to merged now 😄


Option for using station data for baseline

          Option for using station data (e.g. Mace Head) for baseline when comparing simulations with measurements.

Originally posted by @EricSaboya in https://github.com/openghg/openghg/issues/395#issuecomment-1233096594

There is code to do this in the ACRG repo, if you want to use footprint wind directions to select the "baseline" times: https://github.com/ACRG-Bristol/acrg/tree/develop/acrg/scripts/mhd_flat_prior
I think Alistair has a more sophisticated way of selecting "baseline" times, so we might want some flexibility in how baseline values are chosen.


NIFI-7475 JWT processor bundle

Thank you for submitting a contribution to Apache NiFi.
Please provide a short description of the PR here:
Description of PR
NIFI-7475 Processor bundle to JWT sign/unsign JSON
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:

[x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?

[x] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

[x] Has your PR been rebased against the latest commit within the target branch (typically main)?

[x] Is your initial contribution a single, squashed commit? Additional commits in response to PR reviewer feedback should be made on this branch and pushed to allow change tracking. Do not squash or use --force when pushing to allow for clean monitoring of changes.

For code changes:

[x] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
[x] Have you written or updated unit tests to verify your changes?
[x] Have you verified that the full build is successful on JDK 8?
[x] Have you verified that the full build is successful on JDK 11?
[x] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
[ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
[ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
[x] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?

For documentation related changes:

[x] Have you ensured that format looks appropriate for the output in which it is rendered?

Note:
Please ensure that once the PR is submitted, you check GitHub Actions CI for build issues and submit an update to your PR as soon as possible.

Thanks for this contribution. It might feel like I put a lot of comments/questions that are designed to prevent things from being merged. That's not my intent. We get a lot of submissions which work very well for a specific use case and "scratch your own itch" as it were, and people don't evaluate/aren't aware of a lot of the negative/edge cases which can arise in the many scenarios users deploy NiFi into. If you're not interested in trying to address all the possible combinations and failure scenarios, that's ok. We always appreciate sharing these features with the community, and often suggest hosting the code for the custom processors in your own repository so interested users can build and deploy them locally. To be accepted and bundled as part of the core project, however, we have a (non-legally obligated) responsibility to support and maintain the code, so we have to reach a certain threshold of familiarity and basic behavioral consistency in order to do that. Thanks.

Thanks for the review @alopresto, I'll try to address all the comments as best I can over the next few weeks when I get some time


Run initial SQL scripts at docker test environment start up

Purpose
$title
Fixes ballerina-platform/ballerina-standard-library#1729
Examples
Checklist

[ ] Linked to an issue
[ ] Updated the changelog
[ ] Added tests

@lahirusamith How do you much with the pool count to 20?

@daneshk this 20 value is reached from 100 by running tests manually. Yes It seems we need to increase this number when adding new test cases.

Global connection pool count is set to 10 in config.toml file in tests folder again as the procedureCallResult are closed and no random connection timeouts coming.


Use Segoe UI Variable Static instead of Segoe UI

The font Windows 11 uses, Segoe UI Variable has a non-variable font version called Segoe UI Variable Static that could be used in this theme instead of the old Segoe UI. https://aka.ms/SegoeUIVariable is the link to the font.

Good catch. Hopefully updated.


Fix 2D Gzz when sintheta==0

When sin(theta) == 0, Gz*sintheta has no attribute .dx. This correction is now consistent with the 3D Gzz centered kernel

We still need renaming of commits here as shown in: https://github.com/devitocodes/devito/wiki/Tags-for-commit-messages-and-PR-titles

@dimitri-voytan could you rebase that branch. I used the github browser to update the branch which removed your commit ownership so for the sake of recognizing this is your PR, it would be good to have you rebase it to put back your name on it.

Rebased to main

Thanks. Looks like something went wrong though. Sorry for all the steps

Took care of it in #1855, lemme know if you ok with it, it should still show you are the author of the commit

Looks good to me!

Fixed in #1855


⚠ Turnos 24x7 has degraded performance

In 4230700, Turnos 24x7 (https://reservas-dev.alternativasinteligentes.com/) experienced degraded performance:

HTTP code: 200
Response time: 5788 ms

Resolved: Turnos 24x7 performance has improved in 79be22a.


95 Wavelength simulation didn't finish after 6h

modifying line 7 in main.py to "num_ch = 95"
after 6h main.py didn't finish
if we can't find the root cause right away it might be useful to insert some code to report the progress on the terminal.

seems it simply takes more time than expected. I ran the same test but added some print commands to see if the algorithm got stuck or is just slow. Starting it at about 19:30 yesterday and at 12:30 today it had calculated 69 wavelength in 17h. My MAC isn't too slow either. What is the potential to speed up?

Now the main computes the GNLI in three points (the red dots) for each channel. One point per channel is enough. To do this you can comment the line 9 and 10 of the main and impose the fch_NLI=fch like this:
#fch_NLI = np.concatenate((fch,fch+.01,fch-.01))
#fch_NLI = sorted(fch_NLI)
fch_NLI = fch
But consider also that usually a conservative approach is used. Thus the GNLI is computed just in the worst point which is in the middle of the central channel. In this case it is enough to comment the 9th and the 10th rows, as before, and to use fch=0. In this case the code will be:
#fch_NLI = np.concatenate((fch,fch+.01,fch-.01))
#fch_NLI = sorted(fch_NLI)
fch_NLI = [0]
Furthermore, if you want to see all the 95 channels in the plot, also the 23th row needs a modification, since, with the command
f1_array = np.linspace(.-3, .3, 1e3)
you cannot see all the channels. In this case you should substitute the previous command with the following:
f1_array = np.linspace(np.amin(fch), np.amax(fch), 1e3)

finished calculation for 95 wavelength after ~22.5h (Elapsed: 80381.94052100182). Result see preview. Will file another issue as the WDM comb in the graphical representation did not scale although it might be addressed with f1_array change you proposed.
For what is concerning the performance, I would suggest to introduce a parameter when calling gnpy that allows to select the performance/accuracy.
Proposal

adjust number of points per channel (1..3)
adjust channels--> is there a way to calculate every n-th channel and intrapolate? or any other means to approximate with reasonable accuracy?

About your suggestion, me and Vittorio discussed today about a more intuitive way to call the gnpy function also including the possibility to calculate the GNLI in the worst case, in the n-th channel and so on..
So any suggestion about this are appreciated.
Thank you for the suggestions

Ale,
If I had a wishlist:

  If there is an easy way to parallelize the calculation, that may bring some performance gain. I.e. If I run the thing on a computer with 8 cores, it might be a good idea to let the simulation run on 6 cores while working on the other two myself. I helped myself by using "nice" which worked too.

  An iterative approach that would allow to stop the calculation at any given time and receive a meaningful result – obviously with less precision but with an indication how precise it is. Kind of starting with i.e. 100 wavelength, user is stopping after a while where i.e. 10 results have been calculated, the rest interpolated so we have an accuracy of 10%, the rest is interpolation of some kind. This would mean the sequence of the spectrum calculated would need to spread out i.e. the extremes and the center

  It appears that most of the information is at the edges of the spectrum and the center. Perhaps it would be a good idea to define a "calculation-mode" where the wavelengths to be calculated are user-defined in a list and the rest is approximated. So a user could define a "fast mode" with few interesting points and other modes with more precision

  Keep in mind we need to extend towards flexgrid in future which includes different spectral densities. Maybe some of the above doesn't fit well – not sure though

  I find main.py really useful for playing with the SW. One thing I was missing is to understand whether gnpy makes progress or is stalled. Would be great if gnpy had a kind of "progress parameter" (I used f in f_array in the first master branch) to understand where it is. In general (remember this is a wish list) it might be nice if some code in main.py would read once a minute a progress parameter from  gnpy and print it to the terminal. The reason to do it this way is that such functionality can later be used to produce a progress bar of some kind.

Thanks
Gert
From: aleFerrari<EMAIL_ADDRESS>Reply-To: Telecominfraproject/Physical_Simulation_Environment<EMAIL_ADDRESS>Date: Thursday, 1. June 2017 at 19:22
To: Telecominfraproject/Physical_Simulation_Environment<EMAIL_ADDRESS>Cc: Gert Grammel<EMAIL_ADDRESS>Author<EMAIL_ADDRESS>Subject: Re: [Telecominfraproject/Physical_Simulation_Environment] 95 Wavelength simulation didn't finish after 6h (#4)
About your suggestion, me and Vittorio discussed today about a more intuitive way to call the gnpy function also including the possibility to calculate the GNLI in the worst case, in the n-th channel and so on..
So any suggestion about this are appreciated.
Thank you for the suggestions
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://github.com/Telecominfraproject/Physical_Simulation_Environment/issues/4#issuecomment-305562001, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AOcHVBd9hB3Y0-7jLjFYEe84hWEh1y-Eks5r_vNagaJpZM4Nr0pU.

re-ran the code again trying with 10 channels and un-commenting the lines indicated by ale: starting from line 7:
def main():
num_ch = 10
if num_ch % 2 == 1:  # odd number of channels
fch = np.arange(-np.floor(num_ch / 2), np.floor(num_ch / 2) + 1, 1) * 0.05  # noqa: E501
# fch_NLI = [0] #to compute single channel
fch_NLI = fch	#to compute all channels
else:
fch = (np.arange(0, num_ch) - (num_ch / 2) + 0.5) * 0.05
fch_NLI = [-.5 * 0.05, .5 * 0.05]
fch_NLI = np.concatenate((fch,fch+.01,fch-.01))
fch_NLI = sorted(fch_NLI)
it seems no NLI is calculated (see .jpg)

Your result is strange. I have just remove the comments on 15th and 16th lines and set num_ch=10.
Here is my code from line 7 to line 16:
def main():
num_ch = 10
if num_ch % 2 == 1:  # odd number of channels
fch = np.arange(-np.floor(num_ch / 2), np.floor(num_ch / 2) + 1, 1) * 0.05  # noqa: E501
fch_NLI = [0]
else:
fch = (np.arange(0, num_ch) - (num_ch / 2) + 0.5) * 0.05
fch_NLI = [-.5 * 0.05, .5 * 0.05]
fch_NLI = np.concatenate((fch,fch+.01,fch-.01))
fch_NLI = sorted(fch_NLI)
And the resulting figure is the one attached


golang: ~2x speedup for encodeTensor()

This is duplicate of https://github.com/tensorflow/tensorflow/pull/14368, but now it can be merged safely because https://github.com/tensorflow/tensorflow/pull/14331 is merged.
CC: https://github.com/tensorflow/tensorflow/pull/14408
before:
$ go test -bench=.
goos: linux
goarch: amd64
pkg: github.com/tensorflow/tensorflow/tensorflow/go
BenchmarkNewTensor/[150528]-8<PHONE_NUMBER> ns/op
PASS
ok      github.com/tensorflow/tensorflow/tensorflow/go  2.116s
after:
$ go test -bench=.
goos: linux
goarch: amd64
pkg: github.com/tensorflow/tensorflow/tensorflow/go
BenchmarkNewTensor/[150528]-8<PHONE_NUMBER> ns/op
PASS
ok      github.com/tensorflow/tensorflow/tensorflow/go  2.021s

Can one of the admins verify this patch?

Jenkins, test this please

@asimshankar Yeah, this is great idea. I'll open a new pr for this one.

Jenkins, test this please

SUCCESS

FAILURE

That test failure seems un-related. Haven't dug in, but it seems that the continuous builds are passing beyond that point, so perhaps something fixed at head.

Jenkins, test this please

Jenkins, test this please.


fix: 1. glance/keystone version handler fix 2. allow run glance as normal user

这个 PR 实现什么功能/修复什么问题:
修正：1. keystone和glance的version show handler
2. 允许glance以非root用户运行(deployer以root运行)
是否需要 backport 到之前的 release 分支:

release/2.10.0
release/2.11
release/2.12

/area glance
/area keystone

Codecov Report

Merging #2665 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master   #2665   +/-   ##
======================================
  Coverage     7.1%    7.1%
======================================
  Files         466     466
  Lines       73513   73513
======================================
  Hits         5222    5222
  Misses      67861   67861
  Partials      430     430

Flag
Coverage Δ

#aFlag
7.1% <ø> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d884992...d29754f. Read the comment docs.

/approve
/lgtm


v1.25: Prevent recursion during premature reset check (#30270)

Backport #30270 into v1.25

apologies i closed this by accident, kicking CI

/retest


Add Programmatic

Adds the HumanLoop Programmatic platform. License says "while we're in closed beta, we are operating on a free-to-use revocable license... Programmatic is not open source." So not sure if this qualifies for this list but thought I'd check.

Unfortunately, we're only looking to include truly open-source tooling here, and not just free-to-use. However, thank you so much for checking and feel free to add more tools that you see fit!


Clicking cancel still triggers a callback

Clicking cancel still triggers a callback, which will result in junk data being sent out. The fix is easy, just add a call back to the cancel button that returns true to indicate that the cancel button was clicked, and then in the popup.then block check to see if res is true (indicating that the cancel button was clicked) and bail out without firing callback() :
`
            var popup = $ionicPopup.show({
                templateUrl: "monthpicker.html",
                title: scope.title,
                scope: scope,
                buttons: [
                    {
                        text: scope.cancelText,
                        type: scope.cancelClass,
                        onTap: function(e){
                          return true;
                        }
                    }
                ]
            });
            popup.then(function(res) {
              if(res){
                return null;
              }
                //return clone obj not internal private obj
                callback({
                    year : scope.selection.year,
                    month : scope.selection.month
                });
            });

`

Can you submit a pull request with this change? :)

I've created a pull request, pull request #12

I get the same question too!

scope.changeYear = function(index) {
scope.selection.year += index;
};
This code is the reason

We need a price judgment

popup.then(function(res) {
if(res){
return null;
}
//return clone obj not internal private obj
callback({
year : scope.selection.year,
month : scope.selection.month
});
});


Bibtex To JSON initial work

Fixed airbnb warnings
Updated eslint script command for CLIEngine error
Included dev dependencies
Included samples for reference
Included example for local package development
Included further rules and husky

I replaced the library and updated the parser, its much better now. please see.


Revert 15 incorrect branch

What this PR does / why we need it:
Fixes accidental version bump in branch
Which issue(s) this PR fixes:

Fixes #
Applies to Kubernetes versions:

1.14.x

Special notes for your reviewer:
Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.
Release note:

revert accidental version bump

I see the issue, but this PR will change master. This was the result of a snafu in the way that I managed the branches. I have fixed this in the 1.14.x and 1.14.6 branch and tag.


template.instantiate doesn't work

Hey there,
actually I'm pretty new to your addon, but I think this is a bug looking on the old report.
Error: XML-RPC fault: Parameter that is supposed to be integer is not
I think, there also came a new parameter when I looking in their documents.
Best,
d3dx9

Hello @d3dx9, I think that there is no bug, but you are passing wrong type of state argument, it have to be boolean.
There are docs https://docs.opennebula.org/5.0/integration/system_interfaces/api.html#one-template-instantiate. I checked impementation, and it is according to docs.
First two arguments (Session string and Object ID) are automatically added by this package, so you just need to define name, state and template, where name is string, state is boolean and template is string


Add trunc, ceil, floor to math module

float.__trunc__ in #885
missing float support for  math.ceil, math.floor

Codecov Report

Merging #888 into master will decrease coverage by <.01%.
The diff coverage is 63.63%.

@@            Coverage Diff             @@
##           master     #888      +/-   ##
==========================================
- Coverage   63.73%   63.73%   -0.01%
==========================================
  Files          88       88
  Lines       14771    14793      +22
  Branches     3270     3275       +5
==========================================
+ Hits         9414     9428      +14
- Misses       3214     3217       +3
- Partials     2143     2148       +5

Impacted Files
Coverage Δ

vm/src/stdlib/math.rs
37.19% <63.63%> (+4.09%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 88e52ef...8c0b559. Read the comment docs.


Implemented multiple K's - #23

Extended definition of isStable of PMTracker
Adapted and extended PMDatabaseTest class
changed commitThreshold to List


Turn remaining tests with time critical sections into TimingTest

Brief feature description
The CI on some targets, especially Windows & FreeBSD, is more sensitive in timing tests which lead to failing CI builds. This can be written more robust by using our gtest TimingTest extensions.

@elfenpiff before we start to make the tests a TimingTests and hide bugs like it already happened at least once, we should check it these tests could be refactored without making them a TimingTest

@elBoberido this is a good idea. I add this to the issue!


Setuptools greater equals

@aweigold No worries! We're going to think soon about being a little more flexible with the requirements as a whole. Feel free to get in touch / make an issue if you have any preferences.


Access to variables within .bref.yml

Hello,
I see you can add a build hook within .bref.yml. I was wondering about using that to run grunt to prepare the static files (CSS, JS etc). So I would run a hook like 'grunt production' and presumably then those generated (minified) files would get deployed.
... which got me thinking ...
Can you access variables within that .yml file in the same way serverless mentions you can in its yml? (https://serverless.com/framework/docs/providers/aws/guide/variables/). Only if so, would it be possible to set the build hook to be like 'grunt ${opt:stage}'? Since then it could dynamically run 'grunt staging' or 'grunt production', or whatever the stage being deployed was, and so do a different set of operations (like upload them to a different location). Thanks!

Can you access variables within that .yml file in the same way serverless mentions you can in its yml?

It is not possible at the moment indeed. It sounds like a good idea though.

Ok. If you wanted to add for a build hook, I would think you would simply pass it along:

https://github.com/mnapoli/bref/blob/master/src/Console/Deployer.php#L74
$this->generateArchive($io, $progress);
.... to
$this->generateArchive($io, $progress, $stage);

(and the function params would need that third one adding, so it expects it)

https://github.com/mnapoli/bref/blob/master/src/Console/Deployer.php#L193
Add a line prior to that one:

if (null !== $stage) {
  $buildHook = str_replace('${opt:stage}', $stage, $buildHook);
}

... so that would simply turn 'grunt ${opt:stage}' into 'grunt production' (or whatever). Replacing the string with the stage.
Thanks.


updating Mactex

today is the day where texlive updates to 2015
this cask updates the version to the latest + updates the names of the packages to uninstall

There are conflicts. You need to pull changes beforehand.

sorry, this reached my level in understanding PR as I could pull and push with no conflict:
$ git push meduz mactex
Everything up-to-date
$ git pull meduz mactex
From https://github.com/meduz/homebrew-cask
 * branch            mactex     -> FETCH_HEAD
Already up-to-date.

how should I do that?

You’re pulling your own repo. You need to pull this one.


khepri_machine: Run the query anonymous function from the calling process

Why
Before this change, the anonymous function passed to khepri_machine:fold/5 was executed by the Ra server process. This had two downsides:

it blocked the Ra server to serve writes
the anonymous function couldn't query the Ra server itself because it would deadlock

How
The alternative implemented in this patch is to get the whole Khepri tree from the Ra server, then run the anonymous function, this time from the calling process.
The downside is that the whole Khepri tree is copied to that calling process.

I'm still not sure this alternative approach is what we want. Copying the entire Khepri tree to the calling process could be very expensive and the memory footprint could sky-rocket.
Another solution would be to try to run the anonymous function from the Ra process like before. But if it exits with a calling_self exception, then we could re-run it from the calling process. But then, the anonymous function must have no side effects, or the side effects should be idempotent. Perhaps we could accept a {can_be_restarted, true} option, so that the caller lets Khepri know it can re-run the anonymous function.
What do you think, @dcorbacho and @the-mikedavis?
To give some context to this issue, when RabbitMQ queries transient queues from the database, it queries the Khepri members from a Khepri query anonymous function:
khepri:fold(
  StoreId,
  PathPattern,
  fun(QueuePath, NodeProps) ->
      ...
      %% This queries the Ra server and can't be executed by the Ra server
      %% itself because it would deadlock. gen_statem throws a `calling_self`
      %% exception.
      Members = khepri:members(StoreId),
      ...
  end,
  []).

I pushed an additional commit to implement that option that lets the caller decide if it wants the tree to be copied to be able to do nested queries.
I would love some feedback on the approach and the option name :-)

We ended up going a different direction on this in the server similar to https://github.com/the-mikedavis/rabbitmq-server/commit/aed8ddd80e35d97b1afeb277f057209d845ef548. We use khepri:get_many/3 to get all of the records under the path and then fold separately with maps:fold/3 so that the fun isn't called within the Ra server process.
@dumbbell should we close out this PR for now? We could re-open it if we find another use-case and want to make it possible to do while still calling khepri:fold/5


ui:  Update/fix proxy form

Signed-off-by: Ryan Northey<EMAIL_ADDRESS>fix #64
fix #95

Codecov Report

Merging #96 (d9de552) into main (1bc8cd8) will decrease coverage by 0.70%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main      #96      +/-   ##
==========================================
- Coverage   27.07%   26.36%   -0.71%
==========================================
  Files          50       50
  Lines        1751     1798      +47
==========================================
  Hits          474      474
- Misses       1277     1324      +47

Impacted Files
Coverage Δ

ui/src/proxy/forms.js
6.71% <0.00%> (-2.76%)
:arrow_down:

ui/src/proxy/modals.js
8.47% <0.00%> (-0.79%)
:arrow_down:

ui/src/shared/forms/ports.js
6.25% <0.00%> (-0.65%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1bc8cd8...d9de552. Read the comment docs.


Feature/#1799 Map Vault Pagination

Create Pagination for Map Vault

Need to update Unit Tests

Nice, so there are 3 ppl that did pagination in the vault. And I like the one the most in the mod vault. maybe you can look at what they did and make adjust yours in this way.

Will take a look and adjust

Sorry meant online replays https://github.com/FAForever/downlords-faf-client/pull/1808/files They also know the total number of pages.

Should also be able to merge theirs soon, after I have a final look. But it seems pretty well done.

taken care of by #1845


fix: updated ts-jest

What kind of change does this PR introduce? (check at least one)

[x] Bugfix
[ ] Feature
[ ] Code style update
[ ] Refactor
[ ] Docs
[ ] Underlying tools
[ ] Other, please describe:

Does this PR introduce a breaking change? (check one)

[ ] Yes
[x] No

Other information:
Audit fix

bump, please fix the conflicts and accept to fix the audit warning with ts-jest -> yargs-parser


Move dev tools option

Sometimes the ergonomics of a button- stuck tool is hard to use. Could there be a button, like in native dev tools to pin the query tool to the sides, or top/ bottom

Can you be a bit more specific? What is a button-stuck tool please?
i think there are already options to position the devtools differently if that’s what you mean..

No problem, I probably shouldn't write features requests while walking the dog.
Currently we can set the position of the flower tool by passing the position parameter:
<ReactQueryDevtools position={"top-right"} />

That puts the flower trigger in the top right corner. However, the drawer always opens at the bottom.
A user could pass styles and classes in through panelProps. And position the r-query devtools where-ever they please.
What I'm thinking is a toggler within the devtools that allows the user to switch the drawer position on the fly. The example I'm thinking of is the layout switcher in Chrome:

This would allow  a user to reposition the devtool drawer on the fly as they might switch page layouts, or other window sizes.

❤ the idea, would you like to add it?

Yes, I'll work on it.
═════════
Clayton Salem
413-768-8522
═════════
On Sun, Nov 21, 2021 at 1:22 AM Dominik Dorfmeister <
@.***> wrote:

❤ the idea, would you like to add it?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/tannerlinsley/react-query/issues/2994#issuecomment-974762811,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABMAD6A5FUG6FUYCC7QSEFLUNCF3RANCNFSM5IN4GYFQ
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

@TkDodo  @claytron5000  I could work on this if there is one currently working on it

@salamaashoush go ahead, I've assigned you to the issue.

Hi,
I created https://github.com/nirtamir2/react-query-devtools-extension to solve this problem. It works well in development but I have a little problem with its event when building it for production. You can use it and integrate it back to react query

@nirtamir2  this is a pretty cool browser extension, but I am just adding the ability to reposition the current devtools so you don't need to install a browser extension

@TkDodo  if you have time could you please have a look at this PR https://github.com/TanStack/query/pull/3678


what's failing kestrel to run on heroku

From @AbhimanyuAryan on February 10, 2017 23:12
I have created an new asp.net core project and it runs on locally but fails when deployed to heroku. Please see this issue and help me understand this problem. What's causing this issue
Copied from original issue: aspnet/KestrelHttpServer#1357

@AbhimanyuAryan, could you post both the project.json contents here? Or better yet if possible could you upload both projects to Github and share the link?

@ajaybhargavb link to repo
repo generated by yeoman: https://github.com/AbhimanyuAryan/ivdstudios
repo generated by dotnet: https://github.com/ivdstudios/DotNetCoreMVC-LinuxMint

/cc @pranavkm

@AbhimanyuAryan, by default, the CLI uses the folder name as the output assembly name. When deploying the Heroku, it looks like it's checking out the application in a randomly named directory: log  : Restoring packages for /tmp/tmp.d4Qf6iTUHZ/app/project.json...
Try specifying the outputName in your project.json:
{
  "buildOptions": {
    "outputName": "ivdstudios"
     ...
  }

@AbhimanyuAryan can you let us know if this worked for you? Thanks!

To add to this, updating to the csproj should also solve this issue. The default value for the project name is inferred from the project file name (MyApp.csproj) and not the directory. You have the ability to change this value using AssemblyName, but where project is checked out shouldn't affect your output binary name.

@Eilon no I still can't figure out. @pranavkm I'm have a .csproj project. What do you think should I add here?
<Project ToolsVersion="15.0" Sdk="Microsoft.NET.Sdk.Web">

  <PropertyGroup>
    <TargetFramework>netcoreapp1.0</TargetFramework>

  </PropertyGroup>

  <ItemGroup>
    <PackageReference Include="Microsoft.AspNetCore" Version="1.0.3" />
    <PackageReference Include="Microsoft.AspNetCore.Mvc" Version="1.0.2" />
    <PackageReference Include="Microsoft.AspNetCore.StaticFiles" Version="1.0.1" />
    <PackageReference Include="Microsoft.Extensions.Logging.Debug" Version="1.0.1" />
    <PackageReference Include="Microsoft.VisualStudio.Web.BrowserLink" Version="1.0.1" />
  </ItemGroup>

</Project>

@AbhimanyuAryan can you share your full updated app on GitHub, plus also what current error(s) or behavior(s) you're getting?

@AbhimanyuAryan feel free to reopen this work item once you have a repro we could try somewhere. It's difficult to determine much from the details you've provided.


Templates suggestion

It’s a great plug-in especially it works on my tablet too. Are you thinking of adding templates or more customisation features? Like to remove reference below every highlight as long as they be belong to the same pdf. Also changing highlights from block quotes to “mark” or something different. Also changing presentation based on highlight color - for example red highlight is H1 title .. etc. Finally adding extracted images support.

Same as #9
With the new version 1.2.0 it is possible to style the extraction completely by yourself based on your own template with some attributes:
highlightedText: 'Highlighted text from PDF',
folder: 'Folder of PDF file',
file: 'Binary content of file',
filepath: 'Path of PDF file',
pageNumber: 'Page number of annotation with reference to PDF pages',
author: 'Author of annotation',
body: 'Body of annotation'


tickets/PREOPS-1200

TAP-based. Do not merge until confirmed to run at data.lsst.cloud.

In Section 2.2, I feel like it would be helpful to be a bit more "pedagogical" in explaining what one might look for in each figure. It's easy to just skim past them if you don't know what the "takeaway" should be.


Add num_proc to from_csv/generator/json/parquet/text

Allow multiprocessing to from_* methods

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.

I ended up moving num_proc to AbstractDatasetReader.__init__ :)
Let me know if it sounds good to you now


Hi(:

Hey also new and i wasn't sure to start an issue just to say hi, but since someone has already done this. Hi! Love your work y'all, and i really appreciate you putting these logos up on github! Keep going!


yet another install unknown error (probably due to chromeos changes)

Please paste the output of the following command here: sudo edit-chroot -all

sudo: edit-chroot-all: command not found
Please describe your issue:
After multiple attempts, cannot install. Ultimately I am still ignorant of many things about the install process requirements, general linux foo or new Chrome security limitations.
If known, describe the steps to reproduce the issue:
Following https://github.com/dnschneid/crouton/wiki/How-To-Install-To-External-Drive
When I run $> sudo crouton -t xfce, xiwi -e -p '/media/removable/SD Card':
Downloading latest crouton installer...
curl: symbol lookup error: curl: undefined symbol: curl_multi_poll
Failed to download crouton installer.
Check your internet connection or proxy settings (-P) and try again.

Also found https://github.com/dnschneid/crouton/wiki/[FIX]-Help!-I-can-no-longer-install-or-boot-crouton-from-USB-or-MicroSD! and tried that but continue to receive the above message.
What I do notice is that when I run without sudo the process behaves differently. I guess it is normal for root to have it's own curl, but I make note of it here: $> which curl
/usr/local/bin/curl

vs $> sudo which curl
/usr/bin/curl

chrome os does not have apt-get so I do not know how to auto update packages. Like I said, it behaves differently:
$> crouton -t xfce, xiwi -e -p /media/removable/SD\ Card/
Downloading latest crouton installer...
############################################################################################################################################################### 100.0%############################################################################################################################################################### 100.0%
mount: only root can use "--bind" option
Unable to change permissions of the cache directory.
sh: 0: Refusing to exec /tmp/crouton-installer-cache/crouton from noexec mount; see https://chromium.googlesource.com/chromiumos/docs/+/master/security/noexec_shell_scripts.md

Finally also tried the no-disk-touch $> curl -fL https://goo.gl/fd3zc | sudo sh -s -- options_for_crouton_installer which resulted in the same output as when attempting to install with sudo
I know that this is a work of love and I am in no hurry to solve this. My $120 chromebook allows me to ssh to my server which is the reason I bought it originally. But I want to go back to being able to have local dev environment. So thank you all for your effort!

I ended up having to do a full chrome reset. After this I was able to install correctly.


optional ingress parameter for sonarqube-lts chart - ingressClassName

Why:
While the Sonarqube chart allows one to set ingressClassName the same does not apply to the Sonarqube-LTS chart. Internally, we use the LTS version and would need to set this parameter.
How:
Simply added this mentioned extra parameter to the Sonarqube-LTS chart dollowing the way it's done one the default Sonarqube chart.
Please ensure your pull request adheres to the following guidelines:

[x] explain your motives to contribute this change: what problem you are trying to fix, what improvement you are trying to make
[x] Document your Changes in the CHANGELOG.md file of the respected chart as well as the Chart.yaml
[x] Bump the Version number of the respected chart

Hello @kbcasagrande thanks a lot for taking the time to participate in the community.
As per our policy, the LTS chart is frozen and does not receive any updates, its here for pure stability.
I will close your PR based on that, nonetheless we are releasing the new SonarQube 9.9 LTS very soon.
With it will come a new helm chart LTS that will bundle your needs.
Stay tuned for the upgrade guidelines !


websocket access forbidden when behind nginx

the websocket cannot be established on any of our instances.

Probably related to the recent spring upgrade

Unclear: how did we not catch this on integration-test?

Seems that the PR was only tested locally, i.e., not behind nginx

Still an issue in Chrome

Chrome and firefox both get a 403 response when trying to open a websocket. Both try XHR streaming, then XHR as a fallback, Chrome fails in all of that (gets a 403), in Firefox, XHR finally works

Different behaviour on integration-test installation: chrome manages to fall back to XHR


Add debounce for playground code updates in order to reduce lag

Added a debounce to the playground code updates in order to reduce the lag effect when updating larger components with a lot of text typing at once.

@samuelclements Thanks for fixing this!
I noticed that this change introduced a little bug where an error is rendered on page load and then disappears. Could you look into that?
Meantime, I'm trying to figure out why Percy is not running on this PR.

Closing this and reopening as a new PR based off a branch rather than a fork to get percy tests running.


Refactor @go.printf, @go.print_stack_trace

Couple of very minor touch-ups done while developing @go.split and @go.join per #62 and #81.

Coverage increased (+0.003%) to 94.244% when pulling df1f646d42a76b2b0ab1b37f628143febe807949 on core-refactor into 5cd0211a0e71db331b38c811fd009dbf4b4cddc0 on master.


Add basic tester Github workflow

Relates to https://github.com/squirrelchat/smol-toml/issues/7
As I investigated the test failure of my package with Windows, I wanted to confirm I didn't inherit the failure from this dependency (spoiler: this package tests just fine under Windows). Since this workflow was largely just a matter of copying and pasting and it's definitely better than nothing, why not share it? :)
Currently, it installs the (dev) dependencies of the package and runs the tests on all configurations of 3 OSes (latest Windows, latest MacOS, latest Ubuntu) and the 3 latest stable Node versions (v16 is the latest that works with this package and/or the dev dependencies). The tests pass on all these configurations.

Hey there, thanks for the PR and sorry for the delay.
I'm not sure testing on all 3 platforms is relevant for the case of smol-toml. It involves no platform-specific code and is pretty much agnostic to the operating system you're on, so I'm unsure if Windows and MacOS jobs are relevant.
As for the Node version matrix, Node 16 never was supported by this library explicitly (see the package.json versions field), so it shouldn't be a version the lib tests against. It even reached EOL a while ago, so nobody should be using it anymore and migrate to supported versions of Node.
The tests wrote also are not quite complete; they're a good starting point but it'd need to be tested with toml-test for a more thorough testing. Good starting point nonetheless!

I'm not sure testing on all 3 platforms is relevant for the case of smol-toml. It involves no platform-specific code and is pretty much agnostic to the operating system you're on, so I'm unsure if Windows and MacOS jobs are relevant.

I think this reasoning is a bit akin to something like "I have already tested this library so why run them again". If it's naturally supposed to work on other platforms, to me that's one less excuse for not testing on all of them or writing tests that are less multiplatform than the running software itself.

As for the Node version matrix, Node 16 never was supported by this library explicitly (see the package.json versions field), so it shouldn't be a version the lib tests against. It even reached EOL a while ago, so nobody should be using it anymore and migrate to supported versions of Node.

I should have checked this, maybe I didn't notice but anyway, if it shouldn't install on Node v16 and it does, I would say that's legitimate feedback either way. Either something went wrong in the workflow or it does install with v16 disregarding the metadata


unstable channel hasn't updated for 14+ days

https://github.com/nixos/nixpkgs-channels has been stuck at 7ae05edcdd14f6ace83ead9bf0d114e97c89a83a for two weeks. According to https://hydra.nixos.org/job/nixos/trunk-combined/tested#tabs-constituents, kde4 tests fail, but there might be other reasons why the channel is blocked.

Yes, there's a build error in kgamma:

Unknown CMake command "check_include_files".

Maybe some cmake update on staging or something...

Sounds like exactly the same problem that @aszlig fixed in conky: 880eba6481d112b934325f1e60033ffd3c6c3f53

Yes, that sounds exactly like that problem. However I have no idea how to fix it properly.
@ttuegel You do most of the kde stuff, do you have a idea?

For kgamma, check for a patch upstream. CMake doesn't keep backwards compatibility between versions, so you can't just upgrade it globally. You will need an upstream patch for kgamma to fix it properly. If there is no upstream patch, I guess your options are to use an older CMake for kgamma or drop kgamma as unmaintained upstream.

Fixed a channel blocker in 48409bd3. No other failures are visible ATM http://hydra.nixos.org/build/28002207#tabs-constituents

So, kde4 test succeed for me now on x86_64-linux. I decided to switch to cmake-2.8 for all kde4 components, as that seemed easiest with kde4 stuff not really maintained upstream anymore.

@lethalman: what is your estimate about status of gnome-3.18 in nixpkgs? When switch the default?
Now I see that gnome-maps-3.16 also has problems with newer glib and there are no more 3.16 releases of that one. Maybe 3.16 will become nontrivial to keep alive.

gnome3.gnome-maps has been removed by @lethalman , but main hydra machine still fails to run tests because of:
mv: error writing '/nix/store/sdsnyczpgyrf801z33g043igch461gk3-xsession': No space left on device
<3>note: build failure may have been caused by lack of free disk space
<3>builder for ‘/nix/store/n24r2qi5h74c1j8h2cilx23zaz1phbpp-xsession.drv’ failed with exit code 1

cc @rbvermaa @edolstra

Currently hydra doesn't pickup nixos tests, so they're in queue for a few days.

It appears that https://hydra.nixos.org/build/28408697 succeeded. Now all we need is a channel update!

here it is \o/


add more things

Add the singular portal guns for only orange and only blue portals, add the portal emitters (the things that make portals with power), add the portal gun stands for the single portal guns, add the cameras, and add the floor buttons

also adding the wall and floor power would be cool

The mod is still a work in progress, so many things are missing or will be added in the future.  Single-portal guns, floor buttons, and Autoportals have been added in dev versions.


Update docs design to improve readability

Platforms affected
Docs
What does this PR do?
Recently, while using the docs, I've found them difficult to navigate and to read. I've made some minor changes to the design in an attempt to make them more readable and easy to use.
I have made the table of contents less wide on larger screens. Additionally I have reduced its padding and changed the styling of the headers to make separation a bit more obvious.
In the main content area, I have increased the line height and header margins to make things a bit easier to read. I have also set a max width on the content to make the text flow better on larger screens.
I've based the changes on docs for popular frameworks such as the Vue docs and React docs, as well as the Onsen UI docs, which I updated recently.
Below are before and after screenshots taken in Chrome set at 1920x1080 resolution. At this resolution, you can see that the text in the content runs on quite long, making it hard to follow.
Before:

After:

And at a lower resolution, 1280x720. In this example, you can see the padding in the table of contents is taking up more space than it should be.
Before:

After:

What testing has been done on this change?
Tested on Chrome, Firefox and Safari on macOS, and Edge on Windows.
Checklist

[ ] Commit message follows the format: "GH-3232: (android) Fix bug with resolving file paths", where GH-xxxx is the GitHub issue ID & "android" is the platform affected.
[ ] Added automated test coverage as appropriate for this change.

Looks great!

I like what you did there! :+1:
But as you'd probably expect from me by now, I still have a few suggestions :wink:
If we're doing this, I would like to further increase the body type size and further reduce the line length. Butterick recommends 45-90 characters per line. Thus middle ground would be around 68 letters. So the first line could be these 70 characters:

This guide shows how to set up your SDK environment to deploy Cordova

I got to the above line length with 18px font size in a 800px container. 800px gets a bit slim for the code samples though, even with the smaller font size that is used there. We should really target 80-120 characters here too, but that's not so easy to change now :smirk:
So from playing around I think 18px body type in a 960px container look reasonable for the main text and the code samples. And it's barely in the recommended range with about 90 characters per line.
Any opinions on this?

I actually originally wanted to do that, but decided to see what the feedback to the other changes would be first. In fact, I looked up articles about line length just like you linked. I think the case is a bit different for technical documentation, compared to an article. I'm not too worried about aiming for the lower end of recommended characters per line.
Increasing the font size is a good way of doing this, rather than making the content container smaller. I've updated the PR (and the screenshots) to set the font size to 18px (16px on mobile). I have also increased the size of the paragraph margin to look better with this increased font size.

@raphinesse @janpio Is there anything to prevent this from being merged? I'm eager to get this merged so the docs are a bit easier to use, since I still refer to them frequently enough :)

Nah, looks great as I wrote - I just don't want to be the one merging as it implies a bit of "being responsible" for it and I don't have the time for that right now, sorry.

Ah, that's a shame. Maybe @dpogue or @shazron could help get this merged?


Auto corrected by following Lint Ruby Layout/LeadingCommentSpace

Auto corrected by following Lint Ruby Layout/LeadingCommentSpace
Click here to configure it on awesomecode.io

Coverage remained the same at 96.801% when pulling 3e29be2fc841e55a7b507c1afd5420239ee27fde on awesomecode-lint-ruby-layout-leadingcommentspace-48016 into 22ecfa4bd363433d74aa04fa34c03f124f91425e on master.

Coverage remained the same at 96.801% when pulling 3e29be2fc841e55a7b507c1afd5420239ee27fde on awesomecode-lint-ruby-layout-leadingcommentspace-48016 into 22ecfa4bd363433d74aa04fa34c03f124f91425e on master.


Update org-roam hyperlinks in org/README.org

I noticed that the links in modules/lang/org/README.org were still pointing to the original jethrokuan/org-roam repo so I've updated them to org-roam/org-roam as org-roam now has it's own cough org in Github. That's a lot of orgs.

Thanks!


Oxfordshire - Upload function not working

When we choose the non-verify route we cannot upload a document - it allows us to choose a document but does not upload or proceed to the next screen. I am not sure if this is an issue we should be resolving or not?

Hey Abigail, which browser are you using? Thanks

Hi @sanjaypoyzer  I tried Chrome, Safari, IE11 browsers and it still doesn't work. Here is the link -  https://oxford-parkingpermit.herokuapp.com/service-patterns/parking-permit/example-service/start-non-verify

@sanjaypoyzer Has there been any update on this issue? Thanks, Abi


Add badge for coronavirus-related cases

This adds a badge on cases that are coronavirus (COVID-19) related, on both list views and on the case page itself.
See https://trello.com/c/RmjgZzsC/478-1-highlight-covid-19-cases
Colour is still slightly up for grabs 😄
Screenshots
List view

Case page view

Implementation notes
I've resisted refactoring this too much, except for moving the text of the badges into the locale file to avoid duplication, and converting a Slim partial to ERb.
Checklist:

[x] Have you documented your changes in the pull request description?
[ ] Has acceptance criteria been tested by a peer?

General testing (author)

[x] Test on small screen

I've pushed some changes to:

Move the coronavirus colour to a _colours.scss file.
Invert the colours for this special case.

Don't merge this until the cases on production which should be updated to true have been updated.

Should get a dev to review as I've also worked on this.


[BUG] Publisher: API Diagnostic are not getting overridden based on configuration..yaml

Release version
APIOps Toolkit for Azure APIM v6.0.1
Describe the bug
In the publisher, we can override environment specific values using configuration.<environment>.yaml file.
Supported Scenarios specifies, API Diagnostic (Provides operations for managing Diagnostic settings for the logger in an API) is supported.
And in the sample configuration.prod.yaml, we have this:
apis:
  - name: demo-conference-api
    diagnostics:
      - name: applicationinsights
        properties:
          verbosity: Error
          loggerId: "/subscriptions/[subscription Guid goes here]/resourceGroups/rg-apim-lab-prod/providers/Microsoft.ApiManagement/service/apim-prod-wk-05102022/loggers/[application insights name you chose for the destination environment]"

However it doesn't seem to be working.
In Azure Portal when we enable Diagnostic Logs for an API, it does the following.
curl 'https://management.azure.com/batch?api-version=2016-07-01' \
  --data-raw $'{
    "requests": [
        {
            "httpMethod": "PUT",
            "relativeUrl": "/subscriptions/<subscriptionId>/resourceGroups/<resourceGroupName>/providers/Microsoft.ApiManagement/service/<apimName>/apis/<apiName>/diagnostics/<diagnosticName>?api-version=2022-09-01-preview",
            "content": {
                "id": "",
                "name": "<diagnosticName>",
                "properties": {
                    "loggerId": "/subscriptions/<subscriptionId>/resourceGroups/<resourceGroupName>/providers/Microsoft.ApiManagement/service/<apimName>/loggers/<loggerName>",
                    "verbosity": "information",
                    // Omitted for brevity
                }
            }
        }
    ]
  }'

I inspected the HTTP calls the publisher is making, and I am not seeing any HTTP call to .../apis/<apiName>/diagnostics/*.
Api Diagnostic - Create Or Update
Expected behavior
The publisher should honor and override API diagnostics as specified in the following format.
apis:
  - name: demo-conference-api
    diagnostics:
      - name: applicationinsights
        properties:
          verbosity: Error
          loggerId: "/subscriptions/[subscription Guid goes here]/resourceGroups/rg-apim-lab-prod/providers/Microsoft.ApiManagement/service/apim-prod-wk-05102022/loggers/[application insights name you chose for the destination environment]"

Actual behavior
The publisher doesn't override API diagnostics.
Reproduction Steps

From the source APIM, create a test HTTP API, and enable Diagnostics Logs
Create a configuration.<environment>.yaml for the target APIM. Update apis.diagnostics with environment specific values
Run publisher and ensure in the target APIM, Diagnostics Log are enabled as per the configuration.<environment>.yaml

Seems ApiDiagnostic.cs was dropped in version >6.0.0?

This seems related: #616

Closing in favor of #616. We're adding support back in, accidentally removed it v6.

@guythetechie
Thanks for confirmation!

@guythetechie
Can confirm diagnostics are getting published with v<IP_ADDRESS>

The version v<IP_ADDRESS> supports extraction for api level diagnostics but not replacing loggerId form the configuration..yaml file.

@guythetechie
Can confirm diagnostics are getting published with v<IP_ADDRESS>

Are you able to replace loggerId for the uat and prod (target APIM) from publisher configuration..yaml ?? In my case, it is creating the loggerId with the same name as dev.
Starting request
2024-09-02T11:25:48.7661199Z       Method: PUT
2024-09-02T11:25:48.7662007Z       Uri: https://management.azure.com/subscriptions//resourceGroups//providers/Microsoft.ApiManagement/service//apis//diagnostics/applicationinsights?api-version=2023-09-01-preview
2024-09-02T11:25:48.7663677Z       Content: {"properties":{"loggerId":"/subscriptions//resourceGroups/<dev RG - it should be target rg>/providers/Microsoft.ApiManagement/service//loggers/","alwaysLog":"allErrors","backend":{"request":{"body":{"bytes":0},"headers":[]},"response":{"body":{"bytes":0},"headers":[]}},"frontend":{"request":{"body":{"bytes":0},"headers":[]},"response":{"body":{"bytes":0},"headers":[]}},"httpCorrelationProtocol":"Legacy","logClientIp":true,"metrics":true,"sampling":{"percentage":100,"samplingType":"fixed"},"verbosity":"verbose"}}

The version v<IP_ADDRESS> supports extraction for api level diagnostics but not replacing loggerId from the configuration..yaml file.
Here is the APIOPS logs for API level diagnostic. Starting request 2024-09-02T11:25:48.7661199Z Method: PUT 2024-09-02T11:25:48.7662007Z Uri: https://management.azure.com/subscriptions//resourceGroups//providers/Microsoft.ApiManagement/service//apis//diagnostics/applicationinsights?api-version=2023-09-01-preview 2024-09-02T11:25:48.7663677Z Content: {"properties":{"loggerId":"/subscriptions//resourceGroups/<dev RG - it should be target rg>/providers/Microsoft.ApiManagement/service//loggers/","alwaysLog":"allErrors","backend":{"request":{"body":{"bytes":0},"headers":[]},"response":{"body":{"bytes":0},"headers":[]}},"frontend":{"request":{"body":{"bytes":0},"headers":[]},"response":{"body":{"bytes":0},"headers":[]}},"httpCorrelationProtocol":"Legacy","logClientIp":true,"metrics":true,"sampling":{"percentage":100,"samplingType":"fixed"},"verbosity":"verbose"}}

I'm having the exact same experience in my environment.

We only support overriding top-level resources in the publisher. You can override service-level diagnostics (which are top-level), but you can't override API diagnostics. In other words, this works:
- diagnostics:
    properties:
      loggerId: abcd

But there is no support for something like this:
- apis
     apiA:
       diagnostics:
         properties:
           loggerId: abcd

We will look into adding support for the above configuration, as we'll need a solution to support overrides in workspaces. In the meantime, you have to update properties.loggerId in apis/apiA/diagnostics/diagnosticA/diagnosticInformation.json with the correct logger.
Also, I don't think the full resource ID of the logger is required in properties.loggerId. You should be able to update it with just /loggers/your-logger-name. This will make sure it works across all APIM instances. It will look for your-logger-name in the current APIM instance instead of the instance specified in /subscriptions/your-subscription/resourceGroups.../original-apim-instance.

Further @guythetechie s' answer,
Example override yaml,
apimServiceName: <apimServiceName>
namedValues:
  - name: application-insights-instrumentation-key
    properties:
      displayName: application-insights-instrumentation-key
      value: "<application-insights-instrumentation-key>"

loggers:
    - name: appinsights
      properties:
        loggerType: applicationInsights
        description: <description>
        resourceId: "/subscriptions/<subscription>/resourceGroups/<resourceGroup>/providers/microsoft.insights/components/<applicationInsightsInstance>"
        credentials:
          instrumentationKey: "{{application-insights-instrumentation-key}}"
        isBuffered: true

diagnostics:
   - name: applicationinsights
     properties:
       verbosity: Error
       loggerId: "/subscriptions/<subscription>/resourceGroups/<resourceGroup>/providers/Microsoft.ApiManagement/service/<apimServiceName>/loggers/appinsights"

apis:
  - name: <apiName>
    properties:
      serviceUrl: "<serviceUrl>"
    diagnostics:
      - name: applicationinsights
        properties:
          verbosity: information
          loggerId: "/subscriptions/<subscription>/resourceGroups/<resourceGroup>/providers/Microsoft.ApiManagement/service/<apimServiceName>/loggers/appinsights"

Has this issue been fixed now as i am getting exactly the same error while using v<IP_ADDRESS>. Kindly provide the fix if it's working for anyone and configuration.env.yaml file if there is any change in it to make it work.

@guythetechie, I'm looking forward to an alternative solution in v6.
This requested behaviour of transforming a nested loggerId worked just find in v5.

We are also seeing this issue, it doesn't override
This snippet doesn't work anymore
apis:
  - name: <apiName>
    properties:
      serviceUrl: "<serviceUrl>"
    diagnostics:
      - name: applicationinsights
        properties:
          verbosity: information
          loggerId: "/subscriptions/<subscription>/resourceGroups/<resourceGroup>/providers/Microsoft.ApiManagement/service/<apimServiceName>/loggers/appinsights"

@vinilka8,
Just to clarify, loggerId should follow the following template.
loggerId: "/subscriptions/<subscription>/resourceGroups/<resourceGroup>/providers/Microsoft.ApiManagement/service/<apimServiceName>/loggers/<loggerId>"

/subscriptions/f5760094-......7ae94787f/resourceGroups/rg-apim-tst-cc-01/providers/Microsoft.ApiManagement/service/apim-aviso-tst-cc-01/loggers/appi-apim-tst-cc-01
this what we use, and it's not working

we using this approach for a year, since version 4, we just migrated today from 4 to <IP_ADDRESS>, but it start screaming with an error stating that it can't override, and failed the publisher

Please publish the logs here. Make sure you scrape the logs before you publish though.

I see that there is new version released v <IP_ADDRESS>in release log there is an info that that bug was fixed, however I still see same error diagnostics information for API's are not overwritten from config yaml file.
Example:

name: product-cognitive-search-apis
properties:
path: "indexes"
diagnostics:

name: applicationinsights
properties:
loggerId: "/subscriptions/<subscription_ID}/resourceGroups/test-product-api-00001- rg/providers/Microsoft.ApiManagement/service/test-product-api-01-apim/loggers/dap-api-01-appi"
verbosity: "information"

I'm using release version for linux in devops pipeline.

I am getting same issue for loggerID , not able to replace using configuration.dev.yaml


UI - settings in non functional and contain unnecessary step

When clicking on settings i get a drop down list (problem #1) instead of going to settings directly + when clicking it i get 404 message which then the url get messed up trying to go back.

solved by https://github.com/konflux-ci/konflux-ci/pull/815


Not possible to configure permalinks for the root section in TOML

TOML does not allow empty keys (not sure about JSON, YAML).
We have a test for it, but that uses a Go map.
Suggest we allow an empty string ( ) to represent the root (i.e. trim it).

May be use "/"  key for root?


python311Packages.devolo-plc-api: 1.4.0 -> 1.4.1

Diff: https://github.com/2Fake/devolo_plc_api/compare/refs/tags/v1.4.0...v1.4.1
Changelog: https://github.com/2Fake/devolo_plc_api/releases/tag/v1.4.1
Description of changes

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 255606 run on x86_64-linux 1

5 packages built:

home-assistant-component-tests.devolo_home_network
python310Packages.devolo-plc-api
python310Packages.devolo-plc-api.dist
python311Packages.devolo-plc-api
python311Packages.devolo-plc-api.dist


Cannot seem to get timeline to function

Hello,
I'm trying to get a timeline added to my mkdocs-material site, but can't seem to quite understand how this package installs/works.

I've run pip3 install neoteroi-mkdocs and that installed correctly.
I added the following to my mkdocs.yml that's at the root of my site

markdown_extensions:
  - neoteroi.timeline

and
extra_css:
  - css/neoteroi-mkdocs.css

However, I consistently get WARNING  -  [12:39:06] "GET /docs/css/neoteroi-mkdocs.css HTTP/1.1" code 404 in my console output.
Questions:

I did notice in the introduction page of the documentation site you indicated that we had to download the CSS? Is that required or serve up timeline? or is it downloaded with the pip install?
Can I copy the CSS output instead of downloading a file?
Do you have an example site of serving up the timeline? Couldn't find your mkdocs example site in this repo.

Hi @sseekamp0
Yes, it's necessary to download the CSS file and include it in your site folder. Distributing it with pip wouldn't work because it would get placed into your Python virtual environment, or Python global installation folder (depending on whether you use virtual environments or not). The MkDocs development server does not serve files in your dependencies folder.

Couldn't find your mkdocs example site in this repo.

The documentation site is linked in the README of this repo, there are 8 links at the very top:

I have the same problem.
Is the css file described in the documentation the file I marked up?

Hi @scydas
Yes, as described here https://www.neoteroi.dev/mkdocs-plugins/intro/#how-to-obtain-css-files
You can download the CSS from the assets of the last successful release, or from the published artifacts of the last successful GitHub Workflows run in GitHub.
From the release:

From the last action:

In the first case, rename the CSS file as desired. In the second case, the file has already name "neoteroi-mkdocs.css", in only need to be unzipped.

@RobertoPrevato
Thank you very much for your reply, I have a question.
oad only supports swagger V3? not V2

@RobertoPrevato Thank you very much for your reply, I have a question. oad only supports swagger V3? not V2

You're welcome 😄. Yes, my libraries to handle OpenAPI Specification only support V3. Because I wouldn't have the time to support also version 2. However, I generally structure my code to support adding support for V2 eventually in the future (or V4, when it will exist).


[HUDI-709]Add unit test for UtilsCommand

Tips

Thank you very much for contributing to Apache Hudi.
Please review https://hudi.apache.org/contributing.html before opening a pull request.

What is the purpose of the pull request
Add unit test for UtilsCommand
Brief change log
(for example:)

Add unit test for UtilsCommand

Verify this pull request
This pull request is a trivial rework / code cleanup without any test coverage.
Committer checklist

[x] Has a corresponding JIRA in PR title & commit

[ ] Commit message is descriptive of the change

[ ] CI is green

[ ] Necessary doc changes done or have another open PR

[ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.

Please note that in #1689 some package path were changed. Either PR merged later would need to make sure import statements work. Thanks.

@xushiyan : Yes, thanks for your information.

Codecov Report

Merging #1686 into master will increase coverage by 0.01%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #1686      +/-   ##
============================================
+ Coverage     18.19%   18.20%   +0.01%
- Complexity      856      857       +1
============================================
  Files           348      348
  Lines         15344    15344
  Branches       1523     1523
============================================
+ Hits           2792     2794       +2
+ Misses        12195    12193       -2
  Partials        357      357

Impacted Files
Coverage Δ
Complexity Δ

...apache/hudi/common/fs/HoodieWrapperFileSystem.java
22.69% <0.00%> (+0.70%)
29.00% <0.00%> (+1.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7fb1251...6e66206. Read the comment docs.

Will review this one after merging PR #1689

@yanghua : Had address them, please review again when free.


chore: remove phpunit unnecessary values

Changes come from https://github.com/supportpal/api-client-php/pull/102#discussion_r549652673

:tada: This PR is included in version 1.2.1 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Show a zero in cells that have zero value

Hi there. I need to hide the zeroes, which is a worksheet property accessible via Options in Excel
Can I do this with exceljs?

i also has this problem
when i unchecked this option
then export excel by exceljs
this option is auto checked


Swagger generate fix

The Copyright Check has failed!
The files listed below do not have a valid copyright statement:

auth_operations/authOperation.go - auth_operations/auth_operations_test.go - client/about.go - client/about_api.go - client/api_client.go - client/api_response.go - client/auth_api.go - client/configuration.go


Fields for unset preference values should revert to their initial value

Example:
@OnPreferenceChange("some_pref_key")
int myFieldName = 100;

When the value associated with "some_pref_key" is removed from the preference file, the value of the field should be reset back to 100 (if no default is specified).

Deferred in favour of the @PreferenceDefault annotation system.


Build error with latest bevy

Hi-
I'm trying to consume bevy directly from git, due to the fact the latest release 0.5.0 is 6 months old and is missing a few fixes I need (see bevyengine/bevy#2940). However I'm facing many build errors:
error[E0432]: unresolved import `bevy::prelude::AppBuilder`
error[E0432]: unresolved imports `bevy::core::AsBytes`, `bevy::render::pass::RenderPassDepthStencilAttachmentDescriptor`
error[E0261]: use of undeclared lifetime name `'w`
error[E0261]: use of undeclared lifetime name `'s`
error[E0107]: this struct takes 2 lifetime arguments but 1 lifetime argument was supplied

So I have a few questions:

Is bevy_kira_audio only supposed to work with bevy on released version?
Would it be possible to add some CI to catch those build issues along the way?

Thanks!

Are you using the bevy_main branch? The main branch is only compatible with the latest release.
I try to keep the commit that bevy_main depends on up to date, but it's very likely outdated again.

I'll close this since the original issue seems to be resolved.


Enabling HTTP2 crashes at runtime on client

Working on some benchmarks for a new server.
Unable to use the http2 client.
Finished `bench` profile [optimized + debuginfo] target(s) in 54.62s
     Running benches/hello_world_tower_hyper_tls_tcp.rs (target/release/deps/hello_world_tower_hyper_tls_tcp-a580cce80814937a)
Benchmarking hyper_server/serial_latency
Benchmarking hyper_server/serial_latency: Warming up for 5.0000 s
thread 'tokio-runtime-worker' panicked at /Users/user/.cargo/registry/src/index.crates.io-6f17d22bba15001f/hyper-1.4.1/src/common/time.rs:37:17:
You must supply a timer.
stack backtrace:

at runtime, when I enable:
        let https = HttpsConnectorBuilder::new()
            .with_tls_config(tls_config.client_config)
            .https_or_http()
            .enable_all_versions()
            .build();

        let client: Client<_, Empty<Bytes>> = Client::builder(TokioExecutor::new())
            .timer(TokioTimer::new())
            .pool_timer(TokioTimer::new())
            .build(https);

http1 works just fine.
Whole file:
https://github.com/warlock-labs/hyper-server/blob/ff7b4397fa1a0488dd5534fc46c27d21248bd5d7/benches/hello_world_tower_hyper_tls_tcp.rs
Relates to:
https://github.com/rustls/hyper-rustls/issues/287
Found on:
https://github.com/warlock-labs/hyper-server/pull/17

    // Configure the builder
    let mut builder = builder.clone();
    builder
        // HTTP/1 settings
        .http1()
        // Enable half-close for better connection handling
        .half_close(true)
        // Enable keep-alive to reduce overhead for multiple requests
        .keep_alive(true)
        // Increase max buffer size to 256KB for better performance with larger payloads
        .max_buf_size(256 * 1024)
        // Enable immediate flushing of pipelined responses
        .pipeline_flush(true)
        // Preserve original header case for compatibility
        .preserve_header_case(true)
        // Disable automatic title casing of headers to reduce processing overhead
        .title_case_headers(false)
        // HTTP/2 settings
        .http2()
        // Add the timer to the builder
        // This will cause you all sorts of pain otherwise
        // https://github.com/seanmonstar/reqwest/issues/2421
        // https://github.com/rustls/hyper-rustls/issues/287
        .timer(TokioTimer::new())
        // Increase initial stream window size to 2MB for better throughput
        .initial_stream_window_size(Some(2 * 1024 * 1024))
        // Increase initial connection window size to 4MB for improved performance
        .initial_connection_window_size(Some(4 * 1024 * 1024))
        // Enable adaptive window for dynamic flow control
        .adaptive_window(true)
        // Increase max frame size to 32KB for larger data chunks
        .max_frame_size(Some(32 * 1024))
        // Allow up to 2000 concurrent streams for better parallelism
        .max_concurrent_streams(Some(2000))
        // Increase max send buffer size to 2MB for improved write performance
        .max_send_buf_size(2 * 1024 * 1024)
        // Enable CONNECT protocol support for proxying and tunneling
        .enable_connect_protocol()
        // Increase max header list size to 32KB to handle larger headers
        .max_header_list_size(32 * 1024)
        // Set keep-alive interval to 10 seconds for more responsive connection management
        .keep_alive_interval(Some(Duration::from_secs(10)))
        // Set keep-alive timeout to 30 seconds to balance connection reuse and resource conservation
        .keep_alive_timeout(Duration::from_secs(30));

This ended up being a hyper::server::conn::auto::Builder ergonomics issue.


Floating mode

Hi 👋🏾
I was wondering if we could have floating mode, similar to what Helium does.
This is probably only OS X related, but I;d like to summon hyper from anywhere, even from fullscreen apps, without jumping to any other spaces, I just'd like to have hyper showing in the exact space I'm in.
Helium has also support to floating over spaces.
I know this is based on electron, so I'm not sure if it can be implemented directly.

Hi there!
This can definitely be implemented as a plugin. One exists here: https://www.npmjs.com/package/hyperterm-overlay

@CodeTheory thanks! Unfortunately this doesn't work as expected, when I'm using a fullscreen app I get to another space when opening hyper via the shortcut. I'll have a look at the code and see if we can fix this :)

Any update on this?

@ChadTaljaardt hey! not really I tried to hack a bit with Electron but I haven't managed to create a proper floating window, I'm sure I'm doing something wrong with the OSX flags, but I didn't have too much time to test.

I can see if i can figure anything out after i reinstall my laptop :)

Don't know if will help, but I was doing some tests here: https://github.com/electron/electron/blob/master/atom/browser/native_window_mac.mm#L680
but I haven't managed to get the right flags/settings :)

Just curious whether anyone figured this out?