Makefile refactor

cleanup makefile
update buildtest workflow
ran go mod tidy, update go.mod

similar to what was done : https://github.com/k8snetworkplumbingwg/sriov-network-device-plugin/pull/579

Pull Request Test Coverage Report for Build<PHONE_NUMBER>5
Details

0 of 0   changed or added relevant lines in 0 files are covered.
12 unchanged lines in 1 file lost coverage.
Overall coverage decreased (-10.2%) to 41.345%

Files with Coverage Reduction
New Missed Lines
%

pkg/utils/utils.go
12
44.23%

Totals

Change from base Build<PHONE_NUMBER>6:
-10.2%

Covered Lines:
535

Relevant Lines:
1294

💛  - Coveralls

LGTM
I think this should solve also:

sriov-cni build is not idempotent #263

yeap, running make build twice will not fail :)
been looking at failed CI e2e, it dont seem to be related.

@zeeke can we merge this one?

.PHONY: all
all: fmt lint build test

The all target now also includes test. That seems desirable to me.
In particular, because all is also the default target.
On my machine, make test fails due to lack of permissions. Maybe I am doing it wrong, and I should develop in a new rootless netns, where I have permissions or run make as root(??). But I'd rather not do that (are you?)
Compare to autotools projects, where make does not include make check.
I think either:

just don't include test in all target, as before.
add new target (check-and-build) that contains fmt lint build (but not test) and which is the new default target. Like

.PHONY: check-and-build
check-and-build: fmt lint build

.PHONY: all
all: check-and-build test

agree! here with @thom311
@thom311 can you please open a PR for that?


feat(config): change the default of useDisplayNameInClassName

What:

Added a test to useDisplayNameInClassName

Updated the FAQs with default

Updated the README.md file docs for useDisplayNameInClassName to say "Defaults to process.env.NODE_ENV !== 'test'"

Why: Not sure

How: Not sure

Checklist:

[x] Documentation
[x] Tests
[x] Ready to be merged
[x] Added myself to contributors table

I've changed this PR to merge into the next branch. Considering it's a breaking change, I want to queue up a few breaking changes to release them all at once (when a PR is merged into master it is automatically released). So this'll go into the next branch, then it'll get merged into master when we're ready to release this officially. Thanks again!

Sorry, I kinda messed things up. I'll fix it :)

I'm not sure why travis isn't kicking off another build here, but I'm going to go ahead and merge this.
Thanks again @oalbacha! Congratulations on your first ever pull request!


Unnecessary record is created to belongsToMany pivot table

references object to insertOrUpdate

https://codesandbox.io/s/l3n381925l
this's problem of first aid
delete id field from  pivot table and separately 'insertOrUpdate' will fix it
https://codesandbox.io/s/kkm1x71wjo

Thank you for the report and the PR!


Add E2E tests for create account

And check if peruse is requesting to auth after account creation.

Resolves #320


Blazor-SignalR configuration updates

Per https://github.com/dotnet/aspnetcore/pull/44623#issuecomment-1283093817
@BrennanConroy ... This wasn't caught on review. The text is right ... the code example is incorrect for the Blazor.start piece.
Reminder: This is for a hosted Blazor WebAssembly with SignalR app. The user needs to extend the server timeout. I was also covering the keep-alive bit, saying to set keep-alive equally on both sides if changed but not recommending a change for merely extending the server timeout, just showing how to change keep-alive for reference.
The SignalR guidance states for the KeepAliveInterval server setting ...

When changing KeepAliveInterval, change the ServerTimeout or serverTimeoutInMilliseconds setting on the client.

Cross-ref: https://learn.microsoft.com/en-us/aspnet/core/signalr/configuration?view=aspnetcore-6.0&tabs=javascript#configure-server-options
What are we doing about setting serverTimeoutInMilliseconds/keepAliveIntervalInMilliseconds client-side in Blazor.start? The following (in the doc right now) is wrong (Chris and Tanay informed me that builder = HubConnectionBuilder, not HubConnection) ...
<script>
  Blazor.start({
    configureSignalR: function (builder) {
      builder.serverTimeoutInMilliseconds = 30000;
      builder.keepAliveIntervalInMilliseconds = 15000;
    }
});
</script>

I considered the following from a PU issue ...
Blazor.start({
  configureSignalR: function (builder) {
    let c = builder.build();
    c.serverTimeoutInMilliseconds = 30000;
    c.keepAliveIntervalInMilliseconds = 15000;
    builder.build = () => {
      return c;
    };
  }
});

Cross-ref: https://github.com/dotnet/aspnetcore/issues/18840#issuecomment-1182694070
... but that's described as a workaround and looks hackish.
... and configuration of configureSignalR doesn't seem to be effective at all for the client of a hosted WASM solution.

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 0969556b-b77e-bdb8-8e20-fd6971be0c25
Version Independent ID: d17e4c28-ea82-0dd8-295d-19f6ada147ea
Content: ASP.NET Core Blazor SignalR guidance
Content Source: aspnetcore/blazor/fundamentals/signalr.md
Product: aspnet-core
Technology: aspnetcore-fundamentals
GitHub Login: @guardrex
Microsoft Alias: riande

btw @BrennanConroy ... Not directly related to this, but I'm having trouble getting control of client-side logging via app settings.
A minimum level can be set via ...
.ConfigureLogging(logging =>
{
    logging.AddProvider(LoggerProvider);
    logging.SetMinimumLevel(LogLevel.Trace);
})

... but that's perhaps not ideal to show because I fear devs will forget to turn it off. I'd prefer an appsettings.Development.json approach client-side for this, but I can't get it working. Is there a way to set the hub connection logging client-side via app settings?

I'd prefer an appsettings.Development.json approach client-side for this, but I can't get it working. Is there a way to set the hub connection logging client-side via app settings?

Sort of but not really, the whole "development" vs "production" concept is an end-to-end experience we built into VS and Web apps. Console apps (client code) doesn't get an "ASPNETCORE_ENVIRONMENT" variable set when you launch it via VS, and you would need to write some configuration loading to load a json file that you hand create.
The easiest and "best" way I can think of doing it is using #if DEBUG
#if DEBUG
    logging.AddProvider(LoggerProvider);
    logging.SetMinimumLevel(LogLevel.Trace);
#endif

What are we doing about setting serverTimeoutInMilliseconds/keepAliveIntervalInMilliseconds client-side in Blazor.start?

I don't know how Blazor exposes SignalR objects, suggest talking to blazor folks about if the HubConnection is accessible.

given that environmental settings are supported for Blazor WASM apps

I don't know anything about this 🤷

Normally for logging in WASM, we say to drop the file in the wwwroot folder and activate in Program.cs with ...
builder.Logging.AddConfiguration(builder.Configuration.GetSection("Logging"));

Cross-ref: https://learn.microsoft.com/en-us/aspnet/core/blazor/fundamentals/configuration?view=aspnetcore-6.0#logging-configuration
It also works tho without that Program.cs line if the app settings file is in the root of the app.
Anyway ... I was just hoping that the normal app settings for development might isolate trace connection logging to that environment. Compiler directives are ok. We do that in a half dozen or so spots for special circumstances.

🤔 ... Perhaps, we could read config for SetMinimumLevel ... mmmmmm ... that sounds good.

That can work for the SignalR client too if you have access to builder.Configuration when setting up logging for the client.

I'm working on the doc updates to cover this. The workaround code shown above doesn't work, but setting the props on the Hub connection in a component works for the client on both WASM and Server. The following approach for connection building is what what we show in the Blazor-SignalR tutorial. The following values are purely for demo purposes and aren't meant to make sense.
protected override async Task OnInitializedAsync()
{
    hubConnection = new HubConnectionBuilder()
        .WithUrl(Navigation.ToAbsoluteUri("/chathub"))
        .Build();

    hubConnection.ServerTimeout = TimeSpan.FromSeconds(61);
    hubConnection.HandshakeTimeout = TimeSpan.FromSeconds(31);
    hubConnection.KeepAliveInterval = TimeSpan.FromSeconds(17);

    Logger.LogInformation($"\n\n\nhubConnection.ServerTimeout: {hubConnection.ServerTimeout}" +
        $"\nhubConnection.HandshakeTimeout: {hubConnection.HandshakeTimeout}" +
        $"\nhubConnection.KeepAliveInterval: {hubConnection.KeepAliveInterval}\n\n");

    hubConnection.On<string, string>( ... );

    await hubConnection.StartAsync();
}

Output ...

hubConnection.ServerTimeout: 00:01:01
hubConnection.HandshakeTimeout: 00:00:31
hubConnection.KeepAliveInterval: 00:00:17

The code pitched on the PU issue by a community member for Blazor.start is ineffective for both hosting models AFAICT. I'll angle coverage this way for Blazor Server and hosted WASM for the server (not shown here, but it will be on the PR) and client (shown above). If there's any further discussion on the doc updates, feel free to add remarks to this issue.


feat: Nebula Graph integration

Description
Nebula Graph integration based on @Odysseusailoon @raywhoelse @ZackYule 's work in https://github.com/camel-ai/camel/pull/836
Motivation and Context
close #816

[x] I have raised an issue to propose this change (required for new features and bug fixes)

Types of changes
What types of changes does your code introduce? Put an x in all the boxes that apply:

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds core functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Documentation (update in the documentation)
[ ] Example (update in the folder of example)

Implemented Tasks

[ ] Subtask 1
[ ] Subtask 2
[ ] Subtask 3

Checklist
Go over all the following points, and put an x in all the boxes that apply.
If you are unsure about any of these, don't hesitate to ask. We are here to help!

[ ] I have read the CONTRIBUTION guide. (required)
[ ] My change requires a change to the documentation.
[ ] I have updated the tests accordingly. (required for a bug fix or a new feature)
[ ] I have updated the documentation accordingly.

merge as beta version, will add more functionality support https://github.com/camel-ai/camel/issues/971


master to live, see commits for details.

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

README.md
:white_check_mark:Succeeded

exchange/docs-conceptual/exchange-server/exchange-management-shell.md
:white_check_mark:Succeeded
View (exchange-ps)

exchange/exchange-ps/exchange/advanced-threat-protection/New-AntiPhishPolicy.md
:white_check_mark:Succeeded
View (exchange-ps)

exchange/exchange-ps/exchange/advanced-threat-protection/Set-AntiPhishPolicy.md
:white_check_mark:Succeeded
View (exchange-ps)

exchange/exchange-ps/exchange/antispam-antimalware/Get-IPAllowListProvidersConfig.md
:white_check_mark:Succeeded
View (exchange-ps)

exchange/exchange-ps/exchange/antispam-antimalware/Get-IPBlockListProvidersConfig.md
:white_check_mark:Succeeded
View (exchange-ps)

exchange/exchange-ps/exchange/antispam-antimalware/Get-MailboxJunkEmailConfiguration.md
:white_check_mark:Succeeded
View (exchange-ps)

exchange/exchange-ps/exchange/antispam-antimalware/Set-IPAllowListProvidersConfig.md
:white_check_mark:Succeeded
View (exchange-ps)

exchange/exchange-ps/exchange/antispam-antimalware/Set-MalwareFilterPolicy.md
:white_check_mark:Succeeded
View (exchange-ps)

exchange/exchange-ps/exchange/client-access/Set-ImapSettings.md
:white_check_mark:Succeeded
View (exchange-ps)

exchange/exchange-ps/exchange/client-access/Set-PopSettings.md
:white_check_mark:Succeeded
View (exchange-ps)

exchange/exchange-ps/exchange/database-availability-groups/Test-ReplicationHealth.md
:white_check_mark:Succeeded
View (exchange-ps)

exchange/exchange-ps/exchange/encryption-and-certificates/Set-IRMConfiguration.md
:white_check_mark:Succeeded
View (exchange-ps)

exchange/exchange-ps/exchange/encryption-and-certificates/Set-SmimeConfig.md
:white_check_mark:Succeeded
View (exchange-ps)

exchange/exchange-ps/exchange/mail-flow/Set-RemoteDomain.md
:white_check_mark:Succeeded
View (exchange-ps)

exchange/exchange-ps/exchange/mailboxes/Set-MailboxSentItemsConfiguration.md
:white_check_mark:Succeeded
View (exchange-ps)

exchange/exchange-ps/exchange/organization/Get-ExchangeSettings.md
:white_check_mark:Succeeded
View (exchange-ps)

exchange/exchange-ps/exchange/organization/Set-OrganizationConfig.md
:white_check_mark:Succeeded
View (exchange-ps)

exchange/exchange-ps/exchange/policy-and-compliance/Get-TransportRule.md
:white_check_mark:Succeeded
View (exchange-ps)

exchange/exchange-ps/exchange/sharing-and-collaboration/New-SiteMailboxProvisioningPolicy.md
:white_check_mark:Succeeded
View (exchange-ps)

exchange/exchange-ps/exchange/sharing-and-collaboration/Set-SiteMailboxProvisioningPolicy.md
:white_check_mark:Succeeded
View (exchange-ps)

repo_docs/FAQ.md
:white_check_mark:Succeeded

repo_docs/NEW_CMDLETS.md
:white_check_mark:Succeeded

repo_docs/UPDATE_CMDLETS.md
:white_check_mark:Succeeded

sharepoint/docs-conceptual/sharepoint-pnp/sharepoint-pnp-cmdlets.md
:white_check_mark:Succeeded
View (sharepoint-ps)

sharepoint/docs-conceptual/sharepoint-server/sharepoint-server-cmdlets.md
:white_check_mark:Succeeded
View (sharepoint-ps)

sharepoint/sharepoint-ps/sharepoint-online/Set-SPOSite.md
:white_check_mark:Succeeded
View (sharepoint-ps)

sharepoint/sharepoint-ps/sharepoint-pnp/Test-PnPOffice365GroupAliasIsUsed.md
:white_check_mark:Succeeded
View (sharepoint-ps)

sharepoint/sharepoint-ps/sharepoint-server/Get-SPAppStateUpdateInterval.md
:white_check_mark:Succeeded
View (sharepoint-ps)

sharepoint/sharepoint-ps/sharepoint-server/Set-SPInternalAppStateUpdateInterval.md
:white_check_mark:Succeeded
View (sharepoint-ps)

sharepoint/sharepoint-ps/sharepoint-server/Set-SPWebApplicationHttpThrottlingMonitor.md
:white_check_mark:Succeeded
View (sharepoint-ps)

sharepoint/sharepoint-ps/sharepoint-server/Stop-SPDistributedCacheServiceInstance.md
:white_check_mark:Succeeded
View (sharepoint-ps)

skype/skype-ps/skype/Get-CsTeamsInteropPolicy.md
:white_check_mark:Succeeded
View (skype-ps)

skype/skype-ps/skype/Get-CsTeamsUpgradePolicy.md
:white_check_mark:Succeeded
View (skype-ps)

skype/skype-ps/skype/Grant-CsTeamsInteropPolicy.md
:white_check_mark:Succeeded
View (skype-ps)

skype/skype-ps/skype/Grant-CsTeamsUpgradePolicy.md
:white_check_mark:Succeeded
View (skype-ps)

skype/skype-ps/skype/Test-CsIM.md
:white_check_mark:Succeeded
View (skype-ps)

tools/office-cmdlet-updater/config/default.json
:white_check_mark:Succeeded

tools/office-cmdlet-updater/constants/commands.js
:white_check_mark:Succeeded

tools/office-cmdlet-updater/db/index.js
:white_check_mark:Succeeded

tools/office-cmdlet-updater/services/log.parse.service.js
:white_check_mark:Succeeded

tools/office-cmdlet-updater/services/log.store.service.js
:white_check_mark:Succeeded

tools/office-cmdlet-updater/services/markdown.service.js
:white_check_mark:Succeeded

tools/office-cmdlet-updater/services/power.shell.service.js
:white_check_mark:Succeeded

whiteboard/whiteboard-ps/whiteboard/whiteboard.md
:white_check_mark:Succeeded
View (whiteboard-ps)

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Add support for downloads from GitHub

This PR adds a setting to allow Godots to download releases from Github whenever possible (stable releases newer than 3.1.1 and the version 2.1.6).  If the download fails, Godots will fallback to TuxFamily.
The setting can be enabled in the remote editors tab, by toggling the checkbox on the right that says «Use Github».
I had considered adding an OptionButton to each TreeItem for a release's zip, to allow the user to explicitly choose the mirror to use when downloading (as was done in https://gitlab.com/jwestman/hourglass/-/merge_requests/43), but that was not possible, since a TreeItem only allows for normal buttons to be added.

Cool!! Thanks!


Fix not found page shows when going back from WS list after open a WS join link

Details

Opening a join link will add an old unexisted route and a workspace list to the stack, so pressing back from the workspace list shows the not found page. This PR fix it.
Fixed Issues

$ https://github.com/Expensify/App/issues/44845
PROPOSAL: https://github.com/Expensify/App/issues/44845#issuecomment-2211031360
Tests

Same as QA Steps

[x] Verify that no errors appear in the JS console

Offline tests

Same as QA Steps
QA Steps

As user A, copy a join link of a workspace where user B is not a member
As user B, open the copied workspace join link
Press back button
Verify there is no not found page shows

[x] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label and/or tagged @Expensify/design so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

https://github.com/user-attachments/assets/7dfe9b2b-3c98-4f2d-a31d-c1508db5b777

Android: mWeb Chrome

https://github.com/user-attachments/assets/e3491d98-dcce-4be5-8878-9e05ec5cbc45

iOS: Native

https://github.com/user-attachments/assets/3ad4b6e2-dede-4522-8bcd-0161b5be89ad

iOS: mWeb Safari

https://github.com/user-attachments/assets/2f1c325d-7c38-47da-9830-dcf34f413ce2

MacOS: Chrome / Safari

https://github.com/user-attachments/assets/9812e6f9-44ab-4197-ae77-00c9cb7ad22e

MacOS: Desktop

https://github.com/user-attachments/assets/e92fff5b-0c59-4028-9ad2-4cc9d021ae86

Reviewer Checklist

[x] I have verified the author checklist is complete (all boxes are checked off).
[x] I verified the correct issue is linked in the ### Fixed Issues section above
[x] I verified testing steps are clear and they cover the changes made in this PR

[x] I verified the steps for local testing are in the Tests section
[x] I verified the steps for Staging and/or Production testing are in the QA steps section
[x] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[x] I checked that screenshots or videos are included for tests on all platforms
[x] I included screenshots or videos for tests on all platforms
[x] I verified tests pass on all platforms & I tested again on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[x] I verified proper code patterns were followed (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I verified that this PR follows the guidelines as stated in the Review Guidelines
[x] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label and/or tagged @Expensify/design so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[x] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native
https://github.com/user-attachments/assets/b744042a-e978-4b39-9157-757bf6428ad3

Android: mWeb Chrome
https://github.com/user-attachments/assets/a24e7738-d5c1-40f6-8090-169fc56c2f47

iOS: Native
https://github.com/user-attachments/assets/ba44371b-8386-4c26-9c9b-80165c9a7cdf

iOS: mWeb Safari
https://github.com/user-attachments/assets/ad868e8a-6530-43c2-a14d-bb559503824c

MacOS: Chrome / Safari
https://github.com/user-attachments/assets/5616137e-8c7d-4de4-a060-cc00325864cd

MacOS: Desktop

@bernhardoj could you please merge main

Done

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Cherry-picked to staging by https://github.com/roryabraham in version: 9.0.14-1 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

🚀 Deployed to production by https://github.com/roryabraham in version: 9.0.14-6 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


As keras use mxnet as  backend, I can not use the GPU  to train .

For bugs or installation issues, please provide the following information.
The more information you provide, the more likely people will be able to help you.
Environment info
Operating System: ubuntu16.04
Compiler:
Package used (Python/R/Scala/Julia):Python2.7
MXNet version: mxnet 0.11.0rc2
Or if installed from source:mxnet 0.11.0rc2
MXNet commit hash (git rev-parse HEAD):
If you are using python package, please provide
Python version and distribution:
If you are using R package, please provide
R sessionInfo():
Error Message:
Please paste the full error message, including stack trace.
[22:01:04] G:\mxnet-cpp\mxnet20170819\mxnet\src\storage\storage.cc:109: Check failed: e == cudaSuccess || e == cudaErrorCudartUnloading CUDA: no CUDA-capable device is detected
Minimum reproducible example
if you are using your own code, please provide a short script that reproduces the error.
\keras\examples\mnist_mlp.py
model = Sequential()
model.add(Dense(512, input_shape=(784,)))
model.add(Activation('relu'))
model.add(Dropout(0.2))
model.add(Dense(512))
model.add(Activation('relu'))
model.add(Dropout(0.2))
model.add(Dense(10))
model.add(Activation('softmax'))
model.summary()
gpu_list = ["gpu(0)"]
model.compile(loss='categorical_crossentropy',
optimizer=SGD(),
context=gpu_list, ##Remove this line, we use cpu to train.
metrics=['accuracy'])
Steps to reproduce
or if you are running standard examples, please provide the commands you have run that lead to the error.

I run the sample named mnist_mlp.py . When I use cpu, it works.  When I try it with GPU, it does not work.

I write some codes to test the  gpu function in mxnet, it works. The codes are like these:
import mxnet as mx
a = mx.nd.ones((2, 3), mx.gpu())

What have you tried to solve it?

I tried to compile the source codes . Then I tried again.  I got the same errors.  My cuda version is 8.0.  In gpu mode, tensorflow and mxnet are ok.  But when keras use mxnet as  backend, I can not use the GPU  to train .

@sandeep-krishnamurthy

Your Keras code looks fine.
Can you please confirm if you have installed/compiled MXNet with GPU support and have installed NVIDIA drivers?
Here is the detailed installation guide for your reference - https://github.com/dmlc/keras/wiki/Installation
Also can you provide your full code? I tried with https://github.com/dmlc/keras/blob/master/examples/mnist_mlp.py example by setting the context to gpu and it seems to work fine.

Sorry, it is my mistake.  My codes has some bug like these :
os.environ['CUDA_VISIBLE_DEVICES']='1'
When I remove this line, everything is ok.
I love the mxnet as the keras backend.  It is great!


[Guide] Basic JS: Greater than operator. Enhancements

From this PR on the old guide repo.
· Added problem explanation, run code example, code explanation and resources.

[x] I have read freeCodeCamp's contribution guidelines.
[x] My pull request has a descriptive title (not a vague title like Update index.md)
[x] My pull request targets the master branch of freeCodeCamp.
[x] None of my changes are plagiarized from another source without proper attribution.
[x] My article does not contain shortened URLs or affiliate links.

Closed and reopened this PR in an attempt to resolve the following Travis build error:
Error: ValidationError: "0" is not allowed. "1" is not allowed. "2" is not allowed. "3" is not allowed. "4" is not allowed

Thank you for your contribution to the page! 👍
We're happy to accept these changes, and look forward to future contributions. 🎉

We don't allow repl.it or codepen.io links anymore in the guide articles, so I "fixed" it.

I didn't know about that, where is this  change referenced? The style guide for creating and editing guide articles still encourages it.

It has not been added yet, but will be soon.  We are just removing them as we see them in open PRs, then once most of the curriculum related article PRs have been merged, we will do some kind of mass removal for any found.

Thank you @RandellDawson, pretty clarifying.
Sorry about the newb question but do this discussions take place on github issues, mail subs or something similar?

The discussion for this particular issue started in the Gitter chat room, but I also created an issue.  I have already made all the changes locally which removes them from all 6 languages, but will wait till there are fewer oustanding PRs for challenge related articles, before creating the PR for it.


Pinia Init Action

What problem is this solving
When  useStore() called a init action should be called by default it will help to run some custom code which can be filling the state with data fetched from a server, And it should be called only when a store is installed
Proposed solution
export const useWishlist = () => {
  const innerStore = defineStore('wishlist', {
    state: (): { isInit: boolean} => ({
      isInit: false,
    }),
    getters: {
    },
    actions: {
      async init() {
       if (process.server || this.isInit)
          return
        this.isInit = true

     // TODO: Code to run
    },
  });

  const store = innerStore();
  store.init()

  return store;
}

Describe alternatives you've considered

process.server is there because for Nuxt when SSR happens the isInit changes to true and init is async so it does not get updated
If it is possible to hydrate the state from server side it will be more efficient ...but I am unable to done that
If I put isInit last init function will trigger multiple times if in a single page multiple component has same store

Duplicate of #1080

@shba007 with your solution the TypeScript typings will not work when you use e.g. with ...mapState(uswWishList,
The store itself will work.


problem executing gpg

I'm having troubles translating this bash one liner
echo "1234" | gpg --no-use-agent -o /dev/null --local-user MY_KEY -as - && echo "PASSW IS CORRECT"
(checking if gpg key has password) into sh. I tried:
x = sh.gpg('--no-use-agent', '-as', o='/dev/null', local_user='MY_KEY', _fg=True, _in='1234\n')
if x.exit_code == 0:
    print('OK')
else:
    print('NOT OK')

But to no avail: when I enter correct gpg password, the last line "Enter passphrase: " disapears and the script is stuck on first line, never printing OK or NOT OK.
I would expect that after entering correct password it would print ok/not ok just like bash one liner.

@tkossak I tried your example and could reproduce it.  This looks like it's related to _fg=True and _in='1234\n.  After you enter the password, type anything else, then hit control-D (for EOF) and you should get output.  This suggests that _in isn't being used.  And that makes sense.  When _fg=True is used, the current terminal is attached to the process, so there's no way we can programmatically use _in to enter input.  The bug here is that you didn't get an error saying "don't use _fg=True and _in at the same time."
But I know that doesn't help what you're trying to do :)  I think your best bet would be to use a NamedTemporaryFile in place of trying to pipe in from stdin:
from tempfile import NamedTemporaryFile
h = NamedTemporaryFile()
sh.gpg('--no-use-agent', '-as', '-o', '/dev/null', '--local-user', 'MY_KEY', h.name, _fg=True)
h.close()

This works perfectly, thank you! Even more thank you for this awesome library that i discovered recently! I really like it :)

Happy to help @tkossak!  I'll leave this issue open until I add an exception that makes those two options incompatible


Drop dev{date} from version in next release

We no longer need to specify the dev{date} for releases as we are still using 0 release. We should drop that from the release name.

PR #254 fixed this.


Fixed Bug in simulate_queue_worker introduced by #8085

Fixes: #8118
@tumido @himdel @skateman

LGTM :shipit:


Add linting job

Description of the change

Existing or Associated Issue(s)

Additional Information

Checklist

[ ] Chart version bumped in Chart.yaml according to semver. Where applicable, update and bump the versions in any associated umbrella chart
[ ] Variables are documented in the values.yaml and added to the README.md. The helm-docs utility can be used to generate the necessary content. Use helm-docs --dry-run to preview the content.
[ ] JSON Schema generated.
[ ] List tests pass for Chart using the Chart Testing tool and the ct lint command.

I see many of the charts have outdated documentation again, since last time I made some contributions (and therefore also the CONTRIBUTING.md was not followed). Using this PR we should have an automated safety net in place to prevent this in the future.
How do you want to go about merging this PR vs fixing the docs in all the other charts? It is a bit chicken and egg story. Not merging this PR will not safeguard other PRs from preventing again outdated docs.
Not updating the docs will fail the builds till they are fixed.
I know there is a policy to only touch one chart per PR. Should we create one PR per chart just fixing the docs to merge this PR straight afterwards, or shall we skip that policy one time by fixing all the docs in this PR?
@cpanato @sabre1041  please let me know how you would like to move this forward.

@marcofranssen can you rebase and update?


How to use this without the prebuild?

Hi, I'm trying to use this on macOS 10.12 (Sierra) with Electron 1.7.5, for which there is no prebuilt package available.
I've managed to compile it following the instructions in the readme (running npm run build) and this produces a module in  iohook/build/Release/iohook.node.
This causes errors when trying to use it because the native module is expected to be in iohook/builds/electron-v54-darwin-x64/build/Release/iohook.node
I can of course manually move this file to where it is inpected, but an important goal is to have the app up and running straight away after a clean checkout and npm install.
Am I missing something or is this module only meant to work with  prebuilt binaries?
Adding support for electron abi 54 appears trivial, it just needs a few lines added in support.js. If I do that, running npm run deploy produces iohook/prebuilds/iohook-v0.1.9-electron-v54-darwin-x64.tar.gz.
Am I correct that that is all that's required? I'd be happy to send a pull request in that case.

@willemkokke - did you end up finding a solution that worked for you on this one?

@willemkokke Sorry for long response. Make pull-request if you can.
If not. I try to do it in short time.


There's problem in model.js source in method "generate"

I'm try and fail to use it. i am use tfjs-backend-cpu because it is the fastest in android 👍. however i can train and can't generate. errors when try generate because something is wrong in blackSize
CONSOLE :
Training took 2027.4000000059605ms
GatherV2: the index value 11 is not in [0, 10]
at assert$1 (http://localhost:7700/test/tf.js:19365:12)
at loop (http://localhost:7700/test/tf.js:106393:6)
at Object.gatherV2$1 [as kernelFunc] (http://localhost:7700/test/tf.js:106398:6)
at kernelFunc (http://localhost:7700/test/tf.js:23856:25)
at http://localhost:7700/test/tf.js:23926:22
at Engine.scopedRun (http://localhost:7700/test/tf.js:23693:20)
at Engine.runKernelFunc (http://localhost:7700/test/tf.js:23918:13)
at Engine.runKernel (http://localhost:7700/test/tf.js:23774:20)
at gather (http://localhost:7700/test/tf.js:33619:18)
at gather__op (http://localhost:7700/test/tf.js:24920:24)
value 11 is blockSize because when change it. value change either.
always 11 is not in [0, 10] and if blockSize = 5 for example error 5 is not in [0, 4] 😔 in every time
this problem in source "generate" function in model.js
So Sorry for my bad English. because I'm still studying 🤗 it

I'm using browser

I'm discovered what is problem. it's when use Wrong vocabSize and blockSize. Sorry my bad 😅👍

just in case it helps, we also have a complete case of how to use gpt-tfjs in https://github.com/epfml/disco/


[UI] - Project cards should display languages

The project card component should be updated to display the languages of each repository on them.

This issue was dealt with in the latest pr #5


Build(deps-dev): Bump eslint-config-prettier from 8.9.0 to 9.0.0 (#5034)

Pull request opened by the merge tool on behalf of #5034

Merged in d3268d1f2a4d35c49ab73dc75a9a80cfbdb535f8


chore(deps): upgrade dev dependencies

Upgrades project dependencies. See details in workflow run.

Automatically created by projen via the "upgrade-dev-dependencies-2.x" workflow

⚪ Backport skipped
The pull request was not backported as there were no branches to backport to. If this is a mistake, please apply the desired version labels or run the backport tool manually.
Manual backport
To create the backport manually run:
backport --pr 1513

Questions ?
Please refer to the Backport tool documentation


[Runtime] Abstract tag handling for generic single payload enums

This functionality will be shared across multiple functions, so adding the abstraction in preparation of that.

@swift-ci smoke test

@swift-ci smoke test


SLF4J StaticMDCBinder implementation

Fixes #9491
If classpath doesn't have org.slf4j.impl.StaticMDCBinder class, slf4j displays a message about it. The message is sent to System.err. This implementation returns NOPMDCAdapter as MDC adapter.

Thanks @remal - this will be in 5.6


The item you requested is not available for purchase.

Hi guys, when I trying to purchased an item, I receive an error from Google Store with the message "The item you requested is not available for purchase." If I try with an old APK version of my app is working perfectly, but If I try to compile the same project to build a new APK I have the issue. The only thing that I changed was the SDK platform update to version 23 and JVM (1.8.0_66-b17), maybe is this the problem but I tried downgrading SDK to version 22 and still the same problem. Those are the Errors from the console:
PurchaseFragment.onStateChange: Error: PurchaseError{type=3 subtype=0}
PurchaseFragment.onStateChange: Purchase failed: PurchaseError{type=3 subtype=0}
PD: the configuration for testers I think is not a problem because is working with the older APK version.

I think its because your version code. The new apk has a different version code than the published apk and for this reason your getting this error.
Regards.

I think its because your version code. The new apk has a different version code than the published apk and for this reason your getting this error.

That works in my case. Thanks! =)

      I think its because your version code. The new apk has a different version code than the published apk and for this reason your getting this error.

Regards.

And how to solve this problem, sometimes I distribute a higher version on other places before the store and I want to give the users the ability to buy the items to unlock features.


[SOLVED] [WORKAROUND] log2timeline cannot output plaso file due to dependencies failure

Hi,
i receive the following errors while creating a super timeline using log2timeline. This is a fresh import of ova appliance (SIFT workstation v3.0) Please advice on resolution.
Thank you
log2timeline.py /tmp/output /cases/nps-jeans/nps-2008-jean.E01
Checking availability and versions of dependencies.
[FAILURE]	elasticsearch version: 6.2.0 is too recent, 5.5.1 or earlier required.
Regards
Jun Wei

I shall wait for the fix.  I have installed 5 but had a hard time figuring out how to link the python scripts together.
Sent from my iPhone

On 22 Jun 2018, at 4:39 PM, Erik Kristensen<EMAIL_ADDRESS>wrote:
We are aware. It’s being worked on. Should have a fix by next week. In the mean time you can uninstall 6 and install 5 and it should fix
Erik
Sent from my iPhone

On Jun 22, 2018, at 06:39, ljw001<EMAIL_ADDRESS>wrote:
Hi,
i receive the following errors while creating a super timeline using log2timeline. This is a fresh import of ova appliance (SIFT workstation v3.0) Please advice on resolution.
Thank you
log2timeline.py /tmp/output /cases/nps-jeans/nps-2008-jean.E01
Checking availability and versions of dependencies.
[FAILURE]	elasticsearch version: 6.2.0 is too recent, 5.5.1 or earlier required.
Regards
Jun Wei
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.

Jun Wei,
I have experienced the same issue.  Try this as a work around.  The Plaso team has acknowledged this issue and are working on a fix.  They gave me the work around.
If this command works for you,  you should be all set.  Just include it as the 1st parameter on all your Plaso commands (log2timeline, psort, image_info, etc.).
-Mark
log2timeline.py --no-dependencies-check -V

Hi Mark,
Thanks. The workaround did work!
Regards
Jun Wei
Sent from my iPhone

On 23 Jun 2018, at 12:34 AM, mark-hallman<EMAIL_ADDRESS>wrote:
Jun Wei,
I have experienced the same issue. Try this as a work around. The Plaso team has acknowledged this issue and are working on a fix. They gave me the work around.
If this command works for you, you should be all set. Just include it as the 1st parameter on all your Plaso commands (log2timeline, psort, image_info, etc.).
-Mark
log2timeline.py --no-dependencies-check -V
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.

FYI Providing a work-around is not a fix

I would be interested in the fix vs. the workaround as well. I installed elasticsearch v5.5.1 but still received the dependency error. When providing the '--no-dependencies-check' switch it kicks off processing, but I'm not sure if this impacts log2timeline functionality. Thanks in advance!

I would be interested in the fix vs. the workaround as well.

The --no-dependencies-check is there to skip the dependency check. But this check is there for a reason, given that some dependencies are only needed to support specific data format. Unless you know for sure that you are not going to use the format that a missing dependency provides, it is risky to use this flag.
A fix would be to install the missing dependency or if a potential bug in plaso file an issue with the plaso project.
Plaso added support for both elasticsearch5-py and elasticsearch-py in the end: https://github.com/log2timeline/plaso/commit/00ef17c545041f711a4403a47ab2c39ac31a1445. So this should no longer be an issue.


Find 404 error in the test

Find this line of code in  “ PHP - s ”  404  error occurs
Original code
$uri = dirname($_SERVER['PHP_SELF']).'/'.$params[0]; //29

Modify code
$uri = strpos($params[0], '/') === 0 ? $params[0] : '/' . $params[0]; //29

Agreed, I've opened a PR for this.

Merged #62!

Changing this back to the original code solved this issue of everything being a 404 error. Just wanted to give a heads up this may still be iffy.


Crash on plug-in in external monitor

Sway Version:
sway version 1.4-5ed01c86 (Feb 27 2020, branch 'master'
Debug Log
Not much ;(
sway: types/wlr_xdg_output_v1.c:101: output_manager_handle_get_xdg_output: Assertion `layout_output' failed.
2020-02-27 12:33:00 - [common/ipc-client.c:88] Unable to receive IPC response

The same issue has been reported in Wayfire as well (no issue on GitHub though).


Refactored Manager concept into Services

Overview
There was a bit of confusion and misconception of the MixedRealityManager. Its sole responsibility is to keep all the other feature systems, and components synchronized and in step. This is the only entry point for the Mixed Reality Toolkit into the user's project and into the scene. This component's sole responsibility is to be a resource locator and facilitator of each feature's communication in a decoupled and emergent way.
This Pull Request tries to re-define the concepts of this core system and break misconceptions.
No logical changes, only renames.

I highly recommend we make this change before we go beta

we will likely need to be changing some layering as well.

Likely not unless something substantial comes up that wasn't previously addressed.

I highly recommend we make this change before we go beta

why the rush? i really want to understand the customer issue before making changes

I don't think this change addresses the concerns as I understand them. We shouldn't make a breaking change until we properly understand the underlying concerns.

we will likely need to be changing some layering as well.
Likely not unless something substantial comes up that wasn't previously addressed.

The layering I am alluding to is updating the systems to access the manager through an interface, not the concrete class and allowing for pluggable managers.

The layering I am alluding to is updating the systems to access the manager through an interface, not the concrete class and allowing for pluggable managers.

Lol what? We already enforce that.

This also isn't really a breaking change as just a rename.

I'm tired of being hanstrung trying to be agile, make improvements, and address feedback while still in alpha.

The layering I am alluding to is updating the systems to access the manager through an interface, not the concrete class and allowing for pluggable managers.
Lol what? We already enforce that.

We enforce from the manager -> systems, not the other way around...
For example:
MixedRealityToolkit-SDK\Features\Input\FocusProvider.cs:239:            foreach (var inputSource in MixedRealityManager.InputSystem.DetectedInputSources)

I'm tired of being hanstrung trying to be agile, make improvements, and address feedback while still in alpha.

We are in the final stretch of finishing the beta... we have already agreed that breaking changes are allowed between major releases (ex: 2018 -> 2019 -> 2020).
I really want to make sure we are setup for success with both enterprise and independent customers.

If we don't do it now it'll cause more confusion in the future.

The confusion is why I requested (on slack) that I meet with the customer and have a deep dive discussion. I do not believe changing the name solves the underlying issue.

we have already agreed that breaking changes are allowed between major releases (ex: 2018 -> 2019 -> 2020).

Community members didn't have much say in the matter as it's part of the internal agenda. We really shouldn't be rushing this as much as it has been. Imo we need to release the beta when it's ready.

We enforce from the manager -> systems, not the other way around...
For example:
MixedRealityToolkit-SDK\Features\Input\FocusProvider.cs:239: foreach (var inputSource in MixedRealityManager.InputSystem.

No we don't. And this is a one off example of something that needs to be fixed and already has an issue assigned to it. This is one of the few exceptions, but is identified.

I do not believe changing the name solves the underlying issue.

I don't think there's an issue at all, but a complete misunderstanding and misconceptions of past experiences. Documentation and discussion will help solve those issues. If the MRTK isn't something they want to utilize that's their decision.

I do not believe changing the name solves the underlying issue.
I don't think there's an issue at all, but a complete misunderstanding and misconceptions of past experiences. Documentation and discussion will help solve those issues. If the MRTK isn't something they want to utilize that's their decision.

We should table this discussion until the next shiproom (tomorrow) so that we can get clarity.

Unfortunately I will not be able to attend as I'll be 30k ft 😅

Unfortunately I will not be able to attend as I'll be 30k ft

We can schedule a call for when you are on the ground.

I would have to agree with Stephen on this point.  As this is really just about naming and breaking down barriers to understanding, especially following the recent meetings.  It would be better to get the names right before finalising Beta.
Else, this is going to hit hard on any consumers / customer consuming the project as they'll have major refactoring to do later.
I can understand wanting to wait, but that will ultimately hurt us more upgrading to 2019, as well as invalidating all our documentation / tutorials / etc.
I personally would prefer to settle on the naming now and stick to it, rather than change later. imho.  And the new namings align more to the feedback we've been getting.

invalidating all our documentation / tutorials / etc.

that is a reasonable concern. I do want to make sure we revisit the feedback from the customer (I have a meeting tomorrow) and only change names if the value is there.

Fair enough.
I'm planning an a quick start series for the beta.  But if the naming / use is going to change straight after the beta is released (e.g. for 2019) then there isn't much point, as the Beta would just be an internal stream.

I should have a better inderstanding within 24 hours.  thanks
for your feedback and understanding

Don't want to step in the name now / name later debate - I see the need for the change as well as the rationale behind waiting.
@StephenHodgson @SimonDarksideJ  IMixedRealityService feels much clearer. Not a huge fan of Orchestrator though.
Manager is misleading but clear. You get that important things happen there even if you're wrong about its responsibilities.
Orchestrator doesn't mislead but only because it puts no clear idea in mind, even if you're familiar with the technical term. At a glance I'd take it for some background service I wasn't supposed to touch.
We played with alternatives and thought Hub had potential. Hubs are where important things happen (or through which important things are routed) without the expectation of management / intervention. And MixedRealityHub is less verbose than MixedRealityOrchestrator which is a nice bonus.

I should have a better inderstanding within 24 hours.

Looks like I misread my calendar.... I meet with the customer friday.

Hubs are where important things happen (or through which important things are routed)

I could live with Hub... Part of me would really like to just call it MixedRealityToolkit as the component is the entry point to the MRTK.

I like your thinking Lars and this is a really good debate, especially around not trying to make it too wordy.
Whilst I already suggested simply naming the scene object to "MixedRealityToolkit", there is also potential merit to also calling the "orchestrator / service locator / hub" as simply

MixedRealityToolkit

Doesn't need to say what it does or how it works, just that it IS the heart of the toolkit (although, also now an "optional" thing maybe)
Thoughts?

To summarize the discussion so far. I believe everyone who commented is good with the interface rename and that the blocker for this PR is the manager rename.

@davidkline-ms , can you summarise the discussion in Shiproom about the "agreed" changes / standards for this PR here please.

@SimonDarksideJ, was just about to do that :)

From 10/17 shiproom, it was decided that the following changes should be made:
Namespace:
Microsoft.MixedReality.Toolkit.Core.Managers -> Microsoft.MixedReality.Toolkit.Core.Systems
Interfaces:
IMixedRealityManager* -> IMixedRealitySystem*
Scene object:
MixedRealityManager -> MixedRealityToolkit
(this includes the internal object name as well, so MixedRealityManager.Instance becomes MixedRealityToolkit.Instance)
Open item: What to call the registered components, since component has a Unity concept associated.
Proposed terms:

Service
Agent
Provider

Just to clarify IMixedReality<Feature Name>System, correct?

Just to clarify IMixedRealitySystem, correct?

Yes. Trust the shiproom notes (the multicolored handwritten images). :)

I believe the only change that needs to be made to accommodate this with the PR is renaming the Mixed Reality Orchestrator.
You guys should have push access to my branch to do that. I won't be able to make it to a computer and time soon.

I believe the only change that needs to be made to accommodate this with the PR is renaming the Mixed Reality Orchestrator.

The Services namespace was also a question mark.

They're all services


[SecondaryNetwork] Attach OVS uplink after removing flow-restore-wait flag

Physcial network interface is attached on the OVS bridge with SecondaryNetwork feature enabled. Antrea uses a global configuration flow-restore-wait='true' to ensure that OVS OpenFlow entries can start working after the dependencies are ready. A connectivity issue exists if a setup uses the Node NIC as secondary network interface and connects the NIC to OVS bridge before removing the flow-restore-wait option.
This change ensures agent attaches the physical network interface to the secondary OVS bridge after the global flow-restore-wait option is removed.
Fix: #6448

/test-all

/test-all

/test-latest-all

/test-all


[test] fl-suggestion

test the suggestion from Mr. Josh Holtz

https://cd.screwdriver.corp.yahoo.co.jp/pipelines/3774/builds/61931617
It seems far more clear & works perfect!


scripts/popup.js Misssing

Thanks for this example!
FYI scripts/popup.js is referenced in views/popup.html but doesn't exist.

Hi crowers, popup.html is not being used in exyemsion. It is a redundant file. I forgot to delete it.

I hope my last reply cleared the doubt. I will be closing this issue thread. If you have any further question you may continue so in the discussion or if there are any issues concerning this very topic you are free to reopen this issue.

Makes sense. Thanks again for this.
On Sat, 4 Mar 2023 at 06:19, Draken Wan @.***> wrote:

I hope my last reply cleared the doubt. I will be closing this issue
thread. If you have any further question you may continue so in the
discussion or if there are any issues concerning this very topic you are
free to reopen this issue.
—
Reply to this email directly, view it on GitHub
https://github.com/DrakenWan/Yale3/issues/7#issuecomment-1454530182, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/ALWAEGY3QQIMRMIUFUWMZY3W2LNGBANCNFSM6AAAAAAVLTVKFA
.
You are receiving this because you authored the thread.Message ID:
@.***>

--
Kind regards
Peter Chapman
Mobile: +44 7889 574824
LinkedIn https://www.linkedin.com/in/peterjchapman/
https://crowers.co.uk
Tel: ** +44 (0) 1223 656 808
Web: https://crowers.co.uk http://crowers.co.uk
Red Barns, Ashwell Road, Guilden Morden, Royston SG8 0JY, UK
Crowers Limited Company Registration No. 10894526 England.
VAT Registration No. GB 282199966


Eclipse and IntelliJ should expose the same configuration parameters for local run and deployment

@elharo

Agreed. I don't think there's anything either Eclipse or IntelliJ specific here. It's mostly a querstion of reflecting the various available command line flags. Maybe we should make a document in the wiki?
for run and debug command line arguments are here: https://cloud.google.com/appengine/docs/java/tools/devserver
for deploy it's here: https://cloud.google.com/sdk/gcloud/reference/app/deploy
Is there anything else we need that's not covered by this?

Here's the list of flags on dev_appserver.py:
usage: dev_appserver.py [-h] [-A APP_ID] [--host HOST] [--port PORT]
                        [--admin_host ADMIN_HOST] [--admin_port ADMIN_PORT]
                        [--auth_domain AUTH_DOMAIN] [--storage_path PATH]
                        [--log_level {debug,info,warning,critical,error}]
                        [--max_module_instances MAX_MODULE_INSTANCES]
                        [--use_mtime_file_watcher [USE_MTIME_FILE_WATCHER]]
                        [--threadsafe_override THREADSAFE_OVERRIDE]
                        [--php_executable_path PATH]
                        [--php_remote_debugging [PHP_REMOTE_DEBUGGING]]
                        [--php_gae_extension_path PATH]
                        [--php_xdebug_extension_path PATH]
                        [--appidentity_email_address APPIDENTITY_EMAIL_ADDRESS]
                        [--appidentity_private_key_path APPIDENTITY_PRIVATE_KEY_PATH]
                        [--python_startup_script PYTHON_STARTUP_SCRIPT]
                        [--python_startup_args PYTHON_STARTUP_ARGS]
                        [--jvm_flag JVM_FLAG]
                        [--custom_entrypoint CUSTOM_ENTRYPOINT]
                        [--runtime RUNTIME] [--blobstore_path BLOBSTORE_PATH]
                        [--mysql_host MYSQL_HOST] [--mysql_port MYSQL_PORT]
                        [--mysql_user MYSQL_USER]
                        [--mysql_password MYSQL_PASSWORD]
                        [--mysql_socket MYSQL_SOCKET]
                        [--datastore_path DATASTORE_PATH]
                        [--clear_datastore [CLEAR_DATASTORE]]
                        [--datastore_consistency_policy {consistent,random,time}]
                        [--require_indexes [REQUIRE_INDEXES]]
                        [--auto_id_policy {sequential,scattered}]
                        [--logs_path LOGS_PATH]
                        [--show_mail_body [SHOW_MAIL_BODY]]
                        [--enable_sendmail [ENABLE_SENDMAIL]]
                        [--smtp_host SMTP_HOST] [--smtp_port SMTP_PORT]
                        [--smtp_user SMTP_USER]
                        [--smtp_password SMTP_PASSWORD]
                        [--smtp_allow_tls [SMTP_ALLOW_TLS]]
                        [--prospective_search_path PROSPECTIVE_SEARCH_PATH]
                        [--clear_prospective_search [CLEAR_PROSPECTIVE_SEARCH]]
                        [--search_indexes_path SEARCH_INDEXES_PATH]
                        [--clear_search_indexes [CLEAR_SEARCH_INDEXES]]
                        [--enable_task_running [ENABLE_TASK_RUNNING]]
                        [--allow_skipped_files [ALLOW_SKIPPED_FILES]]
                        [--api_port API_PORT]
                        [--automatic_restart [AUTOMATIC_RESTART]]
                        [--dev_appserver_log_level {debug,info,warning,critical,error}]
                        [--skip_sdk_update_check [SKIP_SDK_UPDATE_CHECK]]
                        [--default_gcs_bucket_name DEFAULT_GCS_BUCKET_NAME]
                        yaml_or_war_path [yaml_or_war_path ...]

And the flags for deploy:
     --bucket BUCKET
        The Google Cloud Storage bucket used to stage files associated with the
        deployment. If this argument is not specified, the application's
        default code bucket is used.

     --image-url IMAGE_URL
        Deploy with a specific Docker image. Docker url must be from one of the
        valid gcr hostnames.

     --promote
        Promote the deployed version to receive all traffic.

        True by default. To change the default behavior for your current
        environment, run:

            $ gcloud config set app/promote_by_default false

        Overrides the default promote_by_default property value for this
        command invocation. Use --no-promote to disable.

     --stop-previous-version
        Stop the previously running version when deploying a new version that
        receives all traffic. Overrides the default stop_previous_version
        property value for this command invocation. Use
        --no-stop-previous-version to disable.

     --version VERSION, -v VERSION
        The version of the app that will be created or replaced by this
        deployment. If you do not specify a version, one will be generated for
        you.

The dev appserver is obviously the trickier customer in terms of figuring out what a user is likely to care about.  I'm going to look into that now.


separate rules for transport demand and nodal energy totals

This PR disentangles the prepare_data() function in prepare_sector_network.

adds two new rules build_transport_demand and build_population_weighted_energy_totals
renames prepare_data to build_heat_demand
calls COP data where needed

Looks all good to me!


Question about inference and auroc measure

The process used to generate predicted labels in the inference.py script does not seem to take multi-label classification into account. The ground truth labels contain probabilities for multiple lesions (since this is a multi-label classification task), but the script uses np.argmax to select only a single lesion out of 14 possible lesions (ChestX-ray 14 dataset).
In summary, is the inference.py script wrong for this task? Or is the task itself not intended to be multi-label classification?

Thank you for pointing this out. In fact, we did not use 'pre' as hard predictions for calculating metrics; we only used the scores to compute the AUC. Therefore, this part of the code does not require attention. If we wish to calculate metrics in the future, we prefer using prompts like 'There is [Disease]' and 'There is no [Disease]'. After generating the corresponding scores, we can make hard predictions by comparing their numerical values.


Port 3000 is already in use

I'm already using Port 3000 for a rails project. How to change the port to run this tool locally

You can change the port in bin/www or set PORT environment variable.


New Sample : MVP using Blade and Dagger2

I'd like to create a sample that demonstrates the usage of library Blade.
Blade offers multiple modules for boilerplate destruction, one of which is mvp module that makes MVP on Android simple and uses Dagger2 for Presenter injection.
I would also use RxJava2 in the sample.

Feel free to create the sample and let us know.


[WIP] Fix thermal distributions again

I misunderstood what ThermalDistributionOfT was providing (and so I broke e.g. gray opacities in #20).
Ultimately we want to provide both $I = \int I_{\nu} d\Omega d\nu$ and $u = 1/c \int I_{\nu} d\Omega d\nu$ (or maybe just let users divide I by c to get u)
I'm also adding to README.md to help avoid this kind of confusion going forward

I'm fine with letting users divide by C or adding another function. Dividing by C seems cleanest, though.


Fix bug for Scalable-Broadcast

When running the current Scalable-Broadcast demo (https://rtcmulticonnection.herokuapp.com/demos/Scalable-Broadcast.html) watchers on at least chrome and firefox cannot open a stream. This is because the browser tries to set the local answer sdp in a stable state. The solution is to not negotiate a new state when the state is stable.

@Periodic1911 :+1: Thanks a lot for the fix. I can confirm that the fix allows streams to be hosted on Firefox (v74/Linux). I also tested on  Chromium (v80.0.3987.87/Linux) and Chrome (Version 80.0.3987.149/Linux). These worked before (for me) and still do after the fix.
@muaz-khan Is there any reason not to merge the PR?

Strange :-/ It worked once, but now it doesn't (with FF host).

Bumping this issue. Would be great to have this merged in.

@muaz-khan This change has some issues:

the change was only made to dist/RTCMultiConnection.js
many iceConnectionStates, including closed and failed, are no longer handled
nor are they raised to the application via connection.onPeerStateChange


[AppService] No resource name completion on 'az appservice web config hostname list'

$ az appservice web config hostname list -g com-appservice-1 --webapp-name <tab><tab>

This should have should my web apps but returns nothing in tab completion.

This was broken by #1985 which renamed the parameter, but didn't update the params.py file
//cc: @twitchax
I will fix it today

Awesome: thanks!


Portfolio: details popup window

For this milestone of my portfolio website, I implemented the popup window that includes the project details in both desktop and mobile version. In order to do that, I store the information about my projects in a JavaScript object.
I used the Figma Template number 1 for this project.
The general requirements of this milestone were:

No linter errors.
Correct use of GitHub flow.
Work documented in a professional way.

Project Requirements

[ ] When the user clicks (or taps) the button to check project details, the popup with details about the project appears.
[ ] When the user clicks (or taps) the close (X) button, the popup disappears.
[ ] I need to use a JavaScript array to store all of the information for all projects.
[ ] For each project I needed to store the following pieces of data in a JavaScript object, at a minimum: name, description, featured image, technologies, link to live version, link to source.
[ ] I needed to update the main page so that the projects section is created dynamically using the information stored in that JavaScript object, all of the HTML in that section is created when the page loads.
[ ] I implemented popups for both mobile and desktop screen sizes:

I ask for your kind review in order to continue with the develop of my project.
Thank you for your support.

Thank you @DeliceLydia, great support!! 👏


Add docs on how to use each core hook [ongoing]

Explanation of what each hook does, its return type, and how you should use it.

done


How can I show my model collider?

Hi. I have a model. And I want create box collider around the model, but i don't see collider bounds. How can I select and see collider?
Solution with showing all colliders in a scene is useless for this case.

From within the editor or in your game ?
If from within the editor why wouldn't showing all colliders work in your case ? I'm not aware of any other solution besides that one, or using a cube model as a guide and scaling that one with the box collider.

From within the editor or in your game ?
In editor.

If from within the editor why wouldn't showing all colliders work in your case ?
Because I'm designing the model. Because I want to see once collider and my model when I design the model.

Have you tried opening the prefab in single view mode by double clicking it?

Have you tried opening the prefab in single view mode by double clicking it?

Of course.

And what was the issue with herocrab's solution ?

Is this still an issue, otherwise this can be closed.


Cannot fire click event in IE 10

I cannot figure out why only in IE 10 (I've tested with Windows 7)
In this website http://www.nexta-tech.com/en/ it's not possible to click on the hamburger menù.
Also the hover do not show the correct cursor pointer.
This happens only in homepage, for other pages like http://www.nexta-tech.com/en/company
works correctly.
Do you have an idea what I'm doing wrong?
Thanks in advance!

I've fixed it! It was happening something with Pace.js loading tag styles that was positioned fixed with a high z-index over all the page and for some reasons only in IE 10 was not working correctly.
The fix for my issue is showing and hiding the Pace.js tag
using the Pace.js events callbacks.
// Pace.js
Pace.on('start', function(){
  $('.pace').show();
});

Pace.on('done', function(){
  $('.pace').hide();
});


problem encountered using license_finder with cocoapods 0.37.0

Hello,
We tried running license_finder against our codebase, which is using cocoapods 0.37.0 and were met with the following:
................................................................................................................../Users/pivotal/.rbenv/versions/2.1.6/lib/ruby/gems/2.1.0/gems/license_finder-2.0.4/lib/license_finder/package_managers/cocoa_pods.rb:51:in `read_plist': undefined method `expand_path' for nil:NilClass (NoMethodError)
	from /Users/pivotal/.rbenv/versions/2.1.6/lib/ruby/gems/2.1.0/gems/license_finder-2.0.4/lib/license_finder/package_managers/cocoa_pods.rb:34:in `license_texts'
	from /Users/pivotal/.rbenv/versions/2.1.6/lib/ruby/gems/2.1.0/gems/license_finder-2.0.4/lib/license_finder/package_managers/cocoa_pods.rb:16:in `block in current_packages'
	from /Users/pivotal/.rbenv/versions/2.1.6/lib/ruby/gems/2.1.0/gems/license_finder-2.0.4/lib/license_finder/package_managers/cocoa_pods.rb:8:in `map'
	from /Users/pivotal/.rbenv/versions/2.1.6/lib/ruby/gems/2.1.0/gems/license_finder-2.0.4/lib/license_finder/package_managers/cocoa_pods.rb:8:in `current_packages'
	from /Users/pivotal/.rbenv/versions/2.1.6/lib/ruby/gems/2.1.0/gems/license_finder-2.0.4/lib/license_finder/package_manager.rb:37:in `current_packages_with_relations'
	from /Users/pivotal/.rbenv/versions/2.1.6/lib/ruby/gems/2.1.0/gems/license_finder-2.0.4/lib/license_finder/package_manager.rb:23:in `each'
	from /Users/pivotal/.rbenv/versions/2.1.6/lib/ruby/gems/2.1.0/gems/license_finder-2.0.4/lib/license_finder/package_manager.rb:23:in `flat_map'
	from /Users/pivotal/.rbenv/versions/2.1.6/lib/ruby/gems/2.1.0/gems/license_finder-2.0.4/lib/license_finder/package_manager.rb:23:in `current_packages'
	from /Users/pivotal/.rbenv/versions/2.1.6/lib/ruby/gems/2.1.0/gems/license_finder-2.0.4/lib/license_finder/core.rb:60:in `current_packages'
	from /Users/pivotal/.rbenv/versions/2.1.6/lib/ruby/gems/2.1.0/gems/license_finder-2.0.4/lib/license_finder/core.rb:55:in `decision_applier'
	from /Users/pivotal/.rbenv/versions/2.1.6/lib/ruby/gems/2.1.0/gems/license_finder-2.0.4/lib/license_finder/cli/main.rb:26:in `action_items'

Any help or pointers appreciated.  are we doing something wrong?

Hi Andrew,
Without more information, I can't reproduce it and thus can't accurately diagnose.
That said: do you have a file named Pods-acknowledgements.plist somewhere in your project tree? If so, where is it? (LF assumes it's in either Pods or Pods/Target Support Files/Pods, which correspond to the behavior of various versions of cocoapods (see #118 for some historical context).

Worth noting that the test suite passes on cococapods 0.37.1 (I just checked). So, more info on the location of your acknowledgements file would be helpful. Thanks.

OK, maybe we have made a mistake in setup.  we will look into it further and follow up later.
thanks Mike.

Our codebase didn't have a Pods-acknowledgements.plist anywhere.  I assume that is a file generated by cocoapods?
Our project ended up migrating away from cocoapods since it was adding warnings to our build process which could not be fixed by us or suppressed, making it so that we were not able to treat warnings as errors.  And we prefer to treat warnings as errors.
I won't be able to follow up much more on this issue in the context of this project, so feel free to close if no one else has been experiencing this problem.

Haven't heard further reports of problems, so closing.  Please re-open if it crops up again.


Add Drupal at your Fingertips book to PHP/Drupal section

What does this PR do?
Add Drupal book
For resources
Description
Why is this valuable (or not)?
How do we know it's really free?
I wrote it.  There are no limitations to accessing it
For book lists, is it a book? For course lists, is it a course? etc.
It is a book
Checklist:

[x] Read our contributing guidelines.
[x] Search for duplicates.
[x] Include author(s) and platform where appropriate.
[x] Put lists in alphabetical order, correct spacing.
[x] Add needed indications (PDF, access notes, under construction).
[x] Used an informative name for this pull request.

Follow-up

Check the status of GitHub Actions and resolve any reported warnings!

This is an automated response to help you with this issue. Please let us know if you need further assistance.

Thanks, and welcome to free-programming-books!


fix(DTFS2-7647): add missing test to yml file

Introduction :pencil2:
A test was being skipped on the pipeline due to incorrect config in the test.yml file
Resolution :heavy_check_mark:
Fix the config in the test.yml file to pick up all the tests when the deal cancellation FF is enabled
Miscellaneous :heavy_plus_sign:
List any additional fixes or improvements.

@BethThomas141  is this test no longer required


Ocelot on full .Net framework 4.6.1 fails to create HttpClient and use

Steps to Reproduce the Problem
In VS 2017 create .Net Core project but select (at the second screen) .NET Framework, not .Net Core one.
Select in the Project -> properties 4.6.1 framework.
Configure Ocelot and run.
An attempt to get into a route will throw.
Specifications

Version: Win 10
Platform: .NET 4.6.1
Subsystem:

And here is the code to fix it:

--- a/src/Ocelot/Requester/HttpClientBuilder.cs
+++ b/src/Ocelot/Requester/HttpClientBuilder.cs
@@ -42,15 +42,29 @@ namespace Ocelot.Requester
             {
                 return httpClient;
             }
-
-            var httpclientHandler = new HttpClientHandler
+            bool useCookies = context.DownstreamReRoute.HttpHandlerOptions.UseCookieContainer;
+            HttpClientHandler httpclientHandler;
+            // Dont' create the CookieContainer if UseCookies is not set ot the HttpClient will complain
+            // under .Net Full 46
+            if (useCookies)
             {
-                AllowAutoRedirect = context.DownstreamReRoute.HttpHandlerOptions.AllowAutoRedirect,
-                UseCookies = context.DownstreamReRoute.HttpHandlerOptions.UseCookieContainer,
-                CookieContainer = new CookieContainer()
-            };
+                httpclientHandler = new HttpClientHandler
+                {
+                    AllowAutoRedirect = context.DownstreamReRoute.HttpHandlerOptions.AllowAutoRedirect,
+                    UseCookies = context.DownstreamReRoute.HttpHandlerOptions.UseCookieContainer,
+                    CookieContainer = new CookieContainer()
+                };
+            }
+            else
+            {
+                httpclientHandler = new HttpClientHandler
+                {
+                    AllowAutoRedirect = context.DownstreamReRoute.HttpHandlerOptions.AllowAutoRedirect,
+                    UseCookies = context.DownstreamReRoute.HttpHandlerOptions.UseCookieContainer,
+                };
+            }

-            if(context.DownstreamReRoute.DangerousAcceptAnyServerCertificateValidator)
+            if (context.DownstreamReRoute.DangerousAcceptAnyServerCertificateValidator)
             {
                 httpclientHandler.ServerCertificateCustomValidationCallback = (request, certificate, chain, errors) => true;

diff --git a/src/Ocelot/Requester/HttpClientHttpRequester.cs b/src/Ocelot/Requester/HttpClientHttpRequester.cs
index c7914c9..60d4899 100644
--- a/src/Ocelot/Requester/HttpClientHttpRequester.cs
+++ b/src/Ocelot/Requester/HttpClientHttpRequester.cs
@@ -32,7 +32,17 @@ namespace Ocelot.Requester

             try
             {
-                var response = await httpClient.SendAsync(context.DownstreamRequest.ToHttpRequestMessage());
+                var message = context.DownstreamRequest.ToHttpRequestMessage();
+
+                // Remove Content from the message if not put or post or the http client will choke
+                // under .Net Full 46
+                if (message.Method != HttpMethod.Post &&
+                    message.Method != HttpMethod.Put)
+                {
+                    message.Content = null;
+                }
+                _logger.LogDebug(string.Format("Sending {0}", message));
+                var response = await httpClient.SendAsync(message);
                 return new OkResponse(response);
             }
             catch (TimeoutRejectedException exception)

Created a pull request for this
Thanks for the great project

@tsirkin thanks for reminding me I will do a release next week!


BoomboxMod

Hi, the more people in the lobby, the slower the songs load (for 3 people, about 2 minutes). Is this normal?
Thanks for the mod

that is a shocking amount of time! the mod just waits for everyone to download the video from youtube and then convert it to audio, so if someone has a slower download speed and/or slower pc it might take longer
a less lightweight more powerful mod that might work better for slow download speed issues is DiscJockey: https://thunderstore.io/c/lethal-company/p/Yoshify/DiscJockey/


Add APY Breakdown Info from API Endpoint apy/breakdown on the APP

Beefy's App currently displays the Total APY of most AMM's (inclusive of trading APR). What needs to happen is the info from the newly created apy/breakdown endpoint needs to be displayed on the app. It might make the most sense to include this in a hover over module since its a lot of information in one place. At bare minimum a display for Total APY, Vault APY, Trading APR, Daily APY and TVL is needed.

Can I request that we don't have hovers? If you want the information hidden until a user interaction, perhaps some dropdown toggle similar to the way the vault card opens.
Hovers don't always work great on touch devices (mobile/tablet), and they often go missed completely as there is no chance to accidently hover over them like you might on desktop.

Agree with the feedback. I'll remove from initial post.

I've seen the no-hover-on-mobile problem resolved by a small-circled-i added at least on the mobile flavor of the app which is clickable with a small, pretty info popup the disappears with the next touch anywhere. On desktop, I do like hovers. My 2 cents.

I'm not against them if they work when clicked on mobile, and it is made obvious that they can be clicked.
Trying to avoid the ones like on the chain icons on https://www.beefy.finance/ - works fine on desktop but on mobile there is no way to know they are there until you click it.

This can be closed; was added in #573


Add a CLI for the domainmodel example

The CLI generates Java classes with private fields and corresponding getters and setters.
Closes issue/131.

Please move cli.ts and generator.ts to a subdirectory cli. Currently we have code for multiple processes in one package, so we should use a clear directory structure to avoid confusion.
cli.ts could be renamed to index.ts so it can be invoked with node lib/cli (equivalent to node lib/cli/index.js).


doc: describe Unix signal handling better

SIGTERM seems OK to handle - I tested that on Linux, read POSIX, etc.
I can't see why it should be different from SIGUSR1, for example,
except that the default handler is different.
Also raise(15) is caught by the handler for me, and I can't see
why it wouldn't.

The main source of knowledge for this is POSIX.
http://pubs.opengroup.org/onlinepubs/9699919799/functions/V2_chap02.html#tag_15_04_03_03

Or did some of the paragraphs I replaced mean to refer to Windows? (and not marked properly)  I can really only write about Unix systems.

@piscisaureus Can this be merged after the last round of changes?

I must say I feel a bit conflicted about doing (similar) contributions to libuv.

@vcunat Sorry, landed in 4fc5a0ee6 and thanks!
We frequently land pull requests in batches. Yours would eventually have been rounded up because it was already signed off on. :-)

Ah, OK.  I didn't know the workflow, i.e. the fact that one positive review "is enough" and it only waits for such a roundup.


config.adapter.build (npm run build) arguments do not match Adapter#build argument types

https://github.com/solidjs/solid-start/blob/main/packages/start/bin.cjs#L185
config.adapter.build(config, { ... })

https://github.com/solidjs/solid-start/blob/main/packages/start/vite/plugin.d.ts#L3
export type Adapter = {
  start(options: Options): Promise<void>;
  build(options: Options): Promise<void>;
  dev(options: Options): Promise<void>;
  name: string;
};

The arguments passed to config.adapter.build do not match the Adapter build function type arguments.

In setting up for SolidStarts next Beta Phase built on Nitro and Vinxi we are closing all PRs/Issues that will not be merged due to the system changing. If you feel your issue was closed by mistake. Feel free to re-open it after updating/testing against 0.4.x release. Thank you for your patience.

See https://github.com/solidjs/solid-start/pull/1139 for more details.


Convert ActiveRecord attribute name from underscore to camelCase

Underscore naming convention is popular standard for table and column naming. Generated AR attributes use underscore naming convention too. It's contrary framework code style, contrary corporative code style.
To avoid mistakes, names conversion will work only for ActiveRecord attributes. Names conversion is very simple action does not affect performance. Conversion turn on by switcher, by default off.

It's not as simple as it seems. Especially when it comes to queries and the fact that you should use field_name in conditions and fieldName when accessing properties.

Yes, therefore It only for attributes: insert, update, access to attributes.

we have discussed this before and it is confusing if attributes are named different in insert, update than in query.
see #6760, #7136

It's not required feature. This will be useful someone.

Omg this is really annoying and kinda a deal breaker for us.... Why not just give an option to use camelCase ?
This greatly increases code consistency, Hundreds of devs wish for this feature and your reason to not do it is because it is "confusing"?
Thinking of switching to Laravel because of this or enhancing ur implementation....
Kinda disappointed

@j3rrey it's not as simple as it looks as I've already pointed out https://github.com/yiisoft/yii2/issues/9409#issuecomment-130868475.
If you have a plan for a complete solution which isn't too complex and solves the two-way mapping, it would be great.

I will give it a shot and come back later to this issue, and yes I've read all the issues and your answers

Looking forward to it.

Thinking of switching to Laravel because of this or enhancing ur implementation....

I am not aware of laravel supporting this feature, can you point me to the docs or implementation?

Hey hey, so I don't have the time to enhance ur current implementation.... also ur comment about it's confusing kinda was a deal breaker to further use ur framework.
We will switch.
@cebe It's all here in the eloquent documentation https://laravel.com/docs/5.4/eloquent

It's all here in the eloquent documentation https://laravel.com/docs/5.4/eloquent

Where do you see automatic conversion of attributes names in eloquent? Even in docs they use snake_case for attributes names:
$user = App\User::find(1);

$firstName = $user->first_name;

I also can not find it. I'm not even sure if this is supported at all in current Laravel version, see some old tickets:

https://github.com/laravel/framework/issues/316
https://github.com/laravel/internals/issues/41

It was implemented in Doctrine like ages ago.

Well yes, there is naming strategy there.

I'm sure it was somewhere in the documentation maybe a bit hidden.
What I've just found are packages that do provide it for Laravel.
Either way in this issue Taylor said he is fine with it not sure if he meant the created_at and updated_at attributes.
https://github.com/jarektkaczyk/eloquence/wiki/Mappable
https://github.com/jarektkaczyk/eloquence
Checking the code later today:
https://laravel.com/api/5.4/Illuminate/Database/Eloquent/Model.html
https://github.com/laravel/framework/blob/5.4/src/Illuminate/Database/Eloquent/Model.php

@j3rrey this feature was deprecated in Laravel.

This can be realized by gii generating. Add getters/setters in class body.
<?php foreach ($tableSchema->columns as $column): ?>
<?php
    $camelCaseName = Inflector::camelize($column->name);
    $variableName = Inflector::variablize($column->name); ?>
    /**
    * @return <?= $column->phpType . "\n"; ?>
    */
    public function get<?= $camelCaseName; ?>()
    {
        return $this->getAttribute('<?= $column->name; ?>');
    }

    /**
    * @param <?= $column->phpType . ' $' . $variableName. "\n"; ?>
    */
    public function set<?= $camelCaseName; ?>($<?= $variableName; ?>)
    {
        $this->setAttribute('<?= $column->name; ?>', $<?= $variableName; ?>);
    }
<?php endforeach; ?>

@zetamen Also you can add
@property $columnNameCamelCase
at the class definition for autocomplete on IDEs

So camel naming is supported now? Thanks!~


Add codecov.io support

Description
Implement support for codecov.io (free service for collecting test coverage results).
Related information
codecov.io is a free service that integrates with Github, and it provides a way to collect test coverage results and publish it to their service; this gives you a 'badge' you can add to the repository's README to make it easy to see how well a library's code is covered by it's test suite.
An example integration for a C# project can be found at:
https://github.com/codecov/example-csharp

Closing old suggestions (please send a PR if you want it)

This was a great suggestion, my apologies for closing it.

Even if the maintainers do not want this, I would merge it into my fork.


V2 Pushed to Market - data polling from controllers

I am just about to push the V2 version.  If you have 'auto update' turned on you should see a notification.
This release turns on the polling every x mins.  Currently only for a single controller.  Currently does not prune old data.
Use the DB Maintenance icon (the star) to view complete listing of controllers, probes and probe data.
Next release will turn on the daily cleanup script which will prune data older than y and fill in any missing data with full resolution 5-min interval data that is available from the controller.

Oh, it is really V3.  I am going to start using the actual app version so you may see caps in version numbers in these issues.
My goal will be to let the app run for a while to make sure there are no issues that creep up after it has been running for a while.  Success would be seeing no crashes and the data builds at x min intervals except when the phone is sleeping.
The data display only shows probe data now not outlets but that is just a small code change.

Is there any way to view/modify the preferences information once entered?    (A de-reinstall corrected)
An enhancement idea; allow for probe order to be user modified.
Testing results on v0.05;
I am able to see all 7 of my probes and their data while using internet on droid2 v2.3.3 and galaxyS v2.2.  I will verify wifi intra-subnet access tonight.
The 2 phones react slightly different.
galaxyS v2.2; I used 5 min interval. The first data poll and the first update worked as expected.  A second update poll does not occur, until  I exit and kill the app using Adv Task killer.  Then I reopen. The poll happens when the app is restarted and the next interval update works as expected. Again, a second update does not occur. Similarly a close and task kill restart the polling. Any time I kill the task after the current minute has incremented, a new poll appears in the DB.
Droid2 v2.3.3; I used 5 min interval. The first data poll and the first update worked as expected.  A second update poll does not occur, until  I exit and kill the app using Adv Task killer.  Then I reopen. The poll happens when the app is restarted but the next interval update does not happen. Similarly a close and task kill restart the polling. Any time I kill the task after the current minute has incremented, a new poll appears in the DB.
I will let both phones sit through the day and see if the polling restarts on its own.


I've successfully added the new Stay connected portion along with a perfect email box so that the reader gets understood what it is actually and can register there by writing their email

Related Issue
[Cite any related issue(s) this pull request addresses. If none, simply state “None”]
Fixes:  #(issue no.)
Description
[Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.]

Type of PR

[ ] Bug fix
[ ] Feature enhancement
[ ] Documentation update
[ ] Other (specify): _______________

Screenshots / videos (if applicable)
[Attach any relevant screenshots or videos demonstrating the changes. Make sure to attach before & after screenshots in your PR.]
Checklist:

[ ] I have made this change from my own.
[ ] I have taken help from some online resources.
[ ] My code follows the style guidelines of this project.
[ ] I have performed a self-review of my own code.
[ ] I have commented my code, particularly in hard-to-understand areas.
[ ] I have made corresponding changes to the documentation.
[ ] My changes generate no new warnings.
[ ] I have tested the changes thoroughly before submitting this pull request.
[ ] I have provided relevant issue numbers and screenshots after making the changes.

@anuragverma108


Qa

Coverage decreased (-0.05%) to 85.841% when pulling 641367d581264545dc6873cb9af550997e135aec on qa into e23a78dc20c55d9df21e28262e02c0d24f658fd5 on master.

Coverage decreased (-0.05%) to 85.841% when pulling 641367d581264545dc6873cb9af550997e135aec on qa into e23a78dc20c55d9df21e28262e02c0d24f658fd5 on master.


Latest install.sh seems broken

I'm talking about these two lines:
https://github.com/silvanmelchior/RPi_Cam_Web_Interface/blob/master/install.sh#L240
https://github.com/silvanmelchior/RPi_Cam_Web_Interface/blob/master/install.sh#L242
For some reason I get these lines in my /etc/motion/motion.conf:
on_event_start echo -n '1' >/var/www/html/html/FIFO1
on_event_end echo -n '0' >/var/www/html/html/FIFO1

Which are obviously broken, because the FIFO1 file is at /var/www/html/FIFO1.

Upon further investigation, it seems to be also caused by https://github.com/silvanmelchior/RPi_Cam_Web_Interface/blob/master/install.sh#L253

A quick blame in suggests that this commit caused the breakage: https://github.com/silvanmelchior/RPi_Cam_Web_Interface/commit/aeb5ccb52655d6b127b0011c1617a95876ad37a3

Line 253 probably should have been removed after the fix in aeb5ccb

Thanks for finding that.
The line should have been removed after that original change.
Change now made.

Closing this since it's fixed in https://github.com/silvanmelchior/RPi_Cam_Web_Interface/commit/84b328cafb217883a93a69b6aec3c5deb60d1c84.


Hierarchical vs P2P registry support

Decide which way to go and add support. More info.

CanDIG definitely needs P2P


Feature/#docker file

Changes:
Updated the DockerFile with multistage docker build which produces low-sized docker images and only builds linux distribution-based executable.
Tests:
Manually tested by running docker and connecting it via redis-cli and tested basic commands.
BUILD Image: docker build -t image_name .
RUN Command: docker run -p 7379:7379  image_name

Hello Mihir,
Thanks for raising the PR. A dockerfile has already been added to the repository. Ref: https://github.com/DiceDB/dice/blob/master/Dockerfile
Hence. closing the PR. If you think we can do better with the existing Dockerfile, do raise a PR happy to incorporate the changes.


Are there evaluations of detections on images and mAP on wandblogger?

I cannot find tutorials or if mmdetection produces results of images with annotations when evaluating while training as well as mAP metric.

We use eval hook if you want to validate the result while training. The hook's main code is in MMCV, you can find evaluate code in mmdet/core/evalation/eval_hooks.py

We use eval hook if you want to validate the result while training. The hook's main code is in MMCV, you can find evaluate code in mmdet/core/evalation/eval_hooks.py

We use eval hook if you want to validate the result while training. The hook's main code is in MMCV/runner/hooks/evaluation.py, you can find evaluate code in mmdet/core/evalation/eval_hooks.py

Is it automatically providing images with detections?


Patch NetUtils so it will use hostname if it exists

In some environments we have Docker containers where we have internal
IP addresses (e.g. 172.x.x.x) that are only valid inside the container.
This change makes sure that we use hostname instead of theses addresses
when possible.
Please review only.

Good point @hakonhall , I will make a new PR

Good point @hakonhall , I will make a new PR

Replaced by https://github.com/vespa-engine/vespa/pull/16052

Replaced by https://github.com/vespa-engine/vespa/pull/16052


404 page in docs: http://tryshoppe.com/docs/paypal

I get a 404 error when I try to access:
http://tryshoppe.com/docs/paypal
This also happens when I try to access the Stripe docs.

Where did you find this link? The correct link is http://tryshoppe.com/docs/payment-gateways/paypal