Added allSatisfy for Iterable / array (#711)

Check List:

Fixes #711
Unit tests : YES
Javadoc with a code example (API only) : YES

Just had to fix the tests that was using satisfies instead of  allSatisfy ;-) but neat work otherwise, thanks !
https://github.com/joel-costigliola/assertj-core/pull/722/files#diff-27b4987a668cf4535480fbc753363884R64

oh, thank you


Generate 3D conformers in documentation

📖 Documentation
Hello!
Thanks for a great and very useful library. I am a bit confused with the documentation of the featurizers that require 3D information. In the documentation, we find something like this:
import datamol as dm
from molfeat.trans.fp import FPVecTransformer
smiles = dm.freesolv().iloc[:100].smiles
# sanitize and standardize your molecules if needed
# <generate 3D coordinates here>
transformer = FPVecTransformer(kind='usrcat', dtype=float)
features = transformer(smiles)

I do not understant what should we do in place of <generate 3D coordinates here>. The input of transformer is anyways a list of SMILES, so why should we be generating 3D coordinates before? Are these 3D coordinates being generated as part of the internal procedure of the transformer, or should we generate them separately?
Thanks so much in advance!

@miquelduranfrigola I was also confused recently and found this to work:
import datamol as dm
from rdkit.Chem import AllChem
from molfeat.trans.fp import FPVecTransformer
smiles = dm.freesolv().iloc[:100].smiles

# Convert SMILES to molecules and generate 3D coordinates
mols = [dm.to_mol(s, add_hs=True) for s in smiles]
mols_3d = []
for mol in mols:
    AllChem.EmbedMolecule(mol)
    mols_3d.append(mol)

transformer = FPVecTransformer(kind='usrcat', dtype=float)
features = transformer(mols_3d)

would be great to double check with the maintainers that this is the intended way to interface with this transformer and if so the documentation should be updated.

Hi @miquelduranfrigola, thanks for reporting this.  It's is a typo in the doc.  It should read:

smiles = dm.freesolv().iloc[:100].smiles
smiles = dm.freesolv().iloc[:100].smiles
# sanitize and standardize your molecules if needed
# <generate 3D coordinates here>

transformer = FPVecTransformer(kind='usrcat', dtype=float)
# molecules_with_3D contains the list of molecules with 3D data you have generated <--
features = transformer(molecules_with_3D)

The Transformers accept both SMILES and RDKit Mol objects as input.  We have chosen to not compute the conformers on the fly for descriptors that require it, because the conformer variant you use will impact the representation. We therefore want that to be intentional by the user (there is a decorator that checks if you are providing molecules with 3D coordinates for USR and other shape descriptors and raise an error accordingly).
@kkovary provided a nice example of how to compute the 3D coordinates. Again, think carefully about which conformer would make sense for your task (the one with minimal energy ? a random one ? the bioactive one ? one coming from a docking experiment ? etc)
You can also use datamol to compute the conformers:
import datamol as dm
from molfeat.trans.fp import FPVecTransformer

smiles = dm.freesolv().iloc[:50].smiles
# sanitize and standardize your molecules if needed

# <generate 3D coordinates here>
mols = [dm.to_mol(s) for s in smiles]
molecules_with_3D = [dm.conformers.generate(m, n_confs=1, minimize_energy=True) for m in mols]

transformer = FPVecTransformer(kind='usrcat', dtype=float)
features = transformer(molecules_with_3D)

If you are reading molecules from SDF with 3D coordinate info available, then you can use the molecules directly as input.
import datamol as dm
from molfeat.trans.fp import FPVecTransformer
# we are reading from an SDF that contains the 3D coordinates already
molecules_with_3D = dm.read_sdf("https://raw.githubusercontent.com/datamol-io/datamol/main/datamol/data/cdk2.sdf")
features = transformer(molecules_with_3D)

@maclandrol Type fixed in the doc: https://molfeat.datamol.io/featurizers/usrcat

Thank you all! Very useful


Array order (C/Fortran) is sometimes misinterpreted when using mmapped arrays

I have this code:
@numba.njit(nogil=True)
def std_2d_mask(array, mean, mask):
    """Input array is 2D, plus column-wise mean (1D) and mask (1D).
    Returns column-wise standard deviation.
    Same as array[mask].std(0), but ~10x faster.
    """
    assert array.ndim == 2
    length, width = array.shape
    assert length > 0 and len(mask) == length

    count = 0
    variance = np.zeros(width)  # result is always float

    for row in range(length):
        if not mask[row]:
            continue
        count += 1
        for col in range(width):
            diff = array[row, col] - mean[col]
            variance[col] += diff * diff

    return np.sqrt(variance / count)

This mostly works, but I have one case where there appears to be non-deterministic misinterpretation of Fortran vs C ordering of the input array.  I have only noticed it when the array is loaded using np.load(mmap_mode='r').  Unfortunately the array that reproduces the problem is huge, so I cannot post it online, but the dtypes and shapes in the mmapped "npy" files are:
array: 'descr': '<f8', 'fortran_order': True, 'shape': (143731939, 76)
mean: 'descr': '<f8', 'fortran_order': False, 'shape': (76,)
mask: 'descr': '|b1', 'fortran_order': False, 'shape': (143731939,)

The program is multithreaded (hence nogil=True).  When it gives the wrong result, it's as if the input array were transposed (i.e. as if Numba thinks it is order='C', but it is not).
I have order='F' mostly because that's the default in Pandas (i.e. what you usually get from DataFrame.values).
I do not know where the bug lies, but I would appreciate advice on how to diagnose and perhaps solve it.
The problem exists with Numba 0.34, 0.35, and 0.37, using NumPy 1.13.1, Python 3.5, on 64-bit Linux.

This is a guess...
Given the program is multi-threaded (I assume threads and not processes), I would take a look at which function signatures get compiled first . It may be that a signature that is quite broad and will accept (with promotion) a lot of narrower types is compiled ahead of other more specific versions, in which case it will be used! This may be the root cause of the non-deterministic behaviour. If you look at std_2d_mask.signatures it will show the order in which they were compiled. Numba is aware of C/F order and it is captured in the signature at compile time.
I would also check that the np.read is producing precisely what is expected, including what happens when a slice is made and how Numba then interprets this input.
Hope this helps.

The problem persists in Numba 0.39.

Thanks. Did you try out any of the suggestions above? Also, I wonder if this is related to https://github.com/numba/numba/pull/2950 and it's actually the alignment that's throwing the dispatcher off.

@jzwinck thanks for getting back to us on this. What you describe is suspiciously similar to https://github.com/numba/numba/issues/2937 and the WIP fix for it in #2950 (if you are confident building Numba from source, perhaps patch in the change to numba/_typeof.c and give it a go?).
Might also be worth looking at the ndarray.flags for your mmap'd data to see if any of it has ALIGNED: False, which I think could possibly trigger a similar situation to #2937 under certain signature registration sequences.
You might find numba.typeof() useful for seeing what Numba thinks your data types are. Also, if you want to create explicit signatures then numba.types is a quick way to do this, e.g.
In [39]: numba.types.float64[1::, ::1]
Out[39]: array(float64, 2d, C)

In [40]: numba.types.float64[::1, ::1]
Out[40]: array(float64, 2d, F)

In [41]: numba.types.float64[1::, 1::]
Out[41]: array(float64, 2d, A)

signatures can be composed of these objects or just written as strings, like:
@njit('float64[1::, 1::](float64[1::, 1::],float64[1::, 1::])')
def foo(a, b):
    return a + b

gives foo.signatures : [(array(float64, 2d, A), array(float64, 2d, A))].
If you can create a reproducer for the problem you are seeing then please share it and we'll take a look. Thanks.

The code below reproduces the bug mentioned above:
import numpy as np
import numba

@numba.njit(nogil=True)
def std_2d(array, mean):
    """Input array is 2D, plus column-wise mean (1D)
    Returns column-wise standard deviation.
    Same as array.std(0)
    """
    assert array.ndim == 2
    length, width = array.shape

    variance = np.zeros(width)  # result is always float

    for row in range(length):
        for col in range(width):
            diff = array[row, col] - mean[col]
            variance[col] += diff * diff

    return np.sqrt(variance / length)

# Generate a 100 x 20 numpy array where each column is assigned as
# a float of column number x 1000 (1000 is there only to amplify
# the difference)
gen_arr = np.empty((100, 20))
for col in range(20):
    gen_arr[:, col] = np.full(100, col * 1000)

# Save the generated array into file in fortran order
gen_arr = np.asfortranarray(gen_arr)
np.save('arr_file', gen_arr)

times = 10
for rd in range(times):
    # Load array from file with mmap_mode='r'
    loaded_arr = np.load('arr_file.npy', mmap_mode='r')

    if (rd % 2 == 0):
        # Note that slicing by full column maintains fortran order of the data
        arr_to_cal  = loaded_arr[:, 10:12]
    else:
        # Slicing a portion of the data in the way below creates a c order array
        # due to some implicit mechanisms
        arr_to_cal  = loaded_arr[10:90, 10:12]

    mean = np.mean(arr_to_cal, axis=0) # Column-wise mean as required by std_2d function
    expected = arr_to_cal.std(0) # This should give 0 as the whole column value is the same
    actual = std_2d(arr_to_cal, mean)

    # This prints the storage order of the array
    print('Round:', rd, ' Array Order:','Fortran' if np.isfortran(arr_to_cal) else 'C')

    # Reports error if actual sd calculated from std_2d is non-zero
    assert (actual < 0.001).all()

On numba version 0.40 it still produces assertion error.
However, the problem does not persist for numba version 0.41 onwards.

Fixed in 0.41, most likely by #2950.

@jzwinck Thanks for confirming the fix, much appreciated.


Cannot read property 'values' of undefined"

Hi Ben,
New error popped - never saw it before:
ERRO[0003] handleSummary() failed with error "TypeError: ejs:301
    299|
Virtual Users

    300|
 >> 301|

Min

<%= data.metrics.vus.values.min %>

    302|

Max

<%= data.metrics.vus.values.max %>

    303|

    304|

Cannot read property 'values' of undefined", falling back to the default summary  source=console

I don't have a clue why ... because other test suites with setup and teardown functions - the htmlSummary working great.

Maybe something with the options ? but the same options works in other tests:
export const globalOptions = {
  setupTimeout: "5m",
  scenarios: {
    default: {
      executor: "per-vu-iterations",
      vus: 1,
      iterations: 1,
      maxDuration: "1h",
    },
  },
  thresholds: {
    "http_req_duration{scenario:default}": [`max>=0`],
    "http_req_sending{scenario:default}": [`max>=0`],
    "http_req_waiting{scenario:default}": [`max>=0`],
    "http_req_receiving{scenario:default}": [`max>=0`],
  },
  summaryTrendStats: ["min", "avg", "max", "p(90)", "p(95)"],
};

Hi!
I was having the same error, and fixed it by adding a sleep(1); after each check.
Mi guess is that there is a race condition if you dont sleep, but im not sure.
I hope this helps you :)

Hi, I had already a sleep of 0.1, but changing to sleep(1) worked for some reason...
guess its something that can be fixed in the source code.

Hi,I am using 5 vus and 1 iteration ,when using sleep(1) it is working fine but average response duration increases by 1 sec like 1.54 sec but when using i am using without sleep html report error but response duration is in ms.can you please help in attaining response duration in millisecond with html report working or is there any alternative to skip sleep and get response without sleep time.Thanks.


Remote debug (ssh) Fails to attach and debug any processes

Issue Type: Bug
Using:-
Visual Studio Code 1.47.1
Native Debug 0.25.0
CentOS Linux release 7.7.1908
gdb attaches to a Linux process OK and the symbols are loaded but then an error is reported... "Could not continue: The program is not being run. (from exec-continue)
Also on the CALL STACK tab there is an error PAUSED ON EXCEPTION. The process does not have a bug and runs without any issues outside of the debugger. My debug launch settings are:
{
	...
			"type": "gdb",
			"request": "attach",
			"name": "Attach to PID",
                        "target": "5327",
			"cwd": "/home/xxxx/bin",
			"valuesFormatting": "parseText",
			"ssh": {
				"host": "xx.xxxx.xx",
				"cwd": "/home/xxxxx",
				"user": "xxxxx",

			},
		}

	]
}

Thanks WebFreak001 for the suggestion, the following extra details were generated, the most significant looks like
"Not implemented stop reason (assuming exception): undefined":-
GDB -> App: {"outOfBandRecord":[{"isStream":true,"type":"console","content":"Loaded symbols for /lib64/libfreebl3.so\n"}]}
Loaded symbols for /lib64/libfreebl3.so
GDB -> App: {"outOfBandRecord":[{"isStream":false,"type":"exec","asyncClass":"stopped","output":[["frame",[["addr","0x00007f8e2f7ee087"],["func","semop"],["args",[]],["from","/lib64/libc.so.6"]]],["thread-id","1"],["stopped-threads","all"],["core","0"]]}]}
Not implemented stop reason (assuming exception): undefined
5-thread-info
Replaced the hard coded process id in the target attribute with:-
  "target": "${command:PickProcess}",

but this generated :-  PickProcess not found

Try enabling debug output ("showDevDebugOutput": true, "printCalls": true) and check the logs inside the debug console

This exception should have been gone in one of the previous releases. You possibly want to add sourceFileMap entries if the code does not reside on the same place on your machine/ssh one. To actually stop somewhere you'd want to set a breakpoint in the IDE and/or configure stopAtEntry.
Therefore I'm closing this - but if you still see this issue: please report and we reopen.
Side note: There is no general available "pick process", so for now either use a hardcoded value, or (commonly more reasonable) an input parameter - which then possibly provides you with a list, too. My personal workaround: I've created a tasks that list all processes I'm potentially interested in (limited to my user and some project specific options), which I run before debugging to get the PID.


Transient error "native provider reuse budget has been exceeded"

What happened?
We have seen many transient errors like below
│     message: 'observe failed: cannot schedule a native provider during observe: e2eb787b-fd7f-4297-8110-fa8a64f45146:       │
│       cannot schedule native Terraform provider process: native provider reuse budget                                       │
│       has been exceeded: invocationCount: 112, ttl: 100'

When this error happened, the Synced status of the related managed resource became unready.
It could last a couple of minutes for a managed resource, and then the resource would be recovered from the state.
This error makes our tests very flaky, and also causes much confusion for our users.
How can we reproduce it?

I am not really sure how to consistently reproduce this issue since the issue is transient.
What environment did it happen in?

Crossplane Version: 1.12.0
Provider Version: v0.33.0
Kubernetes Version: v1.24.14
Kubernetes Distribution: GKE

@ZhiminXiang version v0.35.0 of the provider was built with improvements to Upjet that address this error. Could you upgrade your provider and let us know if this is still a problem for you?

We saw some errors similar to this when we upgraded to v0.35.0, but for us they weren't transient; the provider got completely stuck until we restarted it.
I've created https://github.com/upbound/upjet/pull/261 to add a little bit of extra logging, as I suspect the inUse count is somehow not getting decremented in some situations.

Started to observe this error suddenly as well xpkg.upbound.io/upbound/provider-gcp:v0.38.1
CannotObserveExternalResource
cannot schedule a native provider during observe: 5e656f02-149c-4ff5-9009-dc82b0c91b18: cannot schedule native Terraform provider process: native provider reuse budget has been exceeded: invocationCount: 120, ttl: 100

Could you upgrade to v0.40.0 or later? The new non-forking architecture mostly solves this I think

Still observing. Thinks cooled down and I had notice that sqladmin api went quota missing due to i believe a wrong project on database resource.
I can surely give v0.41.1 a try. But right now want to observe things a bit as I've never observed this error before changing to pipelines.


restinio: init 0.6.13

Motivation for this change
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
21.11 Release Notes (or backporting 21.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

This is a header-only lib so I only download and unpack it. However, some deps are needed when using it. Should I add them? How can I do that?

Result of nixpkgs-review pr 140439 at 9feca2cd run on aarch64-linux 1

1 package built successfully:

restinio

1 suggestion:

warning: unused-argument
Unused argument: stdenv.
Near pkgs/development/libraries/restinio/default.nix:1:3:
  |
1 | { stdenv, lib, fetchzip }:
  |   ^


Try out MSAL-node based Microsoft auth

Refs: https://github.com/microsoft/vscode/issues/178740

[ ] macOS @aiday-mar
[x] linux @rzhao271
[x] windows @andreamah

Complexity: 5
Create Issue

This iteration, we've essentially completely rewritten the Microsoft auth extension using https://github.com/AzureAD/microsoft-authentication-library-for-js which is the recommended way to interact with Microsoft identity APIs and allows us one day to use WAM to get auth state from the OS.
I'd love for you to give this new auth provider a spin.

You can certainly write your own little extension and interact with our auth APIs like:
vscode.authentication.getSession('microsoft', scopes, options);

Or you can use my Fugio extension to do more or less the same thing but via a quick pick form.

Definitions

AuthenticationSessionAccountInformation: An account. An account can be associated with many sessions
AuthenticationSession: A session that contains an access token that has certain scopes
Scopes: these are the permissions that you want to have
JWT: The Access Token in the session is a JSON Web Token. You can paste the access token into http://jwt.io to see the information contained by it

Testing

Different values of scopes:

profile - returns a basic session with just some profile info
Mail.ReadWrite - returns a session that could be used to read or write your email (API)
VSCODE_CLIENT_ID:a4fd7674-4ebd-4dbc-831c-338314dd459e, VSCODE_TENANT:common, profile - Put all of these. These VSCODE_ scopes are "special" scopes that we don't pass along with the scopes themselves but rather use these to override the app that is used. VS Code ships with a default client id and tenant, which extension authors can use, but if that doesn't meet their needs, they can create their own Entra App and override it this way. I've created a backup Entra App for you. Keep in mind, it may not work with Corp accounts, Personal Microsoft accounts work better.

Feel free to play with other values of scopes. Keep in mind, not every set of scopes will work because our app is only suppose to have the minimum scopes authorized to function... but if you hit this case (it complaining about pre-authorization) the error message should be surfaced to you nicely.

General flow stuff

Sign in - did it work?
Sign out - did it work?
Sign in again - did it work?
Wait a long time - are you still logged in?
reload the window - are you still logged in?

Real world examples

Use Settings Sync with Microsoft
Use the Azure Resources extension

It's... a weird topic so feel free to message me if you have any questions. I'll be in Germany during testing, but will try to respond to questions.

Hi I am currently trying to test this TPI and am a bit confused as to what to do. I installed the Fugio extension. I noticed from the command palette, there are the commands Fugio : Inspect Accounts and Fugio : Mint Token. From your description I suppose that clicking on Fugio : Inspect Accounts or Fugio : Mint Token should open a form view. This does not happen on my VS Code insiders instance. I was wondering if I am missing something to test correctly?
https://github.com/user-attachments/assets/ce388d97-2be0-4c6c-81f3-bcdf0964833a

I did the same as Andrea with settings sync and the azure resources extension. I read the filed issues to understand better the steps. Generally signed in and signed out, tried reloading and changing the scopes of the tokens. It seems to work.


pull request for e2e test at 01/15/2017 08:56:12

:white_check_mark: Validation status: passed
For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


feat: impl put_multipart in object_store

close: #4748

@Xuanwo hi, have a moment to review?

I attempted to address this issue through OpenDAL's API design but ultimately found it unfeasible, so I implemented a workaround using task notifications instead. The concurrent writing occurs within OpenDAL itself, so the lock here isn't a major concern.

Thanks for @Xuanwo


multiple initial seed URLs

Dear developers, I have multiple initial URLs to crawl. Instead of following deeper into each of them, I only need the page content. Now what I did is to close the context in the OnNewState Plugin, and restart a new builder of a new URL in the main loop. I think this is a common situation, but I can't find any info on the web. Is there any clever way to do this?  It waste too much time every time configuring a new builder.
my code is something like:
while(URL list is not empty) {
CrawljaxConfigurationBuilder builder = CrawljaxConfiguration
.builderFor( a new URL);
CrawljaxRunner crawljax = new CrawljaxRunner(builder.build());
crawljax.call();
}
onNewState(CrawlerContext context, StateVertex newState) {
context.stop();
// do some computation here
}
Thanks.

My situation is a little similar to issue #93 , did you solve that one?


CAMEL-20281 - Camel-AWS Components: Make it possible to use AwsSessio…

…nCredentials to support temporary credentials - AWS EC2
Description

Target

[x] I checked that the commit is targeting the correct branch (note that Camel 3 uses camel-3.x, whereas Camel 4 uses the main branch)

Tracking

[x] If this is a large change, bug fix, or code improvement, I checked there is a JIRA issue filed for the change (usually before you start working on it).

Apache Camel coding standards and style

[x] I checked that each commit in the pull request has a meaningful subject line and body.

[x] I have run mvn clean install -DskipTests locally and I have committed all auto-generated changes

/component-test aws


Set an "incident_key" on PagerDuty incidents to avoid duplication

Right now every alert that notifies PagerDuty will generate a new incident every time it fires. This is extremely annoying. Instead, a non-unique incident key, containing the name of the alert, should be specified when the event is triggered so that PD knows that the new alert is part of the same incident.

@eherot Check out the es-5x branch to test this out (Note the updated setup instructions https://github.com/etsy/411/blob/es-5.x/docs/Setup.md#install)


Snark pool rebroadcast if relevant

Closing. The work for this PR is being transferred into another branch, fix/snark-pool-rebroadcast


flutter doctor has no colors when run in tmux

Steps to reproduce

Have a terminal with color support
Open tmux
Make sure colors actually work
Run flutter doctor (TERM is tmux-256color). => See no colors
Run TERM=xterm-256color flutter doctor. => See color

Actual results
Output is not coloured.
Logs

Logs

<!-- Paste your logs here -->

Flutter Doctor output

Doctor output

flutter doctor -v
[✓] Flutter (Channel stable, 3.16.9, on Fedora Linux 39 (Workstation Edition) 6.6.14-200.fc39.x86_64, locale de_DE.UTF-8)
    • Flutter version 3.16.9 on channel stable at /home/user/.local/opt/flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 41456452f2 (vor 9 Tagen), 2024-01-25 10:06:23 -0800
    • Engine revision f40e976bed
    • Dart version 3.2.6
    • DevTools version 2.28.5

[✗] Android toolchain - develop for Android devices
    ✗ Unable to locate Android SDK.
      Install Android Studio from: https://developer.android.com/studio/index.html
      On first launch it will assist you in installing the Android SDK components.
      (or visit https://flutter.dev/docs/get-started/install/linux#android-setup for detailed instructions).
      If the Android SDK has been installed to a custom location, please use
      `flutter config --android-sdk` to update to that location.

[✗] Chrome - develop for the web (Cannot find Chrome executable at google-chrome)
    ! Cannot find Chrome. Try setting CHROME_EXECUTABLE to a Chrome executable.

[✓] Linux toolchain - develop for Linux desktop
    • clang version 17.0.6 (Fedora 17.0.6-1.fc39)
    • cmake version 3.27.7
    • ninja version 1.11.1
    • pkg-config version 1.9.5

[!] Android Studio (not installed)
    • Android Studio not found; download from https://developer.android.com/studio/index.html
      (or visit https://flutter.dev/docs/get-started/install/linux#android-setup for detailed instructions).

[✓] Connected device (1 available)
    • Linux (desktop) • linux • linux-x64 • Fedora Linux 39 (Workstation Edition) 6.6.14-200.fc39.x86_64

[✓] Network resources
    • All expected network resources are available.

! Doctor found issues in 3 categories.

Hi @rusty-snake

flutter doctor has no colors

Do you mean the symbol's color? Not sure if I configured this correctly but I still can see they have color here from tmux:

Exactly, but I don't have colors.
What's the $TERM value for you? Inside tmux it must be "screen", "tmux" or similar (such as "tmux-256color"). Where TERM=screen has colors but TERM=tmux/TERM=tmux-256color don't have colors.

Here are my outputs inside and outside tmux (all have color)

Inside tmux:

Outside tmux:

But if I run TERM=tmux-256color flutter doctor, there is no color:

Is this the case you are reporting?

Is this the case you are reporting?

Yes.


Pinned Repository Selection/Deselection Broken in Firefox

Maybe related to #1301.
Changes in the "Customize Your Pinned Repositories" menu aren't reflected on GitHub.
Steps to reproduce:

Open Firefox Quantum 59.0.2 (64-bit)
Navigate to github.com/username
Click "Customize Pinned Repositories"
Select/Deselect any repository.
Close the window

@alichtman Why is the this #1301?

@yakov116, I think they're separate issues.
This relates to changes made in the selection menu not being applied, whereas #1301 relates to the scrolling being broken for the selection menu.

Maybe a clearer title would be better. Maybe like: "Pinned Repository Selection/Deselection not Saving in Firefox" or something.

That’s not a Refined GitHub feature. Is RGH breaking a native GitHub feature?

@bfred-it That is what it seems like.

@bfred-it Yes. RGH breaks this native GitHub feature.

I tested. Cannot reproduce. Make sure you're clicking "Save pinned repositories"
If it still does not work, check the console.

Tried this again today and also can not reproduce.
Potentially fixed by any of the 4 commits made today.


Preventing unloading of modules on lazy loading other modules

Is there any way to prevent unloading of modules on lazy loading other modules??
(means earlier views(of modules) must be there along with currently loading views(of modules))
[if anyone thinking about i can use oultlet's but in that also it will unload the modules and lazy load the modules in respective Outlet, i don't need this. i need both should be there..]
i haven't found anything like this in angular documents.
@angular-cli team,
if it is not yet implemented, then this will be a great feature.
please let me know if any..

Hello, we reviewed this issue and determined that it doesn't fall into the bug report or feature request category. This issue tracker is not suitable for support requests, please repost your issue on StackOverflow using tag angular-cli.
If you are wondering why we don't resolve support issues via the issue tracker, please check out this explanation.


fix: parse method mutating its input

fixes: #230

/cc @lholmquist  @lance

@lance I force pushed it. There is now only one line changed: const incoming = { ...parser.parse(payload) };.


Error in logging???

Actual Behavior
Errors happened in logger.
To Reproduce
** Environment Details **

NanoMQ version
Operating system and version
Compiler and language used
testing scenario

Client SDK
Additional context

The PR https://github.com/nanomq/NanoNNG/pull/489 has fixed it


Extension causes high cpu load

Issue Type: Performance
Extension Name: vs-code-prettier-eslint
Extension Version: 5.0.4
OS Version: Windows_NT x64 10.0.19042
VS Code version: 1.71.2

:warning: Make sure to attach this file from your home-directory:
:warning:file:///c%3A/Users/MOHAME~1/AppData/Local/Temp/rvest.vs-code-prettier-eslint-unresponsive.cpuprofile.txt
Find more details here: https://github.com/microsoft/vscode/wiki/Explain-extension-causes-high-cpu-load

@Metwesh I'm assuming since you are on Windows NT that you are using an older computer. There is a known performance issue with quad-core processors that I cannot remedy.  The slowness comes from the prettier-eslint package the extension uses.


Migrations

Wondering what the design story is for migrations.
So when the DB is at v1 on the client, and then you change some code relating to the DB and redeploy the app to v2, you want at runtime on the client to detect the db is at V1 and run some Database migration code.
A quick search brings up this for example: https://github.com/pressly/goose

Our goal is to have Genji be compatible with migrations tools like these

Ok thanks..  Will close for now, as this is clearly not a bug at all, but more just a future thing anyone can do.

Thank you @gedw99, if you have any question you can join the Genji Slack chan on Gophers Slack


wrong display of values of languages

as admin, when looking for details in the application form, this value is not having spaces, please separate with comma all the values

ok


Mocking MediatR  with Moq

Here is my code :
public sealed class BulkAddStockConditionItemCommandHandler : IRequestHandler<BulkAddStockConditionItemCommand,
    UserStockConditionSetsEntity>
{

    private readonly IMediator _mediator;

    public BulkAddStockConditionItemCommandHandler(IMediator mediator)
    {

        _mediator = mediator;

    }

    public async Task<UserStockConditionSetsEntity> Handle(BulkAddStockConditionItemCommand request,
        CancellationToken cancellationToken)
    {
        var conditionalRiskAgreements = new ConditionalRiskAgreementEntity(_userService.CustomerIsin);

        var addRes = await _mediator.Send(new AcceptConditionalRiskAgreementCommand(), cancellationToken);

        if (addRes == null) throw new Exception();

        //do do do
    }
}

As you can see I inject the IMediator into my constructor and I need the addRes not be NULL  in my unit test scenario, so here you can see my test scenario:
public async void BulkAddStockConditionItemCommand_when_StockConditionSet_is_null()
        {
            //arrange

            var condition = new ConditionalRiskAgreementEntity(RandomIsin);

            var mediator = new Mock<IMediator>();

            mediator.Setup(i => i.Send(It.IsAny<ConditionalRiskAgreementEntity>(), It.IsAny<System.Threading.CancellationToken>())).ReturnsAsync(Task.FromResult<object>(condition));

            BulkAddStockConditionItemCommand command = new BulkAddStockConditionItemCommand(data);
            BulkAddStockConditionItemCommandHandler handler = new BulkAddStockConditionItemCommandHandler(mediator.Object, userservice.Object, repoacc.Object, CacheableRepository.Object);

            //Act

            var caughtException = await Assert.ThrowsAsync<Exception>(() => handler.Handle(command, new System.Threading.CancellationToken()));
            //Assert
            Assert.IsType<Exception>(caughtException);

        }

I set up the IMediator as you can see but when I run the test it returns null instead of condition  variable.why?

Based on the shown code, the subject under test uses AcceptConditionalRiskAgreementCommand
//...

var addRes = await _mediator.Send(new AcceptConditionalRiskAgreementCommand(), cancellationToken);

//...

but in the test the mocked mediator is setup to expect ConditionalRiskAgreementEntity
//...

mediator.Setup(i => i.Send(It.IsAny<ConditionalRiskAgreementEntity>(), It.IsAny<System.Threading.CancellationToken>()))
    .ReturnsAsync(Task.FromResult<object>(condition));

//...

The mock will return null by default when the argument matchers do not match in the invoked member.
There is no need to return Task.FromResult<object>(condition) in ReturnsAsync since that will wrap whatever you pass in a Task
First I suggest you refactor the test to use async Task instead of async void and then update the mock to expect the actual argument types used in the subject under test.
public async Task BulkAddStockConditionItemCommand_when_StockConditionSet_is_null() {
    //Arrange
    var condition = new ConditionalRiskAgreementEntity(RandomIsin);

    var mediator = new Mock<IMediator>();

    mediator
        .Setup(i => i.Send(It.IsAny<AcceptConditionalRiskAgreementCommand>(), It.IsAny<System.Threading.CancellationToken>()))
        .ReturnsAsync(condition);

    BulkAddStockConditionItemCommand command = new BulkAddStockConditionItemCommand(data);
    BulkAddStockConditionItemCommandHandler handler = new BulkAddStockConditionItemCommandHandler(mediator.Object, userservice.Object, repoacc.Object, CacheableRepository.Object);

    //Act
    var caughtException = await Assert.ThrowsAsync<Exception>(() => handler.Handle(command, new System.Threading.CancellationToken()));

    //Assert
    Assert.IsType<Exception>(caughtException);
}


CircularProgress throws an error since theming was reworked

Description
Current implementation throw error themeHeight.slice is not a function
CodeSandbox/Snack link
https://snack.expo.dev/@swiftwork/17666d
Steps to reproduce
Lines CircularProgress.tsx#L41-L48 expect theme "space" to return a px based string but it actually returns a number.
NativeBase Version
3.4.25
Platform

[X] Android
[X] CRA
[X] Expo
[X] iOS
[X] Next

Other Platform
No response
Additional Information
No response

Hey @Swiftwork ,
Thanks for reporting. We will look into this.


Valido-React: DateTime picker onBlur not working correctly. Look into other alternatives.

The react demo is currently using YouCanBookMe/react-datetime as its DateTime picker.
Upon testing, I noticed the on Blur event was not firing on multiple occasions when I tabbed or clicked out.
Open to suggestions.

What test did you do here? onBlur seems to fire 100% of the time every time I click away from the DatePicker.
Code:
App.js
 <Datetime
    timeFormat={false}
    inputProps={{
      className: "form-control",
      id: "DateofBirth",
      name: "DateofBirth",
    }}
    onBlur={() => {
      console.log('blur! callback triggered');
    }}
 />

Before selecting a date:

After selecting a date:


Crashes with certain split files

splits_that_crash.zip

Thanks! I'll look into that

Issue was really easy to fix! It was basically crashing if the split name was empty.


2 apps in vertical split keep swapping from time to time

Not too familiar with configuring Yabai yet but can't fix my issue which is that I'd like my 2 apps on Desktop 1 (MacOs) to stay in a fixed order: Chrome on the left and Alacritty on the right. Same with Desktop 2: BearApp on the left and MS-Teams on the right. The issue is that sometimes the 2 apps on a Desktop swap places.
have a fairly simple setup: Macbook Air M1 connected to a LG 29" display, latest OS. A screenshot of "Desktop 1" is attached.

Thanks, but that'd be a workaround. What I want is to have Chrome on the left at all times and Alacritty on the right hand side at all times

You need to create a signal or something to automate the behaviour. I have recently thought about adding the ability to save and restore layouts, which would solve your issue, but no ETA for when this will be ready. This was mentioned in https://github.com/koekeishiya/yabai/issues/902 in which I reference other issues where this has been mentioned.

Thanks. What attribute defines that 'Chrome' should sit left and 'Alacritty' should sit right?

Thanks. What attribute defines that 'Chrome' should sit left and 'Alacritty' should sit right?

I'm not sure if the window_moved signal is sufficient for this, but if so, you could do something like this (edit the coordinates to match your displays):
yabai -m signal --add event=window_moved action=~/.config/yabai/arrange-chrome-alacritty.sh
if (yabai -m query --windows --space | jq -e '.[] | select(.app == "Chrome") | .frame | .x == -0 and .y < 33') \
  && (yabai -m query --windows --space | jq -e '.[] | select(.app == "Alacritty") | .frame | .x > 100 and .y < 33')
then
  yabai -m space --mirror y-axis
fi

https://github.com/h-ohsaki/macpywm


IdentityServer4 4.0.1 does not accept scope

...while the previous version 3.1.3 did
Relevant parts of the log file
Postman protocol
POST /connect/token HTTP/1.1
Accept-Encoding: identity
User-Agent: PostmanRuntime/7.26.1
Cache-Control: no-cache
Postman-Token: 923b3113-5436-4d91-80dc-044ce3650b08
Host: dpvmprod.fritz.box
Connection: keep-alive
Content-Type: application/x-www-form-urlencoded
Content-Length: 115
grant_type=password&username=Frank_Hintsch&password=xxxxx&scope=api%2Fv1&client_id=dpclient&client_secret=yyyyy
HTTP/1.1 400 Bad Request
Date: Thu, 02 Jul 2020 14:04:41 GMT
Server: Kestrel
Content-Type: application/json; charset=UTF-8
Cache-Control: no-store, no-cache, max-age=0
Pragma: no-cache
Connection: close
Transfer-Encoding: chunked
{"error":"invalid_scope"}

Logfile
2020-07-02 16:04:41.0278||ERROR|IdentityServer4.Validation.DefaultResourceValidator|Scope api/v1 not found in store. |url: http://dpvmprod.fritz.box/connect/token|action:
2020-07-02 16:04:41.3302||ERROR|IdentityServer4.Validation.TokenRequestValidator|Invalid scopes requested, {"ClientId":"dpclient", "ClientName":"Dokuplan Client", "GrantType":"password", "Raw":{"grant_type":"password","username":"Frank_Hintsch","password":"***REDACTED***","scope":"api\/v1","client_id":"dpclient","client_secret":"***REDACTED***"}} |url: http://dpvmprod.fritz.box/connect/token|action:

https://leastprivilege.com/2020/06/18/resource-access-in-identityserver4-v4-and-going-forward/


Mongodb: couldn't connect to server controller:27017 at src/mongo/shell/mongo.js:147

When creating Ceilometer database:
mongo --host controller --eval '
db = db.getSiblingDB("ceilometer");
db.addUser({user: "ceilometer",
pwd: MONGODB_PASSWORD,
roles: [ "readWrite", "dbAdmin" ]})'

I got the error:

Error: couldn't connect to server controller:27017 at src/mongo/shell/mongo.js:147

The correct controller IP is configured in mongodb config file
/etc/mongodb.conf

bind_ip = <IP_ADDRESS>

The databse service  looks OK:
service mongodb status

mongodb start/running, process 3202

pinging the controller resolves to <IP_ADDRESS> ??!! A bit strange
ping controller

PING controller (<IP_ADDRESS>) 56(84) bytes of data.
64 bytes from controller (<IP_ADDRESS>): icmp_seq=1 ttl=64 time=0.045 ms
64 bytes from controller (<IP_ADDRESS>): icmp_seq=2 ttl=64 time=0.038 ms
64 bytes from controller (<IP_ADDRESS>): icmp_seq=3 ttl=64 time=0.049 ms

Looking at the hosts file
cat /etc/hosts

<IP_ADDRESS>	localhost
<IP_ADDRESS>	controller
#controller
<IP_ADDRESS>	controller
<IP_ADDRESS>	controller-api
...

Removed the entry

<IP_ADDRESS>	controller

As specified at the documentation:
http://docs.openstack.org/liberty/install-guide-ubuntu/environment-networking-controller.html

Now the database is created.


Plugging in a controller crashes the game

If I plug in a controller in my joinable scene, the game crashes.
`## Returns the name of a gamepad-specific action
func get_action_name(device: int, action: StringName) -> StringName:
if device >= 0:
assert(device_actions.has(device), "Device %s has no actions. Maybe the joypad is disconnected." % device)
# if it says this dictionary doesn't have the key,
# that could mean it's an invalid action name.
# or it could mean that action doesn't have a joypad event assigned
return device_actions[device][action]
# return the normal action name for the keyboard player
return action`

The game crashes on the
assert(device_actions.has(device), "Device %s has no actions. Maybe the joypad is disconnected." % device)
with an error of "Assertion failed: Device 1 has no actions. Maybe the joypad is disconnected".
I think when I plug the controller in, it triggers the "join" action before the action can be created from the "_on_joy_connection_changed".

changing the assert to:
if(device_actions.has(device)):
seems to fix it

hmmm I think that assert should still be there because it is a safeguard to protect me against myself. I do see my comment below that assert line and I'm wondering if any of those situations is what is happening to you?
Things to check:

Typo in the action name?
Does the action have a joypad event assigned to it in Project Settings -> Input Map?

If neither of those work, can you try testing your hypothesis by putting print statements at the very top of the _create_actions_for_device method to see if that gets called before the assert fails?

Closing to clean it up. Feel free to re-open or create a new issue if you still need some help :)


Carthage support

Is Carthage supported, or just CocoaPods?
Sent with GitHawk

Always taking PRs 😇
Sent with GitHawk


There is no way to get local timezone date?

I have a timestamp and I want to convert into local date object in swift. I tried using swiftDate date extension like this:
Date(timeIntervalSince1970: value!/1000).inLocalRegion()
Which returns DateInRegion object, but there is no way to get local date object out of it :(

If you want to get absolute Date object adjusted to the local region offset you can use .absoluteDate property.


Responsive Demo

What kind of change does this PR introduce? (check one with "x")

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Other... Please describe:

What is the current behavior? (You can also link to an open issue here)
No responsive demo
See: https://github.com/swimlane/ngx-datatable/issues/423
What is the new behavior?
Responsive demo present
Does this PR introduce a breaking change? (check one with "x")

[ ] Yes
[x] No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...
Other information:
This PR only adds a demo.
I'm happy to adjust the code to fit your style.

Thanks!

Just wanted to highlight the possible situation where one has been opening the row details (let's say in portrait mode) and while returning in landscape mode see this


Envoy NACKs on a valid IPv6 address

Description:
We ran into this issue that seems definitely unusual. I have considered if this is caused due to underlying host not supporting IPv6 or working in AWS bridge mode but not able to reproducible locally.
A NACK thrown in Envoy version v1.27.
failureReason:Error adding/updating listener(s) egress: malformed IP address: 2600:f0f0:0:0:0:0:0:1

As per NACK Envoy couldn't validate that this is a proper IPv6 address which was provided in filter chain match like
         "filter_chain_match": {
          "prefix_ranges": [
           {
            "address_prefix": "<IP_ADDRESS>",
            "prefix_len": 32
           },
           {
            "address_prefix": "2600:f0f0:0:0:0:0:0:1",
            "prefix_len": 128
           }
          ],

I believe the IPv6 address validation is done in https://github.com/envoyproxy/envoy/blob/83e604abd8214f379617e6320d2255ea20ca0e1f/source/common/network/utility.cc#L117
Repro steps:
Not able to reproduce as this was noted on customer's environment.
Config:
Same as the one mentioned above.
{
     "name": "egress",
     "active_state": {
      "version_info": "1",
      "listener": {
       "@type": "type.googleapis.com/envoy.config.listener.v3.Listener",
       "name": "egress",
       "address": {
        "socket_address": {
         "address": "<IP_ADDRESS>",
         "port_value": 59632
        }
       },
       "filter_chains": [
        {
         "filter_chain_match": {
          "prefix_ranges": [
           {
            "address_prefix": "<IP_ADDRESS>",
            "prefix_len": 32
           },
           {
            "address_prefix": "2600:f0f0:0:0:0:0:0:1",
            "prefix_len": 128
           }
          ],
          "destination_port": 8156
         },
         "filters": [
         ....

Logs:
Logs on Control Plane
26 09 2023 20:20:50,731 [WARN] envoy.common.EnvoyNackHandler: Received NACK(failureReason:Error adding/updating listener(s) egress: malformed IP address: 2600:f0f0:0:0:0:0:0:1) for resource(type:MetaType(identity=envoy.listener), version:, nonce:488d0f4a-425a-467c-99ac-1ddd0a0e9543, names:[]) from Envoy(version:v<IP_ADDRESS>)

I think we need more information to determine whether this anything that we'd want to address. Do you know what OS, version, etc was in use?

AL2023 (based on Fedora Linux distribution), kernel 6.1.52-71.125.amzn2023.x86_64
It was using AWS ECS networking in Bridge mode - I am not sure if this network mode would influence filter_chain_match IPs.

Looking at the code it seems this must be getaddrinfo returning an error. That's about as far as I can get with the time I have.

If this getaddrinfo functionality is provided by glibc, want to understand when Envoy does Api::OsSysCallsSingleton::get().getaddrinfo( call, would it be handled with some library already include with Envoy static binary or would Envoy make call to underlying OS and the glibc functionality has to be supported in the OS itself?
In the above custom Envoy image that is used the binary & the image is built on AmazonLinux2 (CentOS flavor). But the container is run on AmazonLinux2023 host which is Fedora based. So I am wonder if there is some incompatibility that would cause this problem (rarely).

From my experience, glibc is the one library that Envoy links dynamically. If the OS version is older than the compile version it'll fail to start.

I have a similar issue with Cilium 1.16.5, where the cilium-envoy-... pods crash claiming ::1 is a malformed ip. All affected systems have IPv6 support disabled via a grub flag.
https://github.com/cilium/cilium/commit/c4b13797d223af2f514acad6d7ec5a679d856f79

:wave:
For the information, Cilium 1.16.5 is using envoy 1.30.8/Distribution/RELEASE/BoringSSL.


Incremental reparsing for single tokens

Implement incremental reparsing for WHITESPACE, COMMENT, DOC_COMMENT, IDENT, STRING and RAW_STRING. This allows to avoid reparsing whole blocks when a change was made only within these tokens.

Unfortunately I don’t have time for a thorough review right now, but what jumps at me as suspicious is that there isn’t any handling for context sensitive identifiers. Specifically, things like default and union are tokenized as identifiers, but are turned into keywords by the parser. Let’s add a test that checks that modifying ‘notunion S {}’ to ‘union S’ works correctly?
It would also be awesome if property based/fuzz tests could discover this case...

Looking through the code I didn't find code responsible for handling unions. It hasn't been implemented yet or am I missing something?

It hasn't been implemented yet or am I missing something?

Indeed, whoups :) This functionality is handle by https://github.com/matklad/libsyntax2/blob/b6f8037a6f8fbcb4f127e1d2b518279650b1f5ea/crates/libsyntax2/src/parser_api.rs#L51-L54, and looks like we have auto and default, but no union. I think it makes sense to add support for unions though before fixing this issue though, it shouldn't be hard. Will write instructions in a minute.

Filed as https://github.com/matklad/libsyntax2/issues/70

@matklad I'm not sure why test_runnables_project failed on Travis build. Could you tell me what went wrong?

yep, looks like a non-determenistic test, sigh :(

bors r+
LGTM, let's merge!
I think we need to add a couple more tests here, but I am going to heavyli reactor repo structure soon, let's merge as is.

Specifically:

I think tests for contextual keywords are still missing?
An important case is appending/prepending new text to the end/begning of the token (adding more spaces, or typing at the end of identifier). Let's add these tests as well, to make sure we find the correct leaf at offset. Perhaps we need to relex a pair of adjecent tokens if edit touchs an edge of the token?


IgniteTicketRegistryConfiguration bean references itself

changes the name of the configuration bean since it contains another bean with the same name.
igniteConfiguration -> igniteTicketRegistryConfiguration

Looks good. Fix the build failures please.

I think this is just the beginning of a bigger issue...

I'm going to resubmit this against letsboot

No problem. Please be sure to submit before this weekend. The branch is going to merge with master soon and then it will go away. If you want to wait and let the merge happen, that's fine too. Thanks!


Update faq.md

Fixed sniproxy link

Well now I feel stupid, :P I came across this backwards

👍 Ready for merge


'byte index ... is not a char boundary' panic when diffing files that are mostly but not entirely text

Thanks for difftastic!
Description
We've got a few uncompressed zip files checked in to a repository that contain mostly text, but the small amounts of zip metadata are non-UTF8 binary data. (Specifically they're snapshots of Excel spreadsheets from snapshot tests, that have been left uncompressed for (slightly) better diffing, in theory.) When I run Difftastic via git difftool (configured following https://difftastic.wilfred.me.uk/git.html) when those files change, it panics.
Reduced example: I ran RUST_BACKTRACE=1 difft store-only-1.zip store-only-2.zip on the files below:
store-only-2.zip --- Text
1 䭐Ѓ                                                                                1 䭐Ѓ
thread 'main' panicked at 'byte index 162 is not a char boundary; it is inside 'ਃ' (bytes 161..164) of `汩⹳ਊ楆敬⁳湩怠慳灭敬晟汩獥怯愠敲愠獬湵敤⁲桴䥍⁔楬散獮湵敬獳猠慴整੤瑯敨睲獩湩琠敨物栠慥敤⹲倊ŋḂਃ✀⡚ⵕ`', library/core/src/str/mod.rs:127:5
stack backtrace:
   0: _rust_begin_unwind
   1: core::panicking::panic_fmt
   2: core::str::slice_error_fail_rt
   3: core::ops::function::FnOnce::call_once
   4: core::intrinsics::const_eval_select
   5: core::str::slice_error_fail
   6: difft::display::style::split_and_apply
   7: difft::display::side_by_side::print
   8: difft::print_diff_result
   9: difft::main
note: Some details are omitted, run with `RUST_BACKTRACE=full` for a verbose backtrace.

This works fine for files that are less text-y, e.g. equivalent compressed zip files (created without the -0) are detected as binary:
compressed-2.zip --- binary
Binary contents changed.

Files
store-only-1.zip
store-only-2.zip
They were created by running the following in this repo:
zip -0 store-only-1.zip README.md
sleep 2
touch README.md
zip -0 store-only-2.zip README.md

In theory, these are mostly-text, since they're store-only (-0) zip files and so contain the README.md contents literally. Only a few bytes (e.g. in timestamps) are different. For instance:
$ hexdump -C store-only-1.zip
00000000  50 4b 03 04 0a 00 00 00  00 00 27 5a 28 55 2d 4c  |PK........'Z(U-L|
00000010  d2 84 10 0f 00 00 10 0f  00 00 09 00 1c 00 52 45  |?.............RE|
00000020  41 44 4d 45 2e 6d 64 55  54 09 00 03 99 42 19 63  |ADME.mdUT....B.c|
00000030  99 42 19 63 75 78 0b 00  01 04 f5 01 00 00 04 14  |.B.cux....?.....|
00000040  00 00 00 3c 70 20 61 6c  69 67 6e 3d 22 63 65 6e  |...
.  . |
000000a0  20 3c 62 72 3e 0a 20 20  3c 61 20 68 72 65 66 3d  |
.  <a href=|
...
00000ed0  64 6f 72 2f 2a 2f 4c 49  43 45 4e 53 45 60 20 66  |dor/*/LICENSE` f|
00000ee0  6f 72 20 6d 6f 72 65 20  64 65 74 61 69 6c 73 2e  |or more details.|
00000ef0  0a 0a 46 69 6c 65 73 20  69 6e 20 60 73 61 6d 70  |..Files in `samp|
00000f00  6c 65 5f 66 69 6c 65 73  2f 60 20 61 72 65 20 61  |le_files/` are a|
00000f10  6c 73 6f 20 75 6e 64 65  72 20 74 68 65 20 4d 49  |lso under the MI|
00000f20  54 20 6c 69 63 65 6e 73  65 20 75 6e 6c 65 73 73  |T license unless|
00000f30  20 73 74 61 74 65 64 0a  6f 74 68 65 72 77 69 73  | stated.otherwis|
00000f40  65 20 69 6e 20 74 68 65  69 72 20 68 65 61 64 65  |e in their heade|
00000f50  72 2e 0a 50 4b 01 02 1e  03 0a 00 00 00 00 00 27  |r..PK..........'|
00000f60  5a 28 55 2d 4c d2 84 10  0f 00 00 10 0f 00 00 09  |Z(U-L?..........|
00000f70  00 18 00 00 00 00 00 00  00 00 00 a4 81 00 00 00  |...........?....|
00000f80  00 52 45 41 44 4d 45 2e  6d 64 55 54 05 00 03 99  |.README.mdUT....|
00000f90  42 19 63 75 78 0b 00 01  04 f5 01 00 00 04 14 00  |B.cux....?......|
00000fa0  00 00 50 4b 05 06 00 00  00 00 01 00 01 00 4f 00  |..PK..........O.|
00000fb0  00 00 53 0f 00 00 00 00                           |..S.....|

The elided ... is another 200ish lines of the README contents.
Versions

Difftastic 0.35.0, installed via homebrew
macOS

I hit this issue when diffing vim spelling dictionary files.   The extension is .spl
latest/dot_config/nvim/spell/en.utf-8.add.spl --- Text
thread 'main' panicked at 'byte index 22 is not a char boundary; it is inside 'Ţ' (bytes 21..23) of `^@砖琁ȂȂĄŲůŴůŢ^A吀ɵ潥琁栁爁漁省^B^AᘀŮųťŮŴŨšŬ^A䘀ͬ瑡ŵŷŨŮť^A䘀ŹŲŵ^A᐀ţ͢浧ŴŲšŰɨĀ^@猖漁搁甁ā^@氨攁渁猁漁ā^@爖椁瀁攁爁ā^@㉆^@^@^@^@`', /home/karl.meissner/.cargo/registry/src/github.com-1ecc6299db9ec823/difftastic-0.35.0/src/display/style.rs:57:6
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
fatal: external diff died, stopping at latest/dot_config/nvim/spell/en.utf-8.add.spl

for info on the file format see
https://fileinfo.com/extension/spl#:~:text=An SPL file is a spelling dictionary used by Vim,runtime%2Fspell directory.

@huonw thanks for the great bug report.
It sounds like there are two issues here:

Difftastic is trying to split on a non-char boundary, which it should never do
File type detection should probably recognise these bytes as ZIP that shouldn't be diffed as text

Smaller repro:
$ DFT_WIDTH=28 cargo run -- foo.txt bar.txt

foo.txt
bar.txt

Looks like an issue with combining characters.
    #[test]
    fn test_combining_char() {
        assert_eq!(
            split_string_by_width("aabbcc\u{300}x", 6, false),
            vec![("aabbcc\u{300}", 0), ("x", 0)],
        );
    }

I think the display width logic should also return the last byte offset.


Adding datasource to Amazon Managed Grafana outputs ec2_iam_role error

What happened: I deploy dashboards programmatically via the Grafana API, my code has not changed.  However, when I create a new 9.4 workspace in Amazon Managed Grafana, install the Athena plugin and attempt to configure it as a Datasource I get the following error:
attempting to use an auth type that is not allowed: "ec2_iam_role": Failed to create client

My SSO user from AWS Identity center also has full permissions to the account and is defined as the Admin user of the workspace.
Note, my Grafana Workspace Role does have full access to Athena.
The call I am making in my lambda is:
                  if plugin == 'athena':
                    body = {'name':self.datasource_name,'type':'grafana-athena-datasource','access':'proxy','url':'','user':'','database':'','basicAuth':False,'isDefault':False,'jsonData':{'authType':'ec2_iam_role','catalog':'AwsDataCatalog','database':self.athena_db,'defaultRegion':self.athena_region,'provisionedBy':'COAST','workgroup':self.athena_workgroup},'readOnly':False}
                  if plugin == 'cloudwatch':
                    body = {'access': 'proxy', 'isDefault': True, 'name': 'Cloudwatch', 'type': plugin}

What you expected to happen:
The datasource provisioned via lambda without issue in the past.
How to reproduce it (as minimally and precisely as possible):
Add Athena Datasource in Grafana, select Workspace IAM role in the drop down and enter ARN of role.
Environment:

Grafana version: 9.4
Plugin version:2.16.1
OS Grafana is installed on: Amazon Managed Grafana
User OS & Browser:
Others:

My last known working version I have installed in another workspace is 2.13.6

Hi @amazonchris, I'm releasing v2.16.2 which should fix this. It should be available shortly.


Aliases should be kept as open api schemas

Clear and concise description of the problem
I feel like, this is almost a bug and not a feature request.
For a tsp declaration like this
import "@typespec/http";
import "@typespec/rest";
import "@typespec/openapi3";

using TypeSpec.Http;
using TypeSpec.Rest;

@doc("Example API")
@service({
  title: "Example",
})
namespace Example;

interface Examples{
  @get
  get(id: string): Elapsed;
}

model Elapsed {
  amount: integer;
  dateUnit: DateUnit;
}

alias DateUnit = "hours" | "days" | "weeks" | "months" | "years";

we get this open API spec
openapi: 3.0.0
info:
  title: Example
  description: Example API
tags: []
paths:
  /:
    get:
      operationId: Examples_get
      parameters: []
      responses:
        '200':
          description: The request has succeeded.
          content:
            application/json:
              schema:
                $ref: '#/components/schemas/Elapsed'
      requestBody:
        required: true
        content:
          application/json:
            schema:
              type: object
              properties:
                id:
                  type: string
              required:
                - id
components:
  schemas:
    Elapsed:
      type: object
      required:
        - amount
        - dateUnit
      properties:
        amount:
          type: integer
        dateUnit:
          type: string
          enum:
            - hours
            - days
            - weeks
            - months
            - years

As you can see we lost a piece of information about the alias.
This could have easily resulted in the following:
openapi: 3.0.0
info:
  title: Example
  description: Example API
tags: []
paths:
  /:
    get:
      operationId: Examples_get
      parameters: []
      responses:
        '200':
          description: The request has succeeded.
          content:
            application/json:
              schema:
                $ref: '#/components/schemas/Elapsed'
      requestBody:
        required: true
        content:
          application/json:
            schema:
              type: object
              properties:
                id:
                  type: string
              required:
                - id
components:
  schemas:
    Elapsed:
      type: object
      required:
        - amount
        - dateUnit
      properties:
        amount:
          type: integer
        dateUnit:
          type: string
          enum:
            - ref: '#/components/schemas/DateUnit'
    DateUnit:
      type: string
      enum:
        - hours
        - days
        - weeks
        - months
        - years

If the alias were to reference to models it could result into something like this:
    FilterValue:
      anyOf:
        - $ref: '#/components/schemas/MultiSelectFilterValue'
        - $ref: '#/components/schemas/DateFilterValue'

(If an alias is not pure models or scalars we can unpack them just like now.)
And with a result like this, a client generator can easily create a type for it or even a validator.
Or am I missing something in the docs and there is an option/flag for this?
Checklist

[X] Follow our Code of Conduct
[X] Read the docs.
[X] Check that there isn't already an issue that request the same feature to avoid creating a duplicate.

Alias are by design in the TypeSpec type graph non existent so it is not possible to retrieve their name.
If you want to create a union declaration you can use the union keyword or an enum would work in your case too
union DateUnit {
  "hours",
  "days",
  "weeks",
  "months",
  "years",
}

enum DateUnitEnum {
  hours,
  days,
  weeks,
  months,
  years,
}

playground

This was an issue on my part..
I'm fairly new to tsp and tried to use alias as it were union.. thanks for clearing it up.
Also, I saw that the results of circular dependencies do not play nice with the API spec emitter.
model MeuItem {
  label: string;
  // additional item props
}

model MenuGroup {
  label: string;
  // additional group props
  children: MenuItem | MenuGroup;
}

Is this a bug or is there another way to handle these cases?
In the API spec this will result in something like this:
 components:
  schemas:
    MenuGroup:
      type: object
      required:
        - label
        - children
      properties:
        label:
          type: string
        children:
          anyOf:
            - $ref: '#/components/schemas/MenuItem'
            - {}
    MenuItem:
      type: object
      required:
        - label
      properties:
        label:
          type: string

Sorry never got back to you, yeah this looks like a bug in openapi3 emitter, json schema one seems to handle that correctly
https://cadlplayground.z22.web.core.windows.net/?c=aW1wb3J0ICJAdHlwZXNwZWMvanNvbi1zY2hlbWEiOwoKdXNpbmcgVHlwZVNwZWMuSnNvblPFHTsKCm5hbWVzcGFjZSDGE3M7CgpAxEDGDwptb2RlbCBNZW51R3JvdXAgewogIGxhYmVsOiBzdHJpbmc7CgogIC8vIGFkZGl0aW9uYWwgZ8UqcHJvcHMKICBjaGlsZHJlbjrFRkl0ZW0gfMpROwp9CstlxR%2FTZNBjacQoxmJ9Cg%3D%3D&e=%40typespec%2Fjson-schema&options={}

Created a new issue specially for that https://github.com/microsoft/typespec/issues/3811


No identifiers.timestamp attribute in PresentProof response (revocable cred) set from findy agent

When I confirm a present-proof request, which requests attributes from one non-revocable and one revocable credential, I get the following identifiers object in PresentProofResponse body:
"identifiers": [ {"schema_id": "FnhYpbRquQe6TaECgdYxY5:2:BAMF-Basis-ID:1.1", "cred_def_id": "FnhYpbRquQe6TaECgdYxY5:3:CL:12:default"}, {"schema_id": "FnhYpbRquQe6TaECgdYxY5:2:guest:1.0", "cred_def_id": "FnhYpbRquQe6TaECgdYxY5:3:CL:17:ssi-am-guest-local-abc001", "rev_reg_id": "FnhYpbRquQe6TaECgdYxY5:4:FnhYpbRquQe6TaECgdYxY5:3:CL:17:ssi-am-guest-local-abc001:CL_ACCUM:1bd976eb-5fc2-417e-8e5e-c711479d3119"}]}
Normally there should be a "timestamp" field for the revocable credential (which is later important for verifier agent - see aries rfc 0441). This timestamp field is defined here, but later seeming not set.
I also can't find the place in the code where this timestamp attribute is set in identifiers object. Is it possible that this variant is not fully implemented yet or am I missing something?
Regards

Thank you for the feedback! Highly appreciated.
Without checking the code, I can say that you are correct: 'this variant is not fully implemented.' During the early stages of the findy-agent development, we decided not to support revocation because the design AnonCreds 1.0 had many problems. We found no real-world use cases for public revocation in our business field. But never say never.
We'll study this case and offer a patch if it is easy to fix.


Support non-explicit piecewise syntax

For example, {} and {x>0: x, 0} is supported by Desmos but not text mode.

An art contest graph uses this syntax, and it doesn't round-trip, so x=-0.4y-24\left\{0<0.6y-73\right\}\left\{1.2x>0.6y-166\right\}\left\{x<-0.4y-12.3\right\}\left\{\right\} is a good same-parse test to use in addition to \{\}.


chore(repo): GitHub templates for issues/pull requests

should make maintenance a little easier... direct library questions to stack overflow, encourage searching closed issues, remind people to update code generators in prs, write tests, etc

Coverage decreased (-0.01%) to 98.234% when pulling<PHONE_NUMBER>6d75d44c5aa9a7cdd0babbce4949da on justingreenberg:feature/github-templates into 00cc4e41f1294ef46095878ac6bde1a501021d99 on mxstbr:master.

Coverage decreased (-0.01%) to 98.234% when pulling f7ec1796fa2e0c5ac7b43823d829a4c23e0b06ac on justingreenberg:feature/github-templates into 00cc4e41f1294ef46095878ac6bde1a501021d99 on mxstbr:master.

Love it @justingreenberg, this is awesome!! :+1:


feat: improve thorchain status polling reliability

Description

Pull Request Type

[ ] :bug: Bug fix (Non-breaking Change: Fixes an issue)
[ ] :hammer_and_wrench: Chore (Non-breaking Change: Doc updates, pkg upgrades, typos, etc..)
[ ] :nail_care: New Feature (Breaking/Non-breaking Change)

Issue (if applicable)

closes #
Risk

Testing

Engineering

Operations

Screenshots (if applicable)

Current dependencies on/for this PR:

develop

PR #5659   👈

This stack of pull requests is managed by Graphite.


Cannot get basic phantomJS examples to run in chrome. Javascript exceptions thrown

Which version of PhantomJS are you using? Tip: run phantomjs --version.

2.1.1

What steps will reproduce the problem?
Download the mac osx binary from the phantomjs site
Extract the zip file
From the extracted directory run

./phantomjs --remote-debugger-port=9000 ../examples/version.js

Navigate to http://localhost:9000/
Navigate to http://localhost:9000/webkit/inspector/inspector.html?page=1
Clicking on any of the buttons in the remote inspector causes exceptions in the browser window, break points never hit even after running __run() in the remote webkit console (See Screenshot)
Exceptions are thrown in the browsers native console.

Which operating system are you using?
OS X Yosemite 10.10.5

Did you use binary PhantomJS or did you compile it from source?
Binary

Please provide any additional information below.
I saw similar things happening on PhantomJS 1.9.8. Also happened in Safari.

Closing.  I also had the phantomjs binary and one installed globally via npm.
I removed the phantomjs version installed via npm, and used safari since I have no plugins installed on it.

I saw this on Windows Chrome too. Would it be due to Chrome may have removed the getPropertyCSSValue method? https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/3VmxWFzcyJc/GFOnJxnWBN0J
Similar issue: https://github.com/square/PonyDebugger/issues/157

Not that it fixes anything, but you can paste this code in Chrome console (the real one) to patch it.
window.CSSPrimitiveValue = function(styledec, name) {
	this._styledec = styledec;
	this._name = name;
};
window.CSSPrimitiveValue.prototype.setFloatValue = function(unitType, floatValue) { };
window.CSSStyleDeclaration.prototype.getPropertyCSSValue = function(x) {
	var self = this;
	var a = new CSSPrimitiveValue(this, x);
	a.getCssText = function() { return self[x]; };
	a.getCssValueType = function() { return -1; };
	a.setCssText = function(y) { self[x] = y; };
};


Add DCO workflow until dcoapp/app issue is fixed

Description
Looks like the DCO app issue may take some time to get fully fixed https://github.com/dcoapp/app/issues/211#issuecomment-2146301930, for temporary fix we can use  https://github.com/tim-actions/dco to run the DCO checks. We have used this in past for job-scheduler repo https://github.com/opensearch-project/job-scheduler/tree/<IP_ADDRESS>/.github/workflows, this should unblock the open PR's with mandatory DCO branch rule.
Related Issues

Resolves https://github.com/opensearch-project/OpenSearch/issues/13964

Check List

[ ] ~New functionality includes testing.~

[x] All tests pass

[ ] ~New functionality has been documented.~

[ ] ~New functionality has javadoc added~

[ ] ~API changes companion pull request created.~
[ ] ~Failing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)~
[x] Commits are signed per the DCO using --signoff
[ ] ~Commit changes are listed out in CHANGELOG.md file (See: Changelog)~
[ ] ~Public documentation issue/PR created~

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@prudhvigodithi A short term alternative is to remove the required check and have maintainers manually verify that commits are signed. That might be less intrusive if we don't plan to keep this version of the check. What do you think?

@prudhvigodithi A short term alternative is to remove the required check and have maintainers manually verify that commits are signed. That might be less intrusive if we don't plan to keep this version of the check. What do you think?

@andrross I think workflow is an acceptable alternative to keep (instead of app that proves to be unstable) for good.

A short term alternative is to remove the required check and have maintainers manually verify that commits are signed. That might be less intrusive if we don't plan to keep this version of the check. What do you think?

Luckily we've already got this workflow, I would rather having machines read ever commit and return a ✅ or ❌ on each PR than train myself to do this repetitive task.

@prudhvigodithi we are all set, but needs forced megre

Let me force merge this PR and once the backports are done I will update the branch rule to point to this new DCO workflow.


Add java-agents check

We have the NewRelic agent in our :java-agents vector in many of our project.clj files. It is constantly getting out of date because lein-ancient can't currently check it.
This PR adds the ability to do that. It adds a :java-agents arg and turns that on under check :all as well.
The tests are updated and I have manually tested it with both check and upgrade. I also added a mention of the new option to the README.

ping
Would love to get this merged if possible. Thanks!


Add Modal components support

Is your feature request related to a problem? Please describe.
Right now we have no clear way to have little modals on top of our screens.
There are ways to do it, but we have no clear recommendation yet 😊
This might need some additions in the core (even though I think what we have might be enough already).
Describe the solution you'd like
<SpatialNavigationRoot>
  <Button /> {/* should not be active anymore */}
  <Modal isOpen>
    <Button /> {/* should be active */}
  </Modal>
</SpatialNavigationRoot>

Describe alternatives you've considered
...
Additional context
N/A

This was merged. Nothing in the core of the lib, but an example is now provided 😊
https://github.com/bamlab/react-tv-space-navigation/pull/59


can't get user followsCount/followedByCount

have login，getAccountById can't get followsCount/followedByCount，return null。the curl response only have count。

same here, seems like Instagram changed their api/information policy

You can take count with getAccount . The problem is in getAccountById.

@kirillantv sure, but I just have to id and not the name. So I would have to call getAccountById to load the username and then call getAccount?!

@inkrement seems like that. But this is dirty. I've writen an issue with a reason https://github.com/postaddictme/instagram-php-scraper/issues/136 . Lets wait an answer.


Checking if the field is read-only before trying to modify it

Fixes #551

Coverage decreased (-0.006%) to 64.38% when pulling dec991219bf465c9dc088645cda5e84623c5aefa on jainnikhil30:master into 5a42cf0a99addaba0b81af6acbf4ddbcc99ed294 on ansible:master.

I'm going to have to write some of my own notes here. Hope you don't mind. Here is an example of a normal setting:
            "LOG_AGGREGATOR_PORT": {
                "type": "integer",
                "required": false,
                "label": "Logging Aggregator Port",
                "help_text": "Port on Logging Aggregator to send logs to (if required and not provided in Logging Aggregator).",
                "category": "Logging",
                "category_slug": "logging",
                "default": null
            },

That setting is shown in the OPTIONS under actions -> PUT and actions -> GET
Here is an example of an unchangeable setting
            "AWX_ISOLATED_KEY_GENERATION": {
                "type": "boolean",
                "label": "Generate RSA keys for isolated instances",
                "help_text": "If set, a random RSA key will be generated and distributed to isolated instances.  To disable this behavior and manage authentication for isolated instances outside of Tower, disable this setting.",
                "category": "Jobs",
                "category_slug": "jobs",
                "defined_in_file": false
            },

That setting is (correctly) shown under actions -> GET but not under PUT.
So, in the case that a setting is read-only, this code yields an empty dict for r.json()['actions']['PUT'].get(key, {}), which is why your use of to_type winds up being correct.
Functionally, I agree with this change, but it takes research to figure out how it works. Because of that, I would ask that you either add a descriptive comment, or change the test to if key not in r.json()['actions']['PUT'], for the sake of clarity. Then I'll be happy to merge this.
Thanks!

travis fail looks unrelated, will look into it


Defining main in bower

If the bower file does not contain a main property than some dependency utils like wiredep will include all files under ./dist

There already is a main:
https://github.com/nraboy/ng-cordova-oauth/blob/master/bower.json#L3
Are you referring to something else?
Best,

Ah didn't see that. I think you need to remove the minified file - otherwise it will include both if you have an automatic management tool for it.

@matheusrocha89 what do you think of this? It undoes https://github.com/nraboy/ng-cordova-oauth/commit/b35bf954688ebcb0845f8f491b446624452440d6 which is a commit that you had made last year.
I don't know the best approach, so I'm looking for ideas.
Best,

I would interpret [0] that there should be only 1 file since it has to be the main entry point. I'd prefer that this is the non-minified one, since most of us anyways have a minification build step..
[0] https://docs.npmjs.com/files/package.json#main

I am not opposed to it, but I want to find out from @matheusrocha89 why he had it in the first place in case both you and I are overlooking something.

I think it's a good Pull request, I don't remember the reason why I put both files on main, the min and the not min, so if I don't remember I think it was not important so we can merge this @nraboy.

Sounds good to me.  @visiongeist can you update your pull request?  The current would result in a duplicate main.
Best,

done :)

Thanks!


DropdownMenu data refresh error

Steps to reproduce
1.Build a non-empty list to initialize dropdownMenuEntries. initialSelection is list.first.

2.Set the list to empty. DropdownMenu. The drop-down menu disappears, but the displayed selected items are not refreshed.

I think the error code exists in line 541 of dropdown_menu.dart. It lacks the code branch when index=-1. It should be empty at this time.
if (oldWidget.initialSelection != widget.initialSelection) {
      final int index = filteredEntries.indexWhere((DropdownMenuEntry<T> entry) => entry.value == widget.initialSelection);
      if (index != -1) {
        _localTextEditingController?.value = TextEditingValue(
          text: filteredEntries[index].label,
          selection: TextSelection.collapsed(offset: filteredEntries[index].label.length),
        );
      }
//here miss case
    }

After modification
if (oldWidget.initialSelection != widget.initialSelection) {
      final int index = filteredEntries.indexWhere((DropdownMenuEntry<T> entry) => entry.value == widget.initialSelection);
      if (index != -1) {
        _localTextEditingController?.value = TextEditingValue(
          text: filteredEntries[index].label,
          selection: TextSelection.collapsed(offset: filteredEntries[index].label.length),
        );
      } else {
        _localTextEditingController?.value = TextEditingValue.empty;
      }
    }

The abnormal problem disappeared, and when the list was set to empty, the selected option also became empty.
Expected results
Set the list to empty. DropdownMenu. The drop-down menu disappears, but the displayed selected items should also be empty.
Actual results
Set the list to empty. DropdownMenu. The drop-down menu disappears, but the selected item displayed is the last selected item.
Code sample
Code sample
I use getX ，you can change to setstate to refresh profileList to empty

 DropdownMenu<String>(
                              width: 650.h,
                              hintText: Strings.enterProfileHint.tr,
                              menuStyle: const MenuStyle(
                                backgroundColor: WidgetStatePropertyAll<Color>(Colors.white),
                                surfaceTintColor: WidgetStatePropertyAll<Color>(Colors.white),
                                shadowColor: WidgetStatePropertyAll<Color>(Colors.white),
                                padding: WidgetStatePropertyAll<EdgeInsetsGeometry>(EdgeInsets.symmetric(vertical: 0)),
                              ),
                              initialSelection: controller.profileList.isNotEmpty ? controller.profileList.first : null,
                              onSelected: (value) {
                                controller.currentProfile.value = value!;
                                AppConfig().put(AppConfig().roleName, value);
                              },
                              dropdownMenuEntries: controller.profileList.map((String value) {
                                return DropdownMenuEntry<String>(value: value, label: value);
                              }).toList(),
                              inputDecorationTheme: InputDecorationTheme(
                                hintStyle:
                                    Theme.of(context).textTheme.displayMedium?.copyWith(color: const Color(0xFF999999)),
                                filled: true,
                                contentPadding: EdgeInsets.symmetric(vertical: 22.h, horizontal: 22.h),
                                enabledBorder: outlineInputBorder(),
                                focusedBorder: outlineInputBorder(),
                              ),
                            ),

Screenshots or Video

Screenshots / Video demonstration
[Upload media here]

Logs
Logs
[Paste your logs here]

Flutter Doctor output
Doctor output
[!] Flutter (Channel stable, 3.24.1, on Microsoft Windows [版本 10.0.22631.4169], locale zh-CN)
    • Flutter version 3.24.1 on channel stable at D:\fluttersdk\default
    ! Warning: `flutter` on your path resolves to D:\fluttersdk\versions\3.24.1\bin\flutter, which is not inside your current Flutter SDK checkout at D:\fluttersdk\default. Consider adding D:\fluttersdk\default\bin to the front
      of your path.
    ! Warning: `dart` on your path resolves to D:\fluttersdk\versions\3.24.1\bin\dart, which is not inside your current Flutter SDK checkout at D:\fluttersdk\default. Consider adding D:\fluttersdk\default\bin to the front of
      your path.
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 5874a72aa4 (8 weeks ago), 2024-08-20 16:46:00 -0500
    • Engine revision c9b9d5780d
    • Dart version 3.5.1
    • DevTools version 2.37.2
    • If those were intentional, you can disregard the above warnings; however it is recommended to use "git" directly to perform update checks and upgrades.

[√] Windows Version (Installed version of Windows is version 10 or higher)

[√] Android toolchain - develop for Android devices (Android SDK version 35.0.0)
    • Android SDK at C:\Users\17936\AppData\Local\Android\sdk
    • Platform android-35, build-tools 35.0.0
    • Java binary at: C:\Program Files\Android\Android Studio new\jbr\bin\java
    • Java version OpenJDK Runtime Environment (build 17.0.11+0--11852314)
    • All Android licenses accepted.

[√] Chrome - develop for the web
    • Chrome at C:\Program Files\Google\Chrome\Application\chrome.exe

[X] Visual Studio - develop Windows apps
    X Visual Studio not installed; this is necessary to develop Windows apps.
      Download at https://visualstudio.microsoft.com/downloads/.
      Please install the "Desktop development with C++" workload, including all of its default components

[√] Android Studio (version 2024.1)
    • Android Studio at C:\Program Files\Android\Android Studio new
    • Flutter plugin can be installed from:
       https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
       https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 17.0.11+0--11852314)

[√] VS Code (version 1.92.1)
    • VS Code at C:\Users\17936\AppData\Local\Programs\Microsoft VS Code
    • Flutter extension can be installed from:
       https://marketplace.visualstudio.com/items?itemName=Dart-Code.flutter

[√] Connected device (4 available)
    • sdk gphone64 x86 64 (mobile) • emulator-5554 • android-x64    • Android 15 (API 35) (emulator)
    • Windows (desktop)            • windows       • windows-x64    • Microsoft Windows [版本 10.0.22631.4169]
    • Chrome (web)                 • chrome        • web-javascript • Google Chrome 127.0.6533.89
    • Edge (web)                   • edge          • web-javascript • Microsoft Edge 127.0.2651.74

This is probably fixed on master since https://github.com/flutter/flutter/pull/155757.
Especially by:
https://github.com/flutter/flutter/pull/155757/files#diff-634a338bd9ed19b66a27beba35a8acf4defffd8beff256113e6811771a0c4821

@rd-wang
Please switch to latest master and re-run your scenario to check if you still see the reported behavior or not.

This problem has been fixed in master, but I cannot use the master branch and need to use the stable branch. I want to know when this problem can be fixed on stable.
Some suggestions：
When the option list changes, just restore the initial state (empty selection),
It is not necessary to select the last selected one.
Because it may be that an option in the list is consistent, but the meaning of the option has changed (eg:from choosing a favorite fruit to choosing a hated fruit due to some business reasons).

I want to know when this problem can be fixed on stable.

Read this document to understand how the fixes are pushed to stable and its frequency. This particular fix will most likely will be available in next stable release.

Some suggestions：

Please file new issue for these so that we can properly address and track it.
Closing this issue as fixed in master.


Set up CD pipeline with Build, Dev, Test stages

As a Developer
I need a CD pipeline
So that I can automatically build, deploy to dev and test
Details & Assumptions:

Set up the pipeline using IBM Cloud Continuous Delivery
Connect the pipeline to GitHub by webhook
We only deal with 3 stages (Build, Dev, Test) in this story
For test stage, run both unit tests and behave tests

Acceptance Criteria:
When I push on the main branch
Then the CD pipeline should be triggered and run

3-stage pipeline is now configured and working properly.

Prod environment and related CD stage will be addressed in later stories.


Normalize, simplify  and add tests for Deploy commands

[ ] simplify command structure
[ ] add testing for deployment commands and code
[ ] normalize commands and move logging prompts to en.py for easy internationalization

defunct


DayPicker, DateInput Bugs and inconveniences

It's uncomfortable that you can't choose the year on DayPicker, and it can become tedious to go to that year using buttons. It also should be mentioned that you can face some challenges while typing the date manually.  The focus change strangely and unexpectedly. It's sometimes impossible to delete characters.
Video explanation

Fixed DateInput component in pull request #196

After research, I found out that the main problem is in the value prop as well as in the component prop (our custom  <TextInput/>)  that are passed to <DayPickerInput/>.
The issue connected to value is that the date parser understands 12/12/2 as 12/12/0002 fills the input component with such date. That's why we notice such a "jump" while typing the date.
It's time to figure out the problem in <TextInput/>.


Sogou IME does not work in Edge/IE

Test-item Microsoft/vscode#11146

OS Version: Win 10 Anniversary Update (14393)

Install the Sogou IME per the directions here - https://github.com/Microsoft/vscode/wiki/IME-Test

Edge: When I type ni, the IME prompt does not appear. It works fine in VS Code and Chrome. Same if I use the 'npm' version of the editor, so not a regression.
IE: When I type ni, the prompt does appear, but when I press space or select an option, the text is not inserted into the editor. In the 'npm' version, the text is inserted but monaco also duplicates some of the text surrounding the character.

This test item came in this month and we never did anything special for Sogou before. Good to know that something is off, but given the Microsoft Pinyin method works no action for now.

Has this problem been solved？

I had the same problem

The Monaco Editor is generated from the source code of VS Code and in order to improve VS Code we must be able to use modern browser features, like Flexbox, which has a number of bugs that we cannot workaround in IE11.
We have investigated the cost of fixing all the problems of IE11 and have decided to discontinue support for IE 11. The last Monaco Editor version that was tested on IE 11 is 0.18.1.
Thank you for your understanding.


Synchronize to master.

Q
A

Is bugfix?
❌

New feature?
✔

Breaks BC?
❌

https://github.com/yiisoft/yii2/pull/20025#issuecomment-1774029004


cleanup work in org.terasology.math

Contains
Cleanup work in org.terasology.math. Primarily marks fields which are effectively final as "final", but also performs more advanced cleanup/optimizations in Rotation.
How to test
If the game turns on, it's probably fine.
Outstanding before merging

[ ] Should Transform.scale not also be final? Would changing it to final break any existing module?

Outstanding after merging

[x] IntegerRange should be replaced with Guava's Ranges as they are much more flexible, but this is best fit for a separate PR Nevermind, it would be better to improve IntegerRange.

Hooray Jenkins reported success with all tests good!

Hooray Jenkins reported success with all tests good!

Note: The "outstanding" question is probably best answered by someone more experienced with the project.

Found time to test this and the game did indeed still turn on. Merged :-)


generateNixPathFromInputs should use a dir entry instead of per-flake entries

generateNixPathFromInputs symlinks relevant inputs into /etc/nix/inputs and synthesizes a NIX_PATH with an entry for each input. I assume it does this so that way the NIX_PATH entries will always reference the current configuration without having to spawn a new shell. The downside is any additions/removals to the input set won't be reflected in existing shells.
Instead of adding one entry per input to NIX_PATH, it should just add a single entry for /etc/nix/inputs. This way it will always reflect the current state of the system regardless of what happens to the inputs.

I don't think I quite catch the issue here, could you elaborate? Maybe with help of few examples.
Also adding /etc/nix/inputs would require it to contain default.nix?
I personally really do not care for NIX_PATH and I truly believe that it should get removed. I have added it for compatibility reasons in case you need nix-shell

@gytis-ivaskevicius When you have a directory entry without a name in NIX_PATH, then its children become the entries, named after their file names. e.g. NIX_PATH=nixpkgs=/etc/nix/inputs/nixpkgs and NIX_PATH=/etc/nix/inputs both cause <nixpkgs> to evaluate to /etc/nix/inputs/nixpkgs. This is how nix-channel works; you have ~/.nix-defexpr/channels on your NIX_PATH (no foo= prefix), so all the channels it puts in that directory are available with <> syntax.
It's nice because it means you don't need to start a new shell session to get the updated NIX_PATH when you add a new input or remove one. Like if I removed home-manager from my inputs, then <home-manager> would no longer evaluate to /etc/nix/inputs/home-manager, without needing a NIX_PATH update.

What @ElvishJerricco. And to be clear, you do not put a default.nix in the directory, and you do not give it a label.
Implementing this solution reuses your existing /etc/nix/inputs, and just means that the actual config value looks like
{
  nix.nixPath = mkIf cfg.generateNixPathFromInputs [ "/etc/nix/inputs" ];
}

This produces a NIX_PATH variable that looks like /etc/nix/inputs:/nix/var/nix/profiles/per-user/root/channels:/Users/lily/.nix-defexpr/channels. The new path works exactly like the two entries that were already there.

Thank you, I had no idea about this feature of nix


Insert mode bug with Telescope

When a file is opened with a Telescope finder, the buffer is initialized in insert mode.
To reproduce:

Open a fresh nvim session without any files
Launch any Telescope finder that operates on files (find_files, oldfiles, etc.)
Make sure that the field input in in insert mode
Open any file with the finder

I cannot reproduce this any more for some reason :scarf:
This makes me think that this is some kind of race condition that involves certain timings.

Interesting, hopefully the autcommands stop changing between releases soon. I will be closing this issue for now, if it pops up again please feel free to post an issue for review.


Style/add network logo to token logo

Motivation
As part of the single-view requirements, we would like to see a smaller logo that refers to the Token Network when there is the complete list of Tokens. For now, it will be showed only when the user selects Chain Fusion.

Changes

Use inception Logo component to create bottom-right smaller logo when there is a prop for that.
Use token's network icon in the Token Menu.

Tests
See screenshot above.

That's why, in my opinion, the first step is to create a new component that can render a logo for the token and a sub-icon/logo for its network.

I changed the commits to have a new component with a corner icon, let me know what you think.
I would still leave an optional parameter showNetworkIcon, because we are not sure if we will show the network logo in case the user selects a single network.

I would rename LogoWithCorner to TokenLogo and move the component to $lib/components/tokens.


Problems with definitions for subproperties of inheres in aggregate

The final clause of all three definitions is the same: ‘such that x disposition_of_aggregate y’. In the case of disposition of aggregate, this makes the definition clearly circular. In the case of the other two subproperties, it makes no sense given the domains specified for those subproperties vs. that specified for disposition of aggregate.
I believe that in all three definitions, ‘disposition_of_aggregate’ should be replaced with ‘inheres_in_aggregate’.

I agree, this seems like an oversight

Merged into development, closing this issue.

Shouldn't this be a subproperty of inheres_in?

@alanruttenberg: I don't believe it should be, contra @cameronmore. If inheres in aggregate were a subproperty of inheres in, then for any x and y, if x inheres in aggregate y, then x inheres in y. But according to the definition of 'inheres in aggregate', x inheres in aggregate y iff (i) x is an SDC and y is an OA, (ii) there is an Object z that's a member part of y and x inheres in z, and (iii) every other member part of y is a bearer of an SDC of the same type as x.* Now suppose A is an SDC and B is an OA such that A inheres in a member part of B and every other member part of B is a bearer of an SDC of the same type as A. Then, according to the definition, A inheres in aggregate B. Does it follow that A inheres in B? No, because inhering in a member part of an OA doesn't entail inhering in that OA. Thus, inheres in aggregate isn't a subproperty of inheres in, since it's not the case that for any x and y, if x inheres in aggregate y, then x inheres in y.
(That said, you might think that 'inheres in aggregate' isn't a particularly appropriate name for the object property so defined.)
*Or, at least, that's what I take the definition to be trying to say, though there are problems with it (as well as with the specified domain).

My bad you are right.
But yuck! Yes, the name is poorly chosen, and I would be interested in how this is used practically. No examples of use given. Trying to imagine: For role of aggregate it would mean that every member could independently realize the same (type of) role. I suppose that in my suggestion of a shared stewardship of a domain name, anyone in the group of agents in such a group has a "domain name manager" role so you could say "domain name manager role 1" inheres_in_aggregate . Or for quality I guess you could define an aggregate of red things as quality_of_aggregate red-quality. Is that the intended use?
It's a hack for avoiding a relation to a class and so, in OWL, punning. Properly the relation would relate an sdc type to an aggregate  which would imply every member bears an sdc of that type. That would be cleaner than "of the same type". The inverse relation (easier to name) might be 'members bear an instance of' as in aggregate-of-red-things-1 'members bear an instance of' red-quality
I assume the domain problem  you are referring to is that domain is SDC or GDC but definition says only SDC.
Yes, there is a problem with the definition in that "being of the same type" is trivially satisfied in that everything is an instance of entity and so "is the same type". Would need to say something that said that makes clear you have to be all the same types
It's temporally ambiguous as well, as instance-of is time indexed. So given the definition it could mean members bear instances of the same e.g. quality type at the same time, or at completely different times, or something in between.

@alanruttenberg: Yeah, I'd definitely be interested in how it's used too. I wouldn't be surprised if folks used it in a way consistent with what 'inheres in aggregate' is naturally taken to mean (i.e., a range restriction on inheres in). Incidentally, Cameron and I are dealing with a similar issue over on #145.
The domain problem partially consists in the fact that the definition says only SDC but also of the fact that the domain of inheres in is SDC.
I agree with the problems with the definition you identified. Also:

The use of variables is sloppy. 'z' appears out of the blue without any quantifier binding it.
The definition never actually states that z is a member part of y.

I believe I'd planned on raising some of these issues with the definition but held off because Mark and I were going back and forth over the use of 'instance of' in object property definitions over in #259. (I was arguing that if class definitions could get away with not using 'instance of'--and instead using 'is'--object property definitions should too.)

I think I'll close this issue since the original issue was resolved, and I too mistook 'inheres in aggregate' as a subclass until I read the definition closer.


always remove key addedParameters

Because swagger says that this is not a valid key to have in your swagger config.

Managed to sort out CI and have merged the PR in, thanks for the help!


Adds command aad sp list, Closes #2461

Closes #2461

ready to merge 🚀 (remember to adjust a bit before merging 😉)

@nicodecleyre one tiny detail before we merge 👍. Thank you for your awesome work and for sticking with us 😉. You rock 🤩

ready to merge 🚀

merged manually. Awesome work 👏


Can not add this package to Xcode 16

When trying to add this package to a new project in Xcode 16, I receive the following error

@sebsto Hi, can you please paste the full error message for this issue? We are investigating to reproduce locally.
Does it match something like the following?
Failed to resolve dependencies Dependencies could not be resolved because package 'amazon-location-mobile-tracking-sdk-ios' is required using a stable-version but 'amazon-location-mobile-tracking-sdk-ios' depends on an unstable-version package 'amazon-location-mobile-auth-sdk-ios' and root depends on 'amazon-location-mobile-tracking-sdk-ios' 0.2.1.

We were able to reproduce the issue with Xcode 15 as well, so it is not specific to XCode 16. There is a workaround to specify the package version as Branch instead of Up to Next Major Version, but we are still investigating the reason why specifying it by version is failing to resolve. Will update on this issue once we know more.

Using branch = main works for the auth package but not for the tracking package.

@sebsto We've just released v0.3.1 of the Auth library that should fix the error you reported. Thanks for making us aware of the issue!

I can confirm that we can now add version 0.3.1 to an Xcode 16 project - thank you


Unable to extract course idation ..

__  / /  ____ ___  __  __      __/ / /
/ / / / __  / _ / __ ` / / / // __  / /
/ // / // /  / / / / / / /_/ // // / /
_,/_,_/_// // //_, /      _,//
/___/
Version : 0.4
Author  : Nasir Khan (r0ot h3x49)
Github  : https://github.com/r0oth3x49
[*] : Trying to login as (abc@xyz.com)...
[+] : Logged in successfully.
[-] Unable to extract course idation ..

@rahulnautiyal this is already fixed check this issue #145

But i have the latest code, i took it yesterday itself, with my credentials i am able to download where as from my friends credentials i am not able to download videos.

Not work for me.
[*] : Trying to login as (mymailxxx@gmail.com)... [+] : Logged in successfully. [-] Unable to extract course idation ..
. udemy-dl version : 0.4

Python 2.7.12
Install pyOpenSSL from source (also from pip)
. Ubuntu 16.04 LTS

Same here.

Same here too

Same error.

Same error still happening today at November 9 2018 after installing pyOpenSSL

@Kronosneko  Install everything from scratch with the latest versions - python,pip,requirments,udemy-dl then logout of udemy , clear browser cache , login back to udemy.Should work ok after that - make sure to wait 3-5 minutes between downloads.