Updating Spanish Lang Pack gives an error

Azure Data Studio Version: 1.29.0

Steps to Reproduce:

Click update on installed lang pack extension (Spanish in this case)

Expected: Update works
Actual: Update fails

@smartguest could you please take a look at why this is happening?

@kburtram I am unable to reproduce this by installing the older lang packs from the extensions archive (or even the 1.26.1 one that I sent you a while ago) and it automatically updates without any issue besides requiring a restart. Can you try again with another ADS client on another computer with an older Spanish lang pack installed? For reference here is a video showing what is going on on my side.
https://user-images.githubusercontent.com/18018452/120363077-9852ba80-c2c0-11eb-843b-b7f4a867e96d.mp4


ocamlPackages.dns: 5.0.1 → 6.1.4 & related updates

Description of changes
Compatibility with recent cstruct.
https://github.com/mirage/ocaml-dns/blob/v6.1.4/CHANGES.md#v614-2022-01-11
https://github.com/mirage/ocaml-conduit/blob/v5.1.0/CHANGES.md#v510-2022-03-02
https://github.com/mirage/ocaml-cohttp/blob/v5.0.0/CHANGES.md#v500-2021-12-15
cc maintainer @alexfmpe (conduit)
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.11 Release Notes (or backporting 22.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

@GrahamcOfBorg build comby dune-release jackline ligo liquidsoap


Nativescript-feedback fix feedback.hide promise resolving

Fixed the promise resolve on the hide functionality for Android.
feedback.hide can now successfully be promise chained with show on Android.

Perfect, thanks!


org.glassfish.jersey.internal.Errors Parameter 1 of type FooResource is not resolvable to a concrete type

This is a kotlin project using dropwizard 1.3.0
I have some resources with constructors with abstract parameters.
FooResource(private val repository: Repository<String,ByteArray>){
    \\...
}

Where Repository is an Interface
I get a bunch of warnings like:
5:09:40.108 [main] [] WARN  org.glassfish.jersey.internal.Errors - The following warnings have been detected: WARNING: Parameter 1 of type com.foo.Repository<? su
per java.lang.String, byte[]> from public com.foo.FooResource(com.foo.Repository<? super java.lang.String, byte[]>) is n
ot resolvable to a concrete type.

But the program works fine.
I assume this warning has something to do with the supported DI framework / IoC containers, but I use manual injection and don't care about this.
Why is this warning being logged?
How do I disable this check?
UPDATE: I think this has to do with kotlin adding a wildcard to String

I'm getting almost the same problem.
WARN   [22:06:12.763] [main] o.g.j.i.Errors -  The following warnings have been detected: WARNING: Parameter authFilterClass of type java.lang.Class<? extends javax.ws.rs.container.ContainerRequestFilter> from private final java.lang.Class<? extends javax.ws.rs.container.ContainerRequestFilter> io.dropwizard.auth.AuthDynamicFeature.authFilterClass is not resolvable to a concrete type.

@novaterata @hheg Please provide a minimal example we can use to reproduce the issue.

I see the same warning as @hheg, in a plain Java project.
Here is a minimal test project that uses the same code found in the Authentication chapter of the documentation.
dropwizard-test1.zip
./gradlew installDist
./build/install/dw-test/bin/dw-test
You shoud see the warning in the logs.

+1
Same here. I also used the code snippets about Authentication in the docs.

+1
I'm getting the same warning with a Java 8 project using Dropwizard 1.3.0 and 1.3.1. The authentication is implemented according to the OAuth2 example in the docs.

+1

+1

Still seeing this warning with v1.3.3 on Java 8.

The move to v1.3.3 eliminated these warnings for my projects. Can you share a java 8 repo that is a complete dropwizard project that minimally reproduces this issue?

Sorry false alarm my bad.. imported module for swagger is importing v1.3.1 dependancies for auth. assets, and views. Tested with refreshed dependancies for module on DW v1.3.3 and warnings have vanished.
For reference repo can be found here -> https://github.com/cuzz22000/dropwizard-ornament

Excellent, Java 10 / Kotlin users, let us know if you're still experiencing this warning with v1.3.3.

Kotlin user and OP. I am still experiencing this.
On Thu, Jun 14, 2018, 7:32 PM Nick Babcock<EMAIL_ADDRESS>wrote:

Excellent, Java 10 / Kotlin users, let us know if you're still
experiencing this warning with v1.3.3.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/dropwizard/dropwizard/issues/2307#issuecomment-397468962,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABlGHYIXYm3HvzCTX2PGCtmLlcSbOjiQks5t8vKfgaJpZM4SpTfo
.

dropwizard-2307.zip
Finally got around to creating a repo project. Just run with gradlew run and you'll see the warning in the logs

@novaterata The problem seems to be the definition of the interface Repository, or more specifically the generic parameters and the byte code the Kotlin compiler generates from that.
The following diff "solves" the warning from Jersey (by making the first generic parameter K less precise):
--- src/main/kotlin/Repository.kt.orig	2018-06-19 18:45:51.000000000 +0200
+++ src/main/kotlin/Repository.kt	2018-06-19 18:46:04.000000000 +0200
@@ -1,4 +1,4 @@
-interface Repository<in K, V> {
+interface Repository<K, V> {
     operator fun set(key: K, metadata: Map<String, String>, value: V)
     operator fun get(key: K): V
 }

@joschi Thanks, I'll try it

So, In addition to the use of  covariant Generics (in keyword) causing this in Kotlin, The use of functional type, e.g. K -> V, (UriInfo, String) -> URI, etc. , Will also result in the warning. I got around this by replacing my injected functional interfaces with explicit interface implementations. It's ugly, but a simple workaround. I'll close for now even though it still seems like a bug somewhere.

@novaterata I'm not sure it is a real bug and not some incompatibility between the Java and the Kotlin type systems (generics). With Jersey being a Java framework without explicit support for Kotlin, that might pose a problem.

I'm just encountering this myself with the following resource:
@Path("/event-category")
@Produces(MediaType.APPLICATION_JSON)
class EventCategoryResource(
    val clock: Clock,
    val eventCategoryDAOFactory: (UUID) -> EventCategoryDAO
) {

Specifically, the warning is,
WARN   [2019-08-02 19:31:25,879 | -]  org.glassfish.jersey.internal.Errors: The following warnings have been detected: WARNING: Parameter 2 of type kotlin.jvm.functions.Function1<? super java.util.UUID, ? extends com.example.rest.db.dao.organization.EventCategoryDAO> from public com.example.rest.resources.external.EventCategoryResource(java.time.Clock,kotlin.jvm.functions.Function1<? super java.util.UUID, ? extends com.example.rest.db.dao.organization.EventCategoryDAO>) is not resolvable to a concrete type.

Is this warning harmful? What are the negative ramifications here?

Here's a list of our Dropwizard dependencies, in case it's helpful:

Sorry it's been awhile. I think it is harmful, but I don't remember why. I
think all you have to do to avoid it, is not use a default value for that
second parameter. Just inject the lambda.
On Fri, Aug 2, 2019, 4:31 PM Michael Holler<EMAIL_ADDRESS>wrote:

I'm just encountering this myself with the following resource:
@Path("/event-category")
@Produces(MediaType.APPLICATION_JSON)
class EventCategoryResource(
val clock: Clock,
val eventCategoryDAOFactory: (UUID) -> EventCategoryDAO
) {
Specifically, the warning is,
WARN   [2019-08-02 19:31:25,879 | -]  org.glassfish.jersey.internal.Errors: The following warnings have been detected: WARNING: Parameter 2 of type kotlin.jvm.functions.Function1<? super java.util.UUID, ? extends com.example.rest.db.dao.organization.EventCategoryDAO> from public com.example.rest.resources.external.EventCategoryResource(java.time.Clock,kotlin.jvm.functions.Function1<? super java.util.UUID, ? extends com.example.rest.db.dao.organization.EventCategoryDAO>) is not resolvable to a concrete type.
Is this warning harmful? What are the negative ramifications here?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/dropwizard/dropwizard/issues/2307?email_source=notifications&email_token=AAMUMHKU6YYWE53IDDBFGHDQCSKTZA5CNFSM4EVFG7UKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD3OYUCI#issuecomment-517835273,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAMUMHPPA7PLECBC6NK4A2DQCSKTZANCNFSM4EVFG7UA
.

Oh sorry again. Just realized that was the type signature, not a default
value. I think you need to use a named Interface instead of the functional
type.
On Fri, Aug 2, 2019, 4:37 PM Charles Ritchea<EMAIL_ADDRESS>wrote:

Sorry it's been awhile. I think it is harmful, but I don't remember why. I
think all you have to do to avoid it, is not use a default value for that
second parameter. Just inject the lambda.
On Fri, Aug 2, 2019, 4:31 PM Michael Holler<EMAIL_ADDRESS>wrote:

I'm just encountering this myself with the following resource:
@Path("/event-category")
@Produces(MediaType.APPLICATION_JSON)
class EventCategoryResource(
val clock: Clock,
val eventCategoryDAOFactory: (UUID) -> EventCategoryDAO
) {
Specifically, the warning is,
WARN   [2019-08-02 19:31:25,879 | -]  org.glassfish.jersey.internal.Errors: The following warnings have been detected: WARNING: Parameter 2 of type kotlin.jvm.functions.Function1<? super java.util.UUID, ? extends com.example.rest.db.dao.organization.EventCategoryDAO> from public com.example.rest.resources.external.EventCategoryResource(java.time.Clock,kotlin.jvm.functions.Function1<? super java.util.UUID, ? extends com.example.rest.db.dao.organization.EventCategoryDAO>) is not resolvable to a concrete type.
Is this warning harmful? What are the negative ramifications here?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/dropwizard/dropwizard/issues/2307?email_source=notifications&email_token=AAMUMHKU6YYWE53IDDBFGHDQCSKTZA5CNFSM4EVFG7UKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD3OYUCI#issuecomment-517835273,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAMUMHPPA7PLECBC6NK4A2DQCSKTZANCNFSM4EVFG7UA
.

Thanks for the quick response!

I think you need to use a named Interface instead of the functional
type.

That's disappointing... I'd prefer to use the functional type of course (which is technically an interface itself -- a Function1). Do you mean an interface with no generics at all?
I'd be really interested to understand how this is harmful, though, if you're able to remember.

I believe this is a regression in kotlin maybe that stopped generating
something jersey needed for type validation. Again, it's been awhile, and
it might be fixed on the latest of everything ::shrug:: I don't remember
the harm. Might prevent resource registration, it might just be the
warnings.
On Fri, Aug 2, 2019, 4:42 PM Michael Holler<EMAIL_ADDRESS>wrote:

Thanks for the quick response!
I think you need to use a named Interface instead of the functional
type.
That's disappointing... I'd prefer to use the functional type of course
(which is technically an interface itself -- a Function1). Do you mean an
interface with no generics at all?
I'd be really interested to understand how this is harmful, though, if
you're able to remember.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/dropwizard/dropwizard/issues/2307?email_source=notifications&email_token=AAMUMHNZAROHGO5E575JDZLQCSL4ZA5CNFSM4EVFG7UKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD3OZLNQ#issuecomment-517838262,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAMUMHIWNUAREFJSA3GSRC3QCSL4ZANCNFSM4EVFG7UA
.


not loading correct image sizes and not displaying on safari

it dose not seam to be loading in the right image sizes i am pretty sure its not caching as i have turd it off and tested it after clearing all browser data plus the load times are the same for both screen sizes the images also do not display on safari desktop browser but do on mobile.

If it is working on my demo page, I really need more information that helps me to reproduce the problem.

environment
So what is your markup? What did you include in your page? (only lazysizes core or some plugins/polyfills)? Do you have a test case? Give me a link or mail me one.

What happens?

What should happen?

I have same problem.
Latest safari.
I use owl carousel, inside background images.

// Another code

url }}"
        data-bgset="/uploads/banners/grand/{{ $banner->path_phone }} [(max-width: 640px)] |,
        /uploads/banners/grand/{{ $banner->path_tablet }} [(max-width: 940px)] |,
        /uploads/banners/grand/{{ $banner->path_desktop }}" data-sizes="auto">

@codev0
Here is a simplified testcase of your markup:
https://jsfiddle.net/trixta/cycp1cda/7/embedded/result/
It works for me. Can you either give me a test case, where it is not working or share your hole project? Otherwise I can't help.

@aFarkas
Thanks for response.
My case https://jsfiddle.net/cycp1cda/8/embedded/result/

@codev0
You have set the wrapper element to display: none; As long as this is invisible the image doesn't start to load.
As soon as you remove display: none; everything works as expected.

hey sorry for not responding i had to find a fix fast and ended up just making my own JS function to achieve the same effect but thank you very much for your speedy reply and sorry for being crap.

@aFarkas If you take a look at the fiddle you set up the bgset plugin is currently not working in Safari 9.1. http://jsfiddle.net/trixta/bfqqnosp/embedded/result/
I can also e-mail you a site that is currently using the plugin and it is currently loading the lowest res image.
Would love to get this working since this is such a great plugin.

@RegisBiron
Yeah, please mail me. I can't reproduce your issue with the fiddle in Safari 9.1. I can only see that it needs some time to adjust to viewport changes.


Some keyboard shortcuts with ALT don't work - using Cubase Pro 10 with mac keyboard

Microsoft PowerToys version
0.57.2
Running as admin

[X] Yes

Area(s) with issue?
Keyboard Manager
Steps to reproduce
PowerToysReport_2022-04-30-15-02-14.zip
✔ Expected Behavior
"command" key (switched from "option" to work as ALT key) should work in combination with other physical keys on the keyboard
E.G.: ALT+M mutes items, ALT+R removes empty tracks, and so on
❌ Actual Behavior
If i turn off power toys, option+m mutes the selected item correctly. If I switch "command" and "option" keys, I can only use ALT+TAB  ALT+mouse click or (unexpectedly) ALT+I.
Other Software
Cubase 10.5 NOT running as admin.

Not sure why this wouldn't work with this specific software, but it's possible that it's detecting the keys before we have the chance to modify them.


install adam 0.19 error!

install by  mvn clean package -DskipTests
error:
``
[INFO]
[INFO] ADAM_2.10 .......................................... SUCCESS [  8.800 s]
[INFO] ADAM_2.10: Core .................................... SUCCESS [02:09 min]
[INFO] ADAM_2.10: APIs for Java ........................... SUCCESS [ 14.706 s]
[INFO] ADAM_2.10: CLI ..................................... FAILURE [  0.332 s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 02:33 min
[INFO] Finished at: 2016-04-15T21:02:48+08:00
[INFO] Final Memory: 51M/377M
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal pl.project13.maven:git-commit-id-plugin:2.2.0:revision (default) on project adam-cli_2.10: .git directory could not be found! Please specify a valid [dotGitDirectory] in your pom.xml -> [Help 1]
[ERROR]
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR]
[ERROR] For more information about the errors and possible solutions, please read the following articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoExecutionException
[ERROR]
[ERROR] After correcting the problems, you can resume the build with the command
[ERROR]   mvn <goals> -rf :adam-cli_2.10

and pom.xml in adam-cli:
      </plugin>
      <plugin>
        <groupId>pl.project13.maven</groupId>
        <artifactId>git-commit-id-plugin</artifactId>
        <executions>
          <execution>
            <goals>
              <goal>revision</goal>
            </goals>
          </execution>
        </executions>
      </plugin>

I don't how to solve it,please help me! thanks.

I have solve the problem.

Is this still an issue @xubo245? Can we close it?

@ryan-williams ok,close it

Thanks @xubo245!


Update uif-table to render HTML table markup

Fabric's 2.3.0 release added the ability to use HTML markup for building tables https://github.com/OfficeDev/Office-UI-Fabric/pull/367 instead of the original method of using DIV elements. This is better for accessibility and as such our table should be updated to use HTML table elements rather than DIV.

Let me pick it up 😄


renaming suggestion for the the LiteCycle methods

I think naming those methods as the lifeCycle component did, will be more readable, in short you don't need "Invoke" and "Update"suffixes, from library client side he has to remember, that there is two methods.
on the other side I prefer overloading. so to get into code the new suggestion would be like this
//Current naming
public final B onCreateInvoke(Consumer<T> action) {
        this.onCreate.add(action);
        return (B) this;
    }

public final B onCreateUpdate(Function<T, T> action) {
        this.onCreate.add(action);
        return (B) this;
    }

//Suggested naming
public final B onCreate(Consumer<T> action) {
        this.onCreate.add(action);
        return (B) this;
    }

public final B onCreate(Function<T, T> action) {
        this.onCreate.add(action);
        return (B) this;
    }

//current code in client side
LiteCycle.with(10)
                .forLifeCycle(this)
                .onCreateInvoke(i -> Log.e("LiteCycle", "initial value " + i))
                .onCreateUpdate(i -> i + 1)
                .onCreateInvoke(i -> Log.e("LiteCycle", "onCreate() invoked " + i))
...

//after applying the renaming
LiteCycle.with(10)
                .forLifeCycle(this)
                .onCreate((Consumer<Integer>) i ->  Log.e("LiteCycle", "initial value " + i))
                .onCreate(i -> i + 1)
                .onCreate((Consumer<Integer>) i -> Log.e("LiteCycle", "onCreate() invoked " + i))
...

Hi @MohamedISoliman ,
If we used overloading, it will be very painful when using method references, since the user should cast the passed method reference every time, I'm trying to make things easier when using it ... you can fork the library and make this change and try it out in a poc and let me know how it feels ;)
Thanks for your feed back


Playback fails from youtube music

What version of Music Assistant has the issue?
2023.6.0b3
The problem
Playback from youtube music fails
How to reproduce
Attempt to play any music from youtube music
Relevant log output
2023-09-27 15:39:21.650 INFO (ThreadPoolExecutor-0_7) [pychromecast.controllers] Receiver:Launching app CC1AD845
2023-09-27 15:39:50.215 ERROR (MainThread) [aiohttp.server] Error handling request
Traceback (most recent call last):
File "/usr/local/lib/python3.11/site-packages/aiohttp/web_protocol.py", line 433, in _handle_request
resp = await request_handler(request)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/local/lib/python3.11/site-packages/aiohttp/web_app.py", line 504, in _handle
resp = await handler(request)
^^^^^^^^^^^^^^^^^^^^^^
File "/usr/local/lib/python3.11/site-packages/music_assistant/server/controllers/streams.py", line 473, in serve_queue_item_stream
streamdetails = await get_stream_details(self.mass, queue_item=queue_item)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/local/lib/python3.11/site-packages/music_assistant/server/helpers/audio.py", line 268, in get_stream_details
streamdetails: StreamDetails = await music_prov.get_stream_details(
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/local/lib/python3.11/site-packages/music_assistant/server/providers/ytmusic/init.py", line 498, in get_stream_details
url = await self._parse_stream_url(stream_format=stream_format, item_id=item_id)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/local/lib/python3.11/site-packages/music_assistant/server/providers/ytmusic/init.py", line 797, in _parse_stream_url
signature = await self._decipher_signature(
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/local/lib/python3.11/site-packages/music_assistant/server/providers/ytmusic/init.py", line 823, in _decipher_signature
self._cipher = await asyncio.to_thread(_decipher)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/local/lib/python3.11/asyncio/threads.py", line 25, in to_thread
return await loop.run_in_executor(None, func_call)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/local/lib/python3.11/concurrent/futures/thread.py", line 58, in run
result = self.fn(*self.args, **self.kwargs)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/local/lib/python3.11/site-packages/music_assistant/server/providers/ytmusic/init.py", line 818, in _decipher
cipher = pytube.cipher.Cipher(js=ytm_js)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/local/lib/python3.11/site-packages/pytube/cipher.py", line 43, in init
self.throttling_plan = get_throttling_plan(js)
^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/local/lib/python3.11/site-packages/pytube/cipher.py", line 411, in get_throttling_plan
transform_plan_raw = find_object_from_startpoint(raw_code, match.span()[1] - 1)
^^^^^^^^^^
AttributeError: 'NoneType' object has no attribute 'span'
2023-09-27 15:39:50.235 WARNING (Thread-6) [music_assistant.providers.chromecast] Load media failed: 2 - error code: 104
Additional information
Playback from other sources such as radio works
What version of Home Assistant Core are your running
2023.09.2
What type of installation are you running?
Home Assistant OS
On what type of hardware are you running?
Generic x86-64 (e.g. Intel NUC)

A PR to fix this has been done. Will be in the next HA release. Estimate for that is not yet known. Thanks for your patience.

Has this been fixed in b74?

yes this has been fixed in beta74.


How to get the video of demo?

How can I get the video as your provided as follows? To get the world coordinate and have the trajectory.
[2020/08/14] We achieve real-time 3D pose estimation. [video]
[2020/10/15] We achieve real-time online 3D skeleton-based action recognition with a single RGB camera. [video]

Hi~
The trajectory in our video is the virtual world coordinates converted from the image coordinates. For the specific conversion method, please refer to #9.

So how can I use the "revise_skes_real_time”, what's the value of width should I set?

Hi~
The value of width is of little reference, just for better rendering animation.


Update documentation (UG and DG) for room allocation features

What this does
This PR updates the documentation for room allocation features in the UG and DG implemented by me.

Part of #123.
How to test

Pull this branch to your local repo.
Navigate to the docs folder.
Run bundle exec jekyll serve.

Notes

N/A

Codecov Report

Merging #124 into master will decrease coverage by 0.08%.
The diff coverage is 0.00%.

@@             Coverage Diff              @@
##             master     #124      +/-   ##
============================================
- Coverage     68.73%   68.64%   -0.09%
- Complexity      922      923       +1
============================================
  Files           148      148
  Lines          3176     3180       +4
  Branches        371      374       +3
============================================
  Hits           2183     2183
  Misses          875      875
- Partials        118      122       +4

Impacted Files
Coverage Δ
Complexity Δ

...ava/seedu/resireg/model/allocation/Allocation.java
67.64% <0.00%> (-9.02%)
17.00 <0.00> (+1.00)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b32dac6...1313da5. Read the comment docs.


[format] Supports estimation of data size in memory for better control of file size.

Purpose
Supports estimation of data size in memory for better control of file size.
NOTE: The calculation result is an estimated value, so there is no strong limit on the file size.
Linked issue: close #1210
Tests
Extended the format type in org.apache.paimon.io.RollingFileWriterTest to support testing for avro/orc/parquet.
API and Format
No.
Documentation
No.

How large can a file be restricted now. The previous result was 180MB to 220MB (target-file-size is 128MB).

I wrote a simple test: use RollingFileWriter to continuously write 10 million data of type <Int, Varchar(32), Binary(16), BigInt>.
For parquet and orc format, both the old and new rollingFile methods are very close to the targetFileSize.  But for the ORC format, since the size of the stripe in the memory will greatly affect the final size of the file, this is very dependent on the compression effect, and since our test data is random, the compression effect is not good.

format
old
new

ORC
181.4 MB
152.4 MB

PARQUET
128.03 MB
128.03MB

AVRO
128.1 MB
128.1 MB

@liming30 Thanks!


Handle "strict" in behat configuration file

Follows https://github.com/Behat/Behat/pull/1501 and #1512
Implement the fact that we can set the strict settings in the behat.yml in config: section.

It would be great if you could also submit a PR to add the stop on failure & strict config options to https://github.com/Behat/docs/blob/v3.0/user_guide/configuration.rst? Thanks

It would be great if you could also submit a PR to add the stop on failure & strict config options to<EMAIL_ADDRESS>Thanks

@acoulton yes, it's on my mind, I just wanted to add strict mode first to avoid making two different PR on the documentation 👍

@acoulton I did change to more modern PHP code. I converted the the StopOnFailure handler from #1501 as it has not been released in a version for now.

It would be great if you could also submit a PR to add the stop on failure & strict config options to<EMAIL_ADDRESS>Thanks

https://github.com/Behat/docs/pull/155

@jdeniau I took a new look at your PR and thought of something: instead of handling the strict flag and config setting in the stop on failure controller and handler, why not just pass the result interpreter to the handler and use it to check the interpretation? This would provide a better separation of concerns as all the handling of the strict flag and config setting would be just in the strict controller and handler. What do you think?

@carlos-granados Well I am not really confident with ResultInterpreter because it does register multiple interpretations, and because it does "Interprets result as a UNIX return code (0 for success, 1 for failure)." : it seems less readable to check === 0 instead of === true.
I will try an implementation in another PR 🤞

@carlos-granados You were right, this seems to be a way better implementation: https://github.com/Behat/Behat/pull/1516

Thanks for the contribution!
Please do not wait on my review and/or approval, I haven't been able to dig deep enough to fully understand what is going on. I trust @acoulton @carlos-granados when they approve this.

Closed in favour of #1516


Puppet module sees bin/plugin exception as a successful run

I was working on what I thought was a clean system, but it turns out java-1.6.0-openjdk was installed.  Because ES doesn't like 1.6.0, bin/plugin fails with this message:
    [root@ca6-06:/usr/share/elasticsearch]# bin/plugin  http://nexus/nexus/content/repositories/releases/ntent/ntent-boilerplate/1.0.0/ntent-boilerplate-1.0.0.zip
Exception in thread "main" java.lang.UnsupportedClassVersionError: org/elasticsearch/plugins/PluginManagerCliParser : Unsupported major.minor version 51.0
	at java.lang.ClassLoader.defineClass1(Native Method)
	at java.lang.ClassLoader.defineClass(ClassLoader.java:643)
	at java.security.SecureClassLoader.defineClass(SecureClassLoader.java:142)
	at java.net.URLClassLoader.defineClass(URLClassLoader.java:277)
	at java.net.URLClassLoader.access$000(URLClassLoader.java:73)
	at java.net.URLClassLoader$1.run(URLClassLoader.java:212)
	at java.security.AccessController.doPrivileged(Native Method)
	at java.net.URLClassLoader.findClass(URLClassLoader.java:205)
	at java.lang.ClassLoader.loadClass(ClassLoader.java:323)
	at sun.misc.Launcher$AppClassLoader.loadClass(Launcher.java:294)
	at java.lang.ClassLoader.loadClass(ClassLoader.java:268)

Could not find the main class: org.elasticsearch.plugins.PluginManagerCliParser. Program will exit.

The elasticsearch module, however, registers:
Dec 15 09:17:52 ca6-06 puppet-agent[22029]: (/Stage[main]/Profiles::Elasticsearch::Plugins::Ntent-boilerplate/Elasticsearch::Plugin[ntent-boilerplate]/Exec[install_plugin_ntent-boilerplate]/returns) executed successfully
Dec 15 09:17:52 ca6-06 puppet-agent[22029]: (/Stage[main]/Profiles::Elasticsearch::Plugins::Ntent-boilerplate/Elasticsearch::Plugin[ntent-boilerplate]/File[/usr/share/elasticsearch/plugins/ntent-boilerplate/.name]/ensure) change from absent to file failed: Could not set 'file' on ensure: No such file or directory - /usr/share/elasticsearch/plugins/ntent-boilerplate/.name20151215-22029-1u4shbw.lock at 168:/etc/puppet/environments/production/modules/elasticsearch/manifests/plugin.pp

Replacing 1.6 with 1.8 resolved the issue, but the error reporting in this module is wrong.

Hi. I released a new version of the module that should handle this much better.
Could you try that one ?

Oh yeah I can give the new module a shot.  Stand by.

Did it work as expected?

Sorry, I got derailed.  I'll test soon.

no worries. thanks!

Under identical circumstances, the new module version does in fact fail as expected, though not very explicitly.
http://fpaste.org/302883/65401145/
Changing Java version back to 1.8 resolved the issue.  Issue resolved - thanks!

I'll see if it's possible to get back the output from the command when it fails somehow.


How to get API documentation to appear in R?

@David-Fowler I have written documentation for several API endpoints. It appears in insomnia OK, but I'm wondering how we get this documentation to flow through to R Studio, if possible?
siteInfo is one of the endpoints that has documentation.

Ok. Perfect. I have an R package update almost ready which will provide the built in R-studio docs for the API allowing them to be rebuilt as the API itself updates. I may be able to complete this by tomorrow, if not definitely by Monday.


[CXF-8645] Use Bearer as default auth scheme in client and server filter

PR created: https://github.com/apache/cxf/pull/896

Just a note to make sure to run all tests before submitting PRs, as the PR caused a test failure in the STS tests. I'll just fix it locally after merging the PR.


Beeks/enable fk by default

As discussed in https://github.com/craftzdog/react-native-sqlite-2/pull/91, here's the PR to enable foreign key constraints in Android

Thanks, beeks!

landed in v3.2.0 🎉

Awesome, thank you!


Sparse indexing: Can't set to itself

Since update 1.3 I can't change a fancy indexed sparse matrix in-place directly via +=, -= etc. Instead, I have to call .A1 on the right-hand side.
Reproducing code example:

import numpy as np
import scipy.sparse as sp

a = sp.csr_matrix(np.arange(12).reshape((4,3)))
nz = a.nonzero()
a[nz] = a[nz].A1  # Works
a[nz] = a[nz]  # Error
a[nz] += 1  # Error

Error message:

ValueError                                Traceback (most recent call last)
<ipython-input-1-3f27acc27588> in <module>
      5 nz = a.nonzero()
      6 a[nz] = a[nz].A1  # Works
----> 7 a[nz] = a[nz]  # Error

/path/to/lib/python3.7/site-packages/scipy/sparse/_index.py in __setitem__(self, key, x)
    107             x, _ = np.broadcast_arrays(x, i)
    108             if x.shape != i.shape:
--> 109                 raise ValueError("shape mismatch in assignment")
    110             if x.size == 0:
    111                 return

ValueError: shape mismatch in assignment

Scipy/Numpy/Python version information:
1.3.0 1.16.4 sys.version_info(major=3, minor=7, micro=3, releaselevel='final', serial=0)

I believe this is the same issue as gh-10695, which was fixed by gh-10700, which is currently part of the master branch and will be released as part of scipy 1.4.0.
The error no longer appears on master:
In [1]: import scipy.sparse as ss

In [2]: a = ss.rand(5, 4, density=0.5, format='csr')

In [3]: a.A
Out[3]:
array([[0.23017718, 0.        , 0.43185173, 0.80773707],
       [0.2787923 , 0.        , 0.        , 0.87346719],
       [0.31166438, 0.        , 0.60261057, 0.6439705 ],
       [0.        , 0.        , 0.        , 0.        ],
       [0.11345089, 0.        , 0.17125056, 0.        ]])

In [4]: nz = a.nonzero()

In [5]: a[nz]
Out[5]:
matrix([[0.23017718, 0.43185173, 0.80773707, 0.2787923 , 0.87346719,
         0.31166438, 0.60261057, 0.6439705 , 0.11345089, 0.17125056]])

In [6]: a[nz] = a[nz]

In [7]: import scipy

In [8]: scipy.__version__
Out[8]: '1.4.0.dev0+2d6327e'

I just noticed that you call out in-place assignment as well, and I can confirm that's also fixed on master.
Thanks for the well-formed bug report, @klicperajo !


Collapsible code sections

I wonder what's the reason behind placing Confluence Code block with collapsible = true inside Expand block?
This way the following code:

```bash collapse
#!/bin/sh

set -e

exit 0
```

translates to

and ultimately renders to

In order for a user to see contents of the block they should click Click here..., then click Expand source, then (in my case, YMMV) whole section collapses again, and when you click Click here... again the block is ultimately expanded and the code is visible.
Shouldn't just {code ... | collapsible = true} not wrapped with {expand ...} suffice?

Ah, I see.
@tyler-copilot, with what version of Confluence you observed behaviour you mentioned in #58? I'm on 6.4.2 and {code ... | collapsible = true} works as expected for me.

I agree. In newer confluence versions (for me it's 7.13.2) the changes introduced in #58 produce two collapsible boxes. Please check out my PR #179 that reverts it. Judging by what antonalekseev wrote the additional expand macro is not needed for versions >= 6.4.2 (maybe even older) which is already 5 years old. Are you sure you want to support versions that old?

Looks like this has been resolved.


Tenant management page not work on abp 4.3.0

Tenant management page not work on abp 4.3.0

It's seem that ConnectionStringModal.js was removed. in https://github.com/abpframework/abp/commit/eb55d640912026b3544e3cd8a4b1285bdd665aac
I comment out
@*<abp-script src="/Pages/TenantManagement/Tenants/ConnectionStringsModal.js" />*@
and the page is loaded, but some Create funtions still not work.

@wakuflair check this pull request. #31 , it's also fix cannot create new Tenant on sample project.

@dangminhbk
"/Pages/TenantManagement/Tenants/ConnectionStringsModal.js"
This file has been removed in version 4.3

@wakuflair if you have time, please check this pull request #31 .It's also fix cannot create new Tenant on sample project.

Thanks, I'll see it ASAP.

The PR has been merged, thank you guys!


[FEATURE] Plugin description in the .nam file; visable in the plugin

The problem is that descriptions must always be in the filename currently.  Amps can have tons of settings, and differences in hardware (e.g. tubes, output xformers, speakers, cabinets).  While there is a dynamic community for models, most creators don't try to cram all the details of amp settings and hardware into the filename.  Such names could be very long were they to be attempted.
I would hope the amp model creator might have a way to create a text description.  An external editor might be nice, but of course, creators could also just edit the JSON.  Alternately, if it doesn't swell the size of the plugin too much, a rich text description might be nice.  Some users might like to be able to show or hide the description.  Alternately, it might pop up over the existing GUI.
A text file could be distributed with .nam file libraries describing details of the sampling; but this could be tedious while browsing text files from various users.  Having it in the plugin would save the trouble to jump from text file or web page to the next.  One might hope for a way to see models in a list, and then either click on them, or use up and down arrows to not only read the filenames, but the descriptions.
As they begin to be used, it could help users greatly to categorize their models; and also understand them if they wanted the real amp.  With such a feature available, it would encourage creators to describe the amps modeled better.  If an amp were modeled without a particular feature engaged, a user could know that a model with that feature should be asked for or created.

I definitely agree that the file name shouldn't be carrying so much weight. I'm hoping to use the "name" field as what's primarily displayed in the plugin (when it's available).
As far as the other info, I'm hoping for it to (1) be usable in library systems like ToneHunt as well as (2) be displayable in the plugin. Perhaps something like a "?" button for the model. Not sure yet.

The problems with relying on ToneHunt for that info are:

It relies on one being online for it to work, which is not always the case for audio computers, or e.g. laptops at a gig.
It is on a model library basis, not a per model basis.  A per model basis allows the specification of e.g. tone and drive settings per model.

Note that what I have in mind shouldn't be just a single line of text.  I suppose it might be a text box below the current GUI, which might or might not be hideable, or else a tooltop that pops up, giving you a generous amount of time to read it, as you hover over an item in a list, depending on what else gets implemented; but even if it's a text box that's fairly small, there should be enough room to accurately specify all amp, cab and pedal settings.  It needn't be difficult to implement; but have adequate room for description.


305 detailed exception handling inside different filip methods

closes #305

@mwr-ebc Some tests are missing because there are a lot of different requests inside the clients and I didn't have the time to add all of them. Can you maybe help me with that?


Recursion isn't prevented for arrays

The following causes a stack overflow:
var array = [];
array.push(array);
stringifyObject(array);

:+1:


Keyboard PopUp on mobile devices

Hi Daniel,
I was experimenting with this jQuery plugIn as well. The one problem I have with it, and you haven't been able to solve this too, is, that on mobile devices (tested it on Android) the default keyboard is poping up when you focus on the input field. Any idea, how to prevent this behaviour?
Regards,
Christian Rokitta

Hi Christian,
I think I solved it with a simple onfocus="blur();" on the input field. I changed it on my demo app (https://apex.oracle.com/pls/apex/f?p=57743:3). I tested it on iOS and the keyboard is not fading up, can you please test it with Android? Thanks for your hint, tested it by now only on desktop browsers...

Daniel


Doc fix

fix few things
moved get_entity_ai_state to the Deprecated Functions course of the inconsistent name
i was thinking about adding get_entity_move_state for quick replacement, what you think?

i take suggestions for better names then (set/get)_correct_ushabti_af :smile:

Starting variables with an underscore is not a good idea. It's not necessarily disallowed in all contexts here, but sometimes it is and keeping track of all cases where it is and isn't allowed is possibly gonna cause issues some day. And in the case where members previously had the same name it's not a good idea for another reason, namely because those variables most likely refer to separate thing or are used in different context, thus warranting a different name. When we don't know what context that is we should probably do what zapp usually does and name it unknown, e.g. Qilin::_sound_pos could instead be Qilin::sound_pos_unknown

well, it's not like it's unknown, it probably the same cause with all ParticleEmitterInfo that almost all are just named 'particle'

Then name it sound_pos_duplicate. My point is just that there's almost always a better name than _sound_pos


specific copyright garbage text not getting removed

I have copyright garbage (c) uSSg1/2a-N (c) OY+ in the report

and trying to skip this using  /home/user/config/copyright-garbage.yml

But somehow the above garbage text doesnt seem to get removed
I tired adding escape slash behind non alpha numeric characters.
(c) uSSg1\/2a-N (c) OY+
(c) uSSg1/2a\-N (c) OY+
(c) uSSg1/2a-N (c) OY\+
nothing works. How to remove this copyright garbage text (c) uSSg1/2a-N (c) OY+  ?
I have added other copyright garbage it works. only above text seems to not getting removed. Please may I have your help?
Thanks

Please see the CopyrightGarbage class docs:
https://github.com/oss-review-toolkit/ort/blob/25361dd02648e8705bc0e0be3736ce9a09365f6f/model/src/main/kotlin/config/CopyrightGarbage.kt#L28-L32
So the items (in contrast to patterns) are literal strings. Just adding (c) uSSg1/2a-N (c) OY+ should do the trick.

Hi Sebastian,
Thanks for the response. I already tried to add as it is. It didn't work.
That's why I had to raise this issue.
The patterns that I mentioned are the things I tried. Which didn't work as
well.
Regards
Dinesh
On Sun, Dec 10, 2023, 3:41 PM Sebastian Schuberth @.***>
wrote:

Closed #8019 https://github.com/oss-review-toolkit/ort/issues/8019 as
completed.
—
Reply to this email directly, view it on GitHub
https://github.com/oss-review-toolkit/ort/issues/8019#event-11203016232,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABCKH3ZIJ6E4ER3LUQ7JHY3YIXCZJAVCNFSM6AAAAABANWYMKCVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJRGIYDGMBRGYZDGMQ
.
You are receiving this because you authored the thread.Message ID:
@.***>

I already tried to add as it is. It didn't work. That's why I had to raise this issue.

Then why didn't you make it explicit in the report that you also literally tried (c) uSSg1/2a-N (c) OY+? That would have saved both of us time.

The patterns that I mentioned are the things I tried. Which didn't work as
well.

Ok, these are the additional things you tried, not the only ones (like it read to me).
One more thing that comes to my mind is: Where did you copy & paste the literal copyright garbage string from? You should probably not copy it from the PDF document, but from the raw scan ORT result, just to ensure no encoding issues play a role when inserting the literal string to [copyright-garbage.yml](https://github.com/oss-review-toolkit/ort-config/blob/main/copyright-garbage.yml).

Hi @sschuberth
You are right. In raw ort result file the text was like this

(c) uSSg1/2a+-N (c) OY instead of
(c) uSSg1/2a-N (c) OY+ (in the AsciiDoc_disclosure_document.html)
Not sure though why plus symbol + is getting added at the end of asciiDoc_disclosure_document.html
when I added (c) uSSg1/2a+-N (c) OY in copyright-garbage.yml file

now it got removed (in the AsciiDoc_disclosure_document.html)

thanks for the hint.

@dineshr93
In order to add copyright garbage entries to the file I've created some easy workflow which
works really nicely for me.
I suggest giving this a try.
[1] https://github.com/oss-review-toolkit/orthw

Thanks @fviernau  I will try it out.
In ort Assets there is orth-9.0.0.zip file. Is this the same as orthw ?
Does **orthw copyrights ** perform Ort scan internally to get all copyrights for the main project and all it's dependencies?

In ort Assets there is orth-9.0.0.zip file. Is this the same as orthw ?

No, orthw is an additional wrapper script round orth (aka the "helper-cli") that currently needs to be downloaded separately at https://github.com/oss-review-toolkit/orthw.


Remove link to docs

I don’t think there is a docs folder anymore?

There isn't no, we decided at some point to keep them in a docs branch. But we lost that somewhere a long the way. Will generate some HTML docs and put them up.

There isn't no, we decided at some point to keep them in a docs branch. But we lost that somewhere a long the way. Will generate some HTML docs and put them up.


IRGen: Fix reflection metadata for zero-sized enum cases

If an enum has a payload case with zero size, we treat it as an empty case
for ABI purposes. Unfortunately, this meant that reflection metadata was
incomplete for such cases, with a Mirror reporting that the enum value
had zero children.
Tweak the field type metadata emission slightly to preserve the payload
type for such enum cases.
Fixes https://bugs.swift.org/browse/SR-12044 / rdar://problem/58861157.

@swift-ci Please smoke test

@tbkka You might find this interesting too.

Nice.  This will also help with RemoteMirror -- I'm teaching it how to reflect enum cases.

@swift-ci Please smoke test

@swift-ci Please smoke test Linux


Empty repo

Hi,
Is there a particular branch one needs to checkout to find the code?
Thanks,
Susheel

I am also looking for the standalone script to compute the social niche breadth.
Thanks!


⚠ GitLab Server has degraded performance

In 644ca12, GitLab Server (https://gitlab01.its-telekom.eu) experienced degraded performance:

HTTP code: 200
Response time: 6849 ms

Resolved: GitLab Server performance has improved in deae3c0.


model_downloader/common.py: Order all topologies for print_all

Current print_all printing all topologies in non-sorted manner.
Sorted all topologies for print_all printing.
Signed-off-by: Yeoh Ee Peng<EMAIL_ADDRESS>

@epyeoh could you please change the target branch to opencv:develop? We're in process of R2 preparations, and master contents is going to be locked for few weeks.

Changed the branch from master to develop @kchechil

@epyeoh could you please also resolve conflicts?

@kchechil I had create a new pull request (#184) where it was based on the branch: develop. Consider this pull request not needed anymore.


Remove wrong version of foldi

Somehow, the correct version of foldi for the mask wasn't actually being used.
Removed the old, invalid version, fixed the name of the correct one.
Closes #1563.

There's a unit test that should have caught this. Looking into why it wasn't caught.

Updated the test to use foldi, and in master, that test did fail, succeeds in this branch.


Feature/suraj

Please always provide the GitHub issue(s) your PR is for, as well as test URLs where your change can be observed (before and after):
Fix #
Test URLs:

Before: https://main--godrej-capital-internal--divanshu-techx.hlx.live/
After: https://--godrej-capital-internal--divanshu-techx.hlx.live/

URL for testing:

https://feature-suraj--godrej-capital-internal--techx-consulting.hlx.page/

URL for testing:

https://feature-suraj--godrej-capital-internal--techx-consulting.hlx.page/

URL for testing:

https://feature-suraj--godrej-capital-internal--techx-consulting.hlx.page/


Looks like Connection adder threads keeps retrying indefinitely in case of connection is not reachable due to some reasons

Environment
HikariCP version: 3.3.1
JDK version     : 1.8.0_111
Database        : Oracle
Driver version  : OJDBC 6

Lets assume that, I have an Oracle connection and It was working when the Pool was created.
In the mean time, becuase of the Network connectivity, oracle host machine is not reachable.
Now, in the logs i was only able to see the indefinite HikariCP connection adder logs with failure exception.
Ideally, adder thread should stop retrying affter definite attempts and mark the pool as dead.

The connection attempts never stop.  The assumption is that the database connectivity will be restored eventually.
There is no such concept as a pool being marked “bad”.  Presumably you are monitoring HikariCP and the database, and your application or monitoring system can react appropriately.


Setup EPP to be available on elifesciences.org/reviewed-preprints/

Description
We need to configure the journal infrastructure to proxy /reviewed-preprints to the EPP frontend application.

Replaced by https://github.com/elifesciences/issues/issues/7773


Fix subpage lookup bug. Fixes #214.

This fixes the case described by @toonetown in #214 . It does not reintroduce case insensitiveness, as that was never intended behavior (all the docs use _Sidebar.md etc.).  I'm curious to see how this solution will perform on a large repository.

No real comments, looks clean! Also wondering about the performance. Have you tried profiling it?
The previous implementation had a next if instance_variable_get(subpagename) to speed up one of the loops -- not sure if there is ever actually a case in which the subpage lookup is called while one of the subpages is already set , but if there is, would it help to have something similar in this implementation?
Oh, and do we need to improve the test suite to deal with @toonetown's cases?

Have you tried profiling it?

Only by looking at total page load times of a repo with 4000 commits. There doesn't seem to be a big speed difference there (if anything, the new implementation seems to be slightly faster, unless the path is highly nested).

The previous implementation had a next if instance_variable_get(subpagename) to speed up one of the loops -- would it help to have something similar in this implementation?

Different logic. That case does not occur in this implementation.

Oh, and do we need to improve the test suite to deal with @toonetown's cases?

Ideally yes, but I don't think I'll have time to update the test suite on short notice. If you want to have a stab at it, please do!

👍

I'm in favor of merging this into master, since it fixes two bugs that were introduced with the previous implementation of find_sub_pages. Okay @dometto ?

Sure, go ahead!


Enable to get Volume Quota details in OpenStack driver

Enable to get Volume Quota details in OpenStack driver
Description
Implements #1585
Status

done, ready for review

Checklist (tick everything that applies)

[x] Code linting (required, can be done after the PR checks)
[ ] Documentation
[x] Tests
[x] ICLA (required for bigger changes)

Codecov Report

Merging #1586 (b08e67a) into trunk (ea364c5) will decrease coverage by 0.00%.
The diff coverage is 73.52%.

@@            Coverage Diff             @@
##            trunk    #1586      +/-   ##
==========================================
- Coverage   83.01%   83.00%   -0.01%
==========================================
  Files         394      394
  Lines       84999    85033      +34
  Branches     9040     9045       +5
==========================================
+ Hits        70558    70583      +25
- Misses      11374    11379       +5
- Partials     3067     3071       +4

Impacted Files
Coverage Δ

libcloud/compute/drivers/openstack.py
85.54% <68.00%> (-0.34%)
:arrow_down:

libcloud/test/compute/test_openstack.py
94.43% <88.88%> (-0.03%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ea364c5...b08e67a. Read the comment docs.

@Kami this PR is here for a long time, can anybody review it?


Accessibility add links name to icons

/assign
github icon

Hi @Arhell Can you remind me which icon needs the link name?

Hi @Arhell Can you remind me which icon needs the link name?

Here and https://github.com/karmada-io/website/pull/496
Corrected using the example of the main site https://docusaurus.io/

Linked to some docs I just googled:

What the aria-label is: https://www.w3.org/TR/wai-aria/#aria-label
Why do I need aria-label and how should I use it?  https://stackoverflow.com/questions/22039910/what-is-aria-label-and-how-should-i-use-it

It makes sense to have the aria-label because it would help people(like, blind people) understand the button by using assistive technology. (Although I never received feedback that someone needs it yet)
My question is, is this the only place need to add the label?

Linked to some docs I just googled:

What the aria-label is: https://www.w3.org/TR/wai-aria/#aria-label
Why do I need aria-label and how should I use it?  https://stackoverflow.com/questions/22039910/what-is-aria-label-and-how-should-i-use-it

It makes sense to have the aria-label because it would help people(like, blind people) understand the button by using assistive technology. (Although I never received feedback that someone needs it yet)
My question is, is this the only place need to add the label?

I understand you, I apologize for not giving a specific answer as you wrote, yes, only this place and if more icons are added there in the future, slack for example, then do the same.

OK, that makes sense to me.


update the istio/api sha

istio/vendor https://github.com/istio/vendor-istio/pull/48

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: linsun
Assign the PR to them by writing /assign @linsun in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@guptasu: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
f2d4151d6d3fc4ccf3a7e386eb65e97702aaf4c0
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@guptasu: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
f2d4151d6d3fc4ccf3a7e386eb65e97702aaf4c0
link
/test istio-unit-tests

prow/istio-presubmit.sh
f2d4151d6d3fc4ccf3a7e386eb65e97702aaf4c0
link
/test istio-presubmit

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@guptasu: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-presubmit.sh
f2d4151d6d3fc4ccf3a7e386eb65e97702aaf4c0
link
/test istio-presubmit

prow/istio-unit-tests.sh
d115bfaed7017ace8a6345c1a283fb1c559e870c
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@guptasu: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
d115bfaed7017ace8a6345c1a283fb1c559e870c
link
/test istio-unit-tests

prow/istio-presubmit.sh
d115bfaed7017ace8a6345c1a283fb1c559e870c
link
/test istio-presubmit

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@guptasu: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-presubmit.sh
d115bfaed7017ace8a6345c1a283fb1c559e870c
link
/test istio-presubmit

prow/istio-unit-tests.sh
a3c2b7d611eef885f4261ff8263c8d8def02771e
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@guptasu: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
a3c2b7d611eef885f4261ff8263c8d8def02771e
link
/test istio-unit-tests

prow/istio-pilot-e2e.sh
a3c2b7d611eef885f4261ff8263c8d8def02771e
link
/test istio-pilot-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@guptasu: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
a3c2b7d611eef885f4261ff8263c8d8def02771e
link
/test istio-unit-tests

prow/istio-pilot-e2e.sh
a3c2b7d611eef885f4261ff8263c8d8def02771e
link
/test istio-pilot-e2e

prow/istio-pilot-e2e-v1alpha3.sh
a3c2b7d611eef885f4261ff8263c8d8def02771e
link
/test istio-pilot-e2e-v1alpha3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rshriram any idea what might  be wrong with the pilot test here https://circleci.com/gh/istio/istio/63479

this can't work until #4668 is done

@ldemailly I talked to @rshriram and he suggested to add name back into the Destination message. This would make the existing istio/istio repo work and we should be able to move the istio/api to latest SHA. I think what I have is the right fix, because it restores the old name field which is what istio/istio uses everywhere.

I didn't see you fixed it for him, thanks for doing that !

cool, I missed that kindly picked up the clean up!

/lgtm

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: ldemailly
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [ldemailly]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


No cast devices despite having one ?

I've used the sample app several times and never found my cast device "LG Smart TV" which is connected to the same network and can be cast with other published apps from store.
Also the log gives :
2017-11-16 11:09:47.490786+0300 CastVideos-ios[529:96185] Logging 15, currently detected {(
    7,
    3,
    5,
    1,
    15
)}

Have tried all samples on the internet , and none working.
the app starts but no cast button

Please test this with a Cast-enabled device such as chromecast. Apps such as YouTube use other discovery protocols and work with various non-cast devices too.


Basic Tab Context Menu for #736

A basic editor tab context menu with common tab close operations. For issue #736.
Implemented actions:

Close tab

Close other tabs

Close tabs to the left

Close tabs to the right

[x] Added an entry to CHANGELOG.md if this change could be valuable to users

Codecov Report

Merging #1570 (2ece6d9) into master (2f310ab) will increase coverage by 0.00%.
The diff coverage is 0.00%.

:exclamation: Current head 2ece6d9 differs from pull request most recent head 030dec3.  Learn more


Replace calls to eval in Web Node project

Describe the bug
Eval can be replaced by a better call
To Reproduce
Steps to reproduce the behavior:

Fixed with #33


Query - Are GPIO Filters supported in config.txt?

Hi
I'm trying to use GPIO filters in my config.txt i.e. conditional configurations depending on the state of a GPIO at boot.
This doesn't appear to be working but GPIO filters seem to be temperamental at the best of times so I just wanted to check if anyone knows if they're definitely implemented or definitely not implemented before I waste too much time troubleshooting.
Thanks

@GilchristT I haven't played with them until now and also haven't seen people around do it either. have you tried to reach out on the RPi's forum? We use the latest stable firmware version so you should have the same functionality as in upstream/Raspbian.


Fuzzer Literals

As discussed in https://github.com/raphlinus/pulldown-cmark/pull/286#discussion_r280458531 we don't necessarily want all literals used in pulldown-cmark to end up in the list of literals we fuzz with. Instead we probably want to automatically extract some literals (especially ones used within branches, patterns and match-guards) and then manually add some that are not included in branching code.
One such literal we should manually add is a single entity of entities.rs, e.g. &. We might also want to include some unicode characters with different lengths to find crashes due to incorrect handling of unicode.
Here is a list of literals automatically extracted from pulldown-cmark. The branching ones look good, but we might also want to include statics and possibly some other manual ones.
Which do you think would make the most sense @marcusklaas?

We can assume that whenever arrays are used, we only need to take into account the first element. For example in if ["foo", "bar"].contains(baz) { it's enough to just extract the first element to cover that branch.
Extracting only the first element of arrays (see below for the lists with all literals):

Literals inside statics (6)
"'",
"pre",
"&",
"0123456789ABCDEF",
"!--",
"
"

Literals inside consts (1)
"address"

Literals inside if-conditions / match arm patterns / guards (48)
"&",
"]",
">",
"~",
"$",
"\"",
"[]",
"0",
"{",
"> ",
")",
";",
"\'",
"A",
"@",
"CDATA[",
"^",
"`",
"|",
"#",
"[^",
"(",
"ssse3",
"x",
"%",
"\r",
"!",
"-",
"a",
"9",
"f",
"_",
"+",
"*",
":",
"}",
"<",
"\u{0}",
"=",
"Z",
" ",
"X",
"/",
"[",
"?",
"\\",
"\t",
"."

All literals in pulldown-cmark (excluding entities.rs and main.rs) not in statics / consts / conditions (72)
"   ",
" align=\"center\">",
" align=\"left\">",
" align=\"right\">",
"&aXaaaa.a\'aa9a<>aab&",
"*bcd&f0123456789",
"*hello* world",
"0123456789abcde",
"0123456789abcdefghijkl",
"0123456789abcdefghijklm",
"0123456789abcde~*bcd&f0",
"0123456789abcde~~~~d&f0",
"4444444444444444444444444444444444444444444444444444444444!",
"",
"",
"",
"",
"",
"</h",
"
"
"
",
"",
"",
"	",
"	",
"<a href=\"",
"<a href=\"mailto:",
"",
"",
"<div class=\"footnote-definition\" id=\"",
"",
"<h{}>",
"<img src=\"",
"
",
"<ol start=\"",
"
",
"
<code class=\"language-",
"
",
"",
"<a href=\"#",
"
",
"<td",
"",
"\" alt=\"",
"\" title=\"",
"\">",
"\">",
"\u{1bca0}",
"abcdef0123456789",
"match_count: {}, byte: {:?}",
"unexpected item body {:?}",
"world",
"{}",
"¡",
"« Blurry Eyes »",
"«\u{a0}Blurry Eyes\u{a0}»][blurry_eyes]",
"،",
"藏",
"･",
"𛲟",
"🍔",

Extracting all literals of arrays (instead of just the first one):

Literals inside statics (19)
"style",
"?",
"<",
"script",
"0123456789ABCDEF",
"&",
"
",
"pre",
""",
">",
"]]>",
">",
"</style>",
"</script>",
"!--",
"?>",
"'",
"-->",
"![CDATA["

Literals inside consts (62)
"section",
"base",
"nav",
"h6",
"caption",
"basefont",
"address",
"source",
"h5",
"td",
"noframes",
"title",
"legend",
"main",
"menuitem",
"dialog",
"dd",
"h3",
"frame",
"track",
"figcaption",
"link",
"ul",
"tfoot",
"colgroup",
"center",
"option",
"body",
"html",
"summary",
"form",
"optgroup",
"article",
"table",
"iframe",
"footer",
"dt",
"li",
"details",
"param",
"th",
"ol",
"frameset",
"thead",
"col",
"dir",
"hr",
"figure",
"dl",
"h4",
"blockquote",
"h2",
"tbody",
"fieldset",
"tr",
"header",
"div",
"head",
"p",
"menu",
"aside",
"h1"

Literals inside if-conditions / match arm patterns / guards (48)
"[]",
"{",
"@",
"\'",
"+",
"]",
"$",
"9",
"> ",
"|",
"_",
"<",
"?",
"ssse3",
"f",
"\"",
"\u{0}",
"*",
"0",
"X",
".",
" ",
"&",
"!",
"=",
"~",
":",
"-",
";",
"[^",
">",
"\\",
"%",
"[",
"#",
"(",
"\t",
"CDATA[",
"^",
"`",
"a",
"/",
"Z",
"}",
"A",
"x",
")",
"\r"

All literals in pulldown-cmark (excluding entities.rs and main.rs) not in statics / consts / conditions (69)
"   ",
" align=\"center\">",
" align=\"left\">",
" align=\"right\">",
"&aXaaaa.a\'aa9a<>aab&",
"*bcd&f0123456789",
"*hello* world",
"0123456789abcde",
"0123456789abcdefghijkl",
"0123456789abcdefghijklm",
"0123456789abcde~*bcd&f0",
"0123456789abcde~~~~d&f0",
"4444444444444444444444444444444444444444444444444444444444!",
"",
"",
"",
"",
"",
"</h",
"",
"	",
"	",
"<a href=\"",
"<a href=\"mailto:",
"",
"",
"<div class=\"footnote-definition\" id=\"",
"",
"<h{}>",
"<img src=\"",
"
",
"<ol start=\"",
"
",
"
<code class=\"language-",
"
",
"",
"<a href=\"#",
"
",
"<td",
"",
"\" alt=\"",
"\" title=\"",
"\">",
"\">",
"\u{1bca0}",
"abcdef0123456789",
"match_count: {}, byte: {:?}",
"unexpected item body {:?}",
"world",
"{}",
"¡",
"« Blurry Eyes »",
"«\u{a0}Blurry Eyes\u{a0}»][blurry_eyes]",
"،",
"藏",
"･",
"𛲟",
"🍔",

I should include literals in consts in the list of statics. Also I should only use a single literal per const / static, as they are most likely used in the same branches. (e.g. not include all HTML_END_TAGS, but only the first one. Same for HTML_TAGS). I'll do that later today and report back.

[OFF-TOPIC]
@oberien Sorry for the off-topic question, but what are those clickable roll-down triangles in the 1st post, used to roll down more content? Yet another GFM extension? Never saw them yet. Cannot find any docs about them.

@mity https://stackoverflow.com/questions/32814161/how-to-make-spoiler-text-in-github-wiki-pages/33033172#33033172

@oberien Thanks.
 I was afraid I missed some important feature of GFM in MD4C implementation.
[/OFF-TOPIC]

I updated the comment and added a second list only taking into account the first element of arrays.
I'd say we should opt for only including the first element of arrays. We should use literals in statics, consts and conditions. Additionally we should add the following literals manually:

&: This triggers the entities.rs branch. It should already be included from the statics, but adding it an additional time to make sure it's really there doesn't cost anything.
\u{a0}: Unicode no-break space.
\u{0}: First 1-byte UTF-8 character.
\u{80}: First 2-byte UTF-8 character.
\u{800}: First 3-byte UTF-8 character.
\u{10000}: First 4-byte UTF-8 character.

Due to the more relevant literals that are now being used, the parse time increased significantly, more than halving the throughput. Also the false-positive rate increased significantly due to this.


How are you? I am still running your program. I got a problem.

How are you? I am still running your program. I got a problem.
Every time I should run "gpu_compile.m" before I start "testSRnet_result.m".
When I start Matlab, I need to run "gpu_compile.m".
However, it is very uncomfortable.
How can I remember the setup after running "vl_compilenn.m".
Because time is very wasteful for me every time running "gpu_compile.m".
I am so sorry every time, I am bother you.
I am appreciate very much for your attention.

In fact, you can comment 'vl_compilenn' by '%'.
Every time you start matlab,  you only need to add the path  so that Matlab can find the file.

`
addpath matlab;
addpath examples;
run matlab/vl_setupnn ;
%{
vl_compilenn('enableGpu', true, ...
'cudaRoot', '/usr/local/cuda', ...  %change it
'cudaMethod', 'nvcc',...
'enableCudnn',false,...
'cudnnroot','local');
%}
warning('off');`

When I start Matlab and run "testSRnet_result.m",  the program will request to setup GPU if I did not run "vl_compilenn.m". So I do not run the program if I did not start running "vl_compilenn.m".
If I turn off Matlab and then I turn on again Matlab, I cannot start the program because I did not run "vl_compilenn.m".


Finish clowder archive support

Add ARCHIVE status to Clowder so we can bulk tag files
md5 files are in /home/clowder/sites/ua-mac/archive. we should iterate over the files, find them in Clowder Mongo, set status to ARCHIVED.
The tar file name should be included - we can use this to retrieve the file later. Could be a piece of metadata we add to the file in Clowder.

If we try to download archived data, send email to admins with pre-filled in email body including the name of the archive metadata.

Nearing readiness on Pt. I of this, another project is requesting more detail on future support (that may benefit TERRA) so this wiki page will hold more info: https://opensource.ncsa.illinois.edu/confluence/display/CATS/Clowder+Data+Archiving+Support

this PR should address initial requirements:
https://opensource.ncsa.illinois.edu/bitbucket/projects/CATS/repos/clowder/pull-requests/1364/overview

The PR has been merged.


Update namespace in Spec docs

https://jakarta.ee/specifications/cdi/3.0/cdi-spec-3.0.0-M4.html
eg,  https://jakarta.ee/specifications/cdi/3.0/cdi-spec-3.0.0-M4.html#trimmed_bean_archive
It should use the new jakarta namespace.

I can help to update this myself. I will send a PR soon.


Cannot run KolibriOS

Using Chrome - Version 116.0.5845.187 (Official Build) (x86_64), on macOS Intel laptop.
After initial boot of KolibriOS, the emulator hangs on loading the desktop. Historically this worked and would load.

After flushing cache seems to be working... I think the issue was setting Networking proxy to space rather than blank (i.e. " " vs "").

Indeed, we need a try-catch here:
https://github.com/copy/v86/blob/c69cbd7854d7cbda08679c389973aa87c9fb37bd/src/browser/network.js#L101

Obviously this shouldn't cause a crash(?)....

On Chrome, space in Networking proxy (if more technically, in WebSocket constructor) caused this error in console that crashed an emulator:
Uncaught DOMException: Failed to construct 'WebSocket': The URL ' ' is invalid.

On Firefox, it's just tries connect to URL from address bar:

@copy - Thanks for the quick response and for this wonderful tool! It has allowed me to explore multiple OS withe ease.
Does this issue also expose an underlying issue on KolibriOS, that I should report back to their team?

Does this issue also expose an underlying issue on KolibriOS, that I should report back to their team?

No, the issue was specific to v86.


Handling of "Not Used" Elements

I'm trying to parse an X12 835 document, and the NM1 Segment has space for "Name Prefix" - NM106, which is labeled as "Not Used" in the documentation, however, I see that in your code you are ignoring this field.
For reference sake, I am getting my information from here: https://reviewer.x12.org/x322publicreviewweb
Then navigating to 2.4 \ Table 2 - Detail \ Loop 2100 - Claim Payment Information \ NM1 - Patient Name.
And I see in your code: Generated\V5010\Segments\Maps\NM1Map.cs - Line 20 sets position 6 to Name Suffix instead of Name Prefix.
Thank you!

Good catch. The fix is to increment the index for suffix to 7, qualifier to 8, and code to 9. Fix will be in need release.

fixed in release 1.0.236-develop

@nycbauer is this still an issue?

Nope, thank you!


[T3A3][T09-A2]Bey Hao Yun

Ready for review

@cardboardcode Some comments added. Please close the PR after reading comments.


Nit fixes for result display user feedbacks

Codecov Report

Merging #141 (bed5edf) into master (61ec20b) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##             master     #141   +/-   ##
=========================================
  Coverage     61.36%   61.36%
  Complexity      572      572
=========================================
  Files            95       95
  Lines          2063     2063
  Branches        233      233
=========================================
  Hits           1266     1266
  Misses          686      686
  Partials        111      111

Impacted Files
Coverage Δ

...ain/java/socialite/logic/commands/EditCommand.java
90.38% <ø> (ø)

.../java/socialite/logic/commands/PictureCommand.java
0.00% <ø> (ø)

...main/java/socialite/logic/commands/AddCommand.java
91.66% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 61ec20b...bed5edf. Read the comment docs.


docs: ✏ Sidekiq instrumentation options

For users of Sidekiq instrumentation, I thought it would be nice to have a list of options and their uses.
So I added a (simple explain and format) table in the README ✏
（At least no code reading required）
I improve any further explanations, items, or errors that are necessary.
If you don't need it, you can close it 🙏

@arielvalentin Thank you for confirming!

If you are curious and would be interested in helping us a little more in this area, I would be interested in seeing if we could somehow generate this markdown README as well as some yardoc that may appear here:
Sorry, I missed the mention of Yard in the Contribute guide.

I don't know how to output to README, I will first rewrite it from README to Yard so that we can check it in rubydoc 🙏

Thank you for taking the time to do that!

@kohbis Would you be interested and available to help us do the same for other instrumentations?

@kohbis Would you be interested and available to help us do the same for other instrumentations?

@arielvalentin If you don't mind if I proceed a little at a time, I'd be happy to help 🙏


Request: Add regex support to snippets

Being able to do this would be fantastic and drastically increase snippets usefulness above and beyond the example provided
One use case for example is below, I'd love to be able to auto complete anyvar:AcceptInput() while currently there's no way that I've seen to do so.
"ENT:AcceptInput":
{
	"scope": "source.lua",
	"body": ":AcceptInput($0)",
	"prefix": ".*:AcceptInput",
	"description": "SHARED Method: ENT:AcceptInput()"
}

// @jrieken fyi

dupe of #6920

Oh, actually not a duplicate. @aStonedPenguin You want to always get that snippet above when the prefix matches <somethingOrNothing>:AcceptInput, right? So, foo:AcceptInput should become AcceptInput()?

Yes, that is what I was hoping to accomplish.

I'd recommend you to write an extension for that because it seems like a bit of a special case and with extension API you call the powers you need. You can participate in IntelliSense and provider snippets that way. This is a sample: https://github.com/Microsoft/vscode-extension-samples/blob/master/completions-sample/src/extension.ts

Closing because this should be done as extension and we are not planning to make a code change in this repo.


feat: use GeoStylerContext composition for RasterChannelEditor

Description
This makes use of GeoStylerContext for the <RasterChannelEditor>.
BREAKING CHANGE: This removes the defaultValues property from RasterEditor. Please use GeoStylerContext.composition instead.

Do you introduce a breaking change?

[x] Yes
[ ] No
[ ] I am unsure (no worries, we'll find out)

:tada: This PR is included in version 13.0.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


x/pkgsite: redirect semver tags with build metadata

From https://groups.google.com/g/golang-dev/c/bduZuUdzM_o/m/lBX634unAQAJ:
<EMAIL_ADDRESS>should redirect to<EMAIL_ADDRESS>per<EMAIL_ADDRESS>

Seems like this was fixed ~this time last year :)


~💥 disabled line wrap to keep logo intact on small terminal

added printf statements at the top of main to disable line wraps during the entire run to keep logo intact on small terminal or when terminal is resized, and disabled line wrap before exit.

~💥 disabled line wrap to keep logo intact on small terminal

~💥 disabled line wrap to keep logo intact on small terminal


Make the default ResourceProvider available via the Configuration interface

Hello,
My organization has a custom migration resolver that needs to search for migration files in the same way that the rest of Flyway does. Unfortunately, the only way this appears to be possible is through the use of the internal Scanner class. We've been using this for a number of years, but we'd like to move away from using internal classes, since they often change and make upgrading more difficult.
With the recent addition of the getResourceProvider() method to the Configuration interface, we were optimistic that we would finally be able to end our reliance on the internal Scanner class. However, we discovered that this method deliberately returns null when no custom ResourceProvider has been set.
Would it be possible to have the getResourceProvider() method return the default ResourceProvider, instead of null, when no custom ResourceProvider is set?
If the change were implemented, it would allow us to replace code that looks like this:
import org.flywaydb.core.internal.scanner.LocationScannerCache;
import org.flywaydb.core.internal.scanner.ResourceNameCache;
import org.flywaydb.core.internal.scanner.Scanner;

@Override
public Collection<ResolvedMigration> resolveMigrations( Context context )
{
	Configuration config = context.getConfiguration();

	Scanner<JavaMigration> scanner = new Scanner<>(
	        JavaMigration.class,
	        Arrays.asList(config.getLocations()),
	        config.getClassLoader(),
	        config.getEncoding(),
	        false,
	        new ResourceNameCache(),
	        new LocationScannerCache()
	);

	for ( Resource resource : scanner.getResources( config.getSqlMigrationPrefix(), CSV_SUFFIXES ) )
	{
		//do something
	}
}

...with code that does not rely on internal classes and is also simpler and more maintainable:
@Override
public Collection<ResolvedMigration> resolveMigrations( Context context )
{
        Configuration    config           = context.getConfiguration();
        ResourceProvider resourceProvider = config.getResourceProvider();

        for ( Resource resource : resourceProvider.getResources( config.getSqlMigrationPrefix(), CSV_SUFFIXES ) )
        {
    	         //do something
        }
}

getResourceProvider is designed to only be interested in custom implementations as our own scanner is already fully configurable. We wish to keep this approach as it allows us to ascertain if the implementation is custom.
There are a multitude of other reasons to avoid changing this, the primary being that it is a niche request and a breaking change. As such, we cannot commit to making this change at this current time.
That said, Flyway already has support for setting custom suffixes which is what your example seems to be focused on.


Fix race in stats Manager

Came across https://gist.github.com/runcom/5791bd0befbe8f0c7d3b while testing stats in Docker, hope the fix is right or fixing it Docker side is enough https://github.com/docker/docker/pull/13444
Signed-off-by: Antonio Murdaca<EMAIL_ADDRESS>

@dqminh updated

LGTM

LGTM


feat(es/compat): literals

Description:

BREAKING CHANGE:

Related issue (if exists):

fix #4870

I don't know if it's worth adding a pass to handle literals. @kdy1
Solution B: pass FeatureFlag to codegen pass.

I think this pass is fine, although I prefer codegen because of performance reasons

I think this pass is fine, although I prefer codegen because of performance reasons

Ok, I prefer to do it in codegen as well. This is a quick fix. We should pass FeatureFlag into codegen pass in future refactor.


Create a prebuilt package baseline for the prebuilt usage report

We should use the baseline to reduce the report to packages that we don't expect to be prebuilt. We can use that list to eliminate them over time, and alert us to new packages showing up as prebuilts to avoid regressions.
Related: https://github.com/dotnet/source-build/issues/461 (generating the reports)

/cc @dleeapho @crummel @dseefeld


Update Documentation/Languages page for Mermaid.js info

Is your feature request related to a problem? Please describe.
Some of the Mermaid links can be updated. E.g. the link to the Mermaid live editor is now just https://mermaid.live
I think adding a mermaid code snippet and the resulting image as an example may help explain the benefits and use of mermaid for documentation.
Describe the solution you'd like

Update some links to the new URLs, e.g. mermaid.live
Add a sample mermaid.js code snippet and resulting image as an example

Describe alternatives you've considered

Hmm. Not sure. Leaving things as they are? The links still resolve, for example.

Additional context
N/A

@matt-manuel Good suggestions. Can you please create a PR with suggested info?


[Request] Add httpie

https://github.com/jakubroztocil/httpie

Someone tried to PR it to the main bucket here, but I'm not sure what's happening with the PR.

@equinox awh, maybe it should locate in extra bucket?

I dont know what happened myself. You can test it yourself with
scoop install https://gist.githubusercontent.com/Restia666Ashdoll/147a46b3d8d7a91eb53c8c1c7824d9b7/raw/httpie.json
I put it in the main bucket because it fulfills all the criteria. aria2 and wget are also in the main bucket.

scoop bucket add python https://github.com/TheRandomLabs/Scoop-Python.git
scoop install httpie-py

This issue is pretty old and is answered here.
So can @rashil2000 please close this issue.


Homebrew: update instructions following 10.11 changes

Documents changes in https://github.com/ome/omero-install/pull/120

Overall looks fine other than the minor punctuation placement noted.

Thanks, all looks good to merge to me.


Simplify expression profiling macros

A more elegant solution for expression profiling that just occurred to me...

Codecov Report

Merging #510 (4d636d6) into develop (4aba676) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff            @@
##           develop     #510   +/-   ##
========================================
  Coverage    95.26%   95.26%
========================================
  Files           73       73
  Lines         3909     3909
========================================
  Hits          3724     3724
  Misses         185      185

Impacted Files
Coverage Δ

src/serac/infrastructure/profiling.hpp
100.00% <ø> (ø)

...c/serac/physics/utilities/finite_element_state.hpp
100.00% <ø> (ø)

...ties/functional/tests/functional_comparison_L2.cpp
100.00% <100.00%> (ø)

...lities/functional/tests/functional_comparisons.cpp
98.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4aba676...4d636d6. Read the comment docs.


Bug with callbacks in tf.keras model

Please make sure that this is a bug. As per our
GitHub Policy,
we only address code/doc bugs, performance issues, feature requests and
build/installation issues on GitHub. tag:bug_template
System information

Have I written custom code (as opposed to using a stock
example script provided in TensorFlow): Yes
OS Platform and Distribution (e.g.,
Linux Ubuntu 16.04): Ubuntu 19.10
Mobile device (e.g. iPhone 8, Pixel 2, Samsung Galaxy) if
the issue happens on mobile device: N/A
TensorFlow installed from (source or
binary): - TensorFlow version (use command below): pip install / tensorflow==2.0
Python version: - Bazel
version (if compiling from source): 3.7.5
GCC/Compiler version (if compiling from
source): N/A
CUDA/cuDNN version: - GPU model and memory: n/A

You can collect some of this information using our environment capture
script
You can also obtain the TensorFlow version with: 1. TF 1.0: python -c "import tensorflow as tf; print(tf.GIT_VERSION, tf.VERSION)" 2. TF 2.0: python -c "import tensorflow as tf; print(tf.version.GIT_VERSION, tf.version.VERSION)"
Describe the current behavior
When force stopping a model on training, all the callbacks(on_epoch_end, on_train_end) are called. This does not happen with a keras model.
Describe the expected behavior
The other callbacks, namely on_epoch_end and on_train_end aren't supposed to be called.
Standalone code to reproduce the issue
Provide a reproducible test case that is the bare minimum necessary to generate
the problem. If possible, please share a link to Colab/Jupyter/any notebook.
https://colab.research.google.com/drive/1Uu_LPSgdyXAyWubGAQDpbMq8BcUcXqUd
Other info / logs Include any logs or source code that would be helpful to
diagnose the problem. If including tracebacks, please include the full
traceback. Large logs and files should be attached.

@CleanPegasus,
I was able to reproduce the issue with TF2.1, however the issue seems to be fixed in TF-nightly. With TF-nightly, I see that the functions on_epoch_end and on_train_end are not being called.
Please find the attached gist. Thanks!

Thanks for the help.


Option to delete chats

Hi, there.
Archive actually means the chat contents are deleted (removed from the database)? If not:

Is there a planned feature to browser and restore chats?
Maybe add a option to simply delete chats (with confirmation, if possible)?

Thanks again!. Regards

How can I restore a chat from an archive?

How can I restore a chat from an archive?

I believe that just deleting it from sqlite.

How can I restore a chat from an archive?

@rsipakov For now you'll have to set archived=0 on the chat in the database. There's no way to do it via the UI.

Is there a planned feature to browser and restore chats?

@LFd3v Yes, it's planned but not sure when I'll get to it. Could be a couple of months at least.

Maybe add a option to simply delete chats (with confirmation, if possible)?

@LFd3v This would be part of the above feature. When viewing the archived chats you could a) restore or b) delete.


--rm does not work with -d

Original PR: #1589
Justification:
It's currently supported only when -d isn't provided. It doesn't make sense to automatically remove a container created via docker run -d. There are two reasons why this is implemented this way: 1) we might want to retrieve some kind of exit status or logs before removing the container 2) making this run on the server side is difficult in the current architecture.
I want to be able to do this, so 1 doesn't apply. I don't think it being difficult is a good reason for this restriction if it's actually wanted.
Hence opening this issue.

Has anyone come across a more elegant solution to getting around this issue? Is there any new discussion on getting something like this officially supported? Seeing that other instances of this question point here, it would be nice to mention them if so.

you should checkout https://github.com/docker/docker/issues/10545

I can't believe this is still not possible. I'm trying to love docker, but it just feels so hacky, like it leaking disk space by never cleaning anything up, or having some weird latest tag convention that makes no sense what so ever.
(comment for venting and subscription)

@Aidenir
It is not about docker, it is about humans, cooking docker ))))
Blaming software won't help as much as finding a right people to get you help ))))

@Aidenir it was not possible because --rm was implemented client-side and the docker daemon did not have any information about any "auto-removal" thingy. This is fixed with #20848 and will be in 1.13.0.


release

Codecov Report

Merging #5 into master will not change coverage.
The diff coverage is 100%.

@@          Coverage Diff          @@
##           master     #5   +/-   ##
=====================================
  Coverage     100%   100%
=====================================
  Files           6      6
  Lines          43     41    -2
  Branches        7      7
=====================================
- Hits           43     41    -2

Impacted Files
Coverage Δ

src/utils/isPolyfillPath.js
100% <100%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a790054...08fda5f. Read the comment docs.


INTEGRATION-B -19167 - Feature flags to hide/show specific shipment type - Customer UI

B-19167
Summary
INTEGRATION
This PR introduces feature flags to show/hide specific shipment types on the customer application side. It is in preparation for the upcoming production release of Milmove in early April. Dan Shuester wants to only enable HHG for the production release and disable PPM, NTS, NTSR. Note: this is only achieved via UI and NOT on the server side because CreateMtoShipments API is still opened to creating PPM, NTS, NTSR from the Prime/Office side. Dan Shuester says this is acceptable.  Specific shipment types will be shown/hidden on the "Add Shipment" view per configuration.
Feature Flag
.envrc
export FEATURE_FLAG_HHG=true
export FEATURE_FLAG_PPM=true
export FEATURE_FLAG_NTS=true
export FEATURE_FLAG_NTSR=true
Verification Steps for the Author
These are to be checked by the author.

[ ] Tested in the Experimental environment (for changes to containers, app startup, or connection to data stores)
[ ] Have the Agility acceptance criteria been met for this change?

Verification Steps for Reviewers
These are to be checked by a reviewer.

[ ] Has the branch been pulled in and checked out?
[ ] Have the BL acceptance criteria been met for this change?
[ ] Was the CircleCI build successful?
[ ] Has the code been reviewed from a standards and best practices point of view?

Setup to Run the Code

Instructions for starting storybook
Instructions for starting the MilMove application
Instructions for running tests

How to test
By default  all shipment types are enabled via  .envrc:
export FEATURE_FLAG_HHG=true
export FEATURE_FLAG_PPM=true
export FEATURE_FLAG_NTS=true
export FEATURE_FLAG_NTSR=true

Update .envrc to hide/show specific shipment type
Start app and login into customer
Start adding shipments ..etc...
Verify INFO modal popups are consistent with what are enabled/disabled. ie...It should not reference PPM if PPM is disabled ..etc...

If everything is enabled it should should display the following:
Frontend

[ ] There are no aXe warnings for UI.
[ ] This works in Supported Browsers and their phone views (Chrome, Firefox, Edge).
[ ] There are no new console errors in the browser devtools.
[ ] There are no new console errors in the test output.
[ ] If this PR adds a new component to Storybook, it ensures the component is fully responsive, OR if it is intentionally not, a wrapping div using the officeApp class or custom min-width styling is used to hide any states the would not be visible to the user.
[ ] This change meets the standards for Section 508 compliance.

Backend

[ ] Code follows the guidelines for Logging.
[ ] The requirements listed in Querying the Database Safely have been satisfied.

Database
Any new migrations/schema changes:

[ ] Follows our guidelines for Zero-Downtime Deploys.
[ ] Have been communicated to #g-database.
[ ] Secure migrations have been tested following the instructions in our docs.

Screenshots

Warnings

:warning:

New files have been created under one of the legacy directories
(src/shared or src/scenes). Please relocate them according to the file structure described here.
View the frontend file org ADR for more information

:warning:

Files located in legacy directories (src/shared or src/scenes) have
been edited. Are you sure you don’t want to also relocate them to the new file structure?
View the frontend file org ADR for more information

  Generated by :no_entry_sign: dangerJS against 477831db7754f79769077405ef8328a8bf016718

i dont see a Pr to https://github.com/transcom/milmove-feature-flags that would coincide with this

Warnings

:warning:

Files located in legacy directories (src/shared or src/scenes) have
been edited. Are you sure you don’t want to also relocate them to the new file structure?
View the frontend file org ADR for more information

  Generated by :no_entry_sign: dangerJS against b3a243a227af1f7fcb984da8a96d43ed75b670ba

Available move options and the pro/cons modal behave as expected for all eight combinations of the three flags.

Two PRs for milmove-feature-flags repo  have been created:
For Testing
For PROD


Only one output file can be set in the logger

Multiple logger instantiations change the one file that is used.

Fixed in #980


init default logger

Relies on https://github.com/lrlna/femme/pull/9. Adds a default logger that supports log's key-value API. A base "hello world" example now looks like this:
#[async_std::main]
async fn main() -> Result<(), std::io::Error> {
    tide::log::start();
    let mut app = tide::new();
    app.at("/").get(|_| async move { Ok("Hello, world!") });
    app.listen("<IP_ADDRESS>:8080").await?;
    Ok(())
}

There's a bit of a design question whether we should expose this as a separate function, or integrate it directly into the framework. I think logging is kind of on the fringe here since it not only captures things going on inside the framework; it captures things going on outside of it as well.
I feel that making it a single line to enable logging strikes a good balance between the two -- we make it easy to get a good setup going with minimal work, but we don't enable things that have global implications for the program without consulting the user.
Screenshots

Can this be filtered by an env variable? I think that is really a requirement to enabling this by default, especially having a way to make it only log things inside my app or just tide, not all dependencies.

@dignifiedquire still working on adding filtering on the femme through femme::with_filter, but it should then be a one-liner to hook up env vars to apply filtering.

In reply to the question of whether logging should be integrated: Eventually for a production logger, I think there'll be a lot more API surface area*, possibly justifying splitting this out into an independent crate (even if it's included by a default logging feature in tide).
*Other features people might reasonably eventually expect from a feature-complete local logger: Log rotation, configurable formats, splitting into different files depending on a predicate like status code (similar to nginx's approach to logging), parameter filtering.

It would be really nice if the default logger were able to support stuff like that, so that the path from development to production wouldn't be "replace the tide logger" but instead "configure the tide logger."

@jbr I love this phrasing and agree that is indeed the way we should be thinking of driving this feature. As such I probably should add some more context for this logger specifically, explaining the ideas behind it, the direction it's going, and shortcomings it has.
The idea behind femme is to create a logger in the tradition of winston, bole, and pino: using ndjson for logs so that each line can be unambiguously parsed, overcoming much of the problems around common-log formatting. In particular femme acts as a hybrid of pino and the pino-colada pretty printer. When in development it will pretty-print messages. But in production the output is ndjson-formatted [1]. This allows for easy piping into e.g. logstash.
Because femme's format is based on pino, we can use many of the same utilities. For example log rotation exists as a tool already. And so does splitting logs on log level. The pino docs feature many tools and techniques that would likely get us most of the way, right away.
However some things we indeed do not support yet; in particular redaction seems important. Maybe the right approach here is to have femme::with_filter act as some kind of filter_map operation that can both modify and edit values. Though a more elaborate override mechanism might be useful as well. We'll need to think this one over probably.
Hopefully this sheds some light on what femme is, what some of the ideas behind it are, and what it would enable for Tide today. None of this is to say that implementing femme in its current state would be the final word on logging for Tide. But I think it would get us really far out of the box. As we get feedback from users we could look to expend our logging facilities. But hopefully this can help us get off to a good start!
[1]: We probably should do tty detection here as well.

I should have looked more into femme, that's really cool! I saw the pretty-printed output in the screenshot and assumed that it was just logging unstructured text, but the ability to repurpose pino's utilities (and transporters!) makes this approach way more feature-complete and production ready than I expected.

@jbr no worries; I understand the confusion and felt it was on me to share more details here heh 😅

Filed an issue on log as well. Merging this so folks get access to logging, and once log is patched we'll receive a new version as well thanks to semver.


RSDP reporting

rsdp_addr: Optional<u64>

The address of the RSDP data structure, which can be use to find the ACPI tables.

This field is None if no RSDP was found (for BIOS) or reported (for UEFI).

In what situation is RSDP not reported? If the RSDP is important to your kernel, is there any way to guarantee it will be u64 and not None?
let gop = unsafe { &mut *gop.get() };

What is the purpose of the above line from src/bin/uefi.rs?

In what situation is RSDP not reported? If the RSDP is important to your kernel, is there any way to guarantee it will be u64 and not None?

No RSDP is reported when the firmware doesn't support ACPI for whatever reason. For example because it is too old.

What is the purpose of the above line from src/bin/uefi.rs?

gop is of type &UnsafeCell<GraphicsOutput>. This line converts it to &mut GraphicsOutput which is unsafe as it requires that there exists no other reference to the same location of a type unless it is also an &UnsafeCell<GraphicsOutput>.

Thank you for clarifying.
Can you perform an operation such as let gop = unsafe { &mut *gop.get() }; for other boot services or is this specific to the graphics protocol?

It would work with any boot service. Just be careful to not have more than one non &UnsafeCell<T> reference to each boot service at any given time.

Thanks. I hope it is okay if I ask questions later as they arise - I have read a lot about UEFI but most documentation is in C.