Incomplete descriptions are useless

Most of the parameter descriptions are incomplete, and thus they are useless. the description of /s essentially means nothing, for we don't know how the string is modified by the command. The same for the pipe/to file commands. Please write more exhaustive descriptions, or at least provide a link to a website who has done the work already (I haven't been able to find one, which is why I am writing to you now).
Thank you and have a good day!

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 0df94452-999b-43a0-be42-722fbabedaf3
Version Independent ID: 84206d79-507f-b562-9d3f-cc3683b7abe6
Content: cmd
Content Source: WindowsServerDocs/administration/windows-commands/cmd.md
Product: windows-server
Technology: windows-commands
GitHub Login: @JasonGerend
Microsoft Alias: jgerend

Hello @ZBB-XD,
Thanks for contacting Microsoft. We value your feedback.
Documentation changes have been made to clarify the Parameters and Remarks and will be live after the next business day. We will now be closing this thread.
Thank you and have a most pleasant day.
#please-close


NIFI-5076: Add ExportFlowSnapshots NiFi CLI command

The command can be used to migrate Flow snapshots between
FlowPersistenceProviders.
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:

[x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?

[x] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

[x] Has your PR been rebased against the latest commit within the target branch (typically master)?

[x] Is your initial contribution a single, squashed commit?

For code changes:

[x] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
[ ] Have you written or updated unit tests to verify your changes?
[ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
[ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
[ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
[ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?

For documentation related changes:

[ ] Have you ensured that format looks appropriate for the output in which it is rendered?

Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.

In order to try the new 'export-flow-snapshots' command, you need to checkout NiFi Registry PR 112 which is under review phase for NIFIREG-162.

Closing this PR as we decided to just reset NiFi Registry in order to switch Persistence Providers until more reliable export/import commands are added. See NIFIREG-162 for detail.


[Feature Request]: GoSDK: Generics API for beam

What would you like to happen?
Generics make beam code more readable.
Type registration is somewhat annoying because multiple type registrations are required for a single generic DoFn[T, U, ...], one for each concrete type required for a pipeline.
Here's a little library I wrote to play around with this. It works but doesn't cover the full API and isn't super thoughtful/consistent:
// Package beamgen contains utilites for working with beam pipelines using
// generics.
package beamgen

import (
	"context"
	"reflect"

	"github.com/apache/beam/sdks/v2/go/pkg/beam"
	"github.com/apache/beam/sdks/v2/go/pkg/beam/core/runtime"
	"github.com/apache/beam/sdks/v2/go/pkg/beam/core/runtime/graphx/schema"
	"github.com/apache/beam/sdks/v2/go/pkg/beam/io/textio"
	"github.com/samber/lo"
)

// Collection is a typed PCollection.
type Collection[T any] struct {
	underlying beam.PCollection
}

// PCollection returns a generic PCollection from a typed PCollection.
func (c Collection[T]) PCollection() beam.PCollection { return c.underlying }

// AssertType returns a Collection[T] from a PCollection that asserts it has a
// given type.
func AssertType[T any](coll beam.PCollection) Collection[T] {
	return Collection[T]{coll}
}

// Create returns a PCollection from a set of in-memory objects.
//
// Create inserts a fixed non-empty set of values into the pipeline. The values must
// be of the same type 'A' and the returned PCollection is of type A.
//
// The returned PCollections can be used as any other PCollections. The values
// are JSON-coded. Each runner may place limits on the sizes of the values and
// Create should generally only be used for small collections.
func Create[T any](scope beam.Scope, obj ...T) Collection[T] {
	asInterfaces := lo.Map(obj, func(elem T, _ int) any { return elem })
	untyped := beam.Create(scope, asInterfaces...)
	return Collection[T]{untyped}
}

//func ParDoFunc[InT, OutT any](scope beam.Scope, in Collection[InT], fn func(value InT))

// ParDoUnsafe is like beam.ParDo in that it accepts an `any` dofn, but the
// input and output collections are typed.
func ParDoUnsafe[InT, OutT any](scope beam.Scope, dofn any, inCol Collection[InT], opts ...beam.Option) Collection[OutT] {
	return Collection[OutT]{
		beam.ParDo(scope, dofn, inCol.PCollection(), opts...),
	}
}

type DoFnInterfaceStruct1[InT, OutT1 any] interface {
	ProcessElement(ctx context.Context, value InT, emit func(out OutT1)) error
}

// ParDo1 is like beam.ParDo in that it accepts an `any` dofn, but the
// input and output collections are typed.
func ParDo1[InT, OutT any](scope beam.Scope, dofn DoFnInterfaceStruct1[InT, OutT], inCol Collection[InT], opts ...beam.Option) Collection[OutT] {
	return Collection[OutT]{
		beam.ParDo(scope, dofn, inCol.PCollection(), opts...),
	}
}

type DoFnInterfaceStruct2[InT, OutT1, OutT2 any] interface {
	ProcessElement(ctx context.Context, value InT, emit1 func(OutT1), emit2 func(OutT2)) error
}

// ParDo2 is like beam.ParDo in that it accepts an `any` dofn, but the
// input and output collections are typed.
func ParDo2[InT, OutT1, OutT2 any](scope beam.Scope, dofn DoFnInterfaceStruct2[InT, OutT1, OutT2], inCol Collection[InT], opts ...beam.Option) (Collection[OutT1], Collection[OutT2]) {
	c1, c2 := beam.ParDo2(scope, dofn, inCol.PCollection(), opts...)
	return Collection[OutT1]{c1}, Collection[OutT2]{c2}
}

// ParDo1Func is like beam.ParDo in that it accepts an `any` dofn, but the
// input and output collections are typed.
func ParDo1Func[InT, OutT any](scope beam.Scope, dofn func(ctx context.Context, in InT, emit OutT) error, inCol Collection[InT], opts ...beam.Option) Collection[OutT] {
	return Collection[OutT]{
		beam.ParDo(scope, dofn, inCol.PCollection(), opts...),
	}
}

// ParDoGBKFunc is used to handle the result of a call to GroupByKey.
func ParDoGBKFunc[InK, InV, OutT any](
	scope beam.Scope,
	dofn func(ctx context.Context, in InK, next func(*InV) bool, emit func(OutT)) error,
	inCol Collection[GroupedByKey[InK, InV]],
	opts ...beam.Option) Collection[OutT] {
	return Collection[OutT]{
		beam.ParDo(scope, dofn, inCol.PCollection(), opts...),
	}
}

// ParDoGBK is like beam.ParDo in that it accepts an `any` dofn, but the
// input and output collections are typed.
func ParDoGBK[InK, InV, OutT any](
	scope beam.Scope,
	dofn interface {
		ProcessElement(ctx context.Context, in InK, next func(*InV) bool, emit func(OutT)) error
	},
	inCol Collection[GroupedByKey[InK, InV]],
	opts ...beam.Option) Collection[OutT] {
	return Collection[OutT]{
		beam.ParDo(scope, dofn, inCol.PCollection(), opts...),
	}
}

// ParDoGBK0 is like beam.ParDo in that it accepts an `any` dofn, but the
// input and output collections are typed.
func ParDoGBK0[InK, InV any](
	scope beam.Scope,
	dofn DoFnInterfaceGBK0[InK, InV],
	inCol Collection[GroupedByKey[InK, InV]],
	opts ...beam.Option) {
	beam.ParDo0(scope, dofn, inCol.PCollection(), opts...)
}

type DoFnInterfaceGBK0[InK, InV any] interface {
	ProcessElement(ctx context.Context, in InK, next func(*InV) bool) error
}

// DoFnInterfaceKVStruct is a DoFn that outputs a PCollection<KV<OutK, OutV>> from a PCollection<InT>
type DoFnInterfaceKVStruct[InT, OutK, OutV any] interface {
	ProcessElement(ctx context.Context, value InT, emit func(key OutK, value OutV)) error
}

// ParDoKV is a key/value version of ParDo
func ParDoKV[InT, OutK, OutV any](scope beam.Scope, dofn DoFnInterfaceKVStruct[InT, OutK, OutV], inCol Collection[InT], opts ...beam.Option) Collection[KV[OutK, OutV]] {
	return Collection[KV[OutK, OutV]]{
		beam.ParDo(scope, dofn, inCol.PCollection(), opts...),
	}
}

// A type for holding a key and value, mostly used only as a type.
type KV[K, V any] struct {
	// Key   K `json:"key"`
	// Value V `json:"value"`
}

type GroupedByKey[K, V any] struct{}

// GroupByKey is a PTransform that takes a PCollection of type KV<A,B>,
// groups the values by key and windows, and returns a PCollection of type
// GBK<A,B> representing a map from each distinct key and window of the
// input PCollection to an iterable over all the values associated with
// that key in the input per window. Each key in the output PCollection is
// unique within each window.
func GroupByKey[K, V any](scope beam.Scope, col Collection[KV[K, V]]) Collection[GroupedByKey[K, V]] {
	return Collection[GroupedByKey[K, V]]{
		beam.GroupByKey(scope, col.underlying),
	}
}

// type KeyExtractor[V, K any] struct {
// 	fn func
// }

// func KeyBySimple[K, V](scope beam.Scope, col Collection[V], keyFn func(elem V) K) Collection

// RemoveDuplicates takes a PCollection with duplicate entries and returns a
// PCollection with the duplicates removed.
func RemoveDuplicates[T any](scope beam.Scope, col Collection[T]) Collection[T] {
	scope = scope.Scope("RemoveDuplcates")
	var table Collection[KV[T, T]] = ParDoKV[T, T, T](scope, &xToKVXXFn[T]{}, col)
	var grouped Collection[GroupedByKey[T, T]] = GroupByKey(scope, table)
	return ParDoGBK[T, T, T](scope, &keysOfGBKFn[T, T]{}, grouped)
}

func Reshuffle[T any](scope beam.Scope, col Collection[T]) Collection[T] {
	return Collection[T](AssertType[T](beam.Reshuffle(scope, col.PCollection())))
}

func RemoveDuplicatesInit[T any]() {
	runtime.RegisterType(reflect.TypeOf((*keysOfGBKFn[string, string])(nil)).Elem())
	schema.RegisterType(reflect.TypeOf((*keysOfGBKFn[string, string])(nil)).Elem())
	runtime.RegisterType(reflect.TypeOf((*xToKVXXFn[string])(nil)).Elem())
	schema.RegisterType(reflect.TypeOf((*xToKVXXFn[string])(nil)).Elem())
}

type xToKVXXFn[T any] struct{}

func (f *xToKVXXFn[T]) ProcessElement(_ context.Context, in T, emit func(T, T)) error {
	emit(in, in)
	return nil
}

type keysOfGBKFn[K, V any] struct{}

func (f *keysOfGBKFn[K, V]) ProcessElement(_ context.Context, key K, nextValue func(*V) bool, emit func(K)) error {
	emit(key)
	return nil
}

func keysOfGBKFnOld[K, V any](_ context.Context, key K, nextValue func(*V) bool, emit func(K)) error {
	emit(key)
	return nil
}

func TextIOWrite(scope beam.Scope, filename string, col Collection[string]) {
	textio.Write(scope, filename, col.PCollection())
}

// IterToSlice returns a slice from a beam iterator.
func IterToSlice[T any](next func(*T) bool) []T {
	var out []T
	for {
		var value T
		if !next(&value) {
			break
		}
		out = append(out, value)
	}
	return out
}

// IterForEachErr returns a slice from a beam iterator.
func IterForEachErr[T any](next func(*T) bool, fn func(t T) error) error {
	for {
		var value T
		if !next(&value) {
			return nil
		}
		if err := fn(value); err != nil {
			return err
		}
	}
}

// AddFixedKey adds a fixed key (0) to every element.
func AddFixedKey[T any](scope beam.Scope, col Collection[T]) Collection[KV[int, T]] {
	return Collection[KV[int, T]]{
		beam.AddFixedKey(scope, col.PCollection()),
	}
}

Issue Priority
Priority: 2
Issue Component
Component: sdk-go

Hey @gonzojive thanks for the suggestion - broader use of generics is absolutely something we want to see more of!
This doesn't do everything you're talking about here, but I did add generic registration functions which will be part of the next release (2.40). The docs aren't merged yet (here if you want a sneak peak), but it should allow you to register your DoFn, register all associated types, and do some performance optimization using reflection with a single call.
This is just a start, and we should absolutely keep pushing usage of generics forward to improve the experience here.

I like the general thrust of this suggestion! There's plenty to do to use generics with beam (see Beam Java's probable over-abundance of Generics). Currently we have the goal to carefully add generics without breaking existing code.
First as Danny points out is the generic registrations, which make it easier to improve  performance by removing per-call execution time reflection.
We'd also like to introduce a "real" KV type, and make sure that's understood by the whole framework. No more splitting KVs (except to support older code). Similarly, generic iterator and emitters types would let the Go compiler do more work for inlining and efficient calls.   While we're
Making the "front end" generic with typed PCollections is difficult once one gets to features like Side Inputs. I don't see fully compile time checked side inputs in the near term.
Either way, it's important to note that while the SDK's core will take time to include generic awareness, user DoFns and transforms will be able to take advantage of them much sooner.
All that said, something like the code in this example, could be added to a package under ...pkg/beam/x/..  so we can allow users to experiment with them before we fully commit to a given wrapper/approach.

Thanks for sharing your thinking.
One issue I punted on is the usage of any in T any below:
func Create[T any](scope beam.Scope, obj ...T) Collection[T] {
	asInterfaces := lo.Map(obj, func(elem T, _ int) any { return elem })
	untyped := beam.Create(scope, asInterfaces...)
	return Collection[T]{untyped}
}

It seems like the signature should be more like this to ensure things that can be encoded are being passed around:
func Create[T Serializable](scope beam.Scope, obj ...T) Collection[T] { /* ... */ }

Agreed, but unfortunately "Serializable" is not a real concept WRT Go, let alone as generics.
As it stands, primitive types, and the Exported fields of structs (so, exactly like JSON's restrictions) are efficiently encoded using Beam schemas.  Interfaces, Functions, Channels are not encodable because there's no good way of doing so, without the registration lookup tables (largely handled going forward with the register package Danny mentioned).
Anything is serializable with enough prepwork though, via lookup tables or enums, or pre-known keys. It's simply difficult to make things work on distributed workers with only runtime knowledge otherwise.
Aside from deferring to the standard proto.Marshaller for protocol buffer messages (determined via the proto interfaces), users can also register their own arbitrary coder functions (which also gets around the "exported fields" restrictions). You've already filed a task for us to improve the documentation for that escape hatch (#21930).

Just a note WRT the register package. With Go 1.21, type inference is improved sufficiently that one no longer needs to explicitly list out ProcessElement types in the register.DoFnNxM calls.  Registrations are still required, but that should make things simpler.

To slightly contribute to the wrapper library, this function adds a bit more runtime type safety for converting beam.PCollections:

// CollectionOf returns a typed PCollection converted from the given
// beam.PCollection. It exists for documenting purposes. If T doesn't match
// with what is actually in pc, the function panics.
func CollectionOf[T any](pc beam.PCollection) PCollection[T] {
	var z T
	if reflect.TypeOf(z) != pc.Type().Type() {
		panic(fmt.Sprintf(
			"CollectionOf given unexpected PCollection type: expected %v, got %v",
			reflect.TypeOf(z), pc.Type().Type()))
	}
	return PCollection[T](pc)
}

Any progress on this mattern? I would love to contribute!


First UI iteration

Description
We are building a small app for a subset of data served in openspending. This app will provide a curated view onto that data, as well as other data and stories that are related.
Original wireframes here: https://github.com/os-data/eu-structural-funds/issues/191#issue-184208296
We will do several iterations on the design. The goal of this first issue is not to pay much attention to design at all, but rather, just to get all the core elements setup in an app, for further design + data iterations.
Tasks

[ ] copy the basics of os-admin as the starting point for your app. This gives you the following:

a setup for angular and some basic templates
usage of the OS style guide which this app should follow
an existing pattern for building fronted assets, favoured by the core OS app developers @akariv and @kravets-levko

[ ] Strip out what you don't need from your copy of the os-admin base. This should leave you with some type of skeleton with a main page, and whatever angular machinery we are using for routing to other pages
[ ] Implement a basic template for the three pages in the wireframes

The header and footer of the os style guide are important for now. We might change them a little later
use D3 probably for the map
do a basic layout like the wireframes for the main content areas. for the actual content, especially the data points outside of the maps, provide some mock data for now.

@akariv if there are any specific points for the framework do make them known. I'll assign to Goce tomorrow when he accepts the invite.

Pushed first set of templates here: https://github.com/openspending/subsidystories.eu

Now available for preview at:

http://labs.openspending.org/subsidystories.eu/index.html
http://labs.openspending.org/subsidystories.eu/country.html

@gocemitevski I just want to follow up on this. What are the agreed next steps?

@DianaMPG I suppose, integrate these static mock-ups in an Angular application.
cc @pwalsh

I don't see much point in proceeding from this first iteration that we have until:

we have an API to the data in OpenSpending, which we need to be in sync with @akariv on
we have the updated style guide which we need to be in sync with @akariv and @smth on

@pwalsh we should have by EOD a dataset in OpenSpending which we will be able to query using the API and create embeddable visualisations upon it.
It might be a good time to move forward with the implementation of the website.

@akariv
Ok. We'll need to have some type of understanding of the API calls to get all the data points.

@gocemitevski as a first next step, we can start the process of converting what you have to angular. Can you sync with @kravets-levko and @akariv on this.

@gocemitevski I wanted to attract you attention to the geography folder in the repo. I put in there all the geojson data that you need to draw the boundaries according the nuts codes. Have a look.

@akariv do we have a version of the data now that can be queried? If yes, we'll need some examples that match the data points in the UI so that @gocemitevski can get started. We can continue that discussion in https://github.com/openspending/subsidystories.eu/issues/2


refactor(oauth): prevent credentials POST for non-OAuth

When GET /api/v1/connectors/{id}/credentials returns {} we should not invoke a POST /api/v1/connectors/{id}/credentials.
This makes it so that the invocation of useOAuthFlow is conditional on the result of useConnectorCredentials.

PR Storybook available here


[FEATURE] Implementation of Banner Grid 1 defined in Figma

Describe how this feature will help us improve
The Banner Grid 1 is defined in the Figma file.
With the implementation of Banner Grid 1, our users will have one more option in Banner Grid component.

Describe the solution you'd considered
Here is the technical implementation details, I am planning to follow, please have a look:
1.) Add one more template with bannerGrid=3 at SfBannerGrid/SfBannerGrid.vue
Sample Code:
<template v-if="bannerGrid === 3">

    <slot name="banner-A" />

      <slot name="banner-B" />

      <slot name="banner-C" />

</template>

2.) Update the SfBannerGrid stories file to support newly implemented grid.
Hi team,
Kindly let me know if I am missing any step in the suggested implementation, thank you!

Banner Grid has changed in our new designs. The new one is implemented. New designs are here


docs-markdown-to-mail doesnt work

[23:26:13] - Successfully coverted markdown to html.
[23:26:14] - methods.md converted to HTML and sent to<EMAIL_ADDRESS>[23:31:39] - Successfully coverted markdown to html.
[23:31:39] - methods.md converted to HTML and sent to<EMAIL_ADDRESS>[23:31:42] - Successfully coverted markdown to html.
[23:31:43] - methods.md converted to HTML and sent to<EMAIL_ADDRESS>[23:53:21] - Successfully coverted markdown to html.
[23:53:25] - README.MD converted to HTML and sent to<EMAIL_ADDRESS>[24:01:08] - Successfully coverted markdown to html.
[24:01:12] - README.MD converted to HTML and sent to<EMAIL_ADDRESS>yet I got nothing. ...

@jamarw can you look into this one when you get a chance?


FT.SEARCH returns Uint8Array instead of JSON

It's a response body traversal issue.
FT.Search is extremely important for any json query or redis vector searches!
Responses are nested Uint8 Arrays, I suggest testing out FT.Search commands with this library.

Fixed in v0.3.1


On clicking on link it doesn't redirect us to homepage.

Description
On clicking on link it doesn't redirect us to homepage.
Expected Behavior
I will modify the codebase so that it redirect us to homepage
Screenshots

Enviroment:

OS: Mac Linux Windows
Browser: Chrome Safari Firefox
Version:
Device: Desktop Mobile

Yes @Aarav238 , please resolve the issue.

okay  i will raise a PR asap .


Broken check? com.google.fonts/check/034 (xAvgCharWidth)

In https://github.com/google/fonts/pull/1720 the xAvgCharWidth fails, but the fonts were generated with glyphsapp or fontmake, so that suggests either our check is broken, or one of those compilers is broken.

🔥 FAIL: Check if OS/2 xAvgCharWidth is correct.
com.google.fonts/check/034
🔥 FAIL OS/2 xAvgCharWidth is 518 but it should be 533 which corresponds to the weighted average of the widths of the latin lowercase glyphs in the font

Expected behaviour
The xAvgCharWidth check should not fail when a font is built with glyphsapp or fontmake or afdko's default build path.
(Marking this as a p0 because its a false failure, that breaks the promise of reliability and trustworthiness we strongly aspire to)

Glyphsapp recently changed the way it calculates xAvgChar width.
Where is xAvgChar width even used? I mean every editor/fontmake has their own way of calculating this value.
I'd prefer us to work out where it's used and if the differing values between editors cause any significant issues.

Are we extremely sure that this value is irrelevant nowadays? If so, then we should considering deprecating the check at all.

Otherwise, we should clarify which problems are caused by a bad value.

Can't remember anything. Make it a warn and move on?
This should be a OT spec check, following the OT spec.
I wonder if Georg will explain why he changed his algo

@schriftgestalt any thoughts here?

from the OT spec:

The value for xAvgCharWidth is calculated by obtaining the arithmetic average of the width of all non-zero width glyphs in the font.

do you have a different algo depending on the version of the OS/2 table?
# Since version 3, the average is computed using _all_ glyphs (with non-zero width) in a font.
# Version 2 and below only consider lowercase latin glyphs and space.

This should be a OT spec check, following the OT spec.

It is! It is part of os2.py which is one of the table-specific python files that are included on the opentype.py, which is our "OpenType profile".

I meant it should not be com.google.fonts/check/034 but an OpenType check id

I meant it should not be com.google.fonts/check/034 but an OpenType check id

The reverse domain on a check id denotes who contributed the check implementation.

The only checks that do not have com.google.fonts in the checkid are those contributed by Dalton Maag and the ones that we'll port from Adobe's afdko. And also, hopefully, contributions from other people in the future.

Maybe com.google.fonts/ot/check-name is better, then...
I think for 0.7 we should probably redo all the check IDs. We don't follow
our own guidelines for most of our checks.
I remember @graphicore had some ideas about this.


Add Workspace Members Search Feature

Details
Fixed Issues
$ https://github.com/Expensify/App/issues/12339
PROPOSAL: #12339(comment)
Tests

Navigate to Settings.
Click on Workspaces.
Click on any Workspace and Manage members.
Search member by name or email address.

[] Verify that no errors appear in the JS console

Offline tests

Navigate to Settings.
Click on Workspaces.
Click on any Workspace and Manage members.
Search member by name or email address.

QA Steps

Navigate to Settings.
Click on Workspaces.
Click on any Workspace and Manage members.
Search member by name or email address.

[] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[ ] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android / native
[x] Android / Chrome
[x] iOS / native
[x] iOS / Safari
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is correct English and approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)

[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web
https://user-images.githubusercontent.com/17126628/218137774-ba89c425-880c-4c65-a526-b91aa097b2aa.mp4

Mobile Web - Chrome
https://user-images.githubusercontent.com/17126628/218143163-82d0d273-dfb8-488d-972a-3d6d57eac7b1.mp4

Mobile Web - Safari
https://user-images.githubusercontent.com/17126628/218138191-8e2704d8-61ab-4cec-abdd-4bf43b4f5bc4.mp4

Desktop
https://user-images.githubusercontent.com/17126628/218138700-628d7aca-7f51-4c78-a849-0e940c521af6.mp4

iOS
https://user-images.githubusercontent.com/17126628/218139516-f704b589-0fbb-4288-965e-d8c02c791062.mp4

Android
https://user-images.githubusercontent.com/17126628/218138792-fc8b5061-99bc-462a-80a4-305ae6d91663.mov

@stitesexpensify Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

Hi @PankajAS what issue is this from? The linked URL is invalid

@stitesExpensify its from issue #12339 and here is  proposal

Hi @stitesExpensify , have you get chance to review PR?

I think we also need to do something for the "Select all" button because it looks kinda weird when there are no results.
Screen.Recording.2023-02-13.at.9.06.07.PM.mov
We need help with the design and expected behaviour

cc: @shawnborton

@thesahindia  We can hide "Select All" option when there is no record found?

@thesahindia i have added "No results found" header and hide "Select All" when there is no record found, please check

I will be OOO for 1-2 days. @0xmiroslav will be reviewing this.

Ok @thesahindia ,
Hi @0xmiroslav can you please review PR

Can someone share the latest screenshots with me and I can provide design feedback from there? Thanks!

@shawnborton here is latest UI video
https://user-images.githubusercontent.com/17126628/218642449-f60e82c3-5331-49f4-b07a-f97b96b5f10a.mov

@PankajAS please pull from main and fix conflicts. And share latest screenshots for @shawnborton

@0xmiroslav i have fixed conflicts, check now

@PankajAS It seems PR is broken. I think you're doing merge in wrong way. Can you close this one and create new PR based on latest main?

@0xmiroslav I just rebase with main branch and fix conflicts and push code in this branch, anyway let me create new pull request.

@PankajAS Don't use rebase

Ok @0xmiroslav, let me create new pull request if that's ok?


Provide Chinese translations

Added support for Chinese language in src/data/languages.ts
Added Chinese translation file src/locales/zh/ingredients.json
Added Chinese translation file src/locales/zh/translation.json

Thank you for the PR 🚀


Include java time in Javalin bundle

Trying to serialize an instant now will result in
com.fasterxml.jackson.databind.exc.InvalidDefinitionException: Java 8 date/time type `java.time.Instant` not supported by default: add Module "com.fasterxml.jackson.datatype:jackson-datatype-jsr310" to enable handling (through reference chain: io.pesim.Simulation["startDate"])

Could just include it?

Imo a good idea, the new time implementation replaces the old one, so could be nice to have this support out of the box. Also that's what I need to do in pretty much every project and I guess anyone who's using Jackson serialization has to add this module anyway.

This was something tricky I had to figure out for myself. Java is the first programming language I've used where out of the box, it wasn't able to serialize JSON. And with a popular JSON library (I used Jackson, as the Javalin docs advised doing), it wasn't able to serialize the most up to date time type from the standard library (java.time.Instant). This wasn't an impossible challenge. I was able to figure it out after some trial and error, but it would definitely have made for a smoother experience for beginners if java.time.Instant was supported out of the box.
I think the precedent has already been set that Javalin takes an opinionated way of getting you going with JSON by including Jackson (instead of requiring you to choose between Jackson, Gson, or perhaps something else). So I think this change would be the way to continue that approach.

Thanks for the input guys, I'll see how I can include this.

PR here: https://github.com/tipsy/javalin/pull/1448


cursor_inactive_timeout and OS cursor in gaming

I like having my cursor hide when I am working so I have set a cursor_inactive_timeout but with it set I am having it reappear in games which is quite distracting. With variable set to 0 I am not experiencing any problems.
I am not sure if this is related to me using an NVidia GPU (I have followed all the instructions on the wiki as far as I can tell) or maybe just the env = WLR_NO_HARDWARE_CURSORS,1 or if this is a more widespread issue with AMD as well so it would be nice to have a record in the issue tracker even if this is close as unsupported due to NVidia drivers if that turns out to be the case.
Please let me know if you need more info from me regarding the issue.

Steps to reproduce

set cursor_inactive_timeout = 5
launch a game (tested with subnautica, monument valley and doom eternal via steam)
let the cursor disappear while the game is launching
wait for in-game cursor to appear
move the mouse

Expected outcome
OS cursor does not appear
Noted outcome
OS cursor appears alongside the in-game one (sometimes in a different place)
Note
Opening menus in game seems to hide OS cursor

System info
System: Arch Linux
Release: 6.3.6-zen1-1-zen
GPU: NVIDIA Corporation GP106 [GeForce GTX 1060 6GB]
Hyprland version: Hyprland, built from branch  at commit 51a930f802c71a0e67f05e7b176ded74e8e95f87 dirty (). Tag: v0.26.0

At least for me re-entering the game (opening the menu left clicking and exiting) fixes the issue for me

Sounds to me like that has more to do with the game implementation than hyprland itself. I don't think there is much we can do.

I don't think this can be a game issue as I have never had anything like that on xorg while running unclutter. And the cursor is fine when timeout is set to 0.
I believe this is caused either by hyprland or by Wayland itself. Or maybe due to how GPU driver is handled in Wayland. I might try some different Wayland compositor to see if this is isolated to hyprland or to Wayland as a whole.

I tested this with the latest hyprland-git on CS2, portal, Doom2016, ... the cursor doesn't appear within the game.
Seems resolved

Thanks for letting me know, I have now tried setting it back up and haven't noticed it since. I did change a lot since then though.


Specifically setting delimiter

I would love to be able to specifically set the delimiter to be used in the @Parameters annotation, so that I would be able to input strings with commas in them.
Kind of like with the awk -F'|' command
I'm thinking somewhere along the lines of this example
	@Test
	@Parameters({"hello, goodmorning|goodnight"}, delimiter="|")
	public void test(String str, String str2) {
		System.out.println(str + ":" + str2);
	}

I'm open to there being reasons for this being a bad idea, or that I've missed something :)

We will not introduce such change for couple of reasons. The most important is that @Parameters annotation abstraction supports many types of "source" of parameters - you can provide parameters by String, method or csv file (using source + provider). So it's too general to introduce it there.
It's easy to make it work by providing params with method e.g.
    @Test
    @Parameters(method = "paramsByPipe")
    public void byPipe(String parameter) {
        System.out.println("parameter: " + parameter);
    }

    @Test
    @Parameters(method = "paramsByComma")
    public void byComma(String parameter) {
        System.out.println("parameter: " + parameter);
    }

    public List<String> paramsByPipe() {
        return splitBy("hello, goodmorning|goodnight", "\\|");
    }

    public List<String> paramsByComma() {
        return splitBy("hello, goodmorning|goodnight", ",");
    }

    private ArrayList<String> splitBy(String params, String splitter) {
        return Lists.newArrayList(params.split(splitter));
    }


FR: harmonize GradleException content between List and Tree

List and Tree modes throw different exception content.
Tree
***** DEPENDENCY CHANGE DETECTED *****
-\--- androidx.activity:activity:1.4.0
-     +--- androidx.annotation:annotation:1.1.0 -> 1.2.0
-     +--- androidx.core:core:1.7.0
-     |    +--- androidx.annotation:annotation:1.2.0
-     |    +--- androidx.annotation:annotation-experimental:1.1.0
-     |    +--- androidx.lifecycle:lifecycle-runtime:2.3.1
-     |    |    +--- androidx.arch.core:core-runtime:2.1.0
-     |    |    |    +--- androidx.annotation:annotation:1.1.0 -> 1.2.0
-     |    |    |    \--- androidx.arch.core:core-common:2.1.0
-     |    |    |         \--- androidx.annotation:annotation:1.1.0 -> 1.2.0
-     |    |    +--- androidx.lifecycle:lifecycle-common:2.3.1
-     |    |    |    \--- androidx.annotation:annotation:1.1.0 -> 1.2.0
-     |    |    +--- androidx.arch.core:core-common:2.1.0 (*)
-     |    |    \--- androidx.annotation:annotation:1.1.0 -> 1.2.0
-     |    +--- androidx.versionedparcelable:versionedparcelable:1.1.1
-     |    |    +--- androidx.annotation:annotation:1.1.0 -> 1.2.0
-     |    |    \--- androidx.collection:collection:1.0.0
-     |    |         \--- androidx.annotation:annotation:1.0.0 -> 1.2.0
-     |    +--- androidx.collection:collection:1.0.0 (*)
-     |    \--- androidx.concurrent:concurrent-futures:1.0.0
-     |         +--- com.google.guava:listenablefuture:1.0
-     |         \--- androidx.annotation:annotation:1.1.0 -> 1.2.0
-     +--- androidx.lifecycle:lifecycle-runtime:2.3.1 (*)
-     +--- androidx.lifecycle:lifecycle-viewmodel:2.3.1
-     |    \--- androidx.annotation:annotation:1.1.0 -> 1.2.0
-     +--- androidx.savedstate:savedstate:1.1.0
-     |    +--- androidx.annotation:annotation:1.1.0 -> 1.2.0
-     |    +--- androidx.arch.core:core-common:2.0.1 -> 2.1.0 (*)
-     |    \--- androidx.lifecycle:lifecycle-common:2.0.0 -> 2.3.1 (*)
-     +--- androidx.lifecycle:lifecycle-viewmodel-savedstate:2.3.1
-     |    +--- androidx.annotation:annotation:1.0.0 -> 1.2.0
-     |    +--- androidx.savedstate:savedstate:1.1.0 (*)
-     |    +--- androidx.lifecycle:lifecycle-livedata-core:2.3.1
-     |    |    +--- androidx.arch.core:core-common:2.1.0 (*)
-     |    |    +--- androidx.arch.core:core-runtime:2.1.0 (*)
-     |    |    \--- androidx.lifecycle:lifecycle-common:2.3.1 (*)
-     |    \--- androidx.lifecycle:lifecycle-viewmodel:2.3.1 (*)
-     +--- org.jetbrains.kotlin:kotlin-stdlib:1.5.31 -> 1.6.10 (*)
-     +--- androidx.collection:collection:1.0.0 (*)
-     \--- androidx.tracing:tracing:1.0.0
-          \--- androidx.annotation:annotation:1.1.0 -> 1.2.0
+\--- androidx.activity:activity:1.4.1 FAILED

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':sample:app:dependencyTreeDiffReleaseRuntimeClasspath'.
> ***** DEPENDENCY CHANGE DETECTED *****
  Dependency Tree comparison to baseline does not match.

  If this is intentional, re-baseline using ./gradlew :sample:app:dependencyGuardBaseline
  Or use ./gradlew dependencyGuardBaseline to re-baseline dependencies in entire project.

* Try:
> Run with --stacktrace option to get the stack trace.
> Run with --info or --debug option to get more log output.
> Run with --scan to get full insights.

* Get more help at https://help.gradle.org

BUILD FAILED in 9s
9:07:35 pm: Execution finished ':sample:app:dependencyGuard --quiet'.

List
Dependencies Changed in :sample:app for configuration releaseRuntimeClasspath
- androidx.activity:activity:1.4.0
- androidx.annotation:annotation-experimental:1.1.0
- androidx.annotation:annotation:1.2.0
- androidx.arch.core:core-common:2.1.0
- androidx.arch.core:core-runtime:2.1.0
- androidx.collection:collection:1.0.0
- androidx.concurrent:concurrent-futures:1.0.0
- androidx.core:core:1.7.0
- androidx.lifecycle:lifecycle-common:2.3.1
- androidx.lifecycle:lifecycle-livedata-core:2.3.1
- androidx.lifecycle:lifecycle-runtime:2.3.1
- androidx.lifecycle:lifecycle-viewmodel-savedstate:2.3.1
- androidx.lifecycle:lifecycle-viewmodel:2.3.1
- androidx.savedstate:savedstate:1.1.0
- androidx.tracing:tracing:1.0.0
- androidx.versionedparcelable:versionedparcelable:1.1.1
- com.google.guava:listenablefuture:1.0

If this is intentional, re-baseline using ./gradlew :sample:app:dependencyGuardBaseline
Or use ./gradlew dependencyGuardBaseline to re-baseline dependencies in entire project.

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':sample:app:dependencyGuard'.
> Dependencies Changed in :sample:app for configuration releaseRuntimeClasspath
  - androidx.activity:activity:1.4.0
  - androidx.annotation:annotation-experimental:1.1.0
  - androidx.annotation:annotation:1.2.0
  - androidx.arch.core:core-common:2.1.0
  - androidx.arch.core:core-runtime:2.1.0
  - androidx.collection:collection:1.0.0
  - androidx.concurrent:concurrent-futures:1.0.0
  - androidx.core:core:1.7.0
  - androidx.lifecycle:lifecycle-common:2.3.1
  - androidx.lifecycle:lifecycle-livedata-core:2.3.1
  - androidx.lifecycle:lifecycle-runtime:2.3.1
  - androidx.lifecycle:lifecycle-viewmodel-savedstate:2.3.1
  - androidx.lifecycle:lifecycle-viewmodel:2.3.1
  - androidx.savedstate:savedstate:1.1.0
  - androidx.tracing:tracing:1.0.0
  - androidx.versionedparcelable:versionedparcelable:1.1.1
  - com.google.guava:listenablefuture:1.0

  If this is intentional, re-baseline using ./gradlew :sample:app:dependencyGuardBaseline
  Or use ./gradlew dependencyGuardBaseline to re-baseline dependencies in entire project.

* Try:
> Run with --stacktrace option to get the stack trace.
> Run with --info or --debug option to get more log output.
> Run with --scan to get full insights.

* Get more help at https://help.gradle.org

BUILD FAILED in 2s

As you can see, the List output contains the diff twice. Moreover, the colored diff output is generally hidden, and only the last bit appear, which is the GradleException message. (and the first line is different as well)
Do you think we could harmonize this behavior?

Tree (ad-hoc message)

https://github.com/dropbox/dependency-guard/blob/56ba80d9612e5de24a1d9e722f9befaf9ef19a47/dependency-guard/src/main/kotlin/com/dropbox/gradle/plugins/dependencyguard/internal/utils/DependencyGuardTreeDiffer.kt#L66-L72

List (reuses the exception message, leading to duplicated output)

https://github.com/dropbox/dependency-guard/blob/56ba80d9612e5de24a1d9e722f9befaf9ef19a47/dependency-guard/src/main/kotlin/com/dropbox/gradle/plugins/dependencyguard/internal/list/DependencyGuardListTask.kt#L105

🤔 .  The reason why I printed it and then it's part of the exception is that I didn't know how to add color to the exception message, and I loved the color.  Any tips here?

I do too 🌈 But what I don't understand is why we need the same message in both stdout and as Gradle error. In the "tree" mode we only have it on the stdout (not in the Gradle error).
Also, it seems you disabled to colors explicitely here:
https://github.com/dropbox/dependency-guard/blob/c163524a71b448c64875560de42fbe8687839966/dependency-guard/src/main/kotlin/com/dropbox/gradle/plugins/dependencyguard/internal/list/DependencyGuardListTask.kt#L91-L92
Without this, colors are visible in the Gradle exception.

Though it does not play nice with non-rich supported terminals like here for instance:

We might be able to ask Gradle what the current behavior is with this: https://docs.gradle.org/current/userguide/command_line_interface.html#sec:command_line_customizing_log_format or use Gradle's own internal StyledTextOutput.

Happy to accept a PR regarding this.  I personally only use tree format locally when trying to track down where a transitive dependency came from.  That being said, I don't use it much, and don't have much of an opinion about the messaging.
If you would like to update/improve the messaging for tree, I'm open to it!
--
RE: Disable coloring
https://github.com/dropbox/dependency-guard/blob/c163524a71b448c64875560de42fbe8687839966/dependency-guard/src/main/kotlin/com/dropbox/gradle/plugins/dependencyguard/internal/list/DependencyGuardListTask.kt#L91-L92
Because it's a plaintext string and not console output, it just looks like some crazy encoded characters if you don't do it that way unfortunately.

StyledTextOutput sounds nice.  I'd love to use something built in.
Additionally I dislike the double messages, but now I remember why I did it:
In our CI system, it only bubbles up the exception to users when looking at a PR.  If I did not add it to the exception, then users had to dig really deep, so for me at this time, it's a requirement.  I'm open to having a flag for this if it's undesirable for others.
Also, if you want to just chat about any of this, feel free to message me on Slack (Kotlin, Gradle, or ASG).

Ok, this makes more sense now. Then I guess there is no one solution fits all.
And adding even more settings to configure the desired output feels like the wrong approach for this kind of plugin.
Gradle's StyledTextOutput has been moved to their internal package, so I would not rely on this to work across many Gradle versions.


Implement OpenScanHub initial reporting

[ ] in fedmsg repo, process the messages about OSH task states (see https://github.com/openscanhub/openscanhub/pull/299 )
[ ] create new event class for that and implement parsing of these
[ ] create a model for a scan
[ ] store the task in the DB somewhere here and instead of successful status there, report in-progress
[ ] create a handler to report the results for the new event

obtain the task in our DB, update the state and report it to user
for now, just forward the URLs from the message (=> no additional processing)
take into consideration #2515
by default don't fail the CI, have a look also into action_required conclusion from here, whether that could be used, or use neutral/successful
report neutral status for failed, cancelled or interrupted builds

Part of #2516

by default don't fail the CI, have a look also into action_required conclusion from here, whether that could be used, or use neutral/successful
report neutral status for failed, cancelled or interrupted builds

Please also see Code scanning results check failures.

by default don't fail the CI, have a look also into action_required conclusion from here, whether that could be used, or use neutral/successful

If you want to find out if new findings were detected, follow these steps:

Download the added.js file.
Run csgrep added.js and check if output is non-empty.
If output is non-empty, it means there were new findings by the analzyers. Set the CI to action required state.
Otherwise pass the CI.

EDIT: @kdudka Is there any other way to count number of findings in the reports?

@siteshwar For simple scans, we can check whether the scan-results-summary.txt file is empty or not.  Unfortunately, for differential scans, we do not provide such a file that would summarize the added.* results.  We can still check whether added.err is empty or not.

And just to keep everybody in sync. The messages from OpenScanHub can be seen through:
fedora-messaging --conf /etc/fedora-messaging/fedora.toml consume --routing-key "org.fedoraproject.prod.openscanhub.task.*

@siteshwar I can see that the URLs provided in Body: of messages about finished scans use the http:// scheme instead of https://.  Consequently the scan results URLs, when used directly, return 302 Found instead of the real data.

The problem may actually be more generic. I got an e-mail notification and the task URL also contained http:// URL. Something must be misconfigured in the Fedora deployment because the internal OSH instances use https:// URLs.

I would investigate it separately through https://github.com/openscanhub/fedora-infra/issues/73

There is a confusion about task state changes in OSH and how they should be reflected in the reporting. I would summarize it again for clarification:

When a task is submitted to OSH, but has not started, it is in FREE state. The status in Packit should say, it is waiting to be started.

When a worker picks up the task and starts running it, it moves into OPEN state. OSH would emit this message with task id in the body.

org.fedoraproject.prod.openscanhub.task.open

Packit reporting should say the task is running.

If the scan fails to finish successfully, there would be one of these messages with task id in the body:

org.fedoraproject.prod.openscanhub.task.cancel
org.fedoraproject.prod.openscanhub.task.fail
org.fedoraproject.prod.openscanhub.task.interrupt

Packit reporting should put the CI in neutral state.

If the scan finishes successfully, you would get org.fedoraproject.prod.openscanhub.task.finish with url to added and removed findings in JSON format along with task id. Follow the steps from previous comment to process these results.

@lachmanfrantisek @lbarcziova
I am following up from https://github.com/packit/packit-service/pull/2580#discussion_r1804350263
Please tell me exactly the message topics you would like to receive on Packit side and what should be the content of the message body.

https://github.com/openscanhub/openscanhub/pull/301

openscanhub/openscanhub#301

These changes are in production now. Example messages:
[INFO fedora_messaging.twisted.consumer] Successfully consumed message from topic org.fedoraproject.prod.openscanhub.task.started (message id f6561b12-a1d3-4567-9f72-2ef3b941210a)
[INFO fedora_messaging.twisted.consumer] Consuming message from topic org.fedoraproject.prod.openscanhub.task.started (message id d1a83e8e-c9d0-4a1f-adad-562bc38026a4)
Id: d1a83e8e-c9d0-4a1f-adad-562bc38026a4
Topic: org.fedoraproject.prod.openscanhub.task.started
Headers: {
    "fedora_messaging_schema": "base.message",
    "fedora_messaging_severity": 20,
    "priority": 0,
    "sent-at": "2024-10-18T15:44:43+00:00",
    "x-received-from": [
        {
            "cluster-name"<EMAIL_ADDRESS>            "exchange": "amq.topic",
            "redelivered": false,
            "uri": "amqps://rabbitmq01.iad2.fedoraproject.org/%2Fpubsub"
        }
    ]
}
Body: {
    "task_id": 18203
}
[INFO fedora_messaging.twisted.consumer] Successfully consumed message from topic org.fedoraproject.prod.openscanhub.task.started (message id d1a83e8e-c9d0-4a1f-adad-562bc38026a4)
[INFO fedora_messaging.twisted.consumer] Consuming message from topic org.fedoraproject.prod.openscanhub.task.finished (message id 29b7d83b-2a79-46ab-8b9a-5b4f36794daa)
Id: 29b7d83b-2a79-46ab-8b9a-5b4f36794daa
Topic: org.fedoraproject.prod.openscanhub.task.finished
Headers: {
    "fedora_messaging_schema": "base.message",
    "fedora_messaging_severity": 20,
    "priority": 0,
    "sent-at": "2024-10-18T15:45:01+00:00",
    "x-received-from": [
        {
            "cluster-name"<EMAIL_ADDRESS>            "exchange": "amq.topic",
            "redelivered": false,
            "uri": "amqps://rabbitmq01.iad2.fedoraproject.org/%2Fpubsub"
        }
    ]
}
Body: {
    "added.js": "http://openscanhub.fedoraproject.org/task/18198/log/added.js?format=raw",
    "fixed.js": "http://openscanhub.fedoraproject.org/task/18198/log/fixed.js?format=raw",
    "scan-results.js": "http://openscanhub.fedoraproject.org/task/18198/log/crun-1.17-1.20241018152736619857.pr1579.39.g30fda6b/scan-results.js?format=raw",
    "status": "success",
    "task_id": 18198
}


API changes report for Druid

The review of API changes for the Druid library since 0.3.3 version: https://abi-laboratory.pro/java/tracker/timeline/io.druid.druid-api/
Hope it will be helpful for users and maintainers of the library.
The report is generated for jars found at http://central.maven.org/maven2/io/druid/druid-api/ according to https://wiki.eclipse.org/Evolving_Java-based_APIs_2.
Thank you.

Thank you. How the publicness of the API is determined? In Druid we have @PublicApi and @ExtensionPoint annotations for that.

In this report, Public API=="Methods, classes and interfaces with public or protected access level". In the next release of Druid I'll filter out private symbols from the report with the help of annotations.
Thank you.


Update height/width bokeh kwargs

PR updates profiler bokeh kwargs.  Use width/height instead of plot_width/plot_height

[x] Closes #7292
[ ] Tests added / passed
[ ] Passes black dask / flake8 dask

cc @jrbourbeau

closing in favor of #7297

Apologies Ben, I didn't see this before opening up #7297


Share bar on mobile

Hello,
the post bar on mobile isn't very clear. it would be better to have the same on desktop and mobile.
i want to add affiliate links to songs and artists. it doesn't look good with 5 links.
https://soundsirius.digitalpress.blog/golden-rule-trust/?internal
i think i want to remove facebook and twitter share buttons and only keep affiliate links.

Why it's not that clear? The buttons are the same, although the design can't be the same because on mobile they will hide a lot of content, specially if you want 5 buttons there. You can change it if you want but you have to do it by your own, that's something that I won't change since that's very specific for your use case.
I would suggest to keep the same design and only reduce the margin of those buttons on mobile if you want to have 5 buttons.
You can add your own buttons inside of the share element, just use the same structure from the existing buttons.
Then you can paste these styles in your Ghost Admin:
<style>
.m-icon-button.in-share {
  margin: 0 15px; /* You can use a different value if you want */
}
</style>

I will close this issue for now, please fell free to reopen it if needed.


Update readme.md

Updated redone CV!

Huzzah!!
Glad I can see your work and it looks great!
Keep it up


Twitchy login screen

enter MXID
enter PW
no HS selected (dropdown is empty)
press Enter

https://github.com/user-attachments/assets/38b81824-aaf6-4c67-802e-079c4c3a3342
Firefox 130.0.1 on LInux

context: https://github.com/spantaleev/matrix-docker-ansible-deploy/issues/3576
Basically, if the allowed HS URLs config value is set to empty array, the login form shows dropdown without any values, instead of (expected) text input.
So, the scope of this one is to treat empty array the same way as null/undefined for HS URL field


feat: Support retrying complex workflows with nested group nodes

This includes:

Major refactoring with clearer logic.
Connected parent group nodes are reset correctly.
Only the correct branch that matches the selected node path in the DAG is retried.
Handle pod deletion properly and fix some cases where nodes fail with "pod deleted" error.
Added extensive test cases to cover retrying on any selected node in the workflow.

Signed-off-by: Yuan Tang<EMAIL_ADDRESS>

@juliev0 Thanks for your feedback! All comments have been addressed.

Test failure is unrelated: https://github.com/argoproj/argo-workflows/issues/9591


check

add FE logic that will add safe zones in which tokens will not be eaten by oponent tokens
ie. on last 5 -6 fields where only player 1 can get, that are diff then players 2 fields. (relative to abs fields mapping is not correct for those fields)

relative and absolute states (using state machine patt) is removed.
now absolute (relative) view to board is row-column coordinates.
relative view is using state machine pattern.
this prevents handling safe zone edge cases


Cleanup flow-previews repository

The https://github.com/mittwald/flow-previews repository contains all temporary GitHub Pages files for the preview documentation and Storybook.
It should be cleaned up whenever a PR is merged.

Cleaned up old files by https://github.com/mittwald/flow-previews/pull/1


Virtual - Home button labeling not consistent.

Log in as administrator
the Home button on the List of Disasters is labeled "Home (Disaster List)"
click "Add New Disaster"  and the Home button is "Home (Disaster List)"
click "Add new Cluster"  and the Home button is "Home"
click "Cluster List"  and the Home button is "Home"

I'll take this one


[SelectionArea] doesn't show the copy on the web once I  do right click

I'm using flutter 3.3 and tried the new widget for SelectionArea,
...
                      title: S.current.appTitle,
                      builder: (context, child) => MediaQuery(
                        data: MediaQuery.of(context).copyWith(
                            textScaleFactor: getTheTextFactorFix(context)),
                        child: SelectionArea(child: child!),
                      ),
                      color: Theme.of(context).scaffoldBackgroundColor,
...

the issue here is all text widgets once I select the text and right-click the mouse the menu doesn't include the copy button, I can still do copy by CTRL + C, still I will expect to have the copy button in the menu.

Hi @nimr77, please provide a complete minimal runnable code sample so that we can investigate this.
Thank you

// example with material app
class MyApp extends StatelessWidget {
  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      title: 'Flutter Demo',
      theme: ThemeData(
        primarySwatch: Colors.blue,
      ),
      home: Center(
        child: SelectionArea(child: Text('Hello World')),
      ),
    );
  }
}

try this on the web,
and try to copy the text with the mouse

Hi @nimr77, it would appear that this issue has been fixed on the master channel. See the recordings below
Can you confirm if this is the case for you as well?

recordings

stable
master

flutter doctor -v
[✓] Flutter (Channel stable, 3.3.0, on macOS 12.5 21G72 darwin-arm, locale en-GB)
    • Flutter version 3.3.0 on channel stable at /Users/nexus/dev/sdks/flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision ffccd96b62 (2 days ago), 2022-08-29 17:28:57 -0700
    • Engine revision 5e9e0e0aa8
    • Dart version 2.18.0
    • DevTools version 2.15.0

[✓] Android toolchain - develop for Android devices (Android SDK version 33.0.0)
    • Android SDK at /Users/nexus/Library/Android/sdk
    • Platform android-33, build-tools 33.0.0
    • Java binary at: /Applications/Android Studio.app/Contents/jre/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 11.0.12+0-b1504.28-7817840)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 13.4.1)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Build 13F100
    • CocoaPods version 1.11.3

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 2021.2)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.12+0-b1504.28-7817840)

[✓] VS Code (version 1.70.2)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.46.0

[✓] Connected device (2 available)
    • macOS (desktop) • macos  • darwin-arm64   • macOS 12.5 21G72 darwin-arm
    • Chrome (web)    • chrome • web-javascript • Google Chrome 104.0.5112.101

[✓] HTTP Host Availability
    • All required HTTP hosts are available

• No issues found!

[✓] Flutter (Channel master, 3.1.0-0.0.pre.2608, on macOS 12.5 21G72 darwin-arm64, locale en-GB)
    • Flutter version 3.1.0-0.0.pre.2608 on channel master at /Users/nexus/dev/sdks/flutters
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 759d0e1b20 (62 minutes ago), 2022-08-31 23:07:20 -0700
    • Engine revision b149eea0a3
    • Dart version 2.19.0 (build 2.19.0-154.0.dev)
    • DevTools version 2.16.0

[✓] Android toolchain - develop for Android devices (Android SDK version 33.0.0)
    • Android SDK at /Users/nexus/Library/Android/sdk
    • Platform android-33, build-tools 33.0.0
    • Java binary at: /Applications/Android Studio.app/Contents/jre/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 11.0.12+0-b1504.28-7817840)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 13.4.1)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Build 13F100
    • CocoaPods version 1.11.3

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 2021.2)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.12+0-b1504.28-7817840)

[✓] VS Code (version 1.70.2)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.46.0

[✓] Connected device (2 available)
    • macOS (desktop) • macos  • darwin-arm64   • macOS 12.5 21G72 darwin-arm64
    • Chrome (web)    • chrome • web-javascript • Google Chrome 104.0.5112.101

[✓] HTTP Host Availability
    • All required HTTP hosts are available

• No issues found!

Thanks for the replying @danagbemava-nc, so I need to switch to the master channel in order to use the SelectionArea widget

You should be able to use it just fine on stable, but if you need that copy function, then you may need to use master for the time being.
Per our triage policy, I'll be closing this as fixed.
If you do run into this issue on the master channel, kindly leave a comment below and I will reopen this.
Thank you


fix: incorrect prop passing in ChannelSetting component

Description Of Changes
Resolves https://sendbird.atlassian.net/browse/UIKIT-3832
Just replaced a incorrect prop passing renderChannelProfile -> renderUserProfile

@sravan-s Guess you forgot to approve? ;)


When runing gulp build Webpack errors

Type of issue
Code doesn't work
Feedback
when running gulp build the following error happens
`PS C:\Users\JohnN\source\repos\TeamsApps\PersonalTab> gulp build
[14:00:46] Found additional Yo Teams plugin: yoteams-deploy
[14:00:46] Using gulpfile ~\source\repos\TeamsApps\PersonalTab\gulpfile.js
[14:00:46] Starting 'build'...
[14:00:46] Starting 'webpack'...
[14:00:46] Starting 'webpack:client'...
[14:00:46] Starting 'webpack:server'...
[14:00:54] [Webpack errors]:
[14:00:54] TS2554: Expected 0 arguments, but got 1.
64 |
65 | // Start the webserver

66 | http.createServer(express).listen(port, () => {
|                   ^^^^^^^
67 |     log(Server running on ${port});
68 | });
69 |
[14:00:54] 'webpack:server' errored after 7.6 s
[14:00:54] Error in plugin "webpack"
Message:
1 webpack error(s) found.
[14:00:54] 'webpack' errored after 7.6 s
[14:00:54] 'build' errored after 7.61 s`

the code is compaining about this line http.createServer(express).listen in the server.ts file line 66
Page URL
https://learn.microsoft.com/en-us/microsoftteams/platform/tabs/how-to/create-personal-tab?tabs=vs
Content source URL
https://github.com/MicrosoftDocs/msteams-docs/blob/main/msteams-platform/tabs/how-to/create-personal-tab.md
Author
@laujan
Document Id
6d43a761-19e0-541e-ba06-170099411ac1

Thanks for raising your issue. We will check this at our end and will update you accordingly.

the node.js version I'm using is v20.10.0 with webpack version 5.95.0, does this need to be different?

@Prasad-MSFT We are blocked on this error too, do you have a due date for a fix? Or could you advise a temporary workaround? Thank you.

It appears working now after I made the following changes in the file src\server\server.ts.
Previous:
http.createServer(express).listen(port, () => {
    log(`Server running on ${port}`);
});

Updated:
express.listen(port, () => {
    log(`Server running on ${port}`);
});

Thanks @alexchx! That change worked for me as well. 😊


W-13623867: Deploy Applications to CloudHub | CloudHub Deployment Reference | objectStoreV2 - parameter available for which version of plugin

The doc

Deploy Applications to CloudHub Using the Mule Maven Plugin | MuleSoft Documentation

Could have the text explaining after which version of plugin it's available to use property objectStoreV2, like the example from businessGroupId
https://docs.mulesoft.com/mule-runtime/latest/deploy-to-cloudhub#cloudhub-deploy-reference:~:text=This parameter is available in plugin version 3.2.7 and later.

Reference for which version:

Application deployment using maven fails with "Cannot find 'objectStoreV2' in class org.mule.tools.model.anypoint.CloudHubDeployment" error when using objectStoreV2 property in pom.xml | MuleSoft Help Center (help.mulesoft.com)

@AndyDaSilva52 Thank you for your contribution. We have added it to our issue tracking system for review.

PR created to address this request: https://github.com/mulesoft/docs-mule-runtime/pull/2655/files


eslint: imports should come before other code

cc @rlgomes @mnibecker

They are hoisted and always run before any preceding code which leads to confusing behavior if there is preceding code.

noice! if we start using imports in other repos we should probably make sure this is enforced the same way to save us heaches.

Wait, doesn't this go against the spec for how imports will eventually work? Feels like a hack...

No it doesn't, it makes it so that your code matches the order of execution that the spec defines (i.e. imports go first). Its the same as having an eslint rule that all vars should be declared at the top.

oooh, sry man this is an eslint rule. I thought you were messing with babel, my bad. good stuff.

no worries!


[ISSUE #608] Update rest of details (polish the example module)

What is the purpose of the change
Fix issue608
Update rest of details (polish the example module)
Brief changelog

batch (typo check)

SimpleBatchProducer.java
SplitBatchProducer.java

broadcast

BroadcastConsumer.java (renamed from PushConsumer.java, a clearer class name)

openmessaging

OMSProducer.java (renamed from SimpleProducer.java)
OMSPullConsumer.java (renamed from SimplePullConsumer.java)
OMSPushConsumer.java (renamed from SimplePushConsumer.java)

operation(remove this package, unsuitable)

Consumer.java
Producer.java

quickstart

delete resources/MessageFilterImpl.java

Coverage decreased (-0.1%) to 43.079% when pulling c7e58667e1db432e7dcdb13090997a0bc55bf54b on RongtongJin:remaining_modification into 385c69545988f8c2614f104de7ca88cf2dd7dc4e on apache:develop.


Adds support for re-init after Turbo Stream

Also DRYs up the init functions so you don't have to maintain the list in multiple places ✨
In this I introduce a new turbo event (turbo:after-stream-render) for parity with the other turbo events, and then use it to register another re-init listener. This may be more invasive that you want (that is, it essentially monkey-patches a new event into Turbo). I can remove the event if you like, it seems harmless and maybe useful for others so figured I'd try this way first.
This has been a long time coming since I figured out how to fix this—please let me know if I'm missing anything, I'm not particularly well-versed in Typescript.
I tested this out locally and it seemed to work fine. Didn't see any tests in the repo 👀

Hey @sdhull,
Thanks a lot for this PR! Will have it properly checked next year (first week).
Cheers,
Zoltan


Type global APIs: $router and $router, beforeRouteLeave, etc

Currently it seems like types are conflicting

Turns out this is because override of types get merged together instead of replaced. So I need to find a way that allows these types to be overriden outside of Vue Router. Maybe introducing a Config interface that can be extended


24w09a stuff

still so much to do, very much a work in progress, but I need sleep

Thanks for this, going to merge to help with API. Feel free to change names or whatever later 👍


conda run: qemu uncaught target signal 4 error

Hi!
I am trying to create armhf Dockerfile with automated build of the JupyterLab using this hack: https://resin.io/blog/building-arm-containers-on-any-x86-machine-even-dockerhub/
Here's the link to my repo: https://github.com/movalex/rpi-jupyter-conda/blob/base/Dockerfile
Unfortunately when Berryconda3-2.0.0-Linux-armv7l.sh is installed, I've got the error on this step:
conda config --system --add channels rpi

qemu: uncaught target signal 4 (Illegal instruction) - core dumped
Illegal instruction

Is it possible to fix this error?

Why not try to use armv6l build?


How to implement waypoint horizontal navigation with jInvertScroll ?

I have created a single page horizontal website using jInvertScroll and it is working well with mouse scroll. But I am facing issues with menu navigation using waypoint. Could you please help me in creating navigation with waypoint. Please provide some example scripts.

Thank you! @pixxelfactory


I was trying to put tabbar in a container

Steps to Reproduce

Run flutter create bug.
Update the files as follows: ...
...

Expected results:
Actual results:

Logs

Hi @azzamjafri
You need wrap Container like this
    appBar: AppBar(
            title: const Text('Tabbed AppBar'),
            bottom: PreferredSize(
              preferredSize: Size.fromHeight(100),
              child: Container(
                color: Colors.red,
                child: TabBar(
                  isScrollable: true,
                  tabs: choices.map((Choice choice) {
                    return Tab(
                      text: choice.title,
                      icon: Icon(choice.icon),
                    );
                  }).toList(),
                ),
              ),
            ),
          ),

Code Sample
// Copyright 2017 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.

import 'package:flutter/material.dart';

class TabbedAppBarSample extends StatelessWidget {
  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      home: DefaultTabController(
        length: choices.length,
        child: Scaffold(
          appBar: AppBar(
            title: const Text('Tabbed AppBar'),
            bottom: PreferredSize(
              preferredSize: Size.fromHeight(100),
              child: Container(
                color: Colors.red,
                child: TabBar(
                  isScrollable: true,
                  tabs: choices.map((Choice choice) {
                    return Tab(
                      text: choice.title,
                      icon: Icon(choice.icon),
                    );
                  }).toList(),
                ),
              ),
            ),
          ),
          body: TabBarView(
            children: choices.map((Choice choice) {
              return Padding(
                padding: const EdgeInsets.all(16.0),
                child: ChoiceCard(choice: choice),
              );
            }).toList(),
          ),
        ),
      ),
    );
  }
}

class Choice {
  const Choice({this.title, this.icon});

  final String title;
  final IconData icon;
}

const List<Choice> choices = const <Choice>[
  const Choice(title: 'CAR', icon: Icons.directions_car),
  const Choice(title: 'BICYCLE', icon: Icons.directions_bike),
  const Choice(title: 'BOAT', icon: Icons.directions_boat),
  const Choice(title: 'BUS', icon: Icons.directions_bus),
  const Choice(title: 'TRAIN', icon: Icons.directions_railway),
  const Choice(title: 'WALK', icon: Icons.directions_walk),
];

class ChoiceCard extends StatelessWidget {
  const ChoiceCard({Key key, this.choice}) : super(key: key);

  final Choice choice;

  @override
  Widget build(BuildContext context) {
    final TextStyle textStyle = Theme.of(context).textTheme.headline4;
    return Card(
      color: Colors.white,
      child: Center(
        child: Column(
          mainAxisSize: MainAxisSize.min,
          crossAxisAlignment: CrossAxisAlignment.center,
          children: <Widget>[
            Icon(choice.icon, size: 128.0, color: textStyle.color),
            Text(choice.title, style: textStyle),
          ],
        ),
      ),
    );
  }
}

void main() {
  runApp(TabbedAppBarSample());
}

This platform is not meant for assistance on personal code.
Please see https://flutter.dev/community for resources and asking questions like this,
you may also get some help if you post it on Stack Overflow and if you need help with your code, please see https://www.reddit.com/r/flutterhelp/
Closing, as this isn't an issue with Flutter itself. If you disagree, please write in the comments and I will reopen it.
Thank you


Fixes Union Exhaustiveness checking description

The previous description referred to an older example than the current example. This updates the references to refer to the code snippet presented below it.

Thanks!


Update a typo in the docs

Update a typo in Getting Started.md for all versions containing a section about Vite (main,  29.1, 29.2)
Summary
A typo.
Test plan
No coding needed.

Continuing pull request #13453

Included in #13447


Wrong cursor behavior when moving from tree view to editor

Running Atom 1.18.0 on OS X 10.10.5
Expected behavior: the cursor should always be a text cursor when hovering over code in the editor.
Actual behavior: clicking on the tree view then clicking on code switches the cursor to default pointer.
A gif to illustrate:

Related issues: #8566 #9489 #12314

Cannot reproduce on Windows, Atom 1.20.0-dev-c84d705e5.

Hmmm, can't reproduce either with 1.18.0 on macOS 10.12.6 - do you see any difference in safe mode @chbk?

No difference, same bug in safe mode. It only happens when Atom is in fullscreen (just noticed this).

Still can't reproduce in fullscreen.

I tried again in fullscreen and can't reproduce either.

I upgraded my OS to macOS 10.12.6 and can't reproduce anymore.

Thanks @chbk - since it's not reproducible after an OS update, we'll go ahead and close this.


Enhance PlanNodeDecorrelator

This change improves PlanNodeDecorrelator.Visitor to:

fail early when unable to decorrelate
never fail when plan is not correlated
The latter allows to succeed when a correlated subquery contains nested uncorrelated subquery.

Applied comments.

Updated commit message for fix test commit.

@sopel39 would you like to take a look before I merge this?

@kasiafi Please describe the problem that you are trying to solve in more details. Could you describe why this PR solves the problem?
Specifically, could you explain why the planning failed for the test queries previously?
I'm worried that the tests pass now because of the way (non-intentional) the rule optimizers fire and not by purpose. I've seen case where one decorrelation rule blocked other decorrelation rule, which made the planning fail because it reached dead-end.

@sopel39 Discussable commit was removed from this pull request and is going to be posted in separate pull request. Since other commits do not change much and are mostly refactoring I am merging this as it is.

Merged, thanks!


Do not set $IsWindows

Since PS 6.0 it is not allowed to set $IsWindows.

solves #49  (How to link an issue? i am new to git :) excuse me )

Since ($null -or $Env:OS.StartsWith('Windows')) will also return true with PS Version < 6.0, this should work. Tested on my system.


Use Read instead of Vec for files

Fantastic! I opened https://github.com/wcampbell0x2a/backhand/pull/107 with some fixes that I saw, lmk what you think of the branch. Also added some benchmarks to confirm.

The only problem right now is the function FilesystemReader::file that returns a Vec<u8>, instead it should return an impl Read.
Other then that the lib will be ready to read huge file.

I think a good solution for that is to have something like this:
pub struct FilesystemFileReader<'a, R: SquashFsReader> {
    filesystem: &'a FilesystemReader<R>,
    file: &'a BasicFile,
    blocks_remaining: usize,
}

impl<'a, R: SquashFsReader> Read for FilesystemFileReader<'a, R> {
    fn read(&mut self, _buf: &mut [u8]) -> std::io::Result<usize> {
        todo!()
    }
}

impl<R: SquashFsReader> FilesystemReader<R> {
    /// From file details, extract FileBytes
    pub fn file<'a>(&'a self, basic_file: &'a BasicFile) -> FilesystemFileReader<'a, R> {
      todo!()
    }
  }
}

The #cb8194b implement interface.


Why is this line commented out in the Dockerfile?

https://github.com/docker-library/httpd/blob/master/2.4/Dockerfile#L4

Because the "www-data" user already exists in the Debian base image.


Repo Index Merge

What type of PR is this?
/component kudoctl
/kind feature
What this PR does / why we need it:
kudo repo index --merge
kudo repo index --merge-repo
Which issue(s) this PR fixes:
Fixes #769
Special notes for your reviewer:
Looking to add some more tests tomorrow
Does this PR introduce a user-facing change?:
kudo repo index --merge
kudo repo index --merge-repo

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: kensipe
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [kensipe]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kensipe: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

test
6906b97bb2f38d2d81c6c9af8a56e4cc696d2aad
link
/test test

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: alenkacz, gerred, kensipe
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [alenkacz,gerred,kensipe]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


How do you determine sigma or mean value when using another dataset?

in the code you would find this
[
            ['gaussmf', {'mean': 0., 'sigma': 1.}],
            ['gaussmf', {'mean': -1., 'sigma': 2.}],
            ['gaussmf', {'mean': -4., 'sigma': 10.}],
            ['gaussmf', {'mean': -7., 'sigma': 7.}]
],

how do we calculate it for different dataset?

well somehow I figured it out, the easy way is you need MATLAB to generate this gaussmf


pixel-scroll-precision-mode does not work with rustic

As title says, enabling 'pixel-scroll-precision-mode' does not work with rustic. Scrolling with the mouse wheel has no effect. Curiously it works in 'rust-mode'. Any idea how to narrow down the cause?
$ emacs --version
GNU Emacs 29.1.50

with some recent update (GNU Emacs 29.1.90, rustic from straight/git) it works. Dunno what was the cause that it was broken but closing this ticket. thanks.


Added documentation regarding logging.

Packages impacted by this PR
@azure/cosmos
Issues associated with this PR
N/A
Describe the problem that is addressed by this PR
Added documentation regarding logging.
What are the possible designs available to address the problem? If there are more than one possible design, why was the one in this PR chosen?
N/A
Are there test cases added in this PR? (If not, why?)
N/A
Provide a list of related PRs (if any)
N/A
Command used to generate this PR:**(Applicable only to SDK release request PRs)
N/A
Checklists

[ ] Added impacted package name to the issue description
[ ] Does this PR needs any fixes in the SDK Generator?** (If so, create an Issue in the Autorest/typescript repository and link it here)
[ ] Added a changelog (if necessary)

API change check
API changes are not detected in this pull request.


[BUG] Bot API returns 0 for total bot volume. This impacts the LIghtNode Sale page

Bot API returns 0 for total bot volume. This impacts the LIghtNode Sale page

Superseeded by #2074

https://github.com/VolumeFi/paloma/issues/2074 doesn't cover this ticket. I am reopening this ticket. @taariq

This is done. @taariq


Add subcategories to SimpleLoss

I would be interested in adding some functionality to the SimpleLoss class and I'm opening this issue to discuss my proposed functionality and discuss how best to approach it. What I would like to do is to be able to add different categories of loss to an instance of SimpleLoss. So it might look something like this
from riskquant import simpleloss
s = simpleloss.SimpleLoss("ALICE", "Alice steals the data", 0.10) # notice that no loss range provided
s.add_loss("Response", 75000, 150000)
s.add_loss("Replacement", 1000, 150000)
s.add_loss("Reputation", 100, 200)
s.add_loss("Competitive Advantage", 100, 200)
s.add_loss("Fines & Judgement", 50000,2000000)
s.add_loss("Productivity", 100, 20000)

s.annualized_loss() # returns the sum of the mean for each loss multiplied by avg frequency

I think a decent approach to this would be to abstract out the loss distribution into its own class. This would give people the ability to specify that some kinds of loss should be modeled with the lognormal and others could be modeled with pert.
from riskquant import simpleloss

s = simpleloss.SimpleLoss("ALICE", "Alice steals the data", 0.10)
s.add_loss("hard costs", 100000, 1000000) # defaults to lognormal loss
s.add_loss(PertLoss("soft costs", 1000, 5000, 150000, kurtosos=4))

I think moving the loss distribution to a separate class is a good idea.  If you get time, feel free to submit a PR.  Otherwise, I'll add this to my backlog.

I like it, but could this maybe be a new class CompoundLoss that leverages the SimpleLoss class? I would like SimpleLoss to remain, well, simple, so that newcomers to the field will be able to have an entry point to quantifying their risks.

It seems like there could also be a better decomposition as you suggest where SimpleLoss contains a single loss distribution (by default a fixed frequency and lognormal magnitude) and CompoundLoss can contain multiple (potentially different) loss distributions.

I did actually implement an abstract Loss() class that can contain any desired frequency distribution and magnitude distribution. Thinking about your CompoundLoss() suggestion, it seems like what you're asking for is the ability to add additional magnitudes given that the loss has occurred in a particular simulated year.
However (at least in the FAIR framework) isn't there also a frequency attached to each of the secondary risks? Or would it more appropriately be modeled as a probability that is conditional on the main loss frequency? In other words, in a particular simulated year, if the main loss occurs once, then for each secondary risk we would draw a random value and if it is <= than the attached probability, the secondary loss occurs and we draw from the magnitude.
The two alternatives are: use a frequency value (in which case a secondary risk could occur more than once for each main loss event) or don't use a probability or frequency, and just draw from the magnitude for each secondary risk.
Thoughts?


Add instructions for ModalModule import

Given issues #1027 and #1143, ModalModule import instructions should indicate where to import the module.
Duplicate of closed PR #1171.

Current coverage is 85.62% (diff: 100%)

Merging #1198 into development will not change coverage

@@           development      #1198   diff @@
=============================================
  Files               35         35
  Lines             1280       1280
  Methods            228        228
  Messages             0          0
  Branches           213        213
=============================================
  Hits              1096       1096
  Misses             184        184
  Partials             0          0

Powered by Codecov. Last update a1b805f...a4d5989

Awesome, thanks!


Will the result of captioning be hugely effected if I don't use object tags?

Hi, thanks for your amazing work.
Now I  want to train your image caption model on my own dataset. For the reason of experimental setting, I can only use texts and image region feature. During training process, I concat those two and ignore the object tags. Will it hugely effect the result?

How did u extract image features?

Hi, thanks for your amazing work.
Now I want to train your image caption model on my own dataset. For the reason of experimental setting, I can only use texts and image region feature. During training process, I concat those two and ignore the object tags. Will it hugely effect the result?

Hi, the main novelty about Oscar is to use object tags. You can check Fig. 6 of our paper to see the performance different with/without tags.

How did u extract image features?

We use the model trained in BUTD paper.

Hi, thanks for your amazing work.
Now I want to train your image caption model on my own dataset. For the reason of experimental setting, I can only use texts and image region feature. During training process, I concat those two and ignore the object tags. Will it hugely effect the result?

Hi, the main novelty about Oscar is to use object tags. You can check Fig. 6 of our paper to see the performance different with/without tags.

Thanks for your kind reply! It turns out I didn't read the paper carefully


Use the editor theme accent color for 2D selections

Follow-up to #40106.
This improves the visual consistency of selections in the editor.
Preview (with default editor theme)

Maybe it's just me, but I fear that this blue might be a little bit too subtle as a selection outline. I believe a selection should be very visible on most backgrounds, so I would avoid anything looking like a sky color.
I agree it's more consistent, but I think this hurts legibility.

@groud Maybe I could draw translucent black lines behind the bright lines so they're visible on any background. If you're OK with the idea, I can give it a try :slightly_smiling_face:

I don't know, I still believe a red or orange outline is more legible than a blue rectangle, even with a darkened background. (though the background could be a good addition anyway). If you feel that this orange it is kind of an "isolated color" in the editor theme, I would prefer using it elsewhere whether than replacing it by a blue tint. There are likely other places in the editor which a more eye-popping color.
But we probably need more opinions on this.

Given that orange would be just as illegible against a bright red/orange background as blue against a sky/blue background, maybe the selection color should be somehow adaptive or at least changeable?

Indeed, but a blue background is more common than a red/orange one. ^^

the selection color should be somehow adaptive or at least changeable per project?

I believe it already is a project setting, but I might be wrong.

I believe it already is a project setting, but I might be wrong.

There isn't, but I don't think adding a project setting is a good solution. Making the outline more visible regardless of the color is likely a better idea. Either way, you could always tweak your editor theme's accent color to change the selection color.

There isn't, but I don't think adding a project setting for this is a good solution. Making the outline more visible regardless of the color is likely a better idea.

Sure, the problem is that usually, this is quite an hard to solve problem. You could dynamically change the color, but it would be confusing, as it would make it harder to identify the selection rectangle at first glance.
You could eventually use two colors, kind of like what image editors do with their dashed lines. I am not sure it would look good but it could work.

Either way, you could always tweak your editor theme's accent color to change the selection color.

Thing is that they are completely unrelated things. The editor accent color is and should stay a cosmetic thing. The selection color is important for the editor usability, so those colors should not be driven by the same variable.

Needs a rebase.
We used some orange for 3D in #40106, should we do the same here?
Maybe it would be worth splitting the text UI accent color from the 2D/3D viewport accent color?

Since we went with orange in 3D, we can keep the current 2D selection color as it's already orange.


Hide cancel button on in-flight relay for recipient

Don't show recipients a cancel button for in-flight relays. Their app ought to claim it soon enough.

per our chat, I think the only issue is renaming cancelable back to claimable so as not to be confused with this new showCancel flag :+1:

For context, claimable was originally displayed everywhere we showed the status, such as here on the tx details screen:

someone commented that cancelable would be less confusing for users, hence the switch in the transform

Ah...perhaps that transform should be done in the tx details screen then?


Transition and promises

Well, the point here will be based on the use of react-resolver; but maybe this problem could affect a larger audience. What react resolver does, is that it wait for the data before rendering. Forget bout transitioning components then when using react-router.
I've looked into many issues here that could relate, but I can't get a real understanding of the state of this problem. Can react-router wait for the component to render and still manage a regular css transition ?

I'm sorry. I don't understand your question.

Hups, sorry for that.
I mean : if the next router renders with a delay, transition does not work.
React-router does not wait

@bbnnt you could just adapt my middleware component — that you referenced — for your use. It would enable you to use ReactCSSTransitionGroup. Or you can use react-resolver, although it seems somewhat incompatible with Flux architecture.
There is no built-in way of doing this, at least currently.

thx yep, I'll definetely look into, even if I'm not that really into flux, I think that'd be an added valu to have a better control over transitions. currently that's just a ng-animate-clone; feels like react can 'go further'
@mjackson there's this one too. My point here was about  having some kind of control over what's happening in the next controller — my example is bound to react resolver, but I guess there are needs for this elsewhere

is this still an issue @bbnnt ?

@knowbody here (https://github.com/rackt/react-router-mega-demo/blob/master/app/handlers/Root.js#L61) it handles the "page" load, first visit. Correct me if I'm wrong
But you can expect "waiting for data" during your navigation from one component to the other.
I guess it is more about a global app architecture than just react-router; still an issue but I'll find out somehow


PSMDB_406: vault encryption - add migration steps

Reworked in https://github.com/percona/psmdb-docs/pull/270


relative_url not working

Setting relative_url in the config.yml file doesn't have any effect. I can only get image sources to the absolute url.

It appears to be working to me, can you share the relevant line in your Gemfile?
It's a relatively recent feature addition, maybe you're on an older version? Try running bundle update

Since it's been a few days I'm going to close this, but feel free to re-open it if you need more help.


[SPARK-8265] [MLlib] [PySpark] Add LinearDataGenerator to pyspark.mllib.utils

It is useful to generate linear data for easy testing of linear models and in general. Scala already has it. This is just a wrapper around the Scala code.

cc: @davies Please have a look.

Merged build triggered.

Merged build started.

Test build #34492 has started for   PR 6715 at commit f234b4c.

Test build #34492 has finished for   PR 6715 at commit f234b4c.

This patch passes all tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
class LinearDataGenerator(object):

Merged build finished. Test PASSed.

Build triggered.

Build started.

Test build #35147 has started for   PR 6715 at commit 504ae9a.

Merged build triggered.

Merged build started.

ping @mengxr I fixed the minor style fixes and pushed. Hopefully it should look good now.

Test build #35148 has started for   PR 6715 at commit b10ced1.

Test build #35148 has finished for   PR 6715 at commit b10ced1.

This patch passes all tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
class LinearDataGenerator(object):

Merged build finished. Test PASSed.

Test build #35147 has finished for   PR 6715 at commit 504ae9a.

This patch passes all tests.
This patch does not merge cleanly.
This patch adds the following public classes (experimental):
class LinearDataGenerator(object):

Build finished. Test PASSed.

jenkins retest this please

Merged build triggered.

Merged build started.

Test build #35162 has started for   PR 6715 at commit b10ced1.

Test build #35162 has finished for   PR 6715 at commit b10ced1.

This patch passes all tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
class LinearDataGenerator(object):

Merged build finished. Test PASSed.

@mengxr Thanks for your comments. I have addressed them.

Merged build triggered.

Merged build started.

Test build #35221 has started for   PR 6715 at commit 1bce3f5.

Test build #35221 has finished for   PR 6715 at commit 1bce3f5.

This patch fails Python style tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
class LinearDataGenerator(object):

Merged build finished. Test FAILed.

Merged build triggered.

Merged build started.

Test build #35224 has started for   PR 6715 at commit 3e5b51d.

Test build #35224 has finished for   PR 6715 at commit 3e5b51d.

This patch passes all tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
class LinearDataGenerator(object):

Merged build finished. Test PASSed.

Rebased over master.

Merged build triggered.

Merged build started.

Test build #35312 has started for   PR 6715 at commit 6182884.

Test build #35312 has finished for   PR 6715 at commit 6182884.

This patch passes all tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
      //     class ParentClass(parentField: Int)
      //     class ChildClass(childField: Int) extends ParentClass(1)
          // If the class type corresponding to current slot has writeObject() defined,
          // then its not obvious which fields of the class will be serialized as the writeObject()
class StreamingKMeansModel(KMeansModel):
class StreamingKMeans(object):
class LinearDataGenerator(object):
abstract class GeneratedClass
case class Md5(child: Expression)

Merged build finished. Test PASSed.

LGTM. Merged into master. Thanks! Apache JIRA is down. I will update the JIRA later.


Song title mini viewer is jittery

Describe your problem. Please include at least reproduction steps, expected output, and environment.

This issue is derived from an issue from the original repo. The issues they raised were:

Icon moves with scrolling text.
Scrolling text appears jittery and inconsistent (compare with seconds on clock)

Should be fixed by using a monospaced font. That might not be possible, and certainly won't look good.

Partially addressed. Fully addressed with v10.0.0 of Electron. For now, closing this ticket as solved in v0.9.0.