Depend on sus instead of rspec

Other places seem to have been updated already.

Types of Changes

Maintenance.

Contribution

[x] I agree to the Developer's Certificate of Origin 1.1.

Thanks for bringing this to my attention and your contribution.
I had to do a little more to get things back to green, so just made a separate commit: https://github.com/socketry/protocol-http/commit/21ce2401570ccfe55206ccb675cbf557f1710072


_WD_SetElementValue + FF window is covered

I will be able to login to the restricted website to test this
$_WD_OPTION_Advanced TheDcoder fix
in next few days.

Already tested.
Works but not so good as I was expecting.
My issue may be related to FF version, driver version, windows version, any other ENV setting.
Here is what I'm having a problem (more or less accurate description).
When FF window is visible (aka TOPMOST) then all is fine.
When FF window is covered by another window, then value is set (visually you can notice that it was set) but when program click "SUBMIT" button then it turns out that the value has not been set correctly.
Originally posted by @mlipok in https://github.com/Danp2/au3WebDriver/issues/333#issuecomment-1173442432

I'm in process of preparing video from this issue.
I will send them to @TheDcoder  and @Danp2  via PM on the Au3Fourm

It would be great if you could find a different website that is accessible by all. You will likely need this if you need to report to Mozilla.

It would be great if you could find a different website that is accessible by all. You will likely need this if you need to report to Mozilla.

I know, but it would be a stroke of luck to find such a case.

Have you tried analyzing the site with https://builtwith.com/? That may help with understanding the framework / libraries involved, which could lead to finding another site with similar behavior.

I was strugling with this all the day and I think I have found solution to my problems.
But as my client end work for today I must wait till tomorow to end my testing.
Curently I think the recent PR _WD_SetElementValue $_WD_OPTION_Advanced usage
did this trick because it was related to:

All other issues may be related to my own code issues, but as I said I must wait till tomorrow to finish fixing/refactoring of my own code.

@mlipok Ok to close this?

Because of: I must finally finish one of my project related to this issue
.....
In this weekend I will do deeper research to check and confirm if all is fine.

Works well.
This issue colud be closed.


Not EqualTo

Hi!
How can I create a field with a validator that has to be different (not equalto) another field?
Trying not EqualTo(args) doesn't work at all
Thanks

@Garito define a instance method, for example, you want foo equals to bar:
def validate_foo(self, field):
    if field.data != self.bar.data:
        raise some error

Yeah, is what I've finally done
Thanks!


fix: add concurrency_method docs

Was added on April 17 by @matthewd :)
cc @keithpitt
Some examples here: https://github.com/joscha/buildkite-graph/pull/42/
cc @uri-canva @arromer

Thanks so much @joscha - this one dropped through the cracks. :(

Thanks so much @joscha - this one dropped through the cracks. :(

never too late :)

:tada:


Add block cancel when GetBlockTask throws exception

Motivation
A scenario will lead to the invoker wait permanently when using SourceHandle. That is, the SourceHandle's EOS has been received while the GetDataBlockTask is still in progress. And then, the GetDataBlockTask throws exception. If the invoker is waiting the blocked future it will be blocked permanently here.
Solution
Cancel the blocked if the GetDataBlockTask threw exception

Coverage increased (+0.05%) to 54.158% when pulling 9d2de7552e7a7be9a428f0538ea4586659f57efd on xingtanzjr/fix_sourceHandle into b2520b31b02902921dad83926c9bba6eaafffabe on master.


Add new date validation rules to form_validation library

This PR includes 3 new Form_validation rules:

valid_date
date_is_past
date_is_future

Rule reference in docs are updated as well

Picky, but in the docs wouldn't the description for valid_past and valid_future say "invalid OR is in the future/past"?

Yeah valid point, I'll correct it in the morning

Wording is fixed

Duplicate of #4346.


ModuleNotFoundError: No module named 'urlparse' when running demo-flask app

when running demo-flask app we get the error
ModuleNotFoundError: No module named 'urlparse'

How to fix:
Change the code at line 6
from:
from urlparse import urlparse
to:
from urllib.parse import urlparse

I guess this is something required while using py3
Can you provide a PR and make it backward-compatible?


Can I use existing CNAME for new certificate?

I would like to use already created ACME-DNS registration and registered DNS to create a new wildcard certificate for the domain.
I called API ACME-DNS service from here (HTTP POST) https://auth.acme-dns.io/register and received domain and API credentials.
I then call wacs.exe
M (manual mode),
4 (manual imput)
*.[mydomain].net,
default name
2: [dns-01] Create verification records with acme-dns (https://github.com/joohoi/acme-dns),
acme-dns server : https://auth.acme-dns.io
But this is the issue a new set of credentials and CNAME record is created.
Is there a way to reuse the ones I have already created? We would like to retrieve new & renew SSL certificates for the wildcard domain on multiple machines by a single script and using the pre-generated CNAME records.
Is this possible or am I missing something?
Thanks!

If you create an acme-dns registration manually in the program, the credentials are stored in %programdata%\win-acme\[acme-domain]\acme-dns\[acme-dns-domain]\[your-domain].json. If you copy that file to all your servers, they will use the same registration and won't ask questions about creating a new one.
By the way I would recommend using command line parameters to call into wacs.exe instead of using a pre-defined combination of keystrokes. You never know when something in the (order of) options in the UI might change that causes your script to break.

Thank you very much for the quick response. I will take a look at this.
Yes, I will use the command line params when I figure them out. I am still testing this in the manual mode..

Great, this works like a charm. Many thanks!

I have one more related question. If I install/create new certificate or renew in the unattended mode, which already works for me. Is there a way to specify path the the domain specific credentials .json file and use other path than %programdata%\win-acme[acme-domain]\acme-dns[acme-dns-domain][your-domain].json?

Hi @pelnarp, no you can't. You could create the file manually, or with another script, before starting wacs.exe though. And maybe use a soft/hardlink to redirect the path.

There is one more issue. We want to run the script in fully unattended manner, without having to provide any input.
There are questions the wacs cmd tool can ask on the way (not always), accept TOS (accepted by argument --accepttos), default email address for renewal failures (--emailaddress).
But if there is already an existing task we get this question "Do you want to replace the existing task?"
Is there a way to get this overwritten automatically without asking and getting the command line stopped?

The question "Do you want to replace the existing task?" should only show up when you a running from the interactive menu, though I've spotted a bug where the question could pop up during an unattended run when the task already exists, but is not healthy (i.e. it's disabled or pointing to an unexpected path). That bug will be fixed in the next release, which you can preview here: https://ci.appveyor.com/project/WouterTinus/win-acme-s8t9q/builds/29870536/artifacts

Thank you, much appreciated!

It seems to me, there probably should be a way to turn off completely any input from the user for the unattended mode. In the unattended mode you want the command line to handle the job on its own, timeout or exit with an error code if some parameter should be provided or use the default. But waiting for user input in the unattended mode defeats the purpose of the unattended mode, does it not?
The most common issue I am facing now is that when I run the wacs command line in unattended mode from normal command line (get the scheduled task registered, etc. - all works fine) and then do the same from a new process run inside our WPF application (which tries does the same job, register the SSL certificate), the process is waiting for an input asking if the task should be overwritten.
It is probably because of the different location of the win-acme cmd or some other identifier, which is different.
To explain, we are not building UI to wrap the win-acme command line tool. We have a medical app that needs to create and register on the localhost an SSL certificate to provide an intranet web application with SSL for a given domain. But in this scenario we are hitting this issue.
We can follow-up via email, please feel free to contact me at<EMAIL_ADDRESS>Thanks;)

It seems to me, there probably should be a way to turn off completely any input from the user for the unattended mode. In the unattended mode you want the command line to handle the job on its own, timeout or exit with an error code if some parameter should be provided or use the default. But waiting for user input in the unattended mode defeats the purpose of the unattended mode, does it not?

Of course you are right, that's why I classified that behaviour as a bug and fixed it - at least in one scenario. You didn't provide feedback about the test build that I linked in my previous comment, did you try that?

We can follow-up via email, please feel free to contact me at<EMAIL_ADDRESS>Thanks;)

Your application definitely sounds interesting, but I only do private consulting/support for Patreon members though. If you're planning on rolling out win-acme as part of a commercial solution it would probably not be a bad idea to have some support at hand :wink:

Thank you very much, I appreciate your help! I can confirm that the unofficial release you have shared above fixed the issue and the wacs tool does not hang now. From: Wouter TinusSent: Monday, January 6, 2020 10:35 PMTo: PKISharp/win-acmeCc: pelnarp; MentionSubject: Re: [PKISharp/win-acme] Can I use existing CNAME for new certificate? (#1285) It seems to me, there probably should be a way to turn off completely any input from the user for the unattended mode. In the unattended mode you want the command line to handle the job on its own, timeout or exit with an error code if some parameter should be provided or use the default. But waiting for user input in the unattended mode defeats the purpose of the unattended mode, does it not?Of course you are right, that's why I classified that behaviour as a bug and fixed it - at least in one scenario. You didn't provide feedback about the test build that I linked in my previous comment, did you try that?We can follow-up via email, please feel free to contact me at petr@pelnar.netThanks;)Your application definitely sounds interesting, but I only do private consulting/support for Patreon members though. If you're planning on rolling out win-acme as part of a commercial solution it would probably not be a bad idea to have some support at hand 😉—You are receiving this because you were mentioned.Reply to this email directly, view it on GitHub, or unsubscribe.


BBD V0.2.4: Automatic loading bugs

I hope this is a false flag but automatic loading seems to have broken on my end, console was displaying this every time I saved a theme file:

Also the on/off switch for automatic loading does not visually update unless you re-click the tab.

that error is fixed, will look into the enabling/disabling auto loading bug


Add license to project

Please consider adding a license to this project so that others can use it more flexibly.
Ideally MIT to match Trix itself. IANAL.

https://github.com/lazaronixon/trix-extensions/commit/9ab2a904b0a7782d475fc17935621b2096a3a3be


Upgrade to yaml.v3 3.0.1

Ref CVE-2022-28948

Codecov Report

Merging #6 (3901363) into main (9998b96) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##              main        #6   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files            4         4
  Lines           66        66
=========================================
  Hits            66        66

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9998b96...3901363. Read the comment docs.


Disk space delimma

We are presently at 77% disk space used on one of our nodes, and 55% on the others.
As deis-builder is on the first one, it has started dying with "no space left on device" during deploys.
At the time of these space errors, this is what df looked like from within deis-builder:
$ nse deis-builder
groups: cannot find name for group ID 11
root@42f041aba839:/# df -k
df: `/etc/resolv.conf (deleted)': No such file or directory
Filesystem     1K-blocks     Used Available Use% Mounted on
rootfs         102366188 77256868  23987612  77% /
/dev/xvda9     102366188 77256868  23987612  77% /
tmpfs            7704148        0   7704148   0% /dev
shm                65536        0     65536   0% /dev/shm
/dev/xvda9     102366188 77256868  23987612  77% /.dockerinit
/dev/xvda9     102366188 77256868  23987612  77% /etc/hostname
/dev/xvda9     102366188 77256868  23987612  77% /etc/hosts
/dev/xvda9     102366188 77256868  23987612  77% /var/lib/docker
cgroup           7704148        0   7704148   0% /sys/fs/cgroup
/dev/xvda9     102366188 77256868  23987612  77% /var/lib/docker/btrfs

Will have to investigate more on that front.

@bacongobbler did we clean this up at some point?

Unfortunately not. At the moment, there's no way to determine which parent images to clean up other than the app image itself. :(

@ianblenke I used some of your tips in #3021

There is another benefit of having cephfs occasionally kill instances: we're only running at 6% of our 1TB volumes on our 5 deis nodes. It helps when you keep building new instances and the old images eventually disappear organically on their own.

Failing proper LRU tracking for cached containers, I really the idea of introducing a little chaos @ianblenke.
If cached parent containers were to be randomly selected for deletion @bacongobbler, they would probably be available to the builder (good for build speed as noted elsewhere) but may have been randomly deleted (minor penalty since they would transparently be pulled back in).
So the longer the interval since last use of a parent container, the more likely that parent container will have been randomly purged. Entropy :tada:

@ianblenke @wenzowski What do you guys think about closing this? A good discussion around disk usage, but not sure if there's anything actionable out of it. If there is, we should probably file a separate issue to track.

I've been using 1TB root volumes now to ensure I never run into btrfs issues again. Beyond CoreOS 561, it defaults to ext4 + OverlayFS anyway, so I'm not sure the same btrfs issues will continue to apply. I'm ok with closing this if you are.

it defaults to ext4 + OverlayFS anyway

overlay is selected only if the module overlay is loaded (and by default is not)

Good to know. When stable makes it to 561+, we should definitely try and make sure the overlay module is loaded on boot before docker starts.

Making sure overlay is loaded on boot seems actionable. New issue? Otherwise ok to close for me.

Making sure overlay is loaded on boot seems actionable. New issue?

Sounds good to me.


Add ability to change the "m" key keybind

Even better if it also supports mouse clicks and such.
Based on feedback on reddit: https://www.reddit.com/r/EscapefromTarkov/comments/fmpevr/i_made_a_map_overlay_for_tarkov/flb239x

Implementing the mouse listener is a bit more complex as you need to listen to mouse events when the application is not in focus. There are some discussions on the topic here. https://stackoverflow.com/questions/11607133/global-mouse-event-handler
It's shouldn't be too hard to do. Once the listener is in place you simply modify this function to also handle mouse events. However I would avoid setting the left mouse button to minimize as it would prevent the user from exiting the application or changing settings. https://github.com/UberSwe/Tarkov-Map-Overlay/blob/master/TarkovMapOverlay/MainWindow.xaml.cs#L93L114


Scatter chart does not emit click event

The scatter chart is missing the click event dispatch. We'll need to add this to make scatter charts interaction sources.

Fixed in #30.


phase_bin_magseries_with_errs: add weights option

Useful for whenver you have a flux/magnitude time series with points
that have different error bars (for instance, from different
instruments), and you want to bin them.
In these cases, take a weights vector, and use np.average(..., weights=...) instead of the unchanged default median-averaging.

Thanks!
Do you mind adding the new kwargs to the docstring for phase_bin_magseries_with_errs()?

Thanks! Merged.


There seems to be a bug in run.py on eval_output_path

In line 102,
eval.main(eval_config)
the eval_output_path is replaced (eval.py line 25):
args.output.replace('__LOGDIR__', real_logdir)
However, in line 104 res_json = json.load(open(eval_output_path)) the eval_output_path is not replaced.
I got a FileNotFoundError during eval on line 104 and I wonder if this is the reason.
Thanks!

I just commented that line out, and I moved the print line after it into utils/evalutation.py. Those lines of code are relatively unimportant, they just print the accuracy, but the accuracy is also saved in the output json file so you are not really losing much if you just delete those two lines altogether

Ok, @Sea-Snell  thank you for this proposition.
I did the following thing to keep printing the accuracy :
in the file experiments/spider-glove-run.jsonnet, I replaced the value of eval_output by "logdir/glove_run/bs=20,lr=7.4e-04,end_lr=0e0,att/ie_dirs" ant it works.


Build of trunk on MSYS2 failed in test suite

Building fails in the test suite:
from C:/msys64/home/rute/dev/pkg/duckdb-git/src/duckdb/test/sqlite/test_sqllogictest.cpp:28,                  from test_sqllogictest.cpp: C:/msys64/home/rute/dev/pkg/duckdb-git/src/duckdb/src/include/duckdb/common/file_system.hpp:56:27: error: expected unqualified-id before numeric constant    56 |  static constexpr uint8_t FILE_CREATE = 1 << 3;       |                           ^~~~~~~~~~~ C:/msys64/home/rute/dev/pkg/duckdb-git/src/duckdb/src/include/duckdb/common/serializer/buffered_file_writer.hpp:22:101: error: expected unqualified-id before numeric constant    22 |  BufferedFileWriter(FileSystem &fs, string path, uint8_t open_flags = FileFlags::WRITE | FileFlags::FILE_CREATE);       |                                                                                ^~~~~~~~~~~
Disabling the unit test temporary fixes the problem. Not sure about the
cause. Perhaps the symbol is defined elsewhere?

Seems to be an issue with the FILE_CREATE macro being defined by windows.h. We should rename the FILE_CREATE, perhaps to DFILE_CREATE_NEW or so.

Its not windows.h, its the bastardised version of it that mingw uses... But indeed, another rename is probably in order.

I can confirm that renaming the symbol fixes the build problem.
These are a bit tricky as for sure a common name will collide
on some exotic platform or combination in the future.
Perhaps a unique prefix like DDB_[NAME] could be used?
Not sure if these symbols are end user visible (API) though,
probably do not want to change to much of that.

Should be fixed now, feel free to reopen if the issue persists


pkg-config install fail. configure: error: C compiler cannot create executables

Please follow the general troubleshooting steps first:

[x] Ran brew update and retried your prior step?
[x] Ran brew doctor, fixed as many issues as possible and retried your prior step?

Bug reports:
https://gist.github.com/anonymous/ccf33571265d355163362e2402c9b09d
I am trying to install several packages, with failures related to pkg-config, and am getting errors (see gist), which I believe are fundamentally related to configure: error: C compiler cannot create executables
I've looked at a few other bug report of this nature, and they seem to be a bit, ahem, complicated.

The relevant error is
/usr/bin/ld: /mnt/lustre/macmaneslab/macmanes/linuxbrew/.linuxbrew/lib/../lib64/crti.o: unrecognized relocation (0x2a) in section `.init'
/usr/bin/ld: final link failed: Bad value

https://gist.github.com/anonymous/ccf33571265d355163362e2402c9b09d#file-config-log-L98

OS: Scientific Linux release 7.2 (Nitrogen)

Try brew install binutils

seems like binutils already installed installed:
brew install binutils
Updating Homebrew...
==> Homebrew has enabled anonymous aggregate user behaviour analytics.
Read the analytics documentation (and how to opt-out) here:
  https://git.io/brew-analytics

==> Auto-updated Homebrew!
Updated 1 tap (homebrew/core).
No changes to formulae.

Warning: binutils-2.27 already installed

[macmanes@premise linuxbrew]$ brew install pkg-config
==> Downloading https://pkgconfig.freedesktop.org/releases/pkg-config-0.29.1.tar.gz
Already downloaded: /mnt/lustre/macmaneslab/macmanes/.cache/Homebrew/pkg-config-0.29.1.tar.gz
==> ./configure --prefix=/mnt/lustre/macmaneslab/macmanes/linuxbrew/.linuxbrew/Cellar/pkg-config/0.29.1_2 --disable-host-tool --with-internal-glib --with-pc-path=/mnt/lustre/macmaneslab/macmanes/linuxbrew/.linuxbrew/lib/pkgconfig:/mnt/lustre/macmaneslab/macmanes/linuxbrew/.linuxbrew/share/pkgconfig:/usr/local/lib/pkg
Last 15 lines from /mnt/lustre/macmaneslab/macmanes/.cache/Homebrew/Logs/pkg-config/01.configure:
checking for a BSD-compatible install... /usr/bin/install -c
checking whether build environment is sane... yes
checking for a thread-safe mkdir -p... /usr/bin/mkdir -p
checking for gawk... gawk
checking whether make sets $(MAKE)... yes
checking whether make supports nested variables... yes
checking build system type... x86_64-unknown-linux-gnu
checking host system type... x86_64-unknown-linux-gnu
checking how to print strings... printf
checking for style of include used by make... GNU
checking for gcc... /mnt/lustre/macmaneslab/macmanes/linuxbrew/.linuxbrew/bin/gcc-5
checking whether the C compiler works... no
configure: error: in `/tmp/pkg-config-20161207-98803-ibkli8/pkg-config-0.29.1':
configure: error: C compiler cannot create executables
See `config.log' for more details

READ THIS: https://github.com/Linuxbrew/brew/blob/master/docs/Troubleshooting.md#troubleshooting

You'll need to troubleshoot why pkg-config is picking up /usr/bin/ld rather than $(brew --prefix)/bin/ld. Try
brew link binutils
which -a ld
brew sh <<<'which -a ld'
brew install -dv pkg-config

select shell then run which -a ld

You want to see in config.log:
configure:4406: checking for ld used by /home/sjackman/.linuxbrew/bin/gcc-5
configure:4473: result: /home/sjackman/.linuxbrew/bin/ld

Please report the output of
$(brew --prefix gcc)/libexec/gcc/x86_64-unknown-linux-gnu/5.3.0/collect2 --version

$(brew --prefix gcc)/libexec/gcc/x86_64-unknown-linux-gnu/5.3.0/collect2 --version

collect2 version 5.3.0
/usr/bin/ld --version
GNU ld version <IP_ADDRESS>.1-55.el7 20130226
Copyright 2013 Free Software Foundation, Inc.
This program is free software; you may redistribute it under the terms of
the GNU General Public License version 3 or (at your option) a later version.
This program has absolutely no warranty.

not sure if I'm doing these steps exactly right, so let me know.
which ld
~/linuxbrew/.linuxbrew/bin/ld

[macmanes@premise linuxbrew]$ /usr/bin/ld --version
GNU ld version <IP_ADDRESS>.1-55.el7 20130226

brew link binutils
Warning: Already linked: /mnt/lustre/macmaneslab/macmanes/linuxbrew/.linuxbrew/Cellar/binutils/2.27
To relink: brew unlink binutils && brew link binutils
[macmanes@premise linuxbrew]$ ld --version
GNU ld (GNU Binutils) 2.27

which -a ld
~/linuxbrew/.linuxbrew/bin/ld
~/linuxbrew/.linuxbrew/bin/ld
/usr/bin/ld

[macmanes@premise linuxbrew]$ brew sh <<<'which -a ld'
Your shell has been configured to use Homebrew's build environment:
this should help you build stuff. Notably though, the system versions of
gem and pip will ignore our configuration and insist on using the
environment they were built under (mostly). Sadly, scons will also
ignore our configuration.
When done, type `exit'.
/mnt/lustre/macmaneslab/macmanes/linuxbrew/.linuxbrew/bin/ld
/mnt/lustre/macmaneslab/macmanes/linuxbrew/.linuxbrew/bin/ld
/usr/bin/ld

[macmanes@premise linuxbrew]$ brew install -dv pkg-config
/mnt/lustre/macmaneslab/macmanes/linuxbrew/.linuxbrew/Library/Homebrew/brew.rb (Formulary::FormulaLoader): loading /mnt/lustre/macmaneslab/macmanes/linuxbrew/.linuxbrew/Library/Taps/homebrew/homebrew-core/Formula/pkg-config.rb
/mnt/lustre/macmaneslab/macmanes/linuxbrew/.linuxbrew/Library/Homebrew/build.rb (Formulary::FromPathLoader): loading /mnt/lustre/macmaneslab/macmanes/linuxbrew/.linuxbrew/Library/Taps/homebrew/homebrew-core/Formula/pkg-config.rb
==> Downloading https://pkgconfig.freedesktop.org/releases/pkg-config-0.29.1.tar.gz
Already downloaded: /mnt/lustre/macmaneslab/macmanes/.cache/Homebrew/pkg-config-0.29.1.tar.gz
==> Verifying pkg-config-0.29.1.tar.gz checksum
tar xzf /mnt/lustre/macmaneslab/macmanes/.cache/Homebrew/pkg-config-0.29.1.tar.gz
==> ./configure --disable-debug --prefix=/mnt/lustre/macmaneslab/macmanes/linuxbrew/.linuxbrew/Cellar/pkg-config/0.29.1_2 --disable-host-tool --with-internal-glib --with-pc-path=/mnt/lustre/macmaneslab/macmanes/linuxbrew/.linuxbrew/lib/pkgconfig:/mnt/lustre/macmaneslab/macmanes/linuxbrew/.linuxbrew/share/pkgconfig:/usr/local/lib/pkgconfig:/usr/lib/pkgconfig:/mnt/lustre/macmaneslab/macmanes/linuxbrew/.linuxbrew/Library/Homebrew/os/mac/pkgconfig/0
checking for a BSD-compatible install... /usr/bin/install -c
checking whether build environment is sane... yes
checking for a thread-safe mkdir -p... /usr/bin/mkdir -p
checking for gawk... gawk
checking whether make sets $(MAKE)... yes
checking whether make supports nested variables... yes
checking build system type... x86_64-unknown-linux-gnu
checking host system type... x86_64-unknown-linux-gnu
checking how to print strings... printf
checking for style of include used by make... GNU
checking for gcc... /mnt/lustre/macmaneslab/macmanes/linuxbrew/.linuxbrew/bin/gcc-5
checking whether the C compiler works... no
configure: error: in `/tmp/pkg-config-20161207-112122-q3b44z/pkg-config-0.29.1':
configure: error: C compiler cannot create executables
See `config.log' for more details
/mnt/lustre/macmaneslab/macmanes/linuxbrew/.linuxbrew/Library/Homebrew/build.rb (Formulary::FormulaLoader): loading /mnt/lustre/macmaneslab/macmanes/linuxbrew/.linuxbrew/Library/Taps/homebrew/homebrew-core/Formula/glibc.rb
/mnt/lustre/macmaneslab/macmanes/linuxbrew/.linuxbrew/Library/Homebrew/build.rb (Formulary::FormulaLoader): loading /mnt/lustre/macmaneslab/macmanes/linuxbrew/.linuxbrew/Library/Taps/homebrew/homebrew-core/Formula/gcc.rb
/mnt/lustre/macmaneslab/macmanes/linuxbrew/.linuxbrew/Library/Homebrew/build.rb (Formulary::TapLoader): loading /mnt/lustre/macmaneslab/macmanes/linuxbrew/.linuxbrew/Library/Taps/linuxbrew/homebrew-xorg/xorg.rb
/mnt/lustre/macmaneslab/macmanes/linuxbrew/.linuxbrew/Library/Homebrew/debrew.rb:11:in `raise'
FormulaUnavailableError: No available formula with the name "xorg"
1. raise
2. ignore
3. backtrace
4. irb
5. shell
Choose an action: 5
When you exit this shell, you will return to the menu.

bash-4.2$ which -a ld
/usr/bin/ld

PS, ths doesn't have anything to do with the symlinking of the locks folder to /tmp, right?

I'm pretty sure it's unrelated.

FormulaUnavailableError: No available formula with the name "xorg"

Run brew tap linuxbrew/xorg

new error after xorg installed:
 brew install -dv pkg-config
/mnt/lustre/macmaneslab/macmanes/linuxbrew/.linuxbrew/Library/Homebrew/brew.rb (Formulary::FormulaLoader): loading /mnt/lustre/macmaneslab/macmanes/linuxbrew/.linuxbrew/Library/Taps/homebrew/homebrew-core/Formula/pkg-config.rb
/mnt/lustre/macmaneslab/macmanes/linuxbrew/.linuxbrew/Library/Homebrew/build.rb (Formulary::FromPathLoader): loading /mnt/lustre/macmaneslab/macmanes/linuxbrew/.linuxbrew/Library/Taps/homebrew/homebrew-core/Formula/pkg-config.rb
==> Downloading https://pkgconfig.freedesktop.org/releases/pkg-config-0.29.1.tar.gz
Already downloaded: /mnt/lustre/macmaneslab/macmanes/.cache/Homebrew/pkg-config-0.29.1.tar.gz
==> Verifying pkg-config-0.29.1.tar.gz checksum
tar xzf /mnt/lustre/macmaneslab/macmanes/.cache/Homebrew/pkg-config-0.29.1.tar.gz
==> ./configure --disable-debug --prefix=/mnt/lustre/macmaneslab/macmanes/linuxbrew/.linuxbrew/Cellar/pkg-config/0.29.1_2 --disable-host-tool --with-internal-glib --with-pc-path=/mnt/lustre/macmaneslab/macmanes/linuxbrew/.linuxbrew/lib/pkgconfig:/mnt/lustre/macmaneslab/macmanes/linuxbrew/.linuxbrew/share/pkgconfig:/usr/local/lib/pkgconfig:/usr/lib/pkgconfig:/mnt/lustre/macmaneslab/macmanes/linuxbrew/.linuxbrew/Library/Homebrew/os/mac/pkgconfig/0
checking for a BSD-compatible install... /usr/bin/install -c
checking whether build environment is sane... yes
checking for a thread-safe mkdir -p... /usr/bin/mkdir -p
checking for gawk... gawk
checking whether make sets $(MAKE)... yes
checking whether make supports nested variables... yes
checking build system type... x86_64-unknown-linux-gnu
checking host system type... x86_64-unknown-linux-gnu
checking how to print strings... printf
checking for style of include used by make... GNU
checking for gcc... /mnt/lustre/macmaneslab/macmanes/linuxbrew/.linuxbrew/bin/gcc-5
checking whether the C compiler works... no
configure: error: in `/tmp/pkg-config-20161207-114949-s93d5k/pkg-config-0.29.1':
configure: error: C compiler cannot create executables
See `config.log' for more details
/mnt/lustre/macmaneslab/macmanes/linuxbrew/.linuxbrew/Library/Homebrew/build.rb (Formulary::FormulaLoader): loading /mnt/lustre/macmaneslab/macmanes/linuxbrew/.linuxbrew/Library/Taps/homebrew/homebrew-core/Formula/glibc.rb
/mnt/lustre/macmaneslab/macmanes/linuxbrew/.linuxbrew/Library/Homebrew/build.rb (Formulary::FormulaLoader): loading /mnt/lustre/macmaneslab/macmanes/linuxbrew/.linuxbrew/Library/Taps/homebrew/homebrew-core/Formula/gcc.rb
/mnt/lustre/macmaneslab/macmanes/linuxbrew/.linuxbrew/Library/Homebrew/build.rb (Formulary::TapLoader): loading /mnt/lustre/macmaneslab/macmanes/linuxbrew/.linuxbrew/Library/Taps/linuxbrew/homebrew-xorg/xorg.rb
/mnt/lustre/macmaneslab/macmanes/linuxbrew/.linuxbrew/Library/Homebrew/debrew.rb:11:in `raise'

BuildError: Failed executing: ./configure --disable-debug --prefix=/mnt/lustre/macmaneslab/macmanes/linuxbrew/.linuxbrew/Cellar/pkg-config/0.29.1_2 --disable-host-tool --with-internal-glib --with-pc-path=/mnt/lustre/macmaneslab/macmanes/linuxbrew/.linuxbrew/lib/pkgconfig:/mnt/lustre/macmaneslab/macmanes/linuxbrew/.linuxbrew/share/pkgconfig:/usr/local/lib/pkgconfig:/usr/lib/pkgconfig:/mnt/lustre/macmaneslab/macmanes/linuxbrew/.linuxbrew/Library/Homebrew/os/mac/pkgconfig/0

$(brew --prefix gcc)/libexec/gcc/x86_64-unknown-linux-gnu/5.3.0/collect2 --version

collect2 version 5.3.0
/usr/bin/ld --version

That's not good, but I'm not sure how to fix it. We want it to report Linuxbrew's ld. Here's the relevant documentation
https://gcc.gnu.org/onlinedocs/gccint/Collect2.html
Please report which -a real-ld

5. shell
Choose an action: 5
When you exit this shell, you will return to the menu.

bash-4.2$ which -a ld
/usr/bin/ld

That's the smoking gun! That shouldn't happen. Please report
brew install -dv pkg-config

Select shell and report echo $PATH
Any chance either your ~/.bashrc or ~/.bash_profile puts /usr/bin in your PATH before $(brew --prefix)/bin ?

I was having a similar problem:
$ brew install fontconfig openblas libpthread-stubs numpy scipy ==> Installing dependencies for fontconfig: pkg-config, libpng, freetype ==> Installing fontconfig dependency: pkg-config ==> Downloading https://pkgconfig.freedesktop.org/releases/pkg-config-0.29.2.tar.gz Already downloaded: /home/eerhan/.cache/Homebrew/pkg-config-0.29.2.tar.gz ==> ./configure --prefix=/home/eerhan/.linuxbrew/Cellar/pkg-config/0.29.2 --disable-host-tool --with-internal-glib -- Last 15 lines from /home/eerhan/.cache/Homebrew/Logs/pkg-config/01.configure: checking for a BSD-compatible install... /usr/bin/install -c checking whether build environment is sane... yes checking for a thread-safe mkdir -p... /bin/mkdir -p checking for gawk... gawk checking whether make sets $(MAKE)... yes checking whether make supports nested variables... yes checking build system type... x86_64-unknown-linux-gnu checking host system type... x86_64-unknown-linux-gnu checking how to print strings... printf checking for style of include used by make... GNU checking for gcc... gcc-5 checking whether the C compiler works... no configure: error: in '/tmp/pkg-config-20170425-148819-q05kra/pkg-config-0.29.2': configure: error: C compiler cannot create executables See 'config.log' for more details
But it was fixed when I reinstalled binutils with:
$brew unlink binutils $brew install binutils $brew install -dv fontconfig
Everything seems to work now.

I believe that this issue is resolved by both #272 and #355.
#355 probably means that #272 could be reverted.


Gremlin Support for Cosmosdb

Please tell us how you are using Spring Data Gremlin for Cosmos DB and how important it is to you by voting on this issue with the thumbs up emoji.

Please tell us how you are using Gremlin with Cosmos DB, and how important it is to support the Cosmos DB Gremlin API by vote on this issue with the thumbs up emoji.

We use Spring Data Gremlin for both Neptune and Cosmos. Please keep supporting it.

We are using CosmosDB/Gremlin, and are looking to use spring/java to expose some data via microservices. Would love this to get formal support, even if it's just community support! I can look to help make contributions.

We will re-evaluate Gremlin support in our next 6-month planning cycle in September. We welcome code contributions from anyone if we have enough evidence to prioritize this investment. In the meantime, please keep commenting and voting on this issue.
Spring on Azure team

We definitely need a Gremlin supported. This is an interface we use to work with Cosmos database as a graph database.
This is critical for us, so please keep it alive.

We are using this dependency for storing data in graph to maintain relationship between entities. We are exploring How to connect with multiple graphs from one application. It would be really helpful if you guide us. Please don't stop supporting it.


first SEP version of Microsoft Windows Event Log schema

Based on recommendation from my pull request on oasis-open/cti-stix2-json-schemas, i proposed a first version of Microsoft Windows Event Log Observable schema based on SANS recommendations: http://uk.sans.org/reading-room/whitepapers/logging/evtx-windows-event-logging-32949 .

Hey, @acabrol, thanks for this great contribution! Unfortunately I cannot accept your pull request until you execute an OASIS Contributor License Agreement (CLA). Also, please confirm in a written comment on this pull request that you agree to the OASIS CTI TC's decision to change the SEPs license from BSD3 to Apache License, Version 2.0. (Sorry about the extreme latency on my side - turns out working in a national CERT can be a bit hectic!)

Dear certbe-trey we agree to the OASIS CTI TC's decision to change the SEPs license from BSD3 to Apache License, Version 2.0.

@acabrol Thanks for the contribution! ^_^


WIP: s/Makefile/Taskfile/

Experimenting with replacing Makefile with Taskfile
https://taskfile.dev/

Codecov Report

:exclamation: No coverage uploaded for pull request base (main@eb0312c). Click here to learn what that means.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #137   +/-   ##
=======================================
  Coverage        ?   79.40%
=======================================
  Files           ?       13
  Lines           ?      869
  Branches        ?        0
=======================================
  Hits            ?      690
  Misses          ?      140
  Partials        ?       39

Flag
Coverage Δ

e2e
60.29% <0.00%> (?)

unit
76.90% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


Update description of push command

The push command doesn't behave like this since v0.30.0 or so. Found it a bit misleading while using Paket on the command line today.

thx


Autograd/sum

Not a bad first implementation for autograd sum. Once we're able to support non-contiguous tensors a lot of the code can just be replaced with a view and an expand.

Great job learning how the new autograd system - as it's got some more complexity, we need a couple extra unit tests. For each test, we want to try 3 things.

Test whether the basic backprop functionality works when the function is used in isolation. You've already implemented this! Looks great!
Test whether repeatedly calling forward and backprop on the function allocates new tensors (after the first forward/backprop it shouldn't). You can use the "allow_new_tensors" variable in ctrl to test this.
Test whether calling backprop when sum is used correctly backprops into previous variables. While this might seem like it naturally extends from (1), if backprop is done incorrectly, it'll break.

Because autograd fails silently, having all three of these tests (especially 2 and 3) is super important for all our variables. Would you be so kind as to add (2) and (3) to this before I merge? For an example of how it works, feel free to check out the current unit tests for Autograd in FloatTensorAutograd.cs.

Sure thing! I started putting tests in another place. I can move them to where you put them as well.

Going ahead and merging this for now because I need it for another feature :)

Still hoping to see those autograd tests :)


Client Holy Mountain Teleport Issue

Bug with client taking portals to holy mountains. Teleport seems to vary where it places the clients. No issues with host holy mountain. Multiple games teleported into holy mountain bricks. Forces a game restart.

It seems to work better when host goes first.


Turn off accesslog for admin

In adding prometheus scraping of Envoy to eliminate the overhead of the statsd-to-prometheus process, we have increased the logging of each proxy, due to the access log configuration of the admin cluster.
This PR turns that access logging off (sends to /dev/null per Envoy docs).

If no access log is desired specify ‘/dev/null’.

This should be a "good enough" fix for now, as the only access to the admin cluster exposed beyond localhost is the metrics path. Any localhost access to the admin cluster should be executed by an admin.
Related issues:

https://github.com/istio/istio/issues/8415
https://github.com/istio/istio/issues/9099

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: douglas-reid
If they are not already assigned, you can assign the PR to them by writing /assign @douglas-reid in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

For consistency, please also change https://github.com/istio/istio/blob/master/pilot/docker/envoy_pilot.yaml.tmpl#L2 and other ones in the directory.
/lgtm after that

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: kyessenov
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [kyessenov]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kyessenov good catch. thank you! done.

My merge powers don't work here.
/lgtm

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: kyessenov
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [kyessenov]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


Is not no longer updated, 1.6.0-RC3 has now been a long time

Is not no longer updated, 1.6.0-RC3 has now been a long time

then maybe is a risk adopt this library in new projects?

So, is anyone still working on the project? Developers are looking for help to make it progress somehow?
We are currently using it in several project and maybe we can provide some kind of help for the future...

+1
We use it still in our projects and want to use it in future. Should anybody fork it and port it to java 8?

I can not speak for @aaberg but I do think the ambition in the short term is to release v. 1.6.0 based on the latest commits in the master branch. @mbraunerDE I do think we should start a 2.0 branch that moves the minimum Java target to Java 8. In addition, to get more contributors would be nice. I will have a chat with the project owner ASAP and see how it can be managed better by the community in the future.

This project is not expected to be updated. It is recommended that everyone go to JOOQ or jdbi

@kkrgwbj I do think you are mistaken but as for any other opensource project it needs an active community to thrive. So we definitely need to build that in some way

Could we expect a stable 1.6.0 version or the project is dead forever?

any updates on this?

Any updates or progress? Will there be new a release?

it's still active this project?

any news????

Why this project Is stopped?

@prodsey you are right,  Sql2o will not be compatible with versions of Java after v. 1.8. To make it compatible with Java 9+ will require a major rewrite. The community is more than welcome to step up and make contributions if you want to see this happen in the future 👍

Closing this issue as 1.6.0 was finally released this weekend 👍


p1-test on pfSense (FreeBSD 12.3-STABLE) not working

Running ./p1-test stand-alone on /dev/ttyU0 does not seem work (no errors in errors.dat).
To get it working I first need to open a modem tool like cu -l /dev/ttyU0 -s 115200 and then execute ./p1-test /dev/ttyU0 errors.dat

In p1-lib.c, you need to set the initial baud rate in telegram_parser_open, else it keeps switching the wrong baud rates in telegram_parser_read when it tries to "guess" another baud rate.
include cfsetispeed in telegram_parser_open after the tcflush(..) line so it looks like this:
tcflush(obj->fd, TCIFLUSH);						# Flush any data still left in the input buffer, to avoid confusing the parsers cfsetispeed(&(obj->newtio), B115200); cfsetospeed(&(obj->newtio), B115200);
When guessing new baud rates its also better to check if a timeout has occurred. So that the program doesn't "switch" baud rates if it has not received a telegram. Therefore I also included some checking in telegram_parser_read and replaced the code around line 259 to look like this:
`
time_t tcurrent, tdiff = 0;
if (obj->tparsed != 0) tdiff = difftime(time(&tcurrent), obj->tparsed);
if (obj->len > 0) obj->tparsed = time(&tcurrent);

if (obj->terminal && obj->len == 0 && tdiff > obj->timeout && obj->mode == 'P') {

	logmsg(LL_VERBOSE,
			"Timeout hit %is limit: %i bytes received. Changing baudrate from %i to ", obj->timeout, (int)obj->len, cfgetispeed(&(obj->newtio)));
	// Try a different baud rate, maybe we have an old DSMR meter that runs at 9600 baud

	speed_t baudrate = cfgetispeed(&(obj->newtio));

	if (baudrate == B115200)
		cfsetispeed(&(obj->newtio), B9600);
	else
		cfsetispeed(&(obj->newtio), B115200);

	baudrate = cfgetispeed(&(obj->newtio));
	logmsg(LL_VERBOSE,"%i\n", baudrate);

	tcflush(obj->fd, TCIFLUSH);				// Flush any data still left in the input buffer, to avoid confusing the parsers
	tcsetattr(obj->fd, TCSANOW, &(obj->newtio));	// Set new terminal attributes
}

`
It looks like the code isn't fully compatible on UNIX style systems. I'm getting too many errors reading the serial device.
Therefore I'm gong to refactor the code a little more. I'm going to pipe the serial input directly to the program. IMHO this will solve the issues across different OS flavors.


Plugin manager intgration resource listener

I encountered a situation where I required a global functionality for the Resources used by our apigility project. Naturally I thought of controller plugins and expected to find something like this - or at least access to the controller from the resource to provide something like those plugins.
Unfortunately plugins aren't available for Resources, which forced me to implement a new AbstractResourceListener to forcibly introduce a plugin manager. This fork implements the same thing in a much more standard way, relying on approaches established for the controller plugin manager.

Can you detail some examples of plugins you've used and/or would use with this? That information will be useful for us if/when we are ready to document the feature.

I had a use case where I wanted to allow different resources to trigger events with a specific data structure.
In my specific case, it was to declare the input "channel", or context for use in other, deeper level objects. These other objects I set up as listeners on the "set-channel" event and created a plugin to broadcast the new channel setting.
class DeclareChannel extends AbstractPlugin implements EventManagerAwareInterface {
	use EventManagerAwareTrait;

	public function __invoke($channel) {
		$this->getEventManager()->trigger('set-channel', $this, array('channel' => $channel));
	}
}

The resource itself would use something like this:
class AccountResource extends AbstractResourceListener {
	public function create($data) {
	...
		$this->declareChannel('channel');
	...
	}
}

While I can appreciate the need for this, I'm not sure it's something we want to support. Adding plugin awareness leads to a number of issues for us:

Documentation and education. Developers can and will confuse resource plugins with MVC controller plugins. Additionally, identifying and implementing the functionality as an end-user will be non-trivial.
Complexity. The implementation adds quite a number of methods to the resource listener, making it harder to understand.
Always-on vs opt-in. By tying it to the AbstractResourceListener, the functionality is now required for all resource listeners, vs. having it opt-in (e.g., providing an interface for "plugin-aware" resources, and composing a trait in resources that need the functionality).
Maintenance. We'll need to answer questions and/or fix issues with the functionality going forward. Considering this reply is coming 18 months later, you can see our reluctance.

In the end, this can be accomplished already. Resources already must be defined as services, which allows you to define factories, delegator factories, and abstract factories for instantiating them. This means you can take one of the following approaches:

Inject your "plugins" individually as discrete dependencies directly during instantiation.
Inject them individually as discrete dependencies via setter injection (delegator factories)
Inject your own custom plugin manager into your listeners during instantiation or via a delegator.

Since these approaches already exist, I will close this issue at this time.


CARDS-1799: LFS mode: Timeline unresponsive

Fixed leftover moment to luxon migration artifacts

The chart entries appear on one side only. Here is the comparison of the look of the old timeline and new one in this PR:

The chart entries appear on one side only. Here is the comparison of the look of the old timeline and new one in this PR (same dates were used for both timelines)

This issue is related to the mui5 upgrade (CARDS-1441) so it's slightly out of scope. Let's report it as a separate task.


fix: enable CSV logpipe inside WithActiveInstance function

This patch ensures that we can collect the Postgres log files when we start the instance with the WithActiveInstance function.
It does that by starting a CSV logpipe process with the instance and terminating it before terminating the WithActiveInstance function.
Closes #130
Signed-off-by: Armando Ruocco<EMAIL_ADDRESS>

/test


native Android ESRI mapping not working when embeddinator generate AAR included

Steps to Reproduce

Create native Android application which includes ESRI mapping and Embeddinator generated AAR file
Display a map

Expected Behavior
ESRI map widget displays a map image and the map widget is functional.
Actual Behavior
ESRI map widget does not display the map image, but the map seems to be otherwise functional.  Swipes and grid pattern appear.  The map image is never displayed.
Removing the dependency on the Embeddinator generate AAR results in the map image appearing.
Logcat shows no errors.
Environment

Embeddinator-4000 v0.1 (0.4: 7664197)

Build Logs

Example Project (If Possible)

This turned out to be an ESRI issue.  They provided a fix.


fix(isolated-declarations): missing const after transformed const enum

[!WARNING]
This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

#3808
#3807
#3806
#3805  👈
#3804
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @Dunqing and the rest of your teammates on  Graphite


(BUG) Export wallet/Magic link items are displayed on the context menu for Torus user

[x] export wallet shown to all account types
[x] magiclink/seed phrase only shown to self custody

Precondition:
The same account is opened on the two tab
Steps to reproduce:

Logout from the first tab
Open the context menu on the second tab
Pay attention to the new items in the menu

Actual result: Export wallet/Magic link items are displayed on the context menu for Torus user  after logging out and opening the context menu on the same account in a new tab
Expected result: Export wallet/Magic link items shouldn't be displayed on the context menu for Torus user after logging out and opening the context menu on the same account in a new tab
Video: https://www.screencast.com/t/aMaPcWM64
Checked on DEV/QA V0.24.1-5
LG V30+ // Android 8.0 // Google Chrome 83.0.4103.106
Desktop: Windows 10 // Google Chrome  83.0.410

@AnastasiiaOdnoshevna export wallet should be shown to everyone
magiclink is in did only for self custody

@sirpy @serdiukov-o-nordwhale
the export wallet is displayed for all users
But after performing steps described in this issue, the user can see also backup wallet and a magic link in the context menu
Checked on DEV V0.25.0
LG V30+ // Android 8.0 // Google Chrome 83.0.4103.106
Desktop: Windows 10 // Google Chrome  83.0.4103.116

I pushed changes to master - so need to wait 30 min until it will be deployed.

@yaroslav-fedyshyn-nordwhale @sirpy
The issue isn't reproduced. The user is unable to see the items that can see only custody users
Video: https://www.screencast.com/t/NXWynECFIABz
Checked on DEV V0.25.0
LG V30+ // Android 8.0 // Google Chrome 83.0.4103.106
Desktop: Windows 10 // Google Chrome  83.0.4103.116

@sirpy @yaroslav-fedyshyn-nordwhale Magic link and backup wallet items are displayed on the context menu for Torus user
It displayed all time, not need to reproduced by steps described in this issue
Checked on DEV/QA V0.25.4-3
LG V30+ // Android 8.0 // Google Chrome 83.0.4103.106
Desktop: Windows 10 // Google Chrome  84.0.4147.89

ok this caused by a bug that corrupted userproperties
should be  fixed  in pr #2185

@yaroslav-fedyshyn-nordwhale @sirpy
The issue isn't reproduced
Checked on DEV V0.25.4-4 / QA V0.25.4-5
LG V30+ // Android 8.0 // Google Chrome 83.0.4103.106
Desktop: Windows 10 // Google Chrome 84.0.4147.89


Django feed urls

Added feed urls: a way for users to specify a url (drive, gist, dropbox, etc.) with newline separated urls for Portia to crawl.

Depends on https://github.com/scrapinghub/portia/pull/587 and needs a rebase with nui-develop to work.


Fix useAppState dependencies list

This was already fixed with this PR but it looks that you had a regression in this commit and reverted the fix

Fixed in 9bb5a3c9f4ba102c48e3f2e865a6825f1aff96c9. With the js and ts files, it was easier for me to just fix the code than fix the PR 😬.
Thank you!


[BEAM-7767] Improving regexp matching for fileio test

This matching runs into problems when receiving a c:/... filepath, so I'm just matching on the file name, and wildcarding the directory.
r: @chamikaramj
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Choose reviewer(s) and mention them in a comment (R: @username).
[ ] Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

Run Python_PVR_Flink PreCommit

LGTM. Thanks.


[Bug Report] Errors while deploying 3.0.0 landing zone

Community Note

Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
If you are interested in working on this issue or have submitted a pull request, please leave a comment

Versions

terraform:  Terraform v1.3.2
azure provider: >= 3.29.0
module: 3.0.0
Description
Describe the bug
Hello, we trying to deploy a testing landing zone for our CAF project (hub and spoke as example) and we have a few errors we are trying to solve. We are deploying under 3 subscriptions (connectivity,identity,management) all under 1 management group (non root) and seems to work fine until at around 30 minutes into the build in the CD phase we hit the following errors, if we run another terraform apply after those errors the build proceeds without issues. We using a Service principal account which is owner of all subscriptions so should not have issues with permissions. We tried destroying and re-applying multiple times and we always able to reproduce this issue. I am wondering if its because it needs some time or delay before reading these objects after creation.
Thanks
Steps to Reproduce

terraform init + terraform plan + terraform apply

After around 30 minutes into the build before it finishes we get the following

<omitted>
module.enterprise_scale.module.role_assignments_for_policy["/providers/Microsoft.Management/managementGroups/caf-test-landing-zones/providers/Microsoft.Authorization/policyAssignments/Deploy-AKS-Policy"].azurerm_role_assignment.for_policy["/providers/Microsoft.Management/managementGroups/caf-test-landing-zones/providers/Microsoft.Authorization/roleAssignments/xxxx-69d4-5b79-82fc-bf27b18cb508"]: Creation complete after 28s [id=/providers/Microsoft.Management/managementGroups/caf-test-landing-zones/providers/Microsoft.Authorization/roleAssignments/xxxx-69d4-5b79-82fc-bf27b18cb508]
module.enterprise_scale.module.role_assignments_for_policy["/providers/Microsoft.Management/managementGroups/caf-test-landing-zones/providers/Microsoft.Authorization/policyAssignments/Enforce-TLS-SSL"].azurerm_role_assignment.for_policy["/providers/Microsoft.Management/managementGroups/caf-test-landing-zones/providers/Microsoft.Authorization/roleAssignments/xxxx-0d0f-57c5-8d15-9aaf04c0dd50"]: Creation complete after 29s [id=/providers/Microsoft.Management/managementGroups/caf-test-landing-zones/providers/Microsoft.Authorization/roleAssignments/xxxx-0d0f-57c5-8d15-9aaf04c0dd50]
module.enterprise_scale.module.role_assignments_for_policy["/providers/Microsoft.Management/managementGroups/caf-test/providers/Microsoft.Authorization/policyAssignments/Deploy-MDFC-Config"].azurerm_role_assignment.for_policy["/providers/Microsoft.Management/managementGroups/caf-test/providers/Microsoft.Authorization/roleAssignments/xxxx-8d0f-50e3-9b19-b18d6724de20"]: Creation complete after 30s [id=/providers/Microsoft.Management/managementGroups/caf-test/providers/Microsoft.Authorization/roleAssignments/xxxx-8d0f-50e3-9b19-b18d6724de20]
module.enterprise_scale.module.role_assignments_for_policy["/providers/Microsoft.Management/managementGroups/caf-test-identity/providers/Microsoft.Authorization/policyAssignments/Deploy-VM-Backup"].azurerm_role_assignment.for_policy["/providers/Microsoft.Management/managementGroups/caf-test-identity/providers/Microsoft.Authorization/roleAssignments/xxxx-0bf4-5354-aeaa-987f91544ef3"]: Creation complete after 29s [id=/providers/Microsoft.Management/managementGroups/caf-test-identity/providers/Microsoft.Authorization/roleAssignments/xxxx-0bf4-5354-aeaa-987f91544ef3]
module.enterprise_scale.module.role_assignments_for_policy["/providers/Microsoft.Management/managementGroups/caf-test/providers/Microsoft.Authorization/policyAssignments/Deploy-Resource-Diag"].azurerm_role_assignment.for_policy["/providers/Microsoft.Management/managementGroups/caf-test/providers/Microsoft.Authorization/roleAssignments/xxxx-5bbb-5a52-801c-88d5d2cd160a"]: Creation complete after 29s [id=/providers/Microsoft.Management/managementGroups/caf-test/providers/Microsoft.Authorization/roleAssignments/xxxx-5bbb-5a52-801c-88d5d2cd160a]
module.enterprise_scale.module.role_assignments_for_policy["/providers/Microsoft.Management/managementGroups/caf-test/providers/Microsoft.Authorization/policyAssignments/Deploy-AzActivity-Log"].azurerm_role_assignment.for_policy["/providers/Microsoft.Management/managementGroups/caf-test/providers/Microsoft.Authorization/roleAssignments/xxxx-32b5-5730-80ab-0f86d0038364"]: Creation complete after 29s [id=/providers/Microsoft.Management/managementGroups/caf-test/providers/Microsoft.Authorization/roleAssignments/xxxx-32b5-5730-80ab-0f86d0038364]
module.enterprise_scale.module.role_assignments_for_policy["/providers/Microsoft.Management/managementGroups/caf-test-management/providers/Microsoft.Authorization/policyAssignments/Deploy-Log-Analytics"].azurerm_role_assignment.for_policy["/providers/Microsoft.Management/managementGroups/caf-test-management/providers/Microsoft.Authorization/roleAssignments/xxxx-dd8e-5243-8f40-add6db1033d6"]: Creation complete after 29s [id=/providers/Microsoft.Management/managementGroups/caf-test-management/providers/Microsoft.Authorization/roleAssignments/xxxx-dd8e-5243-8f40-add6db1033d6]

Error: checking for presence of existing Role Assignment ID for "xxxx-e137-f9ed-6d77-acc93acd829c" (Scope "/providers/Microsoft.Management/managementGroups/caf-test"): authorization.RoleAssignmentsClient#Get: Failure responding to request: StatusCode=403 -- Original Error: autorest/azure: Service returned an error. Status=403 Code="AuthorizationFailed" Message="The client 'xxxx-aeb5-4f45-9f6e-ba9b02b7f5fd' with object id 'xxxx-aeb5-4f45-9f6e-ba9b02b7f5fd' does not have authorization to perform action 'Microsoft.Authorization/roleAssignments/read' over scope '/providers/Microsoft.Management/managementGroups/caf-test/providers/Microsoft.Authorization/roleAssignments/xxxx-e137-f9ed-6d77-acc93acd829c' or the scope is invalid. If access was recently granted, please refresh your credentials."

  with azurerm_role_assignment.mgmt_group_role_assignement["xxxx-9f7a-44da-a552-e1c96d74d16f"],
  on main.tf line 86, in resource "azurerm_role_assignment" "mgmt_group_role_assignement":
  86: resource "azurerm_role_assignment" "mgmt_group_role_assignement" {

Error: checking for presence of existing Role Assignment ID for "xxxx-b69c-d939-6f53-0be29e1222b4" (Scope "/providers/Microsoft.Management/managementGroups/caf-test"): authorization.RoleAssignmentsClient#Get: Failure responding to request: StatusCode=403 -- Original Error: autorest/azure: Service returned an error. Status=403 Code="AuthorizationFailed" Message="The client 'xxxx-aeb5-4f45-9f6e-ba9b02b7f5fd' with object id 'xxxx-aeb5-4f45-9f6e-ba9b02b7f5fd' does not have authorization to perform action 'Microsoft.Authorization/roleAssignments/read' over scope '/providers/Microsoft.Management/managementGroups/caf-test/providers/Microsoft.Authorization/roleAssignments/xxxx-b69c-d939-6f53-0bef29e1222b4' or the scope is invalid. If access was recently granted, please refresh your credentials."

  with azurerm_role_assignment.mgmt_group_role_assignement["xxxx-90fe-4d6e-9096-1f4a2ec49bb6"],
  on main.tf line 86, in resource "azurerm_role_assignment" "mgmt_group_role_assignement":
  86: resource "azurerm_role_assignment" "mgmt_group_role_assignement" {

Error: checking for presence of existing Role Assignment ID for "xxxx-bbd6-4fb9-405b-12283e21f8ed" (Scope "/providers/Microsoft.Management/managementGroups/caf-test"): authorization.RoleAssignmentsClient#Get: Failure responding to request: StatusCode=403 -- Original Error: autorest/azure: Service returned an error. Status=403 Code="AuthorizationFailed" Message="The client 'xxxx-aeb5-4f45-9f6e-ba9b02b7f5fd' with object id 'xxxx-aeb5-4f45-9f6e-ba9b02b7f5fd' does not have authorization to perform action 'Microsoft.Authorization/roleAssignments/read' over scope '/providers/Microsoft.Management/managementGroups/caf-test/providers/Microsoft.Authorization/roleAssignments/xxxx-bbd6-4fb9-405b-12283e21f8ed' or the scope is invalid. If access was recently granted, please refresh your credentials."

  with azurerm_role_assignment.mgmt_group_role_assignement["xxxx-7668-4c08-be27-abf61a9f8805"],
  on main.tf line 86, in resource "azurerm_role_assignment" "mgmt_group_role_assignement":
  86: resource "azurerm_role_assignment" "mgmt_group_role_assignement" {

Error: authorization.RoleDefinitionsClient#CreateOrUpdate: Failure responding to request: StatusCode=403 -- Original Error: autorest/azure: Service returned an error. Status=403 Code="AuthorizationFailed" Message="The client 'xxxx-aeb5-4f45-9f6e-ba9b02b7f5fd' with object id 'xxxx-aeb5-4f45-9f6e-ba9b02b7f5fd' does not have authorization to perform action 'Microsoft.Authorization/roleDefinitions/write' over scope '/providers/Microsoft.Management/managementGroups/caf-test/providers/Microsoft.Authorization/roleDefinitions/xxxx-5142-562d-b0d2-6f1482eed753' or the scope is invalid. If access was recently granted, please refresh your credentials."

  with module.enterprise_scale.azurerm_role_definition.enterprise_scale["/providers/Microsoft.Authorization/roleDefinitions/xxxx-5142-562d-b0d2-6f1482eed753"],
  on .terraform/modules/enterprise_scale/resources.role_definitions.tf line 1, in resource "azurerm_role_definition" "enterprise_scale":
   1: resource "azurerm_role_definition" "enterprise_scale" {

Error: authorization.RoleDefinitionsClient#CreateOrUpdate: Failure responding to request: StatusCode=403 -- Original Error: autorest/azure: Service returned an error. Status=403 Code="AuthorizationFailed" Message="The client 'xxxx-aeb5-4f45-9f6e-ba9b02b7f5fd' with object id 'xxxx-aeb5-4f45-9f6e-ba9b02b7f5fd' does not have authorization to perform action 'Microsoft.Authorization/roleDefinitions/write' over scope '/providers/Microsoft.Management/managementGroups/caf-test/providers/Microsoft.Authorization/roleDefinitions/xxxx-33c3-518e-ad05-a81ca242afa7' or the scope is invalid. If access was recently granted, please refresh your credentials."

  with module.enterprise_scale.azurerm_role_definition.enterprise_scale["/providers/Microsoft.Authorization/roleDefinitions/xxxx-33c3-518e-ad05-a81ca242afa7"],
  on .terraform/modules/enterprise_scale/resources.role_definitions.tf line 1, in resource "azurerm_role_definition" "enterprise_scale":
   1: resource "azurerm_role_definition" "enterprise_scale" {

Error: authorization.RoleDefinitionsClient#CreateOrUpdate: Failure responding to request: StatusCode=403 -- Original Error: autorest/azure: Service returned an error. Status=403 Code="AuthorizationFailed" Message="The client 'xxxx-aeb5-4f45-9f6e-ba9b02b7f5fd' with object id 'xxxx-aeb5-4f45-9f6e-ba9b02b7f5fd' does not have authorization to perform action 'Microsoft.Authorization/roleDefinitions/write' over scope '/providers/Microsoft.Management/managementGroups/caf-test/providers/Microsoft.Authorization/roleDefinitions/xxxx-75d9-5539-b5d1-45369e5ca594' or the scope is invalid. If access was recently granted, please refresh your credentials."

   Resources: 8 added, 0 changed, 0 destroyed.

Screenshots
N/A
Additional context
I can provide additional output if needed
Thanks

Thank you for your issue @exe-r
Unfortunately, this is a known issue with the way Terraform interacts with Azure. We see something similar sometimes with policies too.
In short, the authorization token needs to be refreshed after creation of certain resource types when created at the management group scope (and possibly other scopes). This is all to do with "claims" in the token.
This is why you see the pipeline succeed on a 2nd run, as Terraform has effectively refreshed the authorization token.
I'm afraid there isn't much we can do about this in the module, but I will give the provider team a nudge to see whether they can add a fix in the provider.

Thank you so much for your response @krowlandson, If there is no workaround for this then we will note in that after a destroy we will need to perform the first deployment of the module twice. Not ideal since the pipeline will report incorrect info but we will wait for a more permanent solution on the provider side as you said.
Thanks again

Agreed @exe-r... this is not ideal and actually causes us consistent pain with our automated testing. This is now raised on the provider backlog, and I have direct contact with an engineer from the team responsible for this to investigate further.
Thank you for your patience with this 👍🏻

@exe-r as reported in the linked issue, it looks like there won't be a quick fix to this as we will need to convince the team responsible for he Azure SDK for Go to add a token refresh capability to the SDK before the provider team can implement this capability in the provider (if needed). I will continue to pursue this but don't expect there to be a quick resolution to this issue.


Proposal: ThresholdReachedBackground property for SwipeItem class

Proposal: ThresholdReachedBackground property for SwipeItem class

Summary

The ThresholdReachedBackground property is a Brush property for the SwipeItem class, that is only used when the SwipeItems.Mode property of the parent SwipeItems instance is set to SwipeMode.Execute.
When this property is not null, the SwipeControl applies this background to the triggered item, when the swipe threshold is exceeded, instead of always applying just the current accent color as it currently does.
Rationale

Right now, items in SwipeMode.Execute mode always receive the accent color when they are triggered. This is not really ideal, as developers might want to associate specific colors to different actions (eg. red for "delete", like in the Mail app). Just using the SwipeItem.Background property is not sufficient, as that background is always visible, even before the swipe threshold is reached

Scope

Capability
Priority

This proposal will allow developers to specify a Brush to be applied to a SwipeItem instance, contained in a SwipeItems object set to SwipeMode.Execute mode, when reaching the swipe threshold
Must

Important Notes

The new property should (presumably) be added here with the others: https://github.com/microsoft/microsoft-ui-xaml/blob/5d1d3d5ab35cdf408b5ad1426ef28a40dc2b7bf6/dev/SwipeControl/SwipeControl.idl#L81
Something like:
Windows.UI.Xaml.Media.Brush ThresholdReachedBackground { get; set; };
static Windows.UI.Xaml.DependencyProperty ThresholdReachedBackgroundProperty { get; };

This is the main method in SwipeControl that should be updated: https://github.com/microsoft/microsoft-ui-xaml/blob/45c63815bffba90a7cc0b7454269f55881878d7e/dev/SwipeControl/SwipeControl.cpp#L1333
It receives the input SwipeItem object and updates its background color depending on the threshold value. A check should be added here to see if the SwipeItem.ThresholdReachedBackground is not null, in which case that Brush will be used if the threshold is exceeded, instead of the accent color (which is currently retrieved from the s_executeSwipeItemPostThresholdBackgroundResourceName resource name).
In particular, this line should be changed like this:
if (swipeItem && swipeItem.ThresholdeReachedBackground())
{
    background = swipeItem.ThresholdeReachedBackground();
}
else if (auto lookedUpBackgroundBrush = SharedHelpers::FindResource(s_executeSwipeItemPostThresholdBackgroundResourceName, resources))
{
    background = lookedUpBackgroundBrush.try_as<winrt::Brush>();
}

Barring other complications (I can't really think anything major though), this should be pretty easy to implement, as it's very restricted in scope.
I can create a draft PR with these changes if it can help get this started! 😄

@kikisaints, @StephenLPeters, can you take a look?

Hey @Sergio0694! Thanks for bringing this up. There are some alternatives to this, like overriding the system accent color, can you explain why doing so won't satisfy you're scenario?

Hi @kikisaints - thank you for your reply!
Unfortunately changing the accent color would obviously result in the whole app using that color, while instead I just want to have a single swipe item using a particular color when that action is triggered.
Also, a custom accent color would be applied for all the left, right, up and down actions, while on the other hand if a ThresholdReachedBackground property was available, you could have for instance the left execute action turning green when reaching the threshold, and the right execute action turning red.

Hmm, so it sounds like you want per-swipe item instance control over the background, and also want that color applied only after the threshold is reached, correct?
As a side note, we do have a Lightweight styling resource called SwipeItemPostThresholdExecuteBackground which I thought :smile: would do what you want - keep the background "greyed out" until the threshold is reached and then applies your specified color - and you could set it up something like this:
<ListView.Resources>
    <FontIconSource x:Key="ReplyAllIcon" Glyph=""/>
    <FontIconSource x:Key="ReadIcon" Glyph=""/>
    <FontIconSource x:Key="DeleteIcon" Glyph=""/>

    <SolidColorBrush x:Key="SwipeItemPostThresholdExecuteBackground" Color="Red" />

    <SwipeItems x:Key="left" Mode="Reveal">
        <SwipeItem Text="Reply All" IconSource="{StaticResource ReplyAllIcon}"/>
        <SwipeItem Text="Open" IconSource="{StaticResource ReadIcon}"/>
    </SwipeItems>
    <SwipeItems x:Key="right" Mode="Execute">
        <SwipeItem Text="Delete" IconSource="{StaticResource DeleteIcon}" />
    </SwipeItems>
</ListView.Resources>

However, this doesn't appear to work. @StephenLPeters Do you have an idea of why it doesn't? I think it would solve Sergio0694's scenario if it did.

@kikisaints Not sure what you mean with "per-list swipe item instance".
The way I have this setup is that I have a SwipeControl as the root of my data templates, and two SwipeItems instances for the left and right swipe actions.
To rephrase the problem in another way, the issue is simply this: when a SwipeItems is set in Execute mode, by default the control uses a gray-ish color as you start to swipe, and then switches to the accent color when you move past the swipe threshold. This is fine, looks good and is the expected behavior.
But, if you set the Background property of a SwipeItem (the only one in a SwipeItems object, when set in Execute mode), that background is always applied, no matter if you're before or after the threshold, so you completely lose the visual feedback when reaching the threshold.
Having the background being always applied is fine when the items are in Reveal mode, but it doesn't really make sense from a UX standpoint when the item is in Reveal mode.
As I said, maybe the easiest solution would just be to tweak this method: https://github.com/microsoft/microsoft-ui-xaml/blob/45c63815bffba90a7cc0b7454269f55881878d7e/dev/SwipeControl/SwipeControl.cpp#L1333
So that if the Background property is set but the threshold hasn't been reached, the gray-ish color will be used, and the custom Background will only be applied after the threshold is reached.
That would solve all my issues, and would make the whole control more consistent overall.
What do you think?

@Sergio0694 Sorry, yes that's what I meant by "per-list swipe item instance". Although that phrasing was confusing. I meant you want to be able to control these items' colors individually:
<SwipeItem Text="Delete" IconSource="{StaticResource DeleteIcon}"/>
...
<SwipeItem Text="Reply All" IconSource="{StaticResource ReplyAllIcon}"/>

At the root of your data templates. Which you've already confirmed is what you want, so I don't need to reiterate further.
I understand your API proposal, and agree with it only if we cannot get the Lightweight styling resource to work, because that is what Lightweight styling is for - to maintain original behavior (in this case the gray to colored BG on threshold reached) without any need to re-template or add extra APIs to a control, ideally.
However, if we cannot get that to work, i would like to go with your alternate proposal of simply getting the Background property to apply itself after the threshold is reached, as that seems more intuitive to me.
@MikeHillberg thoughts on either?

That's perfect, just tweaking that behaviour without introducing a new property sounds perfect, and after all the result would be the same anyway. I'm not sure we'll be able to do this without actually changing the implementation in the control itself though, look at this block: https://github.com/microsoft/microsoft-ui-xaml/blob/45c63815bffba90a7cc0b7454269f55881878d7e/dev/SwipeControl/SwipeControl.cpp#L1355
It seems to me that no matter what the current sliding position is, either pre or post the threshold, if the Background property is set, that will always overwrite the control's background, which is exactly the issue - once you set that property, you lose the visual feedback getting past the threshold.
I might very well be missign something here though (I hope so). 😄

Wow, looks like there might be some coded dependencies on the background property. That may need to change, or we would need to introduce a new API. I'll sync with the devs offline and get back to you.

Hey! following up on this. I synced with the devs and we came up with a more "refined", if you will, scope to this proposal:
Scope

Capability
Priority

Provide a way to access the brushes/colors of a SwipeItem in each state (pre, post and rest/normal state)
Must

Expose/make public the ThresholdReached event
Must

There are also some side issues we discovered around how the SwipeItem is created and how it preforms it's resource lookups that's preventing the Lightweight styling resource from working correctly. We believe that in creating a more structured VSM for the SwipeItem we can solve that issue.
We decided to leave the Background property alone for now, because making special behavior for it is felt like overloading a property that's already a bit weird on many controls.
@Sergio0694 let me know if you have an questions to this result and I will try my best to address them. Otherwise, I will modify your original proposal to encompass these proposal changes.

Hi @kikisaints - thank you for the follow up!
I can see why you wanted to leave the Background property as it is, and yeah it does make sense to leave it as it is. Plus, if you expose all the various pre/post/rest/etc. brushes, that's perfectly fine by me, as I'd be able to just set the "post threshold" brush at that point, leave the Background property to null and I should hopefully get the desired effect that way.
Looking forward to seeing this in a future preview build!
Thank you for your help! 😄

At this point EVERY Color for EVERY State on EVERY control, should probably be a ThemeResource that can be overridden - so these individual issues will become redundant.
Same for Border Thickness, FontSize, basically any property used to define it's look...

@mdtauk - I'm not really convinced about having theme resource that can be overridden.
Take the SwipeControl for instance, in Execute mode, with two actions (left and right).
Would there be two different theme resource, one for each side?
I mean, wouldn't it be simpler to just have the necessary properties right in the controls, instead of having countless theme resources to override, which is also more error prone?
Just brainstorming here 🤔


New Section: Drupal theming

General theming

The Drupal theme anatomy
Create subtheme
Regions
Twig templates (organizing, naming, inheritance)
Frameworks we prefer (and how to choose them)
Setup CSS (CSS variables, postcss, scss, node-sass etc)
Setup JS (ES6, jQuery)
Fonts/typography
Setup compiling (grunt, gulp, npm etc)
Browsersync, autoreload etc
autoprefixer and browser support, polyfills
npm utilities (eslint, normalize, husky, prettier, stylelint etc)
External libraries used (JS utilities, cookies etc)
Enable twig and cache debug (+devel module)
hooks (how to add custom classes, theme suggestions, in-twig libraries)
IDE setup, basic vcs (git) workflows
Utility CSS/JS/HTM frameworks
Storybook
Should we include compiled assets to vcs?
Best practices to write, organize and reuse SCSS and JS
Chrome extensions for theming
Browser Devtools (how to, common tasks, addiotional tools etc)
"Translating" design systems into styleguides
e2e testing, visual regression etc
Drupal themes we prefer or avoid
Drupal layout builder
Drupal theme breakpoints
BEM, SMACSS and other CSS methodologies within Drupal
Above the fold CSS
A11y validations, tools and analysis
Local dev tools (eg ddev) to get a running Drupal instance

See also https://github.com/theodorosploumis/notes/blob/master/drupal/theme-validator.md.

Theming lessons
Business logic versus presentation logic
Twig
Theme hooks

Theme hook suggestions

Render arrays

The structure of a render array
The render pipeline

Assets and libraries

Libraries

Common theme hooks

Lists
Links
Tables

Attributes
Layouts

Defining layouts
Rendering a layout

Other/General

Get Drupal themes
The theme anatomy
Base themes and inheritance
Create a new theme
Theme settings
(Theme) layouts and breakpoints
Twig templates
Render arrays
Controllers
Theme templates and theme hooks
BEM, SMACSS and other CSS methodologies within Drupal
Attach CSS and JS (internal, external) with libraries
Working with JS (behaviors etc)
Useful modules for theming (kint, webprofiler, twig related etc)
Twig basics (render, loop, sub-values, conditions, arrays)
Twig functions
Twig filters
Twig macros
How to theme
Modules we use for theming
Base themes we prefer
Themes we avoid
Theming philosophy
Compiling assets
Performance needs and testing
Browsers we support
A11y testing
Using paid themes

Theming problems quastionaire
Theming process standards
Trying new things on theming

Drupal + TailwindCSS theme

tailwind version (CDN usage)
unset Drupal core CSS files
tailwind CSS variables
tailwind compiler
Drupal config values (php --> twig) on admin UI
fonts
colors
width & layout
twig templates
twig template suggestions (by bundle, field type, view_mode, combinations of)
email twig templates
use laravel mix
Drupal modules (ui_patterns, entity_class_formatter, block_class, layout_builder, CKEditor tailwind buttons)
Other CSS/JS libraries (hover, animate, icons etc)

Lessons: Theming (new)

Base theme and inheritance
CSS libraries

which
external/internal
(core) overrides

JS libraries

which
external/internal
(core) overrides

Theme Breakpoints
Asset bundle

grunt
bundle
gulp
phpstorm watchers

SCSS structure
Twig

folders
suggestions
embeds
extends
templates
variables
debug

Admin theme
Theming methodology

Twig templates
Patternlab
Storybook

Styleguides
.theme file

functions
hooks
includes

Related modules

ds
components
ui_patterns
paragraphs
layout_builder
twig_tweak
twig_field_value
field_formatter_class

Browser

which
extensions
profiles
local sources

Node version (for npm packages) with nvm
Git

.gitignore
exclude compiled (CSS/JS) files?
pre commit hook

Mockups and design

Sketch
Figma
InvisionApp
XD
Zeplin

See also https://github.com/aleksip/component-based-theming

See also the new 2023 Book:

https://www.packtpub.com/product/modernizing-drupal-10-theme-development/9781803238098
https://github.com/PacktPublishing/Modernizing-Drupal-10-Theme-Development


Rename to LSP-julia?

My version of this package is called LSP-julia with lowercase "j", because based on the other LSP-* packages this seems to be the convention. I could make a pull request to replace all the files here, but I think it would be easier to delete this repo and transfer ownership of my repo to sublimelsp directly, and I guess existing clones get redirected then automatically.
The other two issues here are fixed in my version.

Renamed this to LSP-julia.
You can change your git remote to point to this location and force-push the master branch. I believe there are a few difficulties when transferring repos with outside collaborators.

I prefer naming the package with correct casing, e.g. LSP-PowerShellEditorSerivces, but it's up to you.


fix: canStale should return false if Cache-Control: must-revalidate is present

Description
This PR contains the following changes:

Fix for incorrect behavior of canStale function.
Updated test cases. [1 failing test case is pending]

Relevant Issue:
#507

@arthurfiorette can you please give me some pointer on why tests modifiedSince using cache timestamp test fails 🤔 ?

What the debug option prints when running this test?

PR out of date and implemented by 22870d7.


{PolicyInsights} Add help examples for retrieving component-level policy compliance states

Description
Add help examples for retrieving component-level policy compliance states
Testing Guide

History Notes

[Component Name 1] BREAKING CHANGE: az command a: Make some customer-facing breaking change.
[Component Name 2] az command b: Add some customer-facing feature.

This checklist is used to make sure that common guidelines for a pull request are followed.

[X] The PR title and description has followed the guideline in Submitting Pull Requests.

[X] I adhere to the Command Guidelines.

[X] I adhere to the Error Handling Guidelines.

PolicyInsights


server side rendering?

does fre provide ssr and hydration like preact and react?

I do have a good idea to do SSR, but it's not easy
Do you know react server component? It has no states and events and does not need hydration.
In the past, SSR traverses vdom to generate html strings, which has poor performance in the server.
But if we compile JSX into bytecodes, there will be a great performance improvement.
This is feasible on the premise that the component is the same as the server component and has no state.
In other words, we can do ssr of server component at the same time, which has four advantages:

Efficient bytecode

Because the server component has no state, it doesn't need to hydration.

Smaller bundle size.

If we can learn from angular ivy, we can do more tree shaking.

https://github.com/trueadm/react-compiler/blob/master/browser-sandbox/build/compiled-bundle.js
@trueadm has done similar work, and I'd like to try it. Maybe it's a good idea.

I do have a good idea to do SSR, but it's not easy
Do you know react server component? It has no states and events and does not need hydration.
In the past, SSR traverses vdom to generate html strings, which has poor performance in the server.
But if we compile JSX into bytecodes, there will be a great performance improvement.
This is feasible on the premise that the component is the same as the server component and has no state.
In other words, we can do ssr of server component at the same time, which has four advantages:

Efficient bytecode

Because the server component has no state, it doesn't need to hydration.

Smaller bundle size.

If we can learn from angular ivy, we can do more tree shaking.

https://github.com/trueadm/react-compiler/blob/master/browser-sandbox/build/compiled-bundle.js
@trueadm has done similar work, and I'd like to try it. Maybe it's a good idea.

@jantimon I am paying close attention to react fizz. Its implementation is very interesting and suitable for fre.
https://github.com/facebook/react/tree/master/packages/react-server

cool :) looking forward on your findings

Any new ideas yet?

@tomByrer I do have a lot of ideas here, but it takes time and I may need a summer vacation.

Streaming rendering, which is the most important, enables SSR to support suspend interaction.

https://github.com/facebook/react/pull/20970

ESR, Deploying in cloudflare worker, and developing in labor

I'm a little busy recently, so the progress will be slow. If someone helps me, that would be great. Thank you.

In the past, SSR traverses vdom to generate html strings, which has poor performance in the server.

are there some poor performance examples about renderToString?


Not working on mobile devices

Not working on chrome android
Tested on Mi, Moto g5 plus, lenovo vibe note

Hello there AKprisonER,
At the moment, coindexter is not fully responsive for mobile devices. I'm a little surprised it doesn't work. I just tried loading it in Chrome on Android as well and it seems like there's some JS that's not loading or it can't reach an API. I'll look into this soon.

Found the issue. Seems like older Chrome versions on Android don't have support for arrow functions. I'll have to rewrite some code to get it working.

Should work now athough the page isn't optimized for smaller devices.

yeah.e.....working fine..but optimization is not done it seems..i will try with tat


updated common-text to use latest version (Crit Vuln resolution)

Previous version of commons-lang, 1.9 contains this vulnerability:
https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2022-42889
Which has now been patched in commons-lang 1.10.0
Simple Pull request to update the dependency

Can we amend the title of this PR to better reflect what has been updated (commons-text, not commons-lang)

Thanks!


Fixes drawing of the 2D plugins on the 3D view

Splits the forward_draw_over_viewport() into forward_canvas_draw_over_viewport() (2D) and forward_spatial_draw_over_viewport() (3D).
Same thing for forward_force_draw_over_viewport()
Fixes #20793
Probably fixes #19681 too

Thanks!


x/pkgsite: doc strings on struct fields do not display in Safari

What is the URL of the page with the issue?
https://pkg.go.dev/github.com/cpuguy83/dockercfg
What is your user agent?

Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_6) AppleWebKit/605.1.15 (KHTML, like Gecko) Version/14.0.3 Safari/605.1.15
Screenshot

Data is present just not showing:

What did you do?

Add a doc string to a struct field
e.g.
type Foo struct {
  // COMMENT HERE
  Foo string
}

What did you expect to see?
The comment should show in the doc site.
What did you see instead?
There is whitespace for the comment and the comment data is there, the actual comment does not show up, though.
This is the same on both pkg.go.dev and godoc.org

FWIW I see this using an older Safari (and on latest Chrome for macOS):
Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/89.0.4389.114 Safari/537.36

I am also unable to reproduce this issue with the same user agent:
Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_6) AppleWebKit/605.1.15 (KHTML, like Gecko) Version/14.0.3 Safari/605.1.15

Interesting...
I swear I saw this on iOS as well a little while back, but cannot repro it there anymore.
Knowing this I started messing with addons...
Turned off an ad blocker (1Blocker) and the problem went away.

Somewhat relevant: few days ago I almost opened an issue about http.Cookie type header not showing up on Safari (the <h2 id="Cookie">... node was not rendering at all), but once I loaded the page with content blockers disabled, it rendered fine. I used Wipr.

Thanks all for investigating! Closing this issue since there isn't anything actionable on our end.


Recommended credential configuration causes unnecessary masking in GitHub logs

The recommended way of configuring the GitHub secret to contain the Azure credentials results in GitHub masking all output containing curly braces.  For multi-line secrets, GitHub treats each line of the secret as sensitive (which makes sense when you think about it).
So specifying credentials like this...
{
  "clientId": "<GUID>",
  "clientSecret": "<GUID>",
  "subscriptionId": "<GUID>",
  "tenantId": "<GUID>"
}

...will instruct GitHub that { and } are sensitive.  Anything you echo out to the GitHub logs from this point on will mask curly braces.  This makes reading JSON in your logs less than ideal:
***
    "key": "value1",
    "obj": ***
        "subkey": "value2"
    ***
***

Fortunately, you can resolve this by specifying your secret as:
{ "clientId": "<GUID>",
  "clientSecret": "<GUID>",
  "subscriptionId": "<GUID>",
  "tenantId": "<GUID>" }

Updating the documentation in this repo to consider this behavior would prevent others from scratching their heads wondering why their curly braces are always masked in GitHub logs.

@doug-papenthien-by  Thank you for the suggestion! updated readme


chore/update go 117 and handle go build comment

feat: ignore go:build comments in code
chore: update to go 1.17

It was changed for satisfying the demands of the new linter version instead of turning the lint check off.


Postgres table changes only applied temporarily

System information:

Operating system (distribution) and version: Windows 10, x64
DBeaver version: 6.2.4, 6.2.3
Additional extensions: None

Connection specification:

Database name and version: Postgres 10.7
Driver name: PostgreSQL JDBC Driver
Do you use tunnels or proxies (SSH, SOCKS, etc)? No

Describe the problem you're observing:
When executing table-altering statements from DBeaver, I've found that they temporarily take effect, but then are revoked. So for example, I'll execute a statement to add a new index. When I do a select from pg_indexes, the index is initially there, and if I explain a query that would use the index, it shows the index as being used. But then, a few minutes later, the index is not listed in pg_indexes, and the explain shows the query as scanning the whole table.
I've seen a similar phenomenon with adding a column (it's there for a couple minutes when I do a select, but then later the very same query throws an error), and with an update statement.
When I run the same SQL statements via a PSQL (v10) CLI, they work as expected, which is why I think the issue is with DBeaver.
One other interesting thing of note is that one time I tried creating an index (if not exists) in DBeaver, and then executed the same statement in PSQL. The PSQL hung until I disconnected DBeaver, at which point it completed successfully.
Steps to reproduce, if exist:
Attempt to alter a Postgres table with DBeaver, e.g. by adding an index or a column. Wait 5 minutes and see if it's still there.

NM, I was thrown by manual commit mode. Things are working as expected with auto-commit on.


SA1106 should be reported for the semicolon following a type declaration

The following is legal C# code:
class TypeName
{
};

However, the ; at the end is not necessary. It should be treated as an empty statement for the purpose of SA1106.

grabbed


datatypes.Date to time.Time

Your Question
In the documentation it talks about how to go from time.Time to datatypes.Date() - insert a time into database.
Reference:
https://github.com/go-gorm/datatypes/
https://github.com/go-gorm/datatypes/blob/master/date.go
But to retrieve a date from the database and convert to time.Time, I searched quite a lot and tried different methods to go from datatypes.Date() to time.Time.
I got this to work but I'm sure its probably not the best method.
x, _ :=  dbrecord.Date.MarshalJSON()
bDate, _ := time.Parse(time.RFC3339, strings.Trim(string(x), "\""))

The document you expected this should be explained
https://github.com/go-gorm/datatypes/
Expected answer
It would be good to have best practice in the readme on how to do this.

I found another way of converting datatypes.Date to time.Time. You can do:
dVal, _ := dbRecord.Date.Value()
d := dVal.(time.Time)

This seems to work:
t := time.Time(dbRecord.Date)


Replace routers.json usage with config.json

No need to keep around two endpoint that are essentially the same
except config.json provides more info

:star: :shell: Nice cleanup!

:star: :cake: yay


Bugfix: offline mode is sometimes broken during remote debugging

subscribe to mode changes after the connection status is initialized.
(bug was caused by a race condition when app is loaded between fetch and change)

Well done 👍


DOCS-1022: Remove extra columns from a table

Description
Fixed extraneous columns in a table in this topic: https://unified-docs.tigera.io/calico/reference/resources/felixconfig

Todos

[ ] Tests
[ ] Documentation
[ ] Release note

Release Note

TBD

Reminder for the reviewer
Make sure that this PR has the correct labels and milestone set.
Every PR needs one docs-* label.

docs-pr-required: This change requires a change to the documentation that has not been completed yet.
docs-completed: This change has all necessary documentation completed.
docs-not-required: This change has no user-facing impact and requires no docs.

Every PR needs one release-note-* label.

release-note-required: This PR has user-facing changes. Most PRs should have this label.
release-note-not-required: This PR has no user-facing changes.

Other optional labels:

cherry-pick-candidate: This PR should be cherry-picked to an earlier release. For bug fixes only.
needs-operator-pr: This PR is related to install and requires a corresponding change to the operator.

@ctauchen Can you please review this one?

/sem-approve

I don't understand this one - the title says it's removing an extra column, but it actually just seems to be changing some special characters in a regex. What's the motivation for this?

@caseydavenport This is one for the migration project. The new system takes a different syntax in markdown tables. The | character was being interpreted as a new column marker.
This fix makes the tables in Jekyll and Docusaurus both work correctly.


commands.icon contribution point is not clear

According to the intellisense, it looks like it's possible to specify an icon as part of command properties.
However, it looks like it is not documented in VSCode website and I am not able to understand where is this displayed. I tried with bot .png and .ico, but I wasn't able to see anything.
Are there some restrictions? Am I doing something wrong?

Icons are only shown for editor title commands that are in the navigation group (the place where VS Code also shows icons). Formats that browsers/css support are supported by this extension point

@jrieken
I do not get what's editor title commands...do you mean this?

No, this:

Thanks a lot! Would it worth to update the documentation about that? It's a bit confusing.


Support "if-feature" statements in yang schemas

This adds support for "if-feature" statements in the yang schema. It does this by returning a getter that supports a lua table of feature names, when it gets to an "if-feature" block it checks if the feature is present and if so includes the block, otherwise it leaves it out.
There is more info in the git commit message.
I've verified that all the commands (get-state, get, set, add and remove) all function as they ought to with this change - they all do.
PTAL @wingo

Seems there was some overlap on this, don't think this is needed anymore.


Fixed that types are invalid

Fixed the path to the types file.
Closes #321

Thanks for your contribution! I fixed the root issue in https://github.com/tauri-apps/plugins-workspace/commit/7acf865ffbb82c6d00334926a4527dd5ff3163a4 (especially because it was an issue in all plugins) so this PR is not needed anymore, thank you again though!