double.clamp should return a double

I ran into two issues independently recently that both led me to the same conclusion: double.clamp should just always return a double.
Issue 1: removal of implicit casts (cc @a14n @goderbauer)
Without implicit casts, double.clamp needs continuous babysitting with as to make it work:
  // assume implicit casts are disabled for this code
  void foo(double x) { }
  void main() {
    double y = 1.1;
    foo(y.clamp(0.0, 1.0) as double); // without the as double, this is a compile-time error
  }

It's absurd that you keep having to cast things to double when you are only dealing with doubles.
This is newly important since implicit casts are going away with NNBD.
Issue 2: Accidental ints
Because int literals can masquerade as doubles, it's common to use them. Because clamp takes nums, they don't get considered as doubles there. Because clamp returns its value directly, what appears to just be code dealing in doubles is actually suddenly dealing with ints, which leads to runtime errors:
  void foo(double x) { }
  void main() {
    double y = 1.1;
    foo(y.clamp(0, 1).toDouble()); // without the toDouble, this is a runtime error
  }

Related to #30403 where a comment from @floitschG is:

We are dropping clamp from num and specialize the functions on int and double.

@lrhn will there be changes happening with NNBD?

Those changes sadly did not make it into Dart 2.0.
We are aware that some number operations have become very cumbersome (num.remainder, math.pow and num.clamp included). We may want to either special-case them in the static type system or restrict them in some way while adding alternatives.
The current clamp has type num clamp(num, num) and is declared on the num class. It allows you to do num.clamp(1, 2.5) and get either 1 or 2.5 back as result. It's hard to modify that signature without breaking things, but if we add new methods that you can migrate to (or we can migrate you to automatically), then it might become more palatable.

You could solve issue 2 above by implying toDouble on the return value, that would be backwards-compatible (may require compiler work to keep it efficient).
Issue 1 is going to become seriously problematic with NNBD. We're already experiencing this in Flutter to the point that we're discussing creating an extension method on double that has the right signature and just using that. It would be very unfortunate if Flutter had to do that given that we're all one team. :-(

Making double.clamp always return a double is a breaking change in the sense that there might exist code which will change behavior.
In practice, I wouldn't bet on any code actually breaking.
The int.clamp issue is worse. I'd probably go for converting the result to double  if any argument is a double, and then add a special typing case for that too, like we have for + etc.
Even with special typing rule exceptions, we also need the type inference to understand those exceptions. Otherwise we'll still infer num in some places where we could do better.

I'm falling into toDouble() hell when it comes to clamping doubles :-(

The null safety rules now say that the static type of clamp is double if any argument is double (or if the receiver is double, but double.clamp already said that), and it is int if all arguments and the receiver are ints.


support new ui build&compile and make process into travis.

Coverage decreased (-25.9%) to 28.814% when pulling 5fdc12e851a69e2eaa753fc5caa3fa2699c6a1a1 on wy65701436:dev into 37ea4273e15a616627da1581e377508d7736aa04 on vmware:dev.

Coverage decreased (-25.8%) to 28.86% when pulling 067fae206ed8e24c5c9766fb6008484c519e1284 on wy65701436:dev into 37ea4273e15a616627da1581e377508d7736aa04 on vmware:dev.


Well then find it!

I have no idea why this error is coming up when trying to install from the flatpak

Try running flatpak install org.gnome.Platform/x86_64/42


Website went missing?

I'm not sure you've been notified but the site seems to have gone the way of the dodo:

I wonder what may have caused it.

I confirm

Also confirm

While this is out, you can use http://beautify-web.github.io/js-beautify/.

Thanks @kenzierocks !

Fixed!  My bad!  Thanks, everyone!

Thanks!


fix modFunctionIndex is missing on copy

OS14289876 credit goes to @jianchun

            bucketCount = 0;

If other.Count() == 0 (because count == freeCount but bucketCount != 0), this could result in bad modFunctionIndex.

Refers to: lib/Common/DataStructures/BaseDictionary.h:153 in 1339070. [](commit_id = 1339070d172f6dc7da9aa3e1d5a2a21a6bc43e90, deletion_comment = False)

        this->freeCount = 0;

Here modFunctionIndex missing update.

Refers to: lib/Common/DataStructures/BaseDictionary.h:302 in 1339070. [](commit_id = 1339070d172f6dc7da9aa3e1d5a2a21a6bc43e90, deletion_comment = False)

            bucketCount = 0;

Missing modFunctionIndex update.

Refers to: lib/Common/DataStructures/BaseDictionary.h:311 in 1339070. [](commit_id = 1339070d172f6dc7da9aa3e1d5a2a21a6bc43e90, deletion_comment = False)

        uint newBucketCount = SizePolicy::GetBucketSize(newSize, &modFunctionIndex);

In theory this is not safe. this->modFunctionIndex is changed while other variables are not (newSize, newBucketCount are using temporaries). If anything below failed in the middle we'd end up with bad modFunctionIndex. To be consistent and safer, consider also use a temporary "newModFunctionIndex" and be sure use it during rehash.

Refers to: lib/Common/DataStructures/BaseDictionary.h:1021 in 1339070. [](commit_id = 1339070d172f6dc7da9aa3e1d5a2a21a6bc43e90, deletion_comment = False)

Please also fix WeaklyReferencedKeyDictionary::Resize() and Initialize(), both have the same unsafe pattern of changing modFunctionIndex before everything succeeds.

@jianchun please consider that the mod index set by previous dictionary was working for that dictionary.

@jianchun please consider that the mod index set by previous dictionary was working for that dictionary.

Yes it is a bug. But that's not the only problem. Several from my comments are apparent bugs too. The observation is that we have similar amount of failures in WeaklyReferencedKeyDictionary, which was not covered by current change. Why not do a thorough review and fix?

Well, it wasn’t a through review but your comments on vso with a credit on description.

@jianchun Thank you for the review and pointers. Is it good to go?


Add flags infrastructure to main.py

This is a deceptively simple PR that took me like 5 hours of researching the interaction between argparse, arghparse, and absl.flags and trying to figure out how to create a flag file.
Anyway, this is the first commit. This is backwards compatible with the way we've been calling everything, and allows us to gradually swap out hyperparameters one by one by replacing them with flags.DEFINE declarations. I'll submit a few of these as examples on how to swap them out.
The only downside I've found so far is that this approach doesn't allow directly loading flagfiles from GCS; they must be gsutil cp'd to the host before passing --flagfile=local/path/to/flagfile as a command line flag.

I'm very intrigued how this will work w.r.t. our different commands (main.py, rl_loop.py, oneoffs, etc).  Do they all have different flag files?  Do we check them in?
I mean LGTM and let's not hold up the party but i'm curious to see what the working example looks like.

The idea is to have one flag file for each experiment type. So ideally the flags are all configured with sensible defaults, and then we can override with --num_mcts_readouts=100 or --num_trunk_layers=10.
I have to think more about rl_loop, local_rl_loop, rl_runner and how we might simplify those. It's a bit annoying to parse flags and then repeatedly pass them down a matroska doll.


client restart，observer is reset

HI, I have a server observe client resource,it works well.But when i restart client,I find the server delete the observer relationship with the client.I want that  the server not cancel observer ,although the client restart,it works well.  How should i do to handle this question?
OMA-TS-LightweightM2M_Core-V1_1-20180710-A notes:
Until the LwM2M Client sends a new registration, the LwM2M Server expects the LwM2M Client to remember the observation requests. If a LwM2M Client forgets the observation requests (e.g. device factory reset) it MUST perform a new "Register" operation. The LwM2M Server MUST re-initiate observation requests whenever the LwM2M Client registers.
and I use leshan 1.00-M11,the server demo :
public void registered(Registration registration, Registration previousReg,
Collection previousObsersations) {
String jReg = EventServlet.this.gson.toJson(registration);
sendEvent(EVENT_REGISTRATION, jReg, registration.getEndpoint());
}
I kown the previous Obsersations param represent the previous relaship with client ,but how to use the param to re-initiate observation requests？

So, If I am not wrong then,
 try {                                 ReadResponse response = lwServer.send(registration, new ObserveRequest(obj, inst, res));                                  if (response == null){                                     System.out.println("!!!!!response is null TIMEOUT!!!!");                                     return;                                 } else if (response.isSuccess()){                                         if(((LwM2mResource) response.getContent()).isMultiInstances()) {                                             System.out.println("Observe values:" + ((LwM2mResource) response.getContent()).getValues());                                         } else {                                             System.out.println("Observe value:" + ((LwM2mResource) response.getContent()).getValue());                                         }                                 } else {                                         System.out.println("Failed to read:" + response.getCode() + " " + response.getErrorMessage());                                 }                             } catch (InterruptedException ex) {                                 System.out.println();                             }
Looks something like this->

If you get (response == null) try add in code coapConfig.set(NetworkConfig.Keys.PROTOCOL_STAGE_THREAD_COUNT, 4);
There was an issue, if your test machine running on one thread, like i got.
Sorry for poorly structured answer, but its still better than wait a week :)

So, If I am not wrong then,
 try { ReadResponse response = lwServer.send(registration, new ObserveRequest(obj, inst, res)); if (response == null){ System.out.println("!!!!!response is null TIMEOUT!!!!"); return; } else if (response.isSuccess()){ if(((LwM2mResource) response.getContent()).isMultiInstances()) { System.out.println("Observe values:" + ((LwM2mResource) response.getContent()).getValues()); } else { System.out.println("Observe value:" + ((LwM2mResource) response.getContent()).getValue()); } } else { System.out.println("Failed to read:" + response.getCode() + " " + response.getErrorMessage()); } } catch (InterruptedException ex) { System.out.println(); }
Looks something like this->

If you get (response == null) try add in code coapConfig.set(NetworkConfig.Keys.PROTOCOL_STAGE_THREAD_COUNT, 4);
There was an issue, if your test machine running on one thread, like i got.
Sorry for poorly structured answer, but its still better than wait a week :)

Thank you very much,i will have a try.
But i have a question,is there a method that not send "lwServer.send()" to client?because previousObsersations has represent the observer information,why we just store it again?

Its just my test code, not developed enough, a lot to learn, I must. I am new here.
If you got Previous observation active, they will be canceled, if you just send new Observation request, tested that! If you want a smooth code, you should check previousObsersations I think there may be an answer or maybe wait some Leshan Guru to answer that :)

Its just my test code, not developed enough, a lot to learn, I must. I am new here.
If you got Previous observation active, they will be canceled, if you just send new Observation request, tested that! If you want a smooth code, you should check previousObsersations I think there may be an answer or maybe wait some Leshan Guru to answer that :)

Yes,thanks you.If possible,make a smooth code in leshan server demo in next version.Have a good day!


Wrong parameter (--proj-file) in "Publish your bot to Azure" command

Currently, the command is documented as below.
az bot publish --name <bot-resource-name> --proj-file "<project-file-name>" --resource-group <resource-group-name> --code-dir <directory-path> --verbose --version v4
Unfortunately, this does not work. This returns "az: error: unrecognized arguments: --proj-file "
I believe instead of --proj-file it ought to be --proj-name instead. Further I believe the response provided by the Azure CLI is also incorrect.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 2cfa1653-6ab2-730b-5479-81a05b9bb18e
Version Independent ID: a7c8085e-3b7a-711e-308c-7061176c0a5c
Content: Deploy your bot using Azure CLI - Bot Service
Content Source: articles/bot-builder-deploy-az-cli.md
Service: bot-service
Product: bot-framework
GitHub Login: @ivorb
Microsoft Alias: v-ivorb

@kriscamilleri -  Thanks for saving my day. I was about to debug the root cause 👍


Pausing and sleep will kill the audio until next track

Only on Yosemite
If you pause a track and then lock/go to sleep when you resume and try to un-pause, the track will continu playing but there will be no sound, until the next track.
EDIT: It's now also happening when only pausing and resuming a song, but when i tried earlier it was fine.

@LeGourmand I'm closing this as it's been a while and I can't replicate, but feel free to ping if it's still happening.


Remove instance variable error for abstract classes

Remove instance variable error for abstract classes
Fixes #2827
Test Plan:

Compile the following code:

abstract class Base
  @a : Int32
end

class Sub < Base
  @b : Int32
  def initialize(@a, @b)
  end
end

No error messages should be thrown

I'm wondering about some edge cases that shouldn't be allowed but might pass through with this change. Please try out this code (I can't right now) and check that it still gives an error.
class A
  @a : Int32
  def initialize
    @a = 5
  end
end

abstract class B < A
  @b : Int32
  def initialize(@b)
  end
end

class C < B
end

Or maybe this is simpler but still checks the same thing (should give an error)
abstract class A
  @b : Int32
end

class B < A
end

(Feel free to use this code, I release it as public domain)

Thanks, @asterite and @BlaXpirit! It seems like the intended behavior may still be developing, but if this PR is indeed wanted eventually, I will gladly make the changes needed to make sure the edge cases are covered.

Closing because the solution is incorrect.


Histogram: number of bins and selected column is not synched between in-plot controls and properties panel

Steps to reproduce:

Open a table
Add a histogram
Change number of bins using in-plot slider
Change number of bins using properties panel
Select another column using in-plot controls

Expected results: number of bins and selected column is synchronised between in-plot controls and properties panel.
Actual results: number of bins is not synchronised, selected column is not synchronised if changed using in-plot controls.

Duplicates https://github.com/datagrok-ai/public/issues/2295

DG 1.17.0 (1.16.4)

Select another column using in-plot controls - selected column is not synchronised between in-plot controls and properties panel -this item is moved to the https://github.com/datagrok-ai/public/issues/2472 ticket


Set flags if their envvar counterparts are set

Prevents conflicts with Cobra for not using any required flag when invoking a connector

https://github.com/spf13/viper/issues/397

tested using baton-ldap, having BATON_DOMAIN set:
➜  ./dist/linux_amd64/baton-ldap
{"level":"error","ts":1721430672.5190167,"caller":"baton-ldap/main.go:58","msg":"error creating connector","error":"LDAP Result Code 200 \"Network Error\": dial tcp [::1]:389: connect: connection refused"}
LDAP Result Code 200 "Network Error": dial tcp [::1]:389: connect: connection refused

(the error happens because I'm not running the LDAP service)
Previously we would get an error that you need to either use the flags domain or url.


Ability to set icon as a value of sensor

As a small UX improvement I would like to set icon as a value of my sensor, e.g. visual representation of battery state, keeping the top-right state with numeric value.

Is it possible currently?

Yes, something like this should work:
icon: function(){
               var battery_level = this.states[item].attributes.battery_level || 0;
               var battery_round = parseInt(battery_level / 10) * 10;

               if (battery_round >= 100) return 'mdi-battery';
               else if (battery_round > 0) return 'mdi-battery-' + battery_round;
               else return 'mdi-battery-alert';
            }

I tried this but no luck, the 100% is still there.
 {
                            position: [0, 1],
                            type: TYPES.SENSOR,
                            id: 'sensor.piggies_camera_battery',
                            title: 'Battery',
                            icon: function(item, entity){
                                var battery_level = this.states[item].attributes.battery_level || 0;
                                var battery_round = parseInt(battery_level / 10) * 10;

                                if (battery_round >= 100) return 'mdi-battery';
                                else if (battery_round > 0) return 'mdi-battery-' + battery_round;
                                else return 'mdi-battery-alert';
                             }
                        },

If sensor.piggies_camera_battery is reporting percentage as state, than you surely need to amend this.states[item].attributes.battery_level. This was a code I used for my  Aqara motion sensors for TEXT_LIST . All you need for your one is entity.state

I wasn't precise enough. The problem is that using TYPES.SENSOR I'm unable to show icon instead of value. Which is obvious looking at the code:

Is there a work around for it other than using TYPES.CUSTOM which makes tile clickable?

Simply use GENERIC_ICON tile

Oh, missed this one, thanks!

And remember that you can still use a function to display a different icon  :)


Unable to send BTC on phantom wallet

Overview
Getting an error when trying to send BTC on phantom wallet
References and additional details

https://jam.dev/c/a3d35509-dba4-4c42-a0fe-265d70bb7055
Acceptance Criteria
Should be able to send BTC on phantom
Need By Date
No response
Screenshots/Mockups
No response
Ownership

[X] If my bounty needs engineering or needs product I have added the respective labels on the right
[X] As the sponsor of this bounty I will review the changes in a preview environment (ops/product) or review the PR (engineering)

Estimated effort
No response
Sponsor / Stakeholder
No response
Bounty Hunters

Join our discord
Include an expected timeline for you to complete work in the work plan when you apply for this bounty!
Please refer to this link for some basic info
Please do not start work on this issue until you are approved in Gitcoin.

Hello @MBMaria
You're experiencing transcript error. It sounds like your query would be best dealt with by the support team.
I'll have to refer you to the official support live chat with the ticket ID PHA07638
Please see the link below to our dedicated support line:
Phantom Network DApps Support Ticket Requests.
[Click on the live chat icon at the bottom corner of the page to initiate chat with a live support agent.]

Confirmed the issue persists after release #8198 went out
https://jam.dev/c/42ee1d49-5107-4815-8ffa-06213220dc99

@MBMaria  @woodenfurniture Couldn't repro on latest develop and prod (tested on develop locally, and upstream on prod), is this still happening for you guys? And if so, can I haz the address you're trying to send to to try to send to it as well?
Develop:

https://live.blockcypher.com/btc/tx/8e081db5f1252d706f9cfd89cda8bf71e9379b1e4aec6c45f45e963afdb46725/
Prod:

https://live.blockcypher.com/btc/tx/21aa9701ad5fdaa8c97d315cb5acbbdd0a53621922b6101a577d2930dbcbcfdb

Was able to recreate again now with a different address.
1st one: 166fG6tESGgUDm53oSAm2cGB2rByzXQG5e
2nd one: bc1qqax70hx8x026y6uv74lewqt9le3n8r56w7s8ng

Was able to recreate again now with a different address. 1st one: 166fG6tESGgUDm53oSAm2cGB2rByzXQG5e 2nd one: bc1qqax70hx8x026y6uv74lewqt9le3n8r56w7s8ng

https://live.blockcypher.com/btc/tx/64e6f666324700847e876616dfe08aac882fdea438a0b96805ede1cf2a562690/
https://live.blockcypher.com/btc/tx/421a1b3fae466a957e4b8104da655a75e204f703454b7ca4fd171d3c104efc2d/
Was able to send to these two addies on develop, requested Foxcrypt of seed to try and repro with affected account 🙏🏽

Repro'd in develop.shapeshift.com after getting @MBMaria's seed and trying a send to 166fG6tESGgUDm53oSAm2cGB2rByzXQG5e and as confirmed, this is not an us issue but it is thrown by Phantom:

However, regardless of how many times I try this again on upstream develop or while running web locally, I can't get to this error anymore for debugging.
See myself retrying with a fully cleared cache and MbMaria's account:
https://jam.dev/c/30fb10e8-bad3-46e9-a9aa-627e82f71004

Update: There's not so much about 166fG6tESGgUDm53oSAm2cGB2rByzXQG5e being borked to send to, but rather all sends failing when sending from Maria's seed. @woodenfurniture you could confirm here but pretty sure any send - including self-send, would fail for you as well.
Going deeper into the rabbit hole, debugging not only our implementation but running devtools on Phantom extension itself, stay tuned...

@MBMaria I've tried a self-send through Phantom's UI and it seems to have unblocked things, now sends are happy in app - couldn't see anything wrong in how the Tx was previously formed, though I suspect there is something Phantom didn't like in the previous UTXO set.
@woodenfurniture if you want to try this as well, though careful, this means you won't be able to repro anymore as that effectively solves things. Will raise the issue to Phantom since I was able to capture the error in Phantom devtools.

Moving to blocked as issue has been raised upstream. For the time being, solution is to proceed to (any) send through Phantom UI itself, which I assume reconciliates the UTXO set for the address (not xpub, Phantom only consumes address_index 0 and doesn't do next receive addy business) in a way that it's then happy with when we call signPSBT() the next time around

Confirmed with @woodenfurniture and @MBMaria we're g2g here as we have effectively a fix to tell users for the time being. Closing, to be reopened if/when there are changes fixing this upstream in Phantom build.


Detach latest migration

Step one of https://github.com/Electron100/butane/issues/91 - detach rather than unmake.

I was a bit ambiguous initially planning to allow any migration to be detached.  While detaching from the middle is do-able, it is less sensible to allow it, and it is not necessary for most common #91 scenarios.  Doing multiple detaches of the top migration is sufficient, and adding support for re-attaching migrations is more important IMO.

Ack on the review request. Will take a look tomorrow.

Note two parts of https://github.com/Electron100/butane/issues/91#issuecomment-1567598015 that I havent implemented yet is

Undo it from the embed

and

When there is an existing detached migration, all commands would be disabled except for the "rejoin", with an error message informing the user how to delete the detached migration if they want to abandon it.

The first of those is mandatory.
IMO the second doesnt depend on "rejoin" being built first - all commands can be blocked until the detached migration has been removed - atm that means it is the users responsibility to do something with it or delete it.  I'm happy to do that in the scope of this PR if you agree that is good enough for now.

I've added the ability to detect if there are detached migrations, but after looking through the existing list of commands I am reconsidering whether this is needed at all.  While it might be usually a bad idea to run some of the commands when there is a detached migration, it cant cause new undesirable states which we must avoid, and maybe we should just let the user do the commands and let them deal with the repercussions.
What might be useful is to always print the list of detached migrations, so they are not accidentally forgotten.

I agree with your reconsideration -- it doesn't seem necessary to me to actually block operations for detached migrations.


Update docker-compose-cpu.yaml

Commented nvidia runtime out as it throws an error while compiling in no gpu mode.

@kpfadnis : my bad - done.

Fixes #11


Support just in time dependencies depending on just in time

dependencies.
This is a WIP but looking for feedback on this to see if this is the right direction to go here or if this is totally the wrong approach.
This moves the JustInTimeLookupFactory lookup from the getBinding method
in Scope to the findBinding method in Scope.
This then uses the Scope's findBinding method from the Linker's find method
in order.

Also, if you want, try and remove the excludeTest bits in integration-test/upstream/build.gradle which talk about JIT depending on JIT and see if they pass.

So it looks less good now that I've dug deeper. Trying to think of a reasonable way to solve this.


[typescript-language-features] Add telemetry for package.json auto imports

Counterpart to https://github.com/microsoft/TypeScript/pull/38923 (and #103037)
This is my first time messing with VS Code telemetry so I have some questions and need a careful review.
With https://github.com/microsoft/TypeScript/pull/38923, we are potentially doing extra work to offer more auto-imports in completion items, so we want to validate that it’s worth it. So, this PR adds a property to the existing completions.execute event that says whether any of these extra items are included in the response, and adds a new event, completions.accept, fired upon accepting a completion item, that includes a property that says whether the accepted item was one of these extra auto-import completion items. Between these two events, we can determine how often the extra work was what the user wanted.

Looks good to me. Thanks!


Don't accept outdated SCP messages

I can't really think of a way to test this, because the only thing that changes here is the logging. The state machine (Ledger) wouldn't change if for example an outdated SCP Externalize message was accepted (it would be a double-spend).
This eliminates the various "tx not found in tx set" error messages we frequently saw in the CI logs.

This also might be a symptom of something wrong with SCP. I don't quite understand why the protocol is calling the validation routine validateValue on a slot which was already externalized. It would seem to me that SCP should log an error very early on and skip validation.

Rebased.
I've added another commit removing externalized_slots, because we can just use the Ledger directly.


sfml: 2.5.0 -> 2.5.1

Semi-automatic update generated by https://github.com/ryantm/nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/sfml/versions.
meta.description for sfml is: '"Simple and fast multimedia library"'.
Release on GitHub
Compare changes on GitHub

Checks done (click to expand)

built on NixOS

0 of 0 passed binary check by having a zero exit code.

0 of 0 passed binary check by having the new version present in output.

found 2.5.1 with grep in /nix/store/mz1mh7bdhx43ld9hf0vk62d28jm1zlvg-sfml-2.5.1

directory tree listing: https://gist.github.com/870b226740e7e6588e8f393c7458ad72

du listing: https://gist.github.com/c5e335f4197db3b71ca1a96b2d18483e

Outpath report (click to expand)

Outpath difference report
50 total rebuild paths
17 package rebuilds
17 x86_64-linux rebuilds
15 i686-linux rebuidls
5 x86_64-darwin rebuilds
13 aarch64-linux rebuilds
First ten rebuilds by attrpath
EmptyEpsilon
attract-mode
csfml
dolphinEmu
dolphinEmuMaster
extremetuxracer
libretro.dolphin
mars
mosdepth
nim

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/mz1mh7bdhx43ld9hf0vk62d28jm1zlvg-sfml-2.5.1 \
  --option binary-caches 'https://cache.nixos.org/ https://r-ryantm.cachix.org/' \
  --option trusted-public-keys '
  r-ryantm.cachix.org-1:gkUbLkouDAyvBdpBX0JOdIiD2/DP1ldF3Z3Y6Gqcc4c=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(r-ryantm's Cachix cache is only trusted for this store-path realization.)
Or, build yourself:
nix-build -A sfml https://github.com/r-ryantm/nixpkgs/archive/281cd63045596b08c4de85e5f226d54f79759149.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/mz1mh7bdhx43ld9hf0vk62d28jm1zlvg-sfml-2.5.1
ls -la /nix/store/mz1mh7bdhx43ld9hf0vk62d28jm1zlvg-sfml-2.5.1/bin

cc @astsmtl for testing.

@GrahamcOfBorg eval

Success on aarch64-linux (full log)
Attempted: sfml
Partial log (click to expand)
shrinking RPATHs of ELF executables and libraries in /nix/store/86z0bpnrxmrkk2lx6b2sf5875ryjkg2w-sfml-2.5.1
shrinking /nix/store/86z0bpnrxmrkk2lx6b2sf5875ryjkg2w-sfml-2.5.1/lib/libsfml-audio.so.2.5.1
shrinking /nix/store/86z0bpnrxmrkk2lx6b2sf5875ryjkg2w-sfml-2.5.1/lib/libsfml-graphics.so.2.5.1
shrinking /nix/store/86z0bpnrxmrkk2lx6b2sf5875ryjkg2w-sfml-2.5.1/lib/libsfml-network.so.2.5.1
shrinking /nix/store/86z0bpnrxmrkk2lx6b2sf5875ryjkg2w-sfml-2.5.1/lib/libsfml-window.so.2.5.1
shrinking /nix/store/86z0bpnrxmrkk2lx6b2sf5875ryjkg2w-sfml-2.5.1/lib/libsfml-system.so.2.5.1
strip is /nix/store/p9akxn2sfy4wkhqdqa3li97pc6jaz3r1-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/86z0bpnrxmrkk2lx6b2sf5875ryjkg2w-sfml-2.5.1/lib
patching script interpreter paths in /nix/store/86z0bpnrxmrkk2lx6b2sf5875ryjkg2w-sfml-2.5.1
checking for references to /build in /nix/store/86z0bpnrxmrkk2lx6b2sf5875ryjkg2w-sfml-2.5.1...

Success on x86_64-linux (full log)
Attempted: sfml
Partial log (click to expand)
shrinking RPATHs of ELF executables and libraries in /nix/store/p3zm7iwn17mh1vq77dnsmsandiy9r1bx-sfml-2.5.1
shrinking /nix/store/p3zm7iwn17mh1vq77dnsmsandiy9r1bx-sfml-2.5.1/lib/libsfml-graphics.so.2.5.1
shrinking /nix/store/p3zm7iwn17mh1vq77dnsmsandiy9r1bx-sfml-2.5.1/lib/libsfml-window.so.2.5.1
shrinking /nix/store/p3zm7iwn17mh1vq77dnsmsandiy9r1bx-sfml-2.5.1/lib/libsfml-system.so.2.5.1
shrinking /nix/store/p3zm7iwn17mh1vq77dnsmsandiy9r1bx-sfml-2.5.1/lib/libsfml-network.so.2.5.1
shrinking /nix/store/p3zm7iwn17mh1vq77dnsmsandiy9r1bx-sfml-2.5.1/lib/libsfml-audio.so.2.5.1
strip is /nix/store/vcc4svb8gy29g4pam2zja6llkbcwsyiq-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/p3zm7iwn17mh1vq77dnsmsandiy9r1bx-sfml-2.5.1/lib
patching script interpreter paths in /nix/store/p3zm7iwn17mh1vq77dnsmsandiy9r1bx-sfml-2.5.1
checking for references to /build in /nix/store/p3zm7iwn17mh1vq77dnsmsandiy9r1bx-sfml-2.5.1...

Success on x86_64-darwin (full log)
Attempted: sfml
Partial log (click to expand)
/nix/store/zx0bcdyb9gmxl6dd5dpr4ixvg591551b-sfml-2.5.1/lib/libsfml-graphics.2.5.1.dylib: fixing dylib
/nix/store/zx0bcdyb9gmxl6dd5dpr4ixvg591551b-sfml-2.5.1/lib/libsfml-network.2.5.1.dylib: fixing dylib
/nix/store/zx0bcdyb9gmxl6dd5dpr4ixvg591551b-sfml-2.5.1/lib/libsfml-system.2.5.1.dylib: fixing dylib
/nix/store/zx0bcdyb9gmxl6dd5dpr4ixvg591551b-sfml-2.5.1/lib/libsfml-window.2.5.1.dylib: fixing dylib
/nix/store/zx0bcdyb9gmxl6dd5dpr4ixvg591551b-sfml-2.5.1/lib/libsfml-audio.2.5.1.dylib: fixing dylib
/nix/store/zx0bcdyb9gmxl6dd5dpr4ixvg591551b-sfml-2.5.1/lib/libsfml-graphics.2.5.1.dylib: fixing dylib
/nix/store/zx0bcdyb9gmxl6dd5dpr4ixvg591551b-sfml-2.5.1/lib/libsfml-network.2.5.1.dylib: fixing dylib
/nix/store/zx0bcdyb9gmxl6dd5dpr4ixvg591551b-sfml-2.5.1/lib/libsfml-system.2.5.1.dylib: fixing dylib
/nix/store/zx0bcdyb9gmxl6dd5dpr4ixvg591551b-sfml-2.5.1/lib/libsfml-window.2.5.1.dylib: fixing dylib
/nix/store/zx0bcdyb9gmxl6dd5dpr4ixvg591551b-sfml-2.5.1

@GrahamcOfBorg build sfml

Success on aarch64-linux (full log)
Attempted: sfml
Partial log (click to expand)
shrinking RPATHs of ELF executables and libraries in /nix/store/q9d69q1ff2nvm4rc5j1hnz572rgq4cyd-sfml-2.5.1
shrinking /nix/store/q9d69q1ff2nvm4rc5j1hnz572rgq4cyd-sfml-2.5.1/lib/libsfml-audio.so.2.5.1
shrinking /nix/store/q9d69q1ff2nvm4rc5j1hnz572rgq4cyd-sfml-2.5.1/lib/libsfml-graphics.so.2.5.1
shrinking /nix/store/q9d69q1ff2nvm4rc5j1hnz572rgq4cyd-sfml-2.5.1/lib/libsfml-network.so.2.5.1
shrinking /nix/store/q9d69q1ff2nvm4rc5j1hnz572rgq4cyd-sfml-2.5.1/lib/libsfml-window.so.2.5.1
shrinking /nix/store/q9d69q1ff2nvm4rc5j1hnz572rgq4cyd-sfml-2.5.1/lib/libsfml-system.so.2.5.1
strip is /nix/store/p9akxn2sfy4wkhqdqa3li97pc6jaz3r1-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/q9d69q1ff2nvm4rc5j1hnz572rgq4cyd-sfml-2.5.1/lib
patching script interpreter paths in /nix/store/q9d69q1ff2nvm4rc5j1hnz572rgq4cyd-sfml-2.5.1
checking for references to /build in /nix/store/q9d69q1ff2nvm4rc5j1hnz572rgq4cyd-sfml-2.5.1...

Success on x86_64-linux (full log)
Attempted: sfml
Partial log (click to expand)
shrinking RPATHs of ELF executables and libraries in /nix/store/d3a5kfq200hawl93yd5zw7ckyi16nkfp-sfml-2.5.1
shrinking /nix/store/d3a5kfq200hawl93yd5zw7ckyi16nkfp-sfml-2.5.1/lib/libsfml-audio.so.2.5.1
shrinking /nix/store/d3a5kfq200hawl93yd5zw7ckyi16nkfp-sfml-2.5.1/lib/libsfml-system.so.2.5.1
shrinking /nix/store/d3a5kfq200hawl93yd5zw7ckyi16nkfp-sfml-2.5.1/lib/libsfml-network.so.2.5.1
shrinking /nix/store/d3a5kfq200hawl93yd5zw7ckyi16nkfp-sfml-2.5.1/lib/libsfml-graphics.so.2.5.1
shrinking /nix/store/d3a5kfq200hawl93yd5zw7ckyi16nkfp-sfml-2.5.1/lib/libsfml-window.so.2.5.1
strip is /nix/store/vcc4svb8gy29g4pam2zja6llkbcwsyiq-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/d3a5kfq200hawl93yd5zw7ckyi16nkfp-sfml-2.5.1/lib
patching script interpreter paths in /nix/store/d3a5kfq200hawl93yd5zw7ckyi16nkfp-sfml-2.5.1
checking for references to /build in /nix/store/d3a5kfq200hawl93yd5zw7ckyi16nkfp-sfml-2.5.1...

Failure on x86_64-linux (full log)
Partial log (click to expand)
Merge failed

Failure on aarch64-linux (full log)
Partial log (click to expand)
Merge failed

Failure on x86_64-darwin (full log)
Partial log (click to expand)
Merge failed

(retried locally and it builds fine, just to be sure)


bug([@angular/material*]): Packages won't be catched by ngcc anymore | v9.1.1

Reproduction
Steps to reproduce:

npm i @angular/compiler @angular/compiler-cli @angular/core @angular/material @angular/cdk tslib<EMAIL_ADDRESS>run ngcc --properties es2015 --first-only --create-ivy-entry-points

Expected Behavior
What behavior were you expecting to see?
@angular/material packages to be compiled by ngcc like before.
 Tried this again within webstorm IDE.
↯flash↯/c/sources/angular-micro-frontends
└─▶ngcc --properties main --first-only
Compiling @angular/cdk/keycodes : main as umd
Compiling @angular/compiler/testing : main as umd
Compiling @angular/core : main as umd
Compiling @angular/common : main as umd
Compiling @angular/cdk/collections : main as umd
Compiling @angular/cdk/observers : main as umd
Compiling @angular/cdk/platform : main as umd
Compiling @angular/cdk/portal : main as umd
Compiling @angular/core/testing : main as umd
Compiling @angular/platform-browser : main as umd
Compiling @angular/cdk/a11y : main as umd
Compiling @angular/cdk/clipboard : main as umd
Compiling @angular/cdk/text-field : main as umd
Compiling @angular/cdk/layout : main as umd
Compiling @angular/common/testing : main as umd
Compiling @angular/cdk/bidi : main as umd
Compiling @angular/elements : main as umd
Compiling @angular/forms : main as umd
Compiling @angular/platform-browser/testing : main as umd
Compiling @angular/cdk/accordion : main as umd
Compiling @angular/cdk/scrolling : main as umd
Compiling @angular/cdk/stepper : main as umd
Compiling @angular/common/http : main as umd
Compiling @angular/cdk/table : main as umd
Compiling @angular/cdk/tree : main as umd
Compiling @angular/cdk/drag-drop : main as umd
Compiling @angular/common/http/testing : main as umd
Compiling @angular/cdk/overlay : main as umd
↯flash↯/c/sources/angular-micro-frontends
└─▶ngcc --properties main --first-only -s node_modules/
Display all 403 possibilities? (y or n)
↯flash↯/c/sources/angular-micro-frontends
└─▶ngcc --properties main --first-only -s node_modules/\@
@angular/        @angular-devkit/ @babel/          @rollup/         @schematics/     @sindresorhus/   @szmarczak/      @types/          @webcomponents/  @yarnpkg/
↯flash↯/c/sources/angular-micro-frontends
└─▶ngcc --properties main --first-only -s node_modules/\@angular/material
Compiling @angular/material/core : main as umd
Compiling @angular/material/icon : main as umd
Compiling @angular/material/divider : main as umd
Compiling @angular/material/grid-list : main as umd
Compiling @angular/material/icon/testing : main as umd
Compiling @angular/material/list : main as umd
Compiling @angular/material/badge : main as umd
Compiling @angular/material/button : main as umd
Compiling @angular/material/progress-bar : main as umd
Compiling @angular/material/card : main as umd
Compiling @angular/material/button-toggle : main as umd
Compiling @angular/material/checkbox : main as umd
Compiling @angular/material/progress-spinner : main as umd
Compiling @angular/material/radio : main as umd
Compiling @angular/material/slide-toggle : main as umd
Compiling @angular/material/slider : main as umd
Compiling @angular/material/toolbar : main as umd
Compiling @angular/material/tree : main as umd
↯flash↯/c/sources/angular-micro-frontends
└─▶

The only difference here is that webstorm adds node_modules/.bin/ to the %PATH%

cheers
flash :zap:

Thanks for the issue. I just tried your command, and I was able to reproduce the described issue.
The problem here is that ngcc is unable to process all entry-points if they have missing dependencies. e.g. Angular Material depends on @angular/common.
When I added the required dependencies, ngcc was able to process all entry-points as expected.

This indeed solves the issue. Thanks for the hint! From my side this issue can be closed.
Cheers
flash :zap:


Added Console Log Listener Test

This PR adds a TestCase for the Console Listener.
It's not the best approach but as the class uses new Classname we have no choice.
Still better than no test.

Hi @ins0 ,
thanks for your work so far. You are totally right to have a Unit Test on this rather important part of the tool.
But I think, it would be better to be able to inject either the $consoleOutput in the constructor, or set it automatically as it is now. This gives us the opportunity to inject a proper interface and implement our stub against the interface, not against the implementation inside the class.
I do not like the reflection approach with unit tests at all, since the test has to much knowledge about the tested class and I cannot be sure anymore to not break anything, if I change private members of a class.
Do you still want to work on this?
Grüße
Markus :-)

Used the reflection only because i thaught about the test in the first place - rather then to touch multiple files for this. Sure.

@frickelbruder done ;)

Ok,
I'll merge this PR, as I think it is good as it is.
I don't like the fwrite substitution and will revert it back. There is another fix for this in the 2.0 branch, which does not change the code but is a fix in the tests, where the EOL-thing is mostly annoying.
One thing:
It would be better to provide one encapsuled feature per PR. This makes it easier to track and/or merge the changes.
But many thanks anyway :-)
Regards
Markus


npm install fails if no server.js | app.js | main.js | index.js found in the root 0.17.0

What happened?

What were you attempting to do?

Download https://github.com/paketo-buildpacks/samples/tree/main/nodejs/npm
mv server.js src/server.js
Update start script in package.json: "start": "echo "start" && node src/server.js"
Run building

What did you expect to happen?
Successful build (as in gcr.io/paketo-buildpacks/nodejs:0.16)

What was the actual behavior? Please provide log output, if possible.

pack build my-app --builder paketobuildpacks/builder:base --buildpack gcr.io/paketo-buildpacks/nodejs -v
Builder paketobuildpacks/builder:base is trusted
Pulling image index.docker.io/paketobuildpacks/builder:base
base: Pulling from paketobuildpacks/builder
Digest: sha256:204eddae19e3f91b44be9ad28922810f93ae5b83f9a30f975934f00f4dabe62f
Status: Image is up to date for paketobuildpacks/builder:base
Selected run image index.docker.io/paketobuildpacks/run:base-cnb
Pulling image index.docker.io/paketobuildpacks/run:base-cnb
base-cnb: Pulling from paketobuildpacks/run
Digest: sha256:38199b888e33bed03b98bfed20a091733f502c33ced1a6660ed5c92ed82308ea
Status: Image is up to date for paketobuildpacks/run:base-cnb
Downloading buildpack from image: gcr.io/paketo-buildpacks/nodejs
Pulling image gcr.io/paketo-buildpacks/nodejs
latest: Pulling from paketo-buildpacks/nodejs
Digest: sha256:c18649cacd75e433211a2622b3dce1807eb7e076d827fb253fbb28e9d23a3d0e
Status: Image is up to date for gcr.io/paketo-buildpacks/nodejs:latest
Adding buildpack paketo-buildpacks/nodejs version 0.17.0 to builder
Adding buildpack paketo-buildpacks/node-start version 0.8.0 to builder
Adding buildpack paketo-buildpacks/procfile version 5.1.0 to builder
Adding buildpack paketo-buildpacks/watchexec version 2.3.5 to builder
Adding buildpack paketo-buildpacks/ca-certificates version 3.1.0 to builder
Adding buildpack paketo-buildpacks/environment-variables version 4.1.0 to builder
Adding buildpack paketo-buildpacks/node-engine version 0.12.3 to builder
Adding buildpack paketo-buildpacks/node-module-bom version 0.2.4 to builder
Adding buildpack paketo-buildpacks/npm-start version 0.9.0 to builder
Adding buildpack paketo-buildpacks/node-run-script version 0.3.3 to builder
Adding buildpack paketo-buildpacks/npm-install version 0.9.0 to builder
Adding buildpack paketo-buildpacks/yarn-install version 0.9.0 to builder
Adding buildpack paketo-buildpacks/image-labels version 4.1.0 to builder
Adding buildpack paketo-buildpacks/yarn version 0.6.1 to builder
Adding buildpack paketo-buildpacks/yarn-start version 0.8.0 to builder
Setting custom order
Creating builder with the following buildpacks:
-><EMAIL_ADDRESS>-><EMAIL_ADDRESS>-><EMAIL_ADDRESS>-><EMAIL_ADDRESS>-><EMAIL_ADDRESS>-><EMAIL_ADDRESS>-><EMAIL_ADDRESS>-><EMAIL_ADDRESS>-><EMAIL_ADDRESS>-><EMAIL_ADDRESS>-><EMAIL_ADDRESS>-><EMAIL_ADDRESS>-><EMAIL_ADDRESS>-><EMAIL_ADDRESS>-><EMAIL_ADDRESS>-><EMAIL_ADDRESS>-><EMAIL_ADDRESS>-><EMAIL_ADDRESS>-><EMAIL_ADDRESS>-><EMAIL_ADDRESS>-><EMAIL_ADDRESS>-><EMAIL_ADDRESS>-><EMAIL_ADDRESS>-><EMAIL_ADDRESS>-><EMAIL_ADDRESS>-><EMAIL_ADDRESS>-><EMAIL_ADDRESS>-><EMAIL_ADDRESS>-><EMAIL_ADDRESS>-><EMAIL_ADDRESS>-><EMAIL_ADDRESS>-><EMAIL_ADDRESS>-><EMAIL_ADDRESS>-><EMAIL_ADDRESS>-><EMAIL_ADDRESS>-><EMAIL_ADDRESS>-><EMAIL_ADDRESS>-><EMAIL_ADDRESS>-><EMAIL_ADDRESS>-><EMAIL_ADDRESS>-><EMAIL_ADDRESS>-><EMAIL_ADDRESS>-><EMAIL_ADDRESS>-><EMAIL_ADDRESS>-><EMAIL_ADDRESS>-><EMAIL_ADDRESS>-><EMAIL_ADDRESS>-><EMAIL_ADDRESS>-><EMAIL_ADDRESS>-><EMAIL_ADDRESS>-><EMAIL_ADDRESS>-><EMAIL_ADDRESS>-><EMAIL_ADDRESS>-><EMAIL_ADDRESS>-><EMAIL_ADDRESS>-><EMAIL_ADDRESS>-><EMAIL_ADDRESS>-><EMAIL_ADDRESS>-><EMAIL_ADDRESS>-><EMAIL_ADDRESS>-><EMAIL_ADDRESS>-><EMAIL_ADDRESS>-><EMAIL_ADDRESS>-><EMAIL_ADDRESS>-><EMAIL_ADDRESS>-><EMAIL_ADDRESS>-><EMAIL_ADDRESS>-><EMAIL_ADDRESS>-><EMAIL_ADDRESS>-><EMAIL_ADDRESS>-><EMAIL_ADDRESS>-><EMAIL_ADDRESS>-><EMAIL_ADDRESS>-><EMAIL_ADDRESS>-><EMAIL_ADDRESS>-><EMAIL_ADDRESS>-><EMAIL_ADDRESS>-><EMAIL_ADDRESS>-><EMAIL_ADDRESS>-><EMAIL_ADDRESS>-><EMAIL_ADDRESS>-><EMAIL_ADDRESS>-><EMAIL_ADDRESS>-><EMAIL_ADDRESS>-><EMAIL_ADDRESS>-><EMAIL_ADDRESS>-><EMAIL_ADDRESS>-><EMAIL_ADDRESS>-><EMAIL_ADDRESS>-><EMAIL_ADDRESS>-><EMAIL_ADDRESS>-><EMAIL_ADDRESS>-><EMAIL_ADDRESS>-><EMAIL_ADDRESS>-><EMAIL_ADDRESS>-><EMAIL_ADDRESS>-><EMAIL_ADDRESS>-><EMAIL_ADDRESS>-><EMAIL_ADDRESS>-><EMAIL_ADDRESS>-><EMAIL_ADDRESS>-><EMAIL_ADDRESS>-><EMAIL_ADDRESS>-><EMAIL_ADDRESS>-><EMAIL_ADDRESS>-><EMAIL_ADDRESS>-><EMAIL_ADDRESS>-><EMAIL_ADDRESS>-><EMAIL_ADDRESS>-><EMAIL_ADDRESS>-><EMAIL_ADDRESS>-><EMAIL_ADDRESS>-><EMAIL_ADDRESS>-><EMAIL_ADDRESS>-><EMAIL_ADDRESS>-><EMAIL_ADDRESS>-><EMAIL_ADDRESS>-><EMAIL_ADDRESS>-><EMAIL_ADDRESS>-><EMAIL_ADDRESS>-><EMAIL_ADDRESS>-><EMAIL_ADDRESS>-><EMAIL_ADDRESS>-><EMAIL_ADDRESS>-><EMAIL_ADDRESS>-><EMAIL_ADDRESS>-><EMAIL_ADDRESS>-><EMAIL_ADDRESS>-><EMAIL_ADDRESS>-><EMAIL_ADDRESS>-><EMAIL_ADDRESS>-><EMAIL_ADDRESS>Buildpack<EMAIL_ADDRESS>already exists on builder with same contents, skipping...
Buildpack<EMAIL_ADDRESS>already exists on builder with same contents, skipping...
Buildpack<EMAIL_ADDRESS>already exists on builder with same contents, skipping...
Buildpack<EMAIL_ADDRESS>already exists on builder with same contents, skipping...
Buildpack<EMAIL_ADDRESS>already exists on builder with same contents, skipping...
Buildpack<EMAIL_ADDRESS>already exists on builder with same contents, skipping...
Buildpack<EMAIL_ADDRESS>already exists on builder with same contents, skipping...
Buildpack<EMAIL_ADDRESS>already exists on builder with same contents, skipping...
Buildpack<EMAIL_ADDRESS>already exists on builder with same contents, skipping...
Buildpack<EMAIL_ADDRESS>already exists on builder with same contents, skipping...
Buildpack<EMAIL_ADDRESS>already exists on builder with same contents, skipping...
Buildpack<EMAIL_ADDRESS>already exists on builder with same contents, skipping...
Buildpack<EMAIL_ADDRESS>already exists on builder with same contents, skipping...
Buildpack<EMAIL_ADDRESS>already exists on builder with same contents, skipping...
Buildpack<EMAIL_ADDRESS>already exists on builder with same contents, skipping...
Using build cache volume pack-cache-library_my-app_latest-cbd6ecf04229.build
Running the creator on OS linux with:
Container Settings:
  Args: /cnb/lifecycle/creator -daemon -launch-cache /launch-cache -log-level debug -app /workspace -cache-dir /cache -run-image index.docker.io/paketobuildpacks/run:base-cnb my-app
  System Envs: CNB_PLATFORM_API=0.8
  Image: pack.local/builder/6c616273676b6279696a:latest
  User: root
  Labels: map[author:pack]
Host Settings:
  Binds: pack-cache-library_my-app_latest-cbd6ecf04229.build:/cache /var/run/docker.sock:/var/run/docker.sock pack-cache-library_my-app_latest-cbd6ecf04229.launch:/launch-cache pack-layers-wkkmrxfaxr:/layers pack-app-topujlgoev:/workspace
  Network Mode:
===> ANALYZING
Analyzing image "80dab43240cefaf161ea29cae233b2d2913659ffbe590e3d6431af9e5165464b"
Restoring data for sbom from previous image
Retrieving previous image sbom layer for "sha256:debcbe5b235b338dbcdbf09aff514ebbee0de58715f8846a85fe7d53974c54bd"
Analyzing image "497ee92d82e944a5b4a9e2d9802e9261bf65cf509d07096dbd83a909c98baadd"
===> DETECTING
======== Output<EMAIL_ADDRESS>========
failed
======== Output<EMAIL_ADDRESS>========
expected value from $BP_NODE_RUN_SCRIPTS to be set
======== Output<EMAIL_ADDRESS>========
could not find app in /workspace: expected one of server.js | app.js | main.js | index.js
======== Output<EMAIL_ADDRESS>========
failed
======== Results ========
pass<EMAIL_ADDRESS>pass<EMAIL_ADDRESS>pass<EMAIL_ADDRESS>pass<EMAIL_ADDRESS>fail<EMAIL_ADDRESS>pass<EMAIL_ADDRESS>skip<EMAIL_ADDRESS>fail<EMAIL_ADDRESS>skip<EMAIL_ADDRESS>skip<EMAIL_ADDRESS>skip<EMAIL_ADDRESS>skip<EMAIL_ADDRESS>======== Output<EMAIL_ADDRESS>========
expected value from $BP_NODE_RUN_SCRIPTS to be set
======== Output<EMAIL_ADDRESS>========
could not find app in /workspace: expected one of server.js | app.js | main.js | index.js
======== Results ========
pass<EMAIL_ADDRESS>pass<EMAIL_ADDRESS>pass<EMAIL_ADDRESS>pass<EMAIL_ADDRESS>pass<EMAIL_ADDRESS>skip<EMAIL_ADDRESS>fail<EMAIL_ADDRESS>pass<EMAIL_ADDRESS>skip<EMAIL_ADDRESS>skip<EMAIL_ADDRESS>skip<EMAIL_ADDRESS>======== Output<EMAIL_ADDRESS>========
could not find app in /workspace: expected one of server.js | app.js | main.js | index.js
======== Results ========
pass<EMAIL_ADDRESS>pass<EMAIL_ADDRESS>pass<EMAIL_ADDRESS>pass<EMAIL_ADDRESS>fail<EMAIL_ADDRESS>skip<EMAIL_ADDRESS>skip<EMAIL_ADDRESS>skip<EMAIL_ADDRESS>ERROR: No buildpack groups passed detection.
ERROR: Please check that you are running against the correct path.
ERROR: failed to detect: no buildpacks participating
ERROR: failed to build: executing lifecycle: failed with status code: 20

Build Configuration

What platform (pack, kpack, tekton buildpacks plugin, etc.) are you

pack --version
0.24.0

What buildpacks are you using? Please include versions.
gcr.io/paketo-buildpacks/nodejs:0.17

What builder are you using? If custom, can you provide the output from pack inspect-builder <builder>?
paketobuildpacks/builder:base

Can you provide a sample app or relevant configuration (buildpack.yml,
nginx.conf, etc.)?

Checklist

[+] I have included log output.
[+] The log output includes an error message.
[+] I have included steps for reproduction.

As far as I can tell from the PRs is that this has been resolved can someone confirm that status of this issue.

I'm gonna close this since we believe the issue to be resolved.


Login issue in RN

Describe the bug
The bug is...
"We're unable to complete your request - invalid_request: The provided value for the input parameter 'redirect_uri' is not valid. The expected value is a URI which matches a redirect URI registered for this client application."
--> Note: this application works on the web version, but does not work on mobile (RN with ngrok).
To Reproduce

Click Sign in with Microsoft.
The Microsoft login to enter the email is displayed.
I enter the email and click on the Next button
See error

Expected behavior
After entering the email it should allow me to enter the password but that error appears.
Screenshots

Ty! @IronTony @enlightenedpie @glauberbrack

I closed the PR because I found the solution to the problem, I had to use HTTPS instead of HTTP in the redirect_uri.


Preserve Reading Progress on App Restore from Background

Describe your suggested feature
Description:
When the LNReader app is running in the background and gets terminated by the system, the app currently reopens to the default Library screen upon restoration. However, it correctly saves the progress of the currently read chapter.
Issue:
It would be beneficial if the app could not only save the reading progress but also restore the user to the exact entry they were reading, including the specific chapter and position within it, when the app is restarted after being killed.
Proposed Solution:
Implementing state restoration using the Android Saved State feature could address this issue. This would involve:

Storing the Current Reading Entry: Save details of the chapter and current position when the app goes into the background or is about to be killed by the system.
Restoring the Reading State: On app launch, check if there is a saved reading state and navigate the user directly to their last-read entry instead of the Library screen.

Benefits:

Improved User Experience: Users can resume their reading exactly where they left off, making the app more user-friendly and efficient.
Consistency: Maintains continuity and reduces frustration for users who might be interrupted by system resource management.

Other details
No response
Acknowledgements

[X] I have searched the existing issues and this is a new ticket, NOT a duplicate or related to another open or closed issue.
[X] I have written a short but informative title.
[X] If this is an issue with a source, I should be opening an issue in the sources repository.
[X] I have updated the app to version 2.0.0.
[X] I will fill out all of the requested information in this form.

maybe..
Re-open app, click History, click the entry at the top. that's it.
This feature reminds of the electric hammer, somehow.

maybe.. Re-open app, click History, click the entry at the top. that's it. This feature reminds of the electric hammer, somehow.

I have an older phone with limited RAM, so every time I reopen the app, it starts at the home screen instead of where I left off. This adds a few extra steps to get back to my reading position whenever the reader closes unexpectedly.
For example, the Tachiyomi manga reader restores the previous session even after being terminated by the system, though it doesn’t save the exact scroll position within an image. If LNReader could implement a similar state-saving feature, it would enhance the user experience by making it easier to pick up exactly where we left off.


Required Python version for deployment?

What's the minimum supported Python version?
I think because of the new-style lowercase type annotations (like dict[str,int]) that would be around 3.10, correct?  If we wanted to support older Python, we would need from __future__ import annotations?

I think 3.9 ? : https://peps.python.org/pep-0585/
That said, I've made use of from __future__ import annotations in LiberTEM-panel-ui so I can add the same to this repo. That should bring it down to about 3.7 ? (as long as the install is reasonably recent)

I do think the type Union syntax int | None is from 3.10, you're right! Still should be fine with __future__ though.

That should bring it down to about 3.7

Correct.

Closed through #4 (drive-by)


some bugs

Campfire - Incorrect name with the name Soul Campfire
Lantern - Incorrect name with the name Soul Lantern
Dirt - Incorrect name with the name Soul Dirt
Grass block - Wrong name with the name Crimson Roots + Displays the wrong block and Grass block can't be placed in survival as a creative. use the showel
use shovel to pick up grass block that gets dirt it works fine
Jack'O Lantern - Wrong name with the name Shroom Light + The cutouts are always displayed in the same direction.
Rednether - Incorrect name with the name Blackstone
Dark oak sign - Incorrect name with the name Warped sign
Acacia sign - Incorrect name with the name Crimson Sign
Oak log - Incorrect name with the name Warped Hyphae
Haybale - Wrong name with the name Target + The broadcast is locked in a direction similar to Jack'O Lantern
Vines - Incorrect name with the name Twisting Vines + They are displayed incorrectly when placed, displayed as a full block instead of just the page that touches other blocks
Unknown Name -2 Black eggs with the name - item.spawn_egg.entity.xp_orb.name and item.spawn_egg.entity.thrown_trident.name
I also found a couple of other things that were wrong.
Placing water in a bucket does not work properly, you must hold the placement button for about 1 second before placing it.
Flower Pot - Can not be placed.
Iron Bars - Cannot be held in invetory, and can not be placed in the world due to this.

bee nest - Cannot be held in invetory, and can not be placed in the world due to this.

Thanks for these. I'll go through them and correct the mappings. Its possible the new 1.14.70 has similar or more issues like this since I've not tested all the mappings yet.


notebook versioning via git

Today we came up with, IMHO, a pretty good idea, to use git for notebook versioning.

[ ] conf/application.conf option to use *.ipynb extension, so it's displayed nicely on github

[ ] save a checkpoint (optionally with a name given)
git add dir/notebook-name.snb && git commit -m 'Checkpoint: User given name'

[ ] list existing checkpoints

[ ] restore to a certain checkpoint
git checkout commitSHA -- filename && git add filename && git commit -m 'Restore to a checkpoint'

[ ] git commands need to be synchronized, so it's one commit per notebook

[ ] push to remote git repo (github) (can be done manually at first): git push somerepo

[ ] store graphs/tables in ipynb readable format

graphs: svg->png
tables

@andypetrella
comments welcome :)

looks nice!
is it only for checkpointing?
because I was considering as well putting an abstraction in the notebook manager to allow loading and saving from several sources, this would be complimentary I guess?

is it only for checkpointing?

if we integrated git, github would be a natural choice :)

if it's public yes, but it needs to be pluggable...

if it's public yes, but it needs to be pluggable...

I see no problem with private repos either, it's just a matter of adding a public/private-key or smf like that.

yup,  I meant bit bucket or other internal git.  but support of bare git is probably what you meant, not just github?
Also there is also s3 or swift or simply local folder I guess

but support of bare git is probably what you meant, not just github?

exactly.

I'm up for that, we can suppose that git is installed and available everywhere, now we'll need to git init.
I'd love to see if we can come up directly with both support of local filesystem and git, let's see how it'll go

sbt-release

@shijinkui what do you mean exaclty? I'm not quite sure actually if you propose us to use sbt release for the notebooks or for the spark-notebook project :-D

@andypetrella using sbt-release to auto increase version number is more convenienced :)


isDragActive and isDragReject don't work correctly in example

I just started diving into Vue 3 and dropzone for the first time, so forgive me if I'm missing something. I am able to pull this project down and run the example successfully. The examples are using the local project and not the bundled package.
However, when I create a basic Vue 3 instance with vue3-dropzone v0.0.5 or v0.0.6, isDragActive and isDragReject do not work inside of the v-if statements.
Steps to reproduce:

Clone https://github.com/boggsey/vue3-dropzone-test
yarn install & yarn serve
Attempt to drag a .jpg file on to the input
Observe that the v-if for isDragActive does not fire

Minimal repro can be found here: https://github.com/boggsey/vue3-dropzone-test

It seems that I did not publish the build files to npm registry correctly.
I have fixed it. Please update to version 0.0.7.
Thanks 😄

Thank you! It does seem to be working correctly, however, isDragReject is always true even if the file type is correct. I have updated the existing repo to 0.0.7. This might be a separate issue as it seems to be behaving that way in the example, as well.


Remove outside padding

Remove the outside padding from a menu so that it lines up properly with other elements on the page.

Looks good! Added test case for this as well


[Settings] Lost window focus after toggling checkbox

Microsoft PowerToys version
0.49.1
Running as admin

[X] Yes

Area(s) with issue?
Settings, Video Conference Mute
Steps to reproduce

Toggle the option Hide toolbar when both camera and microphone are unmuted in VCM's setting.

The window lost focus.

✔ Expected Behavior
The setting window stays focused.
❌ Actual Behavior
Setting window lose focus.
Other Software

cc: @niels9001

Is this still an issue? Can we reproduce? (I can't)

I'll test this tonight.

Seems resolved. Cannot reproduce this on the latest build from main.


⚠ Bofrost.lu has degraded performance

In e494587, Bofrost.lu (https://www.bofrost.lu) experienced degraded performance:

HTTP code: 200
Response time: 1754 ms

Resolved: Bofrost.lu performance has improved in 15487f7 after 6 minutes.


Fix CSP restrictions

closes #13

I just move the CDN assets into inside the project to avoid loading them from a cross origin urls, the icons should now be displayed correctly

 Here is an overview of what got changed by this pull request:

Issues
======
- Added 43

Complexity increasing per file
==============================
- yasa-ui/src/style/iconfont/iconfont.js  8

See the complete overview on Codacy

Generated files will be ignored next time in Codacy

@chatman thanks for verifying 😄


Corrected 4x4 binning for v1 camera to 2x2

Datasheet lists only 2x2 binning, see here: http://cdn.sparkfun.com/datasheets/Dev/RaspberryPi/ov5647_full.pdf

It's 2x2 binning and then 2x2 skipping. Overall the resolution is reduced by 4x4.

Ok, but then the column heading is still misleading.

Feel free to suggest something better, but understand that writing the documentation is a balance between keeping things reasonably simple and being accurate. In other words, I consider the current state acceptable (it specifies the resolution reduction correctly which is all the majority of users care about, because that's what affects the FoV, without leading to follow-up questions like "which are binned and which are skipped?", "does that change with flips?", etc.). That said, if you feel something else would be better (e.g. another callout beneath the table clarifying the meaning of 4x4 binning, or another column in the table specifying skipping), do feel free to update the PR and I'll take a look.

I actually prefer being both simple and accurate at the same time :). Lets put an asterisk (or other sign) as a note to those "4x4"s and explain the truth below. Do you agree with this? If so, I will make the change.

Sure, that sounds fine. Just in case you're not familiar with it: you can edit this PR just by making another commit (don't worry about multiple commits - I can squash them on merge).


When I run the preview option of the PowerToys app, the screen does not close with the Alt + F4 keyboard key.

Microsoft PowerToys version
0.80.1
Installation method
PowerToys auto-update
Running as admin
Yes
Area(s) with issue?
File Explorer: Preview Pane
Steps to reproduce

On the file, I push the key "CTRL+Space"
then there will be preview pane,

and If I push the key CTRL+F4, then It is not works

Always top (Pin) is not works on Windows 10 Pro 22H2 19045.4291

✔ Expected Behavior

Close previe pane
Always on top the screen

❌ Actual Behavior

not close
not pinned

Other Software
No response

/dup https://github.com/microsoft/PowerToys/issues/28715


build/gulpfile.editor.js is not searched in our repository

search for editor-esm-bundle
observe the matches in build/gulpfile.editor.js are not found.
I don't think this file should be excluded based on the settings:

	"search.exclude": {
		"**/node_modules": true,
		"**/bower_components": true,
		".build/**": true,
		"out/**": true,
		"out-build/**": true,
		"out-vscode/**": true,
		"i18n/**": true,
		"extensions/**/out/**": true,
		"test/smoke/out/**": true,
		"test/automation/out/**": true,
		"test/integration/browser/out/**": true,
		"src/vs/base/test/node/uri.test.data.txt": true,
		"src/vs/workbench/test/browser/api/extHostDocumentData.test.perf-data.ts": true,
		"src/vs/server": false
	},

It's in build/.gitignore since 2 days ago @joaomoreno

wtf

Interestingly, when I touch the file it appears as modified, so I guess it is not .gitignored ?

It's a file that's checked in to git, but in gitignore, this is a valid thing to do for git. But ripgrep only knows about the .gitignore file. I would agree that this is a little unexpected for users but I don't think it's practical for rg to query git during a search.

I've tried to tackle this by having as a goal to put all .ts files and only .ts files in build/lib:

converted all .js files from build/lib to .ts.
moved more of the .ts files to build/lib

There are still 2 folders left:

azure-pipelines
darwin

Since darwin contains only .ts files and azure-pipelines also almost exclusively .ts files, the final ToDo here is to convert build/azure-pipelines/mixin.js and build/azure-pipelines/upload-sourcemaps.js to TS. That would make the .gitignore align with the reality of the repository and would make search 100% reliant again.
I've converted a bunch of files, and will take a break now.

Thanks once again @alexdima! Did the final steps: https://github.com/microsoft/vscode/commit/212fc3d6cd8ff9a1e98a8162b23859bcb3ed7ad6


Working with Deephaven Tables > Table Types

Expanding on and developing the current table types guide more fully would be useful.
Some considerations:

Cover ring, blink, and append-only - definitions
Then, how to create them from existing ticking tables.

It would help to clarify that time tables can be any of these types, depending on how they are created.
Any guide on creating ticking tables (whether from scratch, replayer, kafka, etc) would link out to this guide.
Since this guide can cover creating ring tables, possibly the individual guide can go away.

A guide discussing table types to support the larger section on ingesting live data.


Add 'nautobot-server shell' and deprecate 'nbshell'

Closes: #951
What's Changed

Add nautobot-server shell command as a wrapper of django-extensions shell_plus management command

To match some previous functionality of nbshell, I added a little bit of code that prints the Django version, the Nautobot version, and the version of all installed Nautobot apps.

To ease the transition, I've made nbshell an alias of shell rather than removing it entirely

Running nbshell prints a warning that it is deprecated and shell should be used instead.

Updated all docs and code comments referencing nbshell.

TODO

[x] Explanation of Change(s)
[x] Added change log fragment(s) (for more information see the documentation)
[x] Attached Screenshots, Payload Example
n/a Unit, Integration Tests
[x] Documentation Updates (when adding/changing features)
n/a Example Plugin Updates (when adding/changing features)
[x] Outline Remaining Work, Constraints from Design

It looks like docker-entrypoint.sh needs to be updated too?
nautobot-nautobot-1       | System check identified 7 issues (0 silenced).
nautobot-nautobot-1       | usage: nautobot-server shell
nautobot-nautobot-1       |        [-h]
nautobot-nautobot-1       |        [--bpython | --idle | --ipython | --lab | --kernel | --notebook | --plain | --ptipython | --ptpython]
nautobot-nautobot-1       |        [--connection-file CONNECTION_FILE]
nautobot-nautobot-1       |        [--no-startup]
nautobot-nautobot-1       |        [--use-pythonrc]
nautobot-nautobot-1       |        [--print-sql]
nautobot-nautobot-1       |        [--truncate-sql TRUNCATE_SQL]
nautobot-nautobot-1       |        [--print-sql-location]
nautobot-nautobot-1       |        [--dont-load DONT_LOAD]
nautobot-nautobot-1       |        [--quiet-load]
nautobot-nautobot-1       |        [--vi]
nautobot-nautobot-1       |        [--no-browser]
nautobot-nautobot-1       |        [-c COMMAND]
nautobot-nautobot-1       |        [--version]
nautobot-nautobot-1       |        [-v {0,1,2,3}]
nautobot-nautobot-1       |        [--settings SETTINGS]
nautobot-nautobot-1       |        [--pythonpath PYTHONPATH]
nautobot-nautobot-1       |        [--traceback]
nautobot-nautobot-1       |        [--no-color]
nautobot-nautobot-1       |        [--force-color]
nautobot-nautobot-1       |        [--skip-checks]
nautobot-nautobot-1       | nautobot-server shell: error: unrecognized arguments: --interface python
nautobot-nautobot-1 exited with code 2


Return pan position.

When the view dragged, it is returning the current position.
UseCase:
Consider that the user is dragging the view, before releasing the drag if need to update content or UI based on position.

Added new optional param to floatingPanelDidMove.

Thanks for your PR! I have a question about the new API.
FloatingPanleBehavior has the following API to project a user's finger moment to a moved position.
 func shouldProjectMomentum(_ fpc: FloatingPanelController, for proposedTargetPosition: FloatingPanelPosition) -> Bool

By default, it returns false. But if it returns true, a panel position can jump a position, for example, tip -> full(half is skipped).
As a result, the movingPosition argument isn't always a position nearby a user's finger. Is it expected by you?

Yes, I am expecting the user's finger position.  So that I have added this movingPosition.

Ok, movingPosition isn't always a position of a user's finger so that the API can't work as you expect. Because FloatingPanel.targetPosition is able to consider the finger gesture's momentum as I mentioned.
For example, if a finger is nearby full position and the pan gesture has a high velocity to the bottom, FloatingPanel.targetPosition returns tip position so movingPosition is tip position.
Therefore I would like you to propose to add a new API returning a finger's nearby position in FloatingPanelController instead of adding a new argument of the floatingPanelDidMove  delegate method.
FloatingPanelController.nearbyPosition() -> FloatingPanelPosition

How about this plan?

Thanks for the nice explanation.
Yes, It's a nice pan. I think we can implement nearbyPosition :)

Thank you for your understanding and support! So now we can just add a new API in FloatingPanelController as below.
    public var nearbyPosition: FloatingPanelPosition {
        let currentY = surfaceView.frame.minY
        return floatingPanel.targetPosition(from: currentY, with: .zero)
    }

Could you please try this API and update this PR if it's work well?

I closed it by merging #303


new lexer request: zsh

(Original issue 1128 created by anntzer on 2015-07-17T21:31:11.546453+00:00)
zsh's builtins set is a bit different from bash's, e.g. setopt is (correctfully) not listed as a builtin by BashLexer (which currently also handles zsh files) but a separate ZshLexer would be nice to cover the differences.

(Original issue was assigned to tshatch)

(Original comment by tshatch on 2015-10-17T02:17:13.457416+00:00)
Issue #1107 was marked as a duplicate of this issue.

(Original comment by tshatch on 2015-10-17T02:18:00.901223+00:00)
Do you happen to have a doc link that lists the builtins?

(Original comment by zmwangx on 2015-10-17T02:23:25.171427+00:00)
http://zsh.sourceforge.net/Doc/Release/Shell-Builtin-Commands.html

(Original comment by zmwangx on 2015-10-17T02:25:08.365748+00:00)
Actually there are more, scattered around the docs. For instance, there are a few in http://zsh.sourceforge.net/Doc/Release/Zsh-Line-Editor.html#Zle-Builtins, and a few in http://zsh.sourceforge.net/Doc/Release/Completion-System.html.

(Original comment by zmwangx on 2015-10-17T02:26:42.458876+00:00)
There's also a function index that might help: http://zsh.sourceforge.net/Doc/Release/Functions-Index.html. But some are contribs, not builtins.


Upload time and favorite count are wrong

Most galleries are showing outdated/wrong upload times and favorite counts.

Update: This is also the case with a lot of the tags, artists, parodies etc. In the Manage Tags tab, some tags are either with outdated number counts, or are not even present, an example is the artist "Oltlo", whose artist name is not even shown there.

For the Manage Tags have you modified the minimum count setting? The default is 25 while Oltlo has 13, if a tag is not present it is automatically added there.
The upload date is correct while the favorite and the tags count are wrong because I take them not from the HTML but from the JSON you can found viewing the source of the gallery (at the end). For example this is the JSON of 177013: Pastebin, and there you can find that the wrong favorite count and wrong count for the tags.
Since these numbers are have only esthetic purpose I don't think I will migrate to HTML (Even because it would only solve the favorite count while the tags can still have wrong values)

Oh thanks for responding, I really didn't even know about the mimimum count thing, sorry about that, but yeah thanks for explaining it along with a reasonable reason for why it works like that
I'll post a report of some minor glitchesI found while messing around with the app some time soon, so be around for that.


Create tests for glib/src/translate.rs

It would be good to have tests for the different translations from/to C in translate.rs, especially the container and pointer translations.
This would be a good newcomer task. I'd start by writing tests for String <-> gchar*, then GList (containing strings) by creating one in unsafe code via the C API and checking if the translations give proper results in either direction.

are there still not any tests implemented? Maybe if so i could try to write something up.

Please go ahead :)

Okay then, lemme get a draft PR and we can discuss stuff there. But before i can make any changes, i have a few questions:

I see a folder called glib/tests, would we make a new file there called something like glib/tests/translate.rs? I'm imagining we could probably write them with about the same format as the tests that are already written there. In any case we want them elsewhere, just tell me before i commit anything.

As you said, the first test should be regarding String <-> gchar*, and we'll keep on building from there, Should we merge the tests as we write them, or just do a single merge once everything's done?

I'm opening a draft PR as to keep on iterating on the idea, i'm a college student and i've been fairly busy. Most of what i've done regarding this are just first drafts, very naive implementations that will probably get changed, so i guess we could start working on this over at the draft. I got a branch set up to keep developing. For now i'm setting stuff up, i'll keep reading on stuff to try and make a worthwhile contribution.


/courses/update-account page

Allows a user to update their account based on their current role of:
individual, student, or teacher

Reviewed 👍


ML 1.2 : PDFs and CDFs (A)

Welcome to 'ML' Team, good to see you here
This issue will helps readers in acquiring all the knowledge that one needs to know about PDFs and CDFs.
To get assigned to this issue, add your Batch Numbers mentioned in the spreadsheet of "Machine Learning", the approach one would follow and choice you prefer (Documentation, Audio, Video). You can go with all three or any number of options you're interested to work on.
Domain : Machine Learning
Points to Note :

The issues will be assigned on a first come first serve basis, 1 Issue == 1 PR.

"Issue Title" and "PR Title should be the same. Include issue number along with it.

Changes should be made inside the Machine Learning/Machine_Learning/Statistics_for_Machine_Learning Branch.

Follow Contributing Guidelines & Code of Conduct before start Contributing.

This issue is only for 'GWOC' contributors of 'Machine Learning' domain.

To be Mentioned while taking the issue :

Full name
Batch Number
GitHub Profile Link
Which type of Contribution you want to make :

[ ] Audio

All the best. Enjoy your open source journey ahead. 😎

I would like to work on this issue.
Name: Nazhath Nafizza N
Batch : 1
GitHub profile: https://github.com/Nafizza
Type of contribution: Documentation

Mohit Mishra
ML-Batch-1
Profile_Link:- https://github.com/mohitmishra786
I want to contribute through documentation

@mohitmishra786 At one time, you can work on only one issue.

Name: Tisha Jhabak
ML-batch-6
Profile link -https://github.com/TishaJhabak1014
Assign me for this. Via Audio. Thank you.

@TishaJhabak1014 You've been assigned this issue. Kindly note that you need to complete the work and make a PR within 3 days. Happy Contributing! 😄


Gotools etc. update, remove goimports

Motivation for this change
goimports is severely outdated and the tool itself is included in gotools, hence I removed it and added an alias for backwards compatibility.
Some updates included.
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[x] Fits CONTRIBUTING.md.

@Mic92


Clicking on SDJS logo doesn't work

Describe the bug
Clicking on the SDJS logo on any page doesn't do anything.
To Reproduce
Steps to reproduce the behavior:

Go to any page
Click on SDJS logo in the top left corner
Nothing happens

Expected behavior
Should redirect to the home page.
Screenshots
If applicable, add screenshots to help explain your problem.

take a screenshot

Mac: shift + command + 3
Windows: use desired screenshot program

drag & drop screenshot image here:

System Info (please complete the following information):

Device: [e.g. Macbook Pro, iPhone6]
OS: [e.g. iOS, Android]
Browser: [e.g. chrome, firefox]
Version: [e.g. 22]

Additional context
Add any other context about the problem here.

this issue is resolved with pull request #142

These issues are now resolved. Thank you for your contribution to SDJS.


Move both X and Y Axis Tick-Mark Labeling to Outside of Graph

Per http://code.shutterstock.com/rickshaw/tutorial/introduction.html with the Y-Axis Too section, we should move the axis labeling to outside of the graph.  This will prevent series from being rendered over both the tick mark values.
var y_axis = new Rickshaw.Graph.Axis.Y( {
        graph: graph,
        orientation: 'left',
        tickFormat: Rickshaw.Fixtures.Number.formatKMBT,
        element: document.getElementById('y_axis'),
} );

Note the external element definition.

So, I started looking at this, but..it seems like this might already be finished?
Looks like a yaxis element is defined: https://github.com/prometheus/prometheus/blob/master/web/ui/static/js/graph.js#L551-L554
Then referenced:
https://github.com/prometheus/prometheus/blob/master/web/ui/static/js/graph.js#L109
Then looks like the y axis utilizes this:
https://github.com/prometheus/prometheus/blob/master/web/ui/static/js/graph.js#L621-L626
specifically L625.
I think x-axis is fine as is, or am I mistaken?
Disclaimer: I'm not super versed in JS, so pardon any bold claims :)
@Gouthamve  Tagged you since you were the last person to touch this.

Four year old issue, no one has complained about this. Let's just close @juliusv?

Yeah, I think so too. Closing.


Fix build with resource limit which system not support.

If docker build with resource limit which is not support by kernel,
the build will failed.
Reproduce:
on a WARNING: No swap limit support machine
$ docker build --memory-swap 1000M --memory=800M -t test:v1 .
Sending build context to Docker daemon 2.048 kB
Step 0 : FROM busybox
 ---> 4986bf8c1536
Step 1 : ENV test test1
 ---> Running in 1d3f4bc3ee96
 ---> 8e0046f66b00
Removing intermediate container 1d3f4bc3ee96
Step 2 : RUN echo "Hello world"
 ---> Running in 51c4a7776f78
[8] System error: open /sys/fs/cgroup/memory/docker/51c4a7776f78ca9b5abd86f8c6a8ed7616a6c86b30da48cc2e78e237e70902f9/memory.memsw.limit_in_bytes: permission denied
This will failed without any warning.
The second commit is to remove the redundant ip_forward check, because https://github.com/docker/docker/blob/master/daemon/daemon_unix.go#L185 has done that.
ping @duglin  @tiborvass

ping @icecrime  @LK4D4  @cpuguy83

sorry needs rebase

@jfrazelle  @estesp  rebased

ping @jfrazelle @estesp  @duglin  @tiborvass

@coolljt0725 with your patch I get
$ ./bundles/1.8.0-dev/binary/docker build --memory-swap 1000M --memory=800M -t test:v1 .
Sending build context to Docker daemon 2.048 kB
Step 0 : FROM ubuntu
 ---> 63e3c10217b8
Step 1 : RUN echo "hello world"
You should always set the Memory limit when using Memoryswap limit, see usage.

which I don't think is the correct behavior.
I think you should also reset hostConfig.MemorySwap to -1 if memory cgroup isn't mounted in verifyPlatformContainerSettings after https://github.com/docker/docker/blob/master/daemon/daemon_unix.go#L145
This way the output is:
$ ./bundles/1.8.0-dev/binary/docker build --memory-swap 1000M --memory=800M -t test:v1 .
Sending build context to Docker daemon 2.048 kB
Step 0 : FROM ubuntu
 ---> 63e3c10217b8
Step 1 : RUN echo "hello world"
 ---> [Warning] Your kernel does not support memory limit capabilities. Limitation discarded.
 ---> Running in 041af469fae2
hello world
 ---> 75cb58237b93
Removing intermediate container 041af469fae2
Successfully built 75cb58237b93

So the image is built and the warning is printed

@runcom  It's a bug , I send separate PR #15369 to fix the master branch, since this PR need more disscussion

@coolljt0725 great, thanks!

@coolljt0725 could you also please rebase :(

@runcom  @jfrazelle rebased.

@coolljt0725 Have you looked at making the builder use the daemon.ContainerCreate API instead of directly going to daemon.Create?
This piece of the code with the adapt and verify has had a bit of churn and I'm reluctant to change again here.

@cpuguy83  Actually, use the daemon.ContainerCreate API is the first way I thought of to fix this, but I found that the daemon.Container return a container ID but not a container which is what we want in builder.  And daemon.Create return a container.

@coolljt0725 Do you think we could modify ContainerCreate to return an actual container object and adjust the api/server side accordingly?

@cpuguy83  I'm ok with this way, but I think changing a API interface need more discussion. I'll update the PR with this way.

@cpuguy83  updated.

Sweet, LGTM

ping @jfrazelle @estesp

ping @calavera  @jfrazelle  @duglin  PTAL

LGTM


az costmanagement query does not support paging

Describe the bug
Executing a query using az costmanagement query returns at most 1000 rows
To Reproduce
Perform a query that would return more than 1000 rows (long period of time or have many resources) -> Only 1000 rows are fetched.
Expected behavior
All rows, or an option to paginate.
Environment summary
Latest Docker Image

Routing to service team.

@mrlepat, could you please help take a look?

Hello @twitek, @jsntcy
Query API does return a nextLink as part of the properties object.
It is not fully supported in our az bundle yet. To unblock, you can grab the nextLink from the response and call the api directly.

@mrlepat Thanks a lot for getting back to us!
Yes, that is what we are doing right now (via az rest), it was just unexpected & silent, so I though I'd raise it for awareness.
We were just wondering about the big difference in costs in our scripts vs. the Azure Cost Explorer, and it took us a while to figure that one out :)

my pleasure @twitek! this is great feedback... I will work with my team to update the documents and fix the az sdk.


Better support for accompanying persons

Based on feedback from Science Gateway event coordinators

Support for scanning QR codes for accompanying persons
When scanning a QR code for accompanying persons show their name rather than main participant name
Show accompanying persons in the list of all participants (probably nested in some way)
Make it possible to check in accompanying persons individually and independently from the main participant

I suggest implementing the part on the Indico side first since that goes into tickets (so the earlier this is available the better, since tickets generated between the 3.3 deployment and adding this extra data would not work for accompanying person checkins), and would be useful to have even before any support is present in the checkin app.

Show accompanying persons in the list of all participants (probably nested in some way)

Note to myself, since we currently do not include registration data when fetching the list of registrations, we have no way to show the accompanying persons in the list. The data needed to do that is only loaded when the user navigates to a specific registration.
One solution would be to return the accompanying persons when fetching the list of registrations (while skipping other registration data)


Creating type register, delete type related functions

Basically it is not an issue, but I don't find the solution, I read about a lot and ask it many times on SO.
What version of Go are you using (go version)?
go1.7 linux/amd64
What operating system and processor architecture are you using (go env)?
GOARCH="amd64"
GOBIN=""
GOEXE=""
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GOOS="linux"
GOPATH="/home/loow/gopath"
GORACE=""
GOROOT="/usr/lib/golang"
GOTOOLDIR="/usr/lib/golang/pkg/tool/linux_amd64"
CC="gcc"
GOGCCFLAGS="-fPIC -m64 -pthread -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build217134262=/tmp/go-build -gno-record-gcc-switches"
CXX="g++"
CGO_ENABLED="1"
The core idea
Creating a Database Manager which is getting a json request which is contain sql related data for example the basic json looks like: {"method": "first", "table": "users"}. The method mean getting the first row from table. There is many of tables, all of them a struct which is represent the table. The database ORM is the gorm so this json is looks like after I connect to the database something like: db.First(&user) where the db is a *gorm.DB and the user is an instance of the Users struct. The core question how I get an instance of the struct where I only have a table name?
First solution
First solution which is working, but there is a problem what I detail after. So there is many of struct where a struct look like:
type Users struct {
	ID uint
	Name string
	Email string
	Token string
}
func (u *Users) TableName() string {
	return "users"
}

So there is fields and a method which is return the table name. There is a map which stores the table names and return back a pointer instance of the given struct.
var Models = map[string]interface{}{
	"users":   new(Users),
	"categories": new(Categories),
}

The Operation struct have one field, the *gorm.DB and many of functions for example, the first:
func (o Operation) First(model string) string {
	modelStruct := Models[model]
	o.DB.First(modelStruct)
	response, _ := json.Marshal(modelStruct)
	clear(modelStruct)
	return string(response)
}

This function is just doing the database call and return it as a json after clear the pointer.
func clear(v interface{}) {
	p := reflect.ValueOf(v).Elem()
	p.Set(reflect.Zero(p.Type()))
}

This is working but when I want to call the First in concurrancy the clear not working instead of got a panic of nil pointer. If I don't clear the gorm take an extra where because thinking it is an old request.
Second solution
It is not working, but I need something similar. I have a type register.
var typeRegistry = make(map[string]reflect.Type)

func init() {
	typeRegistry["users"] = reflect.TypeOf(Users{})
}

When I get it I want to use the reflect.New function.
var modelStruct = reflect.New(typeRegistry[model]).Elem()

But this is return a reflect.Value, It would be great, but in this case the functions which is related to the struct will disappear. So the gorm return back an error, there isn't function TableName.
Real question
I know the Go is a static language, but how can I handle these types, for always creating the proper instance of the struct?

Hi,
the Go project does not use its bug tracker for general discussion or asking questions. The Github bug tracker is only used for tracking bugs and proposals going through the Proposal Process.

ask it many times on SO

Please see the Questions wiki page; it has a list of good places for asking questions. If the question wasn't answered on stackoverflow, please try on one of the other go forum on the web, thanks. It's likely that nobody will answer your question here on the issue tracker, because as I wrote we only use it for issues.
Closing, since this is not a bug.


[184430109158DF0F00] [<IP_ADDRESS>] [557.932] [system] [critical] Fatal error. Please report to developers. Log: 'PlgSrcCtrl' '87'

I am running OAKD-POE inside a docker container. The app has been running smoothly for weeks but recently it started giving this error here:
camera       | [184430109158DF0F00] [<IP_ADDRESS>] [557.932] [system] [critical] Fatal error. Please report to developers. Log: 'PlgSrcCtrl' '87'
camera       | [2022-08-04 20:33:48.236] [warning] Monitor thread (device:<PHONE_NUMBER>58DF0F00 [<IP_ADDRESS>]) - ping was missed, closing the device connection
camera       | Traceback (most recent call last):
camera       |   File "/computer-vision/training/record.py", line 70, in <module>
camera       |     run_recorder()
camera       |   File "/computer-vision/training/record.py", line 54, in run_recorder
camera       |     inRgb = qRgb.get()
camera       | RuntimeError: Communication exception - possible device error/misconfiguration. Original message 'Couldn't read data from stream: 'rgb' (X_LINK_ERROR)'

Furthermore, specifying the IP of the camera using: device_info = dai.DeviceInfo(ip) is returning "no device with such info" however, when I run it to auto find the device on the network, the finds the device and when I print the device info, it shows the same IP address.
Further Details:

I am pulling the luxonis/depthai-library docker image like this:

FROM luxonis/depthai-library

COPY requirements.txt requirements.txt
RUN pip3 install -r requirements.txt

ADD . /computer-vision

WORKDIR /computer-vision

ENV PYTHONPATH "${PYTHONPATH}:/computer-vision"

and then running the container using docker-compose:
version: '2.4'
services:
  cv-camera:
    container_name: camera
    build:
      context: ./
      dockerfile: docker/Dockerfile.training

    privileged: true
    device_cgroup_rules:
      - 'c 189:* rmw'
    volumes:
        - '/dev/bus/usb:/dev/bus/usb'
        - '/tmp/.X11-unix:/tmp/.X11-unix'
    environment:
        - DISPLAY=$DISPLAY

    command: python3 training/record.py

    network_mode: host

    restart: unless-stopped

The docker-compose basically starts up the container and runs the script python3 record.py which creates the pipeline, gets rgb data and encodes in into .h256 much like the ColorCamera.
#!/usr/bin/env python3
from distutils.command.upload import upload
import depthai as dai
import json
from datetime import date, datetime
from camera.pipeline import Pipeline
from camera.controls import Controls
from uploader import Uploader

DEFAULT_EXP_TIME = 20000
DEFAULT_SENS_ISO = 800
DEFAULT_FOCUS = 150
DEFAULT_BRIGHTNESS = 0
DEFAULT_LENGTH = 10

# Connect to device and start pipeline
pipe = Pipeline()
uploader = Uploader()

with open('config.json') as f:
    config = json.load(f)

autoFocus = config.get("autoFocus", "Fasle") in ["true", "True"]
brightness = int(config.get('brightness', DEFAULT_BRIGHTNESS))
expTime = int(config.get('expTime', DEFAULT_EXP_TIME))
sensIso = int(config.get('sensIso', DEFAULT_SENS_ISO))
focus = int(config.get('focus', DEFAULT_FOCUS))
vidLength = float(config.get("vidLength", DEFAULT_LENGTH))
autoFind = config.get("autoFind", "Fasle") in ["true", "True"]
poe = config.get("POE", "Fasle") in ["true", "True"]
ip = config.get("cameraIp", None)

def run_recorder(device):
    print("Starting Camera...", flush=True)

    # Get queues
    qRgb = device.getOutputQueue(name="rgb", maxSize=4, blocking=False)
    controlQueue = device.getInputQueue('control')
    camControl = Controls(controlQueue=controlQueue)
    video = device.getOutputQueue(name="h265", maxSize=30, blocking=False)

    if not autoFocus:
        camControl.set_brightness(brightness)
        camControl.set_exposure(expTime=expTime, sensIso=sensIso)
        camControl.set_focus(focus)

    while True:
        t1 = datetime.now()

        with open('video.h265', 'wb') as videoFile:
            print("Press Ctrl+C to stop encoding...", flush=True)
            try:
                while True:
                    inRgb = qRgb.get()
                    h265Packet = video.get()  # Blocking call, will wait until a new data has arrived
                    h265Packet.getData().tofile(videoFile)  # Appends the packet data to the opened file

                    if (datetime.now() - t1).seconds >= 60 * vidLength:
                        break
            except KeyboardInterrupt:
                # Keyboard interrupt (Ctrl + C) detected
                break
        uploader.upload_file()
    uploader.upload_file()
    #ffmpeg -framerate 30 -i video.h265 -c copy video.mp4"

if autoFind or not poe:
    with dai.Device(pipe.create_pipeline()) as device:
      #  print(device.getDeviceInfo(), flush=True)
        run_recorder(device)

else:
    device_info = dai.DeviceInfo(ip)
    with dai.Device(pipe.create_pipeline(), device_info) as device:
        print(device.getDeviceInfo(), flush=True)
        run_recorder(device)

@BBwanaz
Do you mind checking the version of base image you are using?
It seems like an older version is being used in this case. Try using either: v2.17.1 or v2.17.2

Hi @themarpe
both versions and I still get the same error.

Sorry about the trouble @BBwanaz .  We'll likely need to dig into firmware to see how/why this is happening and what it will take to fix this.

@BBwanaz
The latest v2.17.3 should address the issues when connecting with specific IP.

The app has been running smoothly for weeks but recently it started giving this error here
One question on the issue -


Add missing impl tag for openj9 specific tests

Fixes: https://github.com/AdoptOpenJDK/openjdk-systemtest/issues/231
Signed-off-by<EMAIL_ADDRESS><EMAIL_ADDRESS>

@Mesbah-Alam are those tests limited to jdk10 and down? Looks like there are a few other type tests which are also limited to jdk10 and down.

There is a note on them as disabled in jdk11 with systemtest issue linked.


Slowdown with v2

Hi!
I just upgraded from latest v1 to latest v2 of @splunk/otel and our Node server now takes 5-10 seconds to start. Haven't looked deeply into what takes time but this is my code:
import { start } from '@splunk/otel';
start({
  serviceName: 'my-service',
});

If I remove the call to start() the server starts quickly again. Any idea what could cause it? Anything I can do? I have these packages installed as well:
@opentelemetry/instrumentation-express: 0.31.2
@opentelemetry/instrumentation-http: 0.34.0
@opentelemetry/instrumentation-redis: 0.33.0

Hi, what's the exact version you're using - 2.1.0?
In 2.0.0 we made the change to bundle instrumentations and in a release candidate version we were using a version of OTel that had a known proble related to startup times.
However the latest version of Splunk OTel should be using the fixed OTel versions.

And a small side note: with v2 it is no longer necessary to install instrumentation packages yourself, unless of course you want to use something not in the default instrumentations list.

Ah, then that's perhaps the issue. I have a colleague who reported the same slowdown but he instead uninstalled the explicit otel packages and said that it fixed the issue. So I'll uninstall them and see if that works for me as well. Thanks for the quick reply!

Looks like the @opentelemetry packages are peer dependencies, which means I still need to install the ones I want?

The OpenTelemetry instrumentation packages don't need to be installed one by one any longer. At the moment the only peer dependency is @opentelemetry/api: https://github.com/signalfx/splunk-otel-js/blob/main/package.json#L152
The API package is a peer dependency to avoid users installing old API packages alongside the instrumentations - which can cause detached spans in traces, but it is not mandatory to install it.

@andersekdahl Were the problems you had resolved?

Closing this as it should be resolved now with the newer @opentelemetry/instrumentation packages.


/lib folder not present on npm package

I installed the v1.0.0 to check if everything was good and when I tryed importing the SyslogServer class typescript returned the error Cannot find module 'ts-syslog' or its corresponding type declarations.ts(2307).
I look into the package folder on my node_modules and saw the /lib folder was not present, I just had the license.md, readme.md and package.json files.

The issue was fixed with the above commit


Change to use bow.state.Response.Request.URL in Url()

Prefer to use bow.state.Response.URL, because in case of redirects,
the current context depends on the final Request.
A concrete example would be something like OAuth flow, where you
access host A which delegates to host B to do the authorization
via a redirect. If you don't use the Response URL, then the next
Form object may resolve its URL in the context of host A, not B

This has been merged into dev, which I'll merge into master later today. Thanks for the contribution, and thank you for taking the time to write a test for your changes.


[Android] First frame is sometimes a solid color

Some video files loaded on Android show a frame of a solid color instead of the first frame of the video. It is easier to see by opening the video with play: false.
You have indicated this delay:
https://github.com/media-kit/media-kit/blob/5ea2c84b5c7b074a45b3887dc64a997f9a5e3172/media_kit_video/lib/src/video_controller/android_video_controller/real.dart#L146-L148
I played with it and increased it to 2000 ms but it does not solve the issue.
I've tried the paint_first_frame.dart page of the test app, and everything was fine with the default sources, showing the correct frame for each video. However, when I switched the sources to some local files on storage (not dynamically downloaded), I noticed the solid color frame issue. Easy to reproduce with both content://... URIs and regular paths like '/storage/emulated/0/Pictures/....
Interestingly, if we load the page again and again in the test app using local sources, sometimes some of the videos will load correctly, so it definitely points to a race condition. It just does not seem to be related to the delay mentioned above.

Hi! This has been fixed with the latest update, please refer to the "Installation" section in the README.


Update documentation and docker files

The libsodium link was moved for 1.0.18 and the docker files were using 1.0.16. This fixes both of those references to use 1.0.18 and the correct link.
Thanks to @burdettadam for finding the discrepancy

@danintel https://github.com/jedisct1/libsodium is the official github repo for libsodium, so it looks like we're not moving from a public archive to someone's personal repository, but rather moving from the official public archive to the official github repository.


[BugFix] retry on SHUTDOWN tablet occupied

What type of PR is this：

[x] bug
[ ] feature
[ ] enhancement
[ ] refactor
[ ] others

Which issues of this PR fixes ：

Fixes #8515
Problem Summary(Required) ：

Add retry logic to handle clone failure caused by SHUTDOWN tablet occupied
Treat NOT_FOUND on dest replica as a normal case

run all

[FE PR Coverage Check]
:heart_eyes: pass : 0 / 0 (0%)

run starrocks_be_unittest

run starrocks_admit_test