Support taking a shot that boxes multiple selectors

This is a bit of an unconventional need, but I think it's worth exploring.
When taking screenshots for tutorials, I often want to grab an area of the screen that incorporates more than one element - where there's no convenient wrapper element that I can use to get the shot that I want.
Imagine if you could specify multiple selectors and get back a screenshot of the smallest area of the screen that incorporates all of those elements.
The implement would look at the founding box of all of those elements, generate a new box that wraps all of those, inject an absolutely positioned box of that size and take the screenshot of that area.
It could even optionally add some padding to that box before taking the shot.

Potential syntax:
shot-scraper $URL \
  --selector h1 --selector h2 --padding 10

So if you pass multiple selectors it creates a box around them.
In YAML could support a selectors list:
- url: ...
  selectors:
  - h1
  - h2
  padding: 10

Was just about to file this same request!

https://developer.mozilla.org/en-US/docs/Web/API/Element/getBoundingClientRect says:

If you need the bounding rectangle relative to the top-left corner of the document, just add the current scrolling position to the top and left properties (these can be obtained using window.scrollX and window.scrollY) to get a bounding rectangle which is independent from the current scrolling position.

Here are the bounding rectangles for two elements on a page:
{
   "x": 16,
   "y":<PHONE_NUMBER>0351562,
   "width": 799,
   "height": 30,
   "top":<PHONE_NUMBER>0351562,
   "right": 815,
   "bottom":<PHONE_NUMBER>0351562,
   "left": 16
}
{
   "x": 16,
   "y":<PHONE_NUMBER>0351562,
   "width": 799,
   "height":<PHONE_NUMBER>9414062,
   "top":<PHONE_NUMBER>0351562,
   "right": 815,
   "bottom":<PHONE_NUMBER>9765625,
   "left": 16
}

I think I need the min top and left and the max bottom and right.

OK, this function seems to work nicely:
function addBoundingBox(els, padding) {
    // Add an absolutely positioned bounding box that wraps all elements
    padding = padding || 0;
    let minTop = 100000000;
    let minLeft = 100000000;
    let maxBottom = 0;
    let maxRight = 0;
    els.forEach(el => {
        let rect = el.getBoundingClientRect();
        if (rect.top < minTop) {
            minTop = rect.top;
        }
        if (rect.left < minLeft) {
            minLeft = rect.left;
        }
        if (rect.bottom > maxBottom) {
            maxBottom = rect.bottom;
        }
        if (rect.right > maxRight) {
            maxRight = rect.right;
        }
    });
    console.log({minTop, minLeft, maxBottom, maxRight});
    // Adjust them based on scroll position
    let top = minTop + window.scrollY;
    let bottom = maxBottom + window.scrollY;
    let left = minLeft + window.scrollX;
    let right = maxRight + window.scrollX;
    // Apply padding
    top = top - padding;
    bottom = bottom + padding;
    left = left - padding;
    right = right + padding;
    var div = document.createElement('div');
    div.style.position = 'absolute';
    div.style.outline = '2px dashed red';
    div.style.top = top + 'px';
    div.style.left = left + 'px';
    div.style.width = (right - left) + 'px';
    div.style.height = (bottom - top) + 'px';

    document.body.appendChild(div);
}

On https://congress-legislators.datasettes.com/legislators/legislators?bio_gender__exact=F
addBoundingBox(document.querySelectorAll('form.filters,.suggested-facets'), 5)

Got it working:
shot-scraper https://simonwillison.net/ -s '#bighead' -o big.png -s .overband --padding 20


Add tags for users, fixed shared controllers, constraints

https://projects.engineering.redhat.com/projects/SSP/issues/SSP-60

@gmcculloug @syncrou
Please review


[WIP] fix: routing for new-style partner urls

The type of this PR is: Bugfix
This PR resolves CX-1932 and FX-3279
Description

New-style partner pages were launched a while ago
The url structure for these changed as well (to have more conventional URLs rather than relying on Force's old vanity profile url pattern)
The routing logic in Eigen was not updated accordingly

This PR adds the missing routing logic and handles all the currently supported partner URLs as inferred from Force's own redirection logic
PR Checklist (tick all before merging)

[ ] I have included screenshots or videos to illustrate my changes, or I have not changed anything that impacts the UI.
[ ] I have tested my changes on iOS and Android.
[ ] I have added tests for my changes, or my changes don't require testing, or I have included a link to a separate Jira ticket covering the tests.
[ ] I have added a feature flag, or my changes don't require a feature flag. (How do I add one?)
[ ] I have documented any follow-up work that this PR will require, or it does not require any.
[ ] I have added an app state migration, or my changes do not require one. (What are migrations?)
[ ] I have added a changelog entry below or my changes do not require one.

Changelog updates
Changelog updates

Cross-platform user-facing changes

iOS user-facing changes

Android user-facing changes

Dev changes

Warnings

:warning:

❌ An error occurred while validating your changelog, please make sure you provided a valid changelog.

  Generated by :no_entry_sign: dangerJS against 17fdcc31026f6f306c512bb23eb109b217987693

@brainbicycle I'll go ahead and merge this too so that it's in the next release


JPMS

Is there an easy way to use this plugin in a Java project leveraging JPMS?

Hi @apssouza22!
I create a PR.
Can you review all is correct?


Feature: Improved compatibility page of properties window

Summary

Improved the UI of the compatibility page
Refactored the ViewModel
Removed LocalizedEnumHelper class

PR Checklist

[ ] Were these changes approved in an issue or discussion with the project maintainers? In order to prevent extra work, feature requests and changes to the codebase must be approved before the pull request will be reviewed. This prevents extra work for the contributors and maintainers.
[x] Did you build the app and test your changes?
[x] Did you check for accessibility? You can use Accessibility Insights for this.
[x] Did you remove any strings from the en-us resource file?

[x] Did you search the solution to see if the string is still being used?

[ ] Did you implement any design changes to an existing feature?

[ ] Was this change approved?

[x] Are there any other steps that were used to validate these changes?

Launch the app
Open properties window of exe or shortcut item
Go to Compatibility page

Screenshots

Confirmed all actions work fine. Ready for review!

/format

XAML Formatter didn't worked even though I did Shift+S in this case.

Why is https://github.com/files-community/Files/labels/changes requested added?

We'd like the design changes to be separated from the code improvements, this way we can merge the code improvements while we discuss the design changes.

This doesn't have code improvements. I can re-create codebase improvements PR if you want.

Ready for review.


Add adapter for DeviceDetails

Description
This PR is eighth part of the set of PR's which will be raised for adding GPU support #1312
This PR adds adapter for DeviceDetails to serialize and deserialize the class
This PR is build on top of #1321, so it needs to be merged after merging #1321
Fixes #1312
Type of change

[ ] Bug fix
[ ] New feature
[ ] Docs update
[ ] Breaking change (What changes might users need to make in their application due to this PR?)
[ ] Requires DB changes

How has this been tested?
Tests will be added in the other PR

[ ] New Test X
[ ] Functional testsuite

Test Configuration

Kubernetes clusters tested on:

Checklist :dart:

[ ] Followed coding guidelines
[ ] Comments added
[ ] Dependent changes merged
[ ] Documentation updated
[ ] Tests added or updated

Additional information
None

Needs to be rebased against mvp_demo

Apologies for the overlook, I have rebased to mvp_demo. Thanks @dinogun


[v6] Add support for Route Groups

I believe having groups for route which are related e.g
/products
/product/:productID
/product:productID/delete
This would help with organising your list of routes and is already a common pattern in backend frameworks such as laravel. The usage would someone akin to this:
 import { Route, Switch, RouteGroup} from 'react-router-dom';
 <RouteGroup routePrefix="/products">
  <Route route="/">
	<ProductList />
  <Route>
  <Route route="product/:productID">
	<ProductDetail />
  <Route>
  <Route route="/:productID/delete">
	<ProductDelete />
  <Route>
 </RouteGroup>

Based on the routePrefix, the route children would have that prefix added to the url so the /product/:productID would become /products/product/:productID

You can already do this with nested routes in v6: https://github.com/ReactTraining/react-router/blob/v6.0.0-beta.0/docs/installation/getting-started.md#nested-routes


Add Rate Limiting Handling

Rate limits can change depending on the number of load balancers that are active. The API call responses includes header meta data related to these rate limits.
In the short term I would suggest adding these headers to the mangadex_api_schema::ApiData struct to allow user code to utilise this meta data.

Header
Description

X-RateLimit-Limit
Maximal number of requests this endpoint allows per its time period

X-RateLimit-Remaining
Remaining number of requests within your quota for the current time period

X-RateLimit-Retry-After
Timestamp of the end of the current time period, as UNIX timestamp

https://api.mangadex.org/docs/rate-limits/

Hello there!
Firstly, Thank you for posting this interesting issue.
Secondly, I apologize for not responding you sooner,
I have a lot of projects behind this and I didn't have the time on focusing on this issue.
Thirdly, Your proposition for adding rate limiting handling is interesting,
but adding field on mangadex_api_schema::ApiData would be technical challenge for me.
There is around 30 endpoints that respond with these headers, and each of them have a different response type.
I know that some of them respond with the : mangadex_api_schema::ApiData,
but for the GET /at-home/server/{id}, his response type is mangadex_api_schema::v5::AtHomeServer.
After re factoring all of the SDK for the new syntax, I come up with an idea that should be 'easy' to implement and noticeable in your development.
We added these struct :
/// This `RateLimit` struct contains all the data needed for rate limit handling
/// It can be parsed via a [`reqwest::Response`] or [`reqwest::header::HeaderMap`]
#[derive(Serialize, Debug)]
#[cfg_attr(feature = "non_exhaustive", non_exhaustive)]
pub struct RateLimit {
    /// value from `x-ratelimit-limit` header
    pub limit: u32,
    /// value from `x-ratelimit-remaining` header
    pub remaining: u32,
    /// value from `x-ratelimit-retry-after` header
    /// It's normally an [`i64`] [(Unix timestamp)](https://www.unixtimestamp.com/)
    /// but can be parsed as a [`crate::MangaDexDateTime`]
    pub retry_after: MangaDexDateTime,
}

/// This struct is used for rate limited endpoint
/// `rate_limit` is for the rate limit metadata
/// `body` is the response data
pub struct Limited<T> {
    pub rate_limit: RateLimit,
    pub body: T,
}

The RateLimit struct is for the rate limit metadata header.
And the Limited<T> is for handling the metadata.
I know that it might be a strange solution but it's the only one that i come up with.
You can lookup to this linked pull request #87  to see the work progess


Migrate to GitHub Actions

Travis CI has a new pricing model which places limits on open source.

https://blog.travis-ci.com/2020-11-02-travis-ci-new-billing
https://www.jeffgeerling.com/blog/2020/travis-cis-new-pricing-plan-threw-wrench-my-open-source-works

Many projects are moving to GitHub Actions instead, including Jazzband projects:

https://github.com/orgs/jazzband/projects/1
https://github.com/jazzband-roadies/help/issues/206

This is based on https://github.com/jazzband/contextlib2/pull/26.
TODO:

[x] @jezdez to add JAZZBAND_RELEASE_KEY to the repo secrets.

Thanks for the quick review, all! ❤

Worked flawlessly https://github.com/jazzband/django-model-utils/runs/1470115542


Table 5077 Segment Line - function FinishSegLineWizard

Hello,
Can you please add the following local function and an event publisher:
local procedure SetWizardStepWhenEmptyOportunityNo(var SegmentLine: Record "Segment Line")
    var
        IsHandled: Boolean;
    begin
        IsHandled := false;
        OnBeforeSetWizardStep(SegmentLine, IsHandled);
        if IsHandled then
            exit;

        if "Opportunity No." = '' then
            "Wizard Step" := "Wizard Step"::"6";
    end;

    [IntegrationEvent(false, false)]
    local procedure OnBeforeSetWizardStep(var SegmentLine: Record "Segment Line"; IsHandled: Boolean)
    begin
    end;

The local function will be called in this function:
procedure FinishSegLineWizard(IsFinish: Boolean)
    var
        InteractionLogEntry: Record "Interaction Log Entry";
        SegManagement: Codeunit SegManagement;
        Send: Boolean;
        Flag: Boolean;
        HTMLAttachment: Boolean;
        HTMLContentBodyText: Text;
        CustomLayoutCode: Code[20];
    begin
        OnBeforeFinishSegLineWizard(Rec, IsFinish);

        HTMLAttachment := IsHTMLAttachment;
        Flag := GetFinishInteractionFlag(IsFinish);

        if Flag then begin
            CheckStatus;

           // if "Opportunity No." = '' then --
                //"Wizard Step" := "Wizard Step"::"6"; --

          SetWizardStepWhenEmptyOportunityNo(var SegmentLine: Record "Segment Line") // add here

Thank you!

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.
Build ID: 47148.


Add thread count customization 🔥

Is your feature request related to a problem? Please describe. 🤔
It would be great to be able to change the amount of threads that the web server is running with, when, for example, using httpbeast. Running everything in 1 thread isn't ideal, as, for example, some database operations can take time, slowing down the whole site.
Describe the solution you'd like 💡
An additional optional argument could be added in serve() for setting the amount of threads that the web server will run on.

An additional optional argument could be added in serve() for setting the amount of threads that the web server will run on.

Maybe flag -d:beastThread=NUMBER is better solution?

Your issue can helpful for httpx also
https://github.com/ringabout/httpx/blob/master/src/httpx.nim#L156-L160

I'll add this flag to choose number of threads in next commit.


[VEN-2499]: Deployment of XVSVault on Arbitrum Sepolia

Description

Resolves #VEN-2499
This PR adds deployment of XVSVault on ArbitrumSepolia based on timestamp.
Deployed addresses:
XVSVaultProxy: 0xC431A15F5359CdF230c9Bd6b11B538bC2aE2C52B
XVSVaultImp: 0xde9b9f7F141AEec2640E4eB34761eB50D2aa1BFD
XVSStore: 0x3c49eB8FaDD3FdB0a4Bbb40F8A7e3ce821298607
Note1:-
The contract name for XVSVault is XVSVaultProxy_Implementation not XVSVault using this deployment script.
Also we need to refactor the deployment script here to change the contract name and also change the previously deployed files name to maintain consistency on other networks.
Note2:-
Need to update the package version for token-bridge and export XVS address from node modules.
Checklist

[ ] I have updated the documentation to account for the changes in the code.
[ ] If I added new functionality, I added tests covering it.
[ ] If I fixed a bug, I added a test preventing this bug from silently reappearing again.
[ ] My contribution follows Venus contribution guidelines.

We need to use the TimeManagerV5 from the solidity-utilities package. So, we should review and merge first https://github.com/VenusProtocol/solidity-utilities/pull/12, and then update this repo

We need to use the TimeManagerV5 from the solidity-utilities package. So, we should review and merge first VenusProtocol/solidity-utilities#12, and then update this repo
Added


Explain config to use primes as a system library

Display Cargo.toml file for primes crate
Explain what cdylib does
The reader may not have used the lib section in a crate's config.
This explains the basic info in the guide instead of having to look up documentation.
closes #37

I like the look of this. I've been lazy so far and not bothered to quote each Cargo.toml, but something like setting the crate-type key is a pretty important thing to do. If you don't have it set correctly then nothing will work.
I've generally assumed that if someone is wanting to do FFI between Rust and some other language that they should be familiar with C already and know roughly how to compile a C program by hand. FFI is a pretty advanced topic after all, so if want to do interop between Rust and other languages without knowing how compiling and binaries work, you are probably biting off more than you can chew...
Should those assumptions be mentioned towards the beginning of the introduction? I don't want to be scaring people off, but at the same time it's good to know things like what a linker is and how it works, what happens when your OS loads a binary into memory before executing, etc.

My vision of the guide is that someone just hearing about ffi, will be able to have a self-contained tutorial on the process.
#38 addresses making the primes crate, so that someone could get the example working straight way.  That way any unfamiliar parts can be looked over again to learn the process (change some stuff, make their own sample functions, etc).
Including some reading material could lessen the difficulty in learning.  (Hey, if you're unfamiliar with this subject, here's some material to look at.)


[Feature]: Configure the number of seconds to wait before deciding on an exit warning

🚀 Feature Proposal
Add a configurable exitDelay parameter and option to change the 1 second hard-coded default jest
For example: --exitDelay 3000 would cause Jest to wait 3 seconds instead of 1 before issuing a warning.
Motivation
I have tests that spin up a dozen express servers, communicate with a 100 sockets, and then unwind them all.
I'm certain that I'm correctly awaiting everything, and closing everything.   And if I wait long enough... they all shut down correctly.
However, jest expects stuff to exit quickly at the end of a test suite, and many socket libraries do not have an awaitable "close" function.
If I were to be able to change that 1 second to about 3 seconds, I'd never see that warning, and.. more importantly, I'd be able to verify and require it.
Example
jest --exitDelay 3000
Pitch
Because hard-coded things aren't nice to work with.   Sometimes people have slow machines.   Etc.

nevermind.   running with --detectOpenHandles actually fixes this issue.   It doesn't give a warning anymore (because there aren't any)

Did you look at the openHandlesTimeout config option? Isn’t it exactly what you wanted?
(It would be better to avoid --detectOpenHandles, because it has a performance penalty.)

openHandlesTimeout   works, yep.   was looking for "exit" stuff (because its in the message).  thanks!


wrapper.props() includes unset properties

Version
1.0.0-beta.28
Reproduction link
https://github.com/lusarz/vue-test-utils-examples/commit/15caf10869fcf6ffe5d04a9a2dbb2111ffc79a9e
Steps to reproduce

Create child component with two props
Pass one property to child component in template
Check wrapper.find(Child).props()

What is expected?
When property is not set in template, object returned by wrapper.props() method not include it (even as undefined)
What is actually happening?
Object returned by wrapper.props() contains not set prop.

Since the $props object contains props, even if they are undefined, we'll keep the existing behavior


Allow non fullscreen view for faster debugging

Maybe a little trick to skip the requirements for debugging only? E.g. pressing a key.

PR is merged.


Ability to pass refs to all form fields

React hook form requires a ref to be passed to the input

I think SearchBox, Select and TextArea need to be updated but all others are good

Although Select and TextArea seem to be compatible with react hook form already due to ref being passed in on {...input} so not sure why it's needed elsewhere... e.g. InputField

From what I can see, components that take an input prop and spread it to the input, don't need forwardRef as it can be done via the input prop.
I'll remove it for InputField, add it to SearchBox and not touch Select and TextArea


🐞 Bug : Responsiveness of Comments .

Is there an existing issue for this?

[X] I have searched the existing issues

Describe the bug
When long comments are present, the comment box overflows and disrupts the width of the website.
Video of Bug :
https://github.com/CircuitVerse/CircuitVerse/assets/77102885/4aaa9907-5764-4acb-8a70-9b56e194da61
Steps To Reproduce

Go to any project page and find comment section
write a comment with long words
Convert the website to small screen.
See the error that comment section is not responsive .

Expected Behavior
The comment box should be responsive.
Video of Solution:
https://github.com/CircuitVerse/CircuitVerse/assets/77102885/cdffebe3-1f69-4966-81bc-c812570c3c8b
Screenshots
No response
Device Information [optional]
- OS:
- Browser:
- version:

Additional context
No response
Are you working on this issue?
Yes

@shauryag2002 @vedant-jain03 @tanmoysrt please assign me this issue as a new contributer it will be helpul for me

The issue has been verified!

i am up for the work if nobody is there

Yes , you can @tanmoysrt

If you don't mind @shauryag2002 can I assign another one to this?

Yes @tanmoysrt ,You can.

Hi @parthksingh1 you can start working on this !

Hi @tanmoysrt is this issue still open? Can I work on this issue?

Hi @parthksingh1 any update ?

@parthksingh1 it's long time, and there is no update, so I am unassigning this issue

@lalitkumawat1m you have been assigned. You can start working on this issue

Please assign it to me i can work on this if possible

If no one else is working on this issue then could you please assign this issue to me? I would love to work on this.

@tanmoysrt , I'm highly interested to quickly work and fix this issue. Could you assign it to me if possible

@tanmoysrt @shauryag2002  as it been a while and the issue is yet to be solved can I get assign to it.

Hi @MaYaNkKashyap681 @Kashyap-Rishi, if you like to solve the issue please let us know, else will assign the next person.

Yes, sure I want to work on this.

@tanmoysrt  please assign me this issue i want to work on this issue as i begineer i will gain some knowledge and experience by contributing please assign me this issue

@tanmoysrt  I want to work on this issue

@tanmoysrt @shauryag2002 I would like to work on this issue can you please assign this issue to me .

Hello @tanmoysrt I would like to take up this issue, can you assign it to me.

Hey @tanmoysrt, I know the solution to this issue. Do you think I should move ahead?

Hi @PR4NJ41 , would you like to work on this issue ?


Implement booleanWithin

It's worth mentioning that the pipeline failed due to two analyzer errors. The errors are related to the recent Dart 3.3.0 release and also affect the main branch.


doc: scipy.stats.burr pdf issue

In doc, it is stated as
burr.pdf(x, c, d) = c * d * x**(-c-1) * (1+x**(-c))**(-d-1)

However, it has to be
burr.pdf(x, c, d) = c * d * x**(c-1) * (1+x**(c))**(-d-1)

check: https://en.wikipedia.org/wiki/Burr_distribution
I haven't check the code implementation, but only the doc. Therefore, we should revise code if wrongly implemented.

@JKNA  Thanks for looking into this.  There are actually several different "Burr distributions"; see http://onlinelibrary.wiley.com/doi/10.1002/0471667196.ess0189.pub2/abstract.  By inspection of the table in the link, it is apparent that scipy implements the Burr Type III distribution, and you are expecting the Type XII distribution.
The burr docstring should mention that it implements the Type III distribution, so I added the "Documentation" label to this issue.
We should also add the Type XII distribution to scipy.

@WarrenWeckesser Thanks for the remark and revision. Indeed it is Type III. I thought only the Type XII since it is familiar to me. (As far as I know, it is generally used.)

@WarrenWeckesser Thanks for the comment and correction. Indeed it is that scipy implements Type III. I expected Type XII since that's familar to me. (As far as I know, Type XII is the generally used one.)

I created a pull request to include a note about stats.burr being the Type III Burr distribution: https://github.com/scipy/scipy/pull/5588

...and I created an issue with a request for an implementation of the Type XII distribution: https://github.com/scipy/scipy/issues/5589


IonicPage segment: Allow multiple parameters

Ionic version:  (check one with "x")
[ ] 1.x
[ ] 2.x
[ x] 3.x
I'm submitting a ...  (check one with "x")
[ ] bug report
[ x] feature request
[ ] support request => Please do not submit support requests here, use one of these channels: https://forum.ionicframework.com/ or http://ionicworldwide.herokuapp.com/
Current behavior:
IonicPage is not working with multiple parameters after a slash, for example:
segment: 'place/:id-:name'
will not work
Expected behavior:
IonicPage should detect multiple parameters after a slash, starting with :
Use case would be better SEO and avoiding too much slashes in the URL. Example of URL:
mysite.com/place/5-Coffe
Steps to reproduce:
Irrelevant
Related code:
@IonicPage({
  segment: 'place/:id-:name'
})

Other information:

Ionic info: (run ionic info from a terminal/cmd prompt and paste output below):
Ionic 3.0.1

Hello! Thanks for the feature request. I'm going to move this issue over to our internal list of feature requests for evaluation. We are continually prioritizing all requests that we receive with outstanding issues. We are extremely grateful for your feedback, but it may not always be our next priority. I'll copy the issue back to this repository when we have begun implementation. Thanks!

This issue was moved to driftyco/ionic-feature-requests#186

The link is broken.  (https://github.com/ionic-team/ionic-feature-requests/issues/186)
Here is the solution:
https://forum.ionicframework.com/t/ionicpage-more-than-one-parameter/91996/6


fix(formatter): fix else indentation after comment between if-else

closes #2649
Added a few test cases with comments in between, including:

single-line comment with overindentation,
multi-line comment with underindentation,
single-line comment, from inline to multiline if-else

Updated get_post_context() with a better way to format else after comment. This is a bit of a hacky fix but since the post-context concept is currently only used for formatting else blocks after comment, I was thinking this might tide us through for now (and the test suite passes as well).
I wrote a long-form comment explaining what the new get_post_context() does there especially because fixing the off-by-one error with subtracting by 1 is going to look like a hacky solution (and it is, unfortunately)

So this doesn't actually fix the case where the comments themselves are unformatted. Example:
contract;

impl MyContract for Contract {
    fn is_blue() -> bool {
        if self == PrimaryColor::Blue {
            true
        }
        // TODO
            // remove this else when exhaustive ifs are checked for
    else {
            false
        }
    }
}"#;

I'd say this PR is still worth merging since it fixes the linked issue, and I guess misindented comment would be rarer than a misindented else block. I'll open a new issue for the above.


bug: connection string example is inconsistent with implementation

The document shows an example connection string:

s3://?credential=hmac:xxxx:xxxx&endpoint=http://s3.us-east-2.amazonaws.com

While the endpoint in it will not be parsed correctly by the s3 service.
The s3 service uses go-endpoint to parse the endpoint value, which defines endpoints as the form of http:s3.us-east-2.amazonaws.com, no // after the http:
I am using:

go-storage: v4.4.1
s3-service: v2.3.0

By the way, I'am happy to fix it, but not sure which solution is preferred:

make go-endpoint respect the // notation,
or update the doc

Oooops, our docs is incorrect.
We need to use http:s3.us-east-2.amazonaws.com here.
Can you send a PR to site to fix it? Thanks so much!

And the problem is so common that we are considering add support for :// too.

For your convenience: the docs located at https://github.com/beyondstorage/site/blob/master/docs/go-storage/operations/index.md

Fixed in https://github.com/beyondstorage/site/pull/192, thanks for report!


Publishing latest releases to NPM?

The latest version of this lib in npm is 0.1.20, but it looks like the latest in github is 0.1.25. Are 0.1.21 - 0.1.25 considered unstable or should they be published to npm?

The current version on the github master branch works fine for me. I'm using it on several projects. I'd love to publish it asap but I was pretty busy for those weeks. Wait for a moment, thanks!

That would be great :)

0.1.26 published


[BEAM-12941][Playground] Application CI/CD scripts

Add github actions workflow to build application.
Steps that performed by that workflow:

Perform lint over go code
Perform tests via gradle task
Perform lint over Dockerfile
Perform Playground Backend application build operation and push it to Artifact Registry
Call Terraform script to deploy application to GCP App Engine

Following secrets should be set up in registry to support that CI

GCP_ACCESS_KEY - base64 encoded JSON key for service account
REGISTRY_NAME - Docker Registry address
PROJECT_ID - GCP Project ID

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Choose reviewer(s) and mention them in a comment (R: @username).
[ ] Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
[ ] Update CHANGES.md with noteworthy changes.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI.

R: @tvalentyn


Added Frequently Asked Questions (FAQ's) Section

Related Issue
None
Description
I have added a new FAQ section to the project to enhance user experience by providing answers to common questions. This section is designed to be easily navigable and informative, ensuring users can quickly find the information they need.
Type of PR

[ ] Bug fix
[x] Feature enhancement
[ ] Documentation update
[ ] Other (specify): _______________

Screenshots / videos (if applicable)

Checklist:

[x] I have performed a self-review of my code
[x] I have read and followed the Contribution Guidelines.
[x] I have tested the changes thoroughly before submitting this pull request.
[ ] I have provided relevant issue numbers, screenshots, and videos after making the changes.
[x] I have commented my code, particularly in hard-to-understand areas.

Additional context:
Possible enhancements are making the section more responsive

Resolve the conflicts too


Can't get attribute 'WordpieceTokenizer'

Hi thanks for your effort on developing recasepunc! I know that you can't provide help for models not trained by you, but maybe you have an idea what's going wrong here:
I'm loading the model vosk-recasepunc-de-0.21 from https://alphacephei.com/vosk/models. When I do so, torch tells me that it can't find WordpieceTokenizer. Do you know why? Is the model incompatible?
Punc predict path: C:\Users\admin\meety\vosk-recasepunc-de-0.21\checkpoint
Traceback (most recent call last):
File "main2.py", line 120, in
t = transcriber()
File "main2.py", line 32, in init
self.casePuncPredictor = CasePuncPredictor(punc_predict_path, lang="de")
File "C:\Users\admin\meety\recasepunc.py", line 273, in init
loaded = torch.load(checkpoint_path, map_location=device if torch.cuda.is_available() else 'cpu')
File "C:\Users\admin\Anaconda3\envs\meety\lib\site-packages\torch\serialization.py", line 607, in load
return _load(opened_zipfile, map_location, pickle_module, **pickle_load_args)
File "C:\Users\admin\Anaconda3\envs\meety\lib\site-packages\torch\serialization.py", line 882, in _load
result = unpickler.load()
File "C:\Users\admin\Anaconda3\envs\meety\lib\site-packages\torch\serialization.py", line 875, in find_class
return super().find_class(mod_name, name)
AttributeError: Can't get attribute 'WordpieceTokenizer' on <module 'main' from 'main2.py'>

Hello, I was facing the same issue. There are two ways do address it:

Just import WordpieceTokenizer in you main script

Custom pickler:

import pickle

class Custompickler():
    class Unpickler(pickle.Unpickler):
        def find_class(self, module, name):
            if name == 'WordpieceTokenizer':
                return WordpieceTokenizer
            return super().find_class(module, name)

and set this pickler to torch.load
class CasePuncPredictor:
    def __init__(self, checkpoint_path, lang=default_config.lang, flavor=default_config.flavor,
                 device=default_config.device):
        loaded = torch.load(checkpoint_path, map_location='cpu', pickle_module=Custompickler)

Hi @marlon-br, I can not import WordpieceTokenizer (where from?) but including the custom pickler worked well!

WordpieceTokenizer is a part of transformers (https://huggingface.co/docs/transformers)

Thank you!


fix: changed cap default to fix ux issue on js toggle

Description

In Divider Widget change default Cap.

Fixes #10197
Type of change

Bugfix (non-breaking change which fixes an issue)

Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes

Test coverage results :test_tube:
:green_circle: Total coverage has increased
// Code coverage diff between base branch:release and head branch: bug/divider-js-toggle-cap-issue

Status
File
% Stmts
% Branch
% Funcs
% Lines

:green_circle:
total
55.11 (0)
36.87 (0)
34.99 (0)
55.6 (0.01)

:green_circle:
app/client/src/selectors/commentsSelectors.ts
85.25 (1.64)
64.71 (2.95)
73.33 (0)
90.59 (2.35)

:green_circle:
app/client/src/utils/autocomplete/TernServer.ts
52.94 (0.23)
41.67 (0.84)
36.21 (0)
56.99 (0.25)

:red_circle:
app/client/src/widgets/DividerWidget/widget/index.tsx
78.95 (-14.38)
0 (-100)
80 (0)
82.35 (-10.51)

/ok-to-test sha=480eb67

@techbhavin Tested this PR and please find the status below,
The original issue on the Widget is fixed now - Enabling JS on CAP and removing the value on CAP field does not react on the widget now
Additionally found the below issues
Issue 1 - Enabling JS on CAP and removing the value still shows the options below on the CAP property
https://loom.com/share/379beda8843e4684a324a149147cf0e3

/ok-to-test sha=d8b711b

@techbhavin Left/Centre/Right alignment of cap is not showing when JS condition is used

/ok-to-test sha= d98b69b

/ok-to-test sha=d98b69b

@techbhavin Tested this PR and please find the status below,
Both the issue are reopen
Issue 1 - Enabling JS on CAP and removing the value still shows the options below on the CAP property
Issue 2 - Left/Centre/Right alignment of cap is not showing when JS condition is used
https://loom.com/share/a6a6959e2c8942cc84868139085b4ca1

@somangshu  @dilippitchika  @vivekverma2312

can we add the name label  Cap Alignment in the alignment property in Property Panel.

when we have cap type is nc then we hide cap alignment property and for rest, it is visible instead we can remove this condition and show cap alignment for all-cap types.

Agreed with you for both points @techbhavin.
Call the label "Cap Position" and the tooltip to say "Changes the position of the cap if a valid cap is selected." Not worth over-engineering.

/ok-to-test sha=908cd7b

@techbhavin Tested the bug fixes and please find the status below
Issue 1 - Fixed
Issue 2 - Fixed
New issue :
Issue 3  - Cap selection dot or arrow is not applied to the default widget state
https://www.loom.com/share/aed06bbdeba3406f95fcacb5f272997f

@YogeshJayaseelan you are not seeing the UI properly, Maybe it was not visible to you, But I can see it in the video attached.
Also, I know I sound like a broken record here, But could we something here to make the information grok-able? I literally went through the point more than thrice and still did not understand, Would love to help you in this regard if required

@techbhavin please push this back in case you think my above statement is correct

@techbhavin Thats my bad i was not able notice arrow or dot at the first time. This is working fine and we can proceed further
@somangshu Yes i understand and going forward i will make it clear


Sitemap includes /index/

Is this a BUG REPORT or FEATURE REQUEST?:
bug
What happened:
With our current workaround for the root page "/" we have a duplicate page as /index/ is also showing up within the sitemap.
What you expected to happen:
Hide or workaround /index/.
How to reproduce it (as minimally and precisely as possible):
Anything else we need to know?:
Maybe use deplicated fragment code with index.html and then get these fragments (special case) from _index/

Whenever the new release from Hugo comes out we can fix this and blog quite neatly I think. Right now there's the problem with getPage where we can't be sure what page is received when we call getPage with a common page name like _global. With the new release this will be fixed. So we can have _index and _global pages in any section. _global is to have global fragments and _index is for the section pages, aka list pages using list layouts. As mentioned in the Hugo docs home page uses the same mechanism so we can have a content file to let Hugo know that we want a section level page or a list page and have a _index directory to store the fragments for that page and _global in any section to have section level global fragments. Does that sound good?

I think #258 would fix this one as well. Not sure though. Let's keep it in mind and check for it after the PR is finished.


[Bug] Error occured when imageLoader.loadImage. Cannot read properties of undefined (reading 'samplesPerPixel')

Describe the Bug
I'm currently working on a migration to Cornerstone 3D 2.0
But error occured when I use imageLoader.loadImage in my codes.
My code work at cornerston3D 1.82.4 version. And I'm trying to migrate with 2.2.4 version
Steps to Reproduce

Receive a dicom files with the API and create an objectURL with it.
make image ids with objectURL.  It looks like this.(wadors:blob:http://localhost:5173/7650fdd5-28b8-4ee4-abca-d2af7ab5d78b).
In the version 1.82.4 that I was using in the project before, I used wadouri instead of wadors, but in the version 2.2.4 the browser does not do anything, so if I change it to wadors and then load image, the following error occurs.

below is my codes.
import * as cornerstone3DCore from '@cornerstonejs/core'
import cornerstoneDICOMImageLoader from '@cornerstonejs/dicom-image-loader'

async render(imageIds: string[], elements: HTMLDivElement[]) {
   let maxWebWorkers = 1
   if (navigator.hardwareConcurrency) {
       maxWebWorkers = Math.min(navigator.hardwareConcurrency, 7)
   }
   cornerstoneDICOMImageLoader.init({ maxWebWorkers })
   cornerstone3DCore.volumeLoader.registerUnknownVolumeLoader(
       cornerstone3DCore.cornerstoneStreamingImageVolumeLoader
   )

   this.renderingEngine = new cornerstone3DCore.RenderingEngine(this.renderingEngineId)
   const result = await Promise.all(imageIds.map((id: string) => cornerstone3DCore.imageLoader.loadImage(id)))
   const volume = await cornerstone3DCore.volumeLoader.createAndCacheVolume(this.volumeId, { imageIds })
   this.setViewports(elements)
   volume.load()
}

The current behavior
when I call loadImage function, error occured.

The expected behavior
Is there any problem with my way?
OS
macOS sonoma 14.0
Node version
20.14
Browser
chomre 129.0.6668.101

you cannot just change wadouri to wadors, you should continue using wadouri, if you have dcm files hosted somewhere, i will fix the example for wadouri but this one right now works fine as i see https://www.cornerstonejs.org/live-examples/dicomimageloaderwadouri
But these two for some reason are broken
https://www.cornerstonejs.org/live-examples/volumebasicwadouri
https://www.cornerstonejs.org/live-examples/wadouri.html

The issue for those two examples are our old server is down, so ...
const wadoURIRoot = https://server.dcmjs.org/dcm4chee-arc/aets/DCM4CHEE/wado?requestType=WADO&studyUID=${studyUID}&seriesUID=${seriesUID}&contentType=application%2Fdicom;


PYPI Security Recap

URL
https://twitter.com/di_codes/status/1610781657128108033
When was this post released
4 January 2023
Summary

in 2022, the @pypi team removed >12,000 unique projects. each were instances of spam, typosquatting, dependency confusion, exfiltration and/or malware.
2022: ~12K (mostly malware)
2021: ~27K (mostly dep confusion)
2020: ~500
2019: 65
2018: 137
2017: 38

Ingram Brings up that most of the work has been handled by Himself, The Ee Durbin the Director of Infrastructure. Ingram calls for more support to provide PyPI with a paid staff.
Ingram also acknowledges that much of the detection of these attacks are with the help and support from security and observability companies like @sonatype, @Phylum_IO, @Checkmarx, @jfrog, @datadoghq, @nao_sec, @loginsoft_inc, @checkpointsw, [@theopenssf(https://twitter.com/theopenssf) and some others.
Code of Conduct

[ ] I would like my name mentioned on the podcast
[X] I agree to follow this project's Code of Conduct

An interview was conducted and we are currently working on a longer piece that will include some of the findings.


Cannot change directory into wsl distro

Prerequisites

[X] Write a descriptive title.
[X] Make sure you are able to repro it on the latest released version
[X] Search the existing issues.
[X] Refer to the FAQ.
[X] Refer to Differences between Windows PowerShell 5.1 and PowerShell.

Steps to reproduce
This issue was supposedly fixed https://github.com/PowerShell/PowerShell/pull/10674
However, I am still seeing the exact same issue described in https://github.com/PowerShell/PowerShell/issues/10360 and https://github.com/PowerShell/PowerShell/issues/15497.
Expected behavior
PS C:\Users> cd //wsl$/fedoraremix/
PS Microsoft.PowerShell.Core\FileSystem::\\wsl$\fedoraremix>

Actual behavior
PS C:\Users> cd //wsl$/fedoraremix/
Set-Location: Cannot find path '//wsl$/fedoraremix/' because it does not exist.

Error details

Set-Location: Cannot find path '//wsl$/fedoraremix/' because it does not exist.

Environment data
PS> $psversiontable

Name                           Value
----                           -----
PSVersion                      7.2.0-preview.7
PSEdition                      Core
GitCommitId                    7.2.0-preview.7
OS                             Microsoft Windows 10.0.19042
Platform                       Win32NT
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0…}
PSRemotingProtocolVersion      2.3
SerializationVersion           <IP_ADDRESS>
WSManStackVersion              3.0

and
Name                           Value
----                           -----
PSVersion                      7.1.3
PSEdition                      Core
GitCommitId                    7.1.3
OS                             Microsoft Windows 10.0.19042
Platform                       Win32NT
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0…}
PSRemotingProtocolVersion      2.3
SerializationVersion           <IP_ADDRESS>
WSManStackVersion              3.0

Do you see the issue without final  '/'?

@iSazonov
Yes.  All of the following return the same error

cd //wsl$/fedoraremix/
cd //wsl$/fedoraremix/
cd //wsl$/fedoraremix/
cd //wsl$/fedoraremix/

I thought you needed to target \\wsl$\distro rather than //wsl$/distro?

Both backward and forward slashes work for me:
dir //wsl$/Ubuntu

        Directory: \\wsl$\Ubuntu

Mode                LastWriteTime         Length Name
----                -------------         ------ ----
d----        11/21/2019   6:51 PM                bin
d----         9/22/2017  10:15 AM                boot
d----          7/9/2021  12:16 PM                dev
d----          7/9/2021   5:12 PM                etc
...

@rkeithhill Please share your Windows version.
@clayms Is WSL running in your test?

I'm using 21H1 (10.0.19043).

@iSazonov
Yes, in another shell, because I thought it had to be actively running.  So I started it in another shell on the same computer and left it running before I started another shell and tried to cd into the wsl directories.  However, I just found out that I have to run wsl in the exact same shell session that I want to cd into the wsl directories.  After exiting wsl back to PowerShell can I then successfully cd into the wsl directories from that session and only that session.  It does not matter how many other active wsl sessions are running on the same computer.

This is working for me without starting wsl in the same process.  If this still repros for you, try from cmd.exe and see if it repros to determine if it's WSL.


Add the sbt-sonatype plugin to the build

See: https://github.com/xerial/sbt-sonatype

Fixed in 2e1a48ef5826e9df3b0aff66ea0d84341450a4a0.


Add option to disable writing to file system

A clear and concise description of what the feature is.
When the application is placed in a directory, where FXGL is unable to create/write files and/or directories, the FXGL application might not start, or the application runs with errors.
Describe the solution you'd like
New FXGL setting/settings, that would allow disabling FXGL file writing and directory creation to file system.
Additional context (optional)
Case scenario - if the FXGL application is packed in an installer, where during installation, user can select installation folder, and the user selects folder with elevated privileges, e. g. on Windows Program files, after the installation, the program does not run, because it could not create some directories and files.

@fuzzysearch404 this is now building..
To get the latest build, you can use this:
<dependencies>
    <dependency>
        <groupId>com.github.almasb</groupId>
        <artifactId>fxgl</artifactId>
        <version>dev-SNAPSHOT</version>
    </dependency>
</dependencies>

<repositories>
    <repository>
        <id>oss.sonatype.org-snapshot</id>
        <url>http://oss.sonatype.org/content/repositories/snapshots</url>
    </repository>
</repositories>

You can disable any FS write calls by setting settings.setFileSystemWriteAllowed(false);. Please check this works for the above use case before closing.

@AlmasB Seems like isFileSystemWriteAllowed is missing.
Message:  Cannot inject @Inject(isFileSystemWriteAllowed). No value present for isFileSystemWriteAllowed
Type:  IllegalArgumentException
Method:  Engine.injectDependenciesIntoService()
Line:  Engine.kt:100

java.lang.IllegalArgumentException: Cannot inject @Inject(isFileSystemWriteAllowed). No value present for isFileSystemWriteAllowed
	at com.almasb.fxgl.app.Engine.injectDependenciesIntoService(Engine.kt:100)
	at com.almasb.fxgl.app.Engine.initServices(Engine.kt:77)
	at com.almasb.fxgl.app.FXGLApplication$start$task$1.run(FXGLApplication.kt:117)
	at com.almasb.fxgl.core.concurrent.IOTask.lambda$ofVoid$5(IOTask.java:138)
	at com.almasb.fxgl.core.concurrent.IOTask$2.onExecute(IOTask.java:151)
	at com.almasb.fxgl.core.concurrent.IOTask$1.call(IOTask.java:107)
	at javafx.concurrent.Task$TaskCallable.call(Task.java:1425)
	at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
	at java.base/java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:515)
	at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
	at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)
	at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)
	at java.base/java.lang.Thread.run(Thread.java:830)

Odd, I can't reproduce this for some reason. Could you provide the full build number? It should be FXGL-dev-SNAPSHOT (14.07.2020 13.23)
Also, are you running this from an IDE or the no-access folder?

@AlmasB Oops, seems like my IDE messed something up, when switching dependencies.
Now FXGL runs just fine, but when placed in no-access folder there is this logging exception:
Error during launch:
java.nio.file.AccessDeniedException: logs
        at java.base/sun.nio.fs.WindowsException.translateToIOException(WindowsException.java:89)
        at java.base/sun.nio.fs.WindowsException.rethrowAsIOException(WindowsException.java:103)
        at java.base/sun.nio.fs.WindowsException.rethrowAsIOException(WindowsException.java:108)
        at java.base/sun.nio.fs.WindowsFileSystemProvider.createDirectory(WindowsFileSystemProvider.java:506)
        at java.base/java.nio.file.Files.createDirectory(Files.java:694)
        at com.almasb.fxgl.logging.FileOutput.getOrCreateLogDir(FileOutput.kt:46)
        at com.almasb.fxgl.logging.FileOutput.<init>(FileOutput.kt:27)
        at com.almasb.fxgl.logging.FileOutput.<init>(FileOutput.kt:22)
        at com.almasb.fxgl.logging.FileOutput.<init>(FileOutput.kt)
        at com.almasb.fxgl.app.GameApplication.initLogger(GameApplication.java:133)
        at com.almasb.fxgl.app.GameApplication.launch(GameApplication.java:85)
        at com.almasb.fxgl.app.GameApplication.launch(GameApplication.java:53)
        at game.Game.main(Game.java:67)
Application will now exit

Is this with FS write set to false?
initLogger 133 is, so it shouldn't get inside the if ... hmmm
        if (settings.isFileSystemWriteAllowed() && settings.isDesktop() && !settings.isExperimentalNative()) {
            Logger.addOutput(new FileOutput("FXGL"), LoggerLevel.DEBUG);
        }

Yes. I did set it to false.
I recompiled everything again, and I can't reproduce that again. Now everything is working fine in no-access directories.
Thank You for implementing this feature so quickly :)


Empty markdown cell isn't rendered nice

Testing #119367

create a new markdown cell
enter no text and go to preview mode
the cell looks funny, we should render a placeholder like "empty cell"

Fixed by de4b1cf9dca19b3ebd663ae492ade42a0a6c72a0


fixing broken link

At least now I know where to go if I want to buy a horse!

So sorry!  Thanks for catching that!


test: report merged tests coverage

In order to provide a holistic coverage view
The challenge is to merge code coverage results from Cypress Component Testing with the already existing results from Angular CLI's unit testing via Karma
Then, we need to update the CI to upload both coverage results from both test jobs to later join them in a job and report them somewhere. Like Coveralls or Codecov
Has been interesting so far:
Lessons learned

lcov-result-merger does not merge all kinds of data in lcov.info files. Branches for instance were not merged. So discarding that option. Despite merging lcov.info files sounded good, as it's a widely used format, so less dependency on the JS world. Tried with lcov CLI. However didn't manage to properly merge them using -a and ignoring errors with --ignore-error inconsistent.
Cypress Code Coverage official plugin mentions it can merge unit tests even backend tests with Cypress coverage results. It uses istanbul.merge method under the hood.

Lessons reminded:

Angular CLI doesn't allow to configure code coverage reporters directly (via angular.json or CLI flags. You need to generate a karma.conf.js to configure those. Which was already there because of the same reason. But in that case in order to use a GitHub Action to show lcov output (hence need to config that as code coverage reporter) in CI/CD in a human friendly way. Beware test reporters reporting tests results CAN be configured via CLI flags / angular.json. It's test code coverage reports which isn't configurable.

The approach
First, configure both tests to output different istanbul JSON coverage report files. As seen above, playing with lcov is tricky.
Later, we can in local use nyc report after moving those to .nyc_output to merge them & report them visually using HTML report generator for instance.
In CI, however, we need to generate a merged report file to integrate it in some tool (like the ones mentioned above). Seems that can be done using istanbul.js lib. For instance via the nyc CLI)
Specifically, with nyc you can do nyc merge <dir> <outputFile>. Where <dir> is a directory with multiple JSON code coverage reports generated by istanbul. So after both code coverage JSONs get uploaded, we can start a job that will download them to the same place, run that command and finally send the merged report somewhere so it can be tracked & visualized in every PR / GH Actions workflow run.

#656  👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

 Codecov will compare coverage reports and display results in all future pull requests.
Thanks for integrating Codecov - We've got you covered :open_umbrella:


Conflict on using masks on number fields that are used in formulas.

Using onbeforechange and onchange, the values that I am getting instead of being "unmasked" it's masked which complicates things since I have to manually convert it back to numeric.
I have tried to use the unmask function but I have no idea how to do it. I guess that this might not be possible since we set the mask on the column in the jexcel options, whereas the unmask function is applied on the input field that is masked.
So the question is, what is the proposed way of masking and unmasking fields that take part in formula calculations?

@paulhodel If you need more details to understand or maybe reproduce this please inform me. Thank you.

This is included on Pro v5, for the CE or previous versions you need to use some external library for masking since the mask will work in the editor level.
This examples works on v3 & v4 using numeraljs for masking.
www.bossanova.uk/jexcel/v4/examples/table-scripting

Ok let's talk about the solution based on numeraljs for v4.
It does work exactly as expected, using the code in the link you provided, but there is a drawback.
The function called on updateTable runs for every cell in the table and if you are setting the value of a cell during the onchange then the whole thing falls into a (almost) infinite loop.
So is there a way to avoid this? Maybe by changing the label instead of the value of a cell or by detecting whether the change was initialized by a user or programmatically in order to stop the cascade of events?

A possible solution , create a flag where you can apply mask only on edition after the edition. Is that work for you?

How about remove the mask property and apply the mask onchange?

Remove the property mask from the editor on initialiation.
Add a mask on the onchange event

You should avoid execute setValue inside updateTable. If you need change the table values you have other options. Can you create a jsfiddle of you example with your updateTable (simplified version). I can create a solution for you.


Ability to clear/delete a variable inside EnvironmentVariableCollection when extension is disposed/restarted

Currently when an extension is disposed, vscode (as far as I can tell) will ignore usage of EnvironmentVariableCollection.clear() or EnvironmentVariableCollection.delete(key)
context.subscriptions.push({
    dispose() {
      // Tried both clear and replace at the same time, as well as independently. Seemingly no results with any combination
      context.environmentVariableCollection.replace("MY_UNIX_SOCKET", "");
      context.environmentVariableCollection.clear();
    },
});

This is frustrating in our use case, because we have a unix socket that is created each time the extension starts - which means that if the user restarts the extension host we generate a new socket url. Existing terminals then can no longer communicate with the socket, and have to relaunch their terminal. Currently as a workaround I'm storing the socket url in context.globalState and reusing it on restart. This works and existing terminals can just keep assuming the stale URL is correct, but ideally we'd be able to create a new one.

Hi @alii is your extension open source? Can you share a link if it is?
It looks like a caching issue to me - the env collection cache is not updated on dispose hence the values are rehydrated from the cache after the reload (see the first item in the list below).
To unblock you meanwhile I have couple of options in mind (I'm missing use case context of course):

would setting the context.environmentVariableCollection.persistent = false; work for you? this will ensure that the variables (entire collection) are not persistent across reloads
there is an option to get a scoped env collection with the context.environmentVariableCollection.getScoped() function, would using a scoped(e.g. scoped to a session) collection help?

I think persistent = false is indeed the right thing to handle this.


fix(material/tabs): strong focus indicator not visible when tab header has a background

mat-tab-group has the ability to theme both the foreground and background. When the background color is different from the default, the strong focus indicator blends into it, making it invisible.
These changes invert the color of the indicator so it stands out.
cc @zelliott

@crisbeto needs rebase

@crisbeto needs rebase

Rebased.

Rebased.


[Helm v2] add an option for GCS region in global values.yaml

add an option to specify GCS region in global values.yaml

any progress on this?

this is required only if deis needs to create the bucket otherwise you can create the bucket in any region and specify it to use. Currently there is a discussion to move from deis fork of the registry to using upstream which would mean deis wouldn't create buckets if they don't exist.So, will wait until that is finalized.

ok, lets wait for the final decision


Revert "Make a namespace before using it"

Reverts GoogleCloudPlatform/kubernetes#9141

LGTM
On Tue, Jun 2, 2015 at 4:54 PM, Brian Grant<EMAIL_ADDRESS>wrote:

Merged #9151 https://github.com/GoogleCloudPlatform/kubernetes/pull/9151
.
—
Reply to this email directly or view it on GitHub
https://github.com/GoogleCloudPlatform/kubernetes/pull/9151#event-320613275
.


setup.cfg's "version = attr: jinja2.version" causes issues when installing from source

When installing jinja2 from sources in a fresh virtualenv, setup.py breaks unless markupsafe is installed prior.  I seem to have traced it to the version = attr: jinja2.__version__ line in setup.cfg; if I replace that with a hard-coded version (e.g. 3.0.3), then installation works.
This is problematic since some tools install files via requirements.txt using the --no-binary :all:, and since setup.cfg pulls code from jinja which in turn tries to import markupsafe before markupsafe can be installed as a dependency, things break.
How to reproduce the bug:

Prerequisite: Create and activate a fresh virtualenv via python3 -m venv venv; . venv/bin/activate.  (Ensure the venv doesn't already exist, of course.)
Method 1: Download and unzip the jinja2 tarball, cd inside, then run python setup.py install.
Method 2: Install via pip install --upgrade --no-binary :all: 'jinja2>=3.0.3'

Full, complete example and traceback showing the error:
paul-goins@dell2018:~$ rm -rf venv
paul-goins@dell2018:~$ python3 -m venv venv
paul-goins@dell2018:~$ . venv/bin/activate
(venv) paul-goins@dell2018:~$ pip install --upgrade --no-binary :all: 'jinja2>=3.0.3'
Collecting jinja2>=3.0.3
  Using cached Jinja2-3.0.3.tar.gz (269 kB)
    ERROR: Command errored out with exit status 1:
     command: /home/paul-goins/venv/bin/python3 -c 'import sys, setuptools, tokenize; sys.argv[0] = '"'"'/tmp/pip-install-7wo6yg5s/jinja2/setup.py'"'"'; __file__='"'"'/tmp/pip-install-7wo6yg5s/jinja2/setup.py'"'"';f=getattr(tokenize, '"'"'open'"'"', open)(__file__);code=f.read().replace('"'"'\r\n'"'"', '"'"'\n'"'"');f.close();exec(compile(code, __file__, '"'"'exec'"'"'))' egg_info --egg-base /tmp/pip-install-7wo6yg5s/jinja2/pip-egg-info
         cwd: /tmp/pip-install-7wo6yg5s/jinja2/
    Complete output (35 lines):
    Traceback (most recent call last):
      File "<string>", line 1, in <module>
      File "/tmp/pip-install-7wo6yg5s/jinja2/setup.py", line 4, in <module>
        setup(
      File "/home/paul-goins/venv/lib/python3.8/site-packages/setuptools/__init__.py", line 145, in setup
        return distutils.core.setup(**attrs)
      File "/usr/lib/python3.8/distutils/core.py", line 121, in setup
        dist.parse_config_files()
      File "/home/paul-goins/venv/lib/python3.8/site-packages/setuptools/dist.py", line 701, in parse_config_files
        parse_configuration(self, self.command_options,
      File "/home/paul-goins/venv/lib/python3.8/site-packages/setuptools/config.py", line 121, in parse_configuration
        meta.parse()
      File "/home/paul-goins/venv/lib/python3.8/site-packages/setuptools/config.py", line 426, in parse
        section_parser_method(section_options)
      File "/home/paul-goins/venv/lib/python3.8/site-packages/setuptools/config.py", line 399, in parse_section
        self[name] = value
      File "/home/paul-goins/venv/lib/python3.8/site-packages/setuptools/config.py", line 184, in __setitem__
        value = parser(value)
      File "/home/paul-goins/venv/lib/python3.8/site-packages/setuptools/config.py", line 515, in _parse_version
        version = self._parse_attr(value, self.package_dir)
      File "/home/paul-goins/venv/lib/python3.8/site-packages/setuptools/config.py", line 349, in _parse_attr
        module = import_module(module_name)
      File "/usr/lib/python3.8/importlib/__init__.py", line 127, in import_module
        return _bootstrap._gcd_import(name[level:], package, level)
      File "<frozen importlib._bootstrap>", line 1014, in _gcd_import
      File "<frozen importlib._bootstrap>", line 991, in _find_and_load
      File "<frozen importlib._bootstrap>", line 975, in _find_and_load_unlocked
      File "<frozen importlib._bootstrap>", line 671, in _load_unlocked
      File "<frozen importlib._bootstrap_external>", line 848, in exec_module
      File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
      File "/tmp/pip-install-7wo6yg5s/jinja2/src/jinja2/__init__.py", line 8, in <module>
        from .environment import Environment as Environment
      File "/tmp/pip-install-7wo6yg5s/jinja2/src/jinja2/environment.py", line 15, in <module>
        from markupsafe import Markup
    ModuleNotFoundError: No module named 'markupsafe'
    ----------------------------------------
ERROR: Command errored out with exit status 1: python setup.py egg_info Check the logs for full command output.

Environment:

Python version: 3.8.10
Jinja version: 3.0.3

Best Regards,
Paul Goins

You are using an very, very old, unsupported version of pip and/or setuptools. Use pip install -U pip setuptools wheel to update the common set of build tools. Duplicate of pallets/markupsafe#285

Thanks - I had tried with a new pip, but not a new setuptools.  Good to know!


Autocomplete for JS files but not TS files? (TypeScript 2.2 and 2.3)

VSCode Version:
VS Code Insiders
Version 1.12.0-insider (1.12.0-insider)

OS Version:
macOS Sierra
10.12.4 (16E195)

Steps to Reproduce:
mkdir test-dir
cd test-dir
npm i -D typescript
node_modules/.bin/tsc --init
touch index.ts
touch index.js
npm i snoowrap # Any library without types
code-insiders .

Now, Look at this, in index.js:

However, in index.ts:

I tried a few libraries, like reddit-oauth, and chrome-remote-interface (sorry for the obscure choices, it wasn't the intention of testing this).
Basically any library without typings. Libraries with typings, as well as my own files, all work very well. For example, all my Angular 2 applications) work just fine.
The particular pictures show no suggestions because I also disabled snippets "editor.snippetSuggestions": "none", but I confirmed with and without this setting.
I tried this with both TypeScript 2.2 and 2.3. I tried messing with several options in tsconfig.json, and it didn't seem to make a difference.
Things like "allowJs": true, or enabling typeAcquisition (not sure what it is). I also had "moduleResolution": "node", all the time.

Yes, for TypeScript code, any library you use must have typings, either from @types/... or  included in the package. It does not look like there are typings for snoowrap.
In TypeScript projects, these typings files must be manually managed. In JavaScript, since the Typings files are only used for editor language features and not for compiling, we will automatically download these typings to provide richer intellisense. Here's some more info about automatic typing acquisition: https://code.visualstudio.com/Docs/languages/javascript#_intellisense
In your case, you have a few options to work with this library:

Write a *.d.ts typings defintion file for the module. Here's some starting points for that: http://stackoverflow.com/questions/12687779/how-do-you-produce-a-d-ts-typings-definition-file-from-an-existing-javascript
Pretend you are working with JavaScript by casting snoowrap to an any type. This disables all type checking

Please let me know if that makes sense or if you have questions about this

Hi Matt,
The reason I'd expect this to work is the Untyped imports feature announced in TypeScript 2.1.
If there are no typings at all for JS, VS Code seems to generate some typings or use another technique to understand the structure of the non typed module.
In this particular case I'm experimenting with a new JavaScript-only library, and I'm appreciating that VS Code can get as close as possible to TypeScript when working with it. I thought it definitely would use that support for untyped imports, given they're supported TypeScript feature.

Ok. Thanks for the clarification.
In the untyped import case, TypeScript essentially ends up treating the imported module as an any type. This is why IntelliSense no intellisense shows on the module.  However I do agree that it makes sense to show some suggestions on it since we do in the JavaScript case. I've opened https://github.com/Microsoft/TypeScript/issues/15286 to track this

Thanks a lot :)


Added support for RDS version control

This is a simple PR that does two thing:

Add support for enabling / disabling RDS minor version upgrades

Add support for specifying the RDS engine version itself (currently hardcoded)

The need for this is due to a few issues caused by the current hardcoded database version (13.7).
I added this module to my project last week, all was well. Today, when running terraform plan ... again, there is now a delta:
Terraform will perform the following actions:

  # module.retool.aws_db_instance.this will be updated in-place
  ~ resource "aws_db_instance" "this" {
      ~ engine_version                        = "13.10" -> "13.7"

In the past days, the DB hit its regularly scheduled maintenance window, and upgraded from 13.7 -> 13.10.
However, RDS does not support downgrades, as seen when attempting to apply:
│ Error: updating RDS DB Instance (retool-rds-instance): operation error RDS: ModifyDBInstance, https response error StatusCode: 400, RequestID: ~, api error InvalidParameterCombination: Cannot upgrade postgres from 13.10 to 13.7

So as the module is now, I only have one option, and that's to login to the AWS UI and disable "Auto minor version upgrade" under Maintenance, which is of course not idempotent, and contrary to Terraform principles.
This PR fixes the issue, by providing some flexibility:

a user can disable auto version upgrades (I intend to do this)
a user can leave upgrades in place, and when the situation I'm in occurs, instead update the newly exposed variable rds_engine_version to (in this case) 13.10

These are very minor changes, validated with:
aws_ecs (feature/rds-version-support) λ terraform validate
Success! The configuration is valid.

If possible, it'd be great to get this merged quickly, so I don't have to use the web UI / my own fork I don't intend to maintain.
Thanks!

This would be very useful, as AWS has seemingly deprecated Postgres 13.7 - launching the infrastructure with this module is currently failing due to that version being unavailable, which is confirmed in the RDS web console. I note that 13.7-compatible Aurora still exists.


Pages folder/content location

Where to put what is now in the pages folder.
One can only decide between branches and their root / docs location.
Right now the solution is using the gh-pages branch where the content of pages was pushed using
git subtree push --prefix pages origin gh-pages.
I think this makes sense but if we keep it like that it needs automation, the branch needs some sort of protection and in that case we should not have the pages folder at all.

Just added a protection rule to gh-pages which specifies that PRs are necessary to merge into it with at least one approval.


Atom support?

I have Ternjs installed in Atom, is there any path to running tern-meteor on Atom?

Also curious on this, it seems Sublime integration has internal process issues and I've been slowly adopting Atom.

I think it is described in the readme. Copy the Meteor.js file from this repo into the plugins folder of your tern installation and then enable it in your .tern-project file.

IMHO, I think tern-meteor should be published in the npm registry like other tern plugins https://www.npmjs.com/search?q=tern
So after user could install it with npm install (see for instance https://www.npmjs.com/package/tern-tabris#installation)
I had created a PR for that https://github.com/Slava/tern-meteor/pull/17

If you guys want to maintain a copy on npm, I have no problems with that, you are free to do this. Closing this issue as it is not a bug.

I've published a fork of this on npm. Anything I should know, tell me.


Fix typo in include: configuration, add actor include.

The configuration example said includes: with an additional s instead of include:.
I also added the actor import.

Thanks!


Missing credentials in config

Running through the Readme the first time I came across this error:
Unhandled rejection TimeoutError: Missing credentials in config
    at ClientRequest.<anonymous> (/Users/jim/.nvm/versions/node/v4.0.0/lib/node_modules/shep/node_modules/aws-sdk/lib/http/node.js:56:34)
    at ClientRequest.g (events.js:260:16)
    at emitNone (events.js:67:13)
    at ClientRequest.emit (events.js:166:7)
    at Socket.emitTimeout (_http_client.js:534:10)
    at Socket.g (events.js:260:16)
    at emitNone (events.js:67:13)
    at Socket.emit (events.js:166:7)
    at Socket._onTimeout (net.js:318:8)
    at _runOnTimeout (timers.js:512:11)
    at _makeTimerTimeout (timers.js:503:3)
    at Timer.unrefTimeout (timers.js:572:5)

There's a required step to set up AWS credentials as explained in the document Configuring the SDK in node.js.

@bigtiger thanks for the feedback! I added some info to the readme in https://github.com/bustlelabs/shep/pull/47 about configuring the AWS credentials.

I just ran into this same problem, but I have ~/.aws/credentials set up with two different profiles. Other AWS tools are finding those credentials just fine, so I'm fairly sure that I have it configured correctly. Any ideas?

Ah-ha! The problem seems to be that I had two named profiles, but no 'default' profile. When I added one named 'default' it started working.


1#658#752

Max Including Dust #652
Error Message Placement #658
APY Discrepancy #752

You can check latest branch, 1#658#752.
Thank you.

@sparrowDom Do you mind reviewing this PR?

Hey @Michael1104Smith just checking in. A lot of good work has already been done on these issue. Were you planning on completing the PR?

closing as this has no activity.


Rewrite Gulp code with typescript and ESM. I want to do this for you.

Describe your idea for a new feature
Rewriting Gulp code using new Typescript and ESM

This will enhance tests, bug fixes and code redability

Explain the problem your idea is trying to solve
How will it benefit gulp and its users?

More stable and easy to read code

If this feature could exist outside of gulp (like as a plugin or a module), would you be interested in helping to create and maintain it?
No, this is a code refactor. I'm ready to do this for you and send PR if you love to go with typescript
I love Gulp, so I want to maintain it with you and resolve bugs, add features with you.

We're in the process of the gulp 5 updates, which don't include any JS syntax updates.
Once v5 is released, we'll be updating the code to use ESNext and ESM. We have no plans to change any code to typescript.
If you'd like to contribute to v5, we have a public project board at https://github.com/orgs/gulpjs/projects/4 - there is still a lot to do.


I can't run the PyRCN example

When I run the PyRCN / examples / digits.py program in sequence, I get the following error in the 5th cell that optimizes input_scaling and spectrum_radius.
ValueError: Input contains Nan, infinity or a value too large for dtype(‘float64’).
The execution environment is as follows.
ubuntu       18.04.5 LTS
numpy         1.19.2
scipy              1.6.1
scikit-learn   0.24.1
joblib              1.0.1
I haven’t edited the code. Is it an environmental issue? or is there a problem with the example?
I would appreciate it if you could answer.

Hi @Naka2024,
I think that I have seen this error in the past and it might be due to an old version of PyRCN.
Which version of PyRCN and which Python 3.x do you use?
Did you use the Jupyter-Notebook or the python script?
Can you send me the Error Traceback as PN?

Dear @renierts
When I checked the version of pyrcn, it was 0.0.6, so I updated it.
The current versions of PyRCN and Python are listed below.
PyRCN 0.0.12
Python 3.8.8
I ran the example again but got the following error in the 4th cell.
(Sorry, I don't know what the PN is, so here's a screenshot of the error I encountered.)

I get the same error in both Jupyter-Notebook and Python scripts.

Dear @Naka2024
thanks for notifying me about this bug. "input_to_nodes" and "nodes_to_nodes" were changed to "input_to_node" and "node_to_node" to better follow the base module naming.
In the dev-Branch, you can already find the  updated examples. I will merge this with the main branch tonight together with PyRCN v0.0.13. Sorry for the inconvenience.

The fixed examples are on the master branch now.

Dear @renierts
I have upgraded PyRCN to 0.0.13 and tried to run the master branch example, but I get an error in the last cell.
A screenshot is provided below.

I got the same error in Jupyter-Notebook and Python script.

Dear @Naka2024
thanks for pointing that out. This bug was fixed within another issue You can either install PyRCN using setup.py or wait until I notify you that v0.0.14 is released.

Dear @renierts
I updated PyRCN and ran the updated example digits.
The execution of the python script did not produce any error, but the jupyter notebook example produces an error in the last cell.
Here is a screenshot.

Dear @Naka2024 ,
thank you for pointing this out. The last bug is a typo in the previous cell, which should be base_esn = sequential_search.best_estimator_ instead of base_esn = sequential_search.all_best_estimator_, because we aim to use the global best estimator for the final evaluation.
I have updated the notebook on the dev-Branch. Many many thanks for giving me so much feedback regarding this notebook. This definitely helps to improve the quality of PyRCN.
Can you please close the issue if everything works fine now?


Changed IRT image file and logourl

Please note: This repository is being rebuilt to accept the new volume of token additions and modifications. PR merges will be delayed.

I agree to not ping anybody on Discord/Twitter/email about this pull request. Instead I will inquire by posting a new comment in the pull request if needed.

PRs are reviewed in bulk and and can take up to two weeks to be merged.
This repository is managed using an auto merge action. Please ensure your PR has no deleted lines, and it will be merged.
Please provide the following information for your token.
Please include change to the src/tokens/solana.tokenlist.json file in the PR.
DON'T modify any other token on the list.
At minimum each entry should have

Token Address:
Token Name:
Token Symbol:
Logo: (logo should be uploaded under assets/mainnet//*.<png/svg>)
Link to the official homepage of token:
Coingecko ID if available (https://www.coingecko.com/api/documentations/v3#/coins/get_coins__id_):

Auto merge requirements
Your pull request will be automatically merged if the following conditions are met:

Your pull request only adds new tokens to the list. Any modification to existing
tokens will require manual review to prevent unwanted modifications.

Your pull request does not touch unrelated code. In particular, reformatting changes to unrelated
code will cause the auto merge to reject your PR.

Any asset files added correspond to the token address you are adding. Asset files
must be PNG, JPG or SVG files.

Your change is valid JSON and conforms to the schema. If your change failed validation,
read the error message carefully and update your PR accordingly.

No other tokens shares the same name, symbol or address.

For example, this change would be rejected due to unrelated changes:

The bot runs every 60 minutes and bulk-merges all open pull requests to prevent conflicts.
This means that you need to wait up to 60 minutes for your pull request to be merged or reprocessed.

"Your pull request only adds new tokens to the list. Any modification to existing
tokens will require manual review to prevent unwanted modifications."
I am trying to update the image file used to represent IRT (InJesterr Reward Token) I will need a manual review, Thanks!

Can I get a review on this pull request, please?


cancel postgres check within timeout

What does this PR do?

Motivation
This PR makes sure postgres check is canceled within timeout (4s). This is to fix intermittent cancelation timeout (the default check cancel timeout is 5s) happening in cluster runners, which prevent new check being re-scheduled.
2023-12-12 14:51:10 UTC | CORE | ERROR | (pkg/collector/scheduler.go:106 in Unschedule) | Error stopping check postgres:2f8838d1de1b4182: an error occurred while calling check.Cancel(): timeout while calling check.Cancel() on check ID postgres:2f8838d1de1b4182

Additional Notes
This change does introduce new concerns where database connection could be left idle if they are not being gracefully closed within the timeout.
Review checklist (to be filled by reviewers)

[ ] Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
[ ] Changelog entries must be created for modifications to shipped code
[ ] Add the qa/skip-qa label if the PR doesn't need to be tested during QA.

postgres check is canceled within timeout (4s)

That's huge. Do we know where the time is being spent: in the db or in the Python code?

@nenadnoveljic we don't know exactly where the time is spent, mainly because the timeout happens so rarely with no clear reproducible pattern (we see it happen roughly once or twice a month).

When it happens, is it possible for us to check where the time is spent?


Show database name when creating backups and restores.

Using dBeaver Community Edition. It would be helpful if the name of the selected database could be displayed in the backup and restore screens, as well as the confirmation messages before starting the backup or restore. More important for restoring. The confirmation reminds me to double-check my work but I have to cancel out of the process and start over again. Would be helpful to just be able to look at the confirmation message and/or the backup or restore screen.

Thank you for feature request.


How to deploy these two projects to Azure in release mode via script?

How to deploy these two projects to Azure?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: def17b01-9c42-fd6d-a684-7e4a1af62deb
Version Independent ID: b1dd9faa-f1cf-5829-7cbd-66b6b2887d17
Content: Running multiple dependent services using .NET Core and Visual Studio - Azure Dev Spaces
Content Source: articles/dev-spaces/multi-service-netcore-visualstudio.md
Service: azure-dev-spaces
GitHub Login: @zr-msft
Microsoft Alias: zarhoads

@PingPongSet Thank you for the question! We are investigating this and will get back to you shortly.

@PingPongSet Follow the below document to deploy the projects to azure:
https://docs.microsoft.com/en-us/azure/dev-spaces/get-started-netcore-visualstudio
This document talks about calling one project from another.

Take note of the endpoint URL displayed in the Azure Dev Spaces for AKS pane in the Output window. It will look something like http://localhost:. It might seem like the container is running locally, but actually it's running in the dev space in Azure.

Hope this helps!

@AmanGarg-MSFT
I changed the title to make it clearer. I meant how to deploy both project in release mode via script.
Currently, it deploys only when Dev Space is clicked in debug mode within VS 2019.
Also how to deploy them to Azure Container Registery and AKS via script in release mode.

Note that Azure Dev Spaces creates not only public DNS but also a temporary SSH tunnel for your remote container. Therefore you can also access your remote application using “localhost” from your desktop.
You can use azds up command to build and run your code in Azure Dev Spaces
https://docs.microsoft.com/en-us/azure/dev-spaces/quickstart-cli#build-and-run-code-in-kubernetes

Build and run your code in AKS using the azds up command

For your reference: https://docs.microsoft.com/en-us/azure/dev-spaces/how-dev-spaces-works#run-your-code

We are going to close this thread as resolved but if there are any further questions regarding the documentation, please tag me in your reply and we will be happy to continue the conversation.


Datetime column in MSSQL migrations

In knex.schema, creating or altering a column using table.dateTime() or table.timestamp() generates a query that uses the datetime type. Microsoft discourages the use of this type for new work and recommends using datetime2 instead, since it's got considerably better precision, a wider representable range and is ANSI SQL compliant, without using any more storage (both types are 8 bytes wide by default). datetime2 is available since SQL Server 2008, but since I believe other parts of knex generates syntax requiring at least SQL Server 2012, that shouldn't be a problem. The dominant MSSQL Node driver (Tedious) supports both and returns both as a Javascript Date by default.
Now, this is trivial to work around with table.specificType, but I think knex should default to the recommended best practice. I am willing to create a PR for this, but before I do that I figured I'd check if there are any potential problems I've overlooked with such a change. I don't know what the policy is on backwards compatibility in migrations, either.
In addition to switching to datetime2, MSSQL also has a timezone-aware type, datetimeoffset, which is like datetime2 but including a timezone offset (in Postgres terms it's a timestamptz). Perhaps a better idea would be to implement the same API as Postgres, that is table.dateTime(columnName, withoutTimezone), but unlike just switching from datetime to datetime2 which is technically incompatible but unlikely to actually break things in practice, changing to timezone-aware by default has a great deal of potential for interesting bugs.

I believe that if Microsoft recommends against the use of datetime then definitely knex should follow this recommendation.
I don't know much about MSSQL let alone the detailed differences between datetime and datetime2, so I can't determine if this would be a breaking change, but nevertheless the upcoming release already contains some breaking changes so I think 0.14 would be good for this.

I don't think it'd be a breaking change in Javascript for most people (barring extremely weird edge cases relying on datetime's precision, or something). datetime is just all around worse than datetime2 - most glaring issue is that it has a precision of 3 milliseconds, while datetime2 offers 100 nanoseconds) - and the only reason to use it that I'm aware of is for backwards compatibility with old client applications. I don't think any such JS clients exist, so that point should be irrelevant.
I think both of them support the same string literal formats for input, as well, although this is only really relevant to queries explicitly using custom and/or localized date formats. I could investigate further if needed.

I wouldnt like to make this as default, but to add some deprecation notice maybe. If we change the type now, it means that when existing project updates knex and runs new migrations they will have mixed datetime types in their db which sound pretty scary...
Im not sure how to handle this.

@elhigu Well, yes. However, datetime and datetime2 are pretty much interchangeable and can be compared directly without casts. Converting a column from the old to the new format can be done with a simple ALTER TABLE ... ALTER COLUMN (presuming there are no constraints or indexes). I agree that mixed types is a hairy situation to be in but I'm not sure if it actually has any real practical impact in this case. Just using datetime in the first place offers plenty of potential for bugs since the precision is so bad.
There is one thing datetime has that datetime2 doesn't though - it's implicitly convertible to a float (number of days since the epoch), so you can do simple arithmetic and aggregation on it. With datetime2 you must use various SQL functions for that (dateadd & friends).
What would you propose to move this forward though? Add a deprecation warning to table.dateTime() and table.timestamp() for MSSQL and only swap it after the next version bump? Add a new function for datetimeoffset? I don't really like the idea of an inconsistent API though.

I suppose that one correct flow for this would be allow using datetime2 with .timestamp({ highPrecision: true }) flag or something like that and add deprecation warning that in 0.15 highPrecision: true will be changed to be default. So if they don't add { highPrecision: false } to their timestamp commands, during 0.14, then their code will work differently in 0.15 release.
That option should be implemented also for .timestamps() method and pass it to internal calls to .timestamp().

That sounds reasonable. I'll take a look at setting up a PR.

fixed in #2757


Issue with hero card template and message back action - missing display text in chat

Version
Version 01.getting-started/a.full-bundle -  Full Bundle Demo - localhost
(google chrome - Version 80.0.3987.116 (Official Build) (64-bit) browser)
name="botframework-directlinespeech:version" content="4.7.1"
name="botframework-webchat:bundle:variant" content="full"
name="botframework-webchat:bundle:version" content="4.7.1"
name="botframework-webchat:core:version" content="4.7.1"
name="botframework-webchat:ui:version" content="4.7.1"
Describe the bug
Issue with hero card template and message back action inside template defined as /tests/image_snapshots/chrome-docker/rich-cards-js-hero-card-1-snap.png.
Expected behavior :
button  messageBack Action with displayText should display text and show posted value/text
button messageBack Action with no display text should display only posted value/text.
Current behavior:  both buttons display only posted values(check image)

Bug noticed during implementation of web chat channel based on existing chat bot which is currently in use inside Facebook channel. Issue verified using provided test samples in this repository.
Steps to reproduce

start 01.getting-started/a.full-bundle -  Full Bundle Demo on localhost
type help
search for hero card template  and press button "Show hero card"
scroll down to the bottom of the chat
press button messageBack Action with display text
button messageBack Action with no display text

Expected behavior
We should have different behavior for buttons.   Button messageBack Action with display text
should have same output as it is already implemented and presented inside test  tests\hooks\useSuggestedActions.js.

Additional context
Template with hero card should display info text to the  user, and submit different text to the bot (or payload as more complex value).
PostBack action type is not resolving an issue, because we need to show user that action was performed, and message needs to be different.
Behavior should be the same as it is already implemented and presented inside test  tests\hooks\useSuggestedActions.js
This is example of an attachment from project which should work as described when it rendered in web chat: PayloadData submitted to the back end, and user should be able to see message "Check my booking – display text "
"attachments": [
{
"contentType": "application/vnd.microsoft.card.hero",
"content": {
"title": "Check my booking",
"buttons": [
{
"type": "messageBack",
"title": "Check my booking",
"text": "Check my booking  - text",
"displayText": "Check my booking – display text ",
"value": "{'PayloadData':'simplePayload'}"
}
]
}
Changes in file which resolved an issue on localhost but side effects of changes unknown.
file - packages\bundle\src\adaptiveCards\Attachment\AdaptiveCardRenderer.js

[Bug]

@bisercic89 Thank you for the detailed report. I am reviewing your content now and will get back to you shortly.

Related to #1582

This is a bug we should fix, will triage.
IMO, this is different than #1582, because that bug talks about "switching from postBack to messageBack". But this bug talks about "the messageBack behavior is incorrect".

I've added this as a triage item to discuss what milestone we'll be able to address this.


iOS - Injected css with injectedJavaScriptBeforeContentLoaded (or injectedJavaScript) not applied

Hi,
Bug description:
In my usecase I need to add padding-top to rendered html of webview.
It works with Android but not with iOS
To Reproduce:
  const injectedScript = `(function() {
    const injectedStyleTag = "<style>body {padding-top:400px !important; background: red;}</style>";
    document.body.insertAdjacentHTML('beforeend', injectedStyleTag);
  })();`;

<WebView
      startInLoadingState={true}
      source={{uri: myUri}}
      // injectedJavaScript={injectedScript}
      injectedJavaScriptBeforeContentLoaded={injectedScript}
/>

Expected behavior:
Add style tag in webview for iOS
Screenshots/Videos:
Sorry not possible to show any screen 😢
Environment:

OS: iOS
OS version:  16.4
react-native version: 0.66.3
react-native-webview version: 11.26.0

Thanks for your help 👍

Sorry to spam solution here
https://github.com/react-native-webview/react-native-webview/issues/1779
added onMessage fix my problem
onMessage={() => {}}


[IOTDB-6080] Add batch mode in pipe-connector

coverage: 47.975% (-0.08%) from 48.052% when pulling 3e2e29434d9f5d1926788e49f312db6b3bdceb70 on pipe-batch-request into 0a90c45486de25b87b6beaab14a26a7484b0d5d6 on master.


Create Task Note: Ignore date format

Please select if your request is either something new or an enhancement

[ X] Enhancement of an existing Feature.
[ ] Request of a new feature.

Please select the area your request applies to. (Multiple selections are Possible. You can leave blank if you're not sure.)

[ ] Workspace - VSCode workspace, vaults, Intellisense/autocomplete, Dendron settings
[ ] Lookup - Dendron's Lookup Command
[ ] Views - Dendron Preview, Tree View, Side Panels in the UI
[X ] Schema - Dendron Schemas
[ ] Pod - Data import from / export to Dendron
[ ] Publish - External Site Publish
[ ] Markdown - Markdown features, such as syntax support and features

Is your feature request related to a problem? Please describe
I like the ability to create Tasks and the ability to set up a task.schema to help me sort my tasks.
I do not like using the Date to sort my tasks - for my purposes, I don't care when the tasks were created.
From help on the discord, I've created a task.schema that allows me to break my tasks into categories.
Example:
**`- id: task
title: task
parent: root
children:

pattern: "Reading"
template: task.temp
children:

pattern: "*"
template: task.temp

pattern: "Resources"
template: task.temp
children:`**

However, when I go to actually Create Task Note, it still defaults to auto-filling with the date. I think this is because 'dateFormat:' is  a required field.
Describe the solution you'd like
I would like to be able to configure the task.schema to not have the date autopopulated when creating a new note -- which I think might be achieved by not making 'dateFormat' obligatory for the dendron.yml.
Describe alternatives you've considered
A work around is to use a blank string in dendron.yml:  dateFormat: ""
However, this means that there is no autosuggestion when you first create the note. Admittedly, this is a minor inconvenience.
Additional context

Hi @JAlbair - thanks for the suggestion.  There's another feature, note traits that can get the functionality you mentioned.
You can create a custom trait, call it 'my-tasks', and customize the way the note names are generated to not include a date portion.  Furthermore, you can also have any notes created with this trait have a template auto applied, which may make it simpler than having to configure a schema + schema template for it.  Finally, you can also assign a keyboard shortcut to make it easy to create your note with your custom trait just as with task notes.
It takes a little bit of setup, but hopefully these examples can also help: https://wiki.dendron.so/notes/qw0iw9ymf725eoqnptzafd2/


Ability to provide a namespace for the models (POCOs) that are generated.

I currently use *.yaml file to generate c# controllers.  Everything (controllers, interfaces, POCOs) are put in the same namespace.
I would be nice to have to the ability to specify namespaces for the POCOs.
My.Company.Controllers - All controllers get added to this namespace
My.Company.Models - All POCOs get added to this namespace.
Furthermore, it would be nice to be able to specify namespaces for each of the generated components (i.e. interfaces, abstract classes).
Thanks!
Brian

Ah you can specify that for clients and DTOs:

but it seems we do not have this for controllers and DTOs.


Add stack trace to remote protocol ExceptionDetails

Is your feature request related to a problem? Please describe.
We currently don't get any stack trace in the Avalonia designer, meaning that problems are extremely hard to track down. For example, when the designer shows "Invalid markup" (see screenshot):

And the Avalonia Diagnostics output shows this:
23:00:59.004 [Information] 34320 Connection initialized
23:00:59.773 [Error] 34320 UpdateXamlResult error
System.Xaml.XamlException: Value cannot be null. (Parameter 'control')

It's practically impossible to know what really happened here without a stack trace.
Describe the solution you'd like
If we serialize the stack trace, we can display it in places where it matters.
I believe this commit should do the trick: https://github.com/codecat/Avalonia/commit/607f31febebe8b2e946a4168ac87669eff1e8d95
Then, we can make a change in AvaloniaVS to display the stack trace:
https://github.com/AvaloniaUI/AvaloniaVS/blob/3c210142a90d4a99f682c4df30ad8f6f03baca6f/AvaloniaVS.Shared/Services/PreviewerProcess.cs#L465
(I'm unsure how/if this would display in the Error List tab in AvaloniaVS, but that's probably an issue for that specific repository 😅)
As per contribution guidelines, I am opening an issue first, but I can have a PR ready to go. I assume it also needs some tests?
Describe alternatives you've considered
No response
Additional context
No response

https://github.com/AvaloniaUI/Avalonia/blob/db10780e15c1de4c4d02028b2ce3dfc4a4ace7ab/src/Avalonia.DesignerSupport/Remote/RemoteDesignerEntryPoint.cs#L243-L247 seems to include the full exception details in Error field.

ExceptionDetails object was supposed to be there to indicate a particular line number and line position, not to swallow all the info.

I see, I must've missed that! In that case, the required change would just be in AvaloniaVS, here:
https://github.com/AvaloniaUI/AvaloniaVS/blob/3c210142a90d4a99f682c4df30ad8f6f03baca6f/AvaloniaVS.Shared/Services/PreviewerProcess.cs#L452-L468
The ExceptionDetails is only used if Error is null or empty. Okay - I will make a PR there. 😊

Thx for your contribution @codecat 👍. This is indeed a very useful info.


Add Java Doc for SignalR Java Client TransportEnum

We added a new public class for selecting what transport to use in the SignalR Java client. Needs a quick java doc.
https://github.com/aspnet/AspNetCore/blob/master/src/SignalR/clients/java/signalr/src/main/java/com/microsoft/signalr/TransportEnum.java

Done here: https://github.com/aspnet/AspNetCore/pull/7994


feat: Enable new ui5lint version in console

This PR enables notifications in the console when there is a new version of the ui5linter.

The build is failing because of missing coverage for the newly introduced code of the notifier: https://github.com/SAP/ui5-linter/pull/57/files#diff-fa8d4e24d8399e8350f1c8bad05df53e8032ea995835bf911507015e2db61cddR25
However, it's clear that this is untestable code in terms of unit testing. In ui5-tooling/cli this is covered by the integration tests which we're unable to do here (for now), because of the transpilation step.
Adding istanbul ignore * solves the issue, but for higher Node versions, for 18.14.2, that is used for our testing environment it's not taken into account.
I'm wondering what is the possible solution here (apart from lowering the coverage thresholds for that test)?

The PR title is a little confusing to me. This does not "enable" a version in the console. It shows a hint in case a new version exists. The user still has to install it.


Dark mode by default

Hi! 😄
First all, thanks a lot for this great Homer theme. I've been using it for quite some time now and I'm still loving it. 👍
My question is quite simple and I apologize in advance in case I've missed something very obvious here: I'd like to set in my config.yml that always the dark mode is used. I've tried theme: dark, but that didn't work for me.
Any hints how I can achieve this? Thanks in advance.

I've found out. I just needed to add this code to the config.yml:
defaults:
  colorTheme: dark # One of 'auto', 'light', or 'dark'

Problem solved. :+1: