Simulation performance improvements

While investigating why the Qulacs backend does not seem to use multiple threads in my code, I noticed that very little time is spent in the actual simulation.
For testing, I used the Quantum Fourier Transform. By running either just a QFT, or a QFT and then an inverse QFT, we can make the resulting wavefunction dense or sparse, which is important for testing the performance.

Code
import tequila as tq
from math import pi
import time

SIZE = 20

def qft(size: int, inverse: bool = False) -> tq.QCircuit():
    U = tq.QCircuit()
    for i in range(size):
        U += tq.gates.H(target=i)
        for j in range(size - i - 1):
            U += tq.gates.Phase(target=i + j + 1, angle=(-1 if inverse else 1) * pi / 2 ** (j + 2))
            U += tq.gates.CRz(target=i, control=i + j + 1, angle=(-1 if inverse else 1) * pi / 2 ** (j + 1))
    return U

U = qft(SIZE)
V = qft(SIZE) + qft(SIZE, inverse=True)

start = time.time()
wfn = tq.simulate(U, backend="qulacs")
print(f"QFT time: {time.time() - start} s")

start = time.time()
wfn = tq.simulate(V, backend="qulacs")
print(f"QFT + inverse QFT time: {time.time() - start} s")

Running this code on the devel branch takes ~160 seconds for the normal QFT and ~20 seconds for the combined QFT and inverse QFT on my machine. Note that the second one is much faster even though the simulated circuit is twice as large, this is because the result is a sparse wavefunction.
When measuring the time of self.circuit.update_quantum_state(state) in do_simulate in simulator_qulacs.py (which I believe is the actual simulation), it's only ~0.17s / ~0.28s (QFT / QFT + inverse), so there is a lot of room for speedups.
All the times here are simple measurements of single runs, and not proper benchmarks, but the differences are so large that it shouldn't matter if the numbers are inaccurate.
I made four commits which speed this up:

For a dense wavefunction, a lot of time is spent in the apply_keymap function in simulate. This doesn't seem necessary when all qubits are active, since then the mapping has no effect. So I added a check that skips the keymap entirely in that case, reducing the runtime to ~24s / ~20s.

The numpy.isclose call in from_array in qubit_wavefunction.py is expensive, likely because it checks for edge cases (infinity, nan) and because it can handle arrays. Assuming we simply want to skip values close to zero, this can be done much faster using a simple comparison.
Also, we only need to create the index bitstring when we actually want to set the value, so moving it inside the if clause saves a lot of time for sparse wavefunctions. These two changes reduce the runtime to ~6s / ~0.7s.

Still in the from_array function, if the numbering of the array doesn't match the numbering of the wavefunction, a keymap is applied to adjust it. This should not be necessary because the initialize_bitstring function should already return the correct type of bitstring. However currently the returned type depends on the numbering_in parameter, changing it to the numbering_out parameter allows removing the keymap and reduces the time to ~3.7s / ~0.6s.

Reversing the bits in a bitstring is currently done by converting the integer to a binary string, reversing the characters, and converting them back to an integer. This is inefficient and can be replaced with a function that uses bit operations. An interpretation of this code is that each line flips a bit in the position of each bit, so when all position bits are flipped, the position p is moved to 31 - p. This assumes the integer has exactly 32 bit, so if it has less, this adds zeros which we can get rid of with a bitshift.
Another small optimization is to calculate the logarithm to get the bitstring length, instead of converting to a binary string and counting (the integer bit_length() method can't be used because some code passes Numpy ints). Together, this reduces the runtime to ~2.5s / ~0.6s.

In total, the speedup is ~60x / ~30x for the script above, but is likely much less for other code. I have not tested if these speedups transfer to other backends. Further improvements are definitely possible, but I think I have covered a good amount of the low hanging fruit.

some of the code you changed is still from the first prototype of tequila -- back then there wasn't much thought on speed. Would have make sense to improve it earlier, but I think it's because the effects on the variational applications are not that high. The wfn = tq.simulate(U) wavefunction simulation was initially just a bonus feature (as tq it is primarily designed for expectation values) -- But it is great to have that bonus feature accelerated :-) [especially since we also often use it for development purposes]
I need to double check code changes, but I think this is good to go.
Thank you once more!


WIP: Update attaching-files.rst

@JeffSchering I think this might still be WIP

Hi @JeffSchering, this is ready to be reviewed.

@amyblais For updating "Attaching Files" and "Sending Messages" help doc PRs, they're a significant improvement to our existing ones, thank you! (and thanks to Jeff as well!)
Wondering if you had a list of best practices that you prepared while working on the docs and if we can apply them for other help docs?
One question that comes to mind is screenshots -- should we add any the these two pages? Why or why not? (An article about screenshots that might be useful)

@jasonblais I have prepared a list of best practices for end user docs and I am currently thinking about where to add them. I had originally thought of putting them in "Documentation Guidelines" but it has more general guidelines for all documentation.
I did not add any screenshots to these documents because they are generally quite straightforward, but I can think about this further.

@amyblais Sounds good.
I think it might be okay to open a WIP PR and we can figure out where we can put it.


cant add no sniper overlay script

not really something I'm interested looking into fixing unfortunately, sorry. I believe it's also considered an exploit by many competitive leagues, just an FYI


[CSBindings] Preserve l-valueness of optional object type

Result of force unwrap is always connected to its base
optional type via OptionalObject constraint which
preserves l-valueness, so in case where object type got
inferred before optional type (because it got the
type from context e.g. parameter type of a function call),
we need to test type with and without l-value.
Resolves: rdar://problem/47967277

@swift-ci please test

@swift-ci please test source compatibility

Is this going to hurt compile time?

@jrose-apple Very unlikely, since original type gets attempted first and if it succeeds @lvalue version is not going to be attempted. This is also pretty narrow, the situation from new test - type of the optional object got deduced through generic parameter of the Set argument before its base. Usually object type would get bound only after the base type is resolved, but sometimes we get "lucky" :)

Build failed
Swift Test OS X Platform
Git Sha - 7b248f20bf4a3409586b9af5bd9e3425ff3163ac

@nathawes There is a failure in test/SourceKit/CodeComplete/complete_swiftinterface.swift on iphonesimulator-i386 doesn't seem related to my changes, not sure if that's just an intermittent error or something else.

I think Brent reverted that one.

Ok, I figured out what the problem is - implicit conversions, we have to avoid commuting bindings for optional object all together otherwise there is a risk of skipping viable solutions, bindings to that type variable should always come when its base is resolved.

@swift-ci please test source compatibility

@swift-ci please test

Build failed
Swift Test Linux Platform
Git Sha - 7b248f20bf4a3409586b9af5bd9e3425ff3163ac

Build failed
Swift Test OS X Platform
Git Sha - 7b248f20bf4a3409586b9af5bd9e3425ff3163ac


Spice Login broken

>>> spice login
Attempting to open Spice.ai authorization page in your default browser

Your auth code:

7U8G-M7KA

If the browser does not open, please visit the following URL manually:

https://spice.ai/auth/token?code=7U8GM7KA

Waiting for authentication...
Successfully logged in to Spice.ai as  ()
Using app /

>>> spiced
2024-04-26T04:50:32.992089Z  WARN runtime: Failed to initialize data connector for dataset eth_recent_transactions: Unable to attach data connector spiceai: Unable to resolve table provider: Unable to query Flight: Unable to perform handshake: status: Unauthenticated, message: "API key (password) is required.", details: [], metadata: MetadataMap { headers: {"date": "Fri, 26 Apr 2024 04:50:33 GMT", "content-type": "application/grpc", "strict-transport-security": "max-age=15724800; includeSubDomains", "alt-svc": "h3=\":443\"; ma=86400", "cf-ray": "87a3f3d91aa0aadd-SYD", "cf-cache-status": "DYNAMIC", "server": "cloudflare"} }
^C

I initially attempted spice login when my browser was not logged in.
When I logged in my browser and reran spice login, same result.

@Jeadie thanks for reporting, problem was on spice.ai side


config: Support opting into GitHub token auth

Adds a new per-project configuration to hermit.hcl
allowing opting GitHub owner/repo patterns to opt into
token-based authentication instead of anonymous.
For example:
github-auth-token {
  match = ["cashapp/*"]
}

The option accepts any number of glob patterns,
allowing for fine-grained control over which dependencies
get authenticated requests.
This will make it possible to use Hermit with private repositories
without distributing a custom build.
The plumbing for this required a small amount of refactoring:
The new hermit.LoadEnvInfo inspects a Hermit environment
and loads the configuration, but does not open the environment.
The information is later passed to the old hermit.OpenEnv function.
This separation is necessary because cache and state are inputs to
OpenEnv, but we need to inspect the environment configuration to decide
on their inputs.
Resolves #406

Thanks!


New package: ChainRulesOverloadGeneration v0.1.0

Registering package: ChainRulesOverloadGeneration
Repository: https://github.com/JuliaDiff/ChainRulesOverloadGeneration.jl
Created by: @oxinabox
Version: v0.1.0
Commit: 014f5fa9db3544b9db417de427225686eb1b5906
Reviewed by: @oxinabox
Reference: https://github.com/JuliaDiff/ChainRulesOverloadGeneration.jl/commit/014f5fa9db3544b9db417de427225686eb1b5906#commitcomment-51348216

Let's hold off on this while I validate moving the code out actually worked to make it faster.
I will ask for manual merge when we hit 3 days if deleting this comment doesn't work


The issue I'm encountering with the React-Color color picker is that I'm unable to slide and select colors. What could be the reason for this?

Have the same issue.. everything is drawn, but nothing is interactive

Did you ever resolve this? Having the same issue, using Tailwind as well.

Same issue here. I can't slide to select color, just able to select color on click.

This issue can occur if there is no color / onChange property. This is not a 100% clear when looking at the first example in the docs imo.
const [value, setValue] = useState(defaultValue)

<ChromePicker color={value} onChange={({hex}) => setValue(hex)}/>


booting from compressed + dup works in current u boot head

Latest u boot works for me, older version I tried didn't. I'm not booting Pi but should be similar.

Cool, thanks!
Sounds like you're compiling uboot from source for this?
If so, are you using a nix expression to do so? Or just manually copying it to the FAT partition?

I am compiling uboot from source. I'm just installing uboot with: dd
if=u-boot-sunxi-with-spl.bin of=/dev/sdc bs=8k seek=1
It's not pi of nix but compression + dup wasn't working with earlier u boot
for me and it is now.
On Fri, 20 Oct 2023 at 00:41, Nathan Henrie @.***>
wrote:

Cool, thanks!
Sounds like you're compiling uboot from source for this?
If so, are you using a nix expression to do so? Or just manually copying
it to the FAT partition?
—
Reply to this email directly, view it on GitHub
https://github.com/n8henrie/nixos-btrfs-pi/issues/4#issuecomment-1771016479,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAISQBGTA6HSCEU6TBHWH3DYAEU2HAVCNFSM6AAAAAA6GS63H6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONZRGAYTMNBXHE
.
You are receiving this because you authored the thread.Message ID:
@.***>

Not working for me still when I manually build from a local copy of u-boot and copy to my SD card. I'll have to tinker some more, unsure if user error on my part vs issues with the Pi.
There are a few Pi-specific patches that NixOS applies on top, unsure if the absence of these is the problem, but the package fails to compile if I go through nixpkgs (changing the src for buildUBoot) as the patches don't apply cleanly.
Thanks for the heads up, I'll leave this open and try to sort things out.

Chiming in, only just started to explore the great source of wisdom in this project as I want to do similar things though more  bar bones without btrfs and zstd.
But when I:

$ nix eval --include nixos-config=./nixos/configuration-sample.nix     --argstr system aarch64-linux     --file '<nixpkgs/nixos>'     config.boot.kernelModules
[ "bridge" "macvlan" "tap" "tun" "cpufreq_ondemand" "loop" "atkbd" ]

The kernel modules you use for initrd are not listed here, so that does not impact the booting from compressed boot, does it ?
Pardon my layman's 2c.

One more finding, the baud rate given in ll. 28 is suffixed by n8 two times.

@573
Thanks for the kind words. Not sure I understand what you're saying / asking though. Hoping you can clarify!

though more bare bones without btrfs and zstd

I have to say, BTRFS is the whole point of this project / repo, I think you can find much simpler options if you're not using BTRFS. Have you checked out nixos-generators?

The kernel modules you use for initrd are not listed here, so that does not impact the booting from compressed boot, does it ?

Sorry, what are you referring to by "that"? I think I recall that the kernel modules will automatically include / load extras they need based on the config (such as your filesystems attrset).

One more finding, the baud rate given in ll. 29 is suffixed by n8 two times.

Sorry, not sure here as well. I only see a single n8 per line. Where are you seeing two?

My other question was just a shot in the dark I didn't quite understand how initrd kernel modules worked vs. kernel modules, so please ignore that question. Sorry to have wasted your time.

Sorry to have wasted your time.

Not at all! Happy to help if I can.


KafkaConditions value matching

Summary
I have some difficulty in matching two Kafka ConsumerRecords using Assertj. Please see the example.
Example
@Slf4j
@RunWith(SpringRunner.class)
@SpringBootTest
@DirtiesContext
public class KafkaProducerTests {

  private final static String TOPIC_NAME = "greeting-topic";

  @Autowired
  private KafkaProducer kafkaProducer;

  private KafkaMessageListenerContainer<String, Greeting> container;

  private BlockingQueue<ConsumerRecord<String, Greeting>> records;

  @ClassRule
  public static EmbeddedKafkaRule embeddedKafka = new EmbeddedKafkaRule(1, true, TOPIC_NAME);

  @Before
  public void setUp() throws Exception {

    Map<String, Object> consumerProperties = KafkaTestUtils.consumerProps("greeting-group", "false", embeddedKafka.getEmbeddedKafka());
    val consumerFactory = new DefaultKafkaConsumerFactory<String, Greeting>(consumerProperties);
    val containerProperties = new ContainerProperties(TOPIC_NAME);
    container = new KafkaMessageListenerContainer<>(consumerFactory, containerProperties);

    // create a thread safe queue to store the received message
    records = new LinkedBlockingQueue<>();

    // setup a Kafka message listener
    container
        .setupMessageListener(new MessageListener<String, Greeting>() {
          @Override
          public void onMessage(
              ConsumerRecord<String, Greeting> record) {
            log.info("test-listener received message='{}'", record.toString());
            records.add(record);
          }
        });

    // start the container and underlying message listener
    container.start();

    // wait until the container has the required number of assigned partitions
    ContainerTestUtils.waitForAssignment(container, embeddedKafka.getEmbeddedKafka().getPartitionsPerTopic());
  }

  @After
  public void tearDown() {
    // stop the container
    container.stop();
  }

  @Test
  public void testSendMessageSuccessfully() throws Exception {
    Greeting greeting = new Greeting("Hello Shaun!", "Shaun");
    kafkaProducer.sendMessage(TOPIC_NAME, greeting);

    // check that the message was received
    ConsumerRecord<String, Greeting> received = records.poll(10, TimeUnit.SECONDS);

    // AssertJ Condition to check the value
     assertThat(received).has(value(greeting));
  }
}

The assert statement in third last line is giving me following error:
java.lang.AssertionError:
Expecting:
 <ConsumerRecord(topic = greeting-topic, partition = 1, offset = 0, CreateTime =<PHONE_NUMBER>418, serialized key size = -1, serialized value size = 37, headers = RecordHeaders(headers = [RecordHeader(key = __TypeId__, value = [99, 111, 109, 46, 115, 104, 97, 117, 110, 116, 104, 111, 109, 97, 115, 57, 57, 57, 46, 107, 97, 102, 107, 97, 46, 109, 111, 100, 101, 108, 46, 71, 114, 101, 101, 116, 105, 110, 103])], isReadOnly = false), key = null, value = {"msg":"Hello Shaun!","name":"Shaun"})>
to have:
 <a ConsumerRecord with 'value' Greeting(msg=Hello Shaun!, name=Shaun)>

How can I match two ConsumerRecord using Assertj?

What does you Condition looks like ?
It looks like you are trying to compare a map to a Greeting ...

@shaunthomas999 I'm closing this issue but I'm happy to reopen if you can provide us a test case reproducing it.


Added BCA option on edit_detail.html

Added BCA option in response to https://github.com/NSP-Community/NSP/issues/120

Thanks for contributing :)


Tilemap Error using AStar2D

Godot version
v3.4.beta4.mono.official [6a058cbf3]
System information
Debian 11
Issue description
When I add an collision shape in tilemap tile the editor allow me to add other collisions on top the first one.
I noticed it because I had this error in console
E 0:00:00.854   add_point: Condition "p_id < 0" is true.
  <C++ Source>  core/math/a_star.cpp:50 @ add_point()
  <Stack Trace> :0 @ void Godot.NativeCalls.godot_icall_3_43(IntPtr , IntPtr , Int32 , Godot.Vector2& , Single )()
                AStar2D.cs:71 @ void Godot.AStar2D.AddPoint(Int32 , Godot.Vector2 , Single )()
                Ground.cs:129 @ Godot.Collections.Array`1[Godot.Vector2] DesertEdge.Ground.AstarAddWalkableCells(Godot.Collections.Array )()
                Ground.cs:89 @ void DesertEdge.Ground._Ready()()

And I went in edito tilemap and I tried to delete the collision shape. At this point I noticed that there was another layer underneath - width different colour - and another one and so on.
I was in this status all the time:

Then I tried to clean the mess and I deleted all collision shapes, occlusions, regions, and even all tiles...
The error in console still appear and in the scene file I still have all tilemap data:
[node name="Ground" type="TileMap" parent="."]
tile_set = SubResource( 1 )
cell_size = Vector2( 128, 128 )
show_collision = true
collision_layer = 0
collision_mask = 16
format = 1
tile_data = PoolIntArray( 0,<PHONE_NUMBER>, 0, 1,<PHONE_NUMBER>, 0, 2,<PHONE_NUMBER>, 0, 3,<PHONE_NUMBER>, 0, 4,<PHONE_NUMBER>, 0, 5,<PHONE_NUMBER>, 0, 6,<PHONE_NUMBER>, 0, 7,<PHONE_NUMBER>, 0, 8,<PHONE_NUMBER>, 0, 9,<PHONE_NUMBER>, 0, 10,<PHONE_NUMBER>, 0, 11,<PHONE_NUMBER>, 0, 12,<PHONE_NUMBER>, 0, 13,<PHONE_NUMBER>, 0, 14,<PHONE_NUMBER>, 0, 15,<PHONE_NUMBER>, 0, 16,<PHONE_NUMBER>, 0, 17,<PHONE_NUMBER>, 0, 18,<PHONE_NUMBER>, 0, 19,<PHONE_NUMBER>, 0, 20,<PHONE_NUMBER>, 0, 21,<PHONE_NUMBER>, 0, 22,<PHONE_NUMBER>, 0, 23,<PHONE_NUMBER>, 0, 24,<PHONE_NUMBER>, 0, 25,<PHONE_NUMBER>, 0, 26,<PHONE_NUMBER>, 0, 27,<PHONE_NUMBER>, 0, 28,<PHONE_NUMBER>, 0, 29,<PHONE_NUMBER>, 0, 30,<PHONE_NUMBER>, 0, 31,<PHONE_NUMBER>, 0, 32,<PHONE_NUMBER>, 0, 33,<PHONE_NUMBER>, 0, 34,<PHONE_NUMBER>, 0, 35,<PHONE_NUMBER>, 0, 36,<PHONE_NUMBER>, 0, 37,<PHONE_NUMBER>, 0, 38,<PHONE_NUMBER>, 0, 39,<PHONE_NUMBER>, 0, 40,<PHONE_NUMBER>, 0, 41,<PHONE_NUMBER>, 0, 42,<PHONE_NUMBER>, 0, 43,<PHONE_NUMBER>, 0, 44,<PHONE_NUMBER>, 0, 45,<PHONE_NUMBER>, 0, 46,<PHONE_NUMBER>, 0, 47,<PHONE_NUMBER>, 0, 48,<PHONE_NUMBER>, 0, 49,<PHONE_NUMBER>, 0, 50,<PHONE_NUMBER>, 0, 51,<PHONE_NUMBER>, 0, 52,<PHONE_NUMBER>, 0, 53,<PHONE_NUMBER>, 0, 54,<PHONE_NUMBER>, 0, 55,<PHONE_NUMBER>, 0, 56,<PHONE_NUMBER>, 0, 57,<PHONE_NUMBER>, 0, 58,<PHONE_NUMBER>, 0, 59,<PHONE_NUMBER>, 0, 60,<PHONE_NUMBER>, 0, 61,<PHONE_NUMBER>, 0, 62,<PHONE_NUMBER>, 0, 63,<PHONE_NUMBER>, 0, 64,<PHONE_NUMBER>, 0, 65,<PHONE_NUMBER>, 0, 66,<PHONE_NUMBER>, 0, 67,<PHONE_NUMBER>, 0, 68,<PHONE_NUMBER>, 0, 69,

while I don't have anything in design:

Steps to reproduce
See before
Minimal reproduction project
NA

@git2013vb Please upload a minimal reproduction project to make this easier to troubleshoot.

When I add an collision shape in tilemap tile the editor allow me to add other collisions on top the first one.
I noticed it because I had this error in console
E 0:00:00.854   add_point: Condition "p_id < 0" is true.
  <C++ Source>  core/math/a_star.cpp:50 @ add_point()
  <Stack Trace> :0 @ void Godot.NativeCalls.godot_icall_3_43(IntPtr , IntPtr , Int32 , Godot.Vector2& , Single )()
                AStar2D.cs:71 @ void Godot.AStar2D.AddPoint(Int32 , Godot.Vector2 , Single )()
                Ground.cs:129 @ Godot.Collections.Array`1[Godot.Vector2] DesertEdge.Ground.AstarAddWalkableCells(Godot.Collections.Array )()
                Ground.cs:89 @ void DesertEdge.Ground._Ready()()

This error is trigerred by you trying to add a point with negative index to AStar2D, it has nothing to do with the tiles and their collision shapes. I guess some understandable error message needs to be added in here:
https://github.com/godotengine/godot/blob/d4a84be4fb91ef425b4ca55f3d24464bbd9906c9/core/math/a_star.cpp#L49-L52

And I went in edito tilemap and I tried to delete the collision shape. At this point I noticed that there was another layer underneath - width different colour - and another one and so on.

Can't notice anything like this. I can see you have a collision shape set for 8 of your tiles, the same data is in the scene file, everything looks just fine:

(...)
[sub_resource type="ConvexPolygonShape2D" id=2]
points = PoolVector2Array( 128, 128, 0, 128, 0, 0, 128, 0 )

[sub_resource type="ConvexPolygonShape2D" id=3]
points = PoolVector2Array( 128, 128, 0, 128, 0, 0, 128, 0 )

[sub_resource type="ConvexPolygonShape2D" id=4]
points = PoolVector2Array( 128, 128, 0, 128, 0, 0, 128, 0 )

[sub_resource type="ConvexPolygonShape2D" id=5]
points = PoolVector2Array( 128, 128, 0, 128, 0, 0, 128, 0 )

[sub_resource type="ConvexPolygonShape2D" id=6]
points = PoolVector2Array( 128, 128, 0, 128, 0, 0, 128, 0 )

[sub_resource type="ConvexPolygonShape2D" id=7]
points = PoolVector2Array( 128, 128, 0, 128, 0, 0, 128, 0 )

[sub_resource type="ConvexPolygonShape2D" id=8]
points = PoolVector2Array( 128, 128, 0, 128, 0, 0, 128, 0 )

[sub_resource type="ConvexPolygonShape2D" id=9]
points = PoolVector2Array( 128, 128, 0, 128, 0, 0, 128, 0 )

[sub_resource type="TileSet" id=10]
(...)
36/shapes = [ {
"autotile_coord": Vector2( 0, 0 ),
"one_way": false,
"one_way_margin": 1.0,
"shape": SubResource( 2 ),
"shape_transform": Transform2D( 1, 0, 0, 1, 0, 0 )
} ]
(...) // and so on for the other tiles

Similarly can't see a problem with deleting collision shapes:

To sum up: I don't see a single bug in here, just some buggy/incorrect code of yours, @git2013vb .

Can't notice anything like this.
Similarly can't see a problem with deleting collision shapes:
You can't them any-more. I deleted the old map. (was a map created with godot version 3 that is supposed to be compatible right?)

To sum up: I don't see a single bug in here,
Its not to early to say that? How to explain the wrong path that happen also in empty map?
I documentation there is no warning/instructions/examples about not to make a map in negative coordinates. Coordinate that are allowed to use)
The usually way people use the editor is not what developer are used to test and to think  it will be used. Without a clear guideline people like myself are going to delete/add/rename/move (repeat again in not same order) any map parts.  Also how about non documented API?  How I 'm supposed to use them in correct way if  there is just a syntax ? I can read other people mind? Sometime I can but not all the time. :)
last thing: How about the weird path mentioned from my screenshots? It happen even without any tile on map.
Thanks.
ps: any eta to have a more clear interface?

Now i setup the map starting from 0,0  but I have another error:
E 0:00:05.321   get_point_path: Condition "!to_exists" is true. Returned: PoolVector<Vector2>()
  <C++ Source>  core/math/a_star.cpp:700 @ get_point_path()
  <Stack Trace> :0 @ Godot.Vector2[] Godot.NativeCalls.godot_icall_2_50(IntPtr , IntPtr , Int32 , Int32 )()
                AStar2D.cs:339 @ Godot.Vector2[] Godot.AStar2D.GetPointPath(Int32 , Int32 )()
                Ground.cs:231 @ void DesertEdge.Ground.RecalculatePath()()
                Ground.cs:38 @ void DesertEdge.Ground.set_PathStartPosition(Godot.Vector2 )()
                Ground.cs:204 @ Godot.Collections.Array`1[Godot.Vector2] DesertEdge.Ground.GetAstarPath(Godot.Vector2 , Godot.Vector2 )()
                Ground.cs:108 @ Godot.Collections.Array`1[Godot.Vector2] DesertEdge.Ground.SetNewDestination(Godot.Vector2 , Godot.Vector2 )()
                :0 @ System.Object Godot.NativeCalls.godot_icall_2_537(IntPtr , IntPtr , System.String , System.Object[] )()
                Object.cs:377 @ System.Object Godot.Object.Call(System.String , System.Object[] )()
                Peer.cs:76 @ void DesertEdge.Peer.ChangeState(DesertEdge.Peer+STATES )()
                Peer.cs:66 @ void DesertEdge.Peer._UnhandledInput(Godot.InputEvent )()

the point found are:

(749195) 17:05:26.877  :DEBUG	Borderland[Void SpawnMyPlayer(Godot.Vector2, Godot.Vector2, Int32)]
(749195) 17:05:26.884  :DEBUG	Borderland[Void SpawnMyPlayer(Godot.Vector2, Godot.Vector2, Int32)] Spawned peer 0 at (200, 200) dest (200, 200)
(749195) 17:05:31.266  :DEBUG	Ground[Void RecalculatePath()] 78 0
(749195) 17:05:31.270  :DEBUG	Ground[Void RecalculatePath()] 78 1493
(749195) 17:05:31.270  :DEBUG	Ground[Void RecalculatePath()] 78 1493
 Cannot open file '/root/godot/modules/mono/glue/GodotSharp/GodotSharp/Generated/GodotObjects/AStar2D.cs'.
 Failed to read file: '/root/godot/modules/mono/glue/GodotSharp/GodotSharp/Generated/GodotObjects/AStar2D.cs'.

this means I need to start the TileMap from 1,1 and not from 0,0?

You can't see them any-more. I deleted the old map. (was a map created with godot version 3 that is supposed to be compatible right?)

Which exact version? Personally I'm not sure whether there are some compatibility breakages between some 3.x versions but maybe someone else could clarify it for you if you'd provide more details.
So yeah, maybe you've indeed faced some bug, maybe not, I simply don't know. I haven't seen it in action and I don't know how to reproduce it. Without a way to reproduce it it's really hard to track it down. :wink: So if you have any more details about what exactly happend and what steps leaded to it then please provide such details (for example in your original post you didn't say a word about migrating from some older version).

To sum up: I don't see a single bug in here,

Its not to early to say that?

No, currently I don't see a single bug in here. Nothing more, nothing less.

How to explain the wrong path that happen also in empty map?
Or a normal map (just positive tiles) that have the errors?
(...)
last thing: How about the weird path mentioned from my screenshots? It happen even without any tile on map.

Incorrect logic in your code. Here you go, your project "a little" modified: TestTileSet.zip, I see no errors. I think the main problem with your logic was incorrect in-AStar2D point id calculation from the in-TileMap cell coords. But that's not a place to fix the issues with your code logic. This is a bug tracker. If you have problems with your code (or if you're not really sure if you're facing an in-engine bug) then visit some of the community channels, there are plenty of helpful people in there.

I documentation there is no warning/instructions/examples about not to make a map in negative coordinates. Coordinate that are allowed to use)

AStar2D.add_point: "(...) The id must be 0 or larger, (...)"

The usually way people use the editor is not what developer are used to test and to think it will be used. Without a clear guideline people like myself are going to delete/add/rename/move (repeat again in not same order) any map parts.

Seems like for some reason you think that AStar2D and TileMap depends on each other. They're of course independent of each other, I have no idea why would anyone think otherwise. If there's some dependency between these two, it's because of your own code.

Also how about non documented API? How I 'm supposed to use them in correct way if there is just a syntax ? I can read other people mind? Sometime I can but not all the time. :)

What non documented API? Please be more specific.
If you're talking about online C# API documentation then I have no idea if it's planned or (if it's planned) what's the current state of it. Currently you've got this section in the docs and in IDE autocompletion/docs. Also you can always refer to GDScript's API, it's mostly the same.

You show me some source code in c++. I barely work in C#... How I'm supposed to understand that one without the context/knowledge ? To use this game engine I need to be an expert like yourself? How you assume I'm that?

Well that part wasn't addressed directly to you, rather to anyone reading it (even to myself :smile: ). I guess you could've interpret it this way, my bad.

ps: any eta to have a more clear interface?

No idea what you're asking about.

Also where are the ID that I need when I use this method? GetUsedCellsById

Well, that's tile ID. I guess the answer you're expecting (not sure about this) is: in the TileSet. Anyway, this question doesn't really belong in here. How is it related to the issue you've reported? As I've mentioned there are community channels for such questions. And if you want to report an issue with the documentation then please do it, but it's not the place for it:

Seems like there are tons of info that are not allowed to be know to common users - its a military secret? I feel mistreated. And is not the first time.

Again, that's just offtopic. I kinda feel mistreated because you're not really talking about your bug in here.

Again, that's just offtopic. I kinda feel mistreated because you're not really talking about your bug in here.

Apologise.
You right. I was off topic. And yes I was "porting" a map from an old version ( still same main release - 3v - where was possible to set negative numbers). So back the time my logic was sound. Also  agree about documentation that is not the right place.
Back on track. Last zip file contain a project that show an error related to AStar2D. Did you take a look? It don't seem to me you mentioned anything related to it. It is a bug?
Thanks

( still same main release - 3v - where was possible to set negative numbers)

I've just checked it and the check disallowing negative ids in AStar::add_point method is in the source code since AStar was added... which hapened almost 5 years ago (something between 2.0 and 2.1 versions if I've checked correctly). So as of today points with negative ids has been disallowed in Astar (and AStar2D) in all 3.x versions.
I suspect you're talking about cell coords in the TileMap, not about ids in the AStar2D. As I've already mentioned it in my previous comment, these are unrelated. And cell coords in the TileMap can be negative, yes.

Back on track. Last zip file contain a project that show an error related to AStar2D. Did you take a look? It don't seem to me you mentioned anything related to it. It is a bug?

I indeed didn't take a look at it earlier. I've assumed the main issue here is your code/logic because I've already seen there was no errors after I've modified your project a little (have you checked out that modified project I've linked in my previous comment?). Now I've looked at that last zip of yours and I was right, the issue is, again, your logic:

Your in editor map size (in cells) is (78, 78), not (77, 77) which is hard coded by you. Your first cell is (0, 0), not (1, 1).
In AstarAddWalkableCells method for both x and y you're iterating from 1 instead of from 0. Again, your first cell is (0, 0), not (1, 1).

So yeah, this is an issue you could have easily solved by asking for help in some community channel, not here (and you'd most likely solve it faster that way).
As of now, I'd say some error messages in AStar should be made easier to understand and that's all. I'll later open a PR for it (and I'll ping you so you could give some feedback about added error messages).

Feel free to close this issue when you think is the right time. :)


Do not search for MPI with warnings enabled

Description and Context

When finding MPI with -Wextra on, a warning is reported in some deprecated CXX bindings. Avoid this by moving the modification of CMAKE_CXX_FLAGS  behind the find_package() call. This avoids issues when users set -Werror in their CMAKE_CXX_FLAGS variable.
How Has This Been Tested?

Local build.
Checklist

[ ] My commit messages mention the appropriate GitHub issue numbers and are longer than one line where appropriate.
[ ] I have added/updated documentation where necessary.

Additional Information

Interested Parties / Possible Reviewers

FYI @amgebauer

Pipeline passed, I am not that familiar with the cmake setup of MIRCO, but I think this looks good to me. @RShaw026 , @mayrmt any objections?

have you seen problems in your local build?

@mayrmt No.

@isteinbrecher I do not have any objections.


Remove lazy_static dependency

Split off from rust-lang/rust#124475. The functionality of the lazy_static crate is now available in the standard library as OnceLock. Rustfmt can now use this directly and drop the dependency.

Running our Diff Check Job, and assuming this passes we'll be good to go here

🤔 hmmm the job failed when comparing the output from current HEAD (rustfmt 1.7.0-nightly (d5f1200 2024-05-01)) and your latest commit (rustfmt 1.7.0-nightly (54dfcef 2024-05-02)). Surprisingly, compiling both versions of rustfmt locally and running them produces the same output when run on these input snippets, so I'm not 100% what's going on. I'm rerunning the job.
For reference here's what the diffs looked like:
Diff in /tmp/rust-lang-rust-EDALDBzK/tests/run-make/rustdoc-scrape-examples-macros/src/lib.rs:8:

 #[macro_export]
 macro_rules! a_rules_macro {
-  ($e:expr) => { ($e, foobar::f()); }
+    ($e:expr) => {
+        ($e, foobar::f());
+    };
 }

Diff in /tmp/rust-lang-rust-EDALDBzK/tests/run-make/rustdoc-scrape-examples-macros/examples/ex.rs:8:

 #[an_attr_macro]
 fn a() {
-  f(); // no
+    f(); // no
 }

 #[an_attr_macro(with_span)]
Diff in /tmp/rust-lang-rust-EDALDBzK/tests/run-make/rustdoc-scrape-examples-macros/examples/ex.rs:15:
 fn b() {
-  f(); // yes
+    f(); // yes
 }

 fn c() {
Diff in /tmp/rust-lang-rust-EDALDBzK/tests/run-make/rustdoc-scrape-examples-macros/examples/ex.rs:20:
-  a_rules_macro!(f()); // yes
+    a_rules_macro!(f()); // yes
Diff in /tmp/rust-lang-rust-EDALDBzK/tests/run-make/rustdoc-scrape-examples-whitespace/examples/ex.rs:1:
 struct Foo;
 impl Foo {
-  fn bar() { foobar::ok(); }
+    fn bar() {
+        foobar::ok();
+    }
@ -41252,4 +41230,4 @@ Diff in /tmp/rust-lang-rust-EDALDBzK/tests/run-make/rustdoc-scrape-examples-macr
 fn d() {
Diff in /tmp/rust-lang-rust-EDALDBzK/tests/run-make/rustdoc-scrape-examples-macros/examples/ex.rs:24:
-  a_rules_macro!(()); // no
+    a_rules_macro!(()); // no
 fn main() {
Diff in /tmp/rust-lang-rust-EDALDBzK/tests/run-make/rustdoc-scrape-examples-whitespace/examples/ex.rs:7:
-  Foo::bar();
+    Foo::bar();
@ -41258,4 +41236,12 @@ Diff in /tmp/rust-lang-rust-EDALDBzK/tests/run-make/rustdoc-scrape-examples-macr
-fn main(){}
+fn main() {}

Diff in /tmp/rust-lang-rust-EDALDBzK/tests/run-make/wasm-exceptions-nostd/src/arena_alloc.rs:14:
Diff in /tmp/rust-lang-rust-EDALDBzK/tests/run-make/wasm-exceptions-nostd/src/lib.rs:1:
 #![no_std]
 #![crate_type = "cdylib"]
-
 // Allow a few unstable features because we create a panic
 // runtime for native wasm exceptions from scratch
-
 #![feature(core_intrinsics)]
 #![feature(lang_items)]
 #![feature(link_llvm_intrinsics)]
Diff in /tmp/rust-lang-rust-EDALDBzK/tests/run-make/wasm-exceptions-nostd/src/lib.rs:39:
     let data = 0x1234usize as *mut u8; // Something to recognize
@ -41[26](https://github.com/rust-lang/rustfmt/actions/runs/9166837698/job/25203001180#step:4:27)3,6 +41249,31 @@ Diff in /tmp/rust-lang-rust-EDALDBzK/tests/run-make/wasm-exceptions-nostd/src/ar
 impl ArenaAllocator {
     pub const fn new() -> Self {
-        Self {
-            arena: UnsafeCell::new(Arena::new()),
-        }
+        Self { arena: UnsafeCell::new(Arena::new()) }
     unsafe {
-        core::intrinsics::catch_unwind(|data: *mut u8| {
-            let _log_on_drop = LogOnDrop;
+        core::intrinsics::catch_unwind(
+            |data: *mut u8| {
+                let _log_on_drop = LogOnDrop;

-            logging::log_str(&alloc::format!("`r#try` called with ptr {:?}", data));
-            let x = [12];
-            let _ = x[4]; // should panic
+                logging::log_str(&alloc::format!("`r#try` called with ptr {:?}", data));
+                let x = [12];
+                let _ = x[4]; // should panic

-            logging::log_str("This line should not be visible! :(");
-        }, data, |data, exception| {
-            let exception = *Box::from_raw(exception as *mut String);
-            logging::log_str("Caught something!");
-            logging::log_str(&alloc::format!("  data     : {:?}", data));
-            logging::log_str(&alloc::format!("  exception: {:?}", exception));
-        });
+                logging::log_str("This line should not be visible! :(");
+            },
+            data,
+            |data, exception| {
+                let exception = *Box::from_raw(exception as *mut String);
+                logging::log_str("Caught something!");
+                logging::log_str(&alloc::format!("  data     : {:?}", data));
+                logging::log_str(&alloc::format!("  exception: {:?}", exception));
+            },
+        );
@ -41[27](https://github.com/rust-lang/rustfmt/actions/runs/9166837698/job/25203001180#step:4:28)0 +41280,0 @@ Diff in /tmp/rust-lang-rust-EDALDBzK/tests/run-make/wasm-exceptions-nostd/src/ar
 }
@ -41272 +41[28](https://github.com/rust-lang/rustfmt/actions/runs/9166837698/job/25203001180#step:4:29)2,4 @@ Diff in /tmp/rust-lang-rust-EDALDBzK/tests/run-make/wasm-exceptions-nostd/src/ar
Diff in /tmp/rust-lang-rust-EDALDBzK/tests/run-make/wasm-exceptions-nostd/src/arena_alloc.rs:42:
     logging::log_str("This program terminates correctly.");
Diff in /tmp/rust-lang-rust-EDALDBzK/tests/run-make/wasm-exceptions-nostd/src/panicking.rs:17:
     use alloc::boxed::Box;
     use alloc::string::ToString;
@ -[41](https://github.com/rust-lang/rustfmt/actions/runs/9166837698/job/25203001180#step:4:42)274,10 +41287,8 @@ Diff in /tmp/rust-lang-rust-EDALDBzK/tests/run-make/wasm-exceptions-nostd/src/ar
 impl Arena {
     pub const fn new() -> Self {
-        Self {
-            buf: [0x55; ARENA_SIZE],
-            allocated: 0,
-        }
+        Self { buf: [0x55; ARENA_SIZE], allocated: 0 }
     }

     pub unsafe fn alloc(&mut self, layout: Layout) -> *mut u8 {
-    let msg = info
-        .message()
-        .map(|msg| msg.to_string())
-        .unwrap_or("(no message)".to_string());
+    let msg = info.message().map(|msg| msg.to_string()).unwrap_or("(no message)".to_string());
     let exception = Box::new(msg.to_string());
     unsafe {
         let exception_raw = Box::into_raw(exception);

I think this might just be an issue with the CI job, but I'll need some more time to look into it

Seems like it was a temporary CI issue, but now the job is passing. Thanks again for your help on this!


⚠ Processors has degraded performance

In 31e7d64, Processors ($STATUS_URL) experienced degraded performance:

HTTP code: 200
Response time: 51 ms

Resolved: Processors performance has improved in 6529f3b.


Adding Conversion Tools

I think we should add some unit converters.

Distance
Temperature
Weight
Number Systems
Data Storage
Color

Good idea.


WIP - upgrade day, do not merge yet.

resolve the AWS region specific issues from the end of this trail of woe:  https://github.com/samsung-cnct/k2/issues/159


python3Packages.mutesync: init at 0.0.1

Motivation for this change
Python module for interacting with mutesync buttons
https://github.com/currentoor/pymutesync
This is a new Home Assistant dependency (> 2021.5.x)
ToDo:

[ ] Update component-packages
[ ] Enable tests

Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 121848 run on x86_64-linux 1

2 packages built:

python38Packages.mutesync
python39Packages.mutesync

Result of nixpkgs-review pr 121848 at d41ccd8c run on aarch64-linux 1

2 packages built successfully:

python38Packages.mutesync
python39Packages.mutesync

https://github.com/currentoor/pymutesync/pull/1 was not new release so far.

Result of nixpkgs-review pr 121848 run on x86_64-linux 1

3 packages built:

home-assistant
python38Packages.mutesync
python39Packages.mutesync


Wrong Channel names in Home Assistant

I am using the Sonoff 4ch Pro R2. I have set "reload: always" in my configuration.yaml file, and I see in the .sonoff.json the correct names for each channel, but Home Assistant is somehow showing the name of the Ch2 for Ch1 and the name of Ch1 for Ch2.

Can you share this device with me<EMAIL_ADDRESS>

I am unable to share with your email, I get "Failed to share. Please try again.".

Are you using ewelink mobile app version 4? Check about info.

Yes, using app version 4.1.0 on Android.

Ok. Please send sonoff.json to my email. You can hide private data.

After fiddling with HA restarts and renames in the eWelink app, I was able to get it to work. The entity names finally reflected the names in the app, but Lovelace would still not update the entity names in the entity card. By removing and adding the channels again in lovelace, it finally took the correct names. My issue is solved...


Provide on/off toggle for autoplay of stories embedded via Story URL

Feature Description
Currently, Web Stories that are embedded in pages via any of the Latest Stories or Selected Stories options in Gutenberg (i.e. Grid, List, etc.) do not auto-play. However, stories that embedded via Story URL do auto-play. Per https://wordpress.org/support/topic/stop-auto-load-when-web-stories-embedded-in-a-page/, users may not want these stories to auto-play as they are not actually being embedded as a single story in a page, but could be laid out on a page using Gutenberg blocks or other tools.
Alternatives Considered
Disabling auto-play altogether for Story URL embeds, but I do think there are good use cases for it.

Do not alter or remove anything below. The following sections will be managed by moderators only.
Acceptance Criteria

Implementation Brief

Duplicate of #6894


implement default, object & tuple as magics, full object constructors

closes #276
Object constructors and the default object magic both build an object constructor containing every field in the object constructor: first starting with the fields of the most shallow base type of the object type (if it exists), then of its base type and so on, and finally adding the fields from the original object type. This order is the same one used in the VM in the old compiler, could be changed.
Object constructors build a table of the given field assignments first, then when the output object constructor is being built, the table is looked up for each field to see if it has been set and the assignment is used if it has. I'm not sure what the optimal way to do this is. Currently it looks up the object fields when initially going through the object constructor and maps the assignment to the field symbol ID. We could also map to the field name strings as well which would save iterations over the fields, this would require that we get the basename from each field and look that up when building the output object constructor (and don't bother when the field table is empty). But maybe it has pitfalls, it's not 1-to-1 with the field access syntax so I didn't start with it. I'm guessing we should optimize for most of the object fields being set in the constructor since this is going to be the case for typed AST and is reasonable enough for user code as well. I would guess the second option is better for this but maybe there's some method I'm not seeing.
Edit: Mapping to the symbol IDs is probably better for typed AST if we add the symbol IDs directly for symbol tokens. Now, it checks if the symbol token is a field symbol, and uses it directly for the mapping if it is (otherwise converts it to an identifier and looks it up). If we want to protect against field symbols belonging to other objects (after macro manipulation for example) then maybe we can build the set of field symbol IDs by iterating over the object type first.
Typevar symbols are also declared globally now for generic procs in system to work, it could be restricted to typevars in exported routines/types but maybe this would be too complex or incorrect.

Please rebase.


ValueError: min_samples may not be larger than number of samples: n_samples = 1.

Thank you for sharing this project,and I encounter a problem. please!
Processing...
 18%|█████████████████████████████████▏                                                                                | 8/45 [00:09<00:44,  1.20s/it]
[2024-07-22 16:12:24,376][src.utils.utils][ERROR] -
Traceback (most recent call last):
  File "/home/clz/PycharmProjects/DBTunnel3D/superpoint_transformer/src/utils/utils.py", line 45, in wrap
    metric_dict, object_dict = task_func(cfg=cfg)
  File "src/train.py", line 114, in train
    trainer.fit(model=model, datamodule=datamodule, ckpt_path=cfg.get("ckpt_path"))
  File "/home/clz/anaconda3/envs/spt/lib/python3.8/site-packages/pytorch_lightning/trainer/trainer.py", line 543, in fit
    call._call_and_handle_interrupt(
  File "/home/clz/anaconda3/envs/spt/lib/python3.8/site-packages/pytorch_lightning/trainer/call.py", line 44, in _call_and_handle_interrupt
    return trainer_fn(*args, **kwargs)
  File "/home/clz/anaconda3/envs/spt/lib/python3.8/site-packages/pytorch_lightning/trainer/trainer.py", line 579, in _fit_impl
    self._run(model, ckpt_path=ckpt_path)
  File "/home/clz/anaconda3/envs/spt/lib/python3.8/site-packages/pytorch_lightning/trainer/trainer.py", line 946, in _run
    self._data_connector.prepare_data()
  File "/home/clz/anaconda3/envs/spt/lib/python3.8/site-packages/pytorch_lightning/trainer/connectors/data_connector.py", line 93, in prepare_data
    call._call_lightning_datamodule_hook(trainer, "prepare_data")
  File "/home/clz/anaconda3/envs/spt/lib/python3.8/site-packages/pytorch_lightning/trainer/call.py", line 181, in _call_lightning_datamodule_hook
    return fn(*args, **kwargs)
  File "/home/clz/PycharmProjects/DBTunnel3D/superpoint_transformer/src/datamodules/base.py", line 144, in prepare_data
    self.dataset_class(
  File "/home/clz/PycharmProjects/DBTunnel3D/superpoint_transformer/src/datasets/dbtunnel.py", line 270, in __init__
    super().__init__(*args, val_mixed_in_train=False, **kwargs)  # True
  File "/home/clz/PycharmProjects/DBTunnel3D/superpoint_transformer/src/datasets/base.py", line 222, in __init__
    super().__init__(root, transform, pre_transform, pre_filter)
  File "/home/clz/anaconda3/envs/spt/lib/python3.8/site-packages/torch_geometric/data/in_memory_dataset.py", line 57, in __init__
    super().__init__(root, transform, pre_transform, pre_filter, log)
  File "/home/clz/anaconda3/envs/spt/lib/python3.8/site-packages/torch_geometric/data/dataset.py", line 97, in __init__
    self._process()
  File "/home/clz/PycharmProjects/DBTunnel3D/superpoint_transformer/src/datasets/base.py", line 648, in _process
    self.process()
  File "/home/clz/PycharmProjects/DBTunnel3D/superpoint_transformer/src/datasets/base.py", line 683, in process
    self._process_single_cloud(p)
  File "/home/clz/PycharmProjects/DBTunnel3D/superpoint_transformer/src/datasets/base.py", line 711, in _process_single_cloud
    nag = self.pre_transform(data)
  File "/home/clz/anaconda3/envs/spt/lib/python3.8/site-packages/torch_geometric/transforms/compose.py", line 24, in __call__
    data = transform(data)
  File "/home/clz/PycharmProjects/DBTunnel3D/superpoint_transformer/src/transforms/transforms.py", line 23, in __call__
    return self._process(x)
  File "/home/clz/PycharmProjects/DBTunnel3D/superpoint_transformer/src/transforms/point.py", line 250, in _process
    ransac = RANSACRegressor(random_state=0, residual_threshold=1e-2).fit(
  File "/home/clz/anaconda3/envs/spt/lib/python3.8/site-packages/sklearn/base.py", line 1152, in wrapper
    return fit_method(estimator, *args, **kwargs)
  File "/home/clz/anaconda3/envs/spt/lib/python3.8/site-packages/sklearn/linear_model/_ransac.py", line 358, in fit
    raise ValueError(
ValueError: `min_samples` may not be larger than number of samples: n_samples = 1.

As indicated in the traceback, the error comes from the sklearn's RANSACRegressor, which is used in our GroundElevation transform. The error tells you you probably do not have enough points to run RANSAC on. Check the size of the input Data passed to GroundElevation: do you have enough points there ? Investigate whether something strange is happening there. If you are working on your own point cloud and not one of the officially supported datasets, then maybe you need to adjust the GroundElevation parameters to suit your data ? For this, make sure you have a look at our documentation for GroundElevation (in the associated docstring) to understand how that works. And see how we parameterized it for other datasets, for reference.
If you ❤ or simply use this project, don't forget to give the repository a ⭐, it means a lot to us !

I encountered the same problem, and I used the DALES dataset.I downloaded it from the official website.It named DALESObjects.tar.gz.What's going on here?Please.


[FluentGrid] - Hiding elements

[FluentGrid] - Hiding elements
For faster, mobile-friendly development, use responsive display classes to show and hide elements according to device. Avoid creating entirely different versions of the same site, but instead hide elements reactively for each screen size.
To hide elements, simply use the HiddenWhen attribute by selecting one of the following values or combining them with the | operator (see Enumeration flags)
To display an element only on a given range of screen sizes, you can combine a these values. e.g. GridItemHidden.Md | GridItemHidden.Lg will display the element for all screen sizes, except on medium and large devices.

Example
<FluentGrid OnSizeEnter="@OnSizeEnterHandler"> ... </FluentGrid>

void OnSizeEnterHandler(GridItemSize size)
{
    Console.WriteLine($"Page Size: {size}");
    DemoLogger.WriteLine($"Page Size: {size}");
}

Unit Tests

Is it possible to use OnSizeEnter.HasDelegate to prevent calling FluentGridInitialize?  Avoids adding event listeners unnecessarily at the client where no event delegate was specified.

The OnSizeEnter event has been renamed OnBreakPointEnter (for better understanding).


add options for windows pack command.

ability to extract the bundle from a setup
ability to create a setup from a bundle
refactored the WindowsPackCommand for SetupPackage to be static to reduce the qty of new code
added the ability to have sub commands defined by the commands instead of nested in the Program.cs (needed to pass the IServiceProvider around).

I added these so I would only have to store a single file in our artifacts CI/CD pipeline. On final deployment, the 'other' file can be made.

P.S. I love your enthusiasm, thanks for all your PR's. If you'd like to discuss any changes before spending time on them, feel free to join our Discord and @ me!
It is technically possible to extract the nupkg from a Windows setup, but it is not possible to do that on Mac and we need to consider carefully before adding os-specific features. I also can't think of any realistic use-cases for doing this. The -full.nupkg package is "the source of truth". You really should be keeping those around longer than any other types of assets. Therefore you would not need to extract it from Setup.exe. NOTE: the .nupkg you extract from a Setup.exe is NOT a "portable" package (eg. the -Portable.zip you get). The portable zip is constructed differently than the .nupkg zip is and contains items that are not available in the .nupkg, so the naming of the commands and text is not quite right.
For the other way around, could make sense to make a command available which converts a .nupkg into a setup, but it should be cross platform and at least support windows and mac. It probably shouldn't be nested inside the pack command (the delta commands are not nested either, for example). The complexity here, as you've probably already spotted, is codesigning. We'd be duplicating a significant number of options (all the available signing for both windows & mac at least). Also creating the possibility of code signing failing the second time around, or even using different signing certificates? I don't think Apple would be happy with that.

This commit started because I wanted to store just one file in our CI pipeline, and then generate the delta, full package and the releases file when it was actually time for release. 90% of our builds never get promoted, so i really needed it to be dynamic.
I started with the "extract the nupkg from the bundle", but I ran into issues with how it was made (before i found the bundle helper methods). I finished the create setup bundle from nupkg, then went back and finished out the create nupkg from setup.
That being said, you're right, I don't have to deal with mac, we're a windows only shop and our app distribution is tiny and a fixed environment.
Without regard for ensuring that the users did actually use the same options every time, we could use interfaces on the options to ensure that the same ones were presented to the user every time. I did see all the extra codesign code, hence the static methods and I passed around the existing windows pack options rather than make something that took 7 parameters.


Makes volume changes consistent across restart

, and allows you to change volume and paddle sfx after leaving the menu.
paddle sfx settings are not saved on close, because playerprefs doesn't handle bools.  Maybe fix later. low priority.

Looking good!


pypi project description is gone

Project description

The author of this package has not provided a project description

So something is wrong either with our pyproject.toml or with PyPIs handling of the same.

readme = {file = "README.rst", content-type="text/x-rst"}

For now I'd just fix this via the project settings in PyPI, but I'm no maintainer. For the next release, we should switch to README.md

see #851 :)
I will add you as maintainer on pypi @marscher , I could't find how to fix this manually

Thanks! There is no solution anymore. Back in the day one could upload new source archive (different format) and delete the faulty one.


SwarmCallback and additional doc updates

SwarmCallback api updated to include additional parameters.
Added FAQ on how to know SN is successfully started.
Added Architecture in prerequisite.

Adding following content to Master.
SwarmCallback api updated to include additional parameters.
Added FAQ on how to know SN is successfully started.
Added Architecture in prerequisite.


Is is possible to add unidirectional handles?

Hello, very cool project and easy to use as well!
Currently handles have 2 types, source and target. Is it possible to add a both or unidirectional option as well?

This the docs, sorry! 🤦🏻


Team 1 homework 3 - Gmail API Integration Implementation

This PR implements a Gmail class that provides a clean interface for interacting with the Gmail API, enabling email querying and management capabilities.

new PR: https://github.com/Nightshade14/mAIgic-nyu/pull/4


Update Node.gitignore

Reasons for making this change:
TODO
Links to documentation supporting these rule changes:
TODO
If this is a new template:

Link to application or project’s homepage: TODO

Updated gitignore

Updated gitignore


Webhook scope tag different than new image tag

In the Modify the app code and redeploy section it is written:

Update the version number in the image's tag to v1.0.1:
docker tag appsvc-tutorial-custom-image .azurecr.io/appsvc-tutorial-custom-image:v1.0.1

However, in the previous section (Configure continuous deployment) the CI/CD webhook scope is set to latest:

-scope appsvc-tutorial-custom-image:latest

If the new image is pushed under new tag, it will not use the webook.
I think the tutorial should use the latest tag when updating the image or change the scope of the webhook.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 36d6ead7-4a59-ee55-327a-6cc1a909b6b8
Version Independent ID: d529825d-8e4e-1174-14ff-b404791ef304
Content: Tutorial: Build and run a custom image in Azure App Service - Azure App Service
Content Source: articles/app-service/tutorial-custom-container.md
Service: app-service
GitHub Login: @cephalin
Microsoft Alias: msangapu

Thanks for the feedback and bringing this to our notice. At this time we are reviewing the feedback and will update the document as appropriate.

@Rashair Thanks for reaching here! If you are receiving any error? Could you please share screen-shot to help better on this.
Further as mentioned in modify section: you make a change to the web app code, rebuild the image, and then push it to your container registry. App Service then automatically pulls the updated image from the registry to update the running web app. Once the image push is complete, the webhook notifies App Service about the push, and App Service tries to pull in the updated image.
Let us know.

There's no actual error. The logic is just not correct.

You make a change to the web app code, rebuild the image, and then push it to your container registry.
App Service then automatically pulls the updated image from the registry to update the running web app.
That's all correct, but you push it as v1.0.1 version.

Once the image push is complete, the webhook notifies App Service about the push, and App Service tries to pull in the updated image.

That's would be correct, if the version was latest not v1.0.1. The webhook only reacts to the changes of latest image because of the defined scope:
   az acr webhook create --name appserviceCD --registry  --uri '' --actions push --scope appsvc-tutorial-custom-image:latest
See here: https://docs.microsoft.com/en-us/cli/azure/acr/webhook?view=azure-cli-latest#az_acr_webhook_create-optional-parameters

@Rashair The PR has been created for this, once reviewed by author will be visible. Will keep you posted.
We will now proceed to close this thread. If there are further questions regarding this matter, please let us know.

Can you link the PR?


change schedSpec to schedulingSpec and note M1 image for echo server

Regarding the issue https://github.com/project-codeflare/multi-cluster-app-dispatcher/issues/332, this PR made a few small update on tutorial doc as concluded below.

update schedSpec to schedulingSpec
add note of valid image for Mac M1 (refer to image by minikube project, https://github.com/kubernetes/minikube/pull/15397)

Signed-off-by: Sunyanan Choochotkaew<EMAIL_ADDRESS>

Thanks @sunya-ch for the contribution and @z103cb for the review, LGTM


just a typo in constraintLayout

there was a c missing in constraintLayout
BTW, i like the structure and your figures are very effective in explaining library modules/feature modules to my colleagues, so thank you.

Thank you!


[Feature Request] allow user to easily check versions

Is your feature request related to a problem?
While reporting issues, uesrs are supposed to fill in the version of ctimer. However it is not easily accessible without reading the code.
Describe the solution you'd like
A --version option on launching ctimer.

https://packaging.python.org/guides/single-sourcing-package-version/#single-sourcing-the-version

@tai271828 Thanks for the PR. The current implementation of version is hard-coded. Could you try single sourcing package version number using setup.cfg?
Some hints:
https://stackoverflow.com/questions/60430112/single-sourcing-package-version-for-setup-cfg-python-projects


/post does not return multiple values with same key in form data

Raw POST request data:
POST http://www.httpbin.org/post HTTP/1.1
Host: www.httpbin.org
Content-Length: 7
Content-Type: application/x-www-form-urlencoded
Accept-Encoding: identity, deflate, compress, gzip
Accept: */*
User-Agent: python-requests/0.8.2

foo=bar&foo=baz

Response:
>> r = requests.post('http://www.httpbin.org/post', data={'foo': ['bar', 'baz']})
>> json.loads(r.content)['form']
>> {u'foo': u'bar'}

I took a look at what was going on, and it seems that the cause of the problem is the Flask response form-data MultiDict being converted to json.

It behaves like a normal dict thus all dict functions will only return the first value when multiple values for one key are found.

So by converting it to json, multiple values for the same key are lost.
One solution would be to put multiple values for the same keys into lists, thus making them representable in json:
form = {}
for key in request.form.keys():
    values = request.form.getlist(key)
    if len(values) == 1:
        form[key] = values[0]
    else:
        form[key] = values

Correct. This is what we do in requests (except reverse).

That's what to_dict method does:
to_dict(flat=True)
    Return the contents as regular dict. If flat is True the returned dict will only have the first item present, if flat is False all values
will be returned as lists.

Thanks piotr, didn't see that method.


MudButtonGroup: Add visual state for clicked button

Feature request type
Enhance component
Component name
MudButtonGroup
Is your feature request related to a problem?
I use the MudButtonGroup to enable users to make a selection: Today | Yesterday | This week | This month
Clicking on of these buttons will then retrieve logging.
The issue is that you need to remember which button you clicked as there is no visual indicator.
Describe the solution you'd like
The clicked button from the MudButtonGroup should have a visual indicator that it was clicked.
Have you seen this feature anywhere else?
No response
Describe alternatives you've considered
For now I use the MudRadioGroup.
Pull Request

[ ] I would like to do a Pull Request

Code of Conduct

[X] I agree to follow this project's Code of Conduct

There is an open pull request for a new component which does this:
https://github.com/MudBlazor/MudBlazor/pull/7309
Hope it will be merged soon...

There is an open pull request for a new component which does this:

Indeed. I totally forgot about it!

Reopening this as MudToggleGroup is a whole new component and may or may not get merged.

See PRs #7309 and #7948

See PRs #7309 and #7948

Great work guys!

Not yet merged. This issue will be closed when the PR is merged automatically


Fix proofreading warnings

I think the title says enough.
There were some issues/typos in the CCLA text.

@Shredder121 Thanks for the PR!
Unfortuantely we cannot merge this as is because it will break in production. This will happen because this schema was already merged and there is a table that validates the checksum. We need a new SQL file that will update the table to the new values. Any chance you could provide this?

AH! Yes that makes sense.
What naming should I use?
Is it still V1, or V2?

Thanks for the fast reply. Let's go with V1_3__fix-typos.sql

I added a new file with the contents of the previous file with the typos fixed.
You can verify using this command:
$ git show 0f50e3f --find-copies-harder

Or optionally, to minimize the diff:
$ git show 0f50e3f --find-copies-harder --color-words

I would appreciate it if you could comment on my syntax.
I wasn't quite sure about that name parameter.
Usually that's an SQL keyword, so if I have to quote anything in a specific way, then let me know.
Locally it works for me, so I can't quite tell.

@Shredder121 Thanks for the update! This is merged via 6cb0b03c29efe0070d88e914aeba500318967612

You can verify using this command

Thanks for the tip. I use Beyond Compare for stuff like this :)

Usually that's an SQL keyword, so if I have to quote anything in a specific way, then let me know.
Locally it works for me, so I can't quite tell.

It works fine for me and tested fine in our staging environment. This is now pushed to master so it will build and deploy to prod shortly.
Thanks again!

Thanks for the tip. I use Beyond Compare for stuff like this :)

No problem, I just wanted to give you a pointer on how to verify my copy-paste work.
But another tool is fine as well.

It works fine for me and tested fine in our staging environment.

Yes, locally I saw the same, but I wasn't sure on whether it would deploy or not.
Good to hear/see that it did!
Thank you as well, for your time!


Checks if peers are in the right state before trying to create the volume

Sometimes the peer probe will not go well and then the initial create will fail, this runs gluster peer status and ensures the peers are in the correct state (In cluster/connected). If not, it'll run a peer detach and a peer probe. Not sure if it should do this or just exit to be honest, but it definitely shouldn't try to do a volume create without checking first.

Can you add warn log output if the reprobe happens?

After some more testing, I've changed my mind and I don't think this is a good idea. I'm going to write another solution to this.

sounds good, thanks


Class 'Kordy\Ticketit\Models\Comment' not found

Hi!
I really don't know if this issue is related to your project or just my configuration is wrong. I'm just asking for your help, I don't have a clue what's causing this.
So after running php artisan clear-compiled I always get the following error message:
> php artisan clear-compiled
PHP Fatal error:  Class 'Kordy\Ticketit\Models\Comment' not found in /var/www/vendor/kordy/ticketit/src/TicketitServiceProvider.php on line 33

  [Symfony\Component\Debug\Exception\FatalErrorException]
  Class 'Kordy\Ticketit\Models\Comment' not found

Script php artisan clear-compiled handling the post-update-cmd event returned with an error

  [RuntimeException]
  Error Output: PHP Fatal error:  Class 'Kordy\Ticketit\Models\Comment' not found in /var/www/vendor/kordy/ticketit/src/TicketitServiceProvider.php on line 33

After this when I try to run any page I get the above error.
To solve this, I usually do the following:
I comment out the service provider from my config/app.php file:
//Kordy\Ticketit\TicketitServiceProvider::class,

Then I run
$ php artisan clear-compiled
$ php artisan optimize

Then I remove the comment from config/app.php:
Kordy\Ticketit\TicketitServiceProvider::class,

After these steps, everything works. But after a while it's a bit inconvenient.
Can you suggest something, what could I do?

I could not regenerate the error, following the standard way of installing and removing the package
Install:

composer require kordy/ticketit
add Kordy\Ticketit\TicketitServiceProvider::class, to app.php config

Removing:

remove Kordy\Ticketit\TicketitServiceProvider::class, from app.php config
composer remove kordy/ticketit

vagrant@homestead:~/Code/ticketit2$ composer remove kordy/ticketit
> php artisan clear-compiled
Loading composer repositories with package information
Updating dependencies (including require-dev)
  - Removing kordy/ticketit (v0.0.5)
Writing lock file
Generating autoload files
> php artisan optimize
Generating optimized class loader
vagrant@homestead:~/Code/ticketit2$ php artisan clear-compile
vagrant@homestead:~/Code/ticketit2$ php artisan optimize
Generating optimized class loader
vagrant@homestead:~/Code/ticketit2$ composer require kordy/ticketit
Using version ^0.0.5 for kordy/ticketit
./composer.json has been updated
> php artisan clear-compiled
Loading composer repositories with package information
Updating dependencies (including require-dev)
  - Installing kordy/ticketit (v0.0.5)
    Loading from cache

Writing lock file
Generating autoload files
> php artisan optimize
Generating optimized class loader
vagrant@homestead:~/Code/ticketit2$

Yeah, I tried removing and re-installing many times... Anyway, thanks. Probably something's wrong at my side

As a rule for me, I always remove/comment the package service provider class in the app.php before updating the auto load (either installing or removing).
So before i install or remove ticketit package, i have to remove its service provider class from the app.php file.
And so for all other packages, remove their service provider class from app.php when you are going to install or remove them.

Ok, thanks for your advice

Same thing here. Tried fixing it myself. Removed / reinstalled a ton of times a bunch of different ways.

First before install or uninstall, make sure you removed this line from config/app.php file
'''php
Kordy\Ticketit\TicketitServiceProvider::class,
'''
Then follow the installation or uninstall instructions

It was all working perfect. Try running composer update or composer dump-autoload on a fresh project. It breaks again.

So here's what I've done:

Forked the package to my local dev machine.
Used (https://github.com/Jeroen-G/laravel-packager) to set up a brand new package.
Ported your package into the folder structure provided and renamed all folder references to case-sensitive PSR-4 references (lowercase to sentence case). (eg. referencing Kordy\Ticketit\Models when the folder name is "models").

I attempted to composer update and break the package but nothing seems to be breaking it. The issue is: I've already converted all views to MaterializeCSS. If you'd like, I can port your original revisions to a proper namespace and it should fix this issue. I've not seen it come up again since forking.
Let me know and I'll go ahead and fork a Bootstrap version PR.

Hello,
To be honest, I couldn't regenerate the error you had. Would you please mention how do you install the package? and if you uses the composer install or just cloning the package?
For the idea of using styling frameworks, I think we should work in ways that we always can integrate with the user current project styling, if we made our own style, then we won't be able to integrate.
Although, I like what you did, this way the package is more compliant to PSR-4, I appreciate your work :+1:

This should be all resolved with the latest PR. Let me know if any problems still persist. I'll be doing a fresh install on the preview URL tonight at 3am so I can verify all is well.

Thank you

Thank you guys for fixing this

No problem! Like I told Kordy -- I use this on my main website for my few clients I freelance for so I thank you more for releasing a modular way for me to move ticket systems around.


New team bios

Add our new team member bios!
https://airtable.com/tbl9hsEk0ouF2NdXg/viwEIUP3nHRUvGSeZ?blocks=hide

resolved by #45


Clean up Codacy code review rules

Let's clean up Codacy code review rules so that we don't have to manually fix them for every PR.

close this due to codacy will delete the comments automatically once resolved, on behalf of me.


Bump trie-db to 0.27.1 (fix storage iteration bug + change seek behavior with prefix)

This PR bumps trie-db to version 0.27.1 (see this PR for details) which mainly changes two things:

It fixes a bug with storage iteration where in certain cases the iterator would return keys outside of the specified prefix (see this issue for details)

It changes how the iterator works when both a prefix and a key from which to start iteration from is specified. This cleans up some corner cases and solidifies the behavior of how the iteration works which, AFAIK, previously was entirely accidental. The iteration now always follows the following two rules:

All of the keys returned by the iterator are guaranteed to start with the specified prefix (if present).
All of the keys returned by the iterator are guaranteed to be equal or bigger lexicographically to the starting key (if present).

Tagging this as B1-note_worthy and C3-medium for RPC nodes; everyone else can most likely treat this as C3-low.
Fixes https://github.com/polkadot-js/apps/issues/9103
Side-note
As far as I can see this shouldn't affect runtime behavior yet as the host functions (clear_prefix and storage_kill) to access this from within the runtime are not actually used (they're marked as register_only). That said, after merging this PR we will have to wait until the nodes are upgraded before we can consider removing the register_only flag from those host functions. (Since the host function is technically exposed; it's just not used by the runtime. This is why I've tagged this E3-host_functions even though it shouldn't affect the current runtime.)

Certainly should be deployed as soon as possible, but medium sounds right to me. If another pr is running a burn in, can be an idea to include this one, but I don t think it is really needed.

Certainly should be deployed as soon as possible, but medium sounds right to me. If another pr is running a burn in, can be an idea to include this one, but I don t think it is really needed.

Hmm... well, it should be fine, but I guess I can probably leave a full burn-in + partial burn-in (from the current chain head) with this applied over the weekend and see how it goes, just in case.

Certainly should be deployed as soon as possible, but medium sounds right to me. If another pr is running a burn in, can be an idea to include this one, but I don t think it is really needed.

Hmm... well, it should be fine, but I guess I can probably leave a full burn-in + partial burn-in (from the current chain head) with this applied over the weekend and see how it goes, just in case.

For me it is not essential, let's get others opinion :)

@koute I didn't open an issue because it may be related. Can you please check the following:

See the multisig.multisig() state for the account: 5Fd29bZn8XuoYcWG44rdWBRcKtcWsP6TRpf6ucBsFK98ZZRu

It says there's a proposal that has been signed by 3 signatories:

Now this is actually a multisig with a threshold of 3, so this proposal should have been submited, but for some reason it hasn't.

To verify this, check the origin call for this signatory at block 4639448 https://polkadot.js.org/apps/#/explorer/query/4639448
You can see that the multisig that's submitting the call is 5Fd29bZn8XuoYcWG44rdWBRcKtcWsP6TRpf6ucBsFK98ZZRu with a threshold of 3.
Subscan shows the same, the multisig has 1 initatial proposal, 2 approvals.. yet it's still pending: https://rococo.subscan.io/multisig_extrinsic/4639448-2?call_hash=0x94414b64ffe3f6dcbef0a186b5b80f52401ea764f91949f53d39e9add3a53e24


Add Html::tel();

With all of the other types of HTML helpers Yii2 has I think it's only fitting to have a tel: hyperlink type as well.
It is almost an exact copy of the mailto function.
     * Generates a tel hyperlink.
     * @param string $text link body. It will NOT be HTML-encoded. Therefore you can pass in HTML code
     * such as an image tag. If this is coming from end users, you should consider [[encode()]]
     * it to prevent XSS attacks.
     * @param string $tel telephone number. If this is null, the first parameter (telephone body) will be treated
     * as the telephone number and used.
     * @param array $options the tag options in terms of name-value pairs. These will be rendered as
     * the attributes of the resulting tag. The values will be HTML-encoded using [[encode()]].
     * If a value is null, the corresponding attribute will not be rendered.
     * See [[renderTagAttributes()]] for details on how attributes are being rendered.
     * @return string the generated mailto link
     */
    public static function tel($text, $tel = null, $options = []) {
        $options['href'] = 'tel:' . ($tel === null ? $text : $tel);
        return static::tag('a', $text, $options);
    }

use Html::tel(012312313, 'tel') ?

https://github.com/yiisoft/yii2/issues/8075

Rejected. See this comment for details. Thank you


Wtc18 choose an avatar

fixes #28,

add materialize in order to add carousel
style carousel
add package.json
add .gitignore
remove unnecessary materialize files

@skibinska Nice work. I see you've added a reference to issue #18  in the commit message. If you add the reference in the following format:
git commit -m 'commit description' -m 'related #18'
The reference #number will create a hyperlink to that issue which becomes visible in the issues chat history. Aim to do this for every commit as it means your issues will contain complete histories of all the work that has been done on them which makes it easier for people to track what work has been done and where. I'm nagging everyone about this so no worries. 👍

Hi @des-des, I added the lib folder with materialize. Could you please merge this pull request? :)

Make sense @des-des.


[FLINK-16491][formats] Add compression support for ParquetAvroWriters

What is the purpose of the change
Add compression support for ParquetAvroWriters.
Brief change log

Added overloaded versions for methods 'forSpecificRecord', 'forGenericRecord' and 'forReflectRecord', which need an extra CompressionCodecName parameter.
Added corresponding unit tests.

Verifying this change
This change added tests and can be verified as follows:

Added extra unit test cases locates in ParquetStreamingFileSinkITCase, with methods named testWriteParquetAvroSpecificWithCompression, testWriteParquetAvroGenericWithCompression and testWriteParquetAvroReflectWithCompression.

Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): no
The public API, i.e., is any changed class annotated with @Public(Evolving): no
The serializers: no
The runtime per-record code paths (performance sensitive): no
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: no
The S3 file system connector: no

Documentation

Does this pull request introduce a new feature? yes
If yes, how is the feature documented?  JavaDocs

@flinkbot run azure


Make p4-pdpi portable

~do not submit~ ready for submission
@stefanheule

@stefanheule I fixed some Bazel deps, but not all by far.

@stefanheule This is ready. Nothing new here, just merging from smolkaj/p4-pdpi.


ARROW-16857: [C++] Adding Project Relation ToProto

This PR contains an extension to the roundtrip test support for Acero-Substrait. In this extension, the Project relation roundtrip integration and tests are added.

This PR was opened after closing: https://github.com/apache/arrow/pull/13448

cc @westonpace please take a look.

@westonpace I added the emit version, I have a few doubts regarding test case validation.

@westonpace thanks for keeping up with this PR. I will address them accordingly.


Types that map easy to SQL DB types

In my career I am a master writer of SQL DB queries. When I use the MS SQL Server with the C# the types are most perfect. I fight never with them! The DB types and the C# primitive types are almost so close it is like they become one. My code is one with the SQL and the database and there is conflict. But when I use C or C++ or even Java then there is orthogonality! The C and the C++ and the Java types they do not align themselves so precisely with the SQL DB types! There is uncertainty and I do not like that! I would like if I am using Ark to write code that interfaces well with common SQL DB types. I desire this so!

Thanks for the issue, but this isn't really a priority now. SQL isn't really something we've thought about, and isn't really a primary issue in the language.


Application error: a server-side exception has occurred (see the server logs for more information). Digest:<PHONE_NUMBER>

usually it means the website was not connected to a proper database, or the database was not upgraded to tools compatible version. Tools version needs tool, assistant and other new tables.

I'm getting the same issue when trying to install using Vercel. Is there a description of how to make things work with Vercel, or is that method now broken?

Duplicate of #1220. I suggest closing this issue.


Always on top window should not be a part of Task View.

Description of the new feature / enhancement
Always on top is always going to be on top so there's no use of keeping it in task view while switching between different open applications.
Scenario when this would be used?
Sticky notes as always on top window having a function body which I'm gonna use in every practice problem and I wanna switch between the IDE and browser to code and view the question respectively. In this scenario I don't need sticky notes in task view interface.
Supporting information
No response

Love the idea but two big reasons make me go "won't fix".

Those apps then can't moved to a virtual desktop.  Currently in Windows, that is how you'd move stuff
This could break accessibility access to those apps since you can't keyboard only to that app then.

Tackling the idea of moving window to another workspace when on top it can
be implemented such that when we alt + tab it won't be present in the task
view but only when we win + tab all windows should be present in task view
to move from one workspace to another.
On Thu, Jan 20, 2022, 03:19 Clint Rutkas @.***> wrote:

Love the idea but two big reasons make me go "won't fix".

Those apps then can't moved to a virtual desktop. Currently in
Windows, that is how you'd move stuff
This could break accessibility access to those apps since you can't
keyboard only to that app then.

—
Reply to this email directly, view it on GitHub
https://github.com/microsoft/PowerToys/issues/15634#issuecomment-1016898019,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/APUJQMO4YEYA5G4KVLGXSJDUW4WWHANCNFSM5MI4X3CA
.
You are receiving this because you authored the thread.Message ID:
@.***>

This breaks functionality that people use and currently has no other way currently to do it.  Lots of PT users use virtual desktops


cant deploy job in another namespace

I edited the namespace field in the values.yaml file used for creating project
after installing the project no pod for a job is being created in the new namespace or default namespace.
Currently my brigade-project secret is in agent-namespace
and brigade ctr and brigade api pods are running in default namespace .
Please guide me where i am doing something wrong.

At the moment, we are only supporting running all of Brigade in one namespace. So project config, worker, and job pods are all in the same namespace. Hopefully, we will be able to make this more flexible in the future. But for now, this is the only way to run Brigade.


inline some assembly on basic order fulfillment

Codecov Report
Base: 65.63% // Head: 99.43% // Increases project coverage by +33.79% :tada:

Coverage data is based on head (7ae0e33) compared to base (6636073).
Patch coverage: 33.33% of modified lines in pull request are covered.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
Additional details and impacted files
@@             Coverage Diff             @@
##              1.2     #933       +/-   ##
===========================================
+ Coverage   65.63%   99.43%   +33.79%
===========================================
  Files         108       47       -61
  Lines        4449     2642     -1807
  Branches      564      392      -172
===========================================
- Hits         2920     2627      -293
+ Misses       1502       14     -1488
+ Partials       27        1       -26

Flag
Coverage Δ

foundry
75.30% <0.00%> (+26.30%)
:arrow_up:

production
100.00% <100.00%> (ø)

reference
99.91% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

contracts/lib/BasicOrderFulfiller.sol
98.49% <33.33%> (-1.51%)
:arrow_down:

contracts/test/TestInvalidContractOfferer.sol

test/foundry/token/StubERC721.sol

contracts/test/InvalidERC721Recipient.sol

.../foundry/offerers/impl/StatefulRatifierOfferer.sol

test/foundry/utils/OrderBuilder.sol

contracts/zones/PausableZone.sol

contracts/test/TestERC721.sol

contracts/test/TestERC1155Revert.sol

contracts/test/ConduitMockRevertBytes.sol

... and 52 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

This PR partially addresses:

https://github.com/spearbit-audits/review-seaport-1.2/issues/60
https://github.com/spearbit-audits/review-seaport-1.2/issues/57


review site accessibility

try out ' SiteImprove' accessibility checker for Chrome

lengthy alternate text
https://webaim.org/standards/wcag/checklist#sc1.1.1
Why It Matters
Alternative text should be succinct, yet descriptive of the content and function of an image. Lengthy alternative text (more than around 100 characters) often indicates that extraneous content or content that is not available to sighted users is being presented.
What To Do
Ensure the alternative text is succinct, yet descriptive. Ensure that no content is being presented in alternative text that is not available to sighted users viewing the image. When possible, either shorten the alternative text or provide the text alternative via another method (e.g., in text near the image, through a separate description page, etc.).
The Algorithm... in English
The image's alt attribute value is more than 100 characters. Note that the 100 character limit is a rough and somewhat arbitrary length. For images that present complex content or lengthy text, alternative text longer than 100 characters may be appropriate.

Language missing or invalid
What It Means
The language of the document is not identified or a lang attribute value is invalid.
Why It Matters
Identifying the language of the page or page elements allows screen readers to read the content in the appropriate language. It also facilitates automatic translation of content.
What To Do
Identify the document language using the  attribute with a valid value (e.g., ). Ensure that all lang attribute values are valid.
The Algorithm... in English
The  attribute is missing or is empty, or a lang attribute value is not a valid language identifier.
Standards and Guidelines
3.1.1 Language of Page (Level A)

Unlabeled form control with title
What It Means
A form control does not have a label, but has a title.
Why It Matters
The title attribute value for unlabeled form controls will be presented to screen reader users. However, a properly associated text label provides better usability and accessibility and should be used unless the purpose of the form control is intuitive without the label.
What To Do
If a visible text label is available for the form control, associate the text label to the form control using the label element. This provides additional functionality for end users because if the label is clicked it will set focus to the form control. If the form control is intuitive without a , the title attribute value may be used. Note that the title attribute value will not generally be read by a screen reader if the control has a label and may not be available to sighted users, particularly keyboard-only users.
The Algorithm... in English
An <input> (except types of image, submit, reset, button, or hidden), <textarea>, or <select> element has a non-empty title attribute value and is missing a label or valid aria-labelledby reference.
Standards and Guidelines

1.1.1 Non-text Content A
1.3.1 Info and Relationships A
2.4.6 Headings and Labels AA
3.3.2 Labels or Instructions A

Skipped heading level
What It Means
A heading level is skipped.
Why It Matters
Headings provide document structure and facilitate keyboard navigation by users of assistive technology. These users may be confused or experience difficulty navigating when heading levels are skipped.
What To Do
Restructure the document headings to ensure that heading levels are not skipped.
The Algorithm... in English
A heading level is skipped (e.g., an  is followed by an , with no intermediate ). Note that an  is not required to be the first heading within the document.
Standards and Guidelines
1.3.1 Info and Relationships (Level A)
2.4.1 Bypass Blocks (Level A)
2.4.6 Headings and Labels (Level AA)

see also - https://www.w3.org/WAI/ARIA/apg/example-index/dialog-modal/dialog