Lis Trait Association Search Element

The trait association search element allows a user to search for trait associations and follows the draft spec
The search allows filtering by genus, species, study type, traits, publication DOI or PMID, and author.
Results are returned in a format similar to the gene search, and display the study name, study type, study synopsis, study description, trait name, and genotypes.
The limiting "genus" parameter from the gene search is also integrated into the element.

@That-Thing Let's make sure the spec is finalized before proceeding. @StevenCannon-USDA I see the spec version is 1.0.0 and the Details say it's completed. However, Simon says it's a draft and the GitHub issue is still open. Can you confirm its status? (More generally someone needs to start tagging releases in the spec repo so there's no ambiguity whether or not a spec has been finalized. I can get the ball rolling by tagging releases for the existing specs but I don't want to responsible for tagging every releases in the future.)
@That-Thing Since you're last PR (which is also held up by spec finalization; I'll handle it this week) we've introduced automated linting and formatting. As indicated in the branch state section of this PR, these tests are currently failing. The details suggest that you haven't merged the most recent version of main into your branch so the tests can't run. Before proceeding with a review, let's make sure main is merged and the tests are passing.

@alancleary and @That-Thing  -
Good reminder for me to review and tidy up the specs and to review and close the associated issue.
I consider the spec to have been ready for implementation, but I did change one of the text-entry titles from "Study ID" to "Publication ID" -- which I see you have already incorporated, Simon. I also added discussion about the report layout (vertical or horizontal/tabular). I am leaving that up to the implementers. I suspect that tabular is more straightforward, and that's OK to move this forward; but for this data, horizontal will probably be preferable. Let's see how it looks and have the discussion about functionality/esthetics vs. implementation considerations after we have a 1.0 version to evaluate.

Thanks for confirming @StevenCannon-USDA. Regarding vertical vs tabular layout, I think it was more or less settled that tabular would be the default for paginated search components because it can be overridden at run-time, i.e. without forking the web-components library, whereas creating a bespoke layout for each paginated search makes overriding without forking much more difficult.

Branch passes the lint tests and incorporates all the new changes from main.

Thanks @That-Thing. It looks like there's now a merge conflict, probably because I (finally) merged your gene search PR yesterday. Can you resolve the conflict? It looks like all the conflicting files are in the docs so just pulling in main (again) and regenerating the docs should do the trick.
The trait search spec was officially released yesterday so I'll proceed with reviewing this PR after the merge conflict is resolved. I'm hoping to have it reviewed by COB tomorrow.

Will do.

Replacing renderResult with the table view would mean that there would be a lot of empty columns in each result, since each result has either a GWAS or QTL study but not both.
Will this be acceptable?

Replacing renderResult with the table view would mean that there would be a lot of empty columns in each result since each result has either a GWAS or QTL study but not both. Will this be acceptable?

You can use a single "study" column for this and merge the two fields together in your GraphQL code. This is what the gene search component is doing with its "location" column, which can have a chromsome or a contig but not both.

Digging into this a little more I have two questions:

Why is there not a strain field like the gene search?
Why are most of the form fields being used to filter the search results rather than sending all the values to the GraphQL server so the filtering can be integrated into the search?

Regarding (2), this would require updating the searchTraits method of the Intermine data source in the GraphQL Server to accept the following optional parameters: genus, species, (strain?), studyType (QTL or GWAS), publicationID (DOI or PMID), and author. @sammyjava Is crafting the seachTraits method's Intermine constraints to support these parameters a reasonable thing to do?

I've been following the spec. @StevenCannon-USDA would know more about this than I do.
The filtering is being done because there's no option to pass the values in the query. Adding support for these would make things a lot easier.

@alancleary @That-Thing  regarding the absence of a strain field, I think it makes sense not to have it for this type of search, if only because GWAS and QTLStudy don't have a Strain in the data model (because you need a diversity of Strains to do these experiments). Roughly speaking the "Genotypes" field is akin to having an array of Strains, although we don't actually do things that way, but rather just indicate in a textual way what went into the experiment, e.g. "Archer x Minsoy" for a biparental QTL Study or "105 wild and 262 cultivated soybean accessions" for a GWAS. One could imagine being able to do a CONTAINS type constraint on Genotypes, but for now just following the spec is the right thing to do.
And I agree we should extend the GraphQL query to support the constraints from the form, this was probably just an oversight on someone's part.

And I agree we should extend the GraphQL query to support the constraints from the form, this was probably just an oversight on someone's part.

"someone" = @sammyjava (although the graphql-server implementation predates this web component).
@That-Thing let me get the <IP_ADDRESS>-model-changes branch of graphql-server up to speed with this web component, supporting the constraints in the queries. LegumeMine and GlycineMine will be promoted to <IP_ADDRESS> very soon in any case, at which point I'll be merging <IP_ADDRESS>-model-changes into main. There are some differences in how the genetic data are handled on the back end, although I don't think the GraphQL types changed much.
In any case, let's put a hold on this PR while I get that stuff updated, which will require some tweaks to this web-components branch, which either I'll do or I'll throw back to you. :)

@That-Thing I've committed updates to the graphql-server:<IP_ADDRESS>-model-changes branch to support the additional parameters in a trait search:
        traits: async (_, { name, genus, species, studyType, publicationId, author, page, pageSize }, { dataSources }) => {
            const args = {name, genus, species, studyType, publicationId, author, page, pageSize};
            return dataSources[sourceName].searchTraits(args)
                // @ts-ignore: implicit type any error
                .then(({data: results, metadata: {pageInfo}}) => ({results, pageInfo}));
        },

You can update your web component to make use of those parameters. HOWEVER: I have not solved the issue of finding traits associated with a genus/species without specifying the studyType. In the mines that would have to be done by creating a list of GWAS traits and a list of the QTLStudy traits and then joining those lists. @alancleary and I talked about possible ways of achieving that in graphql-server. Right now, a search on genus/species without specifying studyType returns all traits -- the genus/species value is ignored.
But I thought I'd let you know so you can get the web component updated, even though genus/species without studyType isn't working yet.

I recommend that the example for author be a single name. Publications show authors in a variety of ways, and the only consistent thing is last name (if that). Also, the Author.name attribute in the mines against which this value is searched is NOT last name, initials. It is first name middle-initial last name (if middle initial is given, and sometimes first name is initials). Here are some examples to show the variety:
 Abid Md. Hasan
 Adrienne Kleintop
 Akhilesh Tyagi
 Alejandro Velasco Castrillón
 Bao‐Lam Huynh
 David Fernández-Baca
 Eun-Young Hwang
 G Albert Wu
 G Iriarte
 Jansen R.P. Santos
 Manon M S Richard
 María Muñoz-Amatriaín
 Monica Muñoz Torres
 Samira Mafi Moghaddam
 Xiaohua Wu
 Xinbin Dai
 Xinyi Wu
 Yaowen Hu
 Yeisoo Yu
 Zhongfu Lu

Forgot to add in the commit message, but as @sammyjava suggested, example author is now just a single name.

Per our conversation in the graphql-server repo, please add optional genus and species properties to the trait search component that have the same effect as the already implemented genus property in the gene search component.

I think a new (maybe not) tweak on this is to be able to force "-- any --" rather than a specific species (or genus, I suppose). I suppose that could be handled with supplying "any" as the genus/species in the component parameter.


Improvement

Added the report interval to the report in order to detect if the client has lost connection

Can you please explain the use case.

@tananaev When the device sends a report, the device sends its report interval so the sever knows when to except the next report.
If the server doesn't get the report in that time I know that the device went offline due to some reason (i.e. turned off or lost reception).  @tananaev

Are you planning to implement some modifications on the server side as well? What about iOS?

Maybe not right now, but possible to do that in the near future

OK, we can merge when everything is ready. Also, the right way of implementing this would be to add a new parameter to the Position model. One more thing I suggest is renaming parameter to something shorter (e.g. "interval").

I'm not sure if that's correct, the interval isn't really a part of the Position model attributes (logically).
Just because we want to send it to the sever doesn't mean it has to be a part of the model.
The attribute name can definitely be changed.
And OK, we'll wait until all platforms are aligned.

I think it makes sense to send original interval value at the time when location was captured.

We can either keep server as it is, but ideally we want to use interval for "unknown" status timeout.

I like this idea, and would find it useful.

@slobglob @garyvdm https://github.com/traccar/traccar-client-android/pull/348 implements this and more, if you want to try, feedback welcome.


Retired units handling in TADA

Is your feature request related to a problem? Please describe.
Retired units in WQP data pulls do not get caught by the WQXCharValRef table, which is generated by pulling the QAQC Characteristic Validation domain table. Because of this, retired units, such as mg/L as N, are not flagged as valid/invalid and often cannot be assessed against national thresholds. At some point, their units need to be converted to current target units, but that spot has not been widely discussed/established.
Describe the solution you'd like
This step could most easily be achieved in the data harmonization table, which will become more robust with further development on the WQX domains side. Characteristics with retired units aren't necessarily a QC problem (i.e. retired units aren't grounds for removal) but are a translation/harmonization problem.
Describe alternatives you've considered
Adding retired units to the QAQC validation table with the correct target unit populated is another option: but how to ensure the "as N" portion is retained in the correct column (speciation).
Additional context
today = Sys.Date()   twoago = as.character(today-2*365)   testdat = TADAdataRetrieval(statecode = "UT", startDate = twoago, characteristicName = c("Nitrate"), sampleMedia = "Water")   testdat = ConvertResultUnits(testdat, transform = TRUE)   testdat = AboveNationalWQXUpperThreshold(testdat, clean = FALSE, errorsonly=FALSE) testcase = subset(testdat, is.na(testdat$TADA.ResultValueAboveUpperThreshold.Flag))

@ehinman Another option I just remembered that we've considered previously, is to address this within the special characters function (or the unit conversions function) for these very common issues where the metadata is in the unit. Like we do with specific result value issues (>, <. etc.). This one, "mg/L as N" is very common, and "mg N/L" may be common as well.  This might be an easier solution. Thoughts?

This seems a solid idea if users do not wish to be involved in how retired units are handled--how extensive do you think this translation needs to be (e.g. should we make a translation table for all of them or just the most common ones)? Do we need to flag this conversion somehow? Will they all be 1:1?

In harmonize-wq there is a unit_basis_dict lookup for these to update (append to) the basis column from the units string. Here are the ones we saw in Gulf of Mexico Estuaries:
{'Phosphorus': {'as P': {'mg/l': ['mg/l as P', 'mg/l P'],
                         'mg/kg': ['mg/kg as P', 'mg/kg P']},
                'as PO4': {'mg/l': ['mg/l as PO4', 'mg/l PO4'],
                           'mg/kg': ['mg/kg as PO4', 'mg/kg PO4']}},
 'Nitrogen': {'as N': {'mg/l': ['mg/l as N', 'mg/l N']}},
 'Carbon': {},
}

Right now it doesn't flag it, my only concern would be if it were in conflict with the previous speciation.

After a discussion with @cristinamullin yesterday, I believe these issues are isolated to USGS data (not retired units), where the units mg/l as P, mg/l asNO3, etc. are accepted and pushed into the WQP. I think the best way to proceed right now is to create a USGS unit-specific table that gets tacked onto the MeasureUnit reference table (within TADA) used to convert to the target unit. Target units for USGS data will be unified with WQX target units, and any speciation data will be added to the MethodSpeciation column in the TADA dataset. Agree @jbousquin, we need to account for situations where the new speciation may "overwrite" (in a new column) the original--I am unsure how prevalent this situation will be. Hopefully this will be resolved as USGS migrates toward the WQX framework.

This issue was (hopefully) resolved in this PR: https://github.com/USEPA/TADA/pull/308/files


These credentials do not match our records

This is  a **bug **.
Prerequisites

[* ] Are you running the latest version?
[ *] Are you reporting to the correct repository?
(enso is made of many specialized packages: https://github.com/laravel-enso)
[ *] Did you check the documentation?
[ *] Did you perform a cursory search?

Description

After installation, when entering the project, the error "These credentials do not match our records"
LOG.warning: Creation of dynamic property LaravelEnso\Core\Http\Controllers\Auth\LoginController::$maxAttempts is deprecated in /opt/mt6/enso/vendor/laravel-enso/core/src/Http/Controllers/Auth/LoginController .php on line 29
Steps to Reproduce

my env
debian 12
php 8.3

Hi @SerhiiZahuba are you able to resolve it?


Feature: Pending Applications Table

Description
Pull Request Video
As an admin, I can view collected data from user signups in order to approve mentor/mentee applications. A Pending Applications folder and file were created to store the Pending Application component. This component receives data from the backend pertaining to all of the mentor and mentee applications that have been submitted but not yet approved for admins to view. A table is rendered, displaying name, role, and date of application submission. The component is properly linked to the nav sidebar "Pending Applications".
Note: Backend is communicating with the frontend locally. The backend repo branch feature/pending-applications is needed for this component to receive data.
Fixes #107
Type of change

[x] New feature (non-breaking change which adds functionality)

Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have removed unnecessary comments/console logs from my code
[x] My changes generate no new warnings
[x] I have checked my code and corrected any misspellings
[x] No duplicate code left within changed files
[x] Size of pull request kept to a minimum
[x] Pull request description clearly describes changes made & motivations for said changes

Great job on creating the component! Functionality-wise seems to be doing the job.


 Thanks!

Thanks, confirmed the issue. This is a result of a border applied to a pseudo element which is positioned absolutely. Will submit a PR to change how it's implemented.


[auto-merge] branch-24.06 to branch-24.08 [skip ci] [bot]

auto-merge triggered by github actions on branch-24.06 to create a PR keeping branch-24.08 up-to-date. If this PR is unable to be merged due to conflicts, it will remain open until manually fix.

FAILURE - Unable to auto-merge. Manual operation is required.
{'message': 'Pull Request is not mergeable', 'documentation_url': 'https://docs.github.com/rest/pulls/pulls#merge-a-pull-request', 'status': '405'}

Please use the following steps to fix the merge conflicts manually:
# Assume upstream is NVIDIA/spark-rapids-examples remote
git fetch upstream branch-24.06 branch-24.08
git checkout -b fix-auto-merge-conflict-399 upstream/branch-24.08
git merge upstream/branch-24.06
# Fix any merge conflicts caused by this merge
git commit -am "Merge branch-24.06 into branch-24.08"
git push <personal fork> fix-auto-merge-conflict-399
# Open a PR targets NVIDIA/spark-rapids-examples branch-24.08

IMPORTANT: Before merging this PR, be sure to change the merging strategy to Create a merge commit (repo admin only).
Once this PR is merged, the auto-merge PR should automatically be closed since it contains the same commit hashes


Show only 1 priority in Keeper. Just like Tribe

Sometimes the fees is same for low/medium/ high priority. A user would confuse this to be a bug. We want to show only 1 priority. Let's use the logic that we've built in Tribe to show what we must.
On the same screen we need to give the note: "Sometime the fees for low/medium/high priorities are the same. This is not a bug."

I have added logic. But need to test in the Live app. Till then this issue in-peer review

To be tested in Live app

Verified this issue on keeper app v 1.1.11(297)


Surface game metadata and player nicknames in client / react props

Will close #413
Checklist

[X] Use a separate branch in your local repo (not master).
[X] Test coverage is 100% (or you have a story for why it's ok).

Thanks @jasonharrison.  Can you also double-check that this doesn't break anything when the client is used in a singleplayer mode (i.e. no lobby or multiplayer)?

@nicolodavis Are we able to release a patch that includes this? Or do we have some fixed release cycle or testing to do?
Sorry for all the questions 🙏

The release will include everything until the tip in master.  I want to hold off on that until I get the docs ready for all the new features that have changed the API regarding phases.
One option is you can use the library from the repo directly by using npm link.  That way you don't have to wait for a release.

Alright 👍


step4: add smiles

Bug https://github.com/codecov/worker/issues/393
The tutorial says, "Notice that we have the two files api/smiles/smiles.py and api/smiles/test_smiles.py in our Impacted Files list."
Expected behavior: I see 2 files, smiles.py and test_smiles.py listed.
Observed behavior: I see only 1 file, smiles.py, listed. The Files Changed includes new file test_smiles.py as created in 4a.


Error when creating a new API from scratch by a user with Creator only permission

Description:
Below error popup is displayed in Publisher UI when a user with Creator only permissions creates an API from scratch at the point of clicking on the CREATE button.

The browser console shows the following two calls being made to the revision rest API

Since the revision REST API resources require Publisher permissions these calls fail with 401 being returned.
Steps to reproduce:

Login to the Publisher UI with a user who only has Creator permissions.
Fill in the fields required for a new REST API from scratch and click on the "CREATE" button

https://github.com/wso2/carbon-apimgt/pull/9942

Fixed in the latest, please reopen if recurring


Mitch/pa1616s

Implemented driver for the GPS module in pa1616s.py to get time, date, position, course, speed, and fix data.

I reviewed it. Good work! I fixed some style issues (as per PEP 8). I found some bugs after running mypy. Please look over and lmk so I can merge.


Preference -> Appearance Tab

Description
It's time to support the Appearance Tab

Acceptance Criteria

Add new Appearance Tab
All settings are persisted to the next launch
When "Factory Reset", make sure it's reset too
The setting should take affect immediately.

1. Font Size

Implement the Font Size
Not sure what is the default font Size of Windows, maybe 13, or 14? -> Check it and turn it into a default value
When the font size is updated, the following View will be updated:

The Body (Monaco Editor) -> Breakpoint and Map Local
The Header (Cookie, Header, Authentication, Form) -> Make sure multiple line doesn't break
The Raw Tab

2. Wordwarp

Default is ON
Set word warp on Monaco Editor

3. Minimap

Default is OFF
Set minimap on Monaco Editor

4. Scroll beyond the last line

Default is OFF
Set it on Monaco Editor

Requirement Update

Add the Restore Default button to restore all Appearance Setting to the default value.


text appears truncated or wrapped on android

For example

Version 27.209.
Its been like this for a while so not a recent breakage.

Thanks for the report, @sqwishy!
I think the most likely cause is an issue in React Native, the framework this app is built in. If so, it should be possible to work around the bug by changing your system font settings, under Settings → Display → Font size and style.
In previous reports of similar issues, users found that the "Bold text" setting was on, and the text displayed correctly after they turned that off. In your case, however, the text doesn't look bold to me…hmm. I think the font does look different from the usual system font that most people use, though, does that sound right? I'm curious if choosing a different font might fix it.
This is one of many reasons we're looking forward to launching a new app built in Flutter (not React Native): https://github.com/zulip/zulip-flutter

Cross-linking a bit: our first issue for the same underlying problem was #2365, and we saw it again at https://github.com/zulip/zulip-mobile/pull/3533#issuecomment-504580139 and https://github.com/zulip/zulip-mobile/issues/2447#issuecomment-1540703746 . The ongoing thread for it is #2447.
Leaving this open because it is an ongoing bug in this app, but at this point we're not going to fix it in this codebase. If you see anything like this in the new Flutter app, though (now in beta!), we'll definitely be interested in debugging that.


Fixing crash for attachments

Fixes crash for when users click in attachments. This style must be used so com.google.android.material.card.MaterialCardView can be used

The same should be done for java tutorial

This was fixed in the SDK, I don't see the crash anymore.


Node wrapper eslint

Codecov Report

Merging #232 (95dc1f6) into package-upgrade (521462e) will not change coverage.
The diff coverage is n/a.

@@               Coverage Diff                @@
##           package-upgrade     #232   +/-   ##
================================================
  Coverage            57.69%   57.69%
================================================
  Files                  149      149
  Lines                19902    19902
  Branches              4464     4464
================================================
  Hits                 11482    11482
  Misses                5071     5071
  Partials              3349     3349

Flag
Coverage Δ

integration
26.14% <ø> (ø)

unittests
51.95% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 521462e...95dc1f6. Read the comment docs.

It'd be preferable to split into 2 PRs:

update of FFI dependencies
eslint/formatting one

As this way it's hard to see whether there were any changes related to FFI updates

Interesting... I've originally created this PR against master, that's why you see these diff in the package.json.
But when I moved it against package-upgrade (to avoid exactly that), the diff in github doesnt change... 🤷


feat(docs): hotkey to jump to search box

for faster navigation of the docs site, pressing / from anywhere, or maybe Ctrl + K should jump to the search box.
Again, I'm happy to implement, just need confirmation :)

/ is probably dangerous when you will use some examples.
But Ctrl+K could be added.

I think / is okay to add too. GithuB is using it now as a shortcut to search as well

Hi Luke,
Any update on this?

Done


No error for missing escaping anymore in some cases

Bug Description
_e( 'Login', 'example' );
Until recently this returned an error for

All output should be run through an escaping function (see the Security sections in the WordPress Developer Handbooks)

For some reason it doesn't anymore. (specifically this function, when we do e.g. echo $_GET['hello']; we still get the error correctly)
Minimal Code Snippet

_e( 'Login', 'example' );

Error Code
WordPress.Security.EscapeOutput.OutputNotEscaped
Environment

Question
Answer

PHP version
7.4.14

PHP_CodeSniffer version
3.5.8

WPCS version
2.3.0

WPCS install type
Composer global

Works well for me (that is I get reported error). Can you provide your ruleset?

Ah sorry, this seems to happen when using this ruleset in addition to
<rule ref="WordPress-VIP-Go"/>
Seems like WP VIP Go disables this check for _e within this ruleset.
Should I open an issue there?

@kkmuffme No thanks, that behaviour is intentional. Language files are handled in a different way there, so it's far less open to a bad string being present. Translations are trusted.
https://github.com/Automattic/VIP-Coding-Standards/blob/fe2c16e1b9f3bb243c5880123ae02d0e08c547a8/WordPress-VIP-Go/ruleset.xml#L209-L211


Create: 5782-maximum-alternating-subsequence-sum.cpp

File(s) Modified: cpp/5782-maximum-alternating-subsequence-sum.cpp
Language(s) Used: C++
Submission URL: https://leetcode.com/problems/maximum-alternating-subsequence-sum/submissions/903085520/

Hi, could you correct the file name please? The problem number is 1911 and not 5782?

Did you accidently close this?

I've created a new PR with a new branch just now. You can merge that one

Okay, thanks!


queue - aborted no available instance

[REQUIRED] Step 2: Describe your configuration

Extension name: firestore-send-email
Extension version: 0.1.10
Configuration values (redact info where appropriate):

compliant

[REQUIRED] Step 3: Describe the problem

queue - aborted no available instance
Steps to reproduce:
Expected result
Actual result

@waste-app Version 0.1.11 has been recently released. Does upgrading to this version fix the issue?

@waste-app per the Cloud Functions docs, it looks like this may be caused by a Cloud Functions internal error. If you update to the latest version and are still experiencing this, please reach out to Firebase support.

no

@waste-app per the Cloud Functions docs, it looks like this may be caused by a Cloud Functions internal error. If you update to the latest version and are still experiencing this, please reach out to Firebase support.

response:
...Now, issues or bugs in an existing extension are better attended on GitHub, for that you will need to create an issue in the Firebase Extensions GitHub. I know this is not the answer that you expected, but they are better prepared to help you with troubleshooting and also feature requests for existing extensions...

@waste-app per the Cloud Functions docs, it looks like this may be caused by a Cloud Functions internal error. If you update to the latest version and are still experiencing this, please reach out to Firebase support.

response:
...Now, issues or bugs in an existing extension are better attended on GitHub, for that you will need to create an issue in the Firebase Extensions GitHub. I know this is not the answer that you expected, but they are better prepared to help you with troubleshooting and also feature requests for existing extensions...

I submitted a Firebase support ticket because I was seeing this error too with the distributed counter extension, and they gave me the same response.

Thanks for the feedback everyone. Closing this as it's more of a runtime platform issue and nothing needs to be changed in the extensions atm.


Android

https://github.com/The404Hacking/AndroRAT/issues/4

There is a lot of advertising spam from this account. Maintainers, please look into this
Same issue: https://github.com/microsoft/vscode/issues/153777


Auto Start Video, Hide Full Screen Button, On Complete Close Activity

Here is the code, which I am using to play Video from SD Card, In Manifest, I am using orientation as landscape...
<activity android:name=".VideoPlayerActivity"
            android:configChanges="orientation|screenSize|keyboardHidden"
            android:screenOrientation="landscape"
<EMAIL_ADDRESS>            android:launchMode="singleTop">

In VideoPlayerActivity.java, I am using following code:

public class VideoPlayerActivity extends AppCompatActivity {

    @Override
    protected void onCreate(Bundle savedInstanceState) {
        super.onCreate(savedInstanceState);
        setContentView(R.layout.activity_video_player);

        String fileName = "toystory.mp4";
        String completePath = Environment.getExternalStorageDirectory() + "/Download/" + fileName;

        JCVideoPlayerSimple jcVideoPlayerSimple = (JCVideoPlayerSimple) findViewById(R.id.custom_videoplayer);
        jcVideoPlayerSimple.setUp(completePath);

    }

}

Now, I would like to do 3 major improvements in my program, like:

Auto start video (without doing tap on start button)
Want to hide full screen button
On complete want to close the Activity

Note: I do not want to use JCFullScreenActivity because as I wrote above, I want to exit Activity, once user do tap on back, but I am unable to do same with JCFullScreenActivity

1.jcVideoPlayer.startButon.performClick() simulator user click startbutton.
2.create class extends JCVideoPlayerStanard Override setUp(), hide fullscreen button
3.create class extends JCVideoPlayerStanard Override onComplete(), close activity

hey @lipangit  can you help me with https://github.com/lipangit/JiaoZiVideoPlayer/issues/2136


Could not find a declaration file for module 'react-slideshow-image'

I have just installed this package, imported and saw this error

There're some issues about this but I met this error when I was using javascript, not typescript

Hi @lioaslan are you sure you're not using typescript. If you're using typescript follow this instruction. If you're still having issues can you please try and replicate the bug on codesandbox.io/


(Solved) No Diagram Designer open

I have create a Model. Now i will change some parts, but when i will open the efmodel-File my VS2022 hangs and "no preview for this element is possible" show
How can i fix it?
In my model are Entities, Joins and one Enum

Open an another working efmodel


add hackathon playground board

@bhusang this is adding the hackathon to the cookbook

Is the ocdb submodule commit referred to by this project the same as dev? if not, can you make a PR against dev?

This references main OCDB.


Add BeagleConnect Freedom

BeagleConnect is a trademark of the BeagleBoard.org Foundation. BeagleConnect Freedom is the first device to implement the BeagleConnect technology that exposes microcontroller hardware interfaces to Linux devices. BeagleConnect Freedom utilizes a Texas Instruments (TI) CC1352P microcontroller which provides an ARM Cortex-M4 CPU, 2.4GHz radio, SubGHz radio, and many other microcontroller peripherals and features.
See https://beagleconnect.org for details.
Reviews requested from @statropy @Pillar1989 @cfriedt @Yadnik1 and @vaishnav98
Previous pull-request at https://github.com/zephyrproject-rtos/zephyr/pull/36703

@vaishnavachath @cfriedt BeagleConnect Freedom has been updated to use CC1352P7 now. Shall I wait for CC1352P7 support to be merged ahead of submitting the new PR for the device?

@jadonk I will try to add CC1352P7 base support over this weekend, will need corresponding hal_ti updates as well, I would recommend posting P7 updates on BeagleConnect Freedom post that.

I would be OK reviewing board + plus new SoC in the same PR. Just remember to keep separate commits for board, soc, drivers, tests, etc, which I think you've probably already done.
If you're using this PR again, just remember to rebase on latest main.
You'll need to update west.yml to point at the the hal/ti pr and we'll do this weird little dance with Zephyr CI for merging dependent PRs in different repos.


Problem installing OotD

It appears that this is a solution I have been looking for for years, and I see no others like it.  My problem is that I can't get OotD to install.  I am running Win 10 64bit.  When I try to install, I get an error message stating that I need to install the correct version.  I have tried to install the 64 bit version without luck.  Any help would be appreciated.

Did you try the 32-bit version?  What version of Office do you have?

I’m using Office 2016 on a 64 bit machine.  Does this software interface with Outlook or is it simply a calendar that stays on the desktop?  I need the interface.
From: Michael Scrivo<EMAIL_ADDRESS>Sent: Monday, January 25, 2016 9:21 AM
To: mscrivo/ootd<EMAIL_ADDRESS>Cc: jmgraves<EMAIL_ADDRESS>Subject: Re: [ootd] Problem installing OotD (#38)
Did you try the 32-bit version? What version of Office do you have?
—
Reply to this email directly or view it on GitHub https://github.com/mscrivo/ootd/issues/38#issuecomment-174521236 .

It does interface with Outlook, fully interactive.  Sounds like you should try installing the 32-bit version of OotD


feat: propogate crd changes from argocd-operator to gitops-operator

Signed-off-by: rishabh625<EMAIL_ADDRESS>What type of PR is this?

Uncomment only one  /kind line, and delete the rest.
For example, > /kind bug would simply become: /kind bug

/kind bug
/kind cleanup
/kind failing-test
/kind enhancement
/kind documentation
/kind code-refactoring

What does this PR do / why we need it:
This PR contains a shell script that clones upstream ooperator compares config/crd and add those changes in gitops-operator and run make bundle
Have you updated the necessary documentation?

[ ] Documentation update is required by this PR.
[ ] Documentation has been updated.

Which issue(s) this PR fixes:
Fixes #?
Test acceptance criteria:

[ ] Unit Test
[ ] E2E Test

How to test changes / Special notes to the reviewer:
To test this PR make changes in config/crd/bases/ files and run below commands
cd hack
sh propogate.sh

This PR only pulls the CRD changes. How about the changes related to rbac and other files in the bundle folder other than CSV. Can you please take a look ? @rishabh625

/approve

/retest


Sorting sector sync by finished time

Would it be possible to sort this by finished time instead of status?
https://api.catalogueoflife.org/dataset/3/sector/sync?limit=25&offset=0
Otherwise, several pages of old canceled syncs always show first when we're really interested in viewing the latest syncs:
https://data.catalogueoflife.org/catalogue/3/sector/sync?limit=25&offset=250
Unless there's a sort parameter that the frontend should be sending? If so, it looks like it might not work?
https://api.catalogueoflife.org/dataset/3/sector/sync?limit=25&offset=0&sortBy=finished

The canceled ones are wrong I think, syncs should be sorted by their submission/start time. I take this issue also to look into why the canceled ones stick. Sorting otherwise could probably be also done, but it's a bit of work and there is a lot of other important things to be done first.


Could not determine the dependencies of task ':app:compileDebugJavaWithJavac'.

Steps to reproduce

Actually previously, i faced a problem is about the ':flutter_plugin_android_lifecycle:compileDebugJavaWithJavac'. , but seen like solved after i change the grade file version.
After when run again, then facing this issues, I had tried some solution which downgrade or upgrade the java version , but still not working
Current Java Version is 21

Actual results
Hi , I'm building a fish inventory app in Flutter. Initially, the app was working fine and running on the Android emulator from Android Studio. However, after implementing Firebase features, I started encountering an issue where the app no longer runs properly on the emulator. The app works fine when run on Google Chrome, but not when using the emulator.
Issues :
FAILURE: Build failed with an exception.

What went wrong:
Could not determine the dependencies of task ':app:compileDebugJavaWithJavac'.

Cannot query the value of this provider because it has no value available.

Logs
Log.txt
Flutter Doctor output

Doctor output

[√] Flutter (Channel stable, 3.24.5, on Microsoft Windows [Version 10.0.19045.5131], locale en-MY)
    • Flutter version 3.24.5 on channel stable at C:\Users\crazy\Desktop\CODING\Flutter SDK\flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision dec2ee5c1f (4 weeks ago), 2024-11-13 11:13:06 -0800
    • Engine revision a18df97ca5
    • Dart version 3.5.4
    • DevTools version 2.37.3

[√] Windows Version (Installed version of Windows is version 10 or higher)

[√] Android toolchain - develop for Android devices (Android SDK version 34.0.0)
    • Android SDK at C:\Users\crazy\Desktop\CODING\AndroidSDK
    • Platform android-34, build-tools 34.0.0
    • ANDROID_HOME = C:\Users\crazy\Desktop\CODING\AndroidSDK

    • Java binary at: C:\Users\crazy\Desktop\CODING\android-studio\jbr\bin\java
    • Java version OpenJDK Runtime Environment (build 21.0.3+-12282718-b509.11)
    • All Android licenses accepted.

[√] Chrome - develop for the web
    • Chrome at C:\Program Files\Google\Chrome\Application\chrome.exe

[√] Visual Studio - develop Windows apps (Visual Studio Enterprise 2022 17.10.5)
    • Visual Studio at C:\Program Files\Microsoft Visual Studio\2022\Enterprise
    • Visual Studio Enterprise 2022 version 17.10.35122.118
    • Windows 10 SDK version 10.0.22621.0

[√] Android Studio (version 2024.2)
    • Android Studio at C:\Users\crazy\Desktop\CODING\android-studio
    • Flutter plugin can be installed from:
       https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
       https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 21.0.3+-12282718-b509.11)

[√] VS Code (version 1.95.3)
    • VS Code at C:\Users\crazy\AppData\Local\Programs\Microsoft VS Code
    • Flutter extension version 3.102.0

[√] Connected device (4 available)
    • sdk gphone64 x86 64 (mobile) • emulator-5554 • android-x64    • Android 13 (API 33) (emulator)
    • Windows (desktop)            • windows       • windows-x64    • Microsoft Windows [Version 10.0.19045.5131]
    • Chrome (web)                 • chrome        • web-javascript • Google Chrome 131.0.6778.109
    • Edge (web)                   • edge          • web-javascript • Microsoft Edge 131.0.2903.86

[√] Network resources
    • All expected network resources are available.

Hi @MaxCheong0114 ,
It seems you are asking for assistance on personal code. Please see https://flutter.dev/community for resources and asking questions like this, you may also get some help if you post it on Stack Overflow with sufficient code sample and explanation.
Closing, as this isn't an issue with Flutter itself. If you believe that this is a bug in the flutter framework, please provide more details and steps to reproduce the issue and we will reopen it.
Thank you


Implement new channel deposit design

Removes Deposit dialog
Replaces Deposit dialog with inline component
Changes layout for Amount input and makes it work on both light/dark background

Closes #126

Yes, probably the dark one is not needed since it is already applied to the whole app. I will remove it and see if that works or breaks something. If it doesn't break anything I will push a fix on top and merge.

@andrevmatos I also named my classes light and dark and my custom property light in the ChannelDeposit.vue component. Do you think that this is confusing? or overlapping somehow with vuetify's own properties?


HTTP 400 Dependency Failures on Cosmos DB

Package Name: azure/cosmos
Package Version: 3.6.2
Operating system: Linux
[x] nodejs

version: v12.0.0

[ ] browser

name/version:

[x] typescript

version: 3.8.2

Describe the bug
We are using Application Insights with an Azure App Service Web App for Containers (REST API) that queries a Azure Cosmos DB.  We only have GET/read endpoints implemented.  The requests are fine from the end point perspective (requests are successfully returning desired documents with 200).  However, I am seeing thousands of HTTP 400 dependency errors for HTTP: POST [cosmosdbname].documents.azure.com/dbs/[dbname]/colls/[collectionanme]/docs
To Reproduce
Link to source code for app showing usage of this sdk: https://github.com/retaildevcrews/helium-typescript/blob/master/src/services/CosmosDBService.ts
Steps to reproduce the behavior:

Follow the instructions here: https://github.com/retaildevcrews/helium to set up the Azure resources and deploy the reference app, choose the typescript version (not c-sharp)
Generate several requests to the app running in app services.
Observe the several dependency failures in app insights (screenshots below)

Expected behavior
Expectation is there to be no 400 dependency failures when the request succeeds.
I believe this is similar to a previous issue in the .NET SDK that has been resolved links: https://github.com/Azure/azure-cosmos-dotnet-v2/issues/606 , https://github.com/Azure/azure-cosmos-dotnet-v3/issues/110
Screenshots

Additional context
Add any other context about the problem here.

This is expected. The .NET issues you linked cover some of the history, but the gist is that the 400 response is an intentional error in response to an query that cannot be served directly by the gateway. We handle this internally and it is not bubbled to the user. You can opt-out of this behavior by forcing a query plan request using the forceQueryPlan option
In v4, we may address this. Likely by splitting out cross partition queries into a separate method, or changing forceQueryPlan to be true by default.

Got it - thank you!


Conversion fields: update mongoengine email and url fields to marshmallow email and url fields

Hi.
As now mongoengine and marshmallow have both specific field types for email and url, I propose to do the direct conversion between those fields instead of using the string field type from marshmallow.
This mainly allows to benefit of marshmallow validators (when loading data to schemas and before using mongoengine).
Tests showing these 2 points are provided.

Coverage remained the same at 95.039% when pulling 641cd98fd45e69630546507fb760436a33669f3d on Nobatek:devDF_fields_email_url into 750044375bd458d038b131f8399364b8965f6277 on touilleMan:master.

Coverage remained the same at 95.039% when pulling 641cd98fd45e69630546507fb760436a33669f3d on Nobatek:devDF_fields_email_url into 750044375bd458d038b131f8399364b8965f6277 on touilleMan:master.

Nice :+1:
I've released a 0.7.7 with this change


feat(schema): add deprecation field attribute

Summary
Add a deprecation record field attribute to identify fields that are deprecated. The attribute requires the message and removed_version fields to be configured, which are used to generate a warning when the deprecated field is configured (uses kong.deprecation).
Checklist

[ ] The Pull Request has tests
[x] A changelog file has been created under changelog/unreleased/kong or skip-changelog label added on PR if changelog is unnecessary. README.md
[ ] There is a user-facing docs PR against https://github.com/Kong/docs.konghq.com - PUT DOCS PR HERE

Issue reference
KAG-3915

the second commit applies the deprecation attribute to the shorthand fields (where the actual field was removed from the schema).

removed_version is confusing because it is in past tense, when it really is about the future.  Maybe removal_in_version?

love it. Can we have a very simple test case to verify the presence of the field in the /schemas/.. output?

@jschmid1 I added a test, since the field is optional we have to test against something that we can make sure will always have a deprecated field, so I added one to the dummy custom plugin (let me know if you were thinking of a better way to test this though)


How does the front end of the system send requests

Excuse me, How does the front end of the system send requests in the img

The unmodified client browser (e.g., chrome) sends a request to Fawkes backend the same way that it sends a request to the default web server. In other words, the user types the address in, after performing DNS lookup and establishing a connection to the backend, chrome sends a request to get the top-level HTML page from the backend.


Extension fails to activate

Hi there, firstly thanks for your work on this extension, it's made me significantly more productive which is why I'm sad it recently broke in my environment!
The extension fails to activate, so all functionality is borked. Here's a dump from the VS Code developer tools console:
/Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:1917 Overwriting grammar scope name to file mapping for scope source.sql.
Old grammar file: file:///Applications/Visual%20Studio%20Code.app/Contents/Resources/app/extensions/sql/syntaxes/sql.tmLanguage.json.
New grammar file: file:///Users/callum/.vscode/extensions/ms-mssql.mssql-1.10.1/syntaxes/SQL.plist
register @ /Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:1917
/Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:62 [Extension Host] (node:19985) [DEP0005] DeprecationWarning: Buffer() is deprecated due to security and usability issues. Please use the Buffer.alloc(), Buffer.allocUnsafe(), or Buffer.from() methods instead.
m @ /Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:62
/Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:1904 Activating extension 'innoverio.vscode-dbt-power-user' failed: r.replace is not a function.
_logMessageInConsole @ /Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:1904

And my platform:
Version: 1.55.2
Commit: 3c4e3df9e89829dce27b7b5c24508306b151f30d
Date: 2021-04-13T09:36:32.643Z (1 wk ago)
Electron: 11.3.0
Chrome: 87.0.4280.141
Node.js: 12.18.3
V8: <IP_ADDRESS>-electron.0
OS: Darwin x64 19.6.0

I'm running dbt 0.19.1. Please let me know if I can share any extra information.

I'm also on 0.19.1 but no issues here. Could you try to downgrade the version of the extension and check if you experience the same with v0.5.1?

I've got the exact same problem (r.replace is not a function) but on a Windows machine and with a fresh install of Python 3.8, dbt 0.19.1 and vscode 1.55.1. Downgrading did not help. Is there any information I can provide to help debug this issue further?

I was able to reproduce the issue. Will try to fix it shortly.

I've released v0.5.3 fixing this issue. Please let me know if you have any issues.

Works like a charm now. Thanks for the update.

Amazing! Thanks for the speedy fix


Cleanup warnings and javadoc

Closing as this is not relevant anymore. Feel free to open a new one.


Update youtube extension

Description

Added tooltips allowing users to see the full text of truncated item titles
Improved style and UX for actions with destructive consequences
Fixed an issue where the shortcuts for the Pin Video and Pin Channel actions were reserved by Raycast
Fixed an issue where the Pin Video and Pin Channel actions were rendered twice in the Action Panel

Checklist

[x] I read the extension guidelines
[x] I read the documentation about publishing
[x] I ran npm run build and tested this distribution build in Raycast
[x] I checked that files in the assets folder are used by the extension itself
[x] I checked that assets used by the README are placed outside of the metadata folder

Looks good to me 🔥
@tonka3000 do you want to check this?


jobs: SGE: Improvement

Change adderTimer from bar to number box, and add exceed alert color.
Things of healing resource need more accurate gauge.
Hide Adder Gauge below lv 45
Due to unknown reason, if you sync to below lv45, addersgall is not availble but memory still says you have 3 addersgall.
Add HP and MP number display
Add Phlegma Timer
Fix missing threholds and reset

Thanks for all the jobs improvements!!


Adding Build Date and Build Time

This PR adds the build time information to the BuildInfo.

In order to release this, we need to work on other pull requests and documents, so we switched from the "master" branch to the "feature/builddatetime" branch.

I'm sorry to tell you that this patch doesn't work for Android as I just noted. Instead of returning the build time, it returns the install time. (iOS works fine though)
Please do not merge to master!
I'm very sorry for the inconvenience caused

Your PullRequest triggered and added a version that can get the build date and time and installation date and time on the develop branch.
Thank you for giving me this opportunity.
Ver 2.0.0 will be released shortly.


[Create Event] When the page is in Ukrainian, the calendar is displayed in English

Environment: MacOS 13.5.1, Google Chrome (120.0.6099.129) .
Reproducible: always
Build found: 08.01.2024
Preconditions:

Go to https://www.greencity.social/#/greenCity (UA)
User is Authorized
Open "Події" page

Steps to reproduce:

Click on 'Створити подію' button
Click on the calendar icon in ''Обрати дату"

Actual result:

A calendar is displayed in which months and days are displayed in English

Expected result:

A calendar is displayed, in which the months are displayed in Ukrainian

User story #3193

https://github.com/ita-social-projects/GreenCityClient/pull/2908


fix /#684 bug redirecting bookmarks

PR Fixes:

1 Added correct course id, content Id

Resolves #[684]
Checklist before requesting a review

[x] I have performed a self-review of my code
[x] I assure there is no similar/duplicate pull request regarding same issue

fixes #684

Closed via https://github.com/code100x/cms/pull/688


support distinct query

Sometimes distinct query is needed when using join.
https://hexdocs.pm/ecto/Ecto.Query.html#distinct/3
Thank you for the great library!
:-D

You're right, shouldn't be too difficult to add.
Thanks!  👍

GOOD 😄


hooks.handle gets called twice

Describe the bug
The hooks.handle function is executed twice "per request" with the new SvelteKit version.
This is bad because (as of all tutorials ive seen on handling auth in SK) i make a db call to find the current user based on the cookie. With the additional request, it ends up making 2 db requests when the user is actually navigating to one page.
If there is any other way to fix this, id appreciate it!
To Reproduce
Steps to reproduce the behavior:

Create routes/+page.svelte and routes/+page.ts.
In routes/+page.ts, execute a trpc call using SvelteKit fetch. (for example, to a procedure named my-procedure
Place a console.log(event.url.pathname).
When you access the page with the browser, your vscode console should print both / and /trpc/my-procedure.

Expected behavior
hooks.handle is executed only once per "navigation" request.
Screenshots
If applicable, add screenshots to help explain your problem.
Desktop (please complete the following information):

OS: pop os
Browser chrome
Version chrome 104, pop os 22 04

closed because of this issue


KEDA unable to access AmazonMQ ActiveMQ REST API

Report
We're integrating KEDA into our EKS cluster and using AmazonMQ with the ActiveMQ engine. We're facing issues with KEDA not being able to access the ActiveMQ REST API. Whenever we try to access the Jolokia API endpoint (https://:8162/api/jolokia), we're being redirected to the main page.
Expected Behavior
keda will get the queue size and thus scale the pods
Actual Behavior
we get this error that the response probably is the main page
2023-04-09T15:37:16Z ERROR scale_handler error getting metric for scaler {"scaledObject.Namespace": "keda", "scaledObject.Name": "service-scaledobject", "scaler": "activeMQScaler", "error": "error inspecting ActiveMQ queue size: invalid character '<' looking for beginning of value"}
Steps to Reproduce the Problem

open an amazonmq with activemq engine
try to connect the keda pod inside an eks cluster to the activemq

Logs from KEDA operator
2023-04-09T15:37:16Z ERROR scale_handler error getting metric for scaler {"scaledObject.Namespace": "keda", "scaledObject.Name": "service-scaledobject", "scaler": "activeMQScaler", "error": "error inspecting ActiveMQ queue size: invalid character '<' looking for beginning of value"}

KEDA Version
2.10.0
Kubernetes Version
1.24
Platform
Amazon Web Services
Scaler Details
hpa
Anything else?
No response

hi,
Could you share your ScaledObject? I'm not an expert about ActiveMQ, but being redirected when you request https://xxxxxxx:8162/api/jolokia sound weird :/. Is your application able to access, or it doesn't access either?

This might be because we do not support Amazon MQ yet, at least it's the first time I hear about it.

Next to Jorge his question, would you mind sharing more logs please?

sorry .. any news on amazonmq support ? .. I can't see this issue in the roadmap.

sorry .. any news on amazonmq support ? .. I can't see this issue in the roadmap.

The issue was closed due to OP inactivity. I'd suggest creating another issue to track your case. Actually, it should work and the only info about now working is the issue but the OP didn't answer anything


Feature flags system design ADR

Ticket
n/a
Changes
see title
Context for reviewers
created a tech spec for how to design the feature flags system
Testing
n/a

PR that implements this spec: https://github.com/navapbc/template-infra/pull/483


Zuul: SendResponseFilter keeps reading data from Origin even when unable to write it to the client

In SendResponseFilter:
	private void writeResponse(InputStream zin, OutputStream out) throws Exception {
		byte[] bytes = new byte[INITIAL_STREAM_BUFFER_SIZE.get()];
		int bytesRead = -1;
		while ((bytesRead = zin.read(bytes)) != -1) {
			try {
				out.write(bytes, 0, bytesRead);
				out.flush();
			}
			catch (IOException ex) {
				// ignore
			}
			// doubles buffer size if previous read filled it
			if (bytesRead == bytes.length) {
				bytes = new byte[bytes.length * 2];
			}
		}
	}

As you can see, failures to write in the request output stream are silently ignored and the method keeps reading data from origin until the stream is fully drained.
A typical scenario is when the client disconnects from Zuul without reading its response. In this case, the Zuul handling thread (a Tomcat/Jetty worker thread) stays busy until the response if fully read from Origin. The only reason I can think of is to fully drain the origin stream before it is closed.
If there is no actual need to drain the input stream before closing it (which is odd imho) - then we probably had better to exit the writeResponse() operation on the first IOException received when writing back to the client.

@brenuart I merged your PR, can this be closed?

Looks good to me.
Thx.


AQCU-772: Allow extremes report generation for single parameter workflows

Coverage decreased (-0.6%) to 86.201% when pulling c83eda309732edade47c626ee694a76cf6f4ae3b on zmoore-usgs:feature/single-param-extremes into 8c68974081860645c923be596bab9ae93f96c3b0 on USGS-R:master.

Coverage increased (+0.2%) to 86.997% when pulling 8e2305ea72d2943706a0a3a4a30dc1c290095d8c on zmoore-usgs:feature/single-param-extremes into 8c68974081860645c923be596bab9ae93f96c3b0 on USGS-R:master.

About the data frames not being saved: I based that part off of the original code for the extremes report which was not saving them either. Somehow the data frames are still being passed out through lapply but I'm not really sure how.. I just figured it was a shortcut or something since the original extremes report code did it and it seems to work somehow here as well.

Ah it's because functions return the last thing evaluated by default but I think it's best to be explicit. Our bad for not catching it in previous could, but can you add it? Save to a var and then have one return statement at the very end.

Ah okay good to know, I wasn't aware of that. Makes a lot more sense now! :smile: Yep, I will make that change!

Coverage increased (+0.2%) to 86.997% when pulling 5cbbb5c8691731a1141795450781a780473f0f31 on zmoore-usgs:feature/single-param-extremes into 7500d04e4d697600e9d25195bac61c0b861039d8 on USGS-R:master.

Coverage increased (+0.2%) to 86.997% when pulling 5cbbb5c8691731a1141795450781a780473f0f31 on zmoore-usgs:feature/single-param-extremes into 7500d04e4d697600e9d25195bac61c0b861039d8 on USGS-R:master.

Coverage increased (+0.2%) to 87.008% when pulling 5cbbb5c8691731a1141795450781a780473f0f31 on zmoore-usgs:feature/single-param-extremes into 7500d04e4d697600e9d25195bac61c0b861039d8 on USGS-R:master.


Backporting a method reference to interface enum methods fails

Hi,
Please consider the following code. A simple interface that associates a parameterized key with an object:
public interface IIdentifiable<K> {

    @Nonnull
    K getId();

}

A special test enum whose members are associated with a key:
public enum BinaryDigit implements IIdentifiable<Integer> {

    ZERO(0),
    ONE(1);

    private final Integer id;

    BinaryDigit(final Integer id) {
        this.id = id;
    }

    @Override public final Integer getId() {
        return id;
    }

}

An utility method that builds an IIdentifiable-enum index using Google Guava:
public static <K, E extends Enum<E> & IIdentifiable<K>> Map<K, E> enumIndexOf(final Class<E> type) {
    return uniqueIndex(asList(type.getEnumConstants()), e -> {
        return e.getId();
    });
}

Please note that the last method lambda can be simplified to a method reference like this:
public static <K, E extends Enum<E> & IIdentifiable<K>> Map<K, E> enumIndexOf(final Class<E> type) {
    return uniqueIndex(asList(type.getEnumConstants()), E::getId);
}

Once this refactoring is performed, the Retrolambda (I'm using the Maven plugin) is not able to backport the method reference producing the following error during the build:
Caused by: java.lang.invoke.LambdaConversionException: Invalid receiver type class java.lang.Enum; not a subtype of implementation type interface halo.base.IIdentifiable
    at java.lang.invoke.AbstractValidatingLambdaMetafactory.validateMetafactoryArgs(AbstractValidatingLambdaMetafactory.java:233)
    at java.lang.invoke.LambdaMetafactory.metafactory(LambdaMetafactory.java:303)
    at java.lang.invoke.MethodHandle.invokeWithArguments(MethodHandle.java:625)
    at java.lang.invoke.MethodHandle.invokeWithArguments(MethodHandle.java:647)
    at net.orfjackal.retrolambda.lambdas.LambdaReifier.callBootstrapMethod(LambdaReifier.java:110)
    at net.orfjackal.retrolambda.lambdas.LambdaReifier.reifyLambdaClass(LambdaReifier.java:37)
    ... 37 more

My JDK version is <IP_ADDRESS> (64). Could you please check? Thanks!

(Also it was difficult to find out which class fails. Is it possible to configure the Retrolambda Maven plugin to report which classes and methods fail to be backported? Currently the plugin only reports the previously saved lambdas like Saving lambda class: foo/bar/Baz$$Lambda$1, and I couldn't find the failed classes even with the Maven option -X set on.)

Thanks. I've located that the thing which triggers this bug is E extends Enum<E> & IIdentifiable<K>. The bytecode which creates the method reference thinks that the getId method is on the Enum class, when in reality it is on the IIdentifiable interface. I'll continue planning a fix for it.

@orfjackal thank you. One more question please: would it be possible to mention problematic classes like BinaryDigit in the error message as well for similar exceptions? It would be very and very nice to have a little more detailed message if possible.

Error reporting improved. Earlier it reported only problematic lambda classes. Now it reports all classes.

@orfjackal this is great, thank you! :)

And now it reports also the lambda/method reference which caused the problem. :)

The improved error messages is included in Retrolambda 2.1.0. The fix for this issue is still under work.

issue


Mirror all tarballs from conda builds to depot

Track the bioconda repo and as soon as a PR get's merged we should parse the meta.yaml file and download the needed tarballs and mirror them to the Galaxy depot.
For this we need depot access from @natefoo. Nate has admin access to this repo and can remove the token at any time.
Obstacles:

meta.yaml file can define a git_url and a git_rev. Not sure how we want to mirror this or if we need to.
In theory you can fetch other resources in conda inside the build.sh script these we can not determine easily. But I think this should be handled and forbidden on the bioconda side.

This is implemented in https://github.com/galaxyproject/cargo-port/pull/93


File Uploads Failing

When attempting to upload files to a project the upload fails out.

[Error] XMLHttpRequest cannot load https://cord-v3-dev-files.s3.us-east-2.amazonaws.com/temp/JO2fdG8hB?X-Amz-Algorithm=AWS4-HMAC-SHA256&X-Amz-Credential=ASIA26P4M43DQAG5CG33%2F20200824%2Fus-east-2%2Fs3%2Faws4_request&X-Amz-Date=20200824T164031Z&X-Amz-Expires=900&X-Amz-Security-Token=IQoJb3JpZ2luX2VjEL7%2F%2F%2F%2F%2F%2F%2F%2F%2F%2FwEaCXVzLWVhc3QtMiJHMEUCIQDtgOXGbMAXrlHD0Fp6CCfY2HR1mQ0fMqdNN7rKtz7HTQIgMJc8lF2hRkWm0k2bXifGedwWLgdKZD%2Fd1EQjLGUv7dQq8QMIp%2F%2F%2F%2F%2F%2F%2F%2F%2F%2F%2FARABGgw3NTI2ODU0NzU1MjciDMuvviNN2G8ZPec6OCrFAwIDJ2QPDTTCcnBs8%2FmFv31TVqMcSpxiYsyUil9u7O%2BH%2FQIDx6ILYpJxYkxQ6vwhm6g2r1o7z5BYNI3y0aX1x98WOBUGkD5mBfPvRj0FfjLysawUXgtDUBz62%2BFykrRMHtLRvsxT2r4dr6HDy6NHi5A2cLoxEp%2FJelGjihRDrzqZXdpJqhwB1Dc5Ui3GFY%2B3NpTA9nyRfySWfdUmN%2FsVJK3Mr%2FY5NAYfXifcvz530L%2FjE6piVLPdzi6WlnahXIB%2FoOHT4m6sDV817NBqDt30qRuVd6%2B9qovWQEjW5ogMp5Bu4YEDN43FNKTxXf%2Fz7%2BRRDkfqudCSsInZqKhA5HnshWG%2F4sjwFNGUmBEgsq%2B6b3n%2BKCO6c3NMg7q5d6rX9Y24XOJn4Nns0v%2BQWWBAAWgzF8LDh7XQAz9lEP0bNYxVi25UnupZPsjEmlcnMmV1I9vzG77TcPBQUN1VAaw9njYtWYaywYtIuJhPrYNGo5P7Ew2XcIhNAn%2BWtCEj70z1kFQp0mYqAyIIc4gl5AYfn6r%2Bz5X5ugmpsPSbRsPhcz%2F3xTNRbfzybopLFdZfNnSIPRjl3NxNpqBTqbdEFyeh2RKhiLYstNm%2FVDDvlY%2F6BTrvAUdcG8UTnAFGoScmBDh0PpGMW1HP9uR7tQpz3IBZhIFm3lsJLDdqJUR5cSvcmB7RZmSCgHkJxv7D55hvi%2B2PbusprQLYG5uPMrj81kaO1guMUBw%2FVOrjlhyP4quq%2F3G575wh6OpjoOgLc5ethO%2FOd9BEhT0M56kuLvmxNYbZSDn2jC6H%2BjcnXqqaO3g54QG7Fup3Ihb%2BePZfFZriR5HwbxHh8hNfwQM%2FGu7vwz2VxT9YEYNxhDm4857vwxZvHkVs5yBD0koSnCQJgl2E%2FusXbflKIOGsTlJ9TaB9ajT3coloNn2NaRVrOszqMDI1RO3u&X-Amz-Signature=6eab2b0b3c893ee967e12031f515e5a89719dba3ec43c32927ccebb66693b1b7&X-Amz-SignedHeaders=host due to access control checks.
[Error] Failed to load resource: Preflight response is not successful (JO2fdG8hB, line 0)

Fixed S3 CORS config in infrastructure code


Minimal aiohttp streamreader support

First off, I love vcrpy, great work @kevin1024, thank you for giving this to the world :-)
This is a minimal-effort PR to make the MockClientResponse object contain a streamreader object that's fairly similar to the one a real aiohttp ClientResponse object contains.  I've built this as a wheel and included in my own project and this works fine for my use cases (on code that's been run hundreds or thousands of time, but has not been properly tested until now).
I'd love for this (or something based on this) could get included in vcrpy.  Will you take a look and let me know what you think?

@steinnes  can you please rebase your branch on master in order to run the Travis CI ?

Thanks for responding @arthurHamon2, I'm going to rewrite the test to avoid async keywords.


[1.11] Add detect_ip to diagnostics bundle

High-level description
Bacports: https://github.com/dcos/dcos/pull/4394
Corresponding DC/OS tickets (obligatory)
These DC/OS JIRA ticket(s) must be updated (ideally closed) in the moment this PR lands:

DCOS_OSS-4757 Include detect_ip in dcos-diagnostics bundle

Related tickets (optional)
Other tickets related to this change:

DCOS_OSS- Foo the Bar so it stops Bazzing.

Checklist for all PRs

[ ] Added a comprehensible changelog entry to CHANGES.md or explain why this is not a user-facing change:
[ ] Included a test which will fail if code is reverted but test is not. If there is no test please explain here:
[ ] Read the DC/OS contributing guidelines
[ ] Followed relevant code rules Rules for Packages and Systemd

Checklist for component/package updates:
If you are changing components or packages in DC/OS (e.g. you are bumping the sha or ref of anything underneath packages), then in addition to the above please also include:

[ ] Change log from the last version integrated (this should be a link to commits for easy verification and review): example
[ ] Test Results: [link to CI job test results for component]
[ ] Code Coverage (if available): [link to code coverage report]

PLEASE FILL IN THE TEMPLATE ABOVE / DO NOT REMOVE ANY SECTIONS ABOVE THIS LINE
Instructions and review process
What is the review process and when will my changes land?
All PRs require 2 approvals using GitHub's pull request reviews.
Reviewers should be:

Developers who understand the code being modified.
Developers responsible for code that interacts with or depends on the code being modified.

It is best to proactively ask for 2 reviews by @mentioning the candidate reviewers in the PR comments area. The responsibility is on the developer submitting the PR to follow-up with reviewers and make sure a PR is reviewed in a timely manner. Once a PR has 2 ship-it's, no red reviews, and all tests are green it will be included in the next train.

@mesosphere-mergebot label Ready For Review
:wave:  @mrnugget @drewvanstone @br-lewis Can you review, please?

:wave:  @mrnugget @drewvanstone @br-lewis Can you review, please?

@mesosphere-mergebot sync

@mesosphere-mergebot sync

@mesosphere-mergebot sync

@mesosphere-mergebot sync

:wave:  @mrnugget @drewvanstone @br-lewis Can you review, please?

@mesosphere-mergebot sync


python llvmlite: fix by using llvm_36

This should fix llvmlite. Haven't tested it yet though.

@domenkozar This seems to work. Can you merge?

Gladly, thanks!


Remove AWS Logs agent requirements from AWS Deploy docs

We will not be installing and configuring the AWS Logs agent going forward so we should adjust the docs to reflect that.

WOR-8129 was where this decision was made


FirestorePagingAdapter setSnapshotArray

Currently, I am using FirestoreRecyclerAdapter on my RecyclerViews to save their scroll positions upon fragment destroy (I use Android Jetpack Navigation Components).
This is how I do it: https://proandroiddev.com/fui-rv-state-a66833c3bb88
I want to switch to FirestorePagingAdapter to improve the performance of my app, but it seems that I cannot save my recyclerview's scroll positions because FirestorePagingAdapter always queries for the data upon start.

Update: I did manage to use modify FirestorePagingAdapter and FirestorePagingOptions to use the existing LiveData from my ViewModel:
private val config =         PagedList.Config.Builder()             .setEnablePlaceholders(false)             .setPrefetchDistance(2)             .setPageSize(2)             .build()     private val factoryPetShop =         FirestoreDataSource.Factory(firestoreRepo.getPets(), Source.DEFAULT)     val liveDataPetShop = LivePagedListBuilder(factoryPetShop, config).build()

How did you extend FirestorePagingOptions if it is final? did you fetch and modified it? If yes how do you rebuild it to be a library into a project?
Thanks

Update: I did manage to use modify FirestorePagingAdapter and FirestorePagingOptions to use the existing LiveData from my ViewModel:
ViewModel:
private val config =
    PagedList.Config.Builder()
        .setEnablePlaceholders(false)
        .setPrefetchDistance(2)
        .setPageSize(2)
        .build()
private val factoryPetShop = FirestoreDataSource.Factory(firestoreRepo.getPets(), Source.DEFAULT)
val liveDataPetShop = LivePagedListBuilder(factoryPetShop, config).build()

FirestorePagingOptions:
fun build(data : LiveData<PagedList<DocumentSnapshot>>, modelClass: Class<T>): FirestorePagingOptions<T> {
    val parser = ClassSnapshotParser(modelClass)
    return FirestorePagingOptions(data, ClassSnapshotParser(modelClass), DefaultSnapshotDiffCallback(parser), mOwner)
}

I know this can be better, but this is just what I need for my app. But still, hoping this feature can be added.

How did you extend FirestorePagingOptions if it is final? did you fetch and modified it? If yes how do you rebuild it to be a library into a project?
Thanks

Update: I did manage to use modify FirestorePagingAdapter and FirestorePagingOptions to use the existing LiveData from my ViewModel:
ViewModel:
private val config =
    PagedList.Config.Builder()
        .setEnablePlaceholders(false)
        .setPrefetchDistance(2)
        .setPageSize(2)
        .build()
private val factoryPetShop = FirestoreDataSource.Factory(firestoreRepo.getPets(), Source.DEFAULT)
val liveDataPetShop = LivePagedListBuilder(factoryPetShop, config).build()

FirestorePagingOptions:
fun build(data : LiveData<PagedList<DocumentSnapshot>>, modelClass: Class<T>): FirestorePagingOptions<T> {
    val parser = ClassSnapshotParser(modelClass)
    return FirestorePagingOptions(data, ClassSnapshotParser(modelClass), DefaultSnapshotDiffCallback(parser), mOwner)
}

I know this can be better, but this is just what I need for my app. But still, hoping this feature can be added.

How did you extend FirestorePagingOptions if it is final? did you fetch and modified it? If yes how do you rebuild it to be a library into a project?
Thanks

Yep. Just copied the whole files into my project. I didn't rebuilt the libraries.

Does this also solve the fact that the adapter re-fetches the data every time you leave and come back? I'm having tremendous trouble fixing this. Whenever I click an item and come back to the list, the query is re-run, same with orientation changes.

Does this also solve the fact that the adapter re-fetches the data every time you leave and come back? I'm having tremendous trouble fixing this. Whenever I click an item and come back to the list, the query is re-run, same with orientation changes.

It does it for me. The data set is saved and scroll position is restored.

I see you use a FirestoreDataSource and pagedlist, can you share how you query to make the datasource work? Thanks!

This has been released in 7.1.0


AMBARI-25912: use LinkedBlockingQueue in AgentsRegistrationQueue for performance improvement

What changes were proposed in this pull request?
Background
The AgentRegisteringQueueChecker is an interceptor used during the long connection between the agent and server, mainly for requesting congestion control. It internally uses AgentsRegistrationQueue to store the sessionID of connections.
The sessionID is added to the AgentsRegistrationQueue when the ambari agent registers to the server or sends a heartbeat.
When the long connection between the agent and server is disconnected, or when the server completes the heartbeat request, the sessionID is removed from the AgentsRegistrationQueue.
When the queue is full, the server returns "not allowed" to the agent.
Solution
AgentsRegistrationQueue uses ArrayBlockingQueue, which uses the same lock for both writing and consuming, making it easy to negatively impact performance when dealing with large clusters. Therefore, we are switching to using LinkedBlockingQueue in order to improve performance.
How was this patch tested?
unit tests

Can you also share any benchmark report?

@bhavikpatel9977 ok.
The lock contention of LinkedBlockingQueue is much lower than ArrayBlockingQueue in high-concurrency situations, resulting in a significant performance improvement. LinkedBlockingQueue is the most commonly used queue in concurrent scenarios. There have been numerous tests conducted on this. You can find more information in this link: https://stackoverflow.com/questions/5102570/implementation-of-blockingqueue-what-are-the-differences-between-synchronousque
public class Test {
    static ExecutorService e = Executors.newFixedThreadPool(2);
    static int N = 1000000;

    public static void main(String[] args) throws Exception {
        for (int i = 0; i < 10; i++) {
            int length = (i == 0) ? 1 : i * 5;
            System.out.print(length + "\t");
            System.out.print(doTest(new LinkedBlockingQueue<Integer>(length), N) + "\t");
            System.out.print(doTest(new ArrayBlockingQueue<Integer>(length), N) + "\t");
            System.out.print(doTest(new SynchronousQueue<Integer>(), N));
            System.out.println();
        }

        e.shutdown();
    }

    private static long doTest(final BlockingQueue<Integer> q, final int n) throws Exception {
        long t = System.nanoTime();

        e.submit(new Runnable() {
            public void run() {
                for (int i = 0; i < n; i++)
                    try { q.put(i); } catch (InterruptedException ex) {}
            }
        });

        Long r = e.submit(new Callable<Long>() {
            public Long call() {
                long sum = 0;
                for (int i = 0; i < n; i++)
                    try { sum += q.take(); } catch (InterruptedException ex) {}
                return sum;
            }
        }).get();
        t = System.nanoTime() - t;

        return (long)(1000000000.0 * N / t); // Throughput, items/sec
    }
}

@JiaLiangC Thanks for the detailed explanation.
+lgtm

@virajjasani Could you please review this PR?

thanks for the review @bhavikpatel9977


Make default time formatting more user friendly

I think making the default timeFormatter more robust will improve usabillity and help those who want to use the framework almost out of the box. Otherwise, this may not be considered a functional requirement.

The reason why I haven't done that is that it's difficult to do the translations for relative time strings. For this purpose I recommend using moment.js, which has a comprehensive support for different languages


Enable global load balancer and extra SANs

Move from regional to global load balancer
Adds support for custom DNS names in the TLS certs

The global LB takes about 3m more on average to provision and become healthy.

Hey @bgeesaman
Thanks for this. I'm going to hold off until after KubeCon to test and review this. I just don't have the cycles at the moment, sorry 😄

Of course!  I just had some cycles on the plane ride out here.
On Mon, Dec 10, 2018 at 6:38 AM Seth Vargo<EMAIL_ADDRESS>wrote:

Hey @bgeesaman https://github.com/bgeesaman
Thanks for this. I'm going to hold off until after KubeCon to test and
review this. I just don't have the cycles at the moment, sorry 😄
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/sethvargo/vault-on-gke/pull/25#issuecomment-445837677,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ADmFCQ369VlhHIW4GcetJwzEXcL9Iq99ks5u3nH2gaJpZM4ZKV4W
.

Reviewing this further, I think it might make the most sense to generate a separate keypair with just the public IP and optional custom hostnames for use by the GCLB front end.  The existing cert can remain as-is.  This would prevent the external exposure of a cert with SANs of localhost and <IP_ADDRESS>


Calendar not showing events when navigating from initial load or filtering

The initial load of the calendar seems to work fine. All events are displayed as expected, but when we navigate to a different month or filter by location no events are displayed even when we navigate back to the starting month and/or location. Since I am not seeing anyone else with this issue, I am assuming it has something to do with our event module settings or our DNN version. Has anyone had this issue or have any ideas on what settings I may need to adjust to fix this issue? You can see a live version of the problem at http://www3.pinellashomeless.org/Events
Again, notice that that the events show fine initially but try to go to the next month and you will see there are no events shown and if you navigate back to the current month the calendar is still blank.

I expect that this can be related to javascript/skin conflict sith the DNN defaults. Have you tried the default DNN skin?

I just tried with a default skin and have the same problem.

The calendar is based on a Telerik control. Is there something wrong with the Telerik dll version?

I have the same problem (Fresh install DNN 7.4.2). I seen only this here in Event Detail:
   < ; td class = "Subhead">      < ; / table>
  < ; tr valign = "top">      [IFTIMEZONEDISPLAY] [/ IFTIMEZONEDISPLAY]  : Createddatelabel
In Week:
n. Chr. [. NOTALLDAYEVENT] [ALLDAYEVENT] 19 [. ALLDAYEVENT] 	n. Chr. [. NOTALLDAYEVENT] [ALLDAYEVENT] 19 [. ALLDAYEVENT]

I am not able to reproduce the problem. Tried various combinations of settings, categories, locations, etc.

Hi All,
I had a similar problem this week with events not appearing after navigating to a different date on the calendar and finally tracked down the problem. A full breakdown of the problem and the fix is included in the attached PDF at the end of this comment. If you don't want to read the full story then go into the 'settings' - 'General settings' tab of the Events module. Under 'Look and Feel' there are two settings to be careful of, 'Enable Category Select' and 'Enable Location Select'. Be sure to leave these set to 'Do Not Display' if you do not have any entries on your category List or Locations List.
Thanks to the DNNEvents team for their work over the years 'maturing' it into an excellent module.
Cheers
Bryn
BrynSmith_DnnEventsNotAppearingAnswer.pdf

Tnx for the feedback on your debugging! This opens an option to solve it in an upcoming release...
Met vriendelijke groet,
Ernst Peter Tamminga
Op 5 dec. 2015 om 02:59 heeft Alderside <notifications<EMAIL_ADDRESS>het volgende geschreven:
Hi All,
I had a similar problem this week with events not appearing after navigating to a different date on the calendar and finally tracked down the problem. A full breakdown of the problem and the fix is included in the attached PDF at the end of this comment. If you don't want to read the full story then go into the 'settings' - 'General settings' tab of the Events module. Under 'Look and Feel' there are two settings to be careful of, 'Enable Category Select' and 'Enable Location Select'. Be sure to leave these set to 'Do Not Display' if you do not have any entries on your category List or Locations List.
Thanks to the DNNEvents team for their work over the years 'maturing' it into an excellent module.
Cheers
Bryn
BrynSmith_DnnEventsNotAppearingAnswer.pdfhttps://github.com/DNNCommunity/DNN.Events/files/52692/BrynSmith_DnnEventsNotAppearingAnswer.pdf
—
Reply to this email directly or view it on GitHubhttps://github.com/DNNCommunity/DNN.Events/issues/15#issuecomment-162126284.
CEO
[XCESS expertise center b.v.]https://www.xcess.nl/    XCESS expertise center b.v.
Storkstraat 19
3833 LB Leusden, NL
I www.xcess.nlhttps://www.xcess.nl    M
D
T
E
+31-6-21564750
+31-33-4335101
+31-33-4335151
<EMAIL_ADDRESS>
Dit e-mail bericht is alleen bestemd voor de geadresseerde, verstrekking aan en gebruik door anderen is niet toegestaan. Indien u niet de geadresseerde bent, wordt u vriendelijk verzocht de verzender hiervan op de hoogte te stellen en het bericht te verwijderen. In verband met de elektronische verzending kunnen aan de inhoud van dit bericht geen rechten worden ontleend. Tenzij schriftelijk anders is overeengekomen, zijn op al onze rechtsbetrekkingen de XCESS leveringsvoorwaardenhttps://www.xcess.nl/Portals/0/Downloads/[XCESS] Algemene Leveringsvoorwaarden08052008NL.pdf van toepassing. Deze zijn gedeponeerd bij de Kamer van Koophandel Amersfoort onder nummer 31047117 en bij de griffie van de arrondissementsrechtbank te Amsterdam onder nummer 36/2003 en worden op verzoek toegezonden. Toepasselijkheid van eventuele inkoop- of andere voorwaarden van opdrachtgever dan wel van derden wordt dan ook uitdrukkelijk van de hand gewezen door XCESS.


Release of version <IP_ADDRESS> of SecurityPolicyDsc

Releasing version <IP_ADDRESS>

This change is

Codecov Report

Merging #103 into master will increase coverage by 1%.
The diff coverage is 92%.

@@          Coverage Diff          @@
##           master   #103   +/-   ##
=====================================
+ Coverage      81%    83%   +1%
=====================================
  Files           5      5
  Lines         431    439    +8
=====================================
+ Hits          353    367   +14
+ Misses         78     72    -6


Problem with Objective-C lexer

(Original issue 638 created by None on 2011-02-17T09:43:56.489458+00:00)
In the following chunk of code, the second "@implementation" isn't highlighted but marked as an error:
{{{
#!objc
@implementation ABC

(id)a:(B)b {
return 1;
}

@end
@implementation ABC

(void)xyz;

@end
}}}

(Original issue 638 last updated on 2011-06-18T10:02:40.556793+00:00)
(Issue automaticaly closed due to status in Bitbucket: resolved)

(Original comment by None on 2011-02-17T10:39:24.774621+00:00)
This problem is, that you do not recognize methods so the lexer thinks it is a statement which must be terminated with a semicolon. I've added this to the 'root' set of rules:
{{{
#!python
        # methods
        (r'^([-+])(\s*)'                         # method marker
         r'(\(.*?\))?(\s*)'                      # return type
         r'([a-zA-Z$_][a-zA-Z0-9$_]*:?)',        # begin of method name
         bygroups(Keyword, Text, using(this),
                  Text, Name.Function),
         'method'),

}}}
and this as a new rule:
{{{
#!python
    'method': [
        include('whitespace'),
        (r'(\(.*?\))([a-zA-Z$_][a-zA-Z0-9$_]*)', bygroups(using(this), Name.Variable)),
        (r'[a-zA-Z$_][a-zA-Z0-9$_]*:', Name.Function),
        (';', Punctuation, '#pop'),
        ('{', Punctuation, 'function'),
        ('', Text, '#pop'),
    ],

}}}

(Original comment by birkenfeld on 2011-06-18T10:02:40.546267+00:00)
This addition seems to work well. Applied in <>, thanks!


Publish dev image to Docker hub

Description:
Users would benefit from availability of envoy gateway dev (aka @latest) image in Docker hub, not to block on waiting for the upcoming release. Similar to how envoy does it: https://hub.docker.com/layers/envoyproxy/envoy/dev/images/sha256-9c104c9cbaeca4594d643e8e113c57be15d49e2df0df1dab51f6372e47bf10a4?context=explore
[optional Relevant Links:]

Any extra documentation required to understand the issue.

Closing, found this: https://hub.docker.com/r/envoyproxy/gateway-dev/tags


Problem with hostid

Hi all, I've a question/problem. I have one zfs partition, one zpool, that contain dataset for arch/void/opensuse and freebsd. For booting linux distros I use zfsbootmenu ad this is fantastic. But when I booted freebsd at reboot I found hostid 000000 on linux distros and void and opensuse cannot boot. I've partialy solved with skip on recovery shell of zfsbootmenu and export pool, write hostid and import pool. On freebsd I've setted same hostid of linux. How can I solve this?

What kernel command line shows up at the top of your ZFSBootMenu screen before you try to boot but fail?

On arch line I've "rpool/arch-gnome/root (r/o) - vmlinuz-linux rw spl_hostid=00000000"

Setting spl_hostid=00000000 on the command-line is a last-ditch effort by ZFSBootMenu, but this is known to work only with dracut. Arch's mkinitcpio will not respect spl_hostid values.
The reason ZBM is trying to set spl_hostid instead of the module-level spl.spl_hostid is that the module interprets a zero value as "get the hostid from /etc/hostid".
Generally, hostid is a concept that is more trouble than it's worth. We've spent a lot of effort trying to work around some of the warts, but some are unavoidable. Your only shot here is to make sure all of your systems share a hostid. You can also try setting zbm.import_policy=force and make sure that the ZFSBootMenu image has the expected value in /etc/hostid.
I'm kicking this to discussions, as it isn't really a ZFSBootMenu issue.


Enables cd permissions for plugin-signpath

Link to GitHub repository
https://github.com/jenkinsci/signpath-plugin
If you are modifying the release permission of your plugin or component, fill out the following checklist:

### Release permission checklist (for submitters)
- [ ] The usernames of the users added to the "developers" section in the .yml file are the same the users use to log in to [accounts.jenkins.io](https://accounts.jenkins.io/).
- [ ] All users added have logged in to [Artifactory](https://repo.jenkins-ci.org/) and [Jira](https://issues.jenkins.io/) once.
- [ ] I have mentioned an [existing team member](https://github.com/orgs/jenkinsci/teams) of the plugin or component team to approve this request.

When enabling automated releases (cd: true)
Follow the documentation to ensure, your pull request is set up properly. Don't merge it yet.
In case of changes requested by the hosting team, an open PR facilitates future reviews, without derailing work across multiple PRs.
Link to the PR enabling CD in your plugin
In this PR
### CD checklist (for submitters)
- [ ] I have provided a link to the pull request in my plugin, which enables CD according to the documentation.

### Reviewer checklist
- [ ] Check that the `$pluginId Developers` team has `Admin` permissions while granting the access.
- [ ] In the case of plugin adoption, ensure that the Jenkins Jira default assignee is either removed or changed to the new maintainer.
- [ ] If security contacts are changed (this includes add/remove), ping the security officer (currently `@Wadeck`) in this pull request. If an email contact is changed, wait for approval from the security officer.

There are IRC Bot commands for it.

You forgot to fill out the PR template.

You forgot to fill out the PR template.

Hello, sorry for the late reply, the message got lost on me. I don't understand the template. All I want to do is enabled the automated releases. It says to reference the PR that is performing this change. From my understanding, this very PR that I am commenting on is the one.

It should be a PR in this repository for making the Maven and GitHub workflow changes required:
https://github.com/jenkinsci/signpath-plugin
see
https://www.jenkins.io/doc/developer/publishing/releasing-cd/

Thank you @timja - and again sorry for the delay. GitHub notification unfortunately go nowhere for me. There is no such PR in https://github.com/jenkinsci/signpath-plugin, we've fulfilled all the criteria (as far as I can tell) separately and most of them from the beginning.
All that's missing is the change in this (jenkins-infra repo) PR.

As far as I can tell you've done none of https://www.jenkins.io/doc/developer/publishing/releasing-cd/
Please check it closer

Dear @timja
thank you for guiding us through the release process. Could you please check this PR:
https://github.com/jenkinsci/signpath-plugin/pull/17
regards,
Volodymyr

As far as I can tell you've done none of jenkins.io/doc/developer/publishing/releasing-cd (apart from this PR) Please check it closer

But this PR doesn't address https://www.jenkins.io/doc/developer/publishing/releasing-cd/#update-maven-pom-and-config at all.

But this PR doesn't address https://www.jenkins.io/doc/developer/publishing/releasing-cd/#update-maven-pom-and-config at all.

Thank you for your thorough review.
This part was already in the main branch, which is why it is not in the pull request. I should have mentioned it in the PR description. See the following files:

https://github.com/jenkinsci/signpath-plugin/blob/main/.mvn/maven.config
https://github.com/jenkinsci/signpath-plugin/blob/main/pom.xml

We would like to have a manually controlled prefix. The only difference that I see, and which I'm not sure about, is in the maven.config file.
In the example, the revision is set to 1 - <revision>1</revision>. We already have version 2.0.1, so ideally, we would like to continue versioning if possible.
Additionally, the second one, <changelist>999999-SNAPSHOT</changelist>, is empty in our codebase: <changelist></changelist>.
regards,
Volodymyr

Hi @timja and @NotMyFault,
I wanted to follow up on my last comment. We've already made the required changes in the main branch, which is why they aren't reflected in this PR. Here are the files for your reference:
.mvn/maven.config
pom.xml
Could you please review and let us know if anything else is needed? We’re eager to move forward and appreciate your guidance.
Thanks,
Volodymyr

These two lines (version and changelist) are still not correct, please review the documentation and adapt:
https://github.com/jenkinsci/signpath-plugin/blob/e0b85b951934c0e03ef88194af3414dbb96ec5ef/pom.xml#L12
https://github.com/jenkinsci/signpath-plugin/blob/e0b85b951934c0e03ef88194af3414dbb96ec5ef/pom.xml#L16

Hi @timja
Thank you for the review.
I've created a new pull request to address the changes you mentioned:
https://github.com/jenkinsci/signpath-plugin/pull/25
Thanks,
Volodymyr

Hi @timja and @NotMyFault,
I wanted to follow up on my pull request. Have you had a chance to review it?
https://github.com/jenkinsci/signpath-plugin/pull/25
Thanks,
Volodymyr

Hi @timja and @NotMyFault,
I wanted to follow up on my pull request. Have you had a chance to review it? jenkinsci/signpath-plugin#25
Thanks, Volodymyr

I reviewed https://github.com/jenkinsci/signpath-plugin/pull/25 on August 19th and you haven't responded to the review =/

Hi @timja, thank you for your review.
Your last finding has now been addressed:

These two lines (version and changelist) are still not correct, please review the documentation and adapt:
https://github.com/jenkinsci/signpath-plugin/blob/e0b85b951934c0e03ef88194af3414dbb96ec5ef/pom.xml#L12
https://github.com/jenkinsci/signpath-plugin/blob/e0b85b951934c0e03ef88194af3414dbb96ec5ef/pom.xml#L16

These two lines have been updated and now align with the "Manually controlled prefix (optional)" version approach.
Is there anything else we need to enable for CD?

Hi @timja and @NotMyFault,
I wanted to check in again regarding the pull request. Do you think we’re ready to proceed with enabling CD?
Thanks for your time,
Volodymyr

Sorry not sure what happened here I should have merged when I approved your other PR


Windows CI Reliablity: TestLogsApiWithStdout

Signed-off-by: John Howard<EMAIL_ADDRESS>TestLogsApiWithStdout is another test I've seen a few windowsTP4 failures on. Bumping the timeout up to hopefully alleviate the flakiness.

LGTM

LGTM 🐮


[QUERY]question about distributed tracing with opentelemtry and Azure Monitor Exporter

Query/Question
Hi, My team would like to collect and consume traces by using Opentelemtry and Azure Monitor exporter. We still have some questions and hope you could help us.
the first question: I found the sampling supported in Opentelemtry is not supported in Azure Monitor Opentelemtry Exporter according to this guide: https://docs.microsoft.com/en-us/azure/azure-monitor/app/opentelemetry-enable?tabs=net . so, for the latest version, is it supported?
the second question: I succeed to run my web app and the data showed up in the AppInsights. but, in the transaction detail, it showed 0 traces.

it should have 1 trace with 5 spans. I don't know why it shows 0 traces
Environment:
Azure.Monitor.OpenTelemetry.Exporter 1.0.0-beta.3
.NET 5.0
Opentelemetry  1.20-beta1

@pockyhe
Azure Monitor OpenTelemetry Exporter for .NET, Node.js,and Python applications is currently in PREVIEW. Thus, there are several limitations with it currently. Sampling is not supported in Azure Monitor OpenTelemetry Exporter at this time.
Please keep an eye on Azure updates page for the General availability (GA) of this feature.
For the second question,
I succeed to run my web app and the data showed up in the AppInsights. but, in the transaction detail, it showed 0 traces.
Can you please confirm if you did enable sampling in OpenTelemetry?
As mentioned under Warning in the document:
Enabling sampling in OpenTelemetry will make standard and log-based metrics extremely inaccurate which will adversely impact all Application Insights experiences. **Additionally, enabling sampling alongside the existing Application Insights SDKs will result in broken traces.**

@pockyhe Did you get a chance to look at the comment above and did it help resolve your query? Please let me know. Thanks.

Thanks for bringing this to our attention. We will now close this issue. If there are further questions regarding this matter, please tag me in a comment. I will reopen it and we will gladly continue the discussion.


istio-egressgateway/ istio-proxy container is not Ready

Is this the right place to submit this?

[X] This is not a security vulnerability or a crashing bug
[X] This is not a question about how to use Istio

Bug Description
Hi team
Istio has fully supported dual-stack? I installed istio v1.17.6 on IPv6 primary dual-stack cluster, istio-egressgateway/istio-proxy container  isn't ready. Set log to debug, find some doubts. Details as below:

pod status
#kubectl get pods -A -owide|grep istio istio-system                        istio-egressgateway-5df76c8f8c-wnsk4                             0/1     Running     0             13m     fd10:100:64:1::1f      ipv6-primary-dual-stack-mc-md-0-d2r59-6f7f7cf6d5xk6zd8-bnnwm   <none>           <none>

describe pod
  Normal   Created    13m                   kubelet            Created container istio-proxy Normal   Started    13m                   kubelet            Started container istio-proxy Warning  Unhealthy  3m2s (x310 over 13m)  kubelet            Readiness probe failed: Get "http://[fd10:100:64:1::1f]:15021/healthz/ready": dial tcp [fd10:100:64:1::1f]:15021: connect: connection refused

check  the logs of pod istio-egressgateway-5df76c8f8c-wnsk4. Why create listener on <IP_ADDRESS>:15021?

Hi @GregHanson, I notice that your Istio version is v1.17.6, I think it's outdated for Dual Stack features in Istio, I suggestion that Please try 1.19 or higher.

Is there any doc about dual stack support and how to enable dual stack in dual stack env? Thanks

@luniHw there's the announcement blog here: https://istio.io/latest/blog/2023/experimental-dual-stack/
This doc for tracking purposes:
https://github.com/istio/enhancements/blob/master/features/dual-stack-support.md
Dual stack issues in istio:
https://github.com/istio/istio/issues?q=is%3Aissue+label%3Aarea%2Fdual-stack+
Dual stack PR's in istio:
https://github.com/istio/istio/pulls?q=is%3Apr+label%3Aarea%2Fdual-stack+
And there's a dedicated channel called #dual-stack in istio slack:
https://slack.istio.io/

I think this issue (same as #45970 ) was solved in a later Istio release
Please verify on 1.20 release and let us know if the issue is no longer reproducible.

https://github.com/istio/istio/pull/47022 fixes this


Add a free explore tab

This should allow us to freely explore messages, images, videos and audio sorted by time or reactions.
Ideas for this:

Sort by date or reactions
Explore audio
Explore video
Explore messages
Explore photos
The ability to download each media type

Closed by #23


map2021

@abusarayyiurgh can you please make your question more precise? I don't get what you mean