location doesn't work on ungoogled chromium

Unfortunately, I think this is an upstream issue with ungoogled-chromium per #1551, as it seems the browser prevents usage of the Geolocation API.
A commenter on that issue did suggest a workaround with location spoofing, I’d recommend to give that a try and see if it at least allows a manual override of your location data.

Unfortunately, I think this is an upstream issue with ungoogled-chromium per #1551, as it seems the browser prevents usage of the Geolocation API.
A commenter on that issue did suggest a workaround with location spoofing, I’d recommend to give that a try and see if it at least allows a manual override of your location data.

yeah found that out after doing research. Almost all modern browsers have location services of some kind, so the fact that it doesn't is dysfunctional.

Hoping you'll give it another go if you end up choosing another browser! Feel free to reach out again if you run into any other issues. :)

Hoping you'll give it another go if you end up choosing another browser! Feel free to reach out again if you run into any other issues. :)

I use brave now and it works really well :)


fix: fixed for the issue (#567)

1. Description

1.1. Checklist

[ ] The title of my PR starts with a Conventional Commit prefix (fix:, feat:, docs: etc).
[ ] I have read the Contributor Guide and followed the process outlined for submitting PRs.
[ ] I have updated/added tests for ALL new/updated/fixed functionality.
[ ] I have updated/added relevant documentation in docs and added dartdoc comments with ///.
[ ] I have updated/added relevant examples in examples.

1.2. Breaking Change

[ ] Yes, this is a breaking change.
[ ] No, this is not a breaking change.

1.3. Related Issues

Codecov Report

Merging #568 (803964e) into main (b87d634) will increase coverage by 18.65%.
The diff coverage is n/a.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
@@             Coverage Diff             @@
##             main     #568       +/-   ##
===========================================
+ Coverage   65.34%   84.00%   +18.65%
===========================================
  Files         214       19      -195
  Lines        2063      425     -1638
===========================================
- Hits         1348      357      -991
+ Misses        715       68      -647

see 194 files with indirect coverage changes
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


[FEATURE] Resignation from gridFs in media files service and images processing in blazor application

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
https://www.mongodb.com/community/forums/t/storing-images-in-mongodb/152599/3
Describe the solution you'd like
A clear and concise description of what you want to happen.
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context or screenshots about the feature request here.

#341 resolves thie issue.


ionic-toggle ng-true-value and ng-false-value don't work in docs

From @oneillsp96 on September 30, 2015 0:37
This is not a change to the ionic-toggle directive itself.  However, in the html here: http://ionicframework.com/docs/api/directive/ionToggle/
you have the following code snippet:

Newsletter

This doesn't work because there are no single quotes on 'Subscribed' and 'Unsubscribed', like this:
ng-true-value="'Subscribed'"
Not a big deal, just had me scratching my head for a few minutes and might be nice to update and keep the docs pretty!
By the way, I love Ionic....Thanks!
Copied from original issue: driftyco/ionic#4447

From @oneillsp96 on November 20, 2015 1:4
I can only edit the toggle directive itself and submit a pull request for it....it's not an issue with the toggle, just that the way it's being shown (with slightly broken code) could be confusing

From @chiusite on November 19, 2015 17:59
thanks, onelipse.   i was wondering why it did not work.
btw, you can fix it in github  too

Thanks for opening this issue with us! Since this is an issue related to the docs site and not the actual framework i will be moving this issue to that repo. Please feel free to continue the conversation over there! Thanks again!

@oneillsp96  Ahh in the codepen. Noted!
Should be updated! Thanks for the heads up :smile:


Add Github actions for MacOS.

See discussion here: https://forum.djangoproject.com/t/improving-the-contribution-experience-with-github-actions/5964/

Hey @orf — thanks for this. As @jdufresne noted on #13805, the Jenkins node version needs updating. See e.g. https://djangoci.com/job/pull-requests-javascript/9953/
I wonder if we couldn't start using GHA for those JS tests right now? 🤔 — Enable the check, disable the one on Jenkins. — At least as a trial — I'm pretty sure @felixxm doesn't want to spend hours on Jenkins this week. (? 🙂)

Hey @orf — thanks for this. As @jdufresne noted on #13805, the Jenkins node version needs updating. See e.g. https://djangoci.com/job/pull-requests-javascript/9953/
I wonder if we couldn't start using GHA for those JS tests right now? 🤔 — Enable the check, disable the one on Jenkins. — At least as a trial — I'm pretty sure @felixxm doesn't want to spend hours on Jenkins this week. (? 🙂)

Absolutely! I just realized that I haven't actually added the JS tests to docker-box or my POC, I only added the frontend selium tests. I can work on a PR to add JS tests with actions tonight 👍

Absolutely! I just realized that I haven't actually added the JS tests to docker-box or my POC, I only added the frontend selium tests. I can work on a PR to add JS tests with actions tonight 👍

Cool. Thanks. We'll see if @felixxm likes the easy out there? 😀

Cool. Thanks. We'll see if @felixxm likes the easy out there? 😀

Please don't  rush. I still have doubts but I also don't have time in this week to prepare a detailed comment, e.g. isort, flake8 and Windows builds use Python 3.9 on Jenkins; output is not formatted so it's less readable we have almost 14k+ tests so it can be frustrating especially with more than one failure; we have much more skipped tests 1212 vs. 1135 on Jenkins probably SQLite is compiled without the JSON1 etc.; it can be hard to control SQLite version, etc.

Please don't  rush. I still have doubts but I also don't have time in this week to prepare a detailed comment, e.g. isort, flake8 and Windows builds use Python 3.9 on Jenkins; output is not formatted so it's less readable we have almost 14k+ tests so it can be frustrating especially with more than one failure; we have much more skipped tests 1212 vs. 1135 on Jenkins probably SQLite is compiled without the JSON1 etc.; it can be hard to control SQLite version, etc.

As @jdufresne noted on #13805, the Jenkins node version needs updating. See e.g. https://djangoci.com/job/pull-requests-javascript/9953/

It uses the old node because there is some dependency collision with the libraries for MySQL, I don't remember details. I can check this later.

As @jdufresne noted on #13805, the Jenkins node version needs updating. See e.g. https://djangoci.com/job/pull-requests-javascript/9953/

It uses the old node because there is some dependency collision with the libraries for MySQL, I don't remember details. I can check this later.

Please don't rush.

Ahh, ok sorry I missed this comment. I made this PR: https://github.com/django/django/pull/13851, it was pretty simple!
I look forward to your comment on the proposal!

Please don't rush.

Ahh, ok sorry I missed this comment. I made this PR: https://github.com/django/django/pull/13851, it was pretty simple!
I look forward to your comment on the proposal!

Sorry, wrong branch 😂. https://github.com/django/django/pull/13852

Sorry, wrong branch 😂. https://github.com/django/django/pull/13852

Hi,

Please don't rush. I still have doubts but I also don't have time in this week to prepare a detailed comment

No worries, take your time!

e.g. isort, flake8 and Windows builds use Python 3.9 on Jenkins;

This is a one line change (literally) and the same holds true as soon as we need to switch the version.

output is not formatted so it's less readable we have almost 14k+ tests so it can be frustrating especially with more than one failure

Agreed, we certainly can find something there. On the upside flake8 & isort errors can be shown directly in the PR https://aws1.discourse-cdn.com/standard14/uploads/djangoproject/original/2X/f/f59e48cb2c85e16282f1de4e33461b03bcb2f6ec.png which imo is a massive gain. Granted as Tom suggested in the forum topic, we should step slowly and integrate what makes sense. FWIW I think even if everything works we might keep a scaled down jenkins instance for one or two things…

we have much more skipped tests 1212 vs. 1135 on Jenkins probably SQLite is compiled without the JSON1 etc.; it can be hard to control SQLite version, etc.

It is actually easier to control sqlite versions since we'd have our on docker containers. In Jenkins we have the problem with that in the worst case we need different slaves for different django projects we can just adjust our containers here. Also issues like these can be fixed by contributors and not just people with access to Jenkins. As for the skipped tests: Yes there is certainly work left to be done…
Please also consider the following: We currently do not test on Mac at all etc and we would get two different Windows & Mac versions on Github actions.
We obviously don't want to have a degraded experience. But I think in quite a few instances we can improve and in the others at least reach an equivalent experience.

Hi,

Please don't rush. I still have doubts but I also don't have time in this week to prepare a detailed comment

No worries, take your time!

e.g. isort, flake8 and Windows builds use Python 3.9 on Jenkins;

This is a one line change (literally) and the same holds true as soon as we need to switch the version.

output is not formatted so it's less readable we have almost 14k+ tests so it can be frustrating especially with more than one failure

Agreed, we certainly can find something there. On the upside flake8 & isort errors can be shown directly in the PR https://aws1.discourse-cdn.com/standard14/uploads/djangoproject/original/2X/f/f59e48cb2c85e16282f1de4e33461b03bcb2f6ec.png which imo is a massive gain. Granted as Tom suggested in the forum topic, we should step slowly and integrate what makes sense. FWIW I think even if everything works we might keep a scaled down jenkins instance for one or two things…

we have much more skipped tests 1212 vs. 1135 on Jenkins probably SQLite is compiled without the JSON1 etc.; it can be hard to control SQLite version, etc.

It is actually easier to control sqlite versions since we'd have our on docker containers. In Jenkins we have the problem with that in the worst case we need different slaves for different django projects we can just adjust our containers here. Also issues like these can be fixed by contributors and not just people with access to Jenkins. As for the skipped tests: Yes there is certainly work left to be done…
Please also consider the following: We currently do not test on Mac at all etc and we would get two different Windows & Mac versions on Github actions.
We obviously don't want to have a degraded experience. But I think in quite a few instances we can improve and in the others at least reach an equivalent experience.

I moved flake8 and isort to a separate PR, #13921.

I moved flake8 and isort to a separate PR, #13921.

Sorry about the commit spam, I was experimenting with problem matchers. It didn't work 😭.
Is there anything else I should do to this PR? I've removed the linting, added timing information and made the test logging more verbose.

Master has several failures on MacOS that have crept in. I've reproduced them locally. I'd like to ask again: what are the blockers to having this merged @felixxm? Please let me know so I can put some time aside to working through them.
Perhaps we could merge this with allow_failures set to True so we can assess the impact without blocking merges?

Apparently it's https://github.com/django/django/pull/13300, which fails on sqlite 3.35.3. I'm guessing this started failing in 3.35.0 (on homebrew from March 24th), which includes this potentially relevant changelog entry: Attempt to process EXISTS operators in the WHERE clause as if they were IN operators, in cases where this is a valid transformation and seems likely to improve performance..
I'll bisect this while adding support for different sqlite3 versions on MacOS to this branch, which seems useful.

Looking at the thread https://github.com/django/django/pull/13840#issuecomment-755395988 isn't really addressed. I'll have a think about those comments whilst I'm looking at it.

I've added support for multiple sqlite versions to the MacOS tests. You can do the same steps locally:
brew uninstall --ignore-dependencies sqlite
brew tap-new $USER/local-sqlite
brew extract sqlite --version=${{ matrix.sqlite }} $USE R/local-sqlite
brew install sqlite@${{ matrix.sqlite }}
ln -s /usr/local/opt/sqlite@${{ matrix.sqlite }}/ /usr/local/opt/sqlite

With 3.34.0 then expressions.tests.BasicExpressionsTests passes, but with the latest (3.35.3) they fail.
If we can work out some steps to do something similar with Windows (using chocolatey?) then we can unify the two steps again.

Looking at the thread #13840 (comment) isn't really addressed. I'll have a think about those comments whilst I'm looking at it.

I was sort of waiting for the detailed comment 😅, but we've addressed isort/flake8 and the less-readable output. JSON1 is compiled in and it's actually far easier to control and change the sqlite3 version. I'll look at the differences in tests now.

Not gonna lie, this looks like it's an issue with sqlite 😱. I've reduced it it down to this test setup:
CREATE TABLE "expressions_company"
(
    "id"                  integer          NOT NULL PRIMARY KEY AUTOINCREMENT,
    "name"                varchar(100)     NOT NULL,
    "num_employees"       integer unsigned NOT NULL CHECK ("num_employees" >= 0),
    "num_chairs"          integer unsigned NOT NULL CHECK ("num_chairs" >= 0),
    "ceo_id"              integer          NOT NULL REFERENCES "expressions_employee" ("id") DEFERRABLE INITIALLY DEFERRED,
    "point_of_contact_id" integer          NULL REFERENCES "expressions_employee" ("id") DEFERRABLE INITIALLY DEFERRED,
    "based_in_eu"         bool             NOT NULL
);
INSERT INTO "expressions_company"
VALUES (1, 'Example Inc.', 2300, 5, 1, NULL, 0);
INSERT INTO "expressions_company"
VALUES (2, 'Foobar Ltd.', 3, 4, 2, NULL, 1);
INSERT INTO "expressions_company"
VALUES (3, 'Test GmbH', 32, 1, 3, NULL, 0);
CREATE TABLE "expressions_employee"
(
    "id"        integer     NOT NULL PRIMARY KEY AUTOINCREMENT,
    "firstname" varchar(50) NOT NULL,
    "lastname"  varchar(50) NOT NULL,
    "salary"    integer     NULL
);
INSERT INTO "expressions_employee"
VALUES (1, 'Joe', 'Smith', 10);
INSERT INTO "expressions_employee"
VALUES (2, 'Frank', 'Meyer', 20);
INSERT INTO "expressions_employee"
VALUES (3, 'Max', 'Mustermann', 30);

UPDATE "expressions_company"
SET "name"                = 'Test GmbH',
    "num_employees"       = 32,
    "num_chairs"          = 1,
    "ceo_id"              = 3,
    "point_of_contact_id" = 3,
    "based_in_eu"         = 0
WHERE "expressions_company"."id" = 3;

The following query on sqlite 3.32.3 returns three results:
❯ sqlite3 test.db
SQLite version 3.32.3 2020-06-18 14:16:19
Enter ".help" for usage hints.
sqlite> SELECT "expressions_employee"."id",
   ...>        "expressions_employee"."firstname",
   ...>        "expressions_employee"."lastname",
   ...>        "expressions_employee"."salary"
   ...> FROM "expressions_employee"
   ...> WHERE (EXISTS(SELECT (1) AS "a"
   ...>               FROM "expressions_company" U0
   ...>               WHERE U0."ceo_id" = "expressions_employee"."id"
   ...>               LIMIT 1) OR EXISTS(SELECT (1) AS "a"
   ...>                                  FROM "expressions_company" U0
   ...>                                  WHERE U0."point_of_contact_id" = "expressions_employee"."id"
   ...>                                  LIMIT 1));
1|Joe|Smith|10
2|Frank|Meyer|20
3|Max|Mustermann|30

But on 3.35.3 it returns just one row:
❯ /usr/local/opt/sqlite/bin/sqlite3 test.db
SQLite version 3.35.3 2021-03-26 12:12:52
Enter ".help" for usage hints.
sqlite> SELECT "expressions_employee"."id",
       "expressions_employee"."firstname",
       "expressions_employee"."lastname",
       "expressions_employee"."salary"
FROM "expressions_employee"
WHERE (EXISTS(SELECT (1) AS "a"
              FROM "expressions_company" U0
              WHERE U0."ceo_id" = "expressions_employee"."id"
              LIMIT 1) OR EXISTS(SELECT (1) AS "a"
                                 FROM "expressions_company" U0
                                 WHERE U0."point_of_contact_id" = "expressions_employee"."id"
                                 LIMIT 1));
1|Joe|Smith|10
sqlite>

I've posted a bug report to the sqlite forums. I think I might have done it twice.
Removing the redundant LIMIT 1 from the EXISTS subquery makes the query return the correct number of results.
This was added here: https://github.com/django/django/commit/c54b8ec2f5122ae13bcb4e1d00d8e8f6bcacf2cf, but I'm not sure it makes sense in a nested context. At least, that's what IntelliJ is telling me:

Seems like it's fixed in 3.35.4, which should be out in homebrew soon tm Homebrew/homebrew-core#74485

I can confirm that it's fixed in 3.35.4.

I think we should pull out from this adding a single build of macOS, with libmemcached if you like

Agreed! I think we should keep the homebrew method for running a specific version in the script, but it would install the latest? Or we could make it use the system default.

I wonder if we could have the macOS job just run on main? Is there a Not on forks filter? 🤔

We can only trigger it on main or any merge request that has a ci-macos label applied? That might be more flexible. We can also exclude forks I believe.

I'm not really seeing the benefit of moving the Windows build just now.

The question I'd have is: why not move it? It's true that there is no gap in coverage like MacOS but the general act bringing our CI files in-repo has a bunch of other benefits. We can always run Windows tests on both for a time to see how it goes?

I'm going to close due to inactivity. Happy if someone wants to pick this up again.


Merge feature_update_graph_pattern

This PR addresses a few issues: #42 #34 #35 which are centered around applying a new triple pattern across the data and updating virtuoso.
Changes
Image Management
Previously, the docker/ folder acted as the place to build the scheduler and worker images. Because the workers and scheduler depend on the d1lod library, and because Dockerfiles can only copy same-directory or lower files, the d1lod folder had to be copied into each folder. Additionally, there were separate images for the workers and scheduler. This was error prone and tedious.
The changes in 16c9632 and ae271ea install the d1lod package into the d1lod image (which I have at thomasthelen/slinky). This image is used in the workers and scheduler, getting rid of the need for their separate images.
Worker Changes
The worker deployment has changed by deploying separate workers, one for the default queue and the other for the dataset queue. These changes are in  4b78c5c.
Scheduler Changes
In 3051b99dbf5020f5983f057249ddc597981ffeaa the scheduler deployment was updated to use the slinky cli.
Virtuoso Changes
Instead of having a second container interact with Virtuoso to enable updating, I combined the openlink virtuoso image with the shell script to enable updates. The virtuoso server an the update-enabler are run in separate processes, shown below. This was done in 913791c

Networking Changes
When pods in separate deployments need to communicate, they have to go through the associated service. Services can be referenced the same way in docker (ie 'redis' or 'virtuoso'). 50aa722 has a few changes to accommodate this requirement.
Misc
832c7a2 changes the name of the redis deployment to just 'redis'. We don't have a need to distinguish redis deployments, and this makes it more aligned with current names.
8e03b92 Fixes a bug where, without init.py pip won't include the contents of the folder in the install package path.
Testing
Kubernetes
A good kubbernetes test is to tear down the stack and then bring it back up and check that Virtuoso has triples.

kubectl config use-context slinky
kubectl delete deployment scheduler redis virtuoso worker-default worker-dataset
kubectl apply -f virtuoso-deployment.yaml
kubectl apply -f redis-deployment.yaml
kubectl apply -f virtuoso-deployment.yaml
kubectl apply -f worker-default-deployment.yaml
kubectl apply -f virtuoso-dataset-deployment.yaml
kubectl apply -f scheduler-deployment.yaml
kubectl proxy
Visit http://<IP_ADDRESS>:8001/api/v1/namespaces/slinky/services/virtuoso:virtuoso/proxy/sparql/ and check for triples

An optional extra step after deployment is viewing the logs for the workers to see if any jobs have been processed.
Unit Tests
The unit tests should be run the usual way. Without the RDF module locally I run into issues running the tests locally; the requirement for running virtuoso or blazegraph alongside them complicated things (docker in docker territory).
I was able to run the non-networking tests which seemed to pass okay, including the local triple store tests. @amoeba is there any way you can run these on your local machine to test out?

This PR should be ready for review (see my note about testing). There's a followup PR, #48 that's forked off of this branch. It has some nice features added to the deployment and documentation; after reading through this PR I suggest taking a look at the other changes for a bigger picture view.

Thanks @ThomasThelen! I appreciate you coming up to speed on how this service works and getting everything deploying correctly.
This PR got kinda too big to give an effective review but since we ran through things together last week, I'm going to merge and we can go from there.
I did do a scan and I two things did pop up:

Use of a custom Virtuoso image (thomasthelen/virtuoso) referenced in various places. It'd be better to either use the stock image or build one under DataONE org. No need to do that right now.
I think it'd be good to do a pass over how we're doing service discovery and configuration. In my rewrite, I hard-coded service names, some of which are still in the code and should be changed. You added some flags, like --prod which help get around that but I think the best overall solution is to have all connections to default to localhost with default ports and override any hostnames and ports with environmental variables (ala 12F). We can also work on that post-merge.

Oh, and Re: Testing
You should be able to docker compose up -d and run pytest to run the full test suite. I did have to do some work to get the binding installed and I wrote up docs for my future self at https://github.com/DataONEorg/slinky/blob/develop/d1lod/docs/installing-redlands-bindings.md.


Adjust outbound HTTP Requests in wasi-http

Changes the outbound HTTP API.
The send function takes any type that implements Sendable which are all request like types. It then returns the result of trying to turn the response into the desired type. See some examples for how this will work.
This API isn't the cleanest unfortunately, but so far I've not come up with anything better.

Closing this since most of the changes were landed in #1975


Failed to run simple rust plugin in playground

Following error was found while trying to run a pluin following the tutorial "write a plugin in rust".  I also tried to upload code.wasm shipped with source code and it works fine instead.

env
rustc 1.66.0 (69f9c33d7 2022-12-12)

my cargo.toml:

[lib]
crate_type = ["cdylib"]

[dependencies]
extism-pdk = "0.1.1"
serde = { version = "1.0", features = ["derive"] }

wasm_web_plugin.zip

Did you copy paste the code from https://extism.org/docs/write-a-plugin/rust-pdk ?
I ran the code through the extism cli:
echo "Hello World" | extism call wasm_web_plugin.wasm count_vowels
Traceback (most recent call last):
  File "/Users/ben/.local/bin/extism", line 558, in <module>
    main()
  File "/Users/ben/.local/bin/extism", line 553, in main
    r = plugin.call(args.function, input, parse=None)
  File "/opt/homebrew/lib/python3.10/site-packages/extism/extism.py", line 201, in call
    self._check_error(
  File "/opt/homebrew/lib/python3.10/site-packages/extism/extism.py", line 183, in _check_error
    raise Error(ffi.string(error).decode())
extism.extism.Error: Call failed

Caused by:
    0: error while executing at wasm backtrace:
           0: 0x74c3 - <unknown>!__rust_start_panic
           1: 0x74b7 - <unknown>!rust_panic
           2: 0x7487 - <unknown>!std::panicking::rust_panic_with_hook::he04cb00575f2a1e3
           3: 0x6b18 - <unknown>!std::panicking::begin_panic_handler::{{closure}}::hb733f0aa505760cf
           4: 0x6a45 - <unknown>!std::sys_common::backtrace::__rust_end_short_backtrace::h6beefa0bcab220bc
           5: 0x70db - <unknown>!rust_begin_unwind
           6: 0x803a - <unknown>!core::panicking::panic_fmt::h586d720a90aa8503
           7: 0x9134 - <unknown>!core::panicking::panic_display::he96fafaefe672510
           8: 0x90ae - <unknown>!core::panicking::panic_str::h8b2f06f6f011655d
           9: 0x907c - <unknown>!core::option::expect_failed::h1e9a9cbb22bbd6ac
          10:  0xcf4 - <unknown>!count_vowels
       note: using the `WASMTIME_BACKTRACE_DETAILS=1` environment variable to may show more debugging information
    1: wasm trap: wasm `unreachable` instruction executed

The line of interest to you should be:
           9: 0x907c - <unknown>!core::option::expect_failed::h1e9a9cbb22bbd6ac

Keep in mind that any of these lines may trap and just there to demonstrate the API:
    let a = var::get("a")?.expect("variable 'a' set");
    let a = String::from_utf8(a).expect("string from varible value");
    let config = config::get("thing").expect("'thing' key set in config");

Here is a simplified version of that example:
use extism_pdk::*;
use serde::Serialize;

const VOWELS: &[char] = &['a', 'A', 'e', 'E', 'i', 'I', 'o', 'O', 'u', 'U'];

#[derive(Serialize)]
struct TestOutput {
    pub count: i32,
}

#[plugin_fn]
pub unsafe fn count_vowels(input: String) -> FnResult<Json<TestOutput>> {
    let mut count = 0;
    for ch in input.chars() {
        if VOWELS.contains(&ch) {
            count += 1;
        }
    }

    let output = TestOutput {
        count,
    };
    Ok(Json(output))
}

@piaoger currently there is no support to add a config through the playground, but you can do it via the CLI using --set-config to pass a map of key/value pairs, or --config to set a single key=value pair.


Fixed size and position of PvP icon

It should look the same as it was before the patch

Thanks. But you also changed the size of the buff element on arena frames, why?

Sorry, my bad. Thanks, for pointing it out.

Okay, cool. Merging it. Thanks !


refactor(behavior_velocity_planner): simplify cmakelists

Description
refactor cmakelists in behavior_velocity_planner.
Although not sure if this is a good way.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.

[x] I've confirmed the contribution guidelines.
[x] The PR follows the pull request guidelines.

In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.

[ ] The PR follows the pull request guidelines.

Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.

[ ] There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

I think this will break the build for Rolling/Humble. cc @wep21

How about this? -> #855

@kenji-miyake  https://github.com/autowarefoundation/autoware.universe/pull/855 is much better than my way! Thanks!


chore: fix mistake in configuring deny.toml V2

Follow up to #4616, Fixing my mistake.

#4619  👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @rzvxa and the rest of your teammates on  Graphite

I'll merge this without review since it is quite a trivial fix.


Regarding crates import

Hello, thank you for the work on this topic, it seems very promising.
I have a question that I couldn't figure out myself while reading the documentation:
Is it possible to import a crate and use it in the flutter ?
If yes, is it mandatory to create a rust file to export/wrap these functions ?
Is there any tutorial on adding crates and using them in flutter thanks to the glue generated by this project ?

You can import Rust Crate and use it in flutter, but you have to create a Rust file to export/wrap it.
The V2 version has just been released recently, and the documentation seems to be still being improved. For basic usage, maybe reading the template generated by "flutter_rust_bridge_codegen" is also a good choice.

Thank you for this fast answer

@OfficialBoyfriend Thanks for the quick reply!
In addition, I am also thinking about automatically exporting a whole crate to Flutter, without any needs to manually write a wrapper. However, that may have some difficulties, because, for example, it is hard (impossible?) to handle complex lifetimes, etc.
However, feel free to point out the crate you want to use, and we can have a look whether it is easy or hard :)


Cause not allowing special characters is dumb.

@duffn fixed 👍

Thanks again!


⚠ SolarOscp has degraded performance

In 35feca7, SolarOscp ($SOLAROSCP_URL) experienced degraded performance:

HTTP code: 200
Response time: 164 ms

Resolved: SolarOscp performance has improved in 0011564 after 10 minutes.


added react-router and set up some boilerplate routing

Is routing out of scope? I'm finding myself setting up routing a lot while using create-react-app. Here I've set up react-router, moved the intro into its own view component, and added a secondary demo component and some navigation.

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at<EMAIL_ADDRESS>Thanks!

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

Thanks for the PR but yes, it’s currently out of scope, especially considering that a complete rewrite of React Router will be announced tomorrow at React Rally 😄 .

Spoiler alert!


Feature/msgpack

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

11 of 29 (37.93%)  changed or added relevant lines in 3 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-5.0%) to 85.401%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

foxplot/decoders/msgpack.py
4
11
36.36%

foxplot/fox.py
6
17
35.29%

Totals

Change from base Build<PHONE_NUMBER>:
-5.0%

Covered Lines:
234

Relevant Lines:
274

💛  - Coveralls


SQFormDropdown and SQFormMultiSelect TS doesn't cooperate with number or boolean values

After somes changes made in #493 the SQFormMultiSelect and SQFormDropdown components don't work properly if the values used for options includes a number or boolean.
Loom: https://www.loom.com/share/b62a8ad02018418d8c8bbd382055442b

Closed with #509


Request: Add language

Hello,
Can you add to bring the Swedish voice language  when we search?  ☺
Thanks

Added

☺🙏


Website validate failed

HELP TO FIX THIS @leoluk
Head "https://gamerroom.io": read tcp <IP_ADDRESS>:49470-><IP_ADDRESS>:443: read: connection reset by peer
#4892

That website asking permission for cookies I think that the issue @leoluk I will fix it
Thank You.


feat: Add toast for successful table or schema refreshes in Sqllab

SUMMARY

Before users weren't notified if the table or schemas were properly refreshed. So adding toast to inform the users on successful state of refresh.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

https://user-images.githubusercontent.com/27827808/151053833-d2740de8-c12a-4d31-b5d9-7a4631130402.mov
TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

[ ] Has associated issue:
[ ] Required feature flags:
[ ] Changes UI
[ ] Includes DB Migration (follow approval process in SIP-59)

[ ] Migration is atomic, supports rollback & is backwards-compatible
[ ] Confirm DB migration upgrade and downgrade tested
[ ] Runtime estimates and downtime expectations provided

[ ] Introduces new feature or API
[ ] Removes existing feature or API

/testenv up


Remove unnecessary nested Locker and Isolate::Scope use

cc @GustavoCaso
While reviewing https://github.com/Shopify/v8go/pull/39, I noticed that ExceptionError used
  Locker locker(iso);
  Isolate::Scope isolate_scope(iso);

even though ExceptionError isn't exported to Go code and the caller should already have taken the lock and entered that isolate scope.  That PR was trying to preserve this behaviour for existing code, but we should actually just remove those lines.
I've also made ExceptionError static, making it clearer that it isn't used outside that c file.

That PR was trying to preserve this behaviour for existing code, but we should actually just remove those lines.

Fantastic. it would simply https://github.com/Shopify/v8go/pull/39. Tomorrow I will apply the changes to the Heap snapshot PR


preventLinks not working

Hi,
I'm using Swiper in combination with Magnific Popup. Unfortunately preventLinks is not working. I've tried adding e.preventDefault(); to every callback possible but it doesn't work.
I made some code available here for you to inspect:
https://dl.dropboxusercontent.com/u/2177001/bs/index.html

Just did the same trick for Swiperbox library, here is the code (coffee):
window.enableGalleryClick = false;

$(document).ready(function() {
  var mainSwiper = new Swiper('.photos-gallery', {
    onTouchMove: function() {
      window.enableGalleryClick = false;
    },
    onTouchEnd: function() {
      setTimeout(function() {
        window.enableGalleryClick = true;
      }, 100);
    }
  });
  $('.swipebox').swipebox({
    beforeOpen: function() {
      if (!window.enableGalleryClick) {
        return false;
      }
    }
  });
});


Incorrect reported_at timestamp

We noticed that occasionally packets get delayed in processing about 19 minutes. What ever may have caused this delay the reported_at key value in the packet was set according to the processed time not the actual reception time by the gateway. I assume the correct behaviour would have been reported_at to be timestamped in GW according to the receiving time. Could you please check this?

The hold_time should be in your integration data, see https://github.com/helium/router#integrations-data

Looks like our bbmustache library does not support key.0
I got around doing this but warning cause it will fold over all the hotspotsin the list and print hold_time multiple time.
{
  "id": "{{id}}",
  "name": "{{name}}",
  "app_eui": "{{app_eui}}",
  "dev_eui": "{{dev_eui}}",
  "devaddr": "{{devaddr}}",
  "downlink_url": "{{downlink_url}}",
  "fcnt": {{fcnt}},
  "port": "{{port}}",
  "payload": "{{payload}}",
  "reported_at": "{{reported_at}}",
   {{#hotspots}} "hold_time": "{{hold_time}}"{{/hotspots}}
}


macOS Icon Misaligned With Other Apps

VSCode Version: 1.37.1
OS Version: macOS 10.14.6

Steps to Reproduce:

Open VSCode
Observe icon in Apple Logo -> Recent Items, or right click Launchpad
Icon misaligned

Does this issue occur when all extensions are disabled?: Yes

Looks like a duplicate of https://github.com/microsoft/vscode/issues/75593
/duplicate


Enforce multiple authentication schemes

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is.
Hi team,
My issue is about authentication. I am trying to enforce two authentication schemes, My assumption is that the current behavior is that if you have more than one authentication scheme setup the framework will execute both and if any passes then the user will be authenticated.
Is there a way to enforce both so if any of them fails then the authentication process fails?
services.AddAuthentication(options => {
    options.DefaultAuthenticateScheme = SecurityConstants.CustomAuthenticationScheme;
    options.DefaultChallengeScheme = SecurityConstants.CustomAuthenticationScheme; })
    .AddScheme<AuthenticationSchemeOptions, CustomAuthenticationHandler>(SecurityConstants.CustomAuthenticationScheme,
options => options. = "Bearer")
    .AddIdentityServerAuthentication();

Just to be more clear, I've got a custom authentication scheme and identity server, if any of these fails I want to fail authentication. In short I would like that my action methods marked with [Authorize] and the default policy being RequiresAuthenticatedUser return 401 when authentication fails
Describe the solution you'd like
It would be great if the DenyAnonymousAuthorizationRequirement can only verify that there is an authenticated user for the policy scheme
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context or screenshots about the feature request here.

Hi @uokitomer , the recommendation here is to create a policy that enforces your requirements. We have some info on creating policies in this doc: https://docs.microsoft.com/en-us/aspnet/core/security/authorization/policies?view=aspnetcore-2.2

Is there a way to enforce both so if any of them fails then the authentication process fails?

No. If any authentication service succeeds then the user will be authenticated. You can't have "both must succeed".
You could try via policy as Eilon suggests, and have a policy which examines the identities on the user principal and checks that there's an identity from both authentication services, that's as close as you can get.


Facebook 2FA is also one account per phone number

I just witnessed the following on Facebook:

user has two accounts on Facebook: one for a business and another for personal use (I'll call these account1 and account2.)
user enables 2FA for account1 using phone number and Google Authenticator
user enables 2FA for account2 using same phone number and Google Authenticator
Facebook sends the following email to the address associated with account1:

"You recently removed your primary phone from your account.  Because of this, we turned off login approvals on your account to ensure that you don't get locked out when using an unrecognized computer or mobile device to login."

user is now able to login to account1 on a new device with just their password and no second factor
checking the 2FA settings on account1 reveals 2FA is indeed turned off for that account

The Facebook Entry Should have a Hazard Symbol like Twitter

À la the twitter entry, the Facebook entry should have a hazard symbol that states something like the following:

"SMS required for 2FA, 1 account per phone"

Perhaps this should be reported as a bug to Facebook?

@mxxcon It's certainly a limitation, but why would "1 account per phone" be considered a bug?

Because it might not be an expected behavior. In the case of twitter they explicitly tell you that it's 1:1 relationship, where as here they seem to silently remove 2fa from your 1st account.

I see.  That is true.  I wonder if Facebook has a bug submission process...

There's https://www.facebook.com/help/326603310765065/ and there's https://www.facebook.com/whitehat/

I reported this by following the instructions at https://www.facebook.com/help/326603310765065/.

No, definitely not. On Facebook's Terms of Service it clearly says that having two separate Facebook accounts is against the rules (section 4, point 2)

@aleksandar-todorovic except when you have a personal facebook account and a business one, which you now can not protect with 2fa...

@mxxcon Do you by "business account" mean a Facebook page for your company/project?

@aleksandar-todorovic for my company/project/organization/client/however else it can be used.

Yeah. Facebook Pages can have separate accounts that aren't linked to a personal account.

Closing due to #1250.


M2M Corpus Inclusion?

This is really just feedback for the authors of the M2M 100 model.
Based on the Venture Beat article I read about, it sounds like there is a need to expand the text corpus to include more content for some languages so that less artificial material has to be created.
If so, have you considered that the sacred Christian religion text, known simply as the Bible, could be a tremendously valuable source for development of this translation model?  The reason I propose this is because of the fact that Bible translators rely on a tremendously thorough human translation process that theoretically should yield a substantial improvement.
If you are interested in following this path further there is this repository that could serve as a starting point in this direction.
I have also cross posted an issue over there for that team to reference the M2M 100 work released here.
https://github.com/christos-c/bible-corpus/issues/11
Thank you for your contribution to the advancement of communication across the world through the development of this tool.

Thanks for the suggestion! While I didn’t work on this specific project, the Bible and other similar resources are often used in this kind of work. Bible translations are also included in the OPUS project, which our team sometimes uses for low resource MT projects: http://opus.nlpl.eu/
One of the risks to be mindful of is that the style of writing in the Bible is quite a bit different than, say, news articles or social media posts. Typically one wants to train these systems on the same style (or “domain”) of writing that the system will eventually be applied to.

Thanks @normanhh3! The translations of the Bible have been very useful for various NLP efforts --- check out OPUS as Myle mentions or https://link.springer.com/article/10.1007/s10579-014-9287-y. The Masakhane-MT project, which focuses on African languages, trains on the JW300 corpus (https://www.aclweb.org/anthology/P19-1310/), I believe is based on Jehovah's Witness magazines.
In this work, we mainly focused on many-to-many corpora created with data mining, but indeed in the future, incorporating human translations from various sources (including WMT, WAT, IWSLT, etc as well) would be very useful. Check out Section 6.4 of the paper where I also list some existing high-quality resources for low resource languages, like various African languages, that have been created by the community.


how to configure youtebe-dl when using PAC on windows 7

hi,
I use a PAC file on windows 7 to access the internet.
I try the command "youtube-dl --proxy http://<IP_ADDRESS>:16823/adf.pac https://www.youtube.com/watch?v=ByVPaqN9594" to download some files. but it failed.
i'm not sure if it' correct to set parameter. Could you help me?
Thanks.

PAC is not supported in youtube-dl.

Yes, please. Really need PAC be supported.

I have an experimental PAC support at https://github.com/yan12125/youtube-dl/tree/proxy-auto-config-support. There are some limitations in this version:

SOCKS proxies are not supported yet
You need to install python-pacparser
Only PAC URLs are supported. Local PAC files are in TODO.

How do I use this and is this experiment already implemented in the Windows binary.

It's not integrated into Windows binaries yet. The following steps should work:

Install Python 2.7 or Python 3.4
Download https://github.com/yan12125/youtube-dl/archive/proxy-auto-config-support.zip and extract
Install python-pacparser from https://github.com/pacparser/pacparser/releases
youtube-dl --pac-url <the PAC url> <the video URL>

C:\Users\Administrator>youtube-dl --pac-url http://localhost/jp.pac --username root --password pac.nagro.net https://www.youtube.com/watch?v=ByVPaqN9594
[youtube] Downloading login page
WARNING: unable to fetch login page: <urlopen error Tunnel connection failed: 407 Proxy Authentication Required>
[youtube] ByVPaqN9594: Downloading webpage
ERROR: Unable to download webpage: <urlopen error Tunnel connection failed: 407 Proxy Authentication Required> (caused by URLErr
or(OSError('Tunnel connection failed: 407 Proxy Authentication Required',),))

What's the matter?What should I configure the authentication?

Hmm two people encounter the same error, see #11447

thanks a lot

has this function merged into official release?


v1 list_monitors cannot find monitor tags with spaces

Describe the bug
If a monitor has a tag whose key has spaces in it, then list_monitors() cannot find it by tag.
To Reproduce

Go to 'Monitors'
Click on 'Edit' (pencil icon) for any monitor
Scroll down to 'tags'
Add a new tag "Tag With Spaces"
click 'Save'

run following python script:
from datadog_api_client.v1 import ApiClient, ApiException, Configuration
from datadog_api_client.v1.api import downtimes_api, monitors_api
from datadog_api_client.v1.models import *
import os

configuration = Configuration()
api_client = ApiClient(configuration)
monitor_api = monitors_api.MonitorsApi(api_client)

rv = monitor_api.list_monitors(with_downtimes=True, monitor_tags="Tag With Spaces")
print(len(rv))

Expected behavior
list_monitors() returns least one monitor that matches the tag
Environment and Versions (please complete the following information):
Python 3.11.4
datadog-api-client==2.17.0
There is nothing in API documentation or UI to suggest that tags with spaces are not supported.

Hi,
Indeed the list API doesn't seem to support tags with space. Overall spaces in tags are somewhat discouraged, but I agree with you they are not forbidden. I reached out to the monitor team to see if they can fix this. Thanks for you patience.


Enable Filtering for Blog Posts

Right now in the footer of the website there are three links that should link to a list of blog posts filtered by their associated tag. We need to implement the filtering logic and update the following links:

Blog > Announcements
Blog > Today I Learned
Blog > Reviews

Split from #73

Hi there, is this issue still up for grabs?

Totally! And don't hesitate to follow up if you have any questions or need clarification!

Implemented in #125 🎊


[3.1] Improve compile-time performance of string interpolation

Constraint generation for interpolated string literals was
meticulously producing a constraint system that included all of the
generated calls to init(stringInterpolationSegment:). While accurate,
this is completely unnecessary (because the
ExpressibleByStringInterpolation protocol allows anything to be
interpolated) and leads to large, intertwined constraint systems
where:
(1) There are two additional type variables per string interpolation
segment, and
(2) Those type variables form a bridge between the string
interpolation's type variable and the type variables of each string
interpolation segment, and
(3) init(stringInterpolationSegment:) tends to be overloaded (17 overloads on String!)
which left each string interpolation as a large connected component
with big disjunctions.
Drop the calls to init(stringInterpolationSegment:) from the
constraint system. This eliminates two type
variables per segment (due to (1) going away), and breaks the bridge
described in (2), so that each string interpolation segment is
treated as an separate connected component and, therefore, will be
solved independently. The actual resolution of
init(stringInterpolationSegment:) overloads is pushed to the
constraint application phase, where we are only dealing with concrete
types and much smaller constraint systems. Still, eliminate 16 concrete-type overloads of String.init(stringInterpolationSegment:) in favor of 3 generic ones.
Fixes rdar://problem/29389887.

@swift-ci please test

Build failed
Jenkins build - Swift Test Linux Platform
Git Commit - aebe73a794316f1aadc4366490938bac9a159174
Test requested by - @DougGregor

Stack trace printing failed? Weird.

@swift-ci please test Linux

Build failed
Jenkins build - Swift Test Linux Platform
Git Commit - aebe73a794316f1aadc4366490938bac9a159174
Test requested by - @DougGregor

@swift-ci please test Linux

Build failed
Jenkins build - Swift Test Linux Platform
Git Commit - aebe73a794316f1aadc4366490938bac9a159174
Test requested by - @ematejska

We need a 3.1 cherry-pick of https://github.com/apple/swift-lldb/commit/dbb730e8ca79a468e87c49c302c31d1d0fe96f22 for this to work

@swift-ci please test Linux


Changing only query param caused an exception

Met an issue after upgrading to 0.12.3.
I want to change the navigation from a DropdownButton:
 DropdownButton<int>(
        value: selectedAppId,
        icon: Icon(Icons.arrow_drop_down),
        iconEnabledColor: Colors.black,
        iconSize: 12,
        elevation: 16,
        dropdownColor: Colors.white,
        isExpanded: true,
        underline: Container(),
        onChanged: (int? newValue) {
          selectedAppId = newValue;
          Beamer.of(context).beamToNamed("/main/app-edit?id=${selectedAppId}");
        },
        items: items,
      )

Only the query param is changed, and I'll get an exception:

════════ Exception caught by widgets library ═══════════════════════════════════
The following assertion was thrown building Builder(dependencies: [_RouterScope]):
Assertion failed:
../…/widgets/navigator.dart:3237
!isWaitingForEnteringDecision && isWaitingForExitingDecision && isPresent
"This route cannot be marked for remove. Either a decision has already been made or it does not require an explicit decision on how to transition out."

Don't know how to deal with the exception..
I'm using SimpleLocationBuilder.

Seems the issue is related to an overlay. I used the package:
https://pub.dev/packages/select_dialog
It also raises the same exception when choosing from the dialog.
It won't throws exceptions if I just tapped a button from the page(no overlay).

@slovnicki OK, after vocation I'll try to make one for you.

Hey @slovnicki! Got the same issue with PopupMenuItem. Here's an example that demonstrates the bug: https://github.com/MarkAlexanderDev/beamer_issue

Here's a temporary fix :
PopupMenuItem<String>(
                          child: Text(
                            "Random text",
                          ),
                          onTap: () async {
                            Future.delayed(const Duration(milliseconds: 500))
                                .then((value) => Beamer.of(context).beamToNamed("/url"));
                          },
                        ),

Are you kidding? When would you fix this issue? Should use Future.delayed everywhere I need to beamToNamed?

@mhbdev This might have been closed prematurely.
I will reopen and investigate the issue.

@mhbdev This might have been closed prematurely. I will reopen and investigate the issue.

Are you working on this? I got the same error, and use
   Future.delayed(const Duration(milliseconds: 500))
   .then((value) => Beamer.of(context).beamToNamed("/url"));

fix it, but I think it should be fixed in other way

Just ran into the same issue. Any updates yet?

@Wackymax @wenchaosong
I would suggest migrating to go_router or auto_route

@slovnicki Any update on this, this is a mayor issue.
TLTR: I think you should check on a magic may if every animation is done or all the controllers on a page are disposed/done, or w8t until the next frame until you navigate rsmting like that idk sorry... ;-)
I always keeps seeing somthing comming back reguarding The AnimationController notifying status listeners was:
flutter:   AnimationController#df15c(⏮ 0.000; paused; for DialogRoute<ApprovalResult?>) so somthing is up with a animationcontroller...
I have this problem in my 3 flutter apps, in all three i need to apply an Future.delayed(const Duration(milliseconds: 500))... this is a very ugly fix and this needs to be fixed asap.
The issue only exists in debug mode but it makes developing a nightmare... 👾
Here are some details on the error, hopefully you have found a solution since the first mention on Apr 27, 2021...
This is NOT a dialog only problem, this is a global widgets problem.
Here is some video proof:

Code that triggers error
approvalUiState.updateWith(
  purchaseInvoiceId: '',
  flowInstanceId: '',
);

Currently i FiXeD it using this peace of code:
Future.delayed(const Duration(milliseconds: kDebugMode ? 200 : 0), () {
  approvalUiState.updateWith(
    purchaseInvoiceId: '',
    flowInstanceId: '',
  );
});

Stack:
flutter: ══╡ EXCEPTION CAUGHT BY WIDGETS LIBRARY ╞═══════════════════════════════════════════════════════════
flutter: The following assertion was thrown building Builder(dependencies: [MediaQuery]):
flutter: This route cannot be marked for remove. Either a decision has already been made or it does not
flutter: require an explicit decision on how to transition out.
flutter: 'package:flutter/src/widgets/navigator.dart':
navigator.dart:1
flutter: Failed assertion: line 3207 pos 7: '!isWaitingForEnteringDecision && isWaitingForExitingDecision &&
flutter: isPresent'
flutter:
flutter: The relevant error-causing widget was:
flutter:   Builder
flutter:
core_providers.dart:106
flutter:
flutter: When the exception was thrown, this was the stack:
flutter: #2      _RouteEntry.markForRemove
navigator.dart:3207
flutter: #3      NoAnimationTransitionDelegate.resolve
transition_delegates.dart:32
flutter: #4      TransitionDelegate._transition
navigator.dart:858
flutter: #5      NavigatorState._updatePages
navigator.dart:3932
flutter: #6      NavigatorState.didUpdateWidget
navigator.dart:3605
flutter: #7      StatefulElement.update
framework.dart:5471
flutter: #8      Element.updateChild
framework.dart:3685
flutter: #9      ComponentElement.performRebuild
framework.dart:5322
flutter: #10     Element.rebuild
framework.dart:5016
flutter: #11     StatelessElement.update
framework.dart:5373
flutter: #12     Element.updateChild
framework.dart:3685
flutter: #13     ComponentElement.performRebuild
framework.dart:5322
flutter: #14     Element.rebuild
framework.dart:5016
flutter: #15     StatelessElement.update
framework.dart:5373
flutter: #16     Element.updateChild
framework.dart:3685
flutter: #17     ComponentElement.performRebuild
framework.dart:5322
flutter: #18     Element.rebuild
framework.dart:5016
flutter: #19     ProxyElement.update
framework.dart:5628
flutter: #20     _InheritedProviderScopeElement.update
inherited_provider.dart:523
flutter: #21     Element.updateChild
framework.dart:3685
flutter: #22     ComponentElement.performRebuild
framework.dart:5322
flutter: #23     Element.rebuild
framework.dart:5016
flutter: #24     StatelessElement.update
framework.dart:5373
flutter: #25     Element.updateChild
framework.dart:3685
flutter: #26     ComponentElement.performRebuild
framework.dart:5322
flutter: #27     Element.rebuild
framework.dart:5016
flutter: #28     BuildOwner.buildScope
framework.dart:2779
flutter: #29     WidgetsBinding.drawFrame
binding.dart:916
flutter: #30     RendererBinding._handlePersistentFrameCallback
binding.dart:360
flutter: #31     SchedulerBinding._invokeFrameCallback
binding.dart:1299
flutter: #32     SchedulerBinding.handleDrawFrame
binding.dart:1230
flutter: #33     SchedulerBinding._handleDrawFrame
binding.dart:1088
flutter: #37     _invoke (dart:ui/hooks.dart:172:10)
flutter: #38     PlatformDispatcher._drawFrame (dart:ui/platform_dispatcher.dart:401:5)
flutter: #39     _drawFrame (dart:ui/hooks.dart:140:31)
flutter: (elided 5 frames from class _AssertionError and dart:async)
flutter:
flutter: ════════════════════════════════════════════════════════════════════════════════════════════════════
flutter: ══╡ EXCEPTION CAUGHT BY ANIMATION LIBRARY ╞═════════════════════════════════════════════════════════
flutter: The following assertion was thrown while notifying status listeners for AnimationController:
flutter: 'package:flutter/src/widgets/navigator.dart': Failed assertion: line 3968 pos 12: '_debugLocked &&
navigator.dart:3968
flutter: !_debugUpdatingPage': is not true.
flutter:
flutter: Either the assertion indicates an error in the framework itself, or we should provide substantially
flutter: more information in this error message to help you determine and fix the underlying cause.
flutter: In either case, please report this assertion by filing a bug on GitHub:
flutter:   https://github.com/flutter/flutter/issues/new?template=2_bug.yml
flutter:
flutter: When the exception was thrown, this was the stack:
flutter: #2      NavigatorState._flushHistoryUpdates
navigator.dart:3968
flutter: #3      NavigatorState.finalizeRoute
navigator.dart:5176
flutter: #4      TransitionRoute._handleStatusChanged
routes.dart:252
flutter: #5      AnimationLocalStatusListenersMixin.notifyStatusListeners
listener_helpers.dart:240
flutter: #6      AnimationController._checkStatusChanged
animation_controller.dart:815
flutter: #7      AnimationController._tick
animation_controller.dart:831
flutter: #8      Ticker._tick
ticker.dart:249
flutter: #9      SchedulerBinding._invokeFrameCallback
binding.dart:1299
flutter: #10     SchedulerBinding.handleBeginFrame.
binding.dart:1152
flutter: #11     _LinkedHashMapMixin.forEach (dart:collection-patch/compact_hash.dart:625:13)
flutter: #12     SchedulerBinding.handleBeginFrame
binding.dart:1150
flutter: #13     SchedulerBinding._handleBeginFrame
binding.dart:1067
flutter: #17     _invoke1 (dart:ui/hooks.dart:188:10)
flutter: #18     PlatformDispatcher._beginFrame (dart:ui/platform_dispatcher.dart:379:5)
flutter: #19     _beginFrame (dart:ui/hooks.dart:129:31)
flutter: (elided 5 frames from class _AssertionError and dart:async)
flutter:
flutter: The AnimationController notifying status listeners was:
flutter:   AnimationController#df15c(⏮ 0.000; paused; for DialogRoute<ApprovalResult?>)
flutter: ════════════════════════════════════════════════════════════════════════════════════════════════════

@slovnicki Any update on this, this is a mayor issue.
TLTR: I think you should check on a magic may if every animation is done or all the controllers on a page are disposed/done, or w8t until the next frame until you navigate rsmting like that idk sorry... ;-) I always keeps seeing somthing comming back reguarding The AnimationController notifying status listeners was: flutter: AnimationController#df15c(⏮ 0.000; paused; for DialogRoute<ApprovalResult?>) so somthing is up with a animationcontroller...
I have this problem in my 3 flutter apps, in all three i need to apply an Future.delayed(const Duration(milliseconds: 500))... this is a very ugly fix and this needs to be fixed asap.
The issue only exists in debug mode but it makes developing a nightmare... 👾
Here are some details on the error, hopefully you have found a solution since the first mention on Apr 27, 2021...
This is NOT a dialog only problem, this is a global widgets problem.
Here is some video proof:
Code that triggers error
approvalUiState.updateWith(
  purchaseInvoiceId: '',
  flowInstanceId: '',
);

Currently i FiXeD it using this peace of code:
Future.delayed(const Duration(milliseconds: kDebugMode ? 200 : 0), () {
  approvalUiState.updateWith(
    purchaseInvoiceId: '',
    flowInstanceId: '',
  );
});

Stack:
flutter: ══╡ EXCEPTION CAUGHT BY WIDGETS LIBRARY ╞═══════════════════════════════════════════════════════════ flutter: The following assertion was thrown building Builder(dependencies: [MediaQuery]): flutter: This route cannot be marked for remove. Either a decision has already been made or it does not flutter: require an explicit decision on how to transition out. flutter: 'package:flutter/src/widgets/navigator.dart': navigator.dart:1 flutter: Failed assertion: line 3207 pos 7: '!isWaitingForEnteringDecision && isWaitingForExitingDecision && flutter: isPresent' flutter: flutter: The relevant error-causing widget was: flutter: Builder flutter: core_providers.dart:106 flutter: flutter: When the exception was thrown, this was the stack: flutter: #2 _RouteEntry.markForRemove navigator.dart:3207 flutter: #3 NoAnimationTransitionDelegate.resolve transition_delegates.dart:32 flutter: #4 TransitionDelegate._transition navigator.dart:858 flutter: #5 NavigatorState._updatePages navigator.dart:3932 flutter: #6 NavigatorState.didUpdateWidget navigator.dart:3605 flutter: #7 StatefulElement.update framework.dart:5471 flutter: #8 Element.updateChild framework.dart:3685 flutter: #9 ComponentElement.performRebuild framework.dart:5322 flutter: #10 Element.rebuild framework.dart:5016 flutter: #11 StatelessElement.update framework.dart:5373 flutter: #12 Element.updateChild framework.dart:3685 flutter: #13 ComponentElement.performRebuild framework.dart:5322 flutter: #14 Element.rebuild framework.dart:5016 flutter: #15 StatelessElement.update framework.dart:5373 flutter: #16 Element.updateChild framework.dart:3685 flutter: #17 ComponentElement.performRebuild framework.dart:5322 flutter: #18 Element.rebuild framework.dart:5016 flutter: #19 ProxyElement.update framework.dart:5628 flutter: #20 _InheritedProviderScopeElement.update inherited_provider.dart:523 flutter: #21 Element.updateChild framework.dart:3685 flutter: #22 ComponentElement.performRebuild framework.dart:5322 flutter: #23 Element.rebuild framework.dart:5016 flutter: #24 StatelessElement.update framework.dart:5373 flutter: #25 Element.updateChild framework.dart:3685 flutter: #26 ComponentElement.performRebuild framework.dart:5322 flutter: #27 Element.rebuild framework.dart:5016 flutter: #28 BuildOwner.buildScope framework.dart:2779 flutter: #29 WidgetsBinding.drawFrame binding.dart:916 flutter: #30 RendererBinding._handlePersistentFrameCallback binding.dart:360 flutter: #31 SchedulerBinding._invokeFrameCallback binding.dart:1299 flutter: #32 SchedulerBinding.handleDrawFrame binding.dart:1230 flutter: #33 SchedulerBinding._handleDrawFrame binding.dart:1088 flutter: #37 _invoke (dart:ui/hooks.dart:172:10) flutter: #38 PlatformDispatcher._drawFrame (dart:ui/platform_dispatcher.dart:401:5) flutter: #39 _drawFrame (dart:ui/hooks.dart:140:31) flutter: (elided 5 frames from class _AssertionError and dart:async) flutter: flutter: ════════════════════════════════════════════════════════════════════════════════════════════════════ flutter: ══╡ EXCEPTION CAUGHT BY ANIMATION LIBRARY ╞═════════════════════════════════════════════════════════ flutter: The following assertion was thrown while notifying status listeners for AnimationController: flutter: 'package:flutter/src/widgets/navigator.dart': Failed assertion: line 3968 pos 12: '_debugLocked && navigator.dart:3968 flutter: !_debugUpdatingPage': is not true. flutter: flutter: Either the assertion indicates an error in the framework itself, or we should provide substantially flutter: more information in this error message to help you determine and fix the underlying cause. flutter: In either case, please report this assertion by filing a bug on GitHub: flutter: https://github.com/flutter/flutter/issues/new?template=2_bug.yml flutter: flutter: When the exception was thrown, this was the stack: flutter: #2 NavigatorState._flushHistoryUpdates navigator.dart:3968 flutter: #3 NavigatorState.finalizeRoute navigator.dart:5176 flutter: #4 TransitionRoute._handleStatusChanged routes.dart:252 flutter: #5 AnimationLocalStatusListenersMixin.notifyStatusListeners listener_helpers.dart:240 flutter: #6 AnimationController._checkStatusChanged animation_controller.dart:815 flutter: #7 AnimationController._tick animation_controller.dart:831 flutter: #8 Ticker._tick ticker.dart:249 flutter: #9 SchedulerBinding._invokeFrameCallback binding.dart:1299 flutter: #10 SchedulerBinding.handleBeginFrame. binding.dart:1152 flutter: #11 _LinkedHashMapMixin.forEach (dart:collection-patch/compact_hash.dart:625:13) flutter: #12 SchedulerBinding.handleBeginFrame binding.dart:1150 flutter: #13 SchedulerBinding._handleBeginFrame binding.dart:1067 flutter: #17 _invoke1 (dart:ui/hooks.dart:188:10) flutter: #18 PlatformDispatcher._beginFrame (dart:ui/platform_dispatcher.dart:379:5) flutter: #19 _beginFrame (dart:ui/hooks.dart:129:31) flutter: (elided 5 frames from class _AssertionError and dart:async) flutter: flutter: The AnimationController notifying status listeners was: flutter: AnimationController#df15c(⏮ 0.000; paused; for DialogRoute<ApprovalResult?>) flutter: ════════════════════════════════════════════════════════════════════════════════════════════════════

I will not create an issue for this because it seems you don't keep your issues up to date or fix them...


Make $SPARK_HOME writable when running non-root

We ran into another root vs non-root hiccup when testing OOB on openshift: #537
Should probably make $SPARK_HOME writable when running as non-root and/or under anonymous uid.
Possible alternatives:

simple chmod -R a+rwx $SPARK_HOME
make it writable by group 0 (the group assigned to anonymous uids)

cc @tmckayus @elmiko


Refactor - Core/Container/Media Control

Summary
Major refactor regarding Core/Containers/MediaControl relationships. The goal of the changes is to have a more sane MediaControl overriding and some other small changes in the components signatures.
This was planned for us to move in the direction of having a more customizable MediaControl, now turned into a UICorePlugin itself, making it easier to be overriden as well. It also contributes in having a better separation between components in order to have a more minimalistic Clappr core (which we'll call clappr-core) and separated plugins to have the player built in a mix-and-match style, having only the plugins the user needs.
Changes
Core

Added activeContainer and activePlayback properties to replace getCurrentContainer/getCurrentPlayback. The event CORE_ACTIVE_CONTAINER_CHANGED was created, being triggered whenever the activeContainer setter is called. This new event replaces MEDIACONTROL_CONTAINERCHANGED. This is a breaking change.
Removed MediaControl instantiation and initialization (it was converted into a UICorePlugin).
Deprecated getCurrentContainer/getCurrentPlayback methods. The implementations were updated to use the newer activeContainer/activePlayback.
Added mediaControl getter to keep compatibility, using a dummy component if there's no MediaControl plugin configured.

MediaControl

Changed MediaControl into an UICorePlugin. Now in order to replace the MediaControl with another custom implementation, instead of passing an option mediacontrol.external we just need to pass the replacement MediaControl in the plugins list, keeping in mind that the plugin name property should be media_control to use the plugin overriding system correctly. This is a breaking change.

UIObject/UIContainerPlugin/UICorePlugin

Renamed method remove to destroy on UIObject.
All visual plugins, as well as UIObject have now a consistent interface, with destroy removing them from DOM and liberating listeners, resources, etc.

Other

All built-in plugins have been updated accordingly.

Coverage increased (+0.1%) to 78.381% when pulling 2a9fc35bc8eca6fbb217c0938f6540c8496b128a on joaopaulovieira:rc-0.3.0 into 3a9bbb75909235eb1952128307d4e0d61d4131d6 on clappr:master.

This change was planned to prepare for the next iteration in the player architecture.
Actually, it has been discussed for a while between most of the core team members, and we decided to split it into some phases. This is the first phase of the changes required for our architecture review and the reduction of the player footprint, as well as the project being split into smaller ones.
If anyone else wants to review this, we'll leave the PR open until Oct 22. @clappr/core, if anyone there wants to review it, please do. Just don't merge it yet.


Account > Overview : History filterable into (last/weekly/montly)

just brainstorming .. Feedback appreciated

Other possible filters:

by asset
by receiver
memo (search)
date

yep nice - what i'm really loving on the Darkwallet GUI is that all balances are summed up to a weekly / monthly report ..

also referenced to https://github.com/cryptonomex/graphene-ui/issues/491 ... Ability to download history… for accounting etc. purposes

also .. https://github.com/cryptonomex/graphene-ui/issues/494

I still haven't had a change to touch this. Will move to 1216


devspace use: can hang under certain circumstances

This is an uncommon scenario but possible:

Create a space
Delete cluster keys
Run any kubectl command with the space context. This will hang forever

Fixed with v4.0.0


text output of data process

Text reports should be created along main outputs:
Bam2ReadEnds:

Number of paired reads
Number of reads filtered by gene annotation
Number of genes filtered by the minimum number of reads per gene.
Time of start and end of process.

mazter_mine:

Trinucleotide frequencies at 5' and 3'
Number of sites with data / Number of measurable sites by motif Distance
Time of start and end of process.

Also:

Average fragment size
Filtered reads by fragment size (transcriptomic)


Improve tests

added separate tests for .add()
added tests for adding/removing multiple classes
all HTML tests now have SVG variants for better coverage
clarified test titles for .toggle() as to differentiate them from the other methods
switched to current latest 2.x version of QUnit

If you set up a free BrowserStack account for this project, I can wire up the test suite.

@beck

Not yet willing to give up on upstream: https://github.com/eligrey/classList.js/issues/63

That guy takes years to hear back from. I've given up on him.

I've rewritten all the tests and implemented e2e scaffolding and a bit of CI so the polyfill gets tested across browsers.
Closing this in favor of: https://github.com/eligrey/classList.js/pull/69


extension-apiserver-authentication not found

I tried installing service catalog onto a k8s v1.10 cluster from the helm chart svc-cat/catalog.  The API server fails to start with the following error:
01:31:44.138448       1 authentication.go:232] Unable to get configmap/extension-apiserver-authentication in kube-system.  Usually fixed by 'kubectl create rolebinding -n kube-system ROLE_NAME --role=extension-apiserver-authentication-reader --serviceaccount=YOUR_NS:YOUR_SA'
Error: configmaps "extension-apiserver-authentication" not found

There is a configmap in the kube-system namespace called catalog.v1 but so far as I can tell the chart didn't create a configmap called extension-apiserver-authentication.

Helm should be creating the rbac to allow Catalog API server to read this.  Within charts/catalog/templates/rbac.yaml:
- apiVersion: {{template "rbacApiVersion" . }}
  kind: RoleBinding
  metadata:
    name: "servicecatalog.k8s.io:apiserver-authentication-reader"
    namespace: kube-system
  roleRef:
    apiGroup: rbac.authorization.k8s.io
    kind: Role
    name: extension-apiserver-authentication-reader
  subjects:
  - apiGroup: ""
    kind: ServiceAccount
    name: "{{ .Values.apiserver.serviceAccount }}"
    namespace: "{{ .Release.Namespace }}"

Can you see if this was created?
kubectl get roles  -n kube-system extension-apiserver-authentication-reader -o yaml
kubectl get rolebinding servicecatalog.k8s.io:apiserver-authentication-reader -n kube-system -o yaml
If you remove catalog (helm delete --purge catalog) and redeploy adding --debug to the helm install command, you'll get more verbose output that might help narrow in on the issue

Yes, the role and the role binding were created.  It also created 2 service accounts in the catalog namespaces for API server and the controller manager.  Both pods are failing to start.  I am trying to install this on an AWS EKS cluster.

Apparently EKS doesn't support custom API deployments and service catalog yet.  Closing for now.

@jicowan - we've been hearing of some other users unsuccessfully trying to use Catalog on EKS.  Can you provide a quick summary on what you found out?

I'm running into this same issue trying to install the stable/metrics-server on EKS.  Same error Could not create the API server: configmaps "extension-apiserver-authentication" not found

Just ran into this issue yesterday, and now found that EKS announced an update on this today:
https://aws.amazon.com/blogs/opensource/horizontal-pod-autoscaling-eks/
TLDR: Good news: Newly created clusters should work.

We stood up a new cluster which is on eks.2 and did a ARK restore on it. We were told that eks1 would not be upgraded to get this and we had to stand up a new cluster and migrate to it if we wanted to get HPA up and running.

I am facing similar issue but not AWS. I am running the cluster in VM. What is the resolution for this ?
I am getting error, while accessing this:
$ kubectl get rolebinding servicecatalog.k8s.io:apiserver-authentication-reader -n kube-system -o yaml
Error from server (NotFound): rolebindings.rbac.authorization.k8s.io "servicecatalog.k8s.io:apiserver-authentication-reader" not found

I get the same error, @Vikash082.  Did you find out how to add the group or whatever needs to be done?

@bergbrains if i remember correctly, i had to upgrade the k8s version both client and server.


Feedback for “Hello Sui”

run  node index.js  report an error  ,See screenshot

Change the file suffix to.mjs as prompted ,rerun  node index.mjs  report an error  ,See screenshot

Node.js v12.22.9.

node version updated to v22.7.0
problem solving


Add Config Observers for OAuth Token Config

This PR adds config observers for OAuth TokenConfig's AccessTokenMaxAgeSeconds and AccessTokenInactivityTimeout. It adds separate functions for observing these two fields. It also provides another function that merges the observed config for both these fields.
These config observers would be reused by both cluster-authentication-operator and cluster-kube-apiserver-operator to write appropriate config file for oauth-server and kube-apiserver respectively.

@stlaz I stole the code from your commit and created this PR. I would really appreciate if you could review it.

/lgtm

/approve


AC: IE API read net update

fix deprecation warning with backward compatibility

Jenkins please retry a build

Jenkins please retry a build


Download logs button

Important notices
Before you add a new report, we ask you kindly to acknowledge the following:
[-] I have read the contributing guide lines at https://github.com/opnsense/core/blob/master/CONTRIBUTING.md
[-] I have searched the existing issues and I'm convinced that mine is new.
Is your feature request related to a problem? Please describe.
When you check logs, it only shows you the defined amount of lines from the log. This helps if the error you are looking for happened recently but there is no direkt way to get the old entries of the log file.
Describe the solution you'd like
A download logs functionality would be nice. This could download the current logs or there can be an overview page where you can download all logs and the rotated versions as a .zip file.
Describe alternatives you've considered
An alternative could be a log overview page with pagination functionality and search functionality by date and age of entries. This would it make easier to debugg erros happened in the past if no central logging is in place.

the raw logs likely won't be of much use, since they are circular (needs clog to read), you might consider sending logs to a remote syslog server, which is actually quite easy to setup.

Then maybe the log view could be generated as download for a defined count of lines or the complete available log?
I know the logserver would be a better solution, in some cases when I face a problem where the firewall from time to time is not online, the messages directly on the box are helpfull.

the new log view will have a button to download the visible items.


bots: Allow bot owners to unsubscribe their own bots from streams using UI.

This PR allows bot owners to unsubscribe their own bots from subscribed streams using UI.
The process is the same as normal users: Profile info popover > View full profile > streams tab
Admins can unsubscribe bots from streams using this UI like normal users.
CZO
Fixes part of: #21402

Screenshots and screen captures:

Self-review checklist

[x] Self-reviewed the changes for clarity and maintainability
(variable names, code reuse, readability, etc.).

Communicate decisions, questions, and potential concerns.

[x] Explains differences from previous plans (e.g., issue description).
[x] Highlights technical choices and bugs encountered.
[x] Calls out remaining decisions and concerns.
[x] Automated tests verify logic where appropriate.

Individual commits are ready for review (see commit discipline).

[x] Each commit is a coherent idea.
[x] Commit message(s) explain reasoning and motivation for changes.

Completed manual review and testing of the following:

[x] Visual appearance of the changes.
[x] Responsiveness and internationalization.
[x] Strings and tooltips.
[x] End-to-end functionality of buttons, interactions and flows.
[x] Corner cases, error conditions, and easily imagined bugs.

Cool!
Since bots don't show up in the right sidebar, how would the user generally get to the bot's profile? I'm not even sure how to test the PR...
Should we add one or more links to the Personal settings > Bots UI.

In Personal settings > Bots, we can add a button in the bot's info card to open a modal of bots subscribed streams with an unsubscribe button.

In Personal settings > Bots, we can add a button in the bot's info card to open a modal of bots subscribed streams with an unsubscribe button.

OK, cool. Do you want to file and pick up the issue for adding that button? I think it would be good to have an issue so that we don't lose track of it.

When testing this PR, the full profile link and streams management UI worked as expected, but I saw the following error when I clicked on the "Manage this user" link. Are you seeing that as well? This was with  tools/fetch-rebase-pull-request.

I tested it just now, but I didn't see this error

I can add a fix of #22460 in this PR as a separate commit, as this PR's commits are reusable for #22460 and this PR will not be a blocker for #22460.

When testing this PR, the full profile link and streams management UI worked as expected, but I saw the following error when I clicked on the "Manage this user" link in the bot's profile. Are you seeing that as well? This was with  tools/fetch-rebase-pull-request.

We display the user's edit modal instead of the bot's edit modal(in case of bot's profile), I guess fixing this issue might solve this above error too.

Screenshots

"Manage bot" modal in settings > bots

@alya thoughts??

Error fixed by changing existing code of PR.

Playing with the PR, we currently show a "Deactivate user" button for the bot, which pops up the wrong modal:

Instead, we should have a "Deactivate bot" button, and trigger the bot deactivation modal:

Playing with the PR, we currently show a "Deactivate user" button for the bot, which pops up the wrong modal:
Instead, we should have a "Deactivate bot" button, and trigger the bot deactivation modal:

I was planning to display the bots own "Manage bot" modal here, #22482 is the issue I filed for this.
Should we add deactivate button on the "Manage bot" modal?

I noticed that LastPass adds an icon to the bot name field. Is that something we have any ability to prevent?

I am not able to see this icon I checked every modal of bots, where are you able to see this?

I noticed that LastPass adds an icon to the bot name field. Is that something we have any ability to prevent?

I am not able to see this icon I checked every modal of bots, where are you able to see this?

You would only see it if you have the LastPass browser extension installed.

I was planning to display the bots own "Manage bot" modal here, #22482 is the issue I filed for this.
Should we add deactivate button on the "Manage bot" modal?

Ah, sorry, you're right -- the bug described above is in master, not new to this PR.

@Signior-X would you perhaps be up for doing a code review on this PR?

@Signior-X any additional feedback from your side?

Once this is merged, we should do a pass on help center documentation on bots to make sure it's up to date. @yogesh-sirsat , @drrosa perhaps you can work together on this.

I merged the first commit after fixing a grammar issue.

PR updated with changes suggested by the above review comments.

@timabbott just a polite ping about this PR.

I made substantial changes to 9444bcc2286af65f76c7ef831bc214a8653386f7 to make the logic more readable, make the tests somewhat cleaner (not relying on the initial state of which users own which bots), and document the API change.
With those changes, I think this PR is good to merge, but leaving until CI passes in case I broke something (I already caught one issue when rebasing, since I merged a different PR that changed a string in the tests last night). Thanks for all the revisions on this @yogesh-sirsat!


[7.0.0]vCan't import flow types

Hi, I am trying to import the new outstanding types in my project, but it doesnt seem to work .
I am trying this way :
import type { FormProps } from 'redux-form';
Unless there is another way to import them.
I also noticed a bunch of errors in my editors (atom & vscode):
file: 'file:../node_modules/redux-form/lib/index.js'
severity: 'Error'
message: 'inconsistent use of library definitions (Object.defineProperty Property not found in object literal)'
at: '1,1'
source: 'flow'

Ooh, I did want to export that, but I don't think I got around to it. What I am assuming we are talking about is the type that would match this object, the props provided to your form component from the redux form HOC..

yes , I intend to use it as the following:
// @flow

import React, { Component } from 'react';
import {Field, reduxForm } from 'redux-form';

import type { FormProps } from 'redux-form';

type Props = FormProps & {
  onSubmitProp: Function,

};

class ContactForm extends Component {
  props: Props;

  render() {
    const { handleSubmit, pristine, submitting, onSubmitProp } = this.props;

    return (
      <form onSubmit={handleSubmit(this.onSubmitProp)}>

          <Field
              name="name"
              component="input"
              placeholder="Name"
            />

          <button type="submit" disabled={pristine || submitting}>
      </form>
    );
  }

}

export default reduxForm({
  form: 'contact'
})(ContactForm)

Fix published in v7.0.1.


No Shadow in Client (Carla 0.9.3)?

I know CARLA graphics are decent, I might be doing something wrong. I'm running CARLA 0.9.3 with "-quality-level=EPIC", and in the client window I can't see any vehicles shadows, and the graphics quality seems not good as in the image below.
For the client, I create a pygame.display and blit(_surface) to it, where _surface set via pygame.surfarray.make_surface with a carla.ColorConverter.Raw of sensor.camera.rgb sensor.

This does not happen anymore with CARLA recent 0.9.4 version. It should be closed.

How did you fix this? I was messing around with some settings, and even with EPIC, it still lacks shadows. It was working before this

Hello, I'm running on 0.9.6 and my Carla installation doesn't seem to have any shadows! What is the fix for this behaviour?

Hello,
I applied the fix here:
https://github.com/carla-simulator/carla/issues/2019
And my shadows have returned.
Thanks,
Jack


Cannot override name from .pkgr.yml

I'm experimenting with your gem on CI and I have a strange issue in the latest version. When building packages in CI server the working directory has a name I can't control easily (IIRC is generated from commit number) so I've pinned application name in .pkgr.yml file. However when I build packages generated name is not overridden. I did a quick test in a vagrant virtual machine using a directory named foo for sources and here's the result:
$ cat .pkgr.yml
name: my-app
notifications: false
before:
  - cp config/application.example.yml config/application.yml
targets:
  ubuntu-12.04:
    dependencies:
      - opendkim-tools # Used to verify DKIM signed messages

$ pkgr package . --force-os "ubuntu-12.04" --verbose --debug 2>&1 | tee log/pkgr.log
[2015-04-30T13:12:23+02:00] DEBUG: sh(git describe --tags --abbrev=0)
[2015-04-30T13:12:23+02:00] DEBUG: Initializing builder with the following config: #<Pkgr::Config verbose=true, debug=true, buildpacks_cache_dir="/home/fabio/.pkgr/buildpacks", architecture="x86_64", iteration="20150430131201", dependencies=[], build_dependencies=[], auto=false, clean=true, edge=true, env=[], force_os="ubuntu-12.04", version="0.0.0", name="foo">
[2015-04-30T13:12:23+02:00] DEBUG: sh(tar xzf /tmp/pkgr-tarball20150430-27230-vrp6uc.tar.gz -C /tmp/d20150430-27230-7e7r6y/opt/foo)
[2015-04-30T13:12:30+02:00] DEBUG: Loading ubuntu-12.04 from /tmp/d20150430-27230-7e7r6y/opt/foo/.pkgr.yml.
[2015-04-30T13:12:30+02:00] DEBUG: Configuration from file: {"name"=>"my-app", "notifications"=>false, "before"=>["cp config/application.example.yml config/application.yml"], "targets"=>{"ubuntu-12.04"=>{"dependencies"=>["opendkim-tools"]}}} - Distribution: "ubuntu-12.04".
[2015-04-30T13:12:30+02:00] DEBUG: Found .pkgr.yml file. Updated config is now: #<Pkgr::Config name="foo", notifications=false, before=["cp config/application.example.yml config/application.yml"], dependencies=["opendkim-tools"], verbose=true, debug=true, buildpacks_cache_dir="/home/fabio/.pkgr/buildpacks", architecture="x86_64", iteration="20150430131201", build_dependencies=[], auto=false, clean=true, edge=true, env=[], force_os="ubuntu-12.04", version="0.0.0">

Am I doing something wrong? Is this a bug?

I think the issue is in this line
# current behavior
@config = Config.load_file(config_file, distribution.slug).merge(config)
# shouldn't it be merged in the opposite way?
@config = config.merge(Config.load_file(config_file, distribution.slug))

Otherwise if that is intentional because config contains hardcoded values that need to be preserved you should opt out other config keys (e.g. name)

Hi @fabn,
CLI options should take precedence over anything declared in the .pkgr.yml file, so I think the current behaviour is correct.
Regarding your issue, can't you just pass the name as a command line argument to the pkgr tool with --name=my-app?

I'm closing this, please reopen if you still have the issue.


Use VFS infrastructure for continuous build

This allows faster feedback on macOS, since we now use the native watchers there as well and not a polling implementation.
Design spec: https://docs.google.com/document/d/1ASLEPRWn4nRWa8p6Y_gE5gFZMBbIqolA4CzmXIiUkOM/edit#heading=h.8hdfp6sn7rff
Fixes #3427
Fixes #11834

@bot-gradle test and merge

OK, I've already triggered a build for you.

Pre-tested commit build failed.

@bot-gradle test and merge

OK, I've already triggered a build for you.

@bot-gradle cancel

OK, I've already cancelled the pre-tested commit build.

@bot-gradle test and merge

OK, I've already triggered a build for you.

Pre-tested commit build cancelled.

@bot-gradle test and merge

OK, I've already triggered a build for you.


Patchy background on dark theme

Does this issue occur when all extensions are disabled?: Yes

VS Code Version:

Version: 1.69.2 (Universal)
Commit: 3b889b090b5ad5793f524b5d1d39fda662b96a2a
Date: 2022-07-18T16:12:57.074Z (2 days ago)
Electron: 18.3.5
Chromium: 100.0.4896.160
Node.js: 16.13.2
V8: <IP_ADDRESS>-electron.0
OS: Darwin x64 21.5.0

OS Version: macOS Monterey 12.4

Steps to Reproduce:

Restart VSCode to upgrade to 1.69.2
Background areas not covering by code appear lighter in color.
Happens in all dark themes (including built in themes)

/duplicate

Thanks for creating this issue! We figured it's covering the same as another one we already have. Thus, we closed this one as a duplicate. You can search for similar existing issues. See also our issue reporting guidelines.
Happy Coding!

/duplicate

Wasn't easy to find the duplicate sorry.
FYI for anyone arrive later, there're fixes suggested here https://github.com/microsoft/vscode/issues/152816


Add OLMo 1.7-7b README + Config

@2015aroras - do you think that for 1.7 we should have two configs? I understand that training was stopped, config changed, then resumed.

Hi, thank you so much for the work! Is there an estimated date of when all the details including the https links of the training data and the data order files are going to be released?

@kyleclo @soldni Do you have any updates on the data side?


Failed design time build on changing TargetFramework

Create new .NET Standard library or .NetCore App.
Right-click project and choose Edit csproj and change <TargetFramework>netcoreapp1.0</TargetFramework> to <TargetFramework>net451</TargetFramework> and save.
Change target framework from <TargetFramework>net451</TargetFramework> to <TargetFramework>netcoreapp1.0</TargetFramework> and save.

Got: Failed design time build in the Debug output window, which seems to be executed with a project snapshot using the prior target framework (net451), but the imported targets are as per the new target framework (netcoreapp1.0), and hence causes missing target error.
Target "DesignTimeXamlMarkupCompilation" in file "C:\Windows\Microsoft.NET\Framework\v4.0.30319\Microsoft.Xaml.targets" from project "C:\Users\mavasani\documents\visual studio 2017\Projects\ClassLibrary6\ClassLibrary6\ClassLibrary6.csproj" (target "CoreCompile" depends on it):
Done building target "DesignTimeXamlMarkupCompilation" in project "ClassLibrary6.csproj".
The target "DesignTimeMarkupCompilation" does not exist in the project.
Done building project "ClassLibrary6.csproj" -- FAILED.
Build FAILED.

I set a breakpoint in CPS ProjectBuildSnapshotService.UpdateSnapshotCoreAsync and see that the design time build is for TargetFramework net451, CoreCompileDependsOn property includes target DesignTimeMarkupCompilation, which exists in Microsoft.WinFx.Targets, which is only imported for NetFx or Silverlight projects. So I feel we get this error because we are trying to get the target to execute using TargetFramework netcoreapp1.0, causing us to not find this target.

So the failing design time build on TargetFramework change seems to be similar to the underlying CPS issue with unit test discovery on TargetFramework change.. when the TF is changed, a design time build is immediately kicked off and CPS uses the project snaphot and properties from before the edit, but when it tries to do the DT build, certain targets files are missing as it uses the new project file to compute the targets to execute.
For example, if TargetFramework = net451, includes Microsoft.WinFx.Targets, which sets CoreCompile to execute a target DesignTimeMarkupCompilation defined in this target file. When TargetFramework is changed to netcoreapp1.0, CoreCompileDependsOn still has this target, but design time build never imports Microsoft.WinFx.Targets for netcoreapp1.0. and we can a failed design time build with the following error:
Target "DesignTimeXamlMarkupCompilation" in file "C:\Windows\Microsoft.NET\Framework\v4.0.30319\Microsoft.Xaml.targets" from project "C:\Users\mavasani\documents\visual studio 2017\Projects\ClassLibrary6\ClassLibrary6\ClassLibrary6.csproj" (target "CoreCompile" depends on it):
Done building target "DesignTimeXamlMarkupCompilation" in project "ClassLibrary6.csproj".
The target "DesignTimeMarkupCompilation" does not exist in the project.
Done building project "ClassLibrary6.csproj" -- FAILED.
Build FAILED.

Basically design time builds will break as soon you edit a property that changes the included targets, until the CPS project snapshot service catches up and generates a new project snapshot and kicks off a subsequent design time build.
Tagging @lifengl @jviau - is it possible to avoid the design time build on stale project snapshot? Otherswise, I recommend we make the targeted fix for TF change for RTM: https://github.com/dotnet/roslyn-project-system/pull/1478

@lifengl @jviau Did you guys get a chance to look at this issue? I am unable to make further progress into debugging CPS design time builds.
Note that the failed design time build is causing lot of IDE weirdness (broken intellisense, squiggles, etc.) and can seemingly happen when user edits any property that changes the included targets. This can cause lot of subtle IDE issues.

@mavasani I am looking into it now.

The issue here is that CPS runs design time builds out-of-proc. In that state msbuild has auto-reload from disk enabled. This means when you quickly change from netcoreapp1.0 to net451 and back to netcoreapp1.0, CPS will pass the correct project instance with net451 to msbuild , but it will auto-reload the new netcoreapp1.0 project form disk and fail the build. Msbuild reloads from disk before CPS has reacted to the changing project file at all, so we can't stop the failed design time build.
Eventually a successful design time build is processed as we react to the project file change, so why does intellisense and test explorer remain broken? Is down chain dataflow faulting? The IProjectBuildSnapshot is of interesting form - since the design time build outright never ran, there is no results for us to present. TargetOutputs and TargetSuccess will be empty dictionaries.

But who's figuring out what targets to execute? Builds should be consistent, I should never attempt to build targets that don't come from the project that was just loaded from disk.

I believe MSBuild is doing a combination of using properties from the instance we supply, but targets from the reloaded file on disk.
The targets we are executing, which is part of the build submission:
CollectResolvedSDKReferencesDesignTime;
CollectPackageReferences;
ResolveComReferencesDesignTime;
ResolveProjectReferencesDesignTime;
ResolveAssemblyReferencesDesignTime;
CollectSDKReferencesDesignTime;
ResolvePackageDependenciesDesignTime;
CompileDesignTime;

The target that fails, DesignTimeMarkupCompilation, is not part of that set at all. CPS never asks for that soon-to-be-invalid target to build. MSBuild must be getting it from the CoreCompileDependsOn property from the project instance we supply. (The only 2 things we pass to msbuild in this case is the ProjectInstance and the list of targets).

Ported to VSO 385643 - this is CPS or MSBuild bug.


tensorlayer.visualize.W : error "total size of new array must be unchanged"

looks like tensorlayer.visualize.W() always throws an error "total size of new array must be unchanged".
perhaps it is because of the line " feature = W[:,count-1] / np.sqrt( (W[:,count-1]**2).sum()) "
where if count==1, then it will be an empty list.

@haigu12 can you show your code, when you got this error ?
How is your weight matrix look like ?

@wagamamaz
the network code is:
'''define placeholders'''
x = tf.placeholder(tf.float32, shape=[None, 1], name='x')
y_= tf.placeholder(tf.float32, shape=[None, 1], name='y_')
'''define the network'''
network = tl.layers.InputLayer(x, name='input_layer')
network = tl.layers.DenseLayer(network, n_units=16, act = tf.nn.relu, name='relu1')
network = tl.layers.DenseLayer(network, n_units=4, act = tf.nn.relu, name='relu2')
network = tl.layers.DenseLayer(network, n_units=1, act = tf.nn.relu, name='result')
and after training,

network.all_params[0].eval()
array([[-0.12620708, -0.13378434,  0.05406925, -0.06829847,  0.12863488,
-0.0354087 , -0.01825967,  0.06813091, -0.05230081, -0.09361359,
-0.08705429,  0.08989979, -0.17979668,  0.01737362,  0.11124372,
0.04816928]], dtype=float32)

Hi, your shape is incorrect, and why you use DensLayer when X only have one feature?
Check you model pls.

Ah, I see, the shape should be [1,1].
It's only a test program, and I was trying to make things simple.


[Windows] Fix handling of paths in console wrapper

Wrapper does not handle paths with spaces
There might be an alternative way to add this or format this, but this solves the problem, I'm surprised this hasn't popped up before (it only did for me now because my new laptop was configured in the store and had "First-name Last-name" as my account, triggering this)
Additionally we might want to make the error message a bit more descriptive (I had to hack in printing the command line string to discover what was even wrong for this), but not touching that right now

I'll send the error message later today, it fails to run if the path to the main executable contains spaces

it fails to run if the path to the main executable contains spaces

I have tried path with spaces, and executable name with spaces in various combinations and all work with issues.


Image doesn't allow environment variables to be passed

The image won't allow environment variables to be passed in.  Features dependent on being able to work with environment variables, such as auto wallet unlock, don't work.

Hi there, @virtualmotion !
Which image, specifically, are you having trouble with? Can you share the exact command you're using to run it?
I tried the following:
inovakov ~ % docker run -d -e SIA_DATA_DIR=/new-sia-data-dir -e SIAD_DATA_DIR=/new-siad-data-dir -e SIA_API_PASSWORD=lalala -e SIA_WALLET_PASSWORD=MyWalPass nebulouslabs/sia:latest
784c85a4f652b69543a19435594a762e78c295ce28f10578cb558301198d674f
inovakov ~ % docker exec 784 env
PATH=/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin
HOSTNAME=784c85a4f652
SIA_DATA_DIR=/new-sia-data-dir
SIAD_DATA_DIR=/new-siad-data-dir
SIA_API_PASSWORD=lalala
SIA_WALLET_PASSWORD=MyWalPass
SIA_MODULES=gctwhr
HOME=/root

As you can see from the output, the extra environment variables were correctly registered in the container's environment. I also ran a custom image with a modified run.sh that prints the environment right before launching siad and that had similar output.

Thank you @ro-tex .  Upon digging deeper, I had used a password generator for my wallet password -- which had included the symbol '$'.  It seems environment variables either don't like that very much or docker doesn't like it.  After revising the password to not have a dollar sign, it seems to work.