container network statistics not correct

When using lxc info ctname the network statistics are incorrect.
Packets sent and received are identical, which is incorrect:
If you ping a host that drops icmp echo requests, packets sent should increase, and received should not. However, both counters increase.
Also, my gut says that bytes received/sent are also incorrect, but I cannot verify this at the moment:
    eth0:
      Bytes received: 13.35GB
      Bytes sent: 187.06MB
      Packets received: 231350387
      Packets sent: 231350387

% lxc info
apicompat: 0
auth: trusted
environment:
  addresses:
  - <IP_ADDRESS>:8443
  architectures:
  - x86_64
  - i686
  certificate: |
    -----BEGIN CERTIFICATE-----
    -----END CERTIFICATE-----
  driver: lxc
  driverversion: 2.0.0.rc13
  kernel: Linux
  kernelarchitecture: x86_64
  kernelversion: 3.13.0-79-generic
  server: lxd
  serverpid: 4044
  serverversion: 2.0.0.rc7
  storage: dir
  storageversion: ""
config:
  core.https_address: <IP_ADDRESS>:8443
public: false

The packets sent field was indeed wrong, the rest does match the kernel values from /proc/net/dev. I sent a fix for this.


Reorganize materials

Put all data in data folder
Put all slides in slides folder (no need for subdirectories)

gists updated so all data files live in a single folder and paths check out

gists updated so all data files live in a single folder and paths check out


Sterling issue 4129

Description
This PR aims to solve issue 4129,
The solution is to make use of
bool SniffCSVNameAndTypeDriver::addRow(uint64_t, common::column_id_t columnCount) inside driver.cpp,
it dumbly returns true before, we could add a check of columnCount here, similar to what we did in
bool ParsingDriver::addRow(uint64_t /*rowNum*/, common::column_id_t columnCount).
And also in serial_csv_reader.cpp the numColumn of columnInfo inside the Reader need to be initialized properly as auto columnInfo = CSVColumnInfo(bindInput->expectedColumnNames.size() /* numColumns */, {} /* columnSkips */);,before it was simply zero.
A new field "rowEmpty" is introduced in SniffCSVNameAndTypeDriver, which is checked by addRow function to skip any empty row during the sniffing, similar to what we did in ParsingDriver.
After these changes, the mismatched num of columns problem can be detected when sniffing the header, as expected in the BUG description.
Three test cases are revised accordingly, which is 521/1219/1223, they was expecting exception to be thrown in content before, now they should expect exception to be thrown in header.
Fixes # (4129)
Contributor agreement

[x] I have read and agree to the Contributor Agreement.

Btw, please make the PR title be more meaningful: 1) you don't need to include your username in the title; 2) issue ID is not the best reference as you don't know what it refers to unless you clicks into the issue.

Thank Guodong for the reviewing, refactored the SniffCSVNameAndTypeDriver to be extended from SerialParsingDriver


Ignore by Wildcard

Suggestion: allow ignoring external resources with wildcard.
Suppose you have a file:
import { a } from { 'lib/a' };
import { b } from { 'lib/b' };
...

lib is an external library. I would like to be able to exclude both lib/a and lib/b from build. Currently, I have to do something like this:
new Builder({
    meta: {
        'lib/a': { build: false },
        'lib/b': { build: false }
    }
});

It's fine when lib only has two modules a and b but it becomes a little too verbose if there are many modules in lib.
It would be nice if I could exclude externals as lib/* somehow.

This should be supported currently with app - [lib/*]. Let me know if you're unable to have lib present at build time though and there might be some other options.

One example of lib is angular2 so it is present but already built. I am able able to config the builder like this:
builder.config({
    paths: {
        'angular2/*': 'lib/angular2/angular2.dev.js'
    }
});
builder.build('app - [angular2/*]', 'out.js');

This results in error (at angular2.dev.js:716:22):
    module.exports : window));
                     ^
ReferenceError: window is not defined

It would be cool if the builder didn't even try find and load lib if I say app - lib/*. This way I wouldn't have to call config for an external library that I'm excluding anyway.
Thanks!

@abakirov this is a bug, and not related to the builder at all. The reason Angular is being executed is because it is in your original trace, and we therefore need to know it's dependencies so that is all by design. The issue actually is that angular2 is being detected as the System.register format by mistake here. You need to add System.config({ meta: { 'angular2.dev': { format: 'amd' } } }) or global and that should work.
I've created a bug for the detection issue at https://github.com/systemjs/systemjs/issues/447.

I have a similar issue, when i try to minify the, into ES5  compiled angular 2 components.
As the project mixes with angularJs, the angularjs files ar getting minimized perfectly, but it tries to search for angular2/angular2 im my app directory instead in the node_modules folder in the parent of the app folder.
adding the following does not work.
builder.config = {
    meta: {
        'angular2/angular2' : {build: false}
    }
}

It is still trying to look for angular2.js in the app folder.
How can i solve this problem?


Screen scaling for tiled display

i think it would be a good idea to give the option to scale tile based games.

---
Want to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/8732384-screen-scaling-for-tiled-display?utm_campaign=plugin&utm_content=tracker%2F297828&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F297828&utm_medium=issues&utm_source=github).

This is already possible. The tileSet option can be either HTML <img> tag or a <canvas> element, so you are free to adjust your tiles as necessary (by pre-drawing them scaled to a secondary canvas, for instance) before using them with rot.js.

the way i did was
display.getContainer().getContext('2d').imageSmoothingEnabled = false; display.getContainer().getContext('2d').scale(2,2);
it scales up the drawings without blurring the pixels for pixely art stuff.
i think you can close that topic now xD

Global canvas scaling might work fine for this particular case, but please keep in mind that:

this does not work for tiles mixed with text (text will be scaled as well),
canvas scaling breaks the eventToPosition computation.

@ondras How does text and tiles works at the same time? the interactive guide gives me no clues how to manage it.


Create dev container and get it published with instructions for VS Code on armadaproject.io

Create dev container and get it published with instructions for VS Code on armadaproject.io
https://code.visualstudio.com/docs/remote/containers
We could also look into IntelliJ solutions. https://www.gitpod.io/

8

Closing in favor of #1599


unsafe blocks

We don't plan to support unsafe blocks.

Great timing of the bot, this should also go on https://github.com/cryspen/home/issues/95 I suppose @W95Psp

Basic support was added in #867.
I suppose now the question is: what do we do with unsafe blobs? Shall we just extract them as is? That's probably fine, unsafe is just a marker, at the end, performing an unsafe operation resolve to (1) calling unsafe functions or (2) raw pointers. We still reject raw pointers right away, and unsafe functions are just normal functions that usually make strong assumptions, which we can model precisely with strong preconditions
I wonder if we should just turn the unsafe feature on in the F* backend then. Wdyt @franziskuskiefer?

Sure, let's turn it on for F* and see what happens.
Is more needed than the basic support? If so, please update the issue on what remains unsupported and what's supported. If not, let's close this.

No, more advanced support would mean library support in the backends, so we should close that issue.
Ok! Will push a PR, it's gonna be a very small PR.


all: bump to v1.4.1+coreos.0 / kube-dns-v20

This includes the required addon updates to kube-dns v20 which is
included in K8s 1.4.1.
Changes to the kube-dns rc where taken from:
Bump up addon kube-dns to v20 for graceful termination:
kubernetes/kubernetes#3e55d4d6bd8847791f7119fbd669b5b1d7bc575e
In addition some changes to the health checks that were missed in
previous version bumps were taken from:
Tune down initialDelaySeconds for readinessProbe:
kubernetes/kubernetes#55db76241cf10d0fa943281bd5a8aa1e9c4dc509
Split dns healthcheck into two different urls:
kubernetes/kubernetes#d17cd1a5147ca7feb63b5d841f24527861b02912
Also fixed an accidental version bump regarding rbd docs for
kubelet-wrapper that were changed in the v1.4.0+coreos.0 bump.
I have only manually tested the changes with kube-aws.
This PR obsoletes #712.

Rebased on master and fixed a missed replace in the example syntax of contrib/bump-version.sh.

@felixbuenemann Thank you for helping out with this! This looks good to me at first look over. I'll give this a test at some point today and merge it after.

@felixbuenemann  LGTM -- I'll merge it when your ready

Should be ready.


Provide PDTable example source

Provide PDTable example source

The current example shows a PDForm example, not PDTable.

There appears to be a PDTable example in the demo app now?


Drop Python 2 Support

Dropped at https://github.com/giantas/pyconfigreader/commit/8b3ac98c8e3d001cb45e553e8b67089bb19ba2db


Feature request: Use more appropriate indicators for Trail/Grid/Juggl view

Is your feature request related to a problem? Please describe.
I've seen two main problems with the use of some indicators, mostly in the in-note view.
Describe the solution you'd like

For the trail view, → is used, but seems to me like that's a navigation glyph

› or > are more commonly used to communicate hierarchical relationships (see Windows Explorer, Google Drive, etc.)

In the next-prev view, putting prev and next is clunky, unappealing, and just all kinds of wrong in other languages, especially in long-ish titles

← and → seem more appropriate for this use

Describe alternatives you've considered
I've actually made a theme with these considerations in mind. Pictured in the section below.
Additional context
This is a side-by-side view of the modified CSS. Pay attention to the symbology. Don't mind the theming.

Original
Suggested symbology

Hey, a couple of points:

I'm rebuilding the plugin from scratch, and don't intend to implement the Trail view. The Grid view shows the same info.
The prev and next fields can be called whatever you want, so you can change the hierarchy field as you see fit


Redis : Added system test

towards #5947

@chingor13 Build failed due to Redis service is not enable or activate for this project.

@athakor I enabled the Redis API on the test project and restarted the test. It's now failing with a validation error about an invalid network parameter.

@chingor13 PTAL


max_length parameter is not honored w/ Vicuna13-b

Running the model:
output = replicate.run(
    "replicate/vicuna-13b:e6d469c2b11008bb0e446c3e9629232f9674581224536851272c54871f84076e",
    input={"prompt": "Which NFL team won the Super Bowl when Justin Bieber was born? Think step by step.",
           "temperature":0.75,
           "max_length":500})

We specify max_length:500, so 500 tokens.
But, the output is 940 words, or 940 * 2.5 tokens.

@bfirsh @mattt @zeke please help!

Hi, @rlancemartin. This sounds more like an issue for the Vicuna-13B model than the Python client library itself, so I'm going to transfer to that repo.
I just tried this myself using the web UI ^1, and the output was within expected range (using OpenAI's tokenizer, 308 tokens; I didn't try feeding it through the model's tokenizer, though).
Can you share any more information to help us diagnose the problem?
/cc @replicate/models


8

Release osbuild-composer version 8

Let's wait for #331 before the release...

#331 has been merged, but Travis is unhappy, do you know why it was canceled?

I cancelled it manually. I've just rebased the release commit, let's wait for the CI and we can release.


Prl 4698 order error

Before creating a pull request make sure that:

[ ] commit messages are meaningful and follow good commit message guidelines
[ ] README and other documentation has been updated / added (if needed)
[ ] tests have been updated / new tests has been added (if needed)
[ ] the enable_keep_helm label has been added, if the helm release should be persisted after a successful build

Please remove this line and everything above and fill the following sections:
JIRA link (if applicable)
https://tools.hmcts.net/jira/browse/PRL-4698
Change description
Allow CA cases for DA orders
Does this PR introduce a breaking change? (check one with "x")
[ ] Yes
[x] No

PLease check the latest comment in https://tools.hmcts.net/jira/browse/PRL-4698 . Closing this PR for now.


Add Jib Ownership Maven Extension

Towards https://github.com/GoogleContainerTools/jib/pull/1257 and https://github.com/GoogleContainerTools/jib/pull/1955, as well as a workaround for https://github.com/GoogleContainerTools/jib/pull/1270.
The Jib Maven extension allows the user to customize file ownership in layers.
The following example sets UID 300 and GID 500 for /app/classes/**.
<configuration>
  <pluginExtensions>
    <pluginExtension>
      <implementation>com.google.cloud.tools.jib.plugins.extension.maven.ownership.JibOwnershipExtension</implementation>
      <configuration implementation="com.google.cloud.tools.jib.plugins.extension.maven.ownership.Configuration">
        <entries>
          <entry>
            <glob>/app/classes/**</glob>
            <ownership>300:500</ownership>
          </entry>
        </entries>
      </configuration>
    </pluginExtension>

However, due to the way Jib adding parent directory tarball entries, the directories /app and /app/classes will have the ownership 0:0 (root:root). Considering the use-case of Skaffold, we should verify if this can cover the use-case; otherwise, we may need to revisit https://github.com/GoogleContainerTools/jib/issues/1270.

can we change the PR description to describe the ownership extension?

Updated the description. Worth checking.
I'll take care of the code comments next week.


removed ec2 from abstract provisioner (closes #1974(

This will help address the failing CWL CI tests: https://ci.commonwl.org/job/toil-conformance/test/?width=800&height=600


2024-3.0 py311/312 envs

Closes #42 - list of dependencies
Closes #43 - prefect version pin
Closes #38 - pyarrow version

We plan to release https://github.com/NSLS-II-HEX/hextools/pull/25 as well, therefore converted to draft.


Fetch data for /_api/cluster/agency-dump always from leader.

Add option "redirectToLeader" to /_api/agency/state. This is a
strictly internal API which is currently not documented. Without
the option, it does not change in behaviour. The actual change in
/_api/cluster/agency-dump only repairs a bug which can happen in rare
cases when the request to the agency leader times out. In that case,
stale agency data can be reported in the .agency component (which our
debug scripts look at).

http://jenkins.arangodb.biz:8080/view/PR/job/arangodb-matrix-pr/11299/

Green test, pending review, this is good to go.


BUG: misspelled dealloc in cKDTree.

Fixes misspelling preventing destructor from being invoked.

Fix for #5630 in master
Backport candidate for 0.17.x

The fix looks good, how about a test. Is there a simple way to adapt the code from gh-5630 into a unit test?

Yes, resource is in the standard libary so this should be possible. There might be other parts of the system causing small leaks (I get a few of them unrelated to cKDTree), but at least the frequency should be much lower than one per cKDTree instance.

Added unit test

resource is Unix only on Python 2.6 so the unit test needs a tiny update.

Note that if we run the unit test against 0.16.0 this happens:
import numpy as np
from scipy.spatial import cKDTree
from numpy.testing import assert_

def test_ckdtree_memuse():
    # unit test adaptation of gh-5630
    try:
        import resource
    except ImportError:
        return
    # Make some data
    dx, dy = 0.05, 0.05
    y, x = np.mgrid[slice(1, 5 + dy, dy),
                    slice(1, 5 + dx, dx)]
    z = np.sin(x)**10 + np.cos(10 + y*x) * np.cos(x)
    z_copy = np.empty_like(z)
    z_copy[:] = z
    # Place FILLVAL in z_copy at random number of random locations
    FILLVAL = 99.
    mask = np.random.random_integers(0, z.size - 1, np.random.randint(50) + 5)
    z_copy.flat[mask] = FILLVAL
    igood = np.vstack(np.where(x != FILLVAL)).T
    ibad = np.vstack(np.where(x == FILLVAL)).T
    mem_use = resource.getrusage(resource.RUSAGE_SELF).ru_maxrss
    # burn-in
    for i in range(10):
        tree = cKDTree(igood)
        tree = None
    # count memleaks while constructing and querying cKDTree
    num_leaks = 0
    for i in range(100):
        mem_use = resource.getrusage(resource.RUSAGE_SELF).ru_maxrss
        tree = cKDTree(igood)
        dist, iquery = tree.query(ibad, k=4, p=2)
        tree = None
        new_mem_use = resource.getrusage(resource.RUSAGE_SELF).ru_maxrss
        if new_mem_use > mem_use:
            num_leaks += 1
    # ideally zero leaks, but errors might accidentally happen
    # outside cKDTree
    assert_(num_leaks < 10)

test_ckdtree_memuse()

sturla$ python test.py
Traceback (most recent call last):
  File "test.py", line 42, in <module>
    test_ckdtree_memuse()
  File "test.py", line 40, in test_ckdtree_memuse
    assert_(num_leaks < 10)
  File "/Users/sturla/anaconda/lib/python3.4/site-packages/numpy/testing/utils.py", line 53, in assert_
    raise AssertionError(smsg)
AssertionError

Which means it finds the problem if it is there.

Travis is still happy. Nothing more to do here.

Great, merged. Thanks Sturla!

@ev-br you want to do the backport before the final release?

@rgommers yes, will lump the backports together

backported in gh-5682


dependabot updates Mon Apr 30

Issue #, if available:
Description of changes:
Bump uuid from 1.3.1 to 1.3.2 in /tools/cp-utility #396
Bump ch.qos.logback:logback-classic from 1.4.6 to 1.4.7 #395
Bump com.amazonaws:aws-java-sdk-bom from 1.12.454 to 1.12.459 #394
Bump com.fasterxml.jackson:jackson-bom from 2.14.2 to 2.15.0 #393
Bump io.opentelemetry.contrib:opentelemetry-aws-xray from 1.24.0 to 1.25.1 #390
Bump com.diffplug.spotless from 6.11.0 to 6.18.0  #374
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Closing pull request as we usually don't do batch updates in this repository.


remove logrus logger and add zerolog Logger to flowkit backend config

in commit #a03e87a03 the emulator was updated without adding a way for thirdparties to set the logger.
This pr removes logrus and adds zerolog to the EmulatorGateway so that it is possible again.

It also looks like WithEmulatorLogger is not used anymore. It is the logger sent into the backend that is used for both logging meters and logging from emulator.

dammit what did I do to this pr now, i just merged in master, is this ok or should i clean it up?

i tried to update master but it just created a mess so I will leave it like it is.

@bjartek could you update changes from master so we can get this in.

@sideninja master merged. feel free to squash into main

@bjartek the tests fail, can you check what is the issue please.

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@388ea9c). Click here to learn what that means.
The diff coverage is n/a.

:exclamation: Current head eed67df differs from pull request most recent head 384232a. Consider uploading reports for the commit 384232a to get more accurate results

@@           Coverage Diff            @@
##             master    #891   +/-   ##
========================================
  Coverage          ?   2.53%
========================================
  Files             ?       5
  Lines             ?     434
  Branches          ?       0
========================================
  Hits              ?      11
  Misses            ?     422
  Partials          ?       1

Flag
Coverage Δ

unittests
2.53% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


go-links can no longer deploy to Heroku due to sqlalchemy dropping support to postgres:// URI

Deploying to Heroku today produces:

2021-03-28T10:39:46.332245+00:00 app[web.1]:     "Can't load plugin: %s:%s" % (self.group, name)
2021-03-28T10:39:46.332354+00:00 app[web.1]: sqlalchemy.exc.NoSuchModuleError: Can't load plugin: sqlalchemy.dialects:postgres

This is apparently caused by sqlalchemy 1.4.x dropping support for postgres:// URI (keeping only postgresql://):
https://github.com/sqlalchemy/sqlalchemy/issues/6083
https://help.heroku.com/ZKNTJQSK/why-is-sqlalchemy-1-4-x-not-connecting-to-heroku-postgres
Options to fix include:

pinning SQLAlchemy at 1.3.x (1.3.23)
implementing URI substitution from postgres:// to postgresql://

@isviridov thank you for flagging this and diagnosing! I'll implement URI substitution now.

@isviridov this is fixed with #101. I just verified deployment of a new app to Heroku works. Thanks again!

Thank you, i confirm it now works well w/Heroku!

Awesome, thank you for confirming, @isviridov!


Bundling font-roboto-local results in invalid url

When using font-roboto-local, styles containing url are not being bundled correct.
See it live here. My firebase looks misconfigured and return index.html for hose fonts requests, but in fact they are 404:
Failed to decode downloaded font: https://sandbox-e0d4b.firebaseapp.com/src/components/vendor/font-roboto/fonts/roboto/Roboto-Light.ttf
sandbox-e0d4b.firebaseapp.com/:1 OTS parsing error: invalid version tag

Steps to reproduce:

clone my sandbox
run npm i && bower i
run gulp build && npm start

You should then see rules like this:
@font-face{font-family:Roboto;src:url(../../vendor/font-roboto/fonts/roboto/Roboto-Thin.ttf) format("truetype");

Here, only 2 subfolders are present, while there should be 4.
Might be related to #462, but not sure.

#462 was a non-bug.  User was trying to use @import instead of style-modules https://www.polymer-project.org/1.0/docs/devguide/styling#style-modules
Will take a look


WIP Thumbnails & Preview Images

This PR adds a service that generates thumbnail and preview images automatically for visualizations.

@micahstubbs It may be interesting for you to have a look here!
The strategy is to generate 1 thumbnail every 10 second or so until they are all generated.

Current status: need to implement gateway for storing images in the database.

this is interesting.  I like the 10 sec delay strategy.  curious, what database do you store the images in?

Well, that's what I'll be implementing next. The rest of VizHub is already using MongoDB, with ShareDB (real-time layer) on top. I think the easiest way forward would be to store the images in the same way, using ShareDB.

good to see this one go in 👍

Super excited to see it land as well. This opens up so many more possibilities!


Favicon (Publication Icon)

The active favicon image is always detected not used
👇 Unused images that can be removed:

/var/www/site/content/images/2020/12/favicon.png (0.03 MB)
/var/www/site/content/images/2020/12/favicon_o.png (0.05 MB)

📊 Summary:

2 files of 17 uploaded images (11.76%)
Total space: 0.08MB

Thank you @rkafp
It's fixed on the new release 3.0.5


Cache AuthN and AuthZ requests

Which Issue(s) this Pull Request Fixes

Resolves #194
Release Note

NONE

Notes for Reviewers

@beerparty and @maruiz93 I introduced significant changes: now there are two expiration times, one for "positive" answers and one for "negative" answers to give more control to the user. Please take a look.

@maruiz93 @beerparty another more or less big change after today's meeting:

defaults are in the values.yml
environment variables are always populated
api fails if not set env variables not set or they fail to parse
introduced test


Expose language config constructor

Hello guys,
Great work with the package, its working like a charm!
One question/request: is it possible to access or expose the language config setting which is defaulted to "ro" at the moment:
this.config = { language: 'ro' };

I would like to customize the checkout experience for each client based on his preferred language.
All the best,
Dan

Hello Mihai,
Thank you so much, I appreciate your work to get this published!
I've just deployed it to production and its working as expected.
All the best,
Dan


Task 668: TLDR; summarizing paper abstracts

Based on : https://arxiv.org/pdf/2004.15011.pdf
Suggested in issue #222

@aarunku5, wondering if you can help review this tasks?

@swarooprm Looks good to me


After updating to v3.11.1 rewrite/redirects append a port to the URL

Description
The last change for internal redirecting appends a port to the URL. However in our setup at Railway.app this does a faulty redirect. When the middleware should rewrite / redirect, it takes a long time and eventually redirects to the correct URL but with the port number and that crashes.
Reverting to v3.11.0 works.
Verifications

[X] I've verified that the problem I'm experiencing isn't covered in the docs.
[X] I've searched for similar, existing issues on GitHub and Stack Overflow.
[X] I've compared my app to a working example to look for differences.

Mandatory reproduction URL
https://yeahgummy.webbers.dev/cart
Reproduction description
Steps to reproduce:

Open reproduction
Wait about a minute or so
See error: the page does not work and is redirected to https://yeahgummy.webbers.dev:3000/winkelwagen

Expected behaviour
A redirect to https://yeahgummy.webbers.dev/winkelwagen showing a page.

@pepijn-vanvlaanderen your suggestion of config to control what port is used may be the way to go, but it's also possible that the current logic is suboptimal. To troubleshoot further, what request headers are available to Next.js? Do you have values for any of the x-forwarded-* headers, e.g.

x-forwarded-host
x-forwarded-proto
x-forwarded-port

@pepijn-vanvlaanderen Sorry for the inconvenience caused by this change!
But yes, as @awkaiser-tr has pointed out, it would be important to get details about the specific request headers your app receives. Based on that, we can add a failing test like @awkaiser-tr did in https://github.com/amannn/next-intl/pull/979 and look into an appropriate fix.
I'd really like to avoid config as much as possible if we can, therefore the best option from my perspective would be to just do the right thing based on the information we have available.
Can you also share your domains config?
@awkaiser-tr Can you too share your domains config? Maybe we could also utilize a port that is potentially defined there for the detection.

My domains config looks like:
{
  defaultLocale: 'de-DE',
  domain: getDomain('de-DE').host,
  locales: ['de-DE'],
},
{
  defaultLocale: 'en-CA',
  domain: getDomain('en-CA').host,
  locales: ['en-CA', 'fr-CA'],
},
{
  defaultLocale: 'en-GB',
  domain: getDomain('en-GB').host,
  locales: ['en-GB'],
},
// ... and so on ...

... where host is the locale domain for current Next.js environment, e.g.

development @ de-yourcompany-dev.localhost
production @ www.yourcompany.de

@amannn are you suggesting an optional port property on the per-domain config?
Since most deployments will be reached via standard HTTP (80) / HTTPS (443) port, treating non-standard ports as outliers that require config makes sense and would probably result in fewer issues filed on this project.[^1]
However, if DomainConfig were to begin caring about port, it would also need to consider protocol:
{ // For sake of discussion ...
  defaultLocale: 'en-CA',
  domain: getDomain('en-CA').host, // `'www.yourcompany.ca'` || `'ca-yourcompany-dev.localhost'`
  locales: ['en-CA', 'fr-CA'],
  protocol: getDomain('en-CA').protocol, // `'https://'` || `'http://'`
  port: getDomain('en-CA').port, // `undefined` || `3000`
},

... where by default next-intl redirects use Next.js' request protocol and omit port, overridden by DomainConfig values first and proxy header values second.
[^1]: Do not many people test domain-based l10n during development on alternative ports like Next.js' default dev port 3000? 🤔

Yep, that's correct. We currently use the protocol and port of an incoming request to determine wether to add it to a domain that we're redirecting to.
I was wondering if the port could even be part of domain (e.g. domain: 'www.yourcompany.de:3000') to avoid introducing new properties, but I guess that would be somewhat of a stretch for the term "domain".
A separate property like you're suggesting might be the most explicit option and also gives users more flexibility (maybe one domain runs on a different port than another domain). I think this might be a reasonable path forward without having to rely on detecting a reverse proxy, which seemingly people have different configurations for.
What do you think?

Hi @amannn , hereby my domains config:
    localePrefix: 'as-needed',
    localeDetection: false,
    locales: ['nl'],
    defaultLocale: 'nl',
    pathnames: {
        ...,
        '/cart': {
            en: '/cart',
            nl: '/winkelwagen',
        },
        ...
    },
    domains: [
        {
            domain: `${process.env.DOMAIN_NL ?? 'localhost:3000'}`,
            defaultLocale: 'nl',
        },
    ],

As you can see, we currently only support 1 language as we are still waiting on translated content, but internally we use next-intl already to translate short texts.
@awkaiser-tr how does your getDomain look like? I was as well wondering for an easy ussage on local developing here.

Local development w/ locale-based domains
@pepijn-vanvlaanderen the getDomain function returns { host, origin, pathname, port, protocol } by locale, with values determined by environment. You just need to associate some locale-specific domains with your loopback address, e.g. /etc/hosts:
<IP_ADDRESS> ca-yourcompany-dev.localhost
<IP_ADDRESS> de-yourcompany-dev.localhost
<IP_ADDRESS> es-yourcompany-dev.localhost
<IP_ADDRESS> fr-yourcompany-dev.localhost
<IP_ADDRESS> it-yourcompany-dev.localhost
<IP_ADDRESS> pt-yourcompany-dev.localhost
<IP_ADDRESS> uk-yourcompany-dev.localhost
<IP_ADDRESS> us-yourcompany-dev.localhost
<IP_ADDRESS> yourcompany-dev.localhost

@amannn: I was wondering if the port could even be part of domain (e.g. domain: 'www.yourcompany.de:3000') to avoid introducing new properties, but I guess that would be somewhat of a stretch for the term "domain".

Agreed, that would be overloading domain in a surprising way. 🙅🏻

~A separate property like you're suggesting might be the most explicit option.~ EDIT: Seems like we've silently already supported this, so maybe this is the way to go and we should document it.
An explicit port in the domain config should also give users more flexibility, maybe one domain runs on a different port than another domain. I think this might be a reasonable path forward without having to rely on detecting a reverse proxy, which seemingly people have different configurations for.
What do you think?

Adding port to DomainConfig would be fine, so long as protocol (e.g. https://, http://) is also available. A secure or insecure web server can listen on any available port, and the protocol of an internal Next.js server could mismatch its public-facing reverse proxy, so we can't make assumptions about protocol with no way to override. Presumably this also means consideration of proxy-related headers would be removed? Leaving it up to the user, with sensible defaults in absence of DomainConfig values, does feel like the best choice. If they want to set config values based on incoming headers, they'd be free to do that.

Hi @amannn, after some testing I see now that the issue occurs on the pathname rewrite. So i.e. I have in pathnames this:
pathnames: {
    '/cart': : {
        de: '/cart',
        en: '/cart',
        fr: '/cart',
        it: '/cart',
        nl: '/winkelwagen',
    },
}

For all (custom) domains it will work, except for the nl (Dutch) variant. It will take some long time loading and end up at
https://yeahgummy-de.webbers.dev/cart -> https://yeahgummy-de.webbers.dev/cart
https://yeahgummy-fr.webbers.dev/cart -> https://yeahgummy-fr.webbers.dev/cart
https://yeahgummy-it.webbers.dev/cart -> https://yeahgummy-it.webbers.dev/cart
https://yeahgummy-nl.webbers.dev/cart -> https://yeahgummy-nl.webbers.dev:3000/winkelmand
When logging the x-forwarded-host and x-forwarded-port on Railway, I get these results:
xForwardedHost: yeahgummy-fr.webbers.dev
xForwardedPort: 3000

@amannn funny enough, I just experienced the same bug RE: localized pathname redirects 💣
@pepijn-vanvlaanderen quick sanity check: I see you're reporting x-forwarded-port as 3000, but was that just for the https://yeahgummy-nl.webbers.dev:3000/winkelmand request? What is the value of the x-forwarded-* headers for the /cart requests?

@awkaiser-tr for all the requests the port is set as 3000 and the domain I have set per locale as the host.

@awkaiser-tr for all the requests the port is set as 3000 and the domain I have set per locale as the host.

Same problem with us, when updating to 3.11.1

@pepijn-vanvlaanderen Are you saying that for a request to https://yeahgummy-nl.webbers.dev/cart, you're seeing x-forwarded-port: 3000? If so, that sounds like a bug of the reverse proxy to me, x-forwarded-port should contain the value of the port of the original request (443; standard https port).
See also:

Load Balancing with Port Preservation: In a load-balanced environment (NGINX) where the backend servers are listening on different ports, the X-Forwarded-Port header helps the load balancer preserve and convey the original client port information to the server. This information can be used by the server for various purposes, such as generating absolute URLs.

(source)
Can you verify this with Railway?
@awkaiser-tr Does this match your understanding too?
@TomasLukes Which hosting provider are you using? Can you also double check what the value of x-forwarded-port is when https://something.pl/complaints hits your middleware? The correct value should be 443.

Hi @amannn, thanks for your message. Actually I think the issue then is probably how I had setup the Dockerfile. There is a reverse proxy in front of the container and inside the container it then uses the mentioned port. Maybe Railway should superseed that from the proxy, but in the meantime I was just able to expose port 443 in the dockerfile instead of 3000 and it works now, thanks!

@amannn: Does this match your understanding too?

Yup.

@pepijn-vanvlaanderen when you say "it works now" do you mean that, in addition to your other routes, the https://yeahgummy-nl.webbers.dev/cart localized pathname redirect also now leads to https://yeahgummy-nl.webbers.dev/winkelmand as expected?
This GitHub Issue has been confused since details have changed over time:

~Undesired port always added to redirects~
Specifically, localized pathname redirects include undesired port

@TomasLukes Which hosting provider are you using? Can you also double check what the value of x-forwarded-port is when https://something.pl/complaints hits your middleware? The correct value should be 443.

Thanks for quick help!👌 "x-forwarded-port" value in middleware is 3000 now. Should I do something like this?
const modifiedReq = req.headers.set("x-forwarded-port", "443");
It looks like its behaving correctly after that 🤔

@TomasLukes just as Pepijn did, I'd recommend digging deeper and determining why the x-forwarded-port header is being set to 3000 and correcting that before the request reaches Next.js

@awkaiser-tr yes the redirect also leads to localized pathnames correctly. The undesired port issue originated from a bad config.
I exposed port number 3000 in the production environment before, and thats why it redirected to the domain with port addition after reading x-forwarded-port . So in the end I set the port in Railway to 443, which resulted in a proper config and working redirects. Thanks for the help!

I run my next application in docker and in the docker container it runs on 3000, but it is exposed to port 8000 on my host. On redirect from / to /de, the port 8000 is changed to 3000. I this expected for my scenario? After all docker just redirects the tcp traffic and is not an HTTP proxy that sets the x-forwared-for ports.

same issue on latest and multi-domain setup :( and i can't seem to fix it as well by downgrading to 3.10, my site now always redirects to :4001 when no /locale is given, very bad

right. I can confirm that emptying the x-forwarded-port solves the issue. though it feels quite hacky.


DType support

init_param is changed to support DType.

get_random currently will fail under current resource manager. Need to modify the resource manager in order to support this. So let us remove random support for now and make it a separate PR


ci: disable semver checks

This resolves #2470.
Changes

Allow the CI semver workflow to be triggered manually

This provides the option of trying again later

Do not trigger the CI semver on push

Notes

The blame for the errors seem to be external to the leptos code. Something changed around 03/24/2024 that now causes even previously passing commits to fail.

@benwis This is ready for review.

👋 Hey, I'm the cargo-semver-checks maintainer, and I'm looking into this as well. Of course feel free to merge this PR to get things unblocked while I look, I just want to get to the bottom of this one way or the other.

Excellent.
Thank you.
On Sat, Mar 30, 2024, 12:43 PM Predrag Gruevski @.***>
wrote:

👋 Hey, I'm the cargo-semver-checks maintainer, and I'm looking into this
as well. Of course feel free to merge this PR to get things unblocked while
I look, I just want to get to the bottom of this one way or the other.
—
Reply to this email directly, view it on GitHub
https://github.com/leptos-rs/leptos/pull/2471#issuecomment-2028252857,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABWF4QMLDIUQNI7FKYUKP6DY23TRXAVCNFSM6AAAAABFPUSXKOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMRYGI2TEOBVG4
.
You are receiving this because you authored the thread.Message ID:
@.***>

Found the problem. It's not related to cargo-semver-checks but to an interaction between axum and the nightly Rust version used here.
To fix it, either downgrade axum or upgrade to a newer nightly Rust.
Here's what's going on:

axum is doing nightly detection in its build.rs script, and enables a cfg attribute if so: https://github.com/tokio-rs/axum/blob/dbd61783935e7f33d2f7dbb2fbe391441b8c9790/axum/build.rs#L1-L4
That cfg is used to enable nightly features, like here: https://github.com/tokio-rs/axum/blob/axum-v0.7.5/axum/src/handler/mod.rs#L128-L133
That nightly feature was added more recently than in the 1.77-nightly the CI here uses. This is why rustdoc fails in cargo-semver-checks — it doesn't recognize the syntax.

I was stumped because I couldn't reproduce this problem on my own machine. But turns out I'm running 1.79-nightly which is  new enough to have the feature in question.

I recommend merging this PR now and tackling a nightly upgrade later.


Warn on early returns from a component

Describe the need
As mentioned in this thread, it's surprising at first glance to many devs coming from React that conditional early returns in components don't work as expected. An example:
import { render } from "solid-js/web";
import { createSignal } from "solid-js";

function Counter() {
  const [count, setCount] = createSignal(0);

  setInterval(() => setCount(count() + 1), 1000);

  if (count() > 2) return
Larger than 2
;

  return
Count: {count()}
;
}

render(() => <Counter />, document.getElementById("app")!);

Because a component only runs once, this component will only ever render Larger than 2. The correct solution is to move the condition into a reactive JSX context. solid/reactivity already catches if (count() > 2), but doesn't give specific feedback and doesn't handle cases where the condition is not reactive.
Suggested Solution
There should be a new lint rule, solid/components-return-once, that enforces that any function that returns JSX at any point should have only one return statement that is the last statement of the function body. Anything else is an early return in a component. Also, the return value cannot be a ternary or other conditional expression; these are only reactive inside JSX like a fragment.
Fixes could be provided in certain cases:

An early return directly before the final return could be transformed into a Show fallback.
A returned ternary could be transformed into a ternary inside a JSX fragment or into a Show. Since it's not clear which is the fallback and which is the children, the first option could be better.

Possible Alternatives
People are confused and are asking for a lint rule directly, and a lint rule is the best fit for this kind of warning, so there's not really a workaround.

Added in v0.6.0.


Segfault caused by inserting adjascent text nodes

The following reliably causes segfaults for me on both Julia v1.4.1 and Julia master:
using EzXML

for _ in 1:2
    doc = XMLDocument()
    root = ElementNode("root")
    setroot!(doc, root)

    t1 = TextNode("#1")
    link!(root, t1)

    t2 = TextNode("#2")
    linkprev!(t1, t2)
end

The crash occurs in the second linkprev!(t1, t2) call, and the loop is only required to reliably generate the crash. (Without it, typing each line interactively would crash, but sometimes running as a script would be fine.)
I'm inferring that this is a bad interaction between the finalizer and the fact that adjascent text nodes are combined, with the latter new node being freed: http://www.xmlsoft.org/html/libxml-tree.html#xmlAddPrevSibling (or via the actual implementation, https://github.com/GNOME/libxml2/blob/20c60886e42c942e6c45a3a99d583e4d3269a1c1/tree.c#L3075).

More details:
(myproject) pkg> st
Status `~/myproject/Project.toml`
  [8f5d6c58] EzXML v1.1.0
  [0f8b85d8] JSON3 v1.0.2

(myproject) pkg> versioninfo()
ERROR: Could not determine command

julia> versioninfo()
Julia Version 1.5.0-DEV.652
Commit 8d8f46db37* (2020-04-20 18:34 UTC)
DEBUG build
Platform Info:
  OS: Linux (x86_64-pc-linux-gnu)
  CPU: AMD Ryzen 3 2200G with Radeon Vega Graphics
  WORD_SIZE: 64
  LIBM: libopenlibm
  LLVM: libLLVM-9.0.1 (ORCJIT, znver1)

Hello,
It seems I have a similar issue, as seen in this MWE:
using EzXML

document = parsehtml("""
This is a text.
""").root
text = findfirst("//p", document)
parent_node = ElementNode("text")
for child_node ∈ nodes(text)
    # if istext(child_node)
    #     link!(parent_node, TextNode(child_node.content))  # Crashes.
    # end
    # link!(parent_node, TextNode("test"))  # Crashes too.
end
link!(parent_node, TextNode("test"))  # Does not crash.


calib3d and cudastereo: couple of small improvements

This PR aims to address couple of minor annoyances that I encountered in calib3d/cudastereo modules while working with OpenCV's stereo functionality.
In particular, there are appears to be inconsistency among stereo methods when returning 16-bit signed disparity; CPU methods from calib3d (BM and SGBM) use fractional bits for extra precision, while the GPU methods from cudastereo do not. Similarly, when passing the 16-bit signed disparity to cv::reprojectImageTo3D() and cv::cuda::reprojectImageTo3D(), as well as to cv::cuda::drawColorDisp(), it is assumed that the values have no fractional bits.
So the only way to actually use the extra precision from CPU methods' 16-bit disparity values is to convert them to floating point values, and operate on them. However, the CUDA methods - cv::cuda::reprojectImageTo3D() and cv::cuda::drawColorDisp() do not appear to support 32-bit float format at the moment.
So this PR:
a) adds support for 32-bit float and 32-bit signed int format to cv::cuda::reprojectImageTo3D() and cv::cuda::drawColorDisp()
b) explicitly documents the lack of fractional bits for 16-bit signed disparity wherever applicable

@jet47, @ilya-lavrenov, could you please take a look?

:+1:


documentation

The Methods tables in every implementation are the same. Should we update them to comply with each implementation's source code, or is it more of a "pseudo code" to showcase the functionality of Sessionless? Nonetheless the tables should start and end with | symbol due to compatibility reasons (at least that's what my IDE told me lol).

Added the pipe. And yeah the methods tables sort of a pseudocode placeholder. I could give you a justification for that, but it's really I didn't feel like going into all of the implementations and updating them here, but now that you've brought it up it seems reasonable to have a note about that.


Remove all pycache dirs & pyc files

Why do you want to do this? I think it is more useful to have precompiled .pyc in the image rather than python having to do the compilation each time when running the container and thus modifying it?

Why do you want to do this? I think it is more useful to have precompiled .pyc in the image rather than python having to do the compilation each time when running the container and thus modifying it?

I would like the images to be smaller so that the start times are faster. It doesn't take very long to create the bytefiles and it seems to be best practice, at least for Debian packages, to deliver them without pyc/pycache.

with-pyclean                                              latest            331b6916161f   48 seconds ago   546MB
without-pyclean                                           latest            2d24292566c0   5 minutes ago    626MB

Without pyclean (@Quay): 196.8 MiB (extracted 570MB)
With pyclean (@Quay): 168.2 MiB (extracted 487MB)


[UNDERTOW-1554] Improve handling and leniency of bad POST parameters

Issue: https://issues.jboss.org/browse/UNDERTOW-1554
Improve handling and leniency of bad POST parameters - Ignore incorrect parameters or values (ones that contain % without any hexadecimal number) in data query.
Example query with result:
$ curl -d "test1=%&test2=foo" http://<IP_ADDRESS>:8080/helloworld/HelloWorld
test2=foo
Example log:
13:38:04,820 ERROR [io.undertow.request] (default task-1) UT000193: Character decoding failed. Parameter [test1] with value [%] has been ignored. Note: further occurrences of Parameter errors will be logged at DEBUG level.

Can one of the admins verify this patch?

This is ok to test


Some files trigger a bug in processing local color table size in image descriptor blocks

When processing some files (see attached example), the following error is seen:
undefined method `local_color_table_size' for #<#<Class:0x000000075ddd18>:0x000000075dd908>

I've created a test for this, see pull request #3


[i18n] Add internationalization structure

This is a simple extension, but it could be nice if the messages were displayed in the user's browser language.
As part of this ticket:

Create the skeleton for internationalization
Add English as the default (and so far unique language)

Currently, the Chrome extension only has 3 things that would need translation:

The message: "No specified payment methods."
The message: "This creator accepts payments in..."

We will not internationalize company names or console messages at the moment. If there's any missing string that may need translation, leave a comment on this ticket.

Hi @alvaromontoro I would love to contribute to PayCreators extension, please assign this issue to me. I have primarily been a python backend and android dev, but I would love to get my hands on JS based chrome extensions.

@SaranshBaniyal I assigned the task to you :)
Let me know if you need any clarification.

Thanks, can you point me out in a direction to look or reference, for internationlization implementation, logic as well as UI

@SaranshBaniyal To create the internationalization you will need to:

Create the _locales folder with the languages subfolders (in this case, only en)

Create a messages.json file in the language subfolder with the structure:
 {
   "noPayment": {
     "message": "No specified payment methods.",
     "description": "Default message if the page does not have PayCreator metadata"
   },
   "acceptsPayments": {
     "message": "This creator accepts payments in...",
     "description": "Heading when PayCreator metadata is displayed"
   }
 }

You can use the __MSG_[KEYNAME]__ notation or use chrome.i18n.getMessage([KEYNAME]); to read the locale values and set them where appropriately.

@alvaromontoro sorry but I'm afraid I won't be able to continue with this for a while, due to some personal reasons, I won't be available, hence I am unassigning myself. Sorry for the inconvenience.


nvim hangs raspberry pi 3A+ system when running with init.lua in ~/.config/nvim

Describe the bug

When running nvim with init.lua script in ~/.config/nvim/ the nvim editor downloads all the plugins but then hangs on step 0 or step 1 of 12 when trying to compile nvm-treesitter.
If I run the top command in one terminal and then run nvim in another I can see a large number of cc process kicked off before everything stops working. This behavior appears identical to a "make -j" fork bomb but I haven't yet figured out how to force the plugins compilation step to only compile things in serial.
The pi 3A+ is a heavily constrained device.
This is part of an astrophotography project I've started and these are the devices slated for use with it. The only issues we have run into with them is when compilation steps insist on doing some variation of force parallelism. The arm7a CPU does have four cores but it also only has 512MB of memory.
Neovim, itself, had to be carefully compiled to force the make system to only compile serially; once that was accomplished everything worked fine.
To Reproduce

Place a copy of kickstart.nvim init.lua into ~/.config/nvim
run nvim from console

Desktop

OS: debian 11.8 in console mode only; no desktop environment.
Terminal: bash

Neovim Version

NVIM v0.10.0-dev-2221+g47cd532bf
Build type: Release
LuaJIT 2.1.1706185428

OK. So you're saying neovim launches cleanly with no hangs if you move kickstart.nvim away?
Please note there's more to installing than just copy/pasting init.lua into place. See the README.
Also, it's very likely that the problem you have is with one of our bundled plugins, although I know I've run Neovim on pi before with no issue, and others have as well.
Even if we can isolate the problem, you should file an issue with whichever plugin is malfunctioning.

Yes.
By renaming init.lua to init.lua.moved, so that it will be ignored on startup, nvim loads and runs without issue.
In fact, even without renaming the file nvim runs fine. But once it starts trying to compile the plugins init.lua is trying to install it hangs with many, many cc processes being executed.

OK.
Honestly, I'm not sure what we can do about this. You're trying to run a very large, complex, multi-layered program on a system that you yourself have said is very constrained.
Have you considered sticking with Vim?
The only alternative is debugging each plugin, turning them off one by one until you find the culprit.
In any case, I'm sorry but this is outside the purview of this project. Good luck and thanks for checking in!

Well, through many reboots and forcing process limits via ulimit -u N where N was some random and varying number between 10 and 30 I eventually got everything to install.
The only plugin causing an issue turned out to be nvm-treesitter.
I'm too new to lua and neovim plugin installations but from what I can tell the installer was firing off tons of processes for each and every parser nvm-treesitter was trying to install for.
If I understood this installation procedure better I'm guessing the less sledgehammer way through this would be somehow limiting the parser installations to one parser at a time until each of the desired parsers were installed. I'm sure it's an easy thing to do but I just don't know enough on how to do that just yet.
Thanks for the moral support.

@thumdugger I would suggest that the right place for this issue is the nvim-treesitter project itself:
https://github.com/nvim-treesitter/nvim-treesitter


Minimizing memory usage

I'd like to keep the memory usage of my informer low. I'm introducing it to an existing app with low memory usage (<100MB) and I know (based on another app) that, the memory usage will become significantly larger. This is what I've come up with and I'd like to request comment:

I don't need the whole object. I just need the namespace and name (i.e. key).
I can filter most of the objects out based by looking at their contents.

I implemented a version of cache.KeyListerGetter that only stores the key:
// this struct is designed to store a compact cache of meta namespace keys (i.e. "namespace/name") created by an
// informer than can be iterated safely and efficiently
type store struct {
	lock sync.RWMutex
	keys map[string]bool
}

var _ cache.KeyListerGetter = &store{}

func newStore() *store {
	return &store{sync.RWMutex{}, make(map[string]bool)}
}

func (k *store) GetByKey(key string) (interface{}, bool, error) {
	k.lock.RLock()
	defer k.lock.RUnlock()
	_, exists := k.keys[key]
	return cache.ExplicitKey(key), exists, nil
}

func (k *store) Add(obj interface{}) {
	k.lock.Lock()
	defer k.lock.Unlock()
	key, err := cache.MetaNamespaceKeyFunc(obj)
	if err == nil { // error should never happen
		k.keys[key] = true
	}
}

func (k *store) Delete(obj interface{}) {
	k.lock.Lock()
	defer k.lock.Unlock()
	key, err := cache.DeletionHandlingMetaNamespaceKeyFunc(obj)
	if err == nil { // error should never happen
		delete(k.keys, key)
	}
}

func (k *store) ListKeys() []string {
	k.lock.RLock()
	defer k.lock.RUnlock()
	var keys []string
	for key := range k.keys {
		keys = append(keys, key)
	}
	return keys
}

And a new factory that only uses that store and combines it with a filterFunc to further reduce the memory usage:
func NewFilterUsingKeyController(restClient rest.Interface, namespace string, req labels.Selector, resource string, objectType runtime.Object, filterFunc func(d cache.Delta) bool) (cache.Controller, cache.KeyLister) {
	knownObjects := newStore()
	return cache.New(&cache.Config{
		Queue: cache.NewDeltaFIFO(cache.MetaNamespaceKeyFunc, knownObjects),
		ListerWatcher: &cache.ListWatch{
			ListFunc: func(options metav1.ListOptions) (runtime.Object, error) {
				options.LabelSelector = req.String()
				return restClient.Get().
					Namespace(namespace).
					Resource(resource).
					VersionedParams(&options, metav1.ParameterCodec).
					Do().
					Get()
			},
			WatchFunc: func(options metav1.ListOptions) (watch.Interface, error) {
				options.LabelSelector = req.String()
				options.Watch = true
				return restClient.Get().
					Namespace(namespace).
					Resource(resource).
					VersionedParams(&options, metav1.ParameterCodec).
					Watch()
			},
		},
		ObjectType: objectType,
		// note - we never re-sync
		Process: func(obj interface{}) error {
			for _, d := range obj.(cache.Deltas) {
				switch d.Type {
				case cache.Added, cache.Updated:
					if filterFunc(d) {
						knownObjects.Add(d.Object)
					} else {
						knownObjects.Delete(d.Object)
					}
				case cache.Deleted:
					knownObjects.Delete(d.Object)
				}
			}
			return nil
		},
	}), knownObjects
}

Is there an easier way to achieve my goals?

SIG API meeting indicated that metadata informer (k8s.io/client-go/metadata/metadatainformer)

That is good enough I think.

@DirectXMan12 might want to look and see if this would help controller-runtime / kubebuilder users, though.

We've got a parallel implementation going on due to not quite using the same factories to set up our informers, but yeah, that looks about right (tracking issue is https://github.com/kubernetes-sigs/controller-runtime/issues/1159)

Footnote: my suggestion will use less data than the meta-data only example. If a there is a lot of meta-data (and there can be) it maybe usefule.

@alexec - have you implemented your approach? For Kyverno, we are looking for a way to cache data for specific objects instead of all instances of a type, and I was looking into extending what you proposed for that.

@JimBugwadia I did not end up using this, I would have used the meta-data informer. It is not hard to write this yourself, but I'm not sure what happened to my code.

If I remember correctly, you need to implement some interfaced to write your own. One challenge was that if you only cache some data, updates were hard to do, because you could not tell what was any update and what was a resync.

Ok, thanks @alexec!


Non-expandable ActionBar should not have focus

Description of the bug
When an ActionBar is not expandable and has no onClick function it should not be focusable as a button.
The actions, however, should be (as they are today).
Steps To Reproduce

Go to Choose Org page
Use tab to navigate the page
Observe that the ActionBar gets focus even if it is unclickable

Additional Information
No response

Sjekket, ser ok ut. Satt til test


Documentation of routes order confusing

The order of routes adding do matter. The URL which is added earlier and matches wins.
...
Have in mind that the order of the added routes using this method does not matter anymore. However, if we add series of routes by calling on multiple times we should consider the order of the calls.

I think route depth significance should also be documented.

Good spot. The README is changed.


Package Restore unable to download and install proper NUnit 3

Following steps described
https://docs.microsoft.com/en-us/nuget/Consume-Packages/Package-restore-troubleshooting
Attempting to build
https://github.com/Microsoft/GVFS
Have installed the Framework 3.5, C++/cli , C++ toolset and Windows SDK pre-requisites.
Opened solution and attempted to build, output 8 errors similar to the following, all complaining about the version of NUnit 3.10 not installed on system (see following error).
Severity	Code	Description	Project	File	Line	Suppression State Error		This project references NuGet package(s) that are missing on this computer. Use NuGet Package Restore to download them.  For more information, see http://go.microsoft.com/fwlink/?LinkID=322105. The missing file is ..\..\..\packages\NUnit.3.10.0-dev-05190\build\NUnit.props.	GVFS.Tests	C:\Repos\GVFS\src\GVFS\GVFS\GVFS.Tests\GVFS.Tests.csproj	73
Have verified that the following setting described in the link at the top of this post is set correctly

In Visual Studio, enable package restore by selecting the Tools > NuGet Package Manager > Package Manager Settings menu command, setting both options under Package Restore, and selecting OK. Then build the solution again.

Have also installed the NUnit 3.0 Adapter and Templates using Nuget Manager.
No Joy.

Additional.
Attempted to install from NUnitLite package using Nuget Package Manager >
Error says not available
Severity	Code	Description	Project	File	Line	Suppression State Error		NuGet Package restore failed for project GVFS Tests\GVFS.FunctionalTests: Unable to find version '3.10.0-dev-05190' of package 'NUnit'.   https://api.nuget.org/v3/index.json: Package 'NUnit.3.10.0-dev-05190' is not found on source 'https://api.nuget.org/v3/index.json'.   https://www.myget.org/F/nunit/api/v3/index.json: Package 'NUnit.3.10.0-dev-05190' is not found on source 'https://www.myget.org/F/nunit/api/v3/index.json'. . Please see Error List window for detailed warnings and errors.

Have you worked with folks in the GFVS project to determine the issue?
That might be a good first step?
If you do need to engage the nuget team, https://github.com/nuget/home/issues/
is the right place.

If a project specifies a package that isn't published to one of their sources, they need to fix it...

No, are you saying that they should update their source to support a later
Nunit rather instead of you providing the required Nunit version?
Right now, am looking at possibly obtaining the proper Nunit version
without using the Nuget feed.
On Wed, Jun 27, 2018 at 12:44 PM, Rob Relyea<EMAIL_ADDRESS>wrote:

Have you worked with folks in the GFVS project to determine the issue?
That might be a good first step?
If you do need to engage the nuget team, https://github.com/nuget/home/
issues/
is the right place.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/NuGet/docs.microsoft.com-nuget/issues/950#issuecomment-400805856,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABrA44Ig6BwC9aZqia6IyT_9OO4Z-SmJks5uA-CVgaJpZM4U6PvO
.

OK, I'll have them fix their source
On Wed, Jun 27, 2018 at 12:48 PM, Tony Su<EMAIL_ADDRESS>wrote:

No, are you saying that they should update their source to support a later
Nunit rather instead of you providing the required Nunit version?
Right now, am looking at possibly obtaining the proper Nunit version
without using the Nuget feed.
On Wed, Jun 27, 2018 at 12:44 PM, Rob Relyea<EMAIL_ADDRESS>wrote:

Have you worked with folks in the GFVS project to determine the issue?
That might be a good first step?
If you do need to engage the nuget team, https://github.com/nuget/home/
issues/
is the right place.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/NuGet/docs.microsoft.com-nuget/issues/950#issuecomment-400805856,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABrA44Ig6BwC9aZqia6IyT_9OO4Z-SmJks5uA-CVgaJpZM4U6PvO
.


configure default PolymorphicTypeValidator in jackson 11

This is an extra security precaution to block deserialization of classes that specify weakly typed or known vulnerable types.
This will guard against cases where the @JsonTypeInfo annotation is used with JsonTypeInfo.Id.CLASS or when polymorphic types are enabled by an user on the default mapper, used by vert.x, internally and through the Serializer utility. (polymorphic deserialization is disabled by default and not recommended to be enabled.)
Use of Object.class is still allowed without the annotation and without enabling polymorphic types, in this case jackson chooses the implementation class (map, list or basic type) - this is not a security vulnerability and this behavior has not been changed.
See https://github.com/FasterXML/jackson-databind/issues/2587 for list of classes that are blocked.

Fixed in 4a4ddb005db5b2015300c194ee2c85c107166af8


Consolidate manual flags

Consolidate the manual flags. I.e., the flags for bottles we know are not a WOCE 2. These should live in a single csv that can be referenced once and filtered from with a header.

[ ] Manual temperature flags (don't presently exist)
[ ] Salinity flags (outputting to /tools?)
[ ] Oxygen flags (few examples)
[ ] Bottle flags don't exist in CTDCAL as is - should mark mistrips. None of the data get flagged, but skip using this data point for getting fit coefficients

Discussed today. An issue we've routinely run into was that the manual salinity and oxygen reference flags were not being read in correctly. Not creating a duplicate issue, since it would be resolved by this (and our timeframes are the same).

Resolved in PR #106


Introduce detailed CMS changelog information

Description

Rename existing github workflow to correct naming error

Introduce scripts/update_changelog.sh

Record CMS changes in a structured format capturing:
-- Author
-- Environment
-- Content Type
-- Updated At
-- Fields Changes

Example CONTENTFUL_CHANGELOG.md Entry

Type of change
Please delete options that are not relevant.

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[X] Technical Enhancements

DEPLOY_URL=https://d5p2rab60njsr.cloudfront.net/
cloudfront_id=E1Q7C2DEHRAOHO

DEPLOY_URL=https://d5p2rab60njsr.cloudfront.net/
cloudfront_id=E1Q7C2DEHRAOHO

DEPLOY_URL=https://d5p2rab60njsr.cloudfront.net/
cloudfront_id=E1Q7C2DEHRAOHO

DEPLOY_URL=https://d5p2rab60njsr.cloudfront.net/
cloudfront_id=E1Q7C2DEHRAOHO


Update customer-key-manage.md

If OneDrive for Business branding needs to be updated, let's do that on a separate pass for all the encryption content.


C-x C-e does not work with guile

I am able to compile the buffer , but evaluating a sexp behind point causes guile to enter debug mode with a no such language error.
I am on emacs 25.0.5 guile 2.1.1 and latest geiser from Melpa.
Here is the exact error message:
ERROR: In procedure scm-error:
ERROR: no such language objcode
       0 (scm-error misc-error #f "~A ~S" ("no such language" objcode) #f)

I meant Melpa of course.

I saw this was already reported in #112

This is a duplicate of #112

Yep.


Add Storybook Storysource Addon

Adds this plugin: https://storybook.js.org/addons/@storybook/addon-storysource
Fixes: #557
I don't know if the code it displays is helpful / correct - and if it isn't correct then I don't know how to fix.

This doesn't look right - missing syntax highlighting and output looks different compared to the example screenshots at https://storybook.js.org/addons/@storybook/addon-storysource:

I'll close this for now and maybe revisit again sometime in the future.


New command: spfx project github workflow add

Usage
m365 spfx project github workflow add [options]
Description
Adds a GitHub workflow for a SharePoint Framework project.
Options

Option
Description

-n, --name [name]
Name of the workflow that will be created. If none is specified a default name will be used 'Deploy Solution ${name of sppkg file}'

-b, --branchName [branchName]
Specify the branch name which should trigger the workflow on push. If none is specified a default will be used which is 'main'

-m, --manuallyTrigger
When specified a manual trigger option will be added to the workflow: workflow_dispatch

-l, --loginMethod [loginMethod]
Specify the login method used for the login action. Possible options are: user, application. Default user

-s, --scope [scope]
cope of the app catalog: tenant, sitecollection. Default is tenant

--siteUrl [siteUrl]
The URL of the site collection where the solution package will be added. Required if scope is set to sitecollection

--skipFeatureDeployment
When specified and the app supports tenant-wide deployment, deploy it to the whole tenant.

overwrite
set to overwrite the existing package file.

Examples
Adds a GitHub workflow for a SharePoint Framework project with user login method triggered on push to main
m365 spfx project github workflow add

Adds a GitHub workflow for a SharePoint Framework project with application login method triggered on push to main and when manually triggered.
m365 spfx project github workflow add --manuallyTrigger --loginMethod "application"

Adds a GitHub workflow for a SharePoint Framework project with deployment to a site collection app catalog
m365 spfx project github workflow add --scope "sitecollection" --siteUrl "https://some.sharepoint.com/sites/someSite"

Default properties
none
Additional Info
Remarks
When loginMethod option is used with user value then the CLI for Microsoft 365 login action will be created with ADMIN_USERNAME and ADMIN_PASSWORD. If the application value will be used then the action will created with CERTIFICATE_ENCODED, CERTIFICATE_PASSWORD, APP_ID.
Example workflow
This is an example workflow that should be generated.
name: Deploy Solution # {{SOLUTION_NAME}} # default title of flow with possibility to change it with an option in the command

on:
  push:
    branches:
      - main # optionally specify name of the branch which should trigger the flow by specifying an option in the command. by default it is main
  workflow_dispatch: # specify that the flow can be triggered manually by specifying a flag in the command

jobs:
  build-and-deploy:
    runs-on: ubuntu-latest

    steps:

    - name: Checkout
      uses<EMAIL_ADDRESS>
    - name: Use Node.js 16.x
      uses<EMAIL_ADDRESS>      with:
        node-version: 16.x

    - name: Run npm ci
      run: npm ci

    - name: Bundle & Package
      run: |
        gulp bundle --ship
        gulp package-solution --ship

    - name: CLI for Microsoft 365 Login
      uses<EMAIL_ADDRESS>      with:
        ADMIN_USERNAME:  ${{ secrets.ADMIN_USERNAME }} # this may will be used when `user` method is specified
        ADMIN_PASSWORD:  ${{ secrets.ADMIN_PASSWORD }} # this may will be used when `user` method is specified
        #CERTIFICATE_ENCODED: ${{ secrets.CERTIFICATE_ENCODED }} # this may will be used when `application` method is specified
        #CERTIFICATE_PASSWORD: # this may will be used when `application` method is specified
        #APP_ID: ${{ secrets.APP_ID }} # this may will be used when `application` method is specified

    - name: CLI for Microsoft 365 Deploy App
      uses<EMAIL_ADDRESS>      with:
        APP_FILE_PATH: sharepoint/solution/{{ solutionName }}.sppkg # should be automatically populated based on the project
        #SCOPE: # Scope of the app catalog: tenant or sitecollection. Default is tenant by specifying an option in the command
        #SITE_COLLECTION_URL: # The URL of the site collection where the solution package will be added. Required if scope is set to sitecollection by specifying an option in the command
        SKIP_FEATURE_DEPLOYMENT: false # If the app supports tenant-wide deployment, deploy it to the whole tenant by specifying an option in the command. Default is false
        OVERWRITE: true # Set to overwrite the existing package file by specifying an option in the command. Default is false
...

Implementation idea
How I would go about it is maybe keep a .yml file as part of the project in the command folder and just adjust it based on the options passed. We could have some markers inside the template .yml file and just use plain replace based on what was specified
Some other ideas
👉 I wasn't sure if it will be useful but CLI for Microsoft 365 actions also support specifying a CLI version that will be used and we may specify  latest, next or a specific version tag.
👉 Also not sure if giving the possibility to specify a specific node version that will be used might be helpful. The latest version of SPFx supports v16.x but maybe someone would like to create a workflow for an older version of SPFx 🤔
👉 Another idea for an option would be if the bundle and package should be with --ship o not. Maybe someone would like a workflow that deploys a SPFx app for debugging

@pnp/cli-for-microsoft-365-maintainers what do you think?

Great idea! Few considerations:

I suggest that we use application login as default. It's safer than a user and doesn't require the organization to keep around an admin-level account without MFA
I suggest we start simple and leave the Node and CLI versions out. We can always add them later if need be
I like the idea of having a template for the yml file and replacing markers. Alternatively, we could look into defining the template in an object and see if there's a package capable of turning a JS object into yaml which would be less error prone

I suggest that we use application login as default. It's safer than a user and doesn't require the organization to keep around an admin-level account without MFA

I agree, will update the spec

I suggest we start simple and leave the Node and CLI versions out. We can always add them later if need be

I thought exactly the same, that's why it is not in the spec but as a suggestion. Ok for now let's leave it

I like the idea of having a template for the yml file and replacing markers. Alternatively, we could look into defining the template in an object and see if there's a package capable of turning a JS object into yaml which would be less error prone

Awesome idea. Will do some research in that area.
@waldekmastykarz thanks for the feedback 👍

Ok, @waldekmastykarz I updated the spec.
@pnp/cli-for-microsoft-365-maintainers any other comments?

@waldekmastykarz this looks promising js-yaml
https://github.com/nodeca/js-yaml#readme
Allows to convert both ways from object to yaml and the other way around. Which might be helpful if we want to update the workflow template in the future. We could keep the object JSON as the workflow template.
The package is:
-Used by couple of million users
-has some opened issues and PRs
-has 800 forks
-it has 60 m weekly downloads https://www.npmjs.com/package/js-yaml
-last time it was published 2 years ago 🤔
What do you think? We could at least try with this and check if it will work. We also should double check for security issues.
@pnp/cli-for-microsoft-365-maintainers any alternative suggestions?

Lack of activity on the repo is concerning. I suggest that we look for alternatives.

Spec looks good. One detail we miss is the name of the file to create on disk and what the command will do in case of a collision.

Ok will research something more

Spec looks good. One detail we miss is the name of the file to create on disk and what the command will do in case of a collision.

Those are good questions. Usually when I was working with pipelines the filename a bit described what was going to happen. Like 'release_main.yml' means that it will release the product from main branch.
In this case maybe we could just name it deploy.yml. what do you think? In case of collisions I would show an error message. We could also think of adding the --force to overwrite the file in case one already exists.
What do you think?

So @Adam-it, so this command will generate a yml file for you in the directory where you are running it, so you can commit it to the repo and make GH run it. Is that the idea?

So @Adam-it, so this command will generate a yml file for you in the directory where you are running it, so you can commit it to the repo and make GH run it. Is that the idea?

I would suggest that the command should run within a SPFx project directory, similar to other spfx commands.
The aim would be to generate the  deploy.yml file in the project root directory, so the same folder where package.json is present. The workflow should be created in \.github\workflows subdirectories, as this is the default way GitHub handles (looks for) workflow files. I think that if those folders are not present the command needs to create them along the way.

@martinlingstuyl, @waldekmastykarz
I updated the spec with answers to your questions:

filename,
what should be done in case of collision
.yml file location

Lack of activity on the repo is concerning. I suggest that we look for alternatives.

ok second option I would recommend (I think even better then the first one) is yaml
https://www.npmjs.com/package/yaml
https://github.com/eemeli/yaml

951 stars
actively maintained. Last commit is from 26 May
used by millions
npm package has millions of downloads

what do you think?

Ok, great, can we change the description a bit to make it a bit clearer?

The docs for this command can also benefit from a good remarks section, I think...

ok second option I would recommend (I think even better then the first one) is yaml
https://www.npmjs.com/package/yaml
https://github.com/eemeli/yaml

Seems a good choice!

Ok, great, can we change the description a bit to make it a bit clearer?

Absolutely, what would you add?

The docs for this command can also benefit from a good remarks section, I think...

Sure, what would you had in mind?
Our command issue template does not have a remarks section that's why it is quite small and added at the end

Ok seems I got 2x✅ from @waldekmastykarz and @martinlingstuyl, right? The only things we now consider is more clarity in the spec or detail 🤔.
In that case I will start working on this one

The yaml package seems good on the surface: active, a group of contributors, regular releases. Let's try it! Good find!

About the usage @Adam-it:
We could also make it less specific:
m365 spfx project pipeline add --type GitHub --etc

We could later add extra types, like AzureDevOps

About the usage @Adam-it:
We could also make it less specific:
m365 spfx project pipeline add --type GitHub --etc

We could later add extra types, like AzureDevOps...
Just a brainwave

This was actually made up on basecamp. The decision here is to support GH only for now as our CLI actions will only work for GH. As for Azure DevOps it has to be handled differently which actually would resolve in a totally different set of options. Due to that fact this command would be really hard to maintain, large, and would consist of lot of if else code blocks.
I think what @waldekmastykarz wrote on basecamp is the correct way. For now let's focus on GH as this is what when have with actions. And I think it would be wiser to have a separate command for Azure DevOps.

I suggest that we use multiple commands, at least to start. Should we expand in the future, we can always revisit our stance. Since each CI system has different format of pipes, putting the different systems into one command could lead to too much unrelated code put into one command, not to mention different options required by each format. I suggest we start with GH and if we add other systems in the future, see if it makes sense to combine them or to keep them separate.


Difficulty with install

Thank you for putting this package together. I am having trouble installing waddR.
BiocManager::install("waddR")
Bioconductor version 3.11 (BiocManager 1.30.10), R 4.0.0 (2020-04-24)
Installing package(s) 'waddR'
trying URL 'https://bioconductor.org/packages/3.11/bioc/bin/macosx/contrib/4.0/waddR_1.2.0.tgz'
Content type 'application/x-gzip' length 197731 bytes (193 KB)
==================================================
downloaded 193 KB

The downloaded binary packages are in
	/var/folders/fw/ng_3gb5x467903z58bc8nwfm0000gn/T//Rtmp34Hw08/downloaded_packages

library(waddR)
Error: package or namespace load failed for ‘waddR’:
 .onLoad failed in loadNamespace() for 'waddR', details:
  call: gzfile(file)
  error: invalid 'description' argument

sessionInfo()
R version 4.0.0 (2020-04-24)
Platform: x86_64-apple-darwin17.0 (64-bit)
Running under: macOS Catalina 10.15.5

Matrix products: default
BLAS:   /System/Library/Frameworks/Accelerate.framework/Versions/A/Frameworks/vecLib.framework/Versions/A/libBLAS.dylib
LAPACK: /Library/Frameworks/R.framework/Versions/4.0/Resources/lib/libRlapack.dylib

locale:
[1] en_US.UTF-8/en_US.UTF-8/en_US.UTF-8/C/en_US.UTF-8/en_US.UTF-8

attached base packages:
[1] stats     graphics  grDevices utils     datasets  methods   base

loaded via a namespace (and not attached):
 [1] SummarizedExperiment_1.18.1 statmod_1.4.34              tinytex_0.23                tidyselect_1.1.0            xfun_0.14
 [6] purrr_0.3.4                 splines_4.0.0               lattice_0.20-41             vctrs_0.3.1                 generics_0.0.2
[11] stats4_4.0.0                BiocFileCache_1.12.0        blob_1.2.1                  rlang_0.4.6                 nloptr_<IP_ADDRESS>
[16] pillar_1.4.4                glue_1.4.1                  DBI_1.1.0                   BiocParallel_1.22.0         rappdirs_0.3.1
[21] SingleCellExperiment_1.10.1 BiocGenerics_0.34.0         sp_1.4-2                    bit64_0.9-7                 dbplyr_1.4.4
[26] matrixStats_0.56.0          GenomeInfoDbData_1.2.3      lifecycle_0.2.0             zlibbioc_1.34.0             rgeos_0.5-3
[31] coda_0.19-3                 memoise_1.1.0               Biobase_2.48.0              IRanges_2.22.2              GenomeInfoDb_1.24.0
[36] curl_4.3                    parallel_4.0.0              Rcpp_<IP_ADDRESS>                arm_1.11-1                  BiocManager_1.30.10
[41] DelayedArray_0.14.0         S4Vectors_0.26.1            XVector_0.28.0              abind_1.4-5                 lme4_1.1-23
[46] bit_1.1-15.2                digest_0.6.25               dplyr_1.0.0                 GenomicRanges_1.40.0        grid_4.0.0
[51] tools_4.0.0                 bitops_1.0-6                magrittr_1.5                RCurl_1.98-1.2              tibble_3.0.1
[56] RSQLite_2.2.0               crayon_1.3.4                pkgconfig_2.0.3             MASS_7.3-51.6               ellipsis_0.3.1
[61] Matrix_1.2-18               minqa_1.2.4                 assertthat_0.2.1            httr_1.4.1                  rstudioapi_0.11
[66] boot_1.3-25                 R6_2.4.1                    nlme_3.1-148                compiler_4.0.0

I have also attempted to install_github directly from this repository with the same result.

After exploring further on the Bioconductor website I tried the following without success:
BiocManager::install('waddR', type = "source", checkBuilt = TRUE)
Bioconductor version 3.11 (BiocManager 1.30.10), R 4.0.0 (2020-04-24)
Installing package(s) 'waddR'
trying URL 'https://bioconductor.org/packages/3.11/bioc/src/contrib/waddR_1.2.0.tar.gz'
Content type 'application/x-gzip' length 69611 bytes (67 KB)
==================================================
downloaded 67 KB

* installing *source* package ‘waddR’ ...
** using staged installation
** libs
clang++ -mmacosx-version-min=10.13 -std=gnu++11 -I"/Library/Frameworks/R.framework/Resources/include" -DNDEBUG  -I'/Library/Frameworks/R.framework/Versions/4.0/Resources/library/Rcpp/include' -I'/Library/Frameworks/R.framework/Versions/4.0/Resources/library/RcppArmadillo/include' -I/usr/local/include   -fPIC  -Wall -g -O2  -c RcppExports.cpp -o RcppExports.o
clang++ -mmacosx-version-min=10.13 -std=gnu++11 -I"/Library/Frameworks/R.framework/Resources/include" -DNDEBUG  -I'/Library/Frameworks/R.framework/Versions/4.0/Resources/library/Rcpp/include' -I'/Library/Frameworks/R.framework/Versions/4.0/Resources/library/RcppArmadillo/include' -I/usr/local/include   -fPIC  -Wall -g -O2  -c wasserstein.cpp -o wasserstein.o
wasserstein.cpp:386:27: warning: unused variable 'out_it_end' [-Wunused-variable]
        vector<double>::iterator out_it_end = out.end();
                                 ^
wasserstein.cpp:501:4: warning: unused variable 'max_x' [-Wunused-variable]
        T max_x = x_sorted[n-1];
          ^
wasserstein.cpp:1168:8: note: in instantiation of function template specialization 'quantile<double>' requested here
        res = quantile(x, q, type);
              ^
2 warnings generated.
clang++ -mmacosx-version-min=10.13 -std=gnu++11 -dynamiclib -Wl,-headerpad_max_install_names -undefined dynamic_lookup -single_module -multiply_defined suppress -L/Library/Frameworks/R.framework/Resources/lib -L/usr/local/lib -o waddR.so RcppExports.o wasserstein.o -F/Library/Frameworks/R.framework/.. -framework R -Wl,-framework -Wl,CoreFoundation
installing to /Library/Frameworks/R.framework/Versions/4.0/Resources/library/00LOCK-waddR/00new/waddR/libs
** R
** inst
** byte-compile and prepare package for lazy loading
** help
*** installing help indices
** building package indices
** installing vignettes
** testing if installed package can be loaded from temporary location
Error: package or namespace load failed for ‘waddR’:
 .onLoad failed in loadNamespace() for 'waddR', details:
  call: gzfile(file)
  error: invalid 'description' argument
Error: loading failed
Execution halted
ERROR: loading failed
* removing ‘/Library/Frameworks/R.framework/Versions/4.0/Resources/library/waddR’
* restoring previous ‘/Library/Frameworks/R.framework/Versions/4.0/Resources/library/waddR’

The downloaded source packages are in
	‘/private/var/folders/fw/ng_3gb5x467903z58bc8nwfm0000gn/T/RtmpZBBcnt/downloaded_packages’
Warning message:
In install.packages(...) :
  installation of package ‘waddR’ had non-zero exit status

Hey @mosscoder, thanks for using our package! I was unable to reproduce the errors you describe on this system:
> sessionInfo()
R version 4.0.0 (2020-04-24)
Platform: x86_64-pc-linux-gnu (64-bit)
Running under: Arch Linux

Matrix products: default
BLAS:   /usr/lib/libblas.so.3.9.0
LAPACK: /usr/lib/liblapack.so.3.9.0

locale:
 [1] LC_CTYPE=en_US.UTF-8       LC_NUMERIC=C
 [3] LC_TIME=de_DE.UTF-8        LC_COLLATE=en_US.UTF-8
 [5] LC_MONETARY=de_DE.UTF-8    LC_MESSAGES=en_US.UTF-8
 [7] LC_PAPER=de_DE.UTF-8       LC_NAME=C
 [9] LC_ADDRESS=C               LC_TELEPHONE=C
[11] LC_MEASUREMENT=de_DE.UTF-8 LC_IDENTIFICATION=C

attached base packages:
[1] stats     graphics  grDevices utils     datasets  methods   base

other attached packages:
[1] waddR_1.2.0

loaded via a namespace (and not attached):
 [1] SummarizedExperiment_1.18.1 statmod_1.4.34
 [3] tidyselect_1.1.0            purrr_0.3.4
 [5] splines_4.0.0               lattice_0.20-41
 [7] vctrs_0.3.1                 generics_0.0.2
 [9] stats4_4.0.0                BiocFileCache_1.12.0
[11] blob_1.2.1                  rlang_0.4.6
[13] pillar_1.4.4                nloptr_<IP_ADDRESS>
[15] glue_1.4.1                  DBI_1.1.0
[17] BiocParallel_1.22.0         rappdirs_0.3.1
[19] SingleCellExperiment_1.10.1 BiocGenerics_0.34.0
[21] bit64_0.9-7                 dbplyr_1.4.4
[23] matrixStats_0.56.0          GenomeInfoDbData_1.2.3
[25] lifecycle_0.2.0             zlibbioc_1.34.0
[27] coda_0.19-3                 memoise_1.1.0
[29] Biobase_2.48.0              IRanges_2.22.2
[31] GenomeInfoDb_1.24.0         parallel_4.0.0
[33] curl_4.3                    Rcpp_<IP_ADDRESS>
[35] arm_1.11-1                  BiocManager_1.30.10
[37] DelayedArray_0.14.0         S4Vectors_0.26.1
[39] XVector_0.28.0              abind_1.4-5
[41] bit_1.1-15.2                lme4_1.1-23
[43] digest_0.6.25               dplyr_1.0.0
[45] GenomicRanges_1.40.0        grid_4.0.0
[47] tools_4.0.0                 bitops_1.0-6
[49] magrittr_1.5                RCurl_1.98-1.2
[51] tibble_3.0.1                RSQLite_2.2.0
[53] crayon_1.3.4                pkgconfig_2.0.3
[55] ellipsis_0.3.1              MASS_7.3-51.6
[57] Matrix_1.2-18               assertthat_0.2.1
[59] minqa_1.2.4                 httr_1.4.1
[61] R6_2.4.1                    boot_1.3-25
[63] nlme_3.1-147                compiler_4.0.0

You could try installing right from our github with the command below. Please note, however, that the current github version is developmental and outputs are likely to diverge from the Bioconductor versions (1.2.0 and 1.3.0).
devtools::install_github("https://github.com/goncalves-lab/waddR/")

Best,
Julian

I was able to get the wasserstein_metric() operational by cloning this repository and running Rcpp::sourceCpp('/path/to/waddR/src/wasserstein.cpp')
It is quite a bit faster than transport package, thank you!
Trying to go the official installation route with biocmanager or install_github, I still run into problems. Digging into the installation logs it reports that the description file author and maintainer are malformed. Hope this helps.

Digging into the installation logs it reports that the description file author and maintainer are malformed.

Could you post that log here, so I can investigate this further?

It is quite a bit faster than transport package, thank you!

Glad you find our package useful :)

I have problem installing it too. The installation process strangely paused a long time right after the line "** testing if installed package can be loaded from temporary location".
Then the error log looks like this:
[1] "Downloading Reference Distribution: \n"
Warning: download failed
  web resource path: ‘https://github.com/goncalves-lab/waddR-data/blob/master/data/empcdf_ref.RData?raw=true’
  local file path: ‘~/.cache/BiocFileCache/13b8ac1a800fac_empcdf_ref.RData%3Fraw%3Dtrue’
  reason: Empty reply from server
Warning: bfcadd() failed; resource removed
  rid: BFC3
  fpath: ‘https://github.com/goncalves-lab/waddR-data/blob/master/data/empcdf_ref.RData?raw=true’
  reason: download failed
Error: package or namespace load failed for ‘waddR’:
 .onLoad failed in loadNamespace() for 'waddR', details:
  call: .util_download(x, rid[i], proxy, config, "bfcadd()", ...)
  error: bfcadd() failed; see warnings()
Error: loading failed
Execution halted
ERROR: loading failed
* removing ‘/data1/jason/tools/softwares/R_library/4.0.5/waddR’

It seems that you have somehow included a data-loading command during the installation. Since the communication between my computer and github is not that well, the system finally popped out the timeout error.

I think it might help if you deposit your demo data elsewhere..

Similar problem after installation from Bioconductor. After library("waddR"), I got following error info:
Error: package or namespace load failed for ‘waddR’:
 .onLoad failed in loadNamespace() for 'waddR', details:
  call: UseMethod("filter_")
  error: no applicable method for 'filter_' applied to an object of class "c('tbl_SQLiteConnection', 'tbl_dbi', 'tbl_sql', 'tbl_lazy', 'tbl')"
In addition: Warning message:
package ‘waddR’ was built under R version 3.6.3

I tried R 3.6.2 on my MacBook, macOS Monterey 12.0.1


Get templates data from HTMLWebpackPlugin

Hello
Currently the only way to give data to template it locals option but I need access to HTMLWebpackPlugin templateParameters function output in my template.
Mainly because i use svg-sprite-loader and I need access to htmlwebpackplugin.files.sprites.
https://github.com/kisenka/svg-sprite-loader/tree/master/examples/interop-with-html-webpack-plugin

I'll look into a way to make plugins available in the loader options somewhere.

I find a workaround using svg-sprite-html-webpack instead of svg-sprite-loader

Closed in favor of https://github.com/jabney/render-template-loader/issues/5


memory leak: did not delete psub in Server::psub_end

不知是我看错还是粗心
Server.cpp代码里面没发现有释放PresenceSubscriber
在Server::psub请求订阅通道事件消息, 连接断开在Server::psub_end未正常释放内存

closed, see https://github.com/ideawu/icomet/pull/71


Bug: Edge triggering does not work on RPi ZW2

Edge triggering of GPIO doesn’t work consistently on RPi ZW2 and slow on RPi ZW. Code was changed to use busy wait loops and polling.
To Reproduce
See older code with edge triggering.
Expected behavior
Should be just as fast and consistent edge triggering as it is polling.
Hardware (please complete the following information):
As described above.

Some notes and hypotheses:

periph.io uses the older sysfs interface, which is deprecated. It might be worth trying the newer gpiod interface. https://embeddedbits.org/new-linux-kernel-gpio-user-space-interface/
The A2IO code that sets up the edge detection (e.g. inWrite.In(gpio.PullDown, gpio.BothEdges)) isn't checking the return status. Since this is an I/O operation, it might be failing silently on the RPi ZW2. Worth adding some error checking.
I haven't tried it yet, but gpiomon looks like a cool tool for monitoring kernel GPIO events.

Thanks for the research. I might switch to this library in the future: https://github.com/warthog618/gpio For now, the busy-wait loop is working on the Zero W and Zero W 2.


Support DatetimeIndex in variable editor

Support variables of panda's DatetimeIndex type in variable editor, and use the dataframe editor to display them. Fixes #3380.

I actually wrote this a while ago, while we were in freeze for the 3.0 release.
There are a number of places that have to be changed to support a new type in the variable explorer. There are also a number of issues which ask to support more types: #3758, #3562, #2824, #2510, #2355, etc. Can we make it easier to add support for a new type, possibly in a plugin?

Can we make it easier to add support for a new type, possibly in a plugin?

That's my plan for Spyder 4.0 :-) I think we could add a function called register_object to spyder/api/variableexplorer.py that would take care of doing all you've done here.
But for that we need to restructure how we dispatch objects to viewers in the Variable Explorer code, so it can be easily extended.

PR redone against 3.x and conflicts resolved.

Thanks a lot! Just in time for 3.1 :-)


Ambivalent Types (Efficient implementation)

This PR implements Ambivalent types efficiently, relying on new theory.

The above commit implements basic ambivalence. There are several problems w/ the current implementation:

Flexization doesn't currently work as desired, since it is possible for the rigid variable to escape the region (e.g. under an implication), and not be flexized.
Instantiation is extremely in-efficient. This is because we use a deep copy of the type (modulo free variables) to support local ambivalence.
Abstractions between the solver, unifier, and generalization modules are no longer in place due to several hacks.

Some solutions:

Instead of flexizing on generalization, we will incrementally flexize rigid variables. One way would be to introduce the flexized
variable on make_rigid_var, on escape, the rigid variable is flexized. On generalization of the rigid variable, it's flexization is
generalized
We extend the constraint language w/ a polymorphic def. For rigid annotations, we ensure they are polymorphic. This
allows us to use the old instantiate

To address the issues of abstractions within the constraints library, we have added a new notion of structure, designed to be more composable.
The idea is that structure is a functor that implements a notion of "consistent composability" via a function called merge (named after the rewriting rule used in abstract unification). Structures may be composed e.g. First_order structures are used to form Ambivalent structures, etc.
Unfortunately, this doesn't hide the notion of scope in the Ambivalent structure, however, since the notion of scope is baked into the theory we've developed for this, I'm not too sure we need to hide it.

Integrated new unifier w/ Generalization. Currently a problem between obtaining state for current_level, etc in the Structure created for Generalization.

problem between obtaining state for current_level, etc in the Structure created for Generalization.

Solution: This problem is due to fact that we explicitly define the 'a term context used in merge. Instead, we should have 'a term be arbitrary. We can compose terms via *. For example, for generalization:
type 'a term = { fold : 'a t -> 'a; current_level : unit -> level; register : 'a t -> unit }

The discussed fixes have now been implemented. For simplicity (and ease of debugging), we have removed the memorization that used to occur in Rigid_var. This will be implemented in a future PR.
Additional issues:

Inference of annotations adhere's to the Ambivalence paper, but their notion of annotations requires annotations
within all branches?
We really need better debugging tools

In order to merge, we must also implement abbreviations in the style of ambivalent types. For now (as w/ Ambivalents), we have removed memoization of the expansions (This will be re-implemented in a future PR).


Fix leak of execution context between specs

Fixes #2644

Technically released in 6.0.4 but please use 6.1.0 for Rails 7.1 support.


get_pets

if the photo url is local, then i get "not_found" response. it might be related to issue #1

it is miss configuration of the docker compose file. it is fixed now


Update filedrophandler.js

fix: Error accessing effectAllowed property in dragover event in IE

Please also write a test in filehandler_test.js that fails at HEAD but passes under this patch.

No CLA found: https://github.com/google/closure-library/blob/master/CONTRIBUTING

No response.


vnetPE

Hi team,
I moved this from here: https://github.com/MicrosoftDocs/azure-docs.ja-jp/issues/2887
@meatloaf111 commented 21 hours ago — with docs.microsoft.com
Following command should use $rgName instead of the value of the resource groupname it self.
$vnetPE = New-AzVirtualNetwork -Name $virtualNetworkNamePE
-ResourceGroupName myResourceGroup `

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 25c87883-1e32-6383-9d21-306f91406ba6
Version Independent ID: ba6f8deb-cbfc-bf07-2bc8-26f5e6145859
Content: Create an Azure private link service using Azure PowerShell
Content Source: articles/private-link/create-private-link-service-powershell.md
Service: private-link
GitHub Login: @KumudD
Microsoft Alias: kumud

@meatloaf111 @CeciAc Thank you for bringing this to our attention. It appears the common syntax being used throughout the examples is $rgName but Create a virtual network uses -ResourceGroupName myResourceGroup. We are investigating this and will make an update to the documentation as appropriate.

fixed with https://github.com/MicrosoftDocs/azure-docs-pr/pull/94158
@meatloaf111 Thanks for the feedback! I have updated the doc, and changes should reflect within 24 hours.
We will now proceed to close this thread. If there are further questions regarding this matter, please tag me in your reply. We will gladly continue the discussion and we will reopen the issue.


Nick: Watch knowledgepanelservice.xyz

Nick requests the watch of the watch_keyword knowledgepanelservice\.xyz. See the MS search here and the Stack Exchange search in text, in URLs, and in code.

knowledgepanelservice\.xyz has been seen in 1 true positive, 0 false positives, and 0 NAAs.

Approved by Ollie in Charcoal HQ


Clarifying discount rate is monthly

This library has been super-useful, I was getting mixed-up on the discount rate and figured it might be helpful to be explicit in the documentation, and change the default to something a bit more reasonable.
Thanks!

good suggestion, thanks for the PR!

@kingfink there are some tests that need to be updated with this - do you mind adding those changes too?

@CamDavidsonPilon absolutely, just fixed the issues. Thanks for the review, and thanks again for open sourcing this tool!


Snap Transform project setting is Missing

Godot version:

Godot Engine 3.3 RC6
OS/device including version:

Windows 10 Pro x64
Issue description:

Project Settings rendering/2d/snapping/use_transform_snap is missing.

It is missing because the feature was removed - too many arcane corner cases kept breaking. It will be revisited post 3.3.

The settings were removed in 3.3rc6 because they weren't deemed mature enough. In the future, they'll be experimented again as add-ons.

Thanks! The feature is still mentioned on the news blog, maybe should be removed to avoid confusion.
https://godotengine.org/article/release-candidate-godot-3-3-rc-6
Sorry for my bad English.

Ah indeed, thanks. I removed it now.


[2.2.0] Allow --path to be specified for migration commands

Closes #202

The failing build seems to be related to https://github.com/laravel/framework/issues/30505 in some way. Not sure why this is happening only in this branch and not in 2.x, but I could reproduce similar behavior in a Laravel app using duplicate (central & tenant) migrations for queues.


I can't seem to use nested limit() function

So I have a Promise.all that's mapping an array to a limit, that's calling a function. In that function I have another Promise.all that I want limited, but it seems to never get into the second limit function call.
Any ideas?

Ah, I see my problem. I was limiting to 1 concurrent request. So a nested Promise.all needs at least 2 concurrent requests. Working a treat. Thanks!