Teams don't work

Describe the bug
Managing teams doesn't work when using franz's servers (default install).

To Reproduce

Steps to reproduce the behavior:

Go to Settings -> Manage Team
Click on Manage your Team on getferdi.com
See error 404: Not found

Expected behavior

I would expect to be able to add new team members. When this isn't possible because franz won't allow it when using their servers I would expect to see a notice that it will work when setting up an own ferdi-server.
BTW: Does ferdi-server support teams? If so: Why isn't it stated in the README?
Screenshots

Desktop:

OS: Windows 10
Ferdi Version 5.4.3 (latest)

Server Used: https://api.franzinfra.com

Additional context

The same happens when you try Settings -> Account ->Edit account

Ferdi doesn't officially support Franz Teams and there is no support for Teams on custom Ferdi servers.
The reason for this is that Ferdi doesn't offer any "premium" subscriptions, thus making Franz's Team management useless as that is only used to manage subscriptions for multiple users.
We may remove the "Teams" page in the future to make this more clear.
For now, if you need to manage your Franz team subscription simply replace the "getferdi.com" with "meetfranz.com" in the URL opened to manage teams.

We'll improve the information about Teams and Premium subscriptions in general via #497. This will also fix the "Manage your Team" link to work again.


Allow specifying encodings

This e.g. allows using future-fstrings
You can check that this works via:
#!/usr/bin/env python3.5
import ast
st = ast.parse(b"# coding: future-fstrings\nprint(f'hi')")
print(st)

The Path.read_bytes() method was new in 3.5, so there's a test failure on 3.4. However, I think we can move the minimum supported version to 3.5 at this point.

well, or we can open the file in binary mode. as you wish.

I'm OK with dropping 3.4, but I don't feel a strong need to, so since you've made it work with 3.4...

Great, thank you!


'DeviceTools' object has no attribute '_device_modifications'

I am running home assistant 2024.5 with device tools 1.8.2 and on startup I received the following traceback.
2024-05-01 16:44:40.870 ERROR (MainThread) [custom_components.device_tools] 'DeviceTools' object has no attribute '_device_modifications'
Traceback (most recent call last):
  File "/config/custom_components/device_tools/device_tools.py", line 84, in async_run
    self.async_get_entries()
  File "/config/custom_components/device_tools/device_tools.py", line 72, in async_get_entries
    if self._device_modifications == device_modifications:
       ^^^^^^^^^^^^^^^^^^^^^^^^^^
AttributeError: 'DeviceTools' object has no attribute '_device_modifications'

Could this be because self._run_task is being initilzied before self._device_modifications?
class DeviceTools:
    ...
    def __init__(self, hass: HomeAssistant, logger: logging.Logger) -> None:
        ...
        self._run_task = hass.async_create_background_task(self.async_run(), DOMAIN)
        self._device_modifications: dict[str, DeviceModification] = {}
        ....
`

Yes, could be. Maybe you could try switching those statements and if it works open a PR?

Will do! I'll keep you posted.

@EuleMitKeule, I made the change. I have rebooted twice without seeing the same error again. I think the change is safe to merge as is, but I am happy to run with it this way awhile longer, and reboot a few more times and report back if you prefer.

The change makes sense to me, I merged it and published a new release. Thank you!


Model foreignKeys not registered

I've been trying to reproduce this in a clean ember app but practically identical code works and I'm not familiar with the internals so I could use some tips for debugging.
The models are defined with a one to many relationship:
// models/contact.ts
export default class Contact extends DS.Model.extend({
    name:DS.attr('string'),
    organization: DS.belongsTo('organization')
}) { }
// models/organization.ts
export default class Organization extends DS.Model.extend({
    orgName: DS.attr('string'),
    contacts:DS.hasMany('contact')
}) { }

// mirage/factories/contact.js
export default Factory.extend({
    name() {
        return faker.name.firstName();
    },
    afterCreate( contact, server ){
        let org = server.create('organization', {orgName:contact.name, 'contacts':[contact]});
        contact.organization = org;
        contact.save();
    }
});

On my new test repo this works flawlessly, but in my actual app it is returning a Mirage Error:
Mirage: You're trying to create a contact model and you passed in a model:organization(1)
under the organization key, but you haven't defined that key as an association on
your model.

but the belongsTo and hasMany are set on the app models and on the mirage models (so it is making me crazy).
I've inspected it in the chrome debugger and can see that in the failing app the contact model doesn't have the foreignKey set linking it to the organization model, but in the working app it does.

Sleep is the answer, and a bad import. While the code in the mirage model for contact was the same, the imports were not. We were importing ember-data's belongsTo instead of mirage's version of belongsTo.


Numpy calls in non-numpy backends

A few functions in various backends seem to call the numpy equivalent for some reason - an example is sum. Is this intended? I am changing it in my current edit.

All of the shape functions do for certain backends. I believe sum was an oversite.

Ok, I'll fix sum and leave the ones that operate on shapes alone.

Thanks Adam, yes the jax-backend erroneously calls np.sum, this should be jnp.sum

@alewis is this fixed?

Yeah, should be fine to close.


Using short text for text classification

i have been exploring the possibilities of using ftcc to doing text classification but for short text,
but so far i get bad accuracy, any advice on applying this for short text data text classification?
thank you

It's difficult to get compression gains on short strings. No way around it. It's less likely for there to be redundancies/patterns for the compressor to use. For some REALLY short strings, compressing them will make them longer! (because of how compressed strings are formatted/metadata)

@icang1694 @CaltropHungerton ftcc will not perform well by design for short text. Even if the "learning" may be ok, each compression can be seen as a random draw of a normal variable with variance bigger when text is smaller. So with very small text it's very likely that one of the  compressor will have better compression than the compressor corresponding to the expected class.
As mentioned by @CaltropHungerton there is also

For some REALLY short strings, compressing them will make them longer

I need to check if metadata should be fixed in my implem btw.
@icang1694 ftcc is not a good choice for short sentence classification. I'd suggest to finetune a language model on your classification task. In short sentences stopwords, punctuations, grammatical structures and subtle semantics are important. Language model capture those way better than traditional approaches like tf-idf (and ftcc).


OpenCV Package broken on Ubuntu 16.04 LTS?!

Hi,
I tried to build a small sample project using OpenCV and Boost.
My CMakeLists.txt looks like this:
CMakeLists.txt
I tried to run with the following command on two different machines running Ubuntu 16.04 multiple times and always get the same error.

See also "/home/visy/BachelorThesis/OCRScannerApp/buildDebug/CMakeFiles/CMakeOutput.log".
make: *** No targets specified and no makefile found.  Stop.
`
Does anybody know what the problem is? Is it something I did wrong or isn't it supported for Ubuntu 16.04 LTS?
Thanks in advance!

This isn't related to Ubuntu 16.04. Happens on every distro I have tried.
Solution is to use a toolchain that sets fPIC.

The shared libraries that OpenCV links against need to have the same relocatable status (fPIC).
Something in the OpenCV build resets cxxflags when compiling dependencies (such as libpng in your situation).
Ultimately it is best if these flags are passed on but right now they are not. I recently fixed this in OpenSSL.
As a workaround, if you set the flag in your prochain (e.g. polly's gcc-pic),  it will override the flag and prevent it being reset.

The original problem is about OpenCV building shared library (which is not default) and need static PNG library (which is by default static with no -fPIC). I think you can try disable those OpenCV component.

Ultimately it is best if these flags are passed on but right now they are not. I recently fixed this in OpenSSL.

The issue with OpenSSL was about incomplete build scheme. The issue about OpenCV is different. Also as far as I understand OpenCV adds -fPIC always. Which is not good in my opinion (global flags should be set in toolchain, -fPIC is a global flag).

Thanks for your answers!
I will see if I can disable the OpenCV Component and report asap!
I hope I wont run into the OpenSSL problem because I use both of the libraries in my Project. I think it will get even more complicated if I have to fix both of the problems.. But lets hope for the best ;-)

I hope I wont run into the OpenSSL problem because I use both of the libraries in my Project

OpenSSL issue was fixed.

Closing inactive discussion.


Added console message to show when there are no hyperlinks

Currently when you run the command utility, if there are no hyperlinks, there is no onscreen output.
This PR adds a the message No hyperlinks found for such cases.
Test Report:
$ npm test

><EMAIL_ADDRESS>pretest /home/user/Documents/learning/OpenSource/markdown-link-check
> jshint index.js markdown-link-check

><EMAIL_ADDRESS>test /home/user/Documents/learning/OpenSource/markdown-link-check
> mocha -R spec

  markdown-link-check
    ✓ should check the links in sample.md (470ms)
    ✓ should check the links in file.md
    ✓ should handle thousands of links (this test takes up to a minute) (9858ms)

  3 passing (10s)

Thanks for the patch! I've released version 3.1.2 with this change.


JSON schema $ref field is removed before this.formlyJsonschema.toFieldConfig mapping

Question
I am using JSON schema with Formly and have some custom wrappers and types that I would like to map onto my fields when using this.formlyJsonschema.toFieldConfig, specifically to render out my custom definitions consistently throughout my form.
I thought to use the $ref field to do this since it would keep the rendering consistent with the definition, but apparently the mapper removes it in favour of adding the property types as it reaches my map() function. To get around this I've been using the description field on each of my definitions however I'm not fond of this and would rather use the $ref tag instead.
Here's an example:

Any chance I'm missing something or could we just keep $ref when mapping inside this.formlyJsonschema.toFieldConfig?
For reference, I'm currently on v5.12.7 and are using PrimeNG but I think this is still the same in v6

If you want to define the wrappers on a particular field with the json
schema config way of doing it you can use the widget property.
https://formly.dev/docs/guide/json-schema/#customize-json-schema-output
This allows specific field config for that exact field. Let me know if I
misunderstood your query.
On Tue, Feb 6, 2024, 10:58 PM Nicholas Finos @.***>
wrote:

Question
I am using JSON schema with Formly and have some custom wrappers and types
that I would like to map onto my fields when using
this.formlyJsonschema.toFieldConfig, specifically to render out my custom
definitions consistently throughout my form.
I thought to use the $ref field to do this since it would keep the
rendering consistent with the definition, but apparently the mapper removes
it in favour of adding the property types as it reaches my map() function.
To get around this I've been using the description field on each of my
definitions however I'm not fond of this and would rather use the $ref tag
instead.
Here's an example:
Screenshot.2024-02-07.at.3.50.05.pm.png (view on web)
https://github.com/ngx-formly/ngx-formly/assets/87622613/359cc02f-7170-4678-b508-cd28b0d22b69
Screenshot.2024-02-07.at.3.53.51.pm.png (view on web)
https://github.com/ngx-formly/ngx-formly/assets/87622613/7ce4e477-827b-48c6-b2c8-6b2f0d8d35ba
Any chance I'm missing something or could we just keep $ref when mapping
inside this.formlyJsonschema.toFieldConfig?
For reference, I'm currently on v5.12.7 and are using PrimeNG but I think
this is still the same in v6
—
Reply to this email directly, view it on GitHub
https://github.com/ngx-formly/ngx-formly/issues/3865, or unsubscribe
https://github.com/notifications/unsubscribe-auth/ADB4XNL5R2GFAAMK6H5NJRDYSMCX5AVCNFSM6AAAAABC5FCWNWVHI2DSMVQWIX3LMV43ASLTON2WKOZSGEZDEMJZGAYTMNA
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

Sweet that helps a lot. I just noticed that the FormlyJSONSchema7 exists in src/core/json-schema/src/formly-json-schema.service.ts but only seems to apply to the bottom level of the JSONSchema7 type and doesn't go through the rest of the sections in the heirarchy. I was wondering if there were any plans to get this type fixed?


YARN-4212. FairScheduler: Parent queues is not allowed to be 'Fair' policy if its children have the "drf" policy.

Thanks Karthik for the review, a new patch posted for your comments.

Committed.


Full sample project?

Hi, is there a full sample project available?  Thanks.

Hi,
no there isn't yet. Do you miss something from the documentation?

We are starting a new project soon.  Teamwork will be very useful.  We need admin UI functionality.
New to Laravel (moving from other frameworks).
Was planning to start project using this boilerplate.
https://github.com/rappasoft/laravel-5-boilerplate/blob/master/readme.md


Disable spellcheck in sensitive inputs

Prevent https://www.otto-js.com/news/article/spell-jacking-enhanced-spellcheck-features-send-pii-even-passwords

Do we need autoCorrect on Form element? It's not global attr like autoCapitalize or spellcheck and it can be applied to input element. It's also non standard attr that works only in Safari.

It probably doesn't work on textareas and forms, but I'd keep it consistently everywhere


Error changing app with set-CMDeploymentType

Getting the error below when attempting to update a deployment type using Set-CMDeploymentType
In my first attempt I get the cm deployment type then passed it to set-cmdeploymenttype and set the content location to something new.  In my second attempt I used just set-cmdeploymenttype and still the same error.
The application was created through the GUI and works fine.  Content distributed and application installs.
Example command
Set-CMDeploymentType -ApplicationName 'google chrome' -DeploymentTypeName 'Google Chrome - Windows Installer (*.msi file)' -ContentLocation '\server1\SourceFiles\GoogleChrome2'
Error
set-CMDeploymentType : The deployment type 'Microsoft.ConfigurationManagement.ApplicationManagement.MsiInstaller' is unrecognized
and cannot be used by this cmdlet.
At line:1 char:1

set-CMDeploymentType -ApplicationName 'google chrome' -DeploymentType ...

  + CategoryInfo          : InvalidOperation: (Microsoft.Confi...tDeploymentType:SetDeploymentType) [Set-CMDeploymentType], Invali
 dOperationException
  + FullyQualifiedErrorId : UnknownDeploymentType,Microsoft.ConfigurationManagement.PowerShell.Cmdlets.AppMan.SetDeploymentType

I'm getting this same error.  Trying to pass a DeploymentType object (retrieved from Get-CMDeploymentType) for -InputObject and then specify a new content location with -ContentLocation.


Resizing the right explorer window causes the terminal to pop open

Does this issue occur when all extensions are disabled?: Yes/No

VS Code Version:
$ code-insiders --version
1.82.0-insider
501baeb5e07b5a404f862d922bacb93771d91331
x64

OS Version: ubuntu

Steps to Reproduce:

open code insiders
resize the right explorer window
the terminal window opens up: click the trashcan to close it
resize the right explorer again
the terminal window opens up: click the trashcan to close it
repeat steps 2 through 4 until you experience my pain ;)~

https://github.com/microsoft/vscode/assets/10324554/f6ffcef7-f126-4169-9c73-318e6af25016

@noahehall does this repro with all extensions disabled? I don't repro this with the same layout

Will check by EOD

@sbatten issue repro with all extensions disabled.
I retested on the latest code-insiders version f7973f357e7c316a88e8817886f41a843021fe74
https://github.com/microsoft/vscode/assets/10324554/c191d909-e6ae-428d-a39e-f61ed653a50b

I'm testing on Ubuntu 22.04 with your settings file but I am not having any luck with a repro. Maybe the repro has to do with your window manager or DE?

Anything is possible, however, perhaps there is a simpler root cause.
I can access previous vscode releases via this screen: https://code.visualstudio.com/updates/v1_81
is there a similar screen for code-insiders?

@deepak1556 e25 happened this iteration, could there be something strange happening with mouse events?

e25 happened this iteration, could there be something strange happening with mouse events?

Not sure, there was change in draggable region behavior for macOS refs https://github.com/microsoft/vscode/issues/189973 not aware of changes in Linux at this point.
@noahehall can you using the following command npx @vscode/vscode-bisect to help us bisect the commit range that introduced the regression with Insiders, thanks!

thats a neat tool: probably the most stress-free debugging experience i've had seen blowing into nintendo cartridges
i'll update this as it completes, but found the first bad build
✔ Is 29661cb547fed7f6253d9bcb3699ae4379fd63d9 good or bad? › Good
✔ Is 77187a9bb864ca2e522d5727f53cebfea5a5179d good or bad? › Bad

I reran the cmd from the beginning, reusing the cache

Can you share the bisect range for the re-run ? thanks!

Can you share the bisect range for the re-run ? thanks!

my specific issue isnt reproducable with the code-insiders built from tool:

The bisect tool uses the released insiders build and not a custom build but the difference is that the tool uses the tar.gz version rather than deb, rpm or snap. Can you provide the following details

Are you using deb or snap installation of insiders ?
Does the issue repro when you use .tar.gz version from https://code.visualstudio.com/insiders/#linux ?

yes: just tested with the version below

Oh sorry for not being clear, I meant the archive version and not deb package, you can download it from https://az764295.vo.msecnd.net/insider/35be9bf683eace09796e59d54f1f225bbc3a7866/code-insider-x64-1693376777.tar.gz

I did my own bisect install using versions returned from apt-cache policy code-insiders

Thanks for performing this test, @sbatten given the results go all the way back to 1.65 I think it is unrelated to the Electron update.
@noahehall can you check if the issue repros with a new user data directory, the results so far indicate a bad UI state might be at play. You can start the application with code-insiders --user-data-dir /tmp/test-vscode-panel

indicate a bad UI state might be at play

bingo: where is my default data dir and can I simply wipe it?

Your default user data directory for insiders will be at ~/.config/Code\ -\ Inisders, but please do not wipe it yet. Lets hear back from @sbatten incase he could use some data from that folder to repro the issue on his end and maybe fix the root issue.

We don't have a quick and easy way to debug this with that state unless you share the contents which may contain information you don't necessarily want to share. The primary information needed would be the state.vscdb files for workspaceStorage and globalStorage

@sbatten we can close this issue, wiping the data directory resolved the issue

I'm having this happen. What specifically do I need to clear? I found my user settings in
cd ~/Library/Application\ Support/Code/

I had the same issue so I uninstalled VS Code and re-installed it. the problem was solved until the same thing happend again.
I was editing the settings.json file to make Live Server Extension open in a Chrome Dev instead of Chrome. I asked Copilot how to do it since I'm a newbie and it gave my this line of code "liveServer.settings.CustomBrowser": "chrome:chrome-dev" to add it to my settings.json file and so I did, and it was fine until a day later the same problem happend again. So I tried to comment all the costum setting I made in settings.json to see if any of them was the cause to it. I ended up deleting all the settings. I saved the file, closed VS Code and re-opened it and the problem was solved.
How to do it step-by-step:

Open Command Palette: Press Ctrl+Shift+P on your keyboard.
Open Settings (JSON): Type Preferences: Open User Settings (JSON).
Get a Copy of everything in the settings.json file (This is all the custom settings you made so don't lose it) and clear the file.
Save the settings.json file and close VS Code.
Re-open VS Code and the problem should be solved.

I have no idea what was the cause or why this fixed it, but this worked for me, might work for you too.

@3M00RY  Thank you


Update iobroker.easee

RE-CHECK!

Automated adapter checker
ioBroker.easee

:thumbsup: No errors found
ioBroker.alias-manager

:thumbsup: No errors found
ioBroker.fuelpricemonitor

:thumbsup: No errors found
ioBroker.lg-ess-home

[ ] :heavy_exclamation_mark: [E701] No actual year found in LICENSE. Please add "Copyright (c) 2021 Morluktom<EMAIL_ADDRESS>at the start of LICENSE

ioBroker.bluelink

:thumbsup: No errors found

[ ] :eyes: [W400] Cannot find "bluelink" in latest repository

Add comment "RE-CHECK!" to start check anew

what needs to be fixed?

@Newan
Please also add some more infos on the adapter into the Readme. Thank you

you might want to encrypt the "clientSescret" value?
plesse add all languages fpr the io-package standard fields ... you can use the iobroker translation tool (see dev best practices here in repo readme)
defining own "encrypt/decrypt" in https://github.com/Newan/ioBroker.easee/blob/master/admin/index_m.html#L23 can conflict with admin ones and lead to errors in admin javascript. best use own names or switch tp the auto encrypt/decrypt where you do not need to do that at all and only configure it (see dev best practices)
please think about using info.connection instead "online" (or additionally) - then admin would show yellow status if not "online" ... justdefine needed objects in io-package and set that state
please check if really that much states are indicators (only boolean should be indicators :-) see https://github.com/ioBroker/ioBroker.docs/blob/master/docs/en/dev/stateroles.md
makes it really sense to do all these setObjectNotExists on every data update? Normally done only once on beginning :-)

Please check and adjust. Thank you

@Apollon77 bluelink reviewed and ok!! see https://github.com/ioBroker/ioBroker.repositories/pull/1204

@Newan any news here?

@Newan any news here?

Sorry a little under time pressure.
I rebuild this and get back to you, please give me some more time

RE-CHECK!

Automated adapter checker
ioBroker.alias-manager

[ ] :heavy_exclamation_mark: [E144] common.installedFrom field found in io-package.json. Must be removed.
[ ] :heavy_exclamation_mark: [E506] Word "Adopt common.custom (some datapoints have custom configurations for adapters like History, SQL or iQontrol, which are stored in common.custom)" is not translated to german in admin/words.js. You can use https://translator.iobroker.in/ for translations
[ ] :heavy_exclamation_mark: [E301] Tests on Travis-ci.com are broken. Please fix.

ioBroker.easee

[ ] :heavy_exclamation_mark: [E300] Not found on travis. Please setup travis

ioBroker.fuelpricemonitor

:thumbsup: No errors found
ioBroker.lg-ess-home

[ ] :heavy_exclamation_mark: [E701] No actual year found in LICENSE. Please add "Copyright (c) 2021 Morluktom<EMAIL_ADDRESS>at the start of LICENSE

ioBroker.bluelink

:thumbsup: No errors found

[ ] :eyes: [W400] Cannot find "bluelink" in latest repository

Add comment "RE-CHECK!" to start check anew

@Newan
Please also add some more infos on the adapter into the Readme. Thank you

you might want to encrypt the "clientSescret" value?
plesse add all languages fpr the io-package standard fields ... you can use the iobroker translation tool (see dev best practices here in repo readme)
defining own "encrypt/decrypt" in https://github.com/Newan/ioBroker.easee/blob/master/admin/index_m.html#L23 can conflict with admin ones and lead to errors in admin javascript. best use own names or switch tp the auto encrypt/decrypt where you do not need to do that at all and only configure it (see dev best practices)
please think about using info.connection instead "online" (or additionally) - then admin would show yellow status if not "online" ... justdefine needed objects in io-package and set that state
please check if really that much states are indicators (only boolean should be indicators :-) see https://github.com/ioBroker/ioBroker.docs/blob/master/docs/en/dev/stateroles.md
makes it really sense to do all these setObjectNotExists on every data update? Normally done only once on beginning :-)

Please check and adjust. Thank you

Hello, i fixed it all, i hope. The last adjust, setObjectNotExists -> this is only called if the wallbox ist not in the array and a new comes, so the create-Function is only called onced

RE-CHECK!

Automated adapter checker
ioBroker.bluelink

[ ] :heavy_exclamation_mark: [E812] file test/ found in repository, but not found in .npmignore
[ ] :heavy_exclamation_mark: [E816] file tsconfig.json found in repository, but not found in .npmignore
[ ] :eyes: [W400] Cannot find "bluelink" in latest repository

ioBroker.easee

[ ] :heavy_exclamation_mark: [E300] Not found on travis. Please setup travis

ioBroker.alias-manager

[ ] :heavy_exclamation_mark: [E144] common.installedFrom field found in io-package.json. Must be removed.
[ ] :heavy_exclamation_mark: [E506] Word "Adopt common.custom (some datapoints have custom configurations for adapters like History, SQL or iQontrol, which are stored in common.custom)" is not translated to german in admin/words.js. You can use https://translator.iobroker.in/ for translations
[ ] :heavy_exclamation_mark: [E301] Tests on Travis-ci.com are broken. Please fix.

ioBroker.fuelpricemonitor

:thumbsup: No errors found
ioBroker.lg-ess-home

[ ] :heavy_exclamation_mark: [E701] No actual year found in LICENSE. Please add "Copyright (c) 2021 Morluktom<EMAIL_ADDRESS>at the start of LICENSE

Add comment "RE-CHECK!" to start check anew


support limit message size produced by protocol handlers by maxMessag…

Motivation
See  #13170 .
Also, Protocols handlers like KOP should make changes to add and decrease pendingBytes from BrokerSerice.
Modifications
Add a LongAdder totalPedingBytes in BrokerSerivce to record total pending message size.
Documentation
Check the box below and label this PR (if you have committer privilege).
Need to update docs?

[ ] doc-required
(If you need help on updating docs, create a doc issue)

[x] no-need-doc
(Please explain why)

[ ] doc
(If this PR contains doc changes)

There could have a case when we have both pulsar and kafka producer send msgs:

totalPendingBytes exceed maxMessagePublishBufferSizeInMB and pulsar broker and KoP both stop read from producer.
Pulsar have completed all it's pending msgs, but totalPendingBytes still exceed resumeThresholdPendingBytes since KoP may hold lots of pending buffer, pulsar will not start to read from pulsar producer.
KoP completed some pending msgs and totalPendingBytes become lower than resumeThresholdPendingBytes, KoP will start to read from kafka producer. But pulsar broker may still not start to read from pulsar producer because completedSendOperation will never called since all pulsar msgs are sent completed.

Could you please consider how to avoid this happen

Why the previous design had no this problem?  I'm little confused.  @wangjialing218

I  got the reason, I will try fix this case.

As previous design，totalPendingBytes is only used by broker to record the msg bytes received from pulsar producer, so broker could resume reading from producer when totalPendingBytes become lower than resumeThresholdPendingBytes.
This PR will make totalPendingBytes shared with KoP, so this problem could happen.

We do not have to do LongAdder.sum() each time when add or decrease pending bytes,  since it's a little heavy CPU work.
We could do sum() in another scheduler task such as 50ms each time, and then inform ServerCnx in broker and protocol handlers to stop or resume reading by listener.

@codelipenghui  @eolivelli  @wangjialing218 @Jason918   @BewareMyPower  PTAL

/pulsarbot run-failure-checks

/pulsarbot run-failure-checks

@gaozhangmin Thanks for your contribution.
Before Pulsar 2.8.0, the broker publish throttle policy is similar to your implementation, it has a shortcoming of suddenly exceed the limit and will lead to broker direct memory OOM. After Pulsar 2.8.0, we introduced the throttle policy by io thread,  it can limit the throughput of pulsar protocol, but out of control of other protocols, like KOP.
IMO, it's better to throttle in KOP side, do you have any other ideas? @BewareMyPower

@hangc0276 For now I didn't have much context. AFAIK, this PR is an implementation of idea from https://github.com/apache/pulsar/issues/12959. Could you answer hang's question? @wangjialing218

@hangc0276 You may mentioned #7406, which introduced the throttle policy by io thread.
This PR make more effective use of memory, and could also improve the points mentioned in #7406, beside this:
-- There is a delay for detecting the memory over-commit, due to the background task running periodically
As idle connection will not call LoggAdder.add, we only need to count up the bytes from active connection in LoggAdder.sum. We could do the detecting more frequently to avoid OOM, such as 10ms per time.

IMO, it's better to throttle in KOP side, do you have any other ideas?

For this point, we could make sure broker and KoP share the IO thread pool, and do same throttle policy by io thread in KoP side.  @BewareMyPower

I notice there is a configuration useSeparateThreadPoolForProtocolHandlers with default value true. I wonder if there is any disadvantage when set this configuration false.

The false configuration is the previous behavior that the potential deadlocks at KoP side might also block broker's IO thread.


Move the common writeHead to IndexUtils

What changes were proposed in this pull request?
writeHead is used by both BTree and Bitmap, so move to IndexUtils.
How was this patch tested?
mvn clean test package

writeHead is also in Permuterm index...

@adrian-wang @linhong-intel @yueawang Please help review and merge this PR if it's ready. Thanks.

better add tests for IndexUtils.writeHead

@adrian-wang @linhong-intel Please help review and merge this PR if it's ready. Thanks.

merged, thanks!


Fix code scanning alert - Missing zero address validation

Tracking issue for:

[x] https://github.com/antoncoding/grappa/security/code-scanning/3

fixed in #51


Add new standard labels and allow custom labels

Resolves #44
Why
This chart appears to have the standard labels used with helm 2. This adds in the new helm 3 standard labels and also allows the user to pass in additional labels that will get applied to all resources.
How

Create a template helper that creates metadata labels that can be reused by multiple resource templates
Include the existing labels in this helper for passivity
default to use the fullName value for the name labels but allow an optional appSuffix to be passed in for passivity for the jaeger and storage usecases
include this new helper in some resources that were missing the common labels
add a helm value to pass in an object of custom labels which is a common helm convention
enable jaeger and pass custom labels in CI to exercise more code paths

Validation
Run helm template charts/athens-proxy --set extraLabels.athensIs=awesome --set jaeger.enabled=true against main and this branch and diff them

Diff
7a8
>
9c10
<     chart: "athens-proxy-0.7.0"
---
>     chart: athens-proxy-0.7.0
11a13,18
>     app.kubernetes.io/name: release-name-athens-proxy
>     helm.sh/chart: athens-proxy-0.7.0
>     app.kubernetes.io/managed-by: "Helm"
>     app.kubernetes.io/instance: "release-name"
>     app.kubernetes.io/version: "v0.12.0"
>     athensIs: awesome
17a25,36
>   labels:
>
>     app: release-name-athens-proxy
>     chart: athens-proxy-0.7.0
>     release: "release-name"
>     heritage: "Helm"
>     app.kubernetes.io/name: release-name-athens-proxy
>     helm.sh/chart: athens-proxy-0.7.0
>     app.kubernetes.io/managed-by: "Helm"
>     app.kubernetes.io/instance: "release-name"
>     app.kubernetes.io/version: "v0.12.0"
>     athensIs: awesome
26a46
>
28c48
<     chart: "athens-proxy-0.7.0"
---
>     chart: athens-proxy-0.7.0
30a51,56
>     app.kubernetes.io/name: release-name-athens-proxy-jaeger
>     helm.sh/chart: athens-proxy-0.7.0
>     app.kubernetes.io/managed-by: "Helm"
>     app.kubernetes.io/instance: "release-name"
>     app.kubernetes.io/version: "v0.12.0"
>     athensIs: awesome
67a94
>
69c96
<     chart: "athens-proxy-0.7.0"
---
>     chart: athens-proxy-0.7.0
71a99,104
>     app.kubernetes.io/name: release-name-athens-proxy
>     helm.sh/chart: athens-proxy-0.7.0
>     app.kubernetes.io/managed-by: "Helm"
>     app.kubernetes.io/instance: "release-name"
>     app.kubernetes.io/version: "v0.12.0"
>     athensIs: awesome
88a122
>
90c124
<     chart: "athens-proxy-0.7.0"
---
>     chart: athens-proxy-0.7.0
92a127,132
>     app.kubernetes.io/name: release-name-athens-proxy
>     helm.sh/chart: athens-proxy-0.7.0
>     app.kubernetes.io/managed-by: "Helm"
>     app.kubernetes.io/instance: "release-name"
>     app.kubernetes.io/version: "v0.12.0"
>     athensIs: awesome
101a142
>
103c144
<         chart: "athens-proxy-0.7.0"
---
>         chart: athens-proxy-0.7.0
104a146,152
>         heritage: "Helm"
>         app.kubernetes.io/name: release-name-athens-proxy
>         helm.sh/chart: athens-proxy-0.7.0
>         app.kubernetes.io/managed-by: "Helm"
>         app.kubernetes.io/instance: "release-name"
>         app.kubernetes.io/version: "v0.12.0"
>         athensIs: awesome
152a201
>
154c203
<     chart: "athens-proxy-0.7.0"
---
>     chart: athens-proxy-0.7.0
156a206,211
>     app.kubernetes.io/name: release-name-athens-proxy-jaeger
>     helm.sh/chart: athens-proxy-0.7.0
>     app.kubernetes.io/managed-by: "Helm"
>     app.kubernetes.io/instance: "release-name"
>     app.kubernetes.io/version: "v0.12.0"
>     athensIs: awesome

Example Output from template
---
# Source: athens-proxy/templates/service-account.yaml
apiVersion: v1
kind: ServiceAccount
metadata:
  name: release-name-athens-proxy
  labels:

    app: release-name-athens-proxy
    chart: athens-proxy-0.7.0
    release: "release-name"
    heritage: "Helm"
    app.kubernetes.io/name: release-name-athens-proxy
    helm.sh/chart: athens-proxy-0.7.0
    app.kubernetes.io/managed-by: "Helm"
    app.kubernetes.io/instance: "release-name"
    app.kubernetes.io/version: "v0.12.0"
    athensIs: awesome
---
# Source: athens-proxy/templates/secret.yaml
kind: Secret
apiVersion: v1
metadata:
  name: release-name-athens-proxy-secret
  labels:

    app: release-name-athens-proxy
    chart: athens-proxy-0.7.0
    release: "release-name"
    heritage: "Helm"
    app.kubernetes.io/name: release-name-athens-proxy
    helm.sh/chart: athens-proxy-0.7.0
    app.kubernetes.io/managed-by: "Helm"
    app.kubernetes.io/instance: "release-name"
    app.kubernetes.io/version: "v0.12.0"
    athensIs: awesome
type: Opaque
data:
---
# Source: athens-proxy/templates/jaeger-svc.yaml
apiVersion: v1
kind: Service
metadata:
  name: release-name-athens-proxy-jaeger
  labels:

    app: release-name-athens-proxy-jaeger
    chart: athens-proxy-0.7.0
    release: "release-name"
    heritage: "Helm"
    app.kubernetes.io/name: release-name-athens-proxy-jaeger
    helm.sh/chart: athens-proxy-0.7.0
    app.kubernetes.io/managed-by: "Helm"
    app.kubernetes.io/instance: "release-name"
    app.kubernetes.io/version: "v0.12.0"
    athensIs: awesome
spec:
  type: ClusterIP
  ports:
    - name: jaeger-collector-http
      port: 14268
      protocol: TCP
      targetPort: 14268
    - name: jaeger-zipkin-thrift
      port: 5775
      protocol: UDP
      targetPort: 5775
    - name: jaeger-compact
      port: 6831
      protocol: UDP
      targetPort: 6831
    - name: jaeger-binary
      port: 6832
      protocol: UDP
      targetPort: 6832
    - name: jaeger-configs
      port: 5778
      protocol: TCP
      targetPort: 5778
    - name: jaeger-query-http
      port: 16686
      protocol: TCP
      targetPort: 16686
  selector:
    app: release-name-athens-proxy-jaeger
    release: "release-name"
---
# Source: athens-proxy/templates/service.yaml
apiVersion: v1
kind: Service
metadata:
  name: release-name-athens-proxy
  labels:

    app: release-name-athens-proxy
    chart: athens-proxy-0.7.0
    release: "release-name"
    heritage: "Helm"
    app.kubernetes.io/name: release-name-athens-proxy
    helm.sh/chart: athens-proxy-0.7.0
    app.kubernetes.io/managed-by: "Helm"
    app.kubernetes.io/instance: "release-name"
    app.kubernetes.io/version: "v0.12.0"
    athensIs: awesome
spec:
  type: ClusterIP
  ports:
  - name: http
    port: 80
    targetPort: 3000
    protocol: TCP
  selector:
    app: release-name-athens-proxy
    release: "release-name"
---
# Source: athens-proxy/templates/deployment.yaml
apiVersion: apps/v1
kind: Deployment
metadata:
  name: release-name-athens-proxy
  labels:

    app: release-name-athens-proxy
    chart: athens-proxy-0.7.0
    release: "release-name"
    heritage: "Helm"
    app.kubernetes.io/name: release-name-athens-proxy
    helm.sh/chart: athens-proxy-0.7.0
    app.kubernetes.io/managed-by: "Helm"
    app.kubernetes.io/instance: "release-name"
    app.kubernetes.io/version: "v0.12.0"
    athensIs: awesome
spec:
  replicas: 1
  selector:
    matchLabels:
      app: release-name-athens-proxy
      release: "release-name"
  template:
    metadata:
      labels:

        app: release-name-athens-proxy
        chart: athens-proxy-0.7.0
        release: "release-name"
        heritage: "Helm"
        app.kubernetes.io/name: release-name-athens-proxy
        helm.sh/chart: athens-proxy-0.7.0
        app.kubernetes.io/managed-by: "Helm"
        app.kubernetes.io/instance: "release-name"
        app.kubernetes.io/version: "v0.12.0"
        athensIs: awesome
      annotations:
        checksum/upstream: e3b0c44298fc1c149afbf4c8996fb92427ae41e4649b934ca495991b7852b855
        checksum/ssh-config: e3b0c44298fc1c149afbf4c8996fb92427ae41e4649b934ca495991b7852b855
        checksum/ssh-secret: e3b0c44298fc1c149afbf4c8996fb92427ae41e4649b934ca495991b7852b855
    spec:
      serviceAccount: release-name-athens-proxy
      containers:
      - name: release-name-athens-proxy
        image: "docker.io/gomods/athens:v0.12.0"
        imagePullPolicy: "IfNotPresent"
        livenessProbe:
          failureThreshold: 3
          httpGet:
            path: "/healthz"
            port: 3000
          periodSeconds: 10
          successThreshold: 1
          timeoutSeconds: 1
        readinessProbe:
          httpGet:
            path: "/readyz"
            port: 3000
        env:
        - name: ATHENS_GOGET_WORKERS
          value: "3"
        - name: ATHENS_STORAGE_TYPE
          value: "disk"
        - name: ATHENS_DISK_STORAGE_ROOT
          value: "/var/lib/athens"
        - name: ATHENS_TRACE_EXPORTER_URL
          value: "SET THIS ON THE COMMAND LINE"
        - name: ATHENS_TRACE_EXPORTER
          value: "jaeger"
        ports:
        - containerPort: 3000
        volumeMounts:
        - name: storage-volume
          mountPath: "/var/lib/athens"
      volumes:
      - name: storage-volume
        emptyDir: {}
---
# Source: athens-proxy/templates/jaeger-deploy.yaml
apiVersion: apps/v1
kind: Deployment
metadata:
  name: release-name-athens-proxy-jaeger
  labels:

    app: release-name-athens-proxy-jaeger
    chart: athens-proxy-0.7.0
    release: "release-name"
    heritage: "Helm"
    app.kubernetes.io/name: release-name-athens-proxy-jaeger
    helm.sh/chart: athens-proxy-0.7.0
    app.kubernetes.io/managed-by: "Helm"
    app.kubernetes.io/instance: "release-name"
    app.kubernetes.io/version: "v0.12.0"
    athensIs: awesome
spec:
  replicas: 1
  selector:
    matchLabels:
      app: release-name-athens-proxy-jaeger
      release: "release-name"
  template:
    metadata:
      labels:
        app: release-name-athens-proxy-jaeger
        chart: "athens-proxy-0.7.0"
        release: "release-name"
    spec:
      containers:
        - env:
            - name: COLLECTOR_ZIPKIN_HTTP_PORT
              value: "9441"
          image: "jaegertracing/all-in-one:latest"
          name: release-name-athens-proxy-jaeger
          ports:
            - containerPort: 14268
              protocol: TCP
            - containerPort: 5775
              protocol: UDP
            - containerPort: 6831
              protocol: UDP
            - containerPort: 6832
              protocol: UDP
            - containerPort: 5778
              protocol: TCP
            - containerPort: 16686
              protocol: TCP
            - containerPort: 9411
              protocol: TCP
---
# Source: athens-proxy/templates/test/test-connection.yaml
apiVersion: v1
kind: Pod
metadata:
  name: "release-name-athens-proxy-test-connection"
  labels:
    app: release-name-athens-proxy
  annotations:
    "helm.sh/hook": test
spec:
  containers:
    - name: wget
      image: busybox
      command: ['wget']
      args: ['release-name-athens-proxy:80']
  restartPolicy: Never

Thank you for your contribution and effort put in @alex-bezek, unfortunately I overlooked that this PR did not bump the chart version to trigger a release, so I just merged #46 to take care of that.

thanks @DrPsychick and @michalpristas  !


Form buttons

[x] Remove Default Cancel/Save Button from Final Form
[x] Remove renderButtons prop from FinalForm
[x] Create New FormButtons Component
[x] Changelog entry
[x] codemod
[ ] stories aktualisieren

This is a great improvement of the form-component. Splitting the component in Form and FormButtons makes it now much more easier to customize the Buttons, with a much clearer API!


AnalysisServer - add a way to find implementations of a member or class

Prior art: https://microsoft.github.io/language-server-protocol/specification#textDocument_implementation
This would be useful in at least https://github.com/Dart-Code/Dart-Code and https://github.com/natebosch/dart_language_server
Is there a different API (or set of APIs) that IntellJ uses to implement this type of navigation?
cc @DanTup

I have an issue about adding this:
https://github.com/Dart-Code/Dart-Code/issues/554
I added a link to here:
https://htmlpreview.github.io/?https://github.com/dart-lang/sdk/blob/master/pkg/analysis_server/doc/api.html#notification_analysis.implemented
Now I'm not so sure if it's the right thing though?

The analysis.implemented notification only tells the client which classes have been subclasses and which members have been overridden, but doesn't help discover where those subtypes / overriding members are. In IntelliJ, this is used to place icons in the left gutter (which, when clicked, will allow the user to navigate to one of the subtypes / members).
I believe you're looking for the search.getTypeHierarchy request. The documentation isn't very clear, but given the offset of the name of either a type or a member it will return the type hierarchy of that type (or the type containing the member), and if the name is the name of a member will include information about which of those types contains an overriding declaration of the member.

Thanks for the pointer! I'll give a shot at implementing the call on top of getTypeHierarchy


New Sink: Webhook JSON

Is your feature request related to a problem?
I would like to send finding information to a webhook in a JSON payload to be used by external app (for instance in a n8n workflow).
Describe the solution you'd like
Could we have a new generic sink webhook which send Finding attributes and other extra info (like cluster name) in JSON payload. I could allow more complex integration with a machine readable payload.
Describe alternatives you've considered
For now, a workaround may be to use VictorOps sink in order to have a JSON payload with some finding information and a url configurable, but we still miss some info (like severity) and the fields may change in future due to VictorOps evolution.

Hi @Tassatux,
We have a webhook sink already - does it send data in the right format or do you need something else

Hi,
The webhook sink only send a formatted string as body, and I would like to use the raw field from finding in a serialised way (ideally JSON), so I could use it in a programmatic way.

I don't have time to work on it for now, but I'll consider to give a try for the future if nobody is able to work on it in the mean time.
I guess I have to follow https://docs.robusta.dev/master/configuration/sinks/sinks-development.html right?

Yep, that's right. Make sure to see the instructions here for setting up a build environment.
Instead of writing a brand new sink, you can also consider modifying the existing webhook sink and contributing changes to that.

This fix is included in 0.10.26 which was released today


chore(main): release 0.0.26

:robot: I have created a release beep boop
0.0.26 (2024-08-24)
Bug Fixes

YAML rendering of structs embedded in rules (#265) (3b89e14)

This PR was generated with Release Please. See documentation.

:robot: Created releases:

v0.0.26
:sunflower:


Using the grid in a navbar makes row's width auto

When using the grid in the navbar, the row's width is not 100% anymore.
Problem occurs because of .navbar > .container = flexbox display.

            auto width

        100% width

Example: https://jsfiddle.net/8exp8kde/

Im not sure if this is what you want but I tried this and width is not 100%
https://jsfiddle.net/8exp8kde/4/

Yeah, the container because a flex item in addition to being a flex container. This is flex behavior, not a bug. Also, empty rows aren't required for full-width content inside a container. You can nix that unless you're just shortcutting for code snippet and plan to use columns.


Data feed fixed - changes to BNO data source

Resolved.
The spreadsheet still takes a long time to do its work some times -- not sure why.  Manual monitoring.

Looks good. Merging.


2.0 wip

Event.srcElement property does not work in Firefox. Replaced it with e.target, which is the recommended jQuery way.

Should I submit such tiny changes as a pull request or a  new issue?

It's a code change. I'd say PR is a good choice :)

target is not right. I'll think of a different way to do it.

The current code doesn't work in firefox, whereas event.target works in all browsers. For IE and old versions of safari, jQuery store event.srcElement in the target property. ( https://github.com/jquery/jquery/blob/master/src/event.js#L539 )
If you were referring to the current approach with the comment "target is not right", please ignore the above comment :)


We should add a linter

Just my opinion, but I think we should have a linter in this project. I recommend SwiftLint. It helps prevent bugs and keeps code style uniform for all contributors.
The tricky bit is that whatever setting we go with, it'll probably want us to reformat nearly every Swift file, so it might be quite a bit of work, but it's worth it IMO.

Merging with #305


AR icon is displayed in browsers without current support

On iOS, Quick Look is the currently supported AR method. However, Quick Look is only launchable from Safari, and not from other browsers (I tested Chrome and Firefox).
A potential fix would be to not show the icon except on a supported os/browser combination.
I tested this with the sample page - https://googlewebcomponents.github.io/model-viewer/examples/augmented-reality.html
Browser Affected

[X] Chrome - iOS Stable, Dev, & Canary
[ ] Edge
[X] Firefox - iOS 14
[ ] Helios
[ ] IE
[ ] Safari

OS

[ ] Android
[X] iOS - 12.1.2
[ ] Linux
[ ] MacOS
[ ] Windows

Ugh I forgot about this issue. I believe the only way to handle this is to browser sniff and only show the badge for iOS Safari. This is how we handle it for Shopify AR.
Affected browsers is actually beyond that list. For instance Facebook, Instagram, etc all render their own browser chrome and under the hood don't use https://developer.apple.com/documentation/safariservices/sfsafariviewcontroller
In which case you get a false positive for this feature working. Really Apple does need to handle this.

I think this was fixed.


Use latest FreeBSD 11.2 images on prow tests

The Google Compute Agent was updated on FreeBSD 11.2 but prow was only testing
the release image. Tests should be focusing on the latest builds.

E.g: with freebsd-11-2-snap instead of freebsd-11-2, I see the network and oslogin-ssh tests passing


pull request for e2e test at 01/22/2017 15:45:16

:white_check_mark: Validation status: passed
For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


no output in terminal iframe

Using the wrapper.html and wsProxy, the terminal loads with a cursor, and a connection accepted is logged in the wsProxy output. However, there is no login prompt -- eventually the terminal windows displays a message about the connection closing due to inactivity.
Confirmed can SSH into the system via CLI from the same host.

Have any errors been logged in your browsers JavaScript console?

@stuicey Yes, sorry I forgot to mention in the original comment.
Error! code - 6 does not exist!

My apologies, this issue went away when I served via Flask. Must've been a local-file issue. Sorry!

No worries, glad its working for you now :)


_convert_fragment() has polynomial time complexity as signals are added to design

While creating a large gate level multiplier in amaranth I noticed that it took a long time to write out the Verilog.
A simple test case:
#!/usr/bin/python3

import sys

from amaranth import Elaboratable, Module, Signal
from amaranth.back import verilog

class Test(Elaboratable):
    def __init__(self, nr_sigs=1000):
        self.i = Signal()
        self.o = Signal()
        self.nr_sigs=nr_sigs

    def elaborate(self, platform):
        m = Module()

        s = Signal()
        m.d.comb += s.eq(self.i)

        for i in range(self.nr_sigs):
            s_new = Signal(name="s_%i" % i)
            m.d.comb += s_new.eq(s)
            s = s_new

        m.d.comb += self.o.eq(s)

        return m

nr_sigs=int(sys.argv[1])
test = Test(nr_sigs=nr_sigs)
print(verilog.convert(test, ports=[test.i, test.o], strip_internal_attrs=True))

Things start going bad at 1000 signals.
Almost all the time is in the code that groups statements - for each signal we then iterate over each statement. I don't understand everything we are doing here (eg why we have to group signals vs just putting each one in their own process), but it seems we could make a single pass through the signals and statements to form them into the groups we need.
        lhs_grouper = xfrm.LHSGroupAnalyzer()
        lhs_grouper.on_statements(fragment.statements)

        for group, group_signals in lhs_grouper.groups().items():
            lhs_group_filter = xfrm.LHSGroupFilter(group_signals)
            group_stmts = lhs_group_filter(fragment.statements)

            with module.process(name="$group_{}".format(group)) as process:
                with process.case() as case:
                    # For every signal in comb domain, assign \sig$next to the reset value.
                    # For every signal in sync domains, assign \sig$next to the current
                    # value (\sig).
                    for domain, signal in fragment.iter_drivers():
                        if signal not in group_signals:
                            continue
                        if domain is None:
                            prev_value = ast.Const(signal.reset, signal.width)
                        else:
                            prev_value = signal
                        case.assign(lhs_compiler(signal), rhs_compiler(prev_value))

                    # Convert statements into decision trees.
                    stmt_compiler._case = case
                    stmt_compiler._has_rhs = False
                    stmt_compiler._wrap_assign = False
                    stmt_compiler(group_stmts)

I'll take a look, thanks!

Could you prepare a PR with this change, please?

Could you prepare a PR with this change, please?

Sorry, I misunderstood. For some reason I thought you posted a patch in the PR, not just a reference to the code.

eg why we have to group signals vs just putting each one in their own process

We have to group signals because the target of an assignment can be a concatenation. Consider something like:
a = Signal(16)
b = Signal(16)
c = Signal(16)
d = Signal(16)
m.d.comb += Cat(a, b).eq(c * d)

Unless you stuff the two of them into the same process, you have to duplicate the right-hand side, which can get really unwieldy for certain kinds of code. (We already duplicate
The reason we can't just stuff everything into the same process is that you can have something like:
m.d.comb += a.eq(b)
m.d.comb += b.eq(c)

which confuses Verilog simulators if you translate it to:
always @(*) begin
  a = b;
  b = c;
end

I think it should work fine if you do it like:
always @(*) begin
  a$next = b;
  b$next = c;
end
always @(*) begin
  a = a$next;
  b = b$next;
end

but that's ugly.
The right approach here is to convert RTL to netlist on Amaranth side and then convert netlist back to readable-ish Verilog (this is feasible), but it'll take a bit of time to do that.

This is fixed by the new IR in the main branch.


Change text on general feedback form

Trello card URL
https://trello.com/c/fCSnY3g3/357-removing-the-word-teaching-from-feedback-form-question
Changes in this PR:
Changing the wording in the general feedback form.
Screenshots of UI changes:
Before
After
Next steps:

[ ] Terraform deployment required?

[ ] New development configuration to be shared?

 Removing the word 'teaching' from feedback form question


Initialize File fields with label instead of type

Fixes issue #88.

Yo @rogierkoppejan ! Thanks 👍


add display hint annotations for study slots that appear on study submission portal

@dehays
@subdavis
@cmungall

see

https://docs.google.com/spreadsheets/d/1Y3RejJYT8JbIyyXysrDRwTef1lPq-twDZ9x_xDAL9zc/edit#gid=0 from @dehays
https://github.com/microbiomedata/nmdc-schema/blob/main/jsonschema/nmdc.schema.json#L2766
https://docs.google.com/spreadsheets/d/1T31B5gbRgS6vuK_lIg0ZLpIyafByWhlvE2hfcCy-c4k/edit#gid=0 from @mslarae13
https://data.dev.microbiomedata.org/submission/study

Some of the text entry boxes on the study submission portal page may need better display hints despite the fact that they're not modeled in the nmdc schema

study.slot_usage.name.annotations.display_hint = "Provide a name for the study your samples will belong with."
same content was already in study.slot_usage.name.description

Should these be written with a preceding verb phrase like "Enter the width of you swimming pool" or just "width of you swimming pool"
We should be consistent

we're hinting about how to enter something, not hinting on how to display it
tooltips for data entry

Could we put actual DOM paths into column A or B in SubmissionPortal_TermUpdates? Or anything else that's verifiable?


Feature request: Comments with name of view file, RazorView customization

Use case:
Comments with currently rendered viewName in development environment. For example:

<!-- View: "~/Views/MyController/MyAction.cshtml" -->
<div> some stuff </div>
<!-- End of view: "~/Views/MyController/MyAction.cshtml" -->

In case you want to know - "Hey why this div is here" without checking whole view hierarchy.
In rc1 there used to be IRazorViewFactory, where I could create my view on top of razorView, that would write comment to body before and after base.RenderAsync. There is no IRazorViewFactory anymore, and views are new'd in RazorViewEngine.CreateViewEngineResult.

One possible issue with doing this is that it assumes that the contents of the view are necessarily HTML, which isn't always the case. E.g. a partial view might render a JavaScript snippet or other type of content that is then embedded in a larger HTML document.
Certainly an interesting idea, but no plans to implement it at this time.

Still it would be great if there was extensibility point, so I can do it myself without replacing RazorViewEngine :)

@ShadowDancer understood. If you can spot where we could potentially improve the extensibility we can take a look. At this time this isn't a high priority, but if you can help point out to us what the improvement could be we'll take a look.

@Eilon Sorry, I missed your comment. I hope it is not too late already :)
I think that bringing back RazorViewFactory would be good idea, so RazorViewEngine would request view from it instead of newing it up here. RazorView,RenderAsync is already virtual, so it would work.
There is one issue though - both layout and page contents are rendered in RazorView.RenderAsync. It would be great if I could wrap just page (contents of @RenderBody) in comments, because some tools don't like comments before <html> tag (and people like to know where page starts too). Simplest solution would be to make RazorView.RenderPageAsync and RazorView.RenderLayoutAsync protected, so my derived class would wrap them in comment instead of wrapping whole RenderAsync.
I may prepare code samples if You wish.

@rynowak @pranavkm @DamianEdwards thoughts on this?

I vaguely recall speaking to @DamianEdwards about separating the view with the thing that executes it (they're intermingled today). Perhaps if we separate it. and we have the luxury of doing this since none of the implementation methods of the view are public today, it might be easier to do changes like this rather than subclass the type. Is that something we want to consider?

@pranavkm sure we can consider. Perhaps set up a mtg for later this week? Include me, @rynowak @DamianEdwards @danroth27 @davidfowl ?

I don't think this is any easier today, then it was in the past, but this isn't won't be straightforward to do unless we give the whole view engine a coat of paint.
Is this something we want to do? If that's the case, can we create a meta-issue for that and track it there. Otherwise I propose closing as wont fix. /cc @Eilon

I don't think we've heard enough customer demand to make this worthwhile. I would close.

I agree w/ closing, the use case seems very limited, and the value doesn't seem to be there compared to the potential cost.


Issue with APA Formatting when no author is specified

Description
When using references without authors, the generated output format is incorrect.
Example bib,
@misc{sdm,
  title = {Definition and objectives of systems development},
  url = {https://www.opentextbooks.org.hk/ditatopic/25323},
  language = {en},
  urldate = {2023-11-24},
  journal = {Open Textbooks for Hong Kong},
  date = {2016-01-19},
}

Expected Citation Output:
(Definition and objectives of systems development, 2016)
Actual Citation Output:
(2016)
Expected Bibliography Output:
Definition and Objectives of Systems Development. (2016, January 19). Open Textbooks for Hong Kong. https://www.opentextbooks.org.hk/ditatopic/25323
Actual Bibliography Output:
(2016, January 19). https://www.opentextbooks.org.hk/ditatopic/25323
Reproduction URL
No response
Operating system
Linux
Typst version

[X] I am using the latest version of Typst

TLDR: I can reproduce this issue.
Long version:
I added these stanzas to the end of assets/files/works.bib
@misc{book_has_author,
  title = {Book Title of Has Author},
  url = {https://www.opentextbooks.org.hk/ditatopic/25323},
  language = {en},
  urldate = {2023-11-24},
  journal = {Open Textbooks for Hong Kong},
  author = {Strong, Edward},
  date = {2016-01-19},
}

@misc{book_no_author,
  title = {Book Title of No Author},
  url = {https://www.opentextbooks.org.hk/ditatopic/25323},
  language = {en},
  urldate = {2023-11-24},
  journal = {Open Textbooks for Hong Kong},
  date = {2016-01-19},
}

and ran the test in tests/typ/meta/bibliography.typ with new test cases:
---
== Missing elements APA
See @book_has_author, @book_no_author.
#bibliography("/files/works.bib", style:"apa")
---
== Missing elements APS
See @book_has_author, @book_no_author.
#bibliography("/files/works.bib", style:"american-physics-society")
---
== Missing elements IEEE
See @book_has_author, @book_no_author.
#bibliography("/files/works.bib", style:"ieee")

The APA style reproduced this issue. I'm not sure of the APS style (may need to look up the APS style guide, but haven't got the time). The IEEE style can correctly display both items: one with and one without author.

Given that some style works and some doesn't, it appears the bug lies in the CSL data that configures the citation/bibliography formats, not in Typst or Hayagriva code themselves.
(I'm not claiming this issue; others feel free to take a crack at it)

Given that some style works and some doesn't, it appears the bug lies in the CSL data that configures the citation/bibliography formats, not in Typst or Hayagriva code themselves.

I don't think the bug lies in the .csl style. The following are outputted from Zotero's style editor with imported .bib data as well as the APA CSL style. Both entries are as expexted.

It looks to be a problem with the substitue implementation.

Thanks! Given that it's not in components as high as Typst and Hayagriva, and not in components as low as CSL files, it seems to be in the intermediate citationberg @reknih ?
Specifically https://github.com/typst/citationberg/blob/main/src/lib.rs#L2174-L2175 mentioned cs:substitute.
/// Possible children for a `cs:names` element.
#[derive(Debug, Clone, Eq, PartialEq, Hash, Deserialize, Serialize)]
#[serde(rename_all = "kebab-case")]
pub enum NamesChild {
    /// A `cs:name` element.
    Name(Name),
    /// A `cs:et-al` element.
    EtAl(EtAl),
    /// A `cs:label` element.
    Label(VariablelessLabel),
    /// A `cs:substitute` element.
    Substitute(Substitute),
}


Good getting started turotial available ?

Hello, I discovered qbit recently and its prety straight forward to install(I am using truenas scale).
Only issue I have is how to manage the configuration when installed on truenas scale.
How do I setup the configuration ?
I am not able to find a proper guide on how conif can be setup.
I also use traefik with truenas scale.
Can I just edit the config.toml file and then restart the container to pick up the changes.
Not sure how to get these on truennas scale.
- /path/to/sonarr/db:/sonarr.db:ro # This is only needed if you want episode search handling :ro means it is only ever mounted as a read-only folder, the script never needs more than read access
      - /path/to/radarr/db:/radarr.db:ro # This is only needed if you want movie search handling, :ro means it is only ever mounted as a read-only folder, the script never needs more than read access

Any help would be appreciated.

Realistically you got it, just edit the config and restart, something doesn't work, either you'll notice it or qBitrr will inform you through the logs. With regards to those path, you 'll need to provide access to the storage location where your Radarr and Sonarr configs are then place the paths to the .db file in the configs

Realistically you got it, just edit the config and restart, something doesn't work, either you'll notice it or qBitrr will inform you through the logs. With regards to those path, you 'll need to provide access to the storage location where your Radarr and Sonarr configs are then place the paths to the .db file in the configs

let me give that a try. Hopefully it will work out, thanks for the info.

If you manage, please close the issue as resolved

yeah, I am able to figure out the .db file location.


ESP32 ble mac osx not advertised

Hi Ryo, I have used your default simple BLE example. I am able to discover on windows, but can not connect via any apple devices running mac os. When connecting the devices on windows via BLE it also does not seem to register as MIDI device. Did you encounter these problems?
I read on nkolban's esp ble issues, the name exceeds the transmitting data package. I tried recuding the name to one character with no luck.
I have successfully used the serial hairless midi to loopmidi to waveform 11 and MT Power Drum Kit 2 VST, with arduino nano and uno. for anyone trying out this project.

an update, for windows. using midiberry from the microsoft store I am able to grab the bluetooth midi isntructions and route them through to loopmidi and then to waveform. I can not seem to get the drums to map with the piezo discs, for some reason the kick beat 0x50 cycles for a bit so I could see that the esp32 was sending midi instruction. still no progress on mac address


Document that nested calc()'s don't work in the dist package

@dgutride I'm going to add a blurb to our contribution docs so it's documented that we should avoid nested calc() functions.  Is there an issue we can follow on the upstream package with the bug so we know if/when it's resolved?

Yep - you can see this issue for all the details:
https://github.com/patternfly/patternfly-next/issues/1295


Fix type stability of fill_similar

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

4 of 4 (100.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.02%) to 91.07%

Totals

Change from base Build<PHONE_NUMBER>:
0.02%

Covered Lines:
1081

Relevant Lines:
1187

💛  - Coveralls


Automated Package Upgrade

:tada: This PR is included in version 26.0.105 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


acquireTokenSilent refreshes page when React.Suspense is wrapped inside MsalProvider from @azure/msal-react

Core Library
MSAL.js v2 (@azure/msal-browser)
Wrapper Library
MSAL React (@azure/msal-react)
Documentation Location
https://github.com/AzureAD/microsoft-authentication-library-for-js/blob/dev/lib/msal-react/docs/getting-started.md
Description
Libraries
@azure/msal-browser versions tested 2.17.0, 2.11.2 (probbaly also true for 2.16)
@azure/msal-react versions tested 11.0.2, 1.0.1, 1.0.0
In my application where I had just integrated the @azure/msal-browse and @azure/msal-react libraries, my calls to acquireTokenSilent, acquireTokenPopup and acquireTokenRedirect were causing my current app page to reload. I found issue #526  which was originally concerned with Vue and then Angular but not React.
So, after some hit and trial, I discovered the following problem:
Wrapping React.Suspense inside the MsalProvider was causing the current page to reload on calls to acquireTokenSilent, acquireTokenPopup and acquireTokenRedirect. Swapping the wrapping order to make React.Suspense the parent of MsalProvider fixes the issue.
So, this is my App.js' relevant code which causes the problem of reloading on token calls
<MsalProvider instance={msalInstance}>
  <React.Suspense fallback={<Loader />}>
    // Routes etc
  </React.Suspense>
</MsalProvider>

When I switched the wrapping order like this, the issue was resolved
<React.Suspense fallback={<Loader />}>
  <MsalProvider instance={msalInstance}>
    // Routes etc
  </MsalProvider>
</React.Suspense>

So here is my suggestion, include this info on the Getting started document where the wrapping part is shown.
PS: I have tried to understand the reason for why it is happening and based on the linked issue, it is possibly related to iframes and how React.Suspense works but I don't really understand it.
EDIT: I have not tested what happens if now inside this MsalProivder which is wrapped in Suspense,  I wrap Suspense in a nesting.

Thanks, we'll take a look at this and try to figure out what's going on.

@shreenath-is Can you please provide a link to a sample app that demonstrates this behavior? I was not able to reproduce this.

@shreenath-is Can you please provide a link to a sample app that demonstrates this behavior? I was not able to reproduce this.

Sure, I'll try to create a sample with the issue over the weekend.


Improving New Arrivals and Trending Books section

Is there an existing issue for this?

[X] I have searched the existing issues

Feature Description
Enhancing these two sections by adding hover effects and improving the layout
Use Case
It would make the user experience better as it would be visually appealing
Benefits
No response
Add ScreenShots

Priority
High
Record

[X] I have read the Contributing Guidelines
[X] I'm a GSSOC'24 contributor
[X] I have starred the repository

Is there an existing issue for this?

[x]  I have searched the existing issues

Feature Description
Enhancing these two sections by adding hover effects and improving the layout
Use Case
It would make the user experience better as it would be visually appealing
Benefits
No response
Add ScreenShots

Priority
High
Record

[x]  I have read the Contributing Guidelines
[x]  I'm a GSSOC'24 contributor
[x]  I have starred the repository

Hello @komalnalage, Go for it
All the Best
New Arrivals has already been done. You can work on Trending Books and Book Categories section.

Thank you @Trisha-tech i will raise the PR once done


volume mapping TLS keystore

support mapping volumes in the oeprator
mapping of TLS trust store / keystore in case of MTLS to the BE nodes

done


Order Confirmation

Hello! It is asked to confirm an order when I place a market or limit order.

How can I confirm that automatically using your module?
Thanks in advance!

Whats up bro! You can disable the order confirmation altogether from the settings, is that what you want?

Yes, it uses cache. So if I run the code on a different computer, I would have to deal with that problem again.

@jegauth I see now. There isn't a method within the API to do it as of yet, but I think it can be easily added.
If you want to work on it then I suggest you open a pull request, and start by finding the ID/Xpath to the confirm button, I can help you from there.

Hey @jegauth have you made any progress on the issue?


Update gedi-subset example to use maap-py hotfixes branch

Until the maap-py library introduces a release cadence, we're using the new hotfixes branch to unofficially "release" hot fixes that we make to it. Now that we have added some fixes for raising exceptions for HTTP errors, instead of swallowing them (and leaving us wondering why things were breaking with misleading exceptions), we want to update our maap-py dependency to point to the hotfixes branch.
In conjunction, there are some tweaks that can be made within our gedi-subset code to better handle/surface such HTTP exceptions thrown from the maap-py library, as well as some instructions for setting up the gedi-subset virtual env.

Leaving open until we tag a new release and register the new version of the algorithm in MAAP.

Tagged and released: https://github.com/MAAP-Project/maap-documentation-examples/releases/tag/gedi-subset-0.2.4


Error at writer.js, line 239

https://github.com/mcavage/node-asn1/blob/master/lib/ber/writer.js#L239
This line throws "start is not defined"

Hi @jichon
I have forked this repo in an attempt to address the outstanding patch requests and issues.
If you are still experiencing this issue please can you open an issue under:
https://github.com/stephenwvickers/node-asn1-ber
Please provide a lot of more detail, specifically a program which fails, and I will be more than happy to look into it.
Steve

I have seen there is little progress on this project over the past few years.  My project, the net-snmp project, depends on this project, so I have cloned it and migrated (i.e. copied) all the outstanding issues and pull requests.
I will be releasing a new version of my version of this project under the asn1-ber namespace on npmjs.org by the end of the week which should address this particular item (I've already pushed the current code to this namespace to reserve it).
I am now tracking all changes under my own copy at asn1-ber.  Note that this is not a "fork" but a clone and fresh commit to a new repository.  I have of course retained all copyrights and attributed back the original author.
There are quite a few projects dependant on this project, and I want to make sure there is momentum on the issues and feature requests reported.


Suggestion for collaborative exercise with a conflict

Idea by @Jyrsa: pair of pairs, first two pairs of two people start with the same basic repository with some existing files, both groups make concurrent changes, first by making well-contained small branches from master and then submit to each other for review and merging.
Then after the "clean" way has been done they can try doing any of a number of things that will cause merge conflicts and try to resolve them.

The idea is to

promote atomic minimal PRs against master (vs. assuming some order of merging)
promote communication with other contributors while doing and while orchestrating merging
create understanding of what leads to hairy merge situations


Remove Python 2

Please note that this PR will merge into a dev branch, not master.
In progress. Not yet ready for review or merge.

You can add "do not merge" label to be on the safe side. Should tests and review checks be enabled on this dev branch?

@srini100 Yes. I'm working on getting those configured. That requires an internal change.


⚠ ClamAV has degraded performance

In af15104, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 51 ms

Resolved: ClamAV performance has improved in 7eebd36.


[entropy_src/rtl] add a startup phase for health testing with its set of window and threshold regs

The requirements for the startup health tests appear to be different from the continuous health test phases. For this reason, an extra set of threshold registers and a new window registers need to be added. With these new values, the hardware sequencer can choose between the boot phase, the startup phase, and the continuous phase.
The attached diagram shows the health test phases and what the new hardware requirements are.
ht_phases.pdf

For entropy meeting discussion: @tjaychen @martin-lueker @cdgori @felixmiller @moidx

forget @senelson7 @zi-v

Meeting review was that the current thresholds and window register should be re-programmed when transitioning from startup phase to continuous checking phase. This means less registers and documentation updates. However, to make this work, the stop/start feature is needed, and probably a per transaction register lock function.

Some comments regarding health tests with reference to NIST.SP.800-90B.
In '4.4.2 Adaptive Proportion Test' section, the flow and window size is defined as follows:
"The test takes a sample from the noise source, and then counts the number of times that the same value occurs within the next W-1 samples. If that count reaches the cutoff value C, the test declares an error. The window size W is selected based on the alphabet size, and shall be assigned to 1024 if the noise source is binary (that is, the noise source produces only two distinct values) and 512 if the noise source is not binary (that is, the noise source produces more than two distinct values)"
From the above, I gather that:

We are required to test only one 'bucket' at a time (it is not forbidden to test several buckets in parallel, just need to manage the false-positive rate).
For our case, the APT window size is strictly defined to 512 samples. It doesn't sound like it is allowed to run any different window size (neither larger nor smaller).

Section '4.3 Requirements for Health Tests' , subsection 4 says:
"The entropy source's startup tests shall run the continuous health tests over at least 1024 consecutive samples. The startup tests may include other tests defined by the developer. The samples subjected to startup testing may be released for operational use after the startup tests have been passed, or may be discarded at any time."
From the combination of the two above quotes, my best guess is that in our case, we should run the ATP twice with regular (continuous test) settings and only after both passed, we can start releasing bits to the entropy consumers.
To sum up, I am not sure a reconfiguration is needed or even allowed. Moreover, during the reconfiguration, we might miss some samples which may be disallowed by itself. I suggest we reiterate with a lab to make sure we do the right thing.

ht_phases2.pdf
Added updated drawing based on discussions.


rows menu is hidden when sticky first column is enabled

Describe the bug
When scrolling vertically, the menu to the left of the rows is hidden by the first column.
Expected behavior
The menu should be visible if the option sticky first column is enabled in settings
Screenshots
https://user-images.githubusercontent.com/38974541/189478462-ece56d87-915d-49d7-85a4-b50476a677fa.mov
Desktop (please complete the following information):

macOS 12.3.1
Obsidian 0.15.9

It is a design decision to give importance to the information in that column


Incompatible C++ compiler standard

When running make following the installation instructions in README.md, an error is raised:
libtorch/include/ATen/ATen.h:4:2: error: #error C++17 or later compatible compiler is required to use ATen.

This error was reproduced using both the CPU-only nightly (accessed on 19/09/23) and CPU-only (stable) 2.0.1 libtorch binaries.
This appears to be due to pytorch now requiring support for C++17:

A compiler that fully supports C++17, such as clang or gcc (especially for aarch64, gcc 9.4.0 or newer is required)

Versions used:

cmake: 3.16.3
gcc:  9.4.0

Thanks Elliott.
Did you manage to get this to work in an updated C++ minimum environment?
If so might be worth a PR to keep us up to date. Can you do this?
Also an update to the README to make it clear to users that they need to select the appropriate binary for their system if downloading libtorch.


Gradle -PhadoopVersion bug

When I specify -PhadoopVersion to build with Gradle, for example -PhadoopVersion=2.7.2, this will attach the version number to every hadoop package.
Other Hadoop packages seem to use the same version number, but hadoop-core doesn't.
1.2.1 was the latest release for Hadoop Core, and they changed the name to Hadoop Common.
This causes an error because Gradle cannot find hadoop-core:2.7.2 as shown below. It compiles successfully when I hardcode the version for hadoop-core to 1.2.1.

Could not resolve all dependencies for configuration ':gobblin-compaction:runtime'.
Could not find org.apache.hadoop:hadoop-core:2.7.2.
Required by:
com.linkedin.gobblin:gobblin-compaction:0.6.2-153-g7ee7b7b-hadoop1
com.linkedin.gobblin:gobblin-compaction:0.6.2-153-g7ee7b7b-hadoop1 > com.linkedin.gobblin:gobblin-api:0.6.2-153-g7ee7b7b-hadoop1
com.linkedin.gobblin:gobblin-compaction:0.6.2-153-g7ee7b7b-hadoop1 > com.linkedin.gobblin:gobblin-utility:0.6.2-153-g7ee7b7b-hadoop1
com.linkedin.gobblin:gobblin-compaction:0.6.2-153-g7ee7b7b-hadoop1 > com.linkedin.gobblin:gobblin-metrics:0.6.2-153-g7ee7b7b-hadoop1
com.linkedin.gobblin:gobblin-compaction:0.6.2-153-g7ee7b7b-hadoop1 > com.linkedin.gobblin:gobblin-core:0.6.2-153-g7ee7b7b-hadoop1
com.linkedin.gobblin:gobblin-compaction:0.6.2-153-g7ee7b7b-hadoop1 > com.linkedin.gobblin:gobblin-core:0.6.2-153-g7ee7b7b-hadoop1 > com.linkedin.gobblin:gobblin-tunnel:0.6.2-153-g7ee7b7b-hadoop1
com.linkedin.gobblin:gobblin-compaction:0.6.2-153-g7ee7b7b-hadoop1 > com.linkedin.gobblin:gobblin-core:0.6.2-153-g7ee7b7b-hadoop1 > com.linkedin.gobblin:gobblin-hive-registration:0.6.2-153-g7ee7b7b-hadoop1

Looks like a bug. I checked fails for any 2.x.x version, except for the default which is 2.3.0.

Actually I believe the solution is to just include -PuseHadoop2 in the build script. Although that shouldn't really be necessary so I will leave this Issue open as a bug.

Closing this as a duplicate of https://github.com/linkedin/gobblin/issues/825 which has more details


Detected Entities Report - Add support for EUM WEB Applications

Add configuration report on the following:
Pages
Rules
Synthetics
Geo Locations

Fixed by d26c4d64bb1dfb895a110ecf182ac7340e877d72


Build got failed after 29 minutes with failure message.

Please do not open issues relating to Zimbra itself or the operating system.  Any issues opened here should ONLY be for issues relating to the build scripts that I provide and nothing more.  You should be analysing output and error messages yourself before posting here.  Any other issues will be closed automatically.
Describe the bug
The build got failed
To Reproduce
Steps to reproduce the behavior:

Run this command - ./zimbra-build-helper.sh --build-zimbra
After running for 29 minutes it shows the error as
'BUILD FAILED
/home/git/zimbra/zm-mailbox/build.xml:6: The following error occurred while executing this line:
/home/git/zimbra/zm-mailbox/store/build.xml:295: Problem happened while installing modules - see output for details'

Expected behavior
Expected to get it installed succesfully
Screenshots

Desktop (please complete the following information):

OS: AlmaLinux
Browser: Mozilla Firefox
Version 128.4.0-1.el8_10

Additional context
Add any other context about the problem here.

AlmaLinux 8 or 9?

AlmaLinux 8

OK, I'll take a look tomorrow need to make a VM with Alma so I can find where the problem is.

Sure, looking forward to hear with you.

I'm guessing a Java conflict with multiple JRE/JDK installed, but I'll confirm tomorrow.

Yes, I will try it after installing the new OS.

I have seen something similar a few years back when PATH in the build environment picked up /opt/zimbra/common/bin/ before the systems directory.
Verify you are pulling from the OS java and not /opt/zimbra/common/bin?
% id
jad
$ which java
/usr/bin/java
It's a long shot but a quick check instead of reloading an OS.
Jim
----- On Nov 21, 2024, at 11:58 AM, Adisingh001 @.***> wrote:

Yes, I will try it after installing the new OS.

—
Reply to this email directly, [
https://github.com/ianw1974/zimbra-build-scripts/issues/104#issuecomment-2492145255
| view it on GitHub ] , or [
https://github.com/notifications/unsubscribe-auth/ACPVASRIQZELJYR4DG7FVP32BY3NFAVCNFSM6AAAAABSHV7ZXSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIOJSGE2DKMRVGU
| unsubscribe ] .
You are receiving this because you are subscribed to this thread. Message ID:
@.***>

Generally, a build system shouldn't be used for every day use, or even on a server where Zimbra is installed.  It is recommended that this is done separately from a live system.  It's quite easy to have a small VM purely for building purposes - I have a VM with 2vcpu, 4gb of ram and a 40GB hard disk that I use purely for building Zimbra and nothing else.  That way it's very simple to avoid these types of conflicts.
That way, you don't have to fix or get around issues when building on your Zimbra server, or on your desktop or whatever that may have conflicting packages installed.

yes, I am using a spare server for zimbra build which will be used only for zimbra. I am trying with new OS, we'll let you know further details.

Make sure whatever OS you install, that it is a minimal installation.  If you install a graphical environment as well, you run the risk of installing multiple versions of Java and it will never work and provide you with a build.  My website has all versions for 9 and 10 built using these scripts, so the problem is your installation.
These scripts work providing you install a minimal server and then run the script to install the required dependencies.

Well, I just created myself an AlmaLinux 8 VM by doing a minimal installation, and then built Zimbra OK

As per the help parameter:
[root@alma zimbra-build-scripts]# ./zimbra-build-helper.sh --help

Zimbra Build Helper script!

Valid parameters are as follows:

  --install-deps	 - Installs required dependencies
  --build-zimbra	 - Builds Zimbra
  --cleanup		 - Cleanup previous attempted builds
  --help		 - Shows this help screen

At the beginning of the script these variables can be changed if you want:

MAINDIR=/home/git
PROJECTDIR=zimbra

Build summary step-by-step:

  1. Generate ssh key: ssh-keygen -t rsa -b 4096 -C "your_email@address"
  2. Upload this to your GitHub profile: https://github.com/settings/keys
  3. Only OpenJDK 8 can be installed on the build server, remove other versions
  4. Run:./zimbra-build-helper.sh --install-deps
  5. Copy either config.build.9 or config.build.10 to config.build
  6. Run:./zimbra-build-helper.sh --build-zimbra

Point 3 to ensure you have only OpenJDK 8 installed on your system. I expect you are building on a machine you use regularly for other things, maybe your desktop or something since you mentioned about Firefox being installed. Since you most likely need the newer Java versions, if you cannot remove them before building Zimbra, then I suggest you do the same as me - make a clean VM minimal installation and use this VM only for building Zimbra.
[root@alma zimbra-build-scripts]# rpm -qa | grep -i jdk
copy-jdk-configs-4.0-2.el8.noarch
java-1.8.0-openjdk-<IP_ADDRESS>2.b06-2.el8.x86_64
java-1.8.0-openjdk-devel-<IP_ADDRESS>2.b06-2.el8.x86_64
java-1.8.0-openjdk-headless-<IP_ADDRESS>2.b06-2.el8.x86_64

that is how the system should look. Therefore the scripts work fine, the problem is your machine has conflicting packages installed.

For me the same thing is showing which you have sent in the ss, next what I need to do can you please guide me with the steps.


Subscription doesn't return anything

Hi,
trying to subscribe to a collection/publication but nothing happen.
On client-side we need to do asteroid.subscribe("mycollection-name")
On server-side i did a "mycollection-name" publication with a log inside to check if it return something.
On server-side it seems to be ok, but on client-side, the Map has nothing inside...

Hi @Rebolon,
if returns a Map, the mixin seems work fine.
Can you provide some snippet of your implementation?

Hi @davidebianchi,
In fact i did a mistake because i missed the fact that asteroid.subscribe returned an EventEmitter.
Now i do this
`
let subscription = asteroid.subscribe("myPublication");
let items;
subscription.ready(() => {
items = asteroid.collections.get("myPublication");
});
`
and the items Map is filled,
sorry for all.


Edit Response

Is possible to edit the respose tab into atom editor?

Thanks for reporting, I think it's a duplicate though. See https://github.com/kdzwinel/betwixt/issues/10


Allow extensions to mutate the search result list

Currently it is possible to alter the search query, as SearchForm->getResults calls $this->extend('updateSearchQuery', $sql);.
But there is no way to modify the returned paginated list variable from the SearchForm->getResults method. (Unless you override the class through the Injector)
Would it make sense to also call extensions right before returning the search result?
Something like this:
        $list = new PaginatedList($objects);
        $list->setPageStart($start);
        $list->setPageLength($pageLength);
        $list->setTotalItems($totalCount);
        $list->setLimitItems(false);

        // Call extensions which can mutate the search result before returning it.
        $this->extend('updateSearchResultList', $list, $keywords);

        return $list;

Sure why not. If you make a Pull Request, I'll merge it. I was wondering what kind of alteration you'd like to make?

I was wondering what kind of alteration you'd like to make?

I quickly realized after creating this issue that I don't really need the extension. I currently override the getResults method through the Injector, because I implemented my own search/filter logic for a site which had translated content with silverstripe-fluent, and I don't think its a good idea to do all this in an extension hook
I tried to delete this issue after creating it but it said only the owner of this repository can delete it, so I will close this issue. :)


Update in Colander/iso8601 breaking the server

Am trying to start senic-hub on a Linux machine.
There is a fresh issue with Colander and iso8601 that crashes the server after a fresh installation of senic-hub.
Steps:
(Assuming arbitrary way of starting a virtualnv.
I'm using virtualenvwrapper.)
git clone https://github.com/getsenic/senic-hub.git
cd senic-hub/
mkvirtualenv senic-hub-env
wget https://github.com/tfriedel/python-lightify/archive/1bb1db0e7bd5b14304d7bb267e2398cd5160df46.zip
unzip 1bb1db0e7bd5b14304d7bb267e2398cd5160df46.zip
cd python-lightify-1bb1db0e7bd5b14304d7bb267e2398cd5160df46/
pip install .
cd ..
rm -rf 1bb1db0e7bd5b14304d7bb267e2398cd5160df46.zip python-lightify-1bb1db0e7bd5b14304d7bb267e2398cd5160df46
pip install .
pip install waitress
pserve development.ini

Error:
File ".../senic-hub-env/lib/python3.5/site-packages/colander/iso8601.py", line 3, in <module>
    from iso8601.iso8601 import (parse_date, ParseError, Utc, FixedOffset, UTC, ZERO, ISO8601_REGEX)
ImportError: cannot import name 'Utc'

For now just hacked it to use the older version of iso8601. Would guess this will soon be fixed at the source.
pip uninstall iso8601
pip install iso8601==0.1.11

Fixed on colander side.
Working for
colander==1.4
iso8601==0.1.12


Windows jdk8_j9 directories not being cleaned up properly

Needs investigating and resolving since this is chewing up 3Gb at a time, and looks like it's happening on every run from the date stamps shown here:
Administrator@build-softlayer-win2012r2-x64-1 /cygdrive/c/Users/jenkins
$ ls -dl /cygdrive/c/Users/jenkins/jdk*
drwx------+ 1 jenkins None 0 Aug 21 05:26 /cygdrive/c/Users/jenkins/jdk11_j9
drwx------+ 1 jenkins None 0 Aug 21 07:07 /cygdrive/c/Users/jenkins/jdk8_j9
drwx------+ 1 jenkins None 0 Aug  1 05:04 /cygdrive/c/Users/jenkins/jdk8_j9_ws-cleanup_1533117858204
drwx------+ 1 jenkins None 0 Aug  1 07:00 /cygdrive/c/Users/jenkins/jdk8_j9_ws-cleanup_1533124822719
drwx------+ 1 jenkins None 0 Aug  1 07:39 /cygdrive/c/Users/jenkins/jdk8_j9_ws-cleanup_1533127144268
drwx------+ 1 jenkins None 0 Aug  2 07:00 /cygdrive/c/Users/jenkins/jdk8_j9_ws-cleanup_1533211214098
drwx------+ 1 jenkins None 0 Aug  2 07:38 /cygdrive/c/Users/jenkins/jdk8_j9_ws-cleanup_1533213470648
drwx------+ 1 jenkins None 0 Aug  3 07:00 /cygdrive/c/Users/jenkins/jdk8_j9_ws-cleanup_1533297610261
drwx------+ 1 jenkins None 0 Aug  3 07:38 /cygdrive/c/Users/jenkins/jdk8_j9_ws-cleanup_1533299895713
drwx------+ 1 jenkins None 0 Aug  6 07:00 /cygdrive/c/Users/jenkins/jdk8_j9_ws-cleanup_1533556813663
drwx------+ 1 jenkins None 0 Aug  6 07:38 /cygdrive/c/Users/jenkins/jdk8_j9_ws-cleanup_1533559075726
drwx------+ 1 jenkins None 0 Aug  7 07:00 /cygdrive/c/Users/jenkins/jdk8_j9_ws-cleanup_1533643212058
drwx------+ 1 jenkins None 0 Aug  7 07:38 /cygdrive/c/Users/jenkins/jdk8_j9_ws-cleanup_1533645498848
drwx------+ 1 jenkins None 0 Aug  8 07:00 /cygdrive/c/Users/jenkins/jdk8_j9_ws-cleanup_1533729612436
drwx------+ 1 jenkins None 0 Aug  8 07:38 /cygdrive/c/Users/jenkins/jdk8_j9_ws-cleanup_1533731921716
drwx------+ 1 jenkins None 0 Aug  9 07:00 /cygdrive/c/Users/jenkins/jdk8_j9_ws-cleanup_1533816012379
drwx------+ 1 jenkins None 0 Aug  9 07:39 /cygdrive/c/Users/jenkins/jdk8_j9_ws-cleanup_1533818334766
drwx------+ 1 jenkins None 0 Aug 10 07:00 /cygdrive/c/Users/jenkins/jdk8_j9_ws-cleanup_1533902415220
drwx------+ 1 jenkins None 0 Aug 10 07:37 /cygdrive/c/Users/jenkins/jdk8_j9_ws-cleanup_1533904670310
drwx------+ 1 jenkins None 0 Aug 10 11:16 /cygdrive/c/Users/jenkins/jdk8_j9_ws-cleanup_1533917810290
drwx------+ 1 jenkins None 0 Aug 10 11:54 /cygdrive/c/Users/jenkins/jdk8_j9_ws-cleanup_1533920076639
drwx------+ 1 jenkins None 0 Aug 10 16:58 /cygdrive/c/Users/jenkins/jdk8_j9_ws-cleanup_1533938331807
drwx------+ 1 jenkins None 0 Aug 10 17:36 /cygdrive/c/Users/jenkins/jdk8_j9_ws-cleanup_1533940563779
drwx------+ 1 jenkins None 0 Aug 12 07:49 /cygdrive/c/Users/jenkins/jdk8_j9_ws-cleanup_1534078194380
drwx------+ 1 jenkins None 0 Aug 12 08:31 /cygdrive/c/Users/jenkins/jdk8_j9_ws-cleanup_1534080670900
drwx------+ 1 jenkins None 0 Aug 13 04:30 /cygdrive/c/Users/jenkins/jdk8_j9_ws-cleanup_1534152616656
drwx------+ 1 jenkins None 0 Aug 13 05:07 /cygdrive/c/Users/jenkins/jdk8_j9_ws-cleanup_1534154841537
drwx------+ 1 jenkins None 0 Aug 13 07:30 /cygdrive/c/Users/jenkins/jdk8_j9_ws-cleanup_1534163396674
drwx------+ 1 jenkins None 0 Aug 13 08:09 /cygdrive/c/Users/jenkins/jdk8_j9_ws-cleanup_1534165789609
drwx------+ 1 jenkins None 0 Aug 13 13:12 /cygdrive/c/Users/jenkins/jdk8_j9_ws-cleanup_1534183955234
drwx------+ 1 jenkins None 0 Aug 13 13:57 /cygdrive/c/Users/jenkins/jdk8_j9_ws-cleanup_1534186628502
drwx------+ 1 jenkins None 0 Aug 13 15:00 /cygdrive/c/Users/jenkins/jdk8_j9_ws-cleanup_1534190399944
drwx------+ 1 jenkins None 0 Aug 13 15:37 /cygdrive/c/Users/jenkins/jdk8_j9_ws-cleanup_1534192650475
drwx------+ 1 jenkins None 0 Aug 15 10:26 /cygdrive/c/Users/jenkins/jdk8_j9_ws-cleanup_1534346808837
drwx------+ 1 jenkins None 0 Aug 15 11:04 /cygdrive/c/Users/jenkins/jdk8_j9_ws-cleanup_1534349044787
drwx------+ 1 jenkins None 0 Aug 16 07:00 /cygdrive/c/Users/jenkins/jdk8_j9_ws-cleanup_1534420814319
drwx------+ 1 jenkins None 0 Aug 16 07:37 /cygdrive/c/Users/jenkins/jdk8_j9_ws-cleanup_1534423062260
drwx------+ 1 jenkins None 0 Aug 17 07:00 /cygdrive/c/Users/jenkins/jdk8_j9_ws-cleanup_1534507237842
drwx------+ 1 jenkins None 0 Aug 17 07:37 /cygdrive/c/Users/jenkins/jdk8_j9_ws-cleanup_1534509453680
drwx------+ 1 jenkins None 0 Aug 20 07:00 /cygdrive/c/Users/jenkins/jdk8_j9_ws-cleanup_1534766417760
drwx------+ 1 jenkins None 0 Aug 20 07:40 /cygdrive/c/Users/jenkins/jdk8_j9_ws-cleanup_1534768820949
drwx------+ 1 jenkins None 0 Aug 21 06:30 /cygdrive/c/Users/jenkins/jdk8_j9_ws-cleanup_1534851015315
drwx------+ 1 jenkins None 0 Aug 21 07:07 /cygdrive/c/Users/jenkins/jdk8_j9_ws-cleanup_1534853251023
drwx------+ 1 jenkins None 0 Aug 21 04:54 /cygdrive/c/Users/jenkins/jdk9_j9
drwx------+ 1 jenkins None 0 Aug 20 10:33 /cygdrive/c/Users/jenkins/jdk9_j9-OLD

Administrator@build-softlayer-win2012r2-x64-1 /cygdrive/c/Users/jenkins
$

I think this is what you're looking for
https://issues.jenkins-ci.org/browse/JENKINS-24824

https://issues.jenkins-ci.org/browse/JENKINS-24824 is now closed and https://ci.adoptopenjdk.net/job/build-scripts/job/jobs/job/jdk8u/job/jdk8u-windows-x64-openj9/ looks a lot happier. Can this be closed?

24824 was closed before this issue was opened. 53579 has since been opened and is unresolved. I haven't tested this in a while but as a workaround at OpenJ9 we use cleanWs notFailBuild: true, disableDeferredWipeout: true, deleteDirs: true.

From what I've seen we only use cleanWs notFailBuild: true in our scripts. This might be what has caused the recent space shortages on some machines

Adding to top priorities as not cleaning up our followers gets us in trouble.

@AdamBrousseau Do you use this work around for all platforms and archs or just JDK8/OpenJ9?

We use it on all our builds. I think that line has changed a few times for various reasons. I wouldn't mind trying to undo some of it but it's working at the moment so not a high priority.


Promise.join does not call handler with bound value

What version of bluebird is the issue happening on?
3.5.0

What platform and version? (For example Node.js 0.12 or Google Chrome 32)
Node.js 0.10 - but should be platform independent

Did this issue happen with earlier version of bluebird?
Unknown

The following illustrates the behaviour:
Promise.join(Promise.resolve(1),
             function(res1) { console.log("this.x:", this.x); }
).bind({ x: 3 });

This prints this.x: undefined. A workaround is to use all+spread:
Promise.all([Promise.resolve(1)])
.bind({ x: 3 })
.spread(function(res1) { console.log("this.x:", this.x); });

which prints this.x: 3 as expected.

The value is bound after join, so this is working as intended. Similar rules apply to all static methods, e.g. Promise.try(fn).bind({x: 3}) will not assign a this value in fn


Using with nuxt.js - The client-side rendered virtual DOM tree is not matching server-rendered content.

Hi!
My configuration:
nuxt.config.js:
  plugins: [
    { src: '~plugins/social.js', ssr: false },
  ],

social.js:
import Vue from 'vue'
import SocialSharing from 'vue-social-sharing'

Vue.use(SocialSharing)

And then in a .vue file pasted <social-sharing url="https://vuejs.org/" inline-template>[...]
When entering the page I get on the console:
[Vue warn]: The client-side rendered virtual DOM tree is not matching server-rendered content. This is likely caused by incorrect HTML markup, for example nesting block-level elements inside
, or missing
. Bailing hydration and performing full client-side render.

I understand the error but don't know how to fix it.

Hello @awronski,
I never tried vue-social-sharing with nuxt.js. But it works well on classic SSR so there is no reason that it shouldn't work with nuxt.
Could you give me more lines of your vue file so that I can replicate the bug?

@nicolasbeauvais Thanks for fast reply.
Here is the demo:
https://nuxt-social-sharing.glitch.me/
open console to check the error

I created a blank nuxt app using https://github.com/nuxt/starter
here is the config:
module.exports = {
  loading: false,
  plugins: ['plugins/toto'],
  build: {
    vendor: ['vue-social-sharing']
  },

  head: {
    //
  }
}

content of vue-social-sharing.js in the plugins directory:
import Vue from 'vue'
import SocialSharing from 'vue-social-sharing'

Vue.use(SocialSharing)

content of my index.vue file:
<template>

      <social-sharing url="https://vuejs.org/" inline-template>

          <network network="facebook">
             Facebook
          </network>
          <network network="googleplus">
             Google +
          </network>

      </social-sharing>

</template>

And everything works great without any warning :angel: Are you sure that this is coming from vue-social-sharing ?

Hi There!
Thanks for your help, the problem was configuration.
I had:
  plugins: [
    { src: '~plugins/social.js', ssr: false }
  ],

And it should be:
  plugins: [
    { src: '~plugins/social.js', ssr: true }
  ],

ssr: true
or just plugins: ['plugins/social.js'],
Once again thanks fot help!

Thank you too, this will probably be usefull for other users :)

You could try wrapping the component with , or moving all dom manipulations to the mounted lifecycle hook.