Issue with react testing library

Hi,
I am having issues when I upgraded to the latest version of craco with jest and react-testing-library.
I created test-util.js file with the following code.
// Add some helpful assertions from jest-dom.
// See: https://github.com/gnapse/jest-dom
import 'jest-dom/extend-expect';

import * as React from 'react';
import { render } from '@testing-library/react';
import { ThemeProvider } from 'styled-components';

import { Colors } from '../src/shared/util/Colors';
import { Provider } from 'mobx-react';

const AllTheProviders = ({ children, stores }) => {
  return (
    <Provider {...stores}>
      <ThemeProvider theme={Colors}>{children}</ThemeProvider>
    </Provider>
  );
};

const customRender = (ui, options) => render(ui, { wrapper: AllTheProviders, ...options });

// re-export everything
export * from '@testing-library/react';

// override render method
export { customRender };

And my craco config is
const CracoAntDesignPlugin = require('craco-antd');
const path = require('path');

module.exports = {
  eslint: {
    enable: false
  },
  babel: {
    plugins: [['@babel/plugin-transform-typescript'], ['@babel/plugin-proposal-decorators', { legacy: true }]]
  },
  plugins: [
    {
      plugin: CracoAntDesignPlugin,
      options: {
        customizeThemeLessPath: path.resolve(path.join(__dirname, 'src/themes', 'theme.less'))
      }
    }
  ]
};

when i run craco test --env=jsdom. I get error in test-utils.js file Unexpected token, expected "</>/<=/>="
Any help is appreciated

Hi @Anoupz
What version of CRA do you use?

Also, does it work if you remove dependencies (styled-component, mobx, antd, @testing-library/react) ?
If it does, can you isolate which dependency cause the problem.

Hi @patricklafrance,
Thanks for the response. I tried to remove styled-components and mobx providers but still the same error.
Per react-testing library which is now under @testing-library/react. We could create a wrapper component which provides global render function with all the providers and themes and u can test out the component.
I use the latest version of Craco. With Older verion of Craco 3.x.x things works fine. I use ts-loader for my typescript projects along with craco.
  "@babel/plugin-proposal-decorators": "^7.4.4",
    "@babel/plugin-transform-typescript": "^7.4.4",
    "@craco/craco": "5.2.1",
    "@testing-library/dom": "^5.2.0",
    "@testing-library/react": "^8.0.1",
    "@types/classnames": "^2.2.7",
    "@types/enzyme": "^3.9.1",
    "@types/graphql": "^14.2.0",
    "@types/jest": "^24.0.12",
    "@types/lodash": "^4.14.123",
    "@types/mobx-apollo": "0.0.2",
    "@types/moment-timezone": "^0.5.12",
    "@types/node": "^12.0.8",
    "@types/react": "^16.8.15",
    "@types/react-dom": "^16.8.4",
    "craco-antd": "1.11.0",
    "craco-workbox": "^0.1.0",
    "env-cmd": "^9.0.3",
    "jest-dom": "^3.1.4",
    "jest-styled-components": "^6.3.1",
    "prettier": "^1.17.0",
    "react-scripts": "3.0.1",
    "source-map-explorer": "^2.0.0",
    "tslint": "^5.17.0",
    "tslint-config-prettier": "^1.18.0",
    "tslint-plugin-prettier": "^2.0.1",
    "tslint-react": "^4.0.0",
    "typescript": "^3.2.4",
    "url-loader": "^2.0.0"

My working version devDepencies and cracoConfig is below.
"devDependencies": {
    "@craco/craco": "3.2.3",
    "@types/classnames": "^2.2.7",
    "@types/enzyme": "^3.1.15",
    "@types/graphql": "^14.0.5",
    "@types/jest": "^23.3.13",
    "@types/lodash": "^4.14.120",
    "@types/mobx-apollo": "0.0.2",
    "@types/moment-timezone": "^0.5.12",
    "@types/node": "^10.12.18",
    "@types/react": "^16.7.20",
    "@types/react-dom": "^16.0.11",
    "babel-core": "^7.0.0-bridge.0",
    "craco-antd": "1.10.0",
    "craco-workbox": "^0.1.0",
    "env-cmd": "^8.0.2",
    "extract-text-webpack-plugin": "^4.0.0-beta.0",
    "jest-dom": "^3.1.2",
    "jest-environment-jsdom": "^24.0.0",
    "jest-styled-components": "^6.3.1",
    "prettier": "^1.16.1",
    "react-addons-test-utils": "^15.6.2",
    "react-scripts": "2.1.3",
    "react-scripts-ts": "4.0.8",
    "react-test-renderer": "^16.7.0",
    "react-testing-library": "^5.4.4",
    "source-map-explorer": "^1.6.0",
    "ts-import-plugin": "^1.5.5",
    "ts-jest": "20.0.14",
    "ts-loader": "^5.3.3",
    "tslint-plugin-prettier": "^2.0.1",
    "typescript": "^3.2.4",
    "url-loader": "^1.1.2",
    "webpack-filter-warnings-plugin": "^1.2.1"
  }

Craco Config.js

const tsImportPluginFactory = require('ts-import-plugin');
const { getLoader, loaderByName } = require('@craco/craco');
const CracoAntDesignPlugin = require('craco-antd');
const path = require('path');
const FilterWarningsPlugin = require('webpack-filter-warnings-plugin');

module.exports = {
  webpack: {
    // Silence mini-css-extract-plugin generating couple of warnings for antd CSS ordering.
    // See: https://github.com/webpack-contrib/mini-css-extract-plugin/issues/250
    plugins: [
      new FilterWarningsPlugin({
        exclude: /mini-css-extract-plugin[^]*Conflicting order between:/
      })
    ]
  },
  plugins: [
    {
      plugin: {
        overrideWebpackConfig: ({ webpackConfig, context: { env, paths } }) => {
          const {
            match: { loader: tsLoader }
          } = getLoader(webpackConfig, loaderByName('ts-loader'));
          tsLoader.options = {
            ...tsLoader.options,
            getCustomTransformers: () => ({
              before: [
                tsImportPluginFactory({
                  libraryDirectory: 'es',
                  libraryName: 'antd',
                  style: true
                })
              ]
            })
          };
          if (env === 'production') {
            try {
              const workboxConfig = require(path.join(paths.appPath, 'workbox.config.js'));

              webpackConfig.plugins.forEach(plugin => {
                if (plugin.constructor.name === 'GenerateSW') {
                  plugin.config = workboxConfig(plugin.config);
                }
              });
            } catch (error) {
              process.exit(1);
            }
          }
          return webpackConfig;
        }
      }
    },
    {
      plugin: CracoAntDesignPlugin,
      options: {
        customizeThemeLessPath: path.resolve(path.join(__dirname, 'src/themes', 'theme.less'))
      }
    }
  ]
};


Using Scorecard GitHub Action reduces the Token-Permissions score

Describe the bug
urllib3 recently added the Scorecard GitHub Action to its repository. After adding this we observed our "Token-Permissions" score being 9/10 instead of the previous value of 10/10. This was due to:

Warn: jobLevel 'security-events' permission set to 'write': .github/workflows/scorecards.yml:16: update your workflow using https://app.stepsecurity.io/secureworkflow/syndicate-lang/syndicate-js/scorecards.yml/main?enable=permissions

This is because the action wants the permission security-events: write which is a permission that is docked points if given to any GitHub Action.
Reproduction steps
Steps to reproduce the behavior:

Add the Scorecard GitHub Action w/ security-events: write
Run Scorecard on the repository
Observe an imperfect score due to Scorecard GitHub Action config

Expected behavior
A clear and concise description of what you expected to happen.
Using the Scorecard GitHub Action shouldn't reduce the project's scorecard score.

@spencerschrock fyi

@sethmlarson slightly off-topic, but I am curious why you got a remediation link for syndicate-lang/syndicate-js? That seems like a different project, which does not have GitHub Actions workflows. For context, I am the maintainer for https://github.com/step-security/secure-workflows (which hosts APIs for app.stepsecurity.io), so want to understand if this is due to a bug...Thanks!

Great question! I copied this output from this page: https://deps.dev/pypi/urllib3 to save me a second in running scorecard to get the output.

They are just taking the information from the scorecard result using the BQtable. Let's verify what in the BQTable for this project.

Great find! So running the check locally seems to work fine, but our cron job table spits out the wrong result (which then propagates to deps.dev). Looks like this might be an interesting memory corruption bug - i.e we are persisting memory across runs of Scorecard which we shouldn't be doing.
@spencerschrock could you look into debugging this?

I highly suspect this line of code here: https://github.com/ossf/scorecard/blob/main/remediation/remediations.go#L47

Wrapping up tests for the commit for the original issue. can take a look at the cron job after

I think there is a bigger problem here we need to address (maybe in a separate issue) - if we can so easily break the results shown on deps.dev, it'll be hard to build any kind of trust on Scorecard results. We need to tighten how these results get published. @ brianrussell2

Re-opening. Can use this issue to track the cron job bug too.

I highly suspect this line of code here: https://github.com/ossf/scorecard/blob/main/remediation/remediations.go#L47
👍

The problem is removing the once.Do code would fix the issue with "stale" repo/branch names, but it introduces data races which cause the unit tests to fail.  The issue is the raw results are generated in a different package (raw) than where the remediation text is generated (evaluation).
If we want to support concurrency (especially for something large like the cron jobs), I think the answer is dependency injection. That would just require changes to function signatures / raw data structs to accommodate it and I haven't found the cleanest way of doing it.

Just a thought: remediation should belong in checks/evaluation instead of being a separate package (also maybe don't expose the remediation related fns)?
If every check generates its own remediation, it makes sense that it should just get generated on a per check basis inside checks/evaluation. @laurentsimon who may have more insights.

Just a thought: remediation should belong in checks/evaluation instead of being a separate package (also maybe don't expose the remediation related fns)?

no strong opinion from me here. I think the long-term plan was to take evaluation/ out of the check some time, which is why the remediation was out. But either works for me.

If every check generates its own remediation, it makes sense that it should just get generated on a per check basis inside checks/evaluation. @laurentsimon who may have more insights.

Maybe a simple fix is to remove the Once. I think I added this to avoid having the remediation function returns an error (and to have to check for the error in all calls), but if this Once is creating too many problems we can jut remove it. We don't really need the caching since the repo client does it already. Would this help?

Just a thought: remediation should belong in checks/evaluation instead of being a separate package (also maybe don't expose the remediation related fns)?
If every check generates its own remediation, it makes sense that it should just get generated on a per check basis inside checks/evaluation. @laurentsimon who may have more insights.

I was still thinking there would need to be some sort of change here to bridge the gap between the checks and checks/evaluation packages. The checker.CheckRequest has info about the source of the request through RepoClient, which can provide repo and branch names for the Token-Permissions remediation text.

Maybe a simple fix is to remove the Once

I believe this leads to the data race problems I was talking about above. All checks are spun up as separate goroutines as part of pkg.RunScorecards, and multiple checks (Token-Permissions and Pinned-Dependencies) could be setting the globals in the remediation package when calling Setup. This causes go test or make unit-test to fail
WARNING: DATA RACE
Write at 0x000001f1b530 by goroutine 62:
  github.com/ossf/scorecard/v4/remediation.Setup()

I meant remove the global as well if the info can be retrieved via repo client direcly.

I was still thinking there would need to be some sort of change here to bridge the gap between the checks and checks/evaluation packages.

Not sure why this is needed? We can simply move all the remediation logic into checks/evaluation and remove the Once?

It's the end of the day, so I might just be missing something obvious, but my thought is:
Inside checks/evaluation where the logic for the remediation check already is here, there is no way to access any variable (such as the RepoClient) that has access to the repo URI/branch.

You're correct, the repoClient is the reason why it's not under evaluation. The reasoning is that evaluation should have all the information required to apply a policy without further API calls, as would be the case for someone fetching the results from the REST API / BQ table.
If some information is missing, maybe it should be added in the raw results.
I think we have hijacked the original intent of this issue, though :-)

Inside checks/evaluation where the logic for the remediation check already is here, there is no way to access any variable (such as the RepoClient) that has access to the repo URI/branch.

I see, that makes sense. Like @laurentsimon mentioned, I think the right way to solve this is to have info like URL, branch_name etc. in RawData. But I know it's not an easy change and might take time. So, let's remove the init() fn and all the global vars for now (that should solve the data race issue too). We need to fix this before EOW so that the cron job picks up the fix.
Once the fix is in, let's reconsider how to solve it the right way using RawData. Wdyt?

I'm fine with that.

The remediation data made its way into raw data in #3632


LINK : fatal error LNK1189: library limit of 65535 objects exceeded

Windows 10 64 bits
VS 2017
cmake 3.10.2
Using #2029 and #1671
linking caffe2 in debug I have got this errors :
1>------ Build started: Project: caffe2, Configuration: Debug x64 ------
1>LINK : G:\Lib\build\caffe2\bin\Debug\caffe2d.dll not found or not built by the last incremental link; performing full link
1>LINK : fatal error LNK1189: library limit of 65535 objects exceeded
1>Done building project "caffe2.vcxproj" -- FAILED.
========== Build: 0 succeeded, 1 failed, 0 up-to-date, 0 skipped ==========

How to solve it?

@LaurentBerger sorry that our Windows coverage isn't so great right now. I think solving this problem will take a lot of effort on our part to narrow down what symbols we want to export. Until then, I think the only workarounds are using release mode or (possibly) linking against less libraries.

I fhave found a way to solve this problem : use option /Ob2 (see this issue in tensorflow)
Unfortunately I built caffe2 without GPU support and I have got two links errors. I have to disable those lines
 like in this issue
Now result is :
1>   Creating library G:/Lib/build/caffe2/lib/Debug/caffe2d.lib and object G:/Lib/build/caffe2/lib/Debug/caffe2d.exp
1>caffe2.vcxproj -> G:\Lib\build\caffe2\bin\Debug\caffe2d.dll
1>Done building project "caffe2.vcxproj".

Is this still working with the current master at https://github.com/pytorch/pytorch ?
I tried different options and I'm still hitting the 65535 symbol limit.

@cbecker where you just trying to build Caffe2 or also building Pytorch? Which optional libraries were you including?

@pjh5 I am building Caffe2 from the pytorch repo https://github.com/pytorch/pytorch
I am using the options:
USE_OPENCV=OFF
USE_OPENMP=OFF
BUILD_ONNX_PYTHON=OFF
BUILD_CUSTOM_PROTOBUF=ON
BUILD_TEST=OFF
USE_METAL=OFF
USE_GFLAGS=OFF
USE_GLOG=OFF
USE_NNPACK=OFF
USE_NCCL=OFF
CUDA_USE_STATIC_RUNTIME=OFF
CAFFE2_STATIC_LINK_CUDA=OFF
USE_OBSERVERS=OFF

For CPU, no CUDA. Do you have any suggestions? I have the impression that it will be almost impossible without splitting the library or manually specifying the symbols to export.

Can you also set BUILD_ATEN and BUILD_BINARY off too? And in Release mode? And the option /Ob2 is being used?
We will have to cut back on the symbols we're exporting eventually, as we really shouldn't run into this limit no matter what libraries we choose to build with.

I'll try that tomorrow (I don't have a Windows machine where I am now) with BUILD_ATEN and BUILD_BINARY off.
I was using /Ob2 and Release, but not sure about these two, are their default values OFF? then they were off.

@pjh5 I tried with BUILD_BINARY and BUILD_ATEN OFF with master from today, and the problem is still there. Is this an issue that will be fixed soon? I am wondering how it's working on CI, as here we cannot compile it with MSVC2017. Maybe because CI runs w/cuda, and we're trying to compile the CPU version here?

@pjh5 It also occurs when I tried to build pytorch master and the error was thrown in building caffe2 in a Release build with MKL, MAGMA and CUDA 8.0. I think we should prioritize this issue, otherwise, the PyTorch 1.0 can't be built with CUDA 8 on Windows.

I am glad to contribute to this, as I believe it's a big blocker for anyone wanting to use caffe2 on Windows.
I am thinking what would be the best way to go around it. My suggestion is to disable exporting all symbols, not only for windows but also for linux and mac. Then fixing this can be done in linux first, where it's much faster to compile and debug, to include the needed exports. When I tried to do it directly on Windows it was such a pain, because compilation takes much longer in my experience. What's your take?

Something like sccache and ninja can help to accelerate the build on Windows.
# Install ninja and sccache
pip install ninja
curl -k https://s3.amazonaws.com/ossci-windows/sccache.exe --output %CD%\\tmp_bin\\sccache.exe
set "PATH=%CD%\\tmp_bin;%PATH%"

# Specify CMAKE_GENERATOR and C/C++ compiler
set CMAKE_GENERATOR=Ninja
set CC=sccache cl
set CXX=sccache cl

Thanks @peterjc123 , that will help.
Nonetheless, wouldn't it then make sense to limit symbol exporting in all platforms, to be consistent and to easy development?

@cbecker Yes, that will be easier. Please try at https://github.com/pytorch/pytorch with other CIs off by deleting some configurations in pytorch/pytorch/.jenkins/pytorch/enabled-configs.txt.


WL-4403 Remove link 'Go to accessibility' shown on mobile site

For completeness the file /access/content/public/accessibility.html could be removed from tomcat as well.  Its contents are rather out of date.

yes, I guess so
--
** Note change of email address to adam.marshall<EMAIL_ADDRESS>**
Dr A C Marshall, WebLearn Service Manager, University of Oxford.
IT Services, 13 Banbury Rd, Oxford. OX2 6NN.
From: Rebecca Miller<EMAIL_ADDRESS>Sent: 04 July 2016 14:02
To: ox-it/sakai
Subject: Re: [ox-it/sakai] WL-4403 Remove link 'Go to accessibility' shown on mobile site (#9)
For completeness the file /access/content/public/accessibility.html could be removed from tomcat as well. Its contents are rather out of date.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHubhttps://github.com/ox-it/sakai/pull/9#issuecomment-230285509, or mute the threadhttps://github.com/notifications/unsubscribe/ACXZILPVJyW5ITiwXnfiiZbt7Hgbmm2Cks5qSQRcgaJpZM4JEWW9.


[Feature] Basculegion has the wrong first ability

Describe the bug
Basculegion is shown to have Rattled, when it should have Swift Swim.
Screenshots

Username:
Audacideez
Server name (all applicable):
Titan

closing as https://github.com/NebulaMC-GG/Bugs-and-Issues/issues/2321 details the same issue


react-step-1

Closes #
{{short description}}
Changelog
New

{{new thing}}

Changed

{{change thing}}

Removed

{{removed thing}}

Closing this because https://github.com/carbon-design-system/carbon-tutorial/pull/5466 was approved.

worked on this react step 1


Include login_name in adminCreateUser response

login_name (Authentication Sign-in Name) is not included in the response of adminUserCreate API.
PR is to return empty string ("") if source_id: 0, and return user-specified login_name if not.

Please run 'make generate-swagger' and commit the result:
I ran make generate-swagger and commit the result, however, it's still causing the same error. Any suggestions?

bot


🐞 Profile country should default to 'US'

When a user creates their profile, we really should ask them for country of origin. If we do not or if they do not answer, we should default to US rather than Null

@maxh1231 I know this is resolved client side, but did we put in a fix to the DB that will default to 'US' as a failsafe?


Add params to the search requests.

Hello, I'm trying to search video on YouTube, so I use the Search class, but I only need the CC-BY videos, there is a filter on YouTube that allow that but not on PytubeFix. I added a parameter in the search class that allow to use custom filter for the research endpoint.
E.g:
from pytubefix import Search

s = Search("Music", {"params": "EgIwAQ%3D%3D"})

last_nbm_results = 0
while len(s.results) != last_nbm_results:
    for result in s.results[last_nbm_results:]:
        print(result.watch_url)
    last_nbm_results = len(s.results)
    s.get_next_results()

Maybe we can add a parameter that inserts this filter more intuitively, for example:
s = Search("Music", get_CC=True)

I liked your filter idea, so I mapped out the filters YouTube uses and decoded them:
upload data:
	Last Hour = {2: {1: 1}}
	Today = {2: {1: 2}}
	This week = {2: {1: 3}}
	This month = {2: {1: 4}}
	This year = {2: {1: 5}}

type:
	Vídeo = {2: {2: 1}}
	Channel = {2: {2: 2}}
	Playlist = {2: {2: 3}}
	Movie = {2: {2: 4}}

Duration:
	Under 4 minutes = {2: {3: 1}}
	Over 20 minutes = {2: {3: 2}}
	4 - 20 minutes = {2: {3: 3}}

Features:
	Live = {2: {8: 1}}
	4K = {2: {14: 1}}
	HD = {2: {4: 1}}
	Subtitles/CC = {2: {5: 1}}
	Creative Commons = {2: {6: 1}}
	360 = {2: {15: 1}}
	VR180 = {2: {26: 1}}
	3D = {2: {7: 1}}
	HDR = {2: {25: 1}}
	Location = {2: {23: 1}}
	Purchased = {2: {9: 1}}

Sort by:
	Relevance = {1: 0}
	Upload date = {1: 2}
	View count = {1: 3}
	Rating = {1: 1}

With this we can combine some filters, for example, video + Creative Commons = {2: {2: 1, 6: 1}} Converting to protobuf we have: EgQQATAB
Sort by works a little differently, for example if we want Video + Creative Commons + Sort by upload date: {1: 2, 2: {2: 1, 6: 1}} Converting to protobuf we have: CAISBBABMAE=
This can be useful if we want to make a filter mechanism.

make tests and changes to the search_requests branch

I saw this was committed to 7.2.2, what exactly are the parameters we would pass? Or is that still to be implemented?  Thanks for this project!


Add additional orientation options in hint.js and provide 3 examples using these orientation options

Add 8 more orientation options all related to edges:

'edgetopLeft',
'edgebottomLeft',
'edgetopRight',
'edgebottomRight',
'topEdgeleft',
'bottomEdgeleft',
'topEdgeright',
'bottomEdgeright'

Add 3 examples (dynamic-simple-edge-hints, dynamic-simple-topedge-hints, dynamic-complex-edge-hints) illustrating these new orientation options.

Export ORIENTATION object with all the orientation constants and use them instead of the strings.
Convert examples to use these constants rather than the strings (for backwards compatibility, the original orientation strings are unchanged).
dynamic-complex-hints.js shows the power of using these edge orientation which also uses:

divs to draw the hint-text box and the hint-pole; they are provided as children to the Hint component.  The hint-pole cannot be done with LineSeries as shown in (dynamic-simple-topedge-hints.js) because it needs to extend from bottom to top edge of plot and not from bottom of innerplot to top of plot (see image).
flex to draw the text box beyond the top of the plot (using align-items: flex-end) and a few other flex tricks.  This demonstrates a pure div approach that could not be done with subclassing GridLines or using LineSeries for the pole because of the need to go from edge to edge of the plot.
exploits existing support by Hint to set margins and to use them to create short hint-pole-stem that connects with LineSeries (if you want to see what I mean, comment out the LineSeries in dynamic-complex-hints.js.

@chrisirhc Your comments to clarify ORIENTATION constants and to accept top/left/right/bottom css props to override Hint behavior provoked me to re-think the existing PR.
I would like to propose the following to address and reduce your underlying concern while maintaining the original spirit of Hint orientation props in the API.  I believe your underlying concern was the long list of orientation constants options and the conflating of two axis/edges into one property.  I suggest we tease apart the orientation property into two separate properties that better address the axes/edges for placement of hints.
Specifically, the two new properties are horizontalAlign and verticalAlign. They have the following values.  See the attached image elaborating on the values and a few examples illustrating hint placements.

horizontalAlign: auto, left, right, leftEdge, rightEdge
verticalAlign: auto, top, bottom, topEdge, bottomEdge

As clarified earlier, in this PR, hints are placed either in one of the data point's 4 quadrants (resulting from two axes bisecting data point) or is pinned to one edge of the plot (leftEdge, rightEdge, topEdge, bottomEdge) and positioned along that edge using data point's other dimension value.
For auto, it would follow the existing notion: place hint as determined by the x or y value but aligning to fit within the inner portion of the plot.  This would also work if the other dimension were pinned to an edge.
This change will drop support of existing ORIENTATION property and its string value in favor of the above proposal.  It will be a breaking change to the Hint API.
Let me know what you think about this? If you agree with the change, I'll post an update changing the Hint API and examples.
Alison

@alee8  it sounds like there's a lot of customization required for your use cases. I've written up an alternate propsal at #203 with the idea of having overrides for any of the positions. Will that be adequate for your use cases?

The reason I'm reluctant to go towards providing a lot of API surface area to deal with positioning is that there are existing libraries that already do this (e.g. http://tether.io/) , and seeing the API of these libraries, there's a certain level of functionality required before the positioning API becomes useful.
I'm proposing to leave it out of the react-vis API for now and allow the user to decide how they would like to position or override the positions so that we can serve both basic and advanced use cases without spending much time / effort on building an API that may not meet either well in its early stages.

Hey Alison.
I really like your diagram! Generally I feel weird about introducing a whole new system for describing the positions of things. While yours is really comprehensive, it feels like something that could easily snowball and get out of hand with time. Also, to chris's point

The reason I'm reluctant to go towards providing a lot of API surface area to deal with positioning is that there are existing libraries that already do positioning really well (e.g. http://tether.io/) , and seeing the API of these libraries, there's a certain level of functionality required before the positioning API becomes useful to power users.

I think the optimal strategy here is to simply provide overrides so that a more developed api can do the work. Unless I'm really missing something, it seems like #203 is maybe a little more defensive in the exposure of our api footprint.Finally, can you please add a documentation task for the hint? It would be great if we could build up the pain points of documentation so that we can prioritize them when we start in on it.

Have a conceptually cleaner proposal in PR#204 with examples in PR#205.
Closing this one out. This was valuable for thinking through and articulating the key issue for this PR (addition of user-friendly, non-programmatic means of attaching hints to edges of a plot).


Feat: added n_choose_r combinatorics algorithm

Description of Change

Added a simple n choose r combinatoric function.
Checklist

[x] Added description of change
[x] Added file name matches File name guidelines
[x] Added tests and example, test must pass
[x] Added documentation so that the program is self-explanatory and educational - Doxygen guidelines
[x] Relevant documentation/comments is changed or added
[x] PR title follows semantic commit guidelines
[x] Search previous suggestions before making a new one, as yours may be a duplicate.
[x] I acknowledge that all my contributions will be made under the project's license.

Notes:  Added a simple n choose r combinatoric function.

LGTM!

Has LGTM generated any warnings for this PR?

LGTM!

Has LGTM generated any warnings for this PR?

No, there are no warnings.


refactor(api)!: change window label getters to be async ref #5380

using initialization scripts to have a dynamic data (available windows) is a bad idea and we should drop that before going v2 stable
closes #10256

closes #10256


Integrating fast_hadamard_transform on C++ level

This PR adds a kernel that wraps together a Fast Hadamard Transform (built from Tri Dao's implementation) and FLUTE GEMM to support HIGGS.
Notably, submodule initialization will be needed to build it.

@HanGuo97 Hi! Works on my machine. Could you check if it compiles and works for you as well?

Upd: swapped the Tri Dao's implementation for the HadaCore implementation because the former wouldn't work with torch.compile for some batch sizes.
It's ~20% slower though. TODO: choose the better option later.


facenet model is missing in the asset path

Hi.
I compiled the<PHONE_NUMBER>8e4b, but after a complete rescan, no People are found in the People section.
I opened a discussion in Photoprism about it. It seems that the docker image is not complete and the facenet model is missing in the asset path.
Could you please check it?
Thanks!

Thanks. It has been fixed. 432417f2661a098b9a605ba123b250fb01c4a653
You can also download the model from https://dl.photoprism.org/tensorflow/facenet.zip and unzip it, then copy the aved_model.pb to /var/db/photoprism/assets/facenet/.
Sorry for the inconvenience.

Hi.
PhotoPrism mantainers are asking here issue 1584
 Should do this by ourselves in the future. What's the process?
Could you confirm them what to do?
Thanks!


Fix spark master setting when it's not provided the user.

If the user does not provide a sparkmaster param the previous setup will fail to run. This fixes that.

Shoot, I should have caught this the first time. +1


preserve pane arrangement on refresh

Hello!
I have been using this plugin for nearly a year now and it has been a tremendous productivity gain for me.
However, it always bugged me that when I accidentally apply a preset layout, I would basically lose the ability to configure the pane arrangement of that window and need to move all my panes to another window.
I thought this was intentional, but maybe not?
Thanks and great project!

Hi! Thanks for the feedback, happy to hear that you're enjoying the plugin! Apologies for the delayed response; I've been overly busy recently, as I've been switching jobs and moving between cities :).
So if I understand correctly, the issue that this PR resolves is:

You organize the panes in a a window "manually" (not with a layout);
You accidentally click alt+v or alt+s or something and enable a layout;
Afterwards, you can't really "get rid" of the layout without creating a new window.

Is this correct? And with your PR, do these previous things still work correctly:

The current layout (if selected) is preserved if you create or delete panes;
If you have set a default layout (e.g. main-vertical), then in new windows the panes automatically follow that layout.

If so, I will give the PR a spin and try to merge it – if not, we can discuss a bit how to make the modification work for everyone (e.g. an if-test checking if you have a default layout set, before running select-layout in that code).

Hi Jabirali! It's my turn to be sorry for the delayed response hehe.

The current layout (if selected) is preserved if you create or delete panes;

The current layout is preserved (in memory), but it won’t be applied when panes are created or deleted. Instead, the panes will just be spread out evenly (tmux select-layout -E).

If you have set a default layout (e.g. main-vertical), then in new windows the panes automatically follow that layout.

No, the new panes will not follow the layout; it'll just be a default vertical split at the end.
I've thought about adding a tmux select-layout command to the Alt +Enter command so that it reapplies the layout, but I find it a bit disruptive because it could potentially re-arrange any manual pane configuration done by the user.
The implementation of Alt +r does not reapply the layout, so I'm thinking that it's consistent that Alt +Enter doesn't reapply the layout either.
Hope this answers your questions!

Hi again, thanks for your contribution.
After thinking it over a bit, I decided that I would prefer for the current behavior to be the default, since the auto-application of the layouts is IMO one of the core features of Tilish to make it act more like dynamical window managers.
However, I completely understand that not everyone wants this to be on. Therefore, I've added a new config option tilish-enforce that can be used to determine whether or not Tilish reapplies layouts. There are three levels:

Default: Like before, Tilish reapplies the layout and resizes the windows.
set -g @tilish-enforce 'size': This does not reapply the layout automatically, it only resizes the windows. This should be the desired behavior in your use case.
set -g @tilish-enforce 'none': This completely disables the relevant hooks, so that people can e.g. maintain a manually constructed 60% / 40% split as requested in issue #18.

I have pushed this modification now and updated the README. I've tested all three cases locally, but please give it a test as well and let me know whether this solution works as intended for you :).
As for the alt+r binding, I think it's OK that this one is slightly inconsistent. This binding was mainly intended to be used in legacy versions of tmux that did not yet support the auto-tiling features that tilish uses, so that the user might have to manually press alt+r once in a while to fix the layout. Those versions are now 6+ years old and less used, so it's probably not worth updating the legacy code paths in the plugin except for important bug fixes. Let me know if you disagree on this, then we can think of how to make alt+r more configurable as well.

@jabirali sounds good, thank you very much for integrating this!


Add support for NOOP result

This allows to have a separate result from done, when nothing was done. This also affects the HTML introspector, that will collapse all NOOP runs to a single line, so as to not interfere with other normal runs.

I have included this in #24


Update macOS version in tests

Description
As of a few minutes ago, I deprecated the High Sierra images.  This switches them to Mojave
Related Issues
N/A
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

[x] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[x] My PR includes tests for all changed/updated/fixed behaviors (See Test Coverage).
[x] All existing and new tests are passing.
[x] I updated/added relevant documentation (doc comments with ///).
[x] The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
[x] I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
[x] I signed the CLA.
[x] I am willing to follow-up on review comments in a timely manner.

Breaking Change
Does your PR require Flutter developers to manually update their apps to accommodate your change?

[ ] Yes, this is a breaking change (Please read Handling breaking changes).
[x] No, this is not a breaking change.

/cc @gspencergoog

@RDIL - we need images that have Xcode 9.4.1 for https://github.com/flutter/engine
Can we get a mojave image that has that?  Or can it be added to the existing Mojave images so we can xcode-select it?

I'll take a look

@dnfield would it work if I installed both 9.4.1 and 10.1 onto the image?  Would you be able to select which version to use?

That would be fine as long as we know the path and can sudo, e.g. sudo xcode-select -s /Path/To/Xcode9.app will do it

Well, High Sierra images will be around. Most likely they won't be updated. Changed wording in the documentation to Not maintained rather than Deprecated to not be confusing.

👍

That should be fine for us.  It may be good to get an Xcode 9.4.1 on Mojave at some point, but it's not pressing for us.


fori_loop with disable_jit fails when no actual iterations happen

In a trivial call of fori_loop, i.e. when upper == lower, a normal call works just fine,
but a call with disable_jit causes a TypeError.
Can be reproduced by
from jax import lax, disable_jit

def test():
    non_trivial = lax.fori_loop(lower=0, upper=3, body_fun=lambda x, i: x + i, init_val=1)
    print(f'non-trivial result: {non_trivial}')
    trivial = lax.fori_loop(lower=0, upper=0, body_fun=lambda x, i: x + i, init_val=1)
    print(f'trivial result: {trivial}')

test()
# non-trivial result: 4
# trivial result: 1

with disable_jit():
    test()
# non-trivial result: 4
# TypeError: tree_map() missing 1 required positional argument: 'tree'

This is because the non-jit implementation of lax.scan
calls tree_multimap to stack the outputs, but there aren't any outputs to stack.
I suggest to check for this special case (of a trivial array to scan over) in the non-jit branch of scan and directly return the initial carry and a trivial stacked_y.
Happy to make a PR if this is the way you want to do it.

PR see above.
I am not sure if jax.numpy.array([]) is the suitable stand-in here, or if it should be None...

Hmm... so I think there's one issue with that approach. Look at this for example:
import jax.numpy as jnp
from jax import lax
carry, out = lax.scan(lambda carry, x: (carry, x[None]), 0, jnp.array([]))
print(out.shape)
# (0, 1)

I don't think returning empty arrays is precisely correct. You actually do need to know the return type of the function, and construct the output based on that. This implies that in the length = 0 case with jit disabled, we'd have to trace the function to figure out the appropriate output... but disabling jit generally means you don't want the function to be traced.
I'm not sure how to resolve this.

Maybe the safest thing is to raise an explicit error, like
raise ValueError("zero-length scan is not supported in disable_jit() mode because the output type is unknown.")

Closed by #8160

We could handle this case using jax.eval_shape or similar.


How do I get Onivim2 to auto format a file after saving?

Hello
I use Onivim 2 (0.5.1-nightly), have already activated a license key, installed EditorConfig plugin and expect the IDE will automatic format my code after I saved it.
Here is my .editorconfig:
# top-most EditorConfig file
root = true

# Unix-style newlines with a newline ending every file
[*]
charset = utf-8
end_of_line = lf
indent_style = space
indent_size = 4
insert_final_newline = true

# Matches multiple files with brace expansion notation
[*.{js, ts, jsx, tsx, .yml}]
indent_size = 2

I also tried:

ctrl+shift+p
Formatting to format a document manually but it does not work.

Please let me know if I miss some configurations.
Thank you.

This may be a duplicate of #2464.

This may be a duplicate of #2464.

@dcalhoun  Thank you so much.


Add start_experiment.sh functionality to run.py

We have a start_experiment.sh script that is a wrapper around run.py which 1. Saves current git info (commit hash and diff) 2. Saves all output of the script 3. Saves the exact configuration used. I think that in principal we always want this kind of functionality from run.py (maybe except git info saving, which should be robust to git not being installed). Thus, I moved this functionality to run.py itself and added exact command line arguments saved as well for even easier reproducibility of experiments. Git info saving will not fail if git is not installed and will just save any errors encountered instead of actual git information. It will also work in horovod mode (saving only output from the first worker, which is the only one that outputs relevant information anyway). I personally think this is very convenient to have in run.py, because start_expeirment.sh is somewhat cumbersome (e.g. I wanted to run something with horovod and realized that it does not support it and to add the support I would basically need to create a copy of that script just for running horovod). Let me know what you guys think about this.

There is one potential problem with this, though:
The new run.py will always create "logs" subdirectory inside logdir and write/read checkpoints from there (same as start_experiment.sh did). Thus, if the user has checkpoint not inside the "logs" subdirectory, the script will complain and fail with exception. But if we don't want this kind of behavior we can maybe add some cmd flags to enable/disable it?

I don't mind moving the shell script's utility to run.py. LGTM.

@okuchaiev, does it look good to you now, can I merge?


do cleos  get account tokenpocke25 then throw bugs

2739545ms thread-0   main.cpp:2552                 main                 ] Failed with error: Assert Exception (10)
a.get_symbol() == b.get_symbol():
version info:
root@iZrj9fjy4361prityhtkvcZ:/data-stage16# cleos -u 'http://<IP_ADDRESS>:8888' get info
{
"server_version": "00c78697",
"chain_id": "706a7ddd808de9fc2b8879904f3b392256c83104c1d544b38302cc07d9fca477",
"head_block_num": 183276,
"last_irreversible_block_num": 183275,
"last_irreversible_block_id": "0002cbebaae193936df403e0bdaa464681c445b5b646a747e74e21860f9a9e76",
"head_block_id": "0002cbec114e6f1be7413bf8f36360480d89a5a0df86f6eb4d82d3299e5679a5",
"head_block_time": "2018-05-31T13:07:58",
"head_block_producer": "eosio",
"virtual_block_cpu_limit": 200000000,
"virtual_block_net_limit":<PHONE_NUMBER>,
"block_cpu_limit": 199900,
"block_net_limit": 1048576
}

Can you provide your detail command?

closed as no follow.
if this persists please file an issue again


Error: exec proxy not found for :: AdMob :: createBannerView

I always have this error when banner.prepare() function is executed.
     this.admobFree.banner.prepare().then(() => {
     }).catch(e => console.log(e));

cordova.js:1003 Error: exec proxy not found for :: AdMob :: createBannerView

This message appears in the chrome inspector.
I run application with:

ionic cordova run browser

Any suggestions ?
Thanks

Any solutions for this? I'm getting the same issue with my project.

@shahmhussain  @tbillson @amorel
Check this link
It states that AdMob plugin is only supported by Android and iOS platforms. Running it on a browser will not be supported and the browser won't find the plugin.

@ps011, I was doing
ionic cordova run android - - device
And inspecting on Chrome, getting the same error.
I uninstalled every plug-in and reinstalled them, making sure I was following the up-to-date instructions.

@tbillson, how is it possible to run an app on a mobile phone and inspect in chrome? Can you please list down the steps that you followed to do this?

@ps011 , this is the step by step I followed:
https://medium.com/@coderonfleek/debugging-an-ionic-android-app-using-chrome-dev-tools-6e139b79e8d2


binfmt: Don't create invalid service with no registrations

We shouldn't be creating a systemd.services.systemd-binfmt value when the upstream unit isn't being pulled in, because it results in a service unit file with no ExecStart line
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[x] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.05 Release Notes (or backporting 22.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[ ] Fits CONTRIBUTING.md.

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/prs-ready-for-review/3032/1839


[bug] product search in product list view does not work

enhance: product search default search for product.name and product.keywords field

https://github.com/revtel/gatsby-starter/pull/112


Create unofficial MoneroLink response

I do not have the images attached (sorry), but I would like to post the paper I have written here to the Monero blog: https://1drv.ms/w/s!AjOt8D-0YjBHgYg_onISH13gCSfKng
My apologies for not knowing much of the formatting. Perhaps someone can help me here? I promise I will improve for subsequent proposals :)
I removed the pre-preface for 2 reasons: 1) a pre-preface is poor form in general, and 2), if published on the GetMoneor website, the paper should be a more formal response, even if not official
Images are not attached. My apologies for not including them in the actual formatting.

I want to make some changes quickly (Andrew Miller sent me a PM). Please do not merge yet.

Please see #254 instead.


Release/v1.4.3

🗃 Github Issue Or Explanation for this PR. (What is it supposed to do and Why is needed)
QR button gone in 1.4.2

✅ Checklist

[x] I have tested all my changes.

🕵♂ Notes for Code Reviewer
I don't think we are using Theme colors yet in this build - correct me if I am wrong
🙈 Screenshots
Restored

👯♀ Paired with
solo

Ok making testflight build for final checks


Other ways to bind data directly in component?

Hey,
directly binding values doesnt seem to work?
like inlining
<vue-slider v-bind={ 'min': 0,'max': 200,'interval': 50}>
Am i doing something wrong or is this not supported?
Thanks

You can try this:
<vue-slider v-bind="{ 'min': 0,'max': 200,'interval': 50}"></vue-slider>

Thanks! I actually realised..the sliders work..seems i need to refresh the component...as the divs are not visible at first. How can i refresh the components?
I saw there is a refresh function, how do I call that one.
Thanks again in advance!

just like:
<vue-slider ref="slider"></vue-slider>
<button @click="$refs.slider.refresh()">Refresh</button>


Add bootstrap icon on the TaskType

Feature Description

Want to have an optional icon for a TaskType.
Expected solution

[ ] Add a string attribute named icon to the TaskType.   It should be in the format for a https://icons.getbootstrap.com/ like bi-door-closed for the door tasktype.

[ ] On the TaskType page, add an  link to the bootstrap icons page to help selection, browser should open in a new tab.

[ ] On the calendar, when displaying the tasktype put the icon before the tasktype text.

[ ] On mobile, just show the icon, not the text. using the format

Testing

Hi @dherbst can I work on this task?

@ovindu-a Yes!  Go for it!


Fix some typo, solved issue #83

Follow up #71

this.props.style should be this.props.styles
should check if the property textInputContainer exists in this.props.styles and nextProps.styles

much thanks @ianlin

new npm version published

Thanks! :)


libtcmu: free tcmu_device after dev->fd is closed

the device is freed in thread cleanup function,  this fd cannot be closed since it is not a valid fd
Signed-off-by: xinxin shu<EMAIL_ADDRESS>

@agrover , pls help review

Hi! It's been a while since I looked at this code, can you help me understand in more detail the way that closing dev->fd before calling dev->handler->removed is bad? Thanks!

in current code,  the dev->fd is freed in thread cleanup function when dev->handler->removed is invoked, tcmu-runner reports the following error since the dev->fd is not a valid fd
could not close device fd uio0: 9
could not unmap device uio0: 22
the fix closes dev->fd before the dev->handler->removed is invoked,  the errors do not show up again

Ahhhh!! Yes. Thanks for fixing this. :+1:


Improve metadata and GitHub Actions

This PR ensures a consistent formatting of the setup.py fields and re-introduces/reorders some of the trove classifiers lost during the original migration process. Additionally, the license field has been updated as it used the wrong value.
Besides the metadata improvements, I added Python 3.12 to the test matrix and upgraded the actions to their latest versions.

Thank you!


[feature][trino-python-client] add new trino python client && support trino set session.

What changes were proposed in this pull request?
Added a new trino python client to support the execution of commands such as trino set sessions through the python client
How was this patch tested?

(Please explain how this patch was tested. Ex: unit tests, manual tests)
it is test by manual tests, however,this code if forked from hue ,  and most of the code come from hue original

@zhuzhengjun01 thanks for the contribution. Can you explain the need for a new trino client, given that a trino client was recently added to Hue?

@zhuzhengjun01 thanks for the contribution. Can you explain the need for a new trino client, given that a trino client was recently added to Hue?

Thanks for your reply~
The original trino connector does not support set session and multi-sql execution. In addition, if you connect trino through jdbc, there will be a memory leak problem. In order to solve this problem, it was changed to python client, which is different from the original one.
issue: https://github.com/cloudera/hue/issues/3223


docs: configuration of disk-access-mode

issue: #98

Add docs for diskAccessMode
highlighting usage, files involved and a gist of caching mechanism

I have summarized the content in table for readability and to pack in a nutshell. I am willing to work on a component to replace with the markdown table.

@itzsrikanth thank you for contributing! I need some time to get into it.

@itzsrikanth, hello! Your pull request provided valuable insights on cache-handler options. Please wait a little while I make changes to the API 🙏

Thanks a lot for the quick review, pls take your time for changes.
I would be happy to make corresponding changes to the documentation.

Unfortunately, I must close your pull request because it is obsolete. I appreciate your contribution, and I hope you will continue to contribute in the future. Your contribution has dramatically influenced the refactoring process.


Update login request to include OpenID scope

Motivation
Make logout work properly
Description
Need to include the OpenID scope to get the identity token.
Login
Logout - Session will be removed on Keycloak
Login again - Will have to authenticate again
Resolves https://github.com/aerogear/aerogear-android-sdk/issues/42
Progress

[x] Include OpenID scope

@TommyJ1994 Mind taking a look?

@TommyJ1994 Yep, the Keycloak logs basically said it wasn't using OpenID because the scope wasn't provided. Who knew logs could be so helpful 😛


Concurrency in managing the runners

Enhancement Proposal
As a user, I would like the charm to reconcile the current state and the intended state as soon as possible.
Adding concurrency to the management of the runners would achieve this.
Async would be a good way to add concurrency, as the charm calls external API.
Parallelism might possibly help.
The creation and deletion of runners might benefit from this.

This is already done for runners on openstack cloud, but missing for LXD. The charm will be refactored soon anyway. Still keeping the issue open to keep track (for LXD).

@jdkandersson It seems we are no longer developing new features for LXD, so closing this issue.


Ddlog and incremental grounding update

Update incremental grounding to match the weight column naming generated from ddlog since     HazyResearch/ddlog@a24788e27ac65d4118a518f1b92f9f2d950af02f.

@feiranwang @netj after code review, let's mail back the user who needed this!!

I wished the two fixes were in separate PRs, but if you think they're better together, I'm okay with either way.  Not 100% sure about all the details of multinomial incremental grounding part, but the code looks relatively okay.  We should really refactor and duplicate the code for different databases soon to stop introducing more branches to the control flow.

Sorry, there are some refactoring in assigning weight ids, so I put the commits together. It's better if they were separate.

@netj Updated. Thanks!

LGTM


Custom http configurer integration

Hi @VanRoy, I left the original ElasticsearchJestAutoConfigurationTest so as to prove that the new configuration code was optional. New test checks that the connection time out was actually updated.
Let me know if this is ok.
Thanks

@aminmc Yes, it's perfect . Thanks again for your help

No problem. Happy to help and this is a cool project.


Fix index-discovery process when using handle

References
Fixes #9764
Description
Fixes the process index-discovery to be able to run and complete when selecting the DSO by handle.
Instructions for Reviewers

Log in as admin in the front-end
In the side-bar, go to Processes > + New
Select the script index-discovery
Add the parameter --index, enter the handle of a DSO (item, collection or community) as the value
The process will run and terminate with status COMPLETED

In the old code the process always fails when using the DSO handle, due to a NullPointerException.
List of changes in this PR:
The index-discovery calls getIndexFactoryByType to get the appropriate IndexFactory instance for the DSO type. getIndexFactoryByType expects the name of the DSO, e.g."Collection".
In the old code, it was being used the Constants value of the DSO. E.g. Constants.COLLECTION, with value equal to "3".
This PR changes to use the proper DSO name.
Checklist

[x] My PR is created against the main branch of code (unless it is a backport or is fixing an issue specific to an older branch).
[x] My PR is small in size (e.g. less than 1,000 lines of code, not including comments & integration tests). Exceptions may be made if previously agreed upon.
[x] My PR passes Checkstyle validation based on the Code Style Guide.
[ ] My PR includes Javadoc for all new (or modified) public methods and classes. It also includes Javadoc for large or complex private methods.
[x] My PR passes all tests and includes new/updated Unit or Integration Tests based on the Code Testing Guide.
[x] My PR includes details on how to test it. I've provided clear instructions to reviewers on how to successfully test this fix or feature.
[ ] If my PR includes new libraries/dependencies (in any pom.xml), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.
[ ] If my PR modifies REST API endpoints, I've opened a separate REST Contract PR related to this change.
[ ] If my PR includes new configurations, I've provided basic technical documentation in the PR itself.
[x] If my PR fixes an issue ticket, I've linked them together.

@autavares-dev could you please rebase and force push your branch again? i'm pretty sure the code coverage failure is a false positive caused by a really large commit (fixing 100s of spelling errors across many lines) that will be resolved if you rebase against main and push again. then we'll get this merged ASAP. thanks!


chore: release main

:robot: I have created a release beep boop
forms: 0.2.4
0.2.4 (2024-12-18)
Bug Fixes

cvv field: change input type from password to text (72c440a)
document field: fix PASSPORT validation (8c71cb4)
email field: add max length validation (de3d007)
full name field: add maximum length check and trim preparation (241549b)
phone field: improves validations (8036037)

ui: 0.3.2
0.3.2 (2024-12-18)
Bug Fixes

FormField: ensure the Select component is fully clickable (6c6fc53)

form-example: 0.0.6
0.0.6 (2024-12-18)
Dependencies

The following workspace dependencies were updated

dependencies

@tabnews/forms bumped from 0.2.3 to 0.2.4
@tabnews/ui bumped from 0.3.1 to 0.3.2

This PR was generated with Release Please. See documentation.

:robot: Created releases:

form-example-v0.0.6
forms-v0.2.4
ui-v0.3.2
:sunflower:


Update cron timings and queue for amr loads and regeneration

The timings for when we receive data has changed over the last few years. Mostly due to changes in which portals and data providers are supplying us and when they send out their automated emails.
We now receive a small number of files between 2-5am but the bulk of the data is received from around 6am onwards, with some not arriving until around midday.
This PR:

adds a second daily run of the AMR import at 22:15pm. This will end up processing the bulk of the data that arrives during the day, with the existing 5.15am run remaining to catch any files from the early hours.
moves the population of the regeneration queue to 5.40am, so that it should complete earlier
updates the amr import job to use the regeneration queue, so that any remaining files in the queue from the morning run, which should be a smaller number will get processed before the regeneration.

the amr import job queue change is missing?

forgot to push, there now


[Stacked on #2054] iox-#1361 Use shared memory for process alive detection

Pre-Review Checklist for the PR Author

[x] Code follows the coding style of CONTRIBUTING.md
[x] Tests follow the best practice for testing
[x] Changelog updated in the unreleased section including API breaking changes
[x] Branch follows the naming format (iox-123-this-is-a-branch)
[x] Commits messages are according to this guideline

[x] Commit messages have the issue ID (iox-#123 commit text)
[x] Commit author matches Eclipse Contributor Agreement (and ECA is signed)

[x] Update the PR title

Follow the same conventions as for commit messages
Link to the relevant issue

[x] Relevant issues are linked
[x] Add sensible notes for the reviewer
[ ] All checks have passed (except task-list-completed)
[x] All touched (C/C++) source code files from iceoryx_hoofs are added to ./clang-tidy-diff-scans.txt
[ ] Assign PR to reviewer

Notes for Reviewer

This PR refactors the process alive detection by moving it from an IPC message to a timestamp in the shared memory. It is still not optimal but helps with #2040 and should prevent #1374.
Ideally the process alive detection should not depend on a free running thread to update a value but either on the frequency of the actual sent messages or actual crash detection to prevent RouDi from killing applications which are stopped in a debugger.
Checklist for the PR Reviewer

[ ] Commits are properly organized and messages are according to the guideline
[ ] Code according to our coding style and naming conventions
[ ] Unit tests have been written for new behavior
[ ] Public API changes are documented via doxygen
[ ] Copyright owner are updated in the changed files
[ ] All touched (C/C++) source code files from iceoryx_hoofs have been added to ./clang-tidy-diff-scans.txt
[ ] PR title describes the changes

Post-review Checklist for the PR Author

[ ] All open points are addressed and tracked via issues

References

Relates to #1361

@FerdinandSpitzschnueffler @mossmaurice @dkroenke @MatthiasKillat @elfenpiff @budrus feel free to add yourself as reviewer


Internet Explorer version

I would like to know what browsers are supported by Signature pad. And what is the minimum version of browsers are supported.

@tejashapani It should support every browser that has basic support for canvas: https://caniuse.com/#feat=canvas. It won't work on IE8, which doesn't support canvas at all and in Android 2.3 Canvas#toDataURL is not supported, though it's possible to add a polyfill for that if you need. If it doesn't work properly in any other more recent browser, then it's most likely a bug.
The demo page has been rewritten recently using flexbox, so it might not look correctly in older browsers, but the library itself should work.

Hi @szimek
Thanks for the info.
I will check for polyfill.


Python - peek definition - last character not highlighted

Issue Type: Bug
Define a function in Python.
Use the function elsewhere.
Select the function where it is used in the code, and right-click to peek its definition.
The last character of the function is not highlighted.
Extension version: 2019.4.12954
VS Code version: Code 1.34.0 (a622c65b2c713c890fcf4fbf07cf34049d5fe758, 2019-05-15T21:59:22.738Z)
OS version: Darwin x64 18.6.0

System Info

Item
Value

CPUs
Intel(R) Core(TM) i7-5557U CPU @ 3.10GHz (4 x 3100)

GPU Status
2d_canvas: enabledchecker_imaging: disabled_offflash_3d: enabledflash_stage3d: enabledflash_stage3d_baseline: enabledgpu_compositing: enabledmultiple_raster_threads: enabled_onnative_gpu_memory_buffers: enabledrasterization: enabledsurface_synchronization: enabled_onvideo_decode: enabledwebgl: enabledwebgl2: enabled

Load (avg)
2, 2, 2

Memory (System)
16.00GB (0.27GB free)

Process Argv
/Volumes/openHAB-conf/

Screen Reader
no

VM
0%

Please could you provide a screen shot of the issue along with some code sample.

Closing until further info is provided


Change in States and Cities name for mobile devices

Is your feature request related to a problem? Please describe.
If we view website in mobile device the STATE/UT column is way too much in width and because of that the Deceased moves more towards right.
Describe the solution you'd like
It would be great if States and Union Territories will be shown as for example Rajasthan as RJ, Delhi as DL and so on which can be a better approach.

This is exactly what I was going to suggest. Having the shorter state codes rather than the entire state name would be a much better choice. The table feels really fidgety on shorter width devices.

But the table now has a horizontal scroll bar, so it should be fine right? Unless you want to view all columns at once.

If user is getting option to view directly that would be better instead of scrolling.

Using the scroll to get more information is the preferred approach. We will be adding more columns to the table soon like recovery percentage etc. So, scrolling is inevitable.
Also, codes won't work well for district names. Let's stick with the full name.


pipeline

May I ask if it supports building pipeline levels for accelerators？

I’m not too familiar with that term. Could you elaborate a little more on pipeline levels?

What I mean is similar to the function pipelining in HLS, but I just discovered that it has this ability. So the issue can be closed.
I was dizzy when I looked at the code and didn't notice the expression about pipelline ; )


Next event TBA

Hi guys,
I probably have missed something but the next event doesn't seem to appear on our brand new chapter : http://maptime.io/belgium/.
I just added 2 events but the next event is still "TBA".
What am I missing ?
Thanks

Update:
Actually, it works in Microsoft Edge, Google Chrome.
But doesn't work in Mozilla Firefox 49, Mozilla Firefox 50 and Internet Explorer 11.

Problem:
Firefox doesn't seem to accept +0000 in a dateString.
Source: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Date


Add style test file

Codecov Report

Merging #23 (805f0fb) into master (bf1efb0) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #23   +/-   ##
=======================================
  Coverage   86.20%   86.20%
=======================================
  Files          18       18
  Lines         174      174
  Branches       50       50
=======================================
  Hits          150      150
  Misses         24       24

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bf1efb0...805f0fb. Read the comment docs.


get_enemy_expansion returns the enemy starting location

The Bot::get_enemy_expansion method returns the enemy starting location (unless you've revealed the enemy "townhall" before, I suppose). In its current form this method is pretty meaningless. I suggest fixing it like this:
self.units.enemy.townhalls.iter().all(|t| t.is_further(7.0, *loc))
    && self.enemy_start.is_further(7.0, *loc))

Fixed in fdedea0.

Fixed in fdedea0.


Tekton pipeline improvement for building stacks

Checklist:

[X] Read the Code of Conduct and Contributing Guidelines.

[X] Followed the commit message guidelines.

Updates to the collections

Update download_cli.sh to work outside of Travis - used within the Tekton pipeline
Update install_yq.sh to use curl to be consistent with download_cli.sh
Fix passing of the buildah format parameter
Add Tekton pipline resources so it's easier to run the build directly from Tekton dashboard

Related Issues:

Closing as the code already got copied into the release-0.6 branch.


Have Setup.py copy config.example.js to config.js

setup.py allows users to get printingRPC set up with all it's dependencies.
We can also use it to copy api/config/config.example.js to api/config/config.js
How to do it
within this if block, we check the user's OS type.
We can add some logic like:
if user_os == 'Darwin' or user_os == 'Linux':
    setup_status = os.system('./util/setup-scripts/setup.sh')
    # handle copying for mac os or linux here
elif user_os == 'Windows':
    setup_status = os.system('util\setup-scripts\setup.bat')
    # handle copying for windows here

Sarah found that os.path.exists() can be used to check if config.js is there or not
If it doesn't exist, just copy the file using os.system()

 os.path.exists("api/config/config.example.js")
os.system("cp api/config/config.example.js  api/config/config.js")


Fix Live coarse universe carrying over securities from previous day

Description

The default value of QCAlgorithm.UniverseSettings.MinimumTimeInUniverse has been changed from TimeSpan.FromDays(1) to TimeSpan.Zero.

Related Issue
Closes #3287
Motivation and Context
Live algorithms using Coarse universe selection were including symbols selected on the previous day.
This is caused by the fact that in Live mode Coarse universe selection is not triggered exactly at the same time every day, but it can happen several minutes before (or after) the 24-hour offset from the time of the previous day.
Requires Documentation Change
No.
How Has This Been Tested?
New unit test included.
Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Non-functional change (xml comments/documentation/etc)

Checklist:

[x] My code follows the code style of this project.
[x] I have read the CONTRIBUTING document.
[x] I have added tests to cover my changes.
[x] All new and existing tests passed.
[x] My branch follows the naming convention bug-<issue#>-<description> or feature-<issue#>-<description>

Per discussion need to think about this in a broader context to see if we can solve it neatly. Agree with @mchandschuh 's comment changing the CoarseFundamental Universe setting for the time in universe is OK;
Other options discussed were

Changing the refresh frequency of the universe to remove these redundant securities more often than 1 day;
Setting a scheduled time for the universe to run; say 8am each day, for outside of coarse time variance.
Setting a dynamic "minimum in universe" period for the Coarse based on when the live feed arrives.

The other current live universe timing issue is the option daily poll at midnight for the new contract list is happening when IB is closed -- resulting in any option live subscription requests failing and killing LEAN. This could also be handled with a scheduled universe event.


Update minimum RAM for Flye

Hi!
To run, Flye needs to first get all the reads in the memory, therefore, the minimum RAM requirement equals the (uncompressed) reads file size. Would it be possible to modify the RAM to something like 1.2 times the reads file size?
Now it is:
toolshed.g2.bx.psu.edu/repos/bgruening/flye/flye/.*:
  cores: 20
  mem: 60

:)

You can define rules, similar to https://github.com/galaxyproject/tpv-shared-database/blob/main/tools.yml#L204
Or this example here: https://github.com/usegalaxy-eu/infrastructure-playbook/blob/master/files/galaxy/tpv/tools.yml#L695
You can also write more complex rules as we have done for hifiasm: https://github.com/usegalaxy-eu/infrastructure-playbook/blob/master/files/galaxy/tpv/tools.yml

Thanks for pointing this out - it'll make a great example for the docs too. A rule like this should work:
toolshed.g2.bx.psu.edu/repos/bgruening/flye/flye/.*:
  cores: 20
  mem: min(input_size*1.2, 256)


Update Proxy SHA to latest with MetricImpl optimizations (release-1.0).

This is far from finished, but it reduces memory usage by ~10%.
Pulling the following changes from github.com/istio/proxy:
2656f34 Update Envoy SHA to latest with MetricImpl optimizations (release-1.0). (#1939)
Pulling the following changes from github.com/envoyproxy/envoy:
c1cc68dda stats: refactoring MetricImpl without strings (#4190)
36809d80a fuzz: coverage profile generation instructions. (#4193)
ba40cc933 upstream: rebuild cluster when health check config is changed (#4075)
05c0d52d3 build: use clang-6.0. (#4168)
01f403ec4 thrift_proxy: introduce header transport (#4082)
564d256fb tcp: allow connection pool callers to store protocol state (#4131)
3e1d643b9 configs: match latest API changes (#4185)
bc6a10c2f Fix wrong mock function name. (#4187)
e994c1c0b Bump yaml-cpp so it builds with Visual Studio 15.8 (#4182)
3d1325e89 Converting envoy configs to V2 (#2957)
8d0680feb Add timestamp to HealthCheckEvent definition (#4119)
497efb95b server: handle non-EnvoyExceptions safely if thrown in constructor. (#4173)
6d6fafdb3 config: strengthen validation for gRPC config sources. (#4171)
132302caf fuzz: reduce log level when running under fuzz engine. (#4161)
7c04ac255 test: fix V6EmptyOptions in coverage with IPv6 enable (#4155)
1b2219bd7 ci: remove deprecated bazel --batch option (#4166)
2db6a4ce1 ci: update clang to version 6.0 in the Ubuntu build image. (#4157)
71152b710 ratelimit: Add ratelimit custom response headers (#4015)
306287418 ssl: make Ssl::Connection const everywhere (#4179)
706e26238 Handle validation of non expiring tokens in jwt_authn filter (#4007)
f06e9588a fuzz: tag trivial fuzzers with no_fuzz. (#4156)
27fb1d353 thrift_proxy: add service name matching to router implementation (#4130)
8c189a552 Make over provisioning factor configurable (#4003)
6c08fb43c Making test less flaky (#4149)
592775b7b fuzz: bare bones HCM fuzzer. (#4118)
For istio/istio#7912.
Signed-off-by: Piotr Sikora<EMAIL_ADDRESS>

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: costinm
If they are not already assigned, you can assign the PR to them by writing /assign @costinm in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rkpagadala please make sure this is merged before daily is cut in the morning, thanks!

/lgtm
/approve

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: lizan
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: costinm
If they are not already assigned, you can assign the PR to them by writing /assign @costinm in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


CLOUD-831 Introduce EventBus in order support asynch communication wi…

Introduce EventBus in order support asynch communication with cloud providers

Reactor was replaced by EventBus
New service provider interface is asynch and synchronisation with Flow will be done by Promises which is properly supported only with EventBus + Streams

Jenkins build finished, all tests passed.
Refer to this link for build results: http://ci.sequenceiq.com/job/cloudbreak-pull-request/1295/

LGTM


Unable to upgrade Helm Chart

Hi Team,
I am working on Helm Chart and it working as expected when its does the fresh install of K9s objects like deployment, pvc, services etc. But When I try ti upgrade the existing deployment again, the Helm throws following error :

Output of helm version:
version.BuildInfo{Version:"v3.8.1", GitCommit:"5cb9af4b1b271d11d7a97a71df3ac337dd94ad37", GitTreeState:"clean", GoVersion:"go1.17.5"}
Output of kubectl version:
Client Version: version.Info{Major:"1", Minor:"21", GitVersion:"v1.21.5", GitCommit:"aea7bbadd2fc0cd689de94a54e5b7b758869d691", GitTreeState:"clean", BuildDate:"2021-09-15T21:10:45Z", GoVersion:"go1.16.8", Compiler:"gc", Platform:"windows/amd64"}
Server Version: version.Info{Major:"1", Minor:"20+", GitVersion:"v1.20.15-eks-a64ea69", GitCommit:"03450cdabfc4162d4e447e6d8c5037efe6d29742", GitTreeState:"clean", BuildDate:"2022-05-12T18:44:04Z", GoVersion:"go1.15.15", Compiler:"gc", Platform:"linux/amd64"}
Cloud Provider/Platform (AKS, GKE, Minikube etc.):
EKS

@rav17 Please check your network issue. Thanks very much.

@yxxhero . I am a bit confused here, if it was netwrok issue, then the helm chart shouldn't be able to do the installation at the first place. the issue is its happening only during the upgrade of the already installed deployment using the same Helm Chart


[Exclusivity] Improve static enforcement diagnostics

Static diagnostics now refer to the identifier for the variable requiring
exclusive diagnostics. Additionally, when two accesses conflict we now always
emit the main diagnostic on the first modifying access and the note on either
the second modifying access or the read.
The diagnostics also now highlight the source range for the expression
beginning the access.

@swift-ci Please smoke test and merge


1.5.6 on Azure ?

RancherOS Version: 1.5.4
Azure
Hi!
Latest version of rancher OS is 1.5.6 but on Azure cloud I'm only finding following offers
[
  {
    "offer": "rancheros",
    "publisher": "rancher",
    "sku": "os",
    "urn": "rancher:rancheros:os:1.5.1",
    "version": "1.5.1"
  },
  {
    "offer": "rancheros",
    "publisher": "rancher",
    "sku": "os152",
    "urn": "rancher:rancheros:os152:1.5.2",
    "version": "1.5.2"
  },
  {
    "offer": "rancheros",
    "publisher": "rancher",
    "sku": "os153",
    "urn": "rancher:rancheros:os153:1.5.3",
    "version": "1.5.3"
  },
  {
    "offer": "rancheros",
    "publisher": "rancher",
    "sku": "os154",
    "urn": "rancher:rancheros:os154:1.5.4",
    "version": "1.5.4"
  }
]

Is there a plan to publish 1.5.6 ?
Thanks!

Look https://github.com/rancher/os/issues/3000#issuecomment-679221210

Oh ok. Sad to hear that.


useTransition leave doesn't fire when something toggles its target value

🐛 Bug Report
useTransition spring is using a stateful boolean to toggle. When that boolean gets set to false by another function, the leave animation doesn't fire and the element leaves from the DOM.
To Reproduce
Steps to reproduce the behavior:
see Codesandbox example. Hit the See matches button. Then type something into the input. The onChange of the input toggles the boolean that the useTransition is tracking. Notice that the list of people animates in but not out.
Expected behavior
The leave animation should fire when the function runs that toggles the boolean that the useTransition targets - fired by the input's onChange.
Link to repro (highly encouraged)
https://codesandbox.io/s/search-results-count-osgii
Environment

react-spring v8.0.27
react v16.12.0

Please try with v9:
npm install react-spring@next

I've updated the codesandbox example to use v9 beta.34 (next) and the same issue occurs.

Here's your sandbox using the latest canary.
https://codesandbox.io/s/search-results-count-ksvl8
But the problem was you wrapped your matchTransitions call with {showMatches && (...)}.

@aleclarson I completely missed that, thanks for pointing it out 🙏


fix logging

dont call _element_to_string which will in some cases attempt to get attributes or text of an attempt after it has been removed from the DOM, causing a StaleElementReferenceException
@DramaFever/qa

LGTM


Fix data page statistics when all rows are null in a data page

Which issue does this PR close?
Closes #11280.
Rationale for this change
When all rows for a data page are null the min and max statistics should be present but null. Some of the data page statistics iterators were incorrectly omitting statistics rather than setting them to null. This results in an array whose length is different from the number of data pages.
What changes are included in this PR?
Adds test for data page statistics for all data types when all rows in a data page are null. Fixes data page statistics iterators that fail these tests.
Are these changes tested?
Yes.
Are there any user-facing changes?
No.

Let's merge this one in so we can proceed with getting https://github.com/apache/datafusion/pull/11319 ready

THanks again@


BlockBasedChunkMeta storage

Code Location:
https://github.com/CivMC/CivModCore/blob/a71661ef833e938969c975c174e1bed4c28b00a5/paper/src/main/java/vg/civcraft/mc/civmodcore/world/locations/chunkmeta/block/BlockBasedChunkMeta.java#L35

Problem:
There is no good justification for a generic array construction over using an ArrayList. Arrays have a static storage size, so the stored object here seems to already introduce another level of indirection, negating the O(1) access advantage of arrays.

Solution:
Rewrite this with proper generic collections to make the code more clear.

I'm closing this out as something that we won't fix. It could be revisited in the future, but it's not within our capacity to work on right now.


OrbitPlotter error in the new version

I used the following code before to draw the plots and it worked very well.
from astropy import units as u
from poliastro.plotting import OrbitPlotter
from poliastro.twobody import Orbit
from poliastro.core.elements import coe2rv
from poliastro.bodies import Earth
import matplotlib.pyplot as plt
import math

Req = Earth.R.to(u.km).value
Earth_k = Earth.k

def keplerian2cartesian_alt(kepler):

    a=(kepler[0]+kepler[1]+Req*2)*1000/2  # m
    e=(kepler[0]-kepler[1])/(kepler[0]+kepler[1]+Req*2)
    p = a * (1 - e ** 2)

    return coe2rv(Earth_k, p, e, kepler[2], kepler[3], kepler[4], kepler[5])

op = OrbitPlotter()

r0, v0= keplerian2cartesian_alt([8000, 600, 64.3*math.pi/180,  0, 310*math.pi/180,0])
r1, v1= keplerian2cartesian_alt([40000, 3000, 64.3*math.pi/180,  0, 270*math.pi/180,math.pi])

o0=Orbit.from_vectors(Earth, r0*u.km/1000, v0*u.km/u.s/1000)
o1=Orbit.from_vectors(Earth, r1*u.km/1000, v1*u.km/u.s/1000)

op.plot(o0, label="Initial orbit")
op.plot(o1, label="Transfer orbit")
plt.show()

After the recent package update I get the following error:
Traceback (most recent call last):
  File "...\test.py", line 2, in <module>
    from poliastro.plotting import OrbitPlotter
ImportError: cannot import name 'OrbitPlotter' from 'poliastro.plotting' (...\miniconda3\lib\site-packages\poliastro\plotting\__init__.py)

Can you please help to adjust this code to the new package version?

@Tarlan0001 Replacing OrbitPlotter with StaticOrbitPlotter would work.

as @jains8844 said, you have to do from poliastro.plotting.static import StaticOrbitPlotter as OrbitPlotter and everything will stay the same. Sorry for not putting a deprecation warning! :innocent: Please let us know if this works.

Works, thanks!

as @jains8844 said, you have to do from poliastro.plotting.static import StaticOrbitPlotter as OrbitPlotter and everything will stay the same. Sorry for not putting a deprecation warning! 😇 Please let us know if this works.

What about 3D plots?

@Tarlan0001 does from poliastro.plotting import OrbitPlotter3D work for you?

Is something wrong here? Sorry, i didn't find an explanation in the documentation.
from astropy import units as u
from poliastro.plotting import OrbitPlotter3D
from poliastro.twobody import Orbit
from poliastro.core.elements import coe2rv
from poliastro.bodies import Earth
import math

Req = Earth.R.to(u.km).value
Earth_k = Earth.k

def keplerian2cartesian(kepler):

    a=(kepler[0]+kepler[1]+Req*2)*1000/2  # m
    e=(kepler[0]-kepler[1])/(kepler[0]+kepler[1]+Req*2)
    p = a * (1 - e ** 2)

    return coe2rv(Earth_k, p, e, kepler[2], kepler[3], kepler[4], kepler[5])

op = OrbitPlotter3D()

r0, v0= keplerian2cartesian([8000,  600, 64.3*math.pi/180, 0, 300*math.pi/180,0])
r1, v1= keplerian2cartesian([39754, 600, 64.3*math.pi/180, 0, 270*math.pi/180,0])
r2, v2= keplerian2cartesian([2000,  800, 80*math.pi/180,   0, 300*math.pi/180,math.pi])

o0=Orbit.from_vectors(Earth, r0*u.km/1000, v0*u.km/u.s/1000)
o1=Orbit.from_vectors(Earth, r1*u.km/1000, v1*u.km/u.s/1000)
o2=Orbit.from_vectors(Earth, r2*u.km/1000, v2*u.km/u.s/1000)

op.plot(o0)
op.plot(o1)
op.plot(o2)

plt.show()

@astrojuanlu Indeed, there is no working example for OrbitPlotter3D for a custom orbit...

@Tarlan0001 please try these :) https://docs.poliastro.space/en/stable/examples/Plotting in 3D.html

Your code above won't work, because plt.show() is for matplotlib, but OrbitPlotter3D is based on Plotly

Thank you. Using Plotly, even for the examples in the link, the plot isn't opened automatically. I set up the pio.renderers.default = "browser". I can't see the plot.
Can you, please, share a working example for my code?

Your code works for me:

Perhaps you have some outdated versions of notebook, ipywidgets or plotly. Please try upgrading your dependencies, displaying a simple Plotly plot (without poliastro) and then running your code again.

Dear @astrojuanlu ,
Plotly works well, checked this code:
fig = dict({
    "data": [{"type": "bar",
              "x": [1, 2, 3],
              "y": [1, 3, 2]}],
    "layout": {"title": {"text": "A Figure Specified By Python Dictionary"}}
})
import plotly.io as pio
pio.show(fig)

But my code above doesn't show the plot. I've even reinstalled Python, tried to run the code from cmd, from Pyzo. No errors are shown, but it doesn't work as expected.
What would you suggest?

I didn't expect the basic Plotly plot to work from cmd or Pyzo to be honest, I though this would only work on Jupyter notebook. Can you share a screenshot with a jupyter notebook containing these two cells?
Cell 1:
fig = dict({
    "data": [{"type": "bar",
              "x": [1, 2, 3],
              "y": [1, 3, 2]}],
    "layout": {"title": {"text": "A Figure Specified By Python Dictionary"}}
})
import plotly.io as pio
pio.show(fig)

Cell 2:
from poliastro import iss
from poliastro.plotting import OrbitPlotter3D
plotter = OrbitPlotter3D()
plotter.plot(iss)

And also please share the versions of all the dependencies installed in your environment (for example using pip freeze).

Closing this issue as inactive, feel free to open new ones!


deploy error after fullfill .env parameters

Error info :
Running build in San Francisco, USA (West) – sfo1
18:57:30.576 | Cloning github.com/gumplus/room-GPT (Branch: main, Commit: e1e0dd1)
18:57:30.715 | Previous build cache not available
18:57:31.870 | Cloning completed: 1.294s
18:57:32.078 | Running "vercel build"
18:57:32.648 | Vercel CLI 28.18.5
18:57:32.968 | Installing dependencies...
18:57:39.377 | npm WARN deprecated<EMAIL_ADDRESS>This package has been deprecated and is no longer maintained. Please use @rollup/plugin-inject.
18:57:39.647 | npm WARN deprecated<EMAIL_ADDRESS>Please use @jridgewell/sourcemap-codec instead
18:57:43.315 | npm WARN deprecated<EMAIL_ADDRESS>This functionality has been moved to @npmcli/fs
18:57:58.619 |
18:57:58.620 | > postinstall
18:57:58.620 | > prisma generate || true
18:57:58.620 |
18:57:59.515 | Environment variables loaded from .env
18:57:59.518 | Prisma schema loaded from prisma/schema.prisma
18:58:00.497 |
18:58:00.498 | ✔ Generated Prisma Client (4.11.0 | library) to ./node_modules/@prisma/client in 222ms
18:58:00.498 | You can now start using Prisma Client in your code. Reference: https://pris.ly/d/client
18:58:00.498 | 18:58:00.498 | import { PrismaClient } from '@prisma/client' 18:58:00.498 | const prisma = new PrismaClient() 18:58:00.498 |
18:58:00.574 |
18:58:00.574 | added 963 packages in 27s
18:58:00.574 |
18:58:00.575 | 170 packages are looking for funding
18:58:00.575 | run npm fund for details
18:58:00.606 | Detected Next.js version: 13.1.6
18:58:00.619 | Detected package-lock.json generated by npm 7+...
18:58:00.620 | Running "npm run build"
18:58:01.026 |
18:58:01.027 | > build
18:58:01.027 | > prisma generate && prisma migrate deploy && next build
18:58:01.027 |
18:58:01.929 | Environment variables loaded from .env
18:58:01.932 | Prisma schema loaded from prisma/schema.prisma
18:58:02.950 |
18:58:02.950 | ✔ Generated Prisma Client (4.11.0 | library) to ./node_modules/@prisma/client in 235ms
18:58:02.950 | You can now start using Prisma Client in your code. Reference: https://pris.ly/d/client
18:58:02.950 | 18:58:02.950 | import { PrismaClient } from '@prisma/client' 18:58:02.951 | const prisma = new PrismaClient() 18:58:02.951 |
18:58:05.145 | ┌─────────────────────────────────────────────────────────┐
18:58:05.146 | │  Update available 4.11.0 -> 4.12.0                      │
18:58:05.146 | │  Run the following to update                            │
18:58:05.146 | │    npm i --save-dev prisma@latest                       │
18:58:05.146 | │    npm i @prisma/client@latest                          │
18:58:05.146 | └─────────────────────────────────────────────────────────┘
18:58:06.084 | Environment variables loaded from .env
18:58:06.085 | Prisma schema loaded from prisma/schema.prisma
18:58:06.090 | Datasource "db": PostgreSQL database "neondb", schema "public" at "ep-wild-credit-819120.us-west-2.aws.neon.tech"
18:58:09.836 |
18:58:09.836 | 5 migrations found in prisma/migrations
18:58:09.836 |
18:58:10.228 |
18:58:10.228 | No pending migrations to apply.
18:58:10.708 | info  - Loaded env from /vercel/path0/.env
18:58:10.884 | Attention: Next.js now collects completely anonymous telemetry regarding usage.
18:58:10.884 | This information is used to shape Next.js' roadmap and prioritize features.
18:58:10.884 | You can learn more, including how to opt-out if you'd not like to participate in this anonymous program, by visiting the following URL:
18:58:10.885 | https://nextjs.org/telemetry
18:58:10.886 |
18:58:11.051 | info  - Linting and checking validity of types...
18:58:17.241 | info  - Creating an optimized production build...
18:58:31.393 | info  - Compiled successfully
18:58:31.393 | info  - Collecting page data...
18:58:31.786 | TypeError [ERR_INVALID_URL]: Invalid URL
18:58:31.786 | at new NodeError (node:internal/errors:400:5)
18:58:31.786 | at URL.onParseError (node:internal/url:565:9)
18:58:31.786 | at new URL (node:internal/url:645:5)
18:58:31.787 | at parseUrl (/vercel/path0/node_modules/next-auth/utils/parse-url.js:17:16)
18:58:31.787 | at Object. (/vercel/path0/node_modules/next-auth/react/index.js:72:34)
18:58:31.787 | at Module._compile (node:internal/modules/cjs/loader:1218:14)
18:58:31.787 | at Module._extensions..js (node:internal/modules/cjs/loader:1272:10)
18:58:31.787 | at Module.load (node:internal/modules/cjs/loader:1081:32)
18:58:31.787 | at Module._load (node:internal/modules/cjs/loader:922:12)
18:58:31.788 | at Module.require (node:internal/modules/cjs/loader:1105:19) {
18:58:31.788 | input: '',
18:58:31.788 | code: 'ERR_INVALID_URL'
18:58:31.788 | }
18:58:31.789 |
18:58:31.789 | > Build error occurred
18:58:31.793 | Error: Failed to collect page data for /dashboard
18:58:31.793 | at /vercel/path0/node_modules/next/dist/build/utils.js:963:15
18:58:31.793 | at process.processTicksAndRejections (node:internal/process/task_queues:95:5) {
18:58:31.793 | type: 'Error'
18:58:31.794 | }
18:58:31.873 | Error: Command "npm run build" exited with 1
18:58:32.205 | Deployment completed
18:58:32.164 | BUILD_UTILS_SPAWN_1: Command "npm run build" exited with 1

Have you try adding NEXTAUTH_URL in your env?

Hey all. I've just simplified the repo to remove auth and payments so you can clone and deploy very easily, only with a Replicate environment variable. Try it out and if you still have any problems, please open a new issue and I will take a look!


proxy emit

We should fire emit calls if we absolutely need to. This should shave a few more milliseconds.

Button presses are down to around 80 milliseconds, continues are down from 17ms to 15ms.


Add Cursor to new Java client and use SQLException

@alainjobart
This provides translation of result row data into native Java types.
It's a slightly different design than Cursor in the old client, which
was more like an iterator. This one is more like a JDBC ResultSet.
I didn't call it a ResultSet because it doesn't implement the full
interface.
I also switched from custom exceptions to using the SQLException
hierarchy. It should have most of the error categories we need, and if
necessary we can add new exceptions as sub-categories. That way,
managing errors and retries should be much more similar to what someone
might be used to with JDBC.

You're saying SQLException can allow the user to find about the cases we want, like duplicate key and throttling error? (I see you have a TODO to convert it to the right thing).
LGTM if that's the case.

Duplicate key would be SQLIntegrityConstraintViolationException. Throttling would probably be a custom subclass of SQLTransientException. There's also specific subclasses already for things like timeouts, deadlocks, permission denied, etc. We should have access to the MySQL error code, so we can map them the same way the MySQL JDBC driver would.


MKLDNN fallback when not recording gradients and calling backwards

Description
PR to address (https://github.com/apache/incubator-mxnet/issues/10994). There is a case where users may want to run the backwards pass but not record any gradients (https://mxnet.incubator.apache.org/api/python/autograd/autograd.html#mxnet.autograd.record - this should be addressed in a later PR as it does not make sense). MKLDNN does not handle this case and instead we will fallback.
Checklist
Essentials
Please feel free to remove inapplicable items for your PR.

[ ] The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
[ ] Changes are complete (i.e. I finished coding on this PR)
[ ] All changes have test coverage:
Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
[ ] Code is well-documented:
For user-facing API changes, API doc string has been updated.
For new C++ functions in header files, their functionalities and arguments are documented.
For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
[ ] To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

[ ] Feature1, tests, (and when applicable, API doc)
[ ] Feature2, tests, (and when applicable, API doc)

Comments

If this change is a backward incompatible change, why must this change be made.
Interesting edge cases to note here

This PR is waiting merge of https://github.com/apache/incubator-mxnet/pull/12019

@azai91 #12019 was merged. Is it still WIP?

still working in progress. working with customer on different issue. will fix this next.

@mxnet-label-bot [pr-work-in-progress]

@azai91 requesting an update on this PR.

@azai91 Any update on this PR?

@azai91 Thanks for the contribution!
Could you please update this PR?

@azai91 any update on this PR. you could close it and reopen the PR once the changes are ready.
@sandeep-krishnamurthy @anirudh2290

@azai91 could you address the CI failure?

@mxnet-label-bot add [pr-awaiting-testing]

still investigating. this PR goes beyond the the original issue I was addressing.

addressed original problem with issuse (https://github.com/apache/incubator-mxnet/issues/10994). However, I discovered another issue and created a new PR to address (https://github.com/apache/incubator-mxnet/issues/13445).

@azai91 Thanks for taking the time to dive into the issue, could you resolve the conflict and trigger CI if still working on this?

@azai91 - can you please rebase and fix CI issues? @pengzhao-intel - You may be interested in this PR?

Actually, this is a system-level issue that how do we handle the situation the backward is called with the is_train=False. I think it doesn't can be done by the simple bypass.
We will have the offline discussion first and back later @TaoLv .

ping, any update @azai91

@azai91 Could you please rebase and fix the CI issues?

@mxnet-label-bot update [pr-awaiting-response, pr-work-in-progress]


⚠ Bofrost.be has degraded performance

In a0b00b3, Bofrost.be (https://www.bofrost.be) experienced degraded performance:

HTTP code: 200
Response time: 1857 ms

Resolved: Bofrost.be performance has improved in b1fec33 after 22 minutes.


WIP: Add multiple write support

This is my initial draft to support write of multiple variables using a single request. The implementation is based on the implementation in Sharp7, but actually supporting value conversion and using infrastructure from S7NetPlus.
It's currently lacking some checks (like validating data size), but it does work. It actually supports write of separate bits as well. I guess it might only work for the DataBlock area, as I didn't focus on any other areas. Also, I didn't bother to add xmldoc yet either.
I intend to make additional changes to this, so I'm not considering this done, but I'd love to get some feedback early on.

Also it would be nice if you create unit tests for the new features

Updated the code to conform more to the rest of s7netplus. Probably could be refactored to use shared code to construct TPKT, ISO DT and S7 Job Request, but I think it's OK in current form. I intend to still add unit tests, however I have verified that this does work, both against an Siemens S7-1500 PLC and against Snap7 running as server.


Interview with Linnaeus University

Context
Carry out user research with Higher Education institutes to understand their educational needs in regards to green software.
Actions

[ ] Send interview request to GSF Org lead
[ ] Schedule interview
[ ] Send pre-interview email
[ ] Conduct interview
[ ] Process interview notes
[ ] Send post-interview email
[ ] Add to HEE mailing list

Hey @tholewis are there any other actions you can think of that need to go on the above list?

I think this process is good. Do they get to opt-in for the HEE mailing list?


Clean up task on reindex_atomic fail

Environment

Algoliax version (mix deps): 0.6.0

Expected behavior
If reindex_atomic/0 fails, temporary index and indexing status should be reset.
Actual behavior
If reindex_atomic/0 fails, temporary index still present and indexing status still true

close by #47