HBASE-22863 : Cleanup transitive Jackson1 vulnerable dependencies(forward-port HBASE-22728)

Partly forwardport from HBASE-22728 to master and branch-2

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
37
Docker mode activated.

_ Prechecks _

+1
dupname
0
No case conflicting files found.

+1
@author
0
The patch does not contain any @author tags.

-0
test4tests
0
The patch doesn't appear to include any new or modified tests.  Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ master Compile Tests _

0
mvndep
34
Maven dependency ordering for branch

+1
mvninstall
340
master passed

+1
compile
423
master passed

+1
shadedjars
295
branch has no errors when building our shaded downstream artifacts.

+1
javadoc
284
master passed

_ Patch Compile Tests _

0
mvndep
14
Maven dependency ordering for patch

+1
mvninstall
319
the patch passed

+1
compile
425
the patch passed

+1
javac
425
the patch passed

+1
whitespace
0
The patch has no whitespace issues.

+1
xml
21
The patch has no ill-formed XML file.

+1
shadedjars
295
patch has no errors when building our shaded downstream artifacts.

+1
hadoopcheck
1021
Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.

+1
javadoc
285
the patch passed

_ Other Tests _

+1
unit
175
hbase-common in the patch passed.

+1
unit
34
hbase-hadoop2-compat in the patch passed.

+1
unit
46
hbase-zookeeper in the patch passed.

+1
unit
68
hbase-http in the patch passed.

+1
unit
203
hbase-procedure in the patch passed.

+1
unit
8789
hbase-server in the patch passed.

+1
unit
1005
hbase-mapreduce in the patch passed.

+1
unit
55
hbase-testing-util in the patch passed.

+1
unit
223
hbase-thrift in the patch passed.

+1
unit
435
hbase-shell in the patch passed.

+1
unit
234
hbase-endpoint in the patch passed.

+1
unit
856
hbase-backup in the patch passed.

+1
unit
68
hbase-it in the patch passed.

+1
unit
288
hbase-rest in the patch passed.

+1
unit
117
hbase-examples in the patch passed.

+1
unit
38
hbase-external-blockcache in the patch passed.

+1
unit
39
hbase-shaded-testing-util in the patch passed.

+1
asflicense
481
The patch does not generate ASF License warnings.

17489

Subsystem
Report/Notes

Docker
Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-505/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/505

Optional Tests
dupname asflicense javac javadoc unit shadedjars hadoopcheck xml compile

uname
Linux 06fed7d11782 4.15.0-55-generic #60-Ubuntu SMP Tue Jul 2 18:22:20 UTC 2019 x86_64 GNU/Linux

Build tool
maven

Personality
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-505/out/precommit/personality/provided.sh

git revision
master / 43a0ec80fa

Default Java
1.8.0_181

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-505/1/testReport/

Max. process+thread count
5192 (vs. ulimit of 10000)

modules
C: hbase-common hbase-hadoop2-compat hbase-zookeeper hbase-http hbase-procedure hbase-server hbase-mapreduce hbase-testing-util hbase-thrift hbase-shell hbase-endpoint hbase-backup hbase-it hbase-rest hbase-examples hbase-external-blockcache hbase-shaded/hbase-shaded-testing-util U: .

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-505/1/console

versions
git=2.11.0 maven=2018-06-17T18:33:14Z)

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
33
Docker mode activated.

_ Prechecks _

+1
dupname
1
No case conflicting files found.

+1
@author
0
The patch does not contain any @author tags.

-0
test4tests
0
The patch doesn't appear to include any new or modified tests.  Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ master Compile Tests _

0
mvndep
33
Maven dependency ordering for branch

+1
mvninstall
337
master passed

+1
compile
423
master passed

+1
shadedjars
294
branch has no errors when building our shaded downstream artifacts.

+1
javadoc
284
master passed

_ Patch Compile Tests _

0
mvndep
15
Maven dependency ordering for patch

+1
mvninstall
323
the patch passed

+1
compile
424
the patch passed

+1
javac
424
the patch passed

+1
whitespace
0
The patch has no whitespace issues.

+1
xml
21
The patch has no ill-formed XML file.

+1
shadedjars
297
patch has no errors when building our shaded downstream artifacts.

+1
hadoopcheck
1009
Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.

+1
javadoc
286
the patch passed

_ Other Tests _

+1
unit
174
hbase-common in the patch passed.

+1
unit
34
hbase-hadoop2-compat in the patch passed.

+1
unit
46
hbase-zookeeper in the patch passed.

+1
unit
67
hbase-http in the patch passed.

+1
unit
207
hbase-procedure in the patch passed.

+1
unit
9023
hbase-server in the patch passed.

+1
unit
1087
hbase-mapreduce in the patch passed.

+1
unit
55
hbase-testing-util in the patch passed.

+1
unit
231
hbase-thrift in the patch passed.

+1
unit
432
hbase-shell in the patch passed.

+1
unit
236
hbase-endpoint in the patch passed.

+1
unit
859
hbase-backup in the patch passed.

+1
unit
65
hbase-it in the patch passed.

+1
unit
294
hbase-rest in the patch passed.

+1
unit
116
hbase-examples in the patch passed.

+1
unit
36
hbase-external-blockcache in the patch passed.

+1
unit
40
hbase-shaded-testing-util in the patch passed.

+1
asflicense
463
The patch does not generate ASF License warnings.

17787

Subsystem
Report/Notes

Docker
Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-505/2/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/505

Optional Tests
dupname asflicense javac javadoc unit shadedjars hadoopcheck xml compile

uname
Linux f66a2e3a1ce4 4.15.0-55-generic #60-Ubuntu SMP Tue Jul 2 18:22:20 UTC 2019 x86_64 GNU/Linux

Build tool
maven

Personality
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-505/out/precommit/personality/provided.sh

git revision
master / 7903f55c18

Default Java
1.8.0_181

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-505/2/testReport/

Max. process+thread count
5137 (vs. ulimit of 10000)

modules
C: hbase-common hbase-hadoop2-compat hbase-zookeeper hbase-http hbase-procedure hbase-server hbase-mapreduce hbase-testing-util hbase-thrift hbase-shell hbase-endpoint hbase-backup hbase-it hbase-rest hbase-examples hbase-external-blockcache hbase-shaded/hbase-shaded-testing-util U: .

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-505/2/console

versions
git=2.11.0 maven=2018-06-17T18:33:14Z)

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
40
Docker mode activated.

_ Prechecks _

+1
dupname
0
No case conflicting files found.

+1
@author
0
The patch does not contain any @author tags.

-0
test4tests
0
The patch doesn't appear to include any new or modified tests.  Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ master Compile Tests _

0
mvndep
37
Maven dependency ordering for branch

+1
mvninstall
352
master passed

+1
compile
431
master passed

+1
shadedjars
288
branch has no errors when building our shaded downstream artifacts.

+1
javadoc
303
master passed

_ Patch Compile Tests _

0
mvndep
16
Maven dependency ordering for patch

+1
mvninstall
327
the patch passed

+1
compile
458
the patch passed

+1
javac
458
the patch passed

+1
whitespace
0
The patch has no whitespace issues.

+1
xml
20
The patch has no ill-formed XML file.

+1
shadedjars
296
patch has no errors when building our shaded downstream artifacts.

+1
hadoopcheck
992
Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.

+1
javadoc
286
the patch passed

_ Other Tests _

+1
unit
173
hbase-common in the patch passed.

+1
unit
33
hbase-hadoop2-compat in the patch passed.

+1
unit
48
hbase-zookeeper in the patch passed.

+1
unit
63
hbase-http in the patch passed.

+1
unit
216
hbase-procedure in the patch passed.

+1
unit
8202
hbase-server in the patch passed.

+1
unit
994
hbase-mapreduce in the patch passed.

+1
unit
55
hbase-testing-util in the patch passed.

+1
unit
221
hbase-thrift in the patch passed.

+1
unit
434
hbase-shell in the patch passed.

+1
unit
228
hbase-endpoint in the patch passed.

+1
unit
888
hbase-backup in the patch passed.

+1
unit
66
hbase-it in the patch passed.

+1
unit
281
hbase-rest in the patch passed.

+1
unit
106
hbase-examples in the patch passed.

+1
unit
35
hbase-external-blockcache in the patch passed.

+1
unit
39
hbase-shaded-testing-util in the patch passed.

+1
asflicense
489
The patch does not generate ASF License warnings.

16936

Subsystem
Report/Notes

Docker
Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-505/4/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/505

Optional Tests
dupname asflicense javac javadoc unit shadedjars hadoopcheck xml compile

uname
Linux 6db552f95121 4.4.0-139-generic #165-Ubuntu SMP Wed Oct 24 10:58:50 UTC 2018 x86_64 GNU/Linux

Build tool
maven

Personality
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-505/out/precommit/personality/provided.sh

git revision
master / 836f26976e

Default Java
1.8.0_181

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-505/4/testReport/

Max. process+thread count
5410 (vs. ulimit of 10000)

modules
C: hbase-common hbase-hadoop2-compat hbase-zookeeper hbase-http hbase-procedure hbase-server hbase-mapreduce hbase-testing-util hbase-thrift hbase-shell hbase-endpoint hbase-backup hbase-it hbase-rest hbase-examples hbase-external-blockcache hbase-shaded/hbase-shaded-testing-util U: .

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-505/4/console

versions
git=2.11.0 maven=2018-06-17T18:33:14Z)

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

Is it safe to just exclude these transitive dependencies? At least hadoop adds them as dependencies...

@Apache9 Since we have moved to Jackson2, we can safely exclude these dependencies. At some places, we require jackson-mapper-asl:1.9.13(CVE exposed) at test scope to run tests like HBaseTestUtility.startMiniCluster(). But definitely not required at compile scope as we would exposed these to downstreamers. This is partly forwardport from HBASE-22728 to master and branch-2.

So we need to add the jackson dependency explicitly as a test dependency in our own pom as we exclude them from the hadoop-common?

So we need to add the jackson dependency explicitly as a test dependency in our own pom as we exclude them from the hadoop-common?

Correct. Just did it here: https://github.com/apache/hbase/pull/505/files#diff-659d55cb388d174df96d2c372cfc982fR138

So what about our own UTs? How do we include the jackson1 dependencies for hbase-server test module for example?

_ Prechecks _

+1
dupname
0
No case conflicting files found.

+1
@author
0
The patch does not contain any @author tags.

-0
test4tests
0
The patch doesn't appear to include any new or modified tests.  Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ master Compile Tests _

0
mvndep
35
Maven dependency ordering for branch

+1
mvninstall
355
master passed

+1
compile
444
master passed

+1
shadedjars
298
branch has no errors when building our shaded downstream artifacts.

+1
javadoc
294
master passed

_ Patch Compile Tests _

0
mvndep
14
Maven dependency ordering for patch

+1
mvninstall
321
the patch passed

+1
compile
451
the patch passed

+1
javac
451
the patch passed

+1
whitespace
0
The patch has no whitespace issues.

+1
xml
22
The patch has no ill-formed XML file.

+1
shadedjars
299
patch has no errors when building our shaded downstream artifacts.

+1
hadoopcheck
1030
Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.

+1
javadoc
294
the patch passed

_ Other Tests _

+1
unit
177
hbase-common in the patch passed.

+1
unit
34
hbase-hadoop2-compat in the patch passed.

+1
unit
46
hbase-zookeeper in the patch passed.

+1
unit
69
hbase-http in the patch passed.

+1
unit
211
hbase-procedure in the patch passed.

+1
unit
8847
hbase-server in the patch passed.

+1
unit
1004
hbase-mapreduce in the patch passed.

+1
unit
55
hbase-testing-util in the patch passed.

+1
unit
235
hbase-thrift in the patch passed.

+1
unit
436
hbase-shell in the patch passed.

+1
unit
246
hbase-endpoint in the patch passed.

+1
unit
995
hbase-backup in the patch passed.

+1
unit
70
hbase-it in the patch passed.

+1
unit
315
hbase-rest in the patch passed.

+1
unit
137
hbase-examples in the patch passed.

+1
unit
36
hbase-external-blockcache in the patch passed.

+1
unit
39
hbase-shaded-testing-util in the patch passed.

+1
asflicense
479
The patch does not generate ASF License warnings.

17874

Subsystem
Report/Notes

Docker
Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-505/5/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/505

Optional Tests
dupname asflicense javac javadoc unit shadedjars hadoopcheck xml compile

uname
Linux<PHONE_NUMBER>e0 4.15.0-55-generic #60-Ubuntu SMP Tue Jul 2 18:22:20 UTC 2019 x86_64 GNU/Linux

Build tool
maven

Personality
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-505/out/precommit/personality/provided.sh

git revision
master / 7697d48cd7

Default Java
1.8.0_181

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-505/5/testReport/

Max. process+thread count
5260 (vs. ulimit of 10000)

modules
C: hbase-common hbase-hadoop2-compat hbase-zookeeper hbase-http hbase-procedure hbase-server hbase-mapreduce hbase-testing-util hbase-thrift hbase-shell hbase-endpoint hbase-backup hbase-it hbase-rest hbase-examples hbase-external-blockcache hbase-shaded/hbase-shaded-testing-util U: .

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-505/5/console

versions
git=2.11.0 maven=2018-06-17T18:33:14Z)

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
42
Docker mode activated.

_ Prechecks _

+1
dupname
0
No case conflicting files found.

+1
@author
0
The patch does not contain any @author tags.

-0
test4tests
0
The patch doesn't appear to include any new or modified tests.  Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ master Compile Tests _

0
mvndep
66
Maven dependency ordering for branch

+1
mvninstall
337
master passed

+1
compile
186
master passed

+1
shadedjars
287
branch has no errors when building our shaded downstream artifacts.

+1
javadoc
261
master passed

_ Patch Compile Tests _

0
mvndep
13
Maven dependency ordering for patch

+1
mvninstall
311
the patch passed

+1
compile
195
the patch passed

+1
javac
195
the patch passed

+1
whitespace
0
The patch has no whitespace issues.

+1
xml
9
The patch has no ill-formed XML file.

+1
shadedjars
289
patch has no errors when building our shaded downstream artifacts.

+1
hadoopcheck
1030
Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.

+1
javadoc
254
the patch passed

_ Other Tests _

-1
unit
11480
root in the patch failed.

+1
asflicense
169
The patch does not generate ASF License warnings.

15354

Reason
Tests

Failed junit tests
hadoop.hbase.snapshot.TestMobExportSnapshot

hbase.shaded.TestShadedHBaseTestingUtility

Subsystem
Report/Notes

Docker
Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-505/6/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/505

Optional Tests
dupname asflicense javac javadoc unit shadedjars hadoopcheck xml compile

uname
Linux d7ee38b18cd6 4.4.0-139-generic #165-Ubuntu SMP Wed Oct 24 10:58:50 UTC 2018 x86_64 GNU/Linux

Build tool
maven

Personality
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-505/out/precommit/personality/provided.sh

git revision
master / 7697d48cd7

Default Java
1.8.0_181

unit
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-505/6/artifact/out/patch-unit-root.txt

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-505/6/testReport/

Max. process+thread count
5471 (vs. ulimit of 10000)

modules
C: hbase-server hbase-mapreduce hbase-shaded/hbase-shaded-client-byo-hadoop hbase-shaded/hbase-shaded-mapreduce hbase-shaded/hbase-shaded-testing-util . U: .

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-505/6/console

versions
git=2.11.0 maven=2018-06-17T18:33:14Z)

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
39
Docker mode activated.

_ Prechecks _

+1
dupname
0
No case conflicting files found.

+1
@author
0
The patch does not contain any @author tags.

-0
test4tests
0
The patch doesn't appear to include any new or modified tests.  Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ master Compile Tests _

0
mvndep
33
Maven dependency ordering for branch

+1
mvninstall
341
master passed

+1
compile
209
master passed

+1
shadedjars
302
branch has no errors when building our shaded downstream artifacts.

+1
javadoc
271
master passed

_ Patch Compile Tests _

0
mvndep
14
Maven dependency ordering for patch

+1
mvninstall
337
the patch passed

+1
compile
191
the patch passed

+1
javac
191
the patch passed

+1
whitespace
0
The patch has no whitespace issues.

+1
xml
8
The patch has no ill-formed XML file.

+1
shadedjars
305
patch has no errors when building our shaded downstream artifacts.

+1
hadoopcheck
1045
Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.

+1
javadoc
253
the patch passed

_ Other Tests _

-1
unit
13944
root in the patch failed.

+1
asflicense
188
The patch does not generate ASF License warnings.

17909

Reason
Tests

Failed junit tests
hbase.shaded.TestShadedHBaseTestingUtility

Subsystem
Report/Notes

Docker
Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-505/7/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/505

Optional Tests
dupname asflicense javac javadoc unit shadedjars hadoopcheck xml compile

uname
Linux 4d704ff9d7b3 4.15.0-55-generic #60-Ubuntu SMP Tue Jul 2 18:22:20 UTC 2019 x86_64 GNU/Linux

Build tool
maven

Personality
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-505/out/precommit/personality/provided.sh

git revision
master / 7697d48cd7

Default Java
1.8.0_181

unit
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-505/7/artifact/out/patch-unit-root.txt

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-505/7/testReport/

Max. process+thread count
5164 (vs. ulimit of 10000)

modules
C: hbase-server hbase-mapreduce hbase-shaded/hbase-shaded-client-byo-hadoop hbase-shaded/hbase-shaded-mapreduce hbase-shaded/hbase-shaded-testing-util . U: .

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-505/7/console

versions
git=2.11.0 maven=2018-06-17T18:33:14Z)

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
71
Docker mode activated.

_ Prechecks _

+1
dupname
0
No case conflicting files found.

+1
@author
0
The patch does not contain any @author tags.

-0
test4tests
0
The patch doesn't appear to include any new or modified tests.  Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ master Compile Tests _

0
mvndep
35
Maven dependency ordering for branch

+1
mvninstall
316
master passed

+1
compile
172
master passed

+1
shadedjars
277
branch has no errors when building our shaded downstream artifacts.

+1
javadoc
265
master passed

_ Patch Compile Tests _

0
mvndep
15
Maven dependency ordering for patch

+1
mvninstall
333
the patch passed

+1
compile
177
the patch passed

+1
javac
177
the patch passed

+1
whitespace
0
The patch has no whitespace issues.

+1
xml
10
The patch has no ill-formed XML file.

+1
shadedjars
273
patch has no errors when building our shaded downstream artifacts.

+1
hadoopcheck
971
Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.

+1
javadoc
260
the patch passed

_ Other Tests _

-1
unit
16821
root in the patch failed.

+1
asflicense
171
The patch does not generate ASF License warnings.

20611

Reason
Tests

Failed junit tests
hadoop.hbase.regionserver.TestHRegion

hadoop.hbase.client.TestFromClientSide3

Subsystem
Report/Notes

Docker
Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-505/8/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/505

Optional Tests
dupname asflicense javac javadoc unit shadedjars hadoopcheck xml compile

uname
Linux ddc2209b7e07 4.4.0-137-generic #163-Ubuntu SMP Mon Sep 24 13:14:43 UTC 2018 x86_64 GNU/Linux

Build tool
maven

Personality
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-505/out/precommit/personality/provided.sh

git revision
master / 7697d48cd7

Default Java
1.8.0_181

unit
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-505/8/artifact/out/patch-unit-root.txt

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-505/8/testReport/

Max. process+thread count
5195 (vs. ulimit of 10000)

modules
C: hbase-server hbase-mapreduce hbase-shaded/hbase-shaded-client-byo-hadoop hbase-shaded/hbase-shaded-mapreduce hbase-shaded/hbase-shaded-testing-util hbase-shaded/hbase-shaded-testing-util-tester . U: .

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-505/8/console

versions
git=2.11.0 maven=2018-06-17T18:33:14Z)

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
99
Docker mode activated.

_ Prechecks _

+1
dupname
0
No case conflicting files found.

+1
@author
0
The patch does not contain any @author tags.

-0
test4tests
0
The patch doesn't appear to include any new or modified tests.  Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ master Compile Tests _

0
mvndep
36
Maven dependency ordering for branch

+1
mvninstall
352
master passed

+1
compile
202
master passed

+1
shadedjars
309
branch has no errors when building our shaded downstream artifacts.

+1
javadoc
276
master passed

_ Patch Compile Tests _

0
mvndep
14
Maven dependency ordering for patch

+1
mvninstall
333
the patch passed

+1
compile
202
the patch passed

+1
javac
202
the patch passed

+1
whitespace
0
The patch has no whitespace issues.

+1
xml
9
The patch has no ill-formed XML file.

+1
shadedjars
306
patch has no errors when building our shaded downstream artifacts.

+1
hadoopcheck
1062
Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.

+1
javadoc
270
the patch passed

_ Other Tests _

-1
unit
14947
root in the patch failed.

+1
asflicense
152
The patch does not generate ASF License warnings.

19023

Reason
Tests

Failed junit tests
hadoop.hbase.util.TestFromClientSide3WoUnsafe

Subsystem
Report/Notes

Docker
Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-505/10/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/505

Optional Tests
dupname asflicense javac javadoc unit shadedjars hadoopcheck xml compile

uname
Linux 6a248cd0b89c 4.15.0-54-generic #58-Ubuntu SMP Mon Jun 24 10:55:24 UTC 2019 x86_64 GNU/Linux

Build tool
maven

Personality
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-505/out/precommit/personality/provided.sh

git revision
master / 46abaef4be

Default Java
1.8.0_181

unit
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-505/10/artifact/out/patch-unit-root.txt

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-505/10/testReport/

Max. process+thread count
4668 (vs. ulimit of 10000)

modules
C: hbase-server hbase-mapreduce hbase-shaded/hbase-shaded-client-byo-hadoop hbase-shaded/hbase-shaded-mapreduce hbase-shaded/hbase-shaded-testing-util hbase-shaded/hbase-shaded-testing-util-tester . U: .

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-505/10/console

versions
git=2.11.0 maven=2018-06-17T18:33:14Z)

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
37
Docker mode activated.

_ Prechecks _

+1
dupname
0
No case conflicting files found.

+1
@author
0
The patch does not contain any @author tags.

-0
test4tests
0
The patch doesn't appear to include any new or modified tests.  Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ master Compile Tests _

0
mvndep
35
Maven dependency ordering for branch

+1
mvninstall
310
master passed

+1
compile
181
master passed

+1
shadedjars
279
branch has no errors when building our shaded downstream artifacts.

+1
javadoc
262
master passed

_ Patch Compile Tests _

0
mvndep
14
Maven dependency ordering for patch

+1
mvninstall
303
the patch passed

+1
compile
187
the patch passed

+1
javac
187
the patch passed

+1
whitespace
0
The patch has no whitespace issues.

+1
xml
10
The patch has no ill-formed XML file.

+1
shadedjars
275
patch has no errors when building our shaded downstream artifacts.

+1
hadoopcheck
941
Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.

+1
javadoc
265
the patch passed

_ Other Tests _

-1
unit
10010
root in the patch failed.

+1
asflicense
164
The patch does not generate ASF License warnings.

13696

Reason
Tests

Failed junit tests
hadoop.hbase.regionserver.TestHRegion

hadoop.hbase.regionserver.TestHRegionWithInMemoryFlush

Subsystem
Report/Notes

Docker
Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-505/11/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/505

Optional Tests
dupname asflicense javac javadoc unit shadedjars hadoopcheck xml compile

uname
Linux a879d01eba97 4.4.0-157-generic #185-Ubuntu SMP Tue Jul 23 09:17:01 UTC 2019 x86_64 GNU/Linux

Build tool
maven

Personality
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-505/out/precommit/personality/provided.sh

git revision
master / 8e488ce9ef

Default Java
1.8.0_181

unit
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-505/11/artifact/out/patch-unit-root.txt

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-505/11/testReport/

Max. process+thread count
4694 (vs. ulimit of 10000)

modules
C: hbase-server hbase-mapreduce hbase-shaded/hbase-shaded-client-byo-hadoop hbase-shaded/hbase-shaded-mapreduce hbase-shaded/hbase-shaded-testing-util hbase-shaded/hbase-shaded-testing-util-tester . U: .

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-505/11/console

versions
git=2.11.0 maven=2018-06-17T18:33:14Z)

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
44
Docker mode activated.

_ Prechecks _

+1
dupname
0
No case conflicting files found.

+1
@author
0
The patch does not contain any @author tags.

-0
test4tests
0
The patch doesn't appear to include any new or modified tests.  Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ master Compile Tests _

0
mvndep
36
Maven dependency ordering for branch

+1
mvninstall
363
master passed

+1
compile
186
master passed

+1
shadedjars
266
branch has no errors when building our shaded downstream artifacts.

+1
javadoc
266
master passed

_ Patch Compile Tests _

0
mvndep
14
Maven dependency ordering for patch

+1
mvninstall
312
the patch passed

+1
compile
190
the patch passed

+1
javac
190
the patch passed

+1
whitespace
0
The patch has no whitespace issues.

+1
xml
9
The patch has no ill-formed XML file.

+1
shadedjars
283
patch has no errors when building our shaded downstream artifacts.

+1
hadoopcheck
962
Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.

+1
javadoc
258
the patch passed

_ Other Tests _

-1
unit
9340
root in the patch failed.

+1
asflicense
157
The patch does not generate ASF License warnings.

13117

Reason
Tests

Failed junit tests
hadoop.hbase.regionserver.TestHRegion

hadoop.hbase.regionserver.TestHRegionWithInMemoryFlush

Subsystem
Report/Notes

Docker
Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-505/12/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/505

Optional Tests
dupname asflicense javac javadoc unit shadedjars hadoopcheck xml compile

uname
Linux 992dcfe98120 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux

Build tool
maven

Personality
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-505/out/precommit/personality/provided.sh

git revision
master / 67382809d3

Default Java
1.8.0_181

unit
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-505/12/artifact/out/patch-unit-root.txt

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-505/12/testReport/

Max. process+thread count
4741 (vs. ulimit of 10000)

modules
C: hbase-server hbase-mapreduce hbase-shaded/hbase-shaded-client-byo-hadoop hbase-shaded/hbase-shaded-mapreduce hbase-shaded/hbase-shaded-testing-util hbase-shaded/hbase-shaded-testing-util-tester . U: .

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-505/12/console

versions
git=2.11.0 maven=2018-06-17T18:33:14Z)

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
78
Docker mode activated.

_ Prechecks _

+1
dupname
0
No case conflicting files found.

+1
@author
0
The patch does not contain any @author tags.

-0
test4tests
0
The patch doesn't appear to include any new or modified tests.  Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ master Compile Tests _

0
mvndep
42
Maven dependency ordering for branch

+1
mvninstall
439
master passed

+1
compile
243
master passed

+1
shadedjars
371
branch has no errors when building our shaded downstream artifacts.

+1
javadoc
321
master passed

_ Patch Compile Tests _

0
mvndep
15
Maven dependency ordering for patch

+1
mvninstall
409
the patch passed

+1
compile
233
the patch passed

+1
javac
233
the patch passed

+1
whitespace
0
The patch has no whitespace issues.

+1
xml
14
The patch has no ill-formed XML file.

+1
shadedjars
377
patch has no errors when building our shaded downstream artifacts.

+1
hadoopcheck
1250
Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.

+1
javadoc
307
the patch passed

_ Other Tests _

-1
unit
19171
root in the patch failed.

+1
asflicense
182
The patch does not generate ASF License warnings.

23983

Reason
Tests

Failed junit tests
hadoop.hbase.regionserver.TestHRegion

hadoop.hbase.regionserver.TestHRegionWithInMemoryFlush

hadoop.hbase.tool.TestSecureBulkLoadHFiles

hadoop.hbase.regionserver.TestRegionMergeTransactionOnCluster

hadoop.hbase.tool.TestBulkLoadHFiles

hadoop.hbase.client.TestAsyncTableBatch

hadoop.hbase.client.TestSnapshotDFSTemporaryDirectory

hadoop.hbase.client.TestSnapshotTemporaryDirectoryWithRegionReplicas

hadoop.hbase.client.TestFromClientSide3

Subsystem
Report/Notes

Docker
Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-505/13/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/505

Optional Tests
dupname asflicense javac javadoc unit shadedjars hadoopcheck xml compile

uname
Linux 23c254d1b86e 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux

Build tool
maven

Personality
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-505/out/precommit/personality/provided.sh

git revision
master / a59f7d4ffc

Default Java
1.8.0_181

unit
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-505/13/artifact/out/patch-unit-root.txt

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-505/13/testReport/

Max. process+thread count
4933 (vs. ulimit of 10000)

modules
C: hbase-server hbase-mapreduce hbase-shaded/hbase-shaded-client-byo-hadoop hbase-shaded/hbase-shaded-mapreduce hbase-shaded/hbase-shaded-testing-util hbase-shaded/hbase-shaded-testing-util-tester . U: .

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-505/13/console

versions
git=2.11.0 maven=2018-06-17T18:33:14Z)

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
43
Docker mode activated.

_ Prechecks _

+1
dupname
0
No case conflicting files found.

+1
@author
0
The patch does not contain any @author tags.

-0
test4tests
0
The patch doesn't appear to include any new or modified tests.  Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ master Compile Tests _

0
mvndep
35
Maven dependency ordering for branch

+1
mvninstall
339
master passed

+1
compile
192
master passed

+1
shadedjars
296
branch has no errors when building our shaded downstream artifacts.

+1
javadoc
272
master passed

_ Patch Compile Tests _

0
mvndep
14
Maven dependency ordering for patch

+1
mvninstall
332
the patch passed

+1
compile
203
the patch passed

+1
javac
203
the patch passed

+1
whitespace
0
The patch has no whitespace issues.

+1
xml
9
The patch has no ill-formed XML file.

+1
shadedjars
318
patch has no errors when building our shaded downstream artifacts.

+1
hadoopcheck
1030
Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.

+1
javadoc
278
the patch passed

_ Other Tests _

+1
unit
15339
root in the patch passed.

+1
asflicense
198
The patch does not generate ASF License warnings.

19328

Subsystem
Report/Notes

Docker
Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-505/14/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/505

Optional Tests
dupname asflicense javac javadoc unit shadedjars hadoopcheck xml compile

uname
Linux 2416fffba854 4.15.0-55-generic #60-Ubuntu SMP Tue Jul 2 18:22:20 UTC 2019 x86_64 GNU/Linux

Build tool
maven

Personality
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-505/out/precommit/personality/provided.sh

git revision
master / ab28f9d8c7

Default Java
1.8.0_181

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-505/14/testReport/

Max. process+thread count
5273 (vs. ulimit of 10000)

modules
C: hbase-server hbase-mapreduce hbase-shaded/hbase-shaded-client-byo-hadoop hbase-shaded/hbase-shaded-mapreduce hbase-shaded/hbase-shaded-testing-util hbase-shaded/hbase-shaded-testing-util-tester . U: .

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-505/14/console

versions
git=2.11.0 maven=2018-06-17T18:33:14Z)

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

Thanks for the review @Apache9 @Reidddddd
We have +1 overall from QA also.
For branch-2, I have attached patch(HBASE-22863.branch-2.000.patch) on the JIRA. With that patch, dependency tree for branch-2 comes exactly similar to what I updated on this PR for master.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
100
Docker mode activated.

_ Prechecks _

+1
dupname
0
No case conflicting files found.

+1
@author
0
The patch does not contain any @author tags.

-0
test4tests
0
The patch doesn't appear to include any new or modified tests.  Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ master Compile Tests _

0
mvndep
65
Maven dependency ordering for branch

+1
mvninstall
321
master passed

+1
compile
176
master passed

+1
shadedjars
273
branch has no errors when building our shaded downstream artifacts.

+1
javadoc
262
master passed

_ Patch Compile Tests _

0
mvndep
14
Maven dependency ordering for patch

+1
mvninstall
308
the patch passed

+1
compile
179
the patch passed

+1
javac
179
the patch passed

+1
whitespace
0
The patch has no whitespace issues.

+1
xml
11
The patch has no ill-formed XML file.

+1
shadedjars
274
patch has no errors when building our shaded downstream artifacts.

+1
hadoopcheck
975
Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.

+1
javadoc
264
the patch passed

_ Other Tests _

-1
unit
9934
root in the patch failed.

+1
asflicense
184
The patch does not generate ASF License warnings.

13749

Subsystem
Report/Notes

Docker
Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-505/15/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/505

Optional Tests
dupname asflicense javac javadoc unit shadedjars hadoopcheck xml compile

uname
Linux 218be9e0fa2f 4.4.0-157-generic #185-Ubuntu SMP Tue Jul 23 09:17:01 UTC 2019 x86_64 GNU/Linux

Build tool
maven

Personality
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-505/out/precommit/personality/provided.sh

git revision
master / 66ad42c742

Default Java
1.8.0_181

unit
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-505/15/artifact/out/patch-unit-root.txt

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-505/15/testReport/

Max. process+thread count
4608 (vs. ulimit of 10000)

modules
C: hbase-server hbase-mapreduce hbase-shaded/hbase-shaded-client-byo-hadoop hbase-shaded/hbase-shaded-mapreduce hbase-shaded/hbase-shaded-testing-util hbase-shaded/hbase-shaded-testing-util-tester . U: .

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-505/15/console

versions
git=2.11.0 maven=2018-06-17T18:33:14Z)

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@Apache9 @Reidddddd
Could you please help me merge this? Patch for branch-2 is also available with QA results in JIRA.
Thanks

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
233
Docker mode activated.

_ Prechecks _

+1
dupname
0
No case conflicting files found.

+1
@author
0
The patch does not contain any @author tags.

-0
test4tests
0
The patch doesn't appear to include any new or modified tests.  Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ master Compile Tests _

0
mvndep
34
Maven dependency ordering for branch

+1
mvninstall
347
master passed

+1
compile
202
master passed

+1
shadedjars
306
branch has no errors when building our shaded downstream artifacts.

+1
javadoc
288
master passed

_ Patch Compile Tests _

0
mvndep
14
Maven dependency ordering for patch

+1
mvninstall
341
the patch passed

+1
compile
213
the patch passed

+1
javac
213
the patch passed

+1
whitespace
0
The patch has no whitespace issues.

+1
xml
12
The patch has no ill-formed XML file.

+1
shadedjars
312
patch has no errors when building our shaded downstream artifacts.

+1
hadoopcheck
1051
Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.

+1
javadoc
288
the patch passed

_ Other Tests _

-1
unit
14585
root in the patch failed.

+1
asflicense
174
The patch does not generate ASF License warnings.

18843

Reason
Tests

Failed junit tests
hadoop.hbase.master.TestMasterShutdown

Subsystem
Report/Notes

Docker
Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-505/16/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/505

Optional Tests
dupname asflicense javac javadoc unit shadedjars hadoopcheck xml compile

uname
Linux f510008edd57 4.15.0-55-generic #60-Ubuntu SMP Tue Jul 2 18:22:20 UTC 2019 x86_64 GNU/Linux

Build tool
maven

Personality
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-505/out/precommit/personality/provided.sh

git revision
master / 7af5b30eca

Default Java
1.8.0_181

unit
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-505/16/artifact/out/patch-unit-root.txt

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-505/16/testReport/

Max. process+thread count
4598 (vs. ulimit of 10000)

modules
C: hbase-server hbase-mapreduce hbase-shaded/hbase-shaded-client-byo-hadoop hbase-shaded/hbase-shaded-mapreduce hbase-shaded/hbase-shaded-testing-util hbase-shaded/hbase-shaded-testing-util-tester . U: .

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-505/16/console

versions
git=2.11.0 maven=2018-06-17T18:33:14Z)

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
122
Docker mode activated.

_ Prechecks _

+1
dupname
0
No case conflicting files found.

+1
@author
0
The patch does not contain any @author tags.

-0
test4tests
0
The patch doesn't appear to include any new or modified tests.  Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ master Compile Tests _

0
mvndep
46
Maven dependency ordering for branch

+1
mvninstall
395
master passed

+1
compile
229
master passed

+1
shadedjars
341
branch has no errors when building our shaded downstream artifacts.

+1
javadoc
308
master passed

_ Patch Compile Tests _

0
mvndep
16
Maven dependency ordering for patch

+1
mvninstall
415
the patch passed

+1
compile
220
the patch passed

+1
javac
220
the patch passed

+1
whitespace
0
The patch has no whitespace issues.

+1
xml
10
The patch has no ill-formed XML file.

+1
shadedjars
340
patch has no errors when building our shaded downstream artifacts.

+1
hadoopcheck
1085
Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.

+1
javadoc
289
the patch passed

_ Other Tests _

-1
unit
15572
root in the patch failed.

+1
asflicense
238
The patch does not generate ASF License warnings.

20096

Reason
Tests

Failed junit tests
hadoop.hbase.client.TestMobSnapshotCloneIndependence

Subsystem
Report/Notes

Docker
Client=18.09.7 Server=18.09.7 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-505/17/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/505

Optional Tests
dupname asflicense javac javadoc unit shadedjars hadoopcheck xml compile

uname
Linux b3f728cc823c 4.15.0-52-generic #56-Ubuntu SMP Tue Jun 4 22:49:08 UTC 2019 x86_64 GNU/Linux

Build tool
maven

Personality
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-505/out/precommit/personality/provided.sh

git revision
master / 1b50404f34

Default Java
1.8.0_181

unit
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-505/17/artifact/out/patch-unit-root.txt

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-505/17/testReport/

Max. process+thread count
5002 (vs. ulimit of 10000)

modules
C: hbase-server hbase-mapreduce hbase-shaded/hbase-shaded-client-byo-hadoop hbase-shaded/hbase-shaded-mapreduce hbase-shaded/hbase-shaded-testing-util hbase-shaded/hbase-shaded-testing-util-tester . U: .

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-505/17/console

versions
git=2.11.0 maven=2018-06-17T18:33:14Z)

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.


Escape HTML entities

Some websites put HTML entities into their meta fields, I added he to decode them.
See this WIRED article as an example:
<meta name="twitter:title" content="Don't Be Misled. The Apple-FBI Fight Isn't About Privacy vs. Security" />

Thank you for the PR!


Enable TLS protocol when cert is provided and port number is 443

Description
Enables TLS protocol when certificateArn is provided and port number is 443 for both OS and OSD.
Bumps version to 1.2.1
Issues Resolved
resolves https://github.com/opensearch-project/opensearch-cluster-cdk/issues/112
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

DO we have logic and test that verifies if the port mapping parameter passed for OS and OSD is not the same?
Like if 443 port is passed by mistake for both OS and OSD we should just error it out upfront.

DO we have logic and test that verifies if the port mapping parameter passed for OS and OSD is not the same? Like if 443 port is passed by mistake for both OS and OSD we should just error it out upfront.

Good catch! Added this check and associated test including defaults.


[6.x] Add json_unqoute() as optional with '->>'

when use aggregates (such as min or max) or use order_by if use json_unquote integer columns returned as string so this funcs not work correct!!!

@staudenmeir can you maybe check in on this? I think I've seen previous attempts of this which were rejected.

Please provide a complete example.

Please provide a complete example.

CREATE TABLE `sample_json`  (
  `id` int(10) UNSIGNED NOT NULL AUTO_INCREMENT,
  `data` json NOT NULL,
  PRIMARY KEY (`id`) USING BTREE
) ENGINE = InnoDB AUTO_INCREMENT = 1558 CHARACTER SET = utf8 COLLATE = utf8_unicode_ci ROW_FORMAT = Dynamic;

INSERT INTO `sample_json` VALUES (1, '{\"price\": 1}');
INSERT INTO `sample_json` VALUES (2, '{\"price\": 10}');
INSERT INTO `sample_json` VALUES (3, '{\"price\": 3}');
INSERT INTO `sample_json` VALUES (4, '{\"price\": 11}');
INSERT INTO `sample_json` VALUES (5, '{\"price\": 2}');

\DB::table('sample_json')->select('data->price')->orderBy('data->price')
if use json_unqoute() in sql price set as string so orderBy worked on string like:
price->1
price->10
price->11
price->2
price->3

if don't use json_unqoute() price dont change and is number so orderBy worked on integer like:
price->1
price->2
price->3
price->10
price->11

so i change MySqlGrammar.php for optional json_unqoute() if use 'data->>price' set json_unqoute(), but if use 'data->price' don't set json_unqoute() just like as mysql tsql syntax for json.

I see the issue, but your suggestion is a breaking change. We need to find a different solution.

I really need know how you can fixed it!

Let's try to find a different solution then. Feel free to open up an issue on the issue tracker to discuss the best solution.
I also see this open issue: so maybe we can tackle both at the same time? https://github.com/laravel/framework/issues/26415

@driesvints That's a different issue.


Can we reach users with Instagram suggestions?

I want to see and follow my suggestion list. Can I see the suggestion list like the home page of the mobile app?
Like this:

I worked on this last week. There is currently a public request method 'profile_related_info' in the library. However, Instagram is no longer responding to this public request. Instead I found an "fbsearch" request with the fbsearch/accounts_recs/ endpoint from web browser network activities.
I added the following method to fbsearch.py. It returns 80 seggested profiles for each profile.
def fbsearch_suggested_profiles(self, user_id: str) -> List[UserShort]:
        params = {
            "target_user_id": user_id,
            "include_friendship_status": "true",
        }
        result = self.private_request("fbsearch/accounts_recs/", params=params)
        return result["users"]

@abdullahbektass Thank you, It really works. I've create a PR, so it will be easier for other to use if merged.


Disable drop after certian item?

Hi, I have a list of draggable items which can be partially and temporarily disabled for any manipulations.
Let's say there is a list of 10 items and first 6 are enabled while the rest 4 are disabled.
Is there a way to prevent user from dropping the "enabled" item to any item among those 4 (basically to any position after index 6 in this case)?
I guess should-accept-drop can be used for that but I can't really see how to apply it for this use case.
Any advice is much appreciated.

Add a counter in your component and in onDrop increase the counter. Check if the counter reached the limit in should-accept-drop and return false when needed.

@Cmacu I mean, should-accept-drop seem to evaluate at the beginning of drag and not at the end.
I guess my question is - what is the API that can disable drop for a single item inside a container at the end of drag?

@Cmacu I mean, should-accept-drop seem to evaluate at the beginning of drag and not at the end.
I guess my question is - what is the API that can disable drop for a single item inside a container at the end of drag?

Have you solved your problem yet

@dgf957492430 nope...


Can it support monitoring of specified URLs through http or socks proxy?

Is your feature request related to a problem? Please describe.
Some of the URLs I want to monitor can only be accessed through a proxy
Describe the solution you'd like
such as an undisclosed company internal website
Describe alternatives you've considered
No alternatives found yet
Additional context
none

@xgrei This is not in the scope of this project.
See https://github.com/brotandgames/ciao/issues/61


"Edit in Plunkr" should be able to open in a new tab/window

I'm submitting a ...

[ ] bug report
[x] feature request
[x] other (Please do not submit support requests here (see above))

Current behavior:

On the documentation pages, there are plunkr editing links which are very important to check the working examples. But when I want to see the example in plunkr, I have to click the link and the link makes the browser page change to the plunkr page. Then I have to go back in a new window or tab to check both plunkr and documentation.
Expected / new behavior:

I expect to have a link to plunkr via open in a new tab or new window option
Minimal reproduction of the problem with instructions:

Just go to the docs in any page and click to the "edit in plunkr" button which you cannot make it open in a new window or tab.
Angular version: 1.x.y

Just the docs, example: https://docs.angularjs.org/guide/forms
Browser: [all | Chrome XX | Firefox XX | IE XX | Safari XX | Mobile Chrome XX | Android X.X Web Browser | iOS XX Safari | iOS XX UIWebView | iOS XX WKWebView ]

Chrome
Anything else:

Have you tried using ctrl/cmd + click ?

Thanks, I had not tried via Ctrl+click until your comment. I tried via scroll click which always makes the links open in a new window without having the second hand push (sroll click is only mouse click but ctrl + click is mouse click and keyboard together)

This is the check used to decide whether or not the plunkr should be opened in a new tab:
https://github.com/angular/angular.js/blob/5b477614ff92dcdf5eff62e2143b7fb43aab5653/docs/app/src/examples.js#L138
Replacing the button with an a tag wouldn't really help I guess as click event requires to execute some javascript instead of navigating to a certain URL.

Thank you for the code analyzing, I think this is a big lack but if there is no luck, I have nothing to say then :)

Let's say we'd replace the button with an a element without a href attribute but instead executing javascript code to open the plunkr.
How would you ensure the context menu to open (it's not opening, it's executing javascript) works? Afaik, this is not possible. If you think otherwise, please feel free to provide a PR!

Afaik it's not possible to overwrite the context menu action. It's only possible to overwrite the click ...
Since the plnkr is generated on the fly with a form submit, I don't think there's currently a better way to do it. PR obviously welcome if there's a better solution.


SSDP search on specific local ip not working

Hi,
first of all great project - works brilliantly although I have one problem with different networks and SSDP broadcasts.
So the scenario:
I'm connected to two different Wifi networks the same time - both are connections to Cameras (which run in hot spot mode). Sadly those cameras have both the same IP as you can't configure it while they run in hotspot mode...
I have identified the local IP endpoints which bind to the cameras - say <IP_ADDRESS> and <IP_ADDRESS>.
If I perform a search as in your FAQ:
        private async Task<SsdpDevice> SearchForDeviceSsdp(string localIpEnpoint)
        {
            int localPort = _rnd.Next(50000, 55000); //seen here: https://github.com/Yortw/RSSDP/issues/38
            Rssdp.Infrastructure.SsdpCommunicationsServer localPortServer = new
            Rssdp.Infrastructure.SsdpCommunicationsServer(new Rssdp.SocketFactory(localIpEnpoint));
            using (var deviceLocator = new SsdpDeviceLocator(localPortServer), localPort)
            {
                deviceLocator.NotificationFilter = SONY_API_IDENTIFIER; //filters for the camera API
                try
                {
                    IEnumerable<DiscoveredSsdpDevice> foundCameraApi = await deviceLocator.SearchAsync();

                    var discoveredSsdpDevices = foundCameraApi as DiscoveredSsdpDevice[] ?? foundCameraApi.ToArray();
                    foreach (var foundDevice in discoveredSsdpDevices)
                    {
                        SsdpDevice fullDeviceInfo = await foundDevice.GetDeviceInfo();
                        return fullDeviceInfo;
                    }
                }
                catch (Exception e)
                {
                }
            }
            return null;
        }

I always get the same camera. So the DeviceInfo contains the name of the camera - I can see I always get the same ID. So I can't differentiate between those cams. On the other side I do later call the API of each camera individually - to take a photo - which works fine.
So I'm wondering if there could be an issue with search based on a locally bound IP.
So calling the API is a bit messy right now but the ServicePoint reset (or set to local IP) is basically this:
                ServicePoint servicePointG = ServicePointManager.FindServicePoint(new Uri(camera.CameraApiEndpoint));
                servicePointG.BindIPEndPointDelegate = (servicePoint, remoteEndPoint, retryCount) => new IPEndPoint(IPAddress.Parse(camera.LocalIpBindingEndpoint), 0);

                servicePointG.ConnectionLeaseTimeout = 0;

                HttpWebRequest req = (HttpWebRequest)WebRequest.Create(camera.CameraApiEndpoint);
                req.ContentType = "application/json";
                req.KeepAlive = false;
                req.Method = "POST";
                req.Timeout = 10000;

So I'm kinda sure the communication is basically fine - just the SSDP on a specific locally bound IP does not work (but would be needed so I know which cam is which).
Currently the GetDeviceInfo call always returns exactly the same result - independent of the local IP (which shouldn't be the case).
Any help would be awesome.
Thanks
Nico

Hi,
Thanks for the kind words and the issue report.
Can I just clarify what the issue(s) are?
You've mentioned that

GetDeviceInfo always returns the same result"

which sort of makes sense. Internally it uses HttpClient to do the GET to the device endpoint, and I don't actually know how to bind HttpClient to a specific adapter - normally it decides itself. So I can understand why that might not work, and if that's the problem then I can investigate a solution.
However you've also said the "search doesn't work bound to a local adapter" and I'm not sure why that would be the case or how to test this. I can be connected to two different networks on my dev machine (though my opportunities for this are limited as I normally only have one network at home & work) , and performing a search bound to different IP's definitely returns me different results. A common problem other people have had is the default network adapter chosen being one that isn't connected or isn't the one they expect, and then they do not get any results (or at least not the results they expect). That was why I updated RSSDP to support taking a local IP to bind to, and I haven't seen/reproduced/heard about any failures of it since.
So are both the search and getdeviceinfo working incorrectly, or are you getting the right search result but getdeviceinfo always returns the response from one device?
You said

I always get the same camera. So the DeviceInfo contains the name of the camera - I can see I always get the same ID

but if GetDeviceInfo is broken that would be true even if the search was working properly, so again, I just need to narrow down the problem so I can investigate.
If it is only GetDeviceInfo that is broken, you can probably work around it on your own until I can provide a fix. You need to use the same logic you've used for calling the API to take a photo, but use the GET http method, content type of "application/xml" and send the request to the DeviceLocation address specified on the search result object. That will give you back the XML, and then you should be able to either read that manually or pass it to the SsdpDevice to parse it into one of the RSSDP objects.
Thanks.

Hi,
thanks for the super fast response.
From what I have learned so far (while working with the cameras) is that some 'HttpClients' can be bound to local endpoints - some not... Due to this I used the HttpWebRequest in a different place - as its possible to provide a ServicePoint delegate.
My hope was the via doing this:
 using (var deviceLocator = new SsdpDeviceLocator(localPortServer), localPort)
I'm binding the deviceLocator to a local IP/ network interface. So when starting a search there I'm only getting SSDP endpoint on this interface.
I'm doing this call (using (var deviceLocator = new SsdpDeviceLocator(localPortServer), localPort)) for each local network interface (I have two) - but when checking the DeviceFriendlyName in the same loop iteration its always the same (on both IPs/ local interfaces).
Which makes sense if GetDeviceInfo() is based on HttpClient (could have looked up that myself - sorry).
As my cameras are identical models I can't differentiate on search level - the only way to separate the cameras is via the DeviceFriendlyName. All other paramters are the same - at least the search returns the same content.
Therefore I rely a bit on GetDeviceInfo()
As mentioned I have two cameras - both running in AccessPoint mode - and both Access points having the same bloody hardcoded IP (its silly... to get the REST API working on the cameras you must switch them into RemoteControlMode - which opens an Access point. There the IP of the camera is hardcoded - there is no way to change this. Or I haven't found one)...
So the only way to differentiate the cameras is via the 'DeviceFriendlyName' that comes out of the DeviceInfo.
Again thanks alot... I believe I know where my problem is located...
It might be a useful improvement for you in the long run - as I would guess having the option to bind the SsdpDeviceLocator only makes sense if GetDeviceInfo() is bound to the same local IP endpoint.
On the other side this is a rare use case I guess :)


Bump to Ruby 2.7

Description

Upgrade to Ruby 2.7.1
Related Issue

Motivation and Context

Rails 6.0.3 supports Ruby 2.7 and fixes most of the warnings.
How Has This Been Tested?

Screenshots (if appropriate):
Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[x] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[ ] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes.
[x] All new and existing tests passed.

Thank you!
On Thu, May 7, 2020 at 11:15 PM प्रथमेश Sonpatki<EMAIL_ADDRESS>wrote:

Merged #1296 https://github.com/codetriage/CodeTriage/pull/1296 into
master.
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
https://github.com/codetriage/CodeTriage/pull/1296#event-3315508067, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AAAOSYHJAZKFXDICJGXP5V3RQOBNFANCNFSM4M275X7A
.

--
Richard Schneeman
https://www.schneems.com
he/him


B 21367 INT B block third address if no second address is present

B-21367
Summary
Added new rules to MTO & PPM shipment validations to prevent tertiary addresses from being added/updated without a second one present. Additional utility functions added as well to support testing.
How to test.

Open Dbeaver and find a move ID to use later. Move should be in approved status
Open Postman, and run this one for Create http://primelocal:3000/prime/v3/mto-shipments using the following JSON

Example JSON
{
  "moveTaskOrderID": "99783f4d-ee83-4fc9-8e0c-d32496bef32b",
  "shipmentType": "PPM",
  "requestedPickupDate": "2024-01-01",
  "estimatedWeight": "1776",
  "pickupAddress": {
    "id": "tp1",
    "city": "Beverly Hills",
    "postalCode": "23231",
    "streetAddress1": "12 Any Street",
    "StreetAddress2": "P.O. Box 1234",
    "state": "CA"
  },
"tertiaryPickupAddress": {
    "id": "tp1",
    "city": "Beverly Hills",
    "postalCode": "23231",
    "streetAddress1": "12 Any Street",
    "StreetAddress2": "P.O. Box 1234",
    "state": "CA"
  },
    "destinationAddress": {
    "id": "tp2",
    "city": "Beverly Hills",
    "postalCode": "23231",
    "streetAddress1": "12 Any Street",
    "StreetAddress2": "P.O. Box 1234",
    "state": "CA"
  },
  "ppmShipment": {
    "expectedDepartureDate": "2024-01-01",
    "estimatedWeight": 2500,
    "hasProGear": false,
    "sitExpected": false,
    "pickupAddress": {
        "id": "ppmp1",
      "city": "Beverly Hills",
    "postalCode": "23231",
    "streetAddress1": "12 Any Street",
    "StreetAddress2": "P.O. Box 1234",
    "state": "CA"
    },
    "destinationAddress": {
        "id":"ppmd1",
      "city": "Beverly Hills",
    "postalCode": "23231",
    "streetAddress1": "12 Any Street",
    "StreetAddress2": "P.O. Box 1234",
    "state": "CA"
    },
  }
}

This should cause a validation error as a result

Run create shipment again using the following JSON

Example JSON
{
  "moveTaskOrderID": "99783f4d-ee83-4fc9-8e0c-d32496bef32b",
  "shipmentType": "PPM",
  "requestedPickupDate": "2024-01-01",
  "estimatedWeight": "1776",
  "pickupAddress": {
    "id": "tp1",
    "city": "Beverly Hills",
    "postalCode": "23231",
    "streetAddress1": "12 Any Street",
    "StreetAddress2": "P.O. Box 1234",
    "state": "CA"
  },
    "destinationAddress": {
    "id": "tp2",
    "city": "Beverly Hills",
    "postalCode": "23231",
    "streetAddress1": "12 Any Street",
    "StreetAddress2": "P.O. Box 1234",
    "state": "CA"
  },
"tertiaryDestinationAddress": {
    "id": "tp1",
    "city": "Beverly Hills",
    "postalCode": "23231",
    "streetAddress1": "12 Any Street",
    "StreetAddress2": "P.O. Box 1234",
    "state": "CA"
  },
  "ppmShipment": {
    "expectedDepartureDate": "2024-01-01",
    "estimatedWeight": 2500,
    "hasProGear": false,
    "sitExpected": false,
    "pickupAddress": {
        "id": "ppmp1",
      "city": "Beverly Hills",
    "postalCode": "23231",
    "streetAddress1": "12 Any Street",
    "StreetAddress2": "P.O. Box 1234",
    "state": "CA"
    },
    "destinationAddress": {
        "id":"ppmd1",
      "city": "Beverly Hills",
    "postalCode": "23231",
    "streetAddress1": "12 Any Street",
    "StreetAddress2": "P.O. Box 1234",
    "state": "CA"
    },
  }
}

An error should be returned here as well

Run Create MTO shipment again using this JSON

Example JSON
{
  "moveTaskOrderID": "99783f4d-ee83-4fc9-8e0c-d32496bef32b",
  "shipmentType": "PPM",
  "requestedPickupDate": "2024-01-01",
  "estimatedWeight": "1776",
  "pickupAddress": {
    "id": "tp1",
    "city": "Beverly Hills",
    "postalCode": "23231",
    "streetAddress1": "12 Any Street",
    "StreetAddress2": "P.O. Box 1234",
    "state": "CA"
  },
    "destinationAddress": {
    "id": "tp2",
    "city": "Beverly Hills",
    "postalCode": "23231",
    "streetAddress1": "12 Any Street",
    "StreetAddress2": "P.O. Box 1234",
    "state": "CA"
  },
"tertiaryDestinationAddress": {
    "id": "tp1",
    "city": "Beverly Hills",
    "postalCode": "23231",
    "streetAddress1": "12 Any Street",
    "StreetAddress2": "P.O. Box 1234",
    "state": "CA"
  },
  "ppmShipment": {
    "expectedDepartureDate": "2024-01-01",
    "estimatedWeight": 2500,
    "hasProGear": false,
    "sitExpected": false,
    "pickupAddress": {
        "id": "ppmp1",
      "city": "Beverly Hills",
    "postalCode": "23231",
    "streetAddress1": "12 Any Street",
    "StreetAddress2": "P.O. Box 1234",
    "state": "CA"
    },
"secondaryPickupAddress": {
        "id": "ppmp1",
      "city": "Beverly Hills",
    "postalCode": "23231",
    "streetAddress1": "12 Any Street",
    "StreetAddress2": "P.O. Box 1234",
    "state": "CA"
    },
    "destinationAddress": {
        "id":"ppmd1",
      "city": "Beverly Hills",
    "postalCode": "23231",
    "streetAddress1": "12 Any Street",
    "StreetAddress2": "P.O. Box 1234",
    "state": "CA"
    },
  }
}

Run this JSON for create MTO Shipment

Example JSON
{
  "moveTaskOrderID": "99783f4d-ee83-4fc9-8e0c-d32496bef32b",
  "shipmentType": "PPM",
  "requestedPickupDate": "2024-01-01",
  "estimatedWeight": "1776",
  "pickupAddress": {
    "id": "tp1",
    "city": "Beverly Hills",
    "postalCode": "23231",
    "streetAddress1": "12 Any Street",
    "StreetAddress2": "P.O. Box 1234",
    "state": "CA"
  },
    "destinationAddress": {
    "id": "tp2",
    "city": "Beverly Hills",
    "postalCode": "23231",
    "streetAddress1": "12 Any Street",
    "StreetAddress2": "P.O. Box 1234",
    "state": "CA"
  },
"tertiaryDestinationAddress": {
    "id": "tp1",
    "city": "Beverly Hills",
    "postalCode": "23231",
    "streetAddress1": "12 Any Street",
    "StreetAddress2": "P.O. Box 1234",
    "state": "CA"
  },
  "ppmShipment": {
    "expectedDepartureDate": "2024-01-01",
    "estimatedWeight": 2500,
    "hasProGear": false,
    "sitExpected": false,
    "pickupAddress": {
        "id": "ppmp1",
      "city": "Beverly Hills",
    "postalCode": "23231",
    "streetAddress1": "12 Any Street",
    "StreetAddress2": "P.O. Box 1234",
    "state": "CA"
    },
"secondaryPickupAddress": {
        "id": "ppmp1",
      "city": "Beverly Hills",
    "postalCode": "23231",
    "streetAddress1": "12 Any Street",
    "StreetAddress2": "P.O. Box 1234",
    "state": "CA"
    },
    "destinationAddress": {
        "id":"ppmd1",
      "city": "Beverly Hills",
    "postalCode": "23231",
    "streetAddress1": "12 Any Street",
    "StreetAddress2": "P.O. Box 1234",
    "state": "CA"
    },
"tertiaryDestinationAddress": {
        "id":"ppmd1",
      "city": "Beverly Hills",
    "postalCode": "23231",
    "streetAddress1": "12 Any Street",
    "StreetAddress2": "P.O. Box 1234",
    "state": "CA"
    },
  }
}

This should cause an error as well

Run this JSON with create MTO shipment, this should return OK

Example JSON
``` JSON{
  "moveTaskOrderID": "99783f4d-ee83-4fc9-8e0c-d32496bef32b",
  "shipmentType": "PPM",
  "requestedPickupDate": "2024-01-01",
  "estimatedWeight": "1776",
  "pickupAddress": {
    "id": "tp1",
    "city": "Beverly Hills",
    "postalCode": "23231",
    "streetAddress1": "12 Any Street",
    "StreetAddress2": "P.O. Box 1234",
    "state": "CA"
  },
    "secondaryPickupAddress": {
    "id": "tp2",
    "city": "Beverly Hills",
    "postalCode": "23231",
    "streetAddress1": "12 Any Street",
    "StreetAddress2": "P.O. Box 1234",
    "state": "CA"
  },
 "tertiaryPickupAddress": {
    "id": "tp2",
    "city": "Beverly Hills",
    "postalCode": "23231",
    "streetAddress1": "12 Any Street",
    "StreetAddress2": "P.O. Box 1234",
    "state": "CA"
  },
"destinationAddress": {
    "id": "tp2",
    "city": "Beverly Hills",
    "postalCode": "23231",
    "streetAddress1": "12 Any Street",
    "StreetAddress2": "P.O. Box 1234",
    "state": "CA"
  },
"secondaryDestinationAddress": {
    "id": "tp2",
    "city": "Beverly Hills",
    "postalCode": "23231",
    "streetAddress1": "12 Any Street",
    "StreetAddress2": "P.O. Box 1234",
    "state": "CA"
  },
"tertiaryDestinationAddress": {
    "id": "tp1",
    "city": "Beverly Hills",
    "postalCode": "23231",
    "streetAddress1": "12 Any Street",
    "StreetAddress2": "P.O. Box 1234",
    "state": "CA"
  },
  "ppmShipment": {
    "expectedDepartureDate": "2024-01-01",
    "estimatedWeight": 2500,
    "hasProGear": false,
    "sitExpected": false,
    "pickupAddress": {
        "id": "ppmp1",
      "city": "Beverly Hills",
    "postalCode": "23231",
    "streetAddress1": "12 Any Street",
    "StreetAddress2": "P.O. Box 1234",
    "state": "CA"
    },
"secondaryPickupAddress": {
        "id": "ppmp1",
      "city": "Beverly Hills",
    "postalCode": "23231",
    "streetAddress1": "12 Any Street",
    "StreetAddress2": "P.O. Box 1234",
    "state": "CA"
    },
    "destinationAddress": {
        "id":"ppmd1",
      "city": "Beverly Hills",
    "postalCode": "23231",
    "streetAddress1": "12 Any Street",
    "StreetAddress2": "P.O. Box 1234",
    "state": "CA"
    },
 "secondaryDestinationAddress": {
        "id":"ppmd1",
      "city": "Beverly Hills",
    "postalCode": "23231",
    "streetAddress1": "12 Any Street",
    "StreetAddress2": "P.O. Box 1234",
    "state": "CA"
    },
"tertiaryDestinationAddress": {
        "id":"ppmd1",
      "city": "Beverly Hills",
    "postalCode": "23231",
    "streetAddress1": "12 Any Street",
    "StreetAddress2": "P.O. Box 1234",
    "state": "CA"
    },
  }
}```

this should return OK

Create another shipment with only the base addresses

Example JSON
``` JSON{
  "moveTaskOrderID": "99783f4d-ee83-4fc9-8e0c-d32496bef32b",
  "shipmentType": "PPM",
  "requestedPickupDate": "2024-01-01",
  "estimatedWeight": "1776",
  "pickupAddress": {
    "id": "tp1",
    "city": "Beverly Hills",
    "postalCode": "23231",
    "streetAddress1": "12 Any Street",
    "StreetAddress2": "P.O. Box 1234",
    "state": "CA"
  },
"destinationAddress": {
    "id": "tp2",
    "city": "Beverly Hills",
    "postalCode": "23231",
    "streetAddress1": "12 Any Street",
    "StreetAddress2": "P.O. Box 1234",
    "state": "CA"
  },
  "ppmShipment": {
    "expectedDepartureDate": "2024-01-01",
    "estimatedWeight": 2500,
    "hasProGear": false,
    "sitExpected": false,
    "pickupAddress": {
        "id": "ppmp1",
      "city": "Beverly Hills",
    "postalCode": "23231",
    "streetAddress1": "12 Any Street",
    "StreetAddress2": "P.O. Box 1234",
    "state": "CA"
    },
    "destinationAddress": {
        "id":"ppmd1",
      "city": "Beverly Hills",
    "postalCode": "23231",
    "streetAddress1": "12 Any Street",
    "StreetAddress2": "P.O. Box 1234",
    "state": "CA"
    },
  }
}```

then in the results note the eTag
This value WILL change each and every time mto shipment is run, running an old one will yield an IF-Match precondition error!

run {{baseUrl}}/prime/v3/mto-shipments/:mtoShipmentID with the mto shipment ID added in the params, with the following json added in the body

Example JSON
``` JSON{
  "ppmShipment": {
    "expectedDepartureDate": "2024-01-01",
    "estimatedWeight": 2500,
    "hasProGear": false,
    "sitExpected": false,
    "pickupAddress": {
        "id": "ppmp1",
      "city": "Beverly Hills",
    "postalCode": "23231",
    "streetAddress1": "12 Any Street",
    "StreetAddress2": "P.O. Box 1234",
    "state": "CA"
    },
    "tertiaryPickupAddress": {
        "id": "ppmp3",
        "city": "Beverly Hills",
    "postalCode": "23231",
    "streetAddress1": "12 Any Street",
    "StreetAddress2": "P.O. Box 1234",
    "state": "CA"
    },
    "destinationAddress": {
        "id":"ppmd1",
      "city": "Beverly Hills",
    "postalCode": "23231",
    "streetAddress1": "12 Any Street",
    "StreetAddress2": "P.O. Box 1234",
    "state": "CA"
    }
  }
}```

This should yield an error like before

Update the eTag (you may need to pull it from the swagger "getMtoShipment" if the one for the shipment in the DB doesn't work. Rerun update-mto-shipment using the same shipment ID and the following JSON

Example JSON
``` JSON{
  "ppmShipment": {
    "expectedDepartureDate": "2024-01-01",
    "estimatedWeight": 2500,
    "hasProGear": false,
    "sitExpected": false,
    "pickupAddress": {
        "id": "ppmp1",
      "city": "Beverly Hills",
    "postalCode": "23231",
    "streetAddress1": "12 Any Street",
    "StreetAddress2": "P.O. Box 1234",
    "state": "CA"
    },
 "secondaryPickupAddress": {
        "id": "ppmp3",
        "city": "Beverly Hills",
    "postalCode": "23231",
    "streetAddress1": "12 Any Street",
    "StreetAddress2": "P.O. Box 1234",
    "state": "CA"
    },
    "tertiaryPickupAddress": {
        "id": "ppmp3",
        "city": "Beverly Hills",
    "postalCode": "23231",
    "streetAddress1": "12 Any Street",
    "StreetAddress2": "P.O. Box 1234",
    "state": "CA"
    },
    "destinationAddress": {
        "id":"ppmd1",
      "city": "Beverly Hills",
    "postalCode": "23231",
    "streetAddress1": "12 Any Street",
    "StreetAddress2": "P.O. Box 1234",
    "state": "CA"
    }
 "secondaryDestinationAddress": {
        "id": "ppmp3",
        "city": "Beverly Hills",
    "postalCode": "23231",
    "streetAddress1": "12 Any Street",
    "StreetAddress2": "P.O. Box 1234",
    "state": "CA"
    },
 "tertiaryDestinationAddress": {
        "id": "ppmp3",
        "city": "Beverly Hills",
    "postalCode": "23231",
    "streetAddress1": "12 Any Street",
    "StreetAddress2": "P.O. Box 1234",
    "state": "CA"
    },
  }
}```

because the secondary addresses are present, this should pass.

Test coverage on client failed.
Last run: Mon 21 Oct 2024 12:21:31 PM UTC
Refer to this report to see coverage details for the client app.
Documentation for test coverage can be found at this link.

conflicts

For the first scenario it just returns a generic error message, could you add some information so user knows why it failed?

For the first scenario it just returns a generic error message, could you add some information so user knows why it failed?

could you post a screenshot of the error that is received?

For the first scenario it just returns a generic error message, could you add some information so user knows why it failed?

could you post a screenshot of the error that is received?

{
    "title": "Internal Server Error",
    "instance": "2941ae0f-de98-4f4b-9be2-7b6f9db8aaf8",
    "detail": "An unexpected server error has occurred."
}

Here's the full error in terminal
```
2024-10-29T14:18:24.343Z	ERROR	middleware/recovery.go:40	http request panic	{"git_branch": "main", "git_commit": "d2b1660a0897d495d05e124eba85c727e4f7c533", "host": "primelocal:3000", "milmove_trace_id": "2941ae0f-de98-4f4b-9be2-7b6f9db8aaf8", "url": "/prime/v3/mto-shipments", "milmove_trace_id": "2941ae0f-de98-4f4b-9be2-7b6f9db8aaf8", "error": "runtime error: invalid memory address or nil pointer dereference", "stacktrace": "goroutine 657 [running]:\nruntime/debug.Stack()\n\t/Users/logan.cunningham_cn/.asdf/installs/golang/1.23.1/go/src/runtime/debug/stack.go:26 +0x64\ngithub.com/transcom/mymove/pkg/handlers/routing.newBaseRouter.Recovery.func4.1.1()\n\t/Users/logan.cunningham_cn/Documents/mymove/pkg/middleware/recovery.go:35 +0x360\npanic({0x103368e60?, 0x104a62810?})\n\t/Users/logan.cunningham_cn/.asdf/installs/golang/1.23.1/go/src/runtime/panic.go:785 +0x124\ngithub.com/transcom/mymove/pkg/appcontext.(*appContext).NewTransaction.(*Connection).Transaction.func2.1()\n\t/Users/logan.cunningham_cn/logan.cunningham_cn/.asdf/installs/golang/1.20.6/pkg/mod/github.com/gobuffalo/pop/v6@v6.1.1/connection.go:173 +0xc0\npanic({0x103368e60?, 0x104a62810?})\n\t/Users/logan.cunningham_cn/.asdf/installs/golang/1.23.1/go/src/runtime/panic.go:785 +0x124\ngithub.com/gobuffalo/validate/v3.(*Errors).Add(0x0, {0x1023792d1, 0x38}, {0x102391cbb, 0x4c})\n\t/Users/logan.cunningham_cn/logan.cunningham_cn/.asdf/installs/golang/1.20.6/pkg/mod/github.com/gobuffalo/validate/v3@v3.3.3/validate.go:113 +0x2c\ngithub.com/gobuffalo/validate/v3.(*Errors).Append(...)\n\t/Users/logan.cunningham_cn/logan.cunningham_cn/.asdf/installs/golang/1.20.6/pkg/mod/github.com/gobuffalo/validate/v3@v3.3.3/validate.go:104\ngithub.com/transcom/mymove/pkg/services/mto_shipment.mtoShipmentCreator.CreateMTOShipment({{0x1037633a0, 0x104c31ae0}, {0x103742000, 0x140075b76b0}, {0x10376ecd0, 0x104c31ae0}, {0x103741d40, 0x14007d03038}, {0x14005c5f710, 0x3, ...}}, ...)\n\t/Users/logan.cunningham_cn/Documents/mymove/pkg/services/mto_shipment/mto_shipment_creator.go:65 +0x1678\ngithub.com/transcom/mymove/pkg/services/orchestrators/shipment.(*shipmentCreator).CreateShipment.func1({0x103766870, 0x1401cd0db00})\n\t/Users/logan.cunningham_cn/Documents/mymove/pkg/services/orchestrators/shipment/shipment_creator.go:69 +0x6c\ngithub.com/transcom/mymove/pkg/appcontext.(*appContext).NewTransaction(0x0?, 0x0?)\n\t/Users/logan.cunningham_cn/Documents/mymove/pkg/appcontext/context.go:63 +0x108\ngithub.com/transcom/mymove/pkg/services/orchestrators/shipment.(*shipmentCreator).CreateShipment(0x14006aea380, {0x103766870, 0x1401cd0db00}, 0x1401df1ed88)\n\t/Users/logan.cunningham_cn/Documents/mymove/pkg/services/orchestrators/shipment/shipment_creator.go:68 +0x460\ngithub.com/transcom/mymove/pkg/handlers/primeapiv3.(*CreateMTOShipmentHandler).Handle.CreateMTOShipmentHandler.Handle.func1({0x103766870, 0x1401cd0db00})\n\t/Users/logan.cunningham_cn/Documents/mymove/pkg/handlers/primeapiv3/mto_shipment.go:131 +0xffc\ngithub.com/transcom/mymove/pkg/handlers.(*Config).AuditableAppContextFromRequestWithErrors.func1({0x103766870, 0x1401cd0db00})\n\t/Users/logan.cunningham_cn/Documents/mymove/pkg/handlers/config.go:152 +0x3c8\ngithub.com/transcom/mymove/pkg/appcontext.(*appContext).NewTransaction.func1(0x1401cd88b40)\n\t/Users/logan.cunningham_cn/Documents/mymove/pkg/appcontext/context.go:67 +0xa0\ngithub.com/transcom/mymove/pkg/appcontext.(*appContext).NewTransaction.(*Connection).Transaction.func2()\n\t/Users/logan.cunningham_cn/logan.cunningham_cn/.asdf/installs/golang/1.20.6/pkg/mod/github.com/gobuffalo/pop/v6@v6.1.1/connection.go:177 +0xc0\ngithub.com/gobuffalo/pop/v6.commonDialect.Lock(...)\n\t/Users/logan.cunningham_cn/logan.cunningham_cn/.asdf/installs/golang/1.20.6/pkg/mod/github.com/gobuffalo/pop/v6@v6.1.1/dialect_common.go:29\ngithub.com/gobuffalo/pop/v6.(*Connection).Transaction(...)\n\t/Users/logan.cunningham_cn/logan.cunningham_cn/.asdf/installs/golang/1.20.6/pkg/mod/github.com/gobuffalo/pop/v6@v6.1.1/connection.go:157\ngithub.com/transcom/mymove/pkg/appcontext.(*appContext).NewTransaction(0x1401cd0dab8, 0x1400cd00ba0)\n\t/Users/logan.cunningham_cn/Documents/mymove/pkg/appcontext/context.go:65 +0xe4\ngithub.com/transcom/mymove/pkg/handlers.(*Config).AuditableAppContextFromRequestWithErrors(0x14000cfe2c0, 0x1401cd0b7c0, 0x1401b507310)\n\t/Users/logan.cunningham_cn/Documents/mymove/pkg/handlers/config.go:136 +0xbc\ngithub.com/transcom/mymove/pkg/handlers/primeapiv3.CreateMTOShipmentHandler.Handle(...)\n\t/Users/logan.cunningham_cn/Documents/mymove/pkg/handlers/primeapiv3/mto_shipment.go:33\ngithub.com/transcom/mymove/pkg/gen/primev3api/primev3operations/mto_shipment.(*CreateMTOShipment).ServeHTTP(0x14007d03368, {0x103765890, 0x1401cd88a80}, 0x1401cd0b7c0)\n\t/Users/logan.cunningham_cn/Documents/mymove/pkg/gen/primev3api/primev3operations/mto_shipment/create_m_t_o_shipment.go:66 +0x130\ngithub.com/go-openapi/runtime/middleware.(*Context).RoutesHandler.NewOperationExecutor.func1({0x103765890, 0x1401cd88a80}, 0x1401cd0b7c0)\n\t/Users/logan.cunningham_cn/logan.cunningham_cn/.asdf/installs/golang/1.20.6/pkg/mod/github.com/go-openapi/runtime@v0.27.0/middleware/operation.go:28 +0x5c\nnet/http.HandlerFunc.ServeHTTP(0x1401cd0b680?, {0x103765890?, 0x1401cd88a80?}, 0x11?)\n\t/Users/logan.cunningham_cn/.asdf/installs/golang/1.23.1/go/src/net/http/server.go:2220 +0x38\ngithub.com/transcom/mymove/pkg/handlers/routing.mountPrimeAPI.func1.3.OpenAPITracing.3.1({0x103765890, 0x1401cd88a80}, 0x1401cd0b680)\n\t/Users/logan.cunningham_cn/Documents/mymove/pkg/middleware/openapi.go:33 +0xf0\nnet/http.HandlerFunc.ServeHTTP(0x14002a4d080?, {0x103765890?, 0x1401cd88a80?}, 0x1006d5da4?)\n\t/Users/logan.cunningham_cn/.asdf/installs/golang/1.23.1/go/src/net/http/server.go:2220 +0x38\ngithub.com/go-openapi/runtime/middleware.NewRouter.func1({0x103765890, 0x1401cd88a80}, 0x1401cd0b540)\n\t/Users/logan.cunningham_cn/logan.cunningham_cn/.asdf/installs/golang/1.20.6/pkg/mod/github.com/go-openapi/runtime@v0.27.0/middleware/router.go:80 +0x1c4\nnet/http.HandlerFunc.ServeHTTP(0x1401cdda7b5?, {0x103765890?, 0x1401cd88a80?}, 0x10186f378?)\n\t/Users/logan.cunningham_cn/.asdf/installs/golang/1.23.1/go/src/net/http/server.go:2220 +0x38\ngithub.com/go-openapi/runtime/middleware.Redoc.serveUI.func1({0x103765890, 0x1401cd88a80}, 0x1401cd0b540)\n\t/Users/logan.cunningham_cn/logan.cunningham_cn/.asdf/installs/golang/1.20.6/pkg/mod/github.com/go-openapi/runtime@v0.27.0/middleware/ui_options.go:164 +0xb4\nnet/http.HandlerFunc.ServeHTTP(0x1401cdda7b5?, {0x103765890?, 0x1401cd88a80?}, 0xd?)\n\t/Users/logan.cunningham_cn/.asdf/installs/golang/1.23.1/go/src/net/http/server.go:2220 +0x38\ngithub.com/go-openapi/runtime/middleware.Spec.func1({0x103765890, 0x1401cd88a80}, 0x1401cd0b540)\n\t/Users/logan.cunningham_cn/logan.cunningham_cn/.asdf/installs/golang/1.20.6/pkg/mod/github.com/go-openapi/runtime@v0.27.0/middleware/spec.go:72 +0x178\nnet/http.HandlerFunc.ServeHTTP(0x1033374e0?, {0x103765890?, 0x1401cd88a80?}, 0x1401cdc9b43?)\n\t/Users/logan.cunningham_cn/.asdf/installs/golang/1.23.1/go/src/net/http/server.go:2220 +0x38\ngithub.com/go-chi/chi/v5.(*Mux).Mount.func1({0x103765890, 0x1401cd88a80}, 0x1401cd0b540)\n\t/Users/logan.cunningham_cn/logan.cunningham_cn/.asdf/installs/golang/1.20.6/pkg/mod/github.com/go-chi/chi/v5@v5.1.0/mux.go:327 +0x1e0\nnet/http.HandlerFunc.ServeHTTP(0x1401cdc50e0?, {0x103765890?, 0x1401cd88a80?}, 0x1401cdc9b42?)\n\t/Users/logan.cunningham_cn/.asdf/installs/golang/1.23.1/go/src/net/http/server.go:2220 +0x38\ngithub.com/go-chi/chi/v5.(*Mux).routeHTTP(0x14007374780, {0x103765890, 0x1401cd88a80}, 0x1401cd0b540)\n\t/Users/logan.cunningham_cn/logan.cunningham_cn/.asdf/installs/golang/1.20.6/pkg/mod/github.com/go-chi/chi/v5@v5.1.0/mux.go:459 +0x280\nnet/http.HandlerFunc.ServeHTTP(0x140000807a8?, {0x103765890?, 0x1401cd88a80?}, 0x14000080788?)\n\t/Users/logan.cunningham_cn/.asdf/installs/golang/1.23.1/go/src/net/http/server.go:2220 +0x38\ngithub.com/go-chi/chi/v5.(*Mux).ServeHTTP(0x14007374780, {0x103765890, 0x1401cd88a80}, 0x1401cd0b540)\n\t/Users/logan.cunningham_cn/logan.cunningham_cn/.asdf/installs/golang/1.20.6/pkg/mod/github.com/go-chi/chi/v5@v5.1.0/mux.go:73 +0x2c4\ngithub.com/go-chi/chi/v5.(*Mux).Mount.func1({0x103765890, 0x1401cd88a80}, 0x1401cd0b540)\n\t/Users/logan.cunningham_cn/logan.cunningham_cn/.asdf/installs/golang/1.20.6/pkg/mod/github.com/go-chi/chi/v5@v5.1.0/mux.go:327 +0x1e0\nnet/http.HandlerFunc.ServeHTTP(0x1401cdc50e0?, {0x103765890?, 0x1401cd88a80?}, 0x1401cdbe5b8?)\n\t/Users/logan.cunningham_cn/.asdf/installs/golang/1.23.1/go/src/net/http/server.go:2220 +0x38\ngithub.com/go-chi/chi/v5.(*Mux).routeHTTP(0x14004b1f7a0, {0x103765890, 0x1401cd88a80}, 0x1401cd0b540)\n\t/Users/logan.cunningham_cn/logan.cunningham_cn/.asdf/installs/golang/1.20.6/pkg/mod/github.com/go-chi/chi/v5@v5.1.0/mux.go:459 +0x280\nnet/http.HandlerFunc.ServeHTTP(0x18?, {0x103765890?, 0x1401cd88a80?}, 0x101183030?)\n\t/Users/logan.cunningham_cn/.asdf/installs/golang/1.23.1/go/src/net/http/server.go:2220 +0x38\ngithub.com/felixge/httpsnoop.CaptureMetrics.func1({0x103765890?, 0x1401cd88a80?})\n\t/Users/logan.cunningham_cn/logan.cunningham_cn/.asdf/installs/golang/1.20.6/pkg/mod/github.com/felixge/httpsnoop@v1.0.4/capture_metrics.go:29 +0x40\ngithub.com/felixge/httpsnoop.(*Metrics).CaptureMetrics(0x1401cdbe690, {0x1037616d0, 0x1401cd8c380}, 0x14000080a50)\n\t/Users/logan.cunningham_cn/logan.cunningham_cn/.asdf/installs/golang/1.20.6/pkg/mod/github.com/felixge/httpsnoop@v1.0.4/capture_metrics.go:84 +0x184\ngithub.com/felixge/httpsnoop.CaptureMetricsFn(...)\n\t/Users/logan.cunningham_cn/logan.cunningham_cn/.asdf/installs/golang/1.20.6/pkg/mod/github.com/felixge/httpsnoop@v1.0.4/capture_metrics.go:39\ngithub.com/felixge/httpsnoop.CaptureMetrics({0x1037363a8?, 0x14005d80f70?}, {0x1037616d0, 0x1401cd8c380}, 0x1035dbfc0?)\n\t/Users/logan.cunningham_cn/logan.cunningham_cn/.asdf/installs/golang/1.20.6/pkg/mod/github.com/felixge/httpsnoop@v1.0.4/capture_metrics.go:28 +0x6c\ngithub.com/transcom/mymove/pkg/handlers/routing.mountPrimeAPI.func1.RequestLogger.7.1({0x1037616d0, 0x1401cd8c380}, 0x1401cd0b540)\n\t/Users/logan.cunningham_cn/Documents/mymove/pkg/middleware/request_logger.go:73 +0x1408\nnet/http.HandlerFunc.ServeHTTP(0x1401cddc2a0?, {0x1037616d0?, 0x1401cd8c380?}, 0x102342268?)\n\t/Users/logan.cunningham_cn/.asdf/installs/golang/1.23.1/go/src/net/http/server.go:2220 +0x38\ngithub.com/transcom/mymove/pkg/handlers/routing.mountPrimeAPI.func1.NoCache.6.1({0x1037616d0, 0x1401cd8c380}, 0x1401cd0b540)\n\t/Users/logan.cunningham_cn/Documents/mymove/pkg/middleware/no_cache.go:12 +0x7c\nnet/http.HandlerFunc.ServeHTTP(0x103766ab8?, {0x1037616d0?, 0x1401cd8c380?}, 0x1401cd0b540?)\n\t/Users/logan.cunningham_cn/.asdf/installs/golang/1.23.1/go/src/net/http/server.go:2220 +0x38\ngithub.com/transcom/mymove/pkg/handlers/routing.mountPrimeAPI.func1.PrimeAuthorizationMiddleware.5.1({0x1037616d0, 0x1401cd8c380}, 0x1401cd0b540)\n\t/Users/logan.cunningham_cn/Documents/mymove/pkg/handlers/authentication/auth.go:406 +0x78\nnet/http.HandlerFunc.ServeHTTP(0x1401cd0b040?, {0x1037616d0?, 0x1401cd8c380?}, 0x1401cddc660?)\n\t/Users/logan.cunningham_cn/.asdf/installs/golang/1.23.1/go/src/net/http/server.go:2220 +0x38\ngithub.com/transcom/mymove/pkg/handlers/routing.mountPrimeAPI.func1.DevlocalClientCertMiddleware.4.1({0x1037616d0, 0x1401cd8c380}, 0x1401cd0b040)\n\t/Users/logan.cunningham_cn/Documents/mymove/pkg/handlers/authentication/client_cert.go:123 +0x25c\nnet/http.HandlerFunc.ServeHTTP(0x1401c283268?, {0x1037616d0?, 0x1401cd8c380?}, 0x1401c283248?)\n\t/Users/logan.cunningham_cn/.asdf/installs/golang/1.23.1/go/src/net/http/server.go:2220 +0x38\ngithub.com/go-chi/chi/v5.(*Mux).ServeHTTP(0x14004b1f7a0, {0x1037616d0, 0x1401cd8c380}, 0x1401cd0b040)\n\t/Users/logan.cunningham_cn/logan.cunningham_cn/.asdf/installs/golang/1.20.6/pkg/mod/github.com/go-chi/chi/v5@v5.1.0/mux.go:73 +0x2c4\ngithub.com/go-chi/chi/v5.(*Mux).Mount.func1({0x1037616d0, 0x1401cd8c380}, 0x1401cd0b040)\n\t/Users/logan.cunningham_cn/logan.cunningham_cn/.asdf/installs/golang/1.20.6/pkg/mod/github.com/go-chi/chi/v5@v5.1.0/mux.go:327 +0x1e0\nnet/http.HandlerFunc.ServeHTTP(0x1401cdc50e0?, {0x1037616d0?, 0x1401cd8c380?}, 0x1401cdda7b5?)\n\t/Users/logan.cunningham_cn/.asdf/installs/golang/1.23.1/go/src/net/http/server.go:2220 +0x38\ngithub.com/go-chi/chi/v5.(*Mux).routeHTTP(0x14004b1f740, {0x1037616d0, 0x1401cd8c380}, 0x1401cd0b040)\n\t/Users/logan.cunningham_cn/logan.cunningham_cn/.asdf/installs/golang/1.20.6/pkg/mod/github.com/go-chi/chi/v5@v5.1.0/mux.go:459 +0x280\nnet/http.HandlerFunc.ServeHTTP(0x1401c283428?, {0x1037616d0?, 0x1401cd8c380?}, 0x1022b1b30?)\n\t/Users/logan.cunningham_cn/.asdf/installs/golang/1.23.1/go/src/net/http/server.go:2220 +0x38\ngithub.com/transcom/mymove/pkg/middleware.LimitBodySize.func1.1({0x1037616d0, 0x1401cd8c380}, 0x1401cd0b040)\n\t/Users/logan.cunningham_cn/Documents/mymove/pkg/middleware/limit_body_size.go:15 +0xf0\nnet/http.HandlerFunc.ServeHTTP(0x1401c2834e8?, {0x1037616d0?, 0x1401cd8c380?}, 0x1022daca7?)\n\t/Users/logan.cunningham_cn/.asdf/installs/golang/1.23.1/go/src/net/http/server.go:2220 +0x38\ngithub.com/transcom/mymove/pkg/handlers/routing.newBaseRouter.SecurityHeaders.func5.1({0x1037616d0, 0x1401cd8c380}, 0x1401cd0b040)\n\t/Users/logan.cunningham_cn/Documents/mymove/pkg/middleware/security_headers.go:30 +0xe4\nnet/http.HandlerFunc.ServeHTTP(0x103766ab8?, {0x1037616d0?, 0x1401cd8c380?}, 0x140000af808?)\n\t/Users/logan.cunningham_cn/.asdf/installs/golang/1.23.1/go/src/net/http/server.go:2220 +0x38\ngithub.com/transcom/mymove/pkg/handlers/routing.newBaseRouter.Recovery.func4.1({0x1037616d0, 0x1401cd8c380}, 0x1401cd0b040)\n\t/Users/logan.cunningham_cn/Documents/mymove/pkg/middleware/recovery.go:57 +0x90\nnet/http.HandlerFunc.ServeHTTP(0x1401cd0af00?, {0x1037616d0?, 0x1401cd8c380?}, 0x1?)\n\t/Users/logan.cunningham_cn/.asdf/installs/golang/1.23.1/go/src/net/http/server.go:2220 +0x38\ngithub.com/transcom/mymove/pkg/handlers/routing.newBaseRouter.ContextLogger.func3.1({0x1037616d0, 0x1401cd8c380}, 0x1401cd0af00)\n\t/Users/logan.cunningham_cn/Documents/mymove/pkg/middleware/context_logger.go:31 +0x424\nnet/http.HandlerFunc.ServeHTTP(0x1401cd0adc0?, {0x1037616d0?, 0x1401cd8c380?}, 0x1401cdda810?)\n\t/Users/logan.cunningham_cn/.asdf/installs/golang/1.23.1/go/src/net/http/server.go:2220 +0x38\ngithub.com/transcom/mymove/pkg/handlers/routing.newBaseRouter.Trace.func2.1({0x1037616d0, 0x1401cd8c380}, 0x1401cd0adc0)\n\t/Users/logan.cunningham_cn/Documents/mymove/pkg/middleware/trace.go:94 +0x57c\nnet/http.HandlerFunc.ServeHTTP(0x1401cd0ac80?, {0x1037616d0?, 0x1401cd8c380?}, 0xc?)\n\t/Users/logan.cunningham_cn/.asdf/installs/golang/1.23.1/go/src/net/http/server.go:2220 +0x38\ngithub.com/transcom/mymove/pkg/handlers/routing.newBaseRouter.SessionIDMiddleware.func1.1({0x1037616d0, 0x1401cd8c380}, 0x1401cd0ac80)\n\t/Users/logan.cunningham_cn/Documents/mymove/pkg/auth/session.go:333 +0x19c\nnet/http.HandlerFunc.ServeHTTP(0x103766ab8?, {0x1037616d0?, 0x1401cd8c380?}, 0x104a64130?)\n\t/Users/logan.cunningham_cn/.asdf/installs/golang/1.23.1/go/src/net/http/server.go:2220 +0x38\ngithub.com/go-chi/chi/v5.(*Mux).ServeHTTP(0x14004b1f740, {0x1037616d0, 0x1401cd8c380}, 0x1401cd0ab40)\n\t/Users/logan.cunningham_cn/logan.cunningham_cn/.asdf/installs/golang/1.20.6/pkg/mod/github.com/go-chi/chi/v5@v5.1.0/mux.go:90 +0x280\ngithub.com/transcom/mymove/pkg/handlers/routing.(*HostRouter).ServeHTTP(0x1400078e0e8, {0x1037616d0, 0x1401cd8c380}, 0x1401cd0ab40)\n\t/Users/logan.cunningham_cn/Documents/mymove/pkg/handlers/routing/routing_init.go:172 +0x128\ngithub.com/transcom/mymove/pkg/server.CreateNamedServer.func1({0x1037616d0, 0x1401cd8c380}, 0x1401cd0aa00)\n\t/Users/logan.cunningham_cn/Documents/mymove/pkg/server/server.go:157 +0x158\nnet/http.HandlerFunc.ServeHTTP(0x10?, {0x1037616d0?, 0x1401cd8c380?}, 0x1401cd8c380?)\n\t/Users/logan.cunningham_cn/.asdf/installs/golang/1.23.1/go/src/net/http/server.go:2220 +0x38\nnet/http.serverHandler.ServeHTTP({0x103751cb8?}, {0x1037616d0?, 0x1401cd8c380?}, 0x6?)\n\t/Users/logan.cunningham_cn/.asdf/installs/golang/1.23.1/go/src/net/http/server.go:3210 +0xbc\nnet/http.(*conn).serve(0x14000f9a990, {0x103766ab8, 0x14003c56330})\n\t/Users/logan.cunningham_cn/.asdf/installs/golang/1.23.1/go/src/net/http/server.go:2092 +0x4fc\ncreated by net/http.(*Server).Serve in goroutine 10\n\t/Users/logan.cunningham_cn/.asdf/installs/golang/1.23.1/go/src/net/http/server.go:3360 +0x3dc\n"}
github.com/transcom/mymove/pkg/handlers/routing.newBaseRouter.Recovery.func4.1.1
	/Users/logan.cunningham_cn/Documents/mymove/pkg/middleware/recovery.go:40
github.com/transcom/mymove/pkg/appcontext.(*appContext).NewTransaction.(*Connection).Transaction.func2.1
github.com/transcom/mymove/pkg/services/mto_shipment.mtoShipmentCreator.CreateMTOShipment
	/Users/logan.cunningham_cn/Documents/mymove/pkg/services/mto_shipment/mto_shipment_creator.go:65
github.com/transcom/mymove/pkg/services/orchestrators/shipment.(*shipmentCreator).CreateShipment.func1
```

Yes I am aware of the recent payload_to_model_test.go merge conflict and am currently working on it. no additional comments necessary.

I am not getting an error as expected when I try tertiary address and no secondary for PPMs, both pickup and destination.

Member
Additional context is required.
is this for updating or creating mto shipments w/ PPM or both?

I am not getting an error as expected when I try tertiary address and no secondary for PPMs, both pickup and destination.

Additional context is required.
is this for updating or creating mto shipments w/ PPM or both?

I am not getting an error as expected when I try tertiary address and no secondary for PPMs, both pickup and destination.

Additional context is required. is this when calling the updateMTOShipment or createMTOShipment endpoint w/ PPM or both?

Sorry, I was testing the create, didn't look at update yet.

The Playwright test failing in CI is passing locally.

We can discuss on Monday when you are back, but I'm having problems getting an error for the update call and passing a PPMShipment with tertiary and no secondary.
Maybe someone else has tried this yet?


Correction for raw affiliation CEE-M, Univ. Montpellier, CNRS, INRAE, Montpellier SupAgro Montpellier France

Correction needed for raw affiliation CEE-M, Univ. Montpellier, CNRS, INRAE, Montpellier SupAgro Montpellier France
raw_affiliation_name: CEE-M, Univ. Montpellier, CNRS, INRAE, Montpellier SupAgro Montpellier France
new_rors: 051escj72;003vg9w96;02feahw73;03rnk6m14;00rwjvc96
previous_rors: 051escj72;003vg9w96;02feahw73;03rnk6m14
works_examples: W3124333443
contact: 9b3b10e138d47fcee9557ae25117410f:831149a20d7c7327119ccd92b48fa87decd0 @ inrae.fr

This issue was accepted and ingested by the OpenAlex team on 2024-12-19. The new affiliations should be visible within the next 7 days.


cooloff_time context variable is in iso8601 format

When using a custom template (by setting the AXES_LOCKOUT_TEMPLATE), the template is passed cooloff_time as a context variable. This sounds really useful, as I can automatically display to my user "you have been locked out for X minutes/hours".
However, the code converts this to iso8601 format. In my case, I'm locking users out for 2 minutes, and in iso8601 this reads "You have been locked out for PT2M" - which isn't a very helpful message for the user.
I appreciate you probably want some backwards compatibility here, but what would you say to adding an additional context variable, perhaps cooloff_timedelta, which gives me the actual object. This would allow me to add my own formatting. Obviously I could write a template tag that interprets the iso8601 format, but that feels like a bit of a pain since you already have access to the timedelta object internally.
I'm happy to create a PR for this, but wanted to check if/how you'd like this done first.

Sounds like a good idea @jstockwin! Please do feel free to open a PR for this.


updates to "body" object inside handler also changes flask.request.json

Description
Hello - I've created a repo to demonstrate this possible bug.
Here is a link to my repo.
Expected behaviour
Using swagger 2, when one adds an additional key to the "body" object passed in from flask/connexion, it also updates flask.request.json. For example in the output below you'll notice I add the "status" key to the body object, and this is reflected when I use flask.request.json.
I expect the same when I switch to using the swagger 3 file.
Actual behaviour
Using swagger 3, updates to the "body" object does not update the flask.request.json object. Is there something I'm missing to get the same functionality as swagger 2? Or is this a bug in flask or connexion?
Notice in the output below there is no "status" key in the response.
Steps to reproduce

Clone this repo
pip install -r requirements.txt
run: "python app.py"
Notice the assertion error

Additional info:
Output of the commands:
$ python app.py
------running first round with swagger 2 file-------
this is body in handler:  {'description': 'this is new description'}
this is body in secondary function:  {'description': 'this is new description', 'status': True}
------running second round with swagger 3 file------
this is body in handler:  {'description': 'this is new description'}
this is body in secondary function:  {'description': 'this is new description'}
Traceback (most recent call last):
File "app.py", line 89, in
run_exercise('swagger3.yaml')
File "app.py", line 82, in run_exercise
assert data_json == get_updated_data()
AssertionError

Can we get a resolution on this Please?

The relevant parts of the code base were change completely for Connexion 3 which will be released tomorrow. Feel free to reopen if you still run into the same issue.


decreased body length and other axioms using multicellulat organism

See issue https://github.com/obophenotype/upheno/issues/377
Need to review definitions using multicellular organism in the axioms to see if there is a better term to use

terms that also use multicellular organism
MP:0002499

MP:0012320


Target class [cache] does not exist when using Redis as a session driver

When Redis is configured as a session driver I get the error:
In Container.php line 906:

  Target class [cache] does not exist.

In Container.php line 904:

  Class "cache" does not exist

Script @php artisan package:discover --ansi handling the post-autoload-dump event returned with error code 1

However changing the session driver back to file fixes this issue.
I saw this stale/close issue [#1529]  maybe they are related somehow.

I'm not getting this when running redis on Laravel 11 and Laravel Modules v11
SESSION_DRIVER=redis
CACHE_STORE=redis

Do you have any steps I can follow?
I have a local redis server running, my application runs normally, doing a composer update or dump-autoload

I found our issue. We were returning an exception in our bootstrap/app.php which the redis session driver was not to happy about. 😅
Thanks for the quick answer and sorry for wasting your time!

no problem, glad you found the cause.


go/httpreplay/internal/proxy go get status code 404

(delete this for feature requests)
Client
Describe Your Environment
mac go get/glide
Seeing this error from go get or using glide...
go get -v -u cloud.google.com/go/httpreplay/internal/proxy
Fetching https://cloud.google.com/go/httpreplay/internal/proxy?go-get=1
Parsing meta tags from https://cloud.google.com/go/httpreplay/internal/proxy?go-get=1 (status code 404)
Any help appreciated.
Thanks.

This should be fixed.