Theme preference isn't able to be persisted without bugs

Bug report 🐞
Version & Environment

Chrome 99
geist-ui/core 2.3.7

Expected Behaviour
The behavior I expect is similar to the theme behavior on geist-ui.dev, where theme preferences are stored across sessions. The documentation only shows how to use state, which is not a viable option for me since I want my user's preference to persist.
Actual results (or Errors)
Here is what my site looks like normally (storing theme with useState, exactly as the docs suggest). Expected behavior is:

Here is the error when using both useLocalStorage and useDarkMode:

As you can see, the tags are missing their white text and the <Divider> component doesn't render in anymore. Moreover, the border around <Card> elements is gone. My _app.tsx looks like:
// ...
import { useLocalStorage, useDarkMode } from 'usehooks-ts'

const App = ({ Component, pageProps, router }: AppProps) => {

  // useDarkMode example (still gives error)
  // const { isDarkMode, toggle } = useDarkMode(false)

  // lower-level useLocalStorage example (also gives error)
  const [theme, setTheme] = useLocalStorage('theme', 'dark')

  const toggle = () => {
    setTheme(theme === 'light' ? 'dark' : 'light')
  }

  return (
    <GeistProvider themeType={theme}>
      <CssBaseline />
     { // content }
    </GeistProvider>
  )
}

export default App

The reason this bug confuses me is:

The official documentation site uses local storage without any of these errors, see below.

This functionality for some reason isn't included by default. It seems generally true that end users would expect their theme to be persisted across sessions.

So... my end question is "How did geist-ui.dev deal with theme persistence?", because, unless I'm doing something quite wrong (which is very possible), it doesn't seem like they're using any of the standard hooks.

I ended up finding the repo for the geist documentation site, but ended up finding the implementation used there a bit too much for my use case. I don't know why useDarkMode and useLocalStorage didn't work for me, but the following ended up working just fine (even though they should be doing the exact same thing):
// ...

const App = ({ Component, pageProps, router }: AppProps) => {
  const [theme, setTheme] = useState('light')

  const toggle = () => {
    let newTheme = theme === 'light' ? 'dark' : 'light'
    window.localStorage.setItem('theme', newTheme)
    setTheme(newTheme)
  }

  useEffect(() => {
    const localTheme = window.localStorage.getItem('theme')
    localTheme
      ? setTheme(localTheme)
      : window.localStorage.setItem('theme', theme)
  }, [])

  return // ...

It uses useState on the surface, but syncs the value to local storage.
Closing the issue as this approach solves all UI glitches.


Include headers in windows build

The windows build on the av-feedstock needs the include and lib directories. I don't know what is the standard policy on this, but I think a solution is downloading the ffmpeg source (the dev Zeranoe package) and including them in the respective directories.
Is it OK if I add them? And is it possible to download multiple archives from the meta.yaml?
ref. https://github.com/conda-forge/av-feedstock/pull/1

Look at opencv's build.sh to see how to download extra sources.

looks like this can be closed. @caspervdw please comment back if this is an issue.


Rendering theme views

Is it at all possible to override rails_admin views inside a custom theme?
I've tried creating the same exact files, for example, creating the file _app/views/layouts/rails_admin/navigation.html.haml ,  but it never gets rendered, only if I put it on my main application.

Solved.
http://stackoverflow.com/questions/38018990/overriding-rails-admin-views-inside-custom-theme/38082910#38082910


No longer working on Sketch 51.3

Love this plugin, and it's no longer running on Sketch 51.3. Is there a workaround?
Thanks!

Same for me. Love this amazing plugin. But nothing happens at all right now with latest plugin-update.

New OS was just pushed to my machine and updating to the latest Sketch resolved the issue. Phew.
Ioana Friedman
<EMAIL_ADDRESS>
On Mar 29, 2019, at 3:12 AM, mikaelce<EMAIL_ADDRESS>wrote:
Same for me. Love this amazing plugin. But nothing happens at all right now with latest plugin-update.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.

I updated Mac OS and Sketch. The plugin still doesn't work. :(

@IoanaFriedman Glad the plugin works for you after updating Sketch.
@mikaelce Sorry you are having an issue... I will need to fire up my old version of Sketch to see what the issue is, and see if it's something I can resolve. That said, it's going to get harder and harder to support old versions of Sketch, as new versions are released.

15.11 solved the issue 👍

15.11 solved the issue 👍

Interesting, it did not solve the problem me on 51.3 and the plugin says that it is on version 15.11


Kimberley Mackenzie - Carets

Ada Trader
Congratulations!
Comprehension Questions

Question
Answer

How do Backbone Views help structure your code?
They help clean up code and separate concerns by giving each view responsibility for rendering a certain components and handling DOM events for that component, much like a controller in Rails.

Did you use jQuery directly in your Views? How, and why?
Yes, in the case of reading input from the order form.

What was an example of an event you triggered? Why did you need to trigger it?
My quote view triggers an event whenever it updates so that every time a quote changes price, open orders can check to see if they should be placed.

In what was is unit testing in JavaScript similar to unit testing in Ruby? In what ways is it different?
The structure seemed similar in describe and it blocks, but the expect syntax was different.

Ada Trader
What We're Looking For

Feature
Feedback

Core Requirements

Git hygiene
Good number of commits and good commit messages

Comprehension questions
Check

Organization

Models and collections are defined in separate files
Check

Code that relies on the DOM is located in or called by $(document).ready
Check

Functionality

Quote prices change when clicking Buy and Sell
Check

The Trade History updates when buying and selling a quote
Check

A user can create an open order using the Order Entry Form
Check

An open order removes itself from the open orders and updates the Trade History when fulfilled
Check

General

Has separate views for different parts of the app
Check

Uses events (listening/handling and triggering) to manage different behavior in views
Check

Practices good standards for views (ES6 syntax, doesn't directly use jQuery, returns this in render)
Check

Error handling for the Order Entry Form
Check

Testing

Has unit tests for models
Validation testing

Overall
Nice work, you hit the learning goals.  One thing I would suggest is to move more of the business logic into the models rather than in the views.  For example if an Order has a quote as an attribute it can monitor it for changes and execute trades when that happens.


Interest in using Chroma?

I wonder if there has been any thought or discussions regarding using Chroma or another Go based code highligher?
Thanks

I would welcome this improvement.

Thank you for the suggestion. I'm re-opening it because I would still welcome the improvement if anyone wants to contribute it – I did not mean to imply that I expected @cameronelliott to write it.
I will assign this to myself if I start on it myself.

@osteele I am exploring different static generators, I was using gostatic for over a year or two, so I did experiment with adding Chroma into gostatic. You can see the work here, just in case it helps you.
https://github.com/piranha/gostatic/pull/115

Maybe I should not have closed! ??


Philips WiZ Lights Not Appearing

I'm running HomeBridge on a Raspberry Pi. I've set up two A19 RGB WiZ lights through the WiZ app and they work fine. I've linked WiZ to Google Home and it works fine. But for some reason, the autodiscover is sending a discovery UDP broadcast, but it appears that it isn't getting a response.
I've tried the manual configuration as well, but that doesn't work either.
Logs when restarting HB are below:
[3/14/2022, 10:25:44 AM] [WizSmarthome] [Socket] Setting up socket on <IP_ADDRESS>:38900

[3/14/2022, 10:25:45 AM] [WizSmarthome] [Discovery] Sending discovery UDP broadcast to <IP_ADDRESS>:38899
[3/14/2022, 10:25:45 AM] [WizSmarthome] [Discovery] Sending discovery UDP broadcast to <IP_ADDRESS>:38899
[3/14/2022, 10:25:45 AM] [WizSmarthome] [Discovery] Sending discovery UDP broadcast to <IP_ADDRESS>:38899
[3/14/2022, 10:25:45 AM] Homebridge v1.4.0 (HAP v0.10.0) (Homebridge 35D0) is running on port 51159.

...and that's all the logs say as it pertains to WiZ. No matter what I try, I can't get the lights to show up in the Apple Home app after restarting HB. They do not show up in the HB accessories list, either.

I've turned UDP both on and off in the WiZ app - neither work
I've reserved IP addresses for both of my lights in the Google Home Wi-Fi app - that doesn't work

Any ideas?

Wrong WiZ.
The WiZ lights for this plugin are not the Philips branded.
You want these:

Hm, I think it should work. Can you please double check if you have "Enable Local Communication" set to ON for these bulbs? thanks

I'm having a similar issue. I have the local communication toggle turned on in the WiZ app. Even when adding hosts by IP as shown in the examples, I don't see any accessories in the Homebridge UI.

@bockensm
Get the local IP of you bulbs from your router, reserve the IP of each bulb in your router, and set up the configuration file with the IP addresses.

The 5th bulb showed up on its own a bit ago. Now I'm just down to the 6th one that's known to be on the guest network still.


readline() method

This would be useful for extracting the header from a csv.

I agree. Can you implement it?

I'll give it a shot.

@coreyatmoat what's your progress?

Sadly no. A while back a co-worker wrote https://gist.github.com/coreyatmoat/c961f99dfb0cfabdda54 as a sort of work around, but I haven't had time to figure out how it'd fit into your framework.

+1

I'm having a look at this now, since one of my projects needs this to work too :)
Is there any reason why we need to maintain independent pointers for read and __iter__? The default implementation of readline shares the file pointer with read (and other I/O operations), to the best of my knowledge.

The reason was related to difficulties with buffering IIRC, but was only technical. That behaviour is not a part of the API contract (I don't think it's even documented).
If we can make a single pointer work, that's fine, even preferable.

@piskvorky OK. I think I've got it working. Have a look here: https://github.com/mpenkov/smart_open/commit/aca3a18358afb5f42b5f7e5c1355e8ff93a9bcea
I made a separate branch (readline) for it, since an open pull request (https://github.com/piskvorky/smart_open/pull/75) is currently using the clone's master.
What do you think is the cleanest way of getting this into your repo? I can think of:

You guys merge https://github.com/piskvorky/smart_open/pull/75 whenever you're ready
I update my clone and merge the branch
I make a new pull request for the readline stuff

Let me know if there's a simpler or more convenient way.

Great stuff! @tmylk please review.
Re. branches: it's your call. If splitting the changes into two separate PRs is too complicated, doing both in one branch is fine with me. We appreciate your work, this is some much needed functionality.

@piskvorky @tmylk I've authored a request to pull from my readline to your master (https://github.com/piskvorky/smart_open/pull/76). Let me know if you need anything else from me.

@tmylk I think we can close this now. 78c461e resolved this.


merge from template-sync/template-arlac77-github

package.json

merge from template package.json

Pull Request Test Coverage Report for Build<PHONE_NUMBER>3
Warning: This coverage report may be inaccurate.
This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

For more information on this, see Tracking coverage changes with pull request builds.
To avoid this issue with future PRs, see these Recommended CI Configurations.
For a quick fix, rebase this PR at GitHub. Your next report should be accurate.

Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 22.976%

Totals

Change from base Build<PHONE_NUMBER>5:
0.0%

Covered Lines:
102

Relevant Lines:
453

💛  - Coveralls


REST API: File Attachments

list files of an object
download file of an object
upload a file of an object (this can be achived by sending a REST request via multpart/form-data, i.e. in curl CLI use -F instead of -d)
delete a file of an object

Take care about the permissions

In re multipart formdata : It's possible that the files comes via the usual $_FILES


apiv2(ticdc):  drain capture

What problem does this PR solve?

Issue Number: ref #8019
What is changed and how it works?
implement api v2 drain capture
Check List
Tests

Unit test
Integration test

Questions
Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?
Release note
`None`.

/merge


Allow leadings zeros in std.conv.octal(string)

First of all, the DDoc currently says that:
"Leading zero is allowed, but not required."
The current implementation doesn't respect that.
D lexer allows leading zero(s) also.
And when considering octal from string, there is no possibility
of confusion, as the comments in the code claim. Disallowing
leading zeros for octal conversion from string, does not help
with anything actually.
So lets allow leading zeros.
Allowing leading zeros, does help when implementing various
APIs (i.e. glibc, Linux kernel), where a lot of octal constant,
are defined with multiple leading zeros, for readability and alignment,
in C headers. Having to manually or automatically special case
these when porting such API definitions, is counter-productive.
Example from a Linux kernel (include/uapi/linux/stat.h):
#define S_IFMT  00170000
#define S_IFSOCK 0140000
#define S_IFLNK	 0120000
#define S_IFREG  0100000
#define S_IFBLK  0060000
#define S_IFDIR  0040000
#define S_IFCHR  0020000
#define S_IFIFO  0010000
#define S_ISUID  0004000
#define S_ISGID  0002000
#define S_ISVTX  0001000

With this patch, now it is trivial and easier to convert these to D:
...
enum S_ISVTX = octal!"0001000";

while being close to original. That helps with readability,
and long term maintenance.
In fact the run-time version provided by parse!(int)(string, 8)
also supports leading zeros already. So this makes octal
more consistent.

Fixed style errors

Looks good. I'm not quite sure why the tests are segfaulting on azure.
Also is there a bug report for this? If so, please retitle the commit message "Fix issue #####: Allow leading zeros in std.conv.octal", if not please file.

Add the issue and renamed the commit.
The azur failures are gone, it looks to have been some other unrelated issue. The buildkite issue now also looks unrelated.

I'm quite sure a rebase will fix the failing builkite test.

"Rebased". All passing now.


Added change events

Added onBefore(Up|Down)/After(Up|Down) functions that are called in the process of change migration.
This fixes #626

I have nothing against that. And that would be a sensible approach, however this means that everyone would need to update their migrations.

Nope. As change() is not a defined method. It is called if it exists. If it doesn't exist, it can't be called and also cannot be defined in an interface anywhere.

I probably missed something :P

Also the in the Inserting Data  section there is a note that is now redundant?

Inserting Data in a change() method would still be considered a no-no. OOI, why would you not stick with up() and down() if you wanted to control anything regarding direction? change() really is only about reversible processing.

Whilst the changes are valid, I'm still not sure why change($direction) over up() and down().
And due to the fact that, internally, the table manipulation methods used in a migration's change() method are 'reversed' automatically based upon direction, I think there is a big scope for significant fubar here.
As things stand, the commits are sound, but the actual usage, I'm not so sure about. Convince me (and anyone else who is reading this and wondering why).

Because change knows how to reverse changes itself. However there are some things that one would like to do and cannot be reversed automatically. e.g create some stored procedures, triggers or some other things.
Why do I need to write up/down for everything and not just for things phinx doesn't know how to reverse?

For views, stored procedures, triggers, etc. we will be building repeatables - migrations that can be run again and again specifically for these sort of changes.
But I can see a level of use for this feature.

PostgreSQL doesn't have if not exists or similar for trigger.


App Not Installed longer then a day

We found some users always show "App Not installed" in the log, even the user app deployed longer then 1 day

Sent message several times, the error still not fix

hi @rex-ma,
This issue might occur when the admin reuploads the app to the app catalog by deleting the old one.

Navigate to Azure portal and open company communicator deployed resource group
Click on “Storage account”
Expand “Tables” section
Open “AppConfig” table
Delete the second record where Rowkey is entered as “UserAppId”

So that it populates with the correct value while sending the next message. Let us know if it worked.

Solution not work for our case

Hi @rex-ma,
As per the discussions, it seems the user customized the app and getting issues, please not that we'll not be able to provide support for customized version of the apps.


Fix #31 - Lower minSDK

This aims to answer question asked in #31 - If that is not the case, feel free to close this PR without merging.
Changes here include:

Update android-spock to latest. This allows us to support minSDK 8 and above
Lowered to minSDK to 8
Bump version number

@eyedol The project does not compile against compileSdkVersion 8. This is because apply() is only available since api level 9. I do not want to use commit as it may block the main thread. Instead I suggest dropping api level 8 and supporting 9 instead? What do you think?

Good catch. Since apply is only used in SharedPreferencesOAuth2AccessTokenStorage (right ?) we could use an interface to provide different implementation. Make implementation for apply and commit. I don't know how that will affect spock though. If it's going to cause much issue, then I'll bump it to 9 otherwise I'll provide a fix for that. Let me know.

Well, according to this chart, I think that we can and should drop api level 8 and support everything starting from 9.

Okay. Bumped to minSDK 9

:+1:


I have a question about sampling offset in the pose decoder.

In  FIgure 3.  in your PETR paper, each referencepoint has multi sampling points.
But the shape of input sampling_locations for MultiScaleDeformableAttnFunction  is (bs, num_query, num_heads, num_levels, num_leypoints, 2).
Did you set the number of sampling offsets for one reference point (i.e. one keypoint) as 1?
https://github.com/hikvision-research/opera/blob/a7cadf6ad3f60c6371d1659d1f9f08ba66ed06d2/opera/models/utils/transformer.py#L409

There are (num_heads*num_levels) sampling points for one reference point as you mentioned.

the number of sampling offsets for one reference point (i.e. one keypoint) is set as 1 for each head and feature level

It could be visualized like this. green is the reference point and other points are sampling points.


ctr-remote is poorly maintained and currently uses many deprecated APIs

ctr-remote has only upgraded dependency related maintenance for a long time, in a recent dependency upgrade, golangci-lint reported many deprecated API calls: https://github.com/dragonflyoss/image-service/actions/runs/4571843533/jobs/8070513996
golangci-lint run
Error: commands/rpull.go:94:3: SA1019: containerd.WithSchema1Conversion is deprecated: use Schema 2 or OCI images. (staticcheck)
		containerd.WithSchema1Conversion,
		^
Error: cmd/main.go:30:2: SA1019: seed.WithTimeAndRand is deprecated: Do not rely on the global seed. (staticcheck)
	seed.WithTimeAndRand()
	^
Error: cmd/main.go:24:2: SA1019: "github.com/containerd/containerd/pkg/seed" is deprecated: Do not rely on the global seed. (staticcheck)
	"github.com/containerd/containerd/pkg/seed"
	^

We should replace these deprecated APIs in the future, otherwise it may not be compatible with containerd 1.7.

Do we still need ctr-remote?

Maybe the nerdctl support is enough for users.

Maybe we could migrate ctr-remote to nydusify rpull to reduce maintenance cost, like soci: https://github.com/awslabs/soci-snapshotter/blob/main/docs/getting-started.md#lazily-pull-image

Maybe we could migrate ctr-remote to nydusify rpull to reduce maintenance cost, like soci

We still need to provide run command etc, better to use nerdctl as the replacement.

Maybe we could migrate ctr-remote to nydusify rpull to reduce maintenance cost, like soci

We still need to provide run command etc, better to use nerdctl as the replacement.

Yeah, that sounds great.


Error: UPGRADE FAILED: a released named croc-hunter is in use, cannot re-use a name that is still in use

Even though --force is given, we get an Error: UPGRADE FAILED: a released named croc-hunter is in use, cannot re-use a name that is still in use if the release name exists already
+ helm upgrade --dry-run --install --force croc-hunter /home/jenkins/workspace/loy-and-test-master-with-ingress/charts/croc-hunter --set 'imageTag=feature-0012-deploy-and-test-master-with-ingress-75b3282,replicas=3,cpu=10m,memory=128Mi,ingress.hostname=crochunter.vocon-it.com,imagePullSecrets.name=croc-hunter-secrets,imagePullSecrets.repository=docker.io,imagePullSecrets.username=null,imagePullSecrets.password=null,imagePullSecrets.email=ServicePrincipal@AzureRM,' '--namespace=croc-hunter'
Error: UPGRADE FAILED: a released named croc-hunter is in use, cannot re-use a name that is still in use

The workaround found on https://github.com/helm/helm/issues/5513 is:
TIMEOUT=600
ENV_NAME="release-name"
RELEASE_STATUS=$(helm history "$ENV_NAME" --max 1 -o json | jq -r '.[0].status')
if [ "$RELEASE_STATUS" == 'PENDING_UPGRADE' ]; then
  # Find the highest revision number with status SUPERSEDED.
  GOOD_REVISION=$(helm history "$ENV_NAME" -o json | jq '[.[] | select(.status == "SUPERSEDED")] | max_by(.revision) | .revision')
  helm rollback --wait --timeout "$TIMEOUT" "$ENV_NAME" "$GOOD_REVISION"
fi

However, we need to handle the case the initial installation fails, as well. In that case, no rollback is possible and we need to helm delete --purge ....

I have had a situation that a rollback was not possible because there were no successful deployments in the helm history. This is aggravated by the fact that in helm versions below 3.0, failed deployments are converted to SUPERSEDED deployments by an upgrade, and the information, that the SUPERSEDED release was never successful, is lost. See https://github.com/helm/helm/issues/2832 for details. Therefore, I will create a quick fix: if the previous release is not status DEPLOYED", I will delete and purge the release. Finding the last successful release will be moved to an independent feature request.

Closed by PR https://github.com/oveits/croc-hunter/pull/18


"Go to" commands broken in insider

For inlay hint I have tweak the "go to"-commands so that they can invoked with a location (https://github.com/microsoft/vscode/commit/120718992a05ccf3cf4b90237128e7c561086997). However, it seems that editor actions are always invoked with an empty arguments object...

Verification steps?

To verify Invoke "go to definition" on a symbol with a definition

Works 👍


Get rid of Microsoft.CodeAnalysis.* reference

Avalonia is currently having Microsoft.CodeAnalysis.* dependencies which are useless and introducing ~10mb size bloating (even with the help of trimming).
Manually removing those DLLs after publishing doesn't prevent the app from running .
This kind of dependencies should be removed.

Build your project in Release configuration. Roslyn is required for Avalonia.Diagnostics package that is referenced in Debug configuration in templates


[WIP] Try out Travis windows support

Platforms affected
What does this PR do?
What testing has been done on this change?
Checklist

[ ] Reported an issue in the JIRA database
[ ] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
[ ] Added automated test coverage as appropriate for this change.

I've just restarted the Travis builds and they succeeded! (at least the
continuous-integration/travis-ci/pr) 🎉 - I would assume that these issues/failrues from before could be TravisCI issues since back in December the Windows support was very, very new and in nearly half a year things got more stable.

Okay revert my first comment. :(
Why does https://travis-ci.org/apache/cordova-windows/builds/469915419 fail but https://travis-ci.org/apache/cordova-windows/builds/469915465 succeed? Where is the difference between /travis-ci/push and /travis-ci/pr?

Rebasing the branch onto master should bring those two builds in sync with the same result.

Yes, but I’ve had not enough time earlier. 😊
IMO this is good to be merged
Sent from my iPhone

On 7. May 2019, at 8:06 PM, Jan Piotrowski<EMAIL_ADDRESS>wrote:
Rebasing the branch onto master should bring those two builds in sync with the same result.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the thread.

Merging this doesn't make to much sense, as it just changes the environment from Linux to Windows. It would be better if we could add Windows as another environment for Travis (although we could of course first discuss if this actually makes sense) and more importantly actually test something, similar to what happens on AppVeyor.

But running the tests on windows makes much more sense than testing that the tests for windows pass on Linux?
Of course we could expand the matrix of Travis to test both OS
Tbh I haven’t looked at the AppVeyor config if there are additional tests

On 7. May 2019, at 8:48 PM, Jan Piotrowski<EMAIL_ADDRESS>wrote:
Merging this doesn't make to much sense, as it just changes the environment from Linux to Windows. It would be better if we could add Windows as another environment for Travis (although we could of course first discuss if this actually makes sense) and more importantly actually test something, similar to what happens on AppVeyor.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the thread.

This pr was never intended to be merged, it was to test windows support in travis.
Linux testing doesn't make sense because it just skips over any real tests, and just does linting.
Realistically .travis.yml should look like appveyor.yml on os:windows

But running the tests on windows makes much more sense than testing that the tests for windows pass on Linux?

The tests on Travis are different from the AppVeyor one - they are just testing the platform independent stuff (API etc). On AppVeyor it actually builds apps.

Of course we could expand the matrix of Travis to test both OS

Looking forward to that PR - that would indeed be worth just to get an alternative to AppVeyor.

Tbh I haven’t looked at the AppVeyor config if there are additional tests

Looking at the build output should give you an idea. Having this on Travis CI would give use more environment variations which would be very valuable - because Cordova Windows tends to be brittle there (see current CI failures on master).

Thanks @purplecabbage for kicking this off anyway.


Workflow presets missing node

In native_workflows preset have bunch of node is missing, drag in brower UI wont show anything, just error as images. I have tried use update all and install missing custome node in comfyui not work, many of them use same keyword, such as "Float", dont knew which one is the right one, can you list all the nodes of the workflows pls, thankyou!

@NagaYasu75 , This website https://ltdrdata.github.io/ could be useful for getting the node repo. Just a note, I’m still figuring out how to tell apart conflicted nodes without manually checking them.
AnimateDiff Evolved:

ADE_

easy-comfy-nodes:

BatchPromptSchedule

Derfuu_ComfyUI_ModdedNodes:

Get Image size
Image scale to side
Integer
Float

was-node-suite-comfyui

Load Lora


Error when deploying API Gateway: A GET request to '/' yielded a 502 response code.

I'm trying to deploy to AWS for the first time using Zappa. I have a Django API running in a virtual environment I created using virtualenvwrapper.
When I ran zappa deploy and now when I run zappa update, it seems to go okay - it downloads and installs dependencies, zips the project, uploads it, uploads the Lambda code and then tries to deploy the API Gateway. That's when it fails and I get the following:
Unscheduled chatroomserver-dev-zappa-keep-warm-handler.keep_warm_callback. Scheduled chatroomserver-dev-zappa-keep-warm-handler.keep_warm_callback with expression rate(4 minutes)! Error: Warning! Status check on the deployed lambda failed. A GET request to '/' yielded a 502 response code.
It's a super simple chat API, I pushed it here: https://github.com/michaloslav/Chatroom-Backend
(I didn't push ChatroomServer/settings.py because it includes databases access information so if you try to run it, it won't work)
Environment:
Zappa version: 0.48.2
Win 10, Python 3.7
Pip freeze output:
argcomplete==1.9.3 astroid==2.2.5 base58==0.2.4 boto3==1.9.185 botocore==1.12.185 certifi==2019.6.16 cfn-flip==1.2.1 chardet==3.0.4 Click==7.0 colorama==0.4.1 dataclasses==0.6 Django==2.2.3 django-cors-headers==3.0.2 django-filter==2.1.0 django-mongodb-engine==0.6.0 djangorestframework==3.9.4 djongo==1.2.33 docutils==0.14 durationpy==0.5 future==0.16.0 handler==1.3.0 hjson==3.0.1 idna==2.8 isort==4.3.21 jmespath==0.9.3 kappa==0.6.0 lambda-packages==0.20.0 lazy-object-proxy==1.4.1 Markdown==3.1.1 mccabe==0.6.1 placebo==0.9.0 pylint==2.3.1 pymongo==3.8.0 python-dateutil==2.6.1 python-slugify==1.2.4 pytz==2019.1 PyYAML==5.1.1 requests==2.22.0 s3transfer==0.2.1 six==1.12.0 sqlparse==0.2.4 toml==0.10.0 tqdm==4.19.1 troposphere==2.4.9 typed-ast==1.4.0 Unidecode==1.1.1 urllib3==1.25.3 Werkzeug==0.15.4 wrapt==1.11.2 wsgi-request-logger==0.4.6 zappa==0.48.2
zappa_settings.json:
{     "dev": {         "aws_region": "us-east-2",         "django_settings": "ChatroomServer.settings",         "profile_name": "default",         "project_name": "chatroomserver",         "runtime": "python3.7",         "s3_bucket": "michaloslav-chatroom",         "extra_permissions": [{             "Effect": "Allow",             "Action": ["rekognition:*"],             "Resource": "*"         }]     } }
I already saw some people having similar issues and there seem to be 2 potential solutions:

Running zappa tail and installing any missing dependencies. I tried that and got the following:
1562750236050] [ERROR] Runtime.ImportModuleError: Unable to import module 'handler': No module named 'werkzeug [1562753064340] [ERROR] Runtime.HandlerNotFound: Handler 'lambda_handler' missing on module 'handler'
(both of these occured multiple times and there was also some other stuff but it doesn't seem relevant)

So I pip installed handler, tried upgrading werkzeug which was already up to date and tried installing lambda_handler which doesn't exist. I tried zappa update again after that and still got the same result
2) Downgrading Zappa to 0.45.1. I tried that but it doesn't support Python 3.7. If necessary, I could downgrade to Python 3.6, the code should still work. I'm not really sure how that would work though and there should be a way to get it to work without downgrading.

I think the problem is related with TQDM (https://github.com/tqdm/tqdm/issues/466). I'm not sure why it started happening now, since Zappa's usage of this version of TQDM goes back two years.
Either way, if you force TQDM version to be >= 4.32.2, it works. Your dependency manager probably will complain but it worked with me. I'm using pipenv, by the way.

In my case, Google's Bigquery crashed before Zappa but for the same reason. The full log, for debugging purposes is:
[Errno 38] Function not implemented: OSError
Traceback (most recent call last):
File "/var/task/handler.py", line 602, in lambda_handler
return LambdaHandler.lambda_handler(event, context)
File "/var/task/handler.py", line 245, in lambda_handler
handler = cls()
File "/var/task/handler.py", line 139, in __init__
self.app_module = importlib.import_module(self.settings.APP_MODULE)
File "/var/lang/lib/python3.6/importlib/__init__.py", line 126, in import_module
return _bootstrap._gcd_import(name[level:], package, level)
File "<frozen importlib._bootstrap>", line 994, in _gcd_import
File "<frozen importlib._bootstrap>", line 971, in _find_and_load
File "<frozen importlib._bootstrap>", line 955, in _find_and_load_unlocked
File "<frozen importlib._bootstrap>", line 665, in _load_unlocked
File "<frozen importlib._bootstrap_external>", line 678, in exec_module
File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
File "/var/task/mobex/zappa.py", line 4, in <module>
from .application import create_app
File "/var/task/mobex/application.py", line 18, in <module>
from .routes import mobex_routes
File "/var/task/mobex/routes.py", line 11, in <module>
from .exporter import AdjustExporter, Exporter, BigQueryExportingError
File "/var/task/mobex/exporter.py", line 7, in <module>
from google.cloud import bigquery
File "/var/task/google/cloud/bigquery/__init__.py", line 35, in <module>
from google.cloud.bigquery.client import Client
File "/var/task/google/cloud/bigquery/client.py", line 53, in <module>
from google.cloud.bigquery.dataset import Dataset
File "/var/task/google/cloud/bigquery/dataset.py", line 26, in <module>
from google.cloud.bigquery.table import TableReference
File "/var/task/google/cloud/bigquery/table.py", line 37, in <module>
import tqdm
File "/var/task/tqdm/__init__.py", line 1, in <module>
from ._tqdm import tqdm
File "/var/task/tqdm/_tqdm.py", line 53, in <module>
mp_lock = mp.Lock() # multiprocessing lock
File "/var/lang/lib/python3.6/multiprocessing/context.py", line 67, in Lock
return Lock(ctx=self.get_context())
File "/var/lang/lib/python3.6/multiprocessing/synchronize.py", line 162, in __init__
SemLock.__init__(self, SEMAPHORE, 1, 1, ctx=ctx)
File "/var/lang/lib/python3.6/multiprocessing/synchronize.py", line 59, in __init__
unlink_now)
OSError: [Errno 38] Function not implemented

@fbidu Thanks for the idea. I tried it and then ran zappa update again but still got the same error message. Anyone got any other ideas? Is there some AWS-side config I missed?
Or maybe I could try to downgrade Python within the virtualenv, if that's even how that works. If anyone knows how to do that, maybe that could be a work around

@fbidu Thanks for the idea. I tried it and then ran zappa update again but still got the same error message. Anyone got any other ideas? Is there some AWS-side config I missed?
Or maybe I could try to downgrade Python within the virtualenv, if that's even how that works. If anyone knows how to do that, maybe that could be a work around

Huh, that's weird... Can you see the full log in your AWS CloudWatch?

Sorry about the late reply. The logs are basically these lines all over again and again.
START RequestId: 41f30055-88aa-4be2-af60-eaa13b5ef45d Version: $LATEST
[ERROR] Runtime.HandlerNotFound: Handler 'lambda_handler' missing on module 'handler'
END RequestId: 41f30055-88aa-4be2-af60-eaa13b5ef45d
REPORT RequestId: 41f30055-88aa-4be2-af60-eaa13b5ef45d	Duration: 1.47 ms	Billed Duration: 100 ms Memory Size: 512 MB	Max Memory Used: 53 MB
(The RequestId changes with every request)
It really looks like the lambda_handler thing might be the problem but I have no idea how to fix that. I already installed handler and it's up to date

I have the same error also

I'm getting the same error in CloudWatch and "zappa tail"
[ERROR] Runtime.ImportModuleError: Unable to import module 'handler': No module named 'werkzeug'

Version 0.45.1 will work under Python 3.6.1

I was getting the same issue, and I was running an older version of Zappa, so I updated Zappa to the latest version. After updating, it's been working. If you are running the latest version you might try downgrading, then upgrading. Sometimes the installation process "fixes" things.

[~/env>> virtualenv-3.7 zappa
[~/env>> cd zappa/
[~/env/zappa>> source bin/activate
(zappa) [~/env/zappa>> pip install django zappa
(zappa) [~/env/zappa>> mkdir uploader
(zappa) [~/env/zappa>> cd uploader/
(zappa) [~/env/zappa/uploader>> django-admin startproject uploader .
(zappa) [~/env/zappa/uploader>> zappa init

{
    "dev": {
        "aws_region": "eu-central-1",
        "django_settings": "uploader.settings",
        "profile_name": "xxxx",
        "project_name": "uploader",
        "runtime": "python3.7",
        "s3_bucket": "zappa-xxxx"
    }
}

(zappa) [~/env/zappa/uploader>> zappa deploy
Calling deploy for stage dev..
Downloading and installing dependencies..
 - sqlite==python3: Using precompiled lambda package
'python3.7'
Packaging project as zip.
Uploading uploader-dev-1567076262.zip (14.8MiB)..
100%|████████████████████████████████████████████████████████████████████████████████████████████████████████████████████| 15.5M/15.5M [00:08<00:00, 1.90MB/s]
Scheduling..
Scheduled uploader-dev-zappa-keep-warm-handler.keep_warm_callback with expression rate(4 minutes)!
Uploading uploader-dev-template-1567076299.json (1.6KiB)..
100%|████████████████████████████████████████████████████████████████████████████████████████████████████████████████████| 1.62K/1.62K [00:00<00:00, 19.7KB/s]
Waiting for stack uploader-dev to create (this can take a bit)..
100%|██████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████| 4/4 [00:09<00:00,  2.40s/res]
Deploying API Gateway..
Error: Warning! Status check on the deployed lambda failed. A GET request to '/' yielded a 502 response code.

[~>> curl https://xxxx.execute-api.eu-central-1.amazonaws.com/dev
"{'message': 'An uncaught exception happened while servicing this request. You can investigate this with the `zappa tail` command.', 'traceback': ['Traceback (most recent call last):\\n', '  File \"/var/task/handler.py\", line 531, in handler\\n    with Response.from_app(self.wsgi_app, environ) as response:\\n', '  File \"/var/task/werkzeug/wrappers/base_response.py\", line 287, in from_app\\n    return cls(*_run_wsgi_app(app, environ, buffered))\\n', '  File \"/var/task/werkzeug/test.py\", line 1119, in run_wsgi_app\\n    app_rv = app(environ, start_response)\\n', \"TypeError: 'NoneType' object is not callable\\n\"]}"

argcomplete==1.9.3
boto3==1.9.218
botocore==1.12.218
certifi==2019.6.16
cfn-flip==1.2.1
chardet==3.0.4
Click==7.0
Django==2.2.4
docutils==0.15.2
durationpy==0.5
future==0.16.0
hjson==3.0.1
idna==2.8
jmespath==0.9.3
kappa==0.6.0
lambda-packages==0.20.0
placebo==0.9.0
python-dateutil==2.6.1
python-slugify==1.2.4
pytz==2019.2
PyYAML==5.1.2
requests==2.22.0
s3transfer==0.2.1
six==1.12.0
sqlparse==0.3.0
toml==0.10.0
tqdm==4.19.1
troposphere==2.5.1
Unidecode==1.1.1
urllib3==1.25.3
Werkzeug==0.15.5
wsgi-request-logger==0.4.6
zappa==0.48.2

What is wrong? Thanks in advance for your help :)

The output of zappa tail is needed to help solve the problem.

@michaloslav Your runtime must be 3.6. 3.7 will works only if you are running GNU/Linux based OS. I guess you are running an OSX as mine.

✅ I had a similar issue that using tqdm 4.32.2 and Python 3.7 from a Linux OS instead of MacOS/OS X solved for me.

I had the issue, with tail showing OSError: [Errno 38] Function not implemented . Updating tqdm to 4.32.2 solved the issue

Running into the same issue (i.e. "Error: Warning! Status check on the deployed lambda failed. A GET request to '/' yielded a 502 response code."). I ran zappa tail and got this error message. Not sure how to proceed.
[1581013830765] [DEBUG] 2020-02-06T18:30:30.765Z 7bfa4009-be95-4208-9194-ac654ef50a80 Event needs-retry.s3.GetObject: calling handler <bound method S3RegionRedirector.redirect_from_error of <botocore.utils.S3RegionRedirector object at 0x7f82c591ec90>>

having same problem any fix
Microsoft Windows [Version 10.0.18362.657]
(c) 2019 Microsoft Corporation. All rights reserved.
C:\WINDOWS\system32>cd c:\users\paul\desktop\project
c:\Users\paul\Desktop\project>env\scripts\activate.bat
c:\Users\paul\Desktop\project>venv
'venv' is not recognized as an internal or external command,
operable program or batch file.
c:\Users\paul\Desktop\project>zappa deploy dev
Calling deploy for stage dev..
Error: This application is already deployed - did you mean to call update?
c:\Users\paul\Desktop\project>zappa update dev
Calling update for stage dev..
Downloading and installing dependencies..

markupsafe==1.1.1: Using locally cached manylinux wheel
cryptography==2.1.4: Using locally cached manylinux wheel
cffi==1.14.0: Using locally cached manylinux wheel
Packaging project as zip.

Warning: Application zip package is likely to be too large for AWS Lambda. Try setting "slim_handler" to true in your Zappa settings file.
Uploading project-dev-1582597588.zip (80.4MiB)..
100%|█████████████████████████████████████████████████████████████████████████████| 84.3M/84.3M [00:29<00:00, 2.82MB/s]
Updating Lambda function code..
Updating Lambda function configuration..
Uploading project-dev-template-1582597977.json (1.6KiB)..
100%|█████████████████████████████████████████████████████████████████████████████| 1.60k/1.60k [00:00<00:00, 11.4kB/s]
Deploying API Gateway..
Scheduling..
Unscheduled project-dev-zappa-keep-warm-handler.keep_warm_callback.
Scheduled project-dev-zappa-keep-warm-handler.keep_warm_callback with expression rate(4 minutes)!
Error: Warning! Status check on the deployed lambda failed. A GET request to '/' yielded a 502 response code.
c:\Users\paul\Desktop\project>

It seems that the package
[handler]
is confusing zappa,
This error message disappears after running
pip uninstall handler

It seems that the package
[handler]
is confusing zappa,
This error message disappears after running
pip uninstall handler

handler is not event present in the venv, I checked the requirements file, (didn't find it, still ran it out of desperation to deploy). Still no relief
WARNING: Skipping handler as it is not installed.
My Error Breakpoint for reference:
Deploying API Gateway..
Error: Warning! Status check on the deployed lambda failed. A GET request to '/' yielded a 500 response code.

I also found this interesting comment
Comment
The main issue is that there are indeed precompiled libraries we use - mainly psycopg2.
This one is not working in Lambda - hence you should include instead aws-psycopg2.

It seems that the package
[handler]
is confusing zappa,
This error message disappears after running
pip uninstall handler

handler is not event present in the venv, I checked the requirements file, (didn't find it, still ran it out of desperation to deploy). Still no relief
WARNING: Skipping handler as it is not installed.

My Error Breakpoint for reference:
Calling deploy for stage dev..
Downloading and installing dependencies..
 - typed-ast==1.4.1: Downloading
100%|████████████████████████████████████████████████████████████████████████████████| 738k/738k [00:00<00:00, 2.43MB/s]
 - markupsafe==1.1.1: Downloading
100%|██████████████████████████████████████████████████████████████████████████████| 27.5k/27.5k [00:00<00:00, 1.83MB/s]
 - lazy-object-proxy==1.4.3: Downloading
100%|██████████████████████████████████████████████████████████████████████████████| 56.5k/56.5k [00:00<00:00, 1.78MB/s]
Packaging project as zip.
Uploading capp-dev-1587298017.zip (11.5MiB)..
100%|███████████████████████████████████████████████████████████████████████████████| 12.0M/12.0M [00:36<00:00, 329kB/s]
Scheduling..
Scheduled capp-dev-zappa-keep-warm-handler.keep_warm_callback with expression rate(4 minutes)!
Uploading capp-dev-template-1587298074.json (1.6KiB)..
100%|██████████████████████████████████████████████████████████████████████████████| 1.59k/1.59k [00:00<00:00, 1.72kB/s]
Waiting for stack capp-dev to create (this can take a bit)..
 75%|███████████████████████████████████████████████████████████████                     | 3/4 [00:13<00:04,  4.57s/res]
Deploying API Gateway..
Error: Warning! Status check on the deployed lambda failed. A GET request to '/' yielded a 500 response code.

This is a very general error message:

A GET request to '/' yielded a 500 response code.

You need to run zappa tail to check its details. Uninstalling handler package can resolve this error:

Runtime.HandlerNotFound: Handler 'lambda_handler' missing on module 'handler'

Thank you i will try this
On Sunday, April 19, 2020, xg1990<EMAIL_ADDRESS>wrote:

It seems that the package
[handler] https://pypi.org/project/handler/
is confusing zappa,
This error message disappears after running
pip uninstall handler
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/Miserlou/Zappa/issues/1897#issuecomment-616112859,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AOSIQHX6ELURL6746NN2GUDRNLP27ANCNFSM4H7NZKOA
.

Hello everyone,
I am working with a Django application and I wanted to state that I am having a similar issue here.
Scheduling..
Unscheduled testproject-dev-zappa-keep-warm-handler.keep_warm_callback.
Scheduled testproject-dev-zappa-keep-warm-handler.keep_warm_callback with expression rate(4 minutes)!
Error: Warning! Status check on the deployed lambda failed. A GET request to '/' yielded a 502 response code.

I also checked the tail output and it returns the following error below:
[1587877984524] [DEBUG] 2020-04-26T05:13:04.524Z 7e5760cb-1904-4df8-b9bf-a7a9f3472d4d amazonaws found in host
[1587877984524] 'NoneType' object is not callable

My Zappa_settings.json isnt anything too fancy. It is located in the same dir as my manage.py and the django_settings points to the settings file. I did noticed that the project was a bit large so I added the slim_handler option so that the uploaded package would be smaller.
{
    "dev": {
        "aws_region": "us-east-1",
        "django_settings": "testproject.settings",
        "profile_name": "default",
        "project_name": "testproject",
        "runtime": "python3.7",
        "s3_bucket": "zappa-5jlzblfqz",
        "slim_handler": "true"
    }
}

I am working within a virtual environment called "env-test" within a docker container so it is as isolated as it gets. I am running it on Ubuntu. My requirements are as follows:
Package                 Version
----------------------- ---------
argcomplete             1.11.1
asgiref                 3.2.7
astroid                 2.3.3
boto3                   1.12.46
botocore                1.15.46
certifi                 2019.6.16
cfn-flip                1.2.3
chardet                 3.0.4
click                   7.1.1
decorator               4.4.0
defusedxml              0.6.0
Django                  3.0.5
django-allauth          0.41.0
django-cleanup          4.0.0
django-cors-headers     3.2.1
django-js-asset         1.2.2
django-model-utils      3.2.0
django-rest-auth        0.9.5
django-vote             2.1.7
djangorestframework     3.11.0
docutils                0.16
durationpy              0.5
future                  0.18.2
gunicorn                20.0.4
hjson                   3.0.1
humanize                0.5.1
idna                    2.8
importlib-metadata      1.6.0
isort                   4.3.21
jmespath                0.9.5
kappa                   0.6.0
lazy-object-proxy       1.4.3
libcnml                 0.9.5
mccabe                  0.6.1
oauthlib                3.1.0
pip                     20.0.2
pip-tools               5.0.0
placebo                 0.9.0
psycopg2-binary         2.8.4
pylint                  2.4.4
python-akismet          0.4.1
python-dateutil         2.8.0
python-slugify          4.0.0
python3-openid          3.1.0
pytz                    2019.1
PyYAML                  5.3.1
requests                2.22.0
requests-oauthlib       1.3.0
s3transfer              0.3.3
setuptools              46.1.3
six                     1.12.0
sqlparse                0.3.0
text-unidecode          1.3
toml                    0.10.0
tqdm                    4.45.0
troposphere             2.6.0
typed-ast               1.4.0
urllib3                 1.25.3
Werkzeug                0.16.1
wheel                   0.34.2
wrapt                   1.11.2
wsgi-request-logger     0.4.6
zappa                   0.51.0
zipp                    3.1.0

And finally when I navigate to the url provided by zappa status, I receive the following error:
"{'message': 'An uncaught exception happened while servicing this request. You can investigate this with the `zappa tail` command.', 'traceback': ['Traceback (most recent call last):\\n', '  File \"/var/task/handler.py\", line 540, in handler\\n    with Response.from_app(self.wsgi_app, environ) as response:\\n', '  File \"/var/task/werkzeug/wrappers/base_response.py\", line 287, in from_app\\n    return cls(*_run_wsgi_app(app, environ, buffered))\\n', '  File \"/var/task/werkzeug/wrappers/base_response.py\", line 26, in _run_wsgi_app\\n    return _run_wsgi_app(*args)\\n', '  File \"/var/task/werkzeug/test.py\", line 1119, in run_wsgi_app\\n    app_rv = app(environ, start_response)\\n', \"TypeError: 'NoneType' object is not callable\\n\"]}"

While tinkering with the project, I did see a package error when using zappa update:
ERROR: zappa 0.51.0 has requirement python-dateutil<2.7.0, but you'll have python-dateutil 2.8.0 which is incompatible.
ERROR: botocore 1.15.46 has requirement docutils<0.16,>=0.10, but you'll have docutils 0.16 which is incompatible.

But after changing even those dependencies, the result was the same. Any help would be appreciated!

@Ronster2018 Try pip-tools and use pip-compile to make your requirements.txt

@elcolie Thanks for your recommendation, but that did not work. I had the same outcome. I had the same outcome. I am going to try to just start a very basic Django application and try it from there. Hopefully the deployment works and I will be able to build on top of that.

After investigating the tail output, I noticed that an exception was being raised. It was relating to the sqlite version that I had installed. The exception that was thrown was early on and it looks like this is what was causing my issue. After implementing the fix, Zappa began to work for me! The work around can be found here under a different issue for this project.
I hope this helps!


apply for a new open-grants

Grant Application Checklist

[ ] The application-template.md has been copied, renamed ( "project_name.md") and updated.
[ ] A BTC address for the payment of the milestones is provided inside the application.
[ ] The software of the project will be released under the Apache license version 2.0 as specified in the terms and conditions.
[ ] The total funding amount of the project is below CHF 30k at the time of submission.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Just a reminder: You need to sign the cla assistant, before we consider your application.

hi, now I have signed the cla assistant

I’m closing the application for now, as discussed on our call yesterday.


Scaling should be done in plotMatrices

The object returned by parseRegions should not have scaled data.

No longer relevant with v2 of metagene.


Make timerSignal work better with SSR

The setTimeout needs to be prevented if running on server.  Maybe it is an option?  Or maybe there can be a way to delay the start?

Checks isPlatformBrowser before starting timer


Train MLE policy for sgd dataset

I was trying to train MLE policy for sgd. I've added default_state in  convlab.util.sgd.state (similar to multiwoz21) but I got the following error. Would you please guid me in this:

Hi @AtheerAlgherairy! I pushed some changes and it worked for me now, can you try again? Please first delete the folder sgd_VectorBinary inside of policy/mle

Thank you very much @ChrisGeishauser. It is worked and the training on SGD completed.
I was trying to use the pre-trained model on SGD  but I got the following output (info for Multiwoz):

I was trying to pass a state to the MLE policy and use predict function, as follows:

The output above shows the generated state from DST.  I got the following error:

I changed dbquery_domain in vector_base.py to return an empty list since SGD doesn't have database, I got another error in the  lexicalize_da in lexicalize.py:

Hi @AtheerAlgherairy! As you correctly observed, SGD has no database and hence no query is possible. Because of this, lexicalization would be only partially possible but you could never inform something from the database for instance. At the moment, the lexicalization function is only working with the multiwoz corpus and has not yet a generalization to other datasets. But we are very happy for any contribution to this!

Thanks @ChrisGeishauser.
I extracted database for SGD from service_results element in the dialogues:
https://github.com/AtheerAlgherairy/SGD_database

Hi @AtheerAlgherairy. Did you use dataset_name = "multiwoz21"?

After training mle on multiwoz, I got this folder:

The resulted model should be here, right:

And here is the cofig file under configs folder:

is there something missing?

Can you tell me how you initialised "sys_policy_mwoz"? And there is nothing missing for your data I think :)

sys_policy_mwoz= MLEPolicy(model_file="C:/Users/g201906730/Desktop/ConvLab-3/convlab/policy/mle/experiments/experiment_2023-05-08-11-49-48/save/supervised.pol.mdl")

When initializing mle policy with model file, the load_from_pretrained is called as follows:
self.load_from_pretrained(archive_file, model_file, cfg['load'])
The last argument cfg['load'] is for file_name which is here: save/best.  However, there is no such file name generated after mle training.
the  load_from_pretrained function in mle.py uses this file name to load the model. it doesn't use the provided model_file.

Instead of loading the MLE policy, could you maybe just try to load the PPO policy? It uses the same architecture, so there is no difference when doing a prediction.
from convlab.policy.ppo import PPO policy_sys = PPO(dataset_name="multiwoz21", load_path="YOUR_MLE_EXPERIMENT_FOLDER/save/supervised")
The experiment folder is the one you mentioned above that also has the timestamp in it. You can also set load_path="from_pretrained" to automatically download a multiwoz model.
If you want to experiment with SGD, I would recommend you to take the DDPT policy instead:
from convlab.policy.vtrace_DPT import VTRACE policy = VTRACE(dataset_name="sgd", load_path="from_pretrained")

The dataset argument is not there.

Can you pull the newest version and try again? It works for me.

@ChrisGeishauser  Thank you..

The SYS RESPONSE shouldn't be like this. right?

Thanks @ChrisGeishauser .. I will try again..
Is there Agenda Based User Simulator for SGD dataset?

Hi @AtheerAlgherairy! No, there is only an ABUS for MultiWOZ at the moment.


Contributors, Please Clarify: Does this version work with Azure Mobile Client or Not?

Hi,
I've been trying to figure out if I am supposed to be using this Nuget for Xamarin.Auth with mobile app on Azure (using Azure Mobile App Client and Server libraries) or am I supposed to be using this one
"Auth for Azure" ?
I am targeting Xamarin.Forms "235.Pre6" using .Net Standard project for the Xam Forms project and trying, unsuccessfully, to use either 4.0.0 or 4.0.1 of Azure Mobile Client
I am only trying to use Xamarin.Auth for secure account and token storage abstract.  What ever the "right" way to get authentication working again for Azure and Xamarin on 4.x will someone please respond?
Thanks, sincerely.
Dave G

@dgerding
Xamarin.Auth has changed a lot in version 1.4. and 1.5 to support Native UI. I contacted Azure Mobile Service Client team and am being in contact with them, but they decided to keep their own fork of Xamarin.Auth. This means they must change code to compile Xamarin.Auth for their need (mostly changing  public to internal).
Recent changes to Xamarin.Auth (coming in <IP_ADDRESS>, after my vacation - 2 more weeks)  have preprocessor defines to reduce changes for Azure Mobile Service Client team, so they will be able to do the changes faster.
Last info from their team was that the Xamarin.Auth code (their fork) was under review. When this will be available - I have no idea. My suggestion is ping them pls. I simply have no time to try to implement AMSC myself.
... and if the answer is OK for you close the issue, pls.

no response since Aug 2017


Seeing this error everytime when i am toggling tree view

Remote Ftp has an option of auto-hide local treview when ftp view is visible.
So i've enabled it.
When i'm turn off ftp tree view with package short key, default local treeview becomes visible again.
So i toggle off it too, because i need more space. with Ctrl +
And everything is ok.
When in second moment i'm using a shortkey to show again treeview of Remote-FTP i see this error msg.
At first glance it does nothing to me. I am just closing this msg. But it appears again and again when i switch between toggle on/off between ftp and local trees.
Steps:

show ftp tree (package auto hides local treeview, there is an option)
hide ftp tree ( and i can see local treeview again)
hide local tree view too. (no active tree view now)
show ftp tree view ( pop-ups an error)

TypeError: Cannot read property 'destroy' of null at TreeView.module.exports.TreeView.detach (C:\Users\Admin\AppData\Local\atom\app-1.8.0\resources\app.asar\node_modules\tree-view\lib\tree-view.js:439:17) at hideLocalTree (C:\Users\Admin\.atom\packages\Remote-FTP\lib\views\tree-view.js:9:65) at TreeView.module.exports.TreeView.attach (C:\Users\Admin\.atom\packages\Remote-FTP\lib\views\tree-view.js:213:4) at TreeView.module.exports.TreeView.toggle (C:\Users\Admin\.atom\packages\Remote-FTP\lib\views\tree-view.js:233:9) at atom-workspace.atom.commands.add.remote-ftp:toggle (C:\Users\Admin\.atom\packages\Remote-FTP\lib\remote-ftp.js:117:19) at CommandRegistry.module.exports.CommandRegistry.handleCommandEvent (C:\Users\Admin\AppData\Local\atom\app-1.8.0\resources\app.asar\src\command-registry.js:260:29) at C:\Users\Admin\AppData\Local\atom\app-1.8.0\resources\app.asar\src\command-registry.js:3:61 at KeymapManager.module.exports.KeymapManager.dispatchCommandEvent (C:\Users\Admin\AppData\Local\atom\app-1.8.0\resources\app.asar\node_modules\atom-keymap\lib\keymap-manager.js:580:16) at KeymapManager.module.exports.KeymapManager.handleKeyboardEvent (C:\Users\Admin\AppData\Local\atom\app-1.8.0\resources\app.asar\node_modules\atom-keymap\lib\keymap-manager.js:388:22) at WindowEventHandler.module.exports.WindowEventHandler.handleDocumentKeyEvent (C:\Users\Admin\AppData\Local\atom\app-1.8.0\resources\app.asar\src\window-event-handler.js:98:36) at HTMLDocument.<anonymous> (C:\Users\Admin\AppData\Local\atom\app-1.8.0\resources\app.asar\src\window-event-handler.js:3:61)

I am still getting this.
And i've found that i am not only one.
Last 2 comments.
https://github.com/atom/tree-view/issues/390

@maximumver I've implemented a workaround for this in the dev branch. I plan on pulling this into the next update in the next few days.

This still happens to me with 0.9.0 (Atom 1.11.1).
The same steps from @maximumver 's report can be taken to reproduce.
I am also getting the Remote FTP: See issue #433 message, although I don't know how to view the more specific error message (like the 'TypeError: Cannot read property...' in @maximumver 's report).

@gilad905 So what are you seeing when you toggle tree view. Is it just the info popup? If so that should be happening as there is a bug which I couldn't fix so I just made a workaround to only show the info window once.

@jimmaaay if you follow the same step as in @maximumver 's report:

show ftp tree.
hide ftp tree -> here, local treeview pops up.
hide local tree view -> no side pane visible.
show ftp tree view -> pop-ups an error.
GOTO step 1. and the cycle goes on like this.

The error pop up doesn't disturb me - the problem for me is that the local tree view will always re-open on step 2. Although it was already manually hidden before (step 3). This is annoying because most of the time I wish no side pane will be visible, at all.
Thanks! Gilad.


Invalidate intrinsic content size when updating ShiftMaskableLabel text

I'm using ShiftMaskableLabel inside a cell and when it gets reused sometimes the text would be clipped and/or with the wrong position.
This seems to fix the issue.

👍


Add github.com/becheran/mlc

https://github.com/becheran/mlc

Thank you.

https://github.com/aquaproj/aqua-registry/pull/29330


Update axiom-configure

Update to packer 1.8.1

Update to packer 1.8.1 which was causing an error and braking in AWS


Android error reporting delayed

Describe the bug
It appears that error reports from Android devices are delayed compared to reports from an iOS device for the exact same bug (in some cases, by up to 3 hours). I have an error boundary set up (following this guide) in my React Native app, and purposefully crash the app via a button click, which tries to render some text outside of a Text component (this causes a crash and triggers the error boundary). I set up Bugsnag by following the docs and using @bugsnag/react-native-cli, and besides the Error Boundary, there is no extra config I've added to my project that would affect Bugsnag. The reports do come through, so that part is not an issue—but why does it take so much longer than for iOS?
This is essentially what my test component looks like:
const BugsnagTest = () => {
  const [element, setElement] = useState(<></>)

  return (
    <View>
      {element}
      <Button
        text='Send error to Bugsnag'
        onPress={() => {
          setElement(<>Send error to Bugsnag!</>)
        }}
      />
    </View>
  )
}

Here you can see the reports from my Bugsnag dashboard, hours apart:

Steps to reproduce
Trigger the Bugsnag error boundary in both an iOS and Android device, i.e. by trying to render text outside of a Text component, and you should notice that the Android report takes much longer to show up in the dashboard.
@bugsnag/react-native: 7.17.4
React: 17.0.2
React Native: 0.66.3
Device: the Android device I tested on is a Galaxy S10, the iOS device is an iPhone XS

Hi @Twinbird24, would you mind sending some links to those errors as they appear on your Bugsnag dashboard? You can send those to<EMAIL_ADDRESS>to avoid posting them publicly.
Additionally is this still reproducible now? I'm currently trying to rule the possibility that there may just have been a significant backlog on our android report queue at the time meaning it was delayed in processing.

@johnkiely1 I've just sent an email, sorry about the delay. I've since had to switch to the free/lite version of Bugsnag and my old errors are gone. I just tested this recently and the iOS error came through right away, but I'm still waiting on the Android error to show up in the dashboard.

Thanks @Twinbird24, got the email. We are investigating now and will follow up with you on that ticket.

Thank you! Looks like the Android errors came through as well, but again, delayed by several hours (the crashes did happen about an hour apart, but the time difference between the errors is still much greater than an hour).

Hi @Twinbird24 - As discussed on the support ticket, this is a known issue. Our engineering team is looking to fix this, however I don't have an ETA on this at the moment. We will make sure to keep this thread updated 👍


No instrumentation detected

Here is my test script.rb:
#!/usr/bin/env ruby

require 'kisaten'

Kisaten.init

puts Integer($stdin.read)

I have one file in the input directory: number.txt containing a valid integer.
Here is the output of afl-fuzz -i input/ -o output/ -t 1000  -m 1000 -- ruby script.rb @@
koyoko% afl-fuzz -i input/ -o output/ -t 1000  -m 1000 -- ruby script.rb @@
afl-fuzz 2.56b by<EMAIL_ADDRESS>[+] You have 8 CPU cores and 1 runnable tasks (utilization: 12%).
[+] Try parallel jobs - see /usr/share/doc/afl/parallel_fuzzing.txt.
[*] Checking CPU core loadout...
[+] Found a free CPU core, binding to #0.
[*] Checking core_pattern...
[*] Checking CPU scaling governor...
[*] Setting up output directories...
[+] Output directory exists but deemed OK to reuse.
[*] Deleting old session data...
[+] Output dir cleanup successful.
[*] Scanning 'input/'...
[+] No auto-generated dictionary tokens to reuse.
[*] Creating hard links for all input files...
[*] Validating target binary...

[-] Looks like the target binary is not instrumented! The fuzzer depends on
    compile-time instrumentation to isolate interesting test cases while
    mutating the input data. For more information, and for tips on how to
    instrument binaries, please see /usr/share/doc/afl/README.

    When source code is not available, you may be able to leverage QEMU
    mode support. Consult the README for tips on how to enable this.
    (It is also possible to use afl-fuzz as a traditional, "dumb" fuzzer.
    For that, you can use the -n option - but expect much worse results.)

[-] PROGRAM ABORT : No instrumentation detected
         Location : check_binary(), afl-fuzz.c:6959

Okay, I got this working.
One thing I'd like to know, is if we can make this slightly more ergonomic. Here is what my script looks like:
#!/usr/bin/env ruby

require 'socket'
require_relative '../../lib/protocol/http1'

def test
	sockets = Socket.pair(Socket::PF_UNIX, Socket::SOCK_STREAM)

	client = Protocol::HTTP1::Connection.new(sockets.first)
	server = Protocol::HTTP1::Connection.new(sockets.last)

	sockets.first.write($stdin.read)
	sockets.first.close

	begin
		host, method, path, version, headers, body = server.read_request

		body = server.read_request_body(method, headers)
	rescue Protocol::HTTP1::InvalidRequest
		# Ignore.
	end
end

if ENV["_"] =~ /afl/
	require 'kisaten'
	Kisaten.crash_at [Exception], [], Signal.list['USR1']

	while Kisaten.loop 1000
		test
	end
else
	test
end

First question: Is there a better check than ENV["_"] =~ /afl/?

Hi, I meet the same problem "No instrumentation detected" as you. Can I know how you solved it? Thanks very much.

The full working example is here: https://github.com/socketry/protocol-http1/blob/e6a9235102986a7a5462aea251f2fc9cdc00d65b/fuzz/request/bake.rb#L8

Thanks for your reply. I got this error solved!


[cluster-test] new invalid tx type for duplication

Added a new type of invalid tx to make a duplicate tx
Motivation
(Write your motivation for proposed changes here.)
Have you read the Contributing Guidelines on pull requests?
(Write your answer here.)
Test Plan
(Share your test plan here. If you changed code, please provide us with clear instructions for verifying that your changes work.)
Related PRs
(If this PR adds or changes functionality, please take some time to update the docs at https://github.com/diem/diem/tree/master/developers.diem.com, and link to your PR here.)

thx @bmwill for reviewing~!

/land


examples/http_mjpeg_streamer: fix to set correct frame size (#22)

This indeed fixes the bug. Tests seem to have flaked and should be re-kicked.


"cf dev start" shown front and center in README

The awesomeness of cf dev start can be promoted at the top of the page to precede its sample output.

Bump


Add callOnce param to Backbone.Events.on method

Event will be triggered only once.

Thanks for your submission!  Unfortunately this has already been discussed and declined as a feature.  Please see the previous issues concerning a once method.


Distance calculation is not accuate enough

L2 distance calculated in Knowhere is not the mathematics L2 distance.
So

whether it will impact the results of range search.
whether it will has gap with users' expectation

L2 distance formula is like this: (||x||^2 - 2*||x||||y|| + ||y||^2) ^ 1/2
In knowhere, in considering of efficiency, it only calculate: ||x||^2 - 2||x||*||y|| + ||y||^2 and sort the result in ascending order.
IP distance formula is like this: (||x||^2 - 2*||x||*||y|| + ||y||^2) ^ 1/2
IP's vector has been normalized, then ||x||^2 == 1 and ||y||^2 == 1.
So in knowhere, it only calculate ||x|| * ||y||, and sort the result in descending order.

/close


Support groupping

Hey guys, the library is really nice.
The only thing we're missing is to have something similar to this: https://adazzle.github.io/react-data-grid/#/grouping

Or something similar: https://handsontable.com/docs/row-parent-child/#preparing-the-data-source


build: docker setup for mode

pulled the docs changes out to https://github.com/latticexyz/mud/pull/1042, closing this in favor of #954


Accessibility of facet functions

There are 4 files:

www/assets/js/components/Facet.tsx
www/assets/js/components/FilterableFacet.tsx
www/assets/js/components/SearchFilter.tsx
www/assets/js/components/SearchFilterDrawer.tsx

If you search </i> in those files you will see there are many instances of i tags. Based on the code alone, it's difficult to say whether accessibility is handled or not.
So the better option would probably be finding those functionalities in the webpages and seeing how screen reader reacts to it and inspecting the code from there.

I've looked at the code and I don't see many semantic elements being used.
For the time being, I think we can add aria attributes to make the page more accessible. We can focus on interactive elements in particular. In the longer run, I believe this piece of code will require some significant refactoring to make it more semantic.
I've put up a draft PR that fixes the obvious problems with the interactive elements on the relevant pages.
@ibrahimjaved12 @pdpinch does this sound good for the scope of this ticket?

does this sound good for the scope of this ticket?

I agree making search fully accessible is a big undertaking. We had attempted it a year or two ago and had to set it aside.
If you can make a first pass to add the aria attributes, we can then have Rich and Mary, our expert consultants, review and give us advice on how to proceed.


ReactiveValueOperations#set result calls onComplete directly without offering Boolean value

The Mono<Boolean> set(K key, V value, Duration timeout) in ReactiveValueOperations  from Spring Data Redis Reactive implies the Mono will return an Boolean to indicate success or fail.
However when using Redisson's Spring Data Redis Integration, the response is either onComplete or onError. It's not revealed in documents that this method should not rely on the Boolean value. It would be easier to use the integration if documents offers these important information.

Besides, the Spring Boot Starter includes spring-boot-starter-web module which conflicts with newer spring-boots-starter-webflux module, which is necessary for Spring Webflux applications.
After exclude the spring-boot-starter-web module from Gradle, Redisson Starter works well. So, can the web module be removed from starter dependencies officially, or, change it to other dependencies?

I don't see error to false mapping in LettuceReactiveStringCommands implementation.

Moreover proposed code swallowing exceptions.

I use Redisson via redisson-spring-boot-starter in my Spring Boot project. The org.redisson.spring.data.connection.RedissonReactiveStringCommands#set is applied for calling ReactiveValueOperations#set.
Calling org.springframework.data.redis.core.ReactiveValueOperations#set(K, V, java.time.Duration)
will cause the problem. All works well if not setting the third parameter .
Test code:

@Autowired
public ReactiveStringRedisTemplate reactiveStringRedisTemplate;

private StepVerifier.FirstStep<Boolean> setWithExpiration() {
    return StepVerifier.create(reactiveStringRedisTemplate.opsForValue().set("test", "test", Duration.ofHours(1)));
}

private StepVerifier.FirstStep<Boolean> set() {
    return StepVerifier.create(reactiveStringRedisTemplate.opsForValue().set("test", "test"));
}

@Test
public void success() {
    set().expectNext(true).expectComplete().verify();
    setWithExpiration().expectComplete().verify();
}

@Test
public void fail() {
    // java.lang.AssertionError: expectation "expectNext(true)" failed (expected: onNext(true); actual: onComplete())
    setWithExpiration().expectNext(true).expectComplete().verify();
}

I traced the set with expiration method, it will run into:
https://github.com/redisson/redisson/blob/f7b3fbc64a422e625f974b23f1d5dfc73542ad1e/redisson-spring-data/redisson-spring-data-20/src/main/java/org/redisson/spring/data/connection/RedissonReactiveStringCommands.java#L91-L94

I noticed the command parameter of write is different.
RedisCommands.SET with VoidReplayConvertor:
https://github.com/redisson/redisson/blob/f7b3fbc64a422e625f974b23f1d5dfc73542ad1e/redisson-spring-data/redisson-spring-data-20/src/main/java/org/redisson/spring/data/connection/RedissonReactiveStringCommands.java#L91-L102
SET with BooleanReplayConvertor
https://github.com/redisson/redisson/blob/f7b3fbc64a422e625f974b23f1d5dfc73542ad1e/redisson-spring-data/redisson-spring-data-20/src/main/java/org/redisson/spring/data/connection/RedissonReactiveStringCommands.java#L90-L103

Merged


feat: truck type list endpoint

Endpoint can be hit by accessing
GET /api/truck_types
a successful response would be look like this


Purchase multiple products

Hi,
I want know if it is possible make multiple purchase and subscription in the same request purchase.
e.g: I have a P1 product priced at $300, a P2 product priced at $120 and a subscription priced at $10/month. Can I process the both product and a subscription in same requestPurchase or requestSubscription?
Thank's for your time.

Hi @patrickbattisti, unfortunately it isn't possible.


CommentEditor: Use shorthand for directive

In the CommentEditor.vue component we are using something like v-on:submit.prevent="onSubmit(slug, comment);". We should rather use the shorthand version with @.
Resources

https://vuejs.org/v2/style-guide/#Directive-shorthands-strongly-recommended

Please assign me to this...

#217

close this , because its was merged @igeligel


Align Vavr 1.0.0 with Scala 3.0 (?)

Since I saw comparisons to scala 2.13 on the vavr 1.0.0 branch I was wondering if it would already make sense to commit the next release of vavr to target scala 3.
currently the progress in dotty/scala3 revolves around advanced langauge features (implicit function types etc.) so the control and collection parts probably won't move that much in API. maybe we can get ppl working on that to weigh in.
afaik developer previews for scala 3.0 should be available in 2019 - not sure what the schedule for vavr is but if it makes any sense to use dotty/scala3 as reference it could be done now.

Yes, this makes sense. I think the scala3 collections hierarchy will be simplified. Ours will be simplified, too. I will have an eye on it.
I will close this issue because it is more a guideline than having formal acceptance criteria.


Python viewer (v 2.3.3)

Running multiple viewer (even with same model and data) results in a runtime error
from mujoco import viewer
    viewer.launch_passive(model, data)
    viewer.launch_passive(model, data)

> _MJPYTHON.launch_on_ui_thread(model, data)
> File "<string>", line 28, in launch_on_ui_thread
> RuntimeError: another MuJoCo viewer is already open

What should be the intended behavior here?

Get two viewers?
Just return back the original viewer?

Is it possible for the viewer launch call to return a handle of some kind?
handle = viewer.launch_passive(model, data)

Multiple viewers is currently not supported on macOS. Are you making a feature request? :)

A handle into the viewer is slated for next release. The proposed API is a context manager.
with viewer.launch_passive(m, d) as v:
  # run whatever code you want

That way you have explicit control over when the viewer window should close, however it does require that user code goes inside the context.
Does that sound good to you?

I'm not sure if this will be ideal.
For simple scripts this make sense to me. Usually viewer is a member of the task/env-class. These classes are constructed once and tossed around the RL agents for training and evaluations loops.

@vikashplus I'd strongly advise against putting the viewer inside a task or env class. Viewers should take a running env and visualise it. Environments themselves shouldn't own the visualiser...

I see your point. I can to see how we can refactor things.
Any recommendation on how to get the viewer-options so that we can configure things? The primary thing I want to be able to do is to control the position of the default camera, and toggle a few flags.


added no OPENAI key set support

PR Description: Resolve issue #86 by enhancing error handling for the OpenAI API key.
When the API key is not set, it now displays a clear message in the toast box indicating that no API key is set.
Additionally, if an invalid API key is provided, it shows an "Unauthorized" error message in the toast box, improving user feedback and error resolution.

Sorry for the delay, and thank you!!


Add prototype for Dance pipelines

This PR adds a prototype for Dance pipelines created by @jduimovich

/retest

/test build-definitions-pull-request

/retest

/test build-definitions-pull-request

/test build-definitions-pull-request

/test build-definitions-pull-request

/test build-definitions-pull-request

/test build-definitions-pull-request

/test build-definitions-pull-request


⚠ Samsung has degraded performance

In b26b201, Samsung (https://samsung.com) experienced degraded performance:

HTTP code: 200
Response time: 2483 ms

Resolved: Samsung performance has improved in 5343afc.


Updating collector's sampling config does not restart all collector pods

I have a Jaeger operator with 3 collector pods.  When the sampling config is updated only 2 of 3 the pods are restarted, leading to the clients getting the old remote sampling configuration.  As a test I also tried changing the minReplicas to 4 but there is still 1 pod that is not restarted.  It is the same pod as when there were 3 replicas, seems like maybe the oldest pod gets stuck.
Jaeger version: 17.0
Jaeger object:
apiVersion: jaegertracing.io/v1
kind: Jaeger
metadata:
  name: jaeger-production
  namespace: observability
spec:
  strategy: production
  sampling:
    options:
      default_strategy:
        param: 0.3
        type: probabilistic
      service_strategies:
      - param: 1
        service: test.test.delete.me
        type: probabilistic
  collector:
    autoscale: true
    minReplicas: 3
    maxReplicas: 8
    resources:
      requests:
        memory: "64Mi"
        cpu: "100m"
    options:
      collector:
        num-workers: 200
        queue-size: 4000
  ingress:
    enabled: false
  storage:
    type: elasticsearch
    options:
      es:
        server-urls: "?????"
        num-shards: 5
        num-replicas: 0
        version: 7
    esIndexCleaner:
      enabled: true
      numberOfDays: 3
      schedule: "0 0 * * *"

Example kubectl get pods output:
jaeger-production-collector-86cc94b4d5-4gtt8           1/1     Running     0          8h
jaeger-production-collector-86cc94b4d5-mr7pq           1/1     Running     0          11m
jaeger-production-collector-86cc94b4d5-qw7fg           1/1     Running     0          11m

When something is changed in the deployment spec (e.g. the --es.server-urls argument) we do see all pods restart.  So this seems just to be limited to the operator itself, I'm guessing the operator is restarting the pods when kubernetes wouldn't restart it itself (e.g. configmap changes)?

This is related to https://github.com/jaegertracing/jaeger/pull/2040. Jaeger will be watching the sampling file and reload if it is changed.

@linjmeyer can this be closed? Is the PR that @pavolloffay linked above sufficient for your use case?

Yep looks good thanks


generate code to parse the keyword args using interpreter-style keyword argument passing

Motivation

Stop allocating a hash table for every method call with keyword args.
This will need to be split up into a separate sorbet/ruby PR.  I'll then update this PR with the result of pulling in that single squashed merge commit and try to write up a proper description.  But I wanted to get something up for potential benchmarking.
Test plan

See included automated tests.

We have a policy of testing changes to Sorbet against Stripe's codebase before
merging them. I've kicked off a test run for the current PR.  When the build
finishes, I'll share with you whether or how it failed. Thanks!
Stripe employees can see the build results here:
→ https://go/builds/bui_KNAzS2kwIX0OM3
→ https://go/builds/bui_KNAzxhsfoY3TQ7

We have a policy of testing changes to Sorbet against Stripe's codebase before
merging them. I've kicked off a test run for the current PR.  When the build
finishes, I'll share with you whether or how it failed. Thanks!
Stripe employees can see the build results here:
→ https://go/builds/bui_KNB8DN7VvulWEh
→ https://go/builds/bui_KNB8vgvtBwZdbs

We have a policy of testing changes to Sorbet against Stripe's codebase before
merging them. I've kicked off a test run for the current PR.  When the build
finishes, I'll share with you whether or how it failed. Thanks!
Stripe employees can see the build results here:
→ https://go/builds/bui_KOX7dacFNORuUn
→ https://go/builds/bui_KOX7o40QH6bhNK

We have a policy of testing changes to Sorbet against Stripe's codebase before
merging them. I've kicked off a test run for the current PR.  When the build
finishes, I'll share with you whether or how it failed. Thanks!
Stripe employees can see the build results here:
→ https://go/builds/bui_KPJwcBpm62C92r
→ https://go/builds/bui_KPJwrxAfY1na7t


Update package.json

Not sure if I'm doing this right, but the idea was to try the latest version of bootstrap to remove the local file dependency that Isaac mentioned was currently in the package.json file.

Got the fork/PR process down, but need to get the code change working.

Great.  You’ll actually need 1.0.0-alpha.16, not 1.0.0.

On Jan 6, 2017, at 12:00 PM, David Quinn-Jacobs<EMAIL_ADDRESS>wrote:
Got the fork/PR process down, but need to get the code change working.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.


Shift from prototype/placeholder functionality to a usable setup

Somewhere in between a feature request and a bug: the current setup is difficult to use, with four different functions for four different use cases that are not even consistent with each other (the integer intervals can only have integer values and the float intervals only float values, but this link is not necessary).
As a next step in this project, some rewriting to make the core functionality more accessible would be beneficial. My current thinking is:

Create a BaseInterval struct like in the Python version of intervalues (with a lowerbound, upperbound and value)
Implement as_interval for common expected inputs (basically, all integer and float options for the bounds and the value).
Let combine_intervals take these BaseIntervals as input

Alternative proposals are welcome - especially with a motivation since that can help me understand better how to tackle this best in Rust.

For now, the input is number_general::Number as a placeholder for a final generic implementation. (Which might be Number, rust_decimal::Decimal, my own wrapper, or perhaps going back to individual implementations. Also a Rust-language feature that is not yet intuitive to me might be a good solution, which I will look into.
But the combine_intervals function in principle is now a generic one that would work will inputs (after they are converted to Number).


some variables and keywords rendered verbatim instead of interpolated

Description
Some variables/keywords like \orgaddress, \country, \fnm and \sur are shown verbatim on https://arxiv.org/html/2310.03560v3
(Optional:) Please add any files, screenshots, or other information here.

(Required) What is this issue most closely related to? Select one.
Other
Internal issue ID
b497da6a-d23f-46df-b887-b1d109bdd024
Paper URL
https://arxiv.org/html/2310.03560v3
Browser
Chrome/<IP_ADDRESS>
Device Type
Desktop

I have nothing much to add other than to note that this same particular issue strikes a recent paper of mine: https://arxiv.org/html/2405.06397v3


[Bug] Need y-axis information in params for tooltip formatter

Version
5.4.2
Link to Minimal Reproduction
https://echarts.apache.org/examples/en/editor.html?c=line-smooth&code=DYUwLgBADgTiUgHYBMBiB7GBbAhmAymDAJaIDmAzhALwQDeAUBBAAwBcEARACScA0TCAEYOnQDUEnBgF8GDdFDDF0iGvUEAPAILriFDo2bMwATwQcA5AGM8IMpmPmBhiMjw4OAbXMBZZY4jmACoAriD-5gDqIMjhgQAWweGoJOH4eKnBiOYAuoJSThBg6OjAilD6gkYkZGQgMBY4OhSOlRAAZpi4YGB1HG2ZlorKABRQODA4WBQAlAbOhqCQ6MFgUCuqnJwA3K3OixDGAGo4wDvzEACQHTAQw_vEqmMTUwB0oORgcRAAtMJbEA8AHy0Fj_Yjfb7TNQXGEwo4nR7jSYUDzEbIvABuJ1CHiE2R2sJhy1W62oDEJRJWa0gAGpyRTzAAeABGMAA9IDzBA6RSLk9kaj0RQ6sQQBQAHKTEDcriiGX8qaCzHYkAvIoAGXQ1lAhBI5GG03pMJk5zgYGCMBUxOprRNEHygmM2l0njmRlMIAsWOAoRaMMaunVOGZIGAFVhFDi6AA7hwiKEBLC4sRkCAAPIYurAHDlQowBNGyMx7yNIMhsN5guw65dHr1doDIYqYbe0JQxiEs0WlTmbhcmkQVuqjVak4gXWkMgGo0O2G4GBkUgcAAs9IdzHXamcJjMASHLWcJ2IZEQgWIlgA1npKyACswAxQy6HwzCi7Gb4mYcnUxmszm4_mt6FlG0YluoT4VvGQHVp0eB1n0jZKM2Q7tkaFxdpaXASDKQ5qugmrauORCTtOsKzjC86LogK5rgUdrZAUwokGKnitG6hiuGA7gQB4AAcABMLB8BAACcADM_HCSJLBCFJYnLsJQj8dJiliWJQnCBJLAMbshQehYwCkGEd6GBQWDFJ8AEFuciBShYiCYJ8EBSiQ1gQBQY7NLaJnMOxzCcdxuICRpQjiZJwjSbJEXyYpIkqdFIUAOyCTp5w7p6ASGYgxm6U6TQAJIoCA6hsLJum2VgGXmCAFryNKHmgF5zj0dIWxAA
Steps to Reproduce

Create a chart with 2 y axes, each with a different number format
Create a tooltip with trigger: 'axis'
Attempt to format each number in the tooltip in the same way as each number's corresponding axis

Current Behavior
I can access information about the data using params, but this does not include the yAxisIndex. Without yAxisIndex, I am not able to determine which format to apply to the numbers in the tooltip.
Expected Behavior
params should include at least yAxisIndex since it is a property of the series which is being summarized in the params.
Even though with trigger: 'axis', you don't know which series is currently active (i.e. they are all active at once), this information can still be contained in params since it can be used to execute iterative logic over the information within params.
Alternatively, if there is a way to pass arbitrary information which will appear in params, that would solve my problem (e.g., if I could pass a custom column into the series config and retrieve it in the tooltip formatter function through params).
Environment
N/A

Any additional comments?
The reason I need to figure this out with trigger: 'axis' is that tooltips are not really usable with trigger: 'item'. Ideally, I could use trigger item to get tooltips displayed for individual series in a chart, but the target hover area is unreasonably small since it relies on symbols, and I typically leave symbols out of my charts for cleanliness of appearance. The only way around this seems to be a custom setup using events, which I would prefer not to do.

Series data determines the format. I don't see the need for yAxisIndex.
"north america" :fast_forward: params[i].seriesIndex==0 :fast_forward: format $
"europe"            :fast_forward: params[i].seriesIndex==1 :fast_forward: format €
NB: please close issue if problem solved.

Sorry, my example doesn’t do a great job of showing the problem. The reason I can’t use the series to determine the format is I’m building a library on top of echarts, so I need to create a generalized formatter function that can be used in any situation. For the axis labels, I have access to the series information before generating the chart, so I can supply the formatting that the user sets for each column.
Unfortunately, for tooltips I can’t access that same information because it’s triggered from the client.
I might be able to use the series name to look up what the correct format is, but there is one other issue with that: we show our series names as formatted versions of column names (e.g., sales_usd —-> Sales ($) ). Ideally, I would look up the format using the series column name (sales_usd), but the only information I have access to in params is the formatted name. I haven’t been able to figure out how to set a separate series name and ID in a way that will be accessible in the tooltip formatter.
For reference, here is the feature I am looking to implement where this is an issue:
https://github.com/evidence-dev/evidence/issues/412

we show our series names as formatted versions of column names (e.g., sales_usd —-> Sales ($) ).

If the seriesName is already used, why not set the column name (sales_usd) as seriesId ? Then the formatting info will be available for tooltip.

That almost works, but there are cases where we use the same column name for multiple series, which causes an error if inputted into the seriesId field.
For example, here's a typical dataset a user would pass into one of our chart components:
data = [
   {year: 2010, country: "US", sales_usd: 100, orders_num: 50},
   {year: 2011, country: "US", sales_usd: 100, orders_num: 50},
   {year: 2010, country: "UK", sales_usd: 100, orders_num: 50},
   {year: 2011, country: "UK", sales_usd: 100, orders_num: 50},
   {year: 2010, country: "China", sales_usd: 100, orders_num: 50},
   {year: 2011, country: "China", sales_usd: 100, orders_num: 50}
]

The user would supply these columns using these options in our API:
x=year
y=sales_usd
y2=orders_num
series=country

And then we map them to individual series names that will look like this:

"US - Sales ($)"
"US - Orders"
"UK - Sales ($)"
"UK - Orders"
"China - Sales ($)"
"China - Orders"

So in the example of a line chart, this would generate 6 lines/series, without an easy way to get back to the column id through params in the tooltip.
Worst case, I could parse the seriesName to reverse engineer which column it came from (or check if the formatted column name is within the seriesName), but that feels like an error-prone solution.

there are cases where we use the same column name for multiple series, which causes an error if inputted into the seriesId field

Is there a problem to prefix the column name with a counter value ('99sales_usd') or another column ('UKsales_usd') to make it unique ? For tooltip formatting just the "_usd" part of seriesId will be needed anyway.

@helgasoft I'm looking at this again after this feature got deprioritized behind some other things. Thanks for getting back to me.
Prefixing the column seems like a complicated solution and would interfere with our column formatting logic (we take the column name and present it as a nicely formatted title in the chart).
I tried another solution which almost worked, which I'll describe below:

I created a variable to count the number of series on the y axis vs. on the secondary y axis
I used componentIndex within params to see which axis each series should be on (e.g., if componentIndex < ySeriesCount then it's on the first axis, otherwise on the second)
This works in the basic case
This doesn't work in the case I mentioned above with US/UK/China and Sales/Orders. Here is how the componentIndex was set for those:

"US - Sales ($)" componentIndex: 0
"US - Orders" componentIndex: 1
"UK - Sales ($)" componentIndex: 2
"UK - Orders" componentIndex: 3
"China - Sales ($)" componentIndex: 4
"China - Orders" componentIndex: 5

This gave me $ formatting on 0, 1, and 2 and # formatting on the other 3

This would all be much easier if I knew yAxisIndex in params!

I may have found an approach that works - I've created a function that will take the componentIndex plus the count of variables on the first and second y axes, and will return which axis the datapoint should be on. This will work if the order of the series is always y first, then secondary y. In my example above, here's what it will return:

"US - Sales ($)" componentIndex: 0 = y
"US - Orders" componentIndex: 1 = y2
"UK - Sales ($)" componentIndex: 2 = y
"UK - Orders" componentIndex: 3 = y2
"China - Sales ($)" componentIndex: 4 = y
"China - Orders" componentIndex: 5 = y2


New output mode

Issues
Description
Implemented new output mode based on feedback from @quadbyte and @XScorpion2 .
I got rid of the functionality to adjust the volume of different devices independently since it was over complicating the user experience in the device for a use case that may not be very common or even existent.
The new version brings back the simplified master volume edit screen and adds device switching to it.
Tapping once takes you to device selection mode, tapping once will switch to that output device and take you back to the volume edit screen.
Types of changes
Put an x in the boxes that apply

[ ] Bugfix (non-breaking change which fixes an issue)
[X] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Documentation Update (if none of the other choices apply)

Checklist
Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

[X] Requested changes are in a branch
[X] Compiled and tested requested changes on target hardware (PC, device)
[X] Updated the documentation, if necessary
[X] Updated the LICENSES file, if necessary
[X] Reviewed the guidelines for contributing to this repository

Further comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

I'm missing the method to call to do the actual switching of the default endpoint. I have tried to find what @XScorpion2 mentioned but couldn't find it anywhere. Help in that front would be supper appreciated.
Everything else should be working and ready for review.

Reviewed and tested, looking good to me. Just need to actually change output.


Create Shreya Dash

You are supposed to make your folder inside the Task folder, do the needful and then create a PR, take reference form the other folders.

Ok, will do that, Didi.
On Fri, May 17, 2024, 2:38 PM Shreeti Mohapatra @.***>
wrote:

You are supposed to make your folder inside the Task folder, do the
needful and then create a PR, take reference form the other folders.
—
Reply to this email directly, view it on GitHub
https://github.com/shivah12/RS-Python-Task/pull/7#issuecomment-2117095627,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/BIRBYSC6FOOTR7I7F5T6DRTZCXCI5AVCNFSM6AAAAABH3QTVTSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMJXGA4TKNRSG4
.
You are receiving this because you authored the thread.Message ID:
@.***>


Left clicking on an model's tag Removes the tag

Left clicking on a model's tag removes the tag with no warning or prompt.  This makes accidental removal of the tags very easy.
A prefered behavior would be to right click and select delete while left clicking puts that tag in the search bar.

That might be another one of those where an application setting for the behavior would be nice.
I found the straigh up click super efficent for editing tags, but yes - different folks, different workflows, different expectations.
Will consider adding this as an option.
The right click menu is a good suggestion as well. Thanks!