YARN-11381. Fix hadoop-yarn-common module Java Doc Errors.

JIRA: YARN-11381. Fix hadoop-yarn-common module Java Doc Errors.
The java doc problem has been fixed once, but during the PR compilation process of YARN-11373, the Java Doc error appeared again.
We can view the report as follows:
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5146/6/artifact/out/patch-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common-jdkUbuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04.txt
I follow the compilation prompts and fix the package-info.java of the module.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 56s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+0 :ok:
detsecrets
0m  1s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

-1 :x:
test4tests
0m  0s

The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
39m 26s

trunk passed

+1 :green_heart:
compile
1m  3s

trunk passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
compile
0m 52s

trunk passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

+1 :green_heart:
checkstyle
0m 52s

trunk passed

+1 :green_heart:
mvnsite
0m 55s

trunk passed

+1 :green_heart:
javadoc
1m 11s

trunk passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
0m 51s

trunk passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
1m 55s

trunk passed

+1 :green_heart:
shadedclient
21m 26s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 42s

the patch passed

+1 :green_heart:
compile
0m 49s

the patch passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javac
0m 49s

the patch passed

+1 :green_heart:
compile
0m 40s

the patch passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

+1 :green_heart:
javac
0m 40s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
0m 28s

hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common: The patch generated 0 new + 0 unchanged - 23 fixed = 0 total (was 23)

+1 :green_heart:
mvnsite
0m 42s

the patch passed

+1 :green_heart:
javadoc
0m 42s

the patch passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
0m 40s

the patch passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
1m 47s

the patch passed

+1 :green_heart:
shadedclient
21m 20s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
5m 40s

hadoop-yarn-common in the patch passed.

+1 :green_heart:
asflicense
0m 50s

The patch does not generate ASF License warnings.

104m 11s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5179/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/5179

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux 470b8074b435 4.15.0-191-generic #202-Ubuntu SMP Thu Aug 4 01:49:29 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 71da4cd1aeef8352056871c28358a1c751914456

Default Java
Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5179/1/testReport/

Max. process+thread count
556 (vs. ulimit of 5500)

modules
C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5179/1/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

@ayushtkn Can you help review this PR? Thank you very much! We still have some package-info.java files to fix, in this pr, I fixed them.

@goiri Thank you very much for helping to review the code!


[REQUEST] 1.16.5 Forge port, reasons below

Recently my Crucial 2 server got hit by some nasty trolls, and we suspect some of them were x-raying. However, this mod does not exist for 1.16.5, which is what Crucial 2 is on. Could this be ported to such a version? If not, can you show me a similar mod to this on 1.16.5?

Someone already asked this on curseforge

I currently don't have the time nor the motivation to backport this mod to 1.16.5.
It also seems that mixins (which are used by this mod) have been added to fabric in 1.17, so they aren't even avaible for the requested version.

I am sadly not aware of any similar mods.

Drex


Cannot import Secrets and Services YAML into non-default namespace

What kind of request is this (question/bug/enhancement/feature request):
Bug
Steps to reproduce (least amount of steps as possible):
Bring up a Rancher v2.5-head setup.
Create a standard user.
As a standard user, create a downstream cluster.
In the cluster, create a new namespace.
Navigate to dashboard.
Import secret YAML into the new namespace.
Import service YAML into the new namespace.
I used the following YAML to import a secret:
apiVersion: v1
data:
  key: dmFsdWU=
kind: Secret
metadata:
  managedFields:
  - apiVersion: v1
    fieldsType: FieldsV1
    fieldsV1:
      f:data:
        .: {}
        f:key: {}
      f:type: {}
    manager: rancher
    operation: Update
  name: test3
  namespace: default
type: Opaque

I used the following YAML to create a service:
apiVersion: v1
kind: Service
metadata:
  name: testservice
  namespace: default
spec:
  clusterIP: <IP_ADDRESS>
  ports:
  - port: 8080
    protocol: TCP
    targetPort: 80
  sessionAffinity: None
  type: ClusterIP
status:
  loadBalancer: {}

Result:
The secret or service is set in the default namespace:

Other details that may be helpful:
Request:
{"yaml":"apiVersion: v1\ndata:\n  key: dmFsdWU=\nkind: Secret\nmetadata:\n  managedFields:\n  - apiVersion: v1\n    fieldsType: FieldsV1\n    fieldsV1:\n      f:data:\n        .: {}\n        f:key: {}\n      f:type: {}\n    manager: rancher\n    operation: Update\n  name: test3\n  namespace: default\ntype: Opaque\n","defaultNamespace":"testnamespace"}

Response:
            "name":"test3",
            "namespace":"default",
            "relationships":null,
            "resourceVersion":"19683",
            "state":{
               "error":false,
               "message":"Resource is always ready",
               "name":"active",
               "transitioning":false
            },
            "uid":"eec1d09e-e100-48a1-b1b0-e9fa6af7cdfa"

Environment information

Rancher version (rancher/rancher/rancher/server image tag or shown bottom left in the UI): v2.5-head version 2f2cfe6
Installation option (single install/HA): Single install

You're importing YAML that has explicit namespaces defined, so that's where the resources go.
kind: Secret
metadata:
  name: test3
  namespace: default

kind: Service
metadata:
  name: testservice
  namespace: default

What namespace(s) you are looking at has no impact on where things are imported.  They either go where the YAML says, or they go into the default ns chosen from the dropdown in the modal.

@vincent99 You're absolutely right. Closing issue.


Teslamate does not start anymore: canceling statement due to user request

Is there an existing issue for this?

[X] I have searched the existing issues

What happened?
I rebooted the machine with sudo reboot after normal system upgrades. I suspect the database may not have finished writing cleanly.
Now teslamate wont start due to below error log. Grafana still works on the database.
Expected Behavior
I would have hoped it would survive a planned reboot - and it did so many times - even power outages without corrupting data. Maybe this is just a very unlucky coincidence albeit there was another issue quite similar to mine https://github.com/adriankumpf/teslamate/issues/2442
I would also be okay to just delete the data for that day if that would help.
Steps To Reproduce
No response
Relevant log output
docker-compose logs
Attaching to teslamate_teslamate_1, teslamate_grafana_1, teslamate_database_1
database_1   |
database_1   | PostgreSQL Database directory appears to contain a database; Skipping initialization
database_1   |
database_1   | 2023-06-09 08:53:35.721 UTC [1] LOG:  starting PostgreSQL 12.15 (Debian 12.15-1.pgdg110+1) on x86_64-pc-linux-gnu, compiled by gcc (Debian 10.2.1-6) 10.2.1 20210110, 64-bit
database_1   | 2023-06-09 08:53:35.721 UTC [1] LOG:  listening on IPv4 address "<IP_ADDRESS>", port 5432
database_1   | 2023-06-09 08:53:35.721 UTC [1] LOG:  listening on IPv6 address "::", port 5432
database_1   | 2023-06-09 08:53:35.725 UTC [1] LOG:  listening on Unix socket "/var/run/postgresql/.s.PGSQL.5432"
database_1   | 2023-06-09 08:53:35.738 UTC [27] LOG:  database system was shut down at 2023-06-06 20:04:52 UTC
database_1   | 2023-06-09 08:53:35.744 UTC [1] LOG:  database system is ready to accept connections
database_1   | 2023-06-09 08:53:57.486 UTC [36] ERROR:  canceling statement due to user request
database_1   | 2023-06-09 08:53:57.486 UTC [36] STATEMENT:  WITH last_position AS (
database_1   | 		SELECT date, convert_celsius(outside_temp, 'C') AS "Outside Temperature [°C]"
database_1   | 		FROM positions
database_1   | 		WHERE car_id = '1' AND outside_temp IS NOT NULL AND date AT TIME ZONE 'Etc/UTC' >= (NOW() - interval '60m')
database_1   | 		ORDER BY date DESC
database_1   | 		LIMIT 1
database_1   | 	),
database_1   | 	last_charge AS (
database_1   | 		SELECT date, convert_celsius(outside_temp, 'C') AS "Outside Temperature [°C]"
database_1   | 		FROM charges
database_1   | 		JOIN charging_processes ON charges.charging_process_id = charging_processes.id
database_1   | 		WHERE car_id = '1' AND outside_temp IS NOT NULL AND date AT TIME ZONE 'Etc/UTC' >= (NOW() - interval '60m')
database_1   | 		ORDER BY date DESC
database_1   | 		LIMIT 1
database_1   | 	)
database_1   | 	SELECT * FROM last_position
database_1   | 	UNION ALL
database_1   | 	SELECT * FROM last_charge
database_1   | 	ORDER BY date DESC
database_1   | 	LIMIT 1;
database_1   | 2023-06-09 08:53:57.486 UTC [39] ERROR:  canceling statement due to user request
database_1   | 2023-06-09 08:53:57.486 UTC [39] STATEMENT:  SELECT
database_1   | 	  date,
database_1   | 	  convert_celsius(inside_temp, 'C') AS "Inside Temperature [°C]"
database_1   | 	FROM positions
database_1   | 	WHERE
database_1   | 	  car_id = '1'
database_1   | 	  and inside_temp is not null AND date AT TIME ZONE 'Etc/UTC' >= (NOW() - interval '60m')
database_1   | 	order by date desc
database_1   | 	limit 1
database_1   | 2023-06-09 08:53:57.486 UTC [35] ERROR:  canceling statement due to user request
database_1   | 2023-06-09 08:53:57.486 UTC [35] STATEMENT:  SELECT
database_1   | 		date AS "time",
database_1   | 		convert_celsius(driver_temp_setting, 'C') as "Driver Temperature [°C]"
database_1   | 	FROM positions
database_1   | 	WHERE driver_temp_setting IS NOT NULL AND car_id = '1' AND date AT TIME ZONE 'Etc/UTC' >= (NOW() - interval '60m')
database_1   | 	ORDER BY date DESC
database_1   | 	LIMIT 1;

Screenshots
No response
Additional data
No response
Type of installation
Docker
Version
latest

I've had the same problem. I also had a problem with my MQTT connection in teslamate. When i fixed that this error message disappeared. Maybe that helps.

And it just works again without any changes whatsoever


[AIRFLOW-2532] Support logs_volume_subpath for KubernetesExecutor

JIRA

[x] My PR addresses the following Airflow JIRA issues and references them in the PR title.

https://issues.apache.org/jira/browse/AIRFLOW-2532

Description

[x] Here are some details about my PR:
The kubernetes section in the configuration file supports
logs_volume_subpath for KubernetesExecutor.

Tests

[x] My PR adds the following unit tests OR does not need testing for this extremely good reason:
Just add a parameter, no need for tests.

Commits

[x] My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":

Subject is separated from body by a blank line
Subject is limited to 50 characters
Subject does not end with a period
Subject uses the imperative mood ("add", not "adding")
Body wraps at 72 characters
Body explains "what" and "why", not "how"

Documentation

[x] In case of new functionality, my PR adds documentation that describes how to use it.

When adding new operators/hooks/sensors, the autoclass documentation generation needs to be added.

Codecov Report

Merging #3430 into master will increase coverage by <.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #3430      +/-   ##
==========================================
+ Coverage   76.57%   76.58%   +<.01%
==========================================
  Files         203      203
  Lines       15028    15028
==========================================
+ Hits        11508    11509       +1
+ Misses       3520     3519       -1

Impacted Files
Coverage Δ

airflow/models.py
87.35% <0%> (+0.04%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 11e670d...0203d7c. Read the comment docs.

@Fokko  PTAL. The kubernetes section in the configuration file supports the dags_volume_subpath parameter, but logs_volume_subpath does not support. If both are supported, the dags and the logs volume can use the same pvc, sharing the same backend storage that support mounted by multiple pod (e.g. NFS), only different subpaths. So, I added logs_volume_subpath  parameter support.


ADD cheetsheet: Data Wrangling with pandas

What does this PR do?
Add resource(s)
For resources
Description
Add official Data Wrangling with pandas cheetsheet https://pandas.pydata.org
Why is this valuable (or not)?
It is useful in Data Science with this Python library to resume all important things at a glance.
How do we know it's really free?
Source: https://pandas.pydata.org/Pandas_Cheat_Sheet.pdf
Scrapped from: https://pandas.pydata.org/getting_started.html
For book lists, is it a book? For course lists, is it a course? etc.
It's a cheetsheet
Checklist:

[x] Read our contributing guidelines
[x] Search for duplicates.
[x] Include author(s) and platform where appropriate.
[x] Put lists in alphabetical order, correct spacing.
[x] Add needed indications (PDF, access notes, under construction)

Followup

Check the output of Travis-CI for linter errors!

Wish I had this when I was doing a thing with pandas!


npc.tensordot drops labels when using axes=0

While playing around I ran into some unexpected (for me at least) behavior for npc.tensordot() when called with the axes=0 option - from what I understand it should be the same as npc.outer(), but somehow when doing it eg. with two simple vectors, the axes labels of the first get lost along the way, so for example:
import tenpy.linalg.np_conserved as npc

v1 = npc.Array.from_ndarray_trivial([1,2,3],labels=['one'])
v2 = npc.Array.from_ndarray_trivial([2,3,4],labels=['two'])

tdot = npc.tensordot(v1,v2,axes=0)

tdot

will give
<npc.Array shape=(3, 3) labels=['two']>

I had a quick look and a possible fix might be as simple as pulling the elif axes=0 check up in the tensordot function, so that outer() gets called before other possible messups occur inbetween, something along the lines of https://github.com/tenpy/tenpy/commit/af86845bb3cea9f06ba050a5f9cdb5437874c068
For some simple cases it seems to be working fine, I didn't check whether this breaks anything else though.

Thanks for pointing it out!
The case above the axes=0 is an optimization, but it indeed didn't handle the labels correctly.
The issue was in the end of the tensordot function, that labels[:-axes] returned an empty list rather than the whole one...
Tricky indexing error with pythons negative-index convention.
I've already pushed the (one-line) fix, will merge it as soon as the tests pass


Get homophones?

Hi, is there a function similar to the rhyming function but for homophones?

Never mind! Sorry for the bother. I wrote this function:
import eng_to_ipa as ipa
def get_homophones(word):
    words_that_sound_the_same = []
    ipa_of_word = ipa.convert(word)
    wordsthatcontainthatsound = ipa.contains(ipa_of_word)
    for every_word in wordsthatcontainthatsound:
        thewaythatwordsounds = every_word[1]

        if ipa_of_word == thewaythatwordsounds:
            if every_word[0] != word:
                words_that_sound_the_same.append(every_word)

    return words_that_sound_the_same

get_homophones('their') #[['there', 'ðɛr'], ["they're", 'ðɛr']]

Just reopening to ask for any tips on this problem: I'm trying to create a function that'll basically give you a homophone that is made up of multiple words.
For instance, given the words:
"breakthrough"
It chunks that into:
[['b', 'reɪkθru'],
 ['b', 'r', 'eɪkθru'],
 ['br', 'e', 'ɪkθru'],
 ['bre', 'ɪ', 'kθru'],
 ['breɪ', 'k', 'θru'],
 ['breɪk', 'θ', 'ru'],
 ['breɪkθ', 'r', 'u'],
 ['breɪkθr', 'u']]

(This is a function I already wrote that does this.)
Then, it takes each segment, for example, br and checks for words that have exactly that sound (and no other sound) (which I can use my homophone function above to do it with).
The problem comes in dividing these arrays up into all possible ways a word could be broken up. For instance, my poor function can only do this for one character at a time but ideally you'd have something that would do it for multiple characters depending on the length of the word's ipa characters. For instance, for breakthrough, that would be 8 characters (ignoring the stress for now since I'm not sure how to deal with that). So the algorithm would then divide breakthrough up like so:
1, 7:
['b', 'reɪkθru']
['breɪkθr', 'u']
2, 6:
['br', 'eɪkθru']
['breɪkθ', 'ru']

3, 5:
['bre', 'ɪkθru']

4, 4:
['breɪ', 'kθru']

5, 3:
['breɪk', 'θru']

and so on...
But I'm posting this mostly to get any suggestions on how to go about this.
What I want to end up with is a function that I can call and get something like this:
multi_homophone('breakthrough')
[['break', 'breɪk'], ['through', 'θru']],
... (other options of combinations)

Take a look at https://github.com/Kyubyong/g2p . Basically, they tag the whole sentence and then use the fact of whether or not the word is a verb to determine which homophone to use. For others, like "bowing" and "bowing", you'd have to use context clues. That'd probably necessitate a machine learning model.


why i can't find the difference

This is my test, I find both of them take almostly the same time

I think I find it


lateral limits: remove Subaru exception

The factor looks wrong, it's 1.4 m/s^2 on our Subaru, but need to manually check the max measured value first.
Regardless, reaching max torque in 1000/40 * (2 / 100)=0.5s seems a little egregious and is the fastest of any OP car (Toyota is 1s, Hyundai CAN is 1.28s, Hyundai CAN FD is 1.35s).

Not changing the tuning in this PR as it is better to overshoot the actual accel factor rather than undershoot, and @nuwandavek will enable torqued learning in a follow up PR.


Missing Log entries & Empty results are schown as "OK"

There seems to be a problem with uncaught exceptions. NUnit collects them all and reports them in their result.xml, but they are not found in the WebApp.
Here is an example for such an exception taken from the NUnit result xml:
OpenQA.Selenium.NoSuchWindowException : Window not found. The browser window may have been closed.
<![CDATA[
Server stack trace:
at System.Threading.Thread.InternalCrossContextCallback(Context ctx, IntPtr ctxID, Int32 appDomainID, InternalCrossContextDelegate ftnToCall, Object[] args)
at System.Runtime.Remoting.Channels.CrossContextChannel.SyncProcessMessage(IMessage reqMsg)
Exception rethrown at [0]:
at System.Runtime.Remoting.Proxies.RealProxy.HandleReturnMessage(IMessage reqMsg, IMessage retMsg)
at System.Runtime.Remoting.Proxies.RealProxy.PrivateInvoke(MessageData& msgData, Int32 type)
at .When
at lambda_method(Closure , IContextManager , String )
at TechTalk.SpecFlow.Bindings.BindingInvoker.InvokeBinding(IBinding binding, IContextManager contextManager, Object[] arguments, ITestTracer testTracer, TimeSpan& duration)
at TechTalk.SpecFlow.Infrastructure.TestExecutionEngine.ExecuteStepMatch(BindingMatch match, Object[] arguments)
at TechTalk.SpecFlow.Infrastructure.TestExecutionEngine.ExecuteStep(StepInstance stepInstance)
at TechTalk.SpecFlow.Infrastructure.TestExecutionEngine.Step(StepDefinitionKeyword stepDefinitionKeyword, String keyword, String text, String multilineTextArg, Table tableArg)
at TechTalk.SpecFlow.TestRunner.When(String text, String multilineTextArg, Table tableArg, String keyword)
at () in .feature:line <>
]]>
As a sidenode: The GlueCode and the selenium related code are in an external library.
In the WebApp the scenario result is 'OK' and when you open it, there are no Results in there.
Incase it is not possible to actually catch this exception (there are other examples as well) and write it to the result, the WebApp should definately default to:
"When a scenario doesnt contain any steps, the scenario result should definately NOT be 'OK' but 'Error'"
The following result data (generated as a result of the unlogged exception above) leads to such a dangerous behavior:
{
"given": {
"result": "OK",
"steps": [],
"start_time": "0001-01-01T00:00:00",
"end_time": "0001-01-01T00:00:00"
},
"when": {
"result": "OK",
"steps": [],
"start_time": "2014-12-08T18:55:21.0951765+01:00",
"end_time": "2014-12-08T18:55:22.7046705+01:00"
},
"then": {
"result": "OK",
"steps": [],
"start_time": "2014-12-08T18:55:22.7046705+01:00",
"end_time": "2014-12-08T18:55:23.0354289+01:00"
},
"result": "OK",
"tags": [],
"title": "my scenario title",
"start_time": "2014-12-08T18:55:21.0951765+01:00",
"end_time": "2014-12-08T18:55:23.0354289+01:00"
},
Maybe even a step without a title should be automatically marked as 'Error'
thanks alot for your support - feel free to contact me back

I get the same issue - bit of a  showstopper


run application as non-root user in docker container

This models the Dockerfile after the advice given here https://github.com/hexops/dockerfile which seems to make a lot of sense.
Trouble with this approach is that it will require manual interaction by users that upgrade, so we might need to wait for a proper point in time to sneak this in.

Changing file ownership in the container would work like this:
docker exec -u 0 <container_ref> chown offen:offen /var/opt/offen/offen.db

A possible migration strategy for moving here might be:

Starting with v0.4.0 we make the non-root Docker image the default, providing instructions on how to migrate. This should only affect deployments that use the Docker / SQLite combo.
For the entire v0.4.x series we also provide a v0.4.x-root tag on Docker Hub that still uses the Docker Image running as root. This leaves users with a little more time to migrate while still keeping the installs up to date.
Starting with v0.5.0 the image running as root is dropped. Anyone who wants to upgrade will need to run the upgrade steps against their setups.


Ability to serve multiple wikis

Can you consider allowing multiple wikis to be served? I have some projects hosted locally, and each needs a separate wiki. It's rather tedious to start a new instance for each wiki when switching between projects. I imagine this could be done with some sort of "central" page with a list of wikis, and the wikis themselves being served on subdirectories. IMO this is a major shortcoming of gollum.

Interesting feature. I am not sure how to make it work so to accomodate most use cases, though. You could have different wiki as different repos in different directories or different wikis on the same repo but in different directories. Maybe jingo could start in "multi-wiki" mode, so that in the configuration you could provide an array of repositories. But they would need to share the authentication and a lot of other things, anyway (or it would be really to complicated).
Something like:
wikis:
   - Cats
      repository: xxxx
   - Dogs
      repository: yyyy
   - Whales
      repository: zzzz

At that point the wikis will be served with urls like /wiki/Cats/my-beloved-one and so on.
It sounds like a nice feature but at the moment I can't see all the implications.

The smallest federated wiki has a farm mode, if that pleases your request.
And since we undoubtedly share several requirements with the Federated Wiki, you may even want to see if our user stories couldn't be written partly together.
I am willing to provide further details upon FedWiki's farm mode in a new thread within the support category of the newly started community initiative federated.wiki, for example.


vdccompare not installed on linux

The linux installer does not seem to be bundling vdccompare.

It's building, but not packaging to the installer.


Layouting

Node d’n’d, Layouting, Saving node positions (in percentage?, 50px-quantificator?)

I decided to leave things as simple as possible, now GridLayout is called GridPlacing and just finds next position for the node, using the given node initial size (loads one from node type definition, if specified). It is done in the way to make it easy to add any other layout placing. Currently, it is vertical, but it looks like it should be changed to horizontal by default.

But, default "placing" should be horizontal, new nodes should go from left to right and then one step down, instead of top to bottom and one step right

I close this, since we have #158 and layouting a.k.a. placing is extracted now


[manila-csi-plugin] allow to update volumesnapshotcontents/status

What this PR does / why we need it:
This commit adds a permission that allows the controllerplugin to update volumesnapshotcontents/status.
Which issue this PR fixes(if applicable):
fixes #1142
NONE

/retest

/retest

/lgtm
/assign @gouthampacha
/assign @gman0

These RBAC rules are only needed for csi-snapshotter v2, and we haven't made the move yet - snapshots created in v1 are incompatible with v2. I've tested this without installing csi-snapshotter v2 and no errors were reported so I'm guessing this is fine. Since we'll need to upgrade to v2 eventually I'm ok with this change.
/lgtm
/approve

CC @ramineni

@Fedosin @gman0 Have added questions on the issue https://github.com/kubernetes/cloud-provider-openstack/issues/1142
Ideally with current snapshotter version , this change shouldn't be required.
Lets continue discussion on the issue. Keeping this on hold till then
/hold

/close
no update , pls reopen if required


Make Demo login more clear

indicate free ethereum
same function as app
testnet, not real value
can easily switch back

to be designed.


PowerShell Output Error in VS Code

If I open the InvokePester.ps1 file in VS Code I get an error in the PowerShell Output. Anytime I swap between another file and InvokePester.ps1 this error occurs.
Suppression Message Attribute error at line 16 in InvokePlaster.ps1 : Cannot find any Targets ModifyContent that match the Scope Function to apply the SuppressMessageAttribute.

Thanks.  I changed the name of a function and didn't update the SupressMessage attribute.  I fix that tonight.


Update vllm colab to work with asyncio requirements

In https://github.com/apache/beam/pull/32687 I updated the vLLM model handler to use an asyncio event loop. This led to huge efficiency gains (around <batch_size>x faster), but also broke it in environments where there is already an asyncio event loop because of https://stackoverflow.com/questions/55409641/asyncio-run-cannot-be-called-from-a-running-event-loop-when-using-jupyter-no
This is generally fine (this is not a normal environment to run Beam), but it does break things for colab environments. It can be easily fixed with this tweak, though - this PR makes that tweak to our example so that this keeps working. I've confirmed we don't need this to run in Dataflow/other runners

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
[ ] Update CHANGES.md with noteworthy changes.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

This shouldn't be merged before the release, but it can get reviewed now I guess

R: @shunping


Inserting elements with data-tooltip attributes does nothing.

You have to manually create the Tooltip. This should at least be mentioned in the docs.

Documentation will be redone soon and can reflect that only elements with data-tooltip before DOMContentLoaded is triggered will get initialized.

@geekjuice is there any way around this?


Scoped Webhooks

Describe the feature you'd like
The ability to bind a webhook in scope to either a single book or shelf (and all child books), or multiple books or shelves (and all child books), instead of being global.
This is really only applicable to certain classes of actions, like _create, _update, _move, _delete, the comment events. The event types checked below could feasibly be scoped, the unchecked ones are global by default pretty much.

Describe the benefits this would bring to existing BookStack users
This allows more granularity and for better control. In my use case, I don't ever need a webhook to tell me if ANY page has been edited, but I do have needs to know if pages in specific books are edited. Different books are scoped to different teams, but creating a webhook to update specific teams about which pages in their books are updated is difficult, as webhooks see everything. The current webhook implementation is good if everything is global, and there is only one main team (which is supposed to see everything).
Can the goal of this request already be achieved via other means?
Technically, yes. I posted a solution in #5009 that allows you to lock a specific webhook to only fire correctly (it'll still try to send the webhook, but with malformed output and will fail safely. Probably, anyway.) given a specific book ID and webhook name combo.
<?php

use BookStack\Activity\Models\Loggable;
use BookStack\Activity\Models\Webhook;
use BookStack\Activity\Tools\WebhookFormatter;
use BookStack\Facades\Theme;
use BookStack\Theming\ThemeEvents;
use BookStack\Users\Models\User;

function selectiveFormat(array $defaultWebhookData): array
{
    $book_id = $defaultWebhookData['related_item']['book_id'];
    $webhook_name = $defaultWebhookData['webhook_name']
    if ( !(
        ($book_id == 1 && $webhook_name == "Team 1 Webhook") ||
        ($book_id == 2 && $webhook_name == "Team 2 Webhook") ||
        ($book_id == 3 && $webhook_name == "Team 3 Webhook") ||
        ($book_id == 4 && $webhook_name == "Team 4 Webhook")
    )
    ) {
        // If it's a teams webhook, but the name and book ID don't match, then just return nothing and cause a 400 error.
        return [];
    }
    return null;

}

Theme::listen(ThemeEvents::WEBHOOK_CALL_BEFORE, function (
    string $event,
    Webhook $webhook,
    string|Loggable $detail,
    User $initiator,
    int $initTime,
) {
    if (str_starts_with($webhook->endpoint, 'https://teams.webhook.whatever')) {
        $defaultData = WebhookFormatter::getDefault($event, $webhook, $detail, $initiator, $initTime);
        return selectiveFormat($defaultData->format());
    }
    return null;
});

This is adapted from https://www.bookstackapp.com/hacks/pushover-webhooks/.
Have you searched for an existing open/closed issue?

[X] I have searched for existing issues and none cover my fundamental request

How long have you been using BookStack?
3 months to 1 year
Additional context
No response

This would be pretty much perfect for specific updates in channels that only are interested in certain topics :)

Users can watch books, chapters and pages, which is implemented really well. So I as a user can be notified via email when a page inside a specific book was updated. A similar behaviour for webhooks would be very powerful, so I as an admin can send a notification to e.g. a specific Zulip/Slack/Discord channel when Book A was updated, and to a different channel when Book B was updated.


How to input the query into Ranknet?

Hi,
The model structure of Ranknet shows that it just use the feature of document as input,
Does Ranknet use query as input too?How?

The input features to RankNet include "query-dependent" features. See Section 6.1 in "Learning to Rank using Gradient Descent".


fix: fmt::Display for Background<T> should color background

This incorrectly colored the foreground instead of the background.

@zesterer did you already had a chance to spend some of your valueable time reviewing this? :)

Thanks for the PR! It seems that GitHub didn't show me notifications for this, not sure why.

@zesterer you could add a CODEOWNERS file to your repos so that you are automatically added to PRs as a reviewer in order to receive a notification: https://docs.github.com/en/repositories/managing-your-repositorys-settings-and-features/customizing-your-repository/about-code-owners
It's a little bit strange that one cannot configure this globally for ones own repos.


feat: rewrite Azure DevOps plugin

⚠ Pre Checklist

Please complete ALL items in this checklist, and remove before submitting

[x] I have read through the Contributing Documentation.
[x] I have added relevant tests.
[x] I have added relevant documentation.
[x] I will add labels to the PR, such as pr-type/bug-fix, pr-type/feature-development, etc.

Summary
As discussed in #2604 this is a revamped version of the Python Azure DevOps Plugin, originally located at ../../python/plugins/azuredevops. Please note, that the current implementation lacks a database migration script to retain the data collected by the Python plugin. As a result, the plugin has been temporarily excluded from the go plugin build process to prevent conflicts with the existing Python version.
PLUGINS=$(find $PLUGIN_SRC_DIR/* -maxdepth 0 -type d -not -name core -not -name helper -not -name logs -not -empty -not -name azuredevops)

Please be careful and only activate the plugin if you know what you do. Once activated following tool tables
will be dropped. The data aggregated in the domain tables will remain untouched which can leave your database in an
undesired state.
"_raw_azuredevops_builds",
"_raw_azuredevops_gitpullrequestcommits",
"_raw_azuredevops_gitpullrequests",
"_raw_azuredevops_jobs"

"_tool_azuredevops_builds",
"_tool_azuredevops_gitpullrequestcommits",
"_tool_azuredevops_gitpullrequests",
"_tool_azuredevops_gitrepositories",
"_tool_azuredevops_gitrepositoryconfigs",
"_tool_azuredevops_jobs"

Does this close any open issues?
No.
Other Information
⚠  Access to Service Connections has been removed as they usually contain sensitive security information.
Any other information that is important to this PR.

@klesh  apologies for including almost 100 files in this pull request. The primary objective of this initial submission is to achieve feature parity with the Python plugin. However, I have omitted the remote repositories from the service connections. Additionally, we need to create a migration plan if we want to phase out the Python plugin. Any suggestions on that?

@mr-ks No worries about the files, I agree with you that the PR should implement whatever the current python plugin does.
I think we can make it a new plugin alongside the Python one because it would be easier to code and it is acceptable for user to move connections from one to another.

@klesh
Do you have any suggestions for the naming? What do you think of  using azuredevops_v2 as an identifier for the database tables and azuredevops-v2 for the APIs?
E.g.:
Database
_tool_azuredevops_v2_pull_requests

API
api/plugins/azuredevops-v2/connections/...

Maybe putting the go into the name would help to signify that it differs from the Python one.

FWIW I had run into a problem with the python version failing to let me link more than 30 or so repos. so I built this branch and switched my testing to this go implementation. I can confirm it doesn't have the same issues and i've been able to link >100 repos to a project. There are still unrelated UI issues that mean you have to do this via direct calls to teh rest apis. however this PR seems good and an improved solution overall. (I still had to cusomise it to work for my on-prem use case but that's ok) fwiw if you select api verison 7.0 instead of 7.1 then almost everything works fine on prem also.

Hi, @mr-ks .  I didn't notice that the PR was ready until @wouldd 's comment, seems like the unit test is failing, would you mind taking a look? Feel free to tag me if I did not response in time. Thanks for your contribution.

Hi @klesh, unit tests are fixed. I added the plugin in the backend/plugins/table_info_test.gofile, sorry for that. Can you please approve the workflow runs once again?

@mr-ks No worries, I just saw the lint-commit-message didn't pass, it is ok to leave it to fail if it is hard for you to fix. We would accept the PR as long as the code itself is colid.

@klesh looks like some prs were merged that had titles not compliant to the conventions. I did a rebase to  fix the commit linting step. I hope this is also what you had in mind.

@mr-ks Nice work, actually, this is beyond what I had in mind 👍
Do you think it is ready to be merged? If so, I would need to discuss it with others because we are already in v1.0.0 testing phase.

@klesh fwiw I have been testing with this implmentation for the last week or so. I would say it is ready to be merged and it is somewhat suprior to the existing python implementation


Add zone info to generated cluster_id

Fixed #242
Signed-off-by: CS Zhang<EMAIL_ADDRESS>

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: cs-zhang
To complete the pull request process, please assign yussufsh after the PR has been reviewed.
You can assign the PR to them by writing /assign @yussufsh in a comment when ready.
The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cs-zhang you'll need to rebase

New changes are detected. LGTM label has been removed.

@cs-zhang: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

pull-ocp4-upi-powervs-terraform-fmt
3096e7453cbfbc8ff8fa53e9bb8aec94d92b26bc
link
/test pull-ocp4-upi-powervs-terraform-fmt

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: bpradipt, cs-zhang
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [bpradipt]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

CC- @yussufsh

New changes are detected. LGTM label has been removed.

@cs-zhang: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

pull-ocp4-upi-powervs-terraform-validate
a3f78333cded71f83ec403a8fde5148ba2232324
link
/test pull-ocp4-upi-powervs-terraform-validate

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@cs-zhang please squash you commits into one, I will approve.

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: bpradipt, cs-zhang
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [bpradipt]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: bpradipt, cs-zhang, yussufsh
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [bpradipt,yussufsh]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

/cherry-pick release-4.7

/cherry-pick release-4.6


Question: QpSplineReferenceLineSmoother::SetAnchorPoints and QpSplineReferenceLineSmoother::Smooth

Here are the signatures of two functions:
bool QpSplineReferenceLineSmoother::Smooth(
    const ReferenceLine& raw_reference_line,
    ReferenceLine* const smoothed_reference_line)

void QpSplineReferenceLineSmoother::SetAnchorPoints(
    const std::vector<AnchorPoint>& anchor_points)

After read the related functions about how a reference line is smoothed out, I noticed there is direct relationship in between the anchor_points and the raw_reference_line to be smoothed. In fact, these anchor points have to be extracted from the raw reference line or the prefixed reference line, otherwise the resulted smoothed_reference_line is meaningless.
If this is the case, there is no need of SetAnchorPoints(). Instead, the anchor points should be extracted inside Smooth() for the given raw_reference_line and prefix_ref_line.
Here is code snippet of ReferenceLineProvider::GetAnchorPoints():
void ReferenceLineProvider::GetAnchorPoints(
    const ReferenceLine &reference_line,
    std::vector<AnchorPoint> *anchor_points) const {
  CHECK_NOTNULL(anchor_points);
  const double interval = smoother_config_.max_constraint_interval();
  int num_of_anchors =
      std::max(2, static_cast<int>(reference_line.Length() / interval + 0.5));
  std::vector<double> anchor_s;
  common::util::uniform_slice(0.0, reference_line.Length(), num_of_anchors - 1,
                              &anchor_s);
  for (const double s : anchor_s) {
    anchor_points->emplace_back(GetAnchorPoint(reference_line, s));
  }
  anchor_points->front().longitudinal_bound = 1e-6;
  anchor_points->front().lateral_bound = 1e-6;
  anchor_points->front().enforced = true;
  anchor_points->back().longitudinal_bound = 1e-6;
  anchor_points->back().lateral_bound = 1e-6;
  anchor_points->back().enforced = true;
}

It shows that there is no other dependencies to generate anchor points for a reference line but itself. Anyhow, this is just a suggestion.

The current code idea is:
raw_reference_line -> anchor_points -> smoothed reference line.
Anchor points were designed as the middle layer, such that different smoothing algorithms can have a uniform constraint input (which is anchor point), without being bothered by how these anchor points are generated.
You may already notice that there is some logic in how to extract and shift these anchor points, and anchor points could come from a part of a previous reference line. This logic is orthogonal with the smoothing algorithm.


MoltenVK/iOS support

Until now I have to compile a different version for MoltenVK/iOS with "__Internal" as library path. Would be great if VulkanSharp would support MoltenVK/iOS out of the box. Perhaps this could be achieved using dllmap in .config? Or is it better to compile one Vulkan.iOS.dll including everything from Vulkan.dll with correct library path?

Maybe adding this line in Vulkan.dll.config might work?
<dllmap dll="vulkan-1" os="osx" target="__Internal" />

Context: https://bugzilla.xamarin.com/show_bug.cgi?id=24943

Maybe adding this line in Vulkan.dll.config might work?
<dllmap dll="vulkan-1" os="osx" target="__Internal" />

Context: https://bugzilla.xamarin.com/show_bug.cgi?id=24943

Does not work for me. Anyone got this working?


cargo build error

..\stm32-hal2-0.2.8\src\timer.rs:319:13
319 |             pub fn countdown(&self) -> u32 {
|             |
|             duplicate definitions for countdown
|             other definition for countdown
All pub fn void reported errors.

hi,
In the  Cargo.toml, stm32-hal2 = { version = "^0.2.8", features = ["f4", "stm32f4"]},when i cargo build,
error：
..\stm32-hal2-0.2.8\src\timer.rs:319:13
319 | pub fn countdown(&self) -> u32 {
| |
| duplicate definitions for countdown
| other definition for countdown
All pub fn void reported errors.
error[E0592]:duplicate definitions with name set_prescaler

Hi! This is a documentation issue. The available features for f4 are shown in Cargo.toml here: https://github.com/David-OConnor/stm32-hal/blob/main/Cargo.toml#L83
So, the line in Cargo.toml should be something like this:
stm32-hal2 = { version = "^0.2.8", features = ["f405", "f4rt"]}
There's a line that's supposed to throw a compile error in lib.rs, but it's not working properly. I'll update the Readme to provide guidance on this. Thanks for bringing it up - let me know if you still have issues after making this change.

Hi,I see. Thank you for your help！

Readme updated to be more clear

OK,Thanks!


fix(doc): Changed the required package name correctly in the document.

Checklist:

[x] I have read freeCodeCamp's contribution guidelines.
[x] My pull request has a descriptive title (not a vague title like Update index.md)
[x] My pull request targets the master branch of freeCodeCamp.
[x] All the files I changed are in the same world language, for example: only English changes, or only Chinese changes, etc.

Ref. https://www.freecodecamp.org/learn/quality-assurance/advanced-node-and-express/set-up-the-environment
IMO: The required package name is http.  Just fix only in the documentation (not code sample, test script).

@ieahleen
Thanks for your time and comment!

why have you proposed this change?

The only place that was changed was the word,  "html". So I included the Chinese translation file because I didn't change the Chinese characters.
According to the rule,  All the files I changed are in the same world language, my changeset is not appropriate. Should I close and re-issue the pull request only for the English file?

I think we can make exception on this one because it probably does not affect the translation.

:sparkles: :sparkles: AWESOME! LGTM. :sparkles: :sparkles:
Thanks @akiko-pusu, for this pull request and contributing to the code-base for the first time.
We will be looking forward for more contributions in future.
Cheers and happy contributing!


feat(dispatch): require configuration of academic use for commercial solvers

closes #3059

Rather than having a boolean flag for academic use, lets create an enum such as tier or type that we can use to differentiate various different types. For now we can just have two options of acadmic/other but later can include others if it comes up

Feel free to use an enumeration instead, but it would be challenging to support multiple tiers and communicate what resources are available to which tiers. In practice, I think just two tiers is a good way to avoid overcomplicating this.

 The dispatch-service would then have to have a map from purposes to eligible keys. The secrets would need to contain more information about which keys can be used for which purposes.

Switched to enumeration with two current values: academic and other

:tada: This PR is included in version 5.1.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Suggestion: separate TQEC frontend/backend into submodules

Since tqec (Python backend) and tqec-js (React frontend) are becoming large projects in their own right, it'd make sense to separate them into their own repositories, and combine them back into this repository as submodules.

Different repositories will make it harder to coordinate the project. Different issue lists e.t.c. A monorepo the way Cirq does it makes things easier communication-wise.


[Warning] Illegal string offset 'Month'

I have this warming that blocks the all process of recording the form
[Warning] Illegal string offset 'Month'
I'm on Silverstripe 3.6 using  the DateSelectorField

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

This might be fixed with #10


get_color_from_hex support and 3-4 HEX values

Maintainer merge checklist

[x] Title is descriptive/clear for inclusion in release notes.
[x] Applied a Component: xxx label.
[ ] Applied the api-deprecation or api-break label.
[ ] Applied the release-highlight label to be highlighted in release notes.
[ ] Added to the milestone version it was merged into.
[ ] Unittests are included in PR.
[x] Properly documented, including versionadded, versionchanged as needed.

You want me to add more futures just because I opened this pull request and to change even the arguments names on your command even you have the option to edit it as you wish, but If I was never opened you had no intention to add this future.
I feel like I just waste my time. I asked three times for help on discord server on the couple months and I did not get any answer like I was invisible, so yeah, I just waste my time. I leaved the discord server and I will close all my pull requests.


Print METAR to webhook

Hiya!
Not really an issue, more of a query.
Could I use my API key to print a METAR to a Discord webhook daily?

Yes. Discord bots are a popular use case. See AvBot for an example:
https://top.gg/bot/494888240617095168

Hiya,
If i were to do this, how would I do it lol?
I just need it to print 1 METAR

I haven't made a Discord bot myself, but I have done some Slack bots. You'd need your own backend server for the bot's commands to go to. That server would make the call to AVWX (or use this library :) if you use Python) and return the report to the Discord bot.
You may be able to make it with no code using a tool like https://botghost.com but it depends on their feature set.
Hope that helps!


docs(nodejs-addon-examples): add guide for pnpm user

For example, pnpm will install the sherpa-onnx-linux-x64 at<EMAIL_ADDRESS>so the addon.js can not find sherpa-onnx.node.

pnpm will install the sherpa-onnx-linux-x64 at<EMAIL_ADDRESS>
In that case, could you modify
https://github.com/k2-fsa/sherpa-onnx/blob/8535b1d3bbbf4bfedf3924abaf563e3e346ad042/scripts/node-addon-api/lib/addon.js#L10
Does it work if you add
  `./node_modules/.pnpm/sherpa-onnx-${platform_arch}/sherpa-onnx.node`,

No, because the folder name with the version like<EMAIL_ADDRESS>So alternative way to resolve this issue is parse the installed version of sherpa-onnx-linux-x64, but it is a complicated way.

Actually the folder structure like this:

Update: It is a issue about environment variable LD_LIBRARY_PATH.


[Feature] Support symroot to specify output dir.

IIRC (long time since I worked on this) you have to run npm dist before this will work.


in call to configure_features(), parameter 'cc_toolchain' got value of type 'ToolchainInfo', want 'CcToolchainInfo'

Bazel plugin sync failed for this project: https://github.com/dozer47528/new-filter
I can build is from command line with bazel.
Clion version: 2019.3
Plugin version: v2020.04.13
Bazel Console Detail:
Syncing project: Partial Sync (partial)...
Updating VCS...
Running Bazel info...
Command: /usr/local/bin/bazel info --tool_tag=ijwb:CLion --curses=no --color=yes --progress_in_terminal_title=no --

Computing VCS working set...
Sync targets from Partial Sync:
  //...:all

Building Bazel targets...
Command: /usr/local/bin/bazel build --tool_tag=ijwb:CLion --keep_going --build_event_binary_file=/var/folders/vc/612y8yl17mq1zj174kl1v3r40000gp/T/intellij-bep-1548dafd-60bd-4fca-9e12-cc4a112477e5 --nobuild_event_binary_file_path_conversion --curses=no --color=yes --progress_in_terminal_title=no --aspects=@intellij_aspect//:intellij_info_bundled.bzl%intellij_info_aspect "--override_repository=intellij_aspect=/Users/dozer/Library/Application Support/CLion2019.3/clwb/aspect" --output_groups=intellij-info-cpp,intellij-info-generic,intellij-resolve-cpp -- //...:all

Loading:
Loading: 0 packages loaded
Analyzing: 9 targets (0 packages loaded, 0 targets configured)
Analyzing: 9 targets (7 packages loaded, 162 targets configured)
ERROR: /Users/dozer/Projects/github/new-filter/toolchain/BUILD:29:13: in @intellij_aspect//:intellij_info_bundled.bzl%intellij_info_aspect aspect on cc_toolchain rule //toolchain:wasm_toolchain:
Traceback (most recent call last):
	File "/Users/dozer/Projects/github/new-filter/toolchain/BUILD", line 29
		@intellij_aspect//:intellij_info_bundled.bzl%intellij_info_aspect(...)
	File "/private/var/tmp/_bazel_dozer/1e05734fcff914bf2c5b19860ac81bf0/external/intellij_aspect/intellij_info_bundled.bzl", line 54, in _aspect_impl
		intellij_info_aspect_impl(<3 more arguments>)
	File "/private/var/tmp/_bazel_dozer/1e05734fcff914bf2c5b19860ac81bf0/external/intellij_aspect/intellij_info_impl.bzl", line 1032, in intellij_info_aspect_impl
		collect_c_toolchain_info(target, <5 more arguments>)
	File "/private/var/tmp/_bazel_dozer/1e05734fcff914bf2c5b19860ac81bf0/external/intellij_aspect/intellij_info_impl.bzl", line 480, in collect_c_toolchain_info
		cc_common.configure_features(<4 more arguments>)
in call to configure_features(), parameter 'cc_toolchain' got value of type 'ToolchainInfo', want 'CcToolchainInfo'
INFO: Analyzed 9 targets (8 packages loaded, 226 targets configured).
INFO: Found 9 targets...
[0 / 1] [Prepa] BazelWorkspaceStatusAction stable-status.txt
ERROR: command succeeded, but not all targets were analyzed
INFO: Elapsed time: 2.317s, Critical Path: 0.01s
INFO: 0 processes.

FAILED: Build did NOT complete successfully
build invocation result: build_error
Sync was successful, but there were Bazel build errors. The project may not be fully updated or resolve until fixed. If the errors are from your working set, please uncheck 'Bazel > Sync > Expand Sync to Working Set' and try again.
Parsing build outputs...
Total rules: 11, new/changed: 0, removed: 0
Reading IDE info result...
Reading IDE info result...
Updating target map
Loaded 0 aspect files, total size 0kB
Prefetching genfiles...
Target map size: 6
Prefetching output artifacts...
Prefetching files...
Refreshing files
Computing directory structure...
Initializing project SDKs...
Committing project structure...
Workspace has 0 libraries
Workspace has 2 modules
Updating in-memory state...
1 unique C configurations, 1 C targets
Sync finished

Timing summary:
BlazeInvocation: 2.4s, Prefetching: 0ms, Other: 591ms

Having the same issue, any workaround?

I encounter the same error with this project: https://github.com/deepmind/reverb
CLion: 2020.1.3
Platform: Linux 5.4.0-52-generic
Bazel plugin: 2<IP_ADDRESS>.1
Bazel: 3.7.0

In .bazelrc, try adding build  --incompatible_enable_cc_toolchain_resolution and see if it works.


fixes #170 deprecated WebBrowser is used

Hi @alexandervanhecke,
Thank you for your contribution! We really value the time you've taken to put this together.
Before we proceed with reviewing this pull request, please sign the Lightbend Contributors License Agreement:
http://www.lightbend.com/contribute/cla

@marcospereira great, thanks for your help!  looking forward to a release containing this fix ;-)


Update test to use new KafkaUser type

Signed-off-by: Kevin Earls<EMAIL_ADDRESS>This is the first part of #713

@jpkrohling @objectiser @pavolloffay Please review.


HBASE-24767 Change default to false for HBASE-15519 per-user metrics

Set hbase.regionserver.user.metrics.enabled default to false; i.e. off.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 31s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ branch-2 Compile Tests _

+1 :green_heart:
mvninstall
4m 15s
branch-2 passed

+1 :green_heart:
checkstyle
1m 17s
branch-2 passed

+1 :green_heart:
spotbugs
2m 16s
branch-2 passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
3m 50s
the patch passed

+1 :green_heart:
checkstyle
1m 11s
the patch passed

+1 :green_heart:
whitespace
0m  1s
The patch has no whitespace issues.

+1 :green_heart:
hadoopcheck
13m 50s
Patch does not cause any errors with Hadoop 3.1.2 3.2.1.

+1 :green_heart:
spotbugs
2m 31s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
0m 18s
The patch does not generate ASF License warnings.

39m 58s

Subsystem
Report/Notes

Docker
Client=19.03.12 Server=19.03.12 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2132/1/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2132

Optional Tests
dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle

uname
Linux 1cc7a9178422 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2 / 70ab0dc324

Max. process+thread count
84 (vs. ulimit of 12500)

modules
C: hbase-server U: hbase-server

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2132/1/console

versions
git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 39s
Docker mode activated.

-0 :warning:
yetus
0m  6s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ branch-2 Compile Tests _

+1 :green_heart:
mvninstall
4m 27s
branch-2 passed

+1 :green_heart:
compile
1m  7s
branch-2 passed

+1 :green_heart:
shadedjars
5m 58s
branch has no errors when building our shaded downstream artifacts.

-0 :warning:
javadoc
0m 41s
hbase-server in branch-2 failed.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
4m  5s
the patch passed

+1 :green_heart:
compile
1m  4s
the patch passed

+1 :green_heart:
javac
1m  4s
the patch passed

+1 :green_heart:
shadedjars
7m  5s
patch has no errors when building our shaded downstream artifacts.

-0 :warning:
javadoc
0m 50s
hbase-server in the patch failed.

_ Other Tests _

-1 :x:
unit
145m 13s
hbase-server in the patch failed.

173m 31s

Subsystem
Report/Notes

Docker
Client=19.03.12 Server=19.03.12 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2132/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2132

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 31acd52d0b43 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2 / 70ab0dc324

Default Java
2020-01-14

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2132/1/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2132/1/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt

unit
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2132/1/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2132/1/testReport/

Max. process+thread count
3573 (vs. ulimit of 12500)

modules
C: hbase-server U: hbase-server

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2132/1/console

versions
git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 39s
Docker mode activated.

-0 :warning:
yetus
0m  7s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ branch-2 Compile Tests _

+1 :green_heart:
mvninstall
3m 46s
branch-2 passed

+1 :green_heart:
compile
0m 53s
branch-2 passed

+1 :green_heart:
shadedjars
4m 57s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 37s
branch-2 passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
3m 20s
the patch passed

+1 :green_heart:
compile
0m 55s
the patch passed

+1 :green_heart:
javac
0m 55s
the patch passed

+1 :green_heart:
shadedjars
5m  6s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 34s
the patch passed

_ Other Tests _

-1 :x:
unit
153m 53s
hbase-server in the patch failed.

177m  4s

Subsystem
Report/Notes

Docker
Client=19.03.12 Server=19.03.12 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2132/1/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2132

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 8913a5dab25d 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2 / 70ab0dc324

Default Java
1.8.0_232

unit
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2132/1/artifact/yetus-jdk8-hadoop2-check/output/patch-unit-hbase-server.txt

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2132/1/testReport/

Max. process+thread count
3296 (vs. ulimit of 12500)

modules
C: hbase-server U: hbase-server

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2132/1/console

versions
git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@saintstack Test failures were related? Seems that the results are not available anymore.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 33s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ branch-2 Compile Tests _

+1 :green_heart:
mvninstall
3m 28s
branch-2 passed

+1 :green_heart:
checkstyle
1m  6s
branch-2 passed

+1 :green_heart:
spotbugs
2m  4s
branch-2 passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
3m 26s
the patch passed

+1 :green_heart:
checkstyle
1m  7s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
hadoopcheck
12m 50s
Patch does not cause any errors with Hadoop 3.1.2 3.2.1.

+1 :green_heart:
spotbugs
2m 40s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
0m 14s
The patch does not generate ASF License warnings.

36m 38s

Subsystem
Report/Notes

Docker
Client=19.03.12 Server=19.03.12 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2132/2/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2132

Optional Tests
dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle

uname
Linux 323de096782a 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2 / 70ab0dc324

Max. process+thread count
94 (vs. ulimit of 12500)

modules
C: hbase-server U: hbase-server

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2132/2/console

versions
git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

Thanks for the reviews @virajjasani  and @HorizonNet  (Jan, I push against branch-2 because I know its stable... will forward port to master).  Thanks to which ever of you reran the build for me.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 34s
Docker mode activated.

-0 :warning:
yetus
0m  5s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ branch-2 Compile Tests _

+1 :green_heart:
mvninstall
4m  9s
branch-2 passed

+1 :green_heart:
compile
1m  4s
branch-2 passed

+1 :green_heart:
shadedjars
5m 51s
branch has no errors when building our shaded downstream artifacts.

-0 :warning:
javadoc
0m 43s
hbase-server in branch-2 failed.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
3m 55s
the patch passed

+1 :green_heart:
compile
1m  2s
the patch passed

+1 :green_heart:
javac
1m  2s
the patch passed

+1 :green_heart:
shadedjars
5m 47s
patch has no errors when building our shaded downstream artifacts.

-0 :warning:
javadoc
0m 40s
hbase-server in the patch failed.

_ Other Tests _

-1 :x:
unit
125m 56s
hbase-server in the patch failed.

151m 38s

Subsystem
Report/Notes

Docker
Client=19.03.12 Server=19.03.12 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2132/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2132

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux ecc584630e64 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2 / 70ab0dc324

Default Java
2020-01-14

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2132/2/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2132/2/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt

unit
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2132/2/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2132/2/testReport/

Max. process+thread count
4330 (vs. ulimit of 12500)

modules
C: hbase-server U: hbase-server

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2132/2/console

versions
git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 41s
Docker mode activated.

-0 :warning:
yetus
0m  7s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ branch-2 Compile Tests _

+1 :green_heart:
mvninstall
4m 52s
branch-2 passed

+1 :green_heart:
compile
1m 20s
branch-2 passed

+1 :green_heart:
shadedjars
6m 15s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 39s
branch-2 passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
3m 42s
the patch passed

+1 :green_heart:
compile
1m  2s
the patch passed

+1 :green_heart:
javac
1m  2s
the patch passed

+1 :green_heart:
shadedjars
5m 36s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 35s
the patch passed

_ Other Tests _

-1 :x:
unit
211m 33s
hbase-server in the patch failed.

239m 32s

Subsystem
Report/Notes

Docker
Client=19.03.12 Server=19.03.12 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2132/2/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2132

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 24d4f6e63d80 4.15.0-101-generic #102-Ubuntu SMP Mon May 11 10:07:26 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2 / 70ab0dc324

Default Java
1.8.0_232

unit
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2132/2/artifact/yetus-jdk8-hadoop2-check/output/patch-unit-hbase-server.txt

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2132/2/testReport/

Max. process+thread count
2519 (vs. ulimit of 12500)

modules
C: hbase-server U: hbase-server

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2132/2/console

versions
git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 33s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ branch-2 Compile Tests _

+1 :green_heart:
mvninstall
3m 39s
branch-2 passed

+1 :green_heart:
checkstyle
1m  9s
branch-2 passed

+1 :green_heart:
spotbugs
1m 57s
branch-2 passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
3m  9s
the patch passed

+1 :green_heart:
checkstyle
1m  6s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
hadoopcheck
11m 25s
Patch does not cause any errors with Hadoop 3.1.2 3.2.1.

+1 :green_heart:
spotbugs
2m  6s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
0m 15s
The patch does not generate ASF License warnings.

32m 35s

Subsystem
Report/Notes

Docker
Client=19.03.12 Server=19.03.12 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2132/2/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2132

Optional Tests
dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle

uname
Linux 220e9fde93b2 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2 / 2720a9d93e

Max. process+thread count
94 (vs. ulimit of 12500)

modules
C: hbase-server U: hbase-server

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2132/2/console

versions
git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
32m 21s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  1s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ branch-2 Compile Tests _

+1 :green_heart:
mvninstall
5m 39s
branch-2 passed

+1 :green_heart:
checkstyle
1m 36s
branch-2 passed

+1 :green_heart:
spotbugs
2m 53s
branch-2 passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
5m 21s
the patch passed

+1 :green_heart:
checkstyle
1m 39s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
hadoopcheck
17m 36s
Patch does not cause any errors with Hadoop 3.1.2 3.2.1.

+1 :green_heart:
spotbugs
3m  0s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
0m 16s
The patch does not generate ASF License warnings.

80m 52s

Subsystem
Report/Notes

Docker
Client=19.03.12 Server=19.03.12 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2132/3/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2132

Optional Tests
dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle

uname
Linux a129cbf3193a 4.15.0-101-generic #102-Ubuntu SMP Mon May 11 10:07:26 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2 / 2720a9d93e

Max. process+thread count
85 (vs. ulimit of 12500)

modules
C: hbase-server U: hbase-server

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2132/3/console

versions
git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
18m 58s
Docker mode activated.

-0 :warning:
yetus
0m  7s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ branch-2 Compile Tests _

+1 :green_heart:
mvninstall
5m 13s
branch-2 passed

+1 :green_heart:
compile
1m 16s
branch-2 passed

+1 :green_heart:
shadedjars
7m 35s
branch has no errors when building our shaded downstream artifacts.

-0 :warning:
javadoc
0m 51s
hbase-server in branch-2 failed.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
4m 30s
the patch passed

+1 :green_heart:
compile
1m 14s
the patch passed

+1 :green_heart:
javac
1m 14s
the patch passed

+1 :green_heart:
shadedjars
7m 24s
patch has no errors when building our shaded downstream artifacts.

-0 :warning:
javadoc
0m 46s
hbase-server in the patch failed.

_ Other Tests _

-1 :x:
unit
8m 15s
hbase-server in the patch failed.

56m 43s

Subsystem
Report/Notes

Docker
Client=19.03.12 Server=19.03.12 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2132/4/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2132

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 25f520fc6ec6 4.15.0-65-generic #74-Ubuntu SMP Tue Sep 17 17:06:04 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2 / 6ded070f82

Default Java
2020-01-14

javadoc
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2132/4/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt

javadoc
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2132/4/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt

unit
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2132/4/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt

Test Results
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2132/4/testReport/

Max. process+thread count
1007 (vs. ulimit of 12500)

modules
C: hbase-server U: hbase-server

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2132/4/console

versions
git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
49m 56s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ branch-2 Compile Tests _

+1 :green_heart:
mvninstall
4m 34s
branch-2 passed

+1 :green_heart:
checkstyle
1m 18s
branch-2 passed

+1 :green_heart:
spotbugs
2m 26s
branch-2 passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
3m 52s
the patch passed

+1 :green_heart:
checkstyle
1m 17s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
hadoopcheck
14m  7s
Patch does not cause any errors with Hadoop 3.1.2 3.2.1.

+1 :green_heart:
spotbugs
2m 45s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
0m 14s
The patch does not generate ASF License warnings.

90m 28s

Subsystem
Report/Notes

Docker
Client=19.03.12 Server=19.03.12 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2132/4/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2132

Optional Tests
dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle

uname
Linux 5ee8ab68599c 4.15.0-65-generic #74-Ubuntu SMP Tue Sep 17 17:06:04 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2 / 6ded070f82

Max. process+thread count
95 (vs. ulimit of 12500)

modules
C: hbase-server U: hbase-server

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2132/4/console

versions
git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 47s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ branch-2 Compile Tests _

+1 :green_heart:
mvninstall
4m 18s
branch-2 passed

+1 :green_heart:
checkstyle
1m 20s
branch-2 passed

+1 :green_heart:
spotbugs
2m 29s
branch-2 passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
4m 15s
the patch passed

+1 :green_heart:
checkstyle
1m 29s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
hadoopcheck
15m 18s
Patch does not cause any errors with Hadoop 3.1.2 3.2.1.

+1 :green_heart:
spotbugs
2m 44s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
0m 13s
The patch does not generate ASF License warnings.

41m 58s

Subsystem
Report/Notes

Docker
Client=19.03.12 Server=19.03.12 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2132/6/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2132

Optional Tests
dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle

uname
Linux 91a08afd4d33 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2 / bba70f08ea

Max. process+thread count
95 (vs. ulimit of 12500)

modules
C: hbase-server U: hbase-server

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2132/6/console

versions
git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.


Add shape to sheet

It would be convenient to have a shape property in sheet objects. This would save from having to type (sheet.rows, sheet.columns), which seems like a thing you'd want quite often.

Maybe support http://www.numpy.org/neps/nep-0018-array-function-protocol.html ?


Fix multi_heap_get_info alias

Thanks @rojer, sorry for the delay due to the holiday. Queued for merging now.


📃: Add QR generator

:red_circle: Title : QR generator
:red_circle: Aim :  paster the url and generate the qr
:red_circle: Tech Stack Used : js css html
Screenshots 📷

:white_check_mark: To be Mentioned while taking the issue :

Full name : Ananya Gupta
What is your participant role?  gssoc hacktoberfest

Happy Contributing 🚀
All the best. Enjoy your open source journey ahead. 😎

i would like to work on it

@Avdhesh-Varshney i would like to work on this issue


Only ignore known wheel issue

Still run pipenv check, but ignore the known (non-actionable) wheel issue.
Context: https://github.com/microsoft/onefuzz/pull/2593#issuecomment-1299331019

Codecov Report

Merging #2595 (5e6f51b) into main (d655fcd) will decrease coverage by 2.59%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #2595      +/-   ##
==========================================
- Coverage   32.45%   29.85%   -2.60%
==========================================
  Files         162      289     +127
  Lines       21719    35809   +14090
==========================================
+ Hits         7049    10692    +3643
- Misses      14670    25117   +10447

Impacted Files
Coverage Δ

src/agent/coverage/src/code.rs
14.41% <0.00%> (-5.24%)
:arrow_down:

src/agent/onefuzz/src/fs.rs
55.55% <0.00%> (-4.37%)
:arrow_down:

...c/agent/dynamic-library/src/bin/dynamic-library.rs
2.38% <0.00%> (-0.40%)
:arrow_down:

src/agent/onefuzz-agent/src/worker.rs
62.00% <0.00%> (-0.38%)
:arrow_down:

src/agent/onefuzz/src/process.rs
1.32% <0.00%> (-0.16%)
:arrow_down:

src/agent/onefuzz/src/asan.rs
0.00% <0.00%> (ø)

src/agent/coverage/src/cache.rs
0.00% <0.00%> (ø)

src/agent/coverage/src/debuginfo.rs
0.00% <0.00%> (ø)

src/agent/onefuzz-agent/src/setup.rs
0.00% <0.00%> (ø)

src/agent/onefuzz-agent/src/reboot.rs
0.00% <0.00%> (ø)

... and 141 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


Signup-userpassform

Example of how we might use Signup as the "smart" component, and conditionally render the appropriate form.
Feel free to copy/paste/modify any doc examples you like, and add directly to the documentation within Signup so it shows all the hierarchy branches and routes in one place :)
Let me know any thoughts/questions/feedback you have!

COOL!
On Wed, Dec 27, 2023 at 4:11 PM Ari (Alyssa) Denary <
@.***> wrote:

Example of how we might use Signup as the "smart" component, and
conditionally render the appropriate form.
Feel free to copy/paste/modify any doc examples you like, and add directly
to the documentation within Signup so it shows all the hierarchy branches
and routes in one place :)
Let me know any thoughts/questions/feedback you have!
You can view, comment on, or merge this pull request online at:
https://github.com/ari-denary/volunteer-management-frontend/pull/5
Commit Summary

a61a7ed
https://github.com/ari-denary/volunteer-management-frontend/pull/5/commits/a61a7edbafea88e5db4b5e2cf682759bbe1fe872
add: createuserpassform
1acd6ae
https://github.com/ari-denary/volunteer-management-frontend/pull/5/commits/1acd6aeb1b5239f361691a6a78549a1d96ade11e
add: interface and typing, restrict data passed upon submit
d1f1b11
https://github.com/ari-denary/volunteer-management-frontend/pull/5/commits/d1f1b1102982f525b8d777d75c04d1ac7b187604
add: docs, state, handleSaveUserPass fx, conditional rendering

File Changes
(2 files
https://github.com/ari-denary/volunteer-management-frontend/pull/5/files
)

A src/components/CreateUserPassForm.tsx
https://github.com/ari-denary/volunteer-management-frontend/pull/5/files#diff-a55a7bef570879e777a22f0b6e07541b34567ef768c5d325ef586c71e49c9c69
(126)
M src/components/Signup.tsx
https://github.com/ari-denary/volunteer-management-frontend/pull/5/files#diff-40430fa96e22c30e430e98bea164207f126fca572dc2289d1f442f8ea2e4321b
(126)

Patch Links:

https://github.com/ari-denary/volunteer-management-frontend/pull/5.patch
https://github.com/ari-denary/volunteer-management-frontend/pull/5.diff
—
Reply to this email directly, view it on GitHub
https://github.com/ari-denary/volunteer-management-frontend/pull/5, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/A5JFZNV65Q5C7P764VVCWADYLS2M3AVCNFSM6AAAAABBE4ALNGVHI2DSMVQWIX3LMV43ASLTON2WKOZSGA2TOOBVHEZTAMI
.
You are receiving this because your review was requested.Message ID:
@.***>

Amazing


Open-Shell is listed as Classic-Start, it's previous name.

Classic-Start should be renamed to Open-Shell in the list.

shall i work on it?

shall i work on it?

Open-Shell is listed as Classic-Start, it's previous name. It's a personal favorite of mine since I was young, and I am so happy to have been able to bring it back into popularity! Kubernetes Certification Training


Node.js snippets

In reference to #120, where do we stand on Node.js snippets? I think we should get the tagging and categories working first before we add Node.js snippets, to distinguish from browser-specific ones. What do you guys think?

I'm actually all for it!
I think that node snippets have some different use cases than js in the browser, I'm talking about FS, IO workflows for example, so yeah. I think it's a great idea. 👍

@elderhsouza I agree, there's a ton of node-specific things I would like to see on the list, but I'd like to get the tagging script written first to make sure we get that sorted beforehand. Maybe we should discuss what categories we need under #94 ?

@Chalarangelo Right, I think we can close this then.


Adding a Pull request template

A simple PR template.

@Anduh
Good call! I need to close this PR.


Fix Readme Example

what
Fix typo in readme example.
Added support for IPv6 target group in ip mode
why

invalid variable name was there in the readme example
target groups in ip mode allow targets to register using ipv6. where service runs in ipv6 mode. only

/terratest


Updating a deep array using dispatchFields is not rendering content straight away

Link to reproduction
https://github.com/daniel7912/payload-cms-deep-arrays-issue
To Reproduce

Clone repo daniel7912/payload-cms-deep-arrays-issue
mv .env.example .env to set up test env variables
yarn to install deps
yarn dev to start server
Log into Payload admin panel using<EMAIL_ADDRESS>password test
Go to 'Products' collection and open 'Product 01'.
Click UI field button labelled 'Setup'. It looks like nothing happens. I would expect to see the listAmounts field with each variation update.
Save the document
Page content is updated & 'listAmounts' field under each variation is updated

Describe the Bug
I created a UI field which contains a single button. When this button is clicked, I am sending a dispatch action to update a deep nested array in variations > listAmounts.
The variations > listAmounts data is updated, but the page doesn't display the information.
If you then save the document, you can see the full data in the variations > listAmounts field as expected.
I logged a similar ticket a while back (https://github.com/payloadcms/payload/issues/1442) which was fixed - this could potentially be linked?
Payload Version
1.6.28

Hey @daniel7912 — I have some answers for you. I pulled down your repo and noticed a few things.
The reason your array field is not updating to reflect your changes is because arrays and blocks maintain their own rows state within their components, which is kept in sync as rows are added / removed, but is separate from the actual form state for performance / separation of concerns.
We plan to make editing array / blocks field values much more easily controllable in the future, but for now, I just released a new useForm method in a beta version which will allow you to do what you need.
It's called replaceState and it works because if you completely replace the form state, then arrays / blocks fields will recalculate their own rows, and then rerender accordingly.
Here's a re-written version of your component:
import React from 'react';
import { useForm } from '../../src/admin/components/forms/Form/context';

const Field: React.FC = () => {
  // Because we are going to be firing this action from an action (button click),
  // we can just use `useForm` itself. No need to subscribe to `useAllFormFields`
  const { fields, replaceState } = useForm();

  const setup = async (e) => {
    e.preventDefault();

    // Safely setup components to iterate over
    const components = Array.isArray(fields.components.value) ? fields.components.value : [];

    // Take a copy of state
    const newState = { ...fields };

    // Create an array for every variation
    // and loop over it
    Array.from(Array(fields.variations.value).keys()).forEach((_, i) => {
      // Assign the listAmounts array field itself a value
      // equal to an integer of how many rows it should have
      newState[`variations.${i}.listAmounts`] = {
        initialValue: components.length,
        value: components.length,
        valid: true,
        disableFormData: true,
      };

      // For each component, set the sub field values for each row
      components.forEach((component, n) => {
        newState[`variations.${i}.listAmounts.${n}.component`] = {
          initialValue: component,
          value: component,
          valid: true,
        };

        newState[`variations.${i}.listAmounts.${n}.amountRequired`] = {
          initialValue: 1,
          value: 1,
          valid: true,
        };
      });
    });

    // This is a new form method which replaces form state,
    // forcing your array field(s) to re-render
    replaceState(newState);
  };
  return (
    <React.Fragment>
      <button onClick={setup}>Setup</button>
    </React.Fragment>
  );
};

export default Field;

What do you think? Give it a shot!

Hi @jmikrut - that's great, thank you! Just upgraded & tried your solution and it worked perfectly.

Hi, I am following this example for my project but I am not sure how to properly dynamic update an Array.
My need is : map a custom tags textfield that contains a string with delimiters (ex: "one,two,three"),  to the rows of an array.
If I use dispatchFields the state seems to update but not the UI.
If I use replaceState I also need to manually rebuild all the subfields, delete all entries that should not be in the array (ex when you delete a tag), it seems very hacky.
Also when I set the array state value like this :
newState.tagsArrayField = {
        initialValue: generatedTagsArray.length,
        value: generatedTagsArray.length,
        valid: true,
        disableFormData: true,
};

The tagsArrayField doesn't update its rows count in the UI.
I've found a workaround with this :
newState.tagsArrayField = {
        initialValue: generatedTagsArray.length,
        value: generatedTagsArray.length,
        rows: generatedTagsArray.map( tag => ({ id : generateUIID() }) ), // <--- adding a rows here
        valid: true,
        disableFormData: true,
};

but I feel like I should miss something...
What is the proper way/steps to dynamic update an ArrayField so that the state and the UI are up to date.

@anthonyivol  I think there is a bug since one of the last versions anyway. My replaceState function was working perfectly fine, but now it isn't anymore. I need submit my colleciton manually or need to call the submit() function to display the new state.
However, I agree with you, that there should be an easier solution to change the state. Attached you can find the code I used to import an array from one langauge/locale to another. Maybe it helps:
export const ImportLocalizedBlocks: React.FC = () => {
  const config = useConfig()
  const {t} = useTranslation()
  const locale = useLocale()
  const {getFields, replaceState, setModified, setProcessing, submit} = useForm()
  const {collection, id} = useDocumentInfo()
  const fields = getFields()
  const [error, setError] = useState(false)
  console.log(fields)

  const langOptions = config?.localization
    ? config.localization.locales
        .filter((option) => option != locale)
        .map((option) => {
          option!
          return {
            label: option,
            value: option,
          } as OptionObject
        })
    : []

  const [selectedLang, setSelectedLang] = useState<string>(
    langOptions.length > 0 ? langOptions[0].value : ''
  )

  if (
    config?.localization === false ||
    (config?.localization && config?.localization?.locales.length <= 1)
  )
    return null

  const fetchData = async (url: string, query: any) => {
    const queryString = query ? qs.stringify(query, {addQueryPrefix: true}) : ''
    fetch(`${url}${queryString}`)
      .then((res) => {
        if (!res.ok) {
          throw Error(res.statusText)
        }
        return res
      })
      .then((res) => res.json())
      .then((data) => {
        handleData(data)
      })
      .catch((error) => {
        console.error(error)
        setError(true)
      })
      .finally(() => {
        setError(false)
      })
  }

const handleData = (data: any) => {
    const newState: State = {...fields}
    let path = 'content.layout' // the path for fields
    let components = Array.isArray(data.content?.layout) ? data.content?.layout : []

    // if you don't have any blocks in default language post
    if (!components || components.length == 0) {
      alert(t('blocks:noBlocksFound'))
      setProcessing(false)
      return
    }

    // set the new state for the root path
    newState[path] = {
      initialValue: components.length,
      value: components.length,
      valid: true,
      disableFormData: true,
    }

    // this array checks, if the value is a string array (used for payload field "point") and if its a array in the first place
    const arrayCheck = (value: any) => {
      if (Array.isArray(value)) {
        const isStringsArray = (array: any[]): boolean => {
          return array.every((i: any) => typeof i === 'string')
        }

        if (isStringsArray(value)) {
          return false
        }
        return true
      }
      return false
    }

    // this is where the magic happens and the new state is set
    // loops as long as every field is set correctly
    const loopArray = (components: Component[], path: string, newState: State) => {
      const stack = components.map((component, i) => ({
        component,
        path: `${path}.${i}`,
      }))

      while (stack.length) {
        const {component, path} = stack.pop()!

        Object.keys(component).forEach((key) => {
          const theKey = path ? `${path}.${key}` : key
          const value = component[key]

          newState[theKey] = {
            initialValue: value,
            value,
            valid: true,
            disableFormData: true,
          }
          if (arrayCheck(value)) {
            stack.push(
              ...value.map((v: any, i: any) => ({
                component: v,
                path: `${theKey}.${i}`,
              }))
            )
          } else if (typeof value === 'object') {
            stack.push({component: value, path: theKey})
          } else {
            newState[theKey] = {
              initialValue: value,
              value,
              valid: true,
              disableFormData: true,
            }
          }
        })
      }
    }

    // call the loop function
    loopArray(components, path, newState)

    // Sets the new state
    replaceState(newState)

    setModified(true)
    setProcessing(false)
    alert(t('blocks:importAlert'))
    submit()
  }
 const importBlocks = async (e: React.MouseEvent<HTMLElement>) => {
    e.preventDefault()
    setProcessing(true)
    fetchData(`/payload/api/${collection?.slug}/${id}`, {
      locale: selectedLang,
      depth: 0,
      draft: true,
    })
  }

  if (!id) return null
  if (error) return
Error

  return (

Import

{t('blocks:importInformation')}

      <SelectInput
        path={''}
        onChange={(e) => setSelectedLang(e.value as any)}
        value={selectedLang}
        name={'selectedLang'}
        options={langOptions}
        label={t('blocks:importSelectLanguageLabel')}
      />

      <button
        style={ButtonStyle}
        type="button"
        className="btn btn--size-medium btn--style-secondary"
        onClick={importBlocks}>
        {t('blocks:importBlocks')}
      </button>

  )
}

Hey,
@jmikrut, Thanks for the update. I have tried a few updates using dispatchFields with ADD_ROW & REMOVE_ROW.
They seem to be working perfectly. I'll be trying a few more flows just to double-check.
But, it's the changes work 👍. Thanks a lot.


[Suggestion] move to JSON5

This is  a feature request.
Description
switch to json5 for the form templates to create more readable & git-able json documents (also affects structuremanager)
php implementation: https://github.com/colinodell/json5

Please describe some use cases where we will benefit from this potential update.

As described

to create more readable & git-able json documents

For the formbuilder (which is the repo it's posted in)
Formbuilder usage
more easily written; commentable; ...

Why was this closed?

Please describe some use cases where we will benefit from this potential update.

Writing forms? the whole point of this package? I don't understand what is missing?

comments can be added to clarify why certain things are defined the way they are (use-case: maintainability)
better git-compatibility (use-case: better git compatibility... no double line-changes for adding a single key etc.)

...

I dont find writing comments in json a desirable "feature"

better git-compatibility

in which sens?

no double line-changes for adding a single key

example

I dont find writing comments in json a desirable "feature"
In case of dealing with big forms, the way json is used; they are

in which sens?
The thing you quoted

example

adding a placeholder(/anything else) to a field

Alternatively we could also support yaml? (which would be more work; hence opting for json5 instead)


README.adoc: Minor Cleanup

Coverage remained the same at 78.484% when pulling 7cd531b0628bafe038f8a754a42e62ae5941a4a6 on iMarbles:docs-README into 486c029f9957216d9e33c04770727507737b0a91 on CS2103-AY1819S1-W16-2:master.