App bundle including Aurelia modules

So the latest blog post demonstrates how to create two bundles, one for the app and one for Aurelia, along the lines of this:
var config = {
  ...
  bundles: {
    "dist/app-build": {
      includes: [
        '*',
        ...
      ],
      ...
    },
    "dist/aurelia": {
      includes: [
        'aurelia-bootstrapper',
        'aurelia-fetch-client',
        ...
      ],
      ...
    }
  }
};

What I'm running into is that when the app is bundled, the bundler tries to walk the Aurelia modules and fails with the following error:
Error on fetch for aurelia-framework at file:///Volumes/Data/Temp/aurelia-bundle-error/app/aurelia-framework.js
	Error: ENOENT, open '/Volumes/Data/Temp/aurelia-bundle-error/app/aurelia-framework.js'
    at Error (native)

Where the app.js looks like this:
var framework = require('aurelia-framework');
...

I found I could limit the scope of the app bundle by using the module syntax as described here:
var config = {
  ...
  bundles: {
    "dist/app-build": {
      includes: [
        '[*]',
        ...
      ],
      ...
    },
    ...
};

Anyways, I'm wondering if I'm doing something wrong, something has changed or if the blog post is not right. I pushed a repo that demonstrates this here.
Thx for all the help BTW. Aurelia rocks!

Something that was confusing to me (And this is not necessarily an Aurelia thing) are the paths in config.js and the bundle includes. Originally I was thinking the paths in the config.js were globs but they are not. Then I thought the bundler includes were globs, and they kinda are but you can't include extensions (Which evidently is a new thing). And then what's the relationship between the config.js path and the bundler includes? It's starting to become clearer but it's hard to track down info on this stuff and on top of it things are changing so fast. So what you think you understand today no longer applies to tomorrow (Literally today and tomorrow... O_o).
Anyways, point is that although Aurelia has been really straight forward, the underlying bits (Like SystemJS/jspm) have not been. I think it would really help uptake if the upcoming Aurelia documentation covered some of these details in addition to the Aurelia specific stuff.

@mikeobrien Aurelia bundle does not support [..] pattern yet. But we do support excludes : [ ] just like includes.
So here is one way to do what you are trying:

var aureliaLibs = [
        'aurelia-bootstrapper',
        'aurelia-fetch-client',
        ...
 ];

var config = {
  bundles: {
    "dist/app-build": {
      includes: [
        '*',
      ],
      excludes : aureliaLIbs.
    },
    "dist/aurelia": {
      includes: aureliaLibs,
      ...
    }
  }
};

Hmmm, I'm using the module syntax with the latest bits and it's working. AFAICT the bundle config is passed directly to the SystemJS bundler so Aurelia is not involved at that point. I could be missing something tho.

Yes, some of expression will work. For example:
var config = {
  bundles: {
    "dist/app-build": {
      includes: [
        'app/**/*',
      ],
      excludes : [ '[app/**/*]' ].
    }
};

This will create an app bundle excluding any external libraries.

What I'm seeing with the latest bits is that the following is creating an app bundle excluding any external libraries:
var config = {
  bundles: {
    "dist/app-build": {
      includes: [
        '[app/**/*]',
      ]
    }
};

No need for the exclude. In fact your config above will only include the external libraries, the opposite of what I'm trying to accomplish. This is consistent with what I'm seeing in the SystemJS docs.
Anyways, here's the point:

If I'm doing something wrong and you don't need to use the module syntax (As demonstrated in the blog post), I'd love to know what I'm doing wrong so I can fix it.
If you do need to use the module syntax above, the blog post needs to be updated otherwise people will get the error I mentioned.
If things have changed since the blog post and you now need to use the module syntax, again the blog post needs to be changed.

Bottom line is I'm trying to figure out if the blog post is wrong or if I'm doing something wrong and one of the two needs fixed.

You are right.

This will create an app bundle excluding any external libraries.

That's a wrong conclusion from my part. Apologies. I was not probably in my right mind.
var config = {
  bundles: {
    "dist/app-build": {
      includes: [
        'app/**/*',
      ],
      excludes : [ '[app/**/*]' ].
    }
};

This configuration should technically produce an aurelia bundle. app/**/* includes all the app module including the dependencies. [app/**/*] includes just the app modules. So the above configuration should produce a bundle of the dependencies only. (app/**/* - [app/**/*]).
But, in case of Aurelia it will not quite do that because all the Aurelia dependencies cannot be detected by static analysis of import or require statements. In some cases Aurelia loads modules dynamically. As of now those modules must be explicitly included in the bundle configuration.
So to answer your original question, you have this bundle config:
var config = {
  ...
  bundles: {
    "dist/app-build": {
      includes: [
        '*',
        ...
      ],
      ...
    },
    "dist/aurelia": {
      includes: [
        'aurelia-bootstrapper',
        'aurelia-fetch-client',
        ...
      ],
      ...
    }
  }
};

* here means everything in the app folder because you have a path config like:
 paths: {
    "*": "app/*",

Now, your app/app.js looks like:
var framework = require('aurelia-framework');

As you are requiring  aurelia-framework, that means one of two things here as long as module resolving is concern.

You have a map configuration in config.js that maps aurelia-framework to an installed module with version. eg: map : { "aurelia-framework"<EMAIL_ADDRESS>or
You have module in app/aurelia-framework because you have * : app/* path configured.

As, you don't have any file like app/aurelia-framewok and the map configuration is not there too, the bundler is throwing error.
What you probably want is to create a map in config.js with for aurelia-framework
It's not a bundler issue necessarily. Your app will not run with this configuration because SystemJS will fail to find aurelia-framework

Aaaahhh, ok that makes sense now. So when I was referencing aurelia-framework my config.js looked like this with no alias mapped to aurelia-framework:
system.config({
  ...
  map: {
    "aurelia-bootstrapper"<EMAIL_ADDRESS>    ...
<EMAIL_ADDRESS>{ ...
    }
});

I was thinking that that since the Aurelia framework module was downloaded as a dependency of the bootstrapper that the aurelia-framework alias would be automatically mapped but obviously that's not the case.
Also, makes sense now why you have to include the github:* modules in the bundle config. Didn't realize those were dynamically loaded.
Thanks for clarifying all that!


Create extract view

description of what view should do and files to be used.

View 10689 in SAFRWBTR environment 4 (DM12)

View ids 10689 is in Database=DM12; Schema=SAFRWBTR; SAFR Environment= Training Master(4).
The view is an Extract Phase view that looks up to the Order file and Product file and writes to DDName = DEXLKUPO.
Description of view: This view looks up to the Order file to obtain the Customer Id, Store Id and Order Total. It then does a lookup to the Product file to obtain the product description. It includes the Product Id, Product Price and Product Quantity sold on each order item.

View built.  Issue resolved.


Enhanced Settings System

Added in build 1.1.1369-dev.
The initial version of the new settings system is out. You can access with <Cmd/Ctrl>+Period.


*-mingw-dynamic triplet automatic detection does not work

Describe the bug
vcpkg toolchain for CMake fails to detect MinGW in two common use cases: when using Visual Studio 2022 configuration preset "Mingw64-Debug" and when using command line. *-windows is selected instead.
Environment

OS: Windows 11
vcpkg: 2023-03-29-664f8bb619b752430368d0f30a8289b761f5caba, PATH unmodified, vcpkg integrate install executed.
MinGW: w64devkit 1.18.0, GCC 11.2.0, installed into C:\msys64\mingw64, PATH unmodified.
CMake: 3.25.1-msvc1 when using VS2022 and 3.26.3, PATH unmodified, when using command line.

To Reproduce
A dummy CMake project is enough to trigger this problem:
cmake_minimum_required(VERSION 3.12)
project(test)

Steps to reproduce the behavior with Visual Studio:

Open project.
In Manage Configurations, add "Mingw64-Debug".
Generate CMake files.
Check CMakeCache.txt to see VCPKG_TARGET_TRIPLET is x64-windows.

Steps to reproduce the behavior from command line:
set Path=C:\msys64\mingw64\;%Path%
cmake -S . -B build -G "MinGW Makefiles" -DCMAKE_TOOLCHAIN_FILE=<vcpkg root>/scripts/buildsystems/vcpkg.cmake

Check build\CMakeCache.txt to see VCPKG_TARGET_TRIPLET is x64-windows.
Expected behavior
VCPKG_TARGET_TRIPLET should be set to x64-mingw-dynamic.
I assume this is intended behavior from vcpkg.cmake:342.
Failure logs
No relevant log files. No error messages appear. CMake logs show that the compiler is indeed gcc in both scenarios.
Additional context
vcpkg does indeed act on this incorrect triplet. As to be expected from VCPKG_TARGET_TRIPLET = x64-windows, packages installed for MinGW are not available.
vcpkg.cmake attempts to detect MinGW by checking CMake variable MINGW. However, as adding a simple
if (MINGW)
    message(WARNING "==== MinGW detected! ====")
endif()

demonstrates, when inserted right before the triplet detection code, that MINGW is not set when the toolchain file is executed. Inserting this check anywhere in CMakeLists.txt, however, shows that MINGW becomes set when user code begins execution. It seems logical to me that as toolchains may affect the choice of the compiler, CMake doesn't run MinGW detection until after toolchain file is completed.
It was suggested to me by @autoantwort that adding a check for MinGW Makefiles generator in vcpkg.cmake might solve this issue. However, this will fail to trigger if a different MinGW-compatible generator is used. In particular, this does not cover the Visual Studio case since it uses Ninja as the default generator in that preset.

Sorry for confusion, I will recreate this issue in the proper repo.

In particular, this does not cover the Visual Studio case since it uses Ninja as the default generator in that preset.

Do you have a suggestion how mingw could be detected in this situation?

I'm not too well-versed in how CMake internals work. I don't have any immediately implementable solution. There are a several hacks I could come up with, like checking compiler name for one, but they all have obvious flaws, which would lead to weird inconsistencies that could seriously confuse users.
In my opinion the only robust solution is to rely on CMake to detect that for us.
Option 1: delay triplet detection
Triplet detection could theoretically be deferred until CMake comes up with an answer naturally. For example, it could be triggered inside the various find_* modules - they will definitely execute after CMake has initialized. However, I'm pretty sure some configuration vcpkg performs is purely passive and must work immediately after the toolchain file is processed. In addition, this would result in a massive overhaul of the CMake integration structure, which does not look realistic.
Option 2: trigger CMake detection early
CMake's internal mechanism for detecting compilers should be available at runtime, and it may be possible to run it manually from vcpkg. This is easier to implement, but it may carry unintended side effects.

This issue hasn’t been updated in 3 month, if it is still an issue, please reopen this issue.

I tried to report something similar via #23607. The problem is this line:
https://github.com/microsoft/vcpkg/blob/45b0e4b5854bae6de9bfa1eeffbbad51bc1d19fe/scripts/buildsystems/vcpkg.cmake#L350
Specifically, it doesn't work because CMake itself doesn't populate that variable until sometime after the toolchain file processing stage.
Unfortunately my report was ultimately ignored, so I had to settle for a workaround of explicitly specifying the triplet in my development environment.

IMO "ignored" is not the right word for a community triplet.
#23607 has a pointer to #25529 which still needs to be picked up again, to align toolchain initialization with vcpkg tool behavior.


"Suggest follow-up questions" is not working

Please provide us with the following information:

This issue is for a: (mark with an x)
- [x] bug report -> please search issues before submitting
- [ ] feature request
- [ ] documentation issue or request
- [ ] regression (a behavior that used to work and stopped in a new release)

Minimal steps to reproduce

Select "Suggest follow-up questions" in Developer Settings.  I expect follow-up questions will pop up after chat response but there is no follow-up question.

Any log messages given by the failure

Expected/desired behavior

Select "Suggest follow-up questions" in Developer Settings.  I expect follow-up questions will pop up after chat response but there is no follow-up question.

OS and Version?

Windows 7, 8 or 10. Linux (which distribution). macOS (Yosemite? El Capitan? Sierra?)
Windows 11

azd version?

run azd version and copy paste here.

Versions 1.0.2

Mention any other details that might be useful

Thanks! We'll be in touch soon.

Thanks for filing, let's merge this issue with the older issue #240 and close this one. Please subscribe to that one.


[ Future request ] Test world option

just adding test world option in main menu, witch will automatically create a void world with platform, creative, command on, and other settings to hop right into making, and don't spend like 2min configuring the world to create

Enabling the IDEA plugin to create a Minecraft world would require introducing a lot of NBT editing libraries that would bloat the project. And automatically running the world would require launcher-like functionality, or embedding the launcher inside this IDEA plugin, which doesn't make sense since this plugin doesn't provide any launcher functionality.

No, I mean in mod. (In minecraft)

This seems to be a function of world generation and presupposition, which seems to have nothing to do with the design concept of this mod, my mod is simply using socket to accept external to debug command and datapack.


Converted RetrieveDiagnosisKeysTransaction to Task (Exposureapp-2908)

@harambasicluka couldn't reproduce, but think it's unrelated to this PR, will look into it, can you reproduce it on release/1.7.x? If so this can be merged and maybe you can message me repro steps .

@harambasicluka couldn't reproduce, but think it's unrelated to this PR, will look into it, can you reproduce it on release/1.7.x? If so this can be merged and maybe you can message me repro steps .

Testet on a working device, will retest on release/1.7.x.

Some error on release/1.7.x.


Automated cherry pick of #5392: fix: scoped resource should override FetchOwnerId

Cherry pick of #5392 on release/3.1.
#5392: fix: scoped resource should override FetchOwnerId

Codecov Report

:exclamation: No coverage uploaded for pull request base (release/3.1@13a3e1c). Click here to learn what that means.
The diff coverage is 0%.

@@              Coverage Diff              @@
##             release/3.1   #5393   +/-   ##
=============================================
  Coverage               ?   7.26%
=============================================
  Files                  ?     575
  Lines                  ?   97486
  Branches               ?       0
=============================================
  Hits                   ?    7084
  Misses                 ?   89832
  Partials               ?     570

Flag
Coverage Δ

#aFlag
7.26% <0%> (?)

Impacted Files
Coverage Δ

pkg/cloudcommon/db/scoperesource.go
0% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 13a3e1c...34b7d1e. Read the comment docs.


#1457 Detection of duplicated "generate" blocks in HCL files

Updated Terragrunt to detect generate blocks with duplicate name, fix for issue https://github.com/gruntwork-io/terragrunt/issues/1457
Example:
$ cat terragrunt.hcl
generate "backend" {
  path = "data.txt"
  if_exists = "overwrite"
  contents = "test data1"
}
generate "backend2" {
  path = "data2.txt"
  if_exists = "overwrite"
  contents = "test data2"
}
generate "backend" {
  path = "data.txt"
  if_exists = "overwrite"
  contents = "test data11"
}
generate "backend2" {
  path = "data2.txt"
  if_exists = "overwrite"
  contents = "test data22"
}

generate "backend3" {
  path = "data3.txt"
  if_exists = "overwrite"
  contents = "test data3"
}

$ terragrunt init
ERRO[0000] Detected generate blocks with the same name: [backend backend2]
ERRO[0000] Unable to determine underlying exit code, so Terragrunt will exit with error code 1

Included changes:

configuration loading updates
integration tests to cover this case

Ah, tests failed, but it's because of an unrelated bug where the test cases can't handle branch names with slashes in them: https://github.com/gruntwork-io/terragrunt/issues/1778. @denis256 Would you mind fixing that one first in a separate PR? Once that's resolved, we can pull master into your several other PRs and see if that gets the tests to pass. Thanks!

OK, https://github.com/gruntwork-io/terragrunt/pull/1799 is now merged. Could you pull in the latest from master?

Updated with changes from  #1799

Great, thanks! Re-running tests now.

https://github.com/gruntwork-io/terragrunt/releases/tag/v0.31.9


Firefox 41 disables the default (unreliable) STUN server

https://wiki.mozilla.org/Media/WebRTC/ReleaseNotes/41

Merged, thanks!


swiss https -> http

forgot they don't have a cert @wpride @gcapalbo

this kind of turned into a "fix" swiss session. it makes postgres connect to pgbouncer. it also properly changes the db hostname so that the postgres tasks aren't skipped over


Python Interactive Window 'Export As' button doesn't work

Bug: Notebook Editor, Interactive Window, Editor cells

Steps to cause the bug to occur
1. Ctrl+Shift+P: Specify local or remove Jupyter server... ( happens in both remote and local)
2. Ctrl+Shift+P: Create Python Interactive Window
3. Run some code : print("hello")
4. Click on button 'Export As', nothing happens.

Actual behavior
I couldn't upload a gif, but I uploaded a video
https://youtu.be/TbK3K2jHwLw
Expected behavior
Export as shows the dropdown menu and I can export te interactive window result as html, as usual

Your Jupyter and/or Python environment
Please provide as much info as you readily know

Jupyter server running: Local & Remote
Extension version: v2020.9.111407
VS Code version: 1.49.1
Setting python.jediEnabled: true | false (I don't see the option, but I see in my file system some jedi cache)
Setting python.languageServer: Microsoft
Python and/or Anaconda version: python 3.9.6/ conda n.a.
OS: Windows | Mac | Linux (distro): Ubuntu 18.04
Virtual environment:  N/A

Python Output

Microsoft Data Science for VS Code Engineering Team: @rchiodo, @IanMatthewHuff, @DavidKutu, @DonJayamanne, @greazer, @joyceerhl

Hi, I also encountered this problem.
I may can provide info but could you tell me how I can set "python.logging.level": "info" ?

@shikiponn, you can set this by doing the following steps:

Type Ctrl+Shift+P to bring up the command palette
Type 'Open Settings (JSON)'
Add "python.logging.level": "info" anywhere in the settings.json file
Reload VS Code

Now when you repeat the repro steps you provided above, you should get more detailed logs in your Python output tab.
Thanks for your help!

@joyceerhl
I just followed your step and after that I did,

Ctrl+Shift+P > Reload window
Started new Python interactive
Ran : print("hello")
Click on button 'Export As'

which gave me,

Seems Export as gives me no output in Python OUTPUT.

Python output updated, shall I better add I file instead of the paste ? because is huge and not so easy to ready imo.

@picatostas yes please, and you can upload the logs as a text file in your comment by dragging and dropping them! Thanks again for being willing to debug this with us!

@picatostas and @shikiponn could you also check what version of nbconvert you have in your target environment?

pycodestyle :  Version: 2.3.1
flake8 :  Version: 3.5.0
autopep8 :  Version: 1.5.4
pyflakes :  Version: 2.2.0
ipython :  Version: 5.5.0
jupyter-nbconvert :  Version: 5.6.1

The version I'm using is,
nbconvert                 6.0.5            py38h32f6830_0    conda-forge

@shikiponn There is a known issue with nbconvert version 6.0+, which just came out Sept 10th. I have a fix currently in PR for that. But for export to work I think that you would currently need to downgrade back to version 5.6.1 which was the last version before the 6.0 update.
@picatostas I'm not going to close this issue, because for you it looks like you are still using 5.6.1 so it's not the 6.0 issue for you.

@IanMatthewHuff Thanks, let me try with 5.6.1

@picatostas the version of nbconvert that you listed. We actually use nbconvert that might be installed into a different environment than the one that your notebook is executing. If you run the command "Python: Select interpreter to start Jupyter server" can you check the version of nbconvert in that environment as well?

I've tried Export as with nbconvert of version 5.6.1 but in vain.
Tail of my log is,
Info 2020-10-02 10:08:20: Finished waiting for idle on (kernel): 35a7a9a6-70e0-4772-a60a-276356410fd5 -> idle
Info 2020-10-02 10:08:22: Attempting to start a server because of preload conditions ...
Info 2020-10-02 10:08:23: Submitting code for c6bbec9d-7b9d-495f-bb18-5bf5fa308e0c
Info 2020-10-02 10:08:23: Kernel switching to busy
Info 2020-10-02 10:08:24: Kernel switching to idle
Info 2020-10-02 10:08:24: Finished execution for 21138cdf-48a4-4e65-a63f-0eba817fb56a
Info 2020-10-02 10:09:10: Submitting code for c6bbec9d-7b9d-495f-bb18-5bf5fa308e0c
Info 2020-10-02 10:09:10: Kernel switching to busy
Info 2020-10-02 10:09:10: Kernel switching to idle
Info 2020-10-02 10:09:10: Finished execution for d87c0a05-58d0-4f27-b031-c53bf3dc9dbb
Info 2020-10-02 10:09:38: Cached data exists getEnvironmentVariables, extension-output-#4

Any info I can provide more than this?

In the remote enviroment I have a raspberry Pi 4  with:
nb-convert: Version 5.6.1
pycodestyle : Version: 2.4.0
flake8 : Version: 3.6.0
pyflakes : Version: 2.0.0
ipython : Version: 7.14.0
python: version: 3.7.3
I would like to add, that before it broke, I installed autopep8 extension in VSCode https://marketplace.visualstudio.com/items?itemName=himanoa.Python-autopep8
which made me downgrade pyflakes and pycodestyle, I don't remember which versions I had before, but maybe it gives a lead.

There was a second issue with the interactive window exporting. My PR here should resolve this and we'll look at getting it into a fix quick. https://github.com/microsoft/vscode-python/pull/14224

I saw that the fix has been merged, how can I test it ?

@picatostas sorry didn't see this last message come in right away. You should be able to see this issue by checking out our development build here:
https://github.com/microsoft/vscode-python/blob/main/CONTRIBUTING.md#development-build

Actually, we just did a point release in our extension. I ported that fix in there so you don't need the dev build. Just check for an update to the main extension.

With the latest update issue has been solved


Inline friend

"Friend functions defined inside class declarations are not considered in the scope of the enclosing class; they are in file scope."
Is above correct ?
//declaration in tip1.h
class tip1
{
....
public:
static  float   basictax;
.....................
static float test1(float t) {
	return addtotaxpu(t);
}

};
// Usage: in main.cpp
void main(){
tip1 testFriends;
testFriends.test();
}
Error	LNK2001	unresolved external symbol "public: static float tip1::basictax" (?basictax@tip1@@2MA)

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 52ffaf97-4abe-683a-cb75-78a33bdb7bcf
Version Independent ID: f5ef91c6-d8f7-75a8-92ec-3fd46b4cfe99
Content: friend (C++)
Content Source: docs/cpp/friend-cpp.md
Product: visual-cpp
GitHub Login: @mikeblome
Microsoft Alias: mblome

@lunidev you are correct. topic fix should appear by JUly 15.


Fix dict handling. Python throws AttributeError, not KeyError.

Actually I have only tested the case for LogstashFormatterV1. Looking at the former instance of KeyError it seems that msg is always a string (?), so not sure which exception should be handled.


Integer input with commas

Laravel Version: 5.6
Voyager Version: 1.1
PHP Version:
Database Driver & Version:

Description: Some of my number inputs are BIGINT, reflecting money value. When inputing, I want separating commas to be shown, like "2,344,122" , not just "2344122" which might be wrong if there're many zeroes.
How do I do so ?

Closing as a duplicate of https://github.com/the-control-group/voyager/issues/3326


feature: silently update desktop app

Details

Press Update in Update required modal should automatically check and install the latest update in the background.
Fixed Issues

$ https://github.com/Expensify/App/issues/39526
PROPOSAL: https://github.com/Expensify/App/issues/39526#issuecomment-2044047518
Tests

Modify package.json's version to 1.4.57-5 (the minimum required version since the group chat releases)
In build-desktop.sh, omit the --publish always param (to disable Apple's notarization process)
Build with npm run desktop-build
Install the build
Open App
Press Update
Verify a dialog shows Update Available
Press Sounds good

[x] Verify that no errors appear in the JS console

Offline tests

NA
QA Steps

Precondition: Desktop app's version is 1.4.57-5 or below.

Open App
Press Update
Verify a dialog shows Update Available
Press Sounds good
Verify after a while, app is restarted
Press New Expensify menu >> About New Expensify
Verify the version is the latest production build

[x] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label and/or tagged @Expensify/design so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

https://github.com/Expensify/App/assets/153004152/b9614999-e192-4231-9990-3ac4812289c6

Android: mWeb Chrome

https://github.com/Expensify/App/assets/153004152/91fc0e56-5ca6-404f-873f-d1c3693f1465

iOS: Native

https://github.com/Expensify/App/assets/153004152/d1f7ed1d-4d36-4502-97ba-b5f585742835

iOS: mWeb Safari

https://github.com/Expensify/App/assets/153004152/6669158a-92c0-4d4c-9f8e-f74bf61940ff

MacOS: Chrome / Safari

https://github.com/Expensify/App/assets/153004152/48190574-6012-43db-8ea4-4fef8b99820d

MacOS: Desktop

https://github.com/Expensify/App/assets/153004152/dedf717f-eb8f-4128-a396-bde54059ca51

Added label & kicked off build 👍  - https://github.com/Expensify/App/actions/runs/8717438546

Note that we can use console.log in main.ts but the log output will be written in ~/Library/Logs/new.expensify.desktop/main.log.
Also note that in order to build desktop, you need to omit the --publish always option here.

Ooh these are pretty interesting suggestions, would you mind bringing these up in #expensify-open-source so we can hopefully make that script better? I'm honestly not super well versed with that script so it could be great to start a convo in slack so more people can see your suggestions 🙏

@gijoe0295 Any update here?

Before I test this solution by using dialog.showMessageBox as @gijoe0295's suggestion
cc @Beamanator

@gijoe0295  I think we should use a tricky way to test this PR on dev ( using dialog.showMessageBox to see log) and leave the rest to the QA team after this PR is deployed
@Beamanator What do you think about this way?

@DylanDylann To be honest i don't know how that works, but feel free to try it!!

Test well
https://github.com/Expensify/App/assets/141406735/3cb61700-9238-4845-8d85-b8950cd826e4
I change somethings to test this PR manually
diff --git a/desktop/main.ts b/desktop/main.ts
index be3d8722fa..85506eed3a 100644
--- a/desktop/main.ts
+++ b/desktop/main.ts
@@ -139,10 +139,12 @@ const manuallyCheckForUpdates = (menuItem?: MenuItem, browserWindow?: BrowserWin
     autoUpdater
         .checkForUpdates()
         .catch((error) => {
+            dialog.showMessageBox({message: "error"});
             isSilentUpdating = false;
             return {error};
         })
         .then((result) => {
+            dialog.showMessageBox({message: "successful"});
             const downloadPromise = result && 'downloadPromise' in result ? result.downloadPromise : undefined;

             if (!browserWindow) {
@@ -615,6 +617,7 @@ const mainWindow = (): Promise<void> => {

                 // Automatically check for and install the latest version in the background
                 ipcMain.on(ELECTRON_EVENTS.SILENT_UPDATE, () => {
+                    dialog.showMessageBox({message: "trigger SLIENT UPDATE event"});
                     if (isSilentUpdating) {
                         return;
                     }
diff --git a/src/App.tsx b/src/App.tsx
index 6316fa80fb..27ebfb08b1 100644
--- a/src/App.tsx
+++ b/src/App.tsx
@@ -54,6 +54,10 @@ const fill = {flex: 1};
 function App({url}: AppProps) {
     useDefaultDragAndDrop();
     OnyxUpdateManager();
+    const ErrorComponent = () => {
:...skipping...
diff --git a/desktop/main.ts b/desktop/main.ts
index be3d8722fa..85506eed3a 100644
--- a/desktop/main.ts
+++ b/desktop/main.ts
@@ -139,10 +139,12 @@ const manuallyCheckForUpdates = (menuItem?: MenuItem, browserWindow?: BrowserWin
     autoUpdater
         .checkForUpdates()
         .catch((error) => {
+            dialog.showMessageBox({message: "error"});
             isSilentUpdating = false;
             return {error};
         })
         .then((result) => {
+            dialog.showMessageBox({message: "successful"});
             const downloadPromise = result && 'downloadPromise' in result ? result.downloadPromise : undefined;

             if (!browserWindow) {
@@ -615,6 +617,7 @@ const mainWindow = (): Promise<void> => {

                 // Automatically check for and install the latest version in the background
                 ipcMain.on(ELECTRON_EVENTS.SILENT_UPDATE, () => {
+                    dialog.showMessageBox({message: "trigger SLIENT UPDATE event"});
                     if (isSilentUpdating) {
                         return;
                     }
diff --git a/src/App.tsx b/src/App.tsx
index 6316fa80fb..27ebfb08b1 100644
--- a/src/App.tsx
+++ b/src/App.tsx
@@ -54,6 +54,10 @@ const fill = {flex: 1};
 function App({url}: AppProps) {
     useDefaultDragAndDrop();
     OnyxUpdateManager();
+    const ErrorComponent = () => {
+        throw new Error('Error in ErrorComponent');
+        // This will throw an error when the component renders
+      };
     return (
         <InitialURLContextProvider url={url}>
             <GestureHandlerRootView style={fill}>
@@ -88,9 +92,12 @@ function App({url}: AppProps) {
                 >
                     <CustomStatusBarAndBackground />
                     <ErrorBoundary errorMessage="NewExpensify crash caught by error boundary">
-                        <ColorSchemeWrapper>
+                        {/* <ColorSchemeWrapper>
                             <Expensify />
                         </ColorSchemeWrapper>
+                         */}
+
+                         <ErrorComponent />
                     </ErrorBoundary>
                 </ComposeProviders>
             </GestureHandlerRootView>
:...skipping...
diff --git a/desktop/main.ts b/desktop/main.ts
index be3d8722fa..85506eed3a 100644
--- a/desktop/main.ts
+++ b/desktop/main.ts
@@ -139,10 +139,12 @@ const manuallyCheckForUpdates = (menuItem?: MenuItem, browserWindow?: BrowserWin
     autoUpdater
         .checkForUpdates()
         .catch((error) => {
+            dialog.showMessageBox({message: "error"});
             isSilentUpdating = false;
             return {error};
         })
         .then((result) => {
+            dialog.showMessageBox({message: "successful"});
             const downloadPromise = result && 'downloadPromise' in result ? result.downloadPromise : undefined;

             if (!browserWindow) {
@@ -615,6 +617,7 @@ const mainWindow = (): Promise<void> => {

                 // Automatically check for and install the latest version in the background
                 ipcMain.on(ELECTRON_EVENTS.SILENT_UPDATE, () => {
+                    dialog.showMessageBox({message: "trigger SLIENT UPDATE event"});
                     if (isSilentUpdating) {
                         return;
                     }
diff --git a/src/App.tsx b/src/App.tsx
index 6316fa80fb..27ebfb08b1 100644
--- a/src/App.tsx
+++ b/src/App.tsx
@@ -54,6 +54,10 @@ const fill = {flex: 1};
 function App({url}: AppProps) {
     useDefaultDragAndDrop();
     OnyxUpdateManager();
+    const ErrorComponent = () => {
+        throw new Error('Error in ErrorComponent');
+        // This will throw an error when the component renders
+      };
     return (
         <InitialURLContextProvider url={url}>
             <GestureHandlerRootView style={fill}>
@@ -88,9 +92,12 @@ function App({url}: AppProps) {
                 >
                     <CustomStatusBarAndBackground />
                     <ErrorBoundary errorMessage="NewExpensify crash caught by error boundary">
-                        <ColorSchemeWrapper>
+                        {/* <ColorSchemeWrapper>
                             <Expensify />
                         </ColorSchemeWrapper>
+                         */}
+
+                         <ErrorComponent />
                     </ErrorBoundary>
                 </ComposeProviders>
             </GestureHandlerRootView>
diff --git a/src/components/ErrorBoundary/BaseErrorBoundary.tsx b/src/components/ErrorBoundary/BaseErrorBoundary.tsx
index 75f65a06a2..3a36f91822 100644
--- a/src/components/ErrorBoundary/BaseErrorBoundary.tsx
+++ b/src/components/ErrorBoundary/BaseErrorBoundary.tsx
@@ -24,7 +24,7 @@ function BaseErrorBoundary({logError = () => {}, errorMessage, children}: BaseEr
      return (
         <ErrorBoundary
-            fallback={updateRequired ? <UpdateRequiredView /> : <GenericErrorPage />}
+            fallback={true ? <UpdateRequiredView /> : <GenericErrorPage />}
             onError={catchError}
         >
             {children}
diff --git a/src/libs/actions/AppUpdate/updateApp/index.desktop.ts b/src/libs/actions/AppUpdate/updateApp/index.desktop.ts
index 5c1ecbe057..873577b03a 100644
--- a/src/libs/actions/AppUpdate/updateApp/index.desktop.ts
+++ b/src/libs/actions/AppUpdate/updateApp/index.desktop.ts
@@ -1,5 +1,7 @@
 import ELECTRON_EVENTS from '@desktop/ELECTRON_EVENTS';

 export default function updateApp() {
+    console.log("Start Updating")
+
     window.electron.send(ELECTRON_EVENTS.SILENT_UPDATE);
 }
:

Reviewer Checklist

[ ] I have verified the author checklist is complete (all boxes are checked off).
[ ] I verified the correct issue is linked in the ### Fixed Issues section above
[ ] I verified testing steps are clear and they cover the changes made in this PR

[ ] I verified the steps for local testing are in the Tests section
[ ] I verified the steps for Staging and/or Production testing are in the QA steps section
[ ] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[ ] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[ ] I checked that screenshots or videos are included for tests on all platforms
[ ] I included screenshots or videos for tests on all platforms
[ ] I verified tests pass on all platforms & I tested again on:

[ ] Android: Native
[ ] Android: mWeb Chrome
[ ] iOS: Native
[ ] iOS: mWeb Safari
[ ] MacOS: Chrome / Safari
[ ] MacOS: Desktop

[ ] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[ ] I verified proper code patterns were followed (see Reviewing the code)

[ ] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[ ] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[ ] I verified that comments were added to code that is not self explanatory
[ ] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[ ] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[ ] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[ ] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[ ] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[ ] I verified the JSDocs style guidelines (in STYLE.md) were followed

[ ] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[ ] I verified that this PR follows the guidelines as stated in the Review Guidelines
[ ] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[ ] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[ ] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[ ] If a new component is created I verified that:

[ ] A similar component doesn't exist in the codebase
[ ] All props are defined accurately and each prop has a /** comment above it */
[ ] The file is named correctly
[ ] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[ ] The only data being stored in the state is data necessary for rendering and nothing else
[ ] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[ ] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[ ] All JSX used for rendering exists in the render method
[ ] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[ ] If any new file was added I verified that:

[ ] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[ ] If a new CSS style is added I verified that:

[ ] A similar style doesn't already exist
[ ] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)

[ ] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[ ] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[ ] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[ ] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[ ] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:

[ ] I verified that all the inputs inside a form are aligned with each other.
[ ] I added Design label and/or tagged @Expensify/design so the design team can review the changes.

[ ] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[ ] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[ ] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

@Beamanator Bump, could you help to take a look at this PR?

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@b1tjoy @Beamanator Could someone internally verify this PR? Unfortunately, we don't have anyone with the Desktop app's version 1.4.57-5 and below.

🚀 Deployed to production by https://github.com/marcaaron in version: 1.4.71-6 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


Edit callhome in running datastore query

More of a query than a issue - is it possible to dynamically initiate callhome without restarting sysrepo/netopeer?
I am working on a project where we wish to initiate multiple callhomes to client connections.  We have been writing callhome parameters to the startup datastore and restarting to copy the parameters from startup to running and initiate the connections which works well.
However we would also like to be able to initiate an additional callhome connection while the application is running, without interrupting the existing connections (ie, without restarting sysrepo/netopeer).  When I try and write the callhome parameters directly into the running datastore this fails with a complaint about ietf-keystore.
Is this actually possible?  Any thoughts or suggestions?
Thanks for all the hard work!
Nick

Nevermind - I figured it out, just needed a subscription to ietf-keystore and it all works!


Notification rule is missing a root condition - Improve error message

getting this error message how to get rid of this, i have the root condition as shown above but it shows
Notification rule is missing a root condition!
i have just removed the userplus plugin and it is working fine now.

same problem

@saulo-silva are you using the UserPlus plugin as well?

Also has got this. Seems it's caused by uncompleted deferred binding of rule_conditions. First I was getting only rule_conditions records without rule_host_id. I'm not sure, but seems I've fixed this by resaving the notification rule in backend
http://prntscr.com/lqie4u

If someone can narrow down a cause and submit a PR to fix it that would be helpful.

i had same issue with automatic user activation by sending mail...
Something wrong with UserPlus plugin, it seems that some notification rule is created by the plugin without any rule_conditions...
Temporary solution would be to disable UserPlus plugin and disable Rain.notify plugin, but enable back notify plugin , all from backend...
This worked for me... wasted couple of hours searching though

i had same issue with automatic user activation by sending mail...
Something wrong with UserPlus plugin, it seems that some notification rule is created by the plugin without any rule_conditions...
Temporary solution would be to disable UserPlus plugin and disable Rain.notify plugin, but enable back notify plugin , all from backend...
This worked for me... wasted couple of hours searching though

Faced problem with error message "Notification rule is missing a root condition", tried solution explained above. But turn out, in this case, I can't create notification rule at all. After enabling UserPlus again and hit "Notification rules" in settings area I got fresh default rule with wrong template naming "welcome". And I can't create a new rule because of that.
And every time I hit "Notification rules" in settings I got fresh default rule over and over again. Something similar was discussed here: https://github.com/rainlab/notify-plugin/issues/3
Tried to reinstall all related plugins: UserPlus, Location and Notify. Not helped.
Environment:
Ubuntu 17.10
php 7.1
Build: 446

I also get this error message "Notification rule is missing a root condition". In my case, I found that I had only one rule in the "Notification rules" settings with root condition but two records in the "rainlab_notify_rule_conditions" table with the same class name. So, when the Notifier class fires the event it founds two records, one with root condition but another one without root condition and triggers the error. I think that one of the records was still there because a failed delete action or something. When I deleted this record the issue was fixed.

Fixed by #18


[FEATURE] Update local module references in manifests for ml-training-on-eks

Once a new release for ADDF and IDF are complete, update the local references in all manifests to gitpaths:
autonomous-driving-data-framework/manifests/ml-training-on-eks

This is dependent on https://github.com/awslabs/autonomous-driving-data-framework/issues/414


Support multiple targets

Hullo there, got a pretty simple one, our company uses multiple targets for different environments on iOS and Android projects:
Cool App (this one ships to the app store)
Cool App Test
Cool App UAT
You get the picture, rnpm currently only links to the main target or named target, not all targets (or the ability to select or nominate a target through the CLI) happy to help patch this one but wanted to get feedback from the squad before I dove in - I absolutely love rnpm :)

Hey,
That's reasonable case - haven't thought about it that much before. I think the easiest way would've been to make rnpm accept a flag specifying target name and just run it n times, for each target separately. I do understand that might be cumbersome but I am not sure if complicating rnpm-plugin-link logic is worth handling that case.
Aon the other hand - I don't have any opinion on that yet - so I am happy to listen to alternative approaches or ways to handle! Obviously - happy to collaborate on a PR since I am currently too busy to take that entirely on my own :)

After thinking about it for a while, I think we can expose an array of targets into config (which defaults to your main target) that you can override in order to have it run for them all.

:+1:

Another use-case - writing Unit tests (creating a target for tests) where you want to link something. Currently not supported. You should be able to pass in a target name as an argument, e.g. rnpm link --targetIOS ABC.
This is in progress.

Can you give us some update on it, @grabbou?

+1, very important


Changed Download link

I think we should change the download link from beta to nightly, since I feel that 90% of problems/questions people have with/about beta are answered with "download latest nightly" anyway.

Also we should consider removing the part that links to Chatterino 1


PDFReceipts: Block unauthenticated requests

Requires https://github.com/opencollective/opencollective-frontend/pull/7028

We should now be ready for this, will try to deploy it soon


Added Convert-ALCOutputToAzureDevOps to covert ALC.EXE output

to format used by Azure DevOps Pipelines.
Based on my code from https://dynamicsuser.net/nav/b/kine/posts/alc-exe-output-formatting-for-tfs-vsts

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: kine sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.


how to specify the store to publish ? ( performance issue )

Hi,  i have an image collection with multiple store ( original, thumbs, crops, etc ....) and i don't always need them all at the same time.  So it will be very interesting from a performance perspective to be able to choose the which store to publish each time.
Please is it possible ?

iirc you don't receive all the stores contents at all times.
Only the ones you ask for with {{url store='thumbs'}}
What exactly is the performance issue?


Where clause not working.

Below is my code, in which when soer_by found as a 'featured' it will apply where clause.
and unfortunately, it is not working. it is giving me a blank array.
I found that scout is only provided where clause on basic numeric equality checks. Since a search index is not a relational database, more advanced "where" clauses are not currently supported
But In this library, it is given that where clauses on a string value.
It would be appreciated if anyone could help me out.
below is my code
 $search = (!is_null($search) && $search != "")? $search: '*';
        $prods = Product::search($search);
        $prods->with(['category', 'allProductSku','productDefaultSku', 'productDefaultVariationSku',
            'productSkuImages',  'productImages','campaignExclusiveProducts.campaignRelation', 'vendorData'
        ]);
        if($category_id){
            $arrayCat = General::categoryPathArrayElasticSearch($category_id);
            $prods->whereIn('product_categorty.id',array_values($arrayCat));
        }
        if ($sort_by) {
            if ($sort_by == 'featured') {
                $prods->where('featured', 'Yes');
            } else if ($sort_by == 'asc' || $sort_by == 'desc') {
                $prods->orderBy('final_price', $sort_by);
            } else if ($sort_by == 'null') {
                $prods->orderBy('id','desc');
            }
        }
        $per_page =  ($per_page > 48) ? 48: $per_page;
        $prods = $prods->paginate($per_page);

I have solved my issue by storing featured column data in integer datatype in the elastic-search document and the where clause is working properly

Closing this issue since you figured out how to solve. Feel free to ask for a reopen if you think it's an issue.

But I want a solution for applying where clause for string or text value

@iget-esoares How I can perform a where clause with an UUID?

To make where() work need use property type keyword or add raw with keyword type for mapping.
'city' => [
    'type' => 'text',
    'fields' => [
        'raw' => [
            'type' => 'keyword',
        ]
    ]
]

$query->where('city.raw', 'CityName');
or
'city' => [
    'type' => 'keyword',
],

$query->where('city', 'CityName');


Add slots to database class to capture versioning

As part of the ETL, add versioning info to the database class. I have already created some stubs for this:
database:
...
      slot_usage:
      nmdc schema version:  <-- pulled from the nmdc.yaml file; I have a util to get this.
        description: >-
            TODO
      date created:  <-- date the database was created
        description: >-
            TODO
      etl software version: <-- requires versioning of our etl scripts
        description: >-
            TODO

Do we need others? @dehays @cmungall @dwinston @jeffbaumes @jbeezley

Good question! Do we need others? Otherwise we should close this issue as completed.

I don't think we're using these stubs. Where would the values go in MongoDB? The collections are populated with lists of instances in the range of the Database's aggregation slots.

I have removed this. All Database slots are now multi-valued and inlined-as-list. They all correspond to a MongoDB colelction.


fix CpuControl::start_app_core signature

I now understand why those lifetime bounds were there in the first place, sorry for removing them in 2f3b6c843ca6015c6e6feac8cfbd8c3c4a004c70.
Should I find a way to add a compile fail test?
It could look like this:
fn test(mut cpu_control: CpuControl) {
    let mut val = 0;

    let _guard = cpu_control.start_app_core(&mut || val = 1).unwrap();

    val = 2;
}

Thanks! If possible it would be nice to have a compile fail test so we don't revert this again :D. I don't think we do any testing in the hal right now, so if it is too much of a pain let me know and I'll merge it as is.

So I tried a couple of things:
cd esp32s3-hal/
cargo test # can't find crate for `test`

add #![cfg_attr(not(test), no_std)] at the top of esp32s3-hal\src\lib.rs
cargo test # can't find crate for `std`
cargo test --target x86_64-pc-windows-msvc # compilation fails because of inline assembly

Do you have other ideas I could try?

I think cargo test --target x86_64-pc-windows-msvc is very close but we'd need to not include the runtime if we are compiling for the host
Probably getting this to work is a bit beyond the scope of this PR (but feel free to explore this) - we can still create an issue for unit testing support since it might be helpful for other things (like clock divider calculation etc.)

I see. In that case I'd prefer to leave the PR as is :)


adds config option to indicate host validation should be disabled for cf ssh (-k flag)

We need this change to run dats against microPCF

@ekcasey @sclevine can you make sure you've both signed the CLA and made memberships public on github please

Merged, thanks. We will bump this dependency in CATS now

also @sclevine @ekcasey and @keaty FYI we've merged DATS into CATS

Thanks @robdimsdale! We just noticed that today and will be adjusting our CI accordingly.


Parse POP and host for different major open recursive resolver formats

(continuing from private conversation)
Each major open resolver has a slightly different way of reporting the POP and hostname with specific DNS queries:
Quad9 reports a hostname and a POP name in NSID for everything as an FQDN of format <hostname>.<pop_code>.suffix1.suffix2.tld (note: suffix1, suffix2, and TLD may change! Do not match on current values of rrdns.pch.net) and reports hostname and POP embedded in the DNS response in the same format if the request is "CH TXT id.server".  The person making the measurement can use any query. (The NSID value should be preferred by the script, as in very rare cases they might be different in the same result)
Cloudflare reports a hash of some sort in NSID for everything (hostname?) and reports POP in the DNS response if the request is "CH TXT id.server".  The DNS response should be the value used for Cloudflare; the person making the measurement needs to ensure that the query is for "CH TXT id.server".  The hash value goes into the sample_reported_host label, and whatever is the result of the DNS query (up to 15 characters) should go into the sample_reported_pop field.
Google  reports a string containing POP name ("gpdns-") in NSID for everything, and hands back SERVFAIL if the request is "CH TXT id.server".  The person making the measurement can use any query.  The sample_reported_host field should be set to whatever is the result of the DNS query (up to 15 characters) and the sample_reported_pop should be parsed from the NSID data to just the POP code.
My suggestion is that determining which of the three methods should be used should be optional for the user when they perform the ingestion, and it should be a function on the command line or config file. An automated recognition is not required and may create unexpected results.
So command line option like this:
--id.servermethod=[quad9,google,cloudflare]
default: quad9

commit f89048121eaad2d8e5c49592e3b16909bff346c0 please verify


Contribution guideline for newcomers

I'd like to be able to contribute to this project, but I don't really know how to get started. Would it be possible to provide some kind of architecture overview? I'd also love to see some recommendations on setting up the development environment and on how the changes are to be tested.

Hi ConjuringCoffee,

I'd like to be able to contribute to this project

That's great, happy to hear that!

Would it be possible to provide some kind of architecture overview?

Actually, that's already in the pipeline. There has already been such documentation during the Inner Source phase of the project, containing information on the object model of ABAP cleaner, how to create a new cleanup rule, how to write tests etc. This would hardly need to be reworked, apart from …

some recommendations on setting up the development environment

… so those might take a little longer.
Kind regards,
Jörg-Michael


feat: add infinite scrolling for Column and Row components

Hi @devis-velope, thanks for opening this issue. If you could please provide some context around the feature request, it'd be greatly appreciated. Keep in mind that at this time solid-ui is in prerelease as we continue to build out the foundations of the library. Any feature requests will be reviewed and backlogged(if deemed fit for addition to the library) once the foundation is complete.

Hello @anthony9187 . This feature is mostly an alternative for the scroll animation. When the user reaches the end of the component it should loop around and show the first few entries of the component again rather than jump all the way back to the start, for example when scrollWrap is enabled.

Would the row go back to the first item and start from the beginning? One issue with infinite loop is a11y - How would a user know they are at the end of the list? I think this is why we don't do this in any of our rows.

That's a good point, but that being the case, how is this situation handled with scrollWrap enabled? or do you guys refer to a more visual thing?
Having the option to use infinite scrolling would add an alternative for the component presentation. Could this be improved offering more options for a11y? "End of the list indicator" maybe?

ScrollWrap goes back to the first item - usually on rows that visually don't go past the size of the screen.

So due to the engineering requirements, we've usually avoided this sort of pattern. It often requires creating at least one extra set of the Row/Column's items to feign the loop, or some messy repositioning logic which winds up being a lot for an opt-in feature. Because of that, we'd would most likely add this as separate Carousel component. We still have a lot of ground work to cover before looking into something like this, but I won't rule out adding it in the future. We're also open to contributions if this is something you'd be interested in taking on!


Port to thiserror, release 0.7

Same motivation as https://github.com/containers/ocidir-rs/pull/16
Originally I split this out as a "quick library" and using anyhow was convenient, but since we're bumping semver let's port to thiserror.

Published https://crates.io/crates/containers-image-proxy/0.7.0


Documentation for customizing theme for v1 is missing

Bug Report
Describe the bug
There is no more doc to v1 for creating theme
To Reproduce

Go to https://www.docz.site/docs/creating-your-themes

Expected behavior
There is no more docs link to the v1 of docz. I'm currently using it, i can't afford to migrate right now (i have some webpack configurations that seems hard to migrate in a short time).
I juste need to intregrate a font right now, and the is no more doc for creating theme for v1.
You just CAN'T remove a whole documentation for your API like that.
You can add the depecation but you can't remove it. There is some people that will still need to see this docs.
In case someone also search for this doc. Here it is.
https://github.com/pedronauck/docz-website/blob/af65df11c83333c17d3176557522c8e6efdb3a1b/src/docs/documentation/references/creating-themes.mdx

I agree with you. I am also surprised how fast it went from v1 to v2...

Yes please keep the v1 docs alive somewhere! The project I am working on is also looking for them.

I deployed the v1.2 docs to : https://docz-v1.surge.sh/
Hope that helps !

Many thanks @rakannimer :) !

I also added a link to the docs in the readme here
Closing this issue, feel free to open a new issue if something is missing !

Perfect ! Thanks :)


Investigate scrollIntoView

We need to investigate scrollIntoView potential usage for things that are not handy when used with scrollUntilVisible (aka scrollTo()).

We've discussed this one and considered it not aligned with Patrol philosophy.

We found no use cases for this.


documentation of Page.url property mentions argument

See http://docs.wagtail.io/en/v2.0/reference/pages/model_reference.html#wagtail.core.models.Page.url

Accepts an optional but recommended request keyword argument that, if provided, will be used to cache site-level URL information (thereby avoiding repeated database / cache lookups) and, via the request.site attribute, determine whether a relative or full URL is most appropriate.

Hi @sir-sigurd, it is unclear to me what you are pointing out here, can you provide more information?
Arguably the function actually accepts 2 arguments (request and current_site) so it could probably be updated, but maybe you only want to point out that the documentation is not clear to you?

@loicteixeira
I want to point that 'argument' is meaningless in the documentation of Page.url since it's not callable.

Thanks for the report @sir-sigurd!
Fixed in 8d786c35349f097b1c9c8cdc5c36f81cb68386ec - as of #3354, the preferred way of obtaining a page URL in Python code is the get_url method. url is now just a wrapper around get_url, and this meant that the documentation (which was still referencing url) erroneously picked up the docstring from that method.


Installed the extension in VS 2022 Preview but nothing appears in solution context menu?

Followed the instructions to install the extension, and it is installed and enabled.
However, when I right-click the solution and go to 'Add' there is no 'Dapr Run File' option there? I've tried with an existing, and a brand new VS solution.
In addition, beyond adding a Dapr run file to the solution, what other features does the extension have?

@chrisrlewis Which version of VS and extension? What type of project did you add to the solution?

I faced same issue. After adding a new project to existing sln, "Project to Dapr Run File" option appeared.
My VS version : 17.8.3
Extension : 0.1.1204.2

I was having the same issue, was on VS 17.9.XX non prerelease. Had to move to 17.10.XX PreRelease version and it appeared.  I am currently stuck at "Waiting for Dapr to start processes..." the process does start as I'm able to call my web api, it just does not goto the debugger.

same issue here. VS2022 Version 17.10.0 with Dapr Extension <IP_ADDRESS>. There is no "Dapr Run File" in the "Add" option

@ggacura-h I've been able to reproduce your debugging hang; it was a race condition while waiting for Dapr to start the applications and .NET to start their respective underlying processes.  I have a fix for that and hope to get it out shortly.
@iqoOopi Under which node in Solution Explorer were you looking?  For a new ASP.NET project, with 17.9 or 17.10, you should see the option under both the solution and project nodes.  (Screenshots below are from 17.10.)

@philliphoff I do not see the option in neither the solution nor project nodes

I do not see the option in neither the solution nor project nodes

@iqoOopi Well that is, indeed, odd.  That's with 17.10.0 (GA, i.e. non-Preview)?  With which kind of solution/project?

Same here... no Solution or project level menu items. Visual studion 17.10.1:

Below is the Info from "About Visual Studio"
Microsoft Visual Studio Professional 2022
Version 17.10.1
VisualStudio.17.Release/17.10.1+34928.147
Microsoft .NET Framework
Version 4.8.09032
Installed Version: Professional
Visual C++ 2022   00476-80000-00000-AA710
Microsoft Visual C++ 2022
ADL Tools Service Provider   1.0
This package contains services used by Data Lake tools
ASA Service Provider   1.0
ASP.NET and Web Tools   17.10.338.1105
ASP.NET and Web Tools
Azure App Service Tools v3.0.0   17.10.338.1105
Azure App Service Tools v3.0.0
Azure Data Lake Tools for Visual Studio   2.6.5000.0
Microsoft Azure Data Lake Tools for Visual Studio
Azure Functions and Web Jobs Tools   17.10.338.1105
Azure Functions and Web Jobs Tools
Azure Stream Analytics Tools for Visual Studio   2.6.5000.0
Microsoft Azure Stream Analytics Tools for Visual Studio
C# Tools   4.10.0-3.24270.2+e8f775c1d8a73dee7ad02408712d714251e708ea
C# components used in the IDE. Depending on your project type and settings, a different version of the compiler may be used.
Code alignment   <IP_ADDRESS>
Code alignment helps you present your code beautifully, enhancing clarity and readability.
CodeRush for Roslyn   <IP_ADDRESS>
DevExpress CodeRush for Roslyn package.
CodeRush for Roslyn Tool Windows   <IP_ADDRESS>
DevExpress CodeRush for Roslyn Tool Windows package.
Common Azure Tools   1.10
Provides common services for use by Azure Mobile Services and Microsoft Azure Tools.
Cookiecutter   17.0.24064.1
Provides tools for finding, instantiating and customizing templates in cookiecutter format.
Entity Framework Core Power Tools   2.6
Adds useful design-time EF Core DbContext features to the Visual Studio Solution Explorer context menu.
Extensibility Message Bus   1.4.39 (main@e8108eb)
Provides common messaging-based MEF services for loosely coupled Visual Studio extension components communication and integration.
File Icons   2.7
Adds icons for files that are not recognized by Solution Explorer
GitHub Copilot   0.2.889.30432
GitHub Copilot is an AI pair programmer that helps you write code faster and with less work.
Linux Core Dump Debugging   <IP_ADDRESS>902
Enables debugging of Linux core dumps.
Markdown Editor v2   2.0.162
A full featured Markdown editor with live preview and syntax highlighting. Supports GitHub flavored Markdown.
Microsoft Azure Hive Query Language Service   2.6.5000.0
Language service for Hive query
Microsoft Azure Stream Analytics Language Service   2.6.5000.0
Language service for Azure Stream Analytics
Microsoft Azure Tools for Visual Studio   2.9
Support for Azure Cloud Services projects
Microsoft JVM Debugger   1.0
Provides support for connecting the Visual Studio debugger to JDWP compatible Java Virtual Machines
Mono Debugging for Visual Studio   17.10.8 (a565b86)
Support for debugging Mono processes with Visual Studio.
Node.js Tools   1.5.60329.1 Commit Hash:15fce86a17f9f33e5bd7ca7ccb9b216aff149252
Adds support for developing and debugging Node.js apps in Visual Studio
NuGet Package Manager   6.10.0
NuGet Package Manager in Visual Studio. For more information about NuGet, visit https://docs.nuget.org/
Office Developer Tools for Visual Studio   17.10.34627.00
Microsoft Office Developer Tools for Visual Studio
Python - Django support   17.0.24064.1
Provides templates and integration for the Django web framework.
Python - Profiling support   17.0.24064.1
Profiling support for Python projects.
Python with Pylance   17.0.24064.1
Provides IntelliSense, projects, templates, debugging, interactive windows, and other support for Python developers.
Razor (ASP.NET Core)   <IP_ADDRESS>7201+4f57d1de251e654812adde201c0265a8ca7ca31d
Provides languages services for ASP.NET Core Razor.
SQL Server Data Tools   <IP_ADDRESS>
Microsoft SQL Server Data Tools
Test Adapter for Boost.Test   1.0
Enables Visual Studio's testing tools with unit tests written for Boost.Test.  The use terms and Third Party Notices are available in the extension installation directory.
Test Adapter for Google Test   1.0
Enables Visual Studio's testing tools with unit tests written for Google Test.  The use terms and Third Party Notices are available in the extension installation directory.
ToolWindowHostedEditor   1.0
Hosting json editor into a tool window
TypeScript Tools   17.0.30327.2001
TypeScript Tools for Microsoft Visual Studio
Visual Basic Tools   4.10.0-3.24270.2+e8f775c1d8a73dee7ad02408712d714251e708ea
Visual Basic components used in the IDE. Depending on your project type and settings, a different version of the compiler may be used.
Visual C++ for Cross Platform Mobile Development (Android)   15.0.34804.30
Visual C++ for Cross Platform Mobile Development (Android)
Visual C++ for Linux Development   <IP_ADDRESS>902
Visual C++ for Linux Development
Visual F# Tools   17.10.0-beta.24228.1+dd749058c91585e9b5dae62b0f8df892429ee28f
Microsoft Visual F# Tools
Visual Studio IntelliCode   2.2
AI-assisted development for Visual Studio.
Visual Studio Tools for Unity   <IP_ADDRESS>
Visual Studio Tools for Unity
VisualStudio.DeviceLog   1.0
Information about my package
VisualStudio.Mac   1.0
Mac Extension for Visual Studio
Workflow Manager Tools 1.0   1.0
This package contains the necessary Visual Studio integration components for Workflow Manager.
Xamarin   <IP_ADDRESS> (main@cf2e960)
Visual Studio extension to enable development for Xamarin.iOS and Xamarin.Android.
Xamarin Designer   <IP_ADDRESS> (remotes/origin/d17-10@3beef58f89)
Visual Studio extension to enable Xamarin Designer tools in Visual Studio.
Xamarin Templates   17.9.0 (38e87ba)
Templates for building iOS, Android, and Windows apps with Xamarin and Xamarin.Forms.
Xamarin.Android SDK   <IP_ADDRESS> (d17-5/45b0e14)
Xamarin.Android Reference Assemblies and MSBuild support.
Mono: d9a6e87
Java.Interop: xamarin/java.interop/d17-5@149d70fe
SQLite: xamarin/sqlite/3.40.1@68c69d8
Xamarin.Android Tools: xamarin/xamarin-android-tools/d17-5@ca1552d
Xamarin.iOS and Xamarin.Mac SDK   <IP_ADDRESS> (9defd91b3)
Xamarin.iOS and Xamarin.Mac Reference Assemblies and MSBuild support.

@AppKajBonfils That's unfortunate. I tested a new machine with 17.10.1 (non-preview) and am able to see the commands on a new ASP.NET solution/project.  It's always possible that multiple extensions can interfere with each other (e.g. when they try to load conflicting versions of assemblies in to the VS process, so you might try disabling as many extensions other than the Dapr one just to see if that could be the issue.
What kind of solution/project were you testing with?

I have disabled all my extensions and reinstalled the the dapr extension. That worked – even after re-enabling all my extensions. Its hard to say which extension that caused the problem, but obviously there were some kind of conflict.
-Kaj
Fra: Phillip Hoff @.>
Sendt: 30. maj 2024 19:12
Til: microsoft/vs-dapr @.>
Cc: Kaj Bonfils @.>; Mention @.>
Emne: Re: [microsoft/vs-dapr] Installed the extension in VS 2022 Preview but nothing appears in solution context menu? (Issue #9)
@AppKajBonfilshttps://github.com/AppKajBonfils That's unfortunate. I tested a new machine with 17.10.1 (non-preview) and am able to see the commands on a new ASP.NET solution/project. It's always possible that multiple extensions can interfere with each other (e.g. when they try to load conflicting versions of assemblies in to the VS process, so you might try disabling as many extensions other than the Dapr one just to see if that could be the issue.
What kind of solution/project were you testing with?
—
Reply to this email directly, view it on GitHubhttps://github.com/microsoft/vs-dapr/issues/9#issuecomment-2140314619, or unsubscribehttps://github.com/notifications/unsubscribe-auth/BHTPQVRUGA7MNMVDFFKEMS3ZE5MVTAVCNFSM6AAAAABA7Y5I6SVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNBQGMYTINRRHE.
You are receiving this because you were mentioned.Message ID<EMAIL_ADDRESS>

@AppKajBonfils Glad you resolved the issue.  The downside to in-process extensions is that they can conflict in strange ways depending on their starting order. Unfortunately, the new VS extensibility model doesn't allow me to move everything out of process (yet).


[improve][doc] Document configuration added by PIP-145

Master Issue: #14505
Motivation
Documentation for the new configuration properties was missing when the feature was merged.
Modifications
Added the new configuration properties to standalone.conf and broker.conf. Also, added documentation to site2/docs/reference-configuration.md .
Verifying this change

[x] Make sure that the change passes the CI checks.

This change is a trivial rework / code cleanup without any test coverage.
Does this pull request potentially affect one of the following parts:
If yes was chosen, please highlight the changes

Dependencies (does it add or upgrade a dependency): (no)
The public API: (no)
The schema: (no)
The default values of configurations: (no)
The wire protocol: (no)
The rest endpoints: (no)
The admin cli options: (no)
Anything that affects deployment: (no)

Documentation

[X] doc

/pulsarbot rerun-failure-checks

/pulsarbot rerun-failure-checks

/pulsarbot run-failure-checks


config: make pd and tikv use github permission

ref: https://github.com/tikv/community/pull/122

/hold

/unhold

/hold

cc: @BusyJay @nolouch
Could you please take a look?

@BusyJay Thanks for your review!

/merge

/unhold


External CA support

Hey,
Thanks for the great module. I'm working on getting external CA support working (e.g. for integration with FreeIPA and certmonger) and was hoping to have the feature merged. There's quite a lot of changes so I'm splitting it into multiple commits.
Cheers

Thanks a lot for your work! I finally got the time to review it. I am really sorry for the way too long delay! There was too much going on here...
I added just two comments, could you please address them? Could you also check the merge conflicts which occurred as I merged another PR? Thanks in advance!

This will be continued in #181.


Not working with Elixir 1.5?

Seems to have stopped working with Elixir 1.5?
Running Linux. Console log:
[atom-elixir] Activating atom-elixir version 0.2.3
/home/adam/.atom/packages/autocomplete-elixir/lib/alchemide/wrapper.coffee:54 /usr/local/bin/
/home/adam/.atom/packages/sync-settings/lib/sync-settings.coffee:93 checking latest backup...

[atom-elixir] warning: String.to_char_list/1 is deprecated, use String.to_charlist/1
  /home/adam/.atom/packages/atom-elixir/lib/elixir_sense/lib/elixir_sense/core/source.ex:10

warning: String.to_char_list/1 is deprecated, use String.to_charlist/1
  /home/adam/.atom/packages/atom-elixir/lib/elixir_sense/lib/alchemist/helpers/complete.ex:21

warning: String.to_char_list/1 is deprecated, use String.to_charlist/1
  /home/adam/.atom/packages/atom-elixir/lib/elixir_sense/lib/alchemist/helpers/complete.ex:134

warning: String.rstrip/1 is deprecated, use String.trim_trailing/1
  /home/adam/.atom/packages/atom-elixir/lib/elixir_sense/lib/alchemist/server.ex:36

Initializing ElixirSense server for environment "dev" (Elixir version 1.5.0)
Working directory is "/home/adam/Dev/polo"

/home/adam/.atom/packages/atom-elixir/lib/server-process.coffee:227 Server busy!
/home/adam/.atom/packages/atom-elixir/lib/server-process.coffee:59 Retrying last request when busy
/home/adam/.atom/packages/atom-elixir/lib/server-process.coffee:227 Server busy!
/home/adam/.atom/packages/atom-elixir/lib/server-process.coffee:59 Retrying last request when busy
server-process.coffee [sm]:166 Server busy!
server-process.coffee [sm]:47 Retrying last request when busy

Huh. Seems to be working again, but still getting errors in the log about the server being busy.


Type inference works in "normal mode" but fails in lax mode (hence in dependency loading)

See the following example
A.fst:
module A

assume val bytes_like: Type0 -> Type0

assume val parser_serializer: bytes:Type0 -> pf:bytes_like bytes -> Type0 -> Type0

assume val bind: #bytes:Type0 -> #pf:bytes_like bytes -> #a:Type0 -> #b:(a -> Type0) -> ps_a:parser_serializer bytes pf a -> ps_b:(xa:a -> parser_serializer bytes pf (b xa)) -> parser_serializer bytes pf (dtuple2 a b)

assume val ps_unit: #bytes:Type0 -> #pf:bytes_like bytes -> parser_serializer bytes pf unit
assume val key: bytes:Type0 -> pf:bytes_like bytes -> Type0
assume val ps_key: #bytes:Type0 -> #pf:bytes_like bytes -> parser_serializer bytes pf (key bytes pf)

val ps_test: #bytes:Type0 -> #pf:bytes_like bytes -> parser_serializer bytes pf (x:unit & (y:key bytes pf & key bytes pf))
let ps_test #bytes #pf =
  ps_unit;;
  ps_key;;
  ps_key

//Workaround:
//let ps_test #bytes #pf =
//  ps_unit;;
//  bind ps_key (fun (_:key bytes pf) -> ps_key)

B.fst:
module B

open A

Running F* on B.fst gives the following error:
(Error 54) Error while computing or loading dependencies:
(*?u42*) _ _ is not equal to the expected type (*?u10*) _

A.fst checks fine, except in lax mode:
$ fstar.exe A.fst
Verified module: A
All verification conditions discharged successfully
$ fstar.exe --lax A.fst
A.fst(16,2-17,8): (Error 54) (*?u42*) _ _ is not equal to the expected type (*?u10*) _
1 error was reported (see above)

Now that I implemented the workaround in all my codebase, I can say it happens quite often.
It make look similar to #2583, but #2583 only happened once (i.e. I was quite unlucky to find it).

Hi @TWal, this seems to have been fixed by 6888f1bafc5151174a641ca49d5146c93ad2a75f which was added in support of typeclasses in F* sources (I remember similar problems, bisect pointed me to this commit).
Could you check if this now works fine in your larger files?

Hi @mtzguido! I don't have any commit without the workaround, so I cannot check this… Anyway, nowadays the code in ps_test is meta-programmed so the issue don't show up anymore.

Thanks! Closing then.


how can I pass allowsAirPlayVideo  value to the player

What version of Streaming-Meda-Cordova-Plugin are you using?
2.2.0
What version of Cordova are you using?
8.1.2
What devices are affected?
Please describe the issue in detail, with relevant code samples
Do I have an option to pass allowsAirPlayVideo value to the Player?
https://developer.apple.com/documentation/avfoundation/avplayer/1624258-allowsairplayvideo
What did you expect to happen?
What actually happened?

@emranashraf you can submit a pull request that provides this property or wait until i'm able to enhance the plugin at some point


Minor memory savings

Saves about ~750 gas.

OrderParameters was created to work around stack limitations in calculateOrderHash. Though it's also pretty nice these values are now bundled together.
availableAmountS is now checked a little bit later.

I'm going to close this PR for now.


installing psycopg2 in lambda

What is the best approach to installing psycopg2 or any other c compiled python library using Apex?
Receiving the following error when all im doing is importing psycopg2 in the lambda function.  Here are the error messages I receive:
{
  "errorMessage": "Unable to import module 'lambda_function'"
}

Unable to import module 'lambda_function': ./modules/psycopg2/_psycopg.so: invalid ELF header

And I have also tried installing the psycopg2-binary from requirements, and still no luck.

Hi, are you on Mac or Windows ?
I guess the problem is that your psycopg2 binary is built for the wrong platform.
AWS Lambda functions run on Linux, so the binary built with pip for Mac OS and Windows won't run on Linux.
I just discover Apex so I don't have a solution to install it using Apex but I suggest to remove psycopg2 from your requirment.txt and install it manually with Docker.
You run a Linux container locally and then install psycopg2 with pip in your working directory,  and then you have the Linux version of the library which should work in AWS Lambda.

Yeah this sounds an awful lot like you're deploying from something other than linux. Can you put the skeleton of your lambda somewhere so we can reproduce your problem?

Yeah, I was deploying from a macos machine.  So it seems like I need to be building the lambda via docker?

Dockers sounds like overkill.
Maybe do a something with (environment markers)[https://pip.pypa.io/en/stable/reference/pip_install/#requirement-specifiers]?
That being said, the psycopg docs seem (opposed to using the binary package)[http://initd.org/psycopg/docs/install.html#binary-install-from-pypi]. So Docker may be best.
Sorry I can't be more help, I'm not terribly familiar with python.

Lambda builds via Docker worked for me when I ran into this issue last year. Try this in your function.json config
"hooks":{
    "build": "docker run --rm -v $(pwd):/var/task lambci/lambda:build-python3.6 pip install --upgrade -r requirements.txt -t ."
},


clean legacy files and remove configuration files

clean files that we no long need or should not have tracked.

Wait a sec.

Sorry for that. I have added it back.


[incubator/kafka] Makes persistence fully configurable

Mimics stable/postgresql and makes persistence fully configurable.
Motivation
We create Kafka StatefulSets during CI on AWS.
Due to the high frequency with which we were creating volumes, EBS wound up getting stuck very frequently.
This change allows us to sidestep the issue by relying on kubelet host volumes.

signed CLA

/signed-cla

/signed-cla

/signed-cla

/signed-cla


Add blog post for Audio Vis

In addition to the requested changes, could you bump the date up on this post (both filename and metadata)?


Add new feature: Support --config with config file

Hi Dustin, I would like to add a new option -c or --config to your repo. This allows users to specify a config file storing options' values.
By doing so, a user could run the SSG in 2 ways:
#1:
ssg --input ./site --output ./build --stylesheet<EMAIL_ADDRESS>--lang fr
#2:
ssg --config ./ssg-config.json
ssg-config.json content:
{   "input": "./site",   "output": "./build",   "stylesheet"<EMAIL_ADDRESS>  "lang": "fr" }
#Tasks:

[x] The -c or --config flags accept a file path to a JSON config file.
[x] If the file is missing, or can't be parsed as JSON, exit with an appropriate error message.
[x] If the -c or --config option is provided, ignore all other options (i.e., a config file overrides other options on the command line).
[x] The program should ignore any options in the config file it doesn't recognize. For example, if the SSG doesn't support stylesheets, ignore a stylesheet property.
[x] If the config file is missing any options assume the usual defaults. For example, use dist/ as the output directory if it isn't specified.
[x] Update README.md

That sounds great, go for it!

Closed by #22


Spelling mistake "Assing roles"

spelling mistake down the bottom on "Assing roles", should be Assign role.

Document details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 78e62232-54ab-fa9d-1e31-7a65e7506a12
Version Independent ID: 51a94f92-9ff4-12e7-2f97-1bbe34855400
Content: Roles and permissions in Microsoft Store for Business and Education (Windows 10)
Content Source: store-for-business/roles-and-permissions-microsoft-store-for-business.md
Product: w10
Technology: windows
GitHub Login: @TrudyHa
Microsoft Alias: TrudyHa

@officedocsbot assign @mypil

@chazwoza - Thank you for pointing this out.
PR #3134 has been created to resolve this typo issue.
We appreciate your effort and feedback that helps us improve the content.

@officedocsbot reopen

@officedocsbot close


loosen premailer dependency

premailer 3.2.0 is now available

@alexhayes
Any reason not to loosen the premailer version? By the way, version 3.7.0 is already available.

@gabn88 thx for reaching out.
Really the only reason I've not merged is because the build is failing on this branch and I have no time to look into why. If you can get the build passing on this PR I'd be more than happy to merge it.


Deprecate C++03/C++11 and GCC <5; error on MSVC <2015

It's time to deprecate C++03/C++11 and GCC <5; we should do this by generating a preprocessor warning when trying to use Thrust with these things.
We should also explicitly error when trying to use Thrust with MSVC <2015.

Implemented in #1098.


iOS integration test execution framework

The project has an Android integration test that does not yet run on iOS. This PR adds the ability to easily execute the test against an iOS device, currently a simulator.

@thomassth when you have a chance have a quick look at the approach here. I tried the same approach you took for the Android test of using Process.run to execute the xcrun simctl logic but I couldn't get it to work. It terminated the test app which causes problems. Using a shell script allowed me to create a simulator for the run then clean up afterwords.


Force fontconfig pangocairo backend for pango_font_info_test

This fixes the test on platforms like MacOS (maybe also Windows) which don't use the fontconfig backend by default.
Fix and improve also some other smaller issues in the pango_font_info.cpp code.

@stweil : thanks
@egorpugin : sw build for mac is failing - at dependency building level...

Will check.


[WinUI 3 Preview 2] Docs - Outdated SDK Links

The install links for .NET5 Preview SDKs incorrectly download the wrong version (preview 5).

It would be better to use a more generic installer link that always gets the latest version (currently preview8).

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 49f58672-73e9-87bb-d7f0-8d67b6878e20
Version Independent ID: 94fc53da-622a-93c8-a4c8-4faaf7e442b8
Content: WinUI 3 Preview 2 (July 2020)
Content Source: hub/apps/winui/winui3/index.md
Product: uwp
Technology: apps
GitHub Login: @Karl-Bridge-Microsoft
Microsoft Alias: kbridge

Hi @LanceMcCarthy - these instructions are constantly being updated as WinUI 3 matures. I'm closing this issue as I believe the topic has been revised and additional topics added that cover these details. Please open a new issue if you find this is not the case.

Hi @LanceMcCarthy - these instructions are constantly being updated as WinUI 3 matures. I'm closing this issue as I believe the topic has been revised and additional topics added that cover these details. Please open a new issue if you find this is not the case.


Test that IO.asyncPure terminates

I was on a 2 week old master and was bitten by https://github.com/scalaz/scalaz-zio/commit/8e55a4e46ec75eb933c51c2651226d1c6e1b7ac3
Took me awhile before figured it out. WDYT about adding a test on this?

@ktonga ♻

Thank you @artempyanykh


Remove 'static lifetime requirement

In some cases, the static lifetime can be problematic because it prevents

Load key from the configuration file (or other dynamically loaded value) without involving Box::leak()

To address the problem, it is advised to remove 'static lifetime requirement and clone the value as needed.

Close in favour of #8


Craft 4 Support

Will we see Craft 4 support for this plugin?
Thanks

Currently, we don't plan to update this (full list of update plans here). Our focus is on our primary commercial plugins right now. I'll be updating the README's with a note shortly.
If you'd like to take over this repository and maintain it, let me know. Happy to help get you framed around migrating it on a screenshare if helpful.

Just to chime in, we've added this to our Craft 3 migration project as a few people have requested it.
If you're looking for a new home for Sprout Active, we'd be happy to continue development at Verbb (including updating to Craft 4) - but just let us know if you've got plans to continue things and update to Craft 4! @BenParizek

Thanks @engram-design. I'm in the process of adding an official Craft 4 Support ticket to all of our plugins and will link to your migration page from all the ones we're discontinuing. With Craft 4 will be focusing on our core plugins and happy to see you folks helping out where there is enough interest for the little ones.

No worries @BenParizek, happy to help but not looking to rip anything away from you, so no pressure 🙂 feel free to reach out on Discord if you want to transfer any our way.


MAHOUT-2106 Adjust confusing comments

Purpose of PR:
The renaming done under MAHOUT-2106 left the text of the comments somehow confusing. Let's have a better wording.
Important ToDos
Please mark each with an "x"

[X] A JIRA ticket exists (if not, please create this first)[https://issues.apache.org/jira/browse/mahout/]
[X] Title of PR is "MAHOUT-XXXX Brief Description of Changes" where XXXX is the JIRA number.

Thanks @sergiu-svinarciuc for the contribution!


update php-urljoin

For future reference,  you should probably be using a git submodule or composer or something instead of just copying the source files over, but those are kind of a pain to deal with and I haven't been great about that in my own projects either. :)

Thanks for the PR ! We should indeed use a dependency manager, but as this dependency is quite straightforward and should not be updated that much, I think it is easier for us and the users to do it that way


chore: upgrade kcd-scripts

What: upgrade kcd-scripts to latest

Why: Something broke with jsdom + jest stuff and the latest kcd-scripts fixes it.

How: bump to v0.40.0

Checklist:

[ ] Documentation N/A
[ ] Tests N/A
[x] Ready to be merged
[ ] Added myself to contributors table N/A

:tada: This PR is included in version 3.1.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


EVEREST-1518: validate db engine read access during db cluster read/update/delete

EVEREST-1518

I haven't reviewed the PR yet, but decided to comment since it's already approved. Does this apply to create as well?

I don't think it does. I'll add it.

I don't think it does. I'll add it.

Thanks, this way you'll be able to fix EVEREST-1604 as well :slightly_smiling_face:


Don't Merge! Regression pull request test

Docs Build status updates of commit 0c4eef8:
:clock10: Pending: waiting for processors (7 builds ahead of you)
:warning: Docs Build is busy, currently there are 7 builds ahead of this one, for more information you can view the Build queue graph on the Docs Portal.

Docs Build status updates of commit 0c4eef8:
:warning: Validation status: warnings

File
Status
Preview URL
Details
Dependent Files

developer/TestingPullRequest.md
:warning:Warning
View
Details

developer/TestingPullRequest.md

[Warning] Metadata with following name(s) are not allowed to be set in Yaml header, or as file level metadata in docfx.json, or as global metadata in docfx.json: content_type. They are generated by Docs platform, so the values set in these 3 places will be ignored. Please remove them from all 3 places to resolve the warning.
[Warning] the value invalid_type is undefined for metadata content_type
Line 7: [Warning] Invalid file link:(~/../nonexisted1.md).
Line 8: [Warning] Invalid file link:(~/../nonexisted2.md).
Line 9: [Warning] Invalid file link:(~/../nonexisted3.md).

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Adding scope label to "Refine" section of facets

Problem Description:
A common confusion with the refine section of facets has been discovered from user testing. When refining results on, for example the object tab, users assume the refinements they have made will transfer over to other tabs they select. (Works, Places, People & Groups, and Events)  However, this is not how it is intended to work. Each tab has different options for refinement, so when selecting a new tab previous refinements from the old tab will clear. This needs to be better communicated to the user.
Expected Behavior/Solution:
Adding the tab name after Refine can relieve user confusion as this would indicate refinements are only applicable to the selected tab.
For each tab, the new label will be "Refine Objects", "Refine Works", "Refine [Type]".
Requirements:
On each refine, the tab name will appear next to it to indicate where this refinement will be applied to.
Ex:
"Refine Objects" will only refine searches from the object tab.
Needed for promotion:
If an item on the list is not needed, it should be crossed off but not removed.

[x] Wireframe/Mockup - Mike
[x] Inform Interactions - Sarah
[x] Feasibility/Team discussion - Sarah
[ ] ~Backend requirements - TBD~
[x] Frontend requirements- TBD
-~ [ ] Questions~
~List of questions for discussions. Answers should be documented within the issue.~

UAT/LUX Examples:
Original version of refine:

New version:

Dependencies/Blocks:
Related Github Issues:
https://github.com/project-lux/lux-frontend/issues/129 (dupe made by ar2674, will need to close if issue re-appears.)
Related links:

User Testing Findings

Wireframe/Mockup:
Place wireframe/mockup for the proposed solution at end of ticket.

Dupe of 109 (which cannot be seen as my old account was banned)

Propose Close?  The new designs will not include "refine" under the facets.
https://github.com/project-lux/lux-frontend/issues/270

Approved by UAT

Looks good in PROD. Closing