chore: release 1.0.0

:robot: I have created a release beep boop
1.0.0 (2024-03-12)
Features

sqlconnect library (#1) (a6fadb5)

This PR was generated with Release Please. See documentation.

:robot: Release is at https://github.com/rudderlabs/sqlconnect-go/releases/tag/v1.0.0 :sunflower:


Any plans to support container commit commands?

Any plans to support container commit commands?
like
docker commit or nerdctl commit

I would say it's unlikely unless support is added in kubernetes for some reason or another. For instance, a use-case was found for kubelet checkpointing a container, so it was added. A similar thing would have to happen and be accepted in SIG-Node for crictl to add commit support


Make signs' text a configurable option

So we can use nice single character symbols like ➤ or ❱ instead of -> and B>.

duplicate #326 has better description


Cannot Find some QR Codes

Problematic QR Code:

Finding (also changing the angle of the QR code to 45° scans successfully):

After further investigation it seems the vertical and horizontal pattern is accepted at the incorrect center, for this particular QR Code.
Which lead me to come across these concerns:
It seems at FinderPatternFinder.java:78
pureBarcode = hints != null && hints.containsKey(DecodeHintType.PURE_BARCODE);
the default for pureBarcode is false (I'd rather assume most QR Codes are pure monochrome?)
eg. pureBarcode = hints == null || hints.containsKey(DecodeHintType.PURE_BARCODE);
In any case at FinderPatternFinder.java:496 it seems that the diagonal check is ignored when it is not monochrome (!pureBarcode || crossCheckDiagonal(...). This seems strange can someone please explain the reasoning behind this, I don't understand it. According to me it should still do the check regardless if it is a pureBarcode or not.
Unfortunately I'm currently unable to run any tests
meaning of Pure Barcode:
  /**
   * Image is a pure monochrome image of a barcode. Doesn't matter what it maps to;
   * use {@link Boolean#TRUE}.
   */
  PURE_BARCODE(Void.class),

DecodeHintType.java

Hi, I think you're best off asking this at the repo where this is actually maintained. The code you found in this repo is similar to the original: https://github.com/zxing/zxing/blob/master/core/src/main/java/com/google/zxing/qrcode/detector/FinderPatternFinder.java
Sorry that it's not too clear that this is 'soft fork'.

Ok will do.
Further down the Rabbit hole I go :)

Haha, good luck! 👍

@EddyVerbruggen can you please update with the fix https://github.com/zxing/zxing/pull/906
Can you also updated the phonegap plugin again?


Regex

There should probably be some mention in the readme about the fact that jalibut supports searching with regular expressions out of the box. This is particularly helpful with large collections.
For example, try searching here for the string fedora.*grey to see everything in the fedora category that also mentions the word "grey". I discovered this by accident. :smile:
This makes jalibut incredibly powerful as a tool for searching/organizing information, and more people should know about it! A note somewhere in the showcase about supporting regex with a link to an overview of regular expression syntax would be great too.

In full accordance, a section has been added to the readme. The default search bar also shows that regex is supported.


Release 1.4.x

Remove unnecessary error log
Fix scoring shapes
removed unnecessary bittensorlogger filename in custom log format
cleaned synapase_history to avoid potential memory leak
Set finney as default and local node in subtensor env

:tada: This PR is included in version 1.4.1 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


[VL] Support change columnar shuffle commpression level

What changes were proposed in this pull request?
Vanilla Spark support change shuffle commpression level if the codec is zstd. This pr makes columnar shuffle follow the behavior. It respects config spark.io.compression.zstd.level.
How was this patch tested?
manually test a small dataset
level=1

level=21

Thanks!

===== Performance report for TPCH SF2000 with Velox backend, for reference only ====

query
log/native_4714_time.csv
log/native_master_02_19_2024_72960de81_time.csv
difference
percentage

q1
33.56
33.43
-0.128
99.62%

q2
24.46
24.73
0.265
101.09%

q3
37.43
37.94
0.506
101.35%

q4
38.04
37.71
-0.328
99.14%

q5
69.68
70.80
1.118
101.60%

q6
7.16
7.31
0.149
102.09%

q7
84.65
82.80
-1.850
97.82%

q8
86.62
86.79
0.174
100.20%

q9
119.94
121.45
1.509
101.26%

q10
44.12
41.30
-2.828
93.59%

q11
20.18
20.02
-0.156
99.23%

q12
29.13
26.06
-3.068
89.47%

q13
45.60
45.68
0.081
100.18%

q14
20.54
15.10
-5.441
73.51%

q15
29.49
27.77
-1.718
94.17%

q16
12.80
14.10
1.298
110.14%

q17
102.84
102.85
0.007
100.01%

q18
149.78
149.16
-0.620
99.59%

q19
12.65
13.92
1.272
110.06%

q20
27.91
26.87
-1.039
96.28%

q21
225.19
226.51
1.323
100.59%

q22
13.73
13.67
-0.061
99.55%

total
1235.49
1225.96
-9.533
99.23%


Arrow function leaves this undefined in code block.

Any clarification on why this is happening?
Misc specs
Node version: 5.6.0
strict-mode: enabled via 'use strict'
through2 version: 2.0.1
The Good  :+1:
Works fine with keyword Function declaration:

.pipe(Through2(function(chunk, enc, callback) {
        this.push(chunk)

        callback();
}))

The Bad :-1:
**Breaks when using ES2015 Arrow Function: **
.pipe(Through2((chunk, enc, callback) => {
        this.push(chunk)

        callback();
}))

The Ugly :bug:
** The error displayed in my cli: **
this.push(results)
            ^

TypeError: Cannot read property 'push' of undefined
  at: ...

Searched through Issues and I did not find anything related. Posting here as reference for anyone that may experience the issue in the future.
Aloha.

Thankfully, I can still push data down the pipeline with  callback(null, dataToPass).
.pipe(Through2((chunk, enc, callback) => {
    //...
    callback(null, results);
}))

Hi @sgnl -- I believe what you are running into is how arrow functions work: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Functions/Arrow_functions

An arrow function expression (also known as fat arrow function) has a shorter syntax compared to function expressions and lexically binds the this value (does not bind its own this, arguments, super, or new.target).


Web site issues

Some icons problem with Safari on your site: http://goo.gl/UfSj0Y
Facebook icons doesn't show and right sidebar is very small.
My safari version: 8.0.5 (10600.5.17)

Are you using an adblocker? I've noticed they like to block social icons.

Thanks for help. I removed extensions.


jailing users

Hi,
is there a way to jail a user in same other software which i will write to operate? So if user john logs in, i want that this users automatically starts the software node ./manage.js and when this user presses CTRL+c it should close the terminal.
This way i plan to make management consoles per user.
I am aware of doing such things on linux by setting .bashrc etc but i am afraid of forgetting something so user can "break out of the jail". Any recommendations please?

Not to take away from this project at all, (it's great!), but the ideas used in this one actually inspired (gotty)[https://github.com/yudai/gotty], which can do exactly what you need, I think.


GUI Windows size isn't saved upon closing and reopening the app

i can resize the app normally but after closing it and opening back, it reverts to the default size

Yeah. MFE currently doesn't track the window size.

It'd nice to keep track of Settings window size, I already done it once let's do it.


Video streaming only works on local network

I’m running homebridge from my iMac. When I’m on the same wifi network as my iMac i.e. at home, all my iDevices are able to stream the video in the Home app. However, when I’m on 4G or another wifi network, the video tries to load and then eventually times out after 30 seconds.
The log below looks fine though. I’ve tried removing and re-adding the camera in Home app but to no avail.
[2/7/2019, 12:10:13 AM] [DoorBird] Start streaming video from DoorBird with 1280x720@299kBit
[2/7/2019, 12:10:43 AM] [DoorBird] Stopped streaming

Definitely related to this is the fact that when I force-touch the lock screen notifications, the expanded picture doesn’t turn into a live video stream unless I’m on the same wifi network as my iMac running Homebridge.
Any ideas?

Same happens with other ffmpeg streams anything can stop it from streaming
Sent from my iPhone

On 6 Feb 2019, at 13:16, BillS11<EMAIL_ADDRESS>wrote:
I’m running homebridge from my iMac. When I’m on the same wifi network as my iMac i.e. at home, all my iDevices are able to stream the video in the Home app. However, when I’m on 4G or another wifi network, the video tries to load and then eventually times out after 30 seconds.
The log below looks fine though. I’ve tried removing and re-adding the camera in Home app but to no avail.
[2/7/2019, 12:10:13 AM] [DoorBird] Start streaming video from DoorBird with 1280x720@299kBit
[2/7/2019, 12:10:43 AM] [DoorBird] Stopped streaming
Definitely related to this is the fact that when I force-touch the lock screen notifications, the expanded picture doesn’t turn into a live video stream unless I’m on the same wifi network as my iMac running Homebridge.
Any ideas?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

I can confirm the behaviour. Its not stopping from external network - it does not even start streaming. In my case there is no request in the log so obviously the request is not routed correctly to the homebridge plugin...

I just don’t see this at all


Update Requirement documentation

Since it use expo in the development so it needs to configure expo module for the people who are going to use it in bare react native.
And since I do develop the project using bare react native and only need the upload feature so it seems not suitable for me to install the expo module.
Do you have any suggestion for it?

Hey @naufanituharish,
Would you please clarify what the issue is here?

Halo there, I was trying to use the react native cloudinary SDK in my react native project. I do develop the project using bare react native, not using expo. I could not use the SDK after installing it. The error said that I need to install expo module.
So I thought it's better to update the documentation to explain how to use the SDK in react native project that not use expo.
So it need to install expo module before I can use it in bare react native.
Here is the documentation to install expo module in bare react native
https://docs.expo.dev/bare/installing-expo-modules
Regards,
Naufan Harish

Hi @naufanituharish ,
Currently our SDK is supported with Expo only.  The decision was not taken lightly, and was following the community best practices.
I hope this helps.

That's what I said before, it is only support the development that using expo. So I thought it's better to update the documentation an mention it on the readme.
Regards,
Naufan Harish

@naufanituharish thx, i will pass that back to our docs team.

Please update your documentation soon. I spent the entire night going through your documentation trying to figure out why the upload was not working for me. Just came across this issue now and finally saw it only works with Expo React native project.


You can't run policy more than once

Description
Added re-run policy control
Test
All passed.
Coverage
No changes
Scalastyle
No info

LGTM


Translate status text suggestions

This is one of the followups to #3344. For details on this and other followups, see this comment:
https://github.com/zulip/zulip-mobile/pull/3344#issuecomment-468465263

@gnprice Fixed in PR #3432, please review.


Create a new package version

@JuliaRegistrator register()

Error while trying to register: Version 0.1.0 already exists

@JuliaRegistrator register()

Registration pull request created: JuliaRegistries/General/86919
After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.
This will be done automatically if the Julia TagBot GitHub Action is installed, or can be done manually through the github interface, or via:
git tag -a v0.2.0 -m "<description of version>" 9bde8bc4a1f8dccddc6a792c9fb705a9d582cabe
git push origin v0.2.0

@JuliaRegistrator register()

Registration pull request created: JuliaRegistries/General/86920
After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.
This will be done automatically if the Julia TagBot GitHub Action is installed, or can be done manually through the github interface, or via:
git tag -a v0.3.0 -m "<description of version>" bec7427bc76c3ed73a05690115f085842437693c
git push origin v0.3.0


Easy-access getter functions

With the implementation of the new datastructure (#327), it becomes rather tricky to get information
from the airr rearrangment schema (e.g. what is the "c_call" of the primary "VJ" chain?).
Previously this was possible simply with
adata.obs["IR_VJ_1_c_call"]

With the new datastructure
adata[:, "c_call"].X

just yields an awkward array with a variable number of chains per cell. The information which
chain is VJ/VDJ and primary or secondary is hidden away in adata.obsm.
This motivates the implementation of long-proposed easy-access getter/setter functions. At the very least to

retrieve AIRR rearrangement variables for a certain chain.

But possibly also with convenience functions, e.g.

to retrieve the most abundant categories (previously discussed in #51).

The latter is of less importance, but the interface needs to be designed jointly, therefore this is also a topic in this issue.

To get AIRR data, we need something like
ir.get(adata, "locus", "VJ_1") -> pd.Series

We need it regulary to get the top n of a category, e.g. v-gene or clonotype.
This can be achieved in a pandas onliner, if one knows how to do it...
# This is probably hacky, we might think about a better way, but we need the most abundant clonotypes

top_clonotypes = adata.obs.clonotype.value_counts()[:8].index.tolist() # A better way might be needed especailly to take normalization into account
top_vgenes = adata.obs.TRB_1_v_gene.value_counts()[:8].index.tolist()

It would be more user-friendly to have a convenience function to this,
for instance:
ir.tl.top_n(col="clonotype", n=10)

Use it for plotting:
sc.pl.umap(adata, color="clonotype", groups=ir.tl.top_n("clonotype", 10))

To discuss

[ ] retrieve multiple columns at once / vectorization?
[ ] what about "extra" chains?
[x] plotting

Suggestion:
Implement a "getter" class that supports method chaining.
putative API:
# get a series (n_obs, )
ir.get(adata).airr("locus", "VJ_1")

# get most frequent C gene
ir.get(adata).airr("c_call", "VJ_1").most_frequent(n=10)

# get most frequent clonotype
ir.get(adata).obs("clonotype").most_frequent(n=10)

# get top 3 clonotypes with the highest clonotype modularity score
ir.get(adata).obs("cc_aa_alignment").top_n(n=3, by="clonotype_modularity", aggr="unique")

For the convenience functions
ir.get.most_frequent(adata.obs["clonotype"])

is more flexible, as it can be applied to any pandas series. Also one that was retrieved from the airr data, e.g
ir.get.most_frequent(ir.get.airr(adata, "c_call", "VJ_1")) # or
ir.get.airr(adata, "c_call", "VJ_1").pipe(ir.get.most_frequent, n=5)

For easy plotting with scanpy functions, we could do one of the following.

Nothing. The user is free to assign a variable of interest to a column

adata.obs["locus_vj1"] = ir.get.airr(adata, "locus", "VJ_1")
adata.obs = adata.obs.assign(locus_vj = lambda x: ir.get.airr(x, "locus", "VJ_1")

Wrapper function that redirects to scanpy plotting functions

ir.pl.airr("umap", adata, "locus", "VJ_1")
ir.pl.airr(sc.pl.umap, adata, "locus", "VJ_1")
ir.pl.airr("umap", [("locus", "VJ_1"), ("locus", "VJ_2"), "some_other_var"])

# what is with other, non-embedding plotting functions?

Context manager

with ir.get.anndata(adata, locus_vj=("locus", "vj_1")) as tmp_ad:
    sc.pl.umap(tmp_ad, color="locus_vj")

plot_dict = {
   "locus_vj1": ("locus", "vj_1"),
   "locus_vj2": ("locus", "vj_2"),
   "c_call_vj1": ("c_call", "vj_1"),
}
with ir.get.anndata(adata, **plot_dict) as tmp_ad:
   sc.pl.umap(tmp_ad, color=plot_dict.keys())

I like options (1) and (3), and they are not mutually exclusive.
(2) seems like it's to inflexible and leads to too many special cases.

The context manager and a get function are implemented in #356.
I decided against a top_n or most_frequent function as the same can be achieved quite easily with plain pandas/numpy.


operators [O] assisted-service-operator (0.0.7)

Thanks submitting your Operator. Please check below list before you create your Pull Request.
New Submissions

[ ] Are you familiar with our contribution guidelines?
[ ] Have you packaged and deployed your Operator for Operator Framework?

[ ] Have you tested your Operator in all supported installation modes?
[ ] Have you considered whether you want use semantic versioning order?
[ ] Is your submission signed?
[ ] Is operator icon set?

Updates to existing Operators

[ ] Did you create a ci.yaml file according to the update instructions?
[ ] Is your new CSV pointing to the previous version with the replaces property if you chose replaces-mode via the updateGraph property in ci.yaml?
[ ] Is your new CSV referenced in the appropriate channel defined in the package.yaml or annotations.yaml ?
[ ] Have you tested an update to your Operator when deployed via OLM?
[ ] Is your submission signed?

Your submission should not

[ ] Modify more than one operator
[ ] Modify an Operator you don't own
[ ] Rename an operator - please remove and add with a different name instead
[ ] Modify any files outside the above mentioned folders
[ ] Contain more than one commit. Please squash your commits.

Operator Description must contain (in order)

[ ] Description about the managed Application and where to find more information
[ ] Features and capabilities of your Operator and how to use it
[ ] Any manual steps about potential pre-requisites for using your Operator

Operator Metadata should contain

[ ] Human readable name and 1-liner description about your Operator
[ ] Valid category name1
[ ] One of the pre-defined capability levels2
[ ] Links to the maintainer, source code and documentation
[ ] Example templates for all Custom Resource Definitions intended to be used
[ ] A quadratic logo

Remember that you can preview your CSV here.
--
1 If you feel your Operator does not fit any of the pre-defined categories, file an issue against this repo and explain your need
2 For more information see here

/merge possible

I checked the 0.0.6 version and it looks like we are using latest there too. Not sure if we want to go all the way back to fixing older versions.
I think this is good enough for now and we can fix the older versions later if needed.

@flaper87  it has nothing to do with image change. We are using a newer opm tool which is now checking for "unused versions".  Versions 0.0.6 and bellow do not belong to any channel. So please delete them or connect them to some higher version which in some channel with replaces property.

@flaper87 it has nothing to do with image change. We are using a newer opm tool which is now checking for "unused versions". Versions 0.0.6 and bellow do not belong to any channel. So please delete them or connect them to some higher version which in some channel with replaces property.

I have creaed https://github.com/redhat-openshift-ecosystem/community-operators-prod/pull/261 to address this comment

/merge possible


External Services not showing up as a target

What did you do?
I am attempting to monitor a ceph cluster with the prometheus running inside the kubernetes cluster. I created a service with ExternalName and an Endpoints inside the cluster for the external service.  I can successfully hit the endpoint from inside a pod in the cluster. I then created a ServiceMonitor and the configuration appeared in Prometheus, but I don't see the target and no errors are reported in any logs. This feels to me like I am just missing something, but I cannot figure out what I've missed.
What did you expect to see?
I expected to see the external service show up as a target or errors in the prometheus-operator log.
What did you see instead? Under which circumstances?
No target showed up for the external service and no logs in the prometheus-operator log.
Environment

Kubernetes version information:

Kuberentes 1.8.4

Kubernetes cluster kind:

kubeadm

Manifests:

External service manifests (Deployed to the kube-system namespace)
---
apiVersion: v1
kind: Service
metadata:
  name: ceph-k8s
  labels:
    component: ceph-k8s
spec:
  type: ExternalName
  externalName: {EXTERNAL_IP}
  ports:
  - port: 9283
    name: scrape
    protocol: TCP
---
apiVersion: v1
kind: Endpoints
metadata:
  name: ceph-k8s
  labels:
    k8s-app: ceph-k8s
subsets:
  - addresses:
    - ip: {EXTERNAL_IP}
    ports:
      - port: 9283

ServiceMonitor (deployed, along with prometheus-operator/prometheus in the monitoring namespace)
apiVersion: monitoring.coreos.com/v1
kind: ServiceMonitor
metadata:
  name: ceph-k8s
  labels:
    k8s-app: ceph-k8s
  spec:
    endpoints:
      - port: scrape
        interval: 30s
        path: /
      selector:
        matchLabels:
          component: ceph-k8s
      namespaceSelector:
        matchNames:
        - kube-system

The configuration that gets generated in Prometheus:
- job_name: monitoring/ceph-prometheus/9
  scrape_interval: 10s
  scrape_timeout: 10s
  metrics_path: /
  scheme: http
  kubernetes_sd_configs:
  - api_server: null
    role: endpoints
    namespaces:
      names:
      - kube-system
  relabel_configs:
    ...

Prometheus Operator Logs:

No errors
ts=2017-12-19T15:50:30Z caller=operator.go:671 component=prometheusoperator msg="sync prometheus" key=monitoring/k8s
ts=2017-12-19T15:50:30Z caller=operator.go:671 component=prometheusoperator msg="sync prometheus" key=monitoring/k8s
ts=2017-12-19T15:50:30Z caller=operator.go:671 component=prometheusoperator msg="sync prometheus" key=monitoring/k8s
ts=2017-12-19T15:50:30Z caller=operator.go:983 component="prometheusoperator" msg="current config or current configmaps has changed"
ts=2017-12-19T15:50:30Z caller=operator.go:989 component="prometheusoperator" msg="updating configuration"
ts=2017-12-19T15:50:30Z caller=operator.go:671 component=prometheusoperator msg="sync prometheus" key=monitoring/k8s
ts=2017-12-19T15:50:30Z caller=operator.go:671 component=prometheusoperator msg="sync prometheus" key=monitoring/k8s
ts=2017-12-19T15:50:30Z caller=operator.go:671 component=prometheusoperator msg="sync prometheus" key=monitoring/k8s

External Services are currently not supported by Prometheus, therefore we don't have any possibility to support it either yet.
Related:

https://github.com/coreos/prometheus-operator/pull/372
https://github.com/prometheus/prometheus/issues/2791

Below a example that works if anyone needs.
The point here's that we need three manifests:

Service that points to the external resource (type: ExternalName);
Endpoints that points to the external address of our resource (this type of service don't create the Endpoint resource automatically, we need to create it manually);
ServiceMonitor with the correct selectors;

Service Manifest
kind: Service
apiVersion: v1
metadata:
  name: my-internal-server
  labels:
    k8s-app: node-exporter
spec:
  externalName: <IP_ADDRESS>
  type: ExternalName
  - name: metrics
    port: 9100
    protocol: TCP
    targetPort: 9100

Endpoints Manifest
apiVersion: v1
kind: Endpoints
metadata:
  name: my-internal-server
  labels:
    k8s-app: node-exporter
subsets:
- addresses:
  - ip: <IP_ADDRESS>
  ports:
  - name: metrics
    port: 9100
    protocol: TCP

ServiceMonitor Manifest
apiVersion: monitoring.coreos.com/v1
kind: ServiceMonitor
metadata:
  name: internal-servers
  labels:
    k8s-app: node-exporter
spec:
  selector:
    matchLabels:
      k8s-app: node-exporter
  namespaceSelector:
    matchNames:
    - monitoring
  endpoints:
  - port: metrics
    interval: 10s
    honorLabels: true
    path: /metrics

@amalucelli  I'm currently trying to get external nodes monitored.  Your example was very close but the service file looked like it was missing the port:.  Could you confirm this still works? I just set this up via the specs below but it doesn't seem to be working.
`pet-bfleming-2:try3 bfleming$ cat *
apiVersion: v1
kind: Endpoints
metadata:
name: my-internal-server
labels:
k8s-app: node-exporter
subsets:

addresses:

ip: <IP_ADDRESS>
ports:
name: metrics
port: 9100
protocol: TCP
apiVersion: monitoring.coreos.com/v1
kind: ServiceMonitor
metadata:
name: internal-servers
labels:
k8s-app: node-exporter
spec:
selector:
matchLabels:
k8s-app: node-exporter
namespaceSelector:
matchNames:

monitoring
endpoints:

port: metrics
interval: 10s
honorLabels: true
path: /metrics
kind: Service
apiVersion: v1
metadata:
name: my-internal-server
labels:
k8s-app: node-exporter
spec:
type: ExternalName
externalName: <IP_ADDRESS>
ports:
name: metrics
port: 9100
protocol: TCP
targetPort: 9100
pet-bfleming-2:try3 bfleming$`

@stonefury yes! I've compared and reviewed your configuration based on my working stack and your configuration looks good, the only thing that differs are the k8s-app label and the ip address.
Can you review the following points?

The Service and Endpoints were created in monitoring namespace?
Are your Prometheus configured to select the k8s-app label?

  serviceMonitorSelector:
    matchExpressions:
    - {key: k8s-app, operator: Exists}

As far as I know, the ports spec when Service is a ExternalName doesn't have any effects, I usually configure this only for convinience as I know what kind of ports I'm using on those external servers.

@amalucelli  I cleaned up some of my failed attempts, and maybe I needed to wait a little longer for data to show up. It works! Fantastic, thanks for your post on this, and really appreciate you responding so quick. You should create a gist for this. That example is very useful.

That's nice @stonefury!
For the friendly name, some considerations/ideas:
Grafana use the following templating on nodes-dashboard.json to suggest the IP:Port list:
"query": "label_values(node_boot_time, instance)",

Querying Prometheus for node_boot_time, Grafana use the label_values function based on the instance label, that will return all of our nodes (below we have k8s nodes and external servers):

Element
Value

node_boot_time{endpoint="https",instance="<IP_ADDRESS>:9100",job="node-exporter",namespace="monitoring",pod="node-exporter-xpto123",service="node-exporter"}
1521484132

node_boot_time{endpoint="https",instance="<IP_ADDRESS>:9100",job="node-exporter",namespace="monitoring",pod="node-exporter-xpto456",service="node-exporter"}
1520525328

node_boot_time{endpoint="metrics",instance="<IP_ADDRESS>:9100",job="internal-server-server1",namespace="servers",service="internal-server-server1"}
1520008665

node_boot_time{endpoint="metrics",instance="<IP_ADDRESS>:9100",job="internal-server-server2",namespace="servers",service="internal-server-server2"}
1520519128

As you can see, in this model we don't have a common tag that works for both k8s nodes and external servers. I would suggest to you to create a new dashboard only for those internal servers and change that specific query.

Thanks @amalucelli .  I don't quite understand your suggestion on getting friendly values. I tried a few things, but I think I just need to learn more about grafana and prometheus. At this point I'm just familiar with the k8s aspect of it.

@amalucelli I have a service that is not external that I am targeting.  Would I still need the endpoint? For example the target will be a service,
      kind: Service
      apiVersion: v1
      metadata:
        name: my-internal-server
        labels:
          k8s-app: node-exporter
      spec:
        ports:
        - name: metrics
          port: 9100
          protocol: TCP
          targetPort: 9100

      apiVersion: v1
      kind: Endpoints
      metadata:
        name: my-internal-server
        labels:
          k8s-app: node-exporter
      subsets:
        ports:
        - name: metrics
          port: 9100
          protocol: TCP

      apiVersion: monitoring.coreos.com/v1
      kind: ServiceMonitor
      metadata:
        name: internal-servers
        labels:
          k8s-app: node-exporter
      spec:
        selector:
          matchLabels:
            k8s-app: node-exporter
        namespaceSelector:
          matchNames:
          - monitoring
        endpoints:
        - port: metrics
          interval: 10s
          honorLabels: true
          path: /metrics

@bamb00 I think that you only need to specify a selector for your Service object. Also don't create manually the Endpoints resource after that.
Based on the docs:

The Service’s selector will be evaluated continuously and the results will be POSTed to an Endpoints object also named “my-service”.

Also in the docs, there's a example of what happens when you don't specify the selector spec.

Because this service has no selector, the corresponding Endpoints object will not be created.

Hi, I use the following yaml to create Endponts & Service & ServiceMonitor. kubectl create with no error and  I can also see the monitoring/nodejs-metrics-sm/0 item in prometheus web Status -> Service Discovery page.
But service not showing up as a target , and in the monitoring/nodejs-metrics-sm/0 item,  the Target Labels show Dropped value.
p.s. use prometheus-operator tag: v0.18.0 ; k8s 1.10
Hope someone can help.
Thanks in advance.
endpoint.yaml
apiVersion: v1
kind: Endpoints
metadata:
  name: nodejs-metrics
  labels:
    k8s-app: nodejs-metrics
subsets:
  - addresses:
    - ip: <IP_ADDRESS>
    ports:
      - name: metrics
        port: 3000
        protocol: TCP

service.yaml
apiVersion: v1
kind: Service
metadata:
  name: nodejs-metrics-svc
  namespace: monitoring
  labels:
    k8s-app: nodejs-metrics
spec:
  type: ExternalName
  externalName: <IP_ADDRESS>
  ports:
  - name: metrics
    port: 3000
    protocol: TCP
    targetPort: 3000

service_monitor.yaml
apiVersion: monitoring.coreos.com/v1
kind: ServiceMonitor
metadata:
  namespace: monitoring
  name: nodejs-metrics-sm
  labels:
    k8s-app: nodejs-metrics
spec:
  selector:
    matchLabels:
      k8s-app: nodejs-metrics
  namespaceSelector:
    matchNames:
      - monitoring
  endpoints:
  - port: metrics
    interval: 10s
    honorLabels: true
    path: /metrics

I've been struggling with this for the past few hours. Eventually, I realised that Prometheus's data model has a strict validation for label names and a - is not a valid character in a label name, only ASCII letters, numbers, and underscores are valid. I changed the name of the Endpoints object to have no dashes in it (just a string of lowercase characters) and the target is now active on the Target Discovery page and pulling metrics from my external Ceph cluster.
This might be the same problem you're facing @CharlesHuangGeminiOpenCloud as I can see your Endpoints object has the name nodejs-metrics.
I'm quite new to Prometheus overall, but is this potentially something the Operator could help address? Relabing invalid characters, such as - to an underscore?

@KingJ   Thanks for your reply!
I try to modify the Endpoints object with name nodejs_metric , but it shows error
The Endpoints "nodejs_metrics" is invalid: metadata.name: Invalid value: "nodejs_metrics": a DNS-1123 subdomain must consist of lower case alphanumeric characters, '-' or '.', and must start and end with an alphanumeric character (e.g. 'example.com', regex used for validation is '[a-z0-9]([-a-z0-9]*[a-z0-9])?(\.[a-z0-9]([-a-z0-9]*[a-z0-9])?)*')
Then  I just use nodejs as object name,  but the result remain the same.  No target in prometheus dashboard... but can see it in Service Discovery
I check the Endpoints curl <IP_ADDRESS>:3000/metrics with some fake result like
# HELP nodejs_heap_space_size_available_bytes Process heap space size available from node.js in bytes.
# TYPE nodejs_heap_space_size_available_bytes gauge
nodejs_heap_space_size_available_bytes{space="new"}<PHONE_NUMBER>851635109
nodejs_heap_space_size_available_bytes{space="old"} 4828584<PHONE_NUMBER>109
nodejs_heap_space_size_available_bytes{space="code"}<PHONE_NUMBER>851635109
nodejs_heap_space_size_available_bytes{space="map"}<PHONE_NUMBER>851635109
nodejs_heap_space_size_available_bytes{space="large_object"}<PHONE_NUMBER><PHONE_NUMBER>109

So I think the metric is ok. Prometheus should pull the metrics with no error.


Empty Output

I am experiencing no output at all from translate-shell
for example:
trans :fr dejeuner
returns emptyin the CLI
I installed from github.
I am using Linuxmint 19.3 MATE
trans - V
^[[1mTranslate Shell <IP_ADDRESS>-git:a915583
^[[22mplatform Linux
terminal type xterm-256color
bi-di emulator [N/A]
gawk (GNU Awk) 4.1.4
fribidi (GNU FriBidi) 0.19.7
audio player mpv --no-config
terminal pager less
web browser xdg-open
user locale en_US.UTF-8 (English)
home language en
source language auto
target language en
translation engine google
proxy [NONE]
user-agent Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/602.1 (KHTML, like Gecko) Version/8.0 Safari/602.1 Epiphany/3.18.2
ip version [DEFAULT]
theme default
init file [NONE]

As I already suggested in the last comment, post the output of trans -D fr: dejeuner here. Please do not spam the issue tracker with the same unuseful information again and again.


Should we hero the year to the top of the dialog in the date picker?

Posse has received a lot of negative feedback in their app about use of the Material Design date picker (see also https://github.com/flutter/flutter/issues/11610).  One suggestion @collinjackson had is that in addition to possibly doing (https://github.com/flutter/flutter/issues/11610) we could also use a hero effect on the selected year from where it was selected to the top of the dialog to make clear that the year is selectable.  Thoughts?  @Hixie @HansMuller?

It seems like the Material date picker may be more useful for picking dates in the near future. For dates in the distant past, the day of the week isn't relevant, so perhaps a different date entry mechanism would feel more natural.
Here's an example of building a date picker using package:numberpicker.


bug: Highlighting is not timely/accurate

Did you check docs and existing issues?

[X] I have read all the vscode-neovim docs
[X] I have searched the existing issues of vscode-neovim
[X] I can reproduce the issue with an empty init.vim/init.lua and no other vscode extensions (when applicable)

Neovim version (nvim -v)
0.9.4
Operating system/version
window 11
Describe the bug
/hello using flash.nvim
NeoVim

VS Code

Steps To Reproduce

Expected Behavior

As you can see, there is a flicker of the same color as the correct highlight
https://github.com/vscode-neovim/vscode-neovim/assets/47070852/9c58b7bb-ff54-476c-8521-9b42d173891c

The source of the problem has been located
diff --git a/src/highlight_provider.ts b/src/highlight_provider.ts
index e495db4..efeb522 100644
--- a/src/highlight_provider.ts
+++ b/src/highlight_provider.ts
@@ -184,8 +184,12 @@ export class HighlightProvider implements Disposable {
             if (groups.length === 1) this.visualHighlightId = id;
             else this.visualHighlightIds.push(id);
         }
+        const hasFlash = groups.some((v) => v.startsWith("Flash"));
+        if (hasFlash) {
+            console.log(groups);
+        }
         // if the highlight consists of any custom groups, use that instead
-        const customName = groups.reverse().find((g) => this.configuration.highlights[g] !== undefined);
+        const customName = !hasFlash && groups.reverse().find((g) => this.configuration.highlights[g] !== undefined);
         const customHl = customName && this.configuration.highlights[customName];
         if (customHl) {
             // no need to create custom decorator if already exists


Unify binary executbles into one

Currently we have 4 executables bundle-rpc, bundler-uopool, bundler, create-wallet.
We could create a big binary executable like aa-bundler and put the 4 above into subcommand

That's a good idea. But it needs to cover all possible scenarios: starting single component, starting all components, starting some components (e.g., bundler and uopool, but not RPC).

That's a good idea. But it needs to cover all possible scenarios: starting single component, starting all components, starting some components (e.g., bundler and uopool, but not RPC).

I was thinking just simply pack all these 4  bundle-rpc, bundler-uopool, bundler, create-wallet which current we have and leaving the users to use and combinate by themselves as  we are doing right now.
I think managing all the combinations ourselves is a good practice to manage.

Ok, that's fine. But we still should have one option to start all three components (rpc, uopool, and bundler).

Ok, that's fine. But we still should have one option to start all three components (rpc, uopool, and bundler).

Isn't bundler  is the way?

Bundler can only be the bundling component. Or also uopool and rpc (so all three).


Multi user, let not delete anyone other files

For example if i share the url anyone can delete stop my torrents, is there any way to create per user or ip or session id like http://someip.org:9000/#session_id/ so only those with session id can manage and see thier torrents?
THX!

I feel like user management, authentication, authorization, etc. is beyond the scope of this project. You can try setting up a reverse proxy (like nginx) in front of the server to handle auth and sessions.

nono i mean like ip based check or session check maybe ?

Session requires authentication, which in turn requires user management, etc. See the discussion in #77

Oh and if you want IP-based security, you can either setup your firewall or configure a reverse proxy: Apache or nginx

I have to agree.... the most that bothers me is when some nut job deletes all torrents so he can add his.
What scriptzteam wants is a session based authorization scheme. For instance when a user accesses the site for the first time he gets a session ID based on a hash of his IP and some salt, unix time etc. Adding a torrent will be marked as removable only by that session ID, a timeout of hours or days (if there's already one implemented) or by the owner of the site.
What you've suggested doesn't hinder anyone from removing the torrents. What we wants if to separate superuser rights on what we add vs other users. I should not be able to remove someone else's torrents, nor should he mine.

torx.cat works this way ;)


Symbol overrides don't work

I am trying to use standard override example with the most recent react-sketchapp version and symbol overrides don't work, returning no errors and just a master symbol instance with default sub-symbol.
Sketch version:
52.6

@mathieudutour any news?

haven't had time to look into it no

Kinda found the solution with #412


pkg/datapath/ipcache: stop leaking FD

Once we create the pendingMap we don't close it and leads to FD leakage.
Fixes: 442e22e61a3c ("datapath/ipcache: GC maps when delete is unsupported")
Signed-off-by: André Martins<EMAIL_ADDRESS>

This change is

test-me-please

@aanm We should also close pendingMap in earlier error cases not just success one only.

test-me-please

@borkmann what earlier error cases?


Add Smithy Formatter To Gradle Tasks

When contributing it's easier if there is a gradle task that can take care of formatting the Smithy files according to the project's desired format, such as empty line at EOF.
Doing a clean checkout and running the gradle tasks doesn't show any Smithy file formatter
./gradlew tasks

Please add the Smithy File formatter plugin to this project so it'll be easier and faster to make pull requests and contributions.

The gradle plugin already runs a formatter automatically.... or it's supposed to. Specifically the task is smithyFormat. It doesn't seem to be doing much though....

Ah it seems we just have it disabled on a number of projects


Update to build 20150331-build-10.0-005

This pull request should be merged after https://github.com/enyojs/enyo-ilib/pull/117 in master. I created branch from 'release-2.5.3-pre.16.w'
The ilib-webapp part is already submitted to the TV build.  A "am-ET" is new locale for MR. and new ethiopic calendar feature is include this pull request.  so I hope it could be merged next enyo release to sync with ilib-webapp part.

Added unit test cases to verify support for the following languages: af (Afrikaans), am (Amharic), ha (Hausa), or (Oriya)
Added support for the Ethiopic and Coptic calendars including the calendar date objects, date formatting, date range formatting, and duration formatting
Added getStringJS() convenience method to ilib.ResBundle. This returns a Javascript string object instead of the ilib.String that getString() returns.
Fixed day names in Vietnamese long format from the 3-letter abbreviations of the full names to "CN" (Sunday) followed by "Th 1" (Monday) through "Th 7" (Saturday).
Now uses the 64-bit getTimeExtended() instead of old 32-bit getTime() where possible. The ilib.Date object uses the built-in Javascript Date object to calculate the offset of the "local" time zone, which is faster than the pure JS algorithm and is always in sync with the system time zone db. Using getTimeExtended() effectively widens the time period when the "local" time zone can use the built-in Date for these calculations.
Updated the country name translations for af, am, ha, or, and pa. These are used in address parsing and formatting.
Changed am and pm symbols in Gujarati to "AM" and "PM" to match CLDR.
Fixed unit formatting in Chinese. Removed some bogus directories under js/data/locale/zh and moved the unitfmt.json files in the bogus dirs to the correct places instead so the code can pick them up.

hi @aarontam, this is the enyo-ilib part of the submissions. The ilib-webapp part is already submitted to the TV build.

Hi @gouniLee, we'll merge this in once we're done with our modularization work, thanks.
cc @clinuz

@gouniLee @ericseong @lishammel @aarontam @clinuz
I think we need to take these changes for 2.5 as well -- @ericseong, please confirm.
If so, we'll need a separate pull request for that. @gouniLee, can you prepare one? @aarontam, can you advise / assist as needed?

These changes should immediately be applicable to 2.5.x right? The 2.6+ adoption will have to be done manually later as stated above. @gouniLee will these changes already be included in the upcoming release of ilib? If so, then we will  be able to skip taking this for 2.6 at all and it will come along automatically when we update to that future release.

Yes, this ilib build should be used with enyo 2.5.x. The changes in this build will be in the modularized code as well, as the modularization branch is based on this build. So yes, this can be skipped for 2.6 for now.

Based on the comments before, It looks like that I have to prepare pull request for 2.5.x.  @aarontam Could you  tell me which branch that I have to submit PR?

Hi @gouniLee, the PR should be made against the 2.5-upkeep branch for the 2.5.4-pre.x releases, thanks!

Hi @aarontam I did  PR for 2.5-upkeep branch in order to apply latest version of iLib. Please see the https://github.com/enyojs/enyo-ilib/pull/119. Thank you

It's not correct pull request. I supposed to dd to release-2.5.3-pre.16.w. but I did it to master. Sorry about that. I think It's better to close this PR.


tf.stack returns different shapes when run in eager and graph mode

Please make sure that this is a bug. As per our
GitHub Policy,
we only address code/doc bugs, performance issues, feature requests and
build/installation issues on GitHub. tag:bug_template
System information

Have I written custom code (as opposed to using a stock example script provided in TensorFlow):
OS Platform and Distribution (e.g., Linux Ubuntu 16.04):
Mobile device (e.g. iPhone 8, Pixel 2, Samsung Galaxy) if the issue happens on mobile device:
TensorFlow installed from (source or binary):binary
TensorFlow version (use command below):2.3
Python version:
Bazel version (if compiling from source):
GCC/Compiler version (if compiling from source):
CUDA/cuDNN version:
GPU model and memory:

You can collect some of this information using our environment capture
script
You can also obtain the TensorFlow version with:

TF 1.0: python -c "import tensorflow as tf; print(tf.GIT_VERSION, tf.VERSION)"
TF 2.0: python -c "import tensorflow as tf; print(tf.version.GIT_VERSION, tf.version.VERSION)"

Describe the current behavior
tf.stack(list(np.ones([2,0,3]))).shape
returns EagerTensor with shape [2,0]
Describe the expected behavior
tf.stack(list(np.ones([2,0,3]))).shape
returns EagerTensor with shape [2,0,3] which same as graph mode
Standalone code to reproduce the issue
Provide a reproducible test case that is the bare minimum necessary to generate
the problem. If possible, please share a link to Colab/Jupyter/any notebook.
Eager mode:
import tensorflow as tf
print(tf.stack(list(np.ones([2,0,3]))).shape)
tf.compat.v1.disable_eager_execution()
print(tf.stack(list(np.ones([2,0,3]))).shape)

Other info / logs Include any logs or source code that would be helpful to
diagnose the problem. If including tracebacks, please include the full
traceback. Large logs and files should be attached.

@fsx950223
I ran your code on colab tf 2.3 and did not face the issue mentioned, please have a look at the gist here.

@fsx950223
I ran your code on colab tf 2.3 and did not face the issue mentioned, please have a look at the gist here.

You should run it in eager mode and graph mode

You could test it via follow example:
import tensorflow as tf
import numpy as np

print(tf.stack(list(np.ones([2,0,3]))).shape)
@tf.function
def test():
  print(tf.stack(list(np.ones([2,0,3]))).shape)

test()

The issue is really due to tf.convert_to_tensor which does not handling shape correctly:
% python3
Python 3.7.3 (default, Jun  2 2020, 19:48:59)
[Clang 11.0.3 (clang-1<IP_ADDRESS>)] on darwin
Type "help", "copyright", "credits" or "license" for more information.
>>> import tensorflow as tf
>>> import numpy as np
>>> x = list(np.ones([2,0,3]))
>>> x
[array([], shape=(0, 3), dtype=float64), array([], shape=(0, 3), dtype=float64)]
>>> y = tf.convert_to_tensor(x)
>>> y
<tf.Tensor: shape=(2, 0), dtype=float32, numpy=array([], shape=(2, 0), dtype=float32)>

It looks like tf.convert_to_tensor() in eager mode (or more specifically InitEagerTensor), dropped the dimension of 3.

I would like to work on this issue. How can I remove this error?

Was able to reproduce the issue in 2.6.0-dev20210528,please find the gist here..Thanks !

Hi @fsx950223 !  This issue getting resolved with tf.config.run_functions_eagerly(False) instead of tf.compat.v1.disable_eager_execution(). Attaching gist for reference. Thank you!

@fsx950223 ,Sorry! Can you please check this updated gist again? We have to disable eager execution at beginning of code right?

@fsx950223 I was able to replicate this issue using tf-nightly 2.10.0.dev2022072608, please find the gist here. Thank you!

Hi,
Thank you for opening this issue. Since this issue has been open for a long time, the code/debug information for this issue may not be relevant with the current state of the code base.
The Tensorflow team is constantly improving the framework by fixing bugs and adding new features. We suggest you try the latest TensorFlow version with the latest compatible hardware configuration which could potentially resolve the issue. If you are still facing the issue, please create a new GitHub issue with your latest findings, with all the debugging information which could help us investigate.
Please follow the release notes to stay up to date with the latest developments which are happening in the Tensorflow space.


Add source_file parameter to primary_zone

Signed-off-by: Robert Detjens<EMAIL_ADDRESS>Description
This exposes the cookbook_file source parameter to allow for (existing) zonefiles to be managed by this cookbook if they do not match the expected filename pattern.
Issues Resolved
List any existing issues this PR resolves
Check List

[x] A summary of changes made is included in the CHANGELOG under ## Unreleased
[x] New functionality includes testing.
[x] New functionality has been documented in the README if applicable.

NB: integration tests are failing, but are also doing so on main so not related to this change.


fsstore2: do not complain about empty documents

Fixes: fsstore2.go:102] Key elements are empty. Extracted as ..
Release note:

NONE

This change is

@mandarjog: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/mixer-e2e-smoketest.sh
445218fb3cde9be6558ff7e987a0144b2b23593d
link
/test mixer-e2e-smoketest

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@mandarjog: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/mixer-e2e-smoketest.sh
445218fb3cde9be6558ff7e987a0144b2b23593d
link
/test mixer-e2e-smoketest

prow/mixer-presubmit.sh
5f4d2e06ab500ee6b42a9a3e7b8a12abd70da591
link
/test mixer-presubmit

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/lgtm

/approve

@mandarjog: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/mixer-e2e-smoketest.sh
59a6ef4a1be2bb8371d92b6b84bdf2a745de36e5
link
/test mixer-e2e-smoketest

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest


Random Cards hero scroller in Featured tab

[ ] Full width in iPhone
[ ] 1/3 width in iPad

Implemented in Commit d0e27c78ce1f4f90c2bcbf46ec21edb53b8c3c22.


Finalize Landing View Layout and Styles

Need Final Wires
Blocks #7 - Browser/Device Testing.

Closing, moving all project tracking to JIRA.


Please update the WinGet version of Microsoft.WSL to <IP_ADDRESS>

Is your feature request related to a problem? Please describe.
We use Microsoft Intune to update applications from winget.  The only way I have been able to update WSL is to use the Microsoft.WSL package from winget.
But the problem is that the current version from the winget package source is <IP_ADDRESS>.  If you run wsl --update, the version is upgraded to <IP_ADDRESS>, but Intune will downgrade that version back to <IP_ADDRESS> after a while.  We want the new version for the the networking fixes, especially for DNS resolution.
Describe the solution you'd like
I would like the winget version of Microsoft.WSL updated to match the version available via wsl --update.  Alternatively, please document another way to use Intune to get the latest version of WSL.
Describe alternatives you've considered
We currently have removed the Microsoft.WSL package from users and instructed them to manually update via `wsl --update'.   But that requires administrative access.

/feature But not really.  Logs are not applicable

Created a PR here:
https://github.com/microsoft/winget-pkgs/pull/172883
And automated future releases here:
https://github.com/microsoft/WSL/blob/master/.github/workflows/winget.yml
Thanks for filing! Will close this once the PR closes.


request: improve splitting/creation of local integrated terminal

With a directory/workspace open in a dev-container, splitting a local (not in-container) terminal fails due to the root dir not existing (looking for dir in container, not in local filesystem).
This means you must create a new local terminal and cannot have them split vertically.

I can confirm this issue

I am running VSCode
Version: 1.61.0
Commit: ee8c7def80afc00dd6e593ef12f37756d8f504ea
Date: 2021-10-07T18:11:58.853Z
Electron: 13.5.1
Chrome: 91.0.4472.164
Node.js: 14.16.0
V8: 9.1.269.39-electron.0
OS: Darwin x64 20.6.0

and can confirm this is no longer an issue 👍
Thank you VSC team (and all of those working on the dependencies)!


Tier2 jobs get stuck on a Mac m1 after a while

This probably happens on tier1 jobs too, but I've seen it more often on tier2 jobs, while running locally on my mac.
This behavior is not seen in our production setup on linux hosts.
What to look for in a stacktrace (I get it by looking at http://localhost:6060/debug/pprof/goroutine?debug=2)
goroutine 127028 [syscall]:
github.com/bytecodealliance/wasmtime-go/v4._Cfunc_wasmtime_linker_delete(0x60000a650000)
	_cgo_gotypes.go:2287 +0x34
github.com/bytecodealliance/wasmtime-go/v4.(*Linker).FreeMem.func1.1(0x140015e0608?)
	/Users/stepd/go/pkg/mod/github.com/streamingfast/wasmtime-go/v4@v4.0.0-freemem3/linker.go:31 +0x50
github.com/bytecodealliance/wasmtime-go/v4.(*Linker).FreeMem.func1()
	/Users/stepd/go/pkg/mod/github.com/streamingfast/wasmtime-go/v4@v4.0.0-freemem3/linker.go:31 +0x20
sync.(*Once).doSlow(0x1080c0b20?, 0x14001b60050?)
	/opt/homebrew/Cellar/go/1.20.4/libexec/src/sync/once.go:74 +0x104
sync.(*Once).Do(...)
	/opt/homebrew/Cellar/go/1.20.4/libexec/src/sync/once.go:65
github.com/bytecodealliance/wasmtime-go/v4.(*Linker).FreeMem(0xffffffffffffffff?)
	/Users/stepd/go/pkg/mod/github.com/streamingfast/wasmtime-go/v4@v4.0.0-freemem3/linker.go:30 +0x48
github.com/streamingfast/substreams/wasm.(*Instance).FreeMem(0x14000860310)
	/Users/stepd/go/pkg/mod/github.com/streamingfast/substreams@v1.1.3/wasm/instance.go:33 +0x34

(...)

It also happens on feature/wazero branch when using SUBSTREAMS_WASM_RUNTIME=wasmtime

Fixed https://github.com/streamingfast/substreams/pull/229 (wasmtime not used anymore)


Issue 69

Description of your changes
Note: this PR has a DRAFT status because of the aws_chime_voice_connector_termination_credentials resource needs to upgrade for running with uptest and pre-hooks
Add the following resources:
Moving 1 resource in the batch group:

[x] aws_batch_scheduling_policy

Moving 2 resources in the budgets group:

[x] aws_budgets_budget
[x] aws_budgets_budget_action

Moving 7 resources in the chime group:

[x] aws_chime_voice_connector
[x] aws_chime_voice_connector_group
[x] aws_chime_voice_connector_logging
[x] aws_chime_voice_connector_origination
[x] aws_chime_voice_connector_streaming
[x] aws_chime_voice_connector_termination
[x] aws_chime_voice_connector_termination_credentials

Moving 2 resources in the cloud9 group:

[x] aws_cloud9_environment_ec2
[x] aws_cloud9_environment_membership

Moving 1 resource in the cloudcontrol group:

[x] aws_cloudcontrolapi_resource

Fixes https://github.com/upbound/provider-aws/issues/69
I have:

[x] Run make reviewable test to ensure this PR is ready for review.

How has this code been tested
Manually and Uptest:
aws_batch_scheduling_policy: https://github.com/upbound/provider-aws/actions/runs/3563209290
aws_budgets_budget: https://github.com/upbound/provider-aws/actions/runs/3563300621
aws_budgets_budget_action: https://github.com/upbound/provider-aws/actions/runs/3564412062
aws_chime_voice_connector: https://github.com/upbound/provider-aws/actions/runs/3564946176
aws_chime_voice_connector_group: https://github.com/upbound/provider-aws/actions/runs/3565118989
aws_chime_voice_connector_logging: https://github.com/upbound/provider-aws/actions/runs/3565405186 (need to fix)
aws_chime_voice_connector_origination: https://github.com/upbound/provider-aws/actions/runs/3566280289
aws_chime_voice_connector_streaming: https://github.com/upbound/provider-aws/actions/runs/3571953098
aws_chime_voice_connector_termination: https://github.com/upbound/provider-aws/actions/runs/3572160748
aws_chime_voice_connector_termination_credentials:
aws_cloud9_environment_ec2:
aws_cloud9_environment_membership:
aws_cloudcontrolapi_resource:

/test-examples="examples/batch/schedulingpolicy.yaml"

/test-examples="examples/budgets/budgetaction.yaml"

/test-examples="examples/budgets/budgetaction.yaml"

/test-examples="examples/chime/voiceconnector.yaml"

/test-examples="examples/chime/voiceconnectorgroup.yaml"

/test-examples="examples/chime/voiceconnectorlogging.yaml"

/test-examples="examples/chime/voiceconnectororigination.yaml"

/test-examples="examples/chime/voiceconnectorstreaming.yaml"

/test-examples="examples/chime/voiceconnectortermination.yaml"

/test-examples="examples/chime/voiceconnectorterminationcredentials.yaml"

/test-examples="examples/cloud9/environmentec2.yaml"

/test-examples="examples/cloud9/environmentmembership.yaml"

/test-examples="examples/cloudcontrol/resource.yaml"

/test-examples="examples/chime/voiceconnector.yaml"

/test-examples="examples/chime/voiceconnectorgroup.yaml"

/test-examples="examples/chime/voiceconnectorlogging.yaml"

/test-examples="examples/chime/voiceconnector.yaml"

/test-examples="examples/chime/voiceconnectorgroup.yaml"

/test-examples="examples/chime/voiceconnectorlogging.yaml"


feat: allow flight client passthru args

This change allows the caller to pass arguments through to the underlying flight library when creating a client.  I am bumping the version number to mark when this feature is added.
Additionally, to get this to build on my Ubuntu 23.04 host, I needed to add some version qualifiers to the dependencies which also speeds up the process as well.
Lastly, this repo looks dead, so I've updated the warning in the README to steer towards the recommended client library. I don't want my update to convey freshness or activity that may be unlikely in the future. I'm not certain this particular interface
has no continuing value, however, so I left the wording pretty vague and non-committal. There may be additional context I'm missing.
I ran make test:
=============================================================================================== test session starts ===============================================================================================
platform linux -- Python 3.11.4, pytest-7.4.2, pluggy-1.3.0
rootdir: /home/reidk/flightsql-dbapi
plugins: cov-4.1.0
collected 14 items

tests/test_dbapi.py ....
tests/test_integration_dbapi.py sssssss
tests/test_integration_sqlalchemy.py sss

---------- coverage: platform linux, python 3.11.4-final-0 -----------
Name                      Stmts   Miss  Cover
---------------------------------------------
flightsql/__init__.py         5      0   100%
flightsql/client.py         161    104    35%
flightsql/dbapi.py          233    102    56%
flightsql/exceptions.py      20      0   100%
flightsql/sqlalchemy.py      94     44    53%
flightsql/util.py             7      3    57%
---------------------------------------------
TOTAL                       520    253    51%

========================================================================================== 4 passed, 10 skipped in 0.41s ==========================================================================================

i'm happy to merge this but just want to check that @powersj ended up getting permissions on this repo as well?

@helenosheaa I still seem to not have permission :\


Psr3AccessLogDecorator does not replace placeholders

The Psr3AccessLogDecorator does not replace placeholders in Psr3AccessLogDecorator::log().
https://github.com/zendframework/zend-expressive-swoole/blob/69c36f044aa22cf0b202eedeb3fc8f31cfb6f023/src/Log/Psr3AccessLogDecorator.php#L134-L137
https://github.com/zendframework/zend-expressive-swoole/blob/69c36f044aa22cf0b202eedeb3fc8f31cfb6f023/src/Log/StdoutLogger.php#L98-L105

Should we just copy/paste the code or move it to a re-useable method or abstract class?

The way PSR-3 is worded is that values provided in $context MAY be used to replace any corresponding placeholders in the message (see section 1.2 of the PSR-3 spec). The StdoutLogger we supply does this, because it's useful, but implementations do not NEED to.
If you use Monolog, for instance, you have to add its PsrLogMessageProcessor to the instance for it to do any replacements. Others, such as apix/log do it out of the box.
As such, if and how placeholders are replaced is up to the PSR-3 logging implementation you choose. If the instance you are using does not support them, decorate your logger's log() method to do so.


feat(action/inject): resume partial injections below size threshold

This offers cross-seed the highly requested ability to resume partial matches without user intervention. Also, we will now recheck and resume all non torrent based searchees as well since we can't tell if a data/virtual searchee is completed.
If users are using matchMode: safe, then all injections will be rechecked and only resumed if 0B are remaining. This makes matchMode: safe completely safe in every scenario.
The maximum that we will resume is 50MB remaining. This was chosen as it should resume all normal partial matches while never resuming those from ensemble and for the inject-saved-torrents feature to only download missing data once between partial matches on different trackers. We do not need to check for fuzzy ratio as the decide stage already has for partial matches.
In the worst case, say a user has 100 partial matches for a single tracker, the maximum download from this would be 5GB. This will never happen however as 50% of my partial matches are below 1MB, 80% under 10MB and 95% under 20MB. And that's from testing with an aggressive fuzzySizeThreshold of 0.1 and including ensemble matches. So a user would likely need at least 1,000+ partials on a single tracker for 5GB of cross-seed download.
This was implemented in an extremely safe way:

After injecting a partial, start a background function to check the torrent status
Check every 15s. If it's in a rechecking state, repeat. Timeout of 1 hour.
If it's not paused, early exit.
If size remaining greater than max, early exit.
Resume otherwise.

To cover the case where cross-seed has restarted or the timeout elapsed, we also check with the hourly inject job and can resume from there.

[ ] Implement for rTorrent, not comfortable with API

Based on discussions I've had, I forsee some people will inherently not trust our code and judgment on resuming. What do you think about the idea of having a way to disable this functionality?
The most obvious solution is an option like resumePartials or something that is boolean, or perhaps a threshold with an upper limit?
I'm not sure if this is entirely possible to implement with a simple if, but it would seem to me that this is going to ruffle some feathers for the people who micromanage the hell out of their cross-seeds.

If they don't want it to be automatically resumed, then they shouldn't be using partial.
But if we are going to give the option, the option should be the amount resumed with an upper limit of 50MB.


Open Weekly Note unable to create new file

The issue I'm having here is pretty bizarre.  So I downloaded the plugin yesterday (Aug 8 2023, 32nd week of August) and ran the "Open Weekly Note" command.  All goes well, except that it created a note for week 31 (one week behind).  Upon attempting to open that already-created note, I get the following error: "Unable to create new note"
I checked that I had my name template proper in the config files, and that is proper.  My format is as such:
[W]W YYYY
The little indicator helper to the left states "W23 2023" - the proper date.
I'm not exactly sure why this happens, but it sure is annoying, having to manually open my weeklies that are one week behind.
In the JS Developer Console, I get the following error:
failed to create file: 'Weekly/W31 2023.md' Error: File already exists.
    at t.<anonymous> (app.js:1:1023347)
    at app.js:1:236930
    at Object.next (app.js:1:237035)
    at a (app.js:1:235753)
createWeeklyNote @ plugin:periodic-notes:387

But this is the only output that I've been given.

Likely duplicate of #185 - am experiencing this as well, see comments there.


What is the equivalent of /var/run/docker.sock in Windows container?

http://stackoverflow.com/questions/27879713/is-it-ok-to-run-docker-from-inside-docker
So the best practice is to map the sock, but how do we do that in the Windows Server 2016 TP5?
Best,

@xied75 there's currently no way to do that that I know up. On Windows, the Docker engine is on a named pipe:  //./pipe/docker_engine. But it cannot be mounted with -v.

I'll close this issue, because I think this is answered, but feel free to continue the discussion

@friism Thanks for the answer. Is there plan to work around this?


Add hasMinimumValueScale parameter to autoscale linechart y-axis

Description

For Line charts a parameter hasMinimumValueScale to adjust the Y axis scale in the case of only positive and non-zero values was added, the parameter is false by default.
Motivation and Context

Issue: https://github.com/britecharts/britecharts/issues/866
How Has This Been Tested?

When the data set contains only positive values greater that zero the y-axis should have a minimum value
positive and non-zero, and the maximum closer or equal the max value of the data set.
Screenshots (if appropriate):

Types of changes

[ ] Refactor (changes the way we code something without changing its functionality)
[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[ ] Latest master code has been merged into this branch
[ ] No commented out code (if required, place // TODO above with explanation)
[x] No linting issues
[x] Build is successful
[x] Code follows the API Guidelines
[ ] Updated the documentation
[x] Added tests to cover changes
[x] All new and existing tests passed

@all-contributors add @alexisbcc for 💻

@all-contributors add @alexisbcc for code


test(reduce): add test against breaking unsubscription chain

For issue #875.

Merged with 460d510, thanks @staltz . (maybe I need merge-and-thanks to staltz script? :sunglasses: )


ReactJS: observable proceeds to execute even if unsubscribed

Describe the bug
Following the documented pattern of use with ReactJS, where an observable is subscribed to in the componentWillMount and unsubscribed in componentWillUnmount, sometimes leads to Warning: Can't call setState (or forceUpdate) on an unmounted component.
Example
https://codepen.io/anon/pen/EGaWEX
Expected behavior
Expecting that the subscribe function is not executed after unsubscribe

This should be resolved as of NanoSQL v1.8.0.


Assignment 3 - Marsh

Still have issues with the Parser.hs file and trying to get the stack. Error below:

src\Adder\Lang\Parser.hs:48:19: error:

* Couldn't match type Statement with [Statement]
  Expected: ParsecT String () (IndentT Identity) [Statement]
    Actual: IParser Statement
* In the second argument of (<$>), namely statement
  In the expression: Pgm <$> statement
  In an equation for `program': program = Pgm <$> statement
 |

48 | program = Pgm <$> statement
|______________________^^^^^^^^^

Still have issues with the Parser.hs file and trying to get the stack. Error below:

src\Adder\Lang\Parser.hs:48:19: error:

* Couldn't match type Statement with [Statement]
  Expected: ParsecT String () (IndentT Identity) [Statement]
    Actual: IParser Statement
* In the second argument of (<$>), namely statement
  In the expression: Pgm <$> statement
  In an equation for `program': program = Pgm <$> statement
 |

48 | program = Pgm <$> statement |______________________^^^^^^^^^

It's useful to note here that ParsecT String () (IndentT Identity) means the same thing as IParser in this context. So, what it's telling you is that Pgm <$> statement gives you an IParser Statement, but what it needs is an IParser [Statement]. That's because the statement function is an IParser Statement.
This is where the block function that I mentioned earlier in the Zoom would be useful. The type of the block function is block :: IParser a -> IParser [a]. In other words, if you give is a function that parses an a value, then it creates a function that parses an sequence of as on separate lines, as long as they're all indented the same amount (which is what we want).

The pass statement looks to be implemented correctly. I don't know if you need to add "return PassStmt" when you define it in the parser. I could be wrong, but I don't think you need it.


Async driver removing connection twice from pool

I encountered the same issue and the same error output as in https://github.com/neo4j/neo4j-python-driver/pull/598
The error states: ValueError: deque.remove(x): x not in deque
The Neo4j Version that we are using is 4.4.3 Community edition running as a single instance.
We are using the experimental driver version 5.0.0a1, so we expected that there might be slight issues like these but we are hoping this can get fixed.
It doesn't happen every time we send a few requests at the same time, but occasionally this happens and we don't get an expected response back but the error message instead.

Hi and thanks for reaching out.
This is in fact the exact same bug. 5.0.0a1 got cut off from 4.4.1. That's why the fix for this issue (released with 4.4.4) is not part of the preview release. However, the fix also got merged into 5.0 https://github.com/neo4j/neo4j-python-driver/pull/732. So it will be part of the next 5.0 release (5.0.0a2) which should go out very soon.
I'll close this issue as it's already fixed (but unreleased). Please feel free to keep commenting if you have further questions or to re-open it, should the bug turn out to still be present in 5.0.0a2.


Add tf.strided_slice op

I have noticed many estimators are generating this op.
https://www.tensorflow.org/versions/master/api_docs/python/tf/strided_slice

This issue was moved to tensorflow/tfjs#138


uses-sdk:minSdkVersion 16 cannot be smaller than version 18 declared in library

**> /android/app/src/debug/AndroidManifest.xml Error:

    uses-sdk:minSdkVersion 16 cannot be smaller than version 18 declared in library [:bluetooth_print]**

I stuck on this error in 2 days. I found the solution to this issue.
Open printer_app/android/build.gradle:
Change the following line as lower version.
android {
    compileSdkVersion 28

    defaultConfig {
        minSdkVersion 16  // Before it was 18
        testInstrumentationRunner "android.support.test.runner.AndroidJUnitRunner"
    }
    lintOptions {
        disable 'InvalidPackage'
    }
}

However, I found the solution. I don't understand minSdk problem.

Hello, can you send me your project with this library please?  i tried to use the documentation but it didn't work, and i need this lib for my project of the school

@edgarsingui just clone this repo and run the example


Update refile-mongoid.gemspec

Changed mongoid dependency version specification to ">= 4.0" to make the gem work with the new version of Mongoid (5.0.0.beta).
I tried it on my project and it seems to be working just fine.
Related to issue https://github.com/DimaSamodurov/refile-mongoid/issues/1

Thank you, @michalvalasek


Moved administrative UI templates to templates/settings/

Added several commits with the aim to move administrative UI templates to /templates/settings folder.
The templates moved are:

[x] admin_bot_form.hbs -- ad6b592970f147f5daad7bc74da2da113ad846a2
[x] admin_default_streams_list.hbs -- 769ffd0
[x] admin_emoji_list.hbs -- 730b761
[x] admin_export_list.hbs -- d444b3e
[x] admin_human_form.hbs -- 8e1b4ed6404b03f3a05acf1b9bb9efa5ef8e4913
[x] admin_invites_list.hbs -- f088134
[x] admin_linkifier_list.hbs -- ac35bc4
[x] admin_profile_field_list.hbs -- 1f85c02
[x] admin_settings_modals.hbs -- d192b32
[x] admin_tab.hbs -- 482400f
[x] admin_user_group_list.hbs -- 3f22713
[x] admin_user_list.hbs -- cc300e8

Fixes #18227
Testing plan
Manually grep(ed) all the occurrences of the above listed template within /static/js folder and tested out each of the organizational template within the local development setup.
Edit: Not sure if it's well, but creating separate commits for each modified template looked fine in my opinion and thought would create much cleaner git history and will be easy to debug if found any regression issue :)

Separate commits are great, merged after adding an additional template I noticed while reviewing, thanks @aryanshridhar!
One bit of feedback on the commit messages: Generally we don't do code blocks or leading /s in paths in commit message titles.  I didn't feel it worth redoing all of these to correct that.


update file

Hi
Great work, (I like cmd line!). Could you please add 'update' looks like it is possible with: https://developers.google.com/drive/v2/reference/files/update
I am not a go programmer!
Many thanks

@gedw99 What? The link blophysics referenced is on their API page. What's the problem?

Ah yes found it !! Thanks

Hi everybody ! !
According to your discussion.
What is the command line for update a file ?
Regards

Did anybody figure this out?

Im currently working on gdrive v2, which will support update.

+1 !

gdrive 2 is now available.
$ gdrive update 0B3X9GlR6EmbnNTk0SkV0bm5Hd0E gdrive-osx-x64
Uploading gdrive-osx-x64
Updated 0B3X9GlR6EmbnNTk0SkV0bm5Hd0E at 2.0 MB/s, total 8.3 MB

$ gdrive revision list 0B3X9GlR6EmbnNTk0SkV0bm5Hd0E
Id                                                    Name             Size     Modified              KeepForever
0B3X9GlR6EmbnOFlHSTZQNWJWMGN2ckZucC9VaEUwczV1cUNrPQ   gdrive-osx-x64   8.3 MB   2016-02-21 20:47:04   False
0B3X9GlR6EmbndVEwMlZCUldGWUlPb2lTS25rOFo1L2t6c2ZVPQ   gdrive-osx-x64   8.3 MB   2016-02-21 21:12:09   False


Update Immer & Fix Import Issues

Updated immer version to latest and fixed issues with the imports. Was using ES5 syntax before and the new immer version would break since the default import wasn't the produce function.
Just named the imports and tests passed.
P.S. I hate that I have to make this PR, I want to remove using this as a dependency but when I did and decided to fix all the issues that came from it, the PR was like 300 files and not worth the time to do it all at once.

I think I can work around this for now by just forcing a lower immer version


Default Emoji Type

Adds a default emoji type.
Second part of #195
It would be cleaner to include twemoji-parser, but wanted to hear your opinion first before adding more dependencies.

Just add a dependency so we don't have to maintain the regex ourselves.

Just add a dependency so we don't have to maintain the regex ourselves.

Will do, should have the updated PR ready this coming weekend.

Will do, should have the updated PR ready this coming weekend.

hey! im not sure if its because of this merge, but my bot doesnt work since this anymore...
here is the error code. im using typescript. here is my repo

pls help

hey! im not sure if its because of this merge, but my bot doesnt work since this anymore...
here is the error code. im using typescript. here is my repo

pls help

hey! im not sure if its because of this merge, but my bot doesnt work since this anymore...
here is the error code. im using typescript. here is my repo

pls help
Can second this!

hey! im not sure if its because of this merge, but my bot doesnt work since this anymore...
here is the error code. im using typescript. here is my repo

pls help
Can second this!

for the time being, i have referenced the commit before in package.json
it works now. hope it helps @anomalilies

for the time being, i have referenced the commit before in package.json
it works now. hope it helps @anomalilies

Guys...
A new dependency was added. Install it. This is not a bug.

Guys...
A new dependency was added. Install it. This is not a bug.


verison of R?

Hi! What version of R did you guys use to write the snakemake scripts? I keep getting weird dependency issues for packages that don't seem to install on some versions of R (ie rgeos, rgdal) when I run the snakemake script. Thanks!

hi @mooreann did you solve it. I am having similar issue. it would be great if you can share your solution.

Yes! I was able to

install terra via mamba install -c conda-forge r-terra, which allowed me to then

install.packages("raster") in R

rgeos has been archived, but was able to install it manually in R via

packageurl <- "https://cran.r-project.org/src/contrib/Archive/rgeos/rgeos_0.6-4.tar.gz"
install.packages(packageurl, repos=NULL, type="source")

Thank you very much for your reply. I am still encountering an error with rgeos. May I ask which version of R you used for this?


[ansible/artifactory_nginx] Added support for Docker registries via subdomain

PR Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

[x] Title of the PR starts with installer/product name (e.g. [ansible/artifactory])
[x] CHANGELOG.md updated
[x] Variables and other changes are documented in the README.md

What this PR does / why we need it:
This is an implementation for #136
I introduced a bool varaible to add redirect cnfiguration to nginx to be able to use the docker-subdomain feature.
Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #136
Special notes for your reviewer:

@MatrixCrawler  Thanks for the PR , will be taking in 10.9.0 release (along with next minor version of artifactory)


Updating egui and egui_glow to 0.24

Used Rc instead of Arc in Context to make it compatible with egui https://github.com/emilk/egui/pull/3598

Thanks for the PR! 🙏 And sorry for the late reply. It's very unfortunate that the context is not send+sync anymore in egui since it actually breaks some applications (some frameworks creates the context in another thread). Fortunately, it seems like this change will be reverted in 0.25 https://github.com/emilk/egui/pull/3646 🥳 so I'll close this PR and wait for 0.25 release of egui before updating.


CQ-4350702 Fix form submission failing in Sites

Description
Currently form submission is failing in Sites since rest APIs expects guide container to be located at /content/forms/af/<form-name>/jcr:content/guideContainer
However, in a Sites page this is not guaranteed.
With this PR, we will be sending the encoded guide container path to the rest APIs instead of just sending the encoded path of the page/form.
This PR will help in fixing following bugs:

Fix form submit in Sites.
In case of multiple form containers, we should always show thank you page/message for which submit is clicked. This PR fixes that. We will be fetching form container using path instead of data.
currently we always show default thank you page even if we have selected thank you message. This PR fixes that. Exposing thankYouOption/redirectUrl for this, which will do the business logic check in rest APIs.

Note: Skipping submit and prefill tests till we have updated changes for af2-rest-api in aemds.
Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):
Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[ ] I have signed the Adobe Open Source CLA.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[ ] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes and the overall coverage did not decrease.
[ ] All unit tests pass on CircleCi.
[ ] I ran all tests locally and they pass.

pls have unit tests for the APIs.


FL research week of 10/12-16

Contact: Craig F (IT Director), Allison Culpepper (Bureau of Epidemiology)

Closed. Duplicated on Data Hub repo.


Use the new SpanEvent in the traces pipeline

What does this PR do?
A brief description of the change being made with this pull request.
Motivation
What inspired you to submit this pull request?
Additional Notes
Anything else we should know when reviewing?
Review checklist (to be filled by reviewers)

[ ] Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
[ ] Make sure you discussed the feature or bugfix with the maintaining team in an Issue
[ ] Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

Codecov Report

Merging #554 (48ed08f) into mconstantin/rumm-1221/add-data-scrubbing-for-spans (d89fa8e) will increase coverage by 0.13%.
The diff coverage is 100.00%.

@@                                   Coverage Diff                                    @@
##             mconstantin/rumm-1221/add-data-scrubbing-for-spans     #554      +/-   ##
========================================================================================
+ Coverage                                                 88.71%   88.84%   +0.13%
  Complexity                                                 1589     1589
========================================================================================
  Files                                                       175      175
  Lines                                                      5290     5296       +6
  Branches                                                    636      636
========================================================================================
+ Hits                                                       4693     4705      +12
+ Misses                                                      357      355       -2
+ Partials                                                    240      236       -4

Impacted Files
Coverage Δ
Complexity Δ

...g/internal/domain/TracesFilePersistenceStrategy.kt
100.00% <100.00%> (ø)
1.00 <0.00> (ø)

...internal/tracking/JetpackViewAttributesProvider.kt
73.91% <0.00%> (-13.04%)
12.00% <0.00%> (-1.00%)

...sistence/file/advanced/ConsentAwareFileMigrator.kt
88.24% <0.00%> (-2.94%)
12.00% <0.00%> (-1.00%)

...c/main/kotlin/com/datadog/android/DatadogConfig.kt
93.94% <0.00%> (-1.52%)
11.00% <0.00%> (-2.00%)

...oid/src/main/kotlin/com/datadog/android/Datadog.kt
88.37% <0.00%> (-1.16%)
33.00% <0.00%> (-1.00%)

...l/net/info/BroadcastReceiverNetworkInfoProvider.kt
78.35% <0.00%> (ø)
28.00% <0.00%> (ø%)

...g/android/rum/internal/domain/scope/RumEventExt.kt
83.64% <0.00%> (+0.91%)
0.00% <0.00%> (ø%)

...tadog/android/log/internal/domain/LogSerializer.kt
87.84% <0.00%> (+1.35%)
25.00% <0.00%> (-1.00%)
:arrow_up:

...ernal/instrumentation/gestures/GesturesListener.kt
91.53% <0.00%> (+3.39%)
48.00% <0.00%> (+2.00%)

...droid/rum/tracking/ActivityViewTrackingStrategy.kt
88.68% <0.00%> (+3.77%)
19.00% <0.00%> (+1.00%)

... and 2 more


Add support for username and passwords/passphrases is input

Is your feature request related to a problem? Please describe.
Inside UCS/config file, there might be passwords and passphrases. AS3 schema also allows them.
Example for password
ltm monitor https /Common/test_monitor_password {
    adaptive disabled
    defaults-from /Common/https
    destination *:*
    interval 5
    ip-dscp 0
    password $M$OC$bN53XhCrVMTvO2+ZlApH7A==       <========== password
    recv none
    recv-disable none
    send "GET /\r\n"
    time-until-up 0
    timeout 16
    username test         <======= username
}

Example for passphrase
sys file ssl-key /Common/f5_api_com.key {
    cache-path /config/filestore/files_d/Common_d/certificate_key_d/:Common:f5_api_com.key_62549_1
    passphrase $M$ar$kSub6Kj+2ZgPVwjyu+1JcVQpqQXjUl/qz+y83S25DopF5Seq0QyAFOD9TjD9SnmQZ/GN1HSIBZCA/eI/kJHvJuvV2I0jJQZu8bbykERsfPU=
    revision 1
    source-path file:///config/ssl/ssl.key/f5_api_com.key
}

Describe the solution you'd like
The passwords/passphrases are added to output objects according to AS3 schema:
        "monitorLDAP_nonDefault1": {
          "class": "Monitor",
          "username": "Adm-nM+nkey",   <===== username
          "passphrase": {
            "ciphertext": "ZjVmNQ==",      <===== password
            "protected": "eyJhbGciOiJkaXIiLCJlbmMiOiJub25lIn0",     <======= see below
            "ignoreChanges": true
          },
          "base": "dc=bigip-test,dc=org",
          "filter": "objectClass=employee"
        },

                "webcert1": {
                    "class": "Certificate",
                    "remark": "replace these with real certificates and keys",
                    "certificate": "...",
                    "chainCA": "...",
                    "privateKey": "...",
                    "passphrase": {
                        "ciphertext": "ZjVmNQ==",      <===== password
                        "protected": "eyJhbGciOiJkaXIiLCJlbmMiOiJub25lIn0"  <======= see below
                    }
                },

According to:
https://clouddocs.f5.com/products/extensions/f5-appsvcs-extension/latest/refguide/schema-reference.html#monitor-radius-passphrase "protected" field description:
So as I understand it - if there is "$M$" prefix inside the password content, which indicates that SecureVault is used to encrypt the value, then:
"protected"="eyJhbGciOiJkaXIiLCJlbmMiOiJmNXN2In0"
else:
"protected"="eyJhbGciOiJkaXIiLCJlbmMiOiJub25lIn0"
Regards

The "protected" strings are base64, so if you forget which is which, just decode them.  One is {"alg":"dir","enc":"f5sv"} and the other is {"alg":"dir","enc":"none"}.

Discussing on the DEV call this Thursday.

https://github.com/mdditt2000/f5-appsvcs-acc/tree/master/Github/40

Created Jira CHARON-404 for PM tracking

@makagonr issue is resolved in a Pre-release. Please get the image from the link in the Jira CHARON-404. Closing this out


add post action rule api

Add endpoint to create action rule
Will need: https://github.com/ONSdigital/rm-actionsvc-api/pull/12

 TBL123: Scheduling Collection Exercise event dates and Action Service actionplan/job trigger redesign (XXL)

Codecov Report

Merging #39 into master will increase coverage by 0.31%.
The diff coverage is 86.36%.

@@            Coverage Diff             @@
##           master      #39      +/-   ##
==========================================
+ Coverage   70.74%   71.05%   +0.31%
==========================================
  Files          37       37
  Lines        1080     1102      +22
  Branches      119      122       +3
==========================================
+ Hits          764      783      +19
- Misses        280      283       +3
  Partials       36       36

Impacted Files
Coverage Δ

...nse/action/service/impl/ActionTypeServiceImpl.java
0% <ø> (ø)
:arrow_up:

...nse/action/service/impl/ActionRuleServiceImpl.java
0% <0%> (ø)
:arrow_up:

...p/response/action/endpoint/ActionRuleEndpoint.java
100% <100%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2b13458...983f492. Read the comment docs.


⚠ Cioos Pacific CKAN has degraded performance

In 1fcc593, Cioos Pacific CKAN (https://catalogue.cioospacific.ca) experienced degraded performance:

HTTP code: 200
Response time: 6497 ms

Resolved: Cioos Pacific CKAN performance has improved in 74c731b after 25 minutes.


opera-gx: Add version 83.0.4254.66

What type of Apps related PR is this? (check all applicable)

[x] ✨ Add Manifest
[ ] ♻ Refactor
[ ] 🐛 Bug Fix
[x] 👷 Optimization
[x] 🚩 Other

Description

Adding Opera GX and adding the "default apps" discovery, which is not available from the other scoop buckets
Related Tickets & Documents

None
Did you verify the followings

Add/Modify a description in the manifest?

[x] 👍 yes
[ ] 🙋 yes, but I need help
[ ] 🙅 no, because they aren't needed

Check URLs?

[x] 👍 yes
[ ] 🙋 yes, but I need help
[ ] 🙅 no, because they aren't needed

Update to the latest version?

[x] 👍 yes
[ ] 🙋 yes, but I need help
[ ] 🙅 no, because they aren't needed

Update Hashes?

[x] 👍 yes
[ ] 🙋 yes, but I need help
[ ] 🙅 no, because they aren't needed

Format the json manifest?

[x] 👍 yes
[ ] 🙋 yes, but I need help
[ ] 🙅 no, because they aren't needed

Did you identify extra steps
Notes in the manifest?

[ ] 👍 yes
[ ] 🙋 yes, but I need help
[x] 🙅 no, because they aren't needed

Application Dependencies?

[ ] 👍 yes
[ ] 🙋 yes, but I need help
[x] 🙅 no, because they aren't needed

Application Suggestions?

[ ] 👍 yes
[ ] 🙋 yes, but I need help
[x] 🙅 no, because they aren't needed

Pre-installation steps to perform?

[x] 👍 yes
[ ] 🙋 yes, but I need help
[ ] 🙅 no, because they aren't needed

Post-installation steps to perform?

[x] 👍 yes
[ ] 🙋 yes, but I need help
[ ] 🙅 no, because they aren't needed

File persistence to perform?

[x] 👍 yes
[ ] 🙋 yes, but I need help
[ ] 🙅 no, because they aren't needed

[optional] What gif/emoji best describes this PR or how it makes you feel?

:sparkles: :bento: :children_crossing: :alembic:

All changes look good.
Wait for review from human collaborators.
opera-gx

[x] Description
[x] License
[x] Hashes
[x] Checkver
[x] Autoupdate
[x] Autoupdate Hash Extraction

I updated the gitattributes to support it...


Update the metadata to support Gnome 47 release

Very simple update to support Gnome 47 - did some local testing and a review of the changelog, this works on 47 fine.
{
  "description": "Adds transparency effects (including notification tray) and slims the top bar for more space. See github page for more screenshots.",
  "name": "Compact Top Bar",
  **"shell-version": ["46","47"],**
  "url": "https://github.com/metehan-arslan/gnome-compact-top-bar",
  "uuid"<EMAIL_ADDRESS>  "version": 6
}

Thanks!


Evaluate FB Messenger Changes based on 03022017 change log

https://developers.facebook.com/docs/messenger-platform/changelog?pnref=story

This can now be closed. All features were broken down on the project.


Documentation inconsistent about preprocessor macros identifying AMD or NVIDIA platform

HIP_PLATFORM_AMD or __HIP_PLATFORM_AMD__ ?
HIP_PLATFORM_NVIDIA or __HIP_PLATFORM_NVIDIA__ ?
The paragraph Identifying HIP Target Platform should be more explicit in use of "is defined".
If talking about a preprocessor macro definition, then these names without double underscore are inconsistent with the following paragraph.
If talking about an environment variable set, then say "is defined in the environment".  ( I suspect this is not the case, what would define such a variable )
This HIP FAQ by AMD suggests the right macro is no double underscores.

Hello,
Thanks for pointing it out. The macro is definitely an issue and will fix it. The correct macro has underscores
The FAQ's env variable are used for config/compiling HIP or running hipcc. That does not have underscores.

@Noerr Internal ticket has been created to resolve this issue? Thanks!

Not sure how https://github.com/rocm-ci/HIP/commit/918214ecabd2608058d615471249150b0a549fc4 was overwritten but the macros have once again been updated in https://github.com/ROCm/HIP/pull/3636. As @jatinx mentioned, the correct macros have underscores. Thanks again for bringing this up!


Container iteration maybe needs to be fallble

The check that size has not changed can lead to a panic. In practice this can happen in downstream code: https://github.com/pydantic/pydantic/issues/7832
Maybe container iteration needs to return results always?

In practice this can happen in downstream code:

From my point of view, whether this is a reason to reconsider the panic depends on whether the issue in pydantic-core can be classified as a logic bug or not. If it is indeed a logic bug, then a panic seems appropriate.
(To be honest, I have a hard time imagining this not being a logic bug as concurrent iteration and modification should hardly depend on user or other external input, but the possibility of this happening or not should be entirely within the purview of the author of a program.)

I completely agree that there's a logic bug in pydantic-core, which needs some rethinking.
I think the question here is what the fallout of such a bug should be. IMO a panic is always unfortunate because it brings down the process, so the upside of switching to fallible iteration would be that future logic bugs just raise an exception. The downside would be the churn of the ecosystem and reduced ergonomics, so maybe it's just not worth it.

I am also not sure whether doing anything but .unwrap() on the result is reasonable. (This is what I would in a pure Rust code base to handle a logic bug.) I understand the ergonomics of catching PanicException are not good, but I would rather improve that than "downgrade" this into a runtime exception.

Let's close this for now then 👍


add command-line flags for agent command(#152)

What this PR does / why we need it:
This PR adds long flags that can set all configurations of Agent.
Which issue(s) this PR fixes:

Fixes #152
Special notes for your reviewer:
It assigns command-line flags directly to the configuration struct variable.
timeout-second variables don't be assigned directly from command-line flags. Because to assign duration variable from command-line arguments, users have to specify the time unit. (5s, 1m...) this form doesn't fit with the flag's name(timeout-'second'.)
ETCD endpoints don't be assigned directly too. Because etcd config's pointer is nil for default.
Does this PR introduce a user-facing change?:

Add flags that can set all configurations of Agent

Additional documentation:

Checklist:

[x] Added relevant tests or not required
[x] Didn't break anything

It would be nice to consider changing the timeout-second variable to duration as well. We can easily convert it using ParseDuration.
I think it's good to start with a separate issue.


Add option to clear URLs in History

Description
Currently only storing the last 25 URLs. Would be nice to have the ability to clear expired URLs from the History and expire URLs early.
Ideas

Add button to clear expired URLs from History
Add action dropdown to

Remove URL from History
Expire the URL early

Closed by #7 MR


Added DynamoDB Table Stream

added the ability to create a DDB Stream in the L2 construct. Change is backwards compatible in that it will not enable a stream if the stream property isn't set.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license.

Awesome. I’ll make these changes today.

On Aug 28, 2018, at 2:29 AM, Elad Ben-Israel<EMAIL_ADDRESS>wrote:
@eladb requested changes on this pull request.
In<EMAIL_ADDRESS>
@@ -23,6 +23,12 @@ export interface TableProps {
* @default
*/
tableName?: string;

/**

* The Type of Stream to create.

* @default ''

*/

streamSpecification?: cloudformation.TableResource.StreamSpecificationProperty;
We usually don't like to expose the raw CloudFormation data types in this layer since normally there's a way to provide a richer API. This is a great example for this. the [StreamSpecification] property basically has a single string field that can accept a bunch of possible values. Instead of sending users to read the docs and find what are the allowed values (failing only in deploy-time), we can just provide a simple enum:

export enum StreamViewType {
NewImage = 'NEW_IMAGE',
OldImage = 'OLD_IMAGE',
NewAndOldImages = 'NEW_AND_OLD_IMAGES',
KeysOnly = 'KEYS_ONLY'
}
Also, copy & paste the documentation from the DynamoDB manual as jsdocs on these enum members so users have all the information.
I also don't see any need for a nested structure here. We can use the fact that this is an optional field to determine if streams are enabled. So you can just call this streamViewType and indicate under @default that if this is not defined, DDB streams are disabled.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.

A couple of minor fixes and we'll merge this in

Cool, I'll wait for the PR builds to pass and merge in


SAK-31449 Quick way to skip deployment of components/webapps

This means if we want to deploy SNAPSHOT artifacts we don’t include all the bundles which are very large. Quick local test shows it’s about 94MB for a full build.

Updated to catch artifacts that got missed by the file based profile activation.
Also switch to just setting the property as this can be overridden on the command line if somewhere wants to deploy the whole lot.


Clarified Hookbin usage details

Hookbin web site is down for a few days (returns 502 Bad Request for https://hookbin.com/api/bins) so I thought I could use any other similar web service for the same thing.
I went for Mockbin and it took me an hour of reading up around to get that actually hookbin usage is hardcoded. This may repeat in the future for somebody therefore I believe it is a useful note.

We are looking to replace hookbin with something more reliable, but for now this seems fine #sign-off