Extend API functionality with new GET search function

For some services it is more convenient to use the HTTP GET request for search purposes. For example, Logstash rest filter plugin (https://github.com/lucashenning/logstash-filter-rest) is more adapted for HTTP GET.

Developed in 98b5b4ad57d7c0a007e310163e13f4a4ffff5b2b


Add a few more merge-related bindings

Adding repo.merge_commits() here, repo.cleanup_state(), as well as ref.set_target()

Overall looks great to me, thanks @tksfz!

Btw  check the conversation here for reference.rs (showing up as hidden for an outdated diff):
So when I pass in 0 as *const libc::c_char  for msg (to the raw call), everything seems to work (in at least one particular case).  The reflog records an empty message.
Do you  want  me to make msg an Option?  I could do that but then we might want  to  modify the  existing reference.rename() function, which also takes a  msg argument, to be the same.
IMHO I'd be inclined to leave it as msg: &str.  If people want an empty log message they can/should pass in empty string.

Thanks!

(not having an Option is fine)


Changes to layout

Added as a commit to https://github.com/ministryofjustice/formbuilder-product-page/pull/40

Added as a commit to https://github.com/ministryofjustice/formbuilder-product-page/pull/40


Update PyProject Toml - License

Hey! HaoHao from comfy.org again 😊.
As a heads up, the license field is optional but in the case that it is filled out, the license file should be referenced as follows

license = { file = "LICENSE" } ✅
license = "LICENSE" ❌

This was brought up in our discord and so we're creating a small PR to update that optional field. For more info check out toml file standards or our docs page!

Edited this one to {text = "MIT License"} after reading documentation.


Error: line contains NULL byte

Hi,
I get this error when I try to run the script? Any ideas on how I can solve this?
./csv2sqlite.py ~/temp/*****/test.csv ~/temp/*****/test.db
Traceback (most recent call last):
  File "./csv2sqlite.py", line 198, in <module>
    convert(args.csv_file, args.sqlite_db_file, args.table_name, args.headers, compression)
  File "./csv2sqlite.py", line 66, in convert
    types = _guess_types(type_reader, len(headers))
  File "./csv2sqlite.py", line 140, in _guess_types
    for row_index,row in enumerate(reader):
_csv.Error: line contains NULL byte

Interesting! Let me see..

Is test.csv your own file, or the one described in the README? This seems relevant: http://stackoverflow.com/questions/4166070/python-csv-error-line-contains-null-byte

Hi,
Thanks for the fast reply.
It's my own file. Might it be because it does not have headers?


Tshark displays destination IP and source Port.

The tshark command given here captures destination IP and source Port. Doesn't displaying IP of source and port of destination make more sense? I tried changing the command to tshark -Y "ip.dst != xyz.xyz.xyz.xyz" -T fields -e ip.src -e tcp.dstport but there's no difference  in output. Probably because everything is running locally and there's no external IP trying to connect to it.

potential awkward bug, I've to check and get back to you. thanks for reporting.

ok, I remember what I did there, so if you run tshark and look into requests, there are two kind, incoming and outgoing. instead oof capture incoming I am capturing outgooing which is not wrong, but it's not right too.
root@9eb6f3ce0289:/# tshark -l -V -T fields -e ip.dst -e ip.src -e tcp.srcport -e tcp.dstport -ni any
Running as user "root" and group "root". This could be dangerous.
Capturing on 'any'
<IP_ADDRESS>	<IP_ADDRESS>	48034	80
<IP_ADDRESS>	<IP_ADDRESS>	80	48034

so outgoing and incoming has exact opposite src and dest. and I used hacky wrong way to split them...
 try:
                        ip, port = str(line.rsplit()[0].decode()), int(line.rsplit()[1])
                    except Exception as _:
                        ip, port = None, None
                    # check if event shows an IP
                    if (netaddr.valid_ipv4(ip) or netaddr.valid_ipv6(ip)) \
                            and ip not in ignore_ip_addresses \
                            and port not in ignore_ports:  # ignored ip addresses and ports in python - fix later
                        # check if the port is in selected module

also that comment meant to be for this issue and I totally forget about.
so I will try to fix it soon and do the right way....
thanks for bringing this up.

I see! In the above case the incoming and outgoing ports are same. However, AFAIK the incoming port (client side) is chosen at random by the OS. Since we already have the code to parse ip and port, I think if we just change the command to view destination port tshark -l -V -T fields -e ip.src -e tcp.dstport the issue can be solved. If there's something that I'm missing please let me know!

I did some changes in #65, hopefully is now much less confusing?

Thanks! less confusing now.


Send / Receive buttons not working until restart

A user made their first lightning receive, then tried to click the send or receive button. It was pressed in the UI but nothing else happened until they restarted the PWA. This is on iOS.

I've reproduced this by clicking on the channel closure activity item. We didn't have that before when this user had the problem but perhaps it helps highlight where the problem is. We don't have the activity pop up built out for channel closures yet, but it might not be easily reproducable after we figure that out.
The whole app won't allow me to click on anything until a restart, but the buttons for send and receive do look pressed in.


Core: inconsistent naming with enabled property

Ionic version:  (check one with "x")
(For Ionic 1.x issues, please use https://github.com/ionic-team/ionic-v1)
[ ] 2.x
[ ] 3.x
[x] 4.x
Some of our components (scroll, split pane, tab) use the enabled property with a default of true, but most of them (alert, button, checkbox, fab…) use disabled with a default of false.
These should be renamed to disabled with a default of false. Also look into what this property is actually doing to make sure they're all behaving the same.

All of the enabled properties were renamed to disabled but these I am unsure of:
reorder
  /**
   * If true, the reorder will be hidden. Defaults to `true`.
   */
  @Prop() disabled = true;

refresher
  /**
   * If true, the refresher will be hidden. Defaults to `true`.
   */
  @Prop() disabled = true;

split pane

  /**
   * If true, the split pane will be hidden. Defaults to `false`.
   */
  @Prop() disabled = false;

infinite scroll
  /**
   * If true, the infinite scroll will be hidden and scroll event listeners
   * will be removed.
   *
   * Call `enable(false)` to disable the infinite scroll from actively
   * trying to receive new data while scrolling. This method is useful
   * when it is known that there is no more data that can be added, and
   * the infinite scroll is no longer needed.
   */
  @Prop() disabled = false;

When I think of the disabled property I think of how buttons are still visible but opaque. Should these be renamed something else like show (to match tabs)??
cc @manucorporat @mhartington @camwiegert

I feel strongly that we should unify this and event names before we ship a beta (not necessarily alpha) of Ionic Core.
Thanks,
Dan

I agree that disabled doesn't accurately describe these. I tend to think we should have show and hide boolean props. So, elements that are hidden by default have an optional show prop and elements that are visible by default have an optional hide prop.


isconvex for Polyhedron

If all faces are planar, then a plane may be constructed on each face. If each vertex is on the same side of the face, the polyhedron is planar. Check using dot product with plane normal.

Not needed. Only need to know if faces are planar


Failed to collate messages by topic (LeaderNotAvailableException)

First off let me say thank you for this great image!
A few days ago I was running the image and it was working well.
Lately, though, I've been trying to follow the most basic steps (as listed in the Run section at dockerhub) and it's been erroring with

root@2995acf13535:/opt/kafka_2.11-<IP_ADDRESS>/bin# ./kafka-console-producer.sh --broker-list localhost:9092 --topic test
[2016-08-25 12:06:33,784] WARN Property topic is not valid (kafka.utils.VerifiableProperties)
Hi There
[2016-08-25 12:06:36,183] WARN Error while fetching metadata [{TopicMetadata for topic test ->
No partition metadata for topic test due to kafka.common.LeaderNotAvailableException}] for topic [test]: class kafka.common.LeaderNotAvailableException  (kafka.producer.BrokerPartitionInfo)
[2016-08-25 12:06:36,214] WARN Error while fetching metadata [{TopicMetadata for topic test ->
No partition metadata for topic test due to kafka.common.LeaderNotAvailableException}] for topic [test]: class kafka.common.LeaderNotAvailableException  (kafka.producer.BrokerPartitionInfo)
[2016-08-25 12:06:36,217] ERROR Failed to collate messages by topic, partition due to: Failed to fetch topic metadata for topic: test (kafka.producer.async.DefaultEventHandler)

Just to verify that I'm not doing anything ultra dumb, in linux I'm,

Running the image (using localhost because I'm in linux): docker run -p 2181:2181 -p 9092:9092 --env ADVERTISED_HOST=localhost --env ADVERTISED_PORT=9092 spotify/kafka
Exec-ing into the image: docker exec -it stupefied_wing bash
Navigating to the kafka tools: cd /opt/kafka_2.11-<IP_ADDRESS>/bin/
Starting the console producer: ./kafka-console-producer.sh --broker-list localhost:9092 --topic test
I get a warning here [2016-08-25 12:12:35,959] WARN Property topic is not valid (kafka.utils.VerifiableProperties)
Type in some message... and see above :)

Thanks again, any help would be greatly appreciated.

I also tried setting the hostname
docker run -p 2181:2181 -p 9092:9092 --hostname foobar --env ADVERTISED_HOST=foobar --env ADVERTISED_PORT=9092 spotify/kafka

Got it! It looks like using the console producer does not correctly create the topic. So ./kafka-topics.sh --create ... should be used before producing/consuming.


[Doc] Clarify the behavior of Vector2/3.cross and mention parallel vectors

The exact wording could use some tweaking, would be nice to have an illustration of the returned vector as well added to the docs page as a follow up as well.
See:

https://github.com/godotengine/godot-proposals/issues/9413

Thanks!

Thank you!

Cherry-picked for 4.2.2.

Cherry-picked for 4.1.4.

Cherry-picked for 3.6.
Cherry-picked for 3.5.4.


Feature Request: Context-sensitive escaping in docker-compose env files

We are using the replacetokens task to (among other things) replace placeholders in env files for docker compose.
These files have very specific requirements on escaping.
Currently we are using the "Replace Tokens" task, but it does not currently support escaping in these env files.
I realize this is a very specific use-case, but it is not possible to cover it with the custom-escaping config, due to the context-sensitive nature of the escaping.
Do you think it makes sense to add special escaping for *.env files here?
Basically what we need is the bash script below, which works well (up to a few edge cases). A bash script in the pipeline does not have access to all the variables though, afaik.
# Generate sed s-command to replace one literal with another one.
# The key is assumed to contain only characters [A-Z_]
function sub() {
  KEY="$1"
  VALUE=$(printf '%s' "$2" | sed -e 's/[\|&]/\\&/g')
  printf 's|#{%s}#|%s|g' "$KEY" "$VALUE"
}

# - Single quoted values need to have single quotes escaped.
# - Double quoted values need to have double quotes and backslashes escaped.
# - Double- und unquoted values need to have the dollar sign escaped.
VALUE_SQ=$(printf "%s" "$VALUE" | sed -e "s|'|\\\\'|g")
VALUE_DQ=$(printf "%s" "$VALUE" | sed -e 's|\\|\\\\|g' -e 's|"|\\"|g' -e 's|\$|$$|g')
VALUE_UQ=$(printf "%s" "$VALUE" | sed -e 's|\$|$$|g')
sed -i \
  -e '/^[^=]*='\''/ '"$(sub "$KEY" "$VALUE_SQ")" \
  -e '/^[^=]*="/ '"$(sub "$KEY" "$VALUE_DQ")" \
  -e "$(sub "$KEY" "$VALUE_UQ")" \
  "$FILE"

Hi @bodograumann,
The task is by default a simple find and replace without any context awareness to keep it simple as there would be too many contexts to support.
Are you using the task in Azure DevOps? If yes I don't see why your bash script will not have access to all variables as environment variables; the replacetokens task just uses the environment variables set by the agent.
I suppose it's not possible for you to "pre escape" the values in the variables?

Thanks for getting back to me. Yes, this is about Azure Devops :smile:
Indeed pre-escaping will not work due to context-sensitivity. We would have to make assumptions about where the value will land in the end. Also in the future it would be forgotten, when new values will be added.
Turns out there are several reasons why the bash script did not have access to the variables.
First of all I assumed all keys where uppercase with underscores – they are not :rofl: :facepalm:.
Then there are also secrets. Only now I learned, that normal variables are mapped automatically to the env in scripts, but secret variables need to be mapped manually.
So when explicitely mapping the secrets to the script, it actually works.
I'll close this issue, assuming that the use-case is too narrow. If somebody else comes along with the same requirements, feel free to comment here and we can consider it again. (Or maybe I'll just share my bash solution then :smirk: )


docs: appropriate README.md

Please see TRG1.01 and other TRGs in the list.
The readme is missing the following sections:

Description about what the repository contains and what the application does
How to configure the application
Reference to an INSTALL.md or description about how to install the application
Reference to the leading product repository and backend repository according to the TRG2.04
Notice for Docker image or reference to the notice based on TRG4.06. You can find a good example for the notice section here.

Checking.

Readme update as per TRGs.


Pagination unit tests

Current Situation

A bug that was recently fixed in #398 involved the pagination.py utilities, which currently don't appear to have tests.
Suggested Improvement

It would be great to add unit tests for this file!
Benefit

Additional context

Implementation

[ ] 🙋 I would be interested in implementing this feature.

hi @AetherUnbound can i work on this issue, i am comfortable in python and  Django  and i think I will be able to handle this, can you please assign this to me.

Thanks @prikshit-1103, feel free to take this up! Assigning to you.


Merge from vscode 0a7364f00514c46c9caceece15e1f82f82e3712f

https://www.github.com/Microsoft/vscode/commit/0a7364f00514c46c9caceece15e1f82f82e3712f Use object parameter for services
https://www.github.com/Microsoft/vscode/commit/feadf5183dfd15021b67694fb8d38b5c9cde428c Move code lens files into own directory
https://www.github.com/Microsoft/vscode/commit/5dfb77c313a7e4244b88ccbbff0995df1670048d Move task provider into own folder
https://www.github.com/Microsoft/vscode/commit/a4b011697892ab656e1071b42c8af4b192078f28 Rename features -> langaugeFeatures
https://www.github.com/Microsoft/vscode/commit/6649f4e2967e0f6e86c8831d1e8b9a7abb23a684 Clean up extension activation
https://www.github.com/Microsoft/vscode/commit/0bf4493b75fe9fecc1dea89c3595e6d1ed8db49b Don't send git resources to tsserver
https://www.github.com/Microsoft/vscode/commit/21cd7c6001e4531e233343c02233bb1c4cbe4ea4 Move some files into server
https://www.github.com/Microsoft/vscode/commit/ae7254a2e975313847a76ea25cb31c673ee67d7a Fixing some errors when loading workspace TS versions
https://www.github.com/Microsoft/vscode/commit/23c4467ed37d01f522394f631dcb89f5dcc7b762 Enable web TS Server  (https://www.github.com/microsoft/vscode/issues/102990)
https://www.github.com/Microsoft/vscode/commit/ec8606cb49ec839ccdf90c278f44c5bfa3567063 Make sure main process webview file resource loads stays on main process
https://www.github.com/Microsoft/vscode/commit/145a0072d321d9e77a94b2ff687bddef3a27a7dd Fix not resetting cell list focus context key when closing notebook
https://www.github.com/Microsoft/vscode/commit/282214a36432e924d106b27f5f5dc2fab91c6832 Clean up group listener
https://www.github.com/Microsoft/vscode/commit/8fbe6d6fd825153cd56d39df8cc5188a48fc9a1d :lipstick:
https://www.github.com/Microsoft/vscode/commit/9ffeec81b60b249075e23134668b56f2b1851e49 Add left/right folding keybindings for mac
https://www.github.com/Microsoft/vscode/commit/973f12a4bfb549e9fc1b1b33cc1faf49b9e6d9fd contribute configuraiton defaults through workbench web api
https://www.github.com/Microsoft/vscode/commit/6112310978efa3cb012561ff75df0f2bb8059720 use workbench base config
https://www.github.com/Microsoft/vscode/commit/786af3a8d0bc0221d979a9f22596fde825691729 Simplify auth sessions change event
https://www.github.com/Microsoft/vscode/commit/8dff81ed5518abed524c473a697a423653c7da18 Add extra rg logging for https://www.github.com/microsoft/vscode/issues/100373
https://www.github.com/Microsoft/vscode/commit/ca7f73b70c6211083e1ee66769cda6bedcb58f31 Resolve task process variable Fixes https://www.github.com/microsoft/vscode/issues/103018
https://www.github.com/Microsoft/vscode/commit/02e0d2309075e669defb8544c18ccf5b826511e5 VS Code refuses to save a files with extensions it doesn't like (fix https://www.github.com/microsoft/vscode/issues/102713)
https://www.github.com/Microsoft/vscode/commit/e2582caecdbc8571284c96959d9eb4ea4b5caa11 allow to provide only url
https://www.github.com/Microsoft/vscode/commit/288108c294994b15ad65bfb4aefbe72858bb610f fix compilation
https://www.github.com/Microsoft/vscode/commit/3fe5e609cee130ebc6497d50437022af3b662000 fix tests
https://www.github.com/Microsoft/vscode/commit/b8405ce0b8e54ca0c24ac3206d608463dfcfcfbf Fix https://www.github.com/microsoft/vscode/issues/103005
https://www.github.com/Microsoft/vscode/commit/eb1ca267d6a478734bd7f3d629ac9b80926ee9d1 comment out notebook web integration tests
https://www.github.com/Microsoft/vscode/commit/4f110a5ad381b57038725366c7d6ff9b3df98516 Fixes https://www.github.com/microsoft/vscode/issues/102198
https://www.github.com/Microsoft/vscode/commit/5c7e862955ca00cb7a1db259fb3b2b440d3f45fd Merge pull request https://www.github.com/microsoft/vscode/issues/102149 from Charles-Gagnon/patch-1
https://www.github.com/Microsoft/vscode/commit/9749ceef5e0a8ff3c2a97d946d6ee6a1d7d0faf3 Fixes https://www.github.com/microsoft/vscode/issues/102336
https://www.github.com/Microsoft/vscode/commit/1b05bbed6ed8064793d7cfb3d13110168b8ee351 Fixes https://www.github.com/microsoft/vscode/issues/102339
https://www.github.com/Microsoft/vscode/commit/5efad44b0d5e8f9b769482c975bc09b4551884b3 tests - skip failing notebook tests for now (https://www.github.com/microsoft/vscode/issues/103003)
https://www.github.com/Microsoft/vscode/commit/0e78d70a991b64bc93b6c5b77b587a74f446cc6e Merge pull request https://www.github.com/microsoft/vscode/issues/102101 from microsoft/aeschli/sortExtByPrimaryLanguage
https://www.github.com/Microsoft/vscode/commit/a5aa8f5456058d9ba13fe2d86ba80552ea24e63e Fixes https://www.github.com/microsoft/vscode/issues/102920
https://www.github.com/Microsoft/vscode/commit/3d0d50caf8d92662fa474251512001d5d96173fb chore: update to electron 9-x-y (https://www.github.com/microsoft/vscode/issues/102011)
https://www.github.com/Microsoft/vscode/commit/5451dbfb9e96d3f28259cb8b9a239a5cd2c745d8 https://www.github.com/microsoft/vscode/issues/102581 update icon and merge view into title
https://www.github.com/Microsoft/vscode/commit/6c79b090ee7988a567b07150139c01c0b2c62442 :lipstick: dangling comment
https://www.github.com/Microsoft/vscode/commit/7e40e8e4be7ef3075428573caead765011e684e9 auth dialog - enable context isolation (https://www.github.com/microsoft/vscode/issues/102926)
https://www.github.com/Microsoft/vscode/commit/798047ca0f69bcf07fc7a8f2ede678cc8d0eaf12 web - contribute a "Go Home" menu action if we have a home indicator
https://www.github.com/Microsoft/vscode/commit/a0068791721128a7f7aa314fd26561dc48413850 electron - explicitly disable spellchecker
https://www.github.com/Microsoft/vscode/commit/dc333833e935db0f793ee7f03fd8ddf4b8f119d3 eslint - fix linting issues
https://www.github.com/Microsoft/vscode/commit/3c4a261d5f666e40748ae6055c6a72614af73eba Add missing code-import-patterns for files and directories targeting web. (https://www.github.com/microsoft/vscode/issues/102961)
https://www.github.com/Microsoft/vscode/commit/f0646f81aa1c4ba5cdada749ca1a18bf60b14dc1 Update Codicons: add 'merge'
https://www.github.com/Microsoft/vscode/commit/57ad6558bf965f70f3bb3fb2008502e3d652d68a chore: bump<EMAIL_ADDRESS>https://www.github.com/Microsoft/vscode/commit/2501ecbe3f7b7f2701573c2b6e4079bbf9d2e6dc :lipstick:
https://www.github.com/Microsoft/vscode/commit/5ed3ec1dae4288cbc1ff836019149bffa81a68e4 save user selection of kernel provider to user settings.
https://www.github.com/Microsoft/vscode/commit/d586f701ec2b3a910ff2d41d31fd84e69316273d kernel provider settings.
https://www.github.com/Microsoft/vscode/commit/caa05dd6d5b8e31e61d4527bfdda962c03993765 Remove extra gating around selector
https://www.github.com/Microsoft/vscode/commit/d361a5318e501eb3a8112d0bd9018953ff0a5e81 Aadd link to upvote section of feature rewquest
https://www.github.com/Microsoft/vscode/commit/3841f78377fc02ab5ef514cbd0fa760ed4ac6f0d Fix normalization of toResource for untitled resources
https://www.github.com/Microsoft/vscode/commit/e41c19505142614f706ad853bd5c4c2ad0f74e89 Work towards allowing enhanced syntax server commands to be run against any file
https://www.github.com/Microsoft/vscode/commit/8bf2ae16a01aed4a35cec622b918cc5f7526af22 Export  RequestCancellerFactory implementations as constants
https://www.github.com/Microsoft/vscode/commit/538ff07c71e06cb6d6f03a2aabba46bb3f1992b1 Move logDirectoryProvide into server
https://www.github.com/Microsoft/vscode/commit/90fbd0eb60f197e3911f20124be3676f5e217b80 Extract cancellation.electron
https://www.github.com/Microsoft/vscode/commit/3b9db3df276c892fdd6f00df7b55f811a053ee25 Extract NodeLogDirectoryProvider to electron specific file
https://www.github.com/Microsoft/vscode/commit/00bd63c32c62895e5f252a1bf9031e5fa447ac93 Move lazyClientHost to own file
https://www.github.com/Microsoft/vscode/commit/c17905888cba86e65cf30c610464aaea0e122893 Extract onIsCaseInsenitiveFileSystem
https://www.github.com/Microsoft/vscode/commit/90363c2f9dc24e381f085a0f997cf1b6287fc219 Change cell execution/cancel API Fix https://www.github.com/microsoft/vscode/issues/99203
https://www.github.com/Microsoft/vscode/commit/357fe6956c8444ab04c0f042bd2c70077d42e849 Ensure account preference set after login flow completes
https://www.github.com/Microsoft/vscode/commit/cd5b4a7c807728a434ef322a3dd45f25ac54dcfe Emit activation event for auth providers when getSession is called
https://www.github.com/Microsoft/vscode/commit/c24e471cb49c5fbe7a40a36ff554c53823dc0be6 Add note about preferring .gif
https://www.github.com/Microsoft/vscode/commit/711ff532e9e1dbd35e8d5ab798874caf4df1750c update distro.
https://www.github.com/Microsoft/vscode/commit/b98f6685ee6fc2c00473499bd37188f3e9273e08 fix tests
https://www.github.com/Microsoft/vscode/commit/fc0dff3335f98ea5482aec1c6be83e4e0fbc150b fix arg number
https://www.github.com/Microsoft/vscode/commit/70f972a002cc5c8039afc0ee34b22d34de0da317 Merge pull request https://www.github.com/microsoft/vscode/issues/102968 from microsoft/misolori/editor-on-type-color
https://www.github.com/Microsoft/vscode/commit/a23bd4f6888345021fdcd18198a0a3dc4c1ef8ef retain dialog
https://www.github.com/Microsoft/vscode/commit/5948f495516b6417a83306518625a8b2041782bd fix https://www.github.com/microsoft/vscode/issues/102504.
https://www.github.com/Microsoft/vscode/commit/ff66cdb1b882acd08cf86e9b8640083dcb1f972a https://www.github.com/microsoft/vscode/issues/91696 start-up log
https://www.github.com/Microsoft/vscode/commit/a79a6e6492ccdcd74c2bb28ad8dac0b38b76d101 Merge pull request https://www.github.com/microsoft/vscode/issues/102845 from rebornix/rebornix/shared-notebook-models
https://www.github.com/Microsoft/vscode/commit/72c8d5d300cc3cb3c8d81001c339c32a125818cd Fix https://www.github.com/microsoft/vscode/issues/91696
https://www.github.com/Microsoft/vscode/commit/d1b0192b4f38547cc14be2b9c299c3f6e139ef2d chore: bump distro
https://www.github.com/Microsoft/vscode/commit/b115b7d35a28dd39f7890bb7b15761fc4f413439 Fix typo Fix https://www.github.com/microsoft/vscode/issues/102964
https://www.github.com/Microsoft/vscode/commit/b1295cc85b58ddb7f3be371f95ed98c8b0a2d8ad Fix https://www.github.com/microsoft/vscode/issues/102391
https://www.github.com/Microsoft/vscode/commit/7725bf1bcc0fcc3c96286ab1dcf2c66491eaefdc Move authServer to fix relative paths issue
https://www.github.com/Microsoft/vscode/commit/e1dce24837163212b13e4b627ea23cc027ae771d Update wording
https://www.github.com/Microsoft/vscode/commit/1a40ba0c9dfb54dc667df7b2de8d4e40c3027ddd Add screencast mode line
https://www.github.com/Microsoft/vscode/commit/993df7802db80df59e96595cd8ad2a52c3e6585e align auto sync conflicts with manual sync conflicts
https://www.github.com/Microsoft/vscode/commit/2f7e5d9841948f4a10a863bff8756396af454814 stdin - log raw output from running chcp command for diag
https://www.github.com/Microsoft/vscode/commit/bfcdb61517e19fd164421aed873296a1ca9308ce handle conflicts while turning on sync
https://www.github.com/Microsoft/vscode/commit/2d7ae4a7d902b42ecfd41bafba9ff79ff085f690 Change where task execution context is set
https://www.github.com/Microsoft/vscode/commit/4d21831e50b00a2aa0cdae4d069ed43edb95c600 Fix https://www.github.com/microsoft/vscode/issues/99764
https://www.github.com/Microsoft/vscode/commit/196a30d1797351128d4188859f86d6d935e07f3e https://www.github.com/microsoft/vscode/issues/100346 merge unmerged resources while applying
https://www.github.com/Microsoft/vscode/commit/90138703196084baed33432d144fd49ae0fe17ed sandbox - fix product name in process explorer
https://www.github.com/Microsoft/vscode/commit/c785a4aca5852c19e34b8e627b915532b1773384 Report Issue => Report Issue...
https://www.github.com/Microsoft/vscode/commit/4aab95966b36a24675c7d3b906bd5a577ed41c88 unit tests - run them in same environment as our main code
https://www.github.com/Microsoft/vscode/commit/2bbcd0611454e22b6aa91e5caa6824cb6126bbca debt - move supported encodings closer to where they belong
https://www.github.com/Microsoft/vscode/commit/e5b3ff76bae1fc69df3b94da1d4ac4fe9dda8283 Enable sandbox and contextIsolation for process explorer when running with --__sandbox (https://www.github.com/microsoft/vscode/issues/102924)
https://www.github.com/Microsoft/vscode/commit/040b60f4d1f1ae90b77eb0d328ab140d4070d97b https://www.github.com/microsoft/vscode/issues/102581 rename reset to clear with ...
https://www.github.com/Microsoft/vscode/commit/4ecf61e7090b8ab9799ba2cd3835932d5852b4f5 https://www.github.com/microsoft/vscode/issues/102001 :lipstick:
https://www.github.com/Microsoft/vscode/commit/d5e58666e5e703009db9269bf127572359592518 https://www.github.com/microsoft/vscode/issues/102581 feedback
https://www.github.com/Microsoft/vscode/commit/336ad64f24f52233ab8ce4e4e68212c67206509d https://www.github.com/microsoft/vscode/issues/102581 select the resource while reopening
https://www.github.com/Microsoft/vscode/commit/6c21258b65e4c9448323c930fabb1ac6b734c597 https://www.github.com/microsoft/vscode/issues/102581 show warning notification on conflicts
https://www.github.com/Microsoft/vscode/commit/c657585feaa52beab4e5d6d920f6558e6a7fc8a3 https://www.github.com/microsoft/vscode/issues/102581 add buttons to sync editors
https://www.github.com/Microsoft/vscode/commit/881e7e546b4546cd4675049f7077c0f0b43db8d7 https://www.github.com/microsoft/vscode/issues/102581 improve first time sync dialog
https://www.github.com/Microsoft/vscode/commit/2c609ec4aac2f5fab83ca3867e1417cb22a4e315 Update commands.json
https://www.github.com/Microsoft/vscode/commit/0e03f9a88e10fc29f103f90d6b8fad0c3ae0c450 Add \gifPlease
https://www.github.com/Microsoft/vscode/commit/a8ee28deb930e3c7a630f48cedb297da5832eb18 Copy providers array before freezing in extHostAuthentication
https://www.github.com/Microsoft/vscode/commit/e2432d9e6301ebc502f2151bc00445f5817f1aec re-pick best kernel if the active kernel is not available.
https://www.github.com/Microsoft/vscode/commit/61807f3f41869d39f8bd066dcf26011a7edb6795 set kernel should not block file opening
https://www.github.com/Microsoft/vscode/commit/9ba813a5e9b2f4a85cccb0e1d278ce302d30c2ac optional kernel id
https://www.github.com/Microsoft/vscode/commit/a8b8907846902da951b9964a3c74fb5db484a7c7 Move process explorer into electron-sandbox layer, fixes https://www.github.com/microsoft/vscode/issues/101832
https://www.github.com/Microsoft/vscode/commit/d34560206f1cd95282b62d4bd76873d255619eeb support joining cells of all cell types.
https://www.github.com/Microsoft/vscode/commit/49305f21a4a613d2d6dfbe5ff2c3fe84af1568ef active kernel info on notebook editor.
https://www.github.com/Microsoft/vscode/commit/f475511726d8dcde0d8d7f38f7770b8e6fc82f4d kernel change event.
https://www.github.com/Microsoft/vscode/commit/f33c9c1430e5562b56e6a99bd2d620b626a43aff Fix cells shifting and overlaying each other as I scroll through a notebook with outputs
https://www.github.com/Microsoft/vscode/commit/893b6e8912f7379beddd1a4686d132ceca756c08 clean up dependencies
https://www.github.com/Microsoft/vscode/commit/94d07595b1a3f1891af58674e6e97e680a7841c7 Add MetaModules to workspace tags
https://www.github.com/Microsoft/vscode/commit/1ac2178ed069eb88e5ff646d1e013f640e859719 Show input box for PAT in test environments instead of doing auth flow
https://www.github.com/Microsoft/vscode/commit/d504784073984011e3c2aa65888b4690590701d5 Merge pull request https://www.github.com/microsoft/vscode/issues/102773 from microsoft/dependabot/npm_and_yarn/lodash-4.17.19
https://www.github.com/Microsoft/vscode/commit/10033ed530e873de415682a24553b350e93d66c5 Merge pull request https://www.github.com/microsoft/vscode/issues/102770 from microsoft/dependabot/npm_and_yarn/extensions/html-language-features/server/lodash-4.17.19
https://www.github.com/Microsoft/vscode/commit/4e648e27dd09c6bee1d167e657c6f63bafe2d63d Merge pull request https://www.github.com/microsoft/vscode/issues/102771 from microsoft/dependabot/npm_and_yarn/extensions/css-language-features/server/lodash-4.17.19
https://www.github.com/Microsoft/vscode/commit/17ede057c3abbf50c6e7ad6798f35837db28f012 Merge pull request https://www.github.com/microsoft/vscode/issues/102775 from microsoft/dependabot/npm_and_yarn/test/smoke/lodash-4.17.19
https://www.github.com/Microsoft/vscode/commit/7f9df80a54956eaf8ab589f4ac441a734be5bb51 Merge pull request https://www.github.com/microsoft/vscode/issues/102772 from microsoft/dependabot/npm_and_yarn/extensions/markdown-language-features/lodash-4.17.19
https://www.github.com/Microsoft/vscode/commit/4639fef39a8edd2b566ecff27a677918bdfdc5d6 Merge pull request https://www.github.com/microsoft/vscode/issues/102774 from microsoft/dependabot/npm_and_yarn/build/lodash-4.17.19
https://www.github.com/Microsoft/vscode/commit/ec3a3fafaaa6b6bb684cc15b8b2cf7faf801da10 Merge pull request https://www.github.com/microsoft/vscode/issues/102776 from microsoft/dependabot/npm_and_yarn/extensions/emmet/lodash-4.17.19
https://www.github.com/Microsoft/vscode/commit/ff6b1c5984a4c2116a06318f07e871a4169fdb1b fix https://www.github.com/microsoft/vscode/issues/102768
https://www.github.com/Microsoft/vscode/commit/e399a3f4d3725c3605125087e22f7376b6fee496 Fix https://www.github.com/microsoft/vscode/issues/100323
https://www.github.com/Microsoft/vscode/commit/c102db4cc82f5abff762ef46546fc72154933bab :lipstick:
https://www.github.com/Microsoft/vscode/commit/227eb50bf3249ee352da09706e6453cc0884b9eb update doc
https://www.github.com/Microsoft/vscode/commit/0b9cffd98ab4c07eb19134993894f1881fa07c63 oops
https://www.github.com/Microsoft/vscode/commit/27e06f526fdb1c419670e7545171af3b7752de30 update octokit in github
https://www.github.com/Microsoft/vscode/commit/a6aa3902d4134a9b2cd89c4e7e7bf8963d50afe1 https://www.github.com/microsoft/vscode/issues/100346 :lipstick:
https://www.github.com/Microsoft/vscode/commit/a24b3629809ad4b91b42b8f67bb1941be6adead7 :lipstick:
https://www.github.com/Microsoft/vscode/commit/c4dae68b49a463c0cbae51868a1647ddc31e76c5 eslint fixes @rebornix
https://www.github.com/Microsoft/vscode/commit/ba9d63bf8993e8ed96ccbd5e189208907cf90e19 partially revert https://www.github.com/microsoft/vscode/issues/102627 (data loss with hot exit)
https://www.github.com/Microsoft/vscode/commit/97940b39dbabecabdceb38b2dccca2b14a72e84c defaultUserWebExtensions setting
https://www.github.com/Microsoft/vscode/commit/bb7910d4810d3102f0f37b7f0182a135b0b1eb48 fix https://www.github.com/microsoft/vscode/issues/102627
https://www.github.com/Microsoft/vscode/commit/0acc996121cfa26813a65817fedf2fd2cca7483d Add support for view initial state (collapsed or hidden) (https://www.github.com/microsoft/vscode/issues/102002)
https://www.github.com/Microsoft/vscode/commit/27e8b9d1a3c130c90451f8c49aef88b72e936563 perf - move perf marking into code that is also used by CS
https://www.github.com/Microsoft/vscode/commit/5abb87f9616dfdd5920c122a3adb3d43e8a09256 Merge pull request https://www.github.com/microsoft/vscode/issues/102735 from rebornix/rebornix/multi-kernel
https://www.github.com/Microsoft/vscode/commit/7099dc0708b3e6c6333641ef162262908ce37a0f Add extra check to markdown state
https://www.github.com/Microsoft/vscode/commit/cc664dbb675114652472dc5fbcdf9c5592cc8a0c remove log
https://www.github.com/Microsoft/vscode/commit/00a0a77785cc5654cfeb25368a6c63254e373a90 Cleaning up ts server logic
https://www.github.com/Microsoft/vscode/commit/a155fcf762d08ed16b48c82f98d45a6b7af46dba Address feedback on auth provider API
https://www.github.com/Microsoft/vscode/commit/0d1933a322770fc2bbe7815b5c888a5f290cc9fb Add webworker support for microsoft authentication extension
https://www.github.com/Microsoft/vscode/commit/34f9cb2bcca43415b37803555c1d18f9ed3a0b29 Style notebook output tables
https://www.github.com/Microsoft/vscode/commit/ed028cfd9669bd904255bd30556d12971461bbdf Add ClientCapabilities class
https://www.github.com/Microsoft/vscode/commit/4d5a18af6475c4664ce7e06e16f7937a90aa9f11 Update ts version used to build VS Code
https://www.github.com/Microsoft/vscode/commit/0857489caf7378f1063376a02344a87772092e43 Add the concept of client capabilities for TypeScript
https://www.github.com/Microsoft/vscode/commit/16c6b81b3e54ce8cab06fbd9649cce211f672944 Flatten conditional registration
https://www.github.com/Microsoft/vscode/commit/740e2d3602162faf1d968b1c73a6a03286bfb566 update distro
https://www.github.com/Microsoft/vscode/commit/e59421712636f55adf40be0d667025b0dd34cf11 https://www.github.com/microsoft/vscode/issues/100346 disable buttons while turning on sync
https://www.github.com/Microsoft/vscode/commit/9a12a5abedabd94c989a45dc5aad52c99b21a905 fix paragraphs inside of
's which are too spaced apart. (https://www.github.com/microsoft/vscode/issues/102719)
https://www.github.com/Microsoft/vscode/commit/c6007a872b6ec13a973b513a16c3f2a18959ab4f https://www.github.com/microsoft/vscode/issues/100346 handle conflicts notifications and editors
https://www.github.com/Microsoft/vscode/commit/65a4098aa97ee8dd4c33d6d81e2bd3fac1e19ed6 https://www.github.com/microsoft/vscode/issues/100346 fix label
https://www.github.com/Microsoft/vscode/commit/de39b1df90cdadab35fe6f2ee63b7aa0d87e3a90 https://www.github.com/microsoft/vscode/issues/100346 use strikethrough for deleted previews
https://www.github.com/Microsoft/vscode/commit/1710c92d5f9c2b6ad641328f6b4d90f817ab02ac fix https://www.github.com/microsoft/vscode/issues/102460
https://www.github.com/Microsoft/vscode/commit/3db442b1cf414156d723fe92bdfc3819aeb19686 use cloud up/down icons
https://www.github.com/Microsoft/vscode/commit/5b9309f351351febdf62c7fab0a9ddd3d14feceb https://www.github.com/microsoft/vscode/issues/100346 use cloud icon
https://www.github.com/Microsoft/vscode/commit/e14c07484365cdb405dbdd31e3cd4574c490d568 https://www.github.com/microsoft/vscode/issues/100346 use read only local files
https://www.github.com/Microsoft/vscode/commit/fdf70cbc7b7a2402ebbd030aa7f180152ae52661 https://www.github.com/microsoft/vscode/issues/100346 fix opening diffs and accept preview
https://www.github.com/Microsoft/vscode/commit/28f3fa9e9bd0545535b0c61ad14190ea974f7b1e https://www.github.com/microsoft/vscode/issues/100346 set data provider while rendering
https://www.github.com/Microsoft/vscode/commit/270a1939647105c5bfd14103cf81015f1acba611 Update Codicons: add 'cloud'
https://www.github.com/Microsoft/vscode/commit/b031ea7879ef3aa1b7100faf87b1538d9637b7af Built-in XSLT extension has 'brackets' setting that prevents bracket-matching for embedded XPath 1.0-3.1 Fixes https://www.github.com/microsoft/vscode/issues/102584
https://www.github.com/Microsoft/vscode/commit/5e5fa3edde19d38ac512d65ccefe2a12ecab025a Tasks without a registered definition should run (https://www.github.com/microsoft/vscode/issues/102696)
https://www.github.com/Microsoft/vscode/commit/a786284f7d3eb1f118f99bae16c8e9238251334e https://www.github.com/microsoft/vscode/issues/100346 change the order of dialog options
https://www.github.com/Microsoft/vscode/commit/1f3a4f124f7bc44df6318f0aa686b9ba0f5fd21b https://www.github.com/microsoft/vscode/issues/100346 UI changes - introduce sync and cancel buttons - ability to discard - update entries on state change with decorations
https://www.github.com/Microsoft/vscode/commit/df336bbe62664200c11e21b4f745f5ef80539689 https://www.github.com/microsoft/vscode/issues/100346 support discard
https://www.github.com/Microsoft/vscode/commit/9e457a6ca31eadec75990e8195f30040935d3032 https://www.github.com/microsoft/vscode/issues/100346 introduce merge state on a resource. Do not apply automatically.
https://www.github.com/Microsoft/vscode/commit/80a33109464ccc831471ae0f31396047d8418d0f add eol to IMainCellDto, no more attach/dettach text document but use the actual (sync'd) document or a fallback cell document
https://www.github.com/Microsoft/vscode/commit/f3fed74a9204552d1278e46cca3a5619c44b40b7 fixes https://www.github.com/microsoft/vscode/issues/98931
https://www.github.com/Microsoft/vscode/commit/ef54e402e2f75837b53751d5a37a251e78226c60 fixes https://www.github.com/microsoft/vscode/issues/102108
https://www.github.com/Microsoft/vscode/commit/d92bbed0cb41795d5cb7e160e791772bd1044e42 always show SCM twisties
https://www.github.com/Microsoft/vscode/commit/7419d68a7cfc5a77d45d36c7fa3a747aacb554f4 fixes https://www.github.com/microsoft/vscode/issues/102682
https://www.github.com/Microsoft/vscode/commit/6a9f98bc864bd879cbc6d556983ab05781942c16 debt - migrate rename api command
https://www.github.com/Microsoft/vscode/commit/62f58fc830b200be237e19473f4b582571cbc84d Markdown hover to tree doesn't require resolve Part of https://www.github.com/microsoft/vscode/issues/100741
https://www.github.com/Microsoft/vscode/commit/9074d576bb403524ff805c715a023a4b3299f4f5 Add GitHub public repo option (https://www.github.com/microsoft/vscode/issues/102406)
https://www.github.com/Microsoft/vscode/commit/90efeb4f2dc41827b382c8bb5da1c3abfff9459f better name for actual uri, https://github.com/microsoft/vscode/issues/101978
https://www.github.com/Microsoft/vscode/commit/717272507d5ccb84e89374125b0511a6a8008f9c fix extension editing main
https://www.github.com/Microsoft/vscode/commit/efa08a0c67702a5a0bb85eb64632344918f9f79c add uri to concat doc proposal
https://www.github.com/Microsoft/vscode/commit/69fd7afc56b4c4f793981d6b0cfbeb06cc1ae613 throttle save participants in certain cases (https://www.github.com/microsoft/vscode/issues/102542)
https://www.github.com/Microsoft/vscode/commit/a05390d95251a4d073620ec48ac1a470d939346b Disable failing tasks test to get build
https://www.github.com/Microsoft/vscode/commit/d9e3ecba9e11d0e7dbc622211e5f5d90dde97cfe fixes https://www.github.com/microsoft/vscode/issues/102578
https://www.github.com/Microsoft/vscode/commit/8e00e24e2bb18907fd2fa36f136b771bc60b38fa activityService.showViewActivity
https://www.github.com/Microsoft/vscode/commit/ad720d6a631c7ed8afada70073cec68e8e18194a Update log grammar
https://www.github.com/Microsoft/vscode/commit/d11d7bf1ef2fe4cf808a07caf38c7957ef02e45f web - tweak wording of quality change dialog
https://www.github.com/Microsoft/vscode/commit/c46ac429e29b10dd8250a02ea0da5b9cac54f0ac fix build
https://www.github.com/Microsoft/vscode/commit/8d8cb8b88348a0e4473422b72540bfe781dec67c Maybe fix listener leak warnings from notebooks
https://www.github.com/Microsoft/vscode/commit/39af33aabebd71aa9a138d5fd22145fa3893fc46 Allow commands in empty cells Fix https://www.github.com/microsoft/vscode/issues/102156
https://www.github.com/Microsoft/vscode/commit/8ab815db54f1114c13524129a699f1d9cdea592e only prompt on imp ext recommendation pattern
https://www.github.com/Microsoft/vscode/commit/c24de77fe85ba69d056e8bca7968661e8226bf8a debug: bump js-debug version
https://www.github.com/Microsoft/vscode/commit/48f23d838fc68c16eab0752e4754a6a3124e0a85 Merge pull request https://www.github.com/microsoft/vscode/issues/102471 from troy351/patch-1

Coverage remained the same at 39.966% when pulling ca39cbe6ab9463fb21b8cbb6ef7eb8b8f25d314e on ads-main-vscode-2020-07-22T03-06-51 into 53ec7585a9da594c2465bfffa01238d1efc190a7 on main.


Feature - Use enum to pick index method

It would be nice to have an overload of
.ForNpgsqlHasMethod("gin");

that accepts an enum value. Primarily for intellisensability. (I would do this, if approved)

Something like this
    public static class EFCoreExtensions
    {
        public static IndexBuilder ForNpgSqlHasMethod(this IndexBuilder indexBuilder, NpgIndexMethod method)
        {
            return indexBuilder.ForNpgsqlHasMethod(method.Value);
        }
    }

    public class NpgIndexMethod
    {
        private NpgIndexMethod(string value)
        {
            Value = value;
        }

        public string Value { get; set; }

        public static NpgIndexMethod Btree => new NpgIndexMethod("btree");
        public static NpgIndexMethod Gist => new NpgIndexMethod("gist");
        public static NpgIndexMethod Hash => new NpgIndexMethod("hash");
    }

** Names subject to change.

There are already various other places where PostgreSQL lists of values are specified as strings - notably types (e.g. when users specify HasStoreType()). We can start wrapping all of these with enums and similar, but the value seems rather limited and we'd have to update these as PostgreSQL adds new ones...
In general it seems preferable for users to consult the PostgreSQL documentation to know these values - at the very least we should point them towards the right page from the xmldocs.

See https://stackoverflow.com/questions/56207300/does-npgsql-expose-a-strongly-typed-list-of-postgresql-column-types/56207864#56207864 for a similar request for PostgreSQL types.

First of all, I have to start by saying I appreciate the work you've done so far. This provider is better than most out there.
I did consider all that, this is not meant to be a replacement but an overload. Similar to how model builders accept both a property expression and string property name as a selector.
I also didn't intend for it as a discovery mechanism for index types. I meant it for type safety. The cost of a misspelled enum is a squiggly line and build failure, the cost of a misspelled string literal is a run-time error when the model lazy loads on the first GET request after the build, startup and service activation time. Requiring a minimum of another refactor-build-execute cycle to correct a silly spelling error.
I do understand the cost vs benefit is low. It's a cherry on top, not the cake. There's already so many features missing in EF Core and it's providers, I'm sure nobody would notice a delayed enum update if there has to be any. In the answer to the SO question, you've said that they are well established names that never change, so there will hardly be any updates leading to refactor. Maybe it's not that much effort after all? It certainly takes less time to code a solution for this than to have this debate.
There's no rule saying that you have to turn each and every string accepting method into an enumeration. A list of 6 index types that are unlikely to change sounds like the ideal candidate. In addition to providing a link to the documentation, the xmldocs can say that "this list is not exhaustive, use the string overload for unlisted types." as a way for you to limit your liability. With the postgres extension system it is technically impossible to build an exhaustive list of types and indexes anyway.
There is no need for 100% parity, it's not like 100% of pg features are exposed in this provider already. Even with the gazillion column types, I don't see the harm in having an enumeration, although, it would be hell of a lot easier if C# supported string enums. If you have a table in the docs indicating the type mapping, why can't you have an enum and have the enum generate the table in the docs? Saying that it's okay to use strings is not an argument against static types, it simply means that it's okay to use strings, which is fine as not being brought into question. Static types are consistent, compatible with intellisense and provide build time errors as opposed to run-time errors. None of these are done by strings.
TLDR: Wrap index types as they are only few and require no maintenance
I have far more important questions for you,

Is the check constraint implemented?
Are partial indexes implemented?
Is OnUpdate on foreign keys implemented?
If I use .ForNpgsqlUseSequenceHiLo(), How would I specify a sequence start value?
If I use .UseNpgsqlIdentityColumn() How would I specify identity start, current, increment and min max values?
For both of the above and sequences, if I use HasData() to insert seed data with specific ids. Does it lead to a key collision on the next db/client generated insert because nextval('sequence') returns the same id as the inserted ones?
How do you ensure that the raw SQL you have to write to make the above work gets applied to a test database created using EnsureCreated() ? Do you Migrate() your test databases?
.ForNpgsqlUseXminAsConcurrencyToken() can this be specified globally on all entities?
If I use the above, who pulls the Xmin value, Npgsql or the provider ? If the provider pulls it, is it present in the shadow state?
If any of the above works, can we specify them in the docs
What is holding this project back from being feature complete? Is it the upstream project? is it lack of time/contributors?

I'm reading through your source now, I don't see why you can't add a PropertyAnnotation called "Check" that accepts a  predicate as a lambda expression. And in the sql generator create an ALTER TABLE ADD CONSTRAINT .... CHECK .....
You could also add an IndexAnnotation called Partial, PartialCondition, Condition, or IndexCondition and in your SQLGenerator just above line 602 append a WHERE clause.
You could be thinking that migrations allow for all this with arbitrary sql execution but migrations are a state transition. Migrations are tied to a specific db. They update the db from one state to the next. They are not a definition. There should be a stateless single source of truth to the database model in order for the code to be readable, portable and maintainable and this has to come in the form of feature completeness from the provider.

Saying that it's okay to use strings is not an argument against static  types, it simply means that it's okay to use strings, which is fine and is not being brought into question. Static types are consistent, compatible with intellisense and provide build time errors as opposed to run-time errors. None of these are done by strings.

Those ar fair points, but I think this conversation turns on the cost/benefit you mentioned above. There's a lot of work to be done, and every feature incurs costs time to develop and adds to the long term maintenance burden.
PRs from new contributors help with the first part, but there's still the question of whether it adds enough value to make sense as part of this project (as compared to being an extension method in your specific project).

I have far more important questions for you,

I can answer a few of these off-hand, but to keep this thread on topic, please open new issues for further discussion on them

Is the check constraint implemented?

Blocked upstream, tracking via #837.

Are partial indexes implemented?

#116

Is OnUpdate on foreign keys implemented?

This should already be implemented by the upstream project, no?

For both of the above and sequences, if I use HasData() to insert seed data with specific ids. Does it lead to a key collision on the next db/client generated insert because nextval('sequence') returns the same id as the inserted ones?

We recommend seeding data with negative key values. Otherwise you should add the requisite raw SQL to bring your sequence up to date. See #536, #573, #759.

How do you ensure that the raw SQL you have to write to make the above work gets applied to a test database created using EnsureCreated() ? Do you Migrate() your test databases?

EnsureCreated() doesn't play well with the migration flow. But if you just need to create/drop simple test stores, then they Ensure{Created,Deleted} tend to work well.

If any of the above works, can we specify them in the docs

Our docs are a always a work in progress that could certainly use more attention. PRs are always welcome :)

What is holding this project back from being feature complete? Is it the upstream project? is it lack of time/contributors?

Feature completeness is always going to be a high bar when considering a backend as feature-rich as PostgreSQL. More contributors would certainly help, and new contributors are always welcome!

@austindrenski thanks for the good responses above, here's some more from me.

First of all, I have to start by saying I appreciate the work you've done so far. This provider is better than most out there.

Thanks for saying that! That's also good to hear.
On the issue of index method enums, it's worth saying I'm not totally against the idea. However:

I do think a good API has to be consistent, and it's not ideal to have an enum for index methods but not for other settings - which is why I approach this question from a more global standpoint. Adding just an index method enum would leave users somewhat confused IMO.
The actually value seems rather low. Yes, it's always better to catch typos in compile-time rather than run-time, but since index methods are part of migrations a typo would be discovered very quickly (and in a risk-free way, as migrations run in transactions). It isn't some obscure runtime branch that would fail at some random late point.
Index methods are a very rarely-used and advanced feature, so once again people can be expected to discover the methods themselves and ensure they have no typo.

On the specific questions, to supplement @austindrenski's responses:

Is the check constraint implemented?

Blocked upstream, tracking via #837.

This has actually been unblocked at the EF Core side, I'm not actually sure we need to do anything to make it work in Npgsql (but obviously testing is needed).

If I use .ForNpgsqlUseSequenceHiLo(), How would I specify a sequence start value?

The HiLo feature seems to be very rarely used (not just with PostgreSQL, but in general in EF Core), and this is the first time anyone has raised the lack of support for specifying the starting value. See my comment at the bottom about eagerly implementing features without a clear need, but if you'd like you can open an issue for this.

If I use .UseNpgsqlIdentityColumn() How would I specify identity start, current, increment and min max values?

This is tracked by #819 and will hopefully make it into 3.0.0.

How do you ensure that the raw SQL you have to write to make the above work gets applied to a test database created using EnsureCreated() ? Do you Migrate() your test databases?

I'm not sure I understand the question - is this a general EF Core question on how EnsureCreated() interacts with migrations? It doesn't seem to be specific to the Npgsql provider.

If any of the above works, can we specify them in the docs

Our docs are a always a work in progress that could certainly use more attention. PRs are always welcome :)

Very much agree - our docs could definitely use some work. It's not always easy to keep them in sync with actual features, and it's possibly a good place for contributors to start as they're exploring/discovering the provider.

What is holding this project back from being feature complete? Is it the upstream project? is it lack of time/contributors?

Feature completeness is always going to be a high bar when considering a backend as feature-rich as PostgreSQL.

Agree as well - the range of features is potentially extremely large, and you can see the same issue in Microsoft-developed providers as well (e.g. SQL Server / Sqlite). In some cases we are also limited by upstream EF Core, but in general this is an open source project maintained by the community.
As a general rule, I personally try to avoid rushing into feature implementation without users asking for them, or without a plausible reason to believe it would be useful. In this project it's very easy to fall into the trap of eagerly implementing tons of features and translations with the goal of being feature-complete (and because it's fun/interesting), but which almost nobody will use, and which we then have to maintain. So while it may sound odd, I'd say feature-completeness isn't exactly an explicit goal.
If you see anything you're interested in it would definitely be great to have you (and anyone else) as a contributor!


Can the preview be protected on private repository so that only people with access can see the preview?

In one of my organization, we have internal documents built in a private repository.
I would like to use this GitHub action to allow previews on PRs.
However, these previews should only be accessible for people who can access this private repository.
Does this GitHub Action handle this?
Thanks

With GitHub Enterprise Cloud you can deploy a private GitHub Pages site from a private repo: https://docs.github.com/en/enterprise-cloud@latest/pages/getting-started-with-github-pages/changing-the-visibility-of-your-github-pages-site. In this case, this Action just makes a new directory in that existing site, so it will be just as private or public as the main site.
On a standard GitHub subscription, I don't believe there's any way to change the visibility of a GitHub Pages site to anything other than public. In this case, I'd imagine that your internal documents are served by something other than GitHub Pages. You might still be able to get this Action to work for you.
If you have more details about your situation I might be able to help further, please feel free to respond. I'm going to mark this issue as close as it doesn't reflect an issue with the Action.


narrower concepts apear with their alt labels

After selecting one concept in the tree - in the view on the right side some of the narrower concepts apear with their alt labels instead of th pref label. The coice semms to be random

@AngusLeBoeuf can you check this please


Do you have any plan to upload config for ONCE dataset?

First of all, Thank you for your awesome works.
It seems that config file for ONCE dataset is missing.
Do you have any plan to share config file for ONCE dataset?
Thanks.

Thanks for your interest in our work! We are still working on the performance tuning of the ONCE dataset. The config files in this dataset will be released in the near future, please stay tuned!


Add explicit deferred flags

Fixes #61257 and possible other issues introduced from #51591.
Please check to see if there's anything I missed.

Thanks!


fix(module:table): fix the missing of init table sort class

close #771
PR Checklist
Please check if your PR fulfills the following requirements:

[x] The commit message follows our guidelines: https://github.com/NG-ZORRO/ng-zorro-antd/blob/master/CONTRIBUTING.md#commit
[ ] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been added / updated (for bug fixes / features)

PR Type
What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
[ ] Yes
[x] No

Other information

Coverage increased (+0.02%) to 40.804% when pulling 80df4896231af7c87c89457ee56cf74e5f699da4 on vthinkxie:fix-table-sort into 12059ef1097a61936430a08f2404a9d51175123b on NG-ZORRO:master.

Coverage increased (+0.03%) to 40.819% when pulling 53619cff5e9e3ebb3fc5c4b26d94c26c3a8db461 on vthinkxie:fix-table-sort into 12059ef1097a61936430a08f2404a9d51175123b on NG-ZORRO:master.


[tag-sync] local repo of tags

https://github.com/feederbox826/plugins/issues/14#issuecomment-2469638600
Look into creating more robust synced tags, maybe add img and vid tags to indicate each

Didn't realize it at first but also related to https://github.com/stashapp/stash/issues/4995


gui3-3.7.0 and 3.6.0 broken, missing sceneFromFirstRenderEngine

Environment

OS Version:
Source or binary build?
Source, gui3-3.7.0 (or 3.6.0, both are broken) with rendering3-3.4.0

Description
This is a compilation bug. Compiling gui3-3.7.0, with rendering3-3.4.0 yields :
25301 /tmp/mboisson/avx2/ignition/citadel/GCC-9.3.0/ign-gui-ignition-gui3_3.7.0/src/plugins/screenshot/Screenshot.cc:185:27: error: sceneFromFirstRenderEngine is not a member of ignition::rendering
25302   185 |   auto scene = rendering::sceneFromFirstRenderEngine();
25303       |                           ^~~~~~~~~~~~~~~~~~~~~~~~~~

Ok, looks like I need rendering3-3.5.0, rather than `3.4.0.

See https://github.com/ignitionrobotics/ign-gui/pull/264 for bumping the required version in the code and https://github.com/ignition-release/ign-gui3-release/pull/5 for the debian packages. Ideally the installation / compilation should end early when a new dependency version is needed, instead of resulting in failures in the middle of the compilation.


Bug: inaccurate low disk space warning during inode exhaustion, newly autodiscovered hosts not collected

After noticing that newly added hosts weren't reflected in the stats, we saw Prometheus was nearly pegging two CPUs (normal is 10-60%) and throwing many error messages in the logs around low disk space and writes failing. Around 875MB was still free according to df.
Handling of low disk space conditions should be better (why were newly autodiscovered hosts not being reported?) and there seems to be a bug in the TSDB writer. Unfortunately we don't have full forensics, but if it recurs we'll snapshot the host.

It would also be useful if you could provide the logs also.
Also, check the number of inodes that are free. Sometimes large
installations run out of inodes.
On Tue 20 Jun, 2017, 7:03 PM e271828-<EMAIL_ADDRESS>wrote:

After noticing that newly added hosts weren't reflected in the stats, we
saw Prometheus was nearly pegging two CPUs and throwing many error messages
in the logs around low disk space and writes failing. Around 875MB was
still free according to df.
Handling of low disk space conditions should be better (why were newly
autodiscovered hosts not being reported?) and there seems to be a bug in
the TSDB writer. Unfortunately we don't have full forensics, but if it
recurs we'll snapshot the host.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/prometheus/prometheus/issues/2864, or mute the thread
https://github.com/notifications/unsubscribe-auth/AHA3H9O-a-0Bm_e7ZSv3sLeznTR-2HSFks5sF8oagaJpZM4N_lwJ
.

@Gouthamve inode exhaustion is possible. We'll check for that if it happens again. I see a 12 hour old prometheus install monitoring 2,000 hosts is using 194,455 files. That seems excessive.

We've recreated the scenario and confirmed it was inode exhaustion. At minimum the log messages should reflect that.

The error thrown in the case of inode exhaustion by the OS is the same as that of disk full.
This is caused due to the structure of the storage. We create a file per timeseries (we will have as many files as the number of ts) and then append new data to that file. We cannot drop old data and add new data as both belong to the same file and we ran out of inodes.
You could fix this by formatting the disk to have more inodes. This issue has been fixed in 2.0.

Sounds like there's not much more we can do here.


🌱  Update Binary-Artifacts and License checks

What kind of change does this PR introduce?
Updates tests to follow best practices (and corrects previous PR #4078 )
What is the current behavior?
binary_analysis and license check tests currently use localDirRepo instead of gomock
binary_analysis does not utilize scut (license test already uses scut and does not need modification)
What is the new behavior (if this is a feature change)?**

No behavior change anticipated
binary_analysis and license check tests updated to use gomock

ListFiles and GetFileReader mocked for both
ListLicenses mocked for license check (replicates localDirRepo by throwing Unsupported Feature error)

binary_analysis updated to use scut

test cases modified to include some logging information

Which issue(s) this PR fixes
Fixes #4032

Thanks for picking up the issue. I made one small tweak to the PR body, as Fixes #1234 is a special keyword for GitHub.
https://docs.github.com/get-started/writing-on-github/working-with-advanced-formatting/using-keywords-in-issues-and-pull-requests#linking-a-pull-request-to-an-issue


JAX and Numpy functions: How to structure them?

This repository contains a 2D Navier-Stokes equation solver and data processing methods. The solver, written using the JAX library, is computationally expensive and leverages GPU acceleration. The less intensive post-processing methods use NumPy.
Some functions are required by both the solver and post-processing. Currently, duplicate copies exist – one for JAX and one for NumPy. What is the best way to optimize this code structure?

Passing a backend variable backend = 'numpy' or 'jax': Suitable for functions where the underlying structure is identical between NumPy and JAX, with only the library calls differing
Write all the functions in JAX (Need to think over it)
Pros:

User friendliness
Cons:
Requires careful consideration of JAX-specific function implementations.

Also at low resolutions, numpy is faster than gpu-jax, so ability to run on either is beneficent, falling back to numpy when jax is not installed is also favorable

For the solver, At low resolution, JAX-CPU is faster than JAX-GPU. I haven't tested for numpy. I can mention this in the readme for now.

I mean for this reason, it is good to have it as a selectionable option, even for the runs

A colleague just told me about the Python "Array API" concept, which might be useful reading for this:
https://data-apis.org/array-api/latest/purpose_and_scope.html#stakeholders


Implement SetChargingProfileRequest and basic database storage/loading

Describe your changes
Implements handling SetChargingProfileRequest from K01
Checklist before requesting a review

[x] I have performed a self-review of my code
[x] I have made corresponding changes to the documentation
[x] If OCPP 2.0.1: I have updated the OCPP 2.0.1 status document
[x] I read the contribution documentation and made sure that my changes meet its requirements

Depends on #682

CC: @shankari

@louisg1337 @the-bay-kay can you pre-review this before I take a look?

I'm very confused by the tests segfaulting on the last few CI runs. They do not segfault locally.

I'm very confused by the tests segfaulting on the last few CI runs. They do not segfault locally.

I am not sure if it's related but I have seen issues with the test databases before. It was the other way around then though, Segfaults locally and not on the server.
In general I think it's better to unit test against in memory databases instead of actual file databases. In this case I would replace /tmp/ocpp201/cp.db with an in memory database. Make sure you don't use the same cache as the device model does ;)

I'm very confused by the tests segfaulting on the last few CI runs. They do not segfault locally.

I am not sure if it's related but I have seen issues with the test databases before. It was the other way around then though, Segfaults locally and not on the server.
In general I think it's better to unit test against in-memory databases instead of actual file databases. In this case I would replace /tmp/ocpp201/cp.db with an in memory database. Make sure you don't use the same cache as the device model does ;)

I did make some changes on the database stuff, when it opens I am adding some flags. Can that be the reason for recent crashes?
The in memory database did not work because those flags are missing, but if you use the correct flags, it will work. I did not look into the test to see if they use those flags but if you want to change to an in memory database, you have to check that.

I'm very confused by the tests segfaulting on the last few CI runs. They do not segfault locally.

I am not sure if it's related but I have seen issues with the test databases before. It was the other way around then though, Segfaults locally and not on the server.
In general I think it's better to unit test against in-memory databases instead of actual file databases. In this case I would replace /tmp/ocpp201/cp.db with an in memory database. Make sure you don't use the same cache as the device model does ;)

I did make some changes on the database stuff, when it opens I am adding some flags. Can that be the reason for recent crashes?
The in memory database did not work because those flags are missing, but if you use the correct flags, it will work. I did not look into the test to see if they use those flags but if you want to change to an in memory database, you have to check that.

Having said, this was when not looking into the logs. I now looked into the logs but I can not really see why the tests fail. They seem to stop, or crash maybe, but it is not really clear to me which tests fail and why.

The tests didn't segfault this time for some reason?

@couryrr-afs just to clarify, one of the two items I had asked for before approval was:

at least a high-level design of what the final error handling during load will be; even if the implementation waits until later

Here's the comment around error handling https://github.com/EVerest/libocpp/pull/711#discussion_r1690006967
I don't see a response to it, either in this PR or in the non-blocking comments PR. The "non-blocking PR" also does not include the nits from this PR, only from #611
If you did add the response elsewhere and I missed it, can you add a link to it here?
Again, I am looking for two high level topics before I approve:

Tracking the non-blocking comments so they don't get lost
A high-level description of the design for the final error handling (https://github.com/EVerest/libocpp/pull/711#discussion_r1690006967) so that we can write it down before we forget it

Still not seeing the non-blocking issues from this PR in https://github.com/US-JOET/base-camp/issues/173

@couryrr-afs just to clarify, one of the two items I had asked for before approval was:

at least a high-level design of what the final error handling during load will be; even if the implementation waits until later

Here's the comment around error handling #711 (comment) I don't see a response to it, either in this PR or in the non-blocking comments PR. The "non-blocking PR" also does not include the nits from this PR, only from #611
If you did add the response elsewhere and I missed it, can you add a link to it here?
Again, I am looking for two high level topics before I approve:
* Tracking the non-blocking comments so they don't get lost

* A high-level description of the design for the final error handling ([Implement SetChargingProfileRequest and basic database storage/loading #711 (comment)](https://github.com/EVerest/libocpp/pull/711#discussion_r1690006967)) so that we can write it down before we forget it

@shankari the tracking ticket on the AFS side has been updated with what I believe to be a full list.
For the conversation around the database I asked for it to be discussed in the WG, 8/7/2024, and will update the issue referenced with those details. Outside of the comments here is there anything else that is needed for this topic?

I spot checked the tracking ticket and it has a couple of issues from here. Giving you the benefit of the doubt that all the pending changes have been tracked. Approving this now.

@marcemmers @hikinggrass @Pietfried I haven't seen any requests from the community to fix the static code analysis, so I didn't hold up my approval for it. However, for the projects that I maintain, I generally don't like to regress on the automated checks. Once you do that once, then the check is essentially useless until it is fixed, because the existing errors will mask any new ones. I look forward to seeing how you respond to this as part of your approval....

@shankari Thanks for bringing it up, I agree we don't always look that well at the static code analysis. Unfortunately this particular tool is flagging false positives sometimes so I have grown a little complacent with it.
For this ticket it is complaining about SQL issues and duplication in test code so for me there are no blockers there. Might be a good idea to disable some of the warnings we don't look at anyway @hikinggrass @Pietfried

Can this be merged @christopher-davis-afs ? Let me know and I'll press the button.

Yes, this is ready :)


Patch 5

coverage: 92.832%. remained the same
when pulling 00bf45ccaab005c2f8b4b01739acf3217981d250 on sjanssen2:patch-5
into 6e673bd90b9f59ddfe2f4332372f7926bc5a0a72 on qiita-spots:dev.


Aggregator on multiple properties

Hi @nicolaskruchten ,
Thanks for the great library.
I am having a typical scenario in my project where i need to do aggregations on multiple properties. for example, if i have four attributes a1, a2, a3 & a4.
i would like to do sum or any other aggregation of all the four attributes separately and show it in graph as four different bars i.e. for a1, a2, a3 and a4.
Any help will be appreciated.
Thanks

Hi! Unfortunately there is no way to do this: https://github.com/nicolaskruchten/pivottable/wiki/Frequently-Asked-Questions#multi


Simplifies the ValueWriter trait family

The ValueWriter trait's container-writing methods (write_list, write_sexp, etc) take a closure using HRTB, allowing the user to call whatever methods they want on the provided container writer.
Unfortunately, due to a limitation in the compiler's implementation of HRTB evaluation, HRTB lifetimes are over-conservatively assumed to be 'static. This constraint led to a number of workaround warts in the ValueWriter trait family.
This PR replaces those closures with a collection of new traits.
Old signatures
fn write_list<F: for<'a> FnOnce(&mut Self::ListWriter<'a>) -> IonResult<()>>(
    self,
    list_fn: F,
) -> IonResult<()>;

fn write_sexp<F: for<'a> FnOnce(&mut Self::SExpWriter<'a>) -> IonResult<()>>(
    self,
    sexp_fn: F,
) -> IonResult<()>;

fn write_struct<F: for<'a> FnOnce(&mut Self::StructWriter<'a>) -> IonResult<()>>(
    self,
    struct_fn: F,
) -> IonResult<()>;

fn write_eexp<'macro_id, F: for<'a> FnOnce(&mut Self::MacroArgsWriter<'a>) -> IonResult<()>>(
    self,
    _macro_id: impl Into<MacroIdRef<'macro_id>>,
    _macro_fn: F,
) -> IonResult<()>;

New signatures
fn write_list(self, list_fn: impl ListFn<Self>) -> IonResult<()>;

fn write_sexp(self, sexp_fn: impl SExpFn<Self>) -> IonResult<()>;

fn write_struct(self, struct_fn: impl StructFn<Self>) -> IonResult<()>;

fn write_eexp<'macro_id>(
    self,
    _macro_id: impl Into<MacroIdRef<'macro_id>>,
    _macro_fn: impl MacroArgsFn<Self>,
) -> IonResult<()>;

These traits are intentionally very close in meaning to the closures they replace. However, introducing them simplifies things quite a bit; in particular:

We are able to remove a lifetime from each of ValueWriter's associated types. For example: ValueWriter::ListWriter<'a> is now ValueWriter::ListWriter.
Because the traits' generics do not involve HRTB (for <'a> ...), the compiler is able to accept the traits anywhere we were already accepting closures.
We can automatically implement the new traits for the old closures, so there's no change to user code needed.
Passing around values that implement these types is much less likely to lead to lifetime errors.
The method signatures are less likely to cause your eyes to bleed.

This patch also modifies the behavior of Symbol's implementation of Borrow, which allows Symbols to be used as keys in a HashMap. Previously, the Symbol would panic if it had no text and the user called borrow() to get a &str. (See #444 for a more detailed write-up.) This PR encountered a spot in our implementation of Struct/Fields that needs to look up fields which have unknown text, causing the tests to trigger the panic. For now, I've modified the Borrow impl to return the empty string if no text is available. This allows symbols with unknown text to be used as HashMap keys, but it could be surprising behavior on the off chance that someone finds another use case for Symbol's Borrow implementation. #444 discusses some long-term options that are more robust.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Per our offline conversation, I'll be incorporating these comments into my next PR.

For now, I've modified the Borrow impl to return the empty string if no text is available.

Could the function return Option<String> instead, and then return None if no text is available?


[OSF-7784] Admin app: accessing list of user's permissions 502s

Purpose
It was difficult to see what permission groups admins had and changing them required a somewhat circuitous route to the correct menu. This fix makes everything accessible from the admin page.
Changes
Created a new "AdminAdmin" model which is an Admin model for the Admin site that subclasses the AdminProfile Model with the admin.ModelAdmin model so admin data can be formatted properly for the admin page (admin/osf/adminprofile/).
Side effects
Incidentally migrations had lead to fields being represented in the AdminNode model and the OSFUser model to become out of sync leading to 502's and other problems caused Django trying to generate html for fields which no longer exsisted. I decided to add some code the should "migration-proof" the models.
Tests
It's difficult to write meaningful tests for these changes because despite the fact that they are back end models they directly effect the front-end design choices and nothing else and so much of the admin site is automatically generated by Django I think that's good coverage.
Screenshot and Video
Before

Clicking the user links causes a 502, with no other results.
After

Permissions listed and clicking them allows an overwrite.
Ticket
https://openscience.atlassian.net/browse/OSF-7784

@brianjgeiger added the gifs, should this be demoed too?


WireGuard

@anjiahao1
@xiaoxiang781216
@gregory-nutt
@zx2c4
Hi,
I would like to request that WireGuard be integrated into NuttX. WireGuard is a new and modern VPN protocol that offers a number of advantages over traditional VPN protocols, such as OpenVPN and IPsec. WireGuard is faster, more secure, and easier to configure than traditional VPN protocols. It is also more lightweight, making it a good choice for embedded systems like drones.
Here are some of the advantages of WireGuard:

Speed: WireGuard is significantly faster than traditional VPN protocols. This is because WireGuard uses a new and more efficient cryptographic algorithm.
Security: WireGuard is more secure than traditional VPN protocols. This is because WireGuard uses a number of security features that are not available in traditional VPN protocols, such as perfect forward secrecy.
Ease of configuration: WireGuard is easier to configure than traditional VPN protocols. This is because WireGuard uses a simpler configuration syntax.
Lightweight: WireGuard is more lightweight than traditional VPN protocols. This is because WireGuard uses a smaller code base.

These advantages make WireGuard a good choice for embedded systems like drones. Drones are often resource-constrained, so it is important to use a VPN protocol that is lightweight and efficient. WireGuard meets these requirements, making it a good choice for drones.
The OpenBSD kernel already has an implementation of WireGuard, which could be ported to NuttX. This would provide NuttX users with a secure and reliable VPN option. Searching the NuttX code for references to WireGuard, I found that NuttX already includes crypto code from OpenBSD: https://github.com/apache/nuttx/blob/bc0fe0ea16c8124e56309bf5bb98c363940d4a97/include/crypto/chachapoly.h#L70
I believe that WireGuard integration would be a valuable addition to NuttX. It would provide users with a secure and reliable VPN option, and it would make NuttX more competitive with other embedded operating systems.
Thanks,
Pavan

What's component WireGuard depends on doesn't support on NuttX yet? It's very nice to support vpn natively on NuttX.

I agree. Thanks for your interest. Here is more information on the WireGuard protocol.

Look like WireGuard just need UDP and the crypto algorithm. The lack crypto algos are Curve25519, SipHash24 and HKDF, which could be supported quickly since crypto is a pure software without any hardware/software dependence. Do you have a plan to port or need help from the community?

I would appreciate help from the community porting WireGuard to NuttX, because it would be of great benefit to everyone. I believe it is a strong security recommendation. I think it is also a good practice for NuttX developers to study OpenBSD to learn about secure development.


new build in order for wrapperStyles and wrapperProps to work as expected

Resolves the hard coded display: inline-block that is in the current build.
And let's us set wrapperStyle and wrapperProps like in examples and in the source.

Looks good, might want to consider amending the commit message to be more descriptive?

like why it's a new build? is that what you mean @robcalcroft?

@hontas I meant more of a description of the PR itself, if I were to do a git log and see new build, I'd have little idea of what changes that commit made. Eg Resolves the hard coded display: inline-block would be more descriptive.

@robcalcroft fair point ;) is this ok?

Yeh that works a lot better 👍

resolves #66

👍

@robcalcroft any plans on merging and publishing a patch to npm?

@hontas I'm not a contributer on this project sorry

@ryanflorence any planson merging this PR and publishing a patch to npm? Without it wrapperStyle and wrapperProps is broken..


TX_EXECUTION_MAX_TIME_SOURCE wrap-around handling in tx_execution_profile.c

Hello,
Affected functions:
_tx_execution_thread_enter
_tx_execution_thread_exit
_tx_execution_isr_enter
_tx_execution_isr_exit
In the wrap around case, the ticks elapsed are calculated like this:
delta_time =  (EXECUTION_TIME) (current_time + (((EXECUTION_TIME_SOURCE_TYPE) TX_EXECUTION_MAX_TIME_SOURCE) - last_start_time));
This should be:
delta_time =  (EXECUTION_TIME) (current_time + ((((EXECUTION_TIME_SOURCE_TYPE) TX_EXECUTION_MAX_TIME_SOURCE) + 1) - last_start_time));
Otherwise there is an error of one tick.
Consider the corner case where last_start_time=0xFFFFFFFF and current_time=0x00000000. This leads to delta_time=0 which is not correct. The fixed line above produces delta_time=1.
Udo

Hello Udo,
Thank you for bringng this up. We will fix it in the next release.

This has been fixed in 6.1.11: https://github.com/azure-rtos/threadx/blob/master/utility/execution_profile_kit/tx_execution_profile.c


Revert "Revert "adding new Game Category enum values""

Reinstates PR #71; resolves #70

Coverage remained the same at 94.846% when pulling e4406645d9bf3d3f86e083d2b5fd477d4d6a8951 on revert-72-revert-71-game-category-enums into a40778fc7d3fb4d84f55d8bd573872fdcb8eda35 on master.


Add Naver sentiment movie corpus

This PR adds the Naver sentiment movie corpus, a dataset containing Korean movie reviews from Naver, the most commonly used search engine in Korea. This dataset is often used to benchmark models on Korean NLP tasks, as seen in this paper.

Closed via #1252


Apple TV support 4: support for input (tvOS focus engine)

Motivation

Support Apple TV input using the remote or keyboard.  TouchableHighlight and TouchableOpacity have been modified so that TV remote navigation will work with existing projects that use these components.

Test plan

Existing CI for tvOS still passes.  New snapshot tests for programmatically changing focus will be added in a later PR.

In looking at the Travis CI logs, it seems that the automated tests will not run correctly if StatusBar and PushNotification don't exist.  So I added those back to the Apple TV build, and stubbed out the parts that don't compile on tvOS.  After this, I was also able to enable most of the UIExplorerSnapshot tests.

@javache here is round 3 of Apple TV changes -- these make Apple TV fully working with Siri Remote and keyboard input.  Travis CI seems broken now... objc-test.sh, objc-test-tvos.sh, npm test, and npm flow check are all passing in my environment.

@dlowder-salesforce after updating to master it seems like project.pbxproj is full of
464A35741DB137BD0070CA98 /* PBXContainerItemProxy */ = {
+                 isa = PBXContainerItemProxy;
+                 containerPortal = 464A34C01DAEB7F20070CA98 /* RCTLinking.xcodeproj */;
+                 proxyType = 2;
+                 remoteGlobalIDString = 2D2A28471D9B043800D4039D;
+                 remoteInfo = "RCTLinking-tvOS";
+         };

Wondering if it matter and if yes can it be optional?

@chirag04 yes those should be there... the project now has tvOS targets and RCLinking-tvOS is needed.  They shouldn't matter unless you're doing a tvOS build.

I closed this PR, will submit it again later once Travis stability issues are under control.


Support custom search engines

Hello @Endle , amazing work !
Would it be possible to support custom search engines like the open source SearX ? Even better would be to let the user set various search engines URLs to this plugin to apply on like: DDG, SearX, Google ...
Thank you for your time !

Hi, thank you for your suggestion.
It's obvious that people want to add more search engine supports, for example, duckduckgo: https://github.com/Endle/fireSeqSearch/issues/17
I'm open to supporting more search engines. However, I don't think a custom search engine could be possible. If I want to support a new engine, I need to do the following:

Edit permission in manifest.json : https://github.com/Endle/fireSeqSearch/blob/4fc852cbfdba8cc5093dee0ddfc1bcb6e11f7a67/fireSeqSearch_addon/manifest.json#L12
Insert a dom to the web page, considering the different page structure for the new search engine  https://github.com/Endle/fireSeqSearch/blob/4fc852cbfdba8cc5093dee0ddfc1bcb6e11f7a67/fireSeqSearch_addon/main.js#L128

Currently, my js implementation is too hacky, and too hard-coded for Google. I'm thinking of re-factoring my js code, making it easier to add more search engine support.
PRs are welcomed, including some hacks for a new search engine. I have no timeline for the refactoring I planned, and I don't want to block users from accessing new search engines.

Hi @krillin666
I had a try with SearX. Their DOM looks quite clean to me

I think it won't cost me too much time to provide a hack for it.
However, the domain is an issue. I refrain from adding all searx.* domains to the host list. I would feel untrustable when a web extension is asking for a loose range of permissions, and I'll avoid that as a developer.
I have no knowledge about SearX (I spend some time googling it before writing this comment). I have two naive questions before adding support for SearX

Is there a widely used, stable domain for SearX? If so, I can consider adding it right now
If self-host a SearX instance, is there a typical URL? For example, <IP_ADDRESS>/SearX   (I know nothing. I just guess)

Hi @Endle thank you so much for taking the time to research this !

The most common used instances I gather should be: https://searx.be/, https://searx.fmac.xyz/ and https://searx.prvcy.eu/. Being that they have the best features, the server is outside the US and have been maintained the longest.
If you self host an instance you could access it by the local domain (would be just <IP_ADDRESS> or something similar), but if you want to access outside your local LAN you must set up a reverse proxy which could be anything like: google.krillin.com

With this information, if you do have the time, I think the best is just supporting those three main instances which would cover must users. Besides, you can choose any instance you want, so If a user wants to benefit from this project we could then choose one of these instances if he's not already using those.
Thank you for your time !

@krillin666 I added support to searx.prvcy.eu and searx.fmac.xyz in version https://github.com/Endle/fireSeqSearch/releases/tag/0.0.7  These two sites have almost identical DOM structure
So happy that Mozilla approves my update while I'm writing this comment  https://addons.mozilla.org/en-US/firefox/addon/fireseqsearch/versions/
If there is any issue when using these two sites, please no hesitate to open a new issue.
I'll remain this issue open for a while. I'm thinking if I could find a solution for custom search engines. At least I could refractor my code so adding a new search engine support would be easier

Since searx is a meta search engine it would be cool if this local server served the results in a format where Logseq notes could be actual hits (with title and description) but that's likely another project

where Logseq notes could be actual hits

Let me share a SECRET with you

Update to the latest version of the server and Firefox extension, then there is an experimental function for showing a summary.

I'll remain this issue open for a while. I'm thinking if I could find a solution for custom search engines. At least I could refractor my code so adding a new search engine support would be easier

I had to eat my words. I haven't found a proper way yet. If anyone wants support for a new engine, new PR plz, and I'll do it ASAP.

Hi @Endle , thank you so much for adding those 2 instances of searX. However, the results are not appearing in those two instances, is there any bug ? Could you see if it appears for you, please?
I also have another question: Sometime, I use other SearX instances, would it be possible for the user to define the instances he wants to use ?

Hi @krillin666

Hi @Endle , thank you so much for adding those 2 instances of searX. However, the results are not appearing in those two instances, is there any bug ? Could you see if it appears for you, please?

Thank you for reporting it. It is a bug. I've created https://github.com/Endle/fireSeqSearch/issues/103 and I'll be working on the fix

I also have another question: Sometime, I use other SearX instances, would it be possible for the user to define the instances he wants to use ?

I'll remain this issue open for a while. I'm thinking if I could find a solution for custom search engines. At least I could refractor my code so adding a new search engine support would be easier

I wish so. However, as I mentioned,

I haven't found a proper way yet. If anyone wants support for a new engine, new PR plz, and I'll do it ASAP.


How to transfer environmental variables？

How to transfer environmental variables？
like NODE_ENV ,I want a custom env like NEXT_ENV,how to do ?

Hi!
You can use .env file with dotenv module. Here you can find simple example.


Shell capture hangs indefinitely

I have successfully been capturing the output of some commands, but when I tried to capture the output of ps, the program is hanging indefinitely. Here is a sample program that reproduces the issue:
#!/usr/bin/env hush

std.print("1")
let result = ${
  ps aux
}
std.print("2")

When running this the "1" is printed but the "2" never comes and the program continues to run.
Notably, if I remove the capture and just run the command, it works.
#!/usr/bin/env hush

std.print("1")
{
  ps aux
}
std.print("2")

Ouch, we have our first bug :). This used to work on previous development versions, but I had to rework the capture code to solve a bug related to redirections, and accidentally introduced this bug while doing so. The issue is that we're reading the pipe after waiting the command to finish, but the command is waiting because the pipe is full. I already have a fix in mind, and will try to implement it until the weekend. Thanks for reporting!

Interesting cause... makes me think about my comment in another issue about being able to read stdout from async capture before joining.
I'd imagine hush will need to support streaming input as bash supports streaming output.

Talking about that, if I recall correctly, to stream output using bash one would use a named fifo (mkfifo) and then use standard redirection operations to route the data. Something like:
#!/usr/bin/env bash

mkfifo /tmp/webserver.log

webserver --start > /tmp/webserver.log &

while read data < /tmp/webserver.log; do
  # use $data
end

Considering this approach, it makes sense to have the capture block produce a single string instead of streaming the output. What do you think?

Fixed by 335d5b, released on v0.1.3-alpha

@gahag
When you pipe in bash I believe it also streams. i.e. I believe that each line of output is sent to the next command in the pipe immediately, it doesn't batch multiple lines.
I think Hush will need to support this or miss out on some common use cases. For example, if I want to tail live server logs and filter lines to print only the ones with errors I can do something like aws logs | grep 'ERROR'. I don't think that currently I can do this in hush with an async capture around the aws logs since the command would never finish on its own.

But those are two separate features, and both work the same way in Hush and Bash. Capture is synchronous, so it will hang until the command finishes.
#!/usr/bin/env bash
$(mycommand)

#!/usr/bin/env hush
${ mycommand }

Pipes on the other hand are asynchronous, and will allow data streaming.
mycommand | tee file.log | grep Error

{ mycommand | tee file.log | grep Error }

Hush implements the exact same behavior as Bash in both cases.


fix(frontend): involve vnode column in batch query planning

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
In some previous PR, we refactor our code that unify the logic of computing vnode in TableDistribution so that we enable querying the sink internal table. However, in frontend optimizer there is still some remaining code that has its own logic to compute vnode, which causes panics when querying sink internal table with filter on the vnode column， e.g. select * from __internal_sink_xxx where kv_log_store_vnode = 0 limit 10.
In this PR, we modify this code to let it use the unified logic, so that there is no panic anymore.
Previously the code of TableDistribution is in risingwave_storage crate, which is not accessible from risingwave_frontend. In this PR we move it to risingwave_common, which causes most of LOC in this PR.
Checklist

[ ] I have written necessary rustdoc comments
[ ] I have added necessary unit tests and integration tests
[ ] I have added test labels as necessary. See details.
[ ] I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features #7934).
[ ] My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
[x] All checks passed in ./risedev check (or alias, ./risedev c)
[ ] My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)

[ ] My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

[ ] My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

generally LGTM, Could you add some e2e test to query the log store's state table?

It's difficult to add slt e2e test because the SQL to query the state table requires the internal table name of the state table, which can only be obtained from the result of show internal tables, but it seems that currently slt doesn't support building SQL text from the result of some previous query.
I have instead added an integration test in the deterministic sink test.


HTML Deep Parser documentation?

In https://github.com/vsch/flexmark-java/wiki/Extensions#list-parsing-options I notice there are HTML_BLOCK_DEEP_PARSER and other option names starting with that. Could you tell me what the deep parser is, how it is different from the default parser, and when it should be enabled?

@ssikuro, common mark has very crude HTML block handling which only uses the leading first line to determine HTML block start and a blank line for block end.
Deep HTML parsing allows more control because it parses the HTML to determine the contents and where it ends. It is one of those features that if you are not sure you need it, then you probably don't.


Dynamic columns support

Two new gridster properties have been added to support dynamic columns: 'minWidthToAddANewColumn' which indicates the minimun width (in px) to add a new column and 'dynamicColumns', a boolean indicating if we want a responsive gridster that calculates the best number of columns for every screen resolution.
On every window resize, the number of suitable columns will be calculated (if 'dynamicColumns' is set to true) taking into account that the minimum width to add a new column is set by 'minWidthToAddANewColumn'. This is also the minimum width of a column before removal if window resizes down.
Feel free to suggest any changes

Any reason this is not getting reviewed?

@arkabide  dynamic colums weather make the items in gridster order  right when change colums?


Implement InprocAddr parsing

Currently InprocAddr is only a wrapper around String. Using the same interface (if possible), proper parsing (FromStr trait) and appropriate methods should be implemented.
See zmq_inproc for reference.

See this.

Closed by 0b4c611a519f8440ae1ea7e8c6fecf19dd26412a.


Clarify which AWS service is doing the text-to-speech conversion

Provide some additional detailed in the README about how the text-to-speech conversion is being done, so people can better understand the other values they could provide in the default.env file, for example.
In fact, perhaps we could add comments into default.env, pointing people to the relevant AWS page to see the available values for each variable.

Amazon option uses the Amazon Polly
Google option uses Cloud Text-to-Speech

Maybe we also add some notes that also describe how to listen to samples of the voices that each service offers.

PR above approved so closing this issue now too.


Fix page shimmer effect on setting section.

Description
Fixed for tax rates, inventory, and roles page.

Checked and found that the shimmer effect is working fine now. Please check the video for reference.
Video
https://github.com/bagisto/bagisto/assets/92721837/d1a258a8-4eb2-4db3-ae82-1d61effc734a
https://github.com/bagisto/bagisto/assets/92721837/4cbc44ca-c251-44d5-8756-1cdaa4ec8eb6
https://github.com/bagisto/bagisto/assets/92721837/156848ab-10db-4172-abc6-4c98fb1ac183


Adds mapbox api key to cocoapods

This API key will need to be set with an official key for production.

Fails

:no_entry_sign:

This PR includes changes to the Emission Pod's native code but does not have a package.json
change for the update to the "native-code-version". If this is fine, add #native_no_changes to your PR message.

Warnings

:warning:

This PR comes from a fork, and won't get JS generated for QA testing this PR inside the Emission Example app.

  Generated by :no_entry_sign: dangerJS

I’m seeing this error from the test This PR includes changes to the Emission Pod's native code but does not have a `package.json` change for the update to the `"native-code-version"`. If this is fine, add #native_no_changes to your PR message.
Do I need to update the package.json file?

Yeah we need to update native-code-version and version in package.json
@ashfurrow can we just bump the # from 9 to 10?


Double pipe required for OR in version contraints

Double pipe is required to resolve to 5.4

Coverage remained the same at 93.594% when pulling 5f3218f1a79fb6ce6bfcc8f806387742789784f2 on andyappitized:patch-1 into d058c6963204f42aef1830e60349268c3af77135 on jarektkaczyk:5.3.

Why is this not merged yet?

+1 for wanting this merged

+1 for wanting this merged

not necessary


ignore debug ckb 550+, 4803762, 0813

Proposed changes
Issue Number: close #xxx

Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

run clickbench

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 44.6 seconds
stream load tsv:          537 seconds loaded<PHONE_NUMBER>9 Bytes, about 132 MB/s
stream load json:         20 seconds loaded<PHONE_NUMBER> Bytes, about 112 MB/s
stream load orc:          65 seconds loaded<PHONE_NUMBER> Bytes, about 16 MB/s
stream load parquet:          31 seconds loaded 861443392 Bytes, about 26 MB/s
insert into select:          29.3 seconds inserted 10000000 Rows, about 341K ops/s
storage size:<PHONE_NUMBER>8 Bytes