Some more "For Dummies" examples

I am making this statement in a purely, purely, completely selfish manner, but I recently picked up Q.js to try and adopt it into my code. My understanding of promises, $.Deferred, the whole async world is - and practically still is, 0.
 I think I would have found it a lot easier to dive into if there were some more simple, end to end, copy-paste examples that show Q functioning in less complicated scenarios.
To cite an example, you start off your tutorial with something that already lost me; https://github.com/kriskowal/q#tutorial, you will notice the code begins like this..
promiseMeSomething()
     .then(function (value) {
   }, function (reason) {
});

Okay, right away, you lost me - because I see you having a function here that gets a then chained to it, and I have no clue why. Where did this promiseMeSomething() come from? When does it get a .then() chained function? I'm digesting what I just saw up ahead and I'm already lost here. This trend keeps going as I keep reading.
Am I the average user? I'm not certain, I am certainly not adept with the entire idea of promises and deferrables, but isn't that the people you need to be using Q the most? People like me that want to be better coders, but are reaching out to take hold of the tool boxes available?
Your tutorials then continue on, as I am still lost from the first one. You go through a ton of useful topics, and I will not deny they are awesome. I found the section on sequences to be of specific, particular use. I loved it. In fact I found it so good that it solved one of my problems, it answered a big problem I was having at the time.
But it isn't until halfway through the documentation that we're met with this part; https://github.com/kriskowal/q#the-beginning
It is more than halfway down the docs that we're even shown an example of how to get a promise from something. And even then, it's a bit confusing.
Don't get me wrong, I have no right to criticize, I have no right to complain, and I certainly don't have the intellect to back up a promotion for better documentation. But as a medium-level coder, as someone who came to Q completely unsure of why I needed it, having been told to look into it by a peer, I found it very hard to just get a first sample up and running.
Your library is brilliant, gorgeous even. Now that I have accomplished something with it, I am in love, I want to learn more. I crave learning more. I am perusing the source code like I would a comic book. I understand less than 2% of it but it is so immaculate that I am excited at the 2% I do understand.
But I think that, if you're still going forward with the 2.0 release, you would really reach a lot more people more quickly if there were some much simpler examples that were very rapidly there, in your face, ready to go, that looked like they belonged in the real world.
What hooked me on jQuery wasn't it's documentation, but it's immediate presentation of how it solved a problem I've personally had.
If you go, right now, to jquery.com, this is what you see.
![jQuery Front Page]
(http://i.imgur.com/VItbHjM.jpg)
I am immediately shown a real world example, something I've tried to do in the past. Something I need to do right now. It's simple, it's brief, it required me to understand nothing but the fact that I wanted to change the text of a button.
Inversely, if you go to http://documentup.com/kriskowal/q/, right away you see this;
![q.js landing page]
(http://i.imgur.com/ysmz2To.jpg)
Wait, now what? So am I getting a Version 1, or a different one? I get the step1() step2() etc example, but then I look at Q.fcall - what is promisedStep1?
This trend is a bit nebulous throughout the Q documentation. There are actually very few places where I found code I could literally copy over to a sample program and just run, to see what it did.
 I just love your library, and in the 3 days I have been using it, I love it so much that I felt compelled to share my experience on how I think it could be more accessible.
I also want to add, if this is an inappropriate place to be putting a comment or statement like this, please let me know. I'm new to using github with other people. I'm new to a lot of this. It seemed like the right place to put things I wanted people who were working on the project to see. If it is not the appropriate place, I'd like to know what a more appropriate venue is.

thank you for bringing up this issue.
I too find it difficult to understand how to use Q after reading the readme article.
I am guess, if I have asynchronous function myAsyncFunc(), then I could enhance with Q by
Q.fcall(myAsyncFunc).then(resolve(value),reject(err));
Is it what Q is trying to achieve?
ciel, could you kindly show us hello world sample code of using Q?


Cursor in captured mode is broken for devices working in absolute mode

Godot version:

f50dd682f6a0f9506daaf16fed06f4bc9efa6599
OS/device including version:

Linux / Ubuntu 18.04.1 LTS
Issue description: Steps to reproduce:

Set e.g. Wacom pen in absolute mode with the Gnome settings-panel or:
xsetwacom --set Wacom Intuos4 4x6 Pen stylus Mode Absolute
xsetwacom --set Wacom Intuos4 4x6 Pen stylus Area 0 0 31496 9842
xsetwacom --set Wacom Intuos4 4x6 Pen stylus MapToOutput desktop

The cursor leaves our planet:

Minimal reproduction project:

Modified example from  https://github.com/godotengine/godot/issues/21744 (thanks!):
i21744-Constrained-Cursor.zip

I didn't test it but maybe #19191 will fix this issue too. Like I said here https://github.com/godotengine/godot/issues/21744#issuecomment-418393418, capture mode on linux is very hack.

Yeah, the source code is already full of frustration ;)
Unfortunately it breaks the device with absolute coordinates even more :-/

i21744-Constrained-Cursor-v3.zip
0001-Use-XInput2-RawMotion-to-generate-MouseMotion-events.patch.txt

The cursor doesn't leaves our planet anymore.

Almost. Ok, let's add one circle ;-)

i21744-Constrained-Cursor-v5.zip

This is not a bug, in absolute mode this is expected because cursor will always forced to stay exact where the pen is, because of that, if your pen is not in center of the wacom pad the relative motion will be updated ever time.
Comparasion:
Mouse:

Pen with absolute:

The only difference is when mouse stop moving, the relative motion (white dot) stop, but pen with absolute mode this is not possible. Only way to get the same result is changing the wacom to "Relative" mode.

Isn't it possible to calculate it from the incoming data?

Maybe it's possible. I think the only way is faking relative mode when using absolute mode on tablet but I don't know how to check that info.

Also, I don't know if it's worth implementing.

Games in general or made with godot?

Anything that does not work with absolute tracking mode, including Godot. We use VMware to manage the computers in the schoolroom ...

Because blender don't use captured mode for free camera, it's use hidden.

I notice now that "free cam" works like blender fine in godot 3.0.6. We have a regression here.

I'll open an issue about that.

I notice now that "free cam" works similar to blender in godot 3.0.6. We have a regression here.

Oops, forget that. I'm sleepy and winding things up here. :)

This issue is still not resolved in absolute tracking mode
https://github.com/godotengine/godot/issues/19692

Should be fixed in #19191 now.

With the two PRs applied to the master, everything (free-cam, editor, ...) seems to work!
0001-Fixes-to-mouse-mode-confined-and-captured.patch.txt
0002-Use-XInput2-RawMotion-to-generate-MouseMotion-events.patch.txt
The only thing that catches my eye at the moment, is that the movement to the tablet edge (window-centered cursor) does not reach the edge of the window. (I've mapped the tablet surface to the entire desktop):


fix android in winit loop rewrite

not saying it works, but at least it compiles
for obscure reasons, I can test once it's merged in your PR but it's a bit painful to do before

Thanks, I totally missed those changes! 😊


ajaxWithCredentials

ajaxWithCredentials property is not working.
ajaxWithCredentials: true,
getTileUrl: function (level, x, y) {
return documentviewerService.getTileImageUrl(level, x, y, imagePath, 256);
            }

And no Bearer-Auth-Token in Header in the Request...
It should be:  (example)
Authorization: Bearer nEQRRxQxps4xyZfPzdFxvWNu-YLLtsHorJocNx-s8MluxCFc8___nq4qhtVsHdMU5qra-OqG8AbFGwms0A4is3zJmLYHNT843Ad3gEY96RlUtNqCve7uJ4Sh5Gc3WBYEdeO-r3YNU1pJAbPu6GO6T4j5g-0qplA2c7xt4fXnLmlO-L_L9XHD0il4Zbuh5OVZipqIjHYFaO_3AHjnypjDcSisadnRf_HlNV4fNexhJ0qQGEpF8Eqh2b6kCg2uypfCuvVxhXFkK7gFTQNbgGa-ID1BKea9SynOSDR3X0WaP69_fs9d_OQqCX5enlwG682mjYIAnLr4wPxSNTgUcENeNOHcOY5E_nurZCLIXZlMkxANdOC36Tu4rF_8LZTtvfyKqfPayuvcW4z9NJyPUYoJOwca7Qg1Wank6Kijf9EvvmIbDjtKQ62x-ogYP9lqzsgEN7zkFH1Y9GD_kR6kasxch689nzEeFG2YYkrIPSRJhVW84IMH8cTLlCkRpQfH2l3oADP-QMNdVQj_sjHhSLtpoQ2q-B7hU2dXwBBpEfbQfk4A_fmKIiHWyO69m_7-mdYAZTklkLyAx6sp5MnQ8rjilT0AhOcdfWdHRufwWqEZmyhYuG-ylZLQyydCV6v67T-GIndyJY-qEtJPT_WCSEXQZ-GnvGwaygrZraZxzxpUlh7NCBJOjMPxyC72tfxijiU0xFFJDrUFEsjIvww8qDuK1N5kB9K4hUKocEuEF-9GudGZUN5kMbi_4Ra7ZZqYv5SzwBFB7fVD6CrSd1vXbv8U4Xe33pulVWwsz_mXbiMPXdketQZTCHJgObbY8G6ISW-sz61IaoMpsTwFstfn40PGffYND9-Ztkhx60iZK4Yj88He6wGFzIsbqok32G-LTu8fE9vCT566n3Xp3N9

I added that feature on @azaroth42's request (with PR #553), but I don't actually know that much about ajaxWithCredentials. Do either of you know what may be causing the issue?

The Authorization header is excluded from the withCredentials flag.  The flag governs cookies and (IIRC) basic authentication.  You can just set the Authorization header in the regular way of adding new headers.

Ahh ok!
There is no sample for this issue for openseadragon ...
I'll try it, thank you!
----- Ursprüngliche Nachricht -----
Von: "Rob Sanderson"<EMAIL_ADDRESS>Gesendet: 29.06.2015 04:59
An: "openseadragon/openseadragon"<EMAIL_ADDRESS>Cc: "jprhamburg"<EMAIL_ADDRESS>Betreff: Re: [openseadragon] ajaxWithCredentials (#672)
The Authorization header is excluded from the withCredentials flag. The flag governs cookies and (IIRC) basic authentication. You can just set the Authorization header in the regular way of adding new headers.
—
Reply to this email directly or view it on GitHub.

@jprhamburg Do you have any suggestions for how we could improve the documentation for this feature?

How was this resolved? I need to send the cookie with the AJAX request.

This is just a documentation issue. You need to set ajaxHeaders.


Tumblr thumbnails

I have the Download video thumbnails setting turned off and still have thumbnails downloaded on Tumblr. All of these are named with the ending _frame1.jpg, So they are easy to find and remove manually but should still be fixed.

Thanks for reporting this. It seems a location was missed the last time.
I think it will have been fixed in the next version.

The issue has been fixed and closed. You can still comment. Feel free to ask for reopening the issue if needed.


how to make textview height smaller?

There is need in my project that i have to made the textview smaller, I tried following but not getting success.
UITextView *textView = [[HPGrowingTextView alloc] initWithFrame:CGRectMake(15,4, 230,25)];

Set Minimum height of the text view.
self.textView.minHeight = 25


support password conversion, on exporter basis

per https://community.nodebb.org/topic/2688/after-migration-passwords/13

Little re-up of the issue c:

it's going to be a little while. sorry.

@akhoury I'm a little fuzzy on the details about how vanilla hashes the passwords, but even if vanilla (or any other forum) actually used the same encryption algorithm like md5, the fact that nodebb runs the password through bcrypt a few times makes that approach useless. For the password import to even work, the old forum would have to have the same salt, and run the password through bcrypt the same number of times as nodebb.

Sorry just caught up on the referenced thread. Imo the proposed solution is more work than is worth it. Plus, this would automatically exclude any proprietary closed source forum software. Having users reset their password is not a huge ask, especially in these times. (Plus an opportunity to have them make a better one)

I totally agree


Fix Terraform bug

What this PR does / why we need it
Terraform has a bug where changes aren't processed when ignore_changes is active for other attributes. The PR https://github.com/hashicorp/terraform/pull/17856 fixes this but isn't merged. I created a fork of Terraform 0.11.11 and merged in that fix.
Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #
Special notes for your reviewer:
Release note:

Fix bug with Terraform that causes problems on Tarmak upgrades.

/assign @simonswine

/lgtm


Fix MacOS version mismatch warnings when linking Pony programs

LLVM needs to have the same minimal API version set that we
use elsewhere. Right now that is 10.14.

This passing CI isn't enough to indicate that I correctly fixed. You need to check the logs and verify that the link warnings don't appear for any of the programs that we build during the CI testing process.


fix MSY search output with >1 season

format of the MSY search output was corrupted when there is >1 season.  Fix by using colsum to output the sum of catch across seasons for each fleet.
There is no issue.
What tests have been done?
examined revised output and verified that it was correct to use colsum, not rowsum
Where are the relevant files?
[x] No test files are required for this pull request.

@Rick-Methot-NOAA, can you walk me through where these changes are showing up in the report file a bit more? At first glance, the logic seems fine but I'm having a hard time finding where it will show up. @iantaylor-NOAA Maybe you could help me out with this since Rick is at PICES this week?

The output is only in forecast-report.sso and is not used by any R read
functions that I know of.  Basically it is just for my investigation of
user problems when they occur.
On Mon, Oct 23, 2023 at 7:13 AM Elizabeth Gugliotti <
@.***> wrote:

@Rick-Methot-NOAA https://github.com/Rick-Methot-NOAA, can you walk me
through where these changes are showing up in the report file a bit more?
At first glance, the logic seems fine but I'm having a hard time finding
where it will show up. @iantaylor-NOAA https://github.com/iantaylor-NOAA
Maybe you could help me out with this since Rick is at PICES this week?
—
Reply to this email directly, view it on GitHub
https://github.com/nmfs-stock-synthesis/stock-synthesis/pull/521#issuecomment-1775299082,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABPV4IFMRHHFZH7K2RJ6JJTYAZ3QJAVCNFSM6AAAAAA6JUFR2KVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONZVGI4TSMBYGI
.
You are receiving this because you were mentioned.Message ID:
@.***>


Community Idea-02 - set limit for transaction

Comments/feedback from community : "What I would like to see in symbol is the ability to set an upper limit on the number of withdrawals per day or per time, like a bank withdrawal.
For example, if you set a limit of 100xym per transaction l, you would only lose that much money. If a transaction  passes the 100xym limit, you would get a confirmation message like "2000xym will be moved" and be asked to enter your password."

Similar issue: https://github.com/symbol/desktop-wallet/issues/1618


fix(README): Updating README

:tada: This PR is included in version 2.26.1 :tada:
Your semantic-release bot :package::rocket:


Azure

@Talhasaleem110
Could you please elaborate the query for better understanding. So, we can assist you further.
It would be great if you could add a link to the documentation you are following for these steps? This would help us redirect the issue to the appropriate team. Thanks!!

@Talhasaleem110
Since we have not heard back from you, we will now proceed to close this thread.If there are further questions regarding this matter, please tag me in your reply. We will gladly continue the discussion and we will reopen the issue.
#please-close


Adding REDIS support

This is a part for the https://github.com/uthsc/UTHSC-WPCAS/pull/10
This will allow to use REDIS for storing active sessions.

Hey @jfritschi! What do ya think about the PR?

Hi Andrew, thanks for this PR. I'll leave more review to @jfritschi, but just wanted to weigh in with a few thoughts:
Adding the full predis-client library to phpCAS repo may not be the best way to add this support as it will significantly bloat the phpCAS library for all users whether or not they use Redis for ticket storage (a narrow slice of the user-population).
Currently phpCAS doesn't have any dependencies on outside libraries or a required install process -- the composer.json was added mainly to allow phpCAS to be included by other projects rather than the other way around. If dependencies on other libraries are to be added to phpCAS and especially optional dependencies like this PR introduces, then it may be good to take a step back and think about a phpCAS install / plugin process that allows users to optionally install additional dependencies to enable the features they wish to use, if any.
This PR is introducing REDIS support for PGT storage, but there really isn't anything special about REDIS -- storage PGT storage back-ends that use MongoDB, Memcache, or any number of data-stores would be just as valid and it would be good to develop an implementation that allows these to be added cleanly without bloating either the code-base or the public API methods.
An alternate sort of implementation would be to refactor the PGT storage methods as we did with the ProxiedService system. Rather than adding arbitrary new API methods for every conceivable type of proxied service that one might need to call, we instead defined an interface for a CAS_ProxiedService that users of phpCAS can implement as they need and pass into phpCAS::initializeProxiedService(CAS_ProxiedService $proxiedService) system. A similar interface could be defined for PGT storage backends that would allow clients to implement arbitrary storage mechanisms that could then be wired into phpCAS with something like a phpCAS::setPgtStorage(CAS_PgtStorage $pgtStorage) call. Existing file & DB storage would be reworked to implement this new interface with the existing setPGTStorageDb() and setPGTStorageFile() methods reimplemented to create and set implementations of the new interface.

So, @adamfranco, what do you recommend that we do with it?

I'd suggest first working up a PR with an interface and support for a pluggable PGT-Storage system as I described in the last paragraph above. This will be an easier feature to review, test, and support going forward and open up additional options for the Redis-specific feature you are looking for. The CAS_PgtStorage interface should define the only the methods that phpCAS will call on the instance passed into it.
Once pluggable PGT-Storage is in place, I see a few options for Redis support:
Option 1: Maintain CAS_PGTStorage_Redis and predis-client it in your application, outside of phpCAS
With phpCAS::setPgtStorage(CAS_PgtStorage $pgtStorage) you will no longer need to rely on patching phpCAS to wire-up this support.
Option 2: Add your CAS_PGTStorage_Redis class and assume that predis-client can be autoloaded
The CAS_PGTStorage_Redis class could simply assume that users of the class will need to have already added the predis-client library to their application and set it up to be autoloaded. This has the advantage of being simple in the phpCAS side and nothing will change for those that don't use the Redis support.
predis-client would then be added as a suggested package to phpCAS's composer.json. This would make it slightly clearer to those installing phpCAS via Composer that predis-client may be helpful for them to install if they want this feature.
Option 3: Set up some other installation mechanism for dependent feature libraries
Composer (or git submodules, or some build process) could be used to require all possible dependent libraries for any CAS_PGTStorage implementation shipped as part of phpCAS. This has the downside of adding these extra libraries to most installations whether they will be used or not, but would slightly lesson the steps required by those that do want to use them. This option is less desirable in my mind, but may make more sense if there are additional dependencies that are very commonly needed.

gotcha

I really like adams options! There is not much to add from my side.
The current PR is really not the right way. We should not include code into phpcas that we are not developing/maintaining. This is what interfaces or packages are for. I also think this would be problematic due to the incompatible license.

I was also wanting to extract out the session management in this. Wouldn't it just be better to abstract out the session calls to classes that implement the SessionHandlerInterface and allow users to inject their own via the constructor (if none provided default to PHP's default session management)?

We already discussed something similar a while back in #42 . I guess this could be a good starting point for such an undertaking.


Product list page import

This story covers importing the 168 pages indicated in the "category analysis" for product listing pages.  Those categories include 3, 12, 14, 15 and 17.  Each page should have the appropriate page metadata needed by the product list block so that search works correctly.
See these stories for more details about the individual blocks on those pages and note that there is a product list template for these pages:

#19
#20
#22

category_analysis.xlsx
See the 5 tabs mentioned above in this spreadsheet for the list of URLs


Combobox drop-down list is cropped by ScrollableArea bounds

The ScrollableArea restricts drawing operations of contained elements to its bounds. While this makes sense, I believe that there should be an exception for combobox dropdown lists and maybe other (temporary) elements. See this example:

Linking to #1627 + #844


Stop using Clowder config for Kafka SSL security protocol

Secure Coding Practices Checklist Link

https://github.com/RedHatInsights/secure-coding-checklist

Secure Coding Checklist

[ ] Input Validation
[ ] Output Encoding
[ ] Authentication and Password Management
[ ] Session Management
[ ] Access Control
[ ] Cryptographic Practices
[ ] Error Handling and Logging
[ ] Data Protection
[ ] Communication Security
[ ] System Configuration
[ ] Database Security
[ ] File Management
[ ] Memory Management
[ ] General Coding Practices

Codecov Report

Merging #217 (70f0790) into master (209c0c9) will increase coverage by 24.10%.
The diff coverage is 68.73%.

@@             Coverage Diff             @@
##           master     #217       +/-   ##
===========================================
+ Coverage   50.14%   74.24%   +24.10%
===========================================
  Files          13       23       +10
  Lines         357      695      +338
===========================================
+ Hits          179      516      +337
- Misses        178      179        +1

Impacted Files
Coverage Δ

clean_expired_records.py
0.00% <0.00%> (ø)

historical_system_profiles/mgmt_views/v0.py
100.00% <ø> (ø)

kafka_listener.py
0.00% <0.00%> (ø)

standalone_flask_server.py
0.00% <ø> (ø)

wsgi.py
0.00% <ø> (ø)

..._system_profiles/notification_service_interface.py
35.00% <35.00%> (ø)

...ical_system_profiles/baseline_service_interface.py
39.13% <39.13%> (ø)

historical_system_profiles/archiver.py
56.62% <56.45%> (+56.62%)
:arrow_up:

historical_system_profiles/config.py
73.68% <66.66%> (-20.26%)
:arrow_down:

...torical_system_profiles/drift_service_interface.py
66.66% <66.66%> (ø)

... and 29 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1c1b2ee...70f0790. Read the comment docs.


SOC calculation for Li-ion models

Summary
The SOC is an important parameter and can also feature in calculating other constitutive relations such as dU/dT. A function is required which could even be used to initialize concentrations given the cell dimensions and capacity
Additional context
The issue will also require implementing an r_average unary_operator. This is apparently tricky to do in a general way for SPM(e) and DFN

rad = pybamm.SpatialVariable("r", [self.domain.lower() + " particle"])
c_s_r_av = pybamm.Integral(pybamm.x_average(c_s), rad)

works

@tinosulzer @ferranbrosa @Scottmar93 @rtimms @martinjrobins : question and discussion on the SOC calculation. Assuming that the anode capacity is essentially limitless compared with the cathode the SOC of the battery is determined by the maximum and minimum level of lithiation in the cathode. A typical plot can be seen here for NMC 811 in figure 2 https://pubs.acs.org/doi/pdf/10.1021/acs.chemmater.9b00140
which has x-axis shown in Capacity and also "x" in Li_(1-x)Ni_(0.8)Mn_(0.1)Co_(0.1)O_2 where "x" is the extent of lithiation.
The theoretical minimum and maximum extent of lithiation fraction is between 0 and 1 but there are practical limits determined by setting an allowable voltage range which means that the SOC is usually measured and normalized over a restricted range. So should we actually be specifying the chemistry and initial average extent of lithiation and allowable range perhaps as the initial conditions as opposed to the concentrations. Setting the maximum concentration is a little trickier in some senses because how do you define your volume over which you are taking the average. Is it a pure crystalline primary particle? Is it an aglomerate secondary particles with interstitial space? Is it a volume averaged number including a battery level porosity. The x is in some ways easier to deal with and also less ambiguous in my view. What are your thoughts? This is also kind of a crucial concept for how to define SOC and also how to interpret experimental data that has been collected vs. SOC such as the entropic data

On this point the key advantage of the 811 chemistry over 111 is the stability for a lower extent of lithiation which increases energy density as more of the theroetical maximum can be practically cycled so it's a very important material characteristic

My understanding of the SOC is the following. I would like to discuss two main points: what do we understand as SOC and the range in which is defined.
First, we should distinguish between the SOC of the battery and the SOC of the electrodes. The SOC of the electrodes (i.e. how much lithiated they are) is the one we need to evaluate the OCP or the dU/dT, while the SOC of the battery seems to be more an application indicator and not of much interest from the modelling point of view. However, notice that both the OCP and the dU/dT depend on the concentration at the interface, therefore it is not actually an SOC because the value depends on the dynamics and it can't be obtained just from Coulomb counting. For example, when you switch the battery off and observe relaxation, that is due to a variation in the OCP, but the SOC has not changed as there is no current applied. Therefore, we should be careful about what we define as SOC and decide if we refer to how much lithium is there in the electrode or the surface concentration (which could be normalised between 0 and 1).
About the range in which the SOC is defined, the experimentalists told me that they define SOC 0 and SOC 1 from the potentials. For example, for the cathode, they define SOC 1 to be 4.2 V and SOC 0 to be 3V (just made up the example so the values are most likely wrong). It does not mean that SOC 0 implies that there is no lithium in the electrode, as for some chemistries you must leave a certain amount of lithium in the electrode, otherwise, the structure is not stable and collapses. However, we can shift the origin of concentration and the equations remain invariant. Butler-Volmer changes, but given that the exchange current must be zero at SOC 0 and SOC 1, the definition is consistent. Therefore we can think of the lithium concentration in the electrodes as "active lithium" (or whatever name you prefer, not sure people have agreed on that) and we can neglect the fraction of lithium that remains in the electrode.
Let me know if it makes sense. I am not sure if all this is obvious and well understood in the modelling community and I am just reinventing the wheel, or if there is some clarification to be made and which could lead to some model review paper. In any case, I am happy to have further discussions about the topic.

Hi @ferranbrosa you make some very nice points. The relaxation especially is interesting from a modelling point of view too and I guess can be thought of as a redistribution of quickly accessible charge even though the average value is not changing. My understanding on the conventions in the modelling and experimental community about these definitions is certainly not great. And from a model validation point of view seems quite important. It's not a sexy thing to be working on (or reviewing) but quite useful in my view. Perhaps actually Greg and Emma have some input on this so we could formulate an email for them to verify

while the SOC of the battery seems to be more an application indicator and not of much interest from the modelling point of view

My understanding on the conventions in the modelling and experimental community about these definitions is certainly not great. And from a model validation point of view seems quite important.

I agree with both these points. Definitions of SOC in different modelling papers seem to vary (particular whether it is just defined as c/c_max or normalized. Would be nice to know if the experimental/parameteristaion people in Faraday have a standard for this (and other parameter names/definitions), particularly if we are wanting to link in to an experimental database at some point.


[docs update] workaround for operating on global endpoints with knife exec

Knife exec uses the chef_server_url from knife.rb.
If changes need to be made to any global end points like user or user keys,
chef_server_url needs to be updated to https://hostname instead of http://hostname/organizations/orgname/
or a flag for --chef_server_url http:// should be included in the command line.
eg: knife exec -E 'api.delete("/users/myuser/keys/user33")' --server-url https://
Also make note: in case of user keys default key cannot be deleted by anyone other than the admin user.

chef-workstation PR - https://github.com/chef/chef-workstation/pull/1781


Fix corner cases of handling of Common Name fallback encoding

Problem:

Appearance of an empty Mpid:/Mvid: without value in a DAC/PAI/PAA DN was deemed OK by previous code, but this caused a critical ambiguity in PAIs which would possibly cause fall-back to non-PID-scoped PAI interpretation.
Related to https://github.com/CHIP-Specifications/connectedhomeip-spec/issues/7470
Fixes #28898

This PR:

Replaces the logic for fallback encoding conversion to take the first legitimate fully matching case for Mvid: and Mpid: and detect errors where either of these is present but without a following Mpid/Mvid.
Updates unit tests to improve coverage and to properly mark as invalid some cases marked invalid in spec which where deemed valid by prior code by mistake

Testing done:

Integration tests still pass (related to Commissioner DUT).
Test vectors updated.
New unit tests added.

This is an auto-commit for an old SVE branch (probably due to label). Should not be done (branch not used anymore)


Update Pages “HowLongDoesItTakePage”

Automatically generated by Netlify CMS

👷 Deploy Preview for chic-shortbread-66a66b processing.

Name
Link

🔨 Latest commit
1e6dbdb80575205edfd4149072fa8cce3c79acdd

🔍 Latest deploy log
https://app.netlify.com/sites/chic-shortbread-66a66b/deploys/656e9cbaf38b75000875ff99


Insert trigger creation [1/n]

test plan: added a unit test for createInsertTrigger
To follow up (in a later pr) with unit tests for each helper function that generates parts of the query string.

test plan: added a unit test for createInsertTrigger
To follow up (in a later pr) with unit tests for each helper function that generates parts of the query string.

fixes made in later commits.


Fixes an issue with S3 notifications

Signed-off-by: Michael Duffy<EMAIL_ADDRESS>
Description of your changes
This PR fixes an issue where SNS notifications cannot be added to S3 buckets using topicRef names. Currently, the topicRef attempts to find a SNSTopic object from the deprecated notification.aws.crossplane.io API group. This PR changes it to use the correct SNS API group.

I have:

[ x] Read and followed Crossplane's contribution process.
[ x] Run make reviewable test to ensure this PR is ready for review.

How has this code been tested
N/A

@muvaf can we merge it ? How do you feel about it because of deprecation of notification?

With this change, existing resources using SNS notification will not be affected as long as resolution policy is set to IfNotPresent. New resources, however, will not have references to the SNS topic resource. So composition for that will need to be updated.
Looks like SNSTopic was marked deprecated 8 months ago. Is there a timeline for removing this api group?

i am fine to say in v0.33.0 to make this change and remove the old apiGroup - depends on the others =)

we will remove with provider release v0.33.0 at Oct 19, 2022 the depcrecated notification APIGroup - and will merge this PR  !!!
https://github.com/crossplane-contrib/provider-aws/issues/1502


Redirect_After... setting overwritten

Description of bug
First observe PortalSettings values for Reirect_After... (Login, Logout, Registration) in SSMS
In my initial case these had values of -1
Steps to reproduce
Go to Site Settings > Site Behavior
Change the page for "404 Error Page" to any page - "404 Error Page" in my case. In my case the initial value was  None Specified
Click Save
Refresh SSMS query. The values for the 3 Redirect_After... fields will have changed to 0
Current behavior
Any value in Redirect_After... is overwritten by 0
The stored procedure UpdatePortalSettings is executed once for each Redirect_After  (Login, Logout and Registration) but passes in 0 as the value rather than the correct original value.
exec sp_executesql N';Exec dbo.UpdatePortalSetting @0, @1, @2, @3, @4, @5',N'@0 int,@1 nvarchar(4000),@2 nvarchar(4000),@3 int,@4 nvarchar(4000),@5 int',
@0=0,@1=N'Redirect_AfterLogin',@2=N'0',@3=1,@4=N'en-IE',@5=0
exec sp_executesql N';Exec dbo.UpdatePortalSetting @0, @1, @2, @3, @4, @5',N'@0 int,@1 nvarchar(4000),@2 nvarchar(4000),@3 int,@4 nvarchar(4000),@5 int',
@0=0,@1=N'Redirect_AfterLogout',@2=N'0',@3=1,@4=N'en-IE',@5=0
exec sp_executesql N';Exec dbo.UpdatePortalSetting @0, @1, @2, @3, @4, @5',N'@0 int,@1 nvarchar(4000),@2 nvarchar(4000),@3 int,@4 nvarchar(4000),@5 int',
@0=0,@1=N'Redirect_AfterRegistration',@2=N'0',@3=1,@4=N'en-IE',@5=0
Expected behavior
Unless the value is changed by the user it should not be overwritten with 0
UpdatePortal in SiteSettings.ascx.cs does not appear to populate the existing values for the three Redirect_After fields.
Screenshots
N/A
Error information
N/A
Additional context
N/A
Affected version

[ ] 10.00.00 alpha build
[X ] 09.09.00 latest supported release

Affected browser

[ ] Chrome
[X] Firefox
[ ] Safari
[ ] Internet Explorer 11
[ ] Microsoft Edge (Classic)
[ ] Microsoft Edge Chromium

is it an issue of the stored procedure itself or the DNN code calling it?

To reproduce this issue right out-of-the-box, install as new DNN instance.  Add a new page and add an account login module to it.  In the Site Settings change the login page to the new page without changing any other settings and update. Run SQL query select * from PortalSettings where SettingName like '%redirect%'.  All 3 default redirect settings now have a value of "0".   The value is from the persona bar PagePicker used by the SiteSettings view.  The TabID of a page is always returned correctly if a specific page is/was selected for any of these settings.  However, if "" (the default) is selected and the PagePicker is never opened (i.e. the list of pages never loads), the value returned to the SiteSettingsController is 0 instead of -1.
A quick work around to this is open the PagePicker for each settings and manually select "" for each redirect setting.  The null integer is stored instead of "0".

I think this is the same issue as #4578.


Runtime error:  DLLNotFoundException: kernel32

Description
I'm getting the following error when running a sample program on CentOS 7:
Unhandled Exception:  System.DllNotFoundException: kernel32
at (wrapper managed-to-native) Confluent.Kafka.Impl.LibRdKafka+WindowsNative:LoadLibraryEx (string,intptr,Confluent.Kafka.Impl.LibRdKafka/WindowsNative/LoadLibraryFlags)
at Confluent.Kafka.Impl.LibRdKafka.Initialize (System.String userSpecifiedPath) [0x000b6] in :0
at Confluent.Kafka.Consumer..ctor (System.Collections.Generic.IEnumerable1[T] config) [0x0000c] in <f8eec87f7e1a4d588a368976ab219188>:0   at Confluent.Kafka.Consumer2[TKey,TValue]..ctor (System.Collections.Generic.IEnumerable1[T] config, Confluent.Kafka.Serialization.IDeserializer1[T] keyDeserializer, Confluent.Kafka.Serialization.IDeserializer`1[T] valueDeserializer) [0x0013f] in :0
This is using the librdkafka.so library I pulled and recompiled on CentOS.
Note that the SimpleProducer and SimpleConsumer apps. work fine when running with "dotnet run".  My app. I can't run using "dotnet run" because my app. needs to be installed as a Spark process using Mobius, which requires running via:  sparkclr-submit.sh.
Any ideas please let me know.  Thanks for your time.

Good morning @mhowlett ,
do you perhaps have any thoughts on the PR?
Best regards,
Nikolaos

sorry @ngeor - it's a little bit down in the queue. e.g. I'm going to get #431 in first. I did take a quick look and saw it's a couple of hundred lines of changes (though they may be simple, I didn't think about it) which meant I postponed looking at it further. Since this is a pretty critical part of the code I need to consider it / test it very carefully.

Thank you @mhowlett of course it totally makes sense. Just a heads up, the reason so many lines seem to have changed is that I grouped some code into smaller methods. But I totally get that it needs time. Thank you for response and let me know if you have any questions.

continued in in #418 (PR for this)


General Hyperparameter Policy (Batch Size, Shard Size, Learning Rate, etc.)

Discussed in Special Topics per this document
Approved general document
Clarify shard size as shuffling and packing
Clarify where to request changes

Will update rules per doc.


lsp user mode

There is undocumented lsp user mode since last release https://github.com/ul/kak-lsp/blob/a8e7830629108aef42ccaa61bf4d651ae7e54220/rc/lsp.kak#L475
I'd like to ask feedback on those keybinding before I put them into README because I don't want to change them much after that, only extend.
How sensible do they look for you, taking in account that more commands corresponding to LSP requests will be added in feature, so should we reserve any of the letters for more important stuff?

lsp-highlight-references is missing, suggest add it as well, for example:
map global lsp <&> ': lsp-highlight-references<ret>' -docstring 'lsp-highlight-references'


Add Async API generation and deploying docs

Purpose

$subject

Security checks

Followed secure coding standards in http://wso2.com/technical-reports/wso2-secure-engineering-guidelines? yes
Ran FindSecurityBugs plugin and verified report? yes
Confirmed that this PR doesn't commit any keys, passwords, tokens, usernames, or other secrets? yes

Content is added in https://github.com/wso2/docs-apim/pull/3330


The place of items in the enterance.

When you maximise the interance window، the items will be misplaced.

Hi,
Could you please give some more info about the problem? Which window?
Cheers
Antti

The first window، where you choose the company and fiscal year .

Sorry, I posted it in incorrect repo.


changes also made for story.tsx

fixing #110

Duplicate PR for same issue, closing it.
Please make the changes in previously opened PR.


Feature Request: Prevent removal of filled bottles until all ingredients are brewed.

Technically a dup of #438 , but as the proposed 'fix' isn't a fix, and it was closed without feedback from the OP, have to open a new issue.
I have the same issue with connecting my brewer with Refined Storage, and as was mentioned there, simply whitelisting the desired potion is not desireable.  Otherwise, one will have to make an individual Crafter (to send brewing ingredients to the machine), Writer (to apply power), 2 Exporters (one to add water and one to add bottles), an Importer (whitelisted to the exact potion you want), -and- the potion brewer.
What would the possibility be of setting up so the three bottles are locked in the 'output' buffer until the fifth crafting stage is completed.  Doing that would allow all recipes to craft as intended with only a small delay for recipies with fewer steps?  Otherwise I have to manually collect bottles everytime as I can't safely use the output

:wave: Sorry but Industrial Foregoing has ended support for version 1.12. I'm closing this issue as it will no longer be updated for that version. Thanks for playing with the mod.


paymentOption is undefined returning from presentPaymentSheet

Describe the bug
After user has successfully filled in information to the payment sheet and no error is returned the payment option is still undefined.
To Reproduce
Steps to reproduce the behavior:

Using versions "@stripe/stripe-react-native": "^0.18.1", and "react-native": "0.69.1".
Init payment sheet in test mode.
Fill in test card to sheet
No payment option is returned

Expected behavior
Payment option should be defined so I can give a visual confirmation to the customer
Smartphone (please complete the following information):

Device: OnePlus 9
OS: android 12

Additional context
As mentioned before this in test mode with a test card. Is this the reason why? It seems it should still work but not sure.

I am expected to be able to get the payment details correct?

Hi! This works in our example app code so please provide the code you're using so we can reproduce the issue. See our example code for this here: https://github.com/stripe/stripe-react-native/blob/master/example/src/screens/PaymentsUICustomScreen.tsx#L61

@tonyneel we chatted on discord earlier... I forgot that paymentOption is only returned when customFlow is set true. Otherwise it is expected to be undefined. As we discussed, fetching the payment mehtod details from your server will be the way to go.

Closing this issue- to get the paymentOption, you'll need to use customFlow as @bensnell-stripe mentioned above. Otherwise, presentPaymentSheet doesn't return the payment option. If you have a use case for that though, let me know!

Thanks for the help again @bensnell-stripe ! I am good with this being closed thanks for the clarification. One action item could be to update the typing for paymentOption to be not required then it would have caused less confusion for me.

Great point @tonyneel ! I'll correct that in the types

@charliecruzan-stripe we're using customFlow: true with a SetupIntent instead of a PaymentIntent, and after a successful card entry (the 4242 card in the dev environment), I'm getting undefined for the PaymentOption.  Is that expected?


Independently download BreakSeq, Breakdancer, Pindel, CNVnator

Hi team,
Does metaSV support the four SV callers, or do I have to install those and run them separately?
Thanks,
Madeline
(Bioinformagician)

Hi Madeine
You will need to install and run the SV callers separately. MetaSV can then be invoked on the output of the SV callers run to get a set of much better quality calls.
Hope that helps.


Feature Request: Clear function instead of loop and clone

Yesterday i came across this issue and i wanted to clear my collection and the only way around is to loop through the clone of my collection and delete objects from the original one.
var self = this;
_.each(_.clone(this.channels.models), function(item) { self.channels.remove(item); });

I am suggesting that it can be a standalone function.
Thanks in advance and keep rockin.

@aseroj I think this issue should be filed in the Backbone repository.
Good luck!


UITextDisplayer isn't updating the vertical position for subtitles with line breaks

Have you read the FAQ and checked for duplicate open issues?
Yes
What version of Shaka Player are you using?
4.1.0
Can you reproduce the issue with our latest release version?
Yes
Can you reproduce the issue with the latest code from main?
Have not tried
Are you using the demo app or your own custom app?
Custom
If custom app, can you reproduce the issue using our demo app?
Have not tried
What browser and OS are you using?
Castlabs ECS version of Electron v10.4.7 on Windows
What configuration are you using?  What is the output of player.getConfiguration()?
config.textDisplayFactory = () => new shaka.text.UITextDisplayer(document.getElementById("shaka-video-element"), videoContainerRef.current)
(Except that I'm actually creating my own displayer that calls down to UITextDisplayer.  This is so I can hack the cues in the append function.)
What are the manifest and license server URIs?
See the attached manifest and the VTT for the relevant segment.
What did you do?
Watched the Eternals on Disney+.
What did you expect to happen?
I expected the subtitles to be drawn on-screen.  Here's what I see using the default subtitles (that is, not specifying a textDisplayFactor in config ).

What actually happened?
For titles with an embedded newline, the second line is cut off.  Like this:

All the titles in this film have a line value of 95.  It appears that the default text displayer adjusts that when the cue payload has newlines in it.
I'm hacking around this by counting the number of newlines in the cur and doing cue.line -= 8 * newlineCount.  Note that I'm also doing cue.lineAlign = "start" to get around a different bug.
manifest.mpd.txt
seg_00018.vtt.txt

I think this may not be a Shaka Player issue after all.  I looked at "Star Trek: Strange New Worlds" on Paramount+ and it has different values for line when there are line breaks in the text.  But "The Eternals" on Disney+ is using the same value for all lines.  So I think that the Disney+ web player is adjusting for this in a non-standard way.
If this is the case, then it's probably best if I continue using my hack and applying it only to Disney+.

Okay.  If you think it's not a Shaka issue, we can close it.  If you need to open this issue again before it expires and gets locked, just put @shaka-bot reopen in a comment.  Thanks!

Clarification:  It was my bashing the lineAlign value that was causing this problem.  So I believe that https://github.com/shaka-project/shaka-player/issues/4247 is still an issue, but this item is completely bogus.  Sorry about that.


Can add method to change the MAX_FIXED_TAB_COUNT?

public class BottomBar extends FrameLayout implements View.OnClickListener, View.OnLongClickListener {
private static final long ANIMATION_DURATION = 150;
private static final int MAX_FIXED_TAB_COUNT = 3;
....
I want to change MAX_FIXED_TAB_COUNT to 4.
Can add new method, please?
Thank you!

Could be done in the future. I'm first focusing on implementing the Material Design spec correctly.

Already done, will be in tomorrow's version.

Thanks.

@roughike How do I get the latest version through gradle?  Do I need to update version number?

Yes, update the version number to 1.3.2.
mBottomBar.setMaxFixedTabs(3);


More things need to be added and some bugs must be solved, thanks.

Firstly, I personally love your job you did like it was so good but there's an issue you need to solve like sometimes when I load the lyrics it won't load but like in the CMD it writes like something but when I closed the app and opened it again I got the lyrics for the same song and also about the lyrics like make an option where the user can enter his own lyrics rather than loading it from internet add other things too like most played and add tracks tab there's for everything a tab except tracks/songs but personally you did good job and I apperciate it, thanks.

Hi @aahmedashrafmohamed
Thank you for using Swing Music. I appreciate that you like my work. I'll take a look at the error you have shared. We shall have the requested in the future. I work on this project by myself so it's slow putting out new features and bug fixes.
Thanks.


Ignoring path errors and overlay video recording

Today I ran into a problem when there was no external drive, and the video was recorded in the camera overlay.
When repeating the problem I found that the type of media does not matter, USB Flash or SD card is connected.
root@openipc-gk7205v300:~# cat /tmp/maj2.log

2023-06-19 21:04:11 INFO  main:125: Majestic Ultimate for HiSilicon, version master+9b9e089f, built on 2023-06-13
2023-06-19 21:04:11 INFO  app_config:89: Using /etc/majestic.yaml as main configuration
2023-06-19 21:04:11 ERROR tools:452: statfs for /mnt/sda1/records/ is No such file or directory
2023-06-19 21:04:11 DEBUG watchdog:101: Detected Watchdog
2023-06-19 21:04:11 DEBUG watchdog:121: Watchdog timeout set to 10 seconds
2023-06-19 21:04:11 INFO  sdk:415: Using /etc/sensors/imx335_i2c_4M.ini sensor configuration file
2023-06-19 21:04:11 WARN  sensor_config:938: Set custom sensor clock mode: 27MHz
2023-06-19 21:04:11 INFO  puts:0: linear mode
2023-06-19 21:04:11 INFO  puts:0: binit false IMX335 i2c init
2023-06-19 21:04:11 INFO  puts:0: -------Sony IMX335_init_5M_2592x1944_12bit_linear30 Initial OK!-------
2023-06-19 21:04:11 INFO  sdk:344: Loading IQ profile /etc/sensors/iq/default.ini
2023-06-19 21:04:11 INFO  httpd:368: HTTP server started on :::80
2023-06-19 21:04:11 INFO  rtsp:31: RTSP server started on port 554
2023-06-19 21:04:15 INFO  main:209: Shutdown main thread

root@openipc-gk7205v300:~# ls /mnt/sda1/records/2023/06/19/*

/mnt/sda1/records/2023/06/19/21.mp4

Fixed


Set the name of the Advanced Abilities after saving

To save the enhancements, the Advanced Ability deck is searched by name. Every card from the deck is drawn and thus the deck is destroyed.  So after saving the enhancements and merging the abilities, the deck has to be named correctly again.

Is the Advanced Ability deck search even necessary?  The only case in which I'd expect an enhanced card to be in this deck is if someone enhanced a character, retired, and then someone else is playing that character, but hasn't yet purchased the enhanced card.
I don't know how difficult the procedure is to "name the deck again" but an alternative may be to process half the deck, returning the cards, then processing the other half.  That way the deck never becomes empty.

Also, may be possible to Save without drawing all the cards?   lua log(getObjectFromGUID('2264ab').getJSON()) appears to be returning information about each card which includes "AttachedDecals".

Yeah, it's definitively a rare case and currently only possible through manual work. As you would carry over the enhancement information from a save file from a retired character to a new save file by hand, when the class is used again. However I still think this should work if done manually.
Naming the deck again shouldn't be that hard I guess, I'm thinking of a wait condition, that uses a cast at the deck position until an object is hit, that has the Deck tag and then sets its names. Maybe the performance is very poor than (as the doc suggest using cast very rarely). Doing the process for half the deck sound like a good plan for that! This would also get rid of the special case, where there's only one card left in the deck and you have to use the remainder card. Always a good thing to have less special cases. :-)
The use of the JSON also sounds promising. I hate that you have to draw cards from the deck to get their actual objects, so this might be a very good way to get the information without doing it.

The function getData() was the way to go. It returns the information from getJSON() but already converts them into Lua tables. I wrapped that into a DeckUtil module, so that you can use the returned objects like other objects (e.g. using getName() or getPosition().


Reduce cpu usage

Hello,
i'm planing on using three webcams on a raspberry pi, but noticed that even when reducing the framerate to "1", the cpu usage is very high (>100%) even for only one webcam.
Is there anyway to reduce the cpu usage? Thanks in advance.
Kevin

@kkettinger CPU usage should not be > 100%.
We did have a memory leak issue in an older version, but that was resolved.

Which version of the project are you using?

Hello @vladimirvivien,
i'm using go version go1.20.1 linux/arm and the simplecam example (g018089c) on a raspberry pi 4. The go.mod uses version v0.0.5.
$ ps -p 2388 -o %cpu,%mem,cmd
%CPU %MEM CMD
 135  0.2 ./simplecam

$ uname -a
Linux rpidev 5.15.84-v7l+ #1613 SMP Thu Jan 5 12:01:26 GMT 2023 armv7l GNU/Linux
$ lsb_release -a
No LSB modules are available.
Distributor ID: Raspbian
Description:    Raspbian GNU/Linux 11 (bullseye)
Release:        11
Codename:       bullseye

Thans @kkettinger
Apologies for the late reply.
Although I don't have a Pi 4 readily available (price still about $145 to get one 😭 )
I will run on Pi 3 to see if I can reproduce that same behavior.

@vladimirvivien No worries :)
Yes, if i had a spare i could sent it to you, but the one i have is currently in use in a project. It's a bummer that they are so pricey nowadays!

Hi @vladimirvivien
Could you reproduce the behaviour?

@kkettinger finally has time to resume looking into this (and was able to find a rpi4 this summer).


Shaman issues

When a mob is in camp I get this spam:

These are checked in Skills tab:

Seems similar to what the cleric is doing...

is your shaman casting something it shouldn't or not casting something it should? i wouldn't recommend turning on debug spam, it is spammy.

Shaman is casting sloth on toons as needed, that's it.  Will heal no problem.  No clue why it's spamming the

constantly.

When I turn on slow and cripple mobs it's also using a lower level slow.  The best one is 'Balance of Discord' right now.
It also spams this constantly with slow and cripple turned on:

its just spamming because you turned on the ability validation spam

Oh i know that, that's not the complaint ).  Why does it search for those spells when balance and cripple are memmed but it doesn't cast it on any mobs?


README: Update package list

What changed?
Updated the structure of the main README (view the new version →), to make it a bit easier to scan. (This can be totally opinionated, so it's more like a conversation starter.)

Before
After

I personally prefer the table as I think it looks tidier and the buttons aren't between the name and description which is jarring to read.
I think referring to the packages by their npm name is a nice addition as is updating the descriptions.

Those are good inputs - just to make sure I understand correctly what you are suggesting is to go back to the table view, but use the names of the packages (e.g. @grafana/plugin-e2e) and also go with the updated descriptions, right? (How do you feel about getting rid of the readme column, and turning the package names into a link?)

Okie dokie, I'll revive them :)


Allow external rollup plugins to be applied

Unbuild provides outstanding defaults for Rollup, and it is highly developer-friendly, but it gets complicated when it comes to a small external change in Rollup. Currently, you would have to hook into the build cycle through an external script and run that script instead of just applying a simple plugin for rollup.
It's a nice feature to provide plugins for Rollup because some codebases require plugins to run other frameworks and extend the ability to transform the code.
Suggested change:
export default {
    entries: [...],
    plugins: [
        myPlugin({})
    ]
}

Sorry, I missed the hooks option in the build options, though it would be more challenging. Great design!


VEP: fixed typo

added missing comma in the VEP args list

Matthias -- thanks much for the fixes.


WIP: Use compile to string instead of making temp files

@unindented I'm not making too much sense of this error. Any ideas?

It could be that the code is throwing an exception, and that's why test.done() is not getting called in the test. Have you tried debugging with node-debug node_modules/.bin/nodeunit test/loader.js?

I've seen this locally too. Once this happened I just  deleted node modules and the elm stuff and then it worked again.

Tried both of those and still not sure. Might hold fire on this PR until new testing is in?

All good - found the problem. Will merge once passing.


Image needs to be rebuild to pickup compiler changes

Using the current container against the latest cheriot-rtos fails with:
   error: ../cheriot-rtos/sdk/lib/unwind_error_handler/unwind.S:7:2: error: unrecognized instruction mnemonic cgettop t0, csp

Rebuilding a local copy of the container works fine, so this just needs a new image to be created and published

Opened in error


Ownership title earned?

Summary

Motivation

Describe alternatives you've considered

Additional context

Thank you for contributing!
We require the issue template to be filled out on all new issues and pull requests. We do this so that we can be certain we have all the information we need to address your submission efficiently. This allows the maintainers to spend more time fixing bugs, implementing enhancements, and reviewing and merging pull requests. Please open a new issue and fill out the template for us.
Thanks for understanding and meeting us half way :grinning:


Kind equality and kind casting

In the context of: https://github.com/samuelhklumpers/strong-vector/blob/6b261d7425c80670a13d74e864bcad4c4ace9154/src/Vectors.hs#L113
Dependent type families seem possible, but not without issues.
For example, writing the instance
    Get (x ': ys) ('InF _) = x
results in Illegal type synonym family application ‘Length @k ys’ when the polymorphic variables for 'InF are inferred, since type families inside type applications seem to be unsupported.
This is remedied by deferring the pattern matching to a location where the polymorphic variable is simpler, e.g. via
https://github.com/samuelhklumpers/strong-vector/blob/6b261d7425c80670a13d74e864bcad4c4ace9154/src/Vectors.hs#L109
However, the lacking support for type equality resolution in type families complicates composition of operations.
 However for any xs, i and x we have Length (Put xs i x) :~: Length xs.
Yet we have no way of applying this knowledge on the type family level.
This may be worked around (with significant effort) by introducing "type isomorphism families",
which constructively transport values between "morally equal types".
For example
type family LiftPut (xs :: [k]) (i :: F (Length xs)) (x :: k) (j :: F (Length xs)) :: F (Length (Put xs i x)) where
    LiftPut (x ': xs) i x' j = ITE (IsInF j) (InF '()) (UpF '( '(), LiftPut xs (DownF i) x' (DownF j)))

However, we then also need to lift isomorphisms for Ok ... and so on...

Update: https://github.com/samuelhklumpers/strong-vector/blob/adeaff212736b1ee655d761c94349fb96d6baa3f/src/Vectors.hs#L140-L141
fails with
• Couldn't match type ‘Put2 xs2 j i (Get xs2 i) (Get xs2 j)’
                 with ‘Put2 xs2 j i (Get xs2 i) (Get xs2 j)’


Link liboqs statically

Does liboqs-go support static linking against liboqs?
I would like to build a statically linked Go executable without external depdendencies..

Here is an example as used by go-rosenpass: https://github.com/stv0g/go-rosenpass/commit/fb93e83dbddd92b60da5feef68f5d0230d4a3684

@stv0g Thanks, I'll look into it this week

@stv0g The only way to link statically is a bit hacky. In oqs.go, immediately after the line https://github.com/open-quantum-safe/liboqs-go/blob/e3e87437a36ce5f154ad38f81b11278187c896a5/oqs/oqs.go#L6, add the line #cgo LDFLAGS: /usr/local/liboqs.a (of course with the path corresponding to your location of liboqs.a). Next, comment the last line starting with Libs: of [.config/liboqs.pc](https://github.com/open-quantum-safe/liboqs-go/blob/main/.config/liboqs.pc), i.e., https://github.com/open-quantum-safe/liboqs-go/blob/e3e87437a36ce5f154ad38f81b11278187c896a5/.config/liboqs.pc#L9. Then do a go clean -cacheto force pkg-config to use the updatedliboqs.pc`.
As far as I know, there's no elegant way of statically linking by only modifying the liboqs.pc file.

Fixed by #37


HTTPS proxy returns incompatible headers with node.js client

HTTPs proxy in capture and simulation mode returns both Content-Length and Transfer-Encoding: chunked headers. It' breaks node client (throws HPE_UNEXPECTED_CONTENT_LENGTH error).
OS: MacOS
Hoverfly version:  v0.16.0
node: v8.9.0

Looks like Hoverfly shouldn't be setting the content length or your client should be ignoring it. We'll have a closer look.

#https://github.com/SpectoLabs/hoverfly/issues/697

It's related to this issue: https://github.com/SpectoLabs/hoverfly/issues/697

I think meeting the following requirements from RFC7230 should solve the Content-Length and Transfer-Encoding issues:

"A sender MUST NOT send a Content-Length header field in any message that contains a Transfer-Encoding header field."
“In the absence of Transfer-Encoding, an origin server SHOULD send a Content-Length header field when the payload body size is known prior to sending the complete header section. “
"A server MUST NOT send a Transfer-Encoding/Content-Length header field in any
response with a status code of 1xx (Informational) or 204 (No Content).
"A server MUST NOT send a Transfer-Encoding/Content-Length header field in
any 2xx (Successful) response to a CONNECT request.”

The problem was that goproxy alwasy delete Content-Length header and set Transfer-Encoding header when handling HTTPS response for some reasons.
Hoverfly on the other hand should have different behavior. In capture mode, it should just record the original headers faithfully. In simulation mode, I can think of two scenarios need special treatments:

User does not provide Content-Length and Transfer-Encoding headers when the response has a body. This is quite common when the simulation is manually created, I think Hoverfly should add approriate header in this case.
User modified the response body but not update the Content-Length header. This could happen when middlware was used to modify response body. Hoverfly should either work out the correct Content-Length or just set chucked transfer encoding.

Hey @nordicdyno
This should now be fixed in Hoverfly v0.17.1. If this is not the case and you still experience problems, please reopen this issue so that we can discuss further.


Add Feature Layers Sample

Current Flutter sample: https://devtopia.esri.com/runtime/common-samples/blob/main/designs/AddFeatureLayers/README.md
Applied common design to Add Feature Layers sample.
The sample works as expected but doesn't have options for rendering PortalItem, GeoPackageFeatureTable, ShapefileFeatureTable layers. README file was created, few changes to API names and steps were made, comments were added, and metadata was generated.
I implemented PortalItem and GeoPackage as sources for the feature layer.

Should I implement PortalItem, GeoPackageFeatureTable, ShapefileFeatureTable layers options?

Yes please! This one will need a little more work as it was initially implemented before we had Portal available. If you run into any issues with any of those classes/data sources let us know, it's a great chance to do some testing.

@jenmerritt I added both PortalItem and GeoPackage as sources!


feat(extrapolator): add exponential extrapolators

Summary
Add MultiExponentialExtrapolator class, for ordinary-least-squares on an exponential-sum model with tunable number of terms.
Details and comments
Facades:

ExponentialExtrapolator
MonoExponentialExtrapolator
BiExponentialExtrapolator

Thanks @caleb-johnson! I have moved the theoretical discussion from the class docstring to the module docstring. I believe that improves readability, but let me know your thoughts.
Also, feel free to explore other ways of documentation. I would really appreciate some help there. There are a few notebooks in the docs already, but ultimately I would love to have autogenerated sphinx documentation from the docstrings and host it in gh-pages and read-the-docs. I have never had time to explore that, but I believe that would be a great contribution, and easy to port to other projects.
We can discuss offline if you want 😉


Add Space Invaders game

I want to add a space invader game

Ignore this 469 issue, i didn't notice . For this issue 468 is valid.


SSH connection opens root filesystem instead of directory set on remote machine

Whenever an SSH connection is opened it defaults the file browser to the root directory of the filesystem for some reason. Any attempt to change this on the server side is ineffective.

What should be the expected behaviour? How did you configure the directory on your server?

Expected behavior should be going to the user folder (home directory, in my case /Users/$USER)
On the server I set an action in .zshrc to change directory on a new session, but in retrospect I’m not sure that would have worked anyway
It’s only an issue as it forces the user to navigate from the root of the filesystem all the way to where they want to go; it could be a setting, with a default to ~

Can you try this?
https://support.termius.com/hc/en-us/articles/4403215978393-How-do-I-set-a-default-SFTP-path-

This is indeed a bug. Code App is ignoring the remote working directory.
Fix: In SFTPFileSystemProvider.swift, we should call libssh2_sftp_realpath with . in libssh2 to obtain the working directory and set it as homePath.

The changes I made in NMSSH: https://github.com/thebaselab/NMSSH/commit/2d800fca5d2da49baff1cbc061b275e33df70731

This should work universally on different platforms as it is how the FreeBSD sftp command pwd works:
https://github.com/freebsd/freebsd-src/blob/6b635c74fd4135eaae68970bfc5aad9ae905fec7/crypto/openssh/sftp.c#L2237

Did the changes make it to 1.4.7 or is it still to be released?

It's processing and will be available on TestFlight soon.

Because of #943, resolving home path is now an configurable option and is off by default.


eslint: Specify Jest version in config.

This fixes a problem where format-on-save had stopped working for
me, probably after updating vscode-eslint. I'd been getting this
error:
Error: Error while loading rule 'jest/no-deprecated-functions':
  Unable to detect Jest version - please ensure jest package is
  installed, or otherwise set version explicitly

Occurred while linting
  /Users/chrisbobbe/dev/zulip-mobile/src/compose/ComposeMenu.js

	at detectJestVersion
	  (/Users/chrisbobbe/dev/zulip-mobile/node_modules/eslint-plugin-jest/lib/rules/no-deprecated-functions.js:38:9)

	at create
	  (/Users/chrisbobbe/dev/zulip-mobile/node_modules/eslint-plugin-jest/lib/rules/no-deprecated-functions.js:61:256)

	[...]

Now I don't get that error, and format-on-save works again.
See these issues:

jest-community/eslint-plugin-jest#686
microsoft/vscode-eslint#1145

Hmm, from the CI failure, looks like this isn't quite the way this should be done. I'll take another look soon.

Thanks! I've been seeing the same symptom -- glad to have that fixed. Merged, with a tiny formatting tweak to add a blank line above the start of that jest: stanza.
Where did you see that error message? I'm not finding an error message anywhere, even when I'm on the commit before this fix, and hit save, and it doesn't auto-format.

Where did you see that error message?

If I click on "Prettier" in the bar at the bottom of VSCode, toward the right:


dear sir,we need a windows version (as windows home )

RDP

@introspection3 - it's not clear what you're asking for here, or what use-case you're trying to satisfy. Can you be more specific please?

@matt335672 sir,windows home version can't use mstsc,but if
xrdp support running on windows,it will be very good

If you're trying to replace mstsc, this isn't the right product for you. This is an RDP server, so it's emulating what a Windows server would do, not mstsc.
Have a look at MobaXterm which offers an RDP client capability.

I think what's he saying is that the RDP SERVER is not enabled on Windows 10 Home, it's only enabled by Microsoft on the professional SKU.
So his point is that for non-professional SKUs of Windows, enabling RDP for that would be a win (and perhaps an easy way to increase adoption of the system).
I have heard that long ago XRDP used to work on WIndows, but I'm not sure if it does now. I'm not even sure if we have a way to access the Windows graphics stack to enable such a thing...
But I do agree it would be a cool thing to support.

I agree it would be cool technically but I don't think we have the Windows knowledge to do this in the team. I certainly don't!
There's also the potential user community to consider. The directions for the main project are driven mainly by the interests of the power users and enterprise users. I don't think they would be interested in this functionality at all. Nor will users of this functionality want to use the main product.
So although there's functional overlap between the two use-cases, I don't think there's any market overlap. This looks to me like a separate project with a different target audience and different development skills.
A little web searching led me to rdpwrap which seems like a saner way to proceed f you're interested in using Windows Home in this way. To be clear I'm not endorsing this project at all. It's not clear to me whether using it would be a violation of Windows licensing, and that may depend on your juristiction.

Closing this for now.


feat: Notion to DevTo feature

Changes made
Added the logic for posting notion blogs to DevTo and then updating it every sec with ISR
Issues facing
type error - while hitting the routes from app

Don't use the npm run setup command if you are contributing. See the CONTRIBUTING.md

Don't use the npm run setup command if you are contributing. See the CONTRIBUTING.md

Sure will raise a new PR.


🐛 [Bug]: 树表无法删除新增行，新增不支持添加子节点

Version
latest
Vue Version
latest
Link to minimal reproduction
树表无法删除新增行，新增不支持添加子节点
相关链接: gird-tree-grid
Step to reproduce
树表无法删除新增行，新增不支持添加子节点
What is expected
No response
What is actually happening
No response
Any additional comments (optional)
No response

我来修复这个问题

Fixed by @GaoNeng-wWw on #224


FileNotFoundError: [Errno 2] No such file or directory: '/SHFP12/02_bevdet/SceneRF/kitti_odometry/dataset/sequences/00/voxels/003228.invalid'

Hi, @anhquancao
I found there is no "003228.invalid" in the the SemanticKITTI voxel data .
How can you fixed this issue?
    data = [self.dataset[idx] for idx in possibly_batched_index]
  File "/SHFP12/02_bevdet/SceneRF/scenerf/data/semantic_kitti/kitti_dataset.py", line 403, in __getitem__
    data['target_1_1'] = self.read_semKITTI_label(label_path, invalid_path)
  File "/SHFP12/02_bevdet/SceneRF/scenerf/data/semantic_kitti/kitti_dataset.py", line 413, in read_semKITTI_label
    INVALID = SemanticKittiIO._read_invalid_SemKITTI(invalid_path)
  File "/SHFP12/02_bevdet/SceneRF/scenerf/data/semantic_kitti/io_data.py", line 126, in _read_invalid_SemKITTI
    invalid = _read_SemKITTI(path, dtype=np.uint8, do_unpack=True)
  File "/SHFP12/02_bevdet/SceneRF/scenerf/data/semantic_kitti/io_data.py", line 114, in _read_SemKITTI
    bin = np.fromfile(path, dtype=dtype)  # Flattened array
FileNotFoundError: [Errno 2] No such file or directory: '/SHFP12/02_bevdet/SceneRF/kitti_odometry/dataset/sequences/00/voxels/003228.invalid'

It seem the Semantic voxel data has been updated.

Ah, thanks for pointing out this problem, you need to download the 3.3 GB data as well. I will update it in the README

Thanks!


Can´t connect to teh simulator

HI
I tried to use both the simulator and companion on the same computer but without any luck. Can you confirm this is woorking or am i doing anything wrong?
Best Regards
Niels

I can confirm that this is working. You probably are doing something wrong.
The real machine is listening on TCP/IP port 80, which is the default and doesn't need to be added to the device address.
The simulator can't listen on ports below 1024, the default is 3000.
You have to add the port to your device address like: <IP_ADDRESS>:3000.
Just enter the address exactly like you do in your browser to reach the WebRCS.


Add generic support to Element.closest()

This now matches querySelector. Allows:
element.closest<HTMLAnchorElement>('.lol')
// => HTMLAnchorElement

I have no idea of what the error means 😮

You have to run the script and include the generated files, too. You submitted only the input files.
Not sure about the error we see.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: bfred-it sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.

All good now


nbproject\project.xml hard-coded paths

In vehicle-commander\source\VehicleCommander\nbproject\project.xml :
Use a property in the classpath for the ArcGIS Runtime install location (like build.xml does)  to make it easier to change versions or between x86 and 64, 10.1.1 & 10.2.
I'm guessing this is just a Netbeans setting file so doesn't affect those using Ant/Eclipse. This is the section of project.xml in question:
        <java-data xmlns="http://www.netbeans.org/ns/freeform-project-java/1">
            <compilation-unit>
                <package-root>${project.dir}/source/VehicleCommander/src</package-root>
                <classpath mode="compile">C:\Program Files (x86)\ArcGIS SDKs\java10.1.1\sdk\jars

Backlog item - https://app.asana.com/0/23019535413946/23267996678697


update e2e job to run only when push to main

Summary

update e2e job to run only when push to main

to avoid run jobs when pushing to the upstream, like dependabot

example: https://github.com/sigstore/cosign/pull/2167

Just to confirm, this will let us run tests on other branches via a workflow_dispatch?

Just to confirm, this will let us run tests on other branches via a workflow_dispatch?

yes we can do that

Codecov Report

Merging #2169 (f72c280) into main (026523a) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #2169   +/-   ##
=======================================
  Coverage   26.26%   26.26%
=======================================
  Files         130      130
  Lines        7615     7614    -1
=======================================
  Hits         2000     2000
+ Misses       5359     5358    -1
  Partials      256      256

Impacted Files
Coverage Δ

cmd/cosign/cli/fulcio/fulcio.go
18.26% <0.00%> (+0.15%)
:arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Awesome, sounds great!


[log-parser] Add .general.whitelisted_domains[] config for PTR

*treat Issue: #86
This create a new option .general.whitelisted_domains[] : a list of PTR domains that cannot be blocked by log-parser.
example : {"general": {"errorThreshold": 50, "blockPeriod": 120, "errorCodes": ["400", "401", "403", "404", "405"], "whitelisted_domains": ["search.msn.com", "spider.yandex.com", ".googlebot.com"]}, "uriList": {}}
So chosen domains like googlebot IP ranges are not blocked if it reach some threshold
When outstanding_requesters is done before merge with existing list. reverse resolution is done on each IP address. and exclude from the object.
No need to query whois and add ranges on whitelist IP set (this could be some improuvment if load on big outstanding_requesters object is heavy).

wow :) thanks for your contribution @dhardy92
This PR will be evaluated for the next version and we'll update to this thread once we have more information.

Close the old PR as it doesn't apply to the latest version.


Drop-in cancel button not working when clicked cancel on Paypal payment method

Describe the bug
Drop-in cancel button not working when clicking on cancel test on paypal screen.
To Reproduce
Steps to reproduce the behavior:

Going to drop-in
Click on paypal payment method
Observe that paypal login screen will open
When we click cancel on paypal login screen paypal popup is closing and dropin cancel button not working

Expected behavior
Drop-in cancel button should work when coming back from any payment type or it should call any callbacks where we can handle the cancel part
Screenshots
https://github.com/Adyen/adyen-react-native/assets/42997076/9ea6ffc0-6611-4675-b4b4-928d0dabdc08
Smartphone (please complete the following information):
Device: iOS 13
OS: macOs Monterey
Platform: React Native v0.67.5 [ Both Android & iOS ]
Adyen version: @adyen/react-native : ^1.1.0
Additional context
Just Fyi configuration object is same as mentioned in adyen doc
<AdyenCheckout
config={configuration}
paymentMethods={paymentMethods}
onSubmit={(state,component) => { console.log(state,component) }}
onAdditionalDetails={(state,component) => { console.log(state,component) }}
onError={(state,component) => { console.log(state,component) }}
onComplete={(state,component) => { console.log(state,component) }}>

Hey @vijay6162
Was "cancel" button working before opening PayPal?

@vijay6162
When "cancel" clicked the callback onError expected to get triggered.
Does it happening?
Same behaviour on both iOS and Android?
After closing PayPal, can you still make a payment with card?

We recently updated docs. We recommend using useCallback from React. This will make sure that callback is not recreated, hanse not missing.
Could you check if this makes any difference ?

@descorp ,
In android it's working fine, but in iOS its not working and, I can confirm that we are using class component here since complete checkout component is written using class component
After closing payPal we are not being able to make second payment again in IOS.

@vijay6162

On selecting card payment also its working, but not incase of paypal.

Can you successfully complete PayPal flow?
Can you successfully complete a full 3DS flow (with action)?

After closing payPal we are not being able to make second payment again in IOS.

Are you using useCallback ?
This behaviour may occur if <AdyenCheckout></AdyenCheckout> element on your "Checkout" page or it's callbacks was recreated. Without useCallback re-rendering of UI may regenerate callback functions.
I see that there is a loading bar on top happening during "/payment" request. Any chance it cause re-rendering of other parts of UI?

In android it's working fine

Does the page that hosting <AdyenCheckout></AdyenCheckout> have different behaviour on iOS and Android?

Hey @descorp ,
I cannot complete 3DS flow and Paypal flow since my onAdditonalSubmit is not being triggered.
Yes im using useCallback for Dropin function
const onPaymentSubmit = useCallback(
(resp, component) => {
onAdyenPaymentSubmit(resp, component);
},
[configuration],
);
const doThirdPartyAction = useCallback(
(resp, component) => {
onAdditionalDetailsSubmit(resp, component);
},
[configuration],
);
const onErrorCallback = useCallback(
(resp, component) => {
onAdyenPaymentError(resp, component);
},
[configuration],
);
const onPaymentComplete = useCallback(
component => {
onAdyenPaymentComplete(component);
},
[configuration],
);
return (

);
The loading bar is just to display payment api is. being called.No its not causing any re-rendering.

@vijay6162

I cannot complete 3DS flow and Paypal flow since my onAdditonalSubmit is not being triggered.

This is exactly what I thought..
Could you create a blank project and recreate your "checkout" page structure so we can reproduce this issue on our side?

@vijay6162

I cannot complete 3DS flow and Paypal flow since my onAdditonalSubmit is not being triggered.

This is exactly what I thought.. Something is triggering re-generation of view tree while (or after) \payments request.

The loading bar is just to display payment api is being called.No its not causing any re-rendering.

Is this external library ? Does it work differently for iOS and Android ?
Could you create a blank project and mimic your "checkout" page structure so we can reproduce this issue on our side?

No its just a progress bar. and it works same on both android and ios.
I don't think its issue related to triggering re-generation because i have kept static response from postman and called the adyen  handle action but unable to trigger the onAdditionalSumit.
Let me create a blank project and get back to you.

Hey @vijay6162
We were trying to replicate similar behaviour locally.
In you console log, when you have this issue and click on "close Drop-In" - do you see warning like:
 WARN  Sending `didFailCallback` with no listeners registered.

Hey @vijay6162
Were you able to resolve this?


Remove restriction for zero-length strings

https://github.com/cmiles74/bencode/blob/cd9789fda47ba8c230edb0339e6d09f8b0b34dee/src/bencode.janet#L141-L142
I think this restriction can be lifted for 0 since bencode spec allows it. I will prepare a pull request if you are okay with it.
Bencode spec https://www.bittorrent.org/beps/bep_0003.html#bencoding, also some resources and implementations use zero length strings, for example https://github.com/sanel/monroe

I actually got an error trying to decode a zero-length string, so far normal eye :D I will prepare a PR


Add feedback form

@akshay2408 during the meeting, Grayson suggested adding a feedback form somewhere else so they don't only view it only after generating zones. If I am not mistaken, the circled area was proposed @gclapp1

Hi @ClaraIV @LunaAsefaw Here is the updated UI :
Is it good ?

@akshay2408 great, thanks! Once it is deployed on the staging site, I will test it and give feedback

@akshay2408 and @LunaAsefaw
Thank you for adding the feedback form on the left navigation bar. That is great placement. Would it be possible to have the pop-out bubble have the full blue color border to avoid a white box on a white background?

@ClaraIV @gclapp1 I just wanted to confirm if this feedback form is an additional feature or meant to replace the old feedback form on the right?

@LunaAsefaw this should not replace the feedback form on the right side; this is the response to @gclapp1 's suggestion to have the feedback form also visible when the tool is not ran yet.
Therefore we'll keep it in both places now


Support for casting spells on players

Contributes to #171

Hey @notjuanortiz,
Your changes look good to me!
View build log
TravisBuddy Request Identifier: 197440a0-04f1-11ea-9b49-e31b2b39913b

Hey @notjuanortiz,
Your changes look good to me!
View build log
TravisBuddy Request Identifier: 577f2ca0-0c0a-11ea-9cd6-8f216fa7db85

Sorry for the poorly written PR 🤷♂

Hey @notjuanortiz,
Your changes look good to me!
View build log
TravisBuddy Request Identifier: aee2e260-1197-11ea-b428-cb0bccf60dd8

Hey @notjuanortiz,
Something went wrong with the build.
TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.
View build log
TravisBuddy Request Identifier: e11c65d0-1197-11ea-b428-cb0bccf60dd8


Add "who are we" page

Some concerns raised on twitter that the source of this work is not clear. I will add a short who we are page. Would like to give all contributors credit - please let me know if I may post your name or handle or if you'd like to remain anonymous.
@awong-dev @ctavispost @leee @shahronak @4kbt @graemer

Fixed! @leee I didn't list you, if you want to be listed just let me know how to credit you - Name and (optional) link.

I appreciate it 🙂Sorry I haven't contributed much other than that single hospital group listing, not much brainspace cycles at the moment. I'll submit a PR for posterity.


[Bug]: Minor update breaks the API

Bug description
Steps to reproduce the problem:

Update from 0.0.5 to  "@cloudflare/puppeteer": "0.0.6"
Build code that uses the connect() API
Does not build

Note: this was working and perfectly fine in 0.0.5 - now this simple first instruction does not anymore, and this is not even a major API version (e.g. 2.0.0) but 0.0.6.
Puppeteer version
0.0.6
Node.js version
18
npm version
<IP_ADDRESS>
What operating system are you seeing the problem on?
Windows
Relevant log output
import { BrowserContext, connect, ScreenshotOptions, TimeoutError } from '@cloudflare/puppeteer';

...

  // [puppeteer] start the remote session
  const browser = await connect({ browserWSEndpoint });

...

./src/modules/browse/browse.router.ts:103:25
Type error: Expected 2 arguments, but got 1.

  101 |
  102 |   // [puppeteer] start the remote session
> 103 |   const browser = await connect({ browserWSEndpoint });
      |                         ^
  104 |
  105 |   // for local testing, open an incognito context, to seaparate cookies
  106 |   let incognitoContext: BrowserContext | null = null;

Hi Enrico,
Can you provide a complete example that worked before? Since we've always connected using a transport, did not expect that to actually work, ie. browserWSEndpoint  = browser.wsEndpoint() would return an empty string, even if it did build.

Hi Enrico,
This package is a fork of the original puppeteer library and is only intended to support the Cloudflare's browser rendering product, read more here. If you're using native puppeteer or other platforms like browserless.io you should use https://www.npmjs.com/package/puppeteer instead.

Same problem for me. I'm using @cloudflare/puppeteer with a third-party Chrome instance, which is not working anymore since 0.0.6. The standard puppeteer-core package seems to use unsupported node dependencies:
✘ [ERROR] Could not resolve "fs/promises"

    node_modules/@puppeteer/browsers/lib/esm/fileUtil.js:8:31:
      8 │ import { mkdir, readdir } from 'fs/promises';
        ╵                                ~~~~~~~~~~~~~

  The package "fs/promises" wasn't found on the file system but is built into node. Are you trying to bundle for node? You can use "platform: 'node'" to do that, which will remove this error.

Any idea how to fix that?

Please add to wrangler.toml
compatibility_date = "2023-03-14"
node_compat = true

or if using pages
npx wrangler pages dev [<DIRECTORY>] --compatibility-flags="nodejs_compat". See here


fix: preview not working during festival

Refactor on how we set the start position with possible overrides
Removes the logic from RealmNavigator
Takes into consideration a position set by args so the feature flag is ignore accordingly
Also sets the correct value for localhost in Hostname for feature flag usage.

Fixes: https://github.com/decentraland/creator-hub/issues/312
QA TEST STEPS

Start the client with the flags --debug --dclenv zone. You should start in 100,100
Start the client with the flags --debug --dclenv zone --position 150,150. You should start in 150,150
Start the client with the flags --debug --dclenv zone --realm olavra.dcl.eth. Dont mind that the scene doesnt load, just check that the coordinates are 0,0. (Also, move a little bit through the scene, probably the scene will say -150,-150. If you move a parcel it should change correclty)

Local scene

Download this test scene and uncompress it somewhere
Enter the scene root folder with a terminal/command and run npm i and then npm run start
Close the Explorer that auto-opened. Leave the scene running in the console/terminal.
Download the build from this PR and connect it to the running scene using the console command according to your OS. Add the --dclenv zone as well to the args
The client should open and the scene with the cube in the middle should be shown
Close the client
Close the terminal/command running the scene
Open the client from this PR again
It should connect to 100,100
Teleport to a world, for example /goto olavra (Same issue, it wont load, but doesnt matter)
Check the world loads correctly
Press the button "Go back to Genesis City"
It should take you to 100,100 (During the festival the avatar should spawn in the festival coordinates)

Nice!! thank you for fixing my mess 😬

It's our mess

Verified on both platforms Windows and Macos ! ✅
✅Start the client with the flags --debug --dclenv zone. You should start in 100,100
✅Start the client with the flags --debug --dclenv zone --position 150,150. You should start in 150,150
✅Start the client with the flags --debug --dclenv zone --realm olavra.dcl.eth.

All commands seem to work properly on both platforms ! ✅