Notifications / badges not working

Hi Ferdi folks!
Yesterday I stumbled upon Ferdi and I was very curious to try it out - great job guys, I really love it!
Unfortunately the current Ferdi version (installed via brew on my Mac running Catalina) does not show that I received a new message in the dock (e.g. new WhatsApp message) and for some services (WhatsApp...), the badge on the service itself is not shown, too.
Is there anything I could do to get this working? Any help is appreciated. If you need more information, I am happy to provide them to you.
Thanks!
Flo

I have the same issue on Windows 10 (latest version). No badge on WhatsApp. It works for Slack and other services.

Same issue here. Tried in Kubuntu 20.04 no notifications to any service at all.

I am experiencing the same issue on:
Windows 10 20H2 (19042.630) 64bit
Ferdi 5.5.0 (x64)
Eletron 8.2.3
Node.js v12.13.0

For Mac this solved the issue for me: https://github.com/getferdi/ferdi/issues/818#issuecomment-645138272

Hey all, so it wasn't working for me initially (am using Windows 10 Version 2004), but I decided to use Franz's implementation for their Whatsapp recipe in webview.js. So similarly, replace
const elements = document.querySelectorAll("[class=OUeyt]");
with
const elements = document.querySelectorAll('.CxUIE, .unread, ._0LqQ, .m61XR .ZKn2B ');

same issue here

I've made a pull request to fix it: https://github.com/getferdi/recipes/pull/377

I've made a pull request to fix it: getferdi/recipes#377

I can confirm that this fix resolve the issue, i made it locally and now i have my notifications whatapps working again , would be cool to have this merged in the main repo

Problem still exists

This issue is not affecting only WhatsApp but it seems like all services.

With the latest version of Ferdi and the latest recipes, this should no longer be the case.

Can you please try to upgrade to the nightlies available here AND then upgrading the recipes by following the steps outlined here?
If you are on macos or linux, I have shared some newer builds of the latest source code here

For whatsapp bug still persist for unread counter.
got a workaround from https://github.com/getferdi/recipes/pull/377

Closing this issue - since the fixes are working in the latest nightly and beta versions.


Is there any possibilities to update the running container when the image having new changes?

Hi All,
I have installed the docker and run the container with my Magento docker image on digitalocean droplet. I want my running container will update automatically when I have made any changes on image. Is it possible? Please let me know way to achieve the same.

Not possible, sorry.

The best way to handle this is for any writes you do, do it in a volume, then you can attach the volume to a new container with the updated image.

You can use webhooks though, to automate things when a new image is built on docker hub; https://docs.docker.com/docker-hub/webhooks/. Docker Cloud can make this even easier, and redeploy services if a new images is ready; https://docs.docker.com/docker-cloud/apps/auto-redeploy/


Refactor controller specs

:oden:

Coverage increased (+1.63%) to 97.0% when pulling f69a7afc5281c34e36e9c61bdc586a17a6d7cd70 on refactor-controller-specs into 1bca594852408bdb0a6ecde44212c9c95f14f87b on master.


Get docs compiling

Checklist

[ ] Appropriate tests were added
[ ] Any code changes were done in a way that does not break public API
[ ] All documentation related to code changes were updated
[ ] The new code follows the
contributor guidelines, in particular the SciML Style Guide and
COLPRAC.
[ ] Any new documentation only uses public API

Additional context
This is definitely a WIP, just pathfinding to find the offending portions in the docs. Nowhere ready for a review.

@xtalax @ChrisRackauckas is there a timeout on how long the docs action can run? I'm now able to build the docs locally, but the action keeps getting cancelled.

@thazhemadam can we get this one to buildkite too?

@thazhemadam can we get this one to buildkite too?

@ChrisRackauckas does this need to be run on GPU machines? Or will the normal CPU runners suffice?

CPU runners are fine

@thazhemadam can we get this one to buildkite too?

This has been implemented in https://github.com/SciML/MethodOfLines.jl/pull/362.

Going to close this PR as I believe it's superseded by #362

No it's complementary.


[DPO] add option for compute_metrics in DPOTrainer

fixes issues #819

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.


building SSR with vite fails due to fs/promises

I am using sveltekit and vite to build my app. Running vite build fails with this error:
vite v5.1.4 building SSR bundle for production...
✓ 955 modules transformed.
x Build failed in 9.35s
error during build:
Error: [vite:load-fallback] Could not load<EMAIL_ADDRESS>(imported by ../../node_modules/.pnpm/@aztec+bb.js<EMAIL_ADDRESS>
Looks like node-stdlib-browser does NOT support fs/promises. Not sure why vite wants to use node-stdlib-browser for an SSR build but it is what it is.
I can provide a repro if this issue is going to be fixed.

unforrutnately this is blocked for a bit. Started because we need it for creating proofs, we still need a WASM endpoint for aztec/client IVC
Will tackle 5050 and some of the others though!

Below vite.config fixes the issue for me. Had to explicitly include fs/promises in nodePolyfills for some reason
import { defineConfig } from "vite";
import { nodePolyfills } from "vite-plugin-node-polyfills";
import topLevelAwait from "vite-plugin-top-level-await";

export default defineConfig({
  plugins: [nodePolyfills({ include: ["fs/promises"] }), topLevelAwait()],
});

@saleel could you and @critesjosh work together to ensure this is reflected in our docs? thanks!

looks like this was fixed at some point.

not fixed. Failing with this error now:
x Build failed in 7.21s
error during build:
[vite-plugin-sveltekit-compile] ../../node_modules/.pnpm/@aztec+circuits.js@0.67.0_typescript<EMAIL_ADDRESS>(3:9): "promises" is not exported by "__vite-browser-external", imported by "../../node_modules/.pnpm/@aztec+circuits.js@0.67.0_typescript<EMAIL_ADDRESS>file: /Users/user/repo/node_modules/.pnpm/@aztec+circuits.js@0.67.0_typescript@5.5.4/node_modules/@aztec/circuits.js/dest/structs/client_ivc_proof.js:3:9

1: import { bufferSchemaFor } from '@aztec/foundation/schemas';
2: import { BufferReader, serializeToBuffer } from '@aztec/foundation/serialize';
3: import { promises as fs } from 'fs';
            ^
4: import path from 'path';
5: /**

file: /Users/user/repo/node_modules/.pnpm/@aztec+circuits.js@0.67.0_typescript@5.5.4/node_modules/@aztec/circuits.js/dest/structs/client_ivc_proof.js:3:9

1: import { bufferSchemaFor } from '@aztec/foundation/schemas';
2: import { BufferReader, serializeToBuffer } from '@aztec/foundation/serialize';
3: import { promises as fs } from 'fs';
            ^
4: import path from 'path';
5: /**

../../node_modules/.pnpm/@aztec+circuits.js@0.67.0_typescript<EMAIL_ADDRESS>(3:9): "promises" is not exported by "__vite-browser-external", imported by "../../node_modules/.pnpm/@aztec+circuits.js@0.67.0_typescript<EMAIL_ADDRESS>file: /Users/user/repo/node_modules/.pnpm/@aztec+circuits.js@0.67.0_typescript@5.5.4/node_modules/@aztec/circuits.js/dest/structs/client_ivc_proof.js:3:9

1: import { bufferSchemaFor } from '@aztec/foundation/schemas';
2: import { BufferReader, serializeToBuffer } from '@aztec/foundation/serialize';
3: import { promises as fs } from 'fs';
            ^
4: import path from 'path';
5: /**

    at getRollupError (file:///Users/user/repo/node_modules/.pnpm/rollup@4.21.0/node_modules/rollup/dist/es/shared/parseAst.js:392:41)
    at error (file:///Users/user/repo/node_modules/.pnpm/rollup@4.21.0/node_modules/rollup/dist/es/shared/parseAst.js:388:42)
    at Module.error (file:///Users/user/repo/node_modules/.pnpm/rollup@4.21.0/node_modules/rollup/dist/es/shared/node-entry.js:13971:16)
    at Module.traceVariable (file:///Users/user/repo/node_modules/.pnpm/rollup@4.21.0/node_modules/rollup/dist/es/shared/node-entry.js:14419:29)
    at ModuleScope.findVariable (file:///Users/user/repo/node_modules/.pnpm/rollup@4.21.0/node_modules/rollup/dist/es/shared/node-entry.js:12121:39)
    at ChildScope.findVariable (file:///Users/user/repo/node_modules/.pnpm/rollup@4.21.0/node_modules/rollup/dist/es/shared/node-entry.js:7467:38)
    at ClassBodyScope.findVariable (file:///Users/user/repo/node_modules/.pnpm/rollup@4.21.0/node_modules/rollup/dist/es/shared/node-entry.js:7467:38)
    at ChildScope.findVariable (file:///Users/user/repo/node_modules/.pnpm/rollup@4.21.0/node_modules/rollup/dist/es/shared/node-entry.js:7467:38)
    at FunctionScope.findVariable (file:///Users/user/repo/node_modules/.pnpm/rollup@4.21.0/node_modules/rollup/dist/es/shared/node-entry.js:7467:38)
    at FunctionBodyScope.findVariable (file:///Users/user/repo/node_modules/.pnpm/rollup@4.21.0/node_modules/rollup/dist/es/shared/node-entry.js:7467:38)


NFT Extensions + RPC Caching

PR-Codex overview
The focus of this PR is to introduce NFT-related functionality and improvements to the Thirdweb project.
Detailed summary

Added NFTType enum and NFT and NFTMetadata structs
Updated contract handling in ThirdwebContract.cs
Added ERC721 and ERC1155 specific methods in ThirdwebContractExtensions.cs
Implemented NFT extension methods in ThirdwebNFTExtensions.cs
Added NFT-related test cases in Thirdweb.NFTExtension.Tests.cs

The following files were skipped due to too many changes: Thirdweb/Thirdweb.NFT/ThirdwebNFTExtensions.cs, Thirdweb/Thirdweb.RPC/ThirdwebRPC.cs

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Codecov Report
Attention: Patch coverage is 71.01449% with 80 lines in your changes missing coverage. Please review.

Project coverage is 90.64%. Comparing base (7b684e5) to head (de01e90).

Files
Patch %
Lines

Thirdweb/Thirdweb.NFT/ThirdwebNFTExtensions.cs
73.04%
34 Missing and 4 partials :warning:

...b/Thirdweb.Contracts/ThirdwebContractExtensions.cs
25.00%
30 Missing and 3 partials :warning:

Thirdweb/Thirdweb.RPC/ThirdwebRPC.cs
91.93%
4 Missing and 1 partial :warning:

Thirdweb/Thirdweb.Contracts/ThirdwebContract.cs
82.35%
1 Missing and 2 partials :warning:

Thirdweb/Thirdweb.NFT/NFTTypes.cs
91.66%
1 Missing :warning:

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #35      +/-   ##
==========================================
- Coverage   93.25%   90.64%   -2.61%
==========================================
  Files          24       26       +2
  Lines        2015     2256     +241
  Branches      228      255      +27
==========================================
+ Hits         1879     2045     +166
- Misses         97      163      +66
- Partials       39       48       +9

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Unexpected behaviour with subclasses of int

Noticed this issue when working with documents from MongoDB (using motor).
It returns integers as BSON types, which are subclasses of the int type.
Minimal reproduction examples: (pydantic 2.2.1)
from pydantic import BaseModel

class MyInt(int):
  ...

class Test(BaseModel):
  id: int

x =<PHONE_NUMBER>621953054
a = Test(id=MyInt(x))

print(a.id)

assert x == a.id # Fails, a.id is equal to<PHONE_NUMBER>621953024

from pydantic import BaseModel, ConfigDict

class MyInt(int):
  ...

class Test(BaseModel):
  model_config = ConfigDict(arbitrary_types_allowed=True)
  id: MyInt

x =<PHONE_NUMBER>621953054
a = Test(id=MyInt(x))

print(a.id)

assert x == a.id # Passes

The first example should either not allow passing the type in, or it should get the value correctly (same behaviour as in v1).
Selected Assignee: @samuelcolvin

After testing more, each time it is subclassed it breaks earlier. Seems to be eating up a byte each time.
from pydantic import BaseModel

class MyInt(int):
  ...

class Test(BaseModel):
  id: int

x = (2 ** 62) + 1
a = Test(id=MyInt(x))

print(x, a.id)

assert x == a.id # Silently breaks at 2 ** 62

from pydantic import BaseModel

class MyInt(int):
  ...

class MyInterInt(MyInt):
  ...

class Test(BaseModel):
  id: int

x = (2 ** 61) + 1
a = Test(id=MyInterInt(x))

print(x, a.id)

assert x == a.id # Silently breaks at 2 ** 61


confirmation_sent_at is set regardless skip_confirmation_notification! method call

Related to https://gitlab.com/gitlab-org/gitlab/-/merge_requests/138501#note_1686234692
User's confirmation_sent_at is set regardless skip_confirmation_notification! when creating new user.

I just found why confirmation_sent_at is always set https://github.com/heartcombo/devise/issues/4536#issuecomment-312870410.


Add beginnings of www content

This is still a WIP, but is in a good-enough spot to merge into fusion in order to keep @chrsmith unblocked on the blog work.

@chrsmith Can we merge this into fusion and then continue working from there, after we merge your other PR into this branch?

What's the benefit of the extra assets dir in static/assets/images? I know that's how it is in the www repo, but looking at some other Hugo sites listed at https://gohugo.io/showcase/, they all seem to put things directly in static, e.g. static/images, static/fonts, etc., not static/assets/images, static/assets/fonts, etc.

What's the benefit of the extra assets dir in static/assets/images?

None, really -- I'm just as happy having things at /images, etc. I'll make that change.


Druid Avatica - Handle escaping of search characters correctly

#10038 .
Test to demonstrate the issue. I tried attempting a fix by appending  ESCAPE \`` clause to the TABLE_NAME LIKE expression but that didn't help.

See this test - https://github.com/apache/druid/pull/10040/files#diff-abce84dd2ebf199e321294871db5068fR558

Gian, any insights into why the proposed fix isn't working?

Ok, figured out what the right thing to do here is, I think. When a user requests to escape search characters like _ by using \\_ , we need to make sure that the ESCAPE ` clause is added to the LIKE filter. Added tests to verify the fix.


Running CombineFCS on R

Greeting @tabdelaal and thank you for sharing your code. I have been trying to run the combination of 2 fcs files sharing common markers (for information some channels were not labeled and kept as isotopes numbers), and got stuck at this step (see screenshots), any comment is welcome!

Dear @AlexBouz,
I believe the problem is having all markers shared between the 2 fcs files, as the column size of Data1.nonshared and Data2.nonshared is zero. Which means both fcs files shares all markers and there is nothing to impute between the files. The merging idea relies on having some shared markers, and some unique markers in each file. Are these 2 fcs files produced from two different cytometry panels, but sharing some (not all) markers?


Segregate Multus Network IPs consumed by WorkerNodes and Application PODs

Hello All,
Is there a way to segregate the IP pool between the EC2 worker node hosts and multus application pods.
For Ex: <IP_ADDRESS>/24 is configured as a multus network.
Now If I spawn 5 worker nodes, the nodes consume 5 IPs randomly between <IP_ADDRESS> and <IP_ADDRESS>. Is there a way to control this IP allocation as it sometimes disrupts application pods IP planning?
Thanks,
Jayaprakash

Hi,
It's not in the scope of this repo, but in practice, we can think about creating dummy-interface in the subnet (before creating worker node group). To the dummy interface, you can (pre-)bind IP addresses to be used for application as secondary IPs of interface (please keep in mind, you have to turn on 'reassign allowed". We can also think about creating lambda and small DB to manage these IPs using this dummy-interface to preserve IP addresses for multus application but it would be beyond the scope of this repo.


Text font changing after the component is loaded

Component text font quickly changes after the component is loaded.

Why this is happening:
Font is rendered differently across various browsers and operating systems. This makes it difficult to deliver consistent UX for your users as some may see the component text in a format that you expect but others may see it with undesirable padding/alignment/size which can be unattractive.
To fix this; the component uses Google web fonts which help enforce standardised font format for all browsers and operating systems. The downside of this is that the component needs to download them via the internet and this latency is the reason why you are seeing a font change.
We have considered pre-bundling the web fonts inside the component, however our investigation concluded that this is a relatively complex task that may ultimately not be handled correctly by the parent app's bundler (not to mention that it would also significantly increase the component size). Hence, if the startup font change behaviour problematic, develoepers can change it by using the approach below.
How to prevent this:
Deep Chat uses Inter as the default font-family value - which in turn is visibly affected when Google web fonts are downloaded on startup. Changing this to anything else will prevent the component font from changing (if the parent app is not using its own custom web fonts). You can simply achieve this by setting the font-family property in containerStyle or any of the other style property in Deep Chat to a font that you desire.

Another optimization that you can make in your app is - if the component is not shown immediately, you can preload the fonts using the following JS code:
const FONT_URL = 'https://fonts.googleapis.com/css2?family=Inter:wght@400;600&display=swap';

function PreloadFont() {
  const head = document.getElementsByTagName('head')[0];
  const linkExists = Array.from(head.getElementsByTagName('link')).some((link) => link.getAttribute('href') === FONT_URL);
  if (!linkExists) {
    const link = document.createElement('link');
    link.rel = 'stylesheet';
    link.href = FONT_URL;
    head.appendChild(link);
  }
}


[docs] Why are CRDs installed via an extra GitRepository Kustomization?

Hi,
your installation guide describes the installation of the CRDs via an extra GitRepository Kustomization. Is there a reason why the CRDs cannot be installed directly via the Helm chart? If so, what is the reason?

@gusfcarvalho thank you for the quick reply, actually I was not aware that dependsOn is limited to resources of same kind. With that in mind your approach makes totally sense, although you could also wrap the CR and the CRDs+Helm into two Kustomizations.
example:
apiVersion: kustomize.toolkit.fluxcd.io/v1beta2
kind: Kustomization
metadata:
  name: external-secrets-base
  namespace: flux-system
spec:
  interval: 5m
  prune: true
  sourceRef:
    kind: GitRepository
    name: flux-system
    namespace: flux-system
  path: ./infrastructure/external-secrets/base
  wait: true
  timeout: 2m
---
apiVersion: kustomize.toolkit.fluxcd.io/v1beta2
kind: Kustomization
metadata:
  name: external-secrets-secret-stores
  namespace: flux-system
spec:
  interval: 5m
  prune: true
  sourceRef:
    kind: GitRepository
    name: flux-system
    namespace: flux-system
  path: ./infrastructure/external-secrets/secret-stores
  wait: true
  timeout: 2m
  dependsOn:
    - name: external-secrets-base


ODK Central 0.7 release

This release covers a number of improvements to existing functionality:

Rework the Form State workflow and consolidate them up to the Project level.
Allow granular visibility control per App User.
Appoint read-only Viewers on a Project.
Basic consolidation of timing audit logs during export.
Other smaller fixes.

Preliminary release criteria and story status may be found here.
Comments and feedback may be left directly on the document, or here in this ticket.

Will read-only viewers have ability to download data?
I presume so or would want that as a level of granularity

yes!

Asking for ruODK: What's the best way to estimate the timeline of new ODK Central releases? I'm trying to keep ruODK up to date against the current release.

unfortunately we don’t plan firm dates in advance because our team is so incredibly small: life things and small misestimations have a huge impact on our schedule, along with external pressures like support and maintenance. but if you check in with at the document linked on this ticket, we update it continually with our current status and you can tell we are close to release when it starts looking like mostly checkmarks. we also discuss the release status on the developer’s slack (for anybody else reading, please only use this resource if you are contributing to odk development).
in addition, i’m happy to drop you a note when we are close each time. we try not to release breaking changes, of course, but i appreciate that you try to keep up with new things as we get them out.

That's perfectly fine, thanks! My only goal is to keep up with ODK Central. ruODK unit tests run against the Central sandbox so I notice anything breaking quickly enough.


Move to Python 3.7+ code

This addresses #227 to remove the old Python 2.7 compatibility code and moved the code base up to Python 3.7+
This is only lightly tested; vnclog still does not work.
Please have a look and review carefully; any (early) feedback from you is very much appreciated. Hopefully I will find time during the Christmas holidays to work on that.
If this is too much I can try to split this into separate PRs, but that is not trivial as some of those patches depend on each other: the code might not git bisect at all because some intermediate steps might be "broken".

How have you tested this?

You got me: I'm still on it which is why I called this PR a WIP. I only did some simple vncdotool testing so far.
My company Univention GmbH is using it for our automated testing, which is why I'm working on this at all. Our tests where failing after switching to Python 3 so I had to go down very deep. I had to spend many hours on understanding the low-level details and adding type-hints helped me to understand all the relations.

I'm wondering if this should be a 2.0 type change. I'm also thinking that when this goes in I'll close any open and stale PRs because most likely they'll need updating due to conflicts. What do you think?

I tried to not break the ABI, but all those bytes vs. unicode differences might have changed details, especially my commit 1ecaafc9d107 named fix(rfb): Missing encoding/decoding: Previously it was unspecified if you still work with low-level bytes or already with high-level unicode.
The change to use bytearray() to buffer the packages should be an internal change and not affect any using application.
The rest is mostly refactoring and style changes, which would not require a major version bump. But I'm okay with this.
I only have looked shortly at the pending PRs: Most of them will no longer work because adding PEP-484 type annotations changed most context. If you take them before this PR I'll rework my branch to incorporate them, but the other way around would also be okay.

Last run looks better, but the build for 3.11 is failing because my branch (based on main) still uses isolate while your branch master has it already removed.
I cherry-picked your patches 9ca371f8da99399e553eb10f230b509eb2601d38 3c17a6583a403e3730db6187cbfcee1db3fdea04 30d4db5db9c41f6634b611939fb3d9fef1474a4c 84de3c922b03b21fd95ea8c44ae1503f19e34651 and squashed them into one and fixed tests/unit/test_command.py.

Let me know when you think this is mostly good enough to merge.  I think we should merge sooner rather than later.  It will be easier for us to make additional cleanups against main than holding a PR open.

From my PoV it's ready; I undid my change to pytest as you already merged your change to plain unittest into main.
My testing so far found no issues, but  your eyes and testing as the expert are much appreciated.

I'm wondering if this should be a 2.0 type change. I'm also thinking that when this goes in I'll close any open and stale PRs because most likely they'll need updating due to conflicts. What do you think?

I tried to not break the ABI

Removing Python 2.x support is a breaking change, so using Semantic versioning the version should be 2.0.0.

huge thanks @pmhahn for putting all this together.

@pmhahn fyi, https://github.com/sibson/vncdotool/commit/54bcdb23a9e0c560774009680774041af07038f5, sets up the environment to run the functional tests.  They are currently failing due to a bytes/string issue.

@pmhahn fyi, 54bcdb2, sets up the environment to run the functional tests. They are currently failing due to a bytes/string issue.

Thanks for that; see #231 which fixes those bytes/string issues.


Cannot find plugin 'esformatter-align'

esformatter throws the following error:
Error: Cannot find plugin 'esformatter-align'. Make sure you used the correct name on the config file or run `npm install --save-dev esformatter-align` to add it as a project dependency.

The same problem shows with global and local installs of esformatter. esformatter itself has no troubles spitting out a diff.
The following file is enough to cause the error:
var longer = require('hello');
var small = require('hello');
var muchlonger = require('hello');

.esformatter is:
{
  "plugins": ["esformatter-align"]
}

I don't actually have the modules installed local as the error suggests trying, however if I try and follow the advice in an actual repo that esformatter also diffs fine it still throws the exact same error.
Thanks for the plugin!

As per readme, plugins are bundled here and needs to be included. Added it now.

Ah I see.
Perhaps:

Some plugins are bundled. PR welcome for more.
Just add the ones you want to your config file:
Could be rewritten to include the actual list of bundled plugins or link to it. That would make clear that 'add the ones you want' only goes for the plugins that are already bundled. As is I assumed some didn't have to be installed (because they were bundled) and could still be used as long as you installed them prior to 'add[ing] the ones you want to your config file'.

So something like:
Plugins
Currently the following plugins are bundled.

esformatter-add-trailing-commas
esformatter-braces
esformatter-collapse-objects
...
PR welcome for more.

Config
Just add any of the bundled plugins you want to your config file.
{
    "plugins": [
        "esformatter-braces"
    ]
}

I can open a pull request if you like. Thanks for the quick include of 'align'!


Fix compiler warnings

Pull Request Test Coverage Report for Build 1157

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 94.895%

Totals

Change from base Build 1153:
0.0%

Covered Lines:
2993

Relevant Lines:
3154

💛  - Coveralls

bors: r+


xds-k8s: Bootstrap generator interop tests

Added a couple of tests which run the baseline_test with all released
bootstrap generator versions on client and server. These tests will be
run on a continuous integration environment with gRPC servers and
clients built using the latest released version of gRPC in one selected
language.

Thanks for the review. I've incorporated your suggestions and taken care of your comments. PTAL.

Thanks for the review @sergiitk .
I ran the linting tools one more time, and also added a TODO for reusing the service accounts and namespaces.

@sergiitk
And looks like I still don't have write access to this repo. So, you would have to merge this. Thank you.


Preventing a child object from saving into a new collection in an embedsMany relationship

Is there any way to forcibly prevent an element used in an embedsMany relationship from being saved into its own collection?
E.g.
Order embedsMany Items
can I prevent myself from accidentally writing Items::create([]) and inserting a new document into a items collection in the database? In SQL land it would theoretically throw a foreign key contstraint violation, anything similar in Mongodb?

I'm not aware of anything in MongoDB that would do this.  Just create an Embeddable trait that overrides create() and any other methods you don't want to use and throws an exception instead.


bug: Overlap text  (Show Content )

@moteeullahazmi
It got fixed and merged in this repo, just not pushed on production yet

Shoudl be fixed on next buidl


User with no privileges for repository can view and modify assets in that repository

The test failures are not related and are kind of random. I've seen them fail in past as well. We need to take a look at those and fix them once and for all.

Licenses for new files show 2015; but otherwise fine... +1 to merge.

6.4.x: 21e76547a0d7efb10de67184c6bb287d64aaf6dc


Issue with Sqlcipher not encrypting the database.

Hi Guys,
I trust you are all well,
I used Gerald Versluis tutorial to originally setup a secure test database as per this link and your gitlab site.
https://www.google.com/search?q=maui+sqlite+sqlcipher+example&oq=Maui+SQL&gs_lcrp=EgZjaHJvbWUqBggAEEUYOzIGCAAQRRg7MgYIARBFGDkyBggCEEUYOzIGCAMQRRg7MgYIBBBFGDwyBggFEEUYPDIGCAYQRRg8MgYIBxAuGEDSAQkxMDYzNWowajGoAgCwAgA&sourceid=chrome&ie=UTF-8#fpstate=ive&vld=cid:01b06d9d,vid:O1UQfoh4710,st:0
We've been using sqlite-net-sqlcipher version 1.9.172 and versions from before in dotNet Maui 8.0.
The solution have multiple tables and we store encrypted data in the Mobile Application build for Android and iOS.
Lately it was requested that we add functionality for the User to be able to change the database encryption key.
This is when I noted that does not matter what key you pass into the database for login, it will always came back with the database as read ready.
I would have suspected as per normal that if a wrong key for the database login is provided an access or Security exception should be thrown. But NOT.  Can you please have a look at this as a matter of urgency.
Currently on Visual Studio Community version 17.11.5 Example as per your github site or per above link. The original .pcl nuget was replaced with the .sqlcipher.
If you can create a database with key A and next login into it with a different key B then you hit the bug.
PS; In other native Android Java/Kotlin and iOS Swift in different projects the sql-ciper works flawless.
Kind regards
Heinrich

@SC-HeinrichG - Unfortunately it's very likely that your database is not actually encrypted. To see if SQLCipher is even being used at runtime, execute the query PRAGMA cipher_version; and retrieve the result set. If SQLCipher is being used it will return a value with the library version number. If there is no result set returned you're using standard SQLite and the database is unencrypted.

Hi Stehen Lombardo,
Thank you for the feedback.
Is there a tutorial to enable encryption on the database?
Kind regards
Heinrich Glover
Developer
[signature_774479978]
M: 27 72 303 5605 | W: www.securecitizen.co.zahttp://www.securecitizen.co.za/ | A: Building A, Suite 2, Cotillion Place, 22 Techno Ave, Techno Park, Stellenbosch, 7600
[signature_3899392277]https://securecitizen.co.za/identity-fraud-theft-protection-services-secure-citizen/
[signature_4090389410]https://play.google.com/store/apps/details?id=com.onevault.sc_consumer_maui[signature_1015348171]https://apps.apple.com/za/app/secure-citizen/id1671813454
Or Register Onlinehttps://securecitizen.app/
This email and its contents are privileged and confidential and for the use of the addressee only. Should you have received this email in error please notify us by replying directly to the sender and thereafter delete the email and any attachments from your system. You warrant that you are legally entitled to disclose any personal information sent by you to Secure Citizen Pty Ltd, that Secure Citizen Pty Ltd is legally entitled to process this personal information for you or on your behalf for the purpose(s) requested or instructed by you, and that you have obtained the necessary consents from the data subject(s) to disclose and process the personal information. © Copyright: Copyright in this document vests in Secure Citizen Pty Ltd. No part of this document may be reproduced in whole or in part, used for commercial gain or disclosed or transmitted in any form whatsoever, without the prior written consent of the copyright owner, and to do so will be unlawful.

From: Stephen Lombardo @.>
Sent: Friday, October 25, 2024 9:04 PM
To: praeclarum/sqlite-net @.>
Cc: Heinrich Glover @.>; Mention @.>
Subject: Re: [praeclarum/sqlite-net] Issue with Sqlcipher not encrypting the database. (Issue #1257)
@SC-HeinrichGhttps://github.com/SC-HeinrichG - Unfortunately it's very likely that your database is not actually encrypted. To see if SQLCipher is even being used at runtime, execute the query PRAGMA cipher_version; and retrieve the result set. If SQLCipher is being used it will return a value with the library version number. If there is no result set returned you're using standard SQLite and the database is unencrypted.
—
Reply to this email directly, view it on GitHubhttps://github.com/praeclarum/sqlite-net/issues/1257#issuecomment-2438609290, or unsubscribehttps://github.com/notifications/unsubscribe-auth/BGMPS3C2S55R3KU64ZGPQVLZ5KI5TAVCNFSM6AAAAABQOWVCS2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMZYGYYDSMRZGA.
You are receiving this because you were mentioned.Message ID: @.***>

Hello @SC-HeinrichG I'm not aware of any specific, up-to-date tutorials for this particular package. It seems like there could be some problem with your application setup or these nuget packages. Perhaps some other community members may chime in with other suggestions.
For reference only, if you're using SQLCipher commercially, compatible commercially supported packages are available directly from the SQLCipher site.

Thanks Stephen,
Don't stress, I will figure it out. For now, I'm treating the database as Un-Encrypted and encrypt the required fields with Aes256.
Thanks for getting back to me.
Regards
Heinrich Glover
Developer
[signature_774479978]
M: 27 72 303 5605 | W: www.securecitizen.co.zahttp://www.securecitizen.co.za/ | A: Building A, Suite 2, Cotillion Place, 22 Techno Ave, Techno Park, Stellenbosch, 7600
[signature_3899392277]https://securecitizen.co.za/identity-fraud-theft-protection-services-secure-citizen/
[signature_4090389410]https://play.google.com/store/apps/details?id=com.onevault.sc_consumer_maui[signature_1015348171]https://apps.apple.com/za/app/secure-citizen/id1671813454
Or Register Onlinehttps://securecitizen.app/
This email and its contents are privileged and confidential and for the use of the addressee only. Should you have received this email in error please notify us by replying directly to the sender and thereafter delete the email and any attachments from your system. You warrant that you are legally entitled to disclose any personal information sent by you to Secure Citizen Pty Ltd, that Secure Citizen Pty Ltd is legally entitled to process this personal information for you or on your behalf for the purpose(s) requested or instructed by you, and that you have obtained the necessary consents from the data subject(s) to disclose and process the personal information. © Copyright: Copyright in this document vests in Secure Citizen Pty Ltd. No part of this document may be reproduced in whole or in part, used for commercial gain or disclosed or transmitted in any form whatsoever, without the prior written consent of the copyright owner, and to do so will be unlawful.

From: Stephen Lombardo @.>
Sent: Wednesday, October 30, 2024 10:48 PM
To: praeclarum/sqlite-net @.>
Cc: Heinrich Glover @.>; Mention @.>
Subject: Re: [praeclarum/sqlite-net] Issue with Sqlcipher not encrypting the database. (Issue #1257)
Hello @SC-HeinrichGhttps://github.com/SC-HeinrichG I'm not aware of any specific, up-to-date tutorials for this particular package. It seems like there could be some problem with your application setup or these nuget packages. Perhaps some other community members may chime in with other suggestions.
For reference only, if you're using SQLCipher commercially, compatible commercially supported packages are available directly from the SQLCipher sitehttps://www.zetetic.net/sqlcipher/.
—
Reply to this email directly, view it on GitHubhttps://github.com/praeclarum/sqlite-net/issues/1257#issuecomment-2448345489, or unsubscribehttps://github.com/notifications/unsubscribe-auth/BGMPS3D7WG4NJSPCPCKTJC3Z6FAY5AVCNFSM6AAAAABQOWVCS2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINBYGM2DKNBYHE.
You are receiving this because you were mentioned.Message ID: @.***>


Is there a way to specify application specific for TUI applications such as vim ?

I want to use xremap to combine wm keybinds and nvim keybinds

i need it on X11 btw


Fix memory leaks in SnackBar

Part of https://github.com/flutter/flutter/issues/141198
Pre-launch Checklist

[x] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[x] I read the Tree Hygiene wiki page, which explains my responsibilities.
[x] I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
[x] I signed the CLA.
[x] I listed at least one issue that this PR fixes in the description above.
[x] I updated/added relevant documentation (doc comments with ///).
[x] I added new tests to check the change I am making, or this PR is test-exempt.
[x] I followed the breaking change policy and added Data Driven Fixes where supported.
[x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

cc @polina-c

We have a 'Google testing' test failed. This means one of two:

Public test coverage is not good enough and should be extended to cover the failure
The internal usage of the feature is wrong and should be fixed

Putting the test details here hoping they will help you to choose between the two.
Let me know if you need code of SnackBarContainer or you can repro the failure without it.
Test code:
      testWidgets(
          'should remove snack bar when popping back from other scaffold, '
          'if the cross-scaffold min duration has expired.', (tester) async {
        await pumpScaffoldRoutes(tester);
        store.updateState(ApplicationState((b) => b
          ..view.messaging.snackBar = SnackBarState(
            'message',
            shownAt: now,
            persistAcrossScaffolds: persistAcrossScaffolds,
          ).toBuilder()));
        await tester.pumpAndSettle();

        // Verify snack bar shown on route #1.
        expect(find.byKey(Key('route1')), findsOneWidget);
        expectSnackBar('message');

        // Navigate to route #2.
        now = now.add(Duration(milliseconds: 500));
        await tester.tap(find.byKey(Key('navigate.button')));
        await tester.pumpAndSettle();
        expect(find.byKey(Key('route2')), findsOneWidget);

        // If persistent, expect the snack bar to transfer across.
        if (persistAcrossScaffolds) {
          expectSnackBar('message');
        } else {
          expectNoSnackBar();
        }

        // Pop back to route #1.
        now = now.add(defaultSnackBarDuration);
        await tester.pageBack();
        await tester.pumpAndSettle();
        expect(find.byKey(Key('route1')), findsOneWidget);

        // Expect the snack bar to not linger on route #1.
        expectNoSnackBar();
      });

Error:
	Null check operator used on a null value
		The relevant error-causing widget was:
		AnimatedBuilder
		AnimatedBuilder:third_party/dart/flutter/lib/src/material/snack_bar.dart:859:28
		When the exception was thrown, this was the stack:
		#0      _SnackBarState.build.<anonymous closure> (third_party/dart/flutter/lib/src/material/snack_bar.dart:864:43) ...

That is a weird bug, it looks like an animation is not set when running the build, but they are supposed to be since it is done in the initState and didUpdateWidget 🤔 I wasn't able to reproduce the failure, would you have access to pumpScaffoldRoutes, store, SnackBarState, ApplicationState ?

It is challenging to share internal code in a way that does not leak internal sensitive information.
Let's try other approach.
Can you please add some debug time (in asserts like here) protection for usage after disposal?
To the animation itself and _SnackBarState.
So that we can see what caused the failure clearer.
Let's see how many tests will fail in Flutter. If not many and they are easy to fix, we may want to keep it. And it may help us to figure out the internal failure.

Sure, I added the asserts in perf: Add debugDispose to snackbar and curved animation. Let's see what comes out of it

It seems states are used after disposal. Can it be that Null check operator used on a null value that was raised in G3 is caused by usage after disposal?
If yes, can we make the classes more resilient to usage after disposal?

perf: Add debugDispose to snackbar and curved animation

Sure, I guess I should also remove what was done in perf: Add debugDispose to snackbar and curved animation (the  debug time protection in asserts for usage after disposal?) ?

perf: Add debugDispose to snackbar and curved animation

Sure, I guess I should also remove what was done in perf: Add debugDispose to snackbar and curved animation (the debug time protection in asserts for usage after disposal?) ?

For now you may want to replace debug asserts with debug prints in case of violation, so that we see if usage after disposal is causing failures in google testing, in case they are still here.

Converted the PR to draft, as it is not intended for merge at the moment.

@polina-c ci: Add debug prints to investigate failing ci adds some logs, do they show something in the google internal tests?

Here is the error:
The following _TypeError was thrown building AnimatedBuilder(listenable: AnimationController#178cc(▶
		0.400; for SnackBar)➩Cubic(0.40, 0.00, 0.20, 1.00), dirty, state: _AnimatedState#23f3b):
		Null check operator used on a null value
		The relevant error-causing widget was:
		AnimatedBuilder
		AnimatedBuilder:third_party/dart/flutter/lib/src/material/snack_bar.dart:874:28
		When the exception was thrown, this was the stack:
		#0      _SnackBarState.build.<anonymous closure> (third_party/dart/flutter/lib/src/material/snack_bar.dart:879:43)
		#1      ListenableBuilder.build (third_party/dart/flutter/lib/src/widgets/transitions.dart:1127:48)
		#2      _AnimatedState.build (third_party/dart/flutter/lib/src/widgets/transitions.dart:138:48)
		#3      StatefulElement.build (third_party/dart/flutter/lib/src/widgets/framework.dart:5593:27)
		#4      ComponentElement.performRebuild (third_party/dart/flutter/lib/src/widgets/framework.dart:5481:15)
		#5      StatefulElement.performRebuild (third_party/dart/flutter/lib/src/widgets/framework.dart:5644:11)
		#6      Element.rebuild (third_party/dart/flutter/lib/src/widgets/framework.dart:5197:7)
		#7      BuildOwner.buildScope (third_party/dart/flutter/lib/src/widgets/framework.dart:2905:19)
		#8      AutomatedTestWidgetsFlutterBinding.drawFrame (third_party/dart/flutter_test/lib/src/binding.dart:1418:19)
		#9      RendererBinding._handlePersistentFrameCallback (third_party/dart/flutter/lib/src/rendering/binding.dart:468:5)
		#10     SchedulerBinding._invokeFrameCallback (third_party/dart/flutter/lib/src/scheduler/binding.dart:1392:15)
		#11     SchedulerBinding.handleDrawFrame (third_party/dart/flutter/lib/src/scheduler/binding.dart:1313:9)
		#12     AutomatedTestWidgetsFlutterBinding.pump.<anonymous closure> (third_party/dart/flutter_test/lib/src/binding.dart:1273:9)
		#15     TestAsyncUtils.guard (third_party/dart/flutter_test/lib/src/test_async_utils.dart:71:41)
		#16     AutomatedTestWidgetsFlutterBinding.pump (third_party/dart/flutter_test/lib/src/binding.dart:1260:27)

🤔 I'm still confused with it haha.
I believe the snack bar is getting disposed and for some reason the AnimatedBuilder using _heightAnimation rebuilds.
I can try to add more prints.
Alternatively, I could do a check like that:
     if (_heightAnimation != null) {
      snackBarTransition = AnimatedBuilder(
        animation: _heightAnimation!,
        builder: (BuildContext context, Widget? child) {
          return Align(
            alignment: AlignmentDirectional.topStart,
            heightFactor: _heightAnimation!.value,
            child: child,
          );
        },
        child: snackBar,
      );
    } else {
      snackBarTransition = child;
    }

but that looks wrong to me

I do not know what is right thing to do here. I am open for experiments in different directions directions. Feel free to start tackling them in parallel by creating number of draft PRs that are intended to solve the same problem, to check how tests will react. :)

Sure I can do that. Can you help me check if there are some useful logs from the commit debug: Add more prints ?

Checking.
For debug prints it would be helpful to prefix all them with something outstanding like !!!!, to make search easier.

Snackbar.dispose called. _SnackBarState#e1f97
		Snackbar.dispose called. _SnackBarState#e5677
		00:01 +1: SnackBarContainer with persistAcrossScaffolds=true should provide a SnackBar action when configured
		Snackbar.dispose called. _SnackBarState#cfaa6
		00:01 +2: SnackBarContainer with persistAcrossScaffolds=true should hide SnackBar action when allowSnackbarAction=false
		Snackbar.dispose called. _SnackBarState#06f1c
20:30:31.000	U	00:01 +3: SnackBarContainer with persistAcrossScaffolds=true should only transfer persistent snack bar across scaffolds
		Snackbar.dispose called. _SnackBarState#352da
		Snackbar.dispose called. _SnackBarState#938f5
		CurvedAnimation.value is used after being disposed. AnimationController#8c4d9(▶ 0.400; for SnackBar)➩Interval(0.72⋯1.0)➩Cubic(0.40, 0.00, 0.20, 1.00)ₒₙ/Threshold
		SnackBar._heightAnimation in AnimatedBuilder. _SnackBarState#938f5(lifecycle state: defunct, not mounted)
		SnackBar is disposed in AnimatedBuilder. _SnackBarState#938f5(lifecycle state: defunct, not mounted)
		SnackBar._heightAnimation in AnimatedBuilder. _SnackBarState#938f5(lifecycle state: defunct, not mounted)
		SnackBar is disposed in AnimatedBuilder. _SnackBarState#938f5(lifecycle state: defunct, not mounted)
		══╡ EXCEPTION CAUGHT BY WIDGETS LIBRARY ╞═══════════════════════════════════════════════════════════
		The following _TypeError was thrown building AnimatedBuilder(listenable: AnimationController#8c4d9(▶
		0.400; for SnackBar)➩Cubic(0.40, 0.00, 0.20, 1.00), dirty, state: _AnimatedState#fa9e2):
		Null check operator used on a null value
		The relevant error-causing widget was:
		AnimatedBuilder
		AnimatedBuilder:third_party/dart/flutter/lib/src/material/snack_bar.dart:875:28
		When the exception was thrown, this was the stack:
		#0      _SnackBarState.build.<anonymous closure> (third_party/dart/flutter/lib/src/material/snack_bar.dart:889:43)
		#1      ListenableBuilder.build (third_party/dart/flutter/lib/src/widgets/transitions.dart:1127:48)
		#2      _AnimatedState.build (third_party/dart/flutter/lib/src/widgets/transitions.dart:138:48)
		#3      StatefulElement.build (third_party/dart/flutter/lib/src/widgets/framework.dart:5593:27)
		#4      ComponentElement.performRebuild (third_party/dart/flutter/lib/src/widgets/framework.dart:5481:15)

It looks like fix: Use ValueListenableBuilder made the trick 😃

@polina-c Is there something else you want me to do on this?


CloudAsset: Update asset lib to v1 for ListAssets sample code

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

[ ] Make sure to open an issue as a bug/issue before writing your code!  That way we can discuss the change, evaluate designs, and agree on the general idea
[ ] Ensure the tests and linter pass
[ ] Code coverage does not decrease (if any source code was changed)
[ ] Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> ☕

Not familiar with the process. May I ask what's the blocking issue for this PR? Thanks!

@Neenu1995 do you know why the integration tests and owlbot are not runnign?

Not sure why it is not running on just this PR. Other PRs look fine. Let's try retriggering it.


problem with embedding dimension

intially i've run ingest.py and faced the following error:
RuntimeError: Embedding dimensions of the model (384) don't match the embedding dimensions of the document store (768). Initiate WeaviateDocumentStore again with arg embedding_dim=384.
upon changing the embedding_dim from 768 to 384 at line 12 in ingest.py; this is error which i'm facing:
Traceback (most recent call last):
File "/Users/sairohith/Downloads/Haystack-and-Mistral-7B-RAG-Implementation/ingest.py", line 60, in
document_store.update_embeddings(retriever)
File "/Users/sairohith/Downloads/Haystack-and-Mistral-7B-RAG-Implementation/.venv/lib/python3.11/site-packages/haystack/document_stores/weaviate.py", line 1525, in update_embeddings
self.weaviate_client.data_object.update({}, class_name=index, uuid=doc.id, vector=emb)
File "/Users/sairohith/Downloads/Haystack-and-Mistral-7B-RAG-Implementation/.venv/lib/python3.11/site-packages/weaviate/data/crud_data.py", line 266, in update
raise UnexpectedStatusCodeException("Update of the object not successful", response)
weaviate.exceptions.UnexpectedStatusCodeException: Update of the object not successful! Unexpected status code: 500, with response body: {'error': [{'message': 'msg:repo.merge code:500 err:merge into index document: update local object: shard="iamYdcK7NLPW": Validate vector index for update of 174af3b8-d99f-2b7b-6824-7045bc59d31d: new node has a vector with length 384. Existing nodes have vectors with length 768'}]}.
Can anyone help me resolve this error?

Hi I did this first curl -X DELETE "http://localhost:8080/v1/schema/Document" restart docker container and change embedding_dim to 384  document_store = WeaviateDocumentStore(
host='http://localhost', port=8080, embedding_dim=384) it worked for me.

hi @sandeesaripalli
thank you for your help.
came up with anonther error:
raise WeaviateStartUpError(
weaviate.exceptions.WeaviateStartUpError: Weaviate did not start up in 5 seconds. Either the Weaviate URL http://localhost:8080 is wrong or Weaviate did not start up in the interval given in 'startup_period'.
Do u have a solution for this?

where we can access Pypdf file, in repo is not their...?


Workflow does not work with "nextjs-pages" 14.2.15 and QStash 2.7.12

Using latest next 14 and QStash versions, here is the error message:
 ⨯ Error [ERR_MODULE_NOT_FOUND]: Cannot find module '/project/workspace/node_modules/next/server' imported from<EMAIL_ADDRESS>Did you mean to import next/server.js?

Repro here:
https://codesandbox.io/p/devbox/79yx3q
The app router version seems to work, but the pages version throws that error
Note it's using:
 "module": "esnext",
 "moduleResolution": "bundler",

I'm also having the same problem as you with the same versions using Pages Router. I can't use the new Workflow because it gives me the error you're having

@vacom It’s not ideal, but in the meantime, if you can, just use the app router for the workflows. I tested it, and everything works perfectly there

@mkv27 Yes, I can confirm that it works on App Router, but I'd like to keep it consistent. I can use App Router for this until the fix for Pages Router arrives. Thanks for the tip

Hi @mkv27 @vacom,
We believe we addressed this issue in release v2.7.13. Can you check again?

@CahidArda I can confirm 2.7.13 fix that, that version works in pages and app router. Thank you!!


create v5 node20 release

create the new v5 release with node20 updates and the required workflow version bumps

The new version and tags are missing still.
The release workflow failed https://github.com/Azure/k8s-deploy/actions/runs/8350336943


do not depend on the archive root directory name. fixes #5

Fixed in https://github.com/coolaj86/node-install-script/commit/5658598c4a5874d6dc444342ff81c5ce48cdaf11 and https://github.com/coolaj86/node-install-script/commit/1445f20fca9dc2e14db7b3f4a4e1d21281200f76


aether vs. coursier discrepancies

I found a simple example of a pretty large discrepancy between the artifacts discovered by coursier vs. aether resolverTypes, where I think aether actually gets it right(er). I've got a complete example with outputs in a gist
The story revolves around com.sun.xml.ws:jaxws-rt:2.2.10. If you follow the trail of maven ancestor poms high enough, you'll eventually find exclusions of several dependencies. For example (full pom):

javax.activation:activation
javax.xml.stream:stax-api,
com.sun.istack:istack-commons-runtime
com.sun.xml.txw2:txw2

Looking at the coursier and aether outputs in the gist you can see that those artifacts aren't included in aether, but are in coursier (the exception is that istack-commons-runtime is also included in aether, which based on a comment in the pom I think was intentional -- it's allowing a different dep path to determine the version. Although istack-commons-runtime actually doesn't show up in our maven-only dep graph at all, so maybe there's a bug in aether there too, or maybe we have an exclusion somewhere else that's preventing it. I haven't dug in far enough to know for sure).
In this specific case, I think I can use bazel-deps excludes w/ coursier resolverType to achieve the correct(ish) effect, but I'm not sure if this is something that coursier is doing, or if there's code in bazel-deps' coursier usage that could be causing this discrepancy. In a scenario where we have other things that depend on the same things that jaxws-rt depends on, I can understand the dep graph not matching exactly, but it seems like for the single-dependency case, it should?
LMK if there's more information I can provide.
Thanks!

It would be interesting to run this down. If you see an error, maybe we can find a way to show it in the coursier command line tool and report the error there.
If it is only us seeing it, that would be good to know that it is internal to our code.
We may be ignoring exclusions in our code here:
https://github.com/johnynek/bazel-deps/blob/master/src/scala/com/github/johnynek/bazel_deps/CoursierResolver.scala#L197
maybe we need to consult the exclusions from Coursier:
https://github.com/coursier/coursier/blob/master/core/shared/src/main/scala/coursier/core/Definitions.scala#L50
If we look at the exclusions, and not walk those edges, that might be correct.
Are you interested in trying to write a failing test that we see this exclusion, then see if we can fix the test by consulting the exclusion in the Dependency?


Support conversion / round-tripping of custom FRESH/JRS fields

FRESH and JRS both allow custom properties (not declared in the schema) to be placed on resume sections or sub-objects. The FRESH-to-JRS and JRS-to-FRESH conversion should carry these properties over.

Via hacksalot/HackMyResume#113.

For a FRESH to JRS 0.0.0 conversion, tuck FRESH sections (that aren't contained in JRS) into basics.fresh, then pull them out when going the opposite way. Can't insert them at the root level (in JRS 0.0.0) because of schema violations.


@mmiele doc clean up

Read through the docs and check for grammar, spelling, typography, tone, and voice.
Useful Resources:

Microsoft Writing Style Guide
Docs contributor guide
Docs Authoring Pack VSCode extension

ToDo:

[x] v4sdk/migration/migration-overview.md. Fixed in https://github.com/MicrosoftDocs/bot-docs-pr/pull/2518.
[x] v4sdk/bot-builder-concept-cross-train.md. Fixed in https://github.com/MicrosoftDocs/bot-docs-pr/pull/2518.
[x] bot-service-resources-bot-framework-faq.md. Fixed in https://github.com/MicrosoftDocs/bot-docs-pr/pull/2518.
[x] v4sdk/bot-builder-dialog-manage-conversation-flow.md
[x] bot-service-encryption.md
[x] v4sdk/bot-builder-concept-adaptive-dialog-generators.md
[x] v4sdk/bot-builder-concept-identity-providers.md
[x] bot-service-troubleshoot-bot-configuration.md
[x] directline-speech-bot.md
[x] rest-api/bot-framework-rest-connector-concepts.md
[ ] v4sdk/bot-builder-concept-dialog.md
[ ] bot-service-manage-speech-priming.md
[ ] rest-api/bot-framework-rest-connector-add-rich-cards.md
[ ] v4sdk/bot-builder-dialog-manage-complex-conversation-flow.md
[ ] v4sdk/bot-builder-telemetry-QnAMaker.md
[ ] bot-service-troubleshoot-index.md
[ ] bot-service-build-continuous-deployment.md
[ ] bot-service-resources-faq-general.md
[ ] what-is-new.md
[ ] language-generation/bot-builder-howto-use-lg-custom-functions.md
[ ] rest-api/bot-framework-rest-connector-quickstart.md
[ ] rest-api/bot-framework-rest-connector-api-reference.md
[ ] adaptive-dialog/adaptive-dialog-prebuilt-triggers.md
[ ] bot-service-design-principles.md
[ ] v4sdk/bot-builder-howto-v4-luis.md
[ ] bot-service-troubleshoot-500-errors.md
[ ] bot-service-channel-connect-skype.md
[ ] rest-api/bot-framework-rest-direct-line-1-1-receive-messages.md
[ ] bot-service-channels-reference.md
[ ] v4sdk/bot-builder-concept-adaptive-dialog-declarative.md
[ ] v4sdk/bot-builder-adaptive-dialog-setup.md
[ ] v4sdk/bot-builder-howto-handle-user-interrupt.md
[ ] v4sdk/migration/net-migration-quickreference.md
[ ] v4sdk/migration/javascript-user-state-using.md
[ ] rest-api/bot-framework-rest-direct-line-1-1-send-message.md
[ ] bot-service-manage-overview.md
[ ] bot-service-channel-connect-email.md
[ ] adaptive-dialog/adaptive-dialog-prebuilt-memory-states.md
[ ] v4sdk/bot-builder-concept-language-generation.md
[ ] rest-api/bot-framework-rest-direct-line-3-0-receive-activities.md
[ ] v4sdk/bot-builder-webchat-overview.md
[ ] rest-api/bot-framework-rest-direct-line-3-0-send-activity.md
[ ] file-format/bot-builder-lu-file-format.md

Closing, will track doc clean up elsewhere.


Regression Task

Thanks for awesome work.
I'm using a tabular dataset for a regression task. I would like to predict the last column (float values) in the picture below.

I'm not sure how should I setup network and esp these two parameters:
categories = tuple(cat_dims),
num_continuous = len(con_idxs)

For now I'm using
con_idxs = [0,1,2,3,4,5,6,7,8,9,10,11,12,13,14,15,16,17,18,19,20,21]

If I change the last column values to int using train[target] = train[target].astype(int) and use the following as cat dims it starts training but I want to predict floating values.
cat_dims = np.append(np.array(cat_dims),np.array([50])).astype(int)

If I dont convert target to int it throws following error:
 return torch.embedding(weight, input, padding_idx, scale_grad_by_freq, sparse)
RuntimeError: Expected tensor for argument #1 'indices' to have one of the following scalar types: Long, Int; but got torch.DoubleTensor instead (while checking arguments for embedding)
``

I have changed few things:
cat_idxs = [10,11,14,15,16,17,18,19,20,21]
con_idxs = [0,1,2,3,4,5,6,7,8,9,12,13]

Also, Instead of changed train[target] to int, I have changed x_categ and cat_mask_temp data types to int in
embed_data_mask(x_categ, x_cont, cat_mask, con_mask,model,vision_dset=False)
Now network seems to be learning on float predictions but I am still not sure about following line:
cat_dims = np.append(np.array(cat_dims),np.array([50])).astype(int)
Please let me know what do you think about these settings.

Hi, Sorry for the late reply. We will include the regression case in the next version. We will be releasing it soon, please stay tuned.

Hello, I have just pushed the latest version of the code with the regression case too. Closing this issue for now. Raise another issue if you face problems with the new version.


(FACT-1740) Update the filesystem resolver to skip AHAFS

The /aha filesystem is a for the AIX event infrastructure, and the filesystem
reports 0 size, but several blocks in use. This commit filters out AHAFS in
the same way we filter out PROCFS.

I will run a build to ensure this will not produce errors

Typo in commit message: "...is a for..."

Updated

I'm :+1: once you get a build through

Build completed successfully on AIX 6.1

CLA signed by all contributors.


Error on launching app

I've tried to use your app to generate a png set of icons :
(I've installed the package through npm.)
$ ./font-awesome-svg-png.js --color e85500 --sizes 40 --dest e85500/

But I have the following error: (I've updated the ./font-awesome-svg-png.js to trace the errors)
Trace: Caught error [TypeError: Cannot read property 'charCodeAt' of undefined]
    at /home/fguerin/Projects/Font-Awesome-SVG-PNG/font-awesome-svg-png.js:76:11
    at tryCatcher (/home/fguerin/Projects/node_modules/font-awesome-svg-png/node_modules/bluebird/js/main/util.js:26:23)
    at Promise._settlePromiseFromHandler (/home/fguerin/Projects/node_modules/font-awesome-svg-png/node_modules/bluebird/js/main/promise.js:510:31)
    at Promise._settlePromiseAt (/home/fguerin/Projects/node_modules/font-awesome-svg-png/node_modules/bluebird/js/main/promise.js:584:18)
    at Async._drainQueue (/home/fguerin/Projects/node_modules/font-awesome-svg-png/node_modules/bluebird/js/main/async.js:128:12)
    at Async._drainQueues (/home/fguerin/Projects/node_modules/font-awesome-svg-png/node_modules/bluebird/js/main/async.js:133:10)
    at Immediate.Async.drainQueues [as _onImmediate] (/home/fguerin/Projects/node_modules/font-awesome-svg-png/node_modules/bluebird/js/main/async.js:15:14)
    at processImmediate [as _immediateCallback] (timers.js:383:17)

I'm on a debian testing:
$ node --version
v4.6.1

Try locking down the dependencies version in package.json.
  "dependencies": {
    "bluebird": "2.9.13",
    "extend": "1.2.1",
    "font-awesome": "4.5.0",
    "graceful-fs": "2.0.1",
    "lodash.indexby": "3.0.0",
    "mkdirp": "0.5.0",
    "optimist": "0.6.0",
    "svgo": "0.4.4",
    "xml2js": "0.4.5"
  }

I'm also getting this error.  The change to package.json did not work.

Mac OS X El Capitan (10.11.6), Node version 4.4.3.

Correction, I believe this will work, but in order for the "fix" to work, you can't use the "binary" in your path.  You have to call it directly using Node.
Will not work:
font-awesome-svg-png --list

Will work:
node font-awesome-svg-png.js --list

I had this problem again and searched to find my own answer.  Hence the self-directed-thumbs-up. :)

FYI, this "fix" applies to not just the --list command, but others also, like:
node font-awesome-svg-png.js --color 00adf2 --sizes 512

Please see latest changes. I apologize for not attending to this repo. Hopefully this latest update amends my absence.


Create feature Change Category Top Headlines News

Codecov Report

Merging #25 into dev-v2.0.0 will not change coverage.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##           dev-v2.0.0       #25   +/-   ##
============================================
  Coverage      100.00%   100.00%
============================================
  Files              13        13
  Lines             159       173   +14
============================================
+ Hits              159       173   +14

Impacted Files
Coverage Δ

...bloc/topheadlinesnews/top_headlines_news_bloc.dart
100.00% <100.00%> (ø)

...loc/topheadlinesnews/top_headlines_news_event.dart
100.00% <100.00%> (ø)

...loc/topheadlinesnews/top_headlines_news_state.dart
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 89418a8...2e5c87f. Read the comment docs.


[BEAM-8294] reuse Spark context

In #8444, I set reuse to false because it seemed to partially alleviate memory constraints. However, I later discovered that #8722 was the main culprit behind the memory issues. I want to see if reusing the Spark context is okay now, and if helps the tests run faster.

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Choose reviewer(s) and mention them in a comment (R: @username).
[ ] Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

Run Java Spark PortableValidatesRunner Batch

Looks like this still causes memory errors.


Got the wired suggest in Tact code in codeblock.

Shows as this, when I coding in Tact it will suggest out of aspect suggestion in Tact code.

What do you mean exactly? What do you offer to change? The methods are available with the right parameters - https://docs.tact-lang.org/language/ref/common#contractaddress
Please, specify more information or explain offered modifications in this behaviour.

No information was added. Please, reopen it with an certain offer if this issue is still actual. Thank you.


Fix release process via GitHub Actions

After the big module refactoring, the release deployment broke: https://github.com/cbeust/testng/blob/master/.github/workflows/publish-maven-central.yml#L35-L42
An option is something like
https://github.com/allure-framework/allure2/blob/430255d8cf5c236ed29bc0df0b72dcd9389c3df9/.github/workflows/release.yaml

Check https://github.com/shipkit

This is taken care of and the release 7.6.0 was done by following the below steps

Go to https://github.com/cbeust/testng/actions
Choose https://github.com/cbeust/testng/actions/workflows/publish-maven-central.yml
Provide an appropriate RC number as per screenshot below
After the job runs to completion, login to the Nexus Manager portal https://oss.sonatype.org/#welcome using sonatype credentials.
From Staging repositories view, find TestNG staged repository and release it ( https://oss.sonatype.org/#stagingRepositories )


Number trending icon with difference

Q
A

New sample?
Yes

What's in this Pull Request?
Adding new column formatting sample that displays a trending icon and the numeric value difference between two compared numeric values. The value difference will display as +/- accordingly.
Thanks for your contribution! Sharing is caring.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: PopWarner sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.


Only prevent default on mousewheel event when trying to zoom within the scaleExtent

fixes https://github.com/mbostock/d3/issues/2549

@mbostock I notice you closed the issue relating to this PR.  Is there anything I need to update before we merge?

The only reason I closed the issue is that this pull request is sufficient to track the request.
Concerns with this change:

A mousewheel event could initiate a change from an allowed scale extent to a disallowed scale extent, and in that case, we want to clamp the new scale extent to the minimum or maximum allowed value and still prevent default on the extent. (Your implementation appears to only check the new value, and not whether it is different from the current value.) For example, if the scale is clamped in [1, 10], and a mousewheel would change the scale from 8 to 12, then we want to change it to 10 and prevent default.

I’m not totally sure the logic is right. For example, this still sets the mousewheelTimer even when the mousewheel event is going to be ignored. The zoom behavior event handling logic is complicated, so it’ll require some thought.

I haven’t decided whether the zoom behavior should always behave this way, or whether it should be something that the user can enable. Probably it would be reasonable to just make it always behave this way, and consider it a bug fix.

This has been implemented in d3-zoom for D3 4.0.


Adding negative revalidating AuTests.

Since this is a test-only change that verifies behavior that currently works, this change has no production risk. I'm therefore adding this for inclusion in the various 9.x projects.

Cherry-picked to v9.0.x branch.
Cherry-picked to v9.1.x branch.
@bneradt Thanks for being crystal clear as to why this should go into the release branches suggested!


[1.3.0] Regression, consoleQuick is hopelessly broken

steps
sbt version: 1.3.0

Launch sbt (as in the gif)
Type consoleQuick (it does not matter if you type other things beforehand)

problem
Unable to type in consoleQuick
expectation
Ability to type in consoleQuick
notes
This appears to be directly related to supershell, as -Dsbt.supershell=false makes consoleQuick work again.

@blast-hardcheese Thanks for the report!

I'm not able to reproduce this in sbt 1.8.2.


In Tutorials the ccs style .line-highlight is not working well now.

Recently the css style .line-highlight is not working well in Tutorials. Thanks a lot if anyone can fix it.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 3ad06677-5842-c1aa-153f-7993a9660dfa
Version Independent ID: 8daf79df-eac4-358b-e6f0-6def45bd54da
Content: Tutorial: Get started with EF Core in an ASP.NET MVC web app
Content Source: aspnetcore/data/ef-mvc/intro.md
Product: aspnet-core
Technology: aspnetcore-data
GitHub Login: @Rick-Anderson
Microsoft Alias: tdykstra

I'm sorry for the inconvenience. This is a system wide problem that's tracked in https://github.com/aspnet/AspNetCore.Docs/issues/13143.


Javascript hangs

Describe the bug
Please provide as much information as you can.
Please complete the following:
Which version of .NET Interactive are you using? (In a notebook, run the #!about magic command. ):
Actually could not get the #!about command to work...

Extension indicates v1.0.4509030. I have uninstalled and reinstalled it to check if my setup was faulty; no effect.

OS

[ ] Windows 11
[ ] Windows 10
[x] macOS (Sonoma)
[ ] Linux (Please specify distro)
[ ] iOS
[ ] Android

Browser

[ ] Chrome
[ ] Edge
[ ] Firefox
[ ] Safari

Frontend

[ ] Jupyter Notebook
[ ] Jupyter Lab
[ ] nteract
[x] Visual Studio Code
[ ] Visual Studio Code Insiders
[ ] Visual Studio
[ ] Other (please specify)

Screenshots
If applicable, add screenshots to help explain your problem.
Javascript cells seem to hang infinitely. I have been able to get this cell to trigger maybe 1/10 times, with each time:

Restart VS Code
Create new blank Polyglot notebook
Add a JS cell, or use JS by default
Try to execute code in the JS cell

I am able to reproduce this issue (and the one re: !#about) with Windows 11 via Parallels (completely fresh VSC install), and a machine running MacOS Ventura as well.
I am unable to reproduce either of the issues when running the previous release - Version: 1.0.446104+34cc09c68f37568da9c8151ba5c51d264d0375d5

New release done, js bug is address. will open one to track the #!about

A fix for the above hang was merged in #3268 and a release with this fix was just released. Could you please confirm that this works now?
The #!about issue should also be fixed now (via #3252).

Awesome - thanks much for confirming!


Adding missing kthread_wait() function to linux&mac platform

@NikolasHaaseGH Thanks for opening this! Unfortunately this was previously fixed on the 0.7.0 feature branch, which was recently merged into main. It is much appreciated though!
Closing this.


Resize CPU and Memory Resources assigned to Containers

Enable the feature，need open feature-gates: - name: InPlacePodVerticalScaling in kube-apiserver、kube-scheduler  and kubelet?

Hi, Could you please share some more details of the issue that you are facing?
/triage needs-information

/language en
/sig docs

Page related to the issue: https://kubernetes.io/docs/tasks/configure-pod-container/resize-container-resources/


Unexpected Neg behavior on Duration

This code panics in debug builds and have unexpected result in release build.
use time::Duration;

fn main() {
    let duration = Duration::MIN;
    println!("{:?}", duration);
    println!("{:?}", -duration);
}

This is because of how signed integers work. i64::MIN has no positive counterpart i.e. i64::MIN == -i64::MIN.
Meanwhile I'll add const fn checked_neg(self) method to Duration impls, it is required for other checked arithmetic, mentioned in #364 .

Actually, there's a lot of places in code where subtraction is defined via negation and add. So, this also panics in debug builds:
use time::Duration;

fn main() {
    assert_eq!(Duration::MIN - Duration::MIN, Duration::ZERO);
}

The panic is deliberate due to the overflow. The only real issue uncovered here is that relying on negation for implementing subtraction isn't ideal. I'll fix that be implementing it directly where appropriate, but it's not going to be a high priority for me given the unlikeliness of running into it in the wild.


On 0.4, I'm getting Module build failed: Error: A valid query string passed to parseQuery should begin with '?'

ERROR in ./shape-react-core/~/svg-react-loader/lib/loader.js?name=Icon!./shape-react-core/images/books.svg
Module build failed: Error: A valid query string passed to parseQuery should begin with '?'
    at Object.parseQuery (/Users/jameydeorio/dev/orm/frontend/node_modules/loader-utils/lib/parseQuery.js:13:9)
    at Object.svgReactLoader (/Users/jameydeorio/dev/orm/frontend/shape-react-core/node_modules/svg-react-loader/lib/loader.js:25:28)

Webpack config:
{
        test: /\.svg$/,
        exclude: /node_modules/,
        loader: 'svg-react'
      }

Import statement:
import Icon from 'svg-react?name=Icon!../../images/books.svg'

I've just ran into the same issue. +1

FWIW I was hitting this same issue with 0.3 under certain configurations as well.

Same issue. Is there a workaround?

@jameydeorio  thats because the you are not passing a query parameter at all to webpack
https://github.com/jhamlet/svg-react-loader/blob/version-0.4.0/README.md#examples
Anyhow, then I get Module build failed: TypeError: query.substr is not a function

For anyone coming here: obviously this project is long time abandoned.
I suggest everyone migrate to<EMAIL_ADDRESS>https://github.com/boopathi/react-svg-loader
The webpack config stays the same, just svg-react-loader string is replaced by react-svg-loader.

For anyone who read my previous comment about migrating to react-svg-loader – I'm migrating back to this library.
The reason is that react-svg-loader feels less convenient (and apparently has bugs) and this library's author has finally fixed this issue.


[Java] Distributed mode support

Describe the problem
Is there any plan to add distributed mode to the Java API? I checked the code and it seems to be doable (unless I missed something) so I was wondering if anyone is already working on it? I went through the issue tracker and PRs but couldn't find anything related.

The Java API is focused on inference, where distributed mode is usually not relevant.  Do you have an application?

@girving I wanted to create and train the model using the Java API instead of having to train in Python, save the graph file and then load it using the Java API. Would make the whole workflow much easier if I could do it from the same tech stack.
I can have a look at how hard it's to implement and make a PR (if it's doable), but my question is would such a PR have any chance of being accepted or are you set on only inference and keeping the Java API minimal?

@asimshankar and @mrry: Can you comment?  My naive hunch is that distributed support is fairly straightforward; just a matter of adding another parameter to the Session constructor.  Except, of course, that one has to arrange for all the processes to exist and connect.  However, I'm not sure how useful it will be given the Java API's lack of graph construction support.

Yes, it looks like the bindings in Session.java are missing the equivalent of a target argument. For a pure-Java solution, we'd also want some bindings for the equivalent of Python's tf.train.Server, which should be fairly easy to add—but right now they are part of the "no stability guarantees" C++ API, rather than the stable C API.

Cool, thanks @girving and @mrry  - I was mostly worried that some parts of the distributed impl were only done in Python and I missed them. I'll put something together since I need it for myself and PR, then you can decide if you want it or not.

If you might submit a PR, I'll reopen this and mark it contributions welcome.  It's good to have a place to track feature requests.


chore: prepare for ownership claim

Signed-off-by: STRRL<EMAIL_ADDRESS>ready for setup Ownership Claim on Artifact Hub.
I have tried to connect the original publisher "wuxiaohui" by slack and email, but I got no response.
I think ownership claim could help us.

/cc @YangKeao @cwen0


failed to decode Base64

Ciphey failed to decipher RVJBTkcgU0VMVUFTIDgwIEVLQVIgKOKAnFByb2playB0ZXJzZWJ1dOKAnSk ,
but i could decipher it here:
https://emn178.github.io/online-tools/base64_decode.html

Hello. I'm closing this issue because the plaintext of your Base64 is ERANG SELUAS 80 EKAR (“Projek tersebut”) which is Malay for 80 ACRES OF ERANG (“The Project”) it seems. Ciphey only supports English, URLs, email addresses, phone numbers, etc.
You can read about Ciphey's checkers here: https://github.com/Ciphey/Ciphey/wiki/Checkers,-explained


iCloud integration stops working after a few HA reboots

Home Assistant release with the issue:
hassos: "3.9"
homeassistant: 0.105.1
machine: raspberrypi3
supervisor: "198"
Operating environment (Hass.io/Docker/Windows/etc.):
Hass.io
Component/platform:
https://www.home-assistant.io/integrations/icloud/
Description of problem:
I've updated Home Assistant to 0.105.1 and removed all icloud integrations via GUI and config file, additionally i removed all tokens created by icloud. I configured two accounts with icloud and both successfully set up and seem to work. After a few HA restarts the integration stopped working.
Here are the logs:
2020-02-06 14:07:42 ERROR (MainThread) [homeassistant.config_entries] Error setting up entry<EMAIL_ADDRESS>for icloud
Traceback (most recent call last):
  File "/usr/src/homeassistant/homeassistant/config_entries.py", line 215, in async_setup
    hass, self
  File "/usr/src/homeassistant/homeassistant/components/icloud/__init__.py", line 124, in async_setup_entry
    await hass.async_add_executor_job(account.setup)
  File "/usr/local/lib/python3.7/concurrent/futures/thread.py", line 57, in run
    result = self.fn(*self.args, **self.kwargs)
  File "/usr/src/homeassistant/homeassistant/components/icloud/account.py", line 124, in setup
    self.update_devices()
  File "/usr/src/homeassistant/homeassistant/components/icloud/account.py", line 168, in update_devices
    self._fetch_interval = self._determine_interval()
  File "/usr/src/homeassistant/homeassistant/components/icloud/account.py", line 239, in _determine_interval
    int(min(intervals.items(), key=operator.itemgetter(1))[1]),
ValueError: min() arg is an empty sequence
2020-02-06 14:07:48 ERROR (MainThread) [homeassistant.config_entries] Error setting up entry<EMAIL_ADDRESS>for icloud
Traceback (most recent call last):
  File "/usr/src/homeassistant/homeassistant/config_entries.py", line 215, in async_setup
    hass, self
  File "/usr/src/homeassistant/homeassistant/components/icloud/__init__.py", line 124, in async_setup_entry
    await hass.async_add_executor_job(account.setup)
  File "/usr/local/lib/python3.7/concurrent/futures/thread.py", line 57, in run
    result = self.fn(*self.args, **self.kwargs)
  File "/usr/src/homeassistant/homeassistant/components/icloud/account.py", line 124, in setup
    self.update_devices()
  File "/usr/src/homeassistant/homeassistant/components/icloud/account.py", line 168, in update_devices
    self._fetch_interval = self._determine_interval()
  File "/usr/src/homeassistant/homeassistant/components/icloud/account.py", line 239, in _determine_interval
    int(min(intervals.items(), key=operator.itemgetter(1))[1]),
ValueError: min() arg is an empty sequence

Regards
Richard

Hello, I have the same issue since the 0.104.x version.
The first integration worked well, but it never updated after that.
For information, my HA works on Docker, on NUC.

#31533 already fixes this 😉
Will be build in 0.105.2
Thanks for submitting an issue again Richard.
Never be so quick to solve an issue 😂


Pull in downstream gevent usage changes

What was wrong?
There are downstream changes in ethereum-tester-client that remove the gevent monkeypatching behavior.
How was it fixed?
Bumped the dependent version number.
Cute Animal Picture

put a cute animal picture here.

Fixes #54


RenderTexture not rendering when sprite with children has parent

I've run into a problem with Rendering to texture that I can't find a solution for.
I'm rendering a sprite to a texture, and converting that to an image to display on a different canvas.
const parent = this.app.stage.getChildByName('parentContainer');
const sprite = new PIXI.Sprite(texture1);
sprite.addChild(...);
sprite.addChild(...);
parent.addChild(sprite);
const renderTexture = PIXI.RenderTexture.create(sprite.width, sprite.height);
app.renderer.render(sprite, renderTexture);

in the above case, nothing renders. If I tell it to skipUpdateTransform=true then I see "something" but all the children are rendered at position 0,0.
const renderTexture = PIXI.RenderTexture.create(sprite.width, sprite.height, false, null, true);
The weirdest part is, if I don't add the sprite to it's parent it renders. It's hard for me to isolate what's going on here.
Environment
pixi.js 4.8.1
Browser: Chrome
OS: Windows 10

If your spirte children are in an area larger then sprite width and height, then you need to make sure the renderTexture renders that size of area.
Try setting the renderTexture area larger and see if your sprite children render.

The children are within the dimensions of the parent sprite. I tried setting the renderTexture to the stage dimensions, but it didn't make any difference.

I just noticed another oddity - when the sprite being copied has an anchor of 0.5 (centered) the texture only copies the bottom right corner. I haven't figured out how to get around that yet either.

In general, adding children to Sprite is technically possible but a bit of an anti pattern in Pixi. It’s difficult to control ordering and there no real benefit performance wise over using a vanilla Container. Unless you are using something advanced with Sprite, would strongly recommend you don’t add children too it because you’ll run into issues like this when trying to cacheAsBiitmap, RenderTexture, filters etc.

Adding childs to Sprite is fine.
I consider passing elements with existijng parent to generateTexture, and render as an anti-pattern because there are many bugs with temporary changing the parent. Also width height on element with childs is bad unless you understand what is going on under the rug, it changes transforms too , and there might be bugs with caching transforms.
The best way is to use getBounds and manual reassignment of parent, that way you are in control of those operations and buggy parts of pixi internals cant affect it.

yea I'm trying to accomplish something advanced here. I'm attempting to copy a particular pixi display object (a sprite with children) and paste it onto a separate canvas. That canvas is transparently overlaid on top of pixi's canvas so that I can place particle effects behind it.  I'm using the Proton particle system and its pixi renderer doesn't support alpha blending so I'm having to resort to this to get a good look.
Yup I also tried cacheAsBitmap and didn't have a lot of luck with that either. Not quite sure how to achieve this, I may have to drop the entire feature which would be unfortunate.

I should note I kinda had partial success when I rendered the texture out, and cached that texture before the object was added to the stage. It was still a little wonky though, I may have to try building and rendering it entirely offscreen and then using that to render the texture. There's some downloading of avatar images outside of the preloader that makes some of this hard to structure.

PIXI.RenderTexture.create(sprite.width, sprite.height, false, null, true)

those are not renderTexture poarams, that's render method params.

PIXI.RenderTexture.create(sprite.width, sprite.height, false, null, true)

those are not renderTexture params, that's render method params.

My bad, I corrected the original it was a copy/paste error.


Ignore GitHub OMERO links due to rate limiting of requests.

Also see https://github.com/sphinx-doc/sphinx/issues/7388.

Unlike the three previous builds, https://ci.openmicroscopy.org/view/Mgmt/job/CONTRIBUTING-merge-docs/1908/console showed no failure with this PR included builds :+1:
Waiting for a validation of the OMERO documentation changes in the next run of the merge CI builds.

Previous 2 runs of https://merge-ci.openmicroscopy.org/jenkins/job/OMERO-docs/ (391 and 392) were green. Merging with the hope that latest-ci goes green.


Non-Admin User rights question

Heya,
I've played a little here. It is a clean Django one with the usual pitfalls.
Here's my pain point. I am trying to define a new non-admin user that should only see/access the products listed under the products category and everything under the Findings section. However, after one hour of testing various combinations, I can't give this user the rights to submit new findings.
Here's my current rights setup:

By any chance, would I be able to achieve what I am looking after or not quite?
Thanks again!

@Hax0rG1rl yes you are right Django comes with a built-in permissions system to assign permissions to specific users and groups of users per type of object or object instance. But I customized permissions per role only.
There are by default only 2 roles (administrator and viewer). You can create more if needed, and restrict access in the code, so take a look into views.py and edit the decorator allowed_users with the roles needed.
@login_required
@allowed_users(allowed_roles=['administrator'])

Also in some templates there are some restrictions per role, for example /templates/home/aside.html:
{% if user.groups.all.0|stringformat:'s' == "administrator" %}

                Configuration

Thank you!


[5pt] Update HAND calibration for new ras2fim v2 ratings

I have a working feature branch started for this (using data for one HUC), but will wait to submit it until I can test it on all of the newly generated ras2fim outputs. I believe we're still waiting to run the updated ras2fim and produce the necessary rating curve outputs and xsection points for several ras2fim HUCs.
@RobHanna-NOAA please let me know when we have those new ras2fim output files ready.


fix: correctly disable triggers on shape GC

Shapes don't use fully qualified table names, but the functions disabling the triggers expect FQ names. So we didn't disable the triggers before. Ideally FQ names should be represented by a different type (e.g. a tuple), but that's for another day

Ideally FQ names should be represented by a different type (e.g. a tuple)

Just to note that there is already a QualifiedTablename type in utils/types.

@thruflo

Just to note that there is already a QualifiedTablename type in utils/types.
yeah, just noticed myself, but it is not applied consistently and I don't want to dig right now through all call chains to see if what works now is qualified-but-string or unqualified. I'll get back to it


Queue creation improvements

Going off my comment on Discord, a few random ideas:
It would be nice to have easier access to specific queues, or the queues that were requested in create_param::queue_info:

expose the list of queues exactly in the order of create_param::queue_info_list, something like get_queues()
(if no special queues are requested? always?) let lava try to find dedicated queues for compute and transfer (some GPUs have those, and they could potentionally be faster for async operations). this could reuse the existing functions like get_compute_queue() but then return the dedicated ones, not any queue with compute support

There's also a bug with device::create_param::queue_info::flags where it can end up creating a queue with just one of the flag bits set:
https://github.com/liblava/liblava/blob/6a3673753f192f19c9bf2cb5d6bd1a243fb87e9e/liblava/base/device.cpp#L22
which then only checks if any flag is set, not all of them:
https://github.com/liblava/liblava/blob/6a3673753f192f19c9bf2cb5d6bd1a243fb87e9e/liblava/base/physical_device.cpp#L42

🔨  created branch queue-creation

🔨  created branch queue-creation

Several hardware platforms have more than one VkQueue per queue family. This can be useful by being able to submit work to the same queue family from separate queues. While there can be advantages, it isn't necessarily better to create or use the extra queues. For specific performance recommendations, refer to hardware vendors' best practices guides.

https://github.com/KhronosGroup/Vulkan-Guide/blob/master/chapters/common_pitfalls.md#multiple-queues-per-queue-family
Does anyone have experience or information about the hardware vendors' best practices guides (links?)

I like the suggestion in 1. (first post) - should be easy doable.
And for 2. I would like to change the default behavior so that it runs like the proposal.

Several hardware platforms have more than one VkQueue per queue family. This can be useful by being able to submit work to the same queue family from separate queues. While there can be advantages, it isn't necessarily better to create or use the extra queues. For specific performance recommendations, refer to hardware vendors' best practices guides.

https://github.com/KhronosGroup/Vulkan-Guide/blob/master/chapters/common_pitfalls.md#multiple-queues-per-queue-family
Does anyone have experience or information about the hardware vendors' best practices guides (links?)

I like the suggestion in 1. (first post) - should be easy doable.
And for 2. I would like to change the default behavior so that it runs like the proposal.

Re: 2. I think a sensible implementation would still expose the default queue, but maybe put any found dedicated queues at the front of the list.
E.g. requesting:

GRAPHICS | COMPUTE | TRANSFER
COMPUTE
TRANSFER
becomes:

graphics_queues: [1]
compute_queues: [2, 1]
transfer_queues: [3, 1]

Re: 2. I think a sensible implementation would still expose the default queue, but maybe put any found dedicated queues at the front of the list.
E.g. requesting:

GRAPHICS | COMPUTE | TRANSFER
COMPUTE
TRANSFER
becomes:

graphics_queues: [1]
compute_queues: [2, 1]
transfer_queues: [3, 1]

Here are some examples how to use add_queues
    app.manager.on_create_param = [](device::create_param& param) {
        param.set_default_queues(); // (1)

        param.set_all_queues(); // (2)

        param.add_dedicated_queues(0.5f); // (3)

        param.add_queues(VK_QUEUE_COMPUTE_BIT | VK_QUEUE_TRANSFER_BIT, 2); // (4)

        param.add_queue(VK_QUEUE_COMPUTE_BIT | VK_QUEUE_TRANSFER_BIT); // (5)
        param.add_queue(VK_QUEUE_COMPUTE_BIT | VK_QUEUE_TRANSFER_BIT); // (6)

        param.add_queues(VK_QUEUE_COMPUTE_BIT, 2); // (7)

        param.add_queue(VK_QUEUE_COMPUTE_BIT);  // (8)
        param.add_queue(VK_QUEUE_TRANSFER_BIT);  // (9)
    };

This is the default handling, even if you do not specify param
Shows how to set all queues, param can still be adjusted afterwards
And this will add all dedicated queues, if any are available, else will return false
Shows how to add a specific combination of 2 queues (same queue family)
But it 4. fails because you don't get it from one queue family, you can still call...
... it twice and hopefully get it from different queue families
Just a simple example how to request 2 dedicated queues with one flag
Well, now back to your last post: If you just set this line and...
... that of course, it will add the 2 dedicated queues to the front of the list 🤠

Added some tests in lava-unit, check tests/unit.cpp

Here are some examples how to use add_queues
    app.manager.on_create_param = [](device::create_param& param) {
        param.set_default_queues(); // (1)

        param.set_all_queues(); // (2)

        param.add_dedicated_queues(0.5f); // (3)

        param.add_queues(VK_QUEUE_COMPUTE_BIT | VK_QUEUE_TRANSFER_BIT, 2); // (4)

        param.add_queue(VK_QUEUE_COMPUTE_BIT | VK_QUEUE_TRANSFER_BIT); // (5)
        param.add_queue(VK_QUEUE_COMPUTE_BIT | VK_QUEUE_TRANSFER_BIT); // (6)

        param.add_queues(VK_QUEUE_COMPUTE_BIT, 2); // (7)

        param.add_queue(VK_QUEUE_COMPUTE_BIT);  // (8)
        param.add_queue(VK_QUEUE_TRANSFER_BIT);  // (9)
    };

This is the default handling, even if you do not specify param
Shows how to set all queues, param can still be adjusted afterwards
And this will add all dedicated queues, if any are available, else will return false
Shows how to add a specific combination of 2 queues (same queue family)
But it 4. fails because you don't get it from one queue family, you can still call...
... it twice and hopefully get it from different queue families
Just a simple example how to request 2 dedicated queues with one flag
Well, now back to your last post: If you just set this line and...
... that of course, it will add the 2 dedicated queues to the front of the list 🤠

Added some tests in lava-unit, check tests/unit.cpp

Awesome, thanks for putting in the time to work on this 🙏
I'm busy with something else currently, but I'll check this out and report back over the weekend.

Awesome, thanks for putting in the time to work on this 🙏
I'm busy with something else currently, but I'll check this out and report back over the weekend.

 No hurry, if something stands out when testing, just let me know.

 No hurry, if something stands out when testing, just let me know.

Just took a look at your additions, and they're great. 👌
I think that the dedicated queue stuff could use some changes, however. Currently it assumes anything but the first queue family is special, but the Vulkan spec makes no guarantees about the order.
What I have in mind is something like this:
// finds a queue family that has compute, but no graphics bit
// return false if there is no such queue family
param.add_dedicated_queue(VK_QUEUE_COMPUTE_BIT, 0.5f); // and [...]_queues() to create multiple queues
// finds a queue family that has transfer but no graphics or compute
param.add_dedicated_queue(VK_QUEUE_TRANSFER_BIT, 0.5f);

and probably remove the old add_dedicated_queues. Might also be worth supporting VK_QUEUE_GRAPHICS_BIT without compute, but that should be it. Combinations of flags for dedicated queues don't really make sense.
I don't know if sorting is still required, depending on how queues are added to params. device::create pushes queues to the front of the graphics/compute/transfer_queue_list but if in the example above the two calls were switched (transfer added before compute), this would happen:

graphics: [default]
compute: [dedicated_compute, default]
transfer: [dedicated_compute, dedicated_transfer, default]

Or maybe it's ok to expect the user to know that the last queue added with a specific bit will be at the front of that list 🤷


Update default starter

Makes less ecommerce focused and more general
Adds a readme with next steps and docs lead-ins
Add some stubs for prerendering
Add some stubs for prefetch and deepfetch

@ianand @tristanlee85 - I can't add reviewers to the PR.

@jeffpatzer after digging into the code, it looks like this repo is no longer referenced. The templates are located at https://github.com/layer0-docs/layer0-templates. Could you apply your changes to that repo? Sorry for the confusion.

https://github.com/layer0-docs/layer0-templates/pull/2


Multiqueue fixes

THis PR builds on #972 and fixes a few errors.  With this, running the icmp_on_fail.conf on 83:00.{0,1} like this:
$ make && sudo ./snabb lwaftr run --name lwaftr --cpu 7-11 --conf program/lwaftr/tests/data/icmp_on_fail.conf --v4 83:00.0 --v6 83:00.1

I can then get the config:
$ make && sudo ./snabb config get lwaftr /softwire-config/instance
make: 'snabb' is up to date.
{
  device 83:00.0;
  queue {
    id 0;
    external-interface {
      device 83:00.1;
      ip <IP_ADDRESS>;
      mac 12:12:12:12:12:12;
      next-hop {
        mac 68:68:68:68:68:68;
      }
    }
    internal-interface {
      ip 8:9:a:b:c:d:e:f;
      mac 22:22:22:22:22:22;
      next-hop {
        mac 44:44:44:44:44:44;
      }
    }
  }
}

And add an RSS worker:
$ cat second-queue.conf
{
  id 1;
  external-interface {
    device 83:00.1;
    ip <IP_ADDRESS>;
    mac 12:12:12:12:12:12;
    next-hop {
      mac 68:68:68:68:68:68;
    }
  }
  internal-interface {
    ip 8:9:a:b:c:d:e:f;
    mac 22:22:22:22:22:22;
    next-hop {
      mac 44:44:44:44:44:44;
    }
  }
}

$ make && sudo ./snabb config add lwaftr /softwire-config/instance[device=83:00.0]/queue < second-queue.conf
make: 'snabb' is up to date.
lib/yang/binary.lua:159: attempt to index local 'data' (a nil value)

OK so weird error there, need to look into it.  However:
$ sudo ./snabb ps
2875
19769
20061
24491
25025	[lwaftr] * [schema: snabb-softwire-v2]
  \- 25031   worker for 25025
  \- 25175   worker for 25025

$ make && sudo ./snabb config get lwaftr /softwire-config/instance
make: 'snabb' is up to date.
{
  device 83:00.0;
  queue {
    id 0;
    external-interface {
      device 83:00.1;
      ip <IP_ADDRESS>;
      mac 12:12:12:12:12:12;
      next-hop {
        mac 68:68:68:68:68:68;
      }
    }
    internal-interface {
      ip 8:9:a:b:c:d:e:f;
      mac 22:22:22:22:22:22;
      next-hop {
        mac 44:44:44:44:44:44;
      }
    }
  }
  queue {
    id 1;
    external-interface {
      device 83:00.1;
      ip <IP_ADDRESS>;
      mac 12:12:12:12:12:12;
      next-hop {
        mac 68:68:68:68:68:68;
      }
    }
    internal-interface {
      ip 8:9:a:b:c:d:e:f;
      mac 22:22:22:22:22:22;
      next-hop {
        mac 44:44:44:44:44:44;
      }
    }
  }
}

I think the error in binary.lua might be significant, because I tried to run this with a modified icmp_on_fail.conf with the extra queue and in that case it fails to bring up the lwaftr. Seems to get added with config add but maybe the extra queue isn't running correctly in that case.
(also trying to run this led me to find some bugs in the intel_mp part, which I'm fixing now. BTW, I also think the multiqueue code should set poolnum for the driver---otherwise new queues would get assigned to new VMDq pools instead of attaching to an existing pool)

Sorry for the inconvenience but I rebased this one due to rebase in #972.  Previous build failure log here: https://gist.github.com/lwaftr-igalia/eff75040758a2296c47470ed8a240ca4