v1.3.0 Terminal now requires 160 cols/50 rows

The readme no longer matches the required columns and rows needed to display the dashboard.
Previously I was able to view the dashboard with a fullscreen terminal, however I now need to reduce my text size to see it.
The readme says:

For optimal results, it's recommended to use a terminal with:

True Color (24-bit) support;
at least 102 columns and 35 rows.

However on v1.3.0 dashboard now says:

❌ Need at least 160 columns and 50 rows to render.
Resize terminal or press q to quit.

This may not be a bug, but either the readme needs to match the new requirement, or can the requirement be put back to 102 columns and 35 rows, where certain information is hidden at this size?

Hi @DannyJJK. Good catch!
It's an intentional change. I added player stats in 1.3.0 (https://github.com/cedricblondeau/world-cup-2022-cli-dashboard/pull/26). 160x50 is the minimum for all the components to fully render.

This is a tradeoff. I prefer making sure the dashboard provides a great user experience for specific setups (i.e. colour profile and size) over supporting more setups with rendering issues.
I just updated the README to reflect the new requirement.

However, I also want to listen to feedback. If we think the requirement is too high, then we could make some other changes.
For the rows, we could:

Set min rows back to 35
If rows < 50, hide lineups or add ability to scroll (so we don't show partial lineups)

For the columns, the lineups are now tables and each row should fit in a single line. We could:

Decrease the player column width (currently 27 cols) and truncate the player name if it does not fit
Reduce the min columns

https://github.com/cedricblondeau/world-cup-2022-cli-dashboard/blob/0b27bcf7d8dfa6ef2ac61f7257da111bcccbfc77/ui/match/match.go#L130
I'm also very open to other ideas and would welcome a PR to do implement these changes.

I mainly opened the issue as I wasn't sure if it was accidental as the readme wasn't updated and the previous version hid certain elements on a smaller size. Thanks for the explanation, I'll close this issue for now but if someone else finds this annoying then it can be re-opened


Update Etcher's slogan

I'm a co-maintainer on the Etcher project.

Thanks for submitting this update to the Etcher app!
To make it easier for our team to review and verify the quality of app submissions, we've moved all the app metadata to a new repository. See github.com/electron/electron-apps#adding-your-app for info on how to open a new pull request there. Sorry for the inconvenience, and thanks again for taking the time to submit your app. For more info on the motivation behind this change, see this pull request: https://github.com/electron/electron.atom.io/pull/616

I created a followup PR at https://github.com/electron/electron-apps/pull/12

Thankyou @zeke ! :+1:


Android API 28 version MediaScanning issue

When video recording is finished with Natcorder.
It is stored in the device.
And when I run the media scanning plugin, it means that the image file is not displayed in the gallery.
Storage is good.
There are only problems with media scanning.
And this problem only occurs in Android API version 28 or later.
I want to know if you are working well. Will it appear right in the gallery after I save it?
It seems that the problem is not updating the thumbnail.

This doesn't sound like it has anything to do with NatCorder. You have to use the SaveToCameraRoll method to copy the video to the gallery.


[PDI-17673] PDI logging UI (trash can) fails to clear log table.

@mbatchelor @bmorrise @pentaho/tatooine Please review and merge.

Build Completed
:x: This pull request has errors. They will need to be addressed before it can be accepted. See below for more details. Some links are also available below for further assistance in addressing those issues.
Build Commands
mvn -B -f 'pom.xml' -pl 'core' -P '!assemblies' -Dsurefire.runOrder=alphabetical -Daudit -amd clean install

Cleanup Commands
mvn -B -f 'pom.xml' -pl 'core' -P '!assemblies' -amd build-helper:remove-project-artifact

Changed files
  core/src/main/java/org/pentaho/di/core/database/DatabaseMeta.java
  core/src/main/java/org/pentaho/di/core/database/MariaDBDatabaseMeta.java
  core/src/main/java/org/pentaho/di/core/database/MySQLDatabaseMeta.java
  core/src/test/java/org/pentaho/di/core/database/DatabaseMetaSupportsSchemasTest.java
  core/src/test/java/org/pentaho/di/core/database/MariaDBDatabaseMetaTest.java
  core/src/test/java/org/pentaho/di/core/database/MySQLDatabaseMetaTest.java

Newly Broken Tests:
org.pentaho.di.trans.steps.mysqlbulkloader.MySQLBulkLoaderTest.testVariableSubstitution:
:red_circle: junit.framework.ComparisonFailure
junit.framework.ComparisonFailure: expected:<`some[schema`.`some]table`> but was:<`some[]table`>
	at org.pentaho.di.trans.steps.mysqlbulkloader.MySQLBulkLoaderTest.testVariableSubstitution(MySQLBulkLoaderTest.java:128)

Unit Test Coverage
These statistics help you identify how your changes have affected the coverage of the following files. If a file is not in this list, then its coverage was not affected by your changes. To get some help interpreting these metrics, please refer to Jacoco's documentation.

:warning: Coverage Changes (click to expand)
org.pentaho.di.job.entries.evalfilesmetrics.JobEntryEvalFilesMetrics

Branch Change: -0.4% :small_red_triangle_down:
Complexity Change: -0.5% :small_red_triangle_down:
Instruction Change: -0.1% :small_red_triangle_down:

org.pentaho.di.job.entries.ftpsget.JobEntryFTPSGet

Branch Change: -0.6% :small_red_triangle_down:
Complexity Change: -0.5% :small_red_triangle_down:
Instruction Change: -0.1% :small_red_triangle_down:

org.pentaho.di.job.entries.getpop.MailConnectionMeta

Branch Change: -1% :small_red_triangle_down:
Complexity Change: -1.5% :small_red_triangle_down:
Instruction Change: -0.3% :small_red_triangle_down:

org.pentaho.di.trans.steps.calculator.CalculatorMetaFunction

Branch Change: -8.7% :small_red_triangle_down:
Complexity Change: -3% :small_red_triangle_down:
Instruction Change: -0.7% :small_red_triangle_down:
Line Change: -0.9% :small_red_triangle_down:

org.pentaho.di.trans.steps.dimensionlookup.DimensionLookupMeta

Branch Change: -1.8% :small_red_triangle_down:
Complexity Change: -1.1% :small_red_triangle_down:
Instruction Change: -0.4% :small_red_triangle_down:
Line Change: -0.3% :small_red_triangle_down:

org.pentaho.di.trans.steps.ifnull.IfNullMeta

Branch Change: -2% :small_red_triangle_down:
Complexity Change: -1.9% :small_red_triangle_down:
Instruction Change: -0.2% :small_red_triangle_down:

org.pentaho.di.trans.steps.memgroupby.MemoryGroupByMeta

Branch Change: -1.1% :small_red_triangle_down:
Complexity Change: -1.3% :small_red_triangle_down:

org.pentaho.di.trans.steps.singlethreader.SingleThreaderMeta

Instruction Change: -0.1% :small_red_triangle_down:

org.pentaho.di.trans.steps.symmetriccrypto.symmetriccryptotrans.SymmetricCryptoTransMeta

Branch Change: -3.3% :small_red_triangle_down:
Complexity Change: -1.8% :small_red_triangle_down:
Instruction Change: -0.3% :small_red_triangle_down:

org.pentaho.di.ui.repository.pur.repositoryexplorer.model.UISecurityRole

Branch Change: -1.8% :small_red_triangle_down:
Complexity Change: -1.5% :small_red_triangle_down:
Instruction Change: -0.2% :small_red_triangle_down:
Line Change: -0.5% :small_red_triangle_down:

Build Completed
:fire: This pull request has some issues. It would be preferable to fix them in order for it to be just perfect. See below for more details. Some links are also available below for further assistance in addressing those issues.
Build Commands
mvn -B -f 'pom.xml' -pl 'engine,core' -P '!assemblies' -Dsurefire.runOrder=alphabetical -Daudit -amd clean install

Cleanup Commands
mvn -B -f 'pom.xml' -pl 'engine,core' -P '!assemblies' -amd build-helper:remove-project-artifact

Changed files
  core/src/main/java/org/pentaho/di/core/database/DatabaseMeta.java
  core/src/main/java/org/pentaho/di/core/database/MariaDBDatabaseMeta.java
  core/src/main/java/org/pentaho/di/core/database/MySQLDatabaseMeta.java
  core/src/test/java/org/pentaho/di/core/database/DatabaseMetaSupportsSchemasTest.java
  core/src/test/java/org/pentaho/di/core/database/MariaDBDatabaseMetaTest.java
  core/src/test/java/org/pentaho/di/core/database/MySQLDatabaseMetaTest.java
  engine/src/test/java/org/pentaho/di/trans/steps/mysqlbulkloader/MySQLBulkLoaderTest.java

Unit Test Coverage
These statistics help you identify how your changes have affected the coverage of the following files. If a file is not in this list, then its coverage was not affected by your changes. To get some help interpreting these metrics, please refer to Jacoco's documentation.

:warning: Coverage Changes (click to expand)
org.pentaho.di.trans.steps.checksum.CheckSumMeta

Branch Change: -1.3% :small_red_triangle_down:
Complexity Change: -1.4% :small_red_triangle_down:
Instruction Change: -0.2% :small_red_triangle_down:

org.pentaho.di.core.injection.bean.BeanInjector

Branch Change: -0.8% :small_red_triangle_down:
Complexity Change: -1.1% :small_red_triangle_down:

org.pentaho.di.job.entries.evalfilesmetrics.JobEntryEvalFilesMetrics

Branch Change: -0.4% :small_red_triangle_down:
Complexity Change: -0.5% :small_red_triangle_down:
Instruction Change: -0.1% :small_red_triangle_down:

org.pentaho.di.job.entries.getpop.MailConnectionMeta

Branch Change: -1% :small_red_triangle_down:
Complexity Change: -1.5% :small_red_triangle_down:
Instruction Change: -0.3% :small_red_triangle_down:

org.pentaho.di.job.entries.waitforsql.JobEntryWaitForSQL

Branch Change: -0.8% :small_red_triangle_down:
Complexity Change: -1% :small_red_triangle_down:
Instruction Change: -0.1% :small_red_triangle_down:

org.pentaho.di.trans.steps.groupby.GroupByMeta

Branch Change: -1% :small_red_triangle_down:
Complexity Change: -1.1% :small_red_triangle_down:
Instruction Change: -0.2% :small_red_triangle_down:
Line Change: -0.3% :small_red_triangle_down:

org.pentaho.di.trans.steps.singlethreader.SingleThreaderMeta

Instruction Change: -0.1% :small_red_triangle_down:

org.pentaho.di.trans.steps.sort.SortRowsMeta

Instruction Change: -0.1% :small_red_triangle_down:

org.pentaho.di.trans.steps.symmetriccrypto.symmetriccryptotrans.SymmetricCryptoTransMeta

Branch Change: -3.3% :small_red_triangle_down:
Complexity Change: -1.8% :small_red_triangle_down:
Instruction Change: -0.3% :small_red_triangle_down:

org.pentaho.di.trans.steps.salesforceinsert.SalesforceInsertMeta

Instruction Change: -0.1% :small_red_triangle_down:

org.pentaho.di.trans.steps.salesforceupsert.SalesforceUpsertMeta

Instruction Change: -0.1% :small_red_triangle_down:


Bug: I cannot get the excluded properties in the Collaboration Plugin to work

I've created a custom TextNode which has an onclick dom attribute.
Everything works as expected until I add the collaboration plugin.
I noticed that there is now an ExcludedProperties prop in the CollaborationPlugin which I believe will solve my issues (yjs throws an error when trying to sync attributes that are not values.
Here is how I declared the createDom function in my plugin:
`  createDOM(config: EditorConfig): HTMLElement {
const dom = super.createDOM(config);
dom.className = "page-link";
dom.style.cursor = "pointer";
dom.style.color = "#F87C1D";
dom.onclick = () => { this.GotoPage(this.__page) }
return dom;
}
exportDOM(): DOMExportOutput {
const element = document.createElement("span");
element.setAttribute("data-lexical-page", this.__text);
element.textContent = this.__text;
return { element };
}
GotoPage = async (page: string) => {
var openner = window.opener;
if (openner) {
openner.postMessage(
JSON.stringify({
doc_id: "",
action: "gotopage",
page: page,
}),
serverIP
);
}
};`
Here is how I declared my ExludedProperties map:
` const CollabExculudedProperties: ExcludedProperties = new Map<
Klass,
Set

([[PageLinkNode, new Set(["GotoPage", "onclick"])]]);`

I am however still getting the following error from yjs:

Any Advice on how to use/declare this prop will be great!
Thanks for the powerful library!

Well, this doesn't directly address the issue, but I would say that storing an event listener on the node like that is not the canonical way to achieve that use case. Instead, use a mutation listener to apply the event listener to the underlying DOM node:
https://lexical.dev/docs/concepts/dom-events

This is Great! I wish I has read the docs a bit more before opening this issue.
It won't be possble for me to share the full codebase for this part of our application but I will definitely be able to assist with debugging the issue even if I will not be using this approach anymore.
Just a quick question - where are the excluded properties actually used? I see it is passed into the yjs.createBinding function:

But other than that I don't see where it is used in any lexical packages.
I will add a breakpoint to the section where the properties are excluded from the sync operation once I get some guidance on where to look.
Thanks for the quick response!

Awesome - this should give you a good idea:
https://github.com/facebook/lexical/pull/4275

I've added a breakpoint over here it does not get triggered when I get this issue:

This does not seem to be where the issue is - here is the full error I am getting from react:

My "PageLinkNode" Extends TextNode so I had a look at the $createCollabTextNode function and placed a breakpoint here but it also does not get triggered:

btw the dom-events are working as expected with the NodeEventListener Plugin - thanks for that! :)
Here is the Custom Node Code:
`
import type { Spread } from "lexical";
import {
type DOMConversionMap,
type DOMConversionOutput,
type DOMExportOutput,
type EditorConfig,
type LexicalNode,
type NodeKey,
type SerializedTextNode,
$applyNodeReplacement,
TextNode,
} from "lexical";
import { serverIP } from "../../../global/globals";
export type SerializedPageLinkNode = Spread<
{
page: string;
},
SerializedTextNode

;

function convertPageLinkElement(
domNode: HTMLElement
): DOMConversionOutput | null {
const textContent = domNode.textContent;
if (textContent !== null) {
const node = $createPageLinkNode(textContent);
return {
node,
};
}
return null;
}
export class PageLinkNode extends TextNode {
__page: string;
static getType(): string {
return "page-link";
}
static clone(node: PageLinkNode): PageLinkNode {
return new PageLinkNode(node.__page, node.__text, node.__key);
}
static importJSON(serializedNode: SerializedPageLinkNode): PageLinkNode {
const node = $createPageLinkNode(serializedNode.page);
node.setTextContent(serializedNode.text);
node.setFormat(serializedNode.format);
node.setDetail(serializedNode.detail);
node.setMode(serializedNode.mode);
node.setStyle(serializedNode.style);
return node;
}
constructor(page: string, text?: string, key?: NodeKey) {
super(text ?? page, key);
this.__page = page;
}
exportJSON(): SerializedPageLinkNode {
return {
...super.exportJSON(),
page: this.__page,
type: "page-link",
version: 1,
};
}
createDOM(config: EditorConfig): HTMLElement {
const dom = super.createDOM(config);
dom.className = "page-link";
dom.style.cursor = "pointer";
dom.style.color = "#F87C1D";
dom.onclick = () => { this.GotoPage(this.__page) }
return dom;
}
exportDOM(): DOMExportOutput {
const element = document.createElement("span");
element.setAttribute("data-lexical-page", this.__text);
element.textContent = this.__text;
return { element };
}
GotoPage = async (page: string) => {
var openner = window.opener;
if (openner) {
openner.postMessage(
JSON.stringify({
doc_id: "",
action: "gotopage",
page: page,
}),
serverIP
);
}
};
static importDOM(): DOMConversionMap | null {
return {
span: (domNode: HTMLElement) => {
if (!domNode.hasAttribute("data-lexical-page")) {
return null;
}
return {
conversion: convertPageLinkElement,
priority: 1,
};
},
};
}
isTextEntity(): true {
return true;
}
}
export function $createPageLinkNode(page: string): PageLinkNode {
const pageLink = new PageLinkNode(page);
pageLink.setMode("segmented").toggleDirectionless();
return $applyNodeReplacement(pageLink);
}
export function $isPageLinkNode(
node: LexicalNode | null | undefined
): node is PageLinkNode {
return node instanceof PageLinkNode;
}
`
Here is the PageLinkNodePlugin:
`import { useLexicalComposerContext } from "@lexical/react/LexicalComposerContext";
import {
$insertNodes,
COMMAND_PRIORITY_EDITOR,
createCommand,
LexicalCommand,
} from "lexical";
import { useEffect } from "react";
import { $createPageLinkNode, PageLinkNode } from "../Nodes/PageLinkNode";
// import { $createTweetNode, TweetNode } from "../Nodes/PageLinkNode";
export interface NewPageLinkPayload {
page: string;
}
export const INSERT_PAGE_LINK_COMMAND: LexicalCommand =
createCommand();
export default function PageLinkPlugin(): JSX.Element | null {
const [editor] = useLexicalComposerContext();
useEffect(() => {
if (!editor.hasNodes([PageLinkNode])) {
throw new Error("TwitterPlugin: TweetNode not registered on editor");
}
return editor.registerCommand(
INSERT_PAGE_LINK_COMMAND,
(payload) => {
const pageLinkNode = $createPageLinkNode(payload.page);
$insertNodes([pageLinkNode]);
return true;
},
COMMAND_PRIORITY_EDITOR
);
}, [editor]);
return null;
}
`
Here is the Excluded Properties Map:
`  const CollabExculudedProperties: ExcludedProperties = new Map<
Klass,
Set

([[PageLinkNode, new Set(["GotoPage", "onclick"])]]);`

I believe this should be enough for you to reproduce the issue - my apologies for not sharing the full code with you it is beyond the scope of what I am allowed to do.

Try a breakpoint in syncLexicalUpdateToYjs - I think that's where your issue is.


⚠ ku-s has degraded performance

In 7a4e0d5, ku-s ($KU_API_STATUS_URL) experienced degraded performance:

HTTP code: 200
Response time: 7128 ms

Resolved: ku-s performance has improved in dbbbdbd after 50 minutes.


Latest version

Hi,
I had version 5.1.2 installed, but now I get error trying to fetch it.
Running "cordova plugin add cordova-plugin-x-socialsharing" gets me 5.1.1.
Can anyone clarify this???

I guess you were pulling it from the master branch in the GitHub repo (currently at 5.1.2 which is work in progress, not released), and are now including the latest version from npm (which is 5.1.1).


What should we do if...

We opened a ticket with the TNS service desk, that is escalated and have not heard back from anyone on the status of our port order for over 48h and we requested the port to be completed tomorrow at 9am?

A port is scheduled to complete at 9am, we opened a ticket with the TNS service desk asking to verify everything is set for our upcoming port order 2 days earlier and received no response... it is now 3pm on the day of the requested time and there is still no update?

We are porting numbers from our old tenant to our new tenant (Inter tenant port). The numbers are assigned and actively used in the old tenant. To port the numbers they have to be unassigned, but given our concern with the above scenario we don't want to unassign the numbers until we are sure what time the Inter tenant port will start.
I also understand the team doing the transfer is available from 8am-9pm (eastern time we presume)
(It would be nice if Microsoft handled unassigning the numbers... but I understand why Ms might not want to do that without an admins approval... but Hi, admin here I am happy to give approval after I have all the information I need. Ask me and I'll say yes :) )

We have a big project and want to talk to someone with experience about best practices?

If this feedback is better suited for the referenced TNS service desk article, or somewhere else, please accept my apologies in advance!
Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: a17293e0-4c49-0e97-d5da-b48322f10928
Version Independent ID: c38c0726-5dec-d374-6948-2188d43025ef
Content: What's a port order? - Microsoft Teams
Content Source: Teams/phone-number-calling-plans/port-order-overview.md
Service: msteams
GitHub Login: @CarolynRowe
Microsoft Alias: crowe

I'm sorry, but the GitHub issues are related to issues with content--not the service desk.  I would suggest followth the procedures outlined the following article.  Or following our normal escalation channels.  https://docs.microsoft.com/en-us/MicrosoftTeams/manage-phone-numbers-for-your-organization/contact-tns-service-desk#view-and-manage-existing-cases

@CarolynRowe Please reopen

Another requirement of Intra Tenant ports I am suggesting is a gap in the existing content is:
service numbers and user numbers cannot be in the same port order.
In other words, create separate port orders for user numbers and service numbers.


Link to confluent community slack from extension

There's no direct URL to the channel, people need to sign up for our slack via launchpass.com/confluentcommunity and then join #vscode from there.

Add a link to the Support section


LocalBaseline development

[x] Center btn --> move plugin.x to vertex-space y-max, gradient ascent
[x] Use trapezoidal integration
[x] pandas table --> Measurement/CSV

2023-05-08

[x] independent left and right outer radii (blue)
[x] remote inner radius (green)
[x] remove decimals from pandas frame
[x] add commas to pandas frame
[x] Use spectra intersection outer radius + linear interpolation for baseline

2023-05-11

[x] Save x-axis units to CSV
[ ] Multiplexing support
[ ] Show derivative of baseline selector (blue) lines to gauge validity
[ ] On change of x-axis unit, preserve true value of plugin.x

2023-05-08

[ ] independent left and right outer radii (blue)
[ ] remote inner radius (green)
[ ] remove decimals from pandas frame
[ ] add commas to pandas frame
[ ] Use spectra intersection outer radius + linear interpolation for baseline

[ ] resizable pandas table
[ ] move plugin to top of sidebar

I'm unsure if moving to the "very top" of the sidebar is ideal.  Personally I might vote for between (Detector Control, X-Axis) or (X-Axis, Scan Averaging).  I think laser control and detector control (integration time) should remain at the top though.  Making it harder to find (unexpectedly moving) the button to turn off the laser is almost a safety issue.

Moved checklist items to first comment so this thing is accurate:

Was having issues were logging wasn't working. Turns out spec needs to be on for "Process" btn to do anything. Led to the addition of plugins having their own log file, which seems overdue anyway

Some notes about the current state of this.
When LocalBaseline is enabled and a spec is connected, changing the count clears the widgets.

This signifies that immediate-mode widget onchange detection is working and post-config widget spawning is on its way to working. onchange is linked to reset_configuration which I think was intended to recreate the layout. It might just be missing a new call to get_configuration_obj.
Maintaining field contents can be handled at the plugin level. Currently it is only for the count parameter which must be persistent for multiplexing to work at all. Persistence of the other fields is an (important) usability improvement.


issue-3640: upgrade to <IP_ADDRESS>21012 due to CVE fixes

What is the purpose of the change
Security issue with jackson
Related issues/PRs
Related issues: #3640
Brief change log

version changes

Checklist

[x] I have read the Contributing Guidelines on pull requests.
[x] I have explained the need for this PR and the problem it solves
[x] I have explained the changes or the new features added to this PR
[ ] I have added tests corresponding to this change
[ ] I have updated the documentation to reflect this change
[x] I have verified that this change is backward compatible (If not, please discuss on the Linkis mailing list first)
[ ] If this is a code change: I have written unit tests to fully verify the new behavior.

this release still have CVE, wait for next release

@jackxu2011 I'm a member of the fasterxml/jackson team - this version of jackson has all the CVE fixes - described in https://github.com/apache/incubator-linkis/issues/3640

2,12.7.1 is released - https://repo1.maven.org/maven2/com/fasterxml/jackson/core/jackson-databind/<IP_ADDRESS>/
Linkis currently uses <IP_ADDRESS> and there are no problems. 2.13.4 is a minor upgrade from that. I'm not sure it would be a good idea to revert back to 2.12.x.

<IP_ADDRESS> is released - https://repo1.maven.org/maven2/com/fasterxml/jackson/core/jackson-databind/<IP_ADDRESS>/
Linkis currently uses <IP_ADDRESS> and there are no problems. 2.13.4 is a minor upgrade from that. I'm not sure it would be a good idea to revert back to 2.12.x.

2.13 have a compatibility problem with  jersey.

jersey-core/jersey-json 1.19 does not even use Jackson2 - it uses Jackson1 which has completey different package names (org.codehaus.jackson).
I am a member of the Jackson dev team - I know a bit about how Jackson works.

jersey-core/jersey-json 1.19 does not even use Jackson2 - it uses Jackson1 which has completey different package names (org.codehaus.jackson). I am a member of the Jackson dev team - I know a bit about how Jackson works.

it's not the jackson itself,  but the dependencies.


Added tags & categories + cleanup

That's a lotta taggin! 😄

I'm pretty good in find/replace with regex 🤪


sub-pages and offices fixes

Fixes to the sub-pages and office pages.
Additions

Adds sub-page_content and sub-page_content-markup classes.
Adds office page specific class for consistency with the classes added in the sub-pages template.

Changes

Moves page specific sub-page class to enclosing content area (it wasn't including the intro block).
Set branded list styles on known areas where unordered lists appear.

Testing

Observe branded lists on /offices/project-catalyst/ page and subpages.

Review

@sebworks
@KimberlyMunoz
@jimmynotjim

Preview

Notes

I hate that extra classes are needed for this, but some links are in lists in the CMS so I can't just blanket apply the branded list to the main content area.

Fixed enormous text styling for FAQ page in https://github.com/cfpb/cfgov-refresh/commit/36f4b075047898cbdabfca62bfe260c2bfe65477

Removes unneeded CSS per @sebworks feedback in chat https://github.com/cfpb/cfgov-refresh/commit/042c287ee8f16a3a8e1d9bdc5b2b38e6cfc58072

:+1:

:clap: :+1:
Love this technique.


Rename surround_ambient_enabled to surround_full_volume_enabled

Reverses the boolean value to make it consistent with the eventing based value for easier integration for downstream users.
Example event (surround_mode is the variable in question, here shown in "full mode"):
{
   "audio_delay" : "0",
   "audio_delay_left_rear" : "1",
   "audio_delay_right_rear" : "1",
   "bass" : "0",
   "dialog_level" : "0",
   "headphone_connected" : "0",
   "height_channel_level" : "0",
   "loudness" : {
      "Master" : "1"
   },
   "music_surround_level" : "6",
   "mute" : {
      "LF" : "0",
      "Master" : "0",
      "RF" : "0"
   },
   "night_mode" : "0",
   "output_fixed" : "0",
   "preset_name_list" : "FactoryDefaults",
   "sonar_calibration_available" : "0",
   "sonar_enabled" : "0",
   "speaker_size" : "9",
   "sub_crossover" : "0",
   "sub_enabled" : "1",
   "sub_gain" : "0",
   "sub_polarity" : "0",
   "surround_enabled" : "1",
   "surround_level" : "3",
   "surround_mode" : "1",
   "treble" : "0",
   "volume" : {
      "LF" : "100",
      "Master" : "18",
      "RF" : "100"
   }
}

The name of the property is just a suggestion, maybe there's a better name for this?

Yes, this makes sense -- thanks.


Add Logits to OpenAI ChatCompletions model

OpenAI added logits back to their ChatCompletions API.
This means we can re-add support for all tasks to this LM type! See OpenAICompletionsLM for an example of how to do this.
Contributions on this would be very welcomed if people have the bandwidth, as I may not get to this super soon but it's high priority.

I've been informed that returning the logprobs of the prompt / input which we would want to be able to support logprobs is not included.
However, supporting logprobs for ChatCompletions-mirroring APIs that do return logprobs including for echo=True would still be very desirable.

Hi Hailey,
I'm interested in contributing to this GitHub issue, but I would appreciate some additional context to better understand the task. Could you please provide more details? Specifically, it would be helpful if you could instruct me on which file(s) are affected and what specific changes are needed.
Actually, overall, I need more clarification.
Thank you very much for your attention to this matter,
looking forward to hear from you!
Cheers!

Language models return output in the form of "logits" / "logprobs" (log probabilities) over their vocabulary of possible next tokens. You can use these to sample text probabilistically or deterministically from, or, these allow you to get the estimated (log) probability of a string by the language model.
However, many closed model providers such as OpenAI stopped providing this info to users, and just gave generated text out. They've re-added that feature for their chat models now. This will allow us to run the models on loglikelihood-based multiple choice QA tasks like hellaswag which are currently implemented by taking an LM, running it on each (input + answer) and asking it to return the log probs on not just the answer, but also the input (echo=True allows this in OpenAI's Completions API), then taking only the logprobs from the answer portion. We then compare the logprobability of each multiple choice answer and say the model chose the one it thinks is most likely. Currently, because logprobs weren't available in openAI's ChatCompletions, we couldn't evaluate on the tasks we defined this way, and would need to write a new task that scores via just asking the model to generate text and checking if it matches the right answer.
The steps to complete this feature would be:

Check out a provider that mirrors OpenAI's ChatCompletions API (e.g. Together, who also provide free credits upon signup): https://docs.together.ai/docs/openai-api-compatibility . Does this (and does OpenAI) allow for echo=True as a parameter for their chat models, allowing us to get log probabilities on a target string by feeding in (input + target) and subsetting the logprobabilities to only the target part?

If yes, you can get echo=True from Together or other providers who can be used with OpenAI's Python SDK, then port over https://github.com/EleutherAI/lm-evaluation-harness/blob/b69ca72ec3a0294638382e0f90cf32f90d761b44/lm_eval/models/openai_completions.py#L174C2-L226C1 from OpenAICompletionsLM into OpenAIChatCompletionsLM, making changes as appropriate.

If yes, test this on an open-source model and compare to our Huggingface implementation.

If no, then investigate whether we can feed in just (input) to these APIs and still measure the logprobability of a target string from them.

Hi all, happy to help with this since I'm more familiar with the OpenaiChatCompletionsLM class after working on it a bit. Let me know if you'd like support or scaffolding for this!
I started by checking to see if OpenAI exposes the echo command for their chat completion models:
from openai import OpenAI

client = OpenAI()

client.chat.completions.create()

stream = client.chat.completions.create(
    model="gpt-3.5-turbo",
    messages=[{"role": "user", "content": "Say this is a test"}],
    stream=True,
    echo=True
)
for chunk in stream:
    if chunk.choices[0].delta.content is not None:
        print(chunk.choices[0].delta.content, end="")

and received
File "pyenv/versions/3.10.0/lib/python3.10/site-packages/openai/_utils/_utils.py", line 272, in wrapper
    return func(*args, **kwargs)
TypeError: Completions.create() got an unexpected keyword argument 'echo'`

which makes sense since the CLIChatCompletionCreateArgs doesn't allow for it

Something I'm missing in understanding: If in the task we only use the logprobs for the response for the task evaluation, what does computing the logprobs of the input string give us in the case of the evaluation, Do we also use this as part of the calculation?

taking an LM, running it on each (input + answer) and asking it to return the log probs on not just the answer, but also the input (echo=True allows this in OpenAI's Completions API), then taking only the logprobs from the answer portion.

Something I'm missing in understanding: If in the task we only use the logprobs for the response for the task evaluation, what does computing the logprobs of the input string give us in the case of the evaluation, Do we also use this as part of the calculation?

For multi-token continuations/targets, to get the loglikelihood of the whole target, we need to get the logprob of token 0 conditioned on the input/context, the logprob of token 1 of the target conditioned on (context + token 0 of target), and so on.
With echo=True, we feed in (context + continuation) and get out all the logprobs which we can subset to the target string’s loglikelihood.
If we don’t have echo=True, then we can only feed in the inputs. Then if the model does not output token 0, the logprob of token 1 at target position 1 does not correspond to the right thing and we can’t accurately compute the loglikelihood in a (single) API call for multi-token continuations

Thanks, this is super helpful. I also just tested on Together and am getting the same issue, because it's OpenAICompletions compatible:
from openai import OpenAI

system_content = "You are a travel agent. Be descriptive and helpful."
user_content = "Tell me about San Francisco"

client = OpenAI(api_key="TOGETHER_API_KEY",
    base_url="https://api.together.xyz/v1",)

chat_completion = client.chat.completions.create(
    model="mistralai/Mixtral-8x7B-Instruct-v0.1",
    messages=[
        {"role": "system", "content": system_content},
        {"role": "user", "content": user_content},
    ],
    temperature=0.7,
    max_tokens=1024,
    echo=True
)

response = chat_completion.choices[0].message.content
print("Together response:\n", response)

TypeError: Completions.create() got an unexpected keyword argument 'echo'

It sounds like, based on this, the next step is: investigate whether we can feed in just (input) to these APIs and still measure the logprobability of a target string from them.
Where would we want this output to feed into?
It looks like this would be a good place to start to see how to get them in the completions call? And then we'd want to see how to pull them in here? , the same way we do here

Darn, that makes sense! Thanks for checking on this.

It sounds like, based on this, the next step is: investigate whether we can feed in just (input) to these APIs and still measure the logprobability of a target string from them.
Where would we want this output to feed into?

We could conceivably achieve measurement of target string loglikelihood in O(target len) API calls but this is quite expensive.
Further, since OpenAI only gives up to 5 token logprobs I think, we are limited by this—if the logprobs for our next desired target token do not appear in the top 5 we are out of luck.
Given this, one option may be to add Chat Templating support for local OpenAI Completions support once local Completions support is enabled, and get echo=True that way. Would you be willing to take on local-completions as a next step?
Orthogonal to this, we should think about how we want to support greedy-gen exact match vs. multichoice loglikelihood for multiple choice tasks to have both variants in some unified way.

Further, since OpenAI only gives up to 5 token logprobs I think, we are limited by this—if the logprobs for our next desired target token do not appear in the top 5 we are out of luck.

Ah, this is good to know, thanks!

Chat Templating support for local OpenAI Completions support once local Completions support is enabled, and get echo=True that way. Would you be willing to take on local-completions as a next step?

Yep, local completions sounds good: want to make sure I'm thinking the right way:

Add case statements in here for branching -if it's a local model, set echo=True and test.

For this piece:

we should think about how we want to support greedy-gen exact match vs. multichoice loglikelihood for multiple choice tasks to have both variants in some unified way.

Sounds like possibly a separate issue to file and link to this one?

Yep, local completions sounds good: want to make sure I'm thinking the right way:

Add case statements in here for branching -if it's a local model, set echo=True and test
we should always need to use echo=True for remote/local models! the additions needed for local-completions would be ~ just the same as that of local-chat-completions (tokenizer backend selectable between HF/openai and exact tokenizer can be specified by user, plus base_url configurable)

Sounds like possibly a separate issue to file and link to this one?

Definitely, will open it for tracking! Just mentioning aloud that our best solution here is (unfortunately) to forgo loglikelihood entirely perhaps.

Ah ok so these changes would be to enable local-completions, which is not the same as local-chat-completions, but do have the ability to run echo=True (for legacy reasons), to also run locally (just clarifying for myself).
That makes sense, can start on those changes!

That's correct!

Cool. Just started working on this to echo OpenaiChatCompletionsLM and noticed we removed the tokenizer from that class

https://github.com/EleutherAI/lm-evaluation-harness/pull/1186/files and
https://github.com/EleutherAI/lm-evaluation-harness/pull/1191

Are we calling it a different way or excluding it entirely for OpenaiChatCompletionsLM?

The OpenAI ChatCompletions API actually fully abstracts away its tokenizer, so we don't need a tokenizer for openai-chat-completions! The same isn't true for Completions, there we still need a tokenizer.

Ok, so here is a fun dilemma:
In starting to implement the code (https://github.com/EleutherAI/lm-evaluation-harness/compare/logprob-completions?expand=1), I found that, due to this issue,
I needed to update the default base model to gpt-3.5-turbo-instruct based on their suggested change,  but that model doesn't support both logprobs and echo=True! 🤦♀

A couple ideas:

I can focus on testing for the local case and set the OpenAI model to None
set echo but not logprobs

Something else that I'm not aware of that might be helpful here. Let me know what you think.

sigh
I think in this case we should support local Completions models with echo=True (assuming that these will continue to support echo=True), and otherwise, for non-local / OpenAI native cases, raise an error saying logits of the form we need are not supported upon trying to run loglikelihood() or loglikelihood_rolling() methods.

Hi Hailey and Vicki, I'm still interested on working on this issue with you.
Do you believe is there any room left to have another developer jumping on it with Vicki?

Hey @gmottajr, absolutely! Does the conversation and code here so far make sense?
Feel free to take the branch I pushed and linked to in my comment above and develop from it. Would that work?
Let me know if you need additional pointers or help (and for sure Hailey can also assist better than me in cases of "do we want to do X this way).

This has been a very interesting conversation, thank you @veekaybee @haileyschoelkopf .
On a separate but related note, @haileyschoelkopf do you know how exactly does OpenAI run these benchmarks? Surely they must need the same logprobs that we do. One possibility is they are running against some internal API where they do have access to the logprobs but it's just not opened up.

Openai certainly has access to model logprobs if they desire them (and definitely use them for things like evaluating perplexity).
As mentioned earlier in this thread, multiple choice benchmarks can be measured using generation and exact match, and we’ll probably want to support this — OpenAI’s evals framework likely to some extent exhibits how they do this. https://github.com/openai/evals

Awesome @veekaybee! 🥳

Hey @gmottajr, absolutely! Does the conversation and code here so far make sense?
Feel free to take the branch I pushed and linked to in my comment above and develop from it. Would that work?
Let me know if you need additional pointers or help (and for sure Hailey can also assist better than me in cases of "do we want to do X this way).

Thank you very much for you positive response, @veekaybee. 😄 🚀
That sounds like music to my ears! 🎼 🎵 🤩
I would like to fork the branch you mentioned, but could not really find it.
Yeah, for sure, I do need some additional pointers and help. How does that sound if we could talk directly through Slack, or Discord, Ms Teams, or any other collaboration software more familiar to you?
Looking forward  to hear back from you (and jump right away in this code change). 👀
Best regards,
Gerson Jr.

The branch is  called logprob-completions and you can find a reference of it here: https://github.com/EleutherAI/lm-evaluation-harness/compare/logprob-completions?expand=1
Feel free to find us on the EleutherAI Discord in the #lm-thunderdome channel, same username :)

Hi @veekaybee, I'm not sure why, but all of yours hyperlinks are pointing to a PR instead of where you aim to point to.  This link for example, does not take me to any branch, https://github.com/EleutherAI/lm-evaluation-harness/compare/logprob-completions?expand=1. It takes me here:

Same thing is happening with your discord link:

That is why it really looks like there is something weird happening when you are sending link and I am wondering that you might actually trying to point to another URL.
Anyway, I just guessed you probably is talking about this branch here, I'm not sure: https://github.com/EleutherAI/lm-evaluation-harness/tree/logprob-completions.

Please let me know if I got it correct? I'm going to fork from there.
I need you sending me again the discord link, please.
Thank you very much.

https://github.com/EleutherAI/lm-evaluation-harness/tree/logprob-completions yes, this link is correct.
you can visit the #lm-thunderdome channel on discord.gg/eleutherai to ask questions or discuss.

@gmottajr were you able to get started on this? Let me know if you need any help, or I'm happy to put together a sample PR for us to review.

Have you tried using logit_bias param for openai.chat.completions? Like gpt-4. This param allows for generating only those tokens that have been previously biased (with quite a large value). Like the model makes forward and get logits for the currecnt token, then some lavue is added to the particular logits (for example to logits of tokens of letters A, B, C, D for mmlu), then log-probs are computed. gpt-4 does not return the probs for input tokens. But if you pass only ctx, bias possible continuation logits with quite large value, the model will exclusively generate tokens with these biased logits. gpt-4 can return log-probs for generated tokens.
So, it may be the way to make the openai chat model generate only those tokens that we want and get their log-probs that will still be comparable (bias all tokens for the same value).

Almost all Polish tasks, we have created, are in two versions: multiple choice and generate, e.g. https://github.com/speakleash/lm-evaluation-harness/tree/polish2/lm_eval/tasks/polish_ppc
Results are published on https://huggingface.co/spaces/speakleash/open_pl_llm_leaderboard with task name suffixes _g or _mc. There is also gpt-3 model tested but only on _g tasks.

Could we set logprobs to a large number for vLLM and openai completion API so that we can do the multile choice task using one-token generation?

I am wondering if there is a solution for this. I am using API provider other than openai and using openai schema for that but getting same error 'No support for logits', what's the solution?

Is there any solution to the "No support for logits", when using the LM Harness for multiple choice tasks and GPT API?

As mentioned earlier in this thread, multiple choice benchmarks can be measured using generation and exact match, and we’ll probably want to support this — OpenAI’s evals framework likely to some extent exhibits how they do this. https://github.com/openai/evals

I just wanna mention I took a stab at this in https://github.com/EleutherAI/lm-evaluation-harness/pull/2601 - it kinda works for me in simple scenarios, though I could certainly think of cleaner approaches!


Add [type=button] default to Button

Not having type=button for <button> can lead to easy to implement bugs in ze d.
Changes

Adds type=button as default prop for Button when container is <button>
Add logic test to ensure type can still be changed from the user.
Changed PlainButton tests to test the plain variant as they were redundantly checking the RegularButton again.

@elanoism Can you explain why exactly type="button" is necessary? In terms of semantics and screen reader accessibility, this seems redundant to me.

In the dashboard, if you have a form (using FinalForm) with an input and the first button is a <button> without type=button, clicking Enter in the input triggers that button's onClick which is usually the Cancel button or something similar in our cases.
With the way our designs are laid out, it is pretty easy to implement and miss.


[type:feat] code over issue #44 push assert.go and assert_test.go

[type:feat] code over issue #44 push assert.go and assert_test.go

I have read the CLA Document and I hereby sign the CLA


add whisper example

Type of Change
feature or bug fix or documentation or others
API changed or not
not
Description
fix whisper python api
detail description
Issues: issue104
Expected Behavior & Potential Risk
no
How has this PR been tested?
how to reproduce the test (including hardware information)
Dependency Change?
any library dependency introduced or removed

inference result


Eligibility Misspelled

@virenkhandal where does the wrong spelling occur?

This issue is fixed as a part of https://github.com/coala/corobo/issues/257.


Toggle touched flag on all fields

Fixes #8

Very good point. On Monday I'll evaluate it against my demo and will get back with feedback.
-------- Original Message --------
On 21 Oct 2018, 00:06, Dave Draper wrote:

@draperd commented on this pull request.

In packages/core/src/types.js:

@@ -121,15 +121,17 @@ export type FormComponentProps = {
parentContext?: FormContextData,
showValidationBeforeTouched?: boolean,
conditionalUpdate?: boolean,

disabled?: boolean

disabled?: boolean,
touched?: boolean

Rather than adding a touched prop here, it might be better to just reuse the showValidationBeforeTouched prop. When this is set to false all the warning messages will be shown immediately even if the field hasn't been given focus.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.

Seems GitHub is having problems today, cause I've pushed additional commit and sometimes it's displayed and sometimes not.
I had to add showValidationBeforeTouched property to the state because the getDerivedStateFromProps method does not have access to previous props.

Seems GitHub is having problems today, cause I've pushed additional commit and sometimes it's displayed and sometimes not.
I had to add showValidationBeforeTouched property to the state because the getDerivedStateFromProps method does not have access to previous props.

Seems GitHub is having problems today, cause I've pushed additional commit and sometimes it's displayed and sometimes not.
I had to add showValidationBeforeTouched property to the state because the getDerivedStateFromProps method does not have access to previous props.

Sorry for not getting back to you today on this ... I'll hopefully have a chance to look at this tomorrow. I'm happy to merge the code as is, but I'm not sure what you mean by the "reset form" functionality. I want to make sure that I don't merge anything that causes any regressions so I'll check your branch out tomorrow and test it quickly before merging.

I've merged this to the code base - I should publish a new release next week

@draperd Thank you for merging this.
The "Reset form" functionality was something my code introduced. Basically, it would clear touched flag from all fields even if they were manually touched.
That was like a side effect and I do not need it at the moment so I think we're good.
Thank you.


use sundial everywhere

Ready for review @kentquirk
I ended up doing Dexcom (and a small change in Abbott to fix the weirdness you discovered last week) because I was on a roll and there really wasn't that much to change. I did leave out Asante because I don't know what other changes might have to be made first when we get back to that - didn't want it to be wasted effort.
Double-checked the Dexcom changes on my own Dex and checked the Insulet, but of course couldn't test the Abbott.
Dependent on sundial PR 12 - use npm link until that's reviewed, merged, and pubbed to npm.

This now passes tests since I deployed the new sundial and set the version number here. Feel free to merge once you've dealt with the question about US/Eastern.


Having a problem in pairing my android mobile with phonegap desktop app beta 0.1.1

I am using phonegap desktop app beta 0.1.1 and trying to pair my android phone, when i tried to pair the phone with phonegap developer app it doesn't work.
The app returned an "error" then "timed out" and then i tried to open the phonegap server on my browser and it worked.
I've checked the phonegap server ip and it's the same as my machine. Both my machine and my android mobile are on the same network. I don't know what should i have to do, i am new to phonegap please help.

Hi @HumayunE
You may want to post this in the phonegap desktop app issue tracker instead of here: https://github.com/phonegap/phonegap-app-desktop
But I will try to help :)
Which os are you running on? Also, once you start up the phonegap desktop app, hit the console button and see if your phone is actually able to request form the server. If the server logs are bare, it's most likely that your problem is a network issue.

i am using windows 7..and yup!! the server logs are bare.. :(

Hrm, you might wanna see if you can actually ping devices connected to your network.

Get the ip address of your phone that's connected to your network
On your windows machine, hit Windows Key + R and then type in cmd to get the command prompt (or go to Start Menu -> Run -> type `cmd')
type ping <ip-address of your phone>

If those pings time out, it is likely you can't send information between ip's on your network. At that point, you'll have to configure your router settings or turn off your firewall.

Closing since we haven't seen very much activity on this issue. Feel free to reopen.


d8vk upstream?

Will d8vk ever be merged with DXVK?

It's being made in a way so it's mergable with dxvk.
But nothing has definitely been decided yet afaik and it's up to the dxvk devs of they want to include it at some point.
But the idea haven't been rejected yet at least

A TODO list would be interesting for following the progress.

Indeed. @AlpyneDreams do you have any comments on the bugs that should be resolved before attempting to upstream?

Indeed. @AlpyneDreams do you have any comments on the bugs that should be resolved before attempting to upstream?

See doitsujin/dxvk#3411


Getting error when using TerminalFX with clojure

I can download and run the project fine. However, when I use maven to load it into a clojure project. There is an error. I don't think it's a clojure problem but I'm a bit stumped as to what to do.
boot.user=> (com.kodedu.terminalfx.TerminalAppStarter/main (make-array String 0))
#
# A fatal error has been detected by the Java Runtime Environment:
#
#  SIGSEGV (0xb) at pc=0x000000010f1ecd9a, pid=47620, tid=206351
#
# JRE version: OpenJDK Runtime Environment (11.0+28) (build 11+28)
# Java VM: OpenJDK 64-Bit Server VM (11+28, mixed mode, tiered, compressed oops, g1 gc, bsd-amd64)
# Problematic frame:
# V  [libjvm.dylib+0x3ecd9a]  jni_CallStaticVoidMethodV+0xdf
#
# No core dump will be written. Core dumps have been disabled. To enable core dumping, try "ulimit -c unlimited" before starting Java again
#
# An error report file with more information is saved as:
# /Users/chris/Development/caudata/kmi/hs_err_pid47620.log
#
# If you would like to submit a bug report, please visit:
#   http://bugreport.java.com/bugreport/crash.jsp
#

---------------  S U M M A R Y ------------

Command Line: -Dboot.app.path=/usr/local/bin/boot /usr/local/bin/boot cider-fx

Host: MacBookPro13,1 x86_64 2000 MHz, 4 cores, 8G, Darwin 18.2.0
Time: Wed May 15 23:00:56 2019 CST elapsed time: 20 seconds (0d 0h 0m 20s)

---------------  T H R E A D  ---------------

Current thread (0x00007fdf67ba5000):  JavaThread "Thread-35" daemon [_thread_in_vm, id=9219, stack(0x0000700005497000,0x0000700005517000)]

Stack: [0x0000700005497000,0x0000700005517000],  sp=0x0000700005516680,  free space=509k
Native frames: (J=compiled Java code, A=aot compiled Java code, j=interpreted, Vv=VM code, C=native code)
V  [libjvm.dylib+0x3ecd9a]  jni_CallStaticVoidMethodV+0xdf
C  [libjfxwebkit.dylib+0x1bae566]  JNIEnv_::CallStaticVoidMethod(_jclass*, _jmethodID*, ...)+0x86
C  [libjfxwebkit.dylib+0x1bae4ac]  WTF::scheduleDispatchFunctionsOnMainThread()+0x17c
C  [libjfxwebkit.dylib+0x1682a25]  WTF::Function<void ()>::CallableWrapper<WebCore::DataURLDecoder::decode(WebCore::URL const&, WebCore::DataURLDecoder::ScheduleContext const&, WTF::Function<void (std::optional<WebCore::DataURLDecoder::Result>)>&&)::$_0>::call()+0x215
C  [libjfxwebkit.dylib+0x1bb1078]  WTF::BlockPtr<void ()> WTF::BlockPtr<void ()>::fromCallable<WTF::WorkQueue::dispatch(WTF::Function<void ()>&&)::$_0>(WTF::WorkQueue::dispatch(WTF::Function<void ()>&&)::$_0)::'lambda'(void*)::__invoke(void*)+0x48
C  [libdispatch.dylib+0x2d53]  _dispatch_call_block_and_release+0xc
C  [libdispatch.dylib+0x3dcf]  _dispatch_client_callout+0x8
C  [libdispatch.dylib+0xa124]  _dispatch_lane_serial_drain+0x26a
C  [libdispatch.dylib+0xabdc]  _dispatch_lane_invoke+0x184
C  [libdispatch.dylib+0x13090]  _dispatch_workloop_worker_thread+0x25b
C  [libsystem_pthread.dylib+0x260b]  _pthread_wqthread+0x199
C  [libsystem_pthread.dylib+0x2405]  start_wqthread+0xd

siginfo: si_signo: 11 (SIGSEGV), si_code: 1 (SEGV_MAPERR), si_addr: 0x0000000000000000

Register to memory mapping:

RAX=0x00007000055166c8 is pointing into the stack for thread: 0x00007fdf67ba5000
RBX=0x00007fdf67ba5000 is a thread
RCX=0x00007fdf6e54d398 points into unknown readable memory
RDX=0x0 is NULL
RSP=0x0000700005516680 is pointing into the stack for thread: 0x00007fdf67ba5000
RBP=0x0000700005516730 is pointing into the stack for thread: 0x00007fdf67ba5000
RSI=0x0 is NULL
RDI=0x00007fdf67ba5340 points into unknown readable memory
R8 =0x0 is NULL
R9 =0x0 is NULL
R10=0x0000000100000000 is an unknown value
R11=0x0 is NULL
R12=0x00000001322424b0: jvm+0 in /Users/chris/.openjfx/cache/11.0.1/libjfxwebkit.dylib at 0x000000012eba7000
R13=0x0 is NULL
R14=0x0 is NULL
R15=0x00007fdf67ba5340 points into unknown readable memory

May it be a JavaFx or clojure bug?

I’m not exactly sure. It seems like there is a problem when calling Webview.

https://github.com/javaterminal/TerminalFX/issues/28
help!!!

https://github.com/javaterminal/TerminalFX/issues/28
Error.

Whwn I run it comes an error.
Error occurred during initialization of boot layer java.lang.module.FindException: Module com.kodedu.terminalfx not found

https://github.com/javaterminal/TerminalFX/issues/31

https://github.com/javaterminal/TerminalFX/issues/33
Help !!!

https://github.com/javaterminal/TerminalFX/issues/33#issue-648711979
error

@ashokkumarvel  @poorvajappja @PradeepSimba Please stop the mess. I answered your questions on individual issues.


Benchmark is not getting a found_value

We are working on a set of checks that are trying to confirm that no user has access or permissions to take a specific action. These checks are all failing because we are not getting a found_value returned to us.  It may be that Windows is returning an empty set, which would be successful since no user (No One) has rights to do the specified thing, but since we do not have a found_value we can not be sure.
here is an example return for the item in question:
{
"CIS-2.2.13": {
"description": "(L1) Ensure 'Create permanent shared objects' is set to 'No One'",
"match_output": "No One",
"module": "win_secedit",
"name": "SeCreatePermanentPrivilege",
"nova_profile": "windows-10-enterprise-r1703-level-1",
"tag": "CIS-2.2.13",
"type": "whitelist",
"value_type": "match"
}

Pretty sure salt isn't using our profiles anymore so I'm going to close this one. Please comment if it should be reopened.


fix for in for babel 5

I change this line:
for(x in xs)
to
for(let x in xs)
For running with babel-node example.js
instead of node --harmony_destructuring example.js

Thanks!


Add support for transparent key prefixing. Close #95

Awesome! Just checked out the changes and they're really nice! I'm going to do more tests and we'll soon have this feature. 🍺

Okay, I made the two changes.

Released in 1.7.0 🍺

:smile: Awesome! Thanks for the quick responses.


Add Padding to Chart Boundaries for Improved Visualization

This update enhances the chart's visual clarity by adding padding to its boundaries:
Increased upperValue by 5% to ensure the highest data point doesn't touch the top edge.
Decreased lowerValue by 2% to add a small buffer below the lowest data point.
These changes improve the overall appearance and prevent data points from clipping or too close to the edges.

@AmirMousavi-Dev Congrats on your first contribution to ComposeNews! 🥳🎉
fix #144


OCPBUGS-41903: operator/status: clear azure path fix job conditions on operator removal

there is sometimes a race condition when setting .spec.managementState back and forth between Removed and Managed where the azure path fix controller will kick off the job, but the resources needed for the job to run will get removed (as expected) before the job can finish and its controller update the operator's progressing condition to reflect that.
this has been happening often in the TestLeaderElection e2e test. this test does not wait for the image registry operator to become available before removing it, and this is what triggers the race. a customer has reported a similar issue, although their error was slightly different and proved harder to reproduce. this commit should fix both problems.
clearing the status is most important when users upgrade from a version of the azure path fix controller that deploys the job. OCP versions that do not deploy the job should not have the problem, and including this code in them should be harmless.
in OCP >= 4.17 this job is no longer deployed, though the controller is kept it can probably be safely removed in OCP >= 4.18.

Testing
We need upgrade tests as well as regression tests for this one. Testing operator removal (.spec.managementState: Removed) would also be great.

/test e2e-azure-operator
/test e2e-azure-ovn
/test e2e-azure-ovn-upgrade

e2e-aws-operator failed on a known flake in TestImageRegistryRemovedWithImages.
/test e2e-aws-operator
will re-run e2e-azure-operator for good measure.
/test e2e-azure-operator
e2e-hypershift failure seem unrelated
/test e2e-hypershift

/label qe-approved
/label cherry-pick-approved

This seem to behave well overall but I'm still slightly skeptical :D
/payload-aggregate periodic-ci-openshift-release-master-ci-4.18-upgrade-from-stable-4.17-e2e-azure-ovn-upgrade 5

/payload-abort

/payload-abort

Test failures are infra related - I'll allow CI some time to recover before retesting.
Failure:
error: error creating buildah builder: copying system image from manifest list: determining manifest MIME type for docker://registry.build10.ci.openshift.org/ci/managed-clonerefs@sha256:84b65cb47df5321b0f344d66290144e853eca71055f9553a6056193f6f9ebb6c: reading manifest sha256:9514ef6fdb801fca35c35c6749e6382ecdc0498f09d7b023cb01d7b728454272 in registry.build10.ci.openshift.org/ci/managed-clonerefs: manifest unknown

/retest
/payload-aggregate periodic-ci-openshift-release-master-ci-4.18-upgrade-from-stable-4.17-e2e-azure-ovn-upgrade 5

e2e-azure-operator failed because TestS3Minio failed. It seems unrelated to the previous flakes. I've seen quite a few errors in the operator logs when it tries to communicate with minio, I suspect the minio deployment might just be unreliable. I've seen TestS3Minio fail previously but never spent time investigating it.
This was seen in the logs for this test, which I think corroborates my understanding of the failure:
imageregistry.go:399: the imageregistry resource is processed, but the the image registry is not available

e2e-aws-operator failure was infra releated:
* could not run steps: step [input:origin-centos-8] failed: failed to wait for importing imagestreamtags on ci-op-nz0w8tln/pipeline:origin-centos-8: failed to import tag(s) [origin-centos-8] on image stream ci-op-nz0w8tln/pipeline because of missing definition in the spec

/retest

@xiuwang this PR has changed since your last tagged it, could you please have another look as well? The same code no longer cleanly applies to 4.14-4.16, but I have adapted the changes on https://github.com/openshift/cluster-image-registry-operator/pull/1158 which we should be able to backport between 4.14-4.16.

I'm putting this on hold to give QE some room to test the latest changes.
/hold
@atiratree if you feel the changes are good to go, could you give the PR the lgtm stamp? Tack!

/lgtm

/retest

/label qe-approved
/label cherry-pick-approved

/hold cancel

e2e-aws-ovn-image-registry failed due to infra issue
/retest

same issue with e2e-aws-ovn-image-registry:
Found 3 events for Pod cluster-image-registry-operator-amd64-build:
* 0001-01-01T00:00:00Z 0x : 0/87 nodes are available: 1 Insufficient cpu, 1 node(s) had untolerated taint {node-role.kubernetes.io/ci-longtests-worker: ci-longtests-worker}, 1 node(s) had untolerated taint {node-role.kubernetes.io/ci-prowjobs-worker: ci-prowjobs-worker}, 1 node(s) had untolerated taint {node.cloudprovider.kubernetes.io/uninitialized: true}, 12 node(s) had untolerated taint {node-role.kubernetes.io/ci-tests-worker: ci-tests-worker}, 3 node(s) had untolerated taint {node-role.kubernetes.io/infra: reserved}, 3 node(s) had untolerated taint {node-role.kubernetes.io/master: }, 4 node(s) didn't match Pod's node affinity/selector, 61 node(s) had untolerated taint {node.kubernetes.io/not-ready: }. preemption: 0/87 nodes are available: 1 No preemption victims found for incoming pod, 86 Preemption is not helpful for scheduling.
* 0001-01-01T00:00:00Z 0x : 0/87 nodes are available: 1 Insufficient cpu, 1 node(s) had untolerated taint {node-role.kubernetes.io/ci-longtests-worker: ci-longtests-worker}, 1 node(s) had untolerated taint {node-role.kubernetes.io/ci-prowjobs-worker: ci-prowjobs-worker}, 1 node(s) had untolerated taint {node.cloudprovider.kubernetes.io/uninitialized: true}, 1 node(s) were unschedulable, 11 node(s) had untolerated taint {node-role.kubernetes.io/ci-tests-worker: ci-tests-worker}, 3 node(s) had untolerated taint {node-role.kubernetes.io/infra: reserved}, 3 node(s) had untolerated taint {node-role.kubernetes.io/master: }, 4 node(s) didn't match Pod's node affinity/selector, 61 node(s) had untolerated taint {node.kubernetes.io/not-ready: }. preemption: 0/87 nodes are available: 1 No preemption victims found for incoming pod, 86 Preemption is not helpful for scheduling.
* 0001-01-01T00:00:00Z 0x : 0/86 nodes are available: 1 Insufficient cpu, 1 node(s) had untolerated taint {node-role.kubernetes.io/ci-longtests-worker: ci-longtests-worker}, 1 node(s) had untolerated taint {node-role.kubernetes.io/ci-prowjobs-worker: ci-prowjobs-worker}, 1 node(s) had untolerated taint {node.cloudprovider.kubernetes.io/uninitialized: true}, 11 node(s) had untolerated taint {node-role.kubernetes.io/ci-tests-worker: ci-tests-worker}, 3 node(s) had untolerated taint {node-role.kubernetes.io/infra: reserved}, 3 node(s) had untolerated taint {node-role.kubernetes.io/master: }, 4 node(s) didn't match Pod's node affinity/selector, 61 node(s) had untolerated taint {node.kubernetes.io/not-ready: }. preemption: 0/86 nodes are available: 1 No preemption victims found for incoming pod, 85 Preemption is not helpful for scheduling.}```

I'll give CI some time to recover before retesting.

/retest

This PR can be backported as is to 4.18 and 4.17. I also plan to backport this fix to 4.16, 4.15 and 4.14, but the code will need to change - see https://github.com/openshift/cluster-image-registry-operator/pull/1158.
I'm requesting the bot to backport down to 4.16 here so we have the bugs created by automation, but we'll use https://github.com/openshift/cluster-image-registry-operator/pull/1158 for 4.16 instead (the bot will probably not be able to create a PR, and even if it does we'll have to discard it in favor of 1158). Once the 4.16 backport PR merges the backport can be automated again.
/jira backport release-4.18,release-4.17,release-4.16

/cherrypick release-4.18
/cherrypick release-4.17

/cherrypick release-4.18


Using the collecting variable of iterable unpacking causes "used before definition" error

Using the example from the PEP:
a, *b, c = range(5)
print(b)

produces
{
	"owner": "_generated_diagnostic_collection_name_#0",
	"code": "use-before-def",
	"severity": 4,
	"message": "'b' used before definition",
	"source": "Python",
	"startLineNumber": 2,
	"startColumn": 7,
	"endLineNumber": 2,
	"endColumn": 8
}

Environment data

VS Code version: 1.29.1
Extension version (available under the Extensions sidebar): 2018.11.0
OS and version: Windows 10 1803
Python version (& distribution if applicable, e.g. Anaconda): CPython 3.7.0
Python Language Server version: <IP_ADDRESS>

I can confirm that this has been fixed in a recent version of the language server.


Suggestion : More settings for Minions

So...
I saw that http://mgar.io got Gamemodes like 'Speedy Bots' and wanted to ask , if it would be possible to get it added @Megabyte918 !
I will try my best and keep you Guys updated ! :)
Greetings Flare !

Do you know for a file called gameserver.ini?

@Luka967 , I meant that there should be some Extra Options like adding the Minions another option like "minionSpeed = 1" !
Greetings Flare :) !

@FlareYT @Megabyte918 doesn't want to add options like that because they reduce performance.

@ZfsrGhS953 , I will wait till @Megabyte918 answers !
Otherwise thanks :)
Greetings ! :)

@FlareYT He already said that before: https://github.com/Megabyte918/MultiOgar-Edited/pull/376#issuecomment-271470247

Yes it is possible, but for performance reasons it will not be implemented. I want to have the highest performance possible with minions :)

@Megabyte918 Why you didn't merge my pull request, then?

@Megabyte918 , alright ! :)


change readme to point to community repo for install/update scripts

Does the pull request solve a related issue?
#1856 #1866

@MichMich   travis broken again

I've just stared working on a docs site to separate the docs from the repo:
https://docs.magicmirror.builders
This way we can update the docs without releasing a new version. In this site, I've already used your new links.
When the new docs site is a bit more polished, I'll remove the docs from the MagicMirror repo, and point to the docs site. If you want to add something to the docs, please send a PR to https://github.com/MichMich/MagicMirror-Documentation
Thanks for all your contributions, Sam! I really, really appreciate it!

@MichMich   how long til u think the new site will be ready?
just thinking about users who will use the bad scripts..

Doing the best I can. (But busy with work, in the middle of a house renovation, wife’s away for work and one of my two kids is currently ill ... so can’t make promises. 🤪)

no problem.. it was just for my planning..  we all have things going on

I've updated README.md in master to reflect the link to the Docs site. Feel free to send PR's to the Docs repo if it needs updates.


USHIFT-492: Document getting-started procedure from microshift-testing copr repo

Closes USHIFT-492

/lgtm


Command line args could be made much more robust with argparse

https://docs.python.org/3/library/argparse.html

Given pysh's new emphasis on sklearn integration, I am not sure that taking arguments from the command line makes much sense.
However, I do think having a fully functional CMI would be be useful (see #65)


[util] Enable deferSurfaceCreation for the Codename Panzer series

Intros are played back using ddraw, and main menu isn't rendered otherwise.

The old enableDialogMode option apparently only did anything for the game in Proton. I can confirm that with this it works both with regular Wine and Proton. Nice find


Nbo/make cypress tests more robust

Dev Review rules:

3 PR max
at the second feedback, prefer meet instead of github conversation

Definition of Done:

[ ] Testing
[ ] No error logs in web console (except iFrame errors)
[ ] Create or Update documentation (README file for users/integrators)
[ ] Identify breaking changes with conventional commits
[ ] Check the test page in order to manually validate the feature
[ ] Clean code (regroup configuration variable, typos, no console.log...)

Could you change the prefix in commit fix: add keystrokeDelay to 0 in scenario launch tests, from fix to test, please ?


Load app items via ajax

There's games with thousands of items which are rendered into dom on page load: https://steamdb.info/app/232090/

Should probably do the same with achievements.


Add feature flag to disable Fiat-Shamir

Description
This PR adds a feature flag test_fiat_shamir that effectively disables Fiat-Shamir when running the stark prover and verifier. This means that if you run something like
cargo test test_prove_fib --features test_fiat_shamir

the fibonacci tests will run with a transcript that always returns the same value. This is useful for debugging.
To do this, Transcript was turned into a Trait and a DefaultTranscript and TestTranscript structs were introduced.
Type of change

[x] New feature

Codecov Report

Merging #242 (dd5350b) into main (8382be0) will decrease coverage by 0.04%.
The diff coverage is 92.94%.

@@            Coverage Diff             @@
##             main     #242      +/-   ##
==========================================
- Coverage   94.05%   94.01%   -0.04%
==========================================
  Files          80       81       +1
  Lines        9430     9447      +17
==========================================
+ Hits         8869     8882      +13
- Misses        561      565       +4

Impacted Files
Coverage Δ

proving_system/plonk/src/prover.rs
100.00% <ø> (ø)

proving_system/plonk/src/verifier.rs
100.00% <ø> (ø)

crypto/src/fiat_shamir/test_transcript.rs
70.00% <70.00%> (ø)

crypto/src/fiat_shamir/default_transcript.rs
94.33% <94.33%> (ø)

proving_system/plonk/src/setup.rs
100.00% <100.00%> (ø)

proving_system/stark/src/fri/mod.rs
100.00% <100.00%> (ø)

proving_system/stark/src/lib.rs
96.00% <100.00%> (-4.00%)
:arrow_down:

proving_system/stark/src/prover.rs
100.00% <100.00%> (ø)

proving_system/stark/src/verifier.rs
98.26% <100.00%> (+0.01%)
:arrow_up:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

In the future if we add more debug tools like this we could add one feature to enable them all, for simplicity


[FEAT] : Add Contact Us Via E-Mail

Description
From this page, user can mail their issue, reviews, and query direct from website.
Previous Work

Request
I would like to assign me this issue under gssoc-extd as a level-3 task.

this page is already done but if functionality is not working then you can work on it.

Ok
On Sun, Oct 27, 2024, 2:45 PM Vivek Prajapati @.***>
wrote:

this page is already done but if functionality is not working then you can
work on it.
—
Reply to this email directly, view it on GitHub
https://github.com/codervivek5/VigyBag/issues/2387#issuecomment-2439920121,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/BDGNWLVWODAT5TER2Y3WIOLZ5SVL3AVCNFSM6AAAAABQU4CLMKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMZZHEZDAMJSGE
.
You are receiving this because you authored the thread.Message ID:
@.***>

Kindly assist gssoc-extd and level labels for that..
On Sun, Oct 27, 2024, 2:50 PM Vivek Prajapati @.***>
wrote:

Assigned #2387 https://github.com/codervivek5/VigyBag/issues/2387 to
@PriyanshuValiya https://github.com/PriyanshuValiya.
—
Reply to this email directly, view it on GitHub
https://github.com/codervivek5/VigyBag/issues/2387#event-14921321068,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/BDGNWLTYM3D6LEE5FE7QRFLZ5SV6NAVCNFSM6AAAAABQU4CLMKVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJUHEZDCMZSGEYDMOA
.
You are receiving this because you were assigned.Message ID:
@.***>


Update Caddy2 reverse proxy configuration

Hi,
Recently, I changed to use caddy2. But the configuration is not working as you mentioned. So I searched from caddy2 official websites and ask from ChatGPT, I finally got the right one. You need to remove the v1 path.
Also, I will give a named match example blow. You can think api is equal v1 in your example. Then you can put url https://yourdomain.example.com/api in OpanAi endpoint. The import things is to delete path in reverse proxy. You might have a try to use handle_path to do the same things.
        route /api* {
            uri strip_prefix /api
            reverse_proxy https://api.openai.com  {
                header_up Host api.openai.com
                header_up Authorization "{http.request.header.Authorization}"
            }
        }

Caddy新版本出来后，我再试试


issue credits

issue 10000 credits to @ctessum

 Follow up
On Monday, 26-Feb-24 14:39:04 UTC by Gov4Git dev
Issued 10000 credits to member @ctessum.


bug: fixed the issue with replacing the remote url in the local repo

Resolves issue https://github.com/redhat-developer/kam/issues/207
What type of PR is this?
/kind bug
What does this PR do / why we need it:
The bootstrap command  kam bootstrap --service-repo-url https://github.com/ishitasequeira/taxi --gitops-repo-url https://github.com/ishitasequeira/gitops.git --image-repo quay.io/isequeir/taxi --dockercfgjson isequeir-robot-auth.json --git-host-access-token ******* --output resources --overwrite --push-to-git=true
when applied to the existing output directory, the folder gets updated and pushed to a git repo but the remote origin does not get updated according to the new repo. We need to check if the remote origin is present and if yes we need to update it.
Have you updated the necessary documentation?

[ ] Documentation update is required by this PR.
[ ] Documentation has been updated.

Which issue(s) this PR fixes:
https://issues.redhat.com/browse/GITOPS-846
Fixes #?
How to test changes / Special notes to the reviewer:

./kam bootstrap --service-repo-url https://github.com/<username>/taxi.git --gitops-repo-url https://github.com/<username>/gitops.git  --image-repo quay.io/<username>/image-repo --dockercfgjson ~/Downloads/<username>-robot-auth.json --git-host-access-token ****  --output ~/go/src/github.com/test/gitops  --overwrite --push-to-git=true
kam bootstrap --service-repo-url https://github.com/ishitasequeira/taxi.git --gitops-repo-url https://github.com/<username>/gitops1.git  --image-repo quay.io/isequeir/image-repo --dockercfgjson ~/Downloads/<username>-robot-auth.json --git-host-access-token ****  --output ~/go/src/github.com/test/gitops  --overwrite --push-to-git=true

Things to check :

Both the commands should get successfully executed
The repos should be created on git
The remote origin should get updated

Verified locally. Looks good.
/approve
@chetan-rns Can you please review it implementation point of view

@amitkrout I think this PR is solving #212 rather than #207. WDYT?

@amitkrout I think this PR is solving #212 rather than #207. WDYT?

@chetan-rns, yes !! it definitely fixes #212, I am not really sure what exactly is the error with issue #207!

Please update this PR to correctly point to which issue it is fixing.   Please update the description as well.   BTW, I don't think #212 is a bug.

Please update this PR to correctly point to which issue it is fixing. Please update the description as well. BTW, I don't think #212 is a bug.
@wtam2018  I have updated the PR to https://github.com/redhat-developer/kam/issues/212. https://github.com/redhat-developer/kam/issues/212 seems to be a bug since the overwrite flag replaces the existing bootstrap directory to the new one. When the output directory gets updated with the new one, the remote alias origin does not get updated. As we are using remote add, there is a remote url origin already present and it needs to be updated with the new url.

Please update "how to test"

Please update "how to test"

I have updated

We don't know what else is in the .git.  It is better off to check if .git exist.  If it does exist, we should fail the command with the appropriate error.   If there is an overwrite flag, we can remove the .git folder.

/hold

When push-to-git was implemented, one of the assumptions was that the git repo had not been initialized.   Now, you are running a sequence of git commands with an initialized repo in an unknown state.

When push-to-git was implemented, one of the assumptions was that the git repo had not been initialized. Now, you are running a sequence of git commands with an initialized repo in an unknown state.

@wtam2018, this would only happen when the user explicitly provides --overwrite flag while bootsrapping.
Right now, when the overwrite flag is provided, it updates the local output directory but doesn't push it to the git which is not consistent.
So IMO, if the user is OK to overwrite the local output directory, it should be OK to update the git repo as well.

We don't know what else is in the .git. It is better off to check if .git exist. If it does exist, we should fail the command with the appropriate error. If there is an overwrite flag, we can remove the .git folder.

aaahhh i missed this comment.
Yes! it actually does make more sense to check for .git directory and overwirte flag. If overwrite=true delete the .git folder and reinitialize it.

/refresh

/retest

When push-to-git was implemented, one of the assumptions was that the git repo had not been initialized. Now, you are running a sequence of git commands with an initialized repo in an unknown state.

@wtam2018 I have addressed the comments

@ishitasequeira  I don't think "How to test changes " is correct.  You need to delete the gitops remote after step 4.   "Both commands should execute successfully" does not seem to make sense,

Codecov Report

Merging #222 (b98f448) into master (f440ca7) will increase coverage by 0.01%.
The diff coverage is 66.66%.

@@            Coverage Diff             @@
##           master     #222      +/-   ##
==========================================
+ Coverage   58.48%   58.49%   +0.01%
==========================================
  Files          57       57
  Lines        3042     3048       +6
==========================================
+ Hits         1779     1783       +4
- Misses       1093     1094       +1
- Partials      170      171       +1

Flag
Coverage Δ

unittests
58.49% <66.66%> (+0.01%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

pkg/pipelines/utils.go
50.00% <33.33%> (-0.88%)
:arrow_down:

pkg/pipelines/bootstrap.go
68.18% <100.00%> (+0.24%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f440ca7...b98f448. Read the comment docs.

Please also test interactive mode.

/refresh

/retest

/hold cancel


cfops backup leaves temp files on Ops Manager

We have cfops backup running in a nightly cron job. Yesterday the backup failed with the following message:
2016/06/15 02:01:08 ... opsmanager.go:147] error in save http request%!(EXTRA *errors.errorString={"error":"No space left on device - sendfile"}) 2016/06/15 02:01:08 ... createCliCommand.go:46] there was an error: {"error":"No space left on device - sendfile"} running backup on ops-manager tile:&{{/srv/backup/pcf false 0xc820152bd0} ...  /srv/backup/pcf/opsmanager/deployments opsmanager  ubuntu ...
Then we checked the Ops Manager VM: there was a folder of ~5GB for every backup run left behin in /tmp/ops_manager/ and the root partition was 100% full. So we deleted everything in /tmp/ops_manager and the backup continued to run.
Example of the last two days:
# du -hs /tmp/ops_manager/* 5.1G    /tmp/ops_manager/d20160615-1096-d1t5cv 5.1G    /tmp/ops_manager/d20160615-1096-u87ttr 5.1G    /tmp/ops_manager/d20160616-1096-10ubl1u 5.1G    /tmp/ops_manager/d20160616-1096-upm66p

I missed the latest release: so I upgraded to v2.2.26 and ran the backup again. After the backup is finised there are around 10GB left in /tmp/ops_manager
root@pivotal-ops-manager:/tmp/ops_manager# du -hs * 5.1G    d20160617-1096-1q9lbqt 5.1G    d20160617-1096-f7c9mj

When cfops backs up the ops manager it simply calls the ops manager export
api endpoint. Calling this endpoint generates a temp file before it pushes
back in the HTTP response.
What you are describing is these ops manager tmp files filling your disk.
That is not a function of cfops, it is simply how ops manager functions.
What other clients have done to work around this is either restart the ops
manager vm or automate the clearing of the tmp dir on the box.
What version of ops manager are you using? I believe there was a fix in the
latest version where ops manager will clear its tmp on its own.
Hope this helps.
On Jun 17, 2016 3:41 AM, "mayrstefan"<EMAIL_ADDRESS>wrote:

I missed the latest release: so I upgraded to v2.2.26 and ran the backup
again. After the backup is finised there are around 10GB left in
/tmp/ops_manager
root@pivotal-ops-manager:/tmp/ops_manager# du -hs *
5.1G d20160617-1096-1q9lbqt
5.1G d20160617-1096-f7c9mj
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/pivotalservices/cfops/issues/94#issuecomment-226702173,
or mute the thread
https://github.com/notifications/unsubscribe/AAqI03hkhyFxygeah_4bakMtMW1HGZI0ks5qMk-OgaJpZM4I3SZI
.

I opened a support ticket at Pivotal when I found export installation settings leaves almost the same files behind. We use Ops Manager <IP_ADDRESS> and there might be an issue with the cleanup on Ops Manager side. We have differents Ops Manager instances and around the last days I could see the following:

a recenty rebooted Ops Manager has files older then 24h but none over 48h: cleanup seems to work
another instance where we cleared the /tmp/ops_manager directory manually has files even older then 48h: did the cleanup job even run?
Maybe the cleanup jobs dies after some time. I'll report when we know more

I learned Ops Manager has a service tempest-scheduler. The scheduler runs delayed_job which cleans files older 24h in /tmp/ops_manager. This scheduler died somehow. That's why our tmp directory filled up. Old files got deleted after I restarted tempest-scheduler-
We use cfops 2.2.26 and the release information

properly cleans up tmp files on elastic runtime backup
did not seem be related to that problem. Maybe this is related to the machine running cfops.

So, sorry for the noise


Please add metrics for energy consumption, average speed and trip meter

Is your feature request related to a problem? Please describe.
No, it is not related to a problem.
Describe the solution you'd like
I would like to receive the available statistics from the car i.e. averageEnergyConsumption, averageSpeed and tripMeter.
Describe alternatives you've considered
I am unable to think of an alternative right now
Additional context
the URL to visit is curl -X GET 'https://api.volvocars.com/connected-vehicle/v2/vehicles/{vin}/statistics. I tried it and works for my EX30. Thanks for your efforts!

This is already supported by volvo2mqtt. If these sensors are not appearing for you, please send debug logs.

Sep 20 09:33:13 volvo2mqtt [1] - INFO: Using login from token file
Sep 20 09:33:13 volvo2mqtt [1] - INFO: Refreshing credentials
Sep 20 09:33:13 volvo2mqtt [1] - INFO: Using VCCAPIKEY: XXXXXXXXX
Sep 20 09:33:13 volvo2mqtt [1] - INFO: Vin: [''] found!
Sep 20 09:33:14 volvo2mqtt [1] - INFO: Success! Battery Charge Level is supported by your vehicle.
Sep 20 09:33:14 volvo2mqtt [1] - INFO: Success! Battery Capacity is supported by your vehicle.
Sep 20 09:33:14 volvo2mqtt [1] - INFO: Success! Electric Range is supported by your vehicle.
Sep 20 09:33:14 volvo2mqtt [1] - INFO: Success! Estimated Charging Time is supported by your vehicle.
Sep 20 09:33:14 volvo2mqtt [1] - INFO: Success! Charging System Status is supported by your vehicle.
Sep 20 09:33:14 volvo2mqtt [1] - INFO: Success! Charging Connection Status is supported by your vehicle.
Sep 20 09:33:14 volvo2mqtt [1] - INFO: Success! Estimated Charging Finish Time is supported by your vehicle.
Sep 20 09:33:14 volvo2mqtt [1] - INFO: Success! Odometer is supported by your vehicle.
Sep 20 09:33:14 volvo2mqtt [1] - INFO: Success! Last Data Update is supported by your vehicle.
Sep 20 09:33:14 volvo2mqtt [1] - INFO: Success! Active schedules is supported by your vehicle.
Sep 20 09:33:14 volvo2mqtt [1] - INFO: Success! Window Front Left is supported by your vehicle.
Sep 20 09:33:14 volvo2mqtt [1] - INFO: Success! Window Front Right is supported by your vehicle.
Sep 20 09:33:14 volvo2mqtt [1] - INFO: Success! Window Rear Left is supported by your vehicle.
Sep 20 09:33:14 volvo2mqtt [1] - INFO: Success! Window Rear Right is supported by your vehicle.
Sep 20 09:33:14 volvo2mqtt [1] - INFO: Success! Door Front Left is supported by your vehicle.
Sep 20 09:33:14 volvo2mqtt [1] - INFO: Success! Door Front Right is supported by your vehicle.
Sep 20 09:33:14 volvo2mqtt [1] - INFO: Success! Door Rear Left is supported by your vehicle.
Sep 20 09:33:14 volvo2mqtt [1] - INFO: Success! Door Rear Right is supported by your vehicle.
Sep 20 09:33:14 volvo2mqtt [1] - INFO: Success! Tailgate is supported by your vehicle.
Sep 20 09:33:14 volvo2mqtt [1] - INFO: Success! Engine Hood is supported by your vehicle.
Sep 20 09:33:14 volvo2mqtt [1] - INFO: Success! Tank Lid is supported by your vehicle.
Sep 20 09:33:14 volvo2mqtt [1] - INFO: Success! Sunroof is supported by your vehicle.
Sep 20 09:33:14 volvo2mqtt [1] - INFO: Success! Air Conditioning is supported by your vehicle.
Sep 20 09:33:14 volvo2mqtt [1] - INFO: Success! Lock state is supported by your vehicle.
Sep 20 09:33:14 volvo2mqtt [1] - INFO: Success! Force Update Data is supported by your vehicle.
Sep 20 09:33:14 volvo2mqtt [1] - INFO: Success! Location is supported by your vehicle.
Sep 20 09:33:15 volvo2mqtt [1] - INFO: Success! Tire Front Left is supported by your vehicle.
Sep 20 09:33:15 volvo2mqtt [1] - INFO: Success! Tire Front Right is supported by your vehicle.
Sep 20 09:33:15 volvo2mqtt [1] - INFO: Success! Tire Rear Left is supported by your vehicle.
Sep 20 09:33:15 volvo2mqtt [1] - INFO: Success! Tire Rear Right is supported by your vehicle.
Sep 20 09:33:15 volvo2mqtt [1] - INFO: Success! Engine State is supported by your vehicle.
Sep 20 09:33:15 volvo2mqtt [1] - INFO: Failed, Fuel Level is unfortunately not supported by your vehicle.
Sep 20 09:33:15 volvo2mqtt [1] - INFO: Failed, Average Fuel Consumption is unfortunately not supported by your vehicle.
Sep 20 09:33:15 volvo2mqtt [1] - INFO: Failed, Average Energy Consumption is unfortunately not supported by your vehicle.
Sep 20 09:33:15 volvo2mqtt [1] - INFO: Failed, Distance to Empty Tank is unfortunately not supported by your vehicle.
Sep 20 09:33:15 volvo2mqtt [1] - INFO: Success! Distance to Empty Battery is supported by your vehicle.
Sep 20 09:33:15 volvo2mqtt [1] - INFO: Failed, Average Speed is unfortunately not supported by your vehicle.
Sep 20 09:33:15 volvo2mqtt [1] - INFO: Failed, Hours to Service is unfortunately not supported by your vehicle.
Sep 20 09:33:15 volvo2mqtt [1] - INFO: Success! Distance to Service is supported by your vehicle.
Sep 20 09:33:15 volvo2mqtt [1] - INFO: Success! Time to Service is supported by your vehicle.
Sep 20 09:33:15 volvo2mqtt [1] - INFO: Success! Service warning status is supported by your vehicle.
Sep 20 09:33:15 volvo2mqtt [1] - INFO: Success! Washer Fluid Level warning is supported by your vehicle.
Sep 20 09:33:15 volvo2mqtt [1] - INFO: Success! API Backend status is supported by your vehicle.
Sep 20 09:33:15 volvo2mqtt [1] - INFO: Success! Update Interval is supported by your vehicle.
Sep 20 09:33:15 volvo2mqtt [1] - INFO: Failed, Warnings is unfortunately not supported by your vehicle.
Sep 20 09:33:17 volvo2mqtt [1] - INFO: Sending mqtt update...
Sep 20 09:33:18 volvo2mqtt [1] - INFO: Mqtt update done. Next run in 300 seconds.
Indeed logs say is not supported although I am able to curl it from the URL I sent you

So, as said, enable debug and send some logs

Sorry, my bad
So it seems to get the info but thinks it fails
Sep 20 09:40:17 volvo2mqtt [1] - INFO: Failed, Fuel Level is unfortunately not supported by your vehicle.
Sep 20 09:40:17 volvo2mqtt [1] - DEBUG: Starting GET call against https://api.volvocars.com/connected-vehicle/v2/vehicles/{0}/statistics
Sep 20 09:40:17 volvo2mqtt [1] - DEBUG: Response status code: 200
Sep 20 09:40:17 volvo2mqtt [1] - DEBUG: {
"data" : {
"averageEnergyConsumptionAutomatic" : {
"value" : 18.700000762939453,
"unit" : "kWh/100km",
"timestamp" : "2024-09-20T06:40:17.500Z"
},
"averageSpeedAutomatic" : {
"value" : 46,
"unit" : "km/h",
"timestamp" : "2024-09-20T05:45:20.174Z"
},
"tripMeterManual" : {
"value" : 1873.4,
"unit" : "km",
"timestamp" : "2024-09-20T05:45:20.174Z"
},
"tripMeterAutomatic" : {
"value" : 28.2,
"unit" : "km",
"timestamp" : "2024-09-20T05:45:20.174Z"
},
"distanceToEmptyBattery" : {
"value" : 252,
"unit" : "km",
"timestamp" : "2024-09-20T05:45:20.174Z"
}
}
}

Would you please upload your complete log ?

Ha, they chaned the naming...
The "old" data key where average_speed for ex30 it is averageSpeedAutomatic

Please try v1.10.0

I could be wrong , I see Failed, Average Fuel Consumption is unfortunately not supported by your vehicle but I am getting the values

No, Fuel Level and Average Fuel isn't Energy level and Average Energy Consumption, so everything works as expected.

Great, thanks!!


[RBAC] First pass at fixing existing eda-server RBAC tests

Getting a start on this, @Dostonbek1

Taking out of draft, just to see if we get CI results.

sigh

Got results, checkpointing:
103 failed, 292 passed, 1 skipped, 2 warnings, 84 errors in 122.80s (0:02:02)

more failed... but more passed
122 failed, 336 passed, 22 skipped, 3 warnings in 119.84s (0:01:59)

Progress, but slow...
109 failed, 347 passed, 24 skipped, 3 warnings in 117.41s (0:01:57)

Update
107 failed, 346 passed, 24 skipped, 3 warnings in 118.77s (0:01:58)


Add validation to CloudWatch metric query name

For context, the metric query name is used by the source to populate the ID field used to identify the query with CloudWatch for follow-up queries and manipulation. The name must adhere to the following regexp as per AWS (https://docs.aws.amazon.com/AmazonCloudWatch/latest/APIReference/API_MetricDataQuery.html):
[a-z][a-zA-Z0-9_]*

Tip: the second part can we shortened to \w*.

Doesn't \w include more than alphanumeric?

Regex101.com says

\w matches any word character (equivalent to [a-zA-Z0-9_])

I wouldn't have known without it to be honest 😄

Wow my memory is getting rusty: https://media.giphy.com/media/83QtfwKWdmSEo/giphy.gif


PK: ECDSA signing

In library/pk_wrap.c, provide an implementation of ecdsa_sign_wrap to use psa_sign_hash() instead of mbedtls_ecdsa_write_signature().
This will require creating a temporary PSA private key with appropriate permissions. An example of something similar, but with a public key, can be found in ecdsa_verify_wrap() in the same file (note: there are two definitions of ecdsa_very_wrap(), we want to look at the one used with MBEDTLS_USE_PSA_CRYPTO).
This will also require transcoding the resulting signature, as PSA doesn't output ECDSA signatures in the format we expect. We already have a helper function for that: pk_ecdsa_sig_asn1_from_psa(), used in psa_sign_hash(), which can be re-used here.
Similar: #5160 and #5162 are also creating a temporary PSA private key.

@mpg Can you assign me this issue and link #5518 ?


Add an example for useSemanticDateRange

Hello SAP Fiori Elements Feature Showcase Team,
it would be great if the Showcase can be extended with an example that implements
useSemanticDateRange.
Thank you in advance.
Best Regards
Gregor

Hi @gregorwolf,
I am sadly currently quite busy with other tasks - however I will try to have a look in May at the topic. The internal feature showcase of this repo already includes it and in May I will hopefully have a look at updating this repo.
BR,
Marten

Example is now added


datapath/node: avoid fatal on daemon init when node routes fail.

Prior to 9486e7b731903eb949cb2fcd70f08e1da386dc5d the call to reconcile the node (i.e. nodeUpdated) did not have errors handled. This meant that (*linuxNodeManager).NodeConfigurationChanged(...) would not return an error if there the underlying node reconciliation failed.
This was the assumption prior to v1.15 that node reconciliation tasks log errors in-line and continue exection without returning early. Following these changes, the call to NodeConfigurationChanged will now return an error if the underlying nodeUpdated call fails.
Issue #31843 is a result of the now incorrect expectation on not terminating execution in case of nodeUpdated failure where in cases where (unreachable) node routes for remote nodes failing was previously silently logged - will now cause the agent to terminate on init if this fails. There may be other such regressions built on these expectations.
This reverts to behavior found in v1.14 where this will log nodeUpdated failures and continue execution.
Fixes: #31843

This got closed and the branch commit changed, recreating this here