PR:  History plugin: Add an option to show/hide line numbers

Fixes #970.

Hello @csabella! Thanks for submitting the PR.

In the file spyder/plugins/tests/test_history.py, following are the PEP8 issues :

Line 14:1: E265 block comment should start with '# '
Line 16:1: E265 block comment should start with '# '
Line 19:1: E265 block comment should start with '# '
Line 21:1: E265 block comment should start with '# '
Line 38:1: E265 block comment should start with '# '
Line 40:1: E265 block comment should start with '# '
Line 71:1: E265 block comment should start with '# '
Line 73:1: E265 block comment should start with '# '
Line 197:80: E501 line too long (83 > 79 characters)

I added some tests for history.py, but not complete coverage in case the tests weren't the way you would like them.  I tried to follow existing patterns, but I didn't do anything with simulating user activity via qtbot.  Please let me know if the tests are OK or if they should have been done differently so that I can make sure to apply the correct style if I write more of them.  Thanks!

@csabella, thanks a lot for your contribution!
@rlaverde, please review this one.

This is a very good addition @csabella, specially because of all the tests you added! Thanks for taking the time to create them.

Thanks @csabella, this is going in!

Thank you!


Unnecessary constants module

In the documentation the constants section doesn't properly render unless I explicitly use .. autodata:: with the constants module. This is a known Sphinx issue: https://github.com/sphinx-doc/sphinx/issues/6495 and can be addressed after Sphinx fixes it.

This is fairly out of date, given the new structure


How to use vacuum to delete old files created by compaction without losing ability to time travel?

I am running some operations for compaction of files. Now I want to delete the old files left out after compaction to avoid redundancy of same data. But if I use vacuum command, then I am not able to do time travel as all the old states of data get deleted. So, what is the better way to delete old files left out due to compaction without losing ability to time travel?

Yes, I'll need the pre-compaction files

I have the same question. @Priyanshu-Mittal have you found a solution to this?

This is currently not possible. To make this possible we would have to do fine-grained tracking of which version ranges each data file is valid for... which is a lot more metadata and a lot of complexity to keep track of.

Closing this as currently Delta transaction logs don't provide the enough information to support this feature request. Feel free to re-open it if you have any suggestion to support this.


Exception thrown: "java.lang.IndexOutOfBoundsException: Index: 6, Size: 4"

Hi,
I generated the input file for pre from BAM file (generated by Babraham HiCUPs) with the kind solution provided in this forum. Subsequently, I ran pre command, and have generated the .hic file. I am not sure if it is successful as I have encountered an exception.
java.lang.IndexOutOfBoundsException: Index: 6, Size: 4         at java.util.ArrayList.rangeCheck(ArrayList.java:635)         at java.util.ArrayList.get(ArrayList.java:411)         at java.util.Collections$UnmodifiableList.get(Collections.java:1211)         at juicebox.tools.utils.original.AsciiPairIterator.advance(AsciiPairIterator.java:143)         at juicebox.tools.utils.original.AsciiPairIterator.next(AsciiPairIterator.java:247)         at juicebox.tools.utils.original.Preprocessor.computeWholeGenomeMatrix(Preprocessor.java:496)         at juicebox.tools.utils.original.Preprocessor.writeBody(Preprocessor.java:374)         at juicebox.tools.utils.original.Preprocessor.preprocess(Preprocessor.java:286)         at juicebox.tools.clt.old.PreProcessing.run(PreProcessing.java:105)         at juicebox.tools.HiCTools.main(HiCTools.java:97)
My question is how do I know if the hic file generated was complete and did not stop at the point where the exception was thrown?
Thank you.
PS:
Code for converting bam to input file for pre:
samtools view read1_2.hicup.bam | awk 'BEGIN {FS="\t"; OFS="\t"} {name1=$1; str1=and($2,16); chr1=substr($3, 4); pos1=$4; mapq1=$5; getline; name2=$1; str2=and($2,16); chr2=substr($3, 4); pos2=$4; mapq2=$5; if(name1==name2) { if (chr1>chr2){print name1, str2, chr2, pos2,1, str1, chr1, pos1, 0, mapq2, mapq1} else {print name1, str1, chr1, pos1, 0, str2, chr2, pos2 ,1, mapq1, mapq2}}}'  | sort -k3,3d -k7,7d > Arrowhead.input
my command for generating .hic file:
java -Xmx2g -jar /mnt/projects/wlwtan/cardiac_epigenetics/george/juicer/juicer_tools.1.6.2_linux_jcuda.0.8.jar pre -f mm9_DpnII.txt -q 30 Arrowhead.input Arrowhead.hic mm9

Hello,
The hic file creation stopped when the error was thrown. The awk code looks
correct (except for one issue that I will say more about below); however,
the hic file creation stopped because there were not enough fields on one
line.
I would check that every line has 11 fields; here is a simple script to do
that:
awk 'NF!=11{print "Problem at line",NR; exit}' Arrowhead.input
Finally, I see from your pre command that you are sending in the fragment
file. There’s no point to doing this if you set the fragment number to 0
and 1. In other words, you should drop the “-f mm9_DpnII.txt”, or if you
want fragment delimited resolutions, use the following code:
samtools view read1_2.hicup.bam | awk 'BEGIN {FS="\t"; OFS="\t"}
{name1=$1; str1=and($2,16); chr1=substr($3, 4); pos1=$4; mapq1=$5;
cigar1=$6; seq1=$10; getline; name2=$1; str2=and($2,16);
chr2=substr($3, 4); pos2=$4; mapq2=$5; cigar2=$6; seq2=$10;
if(name1==name2) { if (chr1>chr2){print str2, chr2, pos2, str1, chr1,
pos1, mapq2, cigar2, seq2, mapq1, cigar1, seq1, name2, name1} else
{print str1, chr1, pos1, str2, chr2, pos2, mapq1, cigar1, seq1, mapq2,
cigar2, seq2, name1, name2}}}' | sort -k3,3d -k7,7d > fragment.input
perl fragment.pl fragment.input Arrowhead.input mm9_DpnII.txt
And then use the same command as before to create the .hic file.
We do recommend using the Juicer pipeline for creating these files; we
handle duplicates and chimeras differently from other pipelines, the
details of which are available in the supplementary materials of
Rao&Huntley et al. | Cell 2014 and Durand&Shamim et al. | Cell Systems 2016.
Best
Neva

On Tue, Jul 4, 2017 at 4:25 AM, lwtan90<EMAIL_ADDRESS>wrote:

Hi,
I generated the input file for pre from BAM file (generated by Babraham
HiCUPs) with the kind solution provided in this forum. Subsequently, I ran
pre command, and have generated the .hic file. I am not sure if it is
successful as I have encountered an exception.
java.lang.IndexOutOfBoundsException: Index: 6, Size: 4 at
java.util.ArrayList.rangeCheck(ArrayList.java:635) at
java.util.ArrayList.get(ArrayList.java:411) at java.util.Collections$
UnmodifiableList.get(Collections.java:1211) at
juicebox.tools.utils.original.AsciiPairIterator.advance(AsciiPairIterator.java:143)
at juicebox.tools.utils.original.AsciiPairIterator.next(AsciiPairIterator.java:247)
at juicebox.tools.utils.original.Preprocessor.computeWholeGenomeMatrix(Preprocessor.java:496)
at juicebox.tools.utils.original.Preprocessor.writeBody(Preprocessor.java:374)
at juicebox.tools.utils.original.Preprocessor.preprocess(Preprocessor.java:286)
at juicebox.tools.clt.old.PreProcessing.run(PreProcessing.java:105) at
juicebox.tools.HiCTools.main(HiCTools.java:97)
My question is how do I know if the hic file generated was complete and
did not stop at the point where the exception was thrown?
Thank you.
PS:
Code for converting bam to input file for pre:
samtools view read1_2.hicup.bam | awk 'BEGIN {FS="\t"; OFS="\t"}
{name1=$1; str1=and($2,16); chr1=substr($3, 4); pos1=$4; mapq1=$5; getline;
name2=$1; str2=and($2,16); chr2=substr($3, 4); pos2=$4; mapq2=$5;
if(name1==name2) { if (chr1>chr2){print name1, str2, chr2, pos2,1, str1,
chr1, pos1, 0, mapq2, mapq1} else {print name1, str1, chr1, pos1, 0, str2,
chr2, pos2 ,1, mapq1, mapq2}}}' | sort -k3,3d -k7,7d > Arrowhead.input
my command for generating .hic file:
java -Xmx2g -jar /mnt/projects/wlwtan/cardiac_epigenetics/george/juicer/
juicer_tools.1.6.2_linux_jcuda.0.8.jar pre -f mm9_DpnII.txt -q 30
Arrowhead.input Arrowhead.hic mm9
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/theaidenlab/juicer/issues/22, or mute the thread
https://github.com/notifications/unsubscribe-auth/ABWiW4f0LHBGRzcAVmp9a6DNT9unqOTdks5sKaKegaJpZM4OM0Zm
.

--
Neva Cherniavsky Durand, Ph.D.
Staff Scientist, Aiden Lab
www.aidenlab.org

Hi Neva,
Thank you for your quick reply. I have determined that the error was due to generation of incomplete input file (the process was cut off half way). Still, your reply will help shed more lights on how to incorporate fragment information into the input file! Thank you.
Wilson


Build Error

An error occurs when building.
C:\MagicScript\sample-model>magic-script build -i
npm ERR! path git
npm ERR! code ENOENT
npm ERR! errno ENOENT
npm ERR! syscall spawn git
npm ERR! enoent Error while executing:
npm ERR! enoent undefined ls-remote -h -t https://github.com/creationix/rollup-plugin-commonjs.git
npm ERR! enoent
npm ERR! enoent
npm ERR! enoent spawn git ENOENT
npm ERR! enoent This is related to npm not being able to find a file.
npm ERR! enoent
npm ERR!      C:\Users<<USER_NAME>>\AppData\Roaming\npm-cache_logs\2019-03-30T20_13_22_207Z-debug.log
C:\Users<<USER_NAME>>\AppData\Roaming\npm\node_modules\magic-script-cli\commands\build.js:15
throw err;
^
Error: Command failed: npm install
npm ERR! path git
npm ERR! code ENOENT
npm ERR! errno ENOENT
npm ERR! syscall spawn git
npm ERR! enoent Error while executing:
npm ERR! enoent undefined ls-remote -h -t https://github.com/creationix/rollup-plugin-commonjs.git
npm ERR! enoent
npm ERR! enoent
npm ERR! enoent spawn git ENOENT
npm ERR! enoent This is related to npm not being able to find a file.
npm ERR! enoent
npm ERR!      C:\Users<<USER_NAME>>\AppData\Roaming\npm-cache_logs\2019-03-30T20_13_22_207Z-debug.log
at ChildProcess.exithandler (child_process.js:297:12)
at ChildProcess.emit (events.js:197:13)
at maybeClose (internal/child_process.js:984:16)
at Process.ChildProcess._handle.onexit (internal/child_process.js:265:5)

C:\MagicScript\sample-model>

Windows 10 Version 1803(OS build 17134.648)
NodeJS v11.10.0
npm v6.9.0
Lumin SDK v0.20.0
magic-script-cli v.1.0.3
Thanks

Hey @tokufxug  I tried to reproduce on my windows machine but didn't see any problems.
I'm using:
NodeJS V10.12.0
npm v6.4.1
Can you check that you have access to https://github.com/creationix/rollup-plugin-commonjs.git since it's the failing depencency.

Hi Sadao-san (@tokufxug) ,
I've tried to reproduce it on my personal MS Windows laptop, but it did work as intended.
The steps I've performed are:

install MxS CLI:

npm install -g magic-script-cli

Install Lumin SDK and Lumin Runtime SDK

Generate and download certificate

Set-up env:

%USERPROFILE%/MagicLeap/mlsdk/v0.20.0/envsetup.bat
SET MLCERT=

Install dependencies:

cd sample-model
npm i

Execute build step:

magic-script build
Could you try to repeat these steps?
Leonid.
node v10.15.2
npm 6.9.0
magic-script 1.0.3

The problem that can not be built has been resolved.
0. I uninstalled NodeJS v11.10.0 and installed NodeJS v.10.15.3.

Manually delete the following

%USERPROFILE%\AppData\Roaming\npm
%USERPROFILE%\AppData\Roaming\npm-cache
Also reinstall magic-script.

1. Set "C:\PythonXX\Scripts" to user environment variable. (XX is the version number. Have Python installed)
2. Install and set up the following because rollup-plugin-commonjs is required.

Install Git for Windows (https://gitforwindows.org/)
Set Git as a User Environment Variable.

3. PC restart.
4. npm install --save-dev rollup-plugin-commonjs
5. magic-script build -i
Thanks.
node v10.15.3
npm 6.4.1
magic-script 1.0.3
Sadao Tokuyama
https://twitter.com/tokufxug


Unable to see run history contents after changing 'Trigger access option' back to default value 'Any IP'

Describe the Bug with repro steps

Create a new consumption logic app with any simple trigger/action
Change workflow settings -> trigger access option to "Specific IP ranges"
Save
Change workflow settings -> trigger access option back to "Any IP"
Save
Observe the resource JSON still has "accessControl" node
Navigate to the logic app run history
Observe run history content error: "Unauthorized: Your IP is not in the access IP range, ..."

What type of Logic App Is this happening in?
Consumption (Portal)
Are you using new designer or old designer
Old Designer
Did you refer to the TSG before filing this issue? https://aka.ms/lauxtsg
Yes
Workflow JSON
{
    "definition": {
        "$schema": "https://schema.management.azure.com/providers/Microsoft.Logic/schemas/2016-06-01/workflowdefinition.json#",
        "actions": {
            "Initialize_variable": {
                "inputs": {
                    "variables": [
                        {
                            "name": "a",
                            "type": "boolean",
                            "value": true
                        }
                    ]
                },
                "runAfter": {},
                "type": "InitializeVariable"
            }
        },
        "contentVersion": "<IP_ADDRESS>",
        "outputs": {},
        "parameters": {},
        "triggers": {
            "Recurrence": {
                "evaluatedRecurrence": {
                    "frequency": "Minute",
                    "interval": 3
                },
                "recurrence": {
                    "frequency": "Minute",
                    "interval": 3
                },
                "type": "Recurrence"
            }
        }
    },
    "parameters": {}
}

Screenshots or Videos

Browser
Microsoft Edge for Business
Version 118.0.2088.57 (Official build) (64-bit)
Additional context
internal, feel free to ping me on Teams

I've created a fix (in our portal-hosting respository) - it should be out in all regions by 11/3


CAE is broken when token is served from the cache (claims should bypass the token cache)

Core Library
MSAL Node (@azure/msal-node)
Core Library Version
9.0.1
Wrapper Library
Not Applicable
Wrapper Library Version
1.14.5
Public or Confidential Client?
Confidential
Description
Context
MSAL handle claims as follows:

User is expected to add claims in json format (MSALs don't need validate this)
If claims are added, MSAL must not serve an access token from the cache
Point 2 above does not apply to client capabilities

Actual behavior:
MSAL's client_credential, OBO and refres_token (shared between PCA and CCA) do not respect point 2 above.
Ref designs:
https://identitydivision.visualstudio.com/DevEx/_git/AuthLibrariesApiReview?path=/ClientCapabilities/overview.md&_a=contents&version=GBdev
https://identitydivision.visualstudio.com/DevEx/_git/AuthLibrariesApiReview?path=/ClaimsParameters/overview.md&version=GBdev&line=180&lineEnd=181&lineStartColumn=1&lineEndColumn=1&lineStyle=plain&_a=contents
Error Message
No response
Msal Logs
No response
MSAL Configuration
with claims

Relevant Code Snippets
n/a

Reproduction Steps
see desc
Expected Behavior
bypass the cache
Identity Provider
Azure AD / MSA
Browsers Affected (Select all that apply)
None (Server)
Regression
No response
Source
Internal (Microsoft)

CC @sameerag for public client implication.

You may want to chat with @hectormmg. He added the requested claims to our cache lookups in #4296

Ah ok, so MSAL Js went on the route of indexing access tokens by claims hash? @hectormmg - would this apply automatically to AcquireTokenByCredential and AcquireTokenOnBehalfOf, both of which looks in the cache by themselves?

ping @hectormmg

@Robbie-Microsoft - sorry, I forgot to update this. MSAL JS uses the claims as part of the AT cache key. This is fine.

@Robbie-Microsoft - we can assume this works, but it should be easy to write a unit test that demonstrates that it works. Something like;
AcquireTokenForCredenatial() -> goes to ESTS
AcquireTokenForCredentails(claims1) -> goes to ESTS
AcquireTokenForCredentails(claims2) -> goes to ESTS
AcquireTokenForCredentails(claims1) -> from cache
AcquireTokenForCredentails(claims2) -> from cache


fix(GridFS): emit error on bad end options

Description
Errors related to handling the start/end options for createDownloadStream
did not propagate correctly.
NODE-2623
What changed?
Are there any files to ignore?

Closed in favor of #2394


Add navigation buttons to the bottom of the RCOS users page

addresses issue #147 as well

addresses #147 as well

Mike and Brian


Memory Leak Fix - CPM Optimization

I noticed that CancellationTokenSource is being leaked by OB and it was causing massive memory consumption as it is never GC collected .
made small changes to CPM calculation to use int directly instead of datetime .
i have a note regarding SslStream :

TLS 1.3 does not work on windows machines, this due to framework limitations not the code.
Allowed CipherSuites can only be used on linux and mac only. (this is also a windows issue not OB).

Just wanted to make you aware of that if any issues come up.

Hey, thank you for the changes.
I am already aware of the 2 notes you made about SslStream. I am planning to move to BouncyCastle in the future as soon as they support TLS 1.3 on their C# library as well (currently only java)

I Use WolfSsl in my personal Projects It is UltraFast C written multiplatform.
It also has a c# wrapper in the repo.
But I don't use the wrapper,  as I am a performance junkie. XD
if you want I can help.

@RydjGit I would be really glad to talk a little with you in private, please contact me on my mail or on the forum if you have time ^_^ https://discourse.openbullet.dev/u/ruri/


getting all subresources using the browser

DOPE project!
I saw your earlier version where you were using puppeteer
I think you probably want to bring it back... :)
The current impl just fetches a single HTTP resource. But.. these embeds typically require quite a few other requests to actually be functional. (the youtube embed needs like 15 requests.. ). the gtag script actually fetches the analytics.js script soon after.
So yeah i think you'll want to go back to the cool initialisationHtml pattern you had and then look at all the network requests that happen and sum them up.
i don't think you need the setRequestInterception stuff...  that'll probably cause more problems than you want. but the request events should come in by default.
that said..... we've noticed that pptr's implementation means out-of-process-iframes may not have network requests consistently reported. (it's being fixed). perhaps that's what you also ran into?

Thanks Paul :)
Yeah - the Puppeteer version was the way I originally envisioned it working, but it was giving results that were inconsistent with regular Chrome.
I'll take another pass at getting it working this weekend

Have implemented subresources now - am getting fairly consistent results by using CDPSession & listening for various Network events


Docker containers stuck in restart/exit loop

The conjure docker_application immediately exits upon start and the other containers get stuck in a loop restarting. After a few seconds, the restarting timers reset.
Ex:
Starting zbalance    ... done
Starting redis       ... done
Starting detector    ... done
Starting application ... done
hazenluk@curveball:~/docker-trial/conjure/docker$ docker ps -a
CONTAINER ID   IMAGE                COMMAND                  CREATED        STATUS                          PORTS     NAMES
4bb1cbb5a821   application:latest   "/opt/conjure/applic…"   20 hours ago   Exited (2) 5 seconds ago                  docker_application_1
b8f8ae843825   detector:latest      "/entrypoint.sh"         20 hours ago   Up 1 second                               docker_detector_1
cd77f845ef61   redis:alpine         "docker-entrypoint.s…"   20 hours ago   Restarting (1) 1 second ago               docker_redis_1
a5773f9dcc80   zbalance:latest      "bash /entrypoint.sh"    20 hours ago   Restarting (255) 1 second ago             docker_zbalance_1
hazenluk@curveball:~/docker-trial/conjure/docker$ docker ps -a
CONTAINER ID   IMAGE                COMMAND                  CREATED        STATUS                           PORTS     NAMES
4bb1cbb5a821   application:latest   "/opt/conjure/applic…"   20 hours ago   Exited (2) 16 seconds ago                  docker_application_1
b8f8ae843825   detector:latest      "/entrypoint.sh"         20 hours ago   Restarting (0) 2 seconds ago               docker_detector_1
cd77f845ef61   redis:alpine         "docker-entrypoint.s…"   20 hours ago   Restarting (1) 4 seconds ago               docker_redis_1
a5773f9dcc80   zbalance:latest      "bash /entrypoint.sh"    20 hours ago   Restarting (255) 4 seconds ago             docker_zbalance_1
hazenluk@curveball:~/docker-trial/conjure/docker$ docker ps -a
CONTAINER ID   IMAGE                COMMAND                  CREATED        STATUS                           PORTS     NAMES
4bb1cbb5a821   application:latest   "/opt/conjure/applic…"   20 hours ago   Exited (2) 19 seconds ago                  docker_application_1
b8f8ae843825   detector:latest      "/entrypoint.sh"         20 hours ago   Restarting (0) 5 seconds ago               docker_detector_1
cd77f845ef61   redis:alpine         "docker-entrypoint.s…"   20 hours ago   Restarting (1) 6 seconds ago               docker_redis_1
a5773f9dcc80   zbalance:latest      "bash /entrypoint.sh"    20 hours ago   Restarting (255) 6 seconds ago             docker_zbalance_1```

Thanks, your log looks exactly like mine so the issues seem to be common. I was able to get the detector to run (even w/out anything else running) by changing the bind mount to the host machine's private key file to correct path in the docker-compose file. For zbalance I changed CJ_IFACE (in docker-compose) to be specified to an interface with PF_RING ZC. However, even after I specified the correct interface I still get the same error as before.

I probably should have updated this a couple weeks ago, but anyways:
The segfault in application_1 was due to PhantomIPSelector being unable to properly read the phantom_subnets.toml file, which was because the file in the docker directory contained floating point weights which should have been integer weights instead. This has since been updated in the repo.
redis and zbalance were failing because there was already a conjure station running.


Cancelling download doesn't cleanup properly

(Using Linux version)
These steps causes a download animation to loop forever without possibility to stop it:

select a blob
press download
press cancel at "save file" dialog
select download again
press save

(If I repeat steps 2-3 there will be multiple items on the download list.)
This is printed on the console:
[11584:0922/130434:ERROR:nw_shell.cc(335)] Error: ENOENT: no such file or directory, open ''
at Error (native)
[11584:0922/130434:INFO:CONSOLE(125)] "Uncaught Error: ENOENT: no such file or directory, open ''", source: events.js (125)
Then, when closing the application:
[11611:0922/131134:WARNING:channel.cc(553)] Failed to send message to ack remove remote endpoint (local ID 1, remote ID 1)
[11611:0922/131134:WARNING:channel.cc(320)] RawChannel write error
Parent failed to complete crash dump.

thanks for reporting @lakaila. I actually knew about this issue when we were implementing it. It turns out the azure-storage-node doesn't offer a cancellation mechanism for blob downloads that are underway. Which is why we didn't originally implement it. There's probably another way we can though just wasn't prioritized at the time.


Hope expose the base_url by setting the OPENAI_API_BASE environment variable or setBaseURL

@ThatcherC
base_url is not necessarily https://openai.com

using OpenAI
provider = OpenAI.OpenAIProvider(
api_key=ENV["OPENAI_API_KEY"],
base_url=ENV["OPENAI_BASE_URL_OVERRIDE"]
)
response = create_chat(
provider,
"gpt-3.5-turbo",
[Dict("role" => "user", "content" => "Write some ancient Greek poetry")]
)
like this


Polish app cards

This PR also fixes a typo in the {% octicon %} tags.

Hey @j-f1! Can you please elaborate on what this PR changes, aside from the typo in the {% octicon %} tags? I pulled down your branch and compared it the live site and didn't see any difference in the app cards. Thanks 💖

@JasonEtco

Can you please elaborate on what this PR changes

Before:

After:

@j-f1 thanks for the screenshots, sorry about the delay on my part. I've looked for the Before bug in Chrome, Edge, Safari and Firefox (the new beta version) and I haven't seen it. What browser did you catch this in?

I've looked for the Before bug in Chrome, Edge, Safari and Firefox (the new beta version) and I haven't seen it.

I saw the boxes being different heights on Safari. It might be that it’s been fixed in Primer, or that Safari is rendering the content incorrectly. I can see the sharp corners bug on Safari and Chrome.

@j-f1 I've seen bugs like that in Safari, I'm curious why I'm not seeing it now. I'll do some more digging 👍

Some more digging later, I still don't see where this occurs, but I'm going to merge it anyway since it seems to happening for more people than me, and these changes to really harm anything. Thanks @j-f1, and sorry about the delay!


[Feature request] Discord login with email

Hey i have an feature request. In the beginning of the bot development it was possible to connect the bot via email credentials. Could you pls add this feature again?

This is no longer supported by discord itself and can result in getting your account banned.

Short answer, no. Long answer no with this stance by Discord https://support.discordapp.com/hc/en-us/articles/115002192352-Automated-user-accounts-self-bots-
Sorry if this disappoints you.

Also: the only reason it was usable is because bot accounts did not exist back then and it was fine to make bots on normal accounts.


Added a new extension i.e., "Word_Definition"

I would like to create a "word definition" extension that would tell the definition of the word. please assign it me.(GSSOC'22)

@abhinay99190, There is an extension Meaning of Word already present for the same, are you also trying to build like this. If yes then you can enhance it, if not then kindly explain your features in brief

Also Word of Day is there , you can enhance this also

I am added Word Definition web app...!

### Word Definition
The Word Definition app will show the definition of the following words.

### Tech Stack

### Client:--

### API Reference
API:-- MERRIAM-WEBSTER'S DEVELOPER CENTER

Screenshots / Gif (Optional) 📸
### In the first image we can see that when we type correct words we can see their definition what the word means.

### In the second image we can that when we type wrong words it suggested me the correct word.

### _In the third image we can  that when we type random words it gives "no result found" _

###By Abhinay singh_

I share you the overall structure of my project. Please review it and confirm that is it same as "Meaning of Word" and "Word of Day" as you mentioned. If it is same then I will do some other project and contribute in your project.

@abhinay99190 its similar to Meaning of Word except in yours there are suggestions when the wrong word is entered, what you can do is enhance Meaning of Word's feature of suggestion and no result found.

Would you like to work on enhancement?

So can I create this project separately or will I have to enhance the feature in the "Meaning of Word" itself? Please suggest me

You can work on enhancing the present one so that it will become more feasible , I can assign you

thank you @harshita214  and I will definitely enhance it for better use.  Thank you for assign it to me.

Completed - #215


Add support for all current supported dotnet versions.

Adds support for net6.0 to ensure dotnet tool installs work on all currently supported dotnet versions. Keeps unit tests at net7.0 as this is the latest dotnet version. Before / after of nuget:

Bumps setup-dotnet to v3 to enable support for many versions of dotnet to be installed at once, as documented here: https://github.com/actions/setup-dotnet#:~:text=Multiple version installation%3A

Looks like there's a problem with this PR. I merged before the build was complete, but have reverted.
The build fails here: https://github.com/Webreaper/CentralisedPackageConverter/actions/runs/6104545855
I tried explicitly specifying the RTI via this commit: https://github.com/Webreaper/CentralisedPackageConverter/pull/31/commits/31039a0e70de3bb86c41370df1573fdce54120c9 but still no joy.
I think it's this that's causing it: https://github.com/dotnet/sdk/issues/30251....


Usage docs for OpenStack clouds

This should apply to vanilla OpenStack clouds, such as Rackspace
Private Cloud powered by OpenStack™.

Nevermind, this needs more work.


'make check' fails on arm

I'm trying to compile on a Raspberry Pi 3 and I'm getting failures in 'make check'.  Ideas?
=========================================
   gperftools 2.5.91: ./test-suite.log
=========================================

# TOTAL: 48
# PASS:  42
# SKIP:  0
# XFAIL: 0
# FAIL:  6
# XPASS: 0
# ERROR: 0

.. contents:: :depth: 2

FAIL: sampling_test.sh
======================

Testing heap output...
Using local file /gperftools/.libs/lt-sampling_test.
Using local file /tmp/sampling_test_dir/out.heap.
Adjusting heap profiles for 1-in-524288 sampling rate
Heap version 2
Use of uninitialized value $address in exists at ./src/pprof line 2845.
FAILED.  Output from ./src/pprof --text /gperftools/.libs/lt-sampling_test /tmp/sampling_test_dir/out.heap
----
Using local file /gperftools/.libs/lt-sampling_test.
Using local file /tmp/sampling_test_dir/out.heap.
Adjusting heap profiles for 1-in-524288 sampling rate
Heap version 2
Use of uninitialized value $address in exists at ./src/pprof line 2845.
Total: 55.0 MB
----

FAIL: heap-checker_unittest.sh
==============================

Testing ./heap-checker_unittest with HEAPCHECK= ... OK
Testing ./heap-checker_unittest with HEAPCHECK=local ... FAILED
Output from the failed run:
----
WARNING: Perftools heap leak checker is active -- Performance may suffer
Segmentation fault
----

FAIL: heap-checker-death_unittest.sh
====================================

Testing ./heap-checker_unittest with HEAPCHECK= ... PASS
Testing ./heap-checker_unittest with HEAP_CHECKER_TEST_NO_THREADS=1 ... FAIL
Wrong exit code: expected: '0'; actual: 139
Output did not match '^PASS$'
Output from failed run:
---
WARNING: Perftools heap leak checker is active -- Performance may suffer
---

FAIL: sampling_debug_test.sh
============================

Testing heap output...
Using local file /gperftools/.libs/lt-sampling_test.
Using local file /tmp/sampling_test_dir/out.heap.
Adjusting heap profiles for 1-in-524288 sampling rate
Heap version 2
Use of uninitialized value $address in exists at ./src/pprof line 2845.
FAILED.  Output from ./src/pprof --text /gperftools/.libs/lt-sampling_test /tmp/sampling_test_dir/out.heap
----
Using local file /gperftools/.libs/lt-sampling_test.
Using local file /tmp/sampling_test_dir/out.heap.
Adjusting heap profiles for 1-in-524288 sampling rate
Heap version 2
Use of uninitialized value $address in exists at ./src/pprof line 2845.
Total: 73.7 MB
----

FAIL: heap-checker_debug_unittest.sh
====================================

Testing ./heap-checker_unittest with HEAPCHECK= ... OK
Testing ./heap-checker_unittest with HEAPCHECK=local ... FAILED
Output from the failed run:
----
WARNING: Perftools heap leak checker is active -- Performance may suffer
Segmentation fault
----

FAIL: profile_handler_unittest
==============================

/gperftools/.libs/lt-profile_handler_unittest: symbol lookup error: /gperftools/.libs/lt-profile_handler_unittest: undefined symbol: _Z19ProfileHandlerResetv

I have a (maybe) similar problem on SLES11.
See https://gist.github.com/volviq/7f097bcbb349f17cc188ed0d407908e3  for the test-suite.log and
https://gist.github.com/volviq/d0b281dddde5685fb37812a5294a10c8  for the make check invocation.
To get the build to work I needed to use the suggested compiler flags " -D__STDC_LIMIT_MACROS -D__STDC_CONSTANT_MACROS"  as mentioned in https://github.com/gperftools/gperftools/issues/887
The invocations states I should email the report to<EMAIL_ADDRESS>- as the groups seems to be way less active then the github project, I assumed it makes more sense to post the problem here?
If I choose to run our Software which links the library, our test case which runs valgrinds memcheck64 causes a hang of the test or the application.

SIZE_MAX is unrelated to this issue.
So, indeed, arm (and arm64) don't have fully functional heap checker. If you configure with --enable-minimal, all tests should pass.

@alk oh, right, this bug is intended to be Arm related. Should I create another one for SLES11 x64 systems?

SIZE_MAX issue you're referring to is fixed now. Try 2.6rc3 that I just tagged.

As for arm64, I just double checked on my arm64 chromebook with debian sid chroot. And only heap checker unittests fail. Sampling and profiling tests pass. Double check that you're using libunwind.

alk:
SIZE_MAX is  fixed, heap problem still exists:
https://gist.github.com/volviq/38b3b38d519acdddad2f1b0546d7597c
-> should I create an issue which is independent of the "ARM" headline?

Yes, lets have separate ticket for that. When filing issue, please attach config.log.

@alk thanks. Created #891

Thanks.  I've verified that configuring with --enable-minimal makes all the tests pass.  Does "--enable-minimal" mean that heap memory checking won't work though?

Yes, minimal mode disables everything except malloc, so including heap checker.
Heap checker isn't 100% broken on arms, so you may get something out of it. I know that at least part that captures registers of all threads is broken on arms. And yes I plan to fix it (or rather port fix from google-internal code base).
Keep in mind that address sanitizer is likely to be better for heap checking purpose.

Thanks for the help!

Heap checker isn't 100% broken on arms, so you may get something out of it. I know that at least part that captures registers of all threads is broken on arms. And yes I plan to fix it (or rather port fix from google-internal code base).

any progress?


HIPSYCL_PLATFORM not settable in CMakeLists.txt

Setting -DHIPSYCL_PLATFORM=cpu on the command line works fine but using set(HIPSYCL_PLATFORM "cpu") in the CMakeLists.txt file gives the following error:
  More than one hipSYCL target platform is available.

  Please specify HIPSYCL_PLATFORM=cpu|cuda|rocm
Call Stack (most recent call first):
  /opt/hipSYCL/lib/cmake/hipsycl-config.cmake:9 (enable_language)
  CMakeLists.txt:15 (find_package)

I could reproduce this issue using the example from the docs. If required, I can provide the CMakeLists.txt used.

Make sure to set the platform before calling find_package(hypsycl)

More information on that. It seems that the first time running cmake the set is ignored but taken into account the following times (potentially leading to surprising results, see #297 )


Does not escape values in PCDATA

The following characters should be escaped when they are part of the text field or equivalent.
&, ", ', <, >

This could be resolved by


[Bug][Master] global taskRetryCheckList clear conflict in killAllTasks in WorkflowExecuteThread

Purpose of the pull request
The Object taskInstanceRetryCheckList is shared among all WorkflowExecuteThreads, so when taskInstanceRetryCheckList is cleared by one WorkflowExecuteThread, all other WorkflowExecuteThreads may lose their track of checking dependent tasks, causing other dependent tasks stuck.

Brief change log
When executing killAllTasks, the WorkflowExecuteThread only remove those tasks belonging to itself from the global taskInstanceRetryCheckList reference.

Verify this pull request

This pull request is code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:

Codecov Report

:exclamation: No coverage uploaded for pull request base (2.0.6-prepare@cfa68a7). Click here to learn what that means.
The diff coverage is n/a.

@@               Coverage Diff                @@
##             2.0.6-prepare    #9678   +/-   ##
================================================
  Coverage                 ?   21.07%
  Complexity               ?     1595
================================================
  Files                    ?      536
  Lines                    ?    22532
  Branches                 ?     2675
================================================
  Hits                     ?     4748
  Misses                   ?    17299
  Partials                 ?      485

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cfa68a7...9d9ff5d. Read the comment docs.

@caishunfeng do you have time to take a look at this PR?

I restart the backend CI


198 get apprentice names api

Added new endpoint for getting all apprenticeships.

new fields for first and last name in database
new controller, service, query handler, query repository to fetch the name data (with uln)
changed any mention of pilot status to funding platform enum

Closed due to renaming branch


Testing Updates

@lyashevska Please merge into your branch (and feel free to double-check/review the changes!).


GenerateJsonSchema should take config and use it for at least title

if you set title via config on a dataclass or valdiate_call, it should be respected in the JSON schema.
@dmontagu we can discuss later.

I am in favor of better support for this, and we can definitely do it for pydantic dataclasses today by reading the value off of __pydantic_config__, but I think this would require some bigger changes to AnalyzedType or similar. I'll work on a PR that at least uses the config title for dataclasses

Okay, looks like this is already working for dataclasses:
from pydantic.dataclasses import dataclass
from pydantic import AnalyzedType

@dataclass(config={'title': 'abc'})
class Data:
    x: int

print(AnalyzedType(Data).json_schema())
#> {'type': 'object', 'properties': {'x': {'type': 'integer', 'title': 'X'}}, 'required': ['x'], 'title': 'abc'}

Will be happy to discuss what you have in mind for validate call / other ways GenerateJsonSchema might receive a config.


It would be great to have input language icons again

Describe the feature you'd like to improve in Pock
It would be great to have the input language icons back after the macOS 12.4 update. Apple redesigned the input sources icons.
Describe alternatives you've considered
So far they only appear for input sources with "white plates", otherwise there is a black square.
Additional context
No screenshot.

I just see an empty space instead of language icon

we all do. would be great to have the icons for each country. this effing 'i'm offended by whatever' is getting out of hand.


Pr fix

The commit (84c8413f187191c659c4b8e0c9a91bbf97700421) has all applicable changes.
Below are certain key changes done in this PR.

The namespace has been updated to ansible, initially it was community. The reason to update to ansible was, as we upload the collection to galaxy, the namespace expected is as per the GitHub Username

All Documentations has been corrected & updated

A extra vars template file has been added which can be used to execute each role

Python-memsource package has been updated, similarly it has been included in requirements.txt file

Post translation role is performed using the project_name retrieved from the string passed and the recent most project is retrieved from memsource.

After addressing those comments, do you mind squashing your commits before we merge?


NetBSD support

Hi, I'd like to add NetBSD support.
I  made changes to make restic built on NetBSD in the following branch.
https://github.com/iquiw/restic/tree/netbsd-support
The tests passed as attached
Can I send PR?

Please send a PR so we can discuss the code. Thanks!


ffMul complete implementation of selected approach: negation vs borrowing

@jspada isn't this one finished?


Issue with Cover not working properly

Description
The cover buttons don't actually work with spotify. For example if i click pause or back skip or forward skip, nothing happens.
Versions
1.8.1

Rainmeter Version: 4.1 r2989
OS Version: Windows 10 64 bit
Skin Version: 1.8.1
Spotify Version: <IP_ADDRESS>3.g7ff4a0dc

Additional notes/images
The album cover is working just fine and you can see the buttons when you scroll over them and your mouse makes it look like it's clickable.

Duplicate of #144.


Running "zeroshot_esc50.sh"

How to run the zeroshot evaluation using the pre-trained model provided in the gdrive link?
"eval_retrieval_main.py" requires params.txt, out.log as a part of the log_dir, right? However, only the .pt files have been provided. Is it possible to upload all the contents of the log_dir to gdrive?
Thanks in advance!

Oh, my bad. Thanks for pointing it out!  I will upload them in the near future.

Just updated the google drive folder. Thanks for pointing this out!

What are the contents of "sizes.json"? in esc/train and esc/test
Also, is there a way of running this script without "webdataset"? i.e. using ESC50 on our local system.

Hi Swapnil, We use webdataset as our dataset format. The sizes.json is
related to webdataset format. It records the number of samples for each
tar.
For details of webdataset format we used, you could check
https://github.com/LAION-AI/audio-dataset/ or
https://github.com/webdataset/webdataset. It is possible to train on
webdataset datasets on local storage.
If you want to use the dataset format you want, you could always create a
new type of dataloader and load the data.
Hope this helps.
Best,
Yusong
Swapnil Bhosale @.***> 于2022年11月21日周一 04:06写道：

What are the contents of "sizes.json"? in esc/train and esc/test
Also, is there a way of running this script without "webdataset"? i.e.
using ESC50 on our local system.
—
Reply to this email directly, view it on GitHub
https://github.com/LAION-AI/CLAP/issues/52#issuecomment-1321727959, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AGXJZ73ZNVIL7BVJV3YNGWLWJM3RNANCNFSM6AAAAAASFRAICM
.
You are receiving this because you modified the open/close state.Message
ID: @.***>

Got it. Thanks for sharing the links!

I am also try to running "zeroshot_esc50.sh", But I can't find  params.txt, out.log , and epoch_top_0.pt.  I just find some checkpoints like LAION-audio-630K.pt .  Could you please let me know the links to these files ?
Thanks a lot!

Hi @CoderwayNew , we actually have a newer script using the pip API to run the ESC50 zeroshot evaluation, please see: https://github.com/LAION-AI/CLAP/blob/main/experiment_scripts/esc50_api.py


auth: import design doc

This commit imports and refines the design doc of v3 auth:
https://goo.gl/fwBxz6

Codecov Report

Merging #7508 into master will increase coverage by 0.09%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #7508      +/-   ##
==========================================
+ Coverage   70.28%   70.37%   +0.09%
==========================================
  Files         320      320
  Lines       26175    26175
==========================================
+ Hits        18396    18420      +24
+ Misses       6328     6304      -24
  Partials     1451     1451

Impacted Files
Coverage Δ

clientv3/concurrency/election.go
65.38% <0%> (-8.66%)
:x:

pkg/adt/interval_tree.go
82.43% <0%> (-7.78%)
:x:

mvcc/watcher.go
95.65% <0%> (-4.35%)
:x:

pkg/netutil/netutil.go
77.94% <0%> (-2.95%)
:x:

etcdserver/api/v3rpc/util.go
51.42% <0%> (-2.86%)
:x:

etcdserver/api/v3rpc/watch.go
88.48% <0%> (-1.05%)
:x:

rafthttp/transport.go
81.92% <0%> (ø)
:white_check_mark:

clientv3/lease.go
91.11% <0%> (ø)
:white_check_mark:

proxy/grpcproxy/adapter/watch_client_adapter.go
94.11% <0%> (ø)
:white_check_mark:

proxy/grpcproxy/adapter/lease_client_adapter.go
65% <0%> (ø)
:white_check_mark:

... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update df839f3...ec25840. Read the comment docs.

@heyitsanthony reflected your comments, could you take a look? Thanks a lot!

@heyitsanthony updated for the latest comments. PTAL, thanks!

@xiang90 updated for removing the empty line, PTAL

LGTM.


403 forbidden

I just create an AWS ec2 with safe-infrastructure with DNS already, but when I logged into my domain:
http://gnosis-test.asd.com:8000/cfg/admin/login/?next=/cfg/admin/chains/chain/add/
There is a Forbidden / CSRF verification failed. Request aborted.
There is any config for django and CSRF ?
Regards

I saw on container_env_files/cfg.env:
CSRF_TRUSTED_ORIGINS="http://gnosis-test.asd.com:8000"
There is another place to place my own domain?

Same here

I saw on container_env_files/cfg.env: CSRF_TRUSTED_ORIGINS="http://gnosis-test.asd.com:8000"
There is another place to set my own domain?

Modifying the CSRF_TRUSTED_ORIGINS parameter in container_env_files/cfg.env worked for me.

This might solve your problem. https://github.com/safe-global/safe-transaction-service/issues/1225

I found other modifications that are newer.

https://github.com/safe-global/safe-infrastructure/issues/66
https://github.com/safe-global/safe-infrastructure/issues/64

Hello @thespamer, I see your test setup is not online anymore. Did you solve the issue? The CSRF_TRUSTED_ORIGINS you wrote seems OK, but maybe another part of your infrastructure (some AWS firewall/API Gateway?) was masking the Origin/Referer field so the CSRF verification didn't pass. You'd need to check the Host saw by the service matches the Origin/Referer as explained in the docs.
If you managed to solve the issue, could you close it? (and if you found where the problem was, it would be really nice if you share it 🙂)


[SPARK-30387] Improving stop hook log message

What changes were proposed in this pull request?

ShutdownHook of YarnClientSchedulerBackend prints just "Stopped" which can be improved to "YarnClientSchedulerBackend Stopped" for better understanding.
Why are the changes needed?

While stopping or gracefully exiting the spark-shell/spark-sql --master yarn, only printing stopped is useless.
Does this PR introduce any user-facing change?

Yes. Log info message change.
How was this patch tested?

Manually

Can one of the admins verify this patch?

Can one of the admins verify this patch?

Jenkins test this please

Test build #115993 has started for PR 27049 at commit 9e71efe.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/20785/
Test PASSed.

Test build #115993 has finished for PR 27049 at commit 9e71efe.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/115993/
Test PASSed.

Test build #4981 has started for PR 27049 at commit b6577cb.

Test build #4981 has finished for PR 27049 at commit b6577cb.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged to master


MapView: adjust button layout on iOS

fixes #1059 for me
move buttons a bit downward, so that they do not
overlap with the status bar on some iPhone models

Forgot to mention that this PR only modifies the layout on iOS and leaves other platforms untouched (it's pretty obvious from the code, though).
@charlenni Do you have an opinion on this? Is this ok with you or would you prefer a different solution?

For me, it is ok. It could be made better, if you expose this values as properties, but I assume, one could move the buttons around by the described child method or disable them and make new ones.


use correct proxy sha

Update patch branch to use correct proxy SHA
see: https://github.com/istio/istio/issues/49561

@lgadban : When trying to run make docker.proxyv2 to build istio locally off of your patch branch, I am seeing this error and I double checked that this tarball is missing...
<Error>
NoSuchKey
<Message>The specified key does not exist.</Message>
No such object: istio-build/proxy/envoy-alpha-c6043aa697a170c3aa21afc2671958f1ca85de22.tar.gz
</Error>

...
Downloading envoy: https://storage.googleapis.com/istio-build/proxy/envoy-alpha-c6043aa697a170c3aa21afc2671958f1ca85de22.tar.gz
curl: (22) The requested URL returned error: 404

I assume this is not supposed to happen ?

Hi @anirudhsaligram, to be clear are you trying to build the agent/proxyv2 from source in istio/istio and not build istio/proxy?

Hi @anirudhsaligram, to be clear are you trying to build the agent/proxyv2 from source in istio/istio but not build istio/proxy from the specified commit?

yes

Okay so for that scenario, you actually don't want the change introduced by this PR/commit.
After thinking through this a bit more, we will revert this change in the istio/istio patch branch.
The intent being if you are building istio/istio only, the tip of the patch branch will work as expected.
If you are also building istio/proxy from the corresponding patch branch, you will need to update istio/istio anyway to point at your build istio/proxy, therefore you can point to the correct SHA for the local proxy build.

@anirudhsaligram please see https://github.com/istio/istio/issues/49561#issuecomment-1973960460 for more info. This has been completed. Let me know if you see other issues.


Skip plugin install

this applies the following changes:

upgrade to Gradle 2.8
use the Gradle daemon by default
allows to skip the head plugin install (by configuring withPlugins = [])
fixes an issue where the untarred elasticsearch binary wasn't executable

thanks for contributing!


C++ SetDefaultDevice does not appear to work properly

I'm using a simple C++ session that works fine otherwise. Trying to use tensorflow::graph::SetDefaultDevice to pin on either CPU or GPU (per id) does not appear to work:

without SetDefaultDevice:

I tensorflow/core/common_runtime/gpu/gpu_device.cc:982] 1:   Y Y
I tensorflow/core/common_runtime/gpu/gpu_device.cc:1041] Creating TensorFlow device (/gpu:0) -> (device: 0, name: Tesla K40c, pci bus i
d: 0000:02:00.0)
I tensorflow/core/common_runtime/gpu/gpu_device.cc:1041] Creating TensorFlow device (/gpu:1) -> (device: 1, name: Tesla K40c, pci bus i
d: 0000:03:00.0)

all goes well beyond this point.

now trying to pin on GPU0:

tensorflow::graph::SetDefaultDevice("/gpu:0", &graph_def);

yields
E tensorflow/core/common_runtime/direct_session.cc:132] Invalid argument: Could not parse entry in 'visible_device_list': '/gpu:0'.  visible_device_list = /gpu:0

Same with /cpu:0, no surprise.

looking at https://github.com/tensorflow/tensorflow/blob/f7ec99516ce0e0937e0b865e90aa02c748cd36c6/tensorflow/core/common_runtime/gpu/gpu_device.cc#L808 it seems the code is rather looking for an int ? Trying it out:

tensorflow::graph::SetDefaultDevice("0",&graph_def);

yields
I tensorflow/core/common_runtime/gpu/gpu_device.cc:972] DMA: 0
I tensorflow/core/common_runtime/gpu/gpu_device.cc:982] 0:   Y
I tensorflow/core/common_runtime/gpu/gpu_device.cc:1041] Creating TensorFlow device (/gpu:0) -> (device: 0, name: Tesla K40c, pci bus id: 0000:02:00.0)
E tensorflow/core/common_runtime/gpu/process_state.cc:108] Invalid allocator type: 0

Am I doing something wrong or has something changed (maybe due to 3e8c4fd7403659ec32b9fec90a78831043aa0786 ?)
The tutorial at https://github.com/tensorflow/tensorflow/blob/master/tensorflow/cc/tutorials/example_trainer.cc#L104 still calls on SetDefaultDevice the way I tried to use it, this seems odd :)

Check that this error doesn't occur when you don't call SetDefaultDevice at all. @keveman, do you have any inight?

I'm going to go out on a limb and suggest that you are setting 'visible_device_list' incorrectly in your ConfigProto, and this has nothing to do with SetDefaultDevice.  SetDefaultDevice doesn't touch 'visible_device_list', and the documentation of 'visible_device_list' should clear up what the syntax is supposed to be.  Please comment if you disagree and I'll reopen!

@aselle hi, see the initial report, there's no error when no call is made to SetDefaultDevice.
@vrv hi, I can certify we are not touching anything within the ConfigProto in our code (it's heere actually https://github.com/beniz/deepdetect/blob/tf/src/tflib.cc#L199) besides the set_allow_growth option that is set to true.
I believe I understand what SetDefaultDevice does and that visible_device_list is outside its scope but if you look at the initial report you can see the initial parsing error can be avoided by setting up the device to 0 instead of /gpu:0 and that with the parsing code strings::safe_strto32(gpu_id_str, &gpu_id) looks suspicious to me.
Please let me know if I can run tests somehow to drive closer to the root of the problem here.

I just can't see a codepath that connects anything in the graph to "visible_device_list".  In fact, visible_device_list is only populated here: https://github.com/tensorflow/tensorflow/blob/master/tensorflow/core/common_runtime/gpu/gpu_device.cc#L525, which comes from the ConfigProto.

[ Windows 10 x64 ] I have found a solution for using "setDefaultDevice" with no exception:
edit tensorflow/tf_version_script.lds to:

this code is from another issue, but i cannot find it out now

tensorflow {
  global:
    *tensorflow*;
    *perftools*gputools*;
    *TF_*;
    *TFE_*;
    *nsync_*;
    *protobuf*;
  local:
    *;
};

then compile the source( r1.2 is tested ok)
you will get tensorflow.dll and lib, but if use these two file in your project you will encounter the exception.
please use *.obj file instead of tensorflow.dll/lib
Edit your vcxproj file (add a lot of Object Entries) just like:
<ItemGroup>
        <Object Include="E:\twd\build_from_source\buildgpu12_setdevice\tf_core_lib.dir\$(Configuration)\arena.obj" />
    <Object Include="E:\twd\build_from_source\buildgpu12_setdevice\tf_core_lib.dir\$(Configuration)\bitmap.obj" />
    <Object Include="E:\twd\build_from_source\buildgpu12_setdevice\tf_core_lib.dir\$(Configuration)\coding.obj" />
    <Object Include="E:\twd\build_from_source\buildgpu12_setdevice\tf_core_lib.dir\$(Configuration)\status.obj" />
    <Object Include="E:\twd\build_from_source\buildgpu12_setdevice\tf_core_lib.dir\$(Configuration)\stringpiece.obj" />
    <Object Include="E:\twd\build_from_source\buildgpu12_setdevice\tf_core_lib.dir\$(Configuration)\threadpool.obj" />
...

more details see this link

and the exception is gone.
but :
exe file is larger  (10MB - > 150MB)
no tensorflow.dll depends

my solution:
tensorflow1.8
c++
https://blog.csdn.net/cdknight_happy/article/details/81100554

@knighthappy were you able to resolve the SetDefaultDevice issue?


foreign import library path corrupted after code format

After OLS in VSCode updated automatically to latest nightly (20224-06-03), when Odin files were saved and auto formated, the foreign import ... statements will be corrupted.
The original file:
when ODIN_DEBUG {
	foreign import uv "../../vcpkg/installed/x64-linux/debug/lib/libuv.a"
} else {
	foreign import uv "../../vcpkg/installed/x64-linux/lib/libuv.a"
}
foreign import uv_wrapper "../../build/lib/uv_wrapper.a"

After format:
when ODIN_DEBUG {
	foreign import uv foreign
} else {
	foreign import uv foreign
}
foreign import uv_wrapper foreign

I like OLS a lot, the intellisense and format are very fast and accurate, but the nightly release scheme is a bit frightening. I'm wondering if it can be released under a semantic versioning scheme, allowing user to pin-point a version they prefer in VSCode settings.

Yeah it was caused by a change in core:odin/parser. It is more by fault that my format tests actually failed, but for some reason it doesn't fail the nightly build. It should have been caught. Regarding semantic versioning, it sounds like a good idea, but not sure if I have time to add it now.

Is now fixed in the latest odin version. I'll rebuild the nightly now.

Totally understood. Thanks for your great work despite limited time. ❤


add type information to generic resources

Codecov Report

Merging #81 (b94bdbf) into main (96388ae) will decrease coverage by 0.10%.
The diff coverage is 89.47%.

@@            Coverage Diff             @@
##             main      #81      +/-   ##
==========================================
- Coverage   85.98%   85.88%   -0.11%
==========================================
  Files           8        8
  Lines         835      843       +8
==========================================
+ Hits          718      724       +6
- Misses         84       85       +1
- Partials       33       34       +1

Impacted Files
Coverage Δ

server/server.go
85.44% <71.42%> (-0.25%)
:arrow_down:

pkg/resource/manager.go
100.00% <100.00%> (ø)

pkg/resource/uri.go
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 96388ae...b94bdbf. Read the comment docs.


Make active Step's links to Steps from previous reports on right 'Step History' Tab

Look at the screen. Highlighted text must be a link to previous report

Release 2.4.0


Http library more granular helpers to get route and http infromation of operation

It would be great if you can pass a generic namespace, interface or operation and be able to get the same info returned by getAllRoutes

@daviwil @timotheeguerin Can you propose an API here?

listOperations-> resolveOperations? findOperations?


Simplify ARM64 bazel invocation (and produce resultstore bazel results).

Followup for https://github.com/grpc/grpc/pull/29354.

produce the bazel invocation link for linux ARM64 bazel C/C++ tests
make use of the bazer_report_helper.py

Adhoc run: http://sponge/3d5b120a-2941-43ab-87b5-3e40b4649b06


frontal bossing

Add:
frontal bossing (child of abnormal forehead shape MP:0030045 )
DEF: bilateral bulging of the lateral frontal bone prominences with relative sparing of the midline; this is not the same as prominent forehead
EXACT SYNONYMS: frontal protuberance; skull bossing
SOURCE: PMID:19125436
Annotation in J:36305 (MGI:2177551), J:152152 (MGI:4360984), J:50144 (MGI:3717417)

frontal bossing MP:0030262


Diagnose identifier in operator declarations

Diagnose if identifiers are used in operator declarations or if multiple operators occur in the operator name.

@swift-ci Please test


Fix coverage on Travis CI

Current coverage is 97.17% (diff: 100%)

No coverage report found for master at 682d55d.

Powered by Codecov. Last update 682d55d...c123d1a


Add automated story-based static accessibility testing workflow

Fixes #1180.
Additional description
This does not add the testing to the CI, just the ability to run testing with npm run test:a11y. Adding the aXe audit will more than double the TravisCI time.

Two Jest configs are needed since many components do not pass in Jest/jsDOM snapshot testing, but due in Jest/Node environment (such as portal use). aXe needs a DOM and therefore uses jsDOM
Add npm run test:a11y script
Moves default Jest config to preset file
Removes Webpack build, doc build line separator, and passing Mocha tests from the CI console--making it more concise.
Removes IconSettings tests and Tree's Large dataset (300+) from Jest tests
Guards SVGs, SLDSSettings.setAppElement and canvas functions for use in jsDOM environment

CONTRIBUTOR checklist (do not remove)
Please complete for every pull request

[ ] First-time contributors should sign the Contributor License Agreement.  If you haven't before, wait a few minutes and a bot will comment on this pull request with instructions.
[ ] npm run lint:fix has been run and linting passes.
[ ] Mocha, Jest (Storyshots), and components/component-docs.json CI tests pass (npm test).
[ ] Tests have been added for new props to prevent regressions in the future. See readme.
[ ] Review the appropriate Storybook stories. Open http://localhost:9001/.
[ ] The Accessibility panel of each Storybook story has 0 violations (aXe). Open http://localhost:9001/.
[ ] Review tests are passing in the browser. Open http://localhost:8001/.
[ ] Review markup conforms to SLDS by looking at DOM snapshot strings.

REVIEWER checklist (do not remove)

[ ] TravisCI tests pass. This includes linting, Mocha, Jest, Storyshots, and components/component-docs.json tests.
[ ] Tests have been added for new props to prevent regressions in the future. See readme.
[ ] Review the appropriate Storybook stories. Open http://localhost:9001/.
[ ] The Accessibility panel of each Storybook story has 0 violations (aXe). Open http://localhost:9001/.
[ ] Review tests are passing in the browser. Open http://localhost:8001/.
[ ] Review markup conforms to SLDS by looking at DOM snapshot strings.

Required only if there are markup / UX changes

[ ] Add year-first date and commit SHA to last-slds-markup-review in package.json and push.
[ ] Request a review of the deployed Heroku app by the Salesforce UX Accessibility Team.
[ ] Add year-first review date, and commit SHA, last-accessibility-review, to package.json and push.
[ ] While the contributor's branch is checked out, run npm run local-update within locally cloned site repo to confirm the site will function correctly at the next release.

Running this locally shows 72 errors.  Are we going to fix those are part of this PR or fix those in a separate PR?

I propose a separate PR(s) that is grouped with the findings from the upcoming audit from JoAnne

The other thing we need to talk about is when this will run since it takes so long.

@futuremint Really good requests! Now, that we've got the 404 and console error noise down, in headers with context and additional documentation is a really good features to have for folks running into errors.

Issue added to fix errors https://github.com/salesforce/design-system-react/issues/1732


slice added

Why did you close it?

https://github.com/devdaoteam/tonsdk
Would you like to join DevDao?


Added verification of X-HTTP-Method-Override before use

Verify that the method in X-HTTP-Method-Override is a valid method
before use using it. Validation is performed using the same logic
as net/http dose. This prevents a routing confusion vulnerability
that allowed an attacker to control the entire internal revel routing
path (used to find a controller) via the override header. This issue can
be problematic in instances where authentication is based on the path
for example in a revel.Filter or if the revel app is behind a reverse
proxy.

this fix is almost identical to  #1555. The functional difference is that my fix ignores the header when its invalid while movitz-s fix will return nil if the header is invalid.

This looks good to me - @brendensoares thoughts?

I appreciate the unit tests you included, but could you also provide steps to reproduce the vulnerability so we can verify this correctly addresses it?
Thank you for contributing to Revel and OSS!

Added new code review comments.
Also, I got your proof of concept code to test for this vulnerability in gitter. Thank you.


[Q] tsp confilt with vlc in windows server 2019

tsp version 3.37-3670
vlc player 3.0.20
OS : Windows Server 2019 Standard
tsp & vlc receive a multicast UDP stream together
tsp process

tsp --verbose -I ip <IP_ADDRESS>:4567  -l <IP_ADDRESS> -O drop

VLC open network stream

udp://@<IP_ADDRESS>:4567

When tsp.exe  & vlc parallel  execute , VLC disply corruption image
Even tsp though add the --disable-multicast-loop   not work
I have check the tsp part is OK , (Ingest ts file no problem  .=>  tsp -I ip ... -O abc.ts )
Terminate tsp.exe process vlc work  fine
The OS Windows 11 work fine

Hi @edwardlai

OS : Windows Server 1029 Standard

I assume you mean "2019", right?
This is a Windows issue. Receiving the same multicast stream on the same machine does not always work as expected, depending on the operating system, its versions, its configuration. Not only Windows (even though I usually consider Windows as the problem in many situations).
Try searching for Windows issues. The problem may be a configuration issue, not necessarily Win 2019 vs. Win 11. I have seen multicast problems because of the presence of VirtualBox on the system. I saw similar reports about Hyper-V.
Anyway, we cannot really help from a TSDuck perspective. Receiving the same multicast stream on the same machine is generally looking for trouble. This is my experience. Sometimes it works, sometimes it doesn't, this is an operating system issue.

As I explained, in some operating systems (or configurations), receiving the same multicast stream, on the same port, from two concurrent processes on the system, may work or not. I have seen situations where each incoming UDP datagram was sent to one client only, one or the other, depending on which is waiting first. On other operating systems (or configurations), each incoming UDP datagram is correctly duplicated to each client. I cannot remember the exact conditions, it was a long time ago, but the lesson I learnt was "never listen twice on the same UDP port".
This is why you should look for multicast reception issues on Windows from multiple clients on the same stream.

=> Not all the server operating system have this issue

Win 10 Professional OK
Win 11 Professional OK
Server 2012 R2 Standard OK
**- Server 2016 Standard  Not work
Server 2019 Standard Not work**
Server 2022 Standard OK

=> Server 2016 & 2019 VLC/ffplay/ffmpeg work concurrently , But incompatible with TSP


Video Trimming

Feature Description
For videos, I’d like to be able to choose the start and end time within any uploaded video to be able to cut the video displayed in my story.

Do not alter or remove anything below. The following sections will be managed by moderators only.
Acceptance Criteria
QA Instructions

Can you link to the designs or any PRD parts that mention this functionality?

@diegovar I don't think this has been spec'd at all. I originally filed this as a feature request a while back.
@o-fernandez I see its a TBD P1 in the CUJ sheet in row 18.

I just looked through the spec and this is all I could find. Needless to say, no real spec for this yet (neither PM nor UX) so adding the necessary labels for Sam and I to take a look.
@diegovar is this something you were planning to work on in the near future? If so, we may need to figure out how to prioritize to get the right specs to you.

I was trying to better understand which issues were available to grab and which ones need more info or are blocked. My objective is for the issues tagged as "media" to be in a good enough state so that it's clear whether an issue can be grabbed before having to open and read the discussion.

Ok got it. For now, if you find anything that is not spec'd, just add the "Needs More Info" or "UX Needed" labels and those are understood to need either a product spec or UX. I'll try to clean this up somewhat as well, so hopefully things are actionable for you!

Video Trimming.fig.zip


OpenSCENARIO 2.0 questions

hey everyone I have some questions about using OpenSCENARIO 2.0

Is it not possible to use the standard.osc file from the Asam documentation?
I saw that there are limitations when writing osc scenarios, there is documentation that summarizes what can be written and what not?
Is it possible to use pedestrians in osc? I have tried to add it as an actor to the basic.osc file but it is not recognized.

I have same question.
How can a person without background knowledge in this area check the correctness of an ANTLR4 .g4 file?
There are three versions for osc2 definition file:

https://github.com/PMSFIT/py-osc2/blob/main/osc2parser/openscenario2.g4
https://github.com/51WORLD/osc2checker/blob/main/osc2grammar/OpenSCENARIO2.g4
this repo
I don't know which is completely correct

@fangchaooo if your goal is to check syntax and correctness of .osc files, I recommend using VS code and installing the OpenSCENARIO extensions.

@yarinr25 My goal is to check parser and lexer correctly for osc2 language.


[Feature][UI Next]Improve the routing

Purpose of the pull request
Please refer to the issue #8070.

Brief change log

Verify this pull request

This pull request is code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:

Codecov Report

Merging #8176 (bfc2e07) into dev (0057cf3) will decrease coverage by 0.05%.
The diff coverage is n/a.

:exclamation: Current head bfc2e07 differs from pull request most recent head 01b6879. Consider uploading reports for the commit 01b6879 to get more accurate results

@@             Coverage Diff              @@
##                dev    #8176      +/-   ##
============================================
- Coverage     41.50%   41.45%   -0.06%
+ Complexity     3737     3730       -7
============================================
  Files           637      637
  Lines         27176    27176
  Branches       3092     3092
============================================
- Hits          11279    11265      -14
- Misses        14811    14824      +13
- Partials       1086     1087       +1

Impacted Files
Coverage Δ

...he/dolphinscheduler/common/enums/SqoopJobType.java
0.00% <0.00%> (-88.89%)
:arrow_down:

...e/dolphinscheduler/remote/NettyRemotingClient.java
50.70% <0.00%> (-2.82%)
:arrow_down:

...inscheduler/common/task/sqoop/SqoopParameters.java
74.00% <0.00%> (-2.00%)
:arrow_down:

...dolphinscheduler/remote/future/ResponseFuture.java
81.96% <0.00%> (-1.64%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0057cf3...01b6879. Read the comment docs.


Running "make monitor" in windows command prompt or other shells

Hi guys, I am trying to use the command "make monitor" in windows command prompt or other shells other than mingw32.exe. I am using Windows 10 64bit.
Note: I want to use cmd to run a monitor command because I am trying to write a Python script to automate factory testing. The script should use subprocess to run that monitor command and terminate that command when a certain string is observed in the output, and then use that string later. I tried making subprocess open mingw32.exe to run that command but it seems like subprocess cannot live capture the output of an opened terminal properly. I also tried writing a shell script to be ran with mingw32.exe, but that did not work either.
I kind of messed up my environment variables a while ago, but I think I fixed it. I have the following environment variables set up:
PROJECT_DIR = C:\Users\james\factory\factory-test\panel-table

IDF_PATH = %PROJECT_DIR%\esp-idf

PATH =
%SystemRoot%\system32
%SystemRoot%
%SystemRoot%\System32\Wbem
%SystemRoot%\System32\WindowsPowerShell\v1.0\
%SystemRoot%\System32\OpenSSH\
C:\Program Files (x86)\Common Files\Oracle\Java\javapath
C:\Program Files (x86)\GtkSharp\2.12\bin
C:\Program Files\dotnet\
C:\Program Files (x86)\Skype\Phone\
C:\Program Files\Git\cmd
C:\Program Files\PuTTY\
C:\Program Files\CMake\bin
C:\Users\james\AppData\Local\Programs\Python\Python37
C:\Users\james\AppData\Local\Programs\Microsoft VS Code\bin
C:\msys32\usr\bin
C:\MinGW\msys\1.0\bin
C:\Program Files (x86)\mingw-w64\i686-8.1.0-posix-dwarf-rt_v6-rev0\mingw32\bin
C:\MinGW\bin
C:\msys32\opt\xtensa-esp32-elf\bin

"make monitor" works fine in mingw32.exe (even though it says Toolchain version is not supported)
However, running "make monitor" in cmd outputs the following:
C:\msys32\home\james\esp\hello_world>make monitor
WARNING: Toolchain version is not supported: 1.22.0-73-ge28a011
Expected to see version: 1.22.0-80-g6c4433a
Please check ESP-IDF setup instructions and update the toolchain, or proceed at your own risk.
MONITOR
Traceback (most recent call last):
  File "C:/Users/james/factory/factory-test/panel-table/esp-idf/tools/idf_monitor.py", line 754, in <module>
    main()
  File "C:/Users/james/factory/factory-test/panel-table/esp-idf/tools/idf_monitor.py", line 670, in main
    p=serial_instance))
  File "C:/Users/james/factory/factory-test/panel-table/esp-idf/tools/idf_monitor.py", line 72, in yellow_print
    color_print(message, ANSI_YELLOW)
  File "C:/Users/james/factory/factory-test/panel-table/esp-idf/tools/idf_monitor.py", line 69, in color_print
    sys.stderr.write("%s%s%s\n" % (color, message,  ANSI_NORMAL))
  File "C:/Users/james/factory/factory-test/panel-table/esp-idf/tools/idf_monitor.py", line 736, in write
    m = re.match(RE_ANSI_COLOR, self.matched)
  File "C:\Users\james\AppData\Local\Programs\Python\Python37\lib\re.py", line 173, in match
    return _compile(pattern, flags).match(string)
TypeError: cannot use a bytes pattern on a string-like object
make: *** [/c/Users/james/factory/factory-test/panel-table/esp-idf/components/esptool_py/Makefile.projbuild:106: monitor] Error 1

Running "make monitor" in git bash outputs the following:
C:\Users\james\factory\factory-test\panel-table\esp-idf/make/project.mk:61: esp-idf build system only supports MSYS2 in "MINGW32" mode. Consult the ESP-IDF documentation for details.
WARNING: Failed to find Xtensa toolchain, may need to alter PATH or set one in the configuration menu
MONITOR
Traceback (most recent call last):
  File "C:/Users/james/factory/factory-test/panel-table/esp-idf/tools/idf_monito
r.py", line 754, in <module>
    main()
  File "C:/Users/james/factory/factory-test/panel-table/esp-idf/tools/idf_monito
r.py", line 670, in main
    p=serial_instance))
  File "C:/Users/james/factory/factory-test/panel-table/esp-idf/tools/idf_monito
r.py", line 72, in yellow_print
    color_print(message, ANSI_YELLOW)
  File "C:/Users/james/factory/factory-test/panel-table/esp-idf/tools/idf_monito
r.py", line 69, in color_print
    sys.stderr.write("%s%s%s\n" % (color, message,  ANSI_NORMAL))
  File "C:/Users/james/factory/factory-test/panel-table/esp-idf/tools/idf_monito
r.py", line 736, in write
    m = re.match(RE_ANSI_COLOR, self.matched)
  File "C:\Users\james\AppData\Local\Programs\Python\Python37\lib\re.py", line 1
73, in match
    return _compile(pattern, flags).match(string)
TypeError: cannot use a bytes pattern on a string-like object
make: *** [/c/Users/james/factory/factory-test/panel-table/esp-idf/components/esptool_py/Makefile.projbuild:106: monitor] Error 1

Any help would be greatly appreciated.

Hi @jamesgz. The error you are getting is cased by Python incompatibility. You are probably using  Python 2 in mingw32 and Python 3 in cmd.
Please note that Python 3 support is experimental in master. I'm guessing based on your log (line numbers don't match the latest idf_monitor) that you are using some older version of IDF where Python 3 isn't working yet. Please post the output of git rev-parse --short HEAD.
The solution to your problem could be:

use the latest master,
or install a Python 2 interpreter (by Windows installer, outside mingw32) and the Python packages for this interpreter from $IDF_PATH/requirements.txt, and use that interpreter in cmd.

Hello @jamesgz. Sorry if you receive this twice but my previous comment just got lost somehow.
The problem is caused by Python incompatibility. Python 3 is not yet supported but the latest master contains experimental support.
Probably you are using an older IDF guessing from the line numbers from your log. Please post the output of git rev-parse --short HEAD.
Your problem could be solved:

by using the latest master (and then IDF monitor should work under Python 3),
install a Python 2.7 interpreter and the packages from $IDF_PATH/requirements.txt for that interpreter. Maybe you can access directly the python2 interpreter from mingw32 from inside cmd (I'm not sure about this). But probably a Windows installer should work.

Hello @jamesgz. Sorry if you receive this twice but my previous comment just got lost somehow.
The problem is caused by Python incompatibility. Python 3 is not yet supported but the latest master contains experimental support.
Probably you are using an older IDF guessing from the line numbers from your log. Please post the output of git rev-parse --short HEAD.
Your problem could be solved:

by using the latest master (and then IDF monitor should work under Python 3),
install a Python 2.7 interpreter and the packages from $IDF_PATH/requirements.txt for that interpreter. Maybe you can access directly the python2 interpreter from mingw32 from inside cmd (I'm not sure about this). But probably a Windows installer should work.

Thanks a lot! That fixed my problem. I ended up using pyserial instead to monitor my device.

Good to hear that!


Cookiecutter clone repository never terminates on missing repository

In the Cookiecutter search bar, enter the URL to a private GitHub repository, or just make up a URL to a repository that doesn't exist.
Click Next, the progress bar turns into "Cloning repository..." which never ends and cannot be canceled.

It's not finding the repository, so it's asking for username/password:
C:\Projects\temp>"C:\Program Files (x86)\Microsoft Visual Studio\Preview\Enterprise\Common7\IDE\CommonExtensions\Microsoft\TeamFoundation\Team Explorer\Git\mingw32\bin\git.exe" clone https://github.com/Microsoft/PTVS122
Cloning into 'PTVS122'...
Username for 'https://github.com':

This code from ProcessOutput may not be working as intended?
                if (_process.StartInfo.RedirectStandardInput) {
                    // Close standard input so that we don't get stuck trying to read input from the user.
                    try {
                        _process.StandardInput.Close();
                    } catch (InvalidOperationException) {
                        // StandardInput not available
                        Trace.WriteLine(_process.HasExited);
                    }
                }

I wasn't able to find any command line arguments that work to prevent username/password input.

The prompt is probably coming from a subprocess, which is why closing stdin for the original process doesn't help. I'm not sure of the best way to suppress this - perhaps we just need a timeout? Say 15 seconds without any new output being shown?
Perhaps we could pop up a dialog at that point saying that it may be an unreachable git repository and offer to run an interactive clone operation that may prompt for login credentials?

This kind of works. There is a problem, we don't get any output during the download phase. During the checkout phase, we get output. So we could be timing out if download is too slow. We could make the pop up dialog a 3 choice selection (continue waiting, stop, try again with console) and that might be good enough. Realistically, those cookiecutter repos shouldn't be that large, but slow internet can be slow sometimes...
Here's what I mean by not getting all output:

We get this:
Cloning into 'PTVS'...
Checking out files:   3% (164/5268)
Checking out files:   4% (211/5268)
Checking out files:   5% (264/5268)
Checking out files:   5% (277/5268)
Checking out files:   6% (317/5268)

We could pop up the "working on it" dialog with a cancel button? Blocking the entire UI is not very nice, but neither is implementing all of that UI manually. Then if the user cancels, we can ask if they want to retry with an open console window.

If the user clones a template from a private repository (either via command line tool, from our UI if we show them the console, etc.) then when we get to the "check for updates" phase, we'll also get stuck because that hidden console will ask for login.
I feel like the right solution is to use the git dll directly, not go through git.exe. We didn't do that because it was easier from a legal point of view to use the existing install, but maybe we need to revisit that decision and see if there's a way to make it work legally.


can't download serenity for  visual studio 2017

name couldn't be resolved volkanceylan.gallerycdn.vsassets.io

Where are you getting this error?

thank you for your Interest
in serenity.is when i try to download serene !!

Download link is working in serenity.is


Add a webhook test capability to verify configuration and test handlers

When developing webhook handlers it is very helpful to have a clear way to send a test event for each specific payload type to test the handling logic end-to-end.
Engine should provide a simple API call to send a test webhook of a specific type.

Closed by #570


Coin blocker lists and family filters

Hello, I found these awesome and huge no coin filters, it will be amazing if Bancuh dns could add them !
https://zerodot1.gitlab.io/CoinBlockerListsWeb/index.html#news
I found also these incredible huge lists collections :
https://github.com/Ultimate-Hosts-Blacklist/Ultimate.Hosts.Blacklist
I previously used ad blocker dns with the anti-porn family filter activated, then I noticed that some youtube videos are blocked, these videos come from my favorite youtube channels which are channels without porno and they are political channels or religious but youtube told me you can't access these videos then I discovered that it's because of the dns which is wrong and classifies political or religious videos as shocking vulgar videos when this is not the case!
there is a filter on youtube that you can easily activate to block shocking content so no need for dns servers with the family option to block youtube content because it can cause errors and the blocking of legitimate videos, I hope that Bancuh dns will make an exception and do not activate the family filter on the youtube site to avoid possible errors and the blocking of legitimate videos!
Thank you very much :)

I previously used ad blocker dns with the anti-porn family filter activated, then I noticed that some youtube videos are blocked, these videos come from my favorite youtube channels which are channels without porno and they are political channels or religious but youtube told me you can't access these videos then I discovered that it's because of the dns which is wrong and classifies political or religious videos as shocking vulgar videos when this is not the case!

At the moment, we don't use any family filter on Bancuh DNS for youtube. We only use some rules to enforce safe-search on google, bing, and duckduckgo. You can check the files here.  We did have safe-search for youtube in the past, but removed it because it was too strict.
If you found some youtube videos that are blocked, maybe it's not because of Bancuh DNS, but something else instead.

Hello, I found these awesome and huge no coin filters, it will be amazing if Bancuh dns could add them !
https://zerodot1.gitlab.io/CoinBlockerListsWeb/index.html#news
I found also these incredible huge lists collections :
https://github.com/Ultimate-Hosts-Blacklist/Ultimate.Hosts.Blacklist

I think we can try to add them. What do you think @Tomatoide ?

I think right now we have a fairly balanced filtering, we don't need to just add more duplicates or risk having false positives.

Great ! thank you so much @ragibkl !
I undersatand @Tomatoide that it could be false positive but here i speak about the dangerous crypto currency mining who can ruin us and cause harm to ecology and it is the main threat on the internet, the pirates use sophisticated techniques like using a very small power of your processor without without realising it and without clicking on any link despite your web browser is up to date,
and Webassembly Tehnology (WASM) is activated by default in web browsers but
WebAssembly may be used, just like JavaScript, to “steal” processing power instead of data. In 2019, an analysis of 150 different Wasm modules found out that about 32% of them were used for cryptocurrency-mining.
https://training.linuxfoundation.org/blog/webassembly-security-now-and-in-the-future/
Though Wasm has been around for a few years, it rose to prominence more recently when it was used for cryptocurrency mining in browsers. This opened a Pandora's box of potential malicious uses of Wasm.
https://www.virusbulletin.com/virusbulletin/2018/10/dark-side-webassembly/
So I think it's necessary for the average user who does not care about Cryto sites to have peaceful mind that the resources of his computer are not stolen, Zerodot1 is very famous and his list used by many famous software, you can see the list of programs on their sites and it will be great if this list is integrated, thank you !

@Tomatoide, about your legitimate apprehension of false postive, The Ultimate Hosts Blacklist (UHB) said :"All our information is gathered from multiple sources, tested regularly and merged into one massive file which is updated daily. Our hosts can be used on almost all operating system"

@trimechee bancuh already has anti cryptominer lists so no need to worry, same goes for ultimate there is already huge lists (and better imo with less aggressiveness and false positives) that bancuh uses.

Brilliant ! Thank you very much for your clarifications :)


Doc improvements: typos, grammar, formatting

Only markdown files have been edited. Fixed several instances of:

typos
grammatical issues
markdown formatting styles
code fencing issues

If all seems well, please merge.

@Ankurk99 I believe most issues have been resolved. Thank you for pointing it out.

Hey @HighnessAtharva, there are still a few review comments left, can you please address those? Also please sign the commit.
You will also need to resolve the conflicts :grimacing:

Signed-off-by: HighnessAtharva<EMAIL_ADDRESS>

Hey @HighnessAtharva, there are still a few review comments left, can you please address those? Also please sign the commit. You will also need to resolve the conflicts 😬

Resolved issues, should be fine to merge now?

Hey @HighnessAtharva, there are still a few review comments left, can you please address those? Also please sign the commit. You will also need to resolve the conflicts 😬

Resolved issues, should be fine to merge now?

Hi @HighnessAtharva, You have to squash the commits you have made and use the --signoff switch while committing again, this will squash your commits and pass the DCO checks.


Use stable coroutines

for #30
all tests pass locally

Coverage remained the same at 87.555% when pulling 62f604a3756cec10355bccbf3536989a90ef5188 on NikkyAI:0.3.0-ALPHA into 299eed10b0ec43bd769906e806839d8cd0bf18d5 on pgutkowski:0.3.0-ALPHA.

tested via publishToMavenLocal and my project compiles and runs fine again


Support per-assertion batch maximum bounds

It's common to have just a few assertion batches in a code base that are far more expensive/highly variable, and it would be much better to only raise the bounds on individual batches when you have to rather than raising them across all batches.
This is getting a bit complicated to specify on the CLI and we may want to find a way of adding it to the project file instead: https://github.com/dafny-lang/dafny/pull/3851

Shouldn't it be specified in-code, where the batch is defined?

Just came to request this.
Yes, in code would be great too!

There's a bit of a UX challenge to think through here: I'm not sure how to identify assertion batches in general, and/or robustly attach an attribute (for example) to an assertion batch. Even something like {:max-resource-count} on a method is ambiguous in the default encoding: does it refer to the well-formedness assertion batch or the implementation batch? And if splitting is used, can we somehow specify the limit on "batch 11/24"?

I'm not sure how to identify assertion batches in general

I suggest changing the language so most batches have to be named. I think better than assert {:split_here} true would be [split] label <BatchName>:
Btw, when you introduce splits, do you always get an extra WF and IMPL batch per split section, or are you only splitting the IMPL part and does the WF part stay one big batch?

One thing I could imagine, and maybe @keyboardDrummer drummer is also suggesting this above, would be to allow a maximum resource count to be attached to an assertion, and that would then apply to every assertion in the same batch.


Documentation update

Hey @AlexFyod,
This is a PR to get some feedback from you before we have to submit our final documents. Looking forwards to hearing your changes

Requirements document

I believe that the Group meeting recap section should be after requirements and not before.
Log in and Log out should be separate requirements.
Inconsistent articles usage. Create new questionnaire: missing "a"? Modify the questionnaire: unnecessary "the"? Please come up with a uniform solution.
Are there any features you are were thinking about, but are not planning to implement? If there are, please include them as well with clarifications why you are not going to implement them. Well, at least this section is mentioned on Nestor.

Architectural document

Can you find a way to get rid of leading 0.'s in your subsection titles?
I am not sure whether the Frontend Architectural Decisions section is in its right place. But let's assume it is.
Nestor also mentions the Change Log section, do you think it is a nice idea to add it to your document?


Add health and version endpoints

Supporting #184 and #223 - specifically:

Show the version endpoint to enable SF to know what it is actually querying if it so desires
Have the (enhanced!) health check endpoint behind authentication that can replace the exposed one

Note that this only partially resolves these issues - the existing health endpoint will still need to be removed, etc.

This change is

Codecov Report
Attention: 90 lines in your changes are missing coverage. Please review.

Comparison is base (a9b557b) 71.73% compared to head (ea00853) 71.60%.
 Consider uploading reports for the commit 7cbdda1 to get more accurate results

Files
Patch %
Lines

src/Serval.Client/Client.g.cs
53.43%
74 Missing and 14 partials :warning:

src/Serval.ApiServer/StatusController.cs
93.33%
0 Missing and 2 partials :warning:

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #238      +/-   ##
==========================================
- Coverage   71.73%   71.60%   -0.13%
==========================================
  Files         133      137       +4
  Lines        5727     5956     +229
  Branches      900      941      +41
==========================================
+ Hits         4108     4265     +157
- Misses       1204     1258      +54
- Partials      415      433      +18

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

When we move the deployment infrastructure to the new one, we can decommission the old one.

src/Serval.ApiServer/DeploymentVersion.cs line  at r1 (raw file):
Previously, ddaspit (Damien Daspit) wrote…
I think this project has gotten sufficiently complex at this point that it would be useful to use the same directory structure as the rest of the projects, so this class should be moved to the Contracts folder.

Moved the single file.

src/Serval.ApiServer/DeploymentVersion.cs line 3 at r1 (raw file):
Previously, ddaspit (Damien Daspit) wrote…
This should end with the Dto suffix. I would also rename this to VersionInfoDto.

Done.

src/Serval.ApiServer/DeploymentVersion.cs line 5 at r1 (raw file):
Previously, ddaspit (Damien Daspit) wrote…
This should be pascal case. Also, I think ServalServerVersion would be better.

Done.

src/Serval.ApiServer/HealthreportDto.cs line  at r1 (raw file):
Previously, ddaspit (Damien Daspit) wrote…
This should be moved to the Contracts folder.

Done

src/Serval.ApiServer/HealthreportDto.cs line 3 at r1 (raw file):
Previously, ddaspit (Damien Daspit) wrote…
To ease the move from the old endpoint to the new endpoint, it would probably make sense to use the same model as the old endpoint.

I didn't see that at all.  Let's talk today at the meeting.  I am inclined to follow the DTO route rather than the parsing function.  The only difference would be how to handle the data.

src/Serval.ApiServer/HealthreportDto.cs line 3 at r1 (raw file):
Previously, johnml1135 (John Lambert) wrote…
I didn't see that at all.  Let's talk today at the meeting.  I am inclined to follow the DTO route rather than the parsing function.  The only difference would be how to handle the data.

I enumerated the data in the dto.

src/Serval.ApiServer/StatusController.cs line 29 at r1 (raw file):
Previously, ddaspit (Damien Daspit) wrote…
The return type should be Task<ActionResult<HealthReportDto>>. The method name should be GetHealthAsync.

Done

src/Serval.ApiServer/StatusController.cs line 43 at r1 (raw file):
Previously, ddaspit (Damien Daspit) wrote…
I feel like app_version might be confusing. "App" usually connotes the calling application. I think just version would be fine.

Would we add versions of other things in the future?  Machine version?  machine.py version?  whether it is a production or staging deployment?  Should we call it DeploymentInfo?

src/Serval.ApiServer/StatusController.cs line  at r4 (raw file):
Previously, ddaspit (Damien Daspit) wrote…
This should be moved to the Controllers folder in this project.

So, should I add Nswag to controllers as well?  It is tested as integration and appears most applicable here.  Especially in that it uses the Serval.ApiServer version as the version.

src/Serval.ApiServer/StatusController.cs line 43 at r1 (raw file):
Previously, ddaspit (Damien Daspit) wrote…
I think that's fine. We use kebab case for all endpoints, so it should be deployment-info.

done.

src/Serval.Shared/Contracts/DeploymentInfoDto.cs line 5 at r4 (raw file):
Previously, ddaspit (Damien Daspit) wrote…
Are we differentiating between the version of the Serval.ApiServer and the whole deployment? For example, we could ship a new deployment that only updates Machine and not the Serval server. In this scenario, would we only update the deployment version and not the Serval server version?

I was thinking of using Serval.ApiServer as an indicator for the whole deployment, changing the version as needed.  Do you have a better way to track the version?  If it is only git tags, the deployment would not be able to know what version it was at.  Yet we also need git tags to have proper releases.  I was thinking of using the Serval.ApiServer project to coincide with git tag versions for deployments including 1.1.RC1, 1.2.3, etc.

src/Serval.ApiServer/HealthreportDto.cs line  at r1 (raw file):
Previously, ddaspit (Damien Daspit) wrote…
I should have been clearer. I meant create a Contracts folder in the Serval.ApiServer project and move it there.

Done

src/Serval.ApiServer/StatusController.cs line  at r4 (raw file):
Previously, ddaspit (Damien Daspit) wrote…
I'm not sure I understand what you mean by "should I add Nswag to controllers as well?". All I'm saying is that you should create a Controllers folder in Serval.ApiServer and move this file there. Generally, the folder structure should reflect the namespace structure.

Gotit.

src/Serval.ApiServer/DeploymentVersion.cs line  at r1 (raw file):
Previously, ddaspit (Damien Daspit) wrote…
I meant that this should be moved to the Contracts folder in the Serval.ApiServer project.

Done.

src/Serval.ApiServer/Contracts/HealthreportEntryDto.cs line  at r5 (raw file):
Previously, ddaspit (Damien Daspit) wrote…
The "r" in "report" is not capitalized in the filename.

Done.

src/Serval.Shared/Contracts/DeploymentInfoDto.cs line 5 at r4 (raw file):
Previously, ddaspit (Damien Daspit) wrote…
It might be useful to differentiate the deployment version and the Serval server version. If we differentiate between all of the other components of the deployment, except the Serval server, then we are being inconsistent and losing relevant information. We could easily specify the deployment version in the appsettings file.

Sure - I like it.  I was just thinking that there should be a proper place for it.

src/Serval.ApiServer/HealthreportDto.cs line 3 at r1 (raw file):
Previously, ddaspit (Damien Daspit) wrote…
I'm not saying that you need to use the same code to build the response. I'm just saying that the DTO should reflect the structure of the original health endpoint. You should be able to follow the code and update the DTO to match the output of the old endpoint.

I changed "Entries" to "Results".  Other than that, I am only adding fields.  We are not using them, but since they are secure, I see little risk in including them.

src/Serval.Shared/Contracts/DeploymentInfoDto.cs line 5 at r4 (raw file):
Previously, johnml1135 (John Lambert) wrote…
Sure - I like it.  I was just thinking that there should be a proper place for it.

Done

deploy/values.yaml line 3 at r6 (raw file):

externalHost: prod.serval-api.org
environment: Production
deploymentVersion: '1.1.0'

Switched deployment version to actual deployment files, that is, k8s.  This allows us to update the deployment without needing to update the docker image of serval-api.

src/Serval.ApiServer/Contracts/HealthReportEntryDto.cs line 7 at r7 (raw file):
Previously, ddaspit (Damien Daspit) wrote…
You should make Description, Exception, and Data optional, since these are optional in the underlying health check report entries.

Done.

src/Serval.ApiServer/Contracts/HealthReportEntryDto.cs line 7 at r7 (raw file):
Previously, johnml1135 (John Lambert) wrote…
Done.

Data appears to not be optional, namely, in HealthReportEntry.

src/Serval.ApiServer/Contracts/HealthReportEntryDto.cs line 7 at r7 (raw file):
Previously, ddaspit (Damien Daspit) wrote…
If it is empty, set it to null.

It is clearer.  Ill change it.

src/Serval.ApiServer/Contracts/HealthReportEntryDto.cs line 7 at r7 (raw file):
Previously, ddaspit (Damien Daspit) wrote…
Sorry, I was talking about the Data property. There is no need to include the Data property if it is empty. This is also consistent with the old endpoint. I would make it optional. The general rule of thumb for DTOs is that we only include a property if it has a value or data assigned to it. We want our DTOs to be as efficient as possible.

Done.

src/Serval.ApiServer/Controllers/StatusController.cs line 87 at r10 (raw file):
Previously, ddaspit (Damien Daspit) wrote…
You are using the bitwise OR operator. It should be ||. Also, you don't need to check if healthReportEntry.Data is null. It is not a nullable property. Once you make these changes, you should be able to get rid of the null-forgiving operator.

Done.


Cleanup: cleaning up .first/.second [source/common/config]

This is the second PR to this https://github.com/envoyproxy/envoy/issues/12354. This time is in the common/config submodule.
Commit Message:
Additional Description:
Risk Level: Low, solely cosmetic changes.
Testing: All existing tests passed.
Docs Changes:
Release Notes:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Deprecated:]

@junr03 @asraa this has been out here for a while now. Do you mind taking a look?

@asraa carries context from #12354 so I will let her take this.


Update README-ko.md

respons_type to response_type

Good catch! Thanks for the contribution. :+1: 😊