Transferring Issue Activity

11.40 In this simulation, I will test how the transferring issue works, I will first open an issue in this first repo named Software-Evolution-Practical-GitHub-Bots, then transfer the issue to another repo named Software-Evolution-Practical-Lehmans-Laws, then add some comments and and discussion

11.41 this is the first comment

11.42 this is the second comment

12.03 this is another comment


Add CodeCov Badge to README.md

Pull Request Description
Summary
This pull request adds code coverage badge.
Changes Made

Add coverage

Welcome to Codecov :tada:
Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.
:information_source: You can also turn on project coverage checks and project coverage reporting on Pull Request comment
Thanks for integrating Codecov - We've got you covered :open_umbrella:

Pull Request Description
Summary
This pull request adds code coverage badge.
Changes Made

Add code coverage badge to READM.md

nice!


change(perf): Decrease the request timeout to 15 seconds, to speed up the initial sync

Motivation
In #4155, we want to speed up Zebra's initial sync.
One way to do that is to give up sooner when peers are slow to respond.
Solution

Decrease the peer request timeout to 15 seconds

Review
Anyone can review this PR.
If it makes the sync faster, we should merge it, and open a ticket for a longer-term solution.
If it doesn't make the sync faster, we should close it.
Reviewer Checklist

[ ] Code implements Specs and Designs
[ ] Tests for Expected Behaviour
[ ] Tests for Errors

Follow Up Work

open a ticket for a longer-term solution

I'm running a full sync test here:
https://github.com/ZcashFoundation/zebra/actions/runs/2230497507
The time to beat is 5h47m.

Full sync took 5h45m, which is exactly the same speed.


Add Travis CI

Have some overview on commits, PR-s
@stevejenkins Please enable Travis

Shellcheck is forward-looking tool!
See https://travis-ci.org/szepeviktor/postwhite/builds/340193346#L454

@stevejenkins Could you please enable Travis?


net/textproto: add extra field to indicate whether EOF is reached

The existing implementation of ReadMIMEHeader() relies on the assumption that bufio will keep the EOF error. In the case where a rewind reader is use, bufio will always return a string and ignore the EOF. So a variable is used to indicate that EOF is reached.
Corresponding test is provided.
Fix #53858

Commit message does not align with latest fixes. Will open another PR for this


Add New Solution in Codeforces Folder of CF Round 715 (Div2) Problem B

I added new Solution in Codeforces Folder of CF Round 715 (Div2) Problem B in C++ Language.
Problem Link : https://codeforces.com/contest/1509/problem/B
Please review it and merge as a part of Hacktoberfest 2021.

@viveakrt ,  added the question URL in the code as well as in the description


Repeated field elements cannot be null in field: org.phenopackets.schema.v2.core.MetaData.resources

This error occurs after I have entered data for a phenopacket
InputValidator] Data format validator	input	com.google.protobuf.InvalidProtocolBufferException: Repeated field elements cannot be null in field: org.phenopackets.schema.v2.core.MetaData.resources

I am not able to recreate this error.

@belkassaby I have found an instance of this error:

I uploaded the example file: bethlem-myopathy-detailed.json. It had a lot of metadata errors, the suggestion to fix those worked. However, this one error is left. Can you tell what is null that should not be??

@belkassaby I just checked and this error occurs the same way on both dev and sqa sites.

This seems to be due to some already created phenopacket with a term not recognized by the validator, and/or the resource in the phenopacketlab backend not being found for that term. So the prefix of the term not found would be an ontology prefix not in phenopacketlab (CARO for instance for "Common Anatomy Reference Ontology") and the corresponding resource set in the phenopacket is undefined therefore when validating, the validator returns this error. I would need to somehow better manage the warning/error message so the user knows that..

@belkassaby
This should not happen with phenopackets we create, right? It might happen if somebody uploads a phenopacket? I do not understand where the CARO prefix is coming from?

@pnrobinson Yes this shouldn't happen with a phenopacket created through phenopacketlab. But it might happen with a phenopacket created elsewhere, (the CARO prefix is just an example i picked and if that prefix and id was found in a phenopacket (which it wouldn't because we dont have any property in a phenopacket that could have such a term from that ontology). The error will just be thrown if the file is validated after having been updated. So the user still can edit their file in the UI. It's just the validation that will return this result.

As I understand it, we are ignoring this error if it is caused by a phenopacket that was created elsewhere. I have not found this error on a phenopacket I have created. I'm going to mark this as done.


Duration Idea

1.1 update is perfect.
I have ideas for 1.2.

Add a duration of how long a button is pressed.

I have added this feature. Test it and lmk if you find any issues.


Update

Description
Here my contribution to "The Duck Gallery".

You must respect the following conditions

Your contribution must respect the code of conduct
It's your first PR to this repository
You have added your image of the duck downloaded from https://pimpmyduck.zenika.com
You have not changed the image of the duck
The image filename must be your GitHub username (ex: your-username.png)
You are using your own GitHub user and it's the same as the PR author
Into the contributors.js file, the message must be short and respect the code of conduct

If the PR doesn't respect those conditions, it will be closed

Sorry but you had already a PR done and merged on this repo.
You can make only one :)


Searching for methods with a "." prefix returns no results

Searches on http://docs.perl6.org/ for any method on with a string having a "." prefix (e.g. ".sort", ".kv") returns no results right now.

I think this is correct since method name is really sort (without dot operator).
Also searching for methods starting with dot works (..., .=, etc) works.

See #155

Yes, this falls under the #155 issue (and this particular search terms are blocked by Apache directory index). I'm going to close this.


Revert "fix: only triggers onResize event when width or height changes"

Reverts wellyshen/react-cool-virtual#109

Pull Request Test Coverage Report for Build 908522240

0 of 6 (0.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.09%) to 5.869%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/useVirtual.ts
0
6
0.0%

Totals

Change from base Build 908515626:
0.09%

Covered Lines:
17

Relevant Lines:
256

💛  - Coveralls


Static checker does not register T::Struct props of T::Hash[, anything]

Input
→ View on sorbet.run
# typed: true
class A < T::Struct
  prop :foo, T::Hash[[String, String], String], default: {}
end

A.new.foo

Observed output
editor.rb:6: Method foo does not exist on A https://srb.help/7003
     6 |A.new.foo
        ^^^^^^^^^
Errors: 1

At runtime this works as expected:
# typed: true
class A < T::Struct
  prop :foo, T::Hash[[String, String], String], default: {}
end

A.new.foo # => {}

Expected behavior
The static checker should not error on this case.

The issue is the key to the hash. Does it have to be a tuple, or could you make a different type?
https://github.com/sorbet/sorbet/issues/1991

I can work around it, just wanted to report as it fails in a pretty confusing way.


[WIP] Uniques V2

The goal:
The goal of Uniques V2 is to apply the best standards we currently have in the NFTs space while keeping the pallet as generic as possible.
This PR helps to track the progress and keep the technical discussions about the best approaches in one place.
Features currently in progress:

[x] built-in buy&sell methods to allow users trade NFTs in a trustless way
[x] new approvals structure
[x] royalties
[ ] new NFTs minting options

Features under research:

[ ] nested ownership
[ ] lending
[x] NFTs atomic swap
[ ] fractionalization
[ ] affiliates (private marketplaces)

Technical debt:

[ ] define different roles (e.g. admins) and implement ACL

I have not deeply dived into the code but the major question why it is in the separate pallet ? Why not to update uniques itself ?

It's in the separate pallet while in progress. The end goal is to have those changes in the main uniques pallet without creating a new one.


Delete a non-existing resource still returns 200

Hello, I found this strange behaviour when trying to delete a resource with a wrong id.
I'm not sure about what the REST standards says, but it shouldn't be clearer if the server return some kind of error, like a 404, when this happens?

I agree. I've fixed it on master and will release a new version soon :)

Thank you @typicode , your library has saved me a lot of time lately and keeps getting better :)

Just released 0.8.2.
Glad it's helpful, user feedback plays an important role in improvements too :)


Command to remove songs from queue

Syntax: remove <song position in queue>
Aliases: rm

Resolved with 514166c


Proposal to generalise DFT trait

The purpose of this PR is to consider generalising the TwoAdicSubgroupDft to a FourierTransform trait. The motivation is to have a unified trait that will include the existing DFT algorithms as well as the new one for Mersenne31 (see #117); this latter introduces the complication that the output is over a quadratic extension field of the input, which is not something TwoAdicSubgroupDft can handle.
The solution suggested here is to not explicitly tie the concept of Fourier Transform to fields with large 2-adic subgroups as it currently is (which one might argue is leaking implementation details into the API) , rather the trait merely reflects whether a given field has a Fourier Transform algorithm available. In addition, there is a new associated type called Range corresponding to the field where the output elements lie.
The interesting changes are in dft/src/traits.rs; all other changes in this PR are just to get the code to compile, though they do provide an idea as to what using the new trait might look like.

After discussion with @dlubarov we decided not to pursue the ideas here at this point.


Remove gir files from crate

Part of https://github.com/gtk-rs/glib/issues/289
cc @GuillaumeGomez

Strange diff

Oh, it wrong repo


fix(apps/prod/tekton/configs/triggers): fix trigger branches

Signed-off-by: wuhuizuo<EMAIL_ADDRESS>

/approve

/hold

/approve

/unhold


Fix coverage invocation

After inspecting the coverage report at coveralls, it seems like it was only reporting for the cb module.
I've updated the check to report for all of them by fixing the invocation of pytest on the travis script.
Not sure how this will affect our coverage report (might go down), but this would be good motivation to fix any missing coverage problems.

Pull Request Test Coverage Report for Build 336

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-3.8%) to 91.257%

Totals

Change from base Build 324:
-3.8%

Covered Lines:
334

Relevant Lines:
366

💛  - Coveralls

Updated some code to use magma's "coreir-verilog" target which removes the need for the function in common.util. This improves our coverage because there was missing lines in that function, and I don't think we need to thoroughly test it given the new magma feature.

Adding a pragma: nocover to the irun command puts us back above to 92% coverage which is pretty good. I think sticking above 90% is a reasonable target.


Circular view error

Fixes #1260

Error("A view returned its own vnode.")?

I can appreciate my wording might need adjustment, but I think the wordiness itself isn't the problem to address: longer and more descriptive error messages are generally better — especially when the route cause is obscure and necessarily involves domain specific terms. Consider the only other custom error, regarding an unrecognised first argument to m(): probably a typo, and 'string' and 'component' are fairly obvious with reference to the documentation; in this scenario we're probably looking at a confusion Component views and RouteResolver renders, or a mistake in assigning the wrong function to a Component's view key, or perhaps a total lack of familiarity with how Mithril views work — obscure problems rather than "oh yeah silly me". Maybe 'the vnode supplied to it' could be 'the vnode it receives', or 'the vnode it was passed'? That's the problematic part, isn't it?
My concern with 'its own vnode' is that, well, all views should return vnodes. When you talk about a view's 'own' vnode, I assume you're talking about the vnode it returns. 'Itself' is also ambiguous IMO: the view function itself? No, the component. A component returns itself? Yeah, that is kind of the problem. Kind of. But then differentiating static component references from internal component instances, from a component instances raw vnode (as opposed to vnode.instance), from the output of the view… It's all a bit of a can of worms, especially for novices. My inclination is that wordy English is likely to be more helpful even if it doesn't translate clearly…?

new Error("A view cannot return the vnode it received as parameter")?

Actually, in Javascript we call them 'arguments' ;P — other than that looks good to me

Sometimes I wish I could :+1: merges... This one made me chuckle :-)
Crushing the bikeshed by landing a helicopter on the roof.


Bind this.onDrop to use desired component

Hey! Thanks for you contribution! You don't need to use bind when using createClass. You could update the example to use class, but even in this case, this would be an anti-pattern. It's much better performance-wise to bind before and use the reference to the bound function in the render method to pass it down.

Uhm, I'm sorry then. I tried this example (with a modification since I was using babel (like in this example) and it didn't work without the bind. What do you recommend me in this case? should I use bind or is there another alternative? Thanks

You could bind the method in the constructor:
class MyComponent extends React.Class {
    constructor() {
        this.onDropCallback = this.onDrop.bind(this);
    }

    onDrop() {
    }
}

Thanks.


Use consistent project IDs between solutions

We don't want to run out of GUIDs... :trollface:
Just kidding, but this might help incremental builds between solutions (and build.cmd).

Anything need to change in OracleProvider.sln?

Minor thing but oracle provider should also be updated.

AppVeyor timed out. are you on latest dev rebase?


Paul/update docs elm

Note that I returned admin_tutorial.md to Edon's original one.

We still need to add CAST, but that can be done in another pull request. Can one of you do it? (You know better than me what is allowed and what isn't.)

Yes, I will handle it soon.


Add (passing) tests.

Thanks for the PR!

Thanks! The tests helped me debug the Kotlin version which now produces exactly the same output as the Java version. (There is, however, one last issue I'm seeing with output formatting where the semicolon is included.)


[New Function] Page 99000888 - Get2

Is it possible to add a new function as external in page 99000888 "Work Center Load Lines" to get variables that was initialized in function Set, so I can use them in page extension?
Edit: I forgot to set all parameters to VAR

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. We will update this issue with information about availability.


next_series_episodes does not advance to next season if only season packs are in series database

Expected behaviour:
next_series_episodes finds that the next episode to obtain is S03E01.
Actual behaviour:
next_series_episodes sees two seasons in the series database and never tries to determine if there were episodes beyond that. There are no calls to TVmaze.
I have a show in my database for which I used a learn task to indicate that I have two complete seasons.
┌Review─────┬────────────┬───────────────────────────────────┬──────────────────────┬────────┐
│ Entity ID │ Latest age │ Release titles                    │ Release Quality      │ Proper │
├───────────┼────────────┼───────────────────────────────────┼──────────────────────┼────────┤
│ S01       │ 0h         │ Review S01 720p hdtv h264 dd5.1 * │ 720p hdtv h264 dd5.1 │        │
│ S02       │ 0h         │ Review S02 720p hdtv h264 dd5.1 * │ 720p hdtv h264 dd5.1 │        │
└───────────┴────────────┴───────────────────────────────────┴──────────────────────┴────────┘
 * Downloaded

Currently S03 is airing (eps 1, 2, and 3 have aired). I am trying to use discover to search a site for these three episodes, but according to the log, it gives up after skipping S01 and S02 - it never tries to find out what the next episode should be.
Note that I know for a fact the config works okay if there are previously downloaded episodes in the season, as I ran it with another show and it worked fine.
Steps to reproduce:

Step 1: ...

Config:
  catchup_btn_search_eps:
    manual: yes
    template:
      - https_fix
      - deluge-connect_tv
    configure_series:
      from:
        entry_list: catchup
      settings:
        exact: yes
        quality: 720p hdtv|webdl|webrip h264
        identified_by: ep
    discover:
      what:
        - next_series_episodes: yes
      from:
        - btn: '{? btn.api_key ?}'
      interval: 1 minute
    list_add:
      - entry_list: catchup_log
    set:
      tracker: tv
      step: '1'

Note the entry-list contains one entry:
┌─────────────────┬───────────────────┐
│    Field name   │ Value             │
├─────────────────┼───────────────────┤
│   original_url  │ http://myshow.com │
│      proper     │ False             │
│   proper_count  │ 0                 │
│  series_episode │ 3                 │
│ series_episodes │ 1                 │
│    series_id    │ S03E01            │
│  series_season  │ 3                 │
│      title      │ Review            │
│       url       │ http://myshow.com │
└─────────────────┴───────────────────┘

Log:
2017-04-05 23:40 DEBUG    manager                       Figuring out config load paths
2017-04-05 23:40 DEBUG    manager                       Found config: /Users/plex/.flexget/config.yml
2017-04-05 23:40 DEBUG    manager                       Config file /Users/plex/.flexget/config.yml selected
2017-04-05 23:40 DEBUG    manager                       sys.defaultencoding: ascii
2017-04-05 23:40 DEBUG    manager                       sys.getfilesystemencoding: utf-8
2017-04-05 23:40 DEBUG    manager                       flexget detected io encoding: utf-8
2017-04-05 23:40 DEBUG    manager                       os.path.supports_unicode_filenames: True
There is a FlexGet process already running for this config, sending execution there.
2017-04-05 23:40 DEBUG    manager                       Sending command to running FlexGet process: [u'-L', u'debug', u'execute', u'--tasks', u'catchup_btn_search_eps']
2017-04-05 23:40 DEBUG    cron_env                      Encoding utf-8 stored
2017-04-05 23:40 DEBUG    util.simple_persistence                 setting key terminal_encoding value 'utf-8'
2017-04-05 23:40 DEBUG    task          catchup_btn_search_eps executing catchup_btn_search_eps
2017-04-05 23:40 DEBUG    template      catchup_btn_search_eps Merging template https_fix into task catchup_btn_search_eps
2017-04-05 23:40 DEBUG    template      catchup_btn_search_eps Merging template deluge-connect_tv into task catchup_btn_search_eps
2017-04-05 23:40 DEBUG    remember_rej  catchup_btn_search_eps Task config has changed since last run, purging remembered entries.
2017-04-05 23:40 DEBUG    series        catchup_btn_search_eps connecting series Review to task catchup_btn_search_eps
2017-04-05 23:40 DEBUG    series        catchup_btn_search_eps no downloaded episodes found for series 'Review', season: None, downloaded: True
2017-04-05 23:40 DEBUG    next_series_episodes catchup_btn_search_eps season 2 is marked as completed, skipping
2017-04-05 23:40 DEBUG    next_series_episodes catchup_btn_search_eps season 1 is marked as completed, skipping
2017-04-05 23:40 WARNING  discover      catchup_btn_search_eps Input next_series_episodes did not return anything
2017-04-05 23:40 VERBOSE  discover      catchup_btn_search_eps Discovering 0 titles ...
2017-04-05 23:40 DEBUG    backlog       catchup_btn_search_eps 0 entries purged from backlog
2017-04-05 23:40 VERBOSE  details       catchup_btn_search_eps Task didn't produce any entries.
2017-04-05 23:40 VERBOSE  manipulate    catchup_btn_search_eps Modified 0 entries.
2017-04-05 23:40 DEBUG    urlrewriter   catchup_btn_search_eps Checking 0 entries
2017-04-05 23:40 VERBOSE  details       catchup_btn_search_eps Summary - Accepted: 0 (Rejected: 0 Undecided: 0 Failed: 0)
2017-04-05 23:40 DEBUG    list_add      catchup_btn_search_eps no accepted entries, nothing to add
2017-04-05 23:40 DEBUG    series        catchup_btn_search_eps on_task_learn
2017-04-05 23:40 DEBUG    util.simple_persistence catchup_btn_search_eps Flushing simple persistence for task catchup_btn_search_eps to db.
2017-04-05 23:40 DEBUG    util.simple_persistence catchup_btn_search_eps Flushing simple persistence for task None to db.

Additional information:

Flexget Version: 2.10.27
Python Version: 2.7.13
Installation method: pip
OS and version: macOS El Capitan 10.11.6
Link to crash log: n/a

Great scenario! I'll fix this ASAP

I appreciate the quick turnaround on this, but I don't think it's fixed (or I'm misunderstanding how this is supposed to work). I tried again and got this log:
2017-04-06 18:11 DEBUG    series        catchup_btn_search_eps no downloaded episodes found for series 'Review', season: None, downloaded: True
2017-04-06 18:11 DEBUG    series        catchup_btn_search_eps no downloaded episodes found for series 'Review', season: 3, downloaded: True
2017-04-06 18:11 DEBUG    series        catchup_btn_search_eps no downloaded season packs found for series 'Review', season: 3, downloaded: True
2017-04-06 18:11 VERBOSE  next_series_episodes catchup_btn_search_eps Series `Review` has no history. Set begin option, or use CLI `series begin` subcommand to set first episode to emit
2017-04-06 18:11 WARNING  discover      catchup_btn_search_eps Input next_series_episodes did not return anything

flexget series show "Review" still shows S01 and S02 as present, and it knows to be using ep-style identifiers. Do I have to set begin s03e01 in addition to telling it that I have S01 and S02? I can I guess, I just assumed it would see S01 and S02 as done and then ask TVmaze what the next episode after that is.

You have to set begin to use it, that part didn't change

This is what I'm not getting, then.
Scenarios:
1a. I insert My Show S01E01 into the database. I don't set any begin options or anything like that.
1b. I run a discover task with next_series_episodes on it. It figures out that S01E02 is the next expected episode and starts looking for that.
1c. As a result of using estimators, it figures out that each season is only one episode, and then starts looking for S02E01.
2a. I insert My Show S01 into the database. Again, no begin options or anything.
2b. I run a discover task with next_series_episodes on it. It wants me to set a begin episode.
There's inconsistency between these two nearly-identical scenarios. In both cases, the database knows the identifier style. (I even added it to the configure_series settings in the task to be doubly sure.) In both cases, a season has ended and it should be looking for the next one - scenario 1 doesn't know that and outputs S01E02 and uses estimators to find out that's not real and to now check for S02E01 ... but scenario 2 doesn't even output S02E01 as a possible starting point, it just gives up. But scenario 2 knows I have completed S01, so why wouldn't it output S02E01 and let the estimators sort out if that's a real episode?
It seems like the assumption is that if there are episodes downloaded in the latest known season, to continue downloading there, but if all known seasons are completed, to not try to start a new season (edit: unless from_start is set). Is that correct?
Contrast this with the normal series plugin, which given scenario 2 above accepts S02E01 as the next episode.
After I read the code, I added from_start: yes, and it immediately worked ... but I'm confused why this is necessary to get the two scenarios to work in a consistent manner.

Not trying to pile on here, but a thought occurred to me ... after looking at next_series_seasons code, it seems like if you only ever download season packs, next_series_seasons just flat-out wouldn't work (again without using from_start).
It's not that I'm necessarily averse to adding from_start to the config, but the option name wouldn't jump out at me as something that I should add when (as in my original case with Review) I don't actually want to get downloads from the start. It also seems very unintuitive that episodes and season packs are treated so differently - episode history works by itself, but season pack history is meaningless without additional options set.
Maybe I'm completely off-base here and there are other reasons for this being designed as it is. I've been wrong before. :)

I moved my discussion to a new issue #1782 since the immediate issue here was resolved.


[Feature Request] Add toggle for cursor/line diagnostics

Would it be possible to add an option to change the behavior to surface line diagnostics instead of cursor diagnostics when on a line?

You want to see all the errors, warnings... on the actual line, and not only where the cursor is ? Is it correct ?

Yes! As far as I understand right now it kind of does this already, because it shows the first line diagnostic if no diagnostic is found for the cursor position, right? But if on a token with a diagnostic attached, then it shows that diagnostic. Depending on how #44 works, this is a mute point, I'll have to check and test that out.

It should be good now.
You can set
require("tiny-inline-diagnostic").setup({
		-- Show all diagnostics on the cursor line.
		show_all_diags_on_cursorline = true,
})

And it will display all diagnostics on your cursor line.


datapath/linux: Remove device's neighbors upon device deletion

For a deleted device netlink does not always send complete set of neighbor delete messages, therefore delete the neighbors for the deleted device explicitly.

/test


message list should not query contact provider in bind method

Often I am experiencing a really slow and laggish graphic user interface on Android 5.1.1 and K-9 Mail 5.006
I collected some debug infos in the way described in the webpage [1] and I uploaded at URL [2]
[1] https://github.com/k9mail/k-9/wiki/LoggingErrors
[2] https://mega.co.nz/#F!lk4gTKxJ!1ge40kShWt8IwxQVVXEnmA

Apparently, list scrolling and messages selection seriously lag only when "Show contact names" is set in Settings > Global settings > Display.

Il 20/ago/2015 11:56 AM, "Mihai Lazarescu"<EMAIL_ADDRESS>ha
scritto:

Apparently, list scrolling and messages selection seriously lag only when
"Show contact names" is set in Settings > Global settings > Display.

Did you find out from my logs or is it a known problem?

I tried disabling my settings one by one until I got a normal-reacting GUI.

Il 20/ago/2015 08:18 PM, "Mihai Lazarescu"<EMAIL_ADDRESS>ha
scritto:

I tried disabling my settings one by one until I got a normal-reacting
GUI.

Your workaround works correctly. Now I hope that the bug will be fixed soon

Just posting here to confirm the issue with very slow responsiveness when Show Contact Names is enabled in v.5.006.
I'm on Android 4.4 Galaxy S5

Sorry, Android 5.0, not 4.4

For me disabling the "Show Correspondent Names" fixed the lag on the mails list.
Android 4.1.2 , K-9 v5.006

Thanks for this temporary solution
I was totally frustrated, moved my app data with titanium Backup from Samsung Galaxy Note edge with 5.1.1 to lg g4 with 5.1
And it was slowly reacting like hell
Disabling the show names and all works fine, beside the missing names
Hope there will be a fix

Oh I forgot to write, just Disabling the feature names from contact data is the issue, you don't need to disable the main show name feature

« "Show contact names" is set in Settings > Global settings > Display »
YESS !
This has made my month. More than 2" to scroll or select spams to purge, instantly with this option disabled. Android 5.1.1.

The implementation of this option is rather questionable: It triggers a content provider query for the contact name in the bind method of each view (MessageListFragment.bindView -> MessageHelper.getDisplayName -> toFriendly -> contacts.getNameForAddress), which means hundreds of queries with a while of scrolling.
Options:

ditch the feature (until implemented correctly?)
add caching? it's still not nice to query in bindView methods
reimplement the feature and do it right™ - whatever that is.. I didn't look into the loading code in depth

Contact names are now fetched in a background thread. See #4214 and #4442.


[BACKPORT] Allow @ character in argument sanitizer

2.2 backport of https://github.com/konveyor/forklift-must-gather-api/pull/20
It is a common practice to use SHA256 signature of container
image names, like registry.example.com/app/web@sha256:.
The argument sanitizer doesn't allow the @ character, so these
image names will be truncated and will fail to be pulled.
This change adds the @ character in the accepted characters.

Test failure is unrelated, merging :+1:


<EMAIL_ADDRESS>decompress error

Installing 'bulk-rename-utility' (<IP_ADDRESS>) [64bit] from 'extras' bucket
BRU_setup_<IP_ADDRESS>.exe (11,0 MB)[===============================================================================================] 100%
Checking hash of BRU_setup_<IP_ADDRESS>.exe ... ok.
Extracting BRU_setup_<IP_ADDRESS>.exe ... Invoke-ExternalCommand: C:\Users\jan\scoop\apps\scoop\current\lib\decompress.ps1:253
Line |
 253 |  … tus = Invoke-ExternalCommand (Get-HelperPath -Helper Innounp) $ArgLis …
     |                                 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
     | Cannot validate argument on parameter 'FilePath'. The argument is null or empty. Provide an argument that is not null or empty, and then try the command again.
Failed to extract files from C:\Users\jan\scoop\apps\bulk-rename-utility\<IP_ADDRESS>\BRU_setup_<IP_ADDRESS>.exe.
Log file:
  ~\scoop\apps\bulk-rename-utility\<IP_ADDRESS>\innounp.log

Please try again or create a new issue by using the following link and paste your console output:
https://github.com/ScoopInstaller/Extras/issues/new?title=bulk-rename-utility%4<IP_ADDRESS>%3a+decompress+error

Okay, innounp was not working correctly.
This:
scoop uninstall innounp
scoop install innounp
scoop install extras/bulk-rename-utility

Works.


New model for IKEA LED1624G9

My new IKEA LED1624G2 is identified as 'TRADFRI bulb E14 CWS opal 600lm'
and was reported is a not supported device
devices.js i found that the LED1624G9 was already present for the E27/E26 type.
Once i changed the zigbeemodel for the IKEA LED1624G9 to include the 'TRADFRI bulb E14 CWS opal 600lm' is was correctly detected.
My device is an E14 model so i updated teh Discription as well.
The entree in "ode_modules/zigbee-shepherd-converters/devices.js" for the IKEA LED1625G9 looks like this for me now :
{         zigbeeModel: ['TRADFRI bulb E27 CWS opal 600lm', 'TRADFRI bulb E26 CWS opal 600lm', 'TRADFRI bulb E14 CWS opal 600lm'],         model: 'LED1624G9',         vendor: 'IKEA',         description: 'TRADFRI LED bulb E14/E27/E26 600 lumen, dimmable, color, opal white',         extend: generic.light_onoff_brightness_colorxy,     },
I'm new to Github and i'm not sure if this is the correct way to report this, but i hope it is helpfull.
Kr. Erwin

This device has already been added support for (https://github.com/Koenkk/zigbee-shepherd-converters/pull/529). It will be included in the next zigbee2mqtt release (1.6).


CLI for M365 version for script "Get SharePoint List Or Library Permissions And Export It To CSV"

🎯Aim
The aim of this issue would be to add a CLI for M365 version of script Get SharePoint List Or Library Permissions And Export It To CSV.
🤔How
I think one of the best approach would be to use the following commands:

list-get (we should use --withPermissions option)
group-get
user-get

@nanddeepn totally 👍 You rock 🤩🤩


[FEATURE REQUEST] Store settings and flag names in notes/memos

Is your feature request related to a problem? Please describe.
Yes, it's hard to synchronize Toolkit settings across devices.
Describe the solution you'd like
I currently store my Toolkit settings JSON in the notes of an empty category at the top of my budget, so I can easily copy & paste it on other devices. This functionality could be built-in to Toolkit, and made more transparent by using the memo on a $0 transaction.
Describe alternatives you've considered
There are various other areas data can be stored, like notes on a category or account notes. Notes on a category would require creating a special category specifically for Toolkit settings, which would clutter the category display when using your budget from a device without Toolkit installed. Account notes are a possibility, as a $0 transaction would also somewhat clutter the account register of the account the transaction is on while account notes are fairly hidden. This falls apart when a user actually uses account notes, in which case Toolkit would interfere with the existing notes so would have to create a new account specifically for settings.

Actually that's a great idea IMHO. Creating an Unlinked Asset account and storing the settings in the notes field:

...

should work to "synchronize" settings across browsers. Would need to be a feature to enable, some folks might not actually want all settings synced.

This is definitely a really cool idea. I've added a link to this FR to this Trello card.
Now that we have live-settings, it's actually totally possible for us to do this. Before, we needed all the settings before we loaded YNAB.


[BUG]

Describe the bug
It seems some linker libraries used for communicating with Discord are for x64 machines only, which causes Minecraft to crash on arm64-based machines.
To Reproduce
Steps to reproduce the behavior:

Use an arm64 based machine
Simply use the mod and Minecraft will crash

Mods
I've removed every single mod and just using this one killed Minecraft.
Log
https://mclo.gs/A2vKYhH
(this was a log when I had my normal mods, but having none has the same effect)
Notice the line below
Caused by: java.lang.UnsatisfiedLinkError: dlopen(/Users/{COMPUTER_USERNAME}/Library/Application Support/ModrinthApp/meta/natives/1.21.1-0.16.5/jna8504912572727924396.tmp, 0x0009): tried: '/Users/{COMPUTER_USERNAME}/Library/Application Support/ModrinthApp/meta/natives/1.21.1-0.16.5/jna8504912572727924396.tmp' (mach-o file, but is an incompatible architecture (have 'x86_64', need 'arm64e' or 'arm64')), '/System/Volumes/Preboot/Cryptexes/OS/Users/{COMPUTER_USERNAME}/Library/Application Support/ModrinthApp/meta/natives/1.21.1-0.16.5/jna8504912572727924396.tmp' (no such file), '/Users/{COMPUTER_USERNAME}/Library/Application Support/ModrinthApp/meta/natives/1.21.1-0.16.5/jna8504912572727924396.tmp' (mach-o file, but is an incompatible architecture (have 'x86_64', need 'arm64e' or 'arm64'))

Additional context
I use MacOS, and any prior mod version doesn't work.

Hey there!
You are indeed correct, the linker/bindings this mod uses for discord stuff doesn't support arm. The only solution would be to switch to a new system because the one I'm currently using hasn't been updated since 2021, so it would be ideal to switch the system. This has been in my plans for a while now, and will probably be the next update I'll do.
Thanks for bringing this to my attention!

Hey there!
You are indeed correct, the linker/bindings this mod uses for discord stuff doesn't support arm. The only solution would be to switch to a new system because the one I'm currently using hasn't been updated since 2021, so it would be ideal to switch the system. This has been in my plans for a while now, and will probably be the next update I'll do.
Thanks for bringing this to my attention!

Hey! Forgot to add the issue title, but if you need any help with adding other linker libraries, let me know. Got an arm64 machine obviously, and I'm already looking into the code to see if I can add it myself :)


Folders open in the wrong window if you have 2 overlapping vscode instances

Issue Type: Bug
The same issue as these, reproducible:
#3572
#13790
Expected:

File > New Window
Switch to new vscode window in the foreground
File > Open Folder
The Folder should now be opened in the active foreground vscode window

Actual:

File > New Window
Switch to new vscode window in the foreground
File > Open Folder
The Folder actually opened in the original vscode window instead.

Notes:

Looks to be related to the "active" window as interpreted by vscode. It only occurs when 2 windows are opened and the "active" one is in front of the other.
If the new window is on a different screen, the issue does not occur.
If the new window is maximized to full screen, the issue does not occur.

VS Code version: Code 1.30.2 (61122f88f0bf01e2ac16bdb9e1bc4571755f5bd8, 2019-01-07T22:49:48.319Z)
OS version: Linux x64 4.15.0-43-generic

System Info

Item
Value

CPUs
Intel(R) Core(TM) i7-6820HQ CPU @ 2.70GHz (8 x 3390)

GPU Status
2d_canvas: enabledchecker_imaging: disabled_offflash_3d: enabledflash_stage3d: enabledflash_stage3d_baseline: enabledgpu_compositing: enabledmultiple_raster_threads: enabled_onnative_gpu_memory_buffers: disabled_softwarerasterization: disabled_softwarevideo_decode: unavailable_softwarevideo_encode: unavailable_softwarewebgl: enabledwebgl2: enabled

Load (avg)
2, 1, 1

Memory (System)
15.12GB (1.50GB free)

Process Argv
--unity-launch

Screen Reader
no

VM
0%

Extensions: none

No need to be sarcastic. I've already seen each of those issues, but the bug still exists in the newest version 1.30.2 (which you can see I'm using).
Just trying to help you guys solidify your product. It takes a bit more than 5 minutes of my own time to submit an issue with a repro gif.  This is a minor bug and doesn't interrupt my workflow, but it should still be addressed.

@acberk 1.30.2 is the version we released last year and you can see that the bugs I mention target our upcoming release. To benefit from the fix right now you can use our insiders release (nightlies): https://code.visualstudio.com/insiders/
Please understand that we typically receive 100-200 issues per day (not just in this repository, also in others) and we have to keep the amount of time we spend on each issue to an absolute minimum to actually be able to get work done. With a repository of 50.000 issues it is unfortunately not easy to find the exact duplicate issue even for me who owns the issue.

Can confirm the bug is fixed in the current insiders build.


[cpr] update to 1.8.3

Fix #24579
Update cpr to the latest version 1.8.3
All features are tested successfully in the following triplet:

x86-windows
x64-windows
x64-windows-static

Thanks for the update!


AttributeError: 'LogisticRegression' object has no attribute 'encode_features'

The document mentioned that we can pass any linear or tree model to ClassicTreeExplainer. All code works smoothly if we use the classifier from interpret-text, however, if we train a logistic regression on the outside, and try to pass it to classic explainer, it gives the above error.
Now, the question is, do the explainers actually support any outside model or it has to be fitted from classifiers inside interpret-text package?
My code:
n = X_train.shape[0]
vec = TfidfVectorizer(ngram_range=(1,2), tokenizer=tokenize,                min_df=3, max_df=0.9, strip_accents='unicode', use_idf=1,                smooth_idf=1, sublinear_tf=1 )
trn_term_doc = vec.fit_transform(X_train)
test_term_doc = vec.transform(X_test)
m = LogisticRegression()
model1=m.fit(x,y_train)
predicted_label = model1.predict(test_x)
explainer = ClassicalTextExplainer(model1)
local_explanation = explainer.explain_local(X_test.iloc[0], predicted_label[0])
The last line results in the error

AttributeError                            Traceback (most recent call last)
 in
----> 1 local_explanation = explainer.explain_local(X_test.iloc[0], predicted_label[0])
~/anaconda3/envs/fairlearn/lib/python3.6/site-packages/interpret_text/experimental/classical.py in explain_local(self, X, y, name)
143         X = _validate_X(X)
144
--> 145         [encoded_text, _] = self.preprocessor.encode_features(
146             X, needs_fit=False
147         )
AttributeError: 'LogisticRegression' object has no attribute 'encode_features'
X_test is the actual texts in the test data, X_test.iloc[0] is actually "Thank you for correcting my typo in Thomas Pooley. I am the world's worst proofreader!"
Just want to find an answer

Hi @anindya5,
I think you need to change the code "explainer = ClassicalTextExplainer(model1)" to "explainer = ClassicalTextExplainer(model=model1)". Can you give this a try?
Regards,


[AIRFLOW-3137] Make ProxyFix middleware optional.

The ProxyFix middleware should only be used when airflow is running
behind a trusted proxy. This patch adds a USE_PROXY_FIX flag that
defaults to False.
Make sure you have checked all steps below.
Jira

[x] My PR addresses the following Airflow Jira issues and references them in the PR title. For example, "[AIRFLOW-XXX] My Airflow PR"

https://issues.apache.org/jira/browse/AIRFLOW-3137
In case you are fixing a typo in the documentation you can prepend your commit with [AIRFLOW-XXX], code changes always need a Jira issue.

Description

[x] Here are some details about my PR, including screenshots of any UI changes:

The ProxyFix middleware should only be used when airflow is running
behind a trusted proxy. This patch adds a USE_PROXY_FIX flag that
defaults to False.
Tests

[x] My PR adds the following unit tests OR does not need testing for this extremely good reason:

Commits

[x] My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":

Subject is separated from body by a blank line
Subject is limited to 50 characters (not including Jira issue reference)
Subject does not end with a period
Subject uses the imperative mood ("add", not "adding")
Body wraps at 72 characters
Body explains "what" and "why", not "how"

Documentation

[x] In case of new functionality, my PR adds documentation that describes how to use it.

When adding new operators/hooks/sensors, the autoclass documentation generation needs to be added.

Code Quality

[x] Passes git diff upstream/master -u -- "*.py" | flake8 --diff

Codecov Report

Merging #3983 into master will decrease coverage by <.01%.
The diff coverage is 50%.

@@            Coverage Diff             @@
##           master    #3983      +/-   ##
==========================================
- Coverage    75.5%   75.49%   -0.01%
==========================================
  Files         199      199
  Lines       15945    15947       +2
==========================================
  Hits        12039    12039
- Misses       3906     3908       +2

Impacted Files
Coverage Δ

airflow/www/app.py
98.95% <50%> (-1.05%)
:arrow_down:

airflow/www_rbac/app.py
96.7% <50%> (-1.08%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c7be7af...faafb19. Read the comment docs.

Good catch @ashb; I just updated the PR.

@jmcarp will this fix (as well as #3580) be included in airflow 1.10.1? And do you know when it will hapen? Thanks!

@victornoel I've just marked them for inclusion in 1.10.1 so we don't forget. Most accurate I can offer on timings is "we're aiming for with in a month".


trusty: sepolicy for mock rpmb

Enabling mock rpmb module sepolicy which is required for creating of the creation of mock RPMB in /data on boot up.
Tests Done:

Boot the device in MTL nuc.
storageproxyd service is running.

Tracked-On: OAM-128292

Android CI has started Engineering Build for this issue ,Please check the linked Tracked-On issue/Android CI Web  for more details.

SUCCESS: Android CI has completed Engineering Build for this issue.Please check the linked Tracked-On issue/Android CI Web  for more details.


Honor AccountBalanceSettings.maxBalance Setting

In the updateBalanceForFulfill.lua script, we should honor the maxBalance setting for the account.

Superseded by #215


ctrl-c is not working when debugging kernel with qemu-system

Somehow, when I'm trying to debug the linux kernel with qemu-system, I can't use ctrl-c to halt it.

With vanilla gdb, ctrl-c works without any issue.

Huh, this seems fix the problem:
diff --git a/gdbinit-gep.py b/gdbinit-gep.py
index b60b94f..d785414 100644
--- a/gdbinit-gep.py
+++ b/gdbinit-gep.py
@@ -541,7 +541,7 @@ def gep_prompt(current_prompt: str) -> None:
                         full_cmd += new_line

             if not quit_input_in_multiline_mode:
-                gdb.execute(full_cmd, from_tty=True)
+                gdb.execute(f"pi gdb.execute({full_cmd!r}, from_tty=True)")
         except gdb.error as e:
             print(e)
         except KeyboardInterrupt:

Weird, why it works?


template engine

What about template engine ( jade, slim etc ) ?

It's too complicated to parse since it's not HTML. It's never be released in this plugin unless someone else added this.


Not able to monitor Swarm master in Grafana ?

In current setup, we have 3 nodes and 1 master.
All nodes are visible properly on Grafana but Master is not visible Grafana.
Please help me to resolve this issu.
Thanks in advance :-)

Issue is resolved.


[JSON Schema Contrib] Module not found when run in Docker container

Hi,
I wrote a simple Docker image that install<EMAIL_ADDRESS>When trying it out with the Doker container, I got Cannot find module<EMAIL_ADDRESS>pkl eval<EMAIL_ADDRESS>\
      -m "output"   \
       -p source=path/to/build-connection-config.model.json

If I execute the command with multiple JSON schema files, then I got
I/O error loading module<EMAIL_ADDRESS>FileAlreadyExistsException: ?/.pkl/cache/tmp/?/.pkl/cache/tmp/package-1/pkg.pkl-lang.org/pkl-pantry/org.json_schema.contrib<EMAIL_ADDRESS>
I also noticed that the package got downloaded to the working folder
example gist: https://gist.github.com/nguyen-vo/abba17300366e3f38de759b7ecc6dff9

I think this is because you don't have a home dir set.
You can either try setting a home dir, or run pkl eval --no-cache, or pkl eval --cache-dir <some_dir>


Republish 6.2.0

It looks like 6.2.0 doesn't exist in npm.

+1
Getting No matching version found for<EMAIL_ADDRESS>while trying to update packages.
Seems like today's issues with NPM registry have affected publish somehow:
https://status.npmjs.org/incidents/b307lbjrdql7
https://status.npmjs.org/incidents/3rjzvts6v98k

Ah... rxjs-compat is missing? Sorry about that.

rxjs 6.2.0 itself also isn't in NPM.

That's... startling, considering I published yesterday and confirmed it multiple times. Checking my logs now.

It shows up here but both npm show rxjs and yarn info rxjs show 6.1.0 as the last published version.

NPM is having issues, apparently... It's showing as 6.2.0 on their website, but npm in terminal is telling a different story.
Seems related to either this bug, or whatever they're trying to fix this bug: https://github.com/npm/npm/issues/20714

So you think it's just going to resolve itself?

@clayne11 I'll give it a bit.. Publishing is currently a bit of a PITA, so I'm hopeful npm resolves the issue themselves. I've filed a ticket.

npm has resolved this <3


Operator scripts

Add operator scripts to create node home folder, create private key, create gentx transaction file, import mnemonic and show key info.

Hello can you provide a script to export key to .  Or a full toolbox like this plz
https://github.com/nico2511/Galactica_TestNet/

Oops integrated in show key script . Thanks Cyril on Discord !!


cannot get height and width for page

** cannot get height and width. I try it when the page strart or end.  **

Code example to reproduce the issue:
def main(page: ft.Page):
    ui_size.update(page.width, page.height)
    page.title = f"xxx"
    logging.warning(f"窗口{page.title}分辨率:{page.width} * {page.height}")
    page.vertical_alignment = ft.MainAxisAlignment.START
    # page.bgcolor = ft.colors.BLUE
    page.opacity = 0.5
    page.spacing = ui_size.spacing
    page.padding = ui_size.page_padding
    from views.view_switch import get_manager_view
    # 定义切换
    page.manager_view = get_manager_view()
    page.manager_view.update_page(page)
    # page.manager_view.switch_main()
    page.manager_view.switch_view(page.manager_view.URL_ORDER_LIST)
    logging.warning(f"last,窗口{page.title}分辨率:{page.width} * {page.height}")

Additional information you deem important (e.g. issue happens only occasionally):
Flet version (pip show flet):
flet                          0.9.0
flet-core                     0.9.0
flet-route                    0.3.2
flet-runtime                  0.9.0

Operating system:  macos and ubuntu

the same result in version 0.10.3

Downgraded the flet version, this issue is resolved.
bin/python3 -m pip list | grep flet
flet                          0.6.0
flet-core                     0.6.0
flet-route                    0.3.2
flet-runtime                  0.9.0

Downgraded the flet version, this issue is resolved.

Nice!
But I didn't understand.
You wanted to print page.width and page.height but nothing was displayed?

Downgraded the flet version, this issue is resolved.

Nice!
But I didn't understand. You wanted to print page.width and page.height but nothing was displayed?

I didn't post it. The result is 0.0 and 0.0.
As shown in the following figure， my debugging results:

Ah Alright!
That's strange, I must admit.

All flet, flet-core and flet-runtime must be the same version.


[Feature] Better zsh completion

This is still work in progress. It is a draft PR.

There are lots of TODO comments.
Many parts are not well tested.
The history is likely to be messy and also likely to end up squashed, reworked etc

Still, feedback is welcome.

Commit ad4ce1f is a reasonable example of what updating the completion file in the future when the command line interface changes would entail. Not difficult (generally) but another thing you will end up having to remember to do.
Note: That commit also includes a bug fix to the definition of -U/--user in aur-build (the format should be --flag=:description of the argument to the flag:completion_function. The middle section was missing (but is required when you have a completer function. Depending on shell settings the middle value may be displayed to the user to aid them.

Sorry I've been busy lately. I can give some comments on the TODOs:

TODO: It is not clear to me how mode flags interact with source flags.
Specifically --search and --info also overwrite mode. Are those exlusive with mode flags?

The aur-pkglist command-line is problematic because behavior depends on the order of the command-line flags (e.g. --info --quiet vs. --quiet --info). That's something to be fixed in a future version.

TODO: Undocumented?

aur-pkglist --plain should be documented or the flag left out

TODO: "[...] or any other field generated by repo-add"

I left this in because I don't know what fields repo-add might add in the future. I don't know of a way to retrieve all possible fields programmatically.

TODO: Possibly be smarter about positional arguments based on what search_by is specified

For an info search __aur_list_pkgs could be used, a regular search (where the term does not have to match any existing packages) should not be completed.

TODO: This should maybe be only local packages (i.e. {aur repo -l | cut -f1})?

Good point. It seems odd that aur repo -q implies aur repo -u, and does not apply to -l.

Commit ad4ce1f is a reasonable example of what updating the completion file in the future when the command line interface changes would entail. Not difficult (generally) but another thing you will end up having to remember to do.

Looks reasonable to me

The aur-pkglist command-line is problematic because behavior depends on the order of the command-line flags (e.g. --info --quiet vs. --quiet --info). That's something to be fixed in a future version.

That would be difficult to express using _arguments in zsh and would require manual parsing. And since it is likely to change in the future there doesn't seem to be much point in doing so. I'm just going to not try to handle that.

aur-pkglist --plain should be documented or the flag left out

Yes the man page needs to be updated! (Hint hint!) I added '--plain[list output one package per line, default behaviour]' for now. That seems accurate to me. But if it becomes a hidden option it should be removed.

I left this in because I don't know what fields repo-add might add in the future. I suppose one could retrieve all fields programmatically by printing all %...% headers in a repository .db.

I found (at least) one flag that was actually missing in the man page already: optdepends. So yeah. I haven't done a complete check though. Automatically retrieving that list would be nice. Probably best if it is implemented as a hidden option that the completion code can call to get it, one option per line.

Good point. It seems odd that aur repo -q implies aur repo -u and does not apply to -l.

aur repo -luq should work instead of what I wrote I believe (can't test it as I don't have any outdated packages on my system right now). That should (I believe) be the list of all things that would make sense to ignore?

#993 fixes the remaining inconsistencies between tab-completion and documented options.

It's a compromise between the "most relevant" ignore targets (AUR upgrades which you may not want) and a slight delay on the tab completion. Either way, in https://github.com/AladW/aurutils/pull/992 -q applies to both --list and --upgrades.

Another thing to note is that --ignore can be used as a crude way to handle provides. See https://github.com/AladW/aurutils/issues/837. Then aur repo -ql is preferable over aur repo -qu

As far as I can see there is only one issue remaining, and that is what do do about the undocumented (but not hidden) --buildscript flags to aur srcver and aur build.

aur-srcver(1): https://github.com/AladW/aurutils/commit/4feddcf9d12032523ad7eda48775e972705af86e
aur-repo(1): https://github.com/AladW/aurutils/commit/4feddcf9d12032523ad7eda48775e972705af86e
aur-build(1): https://github.com/AladW/aurutils/pull/993/commits/16f28102928e6f57e408049b576f62c39a3c5a0e (#993)

I don't know anything else left to do. It is large enough that I would be surprised if there aren't any bugs left. But nothing I have run into in daily use, nor in focused testing.
As for possible improvements:

It would be nice to be able to complete the comma separated lists of arguments to makepkg. And that wouldn't even be difficult (using the _sequence helper bundled with zsh). Except _makepkg is an lazy loaded function defined in a file that is not named the same as the function (it is defined in _pacman). I don't know of a way to ensure it would be available when the user has not yet tab completed any command from the _pacman file.

The _arguments helper that I use throughout the file has a... somewhat dense? syntax. In addition the official documentation is verbose and dense. Tutorials and looking at existing code is a much easier way to get into it. The general form is however not bad: <optional-repeat-marker>(<exclusivity-spec>)<flag>[<help-string>]:<argument description>:<completer/action for argument>. The difficulty comes from all the details and variations (such as a leading space in front of the argument completer having a semantic meaning!). I'm happy to answer any questions you may have though, and I expect to be around and able to help for the foreseeable future.
In addition, different users will have zsh configured differently (that is one of the key selling points of zsh after all!). For example, I use zsh4humans where the argument description is generally not shown (since it conflicts with some other features: I get a tmux window popup with a fuzzy search of the completions available using fzf). On the grml config (used by the Arch live CD for example) it is shown however. This obviously makes testing a bit annoying.

Thanks, the effort is much appreciated. I'll give it a whirl soon and then merge it for the next release. Sorry for the late reply.
Regarding possible improvements, I wonder how to handle multiple repositories best. That is, aur repo -lq with no further arguments assumes a single local repository, and will error out if multiple are available (asking for disambiguation).
What complicates matters is that the completion output then depends on the order of arguments, i.e. if a local repository was specified with -d prior to, say, --ignore, then aur repo -d ... -lq is proper. If not (--ignore was specified after -d or -d was not specified at all) then the completion command would fail with more than one local repository.

[...] I wonder how to handle multiple repositories best. That is, aur repo -lq with no further arguments assumes a single local repository, and will error out if multiple are available (asking for disambiguation).

I have not thought about this use case.

What complicates matters is that the completion output then depends on the order of arguments

It is of course possible to to custom code and parsing of the command line. Still if ignore is passed before the user specifies the repo I don't see a solution other than error out gracefully with a _message (something that may or may not be displayed to the user depending on zsh settings, I don't see them in my setup for example).
Right now I will not be able to look into this though, I have come down with a quite nasty flu.

Merged!


docs: add ming-tsai profile

Which category your Pull Request in? (check all applicable)

[x] 🚀 Added new entry
[ ] 🐛 Grammatical Error
[ ] ➕ Tools Update
[ ] 🚩 Other

Add a simple description of why your code is in this section
Because this my profile doesn't have too much information
Add the profile link here
https://github.com/ming-tsai

Thanks @ming-tsai


C# get_word_string_list memory issue

When I run the C# tests with the compiled develop branch I get this error randomly, i.e. not all the time:
ctest -R "generated_csharp-features" --output-on-failure
Test project /Users/ghoben/shogun/build
    Start 286: generated_csharp-features-string
1/1 Test #286: generated_csharp-features-string ...***Failed    0.22 sec

Unhandled Exception:
System.OutOfMemoryException: Insufficient memory to continue the execution of the program.
  at (wrapper alloc) System.Object.AllocVector(intptr,intptr)
  at SGObject.get_word_string_list (System.String name) [0x0003a] in <d32aa6e2d1564724a8deaed48a8f2744>:0
  at Application.Main () [0x0005a] in <bacc226c5e6040c6a7e0df8bba430fe8>:0
[ERROR] FATAL UNHANDLED EXCEPTION: System.OutOfMemoryException: Insufficient memory to continue the execution of the program.
  at (wrapper alloc) System.Object.AllocVector(intptr,intptr)
  at SGObject.get_word_string_list (System.String name) [0x0003a] in <d32aa6e2d1564724a8deaed48a8f2744>:0
  at Application.Main () [0x0005a] in <bacc226c5e6040c6a7e0df8bba430fe8>:0

and sometimes this one:
ctest -R "generated_csharp-features" --output-on-failure
Test project /Users/ghoben/shogun/build
    Start 286: generated_csharp-features-string
1/1 Test #286: generated_csharp-features-string ...***Failed    0.16 sec
Stacktrace:

  at <unknown> <0xffffffff>
  at (wrapper managed-to-native) System.Runtime.InteropServices.Marshal.copy_from_unmanaged (intptr,int,System.Array,int) [0x00000] in <98fac219bd4e453693d76fda7bd96ab0>:0
  at System.Runtime.InteropServices.Marshal.Copy (intptr,int16[],int,int) [0x00000] in <98fac219bd4e453693d76fda7bd96ab0>:0
  at SGObject.get_word_string_list (string) [0x00062] in <d32aa6e2d1564724a8deaed48a8f2744>:0
  at Application.Main () [0x0005a] in <bacc226c5e6040c6a7e0df8bba430fe8>:0
  at (wrapper runtime-invoke) object.runtime_invoke_void (object,intptr,intptr,intptr) [0x0004c] in <98fac219bd4e453693d76fda7bd96ab0>:0

Unhandled Exception:
System.NullReferenceException: Object reference not set to an instance of an object
  at (wrapper managed-to-native) System.Runtime.InteropServices.Marshal.copy_from_unmanaged(intptr,int,System.Array,int)
  at System.Runtime.InteropServices.Marshal.Copy (System.IntPtr source, System.Int16[] destination, System.Int32 startIndex, System.Int32 length) [0x00000] in <98fac219bd4e453693d76fda7bd96ab0>:0
  at SGObject.get_word_string_list (System.String name) [0x00062] in <d32aa6e2d1564724a8deaed48a8f2744>:0
  at Application.Main () [0x0005a] in <bacc226c5e6040c6a7e0df8bba430fe8>:0
[ERROR] FATAL UNHANDLED EXCEPTION: System.NullReferenceException: Object reference not set to an instance of an object
  at (wrapper managed-to-native) System.Runtime.InteropServices.Marshal.copy_from_unmanaged(intptr,int,System.Array,int)
  at System.Runtime.InteropServices.Marshal.Copy (System.IntPtr source, System.Int16[] destination, System.Int32 startIndex, System.Int32 length) [0x00000] in <98fac219bd4e453693d76fda7bd96ab0>:0
  at SGObject.get_word_string_list (System.String name) [0x00062] in <d32aa6e2d1564724a8deaed48a8f2744>:0
  at Application.Main () [0x0005a] in <bacc226c5e6040c6a7e0df8bba430fe8>:0

In #4647 I get this error with the CI.
Does anyone know what is happening? The machine I am running this on is definitely not running low on memory, definitely not for a small string vector...
The issue seems to be caused by this line in the meta example, but I can't replicate in neither C++ or python:
https://github.com/shogun-toolbox/shogun/blob/ad8004c1032b87b96e48e109b683e5a53c351e36/examples/meta/src/features/string.sg#L12

The reason will be in the typemaps for csharp. I edited them recently .... can have a look


rte: move kni-specific packages to klog

it's just ugly to mix log and klog, and
we have no real reason to be stuck with log.
Signed-off-by: Francesco Romani<EMAIL_ADDRESS>

oo yee
/lgtm

We also have some here https://github.com/openshift-kni/numaresources-operator/blob/main/test/e2e/e2e_suite_test.go#L22

We also have some here https://github.com/openshift-kni/numaresources-operator/blob/main/test/e2e/e2e_suite_test.go#L22

thanks, updated

/lgtm


Investigate need for use of encoding for after/nextlink

We are currently encoding the nextlink used for pagination using a base64 encode. We need to investigate how client applications are processing this afterlink and confirm if we really need to be encoding this ourselves, or allowing the client application to handle such encodings.

The part of the nextLink that is encoded is intended to be opaque to the client. Clients should not do anything with the contents of the encoded piece of the nextLink besides provide it to DAB. This allows us to make non-breaking changes to the structure of the encoded bits without the user being affected.

Confirm Base64 encoding is URL compatible.

We need to investigate this because the url encoded nextLink or after clause no longer provides a valid base-64 encoded value. So, the link turns out to not be useful if it contains special characters. This was evident in the OpenAPI response as well.


OLED BOM header part verification request

The 4 pin OLED header link in the bom points to a part that looks different than the part used in the build guide.
Does the BOM link point to the correct part? If not, can you point me to the correct part?
Mouse part
Build guide image

That's a stock image on the Mouser site. They do that a lot to represent a family of product rather than put an image for each iteration. If you read the description, it's for single row, 4-position connector like it should be.

Thank you! I appreciate your patience - I learned something new.


update containerd/kubenet_template file with portmap plugin chain

addressed Azure/AKS#2070

addressed Azure/AKS#2070

@eriksywu I suggest we put a bit contexts for PRs like this for faster review and for future reference. we may need to config our repo to enforce some basic sanity rule for PR merging to remind us.

@eriksywu I suggest we put a bit contexts for PRs like this for faster review and for future reference. we may need to config our repo to enforce some basic sanity rule for PR merging to remind us.


Fixing typos in ACME provider getCertificateRenewDurations and test comments

What does this PR do?
Fixes typos in ACME provider getCertificateRenewDurations and test comments:

There are actually 365 days in a year
Renew period for 1 year certificates is actually 4 months (the test comment says 2)

Motivation
This aligns the code with the documentation
More

[x] Added/updated tests
[ ] Added/updated documentation

Additional Notes
First commit adds a test for 90d < certificateDuration  < 1y to highlight issue
Second commit actually fixes it to make the new and existing tests pass

Waiting for workflow approval before pushing code fix

Should I open separate PRs for v2.7 and master branches or will v2.6 be automatically merged into them ?

The PR will be backported, you don't need to open several PRs.


selectedItemComponent seems to do nothing

I have the following template code;
{{#form.element
  controlType="power-select-multiple"
  property="assets"
  options=availableAssets
  label='Select Assets'
  as |el|}}
  {{#el.control matcher=assetMatcher selectedItemComponent='test-component' as |asset|}}
    {{asset.assetId}}
  {{/el.control}}
{{/form.element}}

app/templates/components/test-component.hbs
{{log select}}
{{log option}}
{{log extra}}
{{select.name}}

When I select an item from the list, the trigger shows the assetId rather than name, and nothing is logged to console. Am I using it correctly? If so, I'll add a failing test...

Shoot, nevermind. Realised that's fixed in 1.0.0!


fixes gh-865

It checks first for matching ignored patterns and in this case it performs the forward as in the current version.
If the ignored patterns are not matched and the route is not found, the context is populated with error fields such that SendErrorFilter kicks in

@dsyer any objections? I've been through it and think it's ok.

Not 100% sure yet. Do we need getIgnoredRoutes() still?

That's how we disable the routes from DiscoveryClient.


Add sources to bst shell

See original issue on GitLab
In GitLab by [Gitlab user @knownexus] on May 30, 2018, 13:59
Background
We want to be able to run software debuggers & co when we run bst shell
Task description

[ ]  Modify bst shell to include the sources of all open workspaces in a given project
[ ]  Potentially add a flag to enable/disable the feature (undecided)

Steps

[ ]  Find the point were artifacts are added to the sandbox
[ ]  Get a list of all open workspaces
[ ]  Get the build-root for the elements of each workspace
[ ]  Recreate the full path of each workspace inside the sandbox

This is to allow existing debug logs and paths to find the right path
In the case of conflicting paths between workspaces, the shell will abort and instruct the user to close some/all of the conflicting workspaces

[ ]  Copy the contents of the workspaces into their corresponding directory
[ ]  Add tests to confirm that the files were copied into the sandbox

In GitLab by [Gitlab user @tlater] on May 30, 2018, 14:33
Note that most of this functionality is probably covered in Element.stage, as elements are staged into the correct build root by default. I suspect this may be as simple as calling that method on every workspaced element before opening the shell, instead of modifying the staging process.
The only complication is that elements need to be staged into the build directory that the relevant artifact was built in, and not what the element thinks it should be built in, since debugging data in the artifact may refer to the original build directory. Since this could change between builds, we need to store more metadata - if this is not already covered.
We should also consider what happens if multiple elements stage into the same build directory. I have no real proposal for this, I believe the only option is to deduplicate them with -n suffixes and hope this doesn't break debuggers (with adequate warnings).
Note also that this feature should under no circumstances trigger on normal builds - this is purely debugging functionality.
If this is up for discussion, I personally think enabling this by default would be better, since the user can then find this feature through exploration, and debuggers will work out-of-the-box in most cases. There are no real downsides to staging a couple of workspaces, either.

In GitLab by [Gitlab user @knownexus] on May 30, 2018, 15:03

We should also consider what happens if multiple elements stage into the same build directory. I have no real proposal for this, I believe the only option is to deduplicate them with -n suffixes and hope this doesn't break debuggers (with adequate warnings).

My recommendation would be that we abort, with a error message explaining why it failed and suggesting that, if they want to actually do this, they attempt to change the path of one of the listed elements that conflict

In GitLab by [Gitlab user @knownexus] on May 30, 2018, 15:04
However I think this would mean we can't have this enabled by default

In GitLab by [Gitlab user @tlater] on May 30, 2018, 15:18
[Gitlab user @knownexus] if we do abort, we should suggest that the user closes all but one of the workspaces attempting to write to the same directory, instead of suggesting to change the directory (usually changing the default here means that it is required for the build to function, so the user simply could not use buildstream if we'd ask them to do that).
Otherwise, aborting seems like a fine solution. The advantage of deduplication is that the user could still ask their debugger to search in the correct directory, but I understand that this is not quite as intuitive. In either case, this should be an exceptionally rare use case, so I don't have a strong opinion.

In GitLab by [Gitlab user @knownexus] on May 30, 2018, 15:24
Ok, in which case, i'll continue with the idea of abort and instruct the user to close some of the conflicting workspaces, and if it comes up as a problem/request later on, the deduplication functionality can be reconsidered

In GitLab by [Gitlab user @knownexus] on May 30, 2018, 15:26
changed the description

In GitLab by [Gitlab user @knownexus] on Jun 8, 2018, 13:02
changed the description

In GitLab by [Gitlab user @knownexus] on Jun 8, 2018, 13:02
marked the task Find the point were artifacts are added to the sandbox as completed

In GitLab by [Gitlab user @knownexus] on Jun 8, 2018, 13:03
marked the task Get a list of all open workspaces as completed

In GitLab by [Gitlab user @knownexus] on Jun 8, 2018, 13:03
marked the task Recreate the full path of each workspace inside the sandbox as completed

In GitLab by [Gitlab user @knownexus] on Jun 8, 2018, 13:03
marked the task Copy the contents of the workspaces into their corresponding directory as completed

In GitLab by [Gitlab user @knownexus] on Jun 8, 2018, 13:03
marked the task Copy the contents of the workspaces into their corresponding directory as incomplete

In GitLab by [Gitlab user @knownexus] on Jun 8, 2018, 13:03
marked the task Recreate the full path of each workspace inside the sandbox as incomplete

In GitLab by [Gitlab user @knownexus] on Jun 8, 2018, 14:41
marked the task Get the build-root for the elements of each workspace as completed

In GitLab by [Gitlab user @knownexus] on Jun 8, 2018, 14:41
marked the task Recreate the full path of each workspace inside the sandbox as completed

In GitLab by [Gitlab user @knownexus] on Jun 8, 2018, 14:41
marked the task Copy the contents of the workspaces into their corresponding directory as completed

In GitLab by [Gitlab user @knownexus] on Jun 11, 2018, 16:02
[Gitlab user @tristanvb] Thoughts on this plan?

In GitLab by [Gitlab user @tristanvb] on Jun 19, 2018, 17:41

I think workspaces are mounted, not copied; if we were to have workspace presence in the shell environment, would this be any different ?
Should we mount the build directories read-write in the sandbox ?
This should also use cached build trees once they are implemented right ? How is this specific to workspaces ?

Is this issue just to handle the staging of build trees in bst shell where the edge case is that a dependency has an open workspace ?
Do we really know that mounting the workspaced dependency's workspace into bst shell is more correct than staging an existing build tree ?

Looks like there are a lot of choices to make, and we have to be careful not to expose too many options around this making things needlessly confusing:

Which build directory is added to bst shell, the workspace or the cached built tree ?
When staging the cached build trees of dependencies, the user will need to decide somewhere that it's time to download all these build trees, or to not bother with the exorbitant gigabytes of download and make due without the staged build trees.

Does the user get the option somehow to rebuild something locally, so as to avoid downloading a build tree artifact ? (I guess not)

When a workspace exists on a dependency, does choosing the workspace depend on whether we have a cached build tree or not ?

I presume that if workspaces are used at all here; they are secondary to cached build trees; which are a much more certain representation of what was in the build tree at the time the artifact output was produced.

My recommendation would be that we abort, with a error message explaining why it failed and suggesting that, if they want to actually do this, they attempt to change the path of one of the listed elements that conflict

For the case where multiple elements stage in the same dir, we could also handle this in the same way we handle overlap warning/errors.

In GitLab by [Gitlab user @knownexus] on Jul 4, 2018, 12:14
This issue is currently being blocked by #455 and !474

In GitLab by [Gitlab user @knownexus] on Jul 4, 2018, 12:14
This issue is currently being blocked by #455 and !474

In GitLab by [Gitlab user @LaurenceUrhegyi] on Jul 4, 2018, 18:02
Moving back to ToDo and un-assigning

In GitLab by [Gitlab user @knownexus] on Jul 18, 2018, 11:18
unassigned [Gitlab user @knownexus]

In GitLab by [Gitlab user @knownexus] on Aug 7, 2018, 13:18
marked the task Copy the contents of the workspaces into their corresponding directory as incomplete

In GitLab by [Gitlab user @knownexus] on Aug 7, 2018, 13:18
marked the task Recreate the full path of each workspace inside the sandbox as incomplete

In GitLab by [Gitlab user @knownexus] on Aug 7, 2018, 13:18
marked the task Get the build-root for the elements of each workspace as incomplete

In GitLab by [Gitlab user @knownexus] on Aug 7, 2018, 13:18
marked the task Get a list of all open workspaces as incomplete

In GitLab by [Gitlab user @knownexus] on Aug 7, 2018, 13:18
marked the task Get the build-root for the elements of each workspace as completed

In GitLab by [Gitlab user @knownexus] on Aug 7, 2018, 13:18
marked the task Find the point were artifacts are added to the sandbox as incomplete

In GitLab by [Gitlab user @knownexus] on Aug 7, 2018, 13:19
marked the task Find the point were artifacts are added to the sandbox as completed

In GitLab by [Gitlab user @knownexus] on Aug 7, 2018, 13:19
marked the task Get the build-root for the elements of each workspace as incomplete

In GitLab by [Gitlab user @knownexus] on Aug 7, 2018, 13:19
marked the task Find the point were artifacts are added to the sandbox as incomplete

In GitLab by [Gitlab user @tpollard] on Aug 8, 2018, 17:01
'Add sources to bst shell'
If you've built (or attempted to) $element & then you open a workspace for $element, then do 'bst shell --build $element' you'll be given a shell in which the source from the workspace is there (can test via file modification). This behaviour is also tested in integration/shell.py test_workspace_visible() & the same goes for mounting the sysroot into the shell. Am I missing something here?

In GitLab by [Gitlab user @tpollard] on Aug 8, 2018, 17:23
changed the description

In GitLab by [Gitlab user @sstriker] on Aug 9, 2018, 13:31
[Gitlab user @tpollard] the point is that any workspaces that are open for dependencies of the element, are not visible in the shell.

In GitLab by [Gitlab user @tristanvb] on Aug 10, 2018, 06:20
I should point out that, while it may make sense (depending) to bind mount the target workspace while shelling into a build environment for that target, it does not make sense to me that we should bind mount all workspaces for the dependency elements.
Keep in mind that this feature is intended to improve debugging of a given build, and providing the source code for everything is a part of that, so that debuggers have access to the sources.
A workspace is outside of our control, and may have changed since the given build you want to debug occurred, as such you want the state of the workspace at the time the build was performed.
It does of course stand to reason that especially with bst shell --build, you will certainly want to bind mount the workspace of the target you are debugging the build of. If the element is already built and you are launching a runtime shell of an already built artifact, again I don't think you want to bind mount the workspace in that shell.
What makes most sense to me, is to use the cached build tree for all dependencies, regardless of whether those elements had open workspaces or not - with the only exception being a bind mount of the workspace of the target, when the invocation is a bst shell --build invocation.
Some history / notes
I should note that we already behave properly for the case of debugging a failed build with either the bst shell --sysroot option, or from the interactive prompt.
Since d46fbbcbfec7f44cfa3d412b70000eff633b85bb (a fix for regression #346), we are making a copy of the workspace state at the time of failure, ensuring that we are debugging exactly what failed and not the arbitrary workspace state when later debugging the failed build.
Additionally I will note that this functionality should be replaced with the new build tree caching mechanism, this should be done implicitly while ensuring we only have one codepath to debug a failed build, which is an objective outlined in #539.

In GitLab by [Gitlab user @tristanvb] on Aug 22, 2018, 12:03
marked this issue as related to #432

In GitLab by [Gitlab user @bethwhite] on Sep 3, 2018, 13:51
Addressed in the workspaces proposal on the mailing list here

In GitLab by [Gitlab user @tristanvb] on Nov 5, 2020, 07:06
marked this issue as related to #964

This is somewhat related to #422


Windows EPERM: Warn and don't bail on failed cleanup

We've observed errors like:
Error: EPERM: operation not permitted, unlink 'C:\BuildAgent\temp\buildTmp\appcenter-upload118115-6800-1ohlguf.j77hk\AndroidTestServer.apk'

particularly on Windows.
This should not cause the CLI to exit, but rather it should issue a warning.

@owenniblock can you help me test this on windows?

@krukow - sure. Do you have a surefire way of replicating? I would guess we can open one of the files that'll get cleaned up so it gets blocked.

@owenniblock I don't - I was leaning on you to help :)

No problem - let me fire up the Windows machine and see if I can replicate on the current CLI.

OK - I can replicate this by locking one of the .dll files as read only before the test completes.
I think we need to make a slight tweak to the message (we say Error way too much!) Maybe we should change it so that the description and help test comes before the error message which is a bit nonsensical?
Here's the error before this PR:

Error: EPERM: operation not permitted, unlink 'C:\Users\ADMINI~1\AppData\Local\Temp\appcenter-upload11828-9124-cy0d4h.jrn48\Xamarin.UITest.dll'
Error: There were Test Failures.

Here it is after:

Error Error: EPERM: operation not permitted, unlink 'C:\Users\ADMINI~1\AppData\Local\Temp\appcenter-upload11828-4712-1498xu0.w4cy\Xamarin.UITest.dll' while cleaning up artifacts directory C:\Users\ADMINI~1\AppData\Local\Temp\appcenter-upload11828-4712-1498xu0.w4cy. This is often due to files being locked or in use. Please check your virus scan settings and any local security policies you might have in place for this directory. Continuing without cleanup.
Error: There were Test Failures.

@owenniblock Error: There were Test Failures.is this preventing the test run/scheduling? it shouldn't

Number of times we say Error addressed

Great - adding @christav for final review and ideally merge

Merging: cc @christav FYI


Pull kong/kong, Dockerfile RUN command ERROR

when pull kong/kong, I got this problem, and I don't know how to locate the problem and solve it
Step 13/18 : RUN make dependencies
 ---> Running in 235588261d86
make: *** No rule to make target 'dependencies'.  Stop.
The command '/bin/sh -c make dependencies' returned a non-zero code: 2
[pongo-ERROR] Error: failed to build test environment

so I delete this command, and i can not run a test, but a can use kong-pongo shell

Please provide some more information. Can you provide reproduction steps?

And at least a bigger log (snippet).

Please provide some more information. Can you provide reproduction steps?

I just run the demo from kong-pongo README
 [nickduan@ ~/kong-staff/kong-plugin] KONG_VERSION=2.0.4 ~/.local/bin/pongo run -v -o gtest ./spec
[pongo-INFO] image 'kong-pongo-test:2.0.4' not found, auto-building it
Sending build context to Docker daemon  24.51MB
Step 1/18 : ARG KONG_BASE
Step 2/18 : FROM ${KONG_BASE}
 ---> 7a800e1cef72
Step 3/18 : ARG KONG_DEV_FILES
 ---> Using cache
COPY assets/test_plugin_entrypoint.sh /kong/bin/test_plugin_entrypoint.sh
 ---> 42a7d4aab6ed
Step 4/18 : COPY $KONG_DEV_FILES /kong
 ---> Using cache
 ---> 4d2ae21b8dba
Step 5/18 : COPY assets/busted_helper.lua /kong/bin
 ---> Using cache
 ---> 161d6d1e7c44
Step 6/18 : COPY assets/test_plugin_entrypoint.sh /kong/bin/test_plugin_entrypoint.sh
 ---> Using cache
 ---> 0ebd006a1749
Step 7/18 : COPY assets/pongo_pack /kong/bin/pongo_pack
 ---> Using cache
 ---> d2d436478083
Step 8/18 : USER root
 ---> Using cache
 ---> c4260a866e33
Step 9/18 : RUN apk update
 ---> Using cache
 ---> 440f8e93cf62
Step 10/18 : RUN apk add zip unzip make g++ py-pip jq git bsd-compat-headers m4 openssl-dev curl
 ---> Using cache
 ---> cfe17a925e1c
Step 11/18 : RUN pip install 'httpie<2.0.0'
 ---> Using cache
 ---> ceb259cf4233
Step 12/18 : RUN cd /kong
 ---> Using cache
 ---> 5ca97fdac909
Step 13/18 : RUN make dependencies
 ---> Running in 2f50888e8685
make: *** No rule to make target 'dependencies'.  Stop.
The command '/bin/sh -c make dependencies' returned a non-zero code: 2
[pongo-ERROR] Error: failed to build test environment

this is all log, If there are other logs that I have ignored, please tell me where and how to get them.

the 2.0.4 version does have a dependencies target; https://github.com/Kong/kong-pongo/blob/master/kong-versions/2.0.4/kong/Makefile#L71

thanks, I changed the version to 2.0.4 just fine. now i use this version.


Video stream coming in with green/blue tint in Unity 2019.3.7f1

Just did some testing back and forth with this and the AvPro Decklink plugin, and found that the quality was higher using this code. Unfortunately when using it in 2019.3.7 version of Unity (with HDRP) the video was coming in tinted blue/green. Of course I had to update the way that the RenderPipelineManager was calling beginCameraRendering to work with newer versions of HDRP, but after that I am facing this issue. Any insights would be incredible. 👍
Avpro:

Klinker on Standard Pipeline:

Klinker on HDRP in newer Unity editors:

Same issue by me. I am also wondering if it is compatible with DX12 with the HDRP + DXR? Do you know something about it?

Hello,
it looks like it's all about gamma color space.
Need some adjustments for linear version. I think it should work:
`half4 uyvy = tex2D(_MainTex, uv);
uyvy = LinearToGamma1(uyvy);
..
half4 LinearToGamma(half4 col)
{
if (col.r <= 0.0031308)
col.r = col.r * 12.92;
else
col.r = 1.055 * pow(col.r, 0.4166667) - 0.055;
if (col.g <= 0.0031308)
    col.g = col.g * 12.92;
else
    col.g = 1.055 * pow(col.g, 0.4166667) - 0.055;

if (col.b <= 0.0031308)
    col.b = col.b * 12.92;
else
    col.b = 1.055 * pow(col.b, 0.4166667) - 0.055;

col.a = col.a;

return col;

}`


Linking the purchase with the user

The problem is I am using my own authentication system for my app so how do I link the purchase with the user.I tried to give developerIdAndroid and accountIdAndroid as parameters to requestPurchase function but I don't see those 2 parameters are liked with the purchase object from purchaseUpdateListener.

If you do server validation, you could pass the purchase token along with the user information to your server and store it linked in the database.

I'm using react-native-iaphub which does the receipt validation for you, it's easy to link with the user, you just have to provide an user id.

@nochkin thanks for the reply,I am doing server validation but how do you pass user information and there is one problem that I am facing, lets suppose a user has two accounts and lets suppose that user has purchased something from A account and lets suppose that purchase takes time to complete then in the mean time the user login's into his B account then if the purchase got completed at that time then the B account gets credited.
This can be solved only when we pass some id of the user while running requestPurchase function and that user id should be in purchase object so by this even if the user login's into another account we can validate.

I'm using react-native-iaphub which does the receipt validation for you, it's easy to link with the user, you just have to provide an user id.

@tomerdev thanks for the reply, I will check that out

@mohammedavez
If you do server validation, then you pass userid with the receipt together. Your server would link the purchase with that userid on the server side.
Does not matter if a user will re-login or even logout after the fact since the validation is done on the server side anyway.


[BUG] engine-image-ei cp: cannot create regular file '/data/longhorn': Text file busy

Describe the bug
Longhorn Backup target not resolv over CoreDNS host aliases in cluster
To Reproduce
Steps to reproduce the behavior:

Go to 'System project and click eclipse engine-image-ei click Edit'
Click on 'on Show advanced options and select Networking click Host Aliases (/etc/hosts entries)
and add host aliases in interface'
Perform 'Click Save'
See error in logs engine-image-ei
Expected behavior
A clear and concise description of what you expected to happen.

Log
cp: cannot create regular file '/data/longhorn': Text file busy
Environment:

Longhorn version: 0.8
Kubernetes version: 1.17.3
Node OS type and version: VM RHEL 7.6

Additional context
Longhorn Backup target not resolv over CoreDNS alliases in cluster

after reboot all nodes in cluster and problem resolved, but you still can’t determine the target for backup which is not in the DNS -
error listing backups: error listing backup volumes: Failed to execute: /var/lib/longhorn/engine-binaries/longhornio-longhorn-engine-v0.8.0/longhorn [backup ls --volume-only s3://longhorn@us-west-2/], output AWS Error: RequestError send request failed Get https://www.xxx/longhorn?delimiter=%!F(MISSING)&prefix=%!F(MISSING): dial tcp: lookup www.xxx on <IP_ADDRESS>:53: no such host , stderr, time="2020-03-24T16:16:41Z" level=error msg="{\n\n}" pkg=s3 time="2020-03-24T16:16:41Z" level=error msg="Fail to list s3: AWS Error: RequestError send request failed Get https://www.xxx/longhorn?delimiter=%!F(MISSING)&prefix=%!F(MISSING): dial tcp: lookup www.xxx on <IP_ADDRESS>:53: no such host\n" pkg=s3 time="2020-03-24T16:16:41Z" level=error msg="AWS Error: RequestError send request failed Get https://www.xxx/longhorn?delimiter=%!F(MISSING)&prefix=%!F(MISSING): dial tcp: lookup www.xxx on <IP_ADDRESS>:53: no such host\n" , error exit status 1

+1
0.8.0 on k8s 1.17.4 (Rancher 2.3.4) on prem. engine-image-ei-$ID was redeployed with the same error. Cluster reboot fixes the problem but if engine-image pod is re-deployed after - same problem appears. Seems like race condition/locking/whatever on accessing /var/lib/longhorn/engine-binaries/longhornio-longhorn-engine-v0.8.0 contents on host.

#1116

The container with the engine does not have bash, and when you try to change the /etc/hosts, it crashes, after which the binary engine file in the file system host node is blocked, which is indicated in the commands that are executed when the container is expanded. For example, I wanted to change the hosts file since in UI interface and I do not have dns, but I need a valid certificate for backup to S3 longhorn.

For the engine image error cp: cannot create regular file '/data/longhorn': Text file busy, we will track it in #1116.
It seems that the reproduce step you mentioned above is mainly about the engine image error. Can you provide a more concrete way to reproduce the DNS/backup target issue? Since I haven't used the CoreNDS, it would be nice if you can point out the key configurations/operation when you use CoreDNS to reproduce the issue.

setup custom DNS name in /etc/hosts CoreDNS workload in kube-system (default install Rancher 2.4.2) namespace and longhorn backup target not resolved in this name S3. What's Longhorn describe DNS info?


ci: pass OVSX_PAT to release command

I think I missed this when configuring initially, will make sure the latest release is uploaded to Open VSX

very nice! Thanks for that. Now I don't need to do it by hand :smile:


headers propagation

For some reason, I can't propagate headers to my subgraph. I specifically want to propagate the Authorization header to the subgraph
headers:
  all:
    request:
      - op: "propagate"
        named: Authorization
      - op: "propagate"
        matching:  .*

From the documentation, the above code should work.
My router is currently deployed using a Dockerfile:
FROM ghcr.io/wundergraph/cosmo/router:latest

WORKDIR /

COPY config.yaml ./

EXPOSE 3002

Hi @oerhahon, thank you for opening an issue. We'll take a look. A few questions upfront.
Could you share your demo request (curl syntax)?
How did you verify that the header wasn't passed?
Please also use a fixed docker tag instead of latest. You might use a version that doesn't support it.

Hi @StarpTech , thanks for looking into this. I didn't deploy one of your demos, I'm testing from my project that was migrated from Apollo GraphOS.
I'm using Postman and setting only the Authorization header. The request header looks like:
{
        POST /graphql HTTP/1.1
        Authorization: Bearer token
        Content-Type: application/json
        User-Agent: PostmanRuntime/7.33.0
        Accept: */*
        Postman-Token: cc41ecb7-f156-4df3-bebe-95d9d2dc705c
        Host: self-hosted-router-url
        Accept-Encoding: gzip, deflate, br
        Connection: keep-alive
        Content-Length: 1774
}

in the subgraph, I'm printing out the request header:
{
	content-length: "48"
	x-forwarded-proto: "https"
	accept-encoding: "gzip"
	content-type: "application/json"
	accept: "application/json"
	host: "subgraph-url"
	traceparent: "00-24a7e89f331699c9b39904ed4a1ea82d-5350c92aacbd1e1d-01"
	user-agent: "Go-http-client/2.0"
	x-cloud-trace-context: "24a7e89f331699c9b39904ed4a1ea82d/6003519488408755741;o=1"
	forwarded: "for="[2600:1900:2000:e9::1:f00]";proto=https"
	x-forwarded-for: "2600:1900:2000:e9::1:f00"
}

since there is no Authorization tag, authenticated requests fail.

Hi @oerhahon we've found it. It's a regression. Should be fixed in the release. Should be done by today.


readme needs updating

in Language section, "0=" should be "0#" with reversed behaviour.

Hey, sorry that I completely ignored this repo for over a month but thank you very much for that catch, fixed!

Hey, sorry that I completely ignored this repo for over a month but thank you very much for that catch, fixed!

It's all good. :-)
I thank you.
On Tue, 27 Feb 2024 at 19:04, fuzzballcat @.***> wrote:

Hey, sorry that I completely ignored this repo for over a month but thank
you very much for that catch, fixed!
—
Reply to this email directly, view it on GitHub
https://github.com/fuzzballcat/milliForth/issues/16#issuecomment-1968106465,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABWSFMYLOC4BBNVRLEA52U3YV2NE7AVCNFSM6AAAAABBY24YSKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNRYGEYDMNBWGU
.
You are receiving this because you authored the thread.Message ID:
@.***>

Ha, it's actually 328 bytes now, beating SectorLisp by 108 bytes.
On Tue, 27 Feb 2024 at 20:33, Peter Ferrie @.***> wrote:

It's all good. :-)
I thank you.
On Tue, 27 Feb 2024 at 19:04, fuzzballcat @.***>
wrote:

Hey, sorry that I completely ignored this repo for over a month but thank
you very much for that catch, fixed!
—
Reply to this email directly, view it on GitHub
https://github.com/fuzzballcat/milliForth/issues/16#issuecomment-1968106465,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABWSFMYLOC4BBNVRLEA52U3YV2NE7AVCNFSM6AAAAABBY24YSKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNRYGEYDMNBWGU
.
You are receiving this because you authored the thread.Message ID:
@.***>


[MM-43656] Flush cookies to disk on finishing custom login

Summary
OneLogin's 'Remember me' feature wasn't working, and I think the issue was that we weren't saving cookies to disk until after the user blurs the app (or closes it).
Ticket Link
https://mattermost.atlassian.net/browse/MM-43656
Fixed an issue where OneLogin users wouldn't have their credentials remembered.

Building app in separate branch.

Successfully building:
https://circleci.com/gh/mattermost/desktop/19512
https://circleci.com/gh/mattermost/desktop/19511
https://circleci.com/gh/mattermost/desktop/19510

Artifact links:
https://output.circle-artifacts.com/output/job/3dc3c354-e663-47ca-bb12-43c5df0bb1c5/artifacts/0/tmp/artifacts/mattermost-desktop-5.1.0-develop.1-mac-arm64.dmg
https://output.circle-artifacts.com/output/job/3dc3c354-e663-47ca-bb12-43c5df0bb1c5/artifacts/0/tmp/artifacts/mattermost-desktop-5.1.0-develop.1-mac-x64.dmg
https://output.circle-artifacts.com/output/job/2de424a3-ed3b-4269-9122-90a1d8213bb8/artifacts/0/tmp/artifacts/mattermost-desktop-setup-5.1.0-develop.1-win.exe
https://output.circle-artifacts.com/output/job/0b48ec72-afe2-4ea4-8c10-4d38f629e07e/artifacts/0/tmp/artifacts/mattermost-desktop-5.1.0-develop.1-linux-ia32.tar.gz
https://output.circle-artifacts.com/output/job/0b48ec72-afe2-4ea4-8c10-4d38f629e07e/artifacts/0/tmp/artifacts/mattermost-desktop-5.1.0-develop.1-linux-x64.tar.gz

@devinbinnie Is this planned for v5.1, or do we remove the milestone from the ticket/PR?

@amyblais It can wait until the next release, it's not super urgent.

/update-branch

Building app in separate branch.

Successfully building:
https://circleci.com/gh/mattermost/desktop/27897
https://circleci.com/gh/mattermost/desktop/27896
https://circleci.com/gh/mattermost/desktop/27895

Artifact links:
https://output.circle-artifacts.com/output/job/ed120963-fcad-4fc3-bbcd-5eccc026d420/artifacts/0/tmp/artifacts/mattermost-desktop-5.3.0-develop.1-mac-m1.dmg
https://output.circle-artifacts.com/output/job/ed120963-fcad-4fc3-bbcd-5eccc026d420/artifacts/0/tmp/artifacts/mattermost-desktop-5.3.0-develop.1-mac-x64.dmg
https://output.circle-artifacts.com/output/job/e69b8de5-4ec9-47e2-a2ca-8060ba9dcf36/artifacts/0/tmp/artifacts/mattermost-desktop-5.3.0-develop.1-win-arm64.zip
https://output.circle-artifacts.com/output/job/e69b8de5-4ec9-47e2-a2ca-8060ba9dcf36/artifacts/0/tmp/artifacts/mattermost-desktop-5.3.0-develop.1-win-ia32.zip
https://output.circle-artifacts.com/output/job/e69b8de5-4ec9-47e2-a2ca-8060ba9dcf36/artifacts/0/tmp/artifacts/mattermost-desktop-5.3.0-develop.1-win-x64.zip
https://output.circle-artifacts.com/output/job/5fa0ecaa-1319-4a88-bfc7-34c9ec25aa5a/artifacts/0/tmp/artifacts/mattermost-desktop-5.3.0-develop.1-linux-arm64.tar.gz
https://output.circle-artifacts.com/output/job/5fa0ecaa-1319-4a88-bfc7-34c9ec25aa5a/artifacts/0/tmp/artifacts/mattermost-desktop-5.3.0-develop.1-linux-x64.tar.gz

Thanks @devinbinnie
Tested on macOS - works great, I didn't know I needed this 🙂
On Win 10 - At login, app opens on Playbooks each time. Not on Playbooks tab, Channels tab in focus with Playbooks product shown on product switcher.
Haven't checked Ubunto yet, that's next - will comment shortly

Thanks @devinbinnie Tested on macOS - works great, I didn't know I needed this 🙂 On Win 10 - At login, app opens on Playbooks each time. Not on Playbooks tab, Channels tab in focus with Playbooks product shown on product switcher. Haven't checked Ubunto yet, that's next - will comment shortly

Looks like a separate issue. If you are able to reproduce can you file a ticket for us and we'll have a look? :)
As long as the usernames are being remembered correctly we should be okay to approve this :)


Add maven-wrapper

I've added maven-wraper as I've noticed it is used by other spring-cloud projects

Have you signed the CLA?

Yes,<PHONE_NUMBER>04101240

Merged via e5aa9e641f6ef6d508bbc5fc04d107c6b1e557c2