When installing zipline fresh, we can't run any backtests until treasury data is downloaded.  The fed site seems to be broken at the moment, and I have no idea how long it'll be until it's fixed.

What happened instead?
Currently I'm getting this error:

---------------------------------------------------------------------------
ValueError                                Traceback (most recent call last)
<ipython-input-14-71017434b077> in <module>
----> 1 get_ipython().run_cell_magic('zipline', '--bundle=csvdir --start 1999-3-10 --end 2019-2-12  --capital-base 10000 -o buy_tqqq.pk', "from zipline.api import symbol, order, record, order_target_percent, order_target\n\ndef initialize(context):\n    context.i = 0\n\ndef handle_data(context, data):\n    context.i += 1\n    if context.i == 1:\n        order_target_percent(symbol('TQQQ'), 1)\n    \n    record(TQQQ=data[symbol('TQQQ')].price)\n")

~/anaconda3/lib/python3.6/site-packages/IPython/core/interactiveshell.py in run_cell_magic(self, magic_name, line, cell)
   2321             magic_arg_s = self.var_expand(line, stack_depth)
   2322             with self.builtin_trap:
-> 2323                 result = fn(magic_arg_s, cell)
   2324             return result
   2325

~/anaconda3/lib/python3.6/site-packages/zipline/__main__.py in zipline_magic(line, cell)
    309             '%s%%zipline' % ((cell or '') and '%'),
    310             # don't use system exit and propogate errors to the caller
--> 311             standalone_mode=False,
    312         )
    313     except SystemExit as e:

~/anaconda3/lib/python3.6/site-packages/click/core.py in main(self, args, prog_name, complete_var, standalone_mode, **extra)
    715             try:
    716                 with self.make_context(prog_name, args, **extra) as ctx:
--> 717                     rv = self.invoke(ctx)
    718                     if not standalone_mode:
    719                         return rv

~/anaconda3/lib/python3.6/site-packages/click/core.py in invoke(self, ctx)
    954         _maybe_show_deprecated_notice(self)
    955         if self.callback is not None:
--> 956             return ctx.invoke(self.callback, **ctx.params)
    957
    958

~/anaconda3/lib/python3.6/site-packages/click/core.py in invoke(*args, **kwargs)
    553         with augment_usage_errors(self):
    554             with ctx:
--> 555                 return callback(*args, **kwargs)
    556
    557     def forward(*args, **kwargs):

~/anaconda3/lib/python3.6/site-packages/click/decorators.py in new_func(*args, **kwargs)
     15     """
     16     def new_func(*args, **kwargs):
---> 17         return f(get_current_context(), *args, **kwargs)
     18     return update_wrapper(new_func, f)
     19

~/anaconda3/lib/python3.6/site-packages/zipline/__main__.py in run(ctx, algofile, algotext, define, data_frequency, capital_base, bundle, bundle_timestamp, start, end, output, trading_calendar, print_algo, metrics_set, local_namespace, blotter)
    274         local_namespace=local_namespace,
    275         environ=os.environ,
--> 276         blotter=blotter,
    277     )
    278

~/anaconda3/lib/python3.6/site-packages/zipline/utils/run_algo.py in _run(handle_data, initialize, before_trading_start, analyze, algofile, algotext, defines, data_frequency, capital_base, data, bundle, bundle_timestamp, start, end, output, trading_calendar, print_algo, metrics_set, local_namespace, environ, blotter)
    157             trading_calendar=trading_calendar,
    158             trading_day=trading_calendar.day,
--> 159             trading_days=trading_calendar.schedule[start:end].index,
    160         )
    161         first_trading_day =\

~/anaconda3/lib/python3.6/site-packages/zipline/finance/trading.py in __init__(self, load, bm_symbol, exchange_tz, trading_calendar, trading_day, trading_days, asset_db_path, future_chain_predicates, environ)
    101             trading_day,
    102             trading_days,
--> 103             self.bm_symbol,
    104         )
    105

~/anaconda3/lib/python3.6/site-packages/zipline/data/loader.py in load_market_data(trading_day, trading_days, bm_symbol, environ)
    154         last_date,
    155         now,
--> 156         environ,
    157     )
    158

~/anaconda3/lib/python3.6/site-packages/zipline/data/loader.py in ensure_treasury_data(symbol, first_date, last_date, now, environ)
    278
    279     try:
--> 280         data = loader_module.get_treasury_data(first_date, last_date)
    281         data.to_csv(get_data_filepath(filename, environ))
    282     except (OSError, IOError, HTTPError):

~/anaconda3/lib/python3.6/site-packages/zipline/data/treasuries.py in get_treasury_data(start_date, end_date)
     74         parse_dates=['Time Period'],
     75         na_values=['ND'],  # Presumably this stands for "No Data".
---> 76         index_col=0,
     77     ).loc[
     78         start_date:end_date

~/anaconda3/lib/python3.6/site-packages/pandas/io/parsers.py in parser_f(filepath_or_buffer, sep, delimiter, header, names, index_col, usecols, squeeze, prefix, mangle_dupe_cols, dtype, engine, converters, true_values, false_values, skipinitialspace, skiprows, nrows, na_values, keep_default_na, na_filter, verbose, skip_blank_lines, parse_dates, infer_datetime_format, keep_date_col, date_parser, dayfirst, iterator, chunksize, compression, thousands, decimal, lineterminator, quotechar, quoting, escapechar, comment, encoding, dialect, tupleize_cols, error_bad_lines, warn_bad_lines, skipfooter, skip_footer, doublequote, delim_whitespace, as_recarray, compact_ints, use_unsigned, low_memory, buffer_lines, memory_map, float_precision)
    707                     skip_blank_lines=skip_blank_lines)
    708
--> 709         return _read(filepath_or_buffer, kwds)
    710
    711     parser_f.__name__ = name

~/anaconda3/lib/python3.6/site-packages/pandas/io/parsers.py in _read(filepath_or_buffer, kwds)
    447
    448     # Create the parser.
--> 449     parser = TextFileReader(filepath_or_buffer, **kwds)
    450
    451     if chunksize or iterator:

~/anaconda3/lib/python3.6/site-packages/pandas/io/parsers.py in __init__(self, f, engine, **kwds)
    816             self.options['has_index_names'] = kwds['has_index_names']
    817
--> 818         self._make_engine(self.engine)
    819
    820     def close(self):

~/anaconda3/lib/python3.6/site-packages/pandas/io/parsers.py in _make_engine(self, engine)
   1047     def _make_engine(self, engine='c'):
   1048         if engine == 'c':
-> 1049             self._engine = CParserWrapper(self.f, **self.options)
   1050         else:
   1051             if engine == 'python':

~/anaconda3/lib/python3.6/site-packages/pandas/io/parsers.py in __init__(self, src, **kwds)
   1747                 raise ValueError("Usecols do not match names.")
   1748
-> 1749         self._set_noconvert_columns()
   1750
   1751         self.orig_names = self.names

~/anaconda3/lib/python3.6/site-packages/pandas/io/parsers.py in _set_noconvert_columns(self)
   1815                         _set(k)
   1816                 else:
-> 1817                     _set(val)
   1818
   1819         elif isinstance(self.parse_dates, dict):

~/anaconda3/lib/python3.6/site-packages/pandas/io/parsers.py in _set(x)
   1805
   1806             if not is_integer(x):
-> 1807                 x = names.index(x)
   1808
   1809             self._reader.set_noconvert(x)

ValueError: 'Time Period' is not in list

Then, I added the ValueError to the try: except block in zipline/data/treasuries.py .  After that it came up with this error:
---------------------------------------------------------------------------
AttributeError                            Traceback (most recent call last)
<ipython-input-13-f5965e4de699> in <module>
----> 1 get_ipython().run_cell_magic('zipline', '--bundle=quandl --start 1999-3-10 --end 2018-10-12  --capital-base 10000', "from zipline.api import symbol, order, record, order_target_percent, order_target\n\ndef initialize(context):\n    context.i = 0\n\ndef handle_data(context, data):\n    context.i += 1\n    if context.i == 1:\n        order_target_percent(symbol('AAPL'), 1)\n    \n    record(AAPL=data[symbol('AAPL')].price)\n")

~/anaconda3/lib/python3.6/site-packages/IPython/core/interactiveshell.py in run_cell_magic(self, magic_name, line, cell)
   2321             magic_arg_s = self.var_expand(line, stack_depth)
   2322             with self.builtin_trap:
-> 2323                 result = fn(magic_arg_s, cell)
   2324             return result
   2325

~/anaconda3/lib/python3.6/site-packages/zipline/__main__.py in zipline_magic(line, cell)
    309             '%s%%zipline' % ((cell or '') and '%'),
    310             # don't use system exit and propogate errors to the caller
--> 311             standalone_mode=False,
    312         )
    313     except SystemExit as e:

~/anaconda3/lib/python3.6/site-packages/click/core.py in main(self, args, prog_name, complete_var, standalone_mode, **extra)
    715             try:
    716                 with self.make_context(prog_name, args, **extra) as ctx:
--> 717                     rv = self.invoke(ctx)
    718                     if not standalone_mode:
    719                         return rv

~/anaconda3/lib/python3.6/site-packages/click/core.py in invoke(self, ctx)
    954         _maybe_show_deprecated_notice(self)
    955         if self.callback is not None:
--> 956             return ctx.invoke(self.callback, **ctx.params)
    957
    958

~/anaconda3/lib/python3.6/site-packages/click/core.py in invoke(*args, **kwargs)
    553         with augment_usage_errors(self):
    554             with ctx:
--> 555                 return callback(*args, **kwargs)
    556
    557     def forward(*args, **kwargs):

~/anaconda3/lib/python3.6/site-packages/click/decorators.py in new_func(*args, **kwargs)
     15     """
     16     def new_func(*args, **kwargs):
---> 17         return f(get_current_context(), *args, **kwargs)
     18     return update_wrapper(new_func, f)
     19

~/anaconda3/lib/python3.6/site-packages/zipline/__main__.py in run(ctx, algofile, algotext, define, data_frequency, capital_base, bundle, bundle_timestamp, start, end, output, trading_calendar, print_algo, metrics_set, local_namespace, blotter)
    274         local_namespace=local_namespace,
    275         environ=os.environ,
--> 276         blotter=blotter,
    277     )
    278

~/anaconda3/lib/python3.6/site-packages/zipline/utils/run_algo.py in _run(handle_data, initialize, before_trading_start, analyze, algofile, algotext, defines, data_frequency, capital_base, data, bundle, bundle_timestamp, start, end, output, trading_calendar, print_algo, metrics_set, local_namespace, environ, blotter)
    157             trading_calendar=trading_calendar,
    158             trading_day=trading_calendar.day,
--> 159             trading_days=trading_calendar.schedule[start:end].index,
    160         )
    161         first_trading_day =\

~/anaconda3/lib/python3.6/site-packages/zipline/finance/trading.py in __init__(self, load, bm_symbol, exchange_tz, trading_calendar, trading_day, trading_days, asset_db_path, future_chain_predicates, environ)
    101             trading_day,
    102             trading_days,
--> 103             self.bm_symbol,
    104         )
    105

~/anaconda3/lib/python3.6/site-packages/zipline/data/loader.py in load_market_data(trading_day, trading_days, bm_symbol, environ)
    154         last_date,
    155         now,
--> 156         environ,
    157     )
    158

~/anaconda3/lib/python3.6/site-packages/zipline/data/loader.py in ensure_treasury_data(symbol, first_date, last_date, now, environ)
    282     except (OSError, IOError, HTTPError, ValueError):
    283         logger.exception('failed to cache treasury data')
--> 284     if not has_data_for_dates(data, first_date, last_date):
    285         logger.warn(
    286             ("Still don't have expected treasury data for {symbol!r} "

~/anaconda3/lib/python3.6/site-packages/zipline/data/loader.py in has_data_for_dates(series_or_df, first_date, last_date)
     81     last_date?
     82     """
---> 83     dts = series_or_df.index
     84     if not isinstance(dts, pd.DatetimeIndex):
     85         raise TypeError("Expected a DatetimeIndex, but got %s." % type(dts))

AttributeError: 'NoneType' object has no attribute 'index'

I think this is happening because the website isn't working properly right now. Maybe the data should be cached elsewhere? Or a copy updated with zipline with each release? Don't be able to seem to run zipline backtesting at all if we can't download this file at least once.
The URL seems to be
https://www.federalreserve.gov/datadownload/Output.aspx?rel=H15&series=bf17364827e38702b42a58cf8eaa3f78&lastObs=&from=&to=&filetype=csv&label=include&layout=seriescolumn&type=package
However, maybe it should be?
https://www.federalreserve.gov/datadownload/Download.aspx?rel=H15&series=bf17364827e38702b42a58cf8eaa3f78&lastobs=&from=&to=&filetype=csv&label=include&layout=seriescolumn&type=package
But this doesn't quite work either.
Here is how you can reproduce this issue on your machine:
Reproduction Steps

Install zipline fresh
Ingest quandl bundle
Try to run a backtest
Fail

What steps have you taken to resolve this already?
Tried adding ValueError to try: except block in treasuries.py
-Nate

This looks like a rather critical issue.
I can confirm the same behavior. This morning all backtests, all Zipline code failed.
Quantopian Zipline maintainers, please, please, please remove this dependency.
 Edit treasury.py to point to a different URL. I made a local file with the same layout, redirected get_treasury_data in case of failure to download, and all works for now. Not a great long term solution, but at least I can run a backtest again.
For a workaround, either change the parsing logic in the read_csv, or just provide a file in the expected layout:
Series Description | Market yield on U.S. Treasury securities at   10-year   constant maturity, quoted on   investment basis
-- | --
Unit: | Percent:_Per_Year
Multiplier: | 1
Currency: | NA
Unique Identifier: | H15/H15/RIFLGFCY10_N.B
Time Period | RIFLGFCY10_N.B
1962-01-02 | 4.06
1962-01-03 | 4.03
1962-01-04 | 3.99
1962-01-05 | 4.02
1962-01-08 | 4.03
1962-01-09 | 4.05
1962-01-10 | 4.07
1962-01-11 | 4.08
...

See also https://github.com/quantopian/zipline/issues/1817
I simply duplicated the last row in treasury_curves.csv up to and including today's date. I don't use them for anything so the fact they are wrong means nothing to me!
Agree removing this dependency is critical - currently Zipline has been bricked by the fed...

I'm not sure, but I think they may be used for getting market open dates or something.  When I try to bundle my CSVs again (haven't done it since last Oct), it fails because 12-5-18 the market was closed, but it wasn't expected to be.  Maybe pandas_market_cal could be helpful for getting dates.
It also seems like there is a zip file here: https://www.federalreserve.gov/datadownload/Choose.aspx?rel=H15
which has xml files with the data.

@ksyme99 do you have a file you could share as a gist or something for now?

@nateGeorge The problem with that date is resolved by updating the trading_calendar package, which has been updated to correctly have that as a market holiday.
The treasury rates are used to calculate the Sharpe Ratio (as mentioned by @pbharrin in the linked issue).
Regarding the error, I have simple edited the ~/.zipline/data/treasury_curves.csv, and copied the last entry and updated the date for all entries between the last row and now. This has resolved for now. Keep in mind this will wreck Sharpe Ratios and might need to undo this when it is fixed proper!

Thanks, the trading_calendars package did fix that issue.  And I see now treasuries are used for Sharpe.  I guess there needs to be some sort of backup datasource or process for filling in the latest missing data when the fed's site isn't working, which shouldn't surprise us much.

The data does seem to be in the 'download all data as single XML file' link here: https://www.federalreserve.gov/datadownload/Choose.aspx?rel=H15
However, that looks like a pain to parse.  The treasury data seems to start with headers like
<kf:Series CURRENCY="NA" FREQ="9" INSTRUMENT="TCMNOM" MATURITY="M3" SERIES_NAME="RIFLGFCM03_N.B" UNIT="Percent:_Per_Year" UNIT_MULT="1"  >
<frb:Annotations>
<common:Annotation>
<common:AnnotationType>Short Description</common:AnnotationType>
<common:AnnotationText>3-month Treasury constant maturity</common:AnnotationText>
</common:Annotation>
<common:Annotation>
<common:AnnotationType>Long Description</common:AnnotationType>
<common:AnnotationText>Market yield on U.S. Treasury securities at 3-month
  constant maturity, quoted on investment basis</common:AnnotationText>
</common:Annotation>
</frb:Annotations>

Then continue with the data from there.
Forward-filling the data as kysme said can also be done, but isn't super accurate.  Best we have for now I guess.  Here is an ugly hack to do just that:
import pandas as pd

filename = '~/.zipline/data/treasury_curves.csv'
df = pd.read_csv(filename, parse_dates=['Time Period'], index_col=0)

today = pd.to_datetime('today').date()

df.loc[today] = df.iloc[-1]
df = df.asfreq('D')
df.ffill(inplace=True)
df.to_csv(filename)

Ok, the site seems to be back up now.  Took somewhere around 2 days for them to get it running again.  Here is a github repo with code for fixing this issue in the future:
https://github.com/nateGeorge/treasury_data_backup


Using the PowerShell .NET Interactive kernel. It does not render the graph with the Plotly graphing tools

Azure Data Studio Version:

Steps to Reproduce:
Add the below code to a PowerShell .Net Interactive cell and run it. The output is blank
$chart = [Graph.Bar]::new()

$chart.x = 20,14,23
$chart.y = 'lions', 'tigers', 'bears'
$chart.orientation='h'

New-PlotlyChart -Trace $chart | Out-Display

Here it is in ADS - does not render the graph

Here it is in VS Code - renders the graph
This is what is expected. I ran this in Visual Studio Code, it also runs and displays the plotly chart in Jupyter Notebook proper, with the dotnet interactive kernel which supports PowerShell, C# and F#.

I can repro.

We'll have to sync with the dotnet-interactive folks here. This won't make the November release, because it's not so simple as just ensuring that we're
This doesn't work because, by default, there's an inline script that gets added into the HTML:
Refused to execute inline script because it violates the following Content Security Policy directive: "script-src 'self' 'unsafe-eval'". Either the 'unsafe-inline' keyword, a hash ('sha256-RCUq22tWhP2XXPFX4hWRNQW+I5anl740Au4o2yoS3wA='), or a nonce ('nonce-...') is required to enable inline execution.

There's some code here that's handled on the dotnet-kernel side and we need to understand how to leverage this effectively: https://github.com/dotnet/interactive/blob/3e46eb1e404d04d786dacd18fb6473eb9fafcb11/src/XPlot.DotNet.Interactive.KernelExtensions/KernelExtension.cs#L45

Closing this issue since .NET Interactive support has been removed from ADS.


(FM-7550) Edit BGP test to pass harness class to vrf test function

Codecov Report

Merging #56 into puppet6 will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           puppet6     #56   +/-   ##
=======================================
  Coverage     5.82%   5.82%
=======================================
  Files          172     172
  Lines        20616   20616
=======================================
  Hits          1200    1200
  Misses       19416   19416

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e130757...09b11a3. Read the comment docs.


bmaas add MetalLB L2Advertisement + Address pool

When testing ironic it may make sense to expose the internal endpoint for Ironic on the baremetal
provisioning network.
This change add's make target bmaas_metallb which creates the IPAddressPool and L2Advertisement resources.
Also some cleanup and docs changes:

Move the execution the nmstate target to the bmaas_crc_baremetal_bridge target.
Change the execution of input target to instead run the namespace target, and run this with the bmaas_baremetal_net_nad target.
Mention that MetalLB is configured in doc's and add a table descriping how the <IP_ADDRESS>/24 subnet is divided into pools.

recheck
It looks like data-plane-adoption-github-rdo-centos-9-crc-single-node  job don't exercise the patched codepath.


add: howto page for valkey-cli

Describe your changes
Add the missing page describing how to connect to Aiven for Valkey™ using valkey-cli. This is very similar to the equivalent page for Aiven for Caching and redis-cli.
This page will be needed by the developer center articles that I am changing to mention Aiven for Valkey instead of Aiven for Caching.

Added the missing page
Linked to it from docs/products/valkey/get-started.md and also fixed the links on that page which still pointed to /docs/products/caching so that they now point to /docs/products/valkey
Added entry in sidebars.ts - it's not obvious from the comments at the top if this is necessary, but it seems consistent with current usage
In the "Connect with Python" page, correct the capitalisation of valkey-python in the link at the end

Checklist

[x] The first paragraph of the page is on one line.
[x] The other lines have a line break at 90 characters.
[x] I checked the output.
[x] I applied the style guide.
[x] My links start with /docs/.

Thanks @harshini-rangaswamy - those are definitely better the new way.


at cromwell.backend.impl.sfs.config.DispatchedConfigAsyncJobExecutionActor.executeAsync(ConfigAsyncJobExecutionActor.scala:215)
	at cromwell.backend.standard.StandardAsyncExecutionActor.executeOrRecover(StandardAsyncExecutionActor.scala:952)
	at cromwell.backend.standard.StandardAsyncExecutionActor.executeOrRecover$(StandardAsyncExecutionActor.scala:944)
	at cromwell.backend.impl.sfs.config.DispatchedConfigAsyncJobExecutionActor.executeOrRecover(ConfigAsyncJobExecutionActor.scala:215)
	at cromwell.backend.async.AsyncBackendJobExecutionActor.$anonfun$robustExecuteOrRecover$1(AsyncBackendJobExecutionActor.scala:65)
	at cromwell.core.retry.Retry$.withRetry(Retry.scala:38)
	at cromwell.backend.async.AsyncBackendJobExecutionActor.withRetry(AsyncBackendJobExecutionActor.scala:61)
	at cromwell.backend.async.AsyncBackendJobExecutionActor.cromwell$backend$async$AsyncBackendJobExecutionActor$$robustExecuteOrRecover(AsyncBackendJobExecutionActor.scala:65)
	at cromwell.backend.async.AsyncBackendJobExecutionActor$$anonfun$receive$1.applyOrElse(AsyncBackendJobExecutionActor.scala:88)
	at scala.PartialFunction$OrElse.applyOrElse(PartialFunction.scala:172)
	at scala.PartialFunction$OrElse.applyOrElse(PartialFunction.scala:172)
	at akka.actor.Actor.aroundReceive(Actor.scala:517)
	at akka.actor.Actor.aroundReceive$(Actor.scala:515)
	at cromwell.backend.impl.sfs.config.DispatchedConfigAsyncJobExecutionActor.aroundReceive(ConfigAsyncJobExecutionActor.scala:215)
	at akka.actor.ActorCell.receiveMessage(ActorCell.scala:588)
	at akka.actor.ActorCell.invoke(ActorCell.scala:557)
	at akka.dispatch.Mailbox.processMailbox(Mailbox.scala:258)
	at akka.dispatch.Mailbox.run(Mailbox.scala:225)
	at akka.dispatch.Mailbox.exec(Mailbox.scala:235)
	at akka.dispatch.forkjoin.ForkJoinTask.doExec(ForkJoinTask.java:260)
	at akka.dispatch.forkjoin.ForkJoinPool$WorkQueue.runTask(ForkJoinPool.java:1339)
	at akka.dispatch.forkjoin.ForkJoinPool.runWorker(ForkJoinPool.java:1979)
	at akka.dispatch.forkjoin.ForkJoinWorkerThread.run(ForkJoinWorkerThread.java:107)

The contents of the referenced stderr file is the following:
$ cat /export/home/ncit/external/a.mizeranschi/automated-VC-test/testingVC-merged/work/cromwell_work/cromwell-executions/main-testingVC-merged.cwl/0d35763d-1bd3-4d23-a7e8-59c099ca3d31/call-pipeline_summary/shard-430/execution/stderr.submit
error: commlib error: got select error (Connection reset by peer)
Unable to run job: failed receiving gdi request response for mid=1 (got syncron message receive timeout error)..
Exiting.

Will try running one more time, to see if this error is reproducible or if it was another cluster networking fluke.

It looks like increasing the memory for Cromwell got rid of some of the previous errors (java.lang.OutOfMemoryError: Java heap space and java.lang.OutOfMemoryError: GC overhead limit exceeded).
It would help a lot if you could update -Xmx on
https://github.com/bcbio/bcbio-nextgen/blob/62b1b79bb0145c44b8aca6fbe242cd0882685efb/bcbio/cwl/tool.py#L205
to e.g. the value of num_cores * memory, where these are taken from bcbio_system.yaml.
The other issues related to cluster load still remain (Unable to run job: failed receiving gdi request response for mid=1), for this scenario with 100 small input FASTQ files. I'll open a separate issue report for those errors.

Thanks for this. Moving discussion to #2721, the more specific issue about memory usage.


Add 2nd gen function support

As discussed in https://github.com/google-github-actions/deploy-cloud-functions/issues/304, it would be great to have gen2 functions support through this GitHub action without needing any further action rather than just specifying through an input value if we want to use or not second gen functions.
There are many advantages in favor of using 2nd gen functions, so I believe this is something most of us as devs will need.
This PR is adding a new gen2 input that will read the gen2 value (1 or 0) and add it to the request when deploying a cloud function.
The README file was updated having this new input field on the list of available inputs.

@igor-imaginemage do you have any concerns about signing the CLA? I would love to see this one merged.

@foreverest, I can sign it. But what I added to this PR is just the beginning of what we have to adjust on this repository. I was trying to advance it more on my local tests, but as I commented here (https://github.com/googleapis/nodejs-functions/issues/62), I'm stuck on the API call where we create a gen2 function. The example Google provides doesn't have the payload, so I'm getting some random errors and as the error message isn't clear of what's going on I'm having difficulties proceeding.
Is this something you can check if you are able to help me? If I get an example of how we should make this API call I can work on the actions script and make it compatible with gen2 functions.

@foreverest I signed it but it's still showing as not signed even after the rescan.

Hi @igor-imaginemage what email address did you use? The commits are signed with<EMAIL_ADDRESS>so it's going to look for a CLA signed by that email address.

<EMAIL_ADDRESS>Once I submitted the CLA form I got the email to sign in.

I noticed that<EMAIL_ADDRESS>wasn't the primary e-mail address when I pushed this commit. I changed my account to use<EMAIL_ADDRESS>as the primary e-mail address now, so I'm not sure if it's related to that.

There are any updates? I would really like it to be merged

I would also like to see this merged! I've converted a number of functions over to 2nd Gen for my project, but now I'm struggling without good CI/CD support for deploying.

@foreverest, I can sign it. But what I added to this PR is just the beginning of what we have to adjust on this repository. I was trying to advance it more on my local tests, but as I commented here (googleapis/nodejs-functions#62), I'm stuck on the API call where we create a gen2 function. The example Google provides doesn't have the payload, so I'm getting some random errors and as the error message isn't clear of what's going on I'm having difficulties proceeding.
Is this something you can check if you are able to help me? If I get an example of how we should make this API call I can work on the actions script and make it compatible with gen2 functions.

@sethvargo can you help me with this?

HI,
Any eta? on merging the pr? we are in need on gen2 action as well, we need to make decision whether to create our own or wait for your PR to be merged.

Our workaround has been to use the gcloud cli in a github action, however this will require your deploying service account to have some additional permissions
jobs:
  job_id:
    runs-on: ubuntu-latest
    steps:
    - uses: actions/checkout@v3

    - id: auth
      uses: google-github-actions/auth@v0
      with:
        credentials_json: '${{ secrets.SERVICE_ACCOUNT_CREDENTIALS }}'

    - name: 'Set up Cloud SDK'
      uses: 'google-github-actions/setup-gcloud@v0'

    - id: 'deploy'
      run: >
        gcloud
        functions
        deploy
        my-function
        --region=europe-north1
        --source=.
        --runtime=nodejs16
        --gen2

That could be a valid workaround for my use case @gerbal. However are you able to also specify the source in that action? Say for example if I have several functions in my repo.

Who has the power to merge this PR? Seems that is purely procedural at this point

Hi @diervo - it's not really procedural. This PR only adds an input - it does not actually upgrade to using the v2 API or structures. It's a fairly significant refactor and behavior change.

any updates here?

Hey folks - I'm going to close this PR because I think it misleads that adding support for gen2 functions is just a few lines-of-code. It's actually an entirely different API that will require significant engineering. Please follow along in https://github.com/google-github-actions/deploy-cloud-functions/issues/304


frontend: make locize-pull

Also part of https://github.com/BitBoxSwiss/bitbox-wallet-app/pull/2947


The variable port is undefined. The execution fails if process.env.port is defined.

Issue

Please provide us with the following information:

This issue is for the sample

    - [ ] 1-1) Sign-in with Azure AD
    - [ ] 1-2) Sign-in with Azure AD B2C
    - [ ] 2-1) Acquire a Token and call Microsoft Graph
    - [ ] 3-1) Protect and call a web API on Azure AD
    - [ ] 3-2) Protect and call a web API on Azure AD B2C
    - [ ] 4-1) Deploy to Azure Storage and App Service
    - [ ] 4-2) Deploy to Azure Static App Service
    - [ ] 5-1) Call a web API using App Roles
    - [ ] 5-2) Call a web API using Security Groups
    - [ ] 6-1) Call Microsoft Graph using on-behalf-of flow
    - [ ] 6-3) Call a web API using Conditional Access Auth Context
    - [x ] 6-4) Sign-in with Hybrid SPA flow

This issue is for a

    - [X ] bug report -> please search issues before submitting
    - [ ] question
    - [ ] feature request
    - [ ] documentation issue or request

Minimal steps to reproduce

define a value for process.env.port

Any log messages given by the failure

port is undefined

Expected/desired behavior

the variable port would be defined if process.env.port is defined in ${process.env.port ? port : 5000} (the file: authController.js)

Library version

Browser and version

Chrome, Edge, Firefox, Safari? Doesn't matter

Mention any other details that might be useful

Should the statement be: ${process.env.port ? process.env.port : 5000} ?

Thanks! We'll be in touch soon.

@jranxb70 Can you please provide a description for the issue you're facing in the Hybrid SPA sample?

@jranxb70  Thanks for catching this. The port variable is not declared  in the authController.js  causing the application to crash when  you define a port in the .env file. I provided a fix in the following PR.


Apply MADV_RANDOM to TERMS_DATA (and PRIMARY_KEY_TRIE) components

This reduces the performance penalty from Linux trying to helpfully page in more data than requested on mmap page fault

Cleaned up NativeLibrary and friends to make logging more consistent.
Most callers of the functions that have a meaningful return value do not check for errors, I have not addressed that but I think this is enough of a scope creep for one ticket.


httponly cookie

It seems like it doesn't clear httponly cookies (like an ASP.sessionID), is that correct?

+1 for clearing http only cookies


Help SSL true not Working

I/flutter ( 7562): 2022-07-01 15:07:15.756105: ldap.connection: FINE: open: ldaps://10...7:636
I/flutter ( 7562): 2022-07-01 15:07:15.999901: ldap.connection: SEVERE: Exception on connect
I/flutter ( 7562): ********* Exception: Bad X.509 certificate: subject=; issuer=/DC=ng/DC=com/DC=example/CN=Example-ENT01 #0      LdapConnection.defaultBadCertHandler (package:dartdap/src/dartdap/client/ldap_connection.dart:403:5)
I/flutter ( 7562): #1      _RawSecureSocket._onBadCertificateWrapper (dart:io/secure_socket.dart:825:29)
I/flutter ( 7562): #2      _SecureFilterImpl._handshake (dart:io-patch/secure_socket_patch.dart:99:46)
I/flutter ( 7562): #3      _SecureFilterImpl.handshake (dart:io-patch/secure_socket_patch.dart:142:25)
I/flutter ( 7562): #4      _RawSecureSocket._secureHandshake (dart:io/secure_socket.dart:911:54)
I/flutter ( 7562): #5      _RawSecureSocket._tryFilter (dart:io/secure_socket.dart:1040:19)
I/flutter ( 7562):
I/flutter ( 7562): Closing
I/flutter ( 7562): 2022-07-01 15:07:16.004169: ldap.connection: FINE: close
I need support, if possible example of script to use - am new to flutter and ad ldaps

The certificate being presented is not valid, or you don't have the the right cert chain in your keystore to verify the cert.
The easiest fix for this (assuming you trust the server) is to ignore the cert error. Not a good long term solution but it will get you going.
You ignore the cert error by supply a bad cert handler in the connection:
Something like:
LdapConnection(host: 'my-host', ....      badCertificateHandler: (cert) => print('ignore bad cert') );

Thank you @wstrange
I used below code as the function is a bool and it was able to bind and search FINE:
LdapConnection(host: 'my-host', ....      badCertificateHandler: (cert)=> true  );

Thank you @wstrange
I used below code as the function is a bool and it was able to bind and search FINE:
LdapConnection(host: 'my-host', .... badCertificateHandler: (cert)=> true );


LinkTimeout randomly ignored

I have noticed in my program, that when adding a LinkTimeout operation after a Connect, sometimes (randomly) the timeout is ignored and the connect operation blocks forever.
It seems to occur more frequently when the binary is compiled in release mode.
I have made a minimal program, which allows me to reproduce 100% of the time (run with cargo run --release), the program should not block more that 3 seconds, but it does:
Cargo.toml:
[package]
name = "io_uring_test"
version = "0.1.0"
edition = "2021"

[dependencies]
io-uring = "0.5.9"
nix = { version = "0.25.0", default-features = false, features = ["net", "socket"] }

src/main.rs:
use io_uring::{
    opcode, squeue,
    types::{Fd, Timespec},
    IoUring,
};
use nix::sys::socket::{socket, AddressFamily, SockFlag, SockType, SockaddrIn, SockaddrLike};

fn main() {
    let mut ring = IoUring::new(8).unwrap();

    let sckt = socket(
        AddressFamily::Inet,
        SockType::Stream,
        SockFlag::empty(),
        None,
    )
    .unwrap();
    let addr = SockaddrIn::new(37, 187, 0, 1, 80);  // an IP that does not respond

    let op_connect = opcode::Connect::new(Fd(sckt), addr.as_ptr(), addr.len())
        .build()
        .flags(squeue::Flags::IO_LINK)
        .user_data(1);

    let op_connect_timeout = opcode::LinkTimeout::new(&Timespec::new().sec(3))
        .build()
        .user_data(2);

    let ops = [op_connect, op_connect_timeout];

    eprintln!("{ops:?}");

    for op in &ops {
        unsafe {
            ring.submission().push(op).unwrap();
        }
    }

    ring.submit_and_wait(2).unwrap();
}

EDIT: removed use of unsafe feature flag.

Maybe put the link on the timeout op and submit that first?

No the LINK_TIMEOUT should follow the entry it is related to.

The way to use then is to setup your command as you usually would, but then
mark is IOSQE_IO_LINK and add an IORING_OP_LINK_TIMEOUT right after it.

<EMAIL_ADDRESS>If I reverse the order the LinkTimeout completion entry has -EINVAL error.

The issue is also reproducible with a read on a TCP socket, and everything works fine in my io_uring program (connect, read fixed, write fixed, close...) apart from the LinkTimeout entries that have no effect most of the time.

I also tried the following:

creating the socket with O_NONBLOCK
using the ASYNC flag for the Connect op
setting an absolute time in Timespec and using the ABS flag

None of that had any effect. Also weird: the program blocks for 210s, when the kernel default TCP timeout is 60s.

Which kernel version is this btw?

BTW, the reproducer from above works on my Linux machine. Times out after the desired number of seconds. I'm on
Linux nuc 5.15.0-48-generic #54-Ubuntu SMP Fri Aug 26 13:26:29 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux

I'm on 6.0.7. I'll try and repo later tonight or tomorrow.

Reason why I'm wondering about the kernel is that there were a lot of issues fixed in 6.0.
We might wanna do some work first here to see what is getting submitted to the kernel. I'm kinda wondering rn if this is a timing issue in uring that is being exacerbated by release mode being faster or if this is a soundness issue in this crate.

Which kernel version is this btw?

6.0.7 (Debian Sid)

The problem is with the op type definition. It takes a pointer to a Timespec, not a struct.
The reason it works in debug I bet is the stack frame isn't optimized to reuse space, so the data for the Timespec could live in the frame long enough for the driver to read it. In release mode, the frame's local variables are given space just long enough for the required lifetime (or so I've read).
    let op_connect_timeout = opcode::LinkTimeout::new(&Timespec::new().sec(3))

You can work around the problem easily by defining a new local for the Timespec with a scope that will outlast the request
and then pass the address of the local to the new call.
    let ts = Timespec::new().sec(2);
    let op_connect_timeout = opcode::LinkTimeout::new(&ts)

Are unit tests run in debug or release mode I wonder.

BTW, I like having this small program for a linked pair of ops. It will come in very handy. Thank you.

Thanks @FrankReh, that was indeed the cause of my issue.
I'm closing this then, since the issue is in my program.
I think the API is easy to misuse though, which is unusual for Rust, but I guess it is the price to pay when using low level bindings.
Thanks again

I think we've run into this problem before where even an experienced rust and tokio developer fell into the same trap and the code existed in one of their crates for a long time. I wondered then why there wasn't an unsafe required to alert the caller they were doing something that was easy to misuse.
Turns out there was then, and there is in your small reproducer too but you didn't notice the warning that came with the unsafe use, and Noah didn't, and I didn't.
Where the reproducer uses unsafe, it does so because the push onto the submission queue is unsafe. And the Safety warning in that push documentation says "Developers must ensure that parameters of all the entries are valid and will be valid for the entire duration of the operation." (With a little paraphrasing of my own.)
My point isn't that the problem was yours, but that the problem is with this crate or the warning or our complacency with using unsafe. Again, because a very experienced tokio person made this same mistake, and many of us read through that code many times and it didn't strike us, and you fell into it here, and a couple of us looked at your 42 lines of code and it didn't strike us immediately either.
Something should be changed. Maybe the push should be renamed to something like unsafe_push or really_unsafe_push. Maybe someone else can chime in with a better idea.
Your case pointed out another nasty aspect of this kind of bug. It can go undetected when running in debug mode. And in release mode, a problem can occur, and the kernel won't even know it was given wrong data sometimes so won't respond with an error. So all the stress testing, theoretically, done in debug mode doesn't help catch this.
I'm going to reopen this so @Noah-Kennedy and @quininer can give this a think too.
Thanks.

I totally agree with you.
To give some context, I had a similar issue with the socket address and the Connect operation. But in this case the explicit .as_ptr() made me quickly notice and fix the issue.
With the Timespec, i missed that what is passed is a pointer a not a &Timespec, that is why I didn't realize it has to outlive the submit call.

I know taking an address isn't considered unsafe and that's why the new functions like for Connect and LinkTimeout aren't unsafe, but I've wondered if they and other op code's that use pointers should be made unsafe.
Or could a reference with a bounded lifetime  be used as input to new rather than a const pointer and could the borrow-checker be asked to guarantee consistency until the enter syscall is made by the submit (or submit_and_wait in this case).
I suspect not, and some kernel structures passed are a deeper tree of allocated memory so the lifetime of the top level isn't going to be stringent enough anyway.

And I can't think of a runtime check, made in debug mode, that even checks for the lifetime of pointed to data that we could built into the SQ push.

Or could a reference with a bounded lifetime be used as input to new rather than a const pointer and could the borrow-checker be asked to guarantee consistency until the enter syscall is made by the submit (or submit_and_wait in this case).

I think it would definitely be the most Rust idiomatic way to do it. I'm not a Rust expert but I think to do that you would have to completely change the API, to consume whatever object hold the reference at the submit call.

I thought about this issue critically when designing the API and concluded that I couldn't guarantee it in low-level API. build a high-level API around it is best way to go.

Folks keep trying to use the io-crate like it was a stand alone library to build an app off of.

Okay. I'm going to close. I know @Noah-Kennedy doesn't have time to rethink things at this level. I'll let the issue drop.

@FrankReh Don't worry about what I have time for, I can get back to thinks later.
IMO this isn't the right place to add these types of semantics. Doing this would basically require us to move the reactor from tokio-uring into here, and I don't think that this is a good idea. The reactor should be a part of async runtimes leveraging this, and they should be responsible for maintaining lifetime invariants here.
I think that the issue here is that historically tokio-uring wasn't always in the nicest spot, but I feel like this is changing now as we've been doing a lot of work to bring it closer to feature parity. tokio-uring should be what folks are using who aren't writing their own async runtime around this.


Move period inside ending quotation

Why: Move period inside ending quotation to align with style guide
Closes: #34222

What's being changed (if available, include any code snippets, screenshots, or gifs):

Check off the following:

[x] I have reviewed my changes in staging, available via the View deployment link in this PR's timeline (this link will be available after opening the PR).

For content changes, you will also see an automatically generated comment with links directly to pages you've modified. The comment won't appear if your PR only edits files in the data directory.

[x] For content changes, I have completed the self-review checklist.

Hi @nguyenalex836,
I noticed #34223 also uses the same tags for the  ...see "Configuring two-factor authentication using a security key" and "Configuring two-factor authentication using GitHub Mobile". part.  Should I include that issue in this PR? if not then please let me know 👍

@SeanAverS Thanks for opening a PR with this fix 👍 I'll update the branch and get this merged once tests are passing 🍏

@SeanAverS Hello! 👋 Great catch - feel free to include update this PR to account for https://github.com/github/docs/issues/34223 as well. Ping me whenever you are finished, and I'll get this merged 🍏

@SeanAverS Apologies - I added this PR to the merge queue and forgot to remove it 🤦 feel free to open a new PR for https://github.com/github/docs/issues/34223. Thank you! 💛


Enable C# Nullable Reference Types

Should just need to add this to projects and fix all warnings:
<Nullable>enable</Nullable>

@ardalis I have enabled Nullable Reference Types for the projects and trying to push. However I ran into Permission issue.
my github account is - @deepumi.
Would you please allow access to create a PR.

Done

Done

Thank you!
There is another warning VS shows up for  which is changed to now  from nuget. Do you want to take care this?


Development\Android SDK\tools\ant\build.xml:644: null

Hi,
This is first time I use supersonic.
There is an error with Development\Android SDK\tools\ant\build.xml:644: null.
I've follow your tutorial. That error occurs when I set my project.xml like this :
android target-sdk-version="23" if="android"
set name="adcolony-supersonic" if="android"
set name="chartboost-supersonic" if="android"
set name="unityads-supersonic" if="android"
haxelib name="extension-supersonic" if="android"
But if I change haxelib on top of set name there is no error :
android target-sdk-version="23" if="android"
haxelib name="extension-supersonic" if="android"
set name="adcolony-supersonic" if="android"
set name="chartboost-supersonic" if="android"
set name="unityads-supersonic" if="android"
But If I try with haxelib on top set name, There is no rewarded video available when I use live ID. I have setup Mediation for adcolony, chartboost, unityads, also supersonic to Active. If I try using Test ID I get the video test from supersonic.
Which is the correct setup on .xml for supersonic? The First / second?	And do you know why I can't get any rewarded video when using live ID?

Hi, I'm testing it here and it's working fine to me...
I have this on project.xml:
<set name="openfl-legacy" />
<android target-sdk-version="22" />
<haxelib name="openfl" />
<haxelib name="actuate" />
<set name="adcolony-supersonic" if="android" />
<set name="unityads-supersonic" if="android" />
<set name="chartboost-supersonic" if="android" />
<haxelib name="extension-supersonic" />

And haxelib like this:
actuate: [1.8.6]
box2d: [1.2.3]
extension-admob: [1.5.0]
extension-amazon-sns: [0.1.1]
extension-amazonads: [0.1.0]
extension-android-immersive: [1.0.1]
extension-android-media: [1.1.0]
extension-android-support-v4: [1.0.0]
extension-facebook: [0.1.0]
extension-facebookads: [1.0.1]
extension-gamecenter: 1.2.0 [dev:/Users/fbricker/CosasCVS/extension-gamecenter]
extension-gamecircle: [1.1.2]
extension-googleplaygames: [1.4.0]
extension-googleplayservices-lib: [1.1.0]
extension-gpgrest: [1.0.2]
extension-harfbuzz: [1.0.3]
extension-iap: 1.1.0 1.2.0 [dev:/Users/fbricker/CosasCVS/extension-iap]
extension-locale: [1.0.1]
extension-multiads: [1.2.2]
extension-multigames: [1.2.0]
extension-nativedialog: [1.2.2]
extension-randomize: [1.0.1]
extension-screenshot: [1.0.0]
extension-share: [2.4.0]
extension-supersonic: [dev:/Users/fbricker/CosasCVS/extension-supersonic]
extension-wake-lock: [0.1.0]
extension-webview: [1.2.1]
flixel-addons: [1.1.0]
flixel-ui: [1.0.2]
flixel: [3.3.11]
format: 3.2.0 [3.2.1]
gafplayer: [1.0.1]
haxe-ga: [0.5.2]
hscript: 2.0.5 [2.0.7]
hxColorToolkit: [1.6.0]
hxcpp: 3.2.180 3.2.193 [3.3.49]
hxnodejs: git [dev:/usr/local/lib/haxe/lib/hxnodejs/git]
inthebox-macros: [1.2.0]
layout: [1.2.1]
lime-samples: [2.6.0]
lime: 2.6.8 2.7.0 [2.9.1]
monax: [1.5.1]
nape: 2.0.19 [2.0.20]
nme: 5.5.7 [5.6.4]
node-webkit: [1.0.7]
openfl-samples: [3.3.1]
openfl: 3.3.8 3.4.0 [3.6.1]
polygonal-core: [1.0.4]
polygonal-ds: [1.4.1]
polygonal-printf: [1.0.2-beta]
promhx: [1.0.21]
stablexui: [1.1.5]
swf: 2.1.1 2.1.3 [2.2.0]
unifill: 0.4.0 [0.4.1]

Hi Fbricker, Thank you for your fast response.
Yes, I've figure which cause the error. It's because of I add extension of samcodes-chartboost in my project.xml. After I remove it your extension working fine.
Sorry about the trouble.
Thanks :)

Never mind... glad it's working 👍


Use OAuth to login to Mastodon

Currently an app is registered & appkeys are stored - but then they are not used. The Retootbot still logs into mastodon with the normal passphrase, which still needs to be in the config.
Rather prompt the passphrase on first use to register OAuth keys, and then use them, so we don't have to store the passphrase.

Tested with web installation, works. Could be more beautiful, but this will be handled in #9.


test_opesci_segy.py

@ggorman
assert(len(files) == 10)
AssertionError
the two rsf files are breaking the test, we need to separate or change this file

It looks like you are behind HEAD. git pull origin master.

@ggorman
My bad wasn't running it properly.
On the other hand, whatever I do I always get his error
shots = ShotManager(comm, shotfiles)

File "/Volumes/Users/mloubout/Dropbox/London/CodeGen/inversion/python/ShotManager.py", line 45, in init
self.create_index(files)
File "/Volumes/Users/mloubout/Dropbox/London/CodeGen/inversion/python/ShotManager.py", line 53, in create_index
_files[i] = files[i]
TypeError: bytes or integer address expected instead of str instance

@ggorman
fixed
need to be replaced by
_files[i] = bytes(files[i],encoding="utf-8")


Update REAME.md

Description
This PR fixes #1248
Notes for Reviewers
Signed commits

Yes, I signed my commits.

@neha-saggam CONGRATS! Did the link I posted help?

Yay, @neha-saggam 🎈 🥳


Rename tests, parallel tests, one elasticsearch replica

related to #44

rename tests
use travis stages for parallel builds
use one ES replica no two. It seems that data between ES nodes were not synchronized properly, therefore reverting the change.
update nsenster

ES tests are passing when cassandra tests are disabled.
I have introduced travis stages to run tests in parallel. Now it seems that it works fine.

I am restarting the build to be sure :)

I think the main here is actually two replicas. What happens is that one server has data and the other no

@jpkrohling this is ready to review. See the PR description for changes.

Readiness probe for ES has been added. Tests still sometimes fail on travis. Maybe it's just unstable travis environment or something with arquillian-cube. However now with travis stages can clearly see which template failed and restart only that.

Tests still sometimes fail on travis.

I'd rather than just remove this and have a proper fix (proper environment, more resilient test... ) .  We'll eventually just ignore the failure and not know when something wrong really happens.
1 - Broken windows theory

I'd rather than just remove this and have a proper fix (proper environment, more resilient test... )

I am not sure what you suggest can be achieved in reasonable time. Can you setup a proper k8s cluster for tests? Because I can't. Let's keep the issue about tests open and move this forward? This is improvement against current master.

I would rather restart tests if necessary than have no tests or disable them.

I don't have time, but introducing a test with intermittent failures is really a bad idea. Merge if you will, I won't block this merge, but I still think it's a terrible idea :)

The problem is that travis environment is not stable. It's not failing only here but also in other Jaeger repositories (e.g. Jaeger main repo xdock tests, all-in-one).
I am fine with restarting the build rather than not having tests at all.  I will merge and keep the issue for tests open.


Feature Request: Have the miniplayer remain on all Desktops

OS:
10.13.3 (17D102)
GPMDP Version:
Version 4.5.0 (4.5.0)
Feature Descriptions:
Basically, the iTunes Miniplayer is visible from all Desktops (So when you switch Desktop using Mission Control, The Miniplayer is still visible in the very same location it was on the previous Desktop). I am asking if the same feature could be implemented in GPMDP.
It would be a great productivity boost when using many Desktops with many apps to always have a close-by control over your music...
Anyway Thanks!
-Ben

This is possible and Electron has an API for it, do you want to give a PR a shot.
The API is here -->
https://electronjs.org/docs/api/browser-window#winsetvisibleonallworkspacesvisible
You would just need to add a new setting in the settings window to toggle this behavior on and off and call that API appropriately 😄


make cart display logged in user's products

Safe to merge - fixed the bug.

Add to cart work and correct cart is displayed on the products page.


Use spire federation in interdomain examples

Description
Currently, we are using sharing cert for two spire servers to make nsm working over two domains. To generate cert and key we are using openssl. It is can be improved if we'll rework spire deployments and spire examples to use spire federation feature.
Implementation details

Remove using openssl in spire examples:https://github.com/networkservicemesh/deployments-k8s/tree/main/examples/spire
Apply https://spiffe.io/docs/latest/architecture/federation/readme/
Test that all examples are still working on CI.

Currently, I have a working interdomain, but floating interdomain is still stuck in interdomain handshakes.
We internally discussed with @edwarnicke that I can continue my investigation on my return.

We want to simplify spire examples with DNS and for this, we need to complete https://github.com/networkservicemesh/deployments-k8s/issues/2792


Bug Fix heap-use-after-free in the bitmap functions

Proposed changes
How to reproduce and more details in #27409
==87116==ERROR: AddressSanitizer: heap-use-after-free on address 0x60200160a118 at pc 0x5560d96fe0f3 bp 0x7f47783b7f90 sp 0x7f47783b7f80
READ of size 2 at 0x60200160a118 thread T391 (FragmentMgrThre)
    #0 0x5560d96fe0f2 in inline_memcpy /data/doris-1.x/be/src/glibc-compatibility/memcpy/memcpy_x86_64.cpp:132
    #1 0x5560d96feea5 in memcpy /data/doris-1.x/be/src/glibc-compatibility/memcpy/memcpy_x86_64.cpp:219
    #2 0x5560ed490b67 in ra_overwrite (/usr/local/service/doris/lib/be/doris_be+0x25b72b67)
    #3 0x5560d9d077f5 in roaring::Roaring::Roaring(roaring::Roaring const&) /var/local/thirdparty/installed/include/roaring/roaring.hh:68

    ...too much output.

    #21 0x5560d9d08b26 in phmap::btree_map<unsigned int, roaring::Roaring, phmap::Less<unsigned int>, std::allocator<std::pair<unsigned int const, roaring::Roaring> > >::operator=(phmap::btree_map<unsigned int, roaring::Roaring, phmap::Less<unsigned int>, std::allocator<std::pair<unsigned int const, roaring::Roaring> > > const&) /var/local/thirdparty/installed/include/parallel_hashmap/btree.h:3963
    #22 0x5560d9d08b50 in doris::detail::Roaring64Map::operator=(doris::detail::Roaring64Map const&) /data/doris-1.x/be/src/util/bitmap_value.h:140
    #23 0x5560d9d12665 in doris::BitmapValue::_prepare_bitmap_for_write() /data/doris-1.x/be/src/util/bitmap_value.h:1954
    #24 0x5560d9d0f258 in doris::BitmapValue::operator^=(doris::BitmapValue const&) /data/doris-1.x/be/src/util/bitmap_value.h:1466
    #25 0x5560e31dac6c in doris::vectorized::BitmapXor::vector_vector(COW<doris::vectorized::IColumn>::immutable_ptr<doris::vectorized::IColumn>*, unsigned long, unsigned long, std::vector<doris::BitmapValue, std::allocator<doris::BitmapValue> >&, doris::vectorized::IColumn*) /data/doris-1.x/be/src/vec/functions/function_bitmap_variadic.cpp:130
    #26 0x5560e31ed0a7 in doris::vectorized::FunctionBitMapVariadic<doris::vectorized::BitmapXor>::execute_impl_internal(doris_udf::FunctionContext*, doris::vectorized::Block&, std::vector<unsigned long, std::allocator<unsigned long> > const&, unsigned long, unsigned long) /data/doris-1.x/be/src/vec/functions/function_bitmap_variadic.cpp:230
    #27 0x5560e31e8a1c in doris::vectorized::FunctionBitMapVariadic<doris::vectorized::BitmapXor>::execute_impl(doris_udf::FunctionContext*, doris::vectorized::Block&, std::vector<unsigned long, std::allocator<unsigned long> > const&, unsigned long, unsigned long) /data/doris-1.x/be/src/vec/functions/function_bitmap_variadic.cpp:196
    #28 0x5560e25fdaf5 in doris::vectorized::DefaultExecutable::execute_impl(doris_udf::FunctionContext*, doris::vectorized::Block&, std::vector<unsigned long, std::allocator<unsigned long> > const&, unsigned long, unsigned long) /data/doris-1.x/be/src/vec/functions/function.h:484
    #29 0x5560e3f01c98 in doris::vectorized::PreparedFunctionImpl::execute_without_low_cardinality_columns(doris_udf::FunctionContext*, doris::vectorized::Block&, std::vector<unsigned long, std::allocator<unsigned long> > const&, unsigned long, unsigned long, bool) /data/doris-1.x/be/src/vec/functions/function.cpp:244
    #30 0x5560e3f01325 in doris::vectorized::PreparedFunctionImpl::default_implementation_for_nulls(doris_udf::FunctionContext*, doris::vectorized::Block&, std::vector<unsigned long, std::allocator<unsigned long> > const&, unsigned long, unsigned long, bool, bool*) /data/doris-1.x/be/src/vec/functions/function.cpp:214
    #31 0x5560e3f01a26 in doris::vectorized::PreparedFunctionImpl::execute_without_low_cardinality_columns(doris_udf::FunctionContext*, doris::vectorized::Block&, std::vector<unsigned long, std::allocator<unsigned long> > const&, unsigned long, unsigned long, bool) /data/doris-1.x/be/src/vec/functions/function.cpp:235
    #32 0x5560e3f01d98 in doris::vectorized::PreparedFunctionImpl::execute(doris_udf::FunctionContext*, doris::vectorized::Block&, std::vector<unsigned long, std::allocator<unsigned long> > const&, unsigned long, unsigned long, bool) /data/doris-1.x/be/src/vec/functions/function.cpp:266
    #33 0x5560e25fa730 in doris::vectorized::IFunctionBase::execute(doris_udf::FunctionContext*, doris::vectorized::Block&, std::vector<unsigned long, std::allocator<unsigned long> > const&, unsigned long, unsigned long, bool) /data/doris-1.x/be/src/vec/functions/function.h:155
    #34 0x5560e2513fef in doris::vectorized::VectorizedFnCall::execute(doris::vectorized::VExprContext*, doris::vectorized::Block*, int*) /data/doris-1.x/be/src/vec/exprs/vectorized_fn_call.cpp:109
#35 0x5560e25233be in doris::vectorized::VExprContext::execute(doris::vectorized::Block*, int*) /data/doris-1.x/be/src/vec/exprs/vexpr_context.cpp:46
    #36 0x5560df029a77 in doris::vectorized::VUnionNode::materialize_block(doris::vectorized::Block*, doris::vectorized::Block*) /data/doris-1.x/be/src/vec/exec/vunion_node.cpp:285
    #37 0x5560df025478 in doris::vectorized::VUnionNode::get_next_materialized(doris::RuntimeState*, doris::vectorized::Block*) /data/doris-1.x/be/src/vec/exec/vunion_node.cpp:157

...

0x60200160a118 is located 8 bytes inside of 11-byte region [0x60200160a110,0x60200160a11b)
freed by thread T373 (FragmentMgrThre) here:
    #0 0x5560d96b8a6f in free (/usr/local/service/doris/lib/be/doris_be+0x11d9aa6f)
    #1 0x5560ed490883 in ra_shrink_to_fit (/usr/local/service/doris/lib/be/doris_be+0x25b72883)

previously allocated by thread T373 (FragmentMgrThre) here:
    #0 0x5560d96b8dc7 in __interceptor_malloc (/usr/local/service/doris/lib/be/doris_be+0x11d9adc7)
    #1 0x5560ed490822 in ra_shrink_to_fit (/usr/local/service/doris/lib/be/doris_be+0x25b72822)

...


Scheduled Task initiated with previous failed task's outputData

Describe the bug
Creating a task where it is setup to retry upon failure, the retried task is populated with the previous failed attempt's outputData.
Details
Conductor version: 3.2.0
Workflow definition: {   "name": "response_test",   "version": 1,   "tasks": [       {           "type": "HTTP",           "name": "FUNCTION",           "taskReferenceName": "test_task",           "inputParameters": {             "http_request": {                 "uri": "http://httpstat.us/500",                 "method": "GET",                 "Accept": "application/json"             }         },         "taskDefinition": {             "name": "test_task",             "retryCount": 3,             "retryLogic": "FIXED",             "retryDelaySeconds": 120,             "timeoutPolicy": "RETRY"         }       }   ],   "ownerEmail"<EMAIL_ADDRESS>  "schemaVersion": 2 }
Task definition: included in workflow definition
Event handler definition:
To Reproduce
Steps to reproduce the behavior:

Create workflow curl --location --request POST 'http://localhost:8080/api/metadata/workflow' \ --header 'Content-Type: application/json' \ --data-raw '{ "name": "response_test", "version": 1, "tasks": [    {        "type": "HTTP",        "name": "FUNCTION",        "taskReferenceName": "test_task",        "inputParameters": {          "http_request": {              "uri": "http://httpstat.us/500",              "method": "GET",              "Accept": "application/json"          }      },      "taskDefinition": {          "name": "test_task",          "retryCount": 3,          "retryLogic": "FIXED",          "retryDelaySeconds": 120,          "timeoutPolicy": "RETRY"      }    } ], "ownerEmail"<EMAIL_ADDRESS>"schemaVersion": 2 }'
Start the workflow curl --location --request POST 'http://localhost:8080/api/workflow/response_test' \ --header 'accept: application/json' \ --header 'Content-Type: application/json' \ --data-raw '{"version": 1}'
Get workflow by Id. Replace workflow id in the curl with output of step#2 curl --location --request GET 'http://localhost:8080/api/workflow/4949a49f-ea2c-4fc2-9c73-331c5ff70196'
Search for "OutputData" in the response from step 3 and look for the second occurrence. Even though the taskId for the second execution is different than the the first and the task is in scheduled state, and the startTime and endTime are 0 indicating the task has executed, the outputData is populated with the response from the first attempt.

Expected behavior
When a failed task is retried, the outputData should be empty until the task is actually executed and has outputData.
Screenshots
Result Json with explanation:

First task attempt failed, second retry in scheduled state and outputData is populated from the first attempt.
workflow_execution_status_2_scheduled.txt

Second retry now in Failed state and outputData now replaced with the actual result of second retry and a 3rd retry in scheduled state with outputData populated from the 2nd failure.
workflow_execution_status_2_failed.txt

Additional context
Add any other context about the problem here.

The behavior is same in conductor version 2.30.3 as well. This is the version we use and originally noticed the issue. Tried to verify in latest and see the same behavior in 3.2.0

@roversnord While this is fairly simple to fix, we were thinking if this would break for some users, for eg., if they were using output data from the failed attempt(s).
What are you trying to accomplish?

When we update task, we don't want to lose the previously populated outputdata for the task, so we append to the outputdata if there's anything there already. What this causes is when a task fails and is retried, the output data keeps getting accumulated with all the previous failed attempts' outputdata. So, if have 5 retries and the first 4 fail and the last attempt succeeds, the outputdata now has the data from all 5 attempts. If there is a need to use output data from the failed attempts, it would be possible to cycle through the failed attempts get that info but if we don't want the outputdata from the failed attempts there isn't a way to do that.

@csharplus this is a good first issue to look into, if you are interested.

Hi Aravindan,
Sure, I'll take a look at it, and let you know when the fix is ready for
review.
Thanks,
Henry
On Mon, Jan 10, 2022 at 2:25 PM Aravindan Ramkumar @.***>
wrote:

@csharplus https://github.com/csharplus this is a good first issue to
look into, if you are interested.
—
Reply to this email directly, view it on GitHub
https://github.com/Netflix/conductor/issues/2452#issuecomment-1009404358,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AKC4FNNGJQ6L72UVXU7LULLUVNMEHANCNFSM5DWKOPXQ
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you were mentioned.Message ID:
@.***>


[Refactoring] Fix crash when refactoring protocol requirement to async

When a function declaration has no body (e.g. because it’s a protocol requirement), we construct the range to replace by the async keyword as follows:

Start: One character after the closing ) (or potentially the throws keyword if it exists)
End: Last token in the function declaration

Since the last token in the function declaration is the ), we end up with a range that has End < Start, which crashes when trying to print the range.
If the function has no body, we should just use the range’s start location as the end location to construct an empty range.
Fixes rdar://76677035

@swift-ci Please test

@swift-ci Please test

@swift-ci Please test


Copy username

It would be nice copy not only password, but also username.

Hey! Thanks for this comment (:
I'll try taking a look over the weekend and will keep you posted here. If you have expertise and want to contribute, feel free to open a pull request; I'd be happy to assist

Hey @mostepunk,
Sorry for the late reply, life got a lot in the way lately.
So much so that I forgot the feature is already implemented :sweat_smile:
Screencast from 04-07-23 22:56:20.webm
This is a quick screencast showcasing the feature. You can move on the fields with arrows and use Ctrl+C to copy the field.
Or did you have something else in mind? Maybe for the copy command?

Hi @shikaan!
I want to integrate keydex to dmenu.
keydex list | dmenu-run| keydex copy

But I want to create one script for copy password, and another for copy username. I didn't find how can realize with keydex.

Hey @mostepunk, I think this makes totally sense.
What do you think of the following interface?
keydex copy --field=UserName

So that you can copy any field of the entry

I took a quick stab at it here. If it makes sense to you I'll go ahead and merge it tomorrow

Went through the code again and tried it with dmenu myself.
It'll look something like keydex list | dmenu | keydex copy -fUsername
I am merging it now, feel free to reopen this thread if it does not work or you have further suggestions

Thanks a lot! I'll try it in a few days


Webpack 2 bundling error

Hi,
I have encountered an issue when including this library using Webpack 2. I have attached the error log [1], and I have also published a minimal reproducer that can be found here
I'm looking forward to use this library, it looks great! :)
Btw, I had to add:
  node: {
    fs: 'empty',
    tls: 'empty'
  }

..in my webpack config, to avoid errors from node-specific modules (fs etc) in ws. But it seems like a known issue with webpack. Maybe it could be mentioned in the wiki somewhere?
I have also tried installing the library using npm instead of yarn, just in case, but I encountered the same error.
Hash: e9cfd813b9d98ebecc84
Version: webpack 2.5.1
Time: 1948ms
                      Asset       Size  Chunks                    Chunk Names
app-e9cfd813b9d98ebecc84.js    1.05 MB       0  [emitted]  [big]  app
                 index.html  200 bytes          [emitted]
   [0] ./~/buffer/index.js 48.6 kB {0} [built]
   [5] (webpack)/buildin/global.js 509 bytes {0} [built]
  [40] ./~/stream-http/index.js 1.72 kB {0} [built]
  [43] ./~/ws/index.js 1.05 kB {0} [built]
  [61] ./~/isarray/index.js 132 bytes {0} [built]
  [64] ./~/node-libs-browser/mock/empty.js 0 bytes {0} [built]
  [87] ./~/ws/lib/Receiver.js 23.1 kB {0} [built]
  [88] ./~/ws/lib/Sender.js 7.88 kB {0} [built]
  [89] ./~/ws/lib/WebSocket.js 27.6 kB {0} [built]
  [90] ./~/osc-js/lib/osc.js 44.2 kB {0} [built]
 [100] ./~/base64-js/index.js 3.48 kB {0} [built]
 [147] ./~/ieee754/index.js 2.05 kB {0} [built]
 [182] ./~/ultron/index.js 2.96 kB {0} [built]
 [194] ./~/ws/lib/WebSocketServer.js 16.9 kB {0} [built]
 [196] ./src/index.js 29 bytes {0} [built]
    + 184 hidden modules

WARNING in ./~/ws/lib/BufferUtil.js
Module not found: Error: Can't resolve 'bufferutil' in '/Users/$HOME/error/node_modules/ws/lib'
 @ ./~/ws/lib/BufferUtil.js 12:15-36
 @ ./~/ws/lib/Sender.js
 @ ./~/ws/index.js
 @ ./~/osc-js/lib/osc.js
 @ ./src/index.js

WARNING in ./~/ws/lib/Validation.js
Module not found: Error: Can't resolve 'utf-8-validate' in '/Users/$HOME/error/node_modules/ws/lib'
 @ ./~/ws/lib/Validation.js 12:16-41
 @ ./~/ws/lib/Receiver.js
 @ ./~/ws/index.js
 @ ./~/osc-js/lib/osc.js
 @ ./src/index.js

ERROR in ./~/osc-js/lib/osc.js
Module not found: Error: Can't resolve 'dgram' in '/Users/$HOME/error/node_modules/osc-js/lib'
 @ ./~/osc-js/lib/osc.js 936:47-63 1028:49-65
 @ ./src/index.js
Child html-webpack-plugin for "index.html":
       [0] ./~/lodash/lodash.js 540 kB {0} [built]
       [1] ./~/html-webpack-plugin/lib/loader.js!./~/html-webpack-plugin/default_index.ejs 538 bytes {0} [built]
       [2] (webpack)/buildin/global.js 509 bytes {0} [built]
       [3] (webpack)/buildin/module.js 517 bytes {0} [built]

Looks like osc.js has a similar issue
I will includedist/osc.min.js using a standard script tag for now.

Thank you for this one!
dgram, 'utf-8-validate and bufferutil are all non-browser dependencies. I agree that there should be a note for webpack users (or any other browser-related build) to configure the tool accordingly.
Does it work if you set the other dependencies to empty as well, like:
  node: {
    fs: 'empty',
    tls: 'empty',
    utf-8-validate: 'empty',
    dram: 'empty',
    bufferutil: 'empty'
}

Thank you for your quick response! I got it working with:
  node: {
    fs: 'empty',
    tls: 'empty',
    dgram: 'empty',
    ws: 'empty',
  },

There are still two warnings [1] that I couldn't get rid off (I really need to learn more about Webpack), but it seems to be working now! I managed to create an instance of osc-js and printed it to the console.
[1]:
WARNING in ./~/ws/lib/BufferUtil.js
Module not found: Error: Can't resolve 'bufferutil' in '/Users/$HOME/code/javascript/test/node_modules/ws/lib'
 @ ./~/ws/lib/BufferUtil.js 10:19-40
 @ ./~/ws/lib/Sender.js
 @ ./~/ws/index.js
 @ ./~/osc-js/lib/osc.js
 @ ./src/app.js
 @ ./src/index.js

WARNING in ./~/ws/lib/Validation.js
Module not found: Error: Can't resolve 'utf-8-validate' in '/Users/$HOME/code/javascript/test/node_modules/ws/lib'
 @ ./~/ws/lib/Validation.js 10:19-44
 @ ./~/ws/lib/Receiver.js
 @ ./~/ws/index.js
 @ ./~/osc-js/lib/osc.js
 @ ./src/app.js
 @ ./src/index.js

To prevent bundling errors with Webpack etc. I introduced an alternative library version osc.browser.js (https://github.com/adzialocha/osc-js/pull/20) which can be used in Webpack builds (read this Wiki for further information). @davidgranstrom


Provide a Clear Browser Cache function in the setting page

https://github.com/AlphaWallet/alpha-wallet-ios/issues/1224

[ ] Implement
[ ] Verify #1224 works for Victor (hopefully without having deleting the app since)


Fix Ruby 2.7 keyword deprecation warning in validators/coerce

Fix these deprecation warnings
grape/lib/grape/validations/validators/coerce.rb:21: warning: Using the last argument as keyword parameters is deprecated; maybe ** should be added to the call
grape/lib/grape/validations/validators/base.rb:16: warning: The called method `initialize' is defined here

Is there any way we can fail CI when we have these warnings?

Is there any way we can fail CI when we have these warnings?

Umm, I can't suggest enough ways to make CI fail with ruby warnings.

Is there any way we can fail CI when we have these warnings? Maybe a Danger plugin?

The warning gem could be use to turn warnings into exceptions, that might be one way.

@eregon You'll be my hero if you can make it work.

Btw, I had tried in spec_helper to override warn, which worked. The problem was that I couldn't have both specs that expect warnings and always fail on unexpected warnings.

That gem seems to allow filtering warnings like :keyword_separation so that might be helpful.


Use cfg and path attribute instead of cfg_attr for IntelliJ Rust support

PR for IntelliJ Rust plugin support by replacing cfg_attr with cfg and path, as per https://github.com/hecrj/iced/issues/104

Awesome! Thank you! :tada:


Support ts config

Playwright config can also be a typescript file. Load it if it exists, fallback to js, if not. This preference for the ts config matches the default behaviour of playwright-test.

@tianfeng92
Will we also update the docs? It's currently not reflected on how to use the config file


Custom baseline sql script

Hi there! I'm looking for something like a custom baseline SQL script that I can define in my atlas.hcl config. Here is what I mean
docker "postgres" "dev" {
  image  = "postgis/postgis:15-3.4-alpine"
  schema = "public"
  baseline = <<SQL
    drop extension postgis cascade;
  SQL
}

env "ci" {
  url = "postgres://${var.username}:${var.password}@${var.host}:${var.port}/${var.database}?search_path=public&sslmode=disable"
  dev = docker.postgres.dev.url

  migration {
    dir    = "file://db/migrations"
    format = atlas
    baseline = <<SQL
      drop extension postgis cascade;
    SQL
  }
}

But seems the current baseline parameter under migration block expects the baseline version instead of the script like in the docker driver. The problem is that I have different databases in CI and in the cloud, where the cloud database has an extension on the server, but is not initialized, so I have to create a new migration version to run the statement create extension postgis;, but in the CI I use postgis docker container which initializes postgis extension by default https://github.com/postgis/docker-postgis/blob/master/initdb-postgis.sh and that seems impossible to disable. So, to prevent failing my statement create extension in the CI, I have to drop that extension first and let my migrations initialize the extension again. I managed to get this work in dev database by providing a custom SQL script for baseline, but I failed to do it on my primary database. The current workaround I drop the extension in the CI before applying atlas migrations, but it seems relevant to let users define custom baseline script per environment without modifying the CI itself. If you have other options on how I can get this thing to work fully on Atlas, I will be happy to hear! Thanks!

Hello @KostyaZgara, the PG extension was supported in the canary version of the atlas, which you can install using our install script. Check more information about it here: https://atlasgo.io/atlas-schema/hcl#extension
Please let me know it you still have issue with PG extension, cheers!

Hi, thanks for your response!
I tried to follow the documentation you sent me, but atlas doesn't see any changes between current migration directory and the desired state. I added extension resource to schema file
extension "postgis" {
  schema  = schema.public
  comment = "PostGIS geometry and geography spatial types and functions"
}

schema "public" {
  comment = "standard public schema"
}

Run command
$ atlas migrate diff --env moji install_postgis_extension

which gave me the following message
The migration directory is synced with the desired state, no changes to be made

But I expected that Atlas would generate a new migration entry with something like
create extension postgis;

Here is my Atlas CLI version
atlas version v0.19.3-eaf1e59-canary

I think what you can do is instead of using postgis locally, use bare postgres (if that is what you have in production). Then Atlas will generate the CREATE EXTENSION statement.

I don't fully understand how extension resources work. For instance, this postgres image https://hub.docker.com/r/bitnami/postgresql has postgis installed on server, but it's not enabled by default, and executing create extension postgis is required. In another case, when postgis extension doesn't exist on the server at all and executing create extension postgis statement fails, for instance for this image https://hub.docker.com/_/postgres/.
Theoretically, I can narrow down my image types to one when postgis is installed, but not enabled, cuz for example, for production I'm using GCP CloudSQL which seems to have postgis installed, but not enabled (I can't verify it for sure, cuz I'm blocked by issue where I can't push migrations to Atlas Cloud), but my research gave me that vast majority of cloud database has postgis onboard out-of-box. So let's say I would use for CI, local development, and dev database a similar image where postgis is installed, but not enabled, for instance, bitname image. But how atlas resource extension would work here? As I mentioned before, it doesn't generate a create extension postgis statement to enable postgis extension.
While writing this message, I realized I never tried to use bitnami image everywhere except production. Let me try to do it and I'll come back with the results

Thanks! The solution of using Atlas on the database level instead of schema worked for me. Here is my feedback comment https://github.com/ariga/atlas/issues/2596


Adding auto-assign for issues/PRs.

If the author of the commit u/s is in the reviewers list then he will be assigned to the issue/PR, otherwise, a random reviewer will be picked from a default reviewer list.
Signed-off-by: Yoni Bettan<EMAIL_ADDRESS>

Still didn't run e2e test for it.

ERROR: denied: installation not allowed to Write organization package

ERROR: denied: installation not allowed to Write organization package

Since the package belongs to my account, you are not allowed to push to it.

Since the package belongs to my account, you are not allowed to push to it.

I though that the Github workflow is using your creds.

@qbarrand PTAL.
This is only the scaffolding for now and it still needs some work. Just want to make sure you are OK with the general idea.
If you do, will ping you when it is ready for the real review.

@qbarrand PTAL.
I will squash once the content is approved.


[Fix] [UI-Next][V1.0.0-Alpha] Rename node to task in the task creation modal

close #9330

Codecov Report

Merging #9351 (00c5894) into dev (ee0e3be) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##                dev    #9351      +/-   ##
============================================
- Coverage     39.98%   39.98%   -0.01%
+ Complexity     4375     4373       -2
============================================
  Files           822      822
  Lines         32921    32921
  Branches       3656     3656
============================================
- Hits          13164    13162       -2
- Misses        18527    18532       +5
+ Partials       1230     1227       -3

Impacted Files
Coverage Δ

...org/apache/dolphinscheduler/remote/utils/Host.java
37.77% <0.00%> (-2.23%)
:arrow_down:

...e/dolphinscheduler/remote/NettyRemotingClient.java
52.11% <0.00%> (-0.71%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ee0e3be...00c5894. Read the comment docs.


Cannot access to nested class in DataTemplate

Describe the bug
Using WinUI3 (Windows App SDK), I cannot access to nested class in DataTemplate x:DataType.
I had already tried to look at old issues, and the most relevant seems #3238, however the + symbol doesn't solve the issue.
I'm not sure where I should open the issue (https://github.com/microsoft/ProjectReunion or here)..
Steps to reproduce the bug
A very minimalistic example:
In XAML file:
<Window
    x:Class="App1.MainWindow"
    xmlns="http://schemas.microsoft.com/winfx/2006/xaml/presentation"
    xmlns:x="http://schemas.microsoft.com/winfx/2006/xaml"
    xmlns:local="using:App1"
    xmlns:d="http://schemas.microsoft.com/expression/blend/2008"
    xmlns:mc="http://schemas.openxmlformats.org/markup-compatibility/2006"
    mc:Ignorable="d">

    <StackPanel Orientation="Horizontal" HorizontalAlignment="Center" VerticalAlignment="Center">
        <ListView ItemsSource="{x:Bind persons}">
            <ListView.ItemTemplate>
                <DataTemplate x:DataType="local:MainWindow.Person">
                    <TextBlock Text="{x:Bind Name}"></TextBlock>
                </DataTemplate>
            </ListView.ItemTemplate>
        </ListView>
    </StackPanel>
</Window>

while che code-behind is:
namespace App1
{
    public sealed partial class MainWindow : Window
    {
        public class Person
        {
            public string Name;
            public string Surname;
        }

        readonly ObservableCollection<Person> persons = new();

        public MainWindow()
        {
            this.InitializeComponent();
            persons.Add(new Person() { Name = "AAA", Surname = "BBB" });
        }
    }
}

If I move class Person in the global scope (removing it from MainWindow class) and modifying the x:DataType to local:Person, the code compiles.
Expected behavior
This code should compile.
Screenshots

NuGet package version
No response
Windows app type

[X] UWP
[ ] Win32

Device form factor
Desktop
Windows version
Windows 10 (21H2): Build 19044
Additional context
No response

This is true for Win32 as well. Nested types cannot be referenced at all at the moment.

Any update on this?

Out of curiosity, I have tested this issue and I can confirm it is still here with WASDK v1.5.6.
So, I kindly ask the moderators to reopen it.


Dark mode

There is maybe easier way for theming, but it depends on ability to modify main WikiTree css files...
CSS allows to define user variables and this feature is now well supported.
https://developer.mozilla.org/en-US/docs/Web/CSS/Using_CSS_custom_properties
So if it's possible to somehow edit main CSS - define color pallette (based on color scheme - it's defined somewhere, but I cannot remember where) there and use variables everywhere instead of constants - it's easy to overwrite those variables in extension with custom colors.
https://css-tricks.com/updating-a-css-variable-with-javascript/
There is also another benefit - if the variables are named reasonably (e. g. --primary-color , --secondary-text-color, --privacy-public-color,...) then there is also hint for other devs what colors to use and if there will be change of color, it will only change on one place.

Modifying the primary site to set CSS variables for the primary colors is something we might be able to do. It's a relatively simple set of declarations, and then modification of the CSS definitions to use the variables instead of the explicit colors. I've add this to our queue for possible implementation, but don't know if/when it might be done.


feat: Merge all contracts into one ABI

Related issue(s)

Resolves #
Description
This:

Merges all methods in a contract into one ABI.
Adds a ContractType to contract methods so we can distinguish between private/public/unconstrained

Summary of changes

Dependency additions / changes

Test additions / changes

Checklist

[ ] I have tested the changes locally.
[ ] I have formatted the changes with Prettier and/or cargo fmt with default settings.
[ ] I have linked this PR to the issue(s) that it resolves.
[ ] I have reviewed the changes on GitHub, line by line.
[ ] I have ensured all changes are covered in the description.

Documentation needs

[ ] This PR requires documentation updates when merged.

Additional context

Note: We may want to add a test to see what happens when two contracts in different modules are compiled with the same name

There's similar changes which would have to be made to the wasm crate here in order to be consistent.
My preference on this is that we remove support for compiling contracts in TS for now as we're going to be making too many breaking changes. @kobyhallx

Ideally we have this for offsite, so they can compile and make tests in typescript. Its not a hard condition and if it makes the lives of tooling folks hard we can find an alternative.
I'm guessing the painpoint you are referring to is when we are developing on master since, once we cut a release the ts and native should be synced up?


"Automatic partitioning" description isn't hidden when manual partitioning is selected

Currently the description of automatic partitioning stays in the Wizard even when the manual partitioning is selected.

Expected behaviour:

when the manual partitioning radio is selected, the "Automatic partitioning" description is hidden

How to reproduce

Go to the File system configuration step in the image wizard
Select "Manually configure partitions" radio button

Fixed by https://github.com/RedHatInsights/image-builder-frontend/pull/1464


python3Packages.cmarkgfm: 0.5.3 -> 0.6.0

Motivation for this change
Update to latest upstream release 0.6.0
Change log: https://github.com/theacodes/cmarkgfm/releases/tag/0.6.0
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
21.11 Release Notes (or backporting 21.05 Relase notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 128903 run on x86_64-linux 1

14 packages failed to build:

apache-airflow
home-assistant
mailman-web (python39Packages.mailman-web)
python38Packages.ansible-kernel
python38Packages.ansible-runner
python38Packages.apache-airflow
python38Packages.mailman-web
python38Packages.postorius
python38Packages.toggl-cli
python39Packages.ansible-kernel
python39Packages.ansible-runner
python39Packages.apache-airflow
python39Packages.postorius
python39Packages.toggl-cli

36 packages built:

check_systemd
evdevremapkeys
keepkey_agent (python39Packages.keepkey_agent)
ledger_agent (python39Packages.ledger_agent)
luigi
mnemosyne
onlykey-agent
python38Packages.cmarkgfm
python38Packages.gtts
python38Packages.keepkey_agent
python38Packages.ledger_agent
python38Packages.libagent
python38Packages.nagiosplugin
python38Packages.ndjson
python38Packages.pypiserver
python38Packages.python-daemon
python38Packages.readme
python38Packages.readme_renderer
python38Packages.restview
python38Packages.salmon-mail
python38Packages.trezor_agent
python38Packages.twine
python39Packages.cmarkgfm
python39Packages.gtts
python39Packages.libagent
python39Packages.nagiosplugin
python39Packages.ndjson
python39Packages.pypiserver
python39Packages.python-daemon
python39Packages.readme
python39Packages.readme_renderer
python39Packages.restview
python39Packages.salmon-mail
trezor_agent (python39Packages.trezor_agent)
twine (python39Packages.twine)
wlc

Was introduced with #141037.


sparkle-ization of Data Source screen

Fixes https://github.com/dust-tt/tasks/issues/106

Move everything to ContextItem follow Figma design
Report sync status or initial synchronization as a busy Chip
Report notion pages or github / discussion issues synced so far during initial syncing

Figma is here: https://www.figma.com/file/QOxHwppG64GtPocpDhS6Y7/Product?type=design&node-id=2389-13595&mode=design&t=NGCdaQGtfP1osJ6E-0

Ack I have to leave now, but can have a look first thing tom morning

Quick question on design @Duncid : on the first datasource (google drive on screenshot), the "manage" button feels off (a bit too high / out of "box" / lost... not sure how to say)
I know it's actually perfectly aligned :) but maybe a line on top like for the others would be a good visual guide? Although I understand it might give a feeling of separation with the section title...

Thanks! Addressed :+1:


Do Not Merge Yet: Conda recipe

Created a conda recipe

@wasade shall we go with our own version system or be in sync with Siavash's tagged version, i.e. https://github.com/smirarab/sepp-refs/tree/4.3.4 ?

@mortonjt and maybe also review this PR?


have some issue in abstract SliderView class in the new update, v1.2

have some issue in abstract SliderView class in the new update, v1.2, the older version will be fine

Me too, and can't use old version because i already use glide in my project

same error

Same here
Please give a solution to this....

There is some issue in new Version (V2.2)
You can also use
SliderView sliderView = new DefaultSliderView(getActivity());

have some issue in abstract SliderView class in the new update, v1.2, the older version will be fine

Update to 1.3.0 , and use SliderAdapter to add customized views in slider whatever you wand :+1: .


Version 4.0.0

This is a WIP pull request that will augment the library with multiple features that have already been implemented in Harpy's sister library, the Swift version, Siren for v4.0.0 of the app.
Already Implemented (in this PR)

Use App's Internal Bundle ID to perform version check instead of asking for external App ID
Augment Networking APIs (e.g., NSURLComponents, etc.)
Device check compatibility

To Be Implemented

Error handling
Improved Logging
Unit Tests
Modernize Syntax

Still working on this issue - just a bit pressed for time. I'll hopefully have it done in the next week or so.

Improved logging just now.


'show' is unused

Is anyone getting swift compiler warning,  that says

Result of call to 'show' is unused

_ = PopupController.create(self).show(CalPickerViewController.instance())


Is any other place to download the checkpoints

It's too slow when downloading cpk form Yandex.Disk

What checkpoints you need, vox-celeb you can download from google-drive https://drive.google.com/open?id=1kZ1gCnpfU0BnpdU47pLM_TQ6RypDDqgw

thanks

i am trying to download the vox-cpk.pth.tar checkpoint but yandex requires a russian phone number for me to download, which i dont have. Could you possibly upload elsewhere?

Vox celeb checkpoint is also on goole drive
https://drive.google.com/open?id=1kZ1gCnpfU0BnpdU47pLM_TQ6RypDDqgw

How can I extract them 7Zip and Winrar cant read it and report it as a broken archive

See #18

the google drive link only contains images and mp4s

Search for vox-cpk.pth.tar

Can I get the fashion checkpoint on Google Drive as well?

I will upload checkpoints here https://drive.google.com/open?id=1PyQJmkdCsAkOYwUyaj_l-l0as-iLDgeH


Run: Unexpected error: !ok

So we have been experiencing issues with gRPC shutting down in authservice as people authenticate, would result in 403s from envoy as it could no longer communicate to authservice while the actual process continued to run only way to resolve would be to manually delete/recycle the authservice pod. I have added logs with trace logging for authservice (with gRPC tracing) and envoy to the issue.
Commenting out the break on line 137 of async_service_impl.cc fixes the issue (the logs uploaded are using this fix). It looks like we were exiting on a bool that isnt fatal if its false thus causing the server to shut down.

The authservice log is the interesting one with error entries for gRPC as follows:
"Attempt to send initial metadata after stream was closed"
"Attempt to send message after stream was closed"
"Attempt to send trailing metadata after stream was closed"
However in terms of the browser request, it doesnt even appear to have any issues and people are able to auth without issues with this change.
Looking at the gRPC documentation it looks as if Next() returns a bool that if false you should shut the server down, but doesnt seem to be the case for the ok value.
Bear in mind haven't personally worked with gRPC on any projects and could be totally wrong on this fix, however if this is an acceptable fix i can submit a PR for it.
I am however still curious as to what is going on with the stream closing errors, as I'm not seeing anything in the envoy logs relating to it.
authservice.log
envoy.log

Thanks for reporting this!

@cfryanr
Experienced same error twice. Hopefully it gets addressed. Let me know if you need any logs from my end.
[2020-07-14 03:44:53.487] [console] [debug] Check: no matching trigger rule, so allowing request to proceed without any authservice functionality ://host.com/web/Servlet/app/RULES_/pbdorj4V2ay*/!TABTHREAD2?pyActivity=pyDeleteDocPg&pzFromFrame=&pzPrimaryPageName=RH_1&pzHarnessID=HID494geMessages=true&AJAXTrackID=1
[2020-07-14 03:44:53.487] [console] [trace] Request processing complete
[2020-07-14 03:44:53.487] [console] [error] Run: Unexpected error: !ok
[2020-07-14 03:44:53.487] [console] [info] Server shutting down
[2020-07-14 03:45:18.700] [console] [info] operator(): Starting periodic cleanup (period of 60 seconds)
[2020-07-14 03:45:18.700] [console] [info] DoPeriodicCleanup: removing expired sessions from chain idp_filter_chain
[2020-07-14 03:46:18.700] [console] [info] operator(): Starting periodic cleanup (period of 60 seconds)
[2020-07-14 03:46:18.700] [console] [info] DoPeriodicCleanup: removing expired sessions from chain idp_filter_chain
[2020-07-14 03:47:18.700] [console] [info] operator(): Starting periodic cleanup (period of 60 seconds)
[2020-07-14 03:47:18.700] [console] [info] DoPeriodicCleanup: removing expired sessions from chain idp_filter_chain
[2020-07-14 03:48:18.700] [console] [info] operator(): Starting periodic cleanup (period of 60 seconds)

@cfryanr
Configured authservice at ingress gateway level
We are frequently seeing this error and had to restart ingress pod.
Can we have a  solution for this? or workaround untill this is addressed. this is hindering our POC efforts.
Also would like to know how best it scales with increased traffic.
Thanks for all your support.

@r-kotagudem My fix noted in the original issue commenting out that line fixes it, might be able to throw my image we are using in our environment up in the next 24 hours for you

@r-kotagudem My fix noted in the original issue commenting out that line fixes it, might be able to throw my image we are using in our environment up in the next 24 hours for you

@AndrewBabbitt97
Thank you

@r-kotagudem My fix noted in the original issue commenting out that line fixes it, might be able to throw my image we are using in our environment up in the next 24 hours for you

@AndrewBabbitt97 rebuilt the image with this change. we are not facing the issue. will keep monitoring.

@AndrewBabbitt97 @r-kotagudem We are experiencing the same issue from time to time. Did you get any feedback about your fix, and if this is a viable fix? If so, what is the roadmap for the next release of authservice and will you create a PR?

@stefanhenseler I haven't gotten feedback on this, however we have been running a version of authservice with this patch in production for quite some time now and it's been stable.
I can definitely go and open a PR for this fix.

Awesome, thanks for your feedback. I would create a PR and see if it gets merged.

@AndrewBabbitt97 @r-kotagudem We are experiencing the same issue from time to time. Did you get any feedback about your fix, and if this is a viable fix? If so, what is the roadmap for the next release of authservice and will you create a PR?

No issues after this change suggested by @AndrewBabbitt97. it is stable from long time

Just got off a call yesterday with Tetrate to discuss some of this stuff, should hopefully see that PR go through soon.

Devs, can you PLEASE just fix this tiny issue, otherwise this proxy is pretty useless in production because it keeps stopping. Otherwise, maybe some tips to build is myself, because that doesn't work either. Thanks!

Devs have provided a getting started guide for building it here: https://github.com/istio-ecosystem/authservice/wiki/Setting-up-CLion-on-MacOS-for-Authservice-development
If you can't build your dependencies are probably off. Refer to the makefile for commands. Most notable if you are just trying to build is make docker build

@cfryanr who is currently maintaining this project? There are several PRs that have not been merged and released yet. Notably, Redis support.

Devs have provided a getting started guide for building it here: https://github.com/istio-ecosystem/authservice/wiki/Setting-up-CLion-on-MacOS-for-Authservice-development
If you can't build your dependencies are probably off. Refer to the makefile for commands. Most notable if you are just trying to build is make docker build I build on Ubuntu 20.04 just fine.
In the end this isn't a proxy, it's a implementation of envoys external auth api. Curious as to if other implementations of this are around.

make docker-from-scratch FTW!

@cfryanr who is currently maintaining this project? There are several PRs that have not been merged and released yet. Notably, Redis support.

Redis support is already merged in, there's just not a release published with it. You can build master to get it

@AndrewBabbitt97 Thanks for the tips and the fix. I was able to build and image from your PR and deploy it. Will see if it helps the problem, thanks!


[Feature]: Make doggonation image visible in dark mode

[x] Would you like to take up this task?
[x] Are you from GSSoC'23?

Hello, @MisterMickey I want to thake this issue/task.
Yes I am from GSSoc'23 assign me the issue.

Go ahead

@akashgreninja What's this akash?
I have raised this issue, why haven't you assigned it to me? I've already check the box that I want to take this issue, Kindly unassign him and assign me the issue.

@MisterMickey I aplogise for this assigned it to you very sorry

@akashgreninja I'm not able to find the dark theme code can you please assist me in which file it's there?