Fix: Unable to elevate system while "cl7h" repository is active

By submitting pull requests to this repo, I agree to the Contributor License Agreement which can be found at: https://github.com/cpanel/elevate/blob/main/docs/cPanel-CLA.pdf

What is the source of the cl7h repo? We'd need to review it before we green light it.

I'm replacing this with #518


add slots that are rendered if there are no options or search results and improve how search works

By default the slots display the value of the noOptionsText or noResultsText props.

covers issues #42 #44 #46

also covers issue #47

@coronoro ready to merge?


Use os.Environ() in addition to extra env vars

If cmd.Env is empty, it uses the current process's environment. If len(extraEnv) > 0, then we have to append both the current process's env and extraEnv to cmd.Env

Codecov Report

Merging #292 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #292   +/-   ##
=======================================
  Coverage   59.24%   59.24%
=======================================
  Files          90       90
  Lines        6991     6991
=======================================
  Hits         4142     4142
  Misses       2545     2545
  Partials      304      304

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 57ffd07...c6f7b6e. Read the comment docs.


[BUG]Shows unknown license without any conflicting or unknown license

Describe the bug
Shows unknown license without any conflicting or unknown license
To Reproduce
Steps to reproduce the behavior:
same dependencies used:
"dependencies": {
		"ansi-styles": "^3.2.1",
		"escape-string-regexp": "^1.0.5",
		"supports-color": "^5.5.0",
		"bootstrap": "4.1.1",
		"dojo": "1.13.3",
		"libnmap": "0.4.15"
	}

Expected behavior
Should show conflict/unknown license if unable to suggest
Screenshots

@sunilk747 FYI

@invincibleJai This is the scenario when we were unable to find the package level license of one of the dependencies. Either the license is not known to us or we couldn't find a synonym for the license. If you could provide the stack id of the above stack analysis call I can debug more.

@sunilk747 i have provided deps in issue , pls generate one ;)

Yeah sure.

https://github.com/openshiftio/saas-analytics/pull/706


Upgrade to Bicep v0.3.1

@anthony-c-martin  / alex-frankel
Can you please review this and LMK if there's anything else I'm missing from v0.3?


Choose first embedded screen instead of first screen

When I have my laptop (Dell XPS) connected to a second screen sometimes icc-brightness picks that screen instead of the embedded screen.
This change fixes that. See also this closed PR that had the same fix but included a bunch of other changes as well: https://github.com/udifuchs/icc-brightness/pull/30.

@rb3ckers I ran into a similar problem with my XPS. Unfortunately, the order of the display data was unpredictable for me. You may want to check out my fix on #34.

The patch works on my HP Spectre. I think it is sensible to choose the first embedded screen.
@tartansandal why is the order important with this approach here? This would - as far as I understand it - only be problematic if your device has multiple embedded displays.

@mdrake

why is the order important with this approach here?

A bit of poor communication on my behalf. Apologies. I was just reiterating the coding issue that both PRs were addressing in different ways.
If you are only interested in controlling the brightness on your laptop, then yes, choosing the first embedded screen is the most sensible approach. However, if you want to keep open the potential for controlling external monitors using the same tool, then that would be problematic.


internal/gps: Add prune functions to gps

What does this do / why do we need it?
Add different functions to gps that implement different pruning modes.
The different modes are as follows:

pruneNestedVendorDirs: Delete any directory named vendor.
pruneNonGoFiles: Delete any file that doesn't end with .go (will keep files matching common names for legal documents)
pruneGoTestFiles: Prune Go test files (any file ending with _test.go)
pruneUnusedPackages: Delete all files in unused Go packages. Since we might import a sub package we only delete files and keep directories.

What should your reviewer look out for in this PR?
Correctness.
Do you need help or clarification on anything?
Refer to https://github.com/sgotti/glide-vc/ for comparison and ideas.
Is adding an option to allow overriding deletion of specific files a good idea?
Which issue(s) does this PR fix?
Breaking down #952

I'm back to work on this. Should update it today.

@carolynvs Added some simple tests now.

@sdboyer
To improve performance, I was thinking of doing a single filepath.Walk to collect file and directory names and then running the operations on that list.
All the current rules are based on file names anyway so stating multiple times is wasteful.

@ibrasho if you think that general approach is feasible, then i'd say it's vastly preferable.
seems like it might be good to reuse dirwalk code for this purpose, once #1084 is done.

kicking CI to retest, that last one seems like an error?
i'd like to merge this soon, even if it's sorta WIP, as i think we can improve as we go - in particular, i don't think we need to fix the filepath.Walk() duplication right now. however, i do want to get the various smaller cleanup issues addressed, as it seems quite unlikely that we'll remember to grab those in a later PR.

I've pushed some a patch of changes.
I'll keep the changes related to deduplicating filepath.Walk for another PR.

ahh, some new linting errors, as we added some linters - once we have fixes for those, i think we should be ready to go with this.

I'm not sure these linter errors are valid...
/home/travis/gopath/src/github.com/golang/dep/internal/gps/vcs_source.go:379:2: redundant if ...; err != nil check, just return error instead.
/home/travis/gopath/src/github.com/golang/dep/internal/gps/vcs_source.go:460:2: redundant if ...; err != nil check, just return error instead.
internal/gps/prune.go:21:2: const PruneNestedVendorDirs is unused (U1000)
internal/gps/prune.go:23:2: const PruneUnusedPackages is unused (U1000)
internal/gps/prune.go:27:2: const PruneNonGoFiles is unused (U1000)
internal/gps/prune.go:29:2: const PruneGoTestFiles is unused (U1000)
internal/gps/prune.go:60:6: func Prune is unused (U1000)
internal/gps/prune.go:75:6: func PruneProject is unused (U1000)
internal/gps/prune.go:106:6: func pruneNestedVendorDirs is unused (U1000)

ahhhhh so the errors are at least in part because this predates #1157, which changed some of the logic. however, there is one valid complaint in there, which actually points to a real bug:
internal/gps/prune.go:162:19: ToSlash is a pure function but its return value is ignored (SA4017)

I just added that a few hours ago because calculateUnusedPackages had a bug on Windows. 😓
I've rebased. Should be fixed and ready to merge now.

ok so it really seems like those travis linting failures must be erroneous. merging this now, and we'll keep an eye on subsequent PRs to see if we have a real problem or not.


Update SLO in Prometheus

[X] The commits are squashed in a cohesive manner and have meaningful messages.
[X] For commits that came from upstream, [UPSTREAM] has been prepended to the commit message
[X] JIRA link(s): https://issues.redhat.com/browse/RHODS-3947
[ ] The Jira story is acked
[X] Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious)
[X] The developer has manually tested the changes and verified that the changes work.

Live Build
quay.io/lferrnan/rhods-operator-live-catalog:1.11.1-prometheus-slo
Testing instructions

Install the live build in a cluster
Login to RHODS Prometheus
Go to Status > Rules
Verify the expression for SLOs-haproxy_backend_http_responses_total and SLOs-probe_success

lgtm


Lab1

Implements fibonacci printing for both negative and positive n

Please fix failing CI build.
Please go through the common high level code review comments collected from other PRs - they might be useful to you as well.

Codecov Report

Merging #148 into master will not change coverage.
The diff coverage is 100%.

@@          Coverage Diff          @@
##           master   #148   +/-   ##
=====================================
  Coverage     100%   100%
=====================================
  Files          15     16    +1
  Lines         236    251   +15
=====================================
+ Hits          236    251   +15

Impacted Files
Coverage Δ

01_fib/lexual/main.go
100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 70a1318...b58451b. Read the comment docs.

Here is code review I performed for someone else, for lab 1.
https://github.com/anz-bank/go-course/pull/145

I have a new commit pushed, that responds to comments. Specifically:

table-driven testing adopted
better comment
test fib(0) case.


dot/stress: add initial stress app

The stress app can be run by doing go test --tags=stress.
The stress app seems to succeed and only runs a few seconds and does not include all possible operations and types.
But it is a decent start.

Codecov Report

Merging #259 into master will not change coverage.
The diff coverage is 100%.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c0fa81b...36e7952. Read the comment docs.

Codecov Report

Merging #259 into master will not change coverage.
The diff coverage is 100%.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c0fa81b...36e7952. Read the comment docs.


Issue: Not honouring the base views height consraint

Hi,
I am using pagemenu as a subview of the existing ui view, its not fullscreen one like on in the samples.  kind of like a android view pager control. Check out the image http://imgur.com/akDVJ5l
Today i ran into a problem where pagemenu is not honouring the height of the parent view it resides. I need to manually set the height of the pageview.view to fix this
        var newFrame = self.pageMenu!.view.frame;
        newFrame.size.height = 300;
        pageMenu!.view?.frame = newFrame;

        self.pageView.addSubview(pageMenu!.view)

I am not sure whether this control is intended to use it like this.. but it solves my usecase.
Just wondering this is the expected behaviour??

Not sure why this is happening. If you set the frame in the initializer of PageMenu it should set it appropriately, but it could be a bug in that kind of use case


Click on link should be settable to choose between open link on franz window or default browser window

At this point, when I click on a link inside a frianz recipe, it opens the target in a new small franz window.
There is the possibility to open the link in my own default browser if I right-click first, then select Open Link.
It would be nice to have a parameter to set the default behavior when opening a link. The user would choose between these two choices at least:

Default behavior (small franz window)
Open in default browser.

Those behaviors both already exist, it is just a matter of settings. So it shouldn't be to complicated (my guess).
Thanks

Thanks for the reply.
I'm on Windows 10, I have tried this with Chrome and Brave (made on top of chromium).
I'm quite sure it happens with all the different services I'm using (Inbox, Office 365, Slack, Messenger and Whatsapp). It does not do that all the time though. Sometimes it opens the link on the default browser on its own.

Hmmm... Could be that Franz is sometimes confused as the default browser if the browser is Chromium based when it's being handled by the default "opening" code?
Interesting, guess we'll see what @adlk can say about it.

I'm on the 5.0.0-beta.18 version

I concur this same behaviour occurs on the linux client.
I do think it is service related though. On my end, specifically for Outlook.
When I click a link directly in an email a small franz window appears.
Right click open results in default browser launching.
Whatsapp / Slack / Microsoft Teams = default browser always
Franz Version: 5.0.0-beta.18
Release: 1.8.4 / linux / x64

I am using Franz 5.0.1 Version 4.0.8/linux/x64 on fedora.
I have the same issue with the outlook 365 owa: links I click on are opened in a new window of what I assume is franz's web browser instead of my system's web browser (Chrome). I have to do right click -> open in browser to do that. Other services like slack or gmail correctly open links in the system browser by default. So it is a service specific issue.

After a recent update Franz started opening links in new Franz windows, as well as in an open browser.
OS: Linux (kernel 5.8.18-1)
Distro: MANJARO x86_64 20.2 Nibia
Franz version: 5.5.0


Issues regarding node upgrade

Recently some deployments have started using node v12, which caused some issues with the node-sass module that we're using. This raises the concern that we don't have an automatic way to rebuild the node modules. It shouldn't be part of our all or install target since it can be expensive, and in most cases, it's redundant.
Instead, we should either create a new build (or any other target) that cleans the modules and then does the installation.  Or we could introduce a new make target that does the cleaning, and our build recipes should call that first if they need to.

After creating this Issue @robes  pointed out that we should use make distclean  instead of make clean if we want to completely start from a clean chaise build.
@karlcz @ljpearlman @robes @svoinea @bugacov
So in the recipes used for rebuilding the vm, you should use make distclean before doing make install in chaise. This will ensure that you'll get the latest node dependencies appropriate for your node version.


Broken link in CONTRIBUTING.md

Code of Conduct URL is broken in CONTRIBUTING.md
It is redirecting to https://github.com/accordproject/docs/blob/master/Accord Project Code of Conduct.pdf
I am sending a PR with this URL https://lfprojects.org/policies/code-of-conduct/

Fixed in #124


Error running Hello Minikube tutorial on Apple Silicon M1

Hello!
I am working through the Hello Minikube tutorial https://kubernetes.io/docs/tutorials/hello-minikube/. When I try to create a deployment of echoserver I get an error in my kubectl logs:
nginx: [error] failed to initialize Lua VM in /etc/nginx/nginx.conf:54

As a sanity check I tried running docker run k8s.gcr.io/echoserver:1.4 and got this warning, which I suspect may be a clue:
WARNING: The requested image's platform (linux/amd64) does not match the detected host platform (linux/arm64/v8) and no specific platform was requested

I am working through the tutorial on an Apple MacBook Air M1 2020 running macOS 11.6 Big Sur.
Thank you for any insights on this!

UPDATE: I tried passing the --platform flag to fetch the ARM64 image (so, docker run --platform linux/arm64/v8 k8s.gcr.io/echoserver:1.4) and got a similar error:
docker: Error response from daemon: image with reference k8s.gcr.io/echoserver:1.4 was found but does not match the specified platform: wanted linux/arm64/v8, actual: linux/amd64.

/assign @imoisharma

It looks like the Hello Minikube tutorial requires a Linux AMD64 node, or at least isn't compatible with a VM running AArch64 & Linux.
I'm not sure what the best step forward might be here. Perhaps a newer version of that echoserver container supports AArch64?

Hi @sftim, thanks for taking a look at this! I was poking around in the echoserver project and I found some hints that multi-arch builds should be supported. This mentions arm64, which is what seems to be missing from the container registry.
https://github.com/kubernetes/kubernetes/blob/master/test/images/echoserver/BASEIMAGE
I'm wondering if maybe the non-amd64 builds aren't happening for some reason, or aren't getting pushed up? A little out of my depth on this one 😆


Fix app crashing if the notification channel has not been created yet

Fixes #364

Checks if a notification channel should be created, if it should, creates the notification channel.

According to the PlayerNotificationManager documentation https://exoplayer.dev/doc/reference/com/google/android/exoplayer2/ui/PlayerNotificationManager.html:
The caller is responsible for creating the notification channel.

@googlebot I signed it!

Wow, thanks very much for spotting this and submitting a fix!


Refinements to core functionality

I'm still cleaning up the tests and documentation but this is readier for review. If/when this is approved I can write up a migration guide and things like that, but I don't want to do that until I know what has been approved :D

Request struct
HTTP.Body type
Some renaming (I feel like NetworkService and BackendService are very close to the same thing - open to discussion on that)
DecodingFailureRepresentable is a refinement on NetworkFailureRepresentable
More work in handling errors

Codecov Report

Merging #117 into master will decrease coverage by 1.19%.
The diff coverage is 91.33%.

@@            Coverage Diff             @@
##           master     #117      +/-   ##
==========================================
- Coverage   94.14%   92.94%   -1.20%
==========================================
  Files          47       46       -1
  Lines        1554     1347     -207
==========================================
- Hits         1463     1252     -211
- Misses         91       95       +4

Impacted Files
Coverage Δ

...cate Pinning/TrustValidatingTransportService.swift
0.00% <0.00%> (ø)

...rspace/Extensions/Coding/JSONCoder+Container.swift
0.00% <0.00%> (ø)

...es/Hyperspace/Service/Network/NetworkSession.swift
100.00% <ø> (ø)

...ervice/Peripheral/NetworkActivityIndicatable.swift
100.00% <ø> (ø)

...perspace/Service/Peripheral/RecoveryStrategy.swift
100.00% <ø> (ø)

Tests/Helper/Mocks/MockBackendService.swift
40.74% <37.50%> (ø)

Sources/Hyperspace/HTTP/HTTP.swift
86.95% <53.84%> (-13.05%)
:arrow_down:

Tests/DecodingFailureTests.swift
80.00% <62.50%> (-20.00%)
:arrow_down:

...perspace/Extensions/Coding/Request+Decodable.swift
85.71% <85.71%> (ø)

Sources/Hyperspace/Request/Request.swift
90.00% <85.71%> (+1.11%)
:arrow_up:

... and 43 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ff9b7e6...5f2fd33. Read the comment docs.

Codecov Report

Merging #117 into master will increase coverage by 0.71%.
The diff coverage is 95.91%.

@@            Coverage Diff             @@
##           master     #117      +/-   ##
==========================================
+ Coverage   94.14%   94.86%   +0.71%
==========================================
  Files          47       48       +1
  Lines        1554     1460      -94
==========================================
- Hits         1463     1385      -78
+ Misses         91       75      -16

Impacted Files
Coverage Δ

...cate Pinning/TrustValidatingTransportService.swift
0.00% <0.00%> (ø)

...ervice/Peripheral/NetworkActivityIndicatable.swift
100.00% <ø> (ø)

...perspace/Service/Peripheral/RecoveryStrategy.swift
100.00% <ø> (ø)

Tests/Helper/Mocks/MockCodableContainer.swift
100.00% <ø> (ø)

...ests/Helper/Mocks/MockNetworkSessionDataTask.swift
100.00% <ø> (ø)

Tests/Helper/Mocks/MockBackendService.swift
40.74% <37.50%> (ø)

Tests/Helper/Mocks/MockNetworkSession.swift
90.90% <50.00%> (-9.10%)
:arrow_down:

Tests/DecodingFailureTests.swift
82.35% <75.00%> (-17.65%)
:arrow_down:

Tests/HTTPTests.swift
92.85% <88.88%> (-1.12%)
:arrow_down:

Tests/EncodingTests.swift
90.90% <90.90%> (ø)

... and 54 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ff9b7e6...c0b81b6. Read the comment docs.

Also, I'm going to need you to fix all those Codebeat warnings. 😜

@tylermilner I was able to actually fix one, the rest I relaxed the rules. Otherwise we'd need to start creating sub-structs on Request.

Hadn't noticed the Travis failure - should be fixed now and ready to go barring additional feedback.


Fixes: cloning with colons

This fixes two issues:

When using a repo like bitbucket:local.url.com:org/name in vue init, the temp directory made would have multiple colons in it, this caused git to fatal.

This has included in #565 but thanks for the PR.


Visual Studio Code Terminal presents some character glitches related to formatting

Using the terminal shows some display glitches like "←[0m" with certain applications like az interactive. This odd characters seems to be related to formatting not being supported ... see example below of a VSCode Terminal:
Microsoft Windows [versão 6.1.7601]
Copyright (c) 2009 Microsoft Corporation. Todos os direitos reservados.
C:\Users\bu8n>az interactive
←[?25l←[0m←[?7l←[0m←[J←[0m
←[0mDo you agree to sending telemetry (yes/no)? Default answer is yes: ←[0m

Extension	Author (truncated)	Version
vscode-service-fabric-reliable-services	ms-	0.1.2
python	ms-	2018.7.1
azurecli	ms-	0.4.2
azurerm-vscode-tools	msa	0.4.2
vscode-docker	Pet	0.1.0

This is likely related to winpty, tracking in https://github.com/Microsoft/vscode/issues/45693


flyctl: 0.2.55 -> 0.2.58

Description of changes
Bumps flyctl to the latest version.
flyctl#3561 also fixes the issue we had with a failing test, so skipping that is no longer necessary.
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[x] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Result of nixpkgs-review pr 314437 run on aarch64-darwin 1

1 package built:

flyctl

Result of nixpkgs-review pr 314437 run on x86_64-linux 1

1 package built:

flyctl


Clamp Date's month and day in the constructors

Pull Request Test Coverage Report for Build<PHONE_NUMBER>8
Details

29 of 29 (100.0%)  changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.2%) to 92.762%

Totals

Change from base Build<PHONE_NUMBER>6:
-0.2%

Covered Lines:
3427

Relevant Lines:
3652

💛  - Coveralls


chore(ci): fix OSX builds

cc @fkorotkov

This is the right fix: https://github.com/GoogleChrome/puppeteer/pull/2861


A UI layout exception

ℹ Computer information

PowerToys version: 0.25.0
PowerToy Utility: PowerToy Setting
Running PowerToys as Admin: yes
Windows build number: 19042.610

📷 Screenshots
Are there any useful screenshots? WinKey+Shift+S and then just paste them directly into the form

@SakuraNeko
sorry but can you explain a bit more what the issue is?
申し訳ありませんが、問題が何であるかをもう少し説明できますか？

@SakuraNeko  @crutkas
is it the trash icons being partially cut?

@enricogior Yes, This problem occurs on a device with a 250% scaling rate.
This can even happen when the width of the window is reduced.

@niels9001 can we make this break at the size into two lines for overflow like we do with the right side?

@crutkas We should redesign the entire thing so it's optimized for accessibility and inline with W10 UX standards (ListViews normally do not contain interactive elements, that's what a DataGrid is for). This issue is also related to the UI bug mentioned here: #5695
We are tracking the redesign here: https://github.com/microsoft/PowerToys/issues/2813#issuecomment-683288524

Tracked in https://github.com/microsoft/PowerToys/issues/2813


frontend: Add story for MainInfoSection

Following #2034 , I am adding this story for testing the null backlink.

@sniok , I added this quick story for the MainInfoSection, mainly for testing the backlink. However, it looks like the story is generating changes in other snapshots. Maybe this is because I am importing the podList which comes from a different section and maybe that messes up some things?
I am mentioning you here just in case this is related to the Vite changes, since I don't remember a case like this before.

I'll take a look

There was an issue with snapshots, they were not deterministic sometimes, I made a PR with a fix.

Regenerated snapshots as a fixup commit


Investigate into ESLint support for notebooks

Notebooks can contain JS and TS cells. Would be cool if we can use ESLint to validate them

This got added.


Experiment with css content-visibility

Experiment with css content-visibility.

[ ] How it works

[ ] Is there a possible combination of viewport-prio

[ ] ...

blog

spec

close in favoure of #208


Select2 does not work in Meteor/Bootstrap Modal

I have been trying for some time now to get select2 to work with Meteor. I am basically getting data from a MongoDB collection and then creating a profile with that data. A user can then click on "Delegate", which makes a modal popup where the select2 box is. Here you can see the HTML code: https://github.com/domschiener/liquid-democracy/blob/master/app/client/templates/dashboard/delegates/delegates.html#L64 and here I'm declaring the select2 box inside the modal: https://github.com/domschiener/liquid-democracy/blob/master/app/client/templates/dashboard/delegates/delegates.html#L103
Here is the Javascript code where I'm enabling select2 https://github.com/domschiener/liquid-democracy/blob/master/app/client/libraries/dashboard/delegates/delegates.js#L1
The weird thing is that it seems to work fine on localhost (meaning that the select2 box works locally), but when I deploy the app on my server the select2 box does not render and just remains in the old html/css.
Anyone have a suggestion of what Im doing wrok?

Also, I have tried certain hacks as suggested here http://stackoverflow.com/questions/18487056/select2-doesnt-work-when-embedded-in-a-bootstrap-modal but none of them helped solve the problem.

The fix for Select2 within a Bootstrap modal is usually https://github.com/select2/select2/issues/600#issuecomment-102857595.
Any issues between production/local deployments are outside of the scope of Select2, I'd recommend checking your JavaScript console and making sure Select2 is actually being loaded.

This appears to be more of a usage question than a bug report or common feature request.  As we continue to keep the Select2 issue tracker geared towards these two areas, bug reports and common feature requests, we are redirecting usage questions to other communities such as the mailing list, IRC, or Stack Overflow.


Add link to css spec in css modules

Each module should have links to the css spec for any properties used within that module.

Dupe of #103


New github :format for appcasts needed.

See #10056.

Closing based on discussion in  https://github.com/caskroom/homebrew-cask/issues/15908 (:formathas been removed for the time being)


Refactor imod_coupler

Implement proper log support
Replace exit with Exceptions
Refactor init

Please see https://issuetracker.deltares.nl/browse/IMOD6-255

input(f"PID: {os.getpid()}, press a any key to continue ....")

Done!


Bump organization management version to 1.4.34

Changes in this PR

$subject

Merging this PR since the actual code PR [1] passed the PR builder.
[1] https://github.com/wso2-extensions/identity-organization-management/pull/377


feat: add option to exclude global define and env replacement

Description
Intent to fix https://github.com/vuejs/vitepress/issues/419, but not completely resolved.

Related clues:
#3077
#3229
#3176

Ideally, the replacement of define and env can be turned off by specifying options, as in my test example.
I put forward this PR to stimulate discussion about whether the problems caused by string replacement should be fixed.
This is just one of my attempts, there should be other better ways to welcome you to point it out.
Thank you for your positive opinions.

Additional context

When I wrote the test example, I also found the error of define and pre-building, see also: #5570

What is the purpose of this pull request?

[ ] Bug fix
[x] New Feature
[ ] Documentation update
[ ] Other

Before submitting the PR, please make sure you do the following

[x] Read the Contributing Guidelines.
[x] Read the Pull Request Guidelines and follow the Commit Convention.
[x] Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
[x] Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
[x] Ideally, include relevant tests that fail without this PR but pass with it.

@patak-dev Would it be possible to have this merged? It's related to https://github.com/vuejs/vitepress/issues/419 and it's breaking Vite 3 docs page as well (Env Variables and Modes page) 😅

@kiaking we need to discuss this with the team, but I don't think it is the best option. A user may want to use import.meta.env in their .md inside Vue components, and will have the same problem. Maybe we need some flag so Vite would ignore these, like \0process.env.
We have a few instances in the Vite docs, and we are now doing this as a workaround until we find a good path forward
https://github.com/vitejs/vite/blob/main/docs/guide/ssr.md?plain=1#L172

Ah, I see good to see the workaround. OK, in that case we can skip this issue targeting VitePress alpha and just workaround with that technique for now. We can relax a bit then 👍

I think we should find a more robust solution than a new config option to conditionally replace in some files. Maybe https://github.com/vitejs/vite/pull/11151 would help with this. IIRC there's also a builtin workaround for this in VitePress. Closing for now, but thanks for kicking off this option!


Grab pynaco from master.

ping @ldko, @madhulika95b, this is ready for review. Just changes the py3 branch to master for pynaco.


help

Challenge Use CSS Selectors to Style Elements has an issue.
User Agent is: Mozilla/5.0 (Windows NT 10.0) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/58.0.3029.110 Safari/537.36.
Please describe how to reproduce this issue, and include links to screenshots if possible.
My code:


New release?

Hi, the fix in this merged pr https://github.com/kevin1024/vcrpy/pull/289 solves an issue we have with app engine's latest sdk. However, it's not included in the latest release, so I can't get it from pip.
Do you plan to make a release soon that includes this issue?

Thanks for the ping.  Just pushed a new release.

@kevin1024 don't forget to push the tags to github :)

That's right, no new tag, currently latest is 1.10.3

annd tagged!  Thanks :cake:


Update ls with glob example.

Adding an example of using ls with globs. Will generate the README soon.

I just added an example of using a glob pattern with ls. As a windows user this wasn't immediately obvious to me.

I took a look at the failed builds and I have no idea what to do. I only added a single comment to a function's description and regenerated the docs. Please advise.

It looks like you did everything right, but maybe the test has become flaky. Can you trigger a rebuild of the PR? I can't find the "rebuild" button in the Travis UI anymore.
The "brute force" way to trigger a rebuild is to git commit --amend --no-edit && git push -f origin patch-2 (from your local branch).

Codecov Report

Merging #1006 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1006   +/-   ##
=======================================
  Coverage   97.22%   97.22%
=======================================
  Files          35       35
  Lines        1332     1332
=======================================
  Hits         1295     1295
  Misses         37       37

Impacted Files
Coverage Δ

src/ls.js
100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a8452b8...30be106. Read the comment docs.


Fail fast on failed fixes (BUG-72)

Rather than processing fixes after the current batch is complete, let's process failures as they happen. When processing failures, we should log errors rather than bubbling them up.
For context, at the time of writing, "fixes" are the backend mechanism for "actions" performed in the frontend.

bors merge

bors cancel

bors merge

Okay Bors, they are all set, so let's try this again.

bors merge

Yeah, I gotcha.


{IRC,Gitter,Twitter,Google+} notifications

Hi all,
Since three days notifications about new or updated packages are pushed to IRC, Gitter, Twitter and Google Plus. Plus there is also an API, a RSS and an ATOM feed to query the newest packages (however the latter two are currently more work in progress).
I see that we are spamming Twitter and Google Plus a bit, so I would suggest that we only show {minor, major} version updates on Twitter & Google Plus. If someone already feels annoyed by the activity or has a better proposal, feel free to speak here :)
BTW here is the very work in progress code for the notifications

update: https://github.com/biojs/registry-workmen/commit/183fcfea2406444769c745978be870f061aa167f implements this idea to filter for important messages only

maybe the workman should keep us up to date in gitter but just tell us about new components in twitter and google plus :)

This is already the current setup - the workmen only triggers notifications for Google plus/twitter for important updates (based on the semantic versioning - so only major and minor).
This was only done recently, so we could see how many minor updates we get every month and whether it spams twitter and Google+?
On February 21, 2015 3:09:48 PM CET, David Dao<EMAIL_ADDRESS>wrote:

maybe the workman should keep us up to date in gitter but just tell us
about new components in twitter and google plus :)

Reply to this email directly or view it on GitHub:
https://github.com/biojs/biojs/issues/146#issuecomment-75373168


NTR: [L-glutamate:proton antiporter activity]

Please provide as much information as you can:

Suggested term label:
L-glutamate:proton antiporter activity

Definition (free text)
Enables the transfer of a solute or solutes from one side of a membrane to the other according to the reaction: L-glutamate(out) + H+(in) = L-glutamate(in) + H+(out).

Reference, in format PMID:#######
PubMed=29273736

Gene product name and ID to be annotated to this term
Slc17a7

Parent term(s)
GO:0015299 solute:proton antiporter activity

Children terms (if applicable) Should any existing terms that should be moved underneath this new proposed term?

Synonyms (please specify, EXACT, BROAD, NARROW or RELATED)

Cross-references

For enzymes, please provide RHEA and/or EC numbers.

Can also provide MetaCyc, KEGG, Wikipedia, and other links.

Any other information

+[Term]
+id: GO:0106421
+name: L-glutamate:proton antiporter activity
+namespace: molecular_function
+def: "Enables the transfer of a solute or solutes from one side of a membrane to the other according to the reaction: L-glutamate(out) + H+(in) = L-glutamate(in) + H+(out)."  L-glutamate(1-)
+property_value: creation_date 2022-04-01T20:09:58Z xsd:dateTime


[MonorepoBuilder] Duplicate repositories after merge

Given two or more packages with the following content in their composer.json:
{
    "repositories": [
        {
            "type": "composer",
            "url": "https://packages.example.org/"
        }
    ]
}

monorepo-builder merge will create the following main composer.json with default settings:
{
    "repositories": [
        {
            "type": "composer",
            "url": "https://packages.example.org/"
        },
        {
            "type": "composer",
            "url": "https://packages.example.org/"
        }

    ]
}

Repositories should be de-duplicated by hash of type + url.

Agreed :+1: Could you send failing test case?

Et voilà, the new test case expects a single repository, where as the current code gives just a concatenation.

Thank you for failing test :+1:  I'm looking into Monorepo Builder issues right now

Btw, next time feel free to send that as a PR.

Btw, next time feel free to send that as a PR. That way I can just merge it, instead of copying it manually to Symplify.

Good to know, sorry for the overhead 👍 😃


Finnish translations, here you go!

Here's the translations into finnish, hopefully that's most of them.
There might be a bracket error with the info . json file. I just might be blind to see it lol

This is great, thank you @JarskaIT!


Add SQSProvider

What did you implement:
Adds a provider for AWS SQS that puts an event into an SQS Queue with a provider type of awssqs.
How did you implement it:
Pretty straight-forward -- implemented the required provider code.
How can we verify it:
Provision an SQS queue and save the Queue URL. Create some AWS access keys for a user that have sendMessage permission on the queue. Then:

Register the Queue as a function:

curl -X POST \
http://localhost:4001/v1/spaces/default/functions \
  -H 'Content-Type: application/json' \
  -d '{
    "functionId": "sqs",
    "type": "awssqs",
    "provider": {
        "queueUrl": "<yourQueueUrl>",
        "region": "us-east-1",
        "awsAccessKeyId": "<key>",
        "awsSecretAccessKey": "<secret>"
    }
}’

Register a subscription for the function:

curl -X POST \
http://localhost:4001/v1/spaces/default/subscriptions \
  -H 'Content-Type: application/json' \
  -d '{
    "functionId": "sqs",
    "event": "http",
    "method": "POST",
    "path": "/"
}’

Trigger the subscription:

curl -X POST \
http://localhost:4000/ \
  -H 'Content-Type: application/json' \
  -d '{
    "message": "test message"
}’

Verify that your Queue has a message:

aws sqs receive-message --queue-url https://queue.amazonaws.com/786336638212/testQueue
{
    "Messages": [
        {
            "Body": "{\"event\":\"http\",\"id\":\"fed3bee0-7a75-42ef-85a7-0dcb118acba5\",\"receivedAt\":1521942191472,\"data\":{\"headers\":{\"Accept\":\"*/*\",\"Accept-Encoding\":\"gzip, deflate\",\"Cache-Control\":\"no-cache\",\"Connection\":\"keep-alive\",\"Content-Length\":\"30\",\"Content-Type\":\"application/json\",\"Postman-Token\":\"1d0947c7-48f9-400c-8b76-37f94403f40a\",\"User-Agent\":\"PostmanRuntime/7.1.1\"},\"query\":{},\"body\":{\"message\":\"test message\"},\"host\":\"localhost:4000\",\"path\":\"/\",\"method\":\"POST\",\"params\":null},\"dataType\":\"application/json\"}",
            "ReceiptHandle": "AQEBDf4eQm17dSDC5x7HGg2WhPci6/vCZJ0XKLNUg8jRxSNWpUAG/ic53+t6GkhsZYwyGzhK21Lz/tsOFCJeNA55N5FG5yApdlxmMQdmCs4hjsLfstcr7KG5/OQzgT3zj+o0+QWZjPfl+QFu1cVcTcBoa2JlpsHMnylm8tifRCP2tbE61+QClqlv63yyuryc5ICwHLhPvvWqokQaW+bbhaHaSkgeLxulILY1/MCE+PV/UhVwzCNQ/2RqLWlkPLdkQoaPSJEjwuerQcEgJKvecgFJlkbRexxVA7VPhSpmtsb6lOjaiA/eeRKGaUdDipkfvnTsiWZV7Jkwclxt1JGjsHgMeB/0kMu8ac78eLRehcWZJpMzedMpjSHvBAUhHLnnL6kN",
            "MD5OfBody": "3d8830dd49818fee5a2fd3b8d598acb4",
            "MessageId": "78540693-d590-4a14-8691-2cd1eebb31e5"
        }
    ]
}

💥
Todos:

[x] Write tests
[x] Write documentation
[x] Fix linting errors
[x] Make sure code coverage hasn't dropped
[x] Provide verification commands / resources
[x] Enable "Allow edits from maintainers" for this PR
[x] Update the messages below

Is this ready for review?: YES
Is it a breaking change?: NO

@alexdebrie I will also test Codacy integration on this PR :)

@alexdebrie ignore the Codacy status.

@mthenw Done


Update grammars for 0.9

What's up?
We should update the grammars for 0.9. This might just be fixing the tuple / list syntax. They're listed at https://prql-lang.org/book/internals/syntax-highlighting.html
(FWIW some of them could do with a refresh on keywords, or how they handle strings etc, but that's by no means necessary for 0.9)

[x] Lezer (#2868)
[x] Handlebars (#2871)
[x] Monarch (#2874)
[x] VS Code / Textmate (PRQL/prql-vscode#244)
[ ] Tree-SItter (PRQL/tree-sitter-prql#13)

The remaining task is tracked in another repo PRQL/tree-sitter-prql#13, so I close this for now.


update PHPDoc block

Problem:

Solution:
Add static to the Client Facade PHPDoc block

@Webklex

Hi @alphaolomi ,
many thanks for your pull request!
Best regards,


COMPRESS-430: Synchronize iteration of synchronized list

Synchronize the iteration as per Javadocs http://docs.oracle.com/javase/9/docs/api/java/util/Collections.html#synchronizedList(java.util.List
JIRA ticket https://issues.apache.org/jira/browse/COMPRESS-430

Coverage increased (+0.05%) to 85.932% when pulling c0499042c2778161d6cecd54357adb6ea9595132 on kinow:synchronize-iteration-of-synchronized-list-1 into 10ff1c341d37da1cdb2a9ecb280a7e73670c00f5 on apache:master.

Coverage increased (+0.05%) to 85.932% when pulling c0499042c2778161d6cecd54357adb6ea9595132 on kinow:synchronize-iteration-of-synchronized-list-1 into 10ff1c341d37da1cdb2a9ecb280a7e73670c00f5 on apache:master.

Thank you Bruno


[BUG] Improve Feedback button position

Description
The Feedback page button should be placed in the bottom right corner, which will make this website look better.
I want to Fixed these issue properly.
@YadavAkhileshh  please assign me this task.

Screenshots
No response
Any additional information?
No response
What browser are you seeing the problem on?
No response
Checklist

[X] I have checked the existing issues
[X] I have read the Contributing Guidelines
[X] I'm a GSSoC'24-Extd contributor
[X] I'm a Hacktoberfest'24 contributor
[X] I am willing to work on this issue (optional)

@YadavAkhileshh


[Documentation] Some pages are not displayed

flows: blank page
import: page not found
export: page not found

It's not happening.


Set default fill/no_fill behavior on newly defined variable (nc4)

In nc4 mode, the variables were ignoring the default "database" fill/no_fill mode set via a call to nc_set_fill().  This sets the no_fill mode on the variable to match the default database setting at the time the variable is defined.

It might be good to apply this patch in conjunction with the other fill-related patches that you have been applying to make sure they still work correctly once this fix is applied.

Reviewing now, will merge as soon as all the local checks pass (as I expect they will, but the surest way to make tests fail, in my experience, is to skip them :)).

Thanks.  I appreciate the work you do on NetCDF.

Thanks Greg, and likewise; since our move to GitHub, we've seen a fantastic uptick in contributions from the developers in our community, such as yourself! Your work and contributions are very much appreciated, especially your perseverance in the face of potential lengthy review times.  I had just added a paragraph to that effect in the status report to our user community, actually, when I saw the notification from your comment. Thanks again!


Fix for trivia not preserved after string interpolation conversion

fix an issue in #1551
My bad, I should've tested the code action more thoroughly. The leading trivia of the source SequenceExprSyntax is not carried over to the new string literal, resulting in this:
<code block A>
"" + value + ""
<code block B>

->
<code block A>"\(value)"
<code block B>

This fix will preserve the leading trivia, i.e.
<code block A>
"\(value)"
<code block B>

How was // code block A preserved before this change if the leading trivia of the code block weren’t preserved? Or did you mean for // code block A to be a statement?
Should we also retain the trailing trivia from syntax in the same way?

Yeah,  // code block A was meant for a statement instead of a comment, I've changed that in the description above.
AFAIK, string literals don't have trailing trivia, and trailing trivia of any non-string-literal component will be converted and moved into the string interpolation, so the trailing trivia of syntax has been preserved in this way.

What about "a" + b + "c" / * some comment */? In that case /* some comment */ should be trailing trivia for the ".

@swift-ci Please test

@swift-ci Please test Windows

@swift-ci Please test

@swift-ci Please test Windows


Build a package for the Nix package manager

As discussed on Discord, I am currently trying to package kalamine into Nix.
https://search.nixos.org/packages
I am not far from having finished but while trying to execute tests, I have a question. What is the exact goal of the layouts directory? It contains sample layouts apparently. But is it because kalamine wants to have those layouts built alongside kalamine to provide them to users of kalamine, or is it just for testing purposes while running pytest?
It is just that nix has got different phases in its build process. So I would like to know if the step kalamine layouts/*.toml should be part of the build step or the test step. The main difference is that if it is part of the build, the resulted compiled layouts will be part of the outcome, alongside the binary. And so nix users will have them in the package directory on their system when installing the package.
Going even further, if they are part of the package, we can even add some instructions in the build recipe to copy them over to the correct directory /nix/store/<package_dir_when_installed>/usr/share/X11/xkb. I am talking about Linux here. When using the full NixOS operating system, this could have the effect of having them directly available as default keyboard layouts (because /nix/store/<package_dir>/etc will be more or less merged with /etc, and this allows packages to contribute configurations).
So just to sum up, is this desired to have those layouts contributed as default-to-be-installed layouts, or are they just here for reference and for the tests?
Hope it makes sense even if you are not familiar with the nix ecosystem.
Thanks

It seems there is a pull request for a nix kalamine package : https://github.com/NixOS/nixpkgs/issues/287971


MegActor-Sigma based on DiT

Thank you so much for releasing the model. I have two questions, though.
First, the current MegActor-sigma model based on SD1.5 has been released—are there any plans to release a MegActor-sigma model based on DiT as well?
Second, when comparing the model based on SD1.5 with the one based on DiT, which one performs better?

I have similar questions

same here


Does not work with Slack from Microsoft Store

I had Slack installed through Microsoft store and the script was not able to find it. I tried looking for the file ssb-interop.js to find the directory but got nothing. I don't know where and how the Win 10 app gets installed.
After uninstalling Slack and reinstalling it "by hand", everything works as expected.

Thank you for the bug report. However, this has been addressed before. Microsoft Store does not give write permission to their apps even for administrators. math-with-slack will not try to override such restrictions.
See the discussion in the readme for more information:

Package and software managers
The script needs write permissions in the Slack directory in order to inject the MathJax code. Some package and software managers write protect their directories, and math-with-slack cannot be installed if Slack is installed through such a manager. This is the case for both the Windows Store and Snap versions of Slack. You should use the version downloaded from Slack's website if you want to use math-with-slack. The script should, however, work with most package managers if you manage to grant the script write permission.

Thank you for pointing that out, I missed it in the readme, sorry about that.

No worries at all. Better safe than sorry when it comes to bug :)


New updated version

Due to the lack of updates I am creating Electron and Vue.js boilerplate from scratch.
Additionally I decided to use the Nuxt.js framework, which simplifies writing parts of Vue.js and makes it easier to maintain the template (ready Webpack configuration , Babel, ...)
Repo: https://github.com/michalzaq12/electron-nuxt
More information can be found here.
I also suggest reading section about electron-builder dependencies , which also applies to the electron-vue template

👏 clap

hey @michalzaq12 check the answer here #855 and especially the last comment #855 (comment)

I understand that it is easy to update electron but this is not the only problem.
I've already solved a few:

high CPU usage in dev mode
hanging electron processes
obsolete unit tests configuration
can't install vue-devtools in China

I've also added new functionalities:

parallel build
relaunching electron from menu if app get stack
thanks to the use of Nuxt, always the latest Webpack, Babel version with ready configuration (including all loaders config for: Sass, Stylus, Less)
full support for Nuxt universal mode (prerender pages to improve builded app startup time)

I remind you that the project is still in development.


Add Badges to README for builds, coverage & code checks

What is the context of this PR?
Added badges to the README.md to show the current build, code coverage and quantified code status.
How to review
Preview the changes to README.md and see the badges displayed as below

[ ] Do all commits have sensible commit messages?
[ ] Is all new code unit tested?
[ ] Are there integration tests if needed?
[ ] Is there sufficient logging?
[ ] Is there documentation or is the code self-describing?

Who worked on the PR
@collisdigital

Waiting for #300 to be merged to verify that code coverage badge works on master.

Coverage remained the same at 73.699% when pulling dbd36bcb54997f38e15fd3f85335f2893d1c8075 on eq-399-add-badges-to-readme into 3ca7eb5759b5729fa276aed9e1da923f296c1a38 on master.

LGTM 👍

Coverage remained the same at 73.699% when pulling b8e580e112d6629d60a11f6eefa89f1116a4509c on eq-399-add-badges-to-readme into 3ca7eb5759b5729fa276aed9e1da923f296c1a38 on master.

Coverage remained the same at 73.699% when pulling b8e580e112d6629d60a11f6eefa89f1116a4509c on eq-399-add-badges-to-readme into 3ca7eb5759b5729fa276aed9e1da923f296c1a38 on master.

Coverage remained the same at 73.699% when pulling b8e580e112d6629d60a11f6eefa89f1116a4509c on eq-399-add-badges-to-readme into 3ca7eb5759b5729fa276aed9e1da923f296c1a38 on master.


✨ Nova Scotia Parks

Description
Implements Nova Scotia Parks via GoingToCamp
Closes #267

:tada: This PR is included in version 0.25.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


New digest algorithms: sha256+gunzip, sha256+unzstd

https://github.com/opencontainers/image-spec/blob/v1.0.2/descriptor.md#registered-algorithms
I suggest adding new algorithms sha256+gunzip and sha256+unzstd.
These algorithms compute the digest after uncompressing the blob.
The digests are stable regardless to the parameters of the compression algorithm (e.g., deflate block size) and should be useful for reproducible image building.

X-ref: https://github.com/opencontainers/distribution-spec/issues/235
IMO we should not add this as a new digest algorithm, but have manifests reference the uncompressed content and leave compression as an implementation detail of transport/storage.


targets/audio: Remove outdated hacks

They have landed upstream a year ago. Also update minimum version to R39.

Need to take care of that sbc patch as well.


parseIcon is not working with UITextField placeholder

textField.placeholder = "ic:chevron-bottom"
textField.parseIcon()

not working

and try
let font = UIFont.icon(from: .Iconic, ofSize: 20)

        self.attributedPlaceholder = NSAttributedString(
            string: String.fontIconicIcon("chevron-bottom")!,
            attributes: [
                NSFontAttributeName: font
            ])

it's became a ring

parseIcon, only parses textfield value.
testTextField.attributedPlaceholder = NSAttributedString(
            string: String.fontIconicIcon("chevron-bottom")!,
            attributes: [
                NSFontAttributeName: UIFont.icon(from: .Iconic, ofSize: 20)
            ]
        )

This code is working!


Tabs double onActive on page load

        <Tabs>
          <Tab label="one" onActive={() => {console.log('tab one');}}>
            foo
          </Tab>
          <Tab label="two" onActive={() => {console.log('tab two');}}>
            qwe
          </Tab>
        </Tabs>

When I load the page I get
tab one
tab one

Can anyone reproduce it or is it just my problem somewhere?
Wanted to add tab-specific google analytics pageview trigger, but if it triggers twice it's kind of misleading.

Hi @ktmn thanks for reporting it!
We are fixing it ASAP. As we said in other issues, during the weekend we want to ship a lot of fixes and new features and hopefully this will be there too :)

onActive callback will dissapear in the new version of <Tabs> component... now we are moving to pure components (stateless). We think is better listen the onChange callback and then you choose what you wanna do ;)
best

Does the onChange trigger before or after the change? When I tried I always got the index of the previous tab.

Hi @ktmn! Check here hows the new version going to look like. In this new version you can decide who's responsible from keeping the index since it has been extracted from the component state. In this new version you will get the callback as soon as a new tab is clicked so you can get the new index and set the proper state propagating the new index property to the tabs.
What do you think about this?

Looking good, thanks!


Will not work for me.

Hey I’ve been trying to convert this over to pocked edition which is the only version I have access to and I can’t seem to do it. Is there any way someone can make that happen?

This is not possible at all.


fix: improve line extraction from files with missing content

PR Type
Bug fix, Enhancement

Description

Added robust error handling for line extraction from git patches with try-except blocks and detailed error logging
Implemented fallback mechanism to extract lines from patch when file content is missing
Improved code reliability by filtering out deleted lines and handling edge cases
Enhanced debugging capabilities with detailed error messages and tracebacks
Added documentation and improved code structure

Changes walkthrough 📝
Relevant filesError handling

git_patch_processing.pyAdd error handling to hunk line extraction process

pr_agent/algo/git_patch_processing.py
Added error handling with try-except block around hunk line extraction logic  Added logging of errors with traceback for better debugging  Code structure improved with better indentation and error recovery

+41/-38

Enhancement

utils.pyEnhance line extraction with patch-based fallback

pr_agent/algo/utils.py
Added fallback mechanism to extract lines from patch when file content is missing  Improved handling of missing file content with better logging  Added docstring to explain function purpose  Added filtering of deleted lines from patch content

+23/-5

💡 PR-Agent usage: Comment /help "your question" on any pull request to receive relevant information

/help "Is the Gemini Flash 2.0 model supported using Google AI Studio?"


changes to logo done

issue #714

the logo is fixed and i think the website needed a logo rather than a plain text .
Hope @ANSHIKA-26 ma'am finds this better than before.
#714

@ANSHIKA-26  please score this PR with justice
Thanks
Regards

Thank you so much for your effort and creativity in designing this logo! While we truly appreciate your enthusiasm, the style of the logo doesn't quite match the aesthetic or direction we’re aiming for with the project.
We encourage you to explore other ways to contribute that align more closely with our current focus, and we’d be happy to guide you in the right direction. Thank you for your understanding!
note - kindly dont work on an issue unless assigned !

Thank you so much for your effort and creativity in designing this logo! While we truly appreciate your enthusiasm, the style of the logo doesn't quite match the aesthetic or direction we’re aiming for with the project.
We encourage you to explore other ways to contribute that align more closely with our current focus, and we’d be happy to guide you in the right direction. Thank you for your understanding!
note - kindly dont work on an issue unless assigned !

maam the issue was assigned to me . then only i started to work upon it


cargo valgrind always reports "leaked 56 B in 1 block"

Even Hello world! Is it an issue with valgrind or std::rt?
fn main() {
    println!("Hello, world!");
}

$ cargo valgrind run
    Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.01s
     Running<EMAIL_ADDRESS>target/debug/test-valgrind`
Hello, world!
       Error leaked 56 B in 1 block
        Info stack trace (user code at the bottom)
             at malloc
             at alloc (alloc.rs:99)
             at alloc_impl (alloc.rs:192)
             at allocate (alloc.rs:254)
             at {closure#0}<std::thread::Inner> (sync.rs:483)
             at allocate_for_layout<core::mem::maybe_uninit::MaybeUninit<std::thread::Inner>, alloc::sync::{impl#14}::new_uninit::{closure_env#0}<std::thread::Inner>, fn(*mut u8) -> *mut alloc::sync::ArcInner<core::mem::maybe_uninit::MaybeUninit<std::thread::Inner>>> (sync.rs:1925)
             at new_uninit<std::thread::Inner> (sync.rs:481)
             at new_inner (mod.rs:1343)
             at new_main (mod.rs:1333)
             at init (rt.rs:113)
             at {closure#0} (rt.rs:172)
             at do_call<std::rt::lang_start_internal::{closure_env#0}, ()> (panicking.rs:557)
             at try<(), std::rt::lang_start_internal::{closure_env#0}> (panicking.rs:520)
             at catch_unwind<std::rt::lang_start_internal::{closure_env#0}, ()> (panic.rs:358)
             at std::rt::lang_start_internal (rt.rs:172)
             at std::rt::lang_start (rt.rs:194)
             at main
     Summary Leaked 56 B total (0 other errors)

$ rustc --version --verbose
rustc 1.83.0 (90b35a623 2024-11-26)
binary: rustc
commit-hash: 90b35a6239c3d8bdabc530a6a0816f7ff89a0aaf
commit-date: 2024-11-26
host: x86_64-unknown-linux-gnu
release: 1.83.0
LLVM version: 19.1.1

$ valgrind --version
valgrind-3.22.0

$ cargo install cargo-valgrind
    Updating crates.io index
     Ignored package `cargo-valgrind v2.2.1` is already installed, use --force to override

test-valgrind.zip

Hello,
thank you for this well-written report. Indeed, this is caused by the Rust 1.83 standard library, as is discussed here: https://github.com/rust-lang/rust/issues/133574. This tool has currently no way to suppress such "leaks" (especially important, since they are intentional), but this has just being requested in #107.

Thanks for the quick reply. I imagined it had something to do with that issue, but i thought a reproduction and a clear bug description would be valuable both for contributors and users (who are probably going to panic! when CI fails).


Not validating XML

The schemas are not being validated against when the request is of content-type application/xml

The new [v3.0.0] is content agnostic, supporting multiple content-type MIME types. read more about this feature in the documentation.


Refactor custom scss to use variables as much as possible

Too much values are hardcoded in Sass partials, beside the fact that there are variables dedicated to those cases…
And FWIW, some overrides looks misunderstood: I think some of them should be actual overrides (aka Boosted mods) instead of separate files with duplicated styles.
See _o-navbar.scss for examples.

Related to #214

o-nav-local
Should probably be entirely removed since it could be handled as a variant of nav / navbar… Main difference are top/bottom borders, which can be added using utility classes.

o-link-arrow
There's probably lots to do, since it only requires the arrow…


Ninja won't find build.ninja

I followed exactly what the wiki says to build the SDK, but building fails:
$ gclient sync
... # A lot of syncing here
Running hooks: 100% (14/14), done.
$ cd sdk/
$ ./tools/build.py --mode release --arch x64 create_sdk
ninja -C out/ReleaseX64 create_sdk
ninja: error: loading 'build.ninja': No such file or directory
BUILD FAILED
$ ls out/ReleaseX64
args.gn build.ninja build.ninja.d dart-sdk obj toolchain.ninja

I'm building against the master branch, and on Arch Linux with latest packages of everything (gcc, depot_tools, etc.) and depot_tools is within my PATH already.
Running ninja command above manually gives same results. However, doing a cd to out/ReleaseX64 and running ninja -C . create_sdk manually there makes it start compiling things. That leads me think that... ninja is ignoring the -C parameter?
I tried logging the os.getcwd() in ./tools/build.py manually right before opening the process to run the ninja command (line 253), and it logs dart-sdk/sdk directory. Which seems pretty fine, as well.
File permissions are fine.

$ which ninja
/opt/depot_tools/ninja

Okay apparently using /opt/depot_tools/ninja is what causes the error. Use the ninja bundled with the project makes it work.
I'll keep this open because the doc has to be clear on this, as well as this needs a workaround because I believe many folks would have depot_tools in their path anyways.

I'm having this issue on Windows 10. I have depot_tools in my path. Ninja says the same error. I don't know where to find /usr/bin/ninja on Windows

I had the same issue, the problem was error on some steps during the build on windows. The output (defaults to "sdk/out") folder is created anyways with some files, but its content is incomplete. Whenever there is an error, the build.ninja file is not created.
I suggest to anyone having this error to delete the output folder and build again. Once the build finishes check if there were any errors scrolling up in the console.
In my case I'm building on Windows 10 and the problem was some missing Windows Development Kit features (debugger) not installed by Visual Studio.
To get Visual Studio ready (from scratch) for building the SDK (I believe only 2017 and 2019 are compatible):

Download Visual Studio 2019 Community (free) and install
Open Visual Studio and in the menu go to Tools -> Get Tools and Features. Select "Desktop Development with C++" in the Workloads tab (default tab) and install.
Once installed go to Windows Apps & Features (where you uninstall programs), search for "Windows Software Development Kit" and click modify. Click on Change, select "Debugger" and proceed.

I also set the environment variable GYP_MSVS_OVERRIDE_PATH=C:\Program Files (x86)\Microsoft Visual Studio\2019\Community but I think it's not necessary because the path is automatically detected by the scripts (if it is installed in the default path).
After that follow the other steps. Basically install the depot tools, do a "fetch dart" in a new "dart-sdk" folder, then run "gclient sync" from within the folder. Then I was able to build using
python ./tools/build.py --mode release --arch x64 create_sdk without issues.

I also set the environment variable GYP_MSVS_OVERRIDE_PATH=C:\Program Files (x86)\Microsoft Visual Studio\2019\Community but I think it's not necessary because the path is automatically detected by the scripts (if it is installed in the default path).

Well actually it didn't work without for me, because in setup_toolchain.py it will always read it when you have DEPOT_TOOLS_WIN_TOOLCHAIN set to 0 (like proposed in the wiki):
https://github.com/dart-lang/sdk/blob/a34deb2587185cdbc920f0931eaaee7c5bad68a8/build/toolchain/win/setup_toolchain.py#L60-L69
And because the variable was missing, it always raised a KeyError.


Show prompt and take statement id

On button click open native browser prompt and take statement id and save it to a variable.
The text of the prompt should be: "Zadejte ID výroku:"

Solved as part of #502


Optimize internal representation and comparison operation

Replace the internal field byte[20] bytes with two fields: int seconds and byte[16] payload.
Optimize the Ksuid.compareTo() method after the change in the internal representation.

The internal field byte[20] bytes was replaced by two fields: int seconds and byte[16] payload.

Optimization: the Ksuid.compareTo() method is 30% faster.

BEFORE:
Benchmark                        Mode  Cnt     Score     Error   Units
Ksuid_compareTo   (*)           thrpt    5  6318,844 ±  48,798  ops/ms
Ksuid_fromString                thrpt    5  3387,946 ±  34,050  ops/ms
Ksuid_toString                  thrpt    5  2147,112 ±  37,902  ops/ms
KsuidCreator_getKsuid           thrpt    5  1918,965 ±  52,291  ops/ms
KsuidCreator_getKsuid_toString  thrpt    5  1015,992 ±  27,793  ops/ms

AFTER:
Benchmark                        Mode  Cnt     Score     Error   Units
Ksuid_compareTo   (*) (+30%)    thrpt    5  8276,152 ±  47,357  ops/ms
Ksuid_fromString                thrpt    5  3509,903 ±  57,578  ops/ms
Ksuid_toString                  thrpt    5  2176,286 ±  30,880  ops/ms
KsuidCreator_getKsuid           thrpt    5  1929,631 ±  32,927  ops/ms
KsuidCreator_getKsuid_toString  thrpt    5  1012,919 ±  17,240  ops/ms

(*) The Ksuid.compareTo() method was executed 100 times per benchmark operation.

Released version v2.2.0.


Soft FSI backend GPIO assignments

The BMC soft FSI needs to handle different GPIO assignments across different boards. This can be accomplished in a few different ways:

Provide a default hardcoded set of assignments in the code that get patched by OpenBMC machine layers
Add pin assignments that are selectable at runtime (current solution in HEAD), and OpenBMC scripts can use board names to choose the assignments
Read pin assignments from OpenBMC machine config (https://github.com/openbmc/skeleton/tree/master/configs)

3 is probably not desirable since it's a decent bit of code to make it work and both this soft FSI implementation and Python skeleton are meant to have short volatile lives.

The production plan for OpenBMC and pdbg is to move the GPIO bmcfsi backend into the OpenBMC kernel. pdbg would then use the kernel drivers to do the actual FSI protocol and they would read the GPIO assignments from the device-tree so that the userspace side doesn't need to know anything about GPIO pins.

Is there an 'alias' we can add to GPIOs in the device tree to make it easier on userspace?

On Thu, 2016-12-08 at 04:00 -0800, Patrick Williams wrote:

Is there an 'alias' we can add to GPIOs in the device tree to make it
easier on userspace?

Good idea. Can you create devalias entries ? Something like fsi-
master0-clk, fsi-master0-data ?
Cheers,
Ben.

Now that OpenFSI is in the kernel I'm assuming this is no longer an issue. Please re-open if there is still an issue here.


Index Error

I got an index error after I ran the following line of code:
python gen_vggface2_embeddings.py -r <path_to_vggface2_dataset_folder> -d <path_to_store_generated_dataset> --type train
IndexError: The shape of the mask [58] at index 0 does not match the shape of the indexed tensor [59, 4] at index 0.

I am getting a similar index error on running the following command:
python gen_youtubefaces_embeddings.py -r <path_to_youtubefaces_dataset_folder> -d <path_to_store_generated_dataset> --type train/test
IndexError: The shape of the mask [111] at index 0 does not match the shape of the indexed tensor [112, 4] at index 0

I cannot reproduce the error. Can you give more details about how and at which stage of the execution you get this error? Also please be sure using the 'develop' branch of the repo and having the dataset VGGFace-2 not VGGFace...

So I am using VGGFace-2 dataset and not VGGFace and I am sure that I am using the develop branch of the repo.
Here are the steps following which I am getting the error:

Open terminal
cd $AI_PROJECT_ROOT (to change to the project root)
cd ai8x-training
git checkout develop
git submodule update --init
pyenv local 3.8.10
python3 -m venv .
source bin/activate      (to activate the training environment)
cd dataset/face_id     (because embeddings.py is inside the face_id folder)
python3 gen_vggface2_embeddings.py -r /home/user/Documents/Source/AI/ai8x-training/datasets/face_id/VGG-Face2/vggface2_train -d /home/user/Documents/Source/AI/ai8x-training/store --type train

Index Error: IndexError: The shape of the mask [35] at index 0 does not match the shape of the indexed tensor [36, 4] at index 0
Note: I downloaded the VGGFACE-2 dataset from a different source because the link provided in the readme file is no longer available. But that shouldn't be an issue since I am getting the same index error for Youtube Faces dataset and I downloaded that from the source given in the readme file.

After activating environment you have to call the following two lines in order to install the required python packages:

pip3 install -U pip setuptools
pip3 install -U -r requirements.txt # or requirements-cu11.txt with CUDA 11.x

I did that while setting up the virtual environments for the first time. Do I need to run those commands every time I activate the environment?

No, it is a one time thing to install the packages. Then, it might be due to the downloaded dataset. Can you share the full log of the error (so I can see in which package and line you get the error) and the link for the dataset?

So the link to VGG-Face2 dataset given in the readme file: https://www.robots.ox.ac.uk/~vgg/data/vgg_face2/  doesn't work.
Therefore, I downloaded the dataset from the following link: https://academictorrents.com/details/535113b8395832f09121bc53ac85d7bc8ef6fa5b
I tried to find the error logs but couldn't find the latest ones. Do you know where I can find them?

Thanks for the link. You can share the full error trace on the console.

Sorry, for some reason, I am having trouble sharing the full error trace. Therefore, I decided to share the screenshot!

I could only download the test set from the link you provided. I could not replicate the error. Here are the steps I followed:

Download the files in the link to <vgg_folder>

The folder content is: {'data/', 'meta/', 'README.md', 'README.txt'}

Go to <vgg_folder>/data and run 'tar -xf vggface2_test.tar.gz'

This creates a folder 'test' under <vgg_folder>/data

Go to /datasets/face-id and run 'python3 gen_vggface2_embeddings.py -r /data/ml/VGGFace-2 -d ../../store --type test'

This creates a test folder with the required content under /store folder

If you still get an error after these steps, please be sure you are sync the develop branch of the repo with the latest content with git fetch + git pull. Also please check the data you downloaded is not corrupted.

I encountered the same problem in operation. Have you solved it?

Now I use the GPU of the cloud server for training, but this error does not occur. It is probably caused by insufficient cache of the graphics card.


New fixer: proper casting to number

In php 7.1, in accordance with an invalid strings in arithmetic RFC a warning is emitted in case of an arithmetic operation acting on a non-numeric string. This creates a problem for a variety of projects which use  $var * 1 pattern for casting an arbitrary value to a number. In particular, a standard way of mapping empty value to zero $empty_string * 1 now generates a warning A non-numeric value encountered on line X.
Therefore it is suggested to create a new fixer, which would replace all expressions of form value * 1, value *= 1, value + 0 and value += 0 with (float) (value), value = (float) (value), (float) (value) and value = (float) (value) correspondingly, where value is either variable or an element of an array.
Examples:
$countValue = $_GET['count'] * 1; // was
$countValue = $_GET['count'] + 0; // was
$countValue = (float) $_GET['count']; // both should become

$value_from_file *= 1; // was
$value_from_file += 0; // was
$value_from_file = (float) $value_from_file; // both should become

All the implicit cast trickery like $a + 0 (https://3v4l.org/jSqkK) has been around for sometime (I remember something like it from Java for strings concat).
However, I wonder if this case isn't to rare to fix. Is there any community that is really effected by this anti-pattern?

$countValue = $_GET['count'] + 0; // was
$countValue = (float) $_GET['count']; // both should become

this depends on the input value ( $_GET['count']), for example;
<?php

$a = '1';
$a = $a + 0;
var_dump($a);

$a = '1.1';
$a = $a + 0;
var_dump($a);

die;

int(1)
float(1.1)

https://3v4l.org/HHoNY
The problem is that there will be a lot of cases where we cannot, within acceptable risky-range, know (or guess) what the cast should be.
As such, I really like the idea but this is out of the scope of the project, thanks for bringing the idea!


Bump mypy to latest version

Prompted by discussion on #5486; this turned out to be not as difficult as I thought.

type check test is failing

Yeah, there seem to be differences between running mypy in my local environment and in CI, so I missed these failures locally. I'll take a look to see how tricky these errors are to fix.

there seem to be differences between running mypy in my local environment and in CI

This sounds worrying. Do you have any idea why?

rences between running mypy in my local environment and in CI, so I missed these failures locally. I'll take a look to see how

Yeah I had this too, and was a very recent install.  Maybe because our python versions are higher?

I think I've got everything now; PTAL @mpharrigan, @dabacon.
I found a smattering of random lint errors that were revealed when touching various files. FWIW I think we should change CI to lint everything, because the current incremental linting means there can be lint errors hiding in a file that have to be handled by the next person to touch the file for unrelated reasons.

Automerge cancelled: A required status check is not present.
Missing statuses: ['Build docs', 'Build protos', 'Coverage check', 'Doc test', 'Format check', 'Misc check', 'Notebook formatting', 'Pytest MacOS (3.7)', 'Pytest MacOS (3.8)', 'Pytest MacOS (3.9)', 'Pytest Ubuntu (3.7)', 'Pytest Ubuntu (3.8)', 'Pytest Ubuntu (3.9)', 'Pytest Windows (3.7)', 'Pytest Windows (3.8)', 'Pytest Windows (3.9)', 'Type check', 'Typescript lint check', 'Typescript tests', 'Typescript tests coverage']


Add Django 1.9 compatability

@auvipy we will added it when there will be release of django 1.9 stable. For now it's in beta.

seems the maintainers do not have time to work on this project. I would love to work on django + DRF
version compatibility. [I am a co maintainer of drf-extensions, and helped upgrading drf-gis project]
Let me know which parts I need to work/you need contribution to make it compat with latest stable versions?

@auvipy I think it's a difference between the maintainers having free time to work on django-admin2 and having paid time to work on this project. Unfortunately, I've yet to see a single firm or agency step up to provide paid time for this project. In the early days it was promised, but never materialized. Since my open source time is limited, I stepped back from this project once it became apparent how much of my open source time it consumed.
Part of that stepping back was also no longer reviewing pull requests. Those reviews take a lot of time, and are not as much fun as writing code. @galuszkak and @andrewsmedina stepped up, but I think they've come to realize that this project is a time sink that doesn't give back to the maintainer the same way other projects do.
For what it's worth, I've offered @galuszkak and @andrewsmedina to mark this project as unmaintained. They continued to volunteer their time, but I think other concerns have become more important to them. Which I respect and agree on 100%. django-admin2 is a sophisticated project, and one that does eat up a lot of time. You either put in a lot of time or you don't.
Therefore, unless someone can offer myself or them paid time on the project, even as part of a contract for something else, I'm going to mark this project as unmaintained. That means adding a message like this to the README:

This Project is Unsupported

If you decide to use this project, be forewarned that support and patches will not be forthcoming at this time. Why?

The maintainers of this project are not working and have never worked professionally with django-admin2.
The maintainers of this project have to triage their open source time to projects they use on a regular basis, or are paid to maintain.

If you want to pay the maintainers of this project to support it again, please contact @pydanny at<EMAIL_ADDRESS>

@pydanny I do agree to all your points. I do also have to spent my time to work on some open source project. I generally try to contribute to the projects which have some impact on my day to day works. Since I find this project very promising and want to see it alive for long, I do want to offer my time to maintain this project as a co-maintainer. If you think that make sense please let me know. :)

@auvipy django 1.9 was release just not long ago. As I said I still plan (It was 1,5 month when I declared this work) to add this funcionality. I plan to spend some time on Christmas holidays to work toward fixing those issues.
Most this year, was a little unplanned lack of time for open source as I spend more time to give time for open source community in Hackerspace Silesia. So sorry for dragging those issues longer than expected. (My last comments in this project was 1 month ago so not so long ago ;) )

@pydanny the django-admin2 is a so great project, and has a lot of potencial. I think that it is not necessary mark this project as unsupported.
And if we add full compatibility with Django 1.8 and 1.9 more people will use and contribute with this project.
I believe that I can work more in django-admin2. @galuszkak I can work on this issue, but before that I think that we can make all tests pass with Django 1.8, that I'm working on it right now.
@auvipy your contributions are very welcome. You can help send pull requests (http://django-admin2.readthedocs.org/en/latest/contributing.html) and if you want you can talk with us at https://gitter.im/pydanny/django-admin2

@andrewsmedina I'm not sure if you started working on issue if not then I started to get up to date with all tools. and continue my work in #410 . I see the biggest issue is that we lag behind really with rest framework and new django. I think we should solve them all in one pass so we can start development from something fresh to get up to speed.

@galuszkak I'm working on fix the tests on django 1.8

@andrewsmedina  I'm not sure where are you standing (can you push your work somewhere?). I created list of existing problems in tests in #410 I will be updating this list while moving on with fixing code tests.

@galuszkak the tests on Django 1.8 are broken. I believe that is not related with django-rest-framework. You can see the output from tox -e py27-dj1.8.x here: https://gist.github.com/andrewsmedina/c5ee574a5b5b2944b66d
I will enable Django 1.8 and 1.9 on travis-ci now.

@andrewsmedina please do it on different branch or your fork. Don't do this on develop branch.
Yes they aren't related, I didn't stated otherwise ;), but sounds most of your errors are related to floppyforms not only django.

(I already did it on my rest-framework-fix branch so if you want you can take it)

@andrewsmedina also all work please do through pull requests so anyone can review changes.

I'm working from my fork, so this repository until everything is stable it's not affected. If you can @andrewsmedina, please revert those your changes and move it to different branch or fork.

@galuszkak I believe that the tests should be enabled on travis. But I will enable the travis allow_failures in 1.8 and 1.9 tests for now.

@andrewsmedina if you work on fork, or another branch you can change travis and it will catch changes only related to that branch so develop branch is never affected.
Please revert those changes, so we have always stable develop branch, from which people can fork, and always work through PR it's really important :+1:

@galuszkak reverting. But the tests are already broken, run these tests is a way to show where the problem are. Without it everything looks ok, but it is not ok. =/

@galuszkak reverted

@andrewsmedina  no, they went fine see: https://travis-ci.org/pydanny/django-admin2 they all passed https://travis-ci.org/pydanny/django-admin2/builds/99833226

@galuszkak the result was the same with allowed_failures enabled

@galuszkak I will create a PR with the django 1.8 and 1.9 tests and allow_failure enabled. What do you think to use gitter or irc to talk about it?

Fixed with #431

time for a new release? :dancer:


ValueError: Invalid character while parsing year ('N', Index: 0)

For a heterogenous collection of STAC Items with some containing a timestamp property like updated and others that do not, coercing to timestamps fails because the code seems to be trying to convert a pyarrow 'None' string to timestamp:
https://github.com/stac-utils/stac-geoparquet/blob/4b00f5be649609a896242f391d6e9c56377c7f25/stac_geoparquet/arrow/_to_arrow.py#L82
I think this scenario might be common for APIs that are returning metadata that changes over time. I came across this using this public endpoint https://docs.canopy.umbra.space/docs/archive-catalog-searching-via-stac-api
I tried a quick fix which seems to work, but not sure it's the best approach... I just removed ciso8601 and let Arrow handle the casting 😅.
Alternatively, using pandas to coerce timestamps is also mentioned here https://github.com/stac-utils/stac-geoparquet/pull/31#discussion_r1544730642

But I also didn't know that pyarrow was able to cast the strings to dates

I'm new to arrow, so I definitely fumbled around a bit!
I thought this would work: pa.scalar('2024-08-24T17:52:27.135933+00:00', type=pa.timestamp('us', tz='UTC')) but raises ArrowTypeError: object of type <class 'str'> cannot be converted to int
But it works if you first go to a pyarrow string and then cast: pa.scalar(timestamp_str, type=pa.string()).cast(pa.timestamp('us', tz='UTC'))

closed by #80


fix(insights): add Algolia agent on subscribe

Summary
This adds an Algolia agent on the Insights client when the plugin subscribes so that Insights calls coming from the plugin can be identified as such.
I'm making a direct call on the passed client and didn't implement an addAlgoliaAgent on the wrapped client that we expose in methods. This saves a few bytes, and we don't want users to ever add agents anyway.
Now that the Insights client sends at least one event on subscribe, some tests had to be tightened as they were causing false positives.
FX-2062

maybe instantsearch-autocomplete-plugin, but that's longer, and would be inconsistent with InstantSearch


nav ux

Currently nav sits at the top, as the user scrolls the navigation is lost. resulting in the user having to needlessly scroll to the top to navigate to other pages if further down the page.

Possible solutions are: sticky menu component / floating hamburger when below the fold


generators fixes for iterator properties

Blackduck scan failure details
Summary: 0 violations, 0 files pending approval, 2 files pending identification.

Protex Server Path: /home/blackduck/github/Thunder/636/rdkcentral/Thunder

Commit: fbabeed1ffe7495a6ef766d4311c23cdb4c9cb8f

Report detail: gist

WARNING: A Blackduck scan failure has been waived
A prior failure has been upvoted

Upvote reason: Not a problem

Commit: fbabeed1ffe7495a6ef766d4311c23cdb4c9cb8f


CI tests on real world documents

I think the project at this stage, and looking forward, would profit from adding a larger set of real world SVG documents in CI - in addition to the existing, large set of unit tests (which is very good that we have it).

@oberstet Are we looking for a runtime performance baseline, memory usage baseline, scour'ed output size baseline, a "scour does not crash" baseline or ...?
The choice of documents (and possibly the test runner) depends on what we aim to solve with testing on real world documents.

I was mainly thinking about: no regressions, same (non-optimized) input produces exactly (to the byte) the same (optimized) output. and if not, because we expanded scour in some way with a necessary change in output, then the respective changing PR needs to commit new versions of expected output documents as well.

and yeah, the 2nd thing: output size. because that's the whole point of Scour, right? ;) so actually, that could make sense:
the ultimate project CI benchmark for a PR is:

output is functionally correct (it is valid SVG and parses and renders correct in browsers etc)
output size is smaller than input and previous version of Scour output

if we could automate both of above, then we probably wouldn't need to have the optimized versions of the test set documents checked into git as target reference. because if the output changes but still satisfies above conditions, that is totally fine then.
obviously we can check condition 2. automatically. but condition 1.?
how does one check that given some SVG test document that contains a blue hexagon isn't optimized by Scour to a smaller SVG that renders a red triangle?
do we expect Scour to retain pixel exact identity between the rendering of the original SVG and the optimized SVG?
if so it might be possible to automated ..

Tobias Oberstein:

and yeah, the 2nd thing: output size. because that's the whole point of Scour, right? ;) so actually, that could make sense:
the ultimate project CI benchmark for a PR is:

output is functionally correct (it is valid SVG and parses and renders correct in browsers etc)

Imagemagick as a compare tool that allegedly can help us with 1.
Something like:
$ compare -metric AE -fuzz 1% orig.png optimized.png diff.png

Obviously, it will not test all browsers/renders nor animations, but it
should catch visible artefacts in simple images (over the
"fuzz"-threshold - see imagemagick-cmdline)

output size is smaller than input and previous version of Scour output

Ok.  The scour tool has a bunch of options that control optimized size
at the price of visual artefacts.  Which options should we use for this
test?  Perhaps something like the following as the default?
  --enable-id-stripping
  --enable-comment-stripping
  --shorten-ids
  --indent=none
  --no-line-breaks
  --strip-xml-prolog
  --remove-descriptive-elements
  --set-precision=8 [--set-c-precision=8]
  --disable-embed-rasters
  --renderer-workaround

[...]> do we expect Scour to retain pixel exact identity between the
rendering of the original SVG and the optimized SVG?

Depends on the options used (e.g. the --set-precision is exactly
changing pixel identities).  However, with compare we can define an
"acceptable level of error" via the -fuzz parameter and then choose
the options so conservative that we stay inside that level of error.
Thanks,
~Niels

rgd pixel correctness: ah, right, that is a user knob.
ideally then, the CI would test then at different precision vs size tradeoff levels
and the CI would also test using imagemagick, as well as ideally at least one real world browser rendering engine
all of this is to bring our CI testing as close as possible to what the user of Scour is really interested in

fwiw, I think in the case of Scour, benchmarking the resource consumption for the tool (CPU, RAM) is a secondary priority, because it will only matter if you wanna scour 1000s of files .. and for this scenario, we should just - wait until it happens;) and then maybe just implement parallelization, and done. scour isn't nginx.


Error while running default migrations

Laravel Version: 5.4.*
PHP Version: 7.0.14
Database Driver & Version:
MySQL 5.5.42

Description:
When you run the php artisan migrate command, the following error occurs:
[Illuminate\Database\QueryException]
  SQLSTATE[42000]: Syntax error or access violation: 1071 Specified key was too l
  ong; max key length is 767 bytes (SQL: alter table `users` add unique `users_em
  ail_unique`(`email`))

[PDOException]
  SQLSTATE[42000]: Syntax error or access violation: 1071 Specified key was too l
  ong; max key length is 767 bytes

Steps To Reproduce:
$ php artisan migrate

This has been reported several times:
https://github.com/laravel/framework/issues/17530 https://github.com/laravel/framework/issues/17508 https://github.com/laravel/framework/issues/17337
It's also documented in the Migration Guide: https://laravel.com/docs/5.4/migrations#indexes
Adding this in your boot method of the AppServiceProvider should do the trick:
Schema::defaultStringLength(191);

like so:
use Illuminate\Support\Facades\Schema;

/**
 * Bootstrap any application services.
 *
 * @return void
 */
public function boot()
{
    Schema::defaultStringLength(191);
}

@RikSomers It worked, thank you!

sweet thanks @RikSomers

No problem, we're here to help eachother :)


no data in converted video or image

Dear sir,
When converted the svo file into video or image,  I got the empty result. As the following picture shows.

Same here. Is this project live?

Corrected in 3ef0e7d. (same as issue #7)
Thanks for the report.


Create Will's First In Person Meetup

Glad to hear it was a good experience.  Seeing there's a big world outside of class and getting motivated about coding projects is one of the purposes of the assignment so 👍 !


Allow for ES6 development against td.server

Describe what problem your feature request solves
td.server should allow for ES6 development
Describe the solution you'd like
Using babel or a similar technology, the back-end code should be able to handle es6 syntax, such as import './foobar.js'
Additional context
Rather than doing a large refactor all at once, I think it would make sense to create the infrastructure to support ES6 development first, and then chip away at refactoring existing code.

Yes, agreed, if we could do it gradually then we can see the effect of the changes as we go along.

The only problem I'm seeing so far is that if we rewrite a file in es6 syntax, we will have to update everywhere that references it to use the .default() property or method.
somefile.js
import fs from 'fs';

const myFunc = () => {};

export default {
  myFunc
};

consuming-non-es6-file.js
var someFile = require('./somefile.js');

// someFile.myFunc(); // no longer works
someFile.default.myFunc();

There may be a better way of doing this, or maybe some babel plugin that solves the issue.
I'm just wondering if this will add more confusion and unnecessary code, or if we should move forward with it this way just to get things started and see where we land?


Bugfix/checkbox custom class config

If i want to pass a custom class to checkbox and radio i can't because the default form-control not needed here and the HtmlGenerator.php not include the class="'.$config['class'].'"  ot in this case the class="'.$config['config']['class'].'"  for get only the custom one and not the default merget with form-control or what else....
I think it right to allow for passing custom class, in my example for iCheck jquery plugin that require it

I can't run the test, maybe because i'm on PHP7, there are a tutos for run it?

Oh, i'm commit other changes to, sorry! If you accept this edits i clean and do another pull-request


dlp: check errors in tests

Good code

Thanks! Looks good. Let us know if/when you sign the CLA then we can merge.

Thanks, again, for the PR. But, without the CLA, we can't merge this. So, I'm going to close this for now, but feel free to reopen if you sign the CLA.


use properties to replace the specified dependency version and enable library-udf module

Description
use properties to replace the specified dependency version and enable library-udf module
Content1 ...
use properties to replace the specified dependency version,
so that it is easy to upgrade the version and cover current version when user refers our library.
Content2 ...
library-udf was disabled, I enable it in this pr.
The chain reaction is that there are some errors in library-udf (code-style and incorrect variable reference of IoTDB.java)
Content3 ...
a minor defensive programming in StandaloneEnv.java to avoid someone calls getConnection twice and then the first connection resource is not released.

This PR has:

[ x ] been self-reviewed.

[ ] concurrent read
[ ] concurrent write
[ ] concurrent read and write

[ ] added documentation for new or modified features or behaviors.
[ ] added Javadocs for most classes and all non-trivial methods.
[ ] added or updated version, license, or notice information
[ x ] added comments explaining the "why" and the intent of the code wherever would not be obvious
for an unfamiliar reader.
[ ] added unit tests or modified existing tests to cover new code paths, ensuring the threshold
for code coverage.
[ ] added integration tests.
[ ] been tested in a test IoTDB cluster.

Key changed/added classes (or packages if there are too many classes) in this PR

Coverage decreased (-1.2%) to 51.864% when pulling 2c1604711d79942fba98ec197243bb9c1d40db5f on calldepversion into b2f3c4b668e97b07f235807e9dc0d3c763afddc8 on master.


CSI: Allow NodePublishVolume even when plugin does not support staging

- What I did
I was packing  NFS CSI for Swarm on https://github.com/olljanat/csi-plugins-for-docker-swarm/tree/master/csi-driver-nfs when noticed that it was able to create volume and folder to NFS share but mounting volume to didn't worked but instead of it ended up looping these messaged on Docker engine log:
INFO[2023-02-04T19:21:08.939610819+01:00] attempting to publish volume                  attempt=1 module=node/agent/csi volume.id=0f9wq7wvz41wxw81u4gfsiy55
DEBU[2023-02-04T19:21:08.939765667+01:00] staging volume succeeded, attempting to publish volume  attempt=1 module=node/agent/csi volume.id=0f9wq7wvz41wxw81u4gfsiy55
INFO[2023-02-04T19:21:08.939788029+01:00] publishing volume failed                      attempt=1 error="rpc error: code = FailedPrecondition desc = volume not staged" module=node/agent/csi volume.id=0f9wq7wvz41wxw81u4gfsiy55

- How I did it
Set stagingPath to empty string by default and continue logic instead of return error when plugin does not support staging.
- How to test it
Added another test case without staging. Manual testing can be done with linked NFS CSI plugin.
- Description for the changelog

We got an issue with CI and fix had been merge, can you rebase your PR please?

Codecov Report

Merging #3116 (849c087) into master (8892b33) will increase coverage by 61.80%.
The diff coverage is 72.72%.

@@             Coverage Diff             @@
##           master    #3116       +/-   ##
===========================================
+ Coverage        0   61.80%   +61.80%
===========================================
  Files           0      153      +153
  Lines           0    31103    +31103
===========================================
+ Hits            0    19224    +19224
- Misses          0    10331    +10331
- Partials        0     1548     +1548

@crazy-max yes, CI started working with rebase and found two issues which I needed to solve ( accessMode cannot be nil and there need to be separate test case with and without staging).
@dperny PTAL

@neersighted I was not sure what would be correct location for that helper and when started working with it I found that makeCapability function did exists twice so I introduced pkg/... structure for swarmkit too as it looks to be quite common way 😄

I think the pkg pattern has been quite detrimental overall; if we need to share things across two packages I'd suggest we use internal/ instead (so otherwise exported fields are kept from being public).

Now those are in internal/csi/capability and CI is green (looks to be flaky if you update PR when CI is not ready from earlier run).

capability is really not a great home for these, but I think that's a bikeshed we can worry about later -- most of these helpers should probably go into a apihelpers or typeconversion or something package that has its own unit tests.
I think this LGTM to me overall, I'll sync up with @dperny again to go over it once we both have bandwidth.

Not a blocker on this PR, but we should move the volumequeue package from the top level into internal/csi/volumequeue. Not sure why I didn't think of that in the first place.