default bg layer determination: remove extra handling for retina displays

Pull Request Test Coverage Report for Build<PHONE_NUMBER>7
Details

6 of 6 (100.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.02%) to 99.681%

Totals

Change from base Build<PHONE_NUMBER>1:
0.02%

Covered Lines:
13360

Relevant Lines:
13361

💛  - Coveralls


DelayA:setDelay: argument (xxxx.xx) greater than maximum!

The argument value varies (5090.73, 5393.47, 4280.7)
My original code was
let delay = AKDelay(mandolin)
delay.time = 1.5 / 10.0
delay.dryWetMix = 0.3
delay.feedback = 0.1
let reverb = AKReverb(delay)
I changed it to
let delay = AKVariableDelay(mandolin, time: 1.5 / 10.0, feedback: 0.1, maximumDelayTime: 5500)
let reverb = AKReverb(delay)
Then I changed it to
let reverb = AKReverb(mandolin)
Then I changed the effect to AutoWah
but each case resulted in the same errors
The error causes the audio to glitch and causes the debugger to become unresponsive
DelayA::setDelayMessage from debugger: The LLDB RPC server has exited unexpectedly. Please file a bug if you have reproducible steps.
The issue occurs when the note number fed to the mandolin is less than 5
mandolin.fret(noteNumber: noteNum, course: Int(course))
The AudioKit code should handle this error or at least give a more descriptive error.

I have updated AKVariableDelay, thanks for pointing this out.


Generalize what sync task reports to

Needed in order to use the sync task in places other than the home activity

I assume you're actively planning on making the sync task report to another activity at some point? Right now looks like CommCareHomeActivity is the only thing implementing ConnectorWithMessaging

Yes, see https://github.com/dimagi/commcare-odk/pull/1059/files#diff-372dfe29c871df8f1f5baca49b82907eR114

Will, I addressed one of the two lint warnings related to https://github.com/dimagi/commcare-odk/pull/1198#discussion_r60315122. The other one needs to stick around for now because of how I'm going to use these changes in https://github.com/dimagi/commcare-odk/pull/1059.
I may have fixed a strange bug (made a note). I'm going to look into it needs to be fixed for 2.27 as well; if so, I'll create a new PR for that.

Build is failing due to us surpassing github's clone rate limit... still haven't fixed that issue

This is out of sync enough from https://github.com/dimagi/commcare-odk/pull/1059, where the changes are being used, that I'm going to close this and just have the changes reviewed from inside of https://github.com/dimagi/commcare-odk/pull/1059


Fix code scanning alert - Clear text storage of sensitive information

Tracking issue for:

[x] https://github.com/Azure-Samples/iot-edge-opc-plc/security/code-scanning/7

was dismissed


Capture compressed request

If a request is compressed the inspector doesn't capture it and doesn't show in a list.
It will be great to see such requests in a list in a decompressed form.

Could you provide an example request and we'll look at adding it.

compressed_graphql_request.har.zip

Done as per https://github.com/warrenday/graphql-network-inspector/issues/142


typescript ReturnType is “any” if parameter type is “never”

I found alternative solution on stack overflow but was advised to open an issue here
TypeScript Version: 3.8.3
Search Terms:
ReturnType
Parameters
Function
any
never
Code
const abc = (a:never):number=>1

type a = ReturnType< typeof abc> //any

const abc2 = (a:number, b:never):number=>1

type a2 = ReturnType< typeof abc2> //any

Expected behavior:
type a and a2 should be number regardless of the types of parameters
Actual behavior:
type a and a2 are any if any of the types of the parameters are never
Playground
link
the original question is posted on here with details describing the use case
link

This is interesting:
type Expected = ((arg: string) => 0) extends (...args: any) => infer R ? "expected" : "unexpected"; // expected
type Unexpected = ((arg: never) => 0) extends (...args: any) => infer R ? "expected" : "unexpected"; // unexpected
type Expected2 = ((arg: never) => 0) extends (...args: any) => any ? "expected" : "unexpected"; // expected
type Unexpected2 = ((arg: never) => 0) extends ((...args: any) => 0) ? "expected" : "unexpected" // unexpected

There's probably an existing issue for this but I didn't see one.

Duplicate of #35432.


Add test for hdf5 compression check

In GitLab by @Yushan-Wang on Jul 8, 2024, 11:27

In GitLab by @Yushan-Wang on Jul 8, 2024, 11:28
created branch 452-add-test-for-hdf5-compression-check to address this issue

In GitLab by @Yushan-Wang on Jul 31, 2024, 13:05
mentioned in commit 49f3886fd10cf7085699e1e99ec3b77cd2084f0e

In GitLab by @Yushan-Wang on Jul 29, 2024, 14:21
created branch 452-add-test-for-hdf5-compression-check-2 to address this issue

In GitLab by @Yushan-Wang on Jul 29, 2024, 14:06
mentioned in commit 80aa63fd6caeb6ac6782c106f4adf575c7c51755


Hugo and Readme.md

Is it possible to have a .hugoignore file? It currently tries to parse a readme.md file at the root of my repo that I'm using for GitHub and fails.

Just realized what is actually going on.
I have a /data linked as a git submodule to another repo that holds external .yaml files. The fact that there is a readme.me in that repository is actually what is breaking hugo, it doesn't like .md files under /data

That could be fixed. Thanks for the report.


v1.1.0

Codecov Report

Merging #12 into master will increase coverage by 14.30%.
The diff coverage is 83.33%.

@@             Coverage Diff             @@
##           master      #12       +/-   ##
===========================================
+ Coverage   68.62%   82.93%   +14.30%
===========================================
  Files           6        6
  Lines         306      334       +28
===========================================
+ Hits          210      277       +67
+ Misses         96       57       -39

Impacted Files
Coverage Δ

src/bin/bombadil.rs
0.00% <0.00%> (ø)

src/settings.rs
64.70% <ø> (+47.05%)
:arrow_up:

src/templating.rs
89.13% <69.23%> (+20.08%)
:arrow_up:

src/lib.rs
88.39% <89.13%> (+11.74%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c635e7b...5977105. Read the comment docs.


Address failure in TemporaryFolderUsageTest#newFolderWithGivenFolderThrowsIOExceptionWhenFolderCannotBeCreated when run in a Docker image

During tests of #35 and #34 on a broader collection of platforms, when running (CI) in a Docker container, a failure in org.terracotta.org.junit.rules.TemporaryFolderUsageTest#newFolderWithGivenFolderThrowsIOExceptionWhenFolderCannotBeCreated is observed (discussion shown below).  This failure needs to be addressed before extending CI to include Docker.

You can check the results of my test branch here: https://github.com/mathieucarbou/terracotta-utilities/actions/runs/1884731142

Interesting -- a failure in a TemporaryFolder test in which is appears that File.setReadOnly() does not, in fact, set the File to read-only is preventing the rest of the tests being run.  An adjustment to the build script needs to be made to allow the remainder of the build to continue following a test failure to ensure my changes are suitable for Docker execution.  As for the apparent File.setReadOnly() failure, I'll investigate what the root cause might be.  (The most recent change to TemporaryFolderUsageTest was actually in the failing method -- junit-team/junit4#1632.  Our version of this class has that update.)
This failure will need to be addressed, in some way, before moving ahead with the CI expansion.
Originally posted by @cljohnso in https://github.com/Terracotta-OSS/terracotta-utilities/issues/35#issuecomment-1048841126

In addition to currency with JUnit 4, the code underlying the JUnit 5 TempDir annotation does not include a similar test so no guidance is available from JUnit 5's approach.

We'll likely need to examine the operation of the test more closely -- the test result indicates the attempt to call File.newFolder(...) against a directory that was altered using File.setReadOnly() did not fail as expected.  It's unclear, at this point, if the newFolder succeeded or failed in a different way.
org.terracotta.org.junit.rules.TemporaryFolderUsageTest.newFolderWithGivenFolderThrowsIOExceptionWhenFolderCannotBeCreated  Time elapsed: 0.015 s  <<< FAILURE!
java.lang.AssertionError: Expected test to throw (an instance of java.io.IOException and exception with message a string containing "could not create a folder with the path 'level1'")
	at org.junit.Assert.fail(Assert.java:88)
	at org.junit.rules.ExpectedException.failDueToMissingException(ExpectedException.java:263)
	at org.junit.rules.ExpectedException.access$200(ExpectedException.java:106)
	at org.junit.rules.ExpectedException$ExpectedExceptionStatement.evaluate(ExpectedException.java:245)
	at org.junit.rules.RunRules.evaluate(RunRules.java:20)
	at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:325)
	at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:78)
	at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:57)
	at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
	at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71)
	at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288)
	at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58)
	at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268)
	at org.junit.runners.ParentRunner.run(ParentRunner.java:363)
	at org.apache.maven.surefire.junit4.JUnit4Provider.execute(JUnit4Provider.java:365)
	at org.apache.maven.surefire.junit4.JUnit4Provider.executeWithRerun(JUnit4Provider.java:273)
	at org.apache.maven.surefire.junit4.JUnit4Provider.executeTestSet(JUnit4Provider.java:238)
	at org.apache.maven.surefire.junit4.JUnit4Provider.invoke(JUnit4Provider.java:159)
	at org.apache.maven.surefire.booter.ForkedBooter.runSuitesInProcess(ForkedBooter.java:377)
	at org.apache.maven.surefire.booter.ForkedBooter.execute(ForkedBooter.java:138)
	at org.apache.maven.surefire.booter.ForkedBooter.run(ForkedBooter.java:465)
	at org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java:451)

TEST-org.terracotta.org.junit.rules.TemporaryFolderUsageTest.xml.zip

Recoding a portion of the newFolderWithGivenFolderThrowsIOExceptionWhenFolderCannotBeCreated test as the following allows the test suite (and remainder of the build) to complete with no further errors:
//        thrown.expect(IOException.class);
//        thrown.expectMessage("could not create a folder with the path 'level1'");
        try {
            tempFolder.newFolder("level1");
            throw new AssumptionViolatedException("File creation successful in read-only directory; super-privileged user likely");
        } catch (IOException e) {
            assertThat(e.getMessage(), is("could not create a folder with the path 'level1'"));
        }

We may be better off simply ignoring the test altogether -- that would be appropriate if there is no dependency on the IOException thrown when a create-in-read-only-directory error is raised in the main code.

Closed by PR #40


AutoUpload not work for new folder/file

Extension does not auto upload when create new file/folder.

And does not auto delete delete when file/folder delete from project

same problem


turkic setup --public-symlink does not work

Hi,
I have a problem on running
turkic setup --public-symlink returns an error
Could not create symlink!.
I think this makes an error on /var/log/apache2/error.log.

[Sat Mar 04 16:40:48.626938 2017] [core:error] [pid 3857:tid<PHONE_NUMBER>55296] [client <IP_ADDRESS>:56708] AH00037: Symbolic link not allowed or link target not accessible: /home/user/vatic-tool/vatic/public/frames/identifier, referer: http://localhost/?id=1&hitId=offline

I would appreciate any suggestion.
Thanks,

Partially solved.
Once deleted /path/to/vatic/public/turkic,
then turkic setup --public-symlink worked.
Created symblink /usr/local/lib/python2.7/dist-packages/turkic-0.2.5-py2.7.egg/turkic/public to /path/to/vatic/public/turkic.
However, there is still an AH00037 error, so I cannot access to http://localhost/?id=1&hitId=offline.

Completely solved by changing a destination directory like this;
turkic extract src.mp4 ~/work/dst/

@yukinak  hello, I meet the same problem as when I running turkic setup --public-symlink, but
I can't find sth. in the error log, can you tell me how can you solve it in details？
Thanks！

@stonycat Can you remove the symbolic link of /path/to/vatic/public/turkic?
I think you cannot create new symlink on the existing symlink.

@yukinak Thank you, I have an existing turkic link in the path to vatic/public/.  I didn't understand the error before.

@yukinak I have the same problem. Could you help me for this problem? Thank you very much.
This is my 000-default:
WSGIDaemonProcess www-data
WSGIProcessGroup www-data
<VirtualHost *:80>
ServerName localhost
DocumentRoot /home/beans/vatic/vatic/public
WSGIScriptAlias /server /home/beans/vatic/vatic/server.py
CustomLog /var/log/apache2/access.log combined

%%%%%%%%%%%%%%%%%%%%%%%
~/vatic/vatic$ turkic setup --public-symlink
Could not create symlink!

@YangBain I think it's the same problem we discussed. Can you remove the symbolic link of /path/to/vatic/public/turkic?

@yukinak do you know why changing destination directory solve the problem? What was your previous destination directory?


Close the calendar on selection

Hi,
the calendar is not hidden when a date is selected. How can I hide the calendar on value selection?

In the meanwhile, you should click somewhere out of the calendar's modal.
But I am gonna do some refactoring in the future and add a prop that lets you close the calendar after selecting the date or keep it open.

Thank you.
Unfortunately, it has a bad user experience because user should click out of calendar for every date input.
Please add this feature as soon as possible.

I added autoClose to the new version (1.6.0), you can use it.
But be careful about the new version initValue prop, I have changed the flow of adding the initial value and it's very easier than the previous version.


Final Fantasy XIII texture issues.

On linux, running under proton, shadows resolution 4096 x 4096 and 8192 x 8192 makes game don't work and hairs have texture problem:

I have read this error is due to msaa rendering, but i don't know what really means.
Im using Steam native client with:
Proton:4.2-3
Distro:Ubuntu 18.04.2 LTS
Kernel:5.1.0-050100-generic
RAM:16 GB
GPU Driver:4.5 Mesa 19.0.1 - padoka PPA
GPU:Radeon RX 590
CPU:AMD Ryzen 5 2600X Six-Core

Are you actually using D9VK? Proton does not come with D9VK out of the box.
A log would be appreciated.

Both things are rather game bugs and I doubt they can be worked around under Linux. These things are also happening on Windows. For Nvidia cards You have to use third-party configuration tool to fix broken hair transparency (Nvidia Inspector) - read about it here: https://forums.guru3d.com/threads/nvidia-anti-aliasing-guide-updated.357956/page-123.
As for shadow resolution I always sticked to lowest values. The game was crashing too much with anything higher than 512x512.
I haven't tried to play it with d9vk yet, I think I should give it a try.

I've tried to install d9vk in proton's prefix and now game don't launch (even when I change resolution and msaa). Anyone knows how to get .log file with proton?

set launch option with PROTON_LOG=1 %command% and you'll get a steam-apid.log in home folder.
but that will be proton logs. i don't know if it will show d9vk output. probably is better to do DXVK_LOG_LEVEL=none|error|warn|info|debug (pick one).

I haven't tried to play it with d9vk yet, I think I should give it a try. Then why report an issue here?

Thank you logan001, I have got proton log (attached in this message) when game launch crash, but I'm not able to obtain d9vk log.
steam-292120.log

Since you have an AMD card, you could also try Gallium Nine, which is a more mature project at the moment.
Regarding the D9VK logs, they should be in the game's directory, somewhere in /common/.

wine-staging 4.7. This game works with D9VK, when d3d9.evictManagedOnUnlock = True in dxvk.conf, even with shadow resolution set to 8192x8192 (dxvk.conf must be in directory where ffxiiiimg_d3d9.log is found, not in the directory where ffxiiiimg.exe resides).
ffxiiiimg_d3d9.log
When this setting is False (default), it reaches menu, but then crashes always because of memory allocation issues.
ffxiiiimg_d3d9_fail.log
The hair and eyelashes problem is still present though. Probably impossible to fix...
All above applies to FFXIII-2 as well.
ffxiii2img_d3d9.log
As a side note - to have all three parts of the game here - Lightning Returns starts and reaches menu, but crashes when trying to enter the load screen or to start a new game:
00ef:fixme:d3dx:D3DXLoadSurfaceFromMemory Unhandled filter 0x80004.
LRFF13_d3d9.log
Not a D9VK problem ?

I was wrong. It seems to be fixed by implementing alpha to coverage.
Before commit 5815a56a

After commit 5815a56a

Thank You.
(strange thing is Vanille did not change at all)

I was wrong. It seems to be fixed by implementing alpha to coverage.
Before commit 5815a56

After commit 5815a56

Thank You.
(strange thing is Vanille did not change at all)

Hello, how can I implement alpha coverage? Sorry but I'm newbie in this world

I implemented alpha to coverage myself which is what he was talking about.

Ok and how can I turn on that function, what must I do?

Nothing. It's included in the latest builds.

Waaaaau this is another thing, thank you so so much guys for help and fix, now I can play it with max resolution (8192 x 8192 it's a little bit slowly, maybe it was my graphic card, but at least it runs well) and msaa 16.

.

8192 x 8192 shadow res + 16 msaa is gonna struggle on any system :P

Some keys doesn't appear when using d9vk
Without d9vk:

Using d9vk:

Proton log:
steam-292120.log
D9VK log:
ffxiiiimg_d3d9.log


Add warning for Go 1.14/darwin issue and add Go 1.13 to CI matrix

Sorry for the force pushes. Kept munging the link to #10 in the README.

Those failures are unrelated. Scared the heck out of me. Looks like CI had trouble downloading the wasmtime release?

Ah yeah that's ok, thanks for this!


uuid as primary key and inferring associations

Hi all, bouncing over here from discuss.
What I'm hoping to do is simply use UUIDs as my PK's in PG.
First here's a simple (if verbose) pre-uuid experiment that works:
#!/usr/bin/env ruby
require 'bundler/setup'
require 'rom-sql'
require 'rom-repository'

module Relations

  class Series < ROM::Relation[:sql]
    schema(:series) do
      attribute :id, Types::Int
      attribute :database_rp, Types::String
      attribute :measurement, Types::String
      attribute :tag_set, Types::String

      primary_key :id

      associations do
        has_many :archives
      end
    end

    def by_id(id)
      where(id: id)
    end

    def by_series(measurement:, tag_set: )
      # A series definition is
      where(measurement: measurement).where(tag_set: tag_set)
    end
  end

  class Archives < ROM::Relation[:sql]
    schema(:archives) do
      attribute :id, Types::Int
      attribute :series_id, Types::String
      attribute :date_from, Types::Date
      attribute :date_to, Types::Date
      attribute :status, Types::String
      associations do
        belongs_to :series
      end
    end
  end
end

module Repositories

  class Series < ROM::Repository[:series]

    commands :create

    def [](id)
      series.by_id(id).one!
    end

    def from_definition(measurement:, tag_set:)
      series.by_series(measurement: measurement, tag_set:  tag_set)
    end
  end

  class Archives < ROM::Repository[:archives]
    commands :create
  end
end

configuration = ROM::Configuration.new(:sql, 'postgres://localhost/rom-test')
configuration.register_relation Relations::Series
configuration.register_relation Relations::Archives
container = ROM.container(configuration)

gateway = container.gateways[:default]

migration = gateway.migration do
  change do
    create_table :series do
      primary_key :id
      String :database_rp, null: false
      String :measurement, null: false
      String :tag_set, null: false
    end

    create_table :archives do
      primary_key :id
      foreign_key :series_id, null: false
      Date :date_from
      Date :date_to
      String :status, null: false, default: 'Not started'
    end
  end
end

migration.apply(gateway.connection, :up)

series_repo = Repositories::Series.new(container)
archives_repo = Repositories::Archives.new(container)

first_series = series_repo.create(database_rp: 'test.default', measurement: 'cpu', tag_set: 'cpu=cpu0,instance_id=i-1234,role=web')
puts first_series

first_archive_cs = archives_repo.changeset(date_from: Date.today, date_to: Date.today).associate(first_series)
archives_repo.create(first_archive_cs)

Here's my attempt to do the same thing using the same code, with UUID which chokes on .associate
#!/usr/bin/env ruby
require 'bundler/setup'
require 'rom-sql'
require 'rom-repository'
require 'securerandom'
require 'rom/sql/extensions/postgres/types'

module Relations

  class Series < ROM::Relation[:sql]
    schema(:series) do
      attribute :id, Types::PG::UUID
      attribute :database_rp, Types::String
      attribute :measurement, Types::String
      attribute :tag_set, Types::String

      associations do
        has_many :archives
      end
    end

    def by_id(id)
      where(id: id)
    end

    def by_series(measurement:, tag_set: )
      # A series definition is
      where(measurement: measurement).where(tag_set: tag_set)
    end
  end

  class Archives < ROM::Relation[:sql]
    schema(:archives) do
      attribute :id, Types::PG::UUID
      attribute :series_id, Types::String
      attribute :date_from, Types::Date
      attribute :date_to, Types::Date
      attribute :status, Types::String
      associations do
        belongs_to :series
      end
    end
  end
end

module Repositories

  class Series < ROM::Repository[:series]

    commands :create

    def [](id)
      series.by_id(id).one!
    end

    def from_definition(measurement:, tag_set:)
      series.by_series(measurement: measurement, tag_set:  tag_set)
    end
  end

  class Archives < ROM::Repository[:archives]
    commands :create
  end
end

configuration = ROM::Configuration.new(:sql, 'postgres://localhost/rom-test')
configuration.register_relation Relations::Series
configuration.register_relation Relations::Archives
container = ROM.container(configuration)

gateway = container.gateways[:default]

migration = gateway.migration do
  change do
    run 'CREATE EXTENSION "uuid-ossp"'
    create_table :series do
      uuid :id, default: Sequel.function(:uuid_generate_v4), primary_key: true
      String :database_rp, null: false
      String :measurement, null: false
      String :tag_set, null: false
    end

    create_table :archive do
      uuid :id, default: Sequel.function(:uuid_generate_v4), primary_key: true
      foreign_key :series_id, null: false
      Date :date_from
      Date :date_to
      String :status, null: false, default: 'Not started'
    end
  end
end

migration.apply(gateway.connection, :up)

series_repo = Repositories::Series.new(container)
archives_repo = Repositories::Archives.new(container)

first_series = series_repo.create(database_rp: 'test.default', measurement: 'cpu', tag_set: 'cpu=cpu0,instance_id=i-1234,role=web')
puts first_series

first_archive_cs = archives_repo.changeset(date_from: Date.today, date_to: Date.today).associate(first_series)
archives_repo.create(first_archive_cs)

It occurred to me to declare that primary_key: id as I did in the top example, but this seems to need id to be an Int.
Thanks for reading and for any help you can give.

Thanks for reporting this. It needs a closer look though so I can't immediately tell you what's going on. Could you also add some backtrace to the description?

Hey thanks Solnic,
Backtrace below:
/Users/glenn/.gem/ruby/2.3.3/gems/rom-repository-1.3.1/lib/rom/repository/changeset/associated.rb:36:in `infer_assoc_name': can't infer association name for #<ROM::Struct[Series]:0x7fc8be131558> (ArgumentError)
	from /Users/glenn/.gem/ruby/2.3.3/gems/rom-repository-1.3.1/lib/rom/repository/changeset/stateful.rb:188:in `associate'
	from ./run-with-uuid.rb:106:in `<main>'

@glenndavy ok for now just pass in assoc name explicitly so associate(series, :series). I'll look into why it can't infer in your case. Another thing to try is to define your attribute in the schema like that:
attribute :id, Types::PG::UUID.meta(primary_key: true)

Hi @solnic,
Thanks for that tip. What I ended up finding was I needed this as suggested:

attribute :id, Types::PG::UUID.meta(primary_key: true)

and to change this:
foreign_key :series_id, null: false

to this:
 uuid :series_id, null: false

This works just fine (at least on master) https://gist.github.com/solnic/25f217393c5554a3c0ef49f1c948470b


ADDED context/experienceevent-enduserids.schema.json

This PR brings back endUserIDs for Experience Event and clarifies that it contains the user ids asserted during capture of the EE.
LEFT UNTOUCHED:
context/experienceevent-enduserids-deprecated.schema.json, that will
need to be removed later.
NON BREAKING CHANGE:
to solution template mixins to use new non
deprecated endUserIDs

@kstreeter - This is the PR to re-instate end user identities in ee. The approach I take is to add them as a mixin. I also considered adding endUserIDs to the EE class and could go that way if you think it is better.


[stable/airflow] preinit init container is not properly calling the puckel/airflow docker

Describe the bug
We're not running airflow initdb against the proper database when using airflow.preinitdb=true.
Version of Helm and Kubernetes:
helm version
version.BuildInfo{Version:"v3.1.1", GitCommit:"afe70585407b420d0097d07b21c47dc511525ac8", GitTreeState:"clean", GoVersion:"go1.13.8"}
kubectl version
Client Version: version.Info{Major:"1", Minor:"17", GitVersion:"v1.17.3", GitCommit:"06ad960bfd03b39c8310aaf92d1e7c12ce618213", GitTreeState:"clean", BuildDate:"2020-02-14T18:02:25Z", GoVersion:"go1.13.8", Compiler:"gc", Platform:"linux/amd64"}
Server Version: version.Info{Major:"1", Minor:"17", GitVersion:"v1.17.3", GitCommit:"06ad960bfd03b39c8310aaf92d1e7c12ce618213", GitTreeState:"clean", BuildDate:"2020-02-11T18:07:13Z", GoVersion:"go1.13.6", Compiler:"gc", Platform:"linux/amd64"}

Which chart:
[stable/airflow]
What happened:
When airflow.preinitdb is set to true, the airflow-preinitdb initContainer is running airflow initdb on a SQLite context instead of running it against the PostgreSQL database configured in the chart.
*** Waiting 10s for postgres
*** Initializing airflow db
[2020-04-15 21:25:42,740] {{settings.py:212}} DEBUG - Setting up DB connection pool (PID 7)
[2020-04-15 21:25:42,982] {{cli_action_loggers.py:42}} DEBUG - Adding <function default_action_log at 0x7f6d06d51b00> to pre execution callback
DB: sqlite:////usr/local/airflow/airflow.db
[2020-04-15 21:25:43,629] {{db.py:368}} INFO - Creating tables
INFO  [alembic.runtime.migration] Context impl SQLiteImpl.

What you expected to happen:
The initdb operation should be run over the configured PostgreSQL database.
How to reproduce it (as minimally and precisely as possible):
Set airflow.preinitdb to true with an external postgreSQL database configured in the Helm Chart vlaues.
Anything else we need to know:
The initContainer triggered by airflow.preinitdb=true configuration is improperly calling the puckel/docker-airflow Docker image with:
command:
            - "/bin/bash"
            - "-c"
            - "/usr/local/scripts/preinit-db.sh"

As the doc says:

If you supply a command but no args for a Container, only the supplied command is used. The default EntryPoint and the default Cmd defined in the Docker image are ignored.

Hence the ENTRYPOINT of the puckel/docker-airflow docker is overridden: https://github.com/puckel/docker-airflow/blob/master/Dockerfile#L85
But this ENTRYPOINT is very useful to build Airflow specific env variables from env variables built in this Helm chart. See: https://github.com/puckel/docker-airflow/blob/master/script/entrypoint.sh
For example, the AIRFLOW__CORE__SQL_ALCHEMY_CONN env variable is not properly set (as it's built by the default ENTRYPOINT), and the airflow initdb is then run on a local SQLite database instead of the PostgreSQL database configured in this Helm Chart.
To fix the issue, the command:simply has to be renamed args as done in other place in the Chart when running airflow initdb
Ex. https://github.com/helm/charts/blob/master/stable/airflow/templates/deployments-scheduler.yaml#L208

ping @memory

How embarrassing!  I'll try to get a pr together tomorrow.  cc @gsemet

@memory > I did a PR if you want =)


TD-466: Adds severity attribute as event's log level

Removes logstash_logger_formatter dependency
Adds log_fmt to umbrella which is literally copy-paste of dependency mentioned above with a patch
Rearranges config params

Убрал старое решение. Прикрутил https://github.com/valitydev/logstash_logger_formatter/pull/1


Fix handle_info callback of logger backend Fix #34

Logger backend are expected to be GenEvent modules. GenEvent modules does not accept {:noreply, state} as a response to handle_info callbacks.
Therefore, the Airbrakex logger backend is killed with a message :gen_event_EXIT

I would like to add a test to be sure that the problem stay fixed but I need some pointers to how to do it. If anybody can share with me some examples, I'll be pleased to add a test

Great PR. Thanks 👍


fixes #262 : Gradient css fixed in header

    ________________________
   |                       |
   |   Merry ChriCSSmas!   |
   |___  __________________|
       |/
     🎅

🎄🎁

@cesar-lizurey I tested it locally and works great, thank you for it! Let's just bring the into text back to its original size and without the shadow and get this fix in 😄

Never mind, I made this change here 😄

Never mind, I made this change here 😄

You were faster than me!


Add a blank (or stub) /config/composer.local.json file?

I think it would be helpful to add a stub composer.local.json file to the /config directory (as a Docker volume), which would be either blank or (maybe better yet) look something like:
{
	"extra": {
		"merge-plugin": {
			"include": [
			]
		}
	}
}

This could make life easier for the administrator - so that they know where that file should go, and what it should look like.

I agree completely

This could probably be added in the Canasta-DockerCompose repo.

What would be the benefit of that (if any)?

That's eventually going to be the correct place to make this change. Right now, the Docker Compose "stack" is intermingled with the stuff that comprises the Canasta image. We should split them in the near future.

Looks like this is done now! This issue is halfway between "resolved" and "declined", since the file was added, though to the Docker Compose repository and not this one.


Polyhedra is not deleted

When switching from model_style 2 to 1, the polyhedra is still there.

fixed in #53


Update documentation on pip installation.

Simtools can be installed from pypi, this should be added to the documentation.
This should also include the uploaded documentation on pypi, which is not entirely correct (e.g., authors). This is related to #525
Pypi link: https://test.pypi.org/project/gammasimtools/

This issue can be closed.

pip installation is in the documentation (see here) including the still necessary warning that this is not as well tested as the other installations. Note also that this is a rather old version (we don't release often enough)

pypi documentation is correct (including contact email), see here


Reach out to vendors when shields.io is ready for primetime.

We have few languishing issues from vendors that either reached out, or that we discovered were trying to using the style we set forth but didn't quite succeed in doing so.
As soon as shields.io is live and kicking we should reach out to all these folks and urge them to update their shield implementations. :smiley:

Outdated.


[$500] No error message when editing a chat to go past character limit

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: 1.3.95-5
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @grgia
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1699281873727459
Action Performed:

Open app
Go to a report and enter > 10K characters
Observe the error message
Edit a message and enter >10k characters

Expected Result:
Error message should appear
Actual Result:
No error message and could not send the message
Workaround:
unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android: Native
[ ] Android: mWeb Chrome
[ ] iOS: Native
[ ] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[ ] MacOS: Desktop

Screenshots/Videos
Add any screenshot/video evidence
https://github.com/Expensify/App/assets/38435837/1dd18f5f-0598-4c9f-b7af-4873d2c191d7

View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~019dbff50a5a453b18
Upwork Job ID:<PHONE_NUMBER>178677760
Last Price Increase: 2023-11-13

Proposal
Please re-state the problem that we are trying to solve in this issue.
When editing a message, length validation does not work.
What is the root cause of that problem?
Passing reportId to ExceededCommentLength.js in ReportActionItemMessageEdit.js

causes it to be incorrectly initialised with empty value inExceededCommentLength.js:

What changes do you think we should make in order to solve the problem?
We don't need to pass reportId.

What alternative solutions did you explore? (Optional)

Proposal
Please re-state the problem that we are trying to solve in this issue.
The 10,000 character max error message does not show when editing an existing message.
What is the root cause of that problem?
The ExceededCommentLength component checks the onyx store directly for the comment value. It is currently set up to check for the draft of a new comment, but not for the draft of an existing comment, which uses a different Onyx key.
What changes do you think we should make in order to solve the problem?

ExceededCommentLength should not be tied to the Onyx store. It is only used in two places, and it's simple to pass the draft directly to the component, rather than add logic to ExceededCommentLength to fetch the right draft from the store.
We should remove the withOnyx() HOC from this component and allow it to receive the comment direct through the comment prop that is currently populated through Onyx.
What alternative solutions did you explore? (Optional)
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

Proposal
Updated

Recognized that the ExceededCommentLength component was connected to Onyx for performance reasons
Changed recommendation to have consumers pass in the onyx key for the comment draft rather than hardcoding the key
Allows minimal change, no new components need to be created
Allows flexibility as new consumers can specify the key without needing to update logic in ExceededCommentLength.

@burczu can you review the proposals?

@abekkala I'm sorry, I've missed that one - I'll review proposals soon.

@erquhart Could you please be more specific how the ExceedCommentLength component should be changed? How do you want to use this new draftKey property in case on composing and editing?

@tienifr I've tried your solution but it does not work for me. Could you be more specific how do you pass reportActionID to the component and where?

Proposal
Please re-state the problem that we are trying to solve in this issue.

No error message when editing a chat to go past character limit

What is the root cause of that problem?

ExceededCommentLength uses the comment prop to decide if it will display error or not (when comment.length > 10K, it will display error). This comment is from ONYXKEYS.COLLECTION.REPORT_DRAFT_COMMENT
And ExceededCommentLength uses in ReportActionItemMessageEdit as well, so when the main composer has < 10K characters, edit composer has > 10K characters, the edit composer will have no error.

What changes do you think we should make in order to solve the problem?

Rather than getting the comment from ONYXKEYS.COLLECTION.REPORT_DRAFT_COMMENT, we can just pass the comment param to ExceededCommentLength from its parent component. This can fix this issue, also reducing the delay time in updating max length error (currently, when user types more than 10K, it will delay 1500ms before displaying error).
We can do it by these below steps:

Remove subscribing ONYXKEYS.COLLECTION.REPORT_DRAFT_COMMENT
https://github.com/Expensify/App/blob/2c7062b917a2d31b709691166633f171dd1fce8c/src/components/ExceededCommentLength.js#L63-L68
With ReportActionItemMessageEdit, we do not need do anything because we have already had the below logic:
https://github.com/Expensify/App/blob/2c7062b917a2d31b709691166633f171dd1fce8c/src/pages/home/report/ReportActionItemMessageEdit.js#L468
With ReportActionComposer, updating
https://github.com/Expensify/App/blob/358c3bf4fd161c51cf4ea00110576af3afe03ce9/src/pages/home/report/ReportActionCompose/ReportActionCompose.js#L454
to

<ExceededCommentLength comment={value} ... />

What alternative solutions did you explore? (Optional)

Also, we rather than passing the comment param to ExceededCommentLength from its parent component like the above solution, we can just pass the param called isExceedMaxLength to ExceededCommentLength from its parent component.

@burczu ExceededCommentLength has a hardcoded key in the withOnyx config object, which is the norm, but we can pass it through props so any key can be used and the consumer can specify.
Before:
export default withOnyx({
    comment: {
        key: ({reportID}) => `${ONYXKEYS.COLLECTION.REPORT_DRAFT_COMMENT}${reportID}`,
        initialValue: '',
    },
})(ExceededCommentLength);

After:
export default withOnyx({
    comment: {
        key: ({draftKey, reportID}) => `${draftKey}${reportID}`,
        initialValue: '',
    },
})(ExceededCommentLength);

Thanks for your updates @erquhart and @tienifr, I'll get back to your proposals soon.
@DylanDylann So, your solution actually rolls back the changes introduced in this performance PR: https://github.com/Expensify/App/pull/25758 - are you sure it actually improves the performance?

@burczu Before, we need to display exactly the current input length, for example 12000/10000, so we need to get the comment from Onyx - that will be updated with 1000ms delay to increase the performance. But now, we just need to know whether the input is greater than the MAX_COMMENT_LENGTH or not, so my proposal suggestd that, we just need to pass the isExceedMaxLength to ExceededCommentLength from its parent. Besides fixing this bug, it also reduce the delay time when updating the error (Currently, updating error has 1500ms delay)

The 1500ms delay is an intentional debounce, the current setup avoids the component fetching the comment directly to keep evaluation out of the render. Sidestepping this will decrease performance unless you move the debounce into each consumer of ExceededCommentLength, which is why #25758 centralized the comment length check.

@DylanDylann Thanks for explanation, but I agree with @erquhart's comment here.
That being said, after I've reviewed all the proposals I tend to like the most the one from @erquhart, but with additional change - what if instead passing the draftKey to the ExceededCommentLength we could pass some boolean flag, like isEditMode and let the component decide which Onyx key to use based on that? This way, the component would be easier to use. What do you think?
The solution proposed by @tienifr is somehow similar but it is based on more complicated condition, so in my opinion is less preferable, but we could also consider it.
🎀 👀 🎀 C+ reviewed

@burczu as I mentioned above, I think debounce 1500ms is unnecessary

Now, we just need to know whether the input is greater than the MAX_COMMENT_LENGTH or not, so my proposal suggested that, we just need to pass the isExceedMaxLength to ExceededCommentLength from its parent. So the ExceededCommentLength just re-render once the isExceedMaxLength update from "true" to "false" or vice versa.

@burczu Also please note that, the solution that I mentioned is my alternative solutions

@tienifr Ahh, you are right - I've slightly mixed both solutions while testing... Re-tested everything again and indeed passing additional reportActionID prop is necessary because we need it to retrieve the comment from the object if we are in edit mode. I'll change my proposal recommendation. Sorry for my mistake.

@DylanDylann By agreeing with @erquhart I meant that just passing isExceedMaxLength to the ExceededCommentLength component will force us to move debouncing to the parent components for keep the performance, so I don't think it's best solution here.

@bernhardoj Ah, yes - it looks like some kind of workaround for me - I think taking the comment from correct Onyx key for creating and editing comments seems to be more consistent than taking it from Onyx in one case and from props in another.

Let's now wait for @tgolen opinion because I'm curious what he thinks.

@burczu needing to also pass the report action id with my proposal is an implementation detail, I'm hoping code in my proposal is treated as pseudo code. The approach in my proposal still works, and is still the best to maintain existing performance improvements for the ExceededCommentLength component.

All right, coming in with fresh eyes, I see we have multiple proposals here. Every time I've come across a similar problem (one component needing a piece of data that could exist in two different collections like a draft collection and a regular collection), the best solution I've always found is to lift up the onyx connection to the parents. I think this is the most simple, cleanest, most straightforward solution.
The only argument I hear against that is that it would undo a change that was made for performance. That's good to know, but it doesn't need to be a blocker for the solution. As long as the solution does not degrade performance, then that's really all that matters.
I think the RCA from @DylanDylann was the most comprehensive and easiest for me to understand and I think both the main solution (only pass down comment) or the alternate solution (have a prop for isExceedMaxLength) is acceptable as long as you are able to prove that there is no performance decrease. I am leaning more toward isExceedMaxLength or maybe call it something like shouldDisplayError. Also, I'd love to get rid of the debounce. As I understand, the performance problem isn't in checking the length of the comment, but rather in the re-rendering of the component.
@DylanDylann can you please show evidence that your solution won't lead to a performance regression, and then I think the job is yours.

@tgolen Here is the evidence that my solution won`t lead to performance regression:

The current main branch (The ExceedCommentLength re-reder once the input changes)

My solution https://github.com/DylanDylann/App/tree/fix/30921-no-error-message-when-editing-a-chat  (The ExceedCommentLength only re-render once the isExceedCommentLength changes)

Screencast from 18-11-2023 11:28:09.webm

Thank you @DylanDylann. @burczu are you OK with this proposal then? I know it's not the one that you originally approved, but it's the one I prefer.

@tgolen Sure, let's got with the proposal you prefer the most.

OK, thanks! @DylanDylann it's all yours.

I'm heading out for the Thanksgiving holiday and will be back bright and early Monday morning.
@DylanDylann can you note when you expect a PR to be ready?

@abekkala I am working on it and will open PR today

@burczu PR https://github.com/Expensify/App/pull/31769 is ready to reivew

note: deployed to staging Dec 14

@laurenreidexpensify
STATUS:
I'm going ooo but this one is at the finish line and waiting payment on Dec 26.
Then, if regression test is needed a GH will need to be created for that.

Issue reported by: @grgia (no payment 😉)
Fix: @DylanDylann [$500, if no regressions] Offer link
PR Review: @burczu  [$500, if no regressions] please complete checklist.

Just a heads up I am OOO until 28 Dec, @DylanDylann @burczu so this will only be paid then, we have a skeleton team working next week so a few payments may be a little bit late

Payment Summary:
Fix: @DylanDylann $500 paid in Upwork
PR Review: @burczu N/A - expert contributor (callstack)
@burczu please complete checklist steps thanks

@burczu bump to complete checklist thanks

@burczu can you please complete the checklist so this issue can be closed. thanks!

LAST TASK: waiting on @burczu to complete checklist, then this issue can be closed.

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[x]  [@burczu] The PR that introduced the bug has been identified. Link to the PR:

https://github.com/Expensify/App/pull/25758

[x]  [@burczu] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:

https://github.com/Expensify/App/pull/25758#issuecomment-1880557320

[x]  [@burczu] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:

Not found any.

[x]  [@burczu] Determine if we should create a regression test for this bug.

I think it may be worth checking if we have such test for creating the report message and update it with the check for editing report message as well.

[x]  [@burczu] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

I'll post the regression test proposal in a separate message.

[ ]  [@abekkala] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

Regression test proposal

Open the app.
Go to a report and enter > 10K characters in the message box.
Check if the error message appears.
Update the message to have less than 10k characters and post it.
Edit this message and again enter >10k characters.
Check if the error message appears.

Do we agree 👍 or 👎


chore: since .nvmrc is committed to the repo, remove it from .gitignore

What does this PR do?
chore: since .nvmrc is committed to the repo, remove it from .gitignore
Signed-off-by: Nick Boldt<EMAIL_ADDRESS>Screenshot/screencast of this PR
N/A
What issues does this PR fix or reference?
N/A (or see commit message above for issue number)
How to test this PR?
N/A
PR Checklist
As the author of this Pull Request I made sure that:

[x] The Eclipse Contributor Agreement is valid
[x] Code produced is complete
[x] Code builds without errors
[ ] Tests are covering the bugfix
[x] The repository devfile is up to date and works, if one exists
[x] Sections What issues does this PR fix or reference and How to test this PR completed
[x] Relevant user documentation updated
[x] Relevant contributing documentation updated
[x] CI/CD changes implemented, documented and communicated

Reviewers
Reviewers, please comment how you tested the PR when approving it.

having the file ignored meant that in midstream repo we were also missing .nvmrc, which caused issues w/ the specific version of nodejs used to run the builds.

https://github.com/janus-idp/rhpib/commit/8d41ccb5104b0ba13906887769a6c999a7c94fe9
but then it was added back
https://github.com/janus-idp/rhpib/commit/6ec012353de71bb6a811d4352c833ba0a0b4d41a#diff-bc37d034bad564583790a46f19d807abfe519c5671395fd494d8cce506c42947

If you don't like this change, I could instead have a forked version of .gitignore downstream


Tip: Error code 500 and 400

Is it a problem with the openAI server?

should be a problem on my end, API seems to be working just fine, I'm checking on it...

fixed it, wrote some stupid code when handling errors, causing it never return the actual stream 🥲


User Profile isn't where it's supposed to be.

This started with the recent discord update that broke a bunch of addons on replugged as well.
I wish I could be of more use but sadly, I don't know CSS at all

Made a profile just to comment on this! I desperately want to fix this :( If anyone knows how to fix it please let me and op know


feat: extra label row list fields

Introduction and Explanation
Associated SDK changes for the BE pr.

Hi @james-encord, I was wondering what was the intention behind encord/py.typed ?


feat: port Control.Functor.Multivariate

During porting I noticed some inconsistent naming in TypeVec (relLast'/predLast'  should be RelLast'/PredLast').
Since TypeVec was only merged yesterday, I'm relatively certain no other PR's depend on it yet and I figured I'd fix that naming in this PR as well.
If it's better to do that separately, I can undo that last commit!

bors merge


add print

@pisee Please sign the Contributor License Agreement!
Click here to manually synchronize the status of this Pull Request.
See the FAQ for frequently asked questions.


Duplicate Method setContent in IncludedNote.java

This can't be right?

Link to first setContent-Method: https://github.com/ZUGFeRD/mustangproject/blob/7c9f17218ae097541c1dfc65d7ffed322cd8510b/library/src/main/java/org/mustangproject/IncludedNote.java#L75
Link to seconds setContent-Method: https://github.com/ZUGFeRD/mustangproject/blob/7c9f17218ae097541c1dfc65d7ffed322cd8510b/library/src/main/java/org/mustangproject/IncludedNote.java#L90

Setters were already added with the previous commit a7db7acc1df1a4bc5566e8137bb98de2facfb7ae.
One setter got replaced, one duplicated.
In general I would really appreciate, that current master does compile and run tests successfully after every commit.

In general I would really appreciate, that current master does compile and run tests successfully after every commit.
No


Periodically local storage gets cleared

Could be a race condition that only triggers occasionally.

Potential bandaid solution: make sure local storage item can't be written to if it's empty

Maybe fixed by 3da382579e51faefa35d51bf3f40774a5f3379be


Different languages not working on Deezer

Good morning, I've just checked that extension was not working on Deezer; and just took a look at the code, and it is happening because the selector for getting buttons is using aria attribute, so it is not consistent between languages (if you have the browser in a language that is not English, aria-label will not be 'Next' and it will not work, for instance in Spanish it is 'Siguiente'):
"www.deezer.com": {
  buttonBased: true,
  next: `'.svg-icon-group-btn[aria-label="Next"]'`,
  prev: `'.svg-icon-group-btn[aria-label="Back"]'`,
  playPause: `'.svg-icon-group-btn[aria-label="Pause"], .svg-icon-group-btn[aria-label="Play"]'`,
}

As this selectors are being used directly to apply the click event; and there is no a 'parent selector' in JS, I can't get a clean direct solution to this because the 'back', 'play', 'next' classes are directly in the child svg item; and it is not clickable directly through click() method.
In a dirty way, maybe it could be fixed using this selectors, but I don't know if there could be any side effect (that empty svg-icon-group-item list items that deezer put there are really suspicious, but it seems that they are using it just for margin):
"www.deezer.com": {
  buttonBased: true,
  next: `'.svg-icon-group-item:nth-child(5) .svg-icon-group-btn'`,
  prev: `'.svg-icon-group-item:nth-child(1) .svg-icon-group-btn'`,
  playPause: `'.svg-icon-group-item:nth-child(3) .svg-icon-group-btn'`,
}

It should work with current Deezer HTML structure, and doesn't need to modify the JS working with diferent flows; working just like it is doing till now, but in every lang.
Thanks for your work! If I can help with something, let me know!

Hello!
This extension is a bit outdated now as there is default support for media keys on Chrome now.
Have you tried removing the extension and trying to use your media keys on Google Chrome ?
Many thanks


Upload an existing yaml file

This feature was requested to allow users that had downloaded/curated partial yaml files to be able to upload their yaml and continue on using the UI.

Awesome thanks! Taking a look.

Rebased with updated next.js (v15)

Hey @nerdalert, @mingxzhao, @vishnoianil, rebase has been done and this one is ready for review when you guys get chance.

@Misjohns This PR adds a feature where user can upload an existing skill/knowledge yaml file (in case they save the yaml to resume the work later). Current PR adds it as a form group (see below snapshot).

I am wondering if we should use a button that says "Upload Existing Yaml" button. What would you recommend here?

@aevo98765 We upgraded the main branch to pattternfly6 now, so you might have to rebase your branch over main, and give it a test run.

So the proposal would be to add this to the contribution form? The user would still need to fill out the other fields in the form to submit?

I recommend placing this feature at the very top of the page. I have included my recommendations below. Once we settle on a direction I'll get someone from content to finesse the copy.

So the proposal would be to add this to the contribution form? The user would still need to fill out the other fields in the form to submit? @aevo98765 @vishnoianil

Yes, yaml will fill all the fields for which data is available in yaml, rest all field will be filled by the contributor (such as email/name, brief description etc).

I recommend placing this feature at the very top of the page. I have included my recommendations below. Once we settle on a direction I'll get someone from content to finesse the copy.

I am more inclined toward second option, because it's more visible, compared to link in first option.

One minor tweak to Option 2. We should make the YAML button a secondary button instead of a primary. The primary button is at the bottom of the form to submit.

@vishnoianil g2g on this one?


merge main into v1

This was a bit tricky to merge due to all the file reorganizing, and the merge commit is likely messy. The easiest way to review this PR is to compare the differences to main before and after:

Before: v1 against main at the time.
After: jkarneges/update-v1 against main.

Before, the only change was making the legacy runner the default, and this is still the case after the update.

% git --no-pager diff 97c4d6a301d78a7a5066487c22311f0f502b0b55..v1

diff --git a/CHANGELOG.md b/CHANGELOG.md
index 882be35..60bc9b4 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -1,6 +1,11 @@
 Pushpin Changelog
 =================

+v. 1.39.1 (2024-03-18)
+
+  * Regenerate pushpin.conf.inst post-build to ensure up-to-date configuration.
+  * Update legacy runner use revised Qt linking logic, aligning with main branch improvements.
+
 v. 1.39.0 (2024-03-14)

   * Add support for multiple proxy worker threads.
diff --git a/Cargo.toml b/Cargo.toml
index 35d8bdb..9125e5b 100644
--- a/Cargo.toml
+++ b/Cargo.toml
@@ -82,11 +82,6 @@ name = "pushpin-handler"
 test = false
 bench = false

-[[bin]]
-name = "pushpin-legacy"
-test = false
-bench = false
-
 [[bin]]
 name = "pushpin"
 test = false
diff --git a/postbuild/postbuild.pro b/postbuild/postbuild.pro
index 495766b..bbdbe7e 100644
--- a/postbuild/postbuild.pro
+++ b/postbuild/postbuild.pro
@@ -31,10 +31,6 @@ handler_bin.target = $$bin_dir/pushpin-handler
 handler_bin.depends = $$target_dir/pushpin-handler
 handler_bin.commands = mkdir -p $$bin_dir && cp -a $$target_dir/pushpin-handler $$bin_dir/pushpin-handler

-runner_legacy_bin.target = $$root_dir/pushpin-legacy
-runner_legacy_bin.depends = $$target_dir/pushpin-legacy
-runner_legacy_bin.commands = cp -a $$target_dir/pushpin-legacy $$root_dir/pushpin-legacy
-
 runner_bin.target = $$root_dir/pushpin
 runner_bin.depends = $$target_dir/pushpin
 runner_bin.commands = cp -a $$target_dir/pushpin $$root_dir/pushpin
@@ -48,7 +44,6 @@ QMAKE_EXTRA_TARGETS += \
 	m2adapter_bin \
 	proxy_bin \
 	handler_bin \
-	runner_legacy_bin \
 	runner_bin \
 	publish_bin

@@ -57,7 +52,6 @@ PRE_TARGETDEPS += \
 	$$bin_dir/m2adapter \
 	$$bin_dir/pushpin-proxy \
 	$$bin_dir/pushpin-handler \
-	$$root_dir/pushpin-legacy \
 	$$root_dir/pushpin \
 	$$bin_dir/pushpin-publish

@@ -65,7 +59,7 @@ PRE_TARGETDEPS += \

 pushpin_conf_inst.target = pushpin.conf.inst
 pushpin_conf_inst.commands = sed -e \"s,configdir=.*,configdir=$$CONFIGDIR/runner,g\" -e \"s,rundir=.*,rundir=$$RUNDIR,g\" -e \"s,logdir=.*,logdir=$$LOGDIR,g\" ../examples/config/pushpin.conf > pushpin.conf.inst
-pushpin_conf_inst.depends = ../examples/config/pushpin.conf
+pushpin_conf_inst.depends = ../examples/config/pushpin.conf conf.pri

 QMAKE_EXTRA_TARGETS += pushpin_conf_inst
 PRE_TARGETDEPS += pushpin.conf.inst
@@ -79,7 +73,6 @@ unix:!isEmpty(BINDIR) {
 		$$bin_dir/m2adapter \
 		$$bin_dir/pushpin-proxy \
 		$$bin_dir/pushpin-handler \
-		$$root_dir/pushpin-legacy \
 		$$root_dir/pushpin \
 		$$bin_dir/pushpin-publish
 	binfiles.CONFIG += no_check_exist executable
diff --git a/src/bin/pushpin-legacy.rs b/src/bin/pushpin-legacy.rs
deleted file mode 100644
index a44608a..0000000
--- a/src/bin/pushpin-legacy.rs
+++ /dev/null
@@ -1,27 +0,0 @@
-/*
- * Copyright (C) 2023 Fastly, Inc.
- *
- * Licensed under the Apache License, Version 2.0 (the "License");
- * you may not use this file except in compliance with the License.
- * You may obtain a copy of the License at
- *
- *     http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- */
-
-use pushpin::{call_c_main, import_cpp};
-use std::env;
-use std::process::ExitCode;
-
-import_cpp! {
-    fn runner_main(argc: libc::c_int, argv: *const *const libc::c_char) -> libc::c_int;
-}
-
-fn main() -> ExitCode {
-    unsafe { ExitCode::from(call_c_main(runner_main, env::args_os())) }
-}
diff --git a/src/bin/pushpin.rs b/src/bin/pushpin.rs
index c15c559..a44608a 100644
--- a/src/bin/pushpin.rs
+++ b/src/bin/pushpin.rs
@@ -14,58 +14,14 @@
  * limitations under the License.
  */

-use clap::Parser;
-use log::{error, info, LevelFilter};
-use pushpin::log::{ensure_init_simple_logger, get_simple_logger, local_offset_check};
-use pushpin::runner::{open_log_file, ArgsData, CliArgs, Settings};
-use pushpin::service::start_services;
+use pushpin::{call_c_main, import_cpp};
 use std::env;
-use std::error::Error;
-use std::process;
+use std::process::ExitCode;

-fn process_args_and_run(args: CliArgs) -> Result<(), Box<dyn Error>> {
-    let args_data = ArgsData::new(args)?;
-    let settings = Settings::new(&env::current_dir()?, args_data)?;
-
-    let log_file = match settings.log_file.clone() {
-        Some(x) => match open_log_file(x) {
-            Ok(x) => Some(x),
-            Err(_) => {
-                error!("unable to open log file. logging to standard out.");
-                None
-            }
-        },
-        None => None,
-    };
-    ensure_init_simple_logger(log_file, true);
-    log::set_logger(get_simple_logger()).unwrap();
-    let ll = settings
-        .log_levels
-        .get("")
-        .unwrap_or_else(|| settings.log_levels.get("default").unwrap());
-    let level = match ll {
-        0 => LevelFilter::Error,
-        1 => LevelFilter::Warn,
-        2 => LevelFilter::Info,
-        3 => LevelFilter::Debug,
-        4..=u8::MAX => LevelFilter::Trace,
-    };
-    log::set_max_level(level);
-
-    local_offset_check();
-
-    info!("using config: {:?}", settings.config_file.display());
-    start_services(settings);
-
-    Ok(())
+import_cpp! {
+    fn runner_main(argc: libc::c_int, argv: *const *const libc::c_char) -> libc::c_int;
 }

-fn main() {
-    let args = CliArgs::parse();
-    info!("starting...");
-
-    if let Err(e) = process_args_and_run(args) {
-        eprintln!("Error: {}", e);
-        process::exit(1);
-    }
+fn main() -> ExitCode {
+    unsafe { ExitCode::from(call_c_main(runner_main, env::args_os())) }
 }


Memory Leak

          I upgraded openai version to 1.23.5

and still I can see some issues with the same function just it got moved to different place.
/Users/jogireddy/PycharmProjects/flaskProject/venv/lib/python3.9/site-packages/openai/_legacy_response.py:347: size=1389 KiB (+1389 KiB), count=12109 (+12109), average=117 B/Users/jogireddy/PycharmProjects/flaskProject/venv/lib/python3.9/site-packages/openai/_response.py:674: size=1278 KiB (+1278 KiB), count=11239 (+11239), average=116 B/Library/Frameworks/Python.framework/Versions/3.9/lib/python3.9/linecache.py:137: size=1232 KiB (+1232 KiB), count=12014 (+12014), average=105 B/Users/jogireddy/PycharmProjects/flaskProject/venv/lib/python3.9/site-packages/httpx/_content.py:175: size=868 KiB (+868 KiB), count=83 (+83), average=10.5 KiB/Library/Frameworks/Python.framework/Versions/3.9/lib/python3.9/functools.py:58: size=769 KiB (+769 KiB), count=12308 (+12308), average=64 B/Users/jogireddy/PycharmProjects/flaskProject/venv/lib/python3.9/site-packages/openai/_legacy_response.py:330: size=726 KiB (+726 KiB), count=6332 (+6332), average=117 B/Users/jogireddy/PycharmProjects/flaskProject/venv/lib/python3.9/site-packages/openai/_response.py:653: size=676 KiB (+676 KiB), count=5931 (+5931), average=117 B/Users/jogireddy/PycharmProjects/flaskProject/venv/lib/python3.9/site-packages/openai/_resource.py:34: size=358 KiB (+358 KiB), count=5088 (+5088), average=72 B/Library/Frameworks/Python.framework/Versions/3.9/lib/python3.9/abc.py:102: size=261 KiB (+261 KiB), count=2992 (+2992), average=89 B/Users/jogireddy/PycharmProjects/flaskProject/venv/lib/python3.9/site-packages/httpx/_models.py:82: size=249 KiB (+249 KiB), count=3736 (+3736), average=68 B
Originally posted by @rdy5644 in https://github.com/openai/openai-python/issues/1361#issuecomment-2076360795

As the comments suggested to reuse the OpenAI client
`from openai import AsyncOpenAI
_client = OpenAI(
provide a dummy API key so that requests made directly will always fail
api_key='<this client should never be used directly!>',
)
def get_openai(user: User) -> OpenAI:
return _client.with_options(api_key=user.openai_api_key)`
This is how I'm using the same client by overriding the api_key but still the problem persists and when I replaced it with normal api calls using requests the memory utilisation is stable.

The method 'with_options' makes a copy in fact,   you can take a look the source code in openai._client.py.
You should cache the client, maybe the api_key can be used the cached key.
`
using global variable or you can implentment an another class
openai_clients = {}
client = openai_clients .get(api_key)
if client is None:
client = openai.OpenAI(api_key = '')
openai_clients [api_key] = client`

Yes this is something I can try.
will give a try and get back

So when I tried the approach suggested for caching and creating a global client both didn't work as expected.
In case of reusing same client with_options function to override the api_key it didn't give any difference interms of memory issue.
and when it comes to client caching based on api_key as mentioned above. If we don't perform client.close() the number of open files getting increased and the memory usage seems to be increasing very rapidly.

I don't see a clear problem or action item for us here, so I'm going to close this issue.


document kube-apiserver identity

enhancement issue: https://github.com/kubernetes/enhancements/issues/1965

/assign @reylejano-rxm
/milestone 1.20
/sig api-machinery
/hold pending merge https://github.com/kubernetes/kubernetes/pull/95533 and https://github.com/kubernetes/kubernetes/pull/95895

/hold cancel
k/k prs merged
hi @roycaihw with k/k prs merged in, Sig Docs would appreciate it if you could get the docs content ready to be reviewed early, if possible, before kubecon. It will give us more time to make sure we get both tech/docs review on time before the release. Thank you!
Please don't forget to change the PR title once it's ready to be reviewed. (remove wip)

Hi @roycaihw , please change the PR title to remove the words "wip: placeholder" when the PR is ready.

@roycaihw, please keep in mind that the Docs PR Ready for Review deadline is coming up on Monday, November 23

It's ready for review. Please take a look. Thanks!

@kubernetes/sig-api-machinery-pr-reviewer , can we get a tech review (lgtm)
Thank you

/assign @kubernetes/sig-api-machinery-api-reviews

/unasign @kubernetes/sig-api-machinery-api-reviews

/remove-label kind/api-change

/remove-kind api-change

Hi @roycaihw if you address some of the comments above, I think this will be able to merge soon.

Page preview: https://deploy-preview-24921--kubernetes-io-vnext-staging.netlify.app/docs/tasks/administer-cluster/highly-available-master/#api-server-identity
/lgtm

/approve


scale_vpp: check out odd resolution for VPP

check out odd resolution for scaler VPP, if so print error, then return.
Signed-off-by: wudping<EMAIL_ADDRESS>

merged as 08e2403eec7212bfff8b8928d7702ef1935d5bcc


Issues in the inference script

Documenting the issues mentioned by @MerveKaptan in our email correspondence
What kind of input is necessary?
I would like to segment one specific mean image - is that possible? I do not think it is and I believe this may be the issue?

command:
python run_inference.py --path-dataset_bids /home/mkaptan/Documents/data/BIDS/derivatives/data_processed/sub-308/ses-02spinalcord/func/EM/sub-308_ses-02spinalcord_task-EM_bold_mc2_mean.nii.gz  --path-out /home/mkaptan/Documents/data/BIDS/derivatives/data_processed/sub-308/ses-02spinalcord/func/EM/path/  --path-model /home/mkaptan/Documents/EPIsegmentation/fmri-segmentation/inference/model_20240410-20240421T213048Z-001/model_20240410/  --use-best-checkpoint --path-qc /home/mkaptan/Documents/data/BIDS/derivatives/data_processed/sub-308/ses-02spinalcord/func/EM/path/

After I run this, I see the following on my terminal:

Found a dataset folder. Running inference on the whole dataset...
Creating temporary folder with proper filenames...
Starting inference...
perform_everything_on_gpu=True is only supported for cuda devices! Setting this to False
Running inference on device: cpu
Model loaded successfully. Fetching test data...
There are 0 cases in the source folder
I am process 0 out of 1 (max process ID is 0, we start counting with 0!)
There are 0 cases that I would like to predict
overwrite was set to False, so I am only working on cases that haven't been predicted yet. That's 0 cases.
Inference done.
Deleting the temporary folder...
----------------------------------------------------
Results can be found in: /home/mkaptan/Documents/data/BIDS/derivatives/data_processed/sub-308/ses-02spinalcord/func/EM/path/

tl;dr The inference script does not currently have the compatibility for running inference on a single image. It currently works for running inference on a whole dataset.

commit a48347e0a1dd8737db70c25ca7de2923d7edd66f solves the above mentioned issues.
@MerveKaptan can you please follow the following steps and then update if the errors still persists?
1. cd fmri-segmentation
2. git pull
3.

tl;dr The inference script does not currently have the compatibility for running inference on a single image. It currently works for running inference on a whole dataset.

SCT now has an nnUnetv2 wrapper, why not using it?

Oh right, that is the plan. This is a temporary script for inference. I'm in the process of making a new release with the round 2 trained model and integrate it into SCT.


Unable to verify your data submission since updated to 2.0.14

What steps will reproduce the problem?
Submit a form.
What is the expected result?
Form is submitted - data is saved or whatever the the form is supposed to do.
What do you get instead?
yii\web\BadRequestHttpException: Unable to verify your data submission. in /var/www/my.uhub.biz/vendor/yiisoft/yii2/web/Controller.php:166
Additional info
I haven't been able to submit any forms since updated to 2.0.14. Have updated to <IP_ADDRESS> and still same error. Have tried to clear all browser cookies, restart services and server, but still cannot submit forms. Form can be submitted if csrf is disabled but this is not an option.
Fall back to V<IP_ADDRESS> and it works as intended.

Q
A

Yii version
2.0.14  and <IP_ADDRESS>

PHP version
7.0.22

Operating system
Ubuntu 16.04

Did you follow this? http://www.yiiframework.com/doc-2.0/guide-security-best-practices.html#avoiding-csrf

@frontbear the link is about disabling csrf, which I followed to disable csrf and am able to submit the form. However I don't want to do that for security reason.
If downgrade back to 2.0.13 forms can be submitted. It's when updated to 2.0.14+ it forms can't be submitted and gets 'Unable to verify your data submission' error.

its similiar to bug that i encounter,  maybe related?

@rosancoderian I had a look at your issue and it seems to related to performance. I've been upgrading Yii fairly regularly and haven't noticed any performance issues. My only issue with the latest release is unable to submit forms.

Failed to reproduce. Please, supply more info, including request component config and controller

@SilverFire, thanks for looking into this. I'd say this is not easily reproduced as it works in 2.0.13 but not 2.0.14+. Here are info as per request. Please let me know if you need any more info.
In frontend/config/main.php:
'components' => [
        'request' => [
            'csrfParam' => 'csrf-frontend',
        ],
        'session' => [
            'name' => 'xxx-frontend',
        ],
],

As mentioned in original ticket it happens to all actions handling post data. Here's one that saves a record:
public function actionUpdate($id)
    {
        $model = $this->findModel($id);

        if ($model->load(Yii::$app->request->post())) {

            if ($model->save()) {
                return $this->redirect(['index']);
            }
        }
        return $this->render('update', ['model' => $model]);
    }

Could you try to reproduce it on basic app template?

I have the same issue since I have upgraded to <IP_ADDRESS> from 2.0.13. It happens rarely but for loaded project it is significant amount of bad requests apeared

Could you check if this is related to output created by echos instead of returning the content/data of the controller? Ie. during AJAX validation.
Possibly related: https://github.com/yiisoft/yii2/issues/15782

I can't reproduce it on my local developer machine. It is happened rarely on production. I'll keep trying to find

The problem with "remember me". Commit with breaking changes is 6c0540aa2d6e0fe0fa89e4fd35bba4be5d6cece7
Steps to reproduce:

Login with default yii2 auth functionality
Load a page with any ajax request post request
Remove cookie PHPSESSID
Submit post request

Problem  because of regenerating csrf token while restoring session from remember be token.

@sartor yes, that seems valid but I'm not sure how to solve that since not regenerating causes possible security issues.

May be it is possible to not regenerate session if it is recovered from "remember me" token? Is it a security breach?

Possibly not. Need to review it in detail.

My issue isn't related to just AJAX. It's any post - AJAX, form or even via links.
Thanks @sartor who mentioned 'remember me'. I stepped through my user model (which extends \yii\web\User). I resolved by extending login function:
public function login(yii\web\IdentityInterface$identity, $duration = 3600) {
        return parent::login($identity, $duration);
    }

Simply set $duration to any value > 0 and post now works.
This is probably not the correct solution but it resolves my issue.

I'm also seeing a higher than normal amount of "yii\web\BadRequestHttpException: Unable to verify your data submission" errors today after upgrading to <IP_ADDRESS>. Is there anything I can provide that might help you dig into this?
If it helps, I'm using the advanced template, each app with their own CSFR token.
'components' => [
        'request' => [
            'csrfParam' => '_publisher_csrf',
            'baseUrl' => '/publisher',
        ],

I subscribe to this, upgrading to latest version simply had me disable csrf token validation because of the high number of errors(Unable to verify your data submission) i get when submitting the forms.
There is def. something wrong.

The problem is well described by https://github.com/yiisoft/yii2/issues/15783#issuecomment-368964002

Verified that not regenerating token when prolonging via "remember me" cookie is OK security-wise.

I'm having this problem in a form which has a field decorated with a Select2 widget that performs an ajax to search and retrieve the select options through a webservice in the same app. It seems that the ajax response updates the CSRF cookie, but not the CSRF param of meta tag neither the CSRF hidden input. So that when I submit the form through a normal POST the CSRF validation fails because the CSRF state has changed since the page was rendered.
I tried to manually update the CSRF using Yii client API (yii.setCsrfToken()), but it didn't work.
Do you know any workaround to such case?

看看这篇文章   https://segmentfault.com/q/1010000004450797

@xutl I can't reach it.

If you login, you will call regenerateCsrfToken(). Since <IP_ADDRESS>

If you call Yii::app->user->login before '\yii\web\Controller\begoreAction' where validateCsrfToken , You will get 'Unable to verify your data submission.'

@feiyangzhang I'm having this issue on 2.0.16.
So i better always call regenerateCsrfToken() just before showing the login forms ?

Same issue. Can this be related to a reverse proxy (such as Apache Traffic Server - cached page with form and old CSRF token)?

@samdark Users are reporting about such case.

Open login form (when logged out).
Open login form in another tab (suppose they were doing something in different tabs and then appeared to be logged out in both tabs).
Enter credentials in the first tab and submit the form -- logged in OK.
Do the same in the second tab -- Unable to verify your data submission error. Suppose they expect to be logged in successfully.
Is this an official security behavior of the framework? What is a better workaround? Something more informative? Of course, except showing a 403 forbidden page?

@samdark Thank you. Just trying to customize the error message (by something like "Something went wrong. Please try closing and re-opening your browser window", etc.), because "Unable to verify your data submission" doesn't make any sense for the user. The only way I found is relying on the text (of course, if no translations are used), because the framework doesn't provide any specific error code or other states for this case.

@joeyblack835 normally user won't ever receive this message.

@samdark But this is what normal users are reporting and the client asked to make user friendly messages. :blush: Anyway, thank you for clarifying.


Fix expected url in db/index.test.js

This test isn't passed because of an error in the expected URL

In this PR the URL is corrected and the folder of webstorm configuration is ignored

Hey @Sergio401,
I just noticed that PR #209 by: @PChaparro which was submitted just few minutes before this PR, also includes the same fix.
It might be worth taking a look at that PR and considering whether the changes in this PR are still necessary or if they can be combined with the changes in PR #209.

Yes @Fasping, he won me for just a few minutes 😅. If @midudev decides close this PR, there isn't problem, my PR includes the gitignore of webstorm configuration folder because me (and maybe other people) work with webstorm, but I think it's not important.


Distribution file sounds quite big

Having a look to the chartjs-plugin-gradient.min is quite big, 170K and seems containing also the CHART.JS part needed to the plugin.
Even if I'm not an expert and maybe I'm wrong, I think rollup configuration should be changed in order do not include anything but resolve everything at runtime.

I'm working on that I'm going to submit a PR


Main functionality of E-field to healpix is complete

Tolerances on the interpolation precision are OK; open to revision.
fixes #281
fixes #198

Need to add this functionality to the tutorial

Thanks @adampbeardsley! I think I've addressed all your comments


Update npx.savez to workaround missing libzip inplace updates

Description
https://github.com/apache/incubator-mxnet/pull/19417 rewrites the npz archive for each added array due to lack of inplace appending support in libzip.

@mxnet-bot run ci [unix-cpu]
test_cv_model_inference_onnxruntime_resnet101_v1


Add COLR/CPAL support

This allows ufo-extractor to output UFO fonts which can be built as COLR/CPAL color fonts by fontmake, and also be understood as color UFO fonts by MFEKglif.
An example of this working is https://github.com/MFEK/TwemojiMozilla.ufo.
Based on my Twitter thread https://twitter.com/MFEKglif/status/1396819553041125378.
This patch was under the purview of the MFEK project because I needed a complicated example UFO font with many layers.

Coming back to this; now that color has been more settled, should this PR be updated?


test: Add timeout before checking for status

Under some slow environment (nested VMs) or with some
not as fast runtimes (Clear Containers), asking for a
status right away is racy.
Signed-off-by: Samuel Ortiz<EMAIL_ADDRESS>

:+1: even 10 would be good

@runcom On nested and low/small hosts we're much faster than 5s :) But I can still bump that one to 10s if you feel it's safer

👍 for 5s

Sure let's go with 5

[retest]

@sameo Can you rebase this test, so we can run the new tests on it.

Ping @sameo :)

@runcom Sorry to let that one rot...Rebased now.

/test all


AsEnumerable extension

Fixes https://github.com/aspnet/Configuration/issues/370
cc @divega

:shipit:
Heads up to @JunTaoLuo in case you want to remove the duplication in Hosting when this gets in.

Thanks for the heads up, I'll remove the dup when this goes in.

Why is this an extension method? Can't it be implemented more efficiently on the interface?

I don't think IConfigurationProvider exposes what we would need for a more efficient implementation,  E.g. it doesn't expose a way to enumerate all the keys in one shot. If making this the most efficient possible is the high order bit we can change that,  but otherwise this seems a better option.

Merged this, we can more changes in a subsequent PR if needed
b958a68eb96dc38e4606c214b2e23952f60af9ff


Improve generation of the statistics list in UI

Describe the Enhancement
This logic should be roughly consistent with the "aggregate_stat" job type in Stat-Analysis. This is an incomplete list, but we'd start with something like this:
Display CTS stats if the database contains CTS, CTC, or FHO data.
Display MCTS stats if the database contains MCTS or MCTC data.
Display CNT stats if the database contains CNT, SL1L2, or SAL1L2 data.
Display VCNT stats if the database contains VCNT, VL1L2, or VAL1L2 data.
Display PSTD stats if the database contains PSTD or PCT data.
And so on.

This request was described in the discussion: https://github.com/dtcenter/METplus/discussions/1448
Time Estimate
Estimate the amount of work required here.
Issues should represent approximately 1 day of work.
Sub-Issues
Consider breaking the enhancement down into sub-issues.

[ ] Add a checkbox for each sub-issue here.

Relevant Deadlines
List relevant project deadlines here or state NONE.
Funding Source
2702691
Define the Metadata
Assignee

[ ] Select engineer(s) or no engineer required
[ ] Select scientist(s) or no scientist required

Labels

[ ] Select component(s)
[ ] Select priority
[ ] Select requestor(s)

Projects and Milestone

[ ] Select Repository and/or Organization level Project(s) or add alert: NEED PROJECT ASSIGNMENT label
[ ] Select Milestone as the next official version or Future Versions

Define Related Issue(s)
Consider the impact to the other METplus components.

[ ] METplus, MET, METdatadb, METviewer, METexpress, METcalcpy, METplotpy

Enhancement Checklist
See the METplus Workflow for details.

[ ] Complete the issue definition above, including the Time Estimate and Funding Source.
[ ] Fork this repository or create a branch of develop.
Branch name: feature_<Issue Number>_<Description>
[ ] Complete the development and test your changes.
[ ] Add/update log messages for easier debugging.
[ ] Add/update unit tests.
[ ] Add/update documentation.
[ ] Push local changes to GitHub.
[ ] Submit a pull request to merge into develop.
Pull request: feature <Issue Number> <Description>
[ ] Define the pull request metadata, as permissions allow.
Select: Reviewer(s) and Linked issues
Select: Repository level development cycle Project for the next official release
Select: Milestone as the next official version
[ ] Iterate until the reviewer(s) accept and merge your changes.
[ ] Delete your fork or branch.
[ ] Close this issue.

we don't display FHO stats


Influx <IP_ADDRESS> crashes intermittently during startup

Hello
We have an influx docker image deployed on an Amazon EC2 machine. Usually it starts flawlessly, but maybe one time in 100 we get crashes in startup. I've attached the trace log from influx, and it seems like the influxdb process crashes. There are go stack traces around. It is hard to reproduce, but should it somehow be easier for you, I can try to provide you with the docker image, that rarely crashes though

influx-fail.txt

deployment.log.txt

Here is additional log which produces a similar stack trace after some load tests.

influx.err2.txt

Panic looks similar to #5303.

Fixed in 0.11.


inference time as a function of point number and frame number

HI authors of TAPIR,
Thanks again for your work.
I open this issue because i would like to know how the inference time change with respect to point and frame number.
Does the time goes up linearly w.r.t these two argument, or what other form of dependence?
I tried experimenting with it but my result varies a little from time to time, so i asked.
thanks~

Please find our study of inference time at Table 9 in the paper. https://arxiv.org/pdf/2306.08637.pdf
In the table, we limit our setup to maximum to 50 frames and 50 points. Inference time grows w.r.t. point and frame number but not exactly linear from our observation (we ran 10 times for each setup and average). The utilization of GPU allows the model to parallel compute feature maps and run iterative updates on multiple points simultaneously.
Inference time also grows with video resolution.


[Docs] Incorrect example code for using ElasticsSearch as search backend

Expected Behavior

The example code for using ElasticsSearch as search backend given in Backstage documentation site should be correct.
Actual Behavior

The example given is legacy code(?) that doesn't exist in the API.
Steps to Reproduce

Live documentation site: https://backstage.io/docs/features/search/search-engines#elasticsearch

Fixed in https://github.com/backstage/backstage/pull/13988


api documentation cleanup plus adding required role to each api endpo…

…int/route

Let's talk about the Route definition format tomorrow

resource path added back per dewayne


knot-dns: 2.7.6 -> 2.8.0

https://gitlab.labs.nic.cz/knot/knot-dns/tags/v2.8.0
Some explanation for the patching is in this ML thread:
https://lists.nic.cz/pipermail/knot-dns-users/2019-March/001616.html
Motivation for this change
https://github.com/NixOS/nixpkgs/pull/56922#issuecomment-470176678
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] N/A Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[x] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[x] Determined the impact on package closure size (by running nix path-info -S before and after): +69k
[x] Assured whether relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

I thought I'd wait with this, but it's related to the WIP for nixos knot service, so let me at least file this as PR early.


[support] Update polkadot dependencies

📝 Description
Update @polkadot/* dependencies
❓ Context

Impacted projects: LLC LLD LLM
Linked resource(s): https://ledgerhq.atlassian.net/browse/LIVE-8984

✅ Checklist

[ ] Test coverage
[ ] Atomic delivery
[ ] No breaking changes

📸 Demo

🚀 Expectations to reach
Please make sure you follow these Important Steps.
Pull Requests must pass the CI and be internally validated in order to be merged.

(replacing https://github.com/LedgerHQ/ledger-live/pull/4739 to attempt to pass CI)

tip for next time if you reach timeout issue on CI = they usually mean the app never loads / fails to load.
you can download the results from the CI

you extract one and you can check both the html report and the videos

from the video we see the problem

@lvndry I know that you tested builds before, and I still don't see a link between the error and the changes... please see if you reproduce by testing builds now, but there's something weird here.


feat: Mime on write

I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/
Summary
This PR allows guessing users' writing content types and will include it in the CONTENT_TYPE of HTTP headers.
fixes: #875

Add content_type in OpWrite.
Provide API called object.write_with(op: OpWrite)


Query: Forward tenant information via StoreAPI

First part of the query tenancy implementation.

[ ] I added CHANGELOG entry for this change.
[x] Change is not relevant to the end user.

Changes

Adds tenant information to query requests, and forwards them downstream via the StoreAPI to downstream stores/queriers.

Verification
So far this was manually tested. The plan is to add tests after the tenant label has been added to the metrics.

Thanks for the review, added a few unit tests now


Typescript 4.4 complains about missing module @emotion/core in index.d.ts

Describe the bug
Typescript 4.4 complains about missing module @emotion/core in index.d.ts
To Reproduce
yarn add react-easy-sort
tsc --watch --noEmit
node_modules/react-easy-sort/index.d.ts:270:18 - error TS2307: Cannot find module '@emotion/core' or its corresponding type declarations.
270     css?: import("@emotion/core").InterpolationWithTheme;
Expected behavior
No error from tsc
I'm still puzzled how this happens, since I don't find a reference to emotion in the repo here?

I just tried installing the latest version and I confirm there is an issue. I'll try to have a look quickly.

The fix was published in v1.3.3


Add maxValueLength

Like maxSelectorLength, to split value over multiple lines only if its length exceeds the specified limit.
I got results seemed weird now:
.x {
    transition-duration: 0.5s,
                         2s;
}

The following format seems prettier:
.x {
    transition-duration: 0.5s, 2s;
}

Makes sense. The logic for the maxSelectorLength needs a bit of cleaning up, so will do https://github.com/ben-eb/perfectionist/issues/1 at the same time.

By the way, I'm using perfectionist to generate formatted code showcase for my Less mixin library est and it works quite nicely now :)

Nice! :+1:


stack.yaml: Completely disable RDRAND support in cryptonite

Issue Number
Relates to ADP-428.
Overview
Ensures that RDRAND can never be the sole source of RNG entropy.
To generate mnemonics it goes through cryptonite Crypto.Random.Entropy.getEntropy. Disabling the RDRAND backend will leave just the WinCryptoAPI (windows) and DevRandom, DevURandom backends (not windows).

Ja. Damn AMD CPUs...

bors r+

bors r+


content_by_lua_block not working with tcp proxy_pass.

Hello I am new to nginx and openresty.
I am trying to dynamically route tcp connections.
But content_by_lua_block  doesn't seems to be working in tcp proxy_pass configuration however it worked with example http configuration.
error_log logs/error.log;
events {
    worker_connections 1024;
}

stream {
    # define a TCP server listening on the port 8080:
    server {
        listen 8080;
        set $target '';
        content_by_lua_block {
            ngx.var.target = "<IP_ADDRESS>:7000"
        }
        proxy_pass $target;
    }
}

But when i tried to add
set $target "<IP_ADDRESS>:7000";
It's working.
I've also tried to paste it inside location / {} but it also not working.
Please help me.

Moving to main repository.


PIN: relax bowtie2 pin to resolve community distro failures

Hi all! Finally back in the states and already looking forward to our next in-person sprint week 😉
In less fun news, it looks like our community distro builds are failing due to (big surprise) some dependency conflicts. In short, the bowtie2 version that's pinned in assembly is forcing some other dependency versions that are no longer compatible with the community distro. The more verbose explanation is below (from an internal cap lab thread with @ebolyen):
q2-assembly currently uses an older bowtie2 (2.4.4 vs. 2.5.1), which pins tbb to a 2020 version, which pulls numba down to a particularly old version. The current q2-diversity includes a line which pins numba, to 0.56.4, which is unsolvable with tbb 2020. To be clear, the older resolution involves the defaults channel which is almost never a good sign, so it's not like it's quite working right as is.
I pulled down q2-assembly locally and relaxed bowtie2's version to a min pin (bowtie2 >=2.4.4) - the tests still pass locally, so it doesn't seem like this update to bowtie2 would cause any issues with the current code in q2-assembly. I think this should resolve the community distro failures, so was hoping this could be merged sometime before our next release in a few weeks. With that being said, please let me know if updating this would be problematic for any reason I may have overlooked!

It looks like the tests mock the bowtie2 calls, so we'll need to test this manually still as I don't think the binary actually gets called.

Merging this as well (in order to get CI working, we need to externalize the pin).


MIME type for .tar.gz still wrong

Shows as application/octet-stream. Public file.
Sample data transaction:
https://viewblock.io/arweave/tx/eC25qQ0VtHEQmGB0npqBtv6mSrBX2e-TGQYohavE39o
App-Version is quite a bit behind as well.

Fixed on 1.22.1, closing


How to make individual predictions using the FNet example?

Issue Type
Support
Source
source
Keras Version
Keras 2.14
Custom Code
Yes
OS Platform and Distribution
Linux Ubuntu
Python version
No response
GPU model and memory
No response
Current Behavior?
Once I have used the script for the creation of an FNet network, I want to make predictions on individual entries, however, doing it this way generates an array with several values and there should only be 2. How to make individual predictions using the predict method?
reference: https://keras.io/examples/nlp/fnet_classification_with_keras_nlp/
Standalone code to reproduce the issue or tutorial link
When I use predict, I got a vector with shape (32, 3)

fnet_classifier.predict(({"input_ids": [tokenizer("Hi, I'm Erick")]}))

Relevant log output
No response

Using the same example when I predicted I got the shape 16,1
fnet_classifier.predict(({"input_ids": [tokenizer("Hi, I'm Erick")]})).shape
16/16 ━━━━━━━━━━━━━━━━━━━━ 0s 4ms/step
(16, 1)


No non-synonymous mutations found Check vc_nonSyn`` argumet in read.maf` for details

library(TCGAbiolinks)
query_SNV <- GDCquery(project = "TCGA-LIHC",
                      data.category = "Simple Nucleotide Variation",
                      data.type = "Masked Somatic Mutation",
                      workflow.type = "Aliquot Ensemble Somatic Variant Merging and Masking")
GDCdownload(query_SNV)
mafFilePath2 = dir(path = "GDCdata/TCGA-LIHC",pattern = "masked.maf.gz$",full.names = T,recursive=T)
library(maftools)
mafdata2 <- lapply(mafFilePath2, function(x) {read.maf(x,isTCGA = T)})
snv_data2 = merge_mafs(mafdata2)

Why this error occurred, thank you for your answer.

Hi,
I couldn't figure out the issue. But try the below workaround..
library(TCGAbiolinks)
query_SNV <- GDCquery(project = "TCGA-LIHC",
                      data.category = "Simple Nucleotide Variation",
                      data.type = "Masked Somatic Mutation",
                      workflow.type = "Aliquot Ensemble Somatic Variant Merging and Masking")
GDCdownload(query_SNV)
mafFilePath2 = dir(path = "GDCdata/TCGA-LIHC",pattern = "masked.maf.gz$",full.names = T,recursive=T)

library(maftools)
x = lapply(mafFilePath2, data.table::fread, skip = "Hugo_Symbol")
x = data.table::rbindlist(l = x, use.names = TRUE, fill = TRUE)
xm = maftools::read.maf(maf = x)

Hope this helps.

i have the same error,please help me,thank you


Hydra node names

Why
For purposes of monitoring adoption, number of entities involved with Hydra usage and simplifying classification of the data, an opt-in naming protocol for Hydra nodes would be very useful.
This will be very useful for the Hydra explorer to help identify, group and compare statistics from different projects using Hydra.
It could also conceivably be used for P2P protocols as well, similar to how ADA handles are ubiquitous for wallet identification; as it could perhaps be used in a new standard to specify the nodes with which you want to connect, or verify the identity of the nodes with which you are about to interact, using a human-readable tag.
What
TBD by team
How
TBD by team

@Trymyrt Would you be interested in naming nodes or rather the opened heads?
About the what: the hydra-node does have a --node-id argument which has a default, making this more compulsory to define could result in people using it .. or not as they would put generic names like "node-1" or "mynode" anyways. So I'd say the key question here really is: How could we get people to give us metadata about their project which we can put on-chain do track it via the explorer?
Could be related to #1655 too. i.e. that we could re-use this "tag" for identifying what head a script gets committed to.


Is StaticRef supposed to be public?

I see StaticRef isn't actually used anywhere. It seems like a useful thing to expose.
That said, I probably wouldn't expose it by making the type public..
Probably something like NotifyHandle::from_static<T: Notify>(_: &'static T) -> Self

Isn't StaticRef used in client libraries where a &'static T is used as a NotifyHandle?

Yeah, it's used in this public impl of From.

Ag, I missed that. Oops.


Automatic proxy download

Download free socks4/5 proxy lists from github or other sources such as https://github.com/TheSpeedX/PROXY-List

Hello,
I made support for URL in proxy file path.
https://github.com/crpmax/mc-bots/releases/tag/v1.2.2
So you can use something like
java -jar mc-bots-1.2.2.jar -l "https://raw.githubusercontent.com/TheSpeedX/SOCKS-List/master/socks5.txt" -t socks5


add rule blacklist

and put it in a "rule filter" together with the existing whitelist

it should all be resolved now @yulric


[INLONG-2143][sort] change pulsar dependency

Title Name: [INLONG-XYZ][component] Title of the pull request
where XYZ should be replaced by the actual issue number.
Fixes #2143
Motivation
Explain here the context, and why you're making that change. What is the problem you're trying to solve.
Modifications
Describe the modifications you've done.
Verifying this change

[ ] Make sure that the change passes the CI checks.

(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)

Added integration tests for end-to-end deployment with large payloads (10MB)
Extended integration test for recovery after broker failure

Documentation

Does this pull request introduce a new feature? (yes / no)
If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
If a feature is not applicable for documentation, explain why?
If a feature is not documented yet in this PR, please create a followup issue for adding the documentation

Codecov Report

Merging #2146 (79e9d52) into master (b446b85) will increase coverage by 0.01%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #2146      +/-   ##
============================================
+ Coverage     12.26%   12.28%   +0.01%
  Complexity     1157     1157
============================================
  Files           413      413
  Lines         35215    35215
  Branches       5542     5542
============================================
+ Hits           4318     4325       +7
+ Misses        30125    30119       -6
+ Partials        772      771       -1

Impacted Files
Coverage Δ

.../java/org/apache/flume/sink/tubemq/TubemqSink.java
55.42% <0.00%> (+4.00%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 986c3a8...79e9d52. Read the comment docs.