Can't resolve 'perf_hooks' in 'lcjs-example-0550-zoombandchart\node_modules@arction\xydata\dist'

project serves properly, just receive the following warning
Module not found: Error: Can't resolve 'perf_hooks' in 'E:\projects\lcjs-example-0550-zoombandchart\node_modules@arction\xydata\dist'
@ ./src/index.js 19:4-30
1 warning has detailed information that is not shown.
Use 'stats.errorDetails: true' resp. '--stats-error-details' to show it.

This warning can be safely ignored. It's caused by xydata library also supporting Node JS with the same files. This results in WebPack finding a Node JS require statement that can't be resolved when bundling for web.
This warning can also be removed by adding additional config to webpack.config.js
fallback: {
    'perf_hooks': false
}

in resolve field of webpack config
resolve: {
    modules: [
        path.resolve('./src'),
        path.resolve('./node_modules')
    ],
    extensions: ['.js'],
    fallback: {
        'perf_hooks': false
    }
},


🐛 BUG: Cannot wrangler pages deploy with pnpm from subdirectory

Which Cloudflare product(s) does this pertain to?
Pages, Wrangler core
What version(s) of the tool(s) are you using?
3.63.1 [wrangler]
What version of Node are you using?
20.11.1
What operating system and version are you using?
macos sonoma 14.5
Describe the Bug
Observed behavior
I build my pages project into a subdirectory which includes my functions, so I need to run pnpm wrangler pages deploy from that directory.  But when I do, wrangler seems to look in the wrong spot for the wrangler tmp.
My project root is /Users/ianvs/code/defined/webclient, and i run the following command from /Users/ianvs/code/defined/webclient/.definednet:
> pnpm wrangler pages deploy build/
✨ Compiled Worker successfully

✘ [ERROR] ENOENT: no such file or directory, open '/Users/ianvs/code/defined/.wrangler/tmp/pages-F5FXhL/functionsWorker-0.20030179475032694.js'

Note that it is not looking in code/defined/webclient, but rather code/defined, one directory too high.  The listed file does exist in the correct code/defined/webclient/.wrangler/tmp directory.
Expected behavior
Should execute successfully
Steps to reproduce

in a cloudflare pages project containing worker functions, move those functions into a subdirectory, and build your project into that directory as well.
from that directory, using pnpm, run pnpm wrangler pages deploy against your built project.

Please provide a link to a minimal reproduction
No response
Please provide any relevant error logs
No response

hi @IanVS
thank you for reporting this issue with us.
I am not able to reproduce this behaviour. I used https://github.com/cloudflare/workers-sdk/tree/main/fixtures/pages-functions-with-routes-app as my test Pages app. In this project, I:

created a new folder called ./test-app
moved public and functions inside of that new folder
ran npx wrangler pages deploy public from test-app

The .wrangler/tmp folder is correctly created under pages-functions-with-routes, and the app works correctly too.
I noticed you are running the dev command with pnpm and was wondering if you're not in fact meaning to run npx instead?

Hi @CarmenPopoviciu thanks for taking a look.
I use pnpm in my project, so I did intend to use that, rather than npx.  Note that it's in the issue description as well.  I hit this error when using wrangler-action, with the packageManager: pnpm flag.

Hi @IanVS, I am unable to reproduce your issue by running pnpm wrangler pages deploy either. Can you provide us more details on how to reproduce the issue you had? It would be even better if you can provide us a minimal reproduction. Thank you!

Thanks for taking a look @edmundhung.  Here's a minimal reproduction: https://github.com/IanVS/cloudflare-workers-issue-6224.  Steps are in the README.

hi @IanVS,
thank you so much for the reproduction repository ❤. It was extremely helpful in understanding what the issue at hand is. I can indeed confirm that if I run pnpm reproduce in that repro project results in [ERROR] ENOENT: no such file or directory, scandir '/Users/ianvs/code/experiments/cloudflare-pnpm-repro/build', however it appears the main issue here is not an issue with Pages itself, but is rather related to how your build/deploy scripts are set up.
The reason you're seeing that error is because Pages attempts to resolve the directory of static assets, in this case build, relative to the current working directory (which is the directory that was current when you started the reproduce command), in this case cloudflare-workers-issue-6224. The fact that your script cds into the .dist folder has no effect on how the cwd is evaluated, and therefore, Pages will attempt to find /cloudflare-pnpm-repro/build and error, since that directory does not exist.
The fix here would be pretty straightforward, in that you could have the deploy script run pnpm wrangler pages deploy ./.dist/build/, instead, which would work as expected. There's a caveat to that though.
Pages expects the dev/deploy commands to be run from what we call the "root" of the Pages project. This is where your functions should live, if any Pages Functions were to exist, and where Pages will look for Functions by default. In most of the cases, this will also be the root of your project.
In your example, the functions directory lives in cloudflare-workers-issue-6224/.dist, however, the reproduce command is run from its parent folder, cloudflare-workers-issue-6224. When Pages attempts to resolve the functions directory, it will again try to resolve it relative to the current working directory, and again fail. So my proposed fix would get the project deployed, but without your Functions.
Currently we do not support customising the path of the functions directory, and there are no current plans to do so. The simplest fix here would be to have your Functions live in the root of your project if possible. Otherwise you could:

adapt your scripts to factor in how the cwd is resolved
or run the build and deploy scripts separately

I hope this helps, but let me know if you have any more questions <3

Thanks for taking a look, @CarmenPopoviciu, but I have to question one thing.  You said that wrangler uses cwd to determine where to look for static assets.  But if that's the case, why does it still break when I manually cd .dist and then run pnpm wrangler pages deploy build/ directly from there?  In that case cwd should for sure be cloudflare-workers-issue-6224/.dist, but it still tries to look in the project root instead.  Furthermore, using npx wrangler pages deploy build/ from that subdirectory succeeds without any issue.
Considering this is supported in npx and not pnpm, and seems unrelated to cwd, would you consider reopening this issue?


Detect indirect update dependencies

Given these related entity types, with <- pointing to the principal:
A <- B <- C
If A is deleted and C is modified then the latter should be performed first (assuming B is not tracked and the FKs are defined on the PKs).

Also group the commands together if the three entities are sharing the same table.


TWS API

JIRA issue:
https://issues.apache.org/jira/browse/CAMEL-9001

Closing as per discussion in JIRA CAMEL-9001


Add a function to compute the terrain height at a point

Similar to CesiumJS's sampleTerrainMostDetailed.

when to update this?

This is currently no update. It remains something we want to do soon but we're not working on it yet. We will post here when anything changes.

Hello, has this function been updated?

When will the functions for obtaining terrain height be updated in cesium for unreal like the sampleTerrain and sampleTerrainMostDetailed functions in cesiumjs

As I said above, we'll post here when anything changes. Asking about it in the meantime only makes us take time answering this question instead of working on it (and other things).
If this is an urgent need for you, you have two options:

Implement it yourself. Everything is open source, after all. And in fact there's a working example in CesiumJS that you can use as a guide.
Contact our sales team to discuss if it might make sense to increase the priority of this feature by funding its development yourself. https://cesium.com/contact/#contact-sales

To anyone reading this later, though: please do indicate your interest in this (and other) features by reacting to the top post with a 👍. Thanks!

Just keeping tabs on forum posts. Came up on the forum here.

Hope to update this function in the future, it's really useful

it's really useful

No update to this? Seems like this should be higher priority.

We have open pull requests for this feature:

https://github.com/CesiumGS/cesium-native/pull/783
https://github.com/CesiumGS/cesium-unreal/pull/1421
https://github.com/CesiumGS/cesium-unity/pull/507

If all goes to plan, the feature will be in next week's release of Cesium for Unreal and Cesium for Unity.

We have open pull requests for this feature:

Add height-query function to Tileset #783
Add Unreal API for terrain height querying cesium-unreal#1421
Height query API for Unity cesium-unity#507

If all goes to plan, the feature will be in next week's release of Cesium for Unreal and Cesium for Unity.

Oh nice! Sound great :) Much appreciated.


Integrate OCR QA Estimation

Integrate OCR QA Estimation - check text output with dictionary (language-tool, german dictonary)

When #2 is done, the new version will be tagged and finished.


Add Cucumber format tests

Is your feature request related to a problem? Please describe.
As a project maintainer I want Cucumber style Cypress tests so that tests are human readable and easy to maintain.
Describe the solution you'd like

[ ] Add support for Cucumber style tests to Cypress:

https://www.npmjs.com/package/cypress-cucumber-preprocessor

Describe alternatives you've considered
N/A
Additional context
I have this functionality on the Stuart Clark blog site via this commit: https://www.npmjs.com/package/cypress-cucumber-preprocessor
However, it appears that it no longer works with the latest version of Cypress, or I was unable to get it working when I attempted to do so.
I found the following issue, but it is for a different package and may not be related: https://github.com/badeball/cypress-cucumber-preprocessor/issues/722

I did a little more work on it this morning and pushed by WIP code ^
I confirmed that the project has change ownership, and the badeball repo is correct: https://github.com/badeball/cypress-cucumber-preprocessor/issues/689
I also found the webpack processor docs, and used that config for this instance, but I was still not able to get it working: https://github.com/badeball/cypress-cucumber-preprocessor/blob/master/docs/quick-start.md


Builder cache doesn't handle packageConfigPaths

I've set up a test case for using the cache that fails: https://github.com/harrison/jspm-beta
Specific line causing the issue: https://github.com/harrison/jspm-beta/blob/master/builder.js#L23
Relying on fact that setCache pulls out compile and trace by reference so the original cache is mutated.
Should be able to reproduce by running:
npm install
./node_modules/.bin/jspm install
node watch.js

Error:
[TypeError: Cannot read property 'a.js' of undefined]

I've tried digging around further but haven't got that far:)

I've added a fix for this in https://github.com/systemjs/builder/commit/718ed485b96bc15ecd54ff7b8abb143f59f7015c.
The work around would be to alter https://github.com/harrison/jspm-beta/blob/master/builder.js#L4 to be either a plain object ({}) or a cache object of the form - { compile: { loads: {}, encodings: {} }, trace: {} }.

@guybedford sweet! That does fix the error with importing a.js but fails for lodash :(
Added this: https://github.com/harrison/jspm-beta/blob/master/src/app.js#L1
And get this on subsequent builds: jspm build error [TypeError: Cannot read property 'map' of undefined]

Initially had the lodash error but thought I had narrowed it down further..

@harrison that's due to it not being installed in the config file at https://github.com/harrison/jspm-beta/blob/master/src/jspm.config.js (the baseURL is the default configuration file folder, so package-level jspm.config.js file is being ignored).

@guybedford not sure I follow. What am I missing in the config? The initial build completes fine and includes lodash but any subsequent builds with a cache fail.

Ok, thanks this is an issue with the caching process for dynamic package configuration, which actually needs to be architected quite carefully. I will see what I can do here.

I've included a fix here pending release.

Released in 0.15.13.

@guybedford amazing!

@guybedford when's the next jspm beta release? Have a pr to switch our dashboard over to it :)

@harrison feel free to use the beta in production, it is production ready but it isn't released yet mainly due to waiting on the documentation update.

@guybedford planning too:) the current jspm beta has a strict dependency on builder 0.15.11 so was hoping for a jspm bump

Ahh sure, right of course. I'm on contract work this week, but will try and do one when I can.


allow custom labels for runs

example is in mnist-embeddings

Adding an extra name like this doesn't help: dirname + label can still be an existing directory.
Moreover, since you have a python variable already containing the actual name of the log directory, why still use auto_set_dir instead of calling set_logger_dir directly? auto_set_dir is just to automatically generate a name which "probably is what you want", saving just one line of code.


refactor(color-schemes): refactor setting of color schemes

SUMMARY

Refactor code of overriden color schemes
Adding TS file

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TEST PLAN

ADDITIONAL INFORMATION

[ ] Has associated issue:
[ ] Changes UI
[ ] Requires DB Migration.
[ ] Confirm DB Migration upgrade and downgrade tested.
[ ] Introduces new feature or API
[ ] Removes existing feature or API

Codecov Report

Merging #12857 (0a4d35e) into master (9a7fba8) will decrease coverage by 3.64%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #12857      +/-   ##
==========================================
- Coverage   67.04%   63.39%   -3.65%
==========================================
  Files        1022      489     -533
  Lines       50186    30193   -19993
  Branches     5204        0    -5204
==========================================
- Hits        33647    19141   -14506
+ Misses      16404    11052    -5352
+ Partials      135        0     -135

Flag
Coverage Δ

cypress
?

javascript
?

python
63.39% <ø> (-0.70%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

superset/db_engines/hive.py
0.00% <0.00%> (-85.72%)
:arrow_down:

superset/sql_validators/postgres.py
50.00% <0.00%> (-50.00%)
:arrow_down:

superset/db_engine_specs/hive.py
73.84% <0.00%> (-17.31%)
:arrow_down:

superset/databases/commands/create.py
83.67% <0.00%> (-8.17%)
:arrow_down:

superset/databases/commands/update.py
85.71% <0.00%> (-8.17%)
:arrow_down:

superset/connectors/sqla/models.py
84.31% <0.00%> (-6.28%)
:arrow_down:

superset/db_engine_specs/sqlite.py
90.62% <0.00%> (-6.25%)
:arrow_down:

superset/databases/commands/test_connection.py
84.78% <0.00%> (-4.35%)
:arrow_down:

superset/utils/celery.py
86.20% <0.00%> (-3.45%)
:arrow_down:

superset/models/core.py
85.59% <0.00%> (-3.27%)
:arrow_down:

... and 542 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9a7fba8...129e983. Read the comment docs.


service key creation on provision

Hi,
I want to create service key  automatically on creation of service instance. Is there any configuration available such that it will call create binding automatically after service instance creation, if not please let me know how to achieve it.
Regards,
Karthik M L

@Karthik-M-L as of today there is no way to do it w/o a bit of a hack. For example, you could create a service that doesn't support bind() at all (metadata's "bindable" is false), and then just return whatever creds you need on the createInstance response flow - as an extension. Of course, this will only work for your specialized platform code - not CF or K8s.
What is the environment, or platform, you're using?  And, is it not possible to just immediately call bind() right after the provision?  What's the usecase you're trying to solve?
Another option, might be to have the broker create the binding as part of the createInstance() but then have the bind() API just return the (already created) binding info/creds.

Hi,
We are using SAP cloud foundary, our service instance creation is in cf but the application consuming is not in cf. So instead of two steps creating service instance and creating service key, we want to reduce it to one step.
Regards,
Karthik M L

How do you plan on getting the credentials to the app?

We are thinking of maintaining the credentials in the destination or secure store.

"And, is it not possible to just immediately call bind() right after the provision?"
If I call bind after provision, how will platform get to know that I have created a service key. Is there any way we can send notification to platform??

Hey @Karthik-M-L
I think your best path for doing this is to create a script which calls cf create-service, waits for the provision to complete, and then calls cf create-service-key. There is no automated way to do this today in CF.


nuclear vs mitochondrial subtypes patterns

match current nuclear subtype or mito subtype pattern, results in TSV (DOSDP query)
delete existing logical definitions
generate from TSV the new logical definitions with the correct pattern (new pattern)

Example:
MONDO_0007415 'mitochondrial complex III deficiency nuclear type 1'
'mitochondrial complex III deficiency'
 and ('disease has basis in dysfunction of' some BCS1L)

To new pattern:
'mitochondrial complex III deficiency'
 and ('disease has basis in dysfunction of' some (BCS1L and ('part of' some nucleus)))

@cmungall

I don't think we should use nesting, and we don't need it here. The organellar origin is a property of the gene already


OCI boot volumes

Currently we create OCI images. Change this to OCI boot volumes.

I'll investigate, but I'm sure this is straightforward

@rstarmer I may be mistaken. I have read the docs further, and I am uncertain. Worth a read.

I was in error. A boot volume is an instantiation of a platform image or custom image. The documentation here describes in great detail:
https://docs.oracle.com/en-us/iaas/Content/Block/Concepts/bootvolumes.htm


Quartz does not honor manual updates to qrtz_triggers table

Steps to to reproduce

Create and persist a trigger with misfire instruction = 0
Update code base using API to use a new misfire instruction (e.g. 2)
New triggers persisted will be correct, however old triggers will not update
Manually updating the misfire_instr on quartz_triggers will persist until the next trigger fire time, when the record is replaced with the original misfire instruction - it appears that this is coming from the blob data persisted to the database.

Manual update to DB is not recommended. You should use the Quartz API where possible.


Added Uploadapplication.ps1 and Add-User-All-Workspace.ps1

Upload Application uploads the local application into the specified Workspace and creates it if it does not exist. it uses Power BI PowerShell CMDLETs.

@guyinacube  Please review and commit.
Regards

Upload Application which adds a user to Workspace specified or all the Workspace

@guyinacube Can you please check and do the merge?

@guyinacube Can you please review and let me know if there should be any changes, if not can you merge it to the branch?


[bug]: Tile ControlNet model for the chosen main model architecture [FLUX]

Is there an existing issue for this problem?

[X] I have searched the existing issues

Operating system
Windows
GPU vendor
Nvidia (CUDA)
GPU model
RTX 4060ti
GPU VRAM
16GB
Version number
5.3.0rc1
Browser
Chrome
Python dependencies
No response
What happened

What you expected to happen
After generating an image with FLUX, I right clicked the image and clicked Send to Upscale. Now that FLUX.1-dev-Controlnet-Union is available and installed, which explicitly says it includes Tile, I expected to be able to upscale an image using FLUX.
How to reproduce the problem
Install the Starter Bundle of FLUX models, including FLUX.1-dev-Controlnet-Union, and attempt to use a FLUX model (Dev or Schnell) to upscale an image.
Additional context
No response
Discord username
No response

Upscaling tab is not supported for FLUX at this time

@maryhipp I'm having the same issue for SDXL - Juggernaut XL V9
Should I open a different ticket?

@vinipx Sorry for the late response. Yes, please create a separate issue.


fix tiny typos

use Apple’s own writing
add missing space

 All committers have signed the CLA.


Update config.toml to prepare 1.20 branch for the release

Changing config.toml on dev-1.20 branch to prepare for v1.20 release
cc @jimangel @zacharysarah @irvifa @sftim

@annajung Thanks! Feel free to /hold cancel when you’re ready to merge.
/lgtm
/approve
/hold

Thanks @zacharysarah !
/hold cancel


Profile alignment broken

This theme breaks the alignment of the new profiles
Normal

With revert theme:

Ptb 86162 (70570e4)
BetterDiscord 1.1.1
Host 0.0.56
OS X 11.0.0 (20.6.0)

This is probably a PTB only problem because it is not happening to me.

Weird, it seems to have fixed itself. Not sure when that happened.

Nevermind, I apparently had the theme off when I was checking 😂 is still broken. Mine now has the nick centered too like in @mutageneral's screenshot but it's supposed to be left aligned as shown in my original post. If you disable the theme you'll see how it's supposed to be aligned.

@asportnoy

Nevermind, I apparently had the theme off when I was checking 😂 is still broken. Mine now has the nick centered too like in @mutageneral's screenshot but it's supposed to be left aligned as shown in my original post. If you disable the theme you'll see how it's supposed to be aligned.

Oh okay. I did not understand you correctly on the first time. Read the following closely.
The user profiles cards aka user modals where reverted because it is a part of Discord's rebranding, and this add-ons is about reverting it! The rebranding is basically every change's discord do since they announced the rebranding. Discord are going to change pretty much everything until it becomes a completely new look, the rebranded look.
Rebrand:

Revert:

Now it doesn't look exactly like the pre-rebrand look, but that's the subject of issue #29. I hope the theme maker will make it looks exactly how they used to look.
Now, if you want to personally want to turn off the changes done to the user modals you can follow the tutorial I posted in issue #24. The only difference to the tutorial is that you need to find "Revert new user modals" instead of "Revert reactions". Don't worry, it is a very easy process. Hopefully this will have helped you!

If you have any questions, ask me. Don't forget to close your issue when done.

@asportnoy it has been made a part of the theme which will soon be disabled by default, thanks


Sorting according to score in Lockout Championship

Describe the bug
Score Sorting in Lockout
Expected behavior
user who have more score should be above user with less score

Done


Add templating to dev commands

Is your feature request related to a problem? Please describe.
Currently dev validate and dev get-resources doesn't support templating the validation.
Describe the solution you'd like

Given dev
When target is a template
Then target is templated/executed

Describe alternatives you've considered
Run tools template -> then dev  on that. This is a stopgap solution but the extra step is mildly annoying
Additional context
Add any other context or screenshots about the feature request here.
Expected Deliverable

[ ] Dev validate supports template configuration + --set to override
[ ] Dev get-resources supports template configuration + --set to override

Adding this to the configuration and templating milestone. #647 is meant to be a catch-all for this work but open to more finely scoped issues.


Fix #265, implement cmake name based targets

Describe the contribution
Allow targets to be configured in targets.cmake by name, rather than a numeric index.
Fixes #265
Testing performed
Build system, sanity check CFE, and run all unit tests
Testing not fully completed - Initially submitting PR for design review/feedback.
Expected behavior changes
No change to FSW, but changes the way targets are defined in targets.cmake.
This includes backward compatibility for existing files/configs, however.
System(s) tested on
Ubuntu 20.04
Additional context
Also related to #710, this cleans up hardcoded CPU IDs that were in the platform config header file.
Contributor Info - All information REQUIRED for consideration of pull request
Joseph Hickey, Vantage Systems, Inc.

Would it make sense to consider transitioning the platform and mission cfe config file into cmake, similar to osconfig?

Would it make sense to consider transitioning the platform and mission cfe config file into cmake, similar to osconfig?

Yes, I think it would!  Particularly for some of the CFE TIME options - these could then be different source files rather than #ifdef chunks mixed in everywhere.
But that's a fairly big change to existing paradigms obviously - probably should be a separate steering committee discussion.

The msg module as currently drafted has started in this direction with source selection.  Which is clumsy since the rest of cFE uses the header file config.

CCB-2020-07-15 - Mark as deprecated for 7.0

Update - rebased to current main branch.  Should be good to go.

CCB 2020-08-19 Might break CI-Lab, test at the bundle level


Alerting API: showToastPopup is not working

In one of your integration, we are using showToastPopup method of AlertingApi to display notifications in PureCloud.
And suddenly it stopped working.
In our logs, there is an error message -> Cannot read property 'postMsgToPc' of undefined
I`ve tried to use an example from docs, but it also doesn't work:

Create Custom Client App with the https://mypurecloud.github.io/client-app-sdk/toast.html url (as provided in docs).
Click Send toast

Expected:
The toast notification is successfully displayed inside Pure Cloud.
Actual
The notification is not displayed.
purecloud-client-app-sdk version -> 1.4.0

@slavik-chapelskyi   Thanks for issue report.
For testing with the gh-hosted example, can you make sure you're providing a pcEnvironment querystring param?  For instance, https://mypurecloud.github.io/client-app-sdk/toast.html?pcEnvironment={{pcEnvironment}}.  That is my guess as to why you're not seeing the toast message in that case.  The default environment is mypurecloud.com and needs to be configured if you're running in a different region.
As for your other js error, that is very strange.  Can you tell us a bit more about your environment?  Are you consuming the library from CDN or npm?  If you're using the npm package, are you using webpack or another bundler?  We're wondering if the library is getting corrupted somehow at build time.

Another possibility is that maybe the function is being bound/invoked on a different context?  If it's not invoked on a ClientApp instance, the call would fail with the same type of error you're reporting.
// This should work
const myApp = new ClientApp(...);
myClientApp.alerting.showToastPopup(...);

// Binding to a different context will not work
myClientApp.alerting.showToastPopup.call({}, ...);

@justinaray Thank for quick respond.
That was my bad.
I've missed to add pcEnvironment in https://mypurecloud.github.io/client-app-sdk/toast.html and that`s why though that it doesn't work.
Your second comment help me to figure out the issue.
After last refactoring we had, it turned out that myClientApp.alerting.showToastPopup was called in different react component in a way that it context was not bound to ClientApp instance any more.
Sorry for bothering you with this.
Thank you again for helping with this.
Have a nice day :tada:


ci: add support for go vulncheck

Overview

Checklist

[ ] New and updated code has appropriate documentation
[ ] New and updated code has new and/or updated testing
[ ] Required CI checks are passing
[ ] Visual proof for any user facing features like CLI or documentation updates
[ ] Linked issues closed with keywords

Codecov Report

Merging #2744 (58e3f55) into main (03beaef) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #2744   +/-   ##
=======================================
  Coverage   19.62%   19.62%
=======================================
  Files         139      139
  Lines       16999    16999
=======================================
  Hits         3336     3336
  Misses      13341    13341
  Partials      322      322

Can close b/c https://github.com/celestiaorg/celestia-app/pull/2969 merged


support self-signed certificate and fix target branch name issue

support self-signed certificate and fix target branch name issue

@mlarhrouch is this picking the branch name on older version of DevOps automatically ?


Remove unnecessary debug output

Codecov Report

Merging #257 into master will decrease coverage by 0.08%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master     #257      +/-   ##
============================================
- Coverage      79.1%   79.01%   -0.09%
  Complexity      515      515
============================================
  Files            63       63
  Lines          1431     1425       -6
  Branches        235      235
============================================
- Hits           1132     1126       -6
  Misses          206      206
  Partials         93       93

Impacted Files
Coverage Δ
Complexity Δ

...tionpipeline/githubtestreporter/WebHookReceiver.kt
86.66% <ø> (-2.23%)
9 <0> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a450636...c41820d. Read the comment docs.


Pass resolver's data/request context to DI container

This will allow using context dependant injections. This is extremely useful for tracking logs by individual requests.
The library is really cool. One thing that is preventing me from using it - inability to pass request context to DI Container.
Example
import { useContainer, buildSchema } from "type-graphql";
import { createContainer, asClass } from "awilix";

import { SampleResolver } from "./resolvers";

const container = createContainer().register({
  SampleResolver: asClass(SampleResolver),
});

// register the 3rd party IOC container
useContainer({
  get(someClass: any, resolverData: ResolverData<{requestId: string}>) {
    const scopedContainer = container.createScope().register({
      requestId: asValue(resolverData.context.requestId),
    });

    return scopedContainer.resolve(someClass.name);
  }
});

// build the schema as always
const schema = await buildSchema({
  resolvers: [SampleResolver],
});

I have thought about this design earlier but I resign from implementing it because I haven't found a way to enforce unique context/token to scope the container to individual graphql request on a schema level. Of course you can provide function to graphql-yoga or express-graphql and have it but someone may forget about it and have issues in debugging the resolvers/services that shouldn't be singletons. It's complicate the design and makes too much magic.
Secondly, I think that the container per request idea is against the spirit of single-threded, event-loop based Node.js ecosystem. By creating all services/controllers/resolvers per request we goes straight to the "request -> process spawn -> response -> process died". It will will have huge impact on memory usage and total active connection (remember about graphql subscriptions that keeps alive, they're not closed after a few seconds like http request).
We already has this discussion in rest framework:
https://github.com/typestack/routing-controllers/issues/174
My conclusion is that the services should be stateless, not scoped to user/request. All the "dynamic" data should be normally passed by params explicitly.

This is extremely useful for tracking logs by individual requests.

I see what's your point. You want some magic to implicitly under the hood pass the data to service, instead of passing it by hand:
@Resolver()
export class UserResolver {
 constructor(private logger: Logger) {}

 @Query()
 getAll(@Ctx() ctx: Context) {
   this.logger.log("message", ctx);
 }
}

I think the solution for this problem might be #45 but it will work only with Resolver classes.
@Resolver()
export class UserResolver {
 @Query()
 getAll(@InjectLogger() logger: Logger) {
   this.logger.log("message");
 }
}

I will have to think how to implement this wisely, maybe using node-continuation-local-storage. For now I will have reimplement this PR (or push commits to your branch) without lodash and using TypeDI in tests. And if I don't find a better way, I will make this feature official by providing examples and proper docs.

Hi @19majkel94!
Sorry I didn't write answer earlier. My bad.
About using context. Of course, there is no way to enforce context on a schema level. It's a server's responsibility to inject it. But as far as I know, there are plenty of tools to help with it. For example, recommended in graphql-js docs express-graphql is passing the whole request to the resolver's context by default:
context: A value to pass as the context to the graphql() function from GraphQL.js/src/execute.js. If context is not provided, the request object is passed as the context.

Maybe someone will forget, maybe for someone, it's unnecessary complex. But it's okay. Developers building complex things using complex (complicated sometimes) tools. Someone may forget anything at any time. It's impossible to avoid completely. But the good thing about context in resolvers - you have to specifically set it up. It's like the settings for an advanced user that knows what he wants to get. For the rest - reasonable default behavior, singletons, and no problems at all.
About single-threaded spirit. Sorry, but why it's even an argument? A scoped container has nothing to do with threads. And it's doing no more harm to NodeJS way then DI in general. Sure it's more expensive for the performance and memory, and it's okay to warn about it. But who could guess user's budget for memory, space, amount of clusters, how much nodes he could spin? It's quite possible that ability to have better monitoring for all servers means much more for him. At least for me, knowing impact on memory and getting all the benefits of "requestId" in logs, it's a tradeoff worth to make. And, actually, passing context to container resolver has no impact on performance in the context of type-graphql.
If this discussion has happened in the context of 'typedi' library, I'd say, sure, you right, you think it's a wrong way to make containers and you don't have to force yourself to create a scoped container. But, we're talking about type-graphql. The library, that promise support for (any) containers, and saying nothing about incompatibility with certain types of them. It's just wrong. Any user using "wrong" type container will just waste time trying to fit the library in a project.
The solution with passing log's related context with "requestId" is something. If a server is anything a bit more complex than a wrapper over DB, there will be a lot of methods. I was doing it, it's awful. A lot of noise, a lot of tedious and useless work. I'd prefer to stay away from the library, then coming back to such a solution.
How about to add an explicit option to pass context to containers. It will be turned off by default. And you'll warn in the documentation to use it only if it's REALLY necessary. I'll remove all unnecessary dependencies like lodash and uuid, but I'd prefer to have a test with a scoped container. And TypeDI doesn't suit well for this. Of course, if you don't mind an option thing and passing context to containers.
Again, thank you for the library! DI or not DI, it was a pleasant acquaintance!

I understand your point. It's easy to pass the context to container's get function and it has no performance impact. But my doubts are about implementing any weird stuffs that results in complete mess in user's codebase.
I just want to balance between universality/elasticity and being opinionated. I try to analyze all use cases that user's report and find the best solution for the problem. The solution that fit to the idea and is clean and simple.

It's like the settings for an advanced user that knows what he wants to get. For the rest - reasonable default behavior, singletons, and no problems at all.

I get it but from my experience, a lot of the people don't read the docs. They will just copy the code from examples and get it troubles by instancing the whole world for each request.

About single-threaded spirit. Sorry, but why it's even an argument? A scoped container has nothing to do with threads. And it's doing no more harm to NodeJS way then DI in general. Sure it's more expensive for the performance and memory, and it's okay to warn about it.

Node.js is single threaded so there's no thread overhead for each request like in PHP. You don't have to instantiate the whole app for each request like php frameworks do by Apache, so you can handle hundreds of thousands parallel connections (websockets). If you have scoped containers that creates all services, resolvers and repositories for each request (or websocket connection), you loose the main benefit of Node.js - great resources utilization. You will pollute the memory with plenty of instances just for implicitly passing some context data.

But who could guess user's budget for memory, space, amount of clusters, how much nodes he could spin?

More and more developers recently are switching from Node.js to Go for large scale microservices that works on clusters. So I definitely have to profile this feature to get know how much impact it has for http and subscriptions and warn about it in docs.

I'll remove all unnecessary dependencies like lodash and uuid, but I'd prefer to have a test with a scoped container. And TypeDI doesn't suit well for this.

TypeDI has Container.of feature for scoped containers and @Service({ global: true }) for pure services (singletons), so it's not a problem. I will try to play with it this week :wink:

Hi @19majkel94,
Didn't know TypeDI supports scoped containers! Worth to check it =)
It's an interesting thing that all your reasoning centered in preventing dumb users to hurt themselves in the areas outside the library's responsibility. Usually, reasonable default settings + rich customization suits for users better. Take for example, react-create-app that has the easiest default settings and, simultaneously, has the power to customize set up however suits for a user's need. It's not trying to cripple a fellow developer.
Okay, please, have a look, have a thought, check the performance ;)
I'll try to replace awilix with TypeDI and will get rid of unnecessary dependencies.

 Usually, reasonable default settings + rich customization suits for users better. Take for example, react-create-app that has the easiest default settings and, simultaneously, has the power to customize set up however suits for a user's need. It's not trying to cripple a fellow developer.

Ideally, I would like to have a slim basic core and all integration and not common features would be a plugin. There would be a @typegraphql/common package that gathered common plugins in one product + typegraphql CLI for generating the project like create-react-app 😉

@19majkel94, sounds good!

@scalder27 Please take a look at the example of TypeDI integration with scoped containers:
https://github.com/19majkel94/type-graphql/tree/79321593b9719646dcacb30f5fa72a72f4e6162b/examples/using-scoped-container

Right, thanks for pointing that!
I forgot about it because again, it's hard to hook into the last field resolver.
Your solution with middleware (graphql-middleware or TypeGraphQL middleware) has no memory leaks but it creates a fresh scoped container for each resolver, even field resolver.
I have to figure out how to hook into this lifecycle. The only solution might be creating own express/koa middleware, like vesper makes a wrapper:
https://github.com/vesper-framework/vesper/blob/68ba63931a6d3f370463e51321fe2902dd4fcf4e/src/index.ts#L99

@19majkel94 hi!
Yeah, sure you right about graphql middlewares.
Based on graphql-yoga docs it should be something like:
const server = new GraphQLServer({
    schema,
    // we need to provide unique context with `requestId` for each request
    context: (): Context => ({
      requestId: Math.floor(Math.random() * 1000000), // uuid-like
    })
});

// keep in mind that using scoped container could be dangerous, sometimes you have to take care of freeing memory.
server.express.use(disposeScopedContainerMiddleware);

I'm not sure whether graphql-yoga support after express middlewares.
But thankfully the formatResponse option works great!
formatResponse: (response: any, { context }: any) => {
  console.log((Container as any).instances.map((it: any) => it.id));
  Container.reset(context.requestId);
  return response;
},

I've tested it with sleep(10000) in resolver and 3 concurrent requests. The console.log printed:
[ 866135, 427927, 73156 ]
[ 427927, 73156 ]
[ 73156 ]

Anyway, it looks complicated end error prone.
I think I would have to create my own GraphQLServer implementation in @typegraphql/http or common, where I would expose the before/after request hooks. It allows me to control the query execution so I would be able to support document-level middlewares that would be called once per request, not once per resolver (multiple times per query). So it would be then soooo easy to create a middleware for creating and destroying scoped container.

formatResponse hacky as hell ;)
but I don't know a good 100%-bulletproof way for after-request middleware in express

Ah, wait, something like this should work:
const createContextMiddleware = (req, resp, next) => {
  req.context = {
    requestId: Math.floor(Math.random() * 1000000), // uuid-like
  };
  next();
};

const disposeScopedContainerMiddleware = (req, resp, next) => {
  const context = req.context;
  req.once("end", () => {
    if (Container.has(context)) {
      Container.reset(context)
    }
  });

  next();
};

const server = new GraphQLServer({
  schema,
  context: (req): Context => req.context
});

server.express.use(createContextMiddleware);
server.express.use(disposeScopedContainerMiddleware);

@scalder27
Thanks, res.once("finish" works! 😃 But again we need an express middleware for injecting context into req object to retrieve it in disposeScopedContainerMiddleware.
So I will leave the formatResponse workaround for now, until documentMiddlewares arrive:
https://github.com/prismagraphql/graphql-yoga/issues/314

@scalder27
I just figure out that we don't need that changes and pull request at all.
Scoped container means that there is a separate instance of container for each request. And to make it work per request, we have createContextMiddleware. So we can easily create there an instance of container base on requestId and attach it to context object.
const createContextMiddleware = (req, res, next) => {
  const requestId = Math.floor(Math.random() * 1000000); // uuid-like
  req.context = {
    requestId,
    container: Container.of(requestId),
  };
  next();
};

And to avoid the need of creating a wrapper to use in useContainer:
// create a wrapper for TypeDI `Container.of` scoped container feature
export const ScopedContainer = {
  get(someClass: any, { context }: ResolverData<Context>) {
    // use context to get scoped container
    const container = context.container;

    // then get from container like normal
    return container.get<any>(someClass);
  },
};

I would rather expand its definition to pass a function to extract the container from resolver data:
useContainer(({ context }) => context.container);

Sorry for the delays in working on this feature that is a must-have for you but I need to ensure that the API is the best I can achieve to prevent future refactoring and breaking changes 😉

@19majkel94,
It's a really good idea! More flexible, more predictable!

Closed via #121 and published in v0.13.0 🎉

@19majkel94 thank you very much!


⚠ Avatar API Endpoint has degraded performance

In 267c97e, Avatar API Endpoint (https://avatar.roblox.com/v1/avatar-rules) experienced degraded performance:

HTTP code: 200
Response time: 1053 ms

Resolved: Avatar API Endpoint performance has improved in 7587333 after 2 minutes.


Revert "Bump tinkerbell/hegel to latest release (#3939)"

This reverts commit 8c6cb61c206f03c401b2799fc1291054eac7fb9d.

/approve

/lgtm


feat(http): thread methods

Adds the current thread methods to the client. This has been tested.
Fixes #973.
Blocks on #1015.

Blocked on #1017 as well. Can't believe I missed that.


docs: improve help command output

Compare with curl --help all -- lots of short and to the point help information that doesn't wrap on small screens.
We have more to share for these flags, but I'm tried to condense help commands to the bare minimum without losing meaning.


New container bidscoin 4.3.1

There is a new container by @stebo85, use this command to test:
bash /neurocommand/local/fetch_and_run.sh bidscoin 4.3.1 20240328

If test was successful, then add to apps.json to release:
https://github.com/NeuroDesk/neurocommand/edit/main/neurodesk/apps.json
Please close this issue when completed :)

Ok, thank you


Fix help command

It's getting paginated because of all the image commands; find a better way to send them

Fixed in 09f5b08907aac3fd731c41b8cc4b6b7e8a3f6b50. No longer list image collections when calling base help, instead use list_reactions command.


County or Equivalent (A2)

The scroll down menu does not function, but it may be only due to the version of ArcMap (10.3)

Have you populated the County or Equivalent values for your organization? These are not populated, please see GIS Data Provider Specific Domains.


Templating exporter should have clear error reporting

Fixes #3382
Changes proposed in this pull request:

Adding error reporting
Adding unit tests for the Templating exporter
Resolve all json errors

Testing:
TC1:

TC2:

TC3:

TC4:

TC5:

@allanaaa - It would help me, if you could provide me some more syntaxes that can be used in the templating exporter. I think adding a few more test cases will make sure this doesn't break.

@wetneb Based on the discussion, I have added a regex to test the keys, which allows { "UR{N": {{jsonize(cells["URN"].value)}}, "foo:"bar }. And throws an error for all invalid syntaxes.

@sjathin I don't know how I could explain the issue better, really. The templating exporter can be used for any text-based format.
For instance you could use it to generate a CSV, some XML, some BibTeX files, or anything else really!
See for instance this template which generates some MODS file: https://gist.github.com/sallain/7604ffb0c155294fcfaf
Or this example for another XML format: https://blogs.bl.uk/digital-scholarship/2015/12/using-open-refine-to-create-xml-records-for-wikimedia-batch-upload-tool.html
Or this example for Bibtex files: https://github.com/caltechlibrary/open_refine_bibtex/blob/master/row_template.txt
For this reason, we should not assume anything about the format of the text in static fragments. Is that clearer?

Yes, I get it now, much more clearer now, thank you for explaining.

In the interest of getting this merged, I have removed your changes to the templating parser itself, since they were based on a misunderstanding of the sort of templates that were acceptable or not.

Thanks, @wetneb for completing the PR.


Optimize shallow_clone for Bytes::split_{off,to}

If shallow_clone is called with &mut self, and Bytes contains
Vec, then expensive CAS can be avoided, because no other thread
have references to this Bytes object.
split_off_and_drop benchmark becomes 5% faster on my host (MacBook Pro, 2,2 GHz Intel Core i7).
This is related to #88.

Interesting. It looks like most of the work done in shallow_clone including the atomic load above. Maybe we could split this into two fns:
fn shallow_clone(&mut self) {
// ...
}

fn shallow_clone_sync(&self) {
....
}

Anything in common could maybe be broken out.

It is not easy to split these function avoiding-copy-paste and keeping function readable.
Why would you want to split function in two? If you are worried about runtime overhead of branching, it could be replaced with function type parameter. Here.

This would be way nicer with an extra exclusive: bool parameter instead. The compiler will happily inline it (probably even without #[inline] annotations) and remove the branch.

Seems like the branch is out of date. If @arthurprs is correct, then the benchmarks should show it and the cleaner code is preferable 👍

My first version of patch had mut_self parameter (which is the same as exclusive). Have a look at second commit: https://github.com/carllerche/bytes/pull/92/commits/70dbf6cdb9d3aed9af87dd861300beb5c49fa03a.
Benchmark shows nothing, because branch is cheap (in this case) even if function is not inlined.
I can revert PR to that version.

I think the boolean argument is clearer. I'd revert to that.

I went checking and the compiler won't inline it by itself, but since it's now showing in the benchs the clearer the better.

I've rebased a patch and returned a version with mut_self parameter.
Regarding benchmark, I've previously said that with batch split_off became 5% faster. While it is definitely faster with patch, but because variance is high, it is hard to exactly, how much faster. I believe that's because of unstable malloc performance.

@carllerche Is there anything new for this PR?
Thank you.

rebased patch
updated bench to use longer buffer (just in case Bytes won't be upgrading short vecs to ARC on split in future version)
updated shallow_clone doc mentioning mut_self


Move "version" inside transaction body and include it in what gets hashed

Right now, the "version" (version number of the transaction model) of a transaction lives outside of the "transaction" in the transaction data model.
Also, when computing the id/hash of a transaction, the "version" isn't included in what gets hashed.
Proposal: move "version" inside the "transaction" body and include it in what gets hashed (when computing the transaction id/hash).
Fulfillment signatures already include the "version" (in what gets signed), so this would make signature-calculation more consistent with hash-calculation (in transactions).

@ttmc Note that this feature might have implications on backwards compatibility.

Resolved by pull request #518


DelayedExecutor / CuPy (+others) support

In checking the documentation for 0.9.0 (#1193), I realized that we haven't considered CuPy / CUDA support with the DelayedExecutor, except the convenience method get_resources_from_udfs() mentioned here CUDA and Scheduling.
I'm not sure we've ever tested CUDA-based execution (CuPy or otherwise) with DelayedJobExecutor. Certainly there is no capacity in the DaskBufferWrapper implementation to allocate the result arrays on the device (the lib kwarg to .allocate is ignored).
Dask does have some capacity to integrate with CuPy at the array level (https://docs.dask.org/en/stable/gpu.html), but I haven't tested it in the DelayedJobExecutor context. I'm putting this issue out so that there is a trace of that.

Another note, I pushed a prototype branch with the capacity to allocated chunked, cupy-backed Dask arrays as buffers:
https://github.com/matbryan52/LiberTEM/compare/83179d9..delayed_cupy
One thing I hadn't quite appreciated is that even when a UDF runs with cupy as backend and 'device' buffers, the results buffers are always allocated as numpy arrays. (I haven't had much opportunity to use GPU-backed LiberTEM because it's hard to access a GPU here). So, for my initial comment I think CuPy-backed UDFs will work with the Delayed Executor because inside the UDFTask itself we run normal (dask-free) implementations for the Buffers, and only on the main node will we create the Dask-chunked results. (which would never have been cupy anyway).
I'll try to test this assertion on ptycho or another system, however.


Add rolling-ops library

Overview
Currently there is no locking during charm upgrade. This means that we rely entirely on juju for ordering of unit upgrades. This can mean that during an upgrade where you have two units the second unit’s upgrade can begin before the first unit is ready to accept traffic (it may be compiling assets or running s3 migrations as part of the config-changed hook that comes after a charm upgrade hook).
This PR adds the rolling-ops library to handle our charm upgrades.
Juju Events Changes
The upgrade-charm event fires now an acquire_lock that will be used by the rollingèops library to roll out changes gradually.
Checklist

[x] The charm style guide was applied
[x] The contributing guide was applied
[x] The changes are compliant with ISD054 - Manging Charm Complexity
[x] The documentation is generated using src-docs
[x] The documentation for charmhub is updated.
[x] The PR is tagged with appropriate label (urgent, trivial, complex)

Perhaps it is worthwhile to create an integration test that demonstrates the rolling restarts? Just to make sure we're using the library correctly?

Perhaps it is worthwhile to create an integration test that demonstrates the rolling restarts? Just to make sure we're using the library correctly?

Yes, we did discuss this with @nrobinaubertin and @mthaddon - initially the idea is to have unit tests (they cover imo that rolling ops is used as intended and should make sure we don't introduce regressions) and think about what integration test to have to cover the aspect of rolling ops as well.
Looking at the integration tests I have an idea - we might want to introduce scaling the app (I think we test with a single unit), then think of an upgrade test - this is akin to what postgresql charm is testing, they don't explicitly test rolling ops afaik. A basic smoke test should be also fine, similar to the example in rolling ops lib - this requires an action for a restart in place if we do it in the same manner.
Needs to be further discussed and refined, though we're definitely discussing it. The upgrade itself doesn't necessarily come with downtime and I'm not sure we want to have a test that can always cause downtime and we prove it to be fixed via locking through rolling ops, might be too much. Anyway, these are solely my thoughts. What do you think about this @jdkandersson ? Do you have also suggestions on the integration tests? Thanks for the comment!

Perhaps it is worthwhile to create an integration test that demonstrates the rolling restarts? Just to make sure we're using the library correctly?

Yes, we did discuss this with @nrobinaubertin and @mthaddon - initially the idea is to have unit tests (they cover imo that rolling ops is used as intended and should make sure we don't introduce regressions) and think about what integration test to have to cover the aspect of rolling ops as well.
Looking at the integration tests I have an idea - we might want to introduce scaling the app (I think we test with a single unit), then think of an upgrade test - this is akin to what postgresql charm is testing, they don't explicitly test rolling ops afaik. A basic smoke test should be also fine, similar to the example in rolling ops lib - this requires an action for a restart in place if we do it in the same manner.
Needs to be further discussed and refined, though we're definitely discussing it. The upgrade itself doesn't necessarily come with downtime and I'm not sure we want to have a test that can always cause downtime and we prove it to be fixed via locking through rolling ops, might be too much. Anyway, these are solely my thoughts. What do you think about this @jdkandersson ? Do you have also suggestions on the integration tests? Thanks for the comment!

@merkata that sounds good. I think what the rolling ops does is that it ensures that the upgrades are done one unit at a time? Perhaps the integration test could trigger and upgrade and just make sure that the app is available throughout the upgrade?


Cannot read property 'registerPlugin' of undefined in Angular2

I want to use this plugin in angular7 but something go wrong.
angular.json

import videojs from 'video.js';
this.player = videojs('nowVideo');

Uncaught TypeError: Cannot read property 'registerPlugin' of undefined
at videojs-offset.js:19
How to fix?

Hi @adsl99801 ,
Yes, you are right it does not work as it suposed to work in projects managed by angular cli. I'll investigate further.
In the meantime, a solution would be to include videojs as a global script as well.
Try something like this in your angular.json:
...
"scripts": [
   "node_modules/video.js/dist/video.js",
   "node_modules/videojs-offset/dist/videojs-offset.js"
]
...

Also remove any import videojs from "video.js" in you modules/components and start using videojs as global. For example use window['videojs'].
Does it make sense for you?

I'm closing this issue due to inactivity.


chore(pre-commit): Configure pre-commit defaults

This change is part of the following stack:

#52

#53

#54

#55

#56

#57

#58

#59 ◀

Change managed by git-spice.


PHP Proxy Doesn't work

When I ping the proxy URL, it displays OK
But in practice when I try to visit https://mydomain.com/proxy/proxy.php?https://orgurl.maps.arcgis.com/sharing/rest/portals/self?f=json it returns a 500 error.

Closing. This repo is no longer maintained and will be archived shortly.


Simplify contraction methods

Lots of duplication to be removed.

I think this might require #17 which in turn requires #18.


SPSearchResultSource doesn't allow an empty ScopeUrl

Details of the scenario you tried and the problem that is occurring
https://github.com/dsccommunity/SharePointDsc/wiki/SPSearchResultSource instructs that if you want to set a global result source, you should leave ScopeUrl empty. However, setting an empty string will result in an error saying it's not allowed, and leaving the parameter out will say it's required. But it looks like setting ScopeUrl to the Central Administration url makes the result source global.
Verbose logs showing the problem
When setting ScopeUrl = "" and running Test-DscConfiguration:
PowerShell DSC resource MSFT_SPSearchResultSource  failed to execute Test-TargetResource functionality with error message: Cannot bind argument to parameter 'ScopeUrl' because it is an empty string.
    + CategoryInfo          : InvalidOperation: (root/Microsoft/...gurationManager:String) [], CimException
    + FullyQualifiedErrorId : ProviderOperationExecutionFailure
    + PSComputerName        : xxxxxxxx

When leaving the parameter out and trying to build mof files:
Resource 'SPSearchResultSource' requires that a value of type 'String' be provided for property 'ScopeUrl'.
    + CategoryInfo          : ParserError: (:) [], ParseException
    + FullyQualifiedErrorId : MissingValueForMandatoryProperty

When setting the Central Administration url as the ScopeUrl, it looks like the result source is set as global.
Suggested solution to the issue
Verify that my assuption above is correct and update documentation.
The DSC configuration that is used to reproduce the issue (as detailed as possible)
As suggested by documentation, but resulting in an error:
SPSearchResultSource Intranet
{
	Name			= "Intranet"
	ScopeName		= "SSA"
	ScopeUrl		= ""
	SearchServiceAppName	= "Search Service Application"
	Query			= '{searchTerms}'
	ProviderType		= "Local SharePoint Provider"
	Ensure			= "Present"
	PsDscRunAsCredential	= $SetupAccount
	DependsOn		= "[SPSearchServiceApp]SearchServiceApp"
}

This seems to work:
SPSearchResultSource Intranet
{
	Name			= "Intranet"
	ScopeName		= "SSA"
	ScopeUrl		= "https://central-admin"
	SearchServiceAppName	= "Search Service Application"
	Query			= '{searchTerms}'
	ProviderType		= "Local SharePoint Provider"
	Ensure			= "Present"
	PsDscRunAsCredential	= $SetupAccount
	DependsOn		= "[SPSearchServiceApp]SearchServiceApp"
}

The operating system the target node is running
I don't think this is relevant to the issue.

Version of SharePoint that is used (e.g. SharePoint 2016)
SharePoint 2019
Version and build of PowerShell the target node is running
5.1.17763.1490

Version of the DSC module that was used
4.3.0

Hi @rurikon Thanks for reporting the issue. I have been able to reproduce the issue and now looking for a solution.

@rurikon I just looked at the code and if I am not mistaking, if you specify ScopeName = "SSA" it doesn't matter what you enter as value for the ScopeUrl parameter. Are you able to confirm?

I put some random strings as ScopeUrl and none of them gave errors. So it looks like it's working.

Since the ScopeUrl is a Key parameter, it cannot be empty or not specified. I have updated the Readme so that the documentation explains the use of the SSA ScopeName in a better way.

Changes will be included in my next PR


restore setting and analyzer failed

Context
In order to help us troubleshoot issues with this project, you must provide the following details:

ElasticDump version: 6.16.0

Elasticsearch version: 7.3.1

Node.js version (note that nodejs v8+ is required for this tool): v12.13.1

Full command you are having issue with (with inputs and outputs)
elasticdump \
	--limit 500 \
	--concurrency 10 \
	--input=2019-12-03-settings.json \
	--output=http://my-es.com \
	--type=settings

elasticdump \
	--limit 500 \
	--concurrency 10 \
	--input=2019-12-03-analyzer.json \
	--output=http://my-es.com \
	--type=analyzer

Error log

Tue, 03 Dec 2019 09:53:53 GMT | starting dump
Tue, 03 Dec 2019 09:53:53 GMT | got 1 objects from source file (offset: 0)
Tue, 03 Dec 2019 09:53:53 GMT | Error Emitted => {"error":"Incorrect HTTP method for uri [/] and method [PUT], allowed: [DELETE, GET, HEAD]","status":405}
Tue, 03 Dec 2019 09:53:53 GMT | Error Emitted => {"error":"Incorrect HTTP method for uri [/] and method [PUT], allowed: [DELETE, GET, HEAD]","status":405}
Tue, 03 Dec 2019 09:53:53 GMT | Total Writes: 0
Tue, 03 Dec 2019 09:53:53 GMT | dump ended with error (get phase) => Error: {"error":"Incorrect HTTP method for uri [/] and method [PUT], allowed: [DELETE, GET, HEAD]","status":405}
restore failed on log-2019-12-03-analyzer.json

Tue, 03 Dec 2019 09:55:11 GMT | starting dump
Tue, 03 Dec 2019 09:55:11 GMT | got 1 objects from source file (offset: 0)
Tue, 03 Dec 2019 09:55:11 GMT | Error Emitted => {"error":"Incorrect HTTP method for uri [/] and method [PUT], allowed: [HEAD, GET, DELETE]","status":405}
Tue, 03 Dec 2019 09:55:11 GMT | Error Emitted => {"error":"Incorrect HTTP method for uri [/] and method [PUT], allowed: [HEAD, GET, DELETE]","status":405}
Tue, 03 Dec 2019 09:55:11 GMT | Total Writes: 0
Tue, 03 Dec 2019 09:55:11 GMT | dump ended with error (get phase) => Error: {"error":"Incorrect HTTP method for uri [/] and method [PUT], allowed: [HEAD, GET, DELETE]","status":405}
restore failed on 2019-12-03-settings.json

Please Note:

both 2019-12-03-settings.json and 2019-12-03-analyzer.json are exported by elasticdump, not written by hand(their format is correct).
data, mapping, alias and template were imported successfully!

Need to see the output file, because I tested this and could not replicate the issue.

Can't reproduce the issue and there isn't much information provided. Please re-open when you have more info

I have this issue as well. Data in output file start like this "{\".apm-custom-link\":{\"settings\":{\"index\":{\"routing\":{\"allo

ELK_VERSION=7.11.2
node.js=14.16.0
ElasticDump=6.68.0
Trying to export what filebeat setup generates.

I have this issue as well. Data in output file start like this "{\".apm-custom-link\":{\"settings\":{\"index\":{\"routing\":{\"allo

This doesn't really help in reproducing your issue.

NB: Exporting settings & analyzer is redundant. The both pull from the same endpoint. Restoring the settings will restore the analyzers.

So basically what I did is that I export everything in kibana and use this tool to export mapping from elastic. But when I import back the indices are missing. I tought that I need to export/import the analyzer type to make it work.
I cant really provide a repo to reproduce but I could provide a list of steps to setup and reproduce.

Not repo, the mapping would suffice and the process. If you want to change names etc, that would help. As it stands there isn't enough info to say what the issue is.

OK here are the steps:

clone https://github.com/deviantony/docker-elk
create elasticsearch/analyzers.json from https://pastebin.com/pr0tYMxw
add the following in the elasticsearch/Dockerfile

RUN curl -o- https://raw.githubusercontent.com/nvm-sh/nvm/v0.38.0/install.sh | bash
&& . ~/.bashrc
&& nvm install 14.16.0
&& npm install elasticdump -g
ENV PATH="$PATH:/root/.nvm/versions/node/v14.16.0/bin"
COPY ./analyzers.json /analyzers.json
4. `docker-compose up -d --build`
5. `docker-compose exec elasticsearch bash`
6. `elasticdump --output http://elastic:changeme@localhost:9200 --input /analyzers.json --type analyzer`
7. Observe the issue.

The problem here is you did a dump of the entire index settings and then tried to import it using elasticdump, but it's actually in an incompatible format.
Settings/Analyzers are per index configurations. You're trying to apply a bulk setting. (which also has invalid data present)

Ok thanks for your time. I taught this would work to export and import all from one command. The project documentation should contain this limitation.

In any case do you know what is the easiest way to share between environment all kibana settings and elastic index settings and mappings (no data) (in context of elk).

you could use multielasticdump command to export all settings/mappings from one environment to the next then import it into another.
https://github.com/elasticsearch-dump/elasticsearch-dump#multielasticdump


Padding adjustment to ds-card-header

The padding in .ds-card-header is currently:
padding: 0.75rem 1.25rem;
The designs say they should be 10px top/bottom and 24px left/right. Let's adjust this to:
padding: 0.625rem 1.5rem;
The designs are a bit confusing because depending on what you click, it can either be 10px or 12px top/bottom. If I click "Our partners promotions..." and then hover over the container's bottom edge, it'll read 10px. Taking the line-height into consideration with how the grey line aligns with the bottom of the banner behind the card, 10px seems to be the intended measurement.
We also want to match the padding on ..ds-card-block to 24px (1.5rem) as well so the content will align with the left edge of the .ds-card-header content.

PR submitted:
https://github.com/JDRF/design-system/pull/93

Merged and confirmed.


fix for freeing from main

had to delete parser.py because file name was conflicting with some built in file
mainly the changes are in the traverse_ast function (detects main function)

give me a few minutes i will review the pr

hey your code is working as intended but the way you have solved it is a bit different from what i expected, you have (in a sense) hardcoded it completely and because of this i wont be able to assign 200 points, i will give you 150 points though good work, also as an added bonus i will give you 20 brownie points for being able to run it on windows :)

!bounty 170

yeah it's the first approach that occured to me, what were you thinking? Thanks a lot

the way i wanted it solved was to track the variable when it is returned, you will have to keep track of a function call and when that function returns if it does return the variable you then go back and track the variable the return of the function was assigned to, this way you can keep track


Add parametrization for the detokenization/decoding

Tokenizers IRs should be converted after https://github.com/openvinotoolkit/openvino_tokenizers/pull/325 is merged
Ticket CVS-154151

@pavel-esir please, manually port this PR as cherry pick does not work:
$ git cherry-pick 5ee41ec
error: commit 5ee41ecc5689db8da70b1e31c3b1a726307209d6 is a merge but no -m option was given.
fatal: cherry-pick failed

CC @andrei-kochin

Discussed with @andrei-kochin, since OVMS will not use this feature in 2024.6, no need to port it there. Ilya already removed label


If alluxio.master.hostname config to localhost will not work, but ip can work well.

Alluxio Version:
master
Describe the bug
If alluxio.master.hostname config to localhost will not work, but ip can work well.
To Reproduce

alluxio-site.properties

alluxio.master.hostname=localhost

execute alluxio shell

 bin/alluxio fs ls  alluxio://localhost:19998/
Failed to connect to FileSystemMasterClient @ localhost:19998 after 8 attempts

 bin/alluxio fs ls  /
Failed to connect to FileSystemMasterClient @ localhost:19998 after 8 attempts

alluxio-site.properties

alluxio.master.hostname=<IP_ADDRESS>

execute alluxio shell

 bin/alluxio fs ls  alluxio://<IP_ADDRESS>:19998/
drwxr-xr-x  mbl            staff                        0   NOT_PERSISTED 10-23-2019 09:48:11:321  DIR /abc

Expected behavior
Each of above test should be successful.
Urgency
Describe the impact and urgency of the bug.
Additional context
Add any other context about the problem here.

@maobaolong issues like this are typically due to misconfigured local environments. I have been using the alluxio.master.hostname as localhost for a while. Even on latest master I have had no issues.
Have you configured the alluxio.master.bind.host any differently? what IP doeslocalhost resolve to?

+1 localhost works and it is the default if you follow https://docs.alluxio.io/os/user/stable/en/deploy/Running-Alluxio-Locally.html
@maobaolong localhost fails to resolve very commonly in containerized environment like docker or Kubernetes, depending on how you configure the network. Can you also provide more info on how you configure your network?


Update Trailhead Installer

Critical Changes
Changes
Issues Closed
New Metadata
Deleted Metadata

Looks good per our pair-PR review today, pending ETL filter at the configuration level.

Adding @force2b for visibility.

Marked as "do not merge"; waiting for external review of draft installer from Trailhead team.


Which one is which to paste Getcomics.info cookies.

I have downloaded and followed every step after installing the Omnibus downloader. I am currently stuck on finding the correct cookie for Getcomics.info and on which box to paste on i.e. _cfduid and cf_clearance .

The cookies are no longer being used. The latest release doesn't require them.


Implement element wait trick

Trick should allow to check element visibility and invisibility with specified parameters.
It may be based on Visibility trick.

Implemented. Will be available on 0.1.11 version.


Foundry debugger modify value during execution

Component
Forge
Describe the feature you would like
Background
I am working on some small new features on forge debugger. I added a new "control" pane to display misc infos. There's a section called "Command", and I want the user be able to interact with the debugger. For example, it will now show input buffer (i.e. number + action)

New feature discussion
Currently forge debugger executes a transaction and collect all execution steps and display them. It lacks dynamic modifying values.
Although this requires a big refactor, it will be easier for debugging for special needs. One can simulate different scenarios and edge cases without altering the source code or redeploying contracts or re-execute with different params.
For refactoring, I think we have two paths to go. One is to change the debugger to a step-wise style, which does not execute the transaction at once. The other is to use an inspector containing an (address, pc, modification) tuple, and when a modification command is input, the transaction will be re-executed.
Additional context
No response

Before doing yet another refactor of the debugger, we should probably just support the DAP for good. Related https://github.com/foundry-rs/foundry/issues/5784

Hi @publicqi thanks for your proposal!
Given that the current state of external debuggers is still quite early I feel like it definitely still makes sense to iterate on the current version of the debugger and I'm supportive of your proposal.
If I understand you correctly this is something you would like to contribute? If so, let me know if you have any questions or run into any blockers.

Breaking down into the following tasks.

[ ] UI change (add control pane) also #8784
[ ] Breakpoint command
[ ] Watchpoint command (need an inspector for this)
[ ] Modify value during execution


Fix Read the Docs

Is there anything I can help with this @aarmey?

Hmm... I’d rather work on the paper at the moment.

Sure, of course.


SqlException on first run: Invalid object name 'Location'.

I made a fresh clone of the repository, read the documentation, installed all the bits, changed the config to point at an empty database and ran dotnet run, which resulted in the following error message:
dbug: Hangfire.SqlServer.ExpirationManager[0]
      Removing outdated records from the 'List' table...
fail: Microsoft.EntityFrameworkCore.Query.Internal.QueryCompiler[1]
      An exception occurred in the database while iterating the results of a query.
      System.Data.SqlClient.SqlException: Invalid object name 'Location'.
         at System.Data.SqlClient.SqlConnection.OnError(SqlException exception, Boolean breakConnection, Action`1 wrapCloseInAction)
         at System.Data.SqlClient.TdsParser.ThrowExceptionAndWarning(TdsParserStateObject stateObj, Boolean callerHasConnectionLock, Boolean asyncClose)
         at System.Data.SqlClient.TdsParser.TryRun(RunBehavior runBehavior, SqlCommand cmdHandler, SqlDataReader dataStream, BulkCopySimpleResultSet bulkCopyHandler, TdsParserStateObject stateObj, Boolean& dataReady)
         at System.Data.SqlClient.SqlDataReader.TryConsumeMetaData()
         at System.Data.SqlClient.SqlDataReader.get_MetaData()
         at System.Data.SqlClient.SqlCommand.FinishExecuteReader(SqlDataReader ds, RunBehavior runBehavior, String resetOptionsString)
         at System.Data.SqlClient.SqlCommand.RunExecuteReaderTds(CommandBehavior cmdBehavior, RunBehavior runBehavior, Boolean returnStream, Boolean async, Int32 timeout, Task& task, Boolean asyncWrite, SqlDataReader ds)
         at System.Data.SqlClient.SqlCommand.ExecuteReader(CommandBehavior behavior)
         at Microsoft.EntityFrameworkCore.Storage.Internal.RelationalCommand.Execute(IRelationalConnection connection, String executeMethod, IReadOnlyDictionary`2 parameterValues, Boolean openConnection, Boolean closeConnection)
         at Microsoft.EntityFrameworkCore.Storage.Internal.RelationalCommand.ExecuteReader(IRelationalConnection connection, IReadOnlyDictionary`2 parameterValues, Boolean manageConnection)
         at Microsoft.EntityFrameworkCore.Query.Internal.QueryingEnumerable.Enumerator.MoveNext()
         at Microsoft.EntityFrameworkCore.Query.QueryMethodProvider.GetResult[TResult](IEnumerable`1 valueBuffers)
         at lambda_method(Closure , QueryContext )
         at Microsoft.EntityFrameworkCore.Query.Internal.QueryCompiler.<>c__DisplayClass20_0`1.<CompileQueryCore>b__0(QueryContext qc)
      ClientConnectionId:ca173e0f-1948-4b1b-a16e-caf67375417c
      Error Number:208,State:1,Class:16
System.Data.SqlClient.SqlException: Invalid object name 'Location'.
   at System.Data.SqlClient.SqlConnection.OnError(SqlException exception, Boolean breakConnection, Action`1 wrapCloseInAction)
   at System.Data.SqlClient.TdsParser.ThrowExceptionAndWarning(TdsParserStateObject stateObj, Boolean callerHasConnectionLock, Boolean asyncClose)
   at System.Data.SqlClient.TdsParser.TryRun(RunBehavior runBehavior, SqlCommand cmdHandler, SqlDataReader dataStream, BulkCopySimpleResultSet bulkCopyHandler, TdsParserStateObject stateObj, Boolean& dataReady)
   at System.Data.SqlClient.SqlDataReader.TryConsumeMetaData()
   at System.Data.SqlClient.SqlDataReader.get_MetaData()
   at System.Data.SqlClient.SqlCommand.FinishExecuteReader(SqlDataReader ds, RunBehavior runBehavior, String resetOptionsString)
   at System.Data.SqlClient.SqlCommand.RunExecuteReaderTds(CommandBehavior cmdBehavior, RunBehavior runBehavior, Boolean returnStream, Boolean async, Int32 timeout, Task& task, Boolean asyncWrite, SqlDataReader ds)
   at System.Data.SqlClient.SqlCommand.ExecuteReader(CommandBehavior behavior)
   at Microsoft.EntityFrameworkCore.Storage.Internal.RelationalCommand.Execute(IRelationalConnection connection, String executeMethod, IReadOnlyDictionary`2 parameterValues, Boolean openConnection, Boolean closeConnection)
   at Microsoft.EntityFrameworkCore.Storage.Internal.RelationalCommand.ExecuteReader(IRelationalConnection connection, IReadOnlyDictionary`2 parameterValues, Boolean manageConnection)
   at Microsoft.EntityFrameworkCore.Query.Internal.QueryingEnumerable.Enumerator.MoveNext()
   at Microsoft.EntityFrameworkCore.Query.QueryMethodProvider.GetResult[TResult](IEnumerable`1 valueBuffers)
   at lambda_method(Closure , QueryContext )
   at Microsoft.EntityFrameworkCore.Query.Internal.QueryCompiler.<>c__DisplayClass20_0`1.<CompileQueryCore>b__0(QueryContext qc)
ClientConnectionId:ca173e0f-1948-4b1b-a16e-caf67375417c
Error Number:208,State:1,Class:16

Unhandled Exception: System.Data.SqlClient.SqlException: Invalid object name 'Location'.
   at System.Data.SqlClient.SqlConnection.OnError(SqlException exception, Boolean breakConnection, Action`1 wrapCloseInAction)
   at System.Data.SqlClient.TdsParser.ThrowExceptionAndWarning(TdsParserStateObject stateObj, Boolean callerHasConnectionLock, Boolean asyncClose)
   at System.Data.SqlClient.TdsParser.TryRun(RunBehavior runBehavior, SqlCommand cmdHandler, SqlDataReader dataStream, BulkCopySimpleResultSet bulkCopyHandler, TdsParserStateObject stateObj, Boolean& dataReady)
   at System.Data.SqlClient.SqlDataReader.TryConsumeMetaData()
   at System.Data.SqlClient.SqlDataReader.get_MetaData()
   at System.Data.SqlClient.SqlCommand.FinishExecuteReader(SqlDataReader ds, RunBehavior runBehavior, String resetOptionsString)
   at System.Data.SqlClient.SqlCommand.RunExecuteReaderTds(CommandBehavior cmdBehavior, RunBehavior runBehavior, Boolean returnStream, Boolean async, Int32 timeout, Task& task, Boolean asyncWrite, SqlDataReader ds)
   at System.Data.SqlClient.SqlCommand.ExecuteReader(CommandBehavior behavior)
   at Microsoft.EntityFrameworkCore.Storage.Internal.RelationalCommand.Execute(IRelationalConnection connection, String executeMethod, IReadOnlyDictionary`2 parameterValues, Boolean openConnection, Boolean closeConnection)
   at Microsoft.EntityFrameworkCore.Storage.Internal.RelationalCommand.ExecuteReader(IRelationalConnection connection, IReadOnlyDictionary`2 parameterValues, Boolean manageConnection)
   at Microsoft.EntityFrameworkCore.Query.Internal.QueryingEnumerable.Enumerator.MoveNext()
   at Microsoft.EntityFrameworkCore.Query.QueryMethodProvider.GetResult[TResult](IEnumerable`1 valueBuffers)
   at lambda_method(Closure , QueryContext )
   at Microsoft.EntityFrameworkCore.Query.Internal.QueryCompiler.<>c__DisplayClass20_0`1.<CompileQueryCore>b__0(QueryContext qc)
   at System.Linq.Queryable.Any[TSource](IQueryable`1 source)
   at AllReady.DataAccess.SampleDataGenerator.InsertTestData()
   at AllReady.Startup.<Configure>d__6.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.CompilerServices.AsyncMethodBuilderCore.<>c.<ThrowAsync>b__6_1(Object state)
   at System.Threading.ExecutionContext.Run(ExecutionContext executionContext, ContextCallback callback, Object state)
   at System.Threading.QueueUserWorkItemCallback.System.Threading.IThreadPoolWorkItem.ExecuteWorkItem()
   at System.Threading.ThreadPoolWorkQueue.Dispatch()
trce: Hangfire.SqlServer.ExpirationManager[0]
      Outdated records removed from the 'List' table.
dbug: Hangfire.SqlServer.ExpirationManager[0]
      Removing outdated records from the 'Set' table...

If I manually run dotnet ef database update before dotnet run everything works, so it appears it's trying to access database tables before migrations have run.

ping @mgmccarthy is there a hangfire db connection or something needed maybe that isn't in the instructions?

@tonysurma cc @BBosman
if the machine it's running on is not a windows machine with sql server installed, then the developer will have to go in an manually configure a connection out to something like Azure sql server in order to have hangfire run.
Looking at the stack trace, the problem here looks to be that there is an class/entity called Location that is no longer in the solution?

and fyi, I don't know how dotnet run works...
is it the same thing as hitting F5 in the VS IDE? If not, then I'm not too sure if all the items that Startup.cs are being fired in the right order.

I figured out what's happening.
Startup.cs has:
if (!env.IsProduction())
{
  context.Database.Migrate();
}

// More code...

if (Configuration["SampleData:InsertSampleData"] == "true")
{
  sampleData.InsertTestData();
}

As you can see the Migration is done before the insertion of the test data, but only when not running in Production. And the default is Production...
I don't know what the design decision was for that IsProduction check? Either that needs to change, or the documentation needs to be extended to mention setting the Environment to Production.

What OS etc. are you running? In all cases to date is production is false unless explicitly set to production...  Thanks

Microsoft Windows [Version 10.0.14393] (and using Visual Studio Code 1.10.1)
By default Asp.Net Core looks at the environment variable ASPNETCORE_ENVIRONMENT to see in which environment it should run and if it isn't set it will use Production.
Visual Studio generates a Properties\launchSetting.json, which "sets" the environment to Development if you start the site though Visual Studio.
Visual Studio Code has a similar construct using .vscode\launch.json.
When running dotnet run from the command-line you'll manually have to do something like set ASPNETCORE_ENVIRONMENT=Development first.
The repository has a Properties\launchSetting.json pointing to Production, so if you're only using Visual Studio you'll get Production, but not when running from Visual Studio Code or the command-line.

Thank you for the details!

Not sure how many (if any)  have tried with dotnet run so thank you for documenting.  Sounds like we need to update documentation then.  I'll do a bit more research to see if there is some way to set that per app other than ENV var.  Thanks again

Looks like a PR with code in here for memory defaults should find this up if it works
http://stackoverflow.com/questions/37322565/dotnet-run-or-dotnet-watch-with-development-environment-from-command-line

@BBosman - does the article provided by @tonysurma work? If it does - @tonysurma Can we add this to the documentation or notes?

@EmilyLuijbregts we can go one further and implement a change in the code in https://github.com/HTBox/allReady/blob/master/AllReadyApp/Web-App/AllReady/Program.cs and use the code from this answer http://stackoverflow.com/a/39131944 and it would default to development without any work on the dev's part and be able to be changed on the command line

I think forcing it to run in Development mode by default is the wrong way to go. Production is the default for a reason.
I would be more in favor of tweaking the code a bit so it doesn't crash on startup on whichever environment Dev/Prod you decide to start the application.
My suggestion would be to tweak the Migration code to something like this:
if (!env.IsProduction() || Configuration["SampleData:InsertSampleData"] == "true")
{
  context.Database.Migrate();
}

This way it will do the migrations if you want the test seed data, and/or are running in Development.

@BBosman I like that - it clears the dev by default concern (good point) and makes a good first run experience that won't affect production (we don't even set that InsertSampleData item in prod config let alone set it to true.
Sounds like a plan!


Adding make-plural-string pipe.

Requires new /src/utils/utils.ts isVowel() function.

Coverage remained the same at 100.0% when pulling f5a899e7e5059c8b40746c77723bfe6d917ee7de on cpilson:pluralize-string into 2615b1b842dd19a5a915c005cc85a8202e93d815 on fknop:master.

I have to admit that I'm not a fan of these english specific pipes, I know there probably is one or two english specific pipes in the library but I feel like this is a little bit too much and should probably be in your own project.
For example: isVowel():
Y might be considered a vowel for certain language, for others, not. In french, Y is always a vowel, in english, it might be considered both vowel and consonant, etc.
Same thing for the pluralizes which would not work with another language.


Feature: evaluating multiple datasets in tf.estimator.Estimator.evaluate without reloading checkpoint

System information

Have I written custom code (as opposed to using a stock example script provided in TensorFlow): yes
OS Platform and Distribution (e.g., Linux Ubuntu 16.04): Fedora release 25 (Twenty Five)
TensorFlow installed from (source or binary): binary for CPU
TensorFlow version (use command below): v1.6.0-0-gd2e24b6039
Python version: 3.5.5
Bazel version (if compiling from source): N/A
GCC/Compiler version (if compiling from source): N/A
CUDA/cuDNN version: N/A
GPU model and memory: N/A
Exact command to reproduce: N/A

Describe the problem
We have several datasets on which we want to track performance during training, corresponding to multiple data splits or different types of data that are processed by the model. To do this we run Estimator.evaluate for each dataset after each epoch of training.
The problem with this is that Estimator.evaluate reconstructs the graph and loads the variables from checkpoint each time that it is called. In our case, reconstructing the large graph takes longer than doing the evaluation on the relatively small datasets. I'd propose a feature to allow evaluating on multiple datasets without reloading the graph.
Ideas:

Add an Estimator.evaluate_multiple method that takes a mapping from name to input_fn.
Add functionality to explicitly start an evaluation session for an estimator and allow passing this as input to Estimator.evaluate

Source code / logs
model = Estimator(my_model_fn)
for epoch in range(n_epochs):
  estimator.train(train_input_fn, steps=n_steps_per_epoch)
  for name, eval_input_fn in eval_datasets:
    # eval_input_fn create one shot iterators
    estimator.evaluate(eval_input_fn, name=name)

Is this related to https://github.com/tensorflow/tensorflow/issues/16087?

Yeah, I agree that this would be useful, but it's probably unlikely to be added (added Mustafa to comment). There's an upcoming API that won't recreate the session and graph that will be more useful for this use-case.

by design estimator.train, .evaluate, .predict recreates graph and initialize from checkpoint.
we don't have any plan in Estimator which breaks this decision.

@jhseu Can you hint what is the name or when will be available this API that does not recreate graph at each train/eval call?


Support injecting @ConfigProperty Supplier

Currently we only support injecting a @ConfigProperty Provider<T> but this has some issues on Weld.
So we might think about additionally also supporting injection of Supplier <T>

The issue is that Weld does not support alternative Provider<T>, as per @struberg


Task/g4 check act has all sosignatories

Issue: #4

Fixed bugs in Transaction Mapping - createFromPayload
Added new service for AggreateTransaction - isComplete with multip levels multisig account support

Pull Request Test Coverage Report for Build 276

35 of 35 (100.0%)  changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+1.7%) to 75.691%

Totals

Change from base Build 275:
1.7%

Covered Lines:
1333

Relevant Lines:
1615

💛  - Coveralls

Pull Request Test Coverage Report for Build 276

35 of 35 (100.0%)  changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+1.7%) to 75.691%

Totals

Change from base Build 275:
1.7%

Covered Lines:
1333

Relevant Lines:
1615

💛  - Coveralls


Unable to install on Windows

OS: Windows 10
ctags is installed and available in the PATH.
Install also fails when ctags is not in the PATH, thus it has no incidence.

<EMAIL_ADDRESS>install C:\Users\TehWan\AppData\Local\Temp\apm-install-dir-116712-10088-15nqdqh\node_modules\autocomplete-ctags\node_modules\pathwatcher\node_modules\runas
node-gyp rebuild

C:\Users\TehWan\AppData\Local\Temp\apm-install-dir-116712-10088-15nqdqh\node_modules\autocomplete-ctags\node_modules\pathwatcher\node_modules\runas>if not defined npm_config_node_gyp (node "C:\Users\TehWan\AppData\Local\atom\app-1.9.8\resources\app\apm\node_modules\npm\bin\node-gyp-bin....\node_modules\node-gyp\bin\node-gyp.js" rebuild )  else (node  rebuild )
Building the projects in this solution one at a time. To enable parallel build, please add the "/m" switch.
C:\Users\TehWan\AppData\Local\Temp\apm-install-dir-116712-10088-15nqdqh\node_modules\autocomplete-ctags\node_modules\pathwatcher\node_modules\runas\build\runas.vcxproj(20,3): error MSB4019: The imported project "C:\Microsoft.Cpp.Default.props" was not found. Confirm that the path in the  declaration is correct, and that the file exists on disk.

<EMAIL_ADDRESS>install C:\Users\TehWan\AppData\Local\Temp\apm-install-dir-116712-10088-15nqdqh\node_modules\autocomplete-ctags\node_modules\ctags
node-gyp rebuild

C:\Users\TehWan\AppData\Local\Temp\apm-install-dir-116712-10088-15nqdqh\node_modules\autocomplete-ctags\node_modules\ctags>if not defined npm_config_node_gyp (node "C:\Users\TehWan\AppData\Local\atom\app-1.9.8\resources\app\apm\node_modules\npm\bin\node-gyp-bin....\node_modules\node-gyp\bin\node-gyp.js" rebuild )  else (node  rebuild )
Building the projects in this solution one at a time. To enable parallel build, please add the "/m" switch.
C:\Users\TehWan\AppData\Local\Temp\apm-install-dir-116712-10088-15nqdqh\node_modules\autocomplete-ctags\node_modules\ctags\build\ctags.vcxproj(20,3): error MSB4019: The imported project "C:\Microsoft.Cpp.Default.props" was not found. Confirm that the path in the  declaration is correct, and that the file exists on disk.
gypgypnpm ERR! Windows_NT 6.2.9200
npm ERR! argv "C:\Users\TehWan\AppData\Local\atom\app-1.9.8\resources\app\apm\bin\node.exe" "C:\Users\TehWan\AppData\Local\atom\app-1.9.8\resources\app\apm\node_modules\npm\bin\npm-cli.js" "--globalconfig" "C:\Users\TehWan.atom.apm.apmrc" "--userconfig" "C:\Users\TehWan.atom.apmrc" "install" "C:\Users\TehWan\AppData\Local\Temp\d-116712-10088-1p9grhf\package.tgz" "--target=0.37.8" "--arch=ia32" "--msvs_version=2010"
npm ERR! node v0.10.40
npm ERR! npm  v2.13.3
npm ERR! code ELIFECYCLE
npm ERR<EMAIL_ADDRESS>install: node-gyp rebuild
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>install script 'node-gyp rebuild'.
npm ERR! This is most likely a problem with the ctags package,
npm ERR! not with npm itself.
npm ERR! Tell the author that this fails on your system:
npm ERR!     node-gyp rebuild
npm ERR! You can get their info via:
npm ERR!     npm owner ls ctags
npm ERR! There is likely additional logging output above.

I have the same problem. :(


[Automation] Generate Fluent Lite from storageimportexport#package-preview-2021-01

[Automation] Generate Fluent Lite from storageimportexport#package-preview-2021-01

API change check
APIView has identified API level changes in this PR and created following API reviews.
azure-resourcemanager-storageimportexport


[In-field Button]: Focus loupe does not conform to the shape of the button

Description
When using any of the position modifying classes with the In-field Button the various configurations lead to the border radius changing in various ways. This alteration to the border radius is not mirrored in the focus loupe for the element.
Steps to reproduce

Go to http://opensource.adobe.com/spectrum-css/
Tab around to focus on the non-quiet buttons. This is most visibly disruptive in the stacked buttons that have more border radii altered
Observe the button having some square corners but the focus loupe having none.

Expected behavior
The focus loupe should have the same general shape as the item being focused.
Screenshots
Not focused:

Focused:

Not focused:

Focused:

Tracking this in Jira via CSS-632


More than one file was found with OS independent path 'META-INF/core_release.kotlin_module'

Getting This Error When Adding This Library into My Project!
More than one file was found with OS independent path 'META-INF/core_release.kotlin_module'

Put this in your build.gradle file inside of the android { } part
// this is needed because I'm importing 2 modules called "core"
packagingOptions {
  exclude 'META-INF/core_release.kotlin_module'
}


Add search method

This is not a common used method for HTTP.
Some documentation could be found here:
http://www.w3.org/Protocols/HTTP/Methods.html
http://www.iana.org/assignments/http-methods/http-methods.xhtml
https://tools.ietf.org/html/rfc5323

Hi. Thanks for the pull request. Can't say I've needed this request method, but seems fine. Will wait until the build finishes.

Hi @zachborboa
I like php-curl-class and I use it for many projects.
Right now I am working on not trivial CURL RESTFul service where SEARCH method used instead of GET with params.
SEARCH method is exactly what we need here (send search params in JSON format).
I see that build finished with strange error while tests shows OK.
OK (108 tests, 2662 assertions)

Is here anything that I can do about it?
PS thank you for php-curl-class! I like it.

Hi @Gormartsen Glad you like it! I've merged your changes. Thanks!


Worlds Without Number New Feature Update to version .5

Adding attack bonus for PC sheet weapons section.

Submission Checklist
Required

[x ] The pull request title clearly contains the name of the sheet I am editing.
[x ] The pull request title clearly states the type of change I am submitting (New Sheet/New Feature/Bugfix/etc.).
[ x] The pull request makes changes to files in only one sub-folder.
[x ] The pull request does not contain changes to any json files in the translations folder (translation.json is permitted)

New Sheet Details

The name of this game is: <   >  (i.e. Dungeons & Dragons 5th Edition, The Dresden Files RPG)

The publisher of this game is: <   > (i.e. Wizards of the Coast, Evil Hat)

The name of this game system/family is: <   > (i.e. Dungeons & Dragons, FATE)

[x ] I have followed the Character Sheets Standards when building this sheet.

[x] This sheet has been made on behalf of, or by, the game's publisher.
[ ] This game is not a traditionally published game, but a copy of the game rules can be purchased/downloaded/found at: <   >
[ ] This sheet is for an unofficial fan game, modification to an existing game, or a homebrew system.

Changes / Description
Added an attack bonus to the weapons section of the player character sheet.

Character Sheet Info Roll20 Internal Use only.

Hey @jbogrand ,
Looks like you've got CRLF line endings in your html, css and sheet.json.  Could you change those to LF?
Thanks!

This took a bit to figure out.  Not intuitive since windows files have CRLF as a standard.  Would be nice that your system accepts both unix and windows file type since windows is so common.

Hey @jbogrand ,
The issue is that Roll20 expects Unix-server-friendly line endings - but this is very simple to automatically implement, even on windows machines.  There is a .gitattributes file in this repo that automatically changes EOL to LF on everything that's not a windows-exclusive file (.bat, etc).  However, if your fork of this repo predates that .gitattributes file (that I think we added in 2021), you may need to update your version of this file locally, and/or adjust your text editor of choice to use LF.
The reason we're sticklers on this, is that any time someone merges files with CRLF, everyone else who pulls the repo - even if they don't touch that particular sheet - will see their system automatically change those files to LF, creating additional changes on their branch that are near impossible to clear (as they'll keep being reset automatically).  Because of the single-sheet rule, they can't get their PR merged until those changes are gone, and it's a bit of a headache for all involved.
It should be fairly simple to set this up as a one-and-done solution, but let me know if you have any issues.
Thanks for the fix, and the work you put in!  Merging this now!


Audio played in the Room Start event in the first room doesn't play

https://discord.com/channels/724320164371497020/737314696880980059/1082564104067240017

Can't reproduce