Cannot find -lSDL2 (windows 7 64b)

Got an error trying to build sdl2
D:\..snipped..\Rust\example\hello_world>cargo build
unused manifest key: package.link
  Updating registry `https://github.com/rust-lang/crates.io-index`
Downloading sdl2-sys v0.0.14
Downloading sdl2 v0.0.14
 Compiling pkg-config v0.1.3
 Compiling sdl2-sys v0.0.14
 Compiling sdl2 v0.0.14
src\sdl2\lib.rs:4:106: 4:122 warning: feature is deprecated and will only be available for a limited time, please rewrite code that relies o
n it
src\sdl2\lib.rs:4 #![feature(default_type_params, globs, macro_rules, slicing_syntax, unsafe_destructor, associated_types, old_orphan_check)
]
                                                                                ^~~~~~~~~~~~~~~~
<std macros>:5:11: 5:71 warning: `deriving` is deprecated; use `derive`
<std macros>:5         #[deriving(Copy, PartialEq, Eq, Clone, PartialOrd, Ord, Hash)]
                       ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
<std macros>:5:11: 5:71 warning: `deriving` is deprecated; use `derive`
<std macros>:5         #[deriving(Copy, PartialEq, Eq, Clone, PartialOrd, Ord, Hash)]
                       ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
<std macros>:5:11: 5:71 warning: `deriving` is deprecated; use `derive`
<std macros>:5         #[deriving(Copy, PartialEq, Eq, Clone, PartialOrd, Ord, Hash)]
                       ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
<std macros>:5:11: 5:71 warning: `deriving` is deprecated; use `derive`
<std macros>:5         #[deriving(Copy, PartialEq, Eq, Clone, PartialOrd, Ord, Hash)]
                       ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
<std macros>:5:11: 5:71 warning: `deriving` is deprecated; use `derive`
<std macros>:5         #[deriving(Copy, PartialEq, Eq, Clone, PartialOrd, Ord, Hash)]
                       ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
<std macros>:5:11: 5:71 warning: `deriving` is deprecated; use `derive`
<std macros>:5         #[deriving(Copy, PartialEq, Eq, Clone, PartialOrd, Ord, Hash)]
                       ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
<std macros>:5:11: 5:71 warning: `deriving` is deprecated; use `derive`
<std macros>:5         #[deriving(Copy, PartialEq, Eq, Clone, PartialOrd, Ord, Hash)]
                       ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
<std macros>:5:11: 5:71 warning: `deriving` is deprecated; use `derive`
<std macros>:5         #[deriving(Copy, PartialEq, Eq, Clone, PartialOrd, Ord, Hash)]
                       ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
src\sdl2\lib.rs:4:106: 4:122 warning: feature is deprecated and will only be available for a limited time, please rewrite code that relies o
n it
src\sdl2\lib.rs:4 #![feature(default_type_params, globs, macro_rules, slicing_syntax, unsafe_destructor, associated_types, old_orphan_check)
]
                                                                                ^~~~~~~~~~~~~~~~
 Compiling hello_world v0.0.1 (file:///D:/..snipped../Rust/example/hello_world)
error: linking with `gcc` failed: exit code: 1
note: gcc '-Wl,--enable-long-section-names' '-fno-use-linker-plugin' '-Wl,--nxcompat' '-Wl,--large-address-aware' '-shared-libgcc' '-L' 'D:\
Rust\bin\rustlib\i686-pc-windows-gnu\lib' '-o' 'D:\..snipped..\Rust\example\hello_world\target\hello_world.exe' 'D:\..snipped..
\Rust\example\hello_world\target\hello_world.o' '-Wl,--gc-sections' 'D:\..snipped..\Rust\example\hello_world\target\deps\libsdl2-0d7
3d3dc532b9ee0.rlib' 'D:\..snipped..\Rust\example\hello_world\target\deps\libsdl2-sys-0968fbb6d6606131.rlib' 'D:\Rust\bin\rustlib\i686
-pc-windows-gnu\lib\libstd-4e7c5e5c.rlib' 'D:\Rust\bin\rustlib\i686-pc-windows-gnu\lib\libcollections-4e7c5e5c.rlib' 'D:\Rust\bin\rustlib\i6
86-pc-windows-gnu\lib\liballoc-4e7c5e5c.rlib' 'D:\Rust\bin\rustlib\i686-pc-windows-gnu\lib\liblibc-4e7c5e5c.rlib' 'D:\Rust\bin\rustlib\i686-
pc-windows-gnu\lib\librand-4e7c5e5c.rlib' 'D:\Rust\bin\rustlib\i686-pc-windows-gnu\lib\libunicode-4e7c5e5c.rlib' 'D:\Rust\bin\rustlib\i686-p
c-windows-gnu\lib\libcore-4e7c5e5c.rlib' '-L' 'D:\..snipped..\Rust\example\hello_world\target' '-L' 'D:\..snipped..\Rust\examp
le\hello_world\target\deps' '-L' 'D:\Rust\bin\rustlib\i686-pc-windows-gnu\lib' '-L' 'D:\..snipped..\Rust\example\hello_world\.rust\bi
n\i686-pc-windows-gnu' '-L' 'D:\..snipped..\Rust\example\hello_world\bin\i686-pc-windows-gnu' '-Wl,--whole-archive' '-Wl,-Bstatic' '-
Wl,--no-whole-archive' '-Wl,-Bdynamic' '-lSDL2' '-lSDL2' '-lws2_32' '-lcompiler-rt'
note: ld: cannot find -lSDL2
ld: cannot find -lSDL2

error: aborting due to previous error
Could not compile `hello_world`.

To learn more, run the command again with --verbose.

D:\..snipped..\Rust\example\hello_world>

Usually when it makes that noise, it's because it can't find the SDL2 development libraries - they might niot be available in the paths provided. Worst case scenario, try copying them into the directory you're compiling from.

How exactly could i add paths to the build code?
I had to create a folder called: /bin/i686-pc-windows-gnu/ because that folder was the easiest to create which is automatically being linked to it seems after investigating.

I'm not very well versed in getting it to build on Windows, sadly :(

My last question would be is why does the sdl2 port stray away from the standard c/c++ code.  I see things from like from_window and what not which is kind of weird personally.  Wouldn't you want it as 1:1 as possible?

It's for safety's sake - it's a thin layer, but tries to keep it in the Rust idioms

In order to resolve this error, you make sure you have an environment variable called LIBRARY_PATH and that it contains the path to the folder containing the sdl2 libraries.

To build sdl2 on windows, you need to download mingw development libraries from libsdl.org (SDL2-devel-2.0.3-mingw.tar.gz).
Copy all lib files from "SDL2-devel-2.0.3-mingw\SDL2-2.0.3\x86_64-w64-mingw32\lib" to "C:\Rust\bin\rustlib\x86_64-pc-windows-gnu\lib"
Copy SDL2.dll from "SDL2-devel-2.0.3-mingw\SDL2-2.0.3\x86_64-w64-mingw32\bin" into your cargo project, right next to your Cargo.toml
That is it.
I think it might be a good idea to this to Readme, so people have no trouble installing sdl2 on windows.

Feel free to make a pull request to stick it in there :)


How can we ensure that the service node is Deregister wehn use zookeeper plugins

When zookeeper plugins creates a node in the service registration discovery, the flag value is set 0, which means that the created node is a permanent path node. When the machine crashes or the kill 9 service process, how can we ensure that the service node is Deregister.

The only solution for that I see is either make ZooKeeper check the service (TCP port check) or by adding a 3rd party service that deregister's services which aren't there anymore.
When you add a 3rd party service you need to make sure to protect against split-brain ofc.
I'm writing this rudumentary as I haven't found any Zookeeper docs on doing health checks.


ERR_CONTENT_LENGTH_MISMATCH on HTTPS connections

Some resources randomly fail to load with the ERR_CONTENT_LENGTH_MISMATCH response. This only seems to happen on HTTPS connections and not HTTP. This could be due to NGINX's proxy.

Adding the following to the location block in https.conf seems to have fixed it:
proxy_buffering             off;
proxy_max_temp_file_size    0;

Still testing if this is a fix.

This seems to have fixed the issue.


Escape '&' in the comment sidebar

Fixes the following issue:
If you have a comment containing an ampersand (&) in the comment
sidebar, it would be treated as an accelerator, i.e. the ampersand
would not be shown, and the character after it would be underlined
(on Windows), or not (on Mac).

Thank you!

I think this is actually a much wider issue than just the comments -- any wrapped text in the sidebar or elsewhere, including the suggestions, is affected.
My first reaction was that using SetLabelText() would do the trick too, but then realized your fix is better and more robust, because it works for all uses and doesn't require us to hunt them all down.
Committed now. Thanks again!


Mark the library as being typed

Configured mypy to run in strict mode, fixed the last remaining untyped places and added the py.typed marker.
The only thing that prevent mypy to fully run in strict mode is aiocache.cached which is untyped and fails with:
pyjwt_key_fetcher/provider.py:92: error: Untyped decorator makes function "_fetch_jwk_map" untyped  [misc]

There are some issues in the CI causes by security warnings due to old libraries.

There are some issues in the CI causes by security warnings due to old libraries.

We should have got those resolved now in the main branch. If you merge in that or rebase on top of it, it should likely be fine now. Apparently the tests executed from the PR do not do a merge behind the scenes with main before running the tests, which I kind of hoped they would have.

Thanks @joakimnordling, I merged main into my branch :+1:

There's still an issue in 3.8, I'll check this.

There's still an issue in 3.8, I'll check this.

I believe switching to using Mapping from typing instead of collections.ABC should likely fix it.
diff --git a/pyjwt_key_fetcher/key.py b/pyjwt_key_fetcher/key.py
index 7dbbbdd..f53ed25 100644
--- a/pyjwt_key_fetcher/key.py
+++ b/pyjwt_key_fetcher/key.py
@@ -1,10 +1,9 @@
-import collections.abc
-from typing import Any, Dict, Iterator
+from typing import Any, Dict, Iterator, Mapping

 from jwt import PyJWK

-class Key(collections.abc.Mapping[str, Any]):
+class Key(Mapping[str, Any]):
     """
     Wrapper for the JWT key and algorithm.
     """

I tested that locally with 3.9 and 3.8 and seemed to work.

I believe switching to using Mapping from typing instead of collections.ABC should likely fix it.

Indeed, thanks!

I'll let a colleague have a look at this still as well and we'll have to get the changelog updated as well, but we can take care of all that. I'm expecting we could get this merged and released tomorrow (possibly later today).
Big thanks for this contribution @multani!


HSEARCH-3288 Document naming conventions in the technical documentation and ensure all classes comply with them

https://hibernate.atlassian.net//browse/HSEARCH-3288

Pull Request Test Coverage Report for Build 1

757 of 811 (93.34%)  changed or added relevant lines in 369 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.003%) to 86.588%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/gson/impl/AbstractNonRootJsonAccessor.java
1
2
50.0%

backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/types/codec/impl/ElasticsearchLocalDateFieldCodecImpl.java
1
2
50.0%

backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/types/sort/impl/ElasticsearchGeoPointFieldSortBuilderFactoryImpl.java
2
3
66.67%

backend/lucene/src/main/java/org/hibernate/search/backend/lucene/search/query/impl/ReusableDocumentStoredFieldVisitor.java
3
4
75.0%

backend/lucene/src/main/java/org/hibernate/search/backend/lucene/types/sort/impl/LuceneGeoPointFieldSortBuilderFactoryImpl.java
2
3
66.67%

engine/src/main/java/org/hibernate/search/engine/cfg/impl/MaskedConfigurationPropertySourceImpl.java
1
2
50.0%

engine/src/main/java/org/hibernate/search/engine/cfg/impl/PrefixedConfigurationPropertySourceImpl.java
1
2
50.0%

engine/src/main/java/org/hibernate/search/engine/common/impl/SearchIntegrationBuilderImpl.java
8
9
88.89%

engine/src/main/java/org/hibernate/search/engine/environment/bean/BeanReference.java
2
3
66.67%

mapper/javabean/src/main/java/org/hibernate/search/mapper/javabean/model/impl/JavaBeanTypeModelImpl.java
4
5
80.0%

Totals

Change from base Build 88:
-0.003%

Covered Lines:
11776

Relevant Lines:
13600

💛  - Coveralls


Move summaries

Related Issue(s): #903 #822
Proposed Changes:

Moved summaries from collection spec to catalog spec
Had to do a minor bit on #822 so that I could link easily between the two.

PR Checklist:

[x] This PR is made against the dev branch (all proposed changes except releases should be against dev, not master).
[x] This PR has no breaking changes.
[x] I have added my changes to the CHANGELOG.

I'm not a fan of this at all and won't approve. For me summaries is fundamental for collections and catalogs is just a "side" use case that no body has ever implemented yet. Thus, I'm not a fan to make it less visible in Collections and hide important details about summaries in Catalogs.

I'm not a fan of this at all and won't approve. For me summaries is fundamental for collections and catalogs is just a "side" use case that no body has ever implemented yet. Thus, I'm not a fan to make it less visible in Collections and hide important details about summaries in Catalogs.

Ok. I don't feel strongly, just was going for not repeating things. I agree collections is the 'main' use case.
What about having the text in collections and linking to that from catalogs? So it appears in the primary place, but catalogs has a line that mentions summaries can be used there? Like just flip it around from how I proposed?

Ok. I don't feel strongly, just was going for not repeating things. I agree collections is the 'main' use case.
What about having the text in collections and linking to that from catalogs? So it appears in the primary place, but catalogs has a line that mentions summaries can be used there? Like just flip it around from how I proposed?

That would work for me.

That would work for me.

Ok, this should be ready to go. Please approve if it works.

Ok, this should be ready to go. Please approve if it works.


Added mdbook entry for bitfields.

Fixes #818

 Warning

These commits modify unsafe code. Please review it carefully!

Hey @ambaxter, still making progress here?

Yes. Work took a lot of my free time the last few weeks. Thankfully today is the last day of that.

As an update, the latest crunch time is over. Combining that with the upcoming US holiday, I should have this updated this week.

Ready for next review

@ambaxter this PR is a bit tough to review in its current state: there seems to be lots of unrelated commits from master mixed in (perhaps a funky merge?)
Can you rebase just your commits on top of master and squash them down to one commit? Alternatively, just check out the latest master and copy your new .md file into it and make a new commit and force push that to this PR.
Thanks!

And thanks for picking this up again!

Weird. Those were from the rebase. I'll reset it.


Red-black tree documentation

So, now all data-structures (but without suffix-tree) has jsdoc.
As far as I understand suffix-tree is not finished yet.

Well, the algorithm for building suffix trees is not the most efficient one, which could be used.
In near future I plan to implement Ukkonen's algorithm algorithm for building suffix trees.


Fix EROFS support of TurboOCI-apply

Fix dependency issues and make adjustments according to the latest liberofs.
What this PR does / why we need it:
Fix dependency issues and make adjustments according to the latest liberofs.
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #
Please check the following list:

[ ]  Does the affected code have corresponding tests, e.g. unit test, E2E test?
[ ]  Does this change require a documentation update?
[ ]  Does this introduce breaking changes that would require an announcement or bumping the major version?
[ ]  Do all new files have an appropriate license header?

After commit
erofs-utils: lib: get rid of global sbi in lib/cache.c
is resolved upstream with a cleaned way, you could switch to the upstream erofs-utils then.


⚠ Samsung has degraded performance

In ae8e05c, Samsung (https://samsung.com) experienced degraded performance:

HTTP code: 200
Response time: 2680 ms

Resolved: Samsung performance has improved in 3f67578.


Add WriterTo interface, combine structs

-Combine singleGetter/batchGetter into single getter struct
-Implement WriterTo interface to be used with io.Copy
-WriterTo also supports using WriteAt for out-of-order writes, if the Writer implements that method

lgtm


[Bug] The default null as a string is causing an issue

Bug report
What I did
I create a model and table in DevTools that contains a nullable field, and when I open the create form in CRUD, I get the default value "NULL" as a "STRING" instead of an empty field.
What I expected to happen
I expect the input to be empty (value='').
What happened
I am getting the value NULL as a string (value='NULL').
What I've already tried to fix it
We have a datetime field in the database that is nullable. When I went to create, the datepicker didn't work—it didn't show up at all until I set ->value('') to empty in the datetime_picker. That's how we solved the issue of getting the datepicker to work, because if "null" stays as a string, it throws an error since it can't parse the date (Uncaught TypeError: defaultDate() Could not parse date parameter: NaN). However, it's not right that we have to manually remove the string "null" from every input field that is nullable in the database.

Is it a bug in the latest version of Backpack?
After I run composer update backpack/crud the bug... is it still there? YES
Backpack, Laravel, PHP, DB version
When I run php artisan backpack:version the output is:
8.2.22

### PHP EXTENSIONS:

Core, date, libxml, openssl, pcre, sqlite3, zlib, bz2, calendar, ctype, curl, hash, filter, ftp, gettext, json, iconv, SPL, pcntl, random, readline, Reflection, session, standard, mbstring, shmop, SimpleXML, tokenizer, xml, i360, dom, fileinfo, gd, gmp, grpc, intl, exif, PDO, mysqlnd, mysqli, pdo_mysql, pdo_sqlite, Phar, posix, xmlreader, xmlwriter, xsl, zip, ionCube Loader

### LARAVEL VERSION:
<IP_ADDRESS>

### BACKPACK PACKAGE VERSIONS:
backpack/basset: 1.3.6
backpack/crud: 6.7.34
backpack/devtools: 3.1.6
backpack/editable-columns: 3.0.10
backpack/generators: v4.0.6
backpack/pro: 2.2.16
backpack/theme-tabler: 1.2.13```

Hey @pedja1982
I'm unable to reproduce the issue.

Can you recheck on your end? If the problem continues, please let me know the steps to reproduce it.

Hey @karandatwani92 @pedja1982 ,
The problem is with the database server. On MySQL it works, but on MariaDB, "NULL" appears in the input field if the field is nullable in the database. Confirmed!
I have that bug as well, but so far I haven't found a solution other than not using MariaDB.
MARIADB - 10.6.18-MariaDB-cll-lve - MariaDB Server

MYSQL -  8.0.39-cll-lve - MySQL Community Server - GPL

@tabacitu Please confirm this bug and find a solution.

Mariadb 10.2.7 and later quote literals to distinguish them from expressions

Default value for the column. Literals are quoted to distinguish them from expressions. NULL means that the column has no default. In MariaDB 10.2.6 and earlier, no quotes were used for any type of default and NULL can either mean that there is no default, or that the default column value is NULL.

https://mariadb.com/kb/en/information-schema-columns-table/


To have a way to define decimal precision

As far as I know, there's no way to define this with the questions asked by JHipster. Thus, we won't implement it unless JHipster does.


Add benchmark results to gpu doc

What does this PR do?
Add benchmark results to GPU usage documentation.

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.

It's really nice, thanks for adding this!
For me the figures are quite small, could we maybe put them one after the other? Or allow in JS to click and zoom (no idea if it's possible)? See:

Also, I'm not sure to understand the legend in the figures:

There are full and dotted black lines in the legend but not in the plot. Also dotted blue/orange lines, that are not in the legend. Is it expected?

@fxmarty ok, I will try to make the display better looking!
Nope, the legend is a combination of two groups of legends.
The first group is "Framework", which distinguishes PyTorch and ORT by color.
The second group is "Generation(mode)", which distinguishes greedy and beam search by solid and dashed lines.

@fxmarty Any better if I put legend this way?

Yes it's much better, thanks a lot!

@fxmarty Graphs replaced!

Awesome PR @JingyaHuang!!! :fire: :rocket:


MM-58280: Don't show the message count for all posts in a thread if CRT is disabled.

Summary
Bugfix: Don't show the message count for all posts in a thread if CRT is disabled.
Ticket Link
Fixes https://mattermost.atlassian.net/browse/MM-50280
Related Pull Requests
NA
Screenshots

before
after

Release Note
* Don't show the message count for all posts in a thread if CRT is disabled.

E2E tests not automatically triggered, because PR has no approval yet. Please ask a developer to review and then try again to attach the QA label.

/e2e-test

Successfully triggered E2E testing!
GitLab pipeline | Test dashboard

Thanks @AshishDhama
Tested, looks good to merge - pending e2es
Verified message reply count for all posts in a threads when CRT is off - no longer shown for each post.
Found small, out of scope, issue and filed separately https://mattermost.atlassian.net/browse/MM-50357

Cherry pick is scheduled.


docs: fix typos in README.md

seperate -> separate
improvments -> improvements

Thank you for your contribution, but closing in favour of #79


Vue 1.0 support?

Is there an ETA on 1.0 support?

1

Use v1 migration for now.
I'm working on v1 support.

@yuche Legend! o/*\o

The following is happening with the v1 version, How should I use https://github.com/vuejs/vue/releases/tag/1.0.0-migration ,
"[Vue warn]: Invalid prop: type check failed for<EMAIL_ADDRESS>Expected Boolean, got String." instance.js:12409:7
"[Vue warn]: Invalid prop: type check failed for width="400". Expected Number, got String." instance.js:12409:7
"[Vue warn]: Failed to resolve directive: class" instance.js:12409:7
"[Vue warn]: Failed to resolve directive: style"

@yuche You're the real MVP (Most Valuable Programmer) :+1:

Hey, Thanks for the migration note.
However, it'd be REALLY nice to know if there is any ETA (i.e. planned for december, or sprint 2016, or something like that).
Boostrap v4 is not important as it is not out of alpha yet. VueJS 1.0.0 however has been released and considered stable.

I have it running on 1.0.0-migration, but I don't feel like it's okay to use in production with all the warnings in place. Would like to fully migrate to 1.0.x asap.

@yuche are you goint to release the 1.0 Version?

One other reason I'd like to know if this is planned is that I've now started to use your components (individually) in my code (modifying them to be compliant with VueJs 1.0.0.
If you had a github branch or any public plans, it'd be nice if I could contribute this back.

+1

+1
and thanks for the nice package :)

+1 <3 Vue ecosystem

All, As somwhat promised, I've started a fork of this project that will give you VueJS 1.0.0 compatibility. I'm hoping this will become a pull-request to the main repository soon, but in the mean time, feel free to use it.
CAVEAT: Only Aside and Datepicker are currently updated. I'm probably going to update the others soon.
https://github.com/amanpatel/vue-strap

@amanpatel Thanks for the effort, I will check it now.

@amanpatel Can you send me a PR on branch v1 please?

Thanks. I just submitted it. I also caught and fixed an issue with yearSelect method in datepicker for 1.0.0 today. I'm planning to tackle the following now:

dropdown
typeahead
tab
button

Added Tab and Tabset in the new PR.
thanks.

@yuche Another PR is ready for your review.
This one is massive. I've updated the docs to run on v1 (including any syntax updates necessary for users who wish to use the componetns under v1).
In addition, I ported Select/Option, and Tooltip components (ohh and Affix too).

Great work @amanpatel  !

@amanpatel wow .. thats a lot works!
great. Thanks :)

This is now released, so closing this ticket. Any issues should be reported separately.


Why can rtx_mutex only be released by the "owner" thread?

In my design, a certain kind of message is serialized (=only one processing at a time) with a mutex. The receiver thread shall (try to) aquire the mutex, give the message to processing, which puts it to a queue later on.
The transmitter thread will eventually pick it from the queue and send the response, and then allow another loop by releasing the mutex.
However, only the owner thread can release a mutex:
https://github.com/ARM-software/CMSIS_5/blob/837ed048639cb9296e1a96a5e10170d83972d8ee/CMSIS/RTOS2/RTX/Source/rtx_mutex.c#L277-L282
I could basically use event flags as well for that purpose, but a mutex seemed to carry the right semantics for this purpose (= locking a resource). Why is the mutex behavior that strict (i.e. only to be released by owner)?

Hi @IngmarPaetzold,
Thanks for reaching out to us. Please note that I transferred your issue over here to RTX's new home.
A mutex is actually defined exactly this way. It is used to protect a singleton resource. I.e., some thread aiming to access a singleton resource must only proceed after successfully acquiring the mutex. Once the thread finished using the resource it must released the mutex. It would not make any sense if a mutex acquired by one thread is released by a totally different thread.
Did you consider using a semaphore instead? Counting semaphores are exactly made for such use cases. I.e., one thread can provide tokens by releasing the semaphore while another thread can consume them by acquiring the semaphore.
But perhaps you don't even need this level of additional complexity. If I understand correctly, the message queue has only one message slot. So, if the receiver thread tries to put another message to the queue this can block unless the transmitter removes the first message freeing up the single message slot.

Hi @JonatanAntoni,
in my understanding, a mutex was basically the same as a semaphore but explicitly with one token. But surely I can try a semaphore with count 1, since I was not aware that mixed-thread operation is kind of a semantic property of a semaphore, but not of a mutex. "Token" is exactly the idea I need. As I see in semaphore's code, there is no such thread owner check 😊.
My workflow is a bit more complex, I had simplified it above:
The (response) queue has actually several slots and collects from different subsystems/threads, some blocking, some non-blocking, hence the asynchronous processing and communicating via queues. The needed singleton token shall ensure that for one particular type (=sub system), messages can only be processed at a time (whereas the other sub systems can).
In the rx thread, detecting which request type was received and aquiring the resource on that type happens on a different level than releasing the resource much later in the tx thread after the response has completely been sent .
All I need is actually a flag where tx thread notifies "Response is sent, resources no longer needed, you (rx) can aquire the next resource for that type". That's where I think about event flags for notification to reset the actual local lock/flag variable. But mutexes - and of course semaphores - have the charm that they not only notify but they are the flag.
So thanks for your answer and clarification on that important difference between mutex and semaphore concerning ownership. I'll give it a try.


A starting point for SWE-Bench Evaluation with docker

Added a docker image that can run SWE-Bench evaluation (only tested on matplotlib), but still facing issues on other repos (e.g., scikit-learn, https://github.com/princeton-nlp/SWE-bench/issues/57).

Hello @xingyaoww can you please double check the built image on the hub? I got the following error.
groups: cannot find name for group ID 409469441
I have no name!@0f7f0b0fbed4:/swe-bench$

I tried to build it using the Dockerfile. It worked well.

LGTM! More problems might happen in the new fork. Later I advise to switch to our official fork. But now I'll just merge it


Offer enhanced multi-data iterator solutions

🚀 Feature

Motivation

We are auditing the Lightning components and APIs to assess opportunities for improvements:
https://docs.google.com/document/d/1xHU7-iQSpp9KJTjI3As2EM0mfNHHr37WZYpDpwLkivA/edit#
Review Lightning architecture & API #7740
As discussed in the above overview doc, there are some opportunities to improve support for multiple dataloaders.
In current PyTorch Lightning, how to handle mult-dataloaders varies between train vs. val/test/predict:

If you pass multiple dataloaders for training, these are combined into a single batch inside of the trainer.
If you pass multiple dataloaders for evaluation/testing, Lightning sequentially loops through each loader. If anything, it's much easier for users to sequentially call Trainer.validate/test/predict(...) for each individual dataloader in a loop instead of doing this altogether. They can also do this in parallel, leading to speedups in overall time spent.
We incur extra complexity handling multiple dataloaders inside each loop since we also need to account for dataloader_idx as another level of nesting (across control flow, logging, and metrics)

We can have abstract classes:

DataIterationStrategy: indicates how the dataloaders are iterated over.
MultiIterator: defines the iteration logic to get a batch
MultiDataloader: it cycles through the individual dataloaders.

These utilities are used by Facebook internally for handling multiple dataloaders, and they are not specific to FB infra. PyTorch Lightning users can also be benefited from this new feature.
Pitch

This will also involve expanding the data loader interface to accept an Iterable instead of collections of PyTorch dataloaders.
Let's remove CombinedLoader from the Trainer internals. This should be supplied via the data interfaces
Multiple dataloader mode should be a property of the data agent, not the Trainer: https://pytorch-lightning.readthedocs.io/en/latest/common/trainer.html

Alternatives
Keep as it is.

Additional context

If you enjoy Lightning, check out our other projects! ⚡

Metrics: Machine learning metrics for distributed, scalable PyTorch applications.

Flash: The fastest way to get a Lightning baseline! A collection of tasks for fast prototyping, baselining, finetuning and solving problems with deep learning

Bolts: Pretrained SOTA Deep Learning models, callbacks and more for research and production with PyTorch Lightning and PyTorch

Lightning Transformers: Flexible interface for high performance research using SOTA Transformers leveraging Pytorch Lightning, Transformers, and Hydra.

@ninginthecloud It'd be very helpful to include more design detail on the iteration strategy, iterator, and dataloader for people to comment on. If you think this would be readable in the issue, feel free to post there. If it would require more space, we could write this up in a separate doc and link it from this issue. What do you think?

Dear @ninginthecloud,
One note to be added early there. Lightning currently supports fault tolerant training for collection of dataloaders and therefore those features should be supported for the new abstractions.
Best,
T.C

Hi, @ananthsub  I will include more details in a doc and add the link here.

Hi, @tchaton Thanks for the valuable information~ Do you have any docs/links for the current support for collection of dataloaders?  In case I'm missing something important here. I will compare the proposed features with existing features as a follow up.

Dear @ninginthecloud,
We didn't create a document yet as it is still on-going,
but here is one of the latest PR: https://github.com/PyTorchLightning/pytorch-lightning/pull/8950.
The logic can be found under those files primarily for DataLoader:
Supporters: https://github.com/PyTorchLightning/pytorch-lightning/blob/e727d8b46d27644724ceec93d5fc7b4651a71520/pytorch_lightning/trainer/supporters.py
The entire auto_restart file: https://github.com/PyTorchLightning/pytorch-lightning/blob/e727d8b46d27644724ceec93d5fc7b4651a71520/pytorch_lightning/utilities/auto_restart.py
Tests:
test_auto_restart.py, /test_auto_restart.py
Search for _fault_tolerant_training() within PyTorch Lightning to find all the places where fault tolerant is added.
Best,
T.C


markdownlint-cli2-codequality: support custom file name

First thank you for the great tooling 👍
I'm using the markdownlint-cli2-junit and also expected the name to be configurable for markdownlint-cli2-codequality:
# Use specific formatter(s) (only valid at root)
outputFormatters:
# https://github.com/DavidAnson/markdownlint-cli2/tree/main/formatter-summarize
- - markdownlint-cli2-formatter-summarize
  - byFileByRule: true
# https://github.com/DavidAnson/markdownlint-cli2/tree/main/formatter-pretty
- - markdownlint-cli2-formatter-pretty
  - appendLink: true
# https://github.com/DavidAnson/markdownlint-cli2/tree/main/formatter-junit
- - markdownlint-cli2-formatter-junit
  - name: markdownlint-report.xml
# https://github.com/DavidAnson/markdownlint-cli2/tree/main/formatter-codequality
- - markdownlint-cli2-formatter-codequality
  - name: markdownlint-quality.json

It creates the file markdownlint-cli2-codequality.json
I know it's documented, but would be good to have it configurable :)

I made a PR to add this capability. One thing of note, in your "example" you specified a filename that ends in .XML, but regardless the file will be in json format, as codequality appears to require json, with XML not being an option.

Thank You! Yes, it was an "copy and paste" issue during my first try :) now changed to json.

Fixed in latest published version 0.0.4 (and possibly the previous).


Cast duplicate index names to text

Hi. What's the reason for this PR? Are not index names text type by default?

Hi. What's the reason for this PR? Are not index names text type by default?

Hi, no they are object identifiers, so it looks like this:

@palm86 thanks! It's now released as 0.7.13


The signature for document.implementation.hasFeature is incorrect

TypeScript Version:  nightly (2.2.0-dev.20170213)
Code
document.implementation.hasFeature("http://www.w3.org/TR/SVG11/feature#BasicStructure", "1.1");

Expected behavior:
It should not emit an error.
Actual behavior:
The following error is emitted:
test.ts(1,1): error TS2346: Supplied parameters do not match any signature of call target.

The function is deprecated so this error actually helped me realize that the code was using a deprecated function but I guess it should work :)

PRs welcomed. You can find more information about contributing lib.d.ts fixes at https://github.com/Microsoft/TypeScript/blob/master/CONTRIBUTING.md#contributing-libdts-fixes.


apt install extra libraries to run machine learning libraries

Is your feature request related to a problem? Please describe.
As a machine learning developer, needs to install some libraries that require apt install.
This is the portal issue that summarize the requests from various GitHub issues.

[ ] vim: #40

It is required to use vim for editor.

[ ] XeLaTeX: #107

It is required to convert notebook to PDF.
The lack of XeLaTeX causes 500 : Internal Server Error when export notebook as PDF.

[ ] local-gen: #111

It is required to localize the installed database.

[ ] libglu1-mesa-dev libgl1-mesa-dev libosmesa6-dev xvfb patchelf ffmpeg cmake swig: #124

There are required to run OpenAI-Gym in notebook.

[ ] libsndfile1-dev: #20

It is required for soundfile, that is main audio file loader in librosa (>0.7.0).
We can use conda package to install librosa: conda install -c conda-forge librosa

[ ] graphviz: #95

It is required to draw the graph. For example, the decision tree visualization in scikit-learn.
We can use conda package to install graphviz: conda install -c conda-forge python-graphviz

Describe the solution you'd like
The above libraries especially the libraries that have no alternative in conda should be installed as default.
Describe alternatives you've considered
We can install by conda if libraries are available in conda-forge.
Additional context
None

Customers would like zip utility, or the ability to install zip using apt.
+1 to libsndfile1

@bariscankurtkaya Thank you for you feedback! if you have the opinions about the priority of above libraries, please let us know.


Light2D Shadow Smoothing produces weird artifacts

Godot version: 3.1
OS/device including version: Windows 10

Setting high level of smoothing on a Light2D shadow produces weird artifacts (see picture). It's less noticeable with smaller levels, but if you know what you are looking for you can still see it

Is it those hard lines below the player and in the upper-left corner?

Without smoothing

With Max smoothing

With light smoothing (barely noticeable, but still there)

Here's a zoomed in version of the last screenshot

Here's a version of the last screenshot with increased contrast so you can more easily see where it happens

Might be fixed with vulkan?

Indeed. The 2D rendering system was overhauled in the move to Vulkan. This issue should be fixed in 4.0. If it is not, we can reopen.
Sorry I can't point to a specific PR, the 2D stuff was added during the period where reduz maintained a separate branch.


Issue with Number of Frontend Replicas

The number of frontend replicas is not known if we call the KubernetesContainerManager connect method directly.
The attribute self.num_frontend_replicas would not be defined . Hence a subsequent call to deploy would fail.
This needs to be fetched during connect and set. Since each front end creates an underlying deployment, the only way i could think of was to read and filter the deployments with the label ai.clipper.name=query-frontend.

Can one of the admins verify this patch?

@santi81 Thanks for catching that!

jenkins ok to test

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Clipper-PRB/1455/
Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Clipper-PRB/1491/
Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Clipper-PRB/1492/
Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Clipper-PRB/1493/
Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Clipper-PRB/1497/
Test FAILed.

@simon-mo @dcrankshaw the builds are failing with random errors every time.I checked and it has got nothing to do with this PR. I guess they are some build issues in general . Could you guys have a look

jenkins test this please

@simon-mo : can you pls merge this PR

@santi81 Merged! Thanks for contributing!


Add linkout to WB pages for entities in select components

Add a linkout icon to avoid linking when clicking on the entity to select it, and a mouse over popup to say that the link goes to WB

added a button that appears when one or more entities are selected from the multiselect component. The button opens multiple windows if more than one entity is selected. It also manages cases where there is a mix of entities with and without IDs.

I tested this wrt viewing multiple genes and on Chrome, if I selected more than one gene, only one browser window opened with the first gene selected.

browser issue. Closing

Add an FAQ to explain behavior on browsers like Chrome and what users should do to fix it (allow pop-ups).


Snapshot files have a new line at the end of file when running on github CI

Issue:
For some reason there's always a new line \n at the end of each snapshot file when running in CI, but not in local machine. Which is causing failure of tests. Tried to compare only the content, instead of using snapshot.assert_match, but that won't allow me to easily update the snapshot by running pytest --snapshot-update
Any pointers or suggestion would be much appreciated. Thank you! 🙏

actually it might be due to linting rules. closing issue now. thanks


Add additional medications and outcomes to the filters and the patient sidebar

TODO:

[x] Add anemia management (oral/iv iron) to the patient_outcomes route
[x] Use anemia management information in the filters and sidebar
[x] Add risk score to the filters and sidebar (include total LOS from that route, too)
[x] Add outcome: ICU LOS (Already exists in sidebar as Postoperative ICU Length of Stay)
[x] Add outcome: total LOS
[ ] Show death as true + date of death if there is a date of death, false otherwise
[ ] Add outcome: heart attack (Waiting for feedback from Ryan)
[ ] Add outcome: revision
[ ] Add outcome: renal failure (Tons of codes for this)
[ ] Get surgery case anemia data from the hemoglobin route to create filter and sidebar information
[ ] Add outcome: Embolism, DVT, clots

Show death as true + date of death if there is a date of death, false otherwise

Is this entry available in any route?

Get surgery case anemia data from the hemoglobin route to create filter and sidebar information

This can be done directly by filtering Preop demo value. Or do we want just a chip option for anemic?

Show death as true + date of death if there is a date of death, false otherwise

Is this entry available in any route?

Death date comes back from fetch_patient

Get surgery case anemia data from the hemoglobin route to create filter and sidebar information

This can be done directly by filtering Preop hemo value. Or do we want just a chip option for anemic?

Yes, I think we should make a filter chip and show the value in the side panel where all the patient surgery data is

Get surgery case anemia data from the hemoglobin route to create filter and sidebar information

This can be done directly by filtering Preop hemo value. Or do we want just a chip option for anemic?

Yes, I think we should make a filter chip and show the value in the side panel where all the patient surgery data is

I'm adding this on the SANKEY branch since sankey diagram also needs this.

From todays meeting:
Do they have iron deficiency?
Do they have anemia?
Cause identified?
Were they treated?
Did they show up to surgery without anemia?
Hemo within one month of the start of surgery
Hemo on date of surgery
Ferritin is a test (good ferritin levels are 30ng/ml, less is deficiency) (make the label iron deficiency)
Patients can have iron deficiency without anemia


Rework the CLI to properly use commands + arguments.

Currently all arguments are available to csharpier but not all of them apply depending on what you are trying to do with csharpier.
Reworking the cli to use the subcommands from System.CommandLine will help with this.
Some examples of commands reworked
dotnet csharpier format . --loglevel None

dotnet csharpier check . --loglevel None

dotnet csharpier server --port 30000

dotnet csharpier pipe-files

Consider also removing the need to prefix things with dotnet, it is an option when building/publishing a dotnet tool.

Should the log level be an Global option?

I would work on this. Could we define the available commands with corresponding options in here?


How can I change default title?

Hi,
I want changing SPRequestPermissionData subTitle.
How can I change default title and Subtitle without pods?

Good day! Soon the release of a new version, you should study it when it comes out.


Add a cookie settings full page example

This PR adds an full page example with the cookie settings components on it, so it's easier to test the cookie settings JavaScript using the review app.
I found this helped me with reviewing #124.
To do this I had to copy the sass and layout of the cookie settings page from the user frontend. So I'm not really sure if this PR is a good idea; maybe it would make more sense to move the JavaScript for the cookie settings page into the user frontend, as it's used there and only there?
Thoughts appreciated.

maybe it would make more sense to move the JavaScript for the cookie settings page into the user frontend, as it's used there and only there?

🤔 Possibly. The reason it's in this repo at the moment is because I was determined to have tests for any new JS we wrote, and I didn't want to introduce a separate JS test suite on the User FE. Also, it wasn't 100% clear at the time which app the cookie settings page was going to live in (it swapped back and forth between Buyer FE and User FE at least once during development), so keeping the code app-agnostic seemed the best option.
The galaxy-brain option is to have the User FE's custom CCS and template layout live in this repo 😸

Hmm, the worry I have is that this will get out of date with the code in digitalmarketplace-user-frontend so may end up presenting a misleading impression if the JS depends on hooks that exist there. So I'm not sure this is the best solution unless we could use git submodules or some other sorcery to keep them in sync?


Merge changes from rd-mg

Thanks for the new commits @rd-mg !

Not sorry, I did this push by mistake
On Fri, Nov 24, 2023, 2:28 PM w1ld3r @.***> wrote:

@.**** commented on this pull request.
Not pushable
On app/requirements-step-2.txt
https://github.com/w1ld3r/crypto-signal/pull/62#discussion_r1404578249:
is there issue with higher jinja2 version ?
On app/analyzers/indicators/roc.py
https://github.com/w1ld3r/crypto-signal/pull/62#discussion_r1404581344:
line 18: period_count (int, optional): Defaults to 15.
Is there a bad period_count default value or a wrong value in the
description ?
On app/config copy.bk2
https://github.com/w1ld3r/crypto-signal/pull/62#discussion_r1404582315:
Is it a wrong commit containning telegram key<PHONE_NUMBER>:AA[...]OY ?
—
Reply to this email directly, view it on GitHub
https://github.com/w1ld3r/crypto-signal/pull/62#pullrequestreview-1748305330,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AJMEYOXO6BCMLN6VQWZ5NF3YGDRLZAVCNFSM6AAAAAA3KT5TOWVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTONBYGMYDKMZTGA
.
You are receiving this because you were mentioned.Message ID:
@.***>


Update Posts “read-me”

Automatically generated by Netlify CMS

👷 Deploy Preview for jchendriks-s5 processing.
🔨 Explore the source changes: 386adfc67fce8ee22f4c5d6192a28d35a9fb5709
🔍 Inspect the deploy log: https://app.netlify.com/sites/jchendriks-s5/deploys/61b7df5c6f812b0007dae746


preset for man_made=monitoring_station

http://wiki.openstreetmap.org/wiki/Tag:man_made%3Dmonitoring_station

Could anybody try to create a pull request ?

Could anybody try to create a pull request ?

Yes, anybody can!

Could anybody try to create a pull request ?
Yes, anybody can!

I know, I mean nobody want to create a pull request until now ?

I know, I mean nobody want to create a pull request until now ?

It is not polite to ask that question.. You can look at the Pull Requests and see what has been created, or create one yourself. 👍


Reduce toolbar options when debugging

I'm not a heavy data science user, but ran into this when verifying https://github.com/microsoft/vscode-jupyter/issues/11986

This was the toolbar when having two columns and no sidebar open on my MacBook screen. In this case, I couldn't see the Variables button, and wouldn't have known it was there if I didn't see it.
Do users do things like adding new cells or clearing output while debugging? If not, should those options be hidden in debug mode to allow more space for debug actions?

I don't think we should do anything different because the user is debugging. I think it's annoying how much space some of these buttons take up though. But @rebornix aren't the labels supposed to be disappearing when the toolbar is narrow? Or no?


Modifying instantiated annotator vs creating new

Suppose I have an annotator:
sample_poly=dict(
    Longitude = [-10114986, -10123906, -10130333, -10121522, -10129889, -10122959],
    Latitude  = [  3806790,   3812413,   3807530,   3805407,   3798394,   3796693])
sample_points = dict(
    Longitude = [-10131185, -10131943, -10131766, -10131032],
    Latitude  = [  3805587,   3803182,   3801073,   3799778])

annot = GeoAnnotator(polys=[sample_poly], points=sample_points)
annot.panel()

And I draw a few extra points on the drawing. Then, I want to redraw that annotator with my newly drawn points. I could do something like:
annot.polys = annot.poly_stream.element
annot.points = annot.point_stream.element
annot.map_view()

But I loose the annotator tools. Why is that? Is this not a recommended approach? Should I just recreate the annotator altogether?
Usecase: I'm rebuilding the Specifying_Meshes.ipynb to work with xmsmesh and also make it a dashboard. So I have an annotator displayed in panel. Then I create a mesh and I want to overlay that on top of the original data and what the user has drawn. Currently, I'm trying to keep the original annotator and modify it. I also will need the ability to clear the old mesh and overlay a new one.

This could now be done by declaring polys and points as parameters and adding dependencies. Previously this would have required a dedicated update method.

In my annotator class, I have a method to update the points that has a param depends on it such that the map and table are both re-rendered. The method includes
self.points = self.point_stream.element or self.points
            self.point_stream = PointDraw(source=self.points, drag=True, data={}, num_objects=self.num_points,
                                          empty_value=self.default_value)
            projected = gv.project(self.points, projection=ccrs.PlateCarree())
            self.point_table = hv.Table(projected).opts(plot=self.table_opts, style=self.table_style)
            self.point_link = PointTableLink(source=self.points, target=self.point_table)

This approach works for updating the map (which is using points and point_stream) but then if I try to access the point_table which HAS been re-rendered, I get a python error and a js error:
Python failed with the following traceback:
/Users/rdchlkcp/miniconda3/envs/esw0415/lib/python3.6/site-packages/param/parameterized.py inner L1146
/Users/rdchlkcp/miniconda3/envs/esw0415/lib/python3.6/site-packages/param/parameterized.py set_param L2491
/Users/rdchlkcp/miniconda3/envs/esw0415/lib/python3.6/site-packages/param/parameterized.py set_param L1292
/Users/rdchlkcp/miniconda3/envs/esw0415/lib/python3.6/site-packages/param/parameterized.py _batch_call_watchers L1407
/Users/rdchlkcp/miniconda3/envs/esw0415/lib/python3.6/site-packages/panel/viewable.py param_change L599
/Users/rdchlkcp/miniconda3/envs/esw0415/lib/python3.6/site-packages/panel/layout.py _update_model L430
/Users/rdchlkcp/miniconda3/envs/esw0415/lib/python3.6/site-packages/panel/layout.py _update_model L69
/Users/rdchlkcp/miniconda3/envs/esw0415/lib/python3.6/site-packages/panel/viewable.py _preprocess L255
/Users/rdchlkcp/miniconda3/envs/esw0415/lib/python3.6/site-packages/panel/pane/holoviews.py find_links L323
/Users/rdchlkcp/miniconda3/envs/esw0415/lib/python3.6/site-packages/holoviews/plotting/bokeh/callbacks.py __init__ L1324
	AttributeError: 'bool' object has no attribute 'all'
index.js:220 Error: Cannot send
    at CommHandler.send (comm.js:111)
    at HVJSExec.push.cue4.HVJSExec._disposePlot (renderer.js:197)
    at HVJSExec.push.cue4.HVJSExec.dispose (renderer.js:220)
    at PanelLayout.push.HWBy.PanelLayout.dispose (panellayout.js:51)
    at Panel.push.FmDU.Widget.dispose (widget.js:73)
    at OutputArea._clear (widget.js:257)
    at OutputArea.onModelChanged (widget.js:223)
    at invokeSlot (index.js:475)
    at Object.emit (index.js:433)
    at Signal.push.qUp9.Signal.emit (index.js:106)

And when I access point_stream, it doesn't see any changes made to the point_table UI.
I think I'm not applying the update correctly since I don't seem to be doing what you recommended, but I don't understand how else I could do it without rebuilding the whole annotator. polys and points are already parameters. The param depends has to be applied to a method, presumably to the view methods.
Can you explain your answer in more detail? Or will this require some time on Thursday?

adding an update method to the existing earthsim point and poly classes should be sufficient instead of @philippjfr trying to sort through my code

I'm trying to utilize the updated annotators. I'm getting the same basic error as above:
Python failed with the following traceback:
/Users/rdchlkcp/miniconda3/envs/esw0626/lib/python3.6/site-packages/panel/param.py update_pane L587
/Users/rdchlkcp/miniconda3/envs/esw0626/lib/python3.6/site-packages/panel/param.py _update_pane L550
/Users/rdchlkcp/miniconda3/envs/esw0626/lib/python3.6/site-packages/param/parameterized.py _f L296
/Users/rdchlkcp/miniconda3/envs/esw0626/lib/python3.6/site-packages/param/parameterized.py __set__ L861
/Users/rdchlkcp/miniconda3/envs/esw0626/lib/python3.6/site-packages/param/parameterized.py _call_watcher L1454
/Users/rdchlkcp/miniconda3/envs/esw0626/lib/python3.6/site-packages/panel/pane/base.py _update_pane L128
/Users/rdchlkcp/miniconda3/envs/esw0626/lib/python3.6/site-packages/panel/pane/base.py _update_object L122
/Users/rdchlkcp/miniconda3/envs/esw0626/lib/python3.6/site-packages/panel/viewable.py _preprocess L255
/Users/rdchlkcp/miniconda3/envs/esw0626/lib/python3.6/site-packages/panel/pane/holoviews.py find_links L323
/Users/rdchlkcp/miniconda3/envs/esw0626/lib/python3.6/site-packages/holoviews/plotting/bokeh/callbacks.py __init__ L1315
	AttributeError: 'bool' object has no attribute 'all'

But I'm getting it from different parts of my panel dashboard. I think I remember seeing this when the panel widgets were disconnected from the param.depends that they were originally linked to. This might just be an issue with my dashboard, but I can't tell from that error.
@philippjfr we should discuss this on Monday as well

I don't know where that error was coming from, but I inadvertently fixed it... Closing.


Unified Error Message For Expression Metrics

Right now the expression message compile error logic is handled with the following codeblock.
{% if not is_multi_metric %}
    {% for metric in metric_list %}
        {% if metric.type != "expression" and metric.metrics | length > 0 %}
            {%- do exceptions.raise_compiler_error("The metric " ~ metric.name ~ " was not an expression and dependent on another metric. This is not currently supported - if this metric depends on another metric, please change the type to expression.") %}
        {%- endif %}
    {% endfor %}
{% else %}
    {% if single_metric.type != "expression" and single_metric.metrics | length > 0 %}
        {%- do exceptions.raise_compiler_error("The metric " ~ single_metric.name ~ " was not an expression and dependent on another metric. This is not currently supported - if this metric depends on another metric, please change the type to expression.") %}
    {%- endif %}
{%- endif %}

This is duplicative and could create issues if someone remembers to update one error string but not the other. We should re-write the logic here to call a single macro that takes an input and returns the error message from a single location.

Addressed in PR #51


Release 1.3.0

#26, #4

:tada: This PR is included in version 1.3.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Not removing commas from end of multiple attributes list

Fix for #3277 - not removing commas from end of multiple attributes list.
The comma was originally removed since otherwise redundant commas would have been added after consecutive closing delimiters.  E.g. .... attr,)]) would have been formatted as .... attr,),],).  To prevent that, a logic was added to prevent the comma removal after the last attribute, but without adding the redundant commas.
UPDATE: per this comment, also resolves issue #3228.

I think the trailing comma should still be removed if it isn't followed by a line break, same as for function calls.

@jplatte I appreciate that you'd prefer different behavior around commas in macro calls, but we're not going to rehash the same, settled posture again on this PR.
The current behavior is a bug which this PR is intended to address, so please refrain from attempts to modify or increase scope.

Whoa okay, sorry! I thought this was simply a case that wasn't considered properly, rather than an intentional design decision. I didn't see it discussed in #3277 at all.

So, to clarify: the behaviour after this PR is that commas at the end of multi-item metalists will not be added/removed at all. If the attribute is converted between multi-line/single-line the user will have to add/remove the final comma to have it consistent with function arguments, but then running rustfmt again will leave it as the user wrote it?

No worries. It was implicit vs explicit, but yes it's intentional. If there's a comma in the input source we need to maintain it regardless of leading/trailing whitespace characters.

but then running rustfmt again will leave it as the user wrote it?

yup

Overall these changes look good to me. I was curious why the Cargo.lock needed to change. Also, If the user wrote .... attr,),],) would we maintain the commas that they wrote or remove them?

I was curious why the Cargo.lock needed to change.

I don't know.  This is beyond my understanding of caro ... It seems that at least the first cargo make after cargo update generates a new lock file.

If the user wrote .... attr,),],) would we maintain the commas that they wrote or remove them?

Adding such commas seem to cause parsing/compilation errors.  Are there cases where such commas are valid?

I don't know. This is beyond my understanding of cargo ... It seems that at least the first cargo make after cargo update generates a new lock file.

Ah I see. I don't think you need to use cargo make to build rustfmt anymore. At least I haven't had to use it on the 1.x branch. cargo build has worked just fine for me.

Are there cases where such commas are valid?

Maybe not in the case of all attribute macros, but you could conceivably write a macro that requires them and removing those commas would then lead to compilation errors. Ultimately I think our goal for macro rewriting is to not add or remove any tokens so if the developer wrote .... attr,),],) that's what it should be formatted to.

... cargo build has worked just fine for me.

Switched to cargo build and it works fine also for me. Thanks.

Ultimately I think our goal for macro rewriting is to not add or remove any tokens so if the developer wrote .... attr,),],) that's what it should be formatted to.

This PR changes should not affect such macro case.  However, I was not able to write code example that will prove that.

... cargo build has worked just fine for me.

Switched to cargo build and it works fine also for me. Thanks.

Ultimately I think our goal for macro rewriting is to not add or remove any tokens so if the developer wrote .... attr,),],) that's what it should be formatted to.

This PR changes should not affect such macro case.  However, I was not able to write code example that will prove that.

Switched to cargo build and it works fine also for me. Thanks.

Fantastic! I assume with the switch you wont see any other changes with the Cargo.lock

This PR changes should not affect such macro case. However, I was not able to write code example that will prove that.

Taking an existing test case, could we just add trailing commas and make sure that those commas aren't removed. For example:
#[cfg(all(feature1 = "std1",feature2 = "std2",),),]

#[cfg(all(feature1 = "std1",feature2 = "std2",),),]

This is a good example! I found that my initial fix was wrong, and did not properly handle the commas between the parenthesis ...  (Note that the last comma before the ] in the example is illegal and causes compilation error.)
I re-implemented the fix and added test cases.  The root cause of the issue is that for a list in an attribute, the last AST item includes both the list closing ')' and the attribute closing ']'.  Therefore, the check in span_ends_with_comma() of whether there is a comma before the last closing parenthesis did not handle such case properly.

@davidBar-On I've been doing some backlog triage and came across #3228, which this PR solves. If you don't mind could you add a test case for the #![allow(nline_always,)] case mentioned in that issue.

... #3228, which this PR solves. If you don't mind could you add a test case for the #![allow(nline_always,)] case mentioned in that issue.

Added tests/target/issue-3228 folder with this and two other test cases.  Did not add source tests since the tests are just to make sure no commas are removed.

Thank you!!

What's the status of this PR? Would be nice to get this merged.


Allow having an informative message appear after the question but before the prompt

Currently, creating the app/empty template looks like this:
! 🪡 To learn more: https://github.com/varabyte/kobweb#silk
? Would you like to use Silk, Kobweb's powerful UI layer built on top of Compose for Web?
> yes

! 🌐 To learn more: https://github.com/varabyte/kobweb#server
? Would you like to include support for defining server behavior via API routes and API streams?
> no

This would probably look better as:
? Would you like to use Silk, Kobweb's powerful UI layer built on top of Compose for Web?
! 🪡 To learn more: https://github.com/varabyte/kobweb#silk
> yes

? Would you like to include support for defining server behavior via API routes and API streams?
! 🌐 To learn more: https://github.com/varabyte/kobweb#server
> no

But to do this, we'd need to add an "inform" parameter to the CLI's "QueryVar" command.
(Then we'd probably need to wait a few months for people to update before making the change to the empty template to use the new way, because we don't want to break users who haven't upgraded yet)

This functionality has been added to 0.9.14 but we're going to wait a little while before updating the templates to give user's a chance to update.


clippy: variables can be used directly in the format! string

Allowing the lint instead of fixing as the oldest rust compiler supported by pcap does not support the new feature.

This lint is aware of the MSRV:
https://github.com/rust-lang/rust-clippy/blob/54e929bddee5934c527894fabee8a2c48531a795/clippy_lints/src/format_args.rs#L205

https://github.com/rust-lang/rust-clippy/issues/10087, Can we add msrv field that get a warning ?


New-FilterXML

Create new function, New-FilterXML, to provide usable FilterXML for basic Get-WinEvent.

Created the following two public functions:

New-EventFilterXml
New-EventDataFilter


Add the source of the PNG shown in https://cert-manager.io/docs/concepts/certificate/

Back in 2021, I forgot to add the source in 1. Or rather, I had embedded the source inside the PNG file, which is surprising to anyone who wants to make changes to the diagram. As I explained in 2, let's have the source directly checked in Git.
If you would like to re-generate the PNG file, you have two options:
From the UI:

Open the drawio file,
Export it to PNG with a zoom of 200% (otherwise, the PNG is too blurry).
⚠ IMPORTANT ⚠: Compress the resulting PNG with https://tinypng.com/.

From the command-line (macOS instructions):

brew install drawio
npm i -g tinypng
Create an account at https://tinypng.com/ and get the token in the settings.
alias drawio=/Applications/draw.io.app/Contents/MacOS/draw.io
drawio -x -f png -o public/images/letsencrypt-flow-cert-manager.png public/images/letsencrypt-flow-cert-manager.drawio --scale 2
tinypng -k <token> public/images/letsencrypt-flow-cert-manager.png

/cc @inteon

Thanks a lot
/approve
/lgtm


monitor: reduce critical section in (*Monitor).handleEvents

Don't acquire the lock for preparing payload type, only acquire it
before accessing m *Monitor fields. This also allows to merge
(*Monitor).send and (*Monitor).sendLocked.
Signed-off-by: Tobias Klauser<EMAIL_ADDRESS>

This change is

test-me-please

Coverage decreased (-0.02%) to 45.534% when pulling 5e62dc3004fd33491c18d21d72e2c52bb97a41a8 on pr/tklauser/monitor-reduce-critical-section into 0c67ebf581caf2dd6650e690dc71f42291865e6f on master.

In the common case when there are no lost samples, the critical section would now be smaller there so it should be more efficient. However it means also that if we get into the case where the ringbuffer is full, then I would expect that updating the statistics for lost messages will be more expensive because the lock must be acquired twice.

The idea was to optimize for the common case and live with a penalty in the error case where presumably the additional overhead wouldn't matter.

That said this feels like premature optimisation; it's not obvious to me that we're really saving a lot of processing here. Do we have any evidence that this lock is under contention or that the reduction in critical section makes a meaningful difference at runtime?

You're right, it's probably premature optimisation. It just felt weird that the critical section was larger than it need be while reading the code in question. But I don't have any profiling data which would show lock contention or performance penalties.

EDIT: Well, I guess the other argument is if this makes the code simpler. However, we use this send() vs. sendLocked() style elsewhere in the codebase so I don't think it makes a meaningful difference there either.

Even if the same style is used elsewhere, if additioanl code can be avoided it's still nice to get rid of it IMO.
So yeah, in the end it's probably not worth it. Thanks for the feedback @joestringer.


Empty line

i think it is not necessary line.

Can you rebase, the change in Examples/SampleApp/index.ios.js has already been done


rearranging page after closing sidebar when selecting header on mobile

when i am inside the document and open sidebar, the main text of document were shrinked, so, when i select header in sidebar, its navigate correctly, but when i close a sidebar, the content again grows horizontaly, losing headers position(because number of rows is changing)

I see the problem .. Hm, will check if displaying the sidebar not expanding but as overlay (on small devices) solves this problem.


Would like to be able to avoid asset load errors at runtime

Currently with Flutter it's very easy to end up with asset load errors at runtime since assets are keyed off of strings, which are not in any way validated at analyze time (or generated/provided by the system).
Posse's currently most common crash in their live app is a failed asset string load.
They also have a manual file of string constants that they maintain from their pubspec.yaml (presumably could be autogenerated pretty easily).
This just seems like a pattern we could help with. This bug is about finding ideas to reduce the likelihood of this kind of failure.
FYI @yjbanov

We could autogenerate an enum of known asset names, or some such.

I'm still keen to deliver this, I was never sure what was flutter team's opinion on it. My POC is frozen since the beta days. I'll come up with some MVP clean enough that it could be a PR. Soon (TM).

Hi, all:
I'm a member of Fly-Mix Team from NetEase company. My team did develop a flutter development tool: Flr(Flutter-R) to support the feature that you want.
Flr is a flutter resource manager tool, which can help flutter developer to auto specify assets in pubspec.yaml and generate r.g.dart file which likes R.java in Android after he changes the flutter project assets. With r.g.dart, flutter developer can apply the asset in code by referencing it's asset ID function, such as:
import 'package:flutter_r_demo/r.g.dart';

// test_sameName.png
var normalImageWidget = Image(
  width: 200,
  height: 120,
  image: R.image.test_sameName(),
);

// test_sameName.gif
var gifImageWidget = Image(
  image: R.mage.test_sameName_gif(),
);

// test.svg
var svgImageWidget = Image(
  width: 100,
  height: 100,
  image: R.svg.test(width: 100, height: 100),
);

// test.json
var jsonString = await R.text.test_json();

// test.yaml
var yamlString = await R.text.test_yaml();

PS: yes, it is just like the AAPT(Android Asset Packaging Tool) in Android.
Up to now, Flr has supported Android Studio Plugin, CLI, and VSCode Extension:

Flr Android Studio Plugin Version

GitHub:  https://github.com/Fly-Mix/flr-as-plugin

Plugin Homepage: https://plugins.jetbrains.com/plugin/13789-flr

flr-as-plugin Usage Example Gif:

Flr CLI Version

GitHub: https://github.com/Fly-Mix/flr-cli

CLI Homepage: https://rubygems.org/gems/flr

flr-cli Usage Example Gif:

Flr VSCode Extension Version

GitHub: https://github.com/Fly-Mix/flr-vscode-extension

Extension Homepage: https://marketplace.visualstudio.com/items?itemName=LincolnLaw.flr

flr-vscode-extension Usage Example:


[itbl-5833] - Deferred Deeplinking

Add deferred deep linking to SDK.

Add config option for DDL (deferred deep linking).
Send deviceInfo to server and do DDL on first launch.
Little bit of refactoring of how to do local storage.

Codecov Report

Merging #21 into master will decrease coverage by 2.25%.
The diff coverage is 54.41%.

@@            Coverage Diff             @@
##           master      #21      +/-   ##
==========================================
- Coverage   67.74%   65.49%   -2.26%
==========================================
  Files          22       24       +2
  Lines        1727     1881     +154
==========================================
+ Hits         1170     1232      +62
- Misses        557      649      +92

Impacted Files
Coverage Δ

swift-sdk/DeviceInfo.swift
0% <0%> (ø)

swift-sdk/IterableRequestUtil.swift
90.69% <100%> (+2.32%)
:arrow_up:

swift-sdk/IterableAPIInternal.swift
57.24% <100%> (-0.07%)
:arrow_down:

swift-sdk/IterableAPIInternal+Extension.swift
62.23% <24.32%> (-8.71%)
:arrow_down:

swift-sdk/IterableAttributionInfo.swift
50% <85.71%> (+5.55%)
:arrow_up:

swift-sdk/UserDefaultsLocalStorage.swift
89.41% <89.41%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 479c42c...d906d6b. Read the comment docs.


test: use T.TempDir to create temporary test directory

[ ] I added CHANGELOG entry for this change.
[x] Change is not relevant to the end user.

Changes
A testing cleanup.
This pull request replaces os.MkdirTemp with t.TempDir. We can use the T.TempDir function from the testing package to create temporary directory. The directory created by T.TempDir is automatically removed when the test and all its subtests complete.
This saves us at least 2 lines (error check, and cleanup) on every instance, or in some cases adds cleanup that we forgot.
Reference: https://pkg.go.dev/testing#T.TempDir
func TestFoo(t *testing.T) {
	// before
	tmpDir, err := os.MkdirTemp("", "")
	testutil.Ok(t, err)
	defer func() { testutil.Ok(t, os.RemoveAll(dir)) }()

	// now
	tmpDir := t.TempDir()
}

Verification
Tests passed.

It would be cool to finish https://github.com/fatih/faillint/issues/30 one day and add a new rule to forbid using os.MkdirTemp in tests 😄


Ctrl-d/u scrolling behavior is not consitent.

There are many sites which Ctrl-d/u scrolling is behaving funny. Take github.com as a example:

Until this frame gets scrolled to bottom, Ctrl-d starts to scroll the page.

@amosbird, is this resolved? If so, please close.


PLIN-4577 macos notarization

Jira Issue URL
https://inflight.atlassian.net/browse/PLIN-4577
High-Level Description
Configured github actions with "quill" to sign and notarize mac binaries.
Check it out: https://github.com/skuid/skuid-cli/releases/download/actions_test-0.0.5/skuid_darwin_amd64
Changelog:

Is there any way to test it, or just by releasing and making sure the GitHub actions do what is expected?

I already tried it out with some test releases. Download https://github.com/skuid/skuid-cli/releases/download/actions_test-0.0.5/skuid_darwin_arm64, chmod +x and see if macOS lets you run it without security settings workarounds. :-)

(I don't know if you need admin on the repo, but you can also see some build runs at https://github.com/skuid/skuid-cli/actions)


NotSupportedException vs Not supported warning.

I just wanted to bring this up for discussion.
The idea is that some graph DBs are going to support some features while others wont. Examples range from tree functionality to transactions to indexing capabilities.
Now if every DB Driver or Schema implementation throws exceptions on unsupported features, this means that ultimately, switching backends will not be possible without a wave of exceptions being thrown, and code refactor.
I feel it's our duty to make the transition from one backend to another as easy as possible. Hence the introduction of warnings.
The idea is that if you are using transactions in your app with a transaction enabled GraphDB, and then you decide to switch to a transaction disabled GraphDB, the system will emulate transactions but throw a warning (non thread breaking). Rather than outright throw a thread breaking exception.
Same could be done with creating indexes if it isn't supported, the system just ignores the index creation and throws a warning. (queries etc.. still work they just don't use index optimization)
Some cases like tree however will need to continue throwing exceptions as it would be a potential app breaker.
Thoughts?

I like the idea, but its implementation may be difficult. Even warnings can be a problem in production code. No system is going to be 100% db swappable. Instead, lets try to make it as painless as possible. Say (in most cases), no more than 2hrs work, or whatever.
We will eventually have a top level Spider which will hold configuration and be a factory of sorts. What if we gave the option for three levels of warnings:

Fatal - every not supported is fatal.
Quiet - we produce warnings, probably by catching the exceptions and raising warnings
Silent - when possible, no output is rendered. Only logged using the logger of their choice.

Which also raises the issue of logging and caching with third-party packages. Simple interfaces for logging, events, and caching may be helpful. FIGG is working on these, so we can implement them at a time in the future.
There is also the issue of multi-model databases that need to be considered, though in a different issue. For instance, OrientDB has polymorphism in its vertex types (labels) and document db features. There should exist a way for third-party packages to extend Spider for these db-specific features.

I agree that all sounds good. As For OrientDB, I know that they are currently working on a TP3 implementation. I'd be curious to see how that works out before moving forward as it may shed some lighting on how to handle these scenarios.

I am going to add this configuration into the top-level api. Issue #22

Moved into #22. Closing conversation here.


Version 1.14.10+build.15 (the latest release on CF) has "unspecified" as the version

One of my mods has a "modmenu >= 1.12.0" requirement, and I started to get reports that it didn't work with the latest modmenu release. Specifically:
Could not find required mod: better_mod_button requires {modmenu @ [>=1.12.0]}
Creating Empty clause ?

After a bit of digging, I noticed that the version field in 1.14.10+build.15 was set to "unspecified" instead of "1.14.10+build.15"

Modifying to the current version manually works:
"version": "1.14.10+build.15",
I used 7-zip and didn't have to extract anything. Just opened in Notepad++, edited, saved, went back into 7-zip and it updated the file.

Yup, in my reply to the reports my mod got, I had suggested the same, just thought I'd bring it up, since I doubt my mod was the only thing affected by it

Whoops, ok. I've reverted this version since it seems super messed up.


[1.1.1] Query: Materialize shadow properties in derived types properly

1.1.1 port for #7485

@ajcvickers @divega @AndriySvyryd Please review for breaking changes.

Functional changes look good.

LGTM


Menu layout fixes

This fixes some minors in the menu layout if the overall width is increased by a plugin:

always keep the menu title icon width the same
Make use of the full width within the print form

Example:

Please review @terrestris/devs.

Thanks for the review!

:tada: This PR is included in version 5.2.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


fix: return faked response from up status check in check mode

Currently in check mode, the tailscale up status handler will fail out as it's trying to find a real status code for a faked out $ tailscale up command. This PR will return a true value when in check mode allowing Ansible's check mode to continue unabated.

Should the "Fetch Tailscale status" task also be disabled in check mode?


AMIP with Partitioned Fluxes

The Climate Modeling Alliance
Software Design Issue 📜
Purpose

We need a stable interface with robust checks, so once standalone ClimaAtmos is complete, we can immediately test our AMIP configuration. We will also finalize all large software components that need input from scientists (i.e. partitioned surface fluxes).
Cost/Benefits/Risks

b: streamlining AMIP delivery.
People and Personnel

Lead: @LenkaNovak
Collaborators: @valeriabarra
Reviewers: @juliasloan25

Components

there are two parts:

update package versions / fix outstanding bugs in existing code (AMIP Roadmap non-optional requirements)

once this is complete, the AMIP run can be used as a benchmark again

enhancements (other features used by AMIP setups)

fluxes: revise surface fluxes (also the order of timestepping (e.g. radiation) relative to flux computation in Atmos) + include the option to calculate partitioned fluxes
check for masking
bring back Slack reports

Results and Deliverables

[x] utility to calculate fluxes from multiple surfaces and then combine https://github.com/CliMA/ClimaCoupler.jl/milestone/5
[x] physical correctness summary to weekly Slack updates https://github.com/CliMA/ClimaCoupler.jl/milestone/6

QA

[x] conservation tests pass (e.g. #360 )
[x] coupled comparable to atmos for performance

Atmos v Coupler like for like comparison (using the same dt and apply_limiters=false):
Atmos dt=200s (cpu=32, 22 nodes) → 23h25m
Coupler dt=200s (cpu=32, 1 node) → 20h50m
Coupler dt=200s, ct_cpl=600 (cpu=32, 2 nodes) → 20h45m
Coupler + topo, dt=100s (cpu=32, 1 node)  →  ~40h20
Coupler + topo + edmf, dt=100s (cpu=32, 1 node)  →  70days in 20h17

[x] physical tests (see Buildkite runs for different comparisons, also #355, and Slack #coupler-report )

reasonable comparison with observations (TOA fluxes, precipitation, circulation metrics), given the Atmos setup (benchmark)

Task Breakdown And Schedule

fig outstanding bugs in existing code (AMIP Roadmap non-optional requirements)

[x] #282 [25 April]
[x] masking - ensure all tests are implemented and passing for all masking options  #286 [1 May]
[x] use most recent ClimaAtmos [15 May]

this will be done in #281 in a separate folder. Here we will update those API changes to the main driver, and we'll work together with @valeriabarra to update the general environment and tests.

[x] enable a surface flux calculation from the atmosphere (from averaged surface states) and partitioned flux calculation from the Coupler (using individual states) #311 [1 August]

SDI Revision Log

tasks to accomplish the Coupler release were split into two SDIs (WIP)

CC
@tapios @simonbyrne @cmbengue

Complete


[AutoPR cognitiveservices/resource-manager] [Cognitive Services] Add Microsoft.CognitiveServices/skus operation

Created to sync https://github.com/Azure/azure-rest-api-specs/pull/2666

(message created by the CI based on PR content)

Codecov Report

Merging #2301 into restapi_auto_cognitiveservices/resource-manager will not change coverage.
The diff coverage is n/a.

@@                               Coverage Diff                                @@
##           restapi_auto_cognitiveservices/resource-manager    #2301   +/-   ##
================================================================================
  Coverage                                            52.76%   52.76%
================================================================================
  Files                                                 5627     5627
  Lines                                               133882   133882
================================================================================
  Hits                                                 70637    70637
  Misses                                               63245    63245

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 18e0972...496b3ab. Read the comment docs.

Regeneated from ServicePR


Support for Java Actions

Including tests. Works with the caveat that the action JAR must be "small" (for now). Superseeds #77.

TravisCI failure due to ConsulKV (see #79). Relaunched.

perf pg 119

...and regular pg 142!

rebased and merged.

11556af73e96c7070173f1191ae1b27c82080b72


Is this section still relevant?

@MagTer commented on Wed Sep 11 2019
Azure file shares do not currently support Kerberos authentication with your Active Directory (AD) or Azure Active Directory (AAD) identity, although this is a feature we are working on. Instead, you must access your Azure file share with the storage account key for the storage account containing your Azure file share.

Dokumentinformation
⚠ Redigera inte det här avsnittet. Det krävs för docs.microsoft.com ➟ länkning till GitHub-problem.

ID: c12f1ea9-6446-be01-22fe-885fb945d22c
Version Independent ID: 634f8ace-1a8c-6811-627b-fdfbdd1942a3
Content: Använda en Azure-filresurs med Windows
Content Source: articles/storage/files/storage-how-to-use-files-windows.md
Service: storage
Sub-service: files
GitHub Login: @roygara
Microsoft Alias: rogarana

@srvbpigh commented on Wed Sep 11 2019
Hello, @MagTer
Thank you for your feedback.
We are actively reviewing your comments and will get back to you soon.
Kind regards,
Microsoft DOCS International Team

Hi team,
I moving this here because it refers to the original documentation
best regards

@MagTer Thank you for the valuable feedback,we are investigating the issue.

@MagTer AAD authentication is actually supported with Azure File Share, You can refer to the following documentation: https://docs.microsoft.com/en-us/azure/storage/files/storage-files-active-directory-overview
Let me know if this helps.

@MagTer @CeciAc As @Adam-Smith-MSFT pointed out, this section is incorrect. We have AAD authentication through domain services, currently. We're still working on updating/improving the authentication relevant documentation but, we appreciate you pointing out places where it needs attention. :)

Also worth pointing out that you need to set the share (RBAC) permissions under IAM in the Azure web portal for the file share. Once you have done that follow the above instructions to map it using the storage account name and access key. Then you can set the NTFS permissions. Once the NTFS permissions have been set you can get rid of the credentials (from credential manager) and map it normally using the logged on users Azure AD credentials (as long as you have Azure AD Domain Service set up and it has synced any recent on-prem AD changes).

We've significantly reworked the identity-based authentication story and as such this should be resolved. Also this segment has been removed from this article.
Accordingly:
#please-close


Fix bad request for some IP ONVIF cameras

This PR contains the following changes:

Replace the onvif component with onvif-zeep v0.2.12 (seems more actively maintained, but better yet, ensures correct authentication headers)
Add warning in case the date/time of the camera and system are not the same, this could potentially lead to authentication issues
Added extra logging to be able to find the cause of mismatch easier in the future

Fixes #20668

Hi @GeertvanHorrik,
It seems you haven't yet signed a CLA. Please do so here.
Once you do that we will be able to review and accept this pull request.
Thanks!

2 / 6 builds are failing, but I am unsure why. Could someone point me in the right direction? Thanks!

Need to redo some file changes since this has been moved. Will first try to get it working locally again with 0.91.x.

Deprecated, see #22972 for the updated PR.


Rework Azure CLI version regex to be compatible with 2.0.58

Fixes #475.

Is it possible this broke again? getting the same error on 2.0.65
C:\windows\system32>az --version
azure-cli                         2.0.65
Error checking prerequisites
The Azure command line failed. See below for the error message. You may need to:
Log into the Azure CLI (run az login in the terminal)
Install the Azure CLI (see the instructions for your operating system)
Configure Kubernetes from the command line using the az acs or az aks command
Details
Azure CLI 2.0 not found - install Azure CLI 2.0 and log in

Aaugh, taking a look.  Thanks for the heads up @jvermast.

@jvermast It's working for me on 2.0.66 (which is what the download page gave me).  I'm not sure why you might be seeing an error here...

Very odd... I'll try 66. Had a couple guys on my team with the same error on 65. I'm sure it's something were doing...but az cli is definitely working. Very odd indeed.
I'll let you know what I figure out

Thanks.  If you feel confident, you could try running the extension from source (clone the git repo, load into VS Code and hit F5) and set breakpoints on the azureCliVersion command (in src/components/clusterprovider/azure/azure.ts line 83) to see why it's not working.  (You don't need to uninstall the marketplace extension to do this - the debuggee extension will overwrite it temporarily and in the debug environment only.)  But yeah, let me know if you keep running into it and I'll see if I can dig out 65 and try again.

Gave that a shot, I see azVersion is null so it throws the Azure CLI 2.0 not found.
Az looks fine itself...
PS C:\X\vscode-kubernetes-tools> az --version
azure-cli                         2.0.65
acr                                2.2.7
acs                                2.4.2
advisor                            2.0.0
ams                                0.4.6
appservice                        0.2.20
backup                             1.2.4
batch                              4.0.1
batchai                            0.4.9
billing                            0.2.1
botservice                         0.2.1
cdn                                0.2.3
cloud                              2.1.1
cognitiveservices                  0.2.5
command-modules-nspkg               2.0.2
configure                         2.0.23
consumption                        0.4.3
container                         0.3.17
core                              2.0.65
cosmosdb                          0.2.10
deploymentmanager                  0.1.0
dla                                0.2.5
dls                                0.1.9
dms                                0.1.3
eventgrid                          0.2.3
eventhubs                          0.3.6
extension                          0.2.5
feedback                           2.2.1
find                               0.3.3
hdinsight                          0.3.4
interactive                        0.4.4
iot                                0.3.9
iotcentral                         0.1.6
keyvault                          2.2.15
kusto                              0.2.2
lab                                0.1.7
maps                               0.3.4
monitor                           0.2.14
natgateway                         0.1.0
network                            2.5.0
nspkg                              3.0.3
policyinsights                     0.1.3
privatedns                         1.0.1
profile                            2.1.5
rdbms                             0.3.11
redis                              0.4.3
relay                              0.1.4
reservations                       0.4.2
resource                          2.1.14
role                               2.6.2
search                             0.1.1
security                           0.1.1
servicebus                         0.3.5
servicefabric                     0.1.19
signalr                            1.0.0
sql                                2.2.4
sqlvm                              0.1.1
storage                            2.4.2
telemetry                          1.0.2
vm                                2.2.21
Python location 'C:\Program Files (x86)\Microsoft SDKs\Azure\CLI2\python.exe'
Extensions directory 'C:\X\cliextensions'
Python (Windows) 3.6.6 (v3.6.6:4cf1f54eb7, Jun 27 2018, 02:47:15) [MSC v.1900 32 bit (Intel)]
Legal docs and information: aka.ms/AzureCliLegal

I looked into it some more.
If I remove  || sr.stderr from line 85 it works as expected. I see the following at the end of my "az --version"
"WARNING: Unable to check if your CLI is up-to-date. Check your internet connection."
Which I believe is what's causing the issue, even though its really not an issue. :D

Ah, okay.  I think we had experiences perhaps with older versions where it could fail but still return exit code 0, so we had to check stderr as well.  That might have been for the service plug-ins though (from a previous life I seem to recall that it buried errors from Azure Batch.)  Let me raise a new issue for this and get it fixed.
Thanks for digging into this - not something we could have easily reproduced and I appreciate the time you put in helping us make things better.

@jvermast Should be fixed in 1.0.1, up on Marketplace now.


Update setup.py

Actually install the python scripts

Coud you describe how you are instlling our package and what you are exeriencing ?
It's a pyproject.toml only repository so I'm curious why you need to duplicate information here.

Ok, I moved to pyproject then :)

if you don't use pip to install,  python build is your friend


Marker lengths are being cut off

The markers can be I guess 53 characters big?
20 for the name, 30 for the description, 3 for the gap.

Marker labels were previously limited to 25% of the viewport width. I've removed this limit now.


How do I get the IP address of a client that makes a request to the server?

Yes, I saw this issue(#106), but it didn't help me, so I ask the question again

To get the IP address of a client that makes a request to the server in ElysiaJS, you can use the following code:
JavaScript
"""
import { Elysia } from 'elysia';
const elysia = new Elysia();
elysia.on('request', (req, res) => {
// Get the client IP address from the req.headers object.
const clientIp = req.headers['X-Forwarded-For'] || req.headers['CF-Connecting-IP'] || req.socket.remoteAddress;
// Use the client IP address in your application.
console.log(The client IP address is ${clientIp});
});
elysia.listen(3000);
"""
The req.headers object contains all of the HTTP headers that were sent in the request. The X-Forwarded-For header is typically set by a proxy server, such as Cloudflare or Nginx. If the request is not coming from a proxy server, then the req.socket.remoteAddress property will contain the IP address of the client.
Example:
"""
JavaScript
import { Elysia, rateLimit } from 'elysia';
const elysia = new Elysia();
elysia.use(rateLimit({
keyGenerator: (req) => req.headers['X-Forwarded-For'] || req.headers['CF-Connecting-IP'] || req.socket.remoteAddress,
max: 10,
duration: 60000,
}));
elysia.on('request', (req, res) => {
// ...
});
elysia.listen(3000);
"""
This code will limit each client to 10 requests per minute. If a client makes more than 10 requests per minute, they will be blocked.
Note: If you are using ElysiaJS with a proxy server, you may need to configure the proxy server to forward the client IP address to your ElysiaJS server.
Additional notes:
It is important to note that getting the client IP address is not always reliable. For example, if the client is using a VPN or a proxy server, then you may not be able to get the real IP address of the client.
If you need to get the real IP address of the client, then you may need to use a third-party service such as IP Geolocation API.
Conclusion:
Getting the client IP address in ElysiaJS is a straightforward process. You can use the req.headers object or the req.socket.remoteAddress property to get the client IP address. However, it is important to note that getting the client IP address is not always reliable.

Yes, thank you, it helped me, but I'm not writing in JS, but in TS.
Because of this, I don't have a request.socket.remoteAddress'. And I also don't have an ip if I use localhost:3000or<IP_ADDRESS>:3000` ((
But I tried to make a request through ngrok and everything worked out)) Which means it will work in production.

As you mentioned, the req.socket.remoteAddress property is not available in TypeScript. However, you can still get the client IP address by using the req.headers object.
If you are using ElysiaJS with a proxy server, you may need to configure the proxy server to forward the client IP address to your ElysiaJS server.
I am glad to hear that you were able to get the client IP address to work in production using ngrok.

nigga thought he was slick using chatgpt


[WFLY-19668] Upgrade Infinispan to 14.0.31.Final

https://issues.redhat.com/browse/WFLY-19668
This PR supersedes https://github.com/wildfly/wildfly/pull/18108

In general, Infinispan/JGroups upgrades should always be validated first against wildfly-clustering (as of https://github.com/wildfly/wildfly/pull/17910).
Also, this needs an additional rxjava upgrade.  I'll send a new PR when ready.


Installing simmate quickly with mamba or pip

@scott-materials
Discussed in https://github.com/jacksund/simmate/discussions/332

Originally posted by scott-materials November 26, 2022
Often, creating a new conda environment is extremely slow, such as:
conda create -c conda-forge -n scotts_env python=3.10 simmate spyder psycopg2
For those running into a slow installation, I highly recommend using mamba.
This has reduced installation times to 10-20 seconds.  The installation is done identically:
mamba create -c conda-forge -n scotts_env python=3.10 simmate spyder psycopg2
Subsequent commands, like activating the environment, are then simply done with conda:
conda activate scotts_env
Mamba is installed on our WarWulf cluster.  Hope this helps someone!
Issue Summary
The docs can be quickly updated to let users know alternative install strategies.
Because Simmate has because pretty large (in term of its dependencies), we should consider either (1) changing our recommended installation to pip/mamba and/or (2) better describe alternative installation strategies in the docs.
To-do items

[ ] add pip to homepage
[ ] add mamba to homepage
[ ] update recommended install command to create for conda
[ ] update CI workflows to mamba
[ ] add new CI workflow to test user conda/mamba/pip installs
[ ] (optional) change install tutorial to mamba
[ ] (optional) change install tutorial to pip

There's another fix for this that I'll need to make a separate issue/PR for:
The Simmate calculators module is going to be changed to apps where each submodule will become optional. This means each app's dependencies (matminer, clease, etc.) will also become optional (and make the installation faster). Further down the line, we can make apps separate installations as well -- following django-like conventions ("e.g., pip install simmate-vasp and then add to a config).

I've found that when mamba is initialized in place of conda, the conda environments become inaccessible.  So it then becomes easier to do a full replacement of mamba with conda on any system that it is installed.  Perhaps this isn't a switch that every user is able/willing to do. Therefore, your strategy of segmenting Simmate into apps seems reasonable.
On our WarWulf system, I'd be in favor or swapping out Conda entirely if everyone was OK with that.

Sounds good. This is something near the top of my priority list because it greatly affects how others contribute custom code. It would take me a couple days though, so it'll have to wait until later this month.
I'll still update the guides to account for mamba/pip installs.

From original discussion:
point users to the libmamba conda solver
https://www.anaconda.com/blog/a-faster-conda-for-a-growing-community


Enhancement to detect Windows phone and tablet.

I received a suggestion by email from @mrcycling. He wanted to be able to distinguish a Windows phone from a Windows 8 tablet.
For that, I did a few changes.
Hope you will like.
Thanks,

:tada: This PR is included in version 1.0.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


1.0.0 pub API

Not including #119 what's the best way to discuss and coordinate all the breaking changes/behaviors to get to 1.0.0? I think if we try to do it all in one go in one place, nobody is going to be able to follow or track all the discussions/bikeshedding. I'll do the work, but would like to be efficient about it.
Also, from a high level view, what's the priority?
Do we want things to be more like clojure or more like rust? Given it's EDN, and probably almost always going to be used with clojure(script), maybe it should be more like clojure?
Here's a couple examples of things I'm messing around with on https://github.com/Grinkers/edn-rs/tree/bikeshed
clojure
(boolean "foobar") => true
(int "123") => java.lang.ClassCastException: java.lang.String cannot be cast to java.lang.Character [at <repl>:2:1]

edn-rs
Edn::Str("foobar".to_string()).to_bool() -> None
Edn::Str("123".to_string()).to_int() -> Some(123)

Closing in favor of #139
I will try to keep objective things separate from subjective things, so subjective things can be discussed and changed more easily

Edn::Int(42).to_char() -> None

(char 42) -> \*

I think a lot of the methods here https://docs.rs/edn-rs/latest/edn_rs/edn/enum.Edn.html#implementations are confusing. I'm thinking we should remove it all or specify a spec (eg. try to match clojure.core). I really wish there was an easy way to iterate over all collections, like clojure. I think it can only be done with a new type.

https://github.com/edn-rs/edn-rs/issues/158