[Major issue] Item Stacking

If you kill 5 "minecraft:white_sheep" you will end up with 5-10 different stacks of 1 - 2 items in each.  This is probably with the same issue you have with the harvesters.  if you have 10 iron or come up, it every few will generate multiple stacks.  This is your mod, as I have had it by itself, and still will do it.
the temp fix i have for the harvesters was to use a hopper, instead of straight to a storage unit.
By the way, this is Fabric issue, not sure if it is on forge too.

I'm not sure if you're saying this is the same issue as #49, but I think it is different and it does sound like a real problem.
Just to clarify, #49 wasn't an issue, it just looked like one but is actually normal Minecraft stacking logic.
I'm not entirely sure I've correctly understood what you're reporting as I can interpret it in two different ways: The mob harvesters are outputting excessive numbers of items or actually killing entities by hand is giving excessive drops. Is it one of those?
I'll look at my code and see if I can figure it out myself too.

Wait, you said you fixed it by using a hopper. That makes me think that it isn't actually this mod as the harvesters don't have inventories, they only send items to adjacent blocks that do, meaning that the issue didn't happen when a different inventory was used. What did you use other than a vanilla hopper? Did you try a vanilla chest or barrel or something like that?

I did some testing and couldn't reproduce what I think I understand you described.
You might have meant something else though, so I'll wait to close this until you respond.

The issue is not just with the harvesters of the ores, it also affects the killing of some mobs in survival... if you do not use hoppers it will do weird stacking issues.  I know for a fact that the meta data, and nbt data is correct, because you can restack them afterwards and they will work fine.  The issue is that the stacking is coming from your mod, I have had to temporally remove it from the pack, as it was causing too much issues.  when i removed it, the issues with the pickup inventory went away... so i know for a fact it was your mod.

I just noticed this is still open. I'm pretty sure I managed to fix it in version 0.11.12c, so I'll close it now. Feel free to reopen if it turns out my fix didn't work. For anyone who's curious, the problem was that I calling ItemStack.getNbt instead of ItemStack.writeNbt, so it was trying to recreate the drops based on the NBT data that was saved to them instead of their full representation. Reading over that, it seems like it shouldn't have produced any drops at all, but I guess we'll see what happens.


Are the new Converge Apps Backwards Compatible with the Live SDK API?

We are currently using the Live SDK API in our integration with OneDrive. However, new customers do not have the ability to create Live SDK Applications, since this is being deprecated. We are working toward migrating to the new Graph API, however, my question is do the new Converged Apps (to be used with the Graph API) still work with the Live SDK API or can only new customers who only have access to Converged Apps use the Graph API?

As part of a repository clean up effort we are closing older issues. If this issue remains, please: open a new issue, reference this issue, and provide any additional details that may help in resolution. Thank you for your understanding as we work to improve our responsiveness.


Details about implementation

Hi,
Thanks for making the code publicly available. I had some questions about the implementation and it would be great if you could clarify them.

I had some trouble understanding when the classifier is updated? Does the algorithm involve first tuning the embedding function (assuming random weights of classifier) and then updating the classifier? Or since the embedding function updates depend on the weights of the classifier(because of the boundary adversarial example), does this happen iteratively (update the embedding function, then classifier, again the embedding function and so on)?

I was also facing issues running the code on Python3 with Pytorch 1.7.1. Training runs smoothly, but when running evaluation_finetune.py, I get "RuntimeError: derivative for floor_divide is not implemented" when backpropagating the loss. I had some trouble understanding which operation was causing this error.

Thanks.

Hi,
Thanks for checking out our code!

If you are asking about the method, it performs multiple iterations of obtaining the class score function h and updating the embedding function with adversarial samples. Here, the class score function h() is a function that outputs a score for each class given a sample i.e. argmax of h() over classes returns the predicted class. Since we target meta-learning methods, the class score function h() is determined differently for different tasks (e.g. in each task, MetaOptNet solves the SVM problem in the embedding space given labeled samples to determine h()). And, we don't fine-tune parameters of h(), as they will have to be computed based on the updated embedding function anyway.

I'm not completely sure given the information, but my guess is that maybe you added some code that uses torch.floor_divide (or //) to the fine-tuning module and the error occurs becuase that operation is not differentiable?
If you didn't make such modifications, one option is to check if it runs without errors in the environment with which we tested (Python 2.7 and PyTorch 1.1.0), first.

I hope this answers your questions, but if it doesn't, please feel free to leave another comment.


Get arm64 musl build working

This gets Aarch64 builds working.
Unfortunately I had to drop PCRE2 from config and switch kube-runtime over to rustls to get around compiler errors, so this is a bigger change than I'd hoped. Functionality changes should be minimal to zero though.

Maybe we could switch to something like https://github.com/fancy-regex/fancy-regex ?

Good shout, will give it a go this morning

Didn't work unfortunately, had to fork pcre2 to fix up the build


HIVE-28337: TestMetaStoreUtils fails for invalid timestamps

What changes were proposed in this pull request?

Timestamp represented as LocalDateTime is changed to ZonedDateTime to take time-zone into account while creating the timestamp to avoid creating invalid timestamps.
Why are the changes needed?

https://issues.apache.org/jira/browse/HIVE-28337
Does this PR introduce any user-facing change?

No
Is the change a dependency upgrade?

No
How was this patch tested?

mvn test -Dtest=TestMetaStoreUtils
Before the patch:
with Random(seed: 23) in line 65(default case)

with Random(seed: 24) in line 65

After the patch:

Nice catch~ This failed test was also found in https://github.com/apache/hive/pull/5004 and we can revert https://github.com/kgyrtkirk/hive-dev-box/pull/16 once this patch is merged.
@zabetak could you also take a look?

The 2 test cases mentioned in https://issues.apache.org/jira/browse/HIVE-28337 are failing for me locally in my machine with Java version 1.8.0_331. I tried running these test cases in https://github.com/apache/hive/pull/5004, but the DST related one was successful. I was investigating as to why this was happening, and now I get it seeing the previous comments that this is occurring due to JDK bug.

The intention of the test is to ensure that conversions from/to string do not alter the value no matter the timezone because the DATE/TIMESTAMP data types should be timezone agnostic.
Changing LocalDateTime to ZonedDateTime defeats the purpose of the tests and actually hides a bug that affects the MetaStoreUtils APIs.
I left a similar comment under the JIRA ticket.

Yes, I agree with you regarding the intention and purpose of the test. I am looking into the issue and would re-work this PR taking the MetaStoreUtils APIs into account.

I have updated the tests and the MetaStoreUtils APIs to always have Timestamp created in UTC timezone, since the timestamps during the daylight savings transition could not be represented in the local time zone.
However, there are 2 known issues for the timestamps mentioned below but it is the expected behaviour from Java's Timestamp:

Timestamps with year 0000 would be converted to year 0001.
Timestamps in the range [1582-10-05 00:00:00, 1582-10-14 23:59:59] (both inclusive) would have 10 days added due to the shift from Julian calendar to Gregorian calendar. (The next day after 1582-10-04 is 1582-10-15)

References:
[1] https://www.ibm.com/docs/en/db2/11.5?topic=dttmddtija-date-time-timestamp-values-that-can-cause-problems-in-jdbc-sqlj-applications#imjcc_r0053436__title__5
[2] https://strasbourg.eleusal.com/en/what-happened-between-5-and-14-october-1582/

g

I have updated the test to not hit the failing cases. Will raise a separate Jira for the rework that is needed around timestamp. @wecharyu @zabetak Please review. Thank you.

I understand that due to bugs the tests may fail in certain environments.
If the main motivation of this PR is to avoid the failures when this happens it seems more appropriate to add conditions for detecting skipping the specific test with appropriate bug reference.
If the intention is to fix the problems revealed by the tests then more work is needed since the proposed changes cannot land as they are.

The initial motivation was to fix the test failures, which later changed to solve the problem revealed in MetaStoreUtils. Upon your comments, I have reworked my PR which now solves the problem in MetaStoreUtils and accordingly modified TestMetaStoreUtils to validate the tests properly.
@zabetak @wecharyu Please review. Thank you.


[FIX] add ceagent to figures.json

addresses poldracklab/fmriprep#2033

dir should also be direction

dir should also be direction

Do you want to address that in this PR?


export HOOK_CHAIN when calling HOOK

A generic hook needs to know if HOOK_CHAIN is set to yes in order to
handle parameters/arguments accordingly.

This really shouldn't be necessary. Hook scripts should be coded in such a way that they can work without having to explicitly test for HOOK_CHAIN's value.
See https://github.com/bennettp123/dehydrated-email-notify-hook for one implementation of this.

@txr13, you are absolutely right, thank you and sorry for the noise.


Show only necessary fields

id should not be shown, because it helps in no way to the user to decide the label

fixed in https://github.com/dzieciou/tree-labeller/pull/30


Deprecated jsh and js-dsl

Added metadata about deprecation of js-dsl and jsh-dsl

Not sure we need this because the extension metadata already has the deprecated status:
https://github.com/apache/camel-quarkus/blob/main/extensions/jsh-dsl/runtime/src/main/resources/META-INF/quarkus-extension.yaml#L33
https://github.com/apache/camel-quarkus/blob/main/extensions/js-dsl/runtime/src/main/resources/META-INF/quarkus-extension.yaml#L34
It will have been determined automatically from the info in the Camel catalog. groovy-dsl was an exception because it did not have its deprecation status set on the Camel side.

@jamesnetherton makes sense, I'm closing this PR


Prompt to prompt editing

I am trying to understand to what extent your method replaces prompt-to-prompt. It seems to me that EDICT is a clever way to invert DDIM diffusion. If so, once we  get our latents, we should be able to apply prompt to prompt editing techniques. Instead, what you propose is just to run DDIM denoising conditioned on the target prompt to obtain the edited image.
It has been observed that (on generated images) prompt-to-prompt obtains more realistic and semantically meaningful edits. I guess the technique should be readily applicable to a latent obtained by EDICT inversion - and the code seems to support it - but the paper does not mention this combination, and in fact setting use_p2p=True gives me inferior results.
Do you have an explanation why using prompt-to-prompt is not beneficial?

Hi, thanks for the question!
This surprised us too. I love P2P and thought it'd boost our results. We don't have a full explanation for it (we haven't focused on this a ton but I've dug through the code to double-check that things are wired correctly), but typically what I see with EDICT+P2P is some combo of

The image remains overly faithful to the original

The image becomes unrealistic

Is a bit easier to explain imo. As we show in Figure 4 in the paper, the generative process can be delicate to perturbations; that's why we need averaging layers. It's fairly intuitive that putting another constraint on the process could mess things up.

The puzzling thing about 1. is that P2P clearly works in something like null-text inversion. So again it must be something EDICT-specific. One hypothesis is that the combination of the averaging layers with predictions operating on the counterpart sequence (e.g. x to y) dampens the amount of change that can be made when attention maps are constrained. It definitely makes the concept of self-attention more awkward.
It's possible that softening the locking of attention maps to re-weighting or being more selective in their application (or customizing them to EDICT) could work. This definitely is an area we want to keep thinking about so I'm curious if you have any further insight (experimental or otherwise). Happy to have follow-up discussions!

After some more experiments, I start finding the P2P interface too restrictive for general use, so I am not sure I would use that with EDICT even if it was available. Putting just any target prompt is so much more convenient.
Anyway, I don't have good explanations. I actually rewrote the P2P part to use the official Prompt to Prompt implementation, but I never got any good results with that

After some more experiments, I start finding the P2P interface too restrictive for general use, so I am not sure I would use that with EDICT even if it was available. Putting just any target prompt is so much more convenient.
Anyway, I don't have good explanations. I actually rewrote the P2P part to use the official Prompt to Prompt implementation, but I never got any good results with that

Could you kindly share the code that has been rewritten using the official Prompt to Prompt implementation? I am also interested in understanding why "use_p2p=false".  If it's not too much trouble, I would greatly appreciate it if you could contact me at<EMAIL_ADDRESS>Thank you very much!

I am sorry I can't, it is part of a proprietary codebase


Bug (NPE) creating trigger

DBFlow Version: 3.1.1
Issue Kind: Bug
Instant Run is off
Description:
We are creating a trigger to limit the amount of rows inserted in a table.
We have this order of code execution:
Inside our Application class:
FlowManager.init(new FlowConfig.Builder(sContext)
                    .addDatabaseConfig(createDatabaseConfig())
                    .build());

which calls
private static DatabaseConfig createDatabaseConfig() {
    return new DatabaseConfig.Builder(AppDatabase.class)
                .helperListener(createDatabaseHelperListener())
                .openHelper(new OurDbOpenHelperCreator())
                .build();
}

That is our basic setup for DBFlow. Afterwards we create the trigger:
private static void enableLimitTrigger() {
    CompletedTrigger<Table> trigger = Trigger.create(TABLE_LIMITATION_TRIGGER_NAME)
            .after().insert(Table.class)
            .begin(getTriggerLogicQuery(Table.class, Table.COLUMN_ID));
    trigger.enable();
}

where getTriggerLogicQuery is
private static StringQuery getTriggerLogicQuery(@NonNull final Class<? extends BaseModel> cls, @NonNull String idColumnName) {
    if (TextUtils.isEmpty(idColumnName)) {
        idColumnName = "ROWID";
    }
    String tableName = FlowManager.getTableName(cls);
    return new StringQuery<>(cls, "DELETE FROM " + tableName + " WHERE " + idColumnName + " NOT IN " +
                "(SELECT " + idColumnName + " FROM " + tableName + " ORDER BY " + idColumnName + " DESC LIMIT " + DB_ROW_LIMIT + ")");
}

That causes the following crash (from developer console, by a Xperia Z4 Tablet, we couldn't reproduce that on our devices):
Caused by: java.lang.NullPointerException: Attempt to invoke interface method 'void com.raizlabs.android.dbflow.sql.language.SQLCondition.appendConditionToQuery(com.raizlabs.android.dbflow.sql.QueryBuilder)' on a null object reference
at com.raizlabs.android.dbflow.sql.language.ConditionGroup.getQuery(ConditionGroup.java:209)
at com.raizlabs.android.dbflow.sql.language.Where.getQuery(Where.java:221)
at com.raizlabs.android.dbflow.sql.language.Where.query(Where.java:242)
at com.raizlabs.android.dbflow.sql.language.BaseQueriable.execute(BaseQueriable.java:96)
at com.raizlabs.android.dbflow.sql.migration.UpdateTableMigration.migrate(UpdateTableMigration.java:69)
at com.raizlabs.android.dbflow.structure.database.BaseDatabaseHelper.executeMigrations(BaseDatabaseHelper.java:158)
at com.raizlabs.android.dbflow.structure.database.BaseDatabaseHelper.onUpgrade(BaseDatabaseHelper.java:53)
at com.raizlabs.android.dbflow.structure.database.DatabaseHelperDelegate.onUpgrade(DatabaseHelperDelegate.java:78)
at com.raizlabs.android.dbflow.structure.database.FlowSQLiteOpenHelper.onUpgrade(FlowSQLiteOpenHelper.java:76)
at android.database.sqlite.SQLiteOpenHelper.getDatabaseLocked(SQLiteOpenHelper.java:256)
at android.database.sqlite.SQLiteOpenHelper.getWritableDatabase(SQLiteOpenHelper.java:163)
at com.raizlabs.android.dbflow.structure.database.FlowSQLiteOpenHelper.getDatabase(FlowSQLiteOpenHelper.java:54)
at com.raizlabs.android.dbflow.config.DatabaseDefinition.getWritableDatabase(DatabaseDefinition.java:222)
at com.raizlabs.android.dbflow.sql.trigger.CompletedTrigger.enable(CompletedTrigger.java:45)
at com.example.package.database.DatabaseHelper.enableCallLimitTrigger(DatabaseHelper.java:532)

We checked that ConditionGroup:209 is
208: SQLCondition condition = conditionsList.get(i);
209: condition.appendConditionToQuery(query);

We guess that conditionsList might contain null references but we fail to see why and how that can happen.
So we guess that this is somehow a bug on your side. If not so we appreciate any feedback or suggestion you can give us.

Might be that toString calculates the getQuery() method. Ive split that up and made them separate for 4.0.0-beta1, reopen when released if still happening. in develop.


Play_scraper.search(): returns empty list [] for any search query

Describe the bug
When we search the play store using play_scraper.search(query='<search query>'), it returns empty list for any search query.
To Reproduce
Follow the steps to reproduce issue:

import play_scraper
search_results = play_scraper.search(query='ProSe Privacy')
print(search_results)

Expected behavior

It should scrape the Google Play Store and return apps details that match the search query.

Screenshots

Desktop (please complete the following information):

OS: macOS 12.0.1
Python Version 3.7
play_scraper Version 0.6.0

I'm experiencing the same issue.

Me too :( search is broken


Possible False Positive?

🐛 Summary
What's wrong? Please be specific.
Run on Windows 10 system from downloaded folder location.
Folder name changed to v1.0.2
I noticed this on one of my work systems that I was running the script through.  Then ran on a personal non-connected system and received a similar response.
Steps to reproduce the behavior:
System Details: Windows 10, Installed VS Build Tools and Python v3.9.2

Download Chirp from GitHub
Change name of zip to "chirp v1.0.2.zip"
Extract Zip
Install via PowerShell with python install command
Run via powershell CLI as "python chirp.py
Wait for report

Expected behavior
YARA indicated file is from Chirp script directory, not base system itself.  I would have expected any reported files to be outside of this directory.
Any helpful log output or screenshots
{"CrowdStrike Sunspot": {"description": "\"Identifies Sunspot backdoor dropper utilizing unique strings in key encryption material, mutexes, and logging.\"\n", "confidence": 10, "matches": [{"meta": "{'copyright': '(c) 2021 CrowdStrike Inc.', 'description': 'Detects mutex names in SUNSPOT', 'version': '202101081448', 'last_modified': '2021-01-08', 'actor': 'StellarParticle', 'malware_family': 'SUNSPOT'}", "namespace": "CrowdStrike Sunspot", "rule": "CrowdStrike_SUNSPOT_02", "strings": "[(1197, '$mutex_01', b'{12d61a41-4b74-7610-a4d8-3028d2f56395}'), (1270, '$mutex_02', b'{56331e4d-76a3-0390-a7ee-567adf5836b7}')]", "tags": "['artifact', 'stellarparticle', 'sunspot']", "file": "C:\\Users\\UserX\\Downloads\\chirp v1.0.2\\indicators\\crowdstrike_sunspot.yaml"}]}}

Add any screenshots of the problem here.

Good evening! Yes that rule does appear to detect itself (it does in our dev environment too). We attempted to add the cwd to the ignore list but it appears that is a bug that needs fixing.

Thanks for all the work you are doing on this, it is much appreciated.  Below is a copy of the first time I saw this.
Possibly do a validation on the file name or hash and not work about the working directory.
On the first system I ran this on and was suspicious of it actually reported what I believe was the older version as it was in the recycle bin directory, when I dug into the directory it actually was a copy of the chirp directory for an old version that I removed.
{"CrowdStrike Sunspot": {"description": "\"Identifies Sunspot backdoor dropper utilizing unique strings in key encryption material, mutexes, and logging.\"\n", "confidence": 10, "matches": [{"meta": "{'copyright': '(c) 2021 CrowdStrike Inc.', 'description': 'Detects mutex names in SUNSPOT', 'version': '202101081448', 'last_modified': '2021-01-08', 'actor': 'StellarParticle', 'malware_family': 'SUNSPOT'}", "namespace": "CrowdStrike Sunspot", "rule": "CrowdStrike_SUNSPOT_02", "strings": "[(1197, '$mutex_01', b'{12d61a41-4b74-7610-a4d8-3028d2f56395}'), (1270, '$mutex_02', b'{56331e4d-76a3-0390-a7ee-567adf5836b7}')]", "tags": "['artifact', 'stellarparticle', 'sunspot']", "file": "C:\\$Recycle.Bin\\S-1-5-21-2077907170-1886209480-1695163583-7785\\$RUT019A\\indicators\\crowdstrike_sunspot.yaml"}

When #33 is merged, I will build the release for this fix.


Stop showing notification for a domain after user interacts with it

Once the user either clicks the notification to go to the documentation OR clicks the "close" button, then stop showing the notification for that domain.

This issue was created when the notification was shown every. single. time. a domain was loaded. That behavior was quite annoying.
Currently, the notification is shown once per domain per browser session. That is still not ideal and I want to make it more intelligent, but this issue can likely be closed in favor of something more current.


Hoonah maps

find good hoonah basemaps:

https://here.com/en
https://josm.openstreetmap.de/mapsview?entry=Stamen Terrain
http://leaflet-extras.github.io/leaflet-providers/preview/index.html
http://maps.stamen.com/#terrain/12/37.7706/-122.3782

Features and layers:.

[ ] gps
[ ] topo
[ ] tides
[ ] streets
[ ] sat
[ ] see survey

Fish finders
Commander compass
Topo
Tides app
Overgrown spruce trees
Inaccessible streams and roads


After synchro, refresh all

Preferably only if synchro gets some content, but why not always.
Refresh notebooks, tags, and note list and note content.

Fixed in V1.12


Tuya based Smart Power Monitoring Plug

I was able to flash successfully flash the Tuya based Smart Power Monitoring Plug with Tasmota and with various settings on the Config, I was able to control the Plug. But I can't find the correct power settings, so that the info on the main page gives correct voltage. Am from India and the Voltage is max 230v, whereas the page shows 263v. My Other Sonoff-POW shows correctly as 226v. Could someone help which one to select on GPIO4, GPIO5 and GPIO12?

I am guessing the exact model number, and a link to the place purchased would be helpful.

As this is a Sonoff-Tasmota configuration question, and not an issue with tuya-convert, you would be best served by asking there. Feel free to continue this conversation but I will close it as there is nothing for tuya-convert to do here.


add postinstall script in package.json

Signed-off-by: CCongWang<EMAIL_ADDRESS>Description

Add postinstall script in package.json, so that people don't need to manually install hooks

Issues Resolved
https://github.com/opensearch-project/opensearch-dashboards-functional-test/pull/201#discussion_r860252631
Testing

Delete node_modules
Run npm install, should see thathusky installruns and text husky - Git hooks installed

> husky install

husky - Git hooks installed

Commit code change, should see precommit hook runs

ubuntu@ip-172-31-55-176:~/github/opensearch-dashboards-functional-test$ git commit -s -m "add postinstall script in package.json"
yarn run v1.22.10
$ eslint . --ext .js
Done in 2.49s.

Check List

[X] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

TBH I tend to disable the hooks every time.
This seems like a forceful way to install the hook.
Not a big deal just not convenient for me 😅

i asked because i thought we didn't want to automatically install hooks for security reasons. But if that's not a concern (dashboards auto installs so probably not a concern), i think adding a --no-verify flag when hooks are not needed is much easier than remembering to install hooks every time..

TBH I tend to disable the hooks every time. This seems like a forceful way to install the hook. Not a big deal just not convenient for me 😅

Hi @peterzhuamazon , thanks for your feedback! yeah I understand that the pre-commit hook might introduce some inconvenience when contributors are doing some experiments (like writing some PoC), one way to disable it when needed is to comment out the yarn lint in https://github.com/opensearch-project/opensearch-dashboards-functional-test/blob/main/.husky/pre-commit


DISCUSS: Upcoming tracing 0.2 integration

Motivation
Hello, the entire tracing community is currently focusing on version 0.2, which will be released in the future. As a separate repository outside of tracing, we need to discuss how we can integrate with tracing 0.2.
The context involves tracing-opentelemetry, which must integrate simultaneously with both tracing and opentelemetry. Given that opentelemetry frequently introduces breaking changes with each new minor release, we need to update our version accordingly.
Proposal
So I propose to release two new crates that one targets 0.1 and the other one targets 0.2.

tracing-0-1-opentelemetry
tracing-0-2-opentelemetry

tracing-opentelemetry will become a wrapper of those two crates and users can switch tracing version via enabling features. Enable different feature will lead to complie errors.
Alternatives
Add new crate tracing-0-1-opentelemetry
We can only add new crate tracing-0-1-opentelemetry, and keep tracing-opentelemetry tracking with latest tracing version.
Add new crate tracing-0-2-opentelemetry
We can only add new crate tracing-0-2-opentelemetry, and keep tracing-opentelemetry tracking with 0.1 version.
Drop support for tracing 0.1
We can upgrade to tracing 0.2 directly.
This option may seem unfriendly, but considering the current maintenance and how this crate is used, I personally believe it should work.
Use major version instead
Release tracing-opentelemetry with:

1.x.y for tracing 0.1
2.x.y for tracing 0.2

Discussion
Welcome for realtime discussion at tokio discord https://discord.com/channels/500028886025895936/974721015999516672/1243486117660065833

Where is the tracing 0.2 discussion happening? I'm not a fan of the separate crate approach... I think I would be inclined to maybe jump tracing 0.2 compatible tracing-opentelemetry versions to 0.100.x or something like that. It looks like the pace of opentelemetry breaking releases might also slow down soon so maybe there's a simpler alternative?
https://github.com/open-telemetry/opentelemetry-rust/issues/1678

I also don't think that tracing release of 0.2 is happening any time soon (there are a few non-trivial changes to design and implement in the pinned issues) and the maintainers currently don't seem to have time to drive that forward.
On the other hand opentelemetry-rust is planning a 1.0 release fairly soon and then they would have stronger API stability guarantees.
So I think this will not be an issue in the end.
If it were, I don't think you would need three crates, you can depend on two semver-incompatible versions from tracing-opentelemetry so I don't see how the additional crates would help.

Hello, the entire tracing community is currently focusing on version 0.2, which will be released in the future. As a separate repository outside of tracing, we need to discuss how we can integrate with tracing 0.2.

We drew up recent plans (in the last several months...) to move tracing to 0.2, but haven't had the time to execute on it.


test_cmd.go test failure

Describe the bug
est_cmd.go test failed
To Reproduce
$go test ./...
--- FAIL: TestWalletImport (5.06s)
test_cmd.go:250: (stderr) INFO [10-18|14:42:40.025] Maximum peer count                       ETH=50 LES=0 total=50
test_cmd.go:250: (stderr) INFO [10-18|14:42:40.025] Smartcard socket not found, disabling    err="stat /run/pcscd/pcscd.comm: no such file or directory"
test_cmd.go:231: killing the child process (timeout)
test_cmd.go:112: Not enough output, got until ◊:
---------------- (stdout text)
!! Unsupported terminal, password will be echoed.
Passphrase:
    ---------------- (expected text)
    !! Unsupported terminal, password will be echoed.
    Passphrase:
    ◊Address: {d4584b5f6229b7be90727b0fc8c6b91bb427821f}

--- FAIL: TestFakeNetFlag (6.05s)
test_cmd.go:250: (stderr) INFO [10-18|14:42:56.917] Maximum peer count                       ETH=0 LES=0 total=0
test_cmd.go:250: (stderr) INFO [10-18|14:42:56.917] Smartcard socket not found, disabling    err="stat /run/pcscd/pcscd.comm: no such file or directory"
test_cmd.go:231: killing the child process (timeout)
test_cmd.go:112: Not enough output, got until ◊:
---------------- (stdout text)
    ---------------- (expected text)
    ◊Welcome to the Geth JavaScript console!

    instance: go-lachesis/v1.9.1-stable/linux-amd64/go1.12.1
    coinbase: 0xf88d5892faf084dcf4143566d9c9b3f047c153ca
    at block: 0 (Mon, 05 Aug 2019 20:13:20 AEST)
     datadir: /tmp/lachesis-test681905840
     modules: admin:1.0 debug:1.0 eth:1.0 personal:1.0 rpc:1.0 txpool:1.0 web3:1.0

Expected behavior
No failed test

The most of console-related tests aren't deterministic, and rarely fail on slow or loaded servers. We'll look into them in more detail.

outdated


Anyway to set the attr of operation after added to the gragh in C API?

Click to expand!
Issue Type
Support
Have you reproduced the bug with TF nightly?
No
Source
binary
Tensorflow Version
tf2.11
Custom Code
No
OS Platform and Distribution
Windows and Linux
Current Behaviour?
Hello, I'm a developer of Tensorflow.NET, which is a tensorflow binding for dotnet. When I implemented some feature, I could not find a C API to add attributes to an operation that has already been created and added to the graph. However, there is indeed such C API for python. It's located here.
Among exported C APIs of libtensorflow, only the following API was found:
TF_CAPI_EXPORT extern void TF_SetAttrValueProto(TF_OperationDescription* desc,
                                                const char* attr_name,
                                                const void* proto,
                                                size_t proto_len,
                                                TF_Status* status);

However, TF_OperationDescription is released after adding the operation to graph by calling TF_FinishOperation. Therefore I can't use the API to add attributes.
Is there any other way for us to add attributes for operations which have been added to graph?
Standalone code to reproduce the issue
The code is wrote in csharp. I'll give a minimal example if needed.

Relevant log output
No response

Also, is there any corresponding C API for GetHandleShapeAndType and SetHandleShapeAndType in python_api.h?


Operation list

On the deploy page, there is no way to know which operations are possible to send as sources or targets. It would be nice to display the available operations.
This can't be down for now as the API of tdp-server don't provide this information yet (https://github.com/TOSIT-IO/tdp-server/issues/61).
Edit: the endpoint is now available.

This could be done via:

a sidebar (as for GraphQL playground)
a drag and drop list
autocompletion


Adding high-level midi datatypes

I spent a day writing enums and functions to handle the midi data, and then realised that they could be shared with everyone.
Do they work?

Good idea, a lot of VSTs deal with MIDI but:
I think it would make more sense to have MIDI types in a separate crate, because it would be useful outside of VST development, too. And it would 'separate the concerns' of VST and MIDI which would be more orthogonal / elegant.
Also, maybe you'd want to use the MIDI Status type from the rimd crate and re-export that (I use that in my own VSTs).
Btw, I'd also use enum_from_primitive for your other enums.
And I'd use STATUS_MASK and CHANNEL_MASK from rimd (I think they should be made public in rimd).
Btw, what is the purpose of your Data type? It seems like you intend it to store the info of a general MIDI message in a higher abstracted form but you are only storing the status information, not the channel and actual data (only for SysEx msgs). And what is the purpose of this Data::Voice(i, b[1]), you're ignoring b[2] and the channel. I think what you intended (and what would make sense) is to have a datatype that represents a MIDI message on a higher level. But then it should also store channel info and b[2].
And if b[0] ^ 0b11111000 should probably be if b[0] & 0b11111000. And I would give all masks names (constants). Also I would just return Options instead of Result<Self, bool>.
But that's just my two cents..
Btw, I was actually considering using such a higher-level type and rewriting rimd to use that type instead of the low-level Vec<u8> for all messages. Or at least not using a Vec for short messages (which are all except sysex messages and are the majority in a normal MIDI file). This would speed up parsing MIDI files because it wouldn't have to allocate a Vec for each small message during reading.
So it could be enum MidiMessage { Short(ShortMessage), Long(Vec<u8>) } struct ShortMessage(u8, u8, u8); for rimd to reduce allocations (MidiMessage would be able to be constructed from a &[u8]) and then a new crate would provide a more discriminating higher level message type that can be parsed from a MidiMessage.

Thanks for the detailed response!
Putting the midi handling in a separate crate sounds like a much better idea than dumping it in the main library.
The Data type is supposed to be a type for a MIDI message, but as you have correctly pointed out, I may have messed up some of the cases (a key was pressed, but we're not going to tell you which one =])
The reason why some return a Result<_, bool> is because I wanted the from_bytes function to do all of the checking. However, if I returned an option. I would not be able to distinguish between the midi message being the wrong type, and the midi message being malformed. In the former case, I want to try the next type, and in the latter, I want to return a None. There are ways to avoid this, but the ones I can see involve either a) doing the check twice b) not doing the check in the from_bytes function.
I had not found the rimd crate when I started writing this (I should have spent longer looking). On first glance, it looks significantly more detailed (and better written) than the module I wrote. I will move my VST to using that crate.


Bump Retrofit to 2.6 as to support coroutines

Retrofit released support for coroutines which was previously only available through custom adapters, could we do a bump and release for this ?

yes sur emake a aPR


Soversion for shared library

Until recently (I cannot pinpoint exact commit), molmodel used to build a shared library with a soversion. This was the piece of code which did so, but now seem to be gone:
    SET_TARGET_PROPERTIES(${SHARED_TARGET} PROPERTIES
        PROJECT_LABEL "Library - ${SHARED_TARGET}"
        SOVERSION "${MOLMODEL_MAJOR_VERSION}.${MOLMODEL_MINOR_VERSION}")

Soversions are important for Debian packaging, as shared libraries without soversions are not exposed publicly. This is not a problem for Debian packaging per se, as private shared libraries or static libraries are also OK. What is more of a problem, is consistency, as switching between public shared, private shared and static is problematic. Thus my question here: is this loss of soversion intended? Maintaining a soversion requires some level of API/ABI stability, thus there is additional burden in it.

Fixed in https://github.com/samuelflores/molmodel/commit/8bed3539deda854b285eb7ac208613fe7b2401ae

Thanks @MadCatX for prompt fix - this should do. Closing.


x/pkgsite: stdlib packages do not load (permission denied)

What did you do?
Navigate to https://pkg.go.dev/bufio#ScanLines and try to follow it to the source.
What did you expect to see?
The source.
What did you see instead?
The hyperlink leads to https://cs.opensource.google/go/go/+/go1.17.2:src/bufio/scan.go;l=290 which shows "Permission denied."

You might be onto something with extensions as it seems to open okay in Edge. After selectively disabling extensions, I narrowed it down to the DuckDuckGo Privacy Essentials extension.
Every other site (Google sites included) work absolutely fine?

Seems like a problem with the extension and not the site
Dup of #47213


[DO NOT MERGE] staging bridge SDK and API

Description
Temp branch for staging bridge API deployment.
5dac734d11aed687cc9eb3540ffaba9c20576df8: synapse-interface preview link

Closing: to be replaced by #3450


Add dropdown to climate control dashboard card for most used maintainance operations for eTRV

Release 2023.9 of Home Assistant introduced option features that can be added to dashboard cards.  This change would make use of a drop-down to add some of the maintenance commands for the eTRV as an optional entry.
Something along these lines:
features:
  - type: climate-preset-modes
    style: dropdown
    preset_modes:
      - "Cancel Command"
      - "Request Diagnostics"
      - "Request Voltage"
      - "Exercise Valve"
      - "Identify"
      - "Low Power Mode ON"
      - "Low Power Mode OFF"

Implemented in
https://github.com/Achronite/mqtt-energenie-ener314rt/pull/98


Feature Request:  sub-path support for volume mount

In K8S volume, we can use The volumeMounts.subPath property to specify a sub-path inside the referenced volume instead of its root:
https://kubernetes.io/docs/concepts/storage/volumes/#using-subpath
Volume mount is container apps doesn't support subPath, we have to store the data to different file share, which is difficult to maintain.
Describe the solution you'd like.
Volume mount is container apps supports subPath,

Hello,
I'd like to override a specific config file in my container with another config file stored in a Storage Account, with FileShare.
With ACA and volumeMounts i'm able to do it with a whole folder, but unfortunately it also overrides other files in this folder.
One way to do it with k8s was by using subpath, that's why I'm landing here.
Do you have news on this subject ?
Or, do you know another way to do it ?
Thanks,

Hi @yilims,
We are facing the following issue https://learn.microsoft.com/en-us/troubleshoot/azure/azure-kubernetes/could-not-change-permissions-azure-files when using file share and container apps.
Adding the sub-path feature could be useful to be able to implement the workaround.
Any deadline? Any preview feature?

This is supported now but not yet officially documented. Adding it to the documentation backlog.

@simonjj is subPathExpr (https://kubernetes.io/docs/concepts/storage/volumes/#using-subpath-expanded-environment) is also supported?


add params property like RadixRouter.lookup to RouteMatcher.matchAll

Describe the feature
I think this is more consistent with RadixRouter.lookup as I myself was hoping for a params property. The use-case comes from the implemetation of URL's wildcard pattern where there can be multiple urls have different path parameters.
Additional information

[ ] Would you be willing to help implement this feature?

Hi. Can you please elaborate more about expected new feature how API looks like?

@pi0 Hello.
If there are two routing rules:

/hello/:name
/hello/:mine

The result matcher.matchAll('/hello/world') should return (assuming no other payload) is:
[
  { params: { name: 'world' } },
  { params: { mine: 'world' } }
]

But the current version of matchAll does not carry the params field. Therefore, for matched dynamic routes, I cannot know what the dynamic parameters are.
My current requirement is to match multiple dynamic routes and have them handled by multiple handlers at the same time. I would really appreciate it if this issue could be resolved.

From rou3 0.4x (#118) it is possible:
import { createRouter, addRoute, findRoute } from "rou3";

const router = createRouter();
addRoute(router, "", "/hello/:name", {});
addRoute(router, "", "/hello/:min", {});

/**
[
  { data: {}, params: [Object: null prototype] { name: 'world' } },
  { data: {}, params: [Object: null prototype] { min: 'world' } }
]
 */
console.log(findRoute(router, "GET", "/hello/world"));


Small follow up to 8ee3d45

rename containsIndexers to doNotCache in ExpressionHelper

FYI only. Will commit immediately.

4bddb5f


User supplied vs auto-created

It is unclear what is end-user supplied vs auto-created

User supplied: https://github.com/redhat-developer-demos/openshift-hybridizer/blob/master/env/extravars.example#L67
User supplied: https://github.com/redhat-developer-demos/openshift-hybridizer/blob/master/env/extravars.example#L68
unclear - https://github.com/redhat-developer-demos/openshift-hybridizer/blob/master/env/extravars.example#L73
unclear - https://github.com/redhat-developer-demos/openshift-hybridizer/blob/master/env/extravars.example#L75
unclear - https://github.com/redhat-developer-demos/openshift-hybridizer/blob/master/env/extravars.example#L83

Everything that is in the middle of "< a value >" is user supplied. Everything that has a value is a auto-created. This is also reflected in the documentation of cloud vars.

However we can enhance the project to clarify.

Any ideas how we can clarify this information?


transp: support TCP idle timeout option

The idle timeout of the TCP connection can be changed
by the user if needed.

can you please tell me what is the use-case for this patch ?

We found in our test setup, that when baresip is offline (in this scenario for 4 minutes), it lasts about ~10mins 30secs until SIP registration is performed again. This patch makes it possible to reduce/set the TCP idle timeout which we found is the reason for the long registration delay.
This PR is related to baresip PR #1092. They are still in progress and travis failures will be fixed soon.

it seems like a very large and intrusive change, to change a TCP value.
would it be possible to make a compile-time value instead, that you can override when compiling ?

it seems like a very large and intrusive change, to change a TCP value.
would it be possible to make a compile-time value instead, that you can override when compiling ?

Deciding the idle timeout during compile time is a big restriction. The default value still will be the 900 seconds. So if we use a setter for tls instead of adding a parameter to tls_alloc() nothing would change for any component that uses tls_alloc() except for ua.c, which is exactly would we intend. And if in baresip the config setting is missing, nothing changes.
So, we will proceed to improve this PR. For now this should be set to draft.

is it possible to make a simpler solution, just modify the tcp modules.
add a setter function, e.g. tcp_set_timeout(), and use default values.

Ok, we try this. As soon as Naegolus is back.

ok, please create a new PR when he is back


fix(tap): handle unset git config vars in taps

[x] Have you followed the guidelines in our Contributing document?
[x] Have you checked to ensure there aren't other open Pull Requests for the same change?
[x] Have you added an explanation of what your changes do and why you'd like us to include them?
[ ] Have you written new tests for your changes? Here's an example.

[x] Have you successfully run brew typecheck with your changes locally?
[x] Have you successfully run brew tests with your changes locally?

cc/ @reitermarkus
Commits (oldest to newest)
3479d70296 fix(tap): handle unset git config vars in taps
I'm not sure how/when this happened, but I have this in the
.git/config for some of my taps.
[homebrew]
	private =

And this breaks brew upgrade and brew tap-info <tap> since
https://github.com/Homebrew/brew/pull/16811.

I cannot reproduce by adding
[homebrew]
	private =

to a tap and running brew tap-info on that tap.
@gibfahn can you try to get a more minimal, step-by-step reproduction? Would rather not merge this as-is.

The only place where a nil could come from seems to be GitHub.private_repo?. Can you check
brew ruby -e 'p GitHub.private_repo?("<your/homebrew-tap>")'

Do you have HOMEBREW_NO_GITHUB_API set?

Oh yes, I guess that's the difference? Was trying to work out why I could reproduce it.


chore(master): release 0.5.0

:robot: I have created a release beep boop
0.5.0 (2023-10-15)
⚠ BREAKING CHANGES

arbitrary dimensional points (#23)
rename feature for serde (#19)

Features

add 3d points to serde (b03f1d3)
arbitrary dimensional points (#23) (2aee19d)

Bug Fixes

docs: update for 3d deserialization (#26) (6c8c464)
specialized math for <= 4d points (#24) (b5a5533)

Code Refactoring

rename feature for serde (#19) (ff12e9f)

This PR was generated with Release Please. See documentation.

:robot: Release is at https://github.com/kade-robertson/simplify-polyline/releases/tag/v0.5.0 :sunflower:


OnClient error not called after Connection

I was trying to show a message "Impossible to access the server" when the server was not running, and I was not able to get an OnClientError trigger. I've solved my problem this way :
Step to reproduce:

Add a SimpleWebTransport as you main transport
Try to connect to a server not running

You will be disconnected well, but the "OnClientError" event will not be triggered.
That's working if you invert the 2 lines in SimpleWebTransport
client.onError += (Exception e) =>
            {
                ClientDisconnect();
                OnClientError.Invoke(e);
            };

Become
client.onError += (Exception e) =>
            {
                OnClientError.Invoke(e);
                ClientDisconnect();
            };

Nice find, I've committed the fix

Hi James, FYI, I have not created a PR myself because I did not have the time to test if it was working with a WebSocketClientWebGl, I have only tested it with WebSocketClientStandalone.
As the fix is on SimpleWebTransport, I exept this to work, but some test can't harm :)
Cheers


support for tf-2.0

https://github.com/mlperf/inference/issues/529

LGTM

this change should work with tf-1.x (x>12) and tf-2.0


How to change column formats when connecting to csv files

Hi there,
I’ve connected some csv files to DBeaver and all the columns are set to string formats (abc). I’ve been trying to figure out how to change some columns format to datetime or numeric formats for example but I couldn’t find. I’ve tried to find online tutorial and I couldn’t find.
Thanks for your help in advance

You cannot do it during CSV import. But it is possible to set when a table is exported from a database to another database table (Step Tables mapping)

Press Columns btn for it.
Please reopen the ticket if you have additional questions.


Symphony never sets the "secure" flag on cookies

Due to a typo in class.cookie.php, Symphony never sets the "secure" flag on cookies/sessions. (It is supposed to do this in SSL environments.)
Here are the lines in question:
if (defined(__SECURE__)) {
    $this->_secure = __SECURE__;
}

The fix is to add the missing (single) quotes:
if (defined('__SECURE__')) {
    $this->_secure = __SECURE__;
}

I can provide a pull request. To which branch should I send it?

Doh, that would of been me :(
2.7.x I believe, @nitriques will probably backport it to 2.6.x too.
Thanks @michael-e!

Thanks, @brendo. Will do.

BTW, I noticed that fixing Symphony's behaviour as above has one negative side effect. It won't affect many users, however I think that it should be documented here.
If (and only if):

your website is running in "mixed mode", i.e. parts are SSL-encrypted, other parts are running over HTTP, and
you are writing to the session (using an extension) on unencrypted pages of the website

a secure cookie/session (used for Symphony login, for example) will be destroyed as soon as the second step happens.
This is probably due to the fact that the browser does not re-use a secure cookie on unencrypted pages of your site. As soon as a (non-secure) cookie/session is needed, a new session will be generated.
Why should you write to the session on unencrypted pages? Well, I do this in order to carry GET parameters in the session, especially when developing in the production ("live") system; these parameters are then added to the param pool and used in the templating layer in order to switch between versions. :-)
As I said, it's not a big deal... (Ideally everything should be SSL anyway.) Just documenting it.

@michael-e Thanks for the edge case description. That's recurring problem on a lot of platform and I would not try to deal with it.

I completely agree. These edge cases require special treatment (and knowledge) anyway. I just wanted to document it here, just in case someone will run into similar issues.

This was backported to 2.6.8 as well :)

Thanks a lot, @brendo!

Thanks @brendo !


[WIP] [Col] add autoGrow prop for take maximum width/height available

Rebased on to branch from #65 from @davelab

Hi,
The aim of this PR is to have the possibility to change the <Col /> component growth behaviour with a bool prop autoGrow. this enable <Col /> to take max width/height available, depending of <Row /> flex-direction.

Also add the possibility to change the display property of <Col /> from block to flex useful for column layout
Add also a storybook for samples
Update README.md

Hope you find useful and correct.

@davelab can you just do a checkover this PR and make sure you're all good with the changes I have done?
I have tweaked some of the Readme, package.json scripts and just some of the naming of the AutoGrow story file.
I'm a little concern about the double up we now have with the flex prop and the auto value inside the breakpoints, we can see how it goes and maybe revaluate after trying with real examples.
Huge thanks again for spending the time to submit this!

@davelab Thanks. Will be releasing as of version v0.7.0. See https://github.com/aaronvanston/react-flexa/releases/tag/v0.7.0


Create the database tree block

This is to create something like a tree to display the mongo objects in the block. I am thinking in showing some fields like the collections, views, users, etc.
Preview I think it would be OK:
> admin
  > Views
  > Collections
  > Users
> local
  > Views
  > Collections
  > Users
> config
  > Views
  > Collections
  > Users

Of course it will depends on a lot of other things to make it (#5), like create methods to query each of them, create the UI of each db, etc. This issue is just to keep track of it.
This is just an idea, please, let's plan on how it would be good to this tree looks like, maybe we could add another fields to make it better.

The way I've decided to make this was through a hashmap (actually, a linked one). Each database is a hashmap of a String to a Database object. The string is the database name and the Database object is a struct containing all of it's stuff.
It had to be a linked hashmap to preserve the order of the insert operations.
Code of the explanation above is in 04a912a53525e51e6d2a08afd5dcc104fb20fbd0


The library cannot handle "3-1"?

My code:
use cel_interpreter::Program;

fn main() {
    Program::compile("3-1").unwrap();
}

I expect this code to run without any issue, but the actual result:
$ cargo run
   Compiling pubsub v0.1.0 (/home/user/test)
    Finished `dev` profile [unoptimized + debuginfo] target(s) in 1.48s
     Running `target/debug/test`
thread 'main' panicked at src/main.rs:5:29:
called `Result::unwrap()` on an `Err` value: ParseError { msg: "unrecognized token: '-1'", expected: ["\"!=\"", "\"%\"", "\"&&\"", "\"*\"", "\"+\"", "\"-\"", "\".\"", "\"/\"", "\"<\"", "\"<=\"", "\"==\"", "\">\"", "\">=\"", "\"?\"", "\"[\"", "\"in\"", "\"{\"", "\"||\""], span: Span { start: Some(Location { line: 0, column: 1, absolute: 1 }), end: Some(Location { line: 0, column: 3, absolute: 3 }) } }
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

Yes, it might be that the CEL parser is not handling the '-' sign properly.


Mixing datetime.now() and datetime.utcnow() may cause surprising comparisons

datetime.now() and datetime.utcnow() both return naive (non-timezone-aware) datetime instances. Comparing instances from the two can produce meaningless results unless the server happens to be running in UTC.
referencing the Python docs:

Warning Because naive datetime objects are treated by many datetime methods as local times, it is preferred to use aware datetimes to represent times in UTC. As such, the recommended way to create an object representing the current time in UTC is by calling datetime.now(timezone.utc).

The NewsBlur code seems to use both functions, with no obvious pattern:

hits for datetime.datetime.now()
hits for datetime.datetime.utcnow()

Of particular concern, we can see calls to both in the same module, in particular apps/reader/models.py.
I didn't see any calls to datetime.now() with a tzinfo argument.

(saw this while auditing code to try to debug why NewsBlur is marking my old feeds unread.)

Great find, yeah this is technical debt we need to fix. What do you propose we do to ensure compatibility?

I believe converting all the utcnow() to now() should work with no obvious repercussions, but if that's not the case then let me know. And feel free to write a PR to do that, I'd be happy to accept it.

There's not really one "true" way of resolving this... it depends on things like where/how times are stored and which time values are compared with each other.
You want to make sure you never change the UTC-ness of a time on only one side of a comparison.
For times that are never persisted outside the server process, and which are only ever compared to other times that live within the server process' lifetime, switching to utcnow() everywhere would be fine if it's done all at once.
For times that are persisted, changing from now() to utcnow() is going to result in a perceived timezone-offset-sized jump (forwards or backwards) in the time series. That will affect things like sorting and threshold calculations.
Assuming the target invariant is "any datetime in program memory is UTC", one rollout strategy would be:

trace through and figure out, today, which times are persisted as local times and which are persisted as UTC
add code on the read path to parse and apply an optional tz offset. Where not found, assume the offset is what you learned from (1).
(This won't help if a server changes timezones, but there's not much you can do about that anyway.)
move over to utcnow() everywhere and change the write path to include the +0 UTC offset.

Another strategy might involve a rewrite of the datastore to augment values with tzoffsets, but that's more difficult to sequence.


Error creating cluster component when using the legacy Docker Swarm

Description

Hello, when I'm using Docker 17.03 and I want connect it to a swarm using the old method - using the swarm image and a consul KV store. I have set the options --cluster-store and --cluster-advertise` to my docker daemon and that way I get the error:
Error creating cluster component: --cluster-store and --cluster-advertise daemon configurations are incompatible with swarm mode
This didn't happen before, when I was using 1.12. I guess swarm mode in the error is talking about the new Docker Engine swarm mode, however I'm not using that at all.
Steps to reproduce the issue:

Install Docker Engine 17.03
Add cluster-store and cluster-advertise options with appropriate values to the docker daemon.
Try to create a swarm container to connect to an existing swarm using the join --addr options

Describe the results you received:
A message in the systemd log:
level=fatal msg="Error creating cluster component: --cluster-store and --cluster-advertise daemon configurations are incompatible with swarm mode"
Describe the results you expected:
Everything to be working
Additional information you deem important (e.g. issue happens only occasionally):
I am installing and configuring Docker using Salt and I'm also spawning containers using Salt and docker-py.
Output of docker version:
Client:
 Version:      17.03.0-ce
 API version:  1.26
 Go version:   go1.7.5
 Git commit:   60ccb22
 Built:        Thu Feb 23 11:02:43 2017
 OS/Arch:      linux/amd64

Output of docker info:
Cannot connect to the Docker daemon at unix:///var/run/docker.sock. Is the docker daemon running?

Additional environment details (AWS, VirtualBox, physical, etc.):

Can you try starting the daemon without those options set? Even though you don't use swarm mode, it looks like it's enabled, so you'd have to docker swarm leave --force to disable swarm mode
Alternatively (and assuming there's nothing important running on that machine currently), you can remove the /var/lib/docker/swarm directory, which contains the swarm state, and dara

Yes, that worked...so even if I purge and reinstall the docker-engine package the swarm initiated stays active, since its config details are in a different place? I did remember that I init-ed a swarm before, just to try it. Thank you very much for the help!

Correct; the /var/lib/docker directory is not removed when uninstalling https://docs.docker.com/engine/installation/linux/ubuntu/#uninstall-docker
Good to hear it's resolved! Let me close this issue


(#204) applicant changes

#204
Changes include:

Migration for deleting old columns hr_applicant_id from tables. After changes implemented in #210. These columns were needed to migrate data only and are no longer required.
Check for an applicant if it already exists.
Modified the workflow around applicant and application generation.
Modified the workflow around application round actions.
In case an applicant applies for multiple jobs, the first job is marked as in-progress. All the following will be marked as on-hold.
In case an applicant applies for multiple jobs, the reject action will open up a modal. That modal will have options either to reject for this application but refer for another appliction or to reject for all applications at once.

Checked this PR :

[ ] For duplication.
[ ] For performance.
[ ] Usage of recursive methods, loops and algorithms.
[ ] For readability and understanding.
[ ] For functions with multiple responsibilities.
[ ] For scope of refactoring.
[ ] For coupling
[ ] For alternative approaches to the implementation.
[ ] For how the change impacts other parts of the system.
[ ] For validations. client side and server side validations are present.


Light mqtt json asnync tested

Description:
To migrate restore_state (PR #17270) to use the storage helper instead of history, we need to migrate all tests for components/platforms that use restore state to async or else the pytest fixtures won't work.
Checklist:

[x] The code change is tested and works locally.
[x] Local tests pass with tox. Your PR cannot be merged unless tests pass

If the code does not interact with devices:

[x] Tests have been added to verify that the new code works.

Well, its great to move it to async anyway ;)
Ill sort this one now!


WebApp file changes / adds / deletes

Unable to locate logs for file changes / uploads / deletes Azure WebApps (web, functions, etc.).  Needed for PCI-DSS compliance; FIM only works on VMs.
I would assume that file changes and access to files would be logged in one or more of these areas:

Security Center
Activity Logs
Application Insights

@IsaacRoitman please provide us with the link to the documentation you are following so we can better assist

@MicahMcKittrick-MSFT
https://docs.microsoft.com/en-us/azure/security-center/security-center-file-integrity-monitoring

Thanks for that. I have assigned it to an engineer to investigate further.

Hi @IsaacRoitman , you should be able to find this in the audit logs. https://docs.microsoft.com/en-us/azure/active-directory/reports-monitoring/concept-audit-logs
"With application-based audit reports, you can get answers to questions such as:
What applications have been added or updated?
What applications have been removed?"

Hope this helps!
We will proceed to close this thread but if you have further questions feel free to tag me in the comments or open a thread on MSDN.

@Marilee-Turscak-MSFT this issue is not related to AAD audit logs or app registration at all.
Please see original issue regarding file changes on Web App services.

@MicahMcKittrick-MSFT Can you please reopen / escalate and see the comments above?  This is not resolved.
Thanks!

What specific file changes are you looking for? The audit logs will show changes to the web apps made by particular users or done to particular web apps.

https://docs.microsoft.com/en-us/azure/security/fundamentals/log-audit#types-of-logs-in-azure
This doc also covers how to download deployment logs. https://docs.microsoft.com/en-us/azure/app-service/troubleshoot-diagnostic-logs

Since this is a product question and not a doc issue, the right place to ask this is on MSDN. https://social.msdn.microsoft.com/Forums/en-US/home?forum=windowsazurewebsitespreview


the generated video quality different with the samples shown in gallery

the generated video quality different with the samples shown in gallery. Could your share the relevant inference parameters for the gallery sample results?
https://github.com/hpcaitech/Open-Sora/assets/14292495/3b48b0e5-f175-4de2-98f3-04b96414eb65

Could @Sze-qq have a look on this?

Sure. Here are the parameters we used to generate the video:
Resolution: 720p
Sampling Steps: 100
Aesthetic Score: 7
Refine Prompt with GPT-4: Unchecked
Other settings: Default
Prompt:
A Japanese tram glides through the snowy streets of a city, its sleek design cutting through the falling snowflakes with grace. The tram's illuminated windows cast a warm glow onto the snowy surroundings, creating a cozy atmosphere inside. Snowflakes dance in the air, swirling around the tram as it moves along its tracks. Outside, the city is blanketed in a layer of snow, transforming familiar streets into a winter wonderland. Cherry blossom trees, now bare, stand quietly along the tram tracks, their branches dusted with snow. People hurry along the sidewalks, bundled up against the cold, while the tram's bell rings softly, announcing its arrival at each stop.

Here is my inference configuration. I did the modification according to what you said.
[2024-06-21 02:58:22] Inference configuration:
{'aes': 7.0,
'align': 5,
'aspect_ratio': '9:16',
'batch_size': 1,
'condition_frame_length': 5,
'config': 'configs/opensora-v1-2/inference/sample.py',
'dtype': 'bf16',
'flow': None,
'fps': 24,
'frame_interval': 1,
'model': {'enable_flash_attn': True,
'enable_layernorm_kernel': True,
'from_pretrained': 'hpcai-tech/OpenSora-STDiT-v3',
'qk_norm': True,
'type': 'STDiT3-XL/2'},
'multi_resolution': 'STDiT2',
'num_frames': '102',
'prompt': ['A Japanese tram glides through the snowy streets of a city, its '
'sleek design cutting through the falling snowflakes with grace. '
"The tram's illuminated windows cast a warm glow onto the snowy "
'surroundings, creating a cozy atmosphere inside. Snowflakes dance '
'in the air, swirling around the tram as it moves along its '
'tracks. Outside, the city is blanketed in a layer of snow, '
'transforming familiar streets into a winter wonderland. Cherry '
'blossom trees, now bare, stand quietly along the tram tracks, '
'their branches dusted with snow. People hurry along the '
"sidewalks, bundled up against the cold, while the tram's bell "
'rings softly, announcing its arrival at each stop.'],
'prompt_as_path': False,
'resolution': '720p',
'save_dir': './samples/debug',
'save_fps': 24,
'scheduler': {'cfg_scale': 7.0,
'num_sampling_steps': 100,
'type': 'rflow',
'use_timestep_transform': True},
'seed': 1024,
'text_encoder': {'from_pretrained': 'DeepFloyd/t5-v1_1-xxl',
'model_max_length': 300,
'type': 't5'},
'vae': {'from_pretrained': 'hpcai-tech/OpenSora-VAE-v1.2',
'micro_batch_size': 4,
'micro_frame_size': 17,
'type': 'OpenSoraVAE_V1_2'}}
But the generated video is still blurry like below. Can you help me check whether there still exist incorrect parameters? Thanks a lot!
https://github.com/hpcaitech/Open-Sora/assets/14292495/0d0f9bf1-7d98-4e87-8363-5af857692df6

@Sze-qq  Could you help me with the issues above? Thanks a lot!

Hi @runzeer . I generated the image first and then clicked "Generate Video" on Gradio. Hope this helps.

@Sze-qq. Thanks a lot for your explanation. But I found the generated image style, like the image below,  is different with the gallery videos. So You used the  hpcai-tech/OpenSora-STDiT-v3 checkpoint or the original Pixart-sigma checkpoint for the first text-to-image task? Or I should add some prompts.

for the generated style?

We use the hpcai-tech/OpenSora-STDiT-v3 checkpoint. I tested that I can also reproduce @Sze-qq 's result.

We use the hpcai-tech/OpenSora-STDiT-v3 checkpoint. I tested that I can also reproduce @Sze-qq 's result.
@zhengzangw Thanks a lot. Did you share your seed for generating @Sze-qq 's result? I want to reproduce the video completely.

Hi @runzeer . I generated the image first and then clicked "Generate Video" on Gradio. Hope this helps.

Thanks for your reply, but in the galary page, it denotes " text to video"

Hi @runzeer . I generated the image first and then clicked "Generate Video" on Gradio. Hope this helps.

Thanks for your reply, but in the galary page, it denotes " text to video"

Sorry for the confuse, as several people contribute to the gallery. As the image is also generated with the same model, I think it can be viewed as "text to video" as well.


Feature: profiles downloader

Codecov Report

Merging #64 (b22f878) into main (f2057fe) will increase coverage by 1.45%.
The diff coverage is 46.51%.

@@            Coverage Diff             @@
##             main      #64      +/-   ##
==========================================
+ Coverage   38.94%   40.39%   +1.45%
==========================================
  Files          17       20       +3
  Lines         434      510      +76
  Branches       54       63       +9
==========================================
+ Hits          169      206      +37
- Misses        259      298      +39
  Partials        6        6

Impacted Files
Coverage Δ

qgis_deployment_toolbelt/cli.py
44.92% <0.00%> (-2.05%)
:arrow_down:

...loyment_toolbelt/jobs/job_environment_variables.py
33.33% <33.33%> (ø)

...loyment_toolbelt/jobs/job_profiles_synchronizer.py
37.14% <37.14%> (ø)

...deployment_toolbelt/profiles/remote_git_handler.py
64.51% <64.51%> (ø)

qgis_deployment_toolbelt/jobs/orchestrator.py
66.66% <66.66%> (ø)

qgis_deployment_toolbelt/profiles/__init__.py
100.00% <100.00%> (ø)


No option to review

There is something wrong with Olympia... it doesn't give me the option to review, only "Request more information Request super-review Comment" !!??
eg:
PerfectPixel 1.0.10 Extension 1 day
Brief 2.2.1 Extension 21 hours
Facebook Share Button 44.0 Extension 21 hours
MPL Koha Patch 16.4.0 Extension 20 hours

This should only happen the most recent submissions (under 20 hours, I think), which shouldn't be visible on the queues. The ones that appear in the queues should be reviewable. Please reopen if this is happening under other circumstances.

As you can see from the post......

All have already appeared on the queues
Some says 20 hours and some even 1 day
A couple of 1 day old ones were fine to review few hours ago but it changed now (when I posted)

PS. Not the issue here but entries used to start form 7 hours ago and now it says 20 hours ago. Did they really upload them 20 hours ago?

They now say 23 hours, 1 day etc and the situation is still the same. (unless it is only me having this issue ie I am being blocked!!??)
There is something wrong and the issue must be opened.
I am not able to re-open an issue closed by repo collaborators.

Okay, I'm reopening so someone can look at these cases. They should only be blocked when submitted in the last 20 hours.

I can not review any of these:
Brief 2.2.1  Extension  1 day
Facebook Share Button 44.0  Extension  1 day
MPL Koha Patch 16.4.0  Extension  1 day
Twitter App 44.0 Extension  1 day
YouTube Video Replay 44.0 Extension  1 day
OPIE (Ordered Preference Import/Export) 6.4 Extension  21 hours
Puzzle Bars 2.1.9 Extension  21 hours
Stylish Editor Modified 47.0.1 Extension  21 hours
SalesforceOverlay_Beta 1.1.34 Extension   1 day
telejurnal.com 1.1.1 Extension  1 day
OPIE2 1.0.6 Extension   21 hours
Check My HTTPS 2.0.1  Extension   21 hours

I have just noticed something ....
Is Exclusive  an admin reviewer?
He was able to review 2 addons that I was unable to review (ie the review options did not appear)
https://addons.mozilla.org/en-US/editors/review/firegestures
https://addons.mozilla.org/en-US/editors/review/facebook-share-button

If he is not an admin reviewer, is it possible that someone coded something using local time (instead of a fixed reference eg GMT)?

Just a note to say that the situation has not changed (although I realise that it has been the weekend).
The above bug, combined with addon-hoarding (where all new addons are opened and locked for 12+ hours until they become available to review) has considerably hampered the review process.
What was the logic behind the new changes; to limit the reviewers ability to review; to prevent new addons from being reviewed quickly and forcefully make new uploads wait at least 24+ hours; only make new uploads available to the Admin reviewers?
What is the point of addons that can not be reviewed appearing on the queue (which are annoying reviewers who open them to find out they can not be reviewed)?

The purpose is to give less active reviewers some add-ons to review, while allowing the most active ones to still handle most of them. Andreas is working on fixing this bug and looks like the fix will go live next week due to the release schedule. On a positive note, Andreas's fix will also fix the problem where add-ons appear in the queues with 8 hours waiting time. For now, I suggest you don't review any add-ons that show up in the queue with less than one day waiting time.

The purpose is to give less active reviewers some add-ons to review, while allowing the most active ones to still handle most of them.

Is that to say that for example, I have been personally targeted and barred from reviewing newly uploaded addons?
In other words, an institutional discriminatory system has been created to intentionally target the most reliable and consistent volunteer reviewers who have been donating their time and effort for free for months and years, on weekdays, weekends, and on holidays while everyone else was away?!!!

For now, I suggest you don't review any add-ons that show up in the queue with less than one day waiting time.
I am not able to review addons that have been waiting in the queue for less than a day, whether I want to or not.

With the additional situation of addon-Hoarding (sometimes for 24+ hours, check the image in the previous post), addons that have been around for over 1 day are not available either.
Well... as you wish

At the moment Teo and you are in the group that can't review recent submissions, but we'll update it group as needed. We would have preferred to rely on more of an honor code for this, but clearly that wasn't going to work after discussing it with you.
Your work is greatly appreciated, and the impact to Teo and you should be minimal since the amount of reviews taken by less active reviewers is a small fraction of what you two handle.
I don't quite understand the issue about hoarding, but it sounds like something that should be handled by email first so we can figure out what's going on and what should be done. This particular issue is going to be resolved in #1562 and #1594.


disarchive: rename from guile-disarchive, fix program

Description of changes
The package is never called guile-disarchive, either upstream or in other distros.
Also fix runtime error of $out/bin/disarchive.
Things done

Built on platform(s)

[ ] x86_64-linux
[x] aarch64-linux
[ ] x86_64-darwin
[x] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 263820 run on x86_64-linux 1

1 package built:

disarchive

(I forgot this package comes with a binary, that's my bad.)


Setup BuildBuddy job for provisioning provisioner

[x] Setup teleport with provisioner SSH
[x] write pyinfra connector for teleport
[x] create task which logs in and runs provisioning on teleport ssh target
[x] validate what happens to the connection when teleport restarts (if teleport version changes, reboot server?)
[ ] setup BuildBuddy job to run the task

https://goteleport.com/docs/management/admin/upgrading-the-teleport-binary/ For non interrupted upgrades

Had to change the CloudFlare proxy mode for tele.vgijssel.nl to "off" because of https://github.com/gravitational/teleport/discussions/11736. It's currently not possible to use teleport with proxy_listener_mode: multiplex enabled behind any sort of proxy like CloudFlare.

To SSH into the provisioner using teleport
bazel run //tools/teleport:tsh -- login
bazel run //tools/teleport:tsh -- ssh ubuntu@provisioner

Because pyinfra uses paramiko and paramiko doesn’t deal well with teleport ssh implementation https://github.com/paramiko/paramiko/issues/23, need to write a custom connector.

Changing the generated ssh config from Teleport to include the User ubuntu will further the connection attempt
# Begin generated Teleport configuration for tele.vgijssel.nl by tsh

# Common flags for all provisioner hosts
Host *.provisioner tele.vgijssel.nl
    UserKnownHostsFile "/home/devcontainer/.tsh/known_hosts"
    IdentityFile "/home/devcontainer/.tsh/keys/tele.vgijssel.nl/teleport-admin"
    CertificateFile "/home/devcontainer/.tsh/keys/tele.vgijssel.nl/teleport-admin-ssh/provisioner-cert.pub"
    HostKeyAlgorithms rsa-sha2-512-cert-v01@openssh.com,rsa-sha2-256-cert-v01<EMAIL_ADDRESS>
# Flags for all provisioner hosts except the proxy
Host *.provisioner !tele.vgijssel.nl
    Port 3022
    User ubuntu
    ProxyCommand "/home/devcontainer/bazel/output_base/external/teleport_arm64/teleport/tsh" proxy ssh --cluster=provisioner --proxy=tele.vgijssel.nl %r@%h:%p

# End generated Teleport configuration

then it fails on picking the right algorithm.

From https://github.com/paramiko/paramiko/issues/2087 and https://stackoverflow.com/questions/71335166/authentication-failures-when-using-paramiko-with-an-ssh-rsa-cert-v01openssh-com don't think it actually works. Have to wait for https://github.com/paramiko/paramiko/issues/387.

Maybe we can take some inspiration from https://goteleport.com/docs/machine-id/guides/gitlab/. GitHub and GitLab have special methods of joining the teleport cluster. Need to figure out how to replicate this behaviour to BuildBuddy.

From https://github.com/gravitational/teleport/discussions/7278 found that it's possible to also create an identity file manually for a particular user using
tctl auth sign --ttl=30h --user=<user> --out=file.pem

Maybe this is a good first step, after which can try out machine id?

Can also try to configure the machine ID inside the GitHub actions CI and somehow copy the identity file created into BuildBuddy for consumption.
bazel run //provisioner:deploy --config remote --pass-in-secret-somehow=identity

rm -rf /home/buildbuddy-tbot/tbot-user
rm -rf /home/buildbuddy-tbot/tbot-data
tctl bots rm buildbuddy
tctl bots add buildbuddy --roles=access --logins=ubuntu
  tbot init \
     --destination-dir=/home/buildbuddy-tbot/tbot-user \
     --bot-user=buildbuddy \
     --reader-user=buildbuddy-tbot
chown -R buildbuddy-tbot:buildbuddy-tbot /home/buildbuddy-tbot/tbot-data
chown -R buildbuddy-tbot:buildbuddy-tbot /home/buildbuddy-tbot/tbot-user
su buildbuddy-tbot
tbot start \
    --oneshot \
   --destination-dir=/home/buildbuddy-tbot/tbot-user \
   --data-dir=/home/buildbuddy-tbot/tbot-data \
   --token=0000000000 \
   --auth-server=tele.vgijssel.nl:443

Setup a regular user
tctl users add --roles access buildbuddy

Create a new identity file for 2160 hours (90 days)
tctl auth sign -o identity --user buildbuddy  --format file --ttl 2160h

Create secret in BuildBuddy called TELEPORT_BUILDBUDDY_IDENTITY with the contents of the identity file.


Add sphinx documentation style to pydocstyle config

Addition of sphinx documentation style to pydocstyle config as so:
[tool.ruff.pydocstyle]
    convention = "sphinx"

Currently pep257, google, and numpy documentation styles are supported. It'd be nice to have this major documentation style added as well.

We can probably add a convention that's compatible, but there would also be necessary work to actually support parsing Sphinx docstrings (e.g., https://github.com/PyCQA/pydocstyle/pull/595). pydocstyle itself does not support this.

Alright, so as far as I know, the necessary pull requests to pydocstyle have been made as of 5 hours ago. Relevant commit here: PyCQA/pydocstyle/commit.

Related, it would be nice to get a check when a different convention is used.

(Removing needs-decision since we should support this now.)

Sounds great! Let me know if there's anything I can do to help.

+1 on this feature. Any updates on sphinx support?

Ditto @winwinashwin. We would adopt Ruff immediately on this project it there was sphinx support. Unfortunately, we have a code base full of Sphinx style docstrings and need to implement linting on them.

Hello,
Also wondering if there's any plan updates to this? The project I work for is also looking for the support.

@charliermarsh , @zanieb , hi! Sorry for pinging directly on this, I see this as an only option to revive this ticket.
I noticed that this was going to be supported, but there haven't be news for a while. Could you please inform whether this is going to be supported in ruff?
Looking forward to bundle this with uv usage to have a fully configured ecosystem for our projects.

I think I found related PRs, as far as I understand ther are still under review

https://github.com/astral-sh/ruff/pull/13286
https://github.com/astral-sh/ruff/pull/13280

I think I found related PRs, as far as I understand they are still under review

https://github.com/astral-sh/ruff/pull/13286
https://github.com/astral-sh/ruff/pull/13280

@charliermarsh , @zanieb, any info please

@seppzer0 I understand that this feature is important to you but please stop pinging people. We get a lot of notifications every day and creating more for us just means that we have less time to work on features.
We plan to look at linked PRs but it might take a while because we have to balance it with other features that we want to ship. We'll make sure to update this issue or the linked PRs if there's an update.

@MichaReiser , thank you for your response! I do understand that pinging people is not great, unfortunately though it is often the only way to remind of the topic at hand.
Thank you once again for your work! Looking towards to this great feature 👍🏻


GIF support

I have rebuilt everything as per u told me.
The problem i am coming across is i am not able to get gif.imageio.so in dist/linux/lib directory.
iinfo shows unable to find 'unable to find gif file format reader'.
Can u help me, where am i still going wrong?
Thanks.

This review has languished for many months now.  Although we want GIF support, this seems incomplete, lacks test cases, has had no CLA submitted, and there has been no correspondence from this author for many months.
I'm closing the pull request.
@miti, if you are out there, we would love to see you revive this pull request with the necessary additions so that we can incorporate it into the project.


add @with

Matches the API in Base, but implemented with a sequence of nested macros 😓. Seems to work though.
Would like to use this to simplify stacktraces (rather than a layer of scoped stuff every time) by getting rid of these four frames:
    [5] with_logstate(f::Function, logstate::Any)
      @ Base.CoreLogging ./logging.jl:514
    [6] with_logger
      @ ./logging.jl:626 [inlined]
    [7] enter_scope
      @ ~/.julia/packages/ScopedValues/92HJZ/src/payloadlogger.jl:17 [inlined]
    [8] with(::Any, ::Pair{<:ScopedValues.ScopedValue})
      @ ScopedValues ~/.julia/packages/ScopedValues/92HJZ/src/ScopedValues.jl:162

Ty @vchuravy ! Can you register? I bumped the version here


catboost: 1.2.5 -> 1.2.7

Things done
Changelog: https://github.com/catboost/catboost/releases/tag/v1.2.7

catboost: move to by-name
catboost: format
catboost: 1.2.5 -> 1.2.7

cc @PlushBeaver @natsukium

Built on platform(s)

[x] x86_64-linux
[x] aarch64-linux
[ ] x86_64-darwin
[x] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Result of nixpkgs-review pr 347888 run on x86_64-linux 1

10 packages built:

catboost
catboost.dev
python311Packages.catboost
python311Packages.catboost.dist
python311Packages.orange3
python311Packages.orange3.dist
python312Packages.catboost
python312Packages.catboost.dist
python312Packages.orange3
python312Packages.orange3.dist

Thanks for the update! 🙇 Just one small fix maybe 🙏

No prob ! I have done this update hoping to fix the package for x86_64-darwin. I am not yet sure that it now builds.

nixpkgs-review result
Generated using nixpkgs-review.
Command: nixpkgs-review pr 347888

x86_64-linux

:white_check_mark: 10 packages built:

catboost
catboost.dev
python311Packages.catboost
python311Packages.catboost.dist
python311Packages.orange3
python311Packages.orange3.dist
python312Packages.catboost
python312Packages.catboost.dist
python312Packages.orange3
python312Packages.orange3.dist

aarch64-linux

:white_check_mark: 10 packages built:

catboost
catboost.dev
python311Packages.catboost
python311Packages.catboost.dist
python311Packages.orange3
python311Packages.orange3.dist
python312Packages.catboost
python312Packages.catboost.dist
python312Packages.orange3
python312Packages.orange3.dist

x86_64-darwin

:fast_forward: 10 packages marked as broken and skipped:

catboost
catboost.dev
python311Packages.catboost
python311Packages.catboost.dist
python311Packages.orange3
python311Packages.orange3.dist
python312Packages.catboost
python312Packages.catboost.dist
python312Packages.orange3
python312Packages.orange3.dist

aarch64-darwin

:fast_forward: 4 packages marked as broken and skipped:

python311Packages.orange3
python311Packages.orange3.dist
python312Packages.orange3
python312Packages.orange3.dist

:white_check_mark: 6 packages built:

catboost
catboost.dev
python311Packages.catboost
python311Packages.catboost.dist
python312Packages.catboost
python312Packages.catboost.dist

@zakame I addressed your point. Any additional feedback ?


Another bug when following run_example directions

When I try to work around the bug reported in issue #780, I get the following differences from the expected output of the example:
(ogcore-dev) run_examples% ls -l *csv
-rw-r--r--@ 1 mrh  staff  1584 Jan 21 15:34 expected_ogusa_example_output.csv
-rw-r--r--  1 mrh  staff  1640 Feb  6 19:56 ogcore_example_output.csv

(ogcore-dev) run_examples% diff ogcore_example_output.csv expected_ogusa_example_output.csv
1,7c1,7
< ,Variable,2021,2022,2023,2024,2025,2026,2027,2028,2029,2030,2021-2030,SS
< 0,GDP ($Y_t$),-0.16735054602134064,-0.14157894238355173,-0.21744030762126618,-0.2228052844188786,-0.21053121804236263,-0.18645099156078335,-0.16038127595033963,-0.1227400770701889,-0.0966153460839421,-0.0686338595948621,-0.16109691147992355,-0.38614414003818304
< 1,Consumption ($C_t$),-0.0758758816984031,1.0241899555137248,0.12310086751513638,-0.12812369754705397,-0.24351352511095206,-0.32277894213513253,-0.3650822883087033,-0.4194900817886846,-0.4286449823367036,-0.43497670601333205,-0.12405815155773192,-0.7176647471705253
< 2,Capital Stock ($K_t$),-0.37345099560834866,-0.4088108703473829,-0.6526898850168946,-0.7238091470195364,-0.7435953157488909,-0.7329467510562223,-0.7061826074090103,-0.6395066073284759,-0.5915818248341471,-0.5359026282768895,-0.6114964655711641,-1.5067823096305364
< 3,Labor ($L_t$),-0.05611097430623594,0.0026962912189517642,0.0178107834416318,0.048116426639532126,0.07779800378985717,0.10917626595672396,0.13487374038967076,0.1567571028593383,0.17105135740113175,0.18400991222994992,0.08132170577305775,0.22254945389625472
< 4,Real interest rate ($r_t$),-3.0520263383185156,-2.9453224967669973,-2.6454456597459677,-2.528842883299367,-2.472932542916348,-2.458652343235198,-2.460178345199604,-2.587338980604573,-2.616194455888617,-2.658686368570325,-2.645123883468417,-1.4021961225701403
< 5,Wage rate,-0.11126945384732671,-0.14423721606614195,-0.23516455599464775,-0.2707397075510938,-0.2880473874416187,-0.2952417708139666,-0.29478870611867075,-0.2789852586535098,-0.26713231749569566,-0.25209842003726,-0.24416757465891017,-0.607341307944457
---
> ,2020,2021,2022,2023,2024,2025,2026,2027,2028,2029,2020-2029,SS
> GDP ($Y_t$),-0.9832819726616429,-0.9933501251124207,-1.0012567410309168,-0.8619138689893194,-0.8688491315615962,-0.7954144519971328,0.16253581034984757,0.2192235803044291,0.34635236458521806,0.4438971020754922,-0.004407434795898249,-0.28714100248737645
> Consumption ($C_t$),-0.19127695030852182,-0.43858394506951565,-0.6288263816283477,-0.775297529368063,-0.8956242449906628,-0.9756499196546723,-0.854088421002668,-0.760260341447571,-0.6828219249152719,-0.622154622256172,-0.00683407489394566,-0.4132474874303411
> Capital Stock ($K_t$),0.0,-0.27133059955486166,-0.4644215120292453,-0.5989068345527114,-0.6429241686471642,-0.657352677351997,-0.6282759118350663,-0.327506178627711,-0.0520530895270575,0.22674410523649707,-0.0034423952769236177,-1.199948270903317
> Labor ($L_t$),-1.5086442720954116,-1.3799019355333633,-1.2890706763826723,-1.0032119937562165,-0.9902783163382312,-0.8696900923213652,0.5909222126362949,0.5147888056287747,0.5614363434496884,0.560889081941133,-0.004936241462388058,0.20785660530047687
> Real interest rate ($r_t$),-4.946074273142971,-4.518628301408074,-4.21475567456401,-3.7582757475400683,-3.69628288281014,-3.548635621551941,-1.9754843403167293,-2.391993084674715,-2.6409620482126543,-2.9427138949486453,-0.034709775717813314,-1.790330045029657
> Wage rate,0.53346692125439,0.3920004196645291,0.29160614327237255,0.14275150363838113,0.12265017901625362,0.07491797368546342,-0.4258948297161163,-0.29409587149628164,-0.2139472878444211,-0.11642425896171027,0.0004993836471175186,-0.4939722514914293

(ogcore-dev) run_examples%

The directions led me to think that I should expect no differences.  Is that correct?
If so, why do you think I'm getting massive differences?
The example ran smoothly using all four cores on my iMac in about 80 minutes.   There was no indication that anything was amiss.

Recently in PR #775, @rickecon said (emphasis added):

test_run_example.py  The call_run_ogcore_example() function in lines 14-24 loads the run_ogcore_example.py file into the environment as a module. Then the test_run_ogcore_example() function uses the multiprocessing.Process() function to call the module and run it. The test just makes sure that the script (module) runs for 5 minutes without an error.

@jdebacker,  This seems to be the reason for the problems reported in issues #780 and #781.   There is no test of whether or not the model produces the expected results.   This seems like a  quite a shortcoming given that you instruct a new user of the model to run the example and check whether or not the results are the same as the expected results.

This seems like a quite a shortcoming given that you instruct a new user of the model to run the example and check whether or not the results are the same as the expected results.

Yes, we have been careful when deciding on unit tests, especially those running on GH Actions, with processing time in mind, hence the absence of test of a full run of the example (there are already several units tests ensuring the model runs all the way through, even if not the example script).  But you make a good point and a test with a full run and comparing output should be added, even if just on "local" only runs.

This issue is resolved by PR #785. Closing.


Introduce a getRect utility function for the integration tests

Over time the number of integration tests that get the rectangle for a given selector has increased quite a bit, and the code to do so has consequently become duplicated.
This commit refactors the integration tests to move the rectangle fetching code to a single place, which reduces the code by over 400 lines and makes the individual tests simpler.

/botio integrationtest

/botio-windows integrationtest


How to install Midnight Commander using 'extra_packages' or by another way

Could you give a example?
Thank you for your products.
I bought your Ansible book.
Regards, Artu.

Change this line
extra_packages: []

To
extra_packages:
  - mc

and you should be good to go

I'll close this as I assume you got it working. Please re-open the issue if that's not the case.


No way i can logout and login  using your Shell Navigation.

Can you update your sample doc ?  Everytime it is telling me the views inside the navigation stack is present. Though i have cleared the navigation stack and made the  App.Xaml.Shell item's clear from the shell hierarchy.

Hi @samirgcofficial,
I am sorry, but I am not sure if I understand what your problem is. Could you please elaborate a bit more on that?


Create JOSM_Advanced_Mapping_ES.md

Spanish version of "Advanced Mapping with JOSM"

this was included in #487 ?


Debug Variable isn't present in breakpoint capture

Issue Type: Bug
When I hit a breakpoint and hover over a variable it isn't available although this worked in previous versions.  I noticed that a variable in a totally unrelated capture had its variable information available...
VS Code version: Code 1.57.1 (507ce72a4466fbb27b715c3722558bb15afa9f48, 2021-06-17T13:28:07.755Z)
OS version: Windows_NT x64 10.0.19041
Restricted Mode: No

System Info

Item
Value

CPUs
Intel(R) Core(TM) i7-4720HQ CPU @ 2.60GHz (8 x 2594)

GPU Status
2d_canvas: enabledgpu_compositing: enabledmultiple_raster_threads: enabled_onoop_rasterization: enabledopengl: enabled_onrasterization: enabledskia_renderer: enabled_onvideo_decode: enabledvulkan: disabled_offwebgl: enabledwebgl2: enabled

Load (avg)
undefined

Memory (System)
31.95GB (17.38GB free)

Process Argv
--crash-reporter-id 182d8253-7d30-4a14-83d1-eaa9dad2a2d8

Screen Reader
no

VM
0%

User Error


Normalize plots with origin on 1st, 10th or 100th case, in All States at Deep Dive.

Normalize plots with origin on 1st, 10th or 100th case, in All States at Deep Dive
Is your feature request related to a problem? Please describe.
No.
I would like to compare how each state (and maybe even cities, maybe for later) deals and progresses after the the 10th case. Usually using the 100th case would be more significant, but some the ones that have crossed that line are still less then half.
Describe the solution you'd like
I want to have an option or a separate widget to the "STATES - TOTAL CASES" in DEEP DIVE, where each line is normalized to it's 1st, 10th or 100th case, and therefore compare at which speed the number of cases evolved between states. Usually using the 100th case would be more significant, but the number of states that have crossed that line are still less then half.
Describe alternatives you've considered
I considered having it in the main page, but it's complex enough already.
Additional context

I would like to add that there's a limit of the 10 states with most current confirmed cases, in the aforementioned widget, and I don't understand why. I found the line of code that makes this and it seems one could just erase it.
It would also be convenient if clicking on a widget could hide the remaining ones and make it fill the page. Mostly for the most complex ones like the "STATES - TOTAL CASES". I can create a separate issue if it is required.

Thanks for the detailed enhancement request. This sounds good! Marking it available.

On it

On it

I saw you commited this feature, but I don't understand it.
I read your code and it doesn't make sense to me, I have the feeling you didn't understand my idea.
I wrote some code, and tried to clone the project but I don't have the resources to run it. I want for the beggining of each data curve to be matched so we can see how each of them grows differently.
This is what I was thinking

have all data combined and sortedMap generated as it is done in allStates.js
iterate through all the data of each state and make a new dataset normedStatesData where only points >=100 go to (states with less than 100 cases would not feature in this dataset)

// iterate through the sortedMap
  const longestStateData = 0;
  sortedMap.forEach((data, key) => {
    const normedData = [];
    statesData.get(key).forEach((value, i) => {
      // * I'm iterating through statesData.get(key),
      // * but it seems that doing it with data would provide the same effect
      // iterate through each point of the data
      // copy only >=100
      // The reference to the dates will be lost but that's the idea,
      // as long as the progressions throughout the days is maintained.
      if( value >= 100 ){
        // an improvement would be to parametarize the 100 for 1,10 or 100, and maybe 1000 if it makes sense
        normedData.push(value);
      }
    });
    // note down the length of the data of the state with most data point
    // to later generate X axis
    if(normedData.length > longestStateData){
      longestStateData = normedData.length;
    }
    // push the data of the state into the new dataset
    normedStatesData.set( key, normedData );
  });

make a new array of labels for the X axis normedLabels with ["day 1", "day 2", etc...] using the length of the data for the state with most days after above step

// making new X axis
  for (let i = 1; i <= longestStateData; i++) {
     normedDates.push("day "+i);
  }

two possibilities:
a. make a toggle button to switch between the two datasets and the two label arrays (incorporrated into allcharts.js).
or
b. feed the normedStatesData and the  normedLabels to the chart

What do you think?

I hadn't committed it yet... Still building it out... But thanks for your suggestions maybe we can work on it together

Still building it out...

I saw the Growth Trend Chart and assumed it was related with this.
Isn't this the commit?


Update configure to log out injected keys

Description
At the moment, configure succeeds silently, however, there is no indication whether or not certain config keys are being replaced or not.
Implementation

[ ] update configure to log out each key found and whether or not they were injected

I'm working on this one.

Just go ahead and assign yourself. That way we can tell at a glance which issues are claimed.