[hmac] V2(S) Signoff

Commits since HMAC D2(S) Signoff (https://github.com/lowRISC/opentitan/issues/20996)

git rev-parse HEAD
https://github.com/lowRISC/opentitan/commit/ea5bce9ed692af726da4729039c4cbe1fba64ee7
git log d7483116b80bf56ce2b8e665c679872de3f3794d..HEAD --oneline hw/ip/hmac
99ce062a64 [hmac, dv] Fix ValidHmacEnConditionAssert
01a208901a [hmac,rtl/dv] DV synchronization and error handling fixes
f489ff703d [hmac,rtl] HMAC FSM RTL fixes to handle SAR
7d8ace24cb [dv] Remove default value for wait_to_issue_reset argument
6c51bc0da2 [hmac,dv] DV fixes for block-level tests
ee5f4a1abf [sram_ctrl] Add readback feature
f9f6fe5d06 [hmac,csrs/rtl] Add key_swap field and expose hmac idle status
aace3c0617 [hmac,rtl/dv] RTL and DV fixes for digest loading and error handling
76b1c7498c [hmac,dv] DV synchronization fixes for do_read_check
c1fa3221d0 [hmac,rtl] Minor HMAC fixes for secret key wiping
:...skipping...
99ce062a64 [hmac, dv] Fix ValidHmacEnConditionAssert
01a208901a [hmac,rtl/dv] DV synchronization and error handling fixes
f489ff703d [hmac,rtl] HMAC FSM RTL fixes to handle SAR
7d8ace24cb [dv] Remove default value for wait_to_issue_reset argument
6c51bc0da2 [hmac,dv] DV fixes for block-level tests
ee5f4a1abf [sram_ctrl] Add readback feature
f9f6fe5d06 [hmac,csrs/rtl] Add key_swap field and expose hmac idle status
aace3c0617 [hmac,rtl/dv] RTL and DV fixes for digest loading and error handling
76b1c7498c [hmac,dv] DV synchronization fixes for do_read_check
c1fa3221d0 [hmac,rtl] Minor HMAC fixes for secret key wiping
5a74a15fb1 [hmac/rtl] Fix idle_o when told to stop
e71da1ced8 [hmac/rtl] Wait for digest of complete block when stopping
dbe6169068 [prim_sha2_pad,rtl] Go to idle (without padding) when told to stop
e01609eb0d [hmac,doc] Documentation fixes
128d609a2a [hmac,dv] Scoreboard checks for different digest sizes
e120a95bb6 [hmac/prim_2,rtl] Do not clear redundant digest values
ed04dc9cf4 [hmac, doc] Update HMAC context saving guide
f189ae8354 [hmac, doc] Update programmers guide for streaming
5bc6e0a96f [hmac, rtl] Fix indexing bug/typo
ab878b5d35 [hmac/dv] Cleanups and coverage fixes/improvements
e2eff20902 [hmac,dv] Extend DV to test invalid configurations
c859a39662 [hmac/prim_sha2,rtl] Implement SW error for invalid HMAC config
4bc15708cd [prim_sha2,rtl/dv] Fix secret value wiping
0d0ce1ad80 [hmac/dv] Cleanups without functional impact
dc848b3e2a [sram_ctrl,prim,rtl] Fix tlul_we -> ready timing path.
8295903d7e [bazel,autogen_hjson] Split C and rust header generation
30d7e787c7 (tag: Earlgrey-PROD-M2-RC5, tag: Earlgrey-PROD-M2) Add the project name to the copyright header
d01864e18e Fix or waive Python lint errors and warnings
f4c2bb9030 Remove trailing whitespaces
Issues closed since HMAC D2(S) Signoff (https://github.com/lowRISC/opentitan/issues/20996)

Issues closed since HMAC D2(S) Signoff

Discussed moving as P1 to M5 due to RTL risk analysis performed during last issue triage.

Alright, AFAIK all outstanding PRs have been merged and issues addresses. @martin-velay is currently investigating an issue with FSM coverage but after that we should be able to close V2S.

Here are the latest updates: https://github.com/lowRISC/opentitan/issues/23683
Coverage results in this comment: https://github.com/lowRISC/opentitan/issues/23683#issuecomment-2210190963. This includes the UNR exclusions from this PR https://github.com/lowRISC/opentitan/pull/23916 which is not merged yet.
The FSM cov is still a bit lower than 90%, and here is the reason: https://github.com/lowRISC/opentitan/issues/23683#issuecomment-2208903846

Thanks @martin-velay , I've feed back on the FSM coverage issue. I believe this should be coverable but it may need very precise timing.
I've merged the updated UNR file.

Thanks for the V2S review, @martin-velay, and all your work on this, also to @gdessouky!
I reviewed the following commits, which change the RTL of HMAC and/or the SHA2 prims it instantiates:

5084b38250 [hmac] Coding style and minor fixes
--> lint and coding style fixes
30d7e787c7 Add the project name to the copyright header
--> no functional change
dc848b3e2a [sram_ctrl,prim,rtl] Fix tlul_we -> ready timing path.
--> no functional change to HMAC or SHA2
4bc15708cd [prim_sha2,rtl/dv] Fix secret value wiping
--> fix for issue #22555
c859a39662 [hmac/prim_sha2,rtl] Implement SW error for invalid HMAC config
--> fix for issue #22312
5bc6e0a96f [hmac, rtl] Fix indexing bug/typo
--> fix for issue #23014
e120a95bb6 [hmac/prim_2,rtl] Do not clear redundant digest values
--> fix wiping with random value for upper digest registers in SHA2_256 mode
a7cb9a484e [prim_sha2_pad,rtl] Fix setting of digest mode when continuing
--> fix for save & restore feature
6e6c14b56d [prim_sha2_pad,rtl] Refactor comparison on tx_count and msg len into signal
--> small refactoring to enable subsequent commit
dbe6169068 [prim_sha2_pad,rtl] Go to idle (without padding) when told to stop
8fad05fba7 [prim_sha2_pad,rtl] Signal msg feed complete also when stopping
e71da1ced8 [hmac/rtl] Wait for digest of complete block when stopping
--> fixes for save & restore feature
5a74a15fb1 [hmac/rtl] Fix idle_o when told to stop
--> fix for issue #23036
c1fa3221d0 [hmac,rtl] Minor HMAC fixes for secret key wiping
--> fix for secret wiping
aace3c0617 [hmac,rtl/dv] RTL and DV fixes for digest loading and error handling
--> fix digest loading and improve error handling
f9f6fe5d06 [hmac,csrs/rtl] Add key_swap field and expose hmac idle status
--> resolve issue #23158
ee5f4a1abf [sram_ctrl] Add readback feature
--> no functional change to HMAC or SHA2
9e6feec006 [kmac,prim_sha2/rtl] Remove unused conv_endian64 function
--> code removal for lint cleaning
0742a8e0ad [kmac,prim_sha2/rtl] Fix lint error in conv_endian32
--> lint cleanup, no functional change
f489ff703d [hmac,rtl] HMAC FSM RTL fixes to handle SAR
--> fix for save & restore feature
01a208901a [hmac,rtl/dv] DV synchronization and error handling fixes
--> fix loading from message FIFO
99ce062a64 [hmac, dv] Fix ValidHmacEnConditionAssert
--> fix issue #23348
32d52b8d41 [hmac,rtl] Fix Save & Restore FSM bug
--> fix for save & restore feature
37bcf1ef9f [hmac/lint] Remove unused localparam
--> lint cleanup, no functional change
d79a3bb4f8 [hmac,rtl] Coding cosmetics fixes
--> no functional change
85baec433f [hmac,dv] Minor DV assertion fix
--> no functional change
d851a38dc7 [hmac] Avoid inference of latch
--> prevent unintended latch

Those RTL changes LGTM.
Test pass rates are excellent overall (today 100% including V3 tests!), though the fifo_empty_status_interrupt testpoint currently has no tests assigned with it. Since PR #23749, the scoreboard includes checks for this feature, so we just need to list the appropriate tests.
Coverage numbers are very good (94 to 100%) except FSM, which is known and for which an exclusion is being added.
None of the open issues prevents us from signing HMAC off at V2S in my view.
In conclusion, once the exclusions for FSM coverage are in and the fifo_empty_status_interrupt testpoint has tests assigned with it, I agree with signing HMAC off at V2S.

Exclusions for the FSM coverage per our discussion here https://github.com/lowRISC/opentitan/issues/23683 have been added in https://github.com/lowRISC/opentitan/pull/23948.

FSM coverage is now at 97% with the additional FSM exclusions.


Fix Menu Popup Placement

What does the pull request do?
Bottom left aligns Menu popups.
What is the current behavior?

What is the updated/expected behavior with this PR?

How was the solution implemented (if it's not obvious)?
Obvious
Checklist

[ ] Added unit tests (if possible)?
[ ] Added XML documentation to any related classes?
[ ] Consider submitting a PR to https://github.com/AvaloniaUI/Documentation with user documentation

Breaking changes
None
Obsoletions / Deprecations
None
Fixed issues
Fixes https://github.com/AvaloniaUI/Avalonia/issues/10662

You can test this PR using the following package version. 11.0.999-cibuild0031881-beta. (feed url: https://pkgs.dev.azure.com/AvaloniaUI/AvaloniaUI/_packaging/avalonia-all/nuget/v3/index.json) [PRBUILDID]


#6352 input-transition was hardcoded

This resolves #6352

Thanks! I removed the !default from the settings file and added the new variables to the docs. https://github.com/zurb/foundation/commit/4eafb38351a31ed111bf348d943ae6a9575c856f


disable swiftshader until we can fix the clang -frewrite-includes bug

https://bugs.llvm.org/show_bug.cgi?id=26828 continues to cause trouble, let's
also disable swiftshader until it is resolved somehow :(

I need to confirm that this works first... (it builds, but I have a report of startup failures due to GPU initialization issues).

This means certain 3d features won't work with --disable-gpu? I use --disable-gpu quite often working over a VPN.

Possibly, I'm not sure.  In theory it might just disable webgl.


Constant (but also random) issues with ONLY markdown files in VSCode after VSCode updates

I could not find any other bugs matching this.

Im not an insider, nor do I have time as a software dev to test your builds while Im in the process of testing my own software. Trust me I wish I had time to be able to this but

Does this issue occur when all extensions are disabled?: Yes/No
No this does not happen then, but that does not mean its directly related to the extension. This particular extension is microsoft's own  "learn-scaffolding", which if github is correct, hasnt been updated or changed in a while and in VSCode the margin says the extension was  Last updated 2023-12-12, 14:39:03, which indicates, since I just did a visual studio code update, that its more directly related to vscode than the extension.

The publisher of the extension is MICROSOFT....but the extension has not had any new updates lately from what I can tell.

VS Code Version/OSVersion

Steps to Reproduce:
First let me start by saying, this is more a collection of errors that occur ONLY IN MARKDOWN FILES which suggests that it is something with a markdown-related setting, or a markdown-related extension or its settings...Sometimes the error appears, sometimes it doesnt...They appear randomly and sometimes visual markers appear in the actual editor as well as the notifications box and sometimes they do not appear at all.
For example...Pasting into a markdown file, sometime shows a tiny grey wait spinner followed by Running paste handlers in the editor itself.
Another example is when you save the markdown file, it appears as if it tries to format the file and gives some generic notification statements like

Saving test.md followed by
Running 'File Save' participants...
File creation is similar:
Creating test.md followed by
Running 'File Create' participants...
If any of this happens on other file types, it must happen so quickly that I dont see it or notice it.

The error occurs randomly when I either paste into a markdown file:

via the menu Paste
via context menu (right click mouse) Paste
by shortcut key Ctrl+V
THIS TAKES FOREVER

Issues also occur when I create a new markdown file in the left-side panel. by:

right clicking a folder and selecting New File
clicking on the New File icon ,
THIS TAKES FOREVER...

Clicking CTRL+S does the same thing just a different message...also randomly showing itself.

Now that beings said...the actual ERRORS that appear in the notifications in red, and are also random, are:

Other than that, the only things I see that could be affecting this (but shouldnt) is my user settings (settings.json) in the .vscode folder. I will paste the contents below, but I have tried many different variations, even removed them all except for the copyfile.destination setting. I have these settings so when I paste an image into the markdown, it automatically adds a folder(s) to the parent directory (if not exist) named assets/images/, and drops the image into that folder. It appears that certain settings are being overridden by new updates of vscode. I cant prove this of course because of the completely random nature of the errors. But I can tell you that i always see them most prevalently within a week of a new vscode update, but not EVERY UPDATE... Please just tell me what Im doing wrong if its me.
{
    "markdown.copyFiles.destination": {
        "/**/*": "${documentDirName}/assets/images/"
    },
    "[markdown]": {
        "editor.formatOnSave": true,
        "editor.formatOnPaste": true
    },
    "editor.formatOnSave": true
}

I have no taxing programs running, no memory hogs, no cpu hogs. and my workstation, other than VSCODE runs like a dream.

Dell Precision 7750
64bit
Windows 11 Pro 10.0.22631
i7 Processor
4TB SSD (primary)
1TB SSD (secondary)
64GB RAM

My network speed is lightning fast, so no troubles there

No this does not happen then, but that does not mean its directly related to the extension.

If it only happens when the extension is enabled, it's caused by the extension

With extension disabled, please provide specific steps to reproduce the issue. Also make sure to fill in the issue template

Thanks for creating this issue! We figured it's missing some basic information or in some other way doesn't follow our issue reporting guidelines. Please take the time to review these and update the issue.
Happy Coding!

This issue has been closed automatically because it needs more information and has not had recent activity. See also our issue reporting guidelines.
Happy Coding!


Allow to add public IP addresses to API server certificates

When connecting to the API server through the public IP address
it did not work because the certificate did not include this IP.
Including the public IP on demand in addition to the internal IP
solves this issue.

@pothos AFAIK we constantly manage k8s clusters using the controller node's public IP.
Could you please clarify exactly what does not work currently including steps to reproduce? This repository is largely a generic Typhoon module and we should think twice before making changes to it.

@johananl thing is that we would like to be able to test locally, without public DNS and we want to avoid messing around with hosts's /etc/hosts, that's why the access should be over VM ip address. Otherwise you have to mess up with networkmanager to use libvirtd internal DNS server. Accessing via IP address is just way simpler.

The TLS certificate was just issued for the API server domain names and the first internal IP of the service CIDR. I could not simply use the node's IP as external API server domain name because this part of the TLS certificate is not meant for IPs and it results in a "bad certificate" error when I wanted to connect with kubectl.

Thanks, the problem is clearer to me now.


[EG] SignalR Required/Optionality

For SignalRServiceClientConnectionConnectedEventData, “userId” is optional, all other properties are always set.
For SignalRServiceClientConnectionDisconnectedEventData,  both “userId” and “errorMessage” are optional, all other properties are always set.

API change check
APIView has identified API level changes in this PR and created following API reviews.
Microsoft.ApiCenter


Question: Docstring formatting information/examples

Can you provide information about how docstrings are formatted when a Python file is given to docstrfmt?
Things I have noticed that surprised me so far:

The first line of a multi-line docstring (the summary line) does not get split to multiple lines if it goes over the line length limit, but other lines will be reformatted. This kind of makes sense because PEP 257 says that the summary line should fit on one line, but looks like a bug to anyone not familiar with it. (I'm still not sure if it is a bug or not, honestly)

Function parameter documentation like:
:param var1: This is the description of an optional parameter, defaults to 5
:type var1: int, optional

is compacted to
:param int, optional var1: This is the description of an optional parameter, defaults to 5

which I didn't even realize was possible! It was hard to find where this compact format was defined (here, I think) in the Sphinx documentation, so I was initially suspicious of whether it was actually part of the Sphinx format. Links to the formatting guide and/or formatted samples would be incredibly useful in clearing up things like this.

I certainly can!

Your deduction is spot on. It is intentional to not format the first line. Doing so would cause other linters to complain about the violation.
Typing can be provided in the parameter itself. This is interpreted against the standard library and your code base assuming you utilize sphinx's autodoc module. Your typing annotation in the example code is technically incorrect. It should be Something like this::param Optional[int] var1: This is the description of an optional parameter, defaults to 5.

Or:param int | None var1: This is the description of an optional parameter, defaults to 5.

Re: linking relevant documentation: This would be quite a tedious undertaking to do so. It would also likely require a dedicated readthedocs page (which is likely coming soon for configuration alone) for the project. I would welcome if someone wants to take it on but I don't have the bandwidth to do so right now. To be completely honest, I don't see the benefit out weighing the time investment in documenting/cross referencing every aspect of ReStructuredText+Sphinx that this project formats. Now, I'm not ruling it out completely as this project has seen more activity in the last month than nearly its entire history. However, I'd rather cite/explain things ad-hoc as they come up (this could later be compiled into a doc if there's demand for it) than to document everything outright all at once.

Makes sense, I totally get the lack of bandwidth! I also get the tediousness of linking a bunch of different references for the formatting choices. Alternatively, a few sample docstrings would really go a long way in communicating what to expect. I can make a PR with a few samples if you want, since I am toying around with it in a personal project right now and can easily convert some formatted docstrings into samples.

Your typing annotation in the example code is technically incorrect.

I don't think it is incorrect in this instance, although I didn't even know Optional[] existed before now so I had to do some reading and still might not understand!
From PEP 484, Optional[T1] is a shortcut for Union[T1, None] for the type. My understanding is that this helps type checkers not complain about instances where None is a valid value, but your desired type is actually some class or typedef, T1. I think some other languages call this "Nullable", and I've seen a lot of mentions in forums that Optional[] was an unfortunate and misleading name. In my case, the default value is an int and I want to tell the user that int is the only acceptable type for var1. Using Optional[int] or int | None would imply that None is also a valid value/type, which it is not. After some testing, I found that type checkers like mypy will actually complain if you use var: Optional[int] = 5 and then try to do var + 3 later on, since None is not a valid type to use for the + operator.
As far as using , optional at the end of :type var1: int, optional, that is what the autoDocstring extension of VSCode generates for the signature def foo(var1: int = 5):. It has >10.4 million installs, so I'm content to go with that default if it is what everyone else is doing. The docstrfmt formatted version still compiles and displays nicely, too!


feat: Cosh

Feature Request
Describe the Feature Request
Calculates the hyperbolic cosine of the given input tensor element-wise.
Full description here: https://github.com/onnx/onnx/blob/main/docs/Operators.md#Cosh

I can take assignment on this one.

completed

https://github.com/gizatechxyz/orion/pull/132


About hard disk usage restrictions

OpenPAI version: v1.7.0

Does openpai not limit the size of the disk? After the disk exceeds the limit, the job fails.

The data is not stored in the storage, which will lead to the loss of user data

OOMKill refers to the memory exceeding the quota, not the hard disk.

I used the dd command to test at the time. I ran a dd command without running other software.

Please refer https://serverfault.com/questions/516074/why-are-applications-in-a-memory-limited-lxc-container-writing-large-files-to-di. In Linux, write to disk will cached in memory first.


feat(mockingbird-ts): add mock factory fluent/builder api

Codecov Report

Merging #60 (79c6220) into release (a2950f1) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##           release       #60   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files           19        22    +3
  Lines          214       257   +43
  Branches        24        27    +3
=========================================
+ Hits           214       257   +43

Impacted Files
Coverage Δ

packages/generator/src/index.ts
100.00% <100.00%> (ø)

packages/generator/src/lib/index.ts
100.00% <100.00%> (ø)

packages/generator/src/lib/mock-builder.ts
100.00% <100.00%> (ø)

packages/generator/src/lib/mock-factory.ts
100.00% <100.00%> (ø)

packages/generator/test/e2e/test-classes.ts
100.00% <100.00%> (ø)

.../generator/test/integration/common/test-classes.ts
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a2950f1...79c6220. Read the comment docs.


Adding interactions for non-human/mouse

I'm working with zebrafish data, and we have several ligands/receptors of interest which aren't mapped in HomoloGenes DB (Example: NGF in human, ngfa & ngfb in zebrafish). The interactions of interest are represented in the ConnectomeDB interaction database. We've identified around a dozen interactions that we're keenly interested in, but are missing from the results due to lack of HomoloGene mapping.
Is there a recommended way to compute the missing interactions? This seems to be implemented for adding human and mouse interactions, but not other species.
Thank you!

Was able to trick the code by doing the following:

Run ExtractEdges as recommended using --species zebrafish
Create a custom interDB with the missing interactions (due to lack of homologene mapping) using zebrafish genes
Run ExtractEdges.py using the new interDB with argument --species human to forego homology mapping
combine the output from the two ExtractEdges.py runs


[SP-3777][PDI-16441] ${Internal.Job.Repository.Directory} and ${Internal.Transformation.Repository.Directory} kettle variable are not working in 6.1,7.0 and 7.1 versions

[SP-3777][PDI-16441] ${Internal.Job.Repository.Directory} and ${Internal.Transformation.Repository.Directory} kettle variable are not working in 6.1,7.0 and 7.1 versions
fixing loading a transformation and a job

Build Completed
:x: This pull request has errors. They will need to be addressed before it can be accepted. See below for more details. Some links are also available below for further assistance in addressing those issues.
Build Commands
ant -Dtestreports.dir=bin/reports/unit-test -f engine/build.xml clean-all resolve jacoco && ant -f engine/build.xml checkstyle publish-local

Cleanup Commands
rm -r ~/.ivy2/local || echo no publish local to remove

Changed files
  engine/src/org/pentaho/di/job/JobMeta.java
  engine/src/org/pentaho/di/trans/TransMeta.java
  engine/test-src/org/pentaho/di/job/JobMetaTest.java
  engine/test-src/org/pentaho/di/trans/TransMetaTest.java

Unit test coverage change
These statistics help you identify how your changes have affected the coverage of the following files. If a file is not in this list, then its coverage was not affected by your changes. To get some help interpreting these metrics, please refer to Jacoco's documentation.
org.pentaho.di.core.auth.core.impl.DefaultAuthenticationConsumerFactory

Branch Change: -7.14%:small_red_triangle_down:
Complexity Change: -7.69%:small_red_triangle_down:

org.pentaho.di.core.logging.JobEntryLogTable

Branch Change:  + 1.52%
Complexity Change:  + 1.82%
Instruction Change:  + .11%
Line Change:  + .76%

org.pentaho.di.core.logging.JobLogTable

Complexity Change:  + 2.53%
Instruction Change:  + .98%
Line Change:  + 2.07%
Method Change:  + 5.88%

org.pentaho.di.job.entries.sql.JobEntrySQL

Instruction Change: -1.64%:small_red_triangle_down:
Line Change: -1.95%:small_red_triangle_down:

org.pentaho.di.job.Job

Branch Change:  + 3.20%
Complexity Change:  + .38%
Instruction Change:  + 2.27%
Line Change:  + 1.74%
Method Change:  + .72%

org.pentaho.di.job.JobMeta

Branch Change:  + 2.13%
Complexity Change:  + 2.24%
Instruction Change:  + 1.68%
Line Change:  + 1.35%

org.pentaho.di.repository.kdr.KettleDatabaseRepositoryCreationHelper

Branch Change:  + 1.64%
Complexity Change:  + .69%
Instruction Change:  + 2.43%
Line Change:  + 3.70%

org.pentaho.di.trans.step.StepMeta

Instruction Change:  + .19%
Line Change:  + .27%

org.pentaho.di.trans.steps.memgroupby.MemoryGroupByMeta

Branch Change:  + 1.18%
Complexity Change:  + 1.35%

org.pentaho.di.trans.steps.replacestring.ReplaceStringMeta

Instruction Change:  + .07%

org.pentaho.di.trans.steps.symmetriccrypto.symmetriccryptotrans.SymmetricCryptoTransMeta

Branch Change: -3.33%:small_red_triangle_down:
Complexity Change: -1.85%:small_red_triangle_down:
Instruction Change: -.28%:small_red_triangle_down:

org.pentaho.di.trans.TransMeta

Branch Change:  + .69%
Complexity Change:  + .71%
Instruction Change:  + .35%
Line Change:  + .33%

Checkstyle violations
The code submitted is not complying with one or more of our guidelines. To perform these checks locally, please use this tool.
/home/buildguy/project/engine/test-src/org/pentaho/di/job/JobMetaTest.java

:heavy_exclamation_mark: Using a static member import should be avoided - org.junit.Assert.assertEquals. at Line: 54

:heavy_exclamation_mark: Using a static member import should be avoided - org.mockito.Matchers.same. at Line: 55

:heavy_exclamation_mark: Using a static member import should be avoided - org.mockito.Mockito.*. at Line: 56

/home/buildguy/project/engine/test-src/org/pentaho/di/trans/TransMetaTest.java

:heavy_exclamation_mark: 'member def type' have incorrect indentation level 5, expected level should be one of the following: 6, 8. at Line: 378

:heavy_exclamation_mark: 'object def' child have incorrect indentation level 5, expected level should be one of the following: 6, 8. at Line: 378

@mchen-len-son Could you please review and merge it?

Build Completed
:white_check_mark: This pull request has passed all validations.
Build Commands
ant -Dtestreports.dir=bin/reports/unit-test -f engine/build.xml clean-all resolve jacoco && ant -f engine/build.xml checkstyle publish-local

Cleanup Commands
rm -r ~/.ivy2/local || echo no publish local to remove

Changed files
  engine/src/org/pentaho/di/job/JobMeta.java
  engine/src/org/pentaho/di/trans/TransMeta.java
  engine/test-src/org/pentaho/di/job/JobMetaTest.java
  engine/test-src/org/pentaho/di/trans/TransMetaTest.java

Newly Fixed Tests:
org.pentaho.di.trans.TransTest.transWithNoStepsIsNotEndless:
:large_blue_circle: java.lang.Exception
java.lang.Exception: test timed out after 1000 milliseconds
	at org.mockito.asm.ByteVector.putShort(ByteVector.java)
	at org.mockito.asm.MethodWriter.put(MethodWriter.java:1883)
	at org.mockito.asm.ClassWriter.toByteArray(ClassWriter.java:795)
	at org.mockito.cglib.core.DebuggingClassWriter.access$001(DebuggingClassWriter.java:24)
	at org.mockito.cglib.core.DebuggingClassWriter$1.run(DebuggingClassWriter.java:76)
	at java.security.AccessController.doPrivileged(Native Method)
	at org.mockito.cgli

Unit test coverage change
These statistics help you identify how your changes have affected the coverage of the following files. If a file is not in this list, then its coverage was not affected by your changes. To get some help interpreting these metrics, please refer to Jacoco's documentation.
org.pentaho.di.core.auth.core.impl.DefaultAuthenticationConsumerFactory

Branch Change:  + 7.14%
Complexity Change:  + 7.69%

org.pentaho.di.core.logging.JobEntryLogTable

Branch Change:  + 1.52%
Complexity Change:  + 1.82%
Instruction Change:  + .11%
Line Change:  + .76%

org.pentaho.di.core.logging.JobLogTable

Complexity Change:  + 2.53%
Instruction Change:  + .98%
Line Change:  + 2.07%
Method Change:  + 5.88%

org.pentaho.di.job.entries.sql.JobEntrySQL

Instruction Change:  + 1.64%
Line Change:  + 1.95%

org.pentaho.di.job.Job

Branch Change:  + 3.20%
Complexity Change:  + .38%
Instruction Change:  + 2.27%
Line Change:  + 1.74%
Method Change:  + .72%

org.pentaho.di.job.JobMeta

Branch Change:  + 2.13%
Complexity Change:  + 2.24%
Instruction Change:  + 1.68%
Line Change:  + 1.35%

org.pentaho.di.trans.steps.excelwriter.ExcelWriterStepMeta

Branch Change:  + 1.28%
Complexity Change:  + .79%
Instruction Change:  + .04%

org.pentaho.di.trans.steps.memgroupby.MemoryGroupByMeta

Branch Change:  + 1.18%
Complexity Change:  + 1.35%

org.pentaho.di.trans.steps.textfileinput.TextFileInputMeta

Branch Change:  + .53%

org.pentaho.di.trans.TransMeta

Branch Change:  + .69%
Complexity Change:  + .71%
Instruction Change:  + .35%
Line Change:  + .33%

Build Completed
:x: This pull request has errors. They will need to be addressed before it can be accepted. See below for more details. Some links are also available below for further assistance in addressing those issues.
Build Commands
ant -Dtestreports.dir=bin/reports/unit-test -f engine/build.xml clean-all resolve jacoco && ant -f engine/build.xml checkstyle publish-local

Cleanup Commands
rm -r ~/.ivy2/local || echo no publish local to remove

Changed files
  engine/src/org/pentaho/di/job/JobMeta.java
  engine/src/org/pentaho/di/trans/TransMeta.java
  engine/test-src/org/pentaho/di/job/JobMetaTest.java
  engine/test-src/org/pentaho/di/trans/TransMetaTest.java

Newly Broken Tests:
org.pentaho.di.trans.steps.syslog.SyslogMessageConcurrentTest.concurrentSyslogMessageTest:
:red_circle: java.lang.Exception
java.lang.Exception: test timed out after 10000 milliseconds
	at java.lang.ClassLoader.findBootstrapClass(Native Method)
	at java.lang.ClassLoader.findBootstrapClassOrNull(ClassLoader.java:1015)
	at java.lang.ClassLoader.loadClass(ClassLoader.java:413)
	at java.lang.ClassLoader.loadClass(ClassLoader.java:411)
	at sun.misc.Launcher$AppClassLoader.loadClass(Launcher.java:335)
	at java.lang.ClassLoader.loadClass(ClassLoader.java:357)
	at org.productivity.java.syslog4j.impl.net.udp.UDPNetSyslog.crea

Unit test coverage change
These statistics help you identify how your changes have affected the coverage of the following files. If a file is not in this list, then its coverage was not affected by your changes. To get some help interpreting these metrics, please refer to Jacoco's documentation.
org.pentaho.di.core.auth.core.impl.DefaultAuthenticationConsumerFactory

Branch Change:  + 7.14%
Complexity Change:  + 7.69%

org.pentaho.di.core.logging.JobEntryLogTable

Branch Change:  + 1.52%
Complexity Change:  + 1.82%
Instruction Change:  + .11%
Line Change:  + .76%

org.pentaho.di.core.logging.JobLogTable

Complexity Change:  + 2.53%
Instruction Change:  + .98%
Line Change:  + 2.07%
Method Change:  + 5.88%

org.pentaho.di.job.entries.syslog.SyslogDefs

Branch Change: -23.53%:small_red_triangle_down:
Complexity Change: -11.11%:small_red_triangle_down:
Instruction Change: -5.64%:small_red_triangle_down:
Line Change: -14.93%:small_red_triangle_down:
Method Change: -33.33%:small_red_triangle_down:

org.pentaho.di.job.Job

Branch Change:  + 3.20%
Complexity Change:  + .38%
Instruction Change:  + 2.27%
Line Change:  + 1.74%
Method Change:  + .72%

org.pentaho.di.job.JobMeta

Branch Change:  + 2.13%
Complexity Change:  + 2.24%
Instruction Change:  + 1.68%
Line Change:  + 1.35%

org.pentaho.di.trans.steps.symmetriccrypto.symmetriccryptotrans.SymmetricCryptoTransMeta

Branch Change: -3.33%:small_red_triangle_down:
Complexity Change: -1.85%:small_red_triangle_down:
Instruction Change: -.28%:small_red_triangle_down:

org.pentaho.di.trans.steps.syslog.SyslogMessage

Branch Change: -20.00%:small_red_triangle_down:
Complexity Change: -4.76%:small_red_triangle_down:
Instruction Change: -21.47%:small_red_triangle_down:
Line Change: -22.08%:small_red_triangle_down:
Method Change: -16.67%:small_red_triangle_down:

org.pentaho.di.trans.steps.textfileinput.TextFileInputMeta

Branch Change: -.53%:small_red_triangle_down:

org.pentaho.di.trans.steps.uniquerows.UniqueRowsMeta

Instruction Change:  + .18%

org.pentaho.di.trans.TransMeta

Branch Change:  + .69%
Complexity Change:  + .71%
Instruction Change:  + .35%
Line Change:  + .33%

Build Completed
:fire: This pull request has some issues. It would be preferable to fix them in order for it to be just perfect. See below for more details. Some links are also available below for further assistance in addressing those issues.
Build Commands
ant -Dtestreports.dir=bin/reports/unit-test -f engine/build.xml clean-all resolve jacoco && ant -f engine/build.xml checkstyle publish-local

Cleanup Commands
rm -r ~/.ivy2/local || echo no publish local to remove

Changed files
  engine/src/org/pentaho/di/job/JobMeta.java
  engine/src/org/pentaho/di/trans/TransMeta.java
  engine/test-src/org/pentaho/di/job/JobMetaTest.java
  engine/test-src/org/pentaho/di/trans/TransMetaTest.java

Newly Fixed Tests:
org.pentaho.di.core.logging.MetricsPainterTest.testDrawTimeScaleLineInfinityLoop:
:large_blue_circle: java.lang.Exception
java.lang.Exception: test timed out after 10000 milliseconds
	at java.lang.ClassLoader.findBootstrapClass(Native Method)
	at java.lang.ClassLoader.findBootstrapClassOrNull(ClassLoader.java:1015)
	at java.lang.ClassLoader.loadClass(ClassLoader.java:413)
	at java.lang.ClassLoader.loadClass(ClassLoader.java:411)
	at sun.misc.Launcher$AppClassLoader.loadClass(Launcher.java:335)
	at java.lang.ClassLoader.loadClass(ClassLoader.java:357)
	at java.lang.Class.getDeclaredMethods0(Native Method)
	at java.l

Unit test coverage change
These statistics help you identify how your changes have affected the coverage of the following files. If a file is not in this list, then its coverage was not affected by your changes. To get some help interpreting these metrics, please refer to Jacoco's documentation.
org.pentaho.di.core.auth.core.impl.DefaultAuthenticationConsumerFactory

Branch Change: -7.14%:small_red_triangle_down:
Complexity Change: -7.69%:small_red_triangle_down:

org.pentaho.di.core.logging.JobEntryLogTable

Branch Change:  + 1.52%
Complexity Change:  + 1.82%
Instruction Change:  + .11%
Line Change:  + .76%

org.pentaho.di.core.logging.JobLogTable

Complexity Change:  + 2.53%
Instruction Change:  + .98%
Line Change:  + 2.07%
Method Change:  + 5.88%

org.pentaho.di.job.entries.sql.JobEntrySQL

Instruction Change: -1.64%:small_red_triangle_down:
Line Change: -1.95%:small_red_triangle_down:

org.pentaho.di.job.Job

Branch Change:  + 3.20%
Complexity Change:  + .38%
Instruction Change:  + 2.27%
Line Change:  + 1.74%
Method Change:  + .72%

org.pentaho.di.job.JobMeta

Branch Change:  + 2.13%
Complexity Change:  + 2.24%
Instruction Change:  + 1.68%
Line Change:  + 1.35%

org.pentaho.di.repository.kdr.KettleDatabaseRepositoryCreationHelper

Branch Change:  + 1.64%
Complexity Change:  + .69%
Instruction Change:  + 2.43%
Line Change:  + 3.70%

org.pentaho.di.trans.steps.memgroupby.MemoryGroupByMeta

Branch Change: -1.18%:small_red_triangle_down:
Complexity Change: -1.35%:small_red_triangle_down:

org.pentaho.di.trans.steps.replacestring.ReplaceStringMeta

Instruction Change:  + .07%

org.pentaho.di.trans.steps.textfileinput.TextFileInputMeta

Branch Change: -.53%:small_red_triangle_down:

org.pentaho.di.trans.TransMeta

Branch Change:  + .69%
Complexity Change:  + .71%
Instruction Change:  + .35%
Line Change:  + .33%


listen for click events on $curtain

hi i would like to listen for click events on the curtain element and then close the curtain when clicked.

Any advice for implementing this? I can submit a PR in no time

Hey! You should be able to just do $('#dimbackground-curtain').click(...) to attach the click listener.

It's the only package I could find that does something like this! I really wanted a react component package, but I was going to settle for making a custom react wrapper around this jquery package to start. Thanks again!


Adding note about pricing tier of Text Analytics

If change pricing tier of Text Analytics resource Standard(S) to Free(F0), the existing knowledge base associated with that resource will no longer be displayed on QnAPortal.
A note about pricing tier is needed to avoid annoying users.
https://azure.microsoft.com/en-us/pricing/details/cognitive-services/text-analytics/

@noueh : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@noueh : Thanks for your contribution! The author(s) have been notified to review your proposed change.

#sign-off

@mrbullwinkle: I'm sorry - only the author of this article, @nerajput1607, can sign off on your changes. But we do have an exception process - if you are on the Microsoft content or product team for this product area, you can ask the PR review team to review and merge it by sending mail to the techdocprs alias.

@ktoliver would you be able to merge this PR, it is ready to go. Thank you!


package currently failing on snowflake creatives.base_url

There have been some alterations in stitch.base.stitch_fb_ad_creatives where the redshift adapter names something base_url but the naming is not the same for snowflake

Issue closed to prepare for Repository Archival


2.0-dev branch: why does mz.pack drop the label column?

Due to #273, we tried the 2.0 branch.
Due to #444, we are trying out the 2.0-dev branch, as 2.0 is not working.
In 2.0-dev, only sandbox.ipynb is still valid.
I'm mystified about this line:
train_pack.relation['label'] = np.random.randint(low=0, high=2, size=len(train_pack.relation))
Why can't mz.pack retain any label that is present?

I'm sorry about your confusion, the sandbox.ipynb has the minimum explanation and 2.0-dev is still under active development. This random int assignment was not intended to initialize label. The original labels in the train_pack should work but we had a little problem debugging metrics, so I tried some random value to check if metrics are behaving correctly.

Yes, your are right in that mz.pack doesnt affect the label, thanks!


User sent to fresh new page upon contact form submission and success message being displayed

Fixes Issue #1057
I added a feature without back end with which user would be sent to a fresh new page on clicking Send button where the message is displayed as "Thank you We received your submission , Return ". Also on clicking to Return button of that fresh new page, user is redirected to home page.
https://user-images.githubusercontent.com/61961107/122763914-81e6c000-d2bc-11eb-9e8f-0447e8942d48.mp4

See why deploy is failing rest the ui looks great.

Hey @anushbhatia kindly close this PR as I am thinking of Re-cloning the whole project and creating the new PR

Cool


Access to Service Tier Settings

Hi,
this might be a somewhat ...uninformed... question - so please forgive my lack of experience using PowerShell:
Is there any way to access the settings of the Service Tier inside a container? What I want to do is primarily activate th In-Client Designer and maybe also play around with other settings.

Reading the containers customsettings.config from PowerShell on the docker host can be done with:
$config = docker exec -it test powershell "Get-Content -Path 'C:\Program Files\Microsoft Dynamics NAV*\Service\CustomSettings.config'"
or using the navcontainerhelper
$session = Get-NavContainerSession -containerName test
$config = Invoke-Command -Session $session -ScriptBlock {
Get-Content -Path 'C:\Program Files\Microsoft Dynamics NAV*\Service\CustomSettings.config' | Out-String
}

Many thanks!
W1 designer works as expected.
As for fiddling with ST Settings: In my case where I do not even want to script things I found that I can also use the shortcut to the container PowerShell You conveniently provide and then use the NAV cmdlets. In this case
Get-NAVServerConfiguration

to inspect and for example
Set-NAVServerConfiguration -ServerInstance NAV -KeyName EnableTaskScheduler -KeyValue true

to change.


code.tizen.org - Button example - button not visible

Open https://code.tizen.org/demos?path=1.0%2Fexamples%2Fwearable%2FUIComponents%2Fcontents%2Fcontrols%2Fbutton%2Ficon-button.html
Observe:
no button
Expected:
https://samsung.github.io/TAU/examples/1.0/examples/wearable/UIComponents/contents/controls/button/icon-button.html

The issue is cause by not standard reference do icon source. All resources are downloaded by "wget" tool but, the wget follows only by known links "href" or "src". In this case icon source is indicated as:
<button **data-icon**="../../../css/images/gallery_more_opt_save.png" data-middle="true" data-style="nobg">

I found workaround for this issue by style.css.
We can add not used class to app style.css like:

/* --- empty class for download project files by wget */
.wget-download {
	background-image: url(./images/gallery_more_opt_save.png);
	background-image: url(./images/b_slider_btn_bg.png);
}

This is visible for wget but not used by app.

@lslachciak
I prepared workaround as solving this issue.
Different way to solve this issue is modification of demo.js route in WATT.
in line: 142
        // Download requested demo to the project folder.
        (project, projectPath, callback) => {
          const tauExamplesHost = config.get('TAUExamplesHost');
          const samplePath = req.query.path;
          if (!tauExamplesHost || !samplePath) {
            return callback(`Could not resolve path: ${tauExamplesHost}${samplePath}`);
          }

          const sampleUrl = new URL(samplePath, tauExamplesHost);
          // check if url is valid, spider option doesn't download anything
          exec(`wget --spider ${sampleUrl}`, (error, stdout, stderr) => {
            if (error) {
              console.log(error);
              return callback(`Could not download sample from ${sampleUrl}`);
            }
            else {
              // Define number of unnecessary directories to be omitted while downloading.
              const numDirsToCut = sampleUrl.pathname.match(/TAU\/examples\/+.+\/examples\/mobile|wearable\/UIComponents/g) ? 6 : 0;
              exec(`wget --recursive --page-requisites --convert-links --no-host-directories --cut-dirs=${numDirsToCut} --directory-prefix ${projectPath} ${sampleUrl}`, (error, stdout, stderr) => {
                if (error) {
                  // we don't return here because there may be samples with not existing resources
                  console.log(error);
                }
                callback(null, project, projectPath);
              });
            }
          });
},

works good


Update UG and minor error fix for SortCommand

Added exception handling for when tasks lists is empty and also updated DG

Great job updating the SortCommand, good use of SLAP and defensive programming has been implemented. LGTM!


Don't follow symlinks when finding jdk jars

Following symlinks is leading to FileSystemLoopExceptions in some cases when finding jdk jars or jmods for the javasrc type solver. We shouldn't need to follow these in this case, so this just disables that. This could mean that an explicit jdk path argument must be given if the frontend is invoked via a symlinked java distribution.

Ah, missed that. Closing in favour of https://github.com/joernio/joern/pull/3871


Fix links in contents so they properly link to sections in README.md.

@arqex really appreciate your work on freezer!
I'm a newbie when it comes to pull requests, I'm not sure what "Environment variables not set" means or how to fix that in the Travis-CI build?

@YPCrumble
Sorry I didn't get in touch before. Thanks for the PR, I am not a travis-ci expert either so I can't say what was that Environment variables not set.
Anyways, the changes of your PR was included in anybody else PR so there is not need to merge this one.
Thanks very much, your collaboration is much appreciated.
Cheers


Restructure shared functions and integrate duplicated functionality in draft splash submodule.

Is your feature request related to a problem? Please describe.
The draft splash module (#69) has a bunch of functions that overlap substantially with existing functions in the pmodel module. The two sets of functions need to be reconciled but also relocated - they are general utility functions that are shared across modules, so logically are better placed outside those specific science modules.
Describe the solution you'd like
Create a pyrealm.core module that incorporates these functions in sensible groupings. That probably also brings in the hygro and utilities modules, to give pyrealm.core, pyrealm.const and then particular science/model based modules like the pmodel, tmodel, splash etc.
Describe alternatives you've considered
There are enough of these functions that just having small modules for each one would make a more cluttered namespace. Gathering them as submodules under a single module seems cleaner.

Possibly separate the different constants classes out so that there are core constants for the core utilities and then specific constants classes for different science submodules.

@MarionBWeinzierl to create core module, add const and hygro and utilities.
@davidorme to look at tmodel, pmodel, splash etc

@davidorme is going to break this up into a checklist or sub issues

I am wondering whether it would make sense to have two separate core modules for physics-specifics calculations such as in hygro, and general utilities. Maybe a tree-like module structure with core as root, then physics and utilities, and then whatever fits under those two subheadings? Can the constants be divided into those two groups, too, or are they all physics (I just find physics constants, looking briefly through it)?

I don't think we need to make it tree-like. That does make import names a bit longer and I'm not sure we need to differentiate beyond core and science modules. I think we make it flat for now, but maybe we end up grouping them if the core grows.

Yes, it is.


it crash every time i try to change the setting. help plz

when im in game and i try to change the setting cause i dont want the production queue, it keep crashing and i cant do anything about it or when i want to use wasd but it keep crashing.
sorry for bad english.

Are you using any other mods?

ok, i finally found out the problem after two hour. i think the problem is that it crash when i use the map inland sea. i try default map which is continents and it work but not inland sea

and also the original quick ui does not work as well. when i try to download it and add it to mod and dlc it does not show up in my civ6.

The original QUI hasn't been updated since October and there's likely no chance whatsoever that it would work with the current game version. Just to confirm, you have no other mods beside CQUI installed, correct?

i use improved water yield and low warmonger but i also try without it and it still crash. i even try only using chaos quick ui for all map and only inland sea is the one that crash

I've been hearing about crashing on the inland sea map type quite a bit recently, but have been unable to reproduce the issue, it would be very helpful if you could provide a savefile that consistently crashes for us to investigate

sure but it basically a default game with only the map type change to inland sea at turn 1

how do i give u my savefile?

It's under "Documents\My Games"

it say we don't support that file type.

That's if you're trying to open the file.  All you need is to open the folder with the save file, click once on the save, and copy it (ctrl+c) into the text box on here.

Right, well this topic is staling and I personally don't see any added value in keeping it open any longer


Create FreeCad.gitignore

New

[x] Template - New .gitignore template
[ ] Composition - Template made from smaller templates
[ ] Inheritance - Template similar to an existing template
[ ] Patch - Template extending functionality of existing template

Details
The proposed gitignore is a combination of the one I use myself, and one created by the developers.

Hello, @scrouthtv! Thank you for taking the time to contribute to Gitignore! I have two small questions:

https://github.com/FreeCAD/FreeCAD-library/blob/master/.gitignore#L6 there is also a Private folder on FreeCAD .gitignore. Should we also add that?
The access to your .gitignore is restricted, I can't access it by URL you provided. That's alright though

Hey there!

I don't know anything about a Private folder related to FreeCAD, and searching it on the internet, doesn't give any results either. That's why I left it out.
I just checked, that repo is private :/ Anyway, it's just

*.fcstd1
*.FCStd1


ChefDK#456: Fix ChefDK installation on OS X El Capitan

This is the same fix applied to chef on
https://github.com/chef/omnibus-chef/pull/439

Hi. I am an automated pull request bot named Curry. There are commits in this pull request whose authors are not yet authorized to contribute to Chef Software, Inc. projects or are using a non-GitHub verified email address. To become authorized to contribute, you will need to sign the Contributor License Agreement (CLA) as an individual or on behalf of your company. You can read more on Chef's blog.
Non-GitHub Verified Committers
There are 1 commit author(s) whose commits are authored by a non-GitHub verified email address. Chef will have to manually verify that they are authorized to contribute.
Please sign the CLA here.

looks like your email address from the commit isn't one that github recognises, @cassianoleal

Hi. Your friendly Curry bot here. Just letting you know that all commit authors have become authorized to contribute. I have added the "Signed CLA" label to this issue so it can easily be found in the future.

Thanks, that was it! :smile:

:+1:
/cc @chef/client-core

thanks :+1:


prune deprecated peer event port 7053

code hygience
Signed-off-by: DavidLiu<EMAIL_ADDRESS>

CI is not happy!

CI is not happy!

Noted and it seems interesting.

I've re-runned the test, the error seems to be caused by async problem


∃-even-odd

If I try to do the same style of proof you have done for ∃-even and ∃-odd as follows:

postulate even-lemma-2 : ∀ (n : ℕ) ->  n + (n + zero) + 1 ≡ n + suc (n + zero)

∃-even : ∀ {n : ℕ} → ∃[ m ] (    2 * m ≡ n) → even n
 -- {-# NON_TERMINATING #-}
∃-odd  : ∀ {n : ℕ} → ∃[ m ] (2 * m + 1 ≡ n) →  odd n
∃-even ⟨ zero , refl ⟩ = even-zero
∃-even ⟨ suc m , refl ⟩ = even-suc (∃-odd ⟨ m , even-lemma-2 m ⟩)
∃-odd ⟨ n , refl ⟩ rewrite +-comm (n + (n + zero)) 1 = odd-suc (∃-even ⟨ n , refl ⟩)

Then the termination checker is unhappy. The exercise should probably indicate a different way forward or explain that it might be necessary. Unless you had something else in mind for the solution where the termination checker is less agitated.

I should note that tomjack on the #agda irc pointed out that one can make the termination checker happier by using a curried version for the definitions as I have done here.

Thanks. Do you want to draft some appropriate text?


Update for accuracy and formatting

Doc is out of date and needs to be updated for current information and updated docs structure

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 5e68254e-a6e7-d7ef-287c-51ad10c52eef
Version Independent ID: 5cb8c4a0-683d-5205-5214-02f5bcf8386e
Content: Azure CNI networking in Azure Kubernetes Service (AKS) overview - Azure Kubernetes Service
Content Source: articles/aks/azure-cni-overview.md
Service: azure-kubernetes-service
Sub-service: aks-networking
GitHub Login: @asudbring
Microsoft Alias: allensu

@chasewilson
Thanks for your feedback! We will investigate and update as appropriate.

#reassign:schaffererin

You can reassign this to me. @schaffererin or co-assign it to me if that's better for you. Just creating trackign for items I need to do.

#reassign:chasewilson

Hey @chasewilson, just wanted to check in to see if it's ok to close out this GitHub issue?

Unfortunately not yet, this is to track a second wave of updates after the split out.

Thank you for your dedication to our documentation.
Unfortunately, we have been unable to review this issue in a timely manner. We sincerely apologize for the delayed response. We are closing this issue and creating an internal work item to incorporate your suggestion as time allows. If you feel that the problem persists, please respond to this issue with additional information.
Please continue to provide feedback about the documentation. We appreciate your contributions to our community.
#please-close


Add login functionality

The app should allow users to login with their email address and password to a Traccar server. It would be great if the server URL was customisable.

@tananaev is it OK if I work on this?

Thanks. Commented on the PR.


Add PlaceholderAPI support

TODO: find a way to make it faster

Hello, working on the review of it :)


[AutoPR cognitiveservices/data-plane/ComputerVision] [Computer Vision] Add read to CV OCR API.

Created to sync https://github.com/Azure/azure-rest-api-specs/pull/5314

Build output:

Build output:

This PR has been merged into https://github.com/Azure/azure-sdk-for-java/pull/3039


No operator for "does not contain data"

There is no operator to query on fields that do not contain data, or if there is, it's not clear on this page what the operator is.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: a077afea-0218-d8e3-6112-95ea4bb04501
Version Independent ID: 00ba7831-fe82-4f86-2864-311a7b8375b9
Content: Query Data using the Web API (Common Data Service) - PowerApps
Content Source: powerapps-docs/developer/common-data-service/webapi/query-data-web-api.md
Service: powerapps
GitHub Login: @JimDaly
Microsoft Alias: jdaly

There are several examples where the null keyword is used to determine when a field contains no data. Is that different from what you are looking for?

Thanks for your reply.  I can now see null in the examples but there wasn't
a specific mention of it outside of the examples so wasn't immediately
obvious.
But thanks for responding. I have the answer I need.
Cheers
Steven
On Tue, 4 Feb 2020, 18:53 Jim Daly<EMAIL_ADDRESS>wrote:

There are several examples where the null keyword is used to determine
when a field contains no data. Is that different from what you are looking
for?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/MicrosoftDocs/powerapps-docs/issues/996?email_source=notifications&email_token=AIEU3UULGVTWFSM4WQBC7B3RBG2RNA5CNFSM4KPSIJYKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEKYYQIQ#issuecomment-582060066,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AIEU3UV7AA4GPKYFBZ453QTRBG2RNANCNFSM4KPSIJYA
.

@stevenfayers  Thanks for the feedback,.


Building a Spotify Playlist Recommendation Engine from scratch

Proposed title of article
Building a Spotify Playlist Recommendation Engine from scratch
Introduction paragraph (2-3 paragraphs):
Suppose you are browsing through Netflix to watch a TV show and you cannot decide which show to watch, or you are surfing through Spotify and not able to decide which song to listen to. There are many more instances where we have abundant data, and we cannot decide what we need. This is where the Recommendation Systems come into the picture. Recommender systems are designed to recommend things to the user based on many different factors. These systems predict the most likely product to which the users are most likely to purchase and are of interest.
In this blog, we will design a Recommendation Engine from scratch using content-based filtering that will take the user's current playlist as input and recommend new songs according to the current playlist. First, we will start with the basics of recommendation systems, their types, the mathematics behind the recommendation systems, and then dig deeper into its programming aspects.
Key takeaways:

Understanding the working of Recommendation Systems
Types of Recommendation Systems
Mathematics behind Recommendation Systems
Implementing a Spotify Recommender Engine from scratch using Python

References:
N/A
Templates to use as guides

How To Guide Template
Software Review Template
Tutorial Template

Good afternoon and thank you for submitting your topic suggestion. @tanmay69
Your topic form has been entered into our queue and should be reviewed (for approval) as soon as a content moderator is finished reviewing the ones in the queue before it.

Great topic 🚀 , make sure it matches the following:

Adds value beyond what is in the official docs and what is covered in other blog sites.
To avoid potential article closure, it should not overlap with existing EngEd articles or incoming topic suggestions.

Please reference any relevant EngEd articles in yours and build a unique project - Approved. @tanmay69


Constitutional Chain: chain parameter

Fixed issue where could not use a SequentialChain as the base chain input to a ConstitutionalChain because it required an LLMChain, when any chain should do since it just needs to call the run method on the base chain.
Fixed issue by changing base chain from LLMChain to Chain.
Happy to do more if necessary!
See below issue description:
Code to create a ConstitutionalChain from an LLM:
 @classmethod
    def from_llm(
        cls,
        llm: BaseLanguageModel,
        chain: LLMChain,
        critique_prompt: BasePromptTemplate = CRITIQUE_PROMPT,
        revision_prompt: BasePromptTemplate = REVISION_PROMPT,
        **kwargs: Any,
    ) -> "ConstitutionalChain":
        """Create a chain from an LLM."""
        critique_chain = LLMChain(llm=llm, prompt=critique_prompt)
        revision_chain = LLMChain(llm=llm, prompt=revision_prompt)
        return cls(
            chain=chain,
            critique_chain=critique_chain,
            revision_chain=revision_chain,
            **kwargs,
        )

It requires an LLMChain.
SimpleSequentialChain doesn't inherit from LLMChain. It inherits from Chain.
class SimpleSequentialChain(Chain, BaseModel):
    """Simple chain where the outputs of one step feed directly into next."""

    chains: List[Chain]
    strip_outputs: bool = False
    input_key: str = "input"  #: :meta private:
    output_key: str = "output"  #: :meta private:

Therefore we cannot pass a SimpleSequentialChain to the ConstitutionalChain.
This disrupts the workflow where we create a pipeline and want to pass it to a constitutional chain for checks.

Fair, you're right!
The ConstitutionalChain assumes that it has access to the prompt of its input, because it passes it as a kwarg to run when it runs self.critique_chain.run:
            raw_critique = self.critique_chain.run(
                **input_prompt=input_prompt**,
                output_from_model=response,
                critique_request=constitutional_principle.critique_request,
            )
            critique = self._parse_critique(
                output_string=raw_critique,
            ).strip()

            # Do revision

            revision = self.revision_chain.run(
                input_prompt=input_prompt,
                output_from_model=response,
                critique_request=constitutional_principle.critique_request,
                critique=critique,
                revision_request=constitutional_principle.revision_request,
            ).strip()
            response = revision

It uses more than just the response; it also uses the prompt input.
If you give me some guidance for your preferred solution, I'd be happy to make a separate class which work on chains as a whole or adopt some other solution!

An alternative idea would be just to add the concept of a head to a compositional chain like SequentialChain and ConstitutionalChain just acts on the head.

@hwchase17 @chutcheson relatively new to LangChain syntax and design, but here is what I was thinking.
Option 1: Treat ConstitutionalChain as a data flow element, meaning it can be instantiated with other chains like Retrieval chains, LLChains etc. on the lines of @chutcheson thinking.
from langchain.chains.constitutional_ai.base import ConstitutionalChain
from langchain.chains import SequentialChain
from langchain.chains import LLMChain

qa_chain = RetrievalQA.from_chain_type(llm=OpenAI(), chain_type="stuff", retriever=docsearch.as_retriever())

principles = ConstitutionalChain.get_principles(["illegal"])
constitutional_chain = ConstitutionalChain.from_llm(
    chain= **qa_chain**
    constitutional_principles=principles,
    llm=OpenAI(temperature=0),
    verbose=True,
)

Option 2: Draw a distinction between Data flow and Control flow chains. Control flow chains decide the logical flow of the chains/pipelines e.g. SequentialChains, RouterChains etc. based on some decisions or logical operations.
This will help build more complex flow / pipelines, where output of one chain is the input to constitutional or moderation chains.
from langchain.chains.constitutional_ai.base import ConstitutionalChain
from langchain.chains import SequentialChain
from langchain.chains import LLMChain

qa_chain = RetrievalQA.from_chain_type(llm=OpenAI(), chain_type="stuff", retriever=docsearch.as_retriever())

principles = ConstitutionalChain.get_principles(["illegal"])
constitutional_chain = ConstitutionalChain.from_llm(
    chain= LLMChain(llm=OpenAI(temperature=0))
    constitutional_principles=principles,
    llm=OpenAI(temperature=0),
    verbose=True,
)
constitutional_chain.input_key = "output_text"
sq = **SequentialChain(chains=[qa_chain, constitutional_chain])**

What are your thoughts? In the meanwhile, are there any suggested workarounds for this scenario.

sounds like this isn't quite the approach we want to take. closing for now, let me know if i'm missing anything!


187121501 currency conv new conversion

[Pivotal Tracker Link]

What this PR does:

This pull request fixes the view for when admin creates new currency conversion so that from_currency is based on the default conference currency and to_currency is a dropdown of a static list of currencies we can convert to defined in the currency_conversion model.
Who authored this PR?

@tiffanylamm
How should this PR be tested?
The specs and features test that the feature flow is working as intended and that validations are done correctly. Edgecases were taken into consideration like duplicate convertions, incorrcect conversion rates, and no conference currency being set.
Are there any complications to deploying this?
No
Checklist:

[x] Has this been deployed to a staging environment or reviewed by a customer?
[x] Tag someone for code review (either a coach / team member)
[ ] I have renamed the branch to match PivotTracker's suggested one (necessary for BlueJay)

seems like it's grabbing the from currency using tickets rn I'm guessing once user preferred currency is implemented it can be changed.
lgtm you can go ahead a merge and submit a pr to snap-cloud/snapcon/main


Fix cairo 1.18.0 mac crash, upgrade certifi, always use our libs when zip-installed

https://cmu-cs-academy.atlassian.net/browse/CSA-1052
The following code crashes on Mac when run with:

brew-installed cairo 1.18.0
pygame==2.5.2 (and others)
pycairo==1.25.0 (and others)

import cairo
fontCtx = cairo.Context(cairo.ImageSurface(cairo.FORMAT_ARGB32, 0, 0))
fontCtx.text_extents('Hello, world!')

import pygame
pygame.init()

test_image_gen is failing for pip-based installs on Mac because the inspector labels aren't bold, nor is the "Exception! App stopped!" error.

The inspector looks right to me when I run it outside of test_image_gen, and this is a big improvement over the current state of affairs where labels are unusable when using cairo 1.18. But maybe we should see what's going wrong with the tests too.

Reported to pygame here: https://github.com/pygame/pygame/issues/4060

Ready for one more look @austin-schick

Cairo isn't letting us draw bold/italic text on Mac, so that's why the CI build is still failing. https://github.com/pygobject/pycairo/issues/351


Investigate using qooman/actions--context to get github_job_id instead of using the cursed uuid infrastructure

Investigate using https://github.com/qoomon/actions--context/tree/main for getting github job ID to get over the matrix and subjob issue

This doesn't look very promising because we use custom names for jobs: https://github.com/tenstorrent/tt-metal/actions/runs/10562454675/job/29260453934
We can write up a more detailed issue for the author later.


CB-4808 AWS - Reduce number of IAM calls in AwsIDBrokerAssumeRoleValidator

Previously was trying to simulate each role independently when it wasn't necessary. This is still disabled until CB-4886 is complete, but its a step in the right direction.

Rebased on current master no other changes. Not sure why spotbugs failed - when went to check Jenkins job was already gone.

Rebased to have tests trigger again. Previous test failure was unrelated to this change.

Rebased again to get latest test changes hopefully should be good this time.

@sodre90 can you review? Thanks!


Cannot use custom annotations on the consumer side

@Target({ElementType.METHOD})
@Retention(RetentionPolicy.RUNTIME)
@Inherited
public @interface CustomMqMonitor {
    String topic() default "";
    String type() default "";
}

@Slf4j
@Component
@Aspect
public class MetricsAspect {

    private CustomMqMetric customMqMetric;

    @Autowired
    public MetricsAspect(CustomMqMetric customMqMetric) {
        this.customMqMetric = customMqMetric;
    }

    @Pointcut("@annotation(com.been.cloud.stream.config.CustomMqMonitor)")
    public void pointcut() {}

    @Around("pointcut() && @annotation(monitor)")
    public Object around(ProceedingJoinPoint joinPoint, CustomMqMonitor monitor) throws Throwable{
        long beginTime = System.currentTimeMillis();
        MethodSignature methodSignature = (MethodSignature) joinPoint.getSignature();
        Method method = methodSignature.getMethod();
        Object[] requestParams = joinPoint.getArgs();
        Object result;

        log.info("start execute:{}", method);
        try {
            result = joinPoint.proceed();
        } catch (Exception e) {
            log.error("MetricsAspect around exception", e);
            customMqMetric.metricError(monitor, "123");
            throw e;
        }
        if(!ObjectUtils.isEmpty(result)){
            customMqMetric.metricSuccess(monitor, "123");
        }
        long cost = System.currentTimeMillis() - beginTime;
        log.info("MetricsAspect cost:{} millis,end execute:{}", cost, method);
        return result;
    }

}

 @Bean
    @CustomMqMonitor(topic = "member.member_slice", type = TYPE)
    public Consumer<School> memberMemberSlice() {
        return obj -> {
            log.info("kafkaMemberReceiver input message: {}", JSONUtil.toJsonStr(obj));
            if (RandomUtil.randomInt(1, 10) > 5) {
                int i = 9 / 0;
            }
        };
    }

When the program starts, it will be intercepted by AOP. But when receiving a message, it cannot be intercepted
@onobc
I want to write custom metrics based on Prometheus。but custom annotation does not take effect

@CustomMqMonitor(topic = "member.member_slice", type = TYPE)
The consumer has used a custom annotation。
Program custom aop is no problem，i have tested

Hi @cyuegit ,
I was pointing this out:

Note that the function lambda that gets returned from the memberMemberSlice bean method is not annotated w/ the custom annotation but rather the bean method is.

but I will explain w/ a code sample.
Let's consider a simple bean rather than a SCS consumer function.
@Bean
@CustomMqMonitor(topic = "foo.topic")
public Foo fooBean() {
  return new Foo();
}

static public class Foo {
  public void doThing() {
    System.out.println("++++++ foo.doThing()");
  }
}

Let's also assume we have some method to invoke the foo bean (maybe MVC controller):
@Autowired
private Foo fooBean;

public void doSomethingWithFoo() {
  fooBean.doThing();
}

When doSomethingWithFoo is invoked, it does not get intercepted. This is similar to how the consumer invocation does not get intercepted. It is only intercepted on bean creation because that is when the method annotated w/ @CustomMqMonitor is invoked.
Now, if you adjust the example above slightly as follows, the invocation will be intercepted.
@Bean
public Foo fooBean() {
  return new Foo();
}

static public class Foo {

  @CustomMqMonitor(topic = "foo.topic")
  public void doThing() {
    System.out.println("++++++ foo.doThing()");
  }
}

Likewise, if you instead create a consumer class and mark the accept method w/ the annotation then it will also be intercepted.
@Bean
public Consumer<String> memberMemberSlice() {
  return new MyConsumer();
}

static class MyConsumer implements Consumer<String> {

  @Override
  @CustomMqMonitor(topic = "some.topic")
  public void accept(String s) {
    System.out.println("********* received " + s);
  }
}

Of course, the goal is to not get rid of the beauty of the lambda consumer and start writing consumer impls everywhere. However, I wonder if there is something you can tweak on your aspect impl to target the "accept" method of the consumer?

My current solution is similar to yours. But it doesn't feel too elegant

My current solution is similar to yours. But it doesn't feel too elegant

@cyuegit I was not suggesting my comments as a workaround but more continuing the discussion to see if we can get to an acceptable solution. If you are satisfied where you ended up that is fine too.


Use testcontainers instead of docker-java

As a plugin maintainer
In order to have less maintenance effort
I want the plugin to spin up the DB containers using testcontainers instead of docker-java directly

Done with #12


KML feature data

Hi,
I'am looking for reading data from KML.
For example i have this inside my KML file:
< ExtendedData>< SchemaData schemaUrl="#simp_qgis6">
< SimpleData name="ID">1< /SimpleData>
< SimpleData name="level">0< /SimpleData>
< SimpleData name="dept">13< /SimpleData>
< /SchemaData>< /ExtendedData>
I saw that in the Javascript API there is this function : featureData
So i tried this:
kmlOverlay1.on(plugin.google.maps.event.OVERLAY_CLICK, function(overlay1, latLng) {
alert(overlay1.featureData.dept);
});
But didn't work.
Any idea ?

---
Want to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/19368905-kml-feature-data?utm_campaign=plugin&utm_content=tracker%2F637500&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F637500&utm_medium=issues&utm_source=github).

This plugin supports only the below tags:
-style
-stylemap
-linestyle
-polystyle
-linestring
-outerboundaryis
-placemark
-point
-polygon
-pair
-multigeometry
-networklink
-link
-key
-styleurl
-color
-width
-fill
-name
-description
-icon
-href
-coordinates


Fix wps inputouput metadata

this patch provides the following:

adding a Metadata class to parse ows:Metadata.
parses ows:Metadata for the Process and the InputOutputs.
fixes parsing of input/output reference.
fix: resets metadata before parsing capabilities.
pep8 where code was changed.

Hi all!
I'm using OWSlib to manage wps and I was looking for this feature. Any plans to merge this feature on the master branch?
Thanks! bye!

There is currently one wps test failing due to the merge of PR #420:
tests/doctests/wps_request3.txt::wps_request3.txt FAILED

It is not caused by this PR.


Status bar hidden

I'm updating an old Ionic 5, cordova app to ionic 7.4.x/cordova 12.x. Both have the<EMAIL_ADDRESS>dependency but I have found a difference in the behaviour of the plugin. In the old version of the app, the navigation bar was hidden but the status bar was visible in any moment (except during the splash screen).
If I uninstall the plugin, both the status bar and the navigation bar are visible. Once the plugin is installed the bars remain hidden and the webview uses all the screen. Would it be possible to change this behaviour somehow? Am I missing something?
Thanks in advance.

Hi @JaviManteiga,
The difference in behaviour is most likely related to the target version of the Android SDK, but you should be able to match the behaviour of the original app using setSystemUiVisibility method:
// Custom full screen mode
// See https://developer.android.com/reference/android/view/View.html#setSystemUiVisibility(int)
AndroidFullScreen.setSystemUiVisibility(AndroidFullScreen.SYSTEM_UI_FLAG_FULLSCREEN | AndroidFullScreen.SYSTEM_UI_FLAG_LOW_PROFILE, successFunction, errorFunction);

We've seen similar issues in the past on iOS and one workaround was to put the web view behind the status bar, using something like cordova-plugin-statusbar, then offset the page using CSS

I will try something in CSS keeping in mind that It's not going to be a perfect solution due to the differences between devices in the Android ecosystem. In some of then a 20 px margin is enough and others need at least 35 px because of the frontal camera position.


Make use of gRPC metadatas to pass on Hook-Name.

Fixes #362

Thanks for the PR! Is there a reason why we would want to have the hook name in the metadata instead of the protobuf payload? This would avoid splitting the data over multiple places. I could imagine a hookName prototype here or so: https://github.com/tus/tusd/blob/master/cmd/tusd/cli/hooks/proto/v1/hook.proto#L43

@Acconut I guess this is consistent with the HTTP implementation of hooks where the name of the hook is passed through an HTTP header. But I agree with you it would me much simpler to gather all the data at one place. So should we deviate from the HTTP implementation ?

Yes, that would be great!

Ok I'll update the PR


Add test cases for Event's CRUD

Add test cases for Event's CRUD:
Closes #129, closes #130, closes #171.

Codecov Report

Merging #232 into master will increase coverage by 4.22%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##             master     #232      +/-   ##
============================================
+ Coverage     63.47%   67.69%   +4.22%
- Complexity      632      666      +34
============================================
  Files           110      110
  Lines          2286     2294       +8
  Branches        279      282       +3
============================================
+ Hits           1451     1553     +102
+ Misses          719      607     -112
- Partials        116      134      +18

Impacted Files
Coverage Δ
Complexity Δ

...seedu/address/logic/commands/EditEventCommand.java
80.32% <100.00%> (+80.32%)
11.00 <5.00> (+11.00)

...ava/seedu/address/model/event/UniqueEventList.java
94.87% <0.00%> (+2.56%)
20.00% <0.00%> (+1.00%)

src/main/java/seedu/address/model/AddressBook.java
92.68% <0.00%> (+4.87%)
18.00% <0.00%> (+1.00%)

...rc/main/java/seedu/address/model/ModelManager.java
95.00% <0.00%> (+8.33%)
28.00% <0.00%> (+2.00%)

...in/java/seedu/address/logic/parser/ParserUtil.java
71.96% <0.00%> (+11.21%)
29.00% <0.00%> (+4.00%)

...du/address/logic/parser/AddEventCommandParser.java
76.92% <0.00%> (+76.92%)
3.00% <0.00%> (+3.00%)

.../seedu/address/logic/commands/AddEventCommand.java
78.57% <0.00%> (+78.57%)
6.00% <0.00%> (+6.00%)

...edu/address/logic/commands/DeleteEventCommand.java
92.30% <0.00%> (+92.30%)
6.00% <0.00%> (+6.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7edc885...6718e33. Read the comment docs.


Defect: Missing Lab 4 Repair Section Validation

Defect
The repair section for the second part of the exercise of Lab 4 does not check if the user actually made any repairs and allows the user to continue playing the game even if they did not make any changes.
This is the repair section for the second part of Lab 4 that needs to be filled out in order for the user to continue:

(on page Lab4/Exercise/CodeChangeBlocks#)
Here is a screen recording showing that when no changes are made during the repair section, you can still click the "Update" button and continue playing the game:
https://user-images.githubusercontent.com/54957497/222180569-744cbfc7-c7bb-469d-ae4a-03fb2f214ce5.mov
Possible Fixes/Resources
The two other repair sections in Lab 4 implement some validation that prevents the user from continuing the game unless they make changes in the repair section. We might be able to reuse this logic for the second part of Lab 4 repair section.

Acceptance Criteria

[ ] The user cannot continue playing the game unless they have filled out the repair section
[ ] An error message appears indicating to the user that they did not fill out the repair section

Updated the tag based on the error as well. Take a look.
https://user-images.githubusercontent.com/111752403/224447246-e770c5fc-4d39-4bf1-8cf9-2bf89a156672.mov

is this resolved? @dm9965


svkirans || Project to demo Hexagonal architecture in Java

Evaluation article

closing as per instructions in the email.


New fix after run rector

after I update packages locally new rules was applied.

Thank you @eerison