connlib: remove Result return values from Callbacks

Currently, all callback methods can return an error. That is super convoluted because it creates a circular control-flow between the clients and connlib.
If a callback method would fail or throw an exception, then we currently just end up logging that and continue:
https://github.com/firezone/firezone/blob/d8df8d8b7e0b934d171b8e2cb29349cfcae73f46/rust/connlib/clients/shared/src/control.rs#L435
It would be much easier to understand to not hand this errors up and down the stack and either:

Log them directly in the client code
Panic in the client code

My preference would be for (2) because all the errors in the FFI layer should be statically asserted, i.e. if we get a function signature or something else wrong, then there isn't really any point in bubbling that up as a normal error.
Similarly, I don't think it is connlib's responsibility to handle exceptions that are thrown in the client code. Connlib has no idea how fatal such an error is. On the other hand, a client can either continue with normal operation or call disconnect if the Tunnel is otherwise broken.

cc @conectado Let me know if I am missing something.

Yeah, this makes sense, when we used to set routes individually there were certain cases where we should(we did at a time but we stopped doing that for simplicity) have failed and cases where we didn't, say at leas ipv4 or ipv6 should have succeeded. But we the current and future design this doesn't make sense anymore.
What this brings up, with current or future design is we need to think what the client would consider a "failed" state. For example given the routes we need to have at least one sentinel DNS route, but the client has not knowledge of what routes are sentinels. And there are other routes that have such consideration and not handling that could mean a degraded UX, i.e., someone starting Firezone and thinking it's working while it's not and preventing all internet connections.
But overall I think this would be a good change.

Unless I am misunderstanding the code we have today, then any error from the callbacks will only be logged because any Err returned from Tunnel::poll_next_event is just logged (now in the Eventloop and previously in the ControlPlane).
From that, I'd conclude that we can remove that return value now to make it more obvious that this can't really fail. For example, none of actual callbacks in Swift return a Result so those are always "successful". I am not sure what happens if the swift side throws an exception.
On Android, we do catch the exception and return it as an error but again, those are only logged in the Tunnel which is confusing to reason about.

What this brings up, with current or future design is we need to think what the client would consider a "failed" state. For example given the routes we need to have at least one sentinel DNS route, but the client has not knowledge of what routes are sentinels.

We can easily make the clients have knowledge about that though, right? We just need to send two different lists of routes and the clients can chose to disconnect the tunnel if the "critical" one fails.


image: immediately return when store.Writer trylock fails

another writer may hold the ref lock and waiting the boltdb lock to release it, there is a deadlock
fixes: #8790
Signed-off-by: jerryzhuang<EMAIL_ADDRESS>

if the maintainer accept my change, i will fix the ci later. thanks

+1 to remove the retry in local content plugin.

I think it probably makes more sense to handle the backoff and retry at a higher level as well. I wouldn't categorize it as a deadlock, but looks like unnecessary lock contention. We definitely don't want to keep the metadata lock open that long for any case.

@zhuangqh do you have time to update this?

default to no retry to reduce contention between ref lock and bolton lock. PTAL @fuweid @dmcgowan

ping @fuweid @dmcgowan updated, ptal thanks 😁

@zhuangqh please rebase to fix fuzz ci issue. thanks

@zhuangqh please rebase to fix fuzz ci issue. thanks

done


Better Touchscreen controls support

Description
Now there are 3 platforms that support touch input and are able to run Java Edition — Android/iOS via Pocket Java Launcher and Windows 10 installed on tablets. The number of such devices capable of running JE is growing, but so far the Java Edition does not have touch control support.
Solution
MidnightControls could implement several types of touch control of the game by adding the necessary buttons (or joysticks) with actions in the UI. And, possible, some additional controls.
Alternatives
Bedrock-ify  is a good base to request this feature, but I think that we need it outside bedrock-styled segment. Despite the fact that most touch-screen devices run on Android, this feature would be in demand on touch-screen laptops or tablets with Windows, whose owners don't necessarily want to "bedrockize" their Java Minecraft. In addition, the mod developer stated that he was not ready to work on touch controls in this issue, so, here I am.
Additional

My current Pojav controls settings

The basics of this feature were already implemented in LambdaControls, but never really finished.
I'll see what I can do about this in the future.

Although the readme says midnightcontrols has an experimental and bugged touchscreen support, is there actually any way to enable it?

The Touchscreen support was commented out in later versions of LambdaControls, I'll uncomment it soon

Added in v1.2.0 :)

I thought I might add just how buggy it is:
https://github.com/LambdAurora/LambdaControls/issues/42
https://github.com/LambdAurora/LambdaControls/issues/94
https://github.com/LambdAurora/LambdaControls/issues/86 says

The issue that I encountered with touchscreen is, well, on desktop it considers it a single pointer: the mouse, so you can't use multiple fingers at once, or you would need to access some very low-level, potentially breaking libraries to hack into the system to just make it work.
So yeah, not worth it imo.

This explains why the touch controls in LambdaControls and MidnightControls are so poor. I don't know why Minecraft doesn't handle touch events properly. It seems like something that only Mojang can fix. I don't know why though and it'd be great if someone could clarify that. I just read a bit about when Chromium added support for touch on Windows but I didn't understand it.

Yeah, now it is *a bit* buggy...
Tests with Pojav: https://youtu.be/JEEhm4H-Cs8

It likely clashes a bit with Pojavlauncher's built-in mouse emulation, I'm going to add an option to disable MidnightControls' mouse emulation in the next version.
As for the multitouch input on desktop OS's Lambda mentioned in the issues, I think the situation has improved a bit, at least on Linux using wayland (it works pretty well on Steam Deck after all I know).

Also, Mojang have added preliminary touch input support in a recent update (1.18 I think), maybe I could take advantage of that.

About the official "touchscreen mode" in Minecraft, I never understood what it did apart from toggling a boolean? I know this isn't the point of this issue, but is it supposed to do something?

It likely clashes a bit with Pojavlauncher's built-in mouse emulation

Maybe. Previously, lanbdaControls had problems working on it, but these problems were similar both on a tablet (win10) and on a phone with LambdaControls.
I will soon test the latest MidnightControls on my tablet.

About the official "touchscreen mode" in Minecraft, I never understood what it did apart from toggling a boolean?

It changes the logic of moving items through the inventory. Instead of...

press the item slot
release the slot
move your mouse
press the new slot
release the new slot
... you get
press the item
move the mouse
release the item
Not so convenient, actually. Especially on the touch screen. Ironically, this mode was called "touchscreen mode".

The touch controls remain terrible on Windows by the way. Spinning death. I couldn't press escape to free my cursor but I was able to just tap on close window. 😆

I had the opportunity to test it on a tablet. Unfortunately, it doesn't work properly at all.
https://youtu.be/tYRyEEzx3Es

@Motschen this might fix the touch issues https://github.com/Tungstend/TouchInjector

Вероятно, это немного противоречит встроенной эмуляции мыши Pojavlauncher, я собираюсь добавить опцию отключения эмуляции мыши MidnightControls в следующей версии. Что касается мультитач-ввода на Lambda настольной ОС, упомянутой в выпусках, я думаю, что ситуация немного улучшилась, по крайней мере, в Linux, использующем wayland (в конце концов, он довольно хорошо работает на Steam Deck).
Does this mean that this function should work in Linux?

Today I dreamed that I was playing Java Edition with a touchscreen... Just a fun fact :)

@Motschen this might fix the touch issues https://github.com/Tungstend/TouchInjector

Seems don't work either, installed it on a vanilla minecraft due to poor instructions , in the end the game still just rapidly spinning

Today I dreamed that I was playing Java Edition with a touchscreen... Just a fun fact :)

Your dreams have now become reality, with MidnightControls 1.9.0!
Even though multitouch is still not supported [yet ;) ], the touchscreen is now actually usable (tested on my Steam Deck in Desktop mode)

Just found this interesting project for Minecraft 1.8-1.12:
https://github.com/Aang23/MC-TouchControls
It relies on an external framework to achieve multitouch. Maybe it is possible to use the same approach?


Cyclic forcing

Right now forcing tables look like this:

note_id
time
precipitation
potential_evaporation

1
2020-01-01
2.0
1.0

1
2020-02-01
2.1
1.1

Many parameters are highly cyclical, typically yearly, but possibly with a different period. It is worth considering if and how we should support this. @Huite suggested using the same forcing timeseries schema, but adding an option like cycle = "year" (or month/day/...).
If we support this, it will be easier for users with cyclic data to prepare the right input, and input file sizes will be smaller. It does mean some extra complexity in the interpretation of timeseries, e.g. we'd need a TOML to be able to interpret it.
For parameters that have 2 values per year, one for summer and one for winter, the reduction of filesize is probably not worth it since we support nonequidistant timeseries input, so only 2 rows per year are needed. We can also consider adding convenience methods in the preprocessing tooling instead, and stick to regular timeseries in the core.

This ideally would make use of DataInterpolations: https://github.com/SciML/DataInterpolations.jl/issues/360


[stable/stolon] Cannot be written during stolon master election

Stolon is currently in use, down the master node, there will be a few seconds in the middle of the election leader process. The data is not writable during this time. Is there any other way? Can you achieve seamless switching without affecting program usage?  Am i right?

I found it, see https://github.com/helm/charts/tree/master/stable/stolon
clusterSpec option
I changed the setting to
clusterSpec: {"sleepInterval": "1.25s", "failInterval": "5s", "requestTimeout": "4s"}
See https://github.com/sorintlab/stolon/blob/master/doc/cluster_spec.md
That's it.

@dineshba  What I'm trying to say is how to switch master switch faster. But now that a solution has been found. Thank you


Wrong probseg fmriprep output from freesurfer pipeline

Hi, I noticed that the output of the segmentation from the freesurfer pipeline vs the FLIRT pipeline produced different probseg files. Especially, the probseg files from Freesurfer pipeline stream are binarized and not looking nice at all.
probseg-GM produced through Freesurfer pipeline:

probseg-GM produced through FSL  pipeline:

probseg-GM + WM with Freesurfer pipeline:

probseg-GM + WM with FSL pipeline:

probseg-WM with FS pipeline:

wm.mgz file in the freesurfer folder: it looks ok!

Has anybody also noticed this on its data?

What version of fMRIPrep are you using?
20.2.0
What kind of installation are you using? Containers (Singularity, Docker), or "bare-metal"?
Singularity
What is the exact command-line you used?
</usr/local/miniconda/bin/fmriprep /work/EcritApp /work/EcritApp/derivatives --fs-license-file /work/freesurfer/license.txt participant --participant_label 001 --fd-spike-threshold 0.9 --return-all-components -w /work/temp_data_EcritApp --omp-nthreads 8 --nthreads 12 --mem_mb 40000 --ignore slicetiming --output-spaces T1w MNI152NLin2009cAsym MNIPediatricAsym:cohort-3>

Have you checked that your inputs are BIDS valid?
Yes
Did fMRIPrep generate the visual report for this particular subject? If yes, could you share it?

Can you find some traces of the error reported in the visual report (at the bottom) or in crashfiles?
<No errors to report!>

Are you reusing previously computed results (e.g., FreeSurfer, Anatomical derivatives, work directory of previous run)?
Yes Freesurfer results were re-used
fMRIPrep log
If you have access to the output logged by fMRIPrep, please make sure to attach it as a text file to this issue.

This issue is still present for version 20.2.2. It looks that something is not working properly in  smriprep.workflows.anatomical, for the case with freesurfer: the part which is converting the .aseg file from freesurfer (which looks fine) to t1w_tpms is somehow doing something wrong.

Here is another illustration. T1w image from 1 subject, preprocessed with FMRIPREP and normalized to MNI152NL2009cAsym.
1st case: with freesurfer processing, overlap of the tissue probability map of CSF:

2nd case: same input T1w image, but this time, preprocessed with fmriprep with the flag --fs-no-reconall:

Yes, I think we can agree on these tissue probability maps being poor. I think the one issue is that I never bothered to find the right way to generate tissue probability maps (as in GM, WM and CSF) from FreeSurfer outputs.
If someone more versed in FreeSurfer (@ahoopes?) could give me a hand, it would be very much appreciated. Right now we are just mapping labels from aseg to {WM, GM, CSF}.


Are the MR tags really needed?

Hi, I discovered recently the "MR tags" that could add extra meta-data while working on a challenge.
I still don't understand why it would be needed. I asked various other experienced french contributors and we, collectively, can't really figure out why this feature exists.
Sometimes, "less is more": we suggest to remove the "MR tags" because it pollutes the interface and stop the contributors from focusing on the really important buttons on the interface.
If you find a real use to the MR tags, an alternative could be that you make it optional as a new option while creating a challenge. In this case, I suggest you turn it off by default.

The MR tags have been added after feedback from users to have a more flexible way to add tag-style metadata at the task level. They are in active use and we have no plans to deprecate them. I appreciate your 'less is more' remark, and we always try to be mindful of feature creep, but in this case, we will not consider removing this feature at this time. I do appreciate your thoughts on the topic though!

OK, that's duly noted. Regards


controls are unusually small on mobile

It makes impossible to do anything useful
Xiaomi redmi 4, android 6.0.1 MMB29M

Could you try another browser? Opera, Chrome...

That's probably because I did not make any extra efforts on supporting mobile.
If it's for viewing changesets, Changeset Map might now be the better option anyway.

In my case I wanted to find out which changeset caused certain object to be deleted.

Could you try another browser? Opera, Chrome...

Result is the same

Adding a viewport meta tag to index.html would be a start:
<meta name="viewport" content="width=device-width, initial-scale=1.0, maximum-scale=1.0, user-scalable=no" />
But then the layout gets messed up, so supporting mobile would be a bit more involved.
Like with other issues, it would probably make sense to switch to Leaflet or Mapbox GL JS first. Not sure if and when I will get to this though.


Fixed encoding issue where dataframes were not encoded as unicode

Closes #26 .
While we were encoding values properly as UTF-8 in Postgres, we did not maintain them as unicode strings in the in-memory dataframes (which we generate stats from).
Some lookups with values from Postgres was giving a key error since the stats dictionaries had Python byte strings as keys rather than unicode strings.
Also simplified some of the code where we were constantly dictifying stats dataframes rather than doing it once at the beginning.

Before this PR (removing encoding='utf8' from read_csv)
======================================================================
ERROR: test_hospital (test_holoclean_repair.TestHolocleanRepair)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "test_holoclean_repair.py", line 31, in test_hospital
    hc.repair_errors(featurizers)
  File "/Users/rwu1997/Programming/holoclean/holoclean.py", line 228, in repair_errors
    status, feat_time = self.repair_engine.setup_featurized_ds(featurizers)
  File "/Users/rwu1997/Programming/holoclean/repair/repair.py", line 16, in setup_featurized_ds
    self.feat_dataset = FeaturizedDataset(self.ds, self.env, featurizers)
  File "/Users/rwu1997/Programming/holoclean/repair/featurize/featurize.py", line 16, in __init__
    tensors = [f.create_tensor() for f in featurizers]
  File "/Users/rwu1997/Programming/holoclean/repair/featurize/freqfeat.py", line 31, in create_tensor
    tensors = [self.gen_feat_tensor(res, self.classes) for res in results]
  File "/Users/rwu1997/Programming/holoclean/repair/featurize/freqfeat.py", line 24, in gen_feat_tensor
    prob = float(self.single_stats[attribute][val])/float(self.total)
KeyError: u'surgeryxpatientsxneedingxhairxremovedxfromxthexsurgicalxareaxbeforexsurgery& xwhoxhadxhairxremovedxusingxaxsaferxmethodx(electricxclippersxorxhairxremovalxcreamx\xef\xbf\xbdcxnotxaxrazor)'

After this PR
INFO:root:Precision = 0.94, Recall = 0.69, Repairing Recall = 0.80, F1 = 0.80, Repairing F1 = 0.87, Detected Errors = 438, Total Errors = 509, Correct Repairs = 350, Total Repairs = 371, Total Repairs (Grdth present) = 371


Add support for DOXYGEN_EXCLUDE_PATTERNS

Add an option to set DOXYGEN_EXCLUDE_PATTERNS in the Doxyfile, so the user can exclude parts of the C++ code from the documentation (e.g. some third-party library).
This is supported by the current CMake implementation of the documentation build and thus needs to be added to bcat before we can use it to replace the CMake code.

It would be a bit annoying if those patterns would have to be passed as command line arguments all the time.  Instead I would add support for a config file (e.g. a breathing_cat.toml that needs to be added to the repo).  This could then also be used for #10 (instead of the original idea to extend conf.py).

Proposal for the config file format (using toml):
[doxygen]
exclude_patterns = ["pattern1", "pattern2", "..."]

[intersphinx]
# short variant for convenience (if inventory=None)
robot_fingers = "https://open-dynamic-robot-initiative.github.io/robot_fingers"
# long variant for full support
robot_interfaces = {target = "https://open-dynamic-robot-initiative.github.io/robot_interfaces", inventory = "my_inv.txt"}

This can then easily be extended in the future if needed.
I would search for the file in "./breathing_cat.toml" and "doc[s]/breathing_cat.toml" in the package dir and alternatively provide a --config argument to explicitly specify a file.
@MaximilienNaveau Any feedback is welcome.

why toml?
I am not saying it's wrong, I am just considering that this is not the most common file format...

I think the only reasonable alternative would be yaml (json is awful for files that are read/written by humans).
Compared to that, I simply like the syntax more for short config files like this (clear separation into sections, not sensitive to indentation).
There is also a technical argument that the toml specification is much simpler and thus parsers are less complicated and do not have to deal with some security issues that yaml has.  Though, this is probably not so relevant for us in practice.
It is also becoming more and more common in recent years (used, for example in Python's pyproject.toml), so I think this shouldn't be a problem.  Starting with Python 3.11 a parser is even included in the standard libs, so in the future no third-party dependency will be needed.
If there is some argument against it, I can also switch to yaml, but otherwise I would prefer toml for the reasons mentioned above.

No keep it like this it's great, it was plain curiosity, as we used yaml quite a bit for our past project I wondered about the change of format here.
Thanks for the research!!!


Typescript question.

Does this repository has typescript version?

Hi @CAIJIN1002,
TS version is only available for the non-free version.


Fixes

Fixed issues with 404 when trying to retrieve a posts likes
Fixed issues with comments not showing/ improper authorization
Fixed follow request accept (PUT) / follow check not working
Refactoring of some utils

Utils that were splitting the URL were refactored to not split on 'service/' because not all groups is using /service/ for their API endpoint, some use /api/ or some don't have it at all.
Instead, I've refactored it to split on author/ instead.

Looks good


[FEATURE]: creating stops hours by selection in stops list (in addition of localisation around mode)

I would like to have hours on a stop, (without creating a route) by selecting a stop in a list or entering it's code.
WOuld be perfect to create sort of timetable on a stop in a fixed area.
Thanks

Could be by creating a sensor through edition of a file , or something like that...

This is already possible if you create a zone on the stop itself, then setup the zone/person thing and reduce the radius after it is setup....do try, works for me.
This of course only works if the the data-provider has the correct location for the stop supplied :)


Examples?

As a python developer with an upcoming NAV integration project, this library looks really interesting and useful.  Thanks for your work on this.
I don't see any documentation.  That's fine.  Do you at least have a couple of simple examples? (i.e. authenticating, fetching a page, making an update and saving?)

Hi @jasonhildebrand
Sorry for late reply. The way I usually use it is by calling it from the terminal. The command nav should be available after installing with pip.
First you should create a config to not have to pass in the URL and credentials every time. The default config location is ~/.config/nav.ini. Should look something like this:
[prod]
base_url=http://<IP_ADDRESS>:7080/DynamicsNAV/WS/My-Company
username=SOMEUSER
password=SOMEPASSWORD

[test]
base_url=http://<IP_ADDRESS>:7080/DynamicsNAV/WS/My-Company
username=TESTUSER
password=TESTPASSWORD

Then you can make requests as follows.
For example to get the contents of a published Page (done through a page in the UI called something like "Web Services"):
nav page -c test ShipToAddress

This should return results like so:
<Soap:Envelope xmlns:Soap="http://schemas.xmlsoap.org/soap/envelope/">
  <Soap:Body>
    <ReadMultiple_Result xmlns="urn:microsoft-dynamics-schemas/page/shiptoaddress">
      <ReadMultiple_Result>
        <ShipToAddress>
          <Key>123</Key>
          123
          <Name>123</Name>
          <Address_2>123</Address_2>
          <Post_Code>123</Post_Code>
          <City>123</City>
          <Country_Region_Code>123</Country_Region_Code>
          <Location_Code>123</Location_Code>
          <Shipment_Method_Code>123</Shipment_Method_Code>
          <Shipping_Agent_Code>123</Shipping_Agent_Code>
          <Last_Date_Modified>123</Last_Date_Modified>
          <Order_Conf_to_Mail>123</Order_Conf_to_Mail>
          <Customer_No>123</Customer_No>
          <PfsDistribution>123</PfsDistribution>
          <PfsHide_in_Ship_to_List>123</PfsHide_in_Ship_to_List>
        </ShipToAddress>
        <ShipToAddress>
        ...
        </ShipToAddress>
      </ReadMultiple_Result>
    </ReadMultiple_Result>
  </Soap:Body>
</Soap:Envelope>

As I'm no big fan of XML and its verbose output I usually add the flag -j / --json together with -r / --results-only:
[
     {
          "Key": "123",
          "Code": "123",
          "Name": "123",
          "Address_2": "123",
          "Post_Code": "123",
          "City": "123",
          "Country_Region_Code": "123",
          "Location_Code": "123",
          "Shipment_Method_Code": "123",
          "Shipping_Agent_Code": "123",
          "Last_Date_Modified": "123",
          "Order_Conf_to_Mail": "123",
          "Customer_No": "123",
          "PfsDistribution": "123",
          "PfsHide_in_Ship_to_List": "123"
     },
     ...
]

For more information on how to use each command just suffix --help. In addition to nav page you can also use nav codeunit and nav meta
Some things that you should be aware of:

The underlying xml library, xmltodict, doesn't know what is considered arrays and what is not (I'm not sure if this can be achieved without some type of mapping, as I believe all XML types are user defined). This means that whenever only one item is found in what should be an array, it is returned as an object instead of an array of objects.

Perhaps parsing the definition could fix this, haven't looked into it. For above page one would call nav meta -c test ShipToAddress Page to get the definition.

Please note that this lib has only been tested against NAV 2009.

The underlying python code can be used directly as well. Just look at the nav/main.py file to see how it's accessed.
Oh, and also, check out jq, it's perfect when you want to filter and modify the output from this command.

Wow, thanks for the helpful information!  I've poked around in the code a bit, and have gathered that the library is able to read NAV data, but not add/update records.  Is that correct?

Correct 😊

@jasonhildebrand I've added support for CreateMultiple in v3.0.0, so now you can create data as well. Update is still on the to do list though 😉


Blue dot appears when using the default sky

Godot version:

Occurred both on 3.2.3.rc4 and 3.2.2.stable
OS/device including version:

Windows, GLES3
Issue description:
A blue dot appears under the Y-axis gizmo. It is visible both in the editor and when running the scene. It might be related to the default sky texture, as loading a different texture into the environment sky, or using a clear color, seems to make it disappear.

Steps to reproduce:
Create a new scene (spatial or nothing) and look down on the Y-axis gizmo.
Minimal reproduction project:
Not relevant.

See also https://github.com/godotengine/godot/issues/10204.

Duplicate of https://github.com/godotengine/godot/issues/37192
Please search existing issues before opening a new one.
For future reference this issue has already been solved in 4.0, but needs a different solution for 3.x


Automatic Mode

Add an option to have dialogue finish and skip to the next AfterLabel automatically, without any input.
For labels with choices, it should complete, but wait until the player picks a choice.

Completed in an early implementation.


feat(apps): print output from command to stderr if the command failed

Fixes #69
Ideally we would direct individual lines to STDOUT and STDERR based on what the command itself does... however, the kubernetes api does not distinguish between the STDOUT and STDERR, so I'm not sure that is possible. I think this is probably the best we can do until we get interactive run sessions implemented.

@Joshua-Anderson can you put a milestone on this PR?

This will require an e2e change as well.

See deis/workflow-e2e#231 for the e2e test fix.


Interchange Image works in Firefox but only sometimes in Chrome

In firefox interchange will load the image no problem every time. But in chrome it only works every now and again. I am also using a data-dropdown that only works when interchange does. But always works in Firefox.
Here is the code:
<img data-interchange="[/images/made/images/uploads/slider_images/slider- desktop_1920_800_c1.jpg, (default)],
                  [/images/made/images/uploads/slider_images/slider-desktop_400_385_c1.jpg, (small)],
                  [/images/made/images/uploads/slider_images/slider-desktop_888_450_c1.jpg, (phablet)],
                  [/images/made/images/uploads/slider_images/slider-desktop_1024_565_c1.jpg, (medium)],
                  [/images/made/images/uploads/slider_images/slider-desktop_1440_565_c1.jpg, (large)],
                  [/images/made/images/uploads/slider_images/slider-desktop_1440_565_c1.jpg, (xlarge)],
                  [/images/made/images/uploads/slider_images/slider-desktop_1920_800_c1.jpg,    (xxlarge)]">

Phablet is a custom media query that is defined.
Name the query:
 $(document).foundation(
        'interchange','reflow', {
          named_queries : {
            phablet : 'only screen and (min-width:40.063em) and (max-width: 55em)'
          }
    }
  );

Set up Meta:
    Foundation.utils.register_media('phablet', 'phablet');

Sass for Meta:
meta.phablet {
  font-family: "/only screen and (min-width: 40.063em) and (max-width: 55em)/";
  width: 40.063em;
}

New Ranges:
$medium-range: (55.063em, 64em) !default; /* 881px, 1024px */
$phablet-range: (40.063em, 55em) !default;
$xlarge-range: (90.063em, 118em) !default;
$xxlarge-range: (118.063em) !default;

I am using this in slick-slider but also just as a plain image on other pages.
Every thing works perfectly in Firefox.
In Chrome works 50% of the time which is puzzling.

The Foundation forum would be a great place to seek some help with troubleshooting what might be going on here. If it turns out to be a defect, you'll have some more info to provide here which will help prioritize and get it fixed.
We're trying to keep the issue list focused on confirmed defects in Foundation, so any help everyone can provide to differentiate between usage / troubleshooting and actual defects is appreciated!


🐛 fixed comment from code review

Summary
fixed the following comment from code review on issue #1676:
https://github.com/kubestellar/kubestellar/pull/1676#discussion_r1473120706
Related issue(s)
Fixes #

/cc @MikeSpreitzer
/cc @ezrasilvera


Failed to connect to Jupyter notebook, when running a cell within vscode.

Bug: Notebook Editor, Interactive Window, Editor cells
Error: Failed to connect to Jupyter notebook.
http://localhost:8889/
TypeError: Only absolute URLs are supported
at c:\Users\Hsuey\.vscode\extensions\ms-python.python-2020.2.63990\out\client\extension.js:1:815672

Steps to cause the bug to occur
When I running a cell within vscode.

 This is my console output.
Console.log

@greazer , is there any way to solve this problem?

@Hsuey Thanks for providing this full log. It looks like you might have this vscode extension installed?
https://marketplace.visualstudio.com/items?itemName=OpenPAIVSCodeClient.pai-vscode
In the error callstack for this issue it looks like OpenPAI is hijacking the node-fetch command, I'm not entirely sure what it's doing there, but that looks to be what's causing the issue:
Note in this callstack our code calls into the @jupyterlab services. But then it goes into the node-fetch lib from this openpainvscodeclient, which is where the error comes from and has nothing to do with our extension.
Can you disable / uninstall this openpai and then try the scenario?
workbench.desktop.main.js:sourcemap:258 [Extension Host] Error Python Extension: 2020-03-13 14:44:34: Failed to connect to server [r [TypeError]: Only absolute URLs are supported	at getNodeRequestOptions (c:\Users\Hsuey\.vscode\extensions\openpaivscodeclient.pai-vscode-0.3.0\node_modules\node-fetch\lib\index.js:1299:9)	at c:\Users\Hsuey\.vscode\extensions\openpaivscodeclient.pai-vscode-0.3.0\node_modules\node-fetch\lib\index.js:1404:19	at new Promise (<anonymous>)	at fetch (c:\Users\Hsuey\.vscode\extensions\openpaivscodeclient.pai-vscode-0.3.0\node_modules\node-fetch\lib\index.js:1401:9)	at Object.e.handleRequest (c:\Users\Hsuey\.vscode\extensions\ms-python.python-2020.2.64397\out\client\node_modules\@jupyterlab\services.js:1:130905)	at Object.e.makeRequest (c:\Users\Hsuey\.vscode\extensions\ms-python.python-2020.2.64397\out\client\node_modules\@jupyterlab\services.js:1:129470)	at c.newUntitled (c:\Users\Hsuey\.vscode\extensions\ms-python.python-2020.2.64397\out\client\node_modules\@jupyterlab\services.js:3:375939)	at t.ContentsManager.newUntitled (c:\Users\Hsuey\.vscode\extensions\ms-python.python-2020.2.64397\out\client\node_modules\@jupyterlab\services.js:3:373083)	at S.createSession (c:\Users\Hsuey\.vscode\extensions\ms-python.python-2020.2.64397\out\client\extension.js:1:487961)	at S.connect (c:\Users\Hsuey\.vscode\extensions\ms-python.python-2020.2.64397\out\client\extension.js:1:485245)	at t.JupyterSessionManager.startNew (c:\Users\Hsuey\.vscode\extensions\ms-python.python-2020.2.64397\out\client\extension.js:75:1013342)	at d.connect (c:\Users\Hsuey\.vscode\extensions\ms-python.python-2020.2.64397\out\client\extension.js:75:986523)	at async c:\Users\Hsuey\.vscode\extensions\ms-python.python-2020.2.64397\out\client\extension.js:1:816313]
t.log @ workbench.desktop.main.js:sourcemap:258

Sorry that callstack didn't quite paste right.
at c:\Users\Hsuey.vscode\extensions\openpaivscodeclient.pai-vscode-0.3.0\node_modules\node-fetch\lib\index.js:1404:19
at new Promise ()	at fetch (c:\Users\Hsuey.vscode\extensions\openpaivscodeclient.pai-vscode-0.3.0\node_modules\node-fetch\lib\index.js:1401:9)
at Object.e.handleRequest (c:\Users\Hsuey.vscode\extensions\ms-python.python-2020.2.64397\out\client\node_modules@jupyterlab\services.js:1:130905)

Great, after I disabled this openpai, jupyter notebook works normally, thank you very much for your help. @IanMatthewHuff

@IanMatthewHuff it works for me. Thanks. I will let the OpenPAI guys know this issue.

@Hsuey and @mydmdm glad that you are both unblocked. Hopefully the OpenPAI issue is resolvable. I've seen some issue before where VS Code extensions could interfere with each other. Just ping back here if you think there is something that we can help resolve from our end. I'll close this issue and the other related one now.


#70 - fix createDirectoryRecursively with end slash in async drivers

rtrim() for path in createDirectoryRecursively()

Thanks!


[BUG] Polaris can't use S3 when KMS is enabled

Is this a possible security vulnerability?

[X] This is NOT a possible security vulnerability

Describe the bug
When using Polaris with S3 (without KMS), everything is working fine (I can create Iceberg table from spark-sql on Polaris).
However, when I enable S3 KMS, I get:
ServerError: S3Exception: User: arn:aws:sts::601864557682:assumed-role/cep-analytics-platform-role-dev-polaris-catalog/snowflake is not authorized to perform: kms:GenerateDataKey on resource: arn:aws:kms:eu-west-1:601864557682:key/401edca7-d545-4907-9c9f-2695305beb5e because no session policy

allows the kms:GenerateDataKey action (Service: S3, Status Code: 403, Request ID: C0MA61C4VYNS88CP, Extended Request ID: ZboVDdn8eh4YBIjMUbG8X6fDT4oq6OFFqDcq/dKbVsrNDGW3IIhojELznwkyWhMDmSxO376I5o0=)

It seems that we have a missing security configuration to use with KMS.
To Reproduce
Just use S3 KMS with Polaris.
Actual Behavior
It works fine without KMW, but fails with S3 KMS enabled:
ServerError: S3Exception: User: arn:aws:sts::601864557682:assumed-role/cep-analytics-platform-role-dev-polaris-catalog/snowflake is not authorized to perform: kms:GenerateDataKey on resource: arn:aws:kms:eu-west-1:601864557682:key/401edca7-d545-4907-9c9f-2695305beb5e because no session policy

allows the kms:GenerateDataKey action (Service: S3, Status Code: 403, Request ID: C0MA61C4VYNS88CP, Extended Request ID: ZboVDdn8eh4YBIjMUbG8X6fDT4oq6OFFqDcq/dKbVsrNDGW3IIhojELznwkyWhMDmSxO376I5o0=)

Expected Behavior
No response
Additional context
No response
System information
No response

In my setup, I am using S3 with KMS. To get it working, the IAM role needed to include additional IAM policy (for my setup, i have kms:GenerateDataKey, kms:Decrypt, and kms:DescribeKey added to the IAM role used by Polaris).


mscolab chat upload/download  did not use configured "filepicker_default": "fs"

This is similar to
https://github.com/Open-MSS/MSS/issues/636
if we configure in mss_settings.json the "fs" filepicker this is currently for mscolab chat upload/download ignored
To verify this you need a config file mss_settings.json to be stored in $HOME/.config/mss
{
"filepicker_default": "fs"
}
mss_qt.get_open_filename needs to be used
source to look at
https://github.com/Open-MSS/MSS/blob/develop/mslib/msui/mscolab_project.py
please check if the test needs a fix too

I have been assigned to issue #636 and since this is a similar issue, can i provide the fix?


bottom-left

Please add bottom-left

This is for positioning the pop-over?

I am new to contributing to an open source project. Any open issues in this project that is good for intermediate JS guy like me?

Yes for positioning the pop-over.

Okay. Will work on this issue then.

Hey, there is already left-bottom, please use that.

Got it. Shall I add the current positioning options into the Demo page? currently it only has left, top, bottom & right.

Also, i was thinking of a feature

While highlighting input boxes, allow Enter(key press) as an option to move to the next highlighted button. This will help in building forms that will highlight the current required field for every field.

@vishwanathovi if you want to update the demo page for that, go ahead.
Regarding the Enter key to move next, I don't think we should have that, it can easily be implemented by anyone who wants that using an event handler in their app.


Add bastion table

Integration test logs

Logs
Add passing integration test logs here

Example query results

Results
Add example SQL query results here (please include the input queries as well)
select
*
from oci_bastion_session
where bastion_id = 'ocid1.bastion.oc1.ap-sydney-1.'
and target_resource_details->'sessionType' = '"MANAGED_SSH"'

select * from oci_bastion_session where
id = 'ocid1.bastionsession.oc1.ap-sydney-1.'

select * from oci_bastion_bastion
where id = 'ocid1.bastion.oc1.ap-sydney-1.'

select
*
FROM oci_bastion_bastion where (client_cidr_block_allow_list)::jsonb ? '<IP_ADDRESS>/0'

SELECT * from oci_bastion_bastion where id = 'ocid1.bastion.oc1.ap-sydney-1.'

select s.* from oci_bastion_bastion b
INNER JOIN oci_bastion_session s
ON b.id = s.bastion_id

</details>

@scotti-fletcher could you please fix the merge conflicts across all the open PRs? Could you also format the queries in the table docs using https://www.freeformatter.com/sql-formatter.html


need gadget to attach

We have followed the quide to decrypt an ipa using Frida.
When we run ./dump.py {BUNDLE_ID} we are unable to decrypt the ipa.
We get the following message:
need gadget to attach; its default location is: /Users/{machine_name}/.cache/frida/gadget-ios.dylib
How do we either generate or find the file gadget-ios.dylib?

解决了吗？


Corrected Login Text In SignUp Form

Fixed Issue #1230
Corrected the punctuation mistakes in the Signup Form (Login Text)
Before:

After:

@sunny0625 Can you please review the PR and merge it with adding labels

Did you get assigned this issue #1230?

I have opened the issue #1230 but have not been assigned. It was a small typo so thought i could directly open a PR. Can you please assign #1230 and merge the PR.


Compare partial payments with 3.1

I want to merge this change because...

Impact

[ ] New migrations
[ ] New/Updated API fields or mutations
[ ] Deprecated API fields or mutations
[ ] Removed API types, fields, or mutations
[ ] Documentation needs to be updated

Pull Request Checklist

[ ] Privileged queries and mutations are guarded by proper permission checks
[ ] Database queries are optimized and the number of queries is constant
[ ] Database migration files are up to date
[ ] The changes are tested
[ ] GraphQL schema and type definitions are up to date
[ ] Changes are mentioned in the changelog

Closing as probably we will provide partial payment in a different way.


expand_dims changes attrs and encoding of coordinate variable

Expanding the dimensions of a variable with a dimension having the same name as a coordinate variable will also change the attributes (including encoding attributes) of this coordinate variable!
The following examples prints the attrs and encoding of coordinate variable time before/after expanding the dimensions of the variable sea_surface_temperature
import xarray as xr
import numpy as np

grid = xr.Dataset({
    'time': (('time',), [np.datetime64('2018-01-01')]),
    'lat': (('lat'), np.arange(-80, 80, 1)),
    'lon': (('lon',), np.arange(-180, 180, 1)),
    'sea_surface_temperature': (('lat', 'lon',), np.ones(shape=(160, 360)))
    })

grid['time'].encoding['units'] = 'seconds since 1981-01-01 00:00:00'
grid['time'].attrs['comment'] = 'some comment'

print(grid['time'].encoding, grid['time'].attrs)
grid['sea_surface_temperature'] = grid['sea_surface_temperature'].expand_dims('time', axis=0)
print(grid['time'].encoding, grid['time'].attrs)

The current output is:
{'units': 'seconds since 1981-01-01 00:00:00'} {'comment': 'some comment'}
{} {}

Expected Output
I would not expect any change to other coordinates or variables than the expanded one (here sea_surface_temperature)
{'units': 'seconds since 1981-01-01 00:00:00'} {'comment': 'some comment'}
{'units': 'seconds since 1981-01-01 00:00:00'} {'comment': 'some comment'}

Output of xr.show_versions()

INSTALLED VERSIONS
------------------
commit: None
python: 3.8.1 (default, Jan  8 2020, 22:29:32)
[GCC 7.3.0]
python-bits: 64
OS: Linux
OS-release: 4.15.0-72-generic
machine: x86_64
processor: x86_64
byteorder: little
LC_ALL: None
LANG: fr_FR.UTF-8
LOCALE: fr_FR.UTF-8
libhdf5: 1.10.4
libnetcdf: 4.7.3
xarray: 0.15.0
pandas: 1.0.1
numpy: 1.18.1
scipy: 1.4.1
netCDF4: 1.5.3
pydap: None
h5netcdf: None
h5py: None
Nio: None
zarr: None
cftime: <IP_ADDRESS>
nc_time_axis: None
PseudoNetCDF: None
rasterio: None
cfgrib: None
iris: None
bottleneck: None
dask: 2.11.0
distributed: 2.11.0
matplotlib: None
cartopy: None
seaborn: None
numbagg: None
setuptools: 45.2.0.post20200210
pip: 20.0.2
conda: None
pytest: None
IPython: None
sphinx: None

Thanks for the clear reproducible example @jfpiolle. I am marking this as a bug.
Are you up for fixing it?

There is a subtle error here:
>>> grid['sea_surface_temperature'].expand_dims('time', axis=0)
<xarray.DataArray 'sea_surface_temperature' (time: 1, lat: 160, lon: 360)>
array([[[1., 1., 1., ..., 1., 1., 1.],
        [1., 1., 1., ..., 1., 1., 1.],
        [1., 1., 1., ..., 1., 1., 1.],
        ...,
        [1., 1., 1., ..., 1., 1., 1.],
        [1., 1., 1., ..., 1., 1., 1.],
        [1., 1., 1., ..., 1., 1., 1.]]])
Coordinates:
  * lat      (lat) int64 -80 -79 -78 -77 -76 -75 -74 ... 73 74 75 76 77 78 79
  * lon      (lon) int64 -180 -179 -178 -177 -176 -175 ... 175 176 177 178 179
Dimensions without coordinates: time

time is added as an unindexed dimension with no encoding or attrs dicts. This is because once you pull the DataArray sea_surface_temperature out of the dataset; the time variable in the dataset is not attached to that DataArray (since it doesn't have a time dimension).
When the expanded dataarray is assigned back to the dataset, we run into #2180
The only solution I could find is
grid["sea_surface_temperature"] = grid.sea_surface_temperature.expand_dims("time", axis=0).assign_coords(time=grid.time)

Please reopen if you have more questions.


Error: [ng:cpws] Can't copy! Making copies of Window or Scope instances is not supported

Hello,
I have a ng:cpws error using your this plugin and the yeoman genenator :

I simply generate a new angular project :
app/views/main.html
<datetimepicker data-ng-model="main.date" date-format="dd-MMM-yyyy"></datetimepicker>

app/scripts/app.js
$routeProvider
      .when('/', {
        templateUrl: 'views/main.html',
        controller: 'MainCtrl',
        controllerAs: 'main'
      })
     .otherwise({
        redirectTo: '/'
      });
  });

app/scripts/controllers/main.js
angular.module('nodejsApp')
  .controller('MainCtrl', function () {
    this.date = new Date();
  });

It does not work, with or without any custom options...
Do you have an idea please ?

+1
The issue appears in angular v1.6.x. Angular v1.5.x works ok.

I changed the way an inner form is isolated to fix the initialization issue.

Hello, i'm also using this componnent and i'm confronted to the same issue. I've seen your update (isolateForm) and it's fixing the problem.
My question is : When will you realease an updated version with this bug fix ?
Thanks for your time

Updated plugin version

I have the latest updated code but the issue still persists for angular version 1.6 or above .

Does any one else get the same issue with the latest plugin version?

Do you have plunkr where we can reproduce it?

Please find the Plunker here:
http://plnkr.co/edit/2jyyaQuiRmlfS18qZjz1?p=preview

You can try the latest commit now. Plunker: http://plnkr.co/edit/qRhNlfTWlt9wIexa3WbB?p=preview

Thank you for fixing it. It works well now!!


Fix "unwrap_or_else(|| ..." in record_history.rs so it builds

Commit a158ba1281317ee83d71bf5f00d32a54fb1df1d7 from a few days ago changed ".expect(&format!" with ".unwrap_or_else(|| panic!" across the repo (including in record_history.rs).
However this pattern was actually incorrect for Result types (since Result's expect the closure for unwrap_or_else to take a single argument). There was a follow-up in commit 5caba470ad99b2336d044866716799d93f3888c8 to fix this in most verus files, however this commit missed record_history.rs (which as of time of writing won't compile). This went undetected as CI currently does not try to build verus with the --feature record-history flag.
This commit makes it so that the record-history feature at the very least builds (I haven't run any tests since I wasn't sure if there were any).

@utaal are there tests in the repo for the record-history feature? I'll try and just run the code rn to make sure it works, although the changes were typically in error-handling cases so I'm not sure if I'll be able to do a good job verifying these changes work.

@utaal are there tests in the repo for the record-history feature?

There aren't, unfortunately. I thought about adding them but they require infrastructure for running verus in tests that we don't currently have.

I'm going to land this so I can look into https://github.com/verus-lang/verus/pull/916.


Unified measurement representation

This PR aims at fixing #302 by implementing once and for all a robust and efficient way of handling measurements.

Actually I didn't see too much difference between the new representation Measurement and the old RelativeMeasurementData. Maybe I have missed some important points and could you elaborate more on the benefits of the new representation?

I can see 2 benefits to the current representation:

it is not a semi-private class (RelativeMeasurementData was public, but was used in a semi-private way in the code, with opportunities to provide tuple instead of instances of the class to avoid a user to have to use it) and so I find Measurement easier to use for users.
there is RepeatedMeasurement that allows to represent measurements more efficiently and that interacts nicely with Measurement.

but in the end, I very much agree that Measurement can be obtained from copy-pasting RelativeMeasurementData to another file and renaming it.

And one thing I still have problem with is that, since the Measurement includes the local offset, the same Measurement data structure can represent different actual measurements at the different time slices of the circuit. So it's not unique in that sense.

Yes, and this is by design. For a given circuit, Measurement is a way to represent a unique measurement. As soon as the circuit changes, the Measurement instances should be considered invalid. Basically, instances of the Measurement (and RepeatedMeasurement) class only make sense when they accompany a circuit and when the "origin" (i.e., the time slice in the circuit that is used for the relative negative offset) is clear (for simplicity, and because we likely do not want to keep track of that "origin", it is always defined as the last time slice of the circuit).

I wanted to have a try at implementing a better measurement map, but I will need some of the code introduced here in a follow-up PR for detector computation, so I guess this is ready to merge.

I wanted to have a try at implementing a better measurement map, but I will need some of the code introduced here in a follow-up PR for detector computation, so I guess this is ready for review.

Are you going to improve the measurement map in a new PR? If it is, I can approve this one now to avoid blocking.

I wanted to, but I think the Best way forward is to make that in another PR.


Logs show Access granted for expired tags

I am using latest Dev build from last week and rc522 reader but still same bug. Tags with always access but time not between valid since and valid till do not activate the door relay but still show as access granted in access logs.

Hey @neel8440924 also this one should be fixed here: https://github.com/esprfid/esp-rfid/pull/632
Let me know!

I have tested this PR #632 for some time, I think this issue is fixed now. Only one small improvement  for standard card with always access, it would be nice to know why it was denied access (expired or outside of opening hours).


Add possibility to configure preprocessor macro VL53L1_MAX_RANGE_RESULTS.

The user manual (UM2133) suggests that this macro can be configured:

VL53L1_MAX_RANGE_RESULTS [...] by default, is equal to four.

(from Rev 6 page 10, highlighting by me)
The value can be passed to the preprocessor as predefined macro.
Using Arduino IDE this can be achieved with help of the platform.local.txt configuration file. For example to change the value to 1 add this line to platform.local.txt:
compiler.cpp.extra_flags=-DVL53L1_MAX_RANGE_RESULTS=1

This change applies the same mechanism as already exists for VL53L1_MAX_USER_ZONES some lines further up.

Hi @dhebbeker ,
I prefer to manage it inside the library without any change in the Arduino IDE. For example you can use the the __has_include directive to override some default values at application level as I did for VL53L5CX on platform_config.h file. In this way, you can add a platform_config_default.h file inside the library to have the default settings for some defines. And then, if you want, you can override the defines at application level adding a platform_config_custom.h like I did in this example always for VL53L5CX.
Best Regards,
Carlo

Hello Carlo,
I like your solution which uses __has_include. Unfortunately the compiler (version) I have to use does not support it (only C++11).
But both approaches can be combined. I will adjust my suggestion accordingly.
Cheers
David

I am using xtensa-lx106-elf-g++. I can not use the newest version (which may support __has_include) because of this bug in the compiler. That is why I am limited to C++11.

Thanks a lot for your contribution David! PR integrated! ;-)

I have also generated a new release (2.1.0) that includes this new feature

Thank you Carlo, it is a pleasure to work with you!


Update ankama-launcher

Update needed.
The launcher has been updated, I re generated the web-archive downloading and updated sha.

Welcome to nixpkgs!
The latest version of ankama-launcher is already merged with https://github.com/NixOS/nixpkgs/pull/362515.
Also, your changes are not targeting the right branch. Most changes should go in master, if the changes causes mass rebuilds, then it should go in staging.

You can read more about that in https://github.com/NixOS/nixpkgs/blob/master/CONTRIBUTING.md.


Update README.md.gotmpl

Can you please update the existing PR instead of creating a new one. That saves us reviewing time.


Ability to use horizontal scrolling with grid view

Is your feature request related to a problem? Please describe.
Although Microsoft recommends vertical scrolling, horizontal scrolling can sometimes be useful especially for large screens.
Describe the solution you'd like
A clear and concise description of what you want to happen.
A toggle to use horizontal scrolling instead of vertical scrolling.
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
None.
Additional context
Add any other context or screenshots about the feature request here. Ex: What device type/UI layout and app version?
This feature should be hidden on small-screen tablets/laptops because horizontal scrolling makes it hard to navigate on such devices.

@Jaiganeshkumaran We don't have any plans to implement this.

@Jaiganeshkumaran We don't have any plans to implement this.


Server Error 500 when adding POS data.

It would be really awesome if Drug Labs, and other unknown modules wouldn't throw this issue when attempting to add a Dscan of a POS with one anchored or nearby.  If you could add support for the Drug Manufacture modules in the types added to the POS fitting that would be really nice.

Duplicate of #196


signal-desktop: 7.9.0 -> 7.10.0

Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.
meta.description for signal-desktop is: Private, simple, and secure messenger
meta.homepage for signal-desktop is: https://signal.org/
meta.changelog for signal-desktop is: https://github.com/signalapp/Signal-Desktop/releases/tag/v7.10.0
Updates performed

Ran passthru.UpdateScript

To inspect upstream changes
Impact
Checks done

built on NixOS
The tests defined in passthru.tests, if any, passed
found 7.10.0 with grep in /nix/store/z7rlp75w0svj7dcjahmkv62hh8m9mkmk-signal-desktop-7.10.0
found 7.10.0 in filename of file in /nix/store/z7rlp75w0svj7dcjahmkv62hh8m9mkmk-signal-desktop-7.10.0

Rebuild report (if merged into master) (click to expand)

2 total rebuild path(s)

2 package rebuild(s)

First fifty rebuilds by attrpath

signal-desktop

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/z7rlp75w0svj7dcjahmkv62hh8m9mkmk-signal-desktop-7.10.0 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A signal-desktop https://github.com/r-ryantm/nixpkgs/archive/e836d5a4be6155dc8fe45abca7c5617361cc522b.tar.gz

Or:
nix build github:r-ryantm/nixpkgs/e836d5a4be6155dc8fe45abca7c5617361cc522b#signal-desktop

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/z7rlp75w0svj7dcjahmkv62hh8m9mkmk-signal-desktop-7.10.0
ls -la /nix/store/z7rlp75w0svj7dcjahmkv62hh8m9mkmk-signal-desktop-7.10.0/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review --extra-nixpkgs-config '{ allowInsecurePredicate = x: true; }' run on x86_64-linux 1

1 package built:

signal-desktop

Maintainer pings
cc @eclairevoyant @Mic92 @equirosa @urandom2 @bkchr for testing.

Automatic backporting via labels depends on https://github.com/NixOS/nixpkgs/pull/312904


Unable to get MySQL error info

I'm finding it to be useful to provide the user the mysql error if there is a failure to insert data into the db. In order to do so, I need to expose access to the statement PDO object so I can access the errorInfo() method on it.

this is merged


Theming

Sorry if this is already a feature but I cannot seem to find it.
The idea is to exposing a theming api, configurable though the config (or a dedicated theme file, maybe similar to how "foot" terminal does it?) so that users may choose how their ly looks, after all it the first thing the vast majority of people have to interact with :)

Do also check out HalkaDM, recently started the project of the TUI Desktop Manager as an alternative to ly for supporting modern graphics, currently in Development & Testing but will soon release it's first alpha build.


ACM-2522 Display a machine pool instance type for OpenStack and RHV

https://issues.redhat.com/browse/ACM-2522

/cc @Randy424

/lgtm


PagerDuty Setup

Backlog Task
Set up PagerDuty for the team. Presumably we can use the same account used by ReportStream and SimpleReport.
Completion Criteria

[ ] Everyone on the team who needs PagerDuty access has it.
[ ] An on-call rotation has been established.
[ ] A backup on-call rotation has been established.
[ ] Escalation process is established, documented, and shared.
[ ] Length of rotation has been established.
[ ] Establish, document and communicate norms (coverage hours, SLA).
[ ] Times, vacations expectations, comp time is documented and shared.

Tasks

[ ] Ask RS about securing another license @scleary1cs

https://www.pagerduty.com/pricing/incident-response/

Mo will look as getting more (12) PagerDuty.

13 additional seats

We will need some form of admin rights @halprin

Note from RS meeting 03/01:
Pager duty seats- Mo will follow up; has not heard anything back as of today. They have raised the question about whether or not the existing number of licenses is sufficient. Mo will follow up once he receives an update.

We've been asked for who needs a PagerDuty account: https://flexion.slack.com/archives/C048S3GPSQG/p1710441931404389

No change as of 03/29/2024 sync with RS.

No change as of 04/26/2024 sync with RS.

05/10/2024 - Mo was not on the RS sync call, but we reached out via the ETOR channel:
"
@Maurice Reeves
Happy Friday, we are in the "ReportStream <> Intermediary Onboarding and Product Sync", would you happen to have any updates on the PagerDuty seats? Any blockers we can help with? Any forecast for completion"
Mo's reply:
"I don’t. I thought they were purchased and this should be done. Let me find out"

I pinged Dinah about the seats but she’s been OOO so I expanded the email to include others about who the POC is who can hand out those sweet sweet accounts - Mo

OCIO pushed back on funding.  Mo is filing a exception request.

so….nobody let me know this, but OCIO has hit pause on the purchase of additional licenses because PagerDuty is not FedRAMP’d yet. They are going through the process but it’s not complete. I wasn’t aware of this, hence my confusion about it not having been resolved. I’m seeking an exception request since we’re already using the tool. Stay tuned! - Mo  05/05

May need to investigate alternatives? (discussed during Sprint Planning)

Another slack poke to Mo here.

hey everyone, the invoices from PagerDuty have been submitted and I’m meeting with OMO today to get them paid, so that should mean we can add folks in short order after that. details and updates to follow

Discussed with @halprin moving this story to Production Stage 4.

Closing for now as PagerDuty support may be permanently blocked and we've implemented work-arounds for receiving notifications.


Broken badges

Hi,
I'm finding all the badges on my projects are broken. I only just joined and set it up, but I don't think it's an issue on my part.
The direct URLs work just fine, it's when they're cached behind githubusercontent that they 404.
Not sure if it's something you can address with cache headers etc?
Cheers!
Pablo.

I had a similar issue.
The markdown code provided on the site doesn't work with https, I had to replace them with http.

@jadb Just as @ZeeCoder said, HTTPS of this site have some issue.
It only provided one SSL cert without the full cert chain, please fix it.

It looks like the stillmaintained.com domain has been expired and bought up by a domain squatter and is currently asking about $1600 USD for it.


Use heuristics and incremental compute to make sync algorithm faster

After the initial parse an edits we do can possibly be incrementally added on to the original parse faster than re-parsing, but this will be more complex to do.

Not clear about the inline editing feature, which this is a part of.


entryhuman: Use presence of TERM to force colors

We don't need to invent our own variable to indicate that we should log with colors despite not being connected to a TTY. Can reuse $TERM.
Now if you use slog in CI, you'll want to ensure you also set TERM=xterm-256color before you invoke any program that uses slog.

Pull Request Test Coverage Report for Build b83ac07a5c3daf66fe0a8eca9c9e2f22ec983236-PR-

1 of 1 (100.0%)  changed or added relevant line in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 97.541%

Totals

Change from base Build 18dce5c2cd5f311781610661c14b9f3a681bb550:
0.0%

Covered Lines:
714

Relevant Lines:
732

💛  - Coveralls


fix(android): add window.dispatchEvent when postMessage

refer: https://github.com/react-native-webview/react-native-webview/issues/2586

I'm not sure why the Android implementation used document instead of window, but postMessage has been sort of deprecated for quite some time: https://github.com/react-native-webview/react-native-webview/issues/809
So I'm kind of wondering if the better fix might be to just remove it and force everybody to switch to injectJavascript....


How to get integer actions in PPO2 algorithm

I defined action space as a set of integers in MyEnv class
# MyEnv class
self.action_space = gym.spaces.Box(
            low=-10, high=10, shape=(1,), dtype=np.int)

# train model
env = DummyVecEnv([lambda: MyEnv(df, ...)])
model = PPO2(MlpPolicy, env, verbose=1)
model.learn(10000)

but when I train a model, it seems get float actions like this:

I don't know why

This is because you define action space as a Box, not as Discrete. Box space is a "continuous" space, where actions are supposed to be floats.
Note that this place is not for tech support, so if you do not have further questions/issues specifically related to stable-baselines you may close this issue.

but I've set dtype=np.int

I don't use Discrete space because it does not support negative numbers

It is still considered as continuous space under the hood (this is a special case). I suggest you define a discrete space of spaces.Discrete(n=21) (+1 to include +10) and then inside your environment you offset this with -11 .

I don't think it's a good idea, I want to use dynamic action space, it's hard to do as you say
and why this can get integer action
space = spaces.Box(
    low=-10, high=10, shape=(1,), dtype=np.int)

action = space.sample()
print(action)

Under the hood Box space is assumed to be continuous space (used by e.g. robotics/MuJoCo tasks) where you can choose any floating point number in the given range (a mean and standard deviation parametrize a distribution and then that is sampled/used to do updates). This kind of situations were not counted for. If you really need to support this type of behaviour you need to modify the code (I recommend checking out stable-baselines3 for that).

So you mean no matter which type you set the dtype parameter in Box space, this stable-baselines library will always ignore it and still use the default float type?

Yes, no matter the dtype it will always be treated as float.

OK, I'll try to use Discrete space, thanks a lot


The flag of the current player sometimes gets hidden if the other player has a flag.

Reported on Chrome.

Could not reproduce. Maybe it's just at the end, when the score is shown?

Probably fixed in 2.1.23 (noflag classes were not cleaned)


iOS: mailto subject fails to decode

app: NetNewsWire 6.1.4 (Build 6120).
platform: iOS 16.6.
account: Feedbin.

When following a mailto link, the subject fails to decode. I'm guessing it's either interpreted too directly, or double encoded at some point. Clicking the same link from a web page in a browser on the same device works as expected. E.g. in Mobile Safari, or when browsing the article web page within a WebView in the NetNewsWire app, or e.g. a wrapper for Mobile Safari like Firefox on iOS.

Nay
Yay

Example:
https://timotijhof.net/posts/2023/an-internet-of-php/
Reply by email

The corresponding entry in the RSS feed for https://timotijhof.net/ (https://timotijhof.net/feed/):
<generator>https://wordpress.org/?v=6.3.1</generator>
<item>
	<title>An Internet of PHP</title>
	<link>https://timotijhof.net/posts/2023/an-internet-of-php/</link>
	…
	<content:encoded><![CDATA[

PHP is big. …

…

Reply via email
]]></content:encoded>

In case it makes a difference, I'm subscribed via Feedbin.

Similar issue from 2021 (closed). https://github.com/Ranchero-Software/NetNewsWire/issues/3281, https://github.com/Ranchero-Software/NetNewsWire/issues/2711
Related issue from 2020 (closed). https://github.com/Ranchero-Software/NetNewsWire/issues/2256

A fix to this issue has already been landed on the main branch (ce6d114, #3719).

@brentsimmons It seems as though this issue has resurfaced in the current version of NNW on iOS. Even though a mailto link including subject was set to be encoded within the feed itself, the characters are still not decoding properly in the email. Checked in both Feedbin and miniflux with the same feed, and the issue persists. Definitely isn't something with the link itself, as it works properly in Reeder on iOS/iPadOS (I don't have a Mac to verify there).


[Event Request] Table 5407 Prod. Order Component - OnBeforeUpdateUnitCost

In table 5407 Prod. Order Component, in the local procedure UpdateUnitCost, we used to calculate "Unit Cost" and "Indirect Cost %" in another way than the standard one. In BC 16.4, we actually can't do what we want to. We need to have an event publisher at the beginning of this procedure and a IsHandled flag. Like this :

And the integration event :

Do you think it could be possible ?
Thank you for your work.

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. We will update this issue with information about availability.


ENH: added a MatVec(CSR, []float64) routine

This adds a  CSR matrix times vector routine. I use []float64 for both the right hand side and the output of the function.

Good call! I've done tha


Can't reference most functions with intersphinx

Hi there,
I want to use multiformats.multihash in my code and reference some functions in the docs. However, this does not work for most functions except for those in the submodule varint from what I have tested.
works:
:mod:`multiformats.varint`
:func:`multiformats.varint.decode`

doesn't work:
:mod:`multiformats`
:mod:`multiformats.multihash`
:func:`multiformats.multihash.wrap`

I haven't gotten to the bottom of it but I am pretty sure it is because of the api subfolder of the documentation and the ambiguity between files like
https://github.com/hashberg-io/multiformats/blob/main/docs/multihash.rst
https://github.com/hashberg-io/multiformats/blob/main/docs/api/multiformats.multihash.rst

Couldn't the structure of the docs folder be simplified by removing the api folder and integrating the API TOC elsewhere?
Also, what is the purpose of the intersphinx folder? Why not just reference the objects.inv files coming with the respective readthedocs pages?

I just tested all your examples:

and for me they all compile correctly, linking to the respective pages of the multiformats docs:

I suspect this may be an issue with your configuration of intersphinx, or at the very least a difference between yours and ours. Would you mind sharing some additional details on how you configured intersphinx to connect to multiformats? For your reference, here is a snippet from the conf.py that I used when testing:
intersphinx_cache_limit = -1
intersphinx_timeout = 20
intersphinx_mapping = {
    'python': ('https://docs.python.org/3', None),
    'multiformats': ('http://multiformats.readthedocs.io/en/latest', None)
}

Thanks for your reply and sorry for being a little too sure about the source of error. Using latest instead of stable does the trick:
- https://multiformats.readthedocs.io/en/stable
+ https://multiformats.readthedocs.io/en/latest

The docs for stable exist but are basically empty:
https://multiformats.readthedocs.io/en/stable/api/multiformats.multihash.html#multiformats.multihash.wrap
I see that the last build for stable failed:
https://readthedocs.org/projects/multiformats/builds/
I would really prefer referencing the stable version. Could you perhaps issue a bug fix release so that the stable build succeeds?
For reference, here is my configuration:
https://github.com/SAR-ARD/s1ard/blob/feature/stac_asset_hash/docs/source/conf.py

I've done a new build of stable, you should be able to access it now!

Awesome! Thanks a lot @sg495.


Logarithm scale on Y axis in Spectrogram plugin

Hi,
I was wondering if there exists an option to print canva chart of spectrogram plugin using a logarithm scale on Y axis (KHz) in wavesurfer.js 2.2.1 ?
Like this for example :

It would really useful in certain cases !
Thank you

cc @shershey

I second this, it would be a useful addition.

maybe @dofuuz is interested in adding this.

Hi, I see this is closed as completed but can't seem to find this feature? Where should I looking?
Thanks in advance.

It wasn't completed, it was closed for the lack of activity. I'm not going to work on this, but PRs are welcome.

Ah okay thanks for clarifying

Any updates on this? I'm working on a project where the user should be able to select the scale and we're expecting to use Linear, Logarithmic, Mel, Bark and ERB

I see that this was closed as completed in #3790. However, that PR adds support for different scales but doesn't include support for the logarithmic one, or am I missing something? 🤔

Thanks for reopening! I'm not a spectrogram expert, but I will try to do something similar to the PR above to add support for logarithmic scale too

I opened the PR with my initial attempt. Any feedback is welcome!

Thank you @Dabolus! 🎉
Merged and released in 7.8.14.


Add "postsubmit_overrides" to build config json spec

The purpose of this feature would be to support configurations that need e.g. different gn flags between pre- and post-submit.
@godofredoc I will wait on making changes to the goma setup for the builds we discussed until we can write these in the build configs.

The migration to RBE is blocked on this issue, which (AFAIK) must be completed in Q4, so I will bump this up to P1.

This will still be needed to keep presubmit cycle times low. Completing the migration to reclient is still blocked on this.

Recipes change: https://flutter-review.googlesource.com/c/recipes/+/57022

Closing as completed!!!


Adding design patterns to EO

Creating a PR for @marieALaporte's branch

I made the PR so I can't review, but I say +1

The existing pattern will need to be updated and more need to be added based on what we decide.
@cmungall in the makefile, I don't know how this is supposed to work for importing the pattern file into the main file... should this be part of the release process only? I haven't added the robot merge command so far, as I was not sure of where this should fit in the process
Just as a reminder, the PURL will have to point to the eo.owl (or eo.obo) file that will be created by the release process. No release process has been run yet
Last thing, before to accept the PR, should we take the opportunity, as we are almost starting from scratch, to organize the repo as the other OBO Foundry repos?

the .owl file will need to be updated by Justin's cron job - not in sync with the .obo file of this PR

A comment on what is part of the eo.tvs file: I only tried to create the patterns for the classes that would need to be linked to the TO. That's the reason why not all the EO treatment classes are listed. I haven't tried to map all of them to CHEBI and  NCBI.

the .owl file will need to be updated by Justin's cron job - not in sync with the .obo file of this PR

@elserj I think we can remove the cron job. We can have this repo follow the standard SOP for all manually released ontologies - the release manager/ontology editor does a make release which builds owl and obo release files, which are committed and pushed.
See for example the template we often use: https://github.com/cmungall/ontology-starter-kit/blob/master/template/src/ontology/README-editors.md#release-manager-notes

@DoctorBud can we go a TE demo for this as well? Files in this branch: https://github.com/Planteome/plant-environment-ontology/tree/test-dp


A runtimeerror, which is located to copy_param function

In def copy_param, m's weights and bias are copied to n's weights and bias respectively. However, after debugging, I found m.weight.shape=[64,27], while n.weight.shape=[64,3,3,3]. How can I fix this error? Would it be feasible to reshape n.weight' shape before copying?

I see in pull requests that @Amir-Arsalan has updated a convert_torch.py, which perfectly solves my problem.


Fix DC scrape

The DC WARN pages appear to have changed. Scraper is raising the below error. Current status of the WARN pages listed on the 2021 page are:

2021-2018 work
2017 and earlier are broken, except for 2014, which appears to duplicate the 2018 data

[x] We should call the DC Dept. of Employment Services about the status of their WARN pages.
[ ] We'll need to update the scraper based on their response. If they do not respond, we should update the scraper to only pull data for 2018 to present
[ ] Restore DC to list of states to scrape in Prefect settings for WARN Update project

Stacktrace
Traceback (most recent call last):
  File "/Users/tumgoren/code/stanford/biglocal/WARN/warn/cli.py", line 67, in main
    runner.scrape(state)
  File "/Users/tumgoren/code/stanford/biglocal/WARN/warn/runner.py", line 46, in scrape
    output_csv = state_mod.scrape(self.output_dir, self.working_dir)
  File "/Users/tumgoren/code/stanford/biglocal/WARN/warn/scrapers/dc.py", line 43, in scrape
    for url in url_list:
IndexError: list index out of range

Left a voice message at media inquiry number<PHONE_NUMBER> and sent email to<EMAIL_ADDRESS>

DC has been removed from the list of states to scrape in Prefect, pending feedback from DC Dept of Employment Services and final implementation of bugfix.

Followed up with DOES contacts via phone and email and tried various other departments. No luck so far.
Discovered that DC has American Jobs Center locations. They don't appear to post data on the DC job center site, but they may be a better starting point to locate whoever manages the data for DC. See below links for details and contact info:

American Job Center contacts page
DOES contact page

Reached out to mayor's office. Person there took info and said they'd have someone from DC Comms dept reach out...

Got a callback from James Clopton in Rapid Response department. He's in charge of notifying the site maintainers in pubilc affairs dept about updated data. He notified them of the breakages and said he'd pass my info along.

No fixes have been applied yet. Pinged James Clopton today. Awaiting response...

Our agency contact reached to say they're finalizing updates to the pages prior to publishing. No official ETA, but sounds like we're getting closer...

DC data pages are now restored for 2012 through a newly posted 2022 page. However,  2014 still points to the 2018 page.

Also worth noting: The URL patterns remain all over the place (i.e. no regular pattern), so we'll need to scrape links from most recently available year.

I've notified the agency but I think we could update scrapers to start scraping from 2015 onward for now until the 2014 issue is resolved.
/cc @palewire

On a 2017 copy of the page in Archive.org, the URL 2014 now points to redirects to a URL specific to 2014, but it appears to be no longer available at that URL.

@chriszs Latest from DC contact:

It seems there may be more [pages?] dropping off. That [2014] page was lost in conversion and unrecoverable. I am waiting on feedback, but will follow up when I find out. Thanks and have a great weekend!

I'll pass along the Archive.org page you uncovered. Perhaps they can restore it from that page if they can confirm the accuracy of notices listed there...


Implement basic i18n

[x] Research methods for multi-language support
[x] Implement basic version of multi-language
[ ] Update example page with language switcher (moved to #34 )
[x] Ensure translations for things like Time, Date, and Currency
[x] Implement sample component for translations

By translation for time what do you mean?  Like if we have 11.23am that should be 11.13午前？
If we use 24 hour time everywhere we can avoid most of these issues.
I suppose we might have things like "Tx sent 1 minute ago" though right?

Closed by PR #35


test(*): support multiple annotated failures

The way tslint does it seems like an overkill and is actually less readable for our small tests (too much clutter). It looks much clearer to me like this. We can add the [failure] syntax when we feel the need for it. There are enough symbols like this; it basically it just has to be a symbol which is not otherwise used in the snippet.
I updated a (kinda) random test to test the new helper function, although it doesn't make that much sense to test two same error messages (I couldn't find an existing rule on master branch in which two different error messages can happen in the same context).

What do you think about suffixing the markers with an identifier? Something like:
@Component({ selector: '[bar]' })
                                          ~~~~[1]
@Component({ selector: '[foo]' })
                                          ~~~~[2]

This way, we can verify the failure like:
failures: {
  1: '...',
  2: '...'
}

In general, if we omit the suffix, we can check the failures positionally:
failures: {
  0: '...',
  1: '...'
}

Which will be equivalent to:
failures: [
  '...',
  '...'
]

This way we don't need other characters and also don't extend the syntax.

I went for a different character because of cases like this. How do we handle it?


docker_user = ansible_user

So I want to install rootless docker for the user I'm installing most other services for in my playbook. Apart from the alias not being created for some reason, I don't want to have to use sudo in order to connect to the daemon my user is running. As far as I can see, that's the only option in the template, but for my case, setting the DOCKER_HOST env variable would suffice.
Is this something we can implement? I think it would be straightforward and it has a very common use case in my opinion.

Hi @Dzeri96, isn't setting docker_user: "{{ ansible_user }}" enough?
are you installing using the rootless packages or with a docker daemon on the server?

when: docker_add_alias|bool and not docker_rootful and docker_user != ansible_user (https://github.com/konstruktoid/ansible-docker-rootless/blob/main/tasks/main.yml#L71) or something like that and a task settings only DOCKER_HOST if docker_user = ansible_user would probably fix that.
want to submit a PR?

Sure, give me some time though as I'm currently involved in my master's thesis 😅


Add AbstractConfigTestCase

This test enforces a project to have all the fixers specified, either active or not, so it's always up to date. This can be viewed as a more aggressive form of https://github.com/FriendsOfPHP/PHP-CS-Fixer/pull/3047.
Usage:
final class ConfigTest extends \PhpCsFixer\Test\AbstractConfigTestCase
{
    public function testPhpCsFixerConfigIsUpToDate()
    {
        $this->doTestAllDefaultRulesAreSpecified(require dirname(__DIR__) . '/.php_cs');
    }
}

[x] Check all rules are specified, either by name or RuleSet
[x] Check all specified rules exist and are not deprecated
[x] Check all rules are ordered alphabetically

It's 2 years I use this test in my project (for example in Slamdunk/php-cs-fixer-extensions) and is sooo useful.
If you like it, I'll update the README too.

1) PhpCsFixer\Tests\AutoReview\ComposerTest::testBranchAlias
Failed asserting that Array &0 (
    'dev-master' => '2.15-dev'
) is identical to Array &0 (
    'dev-master' => '2.16-dev'
).

near all checks have been added during the refactor of the RuleSet and RuleSets, so others I added here https://github.com/FriendsOfPHP/PHP-CS-Fixer/pull/5930 , I think this covers all, let me know if not than we can reopen, thanks for all the work!

@SpacePossum does this mean that 3.0 dist version has a PHPUnit test that I can use withing my project that accomplish the goal of this PR?

We no longer provide any tests that can be extended on, or at least we don't hold a BC promise on any test logic AFAIK. This was removed in 3.0. There was/is to much work to maintain by the team so we had to reduce the scope of the project and removed the support on extendable tests.


clear method doesnt work

i try to clear user cookie in my ember app. and the cookie still there...
export default Service.extend({
  cookies: Ember.inject.service(),
  removeCookies() {
    let cookieService = this.get('cookies');
    cookieService.clear('user');
  }
});

its work in chrome. but not in firefox..
whats wrong..

I can confirm that this is a bug, although it's not an ember-cookie bug.  It's a Firefox bug (see: https://bugzilla.mozilla.org/show_bug.cgi?id=691973 ), and it's only related to cookies that are already expired.
Chrome isn't affected, so ember-cookies works flawlessly there.
Steps to reproduce:

Create a cookie with an expiration timestamp 10 seconds from now.
Wait until it expires.
Check Firefox's cookies.  The cookie will still be there.
Attempt to delete cookie via Javascript.  Nope.  Not happening.

Here's a simple HTML (must be accessed through a local web server, or enable cookies with local files) that can help reproduce the problem (keep the dev console open in the Local Storage/Cookies section):

<input type="button" id="cookiebutton" onclick="cookieButton()" value="Create cookie"></button>
<input type="button" id="cookiedeletebutton" onclick="hardDeleteCookie()" value="HARD delete cookie"></button>

No cookie (supposedly)

There is an easy workaround:  Just before deleting the cookie, set it again to any value (an empty string should be fine).  Firefox will of course "revive" the cookie, and clearing it will work at that point.  For example:
// Let's delete the 'arepa' cookie:

    cookieService.write('arepa', '');
    cookieService.clear('arepa');

// The 'arepa' cookie is now gone.

This issue is happening for expiry time, which is not getting set properly. Facing this issue in chrome also.
I'm doing this for clearing, which cleared on expired.
if(cookies.read([key])) {
  cookies.write([key], '', { path: '/', expires: moment().toDate()});
}

@trdp30 how is that cookie written in the first place?

I'm seeing issue with this in Chrome now.


Donations

Rundown

Two new pages: /donations & /thank-you
Donation button links to external website
Still looking into API integration

As no-one was around, and it needed to be done, I am merging my branch myself.


Manual handling of resolving components resolving

I want to be able to manually handle when my component is marked as resolved.
In my specific case I want to delay resolution of the component until a background image has loaded. I am able to do this by creating my own custom attribute image-loading but I feel it would make more sense to make use of the unresolved attribute, since it is already widely used.

Closing as a duplicate of #960.


Healthchecks and autorestarts for computes

Problem description / Motivation
Branched off from https://github.com/neondatabase/cloud/issues/14114
At this moment, we can only rely on k8s's signal for compute unavailability, specifically, container process monitoring.
We would like to have an end-to-end healthcheck, which would allow us to detect problems, such as:

Postgres does not accept connections
compute_ctl crashlooping
Network partitioning

Feature idea(s) / DoD
We have a healthcheck mechanism, allowing us to detect compute issues within <30s, and taking appropriate actions, such as restarting.
Implementation ideas
We should have a piece of code inside vm which would respond to a healthcheck.

Not sure we will need that or if Kubernetes is good enough. Putting in the backlog for now.


Handling non-UTF-8 strings

Hi, my users that encode their projects in ISO-8859-1 are experiencing this problem: https://github.com/phpstan/phpstan/issues/3956#issuecomment-726613942

It's because non-UTF-8 strings can find their way into the JSON encoder.
What's the recommended way of preventing this error? How can I bulletproof-encode non-UTF-8 into UTF-8 before feeding it into reactphp-ndjson?
Thank you!

Solved: https://github.com/phpstan/phpstan-src/commit/0524fb5c8e060d40ef6de65955e8e4b324d94477
Feel free to close.

@ondrejmirtes Thanks for reporting this here! I see this is already solved for your use case, but I'm answering here also to help others encountering similar problems.
JSON only supports UTF-8 encoded strings by design, so this is expected behavior by default.
I see you've started using the JSON_INVALID_UTF8_IGNORE (or JSON_INVALID_UTF8_SUBSTITUTE) constant available as of PHP 7.2.0 to handle invalid UTF-8 data. This sounds like a reasonable approach if you want to ignore invalid bytes in your text input.
As an alternative, you may also want to look into transcoding your input strings to valid UTF-8 encoding. This is relatively straight forward when your input encoding is known (uft8_encode(), iconv(), mb_convert_encoding() come to mind), but can be much harder when you don't control the input encoding.
If you want to transport arbitrary string data without caring about its text encoding (or binary data), native JSON might not be the best choice. You can always encode your input string using base64 encoding before passing it to the JSON parser, but this involves additional overhead (plus effort on the receiving side).
Depending on what you want to achieve, you may also use a different framing format that uses message lengths such as BEncode or netstrings.
To recap: For your specific use case, it sounds like ignoring invalid bytes might be reasonable. For other use cases, this might not be acceptable. I've worked with a number of projects to evaluate and find the best I/O formats and the answer is really "it depends". If you're interested in professional support, drop me an email and we'll work out the details.

Thank you very much :)

For the reference: I've updated my answer to include links to https://github.com/clue/reactphp-bencode and https://github.com/clue/reactphp-netstring as possible alternatives. I hear there will be some updates on both projects not too far in the future… 🤫


Miss naming convention for Azure app configuration

Miss naming convention for Azure app configuration

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: d3a84ce2-7a0b-4558-1e28-aeefc649b567
Version Independent ID: 3dffb383-4087-9aca-3b33-c5f777334062
Content: Define your naming convention - Cloud Adoption Framework
Content Source: docs/ready/azure-best-practices/resource-naming.md
Service: cloud-adoption-framework
Sub-service: ready
GitHub Login: @martinekuan
Microsoft Alias: ssumner

The page you linked to are examples, the more complete list is the companion page found at https://learn.microsoft.com/azure/cloud-adoption-framework/ready/azure-best-practices/resource-abbreviations#developer-tools which has App configuration service.
#please-close


Remove choking noise when holding an air bladder

A tactic to travel with limited air is to swim near the surface with an air bladder and use the air bladder to filter air, then dive beneath the surface to take a breath. This leads to constantly triggering the choking sound effect when you resurface to refill the bladder, which is an annoying sound.
My suggestion is to just remove the choking sound (but not the warning notification) when you surface holding a bladder. The player probably doesn't need to be reminded that they can't breathe because they are surfacing purposefully to fill the air bladder (also it would be a bit weird thematically if Riley kept trying to breathe when doing this...) I've made this change locally and tested it and it works quite well. I am happy to submit a PR if this seems like a good idea.
A potential follow-up would be to allow breathing through the air bladder whilst at the surface. Either by allowing the player to breathe normally while holding it, or to modify the item behaviour so it can be used whilst at the surface (similar problem to the air pump).

The air bladder filling up despite the poisonous atmosphere was an oversight. https://github.com/tinyhoot/Deathrun-Remade/commit/fb38e63ef2c5e3c6f16ac8c6da3757c0af88dda1 fixes this. Since there is now no longer a situation where one would keep dolphin diving along the surface with an air bladder, I do not think it is necessary to remove the choking noise.


Issue generating MQNs from mol that is read from XYZ

When I read a Mol from a SMILES, I can generate MQNs with it. When I read a Mol from an XYZ file, I cannot.
I use two files to test this: mqn_generation.py and my_geo.xyz. I pasted the contents of each of those two files below.
mqn_generation.py
from rdkit import Chem
from rdkit.Chem.rdmolfiles import MolFromXYZFile, MolFromSmiles
from rdkit.Chem import rdMolDescriptors

mol_1 = MolFromXYZFile('my_geo.xyz')

# SMILES string corresponding to the XYZ file.
corresponding_smiles = '[C]O[Al]12([O])(O[C])O[C]O[Al](O2)(O[C]O1)([O])[O]'
mol_2 = MolFromSmiles(corresponding_smiles)

print('checking if file is read correctly')
# The for loops below both print the same atoms for mol_1 and mol_2 (different order though)
for idx, atom in enumerate(mol_1.GetAtoms()):
	print(f'mol_1 idx is {idx} and element is {atom.GetSymbol()}')
print()
for idx, atom in enumerate(mol_2.GetAtoms()):
	print(f'mol_2 idx is {idx} and element is {atom.GetSymbol()}')

# https://xinhaoli74.github.io/blog/rdkit/2021/01/06/rdkit.html#Molecular-Quantun-Numbers-(MQN)-Descriptors
mqn_ds_2 = rdMolDescriptors.MQNs_(mol_2)
print(f'len(mqn_ds_2) is {len(mqn_ds_2)}')
print(f'mqn_ds_2 is {mqn_ds_2}')
# Can generate MQNs from the Mol read from SMILES.

print()
print('Now, attempting with mol object read from an XYZ file')
mqn_ds_2 = rdMolDescriptors.MQNs_(mol_1)
# The above line gives the error below:
"""""
****
Pre-condition Violation
getNumImplicitHs() called without preceding call to calcImplicitValence()
Violation occurred on line 299 in file /Users/runner/miniforge3/conda-bld/rdkit_1678104751770/work/Code/GraphMol/Atom.cpp
Failed Expression: d_implicitValence > -1
****

Traceback (most recent call last):
  File "/Users/gianmarcoterrones/Downloads/mqn_generation.py", line 25, in <module>
    mqn_ds_2 = rdMolDescriptors.MQNs_(mol_1)
               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
RuntimeError: Pre-condition Violation
	getNumImplicitHs() called without preceding call to calcImplicitValence()
	Violation occurred on line 299 in file Code/GraphMol/Atom.cpp
	Failed Expression: d_implicitValence > -1
	RDKIT: 2022.09.5
	BOOST: 1_78
"""""

So, the error looks like
****
Pre-condition Violation
getNumImplicitHs() called without preceding call to calcImplicitValence()
Violation occurred on line 299 in file /Users/runner/miniforge3/conda-bld/rdkit_1678104751770/work/Code/GraphMol/Atom.cpp
Failed Expression: d_implicitValence > -1
****

Traceback (most recent call last):
  File "/Users/gianmarcoterrones/Downloads/mqn_generation.py", line 25, in <module>
    mqn_ds_2 = rdMolDescriptors.MQNs_(mol_1)
               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
RuntimeError: Pre-condition Violation
	getNumImplicitHs() called without preceding call to calcImplicitValence()
	Violation occurred on line 299 in file Code/GraphMol/Atom.cpp
	Failed Expression: d_implicitValence > -1
	RDKIT: 2022.09.5
	BOOST: 1_78

my_geo.xyz
16

O       4.62       5.93       1.89
O       6.95       5.32       0.78
O       7.07       5.26       2.96
C       5.22       7.62      -1.78
O       5.24       3.61       0.78
O       5.26       7.07       3.66
C       7.62       5.22       1.79
Al       5.28       5.28       0.00
Al       5.28       5.28       3.30
C       2.94       5.34      -1.78
O       5.30       3.49       2.96
O       5.32       6.95      -0.77
O       3.49       5.30       3.66
C       5.34       2.94       1.79
O       3.61       5.24      -0.77
O       5.93       4.62      -1.88

I used rdkit version 2022.09.1, downloaded with conda using the channel conda-forge. I am using a Mac with macOS Ventura 13.1. The version of python in my conda environment is 3.11.0.

@gianmarco-terrones This is not a bug.
Regarding mol_1: when you read a molecule from a XYZ file, the molecule will simply be a collection of atoms with no bonds in between. Since the descriptor you are attempting to compute requires connectivity, it is bound to fail.
Regarding mol_2: that SMILES does not look correct, as all heavy atoms are specified as having no bonded hydrogens, which I doubt is the case. This also suggests that the XYZ file that you are loading should have hydrogens, but it doesn't.
So it looks like your molecules both have several issues that you should address.
I am closing this as this is not a bug. Please use the Discussions tab in the future before submitting a bug - if the topic of the Discussion turns out to involve an actual bug, it can always be moved to the Issues section.


pintTestSofa Example Unknown Debug Console Error Reported vs No Reported Error in Default Runtime Console

When running the default pinTestSofa scene but with an attached debug window, I find that after 2 more attempted manipulations of any spacepin, an error is reported in the debug window that is not reported in the example's default Tagalong runtime console found under the WorldLocking object in the scene.
Attached is a short video demonstrating what I mean.
https://user-images.githubusercontent.com/2231240/184195405-00e0bcd4-af6e-4700-9013-6ccc58cb3c9c.mp4
Here is snapshop of the scene with the added debug window:

You have a null reference somewhere.  If you run with a debugger attached, it should break-in at the relevant function and you can inspect what is null.