python3Packages.typeguard: 2.12.1 -> 2.13.0

Motivation for this change
Update to latest upstream release 2.13.0
Change log: https://typeguard.readthedocs.io/en/latest/versionhistory.html
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
21.11 Release Notes (or backporting 21.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 146705 run on x86_64-linux 1

4 packages marked as broken and skipped:

python38Packages.optuna
python38Packages.pymatgen-lammps
python39Packages.optuna
python39Packages.pymatgen-lammps

7 packages failed to build:

home-assistant
python38Packages.papermill
python38Packages.qiskit
python38Packages.scikit-tda
python39Packages.catboost
python39Packages.papermill
python39Packages.qiskit

54 packages built:

ansible-lint (python39Packages.ansible-lint)
apache-airflow (python39Packages.apache-airflow)
cmake-language-server
cve-bin-tool
deeptools
git-annex-remote-googledrive
hp2p
python38Packages.aiokef
python38Packages.ansible-lint
python38Packages.apache-airflow
python38Packages.castepxbin
python38Packages.catboost
python38Packages.chart-studio
python38Packages.cufflinks
python38Packages.dash
python38Packages.jedi-language-server
python38Packages.kmapper
python38Packages.marshmallow-dataclass
python38Packages.plotly
python38Packages.pyathena
python38Packages.pygls
python38Packages.pymatgen
python38Packages.qiskit-ibmq-provider
python38Packages.renault-api
python38Packages.smart-meter-texas
python38Packages.stack-data
python38Packages.sumo
python38Packages.synergy
python38Packages.tenacity
python38Packages.typeguard
python39Packages.aiokef
python39Packages.castepxbin
python39Packages.chart-studio
python39Packages.cufflinks
python39Packages.dash
python39Packages.jedi-language-server
python39Packages.kmapper
python39Packages.marshmallow-dataclass
python39Packages.plotly
python39Packages.pyathena
python39Packages.pygls
python39Packages.pymatgen
python39Packages.qiskit-ibmq-provider
python39Packages.renault-api
python39Packages.scikit-tda
python39Packages.smart-meter-texas
python39Packages.stack-data
python39Packages.sumo
python39Packages.synergy
python39Packages.tenacity
python39Packages.typeguard
quark-engine
rapid-photo-downloader
theharvester

Superseded by #147426


SAMZA-1387: Unable to Start Samza App Because Regex Check

@fji @nickpan47 @prateekm take a look.
This change is almost identical to #213, but for coordinator streams rather than changelog.

There is a check failure, could you please take a look? Thanks!
Fred

@fredji97 Yeah it's a known flaky test called testShouldStartAndRestore
@shanthoosh, you've emailed about this before. Is there a ticket for it already?


"x" column in WNAI/codes.csv

The code description of the WNAI dataset has a somewhat mystrious column x, with the following statistics:
  6. "x"

	Type of data:          Text
	Contains null values:  True (excluded from calculations)
	Unique values:         4
	Longest value:         12 characters
	Most common values:    None (2369x)
	                       FINE (8x)
	                       DISAGREEMENT (6x)
	                       Fine (2x)

What does this mean? And do we have to keep it?

I think these can be deleted safely, right @kirbykat ?

@xrotwang, @SimonGreenhill - yes, they can be deleted. thanks!


Add license files to all published crates

Objective
Add our licenses to every published crate
Fixes #4719
Solution

Symlink both licenses to all crates listed in the publish.sh script
I took the approach from serde

Symlinks are not universally supported on Windows. I believe you need to enable developer mode on windows and enable symlink support when installing git. Otherwise git will represent symlinks as files containing the name of the target I believe.

Symlinks are not universally supported on Windows. I believe you need to enable developer mode on windows and enable symlink support when installing git. Otherwise git will represent symlinks as files containing the name of the target I believe.

Is that a problem here? I tested cargo package and it seems to put copies of the symlinked files into the package.

if @cart is still using this script to publish, the script could just copy the license before publishing

if @cart is still using this script to publish, the script could just copy the license files before publishing

That's an alternative, but then we would have to use --allow-dirty for the publish command or check the copied files in. I wouldn't be really happy with any of those two options.

Oh right, forgot about the dirty 🙁

Does license-file allow relative paths outside of the crate directory? Or does this not work because we need two different licenses?

Arg I really don't want to duplicate our licenses a million times throughout the codebase. I'd like a single source of truth and as little "noise" as possible in the repo.
symlinks are better than duplication, but they still increase repo noise (and as mentioned, aren't great on windows), so I think I prefer updating the publish script to do the copy. --allow-dirty is a bit regrettable, but it is "scoped" hackery. We could run git commands to the script to clear the working directory before publishing, which would protect against "dirt" (at the cost of potentially accidentally losing changes).

It's so noisy, but I do want these licenses to show up properly on crates.io 🤔

bors r+


settings: Use browser scrollbar on right pane

Fixes #11694. Alternative to #12348.
Cc: @rishig.
Testing Plan: Opened Settings, Organization settings, and Manage streams.

Thanks! This was helpful. Now that I see this live I might go back to preferring a darker simplebar for modals, and browser scrollbar only for full-screen pages like /help. The hover/click behavior is much nicer with Chrome's scrollbar at least (vs simplebar), but it does seem a bit restrictive in terms of visual style.

@rishig so given that, should we merge #12348?


Add images to documentation

Hi, I saw howler and it piqued my curiosity, but before going all in and trying it for myself, I'd like to know what to expect. I tried reading the documentation, but stopped after a while, because I have no idea what howler looks like and how common workflows are operated with it.
I'd suggest adding a lot of images and videos to the documentation. I'm probably not the only one who would like to see it before trying it. 🙏

Great suggestion. I'll file a ticket internally to expand our documentation to have some improved images and example data. In the meantime, if you'd like a live demo or just access to a demo instance to poke around on, feel free to join our discord and I can get you access.

Hi Matthew, I just saw this reply, and the invite link expired. Could you send me another one? Thanks!

This link shouldn't expire:
https://discord.gg/WTKVn5sC

Link expired. Would love to see a demo on this.


Refactor Links to avoid nested  tags

In nexus-react, there is a DOM issue in the Links component (for incoming / outgoing links when viewing entities).
Nested  tags are invalid HTML and provide redundant information. Refactor the Links component and their parents so that we have only one .

This issue was moved to BlueBrain/nexus#135


Could we have the Day-planner folder changeable?

As wonderful and feature-reach this plugin already is, recently I ran into the

need to change the Day-planner folder

Situation
was surprised by there being no option to change the day-planner's folder in the settings. Did I miss out on anything?
I would imagine this being a simple thing to add on. Correct me if I am wrong.
Reason:
All my standard data files follow some template structure with frontmatter etc.
Day-planner files do not have this - and most probably don't need

( otherwise that would then be another option to ask for  🙂 .  And  it seems some folks have been asking for frontmatter or templating before...  but not my concern today)

Thus I like to file all other files with a distinct prefix or into some special subfolders and would have to change the Day-planner's folder name.

@Sigbert11 I achieve this another core plugin called "Daily notes".
Do the following:

Enable daily notes core plugin
Pick the folder where it will create the daily notes
Change Day Planner to command mode
Hit ctrl-p (or what ever your palette button is) and pick "Daily notes: open today's daily note", this will create a note with today's date (date format customizable in Daily Notes settings).
Hit ctrl-p again and "Day Planner: Link today's Day Planner to the current note"

The Day Planner plugin now treats the note that Daily Notes plugin made as one it will automatically format.
Why this is especially nice is because you can create a template of your own, tell the Daily Notes plugin to use it when creating the Daily Note for the day, and if you format it in a way that Day Planner understands, you can have your own custom format for your Day Planner.
I use the following template myself: https://www.dropbox.com/s/ml913ia1ml2objz/planner.md?dl=0

Some way to not have to run the command manually would be nice.

I feel the need for this also, my top-level folder structure is very precious to be kept that way.
I'd like to put it under a subfolder if that would be viable. /Calendars/

This is available in 0.7.0.

Where can I find this option for selecting a default folder? I'm unable to find it.

I was also puzzled for a while, but I think the author wouldn't have failed to provide this function. Then, I discovered the author's wisdom, this plugin automatically recognizes the folder settings in the Obsidian built-in diary plugin.


Add simple logic locality-awareness reassignments

This is the first part for locality-aware reassignments using rackId/availability zone info. Currently it will not failover to other localities nor will it balance replicas throughout the localities. These issues will be issued afterwards.

@kabochya could you please squash the commits?

@yuyang08
Added notifications for failure on locality-aware reassignments, however the partital reassignment strategy (still assigning oosReplicas without caring if some other oosReplicas fail to get reassigned). This behaviour is inconsistent with the original one, which is drop the whole reassignment if even one oosReplica failed to get reassigned. Should we unify the behavior of these two methods? I have documented the differences in the comments of the generateReassignmentPlanForDeadBrokers method.

Remove partial reassignments


Added pymodbus project

The github mentions support for python 3+ and the tox.ini file lists py35, py36, py37.

Thanks!


Links must be absolute for other domains

Clicking the 'OAuth Documentation Page' link now, in this repository, takes you to a 404 page, because the resulting link is https://github.com/Patreon/patreon-ruby/blob/master/patreon.com/oauth2/documentation
Adding a top level http:// is required in order to send the user to Patreon's site.

Based off the other repositories (python, java), seems https:// is preferred. I'm not a creator so I can't verify it :/. But, consistency is better than not.

closed in favor of #1 which had the same change (as we redirect http => https on our end anyway). thanks!


Changes required for adding prod6 model to database

This is a big pull request with lots of little changes which will be time-consuming to review. However, it is a big step forward to have the full cycle of model_parameters from and to sim_telarray, having different versions of full sets of validated model parameters in the DB.
This PR is accompanied by the addition of a first version of Prod6 into the database (date 2024-02-01). The prod6 model is also available in the the repository at  https://gitlab.cta-observatory.org/cta-science/simulations/simulation-model/model_parameters .
Details:

no need to have a copy of the model_parameter repository available; please: remove the SIMTOOLS_DB_SIMULATION_MODEL_URL setting from your .env file
explicit using of model_version throughout the code (and tests); see issue #846
improve add_value_from_json_to_db to allow to submit all files from a path to the db (similar to existing add_file_to_db.py)
change of command line parser with respect to site and telescope model: allow now to show the following three possibilities: model_version, model_version, site, model_version, site, telescope (-> very repetitive changes in many applications)
moved some of the data type validation to general.py (as used by several modules); possibly needs discussion if general.py is too long and we want to split it into logical parts
db_from_from_repo_handler is checking now the model_version
removed reference data db (issue #845 ); the only parameter in the there (nsb_reference_value) is added to the site model; removed code to pull things from the reference data db
replace of the the specialized functions to get model parameters (e.g., get_telescope_transmission_parameters) by more generic get_parameter_value_as_list() function
replace all simtel-style list descriptions as string "0.25 28. 0.0.0" to lists. The conversion from and back to sim_telarray is now reduced to the core function on the model_parameter module.

(in this context: some smaller changes are moving the 'knowledge' about the structure of how the model parameters are stored in the database to the model_parameter module and out of the specialized simtools modules)

names.py includes some temporary fixes (see issue #853)
not all values are not put into Derived-DB yet for prod6 (affects tests for camera_efficiency and ray-tracing; see issue #850)
the prod5 model is incomplete and needs to be updated with some values to work with simtools (mostly the corsika related parameter like observation level and sphere radius), see issue #851

@tobiaskleiner - thanks a lot for your review and comments!
I've implemented them all. Maybe have a look at the last one, don't have a much better name for the module function without having a long and complicated name.
Let me know if anything else should be fixed.


Formatting and hyperparameter settings before merge

Exploration of the KAN hyperparameter space
Really looking forward to doing some sweeps to characterize the KAN performance in different settings (starting similarly with shakespeare_char then moving on to wikitext103).
Some settings:
mlp_variant = kan
kan_poly_order
kan_base_activation
kan_middle_layers (can set these, hopefully this will be compatible with our run_experiments)
use_parallel_mlp
mlp_variant_mlp
mlp_sharing_size
mlp_sharing_sym
Alternatively can try:
linear_variant="kan", but may be better for a much smaller n_embd (else we'll run out of VRAM with default settings)
That being said maybe we won't need as much n_embd with KAN?
Note on stability
Seems there was a div by zero instability only during inference stemming from the forward method of the KAN class.
Clamping this to a small number appears to have addressed it.
Note on training
Seems that the memory taken by KAN is much larger than that for a usual MLP.
We may have to try the new --use_gradient_checkpointing feature in order for some of the explorations to fit into VRAM.
Looking forward : )

Okay, should be good to go, after you merge this PR into your repo, it should update the PR on ReaLLMASIC and then KAN can be merged into the main repo : )

Feel free to reach out via the group chat if you have any questions.


fix: eda table right click improvements

Closes #1180
Summary of Changes
(Includes History PR changes)

Submenus in column right click:

"From Selection" if one or two selected => plot from selected columns or hide from selection
"From Click" that plots one column plots on current right clicked columns and hides column

"From Selection" also possible if right click on cells
All plotting now checks for column type where only numerical is allowed and shows greyed out with tooltip incl. reason if not possible
Right clicks if preventClicks is true only allowed if on same element type, so can change position of same right click by doing it again
With hiding mult cols from selection the toggleHideColumn method now takes array and only does it if all columns have same hidden state; for now adds separate history entries as creating a new action type for this would be too much

@lars-reimann fixed! That annoying thing of !0 evaluating to true ...

:tada: This PR is included in version 0.18.0 :tada:
The release is available on:

npm package (@latest dist-tag)
npm package (@latest dist-tag)
v0.18.0
GitHub release

Your semantic-release bot :package::rocket:


Intro Screen 1

Add the background for the intro screen.

will it be restricted to a static image or we can use videos and gifs too ??

we can have something like this in the background if GIFs are allowed

will it be restricted to a static image or we can use videos and gifs too ??

yes u can use videos and gifs too
but the one u have uploaded here how are u planning to incorporate that transition from intro screen to the main home page??

will it be restricted to a static image or we can use videos and gifs too ??

yes u can use videos and gifs too but the one u have uploaded here how are u planning to incorporate that transition from intro screen to the main home page??

we can have that same background image in the homepage as well or else we can use another image

will it be restricted to a static image or we can use videos and gifs too ??

yes u can use videos and gifs too but the one u have uploaded here how are u planning to incorporate that transition from intro screen to the main home page??

we can have that same background image in the homepage as well or else we can use another image but the clouds transition we are going to make will give a nice effect if we choose the same background in both intro screen and the homepage

chlo thik h filhaal ke liye lekin pehle mujhe wo transition mein kaisa lgega dikha dena.

Open a PR for this

Open a PR for this
i am still working on it

till now I have reached this far
https://github.com/user-attachments/assets/fdb613b1-dc2f-4007-ad2f-609c1b7ca691
still the cloud animation is remaining

ok

play button mt rkho ek exec koi overlay pe kaam kr rha usi ko lga dena then on enter cloud animation lga dena,button ki design tho will match with the aesthetics of the website toh remove mt krna isko comment out kr dena baad mein lgana hoga toh dekhenge.

Ok

introScreen.js:5 Uncaught
TypeError: Cannot read properties of null (reading 'addEventListener')
at introScreen.js:5:13
sir I was trying to add the cloud animation on the enter button click but no matter what I do, either I use the JS in the script tag in the HTML or a separate JS file I am getting this error, also asked GPT for this but nothing worked, I think that the issue is with the loading time of the scripts.
Can you help me with this? I implemented the background with responsiveness, added the enter button instead of the play button, and even animated the clouds. Now, we just have to work on the JS part.

PR daaldo i'll look into it

see this is the animation without the event listener
https://github.com/user-attachments/assets/ee77ae78-02c6-49d9-87b9-aa759ba4191f

Good work!! Open a PR for this

Good work!! Open a PR for this

Thanks 😊, dropped it


multi-select visual bug

Appears to have a visual bug when clicking canvas.
Actual selected items behind the scenes seem OK.

@wkoeter From your screen capture, it seems that the last node cannot be selected?

I think it is marked selected in the code behind, The bug is visual.
Everytime I click on a node, I click the canvas afterwards. That is creating this effect.


pivot table V2 Color Shading bug

Conditional formatting in pivot table V2 seems to be shading very granular. Is it possible to have conditional formatting without it showing a different shade? Seems the color is not staying solid but rather fades away as the difference between highest and lowest value that is being picked up by a condition is increasing. You could call it a feature, but if the color becomes so faint, it's not visible anymore, I would rather call it a bug.
How to reproduce the bug

Create a data source with values to display that are very far away from each other. (positive range)
Use the  pivot table V2 chart to display the data.
Use conditional formatting on the values to show everything > 0 as green
See like here, that the data is showing only very faint color in relation to the highest value:

Expected results
See shading never go below 70% occupancy for the lowest shade range.
OR an option to only show solid colors without shading.
Actual results
shading down to almost no occupancy of the smaller values.
Screenshots

Environment
(please complete the following information):

browser type and version: Google-Chrome Version 116.0.5845.180 (Official Build) (64-bit)
superset version: 2.0.1
python version: python --version no idea
node.js version: node -v no idea
any feature flags active: no idea

Checklist
Make sure to follow these steps before submitting your issue - thank you!

[ ] I have checked the superset logs for python stacktraces and included it here as text if there are any.
[ ] I have reproduced the issue with at least the latest released version of superset.
[ ] I have checked the issue tracker for the same issue and I haven't found one similar.

Additional context

I suspect we're not seeing all your data in the screenshot. The scale of the color considers the entire value range... so if you have values of 1, 2, 3, 10000, you'll barely be able to see the color of the lower values, but the 10000 will be full opacity.
Closing this as stale since it's been silent for so long, and we're trying to steer toward a more actionable Issues backlog. If people are still encountering this in current versions (currently 3.x) please re-open this issue, open a new Issue with updated context, or raise a PR to address the problem. Thanks!


Continuing Improvement: Ebook Ingestion

Title.
Current process is to use pypandoc to convert the epub to txt.
Seems ebooklib might be useful once it hits v1.0.
Also would like to be able to auto-handle more than just epub.

Issue #170 will add djvu file support.


Styling SDC Questionnaire Components

I am new to using Open Health Stack and the SDC library.
I have been having some issues with replicating the exact UI as the image that I have attached below. I am looking forward to some suggestions on how to go about this. A sample questionnaire JSON file will be of great help.

Thanks for raising this. @Victor-El, this questionnaire from the catalog app: https://github.com/google/android-fhir/blob/master/catalog/src/main/assets/layout_default.json has some similar questions in your screenshot above. Please try it out. If you want to try the catalog app follow the instructions here: https://google.github.io/android-fhir/use/SDCL/Demo-app/
Question for you: in your phone number question, is the country code a fixed value or is it something the user can change?
You may want to take a look at this: https://github.com/google/android-fhir/blob/master/datacapture/src/main/java/com/google/android/fhir/datacapture/contrib/views/PhoneNumberViewHolderFactory.kt if you have specific requirements for phone numbers.


Symfony 3 problem with /cache, /logs permissions.

Well, here goes again (not in this repo but in general)
As I understand this docker configuration for building symfony application heavily depending on files on host machine via volumes.
But, then comes the problem with permissions.
Ideal setup: logs, cache etc inside docker container and also just "mirrored" via volumes.
Actual problems come when Symfony tries to write and as I guess encounters permission denied to files on host folders, mirrored via volumes.
So there actually for every docker restart and symfony cache:clear should be additional instruction on host machine, like chmod and rm -rf old logs etc.
Is it even good approach for Symfony docker application to not have logs via volumes and expose volumes just to web/, app/, vendors/, src/ so assets symlinks would work for nginx container?
Also wondering, why nginx logs volumes do not have this problem :/

Related #54

Hey,
Did you try this solution?
https://github.com/maxpou/docker-symfony/issues/54#issuecomment-297479066

Also wondering, why nginx logs volumes do not have this problem :/

Probably because it's the correct user


How to temporarily disable the datepicker control?

I'm using the datepicker in multi-select & 'embedded/inline' mode, as a permanently-visible datepicker/calendar component that's used to select multiple dates to submit to the server for further processing. While the dates are being handled & processed, the datepicker needs to be in a disabled, 'read-only' state, only serving as visual confirmation of the dates that are currently being processed.
So, I urgently need a means to toggle the datepicker from a normal state to a temporarily disabled/read-only state (don't allow any changes to either the date range or to the selected dates), while still keeping it visible, and maintaining the currently-selected dates.
It doesn't seem that the current code offers this functionality, so I'm both asking for it as a feature request, and also need advice on where in the code I could quickly hack&implement this. Can anyone please help?

FYI, for anyone interested, I ended up adding the following two functions:

disable: function(){
	this._detachEvents();
	this._detachSecondaryEvents();
	return this;
},
enable: function(){
	this._attachEvents();
	this._attachSecondaryEvents();
	return this;
},

This effectively allows me to force the datepicker to be read-only by removing any attached event listeners, and vice versa... Perhaps there's a better, more elegant way to integrate this, but, for my purposes, it's good enough.
The only issue with the above solution is that it doesn't remove highlighting effects when mousing over the datepicker. These effects are currently implemented via :hover css rules, and, as far as I know, there's currently still no simple way to programmatically change/remove a css  :hover rule via javascript.

Many thanks for this workaround !


Extra spacing between tab and tab content in IE 11

Describe the bug
There appears to be extra spacing (or offset) between tab and tab content in IE 11.
IE 11:

Chrome:

How to reproduce
I have provided a stackblitz.io example:
https://angular-fhovtt.stackblitz.io
Expected behavior
I would expect the output would be similar given that no additional application styling has been applied.
Versions
App

Angular: 8.0
Node: 12.9
Clarity: 2.0

Device:

Type: Dell Latitude
OS: Windows 7 Pro
Browser IE 11, Chrome
Version IE (11.0.9600.19403), Chrome (76.0.3809.100)

Additional notes
Add any other notes about the problem here.

I investigated this problem and I found out that there is a display: inline that cause this issue.
If you remove it, the extra spacing disappear. I tested it on Chrome, Mozilla, Edge and IE 11 and seems like this fix doesn't affect the usability.

I just testing this fix in v2.3.0 and it does correct the issue with extra spacing, however it broke the layout of components within the tab control.  In v2.2.2, a Datagrid component within a tab control would render to fill the width of the page.  In v2.3.0 in does not.  The also has a major impact on Flex Grid layouts which render with almost no width at all (which I recently reporting in #4035).

@davidrourke Does the demo from #4035 cover this scenario as well?

@gnomeontherun The tab spacing issue from this scenario was fixed, however as you can see from the screenshots and the demo, the fix introduced a bug in the layout of components.

Any update on when this will be fixed?  I am stuck on v2.1.2 and could really use some of the other fixes in newer release, but I can't because of issue's I've reported with IE 11.

Given the holidays, things have not been picked up. I'm marking it for review at next backlog review.

@gnomeontherun can you tell me when this is going to be fixed?  We have a large customer base that is still using IE11.  I really would like to update to your latest v2.x release, but I can't because if this issue and the other's that I reported.

I understand its a problem for you, and this could be a great contribution candidate since we haven't had capacity to prioritize this work. If you are able to help us isolate and identify a fix, we'd be happy to get it in.


IYO: login endless loop

Used to login with<EMAIL_ADDRESS>but since this is no longer supported I tried to login with IYO. I have added<EMAIL_ADDRESS>my IYO account, verified it and added it to shared info with tf_freeflow pages. But it will not login to my account, it just redirects me to the frontpage without any feedback.

Fixed


chore: add comments for mockRegistry vs actual registry

What does this PR do?
We mentioned in #380 that it would be helpful for users if there is a comment at the top of mockRegistry.ts explaining what it is and why they would use it rather than the actual registry.json.
What issues does this PR fix or reference?
@W-9620029@, #380
Functionality Before
There is no change in functionality.
Functionality After
There is no change in functionality.

@shetzel Let us know if you were looking for anything else!


Serve GIF file instead of webp in server mode

Currently render command has a switch (--gif) to create a GIF file. But when you use serve command, this option is missing. I am trying to use this with a device than doesn't have webp available, but GIF is supported. Is it possible to add such support? Thanks

Definitely open to a PR for this (pixlet serve --gif).


value for partitions

Hi  @tanghaibao and @tangerzhang,
I have allotetraploid plant genome (3G) each haplotype should have 19 chromosomes. Is the value for partitions k = 19?
Thank you in advance,
Michal

Hi Michal,
That depends on how many sets of haplotypes are assembled. If you are working on an allo-tetroploid genome, it is likely that two sets of haplotypes are assembled, similar like tobacco and cotton genomes. If so, K should be set to 19*2, i.e. 38.

Hi @tangerzhang, should I count the organelles?
I.e I have a plant haploid genome = 10.
Should I use 10 or 11 for K because I guess one of the scaffold will be the chloroplast one.

Hi @Juke34
There is no need to count the organelles. The K value should be set to 10 in your case.
The chloroplast and mitochondria genomes should be left as unanchored sequences in ALLHiC results.
Alternative, you can remove the organelle sequences before running ALLHiC.


Update Composer dependencies (2024-01-12-00-17)

Visual regression test passed!
View the visual regression test report


Fix huge memory usage during compilation of embed-go files

This very small change fixes memory usage during compilation. When compiling the swagger ui 1.2 dist folder it required up to 4GB of RAM during compilation. Now it's negligble. The underlying issue in the compiler is here: https://github.com/golang/go/issues/14082
This also has the side effect of creating smaller generated files.

The change changes the format of the generated strings from byte array to strings with '\x' escape codes for the special characters.

The 2nd commit fixes a situation defined in your example:
conf := rice.Config{ 		LocateOrder: []rice.LocateMethod{rice.LocateEmbedded, rice.LocateAppended, rice.LocateFS},
	}
box, err := conf.FindBox("example-files")
this was not working

👍 would love it if this was merged.

@vrecan you can use my fork if that works for you.

@GeertJohan can use your fork and it works for all of us. 😠

Sorry all, I totally missed this PR :fearful:
Thanks a lot @ReneKroon!


Pulsar manager successfully added the administrator account with password "admin", but the web login password can not be less than 6 digits.

Describe the bug
Pulsar manager successfully added the administrator account with password "admin", but the web login password can not be less than 6 digits.

The issue had no activity for 30 days, mark with Stale label.

Fixed by https://github.com/apache/pulsar-manager/pull/393.


update "both" command to use actual mpf call

Currently "mpf both" uses os.fork() to call "mpf mc" and "mpf game". But if you have mpf installed differently where you need to run, for example, "python3 -m mpf both", then it will fail since it calls "mpf mc" instead of "python3 -m mpf mc", etc.

nice work! I'll keep this open until I do a similar thing for windows

done


Translate: guides/telemetry-micrometer-tutorial.adoc

Can you open a draft PR and link this issue to it? Because it's currently not easy to check how it's coming along.


fix(@schematics/angular): component spec with export default

PR Checklist
Please check to confirm your PR fulfills the following requirements:

[x] The commit message follows our guidelines: https://github.com/angular/angular-cli/blob/main/CONTRIBUTING.md#-commit-message-guidelines
[x] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been added / updated (for bug fixes / features)

PR Type
What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?
The generated spec was using the same import when it should be adapted if exportDefault is used:
import { UserComponent } from './user.component.ts`

What is the new behavior?
It now produces:
import UserComponent from './user.component.ts`

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

The changes were merged into the following branches: main, 19.0.x


Impossible to import Spleeter/Deezer environment

Hello,
When trying to import Spleeter/Deezer environment to Anaconda.Navigator, I get this error message :
ScannerError('while scanning for the next token', None, "found character '%' that cannot start any token", <ruamel_yaml.error.StringMark object at 0x000001D6EA8B3040>)
I don't know what the problem is. I have already tried to redownload the spleeter-master zip but it didn't work.
FYI, I have a PC with Windows 10.
Please, could someone help me with this issue ? Thanks very much in advance for your help and time !
Best regards,
80anny

What commands are you running with this import?
What versions of Python and Conda are you running on your machine? The error message seems to indicate that it is a problem with the  ruamel.yaml package. Try updating Conda and Python to their latest versions and try installing again.
Let me know if that helps.


ci: update github actions for k8s-1.29

kubernetes 1.29 is release recently, updating the
github action for the same.

/test ci/centos/mini-e2e-helm/k8s-1.29

/test ci/centos/mini-e2e/k8s-1.29

/test ci/centos/k8s-e2e-external-storage/1.29

/test ci/centos/k8s-e2e-external-storage/1.29

You will also need to add 1.29 to the jobs in the ci/centos branch. Otherwise this comment does not get picked up by the CI.

/test ci/centos/k8s-e2e-external-storage/1.29

You will also need to add 1.29 to the jobs in the ci/centos branch. Otherwise this comment does not get picked up by the CI.

Thanks @nixpanic
Updated here, https://github.com/ceph/ceph-csi/pull/4359

/test ci/centos/k8s-e2e-external-storage/1.29

@mergifyio queue


THRIFT-2998: Set Content-Type for HTTP request in Node.js wrapper. Done similar to th...

...e Python wrapper here:
https://github.com/apache/thrift/blob/master/lib/py/src/transport/THttpClient.py#L127
Without this header, connecting to some servers results in error response. (THRIFT-2998)

@RandyAbernethy Looks like a good workaround for now. Any reason not to merge? :smile:

No worse than no header I suppose, however Thrift media types are now per protocol and registered with IANA:
http://www.iana.org/assignments/media-types/media-types.xhtml#application

vnd.apache.thrift.binary
vnd.apache.thrift.compact
vnd.apache.thrift.json

Would be nice if we could mount a Thrift wide effort to get these into Thrift v1.0. If you need application/x-thrift in the mean time I suppose we could commit it with a TODO.
Thoughts?

IMHO client code should always send the IANA-registered types, while servers should accept application/x-thrift as an alias for application/vnd.apache.thrift.binary (probably for a long time).

I am only porting the fix from the python wrapper in order to make the node wrapper actually work. I don't know enough about Thrift to have a thought about what it should or should not do instead, but I am certain that with the server I attempted to use this with, only the application/x-thrift header worked. The IANA header did not work, so using the IANA header will not work in my case.

@RandyAbernethy agree with your suggested approach of committing this and creating a backlog story to tackle the larger IANA registered media type as a follow up

It's rebased now.

By the way -- it's been nearly three years and I have since switched to another way of doing things. You can close the PR if nobody else needs it.

@tstanev Thank you for putting in the time.  The PR backlog on the project is getting better - there were over 100 PRs at the beginning of the year and we're down to 50, so every little bit helps.  Of course today of all days Travis CI is having some pretty nasty issues with Docker Hub. :)

To properly test this fix I need to add http transport support to the nodejs cross programs, so I'll do that as part of the effort.


fix (frontend): Partially fixes lineage issues and dataset API handling

This PR fixes the following issues:

https://github.com/linkedin/datahub/issues/1827
https://github.com/linkedin/datahub/issues/1823

Both of which likely stem from the same root cause: that the datasets response for the open source midtier (datahub-frontend) no longer matches with how we are handling datasets in datahub-web internally. This PR doesn't create a perfect parity between the two but should bring us a little closer to how components are currently consuming dataset data.
Upon testing, it looks like the lineage issue is solved and other components are currently working fine.

Will rely on automated tests with the build for the rest.
Checklist

[ ] The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
[ ] Links to related issues (if applicable)
[ ] Tests for the changes have been added/updated (if applicable)
[ ] Docs related to the changes have been added/updated (if applicable)

LGTM


[Feature]: Config to make waystones not craftable.

Description
Hi there,
In my modpack, I have multiple traversal options that are added in such as Create with its trains.
In an effort to encourage players to use those instead of just waystoning everywhere, I would like to make it so waystones cannot be crafted and are only placed in villages when generated.
Describe the solution you would like
A simple "Is craftable" boolean config option that changes the item recipe to require something that isn't normally obtainable in game.
Anything else?
Thank you for taking the time to consider this :smile:

Check the wiki.


Progress messages garbled during "draft up" on Windows

When I run a "draft up" on Windows 7 I see garbled characters in both in CMD and PowerShell.

Sure. Any tips on how to build draft on Windows 7? I've not used Go before but it's on my list of things to learn so happy to use this as a vehicle to do that.

To be honest it's probably best to use the pre-compiled canary release instead. A lot of the development process centers around macOS/Linux as the development machine of choice.
If you'd like to use a pre-compiled release of Draft, you can use the canary releases to test this out :) Canary releases of the Draft client for Windows can be found here: https://azuredraft.blob.core.windows.net/draft/draft-canary-windows-amd64.zip

Ah. I did wonder if cross-compiling was the normal way of doing Windows builds.
Test looks good. Screenshot is below.
One minor point to note is the square betweeen the "SUCCESS" and the timing which doesn;t quite look right.

Yeah that's the emojis which are being tracked in #304 so we can go ahead and close this :)


Update/Fix NDC Calculation

Something went sideways with new graphics + physics raycasting. Odd, they shouldn't really be related, but check out ToNormalizedDeviceCoordinate() and GetScreenExtent().

Look at Camera::CastToNearAndFarPlanes(). Its due to the projection y being negated now.


Track ABDM Transactions

Track all ABDM transactions, this would be used for analytics and dashboard.

[ ] Along with tracking ABDM transactions, track ABDM record (health information) access.


Reconnections in C# SDK

This is required for iOS certification. The app needs to be able to reconnect to the server without reloading the app.
I've opened this PR which fixes some surface level issues: https://github.com/clockworklabs/com.clockworklabs.spacetimedbsdk/pull/168
However, indexes are broken right now because of some static data we're holding onto after a connection is lost. This needs to be fixed in order for the game to operate correctly after a reconnection.

How are you implementing reconnection that's broken right now? The only way we currently intend to support is by constructing an entirely new DbConnection. Assuming a correct implementation of the SDK API spec, this should share zero state with the former connection.
One could imagine, in the future, adding a mechanism for a DbConnection to attempt to reconnect, automatically resuming its subscriptions &c, but to the best of my knowledge no such thing currently exists.

How are you implementing reconnection that's broken right now? The only way we currently intend to support is by constructing an entirely new DbConnection. Assuming a correct implementation of the SDK API spec, this should share zero state with the former connection.
One could imagine, in the future, adding a mechanism for a DbConnection to attempt to reconnect, automatically resuming its subscriptions &c, but to the best of my knowledge no such thing currently exists.

Yeah that's how I was implementing reconnections is essentially by just creating an entirely new DbConnection and redoing all of the connection logic. I think there was a discussion in discord about this so I won't rehash it but I think the plan for now is that you must create a new DbConnection when reconnecting, although as you say it would be easy to improve this in the future with just allowing reconnections (even possibly automatically reconnecting).


Define URIs

Ontologies' URIs have to be defined and implemented accordingly.

URIs defined and implemented. Closing.


EPIC Onboarding - 1. Validate Test Files [ETOR]

Acceptance Criteria

[x] Sample file from sender received by RS team
[x] Sample files saved to Keybase by assigned RS engineer
[x] Sample file ingested into RS using validation UI tool by assigned RS engineer
[ ] Feedback provided to sender by assigned RS engineer  (including instructions on what to modify in order to get validated)*
[ ] Sender modifies and re-sends sample file to get file validated by RS engineer*

*Steps can continue until RS can ingest the file from sender
To Do

[x] RS engineer: update this ticket with comments with every interaction with sender
[ ] RS team member who originates this ticket: add any dependencies, as needed
[ ] RS team member who originates this ticket: make sure the following are included when creating this Issue.

[ ] Pipelines: Onboarding & Operations (New)
[ ] Labels: "Onboarding-ops" and "Sender"
[ ] Epics: [select the epic for this API onboarding sender]

From Ott: Flexion came back to say everything is not ready to close. There is some encryption work that still needs to be implemented, and we are waiting for a response from them (Postman) to continue work.

Encryption working for UCSD EPIC. Now waiting on Flexion team to successfully route test messages to UCSD EPIC endpoint. Ott helping where necessary.

Testing with Postman"

Done for staging.


rem-calc warning

I was wondering why margin: rem-calc(16px auto); issues a warning

rem-calc does not accept auto as a parameter.
This will work though:  margin: rem-calc(16px) auto;

Closing this as it has been answered. Any problems though feel free to re-open this issue.


PHPUnit ExceptionHandler is not instantiable

Laravel Version: 5.5.33
PHP Version:7.1.7

Description:
Unfortunately, even though there are a lot of issues on this topic already, it seems non of the solutions apply to my problem.
The error thrown is
Illuminate\Contracts\Container\BindingResolutionException: Target [Illuminate\Contracts\Debug\ExceptionHandler] is not instantiable. in /home/vagrant/code/repo/vendor/laravel/framework/src/Illuminate/Container/Container.php on line 918

Call Stack:
    0.0003     355328   1. {main}() /home/vagrant/code/repo/vendor/phpunit/phpunit/phpunit:0
    0.0763    2739528   2. PHPUnit\TextUI\Command::main() /home/vagrant/code/repo/vendor/phpunit/phpunit/phpunit:53
    0.0763    2739640   3. PHPUnit\TextUI\Command->run() /home/vagrant/code/repo/vendor/phpunit/phpunit/src/TextUI/Command.php:148
    0.1579    4617032   4. PHPUnit\TextUI\TestRunner->doRun() /home/vagrant/code/repo/vendor/phpunit/phpunit/src/TextUI/Command.php:195
    3.9158   36512712   5. PHPUnit\TextUI\ResultPrinter->printResult() /home/vagrant/code/repo/vendor/phpunit/phpunit/src/TextUI/TestRunner.php:552
    3.9165   36512712   6. PHPUnit\TextUI\ResultPrinter->printErrors() /home/vagrant/code/repo/vendor/phpunit/phpunit/src/TextUI/ResultPrinter.php:197
    3.9165   36512712   7. PHPUnit\TextUI\ResultPrinter->printDefects() /home/vagrant/code/repo/vendor/phpunit/phpunit/src/TextUI/ResultPrinter.php:292
    3.9168   36512712   8. PHPUnit\TextUI\ResultPrinter->printDefect() /home/vagrant/code/repo/vendor/phpunit/phpunit/src/TextUI/ResultPrinter.php:243
    3.9171   36512712   9. PHPUnit\TextUI\ResultPrinter->printDefectTrace() /home/vagrant/code/repo/vendor/phpunit/phpunit/src/TextUI/ResultPrinter.php:256
    3.9253   36556000  10. Illuminate\Foundation\Bootstrap\HandleExceptions->handleShutdown() /home/vagrant/code/repo/vendor/laravel/framework/src/Illuminate/Foundation/Bootstrap/HandleExceptions.php:0
    3.9274   36581224  11. Illuminate\Foundation\Bootstrap\HandleExceptions->handleException() /home/vagrant/code/repo/vendor/laravel/framework/src/Illuminate/Foundation/Bootstrap/HandleExceptions.php:123
    3.9314   36592968  12. Illuminate\Foundation\Bootstrap\HandleExceptions->renderForConsole() /home/vagrant/code/repo/vendor/laravel/framework/src/Illuminate/Foundation/Bootstrap/HandleExceptions.php:87
    3.9314   36592968  13. Illuminate\Foundation\Bootstrap\HandleExceptions->getExceptionHandler() /home/vagrant/code/repo/vendor/laravel/framework/src/Illuminate/Foundation/Bootstrap/HandleExceptions.php:101
    3.9314   36592968  14. Illuminate\Foundation\Application->make() /home/vagrant/code/repo/vendor/laravel/framework/src/Illuminate/Foundation/Bootstrap/HandleExceptions.php:159
    3.9314   36592968  15. Illuminate\Foundation\Application->make() /home/vagrant/code/repo/vendor/laravel/framework/src/Illuminate/Foundation/Application.php:732
    3.9315   36592968  16. Illuminate\Foundation\Application->resolve() /home/vagrant/code/repo/vendor/laravel/framework/src/Illuminate/Container/Container.php:586
    3.9315   36592968  17. Illuminate\Foundation\Application->build() /home/vagrant/code/repo/vendor/laravel/framework/src/Illuminate/Container/Container.php:631
    3.9315   36593080  18. Illuminate\Foundation\Application->notInstantiable() /home/vagrant/code/repo/vendor/laravel/framework/src/Illuminate/Container/Container.php:758

Steps To Reproduce:
I use this in my composer.json
"require-dev": {
        "filp/whoops": "~2.0",
        "fzaninotto/faker": "~1.4",
        "mockery/mockery": "~1.0",
        "phpunit/phpunit": "~6.0",
        "symfony/thanks": "^1.0"
    },

I also symlinked /usr/bin/phpunit to ./vendor/bin/phpunit, so the phpunit version I'm using is not a global one and I uninstalled all global ones, just to be sure.
here is my phpunit.xml
<?xml version="1.0" encoding="UTF-8"?>
<phpunit backupGlobals="false"
         backupStaticAttributes="false"
         bootstrap="vendor/autoload.php"
         colors="true"
         convertErrorsToExceptions="true"
         convertNoticesToExceptions="true"
         convertWarningsToExceptions="true"
         processIsolation="false"
         stopOnFailure="false">
    <testsuites>
        <testsuite name="Feature">
            <directory suffix="Test.php">./tests/Feature</directory>
        </testsuite>

        <testsuite name="Unit">
            <directory suffix="Test.php">./tests/Unit</directory>
        </testsuite>
    </testsuites>
    <filter>
        <whitelist processUncoveredFilesFromWhitelist="true">
            <directory suffix=".php">./app</directory>
            <exclude>
                <file>./app/routes/api.php</file>
            </exclude>
        </whitelist>
    </filter>
    <php>
        <env name="APP_ENV" value="testing"/>
        <env name="CACHE_DRIVER" value="array"/>
        <env name="SESSION_DRIVER" value="array"/>
        <env name="QUEUE_DRIVER" value="sync"/>
    </php>
</phpunit>

I tried it with and without excluding the routes. I don't know what it does but I found it in some answers of people who had the same problem. But I guess it could also be related to an older version of either Laravel or phpunit.
I have a subpackage in which the following line is used to register an ExceptionHandler for the contract one in the ServiceProvider
$this->app->singleton(
            \Illuminate\Contracts\Debug\ExceptionHandler::class,
            ExceptionHandler::class
        );

The exception handler and everything works fine when I use it normally in the application AND it also works with phpunit, as long as I have only one test defined. I have the following two tests which on its own both succeed.
<?php

namespace Tests\Feature;

use DB;
use Tests\TestCase;
use Illuminate\Foundation\Testing\WithFaker;
use Illuminate\Foundation\Testing\RefreshDatabase;

class ToolsRoutesTest extends TestCase
{
    /**
     * A basic test example.
     *
     * @return void
     */
    public function testBuildIdeHelper()
    {
            /** @var \App\User $user */
        $user  = factory(\App\User::class)->states('admin')->create();
        $token = \JWTAuth::fromUser($user);

        $response = $this
            ->withMiddleware('jwt.auth')
            ->post('api/v2/tools/build-ide-helper', [], ['Authorization' => "Bearer $token"]);

        $response->assertStatus(200);
    }
}

and
<?php

namespace Tests\Feature;

use Log;
use Tests\TestCase;
use Illuminate\Foundation\Testing\WithFaker;
use Illuminate\Foundation\Testing\RefreshDatabase;

class WebHomeTest extends TestCase
{
    /**
     * A basic test example.
     *
     * @return void
     */
    public function testExample()
    {
        $response = $this->withoutMiddleware(['cache.route'])->get('/');

        $response->assertStatus(200);

        $response = $this->withoutMiddleware(['cache.route'])->get('/home');

        $response->assertStatus(200);
    }
}

I seriously tried lots and lots of things and most of the issues that are closed now are still from L5.1/2/3 and the solutions don't work for me. Also I saw that some people asked similar questions to mine, inside those closed issues. But since they are closed I guess nobody is gonna reopen them and answering the question.
So I hope, with creating a new issue, I can get this solved.

Please ask on the forums, this repo is for bug reporting only. You can use https://laracasts.com/discuss or https://laravel.io/forum which are forums with a very large community of developers helping each other.


Option to add a 'Context' to the Validate() method in the form of an object

Hello,
In our project we need to validate objects to a certain context (some object tree) to check if the relations are valid within the context. As for now we put the 'context' object in the constructor of the validator, wich is fine for now. But this has the restriction that every time the context changes, the validator needs to be created again. As a result the validator cannot be instantiated as a singleton as it is advised here:
https://github.com/JeremySkinner/FluentValidation/wiki/b.-Creating-a-Validator#a-note-on-performance
Maybe something like this is possible: [Valiator].Validate(object instance, object context)
In the validator we could cast the context to the right object and use it to do the comparison. I could imagine the context could only be retrieved in the Custom() method. The custom woud change from:
Custom(instanceToValidate => {
[Do comparison]
});

To:
Custom(instanceToValidate, context => {
[Do comparison]
});

With kind regards,
Cees van Altena

Thanks for the suggestion.
FluentValidation's validators are designed to interact with a single object with multiple properties, so the usual way of doing this would be to expose the context as a property on the object being validated, rather than passing the context in separately. Eg:
public class MyContext {
  public string Whatever {get;set;}
}

public class Person {
  public string Name{get;set;}
}

public class PersonAndContext {
  public Person Person{get;set;}
  public MyContext Context{get;set;}
}

...and then the validator would be defined on the PersonAndContext rather than the Person directly:
public class MyValidator:AbstractValidator<PersonAndContext> {
  public MyValidator() {
    RuleFor(x => x.Person.Name).NotEqual(x => x.Context.Whatever);
  }
}

Hope that makes sense.
Does that solve what you're trying to do, or is there a particular use case where this wouldn't work?
Jeremy

Hmm it is a solution that could work but I think it would be cleaner if FluentValidation would support this because the "object against context" logic would remain in FluentValidation. With your proposal, validation logic is leaking outside FluentValidation with creating the custom PersonAndContext object. What is your vision about this?

So FluentValidation's purpose is to validate properties on a single object...adding direct support for some sort of context in this way is really beyond the scope of what I'm trying to achieve with the project. It also wouldn't work with the way that rules are defined, which only have access to the object being validated.
If you need this kind of cross-object comparison (whether it's a context, or any other type of object) then this is the way you'd need to do it.
Hope that makes sense.
Jeremy

Thank you for your explanation, I understand.
Just some side info: Although we had already suspected that it was made for Form/Screen state validation, we use it for data validation within an object tree. It works like a charm! My compliments.

Thanks! I appreciate it.

Actually with DI (like AutoFac) you are able to access any registered object, and yes, there are FluentValidation samples with AutoFac. You gain the possibility to inject any kind of service into the ValidationObject itself, so you would be able to query the second object (or do any DB related checks).... So you get actually a very similar behaviour as the IValidatableObject works with DI set up (or without any extra code in MVC6/Core)...


moving files up a directory level

@JamesEarle,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot


Exercise workfrom on analytical shape, investigate effect of curvature

Hi @elejeune11
I am trying to start to run our workflow from pixel $\mapsto$ isosurface $\mapsto$ mesh.  I want to study the effect of resolution, which I believe will be driven by local curvature, starting with the sphere analytical shape.
I have started documenting this workflow here:  https://github.com/autotwin/pixel/blob/main/doc/spherical_baseline.md
Question for you:

Do you know of a tool that I can use to provide an analytical shape (e.g., sphere of radius 10 cm), and have it output triangular isosurfaces of various resolution?

moved to mesh repo


⚠ Bofrost.de has degraded performance

In 9d9d23d, Bofrost.de (https://www.bofrost.de) experienced degraded performance:

HTTP code: 200
Response time: 2298 ms

Resolved: Bofrost.de performance has improved in 7311609 after 9 minutes.


Help on lightbox

pl let me know how to open lightbox on page load.

       This is My Light Box.

$(document).ready(function () {
$("#MyLightbox").lightbox("Show");
});
it just shows grey screen but model doesnot appear

Hi @anandbohra
Apologies for the slow reply. It's been a while since I looked at the library.
There is no lightbox method in the library. I'm not sure you're in the right place?
The model plugin documentation is here.
https://responsivebp.com/javascript/modal/


Update _build.yml

Module: 00
Lab/Demo: 00
Fixes # .
Changes proposed in this pull request:

did it for testing

did it for testing


feat: step titles are now clickable

Hey, I just made a Pull Request!
Step titles are now clickable and directly redirect you to the corresponding step. This is an alternative to using the back buttons.

:heavy_check_mark: Checklist

[x] A changeset describing the change and affected packages. (more info)
[x] Added or updated documentation
[x] Tests for new functionality and regression tests for bug fixes
[x] Screenshots attached (for UI changes)
[x] All your commits have a Signed-off-by line in the message. (more info)

Related Issue
Closes #21260

Hey, I can imagine that at some cases it might be useful.
Can you please add also unit tests for this?

Just thinking from a UX POV here, do we expect it to make sure that the current step is valid? Or how do we surface errors from previous pages when clicking next?

Just thinking from a UX POV here, do we expect it to make sure that the current step is valid? Or how do we surface errors from previous pages when clicking next?

@benjdlambert I think this should work as the back button is working now, so if we are missing something on step n but instead of pressing next we press back, the user goes to step n-1 without validating step n. Some thing should happend here, if we click on the step we do not validate our current step, we will validate it when the next button is clicked in step n. What do you think?

@fedy97 I think it sounds a little unfortunate that we validate on the next call and not on the actual tab change when we click the navigation item. It feels a little clunky IMO, and not being able to validate that the previous steps are valid before seeing the current one could break some behaviour.
Thinking a little forward, there could be scenario where some parameters in earlier steps affect the values that's required later on in the form, it feels a little unfortunate to be able to click to step-3 fill out some things, and then back to step-1 to for those values to change something else in the form later on. Does that make sense? Can you see what I mean?

Also, maybe just to clarify and maybe this is what you already meant, but I'd be happy to add the ability to go back to a previous step by clicking, but not navigating forward.

@fedy97 sorry, I deleted my previous comments because now I realised that's whats happening in the PR 😊
Now I understand the use case, and the implementation makes sense. Only navigating backwards using the click is fine, but never forward because of parameter dependencies and validation reasons.

@fedy97 sorry, I deleted my previous comments because now I realised that's whats happening in the PR 😊
Now I understand the use case, and the implementation makes sense. Only navigating backwards using the click is fine, but never forward because of parameter dependencies and validation reasons.

yes, that is what I meant sorry for the misleading explanation 😄


/Zc:__cplusplus leads to C2416

OS: Windows 7
Compiler: MSVC 2017 (15.9.11)
If project uses /Zc:__cplusplus json lib v3.7.0 fails to compile with this:
C2416: attribute 'deprecated' cannot be applied in this context

Looks like MSVC doesn't like this attribute applied to operator>> definition.

I don't see why there is any bug here. Can you explain why the deprecated attribute is not legal in that context?

I assume it complains because [[deprecated]] attribute was applied to definition. According to C++17 draft I have (10.6.4.p2):

The attribute may be applied to the declaration of a class, a typedef-name, a variable, a non-static data member, a function, a namespace, an enumeration, an enumerator, or a template specialization.

Looks like MS read it as "can't happen on a definition". I have no opinion about correctness of this position.

Yeh, that's a nuance that I can't make a call on myself. Dumb fix would be just to disable C2416 for this file :)

Bad bot!

Not sure how the project rules here are with respect to selectively disabling warnings but why not propose a PR which uses pragma push/pop logic for MSVC to disable that warning for this piece of code? See https://stackoverflow.com/a/18463996 as a starting point.

or I could simply patch this lib in my vcpkg instance and avoid dealing with PR/etc ;)

I'm seeing this too.

This should be fixed on develop branch as it contains an updated version of Hedley. Can anyone try this?

I've added a PR which compiles with /Zc:__cplusplus. Let's see if that works now.

Fails in CI as well, see https://ci.appveyor.com/project/nlohmann/json/builds/28319126/job/qp8uvagt7i56g5bp.
@mrstux The best thing here is to fix the issue in https://github.com/nemequ/hedley, then incorporat the changes into the linked PR.

It's not about the definition. MSVC chokes on the friend. Using "__declspec(deprecated)" does not trigger the warning.

@nlohmann Please reopen.

any progress here? As far as I know, the easy way is to disable the attribute for windows by:
#if defined(__cplusplus) && (__cplusplus >= 201402L) && !defined(_MSC_VER)

BTW: MSVC sucks on this and the __cplusplus marco bug.

@LanderlYoung The upstream bug in hedley was fixed.
@nlohmann How do I upgrade to a newer hedley version?

@t-b
I had compared the current version and the newest version of hedley.
There are not a lot of differences or special changes. So it maybe ok to update the source codes.

I upgraded Hedley to version 13 in https://github.com/nlohmann/json/tree/feature/update_hedley - can someone check if this fixes this issue?

@nlohmann Yeep, I've rebased https://github.com/nlohmann/json/pull/1958.

Is the 3.7.4/3.4.0 with this fix planned anytime soon? I use bitsery with std::variant and that requires /Zc:__cplusplus for MSVC to set the correct __cplusplus value for C++17.

The next release will be version 3.8.0. I'm not sure how much more time I will need until it is ready.

@nlohmann Is there anything I can help out with towards the 3.8.0 release?

Not really - but if you are using MSVC and want to help, you may want to have a look at https://github.com/nlohmann/json/pull/2117.


175B opt model seems to output gibberish

❓ Questions and Help
What is your question?
We recently downloaded the open sourced OPT-175B weight and managed to set it up using our own Alpa system, and tried to play with it. Thanks for the effort of making it public!
Unfortunately, we found that the175B model outputs gibberish. An example:
Prompt: Computer science is the study of computation
Output: Computer science is the study of computation and a gotten hoped planned done hoped also to practice to to a come to become nothing to to good taken become hoped to placed originally better only to to just gotten better just given done issues hoped good come come some'
The way we process the 175B model is as follows:

use the scripts/reshard_mp.py to merge FSDP shards (192) into one for each model-parallel part, resulting in 8 parts.
use the scripts/consolidate_fsdp_shard.py to merge the 8 parts into one consolidated version (the core function used here is glue_megatron_parts())
then we load this model into our system.

All the other models processed following this procedure (from 125M to 30B ones) work pretty well, except that the 175B outputs gibberish.
We also cross-checked with HuggingFace's implementation models from 125M to 30B -- the output logits are the same on models. Hence it shouldn't be a problem of the Alpa system.
Here is our model spec: https://github.com/alpa-projects/alpa/blob/torch_transformer_model/playground/model/opt_model.py#L499
We're wondering if you could give any hints? Several questions:

we downloaded the 992 shards about 2 weeks ago. Since then, have you updated the weights?
is there any architectural changes specific to the 175B weight we're unaware of?

What's your environment?

metaseq Version (e.g., 1.0 or master): master
PyTorch Version (e.g., 1.0): 1.10
OS (e.g., Linux): Ubuntu
How you installed metaseq (pip, source): source
Build command you used (if compiling from source):
Python version: 3.8
CUDA/cuDNN version: 11.1
GPU models and configuration: 32x V100
Any other relevant information:

Hm, can you try just consolidate FSDP directly from the MP shards?
The checkpoint hasn't changed. Our own interactive_hosted expected the MP version (your step1) if you want to compare.

@stephenroller Thanks for the response! What do you mean by "MP version"? is it the state after FSDP sharding being consolidated? If yes -- since you use MP = 8, I assume your internal script will start from 8 files (each file corresponds to an MP part), right?

@stephenroller Thanks for the response! What do you mean by "MP version"? is it the state after FSDP shards are merged? If yes -- since you use MP = 8, I assume your internal script will start from 8 files (each file corresponds to an MP part), right?

MP refers to the model/tensor parallel checkpoints. There are a version of checkpoints that are purely tensor parallel(MP) in format.

Can you also double check your md5sums? I've seen at least one person get gibberish when the consolidation script silently failed with some weird corruption we never understood.  Re-consolidating fixed it

@stephenroller we actually run the consolidation 3 times using three different methods:
(1) Use reshard_mp.py to merge 992 shards into 8 MP parts; then use consolidate_fsdp_shard.py to merge 8 parts into 1 consolidated checkpoint.
(2) Directly use consolidate_fsdp_shard.py to merge 992 shards into 1 checkpoint file (reshard_mp.py is not used here).
(3) Use reshard_mp.py to merge 992 shards into 8 MP parts, then use covert_to_singleton.py which inits the model in CPU memory and load the state dict, then use allgather the gather and merge weights.
We run np.assert_allclose() on (randomly sampled) weights of the consolidated file generated by all (1)(2)(3) -- all passed -- meaning the weights generated by any path is the same.
So it is unlikely caused by errors/bugs in the consolidation script.

I'm like 99% sure the only difference between the 30B model and the big model is number of MP shards, learning rate, and batch size. All the other architectural hyperparams were held constant.
Does your prompt have a trailing space by chance?

TL;DR:
With substantial help from @anj-s and Mingzhe's, we concluded that one of the original shards distributed by Meta is corrupted.
Details:
The shard checkpoint_last-model_part-5-shard51.pt is corrupted at the param key decoder.layers.15.flat_param_0 at  indices[1241838:1241838+18] .
if you do the following:
shard_path = "checkpoint_last-model_part-5-shard51.pt"
shard = torch_load_cpu(shard_path)
print(shard["model"]["decoder.layers.15.flat_param_0"][1241838:1241838+18])

It will output:
tensor([ 5.2691e-05,  4.5000e+03,  1.6427e-04,  5.5080e+03,  5.2256e+04,
         6.5880e+03,  3.0224e+04,  5.2631e-05,  7.5640e+03,  6.4969e-06,
         1.5259e-05,  1.5259e-05,  0.0000e+00,  5.0783e-04,  0.0000e+00,
        -0.0000e+00,  0.0000e+00, -4.8828e-03], dtype=torch.float16)

These 18 values are corrupted. As you can quickly tell, some values go to +1000s, which is very unusual for GPT weights.
It was a long story how we discover these 18 values, but essentially these 18 weights are the only 18 values that cause the difference between my consolidated version and the ground truth version (we checked MD5 and did some search).
They correspond to the fc1 weights in the 16th transformer layer (which is a critical layer compared to bias terms), and their magnitudes are substantial, I think they should be the reason that drives the model to produce collapsed outputs in my experiments.
@stephenroller Could you double check and see if our conclusion is correct? If yes -- could you update this shard, thank you!

@suchenzang Uhhh? No one else has had corrupted shards right? @patrickvonplaten, your copy is fine?
Sounds like we need to distribute md5sums.

Ack. Looking.

@stephenroller This is what I'm seeing:
(base) susanz@<old azure cluster>:/data/<redacted>/models/<redacted>/175B/raw$ md5sum checkpoint_last-model_part-5-shard51.pt
2af6ac9e2c440a29ad9ddab99af9a968  checkpoint_last-model_part-5-shard51.pt

Raw from S3:
(base) √ ~ % aws s3 cp s3://<redacted>/checkpoint_last-model_part-5-shard51.pt .
download: s3://<redacted>/checkpoint_last-model_part-5-shard51.pt to ./checkpoint_last-model_part-5-shard51.pt
(base) √ ~ % md5sum checkpoint_last-model_part-5-shard51.pt
2af6ac9e2c440a29ad9ddab99af9a968  checkpoint_last-model_part-5-shard51.pt

And from a presigned URL (backed by S3 ^):
(base) ?1 ~ % wget -O "checkpoint_last-model_part-5-shard51.pt" "https://d3q5sbpjbmb5k9.cloudfront.net/175b/checkpoint_last_20220503/checkpoint_last-model_part-5-shard51.pt?&<redacted>"
--2022-06-04 16:53:27--  <redacted>
Resolving d3q5sbpjbmb5k9.cloudfront.net (d3q5sbpjbmb5k9.cloudfront.net)... <IP_ADDRESS>, <IP_ADDRESS>, <IP_ADDRESS>, ...
Connecting to d3q5sbpjbmb5k9.cloudfront.net (d3q5sbpjbmb5k9.cloudfront.net)|<IP_ADDRESS>|:443... connected.
HTTP request sent, awaiting response... 200 OK
Length: 353677779 (337M) [binary/octet-stream]
Saving to: ‘checkpoint_last-model_part-5-shard51.pt’

checkpoint_last-model_part-5-shard51.pt  100%[================================================================================>] 337.29M  6.81MB/s    in 32s

2022-06-04 16:54:00 (10.5 MB/s) - ‘checkpoint_last-model_part-5-shard51.pt’ saved [353677779/353677779]
(base) √ ~ % md5sum checkpoint_last-model_part-5-shard51.pt
2af6ac9e2c440a29ad9ddab99af9a968  checkpoint_last-model_part-5-shard51.pt

This assumes our internal resharded checkpoints passed in /data/<redacted>/models/<redacted>/175B/raw from our old Azure cluster.  From the looks here - there isn't a file corruption issue wrt checkpoint_last-model_part-5-shard51.pt.  @zhisbug Can you confirm the md5sum you see for your checkpoint_last-model_part-5-shard51.pt file?
Will release md5sums for all the other files too: https://github.com/facebookresearch/metaseq/issues/137

@stephenroller @suchenzang
Here is what I got:
$ md5sum 175B/checkpoint_last-model_part-5-shard51.pt
b2f3995bed96db012a6046f68fce4fe5  175B/checkpoint_last-model_part-5-shard51.pt

Seems it does not match the official MD5.
My download link has expired -- is there a way I can re-download this file? Thank you!

@zhisbug Please reply to the email from where you received the original link with the above information - you will receive a fresh link afterwards.

@suchenzang Just replied!

Link has be re-sent, closing for now - please open a new issue (and link to this one) if output still seems problematic!


No value associated with key CustomCodingKeys(stringValue: "inline_traces", intValue: nil)

When calling getActions on EosioRpcProvider it returns an error:
"RpcProviderFatalError: Error occurred in decoding/serializing returned data. KeyNotFound: inline_traces No value associated with key CustomCodingKeys(stringValue: \"inline_traces\", intValue: nil) (\"inline_traces\").."

#219

https://github.com/EOSIO/eosio-swift/pull/219

Thank you for reporting this issue. This has been resolved by #226


Mass detection status

Added an indication of whether masses have been detected in the Raw data overview table
Before detection:

After detection:

Alongside a couple of smaller issues fixed:

Now row in the data table is highlighted when a chromatogram is clicked (previously a row was highlighted only after click on the table),
Scroll bar & the table itself are within pane (previously they were partially behind Tasks)

Tasks to solve:

[ ] Not all columns fit properly in the table
[ ] Table mass detection icons are updated with delay only after table is scrolled

Closes #780

You can use icons from ikonli
There are different packages but we currently use bootstrapicons-pack
https://kordamp.org/ikonli/cheat-sheet-bootstrapicons.html
FontIcon fontIcon = FxIconUtil.getFontIcon("bi-exclamation-triangle", 15,
            MZmineCore.getConfiguration().getDefaultColorPalette().getNegativeColor());


Electrostatic and linear machines

Hi!
If electrostatic and linear machines are not already implemented, which as far as I can tell they are not, what would be needed to implement these?

Hello,
I'm not familiar with these machines (I'm not an electrical engineer). Can you share some screenshot/schematics/particularity that needs to be addressed to simulated these kind of machines ? With some information I should be able to guide you in the development to add them.
Best regards,
Pierre

Hello,
This is an electrostatic machine:
https://ieeexplore.ieee.org/document/8470983

This is a linear machine:

Best,
Noam

Hello,
Thank you for sharing these information. For now pyleecan is dedicated to radial flux machines, I think we can reuse some existing parts to add both these machines but it would require to find the correct parametrization, create the corresponding objects and add/adapt the models to simulate them so a rather large work I would say. I can give some guidelines and help you on the way but I won't have the time to directly work on the subject I think.
Best regards,
Pierre


[material-ui][Link] Wrong TS infer of component props after minor version upgrade

Duplicates

[X] I have searched the existing issues

Latest version

[X] I have tested the latest version

Steps to reproduce 🕹
The following code
import { Link } from '@mui/material'

const LinkButton = ({ onClick, children }: { children?: ReactNode; onClick: () => void }) => {
    return <Link component="button" variant="body1" onClick={onClick} type="button">{children}</Link>
}

export default LinkButton

Throws a compilation error. It has been working flawlessly for over an year. I see no reason to update it. Is this a bug or a major change in MUI. Which would be weird because I only bumped the patch version, not even the minor one and this is a breaking change.
Current behavior 😯
Property onClick does not exist on type
Expected behavior 🤔
It should compile properly. It used to compile properly.
Context 🔦
I have not so legacy application that used to run MUI "5.14.2". Recently upgraded to "5.14.14" and It's throwing TSC compilation errors on code that used to work. And I'm wondering whether I should go and change my code or is this some sort of a bug
Your environment 🌎

  System:
    OS: Linux 6.5 Fedora Linux 38 (Workstation Edition)
  Binaries:
    Node: 18.18.0 - /usr/bin/node
    Yarn: 1.22.19 - /usr/bin/yarn
    npm: 9.5.0 - /usr/local/bin/npm
  Browsers:
    Chrome: Not Found
  npmPackages:
    @emotion/react:  11.11.1
    @emotion/styled:  11.11.0
    @mui/base:  5.0.0-beta.20
    @mui/core-downloads-tracker:  5.14.14
    @mui/icons-material:  5.14.14
    @mui/material:  5.14.14
    @mui/private-theming:  5.14.14
    @mui/styled-engine:  5.14.14
    @mui/system:  5.14.14
    @mui/types:  7.2.6
    @mui/utils:  5.14.14
    @types/react:  18.2.30
    react:  18.2.0
    react-dom:  18.2.0
    typescript:  5.2.2

@ltsochev-dev assing me this issue

I am not able to reproduce your issue - https://codesandbox.io/s/dry-resonance-fr4ljc?file=/src/App.tsx. Can you provide a reproduction?

Okay I can't reproduce it in codesandbox but even at the most minimalistic usage in my project I get the typescript compilation error. The component works while in DEV mode, renders as you'd expect but typescript is unhappy. So I assume my team have somehow overriden something but I can't for the life of me begin to fiture out where the issue could be happening at. I've been googling for awhile and there are other people with similar issues. In this codesandbox - https://codesandbox.io/s/cranky-taussig-kdsc23?file=/src/App.tsx - I've basically locked every version that my project has, including the theme overrides but it still doesn't come crashing down. Meanwhile in my project, the most minimal usage like so
`import { NextPage } from 'next'
import Box from '@mui/material/Box'
import Link from '@mui/material/Link'
const TmpPage: NextPage = () => {
const goToRegister = () => {
console.log('Weird flex')
}
return (

Hello World

Weird button

)
}
export default TmpPage
`
Brings this 5 page error message
No overload matches this call.   Overload 1 of 2, '(props: { component: string; } & LinkOwnProps & CommonProps & Omit<{}, "border" | "borderTop" | "borderRight" | "borderBottom" | "borderLeft" | "borderColor" | ... 109 more ... | "underline">): Element', gave the following error.     Type '{ children: string; component: string; variant: "body1"; onClick: () => void; type: string; }' is not assignable to type 'IntrinsicAttributes & { component: string; } & LinkOwnProps & CommonProps & Omit<{}, "border" | "borderTop" | "borderRight" | ... 112 more ... | "underline">'.       Property 'onClick' does not exist on type 'IntrinsicAttributes & { component: string; } & LinkOwnProps & CommonProps & Omit<{}, "border" | "borderTop" | "borderRight" | ... 112 more ... | "underline">'.   Overload 2 of 2, '(props: DefaultComponentProps<LinkTypeMap<{}, "a">>): Element', gave the following error.     Type '{ children: string; component: string; variant: "body1"; onClick: () => void; type: string; }' is not assignable to type 'IntrinsicAttributes & LinkOwnProps & CommonProps & Omit<Omit<DetailedHTMLProps<AnchorHTMLAttributes<HTMLAnchorElement>, HTMLAnchorElement>, "ref"> & { ...; }, "border" | ... 114 more ... | "underline">'.       Property 'component' does not exist on type 'IntrinsicAttributes & LinkOwnProps & CommonProps & Omit<Omit<DetailedHTMLProps<AnchorHTMLAttributes<HTMLAnchorElement>, HTMLAnchorElement>, "ref"> & { ...; }, "border" | ... 114 more ... | "underline">'.ts(2769)
How can I even begin to troubleshoot this?

@ltsochev-dev Maybe check your ts config.

Experiencing this after upgrading to react 18

Cause by an issue with @types/react having two versions installed by yarn. Some details on resolution here
https://github.com/reactjs/react-transition-group/issues/813


Bug with copy

The following test fails because the copied dictionary is empty! This is a severe bug.
from wypp import *

def wrapDict(d: dict[str, int]) -> Any: #dict[str, int]:
    return d #.copy()

d1 = {"foo": 1, "bar": 2}
d2 = wrapDict(d1).copy()
check(d1 is d2, False)
check(d1 == d2, True)
print(f"d1: {d1}")
print(f"d2: {d2}")

In the last couple of days, I improved the wrapping code used by the protocol checker. With a quick-and-dirty workaround, I also used this new code for the interface checker and the bug was fixed. Establishing a stable solution is not so easy, however, because my workaround caused other bugs.

Any ideas welcome, @CodeSteak  !

This bug has been fixed but I did not update the issue.


How to set form in error state? hasError does not set the form in error state immediately.

Version

tcomb-form v0.8.2
react v0.14.8

What I am trying to do
Based on the data I receive from the API, I need to set errors per field and set the form in error state. I am doing this with redux and I get the API response in props.signup. I am using componentWillReceiveProps to check for errors in nextProps.signup and set errors accordingly.
The problem
I can confirm the new this.state.formOptions being set in componentWillReceiveProps and render being called again, but the form itself does not render in error state.
Form is only set in error state when I edit a field for which an hasError = true has been set in componentWillReceiveProps. Say, I got error from the server for email field, "email has already been used to register an account"; the moment I edit email field, the errors I set in componentWillReceiveProps only for email field are displayed.
What am I doing wrong?
The Component
const SignupFormSchema = t.struct({
  first_name: t.String,
  last_name: t.String,
  email: EmailRefinement,
  password1: t.String,
  password2: t.String,
  accept_tos: t.Boolean
});

const signupFormOptions = {
  auto: 'none',
  error: '
Acount creation failed
',
  hasError: false,
  fields: {
    first_name: {
      error: 'First name cannot be blank',
      attrs: {
        placeholder: 'First Name'
      }
    },
    last_name: {
      error: 'Last name cannot be blank',
      attrs: {
        placeholder: 'Last Name'
      }
    },
    email: {
      error: 'Please provide a valid email address',
      type: 'email',
      attrs: {
        placeholder: 'Email'
      }
    },
    password1: {
      error: 'Please enter a password',
      type: 'password',
      attrs: {
        placeholder: 'Password'
      }
    },
    password2: {
      error: 'Please repeat the same password',
      type: 'password',
      attrs: {
        placeholder: 'Repeat Password'
      }
    },
    accept_tos: {
      label: 'I agree to terms, conditions, and privacy policy',
      error: 'You must accept the terms, conditions, and privacy policy before proceeding'
    }
  }
};

class SignupForm extends Component {
  state = {
    formValue: {},
    formOptions: signupFormOptions
  };

  onFormChange = formValue => {
    this.setState({formValue});
  };

  componentWillReceiveProps(nextProps) {
    let { signup }  = nextProps;
    let newFormOptions = this.state.formOptions;
    if(signup && signup.error) {
      newFormOptions.hasError = true;
      newFormOptions.error =
{ signup.message }
;

      if(signup.fieldErrors) {

        if(signup.fieldErrors.first_name) {
          newFormOptions.fields.first_name.hasError = true;
          newFormOptions.fields.first_name.error =   signup.fieldErrors.first_name.map(error => {
            return {error};
          });
        }
        else {
          newFormOptions.fields.first_name.hasError = false;
          newFormOptions.fields.first_name.error = signupFormOptions.fields.first_name.error;
        }

        if(signup.fieldErrors.last_name) {
          newFormOptions.fields.last_name.hasError = true;
          newFormOptions.fields.last_name.error =   signup.fieldErrors.last_name.map(error => {
            return {error};
          });
        }
        else {
          newFormOptions.fields.last_name.hasError = false;
          newFormOptions.fields.last_name.error = signupFormOptions.fields.last_name.error;
        }

        if(signup.fieldErrors.email) {
          newFormOptions.fields.email.hasError = true;
          newFormOptions.fields.email.error =   signup.fieldErrors.email.map(error => {
            return {error};
          });
        }
        else {
          newFormOptions.fields.email.hasError = false;
          newFormOptions.fields.email.error = signupFormOptions.fields.email.error;
        }

        if(signup.fieldErrors.password1) {
          newFormOptions.fields.password1.hasError = true;
          newFormOptions.fields.password1.error =   signup.fieldErrors.password1.map(error => {
            return {error};
          });
        }
        else {
          newFormOptions.fields.password1.hasError = false;
          newFormOptions.fields.password1.error = signupFormOptions.fields.password1.error;
        }

        if(signup.fieldErrors.password2) {
          newFormOptions.fields.password2.hasError = true;
          newFormOptions.fields.password2.error =  signup.fieldErrors.password2.map(error => {
            return {error};
          });
        }
        else {
          newFormOptions.fields.password2.hasError = false;
          newFormOptions.fields.password2.error = signupFormOptions.fields.password2.error;
        }
      }
    }
    else {
      newFormOptions.hasError = false;
      newFormOptions.error = signupFormOptions.error;
    }
    this.setState( { formOptions: newFormOptions });
  }

  render() {

    return (
      <form onSubmit={(e)=>{ e.prevenDetault(); }}>
        <t.form.Form ref="signupForm" value={this.state.formValue} onChange={this.onFormChange} type={SignupFormSchema} options={this.state.formOptions} />
        <button onClick={this.handleSignupSubmit} className="button button-primary" type="submit">Signup</button>
      </form>
    );

  }
};

tcomb-form implements shouldComponentUpdate in a way similar to PureRenderMixin, using === comparisons, so options must be treated as immutable data structures (i.e. return a new copy with changed references). My guess is that, since you are mutating formOptions, the form doesn't trigger a re-rendering.
Tip: you might want to use the provided immutability helpers or a library of your choice in order to do less work.

@gcanti
Thank you, good sir! That was it. formOptions with new reference need.


Tracking QB changes

There are lots of QB injuries this week so I was interested in looking back at games where QB changes took place.  Anyone have a better way of doing it than this?  https://gist.github.com/andr3w321/99d64a99b303befca415  As you can see a lot of the players' teams is UNK.  You could probably combine with https://gist.github.com/ochawkeye/aa0aae0ec42c4ba6ca0e somehow to account for that.  The bye weeks are also unaccounted for.

Yes, you will need to do it manually by looking at the team associated with the statistic recorded by a player in any given game. The API unfortunately cannot answer every question. :-)
To be clear: the player data contains current data. If you need historical data, you need to go and look at the actual play-by-play data.


[WIP] Reduce numerical error on numerical gradient calculations

Description
During numerical grad, the output symbol is multiplied by a random matrix. This increases the numerical errors dramatically. With this change, the gradient is still checked at the right location, but without the reduced precission. The benefit by adding a constant instead of multiplying is also that the gradient output in symbolic is always the same and the numerical one changes very little.
Fixes #11720
Overall will reduce flakiness of tests using numerical gradients
Checklist
Essentials
Please feel free to remove inapplicable items for your PR.

[x] The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
[x] Changes are complete (i.e. I finished coding on this PR)
[x] All changes have test coverage:
Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
[x] Code is well-documented:
For user-facing API changes, API doc string has been updated.
For new C++ functions in header files, their functionalities and arguments are documented.
For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
[x] To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

@marcoabreu add [pr-work-in-progress]

@mxnet-label-bot add [pr-work-in-progress]

@larroy
Thanks for diving deep on this issue!
If this solves the problem (adding instead of multiplying random matrix) would be great! Can you address merge conflicts and retrigger the CI?
Also I skimmed through a few CI pipelines. Error seem to be related to this change..

Hi I don't have time to follow on this one.


make Tasks Page Org Centric

Tasks page should only show tasks in current org.
Current org is in route parameters.
Tasks page title should be [OrgName] / Tasks
remove org information from tasks cards.
All new tasks created from this page should be created in org.
All new labels created from this page should be created in org.

blocked on #12918

fix tests that were skipped in 0bc9815 as part of this PR


Removes messaging-nats

We are removing the messaging-nats page and all hyperlinks to said paid
because:

the document does not facilitate operator/app developer understanding
and is more suited for tile developers
the document contents are a copy-paste from the NATS docs
information about NATS is documented elsewhere

#174578977
✨  Can you please propagate this change for 2.7 -> master
Links to all related PRs:

https://github.com/cloudfoundry/docs-cloudfoundry-concepts/pull/145
https://github.com/cloudfoundry/docs-book-cloudfoundry/pull/102
https://github.com/pivotal-cf/docs-book-windows/pull/2
https://github.com/pivotal-cf/docs-ops-manager/pull/92
https://github.com/pivotal-cf/docs-partials/pull/25
https://github.com/pivotal-cf/docs-pas/pull/2
https://github.com/pivotal-cf/docs-pcf-security/pull/115

cc: @jrussett

I also noticed that this change seems identical to the change made here: https://github.com/pivotal-cf/docs-ops-manager/pull/92
Are both of these pages used?

Thanks @ameowlia @jrussett!


Line numbers

It'd be nice if there was some way to get line numbers on functions in light table. I understand that they're less meaningful in light table because of the disorganized nature of the code document and such, but you need line numbers to track down exceptions, so a way to at least jump to a line in file seems necessary.

laconbass, thanks a lot


requestConnectionPriority still useful?

Anything I can find about this is at least 5 years ago: https://www.reddit.com/r/TheSilphRoad/comments/6vt55n/android_improve_goplus_blutooth_responsiveness/
From personal testing I cannot tell any different with this on vs off.

Are we currently using this in the app?

No.

Okay so from what I can tell it totally depends on which device your using. So it definitely made a BIG difference on my LG Velvet and Oneplus 7t (Running LineageOS). No different on my Samsung S23 ultra tho
So I'm just going to conjecture that whether this works or not depends on the phone's vendor and firmware?

Care to elaborate on the "BIG difference"?

Hi,
I have done some input:
Currently I have a Samsung Z fold 4 and I use a megacom dual catchmon from a few years ago.
I found that manually setting the Connection Priority to high using nRF connect dramatically increased the responsiveness of the dual catchmon!
Without it, sometimes stops would fail to spin and pokemon would not be caught even after waiting 10+ seconds.  I found this to be similar on a OnePlus 5T and Pixel 5 as well.
I would love to see a setting that automatically sets Connection Priority to high on connect.
Thanks!

Thanks but I would not consider this conclusive evidence that connection priority is useful. If it only occurs "sometimes", it could as well be caused by connection jittering.


New splitChannelsOptions.overlay Argument Doesn't Work

Wavesurfer.js version(s):
4.4.0
Browser and operating system version(s):
Chrome/FF on Mac
Code needed to reproduce the issue:
Params are as follows:
      const wavesurferArgs = {
        container: document.getElementById('wavesurferContainerInternal'),
        waveColor: '#28275f',
        progressColor: 'rgba(210, 239, 241)',
        cursorColor: '#66c8cf',
        normalize: true,
        pixelRatio: 2,
        splitChannels: true,
        splitChannelsOptions: {
          relativeNormalization: true, (also tried false)
          overlay: true,
          channelColors: {
            0: {
              progressColor: 'green',
              waveColor: 'pink'
            },
            1: {
              progressColor: 'orange',
              waveColor: 'purple'
            }
          }
        },
        src: this.wavesurferUrl,
        plugins,
      };

Use behaviour needed to reproduce the issue:
I just noticed this feature was added 4 days ago. I was excited to try it out but I don't think it actually works.
Here are a couple screenshots illustrating what I'm seeing. Either this is user error of some sort, maybe I'm misunderstanding what "splitChannelsOptions.overlay" is supposed to do, or it is broken.
splitChannelsOptions.overlay = false

This shows 2 people talking. You can see the person captured in the right channel is speaking at the 50-60 second mark.
splitChannelsOptions.overlay = true

In the supposedly combined waveform, the second speaker/right channel is missing. I would expect to see the purple waveform at the 50-60 second mark.

The only place where I can find overlay being refernced in the code. must be a bug.
https://github.com/katspaugh/wavesurfer.js/blob/658bd921be60a64192331ce8511bf1bce68cc4ec/src/drawer.multicanvas.js#L474

The only place where I can find overlay being refernced in the code. must be a bug.
https://github.com/katspaugh/wavesurfer.js/blob/658bd921be60a64192331ce8511bf1bce68cc4ec/src/drawer.multicanvas.js#L474

I too am experiencing this bug. This is the first time I am working with the WaveSurfer library - did older versions have the overlay option? I don't mind making a PR if I can fix the issue.

I too am experiencing this bug. This is the first time I am working with the WaveSurfer library - did older versions have the overlay option? I don't mind making a PR if I can fix the issue.

Digging a little deeper I was able to find where the issue is coming from but not yet have implemented a fix.
See screenshot

wavesurfer.js line: 1227
I outputted the _ref.offsetY value to console when overlay false and overlay true and noticed that the offset value was the same. I changed the offsetY value to 0 to see if it would change it and sure enough it did. I am going to do a little reverse engineering here to trace back when the value is set and sent to the method.

Digging a little deeper I was able to find where the issue is coming from but not yet have implemented a fix.
See screenshot

wavesurfer.js line: 1227
I outputted the _ref.offsetY value to console when overlay false and overlay true and noticed that the offset value was the same. I changed the offsetY value to 0 to see if it would change it and sure enough it did. I am going to do a little reverse engineering here to trace back when the value is set and sent to the method.

I think I solved it by checking for the overlay option and setting the offsetY on the prepareDraw method. Hope the PR get's merged so this overlay can work as expected.

I think I solved it by checking for the overlay option and setting the offsetY on the prepareDraw method. Hope the PR get's merged so this overlay can work as expected.

Merged #2167


Grants improovement

A link to accept or deny grants can be opened from the user many times, and so the Grant can be accepted, declined, accepted, declined etc...multiple times.
We should limit te=he user to access the link only once, if the Grant was already accepted or declined the user should receive a message that the Grant was already handled and redirected to Grants list.

currently the endpoint returning the grant based on interaction id returns only the actions list. ${this.deps.env.AUTH_DOMAIN}/grant/${interactionId}/${nonce}
To understand if the interaction took place or not, we will need the grant state as well.
so if state is PENDING - the page with the choice is displayed
id the state is GRANTED/REJECTED - a modal will be shown that the interaction took place and the user will be redirected to grants list page or to the page of the grant if the response will include the grant id as well.
@mkurapov @sabineschaller does it make sense to add these fields in the response?

Should we go for a separate GraphQL query to fetch a grant using both interaction and nonce?
grantByInteraction(interaction: String!, nonce: String!): Grant!


Set up unit test infrastructure, Travis-CI integration

Now that we are on GitHub and happily, transparently public, we can use Travis for continuous integration and running tests.  For instance, in the issue I just posted #16 , the call is failing for my particular DF but succeeding for a toy example with mtcars.  It would be nice to test both cases once we figure out what's going on there.

I see we already have testthat setup, and tests for some functions!  I'm setting up Travis CI integration.  I don't think codecov is crucial, as long as Travis breaks when any test fails, but it would be a nice-to-have.
Our Travis builds might be slow b/c of all the dependencies this package installs.

Travis integration is live!  And the build is failing from the beginning, an inauspicious start 😂


Problem extracting key

I am basically having the following problem when using the extract_key.shscript, already checked openssl and everything seems right. Basically the bash script isn't creating the required file rsa_key.pem, so the python script gives an error. The error is the following:
extract_key.sh: 3: extract_key.sh: jq: not found
unable to load Private Key
140382660227520:error:0909006C:PEM routines:get_name:no start line:../crypto/pem/pem_lib.c:745:Expecting: ANY PRIVATE KEY
a: rsa_key.pem
b: key.json
Traceback (most recent call last):
  File "extract_key.py", line 8, in <module>
    with open(a, 'rb') as input:
FileNotFoundError: [Errno 2] No such file or directory: 'rsa_key.pem'

I would like to know what is wrong here

Nevermind, noticed it was this command jq that was the problem and a package to be install with apt. Thanks an way.