Rework command output in CLI guides

Based on previous feedback, including the output of every command in the same block as the command itself can be confusing to users. For the CLI installation guide, and the RHOSAK and RHOSR getting started guides, I moved the command output to separate command blocks titled, "Example output".
@smccarthy-ie @bredamc The changes to "Getting started with the rhoas CLI for OpenShift Service Registry" were slightly more involved than the other guides. Please take a look and let me know what you think.

I'm very strongly advicing against including command outputs. This stuff outdates faster than sandwich on drawer :D

Yes. No action in this PR, but more long term action

Thanks @jbyrne-redhat @bredamc @wtrocki for the review and comments. I've removed essentially all of the example command output. As I went over it with a more critical eye, I didn't find any output that was essential to the procedures. I know that it can be helpful to new users to be able to validate that what they're seeing is what they're supposed to see, but it can also backfire if a command changes and the user sees something different than what is documented.
Due to the directory reorg in this repo, I'm closing this PR and opening a new one.


WIP: tests for calling roomSession methods with non existing member

getMemberMeta and promote needs to return 404 when called with non existing memberId. currently it's returning 200.

Promote won't return 404 when the member is missing- the best we can do is 202 (Accepted).

@DonLoquacious What about getMemberMeta ?

@ayeminag Conf Mgr's been updated to return 404 if the member doesn't exist, but the change hasn't been deployed to prod yet.

@DonLoquacious to clarify this, so it'll return 202 if the member doesn't exist for promote and 404 for getMemberMeta?

Yes.

I'm also assuming demote will also return 202 in the case of non existing member.

Demote returns 404 is the member is missing- unlike promote, it's possible to tell if a participant exists to be demoted.

Thanks @DonLoquacious updated my tests.


[Bug]: Inspector shows all closed findings

Steps to Reproduce
Run Prowler with inspector service enabled
Expected behavior
Show only active findings
Actual Result with Screenshots or Logs

How did you install Prowler?
Docker (docker pull toniblyx/prowler)
Environment Resource
Docker container only
OS used
Alpine Linux
Prowler version
Prowler 3.5.2 (it is the latest version, yay!)
Pip version
pip 23.1.2 from /home/prowler/.local/lib/python3.9/site-packages/pip (python 3.9)
Context
No response

Hi @ichasco-heytrade, thanks for letting us know. It will be fixed in the next release.


Dear Mr.atomic14

I encountered some problems. When I learned your project (Build your own Alexa with the ESP32 and TensorFlow Lite), I think your project (Voice Controlled Robot using the ESP32 and TensorFlow Lite) might be simpler, so I imported it into platfromIO Platform and (modified the port COM7) successfully compiled, but in the end it still failed to download to esp32, the port information screenshots are given to you.
                                                                        Thank you for taking the time to reply to me。

Sorry about that - seems like some updates to the underlying libraries now conflict fixed with: 6a19d65


Pull in v0.13.15

This PR pulls in updates from ESBuild v0.13.15.

tests are green, seems like this should work!


RFP - Intel XTU

https://downloadcenter.intel.com/download/24075/Intel-Extreme-Tuning-Utility-Intel-XTU-

Done!
https://chocolatey.org/packages/intel-xtu

Click here to Patreon-ize the package maintainer.


Inside the JS file, code hints, user snippets, etc. don't work

VSCode Version: 1.41.1
OS Version: win10

Inside the JS file, all hints are invalid
And inside the script tag of the .VUE file, it works fine
Including user code snippets, JavaScript (ES6) code snippets/ Path Intellisense Etc. plugins
It seems to be related to these ISSUS  #87635    #87617    #87582
Does this issue occur when all extensions are disabled?: Yes

Is your code stored on a non c drive?
Also please try upgrading your workspace to use typescript@next by installing this extension. Does that fix the issue?


Put big WARNING Sign on the main page: Won't work with Visual Studio!

I was looking for a enum which gives me little more capabilities like the to_string function.
I found wise_enum. The main page (readme.md) looked promising.
I took the effort to check it out in my programm.
First I stumled over the __cpluplus thing, then I had to adjust compiler switches, then I stumbled over the 127 macro arguments thing. And after all the hazzle I looked into the Issues and they were all already there.
Please: It does not work in VisualStudio. You got feedback about it. Please place a big red WARNING note that on the main page.
Please spare other people with VisualStudio the effort to try to use it. Sorry, I'm really a bit pissed...

Could you explain more why this does not work in Visual Studio? Whats the primary problem?

@peter-moran I'm actually not completely sure, at first it seemed like macro limits, so I tried to lower the default number of enumerator cases to help MSVC with that, now it's still not working. The thing is that I don't have a windows dev environment, or MSVC setup, and frankly that's not time I want to put in at the moment. It should be very straightforward for someone who uses MSVC to understand what the problem is.
Nobody has pointed out any issue where my code is not compliant, and I have not used any gcc extensions, so given MSVC is fairly notorious for having a poor preprocessor implementation, I'd suspect the issue is somewhere there. I'm more than happy to help, including detailed explanations, anyone who wants to get this working on MSVC. Let's move that discussion to https://github.com/quicknir/wise_enum/issues/31.

@huberp your comment is pretty obnoxious, think you're missing the part where you think I owe you something. There's literally a CI on the front page for this that shows "failing", if you'd clicked it you would have seen immediately on what compilers this currently passes and fails. Not to mention skimming existing issues. I don't deliberately exclude MSVC from support; I've even made some changes to try to help, there may be a bug in my code or a bug in the MSVC preproprecessor, but either way, that's how software is, it has bugs. Try to keep your comments here constructive in the future, thanks.


Merge in useful design info from diego-dev-notes ?

I recently ran into https://github.com/cloudfoundry/diego-dev-notes which seems to contain quite detailed and useful information.
Wouldn't it make sense to merge part of diego-dev-notes into diego-design-notes ?

Hi, @gberche-orange,
Thanks for the suggestion! I think in general it makes sense to merge the two notes repos, probably renaming 'diego-design-notes' to 'diego-notes' in the process. The 'diego-dev-notes' repo at one point had been private as an internal discussion space for the Diego team, but now that it's public there's no reason to keep them separate. I've made https://www.pivotaltracker.com/story/show/124971441 in the Diego tracker to capture that idea, but it's a fairly low priority to do, so I can't give you a strong estimate on when it will get done. I'll close out this issue now, though, since we have that separate story to track the work.
Thanks again,
Eric

great, thanks a lot @ematpl


chore: auto-restart backend daemon

[!WARNING]
This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

#153
#152  👈
#151
#150
#149
#148
#147
#146
#145
#144
#143
#142
#141
#140
#139
#138
#137
#136
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @NathanFlurry and the rest of your teammates on  Graphite


⚠ Fortnite has degraded performance

In 2363a1e, Fortnite (https://fortnite.com) experienced degraded performance:

HTTP code: 200
Response time: 1719 ms

Resolved: Fortnite performance has improved in 9223225.


[BUG] Game stays on loading screen for awhile despite me being able to drag the window and see it properly while also being able to hear audio

Acknowledgement of preliminary instructions

[X] I have read the preliminary instructions, and I am certain that my problem has not already been addressed.
[ ] My answer given in the checkbox above is a lie.

What problem did you encounter?
It doesnt load, instead it freezes without freezing my game and it has absurd waiting times for me to play especially when playing games where you teleport places alot like type soul

Does this happen only with Bloxstrap? https://github.com/pizzaboxer/bloxstrap/wiki/Switching-between-Roblox-and-Bloxstrap

it only appears in a heavy loading game like type soul, even when entering the game for the first time
from the data i recorded yes because theirs a higher chance to load faster in light games like swfl

Just to be clear, this doesn't happen on any game at all with the original launcher?

Issue has stale for over a month, and will be reopened if further information is given.


[$1000] mWeb Android - Not able to create multiline description

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:

Click on + icon and select assign task option
Enter title and enter description
Click on :leftwards_arrow_with_hook: icon of keyboard which is in bottom right corner

Expected Result:
Should add new line same app
Actual Result:
Not able to add new line
Workaround:
Can the user still use Expensify without this being fixed? Have you informed them of the workaround?
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android / native
[x] Android / Chrome
[ ] iOS / native
[ ] iOS / Safari
[ ] MacOS / Chrome / Safari
[ ] MacOS / Desktop

Version Number: 1.3.34-1
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
https://github.com/Expensify/App/assets/93399543/763a8478-ac32-4ea2-8566-d13b079d0bf3
Expensify/Expensify Issue URL:
Issue reported by:  @gadhiyamanan
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1688318894783959
View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01f6d942e70811c529
Upwork Job ID:<PHONE_NUMBER>824323584
Last Price Increase: 2023-08-11
Automatic offers:

chiragxarora | Contributor | 26157668

Lots of high priorities. Getting to this tomorrow

Still not had time

Seeing this as fixed
https://github.com/Expensify/App/assets/46995600/6f45a638-a56e-4a99-8f0d-6a6782db06e4
Maybe we caught it somewhere else?

@aimane-chnaif did we push a fix for android for this?

I'm also seeing this as fixed on Android Chrome. Am I holding it wrong here?
https://github.com/Expensify/App/assets/46995600/71f1cd8c-d2fc-4a0a-84b9-39a4cb70ad61

@muttmuure still able to reproduce with real device
https://github.com/Expensify/App/assets/54790231/05e35e4c-4c0b-43d5-b131-10b497a29710

@gadhiyamanan can you share some info about your device model and android version.

Catching up from ooo

Sorry, I'm not able to reproduce this. I'm going to close it for WAQ. If it comes up later and someone can reproduce it then we can reopen this one and credit the first reporter.

BrowserStack says the device is real, but I will ask someone on the BZ team if they have an android

Thanks for the proposals folks. @muttmuure I am not sure why this is tagged Internal.
@chiragxarora I checked your proposal, but removing the submitOnEnter won't work as it will cause a regression here. We explicitly added the submit on enter behavior here. Can you post an updated proposal that doesn't break the other issue?
I don't have an Android device to reproduce this right now (I'll post an update in 2-3 hours), but based on my experience I am fairly confident that this  is an issue.

Thanks for the comment @chiragxarora. We can still use multiline with Shift + Enter. Let me confirm the behavior with the team. Raised a comment here

As per the comment on the other issue, we want the conditional behavior. @chiragxarora Can you update your proposal?

Yes let's just disable this for mobile.

I saw the comment  and yeah I am fine with the condition as well. We don't want to use isSmallScreenWidth.

I've tested this on a physical iOS device.  Submit on enter is an issue on mobile Safari like Android.
@chiragxarora's proposal looks good to me.
🎀 👀 🎀  C+ reviewed.

Should’ve mentioned works fine on native app.

@chiragxarora I commented on the PR for missing screenshots.

This was deployed to production 2 days back, but the title wasn't updated.

@muttmuure Can you post the payout summary here? This has been in production for 7 days but the title wasn't updated.

I would call this as small polish/feature request. We linked the other issue, and the comment says it was expected change. I also don't think we need a regression test here.

Waiting on payment summary for NewDot payment.

Reporter - @gadhiyamanan $250
C - @chiragxarora $1500
C+ - @mananjadhav $1500

offer sent!

@muttmuure i didn't get any offer

Sent one to you too @gadhiyamanan

@muttmuure offer accepted, thanks!

All paid up

$1,500 payment approved for @mananjadhav based on BZ summary above.


NIFI-11190: Added provenance events to GetHubSpot and GetShopify

Summary
NIFI-11190
Tracking
Please complete the following tracking steps prior to pull request creation.
Issue Tracking

[ ] Apache NiFi Jira issue created

Pull Request Tracking

[ ] Pull Request title starts with Apache NiFi Jira issue number, such as NIFI-00000
[ ] Pull Request commit message starts with Apache NiFi Jira issue number, as such NIFI-00000

Pull Request Formatting

[ ] Pull Request based on current revision of the main branch
[ ] Pull Request refers to a feature branch with one commit containing changes

Verification
Please indicate the verification steps performed prior to pull request creation.
Build

[ ] Build completed using mvn clean install -P contrib-check

[ ] JDK 11
[ ] JDK 17

Licensing

[ ] New dependencies are compatible with the Apache License 2.0 according to the License Policy
[ ] New dependencies are documented in applicable LICENSE and NOTICE files

Documentation

[ ] Documentation formatting appears as expected in rendered files

@Lehel44 The CI build fails with Checkstyle violation in GetShopifyIT. Please fix it!
I just noticed that GetShopifyIT does not need to be an IT but could be a normal unit test as it uses OkHttp's MockWebServer (as in case of GetHubSpotTest). Could you please convert it to a unit test?

Thanks for the review @turcsanyip !


Allow Component composition

I have a SpriteComponent that will be substituted by an AnimationComponent during the game. I've been thinking to compose this logic into a single PositionComponent that controls whether I render SpriteComponent or AnimationComponent, to improve semantics.
Looking into that, how about Component class have an OrderedSet of subcomponents just like BaseGame? I this way, methods like render and update would be synchronized.
I shall open a pull request in the near future with some ideas in this regard.

Wouldn't an new component class be better? Like a ComposeComponent or ComponentGroup that wraps how many components you need?
This new class would them be responsible by wrapping these inner components and the orchestration of the calls of render and update.

@erickzanardo That coud work. Since my "wrapper" component is a PositionComponent, I think ComposedComponent could be a mixin.
Example of usage:
class MyComponent extends PositionComponent with ComposedComponent {
...

I like the idea of a mixin, I'm feeling more and more inclined about replacing this hierarchy of components with mixins in the future, I've already created several of them  inside one of my games that could potentially be extracted to flame.

Merged #25


adds a static handler for settings.MEDIA

just adds a static resource for MEDIA_ROOT if it is configured so files at /media/ will be served as statics.

had added this to another PR, but it works better on its own.


[TC-SC-5.1] Write ACL by setting AuthMode as Group fails

Problem

TC-SC-5.1 step 1
Write ACL by setting AuthMode as Group returns error code 0x01 (FAILURE)
Subsequent steps will fail with 0x7e (UNSUPPORTED ACCESS)

Hi pankore, this generally works so there may be something wrong with the test setup or environment.

Hi @mlepage-google , may I know what SHA are you using? I am using the TE9 tag and I also see the same FAILURE code written in RED in the test case document of TC-SC-5.1 step 1a.

I am on latest master, but this has been working for quite a while.
Are you trying to write a list containing a single ACL entry that has group auth mode? That won't work.
When you write the ACL attribute, you are writing a list.  If you are writing one entry that is group auth mode, you are replacing the existing ACL list (which contains the "admin" ACL that is giving you access) with your new list. As soon as the pre-existing "admin" ACL is gone, you will lose all access.
If you are trying to make a group auth mode ACL entry, it will need to be an additional ACL entry; you need to write a list containing an "admin" ACL and any other ACL entry you wish.

@pankore What is the exact command being executed?  The TE9 discussions I saw had people executing all sorts of incorrect ACL write commands, because some of the test plans were wrong.

@pankore Can you re-test on latest ToT and update the results.

Please provide the specific chip-tool commands used.

The command I used was copied from the V1 verification steps document. This command returns FAILURE.
 ./chip-tool accesscontrol write acl '[{"fabricIndex": 1, "privilege": 5, "authMode":3 , "subjects": [112233], "targets": [{"cluster": null, "endpoint": 0, "deviceType": null}]}]' 1 0
On the V1.2 verification steps document, there is an uipdate to the command. This command returns UNSUPPORTED_ACCESS.
 ./chip-tool accesscontrol write acl '[{"fabricIndex": 1, "privilege": 5, "authMode":2 , "subjects": [112233], "targets": [{"cluster": null, "endpoint": 0, "deviceType": null}]}, {"fabricIndex": 1, "privilege": 4, "authMode":3 , "subjects": [112233], "targets": null}]' 1 0

assigning to @mrjerryjohns , @bzbarsky-apple , @mlepage-google for feedback on the command used.

./chip-tool accesscontrol write acl '[{"fabricIndex": 1, "privilege": 5, "authMode":3 , "subjects": [112233], "targets": [{"cluster": null, "endpoint": 0, "deviceType": null}]}]' 1 0

OK, so this uses AuthMode == Group, with a subject value of 112233.
Per spec, if the auth mode is group then the subjects must be group ids.  In particular, they must be 64 bit values with the group id in the lowest 16 bits and the high 48 bits set to 0.  112233 == 0x1b669 and does not have the 48 high bits set to 0, so this is not a valid subject value for the Group authmode, and the command should fail.  And yes, this matches the bogus things I saw happening during TE9...

./chip-tool accesscontrol write acl '[{"fabricIndex": 1, "privilege": 5, "authMode":2 , "subjects": [112233], "targets": [{"cluster": null, "endpoint": 0, "deviceType": null}]}, {"fabricIndex": 1, "privilege": 4, "authMode":3 , "subjects": [112233], "targets": null}]' 1 0

This has the same exact problem: group AuthMode, subject that is not a valid group id.

Oh, and after that first (failed) command the ACLs have been wiped out, which is why you get UNSUPPORTED_ACCESS after that.
@cjandhyala Can we please get the verification steps fixed?


'less than 21' is the correct expression.

The example for where the difference happens is between 20 and 21 characters. But the explantion states that is less than 20. That is between 19 and 20 characters. "less than 21" or "less or equal to 20", "at most 20" is better phrasing. This diff simply changes the value to 21.

Oh, right, thanks for pointing this out @secworks
Merging it right away!


Forgot to mention the Issue I made for that. #593


AxTokenIssuer

Hello,
In my wif.config file there is no authority 'AxTokenIssuer'. Where should I add the tumbprint of the certificate?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 71bd6e91-0511-905a-0e70-b0510d961f16
Version Independent ID: 4942a200-93f3-6f2b-8a59-b88fdf6e825c
Content: Performance SDK and multiuser testing via Visual Studio Online - Finance & Operations | Dynamics 365 | #MSDyn365FO
Content Source: articles/dev-itpro/perf-test/perfsdk-tutorial.md
Service: dynamics-ax-platform
GitHub Login: @jujoh
Microsoft Alias: jujoh

the correct place in wif.config is under authority https://fakeacs.accesscontrol.windows.net

It looks like @hasaid answered the question, so closing this issue.  Thanks @hasaid!


UI makes call to v3/authconfigs/azuread when doing an Edit config on an EKS cluster

On 2.6-head commit id: 240554b

Deploy an imported EKS cluster (Issue was not seen during edit of a K3s node driver cluster)
Add a std user to the cluster, as Cluster Owner
Login as the std user
Edit cluster as a standard user
Request made in network calls

Request URL: https://rancher-server/v3/authconfigs/azuread
Request Method: GET
Status Code: 403

In the console, error seen:

/c/c-bdlhj/edit?provider=amazoneksv2:1 Uncaught (in promise) e {baseType: 'error', code: 'Forbidden', message: 'authconfigs.management.cattle.io "azuread" is forb…group "management.cattle.io" at the cluster scope', status: 403, type: 'error', …}
 This is an issue as a standard user

@sowmyav27 What user authentication is configured? I could not reproduce this with local auth config.

It was using local Auth config. And this happens when you login as a Standard user. Specifically these steps

- Add a std user to the cluster, as Cluster Owner
- Login as the std user
- Edit cluster as a standard user

Based on what's left in the 2.6.x lifecycle, this doesn't look critical to fix. Let us know if this is happening in 2.7.x at all.

Reproduction Attempt Environment

Component
Version / Type

Rancher version
2.7.2

Installation option
Helm (high availability)

RKE binary version used
1.4.0

If Helm Chart k8s cluster
v1.24.6

Cert Details
Let's Encrypt / nginx

Docker version
20.10.7, build f0df350

Helm version
v2.16.8-rancher2

Downstream cluster type
Imported EKS

Downstream K8s version
v1.24.12-eks-ec5523e

Authentication providers enabled
local

Logged in user role
standard user

Browser type
Microsoft Edge

Browser version
112.0.1722.39

Reproduction steps

Set up Rancher version 2.7.2, following the guidelines provided in the table above.
Create an AWS EKS Cluster using the Amazon Web Services console, separate from Rancher.
Import the EKS cluster you just created into Rancher.
Create a standard user account named user1.
Grant user1 the Cluster Owner role for the imported EKS cluster.
Log out of Rancher as the administrator.
Open Microsoft Edge DevTools and navigate to the Network tab. Sign in to Rancher using the user1 account with DevTools still open.
Edit the configuration for the imported EKS cluster within Rancher.
Confirm that no API calls are made from the Rancher UI to v3/authconfigs/azuread by checking the network activity in Edge DevTools.

RESULTS
✅ Expected
No API calls from the UI to v3/authconfigs/azuread are expected when editing the configuration of an imported EKS cluster.
✅ Actual
No API calls from the UI to v3/authconfigs/azuread were observed when editing the configuration of an imported EKS cluster.

Based on what's left in the 2.6.x lifecycle, this doesn't look critical to fix. Let us know if this is happening in 2.7.x at all.

@gaktive After testing on version 2.7.2, I can confirm that this issue does not appear to be present.


Docs: readme improvements

What is the expected enhancement?

Improve readme template for better readability.
Incorporate tests results in descriptions.
Split into template hierarchy. See template inheritance

Related stories:

as community member of ecosystem I want my project to be displayed in ecosystem github README and qiskit.org
as core team member/curator I want README for repository to be generated automatically after each change of members

Epic #9

Other points :

Add tox.ini template

Add repo structure example

Add setup.py template

closed in #54


manifest: TF-M v2.0.0 update

Update TF-M to version 2.0.0 including
MbedTLS to v3.5.0
TF-M-Tests to v2.0.0
PSA-Arch_Tests to v23.06_API1.5_ADAC_EAC

Could someone please update the documentation? It looks like this was missed as part of this PR.
For example https://docs.zephyrproject.org/latest/services/tfm/overview.html
" Zephyr RTOS has been PSA Certified since Zephyr 2.0.0 with TF-M 1.0, and is currently integrated with TF-M 1.8.0."
@mswarowsky @d3zd3z

Could someone please update the documentation? It looks like this was missed as part of this PR. For example https://docs.zephyrproject.org/latest/services/tfm/overview.html " Zephyr RTOS has been PSA Certified since Zephyr 2.0.0 with TF-M 1.0, and is currently integrated with TF-M 1.8.0."
@mswarowsky @d3zd3z

Created #67900 I'm not able to add reviewers so pleas @kartben and @d3zd3z feel free to check.


Broken Commit

Hi there,
Commit: 2a02ac3cf6cb7e392aab61d0efbc6416a9e4aefe seems to break functionality.
from api import Fleet, Planet, State on line 10 in _state.py should be from api import Fleet, Planet.

Next issue is with the supplied play.py. For loading the bot, it uses this line of code:
path = './{}/{}.py'.format(name, classname)
But the bots are located in a subfolder bots and are named name + Bot.py, so it should be:
path = './bots/{}/{}Bot.py'.format(name, classname)
But the problems don't end there. The play script assumes the bots are placed in classes with the name of the bot as classname. But the example bots do not have this.
Adding the classname fixes this error but then the next one pops up:
    planets.append(Planet(0.0, 0.0, 10, 100))
TypeError: __init__() takes 4 positional arguments but 5 were given```

Hi Jasper,
Thanks for the early bughunting. Unfortunately, the code currently comitted is quite a way behind the local version. I don't want to commit the things that the students have to fill in themselves (ie. working minimax agents and such). Expect a working codebase tomorrow or the day after.

Hi Peter,
I already thought so, I'll just wait for the working codebase then! Thanks,


Attribute $id require URL with protocol part

Ajv version
6.5.2
Problem
A JSON schema has attribute $id. ajv just works when $id is specifies by URL format such as protocol://domain/path . If protocol part is removed then ajv does not works, it always provide can't resolve reference....
Question
Why don't remove protocol part from $id attribute?. protocol part is unnecessary.

@kevin-leptons could you please post a specific code sample that doesn't work as you expect (ideally please post it to runkit.com)?

Hello,
Sorry for delay. I have two examples

ajv-specifed-protocol
ajv-not-specified-protocol

First example specifics protocol part in URI of $id of schema. Ajv works as well.
Second example does not specifics protocol part of $id of schema. Ajv will throw Error.


Not all messages are recovered

I just used the module for the first time and when I open the file, only 24 messages are displayed on a total of 1184.
This problem appears only with version 2.5.6 of the module.
Older versions like 2.5.5 work fine.
discord.js: v13.7.0

Can you provide any options you are passing to the function?

Unable to reproduce, exported ~3k messages fine with returnType: 'buffer' as the only option.

exported ~19k messages and still works fine

  const channel = discord.channels.cache.get('963640501028929556');

  const attachment = await discordTranscripts.createTranscript(channel, {
    limit: -1,
    returnType: 'attachment',
    fileName: 'transcript.html',
    minify: false,
    saveImages: false,
    useCDN: true
  });

channel.send({
      files: [attachment]
    });

I tried with your options, I only get file.jpg which is a simple white image

I tried with your options, I only get file.jpg which is a simple white image

That's because I set returnType to buffer.
I set it to that so I could save it as a file directly instead of sending to discord.
this shouldn't affect the transcript though

and I think I just found the issue, pushing a fix soon

Ok, thank you very much

released as version 2.5.7


[Debugger] Incorrect thread state shown when stopping event occurent immediately after thread event.

Issue Type: Bug
This is reproducible using the C# extension to debug a .NET Core application. The core issue appears to be with VS Code.
To reproduce:

Get .NET Core from here
Create a new C# console app by running dotnet new console in an empty directory.
Copy the following code into Program.cs:

using System;
using System.Linq;
using System.Diagnostics;
using System.Collections.Generic;
using System.Text;
using System.Threading;
using System.Threading.Tasks;

namespace hwapp
{
    class Program
    {
        const int cThreads = 5;

        static List<Thread> CreateThreads()
        {
            List<Thread> threads=new List<Thread>();
            for(int i=0;i<cThreads;i++)
            {
                threads.Add(new Thread(()=>ThreadCode(0)));
                threads[i].Start();
            }
            return threads;
        }
        static void ThreadCode(object o)
        {
            while(true)
            {
                Thread.Sleep(1000);
            }
        }
        static void Main(string[] args)
        {
            int a=0;
            List<Thread> threads=CreateThreads();
            //Thread.Sleep(100);
            a++; //set bp
            Console.WriteLine("Hello World!");
        }
    }
}

Open the folder in VS Code.
Install the C# Extension
Say yes when prompted Required assets to build and debug are missing from 'scratch'. Add them?
Set a breakpoint at line 37
F5.
Look at the callstacks viewlet.

Expect: All threads show 'Paused'
Actual: Many threads show 'Running'
The C# Extension Debug Adapter always sets the allThreadsStopped property on stopped events, so no threads should ever be shown as running when the debugger is stopped. Our protocol log shows this:
<- (E) {"seq":28,"type":"event","event":"thread","body":{"reason":"started","threadId":26220}}
<- (E) {"seq":29,"type":"event","event":"thread","body":{"reason":"started","threadId":10464}}
<- (E) {"seq":30,"type":"event","event":"thread","body":{"reason":"started","threadId":22324}}
<- (E) {"seq":31,"type":"event","event":"thread","body":{"reason":"started","threadId":9636}}
<- (E) {"seq":32,"type":"event","event":"thread","body":{"reason":"started","threadId":21256}}
<- (E) {"seq":33,"type":"event","event":"stopped","body":{"reason":"breakpoint","threadId":19620,"allThreadsStopped":true,"source":{"name":"Program.cs","path":"C:\\Users\\chuckr\\source\\dotnet\\scratch\\Program.cs"},"line":37,"column":13}}
-> (C) {"command":"threads","type":"request","seq":8}
<- (R) {"seq":34,"type":"response","request_seq":8,"success":true,"command":"threads","message":"","body":{"threads":[{"id":19620,"name":"Main Thread"},{"id":26220,"name":"<No Name>"},{"id":10464,"name":"<No Name>"},{"id":22324,"name":"<No Name>"},{"id":9636,"name":"<No Name>"},{"id":21256,"name":"<No Name>"}]}}
-> (C) {"command":"stackTrace","arguments":{"threadId":19620,"startFrame":0,"levels":20},"type":"request","seq":9}
-> (C) {"command":"threads","type":"request","seq":10}
<- (R) {"seq":35,"type":"response","request_seq":9,"success":true,"command":"stackTrace","message":"","body":{"stackFrames":[{"id":1000,"name":"scratch.dll!hwapp.Program.Main(string[] args) Line 37","source":{"name":"Program.cs","path":"C:\\Users\\chuckr\\source\\dotnet\\scratch\\Program.cs","sourceReference":0,"sources":[],"checksums":[{"algorithm":"SHA1","checksum":"e48301a96275772e1b94d9cfac2328053426722d"}]},"line":37,"column":13,"endLine":37,"endColumn":17,"moduleId":"{18A8B70E-3294-40CB-B4B8-BB7B27E2A7E5}"},{"id":1001,"name":"[External Code]","line":0,"column":0}],"totalFrames":2}}
<- (R) {"seq":36,"type":"response","request_seq":10,"success":true,"command":"threads","message":"","body":{"threads":[{"id":19620,"name":"Main Thread"},{"id":26220,"name":"<No Name>"},{"id":10464,"name":"<No Name>"},{"id":22324,"name":"<No Name>"},{"id":9636,"name":"<No Name>"},{"id":21256,"name":"<No Name>"}]}}

You can see that the stopped event comes in immediately after the thread events, before the threads command can be run. I'm guessing this is somehow breaking the paused/running behavior.
If you uncomment the sleep on line 36 to allow time between creating threads and stopping, this issue no longer reproduces.
VS Code version: Code - Insiders 1.23.0-insider (b845ce918f2689344795e845ae6ef691916c3079, 2018-04-24T05:17:07.677Z)
OS version: Windows_NT x64 10.0.16299

System Info

Item
Value

CPUs
Intel(R) Core(TM) i7-6700 CPU @ 3.40GHz (8 x 3408)

GPU Status
2d_canvas: enabledflash_3d: enabledflash_stage3d: enabledflash_stage3d_baseline: enabledgpu_compositing: enabledmultiple_raster_threads: enabled_onnative_gpu_memory_buffers: disabled_softwarerasterization: disabled_softwarevideo_decode: enabledvideo_encode: enabledvpx_decode: enabledwebgl: enabledwebgl2: enabled

Memory (System)
31.92GB (17.16GB free)

Process Argv
C:\Program Files\Microsoft VS Code Insiders\Code - Insiders.exe

Screen Reader
no

VM
0%

Extensions (1)

Extension
Author (truncated)
Version

csharp
ms-
1.15.0-beta5

@weinand @isidorn

@chuckries Sorry for the slow response this somehow fall though my fingers.
I can not reproduce this with latest vscode insiders. Do you see this with latest vscode insiders, if yes do you do something different than your 8 steps provided above

@isidorn Sorry for the late response on my end. Yes I am still able to repro this, please reactivate the issue:

You made need to increase cThreads from 5 to 20 or so.
VS Code Version:

Version: 1.25.0-insider
Commit: 26eb2a9af5827d71e1f65096c0ce712c5ad2740d
Date: 2018-07-02T12:37:21.268Z
Electron: 1.7.12
Chrome: 58.0.3029.110
Node.js: 7.9.0
V8: 5.8.283.38
Architecture: x64

C# Extension Version:
1.15.2


Start on boot ?

Hello, really nice piece of software. I was wondering if we can init sol on boot ?

Will do soon, trying to fix other stuff at the moment!

Try the latest version 1.0.6 should be working now


[api-docs] Document new threads field, invitable

A new commit was made into the api-docs repo. This issue was created automatically. Need to review if we made any change to the library for this commit.
https://github.com/discord/discord-api-docs/commit/7ab5731e97262bcfdeb9278f8add0d555b98478d

Done


v3.0.0 .NET Framework Version

Hello,
When trying to install the new 3.0.3 Nuget package (https://www.nuget.org/packages/dotnet-certes/) for a C# .NET Framework console application I am receiving the following error:  Package 'dotnet-certes 3.0.3' has a package type 'DotnetTool' that is not supported by project 'CertesNugetDownload'.
It appears the Nuget package may only be for .NET Core projects/applications.  Can you also provide a package/download option for .NET Framework applications?
Thank you.

Following this topic for an update too.


Feature: Publish to NPM

This is a great aurelia extension with amazing documentation. Any chance that it can get published directly to npm so that we can more easily pin to specific versions and be aware of updates (e.g. npm outdated)?

Hey, thank you for the compliments.
I did look into publishing to NPM, but there is already a plugin called aurelia-table. So I'm not sure how to proceed :(
I can use a different name I guess, but I wonder if that would confuse people. What do you suggest?

I have created a NPM package for the plugin. Unfortunately the aurelia-table name was already taken, so I had to settle with au-table instead.
I have updated the documentation to indicate this.

Thanks; sounds like a great solution. (And a nice surprise when I got back from vacation.)


Was the pre-training model corrupted？

I am also facing the same issue, I download the pre-trained model and try to untar it:
tar -xf resnet50_yfcc_coco17.pth.tar
tar: This does not look like a tar archive
tar: Skipping to next header
tar: Exiting with failure status due to previous errors

The code directly load .pth.tar, do not untar it.


Grid not on AC in pages

Hi,
I've a mqtt pvinverter and grid meter fully controlled by mqtt but in the pagesonly the pvmeter shows. The ACinput stays empty.
What can be the cause? How does it work?

Do you see the Meter on the Device Site (First Page Remote Console Menu)?


Swift3 UI Bug

We have been updated our source code from Swfft2.x to Swift3.
I found one issue about uibug of CRToast.
Check this screenshot.

Swift2
Swift3

We’ve solved this issue.
Use setting option like this:
(before) [kCRToastNotificationTypeKey : CRToastType.navigationBar.rawValue, …]
(current) [kCRToastNotificationTypeKey : NSNumber(value: CRToastType.navigationBar.rawValue), …]

Had the same issue after migrating to Swift 3. As well as issues with setting the correct values for:

kCRToastAnimationInTypeKey
kCRToastAnimationOutTypeKey
kCRToastAnimationInDirectionKey
kCRToastAnimationOutDirectionKey

Converting these values to NSNumber(value: <value>.rawValue) worked as well.


[Bug]: Wiped my game save

All of the following criteria must be met

[ ] Full Latest.log file included. If no file exists then leave this unchecked and state so.

All of the following are optional to answer

[X] Tried reinstalling the game.
[ ] Tried reinstalling LemonLoader.
[ ] Tried restarting device.

Describe the issue.
I was trying to install LemonLoader but halfway through it said that it didnt work. So I reinstalled bonelab from the quest store [this had happened before with beat saber and bmbf, but i had gotten the save back for beat saber] but my save file and my mods were gone. How can I get them back? WITHOUT using a dev save (i'll feel like i cheated.)
Did you attach your log file?

[ ] Yes, I attached my log file to the text box above.
[X] No, I could not find a log file at /storage/emulated/0/Android/data/<package name>/files/melonloader/etc/Latest.log

you cant bro, if u paid any attention, trev said that if u delete bonelab without backing up ur stuff, everything will be gone. just get a dev save, that's ur only hope.

ok thanks


Not found file.

Hi:
When I run:
cd faster-rcnn.pytorch
bash init.sh

it's echo
+ echo 'Please move faster_rcnn_200_14_18895.pth to models/res101/gta_det/'
Please move faster_rcnn_200_14_18895.pth to models/res101/gta_det/
+ echo 'Please move faster_rcnn_300_100_175.pth to models/res101/kitti/'
Please move faster_rcnn_300_100_175.pth to models/res101/kitti/

but i don't have these files. where i can find theme?
thank youy !

Hi @Biyu-GitHub,
Thanks for the question!
The checkpoint files can be downloaded using
cd 3d-tracking/
python loader/download.py checkpoint

However, it might not be able to download now since the server is currently down for regular maintenance. I'd encourage you to try it a few days later.
If you have further question, please feel free to open a new issue.

As a side note for people looking for the data (image, label, detection results, checkpoint), we do recommend you follow the data preparation guide to download all the data you need.

Thank you very much !


fix(import-datasources): Use "admin" user as default for importing datasources

SUMMARY
This is a potential fix for #17049 which prevents the use of CLI: superset import-datasources which appears to have been broken for for some time. Attempting to run import-datasources will result in a NameError: user.
Looking at the history of import-datasources there used to be a --user which could be applied, but was removed. I saw though that other CLI functions use the following g.user = security_manager.find_user(username="admin") to default to the admin user before the security_manager runs.
Please note, I'm new to Superset, so please help me check on whether using this is acceptable or an insecure workaround.
TESTING INSTRUCTIONS

from CLI run: superset import-datasources -p mydatasources.zip

ADDITIONAL INFORMATION

[x] Has associated issue: Fixes #17049
[ ] Required feature flags:
[ ] Changes UI
[ ] Includes DB Migration (follow approval process in SIP-59)

[ ] Migration is atomic, supports rollback & is backwards-compatible
[ ] Confirm DB migration upgrade and downgrade tested
[ ] Runtime estimates and downtime expectations provided

[ ] Introduces new feature or API
[ ] Removes existing feature or API

Mypy check was failing due to unrelated mypy errors from the master which have since been fixed. I merged in main again and mypy checks are passing now in my local pre-commit.

@ddxv you mentioned,

Looking at the history of import-datasources there used to be a --user ...

Would you mind sharing where you found this logic?

@ddxv you mentioned,

Looking at the history of import-datasources there used to be a --user ...

Would you mind sharing where you found this logic?

If that doesn't sound correct to you, I must have mixed up import_dashboards which has --username
@click.option(
    "--username",
    "-u",
    default=None,
    help="Specify the user name to assign dashboards to",
)

I wonder if import-datasources should also have a user akin to import-dashboards as both entities are owned. Maybe @betodealmeida or @villebro would have thoughts on this.

I see some of MySQL tests are failing due to this PR being at the latest changes (ie they are due to other unrelated issues) or if it is directly caused by using the security_manager.
If it is that I'm incorrectly using the master here, please let me know which branch or tag is better. If it's the security_manager I'll look into that.


Remove deprecated prepper plugin type

Description
This change removes the support for the deprecated Prepper plugin type and the support of the prepper name in configuration yaml; updates samples and documentations accordingly.
Issues Resolved
Contributes to #619
Check List

[ ] New functionality includes testing.
[ ] New functionality has been documented.

[ ] New functionality has javadoc added

[x] Commits are signed with a real name per the DCO

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Codecov Report

Merging #1707 (19104b6) into main (81d9760) will decrease coverage by 0.14%.
The diff coverage is 90.90%.

:exclamation: Current head 19104b6 differs from pull request most recent head c261840. Consider uploading reports for the commit c261840 to get more accurate results

@@             Coverage Diff              @@
##               main    #1707      +/-   ##
============================================
- Coverage     93.32%   93.17%   -0.15%
+ Complexity     1351     1343       -8
============================================
  Files           178      177       -1
  Lines          3969     3956      -13
  Branches        317      315       -2
============================================
- Hits           3704     3686      -18
- Misses          189      194       +5
  Partials         76       76

Impacted Files
Coverage Δ

...dataprepper/model/processor/AbstractProcessor.java
100.00% <ø> (ø)

.../opensearch/dataprepper/parser/PipelineParser.java
83.48% <0.00%> (ø)

...dataprepper/model/configuration/PipelineModel.java
100.00% <100.00%> (ø)

.../org/opensearch/dataprepper/pipeline/Pipeline.java
88.57% <0.00%> (-4.29%)
:arrow_down:

...rwarder/discovery/AwsCloudMapPeerListProvider.java
92.68% <0.00%> (-2.44%)
:arrow_down:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@dlv @cmanning09 I have added the changes to rename PrepperState to this PR as well (in bff9ded).
For the other changes we discussed, i.e. renaming class names in data-prepper-plugins like GrokPrepper, ServiceMapStatefulPrepper, also including MapDbPrepperState, etc., I'd like to add in a separate PR to keep this one from growing too large.

Something about this rebase doesn't seem right. The diff shows that changes that should have already been merged into main.

@dlvenable @cmanning09 This is ready for another look. The previous approvals were dismissed due to new changes to address merge conflicts. Sorry that those new changes are not obvious and buried in the commit history, but they are all pretty trial changes.


Chore: Replace AppSignal with Spandex/Datadog in OMG.Utils.Metrics

:clipboard: https://github.com/omisego/elixir-omg/issues/765 https://github.com/omisego/elixir-omg/issues/767
Overview
This PR replaces AppSignal with Spandex/Datadog in OMG.Utils.Metrics. We may want to scrap decorators in favor of telemetry, but using our exisiting decorators seemed like an easier first step to get things going (and was suggested by @pdobacz in https://github.com/omisego/elixir-omg/pull/707).
Opening this PR a bit early for feedback while I test. I'm sure things will be adjusted as we get it working. I wasn't really sure where to put the deps and config since we have so many different apps. These pieces might need to move around a bit as we test and I figure out what is going on here. We may make separate tracers for each application or remove the custom tracer completely (as described in the spandex docs)
After we merge https://github.com/omisego/elixir-omg/pull/775 and this PR, we can remove the AppSignal dependency (https://github.com/omisego/elixir-omg/issues/767).
Changes

Add spandex, spandex_datadog, decorator as dependencies
Add OMG.Utils.Tracer
Replace AppSignal decorators with Tracer.start_{trace|span}

Testing
I'm relying on existing tests and dialyzer right now - may write separate tests for OMG.Utils.Metrics as I test in development and try to put stuff in Datadog.

Coverage decreased (-0.3%) to 78.905% when pulling a3e67b6d9e3a0e5f8be4bc11c558b0e90d46aa58 on chrishunt/spandex into e4c8b8c11fd6529bf5405a87592ce86609ff275e on master.

Is this ready for review and consequently merge?

@InoMurko  Is this ready for review and consequently merge?

It is now! Thanks for taking a look. Just cleaned up some conflicts and squashed.


Does it support Acknowledgement as in main Socket.io emitter?

I am trying to pass acknowledgement function while emitting to client but it's not working but in socket.io node process it is working file. here is my code below:
io
.to(socketId)
.emit("event", data,function (err,message) {
     console.info(message);
     console.error(err);
});

the callback function is not called and in java client i am gutting ack function null.

Duplicate of https://github.com/socketio/socket.io-emitter/issues/50.


Update oneDAL PCA infer method

Description
The changes are proposed to move some computations from python wrappers to oneDAL to improve performance of python libraries.
Changes proposed in this pull request:

Oneapi model class for PCA has been extended to allow passing means, eigenvalues, and variances from python
Support for whiten has been added in oneDAL if eigenvalues are passed
Data for inference will be mean centered if mean is passed
Three primitives have been added: Elementwise subtraction of 1d array from 2d array (required for mean centering), elementwise division of 2d array by 1d array (required for whitening), SQRT of an 1d array (required for whitening). The primitives are placed under stat temporarily.

How does this PR compare to #2573 ?

How does this PR compare to #2573 ?

2573 is an updated version of this. Closing this one as duplicate.

Changes have been moved to https://github.com/oneapi-src/oneDAL/pull/2573, closed as duplicate


Handle synthetic nodes correctly as namespace identifiers in system transform

Fixes #19618

cc @mhegazy The failure is because the PR is looking for a node 4 build for dotnetci, when there's a node 8 build instead now.


Subset and download l3 and l4 subsetted datasets

I have been investigating how to subset and download l3 and l4 datasets, since I am new to this I have been facing some confusions.
I am discussing over this[0] thread in the podaac forum.
This should be hopefully solved soon.

[0] https://podaac.jpl.nasa.gov/forum/viewtopic.php?f=5&t=219

@Omkar20895 please paste the XML here and format it. It is a large XML file and I don't knwow hich snippet you are referring to. Thanks

If the data contains XML metadata child elements which are  then you would be wise to assume that the data is gridded ;)

Is this addressed @Omkar20895 ? Did you have a PR for the subsetting within l4 granule function?

No not yet, I have been caught up in the long weekend we had here, I will get onto this now, sorry for the delay, thanks. :)

Closing this as it is not relevant for 1.1.0 now given the new L2SS API


Exception: videoQuality cannot be empty

When playing videos in the app, some videos work as expected, while others cause the app to crash with the following error:
E/flutter ( 3806): [ERROR:flutter/runtime/dart_vm_initializer.cc(41)] Unhandled Exception: Exception: videoQuality cannot be empty

When playing videos in the app, some videos work as expected, while others cause the app to crash with the following error: E/flutter ( 3806): [ERROR:flutter/runtime/dart_vm_initializer.cc(41)] Unhandled Exception: Exception: videoQuality cannot be empty

last_pod_player: ^0.0.5  use it


add config for asset path.

in my project, the directory is
repository
repository
    client
        assets

https://github.com/3pjgames/unity-git-hooks/commit/8944e01c8eeae27c4e52ee6734caa6a6d48dfd67


how can I surpport ARM environment

I found some binary at
https://github.com/joostoudeman/webp-imageio/tree/feature/support-sharp-yuv/src/main/resources/native/Mac/aarch64
hope helps you too


support other robotic arm (not only panda_arm)

Hi,
First, thank you for your great work! it gives me much help and reference when i study moveit2 and Ignition Gazebo.
but i find some code in  moveit2_py/moveit2.py is  special for panda_arm robot , do you have a plan to make ign_moveit more general so that others can directly use the package to move different robotic arm?
In addition, i find you use scipy package to transform euler to quaternion in example scripts, i don't think it's good way to import extra unnecessary package . and i also find a  simple transform code which is from ROS2 Tutorials: Using-URDF-with-Robot-State-Publisher , of course, it's just my opinion.

Hello @gezp, thank you for posting this issue.

some code in moveit2_py/moveit2.py is special for panda_arm robot

That is correct, the Python interface for MoveIt2 (moveit2_py) contained in this repo was originally meant as a quick and dirty alternative to moveit_commander, which has not yet been migrated to MoveIt2 (it is not in migration progress either, so I am not sure if it is planned at all). It actually does not even contain any Ignition-specific code, this was just a convenient place for me to put it because I require to have Python interface in the control loop for my project (hence it is also hardcoded for my needs). It currently does not even support all features of MoveIt, e.g. I have not added planning of Cartesian paths yet. Having proper Python bindings to move_group interface might therefore be much better, but I would use a different repo for such purpose as it has nothing to do with Ignition :)

do you have a plan to make ign_moveit more general so that others can directly use the package to move different robotic arm?

All other parts of using MoveIt2 inside Ignition should already be supported for all robots with URDF if you can get away with using C++ move_group interface. The only extra step you need to do is to publish the joint trajectory to the corresponding topic and bridge it to Ignition such that JointTrajectoryController can receive the messages. There is a small C++ example in this repo for this as well (ROS2 node and launch script).
If there is interest from you to use MoveIt2 with Python interface, then I can spend some time next week to refactor the moveit2_py and make it general (read the robot description from URDF, i.e. fix init_robot() to act as moveit_commander would). I am not that experienced with Python, but maybe I can look at the aforementioned 'proper Python bindings' to move_group and see how much effort it would require... I am also planning to do some changes in this repo soon anyway because upstream dependencies had some of the required features merged in, which should simplify quite a few things.
Do you have a specific robot in mind that you would like to use? If so, please link me its URDF description so that I can test it with something specific (if possible).

i find you use scipy package to transform euler to quaternion in example scripts, i don't think it's good way to import extra unnecessary package

I totally agree with you, this repo should totally be renamed to quick-n-dirty :) As scipy is only used in examples to get top-down aligned orientation, I will replace it everywhere with the resulting [1.0, 0.0, 0.0, 0.0] quaternion and remove the unnecessary import.

Thanks for your reply!  now I copy and modify a part of  moveit2_py/moveit2.py  for my project .I only need part functions and I can flexibly modify the code for my own needs, so i don't think my project need to depend on this package. But anyway, this repo is a good tutorial about how to use moveit2,  thanks for your work!

Thanks for your reply!  now I copy and modify a part of  moveit2_py/moveit2.py  for my project .I only need part functions and I can flexibly modify the code for my own needs, so i don't think my project need to depend on this package. But anyway, this repo is a good tutorial about how to use moveit2,  thanks for your work!


As a pack CLI user, I must select a builder with: pack set-default-builder

Acceptance Criteria
When I install the pack CLI on a workstation that has not had v0.1.0 installed at any point
And pack set-default-builder has not been run with pack v0.1.0
And I run pack build or pack run
Then I see:
Please select a default builder with:

pack set-default-builder [builder image]

Suggested builders:
  Cloud Foundry:  cloudfoundry/cnb
  Heroku:         heroku/buildpacks

Sample builders:
  Samples:        packs/samples

Notes:

suggestions are ordered randomly (except for Samples, which stays at the bottom)
After set-default-builder, do not show this message
May have to record the pack CLI version in the config file

TODO: add more detail for each image (e.g., bionic vs. cflinuxfs3, buildpacks included), also recommend pack inspect-builder

This feature is essentially done in master of pack. However, I temporarily commented out the actual references to the suggested builders b/c neither currently work with master of pack
We should probably hold on acceptance until the builders work...

Per speaking with @djoyahoy, holding off testing this until the CF heroku suggestions are truly randomized.

After discussion with @sclevine @nebhale @jkutner @hone It seems that we would like to take "Samples Builders", section out of the suggestions.
This raises an interesting question... our acceptance tests run against the samples builder, once the samples builder is no longer a default or even a suggested builder this doesn't seem as appropriate any more. What should we do instead?
Is testing against a builder created with pack create-builder sufficient? Should we also test that our suggested builders work? I think that would be probably be good for our users.

@ekcasey Is this story ready for acceptance?  I recall during standup @sclevine mentioning some more complex UX around grouping the CF builders together, but the builder that is listed first is randomized.

@ekcasey @ameyer-pivotal @djoyahoy Any pointers for how to mimic this scenario on my machine?  When I install the pack CLI on a workstation that has not had v0.1.0 installed at any point

@mgibson1121 you can delete the ~/.pack directory (rm -r ~/.pack) if it exists.

This passes acceptance


Use absl logging.

This is essentially glog, but now officially in absl.
Signed-off-by: Henner Zeller<EMAIL_ADDRESS>

Note, this is experimental right now and has some issues

VLOG() does not exist yet
google::InstallFailureSignalHandler(); was in glog, unclear what replacement to use
All the CHECK_<relational-comparison>() seem to have gained signed comparison anxiety:

external/com_google_absl/absl/log/internal/check_op.h: In instantiation of 'constexpr std::string* absl::log_internal::Check_EQImpl(const T1&, const T2&, const char*) [with T1 = long unsigned int; T2 = int; std::string = std::__cxx11::basic_string<char>]':
common/formatting/align_test.cc:848:5:   required from here
external/com_google_absl/absl/log/internal/check_op.h:329:43: warning: comparison of integer expressions of different signedness: 'const long unsigned int' and 'const int' [-Wsign-compare]
 329 | ABSL_LOG_INTERNAL_CHECK_OP_IMPL(Check_EQ, ==)

Codecov Report

Merging #1448 (abffc4c) into master (d7d3259) will increase coverage by 0.21%.
The diff coverage is 100.00%.

:exclamation: Current head abffc4c differs from pull request most recent head 1148252. Consider uploading reports for the commit 1148252 to get more accurate results

@@            Coverage Diff             @@
##           master    #1448      +/-   ##
==========================================
+ Coverage   92.94%   93.16%   +0.21%
==========================================
  Files         342      341       -1
  Lines       24158    23793     -365
==========================================
- Hits        22453    22166     -287
+ Misses       1705     1627      -78

Impacted Files
Coverage Δ

common/util/init_command_line.cc
47.05% <100.00%> (-2.95%)
:arrow_down:

verilog/transform/obfuscate.cc
77.46% <0.00%> (-1.49%)
:arrow_down:

common/parser/parser_test_util.h
76.19% <0.00%> (-1.43%)
:arrow_down:

common/parser/bison_parser_adapter.h
84.61% <0.00%> (-1.10%)
:arrow_down:

verilog/analysis/verilog_excerpt_parse.cc
78.37% <0.00%> (-0.57%)
:arrow_down:

verilog/analysis/dependencies.cc
95.38% <0.00%> (-0.40%)
:arrow_down:

verilog/tools/project/project_tool.cc
92.85% <0.00%> (-0.35%)
:arrow_down:

verilog/tools/kythe/kythe_facts_extractor.cc
37.05% <0.00%> (-0.34%)
:arrow_down:

common/formatting/format_token.cc
94.54% <0.00%> (-0.23%)
:arrow_down:

... and 37 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

FYI @mglb : this will change the names of environment variables used for triggering logging VERIBLE_LOGTHRESHOLD and VERIBLE_VLOG_DETAIL.


Update README: Only TCP port forwarding supported

Documenting the inability to forward protocols other than TCP.
See  #260

Thanks!


Update jquery.payment.d.ts

I made some improvements to the definition file for jquery.payment:

Put interfaces inside a module so they aren't in the global namespace.
Added JQuery return type to JQuery.payment() so calls can be chained more easily.
Added cards array property and CardInfo interface.
Added documentation for most methods and properties.
Marked type parameter on validateCardCVC() method as optional.

jquery.payment/jquery.payment.d.ts
to author(@ejsmith). could you review this PR?
:+1: or :-1:?
check list

[ ] pass the Travic-CI test?

@johnrutherford please fix travis ci failed.
https://travis-ci.org/borisyankov/DefinitelyTyped/builds/75300030

@vvakame Sorry, I couldn't see the Travis-CI page for a while. I should have runs the tests before my initial commit. It's fixed now.

Looks good to me. :+1:

@ejsmith thanks!
@johnrutherford thanks mate!


Kite does not work after laptop sleeps

After putting my computer to sleep, when I open up Nvim, kite shows that it is ready in the statusline, but it does not complete any variable or method names. It works only after a restart (or if I shut it down instead of putting it to sleep).

Is this still an issue with the latest version of Kite?

IDK, I had actually been using Vscode for a while and am now trying to re-vamp my Neovim setup, and I haven't been experiencing the problem so far. I think it may have been a conflict with one of my other plugins at the time. Or maybe the latest version of kite fixed it. I really don't know.

Thanks for the update! Going to close this issue then.


about readme

Hi Kiakh,
The preprint url in the readme refers to (https://arxiv.org/abs/2107.11786v2，Deep Learning-based Frozen Section to FFPE Translation).
Maybe you should alter this URL with your paper.

Thanks for pointing it out!


Fix: Task does not appear in LHN after self-assigning as a group member

Details

Task does not appear in LHN after self-assigning as a group member. This PR fixes that.
Fixed Issues

$ https://github.com/Expensify/App/issues/26762
PROPOSAL: https://github.com/Expensify/App/issues/26762#issuecomment-1710069654
Tests

Login with A and B
On A, go to a group chat with B as a member
Create a task without assignee
On B, self-assign the task
Verify that the task report is displayed in LHN

[x] Verify that no errors appear in the JS console

Offline tests

NA
QA Steps

Login with A and B
On A, go to a group chat with B as a member
Create a task without assignee
On B, self-assign the task
Verify that the task report is displayed in LHN

[x] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android / native
[x] Android / Chrome
[x] iOS / native
[x] iOS / Safari
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[x] I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

https://github.com/Expensify/App/assets/113963320/cc2c2b7d-4693-41ef-bc58-ee6041136d5e

Android: mWeb Chrome

https://github.com/Expensify/App/assets/113963320/64b3ff6c-3a8b-457e-9944-f140d5d95f18

iOS: Native

https://github.com/Expensify/App/assets/113963320/6990d7b0-90f9-4401-b1e9-0861a4eb3ca0

iOS: mWeb Safari

https://github.com/Expensify/App/assets/113963320/d6181a06-0265-4ad9-b072-dcba155a7324

MacOS: Chrome / Safari

https://github.com/Expensify/App/assets/113963320/b413cee6-be83-4b26-9908-c069df4e70c9

MacOS: Desktop

https://github.com/Expensify/App/assets/113963320/4600daad-592b-482f-877c-6f363a4781f8

the bug specifically happen in group chat

For me it isn't reproducible in group chat either (the video below is latest main), only in rooms
https://github.com/Expensify/App/assets/9059945/0e1de907-a052-422c-a0c1-144628b41d78

Reviewer Checklist

[ ] I have verified the author checklist is complete (all boxes are checked off).
[ ] I verified the correct issue is linked in the ### Fixed Issues section above
[ ] I verified testing steps are clear and they cover the changes made in this PR

[ ] I verified the steps for local testing are in the Tests section
[ ] I verified the steps for Staging and/or Production testing are in the QA steps section
[ ] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[ ] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[ ] I checked that screenshots or videos are included for tests on all platforms
[ ] I included screenshots or videos for tests on all platforms
[ ] I verified tests pass on all platforms & I tested again on:

[ ] Android: Native
[ ] Android: mWeb Chrome
[ ] iOS: Native
[ ] iOS: mWeb Safari
[ ] MacOS: Chrome / Safari
[ ] MacOS: Desktop

[ ] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[ ] I verified proper code patterns were followed (see Reviewing the code)

[ ] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[ ] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[ ] I verified that comments were added to code that is not self explanatory
[ ] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[ ] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[ ] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[ ] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[ ] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[ ] I verified the JSDocs style guidelines (in STYLE.md) were followed

[ ] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[ ] I verified that this PR follows the guidelines as stated in the Review Guidelines
[ ] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[ ] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[ ] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[ ] If a new component is created I verified that:

[ ] A similar component doesn't exist in the codebase
[ ] All props are defined accurately and each prop has a /** comment above it */
[ ] The file is named correctly
[ ] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[ ] The only data being stored in the state is data necessary for rendering and nothing else
[ ] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[ ] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[ ] All JSX used for rendering exists in the render method
[ ] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[ ] If any new file was added I verified that:

[ ] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[ ] If a new CSS style is added I verified that:

[ ] A similar style doesn't already exist
[ ] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)

[ ] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[ ] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[ ] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[ ] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[ ] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[ ] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[ ] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to staging by https://github.com/techievivek in version: 1.4.2-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/luacmartins in version: 1.4.2-3 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


Internal Error: Unable to follow symbol for "const" when using as const

Describe the bug
While i am using the plugin i found a problem that it cannot handle as const constants when passing to type. This is when the rollupTypes is true

Reproduction
https://stackblitz.com/~/github.com/panvourtsis/react-blogs/tree/panvourtsis/showcase-as-const
Steps to reproduce
navigate to the url that is a fork from react-blogs
I've change the Title.tsx with the as const demo prop
run yarn build
System Info
[vite:dts] Internal Error: Unable to follow symbol for "const"

You have encountered a software defect. Please consider reporting the issue to the maintainers of this application.
✓ built in 11.59s
error during build:
Error: Internal Error: Unable to follow symbol for "const"

You have encountered a software defect. Please consider reporting the issue to the maintainers of this application.
    at new InternalError (/home/panvourtsis/react-blogs/node_modules/@rushstack/node-core-library/lib/InternalError.js:24:9)
    at AstSymbolTable._analyzeChildTree (/home/panvourtsis/react-blogs/node_modules/@microsoft/api-extractor/lib/analyzer/AstSymbolTable.js:328:43)
    at AstSymbolTable._analyzeChildTree (/home/panvourtsis/react-blogs/node_modules/@microsoft/api-extractor/lib/analyzer/AstSymbolTable.js:377:18)
    at AstSymbolTable._analyzeChildTree (/home/panvourtsis/react-blogs/node_modules/@microsoft/api-extractor/lib/analyzer/AstSymbolTable.js:377:18)
    at AstSymbolTable._analyzeAstSymbol (/home/panvourtsis/react-blogs/node_modules/@microsoft/api-extractor/lib/analyzer/AstSymbolTable.js:247:18)
    at eval (/home/panvourtsis/react-blogs/node_modules/@microsoft/api-extractor/lib/analyzer/AstSymbolTable.js:259:34)
    at AstDeclaration.forEachDeclarationRecursive (/home/panvourtsis/react-blogs/node_modules/@microsoft/api-extractor/lib/analyzer/AstDeclaration.js:168:9)
    at AstDeclaration.forEachDeclarationRecursive (/home/panvourtsis/react-blogs/node_modules/@microsoft/api-extractor/lib/analyzer/AstDeclaration.js:170:19)
    at AstSymbol.forEachDeclarationRecursive (/home/panvourtsis/react-blogs/node_modules/@microsoft/api-extractor/lib/analyzer/AstSymbol.js:103:28)
    at AstSymbolTable._analyzeAstSymbol (/home/panvourtsis/react-blogs/node_modules/@microsoft/api-extractor/lib/analyzer/AstSymbolTable.js:254:27)
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

Validations

[X] Read the FAQ.
[X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
[X] The provided reproduction is a minimal reproducible example of the bug.

Maybe a limitation of @microsoft/api-extractor, refer to https://github.com/microsoft/rushstack/issues/3875.

error during build:
[vite:dts] Internal Error: Unable to follow symbol for "const"
You have encountered a software defect. Please consider reporting the issue to the maintainers of this application.
at AstSymbolTable.analyzeChildTree (D:\Project\1-HTHT\pie-earth\node_modules.pnpm@microsoft+api-extractor@7.47.7@types+node@20.16.5\node_modules@microsoft\api-extractor\src\analyzer\AstSymbolTable.ts:406:25)
at AstSymbolTable.analyzeChildTree (D:\Project\1-HTHT\pie-earth\node_modules.pnpm@microsoft+api-extractor@7.47.7@types+node@20.16.5\node_modules@microsoft\api-extractor\src\analyzer\AstSymbolTable.ts:473:12)
at AstSymbolTable.analyzeChildTree (D:\Project\1-HTHT\pie-earth\node_modules.pnpm@microsoft+api-extractor@7.47.7@types+node@20.16.5\node_modules@microsoft\api-extractor\src\analyzer\AstSymbolTable.ts:473:12)
at AstSymbolTable.analyzeAstSymbol (D:\Project\1-HTHT\pie-earth\node_modules.pnpm@microsoft+api-extractor@7.47.7@types+node@20.16.5\node_modules@microsoft\api-extractor\src\analyzer\AstSymbolTable.ts:312:12)
at AstSymbolTable.analyze (D:\Project\1-HTHT\pie-earth\node_modules.pnpm@microsoft+api-extractor@7.47.7_@types+node@20.16.5\node_modules@microsoft\api-extractor\src\analyzer\AstSymbolTable.ts:154:19)
at D:\Project\1-HTHT\pie-earth\node_modules.pnpm@microsoft+api-extractor@7.47.7_@types+node@20.16.5\node_modules@microsoft\api-extractor\src\analyzer\ExportAnalyzer.ts:340:42
at Map.forEach ()
at ExportAnalyzer.collectAllExportsRecursive (D:\Project\1-HTHT\pie-earth\node_modules.pnpm@microsoft+api-extractor@7.47.7@types+node@20.16.5\node_modules@microsoft\api-extractor\src\analyzer\ExportAnalyzer.ts:328:40)
at ExportAnalyzer.collectAllExportsRecursive (D:\Project\1-HTHT\pie-earth\node_modules.pnpm@microsoft+api-extractor@7.47.7@types+node@20.16.5\node_modules@microsoft\api-extractor\src\analyzer\ExportAnalyzer.ts:356:14)
at ExportAnalyzer.fetchAstModuleExportInfo (D:\Project\1-HTHT\pie-earth\node_modules.pnpm@microsoft+api-extractor@7.47.7_@types+node@20.16.5\node_modules@microsoft\api-extractor\src\analyzer\ExportAnalyzer.ts:248:12)
 ELIFECYCLE  Command failed with exit code 1.


search.maxResults does not affect how many results are found/highlighted

Steps to Reproduce:

Create a file with the same line 300k times
search for something in the line - 19999+ results are found, and that many are highlighted
change search.maxResults to something above or below the default
search again
:bug: 19999+ results are found, and that many are highlighted

+1, extremely annoying and counter-intuitive that the setting only affects the full project-wide search accessible on the sidebar and not the local file Ctrl + F search. I ran into this issue and couldn't even resort to the project-wide search with a strict filter for only the desired file, because it was a standalone file I had open, not within the open project's directory, so it couldn't find it.
Having to resort to grep on the terminal with a different regex engine so regex searches aren't even guaranteed to be 1:1 from VSCode is NOT good user experience.

Will this stay Open and Confirmed forever? Is this so low on the priority list of the project's devs that's not resolved after 1 year after its confirmation?

@amunger @bpasero Could you take a look at this issue? And for some reason, I can’t type or paste the value null
https://github.com/microsoft/vscode/assets/3277207/0d98d0a0-3350-4f39-842f-d18b3f87a075


Sort on children column

Hi,
First of all, TreeGrid is a POWERFUL datatable plugin with a simple approach (children)
There is however a small lack for me. When a column is sorted, the column of the child branch is not sorted.
If that had been possible, it would be great !
Best
Frédérik

Thanks for the suggestion, I'll check and update it once I'm free.
Best
Homfen


Adding validation to solution name

Description
There should be some validation on Solution Name input to prevent the special char.
Error message
Validation failed. errors: An instance of MachinesModel has failed the validation: - property name has failed the following constraints: isAlphanumeric ,An instance of MachinesModel has failed the validation: - property machines[0].name has failed the following constraints: isAlphanumeric.
Logs/Alerts

should be enforced everywhere

Verified on devnet.
Name validation was added for all solutions. and now it only accepts alphanumeric values and can only start with a alphabetical value. and the Deploy button is disabled when there's a validation error


More decimal points

Once you get beyond 20x (say 50x / 0.7 NA) you really want sub micron focusing. While the hardware supports this we don't display the position

Merged fix


Bluetooth: mesh: Temporarily allow K_FOREVER on system workqueue

This is intended as a hotfix of sorts, in order to give some time to the Bluetooth Host and Mesh stack maintainers to figure out a sustainable solution.
This commit should be reverted when that better solution is found.
Hotfixes https://github.com/zephyrproject-rtos/zephyr/issues/77241
DO NOT close the issue when the PR is merged. We should still design a better long-term solution to this problem.

@PavelVPV @jori-nordic I suppose we want this backported to 3.7 too?

I guess so

Also missing from commit message is the "why" this change is needed

You're right, I only added the issue link in the PR text. I will do both action points :+1:

closing. context: https://github.com/zephyrproject-rtos/zephyr/issues/77241#issuecomment-2318939720


Service Worker is not registering on "init mode"

Describe the bug
In the init mode, the service worker is not being registered properly. However, when using the mount mode, it functions correctly. I am utilizing the<EMAIL_ADDRESS>package, which includes a register method along with several hooks such as registered, error and updated. Unfortunately, none of these hooks are being triggered in the init mode.
Expected behavior
After a timeout of the delayed hydration process, the service worker should be registered properly.
Reproduce Like
https://github.com/neetu1123/Service_Worker

This seems to be fixed now with the latest Nuxt version :thinking:


how to do custom components

Hello, thanks for creating such a great package. I want to custom the date component and the cells to look like in the image, I've looked at the documentation like renderHeader in props but it doesn't work at all.
Thank you.

Hi thanks for the interest in this project.
I think there is no such props for now, but if you create a pull request,
I'm happy to merge it.
Best,
On Sun, Dec 25, 2022, 22:52 Muhamad Zulfiqor @.***>
wrote:

Hello, thanks for creating such a great package. I want to custom the date
component and the cells to look like in the image, I've looked at the
documentation like renderHeader in props but it doesn't work at all.
Thank you.
[image: Shift Schedule - Week]
https://user-images.githubusercontent.com/30437682/209470427-5a69a909-5b9a-4438-88c9-a8b0d0157b9a.png
—
Reply to this email directly, view it on GitHub
https://github.com/acro5piano/react-native-big-calendar/issues/796, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/ACRZCB4D3TAYIQJJNAXRZVTWPBGQPANCNFSM6AAAAAATJAAAMY
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>


Clarification on Document, Paragraph, Section, and Sentence

This is not a bug.
I'd want a clarification on Document, Paragraph, Section, and Sentence.
It is clear that which element in HTML becomes which data models like Figure, Table, Caption. E.g.,  and
 become Figure.
However, it is not obvious which element in HTML becomes Document, Paragraph, Section, and Sentence.

Right now, we use predefined tag to define those elements as follow:
Document: each file is one document
Section: ["html", "section"] tag
Figure: ["img", "figure"] tag
Table: "table" tag
Paragraph: every chunk of context in the node, such as content in ["text", "tail"]
Sentence: the parse results from NLP parser (e.g., Spacy) define the sentence.
One idea to improve it is to use a configuration file to define those indicator tags for different applications.
Thanks for your question!
Sen

Thanks for your clarification.
https://lxml.de/tutorial.html#elements-contain-text helps me better understand the Paragraph.
In the following example,
Hello. Nice to meet you.
Snorkel is great. Fonduer is even greater.
"Hello. Nice to meet you." is one paragraph, and "Snorkel is great. Fonduer is even greater." is another.
Sentence is beyond what HTML elements tell you.
"Hello." is one sentence, "Nice to meet you." is another. But this depends on the NLP parser.
Let me add these information to the documents.


New release?

related: #1280
It seems go-github didn't release new version since Sep 8, 2019 and there are about 50 commits since the last release.
Can you release new version?
Thanks in advance!

Yes, I would like to get approval from @willnorris for #1344 and merge that first, as that would be the first major release since the discussion in #1280.
Maybe we should merge master into #1344 before merging to make a single large release?  I'll comment on the PR.

Thank you for the quick response!

Maybe we should merge master into #1344 before merging to make a single large release?

Were there any breaking changes? If so, go-github must bump major version first. If no, I think go-github should just bump minor tag.
p.s. @gmlewis Thank you for maintaining the project :heart:

Yes, there have been many breaking changes.  #1344 is bumping the major version for the breaking changes up to that point... and if we decide to do another release immediately after that (without first merging master into #1344) we would need to bump the major version again with more breaking changes.
For a while there, I was trying to be strict about semver releases after every merge (major, minor, patch), but the volume just got to be too much.
Thank you for the kind words, @haya14busa!

A new version would be great, but if you can't wait for it to be released, you can get features from the head of master into a project that uses Go modules with go get -v github.com/google/go-github/v28@master (which I only recently learned).

We just released v29.0.0.
Closing.

Ugh, I broke the build... trying to figure out how to roll it back...


Internal: upgrade postcss and cssnano

Attempting to address https://github.com/pinterest/gestalt/security/dependabot/29
Though our version of postcss isn't vulnerable, several dependency versions are. This PR upgrade cssnano and all our postcss dependencies to minimize our exposure to the vulnerability.

this isn't a drop-in replacement and we're probably fine, so abandoning for now


bug: Zen mode opening raises an error in terminal mode

Did you check docs and existing issues?

[X] I have read all the zen-mode.nvim docs
[X] I have updated the plugin to the latest version before submitting this issue
[X] I have searched the existing issues of zen-mode.nvim
[X] I have searched the existing issues of plugins related to this issue

Neovim version (nvim -v)
0.10.2
Operating system/version
Windows 11
Describe the bug
Zen mode can be toggled from the terminal split, but it raises an error
E5108: Error executing lua vim/_editor.lua:431: nvim_exec2(): Vim(normal): Can't re-enter normal mode from terminal mode
Steps To Reproduce

Add some mapping to toggle ZenMode in terminal mode
Open split terminal. For example with C-/ in LazyVim
Trigger the mapping
Result: ZenMode is activated but with the error

Expected Behavior
Error doesn't happen. The plugin manages the correct toggling for terminal mode by itself
Repro
vim.env.LAZY_STDPATH = ".repro"
load(vim.fn.system("curl -s https://raw.githubusercontent.com/folke/lazy.nvim/main/bootstrap.lua"))()

require("lazy.minit").repro({
  spec = {
    {
      "folke/zen-mode.nvim",
      opts = {},
      keys = {
        { mode = { "n", "i", "t" }, "<A-z>", "<cmd>ZenMode<cr>", desc = "Toggle Zen Mode" },
      }
    },
  },
})

I can't reproduce this in LazyVim...

I found that bug isn't reproducible for cmd shell, but reproducible for pwsh ot powershell
I corrected the list of steps:

Use the same repro config
Enter nvim
:sp
:term
i -> go to insert mode
type powershell or pwsh
press Enter
press <A-z>

Messages:
E5108: Error executing lua vim/_editor.lua:431: nvim_exec2(): Vim(normal):Can't re-enter normal mode from terminal mode
stack traceback:
        [C]: in function 'nvim_exec2'
        vim/_editor.lua:431: in function 'cmd'
        .../nvim-lazy-data/lazy/zen-mode.nvim/lua/zen-mode/view.lua:187: in function 'create'
        .../nvim-lazy-data/lazy/zen-mode.nvim/lua/zen-mode/view.lua:80: in function 'open'
        .../nvim-lazy-data/lazy/zen-mode.nvim/lua/zen-mode/view.lua:88: in function 'toggle'
        [string ":lua"]:1: in main chunk


WIP: fix issues in function definitions

Which issue does this PR close?
Addresses #1364 #1173
Several of the built-in function definitions are not setup correctly and the functions cannot actually be used at all.
This is the start of some changes to ensure that functions can be passed the correct parameters.
All seeks to address a gap in the test suite and examples and documentation.
There are not many tests using the internal functions, and there are no tests at all using functions with dataframes.
Posting this as WIP because just want to confirm the approach.
Testing functions is tricky because of all the Expr magic, so I've pulled the tests into the integration layer.

Hi @tobyhede I am checking in on this PR -- any chance you will be able to complete it any time soon?

It's taking me a bit longer than anticipated - there are a range of function arities to consider.
I am on the right track though, so I'll close this and reopen with new code.

It's taking me a bit longer than anticipated - there are a range of function arities to consider.

This is the story of my life with software development 😆  maybe more so with Rust


DOC: update 1.0 release notes

I deleted the boilerplate at the start, because it's a repeat of what's on the front page of the docs.

Codecov Report

Merging #412 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #412   +/-   ##
=======================================
  Coverage   80.59%   80.59%
=======================================
  Files          23       23
  Lines        4009     4009
  Branches      729      729
=======================================
  Hits         3231     3231
  Misses        707      707
  Partials       71       71

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ccf69f5...97feadf. Read the comment docs.


Added find bash script for file extensions

script1 finds and replaces file extensions, script2 replaces link extensions in files with a particular extension.

merged new changes

Pullout password change

File extension


Facebook login failure

When I sign in with Facebook, it simply get this failure below.
Get User By ID Error: The operation couldn’t be completed. (BMSCore.BMSCoreError error 2.)
Check If User Already Exists Error: Connection Failure
Login Error: Connection Failure
What is that? My connection is well but...

I confirmed, Facebook login is still working for me. Have you gone through the steps mentioned here: https://github.com/IBM-Swift/BluePic#optional-features-to-configure to setup Facebook and MCA?

Yes, I did. But still failed

I just did a fresh clone of BluePic and it still works for me.
Is there any more information you can give me?

What iOS version are you using?
Is this on a simulator?
Did you run pod install? Because it is not necessary.
Are you able to get images on the main feed?
Are you able to post any images or does the login screen just pop up?

You could try resetting your database to start fresh. I'll keep looking into this.

I am sure I didn't run pod install and I am not able to get images on the main feed even post any images.
And one more question. I began learn iOS programming 3 months ago. And the architecture of this app is MVVM, right? I am not familiar with this architecture.

@dazhendong Are you having the same issues as scauos?
Have you tried creating the BluePic app/runtime through IBM Cloud Tools for Swift? I am testing this now, will get back to you with my results on Monday.
Yes, we are using MVVM. Not quite as simple as MVC, but definitely has its benefits.

I have solved this problem. And I try to learn this design pattern MVVM through your creative app. But still configured . Do you have some link teaching MVVM I can learn from. Thanks.

Thats great. I also got things working fine by using the IBM Cloud Tools for Swift app and then configuring Facebook and MCA.
One good resource is this: https://www.raywenderlich.com/74106/mvvm-tutorial-with-reactivecocoa-part-1
Also, haven't completely read this one, but Artsy is usually good: http://artsy.github.io/blog/2015/09/24/mvvm-in-swift/


Remove unnecessary require from QueuedEmail (zeitwerk)

No longer necessary due to Zeitwerk. Tiny PR.

Coverage decreased (-0.0009%) to 92.721% when pulling 0cddc1069446784ff7cab90fc5592481a4763e60 on nimmo-delete-queued_email-requires into bd70968eb61e30db734a78836325774e31fccd4a on master.


Remove res.redirect + res.redirectWithFlash

As we move to a 'pure' API, we want to replace the parts of the api that only make sense in the context of a browser.
Calls like res.redirect set the location header which causes the browser to redirect. But, obviously, this doesn't do much if the client is not a browser.
@raisedadead could you flesh this out a little? I'm not 100% on what we want instead.

I'd assume the approach would be to send a 3XX redirect status from the API (with any messaging we want?) and handle the actual redirection logic on the client side specifically?

I do not think the API should send any 3XX for our use of res.redirect. A 3XX should only be sent in cases where the API endpoint has been updated (moved) so the client needs to be told to make a new request at the returned endpoint.
I do not think 3XX has anything to do with telling a client to change URL/page.

API Example:
  api.get('/signout', deleteUserToken, (req, res) => {
    const { origin, returnTo } = getRedirectParams(req);
    req.logout();
    req.session.destroy(err => {
      if (err) {
        throw wrapHandledError(new Error('could not destroy session'), {
          type: 'info',
          message: 'We could not log you out, please try again in a moment.',
          redirectTo: origin
        });
      }
      removeCookies(req, res);
      res.redirect(returnTo);
    });
  });

Should become:
  api.get('/signout', deleteUserToken, (req, res) => {
    req.logout();
    req.session.destroy(err => {
      if (err) {
        return res.status(500);
      }
      removeCookies(req, res); // Although, this will go too.
      return res.status(200);
    });
  });

Then, the client needs to handle what it does:
if (res.status === 200) {
  navigate("/");
} else if (res.status === 500) {
  // Go nowhere
  flashUser("Unable to sign out. Please try again later");
}

I think 302 Found is the standard code for this kind of redirect, since it tells the client to keep sending requests to the original URL (e.g. /signout). It's not just for when you've moved a resource - it's for when the client should change location.
What I'm trying to understand is this: do we need to change the server behaviour at all? We talked about this briefly in the meeting, but I don't understand the problem with sending a 302 + location. A browser will handle that automatically and a server can do whatever it wants with that information.