Immediate exit when dragging something over the window.

If I drag a file or browser tab over the window, it immediately exits. According to GDB it exits normally.

Hmm here I use cinnamon so full screen GL really; I can drag windows over/under all I want and it's fine.... are you using 'nouveau' or some other driver?

Fedora/XWayland/AMD here. To be clear, I don't mean dragging windows over it, but drag and drop objects. So by "browser tab" I mean when you pop out a Firefox tab, that's a droppable object. Same with dragging a file icon over the window, it just immediately quits.

Following up, it's this "client message" line that causing the exit:
https://github.com/buserror/mii_emu/blob/2e12a37bceebef3787abddc1ca10d82fdc427e9d/ui_gl/mii_emu_gl.c#L678
I've never done X programming directly before, but here's what gdb has to say about evt.xclient if that's helpful anyway:
(gdb) p evt.xclient
$2 = {type = 33, serial = 371, send_event = 1, display = 0xa5e0b0, window = 23068674, message_type = 307, format = 32, data = {
    b = "\004\000`\000\000\000\000\000\001\000\000\005\000\000\000\000\000\000\000", s = {4, 96, 0, 0, 1, 1280, 0, 0, 0, 0}, l = {6291460, 83886081, 0, 0, 0}}}

Throwing this in there:
printf("atom_name: %s\n", XGetAtomName(ui->dpy, evt.xclient.message_type));
Results in the following which isn't too surprising:
atom_name: XdndEnter
Is there a particular event you are looking for there?

Interesting; it must be remnant of some other code. The Client Message can be used for quite a few things, wonder why it's still there! Good catch tho, I obviously never really look at that code :-)
Also, strangely, it never happens on Xorg! -- I'll remove these lines...

Ahh I remember now, it CAN be used to prevent to have better granularity when scaling the window, but I had found another way to do it anyway so completely unneeded. Good find :-)

Oh, I ALSO figured out why it was still there, and in fact fixed it. ClientMessage are used for the closebox of the window manager, so it was there to allow closing the window, but of course that did it for any ClientMessage. I've now added proper filtering. Nice catch :-)

Seems to be fixed in 1.8.


Works unreliably in Windows 10 pro

Python 3.5.2. Windows 10 professional 64 bit. Retrieving speedtest.net configuration... fails quite often. Never fails in Windows 7 pro 64-bit. These is no any waiting in Retrieving speedtest.net configuration... state. Error is printed very soon.
C:\test>python speedtest_cli.py
Retrieving speedtest.net configuration...
Traceback (most recent call last):
  File "speedtest_cli.py", line 796, in <module>
    main()
  File "speedtest_cli.py", line 790, in main
    speedtest()
  File "speedtest_cli.py", line 623, in speedtest
    config = getConfig()
  File "speedtest_cli.py", line 385, in getConfig
    configxml.append(uh.read(10240))
  File "C:\Program Files (x86)\Python35-32\lib\http\client.py", line 448, in read
    n = self.readinto(b)
  File "C:\Program Files (x86)\Python35-32\lib\http\client.py", line 488, in readinto
    n = self.fp.readinto(b)
  File "C:\Program Files (x86)\Python35-32\lib\socket.py", line 575, in readinto
    return self._sock.recv_into(b)
ConnectionResetError: [WinError 10054]

Problem occurs in VMs.

Please give the devel branch a try and see if the changes made there already resolve your problem.
https://raw.githubusercontent.com/sivel/speedtest-cli/devel/speedtest.py

Please test with the recently released v1.0.0.

I tried speedtest 6 times and 2 of them failed. Windows 7 pro 64-bit is running in Virtual Bos.
python.exe speedtest_cli.py
Retrieving speedtest.net configuration...
Traceback (most recent call last):
File "speedtest_cli.py", line 1410, in
main()
File "speedtest_cli.py", line 1400, in main
shell()
File "speedtest_cli.py", line 1310, in shell
speedtest = Speedtest()
File "speedtest_cli.py", line 685, in init
self.get_config()
File "speedtest_cli.py", line 710, in get_config
stream = get_response_stream(uh)
File "speedtest_cli.py", line 417, in get_response_stream
return GzipDecodedResponse(response)
File "speedtest_cli.py", line 296, in init
self.io = IO(response.read())
File "c:\Ohjelmatiedostot\Python35 32\lib\http\client.py", line 461, in read
s = self._safe_read(self.length)
File "c:\Ohjelmatiedostot\Python35 32\lib\http\client.py", line 607, in _safe_read
chunk = self.fp.read(min(amt, MAXAMOUNT))
File "c:\Ohjelmatiedostot\Python35 32\lib\socket.py", line 575, in readinto
return self._sock.recv_into(b)
ConnectionResetError: [WinError 10054]
python.exe speedtest_cli.py --version
1.0.0

This should be resolved in devel as part of 823d7dc2b7e9a7acc9769fb197eb9f56a36444a9


Cron job  - Parse error: syntax error, unexpected '*', expecting end of file

Hey, none of the alternatives works for me, get the same error every time
Parse error: syntax error, unexpected '*', expecting end of file
Then, manually a cron job every 15 minutes (it should be enough for most websites):

*/15 * * * * wget -q -O - http://www.website.com/wp-cron.php?doing_wp_cron >/dev/null 2>&1

or

*/15 * * * * curl http://www.website.com/wp-cron.php?doing_wp_cron > /dev/null 2>&1

or

*/15 * * * * cd /home/user/public_html; php wp-cron.php > /dev/null 2>&1

Make sure you test that your tasks still run after this change!`

It looks like you pasted this into a PHP file.
I suggest you Google "How to add a crontab" depending on your configuration.  When in SSH, you can simply run:
crontab -e
... and paste ONE of the line.  Make sure you change the URL.

ok got it, thought i needed to add it to wp-config.php under define('DISABLE_WP_CRON', true);
thx for the quick support!
does it matter if i use www or non-www in the url?
(my website always redirect to non-www)

Good!
No, it does not matter how your URL is structured! :-)


Update kube config

This depends on https://github.com/istio/test-infra/pull/349

@sebastienvas: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/pilot-presubmit.sh
b04f0837a9346f95bc83a021f25fe6bdd488e4c6
link
@istio-testing bazel test this

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test all

@sebastienvas: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/pilot-presubmit.sh
b04f0837a9346f95bc83a021f25fe6bdd488e4c6
link
@istio-testing bazel test this

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Jenkins job pilot/presubmit passed

/test all

Jenkins job pilot/e2e-smoketest passed

@sebastienvas: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/pilot-presubmit.sh
b04f0837a9346f95bc83a021f25fe6bdd488e4c6
link
@istio-testing bazel test this

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test all


Maintaining pypuppetdb - looking for volunteers

Though it pains me to write this I am no longer able to maintain pypuppetdb.
I have commitments to many open source projects which at this point means I am spread to thin. Paired with no longer having a need to develop this project on a personal or professional basis it has slipped further and further. This is harmful to the project and its continuity.
There are however plenty of people and organisations that rely on this project. As such I am hoping that some will step up and take over from me. I'm more than happy to facilitate discussions or function in an advisory capacity but I can no longer be the driver.
If you'd like to take over I'd like to know a few things:

Why you want to take over / will be able to work on it
What your PyPi username is so I can give you upload privileges

I have only one constraint. Pypuppetdb resides in the Puppet-Community Github organisation and I expect it to stay there. It's a project that was started by Puppet community members and that was contributed to by Puppet community members. As such it belongs here.

This relates to puppet-community/puppetboard#132.

I volunteer myself to be a maintainer.
I am working on this project and the puppetboard project, in forks, to make it compatible with puppetdb 3.x and working on that has given me new ideas on the future of the projects. While I lack a diverse set of testing environments and experience working in python I hope that I can learn and grow from these projects
I do not have a PyPi username at the present time but will have one available shortly.

Works for me. I've added you to the necessary project teams. Use your new-found power carefully and discuss any major changes with other collaborators first :smile:.

@daenney My PyPi username is coreyhammerton

nudge for PyPi permissions

Done, you have access now.

@corey-hammerton I really need you to start being available in at least #puppetboard on Freenode and preferably also #puppet-community. People need support sometimes when things go wrong but have no way of reaching the maintainer. That's not a good experience.


Rename SonarRanges.msg

As discussed in #3, the current name is confusing because:

The message actually reports travel times, rather than directly converting them to ranges
It has a lot of fields that are clearly aimed at MBES instruments.

@valschmidt suggested using MBES in the name, and maybe rawMBES.
Other ideas/suggestions?

MBES or  rawMBES sounds ok to me.   I think I prefer MBES.  This is fundamentally the type of data the MBES produce.  I think "raw" is redundant and does not match the convention with most other ROS types in my experience.

Other options: What about just Multibeam.msg? MultibeamEcho.msg?
(Brainstorming, not advocating.)

I like MultibeamEcho or how about MultibeamDetections.   We aren't really reporting raw multibeam data. We are reporting what the MBES detected and reported to us.
so how about something like:

MultibeamEcho/Detections:  for detected returns
MultibeamWatercolumn:  for intensities over time and for each rx-angle
MultibeamRaw:  For all phase/intensity information needed to generate bearings, travel times, and detections.   Maybe implement this in the future,  haven't encountered a sonar that reports this to users.

I'm currently on a call w/ @tfoote, and he made some good comments about this issue:

Multibeam will be confusing for people not already immersed in the marine community, because there are plenty of sensors with multiple beams
If we want this message to be used broadly, Watercolumn is overly specific.

How about:

SonarDetections
SonarImage

or, if we want to be very descriptive:

MultibeamSonarDetections
MultibeamSonarImage

I would stay away from Sonar* naming because the geometry associated with this message is intended to be specific to multibeams.
I vote for MultibeamSonar*  or MBES* for brevity.
*Image and *Detections sound ok to me.

From the viewpoint of someone who may search for the messages it's important to not just have the acronyms in the names. Verbose and searchable is better. In the code it gets compiled away or you can use shortcuts/aliases.
Though I understand that these are specifically for multibeam sonar. What are the potential other datatypes for other sonars? Can they have Sonar which would clearly distinguish them? If it's not multibeam is a single beam or point or just a sensor_msgs/Range?

This has been resolved: we now have SonarDetections.msg for time-domain, and SonarRanges.msg for data that has been processed to return distances.


Cargo.toml: Add CI badges

@ezrosent has pointed out that this could be misleading since a build or test failure caused by any crate in the repo could cause an unrelated (ie, non-dependent) crate to appear to be failing on crates.io. It's not worth that potential confusion for the very minor benefit these badges bring.


Hermes output different every build

Description
When running the command multiple times I never get a collision of code when using Hermes:
appcenter codepush release-react \
  --app "ned.stuart/test" \
  --deployment-name "Staging" \
  --description "testing" \
  --target-binary-version "1.5.x"

The Hermes engine output is different every release-react despite no code or resource changes. This difference seems to stem from the JS path being baked into the binary output.
Repro Steps
Run the provided command (with your own variables) on a Hermes enabled project 2 times back to back.
Expected behavior
Releasing code which contains duplicate code results in
Error: The uploaded package was not released because it is identical to the contents of the specified deployment's current release.

Details

Is there a particular beacon/command that you are having trouble with?

appcenter codepush release-react

Which version of the App Center CLI are you using?

2.11.0

Which OS version did you experience the issue on?

MacOS M1 13.0.1

What command line/shell are you using?

N/A

What version of Node.js and NPM/Yarn are you using?

Node v16.13.2 (but shouldnt be applicable I dont think)

Relavant information
This is not unique to any specific library and can be observed on a simple 1 liner JS file. As mentioned above the issue seems to be that Hermes bakes in the JS file path into the output, since CodePush builds to a temp folder which is auto generated by the system its different every time.
Recreating diff Hermes output

Create a javascript file (or any project will do)

// index.js
console.log('hello');

Compile JS to Hermes using a relative path

hermesc -emit-binary -out index_a.hbc index.js -w
xxd index_a.hbc > index_a.hex

Compile using an different path (literally any other path to the file)

hermesc -emit-binary -out index_b.hbc ~/test_hermes/index.js -w
xxd index_b.hbc > index_b.hex

Diff the 2 hex files

> diff index_a.hex index_b.hex
3c3
< 00000020: 3701 0000 0000 0000 0100 0000 0200 0000  7...............
---
> 00000020: 5201 0000 0000 0000 0100 0000 0200 0000  R...............
15,20c15,22
< 000000e0: 0000 0000 0100 0000 0800 0000 0100 0000  ................
< 000000f0: 0d00 0000 0f00 0000 0000 0000 0800 0000  ................
< 00000100: 696e 6465 782e 6a73 0000 0000 0000 0000  index.js........
< 00000110: 0000 0000 0001 0102 0000 0600 0b09 0000  ................
< 00000120: 7f7f 004b 1a3e f8c5 5e2b 87b4 6890 a25e  ...K.>..^+..h..^
< 00000130: e393 1487 f006 52                        ......R
---
> 000000e0: 0000 0000 0100 0000 2300 0000 0100 0000  ........#.......
> 000000f0: 0d00 0000 0f00 0000 0000 0000 2300 0000  ............#...
> 00000100: 2f55 7365 7273 2f6e 7374 7561 7274 2f74  /Users/nstuart/t
> 00000110: 6573 745f 6865 726d 6573 2f69 6e64 6578  est_hermes/index
> 00000120: 2e6a 7300 0000 0000 0000 0000 0000 0000  .js.............
> 00000130: 0101 0200 0006 000b 0900 007f 7f00 4b1b  ..............K.
> 00000140: e318 a347 0a8c a247 c874 0560 75d5 ef80  ...G...G.t.`u...
> 00000150: 278e

A possible fix
When generating the Hermes hbc file do it relative to the temp folder so the path is always the same:
diff --git a/./react-native-utils.ts b/./react-native-utils_patched.ts
index 1d5ef8c..ec4839b 100644
--- a/./react-native-utils.ts
+++ b/./react-native-utils_patched.ts
@@ -354,8 +354,8 @@ export async function runHermesEmitBinaryCommand(
 	Array.prototype.push.apply(hermesArgs, [
 		"-emit-binary",
 		"-out",
-		path.join(outputFolder, bundleName + ".hbc"),
-		path.join(outputFolder, bundleName),
+		path.join(bundleName + ".hbc"),
+		path.join(bundleName),
 		...extraHermesFlags,
 	]);

@@ -369,7 +369,9 @@ export async function runHermesEmitBinaryCommand(

 	out.text(chalk.cyan("Converting JS bundle to byte code via Hermes, running command:\n"));
 	const hermesCommand = await getHermesCommand(gradleFile);
-	const hermesProcess = childProcess.spawn(hermesCommand, hermesArgs);
+	const hermesProcess = childProcess.spawn(path.join(process.cwd(), hermesCommand), hermesArgs, {
+		cwd: outputFolder
+	});
 	out.text(`${hermesCommand} ${hermesArgs.join(" ")}`);

 	return new Promise<void>((resolve, reject) => {

@nedjs Thank you for the report! Let take a look how many users are experiencing this issue.

As we do not have plans to fix this bug in the next year, I'm closing the issue.


Modification in Steps

There were few steps recommended by the user to fit in the document and make the document more clear. I have added a few of the recommendations based on the tests.
Problem: https://github.com/MicrosoftDocs/windows-itpro-docs/issues/8557

@JohanFreelancer9 - kindly do the copy editor review for this PR. Thanks.


Add indexWith?

Not sure if it's best place for it but I find using something like his when working with NonEmpty:
indexWith :: ∀ a f. (f a → Int → Maybe a) → NonEmpty f a → Int → Maybe a
indexWith _    (NonEmpty x _ ) 0   = pure x
indexWith with (NonEmpty _ xs) idx = with xs (idx - 1)

indexNEA :: ∀ a. NonEmpty Array a → Int → Maybe a
indexNEA = indexWith index

You should probably be using NonEmptyList anyway IMO

I use Array because I'm not updating, need indexed access, iteration over elements. NonEmptyList will work tho as at this current moment, my data is 30-40 elements or something.
do you think it will be better to define NonEmptyArray instead of indexWith-kinda thing?

NonEmpty doesn't assume anything about how indexing works in the container, but this does. I don't think we should assume anything like that, so a NonEmptyArray would be better IMO.


"Resolution canceled" when using multiprocessing

When parallelizing some tasks locally, using multiprocessing.Pool to spawn processes, the pipeline gets cancelled and hangs indefinitely.
Minimum example (tested on version 0.22.1):
import time
import multiprocessing
import sematic

def worker(n):
    time.sleep(1)
    return 1

@sematic.func
def pipeline(n_proc: int) -> float:
    with multiprocessing.Pool(n_proc) as pool:
        results = pool.map(worker, range(n_proc*5))
    return sum(results)

if __name__ == "__main__":
    print('Started')
    result = pipeline(3).resolve(tracking=True)
    print(result)

This what I get in the logs, the execution never stops:
Started
Received SIGINT, canceling resolution...
Received SIGINT, canceling resolution...
Received SIGINT, canceling resolution...
Received cancelation event
Server returned 400 for PUT http://<IP_ADDRESS>:5000/api/v1/resolutions/19712d410fe24efa8ba8854bd9761e90/cancel: {"error": "Resolution cannot be canceled. Current state: CANCELED"}
Server returned 400 for PUT http://<IP_ADDRESS>:5000/api/v1/resolutions/19712d410fe24efa8ba8854bd9761e90/cancel: {"error": "Resolution cannot be canceled. Current state: CANCELED"}

When running with tracking=False however it runs through.
Not sure what the issue is, probably something related to the handling of SIGTERM signals. What I did for now as a quickfix is to revert the handler to the default one, then it runs correctly:
default_sigterm_handler = signal.getsignal(signal.SIGTERM)
def setup_sigterm_handler(): # Called in the main sematic function
    signal.signal(signal.SIGTERM, default_sigterm_handler)

Hello, @materight! Thank you for reporting! This issue might be the same as #282.
Could you please share your use case? I'm interested about your requirements for spawning a multiprocessing pool locally.

Hi @tscurtu,
No I didn't issue the signal manually, I think it's just produced by the spawn processes after they are done (like in the example).
In this particular case we have an image dataset and we just want to check that every sample can be loaded correctly and is not corrupted.

Hello, @materight! This was fixed via #626, which will be included in the next release.


feat: common.js support

This is great! How far away from ready is this? :)

@Squareys  Not very far, will be finished at the midterm of May I think.


Add EVP_PKEY_supports_digest_nid() and use it for TLS CertificateVerify

Fixes #7348
I think it's correct not to filter our outbound advertisement. We can check the peer's signature with any digest; it's only our own signature where we're limited to what the EVP_PKEY can support.

Hm, this should check for EVP_PKEY_get_default_digest_nid() returning a "mandatory" result too. And that much could be done as a bug fix all the way back to 1.0.2 without introducing the new supports_digest_nid ctrl.

Added backports (without the new EVP_PKEY_supports_digest_nid() function)
https://github.com/dwmw2/openssl/commits/pkey_md_1.1.1
https://github.com/dwmw2/openssl/commits/pkey_md_1.1.0

Also, I believe the backports should be in different PRs.

If EVP_PKEY_supports_digest_nid() is to go in the public API of libcrypto it needs to do the "right thing" and should not misuse other functions of the public API.
libssl is not the only user of libcrypto: if it is ok for code in libssl to step over certain errors, it should do it by explicitly ignoring the error condition after checking the return value. Not doing so also exposes the library to potential pollution of the error stack.

My intent is to push the first two of these as bug fixes for older versions of OpenSSL as far back as you'll have them, and the third only for 1.1.2 (or 1.2.0 or whatever's next).

I can't work out how to make it stop saying that changes were requested. To my knowledge, nothing is outstanding.

Does this mean you don't have a button to dismiss the review? If not, maybe it's a matter of permissions. In this case, I can dismiss it for you. Or you just ping @romen.

Side note to @dwmw2 : it is not unusual here that sometimes red crosses remain although the requests have been addressed. Crucial is only that you get two approvals, one of which must be from an OMC member. Red crosses don't act as a veto. (Sometimes it happens that an OMC member places a veto, but he will do it by posting a message like -1: <explanation> and not using the GitHub red cross for that.)

@mspncp I know it's cosmetic but I am assuming the red cross detracts from the attention span of those who would need to approve it. They're busy, and if there are PRs to look at which don't have a big red cross, it's understandable that those PRs get first option on a reviewer's limited available time.
Besides, asking about those is a far more polite way to return attention to a languishing PR than directly agitating to "just review and merge my fixes please" :)

the red cross detracts from the attention

A merge conflict detracts even more from the attention ;-)
You need to rebase your branch, because GitHub is showing conflicts in util/libcrypto.num.
git checkout pkey_md
git pull --rebase origin master

Indeed, util/libcrypto.num is a notorious source of merge conflicts.
git diff

But don't hesitate, there is an easy trick: Just discard your own changes and recreate your symbol entries with make update:
git checkout --ours -- util/libcrypto.num
make update
git add  util/libcrypto.num

(Yes, it's confusing, but you have to use --ours, not --theirs, because the viewpoint has moved during rebase: HEAD is on master while your branch is being rebased onto it. Hint: just look at the conflict markers, --ours always chooses the left hand of the conflicts.)
That's it. Add your changes and continue rebasing:
git rebase --continue

I spoke too soon...  looking into the Travis failures

For backports... Just the first two commits?

Is this good to go? What branches is this for?

This is for master. I was planning to update my backports once the dust was settled and it was merged; it needs massaging for 1.1.0 and I haven't even looked at 1.0.2 yet.
For the backports, I would appreciate guidance: how far back should we backport it, and do we do just the first two commits which have a limited fix for the bug without adding the new API? Or is it OK to add the new EVP_PKEY_supports_digest_nid() too?

1.1.0 is in security-fix only mode. So I'd suggest 1.1.1 and 1.0.2 only. Bug fixes only to stable branches so you shouldn't be adding the new function in those branches.

OK, thanks. I'll do those once this is merged to master so I can reference the stable commit IDs.

Backports (which will need the "cherry picked from…" commit IDs updated after this origiinal PR is merged:
https://github.com/dwmw2/openssl/commits/pkey_md_1.1.1
https://github.com/dwmw2/openssl/commits/pkey_md_1.0.2
The first is a trivial cherry-pick but for 1.0.2 it looks a little different. I was planning to submit a new PR for each once this one is merged and the commit IDs are known. In the meantime, @romen can you opine on https://github.com/dwmw2/openssl/commit/ede8375913d02443ad9f3f91f7d536a7297c16a0 please?

I can merge this to master now, and then we can discuss other commits in the 2 separate PRs for 1.0.2 and 1.1.0.
@dwmw2 I had a look at dwmw2@ede8375 : it seems fine, even if a little bit confusing at first; but again I am not that familiar with libssl code, so I'll rely on better reviewers than me for that!

Merged to master, commits: eb7eb1378cd15c4652884b3701d4c0ef27b5b8a6, 2d263a4a73f852005b16359873475d48755999ad and ecbb2fca9301ef22b15beb30c4c0303b29846935 .
Thanks once again @dwmw2 for your contribution, and apologies for the latency lately on my part!

Thanks. Now I have commit IDs, backport PRs for
1.0.2: https://github.com/openssl/openssl/pull/7610
1.1.1: https://github.com/openssl/openssl/pull/7609


Running  npm package in cell like one would do on command line

Is it possible to run a npm package within a cell after it's been installed like you would from the command line?  I have installed shp2json with npm.install('shp2json') and would like to then run it with !shp2json /path/to/shapefile > output.json but receive an error saying /bin/sh: 1: shp2json: not found

Not at the moment @bazini627. The npm modules are installed for development, so any binary executables are not added to the path.
This is where you'd find installed npm modules, if you want to use absolute paths to the executables:
https://github.com/pixiedust/pixiedust_node/blob/master/pixiedust_node/node.py#L155-L159

I am not sure if this would change anything or help but couldn't you instead run
!npm install shp2json -g
and then access it like you would normally so
!shp2json /path/to/shapefile > output.json


Add option to change color of "icons"

It'd be nice to be able to change the color of the letter and background for items without an icon.

Hi @tycm, thanks for the suggestion! My goal is to one day support user provided issuer icons. Maybe that can serve the same purpose as custom colored letters and backgrounds?

Hi @tycm, thanks for the suggestion! My goal is to one day support user provided issuer icons. Maybe that can serve the same purpose as custom colored letters and backgrounds?

That would definitely be better, I was just wondering if it would be easy to implement and it would match how you're able to change the background color for contacts in iOS

That would definitely be better, I was just wondering if it would be easy to implement and it would match how you're able to change the background color for contacts in iOS

That's an interesting idea, and I see how it could be useful! Let's do user provided icons first, then we can see how this could fit in.

That's an interesting idea, and I see how it could be useful! Let's do user provided icons first, then we can see how this could fit in.


OCM-2493: Add support for 1AZ pool in mAZ cluster

Support creating single AZ machine pool in a multi-az cluster. AZ can be designated by either specifying the AZ name or by providing a subnet id for byo VPC.

/cc @nirarg

/retest

/retest

/retest

@nirarg @bardielle @amalykhi
Some thoughts:

Both AZ and subnet cannot be modified once the pool is created. This means we don't need to do anything w/ them during Update(), only Create().
OCM sends back the actual AZ/subnet(s), and that has led to a fair bit of the complication in validation.
The --multi-availability-zone of rosa cli is redundant based on the AZ/subnet options & type of cluster.

Proposal:

Switch to a single string for each of AZ and subnet options
Auto deduce "multi-availability-zone" based on (1) multi-zone cluster and (2) whether AZ or subnet are provided.
Don't update AZ/subnet in the state file based on OCM response, just preserve the user's config. This will allow us to prevent modification while also avoiding needing a list and complicated validation.

/cc @nirarg

Please squash all commits before merge

@JohnStrunk greate job!
Please squash all the commits before I'm approving the PR

Please squash all commits before merge

@nirarg done.

/retest

/approve
/lgtm


Improve typings, and documentation

Hi @bronter, here is my change as discussed!

Looks good! Thanks for doing this.


BE: Wizard: Fix nullable cluster perms check

[ ] Breaking change? (if so, please describe the impact and migration path for existing application instances)

What changes did you make? (Give an overview)
Fixes #677
Is there anything you'd like reviewers to focus on?
How Has This Been Tested? (put an "x" (case-sensitive!) next to an item)

[ ] No need to
[ ] Manually (please, describe, if necessary)
[ ] Unit checks
[ ] Integration checks
[ ] Covered by existing automation

Checklist (put an "x" (case-sensitive!) next to all the items, otherwise the build will fail)

[ ] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation (e.g. ENVIRONMENT VARIABLES)
[ ] My changes generate no new warnings (e.g. Sonar is happy)
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes
[ ] Any dependent changes have been merged

Check out Contributing and Code of Conduct
A picture of a cute animal (not mandatory but encouraged)

Unable to validate still. A cluster configures OK at container bring up time and I can modify it. Add topics etc  but i CANNOT add a  new cluster. Still get 500 errors. Attaching error, compose and RBAC config files
rbacconfig.txt
dockercompose.txt
err-nov26.txt

DEBUG [parallel-5] i.k.u.s.ClustersStatisticsScheduler: Start getting metrics for kafkaCluster: my-cluster
2024-12-04 14:08:45,281 DEBUG [parallel-8] i.k.u.s.ClustersStatisticsScheduler: Metrics updated for cluster: my-cluster
2024-12-04 14:08:47,433 ERROR [reactor-http-epoll-1] o.s.b.a.w.r.e.AbstractErrorWebExceptionHandler: [271ec9af-27]  500 Server Error for HTTP GET "/api/config"
java.lang.IllegalArgumentException: No enum constant io.kafbat.ui.model.ActionDTO.all

I have simmiliar issue. after I have enabled RBAC, permissions seems to be working but I cannot click on "configure" cluster button in dashboard, it throws this error in logs...

@HirossxD that's a separate issue we're aware of, but could you raise an issue here, please? So we don't lose a track of it


Handle the definition of self-recursive and mutually recursive types

Codecov Report
Attention: 8 lines in your changes are missing coverage. Please review.

Comparison is base (52d3987) 81.92% compared to head (354277f) 82.00%.

Files
Patch %
Lines

src/Escalier.TypeChecker/Unify.fs
69.23%
8 Missing :warning:

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #140      +/-   ##
==========================================
+ Coverage   81.92%   82.00%   +0.08%
==========================================
  Files          20       20
  Lines        6667     6697      +30
  Branches      888      896       +8
==========================================
+ Hits         5462     5492      +30
  Misses       1205     1205

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Adrianmarinwork issue #14 #16

If I missed some classes or something just tell me.
I think everything should be correct and changed!

Thanks you so much for your contribution @adrianmarinwork


Fix initializer deprecation warning for >= ember 2.1.0

Initializers now only take 1 argument (see http://emberjs.com/deprecations/v2.x/#toc_initializer-arity). This commit is the suggested approach to support versions of Ember pre and post this change

:octopus: :tiger2:

:octopus: :shipit:


chore: refactor exposed function for BiDi

Using one channel instead of three.
Bug: https://github.com/puppeteer/puppeteer/issues/11981

Looks like some test fail in Firefox

Looks like some test fail in Firefox

Looks like that test wasn't testing what it needed. We don't guarantee that exposed function calls in a preload script will resolve before navigation finishes. I've fixed the test to actually reflect what its title states.


pip install pptk doesn't work on ubuntu 18.04/kubuntu 18.04

Problem: After doing 'pip install pptk' on ubuntu/kubuntu 18.04, it doesn't work.
Diagnosis: The 'viewer' doesn't work because the libz.so.1 in site-packages/pptk/libs has some unresolved dependency issue.
Workaround:

Rename the libz.so.1 in site-packages/pptk/libs
e.g
cd ~/.local/lib/python2.7/site-packages/pptk/libs/
mv  libz.so.1  libz.so.1.old
Create a soft link from /lib/x86_64-linux-gnu/libz.so.1 to the site-packages/pptk/libs
cd ~/.local/lib/python2.7/site-packages/pptk/libs/
sudo ln -s /lib/x86_64-linux-gnu/libz.so.1

hi, I have a similar problem, view gets stuck, and no output is printed (no error or warning). The above solution didn't work either...

Doesn't work for me either on Debian Buster.
Also tried:
ln -s /lib/x86_64-linux-gnu/libz.so.1.2.11 libz.s0.1
pptk doesn't hang anymore but I get no viewer window.

Any news anyone ?
I just installed this and on 18.04 also and I have the same problem.

I'll chime in that this was needed (and fixed the problem) for me here as well, but that you obviously have to make sure you're doing it in the site-packages directory for the right version of python - many users now will be running 3.x not 2.7.

Didn’t fix it for me. Already using /lib/x86..

@emantos solution worked for me. thanks.
envs:
OS ubuntu18.04
python 3.6
turboVNC

Commenting on behalf of conda/miniconda users:
The correct path to the libz.so.1 you need to change is:
<conda-dir>/envs/<env-name>/lib/python<X>.<Y>/site-packages/pptk/libs/
Or in <conda-dir>/lib/python<X>.<Y>/site-packages/pptk/libs/  if you're running in conda root.
Took me quite a while to figure out;
I kept trying to link the libz.so.1 in <conda-dir>/lib/ and <conda-dir>/envs/<env-name>lib/ ...

this works in conda

I get the following error after following @robogast advice :
failed to create symbolic link './libz.so.1': File exists

@nihal-rao yeah you should still rename the already present libz.so.1 to something else like libz.so.1.old as OP states, otherwise the symlinking should obviously not work.

Commenting on behalf of conda/miniconda users:
The correct path to the libz.so.1 you need to change is:
<conda-dir>/envs/<env-name>/lib/python<X>.<Y>/site-packages/pptk/libs/
Or in <conda-dir>/lib/python<X>.<Y>/site-packages/pptk/libs/ if you're running in conda root.
Took me quite a while to figure out;
I kept trying to link the libz.so.1 in <conda-dir>/lib/ and <conda-dir>/envs/<env-name>lib/ ...

This works for me in Conda environment. Thank you.

I solved it in another way.
For conda users:
I modified the file in
<conda-dir>/envs/<env-name>/lib/python<X>.<Y>/site-packages/pptk/viewer/qt.conf
As follows:
[Paths]
Plugins=<conda-dir>/plugins

@emantos Thank you very much! It works for me in python3.6

Problem: After doing 'pip install pptk' on ubuntu/kubuntu 18.04, it doesn't work.
Diagnosis: The 'viewer' doesn't work because the libz.so.1 in site-packages/pptk/libs has some unresolved dependency issue.
Workaround:

Rename the libz.so.1 in site-packages/pptk/libs
e.g
cd ~/.local/lib/python2.7/site-packages/pptk/libs/
mv  libz.so.1  libz.so.1.old
Create a soft link from /lib/x86_64-linux-gnu/libz.so.1 to the site-packages/pptk/libs
cd ~/.local/lib/python2.7/site-packages/pptk/libs/
sudo ln -s /lib/x86_64-linux-gnu/libz.so.1

It works for me in python3.7 and ubuntu 20.04, Thank you!

Problem: After doing 'pip install pptk' on ubuntu/kubuntu 18.04, it doesn't work.
Diagnosis: The 'viewer' doesn't work because the libz.so.1 in site-packages/pptk/libs has some unresolved dependency issue.
Workaround:

Rename the libz.so.1 in site-packages/pptk/libs
e.g
cd ~/.local/lib/python2.7/site-packages/pptk/libs/
mv  libz.so.1  libz.so.1.old
Create a soft link from /lib/x86_64-linux-gnu/libz.so.1 to the site-packages/pptk/libs
cd ~/.local/lib/python2.7/site-packages/pptk/libs/
sudo ln -s /lib/x86_64-linux-gnu/libz.so.1

It works for me in python3.7 and ubuntu 20.04, Thank you!

I'm still running into this issue on RHEL7. I tried the symlink solution with no success. Might be worth noting that I'm doing this with X11 on a remote cluster, but that shouldn't change anything, since I'm positive the X11 part is set up on the system side. Any suggestions?

I'm also running into this problem. But I'm trying to get pptk.viewer() to send the X11 packets from a docker image to my X server running elsewhere. There are no permissions issues with the port. I've been doing this forever with matplotlib. In fact, I tested plotting just now with plt.plot([1, 2, 3, 4, 5]) and then plt.show() and it works perfectly. But pptk.viewer() doesn't. Even with the libz.so.1 fix everyone's talking about.

Thanks

Many thanks

i try it  and  python2 is ok but python3.6 do not work

Has anyone found a solution for this? I'm trying to use pptk in a docker container. I've tried creating a symlink as suggested but its not working.

I am using WSL2 with Ubuntu 20.04 LTS and after applying libz.so.1 fix, the viewer opens but shows a black/dark screen.

2. sudo ln -s /lib/x86_64-linux-gnu/libz.so.1

This solution work for me. Make sure to do it with the correct python. It is for python 2.7.  If you use another python for example python 3.6, you should adjust the instruction.

I am using WSL2 with Ubuntu 20.04 LTS and after applying libz.so.1 fix, the viewer opens but shows a black/dark screen. Can anyone help me?

I have the same problem, have you solved the problem?

@rlangefe I'm using XLaunch (VcXsrv), but the window opens and immediately closes again.


Uncaught SyntaxError: Unexpected end of JSON input

[Enter steps to reproduce:]

...
...

Atom: 1.14.3 x64
Electron: 1.3.13
OS: Mac OS X 10.12.3
Thrown From: jupyter-notebook package 0.0.9
Stack Trace
Uncaught SyntaxError: Unexpected end of JSON input
At file:///Applications/Atom.app/Contents/Resources/app.asar/static/index.html#%7B%22initialPaths%22%3A%5B%22%2FUsers%2Fblueskywalker%2Fworkspace%2Fgithub.com%2Fjunkyard%2Feval%2Fpython%22%5D%2C%22locationsToOpen%22%3A%5B%7B%22pathToOpen%22%3A%22%2FUsers%2Fblueskywalker%2Fworkspace%2Fgithub.com%2Fjunkyard%2Feval%2Fpython%22%2C%22initialLine%22%3Anull%2C%22initialColumn%22%3Anull%2C%22forceAddToWindow%22%3Afalse%7D%5D%2C%22windowInitializationScript%22%3A%22%2FApplications%2FAtom.app%2FContents%2FResources%2Fapp.asar%2Fsrc%2Finitialize-application-window.js%22%2C%22resourcePath%22%3A%22%2FApplications%2FAtom.app%2FContents%2FResources%2Fapp.asar%22%2C%22devMode%22%3Afalse%2C%22safeMode%22%3Afalse%2C%22profileStartup%22%3Afalse%2C%22clearWindowState%22%3Afalse%2C%22env%22%3A%7B%22__CF_USER_TEXT_ENCODING%22%3A%220x1F5%3A0x0%3A0x0%22%2C%22TMPDIR%22%3A%22%2Fvar%2Ffolders%2F9q%2F8rdrjdgj0n396_srr25lbn700000gn%2FT%2F%22%2C%22HOME%22%3A%22%2FUsers%2Fblueskywalker%22%2C%22SHELL%22%3A%22%2Fbin%2Fbash%22%2C%22SSH_AUTH_SOCK%22%3A%22%2Fprivate%2Ftmp%2Fcom.apple.launchd.CLvqmFMfxF%2FListeners%22%2C%22Apple_PubSub_Socket_Render%22%3A%22%2Fprivate%2Ftmp%2Fcom.apple.launchd.iFLvwVofBn%2FRender%22%2C%22DISPLAY%22%3A%22%2Fprivate%2Ftmp%2Fcom.apple.launchd.5yuBjknoLJ%2Forg.macosforge.xquartz%3A0%22%2C%22PATH%22%3A%22%2Fusr%2Fbin%3A%2Fbin%3A%2Fusr%2Fsbin%3A%2Fsbin%22%2C%22LOGNAME%22%3A%22blueskywalker%22%2C%22XPC_SERVICE_NAME%22%3A%220%22%2C%22COMMAND_MODE%22%3A%22unix2003%22%2C%22USER%22%3A%22blueskywalker%22%2C%22XPC_FLAGS%22%3A%220x0%22%2C%22GOOGLE_API_KEY%22%3A%22AIzaSyAQfxPJiounkhOjODEO5ZieffeBv6yft2Q%22%2C%22ATOM_HOME%22%3A%22%2FUsers%2Fblueskywalker%2F.atom%22%7D%2C%22appVersion%22%3A%221.14.3%22%2C%22atomHome%22%3A%22%2FUsers%2Fblueskywalker%2F.atom%22%2C%22shellLoadTime%22%3A671%7D:1

SyntaxError: Unexpected end of JSON input
    at Object.parse (native)
    at NotebookEditor.parseNotebookFile (/packages/jupyter-notebook/lib/notebook-editor.js:243:19)
    at NotebookEditor.loadNotebookFile (/packages/jupyter-notebook/lib/notebook-editor.js:217:29)
    at /packages/jupyter-notebook/lib/notebook-editor.js:34:12)
    at openURI (/packages/jupyter-notebook/lib/main.js:90:80)
    at Workspace.module.exports.Workspace.openURIInPane (/app.asar/src/workspace.js:501:22)
    at Workspace.module.exports.Workspace.open (/app.asar/src/workspace.js:436:19)
    at TreeView.module.exports.TreeView.fileViewEntryClicked (/app.asar/node_modules/tree-view/lib/tree-view.js:486:40)
    at TreeView.module.exports.TreeView.entryClicked (/app.asar/node_modules/tree-view/lib/tree-view.js:474:14)
    at /app.asar/node_modules/tree-view/lib/tree-view.js:190:26)
    at /app.asar/node_modules/jquery/dist/jquery.js:4435:9)
    at /app.asar/node_modules/jquery/dist/jquery.js:4121:28)

Commands

Non-Core Packages
aligner-python 1.0.1
atom-beautify 0.29.17
atom-python-run 0.7.3
autocomplete-haskell 0.7.2
autocomplete-json 5.2.0
autocomplete-python 1.8.57
column-select 0.2.0
environment 1.3.1
git-plus 7.3.2
go-debug 1.0.4
go-plus 5.1.1
go-signature-statusbar 1.2.0
haskell-ghc-mod 1.19.7
hyperclick 0.0.40
jupyter-notebook 0.0.9
kite 0.10.5
language-groovy 0.6.0
language-haskell 1.12.1
language-scala 1.1.8
linter 1.11.23
linter-rubocop 0.5.3
merge-conflicts 1.4.4
node-debugger 1.10.1
platformio-ide-terminal 2.3.0
python-debugger 0.2.0
python-tools 0.6.9
scala-worksheet-plus 0.4.2
script 3.14.1

This repo is not being actively maintained 🙁 In the meantime, I suggest that you look at nteract, which is a Jupyter notebook client built using Electron (the same native app shell that is used by Atom), React, Redux, RxJS, etc. and it has a lot of momentum. It goes without saying that you also have Jupyter Notebook and its WIP successor JupyterLab.
Having said that, nteract is currently extracting its many components into separate packages which will allow them to be reused and assembled to create new apps. When I have the time, I would like to use them to completely refactor this project.

@gnestor I think this package may be necessary for those who work both on notebooks and libraries. nteract does not yet support python code editing (but I think this is out its scope), while atom provides more packages in this case.
Having two applications (atom and nteract) running for this use case would be difficult to handle (considering I would also need a terminal).

@fbrundu Both nteract and this package currently launch kernels themselves, so you don't need to start the Jupyter notebook server in order to use them. Additionally, the idea is to port the nteract notebook packages to this package and in doing, not maintain 2 totally separate code bases, but 2 different implementations of the same code base.


Change test names to be easier to understand

I had some problems when doing the exercice because of the DST. I think more explicit method's name should help.
Thanks

This works for me. Thanks!


remove outdated & unnecessary default arg

Itty bitty one-line change, following up some more on PR #57.

This is so small that I'm gonna merge this myself to avoid wasting a reviewer's time.


Update branch dashing to support Dashing only

This PR updates branch dashing to make it buildable only with the Dashing release.
The PR removes all "feature flags" from static_config.hpp, including RMW_CONNEXT_RELEASE and any code meant to support later releases.
The code was changed assuming the following "feature configuration":

Feature
Value

RMW_CONNEXT_RELEASE
RMW_CONNEXT_RELEASE_DASHING

RMW_CONNEXT_HAVE_PKG_RMW_DDS_COMMON
0

RMW_CONNEXT_HAVE_SCOPE_EXIT
0

RMW_CONNEXT_HAVE_GET_DOMAIN
0

RMW_CONNEXT_HAVE_OPTIONS
0

RMW_CONNEXT_HAVE_OPTIONS_PUBSUB
0

RMW_CONNEXT_HAVE_INCOMPATIBLE_QOS
0

RMW_CONNEXT_HAVE_INCOMPATIBLE_QOS_EVENT
0

RMW_CONNEXT_HAVE_LIFESPAN_QOS
0

RMW_CONNEXT_HAVE_MESSAGE_LOST
0

RMW_CONNEXT_HAVE_SERVICE_INFO
0

RMW_CONNEXT_HAVE_LOCALHOST_ONLY
0

RMW_CONNEXT_HAVE_TAKE_SEQ
0

RMW_CONNEXT_HAVE_SECURITY
0

RMW_CONNEXT_HAVE_COMMON_MUTEX
0

RMW_CONNEXT_HAVE_LOAN_MESSAGE
0

RMW_CONNEXT_HAVE_MESSAGE_INFO_TS
0

RMW_CONNEXT_HAVE_GET_INFO_BY_TOPIC
0

RMW_CONNEXT_HAVE_QOS_PROFILE_API
0

RMW_CONNEXT_HAVE_TIME_UTILS
0

Note to reviewers: It would be great to review these changes but they are somewhat trivial. I'm creating this PR mainly to keep track of them for future reference.

CI jobs to validate the changes (note: first time running unit tests for Dashing 🤞🏼):

ci_linux:

Backported rmw_dds_common from 79af623


Create a new capable-types crate

Create mc-sgx-capable-types
Expose mc-sgx-core-types::{Error, Result}

Current dependencies on/for this PR:

main

PR #94

PR #95

PR #96

PR #97

PR #98

PR #99

PR #101   👈
PR #100

This comment was auto-generated by Graphite.


NPM Scripts not working with new persistent terminal

VS Code Version: 1.54.1
OS Version: macOS 11.2.1

Steps to Reproduce:

Open a very basic NPM project that has a script. For example: a script that starts a web server.
Run the script
Reload the window and you will see the process is terminated.

Does this issue occur when all extensions are disabled?: Yes

I think this is an issue because the NPM Scripts are running as a Task, and tasks are terminated when reloading the window. If I open a terminal and manually type in npm run serve, it is persisted. But if I run it from the NPM Scripts view, it terminates on reload.
Clicking the start button in this view is the issue. This might be an issue with all Tasks and not just terminal.

/duplicate https://github.com/microsoft/vscode/issues/117408


Visually appears to pass layout specs, but failing automation

Visually appears to pass layout specs, but failing automation
https://forum.freecodecamp.org/t/navbar-appears-to-pass-specs-but-not-automation/226396
Tell us about your browser and operating system

Browser Name: Chrome
Browser Version: latest
Operating System: Windows 10

https://codepen.io/TurtleWolf/pen/QVrPvo

passing now


Added callback for getting breadcrumbs from navigation

I'm working on adding tracing and performance analytics to the app. Right now Odyssey provides one way to monitor transactions. RootController.currentScreen outputs updates related to shown and removed screens. Unfortunately, this flow doesn't emit stream of events which correspond to screen changes one-to-one.
This PR adds new callback which can be used by the app to monitor screen changes. It filters some event sources and helps with nested navigation (e.g. bottom navigation tabs switching emits both tab name and owner screen name).
Unfortunately, this doesn't cover multiple layers of nesting (like bottom navigation where the screen also has tabs). Also, I'm not 100% sure on the format of the data.
Could you please check the general direction of this change? Are there any caveats I should know, or maybe you have some different takes on solving this?

Added in release 1.3


GH-2195: Fix Fix No Seek Retries with Pause

Related to https://github.com/spring-projects/spring-kafka/issues/2195
Similar to the recent fix when the first partition is paused, we should
not continue to process the remaining records if the container itself
was paused during the poll after an error occurred with seekAfterError=false.
cherry-pick to 2.9.x

Do not merge; found another bug.

... and cherry-picked to 2.9.x


IS-83 Added check for mismatching SignServiceID is SignRequest

Closes #83

I have built and verified this fix in my test application.


Sort URL query items

I have an issue with snapshotting an URLRequest that contains multiple query items. When I'm building the URLRequest I'm using a [String: Any] dictionary for queries which results in random order of query items in the final URLRequest.

@mihai8804858 Looks like the curl tests are failing because they weren't similarly sorted. I suggest either adding sorting to that snapshot strategy, or removing the curl tests.

@mbrandonw Added back query sorting for curl.


THC SELECT

Adds a somewhat incomplete SELECT bloq for the molecular THC hamiltonian (See #386 for deficiencies).
My plan is to provide primitive bloqs this week for the molecular 2nd quantized Hamiltonians and I will follow up with more detailed implementations in time.

#350 should be merged first

it would be good to generate the notebooks for this too.

It's probably better to merge this and add the notebook in a follow-on PR for forward-momentum purposes


Mismatch in case when using anchors

First of all thanks for the good work!
Maybe I'm doing it wrong, but my anchors don't work:
I'm simply using the advanced extensions to generate HTML from md.
var pipeline = new MarkdownPipelineBuilder().UseAdvancedExtensions().Build();
What happens is, that in the link the name is preserved, but in the id the name is lower case.
As a result anchors don't work.
Example:
[Formatting](#Formatting)
[...]
# Formatting

Generates
Formatting
[...]

Formatting

Thanks!

There seems to be a consensus among different Markdown parsers as to how the heading id is generated. In other words, making the identifier lower-case is by design.
The solution is to use the lower-case identifier when linking to the heading.
[Formatting](#formatting)

# Formatting

Yeah. there are several rules, including replacing space by - or collapsing non alpha-numeric characters...etc.

Default rule is following what I think Pandoc is doing.
Gfm rule

So basically by design. Not sure it is worth adding a different rule, while these links would not work at all on GitHub for example (or even Gitlab), so better to use the common accepted rule
Closing this issue. If you really want this feature, you can try a PR to bring it to the AutoIdentifier extension.

Thanks for the quick reply!
As this is not really usable, I'll hope I get people to use this format for anchors:
`Formatting
[...]
 Formatting`
This works and you don't need to guess the correct text to use for the link, esp. thinking of more complicated headings spaces, numbers, special characters etc.

You can also avoid explicit anchors in that case:
[Formatting]

# Formatting

Or in this documentation for example the entire table of content was generated using the mdtoc tool inside markdig repo. It was really fine for this case.
Otherwise, if you want an absolute control on the anchors, yes, there is no other way than using direct inline HTML


Yoshi engine charts to Psych engine charts

What is your question?
Anyone know how to port a Yoshi engine chart to a psych engine port

not possible + why

What is your question?
Anyone know how to port a Yoshi engine chart to a psych engine port

theres no option but to rechart it + why

I'm wondering this too.


Icons on open editor explorer get squashed for ignored files

VSCode Version: Code - Insiders 1.18.0-insider (65c08338e4bece35fb53f5a1cdf56d30b7706157, 2017-10-20T14:46:19.849Z)
OS Version: Darwin x64 16.7.0

@jrieken did you do some wrong css magic with the label. Feel free to forward back to me

I made it use flex-layout, so yeah maybe

Maybe try adding to the icon
flex-shrink: 0
or
min-width: fit-content;

This is fixed with latest changes


[#5318][#5311] improvement(web): Add jdbc-driver properties for Paimo…

…n JDBC, fix(web): fix update pamon catalog

What changes were proposed in this pull request?

Add jdbc-driver properties for Paimon JDBC
fix update pamon catalog issue

Why are the changes needed?
N/A
Fix: #5318, #5311
Does this PR introduce any user-facing change?
N/A
How was this patch tested?
manually

@LauraXia123 can you please fix the PR title?

@FANNG1 please help to review it.

@LauraXia123 could you post a picture to show the paimon jdbc-driver property?

@LauraXia123 could you post a picture to show the paimon jdbc-driver property?

updated


rio secret add --docker not working

Describe the bug
A clear and concise description of what the bug is.
Cannot add docker secret
To Reproduce
Steps to reproduce the behavior:
1.
rio secret add --docker
FATA[0011] Secret "dockerconfig" is invalid: [data[%s][username]: Required value, data[%s][password]: Required value]
Expected behavior
Kubernetes version & type (GKE, on-prem): kubectl version
lient Version: version.Info{Major:"1", Minor:"14+", GitVersion:"v1.14.7-eks-1861c5", GitCommit:"1861c597586f84f1498a9f2151c78d8a6bf47814", GitTreeState:"clean", BuildDate:"2019-09-24T22:12:08Z", GoVersion:"go1.12.9", Compiler:"gc", Platform:"linux/amd64"}
Server Version: version.Info{Major:"1", Minor:"14+", GitVersion:"v1.14.6-eks-5047ed", GitCommit:"5047edce664593832e9b889e447ac75ab104f527", GitTreeState:"clean", BuildDate:"2019-08-21T22:32:40Z", GoVersion:"go1.12.9", Compiler:"gc", Platform:"linux/amd64"}

Type:
Rio version: rio info
Rio Version: v0.6.0-alpha.4 (969baf29)
Rio CLI Version: v0.6.0-alpha.4 (969baf29)

Additional context
rio systemlogs
output:

Fixed in https://github.com/rancher/rio/pulls

available to test in v0.6.0-alpha5.

I was able to recreate this on alpha4 and verified it is fixed in alpha5.


Upgrade to Java 11

[x] Upgrade Java version in pom.xml
[ ] Upgrade Java version in GitHub workflows

Is this issue still open. can I work on this?

I am available to work on it

I am available to work on it

Okkayy, thank you. Inform if I can work on this

Is this issue still open. can I work on this?

@SanjayRam07 @pedinil Yes, you are welcome to work on this issue 🙂
I invited you both as members of the GitHub organization (check your e-mail) so that you get access to assign yourselves to issues.

@SanjayRam07 Thank you for coding the #281 pull request 🙂
Can you please also upgrade the Java version used in the workflow files at maven-build.yml and maven-release.yml?

@SanjayRam07 Thank you for coding the #281 pull request 🙂
Can you please also upgrade the Java version used in the workflow files at maven-build.yml and maven-release.yml?

Yeah, I need to update Java version. I'll work on this and run the workflow.

@SanjayRam07 Thank you for coding the #281 pull request 🙂
Can you please also upgrade the Java version used in the workflow files at maven-build.yml and maven-release.yml?

@SanjayRam07 Thank you for coding the #281 pull request 🙂
Can you please also upgrade the Java version used in the workflow files at maven-build.yml and maven-release.yml?

I have updated, kindly review it to merge it into main branch

I have updated, kindly review it to merge it into main branch

Reviewed, looks good 👍🏽


Path "tools /kafka" contains space

Why nobody fix this, I cannot git clone because of the space!
error: invalid path 'tools /kafka/README.md'
fatal: unable to checkout working tree


Fix image titles in the expanded image modal

A recent refactor in ExpandedImage moved the conditional around and introduced what looks like a bug:
diff --git a/catalogue/webapp/components/ExpandedImage/ExpandedImage.tsx b/catalogue/webapp/components/ExpandedImage/ExpandedImage.tsx
index 48ca44a89..51b990cf1 100644
--- a/catalogue/webapp/components/ExpandedImage/ExpandedImage.tsx
+++ b/catalogue/webapp/components/ExpandedImage/ExpandedImage.tsx
@@ -207,12 +207,12 @@ const ExpandedImage: FunctionComponent<Props> = ({
         </ImageWrapper>
       )}
       <InfoWrapper>
-        <Space v={{ size: 'l', properties: ['margin-bottom'] }}>
-          <h2
-            className={`${font('intb', 3)} no-margin`}
-            dangerouslySetInnerHTML={{ __html: displayTitle }}
-          />
-          {displayContributor && (
+        {displayContributor && (
+          <Space v={{ size: 'l', properties: ['margin-bottom'] }}>
+            <h2
+              className={`${font('intb', 3)} no-margin`}
+              dangerouslySetInnerHTML={{ __html: displayTitle }}
+            />
             <Space
               as="h3"
               v={{ size: 's', properties: ['margin-top'] }}
@@ -220,8 +220,8 @@ const ExpandedImage: FunctionComponent<Props> = ({
             >
               {displayContributor}
             </Space>
-          )}
-        </Space>
+          </Space>
+        )}
         {license && (
           <Space
             className={font('intr', 5)}

By moving the conditional on displayContributor up a level, we no longer display titles on images which don't have a displayContributor; this seems wrong.
This patch:

Adds a couple of Playwright tests for title/contributor on the expanded image modal. These will catch a similar regression in future.
Fix the ExpandedImage component so it displays titles if there are no contributors. I did consider testing this component directly, but you have to mock the fetch() that goes to the catalogue API, and that was more effort than I was willing to spend.
Add a link to the images API from the API toolbar – I was initially wondering if maybe this was a data issue.

One thing is I remember I did the change as part of a fix for pa11y error (h2 was empty), does it seem OK now?

Ah, I didn't think to check pa11y. Let me fiddle.


vkCmdClearAttachments rect validation errors when CB->createInfo.level != VK_COMMAND_BUFFER_LEVEL_PRIMARY

There is a regression when validating vkCmdClearAttachment rects and the command buffer node isn't created with VK_COMMAND_BUFFER_LEVEL_PRIMARY.
Most likely, you will receive the following error: "vkCmdClearAttachments(): The area defined by pRects[%d] is not contained in the area of the current render pass instance.",
The rects pointer just gets passed to the lambda and won't necessarily contain the rectangle data anymore when the validation occurs later on. The rectangle needs to be copied by value to the lambda in order to make sure the right rectangle gets validated.
The change that introduced the issue is here:
https://github.com/KhronosGroup/Vulkan-LoaderAndValidationLayers/commit/185f5e0f025c5e2c0905f5c180f6d429bda71018

Thank you for fixing the issue so quickly.


Code + Markdown weird design

Refs: #93742
I find the + Code + Markdown separator design a bit weird.
We do not use it anywhere else in vscode and it is not accessible - no way to focus into it.
I would remove it until other parts of the notebook ux are polished.
And this could ideally be done via context menus

Let's look into this issue next iteration.

We now allow tab into the toolbar with c22cc2b3b6cf95f9d8f4ff816f6ef947c1303ec5

This has been changed to be framed and thereby looks more like buttons


Host our api docs (on GitHub pages)

Host our docs on GitHub pages by moving them from /public/docs to /docs

Resolved by #78


Geometry2D.clip_polygons() Geometry2D.merge_polygons() returns [(0,0)]

Tested versions

Tested on: 4.2,stable  4.2.1

System information
windows 11 - Godot 4.2x
Issue description
Maybe there is something I need to the packedVector2Arrays before passing them as arguments for clip_polygon() or merge_polygon() but there is no documentation about it.
Steps to reproduce

create a scene, add two polygon2D or collisionpolygon2D nodes, create polygons on the editor that overlap.
on the root script:

func  _ready():
	var _poly1 = $CollisionPolygon2D
	var _poly2 = $CollisionPolygon2D2
	var _new_poly: Polygon2D = Polygon2D.new()
	var clipped_poly: PackedVector2Array

	var _poly1_vec2array =  _poly1.polygon #you can use .get_polygon() result is the same
	print(poly1_vec2array) # the polygons are assigned correctly
	var _poly2_vec2array = _poly2.polygon
	print(poly2_vec2array) # the polygons are assigned correctly

	clipped_poly = Geometry2D.clip_polygons(poly1_vec2array,poly2_vec2array)

	print_debug(clipped_poly) # returns a single point on PackedVector2Array = [(0,0]]

Minimal reproduction project (MRP)
Tests.zip

Geometry2D.clip_polygons() returns an array of polygons (Array[PackedVector2]), since the result can be in multiple pieces.
I'm little perplexed how the casting of the Array[PackedVector2] to Array works, as it silently eats the inner vector2 arrays and replaces them with zero-vector2:s:
var array: Array[PackedVector2Array] = [PackedVector2Array([Vector2.ONE, Vector2.ZERO]), PackedVector2Array([Vector2.ONE, Vector2.ZERO])]
print(array) # prints "[(0, 0), (0, 0)]"; No warnings.

Having this same issue. Windows 11 4.2.1 stable

I tested all the way back to 4.0.4 and couldn't get it to work

This example appears to be working
	var arr1:= PackedVector2Array([Vector2(0,0),Vector2(1,0),Vector2(1,1)]); 	var arr2:= PackedVector2Array([Vector2(0,0),Vector2(1,0),Vector2(0,1)]); 	var result:= Geometry2D.clip_polygons(arr1, arr2); 	print(arr1); 	print(arr2); 	print(result);

Ran a test with the exact same shapes, first created with polygons, second created programmatically like in the code example above.
When using polygons
[(0, 0), (100, 0), (100, 100)]
[(0, 0), (100, 0), (0, 100)]
[(0, 0)]

When not using polygons
[(0, 0), (100, 0), (100, 100)]
[(0, 0), (100, 0), (0, 100)]
[[(100, 100), (50, 50), (100, 0)]]

I figured out a workaround. I think something it's something to do with the variable's type.
# Clip poly1 against a 0 area shape fixes the type for some reason.
poly1 = Geometry2D.clip_polygons(_poly1, [Vector2(0,0),Vector2(0,0),Vector2(0,0)])[0];

Geometry2D.clip_polygons() returns an array of polygons (Array[PackedVector2]), since the result can be in multiple pieces.
I'm little perplexed how the casting of the Array[PackedVector2] to Array works, as it silently eats the inner vector2 arrays and replaces them with zero-vector2:s:
var array: Array[PackedVector2Array] = [PackedVector2Array([Vector2.ONE, Vector2.ZERO]), PackedVector2Array([Vector2.ONE, Vector2.ZERO])]
print(array) # prints "[(0, 0), (0, 0)]"; No warnings.

This code works perfectly. array has the correct type and print(array) gives [[(1, 1), (0, 0)], [(1, 1), (0, 0)]] which is perfectly fine.
On the other hand static typing the variable array has just PackedVector2Array doesn't work (prints gives [(0, 0), (0, 0)])
That's exactly what OP issue is.

Tested versions

Tested on: 4.2,stable  4.2.1

System information
windows 11 - Godot 4.2x
Issue description
Maybe there is something I need to the packedVector2Arrays before passing them as arguments for clip_polygon() or merge_polygon() but there is no documentation about it.
Steps to reproduce

create a scene, add two polygon2D or collisionpolygon2D nodes, create polygons on the editor that overlap.
on the root script:

func  _ready():
	var _poly1 = $CollisionPolygon2D
	var _poly2 = $CollisionPolygon2D2
	var _new_poly: Polygon2D = Polygon2D.new()
	var clipped_poly: PackedVector2Array

	var _poly1_vec2array =  _poly1.polygon #you can use .get_polygon() result is the same
	print(poly1_vec2array) # the polygons are assigned correctly
	var _poly2_vec2array = _poly2.polygon
	print(poly2_vec2array) # the polygons are assigned correctly

	clipped_poly = Geometry2D.clip_polygons(poly1_vec2array,poly2_vec2array)

	print_debug(clipped_poly) # returns a single point on PackedVector2Array = [(0,0]]

Minimal reproduction project (MRP)
Tests.zip

That's just a static typing code error, not an issue with Godot (which could maybe give a warning though.)
The corrected working code is
func _ready():
	var _poly1 = $CollisionPolygon2D
	var _poly2 = $CollisionPolygon2D2
	var _new_poly: Polygon2D = Polygon2D.new()
	var clipped_poly: Array[PackedVector2Array]

	var _poly1_vec2array =  _poly1.polygon #you can use .get_polygon() result is the same
	print(_poly1_vec2array) # the polygons are assigned correctly
	var _poly2_vec2array = _poly2.polygon
	print(_poly2_vec2array) # the polygons are assigned correctly

	clipped_poly = Geometry2D.clip_polygons(_poly1_vec2array, _poly2_vec2array)

	print_debug(clipped_poly) # returns an array of none ZERO PackedVector2Array as soon as polygon cross

Please note the change made on clipped_poly variable type to match the return type of the clip function.

Was having the same issue and it ended up being the same typing error. A warning would be really nice


CAMEL-9640 - Query string gets decoded when bridging from netty*-http to netty*-http

Please review and merge this PR. Thanks!
https://issues.jboss.org/browse/ENTESB-4737

Thanks it has been merged. Can you close

Thanks Claus!  Closing this PR, too.


Incorrect Examples

This page provides details on the Get-AdvancedThreatProtectionDocumentDetail cmdlet while the examples shown are for the Get-AdvancedThreatProtectionTrafficDetail cmdlet.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: eef7cb2b-d541-71c7-f9e1-8db0a2dc0622
Version Independent ID: 4b33745c-d0b6-2cda-72c5-1398777356f8
Content: Get-AdvancedThreatProtectionDocumentDetail (exchange)
Content Source: exchange/exchange-ps/exchange/advanced-threat-protection/Get-AdvancedThreatProtectionDocumentDetail.md
Service: exchange-powershell
GitHub Login: @chrisda
Microsoft Alias: chrisda

@officedocsbot assign @yogkumgit

Hello @eric-lavalley
Thanks for noting this, created a pull request to fix the example.
Thank you

@chrisda Please merge the PR #3841

@get-itips  Thank you very much for the contribution and updating the documentation with PR. @eric-lavalley Hope this update is helpful for you. Thanks for taking out some time to open the issue. Appreciate and encourage you to do the same in future also.

@officedocsbot close


Remove unrecognized '%p' escape sequence from $PROMPT

@robbyrussell et al.
In recent versions of zsh (v5.x.x and up, AFAICT), the %p escape sequence is no longer supported in $PROMPT.
It appears to have been a date/time placeholder in earlier versions of zsh:
%p  The 'precise' time of day in 12-hour AM/PM format, with seconds.

... but it is no longer recognized, and as such is causing some superfluous spacing in the rendered $PROMPT, which disappears once %p has been removed:

I've removed %p from themes/robbyrussell.zsh-theme only for now, but can also remove it from the other themes in this repo if that would facilitate the acceptance of this pull request :smile:
Thanks!

Addendum - instead of removing %p from the theme/prompt, I just realized that I could have replaced it with a %D{strftime_compatible_format_string} escape sequence to achieve a similar result:
%D{string}  string is formatted using the `strftime` function. See man page strftime(3) for more details.

Something that comes close to the original %p behaviour appears to be:
PROMPT="%D{%L:%M:%S %p} "

(although confusingly the %p in this prompt is different from the one removed in this pull request)

I don't know that %p has ever been supported in zsh. It's a tcsh prompt sequence, and that descriptive text you quote seems to come from the tcsh docs. (E.g. do man tcsh and search for %p.) Do you remember it being supported in the past? I took a look at the zsh ChangeLog and prompt.yo history and don't see any mentions of it.

👍


when changing to signing mode without signer, when no signer is active send disconnect message to the dapp

currently we just reply with 0 accounts, while we should disconnect from app if there's no accounts available

the current behavior seems correct


clarify pool name being unique

Changes
Working on the prototype for DB Metrics, the recommendation for using just host:port as a fallback for pool name was not enough to identify a pool, so this PR adds example of how to make the name more unique.
Merge requirement checklist

[x] CONTRIBUTING.md guidelines followed.
[x] Change log entry added, according to the guidelines in When to add a changelog entry.

If your PR does not need a change log, start the PR title with [chore]

cc @open-telemetry/semconv-db-approvers


UX for activating/deactivating programs

[ ] Programs are active annually and they get deactivated at the end of the year. The TADA programs list only shows active programs. We need to figure out how to deactivate programs from the UI.

[ ] Create program dialog shows an "Active/Inactive" option right now. If all programs are active by default, we shouldn't show this? Or maybe we create a program in advance and activate it later? What's the use case?

[ ] Based on above, we need to figure out whether the edit dialog shows a deactivate button or maybe in the program details box or somewhere.

@meghaklp , please comment when you get some time to ponder.

I've indicated on the mock up, that we add a button alongside Edit, delete I can style the buttons later https://raw.githubusercontent.com/klpdotorg/tada_ui/master/workflow_mockups/Admin_ManagePrograms.jpg

the workflow mock up does not have status. - https://raw.githubusercontent.com/klpdotorg/tada_ui/master/workflow_mockups/Admin_AddProgram.jpg
by default a new program created should be active

Edit need not show status, as we are controlling status alongside the edit button.

Activating a deactivated program/assessment is an enhancement we can look at later.


Track Preferences/Notices Served Received At & New Redis Queue for Processing

Partially Closes #PROD-2099
❗ Required for https://github.com/ethyca/fidesplus/pull/1440
❗ Contains db migration; bump downrev before migrating
Description Of Changes
Fides-side changes for moving saving Privacy Preferences and Notices Served from the main fides webserver to the worker
Code Changes

Add optional "received_at" to Privacy Preference History and Served Notice History.

We will be processing these in a celery worker instead of on the main fides webserver so there may be delays between when we receive the request and when Fides actually persists to the database.  Fidesplus will generate "received_at" when the request is received and add that data to the request body.

Add a separate queue for processing privacy preferences and notices served.
Add the number of tasks in the (redis) queue to the worker health check. Worker must be running and celery task_always_enabled set to False to see values

Steps to Confirm

[ ] Detailed steps plus-side.  https://github.com/ethyca/fidesplus/pull/1440
[ ] The main step to check over here is the new worker health check items that reveal the number of items in the redis queues!

Pre-Merge Checklist

[ ] All CI Pipelines Succeeded
Documentation:

[ ] documentation complete, PR opened in fidesdocs
[ ] documentation issue created in fidesdocs
[ ] if there are any new client scopes created as part of the pull request, remember to update public-facing documentation that references our scope registry

[ ] Issue Requirements are Met
[ ] Relevant Follow-Up Issues Created
[ ] Update CHANGELOG.md
[ ] For API changes, the Postman collection has been updated
If there are any database migrations:

[ ] Ensure that your downrev is up to date with the latest revision on main
[ ] Ensure that your downgrade() migration is correct and works

[ ] If a downgrade migration is not possible for this change, please call this out in the PR description!

Thank you for your review @adamsachs!


Merge pull request #707 from earthlab-education/main

Getting updates

Hopefully actually updating this time....


problem with static files

Hi,
I have a code:
@font-face {
  font-family: icomoon;
  src: url('/fonts/icomoon/icomoon.woff2') format('woff2');

  font-weight: normal;
  font-style: normal;
}

After I updated Nuxt from 0.10.6 to rc5 I got an error:(before update it works)
 in ./node_modules/css-loader?{"minimize":true,"importLoaders":1,"sourceMap":true,"root":"~","alias":{"/static":"D://Projects//Vue//***//src//static","/assets":"D://Projects//Vue//***//src//assets"}}!./node_modules/postcss-loader/lib?{"sourceMap":true,"plugins":[null,null,{"version":"6.0.9","plugins":[null,null,null,null,null,null,null,null,null,null,null,null,null,null,null,null,null,null,null,null,null,null,null,null,null,null,null,null],"postcssPlugin":"postcss-cssnext","postcssVersion":"6.0.9"}]}!./node_modules/sass-loader/lib/loader.js?{"sourceMap":true}!./src/css/main.scss
Module not found: Error: Can't resolve 'fonts/icomoon/icomoon.woff2' in 'D:\Projects\Vue\Smart Landing\smart-landing-client\src\css'
 @ ./node_modules/css-loader?{"minimize":true,"importLoaders":1,"sourceMap":true,"root":"~","alias":{"/static":"D://Projects//Vue//***//src//static","/assets":"D://Projects//Vue//***//src//assets"}}!./node_modules/postcss-loader/lib?{"sourceMap":true,"plugins":[null,null,{"version":"6.0.9","plugins":[null,null,null,null,null,null,null,null,null,null,null,null,null,null,null,null,null,null,null,null,null,null,null,null,null,null,null,null],"postcssPlugin":"postcss-cssnext","postcssVersion":"6.0.9"}]}!./node_modules/sass-loader/lib/loader.js?{"sourceMap":true}!./src/css/main.scss 6:140737-140775
 @ ./src/css/main.scss
 @ ./node_modules/babel-loader/lib?{"presets":["vue-app","stage-0","es2015"],"plugins":["transform-decorators-legacy","transform-class-properties"],"babelrc":false,"cacheDirectory":true}!./node_modules/vue-loader/lib/selector.js?type=script&index=0!./.nuxt/App.vue
 @ ./.nuxt/App.vue
 @ ./.nuxt/index.js
 @ ./.nuxt/client.js
 @ multi webpack-hot-middleware/client?name=client&reload=true ./.nuxt/client.js

Hi. This is because rc5 tries to correctly load and hash font assets. If not is inside assets, please use '~/assets/fonts/..` instead.

@pi0 thank you for your answer, but the fonts are placing in static/, and ~/static/fonts/.. doesn't work

Even if inside ~/assets it doesn't work if there is a space inside font file name (i.e. Averta Bold.otf)

Hi @krasevych
Indeed it's because of css-loaders aliases, I'm looking at it.

I updated the css-loader to handle aliases starting with /, let's hope it could be merged pretty fast!
See https://github.com/webpack-contrib/css-loader/pull/597

Any update on this ?  I have same problem and can't use rc5 now

Fixed with rc7, see https://github.com/nuxt/nuxt.js/issues/1453#issuecomment-325643322


.notebook file being renamed as a .zip file

Is there any way to work around this? Your plugin works great for fixing some weird upload issues with specific .ppt files, but when the plugin is active all .notebook files become .zips.
VALIDATION:
  Naive Name: 026-Badinerie-JS-Bach.notebook
  Naive Extension: notebook
  Naive Type: application/x-smarttech-notebook
  Magic Type: application/zip
  Best Type: application/zip

FINAL:
  Name: 026-Badinerie-JS-Bach.zip
  Extension: zip
  Type: application/zip
  Code: 107

SYSTEM:
  Kernel: Linux downloads 4.15.0-124-generic #127-Ubuntu SMP Fri Nov 6 10:54:43 UTC 2020 x86_64
  PHP: 7.3.24-3+ubuntu18.04.1+deb.sury.org+1
  Modules: Core; PDO; Phar; Reflection; SPL; SimpleXML; Zend OPcache; bcmath; calendar; cgi-fcgi; ctype; curl; date; dom; exif; fileinfo; filter; ftp; gd; gettext; hash; iconv; igbinary; imagick; json; libxml; mbstring; mysqli; mysqlnd; openssl; pcre; pdo_mysql; posix; readline; redis; session; shmop; soap; sockets; sodium; standard; sysvmsg; sysvsem; sysvshm; tokenizer; wddx; xml; xmlreader; xmlrpc; xmlwriter; xsl; zip; zlib
  WordPress: 5.7
  Plugins: acf [5.9.5]; amazon-s3-and-cloudfront [2.5.4]; backupbuddy [<IP_ADDRESS>]; blob-mimes [1.2.4]; disable-gutenberg [2.4]; elastic-email-sender [1.1.35]; folders [2.6.8]; gravityforms [2.4.23]; rocket [3.8.7]; wordfence [7.4.14]; wordpress-seo [16.0.2]; wp-help [1.7.0]; wp-sitemap-page [1.6.4]
  Theme: pl-theme []

Thanks for reporting, @stuininga-pl!
I just pushed a workaround that should improve .notebook support for you. Once your site recognizes the update, would you mind giving Lord of the Files 1.2.6 a shot and letting me know if you're able to upload those files (without them getting renamed) now?
I'll leave the issue open in the meantime just in case.

Hey @joshstoik1, thanks for that speedy reply! I just updated the plugin and reattempted the upload and it uploaded perfectly.
Thanks so much for your help!


fix(packages): Fix trust-dns-resolver version

So, for the moment I've fixed the version of trust-dns-resolver to the one we were using. There are some breaking changes so I think it would be wise for us to wait until the next stable release before upgrading.
@imsnif this will require publishing to crates.io. I should have used the "=" syntax given that we were relying on an alpha version, my apologies!
Fixes #24

Ah, cool. Good to know. So this behaviour (ignoring Cargo.lock) only happens with alpha versions?

Nope, I think this happens always, but even without a lock file, if I'm not mistaken, using the = will prevent cargo from using a newly available semver compatible version.

yeah, but alas - will not save us with transitive deps. There was an issue about this in cargo - I can't find it now. I think they said it should be solved, but I dunno. Might find some time to look into this next time this happens. :)


fix: Remove CVE-2020-36632 vulnerability

#minor
Description
This PR updates the version of the package mocha to ^10.4.0 and avoids the CVE-2020-36632 vulnerability with flat.
Specific Changes

Updated  mocha to ^10.4.0 in every library.

Testing
The following image shows the flat version installed after the update.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.4%) to 84.075%

Totals

Change from base Build<PHONE_NUMBER>:
-0.4%

Covered Lines:
20343

Relevant Lines:
22900

💛  - Coveralls

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 84.431%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
20425

Relevant Lines:
22900

💛  - Coveralls

Promoted /4687


Checkout error in MS Edge: Unable to get property 'props' of undefined or null reference

Issue Description
When trying to checkout with MS Edge, nothig happens when you click save on the adress form.
This happens both in the profile page and during checkout.
Console throws:

Unable to get property 'props' of undefined or null reference

Following the linked code in that error leads to this:
    _defineProperty(this, "onAdd", function (address) {
      let validateAddress = arguments.length > 1 && arguments[1] !== undefined ? arguments[1] : true;
      const {
        addAddress,
        onError,
        updateAddress
      } = _this.props; // if edit address is in the address book form

Didn't investigate further yet.
Steps to Reproduce

Add item to cart
Go to checkout
Enter Adress data
Press save and observe how the adress is not saved and the checkout workflow doesn't continue.
open console, find the error stated above.

Possible Solution
Missing polyfill, misconfigured transpilation?
Versions
v2.0.0-rc.7 and older, 1.x branch aswell.

Transferred from the API repo. We should just verify this isn't an issue on the example storefront and then close.

@aldeed how can we verify this? So far I could not reproduce this issue on MS Edge.

@HarisSpahijaPon That's good enough for me to close this. I am pretty sure this was referring to the old checkout page. Anyone coming here seeing new Edge issues can submit a new issue in this repo.


[Suggestion] Support ability to inject custom Connection

I'm loving the library so far, but in order to take to take full advantage of it, it would be nice if we can provide support for injecting a custom TypeORM connection in order to implement multitenancy

You can manage it in your module and service(extend CrudService)
Because the library uses typeorm connection through Respository of CrudService.

You can manage it in your module and service(extend CrudService)
Because the library uses typeorm connection through Respository of CrudService.

thank you ^^


WebAccess: FireRole documentation fix

FIX Improves the WebAccess FireRole documentation by providing
corrected example on how to use groups in FireRole definitions.
(closes #3107)

Signed-off-by: Samuele Kaplun<EMAIL_ADDRESS>Reported-by: Theodoros Theodoropoulos<EMAIL_ADDRESS>

Thanks, merged as e7ba096.


Not rendering local images

Thank you for your time and energy for maintaining this open source project.
I expected easy local file support like react-native-svg-uri so I spent quite some time to search for similar issue in this repository but surprisingly couldn't find any. Hence opening this issue.
Description of Bug & Unexpected behavior, and Steps To Reproduce
Mimicking the README example, I do
import * as React from 'react';
import { SvgUri } from 'react-native-svg';

export default () => (
  <SvgUri
    width="100%"
    height="100%"
    uri={require('../assets/example.svg')}
  />
);

Remote urls like the original uri="http://thenewcode.com/assets/images/thumbnails/homer-simpson.svg" works perfectly, but is blank (not rendering anything) for local files.
This worked in react-native-svg-uri but in that thread you also stated that react-native-svg now supports this functionality. And considering that people are still defaulting to using react-native-svg-uri to this day it means that this buggy and unexpected behavior is losing customers as they are using the workaround. It is okay if the workaround is good, the problem is the workaround, react-native-svg-uri, is buggy and no longer active and since react-native-svg supports this functionality, I assume that you would want to look into this issue to help out everyone who initially tried to use this library but faced similar problems.
If you do not correct the default behavior, then similar issues would be opened again and again the issues always end with the workaround's creator asking people to use the workaround, e.g. https://github.com/react-native-community/react-native-svg/issues/1204, https://github.com/react-native-community/react-native-svg/issues/310, https://github.com/react-native-community/react-native-svg/issues/612, https://github.com/react-native-community/react-native-svg/issues/510, https://github.com/react-native-community/react-native-svg/issues/347, https://github.com/react-native-community/react-native-svg/issues/310, https://github.com/expo/expo/issues/2402, which is not ideal and keeps causing confusions, as people will always ask you something about the workaround, which I am sure you are already fed up with.
Environment info
"react-native": "^0.61.5",
"react-native-svg": "9.13.3"

Have you tried this? https://github.com/react-native-community/react-native-svg#use-with-svg-files

I think the approach in react-native-svg-uri is similar to something like this:
import React from 'react';
import {SvgCssUri} from 'react-native-svg';
import resolveAssetSource from 'react-native/Libraries/Image/resolveAssetSource';

const test = require('./test.svg');

const svg = resolveAssetSource(test);

export default () => <SvgCssUri uri={svg.uri} width="100%" height="100%" />;

And won't work on android in release builds, so I don't see the point of adding partial and relatively deceptive support, when there exists a working and better performing solution to it already.

@msand, thank you for your quick response.
I apologize as I think there are some misunderstandings. I know how to render SVG files using react-native-svg, in fact, I used the first method you described (https://github.com/react-native-community/react-native-svg#use-with-svg-files), as recommended in the documentation.
What I am asking here, is that most new users would expect a behavior closer to react-native-svg-uri instead of the the current behavior of react-native-svg, and hence I consider this a bug. I hope you can further improve the library so that people never have to ask the same questions over Github and StackOverflow ever again, considering now that react-native-svg is officially backed by react-native team.

What do you mean by being backed by the react-native team? I'm not affiliated with facebook in any way, and receive no compensation, nor any significant support I can remember from the react-native team.
The issue seems like it belongs in the react-native repo if anywhere, I don't think it's possible to resolve the issue of requiring local .svg files in android release builds inside this library, or at least have no clue how to. Feel free to suggest ways to fix it / make a pr.

Alternatively it might belong in the metro repo.

And seems like new users wouldn't even know about react-native-svg-uri, and making assumption about what they expect to work seems a bit premature. Especially with regards to CommonJS style require calls, I see no reason to expect them to do anything but cause an exception, as the files don't contain CommonJS modules.

I just wanted to comment that with<EMAIL_ADDRESS>and<EMAIL_ADDRESS>I had some difficulty getting SVG in strings to work. I get nothing rendered from this:

... but this works

I don't think it makes sense to expose the require style usage, as it's broken on android, nor to depend on importing internals which aren't exposed by the main entry point, why the insistence on this syntax? Is the current approach using react-native-svg-transformer insufficient or lacking somehow? It should at least perform much better than using strings of xml, parsing that, resolving css, and only then start  creating a vdom, all earlier steps are done at build time with the transformer approach. Only use-case I see for xml strings is if you're using something that produces them dynamically, i.e. when there is no other feasible option.

If you really want to do this, I'd recommend you define a component yourself, something like this:
RequireLocalSvgIosOnly.js
import React from 'react';
import {SvgCssUri} from 'react-native-svg';
import resolveAssetSource from 'react-native/Libraries/Image/resolveAssetSource';

// NB Broken on android in release builds.
export function RequireLocalSvgIosOnly({asset, ...rest}) {
  return <SvgCssUri uri={resolveAssetSource(asset).uri} {...rest} />;
}

App.js
import React from 'react';
import {RequireLocalSvgIosOnly} from './RequireLocalSvgIosOnly';
export default () => <RequireLocalSvgIosOnly asset={require('./test.svg')} />;

I found there's a library specialised on this specific issue: react-native-local-resource, so you can do like this:
LocalSvg.js
import React, {useState, useEffect} from 'react';
import {SvgCss} from 'react-native-svg';
import loadLocalResource from 'react-native-local-resource';

export function LocalSvg({asset, ...rest}) {
  const [xml, setXml] = useState(null);
  useEffect(() => {
    loadLocalResource(asset).then(setXml);
  }, [asset]);
  return <SvgCss xml={xml} {...rest} />;
}

App.js
import React from 'react';
import {LocalSvg} from './LocalSvg';
export default () => <LocalSvg asset={require('./test.svgx')} />;

But, you have to configure it in a similar way to transformer: https://github.com/IgorBelyayev/React-Native-Local-Resource#usage
And, it'll have much worse performance in comparison. It adds several layers of processing at run-time, and in comparison, transformer can skip several parts of the processing and move it to build time. Use this pattern if you wish, but I can't figure why you would.

And, you have to use a non-standard file-extension, e.g. svgx as in this example.

If you think this pattern is valuable, feel free to make it into a npm package under any license you want, consider it under Unlicense for my part. Closing now. Feel free to ask more questions / comment.

Actually https://github.com/feats/babel-plugin-inline-import as documented in https://github.com/react-native-community/react-native-svg#use-with-svg-files will give you the better performance than this, two context switches less between js and native. But still, the transformer approach is much better, it also allows you to run the content thru svgo, often making the rendering simpler and more performant in the process, as the original svg content might be overly complex for what it actually does.

Alternatively, if you want to use svg files with the Image component from react-native and react-native-svg, then you can look into rasterizing them using https://github.com/aeirola/react-native-svg-asset-plugin

If you find the current documentation lacking, it would be very appreciated if you could make a pr with improvement suggestions.

I've made a pr to the local-resource package in an attempt to optimize it: https://github.com/IgorBelyayev/React-Native-Local-Resource/pull/11
May be that in many cases, this pattern will give "good enough" performance, but i'd still prioritise both battery energy and render time / user perceived latency by using the transformer approach, it'll quite certainly give wider budgets and thus handle more complex content with acceptable performance, especially on low-end devices, or when low on resources in general.

Perhaps should fix the support for plain .svg files, a bit strange to have it mapped when it's not working, and annoying to have wrong/non-standard extension. Seems should patch react-native, metro, and most importantly react-native-community/cli
diff --git<EMAIL_ADDRESS><EMAIL_ADDRESS>index 78744e7..77b83e3 100644
---<EMAIL_ADDRESS>+++<EMAIL_ADDRESS>@@ -43,7 +43,7 @@ function getAndroidAssetSuffix(scale) {
 } // See https://developer.android.com/guide/topics/resources/drawable-resource.html

-const drawableFileTypes = new Set(['gif', 'jpeg', 'jpg', 'png', 'svg', 'webp', 'xml']);
+const drawableFileTypes = new Set(['gif', 'jpeg', 'jpg', 'png', /*'svg',*/ 'webp', 'xml']);

 function getAndroidResourceFolderName(asset, scale) {
   if (!drawableFileTypes.has(asset.type)) {
diff --git a/node_modules/@react-native-community/cli/build/commands/server/external/xsel b/node_modules/@react-native-community/cli/build/commands/server/external/xsel
old mode 100644
new mode 100755

diff --git a/node_modules/react-native/Libraries/Image/assetPathUtils.js b/node_modules/react-native/Libraries/Image/assetPathUtils.js
index 6281c95..71da47a 100644
--- a/node_modules/react-native/Libraries/Image/assetPathUtils.js
+++ b/node_modules/react-native/Libraries/Image/assetPathUtils.js
@@ -39,7 +39,7 @@ const drawableFileTypes = new Set([
   'jpeg',
   'jpg',
   'png',
-  'svg',
+//'svg',
   'webp',
   'xml',
 ]);

diff --git a/node_modules/metro/src/Bundler/util.js b/node_modules/metro/src/Bundler/util.js
index a50de51..9e95f1f 100644
--- a/node_modules/metro/src/Bundler/util.js
+++ b/node_modules/metro/src/Bundler/util.js
@@ -144,7 +144,7 @@ function generateRemoteAssetCodeFileAst(

 function isAssetTypeAnImage(type) {
   return (
-    ["png", "jpg", "jpeg", "bmp", "gif", "webp", "psd", "svg", "tiff"].indexOf(
+    ["png", "jpg", "jpeg", "bmp", "gif", "webp", "psd", /*"svg",*/ "tiff"].indexOf(
       type
     ) !== -1
   );

@msand, hi, sorry for the delay, it is weekend over here. I read somewhere that expo & react-native teams promote using this repo, not necessarily financial backings.
Just a personal opinion that I think it is better we work to make this the repo (which is the first result) instead of having to search around. The number of similar Github and StackOverflow issues made me decide to ask you to change the design pattern.
Fragmentation is a sin and we also have the problem of the curse of inactive leaders, causing loss of productivity. For example, react-native-svg-renderer, an active repo and successor of, and a few (I think I found other 3 similar ones too) already exist anyway, but it has only 4 stars and everyone is still downloading react-native-svg-uri. After 2 years of no merging, people are still opening issues and PRs on react-native-svg-uri, instead of the successor react-native-svg-renderer. And that is why I truly wish that you can reconsider adding this functionality.
I am not sure if adding a conditional wrapper and a fixed space (installing other libraries) to check if the link is local or remote would have a noticeable negative performance impact, but it sure will have a little. I understand that svg drawings already require considerable performance and I respect your decision.
But it is a good thing that this issue exists now because somebody might google it up and find this issue, which contains links and the status of svg rendering stored locally, saving them time. Closing this issue because maintainer decided that the design pattern does not fit the repo's vision.

Well, given that the patch to cli gets released, I consider adding the LocalSvg component valuable, as it can actually work on both android and ios, with plain .svg extension, in both debug and release mode.
Alternatively it can be made to work immediately already using patch-package and the patches I've provided in the previous message. Ideally I'd see that the users of this library would use the most energy and time efficient method to render their vector graphics as a baseline. But see that it can also make sense for many projects to completely ignore rendering performance for various reasons, and just get things done asap.
As this approach (given new cli release) can allow using .svg files by only adding react-native-svg, and no futher configuration, I consider it a valuable addition to the api, given clear warnings about it's lower performance and run-time / build-time, per render / per component use / per component definition tradeoffs, and the recommended transformer approach.
Once a project starts to feel pains from rendering significant amounts of vector graphics on low end resource constrained devices, there exists a path to get some improvements with minimal configuration changes.

@Riseley Could you test the LocalSvg component? Would that api cover your use case?

This could probably be released by now, together with patch-package and those three patches it's possible to import and/or require svg files, and use them with LocalSvg or with Animated and WithLocalSvg, and it should all work on both ios and android, debug and release builds.

There's a second commit implementing WithLocalSvg in the develop branch atm: https://github.com/react-native-community/react-native-svg/commit/e66e87a5b5c090509d5e2127237963f83e60f1e9

But yeah, I think it's about time for me to take a step back from open-source development. It's starting to resemble a bit of stockholm syndrome and I don't really have the time to spare. Certainly about time that more people in the community step up to do their part of the work involved in this repository.

@msand, hi, sorry for the delay, the WithLocalSvg in the develop branch atm: e66e87a perfectly covered my use case. It would help many new users and end this issue once in for all.
So it will be cool if you can add it. Or you can also not add it to make the library as small as possible. It is your decision.
Maintaining open source is a underappreciated one. But for those who do appreciate, we are grateful that you even created this repo, and the Github Stars clear show that what you are doing is important and widely appreciated. In the end, after many years most of us realize that it is not what we get from the world that is important, but what we put into the world. I don't have a good open source project that generate so much stars because I am still inexperienced, and I can't really read long codes and do PRs for you like a pro, I am still learning. But you have one great and popular library, that is extremely useful to many, I think you staying would inspire many others, at least you are inspiring me.
But of course, I understand it is tiring, but Github Sponsors help. Please try out https://github.com/sponsors. Some gratitude given now and then is satisfying in the long run.

:tada: This issue has been resolved in version 12.1.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

Hello Guys,
First of all thanks for your valuable work!
Not sure if it is the right place to ask but as I found this thread I decided to post here.
I been trying to use this new component WithLocalSvg but it does not show anything.
Trying it on IOS.
My code:
import React from 'react';
import { View } from 'react-native';

import WithLocalSvg from 'react-native-svg';

const Icon = () => {
  return (
    <View style={{ width: 400, height: 400, backgroundColor: 'purple' }}>
      <WithLocalSvg
        fill="green"
        width="100%"
        height="70%"
        asset="../../assets/images/astronaut.svg"
      />
    </View>
  );
};

export default Icon;

I have tried to use uri instead of asset but did not work. Can you provide any help?
Thanks a lot.

@diazevedo Hope you have already solved the issue,
just for info the following is how i solved the issue on my end
import { WithLocalSvg} from 'react-native-svg';
<WithLocalSvg
width="100%"
height="100%"
asset={require('../assets/images/createTag.svg')}
/>

@diazevedo were you able to resolve it ?

@diazevedo Hope you have already solved the issue,
just for info the following is how i solved the issue on my end
import { WithLocalSvg} from 'react-native-svg';
<WithLocalSvg
width="100%"
height="100%"
asset={require('../assets/images/createTag.svg')}
/>

Just remove react-native-svg-transformer's settings from metro.config.js

If anyone comes across the thread this is how I ultimately ended up solving this issue in the expo 42, react-native: 42. Be sure to take away react-native-svg-transformer if you have put any of that in your project.
import { Image } from 'react-native';
import { SvgUri } from 'react-native-svg';
const uri = Image.resolveAssetSource(require('image.svg'))
<SvgUri
    width={width}
    height={width}
    uri={uri}
  />

Maybe something has changed or just a misspell but Image.resolveAssetSource returns an object with uri property (https://reactnative.dev/docs/image#resolveassetsource). So, the actual code should be like this:
import {View, Image} from 'react-native';
import {SvgUri} from 'react-native-svg';

const {uri, width, height} = Image.resolveAssetSource(require('../../assets/example.svg'));

<SvgUri
  width={width}
  height={height}
  uri={uri}
/>

notice the object destructuring. And it actually works (without react-native-svg-transformer)! Thanks.