Lowering min desired capacity

In your examples, if the scripts decide to lower the minimum desired capacity when putting an instance into standby mode, I don't see it ever returning that minimum to the original value.  Seems a like a problem that could come back to bite you long term, as your auto-scale group could get smaller and smaller.

+1 - this was a problem for me too - autoscaling group min eventually went to 0 and the scale down for low ELB latency completely killed everything.

@russellneufeld adding the following to "common_functions.sh" at line 190 worked for me:
msg "Checking to see if ASG $asg_name will let us increase desired capacity"
    local min_desired=$($AWS_CLI autoscaling describe-auto-scaling-groups \
        --auto-scaling-group-name $asg_name \
        --query 'AutoScalingGroups[0].[MinSize, DesiredCapacity, MaxSize]' \
        --output text)

    local min_cap=$(echo $min_desired | awk '{print $1}')
    local max_cap=$(echo $min_desired | awk '{print $3}')
    local desired_cap=$(echo $min_desired | awk '{print $2}')

    if [ -z "$min_cap" -o -z "$desired_cap" -o -z "$max_cap" ]; then
        msg "Unable to determine minimum, maximum, and desired capacity for ASG $asg_name."
        msg "Attempting to increase the minimum regardless."
    elif [ $min_cap -lt $max_cap ]; then
        local new_min=$(($min_cap + 1))
        msg "Incrementing ASG $asg_name's minimum size to $new_min"
        msg $($AWS_CLI autoscaling update-auto-scaling-group \
            --auto-scaling-group-name $asg_name \
            --min-size $new_min)
        if [ $? != 0 ]; then
            msg "Failed to increase ASG $asg_name's minimum size to $new_min. Ensure correct minimum before proceeding."
            return 1
        fi
    fi

Thanks Matt!  I’ll give this a try.

On Jun 11, 2015, at 6:16 PM, Matt Fuller<EMAIL_ADDRESS>wrote:
@russellneufeld https://github.com/russellneufeld adding the following to "common_functions.sh" at line 190 worked for me:
msg "Checking to see if ASG $asg_name will let us increase desired capacity"
local min_desired=$($AWS_CLI autoscaling describe-auto-scaling-groups
--auto-scaling-group-name $asg_name
--query 'AutoScalingGroups[0].[MinSize, DesiredCapacity, MaxSize]'
--output text)
local min_cap=$(echo $min_desired | awk '{print $1}')
local max_cap=$(echo $min_desired | awk '{print $3}')
local desired_cap=$(echo $min_desired | awk '{print $2}')

if [ -z "$min_cap" -o -z "$desired_cap" -o -z "$max_cap" ]; then
    msg "Unable to determine minimum, maximum, and desired capacity for ASG $asg_name."
    msg "Attempting to increase the minimum regardless."
elif [ $min_cap -lt $max_cap ]; then
    local new_min=$(($min_cap + 1))
    msg "Incrementing ASG $asg_name's minimum size to $new_min"
    msg $($AWS_CLI autoscaling update-auto-scaling-group \
        --auto-scaling-group-name $asg_name \
        --min-size $new_min)
    if [ $? != 0 ]; then
        msg "Failed to increase ASG $asg_name's minimum size to $new_min. Ensure correct minimum before proceeding."
        return 1
    fi
fi

—
Reply to this email directly or view it on GitHub https://github.com/awslabs/aws-codedeploy-samples/issues/19#issuecomment-111291594.

@matthewdfuller using the logic above can cause your min_cap to increase when it was never reduced.
ie Before putting instance into standby : Min=1, Max=2, Desired=2
The logic is : ($min_cap == $desired_cap -a $min_cap -gt 0) for determining to reduce min_cap,  so in this example min will stay set to 1.
Then your logic above will compare min to max (1 < 2) so you will then increase min to 2 which is not what you want.
I think there is no way to work out if you need to increase on taking instance out of standby unless you save the min/max in the autoscaling_enter_standby() function. Im thinking I will write these out to a file and then restore in the autoscaling_exit_standby() function.

@scottharrisaus good catch - honestly this seems like an excessively large script to include and maintain with every project that uses CodeDeploy. Would prefer that AWS include an option for managing instance removal / addition during the deployment process. But for now, I agree, it'll likely come down to saving the pre-deploy settings to a file and then restoring them afterwards.

Writing these values to a file seems like the better way of ensuring they get preserved.  Please let me know when this change is made.  Thanks!

Hey @scottharrisaus – any updates on this?
Currently, I'm creating a file to check if the capacity was decremented before incremeneting it again before putting the instance back to InService state.
But I would far rather trust your code than mine here :P

@scottharrisaus @nemo @matthewdfuller  You are welcome to submit a pull request and I'd be happy to review and merge it in. Meanwhile I've added this to our backlog. Thanks.

+1

This is fixed in https://github.com/awslabs/aws-codedeploy-samples/commit/e1e1501dc44084d6e7c0857ee84279061db73e80

Thanks!

Instead of putting the instance in standby, cant we suspend autoscaling. The deployment flow in this case will be:
suspend autoscaling
deregister first instance from elb
stop the application
deploy the code
start the application
register the instance to elb
resume autoscaling.
Does this work instead of putting instance to standby as already minimum and desired capacity is same in my autoscaling group. So after putting instance to standby, the script fails to reduce the desired capacity as it cannot go below min capacity. This cause a new instance to spin up and orginal instance to remain in standby.


Portal Mappack is world 2-1 is unbeatable

Portal Mappack world 2-1 is unbeatable due to the speed gel not reaching enough for the player to be able to jump to the the bounce gel
Mari0 1.16
https://user-images.githubusercontent.com/68875386/132111400-4f016807-65d0-4ac5-90e7-2cea1e47108b.mp4
Mari0 Alesan99's entities 13d (which I think is the latest update)
https://user-images.githubusercontent.com/68875386/132111498-a694ea92-6f47-464e-8ccf-25e16ed46f42.mp4

The issue does not render the level unbeatable, however yes there is a problem with gel placement.


TypeError: received.getMockName is not a function

I got this error When trying to run the following test
it('Button click calls onAdd', () =>{
const button = add.find('button').first();
const input =add.find('input').first();
input.simulate('change',{target:{value:'Name 4'}});
button.simulate('click');
expect(onAdd).toBeCalledWith('Name 4');
});
error:
TypeError: received.getMockName is not a function
  at Object.it (src/__tests__/add.test.js:33:34)
      at new Promise (<anonymous>)
  at Promise.resolve.then.el (node_modules/p-map/index.js:46:16)
      at <anonymous>

My package.json file
{
"name": "codementor_test",
"version": "0.1.0",
"private": true,
"dependencies": {
"enzyme": "^3.3.0",
"enzyme-adapter-react-16": "^1.1.1",
"react": "^16.3.1",
"react-scripts": "1.1.4",
"react-test-renderer": "^16.3.1"
},
"scripts": {
"start": "react-scripts start",
"build": "react-scripts build",
"test": "react-scripts test --env=jsdom",
"eject": "react-scripts eject"
},
"devDependencies": {
"expect": "^22.4.3",
"jest-mock": "^22.4.3",
"p-map": "^1.2.0",
"react-dom": "^16.3.1"
}
}
Thanks for looking at this

expect v22+ is maintained by the jest team; this repo is for earlier versions.

Thanks, I didnt know that.


Change references from react-themr to react-css-themr

I noticed the docs has the old name. This keeps it up to date. \o/

Thanks! 👻


Missing $foreach

Hello. Trying to use this package, I manage to make a few examples work. However it seems that, unlike actual Velocity, this implementation does not auto-generate a $foreach variable with count,  index, hasNext, etc.
Am I missing something ? Or is there a workaround ? Trying to generate JSON, I need to do something like #if($foreach.hasNext),#end at the end of the loop to insert a comma except at the last item, since JSON forbids a final comma in lists/maps.

velty is inspired by velocity as we migrate our system from java, our velty implementation is limited to features that our legacy system used, I'll add that as a feature request


v0.3.13 error win32 x64

:warning:Please attach %TEMP%\vscode-java-installer\log.txt and %TEMP%\vscode-java-installer\AdoptOpenJDK-MSI.log for more details.
version: 0.3.13
env:
JAVA_HOME: undefined
PATH:
C:\Program Files\Common Files\Oracle\Java\javapath
C:\WINDOWS\system32
C:\WINDOWS
C:\WINDOWS\System32\Wbem
C:\WINDOWS\System32\WindowsPowerShell\v1.0\
C:\WINDOWS\System32\OpenSSH\
C:\Program Files\Java\jdk-16.0.1\bin
C:\Users\ajitt\AppData\Local\Microsoft\WindowsApps
C:\Users\ajitt\AppData\Local\Programs\Microsoft VS Code\bin
JDKs:
C:\Program Files\Java\jdk-16.0.1	env.PATH,WindowsRegistry,DefaultLocation

log:
[16:18:33] Configure Java Settings
[16:18:33] Error occurred
[16:18:33] Error: Can not add index to parent of type string

The installer failed to update java.home in your vscode user settings. It can be syntax error but we are not sure. It would be great if you can provide content of your settings.json file. It shoule be located in C:\Users\ajitt\AppData\Roaming\Code\User\settings.json.
Back to your issue, since you have a JDK 16(>11) installed, you can directly install Java Extension Pack in vscode, and it should work out of box.


Bug fix: Resource Group and VWAN creation results in race condition

Apologies, I see now that the creation of a resource group is optional. I will update to provide a suggested approach.

@jaredfholgate Overall changes look good.
Can you add "create_resource_group" in all the examples? Lokks like you have only added in the basic test folder.
Also would you like to comment on https://github.com/Azure/terraform-azurerm-avm-ptn-virtualwan/pull/13/files#r1391684150?

@jaredfholgate Overall changes look good. Can you add "create_resource_group" in all the examples? Lokks like you have only added in the basic test folder. Also would you like to comment on https://github.com/Azure/terraform-azurerm-avm-ptn-virtualwan/pull/13/files#r1391684150?

Done. Thanks


Supporting the Ecosystem

Hi everyone!
I think one of the main goals that the rust net web wg should focus on is not just exploring futures 0.3 but also supporting the community of users and maintainers. I think there are two sides to this, one is creating a really good consumer-facing book on how to work with futures and a place that really primes and sets people up for success with futures. The second is to create guides for library maintainers that use futures 0.1 on how to migrate to 0.3 easily. These two goals to me should enable the ecosystem and its users to reap the benefits of futures 0.3 quicker.
For the book, we already have a pretty good book here but it is still very light on its material. I would like to see kind of what the tokio.rs site was going after for its docs but more general and applied to futures 0.3. I think this is something that should be a large effort by the net web wg. I think it should include chapters on how to use tide, write a proxy, write clients and work with databases. Any more use cases are welcome, I'm sure I did not cover all of them. But to me, the goal of this is to help people get started as the biggest area of weakness right now for futures is documentation.
Not only do we need to write a book but doing weekly blog posts and/or making tutorial videos is another thing that could greatly decrease the barrier of entry for using futures.
For the guides, I'm not 100% sure how we should go about this but I would like to see a guide on how to use the compat layers and what options library maintainers have to move to the new futures 0.3. This may also mean that as a team we spend some time exploring on how to migrate certain libraries to 0.3 and use that experience as a stepping stone for writing the guides.
I think one of the biggest goals that this wg should have is to enable the producers and consumers of the ecosystem. Enabling them to build the best software they can build with such a great language like rust.
I probably missed some stuff but I think this properly summarizes what I was thinking. Feel free to comment on any ideas, I mostly just wanted to start a conversation around this.
cc @yoshuawuyts @bIgBV

@LucioFranco thanks so much for starting the discussion! I quite like everything you've raised so far. I've tried summarizing the points you've made into a brief overview:

async-book

Look to tokio's docs for inspiration, but generalize it further, and apply to std futures
Chapter on Tide
Write a client
Work with databases

futures migration guide

cover the compat layer
cover migration from futures 0.1 to 0.3/std

consider using (recurring) examples

weekly blog posts / videos

A challenge the WG currently has is that we have a presence on 4 websites currently, and if we add a book that'd make 5. I'm thinking perhaps for a first bit it might perhaps be good to perhaps start with just one book for the general futures documentation + migration guides.
It might perhaps also be good to not to include Tide in this while the API is still actively developed. That would prevent us from possibly being blocked at times, and having to go back and rewrite things. I def like the idea of looking at other docs (in particular Tokio), and see what we can learn from them.
Also worth noting is that there's a new database WG forming, and they might be able to assist with covering everything about database bindings. Perhaps talking to them about writing docs would be good.
@LucioFranco More blog posts & videos would be very cool! We have a blog on rustasync/team#gh-pages, and adding to that would be awesome. Do you have any ideas for posts or videos in particular?
I'm very excited for all this!

Also in chat @LucioFranco linked the outline of the Tokio doc effort was linked which might be great to take inspiration from: https://github.com/tokio-rs/doc-push/tree/master/outline.

@yoshuawuyts I think that summary is pretty good, though I would probably add a proxy or another example that heavily uses channels to show how they can be used.
I think it may also be interesting to take patterns used from production systems that use futures I'm thinking linkerd as a good candidate on how to build high throughput systems.
As for videos, Im not totally sure but I do really like the 5min videos on rust that ryan has started and doing something similar for futures would be good.


Cannot access page to get cliientID for reg-notify-github-plugin

Describe the bug
I installed reg-suit Github app.
But, When I access to https://reg-viz.github.io/gh-app/ showing 404.
Do I need to do anything other than installing Github app?
Reproduced step
Steps to reproduce the behavior:

Install Github app. https://github.com/apps/reg-suit
Go to https://reg-viz.github.io/gh-app/
Show 404 page.

Expected behavior
I can access https://reg-viz.github.io/gh-app/ and get the ClientID.
Actual behavior
404 was shown.
Screenshots

Ooops, I'll investigate this!

@m-kikuchi777 For now pls use https://github.com/login/oauth/authorize?client_id=Iv1.88b2ad3983e01d13

Thanks for the quick response and investigate!
I was able to get the ClientID.

I've fixed this. Thanks for reporting


Feature request: robot_description topic

To ease the transition to ROS2 we would like to use a robot_description topic instead of a parameter.
Would a PR get accepted which expands the model view with a topic option?
Implementation would be an enum box which chooses between Parameter (default) or Topic.

Is setting robot description ROS Parameter on ROS2 side not an option? Just wondering, but in one of a ros1-2 bridge projects I think I saw that (robot running on ros1, then there's a bridge to receive some in ros2, but in ros2 redundantly set robot description). It's not nice but worked. Just fyi.

I've created a plugin which solves this issue: https://github.com/nobleo/rviz_robot_description_topic


feat: Add $useExactComparison option to assertLogged

Description
Currently, CIUnitTestCase::assertLogged() matches the logged message verbatim. For simple messages this is no problem but for complex, hard-to-build, or volatile messages, it may be hard to come up with the exact message. This PR adds the capability for the assertLogged method to compare only parts of the message instead of the whole.
Checklist:

[x] Securely signed commits
[ ] Component(s) with PHPDoc blocks, only if necessary or adds value
[x] Unit testing, with >80% coverage
[ ] User guide updated
[x] Conforms to style guide

The implementation looks good.

Something wrong with GA checks.

Some checks were not successful
1 failing and 5 successful checks

I was actually contemplating between a new method and modified method. I'll check what I can do.

Generally It is better to avoid boolean flag parameter.
I prefer a new method, because it is easier to read.
$this->assertLogged('error', 'variable did not', false); // What's false? Jump to the method.
$this->assertLogContains('error', 'variable did not');


Support scripts with absolute paths

For a single page app like: https://shop.polymer-project.org/detail/mens_tshirts/Inbox+-+Subtle+Actions+T-Shirt
Scripts should be server-absolute to prevent odd cache behavior.

@mgiuffrida


Refactor config loading

Current config/probing code is very messy, tried to make it a little less messy :)

Replaced the useEffect-based setup code with react-router's data loaders.
I think the code got a little more easier to understand, also made it more separated and add some docs.
Visually speaking it looks like it got a little faster.

I'm seeing this error appear in my console numerous times:
SyntaxError: JSON.parse: unexpected character at line 1 column 1 of the JSON data
Home@http://localhost:5173/src/Home.tsx:28:44
RenderedRoute@http://localhost:5173/node_modules/.vite/deps/chunk-DSEL6NC5.js?v=2c06ec50:3633:7
Outlet@http://localhost:5173/node_modules/.vite/deps/chunk-DSEL6NC5.js?v=2c06ec50:4070:20
div
ResolveAwait@http://localhost:5173/node_modules/.vite/deps/chunk-DSEL6NC5.js?v=2c06ec50:4239:7
AwaitErrorBoundary@http://localhost:5173/node_modules/.vite/deps/chunk-DSEL6NC5.js?v=2c06ec50:4160:5
Await@http://localhost:5173/node_modules/.vite/deps/chunk-DSEL6NC5.js?v=2c06ec50:4144:7
Suspense
ResolveAwait@http://localhost:5173/node_modules/.vite/deps/chunk-DSEL6NC5.js?v=2c06ec50:4239:7
AwaitErrorBoundary@http://localhost:5173/node_modules/.vite/deps/chunk-DSEL6NC5.js?v=2c06ec50:4160:5
Await@http://localhost:5173/node_modules/.vite/deps/chunk-DSEL6NC5.js?v=2c06ec50:4144:7
ErrorBoundary@http://localhost:5173/node_modules/.vite/deps/react-error-boundary.js?v=2c06ec50:18:5
Layout@http://localhost:5173/src/App.tsx:78:18
RenderedRoute@http://localhost:5173/node_modules/.vite/deps/chunk-DSEL6NC5.js?v=2c06ec50:3633:7
RenderErrorBoundary@http://localhost:5173/node_modules/.vite/deps/chunk-DSEL6NC5.js?v=2c06ec50:3590:5
DataRoutes@http://localhost:5173/node_modules/.vite/deps/react-router-dom.js?v=2c06ec50:544:7
Router@http://localhost:5173/node_modules/.vite/deps/chunk-DSEL6NC5.js?v=2c06ec50:4084:7
RouterProvider@http://localhost:5173/node_modules/.vite/deps/react-router-dom.js?v=2c06ec50:361:7
App
_a@http://localhost:5173/node_modules/.vite/deps/react-helmet-async.js?v=2c06ec50:624:5

I really can't repro this one, how is your config done? any custom config.json or something like?

The console errors were due to a config issue on my end. I had beaconAPI: null for some reason.


Issues with Fine-Tuning Model

Hello,
I am trying to fine-tune the model, but I have run into a number of issues today.
Before making a longer training run with more data, I want to conduct a smaller training run with a small dummy dataset to see if and how the training works. The videos for the dummy dataset I created are in the following GitHub repo: Dummy Dataset Repository.
The script I am using for my test training is here: Training Script.
Inside the define_frame_index function from t2v_datasets.py, I commented out a few lines of code that run checks on the video. I did this to prevent errors that would otherwise occur.
When running the training script, I get the following error:
10/23/2024 20:48:13 - INFO - __main__ -   Num examples = 10
10/23/2024 20:48:13 - INFO - __main__ -   Num Epochs = 10
10/23/2024 20:48:13 - INFO - __main__ -   Instantaneous batch size per device = 1
10/23/2024 20:48:13 - INFO - __main__ -   Total train batch size (w. parallel, distributed & accumulation) = 1
10/23/2024 20:48:13 - INFO - __main__ -   Gradient Accumulation steps = 1
10/23/2024 20:48:13 - INFO - __main__ -   Total optimization steps = 100
10/23/2024 20:48:13 - INFO - __main__ -   Total optimization steps (num_update_steps_per_epoch) = 10
10/23/2024 20:48:13 - INFO - __main__ -   Total training parameters = 2.7719816 B
10/23/2024 20:48:13 - INFO - __main__ -   AutoEncoder = WFVAEModel_D8_4x8x8; Dtype = torch.bfloat16; Parameters = 0.147347724 B
10/23/2024 20:48:13 - INFO - __main__ -   Text_enc_1 = models/text_encoder; Dtype = torch.bfloat16; Parameters = 5.65517312 B
Checkpoint 'latest' does not exist. Starting a new training run.
Steps:   0%|                                                                                | 0/100 [00:00<?, ?it/s]Skip the data of 0 step!
Video training/videos/video_4.mp4 is too short to encode. Using available frames.
Video training/videos/video_6.mp4 is too short to encode. Using available frames.
Video training/videos/video_9.mp4 is too short to encode. Using available frames.
Video training/videos/video_8.mp4 is too short to encode. Using available frames.
Video training/videos/video_5.mp4 is too short to encode. Using available frames.
Video training/videos/video_2.mp4 is too short to encode. Using available frames.
Video training/videos/video_10.mp4 is too short to encode. Using available frames.
Video training/videos/video_7.mp4 is too short to encode. Using available frames.
Video training/videos/video_3.mp4 is too short to encode. Using available frames.
Video training/videos/video_1.mp4 is too short to encode. Using available frames.
Traceback (most recent call last):
  File "/workspace/Open-Sora-Plan/opensora/train/train_t2v_diffusers.py", line 1154, in <module>
    main(args)
  File "/workspace/Open-Sora-Plan/opensora/train/train_t2v_diffusers.py", line 1002, in main
    train_one_epoch()
  File "/workspace/Open-Sora-Plan/opensora/train/train_t2v_diffusers.py", line 958, in train_one_epoch
    if train_one_step(step, data_item, prof_):
  File "/workspace/Open-Sora-Plan/opensora/train/train_t2v_diffusers.py", line 942, in train_one_step
    run(step_, x, model_kwargs, prof_)
  File "/workspace/Open-Sora-Plan/opensora/train/train_t2v_diffusers.py", line 682, in run
    timesteps = explicit_uniform_sampling(
  File "/workspace/Open-Sora-Plan/opensora/utils/utils.py", line 67, in explicit_uniform_sampling
    sampled_timesteps = torch.LongTensor([round(random.uniform(lower_bound, upper_bound)) for _ in range(bsz)], device=device)
RuntimeError: legacy constructor expects device type: cpu but device type: cuda was passed
Traceback (most recent call last):
  File "/workspace/Open-Sora-Plan/opensora/train/train_t2v_diffusers.py", line 1154, in <module>
    main(args)
  File "/workspace/Open-Sora-Plan/opensora/train/train_t2v_diffusers.py", line 1002, in main
    train_one_epoch()
  File "/workspace/Open-Sora-Plan/opensora/train/train_t2v_diffusers.py", line 958, in train_one_epoch
    if train_one_step(step, data_item, prof_):
  File "/workspace/Open-Sora-Plan/opensora/train/train_t2v_diffusers.py", line 942, in train_one_step
    run(step_, x, model_kwargs, prof_)
  File "/workspace/Open-Sora-Plan/opensora/train/train_t2v_diffusers.py", line 682, in run
    timesteps = explicit_uniform_sampling(
  File "/workspace/Open-Sora-Plan/opensora/utils/utils.py", line 67, in explicit_uniform_sampling
    sampled_timesteps = torch.LongTensor([round(random.uniform(lower_bound, upper_bound)) for _ in range(bsz)], device=device)
RuntimeError: legacy constructor expects device type: cpu but device type: cuda was passed

My environment consists of:

PyTorch version: 2.1.0
CUDA: 11.8.0
OS: Ubuntu 22.04
GPU: A100 80GB SXM

Questions:
How can I avoid the error?
Thank you for your help!

Hi, we are fixed this bug, sorry for that. You can see  the main branch to avoid this error.
https://github.com/PKU-YuanGroup/Open-Sora-Plan/commit/390de3f77751f73f139a53c90875a5b0a740535f

Thank you! I will try it out today and report if it works!

Worked. Closing the issue. Thank you.


Error on export video :(

whenever i export the video the returned file is null and goes to else case showing this error
final File file = await _controller.exportVideo(       videoFormat: "mp4",       customInstruction: "-crf 17", //visually lossless       preset: VideoExportPreset.medium,     );     if (file != null) {       NavigationService().goBack(file);       _exportText = "Video success export!";     } else {       _exportText = "Error on export video :(";     }

getting ERROR ON EXPORT VIDEO (CODE 1) on video_editor: ^1.0.2

getting ERROR ON EXPORT VIDEO (CODE 1) on video_editor: ^1.0.2

Oh no! I don't have Mac to test the API. You can view the Flutter_FFMPEG documentation for iOS

Oh no! I don't have Mac to test the API. You can view the Flutter_FFMPEG documentation for iOS

I just released the 1.0.3 version. Please use it with the "min-gpl-lts" package and try it


Fixing misspelt heading in configuration example

Minor change fixing sample configuration file whose header was misspelt.  Code correctly references toml:subscriber so no functional impact

LGTM

@andyfeller can you sign the CLA please?

@e-dard done

@andyfeller do you possibly need to rebase from latest master? Not sure what's going on with your commit history there.

I think this is due to be rebasing with upstream/master.  Going to see about clearing this up.


chore/tests

This PR adds the tiniest tests and actions to keep integration up.
Using vitest and github actions ✨

LGTM


GSF IF Meeting Agenda 2024-03-21

Time 10:30am (GMT) / 4:00pm (IST) - See the time in your timezone

Lead – @srini1978 (Microsoft)
Co-Lead @navveenb (Accenture)
Co-Lead – @jawache (GSF)
PM - @jmcook1186 (GSF)

Antitrust Policy
Joint Development Foundation meetings may involve participation by industry competitors, and it is the intention of the Joint Development Foundation to conduct all of its activities in accordance with applicable antitrust and competition laws. It is therefore extremely important that attendees adhere to meeting agendas, and be aware of, and not participate in, any activities that are prohibited under applicable US state, federal or foreign antitrust and competition laws.
If you have questions about these matters, please contact your company counsel or counsel to the Joint Development Foundation, DLA Piper.
Roll Call
Please add 'Attended' to this issue during the meeting to denote attendance.
Any untracked attendees will be added by the GSF team below:
Agenda

[ ] Press Record!
[ ] Overview of new internal processes
[ ] Weekly call structure

Attended

Attended

Attended

Attended

Attended

Attended

Attended

Closing as complete


Scrolling stops if mouse pointer rolls over title label on subscriptions tab

CPod version: 1.25.2
Description of the problem:
When scrolling on the subscriptions tab, if the mouse pointer rolls over a show label, scrolling stops.  Seems like new behavior.

Hi benjamindaines, v1.25.3 includes a fix for this bug. Please let me know if there are any problems.

I'll be closing this for now. I'll reopen if there are any problems. Thanks.


More snippets

Imported missing snippets from xabikos/vscode-javascript
Added one useful snippet for "require to functions"

Hi, thanks for reminding me to update this fork - I'll manually pull master up to date, remove extra semicolons and close this PR


private and public

Silly question, what options/command should be used to generate the public.pem and private.pem? I've looked through https://nodejs.org/api/tls.html and have still run into issues (such as:
c.context.setCert(options.cert);                 ^ Error: error:0906D06C:PEM routines:PEM_read_bio:no start line
)

I use this in my startup script.
		openssl genrsa -out bot.key 2048
		openssl req -new -sha256 -key bot.key -out bot.csr -subj "/"
		openssl x509 -req -in bot.csr -signkey bot.key -out bot.cert
´´´

You don't need to generate the certificate signing request individually. You can combine both of these into one with:
openssl req -x509 -newkey rsa:2048 -nodes -keyout key.pem -out certificate.pem
For convenience you can also write both the private key and the signed certificate in the same file:
openssl req -x509 -newkey rsa:2048 -nodes -keyout mumble.pem -out mumble.pem
If you want to protect the key with a pass phrase, you can leave the -nodes option out.

Works perfectly, thanks!

That's useful. Perhaps it should be in the README instead of just saying "here's the page go figure it out"? Would be more node-beginner friendly...


Sublime shortcuts on linux - Ctrl-Alt-Down should be changed to Alt-Shift-Down.

Sublime has a pc shortcut Ctrl-Alt-Down which corresponds to addCursorToNextLine. On linux Ctrl-Alt is reserved so this is changed to Alt-Shift-Down in sublime.
Could we detect that the os is linux and change the shortcut accordingly?

Well seen! Ctrl-Alt-Down (Up/Left/Right) is reserved on Windows too (for screen rotation).

I suppose we could (I assume navigator.platform is pretty reliable). Want to submit a patch?


feat: back button in send sats screen (not prompt)

Describe the changes you have made in this PR
Added back button to send satoshis screen, while keeping in mind that we don't need a back button in prompt screen. I have used navigate.isPrompt for the same.
Link this PR to an issue [optional]
Fixes #1535
Type of change

feat: New feature (non-breaking change which adds functionality)

Screenshots of the changes [optional]
https://user-images.githubusercontent.com/74018438/218791326-5481766c-103a-480d-a531-ae665b9bbfe7.mp4
How has this been tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist

[x] My code follows the style guidelines of this project and performed a self-review of my own code
[x] New and existing tests pass locally with my changes
[x] I checked if I need to make corresponding changes to the documentation (and made those changes if needed)

@escapedcat Could I get a review on this?

@im-adithya Could you review?
Thanks!!


[Feature-Request] Expose stats used for 3A algorithms

Start with the why:
We are working to improve image quality in poor lighting situations and have found that the 3A evaluations (auto-focus/auto-exposure/auto-white balance) do not give us our desired results. Specifically we see ISO increase more quickly than exposure and we have limits that we want to keep things within. Additionally, the production we are building can supply additional light, which can be used to increase brightness of an image without increasing the ISO significantly. We've tried playing with auto exposure on a ROI and using custom-tuning bins, but would like more control over setting certain values such as exposure time and ISO sensitivity, lens position, etc. based on data gathered from the sensor. In discussion with Erik, it sounds like there are plans to expose the data used in calculation for the 3A algorithms so that they can be used in custom logic for focus/exposure/white balance.
Move to the what:
Please make available the stats used in the 3A evaluation algorithms on the ISP available so that custom algorithms may be implemented either on host or on-device (flashed Script node). Our plan would be to use these values while manually setting the exposure and ISO.

Related to https://github.com/luxonis/depthai-core/issues/761, almost the same request for the same purpose

Hi @Erol444 , May I know if this feature could be added? It was a free stat from the ISP anyway? Or has to be explicitly computed onboard RVC?

@chengguizi this feature could be added but isn't high on priority list at the moment. Yes params would be used from previously computed ones.


Fallback to Perception on iOS 17 beta builds

Early beta versions used the @_marker protocol for Observable.
Changes to the protocol's memory layout in these versions disrupt dynamic casting,
e.g. subject as? any Observable. This occurs because the Swift runtime expects a specific
protocol metadata layout for casting, and this mismatch leads to a crash.
As a result, the following check has been implemented to disable Observation on any of the
following beta OS versions:

iOS 17.0.0
watchOS 10.0.0
tvOS 17.0.0

This safeguard makes sure that Perception is used in place of Observation.
P/R of https://github.com/pointfreeco/swift-perception/pull/66

Once it's merged, let's add a tag so we can link to it instead of a commit from the ios-app repo, please 🙏

@palpoms
https://github.com/monzo/ios-app/pull/20867/files#diff-2c2060c16025934415d58ac106ea8f19a483b8111694da6904f60fddb91859dc


Query: Entities not being released due to leak in query caching

Apologies if this has been mentioned before:
The problem I am seeing, is that entities are still being held in memory, even after the Context has been disposed.
I have tried the following:
private void Method() {
     Test();
}

 private void Test()
 {
            using (var Context = new ExampleEntities())
            {
                Context.ExampleTable.ToList();
          }
}

When you view the memory heap after the method Test has completed, ExampleTable rows are still held in memory.

Are you running in release mode?

I was debugging and I'm 90% certain as other objects (non ef) are released when I force a collection.
Sent from my iPhone
On 10 Oct 2016, at 19:46, Rowan Miller <notifications<EMAIL_ADDRESS>wrote:
Are you running in release mode?

You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://github.com/aspnet/EntityFramework/issues/6737#issuecomment-252706890, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AVrOYIyD9fnI8LBY3Uy9hqrxvXS9SJVDks5qyofvgaJpZM4KSBYw.

All electronic mail to, from, or within the Telford & Wrekin Council may be the
subject of a request under the Freedom of Information Act 2000 and related
legislation, and therefore may be required to be disclosed to third parties.
Telford & Wrekin Council may monitor email traffic data and also the content of email in conjunction with the relevant policies.

A couple of comments on this in case it helps:

By default, entities returned in query results are tracked by default in the DbContext you used to execute the query. This implies the DbContext instance contains references to the entities. There are ways to opt out, e.g. call the AsNoTracking() method in the query.
By design, DbContext won't release referenced entities when Dispose() is invoked (e.g. a the end of the using block). You will rely on garbage collection to collect the context and all its children objects instead.
I can't remember from the top of my mind if this actually applies to this specific case, but in the past I have definitively seen Debug compilations alter the standard scoping rules of variables. Assuming that was happening here, the variable Context could still be in the method stack even after the using block is finalized. In my experience, if you are paying very close attention you will see some bizarre behaviors in Debug that won't actually occur when you compile for Release.

A more reliable way to tell if the entity is still in memory is to look after the Test() and you force a garbage collection. If you can still observe any unexpected behavior when doing that, it would be great if you could provide a full repro.

Hi,
Thanks for the comments.
•	Unfortunately AsNoTracking() does not help me, as I have found that by using it, the entity relationships are not loaded automatically.
Rightly or wrongly I have found that by doing the following:
class TableA {
[key]
public Guid Oid {get;set;}
public string Code {get;set;}
}
class TableB{
[key]
public Guid Oid {get;set;}
public Guid TableA {get;set;}
public TABLEA TABLEA {get;set;}
public string Code {get;set;}
}
Context.TableA.ToList();
Context.TableB.ToList();
Significantly out performs
Context.TableB.Include(row => row.TABLEA). AsNoTracking().ToList();
On my more complex model, I also got out of memory exceptions using the AsNoTracking() technique, where I didn’t get anywhere close using the first method.
•	I first noticed this when I ran my app in release mode.  As you may gather I am loading a large amount of data for a year, If I want to load another years data in, I reset all my objects back to null and  restart the load process, I noticed that the amount of memory being used was increasing rather than staying at a constant (as best as) level.  Eventually, by keep loading data from 1 year to the next, Out Of Memory exceptions are thrown..
•	I looked at the memory, when the USING had completed, then when Test() had completed and then after a system.gc.collect() completed.  Each time, the objects were still in memory.
I have attached an sample project hopefully demonstrating my issue.
EFTest.zip
You will need to add the Framework and adjust the DB Connection.
When the Main Method (EFTest) or MainWindow Constructor (WPFApplication) has got to the end, there are multiples of the same rows from TableA & TableB still in memory.
It's probably my complete misunderstanding of the garbage collection
Hope this makes sense

Before we get someone to dig into this, I just want to double check that this isn't because the entities are databound to a form? If there is no databinding, then we'll get someone to look at it.

The data items are not bound

Thanks, we'll take a look at it.

This seems to be a leak in query caching, which is keeping references to the context.  There may be other paths, but the one I have been able to trace is this:

MemoryCache uses CacheKey instances (SqlServerCompiledQueryCacheKey in this case)
CacheKey instances have an Expression, which in this case is an ConstantExpression holding an EntityQueryable instance
EntityQueryable instances hold on to the EntityQueryProvider
EntityQueryProvider holds on to the QueryCompiler
QueryCompiler is a scoped provider service that uses the current DbContext through several paths

Marking the bug for re-triage.

I can confirm with @ajcvickers that the issue is still happening. This seems like a decent bug because it is going to bogart resources/DTUs on Azure until this is patched.

@anpete just confirm, is the bug fix included in 1.1.0-preview1?

No, didn't make it.

@anpete Is there a time frame for the patch release and if there is a work around? Is this an issue with IDisposable or just the implementation with EF?

@schwietertj The problem was with EF. You can see the details in this PR https://github.com/aspnet/EntityFramework/pull/6819
I think there may be a workaround, which is to Detach all entities from the leaked DbContext. I.e. The context instance that was used to initially execute the query. cc @ajcvickers who should be able to confirm.

@schwietertj @anpete That should work to release the vast majority of the memory.

@ajcvickers @anpete Thank you for pointing me in a good direction. I will try it out at work tomorrow and let you know what I find.

@ajcvickers @anpete I believe it worked when a variable was declared and set to the entity. In the following instance there would not be an entity to detach and thus a connection will still persist.
dynamic result = new ExpandoObject();
using (var ctx = new CompanyDbContext())
			{
				result.employees = await ctx.Employees.Where(x => x.CompanyId == company_id && x.Active).CountAsync();
			}

I am thinking I will have to wait for the patch to be released and monitor production. The only other work around I can think of would be to set up a service that queries azure for any connection that has been quiet for 30 seconds and kill it.

@schwietertj You can enumerate all of the entities via DbContext.ChangeTracker.Entries()

@schwietertj are you saying that you are seeing database connections leaked? The original issue that was reported here and that was fixed and for which the workaround applies is about a memory leak and not related to database connections.

@divega Very good point. I have experienced both memory leaks and connections that should be disposed that are not being disposed of in the application.
After a request is made in the mvc project, I can look at the activity monitor in ssms and still see an active process. The process should not be active since the db context has been disposed.
I originally thought it was due to DI the db context. I removed the injection and refactored with the "using" statement.
Please correct me if I am wrong but the database connection should be closed after the using block has been executed.
If need be I can open a new issue if it is deemed to be a separate issue than this one.

@schwietertj It could be #6581 which causes some connections to be left open. It has been fixed for 1.0.2 (not yet released) and in 1.1.0-preview1. My understanding is that the workarounds for it are (a) enable MARS in the connection string and (b) avoid using Include() with collections and use multiple queries to retrieve the same data instead.
If you think that is not what you are hitting then yes please create a new issue.

@divega  I just tried enabling MARS and the connection count increased 8 fold per active user. We also have to use includes since lazy loading isn't implemented. Is there an ETA on the 1.0.2 release?

This patch is approved, please ensure it is merged into the correct branch and building as part of the patch train.

@rowanmiller I know this is an old thread, but about halfway through you ask:

Are you running in release mode?
Does running in debug mode cause some sort of known memory leak?  I'm trying to track down an EF memory leak and am grasping at straws.

@joshmouch No known issue like that,


Dual-stack support on IPv6 EKS Cluster

Is this the right place to submit this?

[X] This is not a security vulnerability or a crashing bug
[X] This is not a question about how to use Istio

Bug Description
We've installed Istio 1.17.2 on an IPv6 EKS cluster, but noticed that the envoy sidecar is only binding to [::] and not <IP_ADDRESS>, which means that any requests from the pod to an IPv4 address result in a Connection Refused error.  We can work around this by using the traffic.sidecar.istio.io/excludeOutboundIPRanges annotation, but then we lose the ability to control/inspect IPv4 traffic and use the mesh.
We've tried to enable dual-stack by following the directions from the blog post, but it does not seem to have the right effect - we still only see istio-proxy binding to [::].
Note that with EKS, only IPv6 addresses are advertised to the control plane - the IPv4 addresses are in a private 169.154 range, with a NAT at the node level (details here)
This seems to be related to this code; where link-local addresses are excluded from being added to the map (to address https://github.com/istio/istio/issues/36961), but that was before Istio dual-stack was available.
We can work around this by adding the traffic.sidecar.istio.io/excludeOutboundIPRanges annotation, but that means we lose the ability to control/inspect IPv4 traffic, which is desirable in our case; since we are accessing legacy IPv4 endpoints and services.
Istio configmap:
  mesh: |-
    defaultConfig:
      discoveryAddress: istiod.istio-system.svc:15012
      proxyMetadata:
        ISTIO_AGENT_DUAL_STACK: "true"
      tracing:
        zipkin:
          address: zipkin.istio-system:9411
    enablePrometheusMerge: true
    rootNamespace: istio-system
    trustDomain: cluster.local
  meshNetworks: 'networks: {}'

IP addresses:
1: lo: <LOOPBACK,UP,LOWER_UP> mtu 65536 qdisc noqueue state UNKNOWN group default qlen 1000
  link/loopback 00:00:00:00:00:00 brd 00:00:00:00:00:00
  inet <IP_ADDRESS>/8 scope host lo
     valid_lft forever preferred_lft forever
  inet6 ::6/128 scope global
     valid_lft forever preferred_lft forever
  inet6 ::1/128 scope host
     valid_lft forever preferred_lft forever
3: eth0@if95: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 9001 qdisc noqueue state UP group default
  link/ether 22:44:a4:30:ce:f1 brd ff:ff:ff:ff:ff:ff link-netnsid 0
  inet6 2600:1f10:4457:c303:af67::7/128 scope global
     valid_lft forever preferred_lft forever
  inet6 fe80::2044:a4ff:fe30:cef1/64 scope link
     valid_lft forever preferred_lft forever
5: v4if0@if96: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 9001 qdisc noqueue state UP group default
  link/ether de:62:7d:69:0f:7e brd ff:ff:ff:ff:ff:ff link-netnsid 0
  inet <IP_ADDRESS>/22 brd <IP_ADDRESS> scope global v4if0
     valid_lft forever preferred_lft forever
  inet6 fe80::dc62:7dff:fe69:f7e/64 scope link
     valid_lft forever preferred_lft forever
     ```

     podspec:
     ```  phase: Running
podIP: 2600:1f10:4457:c303:af67::7
podIPs:
- ip: 2600:1f10:4457:c303:af67::7

logs: Proxy role	ips=[2600:1f10:4457:c303:af67::7] type=sidecar
cc @abasitt (thanks for the chat over Slack!)
Version
% istioctl version
client version: 1.17.3
control plane version: 1.17.2
data plane version: 1.17.2 (11 proxies)

% kubectl version --short
Client Version: v1.27.2
Kustomize Version: v5.0.1
Server Version: v1.26.4-eks-0a21954

Additional Information
No response
Affected product area

[ ] Ambient
[ ] Docs
[ ] Installation
[X] Networking
[ ] Performance and Scalability
[ ] Extensions and Telemetry
[ ] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure
[ ] Upgrade
[ ] Multi Cluster
[ ] Virtual Machine
[ ] Control Plane Revisions

@zhlsunshine @jacob-delgado any ideas on this, or anything else I can capture to help?

FWIW, the istio-proxy sidecar contain does allow IPv4 egress, but blocks any IPv4 egress from the app pods. Amazon EKS IPv6 is a single stack, Pods and services receive IPv6 address. Along with routable IPv6 address, Pods also receive host-local non routable IPv4 address to support egress IPv4.

@sheetaljoshi I am not sure if i got it fully, do you mean even if there is a fix to route the ipv4 addresses from link-local subnet via istio-proxy, it won't work ?
Second question if you can answer will be great is that does EKS always use a fix interface number for IPv4 vif ? e.g. is it always going to be if96 ?

We had kind of similar requirements to exclude IPv4 interfaces from a single-stack IPv6 cluster, the feature is merged here
this is useful if you know e.g. if96 could be exclude or not just incase someone wants to exclude and run Istio in IPv6 only mode and may be someone prefer to run istio in dual stack mode because dual stack support is coming. It's more friendly in term of picking up on choices. But this will still not solve this issue because currently link-local addresses are hard-coded to be ignored.
There are folks who are currently running IPv6 EKS cluster, reverting on ignoring link-local addresses will be a breaking change for these clusters. IMO IPv6 deployments are not that common, so it may be worth to consider reverting back and mention in the release notes to opt-in for ignoring interface option.

@abasitt

Amazon EKS uses a fixed interface number for IPv4 "v4if0" on IPv6 clusters and on IPv4 to support IPv6 egress you will see "v6if0".

@sheetaljoshi I am not sure if i got it fully, do you mean even if there is a fix to route the ipv4 addresses from link-local subnet via istio-proxy, it won't work ? Second question if you can answer will be great is that does EKS always use a fix interface number for IPv4 vif ? e.g. is it always going to be if96 ?

Sorry for not being clear, the fix might just work to route IPv4 address from link-local subnet (<IP_ADDRESS>.172.0/22), and the interface are standard on every pod v4if0 https://github.com/aws/amazon-vpc-cni-k8s/blob/master/cmd/egress-cni-plugin/netconf.go#L29 .

Hi @andrewjamesbrown, I noticed that you pointed out the root cause code here, however, it should be no business with dual stack things, it's about golang library change for IP parsing. The PR should be this one: https://github.com/istio/istio/pull/41341.
And I doubt that the link-local addresses should be in the format of IPv4-mapped IPv6 address.
So could you print out the exactly link-local addresses in the log?

fixed by https://github.com/istio/istio/pull/46016.

I see the PR got reverted pretty fast :D
I totally appreciate the gate feature for istio stability. As commented on the PR, it doesn't enable DS but it was more towards streamlining towards excluding interface and remove the hard coded logic of ignoring link-local address. The challenges with current implementation.

EKS secondary interface is ignored because it has a link-local address but it doesn't completely remove it from the iptables logic, so the users still have to include <IP_ADDRESS> in the exclude iprange.
Because we ignore link-local, if the user wants to use dual-stack, even after installing DS profile, it doesn't work because the proxy will start in singlestack mode.
New users struggles because its not documented if we ignore link-local addresses. If this is the direction, we should document it and I am happy to create an issue on AWS side to consider moving away from link-local to routable unicast address. But in my understanding link-local is a valid address to be considered for DS.

How this PR will be helpful.

provide one single option with exclude interface. This does impact the existing user e.g. the current users have to add new annotation of exclude interface and remove the old annotation exclude iprange.
It provides the flexibility to those users who don't want to exclude ipv4 link-local interface and want to use dualstack profile

@ilrudie @kdorosh If i understand correctly, the approach should be to not touch existing logic. Only add the logic of not ignoring link-local address if someone trying to deploy dualstack profile ?
I am hoping once DS reaches stable state, we shouldn't need proxy detection logic and DS should be default for everything.

@abasitt this PR was impacting single stack IPv6 deployments. Link local is also available for IPv6 single stack clusters as well right.
Port 15021 wasn't getting a bind (along with some other ports I suspect) hence the kubelet (CP) wasnt able to run health checks and was causing all sorts of unintended behaviour. With this PR, 15021 was binding to <IP_ADDRESS> instead of ::.
I fully agree that DS should be gated particularly because its still very much in experimental phase.

Back to OP's case of IPv4 egress traffic in a IPv6 single stack cluster on EKS there may be a work around by binding 15001 to the secondary inf. This means that both tcp4 and tcp6 traffic will be serviced via 15001.
Envoy includes ipv4_compat for socket addresses (which allows multi binds) but i dont think this is something Istio currently provides.

To my mind feature gate for this logic is desirable since opting into dual stack during the experimental phase means accepting risk of instability. It's more acceptable to break the existing experimental use cases and require modifying config.
If folks who aren't accepting experimental risk would be impacted by a change it should necessitate a higher level of scrutiny for the PR.

Also, FWIW I am sympathetic to the need to be able to proxy egress to IPv4 addresses in SS IPv6 environments and I'm not blanket opposed to solutions which do not impact existing uses.

I see the PR got reverted pretty fast :D I totally appreciate the gate feature for istio stability. As commented on the PR, it doesn't enable DS but it was more towards streamlining towards excluding interface and remove the hard coded logic of ignoring link-local address. The challenges with current implementation.

Please dont be discouraged!

* EKS secondary interface is ignored because it has a link-local address but it doesn't completely remove it from the iptables logic, so the users still have to include <IP_ADDRESS> in the exclude iprange.

* Because we ignore link-local, if the user wants to use dual-stack, even after installing DS profile, it doesn't work because the proxy will start in singlestack mode.

* New users struggles because its not documented if we ignore link-local addresses. If this is the direction, we should document it and I am happy to create an issue on AWS side to consider moving away from link-local to routable unicast address. But in my understanding link-local is a valid address to be considered for DS.

How the PR was helpful.
* provide one single option with exclude interface. This does impact the existing user e.g. the current users have to add new annotation of exclude interface and remove the old annotation exclude iprange.

* It provides the flexibility to those users who don't want to exclude ipv4 link-local interface and want to use dualstack profile

@ilrudie @kdorosh If i understand correctly, the approach should be to not touch existing logic. Only add the logic of not ignoring link-local address if someone trying to deploy dualstack profile ? I am hoping once DS reaches stable state, we shouldn't need proxy detection logic and DS should be default for everything.

Correct, the key thing is not to impact/regress what is already working with single stack today. We want dual stack to be an opt in feature given it is still experimental atm.  longer term, when it is well tested and stable, we can change it to be default.

@abasitt would you be able to rework your reverted PR?

@linsun this is also impacting IPv6 only clusters on EKS.
On EKS each IPv6 pod gets assigned an IPv4 also from a private pool. When routing to outbound IPv4 endpoints this causes issues as pods only to bind to IPv6. We need a fix for this.
IMO we can track it in a separate ticket but in essence these tickets are related to EKS IPv6. Wdyt ?

@linsun thank you. I don't have an estimated time to rework on it ATM, i will unassigned myself and will pick it up if i get some bandwidth in future.

/subscribe

Hi @andrewjamesbrown, one more thing I want to point out is that the feature gate for both control and data plane are ISTIO_DUAL_STACK, ISTIO_AGENT_DUAL_STACK is already removed.

Hi @andrewjamesbrown, there are fixing for Dual Stack since 1.17, so have you tried the 1.19, and one more thing I want to point out is that the feature gate for both control and data plane are ISTIO_DUAL_STACK, ISTIO_AGENT_DUAL_STACK is already removed if using higher than 1.17.
Another question is that:
Why this code lead to the link-local addresses are excluded from being added to the map? Thanks!

@zhlsunshine here is the reason why link-local addresses are ignored.
here is the fix you can refer which works but reverted back because it doesn't have a gate.

@abasitt, https://github.com/istio/istio/pull/46800 seems relevant

Hi @abasitt sure, it will be great if you can have a try about it, thanks in advance!  As mentioned by @ilrudie, there should be some relevant with PR#46800

fyi https://github.com/istio/istio/pull/52733

Please correct me if I'm wrong because there are some istio features I'm not using, but we have been using EKS with IPv6 for most of 2024 at this point and I'll summarize a couple things useful to anyone wondering about the state of this ticket from my perspective:

It is not necessary to enable dual stack mode in istio.
You do need to enable pilot.env.ISTIO_ENABLE_IPV4_OUTBOUND_LISTENER_FOR_IPV6_CLUSTERS: true which removes the need for hacks like setting excludeIpRanges: <IP_ADDRESS>/0. This is the only real setting I have had to enable to get things working on EKS.
ServiceEntries to IPv4 addresses don't work until hopefully #52733 is released which was just merged.

I am using pilot.env.ENABLE_NATIVE_SIDECARS: true and haven't tried ambient mode.
Hope that helps someone out.

In not-very-thorough testing of ambient i have found almost everything works except DNS ServiceEntries which are fixed by https://github.com/istio/ztunnel/pull/1265

Please correct me if I'm wrong because there are some istio features I'm not using, but we have been using EKS with IPv6 for most of 2024 at this point and I'll summarize a couple things useful to anyone wondering about the state of this ticket from my perspective:

It is not necessary to enable dual stack mode in istio.
You do need to enable pilot.env.ISTIO_ENABLE_IPV4_OUTBOUND_LISTENER_FOR_IPV6_CLUSTERS: true which removes the need for hacks like setting excludeIpRanges: <IP_ADDRESS>/0. This is the only real setting I have had to enable to get things working on EKS.
ServiceEntries to IPv4 addresses don't work until hopefully Fix upstream DNS for AWS ipv4 link local #52733 is released which was just merged.
I'm also still applying a patch to the managed AMI to deal with istioctl proxy-config does not work on EKS IPv6 clusters #49496 (comment).

At the time of writing I'm using istio 1.22.3 in a single cluster with pilot.env.ENABLE_NATIVE_SIDECARS: true and haven't tried ambient mode.
Hope that helps someone out.

looks like a good summary. thanks @howardjohn for looking into this.


[ADH-4366] Generate web-server endpoints layer from new API specification

Moved OpenAPI specifications from #23 to smart-web-server module
Added web-server-codegen maven profile for (re-)generation of the web-server endpoints layer code and generated files for the current version of the API specification
Fixed issues with deepObject request parameter object serialization style unsupported by spring openapi generator
Removed unused endpoints implementing the old zeppelin API

@arenadata/java


Enable passing extra template paths [continued]

This is #696 continuation...
@hackebrot sorry, I made a mess trying to bring #696 up to date with master and I ended up with a new PR.
(I am still not sure if somehow I could have just updated the branch to mantain the same PR)

Thank you @dajose! I will have a look as soon as I have some free time. 🙇

@dajose I think you need to fix the conflicts first 👍

Codecov Report

Merging #837 into master will not change coverage.
The diff coverage is 100%.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d508f8d...04008d0. Read the comment docs.

@theodesp done

Cool, could you PM the rest of the team on Gitter about your progress? 👍
https://gitter.im/audreyr/cookiecutter

@michaeljoseph thanks for the feedback, changes applied :)


[Excel] (Custom Functions) Update requirements

This has the changes that were previously committed and reverted so it can be reviewed.

OPS Build status updates of commit bee5a68:
:clock10: Preparing: average preparing time is 44 sec(s)

OPS Build status updates of commit bee5a68:
:clock10: Incremental building: average incremental building time is 29 sec(s)

OPS Build status updates of commit bee5a68:
:white_check_mark: Validation status: passed
For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

I don't think so. @Keyur<EMAIL_ADDRESS>Can you verify?

From: Michelle Scharlock<EMAIL_ADDRESS>Sent: Thursday, February 21, 2019 10:02 AM
To: OfficeDev/office-js-docs-pr
Cc: Adam Krantz; Mention
Subject: Re: [OfficeDev/office-js-docs-pr] [Excel] (Custom Functions) Update requirements (#767)
Quick q: Does the 32-bit problem we had in Dec no longer exist? Just curious because I hadn't heard any change on it. @keyur32https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fkeyur32&data=02|01|adam.krantz%40microsoft.com|f80d4b82b90b4447621408d69826c384|72f988bf86f141af91ab2d7cd011db47|1|0|636863689589272438&sdata=mXK87k7qVYy4dL85BMJx%2BHh%2F2yj%2FeR%2BlzG6gLNSGbwU%3D&reserved=0 @akrantzhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fakrantz&data=02|01|adam.krantz%40microsoft.com|f80d4b82b90b4447621408d69826c384|72f988bf86f141af91ab2d7cd011db47|1|0|636863689589282433&sdata=Tcu81exFrP0jfE9rbGjmiUavIyyeW83XlOERpc9IYL0%3D&reserved=0 @davidchesnuthttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fdavidchesnut&data=02|01|adam.krantz%40microsoft.com|f80d4b82b90b4447621408d69826c384|72f988bf86f141af91ab2d7cd011db47|1|0|636863689589282433&sdata=7J86vSqOZBmtOWiZ25t4oOtpADB0mchTzcC%2FNoNyHQ8%3D&reserved=0
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FOfficeDev%2Foffice-js-docs-pr%2Fpull%2F767%23issuecomment-466102296&data=02|01|adam.krantz%40microsoft.com|f80d4b82b90b4447621408d69826c384|72f988bf86f141af91ab2d7cd011db47|1|0|636863689589292431&sdata=HhpVkgf0N8YkfsCm4XfUmjunpORPtCT0NbrF6r86dLU%3D&reserved=0, or mute the threadhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAAtPIX8n1ROBwT4AQrIzwLUxfBbf4zJOks5vPt87gaJpZM4bESms&data=02|01|adam.krantz%40microsoft.com|f80d4b82b90b4447621408d69826c384|72f988bf86f141af91ab2d7cd011db47|1|0|636863689589292431&sdata=3nCE8JYTfDwTli5FoELpndXIprU9bYOzIiSJ6FWgcds%3D&reserved=0.

Yea it was fixed in January; we have other bugs now
Get Outlook for iOShttps://aka.ms/o0ukef

From: Adam Krantz
Sent: Thursday, February 21, 2019 10:39:16 AM
To: OfficeDev/office-js-docs-pr; OfficeDev/office-js-docs-pr; Keyur Patel
Cc: Mention
Subject: Re: [OfficeDev/office-js-docs-pr] [Excel] (Custom Functions) Update requirements (#767)
I don't think so. @Keyur<EMAIL_ADDRESS>Can you verify?

From: Michelle Scharlock<EMAIL_ADDRESS>Sent: Thursday, February 21, 2019 10:02 AM
To: OfficeDev/office-js-docs-pr
Cc: Adam Krantz; Mention
Subject: Re: [OfficeDev/office-js-docs-pr] [Excel] (Custom Functions) Update requirements (#767)
Quick q: Does the 32-bit problem we had in Dec no longer exist? Just curious because I hadn't heard any change on it. @keyur32https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fkeyur32&data=04|01|kepatel%40microsoft.com|22605e2f38d24c71c70008d6982be227|72f988bf86f141af91ab2d7cd011db47|1|0|636863711612636672|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|-1&sdata=iwV8CtGO9ePjrR2Hj7KnD4no7uGBUEV5TBPxOD%2BBCMg%3D&reserved=0 @akrantzhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fakrantz&data=04|01|kepatel%40microsoft.com|22605e2f38d24c71c70008d6982be227|72f988bf86f141af91ab2d7cd011db47|1|0|636863711612636672|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|-1&sdata=PKWdEVEkeh4Uq%2BYWNJf6OS5jLD49jymb75r9svOdYIo%3D&reserved=0 @davidchesnuthttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fdavidchesnut&data=04|01|kepatel%40microsoft.com|22605e2f38d24c71c70008d6982be227|72f988bf86f141af91ab2d7cd011db47|1|0|636863711612636672|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|-1&sdata=qoYCL2DZ59pAhM68vMWTeUwy1%2FuAmdAsiYlCG9cFQXA%3D&reserved=0
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FOfficeDev%2Foffice-js-docs-pr%2Fpull%2F767%23issuecomment-466102296&data=04|01|kepatel%40microsoft.com|22605e2f38d24c71c70008d6982be227|72f988bf86f141af91ab2d7cd011db47|1|0|636863711612636672|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|-1&sdata=LQzYeOYGZwrAUYqMHqrigr3%2FU7AHXkfDNu6d1iLWYaw%3D&reserved=0, or mute the threadhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAAtPIX8n1ROBwT4AQrIzwLUxfBbf4zJOks5vPt87gaJpZM4bESms&data=04|01|kepatel%40microsoft.com|22605e2f38d24c71c70008d6982be227|72f988bf86f141af91ab2d7cd011db47|1|0|636863711612636672|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|-1&sdata=tSY9LgAxctoWIwh9gyZM5vkicDJycfhHPcpON3LtMAI%3D&reserved=0.

@akrantz can you restore Keyur's changes? Based on conversation with Keyur those changes were valid. I think we should accept them. Thanks!

I don't think this is no longer needed given we're getting ready for GA and this requirement won't hold there.

CLosing


Replace scrollTo to scrollIntoView

@PysarenkoDS-BWT I fixed the frontend tests, please make sure that your tests are passing and update the snapshots if necessary by running yarn test -u

@PysarenkoDS-BWT the changes look good, but can you explain a bit why this change is needed in the description?

@ericboucher

yarn test

All tests passed


Don't run xds_end2end_test on iOS

Fixes #20755

This PR should not have been necessary.  The problem should have been fixed by #20701.

@markdroth xds_end2end_test_on_ios segfaults with the latest code. We can revert this PR once the test issues have been fixed.

The description of this PR says that it fixes #20755, which should actually be fixed by #20701.  If there's a separate segfault problem, can you please file a separate bug about that?

I think there were multiple issues with xds_end2end_test_on_ios.
#20775. Test fails with Failed to import biplist module.
The  'Failed to import biplist module' error seems to have been fixed in the latest code (by #20701 ?)
But now, I see a new failure:
Test Case '-[GTMGoogleTestRunner UsesXdsResolver/BasicTest::Vanilla/0]' started.
Child process terminated with signal 11: Segmentation fault

I have filed #20788 to track this new failure.


Release 3.10.0 incompatible with PHP 7.0

I just installed the latest version (3.10.0) in my Laravel 5.5 project. I run PHP 7.0.30-0+deb9u1
The error during installation is:
Your requirements could not be resolved to an installable set of packages.

  Problem 1
    - nunomaduro/collision v3.0.1 requires php ^7.1 -> your PHP version (7.0.30) does not satisfy that requirement.
    - nunomaduro/collision v3.0.0 requires php ^7.1 -> your PHP version (7.0.30) does not satisfy that requirement.
    - mpociot/laravel-apidoc-generator 3.10.0 requires nunomaduro/collision ^3.0 -> satisfiable by nunomaduro/collision[v3.0.0, v3.0.1].
    - Installation request for mpociot/laravel-apidoc-generator ^3.10 -> satisfiable by mpociot/laravel-apidoc-generator[3.10.0].

The installation of the previous version works as expected: composer require --dev mpociot/laravel-apidoc-generator:3.9.0
The docs state that it requires PHP 7.
This should be updated to 7.1 for the latest version or maybe there is a way to provide the same functionality without requiring PHP 7.1?

For now, the package can be used on 7.0. I'll tag a new release soon, but
dev-master should work.
On Fri, 9 Aug 2019, 11:30 Robin Ambrosius<EMAIL_ADDRESS>wrote:

I just installed the latest version (3.10.0) in my Laravel 5.5 project. I
run PHP 7.0.30-0+deb9u1
The error during installation is:
Your requirements could not be resolved to an installable set of packages.
Problem 1
- nunomaduro/collision v3.0.1 requires php ^7.1 -> your PHP version (7.0.30) does not satisfy that requirement.
- nunomaduro/collision v3.0.0 requires php ^7.1 -> your PHP version (7.0.30) does not satisfy that requirement.
- mpociot/laravel-apidoc-generator 3.10.0 requires nunomaduro/collision ^3.0 -> satisfiable by nunomaduro/collision[v3.0.0, v3.0.1].
- Installation request for mpociot/laravel-apidoc-generator ^3.10 -> satisfiable by mpociot/laravel-apidoc-generator[3.10.0].
The installation of the previous version works as expected: composer
require --dev mpociot/laravel-apidoc-generator:3.9.0
The docs state that it requires PHP 7.
This should be updated to 7.1 for the latest version or maybe there is a
way to provide the same functionality without requiring PHP 7.1?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/mpociot/laravel-apidoc-generator/issues/550?email_source=notifications&email_token=ADNSD4OGXW6T2T36AJXBM5LQDVBNDA5CNFSM4IKSXUXKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4HELWLTQ,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ADNSD4LPGTJSGWYOOCM2AOLQDVBNDANCNFSM4IKSXUXA
.

Tagged 3.11.0 https://github.com/mpociot/laravel-apidoc-generator/releases/tag/3.11.0

@shalvah awesome, thanks for the quick reply and fix. Just tested the installation and works like a charm.


React Particle js width and height incorrect scaling with Transitions

This is an issue I face with using react-particle-js in mobile responsive view. The width and height set to the screens width and height initially. But on transitioning to another page and coming back, the width and height becomes double the screens width and height making the particle js animation look bad.

Maybe you want to open an issue on the right library https://github.com/Wufe/react-particles-js

Oh ok thank you


Update a-msds-additionaldnshostname.md

description of purpose and sizes is outdated. it can be used for all computers, and it can be longer.

@HerbertMauerer : Thanks for your contribution! The author(s) have been notified to review your proposed change.

Thanks for your contribution @TODO.  I've merged your changes and they should be live soon.


fix typo

Thanks :)

I'm not sure why the build failed here. Maybe I merged too quickly and should have waited for the build here to complete before merging. Anyway, it's not too important as the build worked on master.


Music Library Support

im sure i could but the biggest problem is I don't use plex for music so I don't really have much testing capabilities there but make an issue requesting it and ill try to get to it
Originally posted by @meisnate12 in https://github.com/meisnate12/Plex-Meta-Manager/discussions/188#discussioncomment-582758

Hey @meisnate12 - I just had to manually add sharing labels to a bunch of stuff in music library today and started thinking about this again.
I see you added a prio someday label 9 days ago, I assume that means it's on the backburner for now?

yea it kinda is especially since you can do most collection via smart collections bbut i guess you want it so you can use PMM to add labels?

Yeah, I personally don't really need collections for music... I mean I guess I could do genre collections, but I care more about labels for sharing purposes. Currently I have all my users locked behind different labels, so if the content doesn't have a label then by default only I can view it.

+1 to this! I can help with providing a library to test on

I have a new use case for needing music library support. I have all the music I want synced to my phone in a collection, so being able to back that collection up would be extremely beneficial.

im gonna try and get this in 1.13.0

ok so not quite 1.13.0 but i just added it to the develop branch for testing to be released in the 1.15.0 release the only builders that work with it are plex_all, plex_search, smart_filter and filters


misc/ntp.yml doesn't update all ntp properties

After the change in 90f463c it looks like cloud_provider/properties/ntp and instance_groups/0/properties/ntp  blocks are not updated. After some discussion on Slack it looks like these to blocks shouldn't exist anymore and that the accepted way of setting the NTP servers is in the agent and the resource pool which are not even set in bosh.yml.
The ops file seems to be doing the correct thing to override the NTP servers if we need to provide our own NTP servers.

I made a commit that looks to resolve the inconsistency, https://github.com/cloudfoundry/bosh-deployment/commit/6bd09baed15fe6aa6ce3a7a7fd0ff7228ad26627.
Closing this issue.
Thanks for opening an issue on this!

Aakash


Consolidating general bounding box operations

Change Description
This PR moves existing bounding box code spread across different classes in the presidio-image-redactor module into one class. This new BboxProcessor class can also be used independently during evaluation, as specified in the updated documentation.
Summary of Changes

Existing, general bounding box operations have been consolidated into BboxProcessor
Existing tests for general bounding box operations have been moved into presidio-image-redactor/tests/test_bbox.py (no new tests have been added)
ImageRedactorEngine, DicomImageRedactorEngine, and DicomImagePiiVerifyEngine and their tests have been updated to call bounding box operations from BboxProcessor
Updated evaluation documentation to call bounding box operations from BboxProcessor

Issue reference
This PR fixes issue #996
Checklist

[x] I have reviewed the contribution guidelines
[ ] I have signed the CLA (if required)
[x] My code includes unit tests
[x] All unit tests and lint checks pass locally
[x] My PR contains documentation updates / additions if required

All tests pass locally, but there seems to be an import error when running the build pipeline. Pipeline failure can be seen here.
@omri374 , @SharonHart - Do either of you know why presidio-image-redactor/__init__.py would fail to load bbox.BboxProcessor?

All tests pass locally, but there seems to be an import error when running the build pipeline. Pipeline failure can be seen here.
@omri374 , @SharonHart - Do either of you know why presidio-image-redactor/presidio_image_redactor/__init__.py would fail to load bbox.BboxProcessor?

I don't see an BboxProcessor file, missed committing it?

Thanks @niwilso! This is a great improvement for the codebase.
As this package evolves and matures, I think we should consider architecting it in a way that would support further customization and analysis and wanted to get your and @SharonHart's thoughts. My initial suggestion is to have a base class for image analysis and redaction, and an inheriting class for dicom image analysis and redaction.
Each class would initially have three methods:

redact
validate
analyze

The redact and validate would be the same as the ImageRedactorEngine and ImageVerifyEngine. The analyze method would return all bounding boxes with their text analysis results. This would facilitate further debugging.
This is definitely not for this PR, and might not be doable or easy, so please provide your feedback and we can also have a quick call to further discuss this if needed.

Thanks @niwilso! This is a great improvement for the codebase.
As this package evolves and matures, I think we should consider architecting it in a way that would support further customization and analysis and wanted to get your and @SharonHart's thoughts. My initial suggestion is to have a base class for image analysis and redaction, and an inheriting class for dicom image analysis and redaction. Each class would initially have three methods:

redact
validate
analyze

The redact and validate would be the same as the ImageRedactorEngine and ImageVerifyEngine. The analyze method would return all bounding boxes with their text analysis results. This would facilitate further debugging, and can also plug into improvements in the demo website that Sharon is currently working on (in future releases)
This is definitely not for this PR, and might not be doable or easy, so please provide your feedback and we can also have a quick call to further discuss this if needed.

Yes, I think it makes sense to consolidate as you suggested. I think it would also be great to have "evaluate" as one of the required public methods (already exists for the DICOM engines but would need to be added for the standard image engine).
My only concerns would be around backwards compatibility and having really large classes.
I'm happy to discuss this over a call as well. I've gone ahead and made an issue for this to handle in the future: https://github.com/microsoft/presidio/issues/1012

Thanks @niwilso! This is a great improvement for the codebase.
As this package evolves and matures, I think we should consider architecting it in a way that would support further customization and analysis and wanted to get your and @SharonHart's thoughts. My initial suggestion is to have a base class for image analysis and redaction, and an inheriting class for dicom image analysis and redaction. Each class would initially have three methods:

redact
validate
analyze

The redact and validate would be the same as the ImageRedactorEngine and ImageVerifyEngine. The analyze method would return all bounding boxes with their text analysis results. This would facilitate further debugging, and can also plug into improvements in the demo website that Sharon is currently working on (in future releases)
This is definitely not for this PR, and might not be doable or easy, so please provide your feedback and we can also have a quick call to further discuss this if needed.

I like this approach


Enhance Import Data to account for blank rows within the data

Currently, when an older Input Template has data, but there are blank rows scattered within, the Import Data (copy) routine will stop at the first blank row, preventing all data from being copied. The request is to ensure all rows are copied, even if blank rows exist.

The Import Data feature will now ensure all rows (up to row 200) on each relevant sheet are copied to the new template. It is slightly slower as a result, but only by a couple of seconds.
This has been added to v20230604.


Can you provide training time and the GPU spec for running this project?

10 hrs, require 12GB gpu memory as minimum.


Duplicate Python versioning in Travis CI

Current in Travis we set:
    - os: linux
      python: 3.7
      env: PYTHON_VER=3.7

This will both build a conda env and use a system 3.7 python. There is no need to set the Python version I believe, we may want to set the name= variable instead so that the display is correct.
We might also want to unpin the xenial container.

This was fixed sometime ago.


How to disable strict mode with loader?

When a file is imported with strict mode enabled, the resolution fails.
eval('var x=__merge(x||window.x||{},{"soy":{"examples":{"thing":{}},"thing":{}}});var soy=__merge(soy||window.soy||{},{});var soydata=__merge(soydata||window.soydata||{},{});');

It looks like this line is executing correctly, however, when I try to assign soy on the very next line, an error is thrown because strict mode is prepended to the file via webpack.

Can you please provide some example code (before transformation via the loader) to reproduce this?


Have a look through github to see if the structure of epics, features and tasks is still correct

Have a look through github to see if the structure of epics, features and tasks is still correct
Inspired by Set a clear roadmap in Github based on our tasks in What do we want to try next?
Assigned to Diana Broeders<EMAIL_ADDRESS>Sprint 7 retrospective
https://sanoma.teamretro.com/teams/2V3kuUhdKkP6TBBRn90Rcb

I made a proposal for the "rules":
https://confluence.sanomalearning.com/display/SUD/Github+project+structure
This is of course a living document
Still to be discussed with the whole team. We will do this in the next refinement


charts/multinode: fixed auth on newer images(#341)

At the current state, the multinode chart don't work with any recent image because they are configured in order to allow connection only from localhost, and this obviusly break any multinode configuration (#341).
The approach to solve this problem is similar to #311 , but instead of allowing every IP of the cluster without any authentication, this PR will allow md5 authentication, in the same way older images does. This approach has the advantage that works with any configuration and doesn't require extra configuration in values.yaml file.

Great! Works as expected. LGTM ?!


Compatibility with Python 3.8

…which breaks asynctest, but provides its own async unittest class.
These are minimal changes to make it work again.

Thanks for the input! I've merged it differently as part of #23, adopting most of your approach ;)


Fix Cache Errors

Delete cache if error occurs.
Located inside of onerror because every potential invocation involves the cache in some way.
rimraf is sync because I need to make sure the cache is deleted before err is throw
Ideal behavior would be to restart the download but i don't want to risk an infinite loop, this is just a quick / dirty fix.

The previous behavior was to unzip assuming file is downloaded, nugget will continue an incomplete download so it needs to be called every-time. If download is half complete then it should resume where it left off.

Also updated the readme to let people know where zips are stored
There is a slight regression because internet access is always required now,  but I suppose there are very few cases where someone would download this library without internet...

@RnbWd hey sorry I just saw this PR after pushing a change just now.
I just factored out the zip downloading/caching into https://github.com/maxogden/electron-download so that it can be shared between this module and https://github.com/maxogden/electron-packager/
I think we should wait to hear what @mafintosh thinks about the caching/failure behavior. This PR will have to be re-done to electron-download. Sorry for the inconvenience!

oh LOL I just saw this comment https://github.com/mafintosh/electron-prebuilt/issues/25#issuecomment-100696804

I haven't started yet, no worries!!

I actually really like your implementation, especially the separation of electron-download into another repo.


Make major release

A lot has happened since the previous release and a new one might be sensible!
Issues that should be solved before a new release:

[x] Fix Haddock. Some Documentation does not render properly. (@fendor, closed by #89)
[ ] Document changes and new features or make sure features are properly documented. #58 (@mpickering and @fendor)
[x] Regularise the API, #83 (@mpickering, supported by @fendor) Fixed in #87
[x] Don't use stdout to communicate arguments #90 (@mpickering)
[x] Add project loading tests (@mpickering and @fendor) #91
[x] Command check fails on hie-bios. #93
[x] Fix fixImportDirs #95
Issues that could be in the next release:
[x] Parser fails when cabal runs configure in v2-repl #84 (Fixed in #90)

Changes to the stack cradle before merge (EDITED: 26.11.2019)

[x] Call --compiler-exe before running stack repl
[x] By default don't pass a path to stack repl
[x] Add an optional component like the cabal cradle
[x] Do some simple parsing of the ghci script file to find the initial targets

@fendor Do you want me to deal with all these subtasks?

No, I would like to take on the haddock tasks, and help with documentation.

Project loading tests in #91

The only task left here seems to be the documentation checking.

Updates task list!

I made #96 for the changes to the stack cradle as well.

All these tasks are complete, so we are ready to do a release?

Two last tasks:

[ ] Updating the README (it promostes a cradle: cradle: { stack } which no longer works) (@fendor)
[ ] Decrease the cabal-version. (@fendor)


Allow to add custom usings in generated code.

Hello, I met a problem as i'm trying to generate code for NET3.5 and netstandard for Diagnostics.Tracing but in NET3.5 I have Microsoft.Diagnostics.Tracing and for netstandard it's System.Diagnostics.Tracing.
I don't know if there is a way so that the generator get the targetFramework or if I could add some using to my generated class.

@bhugot I'm currently using this workaroung:
var clientsNamespace = NamespaceDeclaration(ParseName("Clients"))
	.AddUsings(
		GetUsingDirectiveSyntax("System"),
		GetUsingDirectiveSyntax("System.Collections.Generic"),
		GetUsingDirectiveSyntax("System.Threading.Tasks"))
	.AddMembers(clientClass);

return Task.FromResult(List<MemberDeclarationSyntax>().Add(clientsNamespace));

It adds additional namespace but it's ok in my case. Probably, it helps you.

@Pzixel Thanks found another way to do it for my case.

@bhugot then, please, share it? :) Maybe it would fit me better.

I just use fullName for each class.

#80 resolved this.


Fix columnsSlice dependency on Redux

Description
The functionality of the layout to resize is controlled with a slice in the Redux state (columnSlice). Since we no longer use Redux, we must change this functionality or adapt it to be handled with Zustand.
Related
Migrate to Zustand

Just a tip, to reference another issue/PR you can use a hashtag followed by the issue number like this:
#1
This links to the issue, and the you can also specify the repository like so:
HyperloopUPV-H8/h9-backend#1


Base container off of already built container

Maybe this needs a registry, much like docker, could be in the new Command center?
Some of the operations when building containers sometimes takes alot of time. (Installing alot of packages, running pip install -r requirements.txt, followed by npm etc. Minimizing js, css etc.) This is sometimes a problem, developers complaining on stuff taking alot of time to deploy to staging or production etc. One way of greatly speeding this up would be to base it of an already built container.
There are a two main ways of accomplishing this as I see it.

Specify a base uuid in the TredlyFile - This could be downloaded from the tredly command center if not already on the host.

If deploying to the same tredly-host, clone the current container to a new container and run update commands there. This would probably need a variable, maybe cloneCurrent=boolean value.

If you do not have the manpower or if you lowly prioritize this please let me know in which subprojects of tredly and perhaps even files I would have to look into to write this functionality. I would gladly submit a PR for this.

Thanks for the suggestion. As it happens, the ability to move and clone existing containers is something we are working on solving already and has been earmarked for our 1.0 release, which is not far off.


Prepare Svelte Flow launch blog post on xyflow.com

Working Branch: https://github.com/xyflow/web/tree/blog/svelte-launch
To do

[ ] make fitview work for examples in blog post, currently they start with 0,0 at top-left corner of canvas @peterkogo
[ ] Create complex-ish example for "...and beyond" section @peterkogo
[ ] Create nice example for intro of post @peterkogo
[x] Get hello-world example to appear (currently throws 404, https://xyflow-svelte-examples.vercel.app/blog/svelte-launch/hello-world, does it need to be somehow "uploaded" to vercel or something to work?)
[x] make copy-text on blog posts look prettier (play with leading, spacing, font size. Use Medium as a reference)

@johnrobbjr this seems to be done? https://www.xyflow.com/blog/svelte-flow-launch


Feature/create basic tests

what can I do with main test?
what can be more added to cmd test?
do you need some package manager? i still use dep.

Fixes #1

I went ahead and took care of this and will the commits to yours. Thanks for the help @hero0926


Pick up files from S3 bucket

For  https://trello.com/c/kaWFjQlO

I suspect the next step is to use something like https://docs.python.org/3/library/tarfile.html to open up the tar.gz file (attached to the trello ticket) and read the data direct from that.


Use learningequality translationmapping

Summary
Hi @cpauya
We use now learningequality translationmapping for getting the dubbed videos map.

Nice one @mrpau-eduard!  Made my comments then this is good to go for me. 😸


Raise Guard exception with a fully qualified name

@akuzko updated commit name

Closing, since issue was related with mistakenly used version 0.2.0 instead of 1.0.0


Update nf-ntddk-pssetloadimagenotifyroutine.md

it would be better to use a number than word to understand.

Thanks @cssxn!


Alignment pipe (bwa+samblaster) is broken in bcbio1.0 when lumpy is specified for SV calling.

Hi,
I am testing bcbio version 1.0a ( this commit to be specific: https://github.com/chapmanb/bcbio-nextgen/commit/fb4a04b63638ba25af80557acab7e3ca1e6edfbd ) with the following yaml:
# Template for whole genome Illumina variant calling with FreeBayes
# This is a GATK-free pipeline without post-alignment BAM pre-processing
# (recalibration and realignment)
---
details:
  - analysis: variant2
    genome_build: my_reference
    description:
    # to do multi-sample variant calling, assign samples the same metadata / batch
    metadata:
      batch: project_123
    algorithm:
      aligner: bwa
      mark_duplicates: true
      recalibrate: false
      realign: false
      variantcaller: freebayes
      svcaller: lumpy
      nomap_split_targets: 3000
      effects: false
      tools_off:
      - gemini
      # for targetted projects, set the region
      # variant_regions: /path/to/your.bed
resources:
    freebayes:
        options: [--genotype-qualities, --min-mapping-quality 20]

This results in this error for me with two different sets of fastq files that I could previously process with bcbio version 0.9.9.
samblaster: Loaded 13 header sequence entries.
[fputs] Broken pipe
[E::sam_parse1] SEQ and QUAL are of different length
[W::sam_read1] parse error at line 19215
[bam_sort_core] truncated file. Aborting.
[W::sam_read1] parse error at line 6353
[bam_sort_core] truncated file. Aborting.
[W::sam_read1] parse error at line 321353
[main_samview] truncated file.
' returned non-zero exit status 1

Removing svcaller: lumpy from the yaml fixes this issue. I guess because of using another bwa pipe that does not use samblaster for the split to discordant + split bam.

Neill;
Sorry about the delay in responding to this. I've been working on getting a fix into a new bioconda package and the build system was down this week, so finally got a hopeful fix pushed.
We managed to get a reproducible segfault case for samblaster (GregoryFaust/samblaster#26) and Greg pushed a fixed version, 0.1.24. I hope that this will resolve this issue if you update in your installation:
bcbio_conda install -c bioconda samblaster

and then re-run the analysis. If this doesn't fix it for you please let us know and we can investigate further. Thanks again for reporting this.

Hi Brad. No worries, thank you for solving this issue / having this issue solved.
I can confirm that after updating samblaster the bwa+samblaster alignment pipe now works.
The errors are gone and I see .bam, -sr.bam and -disc.bam files being created.


Can't locate CorScorer.pm

Dear guys,
Thank you for your interesting works. I'm training the model for new language (Dutch) using the SoNars corpus. Due to the fact that SoNars was in MMAX, I used the modification of this script (https://github.com/andreasvc/dutchcoref/blob/master/mmaxconll.py) to convert it to CONLL format.
After that, I trained a word2vec model (to prepare the static_word_embeddings files), I still have no clue what tuned_word_embeddings are, but I just use exactly the same static_word_embeddings files and it seemed to worked. I modified the load_function and other related functions as stated in the tutorial for training new language. Everything went well until the training, I got this error:
Error during the scoring Command '['perl', 'c:\\users\\administrator\\desktop\\neural_coref\\neuralcoref\\neuralcoref\\train\\scorer_wrapper.pl', 'muc', 'c:\\users\\administrator\\desktop\\neural_coref\\neuralcoref\\neuralcoref\\train/data//key.txt', 'c:\\users\\administrator\\desktop\\neural_coref\\neuralcoref\\neuralcoref\\train\\test_mentions.txt']' returned non-zero exit status 2. Can't locate CorScorer.pm in @INC (you may need to install the CorScorer module) (@INC contains: scorer/lib /usr/lib/perl5/site_perl /usr/share/perl5/site_perl /usr/lib/perl5/vendor_perl /usr/share/perl5/vendor_perl /usr/lib/perl5/core_perl /usr/share/perl5/core_perl) at c:\users\administrator\desktop\neural_coref\neuralcoref\neuralcoref\train\scorer_wrapper.pl line 16. BEGIN failed--compilation aborted at c:\users\administrator\desktop\neural_coref\neuralcoref\neuralcoref\train\scorer_wrapper.pl line 16.
I could not find any information about the CorScorer.pm on anywhere on the internet. Can someone please help me to fix this? Am I doing anything wrong?

Hi @EricLe-dev, if you found a solution to your problem, could you please post it? This may help others who come here after googling a similar problem.

Hi @EricLe-dev!
We encountered the same error message. For us, the CorScorer.pm file was not present in our repo, it seems like the .gitignore excluded it for some reason.
Make sure that the lib directory is included in the neuralcoref/train/scorer directory, as can be seen hear:
https://github.com/huggingface/neuralcoref/tree/master/neuralcoref/train/scorer.
Hope it helps!
Emma, Caroline and Moa


feat(TresCanvas): add dpr prop

Problem
Tres sets the renderer's pixelRatio automatically, but doesn't allow the developer to specify or influence the value.
Solution
Add a :dpr prop to <TresCanvas /> that:

can be omitted, defaulting to current behavior.
can be number: overriding the system's pixelRatio.
can be [number, number], clamping the system's pixelRatio between the first (expected min) and second (expected max) values.

Playground
Playground demo added at:
http://localhost:5173/advanced/device-pixel-ratio
Meta
closes #765

You are awesome @andretchen0

just FYI, is missing on the docs https://docs.tresjs.org/api/tres-canvas.html

Left a new comment on the main thread https://github.com/Tresjs/tres/issues/765 so i easier to track


[hf parser] Add parser for text2Image

[hf parser] Add parser for text2Image
Copying a lot of what I did for the TextGeneration extension: https://github.com/lastmile-ai/aiconfig/tree/main/extensions/HuggingFaceTransformers
Referencing the API defined in

https://huggingface.co/docs/diffusers/v0.24.0/en/api/pipelines/auto_pipeline#diffusers.AutoPipelineForText2Image
https://huggingface.co/docs/diffusers/using-diffusers/conditional_image_generation

Holy omg these difusers take sooooooo long what the heck. The common options are Stable Diffusion v1.5 and Stable Diffusion XL: https://huggingface.co/docs/diffusers/using-diffusers/conditional_image_generation#popular-models
When using an inference count of 50 (default value), it took me about 5 mins for v1.5 and 20-25mins for XL. XL is noticeably better though:
| v1.5 Image | XL image |
|  |  |
General test plan showing how I tested this:
https://drive.google.com/file/d/1nHVtptrIPd9hxTgfCYBf1SiIgNnSvnpS/view?usp=sharing


Installing Google Plattform Tools via winget seems to not work as expected

Brief description of your issue
Installed Plattform tools (adb and fastboot) via winget as normal (winget install --id Google.PlatformTools). Restarted terminal.
Whenever I need to run these tools I try adb, and terminal isn't returning something at all, but, when I type winget adb it seems to work, but this isn't the normal way of work

Steps to reproduce

Open a Windows Terminal as admin
Install adb via winget (winget install --id Google.PlatformTools)
Restart Terminal
Try to run adb, it wont show anything unless you call winget first

Expected behavior
Type adb and use the application as a normal installation adding manually the tool to path
Actual behavior
Just runs when you write it as an argument after winget
i.e winget adb and prints Unrecognized command: 'adb' but eventually seems to work

Environment
Windows Package Manager v1.4.10173
Copyright (c) Microsoft Corporation. All rights reserved.

Windows: Windows.Desktop v10.0.22621.1555
System Architecture: X64
Package: Microsoft.DesktopAppInstaller v1.19.10173.0

Logs: %LOCALAPPDATA%\Packages\Microsoft.DesktopAppInstaller_8wekyb3d8bbwe\LocalState\DiagOutputDir

User Settings: %LOCALAPPDATA%\Packages\Microsoft.DesktopAppInstaller_8wekyb3d8bbwe\LocalState\settings.json

Links
---------------------------------------------------------------------------
Privacy Statement   https://aka.ms/winget-privacy
License Agreement   https://aka.ms/winget-license
Third Party Notices https://aka.ms/winget-3rdPartyNotice
Homepage            https://aka.ms/winget
Windows Store Terms https://www.microsoft.com/en-us/storedocs/terms-of-sale

I'm not sure what the expected output for these two portable packages is supposed to be.
What should the output from each portable package show?
Do they have any dependencies on anything?

The reason is that the executable depends on .dlls that are not available via symlink.
cc @denelon This can be transferred to the packages repo and marked with zip-binary

Blocked by https://github.com/microsoft/winget-cli/issues/2711


Add dependency in README.md for coreutils

Hi
I had a little issue using bountyplz at first as it seems coreutils is necessary on macOS to use realpath.
$ bountyplz bc awsog acuity.md
/usr/local/bin/bountyplz: line 3: realpath: command not found
usage: dirname path
/usr/local/bin/bountyplz: line 5: /.env: No such file or directory

It might be helpful to others to just mention this in the installation guide.
Thanks!

Thanks!


Cannot add more than one listener if its expressed as a lambda

I noticed this while implementing the framework listeners; doing the following does not add the second listener:
int count1(0);
int count2(0);
auto listener_callback_counter1 = [&count1](const FrameworkEvent& evt) { ++count1; std::cout << "listener_callback_counter1: call count " << count1 << std::endl; };
auto listener_callback_counter2 = [&count2](const FrameworkEvent& evt) { ++count2; std::cout << "listener_callback_counter2: call count " << count2 << std::endl; };
f->GetBundleContext()->AddFrameworkListener(listener_callback_counter1);
f->GetBundleContext()->AddFrameworkListener(listener_callback_counter2);

The same happens when adding bundle listeners.
In both cases the listener comparison functions in usServicveListeners.cpp returns true for the second listener as compared to the first.
If the std::bind flavor of AddBundleListener is used, there is no problem.
For users, it is normal to express std::function objects as lambdas and expect this to work.
It is difficult to compare the equality of std::function objects as evidenced by this stackoverflow thread.
We'll have to define what equality really means for listeners.

Some more info from further investigation...
Since std::function::target<void(const BundleEvent&)>() is used as one of the criteria to compare listeners for equality lambdas and callable objects created from std::bind will never be compared correctly because target<T>() will return a pointer only if the stored callable object is of type T, otherwise it returns nullptr. For lambdas and callable objects created from std::bind, the type is not void(const BundleEvent& ).
The only reason listeners created from std::bind can be added is because the pointer to the class instance is also used to compare the listeners. As long as two different class instance pointers are used the listeners aren't equal.

fixed in PR #179