citation in footnote

asciidoctor-bibliography don't seem to handle a citation inside a footnote, which is a rather common scenario

@pela9 apologies for the late response. Indeed it is something that we should allow.
@paolobrasolin would you have time to look into this? Thanks!

I've found a workaround. The problem arises because having inline macros of the standard form (e.g., xref:Anderson98[Anderson & Lebiere, 1998] inside footnotes gives Asciidoctor difficulties: nesting of square brackets seems to be a parsing challenge (or something.) This is the form of xref asciidoctor-bibliography uses, though, to establish the citations' links to the bibliography.
asciidoctor-bibtex had no trouble when citations were in footnotes; that's because it used the double-angle-bracket form of xref instead (e.g., <<Anderson04,Anderson et al., 2004>>). Asciidoctor has no parsing-difficulties when it finds this in footnotes, because it introduces no square brackets.
I've just finished writing and testing (somewhat) a patch of asciidoctor-bibliography that uses this double-angle-bracket form of the citation xrefs. On my test-file, it worked beautifully: It also did something that asciidoctor-bibtex could NOT do, which is support citations in quote-attributions in a quote-block style attribute-list (see User Manual https://asciidoctor.org/docs/user-manual/#quote ).
The question is, then, whether there is any reason not to use this double-angle-bracket form of xrefs: is there some situation(s) in which it is not as robust as the style that uses square brackets?
It actually takes very little code change to make this change (all in citation.rb). I could set up a PR if you're interested in testing it.

Some more notes:
Asciidoctor can handle nested builltin inline macros, but it seems that asciidoctor-bibliography (and asciidoctor-bibtex) can't handle a nested cite:[...] macro inside another, e.g.
footnote:[abc cite:[KEY]  def] is parsed as:  "footnote:[abc cite:[KEY]"   +   "def]"
(I actually use asciidoctor-bibtex and found initially the same problem there, which I have reported also on its issue list. I use asciidoctor for translation to docbook only, haven't checked if there is the same problem with other output formats).

Yes, good point. Asciidoctor does fine with nested square brackets when it's from an inline macro it recognizes and processes. The cite:[] "macro" though, is a cow from someone else's field. Not seeing it as a macro, Asciidoctor figures the footnote has ended, once it sees the first ]. Thus the parsing-anomalies.

Actually that's a bit over-simplified: When asciidoctor-bibliography is in use, Asciidoctor never has to parse a cite;[] "macro", because the extension has actually replaced all those--with Asciidoctor xref macros--by the time Asciidoctor starts parsing. However, as mentioned, asciidoctor is replacing the cite:[] "macros" with xref:target[] macros--which end with square brackets too. When Asciidoctor sees that, it says, "End of footnote."

Perhaps when asciidoctor-bibtex started out, it was using the square-bracket xrefs.

And you are correct that in the DocBook conversion, a non-escaped-bracket xref:targetID[citation-text] will get parsed as a link--but its closing square bracket and the rest of the footnote (including the created </link> endtag) get pushed out of the footnote. However, it's even worse with the HTML conversion: then, the xref doesn't get parsed at all; but remains in current form--except for those same bits which get pushed out of the footnote.

You can see my initial offering, in PR #81. There's an issue Travis-CI uncovered which I've followed up with a comment, and will look into further.

Travis-CI has, now, no substantive complaint: only two "errors", both amounting to, "We expected the square-bracketed xrefs, and you gave us angle-bracketed instead!!" But that's the whole point of the exercise ;)

Let me add that this is a dandy bibliography extension, IMHO. And this (two-line) emendation would make it, well, just terrific.

Another workaround I found is referencing the citation to make it appear in the bibliography and to reference it via an xref link:
:dumb_variable: cite[kent_beck_manifesto_2001]

Bla footnote:[Agile Manifesto (<<bibliography-default-kent_beck_manifesto_2001, Beck and al., 2001>>)

Thanks everybody for your initiative and thoughtful inputs.
I'm gonna recap the situation:

asciidoctor-bibliography citations do not work in footnotes (thanks @pela9 for reporting this),
this is caused by the fact that xrefs do not work in footnotes even in vanilla asciidoctor,
which in turn is caused by a non-trivial problem with the asciidoctor parser, see asciidoctor/asciidoctor#61.

At least three solutions exist.

Quoting the closing bracket of the citation macro within the footnote as suggested in https://github.com/asciidoctor/asciidoctor/issues/3251#issuecomment-494730499; this is too disruptive and needs much smarter parsing to work, as already stated.
Citing a key, tossing it away and manually writing the citation text as shown by @oncletom above; this is useful, but just as a manual workaround.
Letting asciidoctor-bibliography use the double angled bracket form while interpolating the cross-references as suggested by @andrewcarver. This is the winner IMO: it's using proper features of vanilla asciidoctor and after some testing I see no evidence of failure.

I'll clean up @andrewcarver's #81 (which implements 3) and merge it.

Just released v0.9.2 including this fix.

Many thanks, Paolo and Ronald!
On Wednesday, May 29, 2019, 10:46:52 AM MDT, Paolo Brasolin<EMAIL_ADDRESS>wrote:
Just released v0.9.2 including this fix.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.


add go net/url package support to cue

Is your feature request related to a problem? Please describe.
we can roll our own functions here (mostly), but again, not very intuitive for future end users
Describe the solution you'd like
As simple as it sounds, in Go the net/url package provides most importantly for me both the
PathEscape  and
QueryEscape functions.
As it happens, I have to work with an OData REST API, which uses PathEscape, even for items in the QueryString,
specifically, A%20B style space escaping instead of A+B escaping. This also affects some other punctuation characters as well though.
If we have net Url I can just use:
MyObject: Name: "Name with Spaces"
MyUrl: BaseUrl + ApiVersion + "?Service(" + MyObject.Name +")"
Request: http.Do & { url: url.PathEscape(MyUrl), ... }

Describe alternatives you've considered
Just had to roll my own naive replace functions, they'll work for now, but will probably break once i'm long gone from the project :-/
Additional context

Yes, good point @ghostwheel42 :) Closing as a duplicate.


Animate the rotation when button to rotate viewport is clicked

I have created a button which when clicked rotates the viewport. Is there a way to animate this (similar animation when zoom is clicked)? At the  moment rotation happens instantly. I found that there is optional "Immediately" in setRotation method of TiledImage but no such option on Viewport's setRotation method and I couldn't get the TiledImage's method to work.

For anyone interested, I managed to animate the rotation using jquery animation like this:
function rotateView () {
currentRotation +=180;
			var someValue;
			var startValue = vp.getRotation();

			$({someValue: startValue}).animate({someValue: currentRotation}, {
				  duration: 2000,
				  easing:'swing',
				  step: function() {
					  vp.setRotation(Math.round(this.someValue));
				  },
				  complete:function(){
					  currentRotation = vp.getRotation();
				  }
			  });

}
Wondering if it is an efficient code.
Thanks

Indeed... when we originally added the viewport rotation we didn't put it on springs (unlike panning and zooming), and so far no one has followed up to add that functionality. Here's the issue: https://github.com/openseadragon/openseadragon/issues/1060
Your jQuery solution seems like a reasonable work around.
I'm curious to find out how the TiledImage setRotation didn't work for you; what went wrong?

I managed to get TiledImage setRotation working (using viewer.world.getItemAt(0) ) however couldn't figure out a way to rotate it around my clicked hotspot. The hotspot overlays also changed their location (it was like the image rotated independently of the hotspots overlays) Using viewport's setRotation did not do this. I am unable to release the project at this stage, but once it's launched, I will post links.

I see. Thank you for letting me know. Yeah, sounds like the viewport's version is what you need.
I look forward to seeing your project once it's ready!

Fixed by #2136.


Publish an update as 0.0.6

To use the censys library with its current (helpful) API, where a page parameter can be sent in to the main search method, I need to clone the repo and run python setup.py install rather than pip install. A version hasn't been published since April, so a 0.0.6 (which still doesn't imply any stability or backwards compatibility) would be helpful.

I have uploaded 0.0.6 which includes everything in the current master.


Set different audio and display in gamemode and desktop?

Hello! I have a monitor on a desktop to use for navigation and work, and other TV to play on, I would like that when entering gamemode the TV would automatically turn on e show a gamemode and the system sound would go to the HDMI and when exiting gamemode it would return to the display initially configured with the audio correct, is this possible?
It would also be really cool to disable automatic entry into gamemode and only activate it when pressing the home button on the Xbox controller.
I tried looking to see if there was any configuration in etc/envirolment, but I didn't find anything.
Hardware
B550 Aorus
Ryzen 5700X
RX 6750XT

Gamescope doesn't have output selection built into the interface and its rules for display selection can be a bit arbitrary at times. You can:
1. Check your user home `.gamescope-stdout.log` file (it's a hidden one), which will tell what connector your TV is in. i.e. a graphics card with 3 display ports and 1 HDMI should have DP-1, DP-2, DP-3, and HDMI-A-1.  I have a LG TV connected into DP-3 (I use a DP to HDMI adapter) so the log shows `drm: Connector DP-3 -> GSM - LG TV SSCR2` for it.

2. Once you know the connector your TV is in, now open in your user home the `.gamescope-cmd.log` file and copy its contents.

3. In the home folder, go to `.config/` (it's a hidden one) and create a folder called `environment.d/`. Inside it, create a new file called `gamescope-session-plus.conf`.

4. In our new .conf file, type `GAMESCOPECMD="`, paste the content you copied from `.gamescope-cmd.log`, and type another `"`, so what we just pasted is inside our double quotes wrap. Here is an example:
   `GAMESCOPECMD="/usr/bin/gamescope --max-scale 2 --adaptive-sync -e --xwayland-count 2 -O *,eDP-1 --default-touch-mode 4 --hide-cursor-delay 3000 --fade-out-duration 200 --cursor-scale-height 720 -R /run/user/1000/gamescope.yQe3x0S/startup.socket -T /run/user/1000/gamescope.yQe3x0S/stats.pipe"`

5. Note from our previous step we have `*,eDP-1`.  Replace it with your connector we checked in the step 1. In my case the final file now is:
   `GAMESCOPECMD="/usr/bin/gamescope --max-scale 2 --adaptive-sync -e --xwayland-count 2 -O DP-3 --default-touch-mode 4 --hide-cursor-delay 3000 --fade-out-duration 200 --cursor-scale-height 720 -R /run/user/1000/gamescope.yQe3x0S/startup.socket -T /run/user/1000/gamescope.yQe3x0S/stats.pipe"`

Restart the system and whenever you go into game mode it should now select the proper monitor. Desktop mode will retain its own monitor configuration independently.

It's great but will it also change audio?

Is it also possible to set up priorities here? Like first try DP-1 then DP-2?


Add orphan entities to the Entity Association PDR's

It is not always a standard condition that we should have
a fru record set PDR, we can also have sensors/effecters
without having an associated FRU record set PDR.
This commit would help add these orphan sensors/effecters
entities into the entity association PDR's.
Fixes : SW536590 & SW536589
Signed-off-by: Manojkiran Eda<EMAIL_ADDRESS>

upstream commit :  https://gerrit.openbmc-project.xyz/c/openbmc/pldm/+/49420


 Sounds good.

Merged in 2fca0782adff4c0547d05481fbd39555ee1b3f1f


The creation of an instance of the Powershell class by specifying an InitialSessionState,  do not update the 'IsRunspaceOwner' property.

When I create an instance of the Powershell class by specifying an InitialSessionState,  the 'IsRunspaceOwner' property is not updated.
Steps to reproduce
try {
  $InitialSessionState=  [System.Management.Automation.Runspaces.InitialSessionState]::Create()

 $SessionStateCmdletEntry = New-Object System.Management.Automation.Runspaces.SessionStateCmdletEntry 'Get-ChildItem','Microsoft.PowerShell.Commands.GetChildItemCommand',$null
 $InitialSessionState.Commands.Add($SessionStateCmdletEntry)

 $Provider = New-Object System.Management.Automation.Runspaces.SessionStateProviderEntry 'FileSystem',([Microsoft.PowerShell.Commands.FileSystemProvider]),$null
 $InitialSessionState.Providers.Add($Provider)

  $PS = [PowerShell]::Create($InitialSessionState)
  Write-Warning "Automatic release : $($ps.IsRunspaceOwner)"
   $PS.AddCommand("Get-ChildItem") > $null
   $Results = $PS.Invoke()
  Write-Warning "Automatic release : $($ps.IsRunspaceOwner)"

}
finally {
 $PS.Dispose()
}
$PS.Runspace

Expected behavior
WARNING: Automatic release : False
WARNING: Automatic release : True

 Id Name            ComputerName    Type          State         Availability
 -- ----            ------------    ----          -----         ------------
  2 Runspace2       localhost       Local         Closed        None

Actual behavior
#WARNING: Automatic release : False
#WARNING: Automatic release : False

$PS.Runspace

#  Id Name            ComputerName    Type          State         Availability
#  -- ----            ------------    ----          -----         ------------
#   2 Runspace2       localhost       Local         Opened        Available

Environment data

> $PSVersionTable
Name                           Value
----                           -----
PSVersion                      6.0.2
PSEdition                      Core
GitCommitId                    v6.0.2
OS                             Microsoft Windows 6.1.7601 S
Platform                       Win32NT
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0, 5.0, 5.1.10032.0, 6.0.2}
PSRemotingProtocolVersion      2.3
SerializationVersion           <IP_ADDRESS>
WSManStackVersion              3.0

Same error with  Windows Powershell :
> $PSVersionTable
Name                           Value
----                           -----
PSVersion                      5.1.14409.1012
PSEdition                      Desktop
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0, 5.0, 5.1.14409.1012}
BuildVersion                   10.0.14409.1012
CLRVersion                     4.0.30319.42000
WSManStackVersion              3.0
PSRemotingProtocolVersion      2.3
SerializationVersion           <IP_ADDRESS>

IsRunspaceOwner = true means that a runspace is created by the PowerShell object.
IsRunspaceOwner = true means that a runspace is created out of the PowerShell object and assigned to the PowerShell object.

cc @BrucePay

I updated my comment with code references.

My comment fixed.

If you created you should release.


Not Obvious Where To Set Up Relationships Between Models

Hello! Please mention which file to edit while implementing this code. As a beginner, it's not obvious. Please update your docs to reflect this.

Thanks :)

Why does Filament need to put this in their docs? If you want to know about it, just learn how Laravel models and relationships work.
https://laravel.com/docs/10.x/eloquent-relationships#main-content

I agree, this isn't related to Filament, it is expected that you know the basic concepts of Laravel to begin with.


encrypt: use age encryption

This PR switches the encryption method of the encrypt blobserver to age, since its easier to use and get right. This constitutes a breaking change in this blobserver in the current version for the sake of simplicity. It could be made to be backwards compatible by comparing the version of the blob and choosing an appropriate encryption/decryption method though if that is required!

Test failure is not related to the change. Seems to be some flakiness in pk-mount.


Add a branch with config files to serve with nginx + uswgi

Following a tweet from @rochabruno, I'll test a config using some flask apps + nginx making a kind of load balance.

I'll just write some text about the deploy process


Fix race conditions in encoder to address photo-dedup segfault

This change addresses race conditions revealed by a segfault while running photo-dedup in production.
The root of the problem is described in #2849. The fix is to add use a RWMutex to block encoder function calls until the function is fully initialized.
I've verified the fix by running photo-dedup under the race detector before and after. The race is detected in the before run and is gone in the after run.
An improvement over this fix would be to implement a fast path using an atomic int (see the sync.Once.Do() implementation for an example).

toward: #2849

PTAL @arv
CC: @kalman


BUG: Tabledata as ObjectType in permission set

Describe the bug
I've exported a permission set for my extension from NAV (because i've used the record function) but when I tried to deploy my solution the compiler throws this error:
error PTE0004: Table 'XXX' is missing a matching permission set.
Although there was a matching permission set. here the permission:
<Permission>
      <ObjectType>Table Data</ObjectType>
      <ObjectID>XXXX</ObjectID>
      <ReadPermission>Yes</ReadPermission>
      <InsertPermission>Yes</InsertPermission>
      <ModifyPermission>Yes</ModifyPermission>
      <DeletePermission>Yes</DeletePermission>
      <ExecutePermission>Yes</ExecutePermission>
	  <SecurityFilter />
    </Permission>

Then I realized that exporting the permission set directly from nav it occours the following error:
The new compiler is looking for "TableData" and not for "Table Data" (in simply words it does not want the space batween Table and Data).
So I've changed my permission set as:
<Permission>
      <ObjectType>TableData</ObjectType>
      <ObjectID>XXXX</ObjectID>
      <ReadPermission>Yes</ReadPermission>
      <InsertPermission>Yes</InsertPermission>
      <ModifyPermission>Yes</ModifyPermission>
      <DeletePermission>Yes</DeletePermission>
      <ExecutePermission>Yes</ExecutePermission>
	  <SecurityFilter />
    </Permission>

and works perfectly.
Let me know if it is Ship-in-future or whatever.
Thanks
Versions:

AL Langauge: 2.1.79379

Business Central: RTM IT

UPDATE:
the object ID: "TableData" is not recognized as a valid Object ID, so the deploy goes well but the permission set does not being imported.
The only way is to replace Table Data with the numeric one, in this case it would be equal to 0

RE-UPDATE:
The file permissionset.xml it will not be imported if:
some Permission tag does not have all the tags:
      <ReadPermission>x</ReadPermission>
      <InsertPermission>x</InsertPermission>
      <ModifyPermission>x</ModifyPermission>
      <DeletePermission>x</DeletePermission>
      <ExecutePermission>x</ExecutePermission>

for example
This one not work:
<Permission>
      <ObjectType>0</ObjectType>
      <ObjectID>3</ObjectID>
      <ReadPermission>1</ReadPermission>
      <InsertPermission>0</InsertPermission>
    </Permission>

This one works:
<Permission>
      <ObjectType>0</ObjectType>
      <ObjectID>3</ObjectID>
      <ReadPermission>1</ReadPermission>
      <InsertPermission>0</InsertPermission>
      <ModifyPermission>0</ModifyPermission>
      <DeletePermission>0</DeletePermission>
      <ExecutePermission>0</ExecutePermission>
      <SecurityFilter />
    </Permission>

Hi @stefanoPrimo, there is a command in VS Code AL: Generate permission set containing current extension objects in order to generate a permission set for your extension objects. This should generate a permission with the right format. Did you try using it?

Yes, I've tried it but in order to publish an app to the app source I have to generate a permission like:
Permission set(s) must be created by your extension and when marked, should give the user all setup and usage abilities. A user must not be required to have SUPER permissions for setup and usage of your extension.

There are any updates?

@qutreson

Hi @stefanoPrimo , sorry for the delay in answering to this issue. I had a look back at it and I am now able to reproduce it. It seems that the rule PTE0004 expects to see "TableData" instead of "Table Data". The workaround is to use 0 instead of table data.

The fix for this issue has been checked in to the master branch. It will be available in the bcinsider.azurecr.io/bcsandbox-master Docker image starting from platform build number 36952.
If you don’t have access to these images you need to become part of the Ready2Go program: aka.ms/readytogo
For more details on code branches and docker images please read:
https://blogs.msdn.microsoft.com/nav/2018/05/03/al-developer-previews-multiple-releases-and-github/
https://blogs.msdn.microsoft.com/freddyk/2018/04/16/which-docker-image-is-the-right-for-you/

The fix for this issue has been checked in to the master branch. It will be available in the bcinsider.azurecr.io/bcsandbox-master Docker image starting from platform build number 36952 and VS Code Extension Version 5.0.185850.
If you don’t have access to these images you need to become part of the Ready2Go program: aka.ms/readytogo
For more details on code branches and docker images please read:
https://blogs.msdn.microsoft.com/nav/2018/05/03/al-developer-previews-multiple-releases-and-github/
https://blogs.msdn.microsoft.com/freddyk/2018/04/16/which-docker-image-is-the-right-for-you/


fix: ensure property sheets are not unloaded too early

Fixes #222. This PR ensures that we keep the IShellPropSheetExt alive
while the property sheet is open. The documented method of using
PSP_USEREFPARENT is close to impossible to implement in a managed
environment. This fix actually seems to work perfectly well (and seems
more simple).

@ElektroStudios @Countryen I think this fixes the explorer crash. I'll leave the PR open for a while - if either of you get a chance to see whether it resolves your own local issues I'd love to know before I finally merge!

@ElektroStudios @Countryen I think this fixes the explorer crash. I'll leave the PR open for a while - if either of you get a chance to see whether it resolves your own local issues I'd love to know before I finally merge!

I tested it in my local Windows 10 x64 and in a VM with same OS, all is working fine this time!!.

Excellent @ElektroStudios - I am going to merge and close, and cut a new release with the most recent fixes


Windows: "uv venv" gives "exit 2" with tox-uv

Windows
uv 0.1.4
tox-uv 1.2.0
Using tox-uv, and running python -m tox -e py -vvv on Windows with CPython 3.8-3.13 and PyPy 3.10 gives an error:
ROOT: 156 D setup logging to NOTSET on pid 8056 [tox\report.py:221]
py: 375 W venv> C:\hostedtoolcache\windows\Python\3.8.10\x64\uv venv -p 3.8 D:\a\termcolor\termcolor\.tox\py\.venv [tox\tox_env\api.py:427]
py: 375 C exit 2 (0.00 seconds) D:\a\termcolor\termcolor> C:\hostedtoolcache\windows\Python\3.8.10\x64\uv venv -p 3.8 D:\a\termcolor\termcolor\.tox\py\.venv [tox\execute\api.py:280]
  py: FAIL code 2 (0.00 seconds)
  evaluation failed :( (0.22 seconds)
Error: Process completed with exit code 1.

It passes on Ubuntu and macOS. I don't have a Windows machine, this is on CI:
https://github.com/hugovk/termcolor/actions/runs/7948092300/job/21697697387
To get the code locally:
git clone https://github.com/hugovk/termcolor/
git checkout fd9f3f426449541a111560585c4230e31d2e0adf

Possibly a tox-uv bug?

https://github.com/astral-sh/uv/issues/1310

Reproducible on Windows with uv 0.1.14 for PyPy 3.9 and 3.10, and CPython 3.13.
Run python -m tox -e py -rvvv
.pkg: 4423 W remove tox env folder D:\a\termcolor\termcolor\.tox\.pkg [tox\tox_env\api.py:325]
py: 4470 W venv> C:\hostedtoolcache\windows\PyPy\3.10.13\x86\Scripts\uv.exe venv -p 3.10 -v D:\a\termcolor\termcolor\.tox\py\.venv [tox\tox_env\api.py:427]
 uv_interpreter::python_query::find_requested_python request=3.10
      0.002894s   0ms DEBUG uv_interpreter::python_query Starting interpreter discovery for Python @ `3.10`
      0.003287s   0ms DEBUG uv_interpreter::interpreter Probing interpreter info for: C:\hostedtoolcache\windows\PyPy\3.10.13\x86\python3.10.exe
      0.132933s 130ms DEBUG uv_interpreter::interpreter Found Python 3.10.13 for: C:\hostedtoolcache\windows\PyPy\3.10.13\x86\python3.10.exe
Using Python 3.10.13 interpreter at: C:\hostedtoolcache\windows\PyPy\3.10.13\x86\python3.10.exe
Creating virtualenv at: D:\a\termcolor\termcolor\.tox\py\.venv
uv::venv::creation

  × Failed to create virtualenv
  ├─▶ failed to copy file from
  │   C:\hostedtoolcache\windows\PyPy\3.10.13\x86\Lib\venv\scripts\nt\python.exe
  │   to \\?\D:\a\termcolor\termcolor\.tox\py\.venv\Scripts\python.exe
  ╰─▶ The system cannot find the file specified. (os error 2)
py: 5080 C exit 1 (0.61 seconds) D:\a\termcolor\termcolor> C:\hostedtoolcache\windows\PyPy\3.10.13\x86\Scripts\uv.exe venv -p 3.10 -v D:\a\termcolor\termcolor\.tox\py\.venv pid=6192 [tox\execute\api.py:280]
  py: FAIL code 1 (0.67 seconds)
  evaluation failed :( (4.67 seconds)

Error: Process completed with exit code 1.

https://github.com/hugovk/termcolor/actions/runs/8145079624
CPython 3.8-3.12 pass.

Thanks, let me see if I can repro with a minimal Python 3.13 run.

Reproduced here, thanks! https://github.com/astral-sh/uv/pull/2171

First trying to figure out if we're attempting to copy from the wrong directory, or if we're copying the wrong filename.

@gaborbernat - Do you know if the development builds exclude the venv shims?

I figured this out, I think we're supposed to fallback to venvlauncher.exe if python.exe doesn't exist:
https://github.com/python/cpython/blob/d457345bbc6414db0443819290b04a9a4333313d/Lib/venv/__init__.py#L270C66-L270C71

FYI @gaborbernat -- The executable names changed in Python 3.13: https://discuss.python.org/t/when-should-venv-scripts-nt-python-exe-be-present/47620/2. I suspect virtualenv won't fail because it's robust to the shims not existing.

Thanks for the CPython 3.13 fix!
This issue is also about PyPy (3.9 and 3.10), does uv need an extra fix there?

This issue is also about PyPy (3.9 and 3.10), does uv need an extra fix there?

Probably — PyPy isn't officially supported right now, though we'd welcome contributions to help us get there! See #2096


docs: replace url for finding good first issue

Description
Update the link in the faq.md file for "How do I find good first issues?" to this guide from freeCodeCamp instead of the previous YouTube video. This guide provides more comprehensive information on finding good first issues on GitHub.
What type of PR is this? (check all applicable)

[ ] 🍕 Feature
[ ] 🐛 Bug Fix
[x] 📝 Documentation Update
[ ] 🎨 Style
[ ] 🧑💻 Code Refactor
[ ] 🔥 Performance Improvements
[ ] ✅ Test
[ ] 🤖 Build
[ ] 🔁 CI
[ ] 📦 Chore (Release)
[ ] ⏩ Revert

Related Tickets & Documents

Fixes #140
Mobile & Desktop Screenshots/Recordings

Before:
https://github.com/open-sauced/docs/assets/106407013/4208a33a-0b0f-4c52-a5e7-f1abc7af81b7
After:
https://github.com/open-sauced/docs/assets/106407013/f2afa8d4-9a08-4ac2-8e5e-79154a791b99
Added tests?

[ ] 👍 yes
[x] 🙅 no, because they aren't needed
[ ] 🙋 no, because I need help

Added to documentation?

[ ] 📜 README.md
[x] 📓 docs.opensauced.pizza
[ ] 🍕 dev.to/opensauced
[ ] 📕 storybook
[ ] 🙅 no documentation needed

[optional] Are there any post-deployment tasks we need to perform?
[optional] What gif best describes this PR or how it makes you feel?

Here is the PR,  @CBID2, as discussed.


EOS-S3 update [2/4]: update QL common infrastructure

This PR is second out of four PRs that are integrating and updating QuickLogic EOS-S3 support. All 4 PRs are created from one big PR that contains all EOS-S3 updates (https://github.com/SymbiFlow/symbiflow-arch-defs/pull/2346).
PRs are created as drafts with [WIP] tag because first we need to make sure each of those 4 PRs passes the tests in CI before review takes place.
List of PRs:

https://github.com/SymbiFlow/symbiflow-arch-defs/pull/2354
https://github.com/SymbiFlow/symbiflow-arch-defs/pull/2355
https://github.com/SymbiFlow/symbiflow-arch-defs/pull/2356
https://github.com/SymbiFlow/symbiflow-arch-defs/pull/2357

Each consecutive PR depends on the previous one and needs it being merged to master. That causes the diffs in PRs to display commits from all previous PRs from this batch.
For example PR [4/4] (https://github.com/SymbiFlow/symbiflow-arch-defs/pull/2357) has in its diff commits from PRs: (https://github.com/SymbiFlow/symbiflow-arch-defs/pull/2357, https://github.com/SymbiFlow/symbiflow-arch-defs/pull/2356, https://github.com/SymbiFlow/symbiflow-arch-defs/pull/2355, https://github.com/SymbiFlow/symbiflow-arch-defs/pull/2354)
Once https://github.com/SymbiFlow/symbiflow-arch-defs/pull/2354 is merged, this PR has to be rebased on top of the newest master.
This PR is updating QuickLogic common cmake infrastructure and utils scripts. It also introduces changes and fixes to Quicklogic toolchain wrappers and bumps the submodule with QL test designs.

Updated description to better explain the EOS-S3 update PR series.

PR series requires fixes for the ASSERT_USAGE test cases that will be introduced in https://github.com/SymbiFlow/symbiflow-arch-defs/pull/2359. Because of that I rebased whole series onto the code from xc7 fix. The result is that each PR from EOS-S3 upstream series will have temporarily in its diff additional commits from PR https://github.com/SymbiFlow/symbiflow-arch-defs/pull/2359.
The correct order of merging is as follows:

https://github.com/SymbiFlow/symbiflow-arch-defs/pull/2359 -> https://github.com/SymbiFlow/symbiflow-arch-defs/pull/2354 -> https://github.com/SymbiFlow/symbiflow-arch-defs/pull/2355 -> https://github.com/SymbiFlow/symbiflow-arch-defs/pull/2356 -> https://github.com/SymbiFlow/symbiflow-arch-defs/pull/2357
After one PR is merged, next ones need to be rebased onto newest master or previous PR if it was not merged yet to keep correct ordering and codebase integrity.

Commits titled with [WIP] tag integrate changes to VPR that are not yet merged (https://github.com/verilog-to-routing/vtr-verilog-to-routing/pull/1947).
For now those commits will cause CI failures because introduced code expects new version of VPR.
To solve this it is required to merge mentioned PRs to vtr, bump VPR package in SymbiFlow and rebase PR series onto newest master

Each Symbiflow PR was tested separately with local VPR build that supports features required by [WIP] commits and each should pass CI tests as soon as new VPR version will be available.

This PR was updated and cleaned up. It is ready for review. CI is expected to fail because each of the PRs from chain:
https://github.com/SymbiFlow/symbiflow-arch-defs/pull/2359 -> https://github.com/SymbiFlow/symbiflow-arch-defs/pull/2354 -> https://github.com/SymbiFlow/symbiflow-arch-defs/pull/2355 -> https://github.com/SymbiFlow/symbiflow-arch-defs/pull/2356 -> https://github.com/SymbiFlow/symbiflow-arch-defs/pull/2357
is created from different part of EOS-S3 updated codebase. This codebase was divided into separate PRs to make review process easier but also because of that, CI will work only in the last PR, that is placed on top of all other PRs and contains whole EOS-S3 update: https://github.com/SymbiFlow/f4pga-arch-defs/pull/2357

Some crucial changes from other PRs (cmake infrastructure fixups, fasm2bels update) were moved here in order to make all tests in CI working. One of installed toolchain tests (btn_counter) was failing on routing so I decided to disable it - this test is in fact replaced with similar ones in https://github.com/SymbiFlow/f4pga-arch-defs/pull/2357

Rebased on top of main after merging https://github.com/chipsalliance/f4pga/pull/573, https://github.com/SymbiFlow/f4pga-arch-defs/pull/2359 and https://github.com/SymbiFlow/f4pga-arch-defs/pull/2354.


Maximum period_nsec value

The maximum value for the period is 30000000ns. Greater than this value will result in EINVAL.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 47d2af37-84d3-c7c2-87e1-9cb3915e9dbb
Version Independent ID: 394be125-8bbf-101d-618a-c2bcbee6987c
Content: PwmState struct - Azure Sphere
Content Source: AzureSphere/articles/reference/applibs-reference/applibs-pwm/struct-pwmstate.md
Product: azure-sphere
GitHub Login: @esalc
Microsoft Alias: azurespheredocs

@clarkebowers Thank you for bringing this to our attention. I will have the content team evaluate this and update the document as appropriate.
period_nsec
The length of each period, in nanoseconds. This includes the total length of both the high and low states.

@clarkebowers The period is hardware-dependent. This information has been updated in the documentation.


Check icon alignment

The icons do not seem to be top/middle/bottom aligned.

Yusuf: After verification if you find that the icons are misaligned, please rectify them, share the screen xd link here, remove your assignment and tag Pawan.

https://xd.adobe.com/view/a14b2273-19ad-4c4c-976f-09bac56e5fa6-f418/
@Pawan2792

Completed


sasl conversation error: unable to authenticate using mechanism "SCRAM-SHA-1"

Hello
We are trying to connect our litmus with our mongodb with LDAP auth. After trying we have this error:
time="2022-10-04T14:20:43Z" level=info msg="Go Version: go1.16.15"
time="2022-10-04T14:20:43Z" level=info msg="Go OS/Arch: linux/amd64"
time="2022-10-04T14:20:45Z" level=fatal msg="failed to create collection connection() error occured during connection handshake: auth error: sasl conversation error: unable to authenticate using mechanism \"SCRAM-SHA-1\": (AuthenticationFailed) Authentication failed."

This is our connection string
host-mdb01.example.com:27017,host-mdb02.example.com:27017,host-mdb03.example.com:27017/litmus-dev?authMechanism=PLAIN&readPreference=primary&authSource=%24external&replicaSet=rs0&tls=false

We are using helm chart
apiVersion: v2
appVersion: 2.13.0
dependencies:
- condition: mongodb.enabled
  name: mongodb
  repository: https://charts.bitnami.com/bitnami
  version: 12.1.11
description: A Helm chart to install ChaosCenter
home: https://litmuschaos.io
icon: https://raw.githubusercontent.com/litmuschaos/icons/master/litmus.png
keywords:
- chaos-engineering
- resiliency
- kubernetes
kubeVersion: '>=1.16.0-0'
maintainers:
- email<EMAIL_ADDRESS>  name: imrajdas
- email<EMAIL_ADDRESS>  name: ispeakc0de
- email<EMAIL_ADDRESS>  name: jasstkn
name: litmus
sources:
- https://github.com/litmuschaos/litmus
version: 2.14.0

What should we do with it?
Thank you

@AmitKumarDas, can you PTAL?

@amityt can you PTAL?

@ksponomarev in case you want to try it out here are the custom images for graphql-server and auth-server that you can replace in your setup to see if that fixes the problem.

gdsoumya/litmusportal-server:mongofix
gdsoumya/litmusportal-auth-server:mongofix

Both of them are using master code but I don't think there should be any problem if you are running a recent tagged version.

@gdsoumya Now I have this error:

Changed error from SCRAM-SHA-1 to PLAIN ))

Have you set the db password and username in the secret properly?

Also i just noticed you have mentioned a db name in the connection string, that won't work because litmus has a specific db that it uses, one db for auth-related stuff and another for the graphql. You would have to either manually create the specifc dbs yourself and use them separately in the 2 deployments or skip mentioning the dbname and let the servers create the db as needed.

@gdsoumya
Where can I change db names in helm chart?
I've changed DB_SERVER to:

There is no way to change the db names it's fixed in code, what you should try rather is setting the URL to
host-mdb01.example.com:27017,host-mdb02.example.com:27017,host-mdb03.example.com:27017/?authMechanism=PLAIN&readPreference=primary&authSource=%24external&replicaSet=rs0&tls=false

And let the servers create the dbs as needed (the credentials should have enough permission to create the databases or you can create the 2 dbs with the same name as I mentioned and allow the creds to have write access to the 2 databases)

@gdsoumya
Hello
I changed my connection string to this
mongodb://example-mdb01.example.ru:27017,example-mdb02.example.ru:27017,example-mdb03.example.ru:27017/?authMechanism=PLAIN&readPreference=primary&authSource=%24external&replicaSet=rs0&tls=false

And now have this error
time="2022-10-13T14:54:15Z" level=info msg="Go Version: go1.16.15"
time="2022-10-13T14:54:15Z" level=info msg="Go OS/Arch: linux/amd64"
panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x30 pc=0xbd54d0]

goroutine 1 [running]:
litmus/litmus-portal/authentication/pkg/utils.MongoConnection(0xc000100120, 0xc000030040, 0x0)
	/auth-server/pkg/utils/mongo_database.go:19 +0xd0
main.main()
	/auth-server/api/main.go:57 +0x10a

After that I changed string to
mongodb://example%40example.ru:%23uWv%3F0z%3BLJs%7Dd%3FA~%3FxyQ3%5E@example-mdb01.example.ru:27017,example-mdb02.example.ru:27017,example-mdb03.example.ru:27017/?authMechanism=PLAIN&readPreference=primary&authSource=%24external&replicaSet=rs0&tls=false

I got this
time="2022-10-13T15:13:57Z" level=info msg="Go Version: go1.16.15"
time="2022-10-13T15:13:57Z" level=info msg="Go OS/Arch: linux/amd64"
time="2022-10-13T15:13:57Z" level=fatal msg="failed to create collection  connection() error occured during connection handshake: auth error: unable to authenticate using mechanism \"PLAIN\": (AuthenticationFailed) Authentication failed."

hey @ksponomarev  how did you solved it ?

I guess I didn't. I don't remember. I haven't been using litmus since then


Blurry Text on hover

There is a blurry text on hover appears on chrome. Can this be fixed ?

@web-tiki did we have this issue before?

You can compare the behavior on chrome and on firefox.
The problem is the skewed element on chrome makes the text on it blurry and the image also.
I don't know how to fix that.

Hello @muhammedmagdi  @poi33 ,
This issue has been around for a long time. Chrome renders text blurry when it is transformed and "untransformed".
I just made a new test and it seems the text is not blurry anymore when 2d transforms are used (see here https://jsfiddle.net/webtiki/26qz5shr/).
We could remove the 3d transforms and only use 2d transforms instead for the titles and text hover effect. Even though 3d transforms are supposed to be more performant.

Hello @web-tiki
Thanks for your response,
I have tried so many solutions and I have already made 2d transform instead of 3d but the problem is still existent. The problem with the skewed elements ..  Chrome makes text blurry on any skewed element whatever this text is 2d transform or 3d .. I even tried to remove all transforms and make only text opacity change on hover but it doesn't work too.

Also on firefox the text keeps blurry for a while and then becomes clear.

@muhammedmagdi then there is non way to solve this issue yet...

I'll tag this as a bug web-tiki since its unwanted behavior but there is currently not a lot we can do about it.

@poi33  @web-tiki
To solve this issue, I just suggest using polygonal fill instead of skew and rotate3d like the following example :
https://codepen.io/tstoik/pen/qZEZJp
The only problem is at that example is that it isn't fully responsive. I didn't test it on all browsers.

@web-tiki  Yes, I was going to say that I just tested on IE but it doesn't work unfortunately. But I found you have already mentioned that.
But you can notice this sentence :
Support for clip-path in SVG is supported in all browsers with basic SVG support.
Can we do it as SVG ?

@poi33 @web-tiki
To solve this issue, I just suggest using clip-path instead of skew and rotate3d like the following example :
https://codepen.io/tstoik/pen/qZEZJp
The only problem is at that example is that it isn't fully responsive. I didn't test it on all browsers.

that looks even better !

@daslicht If the low browser support of clip-path isn't an issue for you then you definetly should go down that route ;)
See caniuse  for clip-path browser support table : https://caniuse.com/#feat=css-clip-path

@web-tiki we might want to use clip-path now? Or want to wait for EI11 to be unsupported?

@poi33 Clip-path support has become much better but I don't think it is a good idea to use it yet.
The risk ratio of it failling compared to the benefit of using it inst' hight enough yet.


docs(protocol): enhance bridge documentation

I have added a few TODO(dave):, I'd like to implement these, but I'm not sure if they are good. I would appreciate if you could check those out and let me know if you want me to include them in this PR.

@d1onys1us  some tests are failing due to the change of function name (releaseEther)

Looks like some state renames cause the genesis generation failure. I will push a new commit in this PR to fix this.

Looks like some state renames cause the genesis generation failure. I will push a new commit in this PR to fix this.

Pushed and approved.


ElasticSearch elasticsearch.exceptions.AuthorizationException

Expected Behavior
Hello again, I'm trying to setup Amundsen for the first time. I've been able to stand up the architecture. I'm trying to search over the test data, but it is not succeeding
Current Behavior
The website gets a 500 when I search. The search service logs
elasticsearch.exceptions.AuthorizationException: TransportError(403, '{"message":"\'ZWxhc3RpYzplbGFzdGlj\' not a valid key=value pair (missing equal-sign) in Authorization header: \'Basic ZWxhc3RpYzplbGFzdGlj\'."}')

Which I think is because I setup OIDC via okta? I set this up because it seemed like the "bookmarks" thing would load indefinitely if there was no user authentication.
From what I can tell it is passing an authorization header, but my cluster doesn't have authorized users. I can bash into the container and run the query without passing authorization
curl https://<endpoint>.es.amazonaws.com:443/table_search_index/_search
{"took":17,"timed_out":false,"_shards":{"total":5,"successful":5,"skipped":0,"failed":0},"hits":{"total":87,"max_score":1.0,"hits":[{"_index":"table_378746f6-8012-4b19-8122-6b10d7a876f8","_type":"table","_id":"VPOsTnYBmg9jf7w4Wa-b","_score":1.0,"_source":{"badges":[],"cluster":"plaiddw","column_descriptions":[],"column_names":["id","item_id","account_id",
...

Possible Solution
Is it possible to setup the search service to not pass authorization?
Screenshots (if appropriate)

So I think that it's passed here
def get_access_headers(app: Flask) -> Optional[Dict]:
    """
    Function to retrieve and format the Authorization Headers
    that can be passed to various microservices who are expecting that.
    :param oidc: OIDC object having authorization information
    :return: A formatted dictionary containing access token
    as Authorization header.
    """
    try:
        access_token = app.oidc.get_access_token()
        return {'Authorization': 'Bearer {}'.format(access_token)}
    except Exception:
        return None

from the oidc frontend build. But I'm using AWS ES, which does not want this Authorization set. I'm (attempting to) use okta just so that the amundsen user is set (the bookmarks UI seemed to spin indefinitely otherwise)

Okay, I get this even with oidcEnabled: false set

cc @verdan do you have any suggestions?

@AustinBGibbons is OIDC enabled across all services?

@feng-tao no, originally only in frontend, but then I also tried adding it to metadata but I am still using image: amundsendev/amundsen-metadata

@AustinBGibbons I think OIDC isn't related to the problem at hand. Here's why + a take on what you can do, first some of the facts you provided:

Okay, I get this even with oidcEnabled: false set

From what I can tell it is passing an authorization header, but my cluster doesn't have authorized users. I can bash into the container and run the query without passing authorization

But I'm using AWS ES, which does not want this Authorization set.

It seems to be related to just the hop between amundsen-search and AWS ES, not OIDC. Currently the default Amundsen search container and the Helm chart is configured to use basic authentication towards ES:
https://github.com/amundsen-io/amundsensearchlibrary/blob/fc4503f92faece804c7ad49a0875a85d209cd75b/search_service/config.py#L51-L52
and
https://github.com/amundsen-io/amundsensearchlibrary/blob/fc4503f92faece804c7ad49a0875a85d209cd75b/search_service/proxy/elasticsearch.py#L72-L74
But from this ☝  last link you see there's a backdoor where you can provide your own initial ES object. So if you want/need to go with AWS ES - and not just the containerized one in the Helm chart this is where you'd either:

Instantiate an ElasticSearch object with NO authentication
Instantiate one with AWS authentication (see more below)

Googling for “python elasticsearch aws authentication” brought this up:
https://gist.github.com/simonw/f99c70588f4d7447a223#file-how-to-use-aws-elasticsearch-md
As you can see from that gist an extra library to convert to username/password from IAM credentials then appears to be needed in the search service.

Setting
        - name: CREDENTIALS_PROXY_USER
          value: ''
        - name: CREDENTIALS_PROXY_PASSWORD
          value: ''

Worked for me, thank you!


Feat: public getFiles in local device

Nessessary for Open Runtimes executor to list all files in /tmp and delete left-over temporary build folders

Extra changes regarding deletePath are to prevent this issue:


Registration and config fixes

Fixing bug regarding client re-registering when juju config-changed event is happening. (This was because of in function main() in landscape/client/configuration.py https://github.com/canonical/landscape-client/blob/2044c7b385ab65934a97d0a91515f2a2d9a6f90f/landscape/client/configuration.py#L945 it always re-registers in --silent mode but not in wizard mode).
The fix in the charm is to use client.conf instead of landscape-config so that when the config-changed event happens, the charm will check if it's already been registered and if so only restart landscape-client instead of register again. In addition, in order to register again there is a charm action.
See bugs here:
https://bugs.launchpad.net/landscape-client-charm/+bug/2045295
https://github.com/canonical/landscape-client-charm/issues/8
In addition the computer-title has been assigned a default value of the hostname:
https://github.com/canonical/landscape-client-charm/issues/7
In addition the relation name has been changed:
https://github.com/canonical/landscape-client-charm/issues/9

MANUAL TESTING INSTRUCTIONS:

make build
Remove computer title
Ensure it registers with default computer title
juju config landscape-client log-level=DEBUG
Ensure client.conf gets updated
Ensure the client gets restarted and re-registration does not happen
Try juju run landscape-client/0 register to trigger the new registration event


Unable to render template RuntimeException for AbstractRestfulController

I get an unable to render template error when i do not over-ride the AbstractRestfulController method.
By default, the response code is set and an array is returned which appears to be picked up and rendered using the default render strategy.
Would it be a good idea to set the response content and return the response or is there something I am missing in the configuration.
I would just like some feedback on this before I make a pull request.
Thanks,
James

I've ran into this issue many times as well and haven't found a good solution.
One way to recreate this is to extend the AbstractRestfulController and implement the get() action but not the getList() action. Then when you go to the getList route, you get a "template not found" error instead of a "Method Not Allowed" response like any other framework gives.
It doesn't make sense for me to have to create a "module-name/controller-name/get-list.phtml" template for every rest controller I create when I don't even want to implement "getList" functionality.

I've stumbled across the same problem as I am currently trying to implement a REST API with ZF2.
I registered the ViewJsonStrategy in my module and expected the AbstractRestfulController to return JSON-Based error-responses for unimplemented methods.
Afte some research I found out that the JsonStrategy has been changed long ago in 2.0.4 to only return JSON if a JsonModel has been explicitely returned.
http://framework.zend.com/blog/zend-framework-2-0-4-released.html
So in my understanding the AbstractRestfulController shouldn't return plain arrays in the pre-implemented methods but JsonModel containing the array. This would produce something like this:
{"content":"Method Not Allowed"}

Am I right?!

https://github.com/zendframework/zend-mvc/pull/164

Is there a reason why AbstractRestfulController returns an array in the pre-implemented methods instead of an JsonModel object?


samples: net: cellular_modem: No PPP packets received when using esp32 async uart

Describe the bug
I managed to get the cellular_modem sample to work on my Walter board (ESP32-S3 + Sequans GM02SP modem) using UART_INTERRUPT_DRIVEN. However when using UART_ASYNC_API, all AT chat commands work, but no PPP frames can be received.
Requires #72453, or else the sample fails earlier.
To Reproduce
cellular_modem sample with:
devicetree (changes in comparison to the esp32s3-devkitc dts):
	aliases {
		modem = &modem;
		modem-uart = &uart1;
	};

&uart1 {
	status = "okay";
	current-speed = <115200>;
	hw-flow-control;

	dmas = <&dma 0
	  	&dma 1>;
	dma-names = "rx", "tx";

	pinctrl-0 = <&uart1_default>;
	pinctrl-names = "default";
	modem: modem {
		status = "okay";
		compatible = "sqn,gm02s";
        	mdm-reset-gpios = <&gpio1 13 (GPIO_OPEN_DRAIN | GPIO_ACTIVE_LOW)>;
	};
};

&dma {
	status = "okay";
};

pinctrl:
	uart1_default: uart1_default {
		group1 {
			pinmux = <UART1_TX_GPIO48>;
			output-high;
		};
		group2 {
			pinmux = <UART1_RX_GPIO14>;
			bias-pull-up;
		};
		group3 {
			pinmux = <UART1_RTS_GPIO21>;
			output-high;
		};
		group4 {
			pinmux = <UART1_CTS_GPIO47>;
		};
	};

defconfig:
CONFIG_MAIN_STACK_SIZE=2048

CONFIG_CONSOLE=y
CONFIG_SERIAL=y
CONFIG_UART_CONSOLE=y
CONFIG_GPIO=y
CONFIG_CLOCK_CONTROL=y

CONFIG_DMA=y
CONFIG_UART_ASYNC_API=y

proj.conf:
CONFIG_POSIX_API=y

# Networking
CONFIG_NETWORKING=y
CONFIG_NET_NATIVE=y
CONFIG_NET_L2_PPP=y
CONFIG_NET_IPV4=y
CONFIG_NET_UDP=y
CONFIG_NET_SOCKETS=y
CONFIG_NET_CONTEXT_RCVTIMEO=y

# DNS
CONFIG_DNS_RESOLVER=y
CONFIG_NET_L2_PPP_OPTION_DNS_USE=y

# Network management
CONFIG_NET_MGMT=y
CONFIG_NET_MGMT_EVENT=y
CONFIG_NET_CONNECTION_MANAGER=y

# Modem driver
CONFIG_MODEM=y
CONFIG_PM_DEVICE=y
CONFIG_MODEM_CELLULAR=y

# Logging
CONFIG_LOG=y
CONFIG_LOG_BUFFER_SIZE=65536
CONFIG_MODEM_LOG_LEVEL_DBG=y
CONFIG_MODEM_MODULES_LOG_LEVEL_DBG=y
CONFIG_NET_LOG=y
CONFIG_NET_L2_PPP_LOG_LEVEL_DBG=y

Expected behavior
PPP packets getting received, same as when using UART_INTERRUPT_DRIVEN.
Logs and console output
Functional UART_INTERRUPT_DRIVEN log:
[00:00:19.850,000] <dbg> modem_cellular: modem_cellular_log_state_changed: switch from await registered to carrier on
[00:00:19.850,000] <dbg> modem_cellular: modem_cellular_log_event: event script success
[00:00:19.850,000] <dbg> net_l2_ppp: ppp_change_phase_debug: (0x3fca9e58): [0x3fcaa520] phase DEAD (0) => ESTABLISH (1) (ppp_open_async():202)
[00:00:19.850,000] <dbg> net_l2_ppp: ppp_open_async: (0x3fca9e58): Starting LCP
[00:00:19.850,000] <dbg> net_l2_ppp: ppp_fsm_lower_up: (0x3fca9e58): [LCP/0x3fcaa558] Current state INITIAL (0)
[00:00:19.850,000] <dbg> net_l2_ppp: ppp_change_state_debug: (0x3fca9e58): [LCP/0x3fcaa558] state INITIAL (0) => CLOSED (2) (ppp_fsm_lower_up():312)
[00:00:19.850,000] <dbg> net_l2_ppp: ppp_fsm_open: (0x3fca9e58): [LCP/0x3fcaa558] Current state CLOSED (2)
[00:00:19.850,000] <dbg> net_l2_ppp: ppp_change_state_debug: (0x3fca9e58): [LCP/0x3fcaa558] state CLOSED (2) => REQUEST_SENT (6) (ppp_fsm_open():335)
[00:00:19.850,000] <dbg> net_l2_ppp: fsm_send_configure_req: (0x3fca9e58): [LCP/0x3fcaa558] Sending Configure-Req (1) id 1 to peer while in REQUEST_SENT (6)
[00:00:19.850,000] <dbg> net_l2_ppp: ppp_send_pkt: (0x3fca9e58): [LCP/0x3fcaa558] Sending 10 bytes pkt 0x3fc994c0 (options len 4)
[00:00:19.851,000] <dbg> net_l2_ppp: net_pkt_hexdump: send L2
[00:00:19.851,000] <dbg> net_l2_ppp: net_pkt_hexdump: 0x3fc994c0
                                     c0 21 01 01 00 08                                |.!....
[00:00:19.851,000] <dbg> net_l2_ppp: net_pkt_hexdump: 0x3fc994c0
                                     01 04 05 dc                                      |....
[00:00:19.878,000] <dbg> modem_ppp: modem_ppp_process_received_byte: Receiving PPP frame
[00:00:19.878,000] <dbg> modem_ppp: modem_ppp_process_received_byte: Received PPP frame (len 24)
[00:00:19.878,000] <dbg> modem_ppp: modem_ppp_process_received_byte: Receiving PPP frame
[00:00:19.879,000] <dbg> net_l2_ppp: net_pkt_hexdump: recv L2
[00:00:19.879,000] <dbg> net_l2_ppp: net_pkt_hexdump: 0x3fc995c0
                                     c0 21 01 01 00 14 02 06  00 00 00 00 05 06 44 f9 |.!...... ......D.
                                     b1 da 07 02 08 02                                |......
[00:00:19.879,000] <dbg> net_l2_ppp: ppp_fsm_input: (0x3fcaa318): [LCP/0x3fcaa558] LCP Configure-Req (1) id 1 payload len 16
[00:00:19.879,000] <dbg> net_l2_ppp: fsm_recv_configure_req: (0x3fcaa318): [LCP/0x3fcaa558] Current state REQUEST_SENT (6)
[00:00:19.879,000] <dbg> net_l2_ppp: ppp_parse_options: (0x3fcaa318): [LCP/0x3fcaa558] option ASYNC_CTRL_CHAR_MAP (2) len 6
[00:00:19.879,000] <dbg> net_l2_ppp: ppp_parse_option_conf_req_unsupported: (0x3fcaa318): [LCP/0x3fcaa558] Check option ASYNC_CTRL_CHAR_MAP (2) len 4
[00:00:19.879,000] <dbg> net_l2_ppp: ppp_parse_options: (0x3fcaa318): [LCP/0x3fcaa558] option MAGIC_NUMBER (5) len 6
[00:00:19.879,000] <dbg> net_l2_ppp: ppp_parse_option_conf_req_unsupported: (0x3fcaa318): [LCP/0x3fcaa558] Check option MAGIC_NUMBER (5) len 4
[00:00:19.879,000] <dbg> net_l2_ppp: ppp_parse_options: (0x3fcaa318): [LCP/0x3fcaa558] option PROTO_COMPRESS (7) len 2
[00:00:19.879,000] <dbg> net_l2_ppp: ppp_parse_option_conf_req_unsupported: (0x3fcaa318): [LCP/0x3fcaa558] Check option PROTO_COMPRESS (7) len 0
[00:00:19.879,000] <dbg> net_l2_ppp: ppp_parse_options: (0x3fcaa318): [LCP/0x3fcaa558] option ADDR_CTRL_COMPRESS (8) len 2
[00:00:19.879,000] <dbg> net_l2_ppp: ppp_parse_option_conf_req_unsupported: (0x3fcaa318): [LCP/0x3fcaa558] Check option ADDR_CTRL_COMPRESS (8) len 0
[00:00:19.879,000] <dbg> net_l2_ppp: fsm_recv_configure_req: (0x3fcaa318): [LCP/0x3fcaa558] Sending Configure-Rej (4) id 1 to peer while in REQUEST_SENT (6)
[00:00:19.879,000] <dbg> net_l2_ppp: ppp_send_pkt: (0x3fcaa318): [LCP/0x3fcaa558] Sending 22 bytes pkt 0x3fc994c0 (options len 16)
[00:00:19.879,000] <dbg> net_l2_ppp: net_pkt_hexdump: send L2
[00:00:19.879,000] <dbg> net_l2_ppp: net_pkt_hexdump: 0x3fc994c0
                                     c0 21 04 01 00 14                                |.!....
[00:00:19.879,000] <dbg> net_l2_ppp: net_pkt_hexdump: 0x3fc994c0
                                     02 06 00 00 00 00 05 06  44 f9 b1 da 07 02 08 02 |........ D.......
[00:00:19.879,000] <dbg> modem_ppp: modem_ppp_process_received_byte: Received PPP frame (len 12)
[00:00:19.879,000] <dbg> net_l2_ppp: net_pkt_hexdump: recv L2
[00:00:19.879,000] <dbg> net_l2_ppp: net_pkt_hexdump: 0x3fc99580
                                     c0 21 02 01 00 08 01 04  05 dc                   |.!...... ..

UART_ASYNC_API log:
[00:00:20.009,000] <dbg> modem_cellular: modem_cellular_log_state_changed: switch from await registered to carrier on
[00:00:20.009,000] <dbg> modem_cellular: modem_cellular_log_event: event script success
[00:00:20.009,000] <dbg> net_l2_ppp: ppp_change_phase_debug: (0x3fcaa1a8): [0x3fcaa870] phase DEAD (0) => ESTABLISH (1) (ppp_open_async():202)
[00:00:20.009,000] <dbg> net_l2_ppp: ppp_open_async: (0x3fcaa1a8): Starting LCP
[00:00:20.009,000] <dbg> net_l2_ppp: ppp_fsm_lower_up: (0x3fcaa1a8): [LCP/0x3fcaa8a8] Current state INITIAL (0)
[00:00:20.010,000] <dbg> net_l2_ppp: ppp_change_state_debug: (0x3fcaa1a8): [LCP/0x3fcaa8a8] state INITIAL (0) => CLOSED (2) (ppp_fsm_lower_up():312)
[00:00:20.010,000] <dbg> net_l2_ppp: ppp_fsm_open: (0x3fcaa1a8): [LCP/0x3fcaa8a8] Current state CLOSED (2)
[00:00:20.010,000] <dbg> net_l2_ppp: ppp_change_state_debug: (0x3fcaa1a8): [LCP/0x3fcaa8a8] state CLOSED (2) => REQUEST_SENT (6) (ppp_fsm_open():335)
[00:00:20.010,000] <dbg> net_l2_ppp: fsm_send_configure_req: (0x3fcaa1a8): [LCP/0x3fcaa8a8] Sending Configure-Req (1) id 1 to peer while in REQUEST_SENT (6)
[00:00:20.010,000] <dbg> net_l2_ppp: ppp_send_pkt: (0x3fcaa1a8): [LCP/0x3fcaa8a8] Sending 10 bytes pkt 0x3fc99810 (options len 4)
[00:00:20.010,000] <dbg> net_l2_ppp: net_pkt_hexdump: send L2
[00:00:20.010,000] <dbg> net_l2_ppp: net_pkt_hexdump: 0x3fc99810
                                     c0 21 01 01 00 08                                |.!....
[00:00:20.010,000] <dbg> net_l2_ppp: net_pkt_hexdump: 0x3fc99810
                                     01 04 05 dc                                      |....
[00:00:22.009,000] <dbg> modem_cellular: modem_cellular_log_event: event timeout
[00:00:23.010,000] <dbg> net_l2_ppp: ppp_fsm_timeout: (0x3fcaad28): [LCP/0x3fcaa8a8] Current state REQUEST_SENT (6)
[00:00:23.010,000] <dbg> net_l2_ppp: fsm_send_configure_req: (0x3fcaad28): [LCP/0x3fcaa8a8] Sending Configure-Req (1) id 1 to peer while in REQUEST_SENT (6)
[00:00:23.010,000] <dbg> net_l2_ppp: ppp_send_pkt: (0x3fcaad28): [LCP/0x3fcaa8a8] Sending 10 bytes pkt 0x3fc99810 (options len 4)
[00:00:23.010,000] <dbg> net_l2_ppp: net_pkt_hexdump: send L2
[00:00:23.011,000] <dbg> net_l2_ppp: net_pkt_hexdump: 0x3fc99810
                                     c0 21 01 01 00 08                                |.!....
[00:00:23.011,000] <dbg> net_l2_ppp: net_pkt_hexdump: 0x3fc99810
                                     01 04 05 dc                                      |....
[00:00:26.010,000] <dbg> net_l2_ppp: ppp_fsm_timeout: (0x3fcaad28): [LCP/0x3fcaa8a8] Current state REQUEST_SENT (6)
[00:00:26.011,000] <dbg> net_l2_ppp: fsm_send_configure_req: (0x3fcaad28): [LCP/0x3fcaa8a8] Sending Configure-Req (1) id 1 to peer while in REQUEST_SENT (6)
[00:00:26.011,000] <dbg> net_l2_ppp: ppp_send_pkt: (0x3fcaad28): [LCP/0x3fcaa8a8] Sending 10 bytes pkt 0x3fc99810 (options len 4)
[00:00:26.011,000] <dbg> net_l2_ppp: net_pkt_hexdump: send L2
[00:00:26.011,000] <dbg> net_l2_ppp: net_pkt_hexdump: 0x3fc99810
                                     c0 21 01 01 00 08                                |.!....
[00:00:26.011,000] <dbg> net_l2_ppp: net_pkt_hexdump: 0x3fc99810
                                     01 04 05 dc                                      |....
[00:00:29.011,000] <dbg> net_l2_ppp: ppp_fsm_timeout: (0x3fcaad28): [LCP/0x3fcaa8a8] Current state REQUEST_SENT (6)
[00:00:29.011,000] <dbg> net_l2_ppp: fsm_send_configure_req: (0x3fcaad28): [LCP/0x3fcaa8a8] Sending Configure-Req (1) id 1 to peer while in REQUEST_SENT (6)
[00:00:29.011,000] <dbg> net_l2_ppp: ppp_send_pkt: (0x3fcaad28): [LCP/0x3fcaa8a8] Sending 10 bytes pkt 0x3fc99810 (options len 4)
[00:00:29.011,000] <dbg> net_l2_ppp: net_pkt_hexdump: send L2
[00:00:29.011,000] <dbg> net_l2_ppp: net_pkt_hexdump: 0x3fc99810
                                     c0 21 01 01 00 08                                |.!....
[00:00:29.011,000] <dbg> net_l2_ppp: net_pkt_hexdump: 0x3fc99810
                                     01 04 05 dc                                      |....

Environment:

OS: Ubuntu 22.04
Toolchain: Zephyr SDK
Version used: 3.6.99

Fixed by https://github.com/zephyrproject-rtos/zephyr/pull/72453


docs: Fixed typos in content

*Issue #7  *
Resolves Issue #7
Description of changes:

Fixed some of the typos in the content page.
Fixed the markdown newline issues on the workflow with the PR.
Removed reference of random provider from the Terraform Cloud setup documentation with the changes in tfc-guide-example.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

LGTM


Add CI to lint data examples in docs

We provide lots of examples of training data and domains in our documentation. It would be great to have CI that validates whether these examples are valid rasa format. We can use the existing rasa methods to validate this.
Implementation:

on the rendering side, docusaurus uses Prisme. And it looks possible to add a custom language (i’d suggesting “yaml-rasa”). So basically we would add a new language that has the same syntax as yaml.
on the CI side: it should be possible to detect codeblocks of a specific type. This is was we’re currently doing in our of our plugins. This way we can run tests that pass each codeblock of this type through the training data reader/linter.

@m-vdb would step 1 be something that you or @lunelson do? I am happy to take on step 2. I've seen this come up quite a lot during the alpha, so would love to have it around

would step 1 be something that you or @lunelson do?
@erohmensing yeah that sounds possible. Is the main concern here that you want to lint these things on build, or that you want to highlight them a different way, or that you just want to the code block to indicate that it's "rasa yaml" not just "yaml"?

Main concert is linting things on build to make sure they're valid! I don't know one adds a custom language, but for these purposes it could be just a subclass of the yaml one that behaves exactly the same, but is rasa yaml, and therefore needs to be linted in the CI.
highlighting them in a different way could also be cool but is likely unnecessary 😄

OK cool. The linting process sounds like something that could be added alongside the other build scripts that run in the pre-build step, as a node script that just extracts those codeblocks on the basis of regexes, wdyt @m-vdb ?

yes that's what I had in mind. In terms of prio, it doesn't strike me as something we need to do now (as opposed to after 2.0 release). WDYT @erohmensing ?

Mm, I think it'd be really good to have it for the 2.0 release. This would make sure that every example we give is actually valid, which is especially important when we're trying to tell users how to use a completely new training format for them.


[ENHANCEMENT] When failed to restore vm from backup should display well message on progress bar and volume percentage

Is your enhancement related to a problem? Please describe.

When restore backup to create new vm failed due to remote NFS service not working,
The relative restore progress bar and volume percentage on the vm did not well displayed for the actual state
It would stuck in restoring state

https://github.com/harvester/harvester/assets/29251855/2cb5eabb-56d4-4c5e-98e8-b52d0d165716
Describe the solution you'd like

Perhaps we can have the enhancement to provide error message like unable to reach the service or the snapshot creation failed as we can see on the backup

To Reproduce
Steps to reproduce the behavior:

Setup NFS backup target
Create a backup from a running vm
Stop the NFS service on the remote server
Restore the backup to create a new VM
Check the restore status, progress bar and volume percentage

Additional context

Found when validating issue #4102

I tried to reproduce with the same steps, and found there is no error reported for PVC and PV:
PVC is in phase Bound without any error
apiVersion: v1
kind: PersistentVolumeClaim
metadata:
  name: restore-vm-b1-6520c4a7-e7cf-45e0-865d-7c4511764f64-disk-0
  namespace: default
  ownerReferences:
  - apiVersion: harvesterhci.io/v1beta1
    blockOwnerDeletion: true
    controller: true
    kind: VirtualMachineRestore
    name: restore-vm-b1-l64wh
    uid: 6520c4a7-e7cf-45e0-865d-7c4511764f64
  resourceVersion: "731730"
  uid: 730228c7-de61-4192-840d-cef7a6136b70
spec:
  ...
status:
  accessModes:
  - ReadWriteMany
  capacity:
    storage: 10Gi
  phase: Bound

PV is also in phase Bound without any error
apiVersion: v1
kind: PersistentVolume
metadata:
  name: pvc-730228c7-de61-4192-840d-cef7a6136b70
spec:
 ...
status:
  phase: Bound

That's why the VMRestore controller treats the PVC creation as a success and waits for VM starting.
We only can find the related error message in LH CSI plugin daemonset:
time="2024-01-29T03:19:49Z" level=error msg="ControllerPublishVolume: err: rpc error: code = Aborted desc = volume pvc-730228c7-de61-4192-840d-cef7a6136b
│ 70 is not ready for workloads" func=csi.logGRPC file="server.go:138"

This is from the source code snippet, and it's brought by   the volume ready checking, because in such condition, the backup target is invalid, and the volume's always status.restoreRequired kept as True.

We may workaround this with the following steps:

If the VM restoring is Restore New

Deleting the restoring VM

If the VM restoring is Restore Existing and Delete policy for previous volumes

Deleting VMRestore object, e.q. kubectl delete virtualmachinerestores.harvesterhci.io <VM Restore Name>
Stopping VM by Harvester GUI
Pointing VM to use the previous volume (PVC)

E.q. edit's VM's .spec.template.volumes[0].persistentVolumeClaim.claimName


[5.0] Cleanup of library from the old architecture

As part of 5.0 release we want to simplify the library by changing it’s architecture. This will allow us to remove any code duplication that is part of the current release of the library
Change design
Current hierarchy for every CoreBluetooth object looks as follows:

Main object that user of the library is interacting with ie. Peripheral
Protocol that exposes delegate method callbacks & methods that perform Bluetooth related operations (scan, connection) ie. RxPeripheralType.
Concrete implementation of the protocol that is using CoreBluetooth objects: RxCBPeripheral. These are injected to the main objects and allow for the normal use of the library
Fakes that are implementing the protocols ie. FakePeripheral. We’re injecting them into main objects for the purpose of unit tests.

We would like to get rid of the last 3 layers when implementing the cleanup.  After the currently described issue will be implemented tests will not be a part of the library and will come back a bit later. We believe that the new approach to testing the library will be much easier and allow to make changes and API additions faster. It should also make tests way more concise than today.
As a result of this task:

All protocols, concrete implementations and fakes should be removed
Tests related to the Bluetooth stack hierarchy should be removed

Then, all main, user facing objects will directly use it’s CB counterparts and call the methods on them. To receive delegate callbacks, BluetoothManager and Peripheral will contain delegate wrappers object. First one will conform to the CBCentralManagerDelegate protocol and the second one to the CBPeripheralDelegate protocol. Both will expose delegate callbacks via observables to the main objects.
How it affects the current users
External API of the BluetoothManager, Peripheral, Service, Characteristic, Descriptor and any of the dependent objects will not be changed. Therefore it is not considered a breaking change.

Completed in #171


Windshaft exits with error Cannot find module 'millstone'

I really like this project - pity I am unable to contribute to the project at this stage, hoping to so in the future.
Windshaft container has status Exit 1 - any ideas what could be the issue
Starting the Windshaft node application...
Logs will be written to /carto/Windshaft-cartodb/logs/windshaft.log
internal/modules/cjs/loader.js:584
throw err;
^
Error: Cannot find module 'millstone'
at Function.Module._resolveFilename (internal/modules/cjs/loader.js:582:15)
at Function.Module._load (internal/modules/cjs/loader.js:508:25)
at Module.require (internal/modules/cjs/loader.js:637:17)
at require (internal/modules/cjs/helpers.js:22:18)
at Object. (/carto/Windshaft-cartodb/node_modules/grainstore/lib/grainstore/mml-builder/mml-builder-inline.js:4:17)
at Module._compile (internal/modules/cjs/loader.js:701:30)
at Object.Module._extensions..js (internal/modules/cjs/loader.js:712:10)
at Module.load (internal/modules/cjs/loader.js:600:32)
at tryModuleLoad (internal/modules/cjs/loader.js:539:12)
at Function.Module._load (internal/modules/cjs/loader.js:531:3)

This was being caused because, for whatever reason, you have to do two sequential calls to npm install, and I was only making one. Corrected in e88acae12da141187aed413e6a492cc875b5dfe2.


Replace lots of hamcrest's assert_that with a builder style

Refs #5742
I've been thinking of possible solutions to close out #5742, so I'm submitting this for early feedback.
@alexcrichton what do you think? If you like the look of this I'll apply it across the suite.
r? @alexcrichton

Looking good to me! I wonder if we could lift the requirement though of requiring both execs and run? Having both feels slightly redundant (but I think one is good to keep)

Yeah we can make .cargo return execs and then forward the ProcessBuilder methods used in the test suite.
How do you feel, instead, about running the assert in the Drop? It would remove the need for to expressly execute .run() but maybe it's a bad practice? .run() would still be there when you want to force the execution order. I'm torn :smile:

Sounds plausible to me! (having .cargo return Execs)
I'd be more wary of removing the need for .run() in the sense that having such significant behavior happen in a destructor can be a bit scary for codegen reasons here and there.

Looks great to me!

This doesn't completely remove hamcrest, but it does a lot.
I'm concerned that grand refactorings will clash with parallel development in PRs, so I'd love to land this PR into master and send follow up PRs to close out #5742.

Could someone restart AppVeyor please?

Yeah but both are noisy.
That said my commenting is also noisy so I'm not doing any better..

Holy cow, nice! Thanks so much for taking this on!
Let's definitely get this in before it bitrots!
@bors: r+

:pushpin: Commit 85984a870002ce72d76c45d4e06e1eaa198dd883 has been approved by alexcrichton

:hourglass: Testing commit 85984a870002ce72d76c45d4e06e1eaa198dd883 with merge 9ddf75a9da333102c63e054ae2e3bade0a204e9a...

:sunny: Test successful - status-appveyor, status-travis
Approved by: alexcrichton
Pushing 9ddf75a9da333102c63e054ae2e3bade0a204e9a to master...

And another net negative PR. If you keep up with this the project will just disappear. :-P


ImageUploader - resize image before upload

I can't find the way to make image smaller before upload to the server. The sandbox.js does not provide the solution. I think many of us have same problem.
Please help.

Hi @saso-petrov,
Thanks for your interest in CT. Regarding your question can you clarify it for me? Do you want to shrink the image in size (e.g width x height) client-side and then upload the image to the server before using the URL returned by the server to show the image in the CT image dialog?
If so, an example of client-side image manipulation was posted here: https://github.com/GetmeUK/ContentTools/issues/136 (thanks to @Qqwy).
In my implementations currently I reduce the size of the image server-side and store a copy of the original as well as the working draft (with an admittadly 'space is cheap so ehh...' attitude), this way I always have the original to use when creating resized versions of the image which provides the best output quality. If you haven't already looked it's worth checking out the Handling Image Uploads tutorial.


Improve: vCard Export Fields

Improve vCard fields

Added method to extract display photo URL and include in vCard export
Tweaked fields to better match expected
Added support for multiple phone numbers

Refactore InternalDb methods and structure
Update README

ZIP for testing: build_1.2.0_06092020_1008.zip


[BE] endpoint PUT "/api/v1/favorites" accepts an entire "Resource" on the request

It should only accept a CUID on the request, not an entire Resource.

already accepts a CUID

https://github.com/IT-Academy-BCN/ita-wiki/blob/83cd088c680c0ca23b898d8c7e049d05b3484bf4/back/src/schemas/favorites/favoritePutSchema.ts#L3-L14


ciao-cli: Add volume detach and fix a typo

This PR adds support for the volume detach command and also fixes a small typo in the help for the attach command.

Coverage increased (+0.01%) to 65.815% when pulling 370c0e92ed0aae9d12820074280ec75c883d9804 on markdryan:kaccardi/topic/storage into 4ed30053f6d80b149ba88b8d21144f88d797de1d on 01org:kaccardi/topic/storage.


Feature/issue 64 Add Github Issue and Pull Request Templates

Description of the change:

Fixes #64
Creates 2 new .md files with templates for making pull requests and filing issues
Files are based on existing guidelines in CONTRIBUTING.md, and in existing Sendgrid projects (namely @ksigler7 's work in the /docs project ).
Fixed broken link in CONTRIBUTING.md

Reason for the change:
These templates will make community contributions more consistent by embedding project guidelines directly into the Pull Request/Issue Filing process. See #64 for further discussion/context.
Checklist
Make sure all of these items are complete, or else the PR will be ineligible for a code review.

[x] Code passes all existing tests
[x] Any new functionality added includes new unit tests in tests/test.py
[x] Create or update example code to show the new functionality in action.
[x] All code, branch, and git naming and style conventions are followed (see CONTRIBUTING.md)
[x] Feature branch has been rebased off of the latest master branch. ( see CONTRIBUTING.md ).

Hello @hydrosquall,Thanks again for the PR! It's HACKTOBERFEST! We want to show our appreciation by sending                                              you some special Hacktoberfest swag. If you have not already, could you please fill out                                              this form so we can send it to you? Thanks!                                             Team SendGrid DX


Update node_helper.js

updating to use the one call 3.0 api

using this patch i still cannot get the app to output any data unfortunately. it just remains "loading" despite the API key working via URL (eg: https://api.openweathermap.org/data/3.0/onecall?lat=38.252666&lon=-85.758453&appid=myapikey)

Are you getting anything from the Magic Mirror logs? I verified its still working for me with this patch.

The out.log only displays:
[29.03.2023 16:02.36.378] [LOG]   [MMM-OpenWeatherMapForecast] 29-Mar-23 16:02 ** ERROR ** Latitude and/or longitude not provided.
however my module reads:
            {
                    module: "MMM-OpenWeatherMapForecast",
                    header: "Weather",
                    position: "bottom_left",
                    config: {
                            apikey: "myapikey",
                            latitutde: "38.252666",
                            longitude: "-85.758453",
                            iconset: "6oa",
                            forecastLayout: "table"
                    }
            },

go pull my master branch again and see if that works.  I've verified that the version i'm using is identical to the version that is the master branch on my github page.  Are you using imperial or metric for your units?  Also are you running npm install in the directory after you clone it?  Are you running in docker?  If so, you have to run npm install inside the docker container for it to work.

I'm using imperial as my units. I cloned the master branch repo (https://github.com/thehigherlife/MMM-OpenWeatherMapForecast), cd'd to the directory, ran npm install. I've changed nothing else, and MMM-OpenWeatherMapForecast replaces the spot where the original default weather module was (which also uses openweatherAPI, just not the 3.0 API, and does work). On the MM, it just displays "loading" but never loads. I'm not running in docker, just running it off raspi4b+ hardware

in your config you have a typo:  latitutde instead of latitude

i am an absolute idiot

no worries.  glad we got it working!

thank you for the help, wish original author would merge your work! you've brought the module back to life

is it just me or does the v3.0 api require a subscription with payment info, even if you limit it to the free 1k calls/day?
when i tried this update, it is stuck "Loading…", and the api returns the the following:

{"cod":401, "message": "Please note that using One Call 3.0 requires a separate subscription to the One Call by Call plan. Learn more here https://openweathermap.org/price. If you have a valid subscription to the One Call by Call plan, but still receive this error, then please see https://openweathermap.org/faq#error401 for more info."}

for this reason i don't think v3.0 should be the default, and i've added it as a config option named "endpoint".. have a look at this commit: https://github.com/MarcLandis/MMM-OpenWeatherMapForecast/commit/a0ead66f9e8f05b3d43f820dbb57aafdd8474ee3

That works, you'll probably want to default to 3.0.  the problem is if you try to sign up today as a new user you can't get the 2.5 API access.  You can only get the 3.0 access so since I was new to OpenWeatherMap 3.0 was the only option.

I have added the commit @a0ead66 by luxiouronimo
Sorry for not merging this - I didn't notice the request.


docs(User Guide): Add to the documentation Waitress server working with Falcon

I would like share with others Windows users this documentation which can help them easy start using Falcon framework on Windows machines.
I spent more that few hours to find out how to easy run Falcon examples on Windows. I suppose that is more than one person, which have the same problems as I had.

Current coverage is 100% (diff: 100%)

Merging #946 into master will not change coverage

@@           master   #946   diff @@
====================================
  Files          31     31
  Lines        1989   1989
  Methods         0      0
  Messages        0      0
  Branches      328    328
====================================
  Hits         1989   1989
  Misses          0      0
  Partials        0      0

Powered by Codecov. Last update 463593f...35c1adf


Add webhooks to jobs

Adds a webhook to each job for build events (start/finish) for metric gathering
/cc @jaredpar @smile21prc

Please hold off on this until I can get the view code inserted.

Yes, I'm leaving it up to you guys to merge


Add real-time annotation

We will run out of tapes by February. Need to add real-time annotation to UI. Notional idea is:

Selecting real-time in UI will open (or create if needed) a VideoSequence for the dive/deployment. We'll have to figure out an appropriate URI to use for the VideoReference
It will also create a video that spans the duration of the dive.

On closing, it it should update the duration of the video to be calculated from the last annotation.

Creating an annotation will grab the recordedTimestamp from the computer's clock and use that as the annotation's index.

In addition, we'll need to do the following to the GUI when annotating in real-time

Remove or disable Video controls

Replace with real-time clock display

Wire in the following for a real-time mediaplayer

vars-avfoundation for framegrabs

I've installed this on the Rachel Carson. I'm closing this but we really need to complete #49 for this to be truly complete.


Development: Improve client test speed of user-management-component

Checklist
Client

[x] I followed the coding and design guidelines.

Motivation and Context

As part of further client test speed improvements, I fixed the test for the user management components by applying the guidelines we agreed on.
Description

Improvement:
16.735 s -> less than 1s.
Steps for Testing

Prerequisites:
Check if the changes look good!

@MDK5 great, thanks for the suggestions. Applied all of them!


Pass in the correct file for LwjglNative extraction fixes #3578

Passes in the correct File to be extracted.  It's fairly ugly.

I am not too familiar with this module. However, could you not have two ? operators in the same function call? Maybe have two variable declaration statements (using meaningful names) where you set both parameters in each case, then pass those parameters in the function calls.
That would make this a lot clearer.

Yup, just wanted to change as little as possible in the original commit. I've changed it now.

:+1: Confirm fix on Linux.

Since snapshot is broken for everybody regardless of the operative system, can we merge this fix now?

Confirmed fix on windows as well. Let's pull this in, although I'm not sure what the original issue was. Perhaps @NathanSweet can confirm.

Great :+1:


Disable persistence locally

Writing an E2E suite which fires up wrangler dev --local, but I want to get a clean slate each time. Atm I can rm -rf .mf before each run, but I couldn't find a way to just disable persistence for the current run (in case I had dev data stored in .mf, say).
I tried adding the following to wrangler.toml as per https://miniflare.dev/storage/durable-objects#persistence:
[miniflare]
durable_objects_persist = false
cache_persist = false

But it didn't seem to take effect. Ideally, CLI args would be best, since I can invoke them from my test runner easily.
There's not a way to do this already is there?  :)

We should always disable persistence? Each wrangler dev session is fresh on the edge, any downsides to making the same behaviour for local?

I can see that, for sure. I'd actually thought the best approach to dev persistence was defining like a seed.json file that declares a bunch of data to start a new dev session with. That could be made to work with both edge and local mode...

I'm not certain an CLI flag is the way forward here, because except for tests, this won't be that useful. We do want to figure out how to use wrangler inside tests, and for that usecase this would be perfect.

By the way, we don't disable persistence for wrangler dev, except for Durable Objects. KV writes don't use the copy-on-write thing right now. Not sure about Cache.

(but I am warming up to the idea of disabling persistence by default...)


WebAssembly support

Hi,
I know that WebAssembly is still very young, but will you support it? I guess it would make a big performance change in a physics engine like this.

Well as far as I know to use WebAssembly it would require manually porting the codebase to into assembly to get much benefit. This is a huge task and it would essentially be a new project. Though, if it is possible to port only the most performance intensive parts of the engine (like collisions) it might be worth it.


Fix decrypting pack config keys under additionalProperties

The pack config loader uses "secret: true" in a schema to trigger decrypting a key from the datastore. However, it does not look at the schema under additionalProperties, so those properties can't use encrypted keys.
This issue was first documented in https://github.com/StackStorm-Exchange/stackstorm-jira/pull/19#discussion_r242319464
This PR fixes that so that the pack config loader handles additionalProperties when defined.

I'm force-pushing to re-trigger tests to get the integration test to pass. I can't figure out why one of 3 chunks has been failing.

All GHA tests are passing. CircleCI tests are broken due to a pbr+logshipper issue (known based on conversation in slack).

Nice work :+1:
I will have a more detailed look later this week.

Weird. I'm patching a v3.2 StackStorm running python2.7 and this delta was insufficient. afaik, the behavior of defaultdict should be the same under python3, so I'm not sure why the unit test is passing.

Overall LGTM, just had some questions / comments on internal implementation details.

Some of those integration tests still seem to be failing quite often due to race / similar, quite annoying.
We should probably modify that job step to try to retry up to 2-3 times on failure to avoid annoying and manual re-run of the complete workflow.

GHA is passing now. Hooray.
Circle failed. Could you restart https://app.circleci.com/pipelines/github/StackStorm/st2/1542/workflows/128ecfa9-04ff-4b05-b410-94541fb12be2/jobs/12968/parallel-runs/2

All tests are green. Quick, let's merge before anything else gets merged into master. :)


Add label_singular to collection config

Hello 👋
This PR adds label_singular to collection config.
Fixes #684
- Summary
This field will be used in the UI in places where a singular label makes more sense. For example:
If you have a "Posts" collection, the "add collection" button in the UI will show as "New Post" rather than "New Posts".
I went with label_singular because I foresee majority of Collection names being in plural. Therefore, I think by default the label should respect the collection name.
However I'm happy to change it to label_plural if needed.
- Test plan
There doesn't seem to be tests for certain fields in the config, such as label, perhaps because these are optional fields. For this reason I have not written any tests.
- Description for the changelog
Add label_singular to collection config

Deploy preview for netlify-cms-www ready!
Built with commit d7ca84a5cf038cc326d4b647e0fbcd3ebe0d229d
https://deploy-preview-1086--netlify-cms-www.netlify.com

Deploy preview for cms-demo ready!
Built with commit d7ca84a5cf038cc326d4b647e0fbcd3ebe0d229d
https://deploy-preview-1086--cms-demo.netlify.com

Deploy preview for netlify-cms-www ready!
Built with commit 164da37580f42618c8f709a4608a6e2ed2c5c80e
https://deploy-preview-1086--netlify-cms-www.netlify.com

Deploy preview for cms-demo ready!
Built with commit 164da37580f42618c8f709a4608a6e2ed2c5c80e
https://deploy-preview-1086--cms-demo.netlify.com

@erquhart that's cool thank you!
I see this PR is now conflicting with master, I can resolve these.
Would you like me to rebase master into this branch too (as per contributing docs)?

Just fixed actually - merged a newer PR by mistake earlier and broke a bunch.

@erquhart well thank you! 🙏

@peduarte Thank you for including the matching docs update!! 😉
label_singular makes sense to me, and matches other CMS configs, like WordPress. We may want to run by @biilmann, since it was his desire to bring automatic pluralization that caused me to propose the label_plural version in the issue. :)

@verythorough So I assume it was originally thought of as an override for automatic pluralization, whereas this would be strictly manual?

@tech4him1 that's correct. The goal of this implementation is to be strictly manual, as it's been discovered that trying to intelligently pluralize/singularize words doesn't work.

Hey guys, is there an "ETA" for this? Thanks! 👍

I see no blockers, and it looks like @erquhart approved, so I think we're good to go. Thanks for the nudge, and for the contribution! I'm looking forward to making use of this.