Add Uniform State Preparation

Summary
Closes #11735
Details and comments

#11735

@woodsp-ibm I have put this as draft as you mentioned before. But I don't understand the errors in some of these checks. Can you please give some insight regarding this?

One aspect is the formatting of the code, the style is checked via black you need to run that on your code locally - see https://github.com/Qiskit/qiskit/blob/main/CONTRIBUTING.md#style-and-lint

lint: commands[0]> black --check qiskit test tools examples setup.py
would reformat /home/vsts/work/1/s/qiskit/circuit/library/data_preparation/state_preparation.py
Oh no! 💥 💔 💥
1 file would be reformatted, 1257 files would be left unchanged.

The other is a cyclic import - I copied some of the error below. You have add this import from qiskit.visualization import circuit_drawer but I did not see anything in the added code using it and it would seem strange to import visualization logic here anyway. I would remove that and it most likely will eliminate the cyclic error in doing so.
  File "/home/vsts/work/1/s/qiskit/circuit/library/data_preparation/state_preparation.py", line 31, in <module>
    from qiskit.visualization import circuit_drawer
  File "/home/vsts/work/1/s/qiskit/visualization/__init__.py", line 259, in <module>
    from .circuit import circuit_drawer
  File "/home/vsts/work/1/s/qiskit/visualization/circuit/__init__.py", line 15, in <module>
    from .circuit_visualization import circuit_drawer
  File "/home/vsts/work/1/s/qiskit/visualization/circuit/circuit_visualization.py", line 39, in <module>
    from qiskit.circuit import ControlFlowOp, Measure
ImportError: cannot import name 'ControlFlowOp' from partially initialized module 'qiskit.circuit' (most likely due to a circular import) (/home/vsts/work/1/s/qiskit/circuit/__init__.py)

================================================================================
The above traceback was encountered during test discovery which imports all the found test modules in the specified test_path.

You will need to add unit test(s) too, its good to have already as it will show the code is working as intended.

Hi @woodsp-ibm, I have done the changes as you suggested and even tested it locally. Please have a look into this and suggest future steps.
Thank you!

It seems a test, that is a general test for equivalence, is picking up on your new "Gate" and failing. If you look that test has a exclusion list https://github.com/Qiskit/qiskit/blob/a7cc16624a719332b8ad5ab764425dca33f3952c/test/python/circuit/test_gate_definitions.py#L259 that already excludes StatePreparation - maybe this new one needs to be added there.
Since its failing on num_qubits, I was looking at StatePreparation and how it handles it there. Could this new one be made more compatible with that - ie compute for M the smallest n (where I think n there is synonomous with num_qubits right?) and let one expand things out otherwise by specifying num_qubits explicitly. I get that one can require num_qubits to always be specified - just wondering if it was done more like StatePreparation whether that would be good.

If StatePreparation is excluded from that test it made sense to me that your new class probably should be too.
Yes StatePreparation has num_qubits as optional and does that computation you refer to. It seemed like this could be done the same if that seems reasonable - it would perhaps make them more consistent in that regard.

Okay, that makes sense. I will try to do that as well. Thank you so much, Steve, for all the help and support!

@woodsp-ibm I think the reason why it is still giving the same error in Coverage report test is it might be testing it without the updated TestGateEquivalenceEqual which excludes this class, whereas the old one doesn't. One solution is to just submit a PR with the updated  TestGateEquivalenceEqual and once it is merged try this, but that may not be preferable with the reviewers.

Its not failing the same way though
test.python.circuit.library.test_generalized_uniform_superposition_gate.TestGeneralizedUniformSuperposition.test_generalized_uniform_superposition_gate
-------------------------------------------------------------------------------------------------------------------------------------------------------

Captured traceback:
~~~~~~~~~~~~~~~~~~~
    Traceback (most recent call last):

      File "/home/runner/work/qiskit/qiskit/test/python/circuit/library/test_generalized_uniform_superposition_gate.py", line 38, in test_generalized_uniform_superposition_gate
    gate = Generalized_Uniform_Superposition_Gate(M, n)

      File "/home/runner/work/qiskit/qiskit/qiskit/circuit/library/data_preparation/state_preparation.py", line 484, in __init__
    super().__init__("USup", num_qubits, [])

      File "/home/runner/work/qiskit/qiskit/qiskit/circuit/gate.py", line 46, in __init__
    super().__init__(name, num_qubits, 0, params, label=label, duration=duration, unit=unit)

      File "/home/runner/work/qiskit/qiskit/qiskit/circuit/instruction.py", line 80, in __init__
    raise CircuitError("num_qubits and num_clbits must be integer.")

    qiskit.circuit.exceptions.CircuitError: 'num_qubits and num_clbits must be integer.'

test.python.circuit.library.test_generalized_uniform_superposition_gate.TestGeneralizedUniformSuperposition.test_incompatible_M

this is from your code. In StatePreparation the super.init call is made later once the number of qubits is computed. Maybe compare to that as I think its failing due the super init call now.

Yes, Steve, the error is different, but only slightly. The fundamental error is the same. I think the error coming from ddt is not there because of the decorator I added. I believe if the same is checked with the class being excluded, this error won't be produced, and this is the only primary error currently.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Warning: This coverage report may be inaccurate.
This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

For more information on this, see Tracking coverage changes with pull request builds.
To avoid this issue with future PRs, see these Recommended CI Configurations.
For a quick fix, rebase this PR at GitHub. Your next report should be accurate.

Details

65 of 77 (84.42%)  changed or added relevant lines in 2 files are covered.
41 unchanged lines in 4 files lost coverage.
Overall coverage decreased (-0.02%) to 89.363%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

qiskit/circuit/library/data_preparation/state_preparation.py
63
75
84.0%

Files with Coverage Reduction
New Missed Lines
%

qiskit/synthesis/two_qubit/xx_decompose/circuits.py
1
92.86%

qiskit/synthesis/two_qubit/xx_decompose/decomposer.py
2
90.63%

crates/qasm2/src/lex.rs
5
92.62%

qiskit/transpiler/passes/synthesis/unitary_synthesis.py
33
89.02%

Totals

Change from base Build<PHONE_NUMBER>:
-0.02%

Covered Lines:
60345

Relevant Lines:
67528

💛  - Coveralls

Looks like things are passing - except you need to run black on the code to make sure its formatted with that as presently the black check is failing saying 3 files need formatting.

Yes, Steve, I have just done that. Hopefully, now all tests should pass. Thank you so you much for painstakingly helping me to debug this code, I couldn't have done it without your help and support.

I don't why these two files are failing black's check, when locally they're passing. I have also manually reviewed changes and there doesn't seem to be any.

Could you be using an older version of black? Maybe try updating it - CI will be using the latest version as I do not see any restriction in requirements_dev.txt other than avoiding one with a known problem

I changed to an environment with a newer version of python (since in that environment black was updated to the 'latest' version) and that gave some minor changes to these two files. Hopefully it passes this check now.

Its just the one file now. You have the pyproject.toml file there from the qiskit root right - that limits line length to 100. I see lines in the docstring that seem longer than that. Perhaps thats whys its failing?

Hi Steve, I downgraded to Python 3.8.18 (one which the checker uses), ran black, and then replace state_preparation.py file. This somehow still gives error. One possible reason would be that the black used by the checker is not 24.3.0, but rather some old version. Could you please check which version it could be, then I just have to install it and it would possibly pass the test?

I downloaded your state_preparation and put in in my qiskit project (I just put it qiskit folder to do black). Then from the root of that project I.e the level above qiskit I ran black --check qiskit test tools examples setup.py and it said that file would be changed. I removed --check and sure enough it changed it as I did a diff with the same file still in the Downloads folder I had made the copy into qiskit. My local Python is 3.9.7 and I updated black to the latest version. Is this how you are doing things - ie run the black from the project root? I am not sure why you are seeing a different outcome locally.

I see you managed to get black to alter the file so its ok in CI here. The changes look like what I saw locally. I see now its passing black that its getting further but now failing with the lint.

Hi Steve, finally all the checks have been successful :smile:. Thank you for all the help and support. Let me know what are the next future steps? Should I now select Ready for review?

Hi Steve, finally all the checks have been successful 😄. Thank you for all the help and support. Let me know what are the next future steps? Should I now select Ready for review?

You are most welcome. Yes I would take it out of Draft mode - it will eventually need a reno release note to be eligible to be merged (see https://github.com/Qiskit/qiskit/blob/main/CONTRIBUTING.md#adding-a-new-release-note ) - this documents  user facing changes, like this new feature. You can add it now if you like - there are examples in the releasenotes folder - or wait until someone from the core qiskit team has had a chance to go over this - up to you.

Okay, I'm taking it out of Draft mode. Yes, I'll later write a reno release note. Thanks, again, Steve!

I have added the reno release note as well. Hopefully this pull request gets approved.

A more minor thing - maybe you'd like to edit the title of the PR to something like Add Generalized Uniform State Preparation or something that is more descriptive of what this adds as Update state_preparation.py is more about how you did it and really says nothing about what the update is, plus people can easily see that your new feature was added there from the file changes.

Yes, that makes a lot of sense, Steve. I have changed the title. I hope all things have been checked out now and only have to wait for the reviewers to see this. Once again, thank you so much for all the help and support. This felt like a mini QAMP session :smile:.

@jakelishman We had a discussion in the original issue #11735 that was done for this feature. I have tried to help out here. Its in a state now I think where its ready for someone on the qiskit team to review

Hi Steve, do you know on average how long does it take for the pull-request to be reviewed?

Also, Steve - thanks very very much for doing all the first parts of the review.

Hi @jakelishman, thank you so much for the valuable feedback. I have incorporated mostly all the changes you asked for. I changed it to .. plot:: but since that was giving some error (unable to tell because -q flag, I reverted back to .. code-block::. And I changed the last line to just qc.draw(), so hopefully now that is also fine.
These are the following changes done:

Change name from "GenralizedUniformSuperpositionGate" to "UniformSuperpositionGate" as suggested.
Replace the following files to remove reference to "generalized" (as suggested): __init__.py, state_preparation.py, test_gate_definitions.py.
Replace "test_generalized_uniform_superposition_gate.py" with "test_uniform_superposition_gate.py".
Replace "generalized-uniform-superposition-gate-3bd95ffdf05ef18c.yaml" with "uniform-superposition-gate-3bd95ffdf05ef18c.yaml"
Note: If/else condition has been changed (as suggested).
Included math.ceil and math.log2 instead of np.ceil and np.log2.
m_value replaced by num_superpos_states
Changed assertTrue(np.allclose(x, y)) to np.testing.assert_allclose (as suggested).
Changed QiskitError to ValueError in the docstring of state_preparation.py file.
Deleted to_unitary() function in state_preparation.py and moved it to test_uniform_superposition_gate.py
Removed redundant definitions.
Addressed the following comment: "There's no need to store _num_qubits manually; it's part of the regular gate structure and accessible as self.num_qubits after the super().init call. We also don't need to store _m_value both manually and in self.params - it's best just to leave it in self.params, most likely."

Please let me know if there are any more changes required. Thanks in advance!

Hi @jakelishman, just a friendly reminder regarding this.

Hi @jakelishman, can you please take a look at the changes? If you're busy with other things, please let me know.

Hi @jakelishman, just a friendly reminder regarding this.

Hi @jakelishman or @woodsp-ibm, can you please review the recommended changes?

@Hirmay In the end here you need a maintainer of Qiskit to approve this so it can be merged. As you had initially brought up the idea on algorithms repo, where I am a maintainer, and I had suggested doing it here as it seemed more general, I had provided some initial help/guidance to get things in a reasonable shape as the person who we though might have helped you out was on extended leave, so I figured I could at least help get things going. But for final "polishing" and acceptance the approval needs to come from a Qsikit maintainer who better know internals/details of how things ought to be so my help could only go so far.

Hi Steve, (as stated in qiskit's slack) I didn't know that, thanks for informing me about that. I again want to state that I'm quite grateful to you for going above and beyond in the help and guidance you provided throughout this ardous polishing process.

I have incorporated mostly all the changes you asked for.

For next time, it is easier to track changes if you reply in the conversation for each code comment.

I have added almost every suggestion (except @1ucian0 's last suggestion), if you get time, please take a look at this. Thanks in advance XD!

Hi @Cryoris, I have incorporated all the changes you suggested, and it will all the tests now. The inverse function in the latest release of Qiskit, caused one test to fail, but have fixed it now. Can you please look at it and see if there's anything else required?

Thank you so much to you, Jake, Luciano, and especially Steve, for going through my amateurishly written code and helping bring it to this stage, despite your incredibly busy schedules.
Steve, I'm incredibly grateful for the support and assistance you've provided throughout this journey. Without you, it wouldn't have been possible.
I'll probably bother you guys again with another pull request 😅, hopefully next time it'll be easier to deal with.

Hirmay, you are very welcome. Congratulations on your successful contribution to Qiskit.

Thanks, again, Steve! XD


Can this plugin support CoAP over TCP?

Hi,
Can this plugin support CoAP over TCP?
Thanks!

No.
On Aug 30, 2018, 2:55 PM +0800, Alex Duan<EMAIL_ADDRESS>wrote:
Hi,
Can this plugin support CoAP over TCP?
Thanks!
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHubhttps://github.com/emqx/emqx-coap/issues/84, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ATh-0w5zy3hMuvxMGnyttZR9tMnCJx6Mks5uV4xtgaJpZM4WS4ci.


[CI] Install clippy from git when it's missing

See https://github.com/rust-lang/rust-clippy#travis-ci

Great find! Does this mean we can unpin the nightly?

Oh I didn't find now we use pinned nighlty in travis.
I hope so, though still it can be broken sometimes.


[W6.4f][T11-B4]Artsiom Skliar

Made Command.execute method abstract.

@Articho28 Accepting this PR with minimal review and I found no important issue.


cooler and pairsamtools compatibility issue

Was the compatibility issue between cooler and pairsamtools fixed?
https://github.com/mirnylab/distiller-nf/issues/89
P.S.: pairsamtools has 1 based indexing for pairs (SAM style)
cooler used to use 0 based indexing for pairs, did it change?

Thanks for the fix! I am running the distiller now. Will update once it's done.

It failed giving the following error.
INFO:cooler:Binning chr41:0-9688883|*
  Traceback (most recent call last):
    File "/home/an27w/lib/miniconda3/bin/cooler", line 11, in <module>
      load_entry_point('cooler==0.7.9.dev0', 'console_scripts', 'cooler')()
    File "/home/an27w/lib/miniconda3/lib/python3.6/site-packages/click/core.py", line 722, in __call__
      return self.main(*args, **kwargs)
    File "/home/an27w/lib/miniconda3/lib/python3.6/site-packages/click/core.py", line 697, in main
      rv = self.invoke(ctx)
    File "/home/an27w/lib/miniconda3/lib/python3.6/site-packages/click/core.py", line 1066, in invoke
      return _process_result(sub_ctx.command.invoke(sub_ctx))
    File "/home/an27w/lib/miniconda3/lib/python3.6/site-packages/click/core.py", line 1066, in invoke
      return _process_result(sub_ctx.command.invoke(sub_ctx))
    File "/home/an27w/lib/miniconda3/lib/python3.6/site-packages/click/core.py", line 895, in invoke
      return ctx.invoke(self.callback, **ctx.params)
    File "/home/an27w/lib/miniconda3/lib/python3.6/site-packages/click/core.py", line 535, in invoke
      return callback(*args, **kwargs)
    File "/home/an27w/lib/miniconda3/lib/python3.6/site-packages/cooler/cli/cload.py", line 261, in pairix
      create(cool_path, bins, iterator, metadata, assembly)
    File "/home/an27w/lib/miniconda3/lib/python3.6/site-packages/cooler/io.py", line 286, in create
      file_path, target, meta.columns, iterable, h5opts, lock)
    File "/home/an27w/lib/miniconda3/lib/python3.6/site-packages/cooler/_writer.py", line 203, in write_pixels
      for i, chunk in enumerate(iterable):
    File "/home/an27w/lib/miniconda3/lib/python3.6/site-packages/cooler/_binning.py", line 1350, in _validate_pixels
      "Found a bin ID that exceeds the declared number of bins. "
  cooler._binning.BadInputError: Found a bin ID that exceeds the declared number of bins. Check whether your bin table is correct.

Fixed in release v0.7.9.


How to get latitude and longitude and visual area when the map is repeated and slides in one direction

How to get latitude and longitude and visual area when the map is repeated and slides in one direction

Hi
Can you be a little more explicit to have a chance to get an answer and some help ?

toLonLat will normalize wrapped coordinates https://codesandbox.io/s/geographic-forked-vswpi

for info #13030 ...

Same. Use ol/extent#getBottomLeft() and ol/extent#getTopRight(), and ol/proj#toLonLat() on the results.

Thank you

When I render the point to the map, the map is looping, but the point does not


Command line help option not executed if env variable is missing

Check for environmental variables should be after retrieving command line options.
Command line option should be able to overwrite/set IMPROVE_DATA_DIR
Command:
python lgbm_preprocess_improve.py --help

@wilke can we close this?

is it working now? Then yes.


After the discojuce login the user is redirected to the home page and then the user is waiting

Original issue: https://github.com/ufal/clarin-dspace/issues/1108

It is because of SSR. The user is redirected to the page from where the login was initiated, but the FE is still reloading and fetching the html from the server.

The solution could be to have better server performance.


Flickering / glow backend not clearing buffer

Describe the bug
seems that egui frame doesn't clear properly using glow backend on a mac
To Reproduce
Steps to reproduce the behavior:

go to default example for the glow backend
add a global clear color variable
create a  ui.color_edit_button_rgb(&mut clear_color);
move the color panel

Expected behavior
everything should be clear
Screenshots
https://user-images.githubusercontent.com/3333460/142732354-014755b9-9241-4ded-a673-138c8bb5622c.mov
Desktop (please complete the following information):

OS: MacOSX
Browser
Version

Additional context
Only tested with glow backend in a Mac, so I'm not sure if this happens in other platforms

Im also experiencing flickering in Windows 10.
i used (unchanged): https://github.com/emilk/eframe_template

/

after digging deeper, i understand my comment does not belongs here but instead of delete my comment you could reference #838


Update Ordnance Survey API Endpoint

Ticket: https://trello.com/c/KLgxJkLM
With new API Key

Secrets have bee applied to staging


Plugable handler for CREATE FUNCTION

Is your feature request related to a problem or challenge?
At the moment datafusion does not support CREATE FUNCTION, it only exposes programatic api for UDF declaration.
Programatic approach does not support declarative UDF, and would not work with SQL only interaction.
I believe that we could expose a pluggable interface like FunctionFactory  (part of SessionState) where user can plug their own  CREATE FUNCTION handler, and plug their own declarative UDFs, without bringing them to core library.
Describe the solution you'd like
A solution would allow users to declare functions like:
CREATE FUNCTION iris(FLOAT[])
RETURNS FLOAT[]
LANGUAGE TORCH
AS 'models:/iris@champion'

or
CREATE FUNCTION add(BIGINT, BIGINT)
RETURNS BIGINT
LANGUAGE SQL
RETURN $1 + $2

CREATE FUNCTION handler would be configured at the SessionContext configuration phase:
let runtime_config = RuntimeConfig::new();
let runtime_environment = RuntimeEnv::new(runtime_config).unwrap();
let session_config =
    SessionConfig::new().set_str("datafusion.sql_parser.dialect", "PostgreSQL");
let state = SessionState::new_with_config_rt(session_config, Arc::new(runtime_environment))
    // we configure a torch function factory
    // to handle CREATE (and DROP) FUNCTION requests
    .with_function_factory(Arc::new(TorchFunctionFactory {}));

let ctx = SessionContext::new_with_state(state);

in this example we define TorchFunctionFactory,
full example can be found at https://github.com/milenkovicm/torchfusion
Describe alternatives you've considered
No response
Additional context
No response

This would be quite cool (for example, it could potentially be used to support WASM udfs https://github.com/apache/arrow-datafusion/issues/9326).

yes, that would be third good use case


[prefer-readonly-type] Support Readonly

Support the following case (at the moment functional/prefer-readonly-type gets emitted):
type MyType = Readonly<{ a: string, b: number }>;

This is a prerequisite for #32 (which is about a fixer to Readonly<T> if I understand it correctly); but the validation can implemented before.

I'm interested in taking this on.

@kevinbarabash it's yours 😄.
I think the way to go about it is to add an option to the prefer-readonly-type rule called something like style with options keyword (default) and generic .

Thanks.  I'll start work on this this weekend.

@kevinbarabash How you going with this?

I ended up getting side-tracked by something else and have put my TypeScript development on hold.

+1 for this. Having to put the readonly modifier before every single key decreases readability. And this rule is critical.

+1

Just wanted to point out that https://typescript-eslint.io/rules/prefer-readonly-parameter-types works with Readonly as well as ReadonlyDeep from https://github.com/sindresorhus/type-fest, so maybe we could borrow from it's implementation

@adrian-gierakowski I've actually been working over there helping with that rule. I've also since extracted out the relevant bits and improved upon them in a new lib called is-immutable-type. v5 of this lib (currently in beta) uses that library and resolves this issue.


Upgrade paginated models to new structure

The paginated responses format is now changed to have all the metadata bundled inside a separate object. This is implemented in one generic type model class (Page), and all the separate type-specific classes have been deleted.
Fixes MA-1891.

Note that this change is not available in the current sandboxes yet. @wajeeha-khalid is working on setting up a sandbox called 'markhor' with the latest changes on master so that we can test this.

:+1:

Should we wait to merge this until the mobile-devi sandbox has been updated with the new pagination format? When is that scheduled to happen?

We'll have to wait till the sandbox are updated before merging this PR, or our app will keep on crashing for Discussion UIs.

I usually update them on a need basis. I've updated both devi and dev to latest master.

@BenjiLee, @bguertin, would either of you like to do a second review on this?

:+1:  LGTM


Adding funtionality to toggle original Destiny 2 rules

Adds the ability to toggle the original game rules by removing them whenever the app is active and re adding them when the app is deactivated or closed.
There is a separate option in the settings screen for that as well.

Why would you want this functionality? What purpose does it serve?


Feature/remove pandas bridge

remove pandas_bridge
This PR will remove the  pandas_bridge.py module from elephant.
deprecation
The pandas_bridge module was deprecated here: https://github.com/NeuralEnsemble/elephant/pull/293 on Mar 2, 2020.
Removal was planned for elephant 0.8.X.
decision
As discussed in the last elephant meeting (Nov 28, 2022), the pandas_bridge module will finally be removed from elephant with release v0.12.0.

Coverage decreased (-0.4%) to 87.345% when pulling 7bcad8e3656d4b9e24ea4f69d279bc20d185c399 on INM-6:feature/remove_pandas_bridge into 4de1232d4369c87b1d248cbcfb5e6e0fac0f3166 on NeuralEnsemble:master.


security: automatic remappings can be dangerous

Component
Forge
Have you ensured that all of these are up to date?

[X] Foundry
[X] Foundryup

What version of Foundry are you on?
forge 0.2.0 (a8c3e9c 2024-10-19T00:21:12.472031180Z)
What command(s) is the bug in?
forge build
Operating System
Linux
Describe the bug
Forge infers remappings by taking into account remappings of sub-projects. When there are conflicting remappings, it seems like the longest / most specified has the priority. This can be dangerous, as adding sub-projects can now completely change the code that is executed, even if the remappings of the root project are not changed.
Reproduced in this test. Notice that removing the lib/interesting-project makes the test pass again. Also notice how interesting-project can be very deep in the sub-projects, so it can be difficult to detect that the executed bytecode has changed.
Proposed solution: make remappings of the root project have priority over remappings of sub-projects.

reopen per https://github.com/foundry-rs/foundry/pull/9274


Add region tags for projection query sample.

The START_EXCLUDE wasn't working when I tried to embed the function. I'm reverting to region tags to just include the same code as used in the existing sample.

LGTM


larva pipe has inconsistent forward called fail

❗ please do not add sensitive information in issues, you can provide extra information via email using issue number as reference ❗
Describe the issue
For some reason the larva pipe has a forward called fail instead of failure
Reporter
jjansenvr

To Reproduce
Steps to reproduce the behavior:

Go to '...'
Click on '....'
Scroll down to '....'
See error

Screenshots
If applicable, add screenshots to help explain your problem.
Configuration
Please provide the configuration of the Pipe or Receiver with the problem.

Input
Please provide an example of the input message.
Alternatively, provide a Ladybug report.

Environment
Please go to the console of your Frank, click on 'Information' and copy-paste the results here.

Additional Environment

DBMS: [e.g. Oracle, MSSQL, MariaDB, MySql, PostgreSQL]
Browser: [e.g. Chrome, Safari, Edge, Firefox]

Additional Context
Add any other context about the problem here. (f.e. ladybug report / test adapter with larva test)

depricate fail add failure


CHAOS-2111 Add introduction for namespace consideration

Add intro for namespace consideration in security section

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step behind the Harness VPN and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app. Current Draft URL is: https://65b74b55c65a5ff65f66167e--harness-developer.netlify.app


issue: decode output layer

hi Bo Shao, thanks for your public code. I am a new learner and I have learned much from it.
I have one doubt: the output layer of decode.
The following is yours in the file 'modelcreator.py':
#Decoder
my_decoder = tf.contrib.seq2seq.BasicDecoder(
    cell,
    helper,
    decoder_initial_state,)

# Dynamic decoding
outputs, final_context_state, _ = tf.contrib.seq2seq.dynamic_decode(
    my_decoder,
    output_time_major=self.time_major,
    swap_memory=True,
    scope=decoder_scope)

sample_id = outputs.sample_id
logits = self.output_layer(outputs.rnn_output)

I think the code should be like this:
#Decoder
my_decoder = tf.contrib.seq2seq.BasicDecoder(
    cell,
    helper,
    decoder_initial_state,
    output_layer=projection_layer)

# Dynamic decoding
outputs, final_context_state, _ = tf.contrib.seq2seq.dynamic_decode(
    my_decoder,
    output_time_major=self.time_major,
    swap_memory=True,
    scope=decoder_scope)

logits = outputs.rnn_output

I am wrong...haha.
In the  predict, you add output_layer in the BasicDecoder.


⚠ Bofrost.be has degraded performance

In e3bec54, Bofrost.be (https://www.bofrost.be) experienced degraded performance:

HTTP code: 200
Response time: 2133 ms

Resolved: Bofrost.be performance has improved in 566b19f after 19 minutes.


missing dependencies for installation in case of RHEL or amazonlinux OS

hostname and ping dependencies were added in case of installation on RHEL or amazonlinux OS
closes: #2681

LGTM We probably need the same on https://github.com/scylladb/scylla-pkg/blob/next/scripts/docker-files/get-scylladb/Dockerfile_rpm

Why do we need to update this file ? IIUC the web install script will install it anyway if needed, right ? so we don't really need 2 places to check and install dependencies

oh, you're right


linux_5_3: init

Motivation for this change
https://lwn.net/Articles/799250/
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[x] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[ ] Fits CONTRIBUTING.md.

Looks like this was done directly instead: https://github.com/NixOS/nixpkgs/commit/921071da08d673f34b3dcfcd6129cb2c95f54a3b .  Revision for linux-libre used here is slightly newer, but don't know that the difference matters.  Closing! :)


Rust type aliases

In https://github.com/dtolnay/cxx/pull/1181, I published a tentative implementation for Rust type aliases.
The problem to solve is the following: we have two bridges, one exporting the Rust type, the other declaring functions, which need to work with this type. Currently, one cannot express this, because trying to use the same type in the second bridge would fail, since RustType trait is already implemented. So we need a possibility to specify an alias.
The tentative implementation specifies the alias via type Name = ::path::Name, where Name must be same on both sides. That's somewhat bad, since ideal would be an use ::path::Name statement. However, use is not allowed in extern blocks.
The question: Do we want to allow use for Rust types on the bridge module level? Writing use ::path::Name at the bridge level would be idiomatic Rust and we could generate appropriate Rust type alias with checks and so on at that level, instead of misusing type syntax in an extern block for it.
Any other ideas how to express it?
Thanks.

@wvwwvwwv your opinion?

This totally makes sense to me, since different modules/projects sharing the same data types are actually very common. Adding support for use ::path::Name is most preferable, but using an alias as you suggested looks also reasonable.

Any chance of this being resolved soon? I'm trying to do the same thing, I can for now keep everything coupled inside of a single bridge as a workaround, but it introduces a lot of mental and technical overhead.

@futscdav

Any chance of this being resolved soon? I'm trying to do the same thing, I can for now keep everything coupled inside of a single bridge as a workaround, but it introduces a lot of mental and technical overhead.

I'm sorry, but since the maintainer doesn't have the interest to review anything beyond trivial fixes, react to issues/RFCs and/or establish a secondary maintainer since half a year, I gave up.
We have our own local copy of the crate which we maintain for our large project (8M LOCs C++ + 2M LOCs Rust). Unfortunately, our team is very small (too small for the task, in fact) and thus we don't have resources to manage the community. Therefore I didn't publish a copy of the crate with improvements anywhere. If someone would be willing to handle further maintenance of the crate, we might publish it.

I see, that's unfortunate. @dtolnay what's the plan here?

Another upvote for this. I want to be able to bridge separate C++ libraries into Rust and place them in different Rust modules, possibly in multiple source files. Code in one bridge needs to use types from another bridge, however this  doesn't currently work.
Code below is an example of what I want to do. However it refuses to build complaing that the use of liba_::Image in mod::ui is an 'unsupported type'.
extern crate cxx;

// Bridge to C++ library LibA which we wish to map to rust module lib_a
#[cxx::bridge]
pub mod lib_a {
    #[namespace = "LibA"]
    unsafe extern "C++" {
        // define an image type and simple accessors on it
        pub type Image;
        fn width(self: &Image) -> u32;
        fn height(self: &Image) -> u32;
    }
}

// Bridge to C++ library UI which we wish to map to rust module ui
// The C++ UI library uses types from the C++ LibA library
#[cxx::bridge]
pub mod ui {
    #[namespace = "UI"]
    unsafe extern "C++" {
        // Following line fails to compile, complains "error: unsupported type"
        pub fn getCurrentImage() -> SharedPtr<lib_a::Image>;
    }
}

pub fn print_image_size(img : &lib_a::Image)
{
    print!("Image size is {}x{}\n", img.width(), img.height());
}

pub fn print_current_ui_image_size()
{
    print_image_size(&*ui::getCurrentImage());
}

@bruno-j-nicoletti

My Rust skills are currently insufficient to figure out how to fix this, though I see where the check if failing.

The feature simply doesn't exist, so it doesn't work that way. That was the reason for this PR in the first place. But, it still sits here unreviewed after a year (together with other PRs and RFCs for design of additional features). In the meantime, we have forked the crate in our company repo, added quite a bit of stuff, and do not try to contribute anymore, sorry.
You might have more luck with https://github.com/google/autocxx or https://github.com/mystor/rust-cpp.


Positioning Issue

Is your feature request related to a problem? Please describe.
Fix positioning
Describe the solution you'd like
Fix positioning of the text below the login button and space out.

Kofta is now dead


quick assignment not possible

structure is counter-intuitive -- trying to apply this with a simple keydown, which requires me to write a whole function to wrap, otherwise it's triggered twice.
perhaps there should be objects dedicated to:
keydown
keyup
for quick access

this should also ignore repeat

right now, a simple function looks like this:
keyboardMapper.keyranges.Key.A = function(e, item, direction){if(direction&&e.repeat)next()}


webstorm extension

would it be hard to port vscode extension to webstorm as well?

Do they have an app store like VS Code? Can you link to it?

https://plugins.jetbrains.com/webstorm

What do you think @albbus-stack?
He made the vs code extension

Sure, I'm gonna reasearch it when I refactor the extension 👍🏻

I'll add this to the wish list portion of the docs


Querying temporary table in same query it was created yields no results

Describe the bug
When creating and querying temporary tables in the same query/tab, selecting from the temporary table yields no results. The temporary table is created and I see the schema in the results pane, but there are no rows in it. Furthermore, if I open up a new query and run the same select there, I do get the intended results.
To Reproduce
Open one query on a MySQL connection and enter the following code:
DROP TEMPORARY TABLE IF EXISTS a;

CREATE TEMPORARY TABLE a (
    SELECT
        1 AS first,
        2 AS second
);

SELECT * FROM a;

That should be enough to see the first part of the issue, i.e. a lack of results. To see the second part of the issue, open a new query and just enter:
SELECT * FROM a;

Expected behavior
Selecting from the temporary table in the same query as it was created should return the table with results, i.e. the select in the first screenshot should yield the results seen in the second.
Screenshots
Running the first query with no results:

Running the second query with results:

Desktop (please complete the following information):

SQLTools Version 0.28.1
VS Code Version: 1.84.2
OS: Windows 11 Pro OS Build 22621.2428
Driver:

[ ] PostgreSQL/Redshift
[x] MySQL/MariaDB
[ ] MSSQL/Azure
[ ] SQLite
[ ] Other? Which...

Database version: MySQL 8.0.33

Additional context
Seems like this may be the same issue as this one but with MySQL instead of Postgres. Additionally, running the same code in the reproduce section in MySQLWorkbench works as intended.

I've discovered this may be an issue with multiple commands, not just with temp tables. I recently tried doing a select after defining a variable with SET and ran into the same issue. Try the following code:
SET @foo := 20;

SELECT @foo AS bar;

I suspect that the MySQL driver distributes a multi-command statement across a pool of connections. I've seen reports of the same behaviour with one of the other drivers, for which a workaround existed involving setting the maximum number of connections to 1.

I think I found the issue you're talking about here. It looks like that setting might be specific to the Postgres and Redshift drivers which use node-pg library. This other open issue actually seems to be the same as my issue, but it's been open since 2020 without a resolution. The one comment about a resolution mentions that fix as well. The problem is, I can't find any sort of setting in the SQLTools or the MySQL driver settings to change the maximum connections.


LinDat file bug

LinDat file seems to be having a bug:
AttributeError: 'DataFrame' object has no attribute 'Time_UTC'

idk kinda seems like it was just my dev version that had a bug... but im not sure why I would have changed the parse method to this:
    def parse(self) -> pd.DataFrame:
        """
        Parse a Lin data file.

        Returns
        -------
        pd.DataFrame
            The parsed data.
        """
        vprint(f'Parsing {os.path.relpath(self.path, DATA_DIR)}')

        instrument, lvl = self.path.split(os.sep)[-3:-1]

        names = DATA_CONFIG[instrument][lvl]['col_names']

        data = pd.read_csv(self.path, on_bad_lines='skip',
                           names=names)

        # Format time col
        data.rename(columns={'TIMESTAMP': 'Time_UTC'}, inplace=True)
        data['Time_UTC'] = pd.to_datetime(data.Time_UTC, errors='coerce',
                                          format='ISO8601')

        return data

leaving open for now...


Shrink-wrap Polysphere

Hi,
I am unable to get the shrink-wrap good.
Have you been able to do it to any ready rendered files?
sorry for posting here on issues but i don't know how github works and where to post questions :P

No problem.   I also couldn't get satisfied with the shrink wrap either.
I feel that it is better to model the bevels directly, although it's difficult!
I've been working with NURBS to achieve this, but Blender has quite poor NURBS modelling.  So I've been trying out alternative modellers.
I will be doing more on this in the next week or so.  I will post any results here.

Oh great! I myself just got into modeling and are note really handy with any 3d-modelling program so this is much appriciated. Im thinking about the ISO enter thou (as im from sweden and we use ISO) im thing im going to try to create that. Ill look into NURBS and see if I can figure out how that works and implement it with my ISO enter :D

So far I haven't found any good free NURBS modellers.
Rhino3D is a popular, but expensive option.  There is a 30 day trial version though.
Also there's http://moi3d.com/ which I like better. Also has a trial. It's still pretty expensive.  However they won't bug you  to buy it the way Rhino does. Which I find a bit annoying.

Got it to work? I've been trying to read up on NURBS but beeing a novice in 3D modeling its very hard to wrap your head around all this stuff >.<

I haven't had any time to get any further.
Thanks to Carbon SA/Spoonyluv/MassDrop I do now have a decent set of  SA caps, so other than NURBS, a laser scanning option is not out of the question.
I may do this if I can get hold of a scanner / bureau

Hi
Awesome that you have gotten yourself a good set of SA caps from massdrop. Have you found time to try to create the caps?

Super busy Dec - March so didn't have any time to do any hobby things :)
Hopefully end of April I get a chance, but I'm teaming up with someone to do the renders on Ristretto SA so I'm not highly motivated to improve these now, so progress will be sporadic.

Note. There's been no movement on this.  I'm putting this project on ice for now as I haven't got time to invest at the moment.


Add meeting notes from the March 2023 meeting

Adds the meeting notes from the March 2023 meeting, with some minor textual cleanup to linkify, remove sections that weren't relevant, tweak formatting and fix a couple typos (in a separate commit for easy reviewability).
Also replaces Current agenda: TBD on the index page with a link to the current agenda on HackMd, and got the live agenda ready for the next meeting.

:books: Documentation preview :books:: https://docs-community--76.org.readthedocs.build/en/76/

Seems like arewemeetingyet is down, which is causing the check failure. Do we want to switch to another site, remove the links or just wait a bit?

I reported it at https://github.com/djc/awmy/issues/28
We can merge already and check back later. If it's still down by the next meeting, let's replace it.

Considering at least per the readme it's mentioned as still running on Python 2.7 (though it seems it might be Python 3 compatible), and there have been no changes for years, it seems like the answer may be no. We could actually host it ourselves since it's FOSS, but it looks rather archaic and its probably more realistic to just use another service.

https://arewemeetingyet.com/UTC/2022-10-03/19:30/Docs Meeting is back up!

Unfortunately, I can't restart the CIs without closing and re-opening this issue, as it seems neither I nor even the core devs have Write access here.
FWIW, the permissions here have always seemed a little restrictive to me relative to other much more critical repos (like cpython, peps, devguide, core-workflow, etc.) that even triagers have the GitHub write role (minus actual push/commit/merge) to. We might want to consider giving the docs team write access, and/or implementing python/core-workflow#460 here so we can all use the full GitHub feature set without needing merge rights.


Does this project actually solve the problem?

I read through the provided documentation and the more I read the more I became unsure that the original problem is solved by this project.
The line that says that signers should have CA private key on their keychain and that the service provided by this project does not have access to private keys means that one with the CA private key (one of the signers) can simply sign anything without any need to use the service.
This brings a question of the goal of this project and what the project tries to solve.  Is it just some convenient way to distribute public keys for signing?  If so, this approach with multiple people having access to the CA private key stands against good security practices since it would be impossible to detect who actually signed the key used for malicious activity on the server (all in all, all signers are using the same CA private key).
A much better approach would have been if the signing entity was behind the ss-cert-authority and would not be accessible to anyone directly, but through your service only.  Then if the proper authorisation was implemented (e.g. through the list of fingerprints who allowed to approve the signing of the request) the signing entity (e.g. implemented via HSM or something like that) would sign the request.

Hello and thanks for the comments. I think there may have been a subtle misunderstanding created by the documentation somewhere. Perhaps you can help me fix it.
The general premise to ssh cert authority is that the secret used to sign certificates for logging in to hosts is tightly guarded and known to few, if any, people. When a user requests a certificate we require a strong form of authentication to request a cert and when another user signs (or gives a +1 to that request) we also require a strong form of authentication. It is this strong authentication that I think has caused confusion.
The strong form of authentication is actually a user's ability to sign their own certificate using their own personal key (not a shared key). This self-signed certificate is passed to ssh-cert-authority where it is inspected. The certificate is treated as nothing more than a request and only after receiving the requisite number of +1s is the certificate signed, automatically, by ssh-cert-authority using the actual certificate authority key.
Today, in its current implementation and in a recommended deployment, this secret (the certificate authority key) is loaded into ssh-agent on a host that very few people have access to. This could very easily be a secret that is instead created in an HSM or a key in Amazon's KMS, however, ssh-cert-authority does not support that at this moment.
I'll try to summarize: users sign their own certificates using their own private keys only to verify that the requests being made to ssh-cert-authority are valid. The actual key used for signing certs that users can then use to login to hosts is stored independently of any user keys and is typically known to a very small number of people.
As an example, at my employer, there are several dozen users and signers configured in ssh-cert-authority however only 3 people (security operations staff) have the ability to bootstrap the system by loading the CA secret into ssh-agent on a host that is dedicated to running ssh-cert-authority. In this world, out of dozens of people, only 3 are able to maliciously generate certificates without an audit trail created by ssh-cert-authority (other audit trails are left behind by the user using that certificate).
Please let me know if that addresses your question. I'm pretty sure the docs simply created some confusion and I'd be delighted to look at a pull request that tries to clarify the docs.

@bobveznat, thanks for the clarification - it makes sense now.  Re: the documentation the following line has confused me from the "README.md" file:
None of the code here ever sees or even attempts to look at secrets

Although now I understand why it is worded this way there is still a possible abuse/attack vector on a key that is residing inside ssh-agent on the authority instance.
P.S.  Have you looked into https://github.com/realestate-com-au/sshephalopod which solves a similar problem but with a different approach (when you have some kind of auth framework and want to provide SSH access to instances according to the rules in the framework)?


Task Endpoints

Add Endpoints for Tasks.
Acceptance Criteria:

Each Task must have an User as its parent. The User should be injected on the AuthContext. An User should only be able to fetch/update/delete tasks created by itself.
Those are the expected endpoints for Task:

POST /v1/tasks
GET /v1/tasks/taskID
GET /v1/tasks
PUT /v1/tasks
DELETE /v1/tasks

Unit tests for the datastore layer;

#11


How to start Crawler at the end of a job?

I want AWS Glue job to start the crawler at the end of the job.
Can anyone share python script that I will put at the end of the job to do that?

import boto3
glue_client = boto3.client('glue',  region_name='us-east-1')
glue_client.start_crawler(Name='name_of_crawler')

Currently you can take advantage of Glue workflow.
See details in below doc. https://docs.aws.amazon.com/glue/latest/dg/orchestrate-using-workflows.html
Resolving.


CTRL + K doesn't work on Vivaldi

Sadly this appears to be a problem with Vivaldi, for all extensions with shortcuts. They do not seem to support it at the moment. This is the only way you could fix it from your end from what I've read.

okay ty :)


[move-to-yul] Semantic tests first step

This PR adds the infra to execute semantic tests, and applies it to the tests/Arithm.move module:

A new attribute #[evm_test] is supported. It can be attached to a parameterless function in the Move sources.
The compiler has a new mode to generate code for tests. If this is enabled, it will generated for each function marked with #[evm_test] a standalone contract (without any deployment code) which just executes this given function.
These per-function tests will be generated in our existing testsuite.rs and using the evm-exec-utils, being executed as a custom function. The result of this execution is either success or revert, and will be dumped to the baseline.

The PR also refactors the way how we generate contracts. It turns out that solc only accepts a single Yul object as input. We now generate (in non-test mode) a single contract which contains #[callable]s from any modules which are compilation target. (That is, no use any longer for #[contract] attribute on module level.) Because of this and other changes, a lot of baseline changes happened. It's best to focus on the ones in Arithm.exp to see the way how the semantic tests are wired up.
Motivation
EVM
Have you read the Contributing Guidelines on pull requests?
Yes
Test Plan
New tests

/land


Godoc documentation

Description
Godoc documentation for all packages
Fixes #332
Type of change

Documentation update

Codecov Report

Merging #336 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #336   +/-   ##
=======================================
  Coverage   80.56%   80.56%
=======================================
  Files          15       15
  Lines        1636     1636
=======================================
  Hits         1318     1318
  Misses        221      221
  Partials       97       97

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f67d59b...1c9a2db. Read the comment docs.


add-more-examples

General Checklist:

[ ] Tests added for this feature/bug

[ ] All tests are passed

[ ] No lint error

Review

[ ] Has been reviewed

[ ] Conform by the [merge request performance guides]

[ ] Conform by the [style guides]

[ ] Squashed related commits together

Tasks Checklist

[x] Start a chain
[x] Start mutil chain
[ ] RPC example

What are the relevant issue numbers?
Closes #16
What are the relevant issue on pivotal tracker ?
delivered #

Pull Request Test Coverage Report for Build 74

1 of 1 (100.0%)  changed or added relevant line in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+1.6%) to 63.057%

Totals

Change from base Build 72:
1.6%

Covered Lines:
127

Relevant Lines:
209

💛  - Coveralls

Pull Request Test Coverage Report for Build 74

1 of 1 (100.0%)  changed or added relevant line in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+1.6%) to 63.057%

Totals

Change from base Build 72:
1.6%

Covered Lines:
127

Relevant Lines:
209

💛  - Coveralls

Pull Request Test Coverage Report for Build 74

1 of 1 (100.0%)  changed or added relevant line in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+1.6%) to 63.057%

Totals

Change from base Build 72:
1.6%

Covered Lines:
127

Relevant Lines:
209

💛  - Coveralls


Add lookahead readme

Add lookahead option summary.
...
  -- Auto look forward to the textobj. Vim's default textobj works in this way.
  lookahead = true,
...

I don't think Vim's default work this way. It's what targets.vim does

I didn't mean that you have to close. Just mention that it's similar to targets.vim


Add Online EDA and Simulators

Upverter, CircuitLab and TinkerCAD. Closes #17

I think we need a few more details on these, how they are different from each other. Maybe we need seperate categories. Upverter seems quite different to TinkerCAD. (Is Upverter still going btw. since they were aquired?)

¯_(ツ)_/¯ I'm not sure, bro.
I only know of them but don't use them; I started with OrCAD (just
pre-Cadence) in precision positioning industrial products at a still
existent company once upon a time, in a dotcom era far, far away. These
days, I primarily make boards for curiosity.
On Sun, Jul 5, 2020 at 4:37 AM Kaspar Emanuel<EMAIL_ADDRESS>wrote:

I think we need a few more details on these, how they are different from
each other. Maybe we need seperate categories. Upverter seems quite
different to TinkerCAD. (Is Upverter still going btw. since they were
aquired?)
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/kitspace/awesome-electronics/pull/58#issuecomment-653877641,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AABWYMD3BUWK6AFQRJ44XALR2BQYPANCNFSM4OQWJWLQ
.


cleanup, renaming and add Readme

Hi please review my Pr.
I've changed ubuntu version from 18.10 to 18.04 and add a Readme for build env with docker
Signed-off-by: fbalicchia<EMAIL_ADDRESS>

Closing because of unresolved conflicts.


Not working on Windows?

Sorry if I'm missing a step, but I currently tried to get this working on Windows and am seeing:
C:\Users\Jonathan\thirdparty\doxidize>cargo run -- build
    Updating git repository `https://github.com/steveklabnik/simple-server`
error: failed to load source for a dependency on `simple-server`

Caused by:
  Unable to update https://github.com/steveklabnik/simple-server?branch=gh96#502fc3f1

Caused by:
  revspec '502fc3f101df65795ac221bf123c1418f062b7d2' not found; class=Reference (4); code=NotFound (-3)

Any idea what might cause that?  Might be Windows related (or, I may have missed something)

I'm seeing the same thing in Linux as well.

It's because simple-server does not have the gh96 branch anymore. Until simple-server is released or this tracks master it's busted. Simmilar to https://github.com/steveklabnik/doxidize/issues/91

@mgattozzi - is there a way to workaround the issue for now?

just pushed a commit to fix this


Fix ElementTooltip to correctly render in a popup window

Changes
This PR fixes #862
The class component is refactored to a function component.
Testing
Updated PopupTestView of a test app.

I suppose you saw this and went with useEffect for a reason? It doesn't work with useEffect?

Yes, it's intentional to avoid flickering between preferred and calculated positions.


ES6 Modules

This converts the codebase from one 3000 line file to many smaller ES6 modules.
We can then create builds using 6to5 to target CommonJS, AMD, and browser globals.
As part of the conversion to es6 modules, I also converted the tests to es6 modules. Unfortunately, I couldn't find a great way of getting nodeunit to play well with es6 modules, so I also converted the test framework to QUnit.
There are still a few outstanding tasks to get this production ready.

[x] Convert locales and tests.
[x] Build globals and amd bundles with grunt and es6-module-transpiler
[x] Build commonjs files using grunt-6to5
[ ] Build single moment + tests for browser (momentjs.com)
[ ] Build commonjs folder with moment + tests
[ ] update test task to generate commonjs moment + tests and run tests, make it possible to test a single file
[x] Build UMD single file version of the library (with all the UMD patches applied currently)
[ ] Generate minified files for amd, umd and globals
[ ] Use https://github.com/developit/grunt-esperanto to create amd and browser bundles
[ ] Use https://github.com/6to5/grunt-6to5 to transpile to commonjs
[ ] Comb through the unit test conversion commit, making sure nothing fell through the cracks.

How did you rewrite the tests? Manually? That's a lot of work! Couldn't they be just converted with simple regexes / scripts?

I converted the tests with some vim macros. The locale tests could probably be done by a script though.
The steps are roughly:

Dedent 4 spaces.

Replace test definitions. /^('.*') ?: ?function ?(test) ?{/test($1, function (assert) {/

'format' : function (test) {       // before
test('format', function (assert) { // after

Replace /test\./assert./

test.ok(1)    // before
assert.ok(1)  // after

Replace /^},?$/});/

},  // before
}); // after

For the locale tests, we could add a module helper to do something like this.
// helpers/locale.js
export function localeModule (name) {
    module('locale:' + name, {
        setup : function () {
            moment.locale(name);
        }
    });
}

// tests/locale/fr.js
import { localeModule } from "../../helpers/locale"

localeModule('fr');

test('months', function () {...});

So why is there a chance for tests to be missing?

OK, almost done. Only unit test combing is left.
grunt transpile # creates transpiled files in build/umd
grunt qtest # runs all qunit tests

The current transpiler only outputs UMD (basically the same as we had now). I think we can build the umd and put it in the old location (root/moment.js, root/locale/*.js), so various users of the npm module won't be surprised.
For 3.0 we can actually rearange the files in the repo, provide amd, browser global, custom locale bundle etc. I don't have more energy to do this now, and we're blocking the rest of the development while this is unpushed.

OK, here's a final checklist in case I don't finish today:

[ ] grunt -- builds, jshint and tests
[ ] grunt test -- builds, tests
[ ] grunt uglify -- check that it works
[ ] grunt update-index -- builds, copies files to right place
[ ] grunt release -- uses release-bundle
[ ] make sure travis runs qunit tests
[ ] make sure sauce runs qunit tests
[ ] make sure tests run well in pc/mobile browser (from momentjs.com)
[ ] increase time qunit time limit (2 minutes at least, to account for slow browsers/platforms)
[ ] clean up broccoli, file and refs (package.json)

Can we please have the src folder included in the NPM package for those of us who use ES6 ourselves or TypeScript?

I'm also trying to use Moment from TypeScript and can't seem to import it without the moment.js file that is found inside the src folder - is there a way to get this to work with the current NPM package?

@d4nc3r
import moment = require('moment');


Db checkbook Data Loading Fixes

Fixing the data pipeline: 01_dataloading (fixed the reading from DO functions), tagging @athursland.

Does this whole pipeline work? I haven't pulled and tested myself yet, but don't see changes to build here, is the build script set up to read in the loaded cpdb folders?

Does this whole pipeline work? I haven't pulled and tested myself yet, but don't see changes to build here, is the build script set up to read in the loaded cpdb folders?

_merge_cpdb_geoms() in 02_build.py uses the subdirectories created in the dataloading step to pull in the cpdb data!


settings_users: Unstable bots and users table while reactivating/deactivating.

In settings, when we try to reactivate/deactivate bot/user, the table of bots/users list becomes unstable.
CZO

Bots table

Users table

This is due to the extra "Deactivated " text that's added to the deactivated user row in the Role column.

@zulipbot claim

Closing in favor of #21653. Thanks for the report!


Re-encode Context and events for better compatibility and mockability

This uses the pattern of sealed abstract classes with apply methods as the public interface and private final case classes as the actual implementations.
While passing through I did a few other minor tidy-ups.

One thing that's missing from this PR are withX builder-style methods. I'm not sure how important these are, and we can always add them as-needed without breaking compatibly.


Removing MAS-SSO tokens

This PR cleans up implementation that does remove mas-sso tokens.
This PR cannot be merged until we confirm that production migration succeeded.
Verification
We need to execute various services
rhoas logout
rhoas login
rhoas kafka list
rhoas kafka topic list
rhoas service-registry list
rhoas service-registry artifact list

Target for this PR is to be integrated with connectors feature branch. Then we can also include connectors in tests and adjust changes on feature branch. Minimizing conflicts.

Moved to main - will do extra work on the connectorsv2 branch to avoid conflicts.

Migration finished. We need to remove this and update CLI


Looking for paho-mqtt3c ... LIBPAHO-NOTFOUND

Hi,
Getting this error on using the script:
-- Looking for paho-mqtt3c ... LIBPAHO-NOTFOUND
CMake Error at util/CMakeLists.txt:57 (message):
libpaho-mqtt3c is required for MQTTv5 support.
Looks to be looking at the file: /var/opt/gvm/src/gvm-libs/util/CMakeLists.txt
Also found similar reported here: https://codemonkey.link/greenbone/gvm-libs/issues/694 ?
cheers
Rich

The package is missing from the Ubuntu repos. Found it with Aptitude.


Group regex

Hi,
Love this project.
Is it possible to add the regex function also to groups?
I'm using "mytvonline" provider and each group-title also contains the channel name. (I know it's stupid).
Here's an example of a line in the m3u file.
#EXTINF:-1 tvg-id="NPO1.nl" tvg-name="NL4K+ | NPO 1" tvg-logo="http://mytvonline.nl/picons/npo1hd.png" group-title="TV 4K+ | Nederland",NL4K+ | NPO 1
Thanks!

Hi there,
Yes I'm sure I'll be able to work something out to enable regex pattern matching against groups to be kept.
This is a good idea for a feature request but I agree, if someone somewhere has decided to include channel names within group names that does seem..silly.
Leave it with me and I'll take a look asap.
Cheers
Joe

There you go @Fietspomp86, one change committed directly to the master branch.
This change extends the --groups / -g [GROUPS] argument, hopefully it should enable you to configure one or more regex patterns to match against whatever group text contains the good stuff.
Please update and give it a go, cheers.

Great that you fixed it so quickly. Any chance there's somewhere a list how to use these regex? Can't seem to get it working.

No problem, it's good to hear that you got it working. Regular expressions can be one of the most complex error-prone things known to man in my opinion.


boards: st: Add support for STM32H745I-Disco

This PR adds a new board STM32H745I-Discovery. Its definition is heavily inspired by nucleo_h745zi_q.
I have tested basic functionality by running:

samples/hello_world
samples/basic/blinky
samples/basic/blinky_pwm
samples/basic/button

I am using the board for developing application that uses Ethernet, async UART, RTC, QSPI, so these features are also working fine.
FMC and SDRAM I only tested by tests/drivers/memc/ram/.

Please add an entry in the release notes

Is that a new requirement ?
We've never asked this previously. I know what I'm saying as I usually update the release notes for STM32 related changes and this is quite unusual that new boards additions are documented directly in the release notes.
Also, considering this is first contribution from @darkmoon32 I would not make this blocking.

Please add an entry in the release notes

Is that a new requirement ?

We do have a section for that:
https://docs.zephyrproject.org/latest/releases/release-notes-3.7.html#boards-soc-support
And I think it is worthwhile adding a line mentioning it (it is easy enough). But as you are the maintainer of this area, if you don't think it is worthwhile doing for ST boards I remove the request.

We do have a section for that:
https://docs.zephyrproject.org/latest/releases/release-notes-3.7.html#boards-soc-support
And I think it is worthwhile adding a line mentioning it (it is easy enough). But as you are the maintainer of this area, if you don't think it is worthwhile doing for ST boards I remove the request.

I was just saying we're not usually making it blocking, specially for first time contributors and also because this is not documented in contribution guidelines (last time I've checked, IIC).
I totally agree this should be documented but I'm updating this section at each release, and in any case I'll end up verifying/fixing it (as, as a maintainer, I should check this is updated and complete what is missing if needed).

@darkmoon32 Not sure how you tested the added CAN functionality on this board, but the configuration is wrong and causes build warnings (fix provided here: https://github.com/zephyrproject-rtos/zephyr/pull/72787).
You added CAN controllers and CAN transceivers, but neglected to add can as supported in boards/st/stm32h745i_disco/stm32h745i_disco_stm32h745xx_m7.yaml? No CAN tests will be compiled/run for this board configuration (leading to issues like the one I have just solved).

Hi @henrikbrixandersen ,
I have run the test for the tests/drivers/can/api by hand. I guess I did not notice the warnings or I just ignored them because I wasn't sure if my change caused them or if were already present. I will me more careful next time.
In your PR, shouldn't can be listed in the boards/st/stm32h745i_disco/stm32h745i_disco_stm32h745xx_m7.yaml? As you suggested.

In your PR, shouldn't can be listed in the boards/st/stm32h745i_disco/stm32h745i_disco_stm32h745xx_m7.yaml? As you suggested.

No, I should not be the one adding that as I do not have access to the hardware. If you can verify, with "can" added to boards/st/stm32h745i_disco/stm32h745i_disco_stm32h745xx_m7.yaml, that the following tests all pass on hardware, please open a new PR for listing CAN as supported:
west twister -p stm32h745i_disco/stm32h745xx/m7 --device-testing --device-serial ... -v -t can


Sync user config as a secret

#1478  👈 (View in Graphite)
main

This stack of pull requests is managed by Graphite. Learn more about stacking.


Rewrite improvements

New features
r or regexp is now optional.
1. Conditions
Syntax:
if a cond b

a and b are strings with support for placeholders
cond is one of is(equality), not(inequality), has(has substring), starts_with(has prefix), ends_with(has suffix) and match (matches regexp).
There can be multiple lines.

Examples
if {path} is /error
if {path} not /static
if {>User-Agent} has Android
if {path} starts_with /static
if {path} ends_with .html
# for match, regexp is on the right
if {file} match error_.*\.html

2. Multiple rewrite destinations
to now accepts multiple values.
Syntax
to dest [...dest]

First successful destination or the last one will be used.
From
to {uri} {uri}/ index.php?_uri={uri}

An attempt will be made for {uri} as a file. It is used if file exists.
Otherwise, an attempt will be made for {uri}/ as a directory. It is used if directory exists.
Otherwise, index.php?_uri={uri} will be used.

Examples
If user agent has Android in it, show mobile maintenance page if it exists or redirect to mobile path.
rewrite {
    if {>User-Agent} has Android
    to /mobile/maintenance.html /mobile/{uri}
}

If its not favicon.ico, attempt to server the file or directory, or forward the request to index.php.
rewrite {
    if {file} not favicon.ico
    to {uri} {uri}/ index.php?_url={uri}
}

And to clarify for the benefit of others reading this, from our chat on gitter, the multiple if lines are anded together.
This looks amazing. Going to take a closer look soon!!

is it possible to check if a file exists like done with apache htaccess file?
  RewriteCond %{REQUEST_FILENAME} !-f
  RewriteCond %{REQUEST_FILENAME} !-d

I'm not mean the syntax, just the feature ;)

No, not directly. to can be used to mimic that.

Hi @abiosoft could you give me an example how to rewrite the url only if the file not exists?

rewrite {
    to {uri} {uri}/ /the_new_url
}

This rewrites to /the_new_url if the file/directory does not exist. However, if it does exist, it will be served instead.


Mysql does not work

Connecting to mysql does not work. No tables are created. The plugin connects to sql instead of mysql.
https://pastebin.com/7jgHCaZK

+1

+1


HIVE-27653: Iceberg: Add conflictDetectionFilter to validate concurre…

…ntly added data and delete files

What changes were proposed in this pull request?

Add a conflict detection filter expression which can be used to filter out conflicting files during concurrent writes when committing the delete and data files.
Why are the changes needed?

Does this PR introduce any user-facing change?

No
Is the change a dependency upgrade?

No
How was this patch tested?

Unit test and manual test

Thanks @ayushtkn  for the review :)

Thanks again @ayushtkn for the review


Edge: Unable to login to Edge

Acceptance Criteria

[ ] A user should be able to successfully login to their account when using Edge as their browser.

@IsaacHardy could you try to post some debugging info on this issue? Perhaps an error console or anything like that? I won't be able to look at this myself on Edge until later today or tomorrow morning, but might be able to tell whats going on with a little context.

@conrad-vanl Aboslutely. I'm gonna grab our PC test machine here in a bit and grab some more details on this issue.

The best I can come up with, is that the call tot he server to login an individual is never resolving and just continues to display the isLoading component permanently. They are signs when you first click the "Go" button to login that you are login and your profile is about to be loaded, but then it takes a turn and just never loads. You can try going to another place in the web app but it will redirect you to the login screen.


Add the ability to the debug wasm builds

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 49.32%.  Consider uploading reports for the commit 2426bce to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #41   +/-   ##
=======================================
  Coverage   49.32%   49.32%
=======================================
  Files          13       13
  Lines         742      742
=======================================
  Hits          366      366
  Misses        376      376

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


[Bug]: Footer Links do not redirect to the required locations.

Is there an existing issue for this?

[X] I have searched the existing issues

Describe the bug

The links in the footer do not redirect to the required locations.
For example the Health tips link should redirect to the health tips page, but it simply redirects to the home page.
Expected behavior
The links should redirect the required locations
Add ScreenShots

On which device are you experiencing this bug?
Windows
Record

[X] I have read the Contributing Guidelines
[X] I'm a GSSOC-EXT contributor
[X] I'm a HACKTOBERFEST contributor
[X] I have starred the repository

@Jay-1409  Closing the issue due to it is not required


Running linter in a different directory

I want to give a command line argument --find-config which will find the given document from the current directory.
How do I change the directory where atom-linter's exec function is run

Use {cwd: '/path/to/dir'} as option.

I ran it using
filePath = textEditor.getPath()
console.log path.dirname(filePath)
return helpers.exec(atom.config.get('coala-atom.executable'),
                            parameters,
                            {cwd: path.dirname(filePath)})
                      .then (result) ->
          console.log "cwd - ", process.cwd()

the output is
/home/ajk/Desktop
cwd -  /home/ajk

... so, it doesnt seem to be changing the directory

process.cwd() will always point to the current process, not the spawned one :laughing:
We have a test where we test this CWD and it's passing btw.


409 error response doesn't fully comply with RFC 7231

Following RFC 7231 for the HTTP/1.1 protocol the server "SHOULD generate a payload that includes enough information for a user to recognize the source of the conflict" when sending a 409 status code:
https://tools.ietf.org/html/rfc7231#section-6.5.8
The spec instead says that error details only "MAY" be returned (and only for "Other Responses").
So I suggest to add the following sentence to the 409 errors (appears two times):
"A server SHOULD include error details and provide enough information to recognize the source of the conflict."

Totally makes sense to me!

Created PR  #596.


Add a way to schedule tasks on a day of week

Similar to cron's API.
5 4 * * sun     echo "run at 5 after 4 every sunday"

I agree. I suspect there's two parts to implement this:

Implement day of week functionality with a similar API to the existing Clock.schedulePulse
Implement cron parsing which delegates to either the day or week or day of month operators.

I unfortunately extremely busy in my personal life right now so I won't be able to get to this any time soon, but I'd be happy to accept PRs.

For reference @JakeWharton here's #65

After some investigations, cron's method for scheduling on days of week has proven very annoying. Dropping here so I don't forget.
First, the cron API allows specifying schedules that include both a day of month and a day of week. Unlike what you might expect, this isn't and-ed together such that if I specify 0 0 13 * Fri a job will run on every Friday the 13th. No -- instead, this means execute a job at midnight of the thirteenth of every month in addition to executing this job every Friday at midnight. Essentially, the day values are or-ed together instead of and-ed like everything else.
minute && hour && (dayOfMonth || dayOfWeek) && month

Second, the specifier that * means every value is not necessarily true. For other fields, specifying * is a substitute for specifying the full range of values, like 0-59 for minute. However, when used on day of week, this specifier actually means "don't consider day of week". For example, today is December 4th. If I specified 0 0 12 * * the job would execute next on December 12th. However, if I specified 0 0 12 * mon the job would next execute on December 9th. If * actually translated to SUN-SAT like it does for other fields, then * would basically mean execute this job every day. This is not how this behaves.
We should strive to replicate this somewhat broken behavior in cardiologist so that we can support full cron parsing like requested in #65. To do so, we will need to calculate the next matching day of month alongside the next matching day of week and return whichever value occurs sooner. Furthermore, we will need to distinguish between two scenarios:

We want to execute a job on a specific day of week.
We don't want to consider day of week at all.


highlight the search phrase in the poem

needs a change in the way we capture the poems to share their image for this PR to work correctly ("CaptureableCard")


Allow to open query from table browser

In the table browser, you can click on the left of the search bar and it displays some kind of pop up with the current query.

There could be some action like Ctrl+click that would open the query in a SQL editor instead of copy/pasting the query.

Ok, I like this.
Note: opened SQL editor won't be linked with a physical file.
It can be used as a SQL console but it can't be saved.


dask.array.full produces read-only arrays when computed

Describe the issue:
dask.array's functions for creating single-value arrays such as full, zeros, ones, full_like, zeros_like, and ones_like all produce read-only numpy arrays when computed. In order to get a result that can be written to, I have to copy the entire result or use map_blocks to map np.copy onto each chunk.
Minimal Complete Verifiable Example:
>>> import dask.array as da
>>> import numpy as np

>>> a = da.full(9, 0)
>>> ac = a.compute()
>>> print(ac.flags)
  C_CONTIGUOUS : False
  F_CONTIGUOUS : False
  OWNDATA : False
  WRITEABLE : False
  ALIGNED : True
  WRITEBACKIFCOPY : False

>>> ac[0] = 1
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
ValueError: assignment destination is read-only

My current workaround is to map a copy operation onto the chunks:
>>> a = da.full(9, 0).map_blocks(np.copy)
>>> ac = a.compute()
>>> print(ac.flags)
  C_CONTIGUOUS : True
  F_CONTIGUOUS : True
  OWNDATA : True
  WRITEABLE : True
  ALIGNED : True
  WRITEBACKIFCOPY : False

>>> ac[0] = 1
>>>

Anything else we need to know?:
This may be related to #6520.
Environment:

Dask version: 2024.11.2
Python version: 3.12.7
Operating System: Fedora 40
Install method (conda, pip, source): conda

This is interesting, probably because of the tricks we use to make the initial creation as easy as possible, but not sure. Will have to look into that a bit
You can just do a.compute().copy() if that's simpler for you

Ok this only happens because your dask array has a single chunk, that problem disappears if you have more than one, so I am inclined to close this because we definitely don't want to introduce complexity for cases where NumPy is better suited
import dask.array as da
a = da.full(9, 0, chunks=(3, ))
ac = a.compute()
print(ac.flags)

This will be writeable

Oh interesting. Thanks for looking at this and figuring that out. I'm fine with closing.

Hmm is there an easy way to handle this for both single and mulit-chunk arrays without having to check for npartitions==1? I'm running into this error while writing tests that use smaller arrays. It is annoying to have to check if the number of chunks is 1.

Got it. Thanks. I'll go ahead and close this.


Some fixes

Deleted REVISION file.
Removed step 2 in README.

Thanks for cleaning things up. I think this change will break the Docker builder though: https://github.com/googleprojectzero/fuzzilli/blob/master/Cloud/Docker/SpidermonkeyBuilder/Dockerfile (I think it's probably already broken due to the removed Patches/ directory, my bad...). I think the easiest way to solve this is to just copy the structure of the V8 directory:

Put the REVISION file back in (feel free to update to a newer commit though)
Add the Patches/ directory back with just an empty .gitkeep
Keep the changes to the README like they are now in this PR (i.e. just the three steps)

Alternatively, we can update the build.sh and the Dockerfile for the SpidermonkeyBuilder, whatever you prefer. Although I think keeping a Patches/ directory makes sense in any case, since that makes it easy to test e.g. custom engine instrumentation.

Thanks for cleaning things up. I think this change will break the Docker builder though: https://github.com/googleprojectzero/fuzzilli/blob/master/Cloud/Docker/SpidermonkeyBuilder/Dockerfile (I think it's probably already broken due to the removed Patches/ directory, my bad...). I think the easiest way to solve this is to just copy the structure of the V8 directory:

Put the REVISION file back in (feel free to update to a newer commit though)
Add the Patches/ directory back with just an empty .gitkeep
Keep the changes to the README like they are now in this PR (i.e. just the three steps)

Alternatively, we can update the build.sh and the Dockerfile for the SpidermonkeyBuilder, whatever you prefer. Although I think keeping a Patches/ directory makes sense in any case, since that makes it easy to test e.g. custom engine instrumentation.

Ok. I've restored patches and revision.


Improve focus styles on AudioTrack subcomponents

Description
The subcomponents of the AudioTrack need updated focus styles. See https://github.com/WordPress/openverse-frontend/pull/399#issuecomment-963142168
Expectation

Focus styles should match @panchovm's designs.
Resolution

[x] 🙋 I would be interested in resolving this bug.

@panchovm I was mocking up a version of the audio control button in the same UI style as the search button, and this is how the normal and focused state look like if we establish that as the consistent pattern for all buttons. Do you agree with the direction?

Yes. The focus style for audio control buttons should be inside the button, not overlapping any other area.


Fix YAML excerpt indentation

Proposed changes
Missing 4-spaces indent for code-block
Related issues (optional)
#5226

#5229


Building package hdf5:x64-windows failed with: BUILD_FAILED

Package: hdf5:x64-windows
Vcpkg version: 0.0.113-nohash
Log:
Building package hdf5[core]:x64-windows...
-- Downloading https://support.hdfgroup.org/ftp/HDF5/releases/hdf5-1.10/hdf5-1.1
0.1/src/CMake-hdf5-1.10.1.zip...
-- Downloading https://support.hdfgroup.org/ftp/HDF5/releases/hdf5-1.10/hdf5-1.1
0.1/src/CMake-hdf5-1.10.1.zip... Failed. Status: 35;"SSL connect error"
CMake Error at scripts/cmake/vcpkg_download_distfile.cmake:151 (message):

Could someone help me on this issue?


Use IOException instead of IOExceptionWithCause

We used to use IOExceptionWithCause because IOException with the Throwable constructors is missing before JDK 6.
I think we should use IOException after JDK 6.

@kkrugler Thank you for reviewing this.

I don't see the IOExceptionWithCause class being deprecated

IOExceptionWithCause in Tika was copying from commons-io 1.4.
And IOExceptionWithCause in commons-io has be deprecated since commons-io 2.5. see this

as removing it would be a breaking change

Agree, This will break binary compatibility. And we should only break BC in major version.
As I see, main branch is prepare for Tika-2.0 which will be the new major version. So I believe this is a good time to break BC.

If this change is only going into main, then my question is whether you removed the IOExceptionWithCause class from Tika (maybe I missed that), and if not, why not?

I'm also agree to remove the IOExceptionWithCause class from Tika.
The reason why this PR wasn't removing IOExceptionWithCause class is because consider TaggedIOException class in Tika need  IOExceptionWithCause class.
TaggedIOException class in Tika was copying from commons-io 1.4. So I perfer not to modify TaggedIOException class.
By the way,I think we can remove all these class from Tika which was copying from commons-io 1.4 if we make commons-io as dependency of tika-core.
WDYT ?

TaggedIOException can just extend IOException, yes?
As to adding a dependency on commons-io, that's been discussed in the past, but the decision at that time was to not add the dependency, to keep tika-core as light-weight as possible. I'd take a look at the mailing list archives to get the full context of that discussion (I think there might also be Jira issues), if you want to revisit it.

TaggedIOException can just extend IOException, yes?

Yes, it is.

I'd take a look at the mailing list archives to get the full context of that discussion (I think there might also be Jira issues), if you want to revisit it.

Maybe you are talking about TIKA-1706 and TIKA-1710? Seems that it's agreed to have commons-io as a dependency of tika-core. Are there any other mailing threads or issues? It's appreciated if you can find them. :)

My memory was that we had agreed to add commons-io to tika-core in 2.x, and Bob already did that in the 2.x branch, I haven't had a chance to port those updates to main yet.
I, frankly, want to keep some subclass of IOException around whether that's IOExceptionWithCause or something else.  My reasoning is that we have to wrap SAXExceptions and TikaExceptions in IOExceptions because of the exception signatures in some of our overridden classes.  It is useful to be able differentiate this hack from an actual IOException.
Is there a better way to achieve this goal?

My memory was that we had agreed to add commons-io to tika-core in 2.x, and Bob already did that in the 2.x branch, I haven't had a chance to port those updates to main yet.

I see. I'm almost finished with the code and tests. Maybe I can push a PR to main branch?

Is there a better way to achieve this goal?

Seems we do not have any other ways to do that. Maybe you have any better ideas?

Hi @tballison - you said:

I, frankly, want to keep some subclass of IOException around whether that's IOExceptionWithCause or something else. My reasoning is that we have to wrap SAXExceptions and TikaExceptions in IOExceptions because of the exception signatures in some of our overridden classes. It is useful to be able differentiate this hack from an actual IOException.

Couldn't we have a helper class that checks for IOException.getCause() being an instance of those two exceptions? I'm asking because I also run across a lot of cases in other projects where the root cause has to be wrapped in an IOException, but in the very rare case where I care about what really caused the problem, I call getCause(). But maybe there's something different about this particular use case.

Hi @tballison - hoping you can weigh in on whether we really need to keep around IOExceptionWithCause, thanks.

Sorry for my delay.  I'm now +1 to this.

Hey folks. I'm thinking about merging this before the release of Tika 2.0. WDYT?

+1

@PeterAlfredLee - I thought, based on @tballison input above, that you would delete the IOExceptionWithCause class. Did that happen separately?

that you would delete the IOExceptionWithCause class. Did that happen separately?

Well, this is already finished in #370.


FramebufferTexture is not exported from 'three'

three version<EMAIL_ADDRESS>three-stdlib version<EMAIL_ADDRESS>
Problem description:

This is a duplicate of #123
Make sure your version of @types/three and three are for the same version.


added hint for hotkey

Associated Issue: #180
Summary of Changes

added hint to rebus 'hotkey'

Wrong code...


Externals mapping support

This adds support for an object form in externals to support remapping the externals value in the target environment.
This is a necessary feature for the next.js support.

Codecov Report

Merging #402 into master will increase coverage by 0.26%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #402      +/-   ##
==========================================
+ Coverage   73.29%   73.56%   +0.26%
==========================================
  Files          14       14
  Lines         397      401       +4
==========================================
+ Hits          291      295       +4
  Misses        106      106

Impacted Files
Coverage Δ

src/index.js
83.53% <100%> (+0.41%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f0b0911...9c71345. Read the comment docs.


Use variable cluster_name as a name prefix for the autoscaling group

This PR reuses the cluter_name variable to set name_prefix on the cluster autoscaling group resource.
As the documentation mentions, the cluster_name should be "used to namespace all resources created by this module".
I've tested this PR with test-ktichen and awspec. I've defined the name of the cluster like this:
module "consul_cluster" {
  source = "github.com/miguelaferreira/terraform-aws-consul//modules/consul-cluster?ref=namespace-autoscaling-group"

  cluster_name = "ProjectTestConsul"

  ...
}

I wrote a awspec test like this:
require 'awspec'
require 'rubygems'

tf_output = eval(ENV['KITCHEN_KITCHEN_TERRAFORM_OUTPUT'])

consul_autoscaling_group_name = tf_output[:consul_autoscaling_group_name][:value]

describe consul_autoscaling_group_name do
  it { should start_with 'ProjectTestConsul' }
end

The results were:
ProjectTestConsul20180221110521541200000011
  should start with "ProjectTestConsul"

...

Finished in 0.17729 seconds (files took 1.85 seconds to load)
5 examples, 0 failures

Code change LGTM. How did you test it?

@brikis98 I've updated the PR with the testing info. Thanks for reviewing so quickly 👍

@brikis98: any chance you could give this PR another look?

Oh weird, I somehow didn't get a notification for your previous comment. Thx for the reminder. Code and test approach LGTM, thx!

https://github.com/hashicorp/terraform-aws-consul/releases/tag/v0.2.0

Release notes state that

Terraform treats renaming an ASG as deleting the old one and creating a new one, so be careful when updating!

Any advice how to be careful?
terraform apply will destroy all of your nodes with the data.
Is careful means backup your consul and update with downtime?

Probably the best option is to bring up a new ASG with the consul-cluser module, let the nodes sync up to the existing one and replicate the data, and then delete the old one. I'd recommend testing in pre-prod first to make sure the cluster handles the addition and removal of nodes properly!

@kostyrev wrapping the ASG in a cloudformation stack allows you to set an update policy, and one of the types is AutoScalingRollingUpdate, which will update each instance at a time. It also gives possibilities to roll back updates. I use this approach to manage ECS clusters with terraform.

@miguelaferreira but terraform considers this a new resource so I will delete it anyway

I'm not absolutely sure about that, because the resource terraform controls is the cloudformation stack, not the ASG. But I would test it first ;)

@miguelaferreira Can we fix this to append a dash, as well, similar to the launch configuration?
example launch configuration name:
cluster_name-20181024222144046700000004

current example autoscaling group name:
cluster_name20181024222144046700000004

proposed example autoscaling group name:
cluster_name-20181024222144046700000004

Sure @eedwards-sk, let me open a new PR


url path in css files to load static fonts is not correct after build with vue-cli.

I import font-awesome.css into main.js. It works well in dev mode. But when I build it using script npm run build, the fonts folder and css folder are separated in static folder and css can not load fonts correctly cause css use a path like url(static/fonts/xxxxx), which means fonts folder should be in the css folder or maybe root slash forgot in the path.
I can't reveal it cause I'm using a iPad right now, and I don't have a computer in my room. Sorry for that.

Hi, thanks for your interest but Github issues are for bug reports and feature requests only. You can ask questions on the forum, the Discord server, gitter or StackOverflow. This is also unrelated to vue-cli

I solved it by changing assetsPublicPath option of the configuration file from './' to '../'. You are right, it's not bug. Thank you.


Enable GPU broadcast exchange reuse for DPP when AQE enabled [databricks]

Signed-off-by: sperlingxx<EMAIL_ADDRESS>Closes #4439
Current PR leveraged "columnar adaptive plan", the new feature of Spark 320, to support GPU replacement of SubqueryBroadcastExec when AQE enabled.
In this PR, we removed the GpuBroadcastToCpu since it was only for SubqueryBroadcast. To be specific, Broadcast Exchange are inserted under two conditions in terms of Spark SQL: broadcast joins and SubqueryBroadcast in DPP.

For broadcast joins (BroadcastHashJoin and BroadcastNestedLoopJoin), the build side (BroadcastExchange) will fall back to CPU once the Join plan falls back. There is no need for GpuBroadcastTocpu since the BroadcastExchange itself is on the CPU.
For SubqueryBroadcast, current PR will replace original AdaptiveSparkPlanExec with columnar adaptive plan if possible, which eliminate the appearance of ColumnarToRowExec(e: BroadcastQueryStageExec).

build

build

build

build

I really like the comments in GpuSubqueryBroadcastExec. They help to explain what is happening. But just to be sure that I understand everything. GpuSubqueryBroadcastExec takes columnar as input and returns rows. GpuBroadcastExchangeExec always returns columnar data so it can be reused with anything else that needs columnar data. When AQE is enabled Spark knows that the output is columnar or not so it can adjust without us having to do it, and all we have to do is to match the pattern to know if we can replace this or not.
If I got anything wrong please correct me. I would also like to see a few others like @andygrove review this too before it is merged in.

Yes

build


Add autofocus property to select

#PATCH#
CHANGELOG

Added autofocus property to frost-select component.

:+1:


Find References should handle dunder methods

Is your feature request related to a problem? Please describe.
Find References seems to only find actual uses of the symbol, and doesn't handle cases like in for __contains__, iteration for __iter__.
Describe the solution you'd like
Find References (or Call Hierarchy) should link to all usages of dunder methods.
Additional context
AFAICT, the spec (https://microsoft.github.io/language-server-protocol/specifications/lsp/3.17/specification/#textDocument_references) doesn't specify what it means precisely by references to a symbol. I can see how the literal interpretation would be looking for an actual call to (for eg) __contains__(), but I think that the above behavior will be more useful.

Dupe of https://github.com/microsoft/pylance-release/discussions/2597. Please feel free to upvote the discussion.