Using the 8.0 image the PHP version in the container is 8.1

Sail Version: 1.12.12
Laravel Version: 8.80.0
PHP Version: 8.0.12
OS: macOS 12.0.1

Description:
I use the 8.0 docker image, but after rebuild with sail build --no-cache the php version in den container is 8.1.1 (sail php -v).
The relevant lines from my docker-compose.yml file:
# For more information: https://laravel.com/docs/sail
version: '3.9'
services:
    laravel.test:
        build:
            context: ./docker/8.0
            dockerfile: Dockerfile
            args:
                WWWGROUP: '${WWWGROUP}'
        image: sail-8.0/app
        extra_hosts:
            - 'host.docker.internal:host-gateway'

I freshly published the resources with artisan sail:publish.

Same issue

Same issue here

Same issue here

Looks like php8.0-dev is causing PHP 8.1 to be installed as well.

Screenshots without `php8.0-dev`

Screenshots with `php8.0-dev`

As I see it right now, we could add a apt-get remove php8.1* step to the 8.0 runtime Dockerfile, and that should work. But I think it's weird that php8.0-dev adds PHP 8.1 stuff, so there might be an issue with the extensions or in the PPA.

Same issue. In my temporary fix I added in the Dockerfile, after line 46: "RUN update-alternatives --set php /usr/bin/php8.0"
This way composer will work too.

I tried the solution of @felliper and it worked for me. Now sail php -v gives me version 8.0.14.
Thanks for the fast quick fix!

Looks like php8.0-dev (required in the docker file) recommends (recommends are installed by default) pkg-php-tools which in turn depends on php-pear and in turn php-8.1-cli:
apt-cache depends php8.0-dev
Depends: autoconf
  Depends: automake
  Depends: libpcre2-dev
  Depends: libssl-dev
  Depends: pkg-config
  Depends: php8.0-cli
  Depends: php8.0-common
  Depends: shtool
  Depends: libtool
  Recommends: pkg-php-tools

apt-cache depends pkg-php-tools
pkg-php-tools
  Depends: debhelper
  Depends: php-pear
  Depends: <php-cli>
    php8.0-cli
    php8.1-cli
  Depends: php-json
  Depends: <php-xml>
    php8.0-xml
  Suggests: <dh-make>

apt-cache depends php-pear
php-pear
  Depends: <php-cli>
    php8.0-cli
    php8.1-cli
  Depends: php-common
  Depends: <php-xml>
    php8.0-xml
  Breaks: <php-pear-frontend-gtk>
  Breaks: <php-pear-frontend-web>

Running the following command is a workaround (but will need to be re-run anytime the container is rebuilt):
docker-compose exec  apt-get remove php8.1-cli

Same to me.
Windows WSL, Ubuntu
I added to 8.0 Dockerfile --no-install-recommends


Fixed some paths.

The dunstrc file and the music file had reference to ~/Documents/Test/eww. Changed those to actual paths.

oh i forgot about those thanks for noticing

There is one more reference to ~/Documents/Test/eww in this file, I didn't know where this file was or where it is used. So fix it maybe?

oh that, it's unused I just forgot to remove it


Rename test spec to conform with name test spec

Very good idea!
Could you please rebase this against the current master and do a force push so I can merge it from gh directly?

Forcing push resulted in automatic closing this.
Shall I redo the PR?

https://github.com/TheTorProject/ooni-spec/pull/43


feat: allow multiple subscripts

Ref:

https://github.com/tensorchord/pgvecto.rs/pull/329
https://github.com/tensorchord/pgvecto.rs/pull/352

x[1:2][3:4] in PostgreSQL represents fetching x[0..1, 2..3]. Since vector is always an 1D array we do not support it for the first.
Later we would like to keep consistency with Python haviours. So there are no reason why we do not support multiple subscripts attached to a vector value now. We should implement it for convenience.

Could I work for this issue?

Could I work for this issue?

Sure!

@usamoi Hi, after I tried implementing this feature, and modifying to get multiple subscripts in transform(), I have no idea in modifying sbs_check_subscripts and something else.
I assume it should be implemented with a loop operation, but seems let state = &mut *(*op).d.sbsref.state; is not a list or implemented any memeber function to head next one.
Is there any tutorial, ref or blog to help understand pgrx::pg_sys::SubscriptRef, pgrx::pg_sys::SubscriptRefState and pgrx::pg_sys::SubscriptRoutines?

I think you need to read PostgreSQL source code. You can read the implementation for arrays.

I think you need to read PostgreSQL source code. You can read the implementation for arrays.

Thanks!


logging/gelf: fix stray 'n-dash' instead of hyphen in example

fixes https://github.com/docker/docker.github.io/issues/13998

@StefanScherer ptal

Yes, these are easy to miss (and we did) 🤣
It was reported by someone; after that it was an easy find; also searched the rest of the files, but looks like this was the only one


[INFO] Running com.microsoft.gctoolkit.integration.io.SingleGarbageCollectionLogFileTest

[INFO] Running com.microsoft.gctoolkit.integration.io.SingleGarbageCollectionLogFileTest
[ERROR] Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0.042 s <<< FAILURE! - in com.microsoft.gctoolkit.integration.io.SingleGarbageCollectionLogFileTest
[ERROR] com.microsoft.gctoolkit.integration.io.SingleGarbageCollectionLogFileTest.unifiedLog  Time elapsed: 0.037 s  <<< ERROR!
java.lang.RuntimeException: unified/g1gc/gc-all-info.log.zip not found
at com.microsoft.gctoolkit.integration@2.0.11-SNAPSHOT/com.microsoft.gctoolkit.integration.io.SingleGarbageCollectionLogFileTest.logTest(SingleGarbageCollectionLogFileTest.java:22)
at com.microsoft.gctoolkit.integration@2.0.11-SNAPSHOT/com.microsoft.gctoolkit.integration.io.SingleGarbageCollectionLogFileTest.unifiedLog(SingleGarbageCollectionLogFileTest.java:61)
Originally posted by @karianna in https://github.com/microsoft/gctoolkit/issues/221#issuecomment-1176624983

Test file is missing, but @kcpeppe should have it. I'll disable the test until the file can be uploaded.

@kcpeppe FYI: I commented out the missing file from the list of files in the test so you'll need to undo my hack once the unified/g1gc/gc-all-info.log.zip has been uploaded.
diff --git a/IT/src/test/java/com/microsoft/gctoolkit/integration/io/SingleGarbageCollectionLogFileTest.java b/IT/src/test/java/com/microsoft/gctoolkit/integration/io/SingleGarbageCollectionLogFileTest.java
index c79f244..e2e760e 100644
--- a/IT/src/test/java/com/microsoft/gctoolkit/integration/io/SingleGarbageCollectionLogFileTest.java
+++ b/IT/src/test/java/com/microsoft/gctoolkit/integration/io/SingleGarbageCollectionLogFileTest.java
@@ -15,7 +15,7 @@ import static org.junit.jupiter.api.Assertions.*;
 public class SingleGarbageCollectionLogFileTest {

-    private String[] unifiedLogs = { "unified/cms/gc.log", "unified/g1gc/G1-80-16gbps2.log.0", "unified/g1gc/gc-all-info.log.zip"};
+    private String[] unifiedLogs = { "unified/cms/gc.log", "unified/g1gc/G1-80-16gbps2.log.0"/*, "unified/g1gc/gc-all-info.log.zip"*/};
     private boolean[] zipped = { false, false, true};

     private void logTest(String log, boolean zipped) {


Router problems

More specific paths like
@Path("/{type: \w+}")
should match before general ones like
@Path("/{path: .*}")

See the getWeight() method in https://github.com/Graphity/graphity-core/blob/master/src/main/php/Graphity/Router/Annotation/Path.php
It's more of a temporary workaround at this time. Needs more defined implementation in the future.

JAX-RS has defined request matching in spec section 3.7.2.[1]
[1] http://download.oracle.com/otn-pub/jcp/jaxrs-1.0-fr-oth-JSpec/jaxrs-1.0-final-spec.pdf

Root resource identification implemented in commit f50deb4caf9c796dbd8d3ef2caa043b41e6299b3
For resource matching, another issue should be created.


[New Primitive] Tree

Feature request
Overview

A tree view that helps with hierarchical items, e.g. folders within files.
Here are the W3 specs: https://www.w3.org/WAI/ARIA/apg/patterns/treeview/

Examples in other libraries

A few open-source libraries out there, e.g. https://github.com/brimdata/react-arborist
Who does this impact? Who is this for?

Users that need to build a hierarchical list of things. E.g. Google Drive file viewer, Storybook, or even Radix's documentation website someday!
Additional context

Here is an awesome treeview component. Maybe useful for reference.
https://github.com/minop1205/react-dnd-treeview

Geist Design System from Vercel has a good one.
https://geist-ui.dev/en-us/components/file-tree

Another alternative that seem to have taken special care to implement the WAI-ARIA spec
https://github.com/dgreene1/react-accessible-treeview

Prefer to use MUI treeview for now. Hopefully there is a new component from radix

Might be something to look at: https://master--5fc05e08a4a65d0021ae0bf2.chromatic.com/?path=/story/examples-tree-sortable--collapsible

Can I take this up ?

https://www.radix-vue.com/components/tree.html

Still nothing huh...


Number cell edit input is aligned left

Describe the bug

The number input edit is aligned left.
To Reproduce

Set column content type to number
Click a cell
See the input on the left

Expected behavior
The input should be on the right like the cell
Screenshots

Using Mobile App?

No

Fixed in 4.1.0


web3-provider doesn't work with custom rpc

"@walletconnect/web3-provider": "^1.4.1"
Following the docs here I attempted the following:
import WalletConnectProvider from "@walletconnect/web3-provider";

...

const provider = new WalletConnectProvider({
    rpc: {
        56: "https://bsc-dataseed.binance.org",
    },
});

await provider.enable();

The QR modal pops up and I scan using TrustWallet and I get errors:
Unhandled Promise rejection: Callback was already called. ; Zone: <root> ; Task: Promise.then ; Value: Error: Callback was already called.
    at onlyOnce.js:9
    at createAsyncMiddleware.js:54
    at ZoneDelegate.invoke (zone-evergreen.js:372)
    at Zone.run (zone-evergreen.js:134)
    at zone-evergreen.js:1276
    at ZoneDelegate.invokeTask (zone-evergreen.js:406)
    at Zone.runTask (zone-evergreen.js:178)
    at drainMicroTaskQueue (zone-evergreen.js:582) Error: Callback was already called.
    at http://localhost:4200/vendor.js:165943:32
    at http://localhost:4200/vendor.js:97:11
    at ZoneDelegate.invoke (http://localhost:4200/polyfills.js:1146:26)
    at Zone.run (http://localhost:4200/polyfills.js:908:43)
    at http://localhost:4200/polyfills.js:2050:36
    at ZoneDelegate.invokeTask (http://localhost:4200/polyfills.js:1180:31)
    at Zone.runTask (http://localhost:4200/polyfills.js:952:47)
    at drainMicroTaskQueue (http://localhost:4200/polyfills.js:1356:35)

and clear querying against infura mainnet even though a node url was provided:

What am I doing wrong?

Somehow I've submitted this to the completely wrong project. Apologies!!!!


Node not Starting with new Version of RancherOS (1.4.1)

Rancher versions:
rancher/server or rancher/rancher: 2.0.8
Docker version: (docker version,docker info preferred) https://releases.rancher.com/install-docker/17.03.sh
Operating system and kernel: (cat /etc/os-release, uname -r preferred) RancherOS 1.4.1
**Type/provider of hosts: (VirtualBox/Bare-metal/AWS/GCE/DO)**VSphere
**Setup details: (single node rancher vs. HA rancher, internal DB vs. external DB)**Single Node Rancher
Steps to Reproduce:
Since updating to the new version of RancherOS the new nodes created with my node template are never ready even if RancherOS finished booting.
Rolling back to 1.4.0 fixed my problem.

Hi @miclefebvre ,

Which ISO did you use, can you share your node template?
Did you set up a special cloud-config?

@kingsd041 Can you help to confirm this issue? We happen to have a vsphere setup in our office.

The Vm ware iso.
No cloud config.

I started a new node with the version 1.4.1 to add some info.
When RancherOS is booted, Rancher display this error and after that restart the process of redownloading the image and starting an new RancherOS
2018/09/26 20:03:51 [ERROR] NodeController c-7pj5f/m-pbgvp [node-controller] failed with : Error creating machine: Error in driver during machine creation: ServerFaultCode: The session is not authenticated.
2018/09/26 20:03:51 [INFO] NodeController c-7pj5f/m-pbgvp completed with dropped err: [node-controller] failed with : Error
2018/09/26 20:03:52 [INFO] NodeController c-7pj5f/m-pbgvp completed with dropped err: [node-controller] failed with : Error
2018-09-26 20:04:06.581271 I | mvcc: store.index: compact 7994560
2018-09-26 20:04:06.809846 I | mvcc: finished scheduled compaction at 7994560 (took 216.358325ms)
2018/09/26 20:05:53 [ERROR] NodeController c-7pj5f/m-pbgvp [node-controller] failed with : failed to remove finalizer on c-7pj5f:m-pbgvp

Hi @miclefebvre ,
I verified RancherOS 1.4.1 and created the cluster successfully according to the way you created it.
@niusmallnan This issue has not been reproduced.

@rootwuj  If I use the exact same config but only with this line instead. It works:
"boot2dockerUrl": "https://releases.rancher.com/os/v1.4.0/rancheros-vmware.iso",
The config that is not working:
{
"amazonec2Config": null,
"annotations": { },
"baseType": "nodeTemplate",
"created": "2018-07-24T17:40:59Z",
"createdTS":<PHONE_NUMBER>000,
"creatorId": "user-lp692",
"driver": "vmwarevsphere",
"engineEnv": { },
"engineInsecureRegistry": [
"containerregistry.registry.com",
],
"engineInstallURL": null,
"engineLabel": { },
"engineOpt": { },
"engineRegistryMirror": null,
"id": "user-lp692:nt-p4t9g",
"labels": { },
"links": {
"nodePools": "…/v3/nodePools?nodeTemplateId=user-lp692%3Ant-p4t9g",
"nodes": "…/v3/nodes?nodeTemplateId=user-lp692%3Ant-p4t9g",
"remove": "…/v3/nodeTemplates/user-lp692:nt-p4t9g",
"self": "…/v3/nodeTemplates/user-lp692:nt-p4t9g",
"update": "…/v3/nodeTemplates/user-lp692:nt-p4t9g"
},
"name": "vSpereWorkerMem",
"removed": null,
"state": "active",
"transitioning": "no",
"transitioningMessage": "",
"type": "nodeTemplate",
"useInternalIpAddress": true,
"uuid": "b9ca8d8d-8f68-11e8-b67c-0242ac110002",
"vmwarevsphereConfig": {
"boot2dockerUrl": "https://releases.rancher.com/os/latest/rancheros-vmware.iso",
"cfgparam": [
"disk.enableUUID=TRUE"
],
"cloudinit": "",
"cpuCount": "4",
"datacenter": "",
"datastore": "datastore1",
"diskSize": "20000",
"folder": "",
"hostsystem": "",
"memorySize": "4096",
"network": [
"VM Network"
],
"pool": "",
"username": "myusername",
"vcenter": "<IP_ADDRESS>",
"vcenterPort": "443"
}

@miclefebvre  Hey, I re-verified it in my environment, my cluster works very well.
Here is my template configuration:
{
"amazonec2Config": null,
"annotations": { },
"baseType": "nodeTemplate",
"created": "2018-09-29T05:36:31Z",
"createdTS":<PHONE_NUMBER>000,
"creatorId": "user-5hjhb",
"driver": "vmwarevsphere",
"engineEnv": { },
"engineInstallURL": null,
"engineLabel": { },
"engineOpt": { },
"engineRegistryMirror": null,
"id": "user-5hjhb:nt-t22xq",
"labels": { },
"links": {
"nodePools": "…/v3/nodePools?nodeTemplateId=user-5hjhb%3Ant-t22xq",
"nodes": "…/v3/nodes?nodeTemplateId=user-5hjhb%3Ant-t22xq",
"remove": "…/v3/nodeTemplates/user-5hjhb:nt-t22xq",
"self": "…/v3/nodeTemplates/user-5hjhb:nt-t22xq",
"update": "…/v3/nodeTemplates/user-5hjhb:nt-t22xq"
},
"name": "tem-mirror",
"state": "active",
"transitioning": "no",
"transitioningMessage": "",
"type": "nodeTemplate",
"useInternalIpAddress": true,
"uuid": "9ee2fd65-c3a9-11e8-9020-0242ac110002",
"vmwarevsphereConfig": {
"boot2dockerUrl": "http://<IP_ADDRESS>/ros/rancheros-vmware-141.iso",
"cfgparam": null,
"cloudinit": "http://<IP_ADDRESS>/ros/cloud-config.yml",
"cpuCount": "2",
"datacenter": "",
"datastore": "",
"diskSize": "20000",
"folder": "",
"hostsystem": "",
"memorySize": "3072",
"network": null,
"pool": "",
"username": "root",
"vcenter": "<IP_ADDRESS>",
"vcenterPort": "443"
}
}

I suspect that it may be related to "engineInsecureRegistry": ["containerregistry.registry.com",], you can move the registry configuration to the cloud-config file and specify the cloudinit parameters in the template.
Just like this:

http://<IP_ADDRESS>/ros/cloud-config.yml
#cloud-config
rancher:
  registry_auths:
    https://index.docker.io/v1/:
      auth: dXNlcm5hbWU6cGFzc3dvcmQ=
ssh_authorized_keys:
  - ssh-rsa AAAA...

Reference document:
https://rancher.com/docs/os/v1.x/en/installation/configuration/private-registries/


Getting exception when adding two discrete MISO transfer functions

Hi again! :-)
I think the following code should work, but I'm getting an exception:
import harold
print(harold.__version__)
tf = (harold.Transfer([[[0.0], [1.0]]], [[[1.0], [1.0]]], 0.02)
    + harold.Transfer([[[1.0], [0.5]]], [[[1.0], [1.0]]], 0.02))
print(tf.polynomials)

Here is the output:
1.0.2.dev0+90a785b
---------------------------------------------------------------------------
ValueError                                Traceback (most recent call last)
~/anaconda3/envs/py38/lib/python3.8/site-packages/harold-1.0.2.dev0+90a785b-py3.8.egg/harold/_classes.py in __add__(self, other)
    404                 try:
--> 405                     return Transfer(self.to_array() + other.to_array(),
    406                                     dt=self._dt)

~/anaconda3/envs/py38/lib/python3.8/site-packages/harold-1.0.2.dev0+90a785b-py3.8.egg/harold/_classes.py in __init__(self, num, den, dt)
     64         (self._num, self._den,
---> 65          self._shape, self._isgain) = self.validate_arguments(num, den)
     66         self._p, self._m = self._shape

~/anaconda3/envs/py38/lib/python3.8/site-packages/harold-1.0.2.dev0+90a785b-py3.8.egg/harold/_classes.py in validate_arguments(num, den, verbose)
   1504             if returned_numden_list[0].size > returned_numden_list[1].size:
-> 1505                 raise ValueError('Noncausal transfer functions are not '
   1506                                  'allowed.')

ValueError: Noncausal transfer functions are not allowed.

During handling of the above exception, another exception occurred:

ValueError                                Traceback (most recent call last)
<ipython-input-1-fe5c19b20276> in <module>
      1 import harold
      2 print(harold.__version__)
----> 3 tf = (harold.Transfer([[[0.0], [1.0]]], [[[1.0], [1.0]]], 0.02)
      4     + harold.Transfer([[[1.0], [0.5]]], [[[1.0], [1.0]]], 0.02))
      5 print(tf.polynomials)

~/anaconda3/envs/py38/lib/python3.8/site-packages/harold-1.0.2.dev0+90a785b-py3.8.egg/harold/_classes.py in __add__(self, other)
    406                                     dt=self._dt)
    407                 except ValueError:
--> 408                     raise ValueError('Shapes are not compatible for '
    409                                      'addition. Model shapes are {0} and'
    410                                      ' {1}'.format(self._shape, other.shape))

ValueError: Shapes are not compatible for addition. Model shapes are (1, 2) and (1, 2)

Yeah probably again some static gain detection failure. Let me check quickly

By the way you can directly create static gains like the following
F = harold.Transfer([[1, 0.5]], 0.02)

Yep! That worked like a charm:
In [3]: harold.Transfer([[1, 0.5]], 0.02).polynomials
Out[3]: ([[array([[1.]]), array([[0.5]])]], [[array([[0.02]]), array([[0.02]])]])

Hi Tim, this revealed yet another symptom of #30 so it will take a bit longer for me to revamp the Transfer class. So to let you know :)

Understood. Thanks @ilayn! :)

Well at least I wasn't lying about the time needed 😃 Sincere apologies for the ridiculous delay.


Prevent crash when setting empty chart data

Setting chart data to an empty array causes getLinePath to loop (due to unsigned integer underflow) and leak memory until it crashes. It also causes scale in strokeChart to be infinite as the chart has zero extent.
This PR guards setting empty data to prevent this.

Thanks again! It's good to have a code less likely to crash :)


[BUG]

Describe the bug
no downloads available in all games
Steps to Reproduce
no way
Expected behavior
no way
Screenshots

Operating System
windows 11
Hydra Version
2.0.2
Additional Information
No response

Expected behavior, since 2.0 you need to add sources by yourself.
You can find help in the Discord server managed by the community https://discord.gg/TSxymg7JTJ


Add health checks for .simplereport.gov and api-.simplereport.gov

and trigger slack alerts in #prime-notifications

@nickrobison-usds are you still working on this, or should we move it to the icebox?

@nickrobison-usds are you still working on this, or should we move it to the icebox?


NEXT-17040 - Added custom fields to landingpage front-end

1. Why is this change necessary?
Currently it is possible to assign custom fields to landing pages. However it is not possible to access the custom fields through Twig at the moment.
2. What does this change do, exactly?
Adds the translated custom fields to the page variable, so it can be accessed through page.customFields.
3. Describe each step to reproduce the issue or behaviour.
Assign a custom field to a landing page. Dump page. Custom fields are accessible through Twig.
4. Please link to the relevant issues (if any).
https://issues.shopware.com/issues/NEXT-17040
5. Checklist

[ ] I have written tests and verified that they fail without my change
[x] I have created a changelog file with all necessary information about my changes
[ ] I have written or adjusted the documentation according to my changes
[ ] This change has comments for package types, values, functions, and non-obvious lines of code
[x] I have read the contribution requirements and fulfil them.

Hello,
thank you for creating this pull request.
I have opened an issue on our Issue Tracker for you. See the issue link: https://issues.shopware.com/issues/NEXT-20616
Please use this issue to track the state of your pull request.

@MelvinAchterhuis many thanks for your contribution! 🚀


Iterate properties with scheme properties

Updated getMirror to iterate properties with scheme properties

Sorry, I'll re-implement based on current master :pray:


Assersion Signature Verification

Hello can you point me on where exactly in the example project , the signature verification on the SAMLResponse content is being done?
I know you are using xmlsecurity but can't identify where this check is done in the code, i only find the import of xmlsec in settings.py
Thanks

We have It in pysaml2 internals, look at there

so if i understand correctly , the code is not here in this repository?

Yes sir, It's in pysaml2


Need to have an option to specify the scheme for secure links (https) in navigation links

When using NarBar we use Nav class to specify the list of items for the navigations.
Each item has the 'url' option to specify the desired path.
http://www.yiiframework.com/doc-2.0/yii-bootstrap-nav.html#$items-detail
After reviewing the code, I found that Nav class uses Html::a( ) method to create the link.
https://github.com/yiisoft/yii2/blob/master/extensions/bootstrap/Nav.php#L183
And inside Html::a( ) it uses, Url::to( ) method to create the URL.
https://github.com/yiisoft/yii2/blob/master/framework/helpers/BaseHtml.php#L358
For Url::to( ) , as second parameter we can specify the scheme('http', or 'https').
So I think it would be great if we can use this scheme paramter to create secure links in Nav items.
For example we can have an option called 'scheme' when creating an item.
This is useful and easy when we are creating secure links for sensitive actions such as login, account management pages.
Personally, right now I'm directly using Url::to( ) method to create the expected secure link and assign it to the item 'url' option and it seems to be bit ugly.
...
'url' => Url::to(['/site/login'],'https')
...

Not sure if this is really a problem. Using Url::to() directly is a pretty valid usage and most explicitly shows what is going on. If we add an extra parameter it will be more hidden what is going on.

'url' => Url::to(['/site/login'],'https') is the expected way. It's not common to specify scheme for internal URLs. So we should not further complicate the format of the url option.


fix: fix Social Signup or Linking causes 500 Internal Server Error

Fix: #918

plz r @hsluoyz

@KrishnaPG plz check if this PR can fix your issue

Thank you much @hsluoyz . We are running casdoor as standard docker image
docker run  -p 8000:8000 -v /path/to/app.conf:/conf casbin/casdoor:latest

How to access this PR as part of the standard docker image?

@KrishnaPG the "fix: xxx" PR won't trigger a new Docker image release. It seems that you need to wait for 1.76.0 release

Understood. Thank you @hsluoyz Hope, it wont be too long. On the docker hub, I see the releases every few days frequently. Hopefully 1.76.0 will be soon


Fix parse case of empty string with headers true

Fix #64
In this case "undefined method `headers' for []:Array (NoMethodError)"
was occurring.
row = CSV.parse('', headers: true)
p row
p row.headers

when CSV.parse with (headers: true) option,
return CSV::Table class is expected, but it was returned Array as below.
def read
  rows = to_a #=> []
  headers = parser.headers #=> nil
  if headers
    Table.new(rows, headers: headers)
  else
    rows
  end
end

We shouldn't return Table when headers: isn't specified.

I understand. Changed to judge by CSV::Parser#use_headers.


Feature request: reset when unlocking Windows

It would be a neat feature that when you return to your computer and Unlock it, Stretchly sees that and reset the clock on the "big" 5 minute break as well as the next small break. E.g. if I get back and unlock I was probably walking around and don't need a break again right away.
There is probably an equivalent to "unlocking windows" on the Mac etc. Waking from Sleep would be similar.

We already have sleep functionality: unless very specific case, I reset the breaks on wake-up.
There is a new API for lock/unlock for Mac/Windows, so I will add that as well: https://electronjs.org/docs/api/power-monitor#event-lock-screen-macos-windows

What does Stretchly consider "sleep"? If I'm away from my computer for, say, 30 minutes, and the computer locks but doesn't go to sleep (because my power settings have it sleep at 1 hour), will Stretchly reset the breaks when I unlock the computer?

@ohsospoko right now stretchly checks for this event: https://electronjs.org/docs/api/power-monitor#event-suspend
In MacOS that is "Sleep". No idea how it's called in Windows.
stretchly also checks for idle time (which unfortunately also is not same on every platform):

if idle time is longer than 5 minutes and user has came back from idle time, then reset breaks

The 5-minute idle should take care of most situations, I would think. Certainly answers my question.

fixed in #448


Add 'see more' link to hotels

Allows users to go directly to the hotels list page for a city without entering search criteria.

:+1:


Update localization priority value

The localized articles are getting high page views so let's upgrade the priority so it gets human translated.

@JohanFreelancer9 Copy editing is needed for this PR. Thanks.


Move to Netlify?

I'm considering switching to Netlify for our website. Here are some benefits of doing this:

Faster deployments of updates to the demo site
Ultra fast loading (does this matter that much?)
And, the most important thing at least to me: deployments of the demo for every pull request

This way anyone can view someone's new styles without downloading or installing anything. The main con of switching is that Netlify is a separate addon and might complicate things for a project in an early-ish stage.
I'd love to hear the community's feedback on this - what are your thoughts?

I love it! I'm a big fan of Netlify, let me know if you need a hand with this.
I don't think Netlify will complicate the project too much - it's just sitting "on top" of the project. The deploys would be handled invisibly to users, and we could even integrate the preview links into pull requests.

I think netlify is great!
I don't think it will complicate the project too much. The preview links I think would be a resource to have (especially since this project is a CSS framework)

Ok, I set up the initial Netlify things. This is where the site will now be deployed. Things to still do:

Update links in readme, etc.
Setup PR deployments

Actually, everything should be set up! Lemmme make a test PR.

Awesome work! 🎉

Should we keep the GitHub Pages deployment up still? I think that's what was linked to from the reddit/HN post, so if we do remove it, we should find a way to provide an automatic redirect.


fix: CI such that coveralls leaves comments.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 92.63%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
1234

Relevant Lines:
1312

💛  - Coveralls


work together for project

Summary
i want use teletype to share my project for my workers not only share a file

Wanna work with me

wanna work together


Add example for combobox with highlighted matched text

Trying to close "ComboboxItemValue example" from #939
I've copied and tweaked the test suite from the plain combobox example

These tests already exist in the default example. I don't think we should duplicate them here. Instead, we need tests for this specific example, like asserting the ComboboxItemValue behavior. Maybe toMatchInlineSnapshot on the items to see if the markup is updated correctly?

These tests already exist in the default example. I don't think we should duplicate them here. Instead, we need tests for this specific example, like asserting the ComboboxItemValue behavior. Maybe toMatchInlineSnapshot on the items to see if the markup is updated correctly?

Hi @diegohaz, I've simplified the tests, let me know if you meant something different 😉

We can name this example with the same name as the component: combobox-item-value

Done!


Feature request: add elements key-tweaking functionality

Needed to remove the broken contracthash module from rust-bitcoin, see https://github.com/rust-bitcoin/rust-bitcoin/pull/365
I'll take this on because I directly use this API in Liquid and have some thoughts about how it could be improved.

closing duplicate (#64) in favour of this since one tends to forget old issues :).

Can we close this? https://github.com/rust-bitcoin/rust-bitcoin/pull/871 was merged in rust-bitcoin and includes the comment:

Yes, elements-miniscript needs this functionality. Will re-implement this over there

Yeah, let's close it here. It definitely belongs in elements-miniscript (where there are pegin descriptors) and not here (where there are not).


Add tnt block

This adds a new block "TNT". I've added an optional timer property to blocks that have a number of ticks and a callback.
This PR works, but is still rough around the edges. I'll comment inline.

This looks ok to me, I'm going to merge it so I can resolve the conflicts with my local stuff.


Conflict with @typescript-eslint/member-ordering

Hello.
I have this code:
export class SomeClass {
  @someDecorator
  private static someStaticMethod() {
    //
  }

  private static someOtherStaticMethod = () => {
    //
  };
}

I'm getting this issue:
Member someOtherStaticMethod should be declared before all private decorated method definitions.
When I move someOtherStaticMethod manually to be before someStaticMethod, the issue it resolved, but when I format with prettier, it reverts it and moves someOtherStaticMethod to be after someStaticMethod, making the issue appear again.
eslint config:
'@typescript-eslint/member-ordering': 'error',
prettier config:
"plugins": ["prettier-plugin-sort-members"]
How can I resolve this issue? Thanks in advance.

Hi, thank you for reporting the issue. It's a bug. The default ordering of this plugin should be compatible with @typescript-eslint/member-ordering's default. I'm considering to fix it.
I found that @typescript-eslint/member-ordering itself looks inconsistent around static and decorated... For instance methods, it requires decorated ones get former. On the other hand, for static methods, it requires decorated ones get latter...
Anyway, I'm considering that we have to design this plugin to have capability with @typescript-eslint/member-ordering's default.
export class SomeClass {
  @someDecorator
  private static someStaticMethod() {
    //
  }

  // error
  private static someOtherStaticMethod(){
    //
  };
}

export class SomeClassB {
  @someDecorator
  private someStaticMethod() {
    //
  }

  // OK
  private someOtherStaticMethod() {
    //
  };
}

I'm wondering whether we should have an option to select precedence between consistency and compatibility.

@Tsury Would you try new version 0.2.1-rc.1?

Hey @seiyab, thanks for the rapid response!
I just tried 0.2.1-rc.1 and it seems to behave exactly the same for me - when eslint complains about the non-decorated static methods being below the non-decorated static method, and I manually move it, upon formatting it sends them down below again.
Was I required to configure anything maybe?

@Tsury Thank you for trying. Would you reload IDE?

Eh. Reloading the IDE did resolve the issue - sorry about that, and thank you so much both for this project and both for your quick response!

I'll leave it to you to close it as you see fit.

Thank you for reporting it and verify fix! Close as resolved 👍


fix: Verify when null value should be undefined in Select

SUMMARY
This PR fixes an edge case with the Select component. With dynamic controls there might be the case where a default value is being passed as null when it was intended to be undefined. This change makes sure that a null value that is not available in the options is considered asundefined instead.
BEFORE

AFTER

TESTING INSTRUCTIONS

Create a Histogram chart
Observe the Columns control

ADDITIONAL INFORMATION

[ ] Has associated issue:
[ ] Required feature flags:
[ ] Changes UI
[ ] Includes DB Migration (follow approval process in SIP-59)

[ ] Migration is atomic, supports rollback & is backwards-compatible
[ ] Confirm DB migration upgrade and downgrade tested
[ ] Runtime estimates and downtime expectations provided

[ ] Introduces new feature or API
[ ] Removes existing feature or API

@michael-s-molina for clarity, this is just a safety check for now. Ideally, we should go through each configuration object of the SelectControl in superset and superset-ui and remove the default value when it's null but it's meant to be undefined. I can do that in separate PRs.

@geido Can't this check be made in SelectControl?

For reference, we have agreed with Michael that this safety check will be done in SelectControl and SelectAsyncControl as those are the components where this problem might happen more often. I am about to update this PR.

🏷 v1.4


djxl : decode GIF from JXL

Is your feature request related to a problem? Please describe.
I would like to store a collection of GIFs in JXLs (because of the excellent compression). However, I would also like to restore these JXLs to their original format, GIF. I noticed that djxl can produce a series of JPEGs and PNGs from a GIF encoded to JXL. However, it can't recreate a GIF directly.
Describe the solution you'd like
I would like djxl to be able to decode a JXL file into a GIF file.
Describe alternatives you've considered
Currently, my only way to recreate a GIF from a JXL file is to transform a series of PNGs produced by dxl into a GIF.
Report of bug ?
When decompressing JXL to a series of JPEGs, the JPEGs produced are highly deteriorated compared to the initial quality of the GIF (even when using the options -q 100 --pixels_to_jpeg).

Additional context
I took this GIF file for testing : tenor.com/bftQl.gif

The version of my encoder / decoder is v0.3.7.
I'm on macOS, and use the version of jpeg-xl shipped with brew.

Looks like somehow in the case of animation, the output jpeg quality is set to 0 or something like that.
I personally don't think decoding to gif is in the scope of djxl, because in the general case (when the input was not a gif), that means djxl needs to do a color reduction, which is not at all easy to do properly (and doing it non-properly is not very useful).
Decoding to apng would be useful though, imo. You can then use existing tools from there.

Btw, when I try to decode animated jxl to jpg, whether it be created on my system or from https://github.com/libjxl/conformance it just throws the error that I need to specify quality.
~/P/test $ djxl -q 100 1.jxl 1.jpg
JPEG XL decoder v0.3.7 [AVX2]
Read 1955913 compressed bytes.
Decoded to pixels.
build/libjxl-git/src/libjxl/lib/extras/codec_jpg.cc:481: JXL_FAILURE: please specify a 0-100 JPEG quality
Failed to write decoded image for frame 1/18.
build/libjxl-git/src/libjxl/lib/extras/codec_jpg.cc:481: JXL_FAILURE: please specify a 0-100 JPEG quality
Failed to write decoded image for frame 2/18.
[...]
build/libjxl-git/src/libjxl/lib/extras/codec_jpg.cc:481: JXL_FAILURE: please specify a 0-100 JPEG quality
Failed to write decoded image for frame 17/18.
build/libjxl-git/src/libjxl/lib/extras/codec_jpg.cc:481: JXL_FAILURE: please specify a 0-100 JPEG quality
Failed to write decoded image for frame 18/18.
498 x 498, 0.51 MP/s [0.51, 0.51], 1 reps, 4 threads.
Allocations: 2123 (max bytes in use: 7.957910E+07)

libjxl version f8790509f3588413413682b611cf11f18f4498b1
I think it might be related?

Contrary to decoding to apng, where decoding from jxl already works, because of the limitations of the gif format, decoding from animated jxl to gif is out of scope.
Keeping the bug open to keep track of the JPEG issue.

I tried to reproduce the issue when taking the animated gif from the original post and then encoding to jxl with cjxl (and also cjxl_ng). When trying to decode this animated jxl to different formats this happens:

png: works as intended, gives animated png
jpg: fails with JXL_FAILURE: alpha is not supported
gif: fails with JXL_FAILURE: Encoding to GIF is not implemented
So I can't seem to be getting the artifacts you describe above at the current main. If you still can reproduce the problem at the current main, please reopen.

I can repro this with an animated jxl without alpha and also have a fix coming soon.


Xamarin.Forms CollectionView Support in Mobile Blazor Bindings

We want to create some projects using the Mobile Blazor Bindings. But the unavailability Xamarin.Forms CollectionView or similar UI Control is stopping us.
This is the most useful UI Control in the xamarin forms toolkit. It is used for  presenting lists of data using different layout specifications. Kindly port this UI Control to the Mobile Blazor Bindings.

Hi @rajeshjha96 , indeed adding support for templates controls such as CollectionView would be very useful. We have an issue on that logged here: https://github.com/xamarin/MobileBlazorBindings/issues/67 . Feel free to up-vote that issue so we can take that into account when prioritizing features. Thank you!


[BugFix] Empty kafka message leads data lost in routine load

What type of PR is this：

[x] bug
[ ] feature
[ ] enhancement
[ ] refactor
[ ] others

Which issues of this PR fixes ：

Fixes #8534
Problem Summary(Required) ：

This fixes the data lost problem when there's empty kafka message.
The previous implement of stream_load_pipe determines the EOF by whether the data length = 0, which is incorrect when there's empty kafka message. As a result, the left message would be abandoned and the data would be lost.

run starrocks_be_unittest


Ceph integration

This isn't finished yet, but wanted to get feedback on how best to integrate this piece.

Can one of the admins verify this patch?

"ok to test" to accept this pull request for testing
"test this please" for a one time test run
"add to whitelist" to add the author to the whitelist

Overall looks good, would like @j2sol approval too.

I hope this is a step closer. I'm still a little confused as to how much manual configuration is needed before we deploy. All suggestions are welcome..

Also, should I get rid envs/example/ceph/hosts and move them into envs/examples/standards/hosts?

If multiple backends for cinder are at play, it would be appropriate to create volume types with volume extra specs that links a type to a backend so that users can actually schedule volumes against a backend type. We don't already do this, but we should.

alright, things are looking pretty good here, I think we have to wait for the other bits to land before this will pass CI.

Needs rebase.

Will squash/rebase later, wanted to push a few fixes first.

This is also squashed and rebased.

Fails on test for ceph-monitor because it does not exist. @j2sol Is that something that goes in here?

This needs to wait for #1107 to get merged, then this can be rebased.

Let's wait on this a bit. I need to clean up the virsh stuff (run it only on compute hosts) now that we have fleshed out the various offerings.

This should be good now. Just rebased too. Will submit a ceph-compute PR soon.

ceph-compute merged, so this needs to be rebased so that it can use the role.

@j2sol Is this good to merge?

@zrs233 Should be good once it passes Jenkins. Makes more sense to put ceph-compute after the nova tasks.


Issue request form

make sure required info is present see github docs

Matt, could use your help with this. Or I could muddle through it. :)


config.theme is not supported

config.theme option is not officially supported by HyperTerm, what about handle them using plugins that exports the colors palette?
Some examples: https://github.com/mdo/hyperterm-atom-dark and https://github.com/jxnblk/hyperterminator/blob/master/index.js

Hyperterminator uses the new decorateConfig API. atom-dark uses the same pattern I have here (middleware which basically does what the decorateConfig API does. I'd love to make it so themes just export an object that a theme plugin like myself or hyperterm natively can consume. Let's followup in #1 as needed though.


Need list of python3 dependencies for lierre?

I was trying to create an RPM, but it would be very helpful to have a list of dependencies of the package.

The python requirements in setup.cfg: install_requires and [options.extras_require]
But there are additional requirements I should add in documentation:

notmuch

BTW, you remind me that I have some patches for notmuch I should submit to the upstream project, thanks!
And some recommended dependencies:

pass

Thanks, is there a help file or manual on how to get started? That would be helpful to include and also for figuring out how to use it.

So, it turns out that Fedora does not come with imaplib2.
But I wonder: which of the required packages are needed to build the binary and whicha re required for running the program?
Also, I wonder if there are additional depedencies missing.
No module named 'lierre.ui.error_logs_ui'
Btw, how do I attach files for sending on lierre?

Thanks, is there a help file or manual on how to get started? That would be helpful to include and also for figuring out how to use it.

Not yet.
It would be very useful especially because Lierre wraps other tools like notmuch/mbsync/offlineimap/etc, and for now merely uses them, so the user has to configure themselves notmuch/mbsync/offlineimap/etc prior to use Lierre. It's planned that Lierre's settings dialog will be able to generate configurations for such tools, but it's not implemented yet.
In the meantime, some documentation how to get things together would be useful, yes.

So, it turns out that Fedora does not come with imaplib2.

This is an optional dependency. With it, the "imapidle" plugin stays connected to the IMAP server and triggers a refresh each time the server says "you've got mail". Without it, the emails list will be refreshed only when you press manually the big "refresh" button, a bit more tedious.
Mail fetching doesn't depend on imapidle, it depends on mbsync (there's a dedicated plugin), or offlineimap (no dedicated plugin, but the generic "command" plugin should work) or other third-party tools.

But I wonder: which of the required packages are needed to build the binary and whicha re required for running the program?

The bare minimum really is what's in install_requires from setup.cfg, plus notmuch command-line tool which isn't in pypi and its python bindings.
The rest is optional because alternatives are possible. For example, with the bare minimum, you can only read a local Maildir folder, no IMAP support, but IMAP support is possible with your choice of tool, it can be mbsync (my recommendation for now) or offlineimap or any other similar tool you like.

No module named 'lierre.ui.error_logs_ui'

Do you have the full backtrace?
Under what path is Lierre installed when you get this error?
Can you confirm the following import works "from PyQt5.uic import loadUiType"?
Do you have "lierre/ui/error_logs.ui"?
Feel free to come by #lierre on freenode.

Btw, how do I attach files for sending on lierre?

This isn't implemented yet, though it should not be terribly hard to do, I'm still wondering how should the UI be.

Thanks! File attachments are very important for me.
I am fine with reading a local Maildir folder, no problem.
Here is the error message that I get:
$ lierre
Traceback (most recent call last):
  File "/usr/lib/python3.7/site-packages/lierre/ui/ui_loader.py", line 11, in load_ui_class
    mod = import_module(f'.{module_name}_ui', package)
  File "/usr/lib64/python3.7/importlib/__init__.py", line 127, in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
  File "<frozen importlib._bootstrap>", line 1006, in _gcd_import
  File "<frozen importlib._bootstrap>", line 983, in _find_and_load
  File "<frozen importlib._bootstrap>", line 965, in _find_and_load_unlocked
ModuleNotFoundError: No module named 'lierre.ui.error_logs_ui'

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/bin/lierre", line 11, in <module>
    load_entry_point('lierre==0.1.0', 'gui_scripts', 'lierre')()
  File "/usr/lib/python3.7/site-packages/pkg_resources/__init__.py", line 489, in load_entry_point
    return get_distribution(dist).load_entry_point(group, name)
  File "/usr/lib/python3.7/site-packages/pkg_resources/__init__.py", line 2852, in load_entry_point
    return ep.load()
  File "/usr/lib/python3.7/site-packages/pkg_resources/__init__.py", line 2443, in load
    return self.resolve()
  File "/usr/lib/python3.7/site-packages/pkg_resources/__init__.py", line 2449, in resolve
    module = __import__(self.module_name, fromlist=['__name__'], level=0)
  File "/usr/lib/python3.7/site-packages/lierre/__main__.py", line 8, in <module>
    from .app import Application
  File "/usr/lib/python3.7/site-packages/lierre/app.py", line 9, in <module>
    from .ui.error_logs import install as install_log_handler
  File "/usr/lib/python3.7/site-packages/lierre/ui/error_logs.py", line 49, in <module>
    Ui_Dialog = load_ui_class('error_logs', 'Ui_Dialog')
  File "/usr/lib/python3.7/site-packages/lierre/ui/ui_loader.py", line 16, in load_ui_class
    return loadUiType(str(path))[0]
  File "/usr/lib64/python3.7/site-packages/PyQt5/uic/__init__.py", line 200, in loadUiType
    resource_suffix, import_from)
  File "/usr/lib64/python3.7/site-packages/PyQt5/uic/Compiler/compiler.py", line 111, in compileUi
    w = self.parse(input_stream, resource_suffix)
  File "/usr/lib64/python3.7/site-packages/PyQt5/uic/uiparser.py", line 1013, in parse
    document = parse(filename)
  File "/usr/lib64/python3.7/xml/etree/ElementTree.py", line 1197, in parse
    tree.parse(source, parser)
  File "/usr/lib64/python3.7/xml/etree/ElementTree.py", line 587, in parse
    source = open(source, "rb")
FileNotFoundError: [Errno 2] No such file or directory: '/usr/lib/python3.7/site-packages/lierre/ui/error_logs.ui
```'
Does this help?

Sorry, in that mode, when .py files were copied, the .ui files were not. It should be now fixed in d5e06917f75c4fc6a4050ad5daa9b94a8d5a0942.

Thanks, I am able to load it now. However, I get the following:
ERROR:stevedore.extension:Could not load 'imapidle': No module named 'imaplib2'
I think that since stevedore is required, so is imaplib2?
Also, when I click on a message, nothing happens. How do I read it? Set the settings?

I think that since stevedore is required, so is imaplib2?

No, don't worry :)
stevedore is the plugin loader, and it's installed, so it's okay. The imapidle plugin cannot load because imaplib2 is not present, but the imapidle plugin isn't mandatory. Probably I should make the message look less frightening.

Also, when I click on a message, nothing happens. How do I read it? Set the settings?

The main view is a list of conversations (threads), not of messages (a la GMail). Double click a thread in the list view, it will open the conversation.

In the conversation view, click a message on the right to expand it (unread messages are automatically expanded). Or click a message in the left tree to focus it (bold border).
I'm open to suggestions on the usability.

Thanks, and I appreciate all your hard work. However, when I double click on a conversaion, nothing happens. I get the following on the commandline:
$ lierre
ERROR:stevedore.extension:Could not load 'imapidle': No module named 'imaplib2'
Traceback (most recent call last):
  File "/usr/lib/python3.7/site-packages/lierre/ui/tabwidget.py", line 51, in addThread
    w = ThreadWidget(tid, parent=self)
  File "/usr/lib/python3.7/site-packages/lierre/ui/thread_widget.py", line 56, in __init__
    mdl = ThreadMessagesModel(thread_id)
  File "/usr/lib/python3.7/site-packages/lierre/ui/models.py", line 282, in __init__
    thread = get_thread_by_id(db, thread_id)
  File "/usr/lib/python3.7/site-packages/lierre/utils/db_ops.py", line 25, in get_thread_by_id
    q.set_omit_excluded(q.EXCLUDE.FALSE)
AttributeError: 'Query' object has no attribute 'set_omit_excluded'

I'm sorry about all that difficulties you encounter, it really needs polish...
I have made a few patches to notmuch's python bindings (which aren't as complete as the C library). Some of the patches were merged by the upstream notmuch project but not all of them (see https://github.com/hydrargyrum/notmuch/commits/wip for my stash). They made a few review remarks I should take into account and then republish my patches so they merge them.
Until they get merged upstream though, I'll patch Lierre to make it degrade gracefully when the added features aren't present in the notmuch bindings.

I see, thanks again for all your hard work. I will await the fixes.

The AttributeError: 'Query' object has no attribute 'set_omit_excluded' exception should be fixed now.
I also added very basic attachment support as a proof-of-concept. As I said, I'm not sure about the final UI for attachments, even toolbars for adding an attachment, so right now it's a bit hidden, you need to press alt-j when composing an email to spawn a file dialog for selecting files to attach. It resembles Thunderbird's attachment list.
It's still basic support, you can't remove an attachment yet.
It wasn't thoroughly tested too, my mail hoster has a few problems right now that made testing complicated. I need to change my mail hoster!

Thanks very much. This works now, at least the basic display of the e-mail.
I am having trouble with displaying the attachments, however, from a received message. It is marked attachment all right, but I can not see it inside the message. And I get:

Traceback (most recent call last):
  File "/usr/lib/python3.7/site-packages/lierre/ui/models.py", line 668, in refreshOneMail
    row = self.indexes[tid]
AttributeError: 'ThreadListModel' object has no attribute 'indexes'

Also, how do I increase the diaplay font, etc? I am on a HiDPi device so this is an issue. Many thanks!

Traceback (most recent call last):
  File "/usr/lib/python3.7/site-packages/lierre/ui/models.py", line 668, in refreshOneMail
    row = self.indexes[tid]
AttributeError: 'ThreadListModel' object has no attribute 'indexes'

This is fixed, thanks. But I believe it's unrelated to

I can not see it inside the message

I think this is due to the fact the email you received has no (or it's empty) text/plain version, probably only a text/html version. Right now, Lierre displays a blank mail by default for this. You can click the "..." tool button on the message and select "Display as HTML" to view the text/html version.
But this behaviour will be improved, either we should display text/html version if text/plain is missing, or at least convert text/html to text/plain using html2text.

Also, how do I increase the diaplay font, etc? I am on a HiDPi device so this is an issue.

I don't know about this. Shouldn't it be set by your desktop environment? Do you have the same issue with other Qt5 (or PyQt5) apps?

I will be unavailable for a few days, I created a bunch of dedicated reports, I'm sorry if it sent you many notifications.

Thanks, I will await the changes as and when they happen. Have a good New Year.

Traceback (most recent call last):
  File "/usr/lib/python3.7/site-packages/lierre/ui/models.py", line 668, in refreshOneMail
    row = self.indexes[tid]
AttributeError: 'ThreadListModel' object has no attribute 'indexes'

This is fixed, thanks. But I believe it's unrelated to

I can not see it inside the message

I think this is due to the fact the email you received has no (or it's empty) text/plain version, probably only a text/html version. Right now, Lierre displays a blank mail by default for this. You can click the "..." tool button on the message and select "Display as HTML" to view the text/html version.
But this behaviour will be improved, either we should display text/html version if text/plain is missing, or at least convert text/html to text/plain using html2text.

No, I am able to see the html, and it works well, thank you. But there is no attachment (however, I know that the e-mail has a PDF attachment and the tag says so) but inside the e-mail display in lierre, it is simply not there, poof!


missing complete prettier.io configuration

as the CONTRIBUTING.md file states, the prettier.io code formatter is used, but when looking into the current config, only the singleQuote option is set.
Now that there are formatting rules specified (inside the CONTRIBUTING.md file) these should be also applied to the prettier.io configuration.

As far as I can tell the default options of prettier are matching with my CONTRIBUTING.md — correct me if I am wrong

As far as I can tell the default options of prettier are matching with my CONTRIBUTING.md — correct me if I am wrong

I never used prettier.io before, never even heard of it, until now I only used unrustify. but yes, after formatting one file with it, I noticed that prettier.io does use a default configuration, I don't know if it fits to the CONTRIBUTING.md file, but I think that'd be a different issue.


Recursive includes are not supported ?

Does shader-toy only support one layer include file?

Could be true, though that was certainly not the intention. I'll take a look at it.
On a side note, we should probably start using real source mapping, because for now we require that includes and input files are defined before any code to ensure that line numbers are correct.


Updated commentAcknowledgement modal.

Removed outdated point regarding the ability to delete/edit comments and replaced it with an at least somewhat relevant point.
PR Checklist

[x] I have checked that this PR is not a duplicate of an existing PR (open, closed or merged)
[x] I have checked that this PR does not introduce a breaking change
[ ] This PR introduces breaking changes and I have provided a detailed explanation below

PR Type
What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting)
[x] Refactoring (no functional changes)
[ ] Documentation changes
[ ] Other - Please describe:

Fixes
Issue Number: #3802
What is the current behavior?
Comment Acknowledgement modal includes incorrect information.
What is the new behavior?
Comment Acknowledgement modal now includes more relevant information, scrapping the incorrect information.
Other information
I did not make changes to the "Alpha" phrasing as I am not sure if comments are still in alpha, beta, etc.

Thanks for fixing this!


add WhiskActivation.Outcome, hiding Either[ActivationId, WhiskActivation] impl

Currently, the implementation of the datatype of the active ack return flow from the Invoker is transparent, and spread across a dozen files: Either[ActivationId, WhiskActivation]
this PR introduces WhiskActivation.Outcome, an opaque data type that hides the impl.
the goal of this PR is to enable future work that may change the impl, without those PRs each having to change a dozen files. let's pay that cost once, in this PR.
PG3 1424

i'm now a bit more skeptical of this PR. any change to WhiskActivation.Outcome that moves it away from a type alias will run afoul of the pervasive Left and Right idioms, not to mention the maps. i.e. the use points all assume that the impl is an Either, making it hard to refactor, unless we also abstract away the projections...

That was my point above. The point of using the  either type basically a union type here was to avoid additional overhead for serdes. It’s possibly to refactor the rest but you’re introducing effectively a new type.

we could make a Left and Right constructor... i'll think about it a bit more. i think there's some value here

So you don’t have to change every location you can also just add a toEither method.

@starpit what's the status of this? Is this still relevant?

Closing this as abandoned for quite some time. @starpit let me know if you want to reopen.


BUG: Solves intermittent corrupted cells during de-serialization

The first cell was getting corrupted when de-serializing the mesh.
On de-bugging found that creating a copy was working fine always and the error was due to array_view.
The root cause is not yet known, but this approach solves the problem.
Should we replace array_view with the array at all places where dict is created ?

PR Checklist

[ ] No API changes were made (or the changes have been approved)
[ ] No major design changes were made (or the changes have been approved)
[ ] Added test (or behavior not changed)
[ ] Updated API documentation (or API not changed)
[ ] Added license to new files (if any)
[ ] Added Python wrapping to new files (if any) as described in ITK Software Guide Section 9.5
[ ] Added ITK examples for all new major features (if any)

Refer to the ITK Software Guide for
further development details if necessary.

Should we replace array_view with the array at all places where dict is created ?

Yes!


3.0.0-next.6 - use of native datalist tag causes errors

Describe the bug
When <datalist></datalist> is used without defining a <clr-datalist-container>  it throws the following error:
ERROR NullInjectorError: StaticInjectorError(AppModule)[ClrDatalist -> DatalistIdService]:
  StaticInjectorError(Platform: core)[ClrDatalist -> DatalistIdService]:
    NullInjectorError: No provider for DatalistIdService!

How to reproduce
Steps to reproduce the behavior:

Go to Stackblitz
Open console to see the error details

Expected behavior
DatalistIdService should not be called when a <datalist> tag is defined without  the <clr-datalist-container>
Versions
App

Angular: [8.2.9]
Clarity: [3.0.0-next.6]

Device:

Type: [PC]
OS: [windows 10]
Browser [chrome]
Version [79.0.3945.117]

Additional notes
Add any other notes about the problem here.

DatalistIdService is provided by the clr-datalist-container. Your working example in the stackblitz is the correct way to use this component.
Closing as this is an implementation question and not an issue.

DatalistIdService is provided by the clr-datalist-container.

That is true, but when we wish to use datalist as a native html element or in another type of component (not as a clarity-datalist and therefore, without the clr-datalist-container) it breaks the application since it looks for a DatalistIdService . In the stackblitz the native input with datalist is shown, not the clarity one since the error is occured on the native datalist.
As reference: if  a native html select is used, without the clarity directive on the input and without the clr-select-container it does not break the application. The native select and clarity-select can be used interchangeably .

We should guard against this a little better, at least throw an exception to explain it (as we do with passwords) or handle it gracefully.

I think that overriding the HTML5-default 'datalist' selector is causing this: https://github.com/vmware/clarity/blob/d087d40e623bd472e397e5374e6e4ecf02507b11/src/clr-angular/forms/datalist/datalist.ts#L13 .
Is it possible to check if the 'datalist' selector is used inside of the ?

The selector should stay, but we need to basically make the directive inert unless its inside the container (which we can detect).

I'll fix it this week and submit a PR with @Optional on the service and then add a check for the service before setting the id. Should be pretty simple. (I know, I know, those are famous last words )


SCCM Only

This page seems to be very SCCM focused.... how can i rollout these options with Intune?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 08d16473-db61-23bd-7201-f5d7d6a56cc8
Version Independent ID: 468238c8-8fb4-3dff-3485-07daab0c7833
Content: Onboard to the Microsoft Defender ATP service - Windows security
Content Source: windows/security/threat-protection/microsoft-defender-atp/onboarding.md
Product: w10
Technology: windows
GitHub Login: @mjcaparas
Microsoft Alias: macapara

Hello @alanburchill - Thank you for your query, please see Enforce compliance for Microsoft Defender ATP with Conditional Access in Intune and Configure Microsoft Defender ATP in Intune for details regarding deployment of Microsoft Defender ATP in Intune.
Thanks
Imran.


splunk-connect-for-kubernetes stuck in CrashLoopBackOff

I am trying to install splunk-connect-for-kuberenetes on minikube for testing and learning.
I have sucessfully installed docker-splunk in mini-kube but when I try to deply splunk-connect-for-kubernetes i get error below.
splunk install i have replaced hec token with x's
export MONITORING_MACHINE=https://<IP_ADDRESS>:8443 && export HEC_TOKEN=xxxxxxxxxxxxxxxx && export HEC_PORT=8088 && export GLOBAL_HEC_INSECURE_SSL=true && export OBJECTS_INSECURE_SSL=true && export METRICS_INSECURE_SSL=true && export JOURNALD_PATH=/run/log/journal && export KUBELET_PROTOCOL=https && export METRICS_INDEX=k8_metrics && export LOG_INDEX=k8_events && export META_INDEX=k8_objects && export CLUSTER_NAME=mini-splunk && export HELM_RELEASE_NAME=splunk-k8s && export KUBERNETES_NAMESPACE=splunk && export CORE_OBJ=pods,nodes && export APPS_OBJ= && files=("kubernetes_connect_template.yaml" "deploy_sck_k8s.sh") && for each in "${files[@]}"; do wget -O- --no-check-certificate http://<IP_ADDRESS>:31800/en-US/static/app/splunk_app_infrastructure/kubernetes_connect/"$each" > $each; done && wget https://github.com/splunk/splunk-connect-for-kubernetes/releases/download/1.2.0/splunk-connect-for-kubernetes-1.2.0.tgz -O splunk-connect-for-kubernetes.tgz && bash deploy_sck_k8s.sh
Errors and logs
sed: 1: "s/${monitoring_machine} ...": bad flag in substitute command: '/'
chown: /fluentd/etc/splunk/..data: Read-only file system
chown: /fluentd/etc/splunk/splunk_hec_token: Read-only file system
chown: /fluentd/etc/splunk/..2019_10_22_01_09_22.178706774/splunk_hec_token: Read-only file system
chown: /fluentd/etc/splunk/..2019_10_22_01_09_22.178706774: Read-only file system
chown: /fluentd/etc/splunk/..2019_10_22_01_09_22.178706774: Read-only file system
chown: /fluentd/etc/splunk: Read-only file system
chown: /fluentd/etc/splunk: Read-only file system
chown: /fluentd/etc/..2019_10_22_01_09_22.899916051/fluent.conf: Read-only file system
chown: /fluentd/etc/..2019_10_22_01_09_22.899916051: Read-only file system
chown: /fluentd/etc/..2019_10_22_01_09_22.899916051: Read-only file system
chown: /fluentd/etc/..data: Read-only file system
chown: /fluentd/etc/fluent.conf: Read-only file system
chown: /fluentd/etc: Read-only file system
chown: /fluentd/etc: Read-only file system
2019-10-22 01:26:01 +0000 [info]: parsing config file is succeeded path="/fluentd/etc/fluent.conf"
2019-10-22 01:26:02 +0000 [error]: config error file="/fluentd/etc/fluent.conf" error_class=Fluent::ConfigError error="hec_host (${monitoring_machine}) and/or hec_port (8088) are invalid."
Successfully assigned splunk/splunk-k8s-splunk-kubernetes-logging-w7jb2 to minikube
default-scheduler
1
Pulling image "splunk/fluentd-hec:1.1.1"
kubelet minikube
spec.containers{splunk-fluentd-k8s-logs}
5
Successfully pulled image "splunk/fluentd-hec:1.1.1"
kubelet minikube
spec.containers{splunk-fluentd-k8s-logs}
4
Created container splunk-fluentd-k8s-logs
kubelet minikube
spec.containers{splunk-fluentd-k8s-logs}
4
Started container splunk-fluentd-k8s-logs
kubelet minikube
spec.containers{splunk-fluentd-k8s-logs}
4
warning
Back-off restarting failed container
kubelet minikube
spec.containers{splunk-fluentd-k8s-logs}
72

Hey @modevops!
Looks like the fluentd.conf is rendering something it doesn't like..We dump the rendered config to the pod logs, so lets check kubectl -n <yourNamespace> logs <yourPod>. if you can share the config in the logs i can likely pick out the issue.

Here is what I see in the logs
splunk-k8s-splunk-kubernetes-metrics-agg-5b68fb879f-27577
splunk-k8s-splunk-kubernetes-metrics-cb4c9
[splunk-k8s-splunk-kubernetes-metrics-cb4c9] chown: /fluentd/etc/splunk/..data: Read-only file system
[splunk-k8s-splunk-kubernetes-metrics-cb4c9] chown: /fluentd/etc/splunk/splunk_hec_token: Read-only file system
[splunk-k8s-splunk-kubernetes-metrics-cb4c9] chown: /fluentd/etc/splunk/..2019_10_25_00_02_47.059959492/splunk_hec_token: Read-only file system
[splunk-k8s-splunk-kubernetes-metrics-cb4c9] chown: /fluentd/etc/splunk/..2019_10_25_00_02_47.059959492: Read-only file system
[splunk-k8s-splunk-kubernetes-metrics-cb4c9] chown: /fluentd/etc/splunk/..2019_10_25_00_02_47.059959492: Read-only file system
[splunk-k8s-splunk-kubernetes-metrics-agg-5b68fb879f-27577] chown: /fluentd/etc/splunk/..data: Read-only file system
[splunk-k8s-splunk-kubernetes-metrics-cb4c9] chown: /fluentd/etc/splunk: Read-only file system
[splunk-k8s-splunk-kubernetes-metrics-agg-5b68fb879f-27577] chown: /fluentd/etc/splunk/splunk_hec_token: Read-only file system
[splunk-k8s-splunk-kubernetes-metrics-cb4c9] chown: /fluentd/etc/splunk: Read-only file system
[splunk-k8s-splunk-kubernetes-metrics-agg-5b68fb879f-27577] chown: /fluentd/etc/splunk/..2019_10_25_00_02_47.306302291/splunk_hec_token: Read-only file system
[splunk-k8s-splunk-kubernetes-metrics-cb4c9] chown: /fluentd/etc/..data: Read-only file system
[splunk-k8s-splunk-kubernetes-metrics-agg-5b68fb879f-27577] chown: /fluentd/etc/splunk/..2019_10_25_00_02_47.306302291: Read-only file system
[splunk-k8s-splunk-kubernetes-metrics-cb4c9] chown: /fluentd/etc/..2019_10_25_00_02_47.230980271/fluent.conf: Read-only file system
[splunk-k8s-splunk-kubernetes-metrics-agg-5b68fb879f-27577] chown: /fluentd/etc/splunk/..2019_10_25_00_02_47.306302291: Read-only file system
[splunk-k8s-splunk-kubernetes-metrics-cb4c9] chown: /fluentd/etc/..2019_10_25_00_02_47.230980271: Read-only file system
[splunk-k8s-splunk-kubernetes-metrics-agg-5b68fb879f-27577] chown: /fluentd/etc/splunk: Read-only file system
[splunk-k8s-splunk-kubernetes-metrics-cb4c9] chown: /fluentd/etc/..2019_10_25_00_02_47.230980271: Read-only file system
[splunk-k8s-splunk-kubernetes-metrics-agg-5b68fb879f-27577] chown: /fluentd/etc/splunk: Read-only file system
[splunk-k8s-splunk-kubernetes-metrics-cb4c9] chown: /fluentd/etc/fluent.conf: Read-only file system
[splunk-k8s-splunk-kubernetes-metrics-cb4c9] chown: /fluentd/etc: Read-only file system
[splunk-k8s-splunk-kubernetes-metrics-agg-5b68fb879f-27577] chown: /fluentd/etc/..data: Read-only file system
[splunk-k8s-splunk-kubernetes-metrics-cb4c9] chown: /fluentd/etc: Read-only file system
[splunk-k8s-splunk-kubernetes-metrics-agg-5b68fb879f-27577] chown: /fluentd/etc/fluent.conf: Read-only file system
[splunk-k8s-splunk-kubernetes-metrics-agg-5b68fb879f-27577] chown: /fluentd/etc/..2019_10_25_00_02_47.168839470/fluent.conf: Read-only file system
[splunk-k8s-splunk-kubernetes-metrics-agg-5b68fb879f-27577] chown: /fluentd/etc/..2019_10_25_00_02_47.168839470: Read-only file system
[splunk-k8s-splunk-kubernetes-metrics-agg-5b68fb879f-27577] chown: /fluentd/etc/..2019_10_25_00_02_47.168839470: Read-only file system
[splunk-k8s-splunk-kubernetes-metrics-agg-5b68fb879f-27577] chown: /fluentd/etc: Read-only file system
[splunk-k8s-splunk-kubernetes-metrics-agg-5b68fb879f-27577] chown: /fluentd/etc: Read-only file system
[splunk-k8s-splunk-kubernetes-metrics-agg-5b68fb879f-27577] 2019-10-25 00:03:40 +0000 [info]: parsing config file is succeeded path="/fluentd/etc/fluent.conf"
[splunk-k8s-splunk-kubernetes-metrics-agg-5b68fb879f-27577] 2019-10-25 00:03:41 +0000 [error]: config error file="/fluentd/etc/fluent.conf" error_class=Fluent::ConfigError error="hec_host (${monitoring_machine}) and/or hec_port (8088) are invalid."
[splunk-k8s-splunk-kubernetes-metrics-cb4c9] 2019-10-25 00:03:45 +0000 [info]: parsing config file is succeeded path="/fluentd/etc/fluent.conf"
[splunk-k8s-splunk-kubernetes-metrics-cb4c9] 2019-10-25 00:03:46 +0000 [error]: config error file="/fluentd/etc/fluent.conf" error_class=Fluent::ConfigError error="hec_host (${monitoring_machine}) and/or hec_port (8088) are invalid."

what is it that you have defined here:
export MONITORING_MACHINE=https://<IP_ADDRESS>:8443
and what is this lower case variable
${monitoring_machine} ?

that is the minikube ip
kubectl cluster-info
Kubernetes master is running at https://<IP_ADDRESS>:8443

you should put Splunk pod's IP address for hec_host.

and as far as i know, variables are case sensitive in bash. so MONITORING_MACHINE is not equal to monitoring_machine.

when i fill out the config in infrastructure app  this the command it gives me export MONITORING_MACHINE=https://<IP_ADDRESS>:8443 && export HEC_TOKEN=xxxxxxxxxxxxxxxx && export HEC_PORT=8088 && export GLOBAL_HEC_INSECURE_SSL=true && export OBJECTS_INSECURE_SSL=true && export METRICS_INSECURE_SSL=true && export JOURNALD_PATH=/run/log/journal && export KUBELET_PROTOCOL=https && export METRICS_INDEX=k8_metrics && export LOG_INDEX=k8_events && export META_INDEX=k8_objects && export CLUSTER_NAME=mini-splunk && export HELM_RELEASE_NAME=splunk-k8s && export KUBERNETES_NAMESPACE=splunk && export CORE_OBJ=pods,nodes && export APPS_OBJ= && files=("kubernetes_connect_template.yaml" "deploy_sck_k8s.sh") && for each in "${files[@]}"; do wget -O- --no-check-certificate http://<IP_ADDRESS>:31800/en-US/static/app/splunk_app_infrastructure/kubernetes_connect/"$each" > $each; done && wget https://github.com/splunk/splunk-connect-for-kubernetes/releases/download/1.2.0/splunk-connect-for-kubernetes-1.2.0.tgz -O splunk-connect-for-kubernetes.tgz && bash deploy_sck_k8s.sh

i would have to connect you to infrastructure app team.

I can assist. Monitoring Machine is the host or Virtual IP that is serving HEC.
Minikube can be a challenge due to k8s running in a VM and I dont believe SAI supports or was designed for this usecase.
That being said, what I would recommend is trying to deploy directly with HELM.
I have run it successfully in the past with a few modifications.
If you are looking for less headache, i recommend gke as they provide $300 in free credits you can use to deploy to a more realistic enviro

so you launched splunk in kubernetes. can you access it UI?
which ip address do you browse to access its web UI?
did you also create a kuberentes service resource to send traffic to that splunk pod ?
if then you should use that service's cluster IP (or Load Balance IP) as a hec host.
because that is the address kubernetes pods can access.

i have deployed splunk on my local (not in docker container) and started minikube. for minikube to access its host server, i need to use <IP_ADDRESS> by default. and it works fine.
export MONITORING_MACHINE=<IP_ADDRESS> && export HEC_TOKEN=XXXXXXXXX && export HEC_PORT=8088 && export GLOBAL_HEC_INSECURE_SSL=true && export OBJECTS_INSECURE_SSL=true && export METRICS_INSECURE_SSL=true && export JOURNALD_PATH=/run/log/journal && export KUBELET_PROTOCOL=https && export METRICS_INDEX=em_metrics && export LOG_INDEX=main && export META_INDEX=em_meta && export CLUSTER_NAME=sai && export HELM_RELEASE_NAME=sai && export KUBERNETES_NAMESPACE=sai && export CORE_OBJ=pods,nodes,component_statuses,config_maps,namespaces,persistent_volumes,persistent_volume_claims,resource_quotas,services,service_accounts,events && export APPS_OBJ=daemon_sets,deployments,replica_sets,stateful_sets && files=("kubernetes_connect_template.yaml" "deploy_sck_k8s.sh") && for each in "${files[@]}"; do wget -O- --no-check-certificate http://localhost:8000/en-US/static/app/splunk_app_infrastructure/kubernetes_connect/"$each" > $each; done && wget https://github.com/splunk/splunk-connect-for-kubernetes/releases/download/1.2.0/splunk-connect-for-kubernetes-1.2.0.tgz -O splunk-connect-for-kubernetes.tgz && bash deploy_sck_k8s.sh

Yes, this is what I did as well, as your local machine will talk to k8s via the VM ip and node ports, iirc

Closing due to inactivity.


using jpeg instead of raw

Can you please explain why can't we use jpg instead of raw ?

You have to consider the fact that a jpg is a 3 channel image, and the ARW file format is converted into a 4 channel input. If you want to use jpg, then you first need to change the structure of input layer.

Does it has anything to do with RAW vanilla data and jpeg compression ?

ARW files have a Bayer sensor and has a format called RGGB / RGBG.
If you take a look at their implementation they stack 4 channels before inputting it to the model, and this is because the sensor creates twice as many green pixels as red and blue (RGBG <- two Gs).
JPEG is a RGB format, hence it has an equal amount of red, green and blue pixels, and is therefore considered to be 3 channels. You can indeed use RGB formatted images, but you have to change the architecture of the network.
I hope this answers your question

Thank you very much for explaining :)

You have to consider the fact that a jpg is a 3 channel image, and the ARW file format is converted into a 4 channel input. If you want to use jpg, then you first need to change the structure of input layer.

@Groenbech96 Hi, do you know for using jpg picture, what is the specific approaches to change the structure of input layer?


Classify genotypes plates 3 3p

In this pr, two logistic regression models are trained on both the shuffled and unshuffled plate (3 and 3 prime) combined data to classify nf1 genotypes. Please let me know if you have any questions or suggestions.

Thanks Mike, merging now!


Add German accent

About the PR
This adds a German accent.
It does not add the lederhosen to go along with it, as I am too lazy to sprite that right now.
(I'll probably do it later though)
Why / Balance
Cause it's funny
Technical details
New accent
Media

[x] I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Breaking changes
no
Changelog

:cl:

add: You can now be German on ze space station! (added German accent)

Uhhh... works on my machine? (investigating this now)

Should be
sec -> Polizei
similar to the italian accent

a -> ein perhaps?

a -> ein perhaps?

since it depends on gender, better to not

Should be sec -> Polizei similar to the italian accent

Was brought up in Discord already and I feel like it'd be kinda meh:

woman/lady -> fräulein?
man -> mann?

woman/lady -> fräulein? man -> mann?

Also did the plurals and gentleman/gentlemen -> herr/herren

yes. please. also, idk if it's too much but it would be funny if worst became wurst

also, idk if it's too much but it would be funny if worst became wurst

Not sure if it'd be too much but it just feels kinda... nonsensical? Like, that's two completely different things that are just spelled similarly.
I also don't think an accent should auto-insert puns like that, especially on common words.
(+sausages already get turned into Wieners and Frankfurters)

Plans to make W -> V? Please?

Plans to make W -> V? Please?

Thought about it, but I don't think it'd read particularly well or German.
Germans don't pronounce "lower" like "lover" or "glow" like "glove".
Also things like "pavk" and "havk" just don't make sense.

This is honestly fine without the random ö/ü/ä shit. (e.g. Sud and Süd are two different things) I still don't like it, but meh. Whatever.

Works great. Found some minor code convention and IDE warning nitpicks

All taken care of.

@UbaserB Thanks for all the feedback, I would just like to get a clarification on a thing that kinda permeates a lot of these:
For many of them, I, as a German myself, cannot tell why they should be removed. You also keep calling them "translations".
In my understanding until now, accent word replacement aren't meant to be actual, accurate translations but rather replacements that add foreign flavour and some humor to an accent while still keeping it legible to English speakers.
So I was wondering: Is that not the case or is there some general philosophy to picking these that I am unaware of?
I'm willing to (in some places begrudgingly) make these changes, I'd just like to understand what is wrong with the current words so that I can avoid those mistakes in the future.

@UbaserB Thanks for all the feedback, I would just like to get a clarification on a thing that kinda permeates a lot of these: For many of them, I, as a German myself, cannot tell why they should be removed. You also keep calling them "translations".
In my understanding until now, accent word replacement aren't meant to be actual, accurate translations but rather replacements that add foreign flavour and some humor to an accent while still keeping it legible to English speakers. So I was wondering: Is that not the case or is there some general philosophy to picking these that I am unaware of?
I'm willing to (in some places begrudgingly) make these changes, I'd just like to understand what is wrong with the current words so that I can avoid those mistakes in the future.

From what I understand of the discussions thus far in the maintainer team, there is preference of realism over humor. Keeping it "understandable" is an important aspect for sure, but it is preferred for the translations to be commonly-used words (or accurate).

The remaining comments have been discussed on Discord at https://discord.com/channels/310555209753690112/1272915820233625672 and the relevant changes have been made.

Plans to make W -> V? Please?

I had already thought about it, but I don't think it reads particularly well or German. Germans don't pronounce "lower" like "lover" or "glow" like "glove". Also things like "pavn" and "havk" just don't work.

Just make it for the beginning of vords and then for things like "one" turn it into "vun"

Plans to make W -> V? Please?

I had already thought about it, but I don't think it reads particularly well or German. Germans don't pronounce "lower" like "lover" or "glow" like "glove". Also things like "pavn" and "havk" just don't work.

Just make it for the beginning of vords and then for things like "one" turn it into "vun"

This doesn't really make any sense.

Also, the W -> V thing would need to happen at the same time as the word replacements since otherwise, either "warning" -> "warnung" breaks or we'd get "sausage" -> "vurst".
So it requires extending replacement accents with regex support or similar which is not a thing I am interested in lumping in with this PR.
That can happen later if someone wants to do it.

Also, @slarticodefast, Github is telling me there is still an outstanding requested change from you on this, but on my end it looks like all the requested changes are marked as resolved.
Is there something I'm missing or do you just need to mark them as resolved on your end or so?

Github is telling me there is still an outstanding requested change from you on this, but on my end it looks like all the requested changes are marked as resolved.
Is there something I'm missing or do you just need to mark them as resolved on your end or so?

That was just a reminder for myself to give it one last test with the new changes before merging. There were no new complaints from anyone, so I will merge it in a moment if everythign works.


Mistake in build

Env:

cargo 1.35.0-nightly (0e35bd8af 2019-03-13)
rustc 1.35.0-nightly (719b0d984 2019-03-13)

Error Log:
Some errors occurred: E0432, E0658.

Our current code is not yet compatible with the new features api. I am working to address this issue at the moment.


Detect authors

Onefetch can now detect first three authors of a project by assuming the project is a git repository.
It counts the first three top commiters and puts them as an authors of the project.
This started as a work on #9 but since then @JoshBrudnak took and interest in working on that issue,
so I am contributing this as only a partial imlementation of full project info logic and maybe he can base his work on this :).

The output now looks something like this:

Well done @zxey, there is only three infos left to be implemented: Project name, repo and license.
@JoshBrudnak good luck !


Ability to filter the feed

It would be good to have a way to only send some feed items to slack.
For example, only feed items related to a particular project, or only send Diffusion Commits, etc..

Hi. I've made some progress towards this. So far I've been routing Diffusion Commits to specific Slack rooms. Checkout the go branch if you would like to try it out. I don't have any docs yet though :sweat_smile:

This is now supported for Commits, Revisions, and Tasks. Checkout the README.md on how to set it up. :)


Use master branch client-go

Couple of nice cleanups and more versioned types used.

Coverage remained the same at 0.0% when pulling 59d01e6315c895d0cb4da7a67cc3ca8ef0c68d56 on client-go-master into a4b447dcfbcdb273a88bee21cba24b2ef5731fd2 on master.


C4244 warnings when building in Visual Studio

Hello,
I'm building the lib in Visual Studio with /W4 switch. I'm getting the warnings below. I understand that in your code you do have checks for data loss during those conversions; however, I have to have code building clean in my environment. I can put together a change to disable the warning in those specific places. Please let me know if that's OK.
X64:
cborparser.c(802): warning C4244: '=': conversion from 'uint64_t' to 'int', possible loss of data
cborparser.c(808): warning C4244: '=': conversion from 'uint64_t' to 'int', possible loss of data
X86:
cbor.h(166): warning C4201: nonstandard extension used: nameless struct/union
cbor.h(364): warning C4244: '=': conversion from 'uint64_t' to 'std::size_t', possible loss of data
cbor.h(419): warning C4244: '=': conversion from 'uint64_t' to 'std::size_t', possible loss of data
cbor.h(431): warning C4244: '=': conversion from 'uint64_t' to 'std::size_t', possible loss of data

The non-standard extension is fixed by 4628a110b736c3c31bd8c577ea1d29400e0c0a53 (which got into the dev branch as ede7f1431ae06c9086f2a83a57bd7832d99280e3). The other issues are easily solved with an explicit cast.

Can you check if 806f0c9 (from https://github.com/thiagomacieira/tinycbor) solves the issue?

Yes, that change fixes the the warnings above. Thanks! However, I didn't paste one more from last time (sorry).
compilersupport_p.h(213): warning C4244: 'return': conversion from 'int' to 'unsigned short', possible loss of data

Were there no warnings on lines 190-192 of compilersupport_p.h? That assigns from an uint64_t to int, though the integer operations on the RHS clearly limit the width.

Hmm... they don't. It looks like only single bit shifts trigger the warning, but not when you have two of them chained. I've reduced the problem to the code below. I will check with our compiler team as to why there is a difference. Will get back to you.
#include <stdio.h>
#include <stdint.h>
int main()
{
uint64_t v = 123;
int i = v;
int j = v >> 1;
int k = v << 1;
int m = v >> 63 << 15;
wprintf(L"i = %d, j = %d, k = %d, m = %d\n", i, j, k, m);
return 0;
}
main.cpp(7): warning C4244: 'initializing': conversion from 'uint64_t' to 'int', possible loss of data
main.cpp(8): warning C4244: 'initializing': conversion from 'uint64_t' to 'int', possible loss of data
main.cpp(9): warning C4244: 'initializing': conversion from 'uint64_t' to 'int', possible loss of data

I'll apply this patch as it is for now. If the compiler changes and produces new warnings, we'll fix them then.

By the way, the 806f0c9 (from https://github.com/thiagomacieira/tinycbor) only addressed warnings in cbor.h. There are still warning on these lines (omitting the compilersuport_p.h since it is tracked by different issue now):
cborencoder.c(301) : warning C4244: '=': conversion from 'unsigned int' to 'uint8_t', possible loss of data
cborparser.c(158) : warning C4244: '=': conversion from 'uint64_t' to '::size_t', possible loss of data
cborparser.c(802) : warning C4244: '=': conversion from 'uint64_t' to 'int', possible loss of data
cborparser.c(808) : warning C4244: '=': conversion from 'uint64_t' to 'int', possible loss of data
The second warning only shows up on x86 build of course.

Can you give me an exhaustive list? I'm away from my Windows environment so I can't get them for myself.

The above is the exhaustive list, minus the issue in compilersupport_p.h. I can put together a pull request with the changes that I've done to get myself unblocked at the meantime. Right now that change is in my local branch.

Please send the PR. That will help to make sure we've caught them all.

Sent a PR #48


Synthesis ignores silences in beginning and in ending

I use state aligned labels created with the merlin tool.
When synthesising, the wav output ignores the silences in the beginning and in the end of the label, even if there are more than one silence. The enforce silence parameter in set to "True".
What could cause this kind of problem?

Thank you for pointing out.
We're overwriting the files at the synthesis time and hence caused this bug. The bug has been fixed now in the latest commit by adding a new extension to the binary labels.

Unfortunately, this commit doesn't help resolve the issue - it still happens in the latest version...
When we used phone-aligned labels this problem didn't happen - There was a silence at the beginning and the end of the wave file.
What else could possibly cause this problem?


docs.webmr.io improvements

There's some delicious low-hanging fruit in our docs site 🍒. Although there is a good framework, we could both clean up and expand the site for commonly asked pointers.
We currently use docsify as a Github page for the docs, but that's amenable to change. Whatever we use should be automatic and 🤖.
Frequently asked docs

Can I see some screenshots and videos?
Which sites can I open right now?
How do I run multiplayer?
How do I plug in to my node.js app?
Does it work with electron?
Why doesn't https://youtube.com/ open?
What is the "why" of the project?
I have bug X.
How do I run it in Magic Leap?
How do I run it with Leap Motion?
When is 1.0?

Chores

Remove the huge cover page?
<title/> tag?
<meta/> tags?

How to fix these
Submit a PR to webmixedreality/webmr-docs 🥇

Is this now solved with the new website?

It's an ongoing process. But yeah, many of these points are no longer really relevant/have better avenues to address them, like video tutorials.


[BUG] - ByronShelley chairman test failure "Chain extended, new tip" not found

Internal
Summary
The ByronShelley chairman test expects that the words "Chain extended, new tip" not found appears in the log file of each running node.
This expectation is not met.
Steps to reproduce
Steps to reproduce the behavior:
$ cabal build all --enable-tests
$ (set -e; for x in {1..100}; do echo "=== $x ==="; KEEP_WORKSPACE=1 DISABLE_CHAIRMAN=1 cabal test cardano-node-chairman --test-show-details=direct --test-options=--pattern=Chairman.ByronShelley.chairman; done)

Expected behavior
Every test should pass.  Instead one of the tests fail with "Chain extended, new tip" not found in one of the logs.  In my run, it failed on the 148th run.
Screenshots and attachments
See next comment.


Use Interpolated Value in Grid Query

I'm adding a query attribute to my formio directive like so:
query="{'data.companyActivation': 'abcd' }"

That works perfectly, but as soon as I change it to:
query="{'data.companyActivation': '{{companyActivation}}' }"

It no longer works even though the value is interpolated correctly and the html is rendered with the correct value on the page. It seems like the directive is loading with the raw value before angular has time to interpolate it because the network request contains {{companyActivation}} in the query instead of 'abcd'.
Is it possible to use an interpolated value in the grid query?

Removing the curly braces makes it work.
query="{'data.companyActivation': 'companyActivation' }"