[Action Required] Ensure 2.11 branch readiness for 2.11.1 release

Coming from https://github.com/opensearch-project/opensearch-build/issues/4161
What is happening?
We are planning 2.11.1 release in upcoming few weeks. Following the semver guildelines and branching strategy, this release will be based on 2.11 as a reference branch
Why?

We need this release because of a critical breaking bug in the security plug-in. This bug impacts everyone using logstash and the only work around is to turn off compression (which is expensive)

As a refresher, our normal process is to commit changes to main, then backport to 2.x. Since the 1.0 release, we only backport bug fixes and security changes to the current 2.x branch (in this case 2.11) so that if we need to we can quickly do a patch release.

There are two reason we don’t back port features to the current release branch (right now 2.11):

Because we want patch release to be as thin as possible, and the more changes you make, the more verification we need to do
Adding features in a patch breaks semver.

However, looking at the list of changes for 2.11, we currently have a mix of features that have been merged in. After providing several options and discussing with all the component teams as well as community we came to the conclusion of reverting all feature related changes from 2.11 branch.
What do I need to do?
Please help revert all the commits that are related to new features or enhancements from 2.11 branch that were added after 2.11.0 release.
Here is a rough list of commits that went in after 2.11.0 release for each repo.
Status
Please check-mark one of the below and close this issue once the action item is completed.

[ ] We confirm that no features or enhancements were added to 2.11 branch. We are good to go for 2.11.1 consisting only of bug fixes and security fixes.

OR

[ ] We have reverted all the feature or ehancement related commits from 2.11 branch. We are good to go for 2.11.1 consisting only of bug fixes and security fixes.

Thank you!
cc: @bbarani @CEHENKLE @Divyaasm

[Triage] This issue is for the 2.11.1 release. We will want to make sure we don't have any unintended changes etc.

closing this on behalf of the merge of #3661

👎  This pull request [1] doesn't make sense to me .  Reverting missing license headers and improvements to CI should be valid our teams standards for patch releases.  They aren't part of the semver conversation - this is throwing the baby out with the bathwater.

[1] https://github.com/opensearch-project/security/pull/3661


KAFKA-4011 - fix issues and beef up tests around ByteBoundedBlockingQueue

as discussed under KIP-72

@becketqin Are you happy with this now or should someone else take a pass at review?

@ewencp This PR is actually for KIP-72, which has been changed quite a bit since its initial proposal. So this PR seems not applicable any more. @radai-rosenblatt Could you close the PR and link the KIP to the right PR?

this patch contains fixes to ByteBoundedBlockingQueue. KIP-72 no longer intends to use this class and, given nothing else uses it either, it should probably be deleted.


Build Fails for ember#beta

Any thoughts on ignoring ember#beta for our travis build?

It looks like addon components are not properly added to the registry. A helper named 'virtual-each' could not be found in the integration tests

So ember cut a new release yesterday which means new features were turned on in the beta. I think it might have something to do with the new contextual components? http://emberjs.com/blog/2015/11/16/ember-2-2-released.html#toc_contextual-components

Any thoughts on ignoring ember#beta for our travis build?

Remove https://github.com/jasonmit/virtual-each/blob/master/.travis.yml#L15

Looks like I just had to bump ember-mocha


Generate a debug APK build using GitHub actions

As a user, I want to generate a debug APK using GitHub actions so that I can have the build ready for install
Acceptance Criteria

I have a Yaml workflow to build and create an APK
I have an APK debug build generated

References
https://github.com/marketplace/actions/build-and-release-debug-apk

Artifact alpha-0.1 generated : https://github.com/josdem/fruitypedia/actions/runs/6985067347


Recurring maintenance

I would be very very cool if you can have recurring maintenance, like every first Tuesday of the month or something like that ! :)

I've never thought about this feature! We'll address it in V2 :)

:+1: Would love to see this as well !

+1

+1

I did a quick mock-up of how I thought adding recurring maintenances could work within the dashboard.

I figure we may need additional options under the 'When to repeat [...]' question to cover all requirements.
Thoughts?

@DivineOmega I like it! My one thought about it is that we should probably implement it within the existing Scheduled Maintenance form as it'd be essentially the same stuff happening anyway.

^ agreed.

Team did this feature ever made it to v2, we also have a requirement to schedule maintenance for multiple days. Currently implementation I believe is limited to 1 day. Thank you for everything.

+1

Merged into https://github.com/CachetHQ/Cachet/issues/1176

+1 to this. Several of our teams have standard maintenance windows that would be great to configure. Should be similar to creating a Recurring event in Google Calendar, ideally.


Display of Blog posts in editorial system

Describe the Bug
In our Website CMS there is a checkbox in our blog section to select where the blog post should be visible. One possible checkbox to select is "Redaktionssystem". However at the moment all blog posts are shown in the CMS and not only those that were selected for "Redaktionssystem".
User Story: As person in our marketing I want to hand-select which posts are shown in the CMS and which aren't.
Steps to Reproduce

Go to Wordpress to posts and select one. See the checkbox "Redaktionssystem" is not selected
' open the dashboard of a region and see in Integreat News that the article is shown

Expected Behavior

Only posts selected via the checkbox "Redaktionssystem" (tag_id = 17) are shown in our CMS.
Actual Behavior

All posts are shown in the CMS.
Additional Information

Traceback

I think we should not implement it like that. We should simply show a selected category from the WordPress.


Add option to instantiate MolFileReader with mol str

Added a convenience function:

Added the option to instantiate MolFileReader with the String content of a molfile instead of the path of the molfile
Everything else should behave the same way, the constructor of MolFileReader now simply also accepts and processes the argument molfile_str if the normal "molfile" argument is not given
Added unit tests for the things I have touched to make sure it behaves the way it is supposed to behave

Great, thank you!


Getting .Values.airflow.service.type nil pointer evaluating interface {}.type

I am trying to follow your example Example: KubernetesExecutor with git-sync in ReadWriteMany mode
I am using EKS and when I am trying to run

helm upgrade --install airflow airflow/ --namespace airflow --values examples/kube/git-sync-readwritemany/values.yaml

I am getting this error:

flow/ --namespace airflow --values examples/kube/git-sync-readwritemany/values.yaml
Release "airflow" does not exist. Installing it now.
Error: render error in "airflow/templates/services.yaml": template: airflow/templates/services.yaml:11:18: executing "airflow/templates/services.yaml" at <.Values.airflow.service.type>: nil pointer evaluating interface {}.type

Did you change the project structure? For me the airflow directory had to be at the first level.

No, I have not changed anything


Support opening files in-place

This change provides a mechanism to pass the asCopy parameter to the underlying UIDocumentPickerViewController to allow opening files in-place, required for opening folders (UTType.folder).

can we please get this merged?


[SPARK-47965][SQL][FOLLOW-UP] Uses null as its default value for OptionalConfigEntry

What changes were proposed in this pull request?
This PR partially reverts https://github.com/apache/spark/pull/46197 because of the behaviour change below:
>>> spark.conf.get("spark.sql.optimizer.excludedRules")
'<undefined>'

Why are the changes needed?
To avoid behaviour change.
Does this PR introduce any user-facing change?
No, the main change has not been released out yet.
How was this patch tested?
Manually as described above.
Was this patch authored or co-authored using generative AI tooling?
No.

I am going to merge this - it's a clean revert.
Merged to master.


File upload gets stuck on empty file.

Describe the bug
Uploading an empty file causes the progress bar to cycle forever. "Uploading 0% of 0 Bytes"
To Reproduce
Upload an empty file. Like test.txt with no contents.
Expected behavior
The empty file should upload.
Environment (please complete the following information):

FileGator online demo

Thanks for reporting this bug


feat: correlated variables

This PR implements the capability to correlate variables.
This works with arbitrary distributions (continuous or discrete) as long as the samples generated out of them produce enough unique numbers for a reshuffling of samples to be able to change the rank correlation. The implementation works on a best-effort basis, but is generally robust, and double checks that the samples produced are correlated as expected, explicitly failing if not.
How does this work?
This implementation relies on the Iman-Conover method, which induces a rank correlation directly on the samples, by reordering samples, so the resulting joint distribution matches a correlated reference distribution (in our case, a multivariate normal distribution).
To make this seamless, whenever a user samples one of the variables in a group of correlated variables, we sample all the variables in the group immediately and then transform the samples with the IC method. The leftover samples we didn't need get stored in their corresponding variables (through the _correlated_samples attribute).
Whenever those other variables get sampled, the samples get fetched directly from _correlated_samples, instead of sampling every variable again, and then _correlated_samples gets cleared (to allow resampling in the future).
Because this method relies on reordering existing samples, its biggest flaw is that it doesn't work when there are too many repeated samples, as reordering them won't change the rank correlation. This is often the case with discrete distributions, as it's common to only have a few unique values.
To handle this case, the method checks beforehand that the samples have the right properties to induce the correlation, and otherwise raises an exception to the user. I considered adding noise to samples to circumvent this problem, but with many discrete distributions this could affect the entire logic of a model, so for now I've decided to just acknowledge the limitation.
Testing
To test this exhaustively, I implemented automated property-based testing with Hypothesis, which helped me debug and refine several of the kinks and numerical instabilities with the implementation.
Right now, we have full coverage across all distributions and their defined parameter domains (ignoring cases where there isn't enough sample diversity), which means Hypothesis went through and tried as hard as it can to produce examples of distributions that couldn't be correlated, without success.
One thing I haven't tested extensively yet are composite distributions. I can add this through Hypothesis with a recursive strategy, but this might be overkill for now.
Next steps
This method could be improved. Using copula-based methods would mean no longer having to worry about sampling simultaneously and, most importantly, no limitations on how many unique values to have. I think this could be computationally more inefficient and more complicated to implement, but we could at least test it and see how it compares.
Other things
At some point I needed to add a check for continuous distributions (which is no longer necessary), so I refactored the class tree as to have ContinuousDistribution and DiscreteDistributions[^1] be base classes (under BaseDistribution).
Also, thanks to Hypothesis, I found bugs with how some distributions validated their parameters, some of which I've fixed here (see #46 for more).
[^1]: I renamed the old DiscreteDistribution to CategoricalDistribution, which I also believe is a clearer name. The discrete function remains.

This looks awesome! Is there an expected timeline for when this will get merged?

This looks awesome! Is there an expected timeline for when this will get merged?

I never saw this, sorry! Must have got lost among the GH notifications.
There's no reason we cannot merge now, actually. I was waiting for further testing downstream, but this can be included in the next dev release


Chai v5.0.0

https://github.com/chaijs/chai/releases/tag/v5.0.0
Is chai-as-promised still needed? It hasn't been updated in 7 years..
https://www.npmjs.com/package/chai-as-promised?activeTab=versions

Dependabot found it https://github.com/Innablr/revolver/pull/83

And https://github.com/Innablr/revolver/pull/96

Is chai-as-promised still needed? It hasn't been updated in 7 years..

Without it Chai can not assert promises, which takes away a big chunk of its functionality. Chai-as-promised is pretty old, but there's no open CVEs against it, or other indication that it's insecure/obsolete.


Llama vision build fails

When building like this:
jetson-containers build llama-vision

-- L4T_VERSION=36.4.0
-- JETPACK_VERSION=6.1
-- CUDA_VERSION=12.6
-- PYTHON_VERSION=3.10
-- LSB_RELEASE=22.04 (jammy)

I get the following error at the last step of the build:
-- Building container llama-vision:r36.4.0-llama-vision

DOCKER_BUILDKIT=0 docker build --network=host --tag llama-vision:r36.4.0-llama-vision \
--file /home/jetson/code/Test/jetson-containers/packages/vlm/llama-vision/Dockerfile \
--build-arg BASE_IMAGE=llama-vision:r36.4.0-bitsandbytes \
/home/jetson/code/Test/jetson-containers/packages/vlm/llama-vision \
2>&1 | tee /home/jetson/code/Test/jetson-containers/logs/20241109_115523/build/llama-vision_r36.4.0-llama-vision.txt; exit ${PIPESTATUS[0]}

DEPRECATED: The legacy builder is deprecated and will be removed in a future release.
            BuildKit is currently disabled; enable it by removing the DOCKER_BUILDKIT=0
            environment-variable.

Sending build context to Docker daemon  11.26kB
Step 1/5 : ARG BASE_IMAGE
Step 2/5 : FROM ${BASE_IMAGE}
 ---> b4fefebbaacc
Step 3/5 : COPY *.whl /tmp/
COPY failed: no source files were specified
Traceback (most recent call last):
  File "/usr/lib/python3.10/runpy.py", line 196, in _run_module_as_main
    return _run_code(code, main_globals, None,
  File "/usr/lib/python3.10/runpy.py", line 86, in _run_code
    exec(code, run_globals)
  File "/home/jetson/code/Test/jetson-containers/jetson_containers/build.py", line 112, in <module>
    build_container(args.name, args.packages, args.base, args.build_flags, args.build_args, args.simulate, args.skip_tests, args.test_only, args.push, args.no_github_api, args.skip_packages)
  File "/home/jetson/code/Test/jetson-containers/jetson_containers/container.py", line 147, in build_container
    status = subprocess.run(cmd.replace(_NEWLINE_, ' '), executable='/bin/bash', shell=True, check=True)
  File "/usr/lib/python3.10/subprocess.py", line 526, in run
    raise CalledProcessError(retcode, process.args,
subprocess.CalledProcessError: Command 'DOCKER_BUILDKIT=0 docker build --network=host --tag llama-vision:r36.4.0-llama-vision --file /home/jetson/code/Test/jetson-containers/packages/vlm/llama-vision/Dockerfile --build-arg BASE_IMAGE=llama-vision:r36.4.0-bitsandbytes /home/jetson/code/Test/jetson-containers/packages/vlm/llama-vision 2>&1 | tee /home/jetson/code/Test/jetson-containers/logs/20241109_115523/build/llama-vision_r36.4.0-llama-vision.txt; exit ${PIPESTATUS[0]}' returned non-zero exit status 1.

I have pulled and installed the latest version of jetson containers repo.

And as a follow up question for @dusty-nv - is llama 3.2 90b supported yet through ollama?

@davidADSP that container was just for a special pre-release version of transformers before the model came out, hence it copied the wheel from my drive.  However now that is upstreamed into Transformers.  IIRC that container doesn't have llama.cpp or ollama, and you would need to check those projects if they support it or not.  And if it is supported, it depends on how memory efficient they are with loading the weights/ect if it will fit in AGX Orin 64GB or not (anecdotally I was able to run NVLM-72B on AGX Orin with load_in_4bit=True, but 90B is substantially larger)


Option for SEPA to add "Allow for all EU countries" members for the SEPA area?

Is is an idea to add an "Option for SEPA to add "Allow for all EU countries" members for the SEPA area?" (instead of all countries or manual)
https://en.wikipedia.org/wiki/Single_Euro_Payments_Area

Hi Sean,
This is not possible in Magento. What we can do is by default select the SEPA members that are using SEPA.
Regards,
Rik
Adyen

OK

<EMAIL_ADDRESS>| KvK 60827378 | http://shirtsofholland.com
[image: ShirtsofHolland - dé specialist in Oranje kleding]
http://shirtsofholland.com/
2015-07-03 15:10 GMT+02:00 Rik ter Beek<EMAIL_ADDRESS>
Hi Sean,
This is not possible in Magento. What we can do is by default select the
SEPA members that are using SEPA.
Regards,
Rik
Adyen
—
Reply to this email directly or view it on GitHub
https://github.com/Adyen/magento/issues/337#issuecomment-118345653.


html validation

Some articles lack headings. Consider using h2-h6 elements to [add identifying headings to all articles]
Element [figcaption]not allowed as child of element [article]

headings added and replaced figcaption


error code 400 could be different things

check out https://iexcloud.io/docs/api/#errors

Need to use the existing exceptions structure as opposed to a generic exception. Fits into #171.


how to set init solution before solve?

for the title..i want to know how to set one or more solution first before solve?
in the scipjnijni, just found SCIPsetSolVals(long jarg1, long jarg2, int jarg3, long jarg4, long jarg5) , does it?
but any examples? thanks a lot. :)

You need to have a look at JSCIPOpt/java/Scip.java. There you find some methods to create and add solutions to SCIP. Basically, you need to create a solution via solution = scip.createSol(), then set solution values via scip.setSolVal(...) or scip.setSolVals(), and finally add the solution to SCIP via scip.addSolFree().


Changes to the Plugins API

I realize this is a breaking change, so it probably won't be added until you decide it's time for the 1.0 release.
This suggestion builds upon my pull request (#29). As ES6 modules become more and more widespread, global variables are increasingly frowned upon. Citation.js relies on globals for registering plugins: require('@citation-js/plugin-bibtex')
I would suggest changing the API to use explicit plugin registering. For example:
import { Cite } from '@citation-js/core';
import bibtex from '@citation-js/plugin-bibtex';
import ris from '@citation-js/plugin-ris';

const cite = await Cite
  .use(bibtex)
  .use(ris)
  .async('Q21972834');

It would basically involve two steps:

Add a .use() method to Cite that calls plugins.add and then returns this.
Remove plugins.add from each plugin.

I would be willing to work on this, if you want. But first I have to make sure you even think it's a good idea.

It shouldn't use globals, but rather a shared instance of @citation-js/core, which usually works (although it has its limits).

Shared instance is kind-of globals, at least here. When you import a plugin it registers itself with @citation-js/core instead of the user registering it.
It also has the side effect of meaning that Core must expose the plugin API for plugins to use. That leads to tighter coupling between the core Citation.js and the plugins. With this, you would no longer need to expose the plugin API from Core for plugins to use. Plugins would just need to export ref, parsers, and format (which they already do).
Nonetheless, it's completely your call. If you think what you have now is how you want it to be, that's good enough for me. Do you want me to close this issue?

True. I'm probably going to leave this to 1.0 though, I want to finish up 0.4 at some point :slightly_smiling_face:.


feat: Verify the versions of the three files. Print current version if no args are given.

This PR adds the ability to print the current version when running tauri-version without arguments.
Changes:

Added version printing if CLI command is called without arguments
Added version consistency check across all config files
Added unit tests for version checking
Updated documentation in both README.md and README-zh.md

Looks like I need to do some refactoring on tauriVersion in src/index, to avoid duplicate IO.

Thanks!


Bootstrap app via component and remove ng modules

proof of concept PR, closing for now as we need root module for guessa parser to discover routes


C# Grpc.Tools: can't build when using xmlns import local namespace

What version of gRPC and what language are you using?
gRPC 1.19.0
What operating system (Linux, Windows,...) and version?
Windows 10 1809
What runtime / compiler are you using (e.g. python version or version of gcc)
Dotnet gRPC.Tools
What did you do?
In WPF project, using PackageReference manage package, add proto files, change .csproj files, anything is fine, until edit XAML, using xamlns import namespace, build failure.
What did you expect to see?
Project build succceed
What did you see instead?
Proto files were not compiled, resulting in project build failed.

Make sure you include information that can help us debug (full error message, exception listing, stack trace, logs).
Build Succeed
<UserControl x:Class="RealtimeImage.RealtimeImage"
             xmlns="http://schemas.microsoft.com/winfx/2006/xaml/presentation"
             xmlns:d="http://schemas.microsoft.com/expression/blend/2008"
             xmlns:x="http://schemas.microsoft.com/winfx/2006/xaml"
             xmlns:mc="http://schemas.openxmlformats.org/markup-compatibility/2006"
             xmlns:skia="clr-namespace:SkiaSharp.Views.WPF;assembly=SkiaSharp.Views.WPF"
             mc:Ignorable="d"
             d:DesignHeight="450"
             d:DesignWidth="800">
</UserControl>

Build Failed
<UserControl x:Class="RealtimeImage.RealtimeImage"
             xmlns="http://schemas.microsoft.com/winfx/2006/xaml/presentation"
             xmlns:d="http://schemas.microsoft.com/expression/blend/2008"
             xmlns:x="http://schemas.microsoft.com/winfx/2006/xaml"
             xmlns:mc="http://schemas.openxmlformats.org/markup-compatibility/2006"

             xmlns:converters="clr-namespace:RealtimeImage.Converters"

             xmlns:skia="clr-namespace:SkiaSharp.Views.WPF;assembly=SkiaSharp.Views.WPF"
             mc:Ignorable="d"
             d:DesignHeight="450"
             d:DesignWidth="800">
</UserControl>

Anything else we should know about your project / environment?
package management style: packagereference, but my project is wpf library.

I did not understand the issue. I am guessing more information is required here, but I'll leave it upto @jtattermusch .

I also don't quite understand the question. But based on the error messages it looks like this isn't really related to Grpc.Tools at all.

I also don't quite understand the question. But based on the error messages it looks like this isn't really related to Grpc.Tools at all.

maybe Grpc.Tools can't handle this scenario. I identified the problem by comment code line by line

I also don't quite understand the question. But based on the error messages it looks like this isn't really related to Grpc.Tools at all.

I create a project, maybe can help you locate the problem Project Link

I had the same problem with gRPC 1.21. Any news on this?

You're trying to use Grpc.Tools in a WPF project and I think this is a dupe of https://github.com/grpc/grpc/issues/20402.
The workaround instructions are here:
https://docs.microsoft.com/en-us/aspnet/core/grpc/troubleshoot?view=aspnetcore-3.0#wpf-projects-unable-to-generate-grpc-c-assets-from-proto-files


get_tag.py: Don't encode illegal docker tag when local building

I was getting an encoding of "heads/2023.04.19-dev-amd64" and it seems the slash is not allowed to be there.

Hi Darryl, thank you for your contribution- I'm more miffed as to why git rev-parse HEAD is returning an invalid branch name..? The mysteries of git.
I believe the solution would be to split by "/" and get the last element, not to attempt to escape "/" somehow.

Hi Darryl, thank you for your contribution- I'm more miffed as to why git rev-parse HEAD is returning an invalid branch name..? The mysteries of git.
I believe the solution would be to split by "/" and get the last element, not to attempt to escape "/" somehow.

You can also create a new branch that has / in it.


Create Blog “wrtserg”

Automatically generated by Netlify CMS

👷 Deploy Preview for capable-cassata-45e7fa processing.

Name
Link

🔨 Latest commit
b2bad9eb90f61f7ec60fb942dbc6b4b7c2b3a95e

🔍 Latest deploy log
https://app.netlify.com/sites/capable-cassata-45e7fa/deploys/67001cf402b9890008f95aff


Not validating for a certain format

Hi,
Have written a routine to validate 30k+ post codes, works fine apart from where the format is XX10 nXX, e.g BA10 0AA, DN10 4QH, RG10 0TT etc. Have looked them up on  the Royal Mail site and are all valid post codes. Seems to be a pattern with a 2 letter outcode with a 10 after.
Many thanks
Simon

hey @simondward1066
I think this PR is solving this issue

Hi,
Thank you for letting me know.
Simon
From: Guilherme Munarolo @.>
Sent: 23 June 2021 16:58
To: guimunarolo/postcode-validator-uk @.>
Cc: Simon Ward @.>; Mention @.>
Subject: Re: [guimunarolo/postcode-validator-uk] Not validating for a certain format (#11)
hey @simondward1066https://github.com/simondward1066
I think this PRhttps://github.com/guimunarolo/postcode-validator-uk/pull/10 is solving this issue
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/guimunarolo/postcode-validator-uk/issues/11#issuecomment-866963361, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AUS3T7NVU327YPLPEGFNQNLTUIABBANCNFSM47FWYSFA.


Invalid response callback on write command request (TZ-386)

Answers checklist.

[X] I have read the documentation ESP Zigbee SDK Programming Guide and the issue is not addressed there.
[X] I have updated my IDF branch (master or release) and ESP Zigbee libs (esp-zboss-lib and esp-zigbee-lib) to the latest version and checked that the issue is present there.
[X] I have searched the issue tracker for a similar issue and not found a similar issue.

IDF version.
v5.1.1-588-gc1c843f5e2
esp-zigbee-lib version.
1.0.2
esp-zboss-lib version.
1.0.2
Espressif SoC revision.
ESP32_-H6
What is the expected behavior?
the expected behavior is to work like the read callback, and return a list of attributes with the sames ids and length as the attribute list sent
What is the actual behavior?
after sending the write attribute command request (esp_zb_zcl_write_attr_cmd_req) with multiple or single attributes the ESP_ZB_CORE_CMD_WRITE_ATTR_RESP_CB_ID callback called with only 1 element in the attribute list, the status of the callback message is ESP_ZB_ZCL_STATUS_SUCCESS (message->info.status) also the only element of the array list posses the status in ESP_ZB_ZCL_STATUS_SUCCESS (message->variables->status) but the attribute id (message->variables->attribute_id)  is always 0xffff. so the bug is that the attribute list is always of single element and the attribute id is always 0xffff. on the other hand the receiver receives the writer command without problem.
this update was referred for #106 so the read callback works perfectly as mentioned by @xieqinan but the same logic was no apply in the write callback
Steps to reproduce.

Step
Step
Step
...

More Information.
No response

@diazmanuel ,
Regarding this issue, it's not a bug and has been illustrated in the comment.

hi @xieqinan
Sorry, I had misunderstood the comment. In any case, it is not possible to return the list of attributes written in that list when the writing is done successfully, as is done in the case of reading? I understand that this list is only returned in the cases in which there is an error, but I am using that same list to be able to match the message sent with its response, since there is no sequence number to be able to make the match, or if there is no way to identify who message corresponds to the callback, I am designing a gateway which receives high message traffic and I need to be able to identify its responses without errors

@diazmanuel ,

there is no sequence number to be able to make the match, or if there is no way to identify who message corresponds to the callback,

We have already taken it into consideration, and additional support for it will be added in subsequent versions.

hello @xieqinan, yes sure
void sendTest(){
    esp_zb_ieee_addr_t ieee_addr;
    ieee_addr[7]=0x60;
    ieee_addr[6]=0x55;
    ieee_addr[5]=0xf9;
    ieee_addr[4]=0xff;
    ieee_addr[3]=0xfe;
    ieee_addr[2]=0xf7;
    ieee_addr[1]=0x73;
    ieee_addr[0]=0x3a;
    uint16_t auxval=0;

    esp_zb_zcl_attribute_t attr_field[4];
    attr_field[0].id=16;
    attr_field[0].data.type=ESP_ZB_ZCL_ATTR_TYPE_S16;
    auxval=1;
    attr_field[0].data.value=malloc(sizeof(uint16_t));
    memcpy(attr_field[0].data.value,&auxval,sizeof(uint16_t));
    attr_field[0].data.size=1;

    attr_field[1].id=17;
    attr_field[1].data.type=ESP_ZB_ZCL_ATTR_TYPE_S16;
    auxval=15;
    attr_field[1].data.value=malloc(sizeof(uint16_t));
    memcpy(attr_field[1].data.value,&auxval,sizeof(uint16_t));
    attr_field[1].data.size=1;

    attr_field[2].id=18;
    attr_field[2].data.type=ESP_ZB_ZCL_ATTR_TYPE_S16;
    auxval=58;
    attr_field[2].data.value=malloc(sizeof(uint16_t));
    memcpy(attr_field[2].data.value,&auxval,sizeof(uint16_t));
    attr_field[2].data.size=1;
    zigbeeWriteAttrCmdReq(5,ieee_addr,1,0xFFE9,3,attr_field);
}

void zigbeeWriteAttrCmdReq(uint16_t rid,esp_zb_ieee_addr_t des_addr, uint8_t des_ep, uint16_t cluster_id,uint8_t attr_number,esp_zb_zcl_attribute_t *attr_field){
    struct queue_rid_manager_list_t element;
    esp_zb_zcl_write_attr_cmd_t res;

    element.next=NULL;
    element.rid=rid;
    element.rid_identify.id=ID_TASK_ZIGBEE_HANDLER_WRITE_ATTR_CMD_REQ;
    element.rid_identify.src_ep=des_ep;
    element.rid_identify.cluster_id=cluster_id;
    element.rid_identify.attr_num=attr_number;
    element.rid_identify.attr_id=malloc(sizeof(uint16_t)*attr_number);
    for(int i=0;i<attr_number;i++)element.rid_identify.attr_id[i]=attr_field[i].id;
    memcpy(element.rid_identify.src_addr,des_addr,sizeof(esp_zb_ieee_addr_t));
    addRidToList(element);

    res.address_mode=ESP_ZB_APS_ADDR_MODE_64_ENDP_PRESENT;
    res.clusterID=cluster_id;
    res.attr_number=attr_number;
    res.attr_field=attr_field;
    res.zcl_basic_cmd.dst_endpoint=des_ep;
    res.zcl_basic_cmd.src_endpoint=ZIGBEE_HUB_ENDPOINT;
    memcpy(res.zcl_basic_cmd.dst_addr_u.addr_long,des_addr,sizeof(esp_zb_ieee_addr_t));
    esp_zb_zcl_write_attr_cmd_req(&res);
    ESP_LOGI(TAG,"SENDING");
}

the read and write callbacks are the followings

static esp_err_t zb_read_attr_resp_handler(esp_zb_zcl_cmd_read_attr_resp_message_t *message){
    int32_t rid;
    struct rid_identify_t filter;
    esp_zb_zcl_read_attr_resp_variable_t *nav=message->variables;
    esp_zb_ieee_address_by_short(message->info.src_address.u.short_addr,filter.src_addr);
    filter.id=ID_TASK_ZIGBEE_HANDLER_READ_ATTR_CMD_REQ;
    filter.cluster_id=message->info.cluster;
    filter.src_ep=message->info.src_endpoint;
    filter.attr_num=0;
    filter.attr_id=malloc(sizeof(uint16_t));
    while(nav!=NULL){
        filter.attr_num++;
        filter.attr_id=realloc(filter.attr_id,(sizeof(uint16_t))*filter.attr_num);
        filter.attr_id[filter.attr_num-1]=nav->attribute.id;
        nav=nav->next;
    }
    rid=removeRidFromList(filter);
    free(filter.attr_id);
    if(rid>=0){
        sendReadCallbackToMainTask((int16_t)rid,message->info.status,message->variables);
    }
    return ESP_OK;

}
static esp_err_t zb_write_attr_resp_handler(esp_zb_zcl_cmd_write_attr_resp_message_t *message){
    ESP_LOGW(TAG,"WRITE CALLBACK");
    int32_t rid;
    struct rid_identify_t filter;
    esp_zb_zcl_write_attr_resp_variable_t *nav=message->variables;
    esp_zb_ieee_address_by_short(message->info.src_address.u.short_addr,filter.src_addr);
    filter.id=ID_TASK_ZIGBEE_HANDLER_WRITE_ATTR_CMD_REQ;
    filter.cluster_id=message->info.cluster;
    filter.src_ep=message->info.src_endpoint;
    filter.attr_num=0;
    filter.attr_id=malloc(sizeof(uint16_t));
    while(nav!=NULL){
        filter.attr_num++;
        filter.attr_id=realloc(filter.attr_id,(sizeof(uint16_t))*filter.attr_num);
        filter.attr_id[filter.attr_num-1]=nav->attribute_id;
        ESP_LOGE(TAG,"%d",filter.attr_id[filter.attr_num-1]);
        ESP_LOGE(TAG,"STATUS %d %d",nav->status,message->info.status);
        nav=nav->next;
    }
    rid=removeRidFromList(filter);
    free(filter.attr_id);
    if(rid>=0){
        sendWriteCallbackToMainTask((int16_t)rid,message->info.status);
    }else{
        ESP_LOGI(TAG,"RID INVALIDO");
    }
    return ESP_OK;

}
static esp_err_t zb_action_handler(esp_zb_core_action_callback_id_t callback_id, const void *message)
{
    esp_err_t ret = ESP_OK;
    switch (callback_id) {
    case ESP_ZB_CORE_CMD_WRITE_ATTR_RESP_CB_ID:
        ret = zb_write_attr_resp_handler((esp_zb_zcl_cmd_write_attr_resp_message_t *)message);
        break;
    case ESP_ZB_CORE_CMD_READ_ATTR_RESP_CB_ID:
        ret = zb_read_attr_resp_handler((esp_zb_zcl_cmd_read_attr_resp_message_t*)message);
        break;
    default:
        ESP_LOGW(TAG, "Receive Zigbee action(0x%x) callback", callback_id);
        break;
    }
    return ret;
}

the var filter.attr_num contain the number of elements of the list (iam sure the logic is correct because i use the same logic on the read callback and works fine)

@diazmanuel ,
The code you provided is correct. However, I would like to emphasize that if the write_attr command with multiple attributes is handled correctly, the stack will only respond with nav->status == ESP_ZB_ZCL_STATUS_SUCCESS, message->info.status == ESP_ZB_ZCL_STATUS_SUCCESS, and nav->attribute_id == 0xFFFF, indicating that all writing has been successfully completed.

@diazmanuel If no further request on this issue, please help to close it, thanks.


Clarified what meeting_tile does to fit more with Crystal formatting.

It returns a boolean and makes more sense as meeting_tile?
In other languages it would have most likely been written as isMeetingTile, the ? is crystals equivalent to that format.

Sounds good to me! Cheers! :D


[WFLY-20084] Fix the build; main moved on while the new poms did not

https://issues.redhat.com/browse/WFLY-20084

@bstansberry But how come that dependency tree builder failed with https://github.com/wildfly/wildfly/actions/runs/12285446754/job/34283460542?pr=18508 the following? Is it not testing the actual PR code?
[FATAL] Non-resolvable parent POM for org.wildfly:wildfly-testsuite-aggregator-base:35.0.0.Beta1-SNAPSHOT: Could not find artifact org.wildfly:wildfly-parent:pom:35.0.0.Beta1-SNAPSHOT and 'parent.relativePath' points at wrong local POM @ line 19, column 13
[FATAL] Non-resolvable parent POM for org.wildfly:wildfly-ts-build-demander-expansion:35.0.0.Beta1-SNAPSHOT: Could not find artifact org.wildfly:wildfly-parent:pom:35.0.0.Beta1-SNAPSHOT and 'parent.relativePath' points at wrong local POM @ line 25, column 13
[FATAL] Non-resolvable parent POM for org.wildfly:wildfly-testsuite-aggregator-expansion:35.0.0.Beta1-SNAPSHOT: Could not find artifact org.wildfly:wildfly-parent:pom:35.0.0.Beta1-SNAPSHOT and 'parent.relativePath' points at wrong local POM @ line [19](https://github.com/wildfly/wildfly/actions/runs/12285446754/job/34283460542?pr=18508#step:11:20), column 13

@rhusar The dependency tree job first builds main then builds the merge branch and compares what artifacts are different.
So the 'build main' part will fail.

Ah Gotcha.

Thanks @rhusar


[Bug]Cannot be processed when the submitted task script is empty code

Describe the bug
Cannot be processed when the submitted task script is empty code.
This scenario should return a prompt message that the script cannot be empty and prohibit submission or end the task directly.
Expected behavior
When this method(org.apache.linkis.engineconn.computation.executor.execute.ComputationExecutor#toExecuteTask ) is executed, it should be judged whether the executed code is empty.

hi, @peacewong , would you help review this ?
thanks. kelu.


Open form broken in Survey

Steps to reproduce:

Use dev tip Survey
Download any collection of forms
Tap form to open

Expected behavior: Selected form should be displayed to the user
Observed behavior: Blank screen with "Please wait" is displayed instead
Additional notes: Uncaught TypeError: Object [object Object] has no method 'getBaseUrl' is shown in the AS logcat debug

Fixed, due to targetSDK being changed.


Fixes problem with create info object serialization that contains folded serializable objects

Codecov Report
Patch coverage: 100.00% and project coverage change: +0.02% :tada:

Comparison is base (9185d6c) 86.52% compared to head (700ff63) 86.55%.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@             Coverage Diff              @@
##                4.x      #57      +/-   ##
============================================
+ Coverage     86.52%   86.55%   +0.02%
  Complexity      191      191
============================================
  Files            29       29
  Lines           579      580       +1
============================================
+ Hits            501      502       +1
  Misses           78       78

Files Changed
Coverage Δ

src/Jobs.php
96.29% <100.00%> (+0.06%)
:arrow_up:

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Create Contributing.md, Setup.md, and ReadMe.md files

Create Contributing.md, Setup.md, and ReadMe.md files.

Hi @misspee007


Warn about having both env vars and plugin options

Not sure if it's typical Gatsby plugin behavior, but I spent most of the day debugging this.

@dandv I don't think this is a problem with this specific theme.
I believe this is due to how dotenv works, see more here: https://github.com/motdotla/dotenv#what-happens-to-environment-variables-that-were-already-set


Asset StaticMaterials struck doesn't change?

Hi there,
I tried to do something similar with #287 issue but it doesn't seem to work this time. Any idea why?
import unreal_engine as ue
from unreal_engine.classes import Material

asset = ue.get_asset('/Game/box.box')
material = ue.get_asset('/Game/material.material')

for j in range(0, len(asset.StaticMaterials)):
    settings = asset.StaticMaterials[j].clone()
    settings.MaterialInterface = material
    settings.MaterialSlotName = material.get_name()
    asset.StaticMaterials[j] = settings

Thanks

Hi @sinokgr, you cannot change arrays in place:
import unreal_engine as ue
from unreal_engine.classes import Material

asset = ue.get_asset('/Game/box.box')
material = ue.get_asset('/Game/material.material')

new_settings = []

for j in range(0, len(asset.StaticMaterials)):
    settings = asset.StaticMaterials[j].clone()
    settings.MaterialInterface = material
    settings.MaterialSlotName = material.get_name()
    new_settings.append(settings)

asset.StaticMaterials = new_settings

Great, didn't know that you can't modify list items, so many thanks for the reply.


Link not working in newsletter 20

The link to the blogpost about the Journal of Open Source Software is not working!
The link should be: http://pdebuyl.be/blog/2021/joss-ready.html

Updated newsletter 20 and readme


Foxx queues stuck in 'progress' status

Running 3.2.7, single-server on Ubuntu 16.04.
May be a regression of #3166.
We've noticed that jobs were stuck in 'progress' status (and so the queues stop processing any new job). Manually deleting those jobs resumed the normal operation of the queues, but they got stuck later again (so it is recurring although hard to reproduce).
This started to happen just after we migrated from 3.2.5 to 3.2.7, so we're pretty confident that this bug got (re?)introduced by either 3.2.6 or 3.2.7.

Hi Thomas,
you should definitely upgrade to 3.2.8.
I will tell @mpv1989 to have a look at this again.

@ThomasWeiss : I guess this is a problem after restarting an arangod instance. After a restart jobs that were in state "progress" (i.e. executing) when the server was shut down, were not properly reset to state "pending". This is especially a problem when these jobs were recurring, because it would mean they would not be restarted after a server restart when the server was shut down while a recurring job was being executed.
Release 3.2.9 has a fix for this.

@jsteemann Yep I think that's our case, but apparently not only after a restart, also when we update/replace the Foxx service that was consuming the queues.

Hi, version 3.2.9 has been released. I am closing this issue now. If the problem persists please let us know.
Many thanks,


SQUAD ListPlayers result limited to 23 playters of 100 (handle multiple packets?)

I faced with issue when I'm executing ListPlayers comand in SQUAD game on full server.
Every execution of ListPlayers returns only 23 players.
So to get full list of players I need run this command 5 (!) times.
Moreover, when I run it 6th time - it returns some random server logs instead of players (2nd screen).
Please fix this strange behaviour.

the problem is because your lib didn't continue reading data if packet size is more thn 4kb
currently i'm using java rcon lib https://github.com/ribasco/async-gamequery-lib where this fucntionallity implemented and working good
please, take a look on it

@romanvoloboev If you still need to read packets for squad, then I implemented mine specifically for squad, you can try using
https://github.com/iamalone98/squad-rcon-go


Enable criu on default plinux spec 11 17

Until it is turned on by default in extensions

fyi @tajila


Won't download SRT format subtitles (auto captions), always fall back to vtt format

youtube-dl version: 2016.02.10
System: Windows 10
Test URL:
https://www.youtube.com/watch?v=h7WtYrZ3b2c
--list-subs shows there is "en" lang, "srt" format available, but download with these options:
--write-auto-sub --write-sub --sub-lang en --sub-format ass/srt/best
will only get .vtt files.

There is no srt on Youtube anymore.


fix small typo

fix one typo (from 'itsself' to 'itself')

Thank you for you contribution to the repo and the community
On 14 Jul 2017, at 12:08, 靳阳<EMAIL_ADDRESS>wrote:

fix one typo (from 'itsself' to 'itself')
You can view, comment on, or merge this pull request online at:
https://github.com/geekcomputers/Python/pull/199
Commit Summary
fix small typo
File Changes
M env_check.py (2)
Patch Links:
https://github.com/geekcomputers/Python/pull/199.patch
https://github.com/geekcomputers/Python/pull/199.diff
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.


Move spacer to AWS Batch

Try using AWS batch instead of the current ECS based backend. This will require some minor changes to spacer, some AWS config work and also some change to how CoralNet submits the jobs.

[x] Configure AWS Batch. https://us-west-2.console.aws.amazon.com/batch/home?region=us-west-2#/dashboard
[x] Add AWS Batch bindings to spacer. https://github.com/beijbom/pyspacer/pull/29
[x] Migrate spacer to boto3. Make secure store feature. Make TrainClassifierMsg standalone.
[x] Integrated in CoralNet.

@StephenChan @kriegman : I added this ticket for myself. After conferring with the AWS folks, this seems like a much cleaner way compared to the current setup. It would basically only require interfacing with AWS Batch (plus possibly 1 SQS queue for reading back the results). So it's worth a shot as it'd make the AWS config much more maintainable. I might even try to setting the whole thing up using the CLI.

Sounds good - looking forward to seeing how it goes.

First PR create here: https://github.com/beijbom/pyspacer/pull/29. CC @StephenChan @kriegman.
I'll do one more PR on spacer, and some more testing before updating the CoralNet feature branch. So for it's looking quite good.

This appears to be done, but I guess we can check that it works in production first.

Looks like the AWS Batch setup is working smoothly overall. No recent reports of tasks not getting done. Guess it's time to close the 1.0 milestone, then!
I think it's worth looking into reducing the number of dev emails related to jobs not getting completed, but that can be addressed in a separate issue.


Add Python 3 support for mypy_server.py

probably not mypy-tools related but can't fix it:
$ python3.6 /usr/local/bin/mypy_server.py
Traceback (most recent call last):
  File "/usr/local/bin/mypy_server.py", line 3, in <module>
    from mypytools.server import mypy_server
  File "/usr/local/lib/python3.6/dist-packages/mypytools/server/mypy_server.py", line 20, in <module>
    from mypytools.server.mypy_http_request_handler import HttpServerThread
  File "/usr/local/lib/python3.6/dist-packages/mypytools/server/mypy_http_request_handler.py", line 6, in <module>
    from BaseHTTPServer import BaseHTTPRequestHandler, HTTPServer
ModuleNotFoundError: No module named 'BaseHTTPServer'

add PYTHONPATH
$ export PYTHONPATH=/usr/local/lib/python3.6/dist-packages/

different problem
$ python3.6 /usr/local/bin/mypy_server.py
Traceback (most recent call last):
  File "/usr/local/bin/mypy_server.py", line 2, in <module>
    import click
  File "/usr/local/lib/python3.6/dist-packages/click/__init__.py", line 18, in <module>
    from .core import Context, BaseCommand, Command, MultiCommand, Group, \
  File "/usr/local/lib/python3.6/dist-packages/click/core.py", line 8, in <module>
    from .types import convert_type, IntRange, BOOL
  File "/usr/local/lib/python3.6/dist-packages/click/types.py", line 4, in <module>
    from ._compat import open_stream, text_type, filename_to_ui, \
  File "/usr/local/lib/python3.6/dist-packages/click/_compat.py", line 1, in <module>
    import re
  File "/usr/lib/python3.6/re.py", line 142, in <module>
    class RegexFlag(enum.IntFlag):
AttributeError: module 'enum' has no attribute 'IntFlag'

Ah, the first error is because Python 3 doesn't have BaseHTTPServer any more. mypy_server.py doesn't quite support Python 3 yet. Not sure about the second error, but from some brief googling it looks like it might be caused by the fact you set your PYTHONPATH manually.

thx... it helped a bit... looks like python3 type hinting isn't supported
$ mypy_server.py
Initializing mypy server...Traceback (most recent call last):
  File "/usr/local/bin/mypy_server.py", line 13, in <module>
    main()
  File "/usr/local/lib/python2.7/dist-packages/click/core.py", line 722, in __call__
    return self.main(*args, **kwargs)
  File "/usr/local/lib/python2.7/dist-packages/click/core.py", line 697, in main
    rv = self.invoke(ctx)
  File "/usr/local/lib/python2.7/dist-packages/click/core.py", line 895, in invoke
    return ctx.invoke(self.callback, **ctx.params)
  File "/usr/local/lib/python2.7/dist-packages/click/core.py", line 535, in invoke
    return callback(*args, **kwargs)
  File "/usr/local/bin/mypy_server.py", line 10, in main
    mypy_server.run_server(compact=compact)
  File "/usr/local/lib/python2.7/dist-packages/mypytools/server/mypy_server.py", line 55, in run_server
    g = build_dependency_graph(src_dirs, silence=False)
  File "/usr/local/lib/python2.7/dist-packages/mypytools/server/mypy_server.py", line 36, in build_dependency_graph
    g.parsePathname(d)
  File "/usr/local/lib/python2.7/dist-packages/findimports.py", line 427, in parsePathname
    self.parseFile(os.path.join(root, fn))
  File "/usr/local/lib/python2.7/dist-packages/findimports.py", line 454, in parseFile
    module.imported_names = find_imports(filename)
  File "/usr/local/lib/python2.7/dist-packages/findimports.py", line 320, in find_imports
    root = ast.parse(f.read(), filename)
  File "/usr/lib/python2.7/ast.py", line 37, in parse
    return compile(source, filename, mode, PyCF_ONLY_AST)
  File "/home/emc/pycharm/cloud_tools/crtd/crt_dispatcher/__init__.py", line 36
    def __init__(self) -> None:
                       ^
SyntaxError: invalid syntax

I think what's happening here is that ast module in Python 2.7 doesn't know how to parse Python 3 code. Python 3 support (both for running and for parsing) are on the roadmap!

nice!


[Bootstrap] Install XCTest helper tool to bin.

This will install the XCTest helper tool which lists tests on OSX in the
bin folder. Note that this will still not build the helper during stage1
which should be fine because its not really needed in stage1.

@swift-ci please test

@ddunbar updated


gapps init throws error if there is .json manifest file in the project

Because of Gmail add-ons project has appsmanifest.json file I faced with the following issue:

Create an empty Gmail add-ons project.
Click View -> Show manifest file
execute gapps init 'project_id'
See an error:
Error running init command Unhandled rejection Error: Unsupported file type found  at Object.getFileExtension (/home/vitalybevzik/.nvm/versions/node/v5.12.0/lib/node_modules/node-google-apps-script/lib/util.js:60:9)  at writeExternalFile (/home/vitalybevzik/.nvm/versions/node/v5.12.0/lib/node_modules/node-google-apps-script/lib/commands/init.js:48:35)  at /home/vitalybevzik/.nvm/versions/node/v5.12.0/lib/node_modules/node-google-apps-script/lib/commands/init.js:39:14  at tryCatcher (/home/vitalybevzik/.nvm/versions/node/v5.12.0/lib/node_modules/node-google-apps-script/node_modules/bluebird/js/main/util.js:26:23)  at MappingPromiseArray._promiseFulfilled (/home/vitalybevzik/.nvm/versions/node/v5.12.0/lib/node_modules/node-google-apps-script/node_modules/bluebird/js/main/map.js:56:38)  at MappingPromiseArray.init (/home/vitalybevzik/.nvm/versions/node/v5.12.0/lib/node_modules/node-google-apps-script/node_modules/bluebird/js/main/promise_array.js:92:18)  at Promise._settlePromiseAt (/home/vitalybevzik/.nvm/versions/node/v5.12.0/lib/node_modules/node-google-apps-script/node_modules/bluebird/js/main/promise.js:582:21)  at Promise._settlePromises (/home/vitalybevzik/.nvm/versions/node/v5.12.0/lib/node_modules/node-google-apps-script/node_modules/bluebird/js/main/promise.js:700:14)  at Async._drainQueue (/home/vitalybevzik/.nvm/versions/node/v5.12.0/lib/node_modules/node-google-apps-script/node_modules/bluebird/js/main/async.js:123:16)  at Async._drainQueues (/home/vitalybevzik/.nvm/versions/node/v5.12.0/lib/node_modules/node-google-apps-script/node_modules/bluebird/js/main/async.js:133:10)  at Immediate.Async.drainQueues [as _onImmediate] (/home/vitalybevzik/.nvm/versions/node/v5.12.0/lib/node_modules/node-google-apps-script/node_modules/bluebird/js/main/async.js:15:14)  at tryOnImmediate (timers.js:534:15)  at processImmediate [as _immediateCallback] (timers.js:514:5)

MR to resolve this https://github.com/danthareja/node-google-apps-script/pull/59/files

Currently, gapps will delete .json files on google drive.  I think this fix will also prevent this.

Fixed by #73


Update get-clients.md

Removed section on Linux as it was deprecated in December 2022

@dstrome
PR has been copyedited and is ready for final review, could you please check and merge? Thanks!


Translated urls

Codecov Report

Merging #188 into master will decrease coverage by 6.59%.
The diff coverage is 0%.

@@            Coverage Diff            @@
##           master     #188     +/-   ##
=========================================
- Coverage   64.84%   58.24%   -6.6%
=========================================
  Files          21       23      +2
  Lines         256      285     +29
=========================================
  Hits          166      166
- Misses         90      119     +29

Impacted Files
Coverage Δ

omahelsinki/settings.py
85.93% <ø> (ø)
:arrow_up:

omahelsinki/urls.py
0% <0%> (ø)
:arrow_up:

home/templatetags/home_app.py
0% <0%> (ø)

home/context_processors.py
0% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b970d58...8f4ed4e. Read the comment docs.


Deploy Checklist: New Expensify 2023-03-10

Release Version: 1.2.82-4
Compare Changes: https://github.com/Expensify/App/compare/production...staging
This release contains changes from the following pull requests:

[x] https://github.com/Expensify/App/pull/14944
[x] https://github.com/Expensify/App/pull/15240
[x] https://github.com/Expensify/App/pull/15705
[x] https://github.com/Expensify/App/pull/15709
[x] https://github.com/Expensify/App/pull/15710
[x] https://github.com/Expensify/App/pull/15730
[x] https://github.com/Expensify/App/pull/15752
[x] https://github.com/Expensify/App/pull/15769
[x] https://github.com/Expensify/App/pull/15776
[x] https://github.com/Expensify/App/pull/15792
[x] https://github.com/Expensify/App/pull/15820
[x] https://github.com/Expensify/App/pull/15840

Internal QA:

[ ] https://github.com/Expensify/App/pull/15502 - @tgolen

Deploy Blockers:

[x] https://github.com/Expensify/App/issues/15770

Deployer verifications:

[ ] I checked the App Timing Dashboard and verified this release does not cause a noticeable performance regression.
[ ] I checked Firebase Crashlytics and verified that this release does not introduce any new crashes. More detailed instructions on this verification can be found here.

cc @Expensify/applauseleads

:clap: Heads up @Expensify/applauseleads :clap:
A new pull request has been :cherries: cherry-picked :cherries: to staging, and will be deployed to staging in version 1.2.82-4 :rocket:

:tada: All set?…You bet! @Expensify/applauseleads https://github.com/Expensify/App/releases/tag/1.2.82-4 has been deployed to staging :tada:

@Julesssss
Regression is completed. We are checking last CP
PR https://github.com/Expensify/App/pull/15240 blocked on IOS due to old KI https://github.com/Expensify/App/issues/13882.

I verified all 4 cases for this PR, checking it off: https://github.com/Expensify/App/pull/15709

No outlying timing data since the last release 👍
No new crashes of note 👍

:shipit:


Problem with hostNetwork sockets

Is there an existing issue for this?

[X] I have searched the existing issues

What happened?
Pod ingress-nginx working in hostNetwork has opened sockets to kube-dns.
netstat: can't scan /proc - are you root?
Active Internet connections (w/o servers)
Proto Recv-Q Send-Q Local Address           Foreign Address         State       PID/Program name
udp        0      0 <IP_ADDRESS>:35765      <IP_ADDRESS>:5353       ESTABLISHED -

root@dev-master-0:~# kubectl -n kube-system get pods -o wide | grep kube-dns
d8-kube-dns-5f75bbc6d6-9sdqk                           2/2     Running   0              7m9s   <IP_ADDRESS>      dev-master-0                      <none>           <none>
d8-kube-dns-5f75bbc6d6-zjsn6                           2/2     Running   0              7m9s   <IP_ADDRESS>      dev-master-0                      <none>           <none>

If we restart kube-dns pods ip addresses of pods changes:
root@dev-master-0:~# kubectl -n kube-system delete pod d8-kube-dns-5f75bbc6d6-9sdqk d8-kube-dns-5f75bbc6d6-zjsn6
pod "d8-kube-dns-5f75bbc6d6-9sdqk" deleted
pod "d8-kube-dns-5f75bbc6d6-zjsn6" deleted
root@dev-master-0:~# kubectl -n kube-system get pods -o wide | grep kube-dns
d8-kube-dns-5f75bbc6d6-7gh8t                           2/2     Running   0              10s    <IP_ADDRESS>      dev-worker-6ce11b60-76fb8-29zwq   <none>           <none>
d8-kube-dns-5f75bbc6d6-vvphs                           2/2     Running   0              10s    <IP_ADDRESS>       dev-worker-6ce11b60-76fb8-q88fp   <none>           <none>

But socket in ingress-nginx pod does not change:
/ $ netstat -upn
netstat: can't scan /proc - are you root?
Active Internet connections (w/o servers)
Proto Recv-Q Send-Q Local Address           Foreign Address         State       PID/Program name
udp        0      0 <IP_ADDRESS>:35765      <IP_ADDRESS>:5353       ESTABLISHED -

And nginx fails to resolve dns names.
When we use flannel as cni in the same cluster configuration, we do not have any issues and dns resolve works as expected.
Please give me some advice what to do in this case.
Cilium Version
1.11.14 / 1.12.7
Kernel Version
5.15.0-58-generic
Kubernetes Version
1.23
Sysdump
No response
Relevant log output
No response
Anything else?
No response
Code of Conduct

[X] I agree to follow this project's Code of Conduct

Hey ! Yes, i will collect sysdump. We use kube-proxy-replacement.
<IP_ADDRESS> is pod address.
Service address is <IP_ADDRESS>.
i think problem is connected to service resolve in cilium.
When we use flannel i see <IP_ADDRESS> in socket Foreign Address.

cilium-sysdump-20230316-193832.zip

@aditighag Hi

The sysdump is incomplete. There are no cilium logs nor bugtool output.

Sorry, i collected new sysdump. https://drive.google.com/file/d/1Cb4TO2vi7ywIn64TEqwpO-fEYxWufRRD/view?usp=share_link (file is too big for github).

@aditighag Hi, did you have time to watch ?

Based on the sysdump data, you are running into the limitation of socket-lb - https://github.com/cilium/cilium/issues/12859.

@aditighag thanks, i know this issue, but is there a plan to solve this problem ? https://github.com/cilium/cilium/issues/12859 was created almost 3 years ago and has no progress.

You can monitor the issue for 1.14 updates.


Add Technical blog post.

Checklist

Please note that in case of below checklist not updated accordingly, the maintainers have the right to immediately close your pull request.

[x ] You created a branch from dev branch.
[x ] You PR is raised on dev branch and not onmaster.
[x ] Blog follows Blog Guidelines.
[x ] You have read the Contribution Guidlines before creating this PR.
[x ] Checked for any duplicate blog entry.
[x ] Checked for all grammatical errors in the blog.
[x ] You have not published the blog content anywhere else on the internet on platforms like medium, dev.to etc.
[x ] The content is not copy-pasted from anywhere else on the Internet.

Description of change
Blog entry about template strings (JS related).

Author Details for Blog Post Entry

id: Tatiana Coelho
bio: Slowdev with passion.
github: https://github.com/tacoelho
stackoverflow: https://stackoverflow.com/users/10454517/rabbit?tab=profile
linkedin: https://linkedin.com/in/tatiana-coelho-
twitter: @whoistatona

@tacoelho Please go through CONTRIBUTING and Blog Guidelines before raising a PR.
Blog size should be minimum 600-900 words, cover image size should be of 1200px X 800px

Sorry about that. Changes made.

@tacoelho I don't think this blog covers everything about template strings. This is too generic information.


Blank Responses

Quite often, the reply window is blank after the prompt has been processed and needs to be re-triggered with a prompt like "??" to generate the response

@anshum4 thanks for reporting this issue. If you form your question properly as in
What does this code do: ...your code without ticks (`)...

You should get a proper response. This seems like it may be related to using openai api key method and the public models aren't as capable as the web version in terms of completion models.


Feature/herolab patch note parser

Hero Lab patch notes are now parsed through their location in the gamefiles, rather than added to input-data manually.

Removed the comments and readme for adding to input-data.
Reformatted dates from forum changelogs from mm-dd-yyyy to yyyy_mm_dd, which are now consistent with gamefile date formats. This allows them to be sorted by date accurately in changelog_configs.json (formerly named changelogs.json).
Fixed the TypedDicts accidentally describing the final format that parse_changelogs uses with Tagging, as opposed to it's actual format.

Still feel's a little scrappy, so lmk if you see any immediate areas of improvement. I'll need this merged in before I work on integrating the manifest-id versioning branch with the recent changelog updates.
Parsed data in deadlock-data PR

Reverted to an older version and ported to PR #130


Fix mocha context to closure on computed props

Fixes #94. Wasn't checking for computed properties before :(
cc/ @GoodForOneFare @fandy

LGTM 👍
Sidebar: I can never remember what this transform does from the name alone 😕 If we can come up with something better, I'd be happy to PR a JS+docs update.  mocha-this-to-suite-scope?

lol, I am pretty ambivalent about the name, if you feel strongly I have no problem with renaming it.


Hide "Help Resources" button when help link is empty

Summary

Currently, even if Help Link in the system console is empty, it still shows up in the global header. This PR adds a non-empty condition.
Ticket Link

https://mattermost.atlassian.net/browse/MM-44165
Screenshots

before
after

Release Note

Fixed a bug where Help Resources button pointed to the current link in a new tab, if empty.

E2E tests not automatically triggered, because the PR is not in a mergeable state. Please update the branch with the base branch and resolve outstanding conflicts.

/e2e-test

Successfully triggered E2E testing!
GitLab pipeline | Test dashboard

/update-branch

/e2e-test

Successfully triggered E2E testing!
GitLab pipeline | Test dashboard

This PR has been automatically labelled "stale" because it hasn't had recent activity.
A core team member will check in on the status of the PR to help with questions.
Thank you for your contribution!


SSCCE - Arraybuffer / Blob / XHR in IE

Related to #56 .  Here is a small repro for generating the InvalidStateError in IE (I'm testing against IE11 latest update).
This code downloads bytes from an xhr using expectBytes response. Under the covers, the xhr generates an array buffer that is passed to new Blob in Kernel code at File.Download.bytes.
Here is the code with the error:
import Browser
import Bytes exposing (Bytes)
import Bytes.Decode as Decode
import File.Download as Download
import Html exposing (..)
import Html.Events exposing (onClick)
import Http exposing (Error(..), Response(..))

type Msg
    = Download
    | DownloadComplete (Result Http.Error Bytes)

type alias Model =
    Maybe Bytes

resolve : Response Bytes -> Result Error Bytes
resolve response =
    case response of
        BadUrl_ url ->
            Err (BadUrl url)

        Timeout_ ->
            Err Timeout

        NetworkError_ ->
            Err NetworkError

        BadStatus_ metadata _ ->
            Err (BadStatus metadata.statusCode)

        GoodStatus_ _ body ->
            Ok body

downloadBytes : Cmd Msg
downloadBytes =
    Http.get
        { url = "https://media.giphy.com/media/dUQakUPAZw1EY/200w_d.gif"
        , expect = Http.expectBytesResponse DownloadComplete resolve
        }

init : {} -> ( Model, Cmd Msg )
init _ =
    ( Nothing, downloadBytes )

update : Msg -> Model -> ( Model, Cmd Msg )
update msg model =
    case msg of
        Download ->
            Maybe.map (\bytes -> ( model, Download.bytes "gracias.gif" "image/gif" bytes )) model
                |> Maybe.withDefault ( model, Cmd.none )

        DownloadComplete result ->
            case result of
                Ok bytes ->
                    ( Just bytes, Cmd.none )

                Err e ->
                    ( model, Cmd.none )

view : Model -> Html Msg
view model =
    Maybe.map (always (button [ onClick Download ] [ text "download bytes" ])) model
        |> Maybe.withDefault (text "Downloading file.")

main : Program {} Model Msg
main =
    Browser.element
        { init = init
        , update = update
        , view = view
        , subscriptions = always Sub.none
        }

Error screenshot.

@boianr mentioned https://github.com/bpampuch/pdfmake/issues/294 which appears to be the same problem. They solved it like this: https://github.com/bpampuch/pdfmake/pull/297/files
If you can try adding something like that on your side, let me know how it goes for you!

Got it down to something smaller in https://github.com/elm/file/issues/10


The eng-common sync pipeline fails to merge the PR

The merge step fails due to the following error:
Merging https://api.github.com/repos/Azure/azure-sdk-for-android/pulls/1571
##[error]Invoke-RestMethod [https://api.github.com/repos/Azure/azure-sdk-for-android/pulls/1571/merge] failed with exception:
The given key 'Content-Type' was not present in the dictionary.
##[error]PowerShell exited with code '1'.

Here is the pipeline run triggered by this PR. I had to manually merge all the sync PRs. I noticed that the previous run of the sync pipeline already had this issue and the PR author had to merge the PR manually.
I met this issue previously when doing the Go SDK release and made a fix to the common script by this PR.  The same fix should be applied to the sync script.
@weshaggard

Thanks for reporting I've seen this error once before but not sure what causes it. I think this process does still work in general though. I'll keep an eye on this the next eng/common sync I see.


Equation of state is not DRY

The equation of state is used to compute the pressure from the variables. This EOS changes slightly for different models. The EOS implementation is repeated several places in the code, including in m_variables_converison, m_data_output (including serial data output and probe outputs), and likely more. Following the DRY principle (don't repeat yourself), we should fix this. It has also caused multiple false bugs in the past.

I have gone ahead and implemented the s_compute_pressure subroutines and pointers, located in m_initial_condition.fpp. However, because m_initial_condition.fpp uses m_variables_conversion.fpp and m_variables_conversion.fpp uses m_initial_condition.fpp, there is an error being thrown:
~/src/pre_process/m_variables_conversion.f90:19:9:

   19 |     use m_initial_condition
      |         1
Error: 'm_variables_conversion' of module 'm_initial_condition', imported at (1), is also the name of the current program unit

Therefore I am unsure if there's any way I can really implement s_compute_pressure in m_initial_condition. Is there any other module that I can try and implement it in?

I think m_variable_conversion is a more natural home for this kind of thing.

@anshgupta1234 Check out these lines in m_cbc:
https://github.com/MFlowCode/MFC/blob/d80602abfc6c1528708963032ef8cd44b3f26622/src/simulation/m_cbc.fpp#L786-L853
I think these can probably be factored out completely. One thing we didn't initially notice is how pervasive the computation of c, the speed of sound is.
This is above, but also throughout the codebase.
We should create a helper function that goes in common/m_var_conversion that computes the speed of sound.
We see something similar in m_riemann_solvers, for example:
https://github.com/MFlowCode/MFC/blob/d80602abfc6c1528708963032ef8cd44b3f26622/src/simulation/m_riemann_solvers.fpp#L464-L572
We also see the computation of c coming up again. Each time it takes something like 70 lines:
https://github.com/MFlowCode/MFC/blob/d80602abfc6c1528708963032ef8cd44b3f26622/src/simulation/m_riemann_solvers.fpp#L639-L714

I realize this is becoming an omnibus "issue". Let's merge your pull request when you have all of the main variables conversion stuff done, then do speed of sound c after.


Initial version of CDT.cloud Blueprint

What it does
Initial version of the CDT.cloud Blueprint using the up-to-date Theia Blueprint as a basis.
How to test
yarn && yarn electron start
State

Logos are not yet replaced
Only tested on Linux, Mac and Windows not tested yet
Not yet integrated into Jenkins (although preparations are done)
VSCode extensions need to be updated (Open VSX is down at the moment)

Plan is to squash-merge the contribution for a clean commit

changes look good to me, the open questions you raised must be addressed of course


multiple matches but only one pickup?

In this example, veh12 gets three assignments, but later it only makes one pickup/dropoff (cust13)???
[2018-06-13 00:28:33][greedy_insertion] Match (cust7, veh18)
[2018-06-13 00:28:33][greedy_insertion] Match (cust10, veh12)
[2018-06-13 00:28:33][greedy_insertion] Match (cust11, veh12)
[2018-06-13 00:28:33][greedy_insertion] Match (cust13, veh12)
[2018-06-13 00:28:33][greedy_insertion] Match (cust17, veh18)

Issue is in greedy_insertion.cpp. Veh12 gets a new schedule; the new schedule commits to the db; but handle_customer() loops through the local vehicles. In the local vehicles, Veh12 has the old schedule. The local vehicles is not refreshed until the next listen().
Fix: refresh the entry in the local vehicles; or prevent vehicles from being matched twice in the same batch?
if (matched) {
    commit(cust, best_vehicle, best_route, best_schedule);
    /* refresh(best_vehicle) here, or maybe do it in RSAlgorithm::commit() */
    print_success << "Match (cust" << cust.id() << ", veh" << best_vehicle.id() << ")\n";
    nmatches++;
}

Now there's a MutableVehicle class so local vehicles can be refreshed.


Ja/move api clients to docstrings

Work item: W-7769115
This does a few things in an attempt to simplify the code before splitting up

APICLIENTS.md and templates to create them have been removed
The listOperations has been removed as that wasn't needed for anything except a demo of what could be done.
MAJOR CHANGE Rendering of API models refactored to allow for the passing of the API metadata from exchange.
A lot of unneeded code and their tests have been removed.
Adds package-lock.json back in (If you ignore this there are only 91 lines added, and over 300 removed in this PR)
Class docstrings now have examples and links back to their corresponding documentation at https://developer.commercecloud.com/

Example output of new documentation generated -

Finally fixed the snyk issues!!!


Any other way to designate Prev/Next data-controls?

Firstly, thank you for making such a nice and lightweight slider library!
Issue description:
I have some sliders which need previous and next buttons to come before and after the thumbnail items, respectively. So ideally it would look like this:  Prev Item1 Item2 Item3 Next
I have only been able to do this with absolute positioning and some other CSS, and it isn't very convenient if the number of thumbnail items will change.
It seems like the data-controls are being set sequentially, whatever is under the designated controls container. Is it possible to change this, maybe set the data-controls by whatever has a class of "next" or "prev"? Or maybe there is another good way.
I am willing to help with some testing if I can.
Thanks again for all your hard work!

Yes, will add options for prev/next in recent releases.

prevButton, nextButton options were added in this commit.


imageView with CGAffineTransform

How can I apply CGAffineTransform to imageView ImageViewerConfiguration ?
I try this
let configuration = ImageViewerConfiguration { config in
            config.imageView = imageView // my UImageView
            let angle: CGFloat = (270.0 * CGFloat.pi/180.0)
            config.imageView?.transform = CGAffineTransform(rotationAngle: angle)
}

but no effect

What kind of behaviour did you expect?


Optimize repeated code

Description
Create a method for instantiating new waterfalls and clean up the repeated code. This was requested on PR #1507

Pull Request Test Coverage Report for Build 52011

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 75.588%

Totals

Change from base Build 51937:
0.0%

Covered Lines:
4304

Relevant Lines:
5694

💛  - Coveralls

@ParadoxARG Could you resolve the merge conflict?

Hi @cleemullins! We solved the conflicts.


Problem with native file loading.

Issue details(Over-detailed)
I was working on a game(still on it) for android (without a IDE)(My own setup) . I was using libgdx 1.9.0 or something like that . and there was no problem .
But the problem occured when I upgraded to 1.11.0.
what was the problem ?
It was nothing (JOKING) . i can built it fine , problem was when I Launch it . it just kicks me out . WTh! tried to find why(maybe problem with my codes) . couldn't find why !
after some changes and testing found that it was something to do with library . at first i thought maybe problem with the native files . I change back - forth versions but at the end it was gdx.jar that had something missing .
I don't know why but 1.11.0 doesn't have com.badlogic.gdx.utils.SharedLibraryLoader class (1.10.0 has it)
I don't why you guys removed it but for android this class is essential . Maybe you guys found some other way around but forgot to implement it for android (backend(AndroidApplication class)).
Reproduction steps/code
Just added com.badlogic.gdx.utils.SharedLibraryLoader class from 1.10.0 to 1.11.0 and works for me.
Version of libGDX and/or relevant dependencies
1.11.0
Stacktrace
//Please provide the stacktrace if applicable
```time:<PHONE_NUMBER>933
msg: java.lang.ClassNotFoundException: com.badlogic.gdx.utils.SharedLibraryLoader
stacktrace: java.lang.NoClassDefFoundError: Failed resolution of: Lcom/badlogic/gdx/utils/SharedLibraryLoader;
	at com.badlogic.gdx.utils.GdxNativesLoader.load(GdxNativesLoader.java:30)
	at com.badlogic.gdx.backends.android.AndroidApplication.init(AndroidApplication.java:115)
	at com.badlogic.gdx.backends.android.AndroidApplication.initialize(AndroidApplication.java:81)
	at com.dark.bounceup.MainActivity.onCreate(MainActivity.java:16)
	at android.app.Activity.performCreate(Activity.java:7994)
	at android.app.Activity.performCreate(Activity.java:7978)
	at android.app.Instrumentation.callActivityOnCreate(Instrumentation.java:1314)
	at android.app.ActivityThread.performLaunchActivity(ActivityThread.java:3405)
	at android.app.ActivityThread.handleLaunchActivity(ActivityThread.java:3596)
	at android.app.servertransaction.LaunchActivityItem.execute(LaunchActivityItem.java:85)
	at android.app.servertransaction.TransactionExecutor.executeCallbacks(TransactionExecutor.java:135)
	at android.app.servertransaction.TransactionExecutor.execute(TransactionExecutor.java:95)
	at android.app.ActivityThread$H.handleMessage(ActivityThread.java:2067)
	at android.os.Handler.dispatchMessage(Handler.java:106)
	at android.os.Looper.loop(Looper.java:223)
	at android.app.ActivityThread.main(ActivityThread.java:7665)
	at java.lang.reflect.Method.invoke(Native Method)
	at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:594)
	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:947)
Caused by: java.lang.ClassNotFoundException: com.badlogic.gdx.utils.SharedLibraryLoader
	... 19 more

Please select the affected platforms

[ ] Android

OK. I'll try to refrain from ranting, but we use dependency management with Gradle for good reasons. In 1.10.0, there was some awkwardly placed SharedLibraryLoader code (it might have been duplicated?), and to save on distributable size and keep code where it logically belonged, that file was moved to the gdx-jnigen project. You can see the code that relies on this in one of the build.gradle files, https://github.com/libgdx/libgdx/blob/1.11.0/gdx/build.gradle#L43 . 1.11.0 is the first stable release to get SharedLibraryLoader from gdx-jnigen-loader, which is why you're noticing it in this version update, and it seems like you aren't depending on gdx-jnigen-loader, so without that or your solution (copying in an older SharedLibraryLoader), the code wouldn't be able to work correctly. I'd recommend using the gdx-jnigen-loader JAR that 1.11.0 depends on (you can download the JAR from Maven Central directly, https://repo1.maven.org/maven2/com/badlogicgames/gdx/gdx-jnigen-loader/2.3.1/ , or build from source, https://github.com/libgdx/gdx-jnigen ), but the SharedLibraryLoader code could be the same in 1.10.0 and you might see no difference.
So there we are. This isn't a bug, you were just missing a dependency. Closing.

I think you guys should mention some more info in wiki.
thank you for your help.


Add load balancing to FS installation in Google Cloud

Added internal TCP Load Balancer. Its main components: unmanaged instance group for FS servers, backend service, health check and forwarding rule.
Now there is only 1 frontend address, all FS clients use the same config file, clients are no longer assigned to servers manually anymore - it happens automatically by load balancer.

The load balancing works now, however, I'm not sure if it's fine to leave the health check system in the current state. For now, FS servers don't respond to health check probes, but the main functionality works fine - all the FS components exchange with messages as expected. The Load Balancer shows that 0 servers are healthy, but it still forwards requests to the backend servers, so the health check system is useless. At the same time, it's impossible to create a LB without any health checks at all - Terraform prints an error in this case.
Do we need to support health check requests on FS servers (e.g starting a simple process in the server binary that always responds with an empty message and 200 OK status)? If we want to do it properly there can be an issue: health check system is an external service and it can connect to instances only via external IP. For this, the firewall rule is required, but as I understand, there is a job in the internal Google Cloud that periodically deletes all the firewall rules created by users (not default ones).

When using the communicator component for loadbalancing, it is important that the server port used to communicate with clients not be open to the internet at large - clients connecting to it have the ability to lie about their IP. Therefore, firewall rules or simple network partitioning must be used to allow only the loadbalancer to connect to these ports (https://github.com/google/fleetspeak/blob/master/fleetspeak/src/server/components/https/proxy.go)

We should simply do the same thing to support connections from the health check servers, and the documentation does mention the IP ranges in quesiton:
https://cloud.google.com/load-balancing/docs/health-checks#firewall_rules

Because of 1, a multi-server FS setup simply isn't going to be safe to operate without firewall rules, and the TF script should demonstrate how to configure them correctly. Does this need to run on a Google internal cloud project? The e2e test by design won't have Google internal data, or any sensitive data at all, as far as I know. If it does for some reason, I'm sure that there is a way to have a firewall rule set approved and whitelisted, but I don't know how long or involved that process is.


Add Mimics

Closes #187
Closes #183

@CodiumAI-Agent /review
Curious what this will do

PR Analysis

🎯 Main theme: Adding new features and refactoring existing code in a game project
📝 PR summary: This PR introduces a new feature, the 'Mimic Matter' ability, to the game. It also includes refactoring of some existing code, renaming of classes, and addition of new classes and methods. The new feature allows game characters to mimic the properties of other objects.
📌 Type of PR: Enhancement
🧪 Relevant tests added: No
⏱ Estimated effort to review [1-5]: 4
The PR is quite large and involves both the addition of new features and refactoring of existing code. It requires a good understanding of the game's codebase to review effectively.
🔒 Security concerns: No security concerns found

PR Feedback

💡 General suggestions: The PR is well-structured and the new feature seems to be implemented correctly. However, it would be beneficial to add some tests to ensure the new feature works as expected and does not introduce any regressions. Additionally, some of the code could be further refactored for better readability and maintainability.

 🤖 Code feedback:

relevant file: Source/MimickedMatter.cs
suggestion: Consider adding error handling for the case where the pawn cannot be added to the mimicked thing. Currently, the pawn is destroyed if it cannot be added, but it might be better to throw an exception or at least log an error message. [important]
relevant line: '+            if (!mimickedMatter.innerContainer.TryAdd(pawn))'

relevant file: Source/AbilityComp/MimicMatter.cs
suggestion: Consider refactoring the Apply method to make it more readable. It currently does a lot of things and could be split into smaller, more manageable methods. [medium]
relevant line: '+        public override void Apply(LocalTargetInfo target, LocalTargetInfo dest)'

relevant file: Source/JobGiver/CastAbilityOnJobTarget.cs
suggestion: The class name 'CastAbilityOnJobTarget' is a bit ambiguous. Consider renaming it to something more descriptive, like 'CastAbilityOnTargetJobGiver'. [medium]
relevant line: '+    public class CastAbilityOnJobTarget : JobGiver_AICastAbility'

relevant file: Source/MimickedMatter.cs
suggestion: The Tick method could be refactored for better readability. Consider splitting the if condition into multiple lines or extracting it into a separate method. [medium]
relevant line: '+        public override void Tick()'

How to use

Tag me in a comment '@CodiumAI-Agent' and add one of the following commands:
/review [-i]: Request a review of your Pull Request. For an incremental review, which only considers changes since the last review, include the '-i' option.
/describe: Modify the PR title and description based on the contents of the PR.
/improve [--extended]: Suggest improvements to the code in the PR. Extended mode employs several calls, and provides a more thorough feedback.
/ask <QUESTION>: Pose a question about the PR.
/update_changelog: Update the changelog based on the PR's contents.

To edit any configuration parameter from configuration.toml, add --config_path=new_value
For example: /review --pr_reviewer.extra_instructions="focus on the file: ..."
To list the possible configuration parameters, use the /config command.


Block Trend average incorrect after leader flip?

Biden just took the lead in GA:

Trump is averaging 65.6%
Biden is averaging 67.9%
Biden is averaging 67.9%

The Block Trend for Trump looks like it's really the old one for Biden, so is Trump's average really 100% - 65.6% = 34.4%?

I came to report exactly this! :D I guess it's still reporting the Biden average.

Duplicate of #206, #210, #211, #212. May be fixed by https://github.com/alex/nyt-2020-election-scraper/pull/208.


kernel: timeout: next timeout is closer to elapsed time

Directly get the elapsed time instead of writing a variable
So is the calculated next timeout value as close to the
elapsed time as possible.
Fixes https://github.com/zephyrproject-rtos/zephyr/issues/46641
Signed-off-by: Francois Ramu<EMAIL_ADDRESS>

test case tests/kernel/context PASSED on the nucleo_f091rc
*** Booting Zephyr OS build zephyr-v3.1.0-914-gad71390e548d  ***
Running TESTSUITE context
===================================================================
START - test_kernel_interrupts
SKIP - test_kernel_interrupts in 0.1 seconds
===================================================================
START - test_kernel_ctx_thread
Testing k_current_get() from an ISR and thread
Testing k_is_in_isr() from an ISR
Testing k_is_in_isr() from a preemptible thread
PASS - test_kernel_ctx_thread in 0.12 seconds
===================================================================
START - test_busy_wait
Thread busy waiting for 20000 usecs
Thread busy waiting completed
Thread busy waiting for 20000 usecs (irqs locked)
Thread busy waiting completed (irqs locked)
PASS - test_busy_wait in 0.54 seconds
===================================================================
START - test_k_sleep
thread sleeping for 50 milliseconds
thread back from sleep
Testing k_thread_create() without cancellation
thread (q order: 2, t/o: 500) is running
got thread (q order: 2, t/o: 500) as expected
thread (q order: 3, t/o: 750) is running
got thread (q order: 3, t/o: 750) as expected
thread (q order: 0, t/o: 1000) is running
got thread (q order: 0, t/o: 1000) as expected
thread (q order: 6, t/o: 1250) is running
got thread (q order: 6, t/o: 1250) as expected
thread (q order: 1, t/o: 1500) is running
got thread (q order: 1, t/o: 1500) as expected
thread (q order: 4, t/o: 1750) is running
got thread (q order: 4, t/o: 1750) as expected
thread (q order: 5, t/o: 2000) is running
got thread (q order: 5, t/o: 2000) as expected
Testing k_thread_create() with cancellations
cancelling [q order: 0, t/o: 1000, t/o order: 0]
thread (q order: 3, t/o: 750) is running
got (q order: 3, t/o: 750, t/o order 1) as expected
thread (q order: 0, t/o: 1000) is running
got (q order: 0, t/o: 1000, t/o order 2) as expected
cancelling [q order: 3, t/o: 750, t/o order: 3]
cancelling [q order: 4, t/o: 1750, t/o order: 4]
thread (q order: 4, t/o: 1750) is running
got (q order: 4, t/o: 1750, t/o order 5) as expected
cancelling [q order: 6, t/o: 1250, t/o order: 6]
PASS - test_k_sleep in 5.336 seconds
===================================================================
START - test_kernel_cpu_idle_atomic
SKIP - test_kernel_cpu_idle_atomic in 0.1 seconds
===================================================================
START - test_kernel_cpu_idle
PASS - test_kernel_cpu_idle in 0.8 seconds
===================================================================
START - test_k_yield
PASS - test_k_yield in 0.1 seconds
===================================================================
START - test_kernel_thread
PASS - test_kernel_thread in 0.1 seconds
===================================================================
START - test_kernel_timer_interrupts
SKIP - test_kernel_timer_interrupts in 0.1 seconds
===================================================================
TESTSUITE context succeeded
===================================================================
RunID: 0e4722e3073f6b99bce70cd258a7f372
PROJECT EXECUTION SUCCESSFUL

This seems poorly justified, and more like you're chasing a timing glitch in the test that adjusting a few cycles in the kernel just happens to fix. This is only going to move timing by a tiny bit, and the kernel should be making correct decisions even if the clock slips by a tick (because it will all the time: you can't lock or synchronize against real time).
Can you walk me through exactly what the situation is that's failing here and why this fixes it?

What I can say is reported in the issue https://github.com/zephyrproject-rtos/zephyr/issues/46641 : the testcase  tests/kernel/context/test_kernel_cpu_idle failed  on the nucleo_f091rc START -
because of
 Assertion failed at WEST_TOPDIR/zephyr/tests/kernel/context/src/main.c:355: _test_kernel_cpu_idle: (tms2 < )
Bad ms value computed,got 5481 which is less than 5482

and that changing the elapsed fixes the pb without impacting others (as far as I can check)

Yeah, that just looks like a racy test.  It's relying on a 1ms idle coming out exactly as expected, on a system with a 10 kHz tickrate and with a driver (systick) that is known to be a little sloppy on boundaries (it isn't free running and doesn't self-reset, so the ISR inevitably loses time and has to guess at a calibration/correction).  My guess is that other systick devices would probably fail similarly.
(Also it's invoking k_cpu_idle() incorrectly -- interrupts need to be masked on entry there too, not just for k_cpu_atomic_idle(), but that's benign unless this test has a mystery interrupt source other than the timer)
And AFAIK we don't actually promise high precision through k_cpu_idle() anyway.  This platform doesn't have a deep idle state, but some do (e.g. if you guys ever move to the "kHz-scale clock for idle, mHz for runtime" architecture, you're going to get there too), and almost by definition timeout precision is going to be impacted by idle in a way this test doesn't understand.
My suggestion would be to go back to the test, pick a more reasonable threshold (+/- 10ms in idle wakeup can be done almost everywhere I'm sure), do the math in ticks and not ms (not a big deal here where the rates are integer multiples, but the nordic and microchip folks will thank you), and see if that works for you.

Never mind, I gave it a quick shot in https://github.com/zephyrproject-rtos/zephyr/pull/47112 .  Works for the emulation platforms, can you see if it addresses the failure on your board?

Never mind, I gave it a quick shot in #47112 . Works for the emulation platforms, can you see if it addresses the failure on your board?

definitely, thanks

Never mind, I gave it a quick shot in #47112 . Works for the emulation platforms, can you see if it addresses the failure on your board?

definitely, thanks

Never mind, I gave it a quick shot in #47112 . Works for the emulation platforms, can you see if it addresses the failure on your board?

definitely. Thanks !

refer to https://github.com/zephyrproject-rtos/zephyr/pull/47112


fix yarn.lock

@sanyatuning , I saw you updated the yarn.lock. I made a PR from your branch and merged it. Thanks!

@sanyatuning , I saw you updated the yarn.lock. I made a PR from your branch and merged it. Thanks!

I forgot to create it...

I forgot to create it...


automate the copyright year at the footer

This little PR makes the footer displaying the current year at the copyright statement. I hope this little change can help. If there are any objections, please let me know.

no this is helpful! thank you!

no this is helpful! thank you!


chore/test:add integration test for alter table options

close: #953

@jiacai2050 I found that the sql test of the document will report an error, whether to add this statement

Also, PR's description should follow our template, you can refer https://github.com/CeresDB/horaedb/pull/1313 if you don't know.
For trivial changes, it' acceptable to not follow, but not this PR.

@jiacai2050 Hello，according to my testing process,
CREATE TABLE `t` (`tsid` uint64 NOT NULL, `t` timestamp NOT NULL, `a` int, PRIMARY KEY(tsid,t), TIMESTAMP KEY(t)) ENGINE=Analytic WITH(arena_block_size='2097152', compaction_strategy='default', compression='ZSTD', enable_ttl='true', num_rows_per_row_group='8192', segment_duration='', storage_format='AUTO', ttl='7d', update_mode='OVERWRITE', write_buffer_size='314572800')

column name cannot be tsid

tsid is a reserved column, user can't create table with this name.

@caicancai Please update PR's description.

@jiacai2050 hello, I have a problem, my cargo test doesn't seem to be able to observe the results of the tests I add, why is cli OK, probably because I am a rust beginner and don't understand this problem. If you have time to help answer, thank you very much

@jiacai2050 hello, I have a problem, my cargo test doesn't seem to be able to observe the results of the tests I add, why is cli OK, probably because I am a rust beginner and don't understand this problem. If you have time to help answer, thank you very much
Hi, the easiest way is to open the CI link and the corresponding configuration file. You can reproduce it using the same instructions.

https://github.com/CeresDB/horaedb/blob/main/.github/workflows/ci.yml#L114
https://github.com/CeresDB/horaedb/actions/runs/7129962607/job/19415252972

@caicancai  By the way, asking questions in closed PRs and issues might not be easy to see (I saw it because I clicked on it by accident). If there's no proper place to ask questions, You can use discussion to ask question https://github.com/CeresDB/horaedb/discussions/categories/q-a

@caicancai By the way, asking questions in closed PRs and issues might not be easy to see (I saw it because I clicked on it by accident). If there's no proper place to ask questions, You can use discussion to ask question https://github.com/CeresDB/horaedb/discussions/categories/q-a

ok，thank you


Vote Kick Started Success cool down

I see too late people have already brought this up, you can close this.
When the bot detector you're running successfully calls a vote, but there are multiple bots on your team, the detector keeps trying to call a vote even though there's a 2 minute cool down. This leaves a prompt on your screen saying you cant call another vote for 2 minutes, 1 minute etc.
A solution would be to add a 2 minute cool down after a successful vote started by your detector and maybe a chat message describing that theres still a bot on the team and that youve already called a vote and cannot call another vote for x amount of time.

I agree it's super annoying because if you mark the bot as a cheater then it constantly keeps annoying u with the cooldown prompt.

I agree it's super annoying because if you mark the bot as a cheater then it constantly keeps annoying u with the cooldown prompt.

Hi, thanks for making this issue. Unfortunately, there are some technical challenges with this, mostly arising from the fact that you can't tell from console output who initiated a vote, and who the votekick is against.
Duplicate of #168.

Hi, thanks for making this issue. Unfortunately, there are some technical challenges with this, mostly arising from the fact that you can't tell from console output who initiated a vote, and who the votekick is against.
Duplicate of #168.


Merge changes in actuation, contact force residual and fix on force derivative for 6d contact loop

Actuation data now requires pinocchio data as input in create data, in order to make actuation model rely on pinocchio calculation
Contact force residual now has a new constructor for contact 6d loop where it takes now the name of the contact and no more a frame id (since for a loop several frames are involved)
Derivatives of contact force for contact loop 6D lacks a minus to be consistent with the definition of the force in the contact

I think this PR should be spitted in several ones:

The fix on the force derivative should definitely be merged to this branch.
Changes on the actuation should be a totally different PR (as it is a different topic and should first be discussed with Nicolas or Carlos)
Changes on the contact force residual could go in this PR

The branch as conflict that prevent merging, you should clean the work tree (by rebasing and/or cherrypicking the correct commits)

@msabbah06 I cherrypicked the fixed on update force to include it in the PR here

@LudovicDeMatteis I normally should have cleaned the working tree. Let me know if I did something wrong


Some grafana expression are wrong or suboptimal

Bug Report

What version of TiKV are you using?
v5.4.0
What operating system and CPU are you using?
Doesn't matter
Steps to reproduce
tiup playground
What did you expect?
Good well defined graph.
What did happened?

Pending task is wrong.
Pending task metrics is a guage instead of a counter, its value should be used directly.
Hitmap in coprocessor is hard to read.
It should use similar settings like Raft IO, which makes zero values transparent and choose more colorful scheme.

And storage panel should also show 99%, 95% and avg graph besides hitmap for both async snapshot and async write .

/type bug
/severity Moderate

"Raft log speed" should be renamed to "Raft propose speed" and the unit should be changed to byte/s.

I suggest to include this into v6.0.0.

@jiayang-zheng PTAL

I will take a look at it.


add IDoc Segment support as part of TABL

IDoc Segment type/definition is just customizing and has no own transport object but it generates a structure and is coupled to it
The segment type/definitions have their own XML at the TABL object

I can't test this with multiple definitions! Does anyone have a Z-IDoc for different releases/definitions?

#1989

suggest adding a new test repo under https://github.com/abapGit-tests

Testrepos:
https://github.com/abapGit-tests/IDOC.git
https://github.com/abapGit-tests/IEXTgit


Any plans to support setting port ranges in the configuration?

After a few tests I think this would be a powerful alternative to FRP.
But I think there're still rooms of improvement, like configuration-wise.
Would be nice to see a port range option like FRP does. (Or is this already implemented but wasn't mentioned in Readme?)

Would be a useful improvment

+1

Can't really use ftp without this one, is the ETA on this one?

+1


error: SSL_connect returned=1 errno=0 state=SSLv3 read server hello A: sslv3 alert handshake failure

Please share what is the root cause of this issue,most of the blogs are telling, this is  an issue with OpenSSL verion.

I'm experiencing this too now. I had downloaded cacert.pem and added it to the path as instructed in https://gist.github.com/fnichol/867550 , it doesn't work for me
require "mechanize"
URL= 'https://google.com'
m = Mechanize.new
page=m.get URL
page=m.get URL
# https://google.com is used as an example because not all sites would throw an error. https://example.com would be just fine.
# A site that I was scraping on throws the same error as Google do

Pasting the above code into irb would resulting in the 4th line throwing an error, and the 5th line works just fine
irb(main):004:0> page=m.get URL
OpenSSL::SSL::SSLError: SSL_connect SYSCALL returned=5 errno=0 state=SSLv2/v3 read server hello A
        from C:/RailsInstaller/Ruby2.1.0/lib/ruby/2.1.0/net/http.rb:920:in `connect'
        from C:/RailsInstaller/Ruby2.1.0/lib/ruby/2.1.0/net/http.rb:920:in `block in connect'
        from C:/RailsInstaller/Ruby2.1.0/lib/ruby/2.1.0/timeout.rb:76:in `timeout'
        from C:/RailsInstaller/Ruby2.1.0/lib/ruby/2.1.0/net/http.rb:920:in `connect'
        from C:/RailsInstaller/Ruby2.1.0/lib/ruby/2.1.0/net/http.rb:863:in `do_start'
        from C:/RailsInstaller/Ruby2.1.0/lib/ruby/2.1.0/net/http.rb:858:in `start'
        from C:/RailsInstaller/Ruby2.1.0/lib/ruby/gems/2.1.0/gems/net-http-persistent-2.9.4/lib/net/http/persistent.rb:700:in `start'
        from C:/RailsInstaller/Ruby2.1.0/lib/ruby/gems/2.1.0/gems/net-http-persistent-2.9.4/lib/net/http/persistent.rb:631:in `connection_for'
        from C:/RailsInstaller/Ruby2.1.0/lib/ruby/gems/2.1.0/gems/net-http-persistent-2.9.4/lib/net/http/persistent.rb:994:in `request'
        from C:/RailsInstaller/Ruby2.1.0/lib/ruby/gems/2.1.0/gems/mechanize-2.7.3/lib/mechanize/http/agent.rb:259:in `fetch'
        from C:/RailsInstaller/Ruby2.1.0/lib/ruby/gems/2.1.0/gems/mechanize-2.7.3/lib/mechanize.rb:440:in `get'
        from (irb):4
        from C:/RailsInstaller/Ruby2.1.0/bin/irb:11:in `<main>'
irb(main):005:0> page=m.get URL
=> #<Mechanize::Page
 {url
  #<URI::HTTPS:0x42077d0 URL:https://www.google.co.id/?gws_rd=cr&ei=2UImVZ_4Oce2uATn1oC4DQ>}
 {meta_refresh}
 {title "Google"}
 {iframes}
 {frames}
 {links
  #<Mechanize::Page::Link

I'm on Windows 10 TP x64, RailsInstaller 3.1.0 (ruby 2.1.5p273 (2014-11-13 revision 48405) [i386-mingw32]), mechanize 2.7.3