[util] Correctly cope with patch_dir and no mapping in vendor.py

This was broken with my recent patch to add "mapping" support. The fix
passes a boolean flag to Mapping1.make_default saying "please add a
relative patch directory of '.' to the dummy mapping entry you make".
This patch also fixes how we run "git apply" to apply the patches.
It turns out that if you run
cd subdir/in/repo
git apply my.patch

then the paths in my_path are interpreted relative to the root of the
repository (and anything that applies to a file outside of
subdir/in/repo is skipped).
Before the recent vendoring changes, we applied the patches before
copying into the target repository. So it was something like
git clone git://something /tmp/something
(cd /tmp/something; git apply -p1 /path/to/my.patch)
cp /tmp/something/* vendor/something

I'm not sure this would work with only_subdir, but it definitely did
work correctly if we were copying from the top of the vendored repo.
The recent vendoring changes alter things to:
git clone git://something /tmp/something
cp /tmp/something/* vendor/something
(cd vendor/something; git apply -p1 /path/to/my.patch)

This doesn't do what you want, because the paths in the patch look
like a/myfile.c rather than a/vendor/something/myfile.c (and the hunks
all get skipped).
We can fix things up again by using the --directory argument to git
apply, which works a bit like you might expect changing directory to
vendor/something would work and changes how the patch paths are
interpreted.

(force-push adds the missing sign-off line)

LGTM.
Side comment: I missed in the previous review that you turned around the order in which the files are copied and applied. Applying the patches first, and then copying/moving the resulting tree is beneficial if the patching fails, as it doesn't leave a half-finished import around in the target directory.

Hi @imphil, I think we actually discussed the ordering in the previous review (and then on Zulip, IIRC). I believed it had to go that way around because I thought we were applying patches to the whole lot, rather than "per mapping item". We changed the design afterwards, and I didn't realise we could do it the other way round again.
I'm not sure what behaviour I prefer though: this is a git tree, so trashing the working tree isn't really an issue. It might also be easier to debug than trashing a temporary directory that gets cleaned up. It definitely made debugging Sam's issue much easier than it would have been otherwise. If you feel strongly that things should go back to the other order, feel free to open an issue and I'll get on it.

Nah, all good. The current setup works, there's no need to do it differently at this point beyond hypothetical discussions.


BUG: iloc fails with non lex-sorted MultiIndex

Code Sample, a copy-pastable example if possible
import pandas as pd
import numpy as np
ind = [
        ['AA','AA','AA','BB','BB'],
        ['A' ,'B' ,'B' ,'a' ,'b']
]
ind_nonLex = [
        ['CC','CC','CC','BB','BB'],
        ['A' ,'B' ,'B' ,'a' ,'b']
]

strCol=pd.DataFrame([['fooA'],['fooB'],['fooC'],['fooD'],['fooE']])

dat=np.arange(1,26).reshape(5,5)
df=pd.concat([strCol, pd.DataFrame(dat)], axis=1)
df1=pd.DataFrame(df.values, index=ind_nonLex)
df2=pd.DataFrame(df.values, index=ind)

df1 (whose index is not lex sorted) fails with iloc access:
>>> df1.iloc[0,0]
C:\Users\rikuhiro\Anaconda3\envs\pd-check\lib\site-packages\ipykernel\__main__.py:1: PerformanceWarning: indexing past lexsort depth may impact performance.
  if __name__ == '__main__':
---------------------------------------------------------------------------
AttributeError                            Traceback (most recent call last)
<ipython-input-37-884ae2904642> in <module>()
----> 1 df1.iloc[0,0]

C:\Users\rikuhiro\Anaconda3\envs\pd-check\lib\site-packages\pandas\core\indexing.py in __getitem__(self, key)
   1292
   1293         if type(key) is tuple:
-> 1294             return self._getitem_tuple(key)
   1295         else:
   1296             return self._getitem_axis(key, axis=0)

C:\Users\rikuhiro\Anaconda3\envs\pd-check\lib\site-packages\pandas\core\indexing.py in _getitem_tuple(self, tup)
   1561
   1562             # if the dim was reduced, then pass a lower-dim the next time
-> 1563             if retval.ndim < self.ndim:
   1564                 axis -= 1
   1565

AttributeError: 'str' object has no attribute 'ndim'

Expected Output
df2 (whose index is lex sorted) works as expected:
>>> df2.iloc[0,0]
'fooA'

This attributeError does not occur when the DataFrame.values consist of numpy objects (e.g. numpy.int32) because they have the ndim attribute. (Although the performance warning remains, it may be another issue).
I found that the addition of an if statement can remedy this in pandas/core/indexing.py. This just makes the _getitem_tuple(self, tup) be aware of objects without the ndim attribute, as _getitem_nested_tuple(self, tup) is (I will prepare a pull request if it is helpful.)
 @@ -1569,6 +1569,10 @@ def _getitem_tuple(self, tup):
              retval = getattr(retval, self.name)._getitem_axis(key, axis=axis)

 +            # if we have a scalar, we are done
 +            if lib.isscalar(retval) or not hasattr(retval, 'ndim'):
 +                break
 +
              # if the dim was reduced, then pass a lower-dim the next time
              if retval.ndim < self.ndim:
                  axis -= 1

output of pd.show_versions()
>>> pd.show_versions()
INSTALLED VERSIONS
------------------
commit: None
python: 3.5.2.final.0
python-bits: 64
OS: Windows
OS-release: 10
machine: AMD64
processor: Intel64 Family 6 Model 58 Stepping 9, GenuineIntel
byteorder: little
LC_ALL: None
LANG: None

pandas: 0.18.1
nose: None
pip: 8.1.2
setuptools: 23.0.0
Cython: None
numpy: 1.11.1
scipy: None
statsmodels: None
xarray: None
IPython: 5.0.0
sphinx: None
patsy: None
dateutil: 2.5.3
pytz: 2016.6.1
blosc: None
bottleneck: None
tables: None
numexpr: None
matplotlib: None
openpyxl: None
xlrd: None
xlwt: None
xlsxwriter: None
lxml: None
bs4: None
html5lib: None
httplib2: None
apiclient: None
sqlalchemy: None
pymysql: None
psycopg2: None
jinja2: 2.8
boto: None
pandas_datareader: None

@YG-Riku actually the fix should start here
.iloc should not hit the MultiIndex branch testing at all. If you want to give this a try would be great.

@jreback
Thank you very much for your response.
That's the point where I stumbled on too. Just commenting out the lines:
#        ax0 = self.obj._get_axis(0)
#        if isinstance(ax0, MultiIndex):
#            result = self._handle_lowerdim_multi_index_axis0(tup)
#            if result is not None:
#                return result

diminishes the error (and the warning too). But I am not sure about the consequence of this removal of the codes (any side-effect?).

almost certainly needs to be more selective
eg dispatch on self.name == 'iloc'
lots and lots of indexing tests must still pass

I think I can do some trials-and-errors with the existing test cases of pandas/tests. But if there is a need to prepare a decent set of new test codes, that will be too much burden for me. (Anyway, I will start looking into the test cases ... )

no as I said there are hundreds of tests already
you can just add this case

Thank you for the comment. I will try. It is exciting to have a chance to contribute!. (But, please don't wait for me. Probably the time I can spare for this would be mostly on weekends.)

I found that the following simple amendment works as jreback suggested.
This passed nosetests pandas/tests/test_multilevel.py and no significant performance change was detected (at least in some trial).
@@ -903,7 +903,7 @@ class _NDFrameIndexer(object):

         # we maybe be using a tuple to represent multiple dimensions here
         ax0 = self.obj._get_axis(0)
-        if isinstance(ax0, MultiIndex):
+        if isinstance(ax0, MultiIndex) and self.name != 'iloc':
             result = self._handle_lowerdim_multi_index_axis0(tup)
             if result is not None:
                 return result

What is the next step?

you submit a PR with tests and the fix
see here: http://pandas.pydata.org/pandas-docs/stable/contributing.html


3750 update Rust code to incorporate Clippy warnings for code style

Make sure you have checked all steps below.
Issue
Closes 3750
Tests
My PR updates several tests with Clippy warning suppressions, or adopting Clippy warnings.

Thanks very much! I'll update the "Rust Lint" workflow with the settings you suggested.
In the future please could you link to the issue with a hyperlink and a "Resolves" next to it as shown in the pull request template? I had to look up your issue and it won't close when the PR is merged. The template's just to make it easier.


ensure validation doesnt try validate blank location

Coverage decreased (-0.1%) to 88.636% when pulling 835f2615c88583fad781bb98bc76d5a3feb9acae on feature/ensure-that-form-validation-does-not-validate-blank-location into 02b954351f54287bd2dcf06566d8393b3d1d0458 on develop.

Coverage decreased (-0.1%) to 88.647% when pulling aea777c11218dd0f7ef25cdbe200eeae448e4f5d on feature/ensure-that-form-validation-does-not-validate-blank-location into 02b954351f54287bd2dcf06566d8393b3d1d0458 on develop.

Coverage decreased (-0.09%) to 88.657% when pulling 002acb38459d0b478416bcbfc8cb8d7da1479cd9 on feature/ensure-that-form-validation-does-not-validate-blank-location into 02b954351f54287bd2dcf06566d8393b3d1d0458 on develop.

:+1:


One-sided fisher test

Thank you very much for the HighSpeedStats package.
I would like to use the Fisher exact test with alternative="greater"
Is there an easy way to do so?
Thanks in advance.

You can use the phyper function in R base to get one-sided p-values of the FET with a very good perfomance. A nice explanation can be found in Meng's blog post. One should note that phyper only works for one-sided p-values; this was one of the motivations for this package.
I'll try to add this information to the documentation of the package.

Closed with #2


Resampling using polyphase filtering

Now that upfirdn polyphase filtering is implemented, it should be possible to do upfirdn-based resampling. Hopefully this will be faster than the current FFT-based method.
I don't actually know the correct way to do upfirdn-based resampling, but it looks like Octave does [something reasonable] (http://octave.sourceforge.net/signal/function/resample.html) that is similar to [what MATLAB does] (http://www.mathworks.com/help/signal/ref/resample.html). Although I can't work from the Octave's GPL code, I think I could read the book chapter / equations referenced in the GPL code, and work from that:
http://sourceforge.net/p/octave/signal/ci/default/tree/inst/resample.m
Does that sound about right from a licensing standpoint @WarrenWeckesser @rgommers?
@sirtom67 do you have any other starting points (code or suggesting reading) other than Oppenheim and Schafer (Discrete-time signal processing)? I think I have a copy of that book kicking around somewhere...

The matlab resample command just does the following:

design a low-pass FIR filter with the proper cutoff frequency and some
reasonable rules for setting the length to get a filter that isn't too long
call upfirdn
get rid of precursor and postcursor filtering tails to remove delay

IIRC, the matlab command used fir1 with a kaiser window. Similar
functionality exists in scipy.signal.
On Wed, Jan 20, 2016 at 12:43 PM, Eric Larson<EMAIL_ADDRESS>wrote:

Now that upfirdn polyphase filtering is implemented, it should be possible
to do upfirdn-based resampling. Hopefully this will be faster than the
current FFT-based method.
I don't actually know the correct way to do upfirdn-based resampling, but
it looks like Octave does something reasonable
http://octave.sourceforge.net/signal/function/resample.html that is
similar to what MATLAB does
http://www.mathworks.com/help/signal/ref/resample.html. Although I
can't work from the Octave's GPL code, I think I could read the book
chapter / equations referenced in the GPL code, and work from that:
http://sourceforge.net/p/octave/signal/ci/default/tree/inst/resample.m
Does that sound about right from a licensing standpoint @WarrenWeckesser
https://github.com/WarrenWeckesser @rgommers
https://github.com/rgommers?
@sirtom67 https://github.com/sirtom67 do you have any other starting
points (code or suggesting reading) other than Oppenheim and Schafer
(Discrete-time signal processing)? I think I have a copy of that book
kicking around somewhere...
—
Reply to this email directly or view it on GitHub
https://github.com/scipy/scipy/issues/5746.

Good to hear, that's what I had gathered from reading the documentation of MATLAB and Octavie. MATLAB apparently uses firls but I remember someone saying (mailing list somewhere?) that firwin or firwin could be used instead in scipy. I'll track down Oppenheim and Shafer to get the details right, then.

I don't actually know the correct way to do upfirdn-based resampling, but it looks like Octave does something reasonable that is similar to what MATLAB does. Although I can't work from the Octave's GPL code, I think I could read the book chapter / equations referenced in the GPL code, and work from that:
http://sourceforge.net/p/octave/signal/ci/default/tree/inst/resample.m
Does that sound about right from a licensing standpoint @WarrenWeckesser @rgommers?

Sorry, seeing the question only now. Yes, that's perfectly fine.


CalendarApi: EventExtendedProperties.fromJson still not Dart2 clean

With 0.50.1:
type '_InternalLinkedHashMap<String, dynamic>' is not a subtype of type 'Map<String, String>' where
  _InternalLinkedHashMap is from dart:collection
  String is from dart:core
  Map is from dart:core
  String is from dart:core
  String is from dart:core

#0      new EventExtendedProperties.fromJson (package:googleapis/calendar/v3.dart:4162:22)
#1      new Event.fromJson (package:googleapis/calendar/v3.dart:4635:15)
#2      new Events.fromJson.<anonymous closure> (package:googleapis/calendar/v3.dart:5163:38)
#3      MappedListIterable.elementAt (dart:_internal/iterable.dart:414:29)
#4      ListIterable.toList (dart:_internal/iterable.dart:219:19)
#5      new Events.fromJson (package:googleapis/calendar/v3.dart:5164:12)
#6      EventsResourceApi.list.<anonymous closure> (package:googleapis/calendar/v3.dart:1996:41)
#7      _RootZone.runUnary (dart:async/zone.dart:1381:54)
#8      _FutureListener.handleValue (dart:async/future_impl.dart:129:18)
#9      <…>

@jakobr-google was looking into this iirc.

Yep. Unfortunately, we only get these errors at runtime, so we pretty much have to catch and fix them one by one.
I'll look into this one.

I'll track all the Dart 2 issues in #35.


ls can be slow

this seems primary to our use of Date.toLocaleString; as of this writing, we are calling it twice. we could at least call it only once. it takes about 135ms (on my 2019 macbook pro) for each call, for en_US locale, at least.
we could also use something like https://github.com/gosquared/speed-date which is probably 100x faster (seriously; probably < 1ms compared to 135ms per call), at the expense of loosing i18n. is it important to have ls output dates internationalized, for this level of performance penalty?

i will modify to remove the double-call; but i think i'll also try out speed-date. i'll leave the toLocaleString (single call) impl there, for future reference


Fix BigQuery query template to retrieve training data

Previous BigQuery query template used by DatasetService to retrieve training data has some errors for e.g. it creates query like
# mygcpproject.mydataset.mycolumn is not a valid column name
SELECT mygcpproject.mydataset.mycolumn FROM mygcpproject.mydataset.mycolumn LIMIT 5

This is a fix to the templates.
Extra notes
How to reproduce this error using Feast Python SDK which will call the DatasetService:

Assuming you have ingested feature: myentity.myfeature with event timestamp between 2019-01-01 and 2019-01-02

# Import details are ommitted
# ...

feature_set = FeatureSet(entity="myentity",
                         features=["myentity.myfeature"])
dataset_info = feast_client.create_dataset(feature_set, "2019-01-01", "2019-01-02")
dataset = fs.download_dataset_to_df(dataset_info, staging_location="gs://mybucket")

/lgtm

/approve

/lgtm


Unable to send message on OSX: SSL_accept error from unknown[<IP_ADDRESS>]: lost connection

Hi,
I am trying to configure the default Mail client on OSX 10.10.5, I can receive emails just fine, but  it fails when sending new messages.
OSX SMTP config:

postfix log:

In turn, on my Android phone, receiving and sending works like a charm. What could be the problem on OSX?

@vedtam you found the issue?

@tomav when I switch my internet connection from landline to mobile (tethered, different ISP) it sends messages without a problem. I will inspect the logs for a few days, hope to find some clues or differences when using one over the other.

Great, thanks.


QPI-04 - Rolling dice

Motivation
The cryptomarket is full of risk taker which really blurs the line between traders/gamblers. Even for derivatives, the CEO of Bitmex has repeatedly say that it caters to gamblers and retail traders.  We dived into the gambling scene to discover tons of gambling talks to bitcointalk. It ranges from dice, sports, to full on casino.   We find that the dice game is simple, addictive, and target the right demographic for our traders.  The dice is discrete game that the user can control their own risk vs reward.  So if the user chooses a dice (from 1-100) for a number under 5, then  his chance of winning is 1 / 0.05  = 20. The house take say 1% of that.  In this proposal, we propose a "roll_dice" operation on the blockchain.
Scope
This would be created as standalone blockchain operation without any coin.
Design
We're going to design a roll_dice with the following parameters.
roll_dice <user> <coin> <risk> <bet>
Parameters:
user: The user rolling
coin: The coin user is taking
risk: The amount of coin the user is risking
bet:  a string that an OR of   traditional | numbers | odd_or_even
traditional - can be less than or greater than "<5" or ">95"
numbers - can be a series of numbers, say "5,8,9,10"
odd_even - can be "odd" or "even"
Only one type of bet can be placed.  The reward is calculated for each case.
Calculate fees
System
The fees  are calculated then sent to a special pool (TBD) and the loss are also sent to a special pool (TBD).  Winnings are taken out from the loss pool.
Randomness function / fairness
We want to produce an unpredictable randomness that is tamper proof even for block producer.  Leveraging from (1), we can provide a randomness function
n = sha3(prev, seed=current_bet)
References

https://cryptogambling.org/whitepapers/provably-fair-algorithms.pdf
https://bitcointalk.org/index.php?board=56.0
primedice.com
https://github.com/yahoo/coname/blob/master/vrf/vrf.go
https://gist.github.com/alexvandesande/259b4ffb581493ec0a1c

Calculate Fees
risk_per_roll :=
{type: integer
,meaning: This is how much players can choose to pay per dice roll
}
num_faces :=
{type: integer greater than 0
,meaning:  Number of faces on the dice and the number of dices, which is directly equal to the number of possible outcomes.
}
prob_event :=
{type: float valued between 0 and 1
,meaning: The probability of the event that the player is betting on.  The event can be defined as "When dice is rolled 4 and under" or "When the face value is odd".
,calculated_value: This is defined as a function of num_faces
}
fee_rate_per_win:=
{type: float valued larger than 0
,meaning: How much fee the house will take when the player's event comes true
,calculated_value: 1%
}
fee_per_win:=
{type: float valued larger than 0
,meaning: How much fee the house will take when the player's event comes true
,calculated_value: ((1/prob_event)*(fee_rate_per_win))risk_per_roll
}
payout_per_win:=
{type: float valued larger than 0
,meaning: How much the player will win if the event they bet on comes true
,calculated_value: ((1/prob_event)(1-fee_rate_per_win)) *risk_per_roll
}


Some suggestions and capitalised a few words

I read through this (very nice btw) and went through and capitalised a few words and added some punctuation etc. Feel free to ignore it and just close it if it's not relevant.

One thing though - you may notice that one of the checks failed. This is because we now require code changes to be formatted with the Stylua tool.
Let me know if you need help running your changes through.


#5509: Add ternary ops to ttnn

Add support for ternary ops to ttnn
Sweep Test Results:
addcdiv.csv
addcmul.csv
arange.csv
mac.csv
where.csv

Slow Dispatch Test: https://github.com/tenstorrent-metal/tt-metal/actions/runs/7985990013
Fast Dispatch Test: https://github.com/tenstorrent-metal/tt-metal/actions/runs/7985988863

Modified the following:
Moved arange from ternary to creation
Added device argument for arange op
Added tensor validation condition for all inputs


chore: use yarn to publish NPM packages

Description

Problem*

Resolves #2819
Summary*
This PR uses yarn to publish our NPM packages so we correctly rewrite the workspace dependencies.
Documentation

[ ] This PR requires documentation updates when merged.

[ ] I will submit a noir-lang/docs PR.

[ ] I will request for and support Dev Rel's help in documenting this PR.

Additional Context

PR Checklist*

[x] I have tested the changes locally.
[x] I have formatted the changes with Prettier and/or cargo fmt on default settings.

See relevant code which rewrites the workspace dependencies https://github.com/yarnpkg/berry/blob/4ccec8074cbbc167871e443ad5a62161310df1cc/packages/plugin-pack/sources/index.ts#L67-L75


Restrict Security Groups - UIUX

We must not allow open access (<IP_ADDRESS>) to common ports via security groups.
https://jaas.gsfc.nasa.gov/servicedesk/customer/portal/2/GSD-3779
This is a 2 part ticket:

Cleanup unused security groups - there are many, many security groups across all of our accounts. We must clean up un-used security groups in all unity accounts. Please find your security groups not in use and delete them. Some notes: We should not be using "lunch wizard" security groups. Security groups should have a name- groups without a name will be deleted/removed. Please use the TAGS for all resources- including security groups.

Remove unrestricted access to common ports via security groups. no unfettered access to your applications. This means locking down access to load balancers to the API gateway and the HTTPd proxies, most likely. Internal traffic should be limited to the VPC.
Please reach out to me for any questions or concerns.

This is a priority to cleanup and fix. The fixes should be ready and deployed in ALL ACCOUNTS by the end of Sprint 4.

also see security info: https://github.com/orgs/unity-sds/projects/3/views/34

done
in progress

Needs a meeting with Brandon


Add 'id' field to GraphQL queries for improved data retrieval

Enhance various GraphQL queries by adding an 'id' field to improve data retrieval and facilitate better data handling.

Summary by CodeRabbit

New Features

Enhanced GraphQL queries to include additional id fields for assets and tokens, improving data detail and identification.
Updated queries include GetGlobalRebalances, GetUsersActivity, GetVaults, and GetVault, ensuring consistency across various entities.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Please upload report for BASE (dev@e761d74). Learn more about missing BASE report.

Additional details and impacted files
@@          Coverage Diff           @@
##             dev     #558   +/-   ##
======================================
  Coverage       ?   70.22%
======================================
  Files          ?       25
  Lines          ?      262
  Branches       ?       19
======================================
  Hits           ?      184
  Misses         ?       77
  Partials       ?        1

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Fix universal linking not working on android 12.

I still has the issue.
Is there any change I need to do in maker start app?
Please advise.
Thanks a lot.


Ownership of library

As with purescript-contrib/purescript-handlebars#2, would you mind taking this one back too?
Thanks!

@wfaler Any thoughts on maintaining this?

Forked it back.

@wfaler could you move this and purescript-handlebars back rather than fork it back? That way it will still work for people installing via bower. Thanks! (You should have permission to do so).

I've updated this for 0.7, and I'm happy to take over maintainership if need be. After spending a bit of time with it today, Sammy is quite nice :)


How to use Flurry for WatchOS3

I can't find any official document on how to integrate Flurry for watchOS3. Also in the document it mention to include SystemConfiguration framework but WatchOS never have this framework included.

@coolioxlr pardon the late reply. Our WatchOS implementation is for Watch extensions only at this point. We will be re-evaluating this in the future.


EmblaOptionsType doesn't exists in React

Bug is related to

[ ] embla-carousel (core package)
[x] embla-carousel-react
[x] embla-carousel-vue
[x] embla-carousel-svelte
[ ] embla-carousel-autoplay
[ ] embla-carousel-auto-height
[ ] embla-carousel-class-names
[ ] embla-carousel-docs (documentation)
[ ] embla-carousel-docs (generator)

Embla Carousel version

v8.0.0-rc15

Describe the bug
Since version v8.0.0-rc15,  ESLint says that the SliderPropsOptions type does not have a loop property. This happens to all properties that are in EmblaOptionsType:

Also because of this, useEmblaCarousel has the options argument type Partial<OptionsType> | undefined instead of EmblaOptionsType | undefined, which causes a linter error:

Thanks @proninyaroslav,
I’ve noted this bug and already started working on it. However, thanks for creating a bug report so I can connect it to a pull request and devs can track it 👍🏻.
Best,
David

@proninyaroslav a bug fix for this was just released in v8.0.0-rc16. Try it out and let me know if it's working as expected.

@davidjerleke
Updated to v8.0.0-rc17 and still have this problem.

@proninyaroslav then I suggest you create a CodeSandbox with your setup in order to demonstrate the problem. You didn’t provide one in your bug report but it’s a requirement as mentioned in the contribution guidelines.

@proninyaroslav I think it's better to get the types directly from the main package. Because embla-carousel is a dependency, you can do this:
import { EmblaOptionsType } from 'embla-carousel'; // Get it like so
import useEmblaCarousel from 'embla-carousel-react';

I will remove the type re-exports from the library wrappers like embla-carousel-react, embla-carousel-vue etc. and recommend this approach in the docs.
Best,
David

The problem seems to have popped up again in 8.0.0-rc17

@KingBael09 please read my comment here.

@davidjerleke
How can I apply EmblaOptionsType in case of SliderPropsOptions? It extends EmblaOptionsType, but it itself is not exported.

@davidjerleke
It works, thank you.

@proninyaroslav you should use EmblaOptionsType which is a partial type and not the internal exhaustive definition. Because you don’t want to pass all options every time you want to customize the carousel. Instead, you should only pass the options that aren’t default.

@KingBael09 please read my comment here.

Oh my bad. Thanks for pointing out.

Turns out, this approach doesn’t work with pnpm so I need to solve this differently. Stay tuned.

@div-cowboy, @proninyaroslav. I've added examples of how to import types to the docs. There's also information about how to do it with pnpm:

api/options
api/methods
api/events
api/plugins

[!IMPORTANT]
Remember to switch to the React tab if you're using embla-carousel-react etc.

With bun and shadcn for "embla-carousel-react": "^8.1.7",,
eslint (es2024) gives EmblaCarouselType not found in 'embla-carousel'eslint[import/named] when import { EmblaCarouselType } from "embla-carousel";.

But no complain if import type { EmblaCarouselType } from "embla-carousel";
Should I

install embla-carousel as a devDependency

as pnpm?

@suiboli314 yes, as the docs says:


Fail to update fileSystemInfo with Create an upload session

Category

[ ] Question
[ ] Documentation issue
[x] Bug

Fail to update fileSystemInfo with Create an upload session

No request body is required. However, you can specify an item property in the request body, providing additional data about the file being uploaded.

Request body
{
   "item":{
      "fileSystemInfo":{
         "lastModifiedDateTime":"2009-09-09T09:09:09Z"
      }
   }
}

ODB
http code: 400
error message: The request is malformed or incorrect.

ODP
Successfully uploaded, but fileSystemInfo is not updated.
Thank you.
[ ]: http://aka.ms/onedrive-api-issues
[x]: http://aka.ms/onedrive-api-issues

Could you please provide more information?   I'll tag so our bot fills in what would be needed to look at this further.

Hi @chackman,
Thank you for reply, and here is your information.
Could you please provide the following response headers:

Date (in UTC, please)
Tue, 20 Oct 2020 02:42:44 GMT
request-id
0061859f-30ca-b000-e515-be19842756ee
SPRequestGuid (for requests made to OneDrive for Business)
0061859f-30ca-b000-e515-be19842756ee

Could you please describe the steps to reproduce the bug in sufficient detail for another person to be able to reproduce it?
Use following create session API in ODB
Could you please provide sample requests and responses that illustrate the issue that you are encountering?
POST /_api/v2.0/drives/<drive id>/items/<parent_id>:/<file_name>:/createUploadSession
{
   "item":{
      "@odata.type":"microsoft.graph.driveItemUploadableProperties",
      "fileSystemInfo":{
         "lastModifiedDateTime":"2020-09-09T09:09:09Z"
      }
   }
}

Could you please describe the behavior you expected to occur when performing the action?

I expect this upload session should be created,
After file uploaded, fileSystemInfo should be applied also.

Are there any updates?
Thank alot!

Could you please ensure that the content type on your request is application/json? It appears that the content type provided in the request was an invalid content type.

Hi @chackman
Thanks for reply.
I did miss the  application/json header in requset, and now it works fine.
Additionally, is it possible to have the same behavoir (update fileSystemInfo in upload request) in single upload request?
Because for small files, this will be a efficient option.
Thanks!

That scenario is currently not supported, this is good feedback. Please use the OneDrive Developer Platform UserVoice at http://aka.ms/od-dev-uservoice, or the SharePoint Developer Platform UserVoice at http://aka.ms/sp-dev-uservoice to voice this feature.


Chain custom validation

Describe the bug
Question (not a bug): Is it possible to chain custom validators to the original core validator?
In particular I have written a new "format" validator to trap 'date-time' and 'date' formats and record them (for later data conversion). I would like to then delegate the validation  to the original 'FormatValidator' behaviour for validation against other well-known formats.
To Reproduce
Steps to reproduce the behavior:

Create a 'format' validator as per https://github.com/openapi4j/openapi4j/tree/master/openapi-schema-validator
Validate a body with invalid values with respect to the 'format' value.

Hi,
There is no way to access core validators.
I suggest to declare a new keyword (x-date for example) in your Document Description for your specific needs then format keyword can be processed normally.

Unfortunately I have no control over the spec files. Although I could iterate the parsed schema and modify it in memory to add the extensions.
I think supporting custom formats without spec modification is desirable. The spec supports custom formats - so validating the added custom formats in addition to the standard ones will be a common use case.  Validating keywords other than 'format' will also likely want to fall back to the 'stock' validator after performing the overloaded operation. (e.g I will want to trap all 'type' keywords, but I would prefer to not re-implement the typevalidator).
Can the 'validate' function of the custom validator simply return a boolean which indicates whether openapi4j should proceed onto the core validator after processing?
I can imagine you may want a 'preValidate' and 'postValidate' hook as well(?). The validation hooks are what differentiate openapi4j from other validators so it would be good to make them powerful. But at the least - a boolean which controls the chaining to the core validator would be sufficient.

I implemented a chaining behaviour for validators.
Now validate method returns a boolean to break or continue the chain.
You can have a look at the updated README.md for further info.
Are you able to validate this in latest 0.8-SNAPSHOT?
Thanks

Thanks for the changes. I gave them a quick test and it appears to be working.
Another approach could be to pass the next validator in the chain to the validation function as a parameter. The custom validation function can then choose to call the next one or not. It would allow it to post process the validation results, e.g strip out certain errors from core validators. It does put the onus on the custom function to chain correctly however.
But the boolean return approach is likely to be adequate 90% of the time.


Cleanup Nomad job handling and drivers

The sudden restarts we are sometimes experiencing may be connected to how we are using Nomad. This PR should improve that.

I need to finish checking some possibel problems with deleting sandboxes here.


Update acceptable values for HG converter indicator

As an ECMPS user, I need the ability to leave HG converter indicator field null/blank so that the value is correct for any new component except for that of Hg Analyzers
Acceptance Criteria:
Given I am an ECMPS user logged in
When I am creating a new System Component (System)
Then I have the option to pick from 1, 0 or null for HG converter indicator field
Note: Change the existing radio-button field to a dropdown for HG converter indicator field


Option for smaller Popover

Good evening!
I have used your app for a while, and really like it! 👏
But I think it could benefit from allowing the user from choosing a smaller popover, and thus creating this PR.

I only added English and Portuguese versions so far, though. If you are interested, feel free to tell me the additional translations or changes before squashing the commits.

Looks good, thank you for your contribution! I'll review it a bit later

Hmm I think I found a bug too which doesn't seem to happen all the time. Sometimes, if you pick a song while the popover is open, it will mess up the picture or the time, or not show anything at all. Seems to happen with either popup. Can you replicate the issue? Let me know if it was somehow introduced with this PR.
In the following picture you can see that it's playing a different song but using the picture from a song I played before.


Hilarious "bug" feeding :D

How to feed himself so that all the food is gone in 1 ball? without changing commands ejectSize , ejectSizeLoss and playerMaxCells (without increasing the value of these command)
Example 1
Example 2

That's self-feeding, it's not a bug. Example 1 has 500 cells, which is why the cell gets fed so fast.

Yes, you need to center your mouse on the piece you would like to feed while splitting and ejecting at the same time so something like that could happen, but it might not work correctly due to cells switching order on multi split


[Bug]: extremely slow vscode type intellisense

Minimal, reproducible example
create a app with following dependencies:
"dependencies": {
    "@tsconfig/node18": "^18.2.0",
    "@types/node": "^20.4.1",
    "puppeteer": "^20.8.1",
    "ts-node": "^10.9.1",
    "typescript": "^5.1.6"
  }

create a app.ts file like this
import { launch } from 'puppeteer';

open type definition for launch using Go to Definition.
go to type definition for PuppeteerLaunchOptions using Go to Definition.
now you got a completely hanged vscode
Error string
no error
Bug behavior

[ ] Flaky
[ ] PDF

Background
No response
Expectation
normal vscode type intellisense
Reality
slow and non-stable vscode type intellisense
Puppeteer configuration
No response
Puppeteer version
20.8.1
Node version
18.16.0
Package manager
npm
Package manager version
9.5.1
Operating system
Linux

It is blazingly fast for me in vscode. Sounds like a VSCode issue?

@OrKoN maybe. but i have this problem only with puppeteer package in my project.
i'll continue investigating this


Support for Shouldly

Not a problem, just my preference to use Shouldly instead of the usual Assert. expressions. Now I have to replace all Assert.That with the much nicer to read Should.Throw<>() etc.
Describe the solution you'd like
Would be nice to be able to select Shouldly as option for the generated Asserts.

I can add that - seems pretty similar to FluentAssertions 👍
Thanks for the idea

So ^ is a first pass - I think it does what you'd want. I haven't added examples to the docs yet, and some bits are a little rough (like you can select both 'Use FluentAssertions' and 'Use Shouldly' in the options (in which case it would use FluentAssertions). But it should still find & match the option based on existing references in test projects, and you can specify it when creating test projects etc. 👍

You are a quick one, wow. Will check it out asap. Thanks for your efforts and a really useful extension!

I think that is as designed - the generator doesn't inspect the content of methods - so it doesn't know if it should be true or false - so it emits Assert.Fail so you don't end up with an 'accidentally' passing test.
Thanks in advance for the reviews ❤

Understand, will think about it. Good work.


advanced_options_config block is not supported for CLOUD_ARMOR_EDGE

This advanced_options_config block is only supported for CLOUD_ARMOR type.
advanced_options_config {
    json_parsing = var.json_parsing
    log_level    = var.log_level
    dynamic "json_custom_config" {
      for_each = var.json_parsing == "STANDARD" && length(var.json_custom_config_content_types) > 0 ? ["json_custom_config"] : []
      content {
        content_types = var.json_custom_config_content_types
      }
    }
  }

I'm getting the following error when I try to use this module to setup a security policy for CLOUD_ARMOR_EDGE
│ Error: Error creating SecurityPolicy: googleapi: Error 400: Invalid value for field 'resource.advancedOptionsConfig': '{  "jsonCustomConfig": {  }}'. Advanced options for Cloud Armor are currently only supported for security policies with CLOUD_ARMOR type., invalid
I've try to passed in null values for those variables, but its not skipping that block. It's still trying to provision it.

@nhu-nguyen27 can u plz post an example code for edge policy so I can also add a test for it.

Here's how I'm using the module. I'm trying to use CLOUD_ARMOR_EDGE since I want to apply this policy to GCS backend
`module "edge_security_policy" {
source = "GoogleCloudPlatform/cloud-armor/google"
project_id                           = var.gcp_project_id
name                                 = "geolocation-allowlist"
description                          = "Only certain regions can access"
default_rule_action                  = "deny(403)"
type                                 = "CLOUD_ARMOR_EDGE"
layer_7_ddos_defense_enable          = true
layer_7_ddos_defense_rule_visibility = "STANDARD"
these parameters can only be enable in Advanced options for security policies with CLOUD_ARMOR type
trying to set these to null to bypass advanced_options_config block
#json_parsing                         = null
#log_level                            = null
#json_custom_config_content_types =  []
custom_rules = {
allow_specific_regions = {
action   = "allow"
priority = 1
# prod then allow US
# non-prod then allow US and Canada
description = var.env == "production" ? "Only allow from US  : "Only allow from US, Canada"
expression  = var.env == "production" ? "origin.region_code == 'US' || 'CA'" :   "origin.region_code == 'US' || origin.region_code == 'CA'"
}
}
}`

@nhu-nguyen27 Issue will be fixed with PR #39. adaptive_protection_config block is also not supported for edge policies. You can remove layer_7_ddos_defense_enable from your code. Module will ignore this value if policy type is set to CLOUD_ARMOR_EDGE. Thanks for the example.

nope, that didnt work, its still taking in default values and still trying to setup adaptive_protection_config block
my code:
module "edge_security_policy" {
  source = "GoogleCloudPlatform/cloud-armor/google"

  project_id                           = var.gcp_project_id
  name                                 = "geolocation-allowlist"
  description                          = "Only certain regions can access"
  default_rule_action                  = "deny(403)"
  type                                 = "CLOUD_ARMOR_EDGE"
  layer_7_ddos_defense_rule_visibility = "STANDARD"

  custom_rules = {
    allow_specific_regions = {
      action   = "allow"
      priority = 1
      # prod then allow US
      # non-prod then allow US and Canada
      description = var.env == "production" ? "Only allow from US  : "Only allow from US, Canada"
      expression  = var.env == "production" ? "origin.region_code == 'US'" :   "origin.region_code == 'US' || origin.region_code == 'CA'"
    }
  }
}

Terraform plan

module.rx2.module.edge_security_policy.google_compute_security_policy.policy will be created

resource "google_compute_security_policy" "policy" {

description = "Only certain regions can access"

fingerprint = (known after apply)

id          = (known after apply)

name        = "geolocation-allowlist"

project     = "staging-service"

self_link   = (known after apply)

type        = "CLOUD_ARMOR_EDGE"

adaptive_protection_config {

layer_7_ddos_defense_config {

enable          = true
rule_visibility = "STANDARD"
}
}

advanced_options_config {

json_parsing = "DISABLED"

log_level    = "NORMAL"

json_custom_config {

content_types = (known after apply)
}
}

rule {

action      = "allow"

description = "Only allow from US, Canada"

preview     = false

priority    = 1

match {

expr {

expression = "origin.region_code == 'CA' || origin.region_code == 'US'"
}
}
}

rule {

action      = "deny(403)"

description = "Default rule, higher priority overrides it"

preview     = (known after apply)

priority    =<PHONE_NUMBER>

match {

versioned_expr = "SRC_IPS_V1"

config {

src_ip_ranges = [

"*",
]
}
}
}
}

Here message:

│ Error: Error creating SecurityPolicy: googleapi: Error 400: Invalid value for field 'resource.advancedOptionsConfig': '{  "jsonParsing": "DISABLED",  "logLevel": "NORMAL",  "jsonCustomConfig": {  }}'. Advanced options for Cloud Armor are currently only supported for security policies with CLOUD_ARMOR type., invalid
│

Looks like its not really setting variables in adaptive_protection_config block to null but using default values from json_parsing, log_level, and json_custom_config_content_types

Wait for the PR merge. PR review is needed.

@imrannayer any ETA on when the PR #39 will get review and merged to main?

@nhu-nguyen27 done. If it is urgent you can access updated module by pointing to main branch directly. It will be available through terraform registry after the release.

@imrannayer its working now, thank you so much for updating the module!


Fix incorrect unrevoke index

Unrevoke is represented by -1, not 1 as shown in the original documentation. Added the - to show the correct information.

@rdbahm : Thanks for your contribution! The author(s) have been notified to review your proposed change.

#assign:robinharwood
Firstly, thank you for your contribution and dedication to our documentation. I have accepted the merge which will now continue to internal review prior to publishing, the updated article should be live by tomorrow.


Rename node -> nodejs

There is a naming conflict with the node package (Amateur Packet Radio Node Program), and the nodejs binary has been renamed from node to nodejs.

This will break on non-Debian hosts, won't it?  Googling around, it sees like the sanctioned work around here is to install node-legacy on your system(s), rather than forcing the rest of the [non-Debian] node community to support the nodejs path.   See http://stackoverflow.com/questions/21168141/can-not-install-packages-using-node-package-manager-in-ubuntu

Nope.
kieffer@MacBook-Pro-3$ nodejs
-bash: nodejs: command not found


errorMessage.trim() is not a function

Disclaimer: I'm using react-hook-form v5 and react-hook-form-devtools v1 but I think this issue could be still present.
I've got the exception reported in the issue title because what I put as errorMessage is an object and not directly a string.
I do such a thing because I'm using yup validation library and I'm setting default error messages as they suggest as objects in order to include a value to replace in the final error string.
https://github.com/jquense/yup#using-a-custom-locale-dictionary

This works perfectly except the devtool.
Something like replacing this
https://github.com/react-hook-form/devtools/blob/c6ce9453b5ac32d4a6dc2cd2e41b9eaf4133f2b4/src/panelTable.tsx#L216
with
typeof errorMessage === 'string' ? errorMessage.trim() : JSON.stringify(errorMessage))

could probably be effective.

Still present with<EMAIL_ADDRESS>and<EMAIL_ADDRESS>

would like to send a pr?

I just did !


Revert tailwind to v2

What kind of PR is this?:

/kind dependencies fix
What this PR does / why we need it:
Downgraded tailwind from v3 to v2. Due to drift between local and netlify/production builds

What happened?


ARIA Decals don't differentiate Sankey chart nodes or edges

Version
5.1.2
Reproduction link
https://codesandbox.io/s/cranky-silence-tot46?file=/src/index.js
Steps to reproduce
option = {
  aria: {
    enabled: true,
    decal: { show: true }
  },
  ...
}

What is expected?
each color should get its own decal pattern
What is actually happening?
only one decal pattern is used for all nodes and edges throughout the entire chart

Maybe we can improve this along with improved colorBy. In #13788 , we supported colorBy for basic series (but not tree, treemaps, sankey, ...). So perhaps it can be improved along with enhanced colorBy in the future.


Can't compile on OSX Sierra, missing ->st_atim etc.

Full output:
➜  bfs git:(master) make release
cc -D_DEFAULT_SOURCE -D_GNU_SOURCE -DBFS_VERSION=\"0.82-10-gb0216b9\"  -std=c99 -O3 -flto -Wall -DNDEBUG -MD -MP -MF bftw.d -c bftw.c -o bftw.o
cc -D_DEFAULT_SOURCE -D_GNU_SOURCE -DBFS_VERSION=\"0.82-10-gb0216b9\"  -std=c99 -O3 -flto -Wall -DNDEBUG -MD -MP -MF color.d -c color.c -o color.o
cc -D_DEFAULT_SOURCE -D_GNU_SOURCE -DBFS_VERSION=\"0.82-10-gb0216b9\"  -std=c99 -O3 -flto -Wall -DNDEBUG -MD -MP -MF dstring.d -c dstring.c -o dstring.o
cc -D_DEFAULT_SOURCE -D_GNU_SOURCE -DBFS_VERSION=\"0.82-10-gb0216b9\"  -std=c99 -O3 -flto -Wall -DNDEBUG -MD -MP -MF eval.d -c eval.c -o eval.o
cc -D_DEFAULT_SOURCE -D_GNU_SOURCE -DBFS_VERSION=\"0.82-10-gb0216b9\"  -std=c99 -O3 -flto -Wall -DNDEBUG -MD -MP -MF main.d -c main.c -o main.o
cc -D_DEFAULT_SOURCE -D_GNU_SOURCE -DBFS_VERSION=\"0.82-10-gb0216b9\"  -std=c99 -O3 -flto -Wall -DNDEBUG -MD -MP -MF parse.d -c parse.c -o parse.o
cc -D_DEFAULT_SOURCE -D_GNU_SOURCE -DBFS_VERSION=\"0.82-10-gb0216b9\"  -std=c99 -O3 -flto -Wall -DNDEBUG -MD -MP -MF typo.d -c typo.c -o typo.o
eval.c:139:20: error: no member named 'st_atim' in 'struct stat'
                time = &statbuf->st_atim;
                        ~~~~~~~  ^
eval.c:142:20: error: no member named 'st_ctim' in 'struct stat'
                time = &statbuf->st_ctim;
                        ~~~~~~~  ^
eval.c:145:20: error: no member named 'st_mtim' in 'struct stat'
                time = &statbuf->st_mtim;
                        ~~~~~~~  ^
eval.c:175:20: error: no member named 'st_atim' in 'struct stat'
                time = &statbuf->st_atim;
                        ~~~~~~~  ^
eval.c:178:20: error: no member named 'st_ctim' in 'struct stat'
                time = &statbuf->st_ctim;
                        ~~~~~~~  ^
eval.c:181:20: error: no member named 'st_mtim' in 'struct stat'
                time = &statbuf->st_mtim;
                        ~~~~~~~  ^
eval.c:199:40: error: no member named 'st_atim' in 'struct stat'
        time_t diff = timespec_diff(&statbuf->st_atim, &statbuf->st_ctim);
                                     ~~~~~~~  ^
eval.c:199:59: error: no member named 'st_ctim' in 'struct stat'
        time_t diff = timespec_diff(&statbuf->st_atim, &statbuf->st_ctim);
                                                        ~~~~~~~  ^
8 errors generated.
make: *** [eval.o] Error 1
make: *** Waiting for unfinished jobs....
parse.c:724:21: error: no member named 'st_mtim' in 'struct stat'
        expr->reftime = sb.st_mtim;
                        ~~ ^
parse.c:1156:23: error: no member named 'st_atim' in 'struct stat'
                        expr->reftime = sb.st_atim;
                                        ~~ ^
parse.c:1159:23: error: no member named 'st_ctim' in 'struct stat'
                        expr->reftime = sb.st_ctim;
                                        ~~ ^
parse.c:1162:23: error: no member named 'st_mtim' in 'struct stat'
                        expr->reftime = sb.st_mtim;
                                        ~~ ^
4 errors generated.
make: *** [parse.o] Error 1

I don't have access to macOS Sierra, so I can't easily test this.  It used to work, right?  Do you know if the Sierra man pages are online anywhere?

Hmm, seems like macOS exposes these as st_mtimespec instead?  I wonder what happens if you pass -D_POSIX_SOURCE.

From the OSX El Capitan (other laptop) manpage:
     struct stat { /* when _DARWIN_FEATURE_64_BIT_INODE is NOT defined */
         dev_t    st_dev;    /* device inode resides on */
         ino_t    st_ino;    /* inode's number */
         mode_t   st_mode;   /* inode protection mode */
         nlink_t  st_nlink;  /* number of hard links to the file */
         uid_t    st_uid;    /* user-id of owner */
         gid_t    st_gid;    /* group-id of owner */
         dev_t    st_rdev;   /* device type, for special file inode */
         struct timespec st_atimespec;  /* time of last access */
         struct timespec st_mtimespec;  /* time of last data modification */
         struct timespec st_ctimespec;  /* time of last file status change */
         off_t    st_size;   /* file size, in bytes */
         quad_t   st_blocks; /* blocks allocated for file */
         u_long   st_blksize;/* optimal file sys I/O ops blocksize */
         u_long   st_flags;  /* user defined flags for file */
         u_long   st_gen;    /* file generation number */
     };

     However, when the macro _DARWIN_FEATURE_64_BIT_INODE is defined, the stat structure will now be defined as:

     struct stat { /* when _DARWIN_FEATURE_64_BIT_INODE is defined */
         dev_t           st_dev;           /* ID of device containing file */
         mode_t          st_mode;          /* Mode of file (see below) */
         nlink_t         st_nlink;         /* Number of hard links */
         ino_t           st_ino;           /* File serial number */
         uid_t           st_uid;           /* User ID of the file */
         gid_t           st_gid;           /* Group ID of the file */
         dev_t           st_rdev;          /* Device ID */
         struct timespec st_atimespec;     /* time of last access */
         struct timespec st_mtimespec;     /* time of last data modification */
         struct timespec st_ctimespec;     /* time of last status change */
         struct timespec st_birthtimespec; /* time of file creation(birth) */
         off_t           st_size;          /* file size, in bytes */
         blkcnt_t        st_blocks;        /* blocks allocated for file */
         blksize_t       st_blksize;       /* optimal blocksize for I/O */
         uint32_t        st_flags;         /* user defined flags for file */
         uint32_t        st_gen;           /* file generation number */
         int32_t         st_lspare;        /* RESERVED: DO NOT USE! */
         int64_t         st_qspare[2];     /* RESERVED: DO NOT USE! */
     };

     The time-related fields of struct stat are as follows:

     st_atime         Time when file data last accessed.  Changed by the mknod(2), utimes(2) and read(2) system calls.

     st_mtime         Time when file data last modified.  Changed by the mknod(2), utimes(2) and write(2) system calls.

     st_ctime         Time when file status was last changed (inode data modification).  Changed by the chmod(2), chown(2), link(2), mknod(2), rename(2), unlink(2), utimes(2)
                      and write(2) system calls.

     st_birthtime     Time of file creation. Only set once when the file is created. This field is only available in the 64 bit inode variants. On filesystems where birthtime
                      is not available, this field is set to 0 (i.e. epoch).

     The size-related fields of the structures are as follows:

     st_blksize     The optimal I/O block size for the file.

     st_blocks      The actual number of blocks allocated for the file in 512-byte units.  As short symbolic links are stored in the inode, this number may be zero.

     The status information word st_mode has the following bits:

     #define S_IFMT 0170000           /* type of file */
     #define        S_IFIFO  0010000  /* named pipe (fifo) */
     #define        S_IFCHR  0020000  /* character special */
     #define        S_IFDIR  0040000  /* directory */
     #define        S_IFBLK  0060000  /* block special */
     #define        S_IFREG  0100000  /* regular */
     #define        S_IFLNK  0120000  /* symbolic link */
     #define        S_IFSOCK 0140000  /* socket */
     #define        S_IFWHT  0160000  /* whiteout */
     #define S_ISUID 0004000  /* set user id on execution */
     #define S_ISGID 0002000  /* set group id on execution */
     #define S_ISVTX 0001000  /* save swapped text even after use */
     #define S_IRUSR 0000400  /* read permission, owner */
     #define S_IWUSR 0000200  /* write permission, owner */
     #define S_IXUSR 0000100  /* execute/search permission, owner */

sed  -r 's/st_([amc])tim/st_\1timespec/g' eval.c

Fixed those error for OSX, but then I get the following error:
eval.c:802:7: warning: implicit declaration of function 'clock_gettime' is invalid in C99 [-Wimplicit-function-declaration]
                if (clock_gettime(CLOCK_MONOTONIC, &start) != 0) {
                    ^
eval.c:802:21: error: use of undeclared identifier 'CLOCK_MONOTONIC'
                if (clock_gettime(CLOCK_MONOTONIC, &start) != 0) {
                                  ^
eval.c:811:21: error: use of undeclared identifier 'CLOCK_MONOTONIC'
                if (clock_gettime(CLOCK_MONOTONIC, &end) == 0) {
                                  ^
1 warning and 2 errors generated.


Busywork Attack

iCKB is now approaching its final stage before launch: iCKB is undergoing an internal audit, later a formal external audit, then shortly after iCKB will finally launch on mainnet.
Given all this, I'd like to once again document the Busywork Attack and ask for more eyes on it.
This attack works very similarly to the one described in the Standard Deposit section, but it's even simpler.
An attacker who can borrow a big enough capital can simply attack by repeating the following two steps:

Deposit CKB for iCKB in standard deposits.
Exchange iCKB back to CKB.

Depending on the amount of capital used for the attack, this could reduce the quality of the service for everyone, as the only remaining deposits would be those whose maturity date is a bit more far away, so this could hamper the protocol fruition.
When I first analyzed this attack, the project was still named CKB++, I ask forgiveness for quoting my old analys:

Let's say an attacker controls a percentage of the capital stacked in CKB++, let's see how much time a whale/user have to wait and how much interests he loses. Let's assume a 0.3% APR per 180 epochs (which is an over-valuation of what NervosDAO is currently disbursing).

Let's assume the attacker is able to fully control the first available epoch, then he controls 1/180 ~ 0.6% of the funds locked in CKB++, then the whale have to choose a deposit that expires one epoch later and he is blocked for one epoch and he loses less than *0.3%1/180 ~ 0.0017% of interests.

An attacker controls the first available day, then he controls 6/180 ~ 3.33% of the CKB++ total supply, the whale loses 0.3%*6/180 ~ 0.01% of interests.

An attacker controls the first three available days, then he controls 18/180 ~ 10% of the CKB++ total supply, the whale loses 0.3%*180/180 ~ 0.03% of interests.

An attacker controls the first six available days, then he controls 36/180 ~ 20% of the CKB++ total supply, the whale loses 0.3%*36/180 ~ 0.06% of interests.

So basically once CKB++ grows big enough, an attacker can't really do much damage.

Quoting @jordanmack:

I see it as acceptable. It will take a tremendous amount of capital to do minimal damage.

@XuJiandong does all this sound reasonable?

@msjyryxdzzj @jlguochn when you fully understand the iCKB proposal and Scripts, feel free to evaluate this hypothetical attack vector

@msjyryxdzzj moving our discussion from #18 to this issue:

my initial attack would have been resisted by the nervos DAO, but the one you've revised for me since then bypasses this check and can achieve similar attacks

What do you think about the BusyWork Attack?

I think the possible impact of a busy work attack is much lower with enough money.

Hey @msjyryxdzzj, thank you for publicly expressing your interest in iCKB by auditing the proposal and L1 scripts source code as part of the Scalebit external audit, I personally appreciate a lot!! 🙏

I think the possible impact of a busy work attack is much lower with enough money.

Yeah, that's my take too: the impact is limited when the iCKB Pool is big enough :thinking:
I'll keep this issue open as a form of documentation!


Have an option to only show terraform diffs in Github comment

Describe the solution you'd like
Right now, having the action do a run-all plan/apply in a high-level dir outputs a lot of unhelpful text - in our case, we use this action to run a plan on one of our entire repos, which outputs >2000 lines of text, <50 of which are the actual change plan.
It'd be nice to have an only_output_diffs option which would only output everything between Terraform will perform the following actions: and Plan: X to add, X to change, X to destroy.
Describe alternatives you've considered
I can try adding a filter to the output text on our end, but not totally sure how I'd go about doing that since the PR commenting happens in the terragrunt-action script.
EDIT: after poking around a little more, I might be able to add this on our end via an INPUT_POST_EXEC_ env var - would be neat to see this as a built-in feature, though.
Additional context
n/a

For now, I worked around the issue by adding this to the GHA env:
INPUT_POST_EXEC_0: |
            IFS=$'\n'
            local -r log_file="${terragrunt_log_file}"
            local terragrunt_log_content=$(cat "${log_file}")
            local terragrunt_output=$(clean_colors "${terragrunt_log_content}")
            local diffs_only_output=""
            local concat_line=false
            for line in $terragrunt_output; do
              if [[ $line == "Terraform used the selected providers to generate the following execution" ]]; then
                concat_line=true
              fi
              if $concat_line; then
                diffs_only_output="${diffs_only_output}\n${line}"
              fi
              if [[ $line == *"Plan:"* ]]; then
                concat_line=false
              fi
            done
            echo "terragrunt output:"
            echo -e $diffs_only_output 2>&1 | tee "${terragrunt_log_file}"
            IFS=$' \t\n'

Maybe there's a better way to handle it, my bash isn't great but it seems to work


Set up live tests for Search

Also can make a nice ARM template like https://github.com/Azure/azure-sdk-for-js/blob/master/sdk/keyvault/TEST_RESOURCES_README.md

This was done by #8365


Accessing values of the subchart with dash in the name

Continuation of this since that issue is years old at this point. https://github.com/helm/helm/issues/2192
What is the thinking on this?

please post comments in #2192.
I'm not sure what more there is to add here. https://github.com/helm/helm/issues/2192#issuecomment-293739257 explains a workaround, and there is documentation in https://helm.sh/docs/ around this practice.


Custom db table name

Sometimes we need to have a custom DB table name instead of default cuser_cuser. This PR will help in this case.

@tmm hi,
Could you be so kind to take a look?

Hi @v-hunt! Sorry for the delay! Another one of my projects (Notational) just got a ton of traffic so spending most of my time keeping that up. Maybe @ataylor32 is free.

I don't know how I feel about making this a setting. @tmm is the owner of this app, so he should get the final say. The Django documentation says (source):

If you’re starting a new project, it’s highly recommended to set up a custom user model, even if the default User model is sufficient for you.

I think the same is true for this app. Instead of having your custom user model inherit from Django's AbstractUser, have it inherit from AbstractCUser instead:
from cuser.models import AbstractCUser

class User(AbstractCUser):
    pass

Then you can specify the database table name in your custom user model. But if @tmm is OK with this being a cuser setting then that's fine too. I would only suggest documenting this new setting in the same way that the other settings are documented (rather than having a dedicated section in the documentation).


native-comp-deferred-compilation-deny-list obsolete on latest emacs

What's wrong
With emacs master, for example 5e5f5b28e92a3bb927bb03c783c426c6c3baeadc but also earlier and the current straight.el:
■  Warning (initialization): An error occurred while loading ‘/home/benj/.emacs.d/init.el’:

Symbol's value as variable is void: native-comp-deferred-compilation-deny-list

To ensure normal operation, you should investigate and remove the
cause of the error in your initialization file.  Start Emacs with
the ‘--debug-init’ option to view a complete error backtrace.
 ■  Warning (comp): straight.el:5236:33: Warning: ‘native-comp-deferred-compilation-deny-list’ is an obsolete variable (as of 29.1); use ‘native-comp-jit-compilation-deny-list’ instead.
 ■  Warning (comp): straight.el:5234:19: Warning: ‘native-comp-deferred-compilation-deny-list’ is an obsolete variable (as of 29.1); use ‘native-comp-jit-compilation-deny-list’ instead.

I  can fix this by the new variable for the old.

Should be fixed on the "develop"  branch. See #1054


Can't open "Open Folder" in "New Window" when it is in full screen

VSCode Version: 1.28.2
OS Version: Win10 Ver: 1803

Steps to Reproduce:

Go to File and select New Window
This "New WIndow" click to maximize screen
Now when you try to "open a folder" not appear the "Windows File Explorer" or appear very slowly

Does this issue occur when all extensions are disabled?: Yes

This works as expected for me. Can you record a gif and attach it that shows the difference between a maximized window and a non-maximized window? Anything in the console when you open the "Developer: Toggle Developer Tools"?

/needsMoreInfo


[BUG] urlparams is not set properly

Describe the bug
index, source, sourcetype and hostRegex specified in a config files are not properly set as url parameters for http POST request because of the wrong if conditions.
https://github.com/splunk/eventgen/commit/506a9383aaf39ca43f906492f27f0e1c39aa95ed
To Reproduce

Install eventgen as a python package
Set index, source, sourcetype and hostRegex in a config file
Run eventgen

Expected behavior
index, source, sourcetype and hostRegex in the pushed events are the same as specified in the config file
Actual behavior
Default values are used
index => "main"
host => ip of the sender
source = "http-simple"
sourcetype = "unknown-to_small"
Do you run eventgen with SA-eventgen?
No
If you are using eventgen with pip module mode (please complete the following information):

python version: 2.7.14
OS: Redhat
Virtual Env is used: Yes
Eventgen Version 6.3.4

Additional context
In the commit: https://github.com/splunk/eventgen/commit/506a9383aaf39ca43f906492f27f0e1c39aa95ed,
"if index != None:" is replaced by "if not index:"

@knjkmd could you provide the eventgen.conf as well as the sample file? Thanks.

I edit the file for tutorial2.
eventgen_conf.zip

@knjkmd I can reproduce this issue on my local env.  I will fix it later. Thank you.


Introduce factory for leak detection tasks

This change splits off a ProxyLeakTaskFactory from the ProxyLeakTask class
so that scheduling the task is done after its constructor completes. This
prevents publishing the tasks "this" reference during construction.
See "Safe construction techniques" by Brian Goetz.

Coverage decreased (-0.03%) to 76.404% when pulling 7fd5d90927d94b5da4a0f190ed74438b85956712 on abrenk:leak-task-factory into f4494114463b51b358603ad08ea851da0cb88d31 on brettwooldridge:dev.


⚠ File access (beta) has degraded performance

In fbe3102, File access (beta) (https://beta.fyle.uk/file/fish) experienced degraded performance:

HTTP code: 200
Response time: 3015 ms

Resolved: File access (beta) performance has improved in 441bb5d.


Reintroduce Idea: debug hotkey cycling render distance

1.9 to 22w12a Render Distance Hotkey Cycler, and the reason I think it would be good to reintroduce via carpet fixes
Reintroduce the render distance cycling hotkeys post 22w12a. this use to be a feature 1.9 to 22w12a and was removed due to an exploit in relation to seeing entities through walls when holding down either increasing or decreasing ur render distance.
Describe the solution you'd like
I'd like to see the debug cycling render distance hotkeys reintroduced. however, have a option scale depending on context. 0 would be (obviously) the default, and be the disabled option. 1 would reintroduce the feature pre 22w12a, and 2 would reintroduce it, however adding a fix to it. maybe adding a delay would do something? or maybe it would block entity rendering whilst when increasing or decreasing render distance values.

Sorry I don't really make client-side changes in this mod.

aw. maybe blanket tweaks? :D


⚠ Bofrost.be has degraded performance

In e4fa3c1, Bofrost.be (https://www.bofrost.be) experienced degraded performance:

HTTP code: 200
Response time: 2648 ms

Resolved: Bofrost.be performance has improved in 2eb9899.


WebApiToken -> How to check if it worked

Hi,
I need a bit of help to understand if what I did for web api token setup is right.
I setup the last version of the plugin, did the webapitoken setup, restarted the HB instance.
Here is what the log is saying :
[01/06/2021, 18:52:58] [XboxTv] Device: <IP_ADDRESS> Galaxy-Xbox, authenticated and web api enabled.
So I think it has worked, but how do I see the benefits when this is enabled ?
Thanks a lot,

All is described in the readme.

If You successfully authorized, you can switch between the apps.


Pagination on polymorphic relationship field requesting entries with page parameter set to NaN

Link to reproduction
https://github.com/schaschjan/payload-has-many-relationship-pagination-query-issue
Describe the Bug
Then configuring a relationship field with multiple collection relations, entires from the first configured collection are requested as expected, following collections are requested with query parameter page=NaN.
To Reproduce
Start the reproduction environment:
pnpm dev _community

In the posts collection, scroll through the relations select.
Payload Version
main
Adapters and Plugins
No response

Hi, we ran into this bug as well. Merging the associated PR or working out another solution would be highly appreciated @DanRibbens  Thanks a lot for your work on Payload everyone!


python-tools experienced an unexpected exit

python-tools experienced an unexpected exit.
Please consider posting an issue on https://github.com/michaelaquilina/python-tools/issues/new
exit with code 1, signal null

on start...

I'm seeing this as well.


File "C:\Users\indrajeeth\vs\Independence\main.py", line 11, in       from objloader import ObjFile  ImportError: cannot import name 'ObjFile' from 'objloader' (C:\Users\indrajeeth\AppData\Local\Programs\Python\Python310\lib\site-packages\objloader_init_.py)

tried this example https://github.com/kivy/kivy/blob/master/examples/3Drendering/main.py and stuck up with that error

ah my bad didnt saw objfile


Add support to declarative joins [SQLAlchemy]

Just added a few lines of code to allow the "declarative" join definition. Another user created a similar PR but doing "magic" or "smart" joins, but I find the declarative approach clearer. For the test cases I just  removed the manual joins in the select query and added the declarative approach

Thank you for your contribution Agus!

Thank you for doing such a useful package!

Would it be possible to detect that the join is already present and skip it if so? If not, then people need to know that they have to decide which one they use, with the caveat that the filter join is applied only if there is a filter on that related field.

I was digging a bit into this topic, but I think I'd leave it as it is now, if the user joins twice then there will be an error in the query execution later. I tried to come up with an elegant "smart" solution, and I found that SQLAlchemy saves the tables will be joined in an attribute called _setup_joins and there you can just check if the table you're trying to join is already present or not, but this gets a bit more complicated in non-trivial cases, because if you use models that are aliased then the object is not a Table, it's an Alias, so you don't have the same interface and you have to write custom code for each type of valid object to join. This is something I know because I have a use case where I must use an Alias to join the same table twice in different attributes but I don't know any other "advanced" use cases that should also be supported for this smart logic.

One nit picky thing is that I don't love the join_kwargs name, maybe just joins (since you can have multiple)?

Agreed!

I also like that this is backward compatible but we should definitely add something in the docs (yeah I know they could use some love...).
Finally, can we add a link to https://docs.sqlalchemy.org/en/20/core/selectable.html#sqlalchemy.sql.expression.Select.join so that people know what parameters are allowed in the dict?

Yes! Where should I add this docs?


Write up post-mortem for CBC 2020

Post-mortem
Things that don't work:

no way to tell what things are rare, i.e. need writeup

Please don't put an X in for a species count

Add SPECIES/SPUH, etc

Note that things like "Muscovy Duck (Domestic type)" are not countable, so filter

Really a pain to merge data right now

It looks like Total column for Sectors is a number not a formula. Fix to allow additions

All it is possible to figure out who has to file a rare bird report from the Summary,
would be much better to produce a list (in addition to pre-populating forms)

Really want to move back to my pipeline idea, where info for summary can come from
many sources and have different transformations done (e.g. merge, which inserts into species)

Must agree on hotspots to use when entering data to avoid having to manually
merge/max columns later. See e.g. Bruce Barrett and my mixup over Almaden Lakes

https://johnhurleyphd.medium.com/automating-the-christmas-bird-count-redux-9dd308fed225

https://johnhurleyphd.medium.com/automating-the-christmas-bird-count-redux-9dd308fed225


nixStable: 2.3.12 -> 2.3.14

Motivation for this change
Changes: https://github.com/NixOS/nix/compare/2.3.12...2.3.14
Since this is a bugfix release that wasn't pushed to nixpkgs, I
decided to take care of it.
As it's usually done in upload-release.pl[1], I updated the
fallback-paths accordingly and used eval 1678367[2] for this as it was
the last evaluation of Nix with 2.3.12.
Also added a fallback-path for aarch64-darwin as Nix 2.3.14 seems to
support this now[3].
[1] https://github.com/NixOS/nix/blob/2.3-maintenance/maintainers/upload-release.pl
[2] https://hydra.nixos.org/eval/1678367#tabs-still-succeed
[3] https://github.com/NixOS/nix/commit/14262b86cc5825deae095c14553d623af498124c
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
21.11 Release Notes (or backporting 21.05 Relase notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Not sure aarch64-darwin will work with 2.3.12, why can't we bump to 2.3.14?

@domenkozar tbh I don't know. It seems as it was always used the previosu Nix version as fallback, but this might be because upload-release.pl created a release AND updated the Nix expression (without waiting for Hydra). In other words: it might be possible to just use 2.3.14 as fallback, but I'd like @edolstra (or somebody else who feels sufficiently qualified) to confirm.

Result of nixpkgs-review pr 130538 at d0095abc run on aarch64-linux 1

2 packages marked as broken and skipped:

nixui
ovftool

2 packages failed to build:

haskellPackages.update-nix-fetchgit
update-nix-fetchgit

5 packages skipped due to time constraints:

crate2nix
nix-du
nix-index
nix-serve
nixos-install-tools

44 packages built successfully:

bundix
cabal2nix
cachix
dep2nix
dydisnix
fusionInventory
go2nix
haskellPackages.cabal2nix-unstable
haskellPackages.cachix
haskellPackages.hercules-ci-agent
haskellPackages.hercules-ci-cnix-expr
haskellPackages.hercules-ci-cnix-store
haskellPackages.nix-paths
haskellPackages.nvfetcher
hercules-ci-agent
libnixxml
nix (nixStable)
nix-bundle
nix-direnv
nix-doc
nix-pin
nix-plugins
nix-prefetch-bzr
nix-prefetch-cvs
nix-prefetch-docker
nix-prefetch-git
nix-prefetch-hg
nix-prefetch-scripts
nix-prefetch-svn
nix-template
nix-update
nix-update-source
nixStatic
nixos-generators
nixos-shell
nvfetcher
python38Packages.nix-kernel
python38Packages.nixpkgs
python38Packages.pythonix
python39Packages.nix-kernel
python39Packages.nixpkgs
python39Packages.pythonix
vgo2nix
vulnix

Note that build failures may predate this PR, and could be nondeterministic or hardware dependent.
Please exercise your independent judgement. Does something look off? Please file an issue or reach out on IRC.

No, fallback-paths.nix has always been the most recent version (except that I stopped updating it).

@edolstra @domenkozar I see, updated :)
Used paths from https://hydra.nixos.org/eval/1687468 for this.


Added support for repository deploy keys

See: https://developer.atlassian.com/bitbucket/api/2/reference/resource/repositories/{username}/{repo_slug}/deploy-keys

Thanks. 👍


fix: example for updating a bucket retention period

The example at https://docs.influxdata.com/influxdb/v2.0/organizations/buckets/update-bucket/#update-a-buckets-retention-period doesn't work quite right; for this command to work, a duration needs to be provided, and it isn't necessarily nanoseconds. I updated the documentation so that the example will work better.

Thanks, @wbaker85!


Control plane scale up shows misleading error meessage in EKSA cloudstack #1741

Control plane scale up shows misleading error meessage in EKSA cloudstack
Issue #, if available:
1741
Description of changes:
Added a validation check to check for control plane count
Testing (if applicable):
Documentation added/planned (if applicable):
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

/close


(PUP-3962) Test for '.' module directories

Before this test, the spec tests don't include negative tests for module
directories starting with '.'. After this commit, we test for those
types of directories also. This tests the original intention of
PUP-3678.

CLA signed by all contributors.

+1


Testflight v1.0.16 blocks all UI actions for ~10 seconds on load.

When the app gets past the phase of the spinner and loads you into whatever narrow you are in, clicking on the sidebar buttons will not do anything for around ~10 seconds on my phone (iPhone 6s), and then finally all actions will happen at once (as the queue is suddenly able to process events).
This also leads to interesting states such as both sidebars being open at the same time because all the events process quickly together after the physical event.
If you look carefully, you'll notice both sidebars are open.

I saw the exact same thing, so this is reproducible (and super annoying).
@Sam1301 already did a fix that helps with this, I am looking into what else is happening to cause this.
Definitely a new version with these fixes coming in 1-2 days. This is not OK.

@brockwhittaker try the latest TestFlight. It is more of an intermediary/quick fix, that hmmm, behaves inconsistently. In fact, on the test iPhone 5 it does behave badly, but works pretty well in my Simulator on the Macbook.

Closing, as significantly improved (or fixed).
Will be in next TestFlight.


Manage external IP addresses for GKE in Terraform.

This requires GKE 1.29+. Service resources may need to be manually deleted as migration of existing Services to L4-RBS is not supported. This may result in IP address changes.

This change is


llama-cpp: assert that only one of the *Support arguments is true

When experimenting with llama-cpp I experienced a mysterious build error that in the end I tracked down to me setting openclSupport and openblasSupport to true.  To prevent others from this mistake add an assert that complains if more than one of the arguments openclSupport, openblasSupport and rocmSupport is set to true.
Description of changes

Things done

Built on platform(s)

[X] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[X] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[X] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Fixes #272569.

This breaks setting nixpkgs.config.rocmSupport to true.
The assert is hit as openblasSupport is true as well.
Previously one could override the package to set openblasSupport to false to build with rocm. For example with:
final: prev: {

  llama-cpp = prev.llama-cpp.override {
    openblasSupport = !final.config.rocmSupport;
  };
}

This now errors since while the overridden package should be correct, the assert is tripped for prev.llama-cpp which has default openblasSupport as true and rocmSupport as true from nixpkgs.config.rocmSupport.

So just default it to !rocmSupport && !cudaSupport?

That should work


[Bug]: MySQL: Review page: The user is getting only "connection mode" and "database name" fields.

Is there an existing issue for this?

[X] I have searched the existing issues

Description
MySQL: Review page: The user is getting only connection mode and database name fields after the user configures staging also through manage environment.

Steps To Reproduce
Precondition - Assume prod is default env

create a new MySQL Datasource.
Configure staging through manage env

Observe - Only "connection mode" and "database name" fields are coming
Public Sample App
No response
Issue video log
https://www.loom.com/share/978625dd653a4996a117b54bcd16db8b
Version
1.9.6

@AnandShahs123 can you check this behaviour against release and let me know what should be the expected output here?

@ayushpahwa - have checked on release. Here, Connection Mode, Host Address and Database Name i.e all 3 of them should come

Will be fixed with the solution for #20485


CQ button ignored until received traffic appears

When operating with a dummy load, the CQ button is ignored.

The service_CQ() method is not invoked by update_offset_waterfall() which is not invoked by process_FT8_FFT() because the DSP_Flag is not set in loop().
The DSP_Flag will only be set after queue1.available() (defined by record_queue.h in AudioRecordQueue, derived from AudioStream)  returns true which is apparently not happening.

service_CQ() is not invoked by update_offset_waterfall until num_decoded_msg>0 which, without a complete RF chain on prototype, will not happen.

Pressing Tx button is not starting the transmitted CQ message either

In update_offset_waterfall, the conditional expression,
if (num_decoded_msg > 0 && WF_counter == 0) {
was changed to become,
if (WF_counter == 0) {
so that a successful decode is now unnecessary to transmit CQ.

Resolved.


[nnstreamer/apptest] Added dependency: python-numpy & python3-numpy

This commit is to append 'python-numpy' & 'python3-numpy' to installed packages
Self evaluation:

Build test: [ ]Passed [ ]Failed [*]Skipped
Run test: [ ]Passed [ ]Failed [* ]Skipped

Signed-off-by: Dongju Chae<EMAIL_ADDRESS>

:memo: Version: 1.20190225. Thank you for submitting PR #517. Your PR must pass all verificiation processes of cibot before starting a review process from reviewers. If you are new member to join this project, please read manuals in documentation folder and wiki page. In order to monitor a progress status of your PR in more detail, visit http://nnsuite.mooo.com/.

Here is installed package list in nnsuite.mooo.com since Apr-10-2019 22:38
ubuntu@ip-172-31-27-164:~$
ubuntu@ip-172-31-27-164:~$ dpkg -l | grep numpy
ii  python-numpy                               1:1.11.0-1ubuntu1                            amd64        Numerical Python adds a fast array facility to the Python language
ii  python3-numpy                              1:1.11.0-1ubuntu1                            amd64        Fast array facility to the Python 3 language
ubuntu@ip-172-31-27-164:~$


Graphview sidebar size bug

Describe the bug
Sidebar that opens when clicking on a pattern to see the related pattern covers the whole screen when the pattern description is long.
To Reproduce
Steps to reproduce the behavior:

Go to Graphview
Create a Link with a long Description
Click on the Pattern
See your whole screen getting blocked by the Relationsidebar view

Expected behavior
The sidebar should always be the same size and long descriptions should be handled with a linebreak
Screenshots
https://gyazo.com/37f744bd46e03cd11db09d87fc3cb901

fixed in https://github.com/PatternAtlas/pattern-atlas-ui/commit/cc73c914081e1ecbca69938f532f49ad532d134e


Does folder utils need a init.py?

I got ModuleNotFoundError: No module named 'utils.vad' error. And I can't solve it by adding export PYTHONPATH=./, until adding a __init__.py at directory  utils.

Hi, I updated the scripts and added init.py, you may try again.


⚠ Bofrost.be has degraded performance

In f70456d, Bofrost.be (https://www.bofrost.be) experienced degraded performance:

HTTP code: 200
Response time: 839 ms

Resolved: Bofrost.be performance has improved in 5686479 after 37 minutes.


[C#] csproj conditionals break export fields.

Godot version
4.1.1 Stable Mono
System information
Godot v4.1.1.stable.mono - Windows 10.0.19045 - Vulkan (Compatibility) - NVIDIA GeForce GTX 1650 (NVIDIA; <IP_ADDRESS>79) - AMD Ryzen 5 5600G with Radeon Graphics (12 Threads)
Issue description
Attempting to use conditionals in the .csproj seems to break the godot project, which makes exported variables impossible as everything is set to null in the .tres files and they cannot be edited in the inspector at all.
Steps to reproduce

Do something like this in your .csproj:

<Project Sdk="Godot.NET.Sdk/4.1.1">
  <PropertyGroup>
    <TargetFramework>net6.0</TargetFramework>
    <EnableDynamicLoading>true</EnableDynamicLoading>
  </PropertyGroup>

  <PropertyGroup Condition="'$(OS)' == 'Windows_NT'">
    <DefineConstants>WINDOWS</DefineConstants>
    <SteamworksDllPath>./Steamworks/Facepunch.Steamworks.Win64.dll</SteamworksDllPath>
  </PropertyGroup>
  <PropertyGroup Condition="'$(OS)' != 'Windows_NT'">
    <DefineConstants>LINUX</DefineConstants>
    <SteamworksDllPath>./Steamworks/Facepunch.Steamworks.Posix.dll</SteamworksDllPath>
  </PropertyGroup>
  <ItemGroup>
    <Reference Include="Facepunch.Steamworks">
      <HintPath>$(SteamworksDllPath)</HintPath>
    </Reference>
  </ItemGroup>
</Project>

Go into Godot
Create and attach a script with any exported field like this:
[Export] private string something;
Compile
Attempt to edit any of the variables exported in the editor.

Minimal reproduction project
use this to replicate project:
<Project Sdk="Godot.NET.Sdk/4.1.1">
  <PropertyGroup>
    <TargetFramework>net6.0</TargetFramework>
    <EnableDynamicLoading>true</EnableDynamicLoading>
  </PropertyGroup>

  <PropertyGroup Condition="'$(OS)' == 'Windows_NT'">
    <DefineConstants>WINDOWS</DefineConstants>
    <SteamworksDllPath>./Steamworks/Facepunch.Steamworks.Win64.dll</SteamworksDllPath>
  </PropertyGroup>
  <PropertyGroup Condition="'$(OS)' != 'Windows_NT'">
    <DefineConstants>LINUX</DefineConstants>
    <SteamworksDllPath>./Steamworks/Facepunch.Steamworks.Posix.dll</SteamworksDllPath>
  </PropertyGroup>
  <ItemGroup>
    <Reference Include="Facepunch.Steamworks">
      <HintPath>$(SteamworksDllPath)</HintPath>
    </Reference>
  </ItemGroup>
</Project>

The problem is the usage of <DefineConstants> since you are replacing the constants defined by Godot.NET.Sdk.

So this is a duplicate of https://github.com/godotengine/godot/issues/79605.

You shouldn't need to add WINDOWS and LINUX constants, Godot already defines constants for each supported platform (these constants are documented in the C# features page). In this case you'll want to use GODOT_WINDOWS and GODOT_LINUXBSD.
If you meant to add to the existing constants you should be using <DefineConstants>$(DefineConstants);WINDOWS</DefineConstants> instead.


Reset in middle of animation causes collectible to keep size after reset.

If you reset in middle of the pickup animation, the collectible will remain the size it was in animation at the time reset was pressed.
Can this be made so that collectibles also reset to normal size when reset is pressed?

Fixed in commit f079db0.


arch/sim: Add support for preemptive scheduling in the simulator build using ucontext API

Summary
This patch extends the existing functionality by adding a new option : CONFIG_SIM_PREEMPTIBLE. This option
changes the way we are generating timer events in up_hosttime.c by using an external host timer that sends periodic signals to the simulation. Previously the events were sent from the  Idle Task logic by periodically calling up_timer_update. The patch improves this logic by adding an event driven implementation and changes the way we are doing context switching using the ucontext API.
I have another PR opened that is using a different context switching mechanism with sigsetjmp/siglongjmp but this approach doesn't work on SMP configurations.
Impact
The current implementation doesn't affect the existing implementation when CONFIG_SIM_PREEMPTIBLE=n.
Testing
I validated the patch using sim/ostest config on both MacOS and Linux machines using CONFIG_SIM_PREEMPTIBLE=y and 'CONFIG_RR_INTERVAL=1'.

This change MUST not come into master UNLESS all simulator specific changes outside of arch/sim and boards/sime are removed. The common OS must not be contaminated with platform-specific code.

I agree.
The platform independent logic is supposed to remain platform independent!!

This change MUST not come into master UNLESS all simulator specific changes outside of arch/sim and boards/sime are removed. The common OS must not be contaminated with platform-specific code.

I agree.
The platform independent logic is supposed to remain platform independent!!

I wonder if there is some design alternative that would eliminate the need for this coupling.  It would be good if we could bring this code in, but we do have to enforce the OS modularity.
There are other examples where we had to implement special features to support specific platforms or hardware, but we did these things by extending interfaces and configuration options.  For example, we added the capabilities method to the SDIO interface (included/nuttx/sdio.h).
I am not proposing that as a solution and would not advocate a hack just to avoid the SIM dependency.  We need to do things right.  There are not comments added to the code to explain why you thought this was necessary.  So it is hard to suggest alternatives.  Comments are good!  Comments are your friends!

solution and would not advocate a hack just to avoid the SIM dependency. We need to do things right. There are not comments added to the code to explain why you thought this was necessary. So it is hard to suggest alternatives. Comments are good! Comments are y

Thanks for considering an alternative solution and reviewing my code. I was thinking of something but I'm not sure if it's going to be accepted:

jump to an alternative entry_point that fetches the arguments from the TCB and calls makecontext to setup the task arguments

In this way we don't have to modify the platform independent code but it adds additional complexity. What do you think ?

There are some startup hooks that might be usable for such a purpose with some extensions???  sched/task/task_starthook.c
The the start hooks are not currently set up in a way that would be usable to you because it really only works if the TCB has been created (via nxtask_init()) but not yet started (via nxtask_activate()).
It is currently using only in binfmt/binfmt_execmodule.c when an ELF task is created in order to run the C++ static constuctors (This is a documented security Issue #1265 for this).
Hmm...
I think it would be fine to implement a abstracted, generalized, platform-specific hook in sched/task/task_init.c or maybe nxtask_activate.  It would be wrapped and a general external task startup hook:

It would have a name like up_start_hook()
It would be prototyped in include/nuttx/arch.h
There would be a configuration in sched/Kconfig like ARCH_STARTHOOK

That should work if I understand what you need correctly.

In this way we don't have to modify the platform independent code but it adds additional complexity. What do you think ?

I think my suggestion in the previous comment would work better for you and is very simple.  It is really the same solution that you have originally except that it is dressed up to look like a platform independent feature.  The decoupling here is purely semantic but, I think, acceptable.

the previous comment would work better for you and is very simple. It is really the same solution that you have originally

In this way we don't have to modify the platform independent code but it adds additional complexity. What do you think ?

I think my suggestion in the previous comment would work better for you and is very simple. It is really the same solution that you have originally except that it is dressed up to look like a platform independent feature. The decoupling here is purely semantic but, I think, acceptable.
There are conditional hooks throughout the OS: start hooks, termination hooks, timer hooks, etc. So, although not a thing of beauty, I think that is consistent with how other sticky issues have been addressed.

Thanks for the suggestion I will update my patch.

The patch not related to ucontext API is moved to here: https://github.com/apache/incubator-nuttx/pull/1663

@sebastianene07 you can rebase this patch now, I have an idea which may avoid to touch the common code and will try in the next couple day.

@sebastianene07 you can rebase this patch now, I have an idea which may avoid to touch the common code and will try in the next couple day.

Thanks for the update, I figured it out and we don't have to modify the common code to pass arguments to new tasks. The entry point for a new task is nxtask_start and this function takes no arguments. It grabs the arguments (argc and argv) from the TCB and calls the tcb->cmn.entry.main with them. So the mechanism to pass the arguments is very generic and works like a charm in our case without any modification.


One of Elasticsearch 2 builds fails permanently

Build with TOXENV=py35-dj110-postgres-elasticsearch2 INSTALL_ELASTICSEARCH2=YES fails permanently
$ if [[ -n "$INSTALL_ELASTICSEARCH2" ]]; then ./scripts/travis/install_elasticsearch2.sh; fi
sudo: must be setuid root
sudo: must be setuid root
sudo: must be setuid root
sudo: must be setuid root
sudo: must be setuid root
The command "if [[ -n "$INSTALL_ELASTICSEARCH2" ]]; then ./scripts/travis/install_elasticsearch2.sh; fi" failed and exited with 1 during .

Example: https://travis-ci.org/torchbox/wagtail/jobs/161611317

That is because Travis is set up to use the container infra which does not allow sudo.
https://docs.travis-ci.com/user/ci-environment/#Virtualization-environments
So https://github.com/torchbox/wagtail/blob/master/scripts/travis/install_elasticsearch2.sh must be updated to not use sudo

Should be fixed now. There was a missing sudo: true in the build matrix