chore: release main

:robot: I have created a release beep boop
auto-instrumentations-node: 0.50.2
0.50.2 (2024-10-10)
Dependencies

The following workspace dependencies were updated

dependencies

@opentelemetry/instrumentation-pg bumped from ^0.45.0 to ^0.45.1
@opentelemetry/resource-detector-alibaba-cloud bumped from ^0.29.2 to ^0.29.3
@opentelemetry/resource-detector-container bumped from ^0.4.2 to ^0.4.3

instrumentation-pg: 0.45.1
0.45.1 (2024-10-10)
Bug Fixes

add missing @opentelemetry/core dependency (#2473) (4d66431)

resource-detector-alibaba-cloud: 0.29.3
0.29.3 (2024-10-10)
Bug Fixes

add missing @opentelemetry/core dependency (#2473) (4d66431)

resource-detector-container: 0.4.3
0.4.3 (2024-10-10)
Bug Fixes

add missing @opentelemetry/core dependency (#2473) (4d66431)

This PR was generated with Release Please. See documentation.

We might have the same issue with "detectors/node/opentelemetry-resource-detector-container".


fix(KFLUXBUGS-1272): Broken URLs in slo-documents of Konflux services

Add 1runbook_url1 to Release service Prometheus urls

/retest

Please update the release_service_test.yaml and add the runbook_url to the exp_annotations for the tests to pass


chore: version bump to 0.5.18

#46  👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @tazarov and the rest of your teammates on  Graphite


Set toggle button "title" to submenuToggleText

When a user hovers over the toggle button, there should be a title attribute to indicate what will happen if they click the button. Adds a "title" attribute to the toggle button set to "_this.options.submenuToggleText"

Given that the text is already visible within the button I'm not understanding the value of adding the title attribute, can you clarify?

The text inside the button is wrapper in a span.submenu-toggle-text, which, according to /scss/components/_accordion-menu.scss includes the element-invisible mixin. So, on most screens, that text is not visible.

Got it. Sounds good, merging. Thanks @danbrellis! And Congrats on first contribution!


worker code not executed until postMessage()

when creating a worker, i expected the code of the worker to be executed on creation of the worker. similarly to how module code is executed on every require().
but as it is now, i have to issue a postMessage() for the code to be executed.
for example:
worker-interval.js: https://gist.github.com/1391259
var {Worker} = require('ringo/worker')
// i expected the setInterval(), as defined in worker-interval.js, to be executed by the following call
var worker = new Worker(module.resolve('./worker-interval'))
worker.postMessage()

i just checked: w3c workers executed the script when the worker is created.
a simpler example would be:
// worker.js
print ('FOO');

// main.js
new require('ringo/worker').Worker(module.resolve('./worker'));

... does not output 'FOO'.


Added debug flag to GCSReader/Writer

Added debug statement from GCSReader/ GCSWriter.
Will update documentation in follow up PR.

I think tests need to be updated with the new flag defaulted.


Storing arbitrary attributes for segments

In my project search index files are deployed through something like torrent technology. New replicas are asking by broadcast who can seed segments identified by X, Y, Z etc and then leeches all these segments.
Merging removes old segments so I have to choose between enabled merging and possibility to seed old segments.
My proposal is to give a way to store some extra key-value data for segments. It would allow to mark some segments as i.e. "frozen" = true and to omit these segments while calcualting merge policies.
Probably there is a better way. What is you thought about it? I could try to implement by myself so feel free to choose from options that are really suited better for further development.

Attaching meta data to segments and exposing them to the merge policy seems like a great idea.
Can you work on an actual spec?

Sure, but it seems we need to work out a solution in #971 firstly

@fulmicoton I've come back here to the issue as I'm in need of this now:)
I've taken a look over various ways and here are some initial thoughts:

meta.json already stores some attributes for each segment
Another way is to store attributes in separate file within segment

I'm slighly shifted toward having a separate file (something like .props). But it could be confusing taking into account that some attributes are already stored in meta.json
The main advantage of moving all attributes (max_doc, deletes and others which we would like to have in the future) to a separate file within the segment itself is that segments could be distributed between servers in easier way. Having all segment metadata inside the .props file means that you could attach new segment to the index by merely putting files into index directory and adding segment_id to the list of actual index segments in meta.json

One thing that would be interesting for the quickwit use case is to store values in fields per segment if you have a limited number of values.
This information can be used for pruning or in merge options that prefer to merge same values together. This wouldn't be arbitrary information, but should probably stored in the same file.


Add custom variables in URL template

Many rdbms allow/require to pass parameters as part of the URL connection e.g. LOGMECH for Teradata.
Unfortunately DBeaver never supported custom variables - thought that Connection Properties was there for that.
The 2 workarounds are not practical:

hijacking the SERVER variable is misleading and would work for one param only
editing the driver URL template and hardcoding the param values means maintaining multiple copies of the "driver" - although the same.

Can you consider adding support for e.g. USER.BLAH in the driver URL Template, and a new Connection would use, if set, the value in the User Property BLAH (defined for that Connection) ?

thanks for the suggestion

that would be usefull indeed

seems it was fixed in #13654


Why did you rename limit method to eval_limit?

Is there any collision?

Hello. I renamed limit to eval_limit because limit was misleading. In ActiveRecord, limit controls how many items matching your predicate you get back, whereas with DynamoDB it controlled how many items were evaluated for your predicate.
With DynamoDB, you could run your query on a large table, limit it to 10 items, and get 0 items back because the first 10 items in the table happened to not match your predicates.
So to avoid this confusion and inconsistency between AR and DynamoDB, I renamed limit to eval_limit, to emphasize that you're limiting the number of evaluations rather than resulting rows.

Thanks a lot!
I completely understand and agree with you.


Updates to demo.sh: refactor to make it easier to share.

Factor out some variables. And add a loop to wget the IP so you can see when the LB is up and running.
cc @nikhiljindal

This change is

/ok-to-test

Thanks looks great!
Update demo/README.md as well?

Thanks for the fixes and updating the README!


use full namespace

In the core use statements are mixed (full namespace and alias). This can give problems when instance of is checked. We would like to know what the advice approach is. Using the full namespace gives us some advantages in our IDE.
use Concrete\Core\Page\Page;
use \Page;

Example
We use Concrete\Core\Page\Page . When making a copy of a page we get the following error.
Argument 1 passed to Concrete\Core\Cache\Page\FilePageCache::purge() must be an instance of Page, instance of Concrete\Core\Page\Page given

Using the full namespace gives us some advantages in our IDE.

Do you know that you can give your IDE a great help with the c5:ide-symbols CLI command?
If you run this comamnd, your IDE will understand class aliases like \Page.
PS: it seems that you need to refresh your local repository: its structure changed a lot yesterday.

Thanks that is a nice feature. I assume that we will have to use aliases instead? Or should the core make use of the full namespace + class?

IMO we definitely want to use the full class and not the alias.

@KorvinSzanto could you explain why? I see some more occurrences in the core and I've seen comments in the PRB recently that advocate the use of aliases instead of full namespaces.

@a3020 in the core we should use fully qualified namespaces instead of aliases simply to preserve syntax highlighting and to prevent the odd errors that come with lazy aliasing classes. Class aliases are there for end user convenience, so in a sites custom code it's perfectly fine to use em. But in the core we should be using fully qualified namespaces everywhere.
There are a few special cases where using an alias to type hint will break your website and there's always the possibility since they have no namespace that a dependency in the core or a custom dependency in a package or a custom site will collide with these aliases. If theres a collision, any code that uses the aliases will suddenly be calling methods on a different class.

@KorvinSzanto Thanks for explaining. Good to know.


Adding gzip compression support in browser case

Which problem is this PR solving?
This introduces gzip compression support to the exporters in the browser case. The change use CompressionStream API available in the modern browsers and does not introduce any additional 3rd party dependency.
Note that this support exists for the node case already.
Short description of the changes

Updated sendWithXhr function to take additional parameter for compression. This parameter is not added at the end, so this could potentially qualify as a breaking change. however, I have also modified its only usage in otlp-proto-exporter-base so I'm not sure if this still qualifies to be a breaking change.
I've used Copilot to generate the code for compressContent, let me know if you find anything odd.

Type of change
Please delete options that are not relevant.

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[x] This change requires a documentation update

How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

I tested compressContent function separately, and was able to uncompress the content using gunzip command line
I also tested examples/opentelemetry-web/xml-http-request enabling gzip compression in the OTLPTraceExporter

Checklist:

[ ] Followed the style guidelines of this project
[x] Unit tests have been added
[ ] Documentation has been updated

I do have a question about browser support -
CompressionStream is supported on majority of browsers, but not all. On browsers where this is not supported, the export will fail. We could do a feature detection, and if CompressionStream is not available, then default to export without compression. IMO, this would be a better experience, specifically because getting data about browser usage is a key metric in browser monitoring. (This might be a topic for a broader discussion)
Alternatively, we should at last document that compression is not available on all browsers.

I do have a question about browser support -
CompressionStream is supported on majority of browsers, but not all. On browsers where this is not supported, the export will fail. We could do a feature detection, and if CompressionStream is not available, then default to export without compression. IMO, this would be a better experience, specifically because getting data about browser usage is a key metric in browser monitoring. (This might be a topic for a broader discussion)
Alternatively, we should at last document that compression is not available on all browsers.

@martinkuba I now check if CompressionStream is supported by the browser and proceed with sending without compression if it is not supported.

@pichlermarc all aspects of this PR are resolved, can you take a look?
@martinkuba @MSNev  can you approve this PR when you get a chance?

@pichlermarc  can you review this PR when you get a chance?  There is a commit https://github.com/open-telemetry/opentelemetry-js/commit/8a2e225997f0c8cb850ee500bcde415ed0e2ea31 from you that needs your attention.

/easycla

@MSNev could you please review last comment above from @scheler  (on Jul 11)  ? thanks


Include attachments in Message event type

I've been playing around with fawkes and found I needed the attachments from the message.
I tried to add it in a way that is consistent with the current code, but happy to do it another way. Just point me in the direction you prefer.

Example of the raw message data.
%{
  "attachments" => [
    %{
      "author_name" => "rollout-test.flagger",
      "color" => "2eb886",
      "fallback" => "New revision detected, progressing canary analysis.",
      "fields" => [
        %{
          "short" => false,
          "title" => "Target",
          "value" => "Deployment/rollout-test.flagger"
        },
        %{
          "short" => false,
          "title" => "Failed checks threshold",
          "value" => "5"
        },
        %{"short" => false, "title" => "Progress deadline", "value" => "300s"},
        %{
          "short" => false,
          "title" => "Traffic routing",
          "value" => "Weight step: 10 max: 50"
        }
      ],
      "id" => 1,
      "mrkdwn_in" => ["text"],
      "text" => "New revision detected, progressing canary analysis."
    }
  ],
  "bot_id" => "B0164TD383V",
  "bot_profile" => %{
    "app_id" => "AN89XFLBU",
    "deleted" => false,
    "icons" => %{
      "image_36" => "https://avatars.slack-edge.com/2020-06-26/1208551132130_a2f53ebb1f87db1ece3c_36.png",
      "image_48" => "https://avatars.slack-edge.com/2020-06-26/1208551132130_a2f53ebb1f87db1ece3c_48.png",
      "image_72" => "https://avatars.slack-edge.com/2020-06-26/1208551132130_a2f53ebb1f87db1ece3c_72.png"
    },
    "id" => "B0164TD383V",
    "name" => "Flagger",
    "team_id" => "TB3CSLAF6",
    "updated" =><PHONE_NUMBER>
  },
  "channel" => "C016H634X2M",
  "event_ts" => "1596760084.004600",
  "subtype" => "bot_message",
  "suppress_notification" => false,
  "team" => "TB3CSLAF6",
  "text" => "",
  "ts" => "1596760084.004600",
  "type" => "message"
}

Thanks @forest this LGTM :tada:


Insecure Storage: Insufficient Keychain Protection

Summary
On line 164 of FIRAuthKeychainServices.m, the method setItemWithQuery:attributes:error:() stores data in the Keychain with potentially insufficient encryption settings.The identified method stores data in the Keychain with potentially insufficient encryption settings.
[REQUIRED] Step 1: Describe your environment

Xcode version: 11.3.1
Firebase SDK version: 6.6.7
Firebase Component: Auth, Core, Database, Firestore, Messaging
Installation method: `CocoaPods

[REQUIRED] Step 2: Describe the problem
Explanation
The Keychain accessibility constants are designed to let applications declare when items in the Keychain should be accessible. By specifying one of accessibility constants for a given Keychain item, a developer can instruct the underlying file system to encrypt it either using a key derived from both the device's UID and the user's passcode or using a key solely based on the device's UID (as well as when to automatically decrypt it).
The Keychain accessibility constants are meant to be assigned as the value for the kSecAttrAccessible key in the Keychain attribute dictionary. The definitions for the various Keychain accessibility constants are as follows:
-kSecAttrAccessibleAfterFirstUnlock:
The data in the Keychain item cannot be accessed after a restart until the device has been unlocked once by the user.
After the first unlock, the data remains accessible until the next restart. This is recommended for items that need to be accessed by background applications. Items with this attribute migrate to a new device when using encrypted backups.
Available in iOS 4.0 and later.
-kSecAttrAccessibleAfterFirstUnlockThisDeviceOnly:
The data in the Keychain item cannot be accessed after a restart until the device has been unlocked once by the user.
After the first unlock, the data remains accessible until the next restart. This is recommended for items that need to be accessed by background applications. Items with this attribute do not migrate to a new device. Thus, after restoring from a backup of a different device, these items will not be present.
Available in iOS 4.0 and later.
-kSecAttrAccessibleAlways:
The data in the Keychain item can always be accessed regardless of whether the device is locked.
This is not recommended for application use. Items with this attribute migrate to a new device when using encrypted backups.
Available in iOS 4.0 and later.
-kSecAttrAccessibleWhenPasscodeSetThisDeviceOnly:
The data in the Keychain can only be accessed when the device is unlocked. Only available if a passcode is set on the device.
This is recommended for items that only need to be accessible while the application is in the foreground. Items with this attribute never migrate to a new device. After a backup is restored to a new device, these items are missing. No items can be stored in this class on devices without a passcode. Disabling the device passcode causes all items in this class to be deleted.
Available in iOS 8.0 and later.
-kSecAttrAccessibleAlwaysThisDeviceOnly:
The data in the Keychain item can always be accessed regardless of whether the device is locked.
This is not recommended for application use. Items with this attribute do not migrate to a new device. Thus, after restoring from a backup of a different device, these items will not be present.
Available in iOS 4.0 and later.
-kSecAttrAccessibleWhenUnlocked:
The data in the Keychain item can be accessed only while the device is unlocked by the user.
This is recommended for items that need to be accessible only while the application is in the foreground. Items with this attribute migrate to a new device when using encrypted backups.
This is the default value for Keychain items added without explicitly setting an accessibility constant.
Available in iOS 4.0 and later.
-kSecAttrAccessibleWhenUnlockedThisDeviceOnly:
The data in the Keychain item can be accessed only while the device is unlocked by the user.
This is recommended for items that need to be accessible only while the application is in the foreground. Items with this attribute do not migrate to a new device. Thus, after restoring from a backup of a different device, these items will not be present.
Available in iOS 4.0 and later.
So, while marking a Keychain item with kSecAttrAccessibleAfterFirstUnlock will afford it encryption using a key derived from the user's passcode and the device's UID, the data will still remain accessible under certain circumstances. As such, usages of kSecAttrAccessibleAfterFirstUnlock should be carefully reviewed to determine if further protection is warranted.
Steps to reproduce:
What happened? How can we make the problem occur?
This could be a description, log/console output, etc.
If you have a downloadable sample project that reproduces the bug you're reporting, you will
likely receive a faster response on your issue.

kSecAttrAccessibleAfterFirstUnlock is necessary for apps that perform background tasks. It is up to you to require reauthentication of the Auth user whenever performing sensitive tasks, and Auth automatically requires reauth when modifying the user (i.e. linking a provider or changing the password).


"git push" returns "fatal: The remote end hung up unexpectedly"

https://bazaarvoice.box.com/s/r9j3n83yxobr8zcrm9cxsuyzw92ljp1f is the debug-info. System otherwise reported healthy. Issue persisted across backup and restore of cluster. Migration of all apps to a blank cluster worked around it.

By the looks of it the slugbuilder job was failing with this error:
Error: Status 403 trying to pull repository flynn/slugbuilder: "\n<title>403 Forbidden</title>\n\n
403 Forbidden
\n
\n
Code: AccessDenied
\n
Message: Access Denied
\n
RequestId: C1D613A0D45299A4
\n
HostId: 8QklbjHZMGsVhxYFwPQb7IvHlY+wz0nU7U9lkpA1ueYMyzg8vkjCQLf5pbPN/1P1z+jD571XjWI=
\n
\n
\n\n\n"

An unfortunate oversight in recent debug log collection changes is that we aren't collecting slugbuilder output as it's not marked as a system app. (though this is probably correct as it could contain private information I guess)
So it's not clear if there was further issues but this definitely looks like an S3 bucket permissions issue or similar.

That error is from flynn-host, and is caused by an incorrect SLUGBUILDER_IMAGE_URI env var. I'll add some logging to make it more clear what the exact value of the variable is.

After a closer look, this appears to have been due to a lack of a rewrite of that variable during the backup restore. I'm looking at the code to sort out how it happened.

I was unable to determine the cause of this, but I suspect it was a mismatch in the TUF repo that would have been fixed in a subsequent release. Please open a new issue if you see it again.


Daily develop CI tests still fail.

@deepthiskumar  to find the issue for this.  Maybe there is an issue here that needs to be addressed as full snarks are run on the daily CI runs?

Couldn't find an issue but here's another link to the test, we were seeing the local state desync error before: https://app.circleci.com/pipelines/github/CodaProtocol/coda/21935/workflows/f5c712eb-9a46-4a6e-a9cf-c662db328d59/jobs/413657
IIRC @ghost-not-in-the-shell was investigating a similar issue on the 3.2 testnet


SwiftmailerServiceProvider configuration

Silex\Provider\SwiftmailerServiceProvider resets configuration parameters that were set before register. $app['swiftmailer.options'] becomes empty after SwiftmailerProvider is registered.
class SwiftmailerServiceProvider implements ServiceProviderInterface, EventListenerProviderInterface
{
    public function register(Container $app)
    {
        $app['swiftmailer.options'] = array();  // Works correctly if this line is removed

this is the expected behavior for all silex providers. you should override providers configurations after registering them (or with the second argument of $app->register())

and this is the behavior of all Silex providers

Yes, all providers reset options..  To use existing options would seem like a nicer behavior, but if it is expected it means it is correct.


Pitfall section in readme.md for newcomers

PR Checklist
Please check if your PR fulfills the following requirements:

[x] The commit message follows our guidelines: https://github.com/ngneat/until-destroy/blob/master/CONTRIBUTING.md#commit
[ ] Tests for the changes have been added (for bug fixes / features)
[x] Docs have been added / updated (for bug fixes / features)

PR Type
What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[x] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?
There are certain pitfalls for newcomers when using this library.
Issue Number: #91 and #109
What is the new behavior?
To avoid ppl searching for potential solutions in the closed issues it would be useful to have a list of tips and tricks for the most important pitfalls. New section Potential pitfalls in readme.md
Does this PR introduce a breaking change?
[ ] Yes
[x] No

Other information

Thank @arturovt, applied the suggested improvements.

Thanks @NetanelBasal


Node DTL not syncing

Description
I'm able to start a node on my 8 GB RAM machine but when i open the simple dashboard in grafana, i see the "DTL Sync" container says "No data found in response".
That status doesn't change
However there is data coming in for Fault Check Status and for Target Height (under the Client Heights container) -- both are flat lines
Specs

Docker Desktop (around v3.6 bc im installed windows 10)
Docker v20.10.16
Windows 10
8 GB RAM

Additional info
I noticed that my HEALTHCHECK__REFERENCE_RPC_PROVIDER RPC  isn't making any requests while FAULT_DETECTOR__L1_RPC_PROVIDER and DATA_TRANSPORT_LAYER__L1_RPC_ENDPOINT make many:

I was stupid and used an L2 rpc url for DATA_TRANSPORT_LAYER__L1_RPC_ENDPOINT 🫠


WSL mount failing on Windows 11 - This operation is only supported by WSL2

Version
Microsoft Windows [Version 10.0.22000.194]
WSL Version

[X] WSL 2
[ ] WSL 1

Kernel Version
<IP_ADDRESS>
Distro Version
Ubuntu-20.04
Other Software
When i try to run the command
wsl --mount \.\PHYSICALDRIVE5 --bare
I get the following error
This operation is only supported by WSL2.
Repro Steps
Run the command
wsl --mount \.\PHYSICALDRIVE5 --bare
Expected Behavior
Attach the disk to WSL2
Actual Behavior
I get the error
This operation is only supported by WSL2.
Now the default version is set to 2 and the Distro is also version 2
wsl.exe --status
Default Distribution: Ubuntu-20.04
Default Version: 2
Windows Subsystem for Linux was last updated on 12-10-2021
WSL automatic updates are on.
Kernel version: <IP_ADDRESS>
wsl -l -v
NAME            STATE           VERSION

Ubuntu-20.04    Running         2

Diagnostic Logs
No response

Could you provide the output of wsl.exe -l -v?

I referenced this in another issue, which led me to https://github.com/microsoft/WSL/issues/7829. After adding myself Administrators group, the mount command completed successfully. Obviously, this is an unfortunate limitation, but at least the issue is somewhat understood now.

This operation is only supported by WSL2.

i want to replace wsl2 but i cant!

I am having the exact problem the original author is having. Does not matter whether I'm using an admin account or an admin prompt on a standard account. Using an admin prompt, I get this:
C:\Users\pjsch>wsl --mount \.\PHYSICALDRIVE2
This operation is only supported by WSL2.
C:\Users\pjsch>wsl --status
Default Distribution: Ubuntu-20.04
Default Version: 2
Windows Subsystem for Linux was last updated on 7/25/2022
WSL automatic updates are on.
Kernel version: <IP_ADDRESS>

Same here. I have a hunch that we all have Windows 10 and that the correct error message should be "only supported by WSL2 on Windows 11 or higher".

Same problem as original author and you guys.  I have Windows 11 mind you, not Windows 10, build 22621.1105, well above the minimum version per https://learn.microsoft.com/en-us/windows/wsl/wsl2-mount-disk and I have WSL 2 (wsl --status reports default version 2).

Same issue on Windows 11, exactly as described by the OP. Updated WSL kernel, rebooted, and issue still persists. I'll update back if I have any luck.
WSL version: <IP_ADDRESS>
Kernel version: <IP_ADDRESS>
WSLg version: 1.0.47
MSRDC version: 1.2.3575
Direct3D version: 1.606.4
DXCore version: 10.0.25131.1002-220531-1700.rs-onecore-base2-hyp
Windows version: 10.0.22621.1105

I had the same issue (after update wsl to wsl2) and solved it by uninstall completeley wsl from windows with this tutorial => https://pureinfotech.com/uninstall-wsl-windows-11/
And reinstalled it in cmd command : wsl --install -d debian (yes i needed debian but ubuntu would do it)
After that : wsl --mount \.\PHYSICALDRIVE1 --partition 1         worked


Add reloadOnMissingCSS option, see livereload-js.

Corresponding livereload-js PR: https://github.com/livereload/livereload-js/pull/41

Waiting on a response from https://github.com/livereload/livereload-js/pull/41

Hi guys, we may put this on hold since livereload/livereload-js#41 is on hold as well.
I'm thinking about forking livereload-js to enable us more freedom in the client side. And probably port it to ES6 and babel instead of coffee.

👍 on forking livereload-js, seems abandoned. Double 👍 on moving to ES6/babel, yay!

Hi @STRML I'm sorry but I'll close your PR for the moment. As soon as we can have updates from livereloadjs or decide to make and build our own version of livereloadjs, we may reconsider this option.
I hope you understand.

Thanks - but if you consider this on hold, why not keep it open and label
rather than close, where it could be lost?
On Aug 13, 2016 5:15 AM, "Mickael Daniel"<EMAIL_ADDRESS>wrote:

Hi @STRML https://github.com/STRML I'm sorry but I'll close your PR for
the moment. As soon as we can have updates from livereloadjs or decide to
make and build our own version of livereloadjs, we may reconsider this
option.
I hope you understand.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/mklabs/tiny-lr/pull/93#issuecomment-239613810, or mute
the thread
https://github.com/notifications/unsubscribe-auth/ABJFP4AuWFRwwb_qZLrig-VYyXuWCgjlks5qfZk0gaJpZM4FrNCN
.

Fine, let's keep it opened. This was just in order to clean up old issues / PR

@STRML might want to rebase while we're waiting, so it's good to go when the upstream gets resolved.


aws_ram_resource_share.sub[0] name is changed to an invalid name

After upgrading from 1.1.4 to 1.1.5 we noticed that the aws_ram_resource_share.sub[0] name is changed which causes the terraform apply to fail.
The name is changed from us-east-2-level1 to us-east-2/level1 which is invalid
│ Error: Error creating RAM resource share: InvalidParameterException: Resource share name can contain only alphabetic characters, numbers, spaces, periods, and dashes.
│
│   with module.this.module.ipam.module.level_two["us-east-2/level1"].aws_ram_resource_share.sub[0],
│   on .terraform\modules\this.ipam\modules\sub_pool\main.tf line 45, in resource "aws_ram_resource_share" "sub":
│   45: resource "aws_ram_resource_share" "sub" {

Thanks for reporting. does reverting the version resolve your immediate issue?

can you share the pool_config from that level - please do not include any ram share principal values
I think it may just be a issue related to how the description (or implied description) is defined

i see what the issue is. a bug was introduced in 1.1.5, ill resolve shortly - thanks for reporting


Connection reset when route returns before reading body if it is large enough

Environment
Nitro version: 0.4.12
Node version: 18.6.0
OS: Windows 10
Reproduction
GitHub repo
The repo contains a simple server app with two routes:

/ (containing a simple HTML page with a button that sends a request for testing; the output will be logged to the JS console)
/test (POST only, simply returning a string with body reading commented out)

Describe the bug
When returning a value from a route handler, if the incoming request has a body large enough (~4MB for me) and the handler hasn't read it, the server will abruptly close the connection resulting in a network error on the client side.
Additional context
I also tried similar setups with the Node http module and just h3 (also available in the linked repo), and both worked.
Logs
No response

Hi. The repro seems not existing anymore and I guess could have been a local issue. in case experiencing it again feel free to open new issue 🙏🏼


androidenv: fix emulator build on Linux

Motivation for this change
androidenv emulator was not building on Linux because the file uses lib.optional instead of lib.optionals and doesn't include libuuid in buildInputs.
Things done

Built on platform(s)

[x] x86_64-linux

[x] Tested basic functionality of all binary files (usually in ./result/bin/)
[x] Fits CONTRIBUTING.md.

/marvin opt-in
/status needs_reviewer


buy and sell in solana

Can you update the buy and sell order source code on solana?

It is updated check in the folder Solana/Trade


Wallet Users SBAT talk to the network via bootnodes

Expected Behavior
Should be able to use a bootnode to discover full nodes
Current Behavior
What RNGeth calls bootnodes are actually static nodes, and thus we can't pass our actual bootnode to RNGeth right now

Passing via RNGeth is trivial as long as we know that Geth supports boot nodes.
https://github.com/celo-org/geth/blob/73c1d86b519c72722a924664304e6573cbcf77fa/mobile/geth.go#L147 - set
geth_logs_with_discovery.txt
this to true and build a geth. Discovery works on the mobile client as confirmed in the logs.
geth_logs_with_discovery.txt
The goal will be to make this parameter configurable via react-native-geth. But the plan is to do this after July 17 alfajores launch.

Plan of action

https://github.com/celo-org/celo-blockchain/blob/73c1d86b519c72722a924664304e6573cbcf77fa/mobile/geth.go#L147 - change this to be configurable. Similar to how config.SyncMode is.

Pass it via react-native-geth. Again similar to syncmode https://github.com/celo-org/react-native-geth/search?utf8=✓&q=syncmode&type=

Configure it in the mobile app. https://github.com/celo-org/celo-monorepo/blob/c6adcb24962cdeb52201ca4a429b08e8039f92f5/packages/mobile/src/geth/geth.ts#L61

@tkporter Please check in with @cmcewen as he has some plans for changes to react-native-geth


Add symmetric quantization with no clipping error in the tensor subclass based API

Follow up with #805 , add the same option to the new tensor subclass API.

@iseeyuan although the merging is not blocked, please still wait for an approval before merging next time :)


Changing the one of the leftbar side icons

What would you like to share?
to store all our favourite items we are using the heart icon which is similar to the like icon in the post.
If you allow I will change the icon.
Additional information

Record

[X] I agree to follow this project's Code of Conduct
[X] I have checked the existing issues
[X] I'm a GSSoC'23 contributor
[X] I want to work on this issue

Sure, you can work on this! and also change the name to saved perhaps ?? what do you think, suits better? Do rename that for the components as well?

Sure I got it👍
Thanks for the assigning :)


Recommended XML extension in VS Code

Currently, VS Code recommends to install https://marketplace.visualstudio.com/items?itemName=DotJoshJohnson.xml, when an XML document is opened or when you search for XML, in the extensions view:

redhat.vscode-xml actually has a much larger feature set and is actively maintained.
I wonder which criteria determine how an extension should be the recommended one for a given language. Is it based on max number of installations alone? I remember how, for Java, the recommendation was sort of hard-coded to promote Microsoft's Java Extension pack.
cc @auchenberg, @egamma, @aeschli, @akaroml, @gorkem, @NikolasKomonen

Related, the top recommended extension for Scala is "Better Comments" instead of the official Syntax highlighting extension, which is actively maintained and also vendors Scala highlighting on GitHub.com.

@auchenberg, @egamma, @aeschli, @akaroml, @gorkem, @mjbvz today Red Hat vscode-xml continues to provide more and more advanced features like XML -> XSD/DTD generator, codelens inside DTD, XSD, entities support, etc and we have a lot of planned features although the XML Tools which is the recommended extension is not active.
As @fbricon asked, could you please explain which criteria determine how an extension should be the recommended one for a given language?
Perhaps the Java requirement is the problem and it's the reason why vscode doesn't recommend Red Hat vscode-xml extension?
Thanks for your answer.

We try to recommend extensions that will provide the best "out of the box" experience, which is guided by what is popular/highly downloaded/highly ranked in the Marketplace. It looks like the XML tools extension has quite some open issues, but it also looks like the maintainer of the extension has become active again, which is goodness.
And, we can recommend multiple extensions. The challenge with the Redhat extension is that the user gets an error message immediately when trying to view an XML file if they don't have Java installed. Are there ways you can make this experience better? Maybe the prompt is not an error, but instead says some of the features are not available unless you install Java? Can a subset of features be available if the user doesn't want to install Java?

Hi, we also recently published an official Haskell extension under the Haskell organisation, would it be possible to recommend users to this for .hs files as well? It requires one of the GHC, Cabal or Stack build tools to be installed but we display messages with links to install them if they are not found. Asides from that there are no other prerequisites.

@bubba please open a new issue here to track the Haskell extension request.


Progress Bars: Indeterminate Looping Bar, Warning Type, Hardcoded to use Danger Color

Describe the bug
In the Dark Theme file, I set the value for the Progress Bar's warning color property to be a yellow color:
$clr-progress-warning-color: #FFD100;  //dark yellow
$clr-progress-danger-color: #D20000;  //red
However, I noticed on the Indeterminate Progress Bars page in the Kitchen Sink app that the Warning type is red, just like I'd set the Danger property to be.
Doing some investigation, it appears that in the _progress-bars.clarity.scss file, both danger and warning types of indeterminate progress bars are hard coded to use the danger color. Instead, the warning type should be coded to use the warning property color, as separately specified.
How to reproduce
I made changes to the properties shown in the file:
clarity-master/src/clr-angular/utils/_theme.dark.clarity.scss
The Progress Bars file is:
clarity-master/src/clr-angular/progress/progress-bars/_progress-bars.clarity.scss
Steps to reproduce the behavior:

Change the values in the dark theme file as noted above.
Run the Clarity Kitchen Sink app.
View the progress-bars > Indeterminate Progress Bar section of the demo.

Expected behavior
Each special type of progress bar should use its own properties as separately specifiable.
Versions
App
Kitchen Sink app as downloaded from Github on Friday, Jan. 11, 2019.
Clarity: v1.0.4

I verified locally that this has been fixed with the changes in #2942
Those changes are available now in the 2.0 beta and will be released with 2.0


creating an array struct

Can I create an array struct for all child element with a specific value? Need to choose
cats->cat->name: Tinna
the problem is my xml file has no any breeds, need to check values.

There is now allWithValue method which you can use to filter elements with specific value.


temporal revisit

see also:

https://github.com/microbiomedata/nmdc-schema/issues/925
https://github.com/microbiomedata/nmdc-schema/issues/384

patterns should not accept negative dates


Roles and Permissions in ODA CA -API & Architecture pattern for ODA Component & Canvas Security

This is is linked to E2E-395
Roles and Permissions in ODA CA -API & Architecture pattern for ODA Component & Canvas Security linked.
Text form e2eODA e2e-395 attached below
Description
Note this will be cross linked with ODA -CA Github ( ref to be added) and may be broken down into sub tasks.
Architecture patterns
ODA CA has proposed a Security Identity Management capability documented at:
https://tmforum-oda.github.io/oda-ca-docs/caSource/controllers/securityController/README.html
The ODA-CA sequence charts for this implementation - in ODA-CA example Product Catalog -it assumed that Party Roles are hosted within each Component and that changes to Party Roles are notified to the security controller.
Several issues have been identified and need X team Discussion - led by the ODA Security and Privacy Team:
ODA Component team are assuming that all Party Roles are hosted in the Party Management Component ( which uses TMF699 PartyRole. )
ODA CA describes a implementation specific approach which is different from ODA Component. BUT we have yet to approve Stage 2 functional integration pattern - draft is in: https://projects.tmforum.org/wiki/pages/viewpage.action?pageId=221382600
*This is starting to separate stage 2 flow. patterns ( based on Oauth2.0/ Open ID Connect) from possibly multiple implementation approaches and support Parties and devices /applications .
Current OAuth 2 pattern used in ODA CA is 'Authorization Code Flow' which is mostly party focussed. For device and systems machine to machine communication i.e. headless ODA components we also need to support OAuth 2.0 Client Credential Flow.
Currently it is not clear where the roles  should be  hosted for parties.
Need to  define how the OAuth 2.0 Concept of 'Resource Owner' is supported- in ODA  which requires a model to be defined and a number of implementation options defined.
API
There are several roles based APIs and their use in ODA Security needs to be clarified
TMF672 User Role & Permissions instead of the current ODA-CA implementation based on
TMF699 PartyRole.
Further complexity is we need to support devices we need also to use
TMF720 Digital Identity Management

What has been delivered so far for the Security workstream is just a first step (MVP). We are very open to improvements and our target is a zero-trust model where the Component specification defines all the security requirements using security-as-code approach (extension of infrastructure-as-code). I would be keen to get additional contributors to develop and contribute this if you know of any volunteers!
For the API discussion, our high-level strategy for the relationship between a component and the canvas is as follows:

The Component developer defines the roles and associated permissions for a component. They also enforce these permissions, as they are the only one's with the data access required for data-based permissions.
The Canvas includes an Identity Management Service that manages all the system and human identities and their mapping to roles. The same identities will typically be mapped to roles across different components. In order to do this, the Canvas must have information about all the roles defined by each component.
The Component declares these roles towards the Canvas as part of its component definition. The declaration uses an Open-API so that roles can be added/deleted at run-time for each component. The canvas listens for events using the Open-API event mechanism.

Since our only requirement was for components to communicate roles to the Canvas, we used the TMF699 Party Role API and in the current Level 3 specification, this is a mandatory requirement for all components.
Whilst I understand that there is a TMF672 User Roles & Permissions API and that there may be components that use this as part of their core functionality, we deemed this was not the correct API to use for the Component to Canvas role integration.

Lester thanks for the input very helpful and useful is providing some guidance on limiting options . Note that draft https://projects.tmforum.org/wiki/pages/viewpage.action?pageId=221382600  has made similar assumptions and these observations arose out of that study and current work on ODA Components  . Look forward to working with ODA CA to address enhancements. including need for Federated identity Management

Hi @pecanpete, one thing to clarify here is that the IDM on the ODA CA as it stands is not "in" the canvas, it's "via" the canvas, outside in the wider organisation (although the implementation sits on the same cluster). So the breakdown of responsibilities we've assumed so far takes that into account like this:

roles and permissions are managed in the component
identity and access management are out in the wider organisation
authentication and authorisation are integrated via the front door into the component functional interfaces
the security controller in the canvas provides abstraction between the component and the organisation's IDM platform so that different organisations can use different IDM platforms and not have to change how roles are advertised.

This leaves me with one significant outstanding question of how/if an actual "user" is provisioned in the component itself or whether the component should trust the authorisation token and create a shadow profile (some kind of skeleton local account) to deal with the settings/logging/state for a correctly authenticate/authorised user. This is important because depending on how we handle it, SCIM is probably preferable to the TM Forum identity APIs.
At the moment, the CA documentation actually only describes the client credentials flow, so that's already in line with what you've said. We can adopt the authorisation code flow as well, and you are right that we should - we simply haven't done it yet because our experience is that sorting out the integration with access management (i.e. dynamically managing roles and attaching component roles to identities) is the harder problem to solve than OAuth 2.0 based authentication and authorisation.
It seems like now is the right time for us to double-check the ODA CA team's assumptions together and then build the authentication and authorisation functionality into the refence as per your team's recommendations so that we can test to make sure that can work and also figure out the answer my the outstanding account question.

Hi Brian - planning to change my Github handle to something more recognisable
Agree now is a good time to review where the are across ODA Components and ODA CA
For example my reading of the ODACA security documentation had been that this was a Authorization Code flow example but seems you r view is that it is a Client Credential Flow.  think this might be be sue of a ODA component assumption about using Party Roles. from my reading some of the models proposed in  https://projects.tmforum.org/wiki/display/TAC/TMFC020%3A+Digital+Identity+Management+v1.0.0  and in particular those model in the associated API map in the first comment on this page and the  proposed TMF 720 Digital Identity management API( https://github.com/tmforum-apis/TMF720_DigitalIdentity) . Maybe we can plan a X-team meeting on security some time in the New Year?


Simple way to disable/limit the size of the response stored in the database

Hi,
Thanks for the useful plugin!
Since some of our API responses can be large, the log table is becoming slow to load due to the size of the response column. They are cropped to [204K], (I think due to Django/postgres?), but this  is still a lot and means we have to update the column data manually to get sensible performance.
Is there an easy way to turn off or limit the size of the response stored?
Cheers
Sim

@SimKennedy There is no drf-tracking setting to disable storage based on response body to be stored. You could use Django's pre_save signal to listen to the model save and do some data pre-processing before the save hits the db. Thats might best immediate suggestion.

Thanks @avelis! That worked perfectly. :+1:
Sorry for the noob question. I am still learning Django and didn't know how easy it is to intercept signals.

No apologies needed. Glad it worked out!


Correct project structure.

Ensure Django project structure is correct.

[ ] Static files need to be located within the app folder.
[ ] Templates, JS, and CSS need to be modularized and not grouped together.
[ ] Other various changes.

Django app was replaced by multi-platform Ionic app (including web). Code for this component of the project has been discarded.

Sigh :(


Unable to push Docker image from local registry

I am running Docker and PCFDEV VM on Windows 7. I built a local registry using the instructions listed here: https://docs.docker.com/registry/deploying/#storage-customization
I was able to successfully push the Docker image out to the local registry, but when i try to do a cf push of the image to my PCFDEV machine, I get the following:
C:\sandboxes\Pivotal-Cloud-Foundry>cf push image --docker-image localhost:5000/image:latest
REQUEST: [2018-03-02T13:27:51-06:00]
GET /v2/info HTTP/1.1
Host: api.local.pcfdev.io
Accept: application/json
User-Agent: cf/6.34.0+f53d03a5e.2018-01-09 (go1.9.2; amd64 windows)
REQUEST: [2018-03-02T13:27:56-06:00]
GET /v2/info HTTP/1.1
Host: api.local.pcfdev.io
Accept: application/json
User-Agent: cf/6.34.0+f53d03a5e.2018-01-09 (go1.9.2; amd64 windows)
REQUEST: [2018-03-02T13:28:01-06:00]
GET /v2/info HTTP/1.1
Host: api.local.pcfdev.io
Accept: application/json
User-Agent: cf/6.34.0+f53d03a5e.2018-01-09 (go1.9.2; amd64 windows)
Request error: Get https://api.local.pcfdev.io/v2/info: dial tcp: i/o timeout
TIP: If you are behind a firewall and require an HTTP proxy, verify the https_proxy environment variable is correctly set. Else, check your network co
nnection.
FAILED
I do have the http_proxy & https_proxy set, but I still get this problem. Any ideas?

See: https://docs.pivotal.io/pcf-dev/configuring.html#insecure-docker-registries


Add is-inline property to create, update and retrieve database

I find is_inline property in API reference. Then I send a request to test it and found that it did create a database for inline.

Just as I was doing notion API integration recently, I need this feature, so I sent this PR.
Create inline database example:
curl --location --request POST 'https://api.notion.com/v1/databases/' \
--header 'Content-Type: application/json' \
--header 'Notion-Version: 2022-02-22' \
--header 'Authorization: {token}' \
--data-raw '{
    "parent": {
        "type": "page_id",
        "page_id": "{page_id}"
    },
    "title": [
        {
            "type": "text",
            "text": {
                "content": "Grocery List"
            }
        }
    ],
    "properties": {
        "Name": {
            "title": {}
        },
        "Date": {
            "date": {}
        }
    },
    "is_inline": true
}'

Please replace {token} and {page_id} with your own generated.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

@lao9, (sorry to mention you). Just for this PR, any feedback?

We should have fixed this in the latest version of the SDK. Thank you!


fix: refactor verifiable credential code

Explanation
Performs refactors related to all Verifiable Credentials code:

[x] Create announce function for notifications, history, and browser events
[x] Use pushEvent for sending browser events
[x] Rename background function names and local variables using VC and VP abbreviation
[x] Rename frontend function names and local variables using VC and VP abbreviation
[x] Rename events, RPC actions, operation types, paths appropriately
[x] Document background functions
[x] Document hooks, and duck functions
[ ] Complete code coverage for VC related code

Related Issues
Verifiable Credentials
Verifiable Presentations
Pre-Merge Checklist

[x] PR template is filled out
[x] Pre-commit and pre-push hook checks are passed
[x] E2E tests are passed locally
[ ] IF this PR fixes a bug, a test that would have caught the bug has been added
[x] PR is linked to the appropriate GitHub issue
[x] PR has been added to the appropriate release Milestone

PR template source from github.com/MetaMask

@0xisk @0xmad These are the refactors as discussed in https://github.com/CryptKeeperZK/crypt-keeper-extension/pull/765. Currently working on finishing test coverage for the rest of the VC code.

Folders for improving test coverage:
src/ui/pages/AddVerifiableCredential
src/ui/components/VerifiableCredential/Item
src/ui/components/VerifiableCredential/Display
src/background/services/credentials - this one will have huge tests update and I think it can be next PR right after that.

@0xisk @0xmad Thanks for the comments. Addressed most of them, have a few things that are up for discussion, and some things I'm not sure how to fix. Please take a look.
I also increased the code coverage for all verifiable credentials code to 100%.

@src/background/services/credentials/utils should not be used for ui. These utils must be shared and must not be imported from background services.


Can I use this project to sign documents with ID Austria?

Great project! Also nice that it was supported by Netidee!
I am a little bit lost when it comes to the certificate part of the whole process. How could I sign a document using Austria ID?
Or where could I get a certificate that has some meaning in austria speaking of legal terms?

Thank you for your kind words, and sorry for the late reply!
The ID Austria (IDA) is using a qualified certificate that's stored centrally. Unfortunately, open-pdf-sign cannot be used to sign PDFs with the IDA certificate, as open-pdf-sign requires local certificates/keys. An overview on the IDA architecture can be found at EGIZ.


[ADDITION] Picocrypt (Complete)

Category
Essentials
Listing Name
Picocrypt
Listing URL
https://github.com/Picocrypt
Listing Icon
https://raw.githubusercontent.com/Picocrypt/Picocrypt/refs/heads/main/images/key.ico
Listing Description
Simple and secure file encryption for everyone.
GitHub repository
https://github.com/Picocrypt
ToS;DR ID
No response
Is Open Source?

[X] Yes, it's open source

Security Audited?

[X] Yes, it's been security audited

Accepts Anon Payment?

[ ] Yes, accept anonymous payment

Justification and Further Info

https://github.com/Picocrypt/storage/blob/main/Picocrypt.Audit.Report.pdf

YAML Content for Addition
- name: Picocrypt
  url: https://github.com/Picocrypt
  icon: >-
    https://raw.githubusercontent.com/Picocrypt/Picocrypt/refs/heads/main/images/key.ico
  description: Simple and secure file encryption for everyone.
  github: https://github.com/Picocrypt
  openSource: true
  securityAudited: true

This ticket was submitted via awesome-privacy.xyz/submit
Final Checklist

[X] I confirm that I've read and followed the Contributing Guide
[X] I agree to follow the Code of Conduct
[X] I have clearly declared any affiliation I may have with this service

Done in https://github.com/Lissy93/awesome-privacy/pull/296. Thanks!


Feat: PWA with offline support added

Service worker registers only in production builds so run gatsby build && npm run serve to see the PWA support. But if you deploy the application you can surely get that in prod.
Just a suggestion: Do deploy your app to netlify or vercel for dev, it will be easier for you to view PRs with their bot support!

Thanks, @Aniket762


Avoid scroll on top?

Is it possible to avoid the automatic scrolling on top when the modal is triggered although I disabled hashTracking?

It scrolls to the top only the inner content.

Example?

Sorry it was my fault, after several tries I understood that the problem was caused by "overflow-y: scroll" applied to the body. Anyway please accept my apologies and thank you for your support.

No problems.


significant reduction in speed after "modin[ray]" upgrade to the latest version

System information

OS Distribution: Centos linux 7
Memory: 376 GB  DDR4
Modin version: 0.12.0
Ray version: 1.4.0
Python version: 3.5.1

I have been using the following setup for a while now, however, after using pip install -U "modin[ray]" yesterday, everything has become significantly slower, e.g. 2h for read_csv instead of the usual ~36m and ~3m for df.sample(frac=0.1).groupby(['col_1', 'col_2'])['col_2'].transform(np.size) instead of the usual ~1m 36s:
import ray
def ray_init():
    ray.init(_temp_dir="/some/specific/path/ray/tmp/",
             _plasma_directory="/some/specific/path/ray/",
             _memory=3000000000000,
             object_store_memory=3000000000000)
    os.environ["MODIN_ENGINE"] = "ray"
    os.environ['MODIN_MEMORY']='365000000000'
    return None

ray_init()

import modin.pandas as pd
from modin.config import ProgressBar
ProgressBar.enable()

df_128gb = pd.read_csv('df_128gb.csv', low_memory=True, memory_map=True)

Any ideas what could be causing this?
Thanks!
Pej
Originally posted by @Peji-moghimi in https://github.com/modin-project/modin/issues/3705#issuecomment-991139161

I now definitively know that ray==1.1.0 and modin==0.9.1 work significantly faster for read_csv at approximately 25 minutes, as oppose to ~2hours with pip install -U "modin[ray]".

Hi @Peji-moghimi thanks for the issue!
Would you be able to try the following to see if there's still a slowdown:
pip install modin==0.9.1
pip install ray==1.4

It may not work due to API changes in Ray, in which case I will help with next steps. Looking forward to figuring this out!
If it helps, I can also email you.

@Peji-moghimi because we haven't received a reply in over 10 months, I'm going to close this issue. I'm happy to help if ray performance is not what you expect. Please just reach out here.


Fixed typo

thanks for the PR, but
a) "inert" is correct
b) the content of README.md has already changed significantly in the master branch and this particular section has been removed.


[Autocomplete] onChange not fired for same item consecutively

onChange is not fired when selecting the same item consecutively. A differnt item (or clear) must be selected first.

[x] The issue is present in the latest release.
[x] I have searched the issues of this repository and believe that this is not a duplicate.

Current Behavior 😯

Curretnly, when selecting the same element consecutively onChange is not fired on the consecutive calls.
Expected Behavior 🤔
Every time an item is selected, onChange something should be called, either onChange (perhaps via a prop that says that an item can be slected multiple times) or perhaps via a dedicated onSelect handler.

Steps to Reproduce 🕹

Steps:

Visit the CodeSandBox
Select an item from the list. Notice how the item is stored in state (via useState)
Clear the state by clicking the "clear selected" button
Select the same item from the autocomplete as selected in step 2

The desired outcome would be for state to be populated again with the item. Instead, onChange is never called and hence state is never re-populated.
Context 🔦

The goal is to allow the same item to be slected multiple times. One use case for this would be when selecting an item from a auto-completed list that can be selected multiple times. Anothe might be re-selecting an item after it was cleared by external state (see link for example).
Your Environment 🌎
MUI v5

"already selected" is true from the point of view of the component's internal state. From what the user sees, it seems like nothing is currently selected, and hence it feels like something is not working. Likewise, onChange here is reflecting what the component sees, not what the user sees.
Perhaps a prop (as mentioned above) to allow consecutive selects would make sense?

For comparison, here is a workaround implemented in userland. Notice how much extra boilerplate is needed here: https://codesandbox.io/s/combobox-material-demo-forked-x3yhm?file=/demo.js

#18755 isn't related, it is for select multiple only. @mbrevda didn't make it clear which part of the code sandbox is the workaround. onClose doesn't give us the selected item. How do we do such a basic thing as allow them to select the same item twice?

Add value to your component state and initialise it with null, then in onSelect set value to null. Add these props to your <AutoComplete>:
        value={this.state.value}
        onSelect={(value) => {
          this.setState({ value: null });
        }}

Now onChange always triggers when selecting the same item.


Design and implement tile to show vehicle identifier number in vehicle properties area

User story

As a user
I want to be able to see the vehicle identifier number in the vehicle properties context
So that I can identify my car.

Acceptance criteria

In the vehicle properties context area, there is a new tile for the vehicle identifier number.
The tile has a title.
On the tile, the vehicle identifier number of the car is shown.

Definition of done (DoD)

Code compiles and builds
Acceptance criteria are met
Tests have been written and were passed
Code is peer-reviewed
Feature is merged into development branch
Documentation is updated
Bill of Materials is updated

DoD general criteria

Feature has been fully implemented
Feature has been merged into the mainline
All acceptance criteria were met
Product owner approved features
All tests are passing
Developers agreed to release

I could not read the official vin because the property INFO_VIN needs the PERMISSION_IDENTIFICATION which is protected by "signature|privileged" protection level. So this is only possible for system apps. In the meeting on Friday we decided to make the vin editable. Now it is possible to enter the vin of the car into the app and save it for later use.


WebSocket didn't emit data from scheduler

Hello, i created CLI version play-with-docker, however when i try to connect to websocket, it didn't receive  any event but able to emit terminal in and successfully displayed in the terminal output, it worked yesterday :/
Ref: https://github.com/ii64/play-with-docker-cli/blob/master/api/dashboard.go#L294

The best place to test this is against the code in this repo, not the production environment.


I got "Failed to start instrumentation" message.

when selendroid server executes command shell am instrument,
aut will be started on device.
it usually worked well but some auts not be started on device.
I found when starting aut failed selendroid server keep trying start and stop using shell am instrument and shell am force-stop commands.
I wonder what problem is that and how to solve it.
here is error message
INFO: executing command: /Users/skplanet/adt-bundle-mac-x86_64-20131030/sdk/platform-tools/adb -s 42f7ecb874668f6f shell am instrument -e main_activity com.skp.styletag.activity.SplashActivity -e server_port 8080 io.selendroid.com.skp.styletag/io.selendroid.ServerInstrumentation
1? 22, 2014 10:56:40 ?? io.selendroid.server.model.SelendroidStandaloneDriver createNewTestSession
INFO: error while starting selendroid: Failed to start instrumentation
1? 22, 2014 10:56:40 ?? io.selendroid.io.ShellCommand exec
INFO: executing command: /Users/skplanet/adt-bundle-mac-x86_64-20131030/sdk/platform-tools/adb -s 42f7ecb874668f6f shell am force-stop com.skp.styletag
1? 22, 2014 10:56:41 ?? io.selendroid.io.ShellCommand exec
INFO: executing command: /Users/skplanet/adt-bundle-mac-x86_64-20131030/sdk/platform-tools/adb -s 42f7ecb874668f6f shell am force-stop com.skp.styletag
1? 22, 2014 10:56:42 ?? io.selendroid.android.impl.AbstractDevice kill
INFO: logcatWatchdog logcatWatchdog = io.selendroid.android.impl.DefaultHardwareDevice@125b267f null

I'm closing this issue due to inactivity.
If is a question rather than an issue, please send questions to the selendroid user group.
If you think it's an actual problem with selendroid and still experience the issue described on the latest release of selendroid feel free to file a new issue. If you do please provide a concise reproducible test case and describe what results you are seeing and what results you expect.


Add the necessary for replica set fields to ismaster response

Description

Closes #3556.
In this PR: the minimal necessary changes related to replica set params necessary to connect meteor to FerretDB.
Oplog collection needs to be created manually (as usual in FerretDB).
Readiness checklist

[ ] I added/updated unit tests (and they pass).
[ ] I added/updated integration/compatibility tests (and they pass).
[ ] I added/updated comments and checked rendering.
[x] I made spot refactorings.
[ ] I updated user documentation.
[ ] I ran task all, and it passed.
[x] I ensured that PR title is good enough for the changelog.
[x] (for maintainers only) I set Reviewers (@FerretDB/core), Milestone (Next), Labels, Project and project's Sprint fields.
[x] I marked all done items in this checklist.

@henvic @noisersup PTAL


Quantization-aware models increase in size

Hi, I am training a model using quantization-aware training, and I have a couple of questions:

It seems to actually increase the size of the model (from ~87Mb to ~137Mb). I have come across this explanation on https://nervanasystems.github.io/distiller/quantization.html:

A full precision copy of the weights is maintained throughout the training process ("weights_fp" in the diagram). Its purpose is to accumulate the small changes from the gradients without loss of precision (Note that the quantization of the weights is an integral part of the training graph, meaning that we back-propagate through it as well). Once the model is trained, only the quantized weights are used for inference.

Which lead me to think that the checkpoint actually contains two sets of weights, and thus it is heavier. Is there any way to discard the full precision weights once the training is finished? Or am I not understanding something?

I understand that distiller does not support real quantization, and, instead, uses a wrapper around the quantized parts. However, should I export to model to ONNX, would it be executed as a real quantized model?
Thanks in advance!

Apologies for the very late response. To your questions:

You're correct, both sets of weights are kept. I don't think deleting the set of FP32 weights would work, because when you try to load the checkpoint, even if only for evaluation, when loading the state_dict it will still look for the FP32 weights. That's because they're defined as a buffer, which means PyTorch tried to load them. You could probably override that manually in the code if you really wanted to.
I'm not sure if you're referring here to models quantized with quant-aware training, or using post-training quantization.

For quant-aware training, the short answer is no. The long answer is that only "fake-quantization" is done. That is, we do perform quantization + de-quantization on the data and then the layers execute in their vanilla FP32 form. Even if those fake-quantization operations can be exported to ONNX (haven't tried), you'll still end up with a full FP32 model.
For post-training quantization, we don't support ONNX export. But, we added the ability to convert a model post-train quantized with Distiller to a "native" PyTorch model, using the native PyTorch quantization APIs. Which will execute as a real quantized model, as you put it (only on CPU for the moment, which is what PyTorch supports). see here for details.

Thanks for your answer. Looking forward for ONNX exporting support!

I'm sorry, I don't understand. As the state_dict is now modified by the addition of various parameters, I cannot load it in my model using the .pth file that is generated. In such a scenario how do I evaluate the results of my model after QAT?

@xserraalza, how did you evaluate your model after QAT?


Replace Math with MyST InlineMath

Next step would be to replace BlockMath with MyST Math

Finally the CI is green, with Deploy preview as well: https://papyri-5u0nn2aai-papyri.vercel.app/


Use of "import from derivation" is causing issues with docker / CI.

I've got a coworker who is trying to get an Obelisk project setup in a docker based CI environment, where they're not willing to use the --priviledged option.  This means that the import-from-derivation stuff done in the ob project template (inside ./obelisk/impl/default.nix, and again in ./deps/reflex-platform/default.nix in the main Obelisk repository) cause builds to fail with permission issues.
I can get past the first of these issues by setting up Obelisk as a git submodule in ./obelisk/impl, but I can't set up reflex-platform in there because I'd have a submodule containing a submodule.
If I could change this such that the path to reflex-platform was overridable, I could probably submodule my way to victory.
So I have two questions:

would you be open to such a change?
would you be open to a change that adds an extra option to ob init to set this up for people right from the start?

I'm happy to hack away on these things myself, I just wanted to make sure it's something folks are interested in.

I'd be happy to make reflex-platform configurable, but I'm really surprised that import-from-derivation has this kind of security implication.  Is that fundamental or just a quirk of how nix works?

What do docker privileges have to do with IFD?

I think you're going to run into this problem regardless; callCabal2nix is used extensively in reflex-platform, which relies on IFD.

I would be interested in knowing where Nix fails in Docker with unprivileged. Most likely it is a bug in Nix. You may have to add the SYS_CHROOT capability though.

Maybe I should provide some more context :)
If we're in this and try to build the artifacts for an Obelisk project we get:
8964b3248562:/code# nix-build . -A exe -o result-exe --show-trace
error: cloning builder process: Operation not permitted
error: while evaluating anonymous function at /code/default.nix:1:1, called from undefined position:
while evaluating the file '/code/.obelisk/impl/default.nix':
unable to start build process

and if I make .obelisk/impl a submodule pointing at the Obelisk repository we get:
error: cloning builder process: Operation not permitted
error: while evaluating anonymous function at /code/default.nix:1:1, called from undefined position:
while evaluating 'project' at /code/.obelisk/impl/default.nix:252:19, called from /code/default.nix:5:1:
while evaluating 'projectOut' at /code/.obelisk/impl/default.nix:255:22, called from /code/.obelisk/impl/default.nix:313:8:
while evaluating 'getReflexPlatform' at /code/.obelisk/impl/default.nix:6:23, called from /code/.obelisk/impl/default.nix:255:28:
while evaluating the file '/code/.obelisk/impl/dep/reflex-platform/default.nix':
unable to start build process

which is what made me think IFD was the problem.
From some googling and one of the other Obelisk issues, I think that sysctl -w kernel.unprivileged_userns_clone=1 might help but I don't know if the ops person I'm talking to is going to go for that.

Yeah, I've now done my very first Docker thing and it's working fine for me.  I'll chat with the ops person who was running into this issue and try to work out where our approaches differ.
Sorry for the noise, and thanks for the help.

I'd there anything we can improve/document to help people who might find
themselves in a similar situation in the future?
On Wed, Aug 8, 2018, 20:57 Dave Laing<EMAIL_ADDRESS>wrote:

Yeah, I've now done my very first Docker thing and it's working fine for
me. I'll chat with the ops person who was running into this issue and try
to work out where our approaches differ.
Sorry for the noise, and thanks for the help.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/obsidiansystems/obelisk/issues/192#issuecomment-411602682,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABGlYAS8DO5oQrN5wFekfvFInv2g9hJfks5uO4jigaJpZM4VzZmJ
.

All I can think of is to tweak the installation instructions.  Maybe a new entry in between "other linux" and "macOS"? It could possibly be done with a tweak from "other linux" to "other linux (but not docker)", but getting the wording right so that it flows properly could be tricky.


"Command not found" error when opening a file

Just installed the plugin, and opened up a java file in a project i'm working on. I get this error immediately (before the file loads):
Error detected while processing function 26_setup_gutentags..26_update_tags:
line   74:
E371: Command not found
Error detected while processing function 26_setup_gutentags:
line   42:
E171: Missing :endif

Did you install ctags, and is it in your PATH?

Yep! If I go to a command prompt to C: and type "ctags" I get "ctags: no files specified". So it's on my path.

Can you set g:gutentrace_trace to 1 in your vimrc, or run :GutentagsToggleTrace?
It should start spamming you with messages when it does something. This way, you can see exactly what command line it's running, and you can check stuff is OK. It will also output a <tagfile name>.log file next to the tags file, so you can also see any problem coming from inside the update script. You can post the results here if there's nothing obvious.

Nothing much illuminating here...all the paths are correct (in particular the location of C:\home\config\vimfiles\plat\win32\update_tags.cmd is correct. Weird.
    gutentags: Scanning buffer 'C:\home\projects\turnstile\core\src\com\agencyport\turnstile\Turnstile.java' for gutentags setup...
    gutentags: Setting gutentags for buffer 'C:\home\projects\turnstile\core\src\com\agencyport\turnstile\Turnstile.java' with tagfile: C:\home\projects\turnstile\core\tags
    gutentags: Generating missing tags file: C:\home\projects\turnstile\core\tags
    gutentags: Running: !start /b C:\home\config\vimfiles\plat\win32\update_tags.cmd -e "ctags" -t "C:\home\projects\turnstile\core\tags" -p "C:\home\projects\turnstile\core" -l "C:\home\projects\turnstile\core\tags.log"
    gutentags: In:      C:\home\projects\turnstile\core
    :!start /b C:\home\config\vimfiles\plat\win32\update_tags.cmd -e "ctags" -t "C:\home\projects\turnstile\core\tags" -p "C:\home\projects\turnstile\core" -l "C:\home\projects\turnstile\core\tags.log"

    Error detected while processing function <SNR>26_setup_gutentags..<SNR>26_update_tags:
    line   76:
    E371: Command not found
    Error detected while processing function <SNR>26_setup_gutentags:
    line   42:
    E171: Missing :endif

Also C:\home\config\vimfiles\plat\win32\update_tags.cmd -e "ctags" -t "C:\home\projects\turnstile\core\tags" -p "C:\home\projects\turnstile\core" -l "C:\home\projects\turnstile\core\tags.log" (which I cut and pasted from the "start" command above), when run on the command line, does indeed generate  a tags file for the project.

Aha! It was a bug in Vim. I was on version 7.3.46; grabbing the latest (7.4) and the problem went away.

Interesting... I'll reopen this to remember to add a version check to the plugin, then. Thanks!


PaginatorInterface: don't block while adding reactions

allows the user to hit the close button before the other reactions are added

I'm rejecting this implementation because it breaks a PaginatorInterface implementation security: that being that PaginatorInterface.send_to is guaranteed to raise if the creation of the interface has knowingly failed.
This breaks that security in the case where the bot lacks the permissions to add reactions to the message, so I can't accept this. I will think of a way to deal with early reactions myself.

I realized while rethinking this that I was actually wrong - the first close reaction happens unconditionally and should guarantee further permissions (within the realm of possibility).
Nevertheless, the functionality of this PR has been nulled by 4bfafc53e9abd224c678e090ef0d5d6382ee7551, implemented by simply starting the wait loop sooner.
This has caused a bug to regress in less tolerant PaginatorInterface handlers - such as jsk cat. I'll need to fix this at a later date.


Error when trying to split a layout: 'Instance not within any layout'

I'm getting an 'Instance not within any layout' error when I try to split the root layout defined in my main window's XAML.
The main window is declared as:
<catel:DataWindow x:Class="Views.HerbertWindow"
        xmlns="http://schemas.microsoft.com/winfx/2006/xaml/presentation"
        xmlns:x="http://schemas.microsoft.com/winfx/2006/xaml"
        xmlns:mc="http://schemas.openxmlformats.org/markup-compatibility/2006"
        xmlns:d="http://schemas.microsoft.com/expression/blend/2008"
        xmlns:local="clr-namespace:SRH.Herbert"
        xmlns:h="clr-namespace:SRH.Herbert.Helpers"
        xmlns:uc="clr-namespace:SRH.Herbert.UserControls"
        xmlns:vm="clr-namespace:SRH.Herbert.ViewModels"
        xmlns:catel="http://catel.codeplex.com"
        xmlns:dragablz="http://dragablz.net/winfx/xaml/dragablz"
        xmlns:dockablz="http://dragablz.net/winfx/xaml/dockablz"
        mc:Ignorable="d"
        Title="{Binding Title}"
        Left="{Binding Left, Mode=TwoWay}" Top="{Binding Top, Mode=TwoWay}"
        Height="{Binding Height, Mode=TwoWay}" Width="{Binding Width, Mode=TwoWay}"
        MinHeight="{Binding MinHeight}" MinWidth="{Binding MinWidth}"
        ShowInTaskbar="True" ResizeMode="CanResizeWithGrip" SizeToContent="Manual"
        WindowStartupLocation="Manual" WindowState="Normal">

    <!--  Ribbon definition -->
            <Ribbon>
                <Button>Button 1</Button>
            </Ribbon>

            <!-- StatusBar definition -->
            <StatusBar Grid.Row="2">
                <StatusBar.ItemsPanel>
                    <ItemsPanelTemplate>
                        <Grid>
                            <Grid.ColumnDefinitions>
                                <ColumnDefinition Width="*" ></ColumnDefinition>
                                <ColumnDefinition Width="Auto" ></ColumnDefinition>
                            </Grid.ColumnDefinitions>
                        </Grid>
                    </ItemsPanelTemplate>
                </StatusBar.ItemsPanel>
                <TextBlock > Left Side</TextBlock>
                <StatusBarItem Grid.Column="3">
                    <TextBlock > Right Side</TextBlock>
                </StatusBarItem>
            </StatusBar>

            <dockablz:Layout Grid.Row="1"
                             Partition="2AE89D18-F236-4D20-9605-6C03319038E6"
                             x:Name="RootLayout"
                             IsFloatDropZoneEnabled="False">

                <!-- branch template lets dragablz create a new tab control after a window is split via docking -->
                <dockablz:Layout.BranchTemplate>
                    <DataTemplate>
                        <dragablz:TabablzControl Style="{StaticResource TabablzControlStyle}">
                            <dragablz:TabablzControl.InterTabController>
                                <dragablz:InterTabController InterTabClient="{Binding InterTabClient}"
                                                             Partition="2AE89D18-F236-4D20-9605-6C03319038E6" />
                            </dragablz:TabablzControl.InterTabController>
                        </dragablz:TabablzControl>
                    </DataTemplate>
                </dockablz:Layout.BranchTemplate>

                <!-- a root, named tab control is needed, so when a tab is torn and a new window is created,
                     the new target tab control can be identified -->
                <dragablz:TabablzControl x:Name="InitialTabablzControl"
                                         FixedHeaderCount="1"
                                         ItemsSource="{Binding TabItemsSource}"
                                         Style="{StaticResource TabablzControlStyle}"
                                         AddLocationHint="After">
                    <dragablz:TabablzControl.InterTabController>
                        <dragablz:InterTabController InterTabClient="{Binding InterTabClient}"
                                                     Partition="2AE89D18-F236-4D20-9605-6C03319038E6" />
                    </dragablz:TabablzControl.InterTabController>
                </dragablz:TabablzControl>
            </dockablz:Layout>
        </Grid>
    </DockPanel>
</catel:DataWindow>

I'm trying to create the split layout in my  VB application's OnStartup event handler, using the following code:
    ' Instantiate the Herbert application.
    HerbertApp = New App()

    With HerbertApp
        ' Instantiate the main Herbert window.
        MainHerbertWindow = New HerbertWindow
        .MainWindow = MainHerbertWindow

        Dim myTabablzControl As TabablzControl = MainHerbertWindow.InitialTabablzControl
        Dim myLayout As Layout = MainHerbertWindow.RootLayout

        Dim newTabablzControl As TabablzControl = myLayout.Branch(myTabablzControl, Orientation.Vertical,
                                                                  False, 0.25).TabablzControl

VS throws the 'Instance not within any layout' error when it tries to execute the Branch(), despite myTabablzControl having RootLayout as its Parent (so it must be in a layout). I've tried doing the split in a TabablzControlProxy class, passing the initial TabablzControl to its constructor. However the result was the same. The error details are shown in this screenshot:

If I comment out the lines with the call to Branch() my skeleton application window opens with the TabablzControl containing an HeaderedItemViewModel item that is added in its viewmodel (as shown below). I can add new items by clicking on the add tab item button, and I can tear off tabs and then dock them to the initial TabablzControl (which successfully creates splits in the layout).

It's possible this 'Instance not within any layout' problem is somehow being caused by Catel, which I've just started using. When the type of the main window was System.Window instead of Catel.DataWindow I was able to split the initial TabablzControl by means of code similar to the above in a TabablzControlProxy class. However, I'm keen to keep using Catel if possible, so would really appreciate any suggestions of how to overcome this problem.
For example, is it possible to instantiate the Layout and its TabablzControl in code rather than in the main window XAML, and would that be likely to get around the problem?
Stephen

Hi,  Can you please post a small example GitHub repository.

Hi
Thanks for the quick response! I'm just putting one together and will post it soon.

Hi
I've posted a small test application that creates a window containing a Dragablz control, from which tabs can be torn off and then docked with the original control to create split layouts. An attempt to open the window with a split already performed using code in the OnStartup event handler fails, however.
Any suggestions that get this functionality working will be greatly appreciated!
https://github.com/AnotherKiwi/Catel-and-Dragablz-Test

Hi
I've posted a small test application that creates a window containing a Dragablz control, from which tabs can be torn off and then docked with the original control to create split layouts. An attempt to open the window with a split already performed using code in the OnStartup event handler fails, however.
Any suggestions that get this functionality working will be greatly appreciated!
https://github.com/AnotherKiwi/Catel-and-Dragablz-Test

Did you ever solve this issue?


Remote item fetching after the initial fetch should only fetch modified items

Expected behavior
Remote item fetching after the initial fetch should only fetch modified items
Actual behavior
Every time the same items are retrieved without considering it's modified or not

@aslakknutsen I have created a PR (#585) to make use the Sort by updated and Order desc for Github. This is part of the REST API provided by Github and query itself. I think this should be good enough for Github. It is possible to modify the search input provided by the user, but I am afraid it may override the ident of the user sometimes.
In the case of Jira, there is no such API. Modifying the JQL has the same problem mentioned above.
Please suggest!

Duplicate https://github.com/almighty/almighty-core/issues/372


Not working with PhoneGap Build for Android?

I cannot get this plugin to work using PhoneGap Build for Android.  The discussion in this open issue relating to iOS seems to indicate getting it working for Android might be less problematic than for iOS.  Since that question & discussion related specifically to iOS, opening a new issue/question here for Android.
Is there a PGB workaround that works for Android?
(There's some discussion in the above issue about altering the AndroidManifest.xml using Cordova/PGB <config-file> tags, but I'm not sure what actually needs to be changed there for this plugin to work.)

OK, after (finally!) getting local cordova working to compare, and some trial-and-error, I can get this plugin partly working with PhoneGap Build with these additions to the config.xml:
<config-file platform="android" parent="/manifest/application" mode="merge">
	<activity android:launchMode="singleTask" />
</config-file>

<config-file platform="android" target="AndroidManifest.xml" parent="/manifest/application/activity[1]" mode="add">
	<intent-filter android:autoVerify="true">
		<action android:name="android.intent.action.VIEW" />
		<category android:name="android.intent.category.DEFAULT" />
		<category android:name="android.intent.category.BROWSABLE" />
		<data android:scheme="https" android:host="MYDOMAINHERE" android:path="/MYPATHHERE" />
	</intent-filter>
	<intent-filter android:autoVerify="true">
		<action android:name="android.intent.action.VIEW" />
		<category android:name="android.intent.category.DEFAULT" />
		<category android:name="android.intent.category.BROWSABLE" />
		<data android:scheme="https" android:host="OTHERDOMAINHERE"/>
	</intent-filter>
</config-file>

However, while links now trigger the app to open, the universalLinks.subscribe() callback doesn't seem to fire (neither with the default event, or with custom events).  (As was mentioned already here, we need a way to tell the plugin about which events to fire, and PGB apparently strips the  tag from the config.xml.)
@nikDemyankov - you mentioned a "ul.json" type solution in issue 28.  Is this something that is implemented for Android, or could be?

Any luck with this @blukis ?

Nope.  I'm hoping someone smarter than me can help fill in there gaps I left above.  :)
I think the "ul.json" type solution discussed in the other issue would do the trick, but was unclear from that discussion whether that was ever implemented for Android.  (Looks like they were trying it in iOS, then ran into some iOS-specific showstoppers?)


Google Drive download path is invalid.

I think your Google Drive Download Link path is invalid.
Please check your README.md
When click the Google Drive Download Link attatched, only reload the page of the repo.
Thank you for your appreciate :)

Got it, I will upload the models into the Google Drive in the next two days!

The Google Drive upload is complete


ET for Profile and email notifications

Went to edit profile. Didn't make any changes. Clicked save. No email received as expected, but did get a message that said "Account Settings Changed!"

Went to edit profile. Changed email address. Clicked "Save". Received an email to confirm new email address. Email address doesn't provide any information about the actual emails being changed. We should fix this later.

Without confirming the email change, I went back to edit profile. Blue info message shows that there's a pending email address change. Email field shows old email address. There's no way to cancel the change.

Same as #3. Went back to Edit Profile with a pending email change.  Did not make any changes. Clicked "Save". A new email change confirmation email was sent. If no changes are made, we shouldn't resend the email. We should probably disable the Save button until a change is made. Thoughts?

Clicked on the email change confirmation URL in the email: Visiting the edit profile page shows the new email address and the pending change message goes away. Received an email at the old address that my email address was changed..

After confirming the email address change, went back to old email and clicked on the confirmation URL again. Got an error "Could not confirm your email address.".

Went to edit profile and unchecked "Receive Email Notifications". Clicked "Save". Received an email change notification email. That should not happen..

After turning off email notifications, I changed my email address. This sent an email confirmation as expected, otherwise you can't change your email!.

After turning off email notifications, I logged in as a different user. I then added the original user (the one with notifications turned off) as a package owner. No email was sent to the user who has email notifications turned off. There's no way for this user to know he or she is being added to a package at this point.

After turning email notifications back on, I was able to receive an email when another user added me as a package owner.

I contacted the owner and received a message, when I uncheck the mail notification I cannot use the "Contact Owner" page.


Move generate_coverage.py as function to vptstools

Cf. #17 @stijnvanhoey, you probably have already started with this?
Note that the generate_coverage.py might no longer be needed if we use AWS Inventory.

Indeed, this will be replaced by the inventory based code. Will close this once the operational code of https://github.com/enram/vptstools/pulls is properly checked.

Fixed by https://github.com/enram/vptstools/pull/45


Request to add bookmark search function

Description of the new feature / enhancement
Request to add bookmark search function
Scenario when this would be used?
Directly search bookmarks that have been favorited in various browsers
Supporting information
No response

Duplicate of #8283

Thanks for your suggestion. This issue has been raised in #8283. Please go to that issue for supporting information.

Duplicate of #8283


Merge the TerminalDispatch and AdaptDispatch classes

Summary of the Pull Request
This PR replaces the TerminalDispatch class with the AdaptDispatch class from conhost, so we're no longer duplicating the VT functionality in two places. It also gives us a more complete VT implementation on the Terminal side, so it should work better in pass-through mode.
References
This is essentially part two of PR #12703.
PR Checklist

[x] Closes #3849
[x] CLA signed.
[ ] Tests added/passed
[ ] Documentation updated.
[ ] Schema updated.
[x] I've discussed this with core contributors already. Issue number where discussion took place: #12662

Detailed Description of the Pull Request / Additional comments
Validation Steps Performed

i am so excited

i am so excited

Yeah, me too. But be aware that the terminal side isn't fully functional as a standalone VT implementation yet. I think the two big things outstanding now are the _AdjustCursorPosition and _WriteBuffer implementations, which should ideally be unified with conhost. We're getting close though.

We should merge this PR before we get to #13025.

Technically it's ready for review - I don't have plans to add more code - I'm just still doing some testing, and I want to add some copy for the validation section of the commit message.
And yeah Sixel is probably my number one reason for doing this. I've been putting off committing something because I didn't want to add yet another feature that only worked in conhost, but if I can get it to work in Terminal with the passthrough mode (even if imperfectly), I'd feel a lot better about it.

Meh, I was 40/42 on this so far, but I'm too excited. I didn't find anything so far. I trust the other guys, so: @msftbot merge this in 1 minute


RangeError (index): Invalid value: Not in range 0..3, inclusive:4

i recently ran into a problem with android 7 and 9 .the error displayed is  RangeError (index): Invalid value: Not in range 0..3, inclusive:4
Question is already on SO.
My splash screen works then after that  the app loads a root screen.
Here is the code for root screen:
class _RootScreenState extends State<RootScreen> {
  @override
  Widget build(BuildContext context) {
    return new StreamBuilder<FirebaseUser>(
      stream: FirebaseAuth.instance.onAuthStateChanged,
      builder: (BuildContext context, snapshot) {
        if (snapshot.connectionState == ConnectionState.waiting) {
          return new Container(
            color: Colors.white,
          );
        } else {
          if (snapshot.hasData) {
            return new Home(
              firebaseUser: snapshot.data,
            );
          } else {
            return OnBoarding();
          }
        }
      },

flutter v 1.10.2

Logs

flutter run --verbose
[  +45 ms] executing: [E:\firefox\flutter_windows_v1.5.4-hotfix.2-stable\flutter\] git -c
log.showSignature=false log -n 1 --pretty=format:%H
[ +439 ms] Exit code 0 from: git -c log.showSignature=false log -n 1 --pretty=format:%H
[  +65 ms] f5733f7a62ebc7c2ba324a2b410cd81215956b7d
[   +2 ms] executing: [E:\firefox\flutter_windows_v1.5.4-hotfix.2-stable\flutter\] git describe --match
v*.*.* --first-parent --long --tags
[ +127 ms] Exit code 0 from: git describe --match v*.*.* --first-parent --long --tags
[   +1 ms] v1.10.2-0-gf5733f7a6
[  +52 ms] executing: [E:\firefox\flutter_windows_v1.5.4-hotfix.2-stable\flutter\] git rev-parse
--abbrev-ref --symbolic @{u}
[ +593 ms] Exit code 0 from: git rev-parse --abbrev-ref --symbolic @{u}
[   +1 ms] origin/dev
[        ] executing: [E:\firefox\flutter_windows_v1.5.4-hotfix.2-stable\flutter\] git ls-remote --get-url
origin
[ +110 ms] Exit code 0 from: git ls-remote --get-url origin
[        ] https://github.com/flutter/flutter.git
[ +119 ms] executing: [E:\firefox\flutter_windows_v1.5.4-hotfix.2-stable\flutter\] git rev-parse
--abbrev-ref HEAD
[  +64 ms] Exit code 0 from: git rev-parse --abbrev-ref HEAD
[        ] dev
[ +433 ms] executing: C:\Users\griffins\Downloads\sdk\platform-tools\adb.exe devices -l
[  +32 ms] Exit code 0 from: C:\Users\griffins\Downloads\sdk\platform-tools\adb.exe devices -l
[        ] List of devices attached
[  +15 ms] No supported devices connected.
[ +566 ms] "flutter run" took 562ms.

#0      throwToolExit (package:flutter_tools/src/base/common.dart:28:3)
#1      RunCommand.validateCommand (package:flutter_tools/src/commands/run.dart:268:7)
<asynchronous suspension>
#2      FlutterCommand.verifyThenRunCommand (package:flutter_tools/src/runner/flutter_command.dart:465:11)
<asynchronous suspension>
#3      FlutterCommand.run.<anonymous closure>
(package:flutter_tools/src/runner/flutter_command.dart:407:33)
<asynchronous suspension>
#4      AppContext.run.<anonymous closure> (package:flutter_tools/src/base/context.dart:154:29)
<asynchronous suspension>
#5      _rootRun (dart:async/zone.dart:1124:13)
#6      _CustomZone.run (dart:async/zone.dart:1021:19)
#7      _runZoned (dart:async/zone.dart:1516:10)
#8      runZoned (dart:async/zone.dart:1463:12)
#9      AppContext.run (package:flutter_tools/src/base/context.dart:153:18)
<asynchronous suspension>
#10     FlutterCommand.run (package:flutter_tools/src/runner/flutter_command.dart:397:20)
#11     CommandRunner.runCommand (package:args/command_runner.dart:197:27)
<asynchronous suspension>
#12     FlutterCommandRunner.runCommand.<anonymous closure>
(package:flutter_tools/src/runner/flutter_command_runner.dart:402:21)
<asynchronous suspension>
#13     AppContext.run.<anonymous closure> (package:flutter_tools/src/base/context.dart:154:29)
<asynchronous suspension>
#14     _rootRun (dart:async/zone.dart:1124:13)
#15     _CustomZone.run (dart:async/zone.dart:1021:19)
#16     _runZoned (dart:async/zone.dart:1516:10)
#17     runZoned (dart:async/zone.dart:1463:12)
#18     AppContext.run (package:flutter_tools/src/base/context.dart:153:18)
<asynchronous suspension>
#19     FlutterCommandRunner.runCommand
(package:flutter_tools/src/runner/flutter_command_runner.dart:356:19)
<asynchronous suspension>
#20     CommandRunner.run.<anonymous closure> (package:args/command_runner.dart:112:25)
#21     new Future.sync (dart:async/future.dart:224:31)
#22     CommandRunner.run (package:args/command_runner.dart:112:14)
#23     FlutterCommandRunner.run (package:flutter_tools/src/runner/flutter_command_runner.dart:242:18)
#24     run.<anonymous closure>.<anonymous closure> (package:flutter_tools/runner.dart:63:22)
<asynchronous suspension>
#25     _rootRun (dart:async/zone.dart:1124:13)
#26     _CustomZone.run (dart:async/zone.dart:1021:19)
#27     _runZoned (dart:async/zone.dart:1516:10)
#28     runZoned (dart:async/zone.dart:1500:12)
#29     run.<anonymous closure> (package:flutter_tools/runner.dart:61:18)
<asynchronous suspension>
#30     AppContext.run.<anonymous closure> (package:flutter_tools/src/base/context.dart:154:29)
<asynchronous suspension>
#31     _rootRun (dart:async/zone.dart:1124:13)
#32     _CustomZone.run (dart:async/zone.dart:1021:19)
#33     _runZoned (dart:async/zone.dart:1516:10)
#34     runZoned (dart:async/zone.dart:1463:12)
#35     AppContext.run (package:flutter_tools/src/base/context.dart:153:18)
<asynchronous suspension>
#36     runInContext (package:flutter_tools/src/context_runner.dart:61:24)
<asynchronous suspension>
#37     run (package:flutter_tools/runner.dart:50:10)
#38     main (package:flutter_tools/executable.dart:65:9)
<asynchronous suspension>
#39     main
(file:///E:/firefox/flutter_windows_v1.5.4-hotfix.2-stable/flutter/packages/flutter_tools/bin/flutter_tools.dart:8:3)
#40     _startIsolate.<anonymous closure> (dart:isolate-patch/isolate_patch.dart:303:32)
#41     _RawReceivePortImpl._handleMessage (dart:isolate-patch/isolate_patch.dart:172:12)

flutter doctor -v
flutter doctor -v
[√] Flutter (Channel dev, v1.10.2, on Microsoft Windows [Version 10.0.17763.503], locale en-US)
    • Flutter version 1.10.2 at E:\firefox\flutter_windows_v1.5.4-hotfix.2-stable\flutter
    • Framework revision f5733f7a62 (12 days ago), 2019-09-11 21:03:42 -0700
    • Engine revision 7ea9884ab0
    • Dart version 2.5.0 (build 2.5.0-dev.4.0 be66176534)

[√] Android toolchain - develop for Android devices (Android SDK version 28.0.3)
    • Android SDK at C:\Users\griffins\Downloads\sdk
    • Android NDK location not configured (optional; useful for native profiling support)
    • Platform android-29, build-tools 28.0.3
    • Java binary at: C:\Program Files\Android\Android Studio\jre\bin\java
    • Java version OpenJDK Runtime Environment (build 1.8.0_202-release-1483-b03)
    • All Android licenses accepted.

[√] Android Studio (version 3.5)
    • Android Studio at C:\Program Files\Android\Android Studio
    • Flutter plugin version 39.0.3
    • Dart plugin version 191.8423
    • Java version OpenJDK Runtime Environment (build 1.8.0_202-release-1483-b03)

[√] IntelliJ IDEA Community Edition (version 2019.1)
    • IntelliJ at C:\Users\griffins\AppData\Local\JetBrains\IntelliJ IDEA Community Edition 2019.1.1
    • Flutter plugin version 35.3.2
    • Dart plugin version 191.7019

[√] VS Code (version 1.38.1)
    • VS Code at C:\Users\griffins\AppData\Local\Programs\Microsoft VS Code
    • Flutter extension version 3.4.1

[!] Connected device
    ! No devices available

! Doctor found issues in 1 category.

Can you post a runnable minimal code snippet that we can copy and run to reproduce the error?

i cant single out sample code...i'm still trying to figure out what caused the crash .

Hi @ggichure
Closing as there are not sufficient details to act upon this issue. If the problem persists, please create a new issue and provide the information required in the template.
Thank you

well if you stop the app and run it again then it will work cause that's what happened with mine