Trying to parse attachments when unavailable leading to NullPointerException

When there are no attachments, we are still trying to parse the attachment which leads to NullPointerException. Shall we have an if condition so that the attachments will be parsed only if hasAttachments is true.

Can I take this up and fix this issue?

well hey👋@aarahmanqa , thanks for pointing out this issue.
maybe mail.tm has gone through some changes in their api because i remember it used to return an empty array[] keeping that aside i would love to merge your pull request so you can work on that bug. (I'm just hoping it doesn't break anything 😜)

Thanks Shivam. I would like to ask one more thing. There are many places here that are prone to NullPointerException.
Like, json.get("html").toString();
In case, the json.get("html") returns null, we would get NullPointerException. Rather it would be good if we can get it as null itself.
To overcome such issues, I used to follow this. Shall I implement the same here as well?

the mail.tm api promise the value of the key html in the json so it would never throw NullPointer because mailtm converts raw text to html format and even if you supply no body to the smtp protocol its going to return an empty array[]
so i don't think there is any need for it.

Yeah I agree to your point Shivam. I have mentioned "html" just for reference. It could happen in any field. When a field is null, we need to accept it as null, right? It would be better instead of throwing NullPointerException. I will propose my solution as enhancement and raise PR, we shall discuss it. Please feel free to close it if not needed.

I have raised PR for this issue. Request you to kindly go through the same.
https://github.com/shivam1608/JMailTM/pull/6

Fixed in pull request #6 👍

@shivam1608 , when shall we expect the fix in remote build?


GPUCounter.EventGPUDuration claims to be type Float, but the real value seems to be in result.value.d

Description
I ran into this issue while trying to measure GPU frame timings using the renderdoc Python API. ReplayController.DescribeCounter(renderdoc.GPUCounter.EventGPUDuration).resultType returns "CompType.Float", and so I would expect to read its value from CounterValue.f . However, this was giving me garbage results. Digging into the RenderDoc source, I see that EventBrowser::SetTimes() uses r.value.d, and using this in my own code gives reasonable numbers. Looking at the CompType class, there's no entry for Double, so I'm assuming it treats Doubles as Floats - it would be helpful if this was explicitly stated in the docs for CounterResult.
Steps to reproduce

From the Python API, load any capture into a ReplayController
query controller.DescribeCounter(renderdoc.GPUCounter.EventGPUDuration).resultType - returns "CompType.Float"
compare the values of result.value.f and result.value.d in the results of controller.FetchCounters([rd.GPUCounter.EventGPUDuration]) - result.value.d contains the real data

Environment

RenderDoc version: 1.15
Operating System: Windown 10 64-bit
Graphics API: D3D11

You've only used half of the information that CounterDescription gives about the result type. The CompType enumeration describes only the base type of the data - i.e. float, signed integer, unsigned integer. From the documentation of CompType.Float:

Float
An IEEE floating point value of 64-bit, 32-bit or 16-bit size.

The other important part is CounterDescription.resultByteWidth which tells you which size, and you should see that it returns 8 when the information is stored in doubles, which tells you that you need to look in CounterResult.d. If it returned 4 then the data would be stored in CounterResult.f.


acquireTokenSilent failing in only IE11 (embedded iframe scenario)

Please follow the issue template below. Failure to do so will result in a delay in answering your question.

Library

[x]<EMAIL_ADDRESS>
Description
acquireTokenSilent issues in IE11, whereas it is working properly in all other browsers (Chrome, FF, Edge Chromium), using the exact same code path. The implementation involves an embedded, hidden iframe across a large number of domains that proxies calls inside of the frame and sends their responses to the parents. The expectation is that the parent will be an authenticated page.
Previously, we have this pattern already working with ADAL.js and we are currently upgrading to use MSAL and are running into this issue that is blocking our upgrade.
The main error in the logs is:
Tue, 06 Oct 2020 20:59:57 GMT:1.4.0-Error Please call ResolveEndpointsAsync first
You can see in the network trace that https://login.microsoftonline.com/common//discovery/instance?api-version=1.1&authorization_endpoint=https://login.microsoftonline.com/organizations/oauth2/v2.0/authorize is being called properly, but there is not an ensuing call to https://login.microsoftonline.com/organizations/v2.0/.well-known/openid-configuration, which I see happening in successful cases in other browsers.
Error Message
IE11 Error Logs
Tue, 06 Oct 2020 20:59:57 GMT:1.4.0-Verbose AcquireTokenSilent has been called
Tue, 06 Oct 2020 20:59:57 GMT:1.4.0-Verbose Telemetry Event started: a2659e58-8da7-4921-a900-5cc0cc751f88_3e7295bd-01dc-41ba-b822-a484fa790b7e-msal.api_event
Tue, 06 Oct 2020 20:59:57 GMT:1.4.0-Verbose Account set from MSAL Cache
Tue, 06 Oct 2020 20:59:57 GMT:1.4.0-Verbose Response type: id_token token
Tue, 06 Oct 2020 20:59:57 GMT:1.4.0-Verbose Finished building server authentication request
Tue, 06 Oct 2020 20:59:57 GMT:1.4.0-Verbose Query parameters populated from existing SSO or account
Tue, 06 Oct 2020 20:59:57 GMT:1.4.0-Verbose GetCachedToken has been called
Tue, 06 Oct 2020 20:59:57 GMT:1.4.0-Verbose No tokens found
Tue, 06 Oct 2020 20:59:57 GMT:1.4.0-Verbose Getting all cached access tokens
Tue, 06 Oct 2020 20:59:57 GMT:1.4.0-Verbose No matching tokens found when filtered by clientId and account
Tue, 06 Oct 2020 20:59:57 GMT:1.4.0-Verbose No token found in cache lookup
Tue, 06 Oct 2020 20:59:57 GMT:1.4.0-Verbose No cached metadata for authority
Tue, 06 Oct 2020 20:59:57 GMT:1.4.0-Verbose Telemetry Event started: a2659e58-8da7-4921-a900-5cc0cc751f88_a8991d89-b8b1-4c14-a423-2838156807ad-msal.http_event
Tue, 06 Oct 2020 20:59:57 GMT:1.4.0-Verbose Authority has been updated with endpoint discovery response
Tue, 06 Oct 2020 20:59:57 GMT:1.4.0-Verbose Renewing access token
Tue, 06 Oct 2020 20:59:57 GMT:1.4.0-Verbose RenewToken has been called
Tue, 06 Oct 2020 20:59:57 GMT:1.4.0-Error Please call ResolveEndpointsAsync first

Logs for successful call in Edge Chromium
Tue, 06 Oct 2020 20:47:16 GMT:1.4.0-Verbose AcquireTokenSilent has been called
Tue, 06 Oct 2020 20:47:16 GMT:1.4.0-Verbose Telemetry Event started: 99278209-e2d7-4cb8-abce-4bfd17383bf0_33ba05f6-4bb3-48c7-897a-789e9c623e8b-msal.api_event
Tue, 06 Oct 2020 20:47:16 GMT:1.4.0-Verbose Account set from MSAL Cache
Tue, 06 Oct 2020 20:47:16 GMT:1.4.0-Verbose Response type: id_token token
Tue, 06 Oct 2020 20:47:16 GMT:1.4.0-Verbose Finished building server authentication request
Tue, 06 Oct 2020 20:47:16 GMT:1.4.0-Verbose Query parameters populated from existing SSO or account
Tue, 06 Oct 2020 20:47:16 GMT:1.4.0-Verbose GetCachedToken has been called
Tue, 06 Oct 2020 20:47:16 GMT:1.4.0-Verbose No tokens found
Tue, 06 Oct 2020 20:47:16 GMT:1.4.0-Verbose Getting all cached access tokens
Tue, 06 Oct 2020 20:47:16 GMT:1.4.0-Verbose No matching tokens found when filtered by clientId and account
Tue, 06 Oct 2020 20:47:16 GMT:1.4.0-Verbose No token found in cache lookup

Version:
MSAL Configuration
        const msalConfig: MSALConfig = {
            auth: {
                clientId: "xxxxxxxx",
                authority: "https://login.microsoftonline.com/organizations"
            },
            cache: {
                cacheLocation: "sessionStorage",
                storeAuthStateInCookie: isIE
            },
            upn: config.upn
        };

        this.userAgentApplication = new UserAgentApplication(msalConfig);

        const scopes: Array<string> = [`${resource}/.default`];
        const authenticationParameters: AuthenticationParameters = {
            scopes,
            loginHint: this.upn
        };

    public acquireToken(resource: string, callback: TokenRequestCallback): void {
        this.userAgentApplication.acquireTokenSilent(authenticationParameters).then((authResponse: AuthResponse) => {
            callback(null, authResponse.accessToken);
        }).catch((error) => {
            if (error.errorMessage.indexOf("interaction_required") !== -1) {
                // This is where we have to explore the reasons, and if it is problem only in the Iframe.
                // In such situations it may be appropriate to have user help and then used loginPopup to get user login.
                // or send message to parent page about this.
            }
            callback(error.errorMessage, null);
        });
    }

Browsers/Environment

[ ] Chrome
[ ] Firefox
[ ] Edge
[ ] Safari
[x] IE
[ ] Other (Please add browser name here)

@pmcgannon22 Are you able to make a call to the openid-configuration endpoint independent of msal js in IE11?
Also FYI: some of the IE11 issues we have seen in the past are documented here in case that helps.

@sameerag, yes, I am. I just tried sending an XHR from the console and everything seemed to work fine. I was going through that page, but wasn't able to pinpoint something that applied to my scenario.
Some additional information. Here is what sessionStorage looks like in IE after the attempt to auth with MSAL:
{
   [functions]: ,
   __proto__: { },
   constructor: { },
   length: 20,
   msal.<clientId-xxxxxx>.acquireTokenAccount|NO_ACCOUNT|<resourceId-xxxxxx>: "null",
   msal.<clientId-xxxxxx>.acquireTokenAccount|NO_ACCOUNT|<resourceId-xxxxxx>: "null",
   msal.<clientId-xxxxxx>.acquireTokenAccount|NO_ACCOUNT|<resourceId-xxxxxx>: "null",
   msal.<clientId-xxxxxx>.acquireTokenAccount|NO_ACCOUNT|<resourceId-xxxxxx>: "null",
   msal.<clientId-xxxxxx>.acquireTokenAccount|NO_ACCOUNT|<resourceId-xxxxxx>: "null",
   msal.<clientId-xxxxxx>.authority|<resourceId-xxxxx>: "https://login.microsoftonline.com/organizations/",
   msal.<clientId-xxxxxx>.authority|<resourceId-xxxxx>: "https://login.microsoftonline.com/organizations/",
   msal.<clientId-xxxxxx>.authority|<resourceId-xxxxx>: "https://login.microsoftonline.com/organizations/",
   msal.<clientId-xxxxxx>.authority|<resourceId-xxxxx>: "https://login.microsoftonline.com/organizations/",
   msal.<clientId-xxxxxx>.authority|<resourceId-xxxxx>: "https://login.microsoftonline.com/organizations/",
   msal.<clientId-xxxxxx>.nonce.idtoken|<resourceId-xxxxx>: "<requestId?-xxxxx-not totally sure>",
   msal.<clientId-xxxxxx>.nonce.idtoken|<resourceId-xxxxx>: "<requestId?-xxxxx-not totally sure>",
   msal.<clientId-xxxxxx>.nonce.idtoken|<resourceId-xxxxx>: "<requestId?-xxxxx-not totally sure>",
   msal.<clientId-xxxxxx>.nonce.idtoken|<resourceId-xxxxx>: "<requestId?-xxxxx-not totally sure>",
   msal.<clientId-xxxxxx>.nonce.idtoken|<resourceId-xxxxx>: "<requestId?-xxxxx-not totally sure>",
   msal.acquireTokenAccount|NO_ACCOUNT|<resourceId-xxxx> "null",
   msal.acquireTokenAccount|NO_ACCOUNT|<resourceId-xxxx> "null",
   msal.acquireTokenAccount|NO_ACCOUNT|<resourceId-xxxx> "null",
   msal.acquireTokenAccount|NO_ACCOUNT|<resourceId-xxxx> "null",
   msal.acquireTokenAccount|NO_ACCOUNT|<resourceId-xxxx> "null",
   remainingSpace: 5242752
}

Additionally, I am also internal Microsoft if you want/have time reach out for more context, that would be extremely helpful and potentially we can circle back with a general solution.
Appreciate the reply!

@pmcgannon22 Couple more follow up questions:

Have you followed all the considerations highlighted in our IE sample here - Including providing a promise polyfill?
Are you able to run your application successfully outside of an iframe in IE11?

@sameerag

Confirmed that Promise polyfill is in place before any MSAL code is run. Also, confirmed there is no trusted sites issue and the storeAuthStateInCookie set to true in IE contexts.
I just went directly to the embedded iframe to test and it is behaving in essentially the exact manner given the MSAL log output.

Thanks for the help.

Updating here. This ended up being an issue with my Promise polyfill being too old and/or not having the proper full implementation. I was using a custom polyfill that was defined in a downstream dependency that I assumed would be fine, but it was causing really confusing behavior with some of the transpiled asynchronous code.
After changing my polyfill to es6-promise things seemed to behave much more normally in IE.


Line wrap [OSF-5875]

Purpose
When a .txt file is uploaded in Safari, the line overflow will wrap around when rendered there, but the same file will have to scroll to the right in Chrome.

Similar problems
Firefox also had this problem [OSF-3532] and it was resolved with a Firefox-specific line in the CSS.
Changes
Added a line to the CSS in mfr/extensions/codepygements/static/css/default.css for the pre element:
 white-space : pre-line;
so it wraps to the next line now.

Removed Firefox-specific code to support Chrome as well.
Side Effects

Safari: Words no longer break to wrap in the middle of the word
Firefox: Words no longer break to wrap in the middle of the word
CSS simplification

Sending back to 'Additional Development', but only minor changes needed.

@felliott Thanks, and this website explains it pretty well

@felliott https://github.com/felliott Thanks, and this website http://www.impressivewebs.com/css-white-space/ explains it pretty well

Thanks for the link!  After reading that, I think we do want pre-wrap instead.  A lot of folks use whitespace for formatting in their .txt files, and we wouldn’t want to throw those off.  An ascii table would look pretty weird if you compressed down the white space.

Okay I will fix this in the next five minutes
On Thu, May 19, 2016 at 9:36 AM, Fitz Elliott<EMAIL_ADDRESS>wrote:

@felliott https://github.com/felliott Thanks, and this website <
http://www.impressivewebs.com/css-white-space/> explains it pretty well

Thanks for the link! After reading that, I think we do want pre-wrap
instead. A lot of folks use whitespace for formatting in their .txt files,
and we wouldn’t want to throw those off. An ascii table would look pretty
weird if you compressed down the white space.
—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
https://github.com/CenterForOpenScience/modular-file-renderer/pull/213#issuecomment-220326140

--
Matthew Keitelman
571-269-4724
<EMAIL_ADDRESS>

LGTM, thanks, @zamattiac!  This will be merged after the next MFR release.

QA had some spare bandwidth, so this has been merged, tested, and will be part of the next MFR release!  Closing.


B-18667

Agility ticket
PR 1
PR 2
Summary
Add Safety Moves privilege

Warnings

:warning:

Files located in legacy directories (src/shared or src/scenes) have
been edited. Are you sure you don’t want to also relocate them to the new file structure?
View the frontend file org ADR for more information

:warning:
This PR does not include changes to unit tests, even though it affects app code.

  Generated by :no_entry_sign: dangerJS against e191b054be18af9dd116cbab5bf49461ff3c6631


custom image

hey bro, pls tell me how to put a Custom image, i have a valid application id...

Duplicate with #1
I don’t have much time for implementing custom ID for now, but you can modify the source code.

ok, how do i change the code? can you pls accept my discord friend request Vinade#0001


create replica for same group in the same node panic

this can reproduce by change
https://github.com/engula/engula/blob/main/src/server/tests/group_test.rs#L104
to
c.create_replica(2, 103, empty_desc).await;

then it should get:
PanicInfo {
    payload: Any { .. },
    message: Some(
        assertion failed: raw_db.cf_handle(&name).is_none(),
    ),
    location: Location {
        file: "src/server/src/node/engine/group.rs",
        line: 140,
        col: 9,
    },
    can_unwind: true,
}

I'm not sure whether should we need support creating the replica of the same group in the same node?(although the allocator should avoid allocating new replicas like this as possible as it can) @w41ter

If there already exists a replica, it should be rejected, otherwise it is allowed.


chore: release 10.5.0

Update to v10.5.0

this one will be a piece of work.

this one will be a piece of work.

Turns out the branch is protected. Let me try with a different branch


Not integradet in tensorflow 2 from IBM WML CE

The LMS can not be used from Tensorfow 2.1 from conda  IBM WML CE
tf.config.experimental.set_lms_enabled(True)
produces:
module 'tensorflow_core._api.v2.config.experimental' has no attribute 'set_lms_enabled'

it was a dependecy issue its solved

Hi, do you know the solution to that issue? I'm still puzzled after reading #27

The large model support source code included in the patches directory of this repository is built into the TensorFlow provided by Watson Machine Learning Community Edition 1.7.0 and later. In order for the tf.config.experimental.set_lms_enabled(True) line to work you either need to install this version of TensorFlow or apply the source code patch file and build TensorFlow from source.
The install instructions are here:
https://github.com/IBM/tensorflow-large-model-support#installing-tensorflow-large-model-support
In the case of this issue the bela127 stated:

it was a dependecy issue its solved

so I suspect there was a dependency issue, conda channel, or other conda environment issue that prevented the correct level of TensorFlow to be installed from the WML CE channel.

so I suspect there was a dependency issue, conda channel, or other conda environment issue that prevented the correct level of TensorFlow to be installed from the WML CE channel.

This is exactly what happened.
By having the wrong python version, and/or not specifically choosing "Watson Machine Learning Community Edition 1.7.0"
A old Tensorflow version got installed.
The solution was to explicitly specify the "Watson Machine Learning Community Edition 1.7.0" before the python Version

Thanks guys for the reply
I installed tensorflow/tensorflow-gpu 2.1.0 from the channel by the command: conda install tensorflow-gpu --channel https://public.dhe.ibm.com/ibmdl/export/pub/software/server/ibm-ai/conda/
And it is installed in a newly created conda py3.7 environment.
Is that correct?

I tried your command in my environment and it was going to try and install TensorFlow 1.15. By changing it to conda install tensorflow-gpu=2.1.0 --channel https://public.dhe.ibm.com/ibmdl/export/pub/software/server/ibm-ai/conda/ it was going to install the right version.
You can check that you have the 2.1.0 tensorflow-gpu version installed from the channel by looking at the output of this command:
conda list | grep tensorflow

File "NGCF.py", line 500, in
tf.config.experimental.set_lms_enabled(True)
AttributeError: module 'tensorflow_core._api.v2.config.experimental' has no attribute 'set_lms_enabled'
(zyjtf2) zhengyujia@omnisky:~/ngcf-wang-v2/NGCF$ conda list | grep tensorflow
tensorflow                2.1.0           gpu_py37_915.g4f6e601    https://public.dhe.ibm.com/ibmdl/export/pub/software/server/ibm-ai/conda
tensorflow-base           2.1.0           gpu_py37h6c5654b_0
tensorflow-estimator      2.1.0              pyhd54b08b_0
tensorflow-gpu            2.1.0              915.g4f6e601    https://public.dhe.ibm.com/ibmdl/export/pub/software/server/ibm-ai/conda
tensorflow-probability    0.9.0                    pypi_0    pypi
That's pretty weird :( I'm using tf 1.x code in tf2.1, so I also tried the instruction in readme (config setting).  And the feedback is:
'Experimental' object has no attribute 'lms_enabled'

Note the version of tensorflow-base: tensorflow-base           2.1.0           gpu_py37h6c5654b_0
The bulk of the TensorFlow function is delivered in the tensorflow-base package. Your tensorflow-base was not installed from the WML CE conda channel.
I would suggest following the instructions for setup and install here, https://www.ibm.com/support/knowledgecenter/SS5SF7_1.7.0/navigation/wmlce_install.html, rather than using the --channel parameter on the conda install. You will likely have better success.
Note, you may also need to set "strict channel priority" which is also covered on that page.

Note the version of tensorflow-base: tensorflow-base 2.1.0 gpu_py37h6c5654b_0
The bulk of the TensorFlow function is delivered in the tensorflow-base package. Your tensorflow-base was not installed from the WML CE conda channel.
I would suggest following the instructions for setup and install here, https://www.ibm.com/support/knowledgecenter/SS5SF7_1.7.0/navigation/wmlce_install.html, rather than using the --channel parameter on the conda install. You will likely have better success.
Note, you may also need to set "strict channel priority" which is also covered on that page.

It works haha, thanks so much!
The reason is that I didn't set "strict channel priority" so that tf-base from the other channel was automatically installed when installing tf-gpu from WML CE channel.
Again, appreaciate for your kindly help!

One more question: Do you have any idea how to install cudatoolkit=10.1 while keeping TFLMS works? The driver of the server doesn't support cuda 10.2, and there are always conflicts between WML CE TF-GPU 2.1, WML CE TF-base 2.1 and cudatoolkit10.1 in conda environment.

It's always good to keep the Nvidia driver up to date. Newer ones will always work with older CUDA releases.
For scenarios where that is not possible, CUDA does offer limited forward compatibility.
In WML CE, the compat libraries are in the cudatoolkit-dev package
So
conda install cudatoolkit-dev
Then you have to set your LD_LIBRARY_PATH to the compat directory so it picks up the compat libcuda instead of the one from the driver package. There is a short cut to that directory using $CONDA_PREFIX/compat
In the next version of WML CE, we're going to offer those compat libs in a separate package to make it easier.
Note that the compat libraries only work back one level, so it likely won't work if you have a driver older than the one matched with CUDA 10.1 (which was the 418 driver)

(tf2) zh@om:~/ngcf-wang-v2/NGCF$ echo $LD_LIBRARY_PATH
/home/zh/anaconda3/envs/tf2/compat

NVIDIA-SMI 418.56       Driver Version: 418.56       CUDA Version: 10.2
cudatoolkit               10.2.89            680.g0f7a43a    https://public.dhe.ibm.com/ibmdl/export/pub/software/server/ibm-ai/conda
cudatoolkit-dev           10.2.89            680.g0f7a43a    https://public.dhe.ibm.com/ibmdl/export/pub/software/server/ibm-ai/conda

And I'm using a new env following the instruction (powerai)
But I still cannot make it works. I'm not sure if I understand the setting correctly or not.
2020-04-11 03:12:18.377123: I tensorflow/stream_executor/platform/default/dso_loader.cc:44] Successfully opened dynamic library libcurand.so.10
2020-04-11 03:12:18.379353: I tensorflow/stream_executor/platform/default/dso_loader.cc:44] Successfully opened dynamic library libcusolver.so.10
2020-04-11 03:12:18.380527: I tensorflow/stream_executor/platform/default/dso_loader.cc:44] Successfully opened dynamic library libcusparse.so.10
2020-04-11 03:12:18.380578: I tensorflow/stream_executor/platform/default/dso_loader.cc:44] Successfully opened dynamic library libcudnn.so.7
2020-04-11 03:12:18.383277: I tensorflow/core/common_runtime/gpu/gpu_device.cc:1700] Adding visible gpu devices: 0
2020-04-11 03:12:18.383320: I tensorflow/stream_executor/platform/default/dso_loader.cc:44] Successfully opened dynamic library libcudart.so.10.2
Traceback (most recent call last):
File "NGCF.py", line 558, in
sess = tf.compat.v1.Session(config=config)
File "/home/zh/anaconda3/envs/zyjtf2/lib/python3.6/site-packages/tensorflow_core/python/client/session.py", line 1587, in init
:


[Feature Request] Add "setSignInUserSession" function

Is your feature request related to a problem? Please describe.
A problem not, but a use case. We have an application that allow users to sign in using the cognito client libraries and through our own server using the cognito admin API. In JS, this could be accomplished easily using the function setSignInUserSession, but here there isn't something like that.
Describe the solution you'd like
Add a setSignInUserSession function just like it is done in amplify-js.
Related to https://github.com/aws-amplify/amplify-flutter/issues/845.
Describe alternatives you've considered
I think the above solution would be the best one, as it matches the API offered by Amplify in other language (JS).
Is the feature request related to any of the existing Amplify categories?
Auth
Additional context
No response

Similar request - https://github.com/aws-amplify/amplify-ios/issues/1543

The same feature is discussed in the amplify-android SDK here.


chore: update docs

Updating README.md

I think it would be nice to add some "obvious" examples, but which may be new for Nix users: i.e., a build command and then explain that this creates the whole OS.
Likewise, it would be nice to mention the scripts and what each does.


Proposal to Extend Priority Range for Mail Queues

The Jakarta Messaging API defines ten levels of priority value, with 0 as the lowest priority and 9 as the highest. Clients should consider priorities 0-4 as gradations of normal priority and priorities 5-9 as gradations of expedited priority. Priority is set to 4 by default.

I guess you raised the topic on the mailing list but this means the JMS implementation will not handle well 19 priority levels.
This PR is IMO great as the JMS constraints was leaking to the SMTP API (thus potentially impacting all other  implementations) yet this still means we need to adapt the JMS implementation in order to handle those lower negative priorities.

https://ci-builds.apache.org/job/james/job/ApacheJames/job/PR-2378/1/
Related test failures :)

Thanks for the nice contribution @Maxxx873 :)


wrap instance dispatchers in useCallback

addresses https://github.com/tannerlinsley/react-table/issues/1808
Several of the instance methods added by plugins wrap their state update
functions in useCallback, the ones that didn't do this can lead to problems
where when they are used in a component, for instance in a hook, their
required presence in the dependency array causes an infinite loop as
executing the function triggers an instance update and a new function
generation.  This PR addresses this.

@ggascoigne Hey, just wanted to mention, you missed the column instance setFilter here:
https://github.com/tannerlinsley/react-table/pull/1874/files#diff-8fcb4d3631040704a13e857438931e27R166
Although, I'm kind of unsure if React.useCallback can be used there, we might need a custom way keep the function identity the same.

@VanTanev If you need the column level setFilter function to be stable, you may need to wrap it in a useRef in the render function where you are using it and just keep it up to date manually until we can figure out a better way. I would love to see how you're using it too.

@tannerlinsley I have a Filter like this, where I manually set the filterValue to undefined. It might not actually be necessary:
function CheckboxListFilter<D extends DataItem>({
    column,
    preFilteredRows,
}: FilterProps<D>): React.ReactElement | null {
    const { filterValue, setFilter } = column
    // TODO instead of clearing the filters when table data changes,
    // we should create an intersection of the new and old values, maybe?
    React.useEffect(() => {
        setFilter(undefined)
        // https://github.com/tannerlinsley/react-table/issues/1808
        // eslint-disable-next-line react-hooks/exhaustive-deps
    }, [preFilteredRows])

    // ...
}

This is a dropdown multi-select filter built from the values in the column. Right now we reset it to empty when the table data changes, but I want to make it keep the intersection of the new table data and the old filter values in the future, for which I would still need the same React.useEffect() that uses setFilter() inside its body.


fix #138

done with "convert a image to pdf"

@Xlgd when you are using any third party external library add requirements.txt file

ok

I've added the  requirements.txt file.


Double VIP creation

Under some scenarios two VIPs are being returned by the internal resolver for a single service name.  This should never be possible.  Hypothesis:  stale DNS caching.
Environment:
Red Hat Enterprise Linux Server release 7.2 (Maipo)
[root@node2 ~]# uname -a
Linux node2 3.10.0-327.22.2.el7.x86_64 #1 SMP Thu Jun 9 10:09:10 EDT 2016 x86_64 x86_64 x86_64 GNU/Linux

@mavenugo

@mgoelzer Is there a way to recreate this issue ?

@huslage Is there a way we can connect @sanimej to the user who was having this problem?  It sounded reproducible in their setup, though I cannot reproduce on my own RHEL 7.2 cluster.

@mgoelzer is this still an issue?

I haven't experienced it recently.  Let's close.


changed webrequest timeout

Description
This changes the DefaultWebRequest Timeout option to 100 seconds, matching that of the Invoke-WebRequest timeout.
Related Issue
Resoves #667 #666 #663
Motivation and Context
Why is this change required? What problem does it solve?
Customers are receiving more and more errors involving timeouts since this was set.
How Has This Been Tested?
Tested within the TM lab
Screenshots (if appropriate):
Types of changes
What types of changes does your code introduce? Put an x in all the boxes that apply:

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:
Go over all the following points, and put an x in all the boxes that apply. If you're unsure about any of these, don't hesitate to ask. We're here to help!

[x] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[x] I have read the CONTRIBUTION document.
[x] I have updated the CHANGELOG file accordingly for the version that this merge modifies.
[ ] I have added tests to cover my changes.
[x] All new and existing tests passed.

@jaapbrasser - I'm not sure if we want to write some more code in this PR to force the local options file to have a timeout of 100.  This will indeed fix it for new imports of the module, but if they have the existing file which sits at 15 seconds, they may still experience errors


Use GoogleTest for RGA tests

There's a failing test in RGA but it's hard to see what the cause is since the error string is not shown in tests. This switches to GoogleTest like db/test/joinstore.cc and makes the error visible (rga.cc:148 BADARGS	not an RGA/CT frame).

Cool!


Add support for batching requests

As an additional (optional) request parameter, it would be nice to be able to batch downloads. Additionally, it would be great to be able to batch all functions that you can perform on an individual request, like deleting, pausing, etc. The batch ID could be a user-supplied string.

@jacobtabak A pull request has been submitted for this feature


Fix broken carton init templates

Resolves #77.
Also updates the Tokamak template to use the App/Scene lifecycle and to depend on the future 0.3 version.
JavaScriptKit version check is also updated.

Hey @carson-katri @RayZhao1998, would you mind having a look at this please? I'm going to be away probably most of next week, but would be amazing if this could be released and announced together with the new release of Tokamak to a wide audience tomorrow before I'm off. The change is relatively small and I don't think too disruptive, so should be an easy review. Thanks!


Lost authenticated session when closing the browser

Everything works just fine but it seems like authenticated session is lost when closing the browser. After I logged in successfully, I closed the browser immediately and re-open it after that, I had to login again. Have anyone faced this issue before ? Thanks.

Could you post a runnable sample project showing the issue?

sry @XaserAcheron for disturbing you too much, but this is an invalid bug, it is because I did not to set the cookieExpirationTime a specific time. It was always null so it got deleted after I closed the browser. My apologies.

No worries! Glad you've got it working!
My apologies for not being too useful in helping solve things. This addon is pretty simple in theory, but it links together quite a few complex parts with a lot of configuration, so it's generally pretty tough to reproduce from here.


Correctly remove closed sockets from oident file, remove unused functions

Checked this, just reporting it doesn't fix a bug with ident being the same. Fixes undefineds in .oidentd.conf though.


Custom node that fail to load can make the whole loading fail

I found this node make the whole load to fail:
IFRNet VFI
It's from ComfyUI-Frame-Interpolation
I added and exception catch to ignore it in nodes.py and the rest of the nodes loaded properly

Edit:
The same thing happens in the nodes.py of the real mode.

Fixed. Use git pull to update.


select input channel

Hi, thanks for a great project. I know you are not maintaining it, but do you have a hint as to how one would select the input channel from a multichannel Soundflower, or even an external soundcard etc. instead of the basic system audio input? Possibly where in the code to do this?

thanks; sorry I don't have an answer for this: it's been too many years, and i can't recall if I ever attempted something like that. i know soundflower was pretty configurable, and I wouldn't be surprised if it is possible, but don't know how or have any way to test it.
i'm going to put the help wanted tag on here, in case anyone else has an answer, and leave this question open.


DRAFT: Split shared/dynamic libraries from static/build artifacts

Checklist

[x] Used a personal fork of the feedstock to propose changes
[x] Bumped the build number (if the version is unchanged)
[ ] Reset the build number to 0 (if the version changed)
[x] Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[ ] Ensured the license file is being packaged.

Closes #42

This PR separates the shared and dynamically loaded libraries in /lib and /plugins into a separate output from qt-main; this new output is called libqt5.
The purpose of creating this new output is to reduce the size of run exports for downstream packages which link to qt.
The size of the new libqt5 package is 31MB/100MB (compressed/uncompressed) which is about half the size of the current qt-main package (61MB/254MB).
As you can see from the diff, the build script is unchanged.
There is one change to the top-level build/host requirements: The libclang version is now manually pinned to 15 via the conda_build_config.yaml. This is because using pin_compatible in the outputs section causes an error in conda-build as noted in https://github.com/conda-forge/qt-main-feedstock/pull/223#issuecomment-1876139556.
A new output section which splits the artifacts and dependencies using glob expressions.
Runtime dependencies on libraries who now have run_exports upstream were removed.
For testing, I have compared the artifacts using git, to identify added/missing files.

[ ] linux64 - No significant difference; some pyc files are not packaged.
[ ] osx64
[ ] win64

https://doc.qt.io/qt-6/deployment-plugins.html

There is some problem with rendering the recipe due to the replacements key in the conda_build_config.yaml
Traceback (most recent call last):
  File "/opt/conda/bin/conda-mambabuild", line 10, in <module>
    sys.exit(main())
  File "/opt/conda/lib/python3.10/site-packages/boa/cli/mambabuild.py", line 256, in main
    call_conda_build(action, config)
  File "/opt/conda/lib/python3.10/site-packages/boa/cli/mambabuild.py", line 228, in call_conda_build
    result = api.build(
  File "/opt/conda/lib/python3.10/site-packages/conda_build/api.py", line 254, in build
    return build_tree(
  File "/opt/conda/lib/python3.10/site-packages/conda_build/build.py", line 3789, in build_tree
    packages_from_this = build(
  File "/opt/conda/lib/python3.10/site-packages/conda_build/build.py", line 2470, in build
    output_metas = expand_outputs([(m, need_source_download, need_reparse_in_env)])
  File "/opt/conda/lib/python3.10/site-packages/conda_build/render.py", line 932, in expand_outputs
    get_all_replacements(m.config)
  File "/opt/conda/lib/python3.10/site-packages/conda_build/build.py", line 1109, in get_all_replacements
    assert isinstance(
AssertionError: Found 'all_replacements[0]' (('tag', 'glob_patterns', 'regex_re', 'replacement_re')), but it is not a dict

Probably rerendering has broken the osx build because the vmImage has been updated.


Update README.md TypeScript section to recommend Ajv JSONSchemaType utility type

By combining express-json-validator-middleware's AllowedSchema with Ajv's recommended typescript approach we can still get type safety within the schema object while satisfying the validate function type safety.

@shane-js This is a great tip. Thank you for this!


tableToSlides autoPaging not working

Issue Category

[ ] Enhancement
[ ] Bug
[x] Question
[ ] Documentation gap/issue

Product Versions

Please specify what version of the library you are using......: [3.11.0]
Please specify what version(s) of PowerPoint you are targeting: [MS PowerPoint 2016]
Please specify what web browser you are using.................: [FireFox 102.5.0esr (64-bit)]

Desired Behavior
Basic test of exporting an existing table with dynamic data to PowerPoint with the tableToSlides function with auto paging to see, if it fits my needs and the table is correctly wrapped in multiple slides
Observed Behavior
The table is not correctly wrapped in multiple slides
Question
I used a minimal example to test this, see screenshots of the code. And I got a presentation where the table is overflowing the slide massively (see also screenshots or attached ppt). Am I doing something wrong or are there some options missing (while from documentation the default should be correct for me)?

test_basic.pptx

Hi, I have the same problem(also with addTable method, if I have big array of rows). Can someone give me a hand please?

As nobody provided help in here, I tried older versions.
In version 3.7.0 auto paging is just working fine on my side


How to change GUI type like crafting table or enchant table?

Good question. I realized that I did not mention about it at wiki. I'll update.
Answer:

Gui.class have a second constructor for it. Your code should be look like:
Gui(player, id, title, InventoryType.ENCHANTMENT_TABLE)


Completely broken on v0.6

Sadly, this package is now completely broken on 0.6 :(
I started patching it but got stuck at
ERROR: LoadError: LoadError: UndefVarError: _IO_FILE not defined
Stacktrace:
 [1] include_from_node1(::String) at ./loading.jl:569
 [2] include(::String) at ./sysimg.jl:14
 [3] include_from_node1(::String) at ./loading.jl:569
 [4] eval(::Module, ::Any) at ./boot.jl:235
 [5] _require(::Symbol) at ./loading.jl:483
 [6] require(::Symbol) at ./loading.jl:398
while loading /Users/adrian/.julia/v0.6/PostgreSQL/src/libpq_interface.jl, in expression starting on line 4
while loading /Users/adrian/.julia/v0.6/PostgreSQL/src/PostgreSQL.jl, in expression starting on line 10

const _IO_FILE = Void
might work, not sure

Where was _IO_FILE defined before?  i.e. how did this code ever work?  Or did you re-run Clang or something?
This is apparently used for C FILE* arguments, which are opaque pointers, so just Void should work.
A more basic issue, however is that libpq_interface.jl (the Clang-generated file) is picking up a whole bunch of C standard-library functions (fscanf, perror, etcetera) that you almost certainly don't need or want.  Probably you just want to include the PQ* functions (PQuser etcetera) and filter out everything else.

Current master works on 0.4.
It looks like libpq-fe.h includes stdio...maybe Clang.jl has an exclude list now. I ran it a very long time ago.

how did this code ever work

ccall used to be oddly permissive of invalid code in parts it didn't use or call

Probably easiest to just manually trim the unnecessary functions from that file for now.  It is not very long, and the API seems small enough to maintain the wrappers manually.


Enhancement: Re-assess if the 'IsAssignableFrom' can be used over the customized 'IsInterfacedTo'.

RepoDb property handlers are generic in which it force us to deliver a customized (almost-like) IsAssignableFrom equivalent method for the System.Type.
But since then, RepoDb has improve a lot when it comes to its abstraction and implementation. This user story will allow us to refactor the unneeded code from the code-line by re-assessing whether the IsAssignableFrom method can now be used as a replacement for the customized IsInterfacedTo method.

Tested today, it seems invalid.
Interface:
public interface IPropertyHandler<TInput, TOutput>
{
    TOutput Get(TInput input);
    TInput Set(TOutput input);
}

Class:
public class AddressHandler : IPropertyHandler<string, object>
{
    public object Get(string input)
    {
        throw new NotImplementedException();
    }

    public string Set(object input)
    {
        throw new NotImplementedException();
    }
}

Main:
class Program
{
    static void Main(string[] args)
    {
        var type = typeof(AddressHandler);
        Console.WriteLine(typeof(IPropertyHandler<,>).IsAssignableFrom(type));
        Console.WriteLine(typeof(IPropertyHandler<string, object>).IsAssignableFrom(type));
        Console.ReadLine();
    }
}

Output:
> False
> True

This has been fixed and is now available at RepoDb v1.12.3. Closing this incident ticket now.


HADOOP-15524 Bounding array size in BytesWritable to Integer.MAX_VALUE - 8

Bounding array size to Integer.MAX_VALUE - 8 to prevent OutOfMemoryError from occurring.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
37
Docker mode activated.

_ Prechecks _

+1
dupname
0
No case conflicting files found.

+1
@author
0
The patch does not contain any @author tags.

-1
test4tests
0
The patch doesn't appear to include any new or modified tests.  Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

+1
mvninstall
1109
trunk passed

+1
compile
1097
trunk passed

+1
checkstyle
45
trunk passed

+1
mvnsite
78
trunk passed

+1
shadedclient
791
branch has no errors when building and testing our client artifacts.

+1
javadoc
62
trunk passed

0
spotbugs
125
Used deprecated FindBugs config; considering switching to SpotBugs.

+1
findbugs
123
trunk passed

_ Patch Compile Tests _

+1
mvninstall
51
the patch passed

+1
compile
1033
the patch passed

+1
javac
1033
the patch passed

+1
checkstyle
37
the patch passed

+1
mvnsite
70
the patch passed

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedclient
613
patch has no errors when building and testing our client artifacts.

+1
javadoc
63
the patch passed

+1
findbugs
119
the patch passed

_ Other Tests _

+1
unit
540
hadoop-common in the patch passed.

+1
asflicense
41
The patch does not generate ASF License warnings.

5956

Subsystem
Report/Notes

Docker
Client=18.09.8 Server=18.09.8 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-393/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/393

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle

uname
Linux 7e20a664e954 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / 7f1b76c

Default Java
1.8.0_212

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-393/1/testReport/

Max. process+thread count
1425 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-393/1/console

versions
git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
100
Docker mode activated.

_ Prechecks _

+1
dupname
0
No case conflicting files found.

+1
@author
0
The patch does not contain any @author tags.

-1
test4tests
0
The patch doesn't appear to include any new or modified tests.  Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

+1
mvninstall
1100
trunk passed

+1
compile
1303
trunk passed

+1
checkstyle
46
trunk passed

+1
mvnsite
80
trunk passed

+1
shadedclient
810
branch has no errors when building and testing our client artifacts.

+1
javadoc
67
trunk passed

0
spotbugs
115
Used deprecated FindBugs config; considering switching to SpotBugs.

+1
findbugs
113
trunk passed

_ Patch Compile Tests _

+1
mvninstall
48
the patch passed

+1
compile
1008
the patch passed

+1
javac
1008
the patch passed

+1
checkstyle
41
the patch passed

+1
mvnsite
74
the patch passed

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedclient
639
patch has no errors when building and testing our client artifacts.

+1
javadoc
73
the patch passed

+1
findbugs
126
the patch passed

_ Other Tests _

+1
unit
511
hadoop-common in the patch passed.

+1
asflicense
42
The patch does not generate ASF License warnings.

6241

Subsystem
Report/Notes

Docker
Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-393/2/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/393

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle

uname
Linux 69410c994949 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / c7c7a88

Default Java
1.8.0_212

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-393/2/testReport/

Max. process+thread count
1390 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-393/2/console

versions
git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
45
Docker mode activated.

_ Prechecks _

+1
dupname
0
No case conflicting files found.

+1
@author
0
The patch does not contain any @author tags.

-1
test4tests
0
The patch doesn't appear to include any new or modified tests.  Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

+1
mvninstall
1109
trunk passed

+1
compile
1022
trunk passed

+1
checkstyle
38
trunk passed

+1
mvnsite
67
trunk passed

+1
shadedclient
756
branch has no errors when building and testing our client artifacts.

+1
javadoc
56
trunk passed

0
spotbugs
119
Used deprecated FindBugs config; considering switching to SpotBugs.

+1
findbugs
117
trunk passed

_ Patch Compile Tests _

+1
mvninstall
47
the patch passed

+1
compile
975
the patch passed

+1
javac
975
the patch passed

+1
checkstyle
38
the patch passed

+1
mvnsite
68
the patch passed

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedclient
619
patch has no errors when building and testing our client artifacts.

+1
javadoc
57
the patch passed

+1
findbugs
123
the patch passed

_ Other Tests _

-1
unit
519
hadoop-common in the patch failed.

+1
asflicense
45
The patch does not generate ASF License warnings.

5764

Reason
Tests

Failed junit tests
hadoop.util.TestDiskCheckerWithDiskIo

hadoop.util.TestReadWriteDiskValidator

hadoop.ipc.TestIPC

hadoop.ha.TestZKFailoverController

Subsystem
Report/Notes

Docker
Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-393/3/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/393

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle

uname
Linux 24f8c6ddb65c 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / e872ceb

Default Java
1.8.0_212

unit
https://builds.apache.org/job/hadoop-multibranch/job/PR-393/3/artifact/out/patch-unit-hadoop-common-project_hadoop-common.txt

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-393/3/testReport/

Max. process+thread count
1346 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-393/3/console

versions
git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
42
Docker mode activated.

_ Prechecks _

+1
dupname
0
No case conflicting files found.

+1
@author
0
The patch does not contain any @author tags.

-1
test4tests
0
The patch doesn't appear to include any new or modified tests.  Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

+1
mvninstall
1057
trunk passed

+1
compile
1062
trunk passed

+1
checkstyle
45
trunk passed

+1
mvnsite
76
trunk passed

+1
shadedclient
792
branch has no errors when building and testing our client artifacts.

+1
javadoc
71
trunk passed

0
spotbugs
123
Used deprecated FindBugs config; considering switching to SpotBugs.

+1
findbugs
121
trunk passed

_ Patch Compile Tests _

+1
mvninstall
43
the patch passed

+1
compile
1020
the patch passed

+1
javac
1020
the patch passed

+1
checkstyle
42
the patch passed

+1
mvnsite
67
the patch passed

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedclient
643
patch has no errors when building and testing our client artifacts.

+1
javadoc
63
the patch passed

+1
findbugs
121
the patch passed

_ Other Tests _

+1
unit
510
hadoop-common in the patch passed.

+1
asflicense
53
The patch does not generate ASF License warnings.

5882

Subsystem
Report/Notes

Docker
Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-393/4/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/393

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle

uname
Linux af190897009b 4.4.0-139-generic #165-Ubuntu SMP Wed Oct 24 10:58:50 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / 00b5a27

Default Java
1.8.0_212

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-393/4/testReport/

Max. process+thread count
1513 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-393/4/console

versions
git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
41
Docker mode activated.

_ Prechecks _

+1
dupname
0
No case conflicting files found.

+1
@author
0
The patch does not contain any @author tags.

-1
test4tests
0
The patch doesn't appear to include any new or modified tests.  Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

+1
mvninstall
1030
trunk passed

+1
compile
1050
trunk passed

+1
checkstyle
39
trunk passed

+1
mvnsite
66
trunk passed

+1
shadedclient
767
branch has no errors when building and testing our client artifacts.

+1
javadoc
55
trunk passed

0
spotbugs
112
Used deprecated FindBugs config; considering switching to SpotBugs.

+1
findbugs
110
trunk passed

_ Patch Compile Tests _

+1
mvninstall
43
the patch passed

+1
compile
994
the patch passed

+1
javac
994
the patch passed

+1
checkstyle
37
the patch passed

+1
mvnsite
66
the patch passed

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedclient
639
patch has no errors when building and testing our client artifacts.

+1
javadoc
55
the patch passed

+1
findbugs
117
the patch passed

_ Other Tests _

+1
unit
513
hadoop-common in the patch passed.

+1
asflicense
44
The patch does not generate ASF License warnings.

5722

Subsystem
Report/Notes

Docker
Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-393/5/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/393

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle

uname
Linux 309622885a59 4.4.0-139-generic #165-Ubuntu SMP Wed Oct 24 10:58:50 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / e356e4f

Default Java
1.8.0_212

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-393/5/testReport/

Max. process+thread count
1405 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-393/5/console

versions
git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
43
Docker mode activated.

_ Prechecks _

+1
dupname
0
No case conflicting files found.

+1
@author
0
The patch does not contain any @author tags.

-1
test4tests
0
The patch doesn't appear to include any new or modified tests.  Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

+1
mvninstall
1132
trunk passed

+1
compile
1138
trunk passed

+1
checkstyle
40
trunk passed

+1
mvnsite
73
trunk passed

+1
shadedclient
779
branch has no errors when building and testing our client artifacts.

+1
javadoc
61
trunk passed

0
spotbugs
127
Used deprecated FindBugs config; considering switching to SpotBugs.

+1
findbugs
125
trunk passed

_ Patch Compile Tests _

+1
mvninstall
49
the patch passed

+1
compile
1100
the patch passed

+1
javac
1100
the patch passed

+1
checkstyle
42
the patch passed

+1
mvnsite
68
the patch passed

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedclient
630
patch has no errors when building and testing our client artifacts.

+1
javadoc
59
the patch passed

+1
findbugs
125
the patch passed

_ Other Tests _

+1
unit
554
hadoop-common in the patch passed.

+1
asflicense
37
The patch does not generate ASF License warnings.

6098

Subsystem
Report/Notes

Docker
Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-393/6/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/393

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle

uname
Linux 388224c2da70 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / 094d736

Default Java
1.8.0_212

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-393/6/testReport/

Max. process+thread count
1362 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-393/6/console

versions
git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
42
Docker mode activated.

_ Prechecks _

+1
dupname
0
No case conflicting files found.

+1
@author
0
The patch does not contain any @author tags.

-1
test4tests
0
The patch doesn't appear to include any new or modified tests.  Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

+1
mvninstall
1071
trunk passed

+1
compile
1037
trunk passed

+1
checkstyle
37
trunk passed

+1
mvnsite
67
trunk passed

+1
shadedclient
739
branch has no errors when building and testing our client artifacts.

+1
javadoc
63
trunk passed

0
spotbugs
116
Used deprecated FindBugs config; considering switching to SpotBugs.

+1
findbugs
113
trunk passed

_ Patch Compile Tests _

+1
mvninstall
46
the patch passed

+1
compile
1007
the patch passed

+1
javac
1007
the patch passed

+1
checkstyle
37
the patch passed

+1
mvnsite
70
the patch passed

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedclient
668
patch has no errors when building and testing our client artifacts.

+1
javadoc
58
the patch passed

+1
findbugs
122
the patch passed

_ Other Tests _

+1
unit
508
hadoop-common in the patch passed.

+1
asflicense
41
The patch does not generate ASF License warnings.

5796

Subsystem
Report/Notes

Docker
Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-393/7/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/393

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle

uname
Linux 7ed2ab588a5a 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / 69ddb36

Default Java
1.8.0_222

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-393/7/testReport/

Max. process+thread count
1379 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-393/7/console

versions
git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
82
Docker mode activated.

_ Prechecks _

+1
dupname
0
No case conflicting files found.

+1
@author
0
The patch does not contain any @author tags.

-1
test4tests
0
The patch doesn't appear to include any new or modified tests.  Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

+1
mvninstall
1229
trunk passed

+1
compile
1166
trunk passed

+1
checkstyle
44
trunk passed

+1
mvnsite
78
trunk passed

+1
shadedclient
887
branch has no errors when building and testing our client artifacts.

+1
javadoc
62
trunk passed

0
spotbugs
131
Used deprecated FindBugs config; considering switching to SpotBugs.

+1
findbugs
128
trunk passed

_ Patch Compile Tests _

+1
mvninstall
53
the patch passed

+1
compile
1086
the patch passed

+1
javac
1086
the patch passed

+1
checkstyle
51
the patch passed

+1
mvnsite
83
the patch passed

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedclient
737
patch has no errors when building and testing our client artifacts.

+1
javadoc
65
the patch passed

+1
findbugs
133
the patch passed

_ Other Tests _

+1
unit
576
hadoop-common in the patch passed.

+1
asflicense
44
The patch does not generate ASF License warnings.

6572

Subsystem
Report/Notes

Docker
Client=19.03.0 Server=19.03.0 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-393/8/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/393

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle

uname
Linux 52bcb1febf81 4.15.0-52-generic #56-Ubuntu SMP Tue Jun 4 22:49:08 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / 3329257

Default Java
1.8.0_212

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-393/8/testReport/

Max. process+thread count
1733 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-393/8/console

versions
git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
84
Docker mode activated.

_ Prechecks _

+1
dupname
0
No case conflicting files found.

+1
@author
0
The patch does not contain any @author tags.

-1
test4tests
0
The patch doesn't appear to include any new or modified tests.  Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

+1
mvninstall
1371
trunk passed

+1
compile
1304
trunk passed

+1
checkstyle
48
trunk passed

+1
mvnsite
92
trunk passed

+1
shadedclient
902
branch has no errors when building and testing our client artifacts.

+1
javadoc
61
trunk passed

0
spotbugs
132
Used deprecated FindBugs config; considering switching to SpotBugs.

+1
findbugs
129
trunk passed

_ Patch Compile Tests _

+1
mvninstall
55
the patch passed

+1
compile
1150
the patch passed

+1
javac
1150
the patch passed

+1
checkstyle
44
the patch passed

+1
mvnsite
83
the patch passed

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedclient
756
patch has no errors when building and testing our client artifacts.

+1
javadoc
66
the patch passed

+1
findbugs
155
the patch passed

_ Other Tests _

+1
unit
618
hadoop-common in the patch passed.

+1
asflicense
43
The patch does not generate ASF License warnings.

7029

Subsystem
Report/Notes

Docker
Client=18.09.7 Server=18.09.7 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-393/9/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/393

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle

uname
Linux 4fbeb43f941a 4.15.0-52-generic #56-Ubuntu SMP Tue Jun 4 22:49:08 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / 915cbc9

Default Java
1.8.0_222

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-393/9/testReport/

Max. process+thread count
1338 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-393/9/console

versions
git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

Retriggered Jenkins
https://builds.apache.org/job/hadoop-multibranch/job/PR-393/10/


Pass call sets and use variant merge strategies.

Previously reviewed as https://github.com/googlegenomics/dataflow-java/pull/194 and https://github.com/googlegenomics/dataflow-java/pull/195

Coverage decreased (-0.9%) to 19.994% when pulling b8153e37b76324aa9dcb4a93a1ee12c169166d14 on passCallSets into a9498bd4daf2f6eef2c80674f103d1a7c644afce on master.


breaks redux-devtools TypeError: Converting circular structure to JSON(…)

When plugging in redux-router into my application i'm getting this error:
TypeError: Converting circular structure to JSON(…)

Figured out the problem. I have tool that serialize the actions for replay and it doesn't like the @@reduxReactRouter/replaceRoutes action when you try to serialize it.


[SPARK-19565] Improve DAGScheduler tests.

What changes were proposed in this pull request?
This is related to #16620.
When fetch failed, stage will be resubmitted. There can be running tasks from both old and new stage attempts. This pr added a test to check the case that success of tasks from old stage attempt should be taken as valid and partitionId should be removed from stage's pendingPartitions accordingly. When pending partitions is empty, downstream stage can be scheduled, even though there's still running tasks in the active(new) stage attempt.

Can one of the admins verify this patch?

@kayousterhout @squito @markhamstra
As mentioned in #16620 , I think it might make sense to make this pr. Please take a look. If you think it is too trivial, I will close.

@kayousterhout
I've refined accordingly.  Please take another look at this : )

@squito
Thanks a lot for your comments. I've refined the comment.

After looking at my other test cleanup PR I realized the "map stage submission with executor failure late map task completions" test already tests this functionality, only for map stages that are submitted in isolation (without a following reduce stage).  @squito do you think we need this one, for the same reason?  If so, do you think it's worth it to do some cleanup to (a) move this test next to that one and (b) make it consistent with that one?

Jenkins this is OK to test

@kayousterhout
I'll close since this functionality is already tested.

sorry responding late to this, but your analysis sounds fine


Add location.hash to local storage state key

Append the current hash to the key of the local storage save state.

Thanks for this PR. However, per the contributing document this is just a legacy build repo. The DataTablesSrc repo is the one to send PRs to.

Ups... Sorry, I'll fork the DataTablesSrc repo.
Thanks!


Library changes behaviour of property decorator

In standard compiler implementation, return value of the property decorator is used for call of Object.defineProperty. See example in on plunker.
If we include reflec-metada library, return value of the property decorator is ingnored. For example, if we include library in previus plunk, it will break.

@PFight Can you npm install reflect-metadata@next to see if this change addresses your issue?

@rbuckton yes, in v0.1.9 it is work good.


Speeding up CellComplex.construct()

The current construct() is slow. Polyhedron.intersection(other) takes most of the time, as profiled with line_profiler:
Timer unit: 1e-06 s

Total time: 27.422 s
File: /Users/zhaiyu/opt/anaconda3/envs/abspy/lib/python3.8/site-packages/abspy/complex.py
Function: construct at line 390

Line #      Hits         Time  Per Hit   % Time  Line Contents
==============================================================
   390                                               @profile
   391                                               def construct(self, exhaustive=False):
   392                                                   """
   393                                                   Construct cell complex.
   394
   395                                                   Two-stage primitive-in-cell predicate.
   396                                                   (1) bounding boxes of primitive and existing cells are evaluated
   397                                                   for possible intersection. (2), a strict intersection test is performed.
   398
   399                                                   Generated cells are stored in self.cells.
   400                                                   * query the bounding box intersection.
   401                                                   * optional: intersection test for polygon and edge in each potential cell.
   402                                                   * partition the potential cell into two. rewind if partition fails.
   403
   404                                                   Parameters
   405                                                   ----------
   406                                                   exhaustive: bool
   407                                                       Do exhaustive partitioning if set True
   408                                                   """
   409         1        266.0    266.0      0.0          logger.info('constructing cell complex')
   410         1          4.0      4.0      0.0          tik = time.time()
   411
   412         1      13862.0  13862.0      0.1          pbar = range(len(self.bounds)) if self.quiet else trange(len(self.bounds))
   413        42      16878.0    401.9      0.1          for i in pbar:  # kinetic for each primitive
   414                                                       # bounding box intersection test
   415                                                       # indices of existing cells with potential intersections
   416        41     292416.0   7132.1      1.1              indices_cells = self._intersect(self.bounds[i], self.planes[i], exhaustive)
   417        41        134.0      3.3      0.0              assert len(indices_cells), 'intersection failed! check the initial bound'
   418
   419                                                       # half-spaces defined by inequalities
   420                                                       # no change_ring() here (instead, QQ() in _inequalities) speeds up 10x
   421                                                       # init before the loop could possibly speed up a bit
   422        82      56790.0    692.6      0.2              hspace_positive, hspace_negative = [Polyhedron(ieqs=[inequality]) for inequality in
   423        41      35014.0    854.0      0.1                                                  self._inequalities(self.planes[i])]
   424
   425                                                       # partition the intersected cells and their bounds while doing mesh slice plane
   426        41        153.0      3.7      0.0              indices_parents = []
   427
   428      1013       3274.0      3.2      0.0              for index_cell in indices_cells:
   429<PHONE_NUMBER>.0   1776.8      6.3                  cell_positive = hspace_positive.intersection(self.cells[index_cell])
   430<PHONE_NUMBER>.0   1745.9      6.2                  cell_negative = hspace_negative.intersection(self.cells[index_cell])
   431
   432       972      53076.0     54.6      0.2                  if cell_positive.dim() != 3 or cell_negative.dim() != 3:
   433                                                               # if cell_positive.is_empty() or cell_negative.is_empty():
   434                                                               """
   435                                                               cannot use is_empty() predicate for degenerate cases:
   436                                                                   sage: Polyhedron(vertices=[[0, 1, 2]])
   437                                                                   A 0-dimensional polyhedron in ZZ^3 defined as the convex hull of 1 vertex
   438                                                                   sage: Polyhedron(vertices=[[0, 1, 2]]).is_empty()
   439                                                                   False
   440                                                               """
   441       105        113.0      1.1      0.0                      continue
   442
   443                                                           # incrementally build the adjacency graph
   444       795       1518.0      1.9      0.0                  if self.graph is not None:
   445                                                               # append the two nodes (UID) being partitioned
   446       795       7322.0      9.2      0.0                      self.graph.add_node(self.index_node + 1)
   447       795       3261.0      4.1      0.0                      self.graph.add_node(self.index_node + 2)
   448
   449                                                               # append the edge in between
   450       795       5137.0      6.5      0.0                      self.graph.add_edge(self.index_node + 1, self.index_node + 2)
   451
   452                                                               # get neighbours of the current cell from the graph
   453       795      30508.0     38.4      0.1                      neighbours = self.graph[list(self.graph.nodes)[index_cell]]  # index in the node list
   454
   455       795       1630.0      2.1      0.0                      if neighbours:
   456                                                                   # get the neighbouring cells to the parent
   457       794     119186.0    150.1      0.4                          cells_neighbours = [self.cells[self._index_node_to_cell(n)] for n in neighbours]
   458
   459                                                                   # adjacency test between both created cells and their neighbours
   460                                                                   # todo:
   461                                                                   #   Avoid 3d-3d intersection if possible. Unsliced neighbours connect with only one child
   462                                                                   #   - reduce computation by half - can be further reduced using vertices/faces instead of
   463                                                                   #   polyhedron intersection. Sliced neighbors connect with both children
   464
   465      8090      13708.0      1.7      0.0                          for n, cell in enumerate(cells_neighbours):
   466
   467      7296   13415562.0   1838.8     48.9                              interface_positive = cell_positive.intersection(cell)
   468
   469      7296     218415.0     29.9      0.8                              if interface_positive.dim() == 2:
   470                                                                           # this neighbour can connect with either or both children
   471      5100      69081.0     13.5      0.3                                  self.graph.add_edge(self.index_node + 1, list(neighbours)[n])
   472      5100    9149388.0   1794.0     33.4                                  interface_negative = cell_negative.intersection(cell)
   473      5100     144452.0     28.3      0.5                                  if interface_negative.dim() == 2:
   474      2894      39336.0     13.6      0.1                                      self.graph.add_edge(self.index_node + 2, list(neighbours)[n])
   475                                                                       else:
   476                                                                           # this neighbour must otherwise connect with the other child
   477      2196      30033.0     13.7      0.1                                  self.graph.add_edge(self.index_node + 2, list(neighbours)[n])
   478
   479                                                               # update cell id
   480       795       1257.0      1.6      0.0                      self.index_node += 2
   481
   482       795       1197.0      1.5      0.0                  self.cells.append(cell_positive)
   483       795        849.0      1.1      0.0                  self.cells.append(cell_negative)
   484
   485                                                           # incrementally cache the bounds for created cells
   486       795     137263.0    172.7      0.5                  self.cells_bounds.append(cell_positive.bounding_box())
   487       795     114524.0    144.1      0.4                  self.cells_bounds.append(cell_negative.bounding_box())
   488
   489       795       1246.0      1.6      0.0                  indices_parents.append(index_cell)
   490
   491                                                       # delete the parent cells and their bounds. this does not affect the appended ones
   492       836       1132.0      1.4      0.0              for index_parent in sorted(indices_parents, reverse=True):
   493       795       1029.0      1.3      0.0                  del self.cells[index_parent]
   494       795        959.0      1.2      0.0                  del self.cells_bounds[index_parent]
   495
   496                                                           # remove the parent node (and subsequently its incident edges) in the graph
   497       795        807.0      1.0      0.0                  if self.graph is not None:
   498       795      16774.0     21.1      0.1                      self.graph.remove_node(list(self.graph.nodes)[index_parent])
   499
   500         1          3.0      3.0      0.0          self.constructed = True
   501         1        305.0    305.0      0.0          logger.info('cell complex constructed: {:.2f} s'.format(time.time() - tik))

One way is to avoid 3D-3D intersections wherever possible. Another is to introduce multi-processing/threading into the workflow.

Attempted to avoid 3D-3D intersection by introducing an unsliced flag for neighboring cell, in which case the neighboring cell can only connect to one child of the partition. This actually made it even slower, possibly due to the overhead of 2D-3D intersection for predicting the flag.

Partly addressed in #20 by introducing OBB to reduce 3D-3D intersections.


XN-1460 add model conversion benchmarks

Adds benchmarks for parsing a vector i32 into a Model, and serialising a Model into a vector i32.
Performance:

test
time

parse model from 4 bytes vector
351.78 ns

parse model (bounded) from 100kB vector
3.4069 ms

parse model from 1MB vector
41.986 ms

serialize 4 bytes model to primitives
829.05 ns

serialize 100kB model into primitives
9.5551 ms

serialize 1MB model to primitives
103.23 ms

I tried with 10MB as well but preparing the 1000 iterations was too painfully slow.
Not sure this is the best way, so please don't hold back on comments.
I also get a weird warning that the make_model_XXX functions in the utils mod are unused, but they clearly are, and they work. SO answer was a bit overwhelming.. any word of advice? Thanks!
EDIT: warning disappeared, so that's good.

This is nice 👍 However the "serialize"/"de-serialize" terminology from the ticket is misleading. Serialization/de-serialization would be converting the model to a byte representation for storing it (which we'll also need benchmarks for). I think we can keep the "to/from primitives" terminology.

ahah are you saying i implemented benchmarks for something else..?
so should the whole terminology be parse model to/from primitives? (in the ticket and in the code?)

the benchmarks look good 👍

This is nice 👍 However the "serialize"/"de-serialize" terminology from the ticket is misleading. Serialization/de-serialization would be converting the model to a byte representation for storing it (which we'll also need benchmarks for). I think we can keep the "to/from primitives" terminology.

ahah are you saying i implemented benchmarks for something else..?
so should the whole terminology be parse model to/from primitives? (in the ticket and in the code?)

i agree that we should use the from/to_primitives terminology here. to give you an idea why, the mental model for the conversions look roughly like the following:
              from/to_primitives
Vec<f32>   <---------------------->   Model
   ^                                    ^
   |                                    |
   | de/serialize                       | de/serialize
   |                                    |
   v                                    v
Vec<u8>                              Vec<u8>

this is because a Model holds a representation of the original primitive values, but as rational numbers of arbitrary precision (which is somewhat required for the masking). converting between a Model and a Vec<f32> is referred to as from/to_primitives. de/serialization on the other hand could be done for both representations to get a bunch of bytes to ship, but we usually only serialize the Model, but not the Vec<f32>. i hope this helps a bit to clear things up.
only partly related to your mr, i would suggest to give the benches a proper structure since it is going to grow further in the future. since this might be asking too much, i created a pr for your pr for a cleaned up directory structure, please have a look and feel free to merge this or make further adjustments: #591 (this also partly addresses some of my review comments)

Thanks a lot for the explanation! Much clearer now, maybe i should have asked for it before venturing into this PR. Agree with the naming, just need to find in the code these actual (de)serialisation ops, so that i can build the benchmarks for them.
There is a bit going on now with the change requests from you and Corentin, as well as your other extremely useful PR though.
With Corentin on a call last week we actually re-structured the crate in a different way than your own restructuring in #591  . so maybe we should coordinate a bit? i haven't committed those changes yet of course.
Shall we maybe pause these benchmarks until the second part of this sprint, and perhaps just briefly discuss a unified project structure and then going ahead with the implementation?
Not sure whether we should then close this PR or not, i'm open to anything, not sure if you peeps are fine with PRs open for a long time and what's the process there.

Shall we maybe pause these benchmarks until the second part of this sprint, and perhaps just briefly discuss a unified project structure and then going ahead with the implementation?
Not sure whether we should then close this PR or not, i'm open to anything, not sure if you peeps are fine with PRs open for a long time and what's the process there.

makes sense to align on a common structure, just leave the pr open no worries.

#566 has to be merged first, then this must be rebased onto master to avoid having code from the other pr.

#566 has to be merged first, then this must be rebased onto master to avoid having code from the other pr.

@janpetschexain Thanks, LGTM, though i hope git doesn't make a mess of the history, with multiple authors and such. it's also fine if you want to close this and cherry-pick the stuff that should be merged on top of #566 in a clean PR authored only by you

multiple authors shouldn't be an issue. regarding the commit history, i prefer to squash merge anyways.

@janpetschexain Thanks, LGTM, though i hope git doesn't make a mess of the history, with multiple authors and such. it's also fine if you want to close this and cherry-pick the stuff that should be merged on top of #566 in a clean PR authored only by you

multiple authors shouldn't be an issue. regarding the commit history, i prefer to squash merge anyways.


no "f88ef0b32d48780d573641400fa5c815" file in the github api cache folder

Thus one cannot simply access there dashboard nor the update checker making the big point of the entire update (from the way your worded your update post) rather fruitless since it revolved around the better update checking, no? also I saw that someone put something like this up an hour or two before, but for whatever reason the OP immediately closed it. So consider this the post that clarify's his post.

Check your permissions

if you getting
500  Cannot put content in file "/usr/share/nginx/html/TechnicSolder/app/storage/github-api-cache/f88ef0b32d48780d573641400fa5c815"

its a permissions problem most likely.

nope like the other guy checked and everything; the file simply doesn't exist anywhere including the source

well do a
chown -R root:www-data (solderinstallation)

Permissions need to be set for the folder since its new. GitHub-api-cache

did so, actively did nothing so I restarted it and still nothing. I'm running an debian os so I did the whole chmod 777 and still got nothing, Since I didn't redo any permissions or anything, the storage folder should of had sufficient read-write as it was but obviously in the case if it didn't it should have already solved it.


fix: Error when quote is used in runtime code

Description
Problem*
Resolves
Summary*
Fixes a few small issues:

Error when quote is used in runtime code

Had to update some stdlib code for this
This could maybe be an issue in the future for something like impl Append for Quoted which relies on this. These impl methods have to be comptime now which we currently allow even though the parent trait says nothing about it. At least with https://github.com/noir-lang/noir/pull/5976 we'd get an error if one of these accidentally sneaks into runtime code.

self.in_comptime_context() wasn't being tracked accurately in the case of attributes and globals where the function context would only be of length 2 due to there being no outer function. I changed the check to make it more direct instead of relying on indirect changes.
Comptime globals weren't evaluated in their own function context before so we waited to resolve traits until the end of the program. This could lead to trait errors when interpreting them.

Additional Context
Documentation*
Check one:

[x] No documentation needed.
[ ] Documentation included in this PR.
[ ] [For Experimental Features] Documentation to be submitted in a separate PR.

PR Checklist*

[ ] I have tested the changes locally.
[ ] I have formatted the changes with Prettier and/or cargo fmt on default settings.

One thought about this: should functions with comptime-types not marked as comptime produce an error? For example this:
// Error: fn must be comptime because FunctionDefinition is comptime
fn foo(x: FunctionDefinition) {}

One thought about this: should functions with comptime-types not marked as comptime produce an error? For example this:

Yep! That's the issue I plan on working on next


[WIP] Support Dynamic Client Registration

Adds support for Dynamic Client Registration (see
https://openid.net/specs/openid-connect-registration-1_0.html).
Dynamic Client Registration is initiated when no identifier was supplied among
the client_options.
Also, this includes changes for the better handling of "http" schema (useful in testing).
fixes #46
TODO:

[ ] Add some tests

Coverage decreased (-2.4%) to 96.931% when pulling 86ccda6c51af826aec96af7feb5deff4013b55d6 on cmrd-senya:rfc7591 into 849b181551a61f732f9990dd7ad58c258b970019 on jjbohn:master.

Coverage decreased (-1.9%) to 97.436% when pulling 5e8103b9bc6706fa92f27882ccbaf5fa8c9e1344 on cmrd-senya:rfc7591 into 849b181551a61f732f9990dd7ad58c258b970019 on jjbohn:master.


[Sema] In simplifyType, if substitution fails retry with IUOs stripped.

We can end up with IUOs bound as a result of overload resolution. When
this happens and the resulting type is used as a generic, we can end up
with dependent member types that fail to simplify properly as a result
of failing to substitute due to the IUO getting in the way. In these
cases it should be completely safe to strip the IUO off and retry
substitution with the base type.
This isn't really an ideal fix by any means, and we need to revisit how
we handle bindings to make it more uniform, but for now I think this is
a reasonable path to move forward.
Fixes a source compatibility regression.
rdar://problem/29960575
(cherry picked from ecedb337e7136d0c816b0e714f1b997ce804182d with edits
to handle conflicts between branches)

@swift-ci Please smoke test

@swift-ci Please smoke test

@swift-ci Please test


update-netCDF4tools resolves #Issue 695

Add skip_dim_check to "check each dimension has a coordinate dimension"

@gisi90 can you please send this to stable.

@ReimarBauer By making a new pull request and closing this one?

sent to stable


INT-2216 - For Payload Enricher - add: 'request-timeout' and 'reply-timeout' attributes

For reference see: https://jira.springsource.org/browse/INT-2216

LGTM. Merging now.


Release Pipeline fails to install BcContainerHelper

Release Pipeline fails to install BcContainerHelper. I ran the following script on my local PC to install BcContainerHelper amd that failed. Below is that script and output.
Full output of scripts
  [System.Net.ServicePointManager]::SecurityProtocol = [System.Net.ServicePointManager]::SecurityProtocol -bor [System.Net.SecurityProtocolType]::Tls12
  install-module BcContainerHelper -verbose -force
  Get-InstalledModule BcContainerHelper -AllVersions | where Version -ne (Get-InstalledModule BcContainerHelper).Version | % {
        Write-Host "Removing old version from $($_.installedlocation)"
        remove-item $_.installedlocation -Recurse -Force}
  Import-Module bccontainerhelper

VERBOSE: Acquiring providers for assembly: C:\Users\JónFjölnirAlbertsson\Documents\WindowsPowerShell\Modules\PackageManagement\1.4.7\fullclr\Microsoft.PackageManagement.CoreProviders.dll
VERBOSE: Acquiring providers for assembly: C:\Users\JónFjölnirAlbertsson\Documents\WindowsPowerShell\Modules\PackageManagement\1.4.7\fullclr\Microsoft.PackageManagement.MsuProvider.dll
VERBOSE: Acquiring providers for assembly: C:\Users\JónFjölnirAlbertsson\Documents\WindowsPowerShell\Modules\PackageManagement\1.4.7\fullclr\Microsoft.PackageManagement.MetaProvider.PowerShell.dll
VERBOSE: Acquiring providers for assembly: C:\Users\JónFjölnirAlbertsson\Documents\WindowsPowerShell\Modules\PackageManagement\1.4.7\fullclr\Microsoft.PackageManagement.NuGetProvider.dll
VERBOSE: Acquiring providers for assembly: C:\Users\JónFjölnirAlbertsson\Documents\WindowsPowerShell\Modules\PackageManagement\1.4.7\fullclr\Microsoft.PackageManagement.ArchiverProviders.dll
VERBOSE: Acquiring providers for assembly: C:\Users\JónFjölnirAlbertsson\Documents\WindowsPowerShell\Modules\PackageManagement\1.4.7\fullclr\Microsoft.PackageManagement.MsiProvider.dll
VERBOSE: Using the provider 'PowerShellGet' for searching packages.
VERBOSE: The -Repository parameter was not specified.  PowerShellGet will use all of the registered repositories.
VERBOSE: Getting the provider object for the PackageManagement Provider 'NuGet'.
VERBOSE: The specified Location is 'https://www.powershellgallery.com/api/v2/' and PackageManagementProvider is 'NuGet'.
VERBOSE: En oppgave ble avbrutt.
VERBOSE: Retry downloading 'https://www.powershellgallery.com/api/v2/' for '2' more times
VERBOSE: En oppgave ble avbrutt.
VERBOSE: Retry downloading 'https://www.powershellgallery.com/api/v2/' for '1' more times
VERBOSE: Det oppstod en feil under sending av forespørselen.
VERBOSE: Retry downloading 'https://www.powershellgallery.com/api/v2/' for '0' more times
WARNING: Unable to resolve package source 'https://www.powershellgallery.com/api/v2/'.
VERBOSE: Total package yield:'0' for the specified package 'BcContainerHelper'.
PackageManagement\Install-Package : No match was found for the specified search criteria and module name 'BcContainerHelper'. Try Get-PSRepository to see all available registered module repositories
.
At C:\Program Files\WindowsPowerShell\Modules\PowerShellGet\<IP_ADDRESS>\PSModule.psm1:9709 char:34
+ ... talledPackages = PackageManagement\Install-Package @PSBoundParameters
+                      ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    + CategoryInfo          : ObjectNotFound: (Microsoft.Power....InstallPackage:InstallPackage) [Install-Package], Exception
    + FullyQualifiedErrorId : NoMatchFoundForCriteria,Microsoft.PowerShell.PackageManagement.Cmdlets.InstallPackage

BcContainerHelper version 2.0.15
WARNING: The names of some imported commands from the module 'bccontainerhelper' include unapproved verbs that might make them less discoverable. To find the commands with unapproved verbs, run the I
mport-Module command again with the Verbose parameter. For a list of approved verbs, type Get-Verb.
...

Screenshots

It looks like the https://www.powershellgallery.com/ site is down?

Yeah, not much I can do about that.
My later install-bccontainerhelper scripts actually supports to download the containerhelper from a storage account (done last time the gallery was down).
https://github.com/BusinessCentralApps/HelloWorld/blob/master/scripts/Install-BcContainerHelper.ps1

Gallery is back up


Overline during Import

Report ID:
W94VSSEY-euc
Exporter used:
BetterBibTeX
Summary of behavior:

(000\=1) is correctly imported as (0001̄)
(000\overline{1}), however is imported as (000̅1), so the line is placed over the number before
(000{$\bar{1}$}), is imported as (000̄1), so the same error

Can you get me a full sample bib file that includes these?

Here is a bib file with several examples for each of the three cases (just renamed the ending so that it would upload):
bar-import.txt

:robot: this is your friendly neighborhood build bot announcing test build <IP_ADDRESS>19 ("fixes #1467")
Install in Zotero by downloading test build <IP_ADDRESS>19, opening the Zotero "Tools" menu, selecting "Add-ons", open the gear menu in the top right, and select "Install Add-on From File...".

The import looks good! Works fine now.
You closed the export issue #1465, but that still puts the \overline and \= in the wrong place.


[FR] Opening the expanded view during grid selection

Per user feedback, it would be useful if one could still open the expanded sample view even during grid selection. Ctrl + click could be used to override the default click selection when in selection mode in  the grid.

A corollary to this is that we'll want/need to expose the ability to select samples from the expanded modal (currently only labels can be selected) and persist information about currently selected samples so that multi-sample-tagging workflows can be continued and/or completed with the expanded sample modal open.


Shrunken Cards and Banner icons

Description
Fixes #554

Adjusted the sizing of cards and banner icons and removed extra spaces
File changed: index.html

Video
https://github.com/mdazfar2/HelpOps-Hub/assets/115717746/fa7888ff-c06b-4ceb-aad2-b5ba828cf032

@mdazfar2 Please review and merge this PR