Maintain assembly instructions using PartCAD

Not all blueprints are added yet.
A few problems were identified in the published models and previous instructions.

PartCAD does not yet generate bill of materials, assembly instructions (in PDF) and URDF.
But once it does, it will maintain consistency between all those.
For now, use VS Code to browse models that are created using published files, to make sure that the published files are correct and up to date with the assembly instructions.
If you can't make the rendered 3D models look like the real thing, then something is wrong with the published models.
Which is currently a case (see the Arm).


config.hidden_act is ignored, you should use config.hidden_activation instead.

Gemma attention mode: flash_attention_2
config.hidden_act is ignored, you should use config.hidden_activation instead.
Gemma's activation function will be set to gelu_pytorch_tanh. Please, use
config.hidden_activation if you want to override this behaviour.
See https://github.com/huggingface/transformers/pull/29402 for more details.

have the same problem

this is a hugging face issue.


A11y: Step-by-step mode pagination

The last config page in step-by-step mode is displayed as “X/X”. However there is always one more page and that is displayed as “X+1/X” which looks  a little funny.

The pagination should account  for that page and always end at “X/X”.
The pagination should be labelled as such. It currently seems to have no screen-readable label at all.

!image-20241014-132511.png|width=1465,height=908,alt="image-20241014-132511.png"!

[public] Shopware automated response: This issue is linked to the internal issue: CUS-750
[created from CUS-750, comment 503265]


[Bug]: The tooltip for the orange deviation dot in property pane is moving out of the screen

Is there an existing issue for this?

[X] I have searched the existing issues

Description
If the property name is a little long and the user has selected a value that is different from the theme, the deviated form theme orange dot appears. When hovering over it, the tooltip overflows from the screen.

Steps To Reproduce

Open release.app.appsmith.com / create a fresh FE build from release.
DnD a text widget.
Change the text of the text widget to something lengthy like -

Lorem ipsum, in graphical and textual context, refers to filler text that is placed in a document or visual presentation. Lorem ipsum is derived from the Latin "dolorem ipsum" roughly translated as "pain itself".

Select Overflow Text in the property pane to Truncate text
Go to the style property pane and select any color in the "Truncate button color".
Hover over the orange dot and observe the tooltip overflowing.

https://user-images.githubusercontent.com/22471214/196107193-0fab95c9-9349-4d15-a131-0d44426adca4.mp4
Public Sample App
No response
Version
Appsmith Release - Appsmith v1.8.5-SNAPSHOT

Is this issue still need to be resolved? Please let me know.

@dhruvikn @Nikhil-Nandagopal Please assign me.

@dhruvikn here is the PR https://github.com/appsmithorg/appsmith/pull/21992

@dhruvikn Please also check this another PR https://github.com/appsmithorg/appsmith/pull/21989 for issue https://github.com/appsmithorg/appsmith/issues/21368


Enhancement Proposals for AIGC Direction Focusing on Strengthening Single Agent Capabilities

Description:
Our current AIGC workflow, particularly with the story_maker, has ventured into the realm of multi-agent collaboration to tackle intricate problems. However, from the vantage point of delivering genuine end-user value, I firmly believe we should pivot the core direction of AIGC towards amplifying the capabilities of a single Agent.
Here are the key areas and associated tasks that I recommend we focus on:

Image Generation:

Integrate with DALL·E3 by adding a simple text_to_image node.
Enhance the single agent that uses SD, essentially replacing a less intuitive WebUI with an LLM-based agent for better SD utilization.

Assist users in clarifying their requirements before initiating the drawing process, possibly through interactive keyword prompts.
Use image analysis to determine effective construction methods.
Guide users towards popular effects, automating processes such as model downloads. This could be our breakthrough.
Steer users towards building and using their own Personal LoRA.

Image Editing:

There are two approaches to this:

Agent-based linguistic control: This approach not only aims at fulfilling traditional image editing needs but also includes advanced features like:

Beauty enhancement (Skin retouching, etc.)
Automatic exposure adjustments.
Even automatic composition.

Conventional image editing via WebUI.

The newly released GPT-V does not have an API available for use yet, but I think it can be of great help in solving the problems mentioned above.

Voice Generation and Editing:

Based on a given text and scenario, produce voice outputs in a specific voice imprint.

Train to derive one's own voice imprint, or "lora".

Given a voice input (or video), extract its content. An example use-case would be transcribing meeting records and identifying speakers.
Real-time translation: Accept voice input and provide translated output. For instance, translating a Chinese speech into English while retaining the original voice imprint.

Sound Editing:

Remove background noises.
Isolate a particular voice or extract background music (Karaoke mode).

By concentrating our efforts on enhancing a single Agent's capabilities, I believe we can create a more streamlined, user-centric experience. Feedback and additional suggestions are most welcome.

Stable Diffusion hava a extension plugin to help users train personal lora.
It may requires 5~10 personal photos from different angles.
I would try to call this function through LLM and api, and integrate it into the AIOS.   🤔


Added basic functionality to show HTTP request info, should close #70

Now we can keep and inspect HTTP requests.
No bells and whistles, but should get the job done.
Feel free to comment, reason, argue and object :)

Hi @chorry !
Looks impressive! Could you try to write some instruction in readme?

@chorry could you write me a message in telegram? @butschster


Add cache reservation logic

Description

This PR focuses on adding a reservation logic for the cache introduced as a part of searchable snapshots
The design was defined as a part of #4964 where a user can define the cache size using node.search.cache.size configuration for the node
This value is persisted as a part of the NodePath for the first data path configured on the node, and defaults to 100 MB otherwise.

Issues Resolved

Resolves #5508

Check List

[x] New functionality includes testing.

[x] All tests pass

[x] New functionality has been documented.

[x] New functionality has javadoc added

[x] Commits are signed per the DCO using --signoff
[x] Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

SegmentReplicationStatsIT.testSegmentReplicationStatsResponse

Gradle Check (Jenkins) Run Completed with:

RESULT: UNSTABLE ❕
TEST FAILURES:

      1 org.opensearch.indices.replication.SegmentReplicationStatsIT.testSegmentReplicationStatsResponse

URL: https://build.ci.opensearch.org/job/gradle-check/11323/
CommitID: 6bcf001
Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

Assertion failure on Segment replication stage. The test is reproducbile locally. Will mute or fix flakyness for this test.
REPRODUCE WITH: ./gradlew ':server:internalClusterTest' --tests "org.opensearch.indices.replication.SegmentReplicationStatsIT.testSegmentReplicationStatsResponse" -Dtests.seed=C1BE59295A814240 -Dtests.security.manager=true -Dtests.jvm.argline="-XX:TieredStopAtLevel=1 -XX:ReservedCodeCacheSize=64m" -Dtests.locale=sr-CS -Dtests.timezone=Europe/Volgograd -Druntime.java=19

org.opensearch.indices.replication.SegmentReplicationStatsIT > testSegmentReplicationStatsResponse FAILED
    java.lang.AssertionError:
    Expected: <DONE>
         but: was <FINALIZE_REPLICATION>
        at __randomizedtesting.SeedInfo.seed([C1BE59295A814240:8877D71BDE820586]:0)
        at org.hamcrest.MatcherAssert.assertThat(MatcherAssert.java:18)
        at org.junit.Assert.assertThat(Assert.java:964)
        at org.junit.Assert.assertThat(Assert.java:930)
        at org.opensearch.indices.replication.SegmentReplicationStatsIT.testSegmentReplicationStatsResponse(SegmentReplicationStatsIT.java:50)

https://build.ci.opensearch.org/job/gradle-check/11323/

Resolved in https://github.com/opensearch-project/OpenSearch/pull/6370

Looking at test failures.

Execution failed for task ':distribution:bwc:minor:buildBwcLinuxTar'.
> Building 2.6.0 didn't generate expected file /var/jenkins/workspace/gradle-check/search/distribution/bwc/minor/build/bwc/checkout-2.x/distribution/archives/linux-tar/build/distributions/opensearch-min-2.6.0-SNAPSHOT-linux-x64.tar

Waiting for version PR merges.

Codecov Report

Merging #6350 (b409918) into main (261f22c) will decrease coverage by 0.04%.
The diff coverage is 63.33%.

:exclamation: Current head b409918 differs from pull request most recent head 60eb37f. Consider uploading reports for the commit 60eb37f to get more accurate results

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
@@             Coverage Diff              @@
##               main    #6350      +/-   ##
============================================
- Coverage     70.76%   70.73%   -0.04%
+ Complexity    59065    59062       -3
============================================
  Files          4801     4801
  Lines        282816   282901      +85
  Branches      40773    40787      +14
============================================
- Hits         200134   200100      -34
- Misses        66273    66372      +99
- Partials      16409    16429      +20

Impacted Files
Coverage Δ

...in/java/org/opensearch/indices/IndicesService.java
62.99% <ø> (+0.25%)
:arrow_up:

.../java/org/opensearch/test/InternalTestCluster.java
58.41% <12.50%> (+0.76%)
:arrow_up:

...rc/main/java/org/opensearch/monitor/fs/FsInfo.java
72.13% <31.25%> (-2.87%)
:arrow_down:

...org/opensearch/common/settings/SettingsModule.java
83.55% <40.00%> (-0.91%)
:arrow_down:

...src/main/java/org/opensearch/node/NodeService.java
70.31% <50.00%> (+0.47%)
:arrow_up:

...c/main/java/org/opensearch/index/IndexService.java
73.64% <62.50%> (-0.90%)
:arrow_down:

.../main/java/org/opensearch/env/NodeEnvironment.java
75.21% <68.85%> (-0.96%)
:arrow_down:

server/src/main/java/org/opensearch/node/Node.java
83.57% <75.00%> (-0.08%)
:arrow_down:

...c/main/java/org/opensearch/monitor/fs/FsProbe.java
84.37% <90.00%> (+1.61%)
:arrow_up:

...ava/org/opensearch/cluster/node/DiscoveryNode.java
91.80% <100.00%> (+0.59%)
:arrow_up:

... and 488 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Backport: #6485


Filter Release Date Tied To Specific Type of Release

Description
Within the Filter section, there is a Release Date range in order to filter Movies that have been released within a certain date range. It would be nice to further specify whether this release date should apply to theatrical release or digital release.
Desired Behavior

Select Movies
Select Filters
Select Date Range
Select some type of checkbox implying this range is for a digital release
Filter movies that have had a digital release within the supplied date range

Additional Context
No response
Code of Conduct

[X] I agree to follow Jellyseerr's Code of Conduct

First of all, thanks for this amazing tool !
To add on what @halexh said :
This would be great to help people find movies that are available straight away. Some of my users are confused as for the availability of the movies they ask for.
A great first step would be to add the filter mentioned. I think also adding a category for "New Releases (At Home)" (and maybe "New Releases (Theaters)") in the "Discover" section would be a great UX improvement, to quickly find something to watch.
Furthermore, adding the different release dates (theatrical, premiere, physical, digital...) on a movie's page would be fantastic. These data are available on TMDB (even though, I have to admit, it's not the most regularly updated field).
There currently is a "status" field in jellyseerr's movies, maybe it would be possible to specify "released (Theaters)" or "released (at Home)" with subcategories as per TMDB's fields :

In my view, it would be the most useful update, with the OIDC one, but probably a bit simpler to make 😄
Thanks for reading.

Love @PierrePetit recommendation. I'd add that it would be great to have this be configurable as server default similar to region and language.

I just saw that some movies had a digital release date in jellyseerr (ex: the three musketeers : D'Artagnan (2023)). The digital release date is an information available on rotten tomatoes. Maybe, adding TMDB's data on top of rottentomatoe's ones could be better ? Rottentomatoes really rarely has this information.

For your information, we don't use rotten tomatoes to get the release dates. Rotten tomatoes are only used to get the ratings. And that's it.
Everything else is tmdb. Including the digital release date of your mentioned movie which also comes from tmdb.


You can not select installation sources when creating a VM

Steps:

Go to VM
Click to Create button
Click to "Select" button in "Installation source" area

Actual result: Window for selecting installation source opens with console error (screenshot), a selection is not possible.
Expected result: Window opens without errors, a selection is possible.

@HeyRoach  Probably changes #893 caused this problem

Test:
vm_creation_installsource
vm_creation_installsource_filter

Tested on 1240


[FEATURE] Transform custom dataset to deeplake dataset/database/vectorstore conveniently using DDP

Description
Here is my use case:
I have 4 gpu nodes for training (including compute tensors) on aws.
I want to save pre-computed tensors to deeplake (Dataset/database/vectorstore), aiming to save a lot of time for next training.
I use accelerate as my distributed parallel framework.
So my framework works like this:
deeplake_path = 'dataset_{}'.format(current_process_index)
ds = deeplake.dataset(deeplake_path, overwrite=False)
for index, data_dict in enumerate(my_pytorch_dataloader):
  with torch.no_grad():
    a = net_a_frozen(data_dict['a'])
    b = net_b_frozen(data_dict['b'])
  # loss = net_c_training(a, b)
  # the loss is only used in training.
  save_dict = {'data_dict': data_dict, 'a': a.detach().cpu().numpy(), 'b': b.detach().cpu().numpy()}
  append_to_deeplake(deeplake_path, save_dict)
  if index % 100 == 0:
    commit_to_deeplake(deeplake_path)

Note that I can use deeplake instead of computing the tensors i need again in the next training after the deeplake dataset construction.
The problem includes:

I have to assign different deeplake dataset to different processes but i need to merge them into a dataset after this.
I need to design a proper for-loop/parallel workflow for deeplake dataset construction.
The frequent append and commit function takes me a lot of time.
detach() and to_cpu() function takes me a lot of time.

So Is there any feature to transform custom dataset to deeplake dataset?
If we have a function which works like this:
ds.distributed_append_gpu_tensor_and_auto_commit(data_tensor)
ds.auto_transorm_pytorch_dataset(my_pytorch_dataloader)

or could you give me a standard workflow to solve this?
I don't know which is the best method for this scenario.
The document did not cover this problem. #2596 also indicates this problem.
Use Cases
Distributed parallel computing and saving to deeplake.

@davidbuniat Thanks. It's really urgent for me.

Hey @ChawDoe! Thanks for opening the issue. Let us look into whether any of our current workflows will satisfy your use case and we'll get back to you in a few days.

Hey @ChawDoe! Thanks for opening the issue. Let us look into whether any of our current workflows will satisfy your use case and we'll get back to you in a few days.

Thanks! I hope that I have explained my use case clearly.
Maybe I need function likes this:
ds = deeplake.distributed_dataset('xxx')
ds.distributed_append(xxx)
ds.distributed_commit(xxx)
ds.distributed_append_auto_commit(xxx)

where auto commit will find the best memory-time trade-off in a for loop.

@FayazRahman Hi, do you have any updates on this?

Sorry @ChawDoe, I haven't been able to work on this yet, I will update here as soon as I make any headway regarding this.


Update dependency

Resolves #58
Bump up

containerd/containerd from 1.2.1 to 1.2.6.
docker/distribution from ^2.7.1 to v2.7.1

/test


Unable to build ios - Error Domain=NSCocoaErrorDomain Code=3840

Hi there, mates... I am having this issue suddenly by the face... I was working fine this morning, but when i got back from lunch, I am finding this funny error message when building for ios ... Can't even open module with the command 'Open iOS module in Xcode' which normally fixed many of my problems... :(
Flutter crash report; please file at https://github.com/flutter/flutter/issues.
command
flutter --no-color build ios --simulator
exception
ProcessException: ProcessException: Process "/usr/bin/xcodebuild" exited abnormally:
2019-10-04 18:15:08.021 xcodebuild[2016:19630] Error Domain=NSCocoaErrorDomain Code=3840 "No value." UserInfo={NSDebugDescription=No value.}
xcodebuild: error: Unable to read project 'Runner.xcodeproj'.
Reason: The project ‘Runner’ is damaged and cannot be opened due to a parse error. Examine the project file for invalid edits or unresolved source control conflicts.
Path: /Users/xxx/IdeaProjects/master_gest/ios/Runner.xcodeproj
Command: /usr/bin/xcodebuild -list
#0      runCheckedAsync (package:flutter_tools/src/base/process.dart:259:7)
<asynchronous suspension>
#1      XcodeProjectInterpreter.getInfo (package:flutter_tools/src/ios/xcodeproj.dart:270:36)
<asynchronous suspension>
#2      buildXcodeProject (package:flutter_tools/src/ios/mac.dart:279:70)
<asynchronous suspension>
#3      BuildIOSCommand.runCommand (package:flutter_tools/src/commands/build_ios.dart:84:43)
<asynchronous suspension>
#4      FlutterCommand.verifyThenRunCommand (package:flutter_tools/src/runner/flutter_command.dart:490:18)
#5      _asyncThenWrapperHelper.<anonymous closure> (dart:async-patch/async_patch.dart:71:64)
#6      _rootRunUnary (dart:async/zone.dart:1132:38)
#7      _CustomZone.runUnary (dart:async/zone.dart:1029:19)
#8      _FutureListener.handleValue (dart:async/future_impl.dart:137:18)
#9      Future._propagateToListeners.handleValueCallback (dart:async/future_impl.dart:678:45)
#10     Future._propagateToListeners (dart:async/future_impl.dart:707:32)
#11     Future._completeWithValue (dart:async/future_impl.dart:522:5)
#12     Future._asyncComplete.<anonymous closure> (dart:async/future_impl.dart:552:7)
#13     _rootRun (dart:async/zone.dart:1124:13)
#14     _CustomZone.run (dart:async/zone.dart:1021:19)
#15     _CustomZone.runGuarded (dart:async/zone.dart:923:7)
#16     _CustomZone.bindCallbackGuarded.<anonymous closure> (dart:async/zone.dart:963:23)
#17     _microtaskLoop (dart:async/schedule_microtask.dart:41:21)
#18     _startMicrotaskLoop (dart:async/schedule_microtask.dart:50:5)
#19     _runPendingImmediateCallback (dart:isolate-patch/isolate_patch.dart:116:13)
#20     _RawReceivePortImpl._handleMessage (dart:isolate-patch/isolate_patch.dart:173:5)

flutter doctor
[✓] Flutter (Channel stable, v1.9.1+hotfix.4, on Mac OS X 10.14.6 18G95, locale es-ES)
    • Flutter version 1.9.1+hotfix.4 at /Users/xxx/develop/flutter
    • Framework revision cc949a8e8b (7 days ago), 2019-09-27 15:04:59 -0700
    • Engine revision b863200c37
    • Dart version 2.5.0

[✓] Android toolchain - develop for Android devices (Android SDK version 28.0.3)
    • Android SDK at /Users/xxx/Library/Android/sdk
    • Android NDK location not configured (optional; useful for native profiling support)
    • Platform android-28, build-tools 28.0.3
    • Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 1.8.0_152-release-1343-b01)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 11.0)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 11.0, Build version 11A420a
    • CocoaPods version 1.7.4

[✓] Android Studio (version 3.4)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin version 36.0.1
    • Dart plugin version 183.6270
    • Java version OpenJDK Runtime Environment (build 1.8.0_152-release-1343-b01)

[✓] IntelliJ IDEA Ultimate Edition (version 2018.3.1)
    • IntelliJ at /Applications/IntelliJ IDEA.app
    • Flutter plugin version 32.0.2
    • Dart plugin version 183.4588.61

[✓] Connected device (2 available)
    • SM G920F          • 0715f799560b3e36                     • android-arm64 • Android 7.0 (API 24)
    • iPhone 11 Pro Max • C3508206-9750-45CA-9142-ECBDB2F6D924 • ios           • com.apple.CoreSimulator.SimRuntime.iOS-13-0 (simulator)

• No issues found!

Can it be opened in Xcode?  If so, does Xcode change any files to repair it?  Can you share that diff with us if there is a change?

Hi jmagman... No ... It can't be opened with open in Xcode comand...
Same error occurs

Can you attach the /Users/xxx/IdeaProjects/master_gest/ios/Runner.xcodeproj bundle or put it on GitHub so I can look?

Sure .. is it fine if i zip the Runner folder inside ios folder? ... or is it just the Runner.xcoderproj file??

Runner.xcworkspace.zip
I think this is it ... let me know if you need something else...

It's complaining about the xcodeproj.  Can we get that instead?

Runner.xcodeproj.zip
ooppsss... sorry about that

The project.pbxproj (the guts of the Xcode project logic) is completely empty.

Did running some flutter command did this?  I've never seen a similar report.
Could something else on your system have deleted the contents of that file?
Can you restore it from source control?

I did a flutter upgrade this morning. But it was working fine after that ...
I have no idea how could that happened ...
Ok... i just copied that file from another project (similar but not the same one!) and its seems working again ...
Let me work with it this weekend and see if everything is ok now ....
Thanks very much!! Best wishes, Miguel ... Great Job!!  <3 flutter

I'm going to close since it doesn't seem like a flutter command caused this.  Please file a new issue and reference this one if you see it happen again.

right Click on Runner.xcodeproj and select "Show Package content". Open project.pbxproj and see if there any merge conflicts(search for >>>>/<<<<). Stange how conflict is not being caught by flutter.

@HarshaiOS1 Flutter doesn't instantiate any source control in your project.  That's up to you as a developer.  In any case, this issue was tracking an empty project file, not one with merge conflicts.


Add StableRNGs as dependency?

Hi David, would you mind adding the StableRNGs package as a dependency? I think you dropped it at some point. I have recently switched to using StableRNGs in fwildclusterboot to control seeding in Julia, and now a range of tests fail on github actions as StableRNGs is not installed / imported with WildBootTests.jl. If you have good reasons against having it as a dependency, I can also be explicit in fwildclusterboot's description file and add it as a dependency there, but this will (slightly) increase the amount of work potential users have to go through before running WildBootTests.jl through fwildclusterboot.

Posting now as version 0.7.13.

Thanks!


expose scala binary jars in build even protocol

@johnynek apparently we only expose the wrapper script for scala binary targets.
Added tests for scala_binary/scala_test/scala_junit_test
There is some redundancy between the three but they felt important enough to protect if we re-implement them without a shared method

I wonder if build event protocol has enough info to remove the statsfile instrumentation we added.

@andyscott can you take a look to see if anything is currently missing from build event protocol for timing?


Stacked bar chart is not showing all  series

Version
4.5.0
Steps to reproduce
Go to  https://echarts.apache.org/examples/en/editor.html and use this options:
option = {
    "legend": {
        "data": ["Geschlossen","Neu","Zugewiesen"]

    },
    "xAxis": {
        "type":"value"

    },
    "yAxis": {
        "type": "category"

    },
    "series": [
        {
            "name": "Geschlossen",
            "stack": "stack",
            "type": "bar",
            "data": [4]
        },
        {
            "name": "Neu",
            "stack": "stack",
            "type": "bar",
            "data": [2]
        },
        {
            "name": "Zugewiesen",
            "stack": "stack",
            "type":"bar",
            "data":[4]
        }
    ]
};

What is expected?
There should be a stacked bar that shows the 3 series with the values 4 - 2 - 4
What is actually happening?
There is only one stacked bar with the value 4

It seems that you need to set yAxis data value, and it's length cannot be 0.
data: ['']
I'm not sure that data of yAixs is necessary for stack. Let me check.
For the time being, you can use this workaround to solve this problem.

It's not very clear what you expected！May you can add yAxis.data: ["Geschlossen","Neu","Zugewiesen"] and hope this example helps you!

@yufeng04 The example Kaljak provides was clearly wrong. Does yAixs.data is needed for stacked charts?

@susiwen8 Because the type of yAxis is category, the yAixs.data is needed.

@yufeng04 Thanks.

Thank you very much


Fix None check in variant caster

This PR fixes the missing None check in the std::variant caster.
The following code produces SIGABRT at runtime since the change in<PHONE_NUMBER>ce2d0c96a525f3c27b88e824b997ce;
m.def("variant_copyable_none", [](std::variant<int, Copyable, std::monostate> &) {}, nb::arg("x").none());

t.variant_copyable_none(None)

This PR include

Improve test coverage
Revert the None check
Refactoring of redundant code

Thank you!

This was kind of a serious issue that also needed to be fixed elsewhere. See commit 5f25ae0.


Multi-line comment breaks sourcemaps(?) (chrome debugging)

Describe the bug
BROKEN:
<script>
    /**
     * Start page for the app
     */
    console.log('Hiiiii');

OK:
<script>
    console.log('Hiiiii');
    /**
     * Start page for the app
     */

OK:
<script>
    // Start page for the app
    console.log('Hiiiii');

If your file starts with a multiline comment these are symptoms:

that file appears as empty file in chrome devTools
console logs still indicate the correct file line though
Another file (duplicate?) has an error message:

Could not load content for http://localhost:8000/Index.svelte (HTTP error: status code 404, net::ERR_HTTP_RESPONSE_CODE_FAILURE)

(Not sure how to properly describe this issue)
OK

BROKEN

Reproduction URL
https://github.com/
Reproduction
If someone tries putting a multi-line comment at the top of one of their svelte files and it works fine, I'll chalk it up to my setup and I'll close this issue asap!!
(Only reporting because it took me way too long to figure out it was the comment causing issues. -.-;;)
Logs
No response
System Info
Windows, but running everything in a linux container (docker)

package.json

    "dependencies": {
<EMAIL_ADDRESS>"^3.4.5",
        "@sveltejs/vite-plugin-svelte": "^2.0.3",
        "@unseenco/taxi": "^1.2.2",
        "mapbox-gl": "^2.14.1",
        "svelte": "^3.57.0",
        "vite": "^4.3.2"
    },

please provide a link to a minimal repository and instructions how exactly to reproduce this, using the latest version of svelte (svelte4) and vite-plugin-svelte.

unable to reproduce, report is missing required information.


Time of last change for each line/char on terminal

Contour is really interesting -- and is super fast! I want to use it more. Thank you all for this tool.
Abstract
Terminal users often run long processes. Compile something big, train neural network, scan disk drive or ports.
And, it is often good to know, when something happened.
Let say, you run something long in Friday evening. You came back at Monday morning, and see an output:
Stage 1/5 is completed...
Stage 2/5 is completed...

So, what happened -- stage 1 and 2 was completed in first 15 minutes, and after that, my process hangs? So, it is better to stop it now? Or, each stage take 1 day each, so now it is better to wait 3 more days? Nobody knows.
Probably, everyone who uses console often, sometimes face this situation.
Motivation
I propose to add mode to view time of change of each line (or char) on screen.
Let say, variant # 1

I press Alt+Shift+T
near each line i see time of change of this line (for example, to the right of the line)
If I drag my mouse to the time, I see date of this change (it can be important for Friday-->Monday situation)
On next press of Alt+Shift+T, this time suffix disappear.

variant # 2

I press Alt+Shift+T. Start of special "time mode" signaled somewhere in UI (for example, in window caption)
I can move my mouse to any char, and see the time of it change in a tooltip
On next press of Alt+Shift+T, this mode stops.

(as for me, I prefer 1st option, but 2nd one is also OK and can be useful sometimes)
ps Sorry if this was already discussed

Thank you for 'logstamped' script. I'll save it, it may help in some situations.
But, in my opinion, it's good to know when something went wrong -- especially if you don't expect that something may go wrong. So, I think it better to be part of terminal emulator, in my humble opinion.

It's not TE's task.

TE's task is to allow power user to work with console software in most productive way, isn't it?
Productivity of group of users who work with long processes will increase from this feature, isn't it?
(I will answer myself -- yes, it is. Less problems with logging, especially logging on other's tools,etc).
So, this is TE's task.

power user to work with console software in most productive way, isn't it?

A power user can develop/find suitable tool. It's very likely that such TUI/GUI tool already exists.
TE should not be like Nero Burning ROM.

It's not TE's task.

TE's task is to allow power user to work with console software in most productive way, isn't it? Productivity of group of users who work with long processes will increase from this feature, isn't it? (I will answer myself -- yes, it is. Less problems with logging, especially logging on 3rd party tools,etc). So, this is TE's task.

i'm all in for empowering the users. sometimes it's a core TE feature to be implemented (vi-like input modes for example), and sometimes some tool in between (e.g. a terminal screen recorder can be tooled as man-in-the-middle software).
For your idea, i'm not against, I lag some imagination in visualization, but I'd like to keep this ticket open specifically as motivation for scripting API requirements. I can't promise you anything soon, as other points are currently more pressing (stability, performance (finish open topics), Good Image Protocol, double-width/height text, tabs).


CI tool integration

Includes:

Travis CI integration (.travis.yaml)
Codacy Integration
Coveralls.io integration (without a badge)

@DanVev ,
It doesn't work. I will add WIP to title. Could youp please notify me when all problems are resolved?


FR: Close and Allocate in one transaction

Problem statement
Currently, 2 x eth transactions required to “renew” existing allocation.
Indexer has to close existing allocation and open new allocation (potentially with new parameters, e.g. allocationAmount) then. Having high gas cost, such 2 x operations could financialy impact indexer.
Proposed solution
Consider to update Indexer-Agent with new operation closeAndAllocate(), wich would allow to close and open allocation in one transaction, which could potentially reduce Indexer’s operational costs.
Operation closeAndAllocate() would intake optional argument:

newAllocationAmount
Use:
graph indexer rules set "deployment" newAllocationAmount 1000
It would close existing allocation and reopen with new amount 1000

Discussion on forum.

Being worked on in #258


Add in call backs for drag/resize calls

Thoughts on adding callbacks for this stuff?
I just basically passed through most information since I wasn't sure exactly what people were going to want to utilize.

Rebased, added onResizeStart, add README documentation.
Only thing this will depend on is react-draggable and react-resizable stopping drag/resize when preventDefault gets called.

Hey just curious if you had an idea of when these could get merged?

Hey Jason - sorry, chasing down a lot of things on a lot of projects
right now. Should be merged soon, in the meantime I would recommend
keeping this rebased on master and using a github url in your project
until I can finish reviewing.
On 1/14/15 5:36 PM, Jason Brown wrote:

Hey just curious if you had an idea of when these could get merged?

Reply to this email directly or view it on GitHub:
https://github.com/STRML/react-grid-layout/pull/12#issuecomment-69945453

@STRML no problem, thanks

@STRML hey I just decided to remove the assignment stuff for now, so I've rebased and squashed, fixed the documentation text. I think it should be good to go.

Perfect. This is simple, we can worry about the assignment stuff later on.

0.7.1


Add alt text to header image

The header image needs alt text. Guidelines for adding alt text for various image types can be found here:
http://webaim.org/techniques/alttext/

Fixed!


[Bug]: Incorrect font color for titles in T&C page

Is there an existing issue for this?

[X] I have searched the existing issues

Description
The font color for titles in the T&C page is not consistent with the rest of the platform. It is #4C5665, instead it should be #202939.

Steps To Reproduce

Go to the login page and click on the T&C link.

Public Sample App
No response
Environment
Production
Severity
Low (Inconsistent UI/UX)
Issue video log
No response
Version
Cloud

Hi @shadabbuchh @albinAppsmith @Nikhil-Nandagopal i am picking up this issue
Approach:
appsmith_business/app/client/public/terms-and-conditions.html
Select the css style class of all heading tags and add a color=#202939.

bug created on Jira-https://zemoso.atlassian.net/browse/TNOSB-388


Team Name and vpc name are hardcoded in composition

What happened?
Latest updates are now hardcoding some tags in the composition which might not align with consumer needs:
https://github.com/upbound/platform-ref-aws/blob/bdd3aabdf80a8f395e8d1132571d2dc7cf943f93/network/composition.yaml#L29
How can we reproduce it?
This was discovered while running kuttl tests from https://github.com/AaronME/ATourOfCrossplane/tree/main/crossplane-package-testing-with-kuttl
What environment did it happen in?
Local testing

Thank you for bringing it up @AaronME . It was added to show that some tags can always be added from within the composition rather than claim. Those tags cannot be overridden on purpose. Do you think this should be removed?

we removed the hardcoded tags via https://github.com/upbound/platform-ref-aws/pull/116 - will open a follow up for function labels and tags ;)


Fix the problem that transitive been reported as missing

PR Checklist

[x] A description of the changes is added to the description of this PR.
[x] If there is a related issue, make sure it is linked to this PR.
[x] If you've fixed a bug or added code that should be tested, add tests!
[ ] If you've added or modified a feature, documentation in docs is updated

Hello, I made a small change to fix the issue where some packages might not have the same name when import, which caused them to be incorrectly reported as missing instead of transitive, as described in  in #827.
To ensure the correct package name is retrieved in module.py, I added an additional approach to check if the package is in the development environment:
`
def _get_package_name_from_metadata(self) -> str | None:
    """
    Most packages simply have a field called "Name" in their metadata. This method extracts that field.
    """
    try:
        name: str = metadata(self.name)["Name"]
    except PackageNotFoundError:
        name = self.is_package_installed(self.name)
        if name:
            return name
        return None
    else:
        return name

def is_package_installed(self, package_name: str):
    if importlib.util.find_spec(package_name):
        return package_name
    return None

`
This ensures that the package name can always be retrieved if it is in the environment, regardless of whether the package name and import name match. I also updated the test in test_module so that the package name for bs4 can now be detected.
I'm not sure if this adheres to your program framework or design logic, but I hope it helps. Thanks!
Description of changes

I added the test dependency on the wrong place, I'll remake a pull request. Thank you!


Document library versioning

For newcomers would be nice to have some guide about the differences between the versions of this library. If they are related to their redis version counterpart or the features each version has than the previous one had not, if it follows semVer, etc.

It tries to follow the semver - it is not hard since there is no much activity. There is also https://github.com/go-redis/redis/blob/master/CHANGELOG.md


Update examples for v2

v1 examples converted to v2 API.

According to f95fb6004066ad26c25143b52cd50c6ab164cb9a, you moved it to a branch. Which branch is it?

Just a local branch, it's all the v1 examples, so they're all broken anyway. We'll probably just remake them for v2.

may i suggest having some of those examples in jsfiddle or plnkr.co instead? that way they'd be interactive and people can play with them.
like this: https://jsfiddle.net/q7hsuqmp/1/

Example of HMR discussed in #342.


SIOD ERROR: could not open file hindi_phones.scm

I keep getting that error when I use hindi tts. It would be nice if you include festival-hi* packages in the container.
Thanks for the image!

Thanks for the suggestion. I've done this locally, and I end up getting this error regardless of the input:
INFO:opentts:Synthesizing with festival:hindi_NSK_diphone (12 char(s))...
-=-=-=-=-=- EST Error -=-=-=-=-=-
{FND} Feature Int_Method not defined

Google has been no help so far. Do you have any ideas?


Fix doc link in readme

Fixes #83

Makes the link at least point somewhere that exists but there is no extra information on that page. Seems the root cause is in the docs build failing:
https://docs.rs/crate/rustbox/0.11.0/builds/102651


Fix sparse multiply

Reference issue

Closes gh-19599.

Thanks for the PR and especially for adding a unit test. I've triggered the CI now.

The CI failure is unrelated, so I'll merge this now. Thanks for the PR, @emilfrost !


An example of moving required styling to classes so can be controlled with css

No docs update, just want to show the code changes for the jsfiddle I listed in #275

I'd definitely like to see some way to allow library users to style this kind of stuff through CSS. I know this is just an example so maybe you've considered this, but I think there should still be some default styling. This PR would force every user of this library to add some CSS to get any kind of required/optional styling. Also, should there also be a class like control-label-optional so you can target those elements? Otherwise, it seems like you'd have to use some kind of negative selector if you wanted to just denote the optional elements.

100% agree

Accessibility considerations apart (which are probably a concern here though), we'll eventually move towards a field template system like suggested in https://github.com/mozilla-services/react-jsonschema-form/issues/275#issuecomment-231948348; that way people will have a way to provide their very own semantics (like what this patch suggests), while we provide accessible defaults.

Seems reasonable though I'd argue some more detailed classing and hinting as above are far more accessible than * at the end of the label so I'd still encourage for something more like that as the default. Happy to address @mplis-jetsetter's concerns if you'd like.

Templates have landed in #304 and are the recommended way to alter the HTML field semantics.


Flee command

During command, if I type flee I'd expect to be able to (have a chance to) leave combat the next round and head to an adjacent room. Instead, every battle is a fight to the death and cowardice is not allowed.
How brutal.

yep, good idea, could be implemented along with a wimpy config which is a pretty common diku style thing


"Latest Users" info shows 1970/01/01 01:00:00 for every user

We are using JATOS 3.6.1 on Ubuntu 18.04.5 LTS. At the "Home"/"Administration" overview (/jatos/admin) the "Latest Users" info box is show, but the time for all users is displayed as 1970/01/01 01:00:00.
When having a look at the tables User the users' order seems unrelated to their position in the User table.
SELECT username,name,lastLogin,active FROM User;
The order is also different from what you get using the query
SELECT username,name,lastLogin,active FROM User ORDER BY lastLogin DESC;
Some users in the table have an actual datetime value in field lastLogins for others it is NULL.

Actually in the Administration page, the Latest Users info box doesn't use the lastLogin field from the database but the lastSeen field from the user session cache. The difference between them is that lastLogin only stores the time of the last login while lastSeen stores the time of the user's last action (action here means a call to one of JATOS endpoints by this user). Since a user can stay logged in for quite some time without a refresh of the login, the lastSeen field is more precise if you want to see who is currently using your JATOS. The downside is that the cache is in-memory only and erased with each restart of JATOS. And if JATOS does not have a lastSeen value for a user it just returns the Unix epoch time, which is 1970/01/01 01:00:00. Then as soon as this user logs in and does something in JATOS the time will change to something more meaningful.
Now that I'm thinking about it, the Unix epoch time might be confusing as a default value. I could change this to never. Or even better not display them in the Latest Users at all since they do not add any information. Would you prefer that?
Then about the lastLogin field sometimes being NULL in the User table. That's correct. This field was also added in version 3.6.1 and if this user never logged in after the update to the new version it just has the default value NULL. Over time when the users log in this will change. On the other side if you have a newly installed JATOS server and 3.6.1 is the first version (no update) then this is might be a bug. Did you update your JATOS?

Ok, that explains why the getLatestUsers source did not look like SQL at all ;-) Unfortunately I had rebooted the server just that morning due to Ubuntu's frequent kernel changes (maybe someone is trying to make Livepatch more attractive, really looking forward to good old Debian after the migration) so there where only epoch 0 values in contrast to said SQL table.
It might be good to translate 1970/01/01 01:00:00 to "never" but than again it would confuse people who do not know that these values are non-persistent and depend on the JATOS service runtime. If the JATOS service has its starting time handy "never since " would be good or to make these values persistent. For me both "Latest Users" as well as "Latest Study Runs" are really helpful for administration to determine reboots etc. Also a "Studies in progress" with the time of their latest results would be very helpful to determine, if a quick reboot or service restart will loose participants or not.

I decided to exclude users that never logged in since the last reboot of JATOS from the "Latest Users" table. The table is limited to 10 rows. If there are more then 10 users in JATOS which one should be shown? And it wouldn't add much information. But I (hopefully) improved the tooltip:

The 10 latest users and the last time they were active (except the logged-in user). The times are reset with every restart of JATOS. If a user does not appear in the table they probably never logged in after the last restart.

And about a "Studies in progress": The "Latest Study Runs" table shows the lastSeen field which is probably better than the time of their latest results. The lastSeen field is regularly updated from the first moment until the end of a study run. With each study run a background worker is started in the participant's browser that regularly sends 'ping' back to the JATOS server. By default the ping's frequency is 2 min. On the other side the result data are often sent only once, in the end of a study run. If the study takes a long time it wouldn't even appear in the table. Or do you have something different in mind and I misunderstood you?
And if you updated your JATOS ... everything is fine and there is no bug :)


Add events page

Describe your changes
Create a landing page for the competitions
Issue ticket number and link
Closes #225
Checklist before requesting a review

[x] I have performed a self-review of my code

Check the correct box. Does this PR contain:

[ ] Breaking changes
[x] New functionality
[x] Major changes
[ ] Minor changes
[ ] Bug fixes

[x] Proposed changes are described in the CHANGELOG.md

[x] CI Preview succeeds and looks good!

the neurips 2021 header has some issues


Divider line for search is white, make it Light Grey

Will also be an issue on Android, please assign to me once complete.

Let's not worry about this on Android for now


Out of Memory when I recognize many images

face_recognition version: 1.1.0 Latest
Python version: 3.5
Operating System: Ubuntu 16.04

Description
I'm doing a web service based on django, which recognizes the face. I compress the photo and recognize the face using cnn. Everything works fine. But when I send several hundred files for processing one by one, such an error periodically appears
`Error while calling cudaMalloc(&data, n) in file /home/facer/dlib/dlib/dnn/cuda_data_ptr.cpp:28. code: 2, reason: out of memory`

In what there can be a reason and how it to correct?

I also encountered the same problem. How did you solve that? @kambeerhunter

@zhiyue @X-YI
Hi.
I changed the image resizing and began to send to the recognition of a photo with a width of no more than 800 pixels. I tested it on a server with a videocard of 8GB - there it worked.
That is, you can either reduce the size of the photo (the optimal size is selected manually) or add video memory, I did not find other solutions

The image I used is 640*480 and have 1060Ti with about 1.5G VRam available and also face the same problem. Will the VRAM stop decreasing if I have more VRAM available? That sounds weird

To process a large number of images, with a maximum width of 1024 pixels, it took me 8GB VRAM


Implement the visitor pattern

Hey @ammar, thanks for the great gem! This PR is an attempt to implement the visitor pattern in regexp_parser such that clients can create their own visitors capable of walking the parse tree. It's a fairly common pattern that I've found useful when working with various parser tools.
I think the functionality should be opt-in, so there are two classes: Visitor is the base visitor class that clients would inherit from to implement their own visitors. The visitor_nodes.rb file contains extensions that add the accept method to all the various parser nodes. By requireing regexp_parser/visitor you also require regexp_parser/visitor_nodes. To opt out, simply don't require the visitor.
There's also a new rake task that can generate the visitor and node extensions programmatically, since doing so by hand can be pretty tedious.
Let me know if this is something you'd be interested in merging :)

Hi @camertron. Sorry for the late response, and thanks for the PR. It is very interesting.
I understand the pattern in general, but I'm curious if there was a specific use case that prompted this.
Despite the quite impressive use of reflection and ERB (:heart:), I wonder, and please excuse any ignorance on my part here, if the following visitor would be equivalent.
# lib/regexp_parser/visitor.rb
require_relative 'visitor/node'

class Regexp::Visitor
  def visit(node)
    node.accept(self)
  end

  def method_missing(m, *args, &block)
    node = args.first

    if node.respond_to?(:expressions)
      node.expressions.each do |exp|
        exp.accept(self)
      end
    end
  end
end

And similarly for nodes, using your method from the generator, would the following satisfy the pattern?
# lib/regexp_parser/visitor/node.rb
module Regexp::Expression
  class Base
    def accept(visitor)
      visitor_method = self.class.name.split('::')[2..-1]
        .join('_')
        .gsub(/([a-z])([A-Z])/) { "#{$1}_#{$2}" }
        .downcase

      visitor.send(:"visit_#{visitor_method}", self)
    end
  end
end

I don't like generating the visitor method name on every call. I think that can be memoized, if I'm not missing something obvious and what I coded even works, that is.
Making the functionality opt-in is a good idea.

Hi!
I like that the VisitorGenerator gives you a file that lets you know what you need to handle.
On the other hand, I'm also wondering what the use case is, and in which way the visitor pattern helps it?
In my purely personal opinion, the visitor pattern mostly adds unnecessary overhead in a language like Ruby.
To me, code like the following seems to achieve the same in a much more straightforward way:
class MyExpProcessor
  def process_literal_literal(exp)
    # do something
  end

  def process_group_capture(exp)
    # do something
  end

  # ...
end

root = Regexp::Parser.parse(/foo(bar)/)
processor = MyExpProcessor.new

root.each_expression do |exp|
  processor.send("process_#{exp.type}_#{exp.token}", exp)
end

I've used type and token here, but of course,the same could be done with expression classes. type and token offer a bit more fine-grained differentiation than the classes, which might or might not be desired.
A generator for such processors (or whatever you'd want to call it) could look somewhat like this (not tested):
class Regexp::ProcessorGenerator
  def self.call
    Regexp::Syntax::Token::Map.flat_map do |type, tokens|
      tokens.map { |token| "def #{type}_#{token}(exp); end" }
    end.join("\n\n")
  end
end

The downside with this generator (like the one in the PR), is that it won't help you find "new" missing things that get added to Ruby's regular expression engine in the future, or changes to regexp_parsers API, unless you use the generator to build a parent class and then validate your child classes with something like sorbet.
So perhaps the most helpful thing would be an easy way to iterate over all expression classes, or all type-token combinations, to validate code dealing with the parser's output.

Hey @ammar,

I understand the pattern in general, but I'm curious if there was a specific use case that prompted this.

It's funny, I had a use-case (Unicode regexes as defined by UTS #18) but decided to go in a different direction for the project. I had already written the generator and produced the visitor files, so I thought I'd contribute them back instead of just throwing them away. Correspondingly, I wouldn't be offended at all if you chose to not merge 😉

I wonder, and please excuse any ignorance on my part here, if the following visitor would be equivalent.

Yes, using method_missing is an entirely reasonable approach. I thought of using it myself, but it suffers from a number of drawbacks. First of all, method_missing will always be slower than good 'ol method dispatch. Second of all - and this is the more important reason in my opinion - defining all the methods explicitly leads to much better discoverability. You don't have to understand the internals of regexp_parser, you just have to look at the methods inside the visitor class to be able to start using it.

And similarly for nodes, using your method from the generator, would the following satisfy the pattern?

Hey, that looks great 😄  I don't think there's much of performance hit with send, if any? Might be worth some research, but my hunch is it should be fine.
Hey @jaynetics,

In my purely personal opinion, the visitor pattern mostly adds unnecessary overhead in a language like Ruby.

You're right in thinking that the visitor pattern isn't strictly necessary in a language like Ruby. It's a lot more necessary in languages like Go and Java, which need the accept + visit combo. They call it "double dispatch."
That said, anyone who works with parser technologies (yacc, bison, antlr, etc) will be intimately familiar with the visitor pattern, so I thought it might make regexp_parser a little more approachable from the outside to have an implementation of its own. It doesn't hurt at all that Visitor is also one of the Gang of Four patterns, which further increases its notoriety.

To me, code like the following seems to achieve the same in a much more straightforward way.

Right, your example looks really similar to Nokogiri's SAX listener where the library calls methods on some delegate you pass into it. The biggest downside of that approach in my opinion is that individual process_ methods don't get to decide whether the parser should also iterate over their children. Furthermore, the return values of the process_ methods are ignored, meaning any transformations you'd like to produce along the way have to be stored somewhere (maybe in instance variables?) The visitor pattern by comparison lets each visit_ method decide if/when to visit children and if the return value should be used for intermediate results. For example, here's the difference between the listener and visitor approaches for an imaginary equation solver:
class Listener < BaseListener
  def initialize
    @stack = []
  end

  def process_literal(node)
    @stack << node.value
  end

  def process_addition(node)
    second, first = @stack.pop(2)
    @stack << first + second
  end

  def result
    @stack.first
  end
end

listener = Listener.new
# or maybe this is done during parsing?
parse_tree.traverse(listener)
puts listener.result

# and for comparison, the visitor equivalent

class Visitor < BaseVisitor
  def visit_addition(node)
    visit(node.left) + visit(node.right)
  end
end

visitor = Visitor.new
puts visitor.visit(parse_tree)


Add ability to create sockets early

As per the LEP: https://github.com/libuv/leps/pull/5
This is still WIP, I's just like a bit of early feedback.
ToDo:

[x] Discuss / bikeshed on the naming
[x] Windows
[x] UDP
[x] More tests
[x] Add "versionadded" to the docs

R=@bnoordhuis

I'd probably make the domain argument to uv_tcp_init_ex() a general purpose flags argument with the domain in the low bits.
There are only about 40-something address families and every platform I know of numbers them incrementally starting from zero, so you'd only need 6 bits to cover them all.  Make it 8 or 10 bits to play it safe.
(Although that's wasting a lot of bits... AF_UNSPEC is always zero and AF_INET and AF_INET6 always < 32, AFAIK.  But that aside.)

Can you elaborate a bit on why? Extensibility? FWIW, this is the first time that we modify some uv_*_init in years (if memory serves right), since they tend to basically do nothing, so I'm not really concerned about that.

Extensibility, yes.  Always leave an escape hatch if at all possible.

Let's assume there is some UV_NO_CLOEXEC flag which prevents the sockets from being created with O_CLOEXEC set. This API would then be used as follows:
uv_tcp_init_ex(loop, handle, AF_INET|UV_NO_CLOEXEC);

Is that right? Looks a bit weird to me :-S I can add a dummy flags thing if you really feel strong about it:
int uv_tcp_init_ex(uv_loop_t*, uv_tcp_t* handle, int domain, int flags);
uv_tcp_init_ex(loop, handle, AF_INET, UV_NO_CLOEXEC|UV_DO_AWESOME_STUFF);

WDYT?

The three arg version looks alright to me an is a bit easier to remember; you can't accidentally swap the domain and the flags arguments.  You can alias AF_INET as UV_AF_INET if using plain AF_INET bothers you.

@bnoordhuis is https://github.com/saghul/libuv/commit/9e02f498c7c4620b2eeb1f1567ccf9c5d9c09bc9 what you were suggesting?

@bnoordhuis I'm chasing some failures on Windows, but can you PTAL the unix side?

UNIX side LGTM minus some nits.  Windows side looks okay to me too.

@bnoordhuis Thanks for the review! CI run here: https://jenkins-iojs.nodesource.com/view/libuv/job/libuv+any-pr+multi/109/

Ok, addressed everything and the build is "green" (surprisingly we've been keeping it that way on Windows for a while \o/).
If nobody has any further comments I'll land this and the LEP later tonight.
Thanks again for the review Ben!

Landed!

Just a followup, can you do an API bump in the master/v1.x so I can #ifdef for the new version?

@vavrusa we bump the version when making a release (the tool does it), so you'll have to wait until we make a 1.7.0 release, sorry.

Okay, a small request then - could you make a macro in uv-version.h (basically UV_VERSION from version.c) so I could check for version instead of MAJOR > 1 || MAJOR == 1 && (MINOR > 6 && ... in preprocessor? I like both decimal 171 or hex 0x00010700 ways.
Example:
#if UV_VERSION >= 0x00107000
#define ENABLE_REUSEPORT
#endif

Decimal is neater, but it requires you must use 1 digit per minor release at most.

@vavrusa sounds ok to me, here is a PR: https://github.com/libuv/libuv/pull/412

@vavrusa you can now use UV_VERSION_HEX.

BTW, the change to src/win/pipe.c in this change:
https://github.com/libuv/libuv/commit/fb5df542ace7d6735a9e8e09d7d8bb6b8abdc459
Is causing this problem:
https://github.com/luvit/luv/issues/177
Removing this code from src/win/pipe.c:uv_set_pipe_handle() fixes the problem:
if (handle->handle != INVALID_HANDLE_VALUE)
return UV_EBUSY;

This error is triggered in this code path:
int uv_pipe_accept(uv_pipe_t* server, uv_stream_t* client) {
    ...
    if (server->ipc) {
        ...
    } else {
        ...
        if (!(server->flags & UV__HANDLE_CLOSING)) {
            uv_pipe_queue_accept(loop, server, req, FALSE);
        }
    }
}

static void uv_pipe_queue_accept(uv_loop_t* loop, uv_pipe_t* handle,
    uv_pipe_accept_t* req, BOOL firstInstance) {
    ...
    if (!firstInstance) {
        ...
        if (uv_set_pipe_handle(loop, handle, req->pipeHandle, -1, 0)) {
            ...
        }
    }
}

I could set server->handle = INVALID_HANDLE_VALUE; before uv_pipe_queue_accept() is called and fix this, but I don't know if that is the right thing to do.

I just had a nice chat with @saghul about this which probably triggered a lot of memories for him :-)
Here is what I ended up with, might be useful for someone:
  uv_udp_t* socket = new uv_udp_t;
  uv_udp_init_ex(Loop::GetLoop(), socket, UV_UDP_RECVMMSG | AF_INET);

  uv_os_fd_t fd;
  if (uv_fileno(reinterpret_cast<uv_handle_t*>(socket), &fd) == 0) {
    uint32_t yes = 1;
    int err = setsockopt(fd, SOL_SOCKET, SO_REUSEPORT, (char*)&yes, sizeof yes);
    printf("setsockopt SO_REUSEPORT err %d\n", err);
  }
  struct sockaddr_in recv_addr;
  uv_ip4_addr(listenIp.c_str(), listenPort, &recv_addr);
  uv_udp_bind(socket, (const struct sockaddr*)&recv_addr, UV_UDP_REUSEADDR);
  // ...

(for some implementations of Loop::GetLoop()


Soft delete within the data access layer

Describe the issue to be researched
Within healthcare apps, resources (like observations etc) are often considered immutable. Most relevant resources (like Observations) do not have a 'status'. If there is a desire to delete data, should we provide the option to do a soft delete.
Currently within the SDK, resources can be DELETED (using the data-access API).
To support SOFT DELETE, we would look to:

[ ] Add 'flag' to the db for resources
[ ] Within search results, by default only return resources where SOFT DELETE is NOT TRUE
[ ] Provide additional search param for returning resources where SOFT DELETE is TRUE

Describe the goal of the research

[ ] Solicit input from implementer's on use cases to determine if resources are ever deleted
[ ] Determine if we should support the ability to SOFT DELETE a resource and filter it out of results

Describe the methodology
We will get input from the community of implementers who are best placed to help inform this. If there is a need for this functionality we will then determine the priority.
Would you like to work on the issue?
Yes

I think this issue is somewhat ameliorated by the fact that FHIR servers might implement soft delete, e.g., https://smilecdr.com/docs/fhir_repository/deleting_data.html. So if a resource is originated from the server side, deleting it on device will not remove the physical record on the server (although it won't show up in the search results from the server any more, you can still access the history of it by making specific queries listed in the aforementioned link).
On the other hand, if a resource is originated on the client side (e.g. a newly registered patient that hasn't been synced to the server), then not having soft delete will result in the record being permanently deleted.

Thanks @jingtang10. @joiskash , @pld or anyone else - any thoughts on this? Thanks.

It will be a good feature to have and there is a current requirement to support soft delete in one of our projects. The project has a very simple uni-directional data flow. So to prevent the application from taking up too much space on the client phone we are implementing a soft delete. Just FYI we are not using the android SDK for this project.

@jingtang10 One of the case where enabling a soft delete even when sync to the server has not happened would be in case where Peer to Peer sync is enabled.
A soft delete, will be required in order to propergate the delete action to the server and eventually to any device that may have offline shared data.
If we iallow for P2P then a soft delete , at the very least for P2P shared data , will be required.

Thanks all for your comments. From reviewing the thread, we are proposing to mark this as a 'nice to have' feature for the planned beta release (Q4 '21).
It will be good to flesh this out a bit further. Plan will be to create a new issue for this, specify the requirements and the prioritise for the post beta release roadmap.
I'm going to close the issue for now. If there are major objections, please let me know and we can reivisit. Thanks
cc: @pld @jingtang10 @joiskash @rkodev


Fix syntax error in the cli compilation opspec

Although it works somehow, there's currently a schema violation in the cli compilation opspec that I notice whenever I touch it.

It's an old schema is why. It matches current schema. I think @SudhindraKovalam made a PR to the upstream vscode plugin to add our schema at some point; we likely need to start submitting PR's any time opspec changes.

@apexskier see https://github.com/opctl/opctl/issues/615

hmm. I'd be surprised if it was an editor plugin. Most I've worked with pull from https://github.com/SchemaStore/schemastore
yeah - https://github.com/SchemaStore/schemastore/blob/master/src/schemas/json/opspec-io-0.1.7.json

I actually see a similar to the one reported in #615 until I make a change to the file, then I see the one in my opening comment.

I actually see a similar to the one reported in #615 until I make a change to the file, then I see the one in my opening comment.

Yeah in my experience the error doesn't prohibit the rest of the schema working; it's just annoying

@apexskier this PR fixed the schema by just putting everything directly in a single vanilla jsonschema file as opposed to using multiple files and a bundling library https://github.com/opctl/opctl/pull/902


API - getCustomer

Basic customer response is getting validated against Customerdetail model and failing.
According to the standards PhoneNumber, email and physicalAddress can be empty.
Errors:
Required field 'phoneNumbers' has null value in
{   "middleNames" : [ "middleNames" ],   "firstName" : "firstName",   "lastName" : "lastName",   "emailAddresses" : null,   "occupationCode" : null,   "prefix" : "",   "physicalAddresses" : null,   "suffix" : "",   "phoneNumbers" : null,   "lastUpdateTime" : "2019-05-22T00:00:00Z" }
Required field 'emailAddresses' has null value in
{   "middleNames" : [ "middleNames" ],   "firstName" : "firstName",   "lastName" : "lastName",   "emailAddresses" : null,   "occupationCode" : null,   "prefix" : "",   "physicalAddresses" : null,   "suffix" : "",   "phoneNumbers" : null,   "lastUpdateTime" : "2019-05-22T00:00:00Z" }
Required field 'physicalAddresses' has null value in
{   "middleNames" : [ "middleNames" ],   "firstName" : "firstName",   "lastName" : "lastName",   "emailAddresses" : null,   "occupationCode" : null,   "prefix" : "",   "physicalAddresses" : null,   "suffix" : "",   "phoneNumbers" : null,   "lastUpdateTime" : "2019-05-22T00:00:00Z" }
As raised by @anzbankau:
https://github.com/ConsumerDataStandardsAustralia/engineering/issues/52#issuecomment-539832429

Hi @anzbankau, https://consumerdatastandardsaustralia.github.io/standards/includes/swagger/cds_full.json says

Array is mandatory but may be empty if no phone numbers are held

So, the value is supposed to be [] instead of null
The same for emailAddresses and physicalAddresses

I have confirmed with the Standards team that the mandatory array value is supposed to be [] instead of null.

Hi @nghamilton @fyang1024
I think maybe the real issue we are seeing was not clearly articulated, what we are seeing is that these data elements are being checked on a get customer call but they are not part of the get customer API standard, they should only be checked on a detail call.

Hi @anzbankau
If it is ResponseCommonCustomer data which includes a CommonPerson or CommonOrganisation, then phoneNumbers field should not appear in the data structure at all. The same applies to emailAddresses and physicalAddresses. Correct me if I am wrong

Hi @fyang1024
The request we are sending is for get customer and it does not contain the phoneNumbers, emailAddresses or physicalAddresses fields but the conformance suite is throwing errors specific to ResponseCommonCustomerDetail instead of ResponseCommonCustomer.

Hi @anzbankau
The tool cannot send get customer request by itself yet. What you can do now with tool regarding customer is something like
cds-shell> validate-path customer.json
How did you use it?

Following steps we are performing in the conformance testing .
Customer_001.json :
{
"data": {
"customerUType": "person",
"person": {
"lastUpdateTime": "2019-05-22T00:00:00Z",
"firstName": "TEST",
"lastName": "TEST",
"middleNames": [
"TEST"
],
"prefix": "",
"suffix": ""
}
},
"links": {
"self": "https://api.anz/cds-au/v1/common/customer"
},
"meta": {}
}
validate-path -f /Users/yarramak/Desktop/Conformance-sep/JSON/customer_001.json
Below is the error message returned
Encountered errors while validating: /Users/yarramak/Desktop/Conformance-sep/JSON/customer_001.json
Required field 'phoneNumbers' has null value in
{
"middleNames" : [ "TEST" ],
"firstName" : "TEST",
"lastName" : "TEST",
"emailAddresses" : null,
"occupationCode" : null,
"prefix" : "",
"physicalAddresses" : null,
"suffix" : "",
"phoneNumbers" : null,
"lastUpdateTime" : "2019-05-22T00:00:00Z"
}
Required field 'emailAddresses' has null value in
{
"middleNames" : [ "ANTHONY" ],
"firstName" : "STUART",
"lastName" : "HARTLEY",
"emailAddresses" : null,
"occupationCode" : null,
"prefix" : "",
"physicalAddresses" : null,
"suffix" : "",
"phoneNumbers" : null,
"lastUpdateTime" : "2019-05-22T00:00:00Z"
}
Required field 'physicalAddresses' has null value in
{
"middleNames" : [ "ANTHONY" ],
"firstName" : "STUART",
"lastName" : "HARTLEY",
"emailAddresses" : null,
"occupationCode" : null,
"prefix" : "",
"physicalAddresses" : null,
"suffix" : "",
"phoneNumbers" : null,
"lastUpdateTime" : "2019-05-22T00:00:00Z"
}

Thank you @anzbankau for sending the test data. It is a bug. Basically there are two potential models in this case, ResponseCommonCustomer and ResponseCommonCustomerDetail. The payload validator used to find any matching model and do the validation. Now it goes through all possible matching models and find the best one. The fix is in codegen-attempt branch now.
It will be ready in 1.0.0-RC2 release

Hi @anzbankau,
Can you please try out the latest code / artefacts and let us know if the issue persists?


Hands JavaScript API Error

I've encountered following error on both Android / PC Chrome browser when running the Hands JavaScript API example given. The error happens when no hand is detected.
Uncaught (in promise) TypeError: Cannot read property 'map' of undefined
    at Object.transform (hands.js:44)
    at ja.h (hands.js:42)
    at U (hands.js:10)
    at ma.next (hands.js:11)
    at hands.js:22
    at new Promise (<anonymous>)
    at X (hands.js:22)
    at Object.onResults (hands.js:39)
    at methodCaller_void_$vector$ResultData$$ (eval at new_ (hands_solution_wasm_bin.js:9), <anonymous>:5:26)
    at __emval_call_void_method (hands_solution_wasm_bin.js:9)

I believe this error is from the latest version (0.1.1613506466) as the error doesn't occur when test with older version (0.1.1612238212).
Can anyone look into this?

I believe this issue is fixed with the latest version (0.1.1614621970) and even fps was improved. Thanks for the great work!!


Add CLI command to list vaults

Depends on: https://github.com/build-trust/ockam/issues/3933
Add a new command to list the available vaults. For each vault, show the same information as the vault show command.
A new list method must be implemented for VaultsState, similar to the NodesState's list method.
This command should prevent the user from deleting the vault if it's being used by a node. You will have to list the nodes, and check for each one its default_vault (opts.state.nodes.list() + node.config.default_vault).

We love helping new contributors!
If you have questions or need help as you work on your first Ockam contribution, please leave a comment on this discussion.
If you're looking for other issues to contribute to, checkout this discussion and labels -  https://github.com/build-trust/ockam/labels/good first issue or https://github.com/build-trust/ockam/labels/help wanted

I'd like to have a shot at this if there are no takers.
I noticed the parent issue has an assignee, but if this can be done separately, I don't mind setting up my env here

If I am not mistaking, this will be implemented by exposing the Vaults::list method that we introduced in #4106.

If I am not mistaking, this will be implemented by exposing the VaultsState::list method that we introduced in #4106.

Yes, there is an in-progress PR by @hargut adding this command. We'll wait for him in case he wants to finish it.

Hi @adrianbenavides,
sorry for the late response to your comments. I've rebased the PR, use the now already available list() function, and added the commands.bats test.
As I had the impression that we already had one similar comment on another PR and I wanted to dig deeper into the rust language features I've prepared a patch that moves the cli_state.rs towards traits with generics and default implementations where possible.
Currently the patch does not provide much added value (features). It unifies the functions and removes duplications where possible. As during the past days there where several changes the patch is right now out-of-sync to the develop branch.
In case it is of interest for you, and/or you have ideas/comments for improvement please let me know. I can prepare a rebased version and enhance it.
Best regards,
Harald

As I had the impression that we already had one similar comment on another PR and I wanted to dig deeper into the rust language features I've prepared a patch that moves the cli_state.rs towards traits with generics and default implementations where possible.

Can you post the link again? It seems it's broken. I'll take a look at the patch as soon as I can, thanks for taking the time to look into that!

Hi @adrianbenavides,
sorry it seems to have been a wrong link, this one should work:
https://github.com/hargut/ockam/commit/2d2044da57659fc6de4821eab734fe757fcc9383

Hi @adrianbenavides,
thank you for the feedback.
I fully understand your points and during the learning I've as well thought that it might be easier and more flexible when using free functions for duplicated code parts.
Best regards,
Harald


Fix Unit tests for Python 3.12

I added version 3.12 to the CI/CD pipeline in #126 and some tests failed.
https://github.com/crowdin/crowdin-api-client-python/actions/runs/6453647001/job/17517596970
We need to fix these tests to run successfully on 3.12.

Hi @andrii-bodnar, I am interested in working on this issue. It looks like using assert_called_once_with will fix the test.


How to use in browser?

How to use with browser? My setup is "vue3 vite typescript"
What i get:
Module "util" has been externalized for browser compatibility.
Cannot access "util.promisify" in client code.
See https://vitejs.dev/guide/troubleshooting.html#module-externalized-for-browser-compatibility
for more details.

Uncaught TypeError: util.promisify is not a function
    at node_modules/webp-wasm/index.js (index.js:144:28)
    at __require (chunk-LQ2VYIYD.js?v=96781a35:8:50)
    at index.js:146:63

This project, webp-wasm, is ONLY for use in Node.js on the server.  The WASM sources were taken from Google's Squoosh and CONVERTED to work on Node.js land.  If you are trying to load WebP images in the browser, then.....
(1) All major browsers now support WebP natively.  See Can I Use for the support matrix.  It's basically universal now.  You should not need a WASM WebP library at all anymore on the client-side.
(2) If for some reason you cannot use the built-in browser WebP system, and you must load it using WASM, check out Squoosh: https://squoosh.app/ -- Source: https://github.com/GoogleChromeLabs/squoosh -- This is where I got the WebP WASM blobs, and their version works in the browser.  Don't use my hacked one.

Got it. The reason why I need WASM WebP is because iOS Safari Canvas has a limit of 4096x4096. I need to process images that are much bigger. I've created a VirtualCanvas library that manages tiled images (every tile is OffscreenCanvas elements 4096x4096). Now, I need a way to stitch all tiles into one huge WebP file without using an intermediate OffscreenCanvas.

Ah, gotcha.  I wish they'd increase that limit.  Most phones nowadays could easily handle 16384x16384 or more.


Remove version: Jackett.Jackett version 0.20.3150

404 - release deleted
Microsoft Reviewers: Open in CodeFlow

URL: https://github.com/Jackett/Jackett/releases/download/v0.20.3150/Jackett.Installer.Windows.exe
Response Error: The remote server returned an error: (404) Not Found.
(Automated message - build 918)


updates for v0.7.0 release

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (1ce3687) 77.45% compared to head (6287f50) 77.45%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #25   +/-   ##
=======================================
  Coverage   77.45%   77.45%
=======================================
  Files         109      109
  Lines        8662     8662
=======================================
  Hits         6709     6709
  Misses       1953     1953

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


start in on validation policies

WIP. Gonna add some tests, but I think the high-level idea is there.

This has a bug .validate on leaves need to be changed or they'll use the parent subclasses record not their own.

alright @justinbastress I think I've fixed up all the bugs. Should be good to review. I'm going to write some examples/tests and make sure this meets @cdzombak's biggest dreams and desires.

Alright! Added some documentation here: https://github.com/zmap/zschema/wiki/Validating-Data

@justinbastress fixed

I'm going to fix the formatting string and merge so that @cdzombak can use. I'll fix up enum method when I add the CLI endpoint here in a moment.


Cannot join MultiProgress with hidden ProgressBars

I seem to be unable to join a MultiProgress containing hidden ProgressBars. I would have expected this to work, or alternatively to be able to figure out a workaround from the documentation.
#[test]
fn hangs() {
    let m = MultiProgress::new();

    let p = m.add(ProgressBar::new(1));
    p.set_draw_target(ProgressDrawTarget::hidden());
    p.finish_and_clear();

    m.join_and_clear();
}

The confusion here comes from the fact that Hidden is a draw target, but so is Remote (which is applied by m.add(...), so setting it to hidden makes it override the remote, thus the multiprogress no longer ever receives anything.
The workaround is to never call any draw methods, which will keep a progress bar hidden, even inside a multi-line.
Those two bits of information should be added to the documentation of ProgressDrawTarget::hidden(). I can do that next weekend.

Thanks for the clarification and usage guidelines @andreivasiliu.
The way I was using progress bars was to set up their "visibility" on a higher scope by setting their draw target, and then in low-level functions just updating them -- there is currently no concept of visibility in these places. From what you write this is neither intended nor possible currently, so I might need to add some indirections to adapt the bars for the actual model. It would have been great if indicatif supported some way to avoid that.

Closing this as works as intended for now. I'm not super happy how the draw targets work. Ideally one can hide the progress bar differently anyways than setting a draw target.


Supply of Nano V3 Module

As a biologist, it is amazing to see how doable this is. My question is how quickly could the Nano modules be acquired. The demand for a million is going to hit like a freight train possibly as soon as two to three weeks. Is there any way that these could be sourced or scavenged locally?  https://sccm.org/Blog/March-2020/United-States-Resource-Availability-for-COVID-19?_zs=jxpjd1&_zl=w9pb6
We could easily need a million more after that with a month because the projection in the attached article is with only 20 million infected. I will try to dumb this down so a biologist like me can understand it and so Joe the plumbers can start to build them in their garages. But it looks brilliant to me.

I doubt that Arduinos would be the limiting factor; there are tons of Arduinos (or clones, which work fine too) in the world.  Many different models of Arduinos (Nano, Micro, etc.) could probably all work.  I teach a workshop for kids with my friends and we have bought many hundreds of Arduinos in the past.  Don't know what the actual total supply #s though...
However the best thing to do, if somebody is reading this and would like to take it on,
would be to start to assemble numbers on supplies of all different parts.
And also starting to think through logistics.

Arduino is an open source product. So every can make then thereself https://www.instructables.com/id/How-to-make-your-own-Arduino-board/. Also if there is a problem with getting arduino's inside the Netherlands I can help with supplying arduino's I maybe have access to a number of arduino nano /uno range(100-150)

@Brashdan ,
I am happy to help in porting the Arduino source code to any controller board that you may have around you. I can literally program anything from FPGAs to workstations (even old computers).

Sourcing of the cloned Nano board is not a problem, the bottle neck is the CPAP motor.

If you guys will help me program it, I am going to try to build one. And if
that works, may try to build more because it looks like there are going to
be a lot of people over 60 (like me) that will be not get critical care in
the hospitals due to lack of ventilators.  I suspect they will just let
their family watch them turn blue and die so there will be lots of people
that could be saved by the family taking their loved ones home to the
garage and using an ad hoc ventilator. Perhaps they will not allow that
though. But as the law stands now, they could not prevent a family from
doing that.
On Wed, Mar 18, 2020 at 3:11 PM ArtSuzhou<EMAIL_ADDRESS>wrote:

Sourcing of the cloned Nano board is not a problem, the bottle neck is the
CPAP motor.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/jcl5m1/ventilator/issues/10#issuecomment-600835320,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AOZ4HTDNBSOIQWYOEQHIPOTRIETGVANCNFSM4LNRDU5Q
.


Prompt store

There are currently two main prompts, designed for use in Notebooks:

Coding assistance
Exception diagnosis

The defaults used will come from the GlobalPromptStore. The user can override these defaults by passing in a custom prompt to
set_exception_prompt or set_assist_prompt.
>>> from genai.prompts import set_exception_prompt
>>> set_exception_prompt("You will get an exception. Do something with it.")

Closes #42


Added locale: zh-CN to Microsoft.SQLServerManagementStudio.yaml

Added locale: zh-CN

[x] Have you signed the Contributor License Agreement?
[x] Have you checked that there aren't other open pull requests for the same manifest update/change?

[x] Does your manifest conform to the 1.0 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.

Microsoft Reviewers: Open in CodeFlow

It is based on the original format and only add zh-CN locale support, no other changes

For more than one installer you need to use multi-manifest format, take firefox for example manifests/m/Mozilla/Firefox/92.0
https://github.com/microsoft/winget-cli/blob/master/doc/ManifestSpecv1.0.md

@KaranKad okay, thanks. 👍


New account - Onboarding messages aren't present when selecting "Something else" in the modal

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: 9.0.7-4
Reproducible in staging?: Y
Reproducible in production?: N
Found when executing PR : https://github.com/Expensify/App/pull/45248
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal team
Action Performed:

Navigate to https://staging.new.expensify.com/

Lig in with a new Gmail account

Choose "Something else" in the onboarding modal

Input any first and last name and click on the "Continue" button

Open Chrome console

Paste and run "Onyx.log('nvp_onboarding');"

Copy the received chatReportID from the console

Paste it after the last "/" in the link and navigate to it: https://staging.new.expensify.com/r/

Expected Result:
Onboarding messages should be visible.
Actual Result:
Onboarding messages aren't present when selecting "Something else" in the modal. They're visible for all of the other onboarding options.
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android: Native
[ ] Android: mWeb Chrome
[ ] iOS: Native
[ ] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[ ] MacOS: Desktop

Screenshots/Videos
https://github.com/user-attachments/assets/63b56ee2-d7ab-44ac-8e13-e0ba769a5113

View all open jobs on GitHub

We think this issue might be related to the #collect project.

Hmmm wait, but I can also reproduce on prod... is this the message that I am not supposed to be seeing?

@iwiznia  In step 6

Paste and run "Onyx.log('nvp_onboarding');

"Onyx.log('nvp_onboarding'); returns with an error in production, but onboarding message is not present for both production and staging when selecting "Something else" option.

Seems this was triggered when testing https://github.com/Expensify/App/pull/45248 since the script does not work on prod cc @rojiphil @chiragsalian
Not a blocker though

I'm still confused.

Onboarding messages aren't present when selecting "Something else" in the modal. They're visible for all of the other onboarding options.

There aren't any onboarding tasks when that onboarding intent is selected, so I wouldn't expect any.

Onboarding messages aren't present when selecting "Something else" in the modal.

I also think this is expected.
But what I don't understand is They're visible for all of the other onboarding options.
My understanding is that onboarding messages are shown only when we have a workspace i.e. via Manage my team's expenses
@trjExpensify @chiragsalian Is this understanding correct?

My understanding is that onboarding messages are shown only when we have a workspace i.e. via Manage my team's expenses

Nah, there's tasks for different onboarding intents. Just not the "something else" option. You have access to the doc already to check out the UI of those if you're interested.

My understanding is that onboarding messages are shown only when we have a workspace i.e. via Manage my team's expenses

Nah, there's tasks for different onboarding intents. Just not the "something else" option. You have access to the doc already to check out the UI of those if you're interested.

Oh shoot! I got confused with the term Onboarding messages. Thanks for pointing out the document.

Can we close this issue please if there is nothing to be fixed here?


Account Tab - User Profile

The account tab in the user profile page gives the details of the userAccount

Switch Metamask wallet / Prepaid Wallet
User Address

Will be closed with the PR #189


Blank Wifi Password and Status Pixel Brightness

The wippersnapper firmware supports open networks now, so we need to stop validating that a wifi password is present, per #21
Also add the pixel brightness setting requested in #23
Closes #23
Closes #21

Test Pass: Blank WiFi password
Test Fail: Using pixel brightness of 0.0 on the form does not turn the pixel completely off.


Limit java heap size

Currently after just a few interactions with local DynamoDB its java process' memory usage becomes ~2GiB. It looks like a serious waste of memory for a SQLite wrapper. There are two options:

Set reasonable default, e.g. -Xmx256m works fine
Provide a way for override java config through passing an environment variable to the container

First of all, thanks for using this image and posting the very first question in this repository.
How about using the _JAVA_OPTIONS environment variable?
For ex: docker run -e _JAVA_OPTIONS='-Xmx256m' cnadiminti/dynamodb-local:latest

@saaj Please pull the latest images, verify and let us know.

JAVA_OPTS works like a charm. Thank you.

Thanks for the confirmation.


[full-ci] Bump web to v5.3.0-rc.1

Description
Pre-release to introduce a bunch of spaces UI improvements (huge kudos to @JanAckermann and @JammingBen ), alongside other fixes & stuff.

Damn, forgot to update the settings tests 🤦♂ will do so tomorrow morning

There's a typo in the german translations. Let's make an rc2 and wait with this PR for that. Objections?

There's a typo in the german translations. Let's make an rc2 and wait with this PR for that. Objections?

Nope, sounds good to me. CI is green but the typo would need to be fixed in settings/ui/tests/acceptance/helpers/language.js 🦖

There's a typo in the german translations. Let's make an rc2 and wait with this PR for that. Objections?

Nope, sounds good to me. CI is green but the typo would need to be fixed in settings/ui/tests/acceptance/helpers/language.js 🦖

Will follow up with an RC.2 (typo fixes and new features) soon

Let's merge. The next rc is just around the corner, but this already unblocks other stuff.


Fix standalone fuse tarball error

What changes are proposed in this pull request?
When generate a tarball for standalone fuse, the tarball script is not work.
Why are the changes needed?
Please clarify why the changes are needed. For instance,

If you propose a new API, clarify the use case for a new API.
If you fix a bug, describe the bug.
Fix standalone fuse tarball error

Does this PR introduce any user facing changes?
No
Please list the user-facing changes introduced by your change, including

change in user-facing APIs
addition or removal of property keys
webui

@Xenorith do you mind helping take a look? Thanks

thanks for the fixes. @LuQQiu fyi


containerd 1.7.x support idmap mount containers.

What is the problem you're trying to solve
kubernetes starting 1.27 sets Uid and Gid mappings on mounts for userns pods. However there is no version of containerd that is released that supports idmap mounts. containerd 1.7 which is the latest minor release has an explicit check that rejects  any container with idmap mounts. I noticed that main branch does support this and we would need to backport this to release-1.7 branch but considering that is the latest released minor version I would expect this to work in latest patch version under 1.7 since we don't have a target date for 2.0 yet.
Without any released version it is hard for cloud-providers to test this kubernetes feature who rely on containerd.
Describe the solution you'd like
Please release containerd 1.7.x which has support for idmap mounts. This will give cloud-providers that rely on it enough time to test.
Additional context
No response

/cc @samuelkarp

/cc @mtaufen

I think https://github.com/containerd/containerd/pull/8287 and https://github.com/containerd/containerd/pull/5890 added idmapped mounts to main (targeted for 2.0).

we would need to backport this to release-1.7 branch

We don't generally backport new features to existing releases.  This will be part of 2.0.

Without any released version it is hard for cloud-providers to test this kubernetes feature who rely on containerd.

Cloud providers who need to test this can build from the main branch.  That will be a reasonable preview of what we'll eventually stabilize into 2.0.

@vinayakankugoyal furthermore, just backporting that in containerd won't do the trick, as support is needed in low level container runtimes. crun supports this in stable releases, runc only in the main branch.
When we discussed briefly about backporting to 1.6 LTS, Derek said that usually a feature need to be part of a stable release and be working fine before backporting to other releases.


Error: The received data is no valid JSON-RPC 2.0 Response object.

I have what I believe is a valid JSONRPC response, but the above error gets thrown,
const response = await remote.call(
  "sys.versions",
  {},
  {
    jwt: "...",
  }
);

JSON response:
{"jsonrpc":"2.0","result":{"boost":{"version":"1.80.0"},"libtorrent":{"revision":"63e1ec8c8","version":"<IP_ADDRESS>"},"nlohmann_json":{"version":"3.11.2"},"openssl":{"release_date":"1 Nov 2022","version":"3.0.7","version_text":"OpenSSL 3.0.7 1 Nov 2022"},"porla":{"branch":"-","commitish":"-","version":"0.30.0"},"sqlite":{"source_id":"2022-11-16 12:10:08 89c459e766ea7e9165d0beeb124708b955a4950d0f4792f457465d71b158d318","version":"3.40.0"},"tomlplusplus":{"version":"3.1.0"}}}

Any help would be much appreciated.

Hi @sachaw the data has no methodand ìd`properties. Please take a look at the specification which is really short and well written: https://www.jsonrpc.org/specification

Thanks, sorted now!


When executing jekyll build within docker container (w/o -s and -d options) it always uses /srv/jekyll both for source and destination regardless of current working directory

Here is the command line log:
arman@mataghis:/workspace$ cd test/
arman@mataghis:/workspace/test$ pwd
/workspace/test
arman@mataghis:/workspace/test$ ls
assets  bitbucket-pipelines.yml  Gemfile  Gemfile.lock  _includes  index.html  _layouts  libs  main.css  main.js  _posts  _site
arman@mataghis:/workspace/test$ sudo docker run --volume=/workspace/test:/opt/test -i -t jekyll/jekyll /bin/bash
bash-4.3# pwd
/srv/jekyll
bash-4.3# ls
bash-4.3# cd /opt/test/
bash-4.3# pwd
/opt/test
bash-4.3# ls
Gemfile                  _includes                _posts                   assets                   index.html               main.css
Gemfile.lock             _layouts                 _site                    bitbucket-pipelines.yml  libs                     main.js
bash-4.3# docker build
bash: docker: command not found
bash-4.3# jekyll build
Configuration file: none
            Source: /srv/jekyll
       Destination: /srv/jekyll/_site
 Incremental build: disabled. Enable with --incremental
      Generating...
                    done in 0.01 seconds.
 Auto-regeneration: disabled. Use --watch to enable.

This is by design as we expect you to mount your data inside of /srv/jekyll the same way that PostgreSQL expects your data in a specific way.  This image is not a base image, it is a software image, so we expect things to be consistently mounted to avoid the unnecessary need of using -s and if you wish to mount in another spot, we expect you to use -s.

I see, but I didn't figure how do you achieve this. I looked in dockerfile but didn't find any strange instructions that can make this happen.
Thank you for super prompt response.

https://github.com/jekyll/docker/blob/01561852cf7af68c7f32a8202b4459acef945474/repos/jekyll/copy/all/usr/local/bin/jekyll#L18

Thanks you much!


Apply Spotless for consistent code formatting

As a follow-up to #102, we want to make sure we have consistent code
style.
We can do this using Spotless, which has support for most of the
languages and file formats in this repo, as well as ???

Not sure if these issues are related? :grimacing:

@jamietanna currently demos are flaky. I'm going to fix them in new PR

Ah, flakey in what sense?

Different groovy versions in gradle 6.x and 7.x

Additionally, you can see Compat.kt for compatibility shims around various versions of Gradle

I opened Android sample and code format does not work properly


problem new install on ubuntu

I followed the instructions in README for ubuntu but I get error messages constantly and I don't see hashes getting into /stats/
Here :
Traceback (most recent call last):
File "/home/btc/hopp/eventlet/hubs/hub.py", line 336, in fire_timers
timer()
File "/home/btc/hopp/eventlet/hubs/timer.py", line 56, in call
cb(*args, **kw)
File "/home/btc/hopp/work.py", line 227, in handle_store
hook.notify(rpc_request, data, server)
File "/home/btc/hopp/peak/util/plugins.py", line 58, in notify
for hook in self.query(*args, **kw):
File "/home/btc/hopp/peak/util/plugins.py", line 68, in query
yield hook(*args)
File "/home/btc/hopp/plugins/rpcworklog/rpcworklog.py", line 26, in rpcWorkReport
self.bitHopper.log_msg('RPC request [' + data[0][155:163] + "] submitted to " + server)
AttributeError: BitHopper instance has no attribute 'log_msg'
Traceback (most recent call last):
File "/home/btc/hopp/eventlet/hubs/hub.py", line 336, in fire_timers
timer()
File "/home/btc/hopp/eventlet/hubs/timer.py", line 56, in call
cb(*args, **kw)
File "/home/btc/hopp/work.py", line 227, in handle_store
hook.notify(rpc_request, data, server)
File "/home/btc/hopp/peak/util/plugins.py", line 58, in notify
for hook in self.query(*args, **kw):
File "/home/btc/hopp/peak/util/plugins.py", line 68, in query
yield hook(*args)
File "/home/btc/hopp/plugins/rpcworklog/rpcworklog.py", line 26, in rpcWorkReport
self.bitHopper.log_msg('RPC request [' + data[0][155:163] + "] submitted to " + server)
AttributeError: BitHopper instance has no attribute 'log_msg'

rapid solution:replace all "self.bitHopper.log_msg" with "pass" in rpcworklog.py
because plugin not support new logging system )

I never used a password until not, will try just removing it.

On Mon, Dec 26, 2011 at 1:37 PM, Transisto
<EMAIL_ADDRESS>wrote:

I never used a password until not, will try just removing it.
no password! "pass" - is operator in python

Reply to this email directly or view it on GitHub:
https://github.com/c00w/bitHopper/issues/537#issuecomment-3272667

Thanks it work fine.

u welcome )
deepbit and bitcoin.lc works? in last commit mine_lp looks broken :(

yep, deepbit does not get updated,  (800%+)
It it a bug from the latest commit ?

It it a bug from the latest commit ?
i dont know. may be bug. need seen code

I had not this problem on windows on the previous one.

I had not this problem on windows on the previous one.
me too :) problem in last commit? may be

I updated the logging system and accidenatally broke a module. I'll fix it.

It should be fixed.

On Mon, Dec 26, 2011 at 4:44 PM, Colin Rice
<EMAIL_ADDRESS>wrote:

It should be fixed.
thanks )

Updated,
Deepbit shares keep rising endlessly.

Okay, I'm going to close this issue and deal with that in #538.


Add Arel::Nodes::FullOuterJoin and Arel::Nodes::RightOuterJoin

If it's possible it would be interesting to add those contants, to allow us to make full outer join and right outer join in an arel fashion.

Per #523, Arel development is moving to rails/rails.
If this issue is still relevant, please consider reopening it over there. (Note that the Rails repository does not accept feature request issues, and requires reproduction steps that rely on Active Record's documented API.)


Fixed actions collection indentation

Actions collection section in api.yml was indented one
extra level.
while yaml works fine with this, just fixing the alignment
to be consistent with all the other collections.

/cc @imtayadeway just being picky.

@abellotti LGTM :thumbsup:


In-memory engine: evict range after some raft commands

What is changed and how it works?

Issue Number: Ref #16141

What's Changed:
evict range when becomeing follower, merge, and deleting data ranges.

Related changes

[ ] PR to update pingcap/docs/pingcap/docs-cn:
[ ] Need to cherry-pick to the release branch

Check List
Tests

[x] Unit test
[x] Integration test
[ ] Manual test (add detailed scripts or steps below)
[ ] No code

Side effects

[ ] Performance regression: Consumes more CPU
[ ] Performance regression: Consumes more Memory
[ ] Breaking backward compatibility

Release note

None

Now, we are more focused on correctness and leave some optimizations (such as using binary search when checking ranges) in the future.

/retest-required

/run-test retry=7

/retest-required

/test pull-unit-test

/run-clippy-darwin-amd64