Please invite me to the Recode-Hive GitHub Community Organization

Name
Ubedullah Akhund
Discord Username (if applicable)
No response
Additional Context
No response

Invitation sent to join the GitHub Organisation. Welcome to the community 🎉
Don't forget after accepting to make it public so it appears on your GitHub profile for everyone else to see. You can do this by finding your name in the GitHub organisation list and change the dropdown to public https://github.com/orgs/recodehive/people


Models with Devise::Models::Authenticatable have degraded pretty-printing

Environment

Ruby 2.5.8
Rails <IP_ADDRESS>
Devise 4.7.1

Current behavior
class AuthenticatableUser < ActiveRecord::Base
  devise :database_authenticatable
end

pp AuthenticatableUser.first
=begin
#<AuthenticatableUser id: 1, name: "Greg Grimaldus", email<EMAIL_ADDRESS>nested_field:
=end

Additionally, the output is all one color in a REPL like Pry.
Expected behavior
class NonAuthenticatableUser < ActiveRecord::Base
end

pp NonAuthenticatableUser.first
=begin
#<NonAuthenticatableUser
 id: 1,
 name: "Greg Grimaldus",
 email<EMAIL_ADDRESS> nested_field:
  #<NestedField:0x0ab88383223
   @nested_field_attr=1>,
 ...MANY_MORE_FIELDS...>
=end

Additionally, in a REPL like Pry, each attribute has color highlighting based on the value type.
Cause
The reason this occurs is because Devise::Models::Authenticatable overrides inspect and if the method is overriden, then ActiveRecord::Core#pretty_print defers to super. This is probably PP::ObjectMixin#pretty_print, which doesn't have the niceties described in the "Expected behavior" section.

This should be resolvable by the solution proposed in this comment now that that ActiveRecord feature described has landed.


src: atomics arm64 version of barrier-less compare and swap values.

The aarch64 failures are presumably related?

The aarch64 failures are presumably related?

err ... I ve been developing and testing it in a mac m1 then testing on arm64 without this maybe this is qemu/tcg not being able to translate properly ... maybe better to leave as it is then.

err ... I ve been developing and testing it in a mac m1 then testing on arm64 without this maybe this is qemu/tcg not being able to translate properly ... maybe better to leave as it is then.


don't show traceback if import error is suppressed

Fixes #218

I can test really quick if you want

Wow thanks @JelleZijlstra , so quick! You're the best!


[StableHLO] Migrate samples to StableHLO

Tested by running all notebooks locally.
The mnist model was converted using
iree-opt --iree-convert-mhlo-to-stablehlo.
Fixes: https://github.com/openxla/iree/issues/13869

Seems like editing a few strings in the notebooks also caused them to be re-rerialixed in equivalent but different format. Is this fine or should I redo these modifications with some plain text editor? Not sure what the best practices for working with notebooks are.

@ScottTodd would know more, but I suspect it's where you ran it? did you use colab? (I see vscode things in there - maybe colab now adds those?)

Rebase and update experimental samples

Seems like editing a few strings in the notebooks also caused them to be re-serialized in equivalent but different format. Is this fine or should I redo these modifications with some plain text editor? Not sure what the best practices for working with notebooks are.

I would recommend dropping the metadata and output changes from this PR, yes.

The best supported (but also inconvenient) way to edit is in Colab, as documented here: https://github.com/openxla/iree/tree/main/samples/colab#working-with-github
For simple text replacements like these, you can edit in VSCode (open with text editor) and then either
A) Save without formatting
B) Save with formatting and then only git commit the relevant changes (ignore metadata changes, newlines, etc.).
Open with text editor:

Here's how I pick which lines to commit in git gui:

Thanks @ScottTodd, I used the text editor mode to edit them without reserializing whole notebooks.


Define answer labels when using multiple answers

What is the context of this PR?
Ensure schemas that uses multiple answers define an answer label. The MutuallyExclusive question type are allowed to not define a label.
How to review
Ensure schemas are passing based on changed from https://github.com/ONSdigital/eq-questionnaire-validator/pull/104
Checklist

[ ] New static content marked up for translation
[ ] Newly defined schema content included in eq-translations repo

Closing this as an exception has been made for checkbox of length one. In runner, we only render the label for checkboxes that have at least 2 options.

Closing this as an exception has been made for checkbox of length one. In runner, we only render the label for checkboxes that have at least 2 options.


Garble imports and package paths in GOPRIVATE

Finally, finally this is done. This allows import paths to be obfuscated by modifying object/archive files and garbling import paths contained within. The bulk of the code that makes parsing and writing Go object/archive files possible lives at https://github.com/Binject/debug/tree/master/goobj2, which I wrote as well.
I have tested by garbling and checking for import paths via strings and grep (in order of difficulty) https://github.com/lu4p/binclude, garble itself, and https://github.com/dominikh/go-tools/tree/master/cmd/staticcheck.
This only supports object/archive files produced from the Go 1.15 compiler. The object file format changed at 1.15, and 1.14 and earlier is not supported.
Currently this breaks a few tests, I'm going to need help fixing them because it looks like many tests fail due to expected import paths no longer showing up in binaries.
Fixes #13.

Due to this change, tests on Go 1.14 and earlier will always fail, so we should probably remove them from the github actions workflow. Not doing it myself until I get the go-ahead as that will mean only the latest version is tested/supported.

I'll do a separate PR to drop support for 1.14, then you'll be able to rebase this when merged.
I'd also like to hear how this affects build times - you could use our existing benchmark for that. Right now, I don't know if it would be a <10% hit, or something more sizeable like 50%.

I will go back and add comments for more top level declarations later, not quite done with that yet

I think it would be worth adding a definition of unsupported versions of go. Launched on go1.11 and got a poorly understood message:
error parsing main objfile: parsing archive member "_go_.o": unrecognized object file format
exit status 2

It is better to output "This go version is unsupported".

I agree, though that's a problem in master already due to other reasons. Perhaps open an issue and/or PR about this.

I think it would be worth adding a definition of unsupported versions of go. Launched on go1.11 and got a poorly understood message:
error parsing main objfile: parsing archive member "_go_.o": unrecognized object file format
exit status 2

It is better to output "This go version is unsupported".

Maybe also add which versions are supported


Bump ScalaJS 0.6.8

add some workarounds for ShrinkSpecification

https://github.com/rickynils/scalacheck/commit/f1ea446138ccac5a3c0
https://github.com/rickynils/scalacheck/commit/155a054c61572724508
https://travis-ci.org/rickynils/scalacheck/builds/106758308

Thanks!


fix(frontend): avoid panic when querying log store internal table

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
Fix https://github.com/risingwavelabs/risingwave/issues/14429
Now the query will return error instead of panic
dev=> select * from __internal_s_3_sink_1003;
ERROR:  Failed to run the query

Caused by these errors (recent errors listed first):
  1: Scheduler error
  2: distribution key [4] must be a subset of primary key [0, 1]

In this PR, we allow returning error in some frontend methods instead of panic directly.
Checklist

[ ] I have written necessary rustdoc comments
[ ] I have added necessary unit tests and integration tests
[ ] I have added test labels as necessary. See details.
[ ] I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features #7934).
[ ] My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
[x] All checks passed in ./risedev check (or alias, ./risedev c)
[ ] My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)

[ ] My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

[ ] My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

Hmmm, it's better than panic, but is it possible to allow selecting from sink's internal table?
This error doesn't make sense to me/users because it's not the fault of this select statement.

but is it possible to allow selecting from sink's internal table?

I just inspected our codebase. We have many codes that are based on the assumption that the dist key is a subset of primary key. The panic comes from breaking the assumption in log store's internal table. Therefore, to allow selecting from the log store's internal table, we will need a great amount of work to refactor our code to break the assumption, and this is not trivial. Given that this is a special internal table and users are not expected to often query from it, it's not worthwhile to support this small case with great amount of work. Personally I think the best solution is just to avoid panic and report error. To be more user-friendly, we can change to a more reasonable error message such as distribution key is not a subset of primary key. You are probably querying a special sink internal table.

but is it possible to allow selecting from sink's internal table?

I just inspected our codebase. We have many codes that are based on the assumption that the dist key is a subset of primary key. The panic comes from breaking the assumption in log store's internal table. Therefore, to allow selecting from the log store's internal table, we will need a great amount of work to refactor our code to break the assumption, and this is not trivial. Given that this is a special internal table and users are not expected to often query from it, it's not worthwhile to support this small case with great amount of work. Personally I think the best solution is just to avoid panic and report error. To be more user-friendly, we can change to a more reasonable error message such as distribution key is not a subset of primary key. You are probably querying a special sink internal table.

Can we add an vnode column in the logstore's state table to use the tableCatalog::vnode_idx?

Can we add an vnode column in the logstore's state table to use the tableCatalog::vnode_idx?

Same idea. Store vnode as a separated column and use it as dist key & PK of this table. It may look similar with the state table of LocalAgg.


OwnerReference on applied resources

We should have an OwnerReference (to the GitSync) on any resources we apply, so that if the GitSync were deleted, then all of the resources would automatically be deleted as well.

As cross-namespace owner references are disallowed by design, we will not proceed this. Closed this issue for now.


[CARBONDATA-3117] Rearrange the projection list in the Scan

Rearrange the projection list in the Scan with respect to the requested projection columns from the query

[ ] Any interfaces changed?

[ ] Any backward compatibility impacted?

[ ] Document update required?

[x] Testing done
Existing UT

[ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.

Build Success with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder2.1/1462/

Build Success with Spark 2.3.1, Please check CI http://<IP_ADDRESS>:8080/job/carbondataprbuilder2.3/9720/

Build Success with Spark 2.2.1, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder1/1672/

Build Success with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder2.1/1496/

Build Success with Spark 2.3.1, Please check CI http://<IP_ADDRESS>:8080/job/carbondataprbuilder2.3/9753/

Build Success with Spark 2.2.1, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder1/1705/

LGTM


Memory leak using Node 0.10.28

Hello! I've been using node-formidable for a few years and I recently refactored my file upload script to work with Node 0.10.28. It's a basic uploader that handles users uploading 5GB+ files at a time, usually several users at once, over anywhere from 50mb/sec to 150kb/sec speeds. During testing, I kept finding that the script quickly ate up all available memory while uploads were taking place, then swap space, and then crashed. I couldn't track down what was causing it; I'm testing it on a VM with SSD-backed storage, so I didn't think there was any IO bottleneck. I downgraded node to 0.8.27 and now the memory issue is gone, which leads me to believe that something has changed with Node that formidable hasn't caught up on. I'm just wondering if this is happening with anyone else.

Memory leakage while uploading video file of size 30GB(node 0.8.27 ).

Closing as 0.10.31 is no longer supported. Feel free to re open if you can reproduce on a lts version


postSonarr.py - /var/log error

Getting the following error when running postSonarr.py, pretty sure i have the latest version of sickbeard_mp4_automator
[Error] postSonarr.py: Traceback (most recent call last):  [Error] postSonarr.py:   File "/sickbeard_mp4_automator/postSonarr.py", line 18, in <module>  [Error] postSonarr.py:     elif not os.isdir(logpath):  [Error] postSonarr.py: AttributeError: 'module' object has no attribute 'isdir'

Can confirm that works now with my Sonarr :) thanks for the speedy fix!

Great, thanks for confirmation


Update the README.md

Give the instructions of forking the repo, cloning, making changes, checkout, commit, push and create pull request

assign me this task


Updated fcrepo-java-client version and fcrepo4 version in integration…

I updates the fcrepo-java-client version and the version of fedora against which the integration tests run and fixed any errors resulting from those differences.  When merged, I'd like to create a new release and have the reporter of issue #48 determine if that issue still exists.

Builds 👍


Abi.values documentation contains obsolete TODO comment

See https://api.dart.dev/stable/2.18.7/dart-ffi/Abi/values-constant.html

The nearby comment about windows-arm64 is also stale: we build and upload an SDK for it now.

OK, I'll remove that as well.

Can this be closed now ?

Fixed in I737c17e06a346bba138133e78871a2919f8073ea


Comments not allowed inside of TYPE blocks

I'm not sure if this is a bug or an ER, but code like:
type location
	x               as int: ' the column
	y               as int: ' the row
end type

...generates the error:
ERROR: TYPE blocks can only contain field or method definitions
It fails for either ' or REM, and fails whether located at the beginning of the line, or after a ":"
Surely we want to be able to comment the fields and procedures in a TYPE, right?

Surely we want to be able to comment the fields and procedures in a TYPE, right?

Absolutely. I'll adjust the rules to allow REM within a TYPE block.

Does this look like something that might show up in a nightly build in the near future, or should I expect to wait until 3.1? Asking because I'm using UDTs in my current project & being able to comment things would help.

It is already in the main branch, please download the latest version. (tickets get automatically closed when the fix is merged into main)

Gotcha, thanks


Request for a 4bit quantization model for omnilmm 12B

I have tried the multi card inference but failed, it seems the layers are not dispatched correctly.
        with init_empty_weights():
            model = OmniLMMForCausalLM.from_pretrained(model_name, tune_clip=True, torch_dtype=torch.bfloat16)
        model = load_checkpoint_and_dispatch(model, model_name, dtype=torch.bfloat16,
                    device_map="balanced",  no_split_module_classes=['Eva','MistralDecoderLayer', 'ModuleList', 'Resampler']
        )

So it would be convenience to provide a quantization model for low memory cards, it may be nice if under 20GB single card or 40GB multi cards.

Also want a quantization for omnilmm-12b. BNB seems not to work.

We released the more powerful MiniCPM-Llama3-V 2.5 today，which has 8.5B parameters and much better performance， the int4 version is here.
Welcome to use.


Homepage: video tiles

Videos that aren't part of a series lose the 'play' icon. It would be good to keep this as this clearly denotes 'video'. Can we include this icon for non-series videos? Please refer to screenshot.
Videos tiles are currently unique in displaying tags outside of their containers. Can the container be expanded vertically (even if it's just an extension of the black gradient) to incorporate the tags?

Implemented, screenshot below. We've had to alter the gradient ever so slightly to create a seamless transition into the black, but I think it still looks good.

Feel free to close if satisfied.

@laramplus -- please review when you have a moment.

👍 this looks good @rdunk


[Cambio Estructural] Test Plan MVP 2017

Originally created by Luis Abdel Aguilar Jurado:

Originally created by Luis Abdel Aguilar Jurado:
EDUARDO ANTONIO DAVALOS CAMARENA de acuerdo a lo que platicamos esta tarea puede ser cerrada cierto?
Hazme saber si se requiere reabrir.

Originally created by EDUARDO ANTONIO DAVALOS CAMARENA:
Yo no la cerraría hasta subir los cambios

Originally created by Luis Abdel Aguilar Jurado:
Team Blue-Solo/cde-test con este issue le daremos seguimiento a las actividades relacionadas con la generación del Test Plan para el MVP 2017.

Originally created by Julian Cachua Fruchier:
David Test 1 - Request access to blue xolo
David Test 2 - Set user password
David Test 3 - Request password reset
(Complete Plan) Verify users have proper rights according to role.
Julian Test 4 - Create a profile template
Julian Test 5 - Create a stand profile based on previously created template
Julian Test 6 - Import OS Commands
Vic Test 7 - Create robot version and import Robot Library (Builtin)
Vic Test 8 - Create a Keyword on Library "A" with all possible elements and some of them nested - (Validate correct Robot translation)
Vic Test 9 - Create Custom keyword on Library "B" using the previously created one & optional and mandatory arguments - (Validate correct Robot translation)
Ari Test 10 - Create a Test Case using previously created custom keyword - (Validate correct Robot translation)
Ari Test 11 - Create Test Suite using previously created Test Case - (Validate correct Robot translation)
Ari Test 12 - Execute Test Suite, verify correct result.

Originally created by MONSERRAT ARIDAY BALDERAS ALBA:
David Test 1 - Request access to blue xolo

Click login
click request access
type email address
select product
click send request

David Test 2 - Set user password

click link
type password
confirm password
click change password

David Test 3 - Request password reset

click login
click I forgot my password
type email
click send me instructions
click back
check email
click link
type new password
confirm password
click change password

(Complete Plan) Verify users have proper rights according to role.
Julian Test 4 - Create a profile template
1) Click the Templates link in the main page

2) Click the lower right corner "+" link to create a new template

3) Create at least one variable of each available category.

4) Save the template.

5) Verify all variables are stored correctly

Julian Test 5 - Create a stand profile based on previously created template

Click the Profiles link in the main page
Click the lower right corner "+" link to create a new profile
Create a profiles selecting the previously created template.

Julian Test 6 - Import OS Commands
Vic Test 7 - Create robot version and import Robot Library (Builtin)

Click on "Libraries" from the sources section
Click on "+" located on the lower right corner
Fill the library name, library version and robot version
Add a valid library URL on the documentation URL box (http://robotframework.org/robotframework/latest/libraries/BuiltIn.html)
Click on create
Verity keywords from the html library are added correctly

Vic Test 8 - Create a Keyword on Library "A" with all possible elements and some of them nested - (Validate correct Robot translation)

Click on "Keywords" from the testing section
Write required fields (Collection, Name, Keyword description)
Drag and drop control flow sentences and commands to create the following keyword:
GPFS Test Set Prereqs
[Arguments]        ${Target}=@{CLUSTER_NODES}[0]    ${Mandatory}=Yes
[Documentation]    Execute the CompressDir file. It expects export mounted in client to succeed, if it   doesn't, execution will be marked as failed.
Log    Installing the necessary Packages on ${Target}    INFO
@{output}=    Native CLI mmlsfs    all    Target=${Target}
:FOR    ${fs}    IN    @{FSES}
\    Should Contain    @{output}[1]    ${fs}
:FOR    ${index}    IN RANGE    0    @{fs}
\    Log         ${index}
Validate Translation on TEXT
Click on save located on the lower right corner

Vic Test 9 - Create Custom keyword on Library "B" using the previously created one & optional and mandatory arguments - (Validate correct Robot translation)

Click on "Keywords" from the testing section
Write required fields (Collection, Name, Keyword description) -- Assigned to a different library than the one created on Test 8
Make sure Previous Created Keyword is available under the Command Search
Drag and drop the previous created Custom Keyword
Make sure Arguments and Default Values are correctly loaded from the Custom Keyword in the drop area
Create the following Keyword:
Object Config File Move From Tmp
[Arguments]
[Documentation]        Move from tmp location back to the original location of object configuration file so that cluster finds it
Native CLI UnixCommand    mv ${missingConfigFile}.tmp32687 ${missingConfigFile}
Validate Translation on TEXT
Click on save located on the lower right corner

Ari Test 10  - Execute previously created keyword
1 Under http://<IP_ADDRESS>:8002/testings/keywords/, pick the previous created keyword
2 Click on Run button
3 Choose a Profile
4 Click on Run
5 Click on Go Button to see execution
6 See latest execution and verify correct result.
Ari Test 11 - Create a Test Case using previously created custom keyword - (Validate correct Robot translation)
http://<IP_ADDRESS>:8002/testings/testcases/new/

Write the Required Fields Phase, Name, Description, Function

Validate correct  [Tags] Robot translation of Phase, Functions

Validate correct [Documentation] Robot translation of Description

Validate Name is correct Robot Test Case Name translation.

Drag and drop Tags, and tagging the test case

Drag and drop a variable

Nested in the previous variable, drag and drop a Keyword to assign the returned value

Validate spaces, and variable name and variable keyword returned value are inline

Drag and drop a list variable type

Nested in the previous list, drag and drop a Keyword to assign the returned value

Validate spaces, and list variable name and list values are inline

Drag and drop comments and validate every new comment line start with #

Drag and drop  :FOR and IN loop form, validate 4 spaces are used between loop variables, and the syntax of new lines within the FOR are preceded with  \

Drag and drop a :FOR IN RANGE loop form, validate 4 spaces are used between loop variables, and the syntax of new lines within the FOR are preceded with  \

Make sure Previous the 2 latest created custom keywords are available under the Command Search

Drag and drop the previous created Custom Keyword

Make sure Arguments and Default Values are correctly loaded from the Custom Keyword in the drop area

Drag and drop Run Keyword If keywords and drag and drop nested keywords

Select the Text Tab and validate correct Robot translation as follow for example:

Get Anonymous Userid
[Tags]    arch_os.all    regression    system.health
[Documentation]    get.os.info    anon_user    nfsnobody    nobody    anon_group    nogroup
@{out}=    Get OS Information    Target=@{PROTOCOL_SERVER_NODES}[0]
Run Keyword If    '@{out}[0]' == 'rhel'    Set Suite Variable    ${anon_user}    nfsnobody
Run Keyword If    '@{out}[0]' == 'rhel'    Set Suite Variable    ${anon_group}    nfsnobody
Run Keyword If    '@{out}[0]' == 'ubuntu'    Set Suite Variable     ${anon_user}    nobody
Run Keyword If    '@{out}[0]' == 'ubuntu'    Set Suite Variable     ${anon_group}    nogroup
Run Keyword If    '@{out}[0]' == 'sles'    Set Suite Variable     ${anon_user}    nobody
Run Keyword If    '@{out}[0]' == 'sles'    Set Suite Variable     ${anon_group}    nogroup
:FOR    ${node}    IN    @{CLUSTER_NODES}
\        @{machine_info}=    Get OS Information    Target=${node}
\        Run Keyword If    '@{machine_info}[0]' == 'rhel'    Connect And Execute     yum install -y nfs-utils perl-Thread-Queue perl-Digest-MD5 lsof psmisc   Target=${node}
${range}=    Get Length        ${NSD_FS}
:FOR    ${i}    IN RANGE   ${range}
\    ${index}=    Get Index From List    ${FSES}    @{NSD_FS}[${i}]
Variable Should Exist    ${anon_user}

Ari Test 12 - Create Test Suite using previously created Test Case - (Validate correct Robot translation)
http://<IP_ADDRESS>:8002/testings/testsuites/new/

Assign name and description to the test suite

Use Settings,  set comments, import resources, Suite Setup, Define Variables, Define Keywords and Import Test Cases. eg:

*** Settings ***
Documentation            This test suite is for get a cluster health status
Include more keywords to suite setup and teardown if needed. By default, Log Cluster Status
which provices cluster information is the only keywords included by default in Suite setup
and teardown.
Suite Setup       Run Keywords    Object Config File Move From Tmp
*** Variables ***
Add any variables (that are not contained in the profile) needed for the test suite.
${client_hostname}           martell1
*** Test Cases ***
Get Anonymous Userid

Originally created by Luis Abdel Aguilar Jurado:
MONSERRAT ARIDAY BALDERAS ALBA Julian Cachua Fruchier
viendo los casos de prueba veo que pudiéramos hacer un match de estos casos de prueba con los los issues seleccionados para ser arreglados para el MVP 2017.
Es posible hacer el match y estar seguros de que todos los issues reportados anteriormente fueron arreglados?


CORE-5120: Restructure of HTTP RPC test utilities

Move TestHttpClient and FakeSecurityManager into http-rpc-test-common.
Functionality-wise this change is NOP.

LGTM. So do you think at some point we'll be looking at converting HttpsClient in workers-smoketest to use the TestHttpClient now that it is in a common module?

For now I plan to create an OSGi-enabled test that starts HTTP Server with all the PluggableRpcOps we have and then access this server using TestHttpClient. Hence, I wanted it in http-rpc-test-common module to be accessible.


Update all dependencies https://github.com/serlo/frontend-e2e-tests

switch to yarn

switch to yarn

one or three?

yarn 3


FetchContent_Populate broken on Windows with latest build

CMake configure fails with repeated attempts of
-- Build files have been written to: ...
-- Configuring done (0.1s)
-- Generating done (0.0s)

eventually culminating in something similar to the below:
CMake Error at toolchain/v18/win32-x86_64/cmake/share/cmake-3.28/Modules/FetchContent.cmake:1679 (message):
  Build step for <removed> failed: 1
Call Stack (most recent call first):
  toolchain/v18/win32-x86_64/cmake/share/cmake-3.28/Modules/FetchContent.cmake:1703 (__FetchContent_directPopulate)
  CMakeLists.txt:85 (FetchContent_Populate)

CMake version 3.31 seem to have fixed this, since it doesn't crop up with my other local version of CMake

I plan to make new CMake releases shortly, but it might take some time to get to 3.31.

Looks like it's an upstream issue with CMake due to a combination of path length and the way that our tooling system is calling it: https://gitlab.kitware.com/cmake/cmake/-/issues/25936
I'll close this issue as unrelated to the tooling. Thanks!


feat(icons): add new icons

Description
Implement two new icons: columns and handle-2-vertical
Screenshots

Before
After

Testing in sage-lib

Navigate to http://localhost:4000/pages/foundations/icon
Verify icons are present and no other icons are missing
Navigate to http://localhost:4100/?path=/story/sage-icon--default
Verify icons are present and no other icons are missing

Testing in kajabi-products

(LOW) New icons in sage-lib; no testing in kajabi-products necessary

Related
Closes #1021

@monkeypox8 - could catch. Correcting the capitalization has no impact on the output of the icons and I will relay this back to Design!


Cannot read property 'exclude' of undefined at applyDefaults

Bug Report or Feature Request (mark with an x)
ERROR in ./src/main.ts
Module build failed: TypeError: Cannot read property 'exclude' of undefined
    at applyDefaults (/home/daffodil-201/Desktop/backup/beverage-ecommerce-maintenance/node_modules/awesome-typescript-loader/src/instance.ts:266:72)
    at Object.ensureInstance (/home/daffodil-201/Desktop/backup/beverage-ecommerce-maintenance/node_modules/awesome-typescript-loader/src/instance.ts:145:5)
    at compiler (/home/daffodil-201/Desktop/backup/beverage-ecommerce-maintenance/node_modules/awesome-typescript-loader/src/index.ts:37:20)
    at Object.loader (/home/daffodil-201/Desktop/backup/beverage-ecommerce-maintenance/node_modules/awesome-typescript-loader/src/index.ts:18:18)
 @ multi main

Issue
Hello,
I'm using angular cli and I updated my app to angular4 using "npm install @angular/{common,compiler,compiler-cli,core,forms,http,platform-browser,platform-browser-dynamic,platform-server,router,animations}@latest typescript@latest --save "
**
Versions.

Angular version: 2.0.X
Browser:Chrome
Language:TypeScript
Node (for AoT issues): node --version = 6.10.1
Repro steps.
when I run my app after updation I'm getting the following problem. I run my app using npm start and ng serve both.

The log given by the failure.

Module build failed: TypeError: Cannot read property 'exclude' of undefined
Desired functionality.

simply it have to compile but error occur during compilation.
Mention any other details that might be useful.

Experiencing the same issue on windows.
Trying to update to Angular 4.
It was compiling fine on angular2 until I added
npm install @angular/common@latest @angular/compiler@latest @angular/compiler-cli@latest @angular/core@latest @angular/forms@latest @angular/http@latest @angular/platform-browser@latest @angular/platform-browser-dynamic@latest @angular/platform-server@latest @angular/router@latest @angular/animations@latest typescript@latest --save
Exact same error
ERROR in ./src/main.ts Module build failed: TypeError: Cannot read property 'exclude' of undefined     at applyDefaults (C:\Users\user\Documents\test\final\node_modules\awesome-typescript-loader\src\instance.ts:266:72)     at Object.ensureInstance (C:\Users\user\Documents\test\final\node_modules\awesome-typescript-loader\src\instance.ts:145:5)     at compiler (C:\Users\user\Documents\test\final\node_modules\awesome-typescript-loader\src\index.ts:37:20)     at Object.loader (C:\Users\user\Documents\test\final\node_modules\awesome-typescript-loader\src\index.ts:18:18)  @ multi main

Hi newnewb,
Few days ago I was facing the issue but when I downgrade my project from angular 4.0.1 to 4.0.0 now my app is working properly.
delete your node module and downgrade the angular dependency in 4.0.0 same as image and then run npm install.. hope it will work for you...

Hi @saurabhschauhan ,
I think as I read it was a typescript issue, anything below 2.1.x will lead to that error,
deleted my node modules, and updated the typescript version and angular version in my packages
"@angular/common": "^4.0.2",
"@angular/compiler": "^4.0.2",
"@angular/compiler-cli": "^4.0.2",
"@angular/core": "^4.0.2",
"@angular/forms": "^4.0.2",
"@angular/http": "^4.0.2",
"@angular/platform-browser": "^4.0.2",
"@angular/platform-browser-dynamic": "^4.0.2",
"@angular/platform-server": "^4.0.2",
"@angular/router": "^4.0.2",

 "typescript": "^2.2.2",
this solved the issue for me

Heya, I don't think the issue you are experiencing is related to Angular CLI. I see references to awesome-typescript-loader in your error logs, you should open an issue in that repo instead.


Use a platform agnostic switch

Only fix required for this to work flawlessly on MacOS.

Love your surgical change :wink:


Create break_a_palindrome.cpp

@mayanjain
Your PR has been successfully merged Thank you so much for your valuable contribution. Do give a follow if it helped you and star the repo and check other repo too for more contribution. Keep hacking


Do not use setsid directly, use dedicated start_new_session

Just ran into
https://stackoverflow.com/questions/42257512/difference-between-subprocess-popen-preexec-fn-and-start-new-session-in-python which points to python docs at
https://docs.python.org/3.4/library/subprocess.html?highlight=subprocess#popen-constructor
Warning The preexec_fn parameter is not safe to use in the presence
of threads in your application. The child process could deadlock before
exec is called. If you must use it, keep it trivial! Minimize the number of
libraries you call into.

Note If you need to modify the environment for the child use the env
parameter rather than doing it in a preexec_fn. The start_new_session
parameter can take the place of a previously common use of preexec_fn to
call os.setsid() in the child.

So smells like we better use this dedicated option added in 3.2 .
But may be it was considered and argued against @asmacdo and doesn't work as desired
(there is a separate discussion on possibly using group not session ids in https://github.com/con/duct/issues/82)

I don't think this was considered, looks like an improvement to me. I'm curious if start_new_session is actually slower, or if its just random flake.
I started that requirement as tight as possible, opting to relaxed that requirement only as needed, which I've done in latest push.


Distinguish between Start and Stop

Currently, the Button seams to change between start and stop, regardless of the state of actual toggl state.
If I start a timer by pressing a button on the deck, button turns red and tracking begins.  So far so good...
But if I start a timer by deck and stop it by toogl app or online, the button stays red #12 and the next press will start a new timer, while the buttons turn black again. Timer and deck are out of sync.

Obviously it's working... Didn't for me in the first testing. I'll be watching this.
Anyways... Great Work!


[FEAT]: API Key foreach workspace instead unique for platform

What would you like to see?
Hello,
might it make sense to have the ability to set an API_KEY (of OpenAI but also mistral etc in case) at the workspace level instead of the whole platform?
So for example you can better differentiate what costs one workspace had over another.
Currently instead you can set a unique api key in LLM Preference that all workspaces will use.
What do you think is the time frame for implementing this small change?

Or it would be very convenient to be able to set variables at the workspace level to be able to integrate with LangSmith and keep track of processed tokens, timing, cost, etc.
I did a quick test on another project and all I had to do was put these three variables in the .env file:
LANGCHAIN_TRACING_V2=true
LANGCHAIN_API_KEY="ls__xxx"
LANGCHAIN_PROJECT="xxx"
Here is the docs:
https://docs.smith.langchain.com/tracing


Fixing the axom include

This fixes the axom package finding function to use the new exported cmake target.

LGTM

LGTM


Interfacing  with Dask

Hi @SBentley , would you be interested in adding a functionality to interface this repository with Dask ? We can work on this

Hello, I'm currently facing issues when trying to handle large data files. While I don't have any experience with Dask, I guess a more straightforward solution might involve introducing a "chunksize" parameter similar to the one used in pandas, allowing the processing of larger files in smaller pieces.

Would you like to work on this together ?

Hi @ss756 , I managed to fork the main branch and started working in the solution I mentioned. I introduced a new function named fetch_rows that takes as parameter the number of lines to be loaded:
https://github.com/hugotallys/qvd-utils/blob/e4d089a9cf3e33c8e71a16fd359d3ba025e49bed/src/lib.rs#L38
In the python wrapper ( qvd_reader.py file ) the function can be called as :
def read(file_name):
    reader = QvdReader(file_name)
    data = reader.fetch_rows(10)
    data = reader.fetch_rows(5)
    df = pd.DataFrame.from_dict(data)
    return df

I am still adjusting the implementation as it only fetches the first N rows from qvd files (at each call of fetch_data the file is opened and reads the same lines). If you're interested in improving the solution for this issue we can work over the fork as collaborators.


StatefulSets error: .status.availableReplicas: field not declared in schema

Describe the bug
When updating our flux installations to v0.25.x we experience failures in the kustomizations for StatefulSets, namely for the field ".status.availableReplicas" which was added in Kubernetes v1.22.
Warning  error   11s                kustomize-controller  StatefulSet/monitoring/alertmanager dry-run failed, error: failed to create typed patch object: .status.availableReplicas: field not declared in schema

Steps to reproduce

Use Kubernetes v1.21
Install flux v0.24.x
Rollout a kustomization with a StatefulSet
Update to flux v0.25.x
Check error in kustomization

Expected behavior
The kustomization should not fail or flux should notify users of dropped support for Kubernetes < v1.22
Screenshots and recordings
No response
OS / Distro
N/A
Flux version
v0.25.1
Flux check
► checking prerequisites
✔ Kubernetes 1.21.2-eks-0389ca3 >=1.19.0-0
► checking controllers
✔ helm-controller: deployment ready
► ghcr.io/fluxcd/helm-controller:v0.15.0
✔ image-automation-controller: deployment ready
► ghcr.io/fluxcd/image-automation-controller:v0.19.0
✔ image-reflector-controller: deployment ready
► ghcr.io/fluxcd/image-reflector-controller:v0.15.0
✔ kustomize-controller: deployment ready
► ghcr.io/fluxcd/kustomize-controller:v0.19.0
✔ notification-controller: deployment ready
► ghcr.io/fluxcd/notification-controller:v0.20.1
✔ source-controller: deployment ready
► ghcr.io/fluxcd/source-controller:v0.20.1
✔ all checks passed
Git provider
No response
Container Registry provider
No response
Additional context
No response
Code of Conduct

[X] I agree to follow this project's Code of Conduct

@mycrEEpy can you please test #533 and let me know if this fixes the issue for you?

Thank you for confirming, going to release this fix today.


Survivor Jobs and Presets

About the PR

Draft for additional Survivor types and roles, Myself and Ammoniacres are working on this
I have mapped in the Custom Built Shotgun into Solaris ETA, alongside placing three M890 shotguns across Fiorina
Relevant Issues:
https://github.com/RMC-14/RMC-14/issues/627
https://github.com/RMC-14/RMC-14/issues/628
https://github.com/RMC-14/RMC-14/issues/626
Base TODO

[x] Medical
[x] Engineer
[x] Security
[x] Hostile

Why / Balance

Parity (Certain liberties will be taken with content that doesn't directly translate)
This is basically a direct buff for survivors overall, such as letting survs reliably heal and making getting hugged not an instant death sentence. An additional system gives survivors a flavour briefing on spawn to help incentivise RP
Hostile survivors have been given inherently disadvantaged spawnpoints on most maps and are wearing an easily identifiable cloak that if they take off will forfeit their right to attack under Rules of Engagement
Technical details

Media

Requirements

[x] I have read and am following the Pull Request and Changelog Guidelines.
[ ] I have added media to this PR or it does not require an ingame showcase.

Breaking changes

Changelog

:cl:

add: Added Medical, Engineer, Security and Hostile Survivors
add: Survivor Loadouts have a wider range of contents
add: The Custom Built Shotgun has been mapped into Solaris ETA
add: The M890 Tactical Shotgun has been mapped into Fiorina

#625


How to determine the quantity of various kinds of random mutations in a genomic simulation?

Hi，
I am quite puzzled about how to appropriately set the number of different types of mutations when simulating a human cancer genome.
Could you provide me with some guidance on this matter?
Thanks a lot!

Hi there, this is a tricky question that depends on lots of things.

simuG is designed for simulating germline variants in general,  which means it will not introduce variants with different  somatic allelic frequencies during its simulation. You can of course let simuG to simulate a bunch of different versions of  mutated genomes and then further simulate reads from these genomes to create a mosaic reads dataset to resemble cancer genomes. That being said,  there should be some other more specific cancer genome simulators that can give you a more realistic simulation for somatic mutations. You can take a look.
Both the number and spectrum of somatic mutations in cancer genomes can vary a lot across different cancer types. So my guess is to extract the mutation burden and spectrum information from the real cancer genome data to guide your simulation.

Best,
Jia-Xing

First and foremost, I greatly appreciate your reply.
My research goal is to simulate a cancer genome derived from the human reference genome by individually simulating the paternal and maternal genomes, subsequently simulating reads based on these genomes, and finally combining the reads from both parental genomes into a single final fastq file.
I am wondering whether it is viable to use simuG for this purpose, considering that simuG includes features for simulating a variety of mutation types such as SNPs, INDELs, CNVs, INVERSIONS (INV), and TRANSLOCATIONS (TRA), all of which are integral aspects of simulating cancer genomes.
Thank you once again for your help.

Hi @DayTimeMouse ,
I see. Yes, simuG can definitely do what you need. Just find a cancer genome sequencing paper for the specific types of cancer that you want to cover and plug in those estimated numbers of SNV, CNV and SV count per sample will be fine. We have a paper on NKTCL that with these numbers reported coming out soon. If you are interested in. I will post a link to the paper when it come out in early-mid April.
One thing to keep in mind that there could be significant intratumor genomic heterogeneity across different cancer cells. And what we usually sequenced for real cancer genomes is a bulk of such heterogeneous cancer cell populations. I don't know the bigger scientific question of your study in which this simulation analysis is involved, but you might want to introduce or at least discuss the noise generated by such intercellular genomic heterogeneity when you want to compare your simulated data with real cancer sequencing data.
Best,
Jia-Xing

Yes, I am very interested in your related work and look forward to you posting the link in the future, I will follow it.
Finally, I wish you all the best!

Hi @DayTimeMouse ,
Here is the link to our paper with per-sample variant number estimated for SNVs, CNVs, and SVs:
https://genomemedicine.biomedcentral.com/articles/10.1186/s13073-024-01324-5
Best,
Jia-Xing

Hi @yjx1217,
Thank you so much, I learned a lot from this paper.
Warm Regards.

Hi @yjx1217,
I used pbsv(https://github.com/PacificBiosciences/pbsv) to call SVs, then DUPLICATION is called.
I want to ask how to set duplication varaints via simuG. Is there any difference between CNV and DUPLICATION setup?
The introduction of DUPLICATION is bellow:

Hi @ DayTimeMouse ,
Thanks for the email. You can consider CNV as a consequence of segmental/tandem insertion + deletion + duplication + contraction.
So you can use simuG to introduce CNV in general, which will include some cases of duplication. If you only want to simulate duplication, you can still use simuG' s CNV simulation function with specialized settings for the following parameters:

-cnv_gain_loss_ratio
            Specify the relative ratio of DNA again over DNA loss. Default =
            1.0. Example: -cnv_gain_loss_ratio 1.0. For copy number gain
            only, set '-cnv_gain_loss Inf'. For copy number loss only, set
            '-cnv_gain_loss_ratio 0'.

    -cnv_max_copy_number
            Specify the maximal copy number for CNV. Default = 10. Example:
            -cnv_max_copy_number 10.

    -cnv_min_size
            Specify the minimal size (in basepair) for CNV variants. Default
            = 100. Example: -cnv_min_size 100.

    -cnv_max_size
            Specify the maximal size (in basepair) for CNV variants. Default
            = 100000. Example: -cnv_max_size 100.

    -duplication_tandem_dispersed_ratio
            Specify the expect frequency ratio between tandem duplication
            and dispersed duplication for CNV variants. Default = 1.
            Example: -duplication_tandem_dispersed_ratio 1. For simulating
            tandem duplication only, set
            '-duplication_tandem_dispersed_ratio Inf'. For simulating
            dispersed duplication only, set
            '-duplication_tandem_dispersed_ratio 0'.

Best,
Jia-Xing


$ObjMap allows for incorrect typing sometimes

When using $ObjMap, I'm able to write a function that converts from a type to another but at runtime compiles to (basically) the identity function:
(Flow try link)
const changer = <A, B>(input: A): B => {
  return ({input}: $ObjMap<{input: A}, (a: A) => B>).input
};

(changer((1: number)): string);

I don't think I've introduced any any types through things like Object or Function`, but with this I'm able to cast arbitrary types by wrapping in an intermediate object.
I have another problem, which is that I'm trying to write a configurable HOC that takes in an object with a shape and puts props with a specific type according to the shape. Here's an example in Flow (with some implementation stubbed out as any):
(Flow try link)
import React from 'react';
type MapOf<T> = {[key: string]: T};
type Config = MapOf<number>;
type Transform<T> = $ObjMap<T, () => string>;

type HOC<C: Config, Props: Transform<C>> = (
  (component: ReactClass<Props>) => ReactClass<$Diff<Props, Transform<C>>>
);

const f = <C: Config, P: Object>(config: C): HOC<C, P> => (null: any);

class Base extends React.Component {
  props: {
    foo: boolean,
  }
}

f({foo: 1})(Base)

In this example, given a configuration of {foo: 1}, I want to enforce that the component passed in (Base) must prop types of at least {foo: string}.
With this example, I expect flow check to fail because Base has type ReactClass<{foo: boolean}> which is incompatible with expected ReactClass<{foo: string}>. Is there a better way to express this?
Thanks,
Dan

Here's another example of how $ObjMap can produce seemingly incorrect results:
(Flow try link)
type A = {|a: number|};
type Mapped = $ObjMap<A, () => string>;
({a: true, b: true}: Mapped)

I'd expect the last line in this to fail for two reasons:

a property should have type string
b property is invalid in Mapped

@danwang As of Flow 55, the simple example above is now working. There is a type error for a being a boolean instead of a string. And although the default type for $ObjMap is a non-exact object, you can ask for an exact object to also get a type error on the b key:
type A = {|a: number|};
type Mapped = $Exact<$ObjMap<A, () => string>>;
({a: true, b: true}: Mapped)

This now errors


Web: extension API does not work on Web

Does this issue occur when all extensions are disabled?: Yes/No

VS Code Version:
OS Version:

According to the docs I am expecting vscode.extensions.getExtension('vscode.git') to work on web as "web extensions still have access to the full VS Code API".  I am getting an error saying Git extension is not loaded instead. For context, I am trying to get git info of the currently opened file on vscode.dev / github.dev.
Steps to Reproduce:

Add vscode.extensions.getExtension('vscode.git') & "extensionDependencies": ["vscode.git"] to web extension
Run Web Extension
Receive following error:

Cannot activate the 'test' extension because it depends on the 'Git' extension, which is not loaded. Would you like to reload the window to load the extension?

@AgentofSpyral
The builtin extension vscode.git executes only on a nodejs extension host. The reason is because the builtin vscode.git extension needs to spawn git.exe and that is possible only on the nodejs extension host.
Extension dependencies are fulfiled across extensions only when extensions execute on the same extension host.
So if your extension has a dependency on the vscode.git extension, your extension cannot run on the web worker extension host, since the vscode.git extension runs only on the nodejs extension host.
You can, however relax your dependency into an optional dependency. To do so, you no longer need to declare "extensionDependencies": ["vscode.git"] in your package.json and, at runtime, simply probe the presence of vscode.git on the same extension host using vscode.extensions.getExtension('vscode.git'). If that returns undefined, it means vscode.git is either not running at all or running on a different extension host. If that returns a real object, it means that vscode.git is running on the same extension host as your extension.

@alexdima Thanks for the explanation Alex that was really helpful.
In this case, what would be the recommended way to get the name of the branch of the currently opened file on VS Code Web? Is there a VS Code Web API for that?

In this case, what would be the recommended way to get the name of the branch of the currently opened file on VS Code Web? Is there a VS Code Web API for that?

Do you mean at vscode.dev / github.dev or when running locally? When running locally you can probe for vscode.git and use it when available.

Sorry for the confusion, I was referring to when running on vscode.dev / github.dev

That is a good question, I also don't know. cc @joaomoreno @joyceerhl for insights.

Do these two do what you want?

If you're looking for the branch name specifically, that is always tracked in the branch picker status bar item in the bottom left

@joyceerhl Since I won't be able to run vscode.extensions.getExtension('vscode.git') in my extension on vscode.dev / github.dev I don't think this would work for me. Is there an API where I can retrieve the branch name from the branch picker status bar?

@AgentofSpyral there's currently no api for this. cc @lszomoru who owns the git-base extension that is web-enabled

@AgentofSpyral, as stated by @joyceerhl, at the moment there is no mechanism for an extension to get the git repository details on the web but this is something that we are looking into in the near future.

@lszomoru @joyceerhl @alexdima Thank you for the help! I will file a feature request for this instead.


[BUG] Slew Rate Limiter too high

Describe the bug
The Slew Rate Limiter is too high
Expected behavior
Robot accelerates too slowly

Fixed in merge #11


chore: fix amplify-app related e2e execution

Description of changes:

Fix amplify-app related e2e setup in circle ci to fix the previous file permission issues
Increase timeout and remove extra async statement from amplify-app e2e test
Standardize task names in circle ci

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

lgtm!

Codecov Report

Merging #3482 into master will increase coverage by 0.06%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #3482      +/-   ##
==========================================
+ Coverage    59.6%   59.67%   +0.06%
==========================================
  Files         285      280       -5
  Lines       13159    13144      -15
  Branches     2642     2644       +2
==========================================
  Hits         7844     7844
+ Misses       4892     4876      -16
- Partials      423      424       +1

Impacted Files
Coverage Δ

...ckages/amplify-util-mock/src/utils/cleanup-task.ts

...l-mock/src/CFNParser/resource-processors/lambda.ts

...plify-util-mock/src/__e2e__/utils/cognito-utils.ts

...plify-util-mock/src/api/run-graphql-transformer.ts

...kages/amplify-util-mock/src/__e2e__/utils/index.ts

packages/amplify-util-mock/src/storage/index.ts

...plify-util-mock/src/__e2e__/utils/lambda-helper.ts

...es/amplify-util-mock/src/api/resolver-overrides.ts
0% <0%> (ø)

...kages/amplify-util-mock/src/utils/lambda/invoke.ts
0% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fa01991...68542ae. Read the comment docs.


Data models in Hugo similar to Jekyll and Mixture

Greetings,
Can't say enough good things about Hugo. Many thanks for all the work on it.
I've yet only fiddled with Hugo but am currently considering it as my primary static site generator. Before doing so, I'm wondering about one core feature: data models. Essentially, is it possible to store and loop through objects stored in JSON/YAML files within views?
Two existing examples of such a feature can be seen here with Jekyll and here with Mixture.

See also Pull Request #748, Feature: GetJson and GetJson in short codes or other layout files by @SchumacherFM

For docs, see
https://github.com/spf13/hugo/blob/master/docs/content/extras/datafiles.md


Supporting pre-releases on pypi

Is your feature request related to a problem? Please describe.
It is currently very complex to develop against the new API from master.
A clear and concise description of what you want to happen.
It would be better to also support some kind of pre-release to not need a direct install of the source code from master. It definitely makes development and automated testing easier without keeping eyes on commit shas.

We are going to release v0.15 soon, in about 2 weeks.

@lepture Early-access to pre-release builds sounds like exactly the kind of feature companies might want to pay for as part of a commercial plan.

Hey there. Any update on this? Would like to continue with a conversion to authlib, but waiting on v0.15 before that can continue :)

Bump :)

v0.15 is released.

Awesome, thanks guys :+1:


[FEATURE REQUEST] Web site: dark mode support

It would really be welcome dark mode support at https://go.dev/doc.

Duplicate of #34601


feat: LinearOrder α extends Ord α

This PR makes LinearOrder lawfully extend Ord.
Since LinearOrder has decidable order relations, we take compare to be compareOfLessAndEq by default for a linear order.
Since typeclass synthesis is preferred by structure instances to optparams, this does not create non-defeq diamonds for types which already have a different implementation of Ord.
We also add a field compare_eq_compareOfLessAndEq which encodes the lawful quality by demanding equality to the canonical comparison.
Motivation: Array functions like min largely use Ord, so this lets us seamlessly use these array functions when we only have a linear order.
See zulip.

https://github.com/leanprover/std4/pull/74/files looks related here.
We should probaby add a LinearOrder.toOrientedCmp instance and similar in the meantime.

bors d+

Given that it's been reviewed, I'll merge this PR as-is. If we want to refactor some lemmas after all, let's do so after leanprover/std4#74 lands—I'll be happy to make that PR if desired.
bors r+


Add NUMBA_CACHE_OVERRIDE to force caching on or off

This adds a NUMBA_CACHE_OVERRIDE environment variable which is read into the config.CACHE_OVERRIDE setting. If set to always, then the compilation decorators ignore the cache= parameter and always enable caching. If set to never, then the decorators ignore the cache= parameter and always disable caching.
This closes #4549 where this variable and values were first suggested.
Note that I have added the override behavior to numba.cuda.jit but I currently don't have a CUDA setup to test this with. I assume the CI pipelines will take care of this -- if there is anything else I need to do to enable testing with CUDA, please let me know.

gpuci run tests


Add InterfaceFilter to AgentConfig

This callback can be used to exclude interfaces from gathering.
Relates to pion/webrtc#843

Codecov Report

Merging #105 into master will increase coverage by 0.25%.
The diff coverage is 100%.

@@            Coverage Diff            @@
##           master    #105      +/-   ##
=========================================
+ Coverage   77.35%   77.6%   +0.25%
=========================================
  Files          23      23
  Lines        1837    1840       +3
=========================================
+ Hits         1421    1428       +7
+ Misses        292     289       -3
+ Partials      124     123       -1

Impacted Files
Coverage Δ

agent.go
78.24% <100%> (+0.68%)
:arrow_up:

gather.go
65.5% <100%> (+0.21%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 867a355...ab7b3e3. Read the comment docs.


notification event not fired for remote notifications when app fresh open (not on background)

Report

[x] I have searched existing issues and this is not a duplicate.

Environment

Platforms: iOS

iOS version: 13.5

Issues and Steps to Reproduce

Register for notifications and fully close the app.
You will still get notifications but when you click on them your app will open but 'notification' event won't fire.

Expected Behavior
-'notification' event should be fire.
Actual Behavior
-You received a notification with the app fully closed (not in background) and it will take you to your app main screen and won't execute any custom logic you had put on your listener for 'notification' event.
Link to Code
  // notification: Fired when a remote notification is received. This won't work
  IOSNotificationHub.addEventListener('notification', this._handlerRemoteNotification);

 // notification: Fired when app is fresh opened from remote notification. This is a current workaround you can use, call getInitialNotification on your app initial load and check whether there is a notification.
    IOSNotificationHub.getInitialNotification().then(notification => notification && this._handlerRemoteNotification(notification));

did you installed this package @react-native-community/push-notification-ios  or this react-native-push-notification ?
because this issue #159

Yes I had installed @react-native-community/push-notification-ios in the past, but by the time I got this error I didn't have it on my dependencies anymore.

I am also having the same issue as notification event not fired for remote notifications when app fresh open (not on background) also I am unable to fetch the payload from notification but couldn't do so. I tried putting debugger on the AppDelegate.m code for notification even and surprising it doesn't go on that point if notification is received on background and opened.

I am currently facing exactly the same issue on iOS only. The eventlistener on notification is not fired from a clean boot. Only when the app is running in the background the event is fired for me on iOS. How can I get the initial notification?

Any update on this?
We have an existing app that used to get the notification event fired on ios when in the foreground which doesn't seem to be triggered anymore. I wonder if it's possible that IOS changed the notification behaviour?


Burgir

Halal?

No!!!

Hello

Iam from england, America

My president is Michal jordan

Chicken nugggeeeeeees

Nuggeeeeeees Chicken

@TESAFACEborgir what you mean?


Tscene management/feature/#86bwv9ynu/create panel

Every component have only 1 delete option.
Right click button on inspector works with open and close header.
There cannot be 2 identical components in a gameobject.

Task linked: CU-86bwv9ynu Create Panel


fixed bad reference in doc

Description
This PR fixes a bad document example that was using a deprecated value when accessing documents.
Related Issues
Issue 3714
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

[X] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[X] If the pull request affects only one plugin, the PR title starts with the name of the plugin in brackets (e.g. [cloud_firestore])
[X] My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
[X] All existing and new tests are passing.
[X] I updated/added relevant documentation (doc comments with ///).
[X] The analyzer (flutter analyze) does not report any problems on my PR.
[X] I read and followed the Flutter Style Guide.
[X] I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
[X] I updated CHANGELOG.md to add a description of the change.
[X] I signed the CLA.
[X] I am willing to follow-up on review comments in a timely manner.

Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?

[ ] Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
[X] No, this is not a breaking change.

@googlebot I signed it!

@googlebot I signed it!

@googlebot I fixed it.

Thanks for this, this has already been fixed in a previous PR so I'm going to go ahead and close this.


suggestion

hello dear
please consider these value in search setting:
packets = 1-1
length = 1-3
interval = 5-10
packets =1-1 chunk only first packet which is enough to hide SNI
tlshello mode is a bit different and it seems filtered in some region
another suggestion is to ping multiple time and drop first one because first ping is not accurate
in fragmentation , first packet chunks intentionally delayed to bypass filtering cause large ping in first attempt
but it doesn't affect subsequent data transfer.

hello dear please consider these value in search setting: packets = 1-1 length = 1-3 interval = 5-10
packets =1-1 chunk only first packet which is enough to hide SNI tlshello mode is a bit different and it seems filtered in some region
another suggestion is to ping multiple time and drop first one because first ping is not accurate in fragmentation , first packet chunks intentionally delayed to bypass filtering cause large ping in first attempt but it doesn't affect subsequent data transfer.

Thanks! Will do the first one, it's good to know. Second suggestion will be harder to implement as multiple pings might
undesirably increase run time on invalid fragments, but I will try


2.3.0 broke tablename loading

Just updated and my full application, working previously, broke down on setting the model due to the update (https://github.com/mitsuhiko/flask-sqlalchemy/pull/541). I believe it might be a problem with this new primary key detection thing, which I'm not sure I get the point of. The previously-fine code is thus:
from flask import Flask
from flask_sqlalchemy import SQLAlchemy

app = Flask(__name__)
db = SQLAlchemy(app)
db.reflect()

class Country(db.Model):
    __tablename__ = 'd_country'

Resulting in:
InvalidRequestError: Class <class 'app.models.Country'> does not have a __table__ or __tablename__ specified and does not inherit from an existing table-mapped class.
I'd be willing to bet that the update didn't take db.reflect() into account. I'm rolling back unless there's something else I can do, but I'd rather not have to do a declared_attr on all my tables just for this thing.

You need to specify a primary key column for all models that do not inherit from another mapped model.

Reopening because it would be good to fix which error gets raised. Will look into this.

It does have a primary key which gets loaded in during the reflect process. This worked fine before.

The code you've shown creates a model with no primary key. Make sure your example code reflects the problem you're describing.

No...it does. Look:
$ ipy
In [1]: from flask import Flask
   ...: from flask_sqlalchemy import SQLAlchemy
   ...:
   ...: app = Flask(__name__)
   ...:
   ...: db = SQLAlchemy(app)
   ...: db.reflect()
   ...:
   ...: from app import models as m
In [2]: m.Country.__table__
Out[2]: Table('d_country', MetaData(bind=None), Column('code', CHAR(length=2), table=<d_country>, primary_key=True, nullable=False), Column('name', VARCHAR(length=99), table=<d_country>), schema=None)

This is in v2.2. 2.3 prevents me from loading with the exact same code.

Do you get any warnings from SQLAlchemy? In your real code, are you doing anything with that model besides setting a tablename?

I have a feeling this was just an accident due to other bad behavior in 2.2, and you actually need to inherit from the reflected model and/or use extend_existing.

The error is thrown at the time it is loaded with that exact code up there. Here's the full thing.
$ ipy
In [1]: from flask import Flask
   ...: from flask_sqlalchemy import SQLAlchemy
   ...:
   ...: app = Flask(__name__)
   ...:
   ...: db = SQLAlchemy(app)
   ...: db.reflect()
   ...:
   ...: from app import models as m
   ...:
---------------------------------------------------------------------------
InvalidRequestError                       Traceback (most recent call last)
<ipython-input-1-745089669a6c> in <module>()
     11 db.reflect()
     12
---> 13 from app import models as m

[snip]/app/__init__.py in <module>()
    153
    154
--> 155 from app import views

[snip]/app/views.py in <module>()
      1 from app import app, db
----> 2 from app.models import *
      3 from sqlalchemy import func

[snip]/app/models.py in <module>()
     16
     17
---> 18 class Country(db.Model):
     19     __tablename__ = 'd_country'
     20

/usr/local/lib/python2.7/dist-packages/flask_sqlalchemy/model.pyc in __init__(cls, name, bases, d)
     64             cls.__tablename__ = camel_to_snake_case(cls.__name__)
     65
---> 66         super(NameMetaMixin, cls).__init__(name, bases, d)
     67
     68     def __table_cls__(cls, *args, **kwargs):

/usr/local/lib/python2.7/dist-packages/flask_sqlalchemy/model.pyc in __init__(cls, name, bases, d)
     91         )
     92
---> 93         super(BindMetaMixin, cls).__init__(name, bases, d)
     94
     95         if bind_key is not None and hasattr(cls, '__table__'):

/usr/local/lib/python2.7/dist-packages/sqlalchemy/ext/declarative/api.pyc in __init__(cls, classname, bases, dict_)
     62     def __init__(cls, classname, bases, dict_):
     63         if '_decl_class_registry' not in cls.__dict__:
---> 64             _as_declarative(cls, classname, cls.__dict__)
     65         type.__init__(cls, classname, bases, dict_)
     66

/usr/local/lib/python2.7/dist-packages/sqlalchemy/ext/declarative/base.pyc in _as_declarative(cls, classname, dict_)
     86         return
     87
---> 88     _MapperConfig.setup_mapping(cls, classname, dict_)
     89
     90

/usr/local/lib/python2.7/dist-packages/sqlalchemy/ext/declarative/base.pyc in setup_mapping(cls, cls_, classname, dict_)
    101         else:
    102             cfg_cls = _MapperConfig
--> 103         cfg_cls(cls_, classname, dict_)
    104
    105     def __init__(self, cls_, classname, dict_):

/usr/local/lib/python2.7/dist-packages/sqlalchemy/ext/declarative/base.pyc in __init__(self, cls_, classname, dict_)
    131         self._setup_table()
    132
--> 133         self._setup_inheritance()
    134
    135         self._early_mapping()

/usr/local/lib/python2.7/dist-packages/sqlalchemy/ext/declarative/base.pyc in _setup_inheritance(self)
    428                 "Class %r does not have a __table__ or __tablename__ "
    429                 "specified and does not inherit from an existing "
--> 430                 "table-mapped class." % cls
    431             )
    432         elif self.inherits:

InvalidRequestError: Class <class 'app.models.Country'> does not have a __table__ or __tablename__ specified and does not inherit from an existing table-mapped class.

Besides the little snips for privacy, it's exactly the same code that just worked in 2.2. I don't have time to do anything with the model because I can't load it in.

I believe I am inheriting properly by loading db from app, then using class X(db.Model). All joins and everything, which would rely on the keys, work properly.

You are not. db.Model is the base model class, not a real model. Your intention appears to be to get the reflected model, creating a new class with the same table name is not how you do that.

So I guess I'm not sure why this worked with zero issues before in a fairly complex setup. Are you saying it was a bug of a bug that made it work? If so I feel like that behavior makes sense. What should I be doing instead besides that relatively straightforward-seeming approach?

Does this work in plain SQLAlchemy or Flask-SQLAlchemy 2.1?

OK, this does work in plain SQLAlchemy. Probably need to account for it in __table_cls__.
import sqlalchemy as sa
from sqlalchemy import orm
from sqlalchemy.ext.declarative import declarative_base

engine = sa.create_engine('postgresql:///example', echo=True)

Base = declarative_base()
Base.metadata.reflect(engine)

class User(Base):
    __tablename__ = 'user'

session = orm.Session(engine)
print(session.query(User).all())

2.1 also works fine. For the sqlalchemy:
from sqlalchemy import create_engine, MetaData
from sqlalchemy.ext.declarative import declarative_base

engine = [xxxxx]
Base = declarative_base(bind=engine)
Base.metadata.reflect()

class X(Base):
    __tablename__ = 'd_country'

X.__mapper__.primary_key[0].name
Out[9]: 'code'

Oh, you beat me to it. Are you saying I need to account for it or just that it does in F-SA?

Fixed in #551. Will be released soon, want to look into one other issue first.

You need to specify a primary key column for all models that do not inherit from another mapped model. This is true in normal SQLAlchemy too, the error messages are just switched due to some internal behavior.

I know this is an old issue, but I've searched high and low trying to find a flask-sqlalchemy reflect example that actually works.
Could you point me to a working example (using an app factory)? Much appreciated.


Syntax error

[16:07:36] gulp-notify: [Compile Error] ./bower_components/Uploadcare/uploadcare.js: 'with' in strict mode (4079:116) while parsing file: ./bower_components/Uploadcare/uploadcare.js

@homm ?

@Meekohi Could you explain more precisely, when you are seeing this message? By the way, the "with" statement is indeed used in the widget. But not in "strict mode".

This must be an error on my end then. I am seeing this when using gulp to compile a bunch of JS down into a single file (the majority of which is in strict mode), so I'm guessing someone else's "strict mode" is getting included. I'll take a closer look.


Accomodating oauth2client moves of GCE/App Engine modules.

FYI @tseaver I didn't realize the App Engine import was busted. I am once and for all going to push that stuff upstream into oauth2client and hopefully we can get a 2.0.1 release there.

LGTM


Edit Location Text on Local Source Videos - (Default is File Name)

I am running several local video files as part of my Aerial screen saver rotation. I notice that when running, the location display shown on the screen appears to be the file name of the video file, i.e., Downtown Manhattan.mp4. While I don't have a problem with "Downtown Manhattan", I want to drop the .MP4 from the display and can't seem to do it by simply renaming the file without the extention, as then the file will not be recognized by the program as a video file. A review of the control panel options for the screen saver does not seem to provide an option to control this display. Similarly, opening the existing Aerial screen saver videos with video editing tools (i.e., Subler) does not appear to reveal any customizable meta data options. Does anyone have any thoughts or tips?
Thanks!
BJ

Hey @BJ-57
So yeah I should definitely remove the file extension when defaulting back to this option, that's on me, that should be an easy change.
In the meantime, if you don't mind editing some files, you can get the result you want today.
Open Aerial Settings, go to Advanced, scroll down, press "Show log in finder"
This will open a Finder window where Aerial cache is. There will be a folder in here with the name you  gave your source (the folder you have added). Inside you'll find a entries.json that lists all your files.
You can edit that file to add your own description (and even descriptions showing up at specific time in the video) following what is explained here : https://github.com/AerialScreensaver/AerialCommunity/blob/master/CreatingASource.md#video-manifest-format-entriesjson
What you want is to add this part :
"pointsOfInterest" : {
      "0" : "Something interesting about your video happening at 0 seconds"
    }


NEW LAB REQUEST: Conversational Bot

Please add a new lab showing how to build a conversational bot that works multi-tenant
Probably using Bot Framework SDK and LUIS

Moved to new repo


vector: 0.37.0 → 0.37.1

Description of changes

https://vector.dev/releases/0.37.1/
https://github.com/vectordotdev/vector/releases/tag/v0.37.1

Things done

Built on platform(s)

[X] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[X] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[X] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Thank you !


Fix InfoBox on Mac

On Chrome and Firefox in Windows, window.getComputedStyle works on any node and returns null for non-element nodes.  Under the same browsers on OS X, getComputedStyle throws for non-element ndoes, leading to test failures and a crash in the Cesium WMS picking demo.
This change simply verifies that the first child is indeed an element before calling getComputedStyle.
Fixes #2545 and #2553, both OS X only

Apparently Chrome just pushed out version 41 and master now fails there as well.

Apparently Chrome just pushed out version 41 and master now fails there as well.

Do you mean this same failure happens on Windows now?

Looks good.

Do you mean this same failure happens on Windows now?

Yes, but my fix is good for all of them.


[Automation] Generate SDK based on TypeSpec 0.13.4

[Automation] Generate SDK based on TypeSpec 0.13.4

API change check
API changes are not detected in this pull request.

/azp run java - openai

/check-enforcer override

Ignore the CI. Just tried to run codegen, but it won't work on azure-sdk org.


k8s 1.27 & 1.28 chart support checklist

This issue is to implement the chart changes & perform the testing required to upgrade to k8s 1.27. Please perform below steps.

[x]  Check whether the chart has any references to the below deprecated features of k8s 1.27 & 1.28 You can find information about deprecated APIs here on Kubernetes Deprecation guide.storage.k8s.io/v1beta1 API version of CSIStorageCapacity
[x]  Update kube-version annotation in Chart.yaml. catalog.cattle.io/kube-version: '>= 1.23.0-0 < 1.28.0-0'
Note: If this is an upstream chart and if the upstream chart doesn't support k8s 1.27 then do not update the kube-version annotation

[x] kubewarden-crds
[x] kubewarden-controller
[x] kubewarden-defaults
[x] kubewarden-ui:
https://github.com/kubewarden/ui/pull/393
https://github.com/kubewarden/kubewarden-ui/pull/441
[x] kubewarden-ui-extension: submission of kubewarden-ui to https://github.com/rancher/ui-plugin-charts

[x]  Perform below tests

Fresh install/uninstall/upgrade/downgrade of the charts on K8s 1.27 provisioned on Rancher. Test the chart functionality.
(Please refer to the [Feature] k8s 1.26 support - apps and feature charts  #41395 to know what testing was done for k8s 1.26 upgrade for your chart)
Provision rancher on k8s 1.26 or lesser
Install chart on this cluster
Upgrade this cluster in rancher to k8s 1.27
Make sure the existing chart and the app is functional after cluster upgrade

Kubewarden related:

SDK:

[ ] Go: Generate Kubernetes Go types for new k8s version.
[x] Rust Bump k8s-openapi consumption of feature v1_2X if needed . Then, propagate consumption of kubewarden/policy-rust-sdk (bots normally do this).

[x] Policies:

deprecated-versions-policy : Check automation created a new PR that updates the database file that holds the list of all the deprecation. Merge the PR and tag a release with suffix -k8svX.Y.Z.

[x] Consider if it's needed to bump rancher-kubectl-builder. (kubectl can communicate with 1 minor release of difference upwards or downwards):
https://github.com/kubewarden/rancher-kubectl-builder/pull/16
https://github.com/kubewarden/rancher-kubectl-builder/pull/19

This can't be tested yet, rancher 2.7.5-rc5 does not support 1.27 clusters.

Moving to blocked then.

After the edit and expansion of acceptance criteria to k8s 1.28, we are going through the checklist again.

Is this tested with k8s 1.27, which we are targeting for rancher 2.8 release. Please note that we deferred k8s 1.28 upgrade to Q1 2024.

@kravciak can it be tested now?

Apologies, @kravciak, I misread the issue. @gunamata, as @kravciak mentions, he can't the tests, since k8s 1.27 isn't available in the latest Rancher install (2.7.8-rc1). Please advise on how to proceed. Thanks

Kubewarden UI 1.2.1 does not work on rancher v2.8.0-alpha2, should we extend checklist with UI items? @jordojordo ^

Kubewarden UI 1.2.1 does not work on rancher v2.8.0-alpha2, should we extend checklist with more UI items? @jordojordo ^

Could it be because it expects the helm charts to declare support for 2.8? See https://github.com/kubewarden/helm-charts/pull/328, in main but unreleased.

Could it be because it expects the helm charts to declare support for 2.8? See kubewarden/helm-charts#328, in main but unreleased.

Yes, I confirmed with Jordon it should be fixed by this - I will retry when it's released. Thanks :)

@kravciak , As kubewarden/helm-charts#328 seems to be merged now, Are you able to test this? cc: @jhmarina

@kravciak , As kubewarden/helm-charts#328 seems to be merged now, Are you able to test this? cc: @jhmarina

We are releasing new chart with rancher 2.8 support, I will test after it's out - probably it should be done this week.

@jordojordo UI won't redirect me to kubewarden installation page:
rancher v2.8.0-rc1
kubewarden: 2.0.0
kubewarden-ui: 1.3.0-rc1
cluster: k3d v1.26.9+k3s1

Kubernetes v1.27.6-k3s1
Hi, I tried with kubernetes v1.27.6-k3s1, everything works the same as described above - I was able to create policy server manually, create some policies, it seems kubewarden backend works. As for the UI there are problems related to rancher 2.8.0-rc1, not kubernetes.
Since issues were caused by rancher 2.8.0, not kubernetes 1.27 I think this is done from testing side..
Kubernetes v1.28.2+k3s1
Rancher 2.8.0 does add support for kubernetes 1.28. Rancher can't be deployed on 1.28 and I can't create 1.28 clusters from rancher. Issue description mentions only 1.27 in Perform below tests section.
# Install rancher v2.8.0-rc1
Error: chart requires kubeVersion: < 1.28.0-0 which is incompatible with Kubernetes v1.28.2+k3s1

Recap:

Kubernetes 1.28 is supported by the Kubewarden stack, also our SDKs have been updated to reflect that
There are some issues with Rancher manager and Kubernetes 1.28, but these are being worked by Rancher team. The Kubewarden UI will work on Kubernetes 1.28 starting from the its next release


[3.x] Code refactoring

This is the first set of automatic upgrades.
The idea is to do this gradually as otherwise there may be too many conflicts + we can now check what changes were introduced before we up the level in case of issues.

Hey @ifox,
I looked over this and I do not find any specific issues. I want to merge this so it gets tested automatically during further development.
Then, maybe each week we can improve on it. Next refactorings to be "typings"
What do you think?


chore(main): release 1.26.1

:robot: I have created a release beep boop
1.26.1 (2023-09-29)
Bug Fixes

add start, end newlines to config (5c4ea58)
use complete instead of error spinner for no vidoes available (2bc7417)

This PR was generated with Release Please. See documentation.

:robot: Release is at https://github.com/aidanaden/canvas-sync/releases/tag/v1.26.1 :sunflower:


Mining dynamite explodes in water near land

Minecraft version & Mod Version:
Minecraft 1.12, Cyclic 1.7.7
Single player or Server:
Single player
Describe problem (what you were doing / what happened):
When throwing mining dynamite into water very close to land, it will often explode as if it hit land, rather than doing nothing like it does when landing in the middle of water.
Crash log (if any): N/A

Changed them to not explode in water https://minecraft.curseforge.com/projects/cyclic/files/2465120

I think this went a bit far. They used to "boom" in water but, except for this bug, not break stuff, and now they don't even "boom" anymore.


Include -Werror in build to ensure cleaner code and easier jvm upgrade infuture

as recommended during talk https://www.eclipsecon.org/sites/default/files/slides/migrateearly_theresa.pdf

verified with master branch


Logged attributes ordering by key length

I am not sure of it's this package which is doing this, but if it is, is it possible to allow the natural order to follow through from the order they are defined in the request?

Hey, @wrabit I'm sorry but I have no idea what you refer to?
Do you mean the order of the logged attributes in the JSON column? Right now we don't do any special sorting. We only call Laravel core methods to retrieve the attributes.

Yes, the order in the JSON column, ok thanks for confirming, I'll look a bit further.
This is how it's storing:


LXD commissioning data differs when run in a container vs metal

MAAS 2.7 uses the LXD commissioning data. During testing we have noticed that this information differs between when commissioning data is gather with LXD on bare metal vs in an LXD container. The information isn't just different it is sometimes wrong which is causing issues with MAAS

Blocksize is being detected as 0(LP:1848822). We worked around this by assuming 0 means 512 but we really should be getting the correct data
CDROM is being detected as a read/write SCSI device(LP:1850671). This results in MAAS thinking the CDROM is available for use as a normal drive. Another weird thing about this is LXD is saying the size is<PHONE_NUMBER> when there is no CD/DVD in the drive.
The firmware version of block devices and interfaces is missing.
The serial of block devices is missing
The ports field on interfaces is missing when run in an LXD container. This means MAAS can't gather whether a an interface is connect nor the interface or link speed it is connected at.

container.txt
metal.txt

Unfortunately nothing we can do about that. Containers don't have access to the raw block devices, so this data cannot be retrieved making it all unset.

The size thing needs fixing, will look into that one. Sounds like we're not properly handling a -1 or something.

Could this information be added to the socket in the container at /dev/lxd/sock? This way the information would be gathered on hardware and we wouldn't see any differences.

No, this would be information leakage across privilege boundary

(Our work on containers is actually towards the other way around, we'd like to have /sys not show those devices at all unless they've been passed through by the user, but filtering /sys to that extent has been so far too costly and so hasn't been done)


Enter key in the search pattern should perform the search.

Enter key in the search pattern should perform the search. No need to force customers to use the mouse to click "Apply" button or tab several times to reach the button.

@SeanFeldman, good suggestion. Thank you!

This works now in a new update of the portal this week. After inputting key filter, the enter key will trigger the Apply.


Oxfordshire localisation: Paying offline / outside of transaction

This page is not consistent with how Oxfordshire will be delivering their service.

The council will not be contacting users for payment, they will be emailing an invoice and a link to pay online. (This is because of technical constraints and will be changed in the future.)
The council can not show the cost at this stage. The page should also explain that the cost needs to be calculated and will be included in the invoice that is emailed to them.

@lizziebruce Could you suggest revised content for this page?

Payment summary
When we’ve processed and approved your application, we’ll email you an invoice with a link to pay online.
You will be invoiced for:
[show all rows except cost]
We’ll calculate the cost of your permit. The invoice we send you will show the amount you need to pay.
NEXT

Question: will the emailed invoice also include option to pay by phone/post?

No, it won't (I don't think). @abibarkeroxfordshire can confirm.

@artgov ^^ Above content should display on /pre-payment if councilString == 'oxfordshire'.

@sanjaypoyzer @lizziebruce Hi - thanks for this it all sounds good. Customers can pay by phone but we don't advertise it as an option - if a customer has an email address we email an invoice, if they don't provide one they we will call them (very few customers do not have an email address).

@abibarkeroxfordshire – Ok sure, there may be accessibility reasons why paying over the phone might be needed by some users, but that's something we should find out when we take a closer look at the payment solution in testing.


Add titlebars to panes

Summary of the Pull Request
This pull request adds titlebars to panes. Below are a few features / changes:

The pane's title can be changed by double-click or by a context menu when right clicking on the titlebar.
The tab's title reflects the active pane's title, not the control's title.
The pane titlebar's background color can be changed using the "tabColor" setting only right now.
If no "tabColor" is chosen, the default is ChromeDisabledHigh.
The pane's foreground color is dynamically changed depending on the brightness of its background.

References
This pull request should close #7290 and provides #7075 with a solution.

PR Checklist

[X] Closes #7290
[X] CLA signed. If not, go over here and sign the CLA
[ ] Tests added/passed
[ ] Documentation updated. If checked, please file a pull request on our docs repo and link it here: #xxx
[X] Schema updated.
[X] I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #7290

Detailed Description of the Pull Request / Additional comments
Current Issues with this PR

A crash occurs when closing a pane child and then attempting to edit the pane title. I am looking for some guidance here, as I could not figure out the root cause of the issue. Inside the _CloseChild method, if I don't release _firstChild or _secondChild, it works (however creating a memory leak).
Currently, setting the tab's background color with the color picker does not update the pane titlebar color.
Code Quality – I am sure there are better ways of doing some of the things in this PR (new to the codebase and C++ isn't my primary language). I would be more than happy to make edits based on feedback received.

Future Thoughts:

Add support for changing the pane titlebar background/foreground colors, font/font-size, etc. directly. This was discussed here: https://github.com/microsoft/terminal/issues/7290#issuecomment-674887400
Add support for changing the pane titlebar background/foreground colors to indicate if a pane is active. My thoughts on that start here: https://github.com/microsoft/terminal/issues/7290#issuecomment-678266263

Validation Steps Performed

Set showPaneTitlebar to true if not already.
Double-Click the title or use the context-menu by right-clicking the titlebar to edit the title.
Confirm by pressing enter or clicking away from textbox. Press escape to cancel the edit.

For those curious for a preview:

Note that my ubuntu profile has acrylic pretty agressively enabled. What is important:

the pane's title color reflects the control "tab color" (or title color).
The tab reflects the focused pane's "title color" and "title text". So selecting the "foo" pane changes the tab text to "foo", and the tab color to purple, while selecting the "cmd" pane changes the tab color to the default black, and the tab text to "cmd".
this looks awesome with focus mode:

Maybe the default pane titlebar color should be the same as the focused tab item background? That might lead to more consistency with the UX when a pane has a title color

re:

Currently, setting the tab's background color with the color picker does not update the pane titlebar color.

I think that's fine. Currently, the order of precedence is [tab runtime color, control title color, theme color (unimplemented), default color]. So I could imagine this going two ways:

convert the "tab runtime color" to be a "pane runtime color". Then, using the color picker on the tab would set the active pane's runtime color. This comes with the detrimental side effect that you'd have to re-color each pane in a tab manually.
add an additional "pane runtime color", and have the tab's color be composed from [tab runtime color, pane color (which is itself [pane runtime color, control title color, theme pane title color]), theme color, default]. This would allow panes to have their color changed at runtime with a color picker, and also have the tab have a manual color override.

I'm of course just hypothesizing here in the comments - I don't think any of this is something that needs to get done in this PR. We can always loop back on the issue in a follow-up.

So, here's a quick update. I fixed some of the comments above, however,  the issue regarding a crash after a child pane is closed still exists and I have not been able to find a fix in my free time. This maybe held it by #3999?

Just wanted to get this back into the spotlight in case it got lost in the pile of other feature requests / issues. I know you showed some interested in this feature @DHowett, so would you mind also taking a look at some of the code here and maybe provide some insight. I didn't want to bother @zadjii-msft since he is out. Let me know what you think!

As much as I want this feature done as quickly as possible, I would rather us do the harder work up front so additions to the Pane titlebar and Pane itself are easier. In this case I agree that this PR should blocked until there is a better solution like you provided. I would be up for helping rework some of it, but I have been busy recently.

In this case I agree that this PR should be blocked until there is a better solution like you provided. I would be up for helping rework some of it, but I have been busy recently.

I'll close this for now, but not as a rejection. This is a sound idea that we'll revisit when we can support it best :smile:
Thanks so much for doing the lifting here.


Add feature to strip HTML comments

Hi,
it would be very nice to have something like "{% stripcomments %}..." to strip all static HTML comments from templates.
{% stripcomments %}

<link rel="shortcut icon" href="assets/img/favicons/favicon.png">
{% endstripcomments %}

would become
<link rel="shortcut icon" href="assets/img/favicons/favicon.png">

I'm skeptical about the feature, because it may complicate both implementation and semantics of quicktemplate without significant benefit.
stripcomments feature instantly opens the following questions:

Should the HTML comment be stripped if it contains quicktemplate tags?

{% stripcomments %}

foobar
{% endstripcomments %}

How to handle IE-specific conditional comments?

{% stripcomments %}
Show or hide?

{% endstripcomments %}

What if HTML comment is generated via quicktemplate tags?

{% stripcomments %}
{%s "" %}
{% stripcomments %}

I'd suggest using quicktemplate-specific {% comment %} tag instead of HTML comments. See also the issue #1 for more options.

My motivation comes from 3rd party templates. e.g. I buy templates on themeforest. they have a lot of comments and for development I would like to keep some of those comments.
I understand that this feature would increase complexity and I saw no easy way to implement it myself, thats why I asked.
A workaround for me is to use plain html for design phase and strip comments before converting to quicktemplate. the regexp from #1 is no solutions for me.
But let me answer your questions:

quicktemplate tags inside comments
Strip everything. If someone wants to generate comments he can't use stripcomments around that code.

IE conditional comments:

{% stripcomments %}
Show or hide?
{% endstripcomments %}

Or just start using stripcomments after your conditional comments.

comments generated by quicktemplate tagsI think it depends on the implementation. Keep it simple. Maybe your example is possible. Or like above you have  to use stripcomments after that code


[WIP] Only close stream when the we reached end of the stream

While working on https://github.com/reactphp/event-loop/pull/112 I ran into an issue with suddenly closed streams. Traced the issue down to '' coming from streams when using the ext-uv loop. Adding this check before closing the stream resolved the issue for ext-uv.
Todo:

[ ] Close stream only when reached EOF
[ ] Tests

Relates to https://github.com/reactphp/event-loop/pull/112

Please note that this PR doesn't contain actual code change at the moment. I'll create tests first and commit them before committing the fix to show tests work appropriately.

Ping @jsor @clue let me know if this is 👍 or 👎 . I'll squash and merge on a 👍 .


Updated tf.svd documentation to state " u * s * v' "

Updated tf.svd documentation to state the index for V matrix is transposed.

Can one of the admins verify this patch?

resolve #13298

You change is not correct. V stores the singular vectors as stated. It is correct that A \approx U \Sigma V^H. Notice that this convention is unlike some other SVD libraries that return V^H.
https://cs.corp.google.com/piper///depot/google3/third_party/tensorflow/python/kernel_tests/svd_op_test.py?rcl=171836140&l=120

Also as stated in
https://www.tensorflow.org/api_docs/python/tf/svd
tensor[..., :, :] = u[..., :, :] * diag(s[..., :, :]) * transpose(v[..., :, :])
We should perhaps update that to
tensor[..., :, :] = u[..., :, :] * diag(s[..., :, :]) * transpose(conj(v[..., :, :]))
(although we currently only support complex SVD on CPU)

Can one of the admins verify this patch?

@donigian if you are up for changing the documentation as stated above, it would be helpful. Thanks!

What's needed is a fix to "compatibility" section of the docs, there a difference in order and transposition from numpy result, whereas docs only mentions order difference
@compatibility(numpy)
  Mostly equivalent to numpy.linalg.svd, except that the order of output
  arguments here is `s`, `u`, `v` when `compute_uv` is `True`, as opposed to
  `u`, `s`, `v` for numpy.linalg.svd.
  @end_compatibility

oops @rmlarsen please see revised edits from what I was able to gather.

@yaroslavvb the numpy api is just wrong :-)

@yaroslavvb the numpy api is just "wrong", as explained in the notes:
https://docs.scipy.org/doc/numpy-1.13.0/reference/generated/numpy.linalg.svd.html
"The SVD is commonly written as a = U S V.H. The v returned by this function is V.H and u = U."

Closing for lack of activity, and it seems @rmlarsen is the expert who knows how this could be clarified properly.

FYI. I'll update the docstring internally. Should be pushed out in a day or two. Thanks for bringing up the issue @donigian and @yaroslavvb