spinel-cli: Clean exit

Leverage ot-ncp signal handling improvements to terminate ncp test processes cleanly rather than using CTRL+C.

Current coverage is 65.53% (diff: 100%)

Merging #4 into master will decrease coverage by <.01%

@@             master         #4   diff @@
==========================================
  Files            90         90
  Lines         12362      12362
  Methods        1714       1714
  Messages          0          0
  Branches       1437       1437
==========================================
- Hits           8102       8101     -1
  Misses         3833       3833
- Partials        427        428     +1

Powered by Codecov. Last update 6d2dfa5...9b1201a


question about on csi-monitor

dear
   I have uesed atheros to receive the csi .Now I want to realtime-processing for csi.Your sourse is helpful to me. I want to ask the question about the csi-monitor.I do it as the introduction.When I make install ,it says a mistake.
     Is it necessary to be in a folder(opt/)?

The installation directory points to /opt folder, but you can change the makefile and .service file to point to another place if you want.


DS-1349: Add configuration to hide submitter in item history (JSPUI).

https://jira.duraspace.org/browse/DS-1349

This PR is currently untested. I developed and tested it before the Service Based API came in. As versioning is currently broken, I was unable to test my rebase yet.

This PR contains DSPR#1089 as it was impossible to create this PR without it. As soon as DSPR#1089 I'm going to rebase this again. Everything else is done, PR is ready for review again.

Rebased to resolve merge conflict.

While this looks like it'd "work" for JSPUI, it has the feel of something that we might think about pushing down lower in the API "stack".  Ideally, if this config was disabled, the submitter info would not even be provided to the UI layer. This would ensure that it didn't get displayed to JSPUI or XMLUI or even REST (or other integration points).
Fixing it at the JSPUI is nice. But, ideally we'd find a way to resolve this lower in the stack.

@tdonohue while I see your point, we need this information for logged in administrators, so we have to pass it to the UI anyway.

@pnbecker I don't think that changes anything about the concern - your authorization should be recognized below the API layer.

@helix84 The problem is, that your request requires a complete change of how the version history table in JSPUI works. This would require a massive change. Also would it result in a version history table that works completely different compared to other parts of the UI regarding the point how data is served.
We have a concrete issue. In the past we resolved issues of that kind in the UI. That can be considered being bad design, but that is one of the reasons we're currently discussing a complete change of the UI. For now, I don't think that it is reasonable to change this here.

I agree that we really should be making access decisions much further down the stack, but I also agree that the necessary changes would be much too far-ranging and disruptive to be done this close to release.  I reluctantly support a strategy of "make it work now, and make it right later."
What I would like to see, some day, is that all access decisions are made by the content objects or their services.  Callers would receive refusal of a request for access to a single forbidden item, and on aggregate requests would receive only the items permitted them.  This requires that objects and their services be told who is asking, and for what purpose.  The former information is carried in the Context.  How we will convey the latter, I do not yet know.  It will require a large expansion of the set of access request types.

I'm OK with letting this go in for now. Ideally, longer term, we need to find a way to do this at a lower level, so that the flag can be turned on/off for all access points (UIs or REST or whatever) at once.

Merging this as discussed in today's developer meeting.


Running sample

I am trying to run
edglessrt go sample
Getting error while running OE_SIMULATION=1 erthost enclave.signed
root@d1cc01526652:/com.docker.devenvironments.code/edgelessrt/samples/go/build# OE_SIMULATION=1 erthost enclave.signed
[erthost] running in simulation mode
[erthost] loading enclave ...
 Are you running this on an emulation layer? In our experience, edgelessrt requires real x64 hardware, even in simulation mode. (E.g., it won't run on Rosetta.)


allow JSON to be loaded into loadAnnotations

Allowing a JSON to also be a parameter to loadAnnotations instead of the URL for the annotation.

To set a JSON object directly, you can use the setAnnotations method.
(My intention behind the API design was to separate the sync/async loading methods I guess. I still sort of like it. But happy to hear alternative views :-)

@rsimon I figured that out and it worked for my application which is why I closed the issue. It was already there :).


[MGDOBR-289] Allow manager pipeline to access repository secrets

MGDOBR-289
The pull request must then be marked with the safe to test label
Please make sure that your PR meets the following requirements:

[x] Your code is properly formatted according to this configuration
[x] Your commit messages are clear and reference the JIRA issue e.g: "[MGDOBR-1] - $clear_explanation_of_what_you_did"
[x] All new functionality is tested
[x] Pull Request title is properly formatted: MGDOBR-XYZ Subject
[x] Pull Request contains link to the JIRA issue
[x] Pull Request contains link to any dependent or related Pull Request
[x] Pull Request contains description of the issue
[x] Pull Request does not include fixes for issues other than the main ticket

@r00ta Can we update our documentation about the need to apply the safe to test label in order for the build to run.

Hi @robpblake , I've added a point in the pull request template

Cheers!


Dzhus/provider update

please address this code smell
https://sonarcloud.io/project/issues?id=ita-social-projects-oos-backend&open=AXj-f4o01nk9lrkwtCEV&pullRequest=110&resolved=false&types=CODE_SMELL


RN-38 Clicking on an at mention should open user profile

Summary
This PR adds the ability to navigate to a users profile by pressing on a user mention.
Ticket Link
https://mattermost.atlassian.net/browse/RN-38
Device Information
This PR was tested on:
iPhone 6 iOS 10
iPhone 7 iOS 10
Galaxy s7 - Android 6.0 API 23
@jarredwitt

Thanks @stanchan for the pull request!
Per the CONTRIBUTING.md file displayed when you created this pull request, we need to add you to the list of approved contributors for the Mattermost project.
Please help complete the Mattermost contribution license agreement?
This is a standard procedure for many open source projects. Your form should be processed within 24 hours and reviewers for your pull request will be able to proceed.
Please let us know if you have any questions.
We are very happy to have you join our growing community! If you're not yet a member, please consider joining our Contributors community channel to meet other contributors and discuss new opportunities with the core team.


Fastlane Pilot able to define "What to test?" metadata?

Does Pilot support the inclusion of a "What to test?" section that you can fill in the Connect Portal to tell testers what to look for in the uploaded build?

@jvanlint You can set "What to Test" by setting the changelog when calling pilot. The naming convention is a bit confusing because Apple has changed the name of this field recently (and we should probably add a new alias to the changelog parameter to indicate it sets "What to Test"!)
So, you can do this (from the command line):
fastlane pilot distribute --changelog "What to test goes here"

Or from your Fastfile:
pilot(changelog: "What to test goes here")

I hope this is helpful, please let us know if you have any other questions about fastlane!  🚀

Cheers. Very helpful.


Sentinel Golang Version V1 Discussions

Describe what feature you want
Implement Golang version of Sentinel, including basic statistic and flow functions. Some expected features:

Basic statistic structure (sliding window that can achieve high concurrency and accuracy)
Rate limiting (based on token bucket algorithm, maybe we can leverage golang.org/x/time/rate.Limiter)
Logging
Metrics interface that can pump real-time metrics to outside consumer
Embedded API server
Integrate with Sentinel dashboard (machine discovery)

Discussions are welcomed!

I really need it.I have finished a golang project on internet,but not have Limiting ,Downgrade...   And i have read sentinel source code(java version and cpp),and write a little.Chain of responsibility have been finished,but Slot interface is not very sure,sliding window have been finished.My project is already running in production,i really need sentinel-golang
.I am a new golanger.Old driver brought me.

@helloworldyuhaiyang Contributions are welcomed! Maybe we could discuss the structure and design first.
@louyuting Any progress on this? :)

Is there a real-time communication tool,WeChat ,Dingding,Telegram,Twitter.I can do this this week,and need performance

Is there a real-time communication tool,WeChat ,Dingding,Telegram,Twitter.I can do this this week,and need performance

We can discuss the design in this issue directly (so that the discussion could be public for all developers). And you could also join the Dingtalk group of Sentinel: 21977771

@louyuting @sczyh30
Can the slot of the responsibility chain are composed of the following interface.
type Slot interface {
/**
* Entrance of this slots.
*/
Entry(context core.Context, resourceWrapper core.ResourceWrapper, param interface{}, count int, prioritized bool, args ...interface{}) (core.TokenResult, error)
Exit(context core.Context, resourceWrapper core.ResourceWrapper, count int, args ...interface{}) (core.TokenResult, error)

// 传递进入
FireEntry(context core.Context, resourceWrapper core.ResourceWrapper, param interface{}, count int, prioritized bool, args ...interface{}) (core.TokenResult, error)

// 传递退出
FireExit(context core.Context, resourceWrapper core.ResourceWrapper, count int, args ...interface{}) (core.TokenResult, error)

GetNext() Slot

SetNext(next Slot)

}
type TokenResult struct {
status int
blockReason string
waitMs uint64
}

I am also interested in this project, look forward to joining.

Recently,I have implement a test version to be tested. The repo is louyuting/sentinel-golang  forked from sentinel-group/sentinel-golang. The test version haven't to do unit test and integration test. If you are interested in this, welcome to improve together.

Recently,I have implement a test version to be tested. The repo is louyuting/sentinel-golang forked from sentinel-group/sentinel-golang. The test version haven't to do unit test and integration test. If you are interested in this, welcome to improve together.

ok. i will contribute code to your repository.

is there a road map or some interface definition? i implement the ratelimiter once refer to the java version,find that some concept or interface is suitable for the golang version.

is there a road map or some interface definition? i implement the ratelimiter once refer to the java version,find that some concept or interface is suitable for the golang version.

Recently, we were discussing architectural design of golang version. And you could also join the Dingtalk group of Sentinel: 21977771

is there a road map or some interface definition? i implement the ratelimiter once refer to the java version,find that some concept or interface is suitable for the golang version.

Recently, we were discussing architectural design of golang version. And you could also join the Dingtalk group of Sentinel: 21977771

yeah，i already in the Dingtalk from last year,but i din't receive from any discus about the go version,or maybe i miss it,expect to join the discuss

yeah，i already in the Dingtalk from last year,but i din't receive from any discus about the go version,or maybe i miss it,expect to join the discuss

@atuowgo 群里 at 一下 宿何，我把你拉到 Golang 的讨论群里

any update?

under discussing.

m

Sentinel Golang 0.1.0 has been released, so closing this umbrella issue. Thanks for all the contributors!
The introduction of Sentinel Golang v1 (CN): https://sentinelguard.io/zh-cn/blog/sentinel-golang-v1-go-go-go.html


merge-conflict: Add compare {current,incoming} to original

I use 3-way merge conflict checking, where I can see all of the current changes, the original code, and the incoming changes. My workflow for resolving conflicts is to compare the original code to the current and then, separately, to the incoming changes. I can then figure out which changes are easier to port (say, reflect the original-to-incoming changes in the current code), and then actually port the changes. A critical step here is to be able to compare the original version against the updated versions.
VSCode's merge-conflict support allows me to easily compare the current code against the incoming code, but that's not nearly as actionable as comparing against the original code. Is it possible to add a feature where, in a 3-way conflict, I can compare current and incoming against original?
Useful prior art: emacs's smerge-mode allows the smerge-refine command, which cycles through the 3 possible comparisons (original/current, original/incoming, current/incoming).

Looks like duplicate of #37350

Thanks, @IllusionMH, but I don't think so. I feel like I must be missing something, but it looks like #37350 is essentially a side-by-side representation of the diff3 conflict style that git provides. This side-by-side representation is really useful, but I'm looking for something more: word-by-word (or char-by-char) highlights of what actually changed. Let me demonstrate.
This is the rendering of a 3-way merge in VSCode today.

With merge-conflict.compare, I can get this:

Note that orig is highlighted, along with the fact that EQ1 and EQ2 are different. These highlights are so, so useful. But this comparison is between the current and incoming versions. I want the same display, but comparing the current and original or the incoming and original. That's it! No three-way fanciness required (beyond what git already does).
For comparison, here is emacs:

I have cycled through the three possible head-to-head comparisons to see that original-vs-incoming involves only a 1-character change. I can then confidently change EQ2 to EQ1 in the current code, accept the current version, and move on. Without manually doing the word-by-word or char-by-char comparison, I don't see how I can as easily resolve this conflict in VSCode.
As an added bonus, I'm hoping that implementing what I want is far easier than #37350. It's exactly the same as the existing merge-conflict.compare, but just changing the files that are compared.

I made a vain attempt to fix this myself in https://github.com/goldfirere/vscode/commit/9f8c9ebdfad14c6fea58f71e20c8a018f9e5aa42, but it doesn't work (and fails the pre-commit lint, due to my constructed string). I've never worked in TypeScript before, so there could be all manner of other silliness here, but the commit should get the idea across. Someone more knowledgeable with VSCode internals could hopefully take what I have and make it actually work. (It doesn't: somehow, my new commands aren't recognized. This baffles me.)

Nothing stands out on first look. Try making some trivial change to verify it gets compiled and picked up after reloading the window.

It's definitely recompiling and loading my changes. If I just changed this line in the original code to use conflict.commonAncestors[0].content, I was able to observe the result I wanted.
In the version I've built, my new command e.g. merge-conflict.compare-current-original appears in the command palette (when I Cmd+Shift+P), but then executing it produces an error that the command doesn't exist. It smells to me like the registerTextEditorCommand isn't working somehow -- or that I've mistyped the name of the command in different places. But I don't spot my mistake.

If nothing triggers the activation of the extension, this would be expected. Try adding onCommand activation events for each command in the package.json's activationEvents. I guess you would not run them from the command  palette normally which is why onStartupFinished as the only activation event works for the existing commands.

Thanks for this advice. I couldn't get anything with activationEvents working, but your message inspired me to clone my local repo into a new folder (yarn clean isn't a thing... and I only thought of git clean when writing this comment), where my new stuff works. Hooray!
What are good next steps here? I already noticed a bug in my code, in that if I click on a code lens to do the comparison, the cursor still needs to be within the conflict region for the comparison to work. This is because I didn't, at first, understand how/where the conflict ever gets passed to the action. I'm pretty sure I can fix this. And I suppose I could avoid the constructed string by just enumerating the three possibilities separately. (Luckily, three is a small number.)
But the tasks beyond this are beyond me: creating tests, any documentation, etc. I could put in this time, but is it a reasonable expectation that this patch would get merged? I don't want to spend time cleaning the code and learning more about how to contribute without a reward at the end. Or, is it a better strategy to wait for the VSCode team to address this, essentially using my patch as a tighter specification of what I'd like?
What do you suggest?
Thanks for your help!

Could you open a pull request with your latest code? I wonder if just adding more code lenses will overload the UI a bit.

I agree about the code lenses -- it was actually just a small experiment to see if the strange behavior I was witnessing was related to the command palette somehow and I wanted a new way to trigger my new code path. I will remove it -- happy for this feature to be available only for someone who looks for it.
OK. I will polish a bit and post a PR. Thanks.


Add Origin Isle location

Name: Origin Isle
Code: st412, st413

Context: st412 is the first part of Origin Isle, and won't be accessible after the story ends. If you want to have a unique image for it anyway, you can use this one:

Thanks! I'll add it and Seliana Supply Cache (#17) and will push a patch today.

Done!


Allow changing all the icons in VSCode

Recently a lot of people were shocked by how Microsoft (employees) reacted to https://github.com/microsoft/vscode/issues/87268 , not without a reason.
In order to avoid a single person LOL-ing at us and you in the future, allow changing all the icons in VSCode.
I personally find the "Source Control" icon looking exactly as a thin penis attached to two loosely-coupled testicles heading down (I expect to take this seriously):

This promotes porn-related images to me and I am offended and insulted at the same time. According to what Microsoft says in https://github.com/microsoft/vscode/issues/87440 - "even a single person being offended is one too many", I demand you to "remove it immediately and make it your top priority" (see exactly the same demand at https://github.com/microsoft/vscode/issues/87268 and how you obeyed).
I don't (and hopefully nobody) expect you to treat me (or anyone else) differently on the above matter. Otherwise, it would be an willful discrimination.

Couldn't agree more.  Also the debugger icon looks like a bug is being tortured by poking it with a arrow head. Now I respect all animals equally so I find it horrible that Microsoft is promoting animal torture to such extent.

I do like the general idea, allow more advanced theming.
There are enough examples to encourage this.
Misinterpreting the vscode icons one by one is pointless from now on.

Agreed. There are way too many opinions and way too many ways to offend some single person with some icon
The only right way to solve this is just to make everything customizable and that's how it should've been asked by that guy. Not by "removing it immediately and making it the top priority"

Yes, I would like to change every icon to a frog.
🐸🐸🐸🐸🐸🐸🐸🐸🐸🐸🐸🐸🐸🐸🐸🐸

I am pretty sure you can change those icons with editing themes,
if not that, then you have entire project open sourced, change the icons and you can build it up yourself

Typical white developers waving their undersized penises at us.

We in our company won't introduce a software which contains NSFW icons.
Please remove it.

/duplicate of #79130

Yes, I would like to change every icon to a frog.

Yes, I would like to change every icon to a frog.

Is that the same frog that hially went berserk about in a video and still blames for his defeat to the bad orange man?

@SRGOM I would use pepe the frog.
┬┴┬┴┤ ͜ʖ ͡°) ├┬┴┬┴

@SRGOM No.

Please add a customizeable-size penis icon.
Size matters.


Preview selected files in list #5

This PR is a clone of @jwuwork's contribution in https://github.com/atom/fuzzy-finder/pull/113 with the merge issues addressed.
Copy/paste of their PR details:
Ok folks, you asked for it. Here is the new feature for previewing selected files.
To enable this feature, go into fuzzy-finder Settings and check the new "Preview Selection" option:

Obviously, this works best if you have "Use Preview Tabs" option turned on from the tab package Settings.

@neilthawani can you please take a look at the spec failure?

Tried to sort this out, but having weird issue where my fork says it has merge conflicts.. I think all that needs to be added to ./lib/fuzzy-finder-view.js is:
diff --git a/lib/fuzzy-finder-view.js b/lib/fuzzy-finder-view.js
index d570f43..784b9d4 100644
--- a/lib/fuzzy-finder-view.js
+++ b/lib/fuzzy-finder-view.js
@@ -282,6 +282,11 @@ export default class FuzzyFinderView {
     }
   }

+  setMaxItems (maxCount) {
+    this.selectListView.setMaxItems(maxCount)
+    return maxCount
+  }
+

Well. Not sure what to do now. Sorry for the messy commits - all I wanted was a new feature.

?

Upon reviewing with the team today, we've decided that we don't want to own this functionality because of the various performance and stability impacts that it could have on the fuzzy-finder package. For example, what if you type some characters or select files that match the data files in a particular directory that are 5GB each? For this reason, we're not going to accept this PR and we're closing the related issues.
However, we did discuss the possibility of someone creating a provided service that could allow other community packages to integrate with fuzzy-finder to provide this behavior. We would be open to reviewing an RFC for a design of this proposed service in atom/fuzzy-finder. If anyone is interested in working on this, please open a new issue for the RFC for review by the maintainer team.
Thanks for your hard work and desire to make Atom better.


Memory64 Support

Hi there,
Do you guys have any plan for getting around that 4GB memory limit by supporting memory64?
Please see the following implementation status of the WebAssembly runtimes: https://github.com/WebAssembly/memory64/blob/main/proposals/memory64/Overview.md

Hope to hear from you.
Thank you.

I would have hoped for memory64 and wasm64 to be something a bit independent of candle and that will be a change on the rust toolchain side that we would just benefit from, but maybe that's not the case and it introduces specific apis that we should use? Good if you can give us some pointers for this if that's the case.

I wish I have the expertise and capable enough to give you some pointers. I considered myself is a Rust beginner and an user of WASM modules. So far you guys did a great job to deliver the features and code examples of candle, everyone here should be appreciated. Keep up the great works!
By the way, I try to find out what could we expect on memory64 support, I think it will not happen in months, but years, right? Even so, we can build some usable apps to fit around the 4G memory constraint.
Hope to hear from you soon :)


bulk deletion of images

synchronous checks to verify image can be deleted. response contains status of the delete op and a message when the delete fails
actual deletion of image triggered in an async thread

Signed-off-by: Swathi Gangisetty<EMAIL_ADDRESS>
What this PR does / why we need it:
Which issue this PR fixes (optional, in fixes #<issue number>)(, fixes #<issue_number, ...) format, will close the issue when PR is merged: fixes #:
Special notes:

@zhill, @nurmi, 1st draft of the API and end-to-end implementation for the async deletion of list of images. Still working on the unit tests and haven't included them in this commit. I've refactored some of the existing code to perform image deletion checks in the synchronous path. The async cleanup of image artifacts is implemented simply by invoking the deletion bits in a new thread. Was initially considering updating the status of the image to 'deleting' on the synchronous path and using a periodic handler to perform the deletion. But as I started going down that route, I found image state referred to the analysis status. Updating analysis state to 'deleting' didn't make a lot of sense to me. Let me know if there's a different image state/status that I may have overlooked. There's still the issue of surfacing deletion errors from the async process with either approach and clean up actions on such failures. I'll keep hacking away at it. Wanted to get some eyes on the API first


fixing update property settings for soft-delete and networkAcls

This checklist is used to make sure that common guidelines for a pull request are followed.

[ ] The PR has modified HISTORY.rst describing any customer-facing, functional changes. Note that this does not include changes only to help content. (see Modifying change log).

[ ] I adhere to the Command Guidelines.

You may need to rebase your changes? The CI failures don't look relevant to your code changes but they also don't occur on the dev branch.  Or you may just want to merge this and worry about the CI failures when you merge your preview branch to dev. up to you.


Add form request body

containerregistry/data-plane

Since this issue applies to multiple smoke tests, and has other related issues, I've bundled that all together here: https://github.com/Azure/autorest.csharp/issues/734
I'll close this one and mark it with the new issue number in the smoke test list.


Field Type Plugin with Design System Bugs

First of all - like always a great shoutout to the Storyblok team for creating an awesome product and solutions.
When I played around with the Design System Alpha some time ago with the intention to rewrite my Field Type Plugins using the Design System, I stumbled upon a few problems, that made it unusable to actually continue further at this state.
e.g.:
Components described with their documentation and specific properties / functionality does not work, and my guess is that it is currently a bit bugged that stylings are applied accordingly when working with field type plugins.
I went through this guide:
https://www.storyblok.com/faq/how-to-use-the-design-system-with-custom-field-types
and sadly not even the Radio Buttons showed up at all ;)
The same goes for Field items and their helper fields for example like:
https://blok.ink/?path=/docs/design-system-components-form-sbformitem--default
Looking forward to fixes. :)

Hello @lukas-a-brand , thank you so much for contributing to the project. We will see these issues shortly. ;)

Hey @lukas-a-brand , unfortunately I couldn't reproduce your issue. I created a new custom field type using the plugins page in my user area (so, I created a private plugin) and followed the article that you linked and the styles working well. Please, could you provide a more context?
The npm install command installed the version ^1.0.0-alpha.1 of the storyblok-design-system.
I will share the code which I used here:
My src/Plugin.vue:
<template>
  <div>
    <FormItem
      label="Label Text"
      style="margin-bottom: 20px"
    >
      <TextField
        v-model="content.text"
      />
    </FormItem>

    <FormItem>
      <Radio
        name="example"
        id="inactive"
        label="Unselected"
        v-model="content.selected"
        :native-value="false"
        inline
        style="margin-right: 20px;"
      />

      <Radio
        name="example"
        id="selected"
        label="Selected"
        v-model="content.selected"
        :native-value="true"
        inline
      />
    </FormItem>

    <Button label="Just a button" />
  </div>
</template>

<script>
import FormItem from 'storyblok-design-system/src/components/FormItem'
import Button from 'storyblok-design-system/src/components/Button'
import TextField from 'storyblok-design-system/src/components/TextField'
import Radio from 'storyblok-design-system/src/components/Radio'

export default {
  mixins: [window.Storyblok.plugin],
  components: {
    FormItem,
    Button,
    TextField,
    Radio,
  },
  data: () => ({
    content: {
      text: '',
      selected: false,
    }
  }),
  methods: {
    initWith() {
      return {
        // needs to be equal to your storyblok plugin name
        plugin: 'emanuel-test',
        selected: '',
      }
    },
    removeUiKit() {
      this.removeStyleByHref(
        "https://app.storyblok.com/assets/css/index-latest.css"
      ); // in local dev mode
      this.removeStyleByHref(
        "https://plugins.storyblok.com/assets/css/index-latest.css"
      ); // built plugin
    },
    removeStyleByHref(href) {
      const style = document.querySelector(`link[href="${href}"]`);

      if (style) {
        style.parentNode.removeChild(style);
      }
    },
    pluginCreated() {
      this.removeUiKit();
    },
  },
  watch: {
    'model': {
      handler: function (value) {
        this.$emit('changed-model', value);
      },
      deep: true
    }
  }
}
</script>

<style>
.sb-radio {
  margin: 8px;
}
</style>

In public/index.html file, I removed these lines.
And, the result was:

Just to you know that I didn't test any interaction in this moment, just if the DS styles was integrated well.
If you need anything, let us know.

Hmmmm very interesting that suddenly the radio buttons and also the helper button on the fielditem show up which they did not before, whatever i tried.. ;)
Although it seems they still have styling errors:

the radio hover gets cut off
the helper icon has a weird active state
the helper icon does not show the icon text and there is no hover state
the helper text is just constantly there not only on click

I don't have time right now to go through all of the components, but would be great if they would also work the same way in field type plugins like they are working on blok.ink  ;)
btw. I am on "storyblok-design-system": "^1.0.0-alpha.8",
I also have to add
.sb-textfield__input {
  font-size: 1.4rem !important;
}

otherwise I get that for example as well...

@lukas-a-brand Does this issue still exists?

I closed the issue due to inactivity, if there is a problem we can reopen or open a new issue.
cc: @lukas-a-brand


Evaluate Session Handling with Redis in Session Package

Control Panel sessions can be placed in Redis. Code for this is ready, we just need more testers. Contributors are welcome.

IInstall and test https://github.com/getpinga/session-redis


IHostApplicationLifetime not notified of shutdown

Describe the bug
When running the application as a Windows Service, if I shutdown the PC, the app is not notified of the shutdown or of the stop. IHostApplicationLifetime.ApplicationStopping or ApplicationStopped are not fired (and it's where I log about app stopping/stopped)
To Reproduce

Using version '3.0.1' of package 'Microsoft.Extensions.Hosting.WindowsServices'
Create a Windows Service following instructions here . In particular make sure you call .UseWindowsService

Expected behavior
App notified of system shutdown, so it can stop in a graceful manner.

I had a look at the source code and it looks like WindowsServiceLifetime.cs doesn't override OnShutdown

I can confirm the bug, since I've downloaded the source code and added
protected override void OnShutdown()
{
     ApplicationLifetime.StopApplication();
     base.OnShutdown();
}

and the app is now notified as expected during machine shutdown/restart.

@peval27 that code seems good to us. Would be you up for turning it in to a PR?

From the docs it sounds like you'd have to set CanShutdown as well?
https://docs.microsoft.com/en-us/dotnet/api/system.serviceprocess.servicebase.onshutdown?redirectedfrom=MSDN&view=netcore-3.0#System_ServiceProcess_ServiceBase_OnShutdown

From the docs it sounds like you'd have to set CanShutdown as well?
https://docs.microsoft.com/en-us/dotnet/api/system.serviceprocess.servicebase.onshutdown?redirectedfrom=MSDN&view=netcore-3.0#System_ServiceProcess_ServiceBase_OnShutdown

not sure why it's being called then. happy to add to the constructor.

@peval27 that code seems good to us. Would be you up for turning it in to a PR?

will give it a go!


[FLINK-10470] Add method to check if pattern can produce empty matches

What is the purpose of the change
This change introduces a method that allows checking if a Pattern can produce empty matches. It is needed to disable such patterns in MATCH_RECOGNIZE, until we are able to provide a full support of empty matches in CEP (with proper support of reluctant and greedy)
Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): (yes / no)
The public API, i.e., is any changed class annotated with @Public(Evolving): (yes / no)
The serializers: (yes / no / don't know)
The runtime per-record code paths (performance sensitive): (yes / no / don't know)
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes / no / don't know)
The S3 file system connector: (yes / no / don't know)

Documentation

Does this pull request introduce a new feature? (yes / no)
If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

cc @kl0u @pnowojski

@pnowojski could you have another look?


link in repo description is 404 https://stoplight.io/prism

https://stoplight.io/prism

Fixed - thanks!


Create workload viewer

Create a workload viewer that shows the status of workloads running in a cluster. This will be the new home page for Octant.
Workload shows status for pods in a namespaced grouped by owner. If the cluster
supports the pod metrics API, it will also include CPU and memory metrics
for the group of pods.

I started to look at this today but couldn't give my full attention because I distracted with #135 stuff. I'll give it a full dedicated code review tomorrow. Sorry for the delay in getting to this.

When I was testing this it worked great on GKE (1.13), but was not working on a KIND (1.15) cluster, using the exact same YAML. (example/resources/deployment.yaml)

When I was testing this it worked great on GKE (1.13), but was not working on a KIND (1.15) cluster, using the exact same YAML. (example/resources/deployment.yaml)

Do you have a screenshot?

No errors in the web console (besides preventDefault) and no errors in the terminal.

I think this is currently causing problems on Windows as the root path is created using filepath.Join() instead of path.Join() at the moment:
https://github.com/vmware-tanzu/octant/blob/master/internal/modules/workloads/module.go#L86


Features Tour

depends on #205
Create a tour that showcases all functionality and features.
Possible Waypoints:

[ ] Feature: Embedded Dataset
- imagery/UI: anatomy image with Vandy slide embedded
- text: explanation of feature and how to interact with dataset
- this can be several individual waypoints, taking the user "inside" an embedded dataset, etc.
[ ] Feature: Pins
- Imagery/UI: Vandy slide with preloaded pins
- text: walk through of types of pins and how to interact with them
[ ] Feature: Jobs - Nucleus Detection
- text: prompt the traveler to take some action (launch job from the UI, or activate the vis feature for (preloaded) job results)
[ ] Feature: Job results
[ ] Feature:  Jobs - Nucleus to Gland Detection
[ ] Feature: Job results
[ ] Feature: VTK
- Imagery/UI: tooth image? @naglepuff would this be the right dataset to use?
- text: describe how to interact with pin to open viewer and a bit about what to expect in new viewer
[ ] Feature: Paraview
- Imagery/UI: tooth image?
- text: describe how to interact with pin to open viewer and a bit about what to expect in new viewer
[ ] Feature: Similar nuclei (see #208)

@annehaley @waxlamp @naglepuff @mcovalt
Please feel free to add features that I missed and any imagery or text that you think would best showcase a feature.

@marySalvi Could you explain this part of the list? Why the sandwich?

Feature: Job results
Feature: Jobs - Nucleus to Gland Detection
Feature: Job results

Mary can confirm or reject when she's back, but I think the idea was to show job results for each of the jobs. It's not a single sandwich, it's two open-face sandwiches: "jobs - nucleus detection" + "job results" followed by "jobs - nucleus to gland detection" + "job results".

Imagery/UI: tooth image? @naglepuff would this be the right dataset to use?

Yes, the tooth dataset would be the one to use for demoing 3D vis. Attaching it as a pin would be the best approach.

Feature: Pins

Imagery/UI: Vandy slide with preloaded pins
text: walk through of types of pins and how to interact with them

In addition to different types of pins, you could show off some features of the pin sidebar. Particularly the select/deselect all button, and zooming to different parts of the map sorts pins by visibility.
You could also try and find a way to demo the pin transitions as you zoom towards/away from pins on the map.

@marySalvi Could you explain this part of the list? Why the sandwich?

Feature: Job results
Feature: Jobs - Nucleus to Gland Detection
Feature: Job results

Mary can confirm or reject when she's back, but I think the idea was to show job results for each of the jobs. It's not a single sandwich, it's two open-face sandwiches: "jobs - nucleus detection" + "job results" followed by "jobs - nucleus to gland detection" + "job results".

@annehaley @waxlamp
Yes, I imagined this to be job -> results. I figure we would have info we want to include about the job itself and then different info relating to the results of the job, hence separate waypoints.


Remove version: Google.Chrome.Canary version 128.0.6587.0

[Automated] It returns code over 400 in all urls
Microsoft Reviewers: Open in CodeFlow

URL: https://dl.google.com/release2/chrome/cnngn3jdyhzoykhjltyedp5o7a_128.0.6587.0/128.0.6587.0_chrome_installer.exe
Response Error: The remote server returned an error: (404) Not Found.
(Automated message - build 912)


ResourceWriteSuccessData - Authorization / Claims should be DYNAMIC or objects instead of strings

E.g. file https://github.com/Azure/azure-sdk-for-net/blob/40248f466aa063bd90f16dae10d06b9b7317e2d0/src/SDKs/EventGrid/DataPlane/Microsoft.Azure.EventGrid/Generated/Models/ResourceWriteSuccessData.cs
I'm running into JSON Serialization issues with the EventGrid JSON..
As AUTHORIZATION + CLAIMS are no longer string, but really a subobject!

The following code repro's the bug:
`        string resourceWriteSuccessDataString = "{\r\n  "authorization": {\r\n    "scope": "/subscriptions/00000000-1111-2222-3333-000000000002",\r\n    "action": "Microsoft.Resources/deployments/write",\r\n    "evidence": {\r\n      "role": "Subscription Admin"\r\n    }\r\n  },\r\n  "claims": {\r\n    "aud": "https://management.core.windows.net/\",\r\n    "manyMore": "claimValues",\r\n    "ver": "1.0"\r\n  },\r\n  "correlationId": "00000000-1111-2222-3333-000000000004",\r\n  "resourceProvider": "Microsoft.Resources",\r\n  "resourceUri": "/subscriptions/00000000-1111-2222-3333-000000000002/providers/Microsoft.Resources/deployments/00000000-1111-2222-3333-000000000001-hsf-initial",\r\n  "operationName": "Microsoft.Resources/deployments/write",\r\n  "status": "Succeeded",\r\n  "subscriptionId": "00000000-1111-2222-3333-000000000002",\r\n  "tenantId": "00000000-1111-2222-3333-000000000003"\r\n}";
[TestMethod]
public void ResourceWriteSuccessDataWorkaroundStillNeeded()
{
Assert.ThrowsException(() =>
JsonConvert.DeserializeObject(resourceWriteSuccessDataString)
);
// {"Unexpected character encountered while parsing value: {. Path 'authorization', line 2, position 20."}
}`
Using libs:
netcoreapp2.2
"Microsoft.AspNetCore.Mvc" Version="2.2.0"
"Microsoft.Azure.EventGrid" Version="3.2.0"
"Newtonsoft.Json" Version="12.0.2"
To work-around, I copied the class and changed the authorization and claims to 'object' instead of 'string'.

@ahamad-MS, here are some xunit tests, which can be added to:
https://github.com/Azure/azure-sdk-for-net/blob/master/sdk/eventgrid/Microsoft.Azure.EventGrid/tests/Tests/ConsumeEventTests.cs#L853
Once the bug is resolved.
        [Fact]
        public void ConsumeResourceWriteSuccessEventWithClaimsJObject()
        {
            string requestContent = "[   {     \"topic\":\"/subscriptions/{subscription-id}\",     \"subject\":\"/subscriptions/{subscription-id}/resourceGroups/{resource-group}/providers/Microsoft.EventGrid/eventSubscriptions/LogicAppdd584bdf-8347-49c9-b9a9-d1f980783501\",    \"eventType\":\"Microsoft.Resources.ResourceWriteSuccess\",    \"eventTime\":\"2017-08-16T03:54:38.2696833Z\",    \"id\":\"25b3b0d0-d79b-44d5-9963-440d4e6a9bba\",    \"data\": {        \"authorization\":\"{azure_resource_manager_authorizations}\",        \"claims\": {\"someClaim\":\"theClaimValue\", \"someOtherClaim\":\"theOtherClaimValue\"},        \"correlationId\":\"54ef1e39-6a82-44b3-abc1-bdeb6ce4d3c6\",        \"httpRequest\":\"{request-operation}\",        \"resourceProvider\":\"Microsoft.EventGrid\",        \"resourceUri\":\"/subscriptions/{subscription-id}/resourceGroups/{resource-group}/providers/Microsoft.EventGrid/eventSubscriptions/LogicAppdd584bdf-8347-49c9-b9a9-d1f980783501\",        \"operationName\":\"Microsoft.EventGrid/eventSubscriptions/write\",        \"status\":\"Succeeded\",        \"subscriptionId\":\"{subscription-id}\",        \"tenantId\":\"72f988bf-86f1-41af-91ab-2d7cd011db47\"        },      \"dataVersion\": \"\",      \"metadataVersion\": \"1\"  }]";

            var events = this.eventGridSubscriber.DeserializeEventGridEvents(requestContent);

            Assert.NotNull(events);
            Assert.True(events[0].Data is ResourceWriteSuccessData);
            ResourceWriteSuccessData eventData = (ResourceWriteSuccessData)events[0].Data;
            Assert.Equal("72f988bf-86f1-41af-91ab-2d7cd011db47", eventData.TenantId);
        }

        [Fact]
        public void ConsumeResourceWriteSuccessEventWithAuthorizationJObject()
        {
            string requestContent = "[   {     \"topic\":\"/subscriptions/{subscription-id}\",     \"subject\":\"/subscriptions/{subscription-id}/resourceGroups/{resource-group}/providers/Microsoft.EventGrid/eventSubscriptions/LogicAppdd584bdf-8347-49c9-b9a9-d1f980783501\",    \"eventType\":\"Microsoft.Resources.ResourceWriteSuccess\",    \"eventTime\":\"2017-08-16T03:54:38.2696833Z\",    \"id\":\"25b3b0d0-d79b-44d5-9963-440d4e6a9bba\",    \"data\": {        \"authorization\": { \"scope\": \"/subscriptions/00000000-1111-2222-3333-000000000002\", \"action\": \"Microsoft.Resources/deployments/write\", \"evidence\": { \"role\": \"Subscription Admin\" } },        \"claims\":\"{azure_resource_manager_claims}\",        \"correlationId\":\"54ef1e39-6a82-44b3-abc1-bdeb6ce4d3c6\",        \"httpRequest\":\"{request-operation}\",        \"resourceProvider\":\"Microsoft.EventGrid\",        \"resourceUri\":\"/subscriptions/{subscription-id}/resourceGroups/{resource-group}/providers/Microsoft.EventGrid/eventSubscriptions/LogicAppdd584bdf-8347-49c9-b9a9-d1f980783501\",        \"operationName\":\"Microsoft.EventGrid/eventSubscriptions/write\",        \"status\":\"Succeeded\",        \"subscriptionId\":\"{subscription-id}\",        \"tenantId\":\"72f988bf-86f1-41af-91ab-2d7cd011db47\"        },      \"dataVersion\": \"\",      \"metadataVersion\": \"1\"  }]";

            var events = this.eventGridSubscriber.DeserializeEventGridEvents(requestContent);

            Assert.NotNull(events);
            Assert.True(events[0].Data is ResourceWriteSuccessData);
            ResourceWriteSuccessData eventData = (ResourceWriteSuccessData)events[0].Data;
            Assert.Equal("72f988bf-86f1-41af-91ab-2d7cd011db47", eventData.TenantId);
        }

Note that I can't actually repro a ResourceWriteFailure event, but I'd wager the Authorization and Claims are similarly complex, and will fail in the same way.
To repro in azure, simply register your endpoint to the subscription (or resource group) for event grid events.
Impact Statement:
Affects deserialization as described above.
Affects EventGridSubscriber.DeserializeEventGridEvents function which fails in the same way.
Affects current MSFT partner engagements.
Regression: Unknown

Looks like httpRequest is also a JObject now.

We are adding this for investigation in our backlog and will investigate/triage appropriately

+1

This is an issue in the new Azure.Messaging.EventGrid library as well.
I see two potential paths forward here:

Store these object values as JSON strings in the existing properties. You should be able to reparse to get it back as a JSON object.
Create new events with the correctly typed properties, and hide the old ones (to avoid breaking anyone).

We fixed this by converting the JSON objects into strings and storing in the existing properties. We still want to add new Dictionary properties that would give you the JSON object. Reopening to track that work.

This was fixed in https://github.com/Azure/azure-sdk-for-net/pull/26222 and is available as of 4.8.1.


[Bug]: Module 'battery_plus' not found in iOS

Platform
iOS 15.5
Plugin
battery_plus'
Version
2.1.4
Flutter SDK
2.10.5
Steps to reproduce

Code Sample
var battery = Battery();
    batteryLevel = (await battery.batteryLevel).toDouble();
    print("Battery ${await battery.batteryLevel}");

Logs
MetadataProvider: Loaded debug metadata for module: packages/battery_plus_web/battery_plus_web.dart
[   +8 ms] MetadataProvider: Loaded debug metadata for module: packages/battery_plus_platform_interface/method_channel_battery_plus.dart
[        ] MetadataProvider: Loaded debug metadata for module: packages/battery_plus_platform_interface/src/enums.dart
[        ] MetadataProvider: Loaded debug metadata for module: packages/battery_plus_platform_interface/src/utils.dart

Found plugin battery_plus_macos at /Users/dcasf/BddddgazeDevelopment
/Softwares/flutter/.pub-cache/hosted/pub.dartlang.org/battery_plus_macos-1.1.1/
[   +7 ms] Found plugin battery_plus_web at /Users/ddd/BddddeDevelopment
/Softwares/flutter/.pub-cache/hosted/pub.dartlang.org/battery_plus_web-1.1.0/
[  +13 ms] Found plugin battery_plus_windows at /Users/bidddzgddaze/BdddeDevelopment
/Softwares/flutter/.pub-cache/hosted/pub.dartlang.org/battery_plus_windows-1.1.2/

Flutter Doctor
Doctor summary (to see all details, run flutter doctor -v):
[✓] Flutter (Channel stable, 2.10.5, on macOS 12.3 21E230 darwin-x64, locale en-GB)
[✓] Android toolchain - develop for Android devices (Android SDK version 32.1.0-rc1)
[✓] Xcode - develop for iOS and macOS (Xcode 13.2)
[✓] Chrome - develop for the web
[✓] Android Studio (version 2021.2)
[✓] Connected device (1 available)
[✓] HTTP Host Availability

• No issues found!

I am seeing this same bug on my iOS build.

As I understand, this is a compilation issue, right?
I cannot reproduce this by compiling the example in the battery_plus package folder. Can you try that? build and run the example in packages/battery_plus/battery_plus/example

Checked this on new project:
$ flutter create battery_test
$ cd battery_test
$ flutter pub add battery_plus

copied example from.. example folder
plugin compiled and works.
my flutter doctor output:
➜  battery_test flutter doctor
Doctor summary (to see all details, run flutter doctor -v):
[✓] Flutter (Channel stable, 3.3.4, on macOS 12.6 21G115 darwin-arm, locale en-GB)
[✓] Xcode - develop for iOS and macOS (Xcode 14.0.1)

guess we can close this ?

same issue here,
flutter version
Flutter 3.3.6 • channel stable • https://github.com/flutter/flutter.git
Framework • revision 6928314d50 (7 days ago) • 2022-10-25 16:34:41 -0400
Engine • revision 3ad69d7be3
Tools • Dart 2.18.2 • DevTools 2.15.0
flutter doctor
[✓] Flutter (Channel stable, 3.3.6, on macOS 13.0 22A380 darwin-x64, locale en-ID)                                                                                Checking Android licenses is taking an unexpectedly long time...[✓] Android toolchain - develop for Android devices (Android SDK version 33.0.0)
[✓] Xcode - develop for iOS and macOS (Xcode 14.0.1)
[✓] Chrome - develop for the web
[✓] Android Studio (version 2021.3)
[✓] VS Code (version 1.72.2)
[✓] Connected device (3 available)
[✓] HTTP Host Availability
my device
Iphone XR (iOS 15.5)

I cannot reproduce the issue with a newly created project. You probably need to clean your project and maybe delete the Podfile.lock and Pods folder, so it is recreated correctly again.

same problem

same problem


Marshalling nested JS Date to rb Time not working

Related to #12
require 'bundler/inline'
gemfile do
  gem 'mini_racer', '= 0.2.4'
end

ctx = MiniRacer::Context.new
ctx.eval( <<~JSEVAL )
  var extractDate = (nestedObj) => nestedObj.abc[0].constructor.name;
JSEVAL

# PASS: returns "Date" (rb => js conversion happens even when `Time` is nested)
p ctx.call('extractDate', {abc: [Time.now]})

# PASS: returns `Time` (js => rb conversion happens when a `Date` isn't nested)
p ctx.eval(%q|new Date()|).class

# FAIL: returns `String` (js => rb conversion doesn't happen for nested `Date`s)
p ctx.eval(%q|( {abc: new Date()} )|)['abc'].class

@seanmakesgames can you have a look?

yeah. I can take a look.

Sorry for the lack of comms on this one. It's been a full couple weeks. I was able to take a look at it, looks like this case is traveling down a different code path which I'm less familiar with and so need some more time to dig through it. In the meantime, if you marshal it with a proc, it should work as expected. (you can take a look at https://github.com/discourse/mini_racer/blob/master/test/mini_racer_test.rb#L214 for an example)
Not sure if that works for you, but worth a shot. :)

No rush - this probably isn't something I'll need in the near future. I discovered the issue because I'm using the rb => js nested conversion (which works perfectly), and was curious to see whether it worked in the other direction.

Might be related to https://github.com/rubyjs/mini_racer/issues/136


Use own validator ObjectUtils.anyNull to check null String input

Coverage remained the same at 94.919% when pulling a4713172f607892e154467c9f4e5e880407e01f0 on arturobernalg:feature/use_anyNull into b57f292cdf14fef72e68d60c580cb80d794be7e0 on apache:master.

Eating our own dog food :-)


Create gentx-KruGGoK

👋 We have launched the chain with validators already identified, but stay tuned for the next steps: https://twitter.com/OKP4_Protocol/status/1584519227301502976.


faq for user resources limit of vc

add other items which is suggest by ziming

Coverage increased (+26.06%) to 76.786% when pulling 9c5068d20b4967bd7015f5d8c7e9beabb06e2d1d on yanjga/faq_schedule into 1152bdf971ea45f0d4e0af67ed336b5d6dc622f2 on master.

Coverage increased (+26.06%) to 76.786% when pulling 9c5068d20b4967bd7015f5d8c7e9beabb06e2d1d on yanjga/faq_schedule into 1152bdf971ea45f0d4e0af67ed336b5d6dc622f2 on master.


Please help with:  Building package x265 fails

Hello VCPKG Team!
** VCPKG is a wonderful toolset/environment, and generally works flawlessly for me.  Well Done!! **
However, I ran into a problem with installation of the x265 (HEVC Video Encoder) package.
There appears to be a problem getting the file:
https://bitbucket.com/multicoreware/x265/get/3.2.tar.gz
The details of the failure are given below.
Thanks for your help!
Chris
====================================================================
S:\Sd\3p\VCPKG>vcpkg install x265
The following packages will be built and installed:
    x265[core]:x86-windows
Starting package 1/1: x265:x86-windows
Building package x265[core]:x86-windows...
-- Downloading https://bitbucket.com/multicoreware/x265/get/3.2.tar.gz...
-- Downloading **https://bitbucket.com/multicoreware/x265/get/3.2.tar.gz... Failed. Status: 22;"HTTP response code said error"**
CMake Error at scripts/cmake/vcpkg_download_distfile.cmake:175 (message):

      Failed to download file.
      If you use a proxy, please set the HTTPS_PROXY and HTTP_PROXY environment
      variables to "https://user:password@your-proxy-ip-address:port/".
      Otherwise, please submit an issue at https://github.com/Microsoft/vcpkg/issues

Call Stack (most recent call first):
  scripts/cmake/vcpkg_from_bitbucket.cmake:127 (vcpkg_download_distfile)
  ports/x265/portfile.cmake:3 (vcpkg_from_bitbucket)
  scripts/ports.cmake:94 (include)

Error: Building package x265:x86-windows failed with: BUILD_FAILED
Please ensure you're using the latest portfiles with `.\vcpkg update`, then
submit an issue at https://github.com/Microsoft/vcpkg/issues including:
  Package: x265:x86-windows
  Vcpkg version: 2019.09.12-nohash-external

Additionally, attach any relevant sections from the log files above.

====================================================================

My configuration:
System:  Intel(R) Core(TM) i7-3770K CPU @ 3.50GHz   3.50 GHz, 32GB RAM
OS: Microsoft Windows [Version 10.0.19044.1469]    (Windows 10 Pro 21H2)
Country/Regional:   United States / English (US)
VCPKG bundled with:  Microsoft Visual Studio Community 2019 -- Version 16.11.9

X265 is normally downloaded from its GitHub repo. Please make sure you are using the latest version of vcpkg:
From your vcpkg folder run git pull and then bootstrap.bat.

Question 2:
Should I install (and learn) git, in order to proceed?

Definitely yes!

Question 1:
If I understand you correctly, that means I need to obtain the x265 package myself; i.e. it is not something VCPKG will do for me?

vcpkg will download the package from GitHub. The reason why this particular port failed to download is that it changed the location from which it will be downloaded to its GitHub repo.

Thanks, @Thomas1664  !
Q2:
I kinda knew that answer to (Q2) was gonna be Yes...
Ok ... alright ... gonna git with the program.  :-)
Q1:
Right.  I see.  An updated VCPKG will "find it" on GitHub.
So, there would be nothing else for me to do (beyond updating vcpkg, then re-trying the vcpkg install x265...)

Ok, I will let you know how it goes.
Thanks again for the super-quick response!

Question 1:
If I understand you correctly, that means I need to obtain the x265 package myself; i.e. it is not something VCPKG will do for me?
 I hope you'll forgive my limited understanding of VCPKG. Just so you know ... I am an experienced C/C++ developer [30+years], but I am new to using automated 3rd party code packaging apps, like VCPKG.
I guess I thought it would be handled automatically like all the other packages I have -- like zlib, sqlite, ffmpeg, etc.
My VCPKG list shows 188 packages installed. They all work just fine in my projects.

vcpkg will automaticly download, build and install the binaries/headers/other publish files. You don't need to manually download the packages, since vcpkg already change the repo from official webset to github, you just need to update vcpkg using git pull.

Right. Since I am using the VCPKG bundled with VS 2019, I will assume it is out of date.

If your bundled vcpkg is out-dated, you should update it.

Question 2:
Should I install (and learn) git, in order to proceed?

Just a bit: using git pull to update vcpkg.

Thank you @JackBoosY  and @Thomas1664  !
Success!
I have now:
a) installed git and configured it,
b) git clone'd the vcpkg,
c) installed and rebuilt all my packages,
d) confirmed my existing projects still build, and finally...
e)  -- TADA! -- successfully installed the x265 package.
Thanks guys, for your awesome response.
From my point of view, this issue can be closed.  :-)
Chris


Week picker (2nd attempt)

📯   Hey everyone, big news
@philipkocanda and @iMartzen have helped get this Merge Request from 2021 over the finish line, so most of the credit goes to @TiesWestendorp 👏

⚙ Implementation
() => {
  const [startDate, setStartDate] = useState(new Date("2021/02/22"));
  return (
    <DatePicker
      selected={startDate}
      onChange={(date) => setStartDate(date)}
      dateFormat="I/R"
      locale="en-GB"
      showWeekNumbers
      showWeekPicker
    />
  );
};

📖  Resources:

Original Issue
Original PR

🤝  We used our HackerOne Community Service Day to finalize this feature, and we're thrilled to share it today.
🚀  Enjoy the new week picker, and let's make a positive impact together

@philipkocanda @iMartzen great initiative and excited to see this coming back. Once you mark the PR as ready for review it will be sent to the pullrequest network as well.

Please check the CI output. The linter is failing because of unused imports.

Overall the code coverage seems a bit low, and reduces the project coverage from 96% to 94%, it would be great to make sure we keep this stable and increase the coverage on this PR to the project levels.

BTW: This MR would benefit from having Co Author data in the commit message.
https://docs.github.com/en/pull-requests/committing-changes-to-your-project/creating-and-editing-commits/creating-a-commit-with-multiple-authors
I would also include @TiesWestendorp if some of their work is included in this MR.

@Zarthus Great suggestion! I've added Ties Westendorp as the co-author on the first commit.

Test coverage seems pretty decent, but src/week_number.jsx coverage seems to have reduced a lot. Can you look into keeping the test coverage stable? We have a high coverage of 96% and I would love to keep it that way. Right now, the overall package coverage would reduce by 2% if we merge this PR.

Hi @martijnrusschen. Thanks for taking this up.
I'd like to know if the latest merge has been published to npm. I can see the the showWeekPicker prop is available in the docs but not available in the library props.

It's released now: https://github.com/Hacker0x01/react-datepicker/releases/tag/v4.23.0


Only relabelling should apply for scrape_samples_scraped_post_relabel…

…ling.
More consistent variable names.
Fixes #7298

Is this a recent regression on master?

I didn't dig into when exactly it was introduced, but it is a regression from the original code and intent.

needs test fix


Instantiate AuthZeroManagement client locally.

Coverage decreased (-0.03%) to 89.375% when pulling 237fecbaa3e8c4b2693301fb5d214074525389c7 on johngian:fix-cannotsend-request into 04e58fb1997a4f32506c5085e8aaf35823e95e89 on mozilla:master.


OAuth 2.1 framework version

The draft ietf specification we point at is 01, yet the latest is 08
https://datatracker.ietf.org/doc/html/draft-ietf-oauth-v2-1-08

@msmock can you comment? I am also interested on behalf of ITI-PCF ITI-108

Will be solved with CP-ITI-1288


enabling GELU for nllb text decoder (for Expressivity model compatibi…

This PR is to help enabling GELU activation for the text decoder (of Expressivity model).

resolved internally.


Ensure correct coordinate ordering in selection file write

Description
Fix an issue where write_selection_file would create empty files when selecting multiple lines. This occurred because the selection coordinates were not properly ordered when writing to file.
Problem
When selecting multiple lines from bottom to top , the resulting file would be empty. This happened because:

Selection coordinates were used directly without proper ordering

start() and end() don't guarantee top-to-bottom, left-to-right ordering

Solution
Use topLeft() and bottomRight() methods to ensure correct coordinate ordering when writing selection to file.
Testing
Tested the following scenarios:

Selecting multiple lines from top to bottom ✅

Selecting multiple lines from bottom to top ✅

Known Behavior
When selecting a single word, the entire line containing that word is written to the file. This is consistent with the current terminal behavior as noted in the original discussion.
Fixes ghostty-org/ghostty#3594

Perfect thanks. In debug builds this should've triggered a crash because PageList has runtime safety to assert our pins are ordered properly. I just want to verify this before merging.

I did some investigation about the assertion you mentioned. I found an assertion in PageList.pageIterator:
if (build_config.slow_runtime_safety) {
	assert(tl_pin.eql(bl_pin) or tl_pin.before(bl_pin));
}

I'm not sure if this is the assertion you were referring to, but if it is, I think I might know why it didn't trigger. The call stack in our case is:
Screen.dumpString -> PageList.encodeUtf8 -> Pin.pageIterator
So it ends up calling Pin.pageIterator instead of PageList.pageIterator, which might explain why we didn't see the assertion failure in debug builds.

Okay yeah that's right. We should probably move the assertions into there since all the functions flow into there (i.e. row and cell iterator also recurse into pageIterator).

Thank you!


Fix Codable vtable layout

Fixes rdar://problem/35647420 and https://bugs.swift.org/browse/SR-6468.

@lorentey This introduces a mechanism for derived conformances to define class methods with deterministic vtable order. Just remember to update TypeChecker::finalizeType() to force the conformance, and remember to call setSynthesized() on every method you add to the class.

@swift-ci Please test

@swift-ci Please test source compatibility

Build failed
Swift Test Linux Platform
Git Sha - da47f19f8ae45d53ef166a2920f40e9e012af3f1

Build failed
Swift Test OS X Platform
Git Sha - da47f19f8ae45d53ef166a2920f40e9e012af3f1

@slavapestov Thank you, this looks great! 🎉

This looks good too! A lot of the changes here were also made in #16054 too; should this subsume that PR?
(Also, both PRs appear to have the same test failures in init checking from ObjC; possibly related to the changes in the DeclChecker?)

@swift-ci Please smoke test

@swift-ci Please smoke test


Public Shares Memory Provider

WIP
publicshareprovider as a gateway service plus a memory provider.
configuration:
gateway.toml
# This config file will start a reva gateway that:
# - handles incoming HTTP requests
# - forwards GRPC requests to the backend

[core]
log_file = "stderr"
log_mode = "dev"
max_cpus = "50%"
#tracing_enabled = true

[log]
level = "debug"
mode = "console"

# What http services should be started?

[http]
network = "tcp"
address = "<IP_ADDRESS>:9998"
enabled_services = [
    "appregistrysvc",
    "ocdavsvc",
    "ocssvc",
    "datasvc",
    "preferencessvc",
    "prometheussvc",
    "oidcprovider",
    "wellknown"
]
enabled_middlewares = ["cors", "auth"]

# HTTP middlewares

[http.middlewares.auth]
priority = 100
# directly talk to the backend for authentication to save a grpc request
gatewaysvc = "<IP_ADDRESS>:9999"
credential_strategy = "oidc"
token_strategy = "header"
token_writer = "header"
token_manager = "jwt"
skip_methods = [
    "/status.php",
    "/oauth2",
    "/oauth2/auth",
    "/oauth2/token",
    "/oauth2/introspect",
    "/oauth2/userinfo",
    "/oauth2/sessions",
    "/.well-known/openid-configuration",
    "/metrics"
]

[http.middlewares.auth.token_managers.jwt]
secret = "Uv38ByGCZU8WP18PmmIdcpVmx00QA3xN"

[http.middlewares.cors]
priority = 200
allowed_origins = ["*"]
allow_credentials = true
allowed_methods = ["OPTIONS", "GET", "PUT", "POST", "DELETE", "MKCOL", "PROPFIND", "PROPPATCH", "MOVE", "COPY", "REPORT", "SEARCH"]
allowed_headers = ["Origin", "Accept", "Content-Type", "X-Requested-With", "Authorization", "Ocs-Apirequest", "If-None-Match"]
options_passthrough = true

# HTTP services

[http.services.appregistrysvc]
prefix = "appregistry"
gatewaysvc = "localhost:10000"

[http.services.preferencessvc]
prefix = "preferences"
gatewaysvc = "localhost:10000"

[http.services.iframeuisvc]
prefix = "iframe"

[http.services.webuisvc]
prefix = "ui"

[http.services.ocdavsvc]
prefix = ""
gatewaysvc = "localhost:10000"
chunk_folder = "/var/tmp/owncloud/chunks"

[http.services.ocssvc]
prefix = "ocs"
gatewaysvc = "localhost:10000"
# the list of share recipients is taken fro the user.json file
user_manager = "json"

[http.services.ocssvc.user_managers.json]
users = "users.json"

[http.services.ocssvc.config]
version = "1.8"
website = "nexus"
host = "https://localhost:9998"
contact = "admin@localhost"
ssl = "true"
[http.services.ocssvc.capabilities.capabilities.core]
poll_interval = 60
webdav_root = "remote.php/webdav"
[http.services.ocssvc.capabilities.capabilities.core.status]
installed = true
maintenance = false
needsDbUpgrade = false
version = "<IP_ADDRESS>"
versionstring = "10.0.9"
edition = "community"
productname = "reva"
hostname = ""
[http.services.ocssvc.capabilities.capabilities.checksums]
supported_types = ["SHA256"]
preferred_upload_type = "SHA256"
[http.services.ocssvc.capabilities.capabilities.files]
private_links = true
bigfilechunking = true
blacklisted_files = ["foo"]
undelete = true
versioning = true
[http.services.ocssvc.capabilities.capabilities.dav]
chunking = "1.0"
[http.services.ocssvc.capabilities.capabilities.files_sharing]
api_enabled = true
resharing = true
group_sharing = true
auto_accept_share = true
share_with_group_members_only = true
share_with_membership_groups_only = true
default_permissions = 22
search_min_length = 3
[http.services.ocssvc.capabilities.capabilities.files_sharing.public]
enabled = true
send_mail = true
social_share = true
upload = true
multiple = true
supports_upload_only = true
[http.services.ocssvc.capabilities.capabilities.files_sharing.public.password]
enforced = true
[http.services.ocssvc.capabilities.capabilities.files_sharing.public.password.enforced_for]
read_only = true
read_write = true
upload_only = true
[http.services.ocssvc.capabilities.capabilities.files_sharing.public.expire_date]
enabled = true
[http.services.ocssvc.capabilities.capabilities.files_sharing.user]
send_mail = true
[http.services.ocssvc.capabilities.capabilities.files_sharing.user_enumeration]
enabled = true
group_members_only = true
[http.services.ocssvc.capabilities.capabilities.files_sharing.federation]
outgoing = true
incoming = true
[http.services.ocssvc.capabilities.capabilities.notifications]
endpoints = ["list", "get", "delete"]
[http.services.ocssvc.capabilities.version]
edition = "nexus"
major = 10
minor = 0
micro = 11
string = "10.0.11"

[http.services.datasvc]
driver = "owncloud"
prefix = "data"
temp_folder = "/var/tmp/"

[http.services.datasvc.drivers.owncloud]
datadirectory = "/data"

[http.services.oidcprovider]
prefix = "oauth2"

[http.services.wellknown]
prefix = ".well-known"

# also start the grpc gateway for other cs3 services so we have one frontend process

[grpc]
network = "tcp"
address = "<IP_ADDRESS>:10000"
enabled_services = ["gatewaysvc"]

[grpc.services.gatewaysvc]
storageregistrysvc = "localhost:9999"
authsvc = "localhost:9999"
usershareprovidersvc = "localhost:9999"
publicshareprovidersvc = "localhost:9999"
appregistrysvc = "localhost:9999"
preferencessvc = "localhost:9999"
commit_share_to_storage_grant = true
commit_share_to_storage_ref = true

revad.toml
# This config file will start a reva grpc service backend that:
# - stores files in the local storage
# - reads users from users.json
# - uses basic authentication to authenticate requests

[core]
log_file = "stderr"
log_mode = "dev"
max_cpus = "2"
tracing_enabled = true
disable_http = true

[log]
level = "debug"
mode = "console"

# What grpc services  should be started?

[grpc]
network = "tcp"
address = "<IP_ADDRESS>:9999"
enabled_services = ["storageprovidersvc", "authsvc", "storageregistrysvc", "appregistrysvc", "appprovidersvc", "preferencessvc", "usershareprovidersvc", "publicshareprovidersvc"]
enabled_interceptors = ["auth"]

# Order and configuration of grpc interceptors

# GRPC interceptors

[grpc.interceptors.auth]
# keys for grpc metadata are always lowercase, so interceptors headers need to use lowercase.
token_manager = "jwt"
# GenerateAccessToken contains the credentials in the payload. Skip auth, otherwise services cannot obtain a token.
skip_methods = ["/cs3.authv0alpha.AuthService/GenerateAccessToken", "/cs3.authv0alpha.AuthService/WhoAmI"]

[grpc.interceptors.auth.token_managers.jwt]
secret = "Uv38ByGCZU8WP18PmmIdcpVmx00QA3xN"

# GRPC services

## The authentication service

[grpc.services.authsvc]
token_manager = "jwt"
# users are authorized by checking their password matches the one in the users.json file
auth_manager = "oidc"
# user info is read from the user.json file
user_manager = "oidc"

[grpc.services.authsvc.auth_managers.oidc]
provider = "http://localhost:9998"
insecure = true
# the client credentials for the token introspection beckchannel
client_id = "phoenix"
client_secret = "foobar"

[grpc.services.authsvc.token_managers.jwt]
secret = "Uv38ByGCZU8WP18PmmIdcpVmx00QA3xN"

## The storage registry service

[grpc.services.storageregistrysvc]
driver = "static"

[grpc.services.storageregistrysvc.drivers.static.rules]
"/" = "localhost:9999"
"123e4567-e89b-12d3-a456-426655440000" = "localhost:9999"

## The storage provider service

[grpc.services.appregistrysvc]
driver = "static"

[grpc.services.appregistrysvc.static.rules]
".txt" = "localhost:9999"
"text/plain" = "localhost:9999"

[grpc.services.appprovidersvc]
driver = "demo"

[grpc.services.appprovidersvc.demo]
iframe_ui_provider = "http://localhost:9998/iframeuisvc"

# [grpc.services.storageprovidersvc]
# driver = "local"
# mount_path = "/"
# mount_id = "123e4567-e89b-12d3-a456-426655440000"
# data_server_url = "http://<IP_ADDRESS>:9998/data"

[grpc.services.storageprovidersvc]
driver = "local"
mount_path = "/"
mount_id = "123e4567-e89b-12d3-a456-426655440000"
tmp_folder = "/var/tmp"

[grpc.services.storageprovidersvc.drivers.local]
root = "/data"

[grpc.services.storageprovidersvc.available_checksums]
md5   = 100
unset = 1000

## The user share provider service

[grpc.services.usershareprovidersvc]
driver = "memory"

[grpc.services.publicshareprovidersvc]
driver = "memory"

@labkode @butonic any piece of feedback would be appreciated at this stage! I'd like to jump right into the application logic

@refs please make Travis happy :)
Probably you need to rebase on the master branch

@refs please make Travis happy :)
Probably you need to rebase on the master branch

on it 👍 💃

Codecov Report

Merging #234 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #234   +/-   ##
=======================================
  Coverage   74.25%   74.25%
=======================================
  Files           7        7
  Lines         268      268
=======================================
  Hits          199      199
  Misses         64       64
  Partials        5        5

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update caa3ca1...6502b8d. Read the comment docs.

I've marked this PR as work in progress until you finish the implemenation of the memory provider so we can create/update and list public shares.

yes. just wanted to have something running that adheres to the overall project structure, as it's the first proper PR I submit :)
currently working on the memory provider

@refs the PR is really nice, I wait for your work on the memory provider to wire all the operations.

@refs any progress on this? if you need help don't hesitate to ping us :)

@labkode thanks! will do! I will what I currently have in a moment. Currently getting more familiar with the cs3 API and doing some debugging.

ping @labkode


PostgreSQL support in SQL cells

I'd like to be able to run queries against a PostgreSQL database from a SQL cell. Will that be considered?
Having found this Stackoverflow post and looked at the SQL Server code, could pgsql support be bootstrapped with that code?

Yes, we are planning on adding support for PostgreSQL.

Hi there, any update on this?

This is going to be a very popular request for folks. It's understandable for this to be absent or in beta until the SQL Server support leaves beta, but I strongly expect community demand for this feature should Polyglot Notebook adoption increase significantly.

Is there any progress on it?

This is not currently being worked on. I would be happy to help guide a PR if someone wanted to contribute it, though.


About how to declare goset type

Hi Amit, I have a question
I need declare a variable with goset, this code is my sture type haproxy.ObjSet
var objSet  goset.Set[haproxy.ObjSet]
objSet = goset.NewSet[haproxy.ObjSet]()  // An error was generated

I read the README.md and annotation
the annotaion said

// You should not call it directly, use NewSet() or FromSlice()

in this scene, How should I initial the variable

Hi @destoryccp
The NewSet function returns a pointer, therefore your snippet should look like that:
var objSet  *goset.Set[haproxy.ObjSet]
objSet = goset.NewSet[haproxy.ObjSet]()

But as anything else in go, you can also just do:
objSet := goset.NewSet[haproxy.ObjSet]()

You can have a look at the README & the tests file for more examples

Thank you for your reply, I try using pointer type already resolve. 😁😁


Swift 1.2

http://stackoverflow.com/questions/28771896/overriding-method-with-selector-touchesbeganwithevent-has-incompatible-type

Thanks @Katafalkas ! Any idea how I should keep things compatible for both versions?

I'm also experiencing this issue since upgrading to 8.3

So I changed:
NSSet to Set<NSObject>
and touches.anyObject() to touches.first
and it compiles for Swift 1.2
Untested!!!
verride public func touchesBegan(touches: Set<NSObject>, withEvent event: UIEvent) {
        if let touch = touches.first as? UITouch {
            let touchLocation = touch.locationInView(self)
            self.handleTouchAtLocation(touchLocation)
        }
    }

    override public func touchesMoved(touches: Set<NSObject>, withEvent event: UIEvent) {
        if let touch = touches.first as? UITouch {
            let touchLocation = touch.locationInView(self)
            self.handleTouchAtLocation(touchLocation)
        }
    }

    override public func touchesEnded(touches: Set<NSObject>, withEvent event: UIEvent) {
        // Update delegate
        if let delegate = self.delegate {
            delegate.floatRatingView(self, didUpdate: self.rating)
        }
    }

Fixed for Swift 1.2. Thanks for the help @Katafalkas and @hynese !


Fix: #15285 openssl req command checking digest

openssl req checking digest
Fixes #15285
CLA: trivial

Checklist

[ ] documentation is added or updated
[ ] tests are added or updated

For the third time :) look at how CMS does it -- after all options are processed, like @mattcaswell said.  In particular, look at the context of https://github.com/openssl/openssl/blob/master/apps/cms.c#L710 and see when it is done.

For the third time :) look at how CMS does it -- after all options are processed, like @mattcaswell said. In particular, look at the context of https://github.com/openssl/openssl/blob/master/apps/cms.c#L710 and see when it is done.

For the third time :) look at how CMS does it -- after all options are processed, like @mattcaswell said. In particular, look at the context of https://github.com/openssl/openssl/blob/master/apps/cms.c#L710 and see when it is done.

Oh, thanks, I try to correct it and test.

The commit message needs an edit, it shouldn't have Fix #15285 in the subject line (the first line).  Changing it this is better:
openssl req checking digest

Fixes #15285

CLA: trivial

CLA: trivial would be also wrong. This is not within what is acceptable for CLA: trivial change.

The commit message needs an edit, it shouldn't have Fix #15285 in the subject line (the first line). Changing it this is better:
openssl req checking digest

Fixes #15285

CLA: trivial

Thanks

CLA: trivial would be also wrong. This is not within what is acceptable for CLA: trivial change.

I have provide my CLA files via e-mail, should I remove this mark for trivial change?

Yes, please

2021 4:55, 4:55, luxinyou @.***> napsal/a:

CLA: trivial would be also wrong. This is not within what is
acceptable for CLA: trivial change.

I have provide my CLA files via e-mail, should I remove this mark for
trivial change?
--
You are receiving this because you commented.
Reply to this email directly or view it on GitHub:
https://github.com/openssl/openssl/pull/15362#issuecomment-846339172

I want to know what's wrong with this pull request, should I do something for it?

I believe that it's currently waiting for code review from the project members.  Two reviews are necessary, at least one of which must be from an OTC member.
Unfortunately, developer energy is almost entirely focused on the forthcoming 3.0.0 release at the moment (which is subject to an external deadline for getting FIPS validation), so it may be a couple months before the required review occurs.
But, to be clear: there is not currently anything you need to do for it -- when code review happens, there may be comments that require you to make changes to the PR, but not right now.

There is actually something that needs to be done here. The commit message still contains the CLA: trivial and that is wrong. This is not within the limits of changes acceptable for CLA: trivial. Please amend the message with git commit --amend and force-push.

There is actually something that needs to be done here. The commit message still contains the CLA: trivial and that is wrong. This is not within the limits of changes acceptable for CLA: trivial. Please amend the message with git commit --amend and force-push.

I removed CLA remarks and I have submitted CLA but the cla-check still not pass.

It is possible that the wrong author email is set on your commits.
It's also possible we missed your CLA: send an email to<EMAIL_ADDRESS>with your details and I'll check.

It is possible that the wrong author email is set on your commits.
It's also possible we missed your CLA: send an email to<EMAIL_ADDRESS>with your details and I'll check.

Oh, I mistook email as<EMAIL_ADDRESS>I resend again.

It is possible that the wrong author email is set on your commits.
It's also possible we missed your CLA: send an email to<EMAIL_ADDRESS>with your details and I'll check.

Oh, I mistook email as<EMAIL_ADDRESS>I resend again.

I send CLA files to<EMAIL_ADDRESS>but it's not reachable. The  guide show me email-address with<EMAIL_ADDRESS>

It's meant to be<EMAIL_ADDRESS>my mistake there.

It's meant to be<EMAIL_ADDRESS>my mistake there.

I have just send CLA files. I wanna to get reply if these files can works.

Your CLA files didn't arrive here.  @levitte any idea?

My colleague<EMAIL_ADDRESS>has commit CCLA files . Should recheck cla ?

Your colleague has sent us the CCLA, and we have you listed on it. However all developers also need an ICLA. Your colleague has done so for themselves but I don't see one for you.

This PR has the label 'hold: cla required' and is stale: it has not been updated in 30 days. Note that this PR may be automatically closed in the future if no CLA is provided.  For CLA help see https://www.openssl.org/policies/cla.html

Closing as #15285 was already closed.


UI Issue in company list table

Describe the bug

There is no any tool tip on service count so user can know that he can add service from here.
The same things in change manager so user don't get idea about he can change manager
The same things in auto billings

Expected behavior
There should be tool tip on hover so user can understand what action can he do on that place
Screenshots
If applicable, add screenshots to help explain your problem.

change manager title not possible  => Already Ek Title bind


Add column container paragraph and link media items

Summary
This PR includes two separate changes to eCMS paragraphs. It adds a column container paragraph which allows other paragraphs to be referenced. It also adds linking to media items.
Metadata

Question
Answer

Did you use a meaningful pull request title?
yes

Did you apply meaningful labels to the pull request?
yes

Did you perform a self review first?
yes

CHANGELOG reflects changes?
yes

Did you perform browser testing?
no

Risk level
Low

Relevant links

Ok all good!
/approved


Revert "Update to nunit3 as appveyor is upgraded"

Reverts Microsoft/SparkCLR#136

Hi @rapoth, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

It looks like you're a Microsoft contributor (Rahul Potharaju). If you're full-time, we DON'T require a Contribution License Agreement. If you are a vendor, please DO sign the electronic Contribution License Agreement. It will take 2 minutes and there's no faxing! https://cla.microsoft.com.

TTYL, MSBOT;

Looks like the previous PR has some problems. Will revert until that is fixed.


Larger density map area

Fantastic tool, thank you! Is there a way to make the density map box larger? I'm forced to pan around a lot since it's quite small.

try ] and [ on keyboard

Wow, thank you! I have trouble reading the help :)
Also found where to change the default setting for users.
Thanks again for your quick response and wonderful tool!


WIndows compatibility?

Are the non-networking parts compatible with windows?

I haven't tried and I don't have any plans on supporting windows.  You're welcome to give it a go though.

could you add some cmake option so to not compile networking stuff?

(a dependency-free build in a sense)

https://gitlab.com/niansa/libcrosscoro
Like this fork I make, but as a cmake option

probably would be a good idea to extract the io_scheduler poll functionality into a pimpl style pattern or something that could be instantiated per platform?  That seems like an ideal architecture so more platforms could theoretically be implemented

Yeah. I agree


[FEATURE] Just an heartfelt THANKS !!!!!

Thanks a lot from Rome - Italy

Thank you 😁 . I'm really glad you like the library and are finding it useful 🎉


Improve DictionaryToTable type annotation

Improved type definition for DictionaryToTable that represents better the inputs/outputs of the function. Note that Array<> is not recognized as an interface in the package for some reason, but {[index: number]: A} basically means the same.
As I saw, this was already patched in v2.0.0, but in older versions (latest available version for roblox-ts: 1.9.10) an incorrect type annotation for DictionaryToTable causes the compiler to error. In any case, this type annotation should be better than just marking unknown as the input.

Forgot to sign the commit 😞, here's the good one #37.


A console.log in AppComponent is called 3 or 4 times on the server

I'm submitting a ...  (check one with "x")
[x] bug report => check the README and search github for a similar issue or PR before submitting
[ ] support request => check the README and search github for a similar issue or PR before submitting
[ ] feature request

Current behavior

When adding console.log('test') in the constructor of AppComponent file, the server is logging it 3 or 4 times.
Minimal reproduction of the problem with instructions

Add a random console.log in AppComponent
npm run build:universal-dev
npm run serve
Load the page at localhost:8000

Angular version: 4.1.0

This was mainly due to the fact that Chrome is trying to get the favicon.ico even if it is not referenced. I used npm serve-favicon library to fix this.


fontAliasing antialiased doesn't work for canvas terminal

Version: 1.40.0
Commit: 86405ea23e3937316009fc27c9361deee66ffbf5
Date: 2019-11-06T17:09:34.601Z
Electron: 6.1.2
Chrome: 76.0.3809.146
Node.js: 12.4.0
V8: 7.6.303.31-electron.0
OS: Darwin x64 18.2.0
I set antialiased font and canvas terminal as below, It doesn't work for the canvas terminal
  "workbench.fontAliasing": "antialiased",
  "terminal.integrated.rendererType": "canvas",

When I change canvas to dom, it looks working well.
canvas terminal, antialiased doesn't work:

dom terminal,  antialiased works:

You could see the difference. And antialiased has no effect on canvas terminal.

Tracked in https://github.com/xtermjs/xterm.js/issues/2464
/duplicate


LDAP groups do not work for connection/tree and other permission checks

When using AUTH_LDAP_FIND_GROUP_PERMS=True, groups are not mirrored, but "virtually" assigned to user. This works in standart Django but check's in custom django-rules do not work, because logic of checking by groups uses "user.groups" and it is not populated.
Need to add additional check for LDAP groups in django-rules

Fixed in 59617ae4c601c1cbfd4c01f7946db8ea7fb9eb7d


Feature/sdl 0293 enable oem exclusive apps support

Implementation of https://github.com/smartdevicelink/sdl_evolution/blob/master/proposals/0293-vehicle-type-filter.md
Just for review
This PR will be redirected to smartDeviceLink organization after the revision will be accepted

Moved to smartdevicelink


Update Gallery with new Cookbook

'  - cookbook-template'

<!-- Feel free to add comments below this line -->

Just a test

Unsure what I have wrong in the GitHub actions. Feel free to take a look @dcamron @ktyle - I won't be able to focus on this tomorrow as i prepare for the tutorial.

So, first of all, I think you need to look at the issue template.  You are using the issue_template.md format, which should work, but it not recommended these days because of the power of the new YAML format.  You can create a issue_template.yaml and follow the formatting described in the GitHub docs here for how to fill out the YAML file.
However, it you just look at the issue_template.md file, it seems malformed.  Remember that this is a markdown file.  The top section between the --- markers is called YAML Front Matter, and everything between the --- needs to be valid YAML syntax.  However, there can only be 1 YAML Front Matter section, and there are 2 sections in the template.  Not sure why.  (To learn about what parameters can be set in the YAML Front Matter, read the GitHub docs here.)
After the YAML Front Matter section, all --- markers will be rendered as horizontal lines, which you can see displayed in the comment of this issue above.
The - [repo-root-name] text is encapsulated in single quotes ', which prevents the - from rendering as a a bullet...not sure if that was intentional, but it also displays the single quotes, which I'm sure was not intentional.
Then there is an extraneous triple backtick ``` that causes the rest of the template to be rendered as a code/raw block, which is why the HTML comment is displayed in the markdown, rather than being hidden from view.  I'm not sure that was intentional, either.
And that's my review of the issue template itself.

Thanks @kmpaul that is a great place to start. I won't be able to delve into this until Friday most likely.


Rounded square app icon

Please change back to the former rounded square icon.

Please change back to the former rounded square icon.

I also demand this make the icon adaptive.

Duplicate of #40. Please close.


Investigate 6.0 SDK missing file: shared/Microsoft.NETCore.App/6.0.0/.version

In the Microsoft-built SDK, this file contains the commit hash on the first line and then the version number on a second line. I don't think anyone uses it (it's just informational) but it would be good to fix this diff if it's a small thing.
https://github.com/dagood/source-build/pull/9#discussion_r734897814

Closing as a patch was added in source-build and was backported to runtime.


TextBox: non default aligned text selection issue

When TextBox.TextAlignment is set to Center or Right and I try to apply text selection the rendering becomes very strange.

I still sees issues related to text alignments

In commit bc3d6ec8 still having problem with selected text for CenterAllignment and RightAllignment.
I have a fix which looks like crutch. In Avalonia.Skia.FormattedTextImpl, method Draw, after string "float x = TransformX(origin.X, 0, paint.TextAlign);" add this:
if (paint.TextAlign != SKTextAlign.Left)
{
    var measure = paint.MeasureText(Text);

    x -= paint.TextAlign == SKTextAlign.Center
        ? measure / 2
        : measure;

    paint.TextAlign = SKTextAlign.Left;
}

I think problem in canvas.DrawText, when using several brushes

Hello everyone! I work with Avalonia 0.10.18 and I face the problem with the text selection behaviour when TextAlignment is set to Center. I cannot change the version. How can I fix this bug?

@DmytroProg please do not answer closed issues.
Meanwhile I highly suggest trying to upgrade to 11.0. Make sure to read upgrade guide carefully.


redpanda: 23.1.1 -> 23.1.3

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/redpanda-data/redpanda/releases.
meta.description for redpanda is: Redpanda client
meta.homepage for redpanda is: https://redpanda.com/
Updates performed

Golang update

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact

Checks done (click to expand)

built on NixOS
The tests defined in passthru.tests, if any, passed
found 23.1.2 with grep in /nix/store/q47n0b1x93lxkkyffqlpmr9gpiw8msfq-redpanda-rpk-23.1.2
found 23.1.2 in filename of file in /nix/store/q47n0b1x93lxkkyffqlpmr9gpiw8msfq-redpanda-rpk-23.1.2

Rebuild report (if merged into master) (click to expand)

2 total rebuild path(s)

2 package rebuild(s)

First fifty rebuilds by attrpath
redpanda
redpanda-server

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/q47n0b1x93lxkkyffqlpmr9gpiw8msfq-redpanda-rpk-23.1.2 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A redpanda https://github.com/r-ryantm/nixpkgs/archive/42fd220d6102bee72593d7602058ace34d522a8a.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/q47n0b1x93lxkkyffqlpmr9gpiw8msfq-redpanda-rpk-23.1.2
ls -la /nix/store/q47n0b1x93lxkkyffqlpmr9gpiw8msfq-redpanda-rpk-23.1.2/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

1 package failed to build:

redpanda-server

1 package built:

redpanda

Maintainer pings
cc @avakhrenev @happysalada for testing.

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/redpanda-data/redpanda/releases.
meta.description for redpanda is: Redpanda client
meta.homepage for redpanda is: https://redpanda.com/
Updates performed

Golang update

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact

Checks done (click to expand)

built on NixOS
The tests defined in passthru.tests, if any, passed
found 23.1.3 with grep in /nix/store/4b96lg3hqvx58r2ydk9g3nnjxnf2q8zp-redpanda-rpk-23.1.3
found 23.1.3 in filename of file in /nix/store/4b96lg3hqvx58r2ydk9g3nnjxnf2q8zp-redpanda-rpk-23.1.3

Rebuild report (if merged into master) (click to expand)

2 total rebuild path(s)

2 package rebuild(s)

First fifty rebuilds by attrpath
redpanda
redpanda-server

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/4b96lg3hqvx58r2ydk9g3nnjxnf2q8zp-redpanda-rpk-23.1.3 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A redpanda https://github.com/r-ryantm/nixpkgs/archive/56376c515a7bb0d1b7f42ff69ab006f87458de8b.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/4b96lg3hqvx58r2ydk9g3nnjxnf2q8zp-redpanda-rpk-23.1.3
ls -la /nix/store/4b96lg3hqvx58r2ydk9g3nnjxnf2q8zp-redpanda-rpk-23.1.3/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

1 package failed to build:

redpanda-server

1 package built:

redpanda

Maintainer pings
cc @avakhrenev @happysalada for testing.


Using external configuration system with sacred experiment logging

How can I use an external configuration framework (example https://github.com/google/gin-config) with sacred's experiment logging?
I think of Sacred as two components: Experiment logging + Configuration framework. Is this a wrong way to think about it? Is sacred modular enough to easily accept different configuration framework? If not, what's a roadmap to do such refactoring? What protocols should the configuration framework obey to allow to be used with Sacred?

I think that you can currently use sacred with gin-config. It might not be straightforward through. If you want to take a look at the future API, see #623. We're aiming at being more modular and less magical (quite the opposite of gin-config). It's work in progress, but the more we advance, the easier it will be to integrate sacred with other frameworks.

I don't know anything about gin-config, but if it gives access to the config as a dict you can simply add the config with ex.add_config(constructed_config) to the experiment (outside of ex.main) or pass it as an argument to ex.run like ex.run(config_updates=constructed_config). The second one might raise an error if no default values are present for the passed config.

The API proposals in https://github.com/gabrieldemarmiesse/sacred/blob/document_for_config_v2/config_v2.md look great. I think we should make use of functools.partial available in python. It is a consistent and pythonic way of overriding default function arguments which is consistent with inspect.signature.
I can create a pull request if you like the idea.
import sacred
from sacred.config import Config, get_default_args, partial_from_dotted_config

from functools import partial

def load_dataset(dataset_size, crop_size=(30, 30), random_flip=True):
    ...

def my_main_function(batch_size=32, dataset_size=10_000, nb_epochs=50, load_dataset_configured=load_dataset):
    """
    The load_dataset should have the right kind of argument set already
    """
    # main experiment here
    my_dataset = load_dataset_configured(dataset_size)
    ...

def main_with_config_change(my_main_function):
    # Give users the tools but let them decide how to change the config
    config = get_default_args(my_main_function)
    config.load_dataset_configured = dict(crop_size=(50, 50), random_flip=False)
    config.dataset_size = 700
    # This can be replaced by another utility function like partial_from_config
    return partial(my_main_function,
                         load_dataset_configured=partial(load_dataset, **vars(config.load_dataset_configured))
                         **vars(config))

def main_with_config_change_style_2(my_main_function,
                                            dotted_config={"dataset_size" : 700,
                                                                     "load_dataset_configured.crop_size":  (50, 50),
                                                                     "load_dataset_configured.random_flip": True}):
       # The dotted config can come from json or any other external config storage or GIN etc.
       return partial_from_dotted_config(my_main_function, dotted_config)

default_config.add_potential_modifications(main_with_config_change)
default_config.add_potential_modifications(main_with_config_change_style_2)

ex = sacred.Experiment('my_pretty_experiment')
ex.add_config(default_config)
ex.automain(my_main_function)


⚠ Bofrost.be has degraded performance

In 90fa892, Bofrost.be (https://www.bofrost.be) experienced degraded performance:

HTTP code: 200
Response time: 1288 ms

Resolved: Bofrost.be performance has improved in ed86a8b.


(Share) Extension Compatibility

Description
This Library is not currently compatible with a Share Extension Target
What type of issue is this?

[x] bug
[x] enhancement (feature request)
[ ] question
[ ] documentation related
[ ] testing related
[ ] discussion

Requirements

[x] I've read and understood the Contributing guidelines and have done my best effort to follow them.
[x] I've read and agree to the Code of Conduct.
[x] I've searched for any related issues and avoided creating a duplicate issue.

Bug Report
Building this library against a share extension target fails and results in the following Swift Compiler Error:
PanModalPresentable+LayoutHelpers.swift:37:30: 'shared' is unavailable in application extensions for iOS: Use view controller based solutions where appropriate instead.
return UIApplication.shared.keyWindow?.rootViewController?.bottomLayoutGuide.length ?? 0

Reproducible in:
PanModal version: 1.2.6
iOS version: 13.3
Steps to reproduce:

Add Library as a CocoaPods (or other) dependency to a Share Extension Target
Build / Run the Share Extension
Swift Compiler Error is given

Expected result:
Compatibility with Share Extension context (not dependent on UIApplication).
Unclear at the moment how crucial the UIApplication.shared.keyWindow is to the functionality of this Library
Actual result:
Swift Compiler Error
Attachments:

Hi @james-ff
Thanks for reporting & apologies for the delay. This should be fixed by https://github.com/slackhq/PanModal/pull/81 - feel free to re open this issue if it doesn't.