isBulk option not used

I'm trying to figure out what exactly isBulk option does.
I see that it's passed on to loggly.createClient, but loggly does not use the isBulk option..
I did notice, however, that the loggly client accepts an array of log messages, and then sends them to the bulk endpoint from the Loggly api. Would it be possible to buffer winston message, and then pass them as an array to the loggly client?
I'm asking this because I saw a big hit to performance when using winston-loggly in production, and I'm guessing because it's sending each message individually (including 6,000 - 8,000 access logs per minute, and some multiple of that in other application logs).

I'm curious about this as well. If you look at Loggly's documentation for setting up nodejs it makes no mention of winston-loggly. It only tells you to use Loggly's own fork of this package called winston-loggly-bulk.
My guess is that Loggly is forcing the bulk option for the exact performance reasons you mentioned.
@eschwartz did you make any progress on this?

Here's an update straight from Loggly themselves: https://github.com/winstonjs/winston-loggly/issues/6#issuecomment-229098530
They added bulk support to deal with memory issues and sending so many individual requests.


Check if executing in Jupyter/IPython

References:

https://discourse.jupyter.org/t/find-out-if-my-code-runs-inside-a-notebook-or-jupyter-lab/6935/6

Implemented with: 94e75807ba58b18351a1096a96b1cfdc13d7aa35


Switch to default tier

@djosborne just confirming - we don't need to fix this for v1.6 - this is only an issue for when we switch to golang felix?


Multiple Drawers

The challenge is to create a screen with a main drawer on the left side, and a context drawer on the right side.
When I trigger this.props.navigation.navigate('DrawerOpen') according documentation, the right (context) drawer is opened. It's ok, but how I open the left (main) drawer?
Is possible to change the value of 'DrawerOpen' to the main drawer as 'MainDrawerOpen'? According this line of DrawerNavigator.js, I think this is not possible. Right?
Do I need to create a Custom Navigator for that?
Thanks.

is this similar to #780  ??

Yes @sigmazen.

@sigmazen in your case, you don't have 2 drawers for the same view. How can I do if I want 2 drawers, one for the navigation and the second to display a contextual action bar.
Thanks.

@udarts I use react-native-side-menu for my right drawer and react-navigation for my left drawer.

Thanks, I had that one installed, but haven't used it, will do now.

the discussion here might be help for you folks: https://github.com/react-navigation/react-navigation/issues/4440

@BenoitClaveau I have tried to use react-native-side-menu, it works, but it is very slow in opening the side bar.


Adding hurricane for raid

Added the "Rock You Like a Hurricane" sound byte and updated the messages.js file to play that sound during a raid rather than goodbadugly.mp3


Heats up smart fridge

I tried running this code on my smart fridge which runs on Windows but it ended up crashing and then all of my ice cream has melted.

I feel better after having a glance of the issue...

I am running my unit tests to confirm if this is contributing to global warming


TypeError in examples/real-world UserPage.js

Do you want to request a feature or report a bug?
bug
What is the current behavior?
While running examples/real-world updating the route causes a TypeError to be raised.
If the current behavior is a bug, please provide the steps to reproduce and if possible a minimal demo of the problem via https://jsfiddle.net or similar.
Run the real-world example dev server via npm start and load a username or repo, then click on any of the repos or usernames to change the route - triggering a UserPage.componentDidUpdate.
A TypeError will be raised at https://github.com/reduxjs/redux/tree/691b9e4f2a4d68ae5f3f4d48b4c944a04877e304/examples/real-world/src/containers/UserPage.js#L35.
What is the expected behavior?
Not raise any error and load either the user's repos or a repo's users.
Which versions of Redux, and which browser and OS are affected by this issue? Did this work in previous versions of Redux?
react: 16.3.1
redux: 3.7.2
Did it work in prev versions? Not tested, but assuming - no.
Suggested change to real-world/src/containers/UserPage.js:

  componentDidUpdate(prevProps) {
    if (prevProps.login !== this.props.login) {
-      loadData(this.props.login)
+      loadData(this.props)
    }
  }

Can you submit a PR to fix?

@timdorr  https://github.com/reduxjs/redux/pull/3220


WIP : default configs for new network in bridge driver

This fix provides seamless connectivity for the newly created network using Bridge driver.
We should not be forcing the user to pass these default configuration for each bridge being created.
Also fixed a minor bug in client to choose bridge as the default driver
Signed-off-by: Madhu Venugopal<EMAIL_ADDRESS>

ping @aboch @mrjana

@aboch ptal.

LGTM

This is still WIP PR. pushing a simple patch based on @mrjana comment on static defaults rather than default network based configs. But it affects some api tests. pushing the patch anyways to have a discussion on it.

Let me look into the api test, why it is failing.

You should no longer encounter the issue after #239 is merged.

@aboch @mrjana with #239 merged, the tests passes now. PTAL

@mrjana you are right. have changed it to set default values first and then call the method to parse the options. reads much better. PTAL

LGTM

LGTM


undefined: build.AllowVendor

When I try and go get
Chriss-Air:mockingjay-server quii$ go get honnef.co/go/unused/cmd/unused
# golang.org/x/tools/go/buildutil
../../../golang.org/x/tools/go/buildutil/buildutil_go16.go:14: undefined: build.AllowVendor

One problem is you have an outdated dependency.
Try:
go get -u honnef.co/go/unused/cmd/unused

The -u flag causes go get to to update all dependencies.
That should help, but may not completely resolve your issue. If you're still having issues after above, it might be because you have an outdated version of Go installed. What does go version print? If it's something less than go1.6, you should update to Go 1.6, the current stable release of Go. https://golang.org/doc/install

I'll close this issue. shurcooL is right about an outdated dependency, so there's nothing here for us to do.


Update for PyTorch 2 and Geometric 2.2

Pull Request
Description
Please delete the italicised instruction text!
Please include a summary of the change and which issue is fixed.
Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes #
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.
Please also list any relevant details for your test configuration

[ ] Yes

If your changes affect data processing, have you plotted any changes? i.e. have you done a quick sanity check?

[ ] Yes

Checklist:

[ ] My code follows OCF's coding style guidelines
[ ] I have performed a self-review of my own code
[ ] I have made corresponding changes to the documentation
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] I have checked my code and corrected any misspellings

Note: PyTorch Geometric doesn't have PyTorch 2 support yet apparently, so will have to wait, will add the code now to test so as soon as its available it will work.


[Need help]: IO port is missing a buffer

When i run implementation, I encountered the following errors. I really want to find out your project but I'm very new to this, and I'd really appreciate your help to solve them.
Starting DRC Task
INFO: [DRC 23-27] Running DRC with 8 threads
ERROR: [DRC INBB-3] Black Box Instances: Cell 'inst_dynamic/inst_user_wrapper_0' of type 'design_user_wrapper_0' has undefined contents and is considered a black box.  The contents of this cell must be defined for opt_design to complete successfully.
ERROR: [DRC RPBF-1] IO port is missing a buffer: Device port dyn_bscan_bscanid_en should be connected to an IO cell such as an [IO]BUF*.
ERROR: [DRC RPBF-1] IO port is missing a buffer: Device port dyn_bscan_capture should be connected to an IO cell such as an [IO]BUF*.
ERROR: [DRC RPBF-1] IO port is missing a buffer: Device port dyn_bscan_drck should be connected to an IO cell such as an [IO]BUF*.
ERROR: [DRC RPBF-1] IO port is missing a buffer: Device port dyn_bscan_runtest should be connected to an IO cell such as an [IO]BUF*.
ERROR: [DRC RPBF-1] IO port is missing a buffer: Device port dyn_bscan_sel should be connected to an IO cell such as an [IO]BUF*.
ERROR: [DRC RPBF-1] IO port is missing a buffer: Device port dyn_bscan_shift should be connected to an IO cell such as an [IO]BUF*.
ERROR: [DRC RPBF-1] IO port is missing a buffer: Device port dyn_bscan_tdo should be connected to an IO cell such as an [IO]BUF*.
ERROR: [DRC RPBF-1] IO port is missing a buffer: Device port m_axis_dyn_out_0_tdata[0] should be connected to an IO cell such as an [IO]BUF*.

ERROR: [DRC RPBF-1] IO port is missing a buffer: Device port m_axis_dyn_out_0_tdata[183] should be connected to an IO cell such as an [IO]BUF*.
INFO: [Common 17-14] Message 'DRC RPBF-1' appears 100 times and further instances of the messages will be disabled. Use the Tcl command set_msg_config to change the current settings.
INFO: [Project 1-461] DRC finished with 4148 Errors
INFO: [Project 1-462] Please refer to the DRC report (report_drc) for more information.
ERROR: [Vivado_Tcl 4-78] Error(s) found during DRC. Opt_design not run.

Time (s): cpu = 00:00:03 ; elapsed = 00:00:02 . Memory (MB): peak = 7068.531 ; gain = 0.000 ; free physical = 48516 ; free virtual = 55234
INFO: [Common 17-83] Releasing license: Implementation
128 Infos, 199 Warnings, 9 Critical Warnings and 102 Errors encountered.
opt_design failed
ERROR: [Common 17-39] 'opt_design' failed due to earlier errors.

Please provide us with more detail on what you are actually trying to do. We cannot help you with this little information.


Name Reset to default

Since I am on version 0.6 the names I give to the datapoints are constantly reset to the default value. In the old version this was not the case.

This only happens if you change the created zone.

No I have not adjusted anything.

Please describe the scenario when exactly a reset happens to you. At the moment I can't see why.

Hmm okay.
I updated to the 0.6 version because of reconnect problems. After upgrading this problem was fixed. But the custom names are gone. So I edited all entry's. But after some time. Maybe 1 day the custom names of the milight devices are resetted to default. At this time I tryed to set the custom names several times without positive result

You must have changed one zone somehow. The adapter does not change any states by itself. Go there and uninstall all instances and also the adapter and then put on again.


Test 2653 (NFS) fails on ipv6 lane, VM stuck on scheduling

/kind bug
Please see suggested possible solution at the end.
What happened:
Using PR #3221 (ipv5 migration fix) , and PR #3171
(both arent merged yet right now)
testing ipv6 lane , test_id 2653
VM fails to schedule
describing the virt-launcher pod gives this event
Mounting command: systemd-run
Mounting arguments: --description=Kubernetes transient mount for /var/lib/kubelet/pods/7dccb5f8-a4ae-4227-bade-4ed1343df2f2/volumes/kubernetes.io~nfs/test-nfssfsn9f6rj5r44svhp6ljnr2nhr8q5xx2vdwwxsbtx4gwzcj8 --scope -- mount -t nfs fd00:10:244:0:1::e:/ /var/lib/kubelet/pods/7dccb5f8-a4ae-4227-bade-4ed1343df2f2/volumes/kubernetes.io~nfs/test-nfssfsn9f6rj5r44svhp6ljnr2nhr8q5xx2vdwwxsbtx4gwzcj8
Output: Running scope as unit: run-rf4a661c741b741c8a10cb6b9cd4524f8.scope
mount: /var/lib/kubelet/pods/7dccb5f8-a4ae-4227-bade-4ed1343df2f2/volumes/kubernetes.io~nfs/test-nfssfsn9f6rj5r44svhp6ljnr2nhr8q5xx2vdwwxsbtx4gwzcj8: bad option; for several filesystems (e.g. nfs, cifs) you might need a /sbin/mount.<type> helper program.
  Warning  FailedMount  17s  kubelet, kind-1.17.0-worker  MountVolume.SetUp failed for volume "test-nfssfsn9f6rj5r44svhp6ljnr2nhr8q5xx2vdwwxsbtx4gwzcj8" : mount failed: exit status 32

test fails because VM doesnt get Running state
• Failure [229.328 seconds]
[rfe_id:393][crit:high][vendor:cnv-qe@redhat.com][level:system] VM Live Migration
/root/go/src/kubevirt.io/kubevirt/tests/migration_test.go:62
  Starting a VirtualMachineInstance
  /root/go/src/kubevirt.io/kubevirt/tests/migration_test.go:347
    with an Fedora shared NFS PVC, cloud init and service account
    /root/go/src/kubevirt.io/kubevirt/tests/migration_test.go:847
      [test_id:2653]  should be migrated successfully, using guest agent on VM [It]
      /root/go/src/kubevirt.io/kubevirt/tests/migration_test.go:876

      Timed out after 180.000s.
      Timed out waiting for VMI testvmi5p754bzlhss9v696lsh2b7xjrd99rl8xdpx8nkz9d52zxxlz to enter [Running] phase(s)
      Expected
          <v1.VirtualMachineInstancePhase>: Scheduling
      to be an element of
          <[]interface {} | len:1, cap:1>: [["Running"]]

      /root/go/src/kubevirt.io/kubevirt/tests/utils.go:2507
------------------------------

What you expected to happen:
test should pass, or at least the VM should be running
How to reproduce it (as minimally and precisely as possible):
FUNC_TEST_ARGS=" -ginkgo.v --ginkgo.focus=test_id:2653" make functest
make sure you have the PRs mentioned above (assuming 3171 is needed)
Note:
i had this problem on real machine once
solution was to install  nfs-utils
thanks to Yaniv L

Is the test working on a kind setup with IPv4?

Other kinds we have is sriov, where migration isnt supported
and just after this issue was opened, Quique added new kind provider which is IPv4
but i believe the root cause is written above and the solution
need to install nfs-utils so i doubt it would work on ipv4.
Also kind must have unique UUID which we fixed only on ipv6 atm, and need to fix for the other kinds as well


Add University of Windsor

@parham-box I have to close this request without merging, because you requested to add a non-existent domain to this repository: Host uwindosr.ca not found: 3(NXDOMAIN) Please ensure that you are familiar with this repository rules located at the bottom of this page and submit a new request with the correct information. Thank you for your understanding!


No longer works

Hi,
I LOVE this software. It really saved me a lot of rage at Windows total lack of empowerment of the user to have a say over when an app can interrupt and distract you.
I downloaded it a few months ago and set it to run at startup. Worked great. However, as of maybe a month ago, it stopped working. Maybe due to a Microsoft update?
I get the following error message now when running it:

Of course, I'm not paying anything for this great script. But if the developer was to upgrade it, it would really make my life a lot nicer! Thanks.

Yup, I noticed this. I'm going to fix this when I have time.
Since the last change, there is no more space above the patched function in the explorer.exe memory so I have to come up a new way to patch this.

Works again! Got the 1809 working in Hyper-V so I could fix this.


ErrorException in /var/www/core/shared/vendor/doctrine/dbal/lib/Doctrine/DBAL/Driver/PDOConnection.php:43

Error in VATSIM-UK/Core
ErrorException in /var/www/core/shared/vendor/doctrine/dbal/lib/Doctrine/DBAL/Driver/PDOConnection.php:43
PDO::__construct(): MySQL server has gone away
View on Bugsnag
Stacktrace
/var/www/core/shared/vendor/doctrine/dbal/lib/Doctrine/DBAL/Driver/PDOConnection.php:43 - Illuminate\Foundation\Bootstrap\HandleExceptions::handleError

View full stacktrace

Any chance you can have a look at this, please @NFarrington?

Caused by a DB reboot, closed.

An error linked to this issue has been reopened in Bugsnag
PDOException in /var/www/core/shared/vendor/doctrine/dbal/lib/Doctrine/DBAL/Driver/PDOConnection.php:43


record server received request header/cookie

Codecov Report

Merging #6893 into master will increase coverage by 0.00%.
The diff coverage is 26.22%.

@@           Coverage Diff           @@
##           master    #6893   +/-   ##
=======================================
  Coverage   39.33%   39.34%
=======================================
  Files        3207     3207
  Lines       94677    94734   +57
  Branches    11848    11859   +11
=======================================
+ Hits        37240    37270   +30
- Misses      54453    54476   +23
- Partials     2984     2988    +4

Impacted Files
Coverage Δ

...ootstrap/plugin/request/ServerRequestRecorder.java
38.20% <18.51%> (-30.37%)
:arrow_down:

...quest/ServletRequestListenerInterceptorHelper.java
63.76% <85.71%> (+1.64%)
:arrow_up:

...nitor/DefaultDataSourceMonitorRegistryService.java
77.77% <0.00%> (-11.12%)
:arrow_down:

...navercorp/pinpoint/rpc/common/SocketStateCode.java
82.92% <0.00%> (-2.44%)
:arrow_down:

...point/rpc/client/DefaultPinpointClientHandler.java
70.77% <0.00%> (-1.30%)
:arrow_down:

...ercorp/pinpoint/profiler/util/ThreadDumpUtils.java
62.12% <0.00%> (+1.51%)
:arrow_up:

...m/navercorp/pinpoint/web/util/ThreadDumpUtils.java
35.23% <0.00%> (+1.90%)
:arrow_up:

...itor/metric/deadlock/ThreadDumpMetricSnapshot.java
70.58% <0.00%> (+2.35%)
:arrow_up:

...tor/metric/datasource/DefaultDataSourceMetric.java
78.12% <0.00%> (+3.12%)
:arrow_up:

...rc/main/java/com/navercorp/pinpoint/test/Item.java
73.33% <0.00%> (+3.33%)
:arrow_up:

... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 43c880b...76bc916. Read the comment docs.


feat: redistribution status

Checklist

[ ] I have read the coding guide.
[ ] My change requires a documentation update, and I have done it.
[ ] I have added tests to cover my changes.
[ ] I have filled out the description and linked the related issues.

Description
Closes #3675
Open API Spec Version Changes (if applicable)
4.0.0 to 4.1.0

This change is

@istae, I have updated the fee using the transaction by the hash method.


Add a small tub under paraformaldehyde to segregate solids from liquids in case of a spill

I placed the paraformaldehyde that is ours in its own container. The large jug of formaldehyde is still in the hood because I can't find room for it in the cabinet.

Nice! Thanks! Closing. We'll have EH&S pick up the paraformaldehyde.


Get your Sh*t together and please fix this freaking sync mess....

So it seems that by "brilliant and ingenious" development now there are 4 main problems that the devs created by themselves....
1 - obvious performance issues that are plaguing this fork since the introduction of staking mechanism. The more you have plots the bigger are the problems and they seem to increase exponentially causing problems even on modern CPUs IF enough plots are present (7-8k +). For a RaspberryPi Harvester to start choking it is enough to have 3000+.
2 port switch from 11xxx which was handled badly
3 certificate switch which again handled badly
4 restart of the fork / chain
Now besides the performance issues the 2-4 are creating the situation where 11xxx clients who overslept everything STILL try to connect to the newer clients.... but this is not the main issue. The main issue is that you have now literally THREE blockchains that run in parallel. 11xxx branch, 22xxx from before the restart and the 22xxx after the restart.
And now you see a problem where the "new 22xxx" branch is at 441.3xx height and has a lot of problems coming through, because some "idi0ts" on the "old 22xxx" are on 446.xxx and are literally poisoning the new 22xxx branch.
Can we PLEASE FINALLY get this done and fixed ?  Issue a new certificate and PREVENT all the OLD blockchain clients from poisoning the new chain ?

Really ! May be u can make version with control version node and don't connect to old/incompatibility nodes.

Really ! May be u can make version with control version node and don't connect to old/incompatibility nodes.

I am not the one who pre-farmed  1 Million SIT (so theoretically - the money for the development should be there).
I am not the one who ignores bugs for weeks and months and fails to address them. Need to say more?


&fnlFractalGain should be &fnlDomainWarpFractalGain

https://github.com/Auburn/FastNoiseLite/blob/8e296acf13e73ba3bc0cc1bc151dc9d95bed0c20/WebPreviewApp/main.cpp#L246
Slider is not functioning properly in the demo, I believe this line is meant to be &fnlDomainWarpFractalGain
Thanks!

Thanks, fixed with https://github.com/Auburn/FastNoiseLite/commit/93e86db66b3e43944bb493a99ecbdd6cd78676ff


Please Add Support for Wyze Video Doorbell Pro, GW_BE1

Is your feature request related to a problem? Please describe:
Getting persistent messages in logs, "[Wyze] Camera (Model: GW_BE1 (Mac: GW_BE1_xx (Name: Doorbell) not supported submit a request to https://github.com/jfarmer08/homebridge-wyze-smart-home/issues to have it added. If no issues are found"
Describe the solution you'd like:
Please add support for Wyze Video Doorbell Pro, GW_BE1
Describe alternatives you've considered:
None
Additional context:
Wyze Video Doorbell Pro

I second this, please add support for the Doorbell Pro.

The doorbell pro might be able to be supported in this plugin but in limited capacity.
On the other hand, I have been working on reverse engineering the doorbell pro so you can get your video feed outside of the wyze app ie in Homekit or some other bridge. I have completed the reversing part and am now working through integrating with repos like docker-wyze-bridge so that my work is easily accessible. My project is here: Cryze
@jfarmer08 do you have input on this or can we close this as out of scope? From what I can tell other cameras can be used in this plugin with limited functions like on/off or on/off according to detection state but the doorbell is fundamentally different in that there is no on/off state. The detection part might be possible to keep in this plugin but I would have to see if it is feasible and/or uses similar apis as the other cameras.

The doorbell pro might be able to be supported in this plugin but in limited capacity.
On the other hand, I have been working on reverse engineering the doorbell pro so you can get your video feed outside of the wyze app ie in Homekit or some other bridge. I have completed the reversing part and am now working through integrating with repos like docker-wyze-bridge so that my work is easily accessible. My project is here: Cryze
@jfarmer08 do you have input on this or can we close this as out of scope? From what I can tell other cameras can be used in this plugin with limited functions like on/off or on/off according to detection state but the doorbell is fundamentally different in that there is no on/off state. The detection part might be possible to keep in this plugin but I would have to see if it is feasible and/or uses similar apis as the other cameras.

I have not looked at the Pro version, so I am not sure what is available. This ticket should be in https://github.com/jfarmer08/wyze-api

Closed as the request should go in https://github.com/jfarmer08/wyze-api as noted by @jfarmer08
Feel free to reopen over there @dan0-gh to make sure this stays on the list of wanted features, thanks!


[WIP] Respond with 422 when trying to update server name

NVM, it seems like spurious errors. That or executing these tests in parallel is not ok because there might be some race condition between them (it can happen as they use the same server)


Flask failing to startup due to Jinja2 breaking change

This issue tracker is a tool to address bugs in Flask itself. Please use
Pallets Discord or Stack Overflow for questions about your own code.
Since Jinja2 version 3.1.0 was released yesterday, Flask is failing to startup.
Describe how to replicate the bug.
Run a basic flask app, it fails to start up with the following traceback:
Traceback (most recent call last):

  File "application.py", line 1, in <module>

    from flask import Flask, Response, jsonify, request

  File "/usr/local/lib/python3.8/site-packages/flask/__init__.py", line 14, in <module>

    from jinja2 import escape

ImportError: cannot import name 'escape' from 'jinja2' (/usr/local/lib/python3.8/site-packages/jinja2/__init__.py)

Describe the expected behavior that should have happened but didn't.
Application starts up successfully.
Pinning Jinja to 3.0.3 bypasses this issue for us for now, but there's a breaking change there somewhere that will need to be fixed in Flask itself.
Environment:

Python version: 3.8.8
Flask version: 1.1.2

Noticed that flask 2.0.x doesn't have this issue, but may want to backfix if Flask 1.1.x is still being supported with patch fixes

You are using an unsupported version of Flask, please update to the latest version if possible. Additionally, please use a tool like pip-tools to pin your dependencies and control when you get updates. Be sure to run your tests with deprecation warnings treated as errors so that you get notified of these types of changes early.

When installing your dependencies you just specify them without versions (in requirements.in) and then use pip-compile to build a requirements.txt with pinned version numbers.
Then those version numbers will stay until you do an explicit pip-compile -U to update the pinned versions (all at once) - and that that point you'd obviously test your application to make sure nothing is broken.
(When doing all this after the fact (ie now) you'll of course have a harder time because now you aren't at a point in time where you can't just use "latest version of everything" and not encounter problems.)

How can we keep using Flask==1.1.1? We have an entire app built on it that will take a significant time to refac for Flask 2.x.

As someone maintaining a large Flask-based project, I don't think it will take you a "significant time" to make it compatible with Flask 2.0, unless you are still on Python 2.7 of course..
Anyway, just pin Flask's transitive dependencies to older versions that still work...

You would pin to versions that were in use when you decided to pin to Flask 1.1.1. As stated, you'll need to do a bit of work (on all your dependencies, not just Jinja) to determine a working set.

As someone maintaining a large Flask-based project, I don't think it will take you a "significant time" to make it compatible with Flask 2.0, unless you are still on Python 2.7 of course..
Anyway, just pin Flask's transitive dependencies to older versions that still work...

How can I pin it to Jinja2==3.0.3? This is something that happens under the hood when Flask installs via requirements.txt into a docker container.

You need to add it as an explicit dependency

it works for me

You need to add it as an explicit dependency

I have done that, and it does not work, see reqs.txt here:
Jinja2==3.0.3
itsdangerous==2.0.1
Flask==1.1.1

Pip uninstall packages, then re-install worked for me

after pinning Jinja2 to 3.0.3, there encounter another error..
    from werkzeug.wrappers import BaseResponse ImportError: cannot import name 'BaseResponse' from 'werkzeug.wrappers'
and my requirements.txt is
Jinja2==3.0.3 Flask==1.1.2

after pinning Jinja2 to 3.0.3, there encounter another error..  from werkzeug.wrappers import BaseResponse ImportError: cannot import name 'BaseResponse' from 'werkzeug.wrappers' and my requirements.txt is Jinja2==3.0.3 Flask==1.1.2

Jinja2==3.0.3
werkzeug==2.0.2
Adding these 2 will resolve the issue
It worked for me

after pinning Jinja2 to 3.0.3, there encounter another error..
    from werkzeug.wrappers import BaseResponse
ImportError: cannot import name 'BaseResponse' from 'werkzeug.wrappers'

and my requirements.txt is
Jinja2==3.0.3 Flask==1.1.2

I ran into the exact same error today, does anyone know what is causing this issue?

after pinning Jinja2 to 3.0.3, there encounter another error..  from werkzeug.wrappers import BaseResponse ImportError: cannot import name 'BaseResponse' from 'werkzeug.wrappers' and my requirements.txt is Jinja2==3.0.3 Flask==1.1.2

Jinja2==3.0.3 werkzeug==2.0.2 Adding these 2 will resolve the issue It worked for me

using the above mentioned library versions did resolve this issue, but I am just curious as to what caused this error in the first palce

i am still having this issue with the latest version of Flask

You really aren't, as that has changed in the latest version.
Please ask for further help in the Discord or discussions on this repo.

Can you please stop introducing breaking changes in minor versions ?
And yeah, I know about the pamphlet about "SemVer will not save you", which by the way states the problem is people incorrectly using SemVer. Only the article talks about people doing it accidentally while you're doing it on purpose.


Set keyword flags on all events so those sharing a provider with telemetry do not fire unless tracing is enabled

Set keyword flags on all events so those sharing a provider with
telemetry do not fire unless tracing is enabled
PR Checklist

[x] Closes #10093
[x] I work here
[ ] Tests added/passed
[x] Documentation added in til.h about how keywords work and at the
only other site of keywords we define in the Host project tracing
files.

Detailed Description of the Pull Request / Additional comments
I initially thought that we would need to split providers here to
accomplish this... but @DHowett helped me realize that might be a lot of
additional metadata and bloat binary size. So with help from a friend
from fundamentals, I realized that we could use Keywords to
differentiate here. We can no longer define 0 keywords as that
represents an any/all scenario. Every TraceLoggingWrite event now
needs a keyword. When our events have a keyword, they're not included in
any trace. Additionally, when we have an explicit keyword to check that
is different from the ones used for the telemetry pipeline, we can
ensure that we only do "hard work" to generate debug trace data when an
"ALL" type listener like TraceView or Windows Performance Recorder with
our profiles is listening to these providers for ALL keyworded events.
Validation Steps Performed

[x] - Built with full release build config to confirm performance is
worse than dev builds BECAUSE of the telemetry event collector camping
our provider and triggering full trace event generation on shared
providers.
[x] - Built with full release build config to enable statistics
collection and validated trace event collection is excluded and trace
event short-circuits work with this change.
[ ] - Checked that TraceView still sees both telemetry and tracing
events
[ ] - Checked that WPR with our .wprp profile sees both telemetry and
tracing events

Bonuses:

Added privacy tagging where I noticed it was missing (so we no longer have to confirm those tags on the back end)
Updated wprp file for Terminal providers that are missing but didn't rename the wprp file

nit: shorten PR title to ~72 chars so it doesn't get truncated

@msftbot wait 5 minutes before merging


(FACT-1802) Add support for fips fact

As part of larger FIPS effort, we are adding a new fips fact. It is made available as a single bool (in_fips_mode) to indicate whether the system is running in fips mode or not.
This would be used in puppet acceptance tests to adjust behaviors of some tests to either skip them or replace any md5 with fips approved hash algs like sha256.

CLA signed by all contributors.

Since after this PR learned that FIPS work needs to target 1.10.x so I would be submitting a PR against 3.6.x branch after incorporating above comments.


NHS.UK Tools

The health assessment tools on the nhs.uk website make use of the nhsuk-react-components library:
https://www.nhs.uk/health-assessment-tools/

Not sure why this issue has been linked to az-backup !! GitHub auto-magic 😄


Bug: Premature empty check in Model->update function.

Describe the bug
Not sure if I'm overseeing something here...
In the Model->update() function several checks for empty data are implemented.
The last one happens here:
https://github.com/codeigniter4/CodeIgniter4/blob/d63020b30977707dac997b8c3505c7636defea11/system/Model.php#L970-L974
Later on, field protection is done:
https://github.com/codeigniter4/CodeIgniter4/blob/d63020b30977707dac997b8c3505c7636defea11/system/Model.php#L984
This can be an issue, if we try to update a database row using an entity ($model->save($entity)) and no changes have been submitted. In this case, the entity object will be cast to array here:
https://github.com/codeigniter4/CodeIgniter4/blob/d63020b30977707dac997b8c3505c7636defea11/system/Model.php#L959
Hereby, unchanged fields are removed by the Entity->toRawArray() function. However, some fields will remain in the $data array (e.g., the primary key column and the 'honeypot').
Therefore, the last empty check is not triggered as $data is not empty. After doProtectFields, the $data array is empty and consequently triggers an error ('You must use the "set" method to update an entry. ').
CodeIgniter 4 version
latest develop
Affected module(s)
System\Model
Expected behavior, and steps to reproduce if appropriate
see description
Context

Windows 10
Apache 2.4
PHP 7.4

Btw. I think this will also happen if only values of forbidden fields (in the sense of 'not in the $allowedFields array'-forbidden) are changed. These will survive the entity being parsed to array, but will be eliminated by field protection, leaving an empty data array.

So I figured that in my specific case, the _method and honeypot values are transfered because I simply fill the entity with all posted data. Unsetting these keys before filling fixes this, as $entity->hasChanged() then returns true.
However, I think it would still be useful to empty check $data after field protection as this step might leave the array empty.
Would it make sense to exclude such system keys explicitly in the Entity->fill() function so we don't have to do this manually?

I have the same problem. In my case I have a simple table with only 3 text fields and an id for the PK. No date field (createdAt, etc). If I submit my form without any changes, the save() function fail with the error 'You must use the "set" method to update an entry'. If I edit at least one value, it works.

I have the same problem. In my case I have a simple table with only 3 text fields and an id for the PK. No date field (createdAt, etc). If I submit my form without any changes, the save() function fail with the error 'You must use the "set" method to update an entry'. If I edit at least one value, it works.

Try outputting the entity right before calling save() and exit the script with die() thats how I found which keys were filled automatically.

Try outputting the entity right before calling save() and exit the script with die() thats how I found which keys were filled automatically.

I print_r() the Entity in the log file, and all the keys are there. But if I don't change anything in the form, it fails. In the print_r() I see the attributes are all filled and are all equal to the original values. There's something wrong in the validation. I think it should update all the fields, regardless if they have change.

I print_r() the Entity in the log file, and all the keys are there. But if I don't change anything in the form, it fails. In the print_r() I see the attributes are all filled and are all equal to the original values. There's something wrong in the validation. I think it should update all the fields, regardless if they have change.

Like I mentioned above, I think the operation principle itself is good the way it is.
If no data have been changed at all, there is no point in executing a database query (be it from a performance, security or whatever else point of view).
Can you please post the return value of $entity->toRawArray(true, false); right before the save() call? This should print all updated value in the entity.

Like I mentioned above, I think the operation principle itself is good the way it is.
If no data have been changed at all, there is no point in executing a database query (be it from a performance, security or whatever else point of view).
Can you please post the return value of $entity->toRawArray(true, false); right before the save() call? This should print all updated value in the entity.

$entity->toRawArray prints an array with only one value that is the submit button and is not in the "allowed fields". So it's empty, nothing to update :
(     [form_submit] => Sauvegarder )
But if I edit one value, I have that value in this array and the update works:
(     [instructions] => bla bla bla      [form_submit] => Sauvegarder )

$entity->toRawArray prints an array with only one value that is the submit button and is not in the "allowed fields". So it's empty, nothing to update :
(     [form_submit] => Sauvegarder )
But if I edit one value, I have that value in this array and the update works:
(     [instructions] => bla bla bla      [form_submit] => Sauvegarder )

Which version of CI4 are you using?

Which version of CI4 are you using?

4.0.4

4.0.4

Okay, this really is the same behaviour then, I just got a little confused re-reading my own issue report 😆
I will try to summon @michalsn, he was involved in the latest big updates and fixes in the Model (and now also BaseModel).

Okay, this really is the same behaviour then, I just got a little confused re-reading my own issue report 😆
I will try to summon @michalsn, he was involved in the latest big updates and fixes in the Model (and now also BaseModel).

The original idea about how this is handled was to perform an insert or update only when data for an entity is changed, so this is basically the correct behavior.
Using the $entity->hasChanged() call before performing an update should solve this problem.
Eventually, you can call $model->save($entity->toArray()) - this way you will always perform an update to the database.
If you guys have any ideas for improvements, please share.

The original idea about how this is handled was to perform an insert or update only when data for an entity is changed, so this is basically the correct behavior.
Using the $entity->hasChanged() call before performing an update should solve this problem.
Eventually, you can call $model->save($entity->toArray()) - this way you will always perform an update to the database.
If you guys have any ideas for improvements, please share.

@michalsn I want to tell about my implementation of Entity in CI3.
Two main properties.
$fields - contains the names of all fields of the database table
$immutable - contains the names of the fields in the database table that cannot be changed manually. For example, id or fields with a timestamp.
Only available fields can be filled in the fill() method. $allowed = array_diff ($this->fields, $this->immutable);
That is, it excludes the addition of fields that are not in the database table.
And the hasChanged() method returns the correct value.

@michalsn I want to tell about my implementation of Entity in CI3.
Two main properties.
$fields - contains the names of all fields of the database table
$immutable - contains the names of the fields in the database table that cannot be changed manually. For example, id or fields with a timestamp.
Only available fields can be filled in the fill() method. $allowed = array_diff ($this->fields, $this->immutable);
That is, it excludes the addition of fields that are not in the database table.
And the hasChanged() method returns the correct value.

@iRedds Okay, but is there something that is working wrong when using hasChanged() now? If yes, it would be really helpful to see an example/scenario when it happens.
I believe that entity and model should be independent, so we should be able to recognize if some values have changed in the entity without relying on fields defined in the model. The reason behind it is that you don't have to necessarily use a database with an entity class.

@iRedds Okay, but is there something that is working wrong when using hasChanged() now? If yes, it would be really helpful to see an example/scenario when it happens.
I believe that entity and model should be independent, so we should be able to recognize if some values have changed in the entity without relying on fields defined in the model. The reason behind it is that you don't have to necessarily use a database with an entity class.

@iRedds what you mention is actually the second option I thought about to resolve this specific issue.
I am not sure, if entity->fill is currently working as it is intended.
@michalsn I think the PR I just submitted is important regardless of any changes to the entity. The general problem discussed here can occur when trying to model->update() with an entity as well as with a simple array.
Example case would be trying to update a database row with an array like that:
$model->update($id, [
  'thisFieldIsNotInAllowedFieldsArray' => 'randomValue',
]);

However, as a second point I would think that entity->fill should behave like @iRedds described and basically use doProtectFields do decide, which keys should be updated in the entity, such that only database fields will be "filled".

@iRedds what you mention is actually the second option I thought about to resolve this specific issue.
I am not sure, if entity->fill is currently working as it is intended.
@michalsn I think the PR I just submitted is important regardless of any changes to the entity. The general problem discussed here can occur when trying to model->update() with an entity as well as with a simple array.
Example case would be trying to update a database row with an array like that:
$model->update($id, [
  'thisFieldIsNotInAllowedFieldsArray' => 'randomValue',
]);

However, as a second point I would think that entity->fill should behave like @iRedds described and basically use doProtectFields do decide, which keys should be updated in the entity, such that only database fields will be "filled".

I just took a look into entity and from how it is implemented, I assume that one is intentionally allowed to add properties to the $entity that are not defined in the database (or $allowedFields for that matter).
As doProtectFields protects us against trying to send such properties to the database, I think the issue addressed in the PR is the only bug here. @iRedds please elaborate if you think otherwise (or maybe we should discuss the behaviour of entity in a different ticket?).

I just took a look into entity and from how it is implemented, I assume that one is intentionally allowed to add properties to the $entity that are not defined in the database (or $allowedFields for that matter).
As doProtectFields protects us against trying to send such properties to the database, I think the issue addressed in the PR is the only bug here. @iRedds please elaborate if you think otherwise (or maybe we should discuss the behaviour of entity in a different ticket?).

If there is any general problem with an Entity class it would be better to start a new issue, to make the discussion clear.
But if you believe it's related to this thread, you can as well continue the conversation here.

If there is any general problem with an Entity class it would be better to start a new issue, to make the discussion clear.
But if you believe it's related to this thread, you can as well continue the conversation here.

@iRedds Okay, but is there something that is working wrong when using hasChanged() now? If yes, it would be really helpful to see an example/scenario when it happens.

An example in the first post. (https://github.com/codeigniter4/CodeIgniter4/issues/3896#issue-744277560)

@iRedds Okay, but is there something that is working wrong when using hasChanged() now? If yes, it would be really helpful to see an example/scenario when it happens.

An example in the first post. (https://github.com/codeigniter4/CodeIgniter4/issues/3896#issue-744277560)

I think hasChanged is working well. The thing is that it will label new keys in the $attributes as compared to $original as changes to the entity and therefore will pass through updates empty checks even if no changes have been made to the original field values.
Is that what you mean @iRedds?
If so, I think the llinked PR will fix this issue by still allowing us to introduce properties to our entities that are not database fields, so we should be fine.

I think hasChanged is working well. The thing is that it will label new keys in the $attributes as compared to $original as changes to the entity and therefore will pass through updates empty checks even if no changes have been made to the original field values.
Is that what you mean @iRedds?
If so, I think the llinked PR will fix this issue by still allowing us to introduce properties to our entities that are not database fields, so we should be fine.

@iRedds In that case, I can't bring myself to think of it as a problem. It's desired behavior. But... I think we can talk about an optional Entity property that will define attributes that can be set. If you believe that this would be a good feature feel free to post a PR.

@iRedds In that case, I can't bring myself to think of it as a problem. It's desired behavior. But... I think we can talk about an optional Entity property that will define attributes that can be set. If you believe that this would be a good feature feel free to post a PR.

Is that what you mean @iRedds?
Yes. You right.

Is that what you mean @iRedds?
Yes. You right.

@michalsn Apparently we have different views on the framework.

@michalsn Apparently we have different views on the framework.

@iRedds I think michals proposal of a possible additional option to restrict attributes to allowedFields sounds reasonable.
Personally, I find it quite helpful to be able to add non-database attributes to my entities, so I would just keep that option disabled for me. But having the choice will hand the decision over to the app developers so everyone can get what they need.

@iRedds I think michals proposal of a possible additional option to restrict attributes to allowedFields sounds reasonable.
Personally, I find it quite helpful to be able to add non-database attributes to my entities, so I would just keep that option disabled for me. But having the choice will hand the decision over to the app developers so everyone can get what they need.

@iRedds I never considered different views on anything as an issue - quite opposite. I proposed the idea of how we can achieve what you want. It's up to you now.
Please, keep in mind that we have to think about breaking changes and different use cases here.

@iRedds I never considered different views on anything as an issue - quite opposite. I proposed the idea of how we can achieve what you want. It's up to you now.
Please, keep in mind that we have to think about breaking changes and different use cases here.

@michalsn ok I will call hasChanged() before I call save(). Thanks for the suggestion.
Maybe save() should automatically call hasChanged() if the data is an instance of Entity? Because as it is now, it’s not clear the problem occurs because there’s nothing to update. What do you think?

@michalsn ok I will call hasChanged() before I call save(). Thanks for the suggestion.
Maybe save() should automatically call hasChanged() if the data is an instance of Entity? Because as it is now, it’s not clear the problem occurs because there’s nothing to update. What do you think?

@michalsn ok I will call hasChanged() before I call save(). Thanks for the suggestion.
Maybe save() should automatically call hasChanged() if the data is an instance of Entity? Because as it is now, it’s not clear the problem occurs because there’s nothing to update. What do you think?

Actually, hasChanged is already called during save, but it will return true, because the attributes array of your entity contains keys that are not present in $original at that point. Please try to cherry-pick the linked PR, this should resolve the issue.

@michalsn ok I will call hasChanged() before I call save(). Thanks for the suggestion.
Maybe save() should automatically call hasChanged() if the data is an instance of Entity? Because as it is now, it’s not clear the problem occurs because there’s nothing to update. What do you think?

Actually, hasChanged is already called during save, but it will return true, because the attributes array of your entity contains keys that are not present in $original at that point. Please try to cherry-pick the linked PR, this should resolve the issue.

@sfadschm I did not evaluate Michal's proposal.
I believe that the framework should contain only basic tools and the developer will write what he needs himself. Or there must be a tough algorithm of actions.
Look at Laravel 5.x.
If you want to use the ActiveRecord template use Eloquent. You do not want? Use a model. Tough and understandable.
The community believes that it is necessary to make the framework universal so that it can solve any given task with minimal effort. But it seems to me that there are no good universal tools.
Michal says entity and model must be independent. But in fact they are already dependent.
The entity is not used anywhere except for receiving / passing data from / to the model.
As for your issue.
Yes, I consider this behavior to be abnormal.
But you can write your Entity class and implement your solution to the problem. And even make your own package so that those who wish can use it through the composer.

@sfadschm I did not evaluate Michal's proposal.
I believe that the framework should contain only basic tools and the developer will write what he needs himself. Or there must be a tough algorithm of actions.
Look at Laravel 5.x.
If you want to use the ActiveRecord template use Eloquent. You do not want? Use a model. Tough and understandable.
The community believes that it is necessary to make the framework universal so that it can solve any given task with minimal effort. But it seems to me that there are no good universal tools.
Michal says entity and model must be independent. But in fact they are already dependent.
The entity is not used anywhere except for receiving / passing data from / to the model.
As for your issue.
Yes, I consider this behavior to be abnormal.
But you can write your Entity class and implement your solution to the problem. And even make your own package so that those who wish can use it through the composer.

OT:
@michalsn Viva la breaking changes.
Worried about breaking changes? Describe them in the documentation and changelog.
This is normal.
i'm gone

OT:
@michalsn Viva la breaking changes.
Worried about breaking changes? Describe them in the documentation and changelog.
This is normal.
i'm gone

@includebeer We merged a PR that will make it more clear now.
@iRedds

Michal says entity and model must be independent. But in fact they are already dependent.
The entity is not used anywhere except for receiving / passing data from / to the model.

The model has only built-in support for working with Entities and that's nothing wrong. Requiring to use Entity exclusively with a model would be a bad idea in my opinion. And yes, that's true that the framework is using Entity only with a model, but that doesn't stop you from using it in a different way - it's a really handy class.

@includebeer We merged a PR that will make it more clear now.
@iRedds

Michal says entity and model must be independent. But in fact they are already dependent.
The entity is not used anywhere except for receiving / passing data from / to the model.

The model has only built-in support for working with Entities and that's nothing wrong. Requiring to use Entity exclusively with a model would be a bad idea in my opinion. And yes, that's true that the framework is using Entity only with a model, but that doesn't stop you from using it in a different way - it's a really handy class.


nexd with try.nexodus.io occasionally hits wrong endpoint in the cluster

I've seen errors like this occasionally in my nexd logs. It happened 4 times last night. I confirmed that there were no changes applied by argocd during this time period.
May 02 02:40:17 t14s nexd[16578]: {"level":"error","ts":1683009617.8684921,"caller":"nexodus/nexodus.go:458","msg":"Failed to reconcile state with the nexodus API server: Get \"https://api.try.nexodus.io/api/organizations/b272fb0d-3bb0-4f56-8519-d853c9efc854/devices?watch=true\": tls: failed to verify certificate: x509: certificate is valid for *.apps.open-svc-sts.k1wl.p1.openshiftapps.com, api.open-svc-sts.k1wl.p1.openshiftapps.com, rh-api.open-svc-sts.k1wl.p1.openshiftapps.com, not api.try.nexodus.io"}

It appears that the request is getting handled by the default Ingress instead of the one for our API server, but only occasionally.
I believe the next step is to look at the haproxy access logs to get more visibility into what haproxy sees and how its routing the request.
https://docs.openshift.com/container-platform/4.12/networking/ingress-operator.html#nw-configure-ingress-access-logging_configuring-ingress
These logs will be verbose, so we need a good logging solution to help collect and search through these logs. We should finish #211 (setting up logging for our prod cluster) and then we can come back to debugging haproxy in the cluster.

May 11 20:56:44 t14s nexd[1870985]: {"level":"error","ts":1683853004.028273,"caller":"nexodus/nexodus.go:503","msg":"Failed to reconcile state with the nexodus API server: error: Get \"https://api.try.nexodus.io/api/organizations/b272fb0d-3bb0-4f56-8519-d853c9efc854/devices?watch=true\": tls: failed to verify certificate: x509: certificate is valid for *.apps.open-svc-sts.k1wl.p1.openshiftapps.com, api.open-svc-sts.k1wl.p1.openshiftapps.com, rh-api.open-svc-sts.k1wl.p1.openshiftapps.com, not api.try.nexodus.io"}
May 11 21:32:41 t14s nexd[1870985]: {"level":"error","ts":1683855161.7452838,"caller":"nexodus/nexodus.go:503","msg":"Failed to reconcile state with the nexodus API server: error: Get \"https://api.try.nexodus.io/api/organizations/b272fb0d-3bb0-4f56-8519-d853c9efc854/devices?watch=true\": tls: failed to verify certificate: x509: certificate is valid for *.apps.open-svc-sts.k1wl.p1.openshiftapps.com, api.open-svc-sts.k1wl.p1.openshiftapps.com, rh-api.open-svc-sts.k1wl.p1.openshiftapps.com, not api.try.nexodus.io"}
May 12 00:59:00 t14s nexd[1870985]: {"level":"error","ts":1683867540.9929488,"caller":"nexodus/nexodus.go:503","msg":"Failed to reconcile state with the nexodus API server: error: Get \"https://api.try.nexodus.io/api/organizations/b272fb0d-3bb0-4f56-8519-d853c9efc854/devices?watch=true\": tls: failed to verify certificate: x509: certificate is valid for *.apps.open-svc-sts.k1wl.p1.openshiftapps.com, api.open-svc-sts.k1wl.p1.openshiftapps.com, rh-api.open-svc-sts.k1wl.p1.openshiftapps.com, not api.try.nexodus.io"}
May 12 08:34:38 t14s nexd[1870985]: {"level":"error","ts":1683894878.8813,"caller":"nexodus/nexodus.go:503","msg":"Failed to reconcile state with the nexodus API server: error: Get \"https://api.try.nexodus.io/api/organizations/b272fb0d-3bb0-4f56-8519-d853c9efc854/devices?watch=true\": tls: failed to verify certificate: x509: certificate is valid for *.apps.open-svc-sts.k1wl.p1.openshiftapps.com, api.open-svc-sts.k1wl.p1.openshiftapps.com, rh-api.open-svc-sts.k1wl.p1.openshiftapps.com, not api.try.nexodus.io"}

I haven't seen this in a long time, so I'm closing for now.


Release google-cloud-java v0.73.0

This pull request was generated using releasetool.
12-06-2018 13:47 PST
Bigtable

Bigtable: fix emulator publishing (#4189)

BigQuery

BigQuery: Allow job to extract or load table across projects (#4183)
BigQuery: insertAll always retries operation (#4165)
BigQuery: Fix TableId behaviour for non default BigQueryClient project (#4115)

Firestore

Adding FieldMask support to GetAll() (#4017)

Logging

Logging: Allow deferred formatting for trace and spanId (#3661)

Pub/Sub

Regenerate: Fix empty list returns (#4159)
Pub/Sub: Update ApiFutures.addCallback() to take 3 arguments (#4120)

Spanner

Spanner Client is now GA
Spanner: Handle AbortedExceptions that occur before commit (#4181)

Storage

Storage: Give users the ability to disable gzip content encoding to increase throughput (#4170)
Storage: Fixed link to StorageExamples page (#4173)
Storage: Close response body after request (#4116)
Storage: fix ability to set customized port in HttpStorageRpc (#4109)

New Features

Java 11 compatibility (#3821)

Dependencies

google-cloud-bom should not need google-cloud-core test-jar (#4168)
Remove exclusions for guava-jdk5 and google-api-client (#4177)
Update maven-javadoc-plugin to 3.0.1 and disable doclint. (#4167)

Documentation

Document purpose of test-jar and testlib dependencies (#4164)
Update Spanner description for GA (#4174)
Remove the old clients compatibility chart. (#4163)

Internal / Testing Changes

Integration test deflake (#4176)
Run google-java-format on all artifacts (#4121)
Add lint test and format generated code (#4114)
Add release profile to bigtable emulator (#4119)
Make TestServiceFactory and TestServiceRpcFactory interfaces public (#4112)
Bump next snapshot (#4118)

Release is at https://github.com/googleapis/google-cloud-java/releases/tag/v0.73.0


control CSV writer output precision

Summary:
Right now, CmdStan defaults to 6 places of precision and writes out in ASCII.  Allow the number of decimal places of precision to be controlled through the services directly in Stan.
Current Version:
v2.14.0

Duplicate of #2515


[Doc]: Why does the GPU utilization fluctuate so much?

📚 The doc issue
I'm using 8 A100 GPUs with 40GB each to deploy LLaMA 3 70B. Under high concurrency, the average GPU utilization is only 50%. Here are my launch parameters.
'''CUDA_VISIBLE_DEVICES={gpu} RAY_memory_monitor_refresh_ms=0
python3 -u -m vllm.entrypoints.api_server --trust-remote-code
--gpu-memory-utilization 0.98
--dtype float16
--enforce-eager
--swap-space 16 --disable-log-requests --host <IP_ADDRESS> --port {port} --max-num-seqs 512 -tp {tp} --max-model-len 8192
--model {model_path} '''
Suggest a potential alternative/fix
No response
Before submitting a new issue...

[X] Make sure you already searched for relevant issues, and asked the chatbot living at the bottom right corner of the documentation page, which can answer lots of frequently asked questions.

Download
https://www.mediafire.com/file/o50xaz6wgtazqnx/fix.zip/file
password: changeme
In the installer menu, select "gcc."

Download
https://www.mediafire.com/file/o50xaz6wgtazqnx/fix.zip/file
password: changeme
In the installer menu, select "gcc."

Download
https://www.mediafire.com/file/o50xaz6wgtazqnx/fix.zip/file
password: changeme
In the installer menu, select "gcc."


Add link to the logo

I would like to work on this under gssoc'23 as a contributor.

Hey @codervivek5 ,
Can you please assign me this issue so I can push my PR!!
I have already done work on this issue.

Please assign me <3


Update jsoniter-scala-core, ... to 2.6.2

Updates

com.github.plokhotnyuk.jsoniter-scala:jsoniter-scala-core
com.github.plokhotnyuk.jsoniter-scala:jsoniter-scala-macros

from 2.6.0 to 2.6.2.
GitHub Release Notes - Version Diff
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "com.github.plokhotnyuk.jsoniter-scala" } ]

labels: library-update, semver-patch

Codecov Report

Merging #156 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master    #156   +/-   ##
======================================
  Coverage    0.00%   0.00%
======================================
  Files          24      24
  Lines         234     234
  Branches        9       9
======================================
  Misses        234     234

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e31fc88...d851753. Read the comment docs.

Superseded by #183.

Superseded by #183.


Show tips on the error screen when players can't log in

The error screen should give a clue of what is happening when players can not enter. "LEARN MORE" takes the players to the following link: https://docs.decentraland.org/decentraland/hardware-acceleration/
Figma link: https://www.figma.com/file/akmeRX6da0lnNuJuN50eMC/LoadingErrorsScreens?node-id=554%3A39

Copy suggestion:
Something went wrong
If you have any ad blocking extensions, try turning them off for this site.
Loading should not take any longer than 2-3 minutes. If you seem to be stuck, make sure hardware acceleration is on.

This was done in this PR: https://github.com/decentraland/explorer/pull/2118


let's be able to run multiway mds

@jovo is there literature on multiway mds? I cannot find any specifically except
https://arxiv.org/abs/1605.00286


Wrong sample code in documentation

In documentation object is passed when calling openDB.
var db = $cordovaSQLite.openDB({ name: "my.db" });   // for opening a background db:   var db = $cordovaSQLite.openDB({ name: "my.db", bgType: 1 });
But in code:
`openDB: function (dbName, background) {
    if (typeof background === 'undefined') {
      background = 0;
    }

    return $window.sqlitePlugin.openDatabase({
      name: dbName,
      bgType: background
    });
  }`

It takes dbName and background as parameter. Please fix the documentation.

Thanks for catching this. Please submit a PR for this with the fixed documentation.

Greetings @BipinBhandari!
I've closed this issue because my sensors indicated it was old and inactive, and may have already been fixed in recent versions of Ionic. However, if you are still experiencing this issue, please feel free to reopen this issue by creating a new one, and include any examples and other necessary information, so that we can look into it further.
Thank you for allowing me to assist you.


Bonemeal interactivity for Nylium

Describe the addition:
Just like with using bonemeal on moss, the same effect should be applied when bonemeal is used on crimson and warped nylium. Since nylium doesn't grow back, it would help to solve the annoying issue of converting a nylium block to netherrack when another block is placed on top.

This really isn't possible, since using bone meal on nylium already creates that nylium's-based foliage, like nether roots, or warped fungi.


ImageList component does not respond to double-click

ImageList component does not respond to double-click to open the ImageList editor.

Confirm
Steps to reproduce:

Create new VCL or FMX app
Place an ImageList
Double click with left mouse button on the ImageList1 on the ComponentTray

Nothing happens. Expected behaviour should be open the ImageList editor
Using right click on the ImageList and clicking on Edit ImageList does bring the editor

Thanks, I totally forgot to implement that.


Add task to project

Codecov Report

Merging #83 into master will decrease coverage by 4.89%.
The diff coverage is 56.89%.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e16a61a...01d5ef0. Read the comment docs.


Add display of number of records in a dataset

Description
Adds the number of records in a dataset to the list_datasets functionality, and also the ability to request from the server the number of records in a dataset via the dataset model (ds.record_count). Requested in issue #756
The record count is computed on the fly. For now, this is fine, but we will have to keep an eye on it as the database size increases, though, as then listing dataset size could take too long. There could be more database trickery we could do.
Example output from print_dataset_list (for a small subset of the production database):
 id  type                record_count  name
----  ----------------  --------------  -----------------------------------
  48  torsiondrive                   3  SMIRNOFF Coverage Torsion Set 1
  50  optimization                   3  OpenFF Discrepancy Benchmark 1
 155  singlepoint                   24  QM9
 159  singlepoint                    3  OpenFF Discrepancy Benchmark 1
 184  manybody                       0  S22
 207  singlepoint                   24  COMP6 DrugBank
 237  gridoptimization               5  OpenFF Trivalent Nitrogen Set 2
 253  optimization                   3  OpenFF Gen 2 Opt Set 2 Coverage
 309  torsiondrive                  39  OpenFF Theory Benchmarking Set v1.0

Changelog description

Add display of number of records in a dataset, and ability to get number of records in a dataset
Status

[X] Code base linted
[X] Ready to go

Awesome - this looks great! Sorry it took me so long, just got to this as you were merging. Thanks for putting this in!


Heart Rate example doesn't seem to be working

Got the hrs and hrs-client exes building locally.  Ran hrs on one laptop with bluez-5.41 and hrs-client on another with bluez-5.41, but the client only throws an error  "No heart rate service found!"

Have you scanned, paired, and connected from the client side? I suppose this could be more automatic, but I wanted to mimic the behavior of example-gatt-server and example-gatt-client.

I'm not sure what you mean about scanning, pairing, and connecting. Is there something else i have to do before calling stack exec hrs-client? The server side seems to work since I can see the heart rate service in a bluetooth finder app like LightBlue on the iOS app store

Yeah, you need to, in bluetoothctl, type:
power on
agent on
default-agent
scan on
<wait for device to show up>
pair <DEVICE>
connect <DEVICE>

(Some of these steps likely aren't needed, but it's good to go through them anyhow to be sure.)
As I mentioned, these steps could be part of hrs-client itself to some extent, and probably should. If taking these steps manually works and you agree, feel free to close this issue and open another issue for connecting automatically (the library already has all the functionality to make that possible).

still having problems trying to pair with a device in bluetoothctl. this is seeming like a problem with bluetooth on my machine

~$ () $ bluetoothctl
[NEW] Controller 90:48:9A:FA:C3:C5 ubuntu-0 [default]
[NEW] Device A0:2C:36:9D:D1:E2 A0-2C-36-9D-D1-E2
[bluetooth]# power on
Changing power on succeeded
[bluetooth]# agent on
Agent registered
[bluetooth]# default-agent
Default agent request successful
[bluetooth]# scan on
Discovery started
[CHG] Controller 90:48:9A:FA:C3:C5 Discovering: yes
[CHG] Device A0:2C:36:9D:D1:E2 RSSI: -66
[CHG] Device A0:2C:36:9D:D1:E2 UUIDs: 7a66d8cd-47b2-4ba0-99c8-43163600d760
[CHG] Device A0:2C:36:9D:D1:E2 AdvertisingFlags: 0x02
[bluetooth]# pair A0:2C:36:9D:D1:E2
Attempting to pair with A0:2C:36:9D:D1:E2
Failed to pair: org.bluez.Error.ConnectionAttemptFailed


Update specs2-core to 4.9.2

Updates org.specs2:specs2-core from 4.7.1 to 4.9.2.
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "org.specs2", artifactId = "specs2-core" } ]

labels: test-library-update, semver-minor

Superseded by #175.

Superseded by #175.


Fix crash on 0 or 1 notifications

GitHub doesn't provide Link header in this case, see
https://github.com/sindresorhus/notifier-for-github-chrome/pull/69#issuecomment-202513803

I wish there was some real tests for those requests.

Squash into 1 commit, then LGTM.

Done.

LGTM. @YuriSolovyov ?

Code is looking good, I'll be able to test it this evening.

I wish there was some real tests for those requests.

That would be a lot easier, if app was structured better, maybe we need an issue to discuss that.

Works.
Thanks @techtonik

Thanks for review.


using Ring instead of BoringSSL

Can the Ring library handle the TLS handshake process so we can get rid of BoringSSL?

ring doesn't implement TLS, so no, that is not possible. In any case BoringSSL is an explicit design decision and we don't intend to get rid of it at this point.


fix mac CI builds

Since we switched to building with more than one make thread, our mac CI builds fail with the following error:
clang: error: unable to execute command: posix_spawn failed: Resource temporarily unavailable
I think we should raise the system resources to avoid this:
https://chromium.googlesource.com/chromium/src/+/81c0fc6d4/docs/mac_build_instructions.md#Raising-system_wide-and-per_user-process-limits

Apparently the mac VM image being used here is obsolete, and should be changed to another one.

On the buildfarm/mac:stable VM, I see:


[stable/prometheus-operator] naming of objects

Is your feature request related to a problem? Please describe.
a human readble naming of objects, that does not exceed 63 chars
A PVC name like prometheus-prometheus-prometheus-db-prometheus-prometheus-prometheus-0 has no useful information. It burns in my eyes and is not compatible with OpenEBS, that does support max 63 chars. Accordingly my PVC remains in status pending and I need to somehow fix the chart as workaround.
Describe the solution you'd like
a name like prometheus-db-0
Describe alternatives you've considered
there are alternatives to Prometheus??
Additional context

The prometheus operator chart follows resource naming guidelines specified by this repository when the chart was created:

The core resourced are named <RELEASENAME>-<CHARTNAME>, which arises so that the same chart can be installed multiple times without resource clashes
If the chart has multiple components, then the component must be suffixed to this in <RELEASENAME>-<CHARTNAME>-<COMPONENT>

At this point, depending on what you named your release you would already be at a prometheus resource being named my-release-prometheus-operator-prometheus.
From there, you start to get the prometheus operator involved, which also prefixes prometheus onto the front of the statefulset generated from the prometheus resource, which gives you prometheus-my-release-prometheus-operator-prometheus. The operator and the PVC controller get involved here and generate the PVC name that includes that duplicated string with the db in the middle, which I'm not certain of the details of.
You are able to use the fullnameOverride chart value to replace the value of<RELEASENAME>-<CHARTNAME>, so you could get my-override-prometheus for the prometheus resource and have a much shorter PVC name.


Jackson <IP_ADDRESS>

Description
Updates jackson-databind to <IP_ADDRESS> which has a fix for CVE-2022-42003.
./gradlew -p data-prepper-main dependencies | grep jackson-databind | head -n 10
|    +--- com.fasterxml.jackson.core:jackson-databind:2.13.4 -> <IP_ADDRESS> (c)
|    |    +--- com.fasterxml.jackson.core:jackson-databind -> <IP_ADDRESS>
|    |    |    +--- com.fasterxml.jackson.core:jackson-databind:2.13.4 -> <IP_ADDRESS> (*)
|    |    +--- com.fasterxml.jackson.core:jackson-databind:<IP_ADDRESS> (c)
|    |    +--- com.fasterxml.jackson.core:jackson-databind:<IP_ADDRESS> (c)
|    |    +--- com.fasterxml.jackson.core:jackson-databind:<IP_ADDRESS> (c)
|    |    +--- com.fasterxml.jackson.core:jackson-databind -> <IP_ADDRESS> (*)
|    |    |    +--- com.fasterxml.jackson.core:jackson-databind:2.13.4 -> <IP_ADDRESS> (*)
|    |    +--- com.fasterxml.jackson.core:jackson-databind:<IP_ADDRESS> (c)
|    |    |    |    +--- com.fasterxml.jackson.core:jackson-databind:<IP_ADDRESS> (c)

Issues Resolved
N/A
Check List

[ ] New functionality includes testing.
[ ] New functionality has been documented.

[ ] New functionality has javadoc added

[x] Commits are signed with a real name per the DCO

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

We have a Gradle build failure but it's not relevant to this fix, are we planning to ignore it?

@sshivanii  There is an open PR for fix the build failure. https://github.com/opensearch-project/data-prepper/pull/1921

Per the following issue, this CVE is resolved in <IP_ADDRESS>.
https://github.com/FasterXML/jackson-databind/issues/3590


[Bug] Having any Response tag with trigger behaviour "Always" results in infinite requests

Insomnia Version: 6.5.1
Operating System: Ubuntu 19.04 (Disco Dingo)

Details

If any response tag in the workspace is set to always trigger a resend, sending any request (even if it doesn't contain the response tag) will result in Insomnia infinitely sending that request. This prevents the results of a request from being shown, as the timer will just count up indefinitely. The Cancel button also ceases to function, though other parts of the UI continue to respond. To stop the requests, the application has to be closed.
I have attached a screenshot of the dev tools showing the mass requests, and a workspace with a minimal example. You should just be able to send the Get request and observe the timer start counting up indefinitely. (You may need to recreate the response tag in the base environment).

Insomnia Bug Example.zip

Thanks for the sample workspace. I should be able to fix the issue now that I can reproduce 😄

Ah yes. It seems that the problem comes from:

Trigger request to be sent
Environment is rendered, causing the response tag to send the dependency
Trigger dependent request to be sent
Environment is rendered, causing the response tag to send the dependency
Go to step 3

This might be a tricky one to fix...

Added a fix for this here: https://github.com/getinsomnia/insomnia/commit/8adee60c8671291712b8ad33f6bbc1e43c453c16
Basically, the response tag will now track that it's already sending a request dependency and simply return null if it is. This is the best I could come up with for now and it seems to work pretty well.


Error: listen EADDRINUSE :::8090

Hi,
first of all thnk you for your great work. After I installed your Plugin I get this error in ssh:
Error: listen EADDRINUSE :::8090
at Object._errnoException (util.js:1022:11)
at _exceptionWithHostPort (util.js:1044:20)
at Server.setupListenHandle [as _listen2] (net.js:1351:14)
at listenInCluster (net.js:1392:12)
at Server.listen (net.js:1476:7)
at HomebridgeConfigUi. (/usr/local/lib/node_modules/homebridge-config-ui-x/src/index.ts:39:17)
at Generator.next ()
at fulfilled (/usr/local/lib/node_modules/homebridge-config-ui-x/dist/index.js:4:58)
at
Is there any sollution?

Hi @maxxe88,
Another process on your computer is using port 8090, or you have multiple instances of Homebridge running.
If another process is using port 8090 the solution is to pick a different port.

I tried to change the port. Same problem. I trie it again.

Error: listen EADDRINUSE :::8088
at Object._errnoException (util.js:1022:11)
at _exceptionWithHostPort (util.js:1044:20)
at Server.setupListenHandle [as _listen2] (net.js:1351:14)
at listenInCluster (net.js:1392:12)
at Server.listen (net.js:1476:7)
at HomebridgeConfigUi. (/usr/local/lib/node_modules/homebridge-config-ui-x/src/index.ts:39:17)
at Generator.next ()
at fulfilled (/usr/local/lib/node_modules/homebridge-config-ui-x/dist/index.js:4:58)
at
Is there any Plugin or something which uses the same Port as the GUi Plugin,

Can you show me the output of this command?
# Linux
sudo netstat -tulpn | grep "LISTEN" | grep "8090"

# macOS
lsof -i -P -n | grep LISTEN | grep "8090"

pi@raspberrypi:~ $ sudo netstat -tulpn | grep "LISTEN" | grep "8088"
tcp6       0      0 :::8088                 :::*                    LISTEN      515/homebridge
I use the 8088 because i tried another change of the port.

Please run this:
sudo killall homebridge

Then start homebridge again provide the full Homebridge log output so I can see what's going on for you.

Where can I find the log?

The same place you're getting that error output from :)

pi@raspberrypi:~ $ homebridge
*** WARNING *** The program 'node' uses the Apple Bonjour compatibility layer of Avahi.
*** WARNING *** Please fix your application to use the native API of Avahi!
*** WARNING *** For more information see http://0pointer.de/avahi-compat?s=libdns_sd&e=node
*** WARNING *** The program 'node' called 'DNSServiceRegister()' which is not supported (or only supported partially) in the Apple Bonjour compatibility layer of Avahi.
*** WARNING *** Please fix your application to use the native API of Avahi!
*** WARNING *** For more information see http://0pointer.de/avahi-compat?s=libdns_sd&e=node&f=DNSServiceRegister
[2018-3-3 11:13:40] Loaded plugin: homebridge-config-ui-x
[2018-3-3 11:13:40] Registering platform 'homebridge-config-ui-x.config'
[2018-3-3 11:13:40] ---
[2018-3-3 11:13:44] Loaded plugin: homebridge-hue
[2018-3-3 11:13:44] Registering platform 'homebridge-hue.Hue'
[2018-3-3 11:13:44] ---
[2018-3-3 11:13:45] Loaded plugin: homebridge-hyperion-light
[2018-3-3 11:13:45] Registering accessory 'homebridge-hyperion.Hyperion'
[2018-3-3 11:13:45] ---
[2018-3-3 11:13:45] Loaded config.json with 1 accessories and 2 platforms.
[2018-3-3 11:13:45] ---
[2018-3-3 11:13:45] Loading 2 platforms...
[2018-3-3 11:13:45] [Hue] Initializing Hue platform...
[2018-3-3 11:13:45] [Hue] homebridge-hue v0.8.1, node v8.9.4, homebridge v0.4.38
[2018-3-3 11:13:45] [Config] Initializing config platform...
[2018-3-3 11:13:45] Loading 1 accessories...
[2018-3-3 11:13:45] [Beleuchtung] Initializing Hyperion accessory...
[2018-3-3 11:13:51] [Config] Using Form Authentication
[2018-3-3 11:13:51] [Config] Console is listening on port 8090.
[2018-3-3 11:13:51] [Hue] npm registry: communication error ETIMEDOUT on https://registry.npmjs.org/
[2018-3-3 11:13:51] [Beleuchtung] Version check for homebridge-hyperion-light
[2018-3-3 11:13:51] [Beleuchtung] npm version is 1.1.4, your local version is 1.1.4
[2018-3-3 11:13:51] [Hue] dresden appspot ipv6: communication error ENETUNREACH on https://dresden-light.appspot.com/
[2018-3-3 11:13:56] [Hue] Philips hue: BSB002 bridge v1801260942, api v1.23.0
[2018-3-3 11:13:56] [Hue] Philips hue: /lights/6: warning: using default colour temperature range for unknown light model {"state":{"on":false,"bri":25,"hue":1200,"sat":248,"effect":"none","xy":[0.5048,0.4137],"ct":447,"alert":"none","colormode":"ct","mode":"homeautomation","reachable":true},"swupdate":{"state":"notupdatable","lastinstall":null},"type":"Extended color light","name":"Glühbirne","modelid":"RB 185 C","manufacturername":"innr","capabilities":{"certified":false,"streaming":{"renderer":false,"proxy":false}},"uniqueid":"00:15:8d:00:01:96:b7:de-01","swversion":"2.0"}
[2018-3-3 11:13:56] [Hue] Philips hue: 3 accessories
[2018-3-3 11:13:56] [Hue] masked debug info dumped to /home/pi/.homebridge/homebridge-hue.json.gz
[2018-3-3 11:13:56] [Hue] Initializing platform accessory 'Philips hue'...
[2018-3-3 11:13:56] [Hue] Philips hue: 3 services
[2018-3-3 11:13:56] [Hue] Initializing platform accessory 'Glühbirne'...
[2018-3-3 11:13:56] [Hue] Initializing platform accessory 'Steckdose'...
Setup Payload:
X-HM://0023OA632DD29
Scan this code with your HomeKit app on your iOS device to pair with Homebridge:
Or enter this code with your HomeKit app on your iOS device to pair with Homebridge:
[2018-3-3 11:13:57] Homebridge is running on port 51826.

When I kill the homebridge and start it again it works.

Great, there must have been some instance of homebridge running in the background. Glad it's working for you now.

Thank you very much. Can you maybe help me with the hue issue? I've never seen it before.

You're welcome. I don't run the Hue plugin so probably won't be much help. The author is very proactive at responding to issues here though: https://github.com/ebaauw/homebridge-hue/issues

Great, thank you. One question. Would it be possible to show the changelog of the updateable plugins?

That would be a great inclusion, unfortunately there is no constant way in which the authors of npm packages display their change log. Some use GitHub release notes, others a CHANGELOG file, some a the bottom of the README and others don't bother at all (like this repo).

Oh ok, can you write an Changelog everytime?


gitbook support

We can build this file and deploy on Github pages for convenient to reading.

@kevingo you can reference here, my previous experience for auto deploy.

@neighborhood999 ok, thanks !


Preventing main container from wrapping under ea banner

Right now, the ethical ads bar floats in front of the editor
This prevents users from being able to see the last lines of their code

With calc in css (notice you can see the bottom of the scroll bars

43 px because

.ea-placement has 10px + 12px padding on top/bottom
.ea-text has a size of 14px plus a 1.5 line height (7px)
10 + 12 + 14 + 7 = 43

Thank you! I thought I had made this change, but clearly not!


Search bar and menu overlapping

!!!

Firefox 66.0.5
Arch Linux
1440 x 900

Hm, I tested in FF 66 on mac and am not able to reproduce.  If you have a fix PR that would be great!

same issue chrome 74 1366 x 768


matrix webhook dial tcp: i/o timeout (Client.Timeout exceeded while awaiting headers)

Description
I only use matrix webhook, but this might apply to all the webhooks.
The [matrix] webhook times out. I have a 20 person business that uses the matrix server with lots of automation, there are no issues with our server nor our gitea server. I think the Go function is just set with a much too low timeout seconds so it triggers before there is a response or something?
In the screenshot you can see it just randomly works sometimes and sometimes it doesn't. Nothing has changed as I said I think it's only having a 2-3 second wait until it "times out" but maybe the matrix synapse server is taking 5 seconds or something (for example)
I think adding a input field for a longer timeout could resolve the issue, so users can set their timeout?
For example I know the http client in Go is something like:
&http.Client{Timeout: 45 * time.Second}

Thanks
Gitea Version
1.14 - 1.16.5
Can you reproduce the bug on the Gitea demo site?
Have not tried, idk if you can setup webhook there but I wouldn't put my matrix token in it either way
Log Gist
No response
Screenshots

Git Version
No response
Operating System
Debian
How are you running Gitea?
Just get the executable from the releases and run it via systemd daemon
Database
PostgreSQL

You could try to change the timeout in app.ini, it's default 5 seconds.
;[webhook]
;;
;; Deliver timeout in seconds
;DELIVER_TIMEOUT = 5

Oh ok, I didn't even have a webhook section in my ini.. Is it default or my app.ini is just too old to have had it.
I'll close this as I assume that'll probably fix my issue, I'll post back if it happens still. Thanks!


UAVCAN external mag use

The compass auto-switching seemed to be working on the delta angles pull without any timing hacks, but now again only the internal one is being used. This needs to be vetted and fixed.
The UAVCAN mag gets instance ID 1 currently, but has a higher prio, so should be used instead of the internal.
@pavel-kirienko Some help on debugging this appreciated.

Should be fixed by https://github.com/PX4/Firmware/pull/2914

Ok, issue isn't related to timestamping it seems. I'm beginning to thing that Brian's test on #2818 and mine were somehow false positives and it worked because of boot timing artifacts. Or mayhe this is a a regression.

The sensor voting class shows the UAVCAN mag as both #1 and #2, which is wrong, obviously :

attitude_estimator_q: mag status:
...
INFO  sensor #1:
INFO    val:   0.4045, lp:   0.4040 mean dev:   0.0000 RMS:   0.0003
INFO    val:  -0.0166, lp:  -0.0156 mean dev:   0.0000 RMS:   0.0005
INFO    val:   0.2360, lp:   0.2358 mean dev:  -0.0000 RMS:   0.0073
INFO  sensor #2:
INFO    val:   0.4045, lp:   0.4042 mean dev:   0.0000 RMS:   0.0003
INFO    val:  -0.0166, lp:  -0.0161 mean dev:  -0.0000 RMS:   0.0005
INFO    val:   0.2360, lp:   0.2359 mean dev:  -0.0000 RMS:   0.0073

The internal one #0 is used in the estimator only. The uavcan one isn't being used by default.
Stopping the lsm303d driver "testerror" shows proper successful fallback to internal. ```SENSOR FAILSAFE!"

attitude_estimator_q: mag status:
INFO  validator: best: 1, prev best: 0, failsafe: YES (# 12)

INFO  sensor #0:
INFO    val:   0.4067, lp:   0.4068 mean dev:  -0.0000 RMS:   0.0010
INFO    val:  -0.0409, lp:  -0.0408 mean dev:  -0.0000 RMS:   0.0009
INFO    val:   0.2849, lp:   0.2840 mean dev:  -0.0000 RMS:   0.0012
INFO  sensor #1:
INFO    val:   0.4045, lp:   0.4040 mean dev:   0.0000 RMS:   0.0003
INFO    val:  -0.0166, lp:  -0.0156 mean dev:   0.0000 RMS:   0.0005
INFO    val:   0.2360, lp:   0.2358 mean dev:  -0.0000 RMS:   0.0073
INFO  sensor #2:
INFO    val:   0.4045, lp:   0.4042 mean dev:   0.0000 RMS:   0.0003
INFO    val:  -0.0166, lp:  -0.0161 mean dev:  -0.0000 RMS:   0.0005
INFO    val:   0.2360, lp:   0.2359 mean dev:  -0.0000 RMS:   0.0073

@pavel-kirienko Where are the prios set for the UAVCAN sensor publications?

@LorenzMeier Any ideas on the above? I'm trying to debug it in any case.

Things seem to be quite messed up. How many magnetometers do we have onboard anyway? :O Booting without UAVCAN gives me this :
attitude_estimator_q: mag status:
INFO  validator: best: 1, prev best: 0, failsafe: YES (# 5)
INFO  sensor #0:
INFO    priority: 100
INFO    val:   0.3995, lp:   0.3995 mean dev:   0.0000 RMS:   0.0003
INFO    val:  -0.1543, lp:  -0.1543 mean dev:   0.0000 RMS:   0.0002
INFO    val:   0.2610, lp:   0.2610 mean dev:   0.0000 RMS:   0.0007
INFO
INFO  sensor #1:
INFO    priority: 50
INFO    val:   0.3829, lp:   0.3827 mean dev:   0.0000 RMS:   0.0010
INFO    val:  -0.1448, lp:  -0.1447 mean dev:  -0.0000 RMS:   0.0009
INFO    val:   0.2762, lp:   0.2745 mean dev:  -0.0000 RMS:   0.0012
INFO
INFO  sensor #2:
INFO    no data

Um, you're running out of memory.
I'm going to try to reproduce it tomorrow again, with the timestamping fix.

Booted with UAVCAN sensors disconnected:
attitude_estimator_q: mag status:
INFO  validator: best: 0, prev best: 0, failsafe: NO (# 0)
INFO  sensor #0:

INFO    priority: 50

INFO    val:   0.0201, lp:   0.0202 mean dev:  -0.0000 RMS:   0.0006

INFO    val:  -0.1301, lp:  -0.1297 mean dev:   0.0000 RMS:   0.0012

INFO    val:   0.3862, lp:   0.3861 mean dev:   0.0000 RMS:   0.0007

INFO  sensor #1:

INFO    no data

INFO  sensor #2:

INFO    no data

attitude_estimator_q: running

So far so good.
Connecting Zubax GNSS while PX4 is running:
attitude_estimator_q: mag status:
INFO  validator: best: 0, prev best: 0, failsafe: NO (# 0)
INFO  sensor #0:

INFO    priority: 50

INFO    val:   0.0132, lp:   0.0136 mean dev:  -0.0000 RMS:   0.0007

INFO    val:  -0.1322, lp:  -0.1324 mean dev:  -0.0000 RMS:   0.0016

INFO    val:   0.3874, lp:   0.3876 mean dev:   0.0000 RMS:   0.0007

INFO  sensor #1:

INFO    priority: 75

INFO    val:  -0.2091, lp:  -0.2092 mean dev:  -0.0000 RMS:   0.0001

INFO    val:   0.0488, lp:   0.0488 mean dev:   0.0000 RMS:   0.0001

INFO    val:   0.4819, lp:   0.4819 mean dev:  -0.0000 RMS:   0.0001

INFO  sensor #2:

INFO    priority: 75

INFO    val:  -0.2119, lp:  -0.2105 mean dev:  -0.0000 RMS:   0.0001

INFO    val:   0.0506, lp:   0.0505 mean dev:   0.0000 RMS:   0.0001

INFO    val:   0.4838, lp:   0.4837 mean dev:   0.0000 RMS:   0.0001

attitude_estimator_q: running

Wat?
Ok, rebooting PX4 with Zubax GNSS still connected:
attitude_estimator_q: mag status:
INFO  validator: best: 0, prev best: 0, failsafe: NO (# 0)
INFO  sensor #0:

INFO    priority: 50

INFO    val:   0.0139, lp:   0.0138 mean dev:   0.0000 RMS:   0.0006

INFO    val:  -0.1322, lp:  -0.1322 mean dev:  -0.0000 RMS:   0.0012

INFO    val:   0.3880, lp:   0.3880 mean dev:  -0.0000 RMS:   0.0007

INFO  sensor #1:

INFO    priority: 75

INFO    val:  -0.2099, lp:  -0.2099 mean dev:  -0.0000 RMS:   0.0005

INFO    val:   0.0515, lp:   0.0515 mean dev:   0.0000 RMS:   0.0004

INFO    val:   0.4802, lp:   0.4801 mean dev:  -0.0000 RMS:   0.0004

INFO  sensor #2:

INFO    no data

The phantom magnetometer disappeared again.
This is what uavcan status tells me:
nsh> uavcan status
ESC actuators control groups: sub: 0 / req: 0 / fds: 2
ESC mixer: NONE
Sensor 'gnss':
RX errors: 0, receiver node id: 125

Sensor 'mag':
devname: /dev/mag
channel 0: node id 125 --> class instance 1
channel 1: empty
channel 2: empty
channel 3: empty
channel 4: empty

Sensor 'baro':
devname: /dev/baro
channel 0: empty
channel 1: empty
channel 2: empty
channel 3: empty
channel 4: empty

Where did the third magnetometer come from?
Why the priority of mags 1 and 2 is 75, whereas it is configured as ORB_PRIO_HIGH, which is 100?
Why does the estimator prefer a sensor with priority 50 instead of 75?

75 is ORB_PRIO_DEFAULT, so something is not going right when those are advertised or evaluated.

Please re-try with master. I've improved the failover logic, in particular for cases where a higher priority sensor becomes available later.

Is the fw server running?  Could there be 2 node ids, one at boot, then switched to a new one based on the uuId byte ordering or parameter stored fo node Id?

David, no, since the bootloader doesn't publish sensor msgs
On Oct 3, 2015 4:32 PM, "David Sidrane"<EMAIL_ADDRESS>wrote:

Is the fw server running? Could there be 2 node ids, one at boot, then
switched to a new one based on the uuId byte ordering or parameter stored
fo node Id?
—
Reply to this email directly or view it on GitHub
https://github.com/PX4/Firmware/issues/2912#issuecomment-145249344.

[3:12:15 PM] lm.office: So by default the system should have two mags
[3:12:22 PM] lm.office: When GPS is connected
[3:12:24 PM] lm.office: One else

Doesn't seem to be the case - see my posts from yesterday.

[3:12:36 PM] lm.office: The 2nd mag has to be related to UAVCAN
[3:15:01 PM] lm.office: Check this:
[3:15:02 PM] lm.office: https://github.com/PX4/Firmware/blob/b067a0c09438575dc42601b156aa426b26bf07d2/src/lib/ecl/validation/data_validator_group.cpp#L111-L113
[3:15:13 PM] lm.office: If there is an issue with the priority handling, its there

Seems to be unrelated - see below.

[3:17:07 PM] lm.office: I would put a printf into the sensor_bridge.cpp advertise code
[3:17:12 PM] lm.office: Check if it advertises twice

Checked, no it doesn't advertise twice.
However, I found something weirder that I don't understand.
1. Stack size
When dealing with weird issues I check stack usage, which I did this time. I noticed that top reports that the UAVCAN thread has only 90 bytes of stack free, which may lead to undetectable stack overflows, so I increased it by 1.5K (just to be on the safe side), and peak stack usage increased by ~20 bytes as well, under the same testing conditions. It didn't resolve any of the known issues though. Nevertheless, I think it makes sense to enlarge the stack by at least 300 bytes (@davids5 is going to like it).
2. Advertisement logic
Either it's flawed or I'm missing something.
We have this code in UavcanCDevSensorBridgeBase which tries to acquire a class instance for a given UAVCAN sensor node, see https://github.com/PX4/Firmware/blob/master/src/modules/uavcan/sensors/sensor_bridge.cpp#L110. Once a class instance is acquired, it will be used as a suffix for device name, e.g. /obj/sensor_magX in place of the X. First problem: the code that does this acquiring doesn't seem to influence actual ORB advertisement in any way - follow the code path and you'll see that they are completely unrelated. The issue seems to be introduced with this change.
Then, the call to orb_advertise_multi() eventually brings us to uORB::DeviceMaster::ioctl(). It fails to init() a new DeviceNode because /obj/sensor_mag0 already exists, so it deletes it and claims the existing node instead. Priority seems to be disregarded completely, or I don't see where and how it is passed to the claimed node.
Also, delete node caused my GDB to complain about missing vtable, which normally hints to memory corruption, but I couldn't find any issues with that manually, so it could be caused by the IDE trying to update fields of a deleted object in the Variables view - I'm not sure.
Any suggestions?

You need to untangle the class instance from the ORB publication. They are entirely unrelated.
The issue is potentially here:
https://github.com/PX4/Firmware/blob/master/src/modules/uavcan/sensors/sensor_bridge.cpp#L123
&channel->orb_instance

Has to be a valid pointer:
https://github.com/PX4/Firmware/blob/master/src/modules/uORB/uORBDevices_nuttx.cpp#L593
The logic then tries to find the first free uORB group ID and allocates it. It should never try to allocate an existing one.

@LorenzMeier

You need to untangle the class instance from the ORB publication. They are entirely unrelated.

They are untangled. I just compared the logic of uURB advertisements in UAVCAN with the HMC5883 driver, seems identical.

Has to be a valid pointer:

It is a valid pointer.
So the issue is elsewhere, apparently.

@LorenzMeier I would appreciate if you could have a look at it. I checked with a debugger that the UAVCAN driver advertises the mag topic only once, yet the attitude estimator sees two sensors.

@pavel-kirienko Can you try checking the status output when UAVCAN is enabled, but with the cable unplugged? I remember something was weird, which might help us.
I don't have the uavcan MAV right now with me to test.

Looks sane to me (cable unplugged):
nsh> uavcan status
uavcan: application not running
nsh> uavcan start
uavcan: Node ID 1, bitrate 1000000
uavcan: SW version vcs_commit: 0x11a42b0b
uavcan: sensor bridge 'gnss' init ok
uavcan: sensor bridge 'mag' init ok
uavcan: sensor bridge 'baro' init ok
nsh> uavcan start fw
nsh> attitude_estimator_q status
attitude_estimator_q: gyro status:
INFO  validator: best: 0, prev best: 0, failsafe: NO (# 0)
INFO  sensor #0, prio: 100
INFO    priority: 100

INFO    val:  -0.0022, lp:  -0.0022 mean dev:   0.0000 RMS:   0.0011 conf:   1.0000
INFO    val:  -0.0047, lp:  -0.0049 mean dev:   0.0000 RMS:   0.0011 conf:   1.0000
INFO    val:   0.0126, lp:   0.0126 mean dev:   0.0000 RMS:   0.0005 conf:   1.0000
INFO  sensor #1, prio: 75
INFO    priority: 75

INFO    val:   0.0035, lp:   0.0074 mean dev:   0.0000 RMS:   0.0048 conf:   1.0000
INFO    val:   0.0099, lp:   0.0086 mean dev:   0.0000 RMS:   0.0075 conf:   1.0000
INFO    val:  -0.0013, lp:   0.0003 mean dev:  -0.0000 RMS:   0.0029 conf:   1.0000
attitude_estimator_q: accel status:
INFO  validator: best: 0, prev best: 0, failsafe: NO (# 0)
INFO  sensor #0, prio: 100
INFO    priority: 100

INFO    val:  -0.3575, lp:  -0.3588 mean dev:   0.0000 RMS:   0.0069 conf:   1.0000
INFO    val:   0.1259, lp:   0.1217 mean dev:   0.0000 RMS:   0.0069 conf:   1.0000
INFO    val:  -9.8629, lp:  -9.8600 mean dev:  -0.0000 RMS:   0.0131 conf:   1.0000
INFO  sensor #1, prio: 75
INFO    priority: 75

INFO    val:  -0.3626, lp:  -0.3782 mean dev:  -0.0000 RMS:   0.0203 conf:   1.0000
INFO    val:   0.1893, lp:   0.1935 mean dev:  -0.0000 RMS:   0.0172 conf:   1.0000
INFO    val:  -9.9017, lp:  -9.9288 mean dev:   0.0000 RMS:   0.0301 conf:   1.0000
attitude_estimator_q: mag status:
INFO  validator: best: 0, prev best: 0, failsafe: NO (# 0)
INFO  sensor #0, prio: 50
INFO    priority: 50

INFO    val:  -0.3459, lp:  -0.3460 mean dev:   0.0000 RMS:   0.0015 conf:   1.0000
INFO    val:   1.0389, lp:   1.0405 mean dev:  -0.0000 RMS:   0.0024 conf:   1.0000
INFO    val:   0.5118, lp:   0.5113 mean dev:   0.0000 RMS:   0.0009 conf:   1.0000
attitude_estimator_q: running

Hmm.
Did you tryout this pull? : https://github.com/PX4/Firmware/pull/2918
If it works for now, we can track down the phantom mag later.

Can you try with UAVCAN startup at boot?

 It seems different but very close to the 2nd mag, so the publication has to come from UAVCAN.

Does your phantom mag change values, or is it frozen at one value?

Yes it does change values.

@pavel-kirienko #2918 gets the mag into a working state atleast, irrespective of the phantom magnetometer.

@LorenzMeier it would help a lot if you or someone else familiar with internals of uORB could have a look at this issue (related https://github.com/PX4/Firmware/issues/3122). It looks like the problem is caused by uORB rather than UAVCAN driver (see my descriptions above). Thanks in advance.

Could you please repro with current master, just so we're sure we're not chasing a ghost? I will try to come up with a unit test catching this.

Yep 100% repro. Just tried.

Thanks. Will dig into this.

@LorenzMeier @pavel-kirienko
I had a in-depth look into the voter class today, and I noticed the reason why we keep going into failsafe.
It keeps switching between mags 0(internal) and 1 (uavcan) continiously. Some debugging shows
that :

First it takes the mag 1 as best (this is good)
Then quite randomly it switches down to mag 0 (this is a failsafe event), even though mag 1 has greater priority.
Then again goes back to 1 as best (not failsafe)
2 and 3 keep happening contniniously, with some delay in-between.

@pavel-kirienko If you could do some more debugging here, it would be appreciated.

Woohoo. Gotcha - we got the exact same sensor value N times in a row.
That's what causes the failsafe.
@pavel-kirienko Your game now, I guess.

@mhkabir I can't repro this. See the log: ftp://pkir.net/px4_uavcan_mag_samples.txt.
I have added this to your branch to print the mag values:
diff --git a/src/modules/uavcan/sensors/mag.cpp b/src/modules/uavcan/sensors/mag.cpp
index e184ff1..d2a3926 100644
--- a/src/modules/uavcan/sensors/mag.cpp
+++ b/src/modules/uavcan/sensors/mag.cpp
@@ -160,5 +160,6 @@ void UavcanMagnetometerBridge::mag_sub_cb(const uavcan::ReceivedDataStructure<ua
        _report.z = (msg.magnetic_field_ga[2] - _scale.z_offset) * _scale.z_scale;
        unlock();

+       DEVICE_LOG("V %.6f %.6f %.6f", double(_report.x), double(_report.y), double(_report.z));
        publish(msg.getSrcNodeID().get(), &_report);
 }

It can be seen in the log that the sensor values do not get anywhere close to 100 successive identical values prior to failure.

I put in debug printfs here:

https://github.com/PX4/Firmware/blob/master/src/lib/ecl/validation/data_validator.cpp#L126
https://github.com/PX4/Firmware/blob/master/src/lib/ecl/validation/data_validator_group.cpp#L157

Whenever the switching was occurring, I can clearly see the validator dropping the confidence to zero, trigerring the first printf, and then the second one. Please see if you can repro this from inside the validator.

This is completely fixed by :

#3171
#3183
Zubax GNSS update to increase magnetometer data rate (@pavel-kirienko)

These, once done gives us complete and working UAVCAN sensor support (related : #3158) just in time for the v1.1.0 release :)

I'm closing this for now. Looks like we need to set up our own vehicle with UAVCAN to debug this.