Mapbox/React wrapper

I was curious and tried Uber's Mapbox/React wrapper: https://visgl.github.io/react-map-gl/
This is just experimental and not meant to be merged in the current state. This branch is also based on top of #77 and #75, but that should not be so important. I just did not want to do the migration without the fix in #77 and before the path detail code was moved out of the map component in #75.
The philosophy of the wrapper is interesting: https://visgl.github.io/react-map-gl/docs#design-philosophy
The wrapper is meant to address the problem that Mapbox is stateful and therefore does not integrate so well with React. We already faced some of the related issues like switching the background layer without re-creating the Map component or changing the bounding box in #72 etc. So I was hoping using this wrapper the viewport updates and the style switching feels more natural.
The migration actually went relatively smooth and I did not run into bigger issues yet. The state handling definitely feels better to me and it seems like less workarounds are required.
Other advantages could be that according to the documentation the wrapper works with mapbox-gl 1&2 and maplibre as well (I only tried mapbox-gl 1 so far) (#81)  and it will be easier to move the different map layers out of the central map component (#78), just like I already moved out the viewport state handling. Another advantage could be easier integration with deck.gl (but I am just speculating and not sure if we even need this). Anyway, so far I do not see many reasons not to use the wrapper. At least we should keep this in mind and maybe comeback here when we see more issues related to the Mapbox state management for example.
I will update this branch when #75 and #77 are finished so it will be easier to track the changes. Otherwise, there are the following todos on this branch to make it equal to master/#75/#77, currently (feel free to edit this in case you notice something):

[x] use actual marker symbols for query points and the path detail hovering. this should not be a real problem, but I just could not find any default marker svgs to use. For the path detail marker we might need to adjust the code because I could not find a way how to use the HTML node we get from heightgraph currently as marker. improve look of the point markers and the path detail marker. so far I use a rather ugly point marker and just open a popup for the path detail marker. -> postponed to #106
[x] put back the long touch handler (I just commented it out for now)
[ ] tune the fly to animation (it looks like its not entirely the same as before yet)
[x] the Popup is missing the closeOnMove option
[x] missing maxBounds option for the map (it zooms out too much)
[x] should we move each map layer to a separate file/component so Map.tsx does not have to deal with all the different things? I think so and did this in #108

On the other hand this branch already fixes #82 (and maybe #80 as well) and it also implements the missing 'center map' context menu entry.

I basically replaced our Map component and our Mapbox class with the new Map component that uses the wrapper. With the wrapper it seems like we do not need both Map.tsx and Mapbox.ts. But anyway we should get #75 and #77 merged before and if you want I can then move some of the new Map code into Mapbox.ts so the diff becomes more readable. Currently this PR does not just work. See the todo list in my initial comment.

I think this PR is already in a good state. We could improve the look of the markers also after merging it IMO and do this together with #106. Should we move the different map layers to separate components already (related #78). They already are components so all we need to do is move them to separate files. For example we could create something like:

ContextMenuLayer
QueryPointsLayer
PathsLayer
PathDetailLayer (marker + highlighted path segments)

missing maxBounds option for the map (it zooms out too much)

I'd like to get this done for this PR ideally, but unfortunately I could not make this work yet. I think we have to restrict the viewport in ReactMapGL#onViewportChange, but the tricky thing is to obtain the zoom level for the given width and height so the maximum browser window space is used, but we do not show 'dead space' left and right of the map as we currently do in this branch:

tune the fly to animation (it looks like its not entirely the same as before yet)

I don't have a strong preference here, but feel free to adjust this. This should be possible using the options in ViewportStore#reduce(SetViewportToBbox).

so all we need to do is move them to separate files

Haha, except this seems more complicated than I thought. I still find this very appealing, but it seems like we should do this in a follow-up PR for #78.

I think we have to restrict the viewport in ReactMapGL#onViewportChange

This is working now. I think this PR is ready to go

When I load the map without parameters, the bounding/viewport is a little off

When I load on full screen i get the following error:
Uncaught Error: `longitude` must be supplied
    at assert (assert.js:6)
    at new MapState (map-state.js:74)

When I load on full screen i get the following error:

I had the same error on initial map load here: a9ab9a792ee7d19d602a7d4057eef7fbb19634d1, but only in Chrome and not in Firefox. How do you load full screen? Do you mean browser full screen or Mapbox full screen (not implemented yet I thought, #20).

When I load the map without parameters, the bounding/viewport is a little off

Are you sure you use the latest commit? I fixed this in one of my last commits.

Are you sure you use the latest commit? I fixed this in one of my last commits. This one specifically: 7623366

I din't

How do you load full screen?

I mean the window being sized to full screen, but the frame still showing

I mean the window being sized to full screen, but the frame still showing. It happened on both, Firefox and Chrome

I cannot reproduce this? Do you still see this since you updated?

I cannot reproduce this? Do you still see this since you updated?

It seems to be gone now :-)

It seems to be gone now :-)

You probably pulled the broken version, this problem existed for a few commits and I only fixed it today, because it did not show up in Firefox for some reason.

Btw the bounding box is now more fixed than in master. In master we see empty space above the map when we scroll vertically (and zoom out too much)

Btw the bounding box is now more fixed than in master. In master we see empty space above the map when we scroll vertically (and zoom out too much)

I like this very much. The white bars were terrible.

This is nice :+1:

So, I changed the Dispatch stuff and moved everything into the Viewport store.
I also noticed that there is no easing on zoom. Do we need to specify an easing function? The examples on the mapbox component page seem to have a smooth animation when I zoom by mouse wheel.

Unit testing? At least of the store?

I also noticed that there is no easing on zoom. Do we need to specify an easing function? The examples on the mapbox component page seem to have a smooth animation when I zoom by mouse wheel.

Yes, see the end of this comment https://github.com/graphhopper/graphhopper-maps/pull/87#issuecomment-861418655 and the todo in the calculateLatLngFromBbox function. I just wasn't sure what we want here, but feel free to tune this.

So, I changed the Dispatch stuff and moved everything into the Viewport store.

Thanks for this. To me it seems a bit strange that the ViewportStore knows about all the routesuccess, pathdetail etc. actions. Changing the viewport rather seems like a basic feature of the map that is used by different more specific features (like routes and path details). So I would have expected the dependency the other way around: The route store (same with path detail) is a client of the viewport store. For example when we add more features that modify the viewport I would rather add more client code that uses the viewport store than modify the viewport store's reduce function every time.

To me it seems a bit strange that the ViewportStore knows about all the routesuccess, pathdetail etc. actions

That's an intersting question. I've thought of a store as something which holds and manages a portion of the app's state. The store reacts to Actions happening in the app and updates its state accordingly. So, when we want the viewport to be different after a certain event occured, the ViewportStore should take care of it. Also, every action is dispatched to every store anyway, so that every store knows about every action already.

I would rather add more client code that uses the viewport store than modify the viewport store's reduce function every time.

I think the set of actions our app has should represent the events that happen in our app. Introducing actions like the SetViewportFromBbox action don't actually represent an action of the app but a desired change to the state caused by something else ( a successfull routing request for example)

Ok, I understand there is a difference between 'reacting to a state change' and sending an event like SetViewportFromBBox. So feel free to leave it like this for now and I might think about this a bit more.

Also, every action is dispatched to every store anyway, so that every store knows about every action already.

No, I don't think so. Every action is passed to every store yes, but the code of the different stores is not coupled to all actions and the stores do not contain any code related to actions they do not handle explicitly. We can add/remove actions without changing all the stores. But now we cannot remove the path detail stuff (for example not needed for isochrone) without adjusting the (IMO unrelated) viewport changing code.

Unit testing? At least of the store?

I added a test in my last commit. It is actually quite nice that we can test the viewport transitions on this level now.

This seems to solve several issue like @easbar said also the issue where the elevation widget hides the routes. It zooms also to the route when you select the alternative route which is really nice.
There is a minor problem with the path details widget (not too important :) ) but it is hard to describe. Sometimes the elevation/pathdetails data does not show up when the mouse goes over the area (try left and right). There seem to be areas that just do not work.
Hm ... the path detail widget with current mapbox seems to have this problem too but only for small areas of the widget.

also the issue where the elevation widget hides the routes

Yes, even though this was unrelated to the wrapper: https://github.com/graphhopper/graphhopper-maps/pull/87#discussion_r654781011

I just played chaos monkey a bit more and now an error occurred when using the same coordinates (like #36). But now something like "e is undefined". To prevent this from re-introducing it again, would we need something like playwright or cypress or is this possible in unit tests?

This error occurs because we do this on the server-side:
java
 if (p.getPoints().size() >= 2) {
     jsonPath.putPOJO("bbox", p.calcBBox2D());
 }

so when the points are identical the bbox field is missing and we do not handle this yet. Things like this can be tested without UI/browser tests.

Should we change this on the server-side? It seems a bit ugly that the bbox is missing in this case. Why not just return [lat, lon, lat, lon] in case we request a route from (lat, lon) to (lat, lon)?

I made the error more visible by using a debug build for aws: d731b67d9add4c328bfe2f2d06d3a86f6a21b4aa and logging errors for /route requests: fcfccc5860de50f92a653c18d8147e7af7b85e63

I wasn't able to find the reason but will change this on the server side as this made problems before. The oldest location seems to be here.


 Implement better tracking to figure out why this is happening, then fix it.

Looks like removing the cancellation token doesn't fix it. Something else is causing the task to drop off.


Fix scrolling to pickers

Details

Based on this PR to our react-native-picker-select fork

Fixed scrolling to input components on Web
Added conditional ref-forwarding logic in components/Picker

Fixed Issues

$ https://github.com/Expensify/App/issues/14783
PROPOSAL: https://github.com/Expensify/App/issues/14783#issuecomment-1468874717
Tests

Go to Settings > Workspaces > (any workspace) > Reimburse expenses > Connect bank account > Connect manually
Perform "Connect bank account (Step 1 of 5) anyhow (for example, fill: 011103093 / 067014822)
Input correct values for all inputs before "State" picker, but leave "State" empty ("-")
Click/tap some text input nearby
Scroll the view, so the "State" field is out of sight (it should be possible on all platforms)
Press "Save"
Press "Fix the errors"

[ ] Verify that other inputs lost focus

Ensure the keyboard is hidden
Ensure that text inputs don't have blinking cursor

[ ] Verify that the view scrolled to the picker

Offline tests

QA Steps
See Tests

[ ] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android / native
[x] Android / Chrome
[x] iOS / native
[x] iOS / Safari
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is correct English and approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)

[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected. (Form storybook stories don't work for me on main)
[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[x] I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

Hey! I see that you made changes to our Form component. Make sure to update the docs in FORMS.md accordingly. Cheers!

I have read the CLA Document and I hereby sign the CLA

@parasharrajat I'm still going over the checklist, I'll continue tomorrow.
I tried to check relevant documents, conventions, and apply common sense.
For now, I'm wondering if we should include another form in the testing steps, as the one mentioned in the original issue ("Add debit card") doesn't really allow for scrolling on a typical screen on Android.
This form would work...:

...but I still haven't found the path to manually trigger this flow.

On iOS the scroll view scrolled to the picker, creating extra "stretched" void on the bottom of the screen

@parasharrajat This is an interesting property of iOS scroll view. I personally don't have much against this effect, but we need to ensure that it is acceptable behavior.

@parasharrajat Do you have thoughts on the focusRef naming? Pointing the ref to any internal widgets breaks the test suite, like I mentioned. Not obvious for me what are the work-arounds. If we'd do any pivoting, it's best to make that decision early, I think!
Also it's my first time sketching all the "Testing" sections, so any tips if I'm doing it right would be very appreciated!

@parasharrajat

I ran the tests on all platforms & verified they passed on

Is this about the automated tests or the manual steps I describe? I'm a bit confused. Are automatic tests platform-dependent?

@parasharrajat This is an example, when the user leaves out "Legal buisness name" and "State" fields in the "Company information" form on Web.
They press "Fix the errors", the form scrollst to "Legal buisness name", they fix the error, press "Fix the errors" again, then seemingly the form scrolls to "Legal buisness name" again.
https://user-images.githubusercontent.com/2590174/227182548-36219047-e1b4-4549-ac72-a12a93b47850.mp4
It actually scrolls to "State", but focusing at the center (inconsistent with other inputs).
It's because with the current approach, we don't ensure that the focus/measureLayout contract is fulfilled, at least not on the Web. Our in-app scrolling logic is not launched, and instead we rely on the side-effect of focus that happens on Web, which has different behavior than the in-app logic.
I would still propose to do things consistently, also on the Web, unless we have any technical arguments against it:
https://user-images.githubusercontent.com/2590174/227190078-c830998b-2c30-49a8-8987-b21ad01de438.mp4
What would you say?

@johnmlee101 @parasharrajat One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

Please Mark this PR Ready for review.

Done. But some checkboxes aren't done yet, I'll update them very soon. Also, while the PR might be ready for review (and was ready for early review before), I wouldn't say it's ready to merge until we figure out if the scrolling on Web works as expected

@parasharrajat
@johnmlee101
Hey guys, while I'm sorry that this came out this late (I spent too much time on the technicalities, including GPG and alike, it's on my side), but I'm starting to question whether the "forward ref to RNPicker's TextInput" works at all. While scrolling to the picker actually does work (at least on mobile, proving that TextInput's measureLayout works as expected), the main "selling point" of that approach was bullet-proof blur/focus behavior.
After I resolved all technical discussions and started to do all the heavy testing, I can't see any blur/focus behavior with this approach. I'm very uncomfortable with this, as it would mean that the original author never really tested it or that I can't get this to work because of some silly mistake on my side.
https://user-images.githubusercontent.com/2590174/227511679-e2d61ab7-02d3-4c2f-831e-eaaff9c31adb.mp4
It's difficult for me, as I'm working with not-fully-my proposal, but I have to take responsibility for it (as I agreed to that, and I know that).
Still, I ask you for a big favor of checking out the code, and verifying (both by reading the code and hands-on) if I implemented the "forward-to-internal -extInput" right and if you reproduce my results.

I think it is fine, we agreed to not add any UI for the focused state. #14783 (comment)

What is fine? Could you elaborate?
Have you seen the video in this post?
The focus call on the "State" picker is a total no-op, it doesn't remove the cursor from the "Zip code" input, it doesn't hide the keyboard, it doesn't do anything.
I'm not talking about styling.

Oops. So yeah, you mentioned in your proposal to blur the inputs before focusing. Is that not working?

The "forward-to-TextInput" approach from this proposal doesn't have the blur-all block. As I understood it, it was meant to just work, re-using the TextInput shared focus. And it appears that the focus method in this approach is actually a no-op (a call doing absolutetly nothing) in case of pickers.
The only thing it does is getting a working measureLayout from that TextInput, which gives no benefits (on the technical and practical level, it's not really an opinion here) over my proposal in its actual state. Actually, it's a bit worse, as the bounds of the root View are slightly more appropriate as a scrolling target.
I can add the blur-all block, and it's not a problem, but effectively we're just falling back to my original proposal. Do I have a green light to just do the things my way, i.e. the way that I tested, proposed, and which works? 🙂
Unless I'm missing something and there's some technical benefit of TextInput's measureLayout over root View's measureLayout. Please tell me if there is, we can't afford being on different pages here at this point.

And I'm telling you that forwarding the ref to the TextInput does nothing useful. 😉 And definitely doesn't the thing it was meant to do, i.e. providing a working focus.
So I'll just drop that, okey? The other PR will be unnecessary.

@parasharrajat

Does that sound good?

I would lie if I said it did. I don't understand the reasoning here, and this makes me feel uncomfortable. But I still respect your decision.
The changes as I see them live on this branch. They are split into a few commits, each of them doing one thing. If you'd like to review the my approach, I would recommend doing it there.
I'll try to cherry pick those changes or parts of them, so the continuity of this PR is kept.

I meant to say that we can decide on it later... First thing is to get the PR ready with all the fixed and as planned during the proposal review.

The plan derailed, from my perspective. There were assumptions behind that plan and they fell. But yup, we can go back to it in later.
I cherry picked the changes from the second branch.
@parasharrajat Commits are ready for you

There are a few commits that are not signed. Can you please sign all commits?
This should help you to sign and keep the history. https://superuser.com/a/1123928
Please complete the checklist. Check off the items that do not apply to you.
Must read:
* https://github.com/Expensify/App/blob/main/contributingGuides/CONTRIBUTING.md

I read that document at the time of writing the proposal. Unfortunatelly, I didn't remember everything. I'm sorry about that.
I believed that I configured GPG right, I'll check why the non-GPG-signed commits slipped in. Sorry about that. I'll fix that.

You can configure the GPG signing for all commits in this repo. git config commit.gpgsign true

I did, and I also did the exec trick yesterday. That's why I'm not sure how the non-signed commits slipped in. But that doesn't matter. I'll be double checking now.

@parasharrajat A new changeset pushed 😃

@parasharrajat I believe all threads are correctly resolved. Let me know if you have any more thoughts!
I'll do some more final testing today to ensure that no regression slipped in. It would be awesome to have this merged today, as the first soft (bonus-related) deadline passes in a few hours 😀

@parasharrajat Cool!
I performed manual test steps on Android, iOS and Web once again. All good.
I also ran npm run tests. All good.

@cubuspl42 Please merge main into this.

It has to be merge, or is rebase also okey?

To be honest the size of this PR got out of hand, it's 22 commits 🙈 Is there any way to rewrite it, confirming it has the same diff as the current state?

@parasharrajat Anyway, I did the merge, but please tell me if it's alright. It's the first merge in my professional career, in the companies I worked on, and same in my personal projects, I only rebased. 🙈

It's fine.

Okey 🙃 Let me know if I can help with anything. Technically I'm past my working hours, but I'll be online for around half an hour.

@parasharrajat I pushed new changeset

@parasharrajat Actually, I'm still not sure about how the timeline works in detail, as it's my first accepted proposal.
After the C+ review, does another "internal engineer review" start? Is there a chance to finish the whole process before the 50% penalty kicks in?
Are there any ways I, as the contributor, can help to make that happen?

For this issue, I think the timeline is already crossed. The timeline starts from the time moment you are assigned to the issue(Bot message).

We already crossed the -50% penalty deadline? That one is 6 business days, right? There should be still some time left, I think
Or are you talking about the bonus deadline? Because that one is past us, that's right. 😔 I would be grateful for any feedback on how I could have a chance for it next time

@parasharrajat I'll note the feedback, thanks. From my side, I feel like some of the review rounds didn't really comment on things I introduced in the previous rounds, making it unclear why they weren't merged with the previous rounds.
But on the other hand, it might have been a bit too ambitious of me to hope for the bonus on the first issue. With the lessons learned, it might be achievable next time 😊
Cool, it's good to hear that you don't expect us to cross the penalty-causing deadline 😃
I'll be closing my workday, we can resync tomorrow.

Also, I noticed a jump in iOS Safari. Any idea what can be done about this?

I'm not even sure I reproduce it.
https://user-images.githubusercontent.com/2590174/228459931-b33929e5-366c-4607-81c2-2023a85e6bed.mp4
This looks like a slight delay with hiding the keyboard. The empty space on the bottom is just a left-over that was allocated in the layout for the keyboard. If, for debugging purposes, we modify the Form.js code:
                <FormAlertWithSubmitButton
                    buttonText="Dismiss the keyboard"
                    // ...
                    onSubmit={() => {
                        Keyboard.dismiss();
                    }}

We also observe this behavior after that modification:
https://user-images.githubusercontent.com/2590174/228461434-ff67da39-0fda-4ca5-8b48-a33a62d245cd.mp4
This even happens when we press the checkbox when the keyboard is visible:
https://user-images.githubusercontent.com/2590174/228463127-7dca2577-3f70-4468-ae00-547eb364be1a.mp4
What is more, we also observe this on main:
https://user-images.githubusercontent.com/2590174/228464256-e34c3a94-e0cc-4264-a19e-092948717c37.mp4

Console Warning: Web:

Ouch.
So actually that FormSubmit prop validation doesn't work 🙁
I took a look at the console after that change, but I missed this warning.
I'll try to figure out something later today, unfortunately, I can't do this at this very moment.

Ok, let's get the. Warning fixed. I suppose we have to pass a noop function to the default value of that prop.

Like this?
const defaultProps = {
    innerRef: () => {},
    style: [],
};

Doesn't work, the warning is still present.
I'll try to figure something out.

Ok, Let me look into that. I don't want to hold this PR just for that.

While this sounds weird, in my observations the warning is non-deterministic. When I refresh the page, it sometimes is printed, and sometimes not. So I tried things that seemed to work, but after 10 more refreshes the warning returned. It doesn't help that the warning doesn't include what's wrong with innerRef. Printing out ref before it's passed like innerRef={ref} doesn't help; the ref looks alright, I guess?
So the thing looks a bit weird and I'm not really getting it

Lint failures

Lint failures
@johnmlee101 Ouch. Sorry about that. I'll push the fix in a few seconds.

Does the PR look good otherwise?

@johnmlee101 The PR was approved by @parasharrajat before I removed the unused import. So from my perspective it's effectively approved by both of you.

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to staging by https://github.com/johnmlee101 in version: 1.2.95-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/thienlnam in version: 1.2.95-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


chore(main): release eslint-config-fuf 0.9.1

:robot: I have created a release beep boop
0.9.1 (2024-04-16)
Bug Fixes

eslint-config-fuf: add support for cn in tailwind (3ae3047)

This PR was generated with Release Please. See documentation.

:robot: Release is at https://github.com/fuf-stack/ts-project-setup/releases/tag/eslint-config-fuf-v0.9.1 :sunflower:


Fix subscription argo app of apps topology 2.7

Signed-off-by: Feng Xiang<EMAIL_ADDRESS>Issues:
https://github.com/stolostron/backlog/issues/25299
https://github.com/stolostron/backlog/issues/25279

Fix AppSet status showing error when deployed as a cluster resource
Fix AppSet details complaining about no placement
Fix Argo app details showing warning because it didn't recognize the status Healthy

/test lint-check-unittests-sonarcloud


No output with the actual genome/contigs clusters sequence

Dear developers,
Thank you for the useful good tool. I have followed your instructions manual, however, by running gclust exactly as you did, no output file with the actual clusters nucleotide sequence is produced. Only a list of the clusters with the genomes/contigs in each.
It would be a much better and easy to use tool, if will produce a similar output like cd-hit does, with a representative clusters fasta file.
Thank you and best regards
Vadim

Hi!
Thank you for your great suggestions. Considering that the large input genome will affect the I/O performance of the software, we wrote a shell script to run when needed. For specific examples, please refer to Example step 3 in the README.md file.
Best regards
Ruilin

Dear developers,
Thank you for the useful good tool. I have followed your instructions manual, however, by running gclust exactly as you did, no output file with the actual clusters nucleotide sequence is produced. Only a list of the clusters with the genomes/contigs in each.
It would be a much better and easy to use tool, if will produce a similar output like cd-hit does, with a representative clusters fasta file.
Thank you and best regards
Vadim

I had the same question before.
I have written a similar script like example step 3 to solve this, with name "gclust2fa.py".
# get the clusters' representative sequences from fasta and glust_cluster_output
# usage: python3 gclust2fa.py raw.fa gclust.out cluster.fa
# input just like:
'''
>Cluster 0
0       5888230nt, >seq1... *
>Cluster 1
0       4800869nt, >seq2... *
>Cluster 2
0       3906592nt, >seq3... *
1       20nt, >seq4... at -/100.00%

'''

import sys

# input:
fasta_file = sys.argv[1]
# glust.out
clust_file = sys.argv[2]
# output:
outfa = sys.argv[3]
if fasta_file == outfa:
    exit()

representative_ctgs = dict()

i = 0
with open(clust_file) as f:
    for line in f:
        if line.startswith('>'):
            i += 1
        else:
            temp = line.rstrip().split()
            if temp[-1] == '*':
                representative = 1
            else:
                representative = 0
            if representative == 1:
                ctgname = temp[2].rstrip('.')
                representative_ctgs[ctgname] = ''

print("Representative number: " + str(i))

outFlag = 0
with open(outfa, 'w') as fout:
    with open(fasta_file) as f:
        for line in f:
            if line.startswith('>'):
                if line.rstrip() in representative_ctgs:
                    outFlag = 1
                else:
                    outFlag = 0
            if outFlag == 1:
                fout.write(line)


add .gitignore

one thing to add is pycache, git ignore pycache. list other things to ignore below

Addressed in #2 as well


Closures are transpiled with an empty self argument when stored as a variable

Example
this.resolve_contact = (a: Fixture, b: Fixture, coll: Contact) => {
  const a_entity = a.getUserData();
  const b_entity = b.getUserData();

  if (this.check_contact(a_entity, b_entity)) { return; }

  this.store_contact(a_entity, b_entity, coll);
};

transpiles to
self.resolve_contact = function(____, a, b, coll)
  local a_entity = a:getUserData();
  local b_entity = b:getUserData();
  if self:check_contact(a_entity, b_entity) then
    return;
  end
  self:store_contact(a_entity, b_entity, coll);
end;

This behavior does not occur if the closure is not stored as a variable.
physics_world.setCallbacks((a: Fixture, b: Fixture, coll: Contact) => {
  const a_entity = a.getUserData();
  const b_entity = b.getUserData();

  if (this.check_contact(a_entity, b_entity)) { return; }

  this.store_contact(a_entity, b_entity, coll);
});

physics_world:setCallbacks(function(a, b, coll)
  local a_entity = a:getUserData();
  local b_entity = b:getUserData();
  if self:check_contact(a_entity, b_entity) then
    return;
  end
  self:store_contact(a_entity, b_entity, coll);
end);

The issue here is how resolve_contract is originally declared. It needs to be declared with this: void:
resolve_contact: (this: void a: Fixture, b: Fixture, coll: Contact) => void;

The reason properties which are function types are given a self parameter is because they can be obfuscated by interfaces.
Example:
class Foo {
    prop = "foo";
    fn: (s: string) => string = s => this.prop + s;
}
interface Bar {
    fn(s: string): string;
}
const bar: Bar = new Foo();
print(bar.fn("bar")); // Transpiler doesn't know fn is not a true method


c++ code on windows?

Hi, thank you for this great work. Will it be possible to run the c++ code on Windows? Ideally without Matlab!
Thanks

Hi,
Thanks for your interest in this work. The C++ code takes care of optical
flow calculations and refinement, which is from 'Shape Tracking with
Occlusions via Coarse-to-Fine Region-Based Sobolev Descent, PAMI 2015'.
This piece of the code is no longer updated. I have tried to configure the
code for Windows but had no luck.
On Thu, Jul 6, 2023 at 7:24 AM antithing @.***> wrote:

Hi, thank you for this great work. Will it be possible to run the c++ code
on Windows? Ideally without Matlab!
Thanks
—
Reply to this email directly, view it on GitHub
https://github.com/donglao/videoinpainting/issues/3, or unsubscribe
https://github.com/notifications/unsubscribe-auth/AJ45O23GHYGCOEJICF57KWDXO3DCPANCNFSM6AAAAAA2AQQXFA
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

Understood. Thank you for getting back to me.


Inheriting MeteorComponent from MeteorDirective

FEATURE REQUEST
From a structural point of view would it not make sense to have a MeteorDirective class that becomes the parent class for MeteorComponent. I feel that this would make logical sense since in Angular2 a Component is a Directive and all functionality that MeteorComponent currently has appears to be needed for a MeteorDirective class.
I am trying to create an Angular2 Structural Directive that requires autorun & as far as I know I cannot do this without the above or extending MeteorComponent to create my own MeteorDirective class but that would not be future-proof.
In fact I think it would be beneficial to actually remove the autorun method from MeteorComponent & implement it in a 'Meteor' class. This way anything that needs it could use it (services, directives, components, etc). You could inherit MeteorDirective & MeteorComponent from this class but then you run fowl of the problem of deep inheritance creating a fragile framework; so I would think keeping it as a separate class would serve angular2-meteor best.
I would think one then does something like this:
export class MyComponent extends MeteorComponent {
    test() {
        Meteor().autorun(() => {
            . . .
        });
    }
}

Since the Meteor functionality is global & doesn't actually need to be instantiated it doesn't even need to be a class and can just be a function that returns a Meteor object.
Everybody seems to be so focused on components that it's proving to be difficult getting going with the other powerful features of Angular2 - it seems to be mostly due to lack of documentation since it's still changing so quickly being an RC.

MeteorComponent will be renamed into MeteorReactive in the next release.
MeteorComponent actually doesn't do much, but those things are anyways important especially for UI components: to destroy Meteor handlers on ngOnDestroy and to update UI on the callbacks (i.e. run ngZone).
Other structural elements like services don't need this stuff in most cases, so users are expected to use regular Meteor API in them. That's why one global API is too much.

@barbatus Thanks & good to know; however I would disagree that services don't need this sort of stuff. In my opinion services is exactly where this logic should appear. The biggest flaw I see with the angular2-meteor tutorial is that it teaches users to put server data queries directly into components which is exactly what Angular discourages in favour of separation of concerns.
My argument would be that all calls to the server should instead be in services so that you can share them with any component by just referencing them instead of copy & pasting server subscription code between components. Imagine suddenly you need another 1, 2 or 3 components that show a parties list in a slightly different way, then you have to duplicate your entire autorun method in the new component instead of just importing the partiesList service & reusing it.
I think putting things like Meteor.subscribe() calls into components is just asking for trouble. Yes, it is easier but is not good design practice according to Angular2's design methodology - at least this is my understanding & I am open to correction.

@cubitworx +1 agree server data queries should be done within services to encourage code re-use.


Fixed unnecessary wildcards in manifest

Fixes #312 - A quick change to the module manifest

[X] Change details added to Unreleased section of readme.md?
[n/a] Added/updated documentation and descriptions in .schema.mof files where appropriate?
[n/a] Examples updated for both the single server and small farm templates in the examples folder?
[X] New/changed code adheres to [Style Guidelines]?(https://github.com/PowerShell/DscResources/blob/master/StyleGuidelines.md)?
[n/a] Unit and Integration tests created/updated where possible?

This change is

Reviewed 2 of 2 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable

Reviewed 2 of 2 files at r2.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable


@today in link not working

I have "Add dates as link" option turned off.
But when I do want to create a link, I manually enter:
[[@today]]

and the date is not expanded properly.
I don't want to have all my dates as links, hence the option disabled.  Sometimes though, I want to create the link manually, as above and doesn't seem to be working.

I have add dates as link turned on, and my @today/@tomorrow links have also stopped working

I just updated to the latest obsidian and plug-in via the update button in options and now it works fine

When you say "works fine" do you mean the problem you were having, or that:
[[@today]]
expands correctly?  I am completely updated and nldates inside a wiki-link (manually) still does not work for me.

I never do [[@today]] only @today, I tried [[@today]] and it didn't appear to work, but I can do @today again so please ignore me

I never do [[@today]] only @today, I tried [[@today]] and it didn't appear to work, but I can do @today again so please ignore me

No ignoring from me, thank you for your quick response.


pythonPackages.pytest: Revert "4.6.5 -> 5.1.0 in case of Python 3"

This reverts commit b3ddab852a5229331553e07be6055fb015966b42. The update broke
a number of other packages, like python-blessed and python-django-extentsions,
which are dependencies of GNU Mailman.
Ping @FRidh.

The better solution be to just disable the tests that aren't compatible.
This will likely break packages that are using pytest5 features.

Also, python doesn't handle mutliple versions well, since they have to coexist in the same environment. There should only ever be a single version of a package for an interpreter version.

The better solution be to just disable the tests that aren't compatible.

Well, after we've reverted the update, then we can disable the test suite that turn out to depend on pytest-5.x features.

This is a mass rebuild. The far majority of packages are already compatible or have been adjusted. Those that need fixing can be done now and backported to 19.09. Also, reverting will break other packages.

I've fixed the two mentioned packages on master and 19.09.

4dd38c42894c61358b9b0f56fe7838b045a157eb
aa6c38d9c162ecfc9c9f330ca65eb53de6d844c3

OK, thank you for the fix for django-extensions. I'll check how far I get now compiling Mailman.


Added ColorMode RGBA for GridMap

Description

Added new ColorMode RGBA for GridMap to allow user to set RGBA independently
Added a small example for GridMap

Step to Test

Run ext_light_viewer_gridmap

I noticed that the CI always fails for external PRs because it cannot access secret tokens that are necessary to login to docker. As a workaround, I just updated build.xml so that it neglects login failures.
Could you merge the latest master branch to your PR branch to re-run the CI?

@koide3
I've rebased and push it again

LGTM. Thanks for your PR!


Windows Firewall Log issues

Hello,
Based on my experience, configuring firewall loging using domain GPO according to this article - https://docs.microsoft.com/en-us/windows/security/threat-protection/windows-firewall/configure-the-windows-firewall-log - leads to one of these problems (all settings are at their defaults, logging is enabled for both dropped and allowed packets):

Windows Firewall folder AND the log get created, for some time the log gets populated with log records  then logging stops - for example it may have been logging till 20.11.2019 and after 20.11.2019 no additional log records can be seen in the log,

Windows Firewall folder AND the log get created but the log file contains only the field names  - no dropped or allowed packet is ever registered in the log,

Windows Firewall folder is created but the log file is not

Windows Firewall folder does not get created.

In fact I failed to have correctly working firewall logging in my Windows Server 2008R2 and Windows Server 2019 domains.
On the other hand I haven't yet had  any issues configuring firewall logging locally - without using domain-based GPOs.

@MichaelFirsov - Thank you for submitting feedback.
Can you please share what specific issue you have with this doc? Or are you having some technical issues which requires technical support?
If you have some issues with this doc, we would really appreciate if you are able to help by providing more details as to what should be edited and/or included. Thank you!

@MichaelFirsov - We appreciate any feedback that improves the content in the Microsoft docs but we haven't had any response from you so we are going to close this issue.
If there is a specific area of the docs that we can improve on, please feel free to open a new issue by clicking on the Feedback section on the specific Microsoft doc which is found at the bottom of the page. Thank you.

I must apologize for delaying the answer - please excuse me for this! "Or are you having some technical issues which requires technical support?" - I just wanted to point out that configuring firewall logging in strict accordance with this article may lead to not working logging in many cases and (providing I have tested several different domains) I can't say for sure whether the article lacks some information or this "feature" just not works as expected.

I noticed your comment in issue ticket #2015 -- is that ticket directly related to this one here? Are there any comments in that ticket which may be useful for your issue?
Maybe it would be more useful to reopen a ticket from the feedback section https://docs.microsoft.com/en-us/windows/security/threat-protection/windows-firewall/configure-the-windows-firewall-log#feedback to get the ticket linked directly back to the page in question, for easier referencing.

"is that ticket directly related to this one here?" - not sure... That issue arises when the logging had been working for some time but then has stopped. The new one (#5519) describes a situation when the logging never starts working at all.
Frankly speaking I don't know whether I should open tickets in the "documentation sections" here as I think that's really not the documentation issue(s) but rather the technical problems as mypil pointed out above. For me that's the only way to say something is not working in Windows because I can't open a support case on each issue I see.

OK, fair enough. You may want to use the TechNet forum pages instead to get a broader feedback from tehcnical users who might be able to help you with detailed suggestions for troubleshooting.

Yes, I understand - thank you!


jets: match hoon changes to bif:by

Companion PR to #6639 in Arvo

Tests failing due to jet mismatch with the Hoon, just like in the companion PR

I was overeager with the merge button -- this interface change needs to be handled with different, kelvin-mediated old and new declarations in tree.c. I'll open another PR.

@joemfb Right - let me know if you want me to do it instead, since I forgot that we need to support both the old and new jets for upgrade.


add undeclared  params of VisualScriptEditor::_selected_method

Fixes #23475 ,  the error info:

ERROR: ERROR: emit_signal: Error calling method from signal 'selected': 'VisualScriptEditor::_selected_method': Method expected 2 arguments, but called with 3.

Thanks!


Can you please help me setting up swayvnc in a docker environment.

I have installed swaywm on a docker alpine image and I want to access it remotely using swayvnc. I am new to sway and swayvnc. Can you help me set it up?  I am not even sure if its possible to use swayvnc in docker image.

The container this repository builds shows that it can be done, did you try to run it?
Check the README, podman is command line compatible to docker, just replace 'podman' with 'docker'
$ docker pull ghcr.io/bbusse/swayvnc:latest

Other than that, look at the Dockerfile for what is needed to achieve what you want:
https://github.com/bbusse/swayvnc/blob/main/Dockerfile

Use the Dockerfile linked above as a base and add the changes you want, then build and run

You can also look at swayvnc-firefox for an example how to use swayvnc as a base image:
https://github.com/bbusse/swayvnc-firefox/blob/main/Dockerfile
swayvnc-firefox additionally runs firefox

I get these erros as I am not a user in your docker image and I don't have root privileges to install anything on it
ERROR: Unable to lock database: Permission denied
ERROR: Failed to open apk database: Permission denied

So what I am doing right now is using your images as a base and installing sway on it. and then want to see if sway works with swayvnc. But I guess to install anything on your docker image I need to be a root user or  a USER with sudo privileges

sway is already installed: Check line 16 of the Dockerfile. There is a reason it's called 'swayvnc' (:

I used these commands to run your image. But I find some errors and sway doesn't launches.
0:00:00.001 [ERROR] [wlr] [render/wlr_renderer.c:322] drmGetDevices2 failed: No such file or directory
00:00:00.001 [ERROR] [wlr] [types/wlr_drm_lease_v1.c:705] No DRM backend supplied, failed to create wlr_drm_lease_v1_manager
00:00:00.010 [ERROR] [sway/config/output.c:808] execvp failed: No such file or directory
00:00:00.050 [ERROR] [wlr] [xwayland/server.c:443] Cannot find Xwayland binary "/usr/bin/Xwayland"
00:00:00.050 [ERROR] [sway/server.c:273] Failed to start Xwayland
ERROR: ../src/main.c: 1034: Failed to initialise DRM render node. No GPU acceleration will be available.
ERROR: ../src/main.c: 1034: Failed to initialise DRM render node. No GPU acceleration will be available.

The errors are okay and not fatal for the operation. You should be able to connect with some vnc client and get output

I used remmina. but I can't get access to VNC Port at <IP_ADDRESS>:5900

what vnc viewer do I need to use?

Please try with '-p${LISTEN_ADDRESS}:5910:5910' and then connect to 5910 instead of 5900

I just tried with Remmina and port 5910, works for me

Oka let me see

Bro, you are fantastic. I can use this image to install packages on it and can run sway in docker.  I was working on this for days. You saved me a lot of time at last.
These three errors don't go in my code too.
00:00:00.049 [wlr] [backend/wayland/backend.c:162] drmGetDeviceFromDevId failed: No such file or directory
00:00:00.049 [wlr] [render/wlr_renderer.c:322] drmGetDevices2 failed: No such file or directory
00:00:00.049 [wlr] [types/wlr_drm_lease_v1.c:705] No DRM backend supplied, failed to create wlr_drm_lease_v1_manager

Anyhow, thank you for the help.

Happy to help, I am glad it works!

I will try to add more packages to your docker file and build an image out of it now. And see if it works again with custom configuration. Thank you again you are awesome


fix: UI Improvement in Events Page

Fixes #1172
Changes: Changed the textcolor of Location according to app theme.
Screenshots for the change:
Before:-

After:-

IMO, It was better earlier. It is good if you find good issues or bugs instead of random UI changes.


merging arnav 3 into master

i have resolved the conflicts
@arnaav11 kindly review the changes and merge the pull request


[New game]: Dinosaur Memory Game

🎮 Game Request
This is Dinosaur Memory Game. The goal of the game is to match all of the pictures related to dinosaur in pairs. To do this, players must flip over two squares at a time.
Point down the features

It is very easy to play.
Sound effects when pictures match.
Interactive user interface.

Select program in which you are contributing
GSSoC23
Code of Conduct

[X] I follow CONTRIBUTING GUIDELINE of this project.

Hey @BidisaChowdhury !
Thank you for raising an issue 💗
You can self assign the issue by commenting /assign in comment 😀
Make sure you follow CODE OF CONDUCT and CONTRIBUTING GUIDELINES 🚀
Don’t Forget to ⭐ our GameZone🎮
Make sure you join our Discord🕹

Hey @BidisaChowdhury!
We are already having a similar game request in #1874 👀
Make sure you come up with a cool unique idea 😀
Waiting for your new game idea 💗.

Hey @BidisaChowdhury ! Thank you so much for your raising the issue💗
It’s all yours, you can come anytime again and make some contributions! 🚀
Alone, we can do little, but together we can do so much! 😇


Release version not updated in project name (after v0.6.2)

Check if project name has to be reset to signalo_demo.qgs to fit project title automatically to release version.
Should be 0.6.3

Add a test for version number when building release package

solved in 1.0.0


Version of Arduino too Old

Hi,
I am hoping you could give me a pointer in regards to this issue.

running the program tells me that arduino version is too old, I have tried updating the arduino, but did not change anything.

hi,
Sorry about the misleading message, it is referring to the arduino-esp32 core version, not the IDE version.
ESP32 Core version can updated from the boards manager in Arduino IDE.

Hi,
Thank you for your response, but my ESP32 Core version in the Arduino is up to date, I already have this one installed.

Is there anything i am still doing wrong?

1.0.6 doesn't sound like up to date, current version is 2.0.7, you should probably update the package_esp32_index.json board url in the arduino preferences.
https://docs.espressif.com/projects/arduino-esp32/en/latest/installing.html

I update the package and now and it seems like I am now going past thaterror, However, it seems like there are some files that not being found by when running the program.

looks like the old 1.0.6 is still there and interfering, did you remove 1.0.6 before installing 2.0.7 ?
a clean install of Arduino IDE may be required, I wish I could help you with that but I have no idea how to do it on Windows

Hi
Thank you, I had to uninstall the version 1.06.
Working now.
Thank you I really appreciate.


plant ovary axiom reference to Magnoliophyta

The PO import of http://purl.obolibrary.org/obo/NCBITaxon_3398, currently called Magnoliopsida in NCBITaxon, needs an update on the PO side. The PO label for it is currently Magnoliophyta (which is now listed as a synonym in NCBITaxon), and this is causing a duplicate label situation for FoodOn when it imports "plant ovary" term.
Thx!

Fixed in commit https://github.com/Planteome/plant-ontology/commit/602fcbf5e3d619a34d5e3df62c38cb719cd95a76
Thanks for bringing this to our attention


Is there a way to skip the first row (header)?

Versions

PHP version: 7.2.17
Laravel version: 5.8.15
Package version: 3.1

Description
Is there a way to skip the header row and start importing from the 2nd row?
Like:
class UsersImport implements ToModel
{
    /**
     * @param array $row
     *
     * @return User|null
     */
    public function model(array $row)
    {
        return new User([
           'name'     => $row[0],
           'email'    => $row[1],
           'password' => Hash::make($row[2]),
        ]);
    }
}

But starting from the second row? So I don't have to worry about my header names, just the order of my columns.

I resolved it with
/**
     * @return int
     */
    public function startRow(): int
    {
        return 2;
    }

I know you've solved this already but there's a built-in way to do this: WithHeadingRow

I know you've solved this already but there's a built-in way to do this: WithHeadingRow

But if you use WithHeadingRow you cannot access row items by index

nice！

I know is closed, but if you use @lcardosozago 's method, don't forget to add:
use Maatwebsite\Excel\Concerns\WithStartRow;


Add Spanish translation

This is a first attempt of translation to Spanish. I named it to es_AR b/c I'm from Argentina and I'm not really sure it's dialect neutral enough. I used the Portuguese translation as a basis for which words to translate. I let the commit word in English b/c the literal translation sounds really weird in Spanish (I think it's something like confirmación according the Pro-Git Spanish translation). The same goes for merge, rebase, squash, which are terms from the GIT domain and I don't think it's worth to translate.

@RomuloOliveira I think I fixed all the comments addressed and I just amended the commit b/c, you know, history 😉


Bug in python SDK. Not able to connect when the camera USB connected by extension cable

Before opening a new issue, we wanted to provide you with some useful suggestions (Click "Preview" above for a better view):

All users are welcome to report bugs, ask questions, suggest or request enhancements and generally feel free to open new issue, even if they haven't followed any of the suggestions above :)

Required Info

Camera Model
{  D455 }

Firmware Version
<IP_ADDRESS>

Operating System & Version
Windows10

Platform
PC

SDK Version
{ legacy / (<IP_ADDRESS>17) }

Language
{python/unity }

Segment
{Real time object distance analysis }

Issue Description
I am getting the below error when I connect the camera USB to the Extension Cable
I was trying the get the RGB and depth image using the D455. I will use the depth image for object distance measurement. I can see the RGB and depth image in Intel Realsense when I connect the camera USB to the Extension Cable. But when I try to get the RGB image/depth image from Python, it throws the below error.  Please help me in fixing the issue.
Exception has occurred: RuntimeError
Couldn't resolve requests
  File "D:\Depth_Camera\realtime_testing.py", line 48, in <module>
    pipeline_profiles[device] = pipeline.start(config)

Python code used for testing:
import pyrealsense2 as rs
import numpy as np
import cv2

connect_device = []

for d in rs.context().devices:
    if d.get_info(rs.camera_info.name).lower() != 'platform camera':
        serial = d.get_info(rs.camera_info.serial_number)
        product_line = d.get_info(rs.camera_info.product_line)
        device_info = (serial, product_line)  # (serial_number, product_line)
        connect_device.append(serial)

# Define the criteria for corner detection
#criteria = (cv2.TERM_CRITERIA_EPS + cv2.TERM_CRITERIA_MAX_ITER, 30, 0.001)
#align = rs.align(rs.stream.color)

pipelines = {}
pipeline_profiles = {}
for device in connect_device:
    config = rs.config()
    config.enable_stream(rs.stream.depth, 1280, 720, rs.format.z16, 30)
    config.enable_stream(rs.stream.color, 1280, 720, rs.format.rgb8, 30)
    # config.enable_stream(rs.stream.infrared, 1, 640, 480, rs.format.y8, 5)
    # config.enable_stream(rs.stream.infrared, 2, 640, 480, rs.format.y8, 5)
    # Align objects
    align_to = rs.stream.color
    align = rs.align(align_to)
    pipeline = rs.pipeline()
    config.enable_device(device)

    pipeline_profiles[device] = pipeline.start(config)
    depth_scale = pipeline_profiles[device].get_device().first_depth_sensor().get_depth_scale()
    pipelines[device] = pipeline

Intel RealSense Viewer Output:
I cropped person details from the RGB.

Hi @dsnsabari  Because you are using a USB 2 cable, the camera will operate in USB 2 mode even if the cable is plugged into a USB 3 port.  The supported resolution and FPS combinations that are supported on USB 2 are more limited.  For example, 640x480 at 5 FPS (or up to 30 FPS) is supported but the 1280x720 resolution will only support 5 FPS on a USB 2 connection on D455.  USB 3 is required for 30 FPS at that resolution.
If a requested configuration cannot currently be provided by the camera then the Couldn't resolve requests error is generated.

Hi @MartyG-RealSense, It is working now.

You are very welcome, @dsnsabari - thanks very much for the update!


[FEATURE REQUEST]: Supporting Audio Tasks

Feature Request
Are there any plans to include support for audio tasks such as audio classification, ASR, and TTS in AutoTrain soon? Are they excluded by design? If not, are they already being worked upon, and should we expect them to be there sometime soon?
Motivation
Audio is the only major category of tasks/pipelines unavailable on AutoTrain. Since much of our research focuses on audio, we would like to know if it would be worthwhile to include support for such tasks. We might be able to contribute if it's not already in the pipeline.
Additional Context
No response

if there is interest why not. which one is the most interesting to you?

ASR, to begin with :)


Put small code snippet in README

Dear Mr Big,
I would like to see some "quick start" examples of the autoargs package in the README.MD. The project is cool by the way!

Will do. But not today. Thanks anyway. Check out the examples folder of the development branch.

Done


what is the minimum VRAM requirement for Unicontrol?

what is the minimum VRAM requirement for Unicontrol? is it more efficient than controlnet?

The minimum VRAM is ~9GB. We had no compression optimization yet. BTW, we have released the HF space (https://huggingface.co/spaces/Robert001/UniControl-Demo).


[WFCORE-4636] The class and module attributes should require all serv…

…ices to be restarted.
https://issues.jboss.org/browse/WFCORE-4636

Core - Full Integration Build 9018 outcome was FAILURE using a merge of 28bf7cef2c7fdc739af385fef4d23298fca141b1
Summary: Execution timeout (new); tests passed: 5249, ignored: 128 Build time: 04:00:35


Biocontrol form edits (Sadly)

Biocontrol release form

[x] under both the actual and estimated bioagent tables/objects, delete the agent location and plant position fields or if that causes issues then please just make them optional.

Biocontrol release monitoring form

[x] remove the legacy presence field
[x] create a new field called beside the linked treatment ID field called "Legacy IAPP release ID" that allows users to type in a 5-6 digit IAPP site ID, OR if it's not too much work, choose from a site ID in the area like it does for the InvasivesBC linked ID.  Field should be optional.
[x] confirm there is no better way to deal with the checkboxes that you have to click on then off to be off, like a yes/no for the spread details and the target plant phenology.
[x] make the "Monitoring type" field mandatory.
[x] Make the "monitoring method" field mandatory
[x] under spread results object, make agent density and plant attack optional fields.

Release monitoring, release, and dispersal monitoring:

[x] Update the help text for the estimate tables/objects to be: "Number is derived by an actual sub-sample count and multiplied by the total number of plants/plant parts the agent resides upon or within, e.g 5 larvae within a gall X 10 galls = 50 larvae"

Biocontrol collection form:

[x] total bioagent quantity field is missing.  Add two new fields called "Total Bioagent Quantity (Estimated) and Total Bioagent Quantity (Actual)" under the actual and estimated agent objects that autofills from the sum of Bioagent Quantity from both the estimated and actual tables.  See biocontrol release form for example to copy.
[x] plant collected from field is missing it's drop down.  Please link it to the invasive_plant_code_withbiocontrol drop down.

All 4 biocontrol forms:

[x] update the help text for all the fields under the weather conditions object to make them work for all activity types.  right now the help text for each field refers to the collection activity.  Change the work collection to "activity" for all.
[x] the wind speed field on all 4 biocontrol forms has a default of zero.  Change this default to be blank.
[x] the help text for the "actual agents" object is cut off on the collection form and missing entirely on other forms. Fix help text for all actual objects on all 4 forms to say "The quantity of the biocontrol agents in the life stage present."
[x] bioagent stage field in all 4 forms for both actual and estimated agents is missing it's drop down.  Connect to "biological_agent_stage_code".
[x] edit "Biocontrol Presence" field help text to say: "Choose one or more from the drop down to indicate any visible sign of the agent(s) being present.  Indicate current or prior year plus the type of evidence seen."

@sam-warren  the first item "delete the agent location and plant position fields" from the actual and estimated table was only supposed to happen for the Biocontrol release form, but they have been deleted from the biocontrol release monitoring and biocontrol dispersal monitoring forms too incorrectly.  Can you please add those fields back into those objects on the release monitoring and dispersal monitoring forms?

@sam-warren When these 2 fields are added back into both monitoring forms can you please put in this order after the two existing fields (quantity and life stage), then Plant position followed by the Agent Location.


Error during WebSocket handshake: Unexpected response code: 400

I followed the example by creating a html file with the following code:

Upon launching this file, I received an Error during WebSocket handshake: Unexpected response code: 400.
From the Azure Channel dashboard, it also shows There was an error sending this message to your bot: HTTP status code GatewayTimeout.
How can I fix this?

Does your bot work in Azure 'Test in Web Chat' ?

HI @Kartik1607, it doesn't work for 'Test in Web Chat' as well. (with the same Websocket error on the Azure page). However, it works for the iFrame solution. Do you have any idea why it's failing?


speedup in startup and hit loading

for 20 events one stream
Real Time (as of 3dbc4c3) :      23.9 s->  13.1 s.
From igprof report https://slava77sk.web.cern.ch/slava77sk/reco/cgi-bin/igprof-navigator/sdl/ig.pp.3dbc4c3.rerun2 vs https://slava77sk.web.cern.ch/slava77sk/reco/cgi-bin/igprof-navigator/sdl/ig.pp.16776d3-addInputs2.m8clx (in perf counts, which I think are about the same as seconds)

addInputsToLineSegmentTrackingPreLoad: 2.31 -> 1.95
SDL::initModules: 3.46 -> 2.07
SDL::initHits: 10.27 -> 1.43

I pushed an update in 059d27c.
Now the number of constructed objects agrees.
The counts in the higher level objects seem to fluctuate even in the master.

validation looks ok: https://www.classe.cornell.edu/~mgr85/www/SegmentLinking_keep/PR154/eff_plots__GPU_explicit_cache_b0b8323_PU200/#1.5

I'm not sure, but I think this PR lead to some slowdown in the runtime. Did you see this as well or understand why this might be the case?

here is what I see on 200 events (new = 9e6ae0f; old = 529c823)
   Evt    Hits       MD       LS      T3       T5       pLS       pT5      pT3      TC       TCE      Event      Short             Rate
   old      2.2      3.7      3.5      3.2      3.4      5.0      6.3      5.9      6.8      5.7      45.7      38.5+/-  4.3      51.6   explicit_cache[s=1]
   new      2.4      4.2      3.2      3.2      3.3      5.0      6.2      5.7      9.2      5.8      48.3      40.9+/-  4.9      51.7   explicit_cache[s=1]

in my case the increase is in removeDupQuintupletsInGPUv2, on 20 events from 2.54ms to 4.86ms; about twice as slow

I think i see something similar. Other multiplicities have not changed so idk why this is running slower.


[3.x] Block components.

Quickly made a thing this morning! Standalone component blocks.
These blocks extend TwillBlockComponent and have no view of their own. The formBuilder is used for rendering.
There will also be a method "renderUsing" which takes care of the rendering. So everything in a single file!
These components are loaded using a namespace like this: TwillBlocks::registerComponentBlocks('\App\View\Components\Twill');
this means packages can ship their own fully self-contained blocks.
This also means, packages can become templates as the full markup can be shipped easily.

[x] docs
[x] Generate command

Hey @ifox,
I think this is ready to be the final feature we add in 3.x :).
Let me know what you think.

Bugs:
return new self($this->file, $this->type, $this->source, $this->name, $this->renderNamespace); -> Missing parameters


use fs.accessSync()

When using the latest build of Atom (0.1777) & atom-ternjs (0.4.9), I am getting:
atom-ternjs
fs.existsSync() is deprecated. Use fs.accessSync() instead.

Looks like this might be coming from Tern itself...

Hi @mattapperson,
i'm using BufferNodeProcess to spawn the tern server. BufferNodeProcess throws the deprecation. This will be fixed with atom 0.178 and up. should have no effect to the package, hopefully. :)
Thx for reporting!
tststs

fixed with release of 0.178


[FEATURE]: Create Form for Events

Detailed description
I would like to create form for events section
Possible implementation
No response
Additional information
I would like to work on it under gssoc23
Code of Conduct

[X] I agree to follow this project's Code of Conduct

@suzy-g38 assigned


Transactions

Hello!
How do transactions work?
In the docs I find db.Begin() and db.BeginTx() but there is no mention of db.Commit() or db.Rollback() (or equivalent functions)
I've also noticed the functions such as NewSelectQuery() do not support transactions.
Hence my question, are transactions not supported yet? or is the support there but it works in a non obvious way?
Thank you.

Commit and Rollback are on db.Tx - see https://golang.org/pkg/database/sql/#example_DB_BeginTx
Once you have a tx, you have 2 options:

tx.NewSelectQuery()
db.NewSelectQuery().Conn(tx)

Make sure you are on v0.1.14

Thank you. I'll try it and provide feedback if any (or comeback to close the issue)


Some more fixes for serializing revision trees

Scope & Purpose
Follow-up to #11752 to cover improper shutdowns

[x] Bug-Fix for devel-branch (i.e. no need for backports?)

Testing & Verification
Jenkins: https://jenkins.arangodb.biz/job/arangodb-matrix-pr/10248/ (blue)

http://<IP_ADDRESS>:8080/view/PR/job/arangodb-matrix-pr/10297/

Tests blue


System Administrator security role for Sales Professional

On this page it says System Administrator applies ony to Sales Enterprise and Premium.
As far as I know, it also applies to Sales Professional, because is a global role for admins on all powerapps https://docs.microsoft.com/en-us/power-platform/admin/database-security#environments-with-a-dataverse-database

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 50a95667-5570-1123-89fb-7515681ff5fc
Version Independent ID: 50a95667-5570-1123-89fb-7515681ff5fc
Content: Predefined security roles for Sales (Dynamics 365 Sales)
Content Source: ce/sales/security-roles-for-sales.md
Service: dynamics-365-sales
GitHub Login: @lavanyakr01
Microsoft Alias: lavanyakr

Thanks for your comment, @JMCA2. This issue has been assigned to the doc author for review.

Hi @JMCA2,
Thank you once again for bringing this issue to our attention. Sorry for the delay in addressing the issue. I had to verify if the system customizer role also is applicable to Sales Pro. I just received the confirmation today and updated the doc.
Hope this addresses your issue. :)

Hi @lavanyakr01 Just saw your commit. Yes. The issue can be closed. Thanks for everything. We wanted to make sure we are doing things correctly.

Thanks for the partnership, @JMCA2. Closing the issue.


Increase Update Performance

This PR builds on #122

Simplifies the marshal/unmarshal of the structs in the update code path (TableUpdates, TableUpdate)
Adds some missing fields in the Operation struct
Adds an Echo method on the client for calling the server
Ensures that our update method response contains either an error or a result to avoid upsetting some RPC clients.
Uses partial unmarshalling via json.RawMessage in the update arguments so we can avoid having to marshal/unmarshal to get the arguments in to the right type
Re-writes the benchmarks to use []byte

Comparison of benchmarks:
name       old time/op  new time/op  delta
Update1-8  43.0µs ± 1%  14.6µs ± 1%  -65.96%  (p=0.000 n=3+3)
Update2-8  59.2µs ± 3%  21.6µs ± 2%  -63.59%  (p=0.000 n=3+3)
Update3-8  77.3µs ± 1%  28.6µs ± 1%  -63.02%  (p=0.000 n=3+3)
Update5-8   108µs ± 2%    43µs ± 2%  -60.71%  (p=0.000 n=3+3)
Update8-8   157µs ± 2%    64µs ± 1%  -59.29%  (p=0.000 n=3+3)

In terms of real world performance, with stress we're ~6 seconds better on 3000 inserts
Before
$ go run ./cmd/stress -verbose -ninserts 3000 -ovsdb tcp:localhost:49154
rootUUID is 2333c4e6-5de6-4c8f-a7ba-3f62557d3957

Summary:
        Insertions: 3000
        Deletions: 0
go run ./cmd/stress -verbose -ninserts 3000 -ovsdb tcp:localhost:49154  87.58s user 2.94s system 67% cpu 2:14.57 total

After
$ time go run ./cmd/stress -verbose -ninserts 3000 -ovsdb tcp:localhost:49153
rootUUID is 28ddc871-f67a-405c-ac47-7beb6b94526a
Summary:
        Insertions: 3000
        Deletions: 0
go run ./cmd/stress -verbose -ninserts 3000 -ovsdb tcp:localhost:49153  78.19s user 2.54s system 63% cpu 2:08.10 total

Fixes: #109

Pull Request Test Coverage Report for Build 864803620

78 of 127 (61.42%)  changed or added relevant lines in 8 files are covered.
2 unchanged lines in 1 file lost coverage.
Overall coverage decreased (-1.08%) to 71.367%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

ovsdb/row.go
0
3
0.0%

ovsdb/rpc.go
0
3
0.0%

ovsdb/updates.go
45
53
84.91%

client/client.go
11
22
50.0%

ovsdb/mutation.go
11
35
31.43%

Files with Coverage Reduction
New Missed Lines
%

client/client.go
2
69.51%

Totals

Change from base Build 859723497:
-1.08%

Covered Lines:
1812

Relevant Lines:
2539

💛  - Coveralls

@amorenoz rebased and retested.
without stress on 3000 operations completes in 1m49s, with the changes it's 1m43s which is consistent with the ~6sec improvement I was seeing before.

LGTM


Update Node version in Broker Dockerfile

Pull Request Test Coverage Report for Build 4955

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.007%) to 89.136%

Totals

Change from base Build 4949:
-0.007%

Covered Lines:
9408

Relevant Lines:
10183

💛  - Coveralls

Pull Request Test Coverage Report for Build 4955

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.007%) to 89.136%

Totals

Change from base Build 4949:
-0.007%

Covered Lines:
9408

Relevant Lines:
10183

💛  - Coveralls

Validation on k8s cluster: n is succeeded.

Validation on k8s cluster: n is succeeded.

Validation on k8s cluster: n-2 is succeeded.

Validation on k8s cluster: n-2 is succeeded.

Validation on k8s cluster: n-1 is succeeded.

Validation on k8s cluster: n-1 is succeeded.

Validation on k8s cluster: n is succeeded.

Validation on k8s cluster: n is succeeded.


Website isn't updating

E.g. See the rendered NEWS versus the underlying GitHub file.
Similarly for some changes to the intro vignette that I pushed a little earlier.
I saw that altdoc recently pushed a new 0.4.0 release with some logic updates. Do we need to update our CI workflow?
cc @etiennebacher @vincentarelbundock

FYI I can't look at this before middle of next week

Seems to be fixed by #185.


Make the default LeaseStrategy configurable and default to retainOnIOException for more resilient applications

I just learnt about #646 today. If I understand correctly, by default, if there is an network error during renewal, spring-vault will not re-attempt to renew whatever failed to renew.
There is no property to change the default LeaseStrategy in use that I could find.
https://github.com/spring-projects/spring-vault/blob/cdb687e4bab0aaa43b089f6fb158b1d46d6f369f/spring-vault-core/src/main/java/org/springframework/vault/core/lease/SecretLeaseContainer.java#L158
Can the default be changed to be more sensible (retry on IO error is pretty standard to have resilient software) and can we introduce a flag to chose between the 3 different behaviour without requiring code change?

Have you seen SecretLeaseContainer.setLeaseStrategy(…)?
Generally, retrying at the lease container level isn't in particular a great idea as retries belong into an infrastructure abstraction such as the HTTP Client or Spring's ClientHttpRequest.
Also, Apache's HTTP Client has a facility to retry on I/O exceptions or status codes which gives much more control over retries than trying to rebuild something in Spring Vault that actually belongs somewhere else.

Have you seen SecretLeaseContainer.setLeaseStrategy(…)?

I have but we rely on autoconfig from spring boot, we don't actually have any code calling into vault (https://docs.spring.io/spring-cloud-vault/docs/current/reference/html/#vault-lease-renewal), so unless it's exposed as a property, we can't really use it.
I realise now that this might have been better filed against https://github.com/spring-cloud/spring-cloud-vault/ which contains spring-cloud-starter-vault-config.

Alright, thank you. Indeed, Spring Cloud Vault is the place to introduce properties to pick up configuration details from config flags.


Add deprecated for LFS_CONTENT_PATH on zh-cn docs

Fix https://github.com/go-gitea/gitea/pull/18358#issuecomment-1019294711

Codecov Report

Merging #18362 (86db3cf) into main (a82fd98) will increase coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main   #18362      +/-   ##
==========================================
+ Coverage   46.06%   46.08%   +0.02%
==========================================
  Files         838      838
  Lines       92725    92725
==========================================
+ Hits        42713    42732      +19
+ Misses      43230    43207      -23
- Partials     6782     6786       +4

Impacted Files
Coverage Δ

modules/json/json.go
46.66% <ø> (ø)

modules/process/manager.go
81.39% <0.00%> (-1.56%)
:arrow_down:

routers/api/v1/repo/pull.go
28.35% <0.00%> (-0.51%)
:arrow_down:

services/pull/pull.go
42.39% <0.00%> (-0.41%)
:arrow_down:

models/issue_comment.go
54.86% <0.00%> (-0.29%)
:arrow_down:

models/repo_list.go
77.21% <0.00%> (+0.59%)
:arrow_up:

modules/queue/queue_disk_channel.go
63.86% <0.00%> (+1.48%)
:arrow_up:

modules/queue/workerpool.go
59.87% <0.00%> (+1.88%)
:arrow_up:

modules/queue/queue_channel.go
84.78% <0.00%> (+2.17%)
:arrow_up:

models/asymkey/gpg_key_common.go
64.51% <0.00%> (+4.83%)
:arrow_up:

... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e040eca...86db3cf. Read the comment docs.


Add "SSD Premium"

Please add the type "SSD Premium" as a disk_type when adding a volume
https://github.com/ionos-cloud/module-ansible/blob/master/plugins/modules/volume.py
disk_type:
description:
- The disk type of the volume.
required: false
default: HDD
choices: [ "HDD", "SSD" ]
https://devops.ionos.com/api/cloud/v5/#volumes

Actually using SSD creates a SSD Premium Volume. Setting the SSD Standard would be much the case here
---
- hosts: localhost
  connection: local
  gather_facts: false

  vars:
      ssh_public_key: "{{ lookup('file', '~/.ssh/id_rsa.pub') }}"

  tasks:
    - name: Provision a server
      server:
          datacenter: 	my-test-dc
          location:     de/fra
          availability_zone: ZONE_1
          name: test-name
          count: 1
          cores: 2
          cpu_family: INTEL_SKYLAKE
          ram: 4096
          image: ubuntu:20.04
          disk_type: SSD
          ssh_keys:
            - "{{ ssh_public_key }}"


Add DataGateway and PaNOSC Modes

Description:
As DataGateway API and our implementation of the PaNOSC Search API will be developed in this repo, there needs to be a way of dealing with this. For the first release, I think it'll be best to add a configuration option for datagateway and panosc modes.
The datagateway mode will expose the current endpoints and the panosc mode will (upon implementing) expose the 11 endpoints for the search API. This config option will have to be made mandatory and can be done in config.py.
To do this, I need to add a config option (mode?) and use that option in main.py to branch off to the existing calls to api_start_utils.py and the new panosc function calls to setup the Flask app for that mode. To avoid api_start_utils.py from getting too long and confused, I might create a search_api_start_utils.py to have the endpoint definition and general app infrastructure setup there. At which point, it would probably make sense to rename the existing file to datagateway_api_start_utils.py.
In the future, we should look at supporting both at the same time (i.e. where a single instance can be run for both DataGateway API and PaNOSC Search API) by adding prefixes (perhaps something like /datagateway/ENDPOINT and /panosc/ENDPOINT) but that should come later.
Acceptance criteria:

[ ] Add a way to switch between DataGateway and PaNOSC modes, which should be configurable
[ ] Add mode config option to config.json.example
[ ] Add test in to cover the changing of modes

[{"datagateway-api": "datagateway"}, {"panosc-api": "panosc"}]
[{datagateway-api": ""}]
no prefix (blank string) is all good as long as length of array is 1
Check that no prefix strings match across the list
{"datagateway": "datagateway-api", "panosc": "panosc-api"}
Could flip them round to avoid collisions and have multiple instances of the same API? Could require further reworking of config if you wanted to point two DG API at two different ICAT instances.


Portal-Firewall rules diff from documentation

The Firewall Rules for Portal seem a little bit messed up according to this Documentation:
https://enterprise.arcgis.com/en/portal/latest/administer/linux/ports-used-by-portal-for-arcgis.htm
compared with
https://github.com/Esri/arcgis-powershell-dsc/blob/2fcd4f56ad07870cc7e788308a2a94f40b1890d3/Modules/ArcGIS/Configuration/ArcGISConfigure.ps1#L751-L828
From my perspective following Things should be reviewed:

Open 7080 in first else branch as well.
Don't open 6443 on any part as it is ArcGIS Server Port and is only necessary if ArcGIS Server is installed on that machine.
Port 5703 is missing for HA-Portal (IsMultimachinePortal)
According to Docu Ports 7120, 7220 and 7654 are only local ports (so Outbound should be sufficent)

Could you please advise on these findings?

Opened 7080 in first else branch as well.
Opening 6443 ArcGIS Server Port if ArcGIS Server is installed on that machine.
Added Port 5703 for HA-Portal (IsMultimachinePortal)
Port 7654 Requires Inbound and Outbound Rules as PGSQL needs for a Master-Slave Relationship
Still Evaluating permission required on ports 7120, 7220.

@shailesh91 Did you come around this:

Still Evaluating permission required on ports 7120, 7220.

@spitzerr For now, we are opening both inbound and outbound ports for 7120 and 7220 in case of HA Portal.


Problem pattern matching after a ‘ / ‘

Describe the bug
Using your online demo to test it out, i tried matching the following exact string, but it wouldn’t allow me to do any matching after reaching the slash ‘/’ ?
Date     Time AUG 01/23  8:03p

Date%s+Time%s+(%a+)%s+(%d+)([/])(%d+)%s+(%d+):(%d+)([apAP])

It has been fixed & tested, thank you for reporting!


Unmanaged warnings from master

Just checking out and building the project gives me:
scala-abide/rules/core/src/main/scala/com/typesafe/abide/core/PackageObjectClasses.scala:21: Unmanaged type: PackageObjectClasses.this.context.universe.ClassDef

[warn] You can file this warning as a bug report at https://github.com/scala/scala-abide
[warn]     case cd @ ClassDef(_, _, _, _) if isPackageObjectMember(cd.symbol) =>

similarly, original reported as #22, consolidating here:
Building from master I get:
scala-abide/rules/core/src/main/scala/com/typesafe/abide/core/PackageObjectClasses.scala:24: Unmanaged type: PackageObjectClasses.this.context.universe.ModuleDef
[warn] You can file this warning as a bug report at https://github.com/scala/scala-abide
[warn]     case md @ ModuleDef(_, _, _) if isPackageObjectMember(md.symbol) =>

There are a number of other such warnings, these aren't the only two.

Abide is superseded by https://github.com/scalacenter/scalafix; closing all issues


fix "description" for push-image.yml

fixed a critical (in a sense :wink:) description mistake.

oh gosh, that's embarrassing. thank you ! @hoisjp

@iynere thank you too for a quick merge!


Missing DNS Entries

nslookup introducer.sparecoin.org <IP_ADDRESS>
Server:  dns.google
Address:  <IP_ADDRESS>
*** dns.google can't find introducer.sparecoin.org: Non-existent domain
nslookup dns-introducer.sparecoin.org <IP_ADDRESS>
Server:  dns.google
Address:  <IP_ADDRESS>
*** dns.google can't find dns-introducer.sparecoin.org: Non-existent domain
2021-06-20T15:42:50.849 full_node full_node_server        : DEBUG    Connecting: wss://introducer.sparecoin.org:9444/ws, Peer info: {'host': 'introducer.sparecoin.org', 'port': 9444}
2021-06-20T15:42:50.868 full_node full_node_server        : INFO     Cannot connect to host introducer.sparecoin.org:9444 ssl:<ssl.SSLContext object at 0x7f0fa8230640> [Name or service not known]
2021-06-20T15:42:58.262 full_node spare.full_node.full_node: ERROR    Exception while querying DNS server: The DNS query name does not exist: dns-introducer.sparecoin.org.

we just pushed fix for it, please pull latest

I pulled the latest and dns-introducer-spare.sparecoin.org is fixed however this remains an issue:
introducer_peer:
host: introducer.sparecoin.org
port: 9444

we just pushed fix for it, please pull latest

did this go to the WIndows build too?


It does not work in Firefox when using a dynamically created iframe with a text

The iframe content is hidden after a short period of time
Unit test

Just hit this bug. Don't know how to overcome this because postscribe is used by a library that will inject my code. Is there any way to circumvent or hack this behaviour?


Add check in the influx setup command for a password that has at least 8 characters

I can take this one if no one minds;)

Hey @Zyqsempai, go for it!  Here is a starting place for it:
https://github.com/influxdata/influxdb/blob/master/cmd/influx/setup.go#L192


Slight changes to player movement

Made a few jank changes to player movement to hopefully make it feel more responsive to control.

Thanks. It's good to see you again.

Likewise! Do you still use Discord?


AdjacentDistinct and AdjacentDistinctBy

These operators would be for Distinct and DistinctBy what GroupAdjacent is to GroupBy.
The idea is that by only grouping adjacents, there is no need to store seen objects, and thus memory is saved.
I have a local implementation here, and I could clean them up for submission, if these operators make sense to you. I'm unsure about the naming though: Locally I have them named DistinctUntilChanged. However, this loses the relation to GroupAdjacent. I would prefer to have names that are easily correlated and discoverable. But AdjacentDistinct does not make much sense to me, and neither does DistinctAdjacent. Suggestions?

I see now that I probably stole the name DistinctUntilChanged from the Reactive Extensions

@fsateler In addition to stealing the name, why not just use the implementation in Ix too? 😉

@atifaziz oh, I somehow missed that IX had this as well. However, there is still the By variant missing.
Should this issue be closed then (and possibly file a new one against IX), or is this something worth having in MoreLINQ?

and possibly file a new one against IX

I think given that IX is open source too, this would be the most natural cause as well.

or is this something worth having in MoreLINQ?

Could be but then we'd have to come up with a distinct name (which feels silly) to avoid conflicts in projects using IX and MoreLINQ. Each time an issue of naming conflict comes up, I'm convinced that a “no-conflict” approach via namespaces is more and more the right approach (which I've tried in another project and has proved to work well).

However, there is still the By variant missing.

Are you sure? Looking again, I think it's there.

@atifaziz thanks for looking that up. Sorry for not seeing it before, I blame using the same name for both variants.
I guess we can close this now.


Parser 2.0 not returning data from some pragmas

Describe the issue
Tried implementing parser 2.0 and it was not returning some values from an arc file. I spent a few minutes trying to figure out how it works but I wasn't making much progress.
Steps to reproduce
Steps to reproduce the behavior:

Parse the following Arc file:

@app
mockapp

@events
ping

@queues
pong

@http
get /

@tables
accounts
  accountID *String

@indexes
accounts
  email *String

With parser 1.x you'll get the following data back (represented here as JSON):
{
  "app": ["mockapp"],
  "events": ["ping"],
  "queues": ["pong"],
  "http": [
    ["get", "/"]
  ],
  "tables": [
    {
      "accounts": {
        "accountID": "*String"
      }
    }
  ],
  "indexes": [
    {
      "accounts": {
        "email": "*String"
      }
    }
  ]
}

With parser 2.0 you'll get this:
{
  "app": ["mockapp"],
  "events": ["ping"],
  "queues": ["pong"],
  "http": [
    ["get", "/"]
  ],
  "tables": [
    {
      "accounts": {
        "accountID": "*String"
      }
    }
  ]
}

Notice how @indexes is missing. For now I'll pull parser 2.0 out of use in the upcoming release of Arc, as it's breaking Sandbox.

yikessssss! thx for catching that


Two missing features

I Really love this package and though it contains alot I need im still missing two important features

If I have multiple dist files and I already installed them. Composer asks me if I want to override my current config file and back it up as an old one. The only problem here is that the message does not tell me about which file it's talking about. I know its chronological in my composer.json but this would be a simple fix and clears it somewhat up.

Sometimes I want to reuse some variables I define in my dist file. Is there a possiblity to add this?

What are your ideas for these two features have you already thought about it or are you already working on it? SOO much questions ;p
Thanks
Dennis

Thanks for the suggestions, they're very reasonable. And we're glad you like the package!

Like you said this should be a relatively easy fix and would indeed make things clearer.
I agree this would be great, but I think it escapes a bit the scope of the "Generic" processor we have in place, which is really just meant for simple replacements. So this feature might find a better home as part of a new processor, for example a Twig processor would have variable support built-in as part of the Twig language (see docs on the set tag).

There's currently no development going on for these features. Would you like to get involved with that?

I Created a new processor which supports Twig like you suggested. The working example is still on my local machine but this is the gist:
https://gist.github.com/dstollie/6ebd46721d31ed009314
Can you take a look at it and give some feedback? If ur okay with it I will create a pr somewhere these days

This is awesome, having a Twig processor will take this library to a whole new level! :+1:
Left some feedback on the gist. Looking forward to your PR!


RangePlugin with allowInput and TAB bug

https://jsfiddle.net/8v63fec7/4/
Your Environment

flatpickr version used: 4.6.9
Browser name and version: Google Chrome Version 98.0.4758.82
OS and version: Windows 10 Pro Version 20H2

rangePlugin with allowInput acts weird, if one navigates with TAB. After leaving the second input with TAB, the value from the first input vanishes.

Type in first date
TAB to next input
Type in second date
TAB to next input -> first inputs value vanishes

I'm facing this problem as well, the issue is also reproducible if the dates are already selected and you click one of the picker inputs and then click on the document again.
it seems that the self_input.value used to set the date on documentClick function is not correct when rangePlugin is used because the input value is split into two separated inputs.
// index.ts
if (self.config.allowInput) {
  self.setDate(
    self._input.value,
    ...

self_input.value without rangePlugin active called from documentClick function
2022-03-01 to 2022-03-24
self_input.value with rangePlugin active called from documentClick function
2022-03-01


Image response problem

Hi All,
For some reason I can't get the image directly from the browser. This is the code that I'm using.
Route::get('/', function()
{
$img = Image::make('tmp/test.jpg');
return Response::make($img, 200, ['Content-Type' => 'image/jpeg']);
});

I can manipulate the object img without any problem (resize, save, etc)... the problem is just the response. Any ideas?

Cheers

I'm testing exactly the same example that is posted in the manual and it
doesn´t work.
Route::get('/', function() {
$img = Image::canvas(800, 600, '#ff0000'); //
$response = Response::make($img->encode('png')); // set content-type
$response->header('Content-Type','image/png'); // output
return $response });
2014-05-29 22:52 GMT+02:00 Oliver Vogel<EMAIL_ADDRESS>
Closed #146 #146.
—
Reply to this email directly or view it on GitHub
#146 (comment).
i exactly  have this problem


Execute NamedOperations in the same way as other Operations

Currently, NamedOperations allow the execution of a pre-configured Operation or OperationChain. NamedOperations are called in a different way to natively supported Operations:

An Operation is executed by supplying an instance of the specific Operation class that the user wishes to execute.
A NamedOperation is executed by supplying an instance of NamedOperation containing the name of the operation the user wishes to execute.

This means that the user needs to know whether the operation they wish to run is a NamedOperation or a natively supported Operation. It would be better if both types of operation were executed in the same way so that the user does not need to distinguish between the 2.

Ran in a rather large brick wall with this. Have tried using custom serialisers and deserialisers with annotations, tired adding those also in with StoreProperties and have also tried modifying koryphe. Haven't got a clue where to go next with this one, so happy for someone else to have a go.

Would this be a non-backwardly compatible change, i.e. for Gaffer 2.0?

It probably wouldn't be backwards compatible however it isn't a high priority issue. More of a nice to have.

"It probably wouldn't be backwards compatible" - errh, you mean it is v2.0? The rest of your reply implies you mean it would be backwardly compatible

Strong argument for the "Generic Operation" maestro changes.


github-pages-deploy-action is overwriting Documenter builds

in latest version (v3.6) this github action make CLEAN: true becomes the default behaviour, which as a result will make PkgPage overwites all the previous build of Documenter.
should change it in the docs of this package to add CLEAN: false explicitly?

thanks for this! yes that would be good can you PR?


How-to: use password rotation and IRSA authentication in Mx4PC (no release date)

This document is not linked with any upcoming release and can be published at any convenient moment.
These features require the app to use Mendix 9.22 (or higher), which was released last week:

A customer using Mx4PC version 2.10.0 can now rotate database credentials in AWS Secrets Manager (or Hashicorp Vault) without having to restart the environment
A customer using Mx4PC version 2.10.1 can switch from static passwords to IAM-based authentication

@katarzyna-koltun-mx
Can you pick this up? Let me know if you don't have time.

@MarkvanMents on it!


Misspelling

In the question. "A community should suffer the gains and loss toghether." The word together is misspelled.

@brian6932 seems to have suggested PRs for typos. Maybe merge them?

:)

Thank you @brian6932.

This issue needs to be closed now.

I thought I had closed it.

Why close, the PR is still open, live still has the issue @rudyon ?

You can re-open, I set it to auto-close once the PR is merged @rudyon

Oh I thought it was merged. Sorry.


Fix mismatch indentation

Project contains a mixture of tabs and spaces across most gdscript files, resulting in compiler errors. This PR would resolve to consistent tab usage.

@studiomav
Thanks for this.
I had configured my local project to use spaces because that's what I prefer. Then noticed later that you have to import the library carefully or else you get the compilation errors you described.
Because tabs are the default configuration for godot I think this is a great change. I imported your branch and compiled without error.