Full stack trace for assertEquals

For assert I get full stack trace like
==> X xxx.XxxSpec.xxx  0.003s munit.FailException: assertion failed
    at munit.FunSuite.assert(FunSuite.scala:11)
    at xxx.XxxSpec.$init$$$anonfun$2$$anonfun$1(XxxSpec.scala:72)
    at scala.collection.IterableOnceOps.foreach(IterableOnce.scala:619)
    at scala.collection.IterableOnceOps.foreach$(IterableOnce.scala:617)
    at scala.collection.parallel.immutable.ParHashMap$ParHashMapIterator.foreach(ParHashMap.scala:78)
    at scala.collection.parallel.ParIterableLike$Foreach.leaf(ParIterableLike.scala:938)
    at scala.collection.parallel.Task.tryLeaf$$anonfun$1(Tasks.scala:52)
    at scala.util.control.Breaks$$anon$1.catchBreak(Breaks.scala:97)
    at scala.collection.parallel.Task.tryLeaf(Tasks.scala:56)
    at scala.collection.parallel.Task.tryLeaf$(Tasks.scala:21)
    at scala.collection.parallel.ParIterableLike$Foreach.tryLeaf(ParIterableLike.scala:935)
    at scala.collection.parallel.AdaptiveWorkStealingTasks$AWSTWrappedTask.internal(Tasks.scala:159)
    at scala.collection.parallel.AdaptiveWorkStealingTasks$AWSTWrappedTask.internal$(Tasks.scala:142)
    at scala.collection.parallel.AdaptiveWorkStealingForkJoinTasks$AWSFJTWrappedTask.internal(Tasks.scala:304)
    at scala.collection.parallel.AdaptiveWorkStealingTasks$AWSTWrappedTask.compute(Tasks.scala:149)
    at scala.collection.parallel.AdaptiveWorkStealingTasks$AWSTWrappedTask.compute$(Tasks.scala:142)
    at scala.collection.parallel.AdaptiveWorkStealingForkJoinTasks$AWSFJTWrappedTask.compute(Tasks.scala:304)
    at java.util.concurrent.RecursiveAction.exec(RecursiveAction.java:194)
    at java.util.concurrent.ForkJoinTask.doExec(ForkJoinTask.java:507)
    at java.util.concurrent.ForkJoinPool$WorkQueue.topLevelExec(ForkJoinPool.java:1491)
    at java.util.concurrent.ForkJoinPool.scan(ForkJoinPool.java:2073)
    at java.util.concurrent.ForkJoinPool.runWorker(ForkJoinPool.java:2035)
    at java.util.concurrent.ForkJoinWorkerThread.run(ForkJoinWorkerThread.java:187)

but for assertEquals I need to debug all asserts in all helpers because stack trace is a single line:
    at munit.Assertions.failComparison(Assertions.scala:278)

Which munit version are you using?
Could you verify if this is still the case with 1.0.0-RC1, please.

Which munit version are you using?
Could you verify if this is still the case with 1.0.0-RC1, please.

I'm using 1.0.0-RC1.

As a workaround you can use -F option for running. In sbt added after -- for example:
sbt project/testOnly MySuite -- -F
Otherwise, looks like a but. But I don't think it's blocking 1.0.0.

As a workaround you can use -F option for running. In sbt added after -- for example: sbt project/testOnly MySuite -- -F
Otherwise, looks like a but. But I don't think it's blocking 1.0.0.

I'm using bazel and want to understand what I need to do inside test runner please.

As a workaround you can use -F option for running. In sbt added after -- for example: sbt project/testOnly MySuite -- -F
Otherwise, looks like a but. But I don't think it's blocking 1.0.0.

With -F the same result on 1.0.0 release.


[Arma3] Missing directory causing segfault w/ fix

Arma 3 dumps core with recent updates:
/home/arma3server/functions/fn_debug: line 63: 20150 Segmentation fault (core dumped) ${executable} ${parms}
See the steam discussion for all the details, and the fix:
mkdir -p "/home/arma3server/.local/share/Arma\ 3"

Hey lnxprof,
I cant confirm this fix really worked for me.
Thanks for sharing.
sapphire

"cant" or "can" confirm?

Sorry, my bad - correct is "can"

Děkuji

Is this somthing I need to write in to LGSM or do you think this will be fixed?

I just helped someone with this issue, on a fresh install.
I suggest adding the mkdir -p "/home/arma3server/.local/share/Arma\ 3" to fn_arma3config().
I'm not sure if BI will fix it; as they have tickets related to it, but no solutions/fixes added.

Added fix
https://github.com/dgibbs64/linuxgsm/commit/46a812604ff18063ee1472906930ff85fb31ebc5


gnome-shell-extension not available on Fedora

Listed below are the prerequisite steps on Fedora in the README:
Fedora
To install on Fedora, open a terminal and run the following command:
sudo dnf install dconf-editor gnome-tweaks gnome-shell-extension
the first two install fine but gnome-shell-extension is not available in the repos, nor is gnome-shell-extensions. I'm running Fedora 46 using DNF4 which both return:
No match for argument: gnome-shell-extension
Error: Unable to find a match: gnome-shell-extension

can you able to install extensions with https://extensions.gnome.org/

can you able to install extensions with https://extensions.gnome.org/

no, it says incompatible version

can you able to install extensions with https://extensions.gnome.org/

yes

can give output of this command
dnf list | grep -extension-

gnome-shell-extensions is not a thing anymore in Fedora 41 at least.
The gnome-extensions CLI is installed automatically by the gnome-shell package, so if that's all Gnomintosh needs, then there is no need to install anything else.
The Extensions GUI app is not installed by default anymore but can be installed with dnf install gnome-extensions-app.
This is vanilla Fedora Workstation 41 with GNOME 47.1 after installing the GUI app:
$ rpm -qa | grep extension | sort
gnome-extensions-app-47.0-1.fc41.x86_64
gnome-shell-extension-apps-menu-47.1-1.fc41.noarch
gnome-shell-extension-background-logo-47.0-1.fc41.noarch
gnome-shell-extension-common-47.1-1.fc41.noarch
gnome-shell-extension-launch-new-instance-47.1-1.fc41.noarch
gnome-shell-extension-places-menu-47.1-1.fc41.noarch
gnome-shell-extension-window-list-47.1-1.fc41.noarch


Existing Site fields cleanup / usability

What happened (or feature request):
Existing Site fields cleanup: do we need both of these?

address this in potential re-design...both fields are needed


Displaying break points differently

Identifying via time difference, use another symbol, to make it clear what happens, maybe toggle them separately

It should also be nice, to add information about the breaks if there are toilets available or not.

@LeTaPe Now the Node points, where routes come together are not displayed anymore, but I think it is ok, therefore only the break points are displayed.
Do you think this is ok?

I agree. Maybe I missed something, but in this case, we can reopen the issues.


Update 3.6.0rc2 to 3.6.0

Makes the 12/7 release of 3.6.0 available on Docker Hub

That is strange; the artifacts aren't on www.python.org/ftp/python/3.6.0/ yet: https://travis-ci.org/docker-library/python/jobs/182346726#L406-L411.

@yosifkit - yeah I noticed that - on closer inspection, it's code frozen and all other things being equal, that rc1 release will be converted to 3.6.0 next Friday. Looks like I jumped the gun here - will re-run the tests when the FTP is updated 👍

It looks like the final package release has been already uploaded. Anyone here that can retry this? Thanks!

@tianon @yosifkit - rebased and passing CI - ought to be good to go, PTAL

:metal:


Detailed documentation of preparing a working Nitats environment

Installation steps for a detailed tutorial-
Use a virtual environment. (account for both Pip and conda)
Maybe make a requirements file.
Windows users should install git for windows (access to git bash) -- then access to Anaconda difficult? Will have to use AnacondaPrompt, or maybe Add Conda to Path?

#Standard user.
# Installing Miniconda.
# Download file
bash miniconda.sh
close, open terminal.

# Creating a new conda environment.
conda create -n nistts-py37

# Activate environment
source activate nistats-py
conda install nilearn pandas patsy ipython
pip install nistats # master from github

# download & installation: 1hr

Ran into botocore error. creating PR to rectify that.

It took about an hour to install everything, and I would bet hypothetical money that half the people will not do the installations in advance. Suggestions?


Canonicalisation of Reactions from ReactionEquation

Related to https://github.com/rxn4chemistry/rxn-chemutils/issues/8
proposal to add canonicalisation and removal of atom mapping as arguments to the to_string method of ReactionEquation
reaction.to_string(canonicalise=True, remove_atom_mapping=True)

My personal choice would be not to do that. A few points of explanation:

I see the conversion to string, the canonicalization, and the removal of atom mapping as three distinct things. To me the to_string function should really be about that: the conversion to a string. [PS1]
This would raise the question of adding it to all the reaction-to-string conversions, i.e. also the one with extended SMILES
I try to avoid confusion by keeping the number of arguments small
Linked to the last point: this may lead to other potential arguments such as sorting, removal of duplicates, etc.

Having said that, I am more open to having an external function doing multiple of those if needed. Something along the lines of cleanup_reaction(reaction_equation)? Here I would prefer to work on the reaction equation as on the str, as it is compatible with extended SMILES for instance. Also, I tend to prefer free non-member functions when possible.
What are your thoughts on this?
[PS1]: following up on the arguments with free functions and other kinds of strings, I was already tempted a few times to remove to_string from the ReactionEquation class 😉


Add input blocking when is_debug_overlay_open() is  (2023.800 and beyond)

Feature isn't in runtime yet (Russel says next), speculative patch here https://github.com/offalynne/Input/commit/ec278412b36a2f60c32a1699a4211972adcbe94a


Feat/header

Description
Give an overview of what you fixed in max 2 short sentences.
Context
Please include a summary of the changes and the related issue in more detail than in the description. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes # (issue)
Type of change
Please delete options that are not relevant.

[X] New feature (non-breaking change which adds functionality)

How Has This Been Tested?
This has been viewed in the localhost browser. Cypress testing NYI
Checklist:

[X] My code follows the style guidelines of this project
[X] I have performed a self-review of my code
[ ] I have commented my code, particularly in hard-to-understand areas
[X] I have made corresponding changes to the documentation
[X] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes
[ ] Any dependent changes have been merged and published in downstream modules

The search bar is not completed yet, but this is a good enough MVP.
I cleaned up the code and styling to be more accurate to the design comp but has more room for improvement.
Still the code works and is clean so we will be merging it. A new task for the search bar will be added.


There seems to be something wrong with puaf_smith.

I tested 'puaf_smith' on multiple devices and it seemed that it couldn’t work properly. At first I thought the offset was incorrect. Later, I found that a kernel panic had occurred before running to the place where the offset was needed(After run smith.h line 94).

{
  "build" : "iPhone OS 16.5 (20F66)",
  "product" : "iPhone12,1",
  "socId" : "8030",
  "socRevision" : "11",
  "kernel" : "Darwin Kernel Version 22.5.0: Mon Apr 24 21:10:28 PDT 2023; root:xnu-8796.122.4~1\/RELEASE_ARM64_T8030",
  "date" : "2023-07-27 02:39:43.19 +0800",
  "panicString" : "panic(cpu 5 caller 0xfffffff013800de0): pmap_remove_options_internal: attempt to remove mappings owned by pmap 0xfffffff053e2fb50 through pmap 0xfffffff09359f400, starting at pte 0xfffffff060630000 @pmap.c:5920\nDebugger message: panic\nMemory ID: 0x1\nOS release type: User\nOS version: 20F66\nKernel version: Darwin Kernel Version 22.5.0: Mon Apr 24 21:10:28 PDT 2023; root:xnu-8796.122.4~1\/RELEASE_ARM64_T8030\nFileset Kernelcache UUID: B3D22D357B9EB83D4394D3812CB2404A\nKernel UUID: 472BDDDB-68F8-3D70-AA5A-16908F61EEAE\nBoot session UUID: C355E07A-A0D4-4BA4-9E4E-610915FB3699\niBoot version: iBoot-8422.120.66\nsecure boot?: YES\nroots installed: 0\nPaniclog version: 14\nKernelCache slide: 0x000000000b350000\nKernelCache base:  0xfffffff012354000\nKernel slide:      0x000000000b358000\nKernel text base:  0xfffffff01235c000\nKernel text exec slide: 0x000000000c0c8000\nKernel text exec base:  0xfffffff0130cc000\nmach_absolute_time: 0xa5ec04ed\nEpoch Time:        sec       usec\n  Boot    : 0x64c167e5 0x000032a9\n  Sleep   : 0x00000000 0x00000000\n  Wake    : 0x00000000 0x00000000\n  Calendar: 0x64c16851 0x000151fd\n\nZone info:\n  Zone map: 0xffffffe06d908000 - 0xffffffe66d908000\n  . VM    : 0xffffffe06d908000 - 0xffffffe153f6c000\n  . RO    : 0xffffffe153f6c000 - 0xffffffe1a0c38000\n  . GEN0  : 0xffffffe1a0c38000 - 0xffffffe28729c000\n  . GEN1  : 0xffffffe28729c000 - 0xffffffe36d900000\n  . GEN2  : 0xffffffe36d900000 - 0xffffffe453f68000\n  . GEN3  : 0xffffffe453f68000 - 0xffffffe53a5d0000\n  . DATA  : 0xffffffe53a5d0000 - 0xffffffe66d908000\n  Metadata: 0xffffffe06b5fc000 - 0xffffffe06cdfc000\n  Bitmaps : 0xffffffe06cdfc000 - 0xffffffe06d8f8000\n  Extra   : 0 - 0\n\nCORE 0 recently retired instr at 0xfffffff01323e734\nCORE 1 recently retired instr at 0xfffffff01323e734\nCORE 2 recently retired instr at 0xfffffff01323e734\nCORE 3 recently retired instr at 0xfffffff01323e734\nCORE 4 recently retired instr at 0xfffffff01323e734\nCORE 5 recently retired instr at 0xfffffff01323d1ac\nTPIDRx_ELy = {1: 0xffffffe285d45b38  0: 0x0000000000000005  0ro: 0x00000001ee090160 }\nCORE 0: PC=0x00000001b6cdd2b4, LR=0x00000001b6d30010, FP=0x000000016d399ab0\nCORE 1: PC=0x0000000198d73058, LR=0x0000000198d72fbc, FP=0x000000016c596b40\nCORE 2: PC=0x00000001a5bedefc, LR=0x00000001a5bed198, FP=0x000000016c0ba440\nCORE 3: PC=0x000000019781e10c, LR=0x00000001977e791c, FP=0x000000016c4027e0\nCORE 4: PC=0xfffffff0131412c0, LR=0xfffffff0131412c0, FP=0xffffffef8b113ef0\nCORE 5 is the one that panicked.


[Feature request] : Show Order Details in the cart page

Description:
Our app currently doesn't display important information about orders, like the total cost, any discounts, or delivery fees. We want to make it better by adding a section that shows all these details.
Details:
Where to Show: We'd like this order details section to be easy to find, probably near the shopping cart or checkout page.
What to Show: Here's what we want to include:
Cart Items: We'll list all the things in your cart, how many of each, and how much they cost.
Total Before Discounts: This is how much everything costs before we take off any discounts.
Discounts: If you have any special deals or coupons, we'll show those here.
Delivery Cost: If you need something delivered, we'll say how much that costs.
Total Cost: This is the final amount you'll pay, with everything added up.
Example Picture: We've attached a picture to this request that shows exactly what we're thinking. It's a visual example of how the order details could look.

please assign this task to me

@Aryankax sure bro, have you worked on such functionality in react and what would be your approach to achieve this?

Yeahh I have experience in react, so my approach would be that first I will go through the code base to see if there are any components (like card component) which can be reused, if not then I will create one. I'll most probably I'll be using useState to keep track of each each (as in I can capture the price and count of each item) and will be using tailwind css for the styling. If not tailwind then I can also use vanilla css.

@Aryankax Sounds good, assigning the issue.

Thank you so much!

@Anandsg I'm getting this CORS Error due to which the items are not getting fetched from the swiggy api. Can you help me with this pls.

@Aryankax yes it is expected, sometimes our browser wont allow us to fetch data from external site we need to take help of CORS extension could you please install the extension and enable it and try.
https://chrome.google.com/webstore/detail/allow-cors-access-control/lhobafahddgcelffkeicbaginigeejlf

Alright I'll do that. Thanks.

@Anandsg Hey, it has been mentioned that I have to add discount price and price after discount and delivery but then how should I estimate discount price and delivery cost as it has not been given in the swiggy api

hey @Aryankax yes just hardcode it for now.

Alright!

@Aryankax any updates on this ? I hope you're doing it. the app runs without CORS extension now please free to fork latest version of the repo

Hey, i'm sorry for not responding for so long....I'm busy with my midterm exams could you pls assign this task to someone else. It'll take me some more time to complete this and I don't want to keep this task waiting, so if you want you can assign it to someone else

sure


feature/Decouple MessageListAdapter from MessageListFragment

I'm seeing quite a few PR's that are supposed to migrate ListView to Recycler. This is not as simple and evidently breaks in quite a few places.
This attempts, as the title indicates, to first decouple the adapter from the fragment reference.  I'm started to ride the snapshot with these changes as a daily. So far so good.
Further work is indicated by TODO's/FIXME's, but according to Code Style, they're not welcome. I'll try to clean that up later on.
Plan in further PRs is to

Separate ViewHolder from Adapter further.
Separate Cursor data extraction logic out of the adapter and viewholder.
Swap in the Recycler and Recycler.Adapter.
If possible/viable, allow for generics in the adapter, so we can have multiple object types on the MessageList view.
Provide a a proper Empty View/Load More to better follow the up to date design trends. (given this is the direction the project wants to go)

This in turn is a plan to refactor the monstrum that is the MessageListFragment, and finally allow for future ViewModel (from code reading this appears to be the direction) implementation for that part of code.

Sounds like a good plan :+1: Ideally it'll be implemented using small steps to make pull requests easy to review.
Unfortunately this pull request already is too big to not be painful to review. Can you please split this into multiple parts? It looks like you converted some classes to Kotlin. That's awesome :+1: But please make such changes in a separate commit. Better yet, use the VCS Kotlin Converter plugin and make it two commits. That way it'll be much easier to get the complete file history later. Also, please keep the conversion to Kotlin as simple and true to the original code as possible. If you want to improve the code, make it a separate commit.

rebase&squash habit got the better of me. I think reflog won't help me at this point.
Will reproduce this PR as separate commits in the following days. I'll try to keep it as granular as possible.

Reproduced it with a smaller scope.
I left out the the current implementation of MessageViewHolder - will come in further PRs.
I'll push it to my phone and ride it for a couple of days  to have it tested.

@cketti is there a way to download artefact of this build?

This PR fails at some license check during JDK install.

Part of the issues got addressed as separate commits. Feel free to mark comments resolved.
I'll address the rest during this week.

I've cleaned up the commit history and created PR #4140. I think it's ready to be merged. But I'd appreciate a quick look.


haproxy crashes with a segmentation fault

Whenever I attempt to get a new certificate, my haproxy service crashes with a segmentation fault.
00000266:production_webserver_frontend.accept(0007)=0010 from [<IP_ADDRESS>:49292]
00000266:production_webserver_frontend.clireq[0010:ffffffff]: GET /.well-known/acme-challenge/token HTTP/1.1
00000266:production_webserver_frontend.clihdr[0010:ffffffff]: Host: site.example.com
00000266:production_webserver_frontend.clihdr[0010:ffffffff]: User-Agent: Mozilla/5.0 (compatible; Let's Encrypt validation server; +https://www.letsencrypt.org)
00000266:production_webserver_frontend.clihdr[0010:ffffffff]: Accept: /
00000266:production_webserver_frontend.clihdr[0010:ffffffff]: Accept-Encoding: gzip
00000266:production_webserver_frontend.clihdr[0010:ffffffff]: Connection: close
[info] 314/131321 (25402) : [acme] served http-01 token: token (client-ip: <IP_ADDRESS>)
00000266:production_sites_nosni_be.srvrep[0010:ffffffff]: HTTP/1.1 200 OK
00000266:production_sites_nosni_be.srvhdr[0010:ffffffff]: Content-Type: text/plain
00000266:production_sites_nosni_be.srvhdr[0010:ffffffff]: Content-Length: 88
00000266:production_sites_nosni_be.srvhdr[0010:ffffffff]: Server: haproxy/acme-http01-authenticator
00000266:production_sites_nosni_be.srvhdr[0010:ffffffff]: Connection: close
Segmentation fault

It would likely help to provide the version of haproxy and what platform it's running on.

oops sorry I meant to include more info :)
I'm running on Centos 6.8 / haproxy 1.6.9 / lua 5.3.3

I've tried running an strace and I get nothing useful unfortunately, the only way I was able to get what I did was by running haproxy in debug mode, and even that was pretty useless for telling me what happend.  I've done an LDD on both lua and haproxy and I can provide that info if it's useful, but I can confirm other utilities using the same libraries have no issues.

I think the full output of "haproxy -vv" is needed, and a gdb backtrace of the crash as well.


dns/dyndns: add desec.io wildcard support

Adds https://desec.io wildcard support - see #2482
This is my first PR; I will happely incorporate any feedback.
Also note that I didn't packaged and tested the changes (as I still need to figure that out) - so I only validated the desec-API call via the https://insomnia.rest app.
Closes #2482.

hi @luclu,
Looking at https://github.com/opnsense/plugins/commit/71a8c222684 what you want to achieve should be a one-liner?
Cheers,
Franco

Ok, three lines... one for each case :)

hi @fichtner,
thank you for helping :)
I could change the if statement to a ternary operator like:
$result = condition ? value_true : value_false; - if you want me to.
Best,
Luca

Er, no, just add the wildcard services to the switch case.

On 23. Sep 2021, at 13:23, Luca Zeug @.***> wrote:

hi @fichtner,
thank you for helping :)
I could change the if statement to a ternary operator like:
$result = condition ? value_true : value_false; - if you want me to.
Best,
Luca
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications on the go with GitHub Mobile for iOS or Android.

Ah I see - this should be all then, right?

Looks good to me, thanks! ❤


add config to override the default 100 batch size for server queries

This option is not exposed in the pipeline controller

Thanks @machariamuguku for filing this. Is the main motivation for this to tune performance? Did you do any experiments with other numbers (I mean by running the pipeline directly) and saw significant speed-up?


Some tips about environment configuration

Before pip install -r requirements.txt, I need to

Add yacs to requirements.txt
Specify the version of torchsparse<EMAIL_ADDRESS>in requirements.txt or you cannot import PointTensor in gru_fusion.py.
sudo apt-get install libsparsehash-dev libeigen3-dev or some file cannot be included.
Add CUDA path to the environment variable (add this line to ~/.bashrc and source ~/.bashrc to make it effective immediately)

export LIBRARY_PATH="/usr/local/cuda/lib64/stubs:$LIBRARY_PATH"

It's recommended that use pip install . instead of python setup.py install in third_party/install.sh.

hello! these tips are very useful. This issue should be referenced in the pull request.

补充一条，在安装 requirements.txt 之前，要使用 pip install numpy==1.26.0 ，安装 1.26 版本的 Numpy 。
否则后续 Building wheel for torchsparse (setup.py) 阶段可能会出错，因为默认会安装的 Numpy 2.0 以上版本，导致冲突。


Update QpSolversEigenOsqp.cpp to remove duplicated code

Remove duplicated code.

Thanks for noticing! This is actually a bug, but I think the reason is that the second warm_start should be warm_starting for compatibility with osqp 1.0, see the docs: https://github.com/ami-iit/qpsolvers-eigen/tree/main/plugins/osqp#boolean-parameters . Can you change the PR to just fix the second if to use warm_starting ?

Thanks! This also fixes the code in https://github.com/ami-iit/qpsolvers-eigen/blob/8465681a84b4b1b88bcc3e543a4894e67041256d/examples/mpc/MPCExample.cpp#L257 .

Thanks @LoreMoretti ! I updated the title to be more descriptive for future reference (as PR title end up in the release notes).


Make g77 ABI wrapper work with gfortran ABI lapack

Reference issue

Ref: https://github.com/scipy/scipy/issues/11812
What does this implement/fix?

Using the g77 ABI wrapper with a gfortran ABI lapack doesn't
work for cladiv and zladiv as mentioned in https://github.com/scipy/scipy/issues/11812
This PR fixes that by calling sladiv and dladiv.
Additional information

Thanks, merged.


Releases Data Prepper 2.9.0

Description
Releases Data Prepper 2.9.0.
This adds Data Prepper 2.9.0 as a new artifact version and updates all OpenSearch versions to prefer this version of Data Prepper.
Issues Resolved
N/A
Check List

[x] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the BSD-3-Clause License.

The Data Prepper 2.9.0 artifacts are now ready. You can merge this PR now.


Owner-email is not obtained

Hi,
I am setting up this module with the most recent version of Redmine 2.5. For all emails it works fine, but for my personal email redmine_helpdesk can not save From email to owner-email.. I am enclosing whole email for you to find where problem could be.. Cron task does not show any error.
Return-Path<EMAIL_ADDRESS>X-Original-To<EMAIL_ADDRESS>Delivered-To<EMAIL_ADDRESS>Received: from localhost (web.prohost.cz.local [<IP_ADDRESS>])
	by web.prohost.cz (Postfix) with ESMTP id E67F8BE999
	for<EMAIL_ADDRESS>Sun,  6 Dec 2015 21:42:17 +0100 (CET)
X-Virus-Scanned: Debian amavisd-new at web.prohost.cz
Received: from web.prohost.cz ([<IP_ADDRESS>])
	by localhost (web.prohost.cz [<IP_ADDRESS>]) (amavisd-new, port 10024)
	with ESMTP id qagMkncTtC9Q for<EMAIL_ADDRESS>	Sun,  6 Dec 2015 21:42:16 +0100 (CET)
Received: from [<IP_ADDRESS>] (233.234.broadband7.iol.cz [<IP_ADDRESS>])
	(using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by web.prohost.cz (Postfix) with ESMTPSA id 03F3CBE8FC
	for<EMAIL_ADDRESS>Sun,  6 Dec 2015 21:42:15 +0100 (CET)
From: =?utf-8?Q?Milo=C5=A1_Koz=C3=A1k?=<EMAIL_ADDRESS>Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Subject: test
Message-Id<EMAIL_ADDRESS>Date: Sun, 6 Dec 2015 21:42:15 +0100
To: "Helpdesk prohost.cz"<EMAIL_ADDRESS>Mime-Version: 1.0 (Mac OS X Mail 9.1 \(3096.5\))
X-Mailer: Apple Mail (2.3096.5)

test emailu

Milo=C5=A1

This is the expected behavior if the email is the same one that you are using for your Redmine account. You'll need to add the Treat as supportclient permission for the Redmine users that are treated as support clients. Otherwise the owner-email is not saved.


Update README.md

What changes were proposed in this pull request?

Why are the changes needed?

Does this PR introduce any user-facing change?

How was this patch tested?

Can one of the admins verify this patch?

@drakelam, please read also https://spark.apache.org/contributing.html


Add generic type for SelfDescribing event data (close #156)

This PR allows for typing the self-describing event properties of trackSelfDescribingEvent

signed!

Confirmed! @henbrand  has signed the Contributor License Agreement. Thanks so much.


DAM: File Not Found Error State

check if file exists before returning it in BlobStorageFileStorage (previously the API server would crash if the file didn't exist on disk)
open error dialog if file doesn't exist on disk (only in DB)
show error message in file preview if file doesn't exist on disk (only in DB)

Open Question:

Is this the right way to handle an error like this?
This error is non-recoverable since the physical file disappeared from disk but the DB entry still exists
This should NEVER happen in normal operation
The file can be repaired by uploading the same file again
Possibility: automatically archive the file to prevent further use

Screencast:
https://user-images.githubusercontent.com/13380047/186102863-a590c898-f36e-4a11-b0c8-8dc38668e02f.mov

We should discuss this with UX, and may even think about adding options to restore the file or delete it in the DB.

Showing the "preview" and the error dialog for the file not found menu may be too much imo.

@thomasdax98 how do we proceed here?


[Bug]: While adding new JSobject error is displayed - 'JSobject1 already exist'

Is there an existing issue for this?

[X] I have searched the existing issues

Description
Created new app and try to add new JSobject >> Error is displayed that 'JSobject1 already exist'
Expected: Error should displayed when there is already a JSboject1 available while editing the JSboject name.
While creating, there should not be any error and it should create the JSobj appending numbers.
https://user-images.githubusercontent.com/80756091/192277407-2bbfd098-628f-47e3-a894-8455249a9330.mov
Env : Release/ Cloud
Steps To Reproduce

Create a app
Create new JSobject

Observation : Error is displayed that the JSobject1 already exist
Expected : If JSobject1 is not available on app it should not display the error and it should add JSobject
Public Sample App
https://release.app.appsmith.com/app
Version
could

@AnandiKulkarni it seems to be working for me

@Nikhil-Nandagopal its still reproducible at my end.

Imported the app on production and able to reproduce it

@AnandiKulkarni are you able to reproduce it on new/existing apps without an import?

@bharath31 this is reproducible on few apps and tried later on creating new app and issue no more existed but it is constantly existed on shared app. App is in primary stage and created on release date. Not sure why this error started coming

related to related to https://github.com/appsmithorg/appsmith/issues/14755


Popover doesnt stay open when clicking on calendar's day cell

I'm trying to implement the popover on each date of the <Calendar /> component. So what I did was that I created a custom popover component as such:
const DayPopover = (props) => {
  const date = props.date.getDate();
  return (
    <Popover>
      <PopoverTrigger asChild>
        {date}
      </PopoverTrigger>
      <PopoverContent className="w-48">

Test

      </PopoverContent>
    </Popover>
  );
};

And I added this component into the calendar component as its DayContent as such:
<DayPicker
    ...
    components: {{
        DayContent: DayPopover
    }}
/>

When I click on the date, the popover appears but disappears right immediately (But it stays open when I double click). However, if I try clicking on dates outside of the month, then the popover behaves correctly. What am I missing here?
https://github.com/shadcn-ui/ui/assets/75826315/b8b52127-b3ff-4dda-9e20-e90af0df5395

@owenn2106 Any chance you can share a Codesandbox link so I that I can debug? Thank you.


Update CI pipeline to use Pester v5

Pester v5 has just been released and introduced a number of breaking changes. These changes are not compatible with the current pipeline configuration.
For the moment Pester v4 will be used, however it should be upgraded to v5 at some time in the future.

I can probably help with this. Will need o convert the existing pester v4 tests to use pester v5 BeforeAll/BeforeDiscovery scoping and some other things. Will be a big job but I'll see how I go and send a PR for review 🙂 .