merging mml3 mode

as suggested by @inikep

@inikep : there are a number of issues when trying to merge your dev branch,
likely related to the removal of zstd_opt strategy and its ripple effects on the rest of the code base.
See : https://travis-ci.org/Cyan4973/zstd/builds/111780392
You might want to fix that on your branch, or let me do it after the merge, as you prefer.

I fixed problems with paramgrill:
https://github.com/inikep/zstd/commit/59493e8669832b56624c1e1f844d5915a64bc147
Please look at these errors, I'm not sure if it's related with my changes:
Starting zstd tester (64-bits, 0.6.0)
Seed = 4916
Error detected in Unit tests !

./fuzzer -v
result :
test  8 : compress with duplicated context : Error detected in Unit tests !
Likely explanation :
some new variables were probably added into compression context,
these new variables are probably not taken care of within existing ZSTD_copyCCtx() function.

I've found a bug in ZSTD_copyCCtx() but there is another problem. The error is reported here:
/* offset beyond prefix */
if (sequence.offset > (size_t)(oLitEnd - vBase))
return ERROR(corruption_detected);
Do you have any idea what can be a problem?

 offset beyond prefix
Decoder received an offset which is too large (goes "beyond prefix"). So it aborts operation to avoid reading outside its buffer.
This could be a case of the decoder badly decoding offset, or the encoder providing a bad offset value.

The problem is ZSTD_decompressBlock - Block functions produce and decode raw zstd blocks, without frame metadata.
There is no place to signal MINMATCH=3 or MINMATCH=4 as ZSTD_decompressBegin does not have compressionLevel.
What are your thoughts on this?

There is one more bug found by Travis. So far I've found it's not related to a new changes.
When you change zstd v0.5.1 in zstd_opt.h:126 from:
return ((litLength<<3) + ZSTD_highbit((U32)matchLength+1) + Offbits + ZSTD_highbit((U32)offset+1);
to:
return (litLength<<3) + ZSTD_highbit((U32)matchLength+1) + ZSTD_highbit((U32)offset+1);
then fuzzer.exe generates the same error:
Seed = 7536
11646      Error => streaming decompressed data corrupted : byte 2617994 / 3810755  (31!=30) (seed 7536, test nb 11646)

The problem is ZSTD_decompressBlock - Block functions produce and decode raw zstd blocks, without frame metadata. There is no place to signal MINMATCH=3 or MINMATCH=4 as ZSTD_decompressBegin does not have compressionLevel.

Indeed, it's a difficult point.
ZSTD_decompressBegin() is a generic context initializer, which is supposed to learn frame parameters from frame header. There's no point to force any parameter, it's not up to the decoder to decide if the frame use mml3 or mml4, it's up to the frame to tell it.
But in the case of block functions, there is by definition no frame, hence no header to read and know this information.
A few ideas to move forward :

Add a new method ZSTD_decompressBlocksBegin() where mml3/4 can be selected.

Pros : mml3/4 selection becomes possible
Cons : API becomes a bit more complex.
Caller needs to be aware of which proper setting is required to properly decode the block.
This is not trivial : mml3/4 is hidden behind "compression level", so the caller might be unaware of the proper setting, and require either look into zstd_compress.c source code, or access _advanced() functions within zstd_static.h, or have some trial & error process. None of these perspectives look acceptable.

Forbid mml3 in block mode. Automatically change it into mml4.

Pros : Fairly simple solution, low impact
Cons : obviously, no mml3 available for block mode. Could be detrimental for small blocks (which is the primary scenario for block compression mode, mostly intended to save Frame header space).

move mml3/4 into block header.

Pros : automatic and compatible with block mode. Could allow later optimizations where mml3/4 is selected per block (though gain perspective is pretty low).
Cons : repeated information. Increase header cost (once per block vs once per frame)

Current version seems to be ready to merge.

:+1:


language enum for French, German and Italian

To add these languages to the system, just the enum Language dict in index.ts in ./enum  should be extended? (or more things needs to be done?)
...
Italian = "ita",
French = "fra",
German = "deu"
}
DZ edit: also "Middle English" needed for , ISO code "enm".

@tomaham: in Concepts and/or the upcoming Statement Templates (S'), label language of some will be Middle English (vs. [modern] English). Please count on this while parsing - adding "enm" requested by editing your post.

@davidzbiral Well, this is more general inkVisitor responsibility- if the typescript held data model can work with  "enm" (it will allow the language as valid content of the property), then the parsing will.

Extending the enums needs a change in two places:

shared/enums/index.ts, where enum Language needs to be extended as:
and shared/dictionaries/language.ts

You can extend them anytime, but enum Language values should stay the same once when declared (e.g., changing the code of Czech language from "ces" to "cs") - these values are used within the database.

French, German, and Italian languages were added to the dictionary. Middle English was already added.


Make Zipper opaque. Add fromCons and from constructors

Basic attempt to make Zipper private (#10). Added two new constructors as well, since it would probably be useful to have these.

Looking forward to discussion, @wernerdegroot . I think making Zipper private is an important API change. Thoughts?

Hi @AdrianoFerrari , thanks for contributing. Although I haven't responded really quickly, I really appreciate you taking the time 👍
I would like to propose to add a few unit tests for the new functions.
Also, the fact that the Zipper constructors are now private is breaking the currently existing tests. Could you take a look at that too? Maybe it's a good idea to add a function to construct it from a beforeReversed, current and after so people can migrate easily? That could be useful for fixing the tests too!

Thanks for the feedback!
I'll try to bring the tests in line, and see about that beforeReversed constructor.

Added new unit tests, and doc clarification for from constructor.

Thanks for your contribution. I'll release this directly!

Published as 4.0.0! Well done!

Yay :tada:!
Thanks for the guidance and feedback.


Fix issue with booleans in volunteering_role_form

We were getting false positives when rendering check icons fo volunteering for whether someone had experience of working with children for a given volunteering experience.
Context
Bug identified by user
Changes proposed in this pull request
N/A in terms of UI design.
Guidance to review

do these changes make sense to you?
may be worth creating a new application - adding some volunteering experience at with with working_with_children set to 'Yes', and one set to 'No'. To test this is working correctly. It does for me but I may have done something silly, so a second pair of eyes would be good.

Link to Trello card
https://trello.com/c/lXwtGC10/2114-bug-this-role-involved-working-with-children-incorrectly-rendering-on-heading-components
Things to check

[x] This code doesn't rely on migrations in the same Pull Request
[x] If this code includes a migration adding or changing columns, it also backfills existing records for consistency
[x] API release notes have been updated if necessary
[x] New environment variables have been added to the Azure config

@tvararu happy to apply it to the work experience as well - interestingly though when I tested the work experience it appears to work at the moment though 🤔


Add provincial project search and detail csv download urls

@jbothma its totally WIP PR still, some things are committed but shouldn't (like template change)
If you have a while - I'd be happy to read your opinion about APIs, model, and approach at all.

we get the offset query parameter in the csv url for all but the first search coordinates API request

We only get 20 results in the search download even when there are more on the page

Going to skip the offset also dynamically change default page size - should work that way

Sorry @jbothma it was too late for such changes yesterday ;-)


[New Feature] Experiment with removing the Airflow authentication altogether

Working in a separate branch, figure out what it would take to remove the login from Airflow. This would be useful in case we decide that all Cognito authentication should be taken care by the top level proxy.

See PR https://github.com/unity-sds/unity-sps/pull/244 for implementation details. Removing the Airflow front-end authentication is possible, the next step is to test the flow when a user hits the top-level proxy URL and has to login with Cognito.


Updates to support rest_cherrypy /events API.

There's still a bit of work to do here.  I thought it best I create a PR and get some feedback from the other contributors before moving forward.  Still working through how best to create a unit test for this event stream.

Hello and thanks for contributing! This is a very nice effort overall, it will be super to include support for the /events API. I like this initial version, just tested it and it works great. Please feel free to move this forward with the goal of having a first version that can be merged.
Here is some questions that came up as I tried it out:

I need to log in before I can consume the stream, do we want to mention that somewhere?
How would I close the event stream from my application?
How could this code be tested automatically? Please add some unit tests if possible!

@renner  Thanks for your feedback, I'm glad you like the new additions.  I'll add line notes to a couple of your queries above.  Regarding your main points:

Agree, the Javadocs should be updated to indicate user must first login prior to subscribing/listening to the events stream
Regarding closing the event stream, a new method closeStream() should be added to  SaltStackEventStream.  Once called all subscribed listeners should be notified via eventStreamClosed() and listeners cleaned up and steam closed.
Yes, still working through the details of the unit test - seems to be more difficult than writing the original code :)

What do you think about the class names in general?  I'm thinking it may be best to remove Salt or SaltStack from my class additions.  I've gone back and forth on this in my mind on this.  In looking at the existing classes in the package, it would probably be more faithful to remove Salt/SaltStack.

Sounds good, the caller should be able to close the stream as you suggest I guess. Testing this could indeed get a bit tricky, but nevertheless we should do it. Let me know if there is any problems that you need help with.
About the class names: Good point, we decided a while ago (in #24) to drop the Salt/SaltStack prefixes everywhere besides the main library class (SaltStackClient). Please remove those prefixes from your new classes as well, thanks!

@renner Completed coding updates based on your feedback.  Also did some additional general cleanup and finalized outstanding TODO items.  I think the code is pretty much where I want it unless you have further feedback.  I'll start on the unit test/s now.

@renner I thought of one area you could certainly help me out.  The current code as per the PR doesn't attempt to deserialize the events into Java POJOs.  Perhaps the Jersey SSE implementation is returning well defined JSON messages that could be easily deserialized - I haven't checked yet.  Given your testing facilities there, perhaps you could generate a large body of diverse Salt server events so we can determine the level of difficulty in providing event deserialization support for the Java client.

Not planning to work on this further until I get some feedback otherwise.  Cheers!

@bgaisford: I will test your patch again, thanks for all those fixes and for adding tests! I might have some more remarks after testing (and @moio might add some more comments as well), but the overall scope of this PR is fine. Let's do the deserialization of events in another pull request after we merged this one.

Hey @bgaisford, thanks for this contribution!
I must say it's a pleasure to take the occasion of deep-diving into new tech while reviewing a PR, as it was the case with SSE here, :+1:!
Now a few questions:

jersey-media-sse - can you explain why you picked this library and not others?
EventStream - what about extending AutoCloseable?
EventStreamFactory - while I appreciate code being extendable and I like your implementation, I am not sure if it is worth to add a Factory here since we only have one EventStream/EventListener implementation. The main reason is: does it make sense to add and maintain an infrastructure to support several libraries? In other words, will it ever make sense to add and maintain more than one backend here? What about consolidating on Jersey and removing this Factory, the separate EventListener interface, EventStreamType and EventStream?
JerseyServerSentEvents.processEvents() - this method seems public for testing reasons only, correct? In that case I would suggest to add a Javadoc comment to tell clients that method should not be used directly.
EventAdapter - what is this for?
JerseyServerSentEventsTestCase - we named all test classes *Test and not *TestCase, please adapt this name accordingly.

About generating diverse Salt server events - I agree with @renner, this is not needed for this PR.
Overall those are minor points, I really like your contribution, thank you!

@moio @renner Thanks for the excellent feedback, it's very much appreciated.  I also like this feature and can envision uses for it as well as much more work that needs to be done:

Event deserialization (next PR)
Event versioning - SSE has very generic wrappers around the underlying Salt/rest_cherrypy events subsystem.  Over time the underlying event message contents may change.  How should versioning be handled?
Event filters would be a nice addition - only subscribe to certain types of events.

Addressing your points above (in order):

To be honest, I didn't do a thorough search of alternative Java SSE implementations.  The GlassFish/Jersey version was the first one I found.  Given that GlassFish is a reference platform a lot of times, it seems like a good initial candidate library for this feature.
Agreed, will do.
The factory/facade pattern is important here.  Consumers of this API need isolation from possible backend changes.  API developers need latitude to change the backend implementation without breaking existing client implementations.  I agree with removal of EventStreamType and associated logic.  Only one backend implementation will be supported.
Agreed, will do.
I'll remove EventAdapter .  When I first started this effort I thought the EventListener  interface may containing many more methods than it did.  I added an adapter so a client only interested in a small subset of the EventListener methods could opt out of providing implementations for all of them.
Agreed, will do.

Thanks again for all your feedback and encouragement, this was a fun feature to implement. :)  I'll commit these latest updates promptly.
Note: While looking at the project forks on GitHub yesterday I noticed that @mohamedazouz has a branch to add events.  I included him here in this PR comment in hopes to avoid duplication of effort.

@bgaisford  and @renner  I did some implementation for parsing events on my branch. And also I have a  pretty ugly test implementation which instead of Jersey uses plain Apache HTTPClient - uses lonh polling . Unfortunately I don't have the time needed to get this done but if you guys find it useful fell free to use it .. at least as a starting point for events parsing

@cmorar Thanks for the heads up, I'll definitely take a look at your work to date.

Hey @bgaisford, I merged your patch after I tested it again. Works great so far, seeing all the events coming in real time. Please have a look at the commits I added on top. I discussed with @moio about the EventStreamFactory (and interface) and we both agreed on "don't add complexity until it's needed".
The point is: whenever we want to change the underlying implementation we will just do that. We won't break the API since the class is just called EventStream now and we further won't have two different implementations in parallel that you can switch between.
Two other remarks that you should consider when doing further contributions:

Some of your commit messages are quite long, please note that commit messages should better follow certain guidelines, see for example [this article] (http://chris.beams.io/posts/git-commit/).
Fixing the typo ("Required persmissions") is a very valid fix (and I merged it), but it doesn't belong to this patch. Better do such a fix as a separate PR or at least in a separate commit.

Apart from that: thanks again for your contribution and please feel free to submit any further pull requests!

Hey @renner, the updates look great.  Thanks for the additional pointers as well.  Cheers!


Add checksum details to docs

URL for relevant page?
Installation pages and possibly the downloads page.
See: https://github.com/kyzh/docs.influxdata.com/commit/91a8cfadb283de10ef720685e0f8a1aa72dbd9bf#diff-a1d5f3ae423b181848d95500e9cd2a42R53
Props to @kyzh for thinking of this.

thanks :)

This is on the downloads page now.


How to edit the name of an event and how to delete an event?

For now, I can only create new events with i or o. I cannot edit the name of an existing event. Nor can I delete an event created with i (or o). Please advise how to modify events with calendar.vim.
For my GCP app, I set the scope as the following, which covers both "edit" and "delete". Through this app, the connection did go through after following the steps mentioned in the important notice.

I have also tried to assign mappings in the :Calendar buffer. Still, none of the keys triggered anything in the Calendar view.
nnoremap c <Plug>(calendar_change)
nnoremap C <Plug>(calendar_change_line)
nnoremap d <Plug>(calendar_delete)
nnoremap d <Plug>(calendar_delete_line)

I wish I am missing something really simple. In the task panel, both c and d are working as intended.

By default you can edit and delete events in the event view, which you can show with E. In the popup, you can edit with i and a, and delete with dd and D. For customizing the Plug mapping, use nmap instead of nnoremap.

Thanks a lot for your clarification!
Indeed, entering the event view with E gets C and D to work again. (My events have pretty short names. It suffices to either delete them or rename altogether.)

Is it documented anywhere ? @llinfeng


File not found errors during compilation (in CI)

I have noticed we're getting a file not found error in CI every now and then. I think it's from zig... but how and why?
Thus far, I have noticed two variations, we're getting one of:

error: FileNotFound
error: unable to build compiler_rt: FileNotFound

Occurrences:

https://github.com/actonlang/acton/actions/runs/3434938172/jobs/5726732829 error: FileNotFound
https://github.com/actonlang/acton/actions/runs/3434938172/jobs/5727178233 error: unable to build compiler_rt: FileNotFound
https://github.com/actonlang/acton/actions/runs/3438113386/jobs/5733751980 error: unable to build compiler_rt: FileNotFound

I think we can start by giving zig the --verbose (I think it's called, from top of my head) which will print a lot about how it was invoked etc... is it referring to the actual .c file or what file can't be found?
Not sure we can make much more meaningful progress beyond that, think zig needs to improve the error to report which file is not there, but let's see...

Okay so zig ships with compiler_rt as source files and then compiles it when needed. It is also cached. Sort of guessing here, but it could perhaps be a concurrency bug where we run multiple zig invocations at the same time and they compete over some files.

The upstream zig issue is closed with a likely fix. I'll close this too. It's probably fixed now. Will reopen if not.


Sticky element ref is overwriten

I'm submitting a ...

[x] bug report
[x] feature request
[ ] support request

If you're reporting a bug, please provide a minimal demonstration of the problem
What is the current behavior?
When rendering this Sticky element:
<Sticky>
  {
    ()=>

  }
</Sticky>

The ref was called is not printed.
Since here the ref prop is overwritten.
What is the expected or desired behavior?
I expect to be able to get a ref to my

Why do you want this? What use case do you have?
I might need something other than the supplied 'calculatedHeight`.
What is your environment?

Version: 6.0.3
Browser: Chrome

Thanks for the report! Now that React provides a ref forwarding API this is definitely something we could provide. If you wanted to take a stab at it I'd be happy to merge a PR :)

Oh this is an interesting bit from that post, however

When you start using forwardRef in a component library, you should treat it as a breaking change and release a new major version of your library.

That's a good point, if there are people relying on ref returning the instance of Sticky, changing this would break their application. I'm not sure the marginal improvement is worth a major version release at the moment.


Use Esprima 2.

Facebook's fork is deprecated. Using the upstream Esprima 2 since it already supports ES6 features.

@olov ping

defs does not understand the full ES6 language (only a very limited subset). Since regenerator depends on esprima-fb, and since regenerator can be used in tandem with defs (passing AST), I see more downside than upside of switching.
defs is still here and working (I still use it in production), but doesn't attract new users or try to keep existing ones from moving on, quite the opposite. The post-ES5 landscape is vastly different now compared to when I wrote defs, and as defs users want to use more features of ES20xx and later, such as arrow functions or template literals, they naturally move to Babel or TypeScript. Even if they want to stay on just ES5 + constlet, tsc is still a better choice for most, the only drawback I know of is that tsc is slower. Migrating from defs to Babel may be a bit problematic still because Babel does not catch as many errors via static analysis and because Babel outputs unnecessary IIFE's where defs don't. Give it some more time and Babel should catch up fully.


Uninstall deletes entire .cargo directory

Surely it should only delete stuff that it created?

Thanks for the report.
My reasoning for deleting .cargo is that rustup is responsible for the installation of the entire rust 'world', including cargo, so when it uninstalls itself (and cargo) it should uninstall everything. Everything in .cargo ultimately did originate from the rustup installation, if indirectly. I also don't know that there's much useful to do with .cargo if you don't have Rust.
I suspect that, for the average user who is ditching Rust, they really just want all of Rust off their system after uninstall.
I do see some use for being able to preserve both .cargo and .multirust. For example I uninstall and reinstall constantly and it's super annoying to reinstall the toolchains every time.
Another thing one might do with .cargo use use the bins from cargo install, but just copying out what you need to somewhere else before uninstalling is not too burdensome for what seems a niche case.
So I think it's a reasonable option, but not the default. I'm interested in other reasons for preserving .cargo after uninstall.

rustup isn't necessarily the only rust install so it can still be useful to have the .cargo folder after removing rustup and it's toolchains.
People could be using ~/.cargo/config as a config to cover all repos in ~ and I don't think deleting people's hand written configs is very friendly. I would say that's more an issue in how cargo handles it's directories though.
In my case I just had to cargo install everything again after just trying rustup which I did not expect to have to do.
I think it should be optional but at the very least the uninstaller should be more specific about what its going to delete so you can backup anything you do want to keep. The installer is also a bit misleading as "You can uninstall at any time with rustup self uninstall and these changes will be reverted." suggests it will only delete things it created.

Thanks for the further feedback @ollie27. I agree the uninstall message could be more clear and give options to not delete the cargo directory. For now though my inclination is still that for most users throwing away ~/.cargo is the right thing.

I think rustup now checks for an existing cargo on installation, so this shouldn't be an issue any more. @brson ?

@Diggsey rustup will refuse to install over certain other rust installations, which might prevent some of the problem, but there's still no way to preserve .cargo during uninstall.


[WIP] Share registry auth with invocation image

Signed-off-by: Simon Ferquel<EMAIL_ADDRESS>Signed-off-by: Ian Campbell<EMAIL_ADDRESS>This is a pretty straight port of the code from Simon's earlier attempt in https://github.com/docker/app/pull/436/commits/5ff0fb23abec475c81f61ea126cabaa6cf93ce90 to the current code base.
I haven't even really done any "self" review yet, so WIP. Also more tests needed.

I plan to rebase this onto #492 since that will allow some nice cleanups.

@silvin-lubecki thanks! I just realised I forgot to git push on two cleanup commits, sorry! I've done that now, if you don't like them and want to rescind your LGTM I can rewind instead...

Still LGTM, but the linter is complaining:
internal/commands/root.go:58:44:warning: exported func MakeMergeBundleOpts returns unexported type []commands.mergeBundleOpt, which can be annoying to use (golint)
internal/commands/root.go:58:1:warning: exported function MakeMergeBundleOpts should have comment or be unexported (golint)
make: *** [Makefile:74: lint] Error 1
docker.Makefile:107: recipe for target 'lint' failed

Thanks, I realised as I went home yesterday that I had no good reason to export that function. Will fix now!


New configuration: gem uninstall sensu-plugin  is failing in 1.5.0

I have been building a vagrant box as my 'reference' configuration to learn sensu / grafana etc.
I haven't touched this since version 1.3.1.   When I upgrade to 1.5.0, and build a clean vagrant box, the configuration I have isn't sufficient.   Version 1.3.1 however does work with my vagrant box.
The sensu-plugin  gem should be installed under /opt/sensu/embedded......,  and it is.. however this script seems to want to uninstall it from the system ruby..   I'm not sure why?
I have had a quick peek at the sensu-puppet code and I don't see an ensure => absent.
To recreate

clone this: https://github.com/brettswift/vagrant-sensu_example
Upgrade the version of sensu in the Puppetfile
run  vagrant up sensuserver.

It may be my code, but nothing jumps out at me in the README documentation.
Is this a bug?
==> sensuserver: Error: /Stage[main]/Sensu::Package/Package[sensu-plugin]/ensure: change from 1.1.0 to absent failed: Execution of '/usr/bin/gem uninstall -x -a sensu-plugin' returned 1: ERROR:  While executing gem ... (Gem::InstallError)
==> sensuserver:     cannot uninstall, check `gem list -d sensu-plugin`
==> sensuserver:
==> sensuserver: Error: Execution of '/usr/bin/gem uninstall -x -a sensu-plugin' returned 1: ERROR:  While executing gem ... (Gem::InstallError)
==> sensuserver:     cannot uninstall, check `gem list -d sensu-plugin`

+1. Also facing this issue on a real CentOS 6.5 installation using version 1.5.0 of the sensu puppet module.
Error: Execution of '/usr/bin/gem uninstall -x -a sensu-plugin' returned 1: ERROR:  While executing gem ... (Gem::InstallError)

It appears the default value in init.pp for $sensu_plugin_version is absent:
$sensu_plugin_version     = 'absent',

So @brettswift just specify in your sensu server manifest file (or hiera conf) sensu_plugin_version => 'installed' and you should be ok.
The instructions for a basic installation on https://forge.puppetlabs.com/sensu/sensu need to be updated to reflect that as well.

@pythianliappis We'd welcome a PR with a docs update and/or a fix! Thanks!

@jamtur01 Will do James!

Yes I found the same thing... sorry I forgot to update this ticket.   The reference repo at the above link works on the master branch.  Thanks @pythianliappis

Hey folks,
I believe I found an issue in puppet resulting in the execution of /usr/bin/gem uninstall -x -a sensu-plugin rather than /opt/sensu/embedded/bin/gem uninstall -x -a sensu-plugin.
I have raised issue PUP-4191 in the puppet project and opened PR #3708 in puppetlabs/puppet.
I've also raised PR #332 in this project to work around this issue.
Could you please retest sensu/sensu-puppet with my workaround in place?
Thanks!

I got bitten by this too, and it makes me wonder why it defaults to 'absent'?
I would have thought installing the sensu-plugin gem would have been the most likely use case, especially as excluding it means a newbie will be scratching their head as to why it doesn't Just Work.


Travis CI for automatic testing

Can you squash these all of these into a single commit using git rebase -i? You'll have to do a git push --force afterwards.


Update phpspec dependency

Could we just merge this, @Zales0123, since the build has nothing to do with phpspec?


CIP-0020 choice of format/structure - suggestion

I have a suggestion for what, in my view, would be an improvement to the current proposed structure of the 674 message.
I couldn't find any discussion platform for this topic so I felt like creating an issue was the only way I could bring this to people's attention.
{
  "674":
          { "Invoice-No": "1234567890",
            "Customer-No": "555-1234",
            "Comments": ["P.S.: i will shop again at your store :-)"
                                , "Shopping experience was excellent"]
         }
}

In my opinion, storing key/value pairs inside a string, inside an array, inside a JSON metadata structure is not a smart approach. JSON is already a key value data format. Storing key/value data in this way will introduce the need to have to implement a custom parser, whilst preserving a JSON structure gives easy access to these values directly.
Metadata is expected to be provided as JSON. It is even stored in a column called json in the tx_metadata table in the db-sync database.
Existing tools/wallets already display 721 data in a structured way, by iterating over the key/value pairs,and showing them as labels and values respectively.
The current 674 proposal will introduce the need to handle 674 metadata in a different, inconsistent way.
I also believe that the "msg" key is redundant and offers no extra benefit. The 674 key is already enough to identify the metadata type.
The 674 content structure will be determined by the creator of the transaction/tool and will therefore not follow any particular common standard. Having reserved keys such as "version" etc could be left entirely at the discretion of the transaction creator.
I therefore do not see the added value of having a reserved top-level for keys such as msg, ver, etc...

Hey @grim-i-am, thank you for taking part in the discussion, but please note that CIP discussions need to happen in the CIP repo. The developer portal pulls data only from this repo to present it in a prettier way.
(therefore I'm closing this)

Ok, I've created a new issue there. Thanks


parentage of GO:0018094 protein polyglycylation and GO:0018095 protein polyglutamylation

GO:0018094 protein polyglycylation and GO:0018095 protein polyglutamylation are both posttranslational modifications in which a chain of peptide-bonded amino acids is attached to the side-chain carboxyl group of a glutamate residue on a target protein. The most famous examples involve modification of tubulins (PMID: 25957412)
GO:0018095 protein polyglutamylation is connected to  GO:0006464 cellular protein modification process via two intervening is_a parentage steps, while GO:0018094 protein polyglycylation is connected with no intervening steps. The first longer path seems better.

Easy fix! Thanks Peter.
def: "The addition of glycyl units covalently bound to the gamma carboxyl group peptidyl-glutamic acid."

The definition of peptidyl polyglycation is: The addition of glycyl units covalently bound to the gamma carboxyl group peptidyl-glutamic acid.
The definition of peptidyl-glutamic acid modification is: The modification of peptidyl-glutamic acid.
so isn't that correct, or am I still in hazy vacation mode?
The definition of peptidyl-glycine modification is: The modification of peptidyl-glycine.
The definition of peptidyl-amino acid modification is: The alteration of an amino acid residue in a peptide.

That all looks good.
Thanks.
Peter
From: David Hill<EMAIL_ADDRESS>Sent: Tuesday, January 10, 2017 4:47 PM
To: geneontology/go-ontology
Cc: D'Eustachio, Peter; Author
Subject: Re: [geneontology/go-ontology] parentage of GO:0018094 protein polyglycylation and GO:0018095 protein polyglutamylation (#12907)
The definition of peptidyl polyglycation is: The addition of glycyl units covalently bound to the gamma carboxyl group peptidyl-glutamic acid.
The definition of peptidyl-glutamic acid modification is: The modification of peptidyl-glutamic acid.
so isn't that correct, or am I still in hazy vacation mode?
The definition of peptidyl-glycine modification is: The modification of peptidyl-glycine.
The definition of peptidyl-amino acid modification is: The alteration of an amino acid residue in a peptide.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_geneontology_go-2Dontology_issues_12907-23issuecomment-2D271708176&d=DgMFaQ&c=j5oPpO0eBH1iio48DtsedbOBGmuw5jHLjgvtN2r4ehE&r=FCJ8Ss3HV4Bv4t5pwSEyfEsEX_H7Qf0HYgfOzLSzd4g&m=y5lVVRaumaaN44YjsvGO_EEs4TBqjVA409R68Su1A90&s=I55G-9aOhhtra4mTajbwTXfwiWXcJXEYAS43s9melyE&e=, or mute the threadhttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_notifications_unsubscribe-2Dauth_AMJcV8J3I9oTLMlG3THUKZNinYCporNsks5rQ-5FxhgaJpZM4Lf1df&d=DgMFaQ&c=j5oPpO0eBH1iio48DtsedbOBGmuw5jHLjgvtN2r4ehE&r=FCJ8Ss3HV4Bv4t5pwSEyfEsEX_H7Qf0HYgfOzLSzd4g&m=y5lVVRaumaaN44YjsvGO_EEs4TBqjVA409R68Su1A90&s=uHDp_OM6qVfb_PhldZepzd0v3JlrAPglJc_NzYZr50Y&e=.

This email message, including any attachments, is for the sole use of the intended recipient(s) and may contain information that is proprietary, confidential, and exempt from disclosure under applicable law. Any unauthorized review, use, disclosure, or distribution is prohibited. If you have received this email in error please notify the sender by return email and delete the original message. Please note, the recipient should check this email and any attachments for the presence of viruses. The organization accepts no liability for any damage caused by any virus transmitted by this email.


Merge from the original

Pulling all the changes from the original repo so that the forked one is updated

Rebase doesn't work so squashed


[bug]: cannot fit 'int' into an index-sized integer

Is there an existing issue for this problem?

[X] I have searched the existing issues

Operating system
Windows
GPU vendor
Nvidia (CUDA)
GPU model
RTX 4070 Ti
GPU VRAM
12GB
Version number
4.2.3
Browser
Chrome
Python dependencies
{
"accelerate": "0.29.2",
"compel": "2.0.2",
"cuda": "12.1",
"diffusers": "0.27.2",
"numpy": "1.26.4",
"opencv": "<IP_ADDRESS>",
"onnx": "1.15.0",
"pillow": "10.3.0",
"python": "3.10.9",
"torch": "2.2.2+cu121",
"torchvision": "0.17.2+cu121",
"transformers": "4.39.3",
"xformers": "0.0.25.post1"
}
What happened
I downloaded and installed for the first time. I wanted to try and use my diffusers trained checkpoint now that Kohya supports training diffusers. Kohya can both train and generate samples. I wanted to try out InvokeAI, i cant load the checkpoint with A1111 since it does not support diffusers. I loaded the model, picked a very simple test prompt "1girl", and hit invoke, and program errored with OverflowError: cannot fit 'int' into an index-sized integer.
What you expected to happen
That it generates an image without issue.
How to reproduce the problem

load my diffusers checkpoint
hit invoke
--> error

Additional context
Loading a safetensors model that i got from civitai works fine. There should not be an issue with my model since it both trains and samples just fine in Kohya.
My full error message
[2024-05-29 12:59:33,544]::[InvokeAI]::ERROR --> Error while invoking session c3c5bf7b-a661-45b2-9aa9-56636eed1485, invocation 54a35b4a-7ad1-4410-ba3f-6757563bea2a (compel):
cannot fit 'int' into an index-sized integer
[2024-05-29 12:59:33,544]::[InvokeAI]::ERROR --> Traceback (most recent call last):
  File "C:\Train\InvokeAI\.venv\lib\site-packages\invokeai\app\services\session_processor\session_processor_default.py", line 185, in _process
    outputs = self._invocation.invoke_internal(
  File "C:\Train\InvokeAI\.venv\lib\site-packages\invokeai\app\invocations\baseinvocation.py", line 281, in invoke_internal
    output = self.invoke(context)
  File "C:\Train\InvokeAI\.venv\lib\site-packages\torch\utils\_contextlib.py", line 115, in decorate_context
    return func(*args, **kwargs)
  File "C:\Train\InvokeAI\.venv\lib\site-packages\invokeai\app\invocations\compel.py", line 111, in invoke
    c, _options = compel.build_conditioning_tensor_for_conjunction(conjunction)
  File "C:\Train\InvokeAI\.venv\lib\site-packages\compel\compel.py", line 186, in build_conditioning_tensor_for_conjunction
    this_conditioning, this_options = self.build_conditioning_tensor_for_prompt_object(p)
  File "C:\Train\InvokeAI\.venv\lib\site-packages\compel\compel.py", line 218, in build_conditioning_tensor_for_prompt_object
    return self._get_conditioning_for_flattened_prompt(prompt), {}
  File "C:\Train\InvokeAI\.venv\lib\site-packages\compel\compel.py", line 282, in _get_conditioning_for_flattened_prompt
    return self.conditioning_provider.get_embeddings_for_weighted_prompt_fragments(
  File "C:\Train\InvokeAI\.venv\lib\site-packages\compel\embeddings_provider.py", line 119, in get_embeddings_for_weighted_prompt_fragments
    tokens, per_token_weights, mask = self.get_token_ids_and_expand_weights(fragments, weights, device=device)
  File "C:\Train\InvokeAI\.venv\lib\site-packages\compel\embeddings_provider.py", line 280, in get_token_ids_and_expand_weights
    return self._chunk_and_pad_token_ids(all_token_ids, all_token_weights, device=device)
  File "C:\Train\InvokeAI\.venv\lib\site-packages\compel\embeddings_provider.py", line 307, in _chunk_and_pad_token_ids
    chunk_token_ids += [self.tokenizer.pad_token_id] * pad_length
OverflowError: cannot fit 'int' into an index-sized integer

Discord username
No response

So i decided to dig a bit into the code to see what could cause it. This might be an issue i should probably send over to 'compel', since its a bug in their code.
            pad_length = self.max_token_count - len(chunk_token_ids)
            chunk_token_ids += [self.tokenizer.pad_token_id] * pad_length

self.max_token_count is<PHONE_NUMBER>000000019884624838656, and chunk_token_ids is 4, im guessing bos + 1 + girl + eos.
self.max_token_count should be 77, since its comparing it to a tensor of size 77, so i tried to force the max to be 77 rather then asking what the max is, and it solved the issue.


Support for Nix 24.05?

I'm not using nixpkgs unstable, and I just installed nixOS on my system, so I have 24.05.
According to the readme, I need to specify the nixpkgs version in the flake, but I'm getting an error that it cannot be found (because the branch doesn't exist!)
sudo nixos-rebuild test --flake /etc/nixos#default
error:
       … while updating the lock file of flake 'path:/etc/nixos?lastModified=1716405479&narHash=sha256-jVjsvFjxUMz6Pao9QfsG2pqPEArHARpB2ILTUVqdZ6U%3D'

       … while updating the flake input 'nixvim'

       … while fetching the input 'github:nix-community/nixvim/nixos-24.05'

       error: unable to download 'https://api.github.com/repos/nix-community/nixvim/commits/nixos-24.05': HTTP error 422

       response body:

       {
         "message": "No commit found for SHA: nixos-24.05",
         "documentation_url": "https://docs.github.com/rest/commits/commits#get-a-commit"
       }

We've not yet made a 24.05 branch. I'm sure we will soon.
In the meantime, you could build a standalone nixvim derivation (using unstable) as a workaround.

This issue has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/getting-error-rnix-lsp-has-been-removed-as-it-is-unmaintained-while-trying-to-update-from-23-11-to-24-05/46280/6

The stable branch has been created: https://github.com/nix-community/nixvim/tree/nixos-24.05


Support node 16 (update puppeteer)

I'm reusing my SVG to PNG code that is battle tested on an old (2021!) project, but when deploying to Vercel, I get this error calling the endpoint:
2022-12-21T02:15:00.609Z	9e2b2872-6888-4569-b0e6-0befd516db2d	ERROR	Error: Could not find expected browser (chrome) locally. Run `npm install` to download the correct Chromium revision (982053).
    at ChromeLauncher.launch (/var/task/node_modules/puppeteer/lib/cjs/puppeteer/node/Launcher.js:105:23)
    at async Converter.[getPage] (/var/task/node_modules/convert-svg-core/src/Converter.js:364:24)
    at async Converter.[convert] (/var/task/node_modules/convert-svg-core/src/Converter.js:283:18)
    at async Converter.convert (/var/task/node_modules/convert-svg-core/src/Converter.js:185:12)
    at async API.convert (/var/task/node_modules/convert-svg-core/src/API.js:80:16)
    at async handler (/var/task/.next/server/pages/api/misc/aspng.js:50:23)
    at async Object.apiResolver (/var/task/node_modules/next/dist/server/api-utils/node.js:185:9)
    at async NextNodeServer.runApi (/var/task/node_modules/next/dist/server/next-server.js:395:9)
    at async Object.fn (/var/task/node_modules/next/dist/server/base-server.js:496:37)
    at async Router.execute (/var/task/node_modules/next/dist/server/router.js:226:36)

It seems like the puppeteer version used by this package works only with Node 14, not Node 16.
Some insight...
https://github.com/vercel/community/discussions/124

Do you have any solution to this issue?
I change node to 14 in the vercel setting, but it doesn't work.


support unavailable fs.Stats

No error will be thrown if fs.Stats is not available (such as in browserify).
If a instanceof b is called, while b is not a function, an error is thrown.

Any news?

Only that I'm sorry, this feel through the cracks :(

Can you tell me, in browserify, what exactly is the value of Stats? Is it undefined, null, or something else?

browserify is intended to run node modules in the browser - where obviously you can't access files. require('fs') just returns an empty object, so fs.Stats will be undefined.

But a instanceof b will throw an error if b is anything but a function, so I think the typeof check is appropriate.


Add snippet to render available timeslot on the site

Probably as a snippet with full access to all options like the checkout, so you can do both table-style and "Order by {datetime} to pickup/deliver at {slot time}" from the same integration by passing in a twig template.
https://secure.helpscout.net/conversation/1420109484/26480?folderId=46284

Functionality added in PR #5


feat: [CDS-53571]: add sharing filter functionality

Harness Developer Pull Request
Thanks for helping us make the Developer Hub better. The PR will be looked at
by the maintainers.
What Type of PR is This?

[ ] Issue
[x] Feature
[ ] Maintenance/Chore

This PR adds the sharing filter functionality available behind a feature flag on CG Deployments page. The feature is already available in the current production version.

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app


[stable/hazelcast] Documentation outdated and not shown on Helm Hub

The documentation does not show the Helm 3.x syntax.
No documentation visible at https://hub.helm.sh/charts/stable/hazelcast

The issue is still unresolved

The issue is still unresolved


Unable to use salesforce/cli docker slim image

Note
Before you submit your issue, make sure that:

You're using the latest version of Salesforce CLI.
You've searched both open and closed issues for related posts.
You've used the doctor command to diagnose common issues.
You understand that GitHub Issues don't adhere to any agreement or SLA.

If you require immediate assistance, use official channels such as Salesforce Customer Support.

Summary
I am trying to use the slim docker image from docker hub (2.23.4-slim)
And when I execute simply: sf -v
I get this error: /usr/local/sf/bin/sf: line 45:    21 Segmentation fault      "$NODE" "$DIR/run" "$@"
I can't use it in my daily work.
Steps To Reproduce

IMPORTANT
Provide a repository that's configured to reproduce the issue. If you are unable to provide a repo, please explain why not. The more info we have from the start, the faster we can resolve your issue.
We may close your issue if you don't include proper instructions.

Generate a project with sf project generate or fork dreamhouse-lwc.
Provide detailed step-by-step instructions on how to reproduce the issue.

Having docker engine installed in Mac OS Sonoma 14.2
docker pull salesforce/cli:2.23.4-slim
docker run --name salesforce -it salesforce/cli:2.23.4-slim
In the container terminal
root@0dcf76c916aa:/#
Write sf -v
Expected result

@salesforce/cli/2.21.8 darwin-x64 node-v20.10.0
Actual result

/usr/local/sf/bin/sf: line 45:    21 Segmentation fault      "$NODE" "$DIR/run" "$@"
System Information

I am using Mac OS Sonoma 14.2. Terminal is zsh

This does not apply because I can't install the cli in the docker image
PASTE_VERSION_OUTPUT_HERE

Additional information

Interesting, we have not changed in that Dockerfile for a long time. Are you seeing this on any other Docker-slim versions? The "verify" step for 2.23.4 just passed yesterday https://github.com/salesforcecli/cli/actions/runs/7250635676/job/19751675906#step:3:25

Thanks for answering @iowillhoit . I have just retry this (just in case):
docker pull salesforce/cli:2.23.4-slim
docker run -it salesforce/cli:2.23.4-slim
Once I am in the container terminal I execute:
sf version
And I get the error: /usr/local/sf/bin/sf: line 45:    21 Segmentation fault      "$NODE" "$DIR/run" "$@"
Certainly I can see the "verify" step passes. And the command: java --version works perfectly.
Any further idea? Thanks for helping

@carlosabella
I'm on macos sonomia 14.2 too and can't repro this:

does the previous slim images work for you?

@cristiand391 Thanks for the help.
Yes it happens with previous images also. Today I could dig a bit more and I found the following:
The error says:

So I checked the path: /usr/local/sf/bin/sf
And I opened the "sf" file. What I found is the following:
`#!/usr/bin/env bash
set -e
echoerr() { echo "$@" 1>&2; }
get_script_dir () {
SOURCE="${BASH_SOURCE[0]}"
While $SOURCE is a symlink, resolve it
while [ -h "$SOURCE" ]; do
DIR="$( cd -P "$( dirname "$SOURCE" )" && pwd )"
SOURCE="$( readlink "$SOURCE" )"
# If $SOURCE was a relative symlink (so no "/" as prefix, need to resolve it relative to the symlink base directory
[[ $SOURCE != /* ]] && SOURCE="$DIR/$SOURCE"
done
DIR="$( cd -P "$( dirname "$SOURCE" )" && pwd )"
echo "$DIR"
}
DIR=$(get_script_dir)
CLI_HOME=$(cd && pwd)
XDG_DATA_HOME=${XDG_DATA_HOME:="$CLI_HOME/.local/share"}
CLIENT_HOME=${SF_OCLIF_CLIENT_HOME:=$XDG_DATA_HOME/sf/client}
BIN_PATH="$CLIENT_HOME/bin/sf"
if [ -z "$SF_REDIRECTED" ] && [ -x "$BIN_PATH" ] && [[ ! "$DIR/sf" -ef "$BIN_PATH" ]]; then
if [ "$DEBUG" == "" ]; then
echoerr "$BIN_PATH" "$@"
fi
SF_BINPATH="$BIN_PATH" SF_REDIRECTED=1 "$BIN_PATH" "$@"
else
export SF_BINPATH=${SF_BINPATH:="$DIR/sf"}
if [ -x "$(command -v "$XDG_DATA_HOME/oclif/node/node-custom")" ]; then
NODE="$XDG_DATA_HOME/oclif/node/node-custom"
elif [ -x "$(command -v "$DIR/node")" ]; then
NODE="$DIR/node"
elif [ -x "$(command -v "$XDG_DATA_HOME/oclif/node/node-20.10.0")" ]; then
NODE="$XDG_DATA_HOME/oclif/node/node-20.10.0"
elif [ -x "$(command -v node)" ]; then
NODE=node
else
echoerr 'Error: node is not installed.' >&2
exit 1
fi
if [ "$DEBUG" == "" ]; then
echoerr SF_BINPATH="$SF_BINPATH" "$NODE" "$DIR/run" "$@"
fi
"$NODE" "$DIR/run" "$@"
fi`
What the command is showing as output is precisely what is in the last line of the code. But I can't understand why the execution of the command is getting to that line.
Anyone can help here?
Thanks a lot.

Hi again @iowillhoit @cristiand391,
I found the problem.
The problem was not in the image or the sf cli, the problem was in docker engine in MAC. There is a bug in Docker engine for mac. There are some issues with the "Virtualization Framework". I had it enabled by default. I had to change the file sharing implementation for containers and uncheck the Virtualization Framework. After that, it worked perfectly.

Thank you very much for the help and sorry for the inconvenience due to it wasn't an "sf cli" problem.
You can close the issue.


Fix small typo in README

Looks like ref to local accidentally made it's way through during latest README edits.

cool, thanks!


Fix the CI!

Observed behaviour
CI tests are currently failing on test_check_vertical_metrics_regressions in tests/profiles/googlefonts_test.py
Expected behaviour
CI tests should pass so we have confidence about new PRs.
Resources and exact process needed to replicate
More interesting question is why it is failing. test_check_vertical_metrics_regressions runs a test "with a remote family which does not have typo metrics enabled and the fonts being checked don't take this fact into consideration". In this case, the test family has the typo metrics bit set and the remote family (Cabin) does not:
>>> typo_metrics_enabled(gf_font)
False

gf_has_typo_metrics is False and fam_has_typo_metrics is True, so we pick up the expected ascender from usWinAscent:
https://github.com/googlefonts/fontbakery/blob/9bbf2da4947b7e5ce82c06a8ce7b484185ddac67/Lib/fontbakery/profiles/googlefonts.py#L4444-L4450
gf_font['OS/2'].usWinAscent * upm_scale (for Cabin Regular) is 1150:
>>> ttFonts[0]['head'].unitsPerEm
1000
>>> gf_font['head'].unitsPerEm
2000
>>> upm_scale
0.5
>>> gf_font['OS/2'].usWinAscent
2300
>>> gf_font['OS/2'].usWinAscent * upm_scale
1150.0

However, our test has set the ascender to 1139:
https://github.com/googlefonts/fontbakery/blob/9bbf2da4947b7e5ce82c06a8ce7b484185ddac67/tests/profiles/googlefonts_test.py#L3386-L3387
Hence the test fails.
I guess the fix is to change the test font's ascender to 1150? But I am not really aware of the subtleties of what is going on here.

@simoncozens thanks for catching this. I'm guessing this check is failing because we recently updated Cabin on Google Fonts with a new VF. I reckon this update has typo metrics enabled.

By recently I mean a few hours ago.
Perhaps a better option for this test is to create a mock of the remote_styles  instead of sending a network request.

yes, I noticed that yesterday at night while working on a branch. I simply commented out a portion of the code-test, which is a dirty work around. Would you be able to make a better fix for that, @m4rc1e? (I'm asking you because this check was originally implemented by you, if I recall correctly)

Even if the update has typo metrics enabled, note that we explicitly disable them in the tests:
https://github.com/googlefonts/fontbakery/blob/master/tests/profiles/googlefonts_test.py#L3377-L3378
It's not that; it's just that the metrics really are different.


[US] - Create self-hosted runner

As a
Developer
I want
a runner to perform GitHub Actions on our own VM
so that
I can run CI/CD on our VM

@mikk5829 It requires owners privileges of the repo to do this. Is it possible to have multiple owners of the repo?


HOSTEDCP-1110: [backport-4.13] Allow HCP Specification to Support ICSP & IDMS

What this PR does / why we need it:
Allow HCP Specification to Support ICSP & IDMS. IDMS is replacing ICSP
in OCP 4.13+. hcp.Spec.ImageContentSources was updated in OCPBUGS-11939
to replace ICSP with IDMS; however, HCP needs to support both ICSP &
IDMS. Note, OpenShift clusters can only have either ICSP CRs or IDMS
CRs; clusters cannot utilize both CR types at the same time.
Which issue(s) this PR fixes:
Fixes HOSTEDCP-1110
Checklist

[x] Subject and description added to both, commit and PR.
[x] Relevant issues have been referenced.

This is a backport of #2720. The auto cherrypick didn't work primarily because #2368 wasn't backported and #2642 hasn't merged yet.

/test e2e-aws

/approve


Add noise to reduce banding of scanlines CRT effect

I had to zoom in a bit (old eyes!) to see the difference, but it looks good. I'll get this merged - thank you.


"Disable Quick Access as default view in Explorer" causes "Explorer.EXE Unknown Error"

"Disable Quick Access as default view in Explorer? y/n: " with "LaunchTo = 0" setting causes "Explorer.EXE Unknown Error" in Windows 10 x64 1709

same for me.


The noctua model meta index in GOlr needs to contain the actual models

Currently, after figuring out what models we want, we have no way to get the JSON out of GOlr without repetition--models are saved in every item in metadata/model-ann-config.yaml, and not at all in metadata/noctua-model-meta-config.yaml.
The shortest path here would be to add the field and let epione get it out of the newer models it possible. Longer term, we'll need to make sure that the pipeline provides these, possibly by loading another document type (will talk with @hdietze).
We'll need this to help drive external displays simply and without repetition.

Besides a schema change, the bulk of the work here will happen in geneontology/noctua.

Before closure, I've promised to update: https://github.com/geneontology/noctua-repl/blob/master/scripts/find-models-by-gene.js

As a step towards this model ID information has been added to the JSON in geneontology/minerva#37.

I'll need to touch all noctua models before this can be completely cleared.


Author-names extend beyond pdf bounds (docx works fine)

Hi,
I am having the issue of author names extending beyond the bounds of the respective pdf output. This is the command I use: pandoc --lua-filter=./lua/scholarly-metadata.lua --lua-filter=./lua/author-info-blocks.lua --filter pandoc-citeproc title.md studyarea.md references.md -s -o manuscript.pdf
Output to docx and html work just fine. Is there any easy solution to this? Or is it related to the default.latex template?

Thank you for the report. This is indeed a problem with one of the filters. I'll take a look.

The list of authors is passed to LaTeX as a single author, which causes the problem.  Could you try to replace the following lines close to the end of author-info-blocks.lua
      meta.author = pandoc.MetaInlines(
        create_authors_inlines(doc.meta.author, mark)
      )

with
      meta.author = pandoc.MetaList(
        List:new(doc.meta.author):map(author_inline_generator(mark))
      )

This should lets LaTeX do the actual author rendering. I got better results this way.
I forgot why the filter works the way it does right now. It's probably for consistency across formats. If the above works for you, then we could change the filter to use the above method when the output is LaTeX.

This works as expected, thank you. :)


[Dropzone] Missing documentation

There's missing documentation to do pretty much anything, like how to configure some more advanced things, like upload progress etc.
Is there any such documentation planned? And can someone point me in the right direction regarding accessing the underlying js dropzone instance?

The problem is that the Dropzone component is poorly named :/. It actually has nothing to do with the Dropzone JavaScript library, which admit is a bummer :/. The Dropzone component in its current form is just a "stylized area where you can drop files" and then, with a tiny bit of js, see a preview after dropping. It's nice, but I think many/most people see this component and expect it to be an integration with Dropzone.js... which is confusing and disappointing.
We need to make it VERY clear what Dropzone is & isn't. And, honestly, I haven't thought about it much, but we should perhaps add true Dropzone.js support (or some similar library).


incorporate changes made to the backport of #4143 in #4144 back to main

incorporate changes made to the backport of #4143 in #4144 back to main #4186

@randyridge can you update the branch?

/AzurePipelines run


Schema validation github action

Add a github action workflow to validate schema files in the schemas directory using the simtool simtools-validate-schema-files
This workflow makes use of the simtools-prod containers.
(might fail until #11 has been merged)

It failed, very good! (https://github.com/gammasim/workflows/actions/runs/5900822194/job/16005825866?pr=13)
This means it definitely works if the schema is not correct.

Works now after merging of #11.


why cannot compile

Hi, author. I cannot compile your file using pdflatex or xelatex under texlive 2021.
Is there something wrong, or I must have missed it.
Could you please give me some help?

I successfully compile the file under texlive 2022.
However, it took so much time, even unacceptable!!!

If you are writing your document in Chinese, then it is preferable to install the following open-source fonts:

The Source Han font series (思源字体) at Adobe Fonts. More specifically:

Source Han Serif, go to its Release page.
Source Han Sans, go to its Release page.
Source Han Mono, go to its Release page.

It is recommended to download the Super-OTC version, so that the total download size would be smaller, and the installation would be easier.

Without these fonts, the compilation would still passing, but the system shall spend (quite) some time verifying that the fonts are indeed missing and only then switch to the fallback fonts.
Feel free to continue the discussion here or open a new issue page if you encounter any further problem. Also, it is OK to write in Chinese if it is more convenient for you, I am certainly much more fluent with Chinese than English or French.


Lapse in react-redux/docs/api.md

In areStatesEqual function example says parameters are prev as first and next as second what is wrong. The true is new state is first, and old state is second function parameter.

Thanks!


Update CharacterTypeHandler.java

this is a basic error, the condition statement miss the [String !=""] condition in if(...);
in this case, i execute the select sql statement, and the resultType include a property -- Character type, when the DataBase return a "", Mybatis will throw a Exception: index out of range, becasue the array's length is 0 in the statement -- "return columnValue.charAt(0);"

@harawata
Could you tell me why ? As my opinion, (columnValue != "" ) is completely with (columnValue.Empty() ) when column is not null

@harawata
Could you tell me why ?
As my opinion, (columnValue != "" ) is completely same as (columnValue.Empty() ) when column is not null

columnValue != "" is not the right comparison. Please use columnValue.isEmpty().

Yes, You are right. If the columnValue = new String(), then ( columnValue == "" ) will return false,
can use { !columnValue.isEmpty() } or { s.equals("")) } to replace it ;

Coverage increased (+0.009%) to 87.256% when pulling 71bc47eb14cc2a00d8bc71801a132299a8c1cb12 on mrsun002:mrsun002-fixTheCharacterTypeHandler into 0133e377e140811a12518e3b34c447d2d6d890ba on mybatis:master.

Thank you, @mrsun002 !


fix(trello): optimize render for slow networks

Please remember the Contributing Guidelines :heart:
:star2: What does this PR do?
This PR improves the TogglButton render on Trello even in slow networks.
It does still happen sometimes that the button does not appear but only in very slow networks and with the 'Disable Cache' from the dev tools checked (which is not going to be the case 99% of the time).
Tested with network throttling at 3G speed.
:bug: Recommendations for testing
All changes should be tested across Chrome and Firefox.
Ensure that the button is working.
:memo: Links to relevant issues or information
See the slack thread here.

May be use the mutation observer if its flaky
You can pass comma spperated selectors as last argument to render function
So it will rerender button when for example description is rendered


fix(dashboard): show_native_filters leftover

SUMMARY

https://github.com/apache/superset/pull/23228 removed show_native_filters from dashboards, but it can still be present in exports from older versions. When the key is present, the dashboard is imported correctly, but can't be updated because the schema of json_metadata is now invalid.
This PR addresses the problem by removing the field on dashboard import. Additionally, for those dashboards that have already been imported with the field, it relaxes the metadata schema to allow updates when show_native_filters is present, removing it before processing the metadata.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

[ ] Has associated issue:
[ ] Required feature flags:
[ ] Changes UI
[ ] Includes DB Migration (follow approval process in SIP-59)

[ ] Migration is atomic, supports rollback & is backwards-compatible
[ ] Confirm DB migration upgrade and downgrade tested
[ ] Runtime estimates and downtime expectations provided

[ ] Introduces new feature or API
[ ] Removes existing feature or API

@betodealmeida alternatively, could we bump the export version and create a new import version?


Add a section in the README file indicating how to compile and deploy the OpenNetty daemon

OpenNetty has a built-in Windows service host/systemd daemon that can be deployed as a standalone .NET application to act as an OpenWebNet/MQTT gateway:
https://github.com/opennetty/opennetty-core/blob/92712cc788d1b1ecf587f8d79f015240da013885/src/OpenNetty.Daemon/Program.cs#L1-L25
We'll need to update the README.md file to include instructions on how to compile it and deploy it on a Linux box.

Done: https://github.com/opennetty/opennetty-core/commit/8cfaaab9816dc90c8303100c01b3eb57978b44e3.


For the 20 trial columns, produce a script that tries to identify groupings of ids and potentially the canonically correct id for each group.

We can either do this programmatically or   by finding a secondary column that we can use to identify the groups that exists on one of the member datasets. So for example school names can probably be grouped and identified by BBL or something similar which should be cleaner

Closing stale issues as part of task triage and preparing for a new roadmap


What is the right resolution time period for audio testing?

From today's DPCTF Test Runner meeting: What is the right resolution time period for audio testing?  That is, given 60 seconds of audio, what is the length of the sub-segments we need to examine?  We previously concluded "on the order of 20mS"; that is, step through the recorded audio at 20mS intervals, making sure each one was in the correct position (presentationTime).
Currently the DPCTF spec says "audio sample", and a reasonable reading of that is ISO BMFF sample (section 3.1.9, "all the data associated with a single timestamp"), and typically the audio samples are 20mS.  OK, currently the spec requires 20mS.
So the question is not, "How long is a sample?"  The question now is, "What is the right resolution time, and why?"  If 20mS is required, then the DPCTF spec is fine as written and we'll have to stay with wired audio (most likely, still some study underway).  Or, if we can verify the important stuff with a longer resolution, like 2S, then we should change the DPCTF spec language and build our tests accordingly.
For example--if we're interested in seeing that CMAF segments play out in order, then 20mS is overkill.  If we need to verify ISO BMFF audio samples, as the spec is currently written, then it's not overkill.
The motivation for asking this is, 20mS resolution on automated audio testing is “hard” (maybe not feasible) for playout over a speaker and pickup with microphone and ambient noise or music.  If we can justify closer to 2 seconds resolution, we are closer to a realizable test rig.  If we stay at 20mS resolution, that appears only feasible with wired audio.

After some discussion in DPCTF and off-line, I'm of the opinion we need to stay on 20mS until we cannot support a required test environment.  If speakers/mic/music/room noise really is not feasible at 20mS, we can reassess.  Recommend closing this issue and continuing with the current path of developing 20mS wired-only tests first, and continuing to study opportunities for speaker/mic/music/noise.

After some discussion in DPCTF and off-line, I'm of the opinion we need to stay on 20mS until we cannot support a required test environment. If speakers/mic/music/room noise really is not feasible at 20mS, we can reassess. Recommend closing this issue and continuing with the current path of developing 20mS wired-only tests first, and continuing to study opportunities for speaker/mic/music/noise.

I agree.


Fix last_active to not count verification markers

When an account gets verified or blocked, that action is logged in the activity. But last healthy shouldn't count this because then every time you verify or block an account, it will be considered active even if the account hasn't been active for a long time.

Fixed with latest commit.


Missing coloring in .vue files

Extensions: BracketPair and Vetur.

Open Vue file, reload. Coloring works properly:

Focus another file, e.g. plain javascript, reload. Wait 2 seconds, switch to Vue file. The color in all vue files is missing!

So in order to have bracket pair colorizer work in .vue files, you need to have one of them focussed upon application start. Is it using the wrong hook? Is this Vetur's fault?
also see #15. Not related to #97, because that issue is about HTML, this is about the JS part.

It's probably my fault, thanks for reporting I'll look into it
On Fri, 13 Apr 2018, 3:47 PM Philip Waritschlager<EMAIL_ADDRESS>wrote:

Extensions: BracketPair and Vetur.

Open Vue file, reload. Coloring works properly:
[image: colored]
https://camo.githubusercontent.com/20066563d538c51111ab8b3f905361f8be6fd52e/68747470733a2f2f692e696d6775722e636f6d2f4d5166707961422e706e67
2.
Focus another file, e.g. plain javascript, reload. Wait 2 seconds,
switch to Vue file. The color in all vue files is missing!
[image: noncolored]
https://camo.githubusercontent.com/2aa4fdf9d3cf75bcc0f4032be01ae0cccb5add9d/68747470733a2f2f692e696d6775722e636f6d2f474b76484c34332e706e67
So in order to have bracket pair colorizer work in .vue files, you need to
have one of them focussed upon application start. Is it using the wrong
hook? Is this Vetur's fault?
also see #15 https://github.com/CoenraadS/BracketPair/issues/15. Not
related to #97 https://github.com/CoenraadS/BracketPair/issues/97,
because that issue is about HTML, this is about the JS part.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/CoenraadS/BracketPair/issues/108, or mute the thread
https://github.com/notifications/unsubscribe-auth/AFVa4VwygwtBgIvxA8m7FSQ7ierPmq2tks5toKxsgaJpZM4TTeoV
.

No, still there. (no idea where your comment went)

Would be great to see this extension working in Vue script blocks!

Basic

Vue is now supported in v2: https://marketplace.visualstudio.com/items?itemName=CoenraadS.bracket-pair-colorizer-2


Python2.X and Python3.X compatible changes

As part of the continuous effort to seamlessly make the automation work. There are python codes library used in the test needs to be compatible with 3.x
The changes are on those.

https://gerrit.openbmc-project.xyz/#/c/openbmc/openbmc-test-automation/+/11736/


Steam won't launch

After I deleted the zip file in the skins folder ( I assumed I had to make one since I didn't originally have a skins folder ), Steam won't launch. It only shows this:

and it doesn't launch after. I've checked if it was already open in task manager, but it wasn't.

fixed it somehow


confirmation email was slow. question about crust/corteza

Hello!
Describe the bug
I can't register at the community instance https://latest.cortezaproject.org
To Reproduce
https://latest.cortezaproject.org
create account
wait for confirmation email
Expected behavior
Get the confirmation email :smile:
Additional
I didn't find a comparison page between crust github project and corteza. I see that crust is archived but is it the same features?
I'm looking for a low code platform for CRM but also be able to build simple PWA apps easily.
Thank you and have a great day!
:smile_cat:

BTW, by mistake when changing url, I found all namespaces on demo: https://latest.cortezaproject.org/compose/namespaces

Hi @j2l,
Thanks for informing us. I did a test and I can confirm that it takes long for the confirmation email to arrive. 5 minutes in my case. We'll look what we can do to improve this on the community server.
And to answer your additional question: indeed Crust is archived. All development is done in Corteza. So, I would suggest you use Corteza for your CRM and other apps.

Thanks @lenny-horstink !
All features are the same in the archived crust project and corteza?

Corteza has all the features from the archived Crust project, and a lot more :)

Ah, great! Thanks!


Merge families of separate Roman and Italic variable fonts

Would it be cool to be able to preview these together?

Closing and referring to issue #14


[ENHANCEMENT] Decouple performance analyzer process from Opensearch

Currently the opensearch docker container runs two process, opensearch and performance analyzer. See https://github.com/opensearch-project/opensearch-build/blob/main/docker/release/config/opensearch/opensearch-docker-entrypoint.sh#L108-L112.
While this may work for us but as per the guidelines of docker official image project the recommendation is to have only one process per container, see https://github.com/docker-library/official-images#init.
While we will be going ahead and creating a PR on docker official images repo with the current setup, creating this issue to track this improvement.

This would also reduce the memory footprint and startup times, which would be useful for running tests. On Github Actions we get every now and then an issue where the containers don't start and the culprit seems to always be OpenSearch.
It'd be great if the inclusion of the performance analyzer were controlled by a variable similar to DISABLE_SECURITY_PLUGIN. https://github.com/opensearch-project/docker-images/blob/e42b2cf0f9e7665a66d503f1e3cbd8ffae22e784/2.x/bin/opensearch-onetime-setup.sh#L39

I think this issue was fixed in #9  as now there is such an option
https://github.com/opensearch-project/docker-images/blob/main/2.x/bin/opensearch-docker-entrypoint.sh#L57

Close this issue.
As this has already been fixed.
We are currently not using this repo for docker images.
Here is the latest setup on docker for OpenSearch/Dashboards:
https://github.com/opensearch-project/opensearch-build/tree/main/docker
Thanks.


Fix Grafana Dashboard

It replaces the metric names like: http_server_duration to http_server_duration_seconds.
This means that the Dashboard won't work with the OTEL direct export until the metrics renaming isn't fixed behind the OTEL endpoint.
It works with the Prometheus Exporter and the Grafana Agent collecting and forwarding.

The test that failed is a flaky test, I saw it myself yesterday too, failed 1 time in about 4 runs when I was trying to get the integration tests to pass. I think we can merge without worrying about it and tackle it later.


Usability update: better feedback on successful/pending deposit flow.

[x] button back to check rewards. possibly a dupe here: https://github.com/vegaprotocol/token-frontend/issues/425
[x] show/hide pending stake based on state #410
[ ] New design for the block that shows a market+reward

[ ] show / hide details
[ ] include link to the sushi analytics page in title
[x] always use the secondary button style
[x] some sort of epoch detail (could be text instead of bar)
[x] include units (VEGA or SLP) for each applicable row
[ ] APY and Incentive reward in one row
[ ] 5 different states, connect, you have 0 SLP, you have some SLP but it isn't staked, you have a pending stake, You have an active stake
[ ] @campbellssource can update copy on all labels

Closing as SLP is finished and doesn't look like it's coming back


refactor(role): code refactor

This is an attempt at a fix for #1795

I think now it's easy to find changes.


Check automaticRadius type in search response is string

A user of the Go client reported
on support that they had issue while the Go client was deserializing the
automaticRadius field of a geo search query.
The Algolia documentation says
the type of automaticRadius is a string but, as of today, the written type
annotation is marked to float.
Let's make sure that this field is correctly typed as a string (and not a
float), as it should.
For the record, to make automaticRadius in a search response, you need to
perform a search query with:

with a geo parameter such as aroundLatLng
without any aroundRadius search parameter
have records in your index that will match the geo query, so they need to
have a _geoloc attribute

All good there;
https://github.com/algolia/algoliasearch-client-java-2/blob/febbaeafd7fbdee4affc9856a4601947a1bd1443/algoliasearch-core/src/main/java/com/algolia/search/models/indexing/SearchResult.java#L124


remove code for destatis and use standalone package instead

https://pypi.org/project/de-destatis/
Is now available as a standalone package. Include it as an optional extra to avoid out of date code.

Merged over different branch


AzureRM not supported on self-hosted agent in Version 5

Hello,
i had a quick glance at the code of the task in github and it seems that AzureRM is not supported for self-hosted agents in V5 any more. The remarks / troubleshooting page is misleading in this case.
Regards,
Holger
Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 5de2083f-ba71-fce1-ec99-91ee90d0d001
Version Independent ID: 5de2083f-ba71-fce1-ec99-91ee90d0d001
Content: AzurePowerShell@5 - Azure PowerShell v5 task
Content Source: task-reference/azure-powershell-v5.md
Service: azure-devops-pipelines
Sub-service: azure-devops-pipelines-tasks
GitHub Login: @steved0x
Microsoft Alias: sdanie

@impact79 -- Holger, thank you for your close reading.
@steved0x -- Steve, please look into this issue.

Thank you for your feedback. We are migrating this issue to our new documentation feedback system, and closing this issue.
As we phase out GitHub issues for this repository, we encourage you to propose changes using public PRs or submit feedback through our updated control at the top of the page. For more information on our feedback systems, see https://aka.ms/contentuserfeedback.


Matrix Agent

Can be emulated using the Post Agent:
{
  "post_url": "https://matrix-client.matrix.org/_matrix/client/r0/rooms/{% credential matrix_room_id %}/send/m.room.message/{{txnid}}",
  "expected_receive_period_in_days": "1",
  "content_type": "json",
  "method": "put",
  "payload": {
    "msgtype": "m.notice",
    "body": "{{content}}"
  },
  "headers": {
    "Authorization": "Bearer {% credential matrix_auth_token %}"
  },
  "emit_events": "false",
  "no_merge": "false",
  "output_mode": "clean"
}

But could be much improved to just take a room id, mxid, token and message (maybe msgtype, but m.notice is recommended for automation). And should generate a unique txnid (is there something that could be used instead?)

#2866


Can't use with Xcode 7 beta2

Module file was created by an older version of compiler.How can i do?

And I use xcode convert tolastswiftsynctax ,but it also havs many bug

Closing as a dupe of https://github.com/stephencelis/SQLite.swift/issues/133.


add bootstrap icons via blueprint

see e.g. https://blog.getbootstrap.com/2020/12/11/bootstrap-icons-1-2-0/

this is mostly to try out local / static resources to be delivered so that the CDN approach is optional.
See e.g. how https://github.com/WolfgangFahl/play-chess-with-a-webcam/blob/master/scripts/install needed an elaborate script to download all necessary web parts locally.  http://ptp.bitplan.com and http://diagrams.bitplan.com simply copied the web structure of these project. Putting things into blue prints seem to be the way to go to be more modular and have a better component structure.

http://q.bitplan.com:8234/bootstrapicons fails:
TypeError: The view function for 'getIcon' did not return a valid response. The function either returned None or ended without a return statement.
<IP_ADDRESS> - - [15/Jan/2022 08:47:06] "GET /favicon.ico HTTP/1.1" 404 -
<IP_ADDRESS> - - [15/Jan/2022 08:47:06] "GET /assets/img/index.html HTTP/1.1


Version bump for release

Codecov Report

Merging #90 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #90   +/-   ##
=======================================
  Coverage   98.61%   98.61%
=======================================
  Files          20       20
  Lines        1803     1803
=======================================
  Hits         1778     1778
  Misses         25       25

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cf587de...850f346. Read the comment docs.


[$250] [TS migration] Configure TS & Migrate CONST, fastMerge, Device, Logger to Typescript (expensify-common)

Typescript migration (expensify-common)
Make sure you read through our TypeScript's style guide before you start working on this migration issue.
Files
lib/CONST.jsx
lib/fastMerge.js
lib/Device.jsx
lib/Logger.jsx
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01a5172255327c6e67
Upwork Job ID:<PHONE_NUMBER>164871680
Last Price Increase: 2024-05-16

Issue OwnerCurrent Issue Owner: @blazejkustra

I got approval from @roryabraham to create this issue on #typescript-new-expensify channel here. Let's add it to Typescript project and change labels as this is not a bug, thanks!

I’m Błażej Kustra from Software Mansion, an expert agency, and I’d like to work on this issue 😄

@blazejkustra sounds good! Is the next step for you to raise a PR here?

yes, I think so

Dibs

@godofoutcasts94 this issue is already assigned. Only issues with the help wanted label are available. LMK if you have questions.

Oh sorry! My bad!

Hey there - saw this issue on Upwork, but after reviewing some of these comments I can't figure out if it's open to proposals or not.  I have started looking into the migration, but don't want to waste anyone's time...can someone let me know if this is available to work on or not?  Thanks in advance!

Contributor details
Your Expensify account email<EMAIL_ADDRESS>Upwork Profile Link: https://www.upwork.com/freelancers/~0133925c6cb76728cc

@s-no1ukno Issue is assigned already and being worked on, see this comment.

Does that mean this doesn't need to be deployed?

The code change was made in expensify-common (a set of javascript libs shared between OldDot and NewDot). It won't take effect until we upgrade expensify-common in E/App, and that PR is deployed.

Sounds good. TY!

Update: https://github.com/Expensify/App/pull/42387 was just merged 🚀

woohoo 🚀

PR is on staging

No regression test needed for TS migration

Only payment here is $125 to @abdulrahuman5196 for C+ review via Upwork.

@abdulrahuman5196 just sent you an offer for $125!

There may be a possible regression here too. @roryabraham @abdulrahuman5196 could you please confirm if this was indeed a regression?

I'm about to go OOO until 2024-06-25. Adding another BZ assignee to handle payment next week. We just need to:

Determine whether this was a regression.
Issue payment after the waiting period.

I'll take this back once I return (if it's still open)!

Bump on https://github.com/Expensify/App/issues/42245#issuecomment-2168648439 @roryabraham @abdulrahuman5196 - thank you!

@bfitzexpensify I don't think this is a direct regression but a combined issue due to efforts from different PR.
But feel free to correct me if wrong.

Thanks for confirming @abdulrahuman5196. Paid out, we're all done here.


Thanks for getting this going

Hey so FYI I pulled this and I'm starting to tinker with it a bit as well. I'm just learning about the coding and everything but let me know if I can help with anything.

You should have a working light now.  Still a bit to do though...


[UI] Improved the Footer. 🚀

This is the updated UI of the footer section.

✔And one important thing is to make the footer common for easy use.

Issue no. #13

Footer is not available, kindly check it once.
Website shows that "The page could not be found NOT_FOUND".

Footer is not available, kindly check it once.
Website shows that "The page could not be found NOT_FOUND".

It is there. Please double-check it. I ran the project locally before creating a PR. Can you share the image where the issue occurs?

Footer is not available, kindly check it once.
Website shows that "The page could not be found NOT_FOUND".

It is there. Please double-check it. I ran the project locally before creating a PR. Can you share the image where the issue occurs?

It is showing error.
https://github.com/user-attachments/assets/479b62b7-da65-495f-950c-789e18074903

your PR has conflicts that need to be addressed. Please review and resolve any issues. After resolving them, you can proceed to create a pull request. It is essential to resolve these conflicts in the branch.

look the issue

@yatulearn what does this check do? "Vercel Preview Comments — ⚠ Unresolved feedback"

your PR has conflicts that need to be addressed. Please review and resolve any issues. After resolving them, you can proceed to create a pull request. It is essential to resolve these conflicts in the branch.

What it this check about? "Vercel Preview Comments — ⚠ Unresolved feedback" @yatulearn

kindly fix the home, about, notes section

@yatulearn, I have resolved all conflicts. Please review and let me know if any changes are needed.

your pr has conflicts kindly resolve them

@yatulearn, Any update on this issue? Also, can you tell me why the "Vercel Preview Comments — ⚠ Unresolved feedback" check is failing consistently?


Build system for LSST simstream

From Goal 4 in Cycle-7

14/DEC/22

as said by @RoyWilliams  this is same as MS19

once MS19 passed this can be closed.


Missing Windows Store support for UWP publishing

We are using Xamarin for mobile app development. Xamarin supports Android, iOS and UWP.  We are submitting app in stores but Windows is missing.
Because there is no native integration with Windows Store, I'm trying to find some workaround to to extend pipeline to publish to Windows Store.

@jjindrich thanks for the request! We'd like to support App Center releases to the Windows store but this isn't currently on our immediate roadmap. I will monitor this thread for community support and post updates here.

For me this would be the single most important feature of the platform. Being able to automatically publish releases to the "public" stores. Part of every build/release lifecycle should be a way to automatically publish a nightly build to a beta store (or whatever) so that those can be tested by the user base.
After that I don't mind to have a single manual step to promote a specific package to the "Production" state, but without this, you're still managing everything manually.

Would be useful also the ability to publish to the Business Store and support the package flights system of the Windows Store

@winnieli1 any status update on this? This would be very nice, giving us one place to go for all our apps.

Any updates on this @winnie or @Oddj0b ? I just posted a very similar issue #1422. Also, I would be happy to meet to discuss my use case with either or both of you. I tried clicking on your calendar link above but it did not have any openings.

Is this considered in the roadmap somewhere?
I wonder if it makes sense to invest into using the Microsoft store publishing or if this will be abandoned like UWP more or less is when Microsoft products themselves do not support it. Does not express much confidence into the own platform :-/
Is there an alternate solution?
Would be nice to get a hint whether it is worth to wait for it :-) or to build an own solution :-(

This feature must be implemented, you support App Store and Google Play but not your own store?

Its your own store !
Its your platform !
Pls. implement this feature !!!

This is very needed considering that windows is taking app developers serious again, any update on this?

It shouldn't be stale, it should be added to a future release ;-)

This is still an issue and it would be great if you could add it to your roadmap

Looks like MS cares not about Windows Store. Why?..

Community - add your votes. This issue is blatantly ignored by Microsoft.

Community - add your votes. This issue is blatantly ignored by Microsoft.
Seems so..

@winnie Could you please add this to the backlog or clearly state that this is considered out-of-scope for App Center so that we can give up hope?

and please reopen - it was closed by the bot despite there was activity

This feature will clearly never be implemented for UWP or WinUI, it seems that this project is in maintenance mode.

@asierpn that is my impression as well.
I saw an announcement previously where the devs said 'we do a feature stop to overhaul the internals and then continue with development' which would be a temporary 'maintenance mode', but I am also missing some kind of feedback what is going to happen after the overhaul - so your suspicion that they will never leave that phase is quite a high probability


[google_maps_flutter] Google maps overlay

I would like to display an image in overlay at given lat-log positions on Google map using Flutter. I am using flutter package google_maps_flutter: ^2.2.1, at present the package does not provide to implement the feature .

@tuandq2711
Can you elaborate on the use case you are trying to achieve and current limitation you are facing ?

@darshankawar
Currently on android or ios there is a Ground Overlays section to be able to draw images on the map. But on google_maps_flutter I don't see any to use. I can't add that part by myself so I hope you guys can help me add it.

Closing this as duplicate of https://github.com/flutter/flutter/issues/26479. Please follow-up in it for further updates.


roc format doesn't add spaces around ? in optional record field

You can see the bad formatting that it allows here: https://github.com/roc-lang/roc/blob/856f0516199bbc30bd204f216705d47c3e557385/crates/compiler/builtins/roc/Dict.roc#L240
Essentially, this: { seed ?U64 } should be { seed ? U64 }
I have not worked on the formatter, but I would assume this should be a pretty simple fix.

I'd like to work on this if possible.

Sounds great. Feel free to ask questions on the contributing thread on zulip in a new topic or via questions here.


Development related to Sprint-4

Development Related to User Stories(For Sprint-4),
ESA-2165,
ESA-2154,
ESA-2170,
ESA-2150,
ESA-2168,
ESA-2072,
ESA-2171,
ESA-2172.

@cgijeffolsen, As a update, we have pushed the changes related to de-activate account validation rule.
CC: @avikghoshMOH, @vasanthid23


AD DLL missing from latest version of Az.Accounts

The latest version of Az.Accounts doesn't have Microsoft.IdentityModel.Clients.ActiveDirectory.dll and Microsoft.IdentityModel.Clients.ActiveDirectory.Platform.dll.
We need to get rid of these adal libraries for getting the authorization token.
Example: 2.2.4 doesn't have them.
However, older ones 1.9.4 has those dll files.
Error while running current script with KEK encryption:
At line:29 char:79

... ccounts$(((dir ${env:userprofile}\Documents\WindowsPowerShell\Module ...

            ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

CategoryInfo          : ObjectNotFound: (C:\Users\m10564...les\Az.Accounts:String) [Get-ChildItem], ItemNotFoundException
FullyQualifiedErrorId : PathNotFound,Microsoft.PowerShell.Commands.GetChildItemCommand

dir : Cannot find path 'C:\Users\m1056436\Documents\WindowsPowerShell\Modules\Az.Accounts' because it does not exist.
At line:30 char:85

... ccounts$(((dir ${env:userprofile}\Documents\WindowsPowerShell\Module ...

            ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

CategoryInfo          : ObjectNotFound: (C:\Users\m10564...les\Az.Accounts:String) [Get-ChildItem], ItemNotFoundException
FullyQualifiedErrorId : PathNotFound,Microsoft.PowerShell.Commands.GetChildItemCommand

Exception calling "LoadFrom" with "1" argument(s): "Could not load file or assembly
'file:///C:\Users\m1056436\Documents\WindowsPowerShell\Modules\Az.Accounts\PreloadAssemblies\Microsoft.IdentityModel.Clients.ActiveDirectory.dll' or one of
its dependencies. The system cannot find the file specified."
++++++++++++++++++
Invoke-RestMethod : {"error":{"code":"Unauthorized","message":"Request is missing a Bearer or PoP token."}}
At line:76 char:11

$result = Invoke-RestMethod -Method POST -Uri $unwrapKeyRequestUrl -H ...

      ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

CategoryInfo          : InvalidOperation: (System.Net.HttpWebRequest:HttpWebRequest) [Invoke-RestMethod], WebException
FullyQualifiedErrorId : WebCmdletWebResponseException,Microsoft.PowerShell.Commands.InvokeRestMethodCommand
You cannot call a method on a null-valued expression.

++++++++++++++++++
Also, even this "https://gist.github.com/vermashi/7f3544a911cf0ed75d6b32b562b77237#file-retreiveencryptionsecretviaurl-ps1" fails.
$authResult = $authContext.AcquireToken($resourceAppIdURI, $clientId, $redirectUri, "Auto")
The AquireToken method is no longer available.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 72043177-4ad8-7261-ba13-3d7b14c76a14
Version Independent ID: a9ee0e02-325d-256e-4f20-18df23962002
Content: Troubleshooting BitLocker boot errors on an Azure VM - Virtual Machines
Content Source: support/azure/virtual-machines/troubleshoot-bitlocker-boot-error.md
Service: virtual-machines
GitHub Login: @genlin
Microsoft Alias: genli

@chakra146  Thank you for the feedback. You are right. The ADAL Assemblies used in the script are not available in the latest version of azure PowerShell. I will update the script. Thanks again for helping to improve the document.

@chakra146 The steps about about how to install the az.acocunt 1.9.4 were added into the article . We will provide the new script when it is available. Thanks for your suggestions!


Fix Small Typo

From

to proceed invoking F2 without for activity completion.

to

to proceed invoking F2 without waiting for activity completion.

@juvtib : Thanks for your contribution! The author(s) have been notified to review your proposed change.

#label:"aq-pr-triaged"

#sign-off

No problem. I'm glad it was helpful.


feat(imagecard): add hotspot data loading indicator

Summary

feat(ImageCard): adds a hotspot data loading message to the card (and prop) to show when hotspot data is loading

Change List (commits, features, bugs, etc)

fix(Card): also fixes the table card to pass iconDescription for the Expand and Close icons

Acceptance Test (how to verify the PR)

test the new hotspot data loading indicator story

:tada: This PR is included in version 2.5.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Add ZonedDateTime type support

Version: (e.g. 1.2.1)
Module: (e.g. quill-async-postgres)
Database: (e.g. postgresql-9.6.2)
Expected behavior
I think we shall add ZonedDateTime type support for quill, at least for PostgreSQL. Both ZonedDateTime and PostgreSQL timestamp with time zone support ISO 8601 calendar system and should integrate smoothly.
ZonedDateTime is default java 8 type and more recent comparing to org.joda.time.DateTime. I found some comparison of these time libraries in general. There is only one caveat I could find - is about performance, but it's uncertain how it's relevant
We can completely change org.joda.time.DateTime to ZonedDateTime or add conversion similar to how it's done with UUIDObjectEncoding
Also there is quote from offical site

Note that from Java SE 8 onwards, users are asked to migrate to java.time (JSR-310) - a core part of the JDK which replaces this project

@getquill/maintainers

Here is the quick and dirty mapper we are using @likern if you haven't already handled this:
implicit val encodeZonedDateTime = MappedEncoding[ZonedDateTime, Date](z => Date.from(z.toInstant))
implicit val decodeZonedDateTime = MappedEncoding[Date, ZonedDateTime]( d => d.toInstant.atZone(ZoneOffset.UTC))

@kentongray I handled this. But I think it should be supplied out of the box. No reason to do this in every third-party project. Standard types of PostgreSQL should "just works" and be mapped to standard Java date time.


Align TagHelperOutputExtensionsTest.CaseSensitiveTagHelperAttributeComparer with Razor.Runtime version

was missing Minimized comparison

FYI only; quick fix that @NTaylorMullen and I discussed offline

260ac29


added some comments

I am new to contributing and I am also willing to add Russian or Ukrainian translation for your beautiful readme file

thanks Yurii, I think this change in the readme would be pretty cool if possible

I would be happy to do it ;)
ср, 23 серп. 2023 р. о 03:06 Anderson Porto @.***> пише:

thanks Yurii, I think this change in the readme would be pretty cool if
possible
—
Reply to this email directly, view it on GitHub
https://github.com/andersonhsporto/ft-so_long/pull/10#issuecomment-1689114775,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ANIKUUTNXSQS2XGHOUULF6TXWVJQ3ANCNFSM6AAAAAA32EIL74
.
You are receiving this because you authored the thread.Message ID:
@.***>


large amount of console scrollback causes significant slowdown

once the console reaches the hundreds or thousands of lines range, it starts to cause significant frame drop. try setting a limit on how large the scrollback can be

can also compute how many lines need to be drawn and only draw that many

with fe3a2b9d25092d5dd6b0d72ae3ad535eea5c95ac, old lines are now deleted from the console scrollback, resolving this issue


Support Bitcoing trading

Do you have plans to support bitcoin trading?

We do not currently have plans to support trading currencies or crypto currencies. It is an interesting feature; however it is not on our current roadmap.

What would be the best way to right connectors for bitcoin exchanges on Zipline live trading modules?

May I ask again the same question? Some time has passed by and this issue is now even more relevant IMHO. I stumble upon this repo 1, which could be helpful.
Disclaimer: I am totally new to zipline and quantopian.


Script execution outputs real-time logs to the front end

  We were using linkis, front end to submit a script execution, can only wait for tasks to view the log information, and through the log interface to get the log does not contain the detailed information in the process of execution, execution of the script users can't through the log analysis the cause of the failure, only through the back-end engine service in the log to see the error information.
  What can I do to get real-time logs and detailed error logs in real time?

Hello, this is to reduce unnecessary logs for the user. When the task fails, only the logs of the ERROR level are pushed. You can modify the push level by modifying log4j2


Add USE_STATIC_MSVC_RUNTIME cmake option instead of always using statically-linked runtime library

This pull request corrects for an issue introduced in 877364f0509c9a54f2d7015a6a9b52b4c7c99edc which caused anything dynamically linking against cubeb to fail to compile via MSVC due to a mismatched RuntimeLibrary value. There was no clean way to fix this issue in the dependent project due to there being no cmake configuration option to prevent this value from being set.
The pull request fixes this by adding a new USE_STATIC_MSVC_RUNTIME option which, when enabled, sets CMAKE_MSVC_RUNTIME_LIBRARY to MultiThreaded$<$<CONFIG:Debug>:Debug>.
If the option is not set, CMAKE_MSVC_RUNTIME_LIBRARY will be left at its default value, which as per the cmake documentation is MultiThreaded$<$<CONFIG:Debug>:Debug>DLL.

Thanks for the patch!