Remove minified check

Fixes https://github.com/reduxjs/redux/issues/4443
Thanks for the PR!
To better assist you, please select the type of PR you want to create.
Click the "Preview" tab above, and click on the link for the PR type:

:bug: Bug fix or new feature
:memo: Documentation Fix
:book: New/Updated Documentation Content

Thanks for the fix! When could we expect this to be released?

redoing


Feat/withdrawals reciept view

Closes #135
https://github.com/vegaprotocol/vegawallet-browser/assets/26136207/4eeab7ae-6403-4e51-82f8-d3ba18cf70b9
AC:
The view contains the necessary data enrichment to provide
Amount (with correctly formatted position decimals)
From Key
To Ethereum key

Issue here that the asset name is being chopped by the scrollbar. Can we fix?


[DNS] Tag keys are capitalized when creating a zone

Suppose I create a zone:
az network dns zone create -g rg1 -n test.cli --tags a="b c" d="ef" -o list
The output looks like this:
Etag                      : 00000003-0000-0000-6ac4-15cad777d201
Id                        : /subscriptions/.../resourceGroups/rg1/providers/Microsoft.Network/dnszones/test.cli
Location                  : global
Max Number Of Record Sets : 5000
Name                      : test.cli
Number Of Record Sets     : 2
Resource Group            : rg1
Type                      : Microsoft.Network/dnszones
Name Servers              :
   ns1-06.azure-dns.com.
   ns2-06.azure-dns.net.
   ns3-06.azure-dns.org.
   ns4-06.azure-dns.info.
Tags                      :
   A : b c
   D : ef

Somehow, the key of each tag has been capitalized (a -> A, d -> D).  That shouldn't happen.
I saw the on DNS zone create. Obviously, when fixing, you need to look more broadly (DNS zone updates, DNS record set create/updates, other resources types, etc.

On further investigation, this may be an issue with the -o list output. The tag key shows as lower case if I use JSON output. Still needs to be fixed though.

See #1883. If the list output survives, we will fix this.


Task 18,19,20,21,22,23,24,25

Name           Value

FilePath       D:\Uipath\GitSpace\RPA-Developer-in-30-Days\SourceCode\2023\August2023\Swapna\Task 18\Main.xaml
Description    Variable Dt_Table doesn't have DataTable prefix.
ErrorSeverity  Warning
Recommendation DataTable Variable should start with a dt_ prefix. Learn more.
ErrorCode      ST-NMG-009
Item           f9f5050c-50f1-45e3-9ca8-0dea8dc9c13f
FilePath       project.json
Description    Expand to see details
ErrorSeverity  Info
Recommendation Project workflow count:...
ErrorCode      ST-ANA-003
Item           93f0759a-9fce-470e-b9ef-72d57665363d
FilePath
Description    Dependency package UiPath.Testing.Activities is not used.
ErrorSeverity  Warning
Recommendation Remove unused packages in order to improve process execution time. Learn more.
ErrorCode      ST-USG-010
Item           4461e02d-44f6-49b0-b103-2c8a09ce0bc5
FilePath
Description    Your organization requires your project to have an Automation Hub URL defined.
ErrorSeverity  Warning
Recommendation Use "Project Settings" to add the missing information. Learn more.
ErrorCode      ST-USG-034
Item           3d13264e-b132-42ed-a94a-4b7d90182254
FilePath       D:\Uipath\GitSpace\RPA-Developer-in-30-Days\SourceCode\2023\August2023\Swapna\Task 18\Main.xaml
Description    Expand to see details
ErrorSeverity  Info
Recommendation Activities: 8
ErrorCode      ST-ANA-009
Item           2d0caba8-4447-4d44-b415-166c1b18b665
FilePath
Description    Workflow Main.xaml does not have any assigned Test Cases.
ErrorSeverity  Info
Recommendation Creating Test Cases for your workflows allows you to run them frequently to discover potential issues early on before they are introduced in your production envir...
ErrorCode      TA-DBP-002
Item           672c0f8d-35a8-4a70-b831-5fdb064620fa
FilePath
Description    Dependency package UiPath.UIAutomation.Activities is not used.
ErrorSeverity  Warning
Recommendation Remove unused packages in order to improve process execution time. Learn more.
ErrorCode      ST-USG-010
Item           12c38563-751f-47fe-9f84-d5b8a3c4a3e6
FilePath       D:\Uipath\GitSpace\RPA-Developer-in-30-Days\SourceCode\2023\August2023\Swapna\Task 18\Main.xaml
Description    Log Message not used in workflow Main.
ErrorSeverity  Warning
Recommendation Using Log Message activities is important both during development and after release. They help understanding the flow path which is very useful for maintenance an...
ErrorCode      ST-USG-020
Item           cd16d223-ef52-4971-a7d8-38424cb870d3
FilePath       D:\Uipath\GitSpace\RPA-Developer-in-30-Days\SourceCode\2023\August2023\Swapna\Task 18\Main.xaml
Description    Variable Data_Row does not respect the set pattern ^(dt_)?([A-Z]|[a-z])+([0-9])$
ErrorSeverity  Warning
Recommendation Make sure all the variables follow the naming convention. Learn more.
ErrorCode      ST-NMG-001
Item           cd47708c-2445-4d68-9ddf-a00f17cc5716
FilePath       D:\Uipath\GitSpace\RPA-Developer-in-30-Days\SourceCode\2023\August2023\Swapna\Task 18\Main.xaml
Description    Variable Dt_Table does not respect the set pattern ^(dt_)?([A-Z]|[a-z])+([0-9])$
ErrorSeverity  Warning
Recommendation Make sure all the variables follow the naming convention. Learn more.
ErrorCode      ST-NMG-001
Item           2cf312b4-fce4-4c73-b2b8-64ae38d17382
FilePath
Description    Dependency package UiPath.Mail.Activities is not used.
ErrorSeverity  Warning
Recommendation Remove unused packages in order to improve process execution time. Learn more.
ErrorCode      ST-USG-010
Item           287aa89f-c563-4d0a-8a27-e8602aafa4ac
FilePath       D:\Uipath\GitSpace\RPA-Developer-in-30-Days\SourceCode\2023\August2023\Swapna\Task 18\Main.xaml
Description    Variable Output is not used.
ErrorSeverity  Warning
Recommendation Remove variables that are not used. Learn more.
ErrorCode      ST-USG-009
Item           caf3b409-9d2a-479d-b5fa-00b6a11d5ec3

Name           Value

FilePath       D:\Uipath\GitSpace\RPA-Developer-in-30-Days\SourceCode\2023\August2023\Swapna\Task 18\Main.xaml
Description    Log Message not used in workflow Main.
ErrorSeverity  Warning
Recommendation Using Log Message activities is important both during development and after release. They help understanding the flow path which is very useful for maintenance an...
ErrorCode      ST-USG-020
Item           ecc349bd-8023-4c59-96e3-ad78cf7acba1
FilePath
Description
ErrorSeverity
Recommendation
ErrorCode
Item
FilePath
Description    Dependency package UiPath.Testing.Activities is not used.
ErrorSeverity  Warning
Recommendation Remove unused packages in order to improve process execution time. Learn more.
ErrorCode      ST-USG-010
Item           8efae48d-88b9-4d28-ba6a-a8c049d2c4c6
FilePath
Description
ErrorSeverity
Recommendation
ErrorCode
Item
FilePath
Description    Dependency package UiPath.UIAutomation.Activities is not used.
ErrorSeverity  Warning
Recommendation Remove unused packages in order to improve process execution time. Learn more.
ErrorCode      ST-USG-010
Item           2825dc0d-8137-49fa-a4bd-237f79350874
FilePath
Description
ErrorSeverity
Recommendation
ErrorCode
Item
FilePath       D:\Uipath\GitSpace\RPA-Developer-in-30-Days\SourceCode\2023\August2023\Swapna\Task 18\Main.xaml
Description    Variable Data_Row does not respect the set pattern ^(dt_)?([A-Z]|[a-z])+([0-9])$
ErrorSeverity  Warning
Recommendation Make sure all the variables follow the naming convention. Learn more.
ErrorCode      ST-NMG-001
Item           16b043d4-14d4-42e8-bd5f-cdb9c06c62d5
FilePath
Description
ErrorSeverity
Recommendation
ErrorCode
Item
FilePath
Description    Workflow Main.xaml does not have any assigned Test Cases.
ErrorSeverity  Info
Recommendation Creating Test Cases for your workflows allows you to run them frequently to discover potential issues early on before they are introduced in your production envir...
ErrorCode      TA-DBP-002
Item           aeab55ed-e7ca-4747-9624-8bb87b90565b
FilePath
Description
ErrorSeverity
Recommendation
ErrorCode
Item
FilePath       D:\Uipath\GitSpace\RPA-Developer-in-30-Days\SourceCode\2023\August2023\Swapna\Task 18\Main.xaml
Description    Variable Dt_Table doesn't have DataTable prefix.
ErrorSeverity  Warning
Recommendation DataTable Variable should start with a dt_ prefix. Learn more.
ErrorCode      ST-NMG-009
Item           22ea73f8-3c18-4ef8-8881-3b8ab0c5dbd1
FilePath
Description
ErrorSeverity
Recommendation
ErrorCode
Item
FilePath       D:\Uipath\GitSpace\RPA-Developer-in-30-Days\SourceCode\2023\August2023\Swapna\Task 18\Main.xaml
Description    Variable Output is not used.
ErrorSeverity  Warning
Recommendation Remove variables that are not used. Learn more.
ErrorCode      ST-USG-009
Item           87521051-1f02-456c-b311-608ed187742b
FilePath
Description
ErrorSeverity
Recommendation
ErrorCode
Item
FilePath       D:\Uipath\GitSpace\RPA-Developer-in-30-Days\SourceCode\2023\August2023\Swapna\Task 18\Main.xaml
Description    Variable Dt_Table does not respect the set pattern ^(dt_)?([A-Z]|[a-z])+([0-9])$
ErrorSeverity  Warning
Recommendation Make sure all the variables follow the naming convention. Learn more.
ErrorCode      ST-NMG-001
Item           9e852f58-e03e-45d2-8803-929657791c38
FilePath
Description
ErrorSeverity
Recommendation
ErrorCode
Item
FilePath       D:\Uipath\GitSpace\RPA-Developer-in-30-Days\SourceCode\2023\August2023\Swapna\Task 18\Main.xaml
Description    Expand to see details
ErrorSeverity  Info
Recommendation Activities: 8
ErrorCode      ST-ANA-009
Item           9ff5002e-6120-48b5-9db1-84d8e321b021
FilePath
Description
ErrorSeverity
Recommendation
ErrorCode
Item
FilePath
Description    Your organization requires your project to have an Automation Hub URL defined.
ErrorSeverity  Warning
Recommendation Use "Project Settings" to add the missing information. Learn more.
ErrorCode      ST-USG-034
Item           dc4d6584-3cc5-4897-91a5-65bc298cff28
FilePath
Description
ErrorSeverity
Recommendation
ErrorCode
Item
FilePath
Description    Dependency package UiPath.Mail.Activities is not used.
ErrorSeverity  Warning
Recommendation Remove unused packages in order to improve process execution time. Learn more.
ErrorCode      ST-USG-010
Item           0ee425ff-fa89-4882-b189-826954d92df8
FilePath
Description
ErrorSeverity
Recommendation
ErrorCode
Item
FilePath       project.json
Description    Expand to see details
ErrorSeverity  Info
Recommendation Project workflow count:...
ErrorCode      ST-ANA-003
Item           42cd171b-c19b-4a7a-a6f9-970c3449b395
FilePath
Description
ErrorSeverity
Recommendation
ErrorCode
Item

Name           Value

FilePath       project.json
Description    Expand to see details
ErrorSeverity  Info
Recommendation Project workflow count:...
ErrorCode      ST-ANA-003
Item           13ce36f0-79ad-48da-a77e-6fd028bd4ccb
FilePath
Description
ErrorSeverity
Recommendation
ErrorCode
Item
FilePath       D:\Uipath\GitSpace\RPA-Developer-in-30-Days\SourceCode\2023\August2023\Swapna\Task 19\Main.xaml
Description    Expand to see details
ErrorSeverity  Info
Recommendation Activities: 4
ErrorCode      ST-ANA-009
Item           88303703-f6f0-4567-9858-3c47e7ec69f8
FilePath
Description
ErrorSeverity
Recommendation
ErrorCode
Item
FilePath
Description    Dependency package UiPath.Mail.Activities is not used.
ErrorSeverity  Warning
Recommendation Remove unused packages in order to improve process execution time. Learn more.
ErrorCode      ST-USG-010
Item           ffe2f8ea-ca54-45b6-8a2b-eba91ccaa9d9
FilePath
Description
ErrorSeverity
Recommendation
ErrorCode
Item
FilePath
Description    Workflow Main.xaml does not have any assigned Test Cases.
ErrorSeverity  Info
Recommendation Creating Test Cases for your workflows allows you to run them frequently to discover potential issues early on before they are introduced in your production envir...
ErrorCode      TA-DBP-002
Item           aed0cfbb-6720-4e04-b2c5-de165715954f
FilePath
Description
ErrorSeverity
Recommendation
ErrorCode
Item
FilePath
Description    Your organization requires your project to have an Automation Hub URL defined.
ErrorSeverity  Warning
Recommendation Use "Project Settings" to add the missing information. Learn more.
ErrorCode      ST-USG-034
Item           ca14ea33-947b-4195-8fe6-57afcf2869f3
FilePath
Description
ErrorSeverity
Recommendation
ErrorCode
Item
FilePath       D:\Uipath\GitSpace\RPA-Developer-in-30-Days\SourceCode\2023\August2023\Swapna\Task 19\Main.xaml
Description    Log Message not used in workflow Main.
ErrorSeverity  Warning
Recommendation Using Log Message activities is important both during development and after release. They help understanding the flow path which is very useful for maintenance an...
ErrorCode      ST-USG-020
Item           b2a7944f-43ee-4c66-b95f-2fd9039e6796
FilePath
Description
ErrorSeverity
Recommendation
ErrorCode
Item
FilePath
Description    Dependency package UiPath.Excel.Activities is not used.
ErrorSeverity  Warning
Recommendation Remove unused packages in order to improve process execution time. Learn more.
ErrorCode      ST-USG-010
Item           b636528b-98d5-4363-a950-a7b15a3b06c2
FilePath
Description
ErrorSeverity
Recommendation
ErrorCode
Item

Name           Value

FilePath       D:\Uipath\GitSpace\RPA-Developer-in-30-Days\SourceCode\2023\August2023\Swapna\Task 20\Main.xaml
Description    Variable DT_Data doesn't have DataTable prefix.
ErrorSeverity  Warning
Recommendation DataTable Variable should start with a dt_ prefix. Learn more.
ErrorCode      ST-NMG-009
Item           77f03e10-9d67-4743-b176-82a0d1ca8c5c
FilePath
Description
ErrorSeverity
Recommendation
ErrorCode
Item
FilePath
Description    Your organization requires your project to have an Automation Hub URL defined.
ErrorSeverity  Warning
Recommendation Use "Project Settings" to add the missing information. Learn more.
ErrorCode      ST-USG-034
Item           e3db7177-9462-4a28-82e1-b2fc61b29441
FilePath
Description
ErrorSeverity
Recommendation
ErrorCode
Item
FilePath
Description    Workflow Main.xaml does not have any assigned Test Cases.
ErrorSeverity  Info
Recommendation Creating Test Cases for your workflows allows you to run them frequently to discover potential issues early on before they are introduced in your production envir...
ErrorCode      TA-DBP-002
Item           aed8d08a-21f0-4675-9080-eff7a39fcbab
FilePath
Description
ErrorSeverity
Recommendation
ErrorCode
Item
FilePath
Description    Dependency package UiPath.Mail.Activities is not used.
ErrorSeverity  Warning
Recommendation Remove unused packages in order to improve process execution time. Learn more.
ErrorCode      ST-USG-010
Item           0458690e-abfe-48ef-9663-74cd42e332a8
FilePath
Description
ErrorSeverity
Recommendation
ErrorCode
Item
FilePath       D:\Uipath\GitSpace\RPA-Developer-in-30-Days\SourceCode\2023\August2023\Swapna\Task 20\Main.xaml
Description    Expand to see details
ErrorSeverity  Info
Recommendation Activities: 10
ErrorCode      ST-ANA-009
Item           a141309a-22b9-4141-ba3c-cd36030c0f19
FilePath
Description
ErrorSeverity
Recommendation
ErrorCode
Item
FilePath       project.json
Description    Expand to see details
ErrorSeverity  Info
Recommendation Project workflow count:...
ErrorCode      ST-ANA-003
Item           ce737b87-f909-46cd-9b80-8e0c7d372d88
FilePath
Description
ErrorSeverity
Recommendation
ErrorCode
Item
FilePath
Description    Dependency package UiPath.Testing.Activities is not used.
ErrorSeverity  Warning
Recommendation Remove unused packages in order to improve process execution time. Learn more.
ErrorCode      ST-USG-010
Item           20215985-0cff-4c77-904d-ce874053f78c
FilePath
Description
ErrorSeverity
Recommendation
ErrorCode
Item
FilePath       D:\Uipath\GitSpace\RPA-Developer-in-30-Days\SourceCode\2023\August2023\Swapna\Task 20\Main.xaml
Description    Variable DT_Data does not respect the set pattern ^(dt_)?([A-Z]|[a-z])+([0-9])*$
ErrorSeverity  Warning
Recommendation Make sure all the variables follow the naming convention. Learn more.
ErrorCode      ST-NMG-001
Item           b01c7533-10fd-43df-8d04-c2a9b7174795
FilePath
Description
ErrorSeverity
Recommendation
ErrorCode
Item

Name             Value

FilePath         D:\Uipath\GitSpace\RPA-Developer-in-30-Days\SourceCode\2023\August2023\Swapna\Task 18\Main.xaml
Description      Variable Data_Row does not respect the set pattern ^(dt_)?([A-Z]|[a-z])+([0-9])*$
ErrorSeverity    Warning
Recommendation   Make sure all the variables follow the naming convention. Learn more.
ErrorCode        ST-NMG-001
Item             dc7ba292-6fd2-40e4-957d-1f391f20af61

FilePath
Description      Dependency package UiPath.UIAutomation.Activities is not used.
ErrorSeverity    Warning
Recommendation   Remove unused packages in order to improve process execution time. Learn more.
ErrorCode        ST-USG-010
Item             73551df4-3f99-469e-a15f-06375c2b0bef

FilePath         D:\Uipath\GitSpace\RPA-Developer-in-30-Days\SourceCode\2023\August2023\Swapna\Task 18\Main.xaml
Description      Variable Dt_Table does not respect the set pattern ^(dt_)?([A-Z]|[a-z])+([0-9])*$
ErrorSeverity    Warning
Recommendation   Make sure all the variables follow the naming convention. Learn more.
ErrorCode        ST-NMG-001
Item             64e51052-6690-4106-93d2-1d1166122131

FilePath
Description      Dependency package UiPath.Mail.Activities is not used.
ErrorSeverity    Warning
Recommendation   Remove unused packages in order to improve process execution time. Learn more.
ErrorCode        ST-USG-010
Item             31935f95-3f75-46eb-b3f8-3d81d0b75ea4

FilePath
Description      Your organization requires your project to have an Automation Hub URL defined.
ErrorSeverity    Warning
Recommendation   Use "Project Settings" to add the missing information. Learn more.
ErrorCode        ST-USG-034
Item             921f3d7b-908b-4b03-a3c0-57d718c03fdf

FilePath         D:\Uipath\GitSpace\RPA-Developer-in-30-Days\SourceCode\2023\August2023\Swapna\Task 18\Main.xaml
Description      Variable Dt_Table doesn't have DataTable prefix.
ErrorSeverity    Warning
Recommendation   DataTable Variable should start with a dt_ prefix. Learn more.
ErrorCode        ST-NMG-009
Item             80d82a4d-b909-4ec7-afac-5bc50ff1d237

FilePath         D:\Uipath\GitSpace\RPA-Developer-in-30-Days\SourceCode\2023\August2023\Swapna\Task 18\Main.xaml
Description      Log Message not used in workflow Main.
ErrorSeverity    Warning
Recommendation   Using Log Message activities is important both during development and after release. They help understanding the flow path which is very useful for maintenance ...
ErrorCode        ST-USG-020
Item             76b7c672-87e4-4fca-a5ad-a363ba492ab9

FilePath
Description      Dependency package UiPath.Testing.Activities is not used.
ErrorSeverity    Warning
Recommendation   Remove unused packages in order to improve process execution time. Learn more.
ErrorCode        ST-USG-010
Item             e8d1efb8-8468-4ca7-b80d-1c852c420ff5

FilePath         D:\Uipath\GitSpace\RPA-Developer-in-30-Days\SourceCode\2023\August2023\Swapna\Task 18\Main.xaml
Description      Variable Output is not used.
ErrorSeverity    Warning
Recommendation   Remove variables that are not used. Learn more.
ErrorCode        ST-USG-009
Item             0985497c-d271-4ffd-8dfb-a78726bbd460

FilePath         D:\Uipath\GitSpace\RPA-Developer-in-30-Days\SourceCode\2023\August2023\Swapna\Task 18\Main.xaml
Description      Expand to see details
ErrorSeverity    Info
Recommendation   Activities: 8
ErrorCode        ST-ANA-009
Item             44e5412d-3437-410f-a757-c4d7df35aec6

FilePath
Description      Workflow Main.xaml does not have any assigned Test Cases.
ErrorSeverity    Info
Recommendation   Creating Test Cases for your workflows allows you to run them frequently to discover potential issues early on before they are introduced in your production env...
ErrorCode        TA-DBP-002
Item             87571f2e-29cb-495d-b013-5904f29ba6cc

FilePath         project.json
Description      Expand to see details
ErrorSeverity    Info
Recommendation   Project workflow count:...
ErrorCode        ST-ANA-003
Item             0932939c-bc7a-468a-9eea-7defe505d509

Name             Value

FilePath
Description      Dependency package UiPath.Excel.Activities is not used.
ErrorSeverity    Warning
Recommendation   Remove unused packages in order to improve process execution time. Learn more.
ErrorCode        ST-USG-010
Item             5ec40d9b-0531-47ce-adcb-a1e263a0a0e5

FilePath
Description      Dependency package UiPath.Mail.Activities is not used.
ErrorSeverity    Warning
Recommendation   Remove unused packages in order to improve process execution time. Learn more.
ErrorCode        ST-USG-010
Item             d139113c-e611-484a-bbbd-80a70bc157aa

FilePath
Description      Your organization requires your project to have an Automation Hub URL defined.
ErrorSeverity    Warning
Recommendation   Use "Project Settings" to add the missing information. Learn more.
ErrorCode        ST-USG-034
Item             36af695a-aa57-4cea-9f3f-3c01b50eb480

FilePath         D:\Uipath\GitSpace\RPA-Developer-in-30-Days\SourceCode\2023\August2023\Swapna\Task 19\Main.xaml
Description      Expand to see details
ErrorSeverity    Info
Recommendation   Activities: 4
ErrorCode        ST-ANA-009
Item             a73fbf8c-5a95-423f-a464-edb8cae0de27

FilePath         D:\Uipath\GitSpace\RPA-Developer-in-30-Days\SourceCode\2023\August2023\Swapna\Task 19\Main.xaml
Description      Log Message not used in workflow Main.
ErrorSeverity    Warning
Recommendation   Using Log Message activities is important both during development and after release. They help understanding the flow path which is very useful for maintenance ...
ErrorCode        ST-USG-020
Item             a90c71e2-9827-4bfa-a3fc-06a4a0e0ec4e

FilePath
Description      Workflow Main.xaml does not have any assigned Test Cases.
ErrorSeverity    Info
Recommendation   Creating Test Cases for your workflows allows you to run them frequently to discover potential issues early on before they are introduced in your production env...
ErrorCode        TA-DBP-002
Item             41cf3340-98bd-401b-8f9c-ea3a9f4b3f6e

FilePath         project.json
Description      Expand to see details
ErrorSeverity    Info
Recommendation   Project workflow count:...
ErrorCode        ST-ANA-003
Item             a880e394-a4a4-4a60-9ec3-dcc0f8217f9d

Name             Value

FilePath
Description      Your organization requires your project to have an Automation Hub URL defined.
ErrorSeverity    Warning
Recommendation   Use "Project Settings" to add the missing information. Learn more.
ErrorCode        ST-USG-034
Item             4e40d719-9dd5-4d86-a0ae-3bfbbb369b08

FilePath         project.json
Description      Expand to see details
ErrorSeverity    Info
Recommendation   Project workflow count:...
ErrorCode        ST-ANA-003
Item             e6a72667-92c0-45dd-b0ff-916c442cf2c0

FilePath
Description      Dependency package UiPath.Mail.Activities is not used.
ErrorSeverity    Warning
Recommendation   Remove unused packages in order to improve process execution time. Learn more.
ErrorCode        ST-USG-010
Item             c1625d97-9b76-47a2-9dfe-fa65f67afa96

FilePath         D:\Uipath\GitSpace\RPA-Developer-in-30-Days\SourceCode\2023\August2023\Swapna\Task 20\Main.xaml
Description      Variable DT_Data doesn't have DataTable prefix.
ErrorSeverity    Warning
Recommendation   DataTable Variable should start with a dt_ prefix. Learn more.
ErrorCode        ST-NMG-009
Item             276c1d3f-27de-4c97-b287-862f0ba65011

FilePath         D:\Uipath\GitSpace\RPA-Developer-in-30-Days\SourceCode\2023\August2023\Swapna\Task 20\Main.xaml
Description      Variable DT_Data does not respect the set pattern ^(dt_)?([A-Z]|[a-z])+([0-9])*$
ErrorSeverity    Warning
Recommendation   Make sure all the variables follow the naming convention. Learn more.
ErrorCode        ST-NMG-001
Item             8a5f39af-6c07-4c31-9350-b3be43ff17bf

FilePath
Description      Dependency package UiPath.Testing.Activities is not used.
ErrorSeverity    Warning
Recommendation   Remove unused packages in order to improve process execution time. Learn more.
ErrorCode        ST-USG-010
Item             3f60d446-a805-4498-8633-144357a0550a

FilePath         D:\Uipath\GitSpace\RPA-Developer-in-30-Days\SourceCode\2023\August2023\Swapna\Task 20\Main.xaml
Description      Expand to see details
ErrorSeverity    Info
Recommendation   Activities: 10
ErrorCode        ST-ANA-009
Item             515a083c-5913-4dff-a3a9-428d5618b916

FilePath
Description      Workflow Main.xaml does not have any assigned Test Cases.
ErrorSeverity    Info
Recommendation   Creating Test Cases for your workflows allows you to run them frequently to discover potential issues early on before they are introduced in your production env...
ErrorCode        TA-DBP-002
Item             dba5f167-0f73-4bc3-8a6e-84744153e07c

Task 18,19,20 All working good

@SwapnaThiagarajan
Task18: Changes Verified
Task19: Changes Verified
Task20: Changes Verified
Task21: Changes Verified. Default activity names

Task22: Changes Verified. Default activity names.

Task23: Changes Verified
Task24: Changes Verified. Default activity names

Task25: You have extracted the URL instead of Title

Task26: Changes Verified


Superfluous entry

Already covered by .NOCREF, .XCREF.

Document details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 0546a6ea-c1c9-da23-6f37-e133a07fa94f
Version Independent ID: e6249052-b651-48a9-4234-8cc898e74620
Content: .XCREF
Content Source: docs/assembler/masm/dot-xcref.md
Product: visual-cpp
Technology: cpp-masm
GitHub Login: @corob-msft
Microsoft Alias: corob

@Player1UK thanks for the feedback! However, after considering pros and cons, the product team has decided that the entries should not be merged.


Don’t fetch local files on node

Check if running in Node and don’t use fetch locally.

This has been fixed for some time.


Only show progress bar if request is taking longer than 400 milliseconds

The timeout amount (in milliseconds) is easily changed by a variable on line 6. Closes #581.
cc @Thibaut @javan

@javan implemented this slightly differently in #608


fix(di): Fix asyncFactory when the bean is injected with @Inject on server

Closes: 1065

:tada: This PR is included in version 6.4.1 :tada:
The release is available on:

v6.4.1
GitHub release

Your semantic-release bot :package::rocket:


PowerMethod is too optimistic in using the symmetric version, causing failures for SIRF resamplers

PowerMethod has 2 implementations: "symmetric" uses A^n, while "asymmetric" uses (A'A)^n. The latter is slower of course. The following condition decides which one to use:
https://github.com/TomographicImaging/CIL/blob/45e0b235ac79efc03dc5cb46b8ddda9d16f6331b/Wrappers/Python/cil/optimisation/operators/Operator.py#L195-L196
This is not correct in my opinion. A simple example is the following matrix
A = {{0, 1}, {0, 0}}

This is a 1D translation of 1 entry going “up”. Note that A^2 = 0. Clearly, this matrix doesn’t satisfy the conditions for the power method to give the max singular value (i.e. it is not diagonalisable). Nevertheless, PowerMethod will attempt to use the "symmetric" version as the domain=range (ok, mathematically, the range is smaller than R^2, but we wouldn't take that into account).
I think, the symmetric version should only be applied if the matrix is indeed symmetric. However, I guess we have no way of checking if that is the case. I would therefore vote for always assuming that the matrix is asymmetric, i .e. always set symmetric=False. (I suppose we could let the user pass a symmetric flag, defaulting to False).
This was uncovered by @Letizia97 in the context of SIRF Resamplers, where repeated translations end-up with a zero image.

In this instance 'symmetric' isn't refereeing to the matrix, but that the domain and range have the same shape and geometry.
If these are the same instead of allocating additional memory the single buffer is used for both the direct and adjoint operations.
All that happens with symmetric as True is that each iteration the references to each container are switched.
https://github.com/TomographicImaging/CIL/blob/45e0b235ac79efc03dc5cb46b8ddda9d16f6331b/Wrappers/Python/cil/optimisation/operators/Operator.py#L223-L227

@gfardell I don't think that's true, as the call to adjoint sits in the else statement, but I haven't followed this very carefully. @Letizia97 did observe that disabling the "symmetric" version resolved a problem. Of course, that might be specific to a SIRF operator using a sirf.NiftiImage3D container (but I wouldn't know why)

@KrisThielemans you are right. I blame monday morning!

I suppose I don't understand well what the method is supposed to do. For what I read online adjoint is never used.
As far as I can understand, in the symmetric case the algorithm seems to assume (?) that $A^TAx_0=x_0$, which is what is done by swapping the pointers.
I have no idea how the algorithm should behave, and it seems to me that we determine the property symmetric of the operator just by the checking if domain and range spaces are the same. I'm no mathematician, but this doesn't seem to be sufficient to me.
I would agree with @KrisThielemans and make symmetric an input parameter, which would enable a user who knows what they are doing to force the behaviour.

I suppose I don't understand well what the method is supposed to do.

This is used to compute the norm of a linear operator. There are many matrix-norms around. CIL doesn't seem to specify which one is needed (which might be problematic) but as calculate_norm uses the power-method, I guess it's computing the "induced 2-norm" (I could be wrong!).
The power method tries to find the largest eigenvalue/vector of a matrix. It only works properly when the matrix is diagonalisable. Obviously, a non-square matrix isn't, so then the implementation goes to the "non-symmetric" case, where it essentially computes the norm of $A^*A$ and then takes the sqrt. ($A^*A$ is guaranteed to be diagonalisable). Put another way, the non-symmetric case can be computed in terms of the symmetric power-method for $A^*A$.

As far as I can understand, in the symmetric case the algorithm seems to assume (?) that $A^TAx_0=x_0$

In the symmetric case, in the limit for large $n$ you will find $A^{n+1} x_0 \approx \lambda A^n x_0$, and it will return $\lambda$ (i.e. $A^n x_0$ is an eigenvector with eigenvalue $\lambda$)

I would agree with @KrisThielemans and make symmetric an input parameter, which would enable a user who knows what they are doing to force the behaviour.

👍


Adding Slack integration

Added Slack support for TimeOff. Using @slack/client npm module. Added new Slack class based on the email original class. Same for template from email to slack message templates. Added migration to add slack_username field to Users table. Added unit test based on email unit test.

@Morthor thank you for PR.
That feature was asked many times.
I will have a look at the diff more carefully soon.

That's nice to know. Just tell me if anything is missing or needs to be improved.
Regards

I found an issue with importing employees from csv file. I'm currently fixing it and will commit + push soon.

I have a commit to fix/add titles to all the pages which are missing them. It's on top of these merges though. So once this is approved I can create a new PR.
https://github.com/Morthor/application/commit/f96c996b7dd4aa390ebf20533987316fc0a490e1

hi guys, this can be added now?

There are very likely some changes that vpp would like me to make, possibly regarding migrations/schema. I believe my original approach of using migrations was the correct one, but the original instructions for new installations don't mention running migrations so I modified the original schema. But in hindsight that seems like a bad idea for people who just want to update their current version.
I guess vpp is just too busy to review the MR.

Hi guys, sorry for staying silent in this  thread. I am little bit busy those days (for about next 6-7 days) and then I will have a look into this more thoroughly.
I really appreciate this pull request as this is how the app grows its functionality.
Thank you guys for all your input.
Sent from my iPhone

On 20 Apr 2018, at 11:03, Morthor<EMAIL_ADDRESS>wrote:
There are very likely some changes that vpp would like me to make, possibly regarding migrations/schema. I believe my original approach of using migrations was the correct one, but the original instructions for new installations don't mention running migrations so I modified the original schema. But in hindsight that seems like a bad idea for people who just want to update their current version.
I guess vpp is just too busy to review the MR.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the thread.

Beside slacks; I would love to see webhooks being integrated, which is useful for Slack, but for all other chat(bots) like rocket.chat as well. +1

I fully agree with @saschafoerster regarding the webhooks as it would open the gate for other third party system integration.

The PR is little bit outdated, but not much, just mechanical issues.
I would be happy to get it into.

I must confess I didn't remember this PR was open. It's been 4 years.

@Morthor , don't worry, I will use this PR as a base.
Conceptually it has all needed for the feature, it just requires some work to fit into the app.

Would it be also possible to incorporate the webhooks? We have a third party HR system, where we would like to forward the approved and rejected vacations. If there would be hooks, then we could create a simple hook consumer and forward/remove the needed records. That would be amazing!


GitHub actions experiment

Simplified CI

no matrix
less resource use
only one maven build
only one npm build
generic naming
simple cache

I think there are some things of merit here. Will reference for open discussion.

Coverage decreased (-27.9%) to 19.63% when pulling 05318240d97770122d652afc672b80d657d9663f on github-actions-experiment into 7b0aeadfc8d92d27b485ebf3e42327ef596043ea on master.

Coverage decreased (-27.9%) to 19.63% when pulling 05318240d97770122d652afc672b80d657d9663f on github-actions-experiment into 7b0aeadfc8d92d27b485ebf3e42327ef596043ea on master.


remember and recall last used (non-custom) profile

This pull requests enables remembering and recalling the last used non-custom profile.
The profile identifier is written into the local storage when it's activated.
The stored profile will be activated if found in local storage when the BRouter-web instance is initizialized.
Fixes #437.

Nice! Thanks @mjaschen for this nice improvement. Looks good to me, waiting for @nrenner before merging it though :)


Added screenshots on interface and exporting

I checked that it builds and pics show up nicely.
There's some weird stuff going on (propably mac thing): my picture paths get this '''{figure} img/ [U+200E] Jupyter_Pandas_demo.png character is VSCode that maybe should not be there. So a good idea to check whether that messes up something.

Looks good when previewed locally.

Thanks!


Research prior art, and see if there is a repo to fork and get started

Research previous implementations of similar concept, such as intercom, ...
Getting started: perhaps fork the FOAM reviews repo?

Benchmarking
• Intercom
• Front
• Freshworks
Should be noted that it's mostly the UI/UX of the chat pop up that we're looking at with the above offerings
Rough specs
• Pop up version, in-page chat box version
• Minimal design
• Can work in authorization contexts A-C
• Should / can there be context D - comment as anon? @michaelsena


Postback Persistent Menu Connection error

I am getting this connection error when I click on the postback call from the persistent menu, here is my menu code:
 setMenu(pageId) {
    this.setPersistentMenu({
      pageId: pageId,
      menu: [
            {
               "locale":"default",
               "composer_input_disabled":false,
               "call_to_actions":[
                  {
                    "title": "ℹ  Menu",
                    "type": "postback",
                    "payload": "MENU",
                  },
                  {
                    "title": '💬  Contact Us',
                    "type": "web_url",
                    "url": "https://m.me/jsapp",
                  },
               ]
             },
           ]
    }, (err, body) => {
      console.log("MENU " + JSON.stringify(err))
      console.log("MENU " + JSON.stringify(body))
    })
  }

At first it works fine but after a while it keeps sending me this error. Anybody else had this issue?

No error log.

@jsappme - This is not related to botly - this is on facebook end and is happening sometimes.


Invalid CPE generated on Debian packages with colon ("epoch") in version number

I tried to use the tool on Ubuntu and used the zlib1g package as a guinea pig.
distro2sbom --distro deb -p zlib1g --sbom cyclonedx --format json -o zlib1g.sbom.json

The resulting JSON file cannot be parsed with Dependency Track.
024-01-03 11:07:16,676 WARN [InternalAnalysisTask] An error occurred while parsing: cpe:2.3:a:canonical:zlib1g:1:1.2.11.dfsg-2ubuntu9.2:*:*:*:*:*:*:* - The CPE is invalid and will be discarded. Invalid CPE (too many components): cpe:2.3:a:canonical:zlib1g:1:1.2.11.dfsg-2ubuntu9.2:*:*:*:*:*:*:*

This warning disappears when removing the 1: prefix from the version used in the generated CPE entry.

A proper fix should probably escape the colon from the version in the CPE entry (if that is even possible).

@bombadil  Thanks for the comment. The version string is valid as CycloneDX does not constrain the characters to be included in the version specified for a component. However I can see the issue with a CPE string if the version string contains a ':' and agree that the : should be escaped.
According to the CycloneDX Validator, the generated SBOM is valid.


Update in-code docs for MethodEnum.kt

The MethodEnum is used to enumerate which methods are available through the TikiPlatformChannel. Each method needs documentation explaining what it does and where it is used. Doesn't need to add the details about its usage here. Just the explanation of what it is and the link for the documentation of the underlying method in SDK dart.

[ ] BUILD
[ ] ASSIGN_OWNERSHIP
[ ] GET_OWNERSHIP
[ ] MODIFY_CONSENT
[ ] GET_CONSENT
[ ] APPLY_CONSENT

oudated


[FEAT] Added Contributors page

#22
Created the contributor page as discussed

It's looking good, but It is not completed yet and I can't merge it.
Let's complete complete the whole design and then merge it.
What do you think?

@AliReza1083 As per our prior discussions I made the following changes,

Added the border on the contributor card and the border shadow in the light mode

Finished the twitter and github links for the contributors

reduced the job opacity to look more like the design


No exceptions when adding unconstrained properties. Fixes #409.

Sorry, messed up the merge, but this commit is on master now.


Enable Windows 7 support

I'm using VS2019 on WIN7 I just built the AtmosphereSample demo but once I start it and select a renderer it crashes, no matter which renderer I choose. it comes up with:

Unhandled exception at 0x000007FED4AF0667 (GraphicsEngineD3D11_64r.dll) in AtmosphereSample.exe: 0xC000001D: Illegal Instruction.

how do I get this fixed?
I have tried (in order):
all the different renderer options except D3D12 (DirectX12),
Rebuilding the solution,
retrying all render options except D3D12,
Running it with admin privs.

Hello! Not sure about Win7. Can you try to generate solution files for win8.1 SDK?
https://github.com/DiligentGraphics/DiligentEngine/blob/master/README.md#win32

i have generated all the files im trying to compile and run them but when i run them that happens

Can you try to build the debug configuration? There may be something useful in debug output.

the same thing is happening

And nothing in debug output? There should be at least something. It seems like the system can't find some all.

ill recompile everything with the defualt CMAKE configs just with d3d12 disabled

basically everything is uninitialized/undefined

Ah, I guess this is because the swap chain initialization requests an interface that is not supported on Win7. Did you try OpenGL or Vulkan mode? OpenGL especially

yes, I have and ill double check to make sure the drivers and any on system software is up to date and working.

wait nvm, I just have the drivers for Vulkan but it isn't actually supported by my graphics card

What about OpenGL? Does it work?

I'm still getting a version of OpenGL downloaded and making a demo program

Ok, at least something works, good.
D3D11 doesn't work because the engine requires an interface that is not supported on Windows 7. Will need to see if swap chain initialization can be implemented with older interfaces.
It is strange though that Vulkan doesn't work. Do you have the latest drivers?

I have an MSI R7 370, which doesn't support Vulkan sadly

So I have gone ahead and just upgraded to win 10, but you might as well see about adding support for win7 since a large amount of people are still on there

Closing this issue as Microsoft does not support Windows 7 anymore.


Support running/installing remote Swift packages as scripts

This change makes it possible to have Marathon run and install remote executable Swift packages as scripts. Since what Marathon does under the hood is basically just to generate Swift packages for script files, all that needed to be done to support this new feature is to check if a downloaded repository is indeed a package, and then just use it directly.
To test that this works, Marathon remotely installs and runs itself, from its repo (so meta!)
Resolves https://github.com/JohnSundell/Marathon/issues/120

@orta With this, you can just have Danger-Swift be a normal Swift package, and Marathon will be able to install it remotely (just like how it installs itself in the tests) 👍
Would also love @pixyzehn's thoughts on in 😄

With this patch to Danger: https://github.com/danger/danger-swift/commit/b7666b9cb0ba3b121a4f7765fdc42775d9d4d70a
I got it working:

👍

@orta Awesome! 🎉 Will update the README together with a Homebrew release later today 👍

@JohnSundell I just want to use Package.swift to check if a downloaded repository is indeed a package instead of main.swift if possible. Looks really good!

@pixyzehn my implementation does both 😄 Since nameOfPackage(in:) will throw if there's no Package.swift file, it should have all cases covered 👍

Oh wow, I hadn't seen this before I wrote Mint! If Marathon adds versioning it can remove the need for Mint.

:D - you should help out on on this PR which is the one that is a full integration test https://github.com/JohnSundell/Marathon/pull/127


Ruby implementation

This implementation is modeled on the Python reference implementation and the JavaScript implementation. The output is comparable for the example circuits from the JavaScript implementation.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.1 out of 2 committers have signed the CLA.:white_check_mark: spencerking:x: kenixerYou have signed the CLA already but the status is still pending? Let us recheck it.


Fix - Update Start a free trial on the Concierge DM header to be clickable

Details

Fixed Issues

$ https://github.com/Expensify/App/issues/51197
PROPOSAL: https://github.com/Expensify/App/issues/51197#issuecomment-2427502680
Tests

Open a new account
Check that the Start a free trial badge is present in concierge LHN
Open the concierge chat
Now on the header, verify that there is Start a free trial button
Press it and verify it navigates to subscription page

[x] Verify that no errors appear in the JS console

Offline tests

Same as above
QA Steps

Same as above

[x] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

https://github.com/user-attachments/assets/da2a23ea-a0db-4d43-be5a-ccba0f380c90

Android: mWeb Chrome

https://github.com/user-attachments/assets/0fc4093a-8fed-40f3-9f87-6190019c8599

iOS: Native

iOS: mWeb Safari

https://github.com/user-attachments/assets/864cdd57-043c-49c5-908f-b44c9deababa

MacOS: Chrome / Safari

https://github.com/user-attachments/assets/4b4208b8-13af-4d3c-a638-3938e254b592

MacOS: Desktop

https://github.com/user-attachments/assets/96d2710f-e8c1-448b-a7bc-bb11e35ca336

Reviewer Checklist

[x] I have verified the author checklist is complete (all boxes are checked off).
[x] I verified the correct issue is linked in the ### Fixed Issues section above
[x] I verified testing steps are clear and they cover the changes made in this PR

[x] I verified the steps for local testing are in the Tests section
[x] I verified the steps for Staging and/or Production testing are in the QA steps section
[x] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[x] I checked that screenshots or videos are included for tests on all platforms
[x] I included screenshots or videos for tests on all platforms
[x] I verified tests pass on all platforms & I tested again on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[x] I verified proper code patterns were followed (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I verified that this PR follows the guidelines as stated in the Review Guidelines
[x] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label and/or tagged @Expensify/design so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[x] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

https://github.com/user-attachments/assets/cceac204-091d-4e03-a72e-906802e9ad96

Android: mWeb Chrome

https://github.com/user-attachments/assets/65d87a17-809b-44b4-a9aa-1edd2f4c42d5

iOS: Native

https://github.com/user-attachments/assets/6849a7bb-74e9-47bd-a737-695871cfd526

iOS: mWeb Safari

https://github.com/user-attachments/assets/82054144-326e-4239-8dc8-462474e8d760

MacOS: Chrome / Safari

https://github.com/user-attachments/assets/381b0f9f-6282-42a3-9057-b39a2849acfd

MacOS: Desktop

https://github.com/user-attachments/assets/8e66695e-90b5-4edd-9b05-4ff799d9fb54

I also couldn't identify the cause of the 'Unit Test' Failing. @FitseTLT any ideas? Thanks.

Just want a review from a design perspective, once that's done, we're good to merge

Screenshots look good to me 👍

cc @Expensify/design for vizzy

@MariaHCD Looks like we’ve got the thumbs up from design—are we good to proceed?

Nice, we're good to merge!

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

Tested as well, looks great!


Issue with foreign characters

This may be an edge case, but perhaps worth considering for multilingual apps.
I occasionally have URLs to open that have unencoded Chinese characters in them, which when calling URLWithString will yield null. Passing this kind of URL to SafariViewController in this call -
[[SFSafariViewController alloc] initWithURL:url entersReaderIfAvailable:readerMode];
will cause an unhanded exception, and send no error message back to Cordova.
A possible solution might be this:
NSURL *url = [NSURL URLWithString:[urlString stringByAddingPercentEscapesUsingEncoding: NSUTF8StringEncoding]];
I'm not sure about side effects, so we might consider this as an additional option that we can pass in the JavaScript SafariViewController.show() method call. At the very least we might consider a null check on the NSURL *url variable

Interesting issue. I agree we should attempt having the plugin fix it, but would it be possible to encode the URL in JS before sending it to the plugin? Do you have an example of a troublesome URL perhaps?

In my limited experience with this, the encodeURI() function in JS will also encode URIs encoded in query parameters, resulting in double encoding which won't work. (Think auth redirects on some sites, or partner store networks - http://example.com/auth?next=http%3A%2F%2Fexample.com%2Fpage) Some quick Googling showed me that both JS and Objective C have about a thousand ways of doing this, but this particular Objective C method doesn't seem to do anything but encode the foreign characters. If you have a better way to do this, I very open to it.
Apologies for the strange/amusing link, but it's the only functioning example I have.
For what it's worth, I have forked the project and added a check on the NSURL cast url variable, returning an error to cordova if the URL provided is bad. Seems to work with some bad urls I gave it, and the above test case.

Thanks for the fork, I've integrated it through a pull request. That's a lot better than it was 👍
I'll keep this issue open so we can think about further enhancements. Perhaps try the stringByAddingPercentEscapesUsingEncoding in case the cast URL was nil, and fall back to the error handler in case it's still nil after trying that.

is there any update on this? I am facing the same issue.


If I use this method to monitor, I will not lose data ?

for event in client.eternal_watch('/nodes',recursive = True):
print event.action
If I use this method to monitor, I will not lose data ?
Of course, I tested the next, no loss of data .However, I still want to find you to confirm this .
Thanks U !

@rfyiamcool in theory, no, you're not going to lose data; however I would not rely on it as a replication method.


Default boot2docker machine is not reachable

I'm getting an error creating a new boot2docker machine on Arch x64. I've removed all Host-only networks but vboxnet0 from Virtualbox 5.1.2_OSE.
$ docker-machine create --driver virtualbox default
Running pre-create checks...
Creating machine...
(default) Copying /home/ghost/.docker/machine/cache/boot2docker.iso to /home/ghost/.docker/machine/machines/default/boot2docker.iso...
(default) Creating VirtualBox VM...
(default) Creating SSH key...
(default) Starting the VM...
(default) Check network to re-create if needed...
(default) Waiting for an IP...
Waiting for machine to be running, this may take a few minutes...
Detecting operating system of created instance...
Waiting for SSH to be available...
Detecting the provisioner...
Provisioning with boot2docker...
Copying certs to the local machine directory...
Copying certs to the remote machine...
Setting Docker configuration on the remote daemon...

This machine has been allocated an IP address, but Docker Machine could not
reach it successfully.

SSH for the machine should still work, but connecting to exposed ports, such as
the Docker daemon port (usually <ip>:2376), may not work properly.

You may need to add the route manually, or use another related workaround.

This could be due to a VPN, proxy, or host file configuration issue.

You also might want to clear any VirtualBox host only interfaces you are not using.
Checking connection to Docker...
Error creating machine: Error checking the host: Error checking and/or regenerating the certs: There was an error validating certificates for host "<IP_ADDRESS>:2376": dial tcp <IP_ADDRESS>:2376: i/o timeout
You can attempt to regenerate them using 'docker-machine regenerate-certs [name]'.
Be advised that this will trigger a Docker daemon restart which will stop running containers.

Some basic things. I can ssh into the machine.
$ docker-machine stop default
$ rm -rf ~/.docker
$ docker-machine --version
docker-machine version 0.8.1, build HEAD
$ docker --version
Docker version 1.12.1, build 23cf638
$ uname -a
Linux x220 4.7.1-1-ARCH #1 SMP PREEMPT Wed Aug 17 08:13:35 CEST 2016 x86_64 GNU/Linux
$ VBoxManage list hostonlyifs
Name:            vboxnet0
GUID:            786f6276-656e-4074-8000-0a0027000000
DHCP:            Disabled
IPAddress:       <IP_ADDRESS>
NetworkMask:     <IP_ADDRESS>
IPV6Address:
IPV6NetworkMaskPrefixLength: 0
HardwareAddress: 0a:00:27:00:00:00
MediumType:      Ethernet
Status:          Down
VBoxNetworkName: HostInterfaceNetworking-vboxnet0

$ docker-machine --debug create --driver virtualbox default output
$ docker-machine --debug regenerate-certs -f default output
$ ip addr show output

A reinstallation of both Virtualbox and Docker solved this.
# pacaur -R docker-machine docker-compose docker
# pacaur -S docker docker-machine net-tools
# pacaur -S virtualbox-host-modules-arch virtualbox
# modprobe vboxdrv
# modprobe vboxnetadp
# vboxreload

I have similarly issue, https://github.com/docker/machine/issues/2590


Panic-free read of IPC files

This PR safeguards the IPC interface from panicking or aborting (OOM) on invalid data.

All number casts (e.g. i32 to usize) and operations (e.g. *) are now protected to avoid overflow and thus trigger OOM
Many of the errors were converted to an enum for more clarity over what failed exactly
the sum of size of all IPC buffers can no longer be larger than the size of the file, thus protecting us from OOM attacks

Thanks @kristoff3r and @TethysSvensson for the quick fix and release of https://github.com/planus-org/planus/issues/99 !


Ceylon backend error: method invoked with incorrect number of arguments

This function:
{<Annot->ProgramElement>*} annotatedMembers<Annot, ProgramElement>(
    Class<OptionalAnnotation<Annot, ProgramElement>> annotType,
    Package pkg)
        given Annot satisfies OptionalAnnotation<Annot, ProgramElement>
        given ProgramElement satisfies NestableDeclaration {
    variable {<Annot->ProgramElement>*} results = {};
    for (element in pkg.annotatedMembers<ProgramElement,Annot>()) {
        assert(exists annotation = optionalAnnotation(annotType, element));
        results = results.follow(annotation->element);
    }
    return results;
}

And this annotation
final sealed annotation class SomeAnnotation()
        satisfies OptionalAnnotation<SomeAnnotation,FunctionDeclaration> {
}

Generates a backend error:
shared void backendError() {
    annotatedMembers(`SomeAnnotation`, `package`); //Ceylon backend error: method invoked with incorrect number of arguments; expected 4, found 0
    annotatedMembers(`SharedAnnotation`, `package`); //Compiles
}

Thanks for reporting.

I can reproduce this problem with just this one line of code:
annotatedMembers(`VariableAnnotation`, `package`);

Ouch!
The difference between VariableAnnotation and SharedAnnotation is that SharedAnnotation has a union-typed argument to the type parameter ProgramElement of OptionalAnnotation.

Alright, so the issue here is rooted in the fact that ProgramElement is (correctly, it seems to me, according to the rules, given that it occurs only contravariantly in the parameter list) assigned the inferred type Nothing.
This Nothing results in some sort of very complex interaction between type constraints that I still don't fully grok, and triggers the bug. But actually Nothing wasn't a useful type argument to begin with.
Supplying an explicit type argument fixes the code from a logical point of view, and avoids the bug:
annotatedMembers<SomeAnnotation,FunctionDeclaration>(`SomeAnnotation`, `package`);

I can also fix the code by introducing an intervening interface which redeclares ProgramElement asan invariant type:
interface MyOptionalAnnotation<Annot, ProgramElement>
        of Annot
        satisfies OptionalAnnotation<Annot,ProgramElement>
        given Annot satisfies MyOptionalAnnotation<Annot,ProgramElement>
        given ProgramElement satisfies Annotated {}

{<Annot->ProgramElement>*} annotatedMembers<Annot,ProgramElement>(
    Class<MyOptionalAnnotation<Annot,ProgramElement>> annotType,
    Package pkg)
        given Annot satisfies OptionalAnnotation<Annot, ProgramElement>
        given ProgramElement satisfies NestableDeclaration {
    variable {<Annot->ProgramElement>*} results = {};
    for (element in pkg.annotatedMembers<ProgramElement,Annot>()) {
        assert(exists annotation = optionalAnnotation(annotType, element));
        results = results.follow(annotation->element);
    }
    return results;
}

final sealed annotation class SomeAnnotation()
        satisfies MyOptionalAnnotation<SomeAnnotation,FunctionDeclaration> {
}


Ability to retrieve address in both formats cash and legacy via API #1590

Ability to retrieve address in both formats cash and legacy via API #1590

@dinesh-skyach what if currency doesn’t support cash address?

@ysv Yes, we need this validation too. Thanks


Player doesnt reconnect after track stuck

Actually when the player is manually disconnected, it doesnt reconnect by itself when play command is executed again after some time. And i made sure skip on error is set to true.
Expected- It should stop the player clear the queue on manually disconnect and then start over new queue when joined the channel again.

@mananchawla2005 Can you show me how you are handling the trackStuck event?

@mananchawla2005 Can you show me how you are handling the trackStuck event?

@mananchawla2005 Marking as Invalid due to a lack of information. Please open it again when you can provide an answer to the above question.


Modal Background Doesn't Cover All Elements

Describe the bug
When a modal appears, elements that are attached to the page appear on top of the modal's background.
To Reproduce
Steps to reproduce the behavior:

Create a Modal component that shows/hides with background
Add additional ToastMesssage, Cards, Tooltip components to page
When opening the modal, the components on the page will appear on top of the background of the open Modal.

Expected behavior
When a modal is open the background should always cover up the elements that are on a page.
Screenshots

Closed with PR #240


Value cannot be null

I have this error on executing
MXSPyCOM -f C:\Projects\test\hello_world.ms

Unhandled exception. System.ArgumentNullException: Value cannot be null. (Parameter 'type')
at System.Activator.CreateInstance(Type type, Boolean nonPublic, Boolean wrapExceptions)
at MXSPyCOM.Program.execute_max_commands(String[] args, String filepath)
at MXSPyCOM.Program.Main(String[] args)

Help, please!

Hello Dimitri,
Can you please provide more information?

Which version are you using, 1.0.1 stable release or the 1.1 beta release?
Have you properly added the initialize_COM_server.ms script to your 3ds Max startup scripts folder?

I am unable to reproduce your error using either 1.0.1 or 1.1.

I'm unable to reproduce this issue and the submitter has not responded to a request for more information. I'm closing this issue.


Spurious "Cody is disabled" under low memory conditions

Cody Version
6.0.3-nightly
IDE Information
CLion 2024.1.2
Build #CL-241.17011.124, built on May 28, 2024
Licensed to Virtus Lab sp. z o.o. / Myroslav Golub
You have a perpetual fallback license for this version.
Subscription is active until April 12, 2025.
Runtime version: 17.0.11+1-b1207.24 x86_64
VM: OpenJDK 64-Bit Server VM by JetBrains s.r.o.
macOS 12.7.4
GC: G1 Young Generation, G1 Old Generation
Memory: 2048M
Cores: 4
Metal Rendering is ON
Registry:
actionSystem.update.actions.warn.dataRules.on.edt=false
debugger.attach.dialog.enabled=true
run.processes.with.pty=TRUE
ide.slow.operations.assertion=false
cidr.enable.testRunLineMarkers.clangCatchTestFrameworkSupport=false
cidr.enable.testRunLineMarkers.clangDoctestTestFrameworkSupport=false
cidr.enable.testRunLineMarkers.clangBoostTestFrameworkSupport=false
Non-Bundled Plugins:
com.google.idea.bazel.clwb (2<IP_ADDRESS>.1-api-version-241)
com.sourcegraph.jetbrains (6.0.3-nightly)
Describe the bug
I have loaded a large C++ project into CLion with only 2048 MB of heap memory (which is too little for reliable operation). Whenever I tried to use inline edits, I was getting a "Cody is disabled" notification, even though I hadn't configured codyignore at all.
Expected behavior
While it is no surprise that the Cody plugin did not work properly (and eventually the whole IDE froze), those notifications were totally misleading.
Additional context
No response

This is probably Context Filters "failing closed" because we aren't getting responses from context filters fast enough. TBH, making Cody + IntelliJ work in 2 GB heap is going to be very tough.

Some questions here:

This user looks to be a PLG user, since they mention codyignore, so would it be more accurate to say "this is probably codyignore 'failing closed' "?
Is it common for normal PLG users to work with only 2 GB of heap memory?

Regardless, I think the request here is mainly to update the error notification. So let's move forward with:

if we detect that Cody is running into performance issues (low RAM, low CPU, etc.), show an error that says something of the nature:

"Cody error: we're detecting that we're running into performance issues with your editor. Please restart your editor or check background running tasks to ensure Cody works properly." or something like that.
@dominic.cooney What do you think?

Assigning to @dominic.cooney to get your feedback and resize based on just updated the error

This user looks to be a PLG user, since they mention codyignore, so would it be more accurate to say "this is probably codyignore 'failing closed' "?

The "Cody is disabled" error message could be Cody was slow to start because the IDE was thrashing under the low memory limit ("Cody is disabled or still starting up"), or Context Filters  ("Cody is disabled on this file") because we are being conservative. If we've started up and you're logged into dotcom, we don't display that message.


Bulma conflicting with Tailwind classes

checked and the important heremd:!my-0 seems to be needed.
but the others w-full h-[1px] md:w-[1px] md:h-[13px] seem to work as expect without !
pls remove any important if they are not needed.

It's not needed if there is only tailwind, but now there are some side effects from Bulma styles.. It dose not work as expected without !

yep I'm aware of that, it's pretty annoying, I've encounter those pretty often when adding anymargin or padding   class , it forces you to use ! otherwise it ends up using the bulma class.
conflicting

padding
margin
container
....

Originally posted by @hassnian in https://github.com/kodadot/nft-gallery/pull/9964#discussion_r1549733655

this is larger then it may seem
removing bulma/helpers/spacing is simple
but doing so breaks style in subtle ways
it will require going page by page and over all Neo components to make sure all stays in place

👋

I know, But, i will do my best for our project.

I checked all components and pages and removed unnecessary !,I tried to send pull request but it did not work.
I think it is because  changed codes is not so much to merge.

I am waiting for your reply.

ok, daiagi, sorry for failing my first contribute for our project. Now, I am going to try fixing another issue.


Center modal in window with no overflow

See http://stackoverflow.com/questions/19140702/bootstrap-3-set-height-of-modal-window-according-to-screen-size

This is another quick fix - moving this to SUG milestone.


update creating new so multiple text/rect for state

update appears to enter/append rather than update.  As an example, after changing the dropdown 3 times, I get 3 text/rect pairs for each state.

Thanks @timelyportfolio . It should be fixed now.


Make 2 DL links for drivers.

In dl.rs:
impl std::fmt::Display for DriverWindowsVersion {
    fn fmt(&self, f: &mut std::fmt::Formatter) -> std::fmt::Result {
        match self {
            DriverWindowsVersion::Win10 => write!(f, "win10"),
            DriverWindowsVersion::Win11 => write!(f, "win10-win11"),
        }
    }
}

def dl_links(version, studio=False, type='dch'):
    links = []
    BASE_LINK = 'https://international.download.nvidia.com/Windows'
    match studio:
        case True: nsd = '-nsd'
        case False: nsd = ''

    match type:
        case 'dch': type = '-dch'
        case 'std': type = ''

    for winver in ('win10', 'win10-win11'):
        links.append(
            f'{BASE_LINK}/{version}/{version}-{system_type()}-{winver}-64bit-international{nsd}{type}-whql.exe')
    return links

I would recommend to create 2 download links for drivers.
Older drivers only have win-10 in their DL links but support Windows 11 as well.

I believe I got it, I just make sure the links are not 404's in case it's an older driver and such. Thanks


GH-44149: [Packaging][CI] Remove references to deprecated Ubuntu bionic

Rationale for this change
References to bionic Ubuntu are deprecated.
What changes are included in this PR?
Remove a couple of references to bionic Ubuntu from setup-ubuntu.sh
Are these changes tested?
Yes, will run CI to validate.
Are there any user-facing changes?
No

GitHub Issue: #44149

@github-actions crossbow submit wheel-manylinux--cp39-

@github-actions crossbow submit wheel-manylinux--cp310-

The only place were we seem to use the modified file is on CI when testing wheels on manylinux for Python 3.9 and Python 3.10 (for Ubuntu 20.04 and 22.04 respectively)


Introduce GraphQL specific throttle policies

Describe your problem(s)
GraphQL APIs have query,mutations which work with default request per time frame policies and subscriptions which work with websocket event per time frame policies. Currently we use same request based policies in API-M for both usecases. However, this is not ideal for websocket transport cases, since websocket request throttling is based on the # of active connections which backend can handle at a given time, # of events per time frame, max query complexity depth values etc. Since these parameters deviate from the REST API throttle policies, it is vital to introduce new throttle policy type for GraphQL APIs.
Describe your solution

How will you implement it

Optional Fields
Related Issues:

Suggested Labels:

Suggested Assignees:

tessssssst


Add an option to skip clientID checks  for OIDC issuers

Signed-off-by: Hector Fernandez<EMAIL_ADDRESS>
Summary

We should expose an option to skip the ClientID verification for the OIDC Issuers on demand.
Release Note

Add option to skip the ClientID verifications for the configured OIDC Issuers.
Documentation

@haydentherapper Yes, I understand it is not ideal. But we want to tell Fulcio to skip checking the token’s audience on-demand.

I'm still uncertain why that would be needed unless you're testing with malformed tokens. A token should always contain an audience, and that audience should be static per provider. Fulcio operators should not be able to ignore audience, that opens them up to some risk.

We aren't using malformed tokens. This is only required for OIDC issuer types working with Github-Actions. We need to instruct Fulcio to skip clientID checks, or enable Fulcio to accept custom issuer types which isn't possible today.
cc @priyawadhwa

GitHub Actions supports setting a custom audience, that’s what’s currently done when GHAs call fulcio.
https://docs.github.com/en/actions/deployment/security-hardening-your-deployments/about-security-hardening-with-openid-connect#:~:text=you can set a custom audience with a toolkit command%3A core.getidtoken(audience)
I also don’t think OIDC token verifiers should accept multiple client IDs, you should be given tokens for an expected audience.

The spec allows for multiple audiences, so it would be fine if we supported multiple audiences (albeit I’m not sure the use case) - https://openid.net/specs/openid-connect-core-1_0.html#IDTokenValidation
We aren’t going to add something that allows for deviation from the spec and a potential foot-gun for service operators.

@haydentherapper Sorry for my late reply! Thanks for the comments. We'll reconsider our alternatives here and attempt a different approach.

@hectorj2f Good to close this PR?

Closing since I believe the other PRs will supersede this, lemme know if not.


ASF Licence Header Missing from some of the source files

For example,
https://github.com/apache/kyuubi-docker/blob/master/1.6.1-incubating/scala2.12-java8-ubuntu/Dockerfile

fixed by https://github.com/apache/kyuubi-docker/pull/4


Unable to get WIFI_EVENT_STA_DISCONNECTED event after router turned OFF. (IDFGH-3802)

Environment

Development Kit:      None
Module or chip used:  ESP32-WROOM-32 (DoIt ESP32 DEVKIT v1)
IDF version (run git describe --tags to find it): v4.0.1
Build System:         idf.py
Compiler version (run xtensa-esp32-elf-gcc --version to find it): xtensa-esp32-elf-gcc (crosstool-NG esp-2019r2) 8.2.0
Operating System:     Linux
Using an IDE?: No
Power Supply:         USB

Problem Description
This is a WiFi related issue. The ESP32 received its IP address and mask from the router and is able to communicate. Forcing the router to no power, the wifi driver doesn't indicate the issue to the application.
Expected Behavior
The event handler is expected to receive a WIFI_EVENT_STA_DISCONNECTED event.
Actual Behavior
No event is received.
Steps to reproduce

Using the station example located in esp-idf/examples/wifi/getting_started/station without any change.
Configure with idf.py menuconfig, set wifi ssid and password in example configuration
Router is ON, board is connected to USB port
Compile and load using the following command:  idf.py -p /dev/ttyUSB0 flash monitor

Code to reproduce this issue
The code used to reproduce is the station example from esp-idf/examples/wifi/getting_started/station
Debug Logs
$ idf.py -p /dev/ttyUSB0 flash monitor
Checking Python dependencies...
Python requirements from /home/turgu1/esp/esp-idf/requirements.txt are satisfied.
Adding flash's dependency "all" to list of actions
Executing action: all (aliases: build)
Running ninja in directory /home/turgu1/Dev/station/build
Executing "ninja all"...
[1/4] cd /home/turgu1/Dev/station/build/esp-idf/partition_table && /usr/bin/cmake -E echo "Parti.../cmake -E echo "*******************************************************************************"
Partition table binary generated. Contents:
*******************************************************************************
# Espressif ESP32 Partition Table
# Name, Type, SubType, Offset, Size, Flags
nvs,data,nvs,0x9000,24K,
phy_init,data,phy,0xf000,4K,
factory,app,factory,0x10000,1M,
*******************************************************************************
[2/4] Performing build step for 'bootloader'
ninja: no work to do.
Executing action: flash
Running esptool.py in directory /home/turgu1/Dev/station/build
Executing "/home/turgu1/.espressif/python_env/idf4.0_py3.8_env/bin/python /home/turgu1/esp/esp-idf/components/esptool_py/esptool/esptool.py -p /dev/ttyUSB0 -b 460800 --before default_reset --after hard_reset write_flash @flash_project_args"...
esptool.py -p /dev/ttyUSB0 -b 460800 --before default_reset --after hard_reset write_flash --flash_mode dio --flash_freq 40m --flash_size 2MB 0x8000 partition_table/partition-table.bin 0x1000 bootloader/bootloader.bin 0x10000 wifi_station.bin
esptool.py v2.8
Serial port /dev/ttyUSB0
Connecting......
Detecting chip type... ESP32
Chip is ESP32D0WDQ6 (revision 0)
Features: WiFi, BT, Dual Core, Coding Scheme None
Crystal is 40MHz
MAC: 30:ae:a4:05:0e:34
Uploading stub...
Running stub...
Stub running...
Changing baud rate to 460800
Changed.
Configuring flash size...
Compressed 3072 bytes to 103...
Wrote 3072 bytes (103 compressed) at 0x00008000 in 0.0 seconds (effective 4892.7 kbit/s)...
Hash of data verified.
Compressed 25360 bytes to 14937...
Wrote 25360 bytes (14937 compressed) at 0x00001000 in 0.3 seconds (effective 598.1 kbit/s)...
Hash of data verified.
Compressed 644240 bytes to 406098...
Wrote 644240 bytes (406098 compressed) at 0x00010000 in 9.2 seconds (effective 560.4 kbit/s)...
Hash of data verified.

Leaving...
Hard resetting via RTS pin...
Executing action: monitor
Running idf_monitor in directory /home/turgu1/Dev/station
Executing "/home/turgu1/.espressif/python_env/idf4.0_py3.8_env/bin/python /home/turgu1/esp/esp-idf/tools/idf_monitor.py -p /dev/ttyUSB0 -b 115200 /home/turgu1/Dev/station/build/wifi_station.elf -m '/home/turgu1/.espressif/python_env/idf4.0_py3.8_env/bin/python' '/home/turgu1/esp/esp-idf/tools/idf.py' '-p' '/dev/ttyUSB0'"...
--- idf_monitor on /dev/ttyUSB0 115200 ---
--- Quit: Ctrl+] | Menu: Ctrl+T | Help: Ctrl+T followed by Ctrl+H ---
ets Jun  8 2016 00:22:57

rst:0x1 (POWERON_RESET),boot:0x13 (SPI_FAST_FLASH_BOOT)
ets Jun  8 2016 00:22:57

rst:0x10 (RTCWDT_RTC_RESET),boot:0x13 (SPI_FAST_FLASH_BOOT)
configsip: 0, SPIWP:0xee
clk_drv:0x00,q_drv:0x00,d_drv:0x00,cs0_drv:0x00,hd_drv:0x00,wp_drv:0x00
mode:DIO, clock div:2
load:0x3fff0018,len:4
load:0x3fff001c,len:6876
load:0x40078000,len:14076
ho 0 tail 12 room 4
load:0x40080400,len:4304
entry 0x400806e8
I (72) boot: Chip Revision: 0
I (34) boot: ESP-IDF v4.0.1 2nd stage bootloader
I (34) boot: compile time 08:45:58
I (34) boot: Enabling RNG early entropy source...
I (39) boot: SPI Speed      : 40MHz
I (43) boot: SPI Mode       : DIO
I (47) boot: SPI Flash Size : 2MB
I (51) boot: Partition Table:
I (54) boot: ## Label            Usage          Type ST Offset   Length
I (62) boot:  0 nvs              WiFi data        01 02 00009000 00006000
I (69) boot:  1 phy_init         RF data          01 01 0000f000 00001000
I (77) boot:  2 factory          factory app      00 00 00010000 00100000
I (84) boot: End of partition table
I (88) esp_image: segment 0: paddr=0x00010020 vaddr=0x3f400020 size=0x16d84 ( 93572) map
I (131) esp_image: segment 1: paddr=0x00026dac vaddr=0x3ffb0000 size=0x03864 ( 14436) load
I (137) esp_image: segment 2: paddr=0x0002a618 vaddr=0x40080000 size=0x00400 (  1024) load
0x40080000: _WindowOverflow4 at /home/turgu1/esp/esp-idf/components/freertos/xtensa_vectors.S:1778

I (138) esp_image: segment 3: paddr=0x0002aa20 vaddr=0x40080400 size=0x055f0 ( 22000) load
I (156) esp_image: segment 4: paddr=0x00030018 vaddr=0x400d0018 size=0x6dcbc (449724) map
0x400d0018: _stext at ??:?

I (317) esp_image: segment 5: paddr=0x0009dcdc vaddr=0x400859f0 size=0x0f790 ( 63376) load
0x400859f0: set_chan_dig_gain at /home/aiqin/git_tree/chip7.1_phy/chip_7.1/board_code/app_test/pp/phy/phy_chip_v7_cal.c:1875 (discriminator 3)

I (357) boot: Loaded app from partition at offset 0x10000
I (357) boot: Disabling RNG early entropy source...
I (357) cpu_start: Pro cpu up.
I (361) cpu_start: Application information:
I (366) cpu_start: Project name:     wifi_station
I (371) cpu_start: App version:      1
I (375) cpu_start: Compile time:     Aug 11 2020 08:45:54
I (382) cpu_start: ELF file SHA256:  c5b9454b1f2c5e2d...
I (388) cpu_start: ESP-IDF:          v4.0.1
I (392) cpu_start: Starting app cpu, entry point is 0x400812c0
0x400812c0: call_start_cpu1 at /home/turgu1/esp/esp-idf/components/esp32/cpu_start.c:271

I (0) cpu_start: App cpu up.
I (403) heap_init: Initializing. RAM available for dynamic allocation:
I (410) heap_init: At 3FFAE6E0 len 00001920 (6 KiB): DRAM
I (416) heap_init: At 3FFB99E0 len 00026620 (153 KiB): DRAM
I (422) heap_init: At 3FFE0440 len 00003AE0 (14 KiB): D/IRAM
I (428) heap_init: At 3FFE4350 len 0001BCB0 (111 KiB): D/IRAM
I (435) heap_init: At 40095180 len 0000AE80 (43 KiB): IRAM
I (441) cpu_start: Pro cpu start user code
I (459) spi_flash: detected chip: gd
I (460) spi_flash: flash io: dio
W (460) spi_flash: Detected size(4096k) larger than the size in the binary image header(2048k). Using the size in the binary image header.
I (470) cpu_start: Starting scheduler on PRO CPU.
I (0) cpu_start: Starting scheduler on APP CPU.
I (542) wifi station: ESP_WIFI_MODE_STA
I (562) wifi:wifi driver task: 3ffc2068, prio:23, stack:6656, core=0
I (562) system_api: Base MAC address is not set, read default base MAC address from BLK0 of EFUSE
I (562) system_api: Base MAC address is not set, read default base MAC address from BLK0 of EFUSE
I (592) wifi:wifi firmware version: aa5336b
I (592) wifi:config NVS flash: enabled
I (592) wifi:config nano formating: disabled
I (592) wifi:Init dynamic tx buffer num: 32
I (592) wifi:Init data frame dynamic rx buffer num: 32
I (602) wifi:Init management frame dynamic rx buffer num: 32
I (602) wifi:Init management short buffer num: 32
I (612) wifi:Init static rx buffer size: 1600
I (612) wifi:Init static rx buffer num: 10
I (622) wifi:Init dynamic rx buffer num: 32
I (722) phy: phy_version: 4180, cb3948e, Sep 12 2019, 16:39:13, 0, 0
I (722) wifi:mode : sta (30:ae:a4:05:0e:34)
I (722) wifi station: wifi_init_sta finished.
I (852) wifi:new:<6,0>, old:<1,0>, ap:<255,255>, sta:<6,0>, prof:1
I (852) wifi:state: init -> auth (b0)
I (852) wifi:state: auth -> assoc (0)
I (862) wifi:state: assoc -> run (10)
I (1912) wifi:connected with toto, aid = 1, channel 6, BW20, bssid = 00:21:29:68:41:64
I (1922) wifi:security: WPA2-PSK, phy: bg, rssi: -54
I (1922) wifi:pm start, type: 1

I (1972) wifi:AP's beacon interval = 102400 us, DTIM period = 1
I (5042) tcpip_adapter: sta ip: <IP_ADDRESS>, mask: <IP_ADDRESS>, gw: <IP_ADDRESS>
I (5042) wifi station: got ip:<IP_ADDRESS>
I (5042) wifi station: connected to ap SSID:toto password:snoopy1967
I (24462) wifi:bcn_timout,ap_probe_send_start
I (26962) wifi:ap_probe_send over, resett wifi status to disassoc
I (26962) wifi:state: run -> init (c800)
I (26962) wifi:pm stop, total sleep time: 15241907 us / 25040626 us

I (26972) wifi:new:<6,0>, old:<6,0>, ap:<255,255>, sta:<6,0>, prof:1

Other items if possible

[ ] sdkconfig file (attach the sdkconfig file from your project folder)
[ ] elf file in the build folder (note this may contain all the code details and symbols of your project.)
[ ] coredump (This provides stacks of tasks.)

Thanks for reporting and letting us know, we will look into.

hi @turgu1 ,
According to the log state: run -> init (c800), the STA has issued the disconnect event, but the application doesn't report the disconnect event.  The reason is as the following:
In the station example, after the STA has connected to AP successfully, the event handler will be deleted, so the when you power off the AP, the disconnect event doesn't show.
https://github.com/espressif/esp-idf/blob/820621687ce04b3c85276ca0eb3fe72479573cfd/examples/wifi/getting_started/station/main/station_example_main.c#L123
If you want the example show the disconnect event, you can delete line 122~124 in the example.

Well, I need a new pair of glasses. Thank you!


content/remotes: Example of what a SSH or HTTPS selector could look like.

As discussed in an idea
Installation instructions would still need to be updated
Review: is correct?  Is simpler?  Is useful?

Thanks! This looks like a very useful improvement.

Thanks!


Automated cherry pick of #5424: fix(esxi): Add two account with same account name

Cherry pick of #5424 on release/2.12.
#5424: fix(esxi): Add two account with same account name

/lgtm

/approve


Fatal errors are not recorded with the curl method async

Sentry flushes the unsent messages and calls curl join in the onShutdown method, which is correctly registered to run on shutdown.
However, fatal errors are logged on the ErrorHandler shutdown callback, which is registered after onShutdown. (onShutdown is registered on the Client constructor, and error_handler->registerShutdownFunction is call after you build the Client).
The end result is that a Fatal error gets recorded internally, but it's not send as onShutdown has already been called.
You need to make sure onShutdown runs after all other shutdown handlers.

Although some work was done on this last year, I believe this is still an issue, see https://github.com/getsentry/sentry-php/issues/552#issuecomment-366473263

Isn't onShutdown called on the client destructor?
BTW yes, this is surely related to #552
@nokitakaze IIRC you wrote this part, what do you think?

I'm afraid I don't know. This case must be tested in separate process to test the behaviour.

Hmm not sure off the top of my head, if you had access to $client->_curl_handler->requests you could see if the requests were sent off?

here's code to reproduce the problem, just need a way to detect it:
include './vendor/autoload.php';
ini_set('memory_limit', '8M');
$client = new Raven_Client('...', ['curl_method' => 'async']);
$client->install();
while (TRUE) {
  $a[] = 'b';
}

I think that the only way to detect it would be adding first an other exception handler which could output the result... I'll try that now.

I cannot reproduce the issue, at least not under PHP 7.
This is my test script:
<?php
include '../vendor/autoload.php';

$dsnPublicSite =<EMAIL_ADDRESS>$client = new Raven_Client($dsnPublicSite, ['curl_method' => 'async']);
$client->install();

ini_set('memory_limit', '8M');
while (TRUE) {
    $a[] = 'b';
}

... and this is the correct result:

I think that curl is called correctly because it's registered as a shutdown function here:
https://github.com/getsentry/sentry-php/blob/78433785800d68bb47861c352fc59e28de778e10/lib/Raven/CurlHandler.php#L32

I've just tested it under PHP 5.6 and I can reproduce the issue, but my test is still green... Don't know why!

Well, I can't get it to work on PHP 7.1, presumably because Raven_ErrorHandler registers its shutdown function last, so when it runs (firing off the last exception message), join() has already been called.

Your test is noting that join() was called, but it needs to be called again after handleFatalError() is called.

You're right, thanks! Fixed in cf49ac1, opened #575 as a WIP PR.

#575 merged, can you test if this solves this issue?

I added some echo statements in the shutdown-related methods to make sure I'm not crazy, here's what I see:

PHP Fatal error:  Allowed memory size of 10485760 bytes exhausted (tried to allocate 8388616 bytes) in myapp/test.php on line 9
running curl handler join
running Client onShutdown
running curl handler join
running handleFatalError

So handleFatalError() is still running last, and there is no additional call to join() after that.
The order makes sense because that's the order that register_shutdown_function() is called (the Client makes its own additional call to join).

I had to tweak the test to have an actual working DSN, otherwise it seems like requests didn't queue up?
Also passed a reference to the client into the anonymous shutdown function rather than copying the variables.
This gives me "There are still queued request inside the Curl Handler":
<?php
$client = new \Raven_Client('ACTUAL WORKING DSN HERE', array('curl_method' => 'async'));

$client->setSendCallback(function () {
    echo 'Sending handled fatal error...' . PHP_EOL;
});

$client->install();

register_shutdown_function(function () use (&$client) {
    $pendingEvents = \PHPUnit\Framework\Assert::getObjectAttribute($client, '_pending_events');
    $curlHandler = \PHPUnit\Framework\Assert::getObjectAttribute($client, '_curl_handler');
    $pendingRequests = \PHPUnit\Framework\Assert::getObjectAttribute($curlHandler, 'requests');

    if (! empty($pendingEvents)) {
        echo 'There are pending events inside the client';
    }

    if (empty($pendingRequests)) {
        echo 'Curl handler successfully emptied';
    } else {
        echo 'There are still queued request inside the Curl Handler';
    }
});

ini_set('memory_limit', '8M');
while (TRUE) {
    $a[] = 'b';
}

You're right once again @mfb, thanks a lot for your help!
You can check out the result in #576, I used your code to finally fix it! Does that work for you?

Thanks everyone for helping out 👍
We believe this issue should be fixed in 1.9.0 that was just released, if there is still an issue please reopen this issue.

I have a related PR at #613 to provide a method for registering the async shutdown function.  This is required by any custom setups of the client that don't call install()


添加中文文档

Thanks for providing the Chinese readme doc, but we already have one in ModelScope which has a more accurate translation.


Depreacated method in IABlocks

Appearently GameRegistry.registerItem(item, unlocalizedName) is depreacated in the newer forge builds.
Needs a fix, cause a @SuppressWarnings("deprecation") isn't exactly a fix.

Tried the following changes in local tree with no success:

Added setRegistryName calls ("ignous_extras", "{blockName}") in constructors
Replaced with GameRegistry.register(block) for blocks with constructor changes
Should register successfully, did not actually register

I was going to push it to a feature branch but ended up rage quitting and reset to HEAD :p

It seems to be working when registering both the block and a new ItemBlock created from the block


HybridApp fails to deploy due to react-native-image-size Gradle dependencies

Problem
Slack thread: https://expensify.slack.com/archives/C07J32337/p1723060725518079
HybridApp deploys are failing with:
FAILURE: Build failed with an exception.

* What went wrong:
A problem occurred configuring project ':react-native-image-size'.
> Could not determine the dependencies of null.
   > Could not resolve all task dependencies for configuration ':react-native-image-size:classpath'.
      > Could not find com.android.tools.build:gradle:2.3.3.
        Searched in the following locations:
          - https://repo.maven.apache.org/maven2/com/android/tools/build/gradle/2.3.3/gradle-2.3.3.pom
          - https://jcenter.bintray.com/com/android/tools/build/gradle/2.3.3/gradle-2.3.3.pom
        Required by:
            project :react-native-image-size

Solution
Seems like we are trying to get a Gradle version that is not available. This problem previously occurred here and was fixed in a similar way to how we fixed it last time by @roryabraham in this PR

Did that gradle version change in our fork fix this problem?

It did, but a new problem manifested. See @Julesssss notes starting here.

I don't see an external contributor involved in the linked PR. @marcaaron, am I missing them?

This was internal.


Support to set Kustomization parameters of an Application

/area console
/kind feature

/assign @EliChen95

/assign

Basically, this issue requests to allow users to set the parameters like the following kustomize part.
spec:
  argoApp:
    spec:
      source:
        repoURL: 'https://github.com/kubesphere/console'
        path: .
        targetRevision: HEAD
        kustomize:
          namePrefix: my_
          nameSuffix: _end
          images:
            - 'nginx=nginx:latest'
          commonLabels:
            name: rick
          commonAnnotations:
            name: rick
          forceCommonLabels: true
          forceCommonAnnotations: true

See also https://argo-cd.readthedocs.io/en/stable/user-guide/kustomize/

By the way, we need to provide an option to choose which Configuration Tool that they want to use. The possible values are: kustomize, helm and none.
In this case, users need to choose kustomize before setting those parameters.


feat: add SEO microdata for doc breadcrumbs

Motivation
Continuation of #6517
Have you read the Contributing Guidelines on pull requests?
Yes
Test Plan
Test on this page: https://search.google.com/test/rich-results
With the following URLs:

https://deploy-preview-6697--docusaurus-2.netlify.app/docs/
https://deploy-preview-6697--docusaurus-2.netlify.app/docs/migration/

Note: on this URL, the "Migrating from v1 to v2" doesn't have a URL so right now it's giving a waring about "invalid ID". Not sure how to fix.

Going to merge and see if anyone complains...


Does DPO/RLHF tuning support internVL2 video models?

Hi, thanks for the great work! I'm wondering if DPO is supported for tuning internvl2 with video input? Thanks!

https://github.com/modelscope/ms-swift/pull/1975

However, it seems that _patch_internvl_forward(forward_func) in swift/swift/llm/utils/model.py have pixel_values = None even if I provide an videos key in each entry of the dpo dataset. I think in this case the video input is not being processed?