Firestore crash firebase::firestore::util::AsyncQueue

[REQUIRED] Step 1: Describe your environment

Xcode version: 11.2.1
Firebase SDK version: 6.21.0
Firebase Component: Firestore
Component version: 6.21.0
Installation method: CocoaPods

[REQUIRED] Step 2: Describe the problem
I've receive the following crash report that has come from a user of my app:
Crashed: com.google.firebase.firestore
0  libsystem_kernel.dylib         0x191959ec4 __pthread_kill + 8
1  libsystem_pthread.dylib        0x1918751d8 pthread_kill$VARIANT$mp + 136
2  libsystem_c.dylib              0x1917c9844 abort + 100
3  libsystem_malloc.dylib         0x191862b80 _malloc_put + 558
4  libsystem_malloc.dylib         0x191862d38 malloc_report + 60
5  libsystem_malloc.dylib         0x191858124 free + 532
6  QJAM                           0x104f05dd0 std::__1::shared_ptr<firebase::firestore::util::AsyncQueue>::~shared_ptr() +<PHONE_NUMBER>
7  QJAM                           0x104f8540c firebase::firestore::immutable::SortedMap<firebase::firestore::model::DocumentKey, absl::lts_2019_08_08::optional<firebase::firestore::model::MaybeDocument>, firebase::firestore::util::Comparator<firebase::firestore::model::DocumentKey> >::~SortedMap() +<PHONE_NUMBER>
8  QJAM                           0x104f96ab8 std::__1::__function::__func<std::__1::enable_if<!(std::is_same<void, decltype(fp0())>::value), decltype(fp0())>::type firebase::firestore::local::Persistence::Run<firebase::firestore::local::LocalStore::ApplyRemoteEvent(firebase::firestore::remote::RemoteEvent const&)::$_7>(absl::lts_2019_08_08::string_view, firebase::firestore::local::LocalStore::ApplyRemoteEvent(firebase::firestore::remote::RemoteEvent const&)::$_7)::'lambda'(), std::__1::allocator<std::__1::enable_if<!(std::is_same<void, decltype(fp0())>::value), decltype(fp0())>::type firebase::firestore::local::Persistence::Run<firebase::firestore::local::LocalStore::ApplyRemoteEvent(firebase::firestore::remote::RemoteEvent const&)::$_7>(absl::lts_2019_08_08::string_view, firebase::firestore::local::LocalStore::ApplyRemoteEvent(firebase::firestore::remote::RemoteEvent const&)::$_7)::'lambda'()>, void ()>::operator()() +<PHONE_NUMBER>
9  QJAM                           0x104f822e8 firebase::firestore::local::LevelDbPersistence::RunInternal(absl::lts_2019_08_08::string_view, std::__1::function<void ()>) +<PHONE_NUMBER>
10 QJAM                           0x104f9312c firebase::firestore::local::LocalStore::ApplyRemoteEvent(firebase::firestore::remote::RemoteEvent const&) +<PHONE_NUMBER>
11 QJAM                           0x104fdb494 firebase::firestore::core::SyncEngine::ApplyRemoteEvent(firebase::firestore::remote::RemoteEvent const&) +<PHONE_NUMBER>
12 QJAM                           0x104fc736c firebase::firestore::remote::RemoteStore::RaiseWatchSnapshot(firebase::firestore::model::SnapshotVersion const&) +<PHONE_NUMBER>
13 QJAM                           0x104ff7dc0 firebase::firestore::remote::WatchStream::NotifyStreamResponse(grpc::ByteBuffer const&) + 2148 (memory:2148)
14 QJAM                           0x104fd4ed0 firebase::firestore::remote::Stream::OnStreamRead(grpc::ByteBuffer const&) + 2637 (memory:2637)
15 QJAM                           0x104f688d8 std::__1::__function::__func<firebase::firestore::remote::GrpcCompletion::Complete(bool)::$_0, std::__1::allocator<firebase::firestore::remote::GrpcCompletion::Complete(bool)::$_0>, void ()>::operator()() + 1651 (functional:1651)
16 QJAM                           0x104f06a10 firebase::firestore::util::AsyncQueue::ExecuteBlocking(std::__1::function<void ()> const&) +<PHONE_NUMBER>
17 QJAM                           0x104f26bb4 firebase::firestore::util::internal::DispatchAsync(NSObject<OS_dispatch_queue>*, std::__1::function<void ()>&&)::$_0::__invoke(void*) +<PHONE_NUMBER>
18 libdispatch.dylib              0x19182f184 _dispatch_client_callout + 16
19 libdispatch.dylib              0x1917db404 _dispatch_lane_serial_drain$VARIANT$mp + 608
20 libdispatch.dylib              0x1917dbdf8 _dispatch_lane_invoke$VARIANT$mp + 420
21 libdispatch.dylib              0x1917e5314 _dispatch_workloop_worker_thread + 588
22 libsystem_pthread.dylib        0x19187eb88 _pthread_wqthread + 276
23 libsystem_pthread.dylib        0x191881760 start_wqthread + 8

Steps to reproduce:
Unfortunately I can't reproduce it, it happened on a random persons device, and I don't have any more info than the above.
I'd be grateful if you could look into this crash.

@yusuftor Thank you for this report.
Unfortunately, the stacktrace in the Crash Report is rather broad and as such makes it a bit hard to pinpoint the issue. While I understand that this is a one off issue for you, it would help us a lot if you are able to reproduce this in a small sample app. Alternatively, would it be possible to share the code from your app that you think might be responsible?
Can you also let us know if you see this crash again?

This might be related to https://github.com/firebase/firebase-ios-sdk/issues/5238.
If the above steps are not feasible for you, the steps in https://github.com/firebase/firebase-ios-sdk/issues/5238#issuecomment-607372681 might also let us determine the cause.

@schmidt-sebastian thanks for the reply. Unfortunately it won't be possible to reproduce the crash because it happened on a random user's device and I don't know any more about it. I can't share code from my app either due to privacy reasons but firebase doesn't say that it's from heap corruption. Sorry I can't help any further!

Closing this since it's not currently actionable by the Firestore team and the stack trace indicates the crash may not be caused by Firestore. Please let us know if you have more information and we'll reopen the issue.


More button

It's not a primary action, so it shouldn't be in plein blue like the Send and Receive buttons.
See figma:

Also, there shouldn't be any animation when loading. Just show the button directly like the other buttons.
https://github.com/user-attachments/assets/c83e02a5-94a2-4df1-87b5-907df93b4a6b

It's better but it's not there yet.
I really think it should just appear. No animation.
An animation would be needed if you were to move the other primary buttons. But they don't. So no need.
https://github.com/user-attachments/assets/59cab078-b486-4d56-86da-4718ab925077


Change angular.service example to lowerCamelCase

As indicated just a couple of paragraphs above this example, one should use "lowerCamelCase for all other services" that don't return constructor functions. In this example since the constructor is being registered via angular.service, it will return an already-constructed instance, not a constructor function, when injected. So the name of the service should be written lowerCamelCase.

Thanks for the PR! I'll update the list of contributors next a couple of days.


More compressed command-line option documentation

@charlierudolph @allewun
Aggregates the description for command-line options that semantically belong together.
Implements #385

:+1:

Need parens around each.

Parentheses added

all comments addressed

:ship:


[Bug]: bump-version.yml workflow errors on PRs from forks

Bug Summary
The new version bump automation workflow errors when PR's from forked repos are merged.
Detailed Description
We recently added the bump-version.yml automation to bump package versions based on PR labels, but it requires a PAT to merge to the protected main branch, which is not provided to PR's from forks for security reasons. We should update the workflow file so that it no-ops when the secrets.GH_PUSH_TOKEN is not provided`
Current Behavior
See prior run examples: https://github.com/cuttle-cards/cuttle/actions/runs/6482130280
https://github.com/cuttle-cards/cuttle/actions/runs/6476492175
Expected Behavior
The workflow job should not run if the GH_PUSH_TOKEN secret is not provided
Steps to Reproduce

Merge a PR from a fork
bump-version action will run and error

@itsalaidbacklife Please assign this issue to me

and kindly add the hacktoberfest label

@trishanu-init please have at it! You don't actually need the hacktoberfest label on the specific issue because the hacktoberfest topic on the repo itself ensures credit is given for any PR's merged into main of this repo.
We can only 'officially' assign the issue to organization members, but this would be a valuable contribution, so if you're still interested please do take this one on

Reopening because my suggested change of defaulting to the github token broke the workflow


Todo

Unordered roadmap for v1.0

[x] Add all events to gameloop
[x] Implement Player
[x] Implement Unit
[x] Implement Game
[x] Implement Force
[x] Implement Region
[x] Implement Bullet
[x] Implement UnitCommand static methods
[x] Implement Tile/Walk/Position
[x] Operations add, substract, multiply for Tile/Walk/Positions
[x] Implement PlayerType
[x] Implement Race
[x] Implement TechType
[x] Implement UnitType
[x] Implement UpgradeType
[x] Implement WeaponType
[x] Implement Color
[x] Implement draws
[x] Resolve all remaining TODO's  in the code

Full interface now finished minus eventual bugs/performance optimisations


Error with docker compose

when i try to start the docker container I am getting error below

docker-compose up -d
Pulling azure-vote-back (redis:)...
latest: Pulling from library/redis
ERROR: no matching manifest for windows/amd64 10.0.16299 in the manifest list entries

I had the same problem. Answer on SO question helped me:
https://stackoverflow.com/a/51071057


conv2d: add an optional IGEMM (implicit GEMM) mode for conv2d

Ideally this should be triggered when we know a tensor core will be available.

What is igemm and what does it do differently?

Here's a description from CUTLASS: https://github.com/NVIDIA/cutlass/blob/main/media/docs/implicit_gemm_convolution.md.
We're not doing the shared memory parts, but basically this mostly changes the triple reduce axes to a single reduce where (CIN,H,W) are all combined, at which point the tensor cores can take over since it is a pure GEMM.
This makes all sized conv2d faster (except in the case where WINO outperforms at 3x3).

Are you sure those two lines are different? If you reshape them all to one axis, without a contiguous tinygrad won't do anything.

I believe it does because with a single axis there's no multiple reduce loops in the kernel.  Also when it is a single reduce axis, it can trigger the tensor cores when available.  Here's some data from ./test/models/test_real_world.py:

Actually that said, if collapsing the reduces is doable as an Opt, I think that's way better than doing it here in tensor.py :/

It should totally be doable as an Opt, just reshape in the linearizer

Agreed - closing for now!


Support laravel 10

@mvdnbrk

ping @mvdnbrk

@mvdnbrk A merge and release of this PR would be nice 😃 Thanks!


Broken links in file docs/contributing_to_qiskit.rst

Did you find a doc bug or broken link that needs to be fixed?
Yes, the link "Build from source" in the file docs/contributing_to_qiskit.rst is broken, and all the links inside that section too. They are not able to refer to the sections in the file.

What is the file name(s) where you found the bug?
The file name is contributing_to_qiskit.rst
What is the current text that needs to be fixed or removed? (You can copy and paste)
:ref:Build Qiskit packages from source <install_install_from_source_label>
This should be a link to the following section in the file.
What should the documentation say instead?
There should be a link guiding the user to the section Installing from source in the same file
Are there other related issues or pull requests about this bug?
Yes, all the links under this section Installing from source are broken and doesn't lead to the corresponding sections.

Does existing documentation need to be updated with new content?
No. Just the links have to be fixed.

Which files need to be updated?

What content needs to be updated or replaced? (You can copy and paste)

What new content needs to be added?

Hi. I can solve this issue. May I proceed?

Definitely! However, I tried to fix this and I found it can't be fixed because the text is not writen in markdown language. If you change here, it will not work properly on the website. If you see this part on website, it is working fine. But do have a look.

Ah I see. And that is a problem because the HTML is generated from the RST?
Also, have you tried the autosectionlabel extension for Sphinx?

@bytesalad Yes and no. Yes that that is the problem that HTML is generated from RST. And no that I didn't try. I thought its fine the way it is, since 95% of the people will read from the website only. Reading such a massive documentation from GitHub is very rare unless someone is an experienced developer, in which case it won't be a problem for him to figure out. So I think we can close this issue, unless you wanna work on it?

Good point. You can or you can flag it as priority low if you want to.

The link works in the website - https://qiskit.org/documentation/contributing_to_qiskit.html. The requested change need not be made to contributing_to_qiskit.rst. That's because these .rst files are rendered to HTML for the documentation. I'm closing this issue.


build: pull authors out of subrepos

pulls comitternames out of subrepos
uses local variables instead of globals
makes use of our .mailmap file in our main repo
composable: just source it and pipe it into your process

usage in couchdb-build-release.sh:
sed -e "/^#.*/d" THANKS.in > $RELDIR/THANKS

source "build-aux/print-committerlist.sh"
print_comitter_list >> THANKS;

suggested reviewer: @janl

I'm not Jan, but I still like it. Maybe pipe into sort also (and make sure git is current enough) => +1

print_committer_list produces non-sorted output.

building the thanks file on 1.x currently works like this:

take content from THANKS.in and pipe it into the THANKS file
get committer list from date of their contribution and add it to the THANKS file

(see https://github.com/apache/couchdb/blob/1.6.x/bootstrap#L57-63)
the thanks file was never ordered alphabetically and i don't see why it should be.
what would be the improvement?

for me, it's totally OK as it is, no need to sort

the thanks file was never ordered alphabetically and i don't see why it should be.
To easily notice duplicates and actual authors? Jason Smith mentioned three times for instance.

I’d still be fine with getting rid of the THANKS file :)

as i already mentioned, the script is a way to consume all committers from all our new subrepos from other processes.
if your process wants to sort the output, feel free to pipe it into your consumer/transorm-stream, this script just delivers the raw output which can be sorted in multiple ways (e.g. by date).

hint: a possible consumer could also be a deduplicate-script

Bump. @robertkowalski do you still have an interest in making this work, or do we just proceed without a THANKS file like we did for the 2.0.0 release?

I'm going to merge this for now, since it's not referenced in the actual build yet. We can decide what we want to do for 2.1 during the next release cycle.


Rename Document Uploads Wizard Step to "Supportive Documentation"

Change to Suportive Documentation Page
Add check list for needed supported documents

This is a duplicate of #242

Where is this list of needed supported documents?

From https://github.com/on-site/grantzilla/files/175263/hif_online_application.pdf, which is listed on #240
SUPPORTIVE DOCUMENTATION NEEDED FOR EVERY APPLICATION:
o Three‐month budget that demonstrates cash crisis and sustainability in future months
o W‐9 from landlord
o Relevant pages of lease (pages that show name of lessees, rental amount, security deposit amount, rental dates, and signatures of lessees and payee). If a lease has not been signed, an Acknowledgement to Rent can be submitted in lieu of lease
o Verification of owed costs (3‐Day Notice or other written verification of exactly what lessee owes)
o Verification of income for every adult (pay stubs, letter verifying employment, benefits award letter, etc)
o Verification of crisis (car repair bill, copy of no‐fault notice to vacate, verification of illness)

Grazie! The uploaded files are not tagged as any particular type(that I can tell) right?  This is just going to be a static list.

That's a good place to start.  I think we'll want to start classifying the uploads at some point so it can be kind of a checklist.  Not sure what@joedean has done so far there, but believe he might have something started...

Thanks for jumping in to help!

Heck yea!  :goberserk:

Whoops, identity crisis.  Keep switching accounts  😭


Not working

after following these instructions on 16299.rx3_release.170928-1534 windbg reports:
The system does not support local darnel debugging.
Local kernel debugging requires Administrative
privileges, and is not supported by WOW64.
Only a single local kernel debugging session can run at a
time.
Local kernel debugging is disabled by default. You must run
bcdedit -debug on and reboot to enable it.
bcdedit was update successfully and system rebooted, windbg was started with at Administrative level.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 97eed641-8cd3-4359-aee7-2f14acd28b24
Version Independent ID: c0c6d81e-4487-cd62-9dcd-9ce3b14f98e0
Content: Setting Up Local Kernel Debugging of a Single Computer Manually
Content Source: windows-driver-docs-pr/debugger/setting-up-local-kernel-debugging-of-a-single-computer-manually.md
Product: windows-hardware
GitHub Login: @DOMARS
Microsoft Alias: domars

Thanks, @LarryK348
@DOMARS can you please look into whether this repros?

Local kernel debugging was successful for me and continues to be functional. Make sure that you are using the correct "bitness" of the debugger to match the version of Windows. If you are running 64-bit Windows, use the debugger in the x64 directory.
For further help, your best bet is to look for help in Stack Overflow, the Windows Hardware WDK and driver development forum, or the OSR NTDEV forum.


upgrading from 0.6 to 0.7  will result in corruption of existing segment in realtime node

description here.
https://groups.google.com/forum/#!topic/druid-user/TwVYMnmG82U
this is guaranteed to happen every time and should be documented in the upgrade notes for 0.7

Can this be closed on a count of being super old?


Default export doesn't seem to be work

As per the readme import gqlmin from 'gqlmin'; does not give a function.
Instead gqlmin.default is where the main function resides. Atleast in the context of an mjs file with Node.js 20.
:bulb: I prefer named exports, maybe it's an idea to export the function so import { gqlmin } from 'gqlmin'; works (too)?

Thanks for the suggestion! This is likely just from (very) old packaging. The problem you described is from CommonJS <> ESM interop that’s gotten a lot better since this package was written.
I don’t have a ton of time this week, but perhaps soon I can update this package & push a more modern version where the internals don’t change, but the bundling is updated to current standards (kinda forgot about this package, honestly!)

Yeah this package is basically in maintenance mode, and won’t receive any major updates, but we can at least just fix everything & modernize it. And remove unnecessary deps that are from many Node versions ago.

Actually did have some time today, and published 0.2.0 that only ships ESM, and removes everything but chalk from the CLI. Library itself is unchanged. Thanks for the issue! Please let me know if the new version has something unexpected

Thank you, that was quick!

Oh @drwpow dist is missing from the published package files, but main is pointing to it.

Oh, sorry—dunno what happened there. Fixed!

Under version 1 every change is (potentially) breaking.

This isn’t “official” but I personally like the pattern of: pre-1.0, minor is breaking; patch isn’t (what esbuild and three.js does, though the latter is decidedly never shipping a 1.0 and treating minor as major).


IN-PROGRESS [STACK-168] Correct duplicate argument issue in listener update

Corrects issue reported by customer when protocol is specified in virtual port expressions.

The pypy tests appear to be failing due to a bad pypy ver or pypy-incompatible tox ver being pulled by Travis.

check-ci

check


SMS Message Rule

Provide option to send message rule to SMS and email.

Hey Christian,
I've looked into adding sms to superhost tools but it's prohibitively expensive to send text messages.  There is a way to send text messages to some carriers using email.  If you know what cell service your cleaner uses you can try adding emailing them a text message.  If that works, you could try using that email in superhost tools.  Here's a list of providers and their emails:
https://github.com/typpo/textbelt/blob/master/lib/carriers.js
Let me know if that helps/works.

Using carrier email to SMS text email address worked for AT&T today.    It arrived around the scheduled time in the rule....off by a few minutes.

Ok, great!  Maybe I'll add the option to send an sms with a big disclaimer that states that it doesn't work with all carriers and should be verified.  I'm currently move the code to a new server (the site outgrew the other server) and making it more efficient.  Once that's done.  I'll make the sms my first priority.

I added the ability to send text messages.  Give it a try and let me know if it works like you'd expect.

Hi there!
Thanks for adding it. I found this repo earlier today but I wasn’t able to get the code to work. I loaded it on Heroku but after connecting my account it said go to pricing or messaging but I didn’t see those options. I tried to re-conenct a few times but noting ever happened.
Keep up the good work!
K

On Sep 22, 2017, at 7:17 PM, Tom<EMAIL_ADDRESS>wrote:
I added the ability to send text messages. Give it a try and let me know if it works like you'd expect.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub https://github.com/wootwoot1234/Superhost-Tools/issues/12#issuecomment-331581263, or mute the thread https://github.com/notifications/unsubscribe-auth/AFWKM8wmBGFjlkLMVyk_Vd8vp_Zxa1C5ks5slD_tgaJpZM4PbzTu.

@Kashk have you taken a look at your logs?  Since this is not related to sms please start a new issue.  Thanks!

Tested this morning.  Works for me.  Thank you!

Great!  Thanks for getting back to me.


checking sha256 and md5 at download

Hi there,

sha256 and md5 checking is included
tested on my end and it works
PyTest not written yet

Edge cases worth discussing:
(1) if sha256 and md5 hash are provided via json, which one to take (or both)?
(2) Should checksums be mandatory (i.e. do not start download if not provided)?
Please review code and advise.

recheck

Note: Before GitHub Actions let you execute the tests, you can launch them locally (make pytest).

@marcenacp - i think we are good here. I'd say we can merge

@St3V0Bay Thanks!


WindowDialog constants not working.

Godot version:
v3.1.1.stable.official
OS/device including version:
Windows 10 Home 10.0.17134
Issue description:
Window dialog constants don't update the look of the node.
The only constant that seems to work is the stylebox.
Steps to reproduce:
Create a WindowDialog node, and try and modify any of its custom properties other then "custom style". See that nothing changes.
Minimal reproduction project:
simple_test.zip

Can confirm on 037237f5183c4b8752f8a08d610bb9395ad294ea (master-ish).
Can't see why it would happen though.


[question] timed fade in/out that can be set via HomeKit

Do you guys see a way for a timed fade in/out that can be set via HomeKit? For example the Hue app's native "Wake up/Sleep" routines but manageable via HomeKit scenes or longpresses/3D touches.
At the moment I use the hue light native with the hue bridge connected to HomeKit.
Thanks.

That's an interesting idea!
In the Hue API, you can specify transitiontime when changing a light (or group) state, to specify how long the change should take.  This defaults to 400ms, but you can specify 0 for immediate changes or a longer time, like 10 minutes, that I use for my wakeup routine.
As far as I know, there's no equivalent concept in HomeKit. I don't expect the Hue bridge exposing this functionality to HomeKit, but that's why I created homebridge-hue in the first place ;-). I could easily create a custom Transition Time characteristic and insert its value with each request to the Hue bridge to change a light (or group) state.
However, transitiontime is not a regular light state attribute.  It's value isn't stored with the light state on the Hue bridge.  I would remember it's value in homebridge-hue, just as I do for Duration or Heartrate.  Rather than adding Transition Time to each Lightbulb service (increasing the size of the HomeKit configuration, see #129), I would add it to the Hue bridge service (next toHeartrate).
@DJay79, please let me know if this would work for you.  The usual caveats would apply:

The iOS builtin Home app doesn't support custom characteristics, so you'd need Eve or another HomeKit app that does.  You would be able from Home to recall a scene created in Eve containing Transition Time;
You can only specify Transition Time once in a scene, so you'd need a separate "reset" scene;
The value of Transition Time would be reset after homebridge restarts, see #4;
Using HomeKit scenes might not be as smooth as using Hue bridge scenes.  HomeKit scenes are just a collection of characteristic values, each sent to the accessory (i.c. home bridge-hue) in a separate request,  forwarded to the Hue bridge in separate API calls, resulting in separate ZigBee messages.  Unlike Hue bridge scenes which are stored in the lights and only require a single API call and a single ZigBee message.  For serious home automation, I recommend using Hue bridge scenes: create a CLIPGenericStatus sensor with a number of rules that, when the status becomes non-0, recall a scene and reset the status to 0.  Expose this sensor to HomeKit using homebridge-hue, and then set the status from HomeKit scenes.

Have a look at v0.5.4.  I think Transition Time is fully functional, but I found two more caveats:

In Eve, you cannot set Transition Timeaccurately.  I set the maximum transition time to an hour, so the slider contains 36,000 values (from 0.0 to 3600.0 in steps of 0.1 second);
When using a longer transition time, HomeKit doesn't reflect the actual light state.  This is a limitation of the Hue bridge: it polls the lights at discrete intervals, so the state only gets updated once every so many seconds (depending on the number of connected lights).

You are crazy @ebaauw and this in an absolute fantastic way. 👍
So I think to take advantage of Transition Time, this is the point where I have to use my hue light thru your homebridge-hue plugin and not native by the hue bridge connected to HomeKit as it is now.

In Eve, you cannot set Transition Time accurately. I set the maximum transition time to an hour, so the slider contains 36,000 values (from 0.0 to 3600.0 in steps of 0.1 second)

I've been thinking about ways to address this issue.  I haven't found another (free) HomeKit app, which allows typing the value instead of using a slider.  Matthias' Home app (paid) allows changing the value one step using + and -, but somehow it tends to freeze when changing custom characteristics.
Some ideas:

Reset Transition Time to the default 0.4s automatically, 20ms (value of waitTimeUpdate in config.json) after a light state has been changed (so the entire scene would still use the Transition Time);
Use a more limited and/or coarser-grained range (e.g. 0 to 30 minutes in 1-minutes steps);
Expose Transition Time as a string?
Split Transition Time into multiple characteristics: for 0.1 seconds (0.0 to 0.9), for seconds (0 to 59), for minutes (0 to 59)?  Best create a separate service to group these.

@ebaauw I noticed, that I'm good with the slider in Eve App. But what I forgot, my Raspberry auto-starts every hour for better performance. And as you mentioned the Transition Time is always reset 0.4s. Unfortunately I didn't have the time yet to test everything because I was not at home and already on the jump.
What would a scenario be to use Transition Time or rather how to integrate this feature?

I tested a HomeKit scene that includes Transition Time and turns six lights on, at maximum brightness and with colour red.  The lights fade in, as intended.
I don't think the order of the characteristics in a scene is guaranteed, but homebridge-hue waits 20ms to collect all state changes to a single light before issuing the command to the bridge.  That was long enough for Transition Time to be set.  You might want to adjust waitTimeUpdate if transitiontime isn't included in the first(s) light updated from the scene.  If needed, you can run homebridge -D And check whether transitiontime actually included in the command to the bridge.
For my wakeup scene (from the Hue bridge), I turn on my bedroom lights at 0% brightness when my alarm goes off.  1 second later, I set the brightness to 100%, with a transitiontime of 10 minutes.  You could get the same behaviour in HomeKit, by setting two alarms, one second apart, the first recalling the scene to turn the lights on at 0%, the second scene to turn the lights up to 100% with TransitionTime.  You might want to add a third alarm with a scene only to reset Transition Time, or all other (manual) light changes from HomeKit would use the value set from the scene (until homebridge restarts).

Reset Transition Time to the default 0.4s automatically, 20ms (value of waitTimeUpdate in config.json) after a light state has been changed (so the entire scene would still use the Transition Time);

Implemented that (will be published in next release).

What would a scenario be to use Transition Time or rather how to integrate this feature?

For example, I created a Fade On and Fade Off scene in Eve (note I cannot set Transition Time to 300.0 seconds exactly):

Here's the homebridge -D log of applying the Fade Off scene:
[6/30/2017, 1:12:45 PM] [Hue] Living Room 4: homekit power changed from 1 to 0
[6/30/2017, 1:12:45 PM] [Hue] Living Room 1: homekit power changed from 1 to 0
[6/30/2017, 1:12:45 PM] [Hue] philipshue: homekit transition time changed from 0.4 to 269.3
[6/30/2017, 1:12:45 PM] [Hue] Living Room 6: homekit power changed from 1 to 0
[6/30/2017, 1:12:45 PM] [Hue] Living Room 2: homekit power changed from 1 to 0
[6/30/2017, 1:12:45 PM] [Hue] Living Room 3: homekit power changed from 1 to 0
[6/30/2017, 1:12:45 PM] [Hue] Living Room 5: homekit power changed from 1 to 0
[6/30/2017, 1:12:45 PM] [Hue] philipshue: hue bridge request #103: put /lights/4/state {"on":false,"transitiontime":2693}
[6/30/2017, 1:12:45 PM] [Hue] philipshue: hue bridge request #104: put /lights/1/state {"on":false,"transitiontime":2693}
[6/30/2017, 1:12:45 PM] [Hue] philipshue: hue bridge request #105: put /lights/6/state {"on":false,"transitiontime":2693}
[6/30/2017, 1:12:45 PM] [Hue] philipshue: hue bridge request #106: put /lights/2/state {"on":false,"transitiontime":2693}
[6/30/2017, 1:12:45 PM] [Hue] philipshue: hue bridge request #107: put /lights/3/state {"on":false,"transitiontime":2693}
[6/30/2017, 1:12:45 PM] [Hue] philipshue: hue bridge request #108: put /lights/5/state {"on":false,"transitiontime":2693}
[6/30/2017, 1:12:45 PM] [Hue] philipshue: hue bridge request #105: ok
[6/30/2017, 1:12:45 PM] [Hue] philipshue: reset homekit transition time from 269.3 to 0.4
[6/30/2017, 1:12:45 PM] [Hue] philipshue: hue bridge request #104: ok
[6/30/2017, 1:12:45 PM] [Hue] philipshue: hue bridge request #107: ok
[6/30/2017, 1:12:45 PM] [Hue] philipshue: hue bridge request #108: ok
[6/30/2017, 1:12:45 PM] [Hue] philipshue: hue bridge request #106: ok
[6/30/2017, 1:12:45 PM] [Hue] philipshue: hue bridge request #103: ok

The HomeKit actually issues the Transition Time change after the first two light changes, but because of waitTimeUpdate, transitiontime is included in the Hue bridge requests. You also see Transition Time is reset, after the bridge requests have been issued (but before all requests have returned).
HomeKit now shows the lights as Off (as does the Hue bridge), but they're still On.  After a while, the Hue bridge updates the light states when polling the lights.  Because the transition to Off is still underway, HomeKit now reports the lights as On, with reduced brightness:
[6/30/2017, 1:14:31 PM] [Hue] Living Room 6: light on changed from false to true
[6/30/2017, 1:14:31 PM] [Hue] Living Room 6: set homekit power from 0 to 1
[6/30/2017, 1:14:31 PM] [Hue] Living Room 6: light bri changed from 254 to 155
[6/30/2017, 1:14:31 PM] [Hue] Living Room 6: set homekit brightness from 100% to 61%
...
[6/30/2017, 1:14:36 PM] [Hue] Living Room 5: light on changed from false to true
[6/30/2017, 1:14:36 PM] [Hue] Living Room 5: set homekit power from 0 to 1
[6/30/2017, 1:14:36 PM] [Hue] Living Room 5: light bri changed from 254 to 151
[6/30/2017, 1:14:36 PM] [Hue] Living Room 5: set homekit brightness from 100% to 59%
...
[6/30/2017, 1:14:41 PM] [Hue] Living Room 4: light on changed from false to true
[6/30/2017, 1:14:41 PM] [Hue] Living Room 4: set homekit power from 0 to 1
[6/30/2017, 1:14:41 PM] [Hue] Living Room 4: light bri changed from 254 to 147
[6/30/2017, 1:14:41 PM] [Hue] Living Room 4: set homekit brightness from 100% to 58%
...
[6/30/2017, 1:14:46 PM] [Hue] Living Room 3: light on changed from false to true
[6/30/2017, 1:14:46 PM] [Hue] Living Room 3: set homekit power from 0 to 1
[6/30/2017, 1:14:46 PM] [Hue] Living Room 3: light bri changed from 254 to 144
[6/30/2017, 1:14:46 PM] [Hue] Living Room 3: set homekit brightness from 100% to 57%
...
[6/30/2017, 1:14:51 PM] [Hue] Living Room 2: light on changed from false to true
[6/30/2017, 1:14:51 PM] [Hue] Living Room 2: set homekit power from 0 to 1
[6/30/2017, 1:14:51 PM] [Hue] Living Room 2: light bri changed from 254 to 140
[6/30/2017, 1:14:51 PM] [Hue] Living Room 2: set homekit brightness from 100% to 55%
...
[6/30/2017, 1:15:06 PM] [Hue] Living Room 1: light on changed from false to true
[6/30/2017, 1:15:06 PM] [Hue] Living Room 1: set homekit power from 0 to 1
[6/30/2017, 1:15:06 PM] [Hue] Living Room 1: light bri changed from 254 to 126
[6/30/2017, 1:15:06 PM] [Hue] Living Room 1: set homekit brightness from 100% to 50%

At the next polling cycle, the brightness is adjusted:
[6/30/2017, 1:16:51 PM] [Hue] Living Room 6: light bri changed from 155 to 26
[6/30/2017, 1:16:51 PM] [Hue] Living Room 6: set homekit brightness from 61% to 10%
...
[6/30/2017, 1:16:56 PM] [Hue] Living Room 4: light bri changed from 147 to 18
[6/30/2017, 1:16:56 PM] [Hue] Living Room 4: set homekit brightness from 58% to 7%
[6/30/2017, 1:16:56 PM] [Hue] Living Room 5: light bri changed from 151 to 22
[6/30/2017, 1:16:56 PM] [Hue] Living Room 5: set homekit brightness from 59% to 9%
...
[6/30/2017, 1:17:01 PM] [Hue] Living Room 3: light bri changed from 144 to 15
[6/30/2017, 1:17:01 PM] [Hue] Living Room 3: set homekit brightness from 57% to 6%
...
[6/30/2017, 1:17:06 PM] [Hue] Living Room 2: light bri changed from 140 to 11
[6/30/2017, 1:17:06 PM] [Hue] Living Room 2: set homekit brightness from 55% to 4%

Until the transition has finished, and the lights are reported as Off:
[6/30/2017, 1:17:21 PM] [Hue] Living Room 1: light on changed from true to false
[6/30/2017, 1:17:21 PM] [Hue] Living Room 1: set homekit power from 1 to 0
[6/30/2017, 1:17:21 PM] [Hue] Living Room 1: light bri changed from 126 to 1
[6/30/2017, 1:17:21 PM] [Hue] Living Room 1: set homekit brightness from 50% to 0%
...
[6/30/2017, 1:19:07 PM] [Hue] Living Room 6: light on changed from true to false
[6/30/2017, 1:19:07 PM] [Hue] Living Room 6: set homekit power from 1 to 0
[6/30/2017, 1:19:07 PM] [Hue] Living Room 6: light bri changed from 26 to 1
[6/30/2017, 1:19:07 PM] [Hue] Living Room 6: set homekit brightness from 10% to 0%
...
[6/30/2017, 1:19:12 PM] [Hue] Living Room 5: light on changed from true to false
[6/30/2017, 1:19:12 PM] [Hue] Living Room 5: set homekit power from 1 to 0
[6/30/2017, 1:19:12 PM] [Hue] Living Room 5: light bri changed from 22 to 1
[6/30/2017, 1:19:12 PM] [Hue] Living Room 5: set homekit brightness from 9% to 0%
...
[6/30/2017, 1:19:17 PM] [Hue] Living Room 3: light on changed from true to false
[6/30/2017, 1:19:17 PM] [Hue] Living Room 3: set homekit power from 1 to 0
[6/30/2017, 1:19:17 PM] [Hue] Living Room 4: light on changed from true to false
[6/30/2017, 1:19:17 PM] [Hue] Living Room 4: set homekit power from 1 to 0
[6/30/2017, 1:19:17 PM] [Hue] Living Room 4: light bri changed from 18 to 1
[6/30/2017, 1:19:17 PM] [Hue] Living Room 4: set homekit brightness from 7% to 0%
...
[6/30/2017, 1:19:22 PM] [Hue] Living Room 2: light on changed from true to false
[6/30/2017, 1:19:22 PM] [Hue] Living Room 2: set homekit power from 1 to 0
[6/30/2017, 1:19:22 PM] [Hue] Living Room 2: light bri changed from 11 to 1
[6/30/2017, 1:19:22 PM] [Hue] Living Room 2: set homekit brightness from 4% to 0%
[6/30/2017, 1:19:22 PM] [Hue] Living Room 3: light bri changed from 15 to 1
[6/30/2017, 1:19:22 PM] [Hue] Living Room 3: set homekit brightness from 6% to 0%

Another fun fact: of you set Transition Time to 0.0s, and then recall a scene that turns on 6 lights, you notice the lights turning on separately, quickly after another.  With the default 0.4s Transition Time, the lights appear to fade on simultaneously.
When you set Transition Time manually (from Eve, not from a scene).  It stays on the new value, until you recall a scene, or set a light state manually.

Expose Transition Time as a string?

No go.  Works for setting it manually, although Eve doesn't show the value while editing (on my old iPhone 5s, which I use for testing).  However, Eve won't allow me to include it in a scene.

This is so amazing just by reading your lines. WOW
When I'm at home this Weekend I definitely check things out.
But as I mentioned earlier and as I understand from the description, I now have to set in the config.json the "lights": true
But at the moment I expose the lights native from the hue bridge/app.
I have to change this somehow. Sorry I'm a bit slow on the uptake. I'm having a blonde moment :-)

That's OK, I used to be blond (back in the days when I had more fun...)
Yes, you would need to expose the lights through homebridge-hue to use Transition Time.  Technically, you can continue to expose them by the Hue bridge, but each light would appear twice in HomeKit.  I stopped using the HomeKit feature of the Hue bridge long ago.  The only thing I miss is the feature to copy room assignments from the Hue bridge to HomeKit, every other month or so, when I need to reset my entire HomeKit configuration.

Well... The wisdom comes, the full blond hair goes. 😬 I can tell you a thing or two about it.
Okay.. so have to be brave and do what? How would I remove the hue lights from HomeKit but not the bridge? I'm a bit scared about doing this. I have 14 Lights and sometimes this was the only thing that works wehen the Raspberry with Homebridge was not working.
But I see much more and endless possibilities with your plugin. Now and the days who come.
You have to admit, this was you plan the whole time to get me switched completely to your plugin. 😉

You can admit and tell the truth, this was you plan the whole time to get me switched completely to homebridge-hue.

You found out my plan to conquer the world through homebridge-hue!  Now I need a new plan for world domination ;-(

How would I remove the hue lights from HomeKit but not the bridge?

You don't need to change the Hue bridge configuration.  Just remove the Hue bridge from HomeKit (in Home, hold the bridge tile with the same triangle-like symbol as homebridge and scroll down), and the lights are removed from HomeKit as well.  The Hue app remains fully functional, as do any other apps making use of the Hue API.
Re-pair the Hue bridge with HomeKit to expose the lights once again through the Hue bridge.

OMG I did it. YOU did it. 😉 I removed the Hue bridge from HomeKit.
Thanks for your reassurance. Everything works well. 💡👍🏻
All lights are there and the Test Scene I created with a few lights with transition time to 349.0s switched slowly after 5 minutes to blue. Now I can configure my morning wake-up routine all in Eve and with HomeKit. This is so cool and fantastic what you created. 🏆
And my "wish" was just 3 days ago. Thank you very much.

Today homebridge did not respond anymore.
I found this in the log as the last entry.
After stop and start homebridge,
sudo systemctl stop homebridge
sudo systemctl start homebridge
everything seems to work okay. I'll have an eye on that.
-- Logs begin at So 2017-07-02 00:16:11 CEST. --
Jul 02 00:31:26 raspberrypi homebridge[512]: [2017-7-2 00:31:26] [Hue] Philips hue: hue bridge request #426: get /config
Jul 02 00:31:26 raspberrypi homebridge[512]: [2017-7-2 00:31:26] [Hue] Philips hue: hue bridge communication error ETIMEDOUT
Jul 02 00:31:32 raspberrypi homebridge[512]: [2017-7-2 00:31:32] [Hue] Philips hue: hue bridge request #427: get /config
Jul 02 00:31:32 raspberrypi homebridge[512]: [2017-7-2 00:31:32] [Hue] Philips hue: hue bridge communication error ESOCKETTIMEDOUT
Jul 02 00:31:32 raspberrypi homebridge[512]: [2017-7-2 00:31:32] [Hue] Philips hue: hue bridge request #428: get /config
Jul 02 00:31:32 raspberrypi homebridge[512]: [2017-7-2 00:31:32] [Hue] Philips hue: hue bridge communication error ESOCKETTIMEDOUT
Jul 02 00:31:33 raspberrypi homebridge[512]: [2017-7-2 00:31:33] Changed occupancy state for <IP_ADDRESS> to true. Last successful ping 2017-07-02T00:31:33+02:00 , last webhook none .
Jul 02 00:31:34 raspberrypi homebridge[512]: [2017-7-2 00:31:34] [Hue] Philips hue: hue bridge request #429: get /config
Jul 02 00:31:34 raspberrypi homebridge[512]: [2017-7-2 00:31:34] [Hue] Philips hue: hue bridge communication error ESOCKETTIMEDOUT
Jul 02 00:31:42 raspberrypi homebridge[512]: [2017-7-2 00:31:42] Changed occupancy state for <IP_ADDRESS> to true. Last successful ping 2017-07-02T00:31:42+02:00 , last webhook none .

ETIMEDOUT and ESOCKETTIMEDOUT typically indicate hickups in the network between homebridge and the Hue bridge, see issue #15.  Make sure you connect the Hue bridge and the Raspberry Pi running homebridge (and the AppleTV as HomeKit Hub) by wired Ethernet, not by WiFi or Powerline LAN.

Okay, thanks @ebaauw
Configurations is the same since years. ALL WiFi.
Apple TV, Raspberry and actually all devices here at home. Except the hue bridge which is connected directly to the Fritz!Box Cable Router/Modem. Didn't had any problems in the past.
Ethernet is no Option here at home.
But as mentioned, I'll have an eye on this if there is something strange with homebridge-hue now.

Hello @ebaauw i have a question. I can‘t set a Scene two times behind each other? I must use a reset Scene between? (i use the Raspbee Gateway)

Are you referring to setting a HomeKit scene in Apple’s Home app?  That seems to be limitation of the app.  In other HomeKit apps (e.g. Eve) this is possible.

Yes, with HomeKit. If i activate a Scene with Custom transition Time and turn the light off, the Scene (this transition Time) don’t work anymore. I must bring the light to an other State (other brightness, or other color), Then the Scene is working again.

I notices that you have the room where the Transition option can be selected, has to be the first in the row of rooms. Meaning my default room where the bridge is place and transition time is set, is on top. In a Scene it is then on first place (eve App) and then the lights are following. Buy doing this, transition time is recognized ad working here.

I don't think order of characteristics in a HomeKit scene is guaranteed - it's just how the app displays them.
After receiving a notification from HomeKit that a characteristic has changed, homebridge-hue delays sending the bridge request for a light or group by 20ms (waitTimeUpdate in config.json), to collect multiple changes in a single Hue bridge API call.  Transition Time is only reset 20ms (again, waitTimeUpdate) after the first request is sent.
As long as the characteristics in a scene are processed within these 40ms, it shouldn't matter in which order HomeKit issues the characteristics when recalling a scene.
By running homebridge -D, you should be able to check whether transitiontime is included in the bridge requests.  If it isn't (gen1 bridge?), you might want increase waitTimeUpdate.

Does this work on Raspbee as well? I set the Transition Time in Eve and I can see this command in homeridge-hue message, but the light still turns on instantly.

I try several configurations and find how it works. As you mentioned in previous comments, you need two separate scenes to make Hue-like wake up work: first turn the light on and set the brightness at 0%, and then set the transition time and set brightness to 100%.
I think the reason that single scenario doesn't work is because that if the light is not on before you set the transition time, it may automatically restore your previous setup at power off, which is 100% in my default cases. So, no transition will happen.

I didn't get, why do we need to turn the lights on at 0% brightness before setting the scene with transition time? Are you automating this using hb automation switches or how? :)

Am I right that transitiontime only works (appears as an option in the Eve app) if the Hue lights are exposed to HomeKit via Homebridge-Hue and not via the Hue bridge?

From what I understand that's correct however you can expose both ways at
the same time. You can whitelist the lights (in the hue bridge) you want to
use with transitiontime and this way only part will be exposed, then put
those homebridge duplicates into 'automation' room in HomeKit and use them
for automation purposes only.
pon., 30 lis 2020 o 14:33 JCHH<EMAIL_ADDRESS>napisał(a):

Am I right that transitiontime only works (appears as an option in the
Eve app) if the Hue lights are exposed to HomeKit via Homebridge-Hue and
not via the Hue bridge?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/ebaauw/homebridge-hue/issues/130#issuecomment-735788339,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AINHNWKWLZLH4QOBHMZIBXLSSONLRANCNFSM4DQ5DISA
.

cheers!


[Doc] [5.7.0] configuring UseEntityIdAsIssuerInOidcDiscovery property

The  identity.xml file found in the <IS_HOME>/repository/conf/identity/ folder does not include the following property
Therefore, we need to correct documentation [1] as follows.
1.Add the following property to the identity.xml file resides in /repository/conf/identity directory.
Under the <OAuth> tag.
<!-- If enabled, resident Idp entity id will be honoured as the issuer location in OpenId Connect Discovery -->
<UseEntityIdAsIssuerInOidcDiscovery>true</UseEntityIdAsIssuerInOidcDiscovery>

[1] https://docs.wso2.com/display/IS570/OpenID+Connect+Discovery

This issue is being closed due to extended inactivity. Please feel free to reopen it if further attention is needed. Thank you for helping us keep the issue list relevant and focused!


Work on the readme/documentation for the project

Write an introduction about our project for users and also for fellow programmers explaining the structure of our code.

Wrote a very basic introduction ✅


govuk checkboxes component has invalid value set for test

Description of the issue
We have recently revised some of our patched tests in play-frontend-hmrc which integrate with govuk components. We have found an example that is missing a flag. The HTML example specifies that the red item has a checked attribute but the first item for the checkbox should also then be marked as "checked": true here.
UPDATE
I found a few more examples that require the "checked": true property on the relevant item.

issue 1
issue 2
issue 3

Environment (where applicable)

GOV.UK Frontend Version: v4.3.1

Hi @kyle-bowden. Thanks for raising this issue, however this behaviour is intentional.
These examples are intended to test the values attribute, which is an option at the root of the macro call that allows teams to set the checkbox values as a single array instead of using checked. You can read about it and how it interacts with the checked value on individual items in the nunjucks macro guidance. This feature was introduced in https://github.com/alphagov/govuk-frontend/pull/2616
To illustrate this with the initial example, this scenario is codified in the yml file containing the checkbox API docs and is used in the associated test. The intended behaviour here is that we can pass what is checked in the checkbox array via values, in this case red and green, but the intended behaviour is that the value of checked, if specified, overrides values.
With the above in mind, I'm going to close this issue. We hope you will consider contributing again in future.


Feature request

Hi,
Thanks again for your help the other time.
I was wondering, since you succeeded to make the option port available through wireguard, if we would be able to to activate the option dedicated ip?
I didn't look into the code actually just yet of your script so I don't know if for the port forwarding feature you are relying to the variable PF which is available in the OpenVPN script of PIA. So maybe we need for such a variable to exist for dedicated ip. But I m sure you will tell me if that s possible or not.
Thanks in advance

Hey,
I'd have to check, but I don't have a Dedicated IP to actually test with, but I believe when you order a Dedicated IP, you get a different set of login details, although I'm not sure if it's a whole region or for a certain server. So are you able to provide screenshots of what happens when you buy a Dedicated IP (blank out parts of course to jot identify yourself).
If it's for say any server in the UK London region, then longs you have the region set and the new login details. The dedicated IP will work, and port forwarding. Last I asked about Dedicated IPs and port forwarding, the mechanism is the same still, I believe they said.

Just had a look, looks like they give a Dedicated IP token, after selecting the region you want the dedicated IP in. I'll have to do some research in how you then use the token to connect with the PIA client.
Issue is I don't have a dedicated IP token to test this with.

After some investigation, manual connections for using a Dedicated IP (DIP) is currently not documented, once this is documented I shall be able to look in to developing the script to cater for using a DIP. Probably won't take too long to add this feature but shall need to purchase a DIP for development testing. Otherwise I'll need someone else to test.

I have a dedicated op a and so a token for Germany regio. So I will test it without a problem.
I thought you were using the variable they are documenting in the OpenVPN configuration for the port forwarding but since you didn t tell it so I guess not.
I m asking questions to support for the moment.

I'll wait until they document the connection and then go from there, encase anything for WireGuard connection is done differently.

Spoke to @boistordu, via another platform and confirmed working.


test: allow compact diff for test failures

Motivation
Debug the test failures more easily.
Description

Allow to set the compact diff through env variables.

Steps to test or reproduce

Run all tests

:tada: This PR is included in v1.19.0 :tada:


feat: [maps-mapsplatformdatasets] new module for maps-mapsplatformdatasets

Supersedes previous attempt in #9119.
Initial generation for new mapsplatformdatasets client library:
python3.9 generation/new_client/new-client.py generate \
  --api_shortname=maps-mapsplatformdatasets \
  --proto-path=google/maps/mapsplatformdatasets \
  --name-pretty="Maps Platform Datasets API" \
  --product-docs="https://developers.google.com/maps/documentation" \
  --api-description="The Maps Platform Datasets API enables developers to ingest geospatially-tied datasets
    that they can use to enrich their experience of Maps Platform solutions (e.g. styling, routing)." \
  --cloud-api=false \
  --distribution-name="com.google.maps:google-maps-mapsplatformdatasets"

"snippet-bot check" fails because this is not Cloud product. It's fine.


"Collision Groups" handling Collision Layers & Masks

This is an ongoing idea that I am building on, and I believe this have the potential to simplify collision layers and masks - for intermediate and beginners alike.
While I was working on a tutorial explaining Collision Layers and Masks thoroughly, I realize that a lot of the work consists of having to manage and setting up the individual collision layers and masks.
While I realize we have a "Groups" tab that allows us to set groups, it does not directly affect collision layers and masks without going into gdscript of each object and managing collisions from there.
You could argue that you could check which group "I am on" and set layers and masks from code - and I am sure that would work, but that is not simple or effective - at least not compared to this possible solution.
For example, when working with layers and masks I usually plan ahead of what types of objects will be in which layers and interact with which masks. This is an example of my note:
Collision Layers | Masks
1 - Static Objects (immovable objects, floor, roof, etc.) <-> 2, 3, 4
2 - Friendly Rigid Bodies (crates, player, etc.) <-> 1, 2, 3, 5
3 - Enemy Rigid Bodies <-> 1, 2, 4
4 - Player Bullets  <-> 1, 3
5 - Enemy Bullets <-> 1, 2
I realize that keeping this consistent can be incredibly awkward. Having to go back to my list every time I create new objects.
After all, for every, single, object I make; I would have to go into the inspector and manually set individual layers and masks.
So this idea hit me; Why not create a "Collision Group" system, that allows us to setup individual collision groups for those masks and layers?
Imagine having an simple drop down menu in place of Collision Layers and Masks that allows you to set a new Group or choose an existing group.
When creating a new group, you set a name for it and select which layer it is on and what it with collide with (masks).
Some of the best advantages with this, is that if you later decide that all static objects should also collide with objects on layer 6, you just edit the group instead of doing inside every single object and manually adding 6 to them.
Group name: "Static Objects" <---- This is what you set on new objects that are static
Layer: 1
Mask: 2,3,4
Group name: "Friendly Rigid Bodies" <---- Easy setup of friendly rigidbodies such as player, crates, etc.
Layer: 2
Mask: 1,2,3,5
Lastly I should add; you should not be forced to setup a group - you should still be able to just directly set layers and masks without defining a group.
Thoughts? Feelings? Any flaws that I have not foreseen about this? ;)

I like the idea, and add to this the new named layers, the group setup could be a lot more user friendly.
This could be made with a plugin too, a panel to set the groups and add selected node to a group.

What about creating a new Resource type PhysicMaterial that you can reference on PhysicObjects? It would do all of what you ask, though it needs to be created indeed.
Otherwise you can already do all this by using scene inheritance/composition.

bump Yes, I was thinking of something like this too, but instead if combining it with Layers/Masks it should replace it. Yeah it would need some changes of how collisions works but as long as Group Collision exists, Layers/Masks will not be needed because it will be easier to manage and straightforward for new users.
I'll explain how I have it in mind, because I don't think I'm in the same page as @ivanskodje
Lets say on a platformer game you have 5 objects and you add them to certain groups as you would do normally:

Player is on "player" group
Block is on "solids" group
IceBlock is on "solids" "Ice_blocks" groups
SafeBlock on "barrier" group
Enemy is on "baddies" and "solids" groups

At this point nothing is colliding with anything so you HAVE to set them to a group in order to set it to collide with something later. I don't know if this helps performance but its seems like it should too, no idea. anyway...
if you want a certain body to collide with something you have to set it to collide with a group or multiple groups, ex:

Player will collide with "solids" group (Block, IceBlock, Enemy)
Enemy will collide with "solids" and "barrier" group (Block, IceBlock, SafeBlock, Enemy)

you set it on the UI as you said with a drop-down list BUT instead you can select multiple groups with a checkmark at the side of the group name, on script you could set it with something like set_collision_with("solids"). would be cool if this function had arrays support so you can do something like _Enemy.set_collision_with(["solids","barrier"]) and set collisions with a single line of code.
if you want the Player/Enemy to act differently with an IceBlock then you can check with something that already exists: get_collider().is_in_group("ice_blocks") if the Block is touching is in the "ice_blocks" group, if its true then this will make the Player/Enemy slide around when touching these IceBlocks (same if player is touching something in the "baddies" group). This also can be seen as a sort of PhysicMaterial
now, for example, since Block is not set to collide with any group this mean Block will not collide with anything and can't check what is colliding with it, so its just there, but as long as its there, then Player and Enemy will have something to collide with, Blocks can have values in a script so other Scenes can get values from the Blocks though.
again this would require to change how collisions works a little bit but I don't know, I don't think Collision Layers & Masks are a good way of handling collisions, but thats me.

3.1 introduced a convenient dropdown menu with layer names. While you still have to manually check every bit, it's easier to label them and know what to click.

Would that be enough to resolve this issue, or a proper "groups" are a must-have?

I think we can consider this solved by named layers.
If more is needed, please open a new proposal on godot-proposals.


after fishing once the bot auto exit the fishing menu

after fishing once fish the bot stops and quit the fishing

provide more info. This report is so useless.
Join this discord server and look for fishing help since this looks like a user issue

Sorry i got it to work you can place it as solved


Remove Ruby 2.5

Motivation for this change
Ruby 2.5.x will reach its support end-of-life on March 30 of this year, so the next stable release of nixos shouldn't include it.
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[ ] NixOS
[x] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[x] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
~[ ] Ensured that relevant documentation is up to date~
[x] Fits CONTRIBUTING.md.

This can go straight to master.


TS-5060: Fix DNAME support for OSX and FreeBSD.

This PR fixes the build errors found for OSX caused by removing nameser_compat.h in the PR that adds DNAME support.  nameser_compat.h is being added back in and T_DNAME is defined in lib/ts/ink_resolver.h for OSX and FreeBSD.

[approve ci]

FreeBSD build successful! See https://ci.trafficserver.apache.org/job/Github-FreeBSD/1251/ for details.

Linux build successful! See https://ci.trafficserver.apache.org/job/Github-Linux/1146/ for details.

FreeBSD build successful! See https://ci.trafficserver.apache.org/job/Github-FreeBSD/1252/ for details.

FreeBSD build successful! See https://ci.trafficserver.apache.org/job/Github-FreeBSD/1253/ for details.

Linux build successful! See https://ci.trafficserver.apache.org/job/Github-Linux/1148/ for details.


feat

:recycle: Update dependencies
:recycle: Change uuid (Date => crypto.randomUUID)
:recycle: import React
:recycle: Remove queue
:recycle: seperate timer, swipe logic to custom hook
:wrench: Add new example project
:recycle: implement example2
:test_tube: Add test for swipe, timer hooks
:recycle: Update local  package to public package
:recycle: update dependency
:recycle: Update README

:tada: This PR is included in version 1.1.1 :tada:
The release is available on:

GitHub release
npm package (@latest dist-tag)

Your semantic-release bot :package::rocket:


Release v0.10.0.post1

Proposed changes
This PR bumps the open-autonomy to latest post release and enables the usage of ACN on the oracle agent
Fixes
If it fixes a bug or resolves a feature request, be sure to link to that issue.
Types of changes
What types of changes does your code introduce? (A breaking change is a fix or feature that would cause existing functionality and APIs to not work as expected.)
Put an x in the box that applies

[ ] Non-breaking fix (non-breaking change which fixes an issue)
[ ] Breaking fix (breaking change which fixes an issue)
[ ] Non-breaking feature (non-breaking change which adds functionality)
[ ] Breaking feature (breaking change which adds functionality)
[ ] Refactor (non-breaking change which changes implementation)
[ ] Messy (mixture of the above - requires explanation!)

Checklist
Put an x in the boxes that apply.

[ ] I have read the CONTRIBUTING doc
[ ] I am making a pull request against the main branch (left side). Also you should start your branch off our main.
[ ] Lint and unit tests pass locally with my changes
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] I have locally run services that could be impacted and they do not present failures derived from my changes

Further comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

So I just noticed. The polygon service is missing tendermint_p2p_url overrides, with env variables, which is required by Propel. To avoid having another release for this, let's update it here.

@angrybayblade Shouldn't it be Release v0.10.0.post2?

@angrybayblade Shouldn't it be Release v0.10.0.post2?

The autonomy release was post2, but the last price oracle release was 0.10.0 so the next one should be post1


Add ArrayLists factory class and optimize copyOf(E[] es)

Sometimes, I directly create ArrayLists from arrays and I am forced to use a builder. The proposed new ArrayLists.of|copyOf methods fix that.
Also, all the other types of lists have a direct XXXList.builder() whereas for ArrayList you are force to do ArrayList.<E>factory().newBuilder() which doesn't play really nice with type inference of completion in IntelliJ IDEA.

Thanks - looks good.


Starting server using maven central based dependencies

I am trying to start conductor using maven central based dependencies following the guidelines, it is giving exception as given below.
I tried to force update mine POM in Project, still facing same exception.
"Missing artifact com.netflix.conductor:conductor-server-all:jar:1.6.0" ,  which clearly dipicts that corresponding artifact is missing.
How can i achieve this task, can any person help me ?

Please follow the instructions here for starting the server.


Allow serializing feature for no-std environments?

I noticed that the serializing feature does not only need serde but also std.  I couldn't find the reason for it in the code, so my question is if serializing would also work without std?

I think, if I remember correctly, the derive macros were using std for something, but it has been a while since I last checked. I'm happy to remove that requirement if it's no longer necessary, but it may perhaps be a 0.8 change. It would remove observable features for someone who only explicitly uses serializing. 🤔

I checked the documentation the other day and there should not be a requirement on std anymore. This can be done in a non-breaking way by deprecating serializing and using serde as the feature name. I would like to do that regardless.


nixos-generate-config: use uuid instead of device if possible

Issue description
I mounted a btrfs partition (raid1 of 2 devices) and generated hardware config again.
mount /dev/disk/by-label/data /data
nixos-generate-config

device is /dev/sdb instead of it's uuid. so i will have problems when that changes...
  fileSystems."/" =
    { device = "/dev/disk/by-uuid/ed270d50-b685-4d07-a287-c425dc3712a4";
      fsType = "ext4";
    };

  fileSystems."/data" =
    { device = "/dev/sdb";
      fsType = "btrfs";
    };

  swapDevices =
    [ { device = "/dev/disk/by-uuid/5296e692-60b2-4137-93db-8ea08261246a"; }
    ];

Steps to reproduce
Technical details

System: NixOS 17.03.1316.412b0a17aa (Gorilla)
Nix version: nix-env (Nix) 1.11.10
Nixpkgs version: "17.03.1316.412b0a17aa"
Sandboxing enabled: build-use-sandbox = true

This is still happens on current nixos-20.03 with multi-device btrfs:

  fileSystems."/btrfsy-biscuit-base/random" =
    { device = "/dev/sdb";
      fsType = "btrfs";
      options = [ "subvol=random" ];
    };

nixos-generate-config seem to still ignore label and doesn't have cli option to override it. I tried to change in /fstab manually but change was ignored.

nixos-generate-config seem to still ignore label and doesn't have cli option to override it.

@roberth @edolstra when you have a moment, please take a look at my fix for the label issue: #339995
Thank you!


Add Code of Conduct Linter

Closes #79 & #67
I did this PR as someone new to Forkability, but feel free to close if you wanted someone new to programming as a whole. Just trying to get a feel for node and this project :)
:christmas_tree: :santa:

Looks great.
Being new to node and the project is good enough for this one. I expanded on that a little in #79

Thank you very much!!
:tada:

Wahoo!!

Legend, @Charlotteis! :christmas_tree: great PR-ing!


BlackboxFunction interface implementation missing for ZDT1

https://github.com/nicolaipalm/paref/blob/c7293dba2cd4d5b9c61ba19c77e1a93204a7adca/examples/blackbox_functions/two_dimensional/zdt1.py#L8-L8
The ZDT1 class doesn't implement the BlackboxFunction Interface functions.

ZDT1 is now implemented into the BlackboxFunction interface.


Using Sass Placeholders for proper use of @extend

this PR exposes all grid related class (.row, .col, s1-12, m1-12, l1-12) as Sass Placeholders:
%row, %l17...
see this http://12devs.co.uk/articles/semantic-grids-with-sass-loops-and-silent-placeholders/ for a proper explanation
this avoids extremely large selector chains when using the materialize grid classes in your sass files:
//bad
.my-row {
  @extend .row;

  .my-col {
    @extend .col;

    &.my-s7 {
       @extend .s7;
    }
  }
}

//good
.my-row {
  @extend %row;

  .my-col {
    @extend %col;

    &.my-s7 {
       @extend %s7;
    }
  }
}

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue).
[x] New feature (non-breaking change which adds functionality).
[ ] Breaking change (fix or feature that would cause existing functionality to change).

Checklist:

[x] I have read the CONTRIBUTING document.
[x] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[ ] I have added tests to cover my changes.
[x] All new and existing tests passed.

There is an error. Please keep an eye on the tests.

@DanielRuf fixed it, creating PRs through the github is not always cool ;)


Add workaround for bad govee data

Thanks. There is a filter on the data length in the init.py as well for Govee, so is this bad Govee data always of a fixed length? We will have to change this file as well, I suppose.

so is this bad Govee data always of a fixed length?

It appears to be.  It just the extra 25 bytes glued on to the end

Ok, which Govee is it that shows this behavior?

At least the H5075 and H5177 both do it

2022-07-10 12:06:06.510 DEBUG (MainThread) [homeassistant.components.govee_ble.data] Parsing Govee BLE advertisement data: BluetoothServiceInfo(name='GVH5177_2EC8', address='B16C51A4-061F-7952-76EF-1F4B9C1EE77B', rssi=-50, manufacturer_data={1: b'\x01\x01\x03d\xe8dL\x00\x02\x15INTELLI_ROCKS_HWQw\xf2\xff\xc2'}, service_data={}, service_uuids=['0000ec88-0000-1000-8000-00805f9b34fb'])

raw is b'\x00\x00\x01\x00\x01\x01\x03d\xe8dL\x00\x02\x15INTELLI_ROCKS_HWQw\xf2\xff\xc2

Ok, I'll just modify all govee sensors to also accept the length + 25.


RIP-9[modify punctuation]

What is the purpose of the change
XXXXX
Brief changelog
XX
Verifying this change
XXXX
Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

[x] Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
[x] Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
[x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
[x] Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
[x] Run mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test  to make sure integration-test pass.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

Coverage decreased (-0.04%) to 48.989% when pulling 558ee73ce661cbe6de30978a5e4437e1cc8e961f on yuanchangjin:develop into 4f8d96c4a753d24dc2c2e8933d5d2908821f922f on apache:develop.

Could you please pull the latest code and rerun travis again. @yuanchangjin


libevent fails to build in linux (WSL)

Package: libevent:x64-linux
Vcpkg version: 0.0.110-unknownhash

CMake Error at scripts/cmake/vcpkg_fixup_cmake_targets.cmake:42 (message):
  'vcpkg/packages/libevent_x64-linux/debug/cmake' does not exist.
Call Stack (most recent call first):
  ports/libevent/portfile.cmake:34 (vcpkg_fixup_cmake_targets)
  scripts/ports.cmake:72 (include)

поддтверждаю
-- Applying patch /root/tmp/vcpkg/ports/libevent/fix-target-files.patch
-- Applying patch /root/tmp/vcpkg/ports/libevent/fix-target-files.patch done
-- Configuring x64-linux-dbg
-- Configuring x64-linux-dbg done
-- Configuring x64-linux-rel
-- Configuring x64-linux-rel done
-- Build x64-linux-dbg
-- Build x64-linux-dbg done
-- Build x64-linux-rel
-- Build x64-linux-rel done
CMake Error at scripts/cmake/vcpkg_fixup_cmake_targets.cmake:42 (message):
  '/root/tmp/vcpkg/packages/libevent_x64-linux/debug/cmake' does not exist.
Call Stack (most recent call first):
  ports/libevent/portfile.cmake:34 (vcpkg_fixup_cmake_targets)
  scripts/ports.cmake:72 (include)

Error: Building package libevent:x64-linux failed with: BUILD_FAILED

Just need to set EVENT_INSTALL_CMAKE_DIR to cmake

Just need to set EVENT_INSTALL_CMAKE_DIR to cmake

Does not fix the problem!


Themes demo error in documentation site

Hi ~
In the Themes demo page, page link
Not only click Tab will change theme.
But click checkbox will also trigger theme change.

If you look at themes.jsx, this happens because the onChange event handler is fired for any interactive change on the form (see this React doc).
See the onTabChange function. This can be easily fixed by keeping track of the current tabIndex and checking against the new tabIndex in this function (introduce an additional check so that theme changes only when tabIndex changes). So if you wanna take a shot at this, feel free to put in a PR.

@shaurya947  Thank you :)


WebApp missing supported resource types

The MODFLOW model instance is not listed as resource type that can be selected on the WebAPP edit page.  To replicate this issue, create a new web app resource, navigate to the edit page, and view the supported resource types list.  The ModflowModelInstance is not listed as an option.

merged and tested


4333 remove inventory items

Resolves #4333
Description
Definitely do not merge this.
This removes InventoryItems and all associated functionality, with the exception of the records themselves and the basic associations. It also removes Kit allocation and deallocation.
Need to get all tests passing, and then do some exhaustive manual testing afterwards.

@dorner " It also removes Kit allocation and deallocation."
Please tell me more about this --for instance,  does that mean that we should be able to handle donating kits now?

Pushed some fixes!

The kit stuff does seem to work.  I do not know what I was looking at.

@dorner   I'm seeing if you put two items that are the same in a purchase,  they stay as two lines in this branch,  whereas they are combined in main.     If I'm reading things correctly, it's been awhile since we've merged main into this.   Could we reasonably do that for final testing?

It's been merged!

Light testing finds no issues.


fix: restore docs.scss to resolve docs links overlapping

Restore docs.scss to resolve version less than v1.9 docs links overlapping. The docs.scss was deleted in commit ae7e444

Local test result:

@mmaoyu Does this simply restore the css deleted in #156? Or are there any changes?

The diff from previous css looks empty, i'll go ahead and merge, thanks!


Indent on new line not working

Hi all,
For some reason, my "indent on new line" is not working when coding TypeScript (.ts and .tsx).
I'm using Atom 1.12.5 and atom-typescript 10.1.12.
Basically, if I type something like:
function blah() {

And hit return, it doesn't indent to the new line (it does auto complete the ending brace though).
I'm not sure if this is a config setting I'm missing, but I can't find anything.

Found the setting, nevermind.


Adding mediatypes

@apdavison could you or your team have a spot-check on these mediatypes? Just to make sure there are no systematic errors in the jsonlds. Thanks!

Possibly a bigger issue: shouldn't this PR be made against https://github.com/HumanBrainProject/openMINDS_instances ?
Or has the process been changed? @lzehl can you comment?

@apdavison there was an update on where to store the instances (announced via slack). Sorry if that got lost. I think I should do such announcements via email... We moved the instances to the corresponding metadata model repos (again) because they are version dependent, and we decided it is easier to handle them then directly within the corresponding version branch. If they are backwards compatible we should have them on all version branches of course (this might not yet be the case, I'm still organizing the cleanup). Another question though: how should we handle the openMINDS_instances GitHub? Should we delete it after making an announcement on the README or should we keep it?

@jagru20 & @apdavison for the potential duplicates: the extensions might not help very much to identify duplicates. On the one hand I expect that two versions of the "same format" will get separate entries, but would most likely have the same extension(s). On the other hand all the ambiguous extensions (e.g., csv, tsv, json, etc) which have one generic media type, but can have multiple content types for specific applications will pop up as well.

@jagru20 & @apdavison another question: what about the generic media types (csv, tsv, json, etc)? Should the "relatedMediaType" link to those also for the application specific content type? Or should we allow multiple content types for files, file bundles, and file repositories, so that they can link to the generic & the specific content type?

Where we have application-specific content types that are based on a more generic type, the generic type is generally indicated with a "+".
For example, for IPython/Jupyter notebooks the content type is "application/x-ipynb+json", so indicating that any application that can read JSON can open this file, although of course the full functionality is only available if the application can interpret the JSON as a Jupyter notebook.

@lzehl I think all three approaches would work, i.e.:

direct connection via "relatedMediaType"
direct connection via multiple "contentType"s
parse the content type name to use the "+"part

I don't have a strong preference, I have a weak preference for option 3.

@apdavison I agree. We can adopt later. But as a comment: I think 3 should be always used (based on the naming convention), and in addition we can introduce 1 or 2 (or 4: intro of property "parentMediaType").

@jagru20 do you need help for this PR ?

@lzehl sorry for the delay in this pr. Of course do the redundancies need to be eliminated. I think a little help would be quite useful here. I hope I understand the above discussion correctly when assuming that we add any relatey mediatypes at a later point in time?

@lzehl sorry for the delay in this pr. Of course do the redundancies need to be eliminated. I think a little help would be quite useful here. I hope I understand the above discussion correctly when assuming that we add any related media types at a later point in time?

@jagru20 yes the media types can be added later.

@jagru20 for the redundant entries: should we identify them within the review of this PR? this might be a bit cumbersome... in any case I maybe able to help you towards the end of this week.

I have prepared a commit, where I tried to eliminate the redundancies and keep as much as information as possible available.  Although I would prefer to hear @apdavison thoughts on the filename thing first, I can also just push it and we discuss that later as the essential information in the file contents is the same or extended.

@jagru20 one more thing I noticed: the blackrock formats need to be splitted I think into .ns2 - .ns6 and .nev...

@jagru20 one more thing I noticed: the blackrock formats need to be splitted I think into .ns2 - .ns6 and .nev...

you mean splitting them into separate contenttypes instead of listing the separate extensions in the application/vnd.blackrockmicrosystems.cerebus?

@jagru20 one more thing I noticed: the blackrock formats need to be splitted I think into .ns2 - .ns6 and .nev...

you mean splitting them into separate contenttypes instead of listing the separate extensions in the application/vnd.blackrockmicrosystems.cerebus?

@jagru20 yes. At least nev vs nsX need to be different content types because they need different loading routines. For the nsX we can discuss. @apdavison what is your though about this ?

My understanding is that a given recording session is typically split over a nev and one or more nsX files with the same file name prefix, so you need all files to correctly load the data. This is how Neo handles them in any case: see https://github.com/NeuralEnsemble/python-neo/blob/master/neo/rawio/blackrockrawio.py
Probably we should have a separate content type for each, plus maybe a content type applied to a FileBundle that would represent the group of files belonging to the same recording.

@apdavison sounds good. One contentType for each and one for "blackrock parallel recordings".

Sorry for double asking but "for each" in this case means one for all .nsx files, listing their possible extensions and one for .nev, right? Sorry for double asking. Otherwise, this would not make sense because, the loading routine for different .nsx files would only differ depending on their header contents right?

Sorry for double asking but "for each" in this case means one for all .nsx files, listing their possible extensions and one for .nev, right? Otherwise, this would not make sense because, the loading routine for different .nsx files would only differ depending on their header contents right?

@apdavison please correct me if I'm wrong: we would need contentTypes for each nsX and one for nev. If I remember correctly the nsX differ in their structure, because they are supported by different versions? @jagru20 sorry for the confusion, but it's too long ago that I worked with those files... In addition, Andrew suggested to have a blackrock contentType for parallel recordings (for a file bundle) that can indicate when several nsX and a nev are actually recorded in parallel and should be looked at together.


Test

Have a look at the predict function, has some error with multiclassification and multilogits

looking at the function and trying for errors


manpages: fixes and rewording

[x] Have you followed the guidelines in our Contributing document?
[x] Have you checked to ensure there aren't other open Pull Requests for the same change?
[x] Have you added an explanation of what your changes do and why you'd like us to include them?
[n/a] Have you written new tests for your changes? Here's an example.
[n/a] Have you successfully run brew style with your changes locally?
[x] Have you successfully run brew tests with your changes locally?

Mostly cleanup following the switch from comment-based manpage generation, plus fixes for any documentation or grammatical issues I could find, followed by some rewording for flow and readability in places.

Great work as usual @EricFromCanada 👏


Added initial speed support for pedestrians in OSC

Description
Added initial speed support for pedestrians in OSC
Where has this been tested?

Platform(s): Ubuntu 16.04
Python version(s): 2.7
CARLA version: 0.9.9

Possible Drawbacks
None

This change is

So this doesn't make pedestrians start with an initial speed, correct? That will be implemented in the future, that's what you mean by "initial support"

So this doesn't make pedestrians start with an initial speed, correct? That will be implemented in the future, that's what you mean by "initial support"

After this review is merged, you can set an initial speed of a pedestrian.

Okay, I was confused by the walker controller as I haven't used it yet.


Kafka Supervisor bloats zk discovery path

After testing kafka supervisor for two days, I got more than 1000 index_kafka_* entries in the zk discovery path and they don't go away (i.e. even stopping the supervisor does not help)

@dclim Looks like this is coming from the Kafka index tasks announcing themselves with the chat handler provider – do you know if that's really necessary? IIRC the supervisor finds them without that, using the overlord's builtin task location finding stuff (which doesn't leave "presents" in ZK).

@sixtus thanks for the report

Answering my own question: yes, registering with the chat handler provider is necessary to expose the servlet. But, the provider should have an option on registration to opt of announcing. Realtime tasks still need to announce (for compat with older tranquillity versions) but Kafka tasks should never need to announce.

Can you hint me what to patch? I'd love to deploy this asap, but zk bloat is a show stopper.
Thanks!
Hagen

Am 12.08.2016 um 18:51 schrieb Gian Merlino<EMAIL_ADDRESS>Answering my own question: yes, registering with the chat handler provider is necessary to expose the servlet. But, the provider should have an option on registration to opt of announcing. Realtime tasks still need to announce (for compat with older tranquillity versions) but Kafka tasks should never need to announce.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

@sixtus if you aren't using tranquility (and therefore don't need service discovery to work there) then you should be able to comment out serviceAnnouncer.announce(node); and serviceAnnouncer.unannounce(makeDruidNode(service)); in ServiceAnnouncingChatHandlerProvider.java.

@gianm thanks Gian, I'll submit a patch for a SimpleChatHandlerProvider that doesn't do the unnecessary service discovery announcement.

@dclim IMO it'd be better to have a flag on register about whether or not announcing is needed; it's a little goofy, but it would let us hard-code "false" in Kafka index task and "true" in the Realtime task, meaning legacy tranquility and kafka indexing can co-exist in the same cluster. That'd help people migrate from the former to the latter.
That'd also mean the default behavior is better. we wouldn't want to switch the default chat provider away from the service announcing one, and if we don't do that, we'll have to have another step for Kafka indexing service users (set the chat handler to simple). That'd work but it's better to avoid extra steps if we can.

I think this is telling us that the chat handler provider is not a great abstraction. Combining service announcing and servlet registration was a bad idea, and we are needing to work around that now. So I think the goofiness is acceptable since it's really just working around the sins of our forebears.
Which I think is me since I think I made that thing in the first place :P

Hah, sounds good.

ruby-druid relies on brokers announcing themselves. The rest, I don't have nor care for, still on standalone rt.
I.e. if this doesn't break broker, I'll try on Monday.
Thanks for the quick help!
Hagen

Am 12.08.2016 um 19:42 schrieb Gian Merlino<EMAIL_ADDRESS>@sixtus if you aren't using tranquility (and therefore don't need service discovery to work there) then you should be able to comment out serviceAnnouncer.announce(node); and serviceAnnouncer.unannounce(makeDruidNode(service)); in ServiceAnnouncingChatHandlerProvider.java.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

@sixtus It won't break the broker, this will only affect task announcement.


settings: Fix xdp bug on our side

Since future setting keys might be fixed we allow both value(value(x)) and value(x).

We don't have the CI infra to make sure xdp is actually running so far, so the test is not useful as is.


LAS/WSJ

Hi @vrenkens ,
I tried WSJ / LAS recipes and I did not find a database.cfg nor the alignment_processor.cfg under config/recipes/LAS/WSJ directory. I just coped the one from /DNN/WSJ. Will this work?
And also I used kaldi script to prepare the training data but I don't know if I am supposed to use all the scripts(align_data, computer_prior, decoder, train_gmm). If I wasn't mistaken, only things we need for the prepare_data script would be wav.scp and pdfs, right?
Thanks.

No because that is trained with alignments.This is my database.conf, but you should adjust it to your setup.
Cheers
[trainfbank]
type = audio_feature
datafiles = /users/spraak/vrenkens/spchdisk/kaldi/egs/wsj/s5/data/train_si284/wav.scp
dir = /esat/spchtemp/scratch/vrenkens/Nabu/data/wsj/train/features
processor_config = config/recipes/LAS/WSJ/feature_processor.cfg

[test92fbank]
type = audio_feature
datafiles = /users/spraak/vrenkens/spchdisk/kaldi/egs/wsj/s5/data/test_eval92/wav.scp
dir = /esat/spchtemp/scratch/vrenkens/Nabu/data/wsj/test92/features
processor_config = config/recipes/LAS/WSJ/feature_processor.cfg

[test93fbank]
type = audio_feature
datafiles = /users/spraak/vrenkens/spchdisk/kaldi/egs/wsj/s5/data/test_eval93/wav.scp
dir = /esat/spchtemp/scratch/vrenkens/Nabu/data/wsj/test93/features
processor_config = config/recipes/LAS/WSJ/feature_processor.cfg

[devfbank]
type = audio_feature
datafiles = /users/spraak/vrenkens/spchdisk/kaldi/egs/wsj/s5/data/test_dev93/wav.scp
dir = /esat/spchtemp/scratch/vrenkens/Nabu/data/wsj/dev/features
processor_config = config/recipes/LAS/WSJ/feature_processor.cfg

[traintext]
type = string
datafiles = /users/spraak/vrenkens/spchdisk/kaldi/egs/wsj/s5/data/train_si284/text
dir = /esat/spchtemp/scratch/vrenkens/Nabu/data/wsj/train/text
processor_config = config/recipes/LAS/WSJ/text_processor.cfg

[test92text]
type = string
datafiles = /users/spraak/vrenkens/spchdisk/kaldi/egs/wsj/s5/data/test_eval92/text
dir = /esat/spchtemp/scratch/vrenkens/Nabu/data/wsj/test92/text
processor_config = config/recipes/LAS/WSJ/text_processor.cfg

[test93text]
type = string
datafiles = /users/spraak/vrenkens/spchdisk/kaldi/egs/wsj/s5/data/test_eval93/text
dir = /esat/spchtemp/scratch/vrenkens/Nabu/data/wsj/test93/text
processor_config = config/recipes/LAS/WSJ/text_processor.cfg

[devtext]
type = string
datafiles = /users/spraak/vrenkens/spchdisk/kaldi/egs/wsj/s5/data/test_dev93/text
dir = /esat/spchtemp/scratch/vrenkens/Nabu/data/wsj/dev/text
processor_config = config/recipes/LAS/WSJ/text_processor.cfg

@vrenkens Thanks! I see. So you only use alignment input for the DNN + WSJ recipe. For LAS implementation since it's end-to-end ASR you got rid of the hmmgmm part, right?

Correct :)


FileInfoCard Overflow Fix for Small Screens

FileInfoCard overflow fixed, new condition added to child aspect ratio. When 350<screenWidth<650, card aspect ratio 1.3, in other cases aspect ratio 1 like square.

https://github.com/abuanwar072/Flutter-Responsive-Admin-Panel-or-Dashboard/issues/15
Issue fixed in this branch.


[BrokenLinksH2] Fix path in link

Fixing the link path line 27 and 68.

@tfosmark, Please can you review and merge!

Global effort to fix broken links
@JonDouglas
The Content & Learning team is fixing broken links on docs.microsoft.com for the rest of H2. This effort will eliminate potential accessibility, security, and usability issues. This PR includes only link fixes and does not change other content. Please review within five business days and merge, or comment in the PR with any changes you'd like to see. Thanks!

Global effort to fix broken links
Hi @anangaur,
The Content & Learning team is fixing broken links on docs.microsoft.com for the rest of H2. This effort will eliminate potential accessibility, security, and usability issues. This PR includes only link fixes and does not change other content. Please review within five business days and merge, or comment in the PR with any changes you'd like to see. Thanks!


New Oauth requirements

Has this plugin been rendered outdated by the new FB Oath  requirements?

I looked yesterday but didn't see any activity in any of the branches. I'm not looking forward to learning how this works. I hope someone who knows this code better than me has a quick solution.

For a quick solution you can use sfMelodyPlugin. It is OAuth Based so not only for Facebook but Twitter, Google....
You can also try to contribute to sfFacebookConnectPlugin by forking and make a pull request ;-)

One of the branches has a fix. You need to update php-sdk and make a few changes to the code. I'm going to fork the theodo branch for I have some changes that relate to syncing an existing sfGuardUser with FB credentials and allowing them to login as either a FB user of a sfGuard user.

Is thodo branch working now?

I don't know. Ended up using directly facebook-php-sdk and a couple of new methods just to sign in and create new users.


Investigate concurrency support

We probably want to be able to do things like downloads of many files in parallel. Async may help (#28) but some backends may be able to do things like multipart upload/download in parallel and do things across processes in addition to across threads.
Like #28, we'll want tests to make sure the gains are worth the complexity.

for S3 aioboto3 is another option


Spike: Abstract wallet-dependant components/functionality

Overview
The high-level idea behind this issue is we have a set of common functionality implemented across the app WRT buttons that interact with wallet. This screenshot from @woodenfurniture sums it best:

We always have to:

Think about the "Connect Wallet" flow (spoiler alert: we never do and I can think of at least 5 "Connect Wallet" issues where we had to handle the no wallet connected flow)
Think of MetaMask/Ledger specifically
In the case of Ledger, we always have to warn users to open the app on their device first, or do some weird UX workarounds Ledger

What if we instead we had some dynamic component/s (e.g a button, but not limited to it) which would detect if/which wallet is connected, an do some checks before, returning a fallback in the case of no wallet connected, or in case an action is needed
What if we didn't have to think of those edge cases, but would have a UI library of sorts that handles this, and returns a different copy, also handling things like approvals needed and accepting functions that trigger whichever action is needed on click (e.g onApprove) or sane defaults for actions which are always the same (onConnectWalletClick).
This spike is an engineering spike on how to avoid the repetitiveness, disparity of duplicated code, and eventually make it so we don't have to repeat ourselves and miss edge cases, because it is streamlined.
Here is an overview of states we're interested in:

Wallet isn't connected
Wallet is connected, but chain isn't supported
Wallet is Ledger and requires action (can we open the app on-device programatically as an easy enough lift?)
"Quote" error (gas estimation error, pool halted etc)
Loading state

References and additional details
TODO
Acceptance Criteria

A plan of action is redacted on how to avoid Ledger regressions, but most importantly streamline wallet-dependant components and actions
Stretch: How hard is it to get Ledger "open app" functionality working? If we can do so, then this would be the perfect contender for it, as having the hdwallet functionality for it is one thing and a beast of its own, but then we would still have to write a bunch of repeated logic everywhere to detect and fire it, versus "this component" (if this ends up being a component) handling it.

Need By Date
No response
Screenshots/Mockups
No response
Estimated effort
No response

Some notes from spike @purelycrickets  Common component doesn't have the right estimate baked in. We want to do a holistic treating for is.crypto is.fiat simply the way we do in swapper. Generalizing this abstraction out plugs it into everywhere else (lending, LP etc.)


Parser is dropping Inner Joins when constructing the SQL from AST

Problem
A SQL statement with an Inner Join is given to the parser, once converted to AST and getting the result back as a SQL string parser loose the inner join altering original SQL statement.
I know INNER JOIN is represented as JOIN in many dialects. But since parser alters original query when converted back to AST is a problem as it is loosing information.
Example:
fn main() {
    let sql_select = "SELECT Orders.OrderID, Customers.CustomerName, Orders.OrderDate FROM Orders INNER JOIN Customers ON Orders.CustomerID=Customers.CustomerID";

    let dialect = MySqlDialect {}; // or AnsiDialect, or your own dialect ...
    let mut ast = Parser::parse_sql(&dialect, sql_select).unwrap();

    assert_eq!(ast[0].to_string(), sql_select);
}

Output:
thread 'main' panicked at 'assertion failed: `(left == right)`
  left: `"SELECT Orders.OrderID, Customers.CustomerName, Orders.OrderDate FROM Orders JOIN Customers ON Orders.CustomerID = Customers.CustomerID"`,
 right: `"SELECT Orders.OrderID, Customers.CustomerName, Orders.OrderDate FROM Orders INNER JOIN Customers ON Orders.CustomerID=Customers.CustomerID"`', src/main.rs:111:5

Same is happening with OUTER JOIN

Hi @kasvith  -- thank you for the report
This is a similar issue to https://github.com/sqlparser-rs/sqlparser-rs/issues/918
Basically what needs to happen is that the SQL AST needs to be extended to track if the INNER keyword was seen and then use that to faithfully replicate the output
Anyone who has time to offer a PR that would be most helpful

hey @alamb is this resolved?

hey @alamb is this resolved?

I am not sure -- perhaps you can contribute a PR with a test case demonstrating if it is fixed or not

I checked one more time and seems its failing... if you can give me some hints i would like to work on this PR

I checked one more time and seems its failing... if you can give me some hints i would like to work on this PR

Perhaps you could write a test in https://github.com/sqlparser-rs/sqlparser-rs/blob/main/tests/sqlparser_common.rs that uses verified_query_with_canonical to show that the resulting parse tree loses the results
Here is an example
https://github.com/sqlparser-rs/sqlparser-rs/blob/4875dadbf5e691dd1e8ef179145829d8ca3ef4d8/tests/sqlparser_databricks.rs#L154-L166
Or perhaps you can just put the example in this PR into test form

Hi @alamb sure i will work on this, please assign me to the task :)


Minor updates to release procedure

This makes sure the latest dependencies are installed before building release artifacts.  In addition, the travis/push job is configured to only build pushes to master (while this may look like a confusing change to .travis.yml, it doesn't affect the travis/pr job).

LGTM


No keyboard or mouse input in sandbox

Forked sparky, compiled to whatever the default settings are once you clone it, compiled on windows 7 64 bit with the newest version of visual studio, sandbox will run and render everything just won't record my key or mouse input.

@wallertech try my forked version, should be fixed in there

What are you trying to do to say inputs won't work?

@jannisj1 alright I will check it out buddy.
 Thanks @jannisj1.

@TheCherno i guess this can be closed now