Workspace profiles

Following from https://github.com/colcon/colcon-core/issues/52, it would be fantastic to have a system similar to catkin-tools profiles, which define build settings at the workspace level.
The command line arguments defaults mechanism looks like it provides most of the interesting options I'm familiar with from catkin-tools except one - --extend. With catkin-tools, it was extremely useful to be able to statically configure what the current space overlays, in a way that would persist through clean operations, and not be affected by a user's environment. Would you have any recommendations at what layer of colcon it would make sense to implement something like that?

Having such a feature would indeed be great and improve usability. I don't have a specific recommendation where and how it should be implemented. Before that it needs to be figured out how it interoperates with other similar features like:

global defaults
metadata
mixins
additional command line arguments

How do those features currently interoperate? Is there a precedence order, or is there something more complex required for mutually exclusive arguments?

Metadata read from files can be used to set the metadata of packages directly or amend information like dependencies. Since metadata can't be affected through command line arguments it shouldn't matter for the order.

Global defaults are read from a file specified in an environment variable and set the default value for the argparse arguments.
Passed command line arguments are used to populate the argparse.Namespace. With argparse explicitly passed arguments will override the default values of step 1.
For mixins the semantic depends in the type of the argument:

For list values the mixin items are being prepended to the existing list in the argparse.Namespace.
For other values (bool, int, float, string) the value in argparse.Namespace is being overwritten when it is the default value. If the argument has been explicitly passed through the command line it isn't changed and the mixin value is being ignored.

I appreciate the effort that has gone into the explanation above and in the previous thread, however, I'm still having trouble wrapping my head around all of these features and the various ways they interact. The ideal scenario from my point of view (as a part-time stakeholder in tooling decisions for a medium-size development team) would be:

Something I can install on everyone's computer which universally sets certain defaults in every newly-created workspace.
Something I can ship with a given workspace bundle so that when that workspace is extended, the extending workspace inherits certain global defaults (thinking CMake args, especially around optimization level and arch-specific flags), as well as a suite of package-specific flags.
All of this is exposed to users in a reasonably transparent way, so that they are empowered not just to override any particular setting, but also to understand how it got to be that way in the first place.

I don't want to have to set COLCON_HOME and have it end up pointing somewhere other than the expected location in the user's home directory. It would certainly be possible to set COLCON_DEFAULTS_FILE, especially if it was part of the env for a particular workspace to set that file pointing to workspace-specific defaults.
However, I do wonder if it might be more coherent to just make my own internal colcon-banana-defaults package which sets the options the way I want them and is able to add a supplemental option to --metas such as --banana-metas that points by default into the directory of package-specific metas used for a particular workspace, and then just make that package part of our standard setup— we may well still end up using the mixins capability to organize our flags, but the initial setup of them could be handled programmatically by the plugin rather than as something that has to be handed down to individual users ("be sure to manually add mixins X, Y, Z on every new workspace"). Does this make sense as a way forward?

around all of these features and the various ways they interact

Me too! My naive understanding is that a 'persistent profile' a-la catkin-tools would sit in the order of precedence:

global defaults
~metadata~ seems unrelated
persistent profile
mixins, and additional command line arguments (these seem to be basically equivalent, since mixins just resolve into args)

Something I can install on everyone's computer which universally sets certain defaults in every newly-created workspace.

That sounds like a good use for COLCON_HOME

Something I can ship with a given workspace bundle so that when that workspace is extended, the extending workspace inherits certain global defaults (thinking CMake args, especially around optimization level and arch-specific flags), as well as a suite of package-specific flags.

Ooh, now that's fancy, but totally outside the scope of what I had conceived. This sounds like it would be closely tied to your custom distribution method - is there a place to inject something like this in the wider hierarchy of colcon plugins?

This sounds like it would be closely tied to your custom distribution method - is there a place to inject something like this in the wider hierarchy of colcon plugins?

I mean, our bundles by and large map into larger ROS concept of a "distro", with the main caveat that we identify them by tag and tag-like objects in our rosdistro repo rather than directories, so we have thousands of them rather than just a few. The important part of putting this data into that asset would be ensuring that it's versioned alongside everything else— we don't want to have some outside authority on metas and CMake flags that can change and then mess up the consistency of older builds.
Without having given it too much more thought, my concept would be a utility package similar to cmake_modules, whose only purpose is to carry the global flag mixins and any metas that let us get out of patching upstream source (G2O_BUILD_EXAMPLES=0 and the like). There'd be some fancy tricks to get the flags into the initial bootstrap, but after that, it would basically just register some kind of hook that would make it findable by the "main" colcon plugin— whether that was an environment variable pointing to itself, or even just something that would show up as importable in the PYTHONPATH.
It's likely that most of the logic for this could go in the colcon plugin side, and then it would be fairly easy for anyone else to supply their own data package for it. I'll give it some thought and see about knocking together a prototype to understand better how it would work.

Something I can install on everyone's computer which universally sets certain defaults in every newly-created workspace.

It sounds like putting those options into the defaults.yaml file or setting the environment variable COLCON_DEFAULTS_FILE to point to custom file solves the technical part within colcon. (I will just ignore the aspect how you could deploy that without your team since that doesn't seem to be a colcon specific question.)

Something I can ship with a given workspace bundle so that when that workspace is extended, the extending workspace inherits certain global defaults (thinking CMake args, especially around optimization level and arch-specific flags), as well as a suite of package-specific flags.

I am not sure if that is generally desirable. I would even expect that as soon as you use two sibling underlays you will quickly run into a situation where those inherited flags may conflict with each other.
Are these flags / options different from the above defaults? If yes, could they be declared in a mixin and the user actively decides to use that mixin? At least that would be the already available building blocks.
Obviously a custom extension could write information to a file in the install space as well as read that file from underlays to set different default values for overlays.

My naive understanding is that a 'persistent profile' a-la catkin-tools would sit in the order of precedence:

Technically I think only two things are missing:

Profiles could be specified as simple as in a profiles.mixin file in the root of the workspace.
A way to select a specific profile / mixin by name and make it the currently used one.

On top of that the questions are how to expose this in a nicer way to the user? E.g. how to pass a specific option and persist it in the current profile?
If there is any case around profiles which can't be satisfied with the existing technical building blocks those should be described in detail and being added to the existing building blocks (rather than implementing special logic for profiles).


Change topoRunTime.useCurrentSystem to return an explicit nil value

Ensure topoRunTime.useCurrentSystem returns an explicit nil value, instead of nothing at all.

Why do we need explicit returns of nil? Does StyLua require it or something?

It's always better to use explicit returns of nil rather than nothing, since useCurrentSystem is expected to at least return something, and it's more consistent with other parts of the codebase where explicit nils are returned. StyLua is a formatter, not a linter -- currently linters like Luau LSP don't mark for it since the method has no explicit return type.

Alright, I realize that the points you made are very fair, especially the 2nd point. I think it's safe to close this PR then!


[Bug]: New headless Chromium opened visible popup asking whether I want to accept or block notifications

Minimal, reproducible example
import StealthPlugin from 'puppeteer-extra-plugin-stealth'
import puppeteer from 'puppeteer-extra'

    puppeteer.use(StealthPlugin())

    this.browser = await puppeteer.launch({
      userDataDir: CHROME_PROFILE_PATH,
      headless: 'new',
      defaultViewport: null,
      args: [`--window-size=1900,1000`]
    })

Error string
no error
Bug behavior

[ ] Flaky
[ ] PDF

Background
I was performing a personal experiment with Puppeteer and decided to write a POC script to see if I could remote control web.skype.com with it and post a message.
When Skype website opened, it asked whether I want to see notifications. I actually saw a visual popup even though browser window was headless. When I was using true instead of "new" for headless - this did not happen.
Probably this is not relevant but I was running Brave browser normally in parallel on same computer. It is also Chromium based I think but I have no idea if that has any impact.
Expectation
Headless mode should never reveal anything visually.
Reality
I could see a default Chrome popup asking whether I would allow or block notifications from website. I was in headless mode so browser window was not visible - only popup...
Puppeteer configuration file (if used)
No response
Puppeteer version
20.9.0
Node version
17.9.1
Package manager
npm
Package manager version
8.11.0
Operating system
Windows

I am unable to reproduce using the latest version (Chrome 119.0.6045.105)


Hyperparameters when training.

Hi! Thank you for sharing interest method to evaluate ethics of models.
I wrote some models using in my code and i referenced the hyperparameters on the paper.
But, performance was lower than performance on README.
So, I want to know hyperparameters(including random seed) used when you train models(ALBERT-xxlarge, RoBERTa-large, BERT-base, ...) on your README.
Thank you for reading!

From @collin-burns "I don't think we kept any information like random seeds (though that'd likely be worth keeping track of in the future) or which hyperparameters ended up working best. There were a couple models that had quite high variance across hyperparameters, so I think it was particularly important to do grid search across every set of hyperparameters to get good performance in those cases, but I'm not sure how much of it was the exact hyperparameters vs random seeds in those cases though. But I at least recall RoBERTa being pretty robust to this.
It sounds like he's not doing grid search, in which case I think that's the most likely reason for the drop in performance. But I'm also not sure what changes he made to the code, so that might also be affecting his final performance." Our grid search ranges are in https://arxiv.org/pdf/2008.02275.pdf#page=14


fixed crash on latest recommended Forge version (<IP_ADDRESS>68), fixes #89

Given that I couldn't get the Access Transformer to transform the class PotionHelper$MixPredicate to be public (it is package-private now), I resorted to using reflection. Shouldn't impact performance, as they only get accessed during load and the field references are cached.

urgh, I love gradle sometimes... I've deleted the .gradle folder in my user profile folder and now it works. New PR incoming.

I can't get it to work for some reason with the AT. After re-indexing the project it shows me the same errors again. THe only field that gets transformed is the "reagent" field. I've attached an image to show how it works on my end. Maybe you have more luck with that, but I can't make a PR with errors in the project.

Hmm, I'll look into it. I wonder if the Forge patch somehow breaks the AT. If I cannot figure it out I'll comment back here and we will see about reflection.

I've looked into this more, and it seems the Forge patches are breaking the access transformer, so reflection is the only solution now. If you want to reopen this, feel free. Though, is there any reason you do not use ReflectionHelper like I did in utils? If there is a good reason, it might make sense to transition my other reflection to this method as well.

The only reason was I didn't know about it :V
I'll reopen, look into your ReflectionHelper and make appropriate changes to this PR when I get home.

I've updated this PR now. I still kept the ReflectionUtil, because there are 2 advantages to just using the ReflectionHelper:

fields are cached: better performance instead of always looking up the field when trying to access it.
easier update: all SRG names are in one class, so they can be easily changed once the mappings change.

If you want I can look through the code, replace the rest of the ReflectionHelper usage with the Util class and make a separate PR.

Yeah, if you don't mind I'd prefer using the same reflection method everywhere. You can probably also remove the ATs, they are only needed if we directly access the fields.
It might be worth me switching to storing delegates rather than potion types as well, but that's an idea for another day.

updated PR again, with replacement of the ReflectionHelper occurences to ReflectionUtil

method names are now in the right order and proper exceptions are now catched.
The silk touch method is now properly looked up via the Block class.
I also added a way to lookup private classes and incorporated into the reflection stuff.

Alright, merged. Thanks!


[image_picker] On iOS the picker don't open in Add2app

Steps to Reproduce

Run flutter create --template module my_flutter.
Use the lib image_picker: ^0.6.3+4
Add the flutter project embed iOS Swift project.
Try open the image_picker.

Expected results:
Open image picker
Actual results:
Nothing happens.

Logs
[✓] Flutter (Channel stable, v1.12.13+hotfix.8, on Mac OS X 10.15.3 19D76, locale pt-BR)
    • Flutter version 1.12.13+hotfix.8 at /Users/lailanmatos/flutter
    • Framework revision 0b8abb4724 (5 weeks ago), 2020-02-11 11:44:36 -0800
    • Engine revision e1e6ced81d
    • Dart version 2.7.0

[✗] Android toolchain - develop for Android devices
    ✗ Unable to locate Android SDK.
      Install Android Studio from: https://developer.android.com/studio/index.html
      On first launch it will assist you in installing the Android SDK components.
      (or visit https://flutter.dev/setup/#android-setup for detailed instructions).
      If the Android SDK has been installed to a custom location, set ANDROID_HOME to that location.
      You may also want to add it to your PATH environment variable.

[✓] Xcode - develop for iOS and macOS (Xcode 11.3.1)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 11.3.1, Build version 11C504
    • CocoaPods version 1.9.1

[!] Android Studio (not installed)
    • Android Studio not found; download from https://developer.android.com/studio/index.html
      (or visit https://flutter.dev/setup/#android-setup for detailed instructions).

[✓] VS Code (version 1.43.1)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.8.1

[✓] Connected device (1 available)
    • iPhone de Lailan Rogerio • 62b31a19554ab04aeb16239b1669c17a5776d796 • ios • iOS 13.3.1

! Doctor found issues in 2 categories.

Hi @Lailan
can you please provide your flutter attach --verbose
and your pubspec.yaml
Thank you

name: modulo_treino_online
description: A new flutter module project.
The following defines the version and build number for your application.
A version number is three numbers separated by dots, like 1.2.43
followed by an optional build number separated by a +.
Both the version and the builder number may be overridden in flutter
build by specifying --build-name and --build-number, respectively.
In Android, build-name is used as versionName while build-number used as versionCode.
Read more about Android versioning at https://developer.android.com/studio/publish/versioning
In iOS, build-name is used as CFBundleShortVersionString while build-number used as CFBundleVersion.
Read more about iOS versioning at
https://developer.apple.com/library/archive/documentation/General/Reference/InfoPlistKeyReference/Articles/CoreFoundationKeys.html

This version is used only for the Runner app, which is used if you just do
a flutter run or a flutter make-host-app-editable.
Use with the CupertinoIcons class for iOS style icons.
cupertino_icons: ^0.1.2
dotted_border: ^1.0.5
http: ^0.12.0+4
basic_utils: ^1.2.0
shared_preferences: ^0.5.6+3
url_launcher: ^5.4.2
mobx: ^1.0.2+2
flutter_mobx: ^1.0.1
get_it: ^4.0.1
youtube_parser: ^1.1.0
drag_list: ^1.0.7
skeleton_text: ^1.0.0
rflutter_alert: ^1.0.3
path_provider: ^1.6.5
flutter_slidable: ^0.5.4
image_picker_gallery_camera: ^0.1.4
webview_media: ^0.1.1+3
screenshot: ^0.1.1
date_format: ^1.0.8
percent_indicator: "^2.1.1"
after_layout: ^1.0.7+2
social_share_plugin: ^0.3.0+1
dev_dependencies:
flutter_test:
sdk: flutter
build_runner: ^1.3.1
mobx_codegen: ^1.0.2
For information on the generic Dart part of this file, see the
following page: https://dart.dev/tools/pub/pubspec
flutter:
The following line ensures that the Material Icons font is
included with your application, so that you can use the icons in
the material Icons class.
uses-material-design: true
To add Flutter specific assets to your application, add an assets section,
like this:
assets:

assets/images/
assets/images/treinoDefault/

- images/a_dot_ham.jpeg
An image asset can refer to one or more resolution-specific "variants", see
https://flutter.dev/assets-and-images/#resolution-aware.
For details regarding adding assets from package dependencies, see
https://flutter.dev/assets-and-images/#from-packages
To add Flutter specific custom fonts to your application, add a fonts
section here, in this "flutter" section. Each entry in this list should
have a "family" key with the font family name, and a "fonts" key with a
list giving the asset and other descriptors for the font. For
example:
fonts:
- family: DINPro
fonts:
- asset: assets/fonts/DINPro.otf
- asset: assets/fonts/DINPro-Light.otf
- asset: assets/fonts/DINPro-Medium.otf
style: italic
- family: Trajan Pro
fonts:
- asset: fonts/TrajanPro.ttf
- asset: fonts/TrajanPro_Bold.ttf
weight: 700

For details regarding fonts from package dependencies,
see https://flutter.dev/custom-fonts/#from-packages
This section identifies your Flutter project as a module meant for
embedding in a native host app.  These identifiers should not ordinarily
be changed after generation - they are used to ensure that the tooling can
maintain consistency when adding or modifying assets and plugins.
They also do not have any bearing on your native host application's
identifiers, which may be completely independent or the same as these.
module:
androidX: true
androidPackage: br.com.pactosolucoes.modulo_treino_online
iosBundleIdentifier: br.com.pactosolucoes.moduloTreinoOnline

lailanmatos@Lailans-MacBook-Pro-2 treino-simples-modulo % flutter attach --verbose -d 62b31a19554ab04aeb16239b1669c17a5776d796 [  +45 ms] executing: [/Users/lailanmatos/flutter/] git -c log.showSignature=false log -n 1 --pretty=format:%H [  +53 ms] Exit code 0 from: git -c log.showSignature=false log -n 1 --pretty=format:%H [        ] 0b8abb4724aa590dd0f429683339b1e045a1594d [        ] executing: [/Users/lailanmatos/flutter/] git describe --match v*.*.* --first-parent --long --tags [ +111 ms] Exit code 0 from: git describe --match v*.*.* --first-parent --long --tags [   +3 ms] v1.12.13+hotfix.8-0-g0b8abb472 [  +10 ms] executing: [/Users/lailanmatos/flutter/] git rev-parse --abbrev-ref --symbolic @{u} [  +17 ms] Exit code 0 from: git rev-parse --abbrev-ref --symbolic @{u} [        ] origin/stable [        ] executing: [/Users/lailanmatos/flutter/] git ls-remote --get-url origin [  +16 ms] Exit code 0 from: git ls-remote --get-url origin [   +1 ms] https://github.com/flutter/flutter.git [  +79 ms] executing: [/Users/lailanmatos/flutter/] git rev-parse --abbrev-ref HEAD [  +17 ms] Exit code 0 from: git rev-parse --abbrev-ref HEAD [        ] stable [  +15 ms] executing: sw_vers -productName [  +28 ms] Exit code 0 from: sw_vers -productName [        ] Mac OS X [        ] executing: sw_vers -productVersion [  +17 ms] Exit code 0 from: sw_vers -productVersion [        ] 10.15.3 [        ] executing: sw_vers -buildVersion [  +23 ms] Exit code 0 from: sw_vers -buildVersion [        ] 19D76 [  +43 ms] executing: /usr/bin/xcode-select --print-path [  +15 ms] Exit code 0 from: /usr/bin/xcode-select --print-path [        ] /Applications/Xcode.app/Contents/Developer [   +3 ms] executing: /usr/bin/xcodebuild -version [+1238 ms] Exit code 0 from: /usr/bin/xcodebuild -version [        ] Xcode 11.4            Build version 11E146 [  +96 ms] Unable to locate an Android SDK. [  +12 ms] Unable to locate an Android SDK. [  +36 ms] executing: /Users/lailanmatos/flutter/bin/cache/artifacts/libimobiledevice/idevice_id -h [ +245 ms] /usr/bin/xcrun simctl list --json devices [ +174 ms] Artifact Instance of 'AndroidMavenArtifacts' is not required, skipping update. [        ] Artifact Instance of 'AndroidGenSnapshotArtifacts' is not required, skipping update. [        ] Artifact Instance of 'AndroidInternalBuildArtifacts' is not required, skipping update. [        ] Artifact Instance of 'IOSEngineArtifacts' is not required, skipping update. [        ] Artifact Instance of 'FlutterWebSdk' is not required, skipping update. [   +4 ms] Artifact Instance of 'WindowsEngineArtifacts' is not required, skipping update. [        ] Artifact Instance of 'MacOSEngineArtifacts' is not required, skipping update. [        ] Artifact Instance of 'LinuxEngineArtifacts' is not required, skipping update. [        ] Artifact Instance of 'LinuxFuchsiaSDKArtifacts' is not required, skipping update. [        ] Artifact Instance of 'MacOSFuchsiaSDKArtifacts' is not required, skipping update. [        ] Artifact Instance of 'FlutterRunnerSDKArtifacts' is not required, skipping update. [        ] Artifact Instance of 'FlutterRunnerDebugSymbols' is not required, skipping update. [  +82 ms] Checking for advertised Dart observatories... [+5031 ms] No pointer records found. [  +22 ms] Waiting for a connection from Flutter on iPhone de Lailan Rogerio...

HI @Lailan
image_picker_gallery_camera is a 3rd party plugin
you may want to open an issue in the dedicated github
Closing, as this isn't an issue with Flutter itself,
if you disagree please write in the comments and I will reopen it
Thank you

Sorry, my bad.
I was doing tests with other libraries and I didn't notice that when copying the pubspec.yaml was with another version.
This reported problem is with the image_picker: ^ 0.6.3 + 4

Hi @Lailan
I can reproduce it

flutter doctor -v
[✓] Flutter (Channel stable, 1.22.6, on macOS 11.2 20D64 darwin-x64, locale en-GB)
    • Flutter version 1.22.6 at /Users/tahatesser/Code/flutter_stable
    • Framework revision 9b2d32b605 (3 weeks ago), 2021-01-22 14:36:39 -0800
    • Engine revision 2f0af37152
    • Dart version 2.10.5
[✗] Android toolchain - develop for Android devices
    ✗ Unable to locate Android SDK.
      Install Android Studio from: https://developer.android.com/studio/index.html
      On first launch it will assist you in installing the Android SDK components.
      (or visit https://flutter.dev/docs/get-started/install/macos#android-setup for detailed instructions).
      If the Android SDK has been installed to a custom location, set ANDROID_SDK_ROOT to that location.
      You may also want to add it to your PATH environment variable.
[!] Xcode - develop for iOS and macOS (Xcode 12.4)
    • Xcode at /Volumes/Extreme/Xcode.app/Contents/Developer
    • Xcode 12.4, Build version 12D4e
    ✗ CocoaPods not installed.
        CocoaPods is used to retrieve the iOS and macOS platform side's plugin code that responds to your plugin usage on the Dart side.
        Without CocoaPods, plugins will not work on iOS or macOS.
        For more info, see https://flutter.dev/platform-plugins
      To install:
        sudo gem install cocoapods
[!] Android Studio (version 4.1)
    • Android Studio at /Applications/Android Studio.app/Contents
    ✗ Flutter plugin not installed; this adds Flutter specific functionality.
    ✗ Dart plugin not installed; this adds Dart specific functionality.
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6915495)
[✓] VS Code (version 1.53.0)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.19.0
[✓] Connected device (2 available)
    • Taha’s iPhone (mobile) • 00008020-001059882212002E            • ios • iOS 14.4
    • iPhone 12 (mobile)     • BAAA8897-8FC4-4E65-8A47-16C62B67FD83 • ios • com.apple.CoreSimulator.SimRuntime.iOS-14-4 (simulator)
! Doctor found issues in 3 categories.

[✓] Flutter (Channel master, 1.26.0-18.0.pre.215, on macOS 11.2 20D64 darwin-x64, locale en-GB)
    • Flutter version 1.26.0-18.0.pre.215 at /Users/tahatesser/Code/flutter_master
    • Framework revision f3c10bd23a (9 hours ago), 2021-02-08 21:52:03 -0800
    • Engine revision b04955656c
    • Dart version 2.13.0 (build 2.13.0-0.0.dev)
[✗] Android toolchain - develop for Android devices
    ✗ Unable to locate Android SDK.
      Install Android Studio from: https://developer.android.com/studio/index.html
      On first launch it will assist you in installing the Android SDK components.
      (or visit https://flutter.dev/docs/get-started/install/macos#android-setup for detailed instructions).
      If the Android SDK has been installed to a custom location, please use
      `flutter config --android-sdk` to update to that location.
[!] Xcode - develop for iOS and macOS
    • Xcode at /Volumes/Extreme/Xcode.app/Contents/Developer
    • Xcode 12.4, Build version 12D4e
    ✗ CocoaPods not installed.
        CocoaPods is used to retrieve the iOS and macOS platform side's plugin code that responds to your plugin usage on the Dart side.
        Without CocoaPods, plugins will not work on iOS or macOS.
        For more info, see https://flutter.dev/platform-plugins
      To install see https://guides.cocoapods.org/using/getting-started.html#installation for instructions.
[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome
[✓] Android Studio (version 4.1)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6915495)
[✓] VS Code (version 1.53.0)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.19.0
[✓] Connected device (4 available)
    • Taha’s iPhone (mobile) • 00008020-001059882212002E            • ios            • iOS 14.4
    • iPhone 12 (mobile)     • BAAA8897-8FC4-4E65-8A47-16C62B67FD83 • ios            • com.apple.CoreSimulator.SimRuntime.iOS-14-4 (simulator)
    • macOS (desktop)        • macos                                • darwin-x64     • macOS 11.2 20D64 darwin-x64
    • Chrome (web)           • chrome                               • web-javascript • Google Chrome 88.0.4324.150
! Doctor found issues in 2 categories.

Thank you

Have you tested with the latest version of image_picker? @Lailan  I couldn't reproduce the issue.

Hi @Lailan
I can reproduce it, example works when launched from module

flutter doctor -v
related #37385
Thank you

After image_picker:0.7.0 pickImage method is removed and you should use getImage instead. Do you think this is the problem you had? Have you tried the latest version of image_picker? I think this issue is also fixed.
Please let me know if you have the same issue. Thanks.

Hi @ydag!
I just tried with image_picker  in the add2app sample, the Issue persists.
Preview

image_picker when running module itself
image_picker when running from native app

Steps to reproduce

git clone git@github.com:flutter/samples.git
Add image_picker sample to samples/add_to_app/fullscreen/flutter_module/lib/main.dart
Add latest packages for the sample to samples/add_to_app/fullscreen/flutter_module/pubpsec.yaml and execute flutter pub get

  image_picker: ^0.7.5
  video_player: ^2.1.1

Open samples/add_to_app/fullscreen/flutter_module/.ios/Runner.xcworkspace in Xcode and add required permissions in info.plist

	<key>NSCameraUsageDescription</key>
	<string>Used to demonstrate image picker plugin</string>
	<key>NSMicrophoneUsageDescription</key>
	<string>Used to capture audio for image picker plugin</string>
	<key>NSPhotoLibraryUsageDescription</key>
	<string>Used to demonstrate image picker plugin</string>

Run module samples/add_to_app/fullscreen/flutter_module on iOS simulator (image_picker works fine)
Go to samples/add_to_app/fullscreen/ios_fullscreen and execute pod install
Open samples/add_to_app/fullscreen/ios_fullscreen/IOSFullScreen.xcodeproj in Xcode, run the app, launch Flutter module and try to pick an image

Hello @TahaTesser,
Thank you for the details. I also reproduced the issue with the steps you provide. This was weird first because I also followed the steps in here and it was working.
After some checks, I realized that the add-to-app/fullscreen sample may not be a proper sample to add image_picker to test it. Because in the AppDelegate file, this part is missing:
// Used to connect plugins (only if you have plugins with iOS platform code).
    GeneratedPluginRegistrant.register(with: self.flutterEngine);
    return super.application(application, didFinishLaunchingWithOptions: launchOptions);

Since image_picker has iOS platform code I think we need this part. I also realized some other differences. I think if you follow these instructions then you can see that image_picker works.
Thanks.

@ydag
There are 3 ways to embed the Flutter module, which one you followed? I am happy to follow up

@TahaTesser
I followed option-a.

Hi @ydag
I confirm this solves the issue when following the official doc
 // Used to connect plugins (only if you have plugins with iOS platform code).
   GeneratedPluginRegistrant.register(with: self.flutterEngine);

Preview

Closing. as solved


Reintroduce multi-language support

Each article belongs to a group. Articles in different languages would be linked through this group. You could call them translations. Each article would have links to the other articles in that group. Since a group can only have one article per language, this would mean you'd have something similar to Wikipedia's way of listing the languages in which the current article is available. (I hope I'm making sense so far) Clicking on one of these links would change the interface language and set a cookie to remember that.
You would also be able to set a locale through your account settings or the language switcher at the bottom. The language switcher would actually update your settings if you're logged in. If not, a cookie would be set.

Awesome. Locale switching is working very nicely. There are just a few things left to do:

Add functionality to the locale switcher at the bottom of the page
Add a locale selection box in the account settings and in the management panel

Oh, one more thing: although the next few builds will include a partially-completed Dutch language pack, official releases will not include any language packs other than American English. There are a couple of reasons for this:

Every time a new translation version is released, the package would have to be updated
Translations would have to be complete before we could release a version. This would cost time
If a translation were to be abandoned, the language would have to be removed, because again, locale packs included in a release package would have to be complete

The only thing left to do here is to add a locale selection box in the management panel. There's no need to add one to the account settings page since there's already a locale switcher at the bottom.
You can also install and delete locales, but there are a few things that need to be fixed as well: homepage creation (which has a few bugs) and locales should be deleted using the ID rather than language code.
The locale class does need to be improved upon, but there's another issue for that: #38

Closing this issue as this has already been done some time ago.


Can't create bounding box by clicking in existing box

If you have one box that is the entire head of a person, but also want to add a new box that is an eye, you just keep selecting the existing box instead of creating a new one.
It would be great to be able to start a bounding box inside of an existing box.  I could see the functionality of holding shift and being able to have a new box drawn starting where you click inside an existing box instead of it only selecting the existing box as it does now.

Fixed with exclusive add mode in dev branch.


na.locf(na.rm=FALSE, ...)

Eddie, anywhere you come across na.locf(na.locf(...., there is a bug. I forgot the na.rm arg, which is TRUE by default. This means that NAs at the extreme ends of the vector will be removed. These values should be filled instead (which is the whole reason for doing it twice). You'll want to set na.rm=FALSE.

ok, thanks a bunch!


Monitoring Network Policy

I know this might not be the right place, but wanted to ask if you or anyone else knows where to check logs for dropped traffic by Network Policy.
For example: ingress is denied for all namespaces, which also means for everything else but its own namespace. Where would one be able to check the logs that say namespaceB tried to do a connection however it was dropped due to Network Policy? Or even external source ? -- I tried finding it in various log places including nodes, no-go thus far .

Hi all,
today I tried to put Calico LogSeverityScreen to debug and still could not find any relevant info for my dropped network policies(or this info is to hard to get)


Typings issue

Request and Response declarations has been removed from the d.ts file

These are fetch declarations can be brought back with typings i dt~whatwg-fetch -GS

interface BufferSource {}
interface URLSearchParams {}

are still missing though

Same issues had to revert back to commit hash a97fa7b9484cd78d986b11e537394400c99d02fe. To specify getting the prior version.

Still getting the same issues after updating to the release candidate. Using @y2k4life fix for the moment, but still get  error TS2300: Duplicate identifier 'BufferSource'.

I'm still having the same issue with the release candidate. After starting a new project with Aurelia-cli
I installed aurelia-fetch-client and immediately saw lots of errors.
typings i dt~whatwg-fetch -GS helps but URLSearchParams is missing still.

Please submit the issues to the author of the d.ts files. That is the best way to see this fixed once and for all.

@EisenbergEffect Sorry I am a bit lost, who is the author?
The file that's throwing the error is typings\globals\aurelia-fetch-client\index.d.ts(272,11): error TS2300: Duplicate identifier 'BufferSource'.

Where did it come from? If it's in one of our repos, we can delete the duplicate. It's odd that our tests didn't turn up that error though.

So based off your comments @EisenbergEffect  I thought I might of stuffed things up. So I decided to start fresh using the aurelia-cli. I created a custom install using typescript, no css preprocessor, no unit testing, with dependencies installed. Everything installed correctly.
I then updated app.ts to include:
import {HttpClient} from 'aurelia-fetch-client';

export class App {
  message = 'Hello World!';
  private m_getHTTP: HttpClient;

  constructor(private http: HttpClient) {
    this.m_getHTTP = http;
    this.m_getHTTP.fetch('https://www.google.com.au/')
      .then(response => response.json())
      .then(data => {
        console.log('Google has loaded!');
      });
  }
}

When running au build I get the following error:
$ au build
Starting 'readProjectConfiguration'...
Finished 'readProjectConfiguration'
Starting 'processMarkup'...
Starting 'processCSS'...
Starting 'configureEnvironment'...
Finished 'processCSS'
Finished 'processMarkup'
Finished 'configureEnvironment'
Starting 'buildTypeScript'...
D:/source/app/aurelia-test/node_modules/aurelia-fetch-client/dist/aurelia-fetch-client.d.ts(17,23): error TS2304: Cannot find name 'Request'.
[13:01:13] gulp-notify: [Error running Gulp] Error: D:/source/app/aurelia-test/node_modules/aurelia-fetch-client/dist/aurelia-fetch-client.d.ts(17,23): error TS2304: Cannot find name 'Request'.
D:/source/app/aurelia-test/node_modules/aurelia-fetch-client/dist/aurelia-fetch-client.d.ts(17,35): error TS2304: Cannot find name 'Request'.
[13:01:13] gulp-notify: [Error running Gulp] Error: D:/source/app/aurelia-test/node_modules/aurelia-fetch-client/dist/aurelia-fetch-client.d.ts(17,35): error TS2304: Cannot find name 'Request'.
D:/source/app/aurelia-test/node_modules/aurelia-fetch-client/dist/aurelia-fetch-client.d.ts(17,45): error TS2304: Cannot find name 'Response'.
[13:01:13] gulp-notify: [Error running Gulp] Error: D:/source/app/aurelia-test/node_modules/aurelia-fetch-client/dist/aurelia-fetch-client.d.ts(17,45): error TS2304: Cannot find name 'Response'.
D:/source/app/aurelia-test/node_modules/aurelia-fetch-client/dist/aurelia-fetch-client.d.ts(17,64): error TS2304: Cannot find name 'Request'.
[13:01:13] gulp-notify: [Error running Gulp] Error: D:/source/app/aurelia-test/node_modules/aurelia-fetch-client/dist/aurelia-fetch-client.d.ts(17,64): error TS2304: Cannot find name 'Request'.
D:/source/app/aurelia-test/node_modules/aurelia-fetch-client/dist/aurelia-fetch-client.d.ts(17,74): error TS2304: Cannot find name 'Response'.
[13:01:13] gulp-notify: [Error running Gulp] Error: D:/source/app/aurelia-test/node_modules/aurelia-fetch-client/dist/aurelia-fetch-client.d.ts(17,74): error TS2304: Cannot find name 'Response'.
D:/source/app/aurelia-test/node_modules/aurelia-fetch-client/dist/aurelia-fetch-client.d.ts(27,34): error TS2304: Cannot find name 'Request'.
[13:01:13] gulp-notify: [Error running Gulp] Error: D:/source/app/aurelia-test/node_modules/aurelia-fetch-client/dist/aurelia-fetch-client.d.ts(27,34): error TS2304: Cannot find name 'Request'.
D:/source/app/aurelia-test/node_modules/aurelia-fetch-client/dist/aurelia-fetch-client.d.ts(27,44): error TS2304: Cannot find name 'Response'.
[13:01:13] gulp-notify: [Error running Gulp] Error: D:/source/app/aurelia-test/node_modules/aurelia-fetch-client/dist/aurelia-fetch-client.d.ts(27,44): error TS2304: Cannot find name 'Response'.
D:/source/app/aurelia-test/node_modules/aurelia-fetch-client/dist/aurelia-fetch-client.d.ts(27,63): error TS2304: Cannot find name 'Request'.
[13:01:13] gulp-notify: [Error running Gulp] Error: D:/source/app/aurelia-test/node_modules/aurelia-fetch-client/dist/aurelia-fetch-client.d.ts(27,63): error TS2304: Cannot find name 'Request'.
D:/source/app/aurelia-test/node_modules/aurelia-fetch-client/dist/aurelia-fetch-client.d.ts(27,73): error TS2304: Cannot find name 'Response'.
[13:01:13] gulp-notify: [Error running Gulp] Error: D:/source/app/aurelia-test/node_modules/aurelia-fetch-client/dist/aurelia-fetch-client.d.ts(27,73): error TS2304: Cannot find name 'Response'.
D:/source/app/aurelia-test/node_modules/aurelia-fetch-client/dist/aurelia-fetch-client.d.ts(36,25): error TS2304: Cannot find name 'Response'.
[13:01:13] gulp-notify: [Error running Gulp] Error: D:/source/app/aurelia-test/node_modules/aurelia-fetch-client/dist/aurelia-fetch-client.d.ts(36,25): error TS2304: Cannot find name 'Response'.
D:/source/app/aurelia-test/node_modules/aurelia-fetch-client/dist/aurelia-fetch-client.d.ts(36,45): error TS2304: Cannot find name 'Request'.
[13:01:13] gulp-notify: [Error running Gulp] Error: D:/source/app/aurelia-test/node_modules/aurelia-fetch-client/dist/aurelia-fetch-client.d.ts(36,45): error TS2304: Cannot find name 'Request'.
D:/source/app/aurelia-test/node_modules/aurelia-fetch-client/dist/aurelia-fetch-client.d.ts(36,57): error TS2304: Cannot find name 'Response'.
[13:01:13] gulp-notify: [Error running Gulp] Error: D:/source/app/aurelia-test/node_modules/aurelia-fetch-client/dist/aurelia-fetch-client.d.ts(36,57): error TS2304: Cannot find name 'Response'.
D:/source/app/aurelia-test/node_modules/aurelia-fetch-client/dist/aurelia-fetch-client.d.ts(36,76): error TS2304: Cannot find name 'Response'.
[13:01:13] gulp-notify: [Error running Gulp] Error: D:/source/app/aurelia-test/node_modules/aurelia-fetch-client/dist/aurelia-fetch-client.d.ts(36,76): error TS2304: Cannot find name 'Response'.
D:/source/app/aurelia-test/node_modules/aurelia-fetch-client/dist/aurelia-fetch-client.d.ts(47,42): error TS2304: Cannot find name 'Request'.
[13:01:13] gulp-notify: [Error running Gulp] Error: D:/source/app/aurelia-test/node_modules/aurelia-fetch-client/dist/aurelia-fetch-client.d.ts(47,42): error TS2304: Cannot find name 'Request'.
D:/source/app/aurelia-test/node_modules/aurelia-fetch-client/dist/aurelia-fetch-client.d.ts(47,54): error TS2304: Cannot find name 'Response'.
[13:01:13] gulp-notify: [Error running Gulp] Error: D:/source/app/aurelia-test/node_modules/aurelia-fetch-client/dist/aurelia-fetch-client.d.ts(47,54): error TS2304: Cannot find name 'Response'.
D:/source/app/aurelia-test/node_modules/aurelia-fetch-client/dist/aurelia-fetch-client.d.ts(47,73): error TS2304: Cannot find name 'Response'.
[13:01:13] gulp-notify: [Error running Gulp] Error: D:/source/app/aurelia-test/node_modules/aurelia-fetch-client/dist/aurelia-fetch-client.d.ts(47,73): error TS2304: Cannot find name 'Response'.
D:/source/app/aurelia-test/node_modules/aurelia-fetch-client/dist/aurelia-fetch-client.d.ts(68,13): error TS2304: Cannot find name 'Headers'.
[13:01:13] gulp-notify: [Error running Gulp] Error: D:/source/app/aurelia-test/node_modules/aurelia-fetch-client/dist/aurelia-fetch-client.d.ts(68,13): error TS2304: Cannot find name 'Headers'.
D:/source/app/aurelia-test/node_modules/aurelia-fetch-client/dist/aurelia-fetch-client.d.ts(73,43): error TS2304: Cannot find name 'URLSearchParams'.
[13:01:13] gulp-notify: [Error running Gulp] Error: D:/source/app/aurelia-test/node_modules/aurelia-fetch-client/dist/aurelia-fetch-client.d.ts(73,43): error TS2304: Cannot find name 'URLSearchParams'.
D:/source/app/aurelia-test/node_modules/aurelia-fetch-client/dist/aurelia-fetch-client.d.ts(258,16): error TS2304: Cannot find name 'Request'.
[13:01:13] gulp-notify: [Error running Gulp] Error: D:/source/app/aurelia-test/node_modules/aurelia-fetch-client/dist/aurelia-fetch-client.d.ts(258,16): error TS2304: Cannot find name 'Request'.
D:/source/app/aurelia-test/node_modules/aurelia-fetch-client/dist/aurelia-fetch-client.d.ts(258,63): error TS2304: Cannot find name 'Response'.
[13:01:13] gulp-notify: [Error running Gulp] Error: D:/source/app/aurelia-test/node_modules/aurelia-fetch-client/dist/aurelia-fetch-client.d.ts(258,63): error TS2304: Cannot find name 'Response'.
[13:01:13] TypeScript: 20 semantic errors
[13:01:13] TypeScript: emit succeeded (with errors)
Finished 'buildTypeScript'
Starting 'writeBundles'...
Tracing app...
Tracing app...
Tracing text...
Tracing aurelia-binding...
Tracing aurelia-dependency-injection...
Tracing aurelia-bootstrapper...
Tracing aurelia-event-aggregator...
Tracing aurelia-history...
Tracing aurelia-framework...
Tracing aurelia-loader-default...
Tracing aurelia-logging...
Tracing aurelia-history-browser...
Tracing aurelia-loader...
Tracing aurelia-pal...
Tracing aurelia-logging-console...
Tracing aurelia-metadata...
Tracing aurelia-pal-browser...
Tracing aurelia-path...
Tracing aurelia-polyfills...
Tracing aurelia-route-recognizer...
Tracing aurelia-router...
Tracing aurelia-task-queue...
Tracing aurelia-templating...
Tracing aurelia-templating-binding...
Tracing aurelia-templating-resources...
Tracing aurelia-testing...
Tracing aurelia-templating-router...
Tracing environment...
Tracing main...
Tracing resources/index...
Writing app-bundle.js...
Writing vendor-bundle.js...
Finished 'writeBundles'

The duplicate comes from that fact there's more than one definition of the same symbol somewhere. What symbol is it? I can check our repo and update it...though I was pretty sure we addressed that. Maybe there's more than one location?

I'm happy to push a patch out for this if we can track it down.

That would be amazing, so keen to get this fixed. I'll start looking now

So to resolve all the error TS2304: Cannot find name 'Response'. errors, I have added the following code to whenever I import the HTTPClient (eg inside app.ts):
/// <reference path="../node_modules/aurelia-fetch-client/doc/whatwg-fetch.d.ts" />
import {HttpClient} from 'aurelia-fetch-client';

The whatwg-fetch.d.ts seems like it contained all the missing libraries and it does fix all the errors. The problem is it now introduces a new error, which is the error TS2300: Duplicate identifier 'BufferSource'.
This issue is caused by the whatwg-fetch.d.ts file declaring a BufferSource type which is conflicting with the BufferSource type declared inside the lib.dom.d.ts file found inside:
node_modules\typescript\lib\lib.dom.d.ts (line 14600)
type BufferSource = ArrayBuffer | ArrayBufferView;
To fix the issue on my end, I have commented out the BufferSource declaration inside the whatwg-fetch-d.ts file (line 9)
//interface BufferSource {}
I am concerned that this doesn't seem 'correct' to me. What I am concerned about is that the BufferSource now referenced elsewhere is potentially a different Type now. It would be great however if both the lib.dom.d.ts and whatwg-fetch.d.ts were actually referencing the same type.
To help showcase the different steps to resolve the issue, I have created a seperate git repo located here:
https://github.com/anthonyborell/aurelia-typescript-error/tree/master
I have created 2 other branches 'fix1 and 'fix2' to show the steps described above to fix the compile issues.
Branch fix1 showcases adding the requirement while branch fix2 shows removing the BufferSource interface from whatwg-fetch.d.ts
Unfortunately after all of this, I am now encountering a runtime issue in Chrome:
Cannot read property 'fetch' of undefined at new App (http://localhost:9000/scripts/app-bundle.js:8:27)
I hope this helps you guys in diagnosing the issue. It still seems like something else is wrong and these are just symptoms of the other error that I have not encountered yet...

@anthonyborell node_modules/aurelia-fetch-client/doc/whatwg-fetch.d.ts is a leftover file which should not be used

@MaximBalaganskiy Regardless of the file, substitute it with github:aurelia/fetch-client/dist/aurelia-fetch-client.d.ts#a97fa7b9484cd78d986b11e537394400c99d02fe it's still broken.

@EisenbergEffect , I'm also tracking this issue, I managed to get the fetch Api bits working that was moved out, no problem there. Two types remain amis BufferSource and URLSearchParams, it was last seen in aurelia-fetch-client.d.ts here: https://github.com/aurelia/fetch-client/blob/ab1acbffb540a8f37be8de42edf3f96661233b89/dist/aurelia-fetch-client.d.ts#L269-L271

Add those manually or submit a pr to fetch repo
On 27 Jun 2016 6:57 pm, "Stefan Buys"<EMAIL_ADDRESS>wrote:

@EisenbergEffect https://github.com/EisenbergEffect , I'm also tracking
this issue, I managed to get the fetch Api bits working that was moved out,
no problem there. Two types remain amis BufferSource and URLSearchParams,
it was last seen in aurelia-fetch-client.d.ts here:
https://github.com/aurelia/fetch-client/blob/ab1acbffb540a8f37be8de42edf3f96661233b89/dist/aurelia-fetch-client.d.ts#L269-L271
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/aurelia/fetch-client/issues/65#issuecomment-228689568,
or mute the thread
https://github.com/notifications/unsubscribe/ADimvEETrBHHpp5u9c1LR6-7lND1Hvx6ks5qP5BtgaJpZM4I29wq
.

I am observing the same error. typings i dt~whatwg-fetch -GS fixes most errors, but error TS2304: Cannot find name 'URLSearchParams' remains.

Same problem here with project created from CLI.
error TS2304: Cannot find name 'URLSearchParams'.

URLSearchParams is part of the URL spec, not the fetch spec. It should probably be provided by the TypeScript team at this point along with Fetch. If you can't find it, you can always just add a dummy type to satisfy the compiler.

OK thanks, it seems they are waiting on the Edge team Microsoft/TSJS-lib-generator#118 .

seems after doing this typings i aurelia-fetch-client -GS which makes this
{
  "globalDependencies": {
    "whatwg-fetch": "registry:dt/whatwg-fetch#0.0.0+20160829180742"
  }
}

which fixed most of my warnings, I'm still getting this
[default] C:\Users\xeno\IdeaProjects\rpf-ui\custom_typings\fetch.d.ts:1:1
    File<EMAIL_ADDRESS>not found.
[default] C:\Users\xeno\IdeaProjects\rpf-ui\src\security\register\RegistrationSvc.ts:4:45
    Cannot find module 'src/security/authn/credentials/UsernamePasswordCredentials'.
[default] C:\Users\xeno\IdeaProjects\rpf-ui\typings\globals\whatwg-fetch\index.d.ts:88:11
    Cannot find name 'ReadableStream'.
[default] Checking finished with 3 errors

not sure if it's related...

figured it out.
https://github.com/Microsoft/TypeScript/issues/10708#issuecomment-244760507

I started yesterday a new project in a clean environment using au CLI. I am experiencing this problem:

au build
...
error TS2304: Cannot find name 'URLSearchParams'.
error TS2304: Cannot find name 'ReadableStream'.

I am rather new in this environment and I do not know how to solve the issue.

Those are issues related to TypeScript type definitions which you would need to find. You can just create dummy definitions for those if you can't find official versions. FYI Those definitions are for standard types and should be provided by TypeScript but may not be there yet.

for the typescript webpack skeleton has this (Modified)
}
declare module "isomorphic-fetch" {
    export = fetch;
}

and I needed to add these typings install
{
  "globalDependencies": {
    "whatwg-fetch": "registry:dt/whatwg-fetch#0.0.0+20160829180742",
    "whatwg-streams": "registry:dt/whatwg-streams#0.0.0+20160829180742"
  }
}

it would be nice if there were better docs for this...

Instead of using the skeleton I created a new project using the CLI, i.e. the au new command. I am not sure about having the typescript webpack skeleton in my project folder. These are the webpack files that I have:
$ find . -name webpack*
./node_modules/bs-recipes/recipes/webpack.react-hot-loader
./node_modules/bs-recipes/recipes/webpack.react-hot-loader/webpack.config.js
./node_modules/bs-recipes/recipes/webpack.babel
./node_modules/bs-recipes/recipes/webpack.babel/webpack.config.js
./node_modules/bs-recipes/recipes/webpack.monkey-hot-loader
./node_modules/bs-recipes/recipes/webpack.monkey-hot-loader/webpack.config.js
./node_modules/bs-recipes/recipes/webpack.typescript
./node_modules/bs-recipes/recipes/webpack.typescript/webpack.config.js
./node_modules/bs-recipes/recipes/webpack.react-transform-hmr
./node_modules/bs-recipes/recipes/webpack.react-transform-hmr/webpack.config.js
./node_modules/bs-recipes/recipes/webpack.typescript.react
./node_modules/bs-recipes/recipes/webpack.typescript.react/webpack.common.config.js
./node_modules/bs-recipes/recipes/webpack.typescript.react/webpack.dev.config.js
./node_modules/bs-recipes/recipes/webpack.typescript.react/webpack.config.js

Anyway, since I am just starting (in fact I only pretend to build a quick proof of concept before starting a new project) maybe the easiest option is to switch to ES and forget about TS by now?

It's unfortunate that a project generated with au new doesn't build as soon as you import aurelia-fetch-client. The module is installed by default but there are several steps to make it usable:

Add missing typings

typings i dt~whatwg-fetch -GS
typings i dt~whatwg-streams -GS

Create custom d.ts fiel for missing URLSearchParams
I added a aurelia-fetch-client-fix.d.ts file to the custom_typings folder

declare type URLSearchParams = {}

Add missing aurelia-fetch-client dependency in aurelia.json bundle config.

Hope this helps someone.

Thank's a lot @Costo I hit the same exact thing with a default typescript project also. While I think it's reasonable to expect users to edit aurelia.json this early on for adding third party stuff to a new project, could above be done by default for typescript projects for aurelia-fetch-client? if user selects 'install dependencies' it's installed by default right (unlike http-client)?

For the URLSearchParams, I didn't want to introduce a custom typings file into my project so I created a simple repo which you can add with:
typings install github:RomkeVdMeulen/URLSearchParams --global --save

@anthonyborell did you solve the duplicate BufferSource issue?
Compiling with Typescript 1.8.10 works fine. Upgraded to 2.0.3 creates a conflicting BufferSource with the lib.d.ts file - which is supposed to be excluded, since node_modules folder is excluded in the tsconfig file.
n00b out of my depth here :(

Hey @InquisitorJax, sorry for the late reply. I ended up solving this issue completely in my aurelia project.
Using the aurelia-cli v0.18.0, I created a new typescript project au new then npm installed aurelia-fetch-client v1.0.0 and whatwg-fetch v1.0.0. Then I added this typings file to my custom_typings folder.
// Type definitions for fetch API
// Project: https://github.com/github/fetch
// Definitions by: Ryan Graham <https://github.com/ryan-codingintrigue>
// Definitions: https://github.com/borisyankov/DefinitelyTyped

// @cmichaelgraham - removed explicit external reference

// @cmichaelgraham - added BufferSource and URLSearchParams interfaces to help compilation
interface URLSearchParams {}

declare class Request {
	constructor(input: string|Request, init?:RequestInit);
	method: string;
	url: string;
	headers: Headers;
	context: RequestContext;
	referrer: string;
	mode: RequestMode;
	credentials: RequestCredentials;
	cache: RequestCache;
}

interface RequestInit {
	method?: string;
	headers?: HeaderInit|{ [index: string]: string };
	body?: BodyInit;
	mode?: RequestMode;
	credentials?: RequestCredentials;
	cache?: RequestCache;
}

declare enum RequestContext {
	"audio", "beacon", "cspreport", "download", "embed", "eventsource", "favicon", "fetch",
	"font", "form", "frame", "hyperlink", "iframe", "image", "imageset", "import",
	"internal", "location", "manifest", "object", "ping", "plugin", "prefetch", "script",
	"serviceworker", "sharedworker", "subresource", "style", "track", "video", "worker",
	"xmlhttprequest", "xslt"
}
declare enum RequestMode { "same-origin", "no-cors", "cors" }
declare enum RequestCredentials { "omit", "same-origin", "include" }
declare enum RequestCache { "default", "no-store", "reload", "no-cache", "force-cache", "only-if-cached" }

declare class Headers {
	append(name: string, value: string): void;
	delete(name: string):void;
	get(name: string): string;
	getAll(name: string): Array<string>;
	has(name: string): boolean;
	set(name: string, value: string): void;
}

declare class Body {
	bodyUsed: boolean;
	arrayBuffer(): Promise<ArrayBuffer>;
	blob(): Promise<Blob>;
	formData(): Promise<FormData>;
	json(): Promise<any>;
	text(): Promise<string>;
}
declare class Response extends Body {
	constructor(body?: BodyInit, init?: ResponseInit);
	error(): Response;
	redirect(url: string, status: number): Response;
	type: ResponseType;
	url: string;
	status: number;
	ok: boolean;
	statusText: string;
	headers: Headers;
	clone(): Response;
}

declare enum ResponseType { "basic", "cors", "default", "error", "opaque" }

declare class ResponseInit {
	status: number;
	statusText: string;
	headers: HeaderInit;
}

declare type HeaderInit = Headers|Array<string>;
declare type BodyInit = Blob|FormData|string;
declare type RequestInfo = Request|string;

interface Window {
	fetch(url: string, init?: RequestInit): Promise<Response>;
}

Then in the .ts file I want to use HttpClient/Fetch I add:
import 'whatwg-fetch';
import {HttpClient} from 'aurelia-fetch-client';


otlp: Remove OTel feature gate registration from copied translation package

This change removes OTel Collector feature gates registered in copied translation packages.  These feature gates are not used in Prometheus and create duplicate registration conflicts if both the OTel and copied translation packages are imported.  Due to the state of the individual feature gates and their uses this change has no effect on the behavior of the translation packages.

Yes, we're coming back to this after off-site 🙂

@Aneurysm9 This PR is now unblocked, please rebase your PR

@Aneurysm9 thanks for your PR, I took the liberty of rebasing it to get the latest changes from main.


Pytests are taking too long

Most of CI runs cancelled as it takes almost 6 hours. We need to reduce testing time or shorten test list for each PR verification.
Possible solution is to have full suit nightly, and shorten for regular PR verification.

I noticed that too. Running test_core.py takes too much time. A good point was that it was reaching like 99%. I think we can put a timeout for now. My speculation is taking too much time in compilations?

Ilya reduced time of tests in PR #83 .


Failed to establish a socket connection to proxies

Extension version: v0.60.0
VSCode Version:

Version: 1.76.0
Commit: 92da9481c0904c6adfe372c12da3b7748d74bdcb
Date: 2023-03-01T10:23:45.993Z (1 wk ago)
Electron: 19.1.11
Chromium: 102.0.5005.196
Node.js: 16.14.2
V8: <IP_ADDRESS>-electron.0
OS: Darwin x64 22.3.0
Sandboxed: No

OS: MacOS 13.2.1

Steps to Reproduce:
I'm configuring my dev environment directly in a dev container by following this doc but now this extension stopped working and does not load any data in the left toolbar. This is the error message:
Fetching pull requests failed: request to https://api.github.com/repos/mautic/mautic/pulls?per_page=20&page=1 failed, reason: Failed to establish a socket connection to proxies: ["PROXY <IP_ADDRESS>:9000"]

Is there any suggestion anyone could give me to try to fix this issue?
This might be related to https://github.com/microsoft/vscode-pull-request-github/issues/701 but I'm not sure and if it is then it looks like I'm screwed like the Chinese nation.

@escopecz are you using the http.proxy setting?

It is empty at the moment. Shall I try putting some value in it?

I did not start from a template. We had an existing docker-compose setup but it started to be painfully slow after upgrading to MacOs 13. When I ditch all the volumes shared with MacOs and attach VS Code to the container then it's very fast.
I don't see anything specific in https://github.com/microsoft/vscode-remote-try-node that would enable this extension's socket connection. Am I missing something?

@escopecz is this in a public repo? I'd like to try out the exact scenario.

The project itself is a public repo, but the dev docker is closed source as it contains some proprietary code.

Hmm. Which part of https://code.visualstudio.com/docs/devcontainers/containers were you following?

As my team is using docker compose as the setup is not trivial I followed https://code.visualstudio.com/remote/advancedcontainers/connect-multiple-containers
Most of my team is using other editor than VS code for development so I made only minimal change to the dev docker setup and the rest is configured via local config overrides. I know I'm not very helpful debugging this, but not sure how to debug this further.

I have managed to override this by going to the user settings, and changing the application proxy extension settings to off. The initial setting was on override which is manual proxy configuration. Setting it on will use the hosting system settings and off will not use a proxy at all.

高低得给您鞠一躬！

I am using Mac, I changed the network settings, and it works fine
System Preferences   >  Network   >  Advanced >  Proxies
Uncheck all  and save

Thanks for posting your solution, I am very grateful!!


Merge master to live

Docs Build status updates of commit 0953d3e:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

office-365-management-api/office-365-service-communications-api-reference.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


DEV: Fluids Report: Request Object Selection Capability True

EPIC:
#491 Fluids Report Implementation
PARENT:
#492 Get From Store Fluids Report Object
SIZE:
8 hrs = 1 day = 2 points
Dev - Request Object Selection Capability True – Return State Object with/fake data

@sukhendumukherjee will deliver with 7/29

Dev Complete


chore(deps): upgrade dependencies

Upgrades project dependencies. See details in workflow run.

Automatically created by projen via the "upgrade-k8s-24-main" workflow

⚪ Backport skipped
The pull request was not backported as there were no branches to backport to. If this is a mistake, please apply the desired version labels or run the backport tool manually.
Manual backport
To create the backport manually run:
backport --pr 1913

Questions ?
Please refer to the Backport tool documentation


Subscription state listener

Question
How can you get a subscription's current state on Apollo 3.5?
Context
Previously on Apollo 2 we could have access through the subscription manager doing the following:
 apolloClient.subscriptionManager.addOnStateChangeListener { fromState, toState ->
         if(toState = SubscriptionManagerState.DISCONNECTED) {
              ....
         }
         if (toState = SubscriptionManagerState.ACTIVE) {
             ....
         }
    }

Hi!
There is no equivalent in 3.x. Did you use this as a way to reconnect automatically? If so, there is now a webSocketReopenWhen lambda that you can set on the ApolloClient. If you used it for another reason maybe you can tell us a bit more and try to find a way to do it with v3.

Hi @BoD, so I'm currently using the webSocketReopenWhen to reconnect automatically.
Basically I would like to know when my socket is disconnected and when is back to an active state so I know when to fetch from the server the data that should have been delivered during this subscription downtime.

Interesting! To know when it is disconnected, webSocketReopenWhen would work, but there is no signal for connected.
We could add an API (to be determined) for this, but in the meantime what you could do is have your own implementation of WebSocketEngine based on the default one, but adding a listener.
That will work, hopefully there will be a cleaner solution later on :)

Thinking out loud about the best solution for this problem:

know when my socket is disconnected and when is back to an active state so I know when to fetch from the server the data that should have been delivered during this subscription downtime.

I think live queries is the ultimate solution you're looking for (which is neither specified nor implemented yet unfortunately).
Until we have that nice future-proof technology, I'm wondering if it'd make sense to handle the state "locally" instead of relying on the "global" reconnect. Something like this:
    flow {
      apolloClient.subscription(TripsBookedSubscription())
          .toFlow()
          .onStart {
            // Get the latest "initial" state
            emit(apolloClient.query(GetDataQuery()).toEvent())
          }
          .retry { true }
          .collect {
            emit(it.data)
          }
    }

Since the data that you're missing is somewhat related to the subscription, it might make sense to colocate this? Would you mind sharing more details about your use case there?

Hi @martinbonnin
Any updates about Live Query? I can't find anything related.


Handle more safety conditions

There are a few mishandled exception around; take a look for where they might be.
One known one is that a end-user shouldn’t see a file not found message.

I think this is in a good spot for now
/remove-lifecycle stale
/close


Relax finch version requirement to allow 0.12

See the associated Finch Changelog. It appears that the only breaking changes are to do with Telemetry, which I don't believe Req interacts with currently.
Finch 0.12.0 also adds non-GET request support when using an HTTP proxy.

Thank you!


TSAN violations for Distribution ops (reoccurrence of #1755 and #1768)

What happened?
The following 6 tests are failing (crash) upon upgrading StableHLO in our downstream repo to https://github.com/openxla/stablehlo/tree/5a8bb985f50a679721292b14f97f270344ac64a3.
@stablehlo//stablehlo/tests:interpret_all_gather.mlir.test      (remote) FAILED in 7.8s
@stablehlo//stablehlo/tests:interpret_all_reduce.mlir.test      (remote) FAILED in 7.0s
@stablehlo//stablehlo/tests:interpret_all_to_all.mlir.test      (remote) FAILED in 7.7s
@stablehlo//stablehlo/tests:interpret_collective_permute.mlir.test (remote) FAILED in 8.2s
@stablehlo//stablehlo/tests:interpret_reduce_scatter.mlir.test  (remote) FAILED in 7.0s
@stablehlo//stablehlo/tests:interpret_send_recv.mlir.test       (remote) FAILED in 5.9s

These fail with bazel test but pass with bazel run. We believe these are related to TSAN violations for distributions ops going by https://github.com/openxla/stablehlo/pull/1768 where exactly these six tests were re-enabled.
Here's the crash dump for one of the above (all fail the same way)
==================== Test output for @stablehlo//stablehlo/tests:interpret_all_gather.mlir.test:
-- Testing: 1 tests, 1 workers --
FAIL: STABLEHLO_TESTS_SUITE :: interpret_all_gather.mlir (1 of 1)
******************** TEST 'STABLEHLO_TESTS_SUITE :: interpret_all_gather.mlir' FAILED ********************
Exit Code: 134

Command Output (stderr):
--
RUN: at line 1: /external/stablehlo/stablehlo-translate --interpret -split-input-file /external/stablehlo/stablehlo/tests/interpret_all_gather.mlir                                                                                + /external/stablehlo/stablehlo-translate --interpret -split-input-file /external/stablehlo/stablehlo/tests/interpret_all_gather.mlir
LLVM ERROR: rendezvous timed out: not all process has received the results yet
PLEASE submit a bug report to https://github.com/llvm/llvm-project/issues/ and include the crash backtrace.
Stack dump without symbol names (ensure you have llvm-symbolizer in your PATH or set the environment var `LLVM_SYMBOLIZER_PATH` to point to it):
0  stablehlo-translate 0x000055a8ab070d0e
1  stablehlo-translate 0x000055a8ab06eb67
2  stablehlo-translate 0x000055a8ab071431
3  libpthread.so.0     0x00007face4c50980
4  libc.so.6           0x00007face488be87 gsignal + 199
5  libc.so.6           0x00007face488d7f1 abort + 321
6  stablehlo-translate 0x000055a8ab09dacd
7  stablehlo-translate 0x000055a8ab09d8eb
8  stablehlo-translate 0x000055a8a73f15a2
9  stablehlo-translate 0x000055a8a73edbc1
10 stablehlo-translate 0x000055a8a73c3488
11 stablehlo-translate 0x000055a8a73b1e41
12 stablehlo-translate 0x000055a8a73a7e2f
13 stablehlo-translate 0x000055a8a73abd23
14 stablehlo-translate 0x000055a8ab056ef3
15 stablehlo-translate 0x000055a8ab057a04
16 libpthread.so.0     0x00007face4c456db
17 libc.so.6           0x00007face496e61f clone + 63
/external/stablehlo/stablehlo/tests/Output/interpret_all_gather.mlir.script: line 1:    32 Aborted                 (core dumped) /external/stablehlo/stablehlo-translate --interpret -split-input-file /external/stablehlo/stablehlo/tests/interpret_all_gather.mlir

--

********************
********************
Failed Tests (1):
  STABLEHLO_TESTS_SUITE :: interpret_all_gather.mlir

Testing Time: 6.66s
  Failed: 1
Remote action<PHONE_NUMBER>edaebede608005c2dc46d514bdf8b3f8c708337294bf9f8740f28a/381 failed with action exit code 1 and gRPC status 0

Steps to reproduce your issue

Go to '...'
Click on '....'
Scroll down to '....'
See error

Version information
Trying to upgrade to https://github.com/openxla/stablehlo/tree/5a8bb985f50a679721292b14f97f270344ac64a3.

@ghpvnist , @burmako , @GleasonK PTAL.

Hi, thanks for filing the bug.
Unfortunately, I'm not able to repro this issue on my end., but just to get the usual out of the way, have you tried building from scratch? e.g. bazel clean --expunge
What platform are you on? I haven't run into the issue locally running both bazel test //stablehlo/tests:all and bazel run //stablehlo/tests:all and our CI has been running bazel test on HEAD.  We've also been testing on linux with no issues since and don't have any tsan violations.

Closing this ticket since I haven't heard back in a few months (assuming it's resolved) with additional context. Feel free to reopen if this is still an issue.


Get geolocation about a given IP address

Using Fastly's Compute@Edge and getGeolocationForIPAddress to get Geolocation information about a given IP.

@cegerhardson I think if you configure the service id here: https://github.com/pypi/infra/pull/138/files#diff-091f525b8dbb48737c908263259c0fbb5eb7b3488c22c76fd4d86ce631047d4bR9
it should stop blowing up.


[AP-3330] bank statement upload employed journey feature tests

What
Link to story
Change bank statement upload feature tests to include employed journey
with income page.
This proved flaky in the main flow branch for AP-3264 so was separated
out.
Checklist
Before you ask people to review this PR:

Tests and rubocop should be passing: bundle exec rake
Github should not be reporting conflicts; you should have recently run git rebase main.
There should be no unnecessary whitespace changes. These make diffs harder to read and conflicts more likely.
The PR description should say what you changed and why, with a link to the JIRA story.
You should have looked at the diff against main and ensured that nothing unexpected is included in your changes.
You should have checked that the commit messages say why the change was made.

This is a branch off of jsugarman/ap-3264-provider-means-flow but with the bank statement employment journey feature tests in place.


Require friendsofsymfony/elastica-bundle dev-master

friendsofsymfony/elastica-bundle master branch now support elasticsearch 5.x. It would be good to allow use it with enqueue/elastica-bundle

fixed https://github.com/php-enqueue/enqueue-elastica-bundle/commit/ad965763be7ad4a3abe989abdae0c1526f9054cb


WIP Drop test that impact other tests

✅ Checklist

[ ] npx changeset was attached.
[ ] Covered by automatic tests.
[ ] Impact of the changes:

...

📝 Description
Replace this text by a clear and concise description of what this pull request is about and why it is needed. Be sure to explain the problem you're addressing and the solution you're proposing.
For libraries, you can add a code sample of how to use it.
For bug fixes, you can explain the previous behaviour and how it was fixed.
In case of visual features, please attach screenshots or video recordings to demonstrate the changes.

❓ Context

JIRA or GitHub link:

🧐 Checklist for the PR Reviewers

The code aligns with the requirements described in the linked JIRA or GitHub issue.
The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
There are no undocumented trade-offs, technical debt, or maintainability issues.
The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
Any new dependencies have been justified and documented.
Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

/regenerate-screenshots

/generate-screenshots

@KVNLS
Generating screenshots: workflow started

/generate-screenshots

/generate-screenshots


Generated SDK modules and recorded tests for UltraSSDCapability property in Dedicated Hosts for API version 2022-03-01 Compute #27949

Contributing to the Azure SDK
Please see our CONTRIBUTING.md if you are not familiar with contributing to this repository or have questions.
For specific information about pull request etiquette and best practices, see this section.

/azp run net - mgmt - ci

/azp run net - mgmt - ci

/azp run net - mgmt - ci

/azp run net - mgmt - ci


adding bluetooth call feature

Is there a way to add not only the Bluetooth audio feature but the Bluetooth call feature?
I would like to be able to receive calls when i have my headsets connected to my computer.
If anything can someone at least guide me to show how i could implement this in pull request?
https://github.com/ysc3839/AudioPlaybackConnector/assets/94718699/13f3cc43-f15f-405f-807a-bb07cbaa97ee

No. Windows does not provide such feature at this time.


Subtag Descriptions In UDTs only returning base tag.

When Looping through each members in a tag, the descriptions of those sub-tags only returns the description of the highest level tag when using the .Description function
foreach (var subtag in tag.Members()) {
    Console.Writeline(subtag.Description);
}

Will always return the same description

Fixed with version 0.14.0

This is outstanding! Thank you so much for the hard work!


class file for java.lang.invoke.MethodType not found

I tried to setup new sample project and it can't compile.
An exception has occurred in the compiler (1.8.0_05). Please file a bug at the Java Developer Connection (http://java.sun.com/webapps/bugreport)  after checking the Bug Parade for duplicates. Include your program and the following diagnostic in your report.  Thank you.
com.sun.tools.javac.code.Symbol$CompletionFailure: class file for java.lang.invoke.MethodType not found

* Exception is:
org.gradle.api.tasks.TaskExecutionException: Execution failed for task ':app:compileDebugJava'.
	at org.gradle.api.internal.tasks.execution.ExecuteActionsTaskExecuter.executeActions(ExecuteActionsTaskExecuter.java:69)
	at org.gradle.api.internal.tasks.execution.ExecuteActionsTaskExecuter.execute(ExecuteActionsTaskExecuter.java:46)
	at org.gradle.api.internal.tasks.execution.PostExecutionAnalysisTaskExecuter.execute(PostExecutionAnalysisTaskExecuter.java:35)
.
.
.
Caused by: org.gradle.api.internal.tasks.compile.CompilationFailedException: Compilation failed; see the compiler error output for details.
	at org.gradle.api.internal.tasks.compile.jdk6.Jdk6JavaCompiler.execute(Jdk6JavaCompiler.java:47)
	at org.gradle.api.internal.tasks.compile.jdk6.Jdk6JavaCompiler.execute(Jdk6JavaCompiler.java:38)
	at org.gradle.api.internal.tasks.compile.NormalizingJavaCompiler.delegateAndHandleErrors(NormalizingJavaCompiler.java:96)
	at org.gradle.api.internal.tasks.compile.NormalizingJavaCompiler.execute(NormalizingJavaCompiler.java:49)
	at org.gradle.api.internal.tasks.compile.NormalizingJavaCompiler.execute(NormalizingJavaCompiler.java:35)
	at org.gradle.api.internal.tasks.compile.DelegatingJavaCompiler.execute(DelegatingJavaCompiler.java:29)
	at org.gradle.api.internal.tasks.compile.DelegatingJavaCompiler.execute(DelegatingJavaCompiler.java:20)
	at org.gradle.api.internal.tasks.compile.IncrementalJavaCompilerSupport.execute(IncrementalJavaCompilerSupport.java:33)
	at org.gradle.api.internal.tasks.compile.IncrementalJavaCompilerSupport.execute(IncrementalJavaCompilerSupport.java:24)
	at org.gradle.api.tasks.compile.Compile.compile(Compile.java:67)
	at org.gradle.internal.reflect.JavaMethod.invoke(JavaMethod.java:63)
	at org.gradle.api.internal.project.taskfactory.AnnotationProcessingTaskFactory$StandardTaskAction.doExecute(AnnotationProcessingTaskFactory.java:219)
	at org.gradle.api.internal.project.taskfactory.AnnotationProcessingTaskFactory$StandardTaskAction.execute(AnnotationProcessingTaskFactory.java:212)
	at org.gradle.api.internal.project.taskfactory.AnnotationProcessingTaskFactory$StandardTaskAction.execute(AnnotationProcessingTaskFactory.java:201)
	at org.gradle.api.internal.AbstractTask$TaskActionWrapper.execute(AbstractTask.java:533)
	at org.gradle.api.internal.AbstractTask$TaskActionWrapper.execute(AbstractTask.java:516)
	at org.gradle.api.internal.tasks.execution.ExecuteActionsTaskExecuter.executeAction(ExecuteActionsTaskExecuter.java:80)
	at org.gradle.api.internal.tasks.execution.ExecuteActionsTaskExecuter.executeActions(ExecuteActionsTaskExecuter.java:61)
	... 72 more

Setup is similar as in the doc except:
retrolambda {
    jdk System.getenv("JAVA8_HOME")
    oldJdk System.getenv("JAVA7_HOME")
    javaVersion JavaVersion.VERSION_1_7
}

Environment variables are set to:
/Library/Java/JavaVirtualMachines/jdk1.8.0_05.jdk/Contents/Home
/Library/Java/JavaVirtualMachines/jdk1.7.0_51.jdk/Contents/Home
respectively.

I got the same error when I used in RxJava lambda alternative of this:
new Func1<Throwable, Boolean>() {
   @Override
   public Boolean call(Throwable throwable) {
            return false;
   }
}

it was in RxJava method onErrorReturn. It was in unit test.
Solution for me was using old way interface

Hey,
I think we need to reopen this issue. Gradle plugin - v1.1.0-rc1 introduced basic support for unit tests. When you use lambda expressions in a unit test (as @hanibalsk mentioned in above comment) compiler fails with
com.sun.tools.javac.code.Symbol$CompletionFailure: class file for java.lang.invoke.MethodType not found

I had no time to investigate it deeper, but I guess there's now separated task for compiling test sources, like compileUnittTestJava, and since Retrolambda gradle plugin substitutes compile<Variant>Java task it might be needed to do the same for compile<Variant>UnitTestJava. At first sight seems like it doesn't do that, so compiler fails on compiling unit tests' sources.
We'd appreciate to have it fixed, since unit testing now becomes a little less pain as before and more people starts writing them :)

Thanks, I created a new issue for it https://github.com/evant/gradle-retrolambda/issues/86

I too am having a very similar issue.  Except it has started once I upgraded to Android Studio 2 preview.  I get the error

An exception has occurred in the compiler (1.8.0_65). Please file a bug at the Java Bug Database (http://bugreport.java.com/bugreport/) after checking the database for duplicates. Include your program and the following diagnostic in your report.  Thank you.
com.sun.tools.javac.code.Symbol$CompletionFailure: class file for java.lang.invoke.MethodType not found
Error:Execution failed for task ':Autosense:compilePaidDebugJavaWithJavac'.
Compilation failed; see the compiler error output for details.

If I compile from the command line everything works.
I've got posts on the Android Studio bug list as well as Stackoverflow

@hanibalsk what is the "old way interface" you mention? I'm using a lot of the Callable thing and now my code breaks with the exact same error : (

i delete this
retrolambda {
jdk System.getenv("JAVA8_HOME")
oldJdk System.getenv("JAVA6_HOME")
javaVersion JavaVersion.VERSION_1_6
jvmArgs '-arg1', '-arg2'
defaultMethods false
incremental true
}
then  OK!!


Update README, .travis.yml for Melodic

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Verified ros-melodic-cloudwatch-logger in ROS melodic
Passed Travis https://travis-ci.org/aws-robotics/cloudwatchmetrics-ros1/builds/520487495?utm_source=github_status&utm_medium=notification


More validation of TfJob

We should add more validation to TfJobSpec.Validate so that we reject invalid jobs with clear error messages.
Things to check

At least 1 ReplicaSet is specified
There is a MASTER
There aren't multiple ReplicaSet's of the same type

dup with #437


aldeed:collection2 not available

Hi. I am going through autoform examples I cant seem to install collection2 package, it says no such package.

Sorted, PC had duplicate versions of Meteor.


Honor delta_lake marker for pytest [databricks]

Signed-off-by: Peixin Li<EMAIL_ADDRESS>fix #6347
honor --delta_lake marker. If not exist, we should skip by default

build


Can this class work with wchar_t / std::wstring?

Bug Report

What is the issue you have?
Failed to parse wchar_t string
Please describe the steps to reproduce the issue. Can you provide a small but working code example?
json::parse(wstring) failed
What is the expected behavior?
the string was parsed
And what is the actual behavior instead?
error
Which compiler and operating system are you using? Is it a [supported compiler]
VS 2017 Community edition
Did you use a released version of the library or the version from the develop branch?
Took from developer branch
If you experience a compilation error: can you compile and run the unit tests?

Feature Request

Describe the feature in as much detail as possible.

Include sample usage where appropriate.

Related: #722 #216

wstring is currently not supported.

That's pity. Thank you.

Well, I think it this could be fixed by writing an input adapter for std::wstring, std::u16string, and std::u32string. I'll see what I can do.

So my naive approach would be to implement an input adapter for std::wstring, std::u16string, and std::u32string and take care of the translation between UTF-32 and UTF-16 to UTF-8, respectively. This adapter would read a character from the string and internally offer several UTF-8 bytes to the consumer of the input adapter. This would allow to reuse the lexer/parser chain for JSON files.
I shall open a feature branch, but would be happy for any comment whether I overlooked some fundamental flaw in this idea.

On a previous project I derived a string class from std::string that gave me my utf-8/16/32 support.  My suggestion is to consider doing the same.
The benefit would be that it would also give generic utf string support everywhere else where you would use it.  ie: json::string instead of std::string. There are open source versions floating around but it is easy to roll your own.
But that's my 2 cents worth.

@us-er-name I don't fully understand. You mean to use a Unicode-friendly user-defined string class which is basically std::string plus some conversion functions? But how does this play with templating the JSON string type?

I apologise if I'm way off base here.  To answer your first question: yes.
Once, in my own code, I was having difficulty supporting different string types so I finally got tired of it and wrote my own string class that was derived off std::string.  I added utf-8/16/32 support and used it instead.  I replaced all std::string in my code to myspace::string and that was it.  Now I was able to pass wstring, u16string, u32string and cast back and forth without problems.  The conversion was minor in my case.
You have a lot of code so I didn't go over it in any detail but I was wondering if you could do the same and then you would also have the benefit of having a generic string class that could be used for other purposes as well. Either way it is done, it mainly boils down  to a set of routines converting to and from utf-8, utf-16, utf-32.
In the end, it winds up to have the same result - your code internally will be utf friendly.  My suggestion was to create a utf string class that you use so that the same objective is achieved plus the added benefit of creating this utf friendly string class that could be used by itself as well - an extra bonus.
ie:
using utf = nlohmann::utf; // namespace nlohmann { namespace utf { class string : public std::string { ...
now:
utf::string mystring; // Unicode friendly string
Something like that. Just a quick glance it seems like you have made provisions to support others than just std::string.  I see in a template definition:
class StringType = std::string
Would be nice if you had your own utf string class and then it could be changed (using my first example) to:
class StringType = utf::string
As I said, I may be way off base here. Sometimes things like this go easy and sometimes it can't be done without major rework. You tagged this thread as "please discuss" so this was just a suggestion (assuming it could be done). You know your own code much better than me.

Thanks for clarifying!
My current take would be to use UTF-8 internally and convert UTF-16 and UTF-32 strings into UTF-8 while parsing. This would then allow any user-defined string type to be used in the library as long as it is fine with UTF-8. Another place for recoding would then be the serialization function which currently assumes UTF-8. Furthermore, assignment from/to strings would need similar code as parsing/serializing.
A Unicode-friendly string class would simplify a lot (the parser would need to be adjusted), but I have no idea how to mix this with the option to pass a user-defined string type to the library. And the latter is used by some folks on embedded devices which implement all kinds of optimizations into their strings.

We're pretty much talking the same thing. I was suggesting using UTF-8 internally, storing it in a std::string.  You already use std::string internally.  The new class would be just to encapsulate the UTF-16 and UTF-32 methods instead of being parts of other code. So it is really just an enhanced version of  std::string.  If anyone else has used a customised string type then this should not interfere.
I believe this satisfies your parts of your definition: "My current take would be to use UTF-8 internally" and "This would then allow any user-defined string type to be used in the library as long as it is fine with UTF-8".  The only difference is where conversions are done.
I tried to quickly write this utf class to show you (and you could use if you liked it), but I got stuck in the code section:
template<> struct hash<nlohmann::json>

Your default is to use std::string in the hash - for which there is a template specialisation but my derived class does not.  Thus my compile fails with a deleted constructor error.  I've never delved deep into std:: stuff, especially std::hash. So I am unable to get my class to compile. I also have not kept up with the latest c++ template goodies so it is quickly becoming a painful experience.  Except for this hash stuff, everything else seems simple to switch over to my new class.
I noticed that your code does not handle UTF-8 at the moment but this class could help in that.
ie: You use std::string::find_first_of() which is not UTF-8 aware.  If you had your own string class then you would simply rewrite it.
I've decided to post what I have so far. Except for the hash stuff, the rest compiles.  Obviously no chance to debug. At least it shows what I was aiming for.
#include <string> // string, stoi, to_string
namespace utf {
	class string : public std::string {
	public:
		string() {}
		string(size_type n, char c) { assign(n, c); }
		string(const char * s, std::size_t n) { assign(s, n); }
		string(const char * s) { assign(s); }
		string(const string & s) { *this = s; }
		string(std::string & s) { assign(s); }
		friend string operator+(const string& lhs, const string& rhs) { return (std::string)lhs + (std::string)rhs; }
		friend string operator+(const string& lhs, const char * rhs) { return (std::string)lhs + rhs; }
		friend string operator+(const char * lhs, const string& rhs) { return lhs + (std::string)rhs; }
		friend string operator+(const string& lhs, char          rhs) { return (std::string)lhs + rhs; }
		friend string operator+(char          lhs, const string& rhs) { return lhs + (std::string)rhs; }

//		operator wstring() const;			// TODO
//		operator std::u16string() const;	// TODO
//		operator std::u32string() const;	// TODO
//		string(const wchar_t *);			// TODO
//		string(const char16_t *);			// TODO
//		string(const char32_t *);			// TODO
// Any others you find useful
	};
	string to_string(int id_) { return std::to_string(id_); }
}

I used the single header file and changed all std::string to utf::string.  If you do a global string replace, watch out for std::stringstream. Leave that as is.
There are two references to std::to_string which should be changed to utf::to_string.
The line:
auto reference_token = reference_string.substr(start, slash - start);

should have the keyword 'auto' changed to utf::string
As mentioned, the only compile errors should be with the hash stuff.
So close. sighs

Merged.


TF 2.5+ GPU build no longer works because CUDA 11 configure is not supported

With TensorFlow 2.5, there have been some code changes which require CUDA 11. You can read more about the issues when trying to build TF 2.5 against CUDA 10 here:
https://github.com/tensorflow/tensorflow/issues/49983
https://github.com/tensorflow/tensorflow/issues/48468
The build rules to configure CUDA in this custom-op repo (https://github.com/tensorflow/custom-op/tree/master/gpu) have not been updated in a long time. Because of that, it is not possible to compile against newer CUDA versions so we can no longer build our custom gpu plugin against newer TF releases.
Questions

Will this repository be updated to support newer versions of CUDA? Otherwise, it is impossible to build custom gpu ops with newer TF versions (2.5+).
There is an alternative way to build custom ops through using the main TensorFlow repository by placing the custom op code in this folder https://github.com/tensorflow/tensorflow/tree/master/tensorflow/core/user_ops which will reuse the configuration code from the main tensorflow repository. Is this the recommended approach moving forward and will this repository be deprecated? Is this approach equivalent in terms of what kind of plugins can be built?

Thanks!

Hey @trevor-m while this repo appears to be stale, there isn't too many modification that need to be made to support TF2.5+. You can check the changes that addons made:
https://github.com/tensorflow/addons/pull/2441/files
https://github.com/tensorflow/addons/pull/2218/files
https://github.com/tensorflow/addons/tree/master/build_deps

Alternatively it does look like you can use that user_ops directory if you're compiling TF from source and not a plugin library

Hi @seanpmorgan, thanks for the response!
Actually, there are more incremental changes needed to compile against TF 2.5:
https://github.com/tensorflow/addons/pull/2218
https://github.com/tensorflow/addons/pull/1950
Will this repository be updated with those changes?

Alternatively it does look like you can use that user_ops directory if you're compiling TF from source and not a plugin library

I see, so it is not possible to build a plugin using the user_ops directory?


[Bug]: LiteLLM BadRequest - VertexAI Exception

Is there an existing issue for the same bug?

[X] I have checked the troubleshooting document at https://docs.all-hands.dev/modules/usage/troubleshooting
[X] I have checked the existing issues.

Describe the bug
litellm.exceptions.BadRequestError: litellm.BadRequestError: VertexAIException BadRequestError│
 - {                                                                                │
  "error": {                                                                                │
    "code": 400,                                                                              │
    "message": "Invalid JSON payload received. Unknown name \"text\" at 'system_instruction.pa│
rts[0]': Proto field is not repeating, cannot start list.",                                   │
    "status": "INVALID_ARGUMENT",                                                             │
    "details": [                                                                              │
      {                                                                                │
        "@type": "type.googleapis.com/google.rpc.BadRequest",                                 │
        "fieldViolations": [                                                                  │
          {                                                                                │
            "field": "system_instruction.parts[0]",                                           │
            "description": "Invalid JSON payload received. Unknown name \"text\" at 'system_in│
struction.parts[0]': Proto field is not repeating, cannot start list."                        │
          }                                                                                │
        ]                                                                                │
      }                                                                                │
    ]                                                                                │
  }                                                                                │
}

Current OpenDevin version
Building from HEAD

Installation and Configuration
mkae build; make run;

Model and Agent

Model: gemini/gemini-1.5-pro
Agent: CodeActAgent

Operating System
OS: Debian GNU/Linux rodete
Reproduction Steps
No response
Logs, Errors, Screenshots, and Additional Context
No response

@neubig I am passing the API key through the UI. Also, it has been working fine for the past 2 months and broke only recently after the vision capabilities were added.

@SmartManoj thanks for the commit!

@RajWorking Is this fixed by SmartManoj's commit ?

This is being handled in PR #3665


Debian build and remove generated manpage on clean

Add configuration for building debian packages
Fix make clean to remove the generated manpage.

Thanks for the PR.
I've merged one of the changes.  I will review the rest shortly.

I'm sorry it took me so long to get back.
After pondering this for a while I've decided to not include any packaging files in here. This is better handle downstream.
Also, if I were to add deb support, there would be no reason to not accept rpm, tbz2, etc.
I prefer to keep the repository clean wrt packaging artifacts and let this be handled elsewhere.
Sorry if this is not the answer you were looking for and thanks again for the PR.


@xray-app/playwright-junit-reporter - Showing vulnerability on Jfrog Xray scans.

Hi @bitcoder ,
I am currently integrating new playwright tests to Xray TMT.
But when i need to use JFrog Xray scans as the standards of my organization.
CVE-2023-2968 - Severity: High
Impacted Components: proxy:1.0.2JFrog(XRAY-520917)
generate an enhanced JUnit XML report suitable for Xray with the playwright test results
Latest version: 0.3.0 published 1 month ago
https://github.com/Xray-App/playwright-junit-reporter
Is there a way to mitigate this ? or will this be addressed in the coming releases?
Please advice.
Thank you.

thanks for reporting @shrubom .
It needs to be analyzed by someone.
From a quick look it seems that it isn't applicable to this project.
If you look at the advisory, it mentions "proxy versions" >= 2.0.0, < 2.1.1, where this package is using "proxy" version 1.0.2
https://github.com/advisories/GHSA-mj6p-3pc9-wf5m

Thank you for the prompt response. Highly appreciated. :-)
Could you please confirm if I am using the correct npm dependency version?
"@xray-app/playwright-junit-reporter": "^0.3.0"
If it is the correct one, then I will contact my security team to analyze this from our end as well.

0.3.0 is the latest version of this package; I advise you to look at your package-lock.json file of your project to see what "proxy" version is being resolved  by npm and therefore being used in your project

Perfect. Thank you so much will do so and keep you posted. :)

any news on this topic @shrubom ? or can I close this?


Datasets

Could you provide datasets (such as train_SIDD_25000_2.hdf5, train_DND_25000_2.hdf5 and so on) or release the data-processing code?

Sorry for the late reply.
I just uploaded the new version of our code.
We could not upload whole training datasets because it is too big to upload my google drive.
However, I added the data-processing code for generating synthetic noise datasets in './data/'. I recommend to check it to solve your problem.
if you have any questions, places let me know.
Sungmin.