DE21128-broadcast-theme-hooks

Link(s) to demo pages where this element can be viewed:
http://localhost:8000/elements/pfe-card/demo/

What has changed and why

Added support for manual overrides to which theme context is invoked by surface colors. Previously the theme was "locked" into having 3 light theme colors, 2 dark, and 2 saturated. Now the themes can be redefined if desired.
Added demo file for pfe-card to test.

Testing instructions
Be sure to include detailed instructions on how your update can be tested by another developer.

Open the elements/pfe-card/demo/custom-theme.css
Change the values of the following variables. Make stuff up, but make the colors match the appropriate theme, like this:

  --pfe-theme--color--surface--lightest: purple;
  --pfe-theme--color--surface--lightest--theme: dark;
  --pfe-theme--color--surface--lighter: maroon;
  --pfe-theme--color--surface--lighter--theme: dark;
  --pfe-theme--color--surface--base: green;
  --pfe-theme--color--surface--base--theme: dark;
  --pfe-theme--color--surface--darker: pink;
  --pfe-theme--color--surface--darker--theme: light;
  --pfe-theme--color--surface--darkest: yellow;
  --pfe-theme--color--surface--darkest--theme: light;
  --pfe-theme--color--surface--complement: hotpink;
  --pfe-theme--color--surface--complement--theme: saturated;
  --pfe-theme--color--surface--accent: #c0ff33;
  --pfe-theme--color--surface--accent--theme: light;

The cards should reflect both the color and theme changes.

Browser requirements
Your component should work in all of the following environments:

[ ] Latest 2 versions of Edge
[ ] Internet Explorer 11 (should be useable, not pixel perfect)
[ ] Latest 2 versions of Firefox (one on Mac OS, one of Windows OS)
[ ] Firefox 60.7.2 (or latest version for Red Hat Enterprise Linux distribution)
[ ] Latest 2 versions of Chrome (one on Mac OS, one of Windows OS)
[ ] Latest 2 versions of Safari
[ ] Galaxy S9 Firefox
[ ] iPhone X Safari
[ ] iPad Pro Safari
[ ] Pixel 3 Chrome

Ready-for-merge Checklist

[x] Expected files: all files in this pull request are related to one feature request or issue (no stragglers)?
[x] Did browser testing pass?
[ ] Did you update or add any necessary documentation (README.md, WHY.md, etc.)?
[x] Was this feature demo'd and the design review approved?
[x] Did you update the CHANGELOG.md file with a summary of this update?

@castastrophe added!


Change redis ref keys to avoid breaking upgrades

To go up alongside https://github.com/laravel/framework/pull/12733 to prevent breaking upgrades as per discussion at https://github.com/laravel/framework/issues/13675

With this it wouldn't break but we should still recommend a cache flush right?

Yes, a flush is recommended but not required.

Both merged.

Great! I would like to revisit the tests next week just to improve what's there currently from 5.1 (noted when doing the commits). Although the mock tests won't pickup runtime errors. Perhaps a simulation?

@mstephens Did you get a chance to look at this please. We'd be massively grateful if you could fit it in, whenever. :)


Correction for raw affiliation Department of Psychology, King's University College at Western University, London, Canada

Correction needed for raw affiliation Department of Psychology, King's University College at Western University, London, Canada
raw_affiliation_name: Department of Psychology, King's University College at Western University, London, Canada
new_rors: 02grkyz14
previous_rors: 02grkyz14;048f5b183
works_examples: W4386407042
contact: ec9b6e4d14c1b6808651b2f3d91135be:a416f5721e46c3fc @ uwo.ca

This issue was accepted and ingested by the OpenAlex team on 2024-12-21. The new affiliations should be visible within the next 7 days.


blockReplacements strips my css tags of data-* attributes

I currently have a bunch of css files with the following:
<!-- build:css out.css -->
<link href="./my/css/file.css" data-my-attribute />
<link href="./my/css/file2.css" data-my-attribute />
<!-- enbuild -->

The outputted link tags are stripped of the data-my-attribute fields, and I have to override blockReplacements in order to get them. Is there a way around this, or do I have to do this by hand? It seems quite cumbersome to have to override blockReplacements just to get one attribute.

I think this issue have relation with #523

closing as a duplicate of #523


500 Ada Pool deposit lost if Rewards address is ever de-registered

I retired a pool and then de-registered the owner staking address and the rewards staking address. After realizing that the 500 ada deposit was supposed to be returned to the rewards address, I re-registered it on the chain. After the pool retired, no 500 ada back.
https://pooltool.io/pool/3b066c31e418ae43a63b621c148ffc076ad6c0715c1079790a0209f0
PoolID: 3b066c31e418ae43a63b621c148ffc076ad6c0715c1079790a0209f0
Owner Payment Address: addr1q9lwmtrrwamrgj7zadh0vz2e9cgxq99yley5f5h59s5x0vk0svw555dv93ag9jz3q8t89runhglpt43u2v7xs8hxff6sn0px4x
Owner Staking Address: stake1u88cx8222xkzc75zepgsr4nj37fm50s46c79x0rgrmny5ag9l92vy
Rewards Payment Address: addr1qyfgenmpkgz7vh3zjxz834lf2gqmvfxw2ae2juxpwch84lmyawmlck8cw87wp8xxan4g0wtrd7qryd45murg24etawjqf3am8r
Rewards Staking Address: stake1u9jwhdlutru8rl8qnnrwe658h93klqpjx66d7p592u47hfq5pdejf

Transferred to cardano-node for triage and priority assignment!

Basic advice obviously: don't do this :-)
From a brief reading of the ledger rules however, it looks to me like it ought to work if the stake address is re-registered in time. The POOLREAP transition (Fig 41) just needs the retiring pool to reference a registered stake address. And unregistering the stake address does not adjust the pools state at all. So it looks like it should work to re-register.
@JaredCorduan any thoughts? Am I misreading the spec?

I retired a pool and then de-registered the owner staking address and the rewards staking address. After realizing that the 500 ada deposit was supposed to be returned to the rewards address, I re-registered it on the chain. After the pool retired, no 500 ada back.

When you say that you "re-registered it", do you mean the owner stake credential, the reward stake credential, or both? The deposit goes back to the reward stake credential.

@JaredCorduan any thoughts? Am I misreading the spec?

I don't think so.  If the stake address that was listed in the stake pool registration certificate for the pool's rewards was re-registered in time it should have worked. There is still exactly 45B ada in the system, so that deposit either went to the address listed in the pool registration cert or was deemed unclaimed.
The possibilities of what went wrong are, as far as I can tell: it was the owner stake credential that was re-registered (not the reward one), or the stake credential re-registration did not get included in time.

I re-registered the reward stake address.

stake1u9jwhdlutru8rl8qnnrwe658h93klqpjx66d7p592u47hfq5pdejf

https://pooltool.io/pool/3b066c31e418ae43a63b621c148ffc076ad6c0715c1079790a0209f0 is showing that the reward account is:
e164ebb7fc58f871fce09cc6ecea87b9636f803236b4df0685572beba4

(I guess pooltool remembers pools after they retire?)
I looked at two ledger state dumps that I happened to have lying around, one from Aug 28th and one from today. Both showed that that reward account was not registered.
Did you de-register it a second time? Do you know about what day you first de-registered it, and what epoch the pool retired?

@JaredCorduan That is the correct rewards account. I'm showing it on chain. I did not de-register it a second time. It was de-registered once, and then re-registered. I haven't touched it since.

@AndrewWestberg if you never intentionally de-registered it a second time, then I think that something must have gone wrong with the re-registration.  you can see for yourself that e164ebb7fc58f871fce09cc6ecea87b9636f803236b4df0685572beba4 is not currently registered by inspecting a ledger state dump:
$ cardano-cli shelley query ledger-state --mainnet | grep e164ebb7fc58f871fce09cc6ecea87b9636f803236b4df0685572beba4

If it were currently registered, you would see grep find several matches, but when I run the above command I get nothing.
You are referring to a series of events on mainnet, correct?

@JaredCorduan It is on the chain. You need to remove the e1 from the beginning as that's a bech32 artifact.
$ cardano-cli shelley query stake-address-info --address stake1u9jwhdlutru8rl8qnnrwe658h93klqpjx66d7p592u47hfq5pdejf --cardano-mode --mainnet
[
    {
        "address": "stake1u9jwhdlutru8rl8qnnrwe658h93klqpjx66d7p592u47hfq5pdejf",
        "delegation": null,
        "rewardAccountBalance": 0
    }
]

$ cat /tmp/ledger-state.json| grep 64ebb7fc58f871fce09cc6ecea87b9636f803236b4df0685572beba4
                            "key hash": "64ebb7fc58f871fce09cc6ecea87b9636f803236b4df0685572beba4"
                            "key hash": "64ebb7fc58f871fce09cc6ecea87b9636f803236b4df0685572beba4"

@JaredCorduan It is on the chain. You need to remove the e1 from the beginning as that's a bech32 artifact.

you are totally right, thank you @AndrewWestberg !
After digging around in some ledger state dumps, I see that pool 3b066c31e418ae43a63b621c148ffc076ad6c0715c1079790a0209f0 was registered in epoch 212, and set to retire in epoch 213. Epoch 213 began at 2020/08/23 21:44:51 EST, so the stake key 64ebb7fc58f871fce09cc6ecea87b9636f803236b4df0685572beba4 would need to have been re-registered before then. I have a dump dated about thirty minutes before the epoch change at 2020/08/23 21:15:38 EST that shows that it is not registered. The next dump that I have easy access to is from 2020/08/27 19:47:35 EST, and I do see the stake key registered by then. Unfortunately it's a bit time consuming for me to get dumps at particular times, but what I need to check next is if the key was registered between 21:15 EST and 21:44 EST on 2020/08/23. If it didn't make it into this 29 minute window, then everything is working as expected.

@AndrewWestberg I have confirmed that 64ebb7fc58f871fce09cc6ecea87b9636f803236b4df0685572beba4 was not registered when epoch 213 began, which was when the pool was reaped.
Here is what I did. I added a small change to the ledger code so that the node would raise an error on the first block processed in epoch 213, and then dump the currently registered reward accounts.  I then built a full node, nuked the database, ran the node from genesis, and captured the error. To sanity check myself, I checked my personal reward account in the error message to see that it was as I would expect for epoch 213. I then looked to see if 64ebb7fc58f871fce09cc6ecea87b9636f803236b4df0685572beba4 was registered, but it was not.
It looks like 64ebb7fc58f871fce09cc6ecea87b9636f803236b4df0685572beba4 was registered sometime between 2020/08/23 21:44:51 EST and 2020/08/27 19:47:35 EST, which is too late to get the deposit back.
I'm sure it's a bummer to have attempted to get the deposit back and it not work out. :(

@JaredCorduan Thanks for the thorough investigation. I'm going to go ahead and close this ticket.

I have the same issue, this is my old payment.addr
addr1q8k3ry4l0awkn0fgfq7znyj8pe78f5d6r3hh8t632a9p6ut7nf88klg69dfutch8r095eprqg8fr67a77nydazqx4k3qn3aat7

and this is my pool deregistration cert
{
    "type": "CertificateShelley",
    "description": "Stake Pool Retirement Certificate",
    "cborHex": "8304581c3d6c43ce268e05c0bf038dd3364ae0eba2e97d6e9e1b2801f2c51864190100"
}

this is the transaction for the first time pool registration
https://cardanoscan.io/transaction/c7bbec808dcdad3cf854e00044ffcfc73ae2e30d915d87cb5bbd0befd2a496ad?tab=poolcertificates
Can you help to check this. my pool ticket is AHA

Guys you need to do something for that ! I have the same issue.. you should prevent stake dereg for active pool.. how we can now? Any chance to get the deposit back?

Hello guys! I have the same issue, I de-register my pool (on epoch 273) and did not receive rewards.
Can anyone help me?
My Pool: 73946f2e9cd318983c5e846a1d5f0b828a49916861a6ea405b07457c
Thanks

Same issue too...


Feature/1.0.0/examples

Changes Unknown when pulling 6c5027c34da02358df724c5e88890b5e80998673 on feature/1.0.0/examples into ** on release/1.0.0**.

Changes Unknown when pulling e90157e254c2135b571cd668c5de9ea70cf92500 on feature/1.0.0/examples into ** on release/1.0.0**.


Drag and Drop cdkDropListDisabled odd binding

Reproduction
https://stackblitz.com/edit/angular-bj2u4w (working example)
https://stackblitz.com/edit/angular-4pnl1v (broken example)
When  you the cdkDropListDisabled  limit it appears that the next operation isn't setting the disable back to enabled.
In these examples there is a limit on the todo where the todo list should be drag disabed when it has only 1 item and the done list should be drag disabled when the todo list has 6 or more in it.
Reproduce:
Move all but 1 item from todo and notice that you cannot move the final item out of todo list.
Move 1 from done back to todo. This SHOULD allow you to move an item from todo back to done since the  limit for cdkDropListDisabled  has been removed.
Notice that you cannot move from todo until you move a 3rd into todo. It is fixed if you drop or even just enter the 3rd item into the todo list.
other way of breaking:
Move 6 items into todo and notice you cannot move a 7th item into todo
Move 1 from todo to done. This SHOULD allow you to move an item from done into todo.
Notice you cannot move from done into todo until you reduce the todo count to 4. It is fixed by dropping OR simply entering the done list from todo.
Expected Behavior
When the cdkDropListDisabled becomes false it should actually let me interact with the draggable list again.
Actual Behavior
cdkDropListDisabled is not re-enabling the list after the first operation that makes it false.
Environment

Angular: 8.2
CDK/Material: 8.2
Browser(s): Edge, Chrome, Firefox
Operating System (e.g. Windows, macOS, Ubuntu): Windows 10

Thanks for the quick turn around on this!

Was curious when we were expecting this to be live.


TypeError: Cannot read property 'ImageAnnotatorClient' of undefined

I'm new to nodejs, trying google handwriting text recognition. The error log and code is given below, please suggest me.
function test(){
    const vision = require('@google-cloud/vision').v1p3beta1;
    const fs = require('fs');
    const client = new vision.ImageAnnotatorClient();
    const fileName = `C:/Users/sandr/Downloads/menu.jpg`;

    const request = {
    image: {
        content: fs.readFileSync(fileName),
    },
    feature: {
        languageHints: ['en-t-i0-handwrit'],
    },
    };
    client
    .documentTextDetection(request)
    .then(results => {
        const fullTextAnnotation = results[0].fullTextAnnotation;
        console.log(`Full text: ${fullTextAnnotation.text}`);
    })
    .catch(err => {
        console.error('ERROR:', err);
    });
}

console.log(test());

    const client = new vision.ImageAnnotatorClient();
                              ^

TypeError: Cannot read property 'ImageAnnotatorClient' of undefined
    at test (D:\Softwares\nodejs-docs-samples-master\nodejs-docs-samples-master\functions\ocr\app\MyApp.js:8:31)
    at Object.<anonymous> (D:\Softwares\nodejs-docs-samples-master\nodejs-docs-samples-master\functions\ocr\app\MyApp.js:34:13)
    at Module._compile (internal/modules/cjs/loader.js:689:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:700:10)
    at Module.load (internal/modules/cjs/loader.js:599:32)
    at tryModuleLoad (internal/modules/cjs/loader.js:538:12)
    at Function.Module._load (internal/modules/cjs/loader.js:530:3)
    at Function.Module.runMain (internal/modules/cjs/loader.js:742:12)
    at startup (internal/bootstrap/node.js:279:19)
    at bootstrapNodeJSCore (internal/bootstrap/node.js:696:3)

Environment details

OS: Windows 10
Node.js version: 10.10.0
npm version: 6.4.1
@google-cloud/vision version: 0.19.0

Thanks!

Greetings!  I could be wrong, but I don't think you shouldn't need the .v1p3beta1.  Will this work without it?

When I remove .v1p3beta1. and try I get an error "TypeError: vision.ImageAnnotatorClient is not a constructor"

Hi @JustinBeckwith, can you please suggest if this is a bug in vision api.

I believe you just need to upgrade to the latest version of this library, which is currently 0.22.0.
With that version, this works for me:
const vision = require('@google-cloud/vision')
const client = new vision.ImageAnnotatorClient()

Please let me know if you still have issues after the upgrade.

I just tried with the latest version, and facing new errors. Kindly suggest me if anything wrong in code.
(node:8904) DeprecationWarning: grpc.load: Use the @grpc/proto-loader module with grpc.loadPackageDefinition instead
(node:8904) UnhandledPromiseRejectionWarning: Error: Unexpected error while acquiring application default credentials: Could not load
the default credentials. Browse to https://developers.google.com/accounts/docs/application-default-credentials for more information.
at GoogleAuth. (C:\Users\sandrpa\Downloads\nodejs-docs-samples-master\functions\ocr\app\node_modules@google-cloud\vision\node_modules\google-auth-library\build\src\auth\googleauth.js:248:31)

https://cloud.google.com/docs/authentication/getting-started#auth-cloud-implicit-nodejs has some good information about getting started with authorization.

Thanks @stephenplusplus its working now.


Update Microsoft.Insights\privateLinkScopes to new child-resource structureFeature Request

We still have a nested child resource deployed in arm\Microsoft.Insights\privateLinkScopes\deploy.bicep
resource privateLinkScope 'Microsoft.Insights/privateLinkScopes@2019-10-17-preview' = {
  name: privateLinkScopeName
  location: location
  tags: tags
  properties: {}

  resource privateLinkScope_scopedResources 'scopedresources@2019-10-17-preview' = [for (scopedResource, index) in scopedResources: {
    name: 'scoped-${last(split(scopedResource.linkedResourceId, '/'))}-${guid(uniqueString(privateLinkScope.name, scopedResource.linkedResourceId))}'
    properties: {
      linkedResourceId: scopedResource.linkedResourceId
    }
  }]
}

duplicate


CustomEvent: communicate subcribed to event without meta tag defined

It would be good if we can communicate to the user they are subscribed to the readthedocs-addons-data-ready but they haven't defined the meta[name=readthedocs-addons-api-version] tag which is mandatory to make usage of the Read the Docs data event.
Reference: https://github.com/readthedocs/addons/pull/64/files#r1331997049

I had an idea about this during the weekend and I think it could be good. I'm writing it down here to receive some feedback and consider implementing it.
When triggering readthedocs-addons-data-ready instead of passing the raw JSON object, we could pass an instance of a class we control, e.g (AddonsData). This class requires calling .initialize() to be able to access the JSON object with the addons data. After that, the user can access AddonsData.config which contains the full JSON data
This allows us to perform anything we need inside the .initialize() method:

tell users that they need to define the meta HTML tag
communicate anything new we need in the future
raise exceptions to block the usage of the JSON data if any validation is no passed
eventually hit an API to log who is using this custom event (?)
... and any other requirement we may have in the future

In other words, I'm suggesting to pass an instance of a class we control and enforce users to call a method before making usage of the data. I think this solves the problem I already raised but also gives us the flexibility in the future to communicate with users. @agjohnson what do you think?

The usage from a user's perspective would like this:
document.addEventListener("readthedocs-addons-data-ready", function(event) {
    const addons = event.detail;

    // Accessing `addons.data` at this point without initializing it will fail.
    // It will raise an exception at this point communicating what happened.

    // So, we require users calling `addons.initialize()` here.
    addons.initialize();

    // Then, the user can access to the data and do whatever they need.
    const config = addons.data;

    ....
});

I think I get what you're aiming for, this seems like a good way to solve the issue above. I would agree that providing a richer data structure in some way would help us now, and probably in the future too.
We could also pass the user a callback function if we don't see the need for additional class methods/etc.
That is:
document.addEventListener("readthedocs-addons-data-ready", function(event) {
    const fn = event.detail;
    const config = fn();
    ...
});

This is maybe a more an expected pattern in JS but the two seem functionally the same.

We could also pass the user a callback function if we don't see the need for additional class methods/etc.

Yeah, I was suggesting a class since seems more flexible for future scenarios --but I've never done this, so I'm not sure if it's a good idea or not.

This is maybe a more an expected pattern in JS but the two seem functionally the same.

Does this pattern have a name I can Google for?[^1] Do you have a link at hand where I can read more about this?
[^1]: I thought I was inventing something revolutionary here, but it seems it already exists 😝

Does this pattern have a name I can Google for?

Good question. Maybe "callback" is the closest? This feels maybe similar to how a JSONP callback might work, just with an event added in instead of a named function.

I implemented an approach that I like in https://github.com/readthedocs/addons/pull/287


New labels for issues and pull requests

I'm thinking about the labels on issues and pull requests and would like to hear from you before implementing them.
Suggestions for issues and pull requests:

bug
documentation
duplicate
enhancement
good first issue
help wanted
question
invalid
released (used to mark when a feature request is in production)
wontfix (used to mark when a issue wont be fixed that way)
blocked
severity-major
severity-minor
severity-nice-to-have
working

What do you think? Missed something? Overlabeling?

I think:
-1 good first issue is not necessary
-2 I dont get the diference between help wanted and question
-3 working would be WIP that  github undestand as Work in progress
-4 i think would be nice to have tha labels effort:easy effort:medium effort:hard

i think we need a ready-to-do or something to say that issue is waiting for someone to make the implementation

-1 good first issue is not necessary

Agree

-2 I dont get the diference between help wanted and question

Question is someone asked something, help wanted is when a issue is opened for a long time and no one knows the awnser

-3 working would be WIP that github undestand as Work in progress

Agree

-4 i think would be nice to have tha labels effort:easy effort:medium effort:hard

Effort is a subjective thing, I don't know if it would actually be effective as each person can judge complexity in a totally different way.

About the effort, hmmm, but after a great discussion we know the effort size approximation, if this is "small", "medium" or "big" effort.

I'll implement these labels this week.
@italojs about the effort, let's discuss inside the herbs monthly meeting, ok?

Labels are now implemented: https://github.com/herbsjs/herbs/labels
I'll replicate to others repositories now


What Happens when user is unlicensed from Power BI, what happens to My workspace saved reports :

[We have tried internally and confirmed it with Power BI Free license revoking process. It worked for Power BI too. We could see “My Workspace”(Personal Workspace) reports back into the place.
You can add Power BI Product in the below blog. But not sure about the retention period apply as same as other MS products.
]

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 0d850211-99b4-faf7-09fc-4621919dd74b
Version Independent ID: 9b294f13-b1e3-291e-25a1-75f7c5755b6c
Content: Unassign licenses from users - Microsoft 365 admin
Content Source: microsoft-365/admin/manage/remove-licenses-from-users.md
Service: o365-administration
GitHub Login: @cmcatee-MSFT
Microsoft Alias: cmcatee

@Pulendar Thank you for your feedback. I see the My workspace item still on the dashboard after removing the license for a user. I will confirm with the author/PG about the retention policy and update the document accordingly.
Thanks
Sri

@Pulendar Thank you for your feedback. I see the My workspace item still on the dashboard after removing the license for a user. I will confirm with the author/PG about the retention policy and update the document accordingly.
Thanks
Sri


feat: Add custom completer for cargo help <TAB>

What does this PR try to resolve?
Tracking issue https://github.com/rust-lang/cargo/issues/14520
Add custom completer for cargo help <TAB>
Additional information
The current completer function is quite slow because it executes too many functions. One idea I have is to use the file!() macro to list the filenames under the commands directory, excluding mod.rs, and return them as the completion results. Would this approach be too hacky?

@bors r+

:pushpin: Commit f64411c4cd4f8b8959c0e975de532e5e8438dfeb has been approved by epage
It is now in the queue for this repository.

:hourglass: Testing commit f64411c4cd4f8b8959c0e975de532e5e8438dfeb with merge f137aba272ca9b07bdca3474e559a085d8e61b46...

:boom: Test timed out

@bors retry

:hourglass: Testing commit f64411c4cd4f8b8959c0e975de532e5e8438dfeb with merge c652c56e2a6b582989d854190540ebdc636ebf7f...

:sunny: Test successful - checks-actions
Approved by: epage
Pushing c652c56e2a6b582989d854190540ebdc636ebf7f to master...


Avoid generating FlywaySqlScriptException message dynamically

This is suboptimal as we end up generating the same string over and over again and this particular getMessage() requires class loader calls (via resource.getAbsolutePathOnDisk()).
In Quarkus, we actually call getMessage() after the class loader is closed in some cases which causes some issues.
I think this is good practice anyway as better avoid calling the class loader multiple times when an error occurs.
See https://github.com/quarkusio/quarkus/issues/43926 for the background of this change.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Ping? We at Quarkus would really like to get this in as we can't properly get feedback to users in some cases. Thanks!


IRC should identify before joining rooms

Currently the IRC bot attempts to join the channels before responding to the identification request from NickServ as per the pull request: https://github.com/github/hubot/pull/54, however this will prevent the bot from joining rooms that require identification before joining (+r).  This isn't an issue with freenode which will accept the nickpass as the server pass, but could be an issue on other networks which aren't as flexible.
We can fix this by only joining rooms after receiving acknowledgement from NickServ that we are identified.

Submitted pull request: https://github.com/github/hubot/pull/64


runner/runners: Write to stdout/err when a task times out or is aborted

Codecov Report

Merging #294 into master will increase coverage by 0.02%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #294      +/-   ##
==========================================
+ Coverage   59.24%   59.27%   +0.02%
==========================================
  Files          90       90
  Lines        6991     6995       +4
==========================================
+ Hits         4142     4146       +4
  Misses       2545     2545
  Partials      304      304

Impacted Files
Coverage Δ

runner/runners/invoke.go
71.89% <100%> (+0.62%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9d53714...e78f56a. Read the comment docs.

I'd throw in an "ERROR" or "FAILED" or some obvious loud keyword in there, gets kind of lost in the long command


Add the ability to mount a volume / persist data to disk after Kurtosis run has finished

Background & motivation
The auto-gpt package at the moment loses data after the enclave dies. We can't share the workspace between multiple different enclave runs
The author approved way of doing this mounts a local folder to the container and the container can write to it https://github.com/Significant-Gravitas/Auto-GPT#docker
Desired behaviour
The user experience in the dev workflow - I am working on my enclave ;some of the services are recording state. Want that state to exist when he comes back tomorrow. So need Kurtosis to give a way to do that. cc: @galenmarchetti
How important is this to you?
Critical; Kurtosis is unusable for me without it.

moving this ticket to back-burner as this probably looks like a project ( assigning this ticket to myself just to keep track of it)


Add HTML report figures back into workflow

ds_report_melodic is failing. Looks like MELODICRPT isn't generating the report.
I also think I did something wrong with the template iterator workflow. Denoising didn't run because I don't think std_buffer actually selected anything.
Changes proposed in this pull request

Documentation that should be reviewed

@effigies I just can't get the template iterator workflow to work. Would you mind reviewing this PR at some point?

I don't think resampler and the template iterator workflow are compatible. I need to swap out the resampler step in init_resample_volumetric_wf with a regular warping step with pre-collected transforms like fMRIPrep has.


Test setup

Screencast:

@psyfear please have a look! Thanks!

Forgot to add this:
brew install terminal-notifier

👆 is required for notification.

So with these deps added, simply do
$ mix test.watch

then continue coding ⌨ , and if ever tests are failing you will see notification same as above.


Backports the fix to #409 from the master branch to v1.x branch.

Backports commit cf783fca1213d26b50bc07af0ca7e2b0f6385401
Backports the fix for #409 "SvgPathSeg is removed in Chrome 48".
This change fixes 53 test failures on Chrome 48+ (error: 'TypeError: Cannot read property 'numberOfItems' of undefined'.

did you run the tests in chrome? Also I am pretty sure you missed 2 commits which fixes issues with this fix (dd7cc2f5104d488b0ba85366e14fae57edb767b7 and dd2ad7824d546242468992436d9a631a60294e28)

Yes, ran tests on Chrome 48 and 51 canary. All 53 tests that were failing because of SvgPathSeg being removed on Chrome 48 (error: 'TypeError: Cannot read property 'numberOfItems' of undefined'.) now run correctly.
I wasn't aware of any further commits related to this, since all tests are now working. I'm not sure if those are easy to backport to v1.x, do you want me to try to backport also those or we do different PRs?

Updated PR to include dd7cc2f and dd2ad78.
patharray.js is now synchronized to HEAD on master branch

I wasnt speaking from the tests before the fix but after. Are all tests ok after applying this patch?
If so I will merge it immediately

OK, got it.
There is 1 test failing both before and after on Chrome 48 and 51 (and IE and FF) but it doesn't seem to be related to this PR. I believe that test is not correct but I don't have enough background to understand if the spec is wrong or there is a real problem.
Test failing:
Regex testers isEvent is false without a namespace
That test doesn't exist anymore on master and neither the isEvent regex. Other than this one, all tests are OK.

Published under 1.1.1


Major minitwlpayload cleanup (also fixes FAT12/FAT16 support)

This Pull Request supersedes and replaces #5.

Use nds-bootloader submodule (latest official devkitPro ds(i) bootloading code)
Consequence of above: FAT12/FAT16 support restored
Now compressing bootloader with exomizer: bootloader decreased from 6120 bytes to 4564 bytes. Max payload.dat size inside 4swords savegame partition is 6144 bytes, for reference.
Miscellaneous code cleanup & stability fixes.

"Now compressing ..." <- Add to README credits?

https://github.com/fincs/dsi/blob/5d2fe1ab9f860a2e19be6611214a5b7eae4e751c/exploits/minitwlpayload/source/exodecr.c#L12

If you use this software in a product, an acknowledgment in the product documentation would be appreciated but is not required.


Update ImageReference to allow the alt property to be optional

⚠ This change will break docc2html, this pull request fixes it: https://github.com/DoccZz/docc2html/pull/27 ⚠
In some cases, the alt property in an ImageReference is null. I think this may be a bug in DocC, since I've intentionally provided alt text, but even if it is a bug it seems like it should be handled.
Here is the documentation that generated a null value for the alt text: https://github.com/DavidBrunow/brunow.org/blob/main/Sources/BrunowOrg/Documentation.docc/Posts/2023/10-21-here-be-dragons-snapshot-testing-edition.md?plain=1#L8
And here is the generated JSON: https://github.com/DavidBrunow/brunow.org/blob/main/docs/data/documentation/brunow/10-21-here-be-dragons-snapshot-testing-edition.json
And the relevant part of that JSON:
...
"misrenderedSwiftUIList.png":{
  "alt":null,
  "identifier":"misrenderedSwiftUIList.png",
  "type":"image",
  "variants": [
    {
      "url"<EMAIL_ADDRESS>      "traits": [
        "3x",
        "light"
      ]
    }
  ]
}
...

I looked into this some more, and it appears that the order of the properties for the @PageImage annotation matters, and having them in the wrong order will cause the alt text to be null.
This annotation will generate null text:
@PageImage(
    purpose: card,
    source: "misrenderedSwiftUIList",
    alt: "Screenshot of a user interface which was not rendered properly in snapshot tests."
  )

This annotation will not:
@PageImage(
    source: "misrenderedSwiftUIList",
    alt: "Screenshot of a user interface which was not rendered properly in snapshot tests.",
    purpose: card
  )

All that being said, it is possible for folks to not provide alt text for this annotation at all, so I think this pull request is useful.


Snapshot Support

Do you plan on supporting the resolution of Snapshots (i.e. get the latest version from the repository if it is newer than what you have locally)?
I noticed that when it is resolving dependencies it ignores "test" scoped dependencies.  Shouldn't this also be the case for "provided"?
Thanks

Hi Gnartg,
The "provided" dependencies should not be ignored, as ModRun is not building a JAR file, but running a JAR file. ModRun has to look for all dependencies needed at runtime, and "provided" dependencies are also needed at runtime. They are just assumed to be "provided".
Snapshots - we might, in the future. If enough people ask for it. That might be useful during development. But - one step at a time. First we focus on running Java apps in test and production environments. Then we will focus on running Java apps during dev (with stuff like SNAPSHOT versions etc).

My usecase was to use this as a classloader for a jar and if a particular dependency is already on my classpath (i.e. provided) then it can be ignored.  Perhaps I am not aligned with the purpose of the library.
Could this be configurable?

It could probably be configurable in the future. It is not right now. ModRun first checks if a dependency is available in the Maven repository you have pointed ModRun to. If not, it will check transitive dependencies, and finally it will check the root class loader.
I guess a dependency marked as "provided" could be interpreted as being available from the root class loader ... ?


Cannot install on macOS?

I have installed BuildTools and Visual Studio, but I am still getting the error "Visual C++ not found".
some screenshots:

build.sh script has this line:
[ "$OSTYPE" == "linux-gnu" ] || [ "$OSTYPE" == "linux" ] && PLATFORM="linux"

So, it recognizes linux this way. Otherwise it treats OS as Windows. Anyway, MacOS shouldn't work - I never had any access to Mac, so only 2 platforms are supported: Windows and Linux.

ok :(

Actually limited macOS support has been added in August 2020. Can't do more because I don't have a mac.


Mask in WSeg dataset

Hi, thanks for the great work and released dataset,
I follow the updated dataset link in README and download it.
But I noticed that the downloaded dataset only contains images without the corresponding masks. I wondering if there is an alternative link available for downloading the masks separately or it will update in the same link.
Thanks!!

Hi Mouthan,
I hope you are doing well.
The mask images will be uploaded it by tomorrow. You can get the mask images in same folder.
Thanks,
Subba

Hi Mouthan,
I hope you are doing well.
The mask images are uploaded on the same link.
Thanks,
Subba


ImportError: No module named interpolation

fontmake version 1.6.0
$ fontmake -m SourceSerifVariable-Roman.designspace -o variable
Traceback (most recent call last):
  File "fontmake/bin/fontmake", line 11, in <module>
    sys.exit(main())
  File "fontmake/lib/python2.7/site-packages/fontmake/__main__.py", line 256, in main
    project.run_from_designspace(designspace_path, **args)
  File "fontmake/lib/python2.7/site-packages/fontmake/font_project.py", line 585, in run_from_designspace
    from glyphsLib.interpolation import apply_instance_data
ImportError: No module named interpolation

this was the result of https://github.com/googlei18n/glyphsLib/pull/361
the glyphsLib.interpolation module was removed. The apply_instance_data function is still defined in glyphsLib.builder.instances. I'll change next version of fontmake to import from there.
For now you can install the previous glyphsLib version preceding 3.0.0, pip install glyphsLib==2.4.0

in the end I decided to fix this in glyphsLib, instead of here in fontmake.


support dry run in galley validation webhook

Bug description
when run command: kubectl diff -f gateway.yaml
apiVersion: networking.istio.io/v1alpha3
kind: Gateway
metadata:
  name: my-gateway
  namespace: some-config-namespace
spec:
  selector:
    app: my-gateway-controller
  servers:
  - port:
      number: 80
      name: http
      protocol: HTTP
    hosts:
    - "ns2/foo.bar.com"

a error raised:
Error from server (BadRequest): admission webhook "pilot.validation.istio.io" does not support dry run

Solution
After PR merged, if sideEffects set Unknown in webhook pilot.validation.istio.io, the command will be blocked. Now we can  set default value 'NoneOnDryRun' to solve it.

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: ChangyuWang
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: geeknoid
If they are not already assigned, you can assign the PR to them by writing /assign @geeknoid in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

galley/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Hi @ChangyuWang. Thanks for your PR.
I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test label.
I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

/ok-totest

/ok-to-test

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: ChangyuWang
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: geeknoid
If they are not already assigned, you can assign the PR to them by writing /assign @geeknoid in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

galley/OWNERS
install/kubernetes/helm/istio/charts/galley/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ChangyuWang: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/integ-mixer-k8s-k8s-presubmit-tests.sh
90c7284705982bed562460222b0d784abd0ca48b
link
/test integ-mixer-k8s-k8s-presubmit-tests-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ChangyuWang: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/integ-mixer-k8s-k8s-presubmit-tests.sh
90c7284705982bed562460222b0d784abd0ca48b
link
/test integ-mixer-k8s-k8s-presubmit-tests-master

prow/integ-pilot-k8s-presubmit-tests.sh
90c7284705982bed562460222b0d784abd0ca48b
link
/test integ-pilot-k8s-presubmit-tests-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest

@ChangyuWang: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/integ-mixer-k8s-k8s-presubmit-tests.sh
90c7284705982bed562460222b0d784abd0ca48b
link
/test integ-mixer-k8s-k8s-presubmit-tests-master

prow/integ-pilot-k8s-presubmit-tests.sh
90c7284705982bed562460222b0d784abd0ca48b
link
/test integ-pilot-k8s-presubmit-tests-master

prow/racetest.sh
90c7284705982bed562460222b0d784abd0ca48b
link
/test istio-racetest-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ChangyuWang: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/integ-mixer-k8s-k8s-presubmit-tests.sh
90c7284705982bed562460222b0d784abd0ca48b
link
/test integ-mixer-k8s-k8s-presubmit-tests-master

prow/integ-pilot-k8s-presubmit-tests.sh
90c7284705982bed562460222b0d784abd0ca48b
link
/test integ-pilot-k8s-presubmit-tests-master

prow/racetest.sh
90c7284705982bed562460222b0d784abd0ca48b
link
/test istio-racetest-master

prow/integ-mixer-k8s-presubmit-tests.sh
90c7284705982bed562460222b0d784abd0ca48b
link
/test integ-mixer-k8s-presubmit-tests-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ChangyuWang: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/integ-pilot-k8s-presubmit-tests.sh
90c7284705982bed562460222b0d784abd0ca48b
link
/test integ-pilot-k8s-presubmit-tests-master

prow/racetest.sh
90c7284705982bed562460222b0d784abd0ca48b
link
/test istio-racetest-master

prow/integ-mixer-k8s-presubmit-tests.sh
90c7284705982bed562460222b0d784abd0ca48b
link
/test integ-mixer-k8s-presubmit-tests-master

prow/integ-mixer-k8s-k8s-presubmit-tests.sh
90c7284705982bed562460222b0d784abd0ca48b
link
/test integ-mixer-k8s-k8s-presubmit-tests-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest

@ChangyuWang: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/integ-mixer-k8s-k8s-presubmit-tests.sh
90c7284705982bed562460222b0d784abd0ca48b
link
/test integ-mixer-k8s-k8s-presubmit-tests-master

prow/integ-security-k8s-presubmit-tests.sh
90c7284705982bed562460222b0d784abd0ca48b
link
/test integ-security-k8s-presubmit-tests-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ChangyuWang: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/integ-security-k8s-presubmit-tests.sh
90c7284705982bed562460222b0d784abd0ca48b
link
/test integ-security-k8s-presubmit-tests-master

prow/integ-mixer-k8s-k8s-presubmit-tests.sh
90c7284705982bed562460222b0d784abd0ca48b
link
/test integ-mixer-k8s-k8s-presubmit-tests-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ChangyuWang: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/integ-security-k8s-presubmit-tests.sh
90c7284705982bed562460222b0d784abd0ca48b
link
/test integ-security-k8s-presubmit-tests-master

prow/integ-mixer-k8s-k8s-presubmit-tests.sh
90c7284705982bed562460222b0d784abd0ca48b
link
/test integ-mixer-k8s-k8s-presubmit-tests-master

prow/istio-pilot-multicluster-e2e.sh
90c7284705982bed562460222b0d784abd0ca48b
link
/test istio-pilot-multicluster-e2e-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

I am not sure why we need this? Are you hitting this problem with a recent deployment? Ed fixed the dry run problem some time ago.
https://github.com/istio/istio/pull/12670
We have this in the configuration that is used as the template, so reconciliation should be fixing up any existing configuration.
https://github.com/istio/istio/blob/3f0031fa36a015831554a6e1ca7a4d7346b9466e/install/kubernetes/helm/istio/charts/galley/templates/validatingwebhookconfiguration.yaml.tpl#L67
So, what am I missing?

I am not sure why we need this? Are you hitting this problem with a recent deployment? Ed fixed the dry run problem some time ago.
#12670
We have this in the configuration that is used as the template, so reconciliation should be fixing up any existing configuration.
https://github.com/istio/istio/blob/3f0031fa36a015831554a6e1ca7a4d7346b9466e/install/kubernetes/helm/istio/charts/galley/templates/validatingwebhookconfiguration.yaml.tpl#L67
So, what am I missing?

I think istio can support dry-run feature with default configuration,  or we'll modify manually after istio deployed.

I don't get why we would override the settings on the yamls though. Of you want to add dry run support you can change the yaml templates


Change on-click event in an element

Hello all,
i want to give thanks for helping me previously with an issue i had. This time, i ran into a more difficult one: i need to change the function that is called in an on-click event for an element. Here is my html code:
<dom-module id="single-question">
...
<template>
...
<button id="ba1-q1" class="btn add-more" type="button" on-click="addMore">+</button>
...
</template>
...
</dom-module>

and my javascript code to capture that button and what i want to do:
var button = Polymer.dom(this.root).querySelector("#ba1-q1");
button.innerHTML = "-";
button.on-click = function(){
    alert("bluuuuuu");
}

or

var button = Polymer.dom(this.root).querySelector("#b"+t.id);
button.innerHTML = "-";
button.on-click = this.removeAnswer();
}

where removeAnswer() is a function defined inside Polymer element definition, in javascript code.
I know you can change/remove a function that is called with onClick and eventListeners but i want to do the same here in Polymer. Any ideia?

First, I encourage you to put the indirection you need inside the click handler so you don't have to change the handler function itself. For example,
clickHandler: function() {
  // manage setting this 'state' property where you need to change the behavior...
  if (this._stateA) {
    // do state A...
  }  else {
    // do other state...
  }
}

Second, you can use listen and unlisten which are minimal sugar around add/removeEventListener.  Here's an example:
http://jsbin.com/megenazuha/1/edit?html,output


[Angular] Fix EOL Date for 18.x

as noted her:
https://angular.dev/reference/releases#actively-supported-versions

File https://github.com/endoflife-date/endoflife.date/pull/5699 to prevent that in the future.


Updated versions, added logging

Sorry - didn't really mean to make that - was only comparing ^ 🐑 😁


Add z-order docs

Why are the changes needed?

introduce how to use z-order with Kyuubi
How was this patch tested?

Codecov Report

Merging #1481 (62483a8) into master (10034cd) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #1481      +/-   ##
============================================
- Coverage     59.14%   59.13%   -0.01%
  Complexity      172      172
============================================
  Files           234      235       +1
  Lines         12032    12050      +18
  Branches       1475     1478       +3
============================================
+ Hits           7116     7126      +10
- Misses         4312     4319       +7
- Partials        604      605       +1

Impacted Files
Coverage Δ

...org/apache/kyuubi/ha/client/ServiceDiscovery.scala
41.26% <0.00%> (-2.61%)
:arrow_down:

...rg/apache/kyuubi/engine/spark/SparkSQLEngine.scala
63.63% <0.00%> (-1.70%)
:arrow_down:

...ala/org/apache/kyuubi/session/SessionManager.scala
62.80% <0.00%> (-0.53%)
:arrow_down:

...in/scala/org/apache/kyuubi/config/KyuubiConf.scala
95.31% <0.00%> (ø)

...ache/kyuubi/ha/client/EngineServiceDiscovery.scala
50.00% <0.00%> (ø)

...i/ha/client/zookeeper/ServiceDiscoveryClient.scala
46.07% <0.00%> (ø)

...ache/kyuubi/engine/spark/SparkProcessBuilder.scala
87.61% <0.00%> (+0.61%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 10034cd...62483a8. Read the comment docs.

thanks, merged to master


vaul vue Drawe, datepicker in popover or datepicker in another dialog inside Drawer

Reproduction
0.8.7
Describe the bug
[Bug]: vaul vue drawer cant work with  datepicker on popover azin is not clickable and also datepicker in dialog it auto closes drawer on click outside
System Info
System:
    OS: Linux 6.1 Manjaro Linux
    CPU: (4) x64 Intel(R) Core(TM) i5-7200U CPU @ 2.50GHz
    Memory: 887.51 MB / 11.57 GB
    Container: Yes
    Shell: 3.7.0 - /bin/fish
  Binaries:
    Node: 21.6.2 - /usr/bin/node
    pnpm: 8.15.2 - /usr/bin/pnpm
  npmPackages:
    @vueuse/core: ^10.7.2 => 10.7.2
    nuxt: ^3.9.3 => 3.9.3
    radix-vue: ^1.5.1 => 1.5.1
    shadcn-nuxt: ^0.8.7 => 0.8.7
    vue: ^3.3.12 => 3.4.15
  operamini

Contributes

[ ] I am willing to submit a PR to fix this issue
[ ] I am willing to submit a PR with failing tests

Duplicated of https://github.com/radix-vue/vaul-vue/issues/37

Let's track it in upstream issue


PersistentCollection generics

I've made a good start on adding proper use of generics to the PersistentCollection hierarchy.
I was doing this work on the 6.0 branch, but I just noticed that it actually applies cleanly to master as well.

I will next take a look at extending this work to the CollectionSemantics hierarchy.

Nice work, thanks!


Added usage example for readme and html

This PR includes additions to the readme on how to add a Green Wall preview to a github readme and website  that was answered at https://github.com/Codennnn/Green-Wall/issues/24#issuecomment-1960646877

Great!


Serialize errors as JS objects (optional?)

Currently, the exception object has XML serialized string for errors, so the downstreams need to parse it using regex. Something like:
https://github.com/madskristensen/WebEssentials2013/blob/c82a9a52816bb59fb10833811c287457c9b4b4fc/EditorExtensions/Resources/server/services/srv-sweetjs.js#L57 (we are using require("xregexp").XRegExp; there for named captures).
Would be really helpful if sweet.js could return a regular object to make it consumable like:
https://github.com/madskristensen/WebEssentials2013/blob/c82a9a52816bb59fb10833811c287457c9b4b4fc/EditorExtensions/Resources/server/services/srv-less.js#L78-L95
Thanks!

I'm mass closing issues due to the release of 1.0 obviating lots of bugs. If you feel this issue is something we still need to address feel free to reopen.

Lately, there was a next version of WebEssentials released, which phased out the transcompilers as a separate VS extension (WebCompiler, which does not include sweet.js).
However, if I get back to sweet.js in another project, I will definitely investigate and send a PR if necessary.
Thanks.


Not support another style

please add option to support this style object.
{
  'post-id-followup-log-c79b15': {
    status: {
      name: 'xxxx',
      type: 'string',
    },
    purchaseType: {
      allowNull: false,
      name: 'xxxx',
      type: 'number',
    },
}

always has comma on the end

This module is for just printing an object, not supporting every custom style out there. If you need to format it, check out https://github.com/prettier/prettier or eslint --fix.


refactor: refactor the code base

Codecov Report

Merging #133 (8da8192) into master (1eced2f) will decrease coverage by 2.24%.
The diff coverage is 79.31%.

:exclamation: Current head 8da8192 differs from pull request most recent head eee0a22. Consider uploading reports for the commit eee0a22 to get more accurate results

@@            Coverage Diff             @@
##           master     #133      +/-   ##
==========================================
- Coverage   73.42%   71.17%   -2.25%
==========================================
  Files          33       34       +1
  Lines         666      687      +21
  Branches       48       54       +6
==========================================
  Hits          489      489
- Misses        177      198      +21

Impacted Files
Coverage Δ

.../scala/com/github/chiefofstate/NodeBehaviour.scala
0.00% <0.00%> (ø)

.../scala/com/github/chiefofstate/AggregateRoot.scala
94.11% <71.42%> (ø)

...github/chiefofstate/serialization/Serializer.scala
96.66% <90.00%> (ø)

...cala/com/github/chiefofstate/MigrationRunner.scala
75.00% <100.00%> (ø)

...com/github/chiefofstate/services/ServiceImpl.scala
100.00% <100.00%> (ø)

...ain/scala/com/github/chiefofstate/utils/Util.scala
100.00% <100.00%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


fix COPS-5547

customers might not have REMOTE_SEEDS. in that case the comma in the end tells the config parser that the list end with a NULL, which in turn is converted to <IP_ADDRESS>, which then results in the debug log constantly spewing errors about the gossip protocol not being able to communicate with localhost.
i'd love to learn how to properly test this change. it's currently untested and just a best guess to illustrate what i think needs to happen in order to fix COPS-5547

Cassandra and HDFS CI failures were fixed in #3259 which was merged after this PR was created.


add post-fusion strategy & example for conv2d-gather op-sequence

add post-fusion strategy for conv2d-gather tflite-op-sequence, mostly used in low-level vision problem, like conv2d--->pixelshuffle.
add upsample-pytorch converting example

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Per discussion, please remove the example code and make it a test case.

Thx, the test case is added on tests/converter_optimizer_test.py. Please kindly check it.


Adds vasp.cyg

Adds vasp with gpu support. Note that the path to the source code is hard coded, maybe we can use an env variable.

This patch actually has to be fixed since the source code is accessible only by malli user and all users in pawsey0001 group. How can we allow a group installation from a user? The source code must be accessible by that user.

Any user with a valid license can download the source code.  We should never be providing them the source code, even if they prove they have a license.  They will need to download the source and put in their own location as appropriate.

Thanks for the help! I was reading the license to search for this information. I will modify the maali file accordingly.

yep, have a look at the maali cyg for magnus, that's the way
(basically you assume the source tar is already in the src/ directory location)

Commenting on my edits:

modules that appear in MAALI_TOOL_PREREQ do not need to be repeated in MAALI_TOOL_BUILD_PREREQ. Both sets are loaded at build time, the difference is that the former are also loaded in the module file for production.
prereqs: use module intel-tbb for tbb libraries
prereqs: use openmpi-ucx-gpu (not openmpi-ucx), as we are building a gpu enabled tool
as discussed, the compiler swap is dirty, but this makes it a bit less dirty: module swap gcc $MAALI_COMPILER

Regarding the dirty switch.
GCC 7.2 gives the following error:
gcc -E -P -C -w mpi.F >mpi.f90 -DHOST=\"LinuxGNU\" -DMPI -DMPI_BLOCK=8000 -Duse_collective -DscaLAPACK -DCMAKE_Fortran_COMPILER_SUPPORTS_CONTIGUOUS=FALSE -DCACHE_SIZE=4000 -Davoidalloc -Duse_bse_te -Dtbdyn -Duse_shmem -DNGZhalf
mpif90 -ffree-form -ffree-line-length-none -w -O2 -I/pawsey/centos7.6/devel/cascadelake/gcc/8.3.0/fftw/3.3.8/include -c mpi.f90
mpif-sizeof.h:66:41:
Error: Array specification at (1) has more than 7 dimensions
mpif-sizeof.h:72:41:

and GCC 8.3 the following
gcc -E -P -C -w wave.F >wave.f90 -DHOST=\"LinuxGNU\" -DMPI -DMPI_BLOCK=8000 -Duse_collective -DscaLAPACK -DCMAKE_Fortran_COMPILER_SUPPORTS_CONTIGUOUS=FALSE -DCACHE_SIZE=4000 -Davoidalloc -Duse_bse_te -Dtbdyn -Duse_shmem -DNGZhalf
mpif90 -ffree-form -ffree-line-length-none -w -O2 -I/pawsey/centos7.6/devel/cascadelake/gcc/8.3.0/fftw/3.3.8/include -c wave.f90
wave.f90:1208:15:

     W1%CPTWFP=>W%CPTWFP(:,:,:,ISPIN)
               1
Error: Assignment to contiguous pointer from non-contiguous target at (1)
wave.f90:1209:15:


Evolve EthDM to add reply with new chat key

Problem
In the current version of Eth-DM (#204, https://github.com/vacp2p/rfc/pull/403), Bob has no way to reply to Alice as Alice does not include any identifier in the Direct Message she sends.
Solution
Alice SHOULD include information in her Direct Message to allow Bob to reply with an encrypted message.
The following requirements apply:

Only Bob should learn Alice's Ethereum Address
Bob should be able to verify that Alice indeed owns her Ethereum Address
Bob should only be able to find Alice's messages for which he is the recipient, ie, Alice should generate new Eth-DM keys for each recipient.
Alice should be able to recover her Eth-DM keys from her Ethereum Account.

Notes
We may want to include a way for Bob to also share new, dedicated, Eth-DM keys to Alice in his first reply.

Unnecessary at this stage, we are not aiming to re-doing Status chat app with ETh-DM.


z.union() inside of z.array repeats the same issue multiple times

Let's say I have a schema like this
const questionsSchema = z.array(
  z.union([
    z.object({
      code: z.string(),
      value: z.enum(['Yes', 'No']),
    }),
    z.object({
      code: z.string(),
      value: z.enum(['Yes', 'No']),
      meta: z.object({
        something: z.number(),
      }),
    }),
    z.object({
      code: z.string(),
      value: z.enum(['Yes', 'No']),
      meta: z.object({
        somethingElse: z.boolean(),
      }),
    }),
  ]),
);

And the following array which I try to validate:
const questions = [
  {
    code: 'Q1',
    value: 'No',
    meta: {
      something: 123,
    },
  },
  {
    code: 'Q2',
    value: 'Yes',
    meta: {
      somethingElse: false,
    },
  },
  { code: 'Q3', value: 'No' },
];

If there are no errors, as in the example above, it all looks good. But if I mess up one of the values, e.g. 'No' -> 'Nooo' for Q1, I'd expect to get a single issue, instead of the issue being repeated multiple times and wrongly interpreting the type of one of the items.
[
  {
    "code": "invalid_union",
    "unionErrors": [
      {
        "issues": [
          {
            "received": "Nooo",
            "code": "invalid_enum_value",
            "options": ["Yes", "No"],
            "path": [0, "value"],
            "message": "Invalid enum value. Expected 'Yes' | 'No', received 'Nooo'"
          }
        ],
        "name": "ZodError"
      },
      {
        "issues": [
          {
            "received": "Nooo",
            "code": "invalid_enum_value",
            "options": ["Yes", "No"],
            "path": [0, "value"],
            "message": "Invalid enum value. Expected 'Yes' | 'No', received 'Nooo'"
          }
        ],
        "name": "ZodError"
      },
      {
        "issues": [
          {
            "received": "Nooo",
            "code": "invalid_enum_value",
            "options": ["Yes", "No"],
            "path": [0, "value"],
            "message": "Invalid enum value. Expected 'Yes' | 'No', received 'Nooo'"
          },
          {
            "code": "invalid_type",
            "expected": "boolean",
            "received": "undefined",
            "path": [0, "meta", "somethingElse"],
            "message": "Required"
          }
        ],
        "name": "ZodError"
      }
    ],
    "path": [0],
    "message": "Invalid input"
  }
]

How would the schema know which one it is meant to validate against? It's showing you three errors because it cannot validate against any in the union

I might be missing something, but isn't it possible to figure this out by looking at the shape of the object?
In my example, Q1 has something key under meta property, which only matches the second shape provided to z.union.

How would we definitively know that, that specific object is what you were attempting to match?
What if we had
{
    code: 'Q1',
    value: 'No',
    meta: {
      something: 123,
      somethingElse: 'bla'
    },
  },

which one would we match?

If I'm to ask, I would match none with the payload you provided because it's ambiguous. I understand it might not be as performant to try and figure out what to match, but logically I think it is more sensible than matching against everything and showing an array of errors.
For my particular use case I could use discriminated union, but since I'm building validation logic dynamically, the downside is that I'll have to preprocess the data I get from a third-party CSV file and figure out the keys, which I wouldn't have to provide to a regular union.

How would you determine what to match? What would you prioritise?
Which takes greater precedence, a missing key in an object? Or a correct key but incorrect type?
There's far too many permutations


Should event listener allow optional access to response body

First three of four possible logging event listeners I hit, all use the Response Body
OkHttp - https://github.com/square/okhttp/blob/master/okhttp-logging-interceptor/src/main/java/okhttp3/logging/HttpLoggingInterceptor.java
Stetho - https://github.com/facebook/stetho/blob/42f375f959e64e204b43983c7b1f582dc44e2ffc/stetho-okhttp/src/main/java/com/facebook/stetho/okhttp/StethoInterceptor.java
Sonar - https://github.com/facebook/Sonar/blob/0aa60aee165d8915298789c3bac50a2d9951e83b/android/plugins/network/SonarOkhttpInterceptor.java
We could have an optional check to see if body is required per request (e.g. JSON API, but not streaming video) and then provide a safe copy in an efficient streaming manner.  The examples linked above cause delays in processing.
Possibly through a subinterface (ResponseBodyAware) or an API method on EventListener to query.

Won't fix. This seems like a useful firewall for us.


dbus-broker: 28 -> 29

Motivation for this change
new release
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[ ] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
21.11 Release Notes

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

This looks perfectly fine - I don't have time to try it out though.


Add support for entity updates

Closes https://github.com/XLSForm/pyxform/issues/662
Why is this the best possible solution? Were any other approaches considered?
The complexity here comes from the fact that the spec allows for implicit actions. Specifically:

if there's just a dataset and label specified, it's implied that submissions should always create entities
if an entity_id is specified, it's implied that submissions should always update entities

That makes the implementation more complex but I continue to think it's worth it because it's more intuitive than having to explicitly specify true() as create or update conditions.
Given that complexity, I decided to pass through the XLSForm values in the json representation (entities_parsing) and then to handle all the cases when building the XML representation (entity_declaration).
I used a truth table to make sure I handled and tested all the combinations of entity_id, create_if and update_if:
    # id    create  update  result
    # 1     0       0       always update
    # 1     0       1       update based on condition
    # 1     1       0       error, id only acceptable when updating
    # 1     1       1       include conditions for create and update, user's responsibility to make sure they're exclusive
    # 0     0       0       always create
    # 0     0       1       error, need id to update
    # 0     1       0       create based on condition
    # 0     1       1       error, need id to update

Hopefully that also helps with review.
I did find it challenging to balance writing narrow, specific tests and feeling confident that all aspects of the form were taken care of with each combination of options.
What are the regression risks?
There's some possible regression risk around entity creation. Hopefully the tests guard against it! The bigger risk is that I have a logic error in the new code.
Does this change require updates to documentation? If so, please file an issue here and include the link below.
Part of https://github.com/getodk/docs/issues/1678
Before submitting this PR, please make sure you have:

[x] included test cases for core behavior and edge cases in tests
[x] run nosetests and verified all tests pass
[x] run black pyxform tests to format code
[x] verified that any code or assets from external sources are properly credited in comments

Thanks so much for the thorough review, all the great suggestions, and particularly for catching that the spec change should be versioned. 🙏

I think it's worth considering calling the validation logic from EntityDeclaration (during XML processing) either in addition to or instead of from workbook_to_json

This is an interesting suggestion that I'd rather chew on and address in a follow-up PR.

A key benefit to checking during the latter is that it's possible to tell the user where they made a mistake in the XLSForm, but users can only have 1 entity per form so that is kind of redundant.

The current messages use a lot of spreadsheet language too.

by calling the validation during the XML pipeline it can apply to data coming in via the JSON entrypoint

Do we know that it's for sure being used?

Thanks! To summarise the related slack thread, the behaviour in this PR is that if a XLSForm uses entity updates then it gets the newer spec version 2023.1.0 and otherwise it gets the older spec version 2022.1.0. This is to allow forms not using the new features to be accepted by older versions of Central. If a form uses entity updates then older Central wouldn't know what to do with them so rejecting the form based on the spec version avoids users setting up forms that don't work as expected.


Using iavl v1.0.0 with cosmos sdk 0.47.5

Closes: #XXX
What is the purpose of the change

Add a description of the overall background and high-level changes that this PR introduces

(E.g.: This pull request improves documentation of area A by adding ....
Brief Changelog
(for example:)

The metadata is stored in the blob store on job creation time as a persistent artifact
Deployments RPC transmits only the blob storage reference
Daemons retrieve the RPC data from the blob cache

Testing and Verifying
(Please pick one of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)

Added unit test that validates ...
Added integration tests for end-to-end deployment with ...
Extended integration test for ...
Manually verified the change by ...

Documentation and Release Note

Does this pull request introduce a new feature or user-facing behavior changes? (yes / no)
Is a relevant changelog entry added to the Unreleased section in CHANGELOG.md? (yes / no)
How is the feature or change documented? (not applicable   /   specification (x/<module>/spec/)  /  Osmosis docs repo   /   not documented)

Fyi, on the PR I made, we got a super helpful comment from @julienbrt
https://github.com/julienrbrt/cosmos-sdk-inj/compare/f/v0.47.3-inj-1...ac1b893f08942b97c308dc57716cf8c597ef967f

Closing, since we currently are using a different branch for this


dokku run in cron: "cannot enable tty mode on non tty input"

I'm trying to run a dokku run command in a cron job, but getting the following error:
time="2015-07-08T19:03:02-04:00" level="fatal" msg="cannot enable tty mode on non tty input"

I found this commit on dokku that may help: https://github.com/progrium/dokku/commit/3e100e30023922ce23d8023128887720ca01adce

It seems that a good way to test it is by using:
:| dokku run <app> date

I'm running into this as well. The commit mentioned above does seem to solve this for dokku.

Any news here? I am running into this issue too when executing rake commands in Rails environment remotely (via the ssh dokku@HOST run APP rake db:create for example).
It says cannot enable tty mode on non tty input
Because the ssh for user dokku is tunelled directly to the dokku command (as is the default AND desired behavior) the ssh session will not receive interactive tty (which is OK). The dokku command should be able to live with that...
Do you plan to do similar fix which original dokku did?
Thanks!

There are no active developers around so you should make PR yourself


koreader: 2021.01.1 -> 2021.02

Motivation for this change
Version bump 2021.01.1 -> 2021.02
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 113664 at 5027d988 run on x86_64-linux 1

1 package built:

koreader

1 suggestion:

warning: missing-phase-hooks
installPhase should probably contain runHook preInstall and runHook postInstall.
Near pkgs/applications/misc/koreader/default.nix:30:3:
   |
30 |   installPhase = ''
   |   ^


Support for previewing animations, even if no model exists

Describe Your Suggestion
Currently, VPKEdit does not let us view model animations whereas HLMV++ does. This is best demonstrated when you load up a .MDL file without .VTX files, which gives us the Error placeholder instead of drawing a skeleton and a list of animations.
But maybe that's not really the point of this application…?

I haven't added animation parsing to the MDL parser yet, so when I do I'll add that functionality to VPKEdit. Interesting to see VTX files aren't required, I didn't know that was a thing

I haven't added animation parsing to the MDL parser yet, so when I do I'll add that functionality to VPKEdit. Interesting to see VTX files aren't required, I didn't know that was a thing

Yes, well for starters the stock HLMVs (including SFM's which I just tested, I'm sure it's the same with CS:GO's SDK) refuse to load models that lack vertices.

I think I am going to keep VTX files as a requirement, all Valve official models require them and I've never seen a use for a model without them

Kinda expected that, and HLMV++ already allows viewing models with skeleton animations, with or without vertices.


Remove ProjectReunionInternal Service Connection in NuGetAuthenticate task

Cherrypick of https://github.com/microsoft/WindowsAppSDK/pull/4316

/azp run


Adding template for a promotion request

Changes
Introducing a template for a promotion request. This template will help collect all necessary information/details to promote any feature to next level.
/kind misc
Submitter Checklist
As the author of this PR, please check off the items in this checklist:

[x] Has Docs included if any changes are user facing
[ ] Has Tests included if any functionality added or changed
[x] Follows the commit message standard
[x] Meets the Tekton contributor standards (including
functionality, content, code)
[x] Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
[x] Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings)
[ ] Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes
Developers - Please file a promotion request using this new template.

/lgtm


minio-client: 2021-02-10T07-32-57Z -> 2021-02-14T04-28-06Z

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/minio/mc/releases.
meta.description for minio-client is: "A replacement for ls, cp, mkdir, diff and rsync commands for filesystems and object storage"
meta.homepage for minio-client is: "https://github.com/minio/mc"
meta.changelog for minio-client is: ""
Updates performed

Golang update

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact

Checks done (click to expand)

built on NixOS

The tests defined in passthru.tests, if any, passed

0 of 0 passed binary check by having a zero exit code.

0 of 0 passed binary check by having the new version present in output.

found 2021-02-14T04-28-06Z with grep in /nix/store/5314i4kqsdyj38ccqxyziczdi5r3niym-minio-client-2021-02-14T04-28-06Z

directory tree listing: https://gist.github.com/d22e075e975ccd3c023861e18a047341

du listing: https://gist.github.com/c4fa2c8ea8a2c0ab66c78b3fc68e1bbd

Rebuild report (if merged into master) (click to expand)

4 total rebuild path(s)

1 package rebuild(s)

1 x86_64-linux rebuild(s)
1 i686-linux rebuild(s)
1 x86_64-darwin rebuild(s)
1 aarch64-linux rebuild(s)

First fifty rebuilds by attrpath
minio-client

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/5314i4kqsdyj38ccqxyziczdi5r3niym-minio-client-2021-02-14T04-28-06Z \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A minio-client https://github.com/r-ryantm/nixpkgs/archive/cf6075bcda5b8c6b30af975ebd2d4c824bc78c8e.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/5314i4kqsdyj38ccqxyziczdi5r3niym-minio-client-2021-02-14T04-28-06Z
ls -la /nix/store/5314i4kqsdyj38ccqxyziczdi5r3niym-minio-client-2021-02-14T04-28-06Z/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

1 package built:

minio-client

Maintainer pings
cc @edolstra @bachp @kalbasit for testing.

Result of nixpkgs-review pr 113281 at cf6075bc run on aarch64-linux 1

1 package built:

minio-client

1 suggestion:

warning: patch-phase
patchPhase should not be overridden, use postPatch instead.
Near pkgs/tools/networking/minio-client/default.nix:20:3:
   |
20 |   patchPhase = ''
   |   ^


[RELAY][Frontend][TF] decompile tf control flow

This PR decompiles TF control flow primitives into Relay high level control-flow construct as described in #2812. The execution frame is used to identify the invocation of control flow construct and to instantiate the control flow object, like Branch and Loop.
Thanks @jroesch for helping the loop part and @yongwww for more test cases.
cc @wweic @icemelon9 @srkreddy1238 @yzhliu @tqchen

@antinucleon or @ajtulloch could one of you review too?

@srkreddy1238 ping

@jroesch  thanks  &  will take a look today or tomorrow.

@yzhliu TF Lite doesn't support control flow so far, confirmed with tf lite team, probably tf lite will support control flow in the next or next two quarter. We will see once control flow is supported by tf lite.

Sorry, I've been busy with other stuff recently. I will update the PR and clean it up by this week when I have time.

@srkreddy1238 Please take another look. Thanks.

I have a question related to control flow. tf.TensorArray() is often used in control flow code. It is a container with dynamic shape.  How to use Relay to support it?

@lixiaoquan we can use algebraic data type in Relay to model complex data structure. For TensorArray, list(already included in Relay standard library) might be a good candidate. I added nth to model TensorArrayRead, i have a pending PR(https://github.com/dmlc/tvm/pull/2866) to add update to model TensorArrayWrite.

@srkreddy1238 Updated.

Thanks @zhiics @srkreddy1238 @wweic @jroesch @yongwww @lixiaoquan This is now merged.


[Share] Normal chat is duplicated if to click on Duplicate button when shared and normal chats are opened in Compare mode

EPAM AI DIAL chat version
0.6.0
How to reproduce
Preparation:

By user1 create chat1 -> share it
By user2 open the shared link, so chat1 appears in Shared with me
By user2 create chat2 with the same mount of messages as in chat1

Steps:

By user2 hover over chat1 from Shared with me -> click on three dots -> Compare
On the right part of the screen check Show all conversations check box and select chat2
Click on "Duplicate..." button at the bottom of the chats

Actial result
Chat2 is duplicated
https://github.com/epam/ai-dial-chat/assets/111180458/da06c5e9-9634-4f36-a0ad-f75ea2ebea06
Expected result
Chat1 from shared with me should be duplicated
Ideally is to leave Chat1_duplicated and Chat2 in compare mode
Confidential information

[X] I confirm that do not share any confidential information

Verified on staging successfully


feat(lvm): add support for replica operations backed by lvm volume

add support for replica operations backed by lvm volume
add python tests for lvm replicas

Signed-off-by: Akhil Mohan<EMAIL_ADDRESS>

I've taken this PR and re-raised on #1587


"Thin arrow used" error occurs in the blade file.

<input x-ref="{{ $field->key }}" {{ $field->wire }}="{{ $field->key }}" name="{{ $field->key }}" type="hidden"
autocomplete="{{ $field->autocomplete }}" class="nosy" />

Details about the problem are on the url.
https://youtrack.jetbrains.com/issue/WI-57838

Is an update planned?

It appears that the Alpine language injection (telling the IDE that what's inside an x- directive is JS) is overriding the Laravel language injection (telling the IDE that what's inside {{ is PHP. I'll have to dig around to see if there's a way to change that priority…

@inxilpro I uninstalled the plugin a few months ago because of this issue. I would like to use it again if the bug is fixed. 👍

I think 0.4.0 will resolve this. I'm still testing it a bit, but should be able to release it in a day or two.

I can confirm that this will work in 0.4.0:

thank you! @inxilpro


Document reason each allowed license is allowed

Relates to #60, #121
Summary
Include reasoning for allowing every allowlisted license in the project to:

make intent clearer, and
allow for more constructive public review.

Superseded by #264


doc : dp will bang every 24th ?!

For instance Dp will bang every 24th frame.
If we refer to the table https://github.com/hundredrabbits/Orca#base36-table
isn' it Do ?

If you want to bang every 24th frame, use Do, as per:
Co.D3.....................
5oP.......................
..*..*..*..*..*..*..*..*..
Co.D6.....................
5oP.......................
..*.....*.....*.....*.....
Co.Dc.....................
5oP.......................
..*...........*...........
Co.Do.....................
5oP.......................
..*.......................

yes so there's a typo into the doc.

For instance Dp will bang every 24th frame.

it rather be "Do will bang every 24th frame" right ?

Ah! yes, next time, just go ahead and fix the typo as a pull request.
It will be faster.

ok thank you !


Description field is too wide

https://github.com/Microsoft/vscode/issues/57301
https://baymard.com/blog/line-length-readability suggests the optimal reading width is 50-75 characters, right now the description page is around 160:

It's a far more pleasant experience reading it on GitHub:

We should bump the font size and make the wrapping div around 20-30% more narrow imo

As part of https://github.com/Microsoft/vscode-pull-request-github/pull/951, the content on the description page now has a max width of 900px which should more closely match GitHub


[Overlapping] Graph uses external market price

fix #1320
Strategy with external market price:

Strategy without external market price

Note: The text is "Geometric mean", while it's not exactly that when strategy is above/below market. Maybe use "Calculated market price".
Strategy with user market price

Switching from untouched to touch changes the marginal price:
https://github.com/bancorprotocol/carbon-app/assets/8143464/ce548f8d-c799-4b85-bec0-4783b09133e3

[ ] edit price - do not default into price field when price is available
flow:

click edit price
IF external price is available, do not default into the price field (because it force to show the last bit of the price which is usually a number that doesnt make sense)

https://github.com/bancorprotocol/carbon-app/assets/40430285/2ddb9d14-cc1a-466a-bbe1-5b931647f31b

[ ] external price - decimal trim
currently, we show 82 decimals.
updated, show the following:
IF (first 6 decimals are 0) AND (price < 1), show the 6 decimals after the first non zero digit
ELSE, show 6 decimals

[ ] edit market price when there is no external price
currently warning:
Warning, your market price will be used in the strategy creation flow and calculations.

updated warning:
Warning, the defined market price will be used for strategy budget distribution

[ ] edit strategy with no external price
flow:

edit a strategy with no external price
show the price input modal

in the place where we typically show "use market" and allow users to click and use the external market price, replace it with "use strategy" and allow users to click and use the strategy geomean(marginal.sell, marginal.buy)
add tool tip when mouse over "use strategy" with this text: "This price is the geometric mean of the strategy buy and sell marginal prices."

[ ] Updating prices on the graph

flow:

Find concentrated strategy without market price
Click edit prices
Chage the prices via the graph without providing the market price

Expected:
User can't update the prices
Actual:
User can change the prices of the strategy

[ ] Deposit/withdraw from a strategy without market price

flow:

Find concentrated strategy without market price
Click edit prices
Select one of the tokens and click on edit budget without providing the market price
Input deposit amount
Click the checkbox

Expected:
CTA becomes enabled
Actual:
CTA is disabled and becomes enabled only after user sets the market price

[ ] Using external market cap for deposit/withdraw incorrectly
Flow:
edit concentrated strategy with market price
click to withdraw some tokens (no other changes)
expected: withdraw from the strategy according to the on-chain marginal price
actual: the check is using the current market price and tried to re-adjust the strategy around it

[ ]text change
current:
{token} market price is missing. To continue the prices of the strategy, enter its market price below.

updated:
{token} market price is missing. Please provide the market price to enable price editing.

[ ] Difference from market price indicators

Current: We always show difference from market price indicators, wheter there is a market price or not
Updated: Show difference from market price indicators only when there is an external market price or market price that was provided by the user

Manually tested with :

Create an overlapping strategy with tokens with market price

Trade against it

Go to edit price, the graph should display external market price, but marginal price is the current one from the strategy

Try to withdraw without change price or spread, it should use the calculated market price

Withdraw

Create an overlapping strategy with tokens without market price

Trade against it

Go to edit price, the graph should be disabled (you cannot change the price), and the price section is hidden

Withdraw -> it should use calculated market price

Go back to edit price, enter a market price in the input field -> the graph should be enabled and price is available

Withdraw -> it should use the market price you filled in the input


⚠ Nebulance has degraded performance

In d031eb6, Nebulance ($NBL) experienced degraded performance:

HTTP code: 200
Response time: 4405 ms

Resolved: Nebulance performance has improved in f5b98ef.


Error in Unit 5

In a Solution section it says
class Policy(nn.Module):
    def __init__(self, s_size, a_size, h_size):
        super(Policy, self).__init__()
        self.fc1 = nn.Linear(s_size, h_size)
        self.fc2 = nn.Linear(h_size, a_size)

    def forward(self, x):
        x = F.relu(self.fc1(x))
        x = self.fc2(x)
        return F.softmax(x, dim=1)

    def act(self, state):
        state = torch.from_numpy(state).float().unsqueeze(0).to(device)
        probs = self.forward(state).cpu()
        m = Categorical(probs)
        action = np.argmax(m)
        return action.item(), m.log_prob(action)

And then

I make a mistake, can you guess where?

To find out let's make a forward pass:

But when I run the following code
debug_policy = Policy(s_size, a_size, 64)
debug_policy.act(env.reset())

The error is

RuntimeError: Expected all tensors to be on the same device, but found at least two devices, cpu and cuda:0! (when checking argument for argument mat1 in method wrapper_addmm)

Which is different than the one shared below

I think this would be fixed by changing
self.forward(state).cpu()

to
self.forward(state)


ListView scroll event stops Drag/Drop

Description
I am using ListView with horizontal={true}
The listview renders x numbers of Card component.
Each card can be dragged up to some drop zones
When the listview has a scroll, I can no longer drag a card up. The card does not move. It seems to freeze.
Drag and drop is done via https://github.com/deanmcpherson/react-native-drag-drop/tree/master/lib which provides some high order components
Pseudo code
<DragContainer
	onDragStart={this.onDragStart}
	onDragEnd={this.onDragEnd}
>
	<View>
		<DropZone
			onDrop={(dragObject) => {
				onDrop(dragObject)
			}}
		>
			<DropItem
				title="Drop Zone 1"
			/>
		</DropZone>
		<DropZone
			onDrop={(dragObject) => {
				onDrop(dragObject)
			}}
		>
			<DropItem
				title="Drop Zone 2"
			/>
		</DropZone>
	</View>
	<ListView
		horizontal={true}
		dataSource={dataSource}
		renderRow={this.renderCard}
	/>
</DragContainer>

Then renderCard renders <Draggable> components like so
renderCard(data) {
	return (
		<Draggable data={data}>
			<Card
				firstName={data.firstName}
				lastName={data.lastName}
			/>
		</Draggable>
	)
}

Solution
Help needed.
I tried to set scrollEnabled={false} on ListView when dragStart is fired and no luck
Additional Information

React Native version: 0.42
Platform: Windows 10. react-native-windows 0.42 , but this also happens on Android
Development Operating System: started on MacOS but now using Windows 10
Dev tools: Visual Studio / Atom

similar issue is reported here with some possible solutions
https://github.com/facebook/react-native/issues/1046

Does this still reproduce using FlatList? ListView is deprecated.

Hello,
Not tested with FlatList as not sure if Windows 10 supports it yet.
Also I moved on for the project, so although there is a bug somewhere, it is no longer a priority for me.
If you would like to close the issue feel free.
Cheers


Back-port Cucumber Setup from TTL

I think there's a few more things we need to do for cucumber
[4:44]
there are a ton of steps that can be global/universal
[4:44]
and the env.rb, too
[4:44]
and the cuke_steps.rb file
[4:44]
that generates that html table view of the steps


No documentation for keyword 'format'

In the yml configuration file for installing OWL ontologies, the keyword format is not specified, which is relevant if the file that is being installed has a specific format. For example:
...
format: turtle

Link to the docs page: https://simphony.readthedocs.io/en/latest/owl.html

Related to https://github.com/simphony/osp-core/issues/557

Related to https://github.com/simphony/osp-core/issues/557

Is the keyword still supported, then?
@urbanmatthias

Is the keyword still supported, then?
@urbanmatthias

it is

it is

/cib


Add a workflow version column on executions page

Right now it is not convenient to do not see what workflow version is executed inside the executions list.
We execute more than one version at the same time to compare their results so it would be really nice to see the "Version" column right after the "Workflow" column and also have the "Version" filter to easily see all executions for a specific version of the workflow.
Thank you!

@dskarataev Thanks for the suggestion. Please feel free to make a contribution for the same, we will add it to our wishlist.

thanks a lot! really happy to see it is implemented!


mosh [mobile shell] compatibility

When connected via mosh the ptpython console is broken and blinking. I guess this might have something to do with the VT100 requirement, so it's not a bug but a design limitation? My expertise is non-existent here.

It looks that by now, in the mosh version that I have. (1.2.5), it works fine, so I'm closing this issue.
Please reopen if you still experience any issues.
Jonathan


⚠ Fortnite has degraded performance

In d6b8f4e, Fortnite (https://fortnite.com) experienced degraded performance:

HTTP code: 200
Response time: 1584 ms

Resolved: Fortnite performance has improved in 406c6e1.


Pytest failure.

What happened
Running the command "pytest" renders the following message:
pytest: error: unrecognized arguments: --cov=kube_hunter
Environment:

OS: OS X Catalina
Python: 3.7.4
pytest: 5.3.5

I believe the issue lies in the setup.cfg file, with the line:
-addopts                                           = --cov=kube_hunter
However, if the line is removed, I get the following outcome:
START
============================================= test session starts ==============================================
platform darwin -- Python 3.7.4, pytest-5.3.5, py-1.8.1, pluggy-0.13.1
rootdir: /Users/abdullahgarcia/Documents/Workbench/GitHub/kube-hunter, inifile: setup.cfg, testpaths: tests
plugins: requests-mock-1.7.0
collected 0 items / 6 errors
==================================================== ERRORS ====================================================
________________________________ ERROR collecting tests/core/test_subscribe.py _________________________________
ImportError while importing test module "/Users/abdullahgarcia/Documents/Workbench/GitHub/kube-hunter/tests/core/test_subscribe.py".
Hint: make sure your test modules/packages have valid Python names.
Traceback:
tests/core/test_subscribe.py:3: in
from kube_hunter.core.types import Hunter
E   ModuleNotFoundError: No module named "kube_hunter"
______________________________ ERROR collecting tests/discovery/test_apiserver.py ______________________________
ImportError while importing test module "/Users/abdullahgarcia/Documents/Workbench/GitHub/kube-hunter/tests/discovery/test_apiserver.py".
Hint: make sure your test modules/packages have valid Python names.
Traceback:
tests/discovery/test_apiserver.py:4: in
from kube_hunter.modules.discovery.apiserver import ApiServer, ApiServiceDiscovery
E   ModuleNotFoundError: No module named "kube_hunter"
________________________________ ERROR collecting tests/discovery/test_hosts.py ________________________________
ImportError while importing test module "/Users/abdullahgarcia/Documents/Workbench/GitHub/kube-hunter/tests/discovery/test_hosts.py".
Hint: make sure your test modules/packages have valid Python names.
Traceback:
tests/discovery/test_hosts.py:5: in
from kube_hunter.modules.discovery.hosts import FromPodHostDiscovery, RunningAsPodEvent, HostScanEvent, AzureMetadataApi
E   ModuleNotFoundError: No module named "kube_hunter"
___________________________ ERROR collecting tests/hunting/test_apiserver_hunter.py ____________________________
ImportError while importing test module "/Users/abdullahgarcia/Documents/Workbench/GitHub/kube-hunter/tests/hunting/test_apiserver_hunter.py".
Hint: make sure your test modules/packages have valid Python names.
Traceback:
tests/hunting/test_apiserver_hunter.py:4: in
from kube_hunter.modules.hunting.apiserver import AccessApiServer, AccessApiServerWithToken, ServerApiAccess, AccessApiServerActive
E   ModuleNotFoundError: No module named "kube_hunter"
______________________________ ERROR collecting tests/hunting/test_cvehunting.py _______________________________
ImportError while importing test module "/Users/abdullahgarcia/Documents/Workbench/GitHub/kube-hunter/tests/hunting/test_cvehunting.py".
Hint: make sure your test modules/packages have valid Python names.
Traceback:
tests/hunting/test_cvehunting.py:4: in
from kube_hunter.core.events import handler
E   ModuleNotFoundError: No module named "kube_hunter"
________________________________ ERROR collecting tests/modules/test_reports.py ________________________________
ImportError while importing test module "/Users/abdullahgarcia/Documents/Workbench/GitHub/kube-hunter/tests/modules/test_reports.py".
Hint: make sure your test modules/packages have valid Python names.
Traceback:
tests/modules/test_reports.py:1: in
from kube_hunter.modules.report import get_reporter, get_dispatcher
E   ModuleNotFoundError: No module named "kube_hunter"
!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!! Interrupted: 6 errors during collection !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
============================================== 6 errors in 0.31s ===============================================
END
I'm planning on raising a pull request to bring new active hunters. Should I aim to address this issue within the same pull request or ignore it for now, raise the pull request, and then address this issue on a separate pull request?
Expected behavior
Tests executed successfully and coverage stats presented.

Update: the problem was due to an environment issue, I'll close this issue.


FORGE-438 upgrade to v15

update CHANGES.md
use ${hippo.release.version} from parent everywhere instead of explicit 15.2.0
replace the name hippo everywhere in project with Bloomreach
replace maven.onehippo repository with maven.bloomreach
use ${commons-text.version} for commons-text version from parent.


Fl Studio 20, .dlls not appearing in Plugin Directory?

First off my apologies if this is some error on my part.
I have extracted everything and placed into Fl Studios directory, the .dlls are being seen while scanned but are not appearing in plugin directory. Am I meant to have VCV Rack 0.6 installed as well rather than the latest 1.1?

For VSVR you don't need the standalone version of Rack.
Just add the vst2_bin/ folder in the FL plugin manager and make sure you are using the right VSVR plugin version ("win64" / 64 bit).
In case it's still not working, try loading the plugin in VSTHost64 to see if it's working on your system at all.