[QUESTION]Window 10 Build Error (NMAKE : fatal error U1077)

Platform:

Windows 10 Pro 21H2
x64 Native Tools Command Prompt for VS 2022(With v142 build tool)
strawberry-perl-<IP_ADDRESS>-64bit
OpenSSL 1.1.1o

I tried to execute the same command cmake .. -G "NMake Makefiles" -DBUILD_GSTREAMER_PLUGIN=ON -DBUILD_JNI=TRUE several times, but the following error occurred.
Error message
[ 66%] Performing build step for 'project_libopenssl'

Microsoft(R) Program Maintenance Utility Version 14.32.31328.0
Copyright (C) Microsoft Corporation.  All rights reserved.

        "C:\Strawberry\perl\bin\perl.EXE" "-I." -Mconfigdata "util\dofile.pl"  "-omakefile" "include\crypto\bn_conf.h.in" > include\crypto\bn_conf.h
        "C:\Strawberry\perl\bin\perl.EXE" "-I." -Mconfigdata "util\dofile.pl"  "-omakefile" "include\crypto\dso_conf.h.in" > include\crypto\dso_conf.h
        "C:\Strawberry\perl\bin\perl.EXE" "-I." -Mconfigdata "util\dofile.pl"  "-omakefile" "include\openssl\opensslconf.h.in" > include\openssl\opensslconf.h
        "C:\Program Files\Microsoft Visual Studio\2022\Community\VC\Tools\MSVC\14.32.31326\bin\Hostx64\x64\nmake.exe" /                   depend && "C:\Program Files\Microsoft Visual Studio\2022\Community\VC\Tools\MSVC\14.32.31326\bin\Hostx64\x64\nmake.exe" /                   _all

Microsoft(R) Program Maintenance Utility Version 14.32.31328.0
Copyright (C) Microsoft Corporation.  All rights reserved.

Microsoft(R) Program Maintenance Utility Version 14.32.31328.0
Copyright (C) Microsoft Corporation.  All rights reserved.

        C:/Program Files/Microsoft Visual Studio/2022/Community/VC/Tools/MSVC/14.32.31326/bin/Hostx64/x64/cl.exe  /Zi /Fdossl_static.pdb /Gs0 /GF /Gy /MD /W3 /wd4090 /nologo /O2 /I "." /I "include" -D"L_ENDIAN" -D"OPENSSL_PIC" -D"OPENSSLDIR=\"C:\\amazon-kinesis-video-streams-producer-sdk-cpp\\open-source\\local\"" -D"ENGINESDIR=\"C:\\amazon-kinesis-video-streams-producer-sdk-cpp\\open-source\\local\\lib\\engines-1_1\"" -D"OPENSSL_SYS_WIN32" -D"WIN32_LEAN_AND_MEAN" -D"UNICODE" -D"_UNICODE" -D"_CRT_SECURE_NO_DEPRECATE" -D"_WINSOCK_DEPRECATED_NO_WARNINGS" -D"OPENSSL_USE_APPLINK" -D"NDEBUG"  -c /Foapps\app_rand.obj "apps\app_rand.c"
        C:/Program Files/Microsoft Visual Studio/2022/Community/VC/Tools/MSVC/14.32.31326/bin/Hostx64/x64/cl.exe  /Zi /Fdossl_static.pdb /Gs0 /GF /Gy /MD /W3 /wd4090 /nologo /O2 /I "." /I "include" -D"L_ENDIAN" -D"OPENSSL_PIC" -D"OPENSSLDIR=\"C:\\amazon-kinesis-video-streams-producer-sdk-cpp\\open-source\\local\"" -D"ENGINESDIR=\"C:\\amazon-kinesis-video-streams-producer-sdk-cpp\\open-source\\local\\lib\\engines-1_1\"" -D"OPENSSL_SYS_WIN32" -D"WIN32_LEAN_AND_MEAN" -D"UNICODE" -D"_UNICODE" -D"_CRT_SECURE_NO_DEPRECATE" -D"_WINSOCK_DEPRECATED_NO_WARNINGS" -D"OPENSSL_USE_APPLINK" -D"NDEBUG"  /Zs /showIncludes "apps\app_rand.c" 2>&1 > apps\app_rand.d
        C:/Program Files/Microsoft Visual Studio/2022/Community/VC/Tools/MSVC/14.32.31326/bin/Hostx64/x64/cl.exe  /Zi /Fdossl_static.pdb /Gs0 /GF /Gy /MD /W3 /wd4090 /nologo /O2 /I "." /I "include" -D"L_ENDIAN" -D"OPENSSL_PIC" -D"OPENSSLDIR=\"C:\\amazon-kinesis-video-streams-producer-sdk-cpp\\open-source\\local\"" -D"ENGINESDIR=\"C:\\amazon-kinesis-video-streams-producer-sdk-cpp\\open-source\\local\\lib\\engines-1_1\"" -D"OPENSSL_SYS_WIN32" -D"WIN32_LEAN_AND_MEAN" -D"UNICODE" -D"_UNICODE" -D"_CRT_SECURE_NO_DEPRECATE" -D"_WINSOCK_DEPRECATED_NO_WARNINGS" -D"OPENSSL_USE_APPLINK" -D"NDEBUG"  -c /Foapps\apps.obj "apps\apps.c"
        C:/Program Files/Microsoft Visual Studio/2022/Community/VC/Tools/MSVC/14.32.31326/bin/Hostx64/x64/cl.exe  /Zi /Fdossl_static.pdb /Gs0 /GF /Gy /MD /W3 /wd4090 /nologo /O2 /I "." /I "include" -D"L_ENDIAN" -D"OPENSSL_PIC" -D"OPENSSLDIR=\"C:\\amazon-kinesis-video-streams-producer-sdk-cpp\\open-source\\local\"" -D"ENGINESDIR=\"C:\\amazon-kinesis-video-streams-producer-sdk-cpp\\open-source\\local\\lib\\engines-1_1\"" -D"OPENSSL_SYS_WIN32" -D"WIN32_LEAN_AND_MEAN" -D"UNICODE" -D"_UNICODE" -D"_CRT_SECURE_NO_DEPRECATE" -D"_WINSOCK_DEPRECATED_NO_WARNINGS" -D"OPENSSL_USE_APPLINK" -D"NDEBUG"  /Zs /showIncludes "apps\apps.c" 2>&1 > apps\apps.d
        C:/Program Files/Microsoft Visual Studio/2022/Community/VC/Tools/MSVC/14.32.31326/bin/Hostx64/x64/cl.exe  /Zi /Fdossl_static.pdb /Gs0 /GF /Gy /MD /W3 /wd4090 /nologo /O2 /I "." /I "include" -D"L_ENDIAN" -D"OPENSSL_PIC" -D"OPENSSLDIR=\"C:\\amazon-kinesis-video-streams-producer-sdk-cpp\\open-source\\local\"" -D"ENGINESDIR=\"C:\\amazon-kinesis-video-streams-producer-sdk-cpp\\open-source\\local\\lib\\engines-1_1\"" -D"OPENSSL_SYS_WIN32" -D"WIN32_LEAN_AND_MEAN" -D"UNICODE" -D"_UNICODE" -D"_CRT_SECURE_NO_DEPRECATE" -D"_WINSOCK_DEPRECATED_NO_WARNINGS" -D"OPENSSL_USE_APPLINK" -D"NDEBUG"  -c /Foapps\bf_prefix.obj "apps\bf_prefix.c"
        C:/Program Files/Microsoft Visual Studio/2022/Community/VC/Tools/MSVC/14.32.31326/bin/Hostx64/x64/cl.exe  /Zi /Fdossl_static.pdb /Gs0 /GF /Gy /MD /W3 /wd4090 /nologo /O2 /I "." /I "include" -D"L_ENDIAN" -D"OPENSSL_PIC" -D"OPENSSLDIR=\"C:\\amazon-kinesis-video-streams-producer-sdk-cpp\\open-source\\local\"" -D"ENGINESDIR=\"C:\\amazon-kinesis-video-streams-producer-sdk-cpp\\open-source\\local\\lib\\engines-1_1\"" -D"OPENSSL_SYS_WIN32" -D"WIN32_LEAN_AND_MEAN" -D"UNICODE" -D"_UNICODE" -D"_CRT_SECURE_NO_DEPRECATE" -D"_WINSOCK_DEPRECATED_NO_WARNINGS" -D"OPENSSL_USE_APPLINK" -D"NDEBUG"  /Zs /showIncludes "apps\bf_prefix.c" 2>&1 > apps\bf_prefix.d
        C:/Program Files/Microsoft Visual Studio/2022/Community/VC/Tools/MSVC/14.32.31326/bin/Hostx64/x64/cl.exe  /Zi /Fdossl_static.pdb /Gs0 /GF /Gy /MD /W3 /wd4090 /nologo /O2 /I "." /I "include" -D"L_ENDIAN" -D"OPENSSL_PIC" -D"OPENSSLDIR=\"C:\\amazon-kinesis-video-streams-producer-sdk-cpp\\open-source\\local\"" -D"ENGINESDIR=\"C:\\amazon-kinesis-video-streams-producer-sdk-cpp\\open-source\\local\\lib\\engines-1_1\"" -D"OPENSSL_SYS_WIN32" -D"WIN32_LEAN_AND_MEAN" -D"UNICODE" -D"_UNICODE" -D"_CRT_SECURE_NO_DEPRECATE" -D"_WINSOCK_DEPRECATED_NO_WARNINGS" -D"OPENSSL_USE_APPLINK" -D"NDEBUG"  -c /Foapps\opt.obj "apps\opt.c"
        C:/Program Files/Microsoft Visual Studio/2022/Community/VC/Tools/MSVC/14.32.31326/bin/Hostx64/x64/cl.exe  /Zi /Fdossl_static.pdb /Gs0 /GF /Gy /MD /W3 /wd4090 /nologo /O2 /I "." /I "include" -D"L_ENDIAN" -D"OPENSSL_PIC" -D"OPENSSLDIR=\"C:\\amazon-kinesis-video-streams-producer-sdk-cpp\\open-source\\local\"" -D"ENGINESDIR=\"C:\\amazon-kinesis-video-streams-producer-sdk-cpp\\open-source\\local\\lib\\engines-1_1\"" -D"OPENSSL_SYS_WIN32" -D"WIN32_LEAN_AND_MEAN" -D"UNICODE" -D"_UNICODE" -D"_CRT_SECURE_NO_DEPRECATE" -D"_WINSOCK_DEPRECATED_NO_WARNINGS" -D"OPENSSL_USE_APPLINK" -D"NDEBUG"  /Zs /showIncludes "apps\opt.c" 2>&1 > apps\opt.d
        C:/Program Files/Microsoft Visual Studio/2022/Community/VC/Tools/MSVC/14.32.31326/bin/Hostx64/x64/cl.exe  /Zi /Fdossl_static.pdb /Gs0 /GF /Gy /MD /W3 /wd4090 /nologo /O2 /I "." /I "include" -D"L_ENDIAN" -D"OPENSSL_PIC" -D"OPENSSLDIR=\"C:\\amazon-kinesis-video-streams-producer-sdk-cpp\\open-source\\local\"" -D"ENGINESDIR=\"C:\\amazon-kinesis-video-streams-producer-sdk-cpp\\open-source\\local\\lib\\engines-1_1\"" -D"OPENSSL_SYS_WIN32" -D"WIN32_LEAN_AND_MEAN" -D"UNICODE" -D"_UNICODE" -D"_CRT_SECURE_NO_DEPRECATE" -D"_WINSOCK_DEPRECATED_NO_WARNINGS" -D"OPENSSL_USE_APPLINK" -D"NDEBUG"  -c /Foapps\s_cb.obj "apps\s_cb.c"
        C:/Program Files/Microsoft Visual Studio/2022/Community/VC/Tools/MSVC/14.32.31326/bin/Hostx64/x64/cl.exe  /Zi /Fdossl_static.pdb /Gs0 /GF /Gy /MD /W3 /wd4090 /nologo /O2 /I "." /I "include" -D"L_ENDIAN" -D"OPENSSL_PIC" -D"OPENSSLDIR=\"C:\\amazon-kinesis-video-streams-producer-sdk-cpp\\open-source\\local\"" -D"ENGINESDIR=\"C:\\amazon-kinesis-video-streams-producer-sdk-cpp\\open-source\\local\\lib\\engines-1_1\"" -D"OPENSSL_SYS_WIN32" -D"WIN32_LEAN_AND_MEAN" -D"UNICODE" -D"_UNICODE" -D"_CRT_SECURE_NO_DEPRECATE" -D"_WINSOCK_DEPRECATED_NO_WARNINGS" -D"OPENSSL_USE_APPLINK" -D"NDEBUG"  /Zs /showIncludes "apps\s_cb.c" 2>&1 > apps\s_cb.d
        C:/Program Files/Microsoft Visual Studio/2022/Community/VC/Tools/MSVC/14.32.31326/bin/Hostx64/x64/cl.exe  /Zi /Fdossl_static.pdb /Gs0 /GF /Gy /MD /W3 /wd4090 /nologo /O2 /I "." /I "include" -D"L_ENDIAN" -D"OPENSSL_PIC" -D"OPENSSLDIR=\"C:\\amazon-kinesis-video-streams-producer-sdk-cpp\\open-source\\local\"" -D"ENGINESDIR=\"C:\\amazon-kinesis-video-streams-producer-sdk-cpp\\open-source\\local\\lib\\engines-1_1\"" -D"OPENSSL_SYS_WIN32" -D"WIN32_LEAN_AND_MEAN" -D"UNICODE" -D"_UNICODE" -D"_CRT_SECURE_NO_DEPRECATE" -D"_WINSOCK_DEPRECATED_NO_WARNINGS" -D"OPENSSL_USE_APPLINK" -D"NDEBUG"  -c /Foapps\s_socket.obj "apps\s_socket.c"
        C:/Program Files/Microsoft Visual Studio/2022/Community/VC/Tools/MSVC/14.32.31326/bin/Hostx64/x64/cl.exe  /Zi /Fdossl_static.pdb /Gs0 /GF /Gy /MD /W3 /wd4090 /nologo /O2 /I "." /I "include" -D"L_ENDIAN" -D"OPENSSL_PIC" -D"OPENSSLDIR=\"C:\\amazon-kinesis-video-streams-producer-sdk-cpp\\open-source\\local\"" -D"ENGINESDIR=\"C:\\amazon-kinesis-video-streams-producer-sdk-cpp\\open-source\\local\\lib\\engines-1_1\"" -D"OPENSSL_SYS_WIN32" -D"WIN32_LEAN_AND_MEAN" -D"UNICODE" -D"_UNICODE" -D"_CRT_SECURE_NO_DEPRECATE" -D"_WINSOCK_DEPRECATED_NO_WARNINGS" -D"OPENSSL_USE_APPLINK" -D"NDEBUG"  /Zs /showIncludes "apps\s_socket.c" 2>&1 > apps\s_socket.d
        C:/Program Files/Microsoft Visual Studio/2022/Community/VC/Tools/MSVC/14.32.31326/bin/Hostx64/x64/cl.exe  /Zi /Fdossl_static.pdb /Gs0 /GF /Gy /MD /W3 /wd4090 /nologo /O2 /I "." /I "include" -D"L_ENDIAN" -D"OPENSSL_PIC" -D"OPENSSLDIR=\"C:\\amazon-kinesis-video-streams-producer-sdk-cpp\\open-source\\local\"" -D"ENGINESDIR=\"C:\\amazon-kinesis-video-streams-producer-sdk-cpp\\open-source\\local\\lib\\engines-1_1\"" -D"OPENSSL_SYS_WIN32" -D"WIN32_LEAN_AND_MEAN" -D"UNICODE" -D"_UNICODE" -D"_CRT_SECURE_NO_DEPRECATE" -D"_WINSOCK_DEPRECATED_NO_WARNINGS" -D"OPENSSL_USE_APPLINK" -D"NDEBUG"  -c /Foapps\win32_init.obj "apps\win32_init.c"
        C:/Program Files/Microsoft Visual Studio/2022/Community/VC/Tools/MSVC/14.32.31326/bin/Hostx64/x64/cl.exe  /Zi /Fdossl_static.pdb /Gs0 /GF /Gy /MD /W3 /wd4090 /nologo /O2 /I "." /I "include" -D"L_ENDIAN" -D"OPENSSL_PIC" -D"OPENSSLDIR=\"C:\\amazon-kinesis-video-streams-producer-sdk-cpp\\open-source\\local\"" -D"ENGINESDIR=\"C:\\amazon-kinesis-video-streams-producer-sdk-cpp\\open-source\\local\\lib\\engines-1_1\"" -D"OPENSSL_SYS_WIN32" -D"WIN32_LEAN_AND_MEAN" -D"UNICODE" -D"_UNICODE" -D"_CRT_SECURE_NO_DEPRECATE" -D"_WINSOCK_DEPRECATED_NO_WARNINGS" -D"OPENSSL_USE_APPLINK" -D"NDEBUG"  /Zs /showIncludes "apps\win32_init.c" 2>&1 > apps\win32_init.d
        lib /nologo /out:apps\libapps.lib @C:\Users\JT0200~1\AppData\Local\Temp\nmDFF8.tmp
LINK : fatal error LNK1181: 入力ファイル 'apps\app_rand.obj' を開けません。
NMAKE : fatal error U1077: '"C:\Program Files\Microsoft Visual Studio\2022\Community\VC\Tools\MSVC\14.32.31326\bin\HostX64\x64\lib.EXE"' : ���^�[�� �R�[�h '0x49d'
Stop.
NMAKE : fatal error U1077: '"C:\Program Files\Microsoft Visual Studio\2022\Community\VC\Tools\MSVC\14.32.31326\bin\Hostx64\x64\nmake.exe"' : ���^�[�� �R�[�h '0x2'
Stop.
NMAKE : fatal error U1077: 'echo' : ���^�[�� �R�[�h '0x2'
Stop.
NMAKE : fatal error U1077: '"C:\Program Files\Microsoft Visual Studio\2022\Community\VC\Tools\MSVC\14.32.31326\bin\HostX64\x64\nmake.exe"' : ���^�[�� �R�[�h '0x2'
Stop.
NMAKE : fatal error U1077: '"C:\Program Files\Microsoft Visual Studio\2022\Community\VC\Tools\MSVC\14.32.31326\bin\HostX64\x64\nmake.exe"' : ���^�[�� �R�[�h '0x2'
Stop.
CMake Error at dependency/libkvscproducer/kvscproducer-src/CMake/Utilities.cmake:93 (message):
  CMake step for libopenssl failed: 2
Call Stack (most recent call first):
  dependency/libkvscproducer/kvscproducer-src/CMakeLists.txt:69 (build_dependency)

-- Configuring incomplete, errors occurred!
See also "C:/amazon-kinesis-video-streams-producer-sdk-cpp/build/CMakeFiles/CMakeOutput.log".

@risho-lizhao ,
Not sure what is happening, but can you try the environment that is being used in our CI to see if it resolves your issue?
You can find the scripts here:
https://github.com/awslabs/amazon-kinesis-video-streams-producer-sdk-cpp/blob/master/.github/build_windows.bat
https://github.com/awslabs/amazon-kinesis-video-streams-producer-sdk-cpp/blob/2b343c90bd9c8785d9b2b9ba321f053ebf175b5e/.github/workflows/ci.yml#L268
Another way to debug would be to try building openssl standalone on your system using MSVC and seeing if that builds successfully and then try using KVS build.

@disa6302 ,
Thank you for your reply.
I tried building openssl (version 1.1.1i) that using MSVC and builds successfully. Then I build KVS again, but the same error still came out.
Also, I downgraded gstreamer to version 1.16.2 and installed NASM(version 2.15.05) as ci.yml showed.
In addition, I modified the path inside the build_windows.bat and ci.yml according to my computer's environment, and replaced the file downloaded from git. But the same error continues to recur.
Could you tell me which version of openssl you are using?
My build_windows.bat:
call "C:\Program Files\Microsoft Visual Studio\2022\Community\VC\Auxiliary\Build\vcvars64.bat"
mkdir build
cd build
cmd.exe /c cmake -G "NMake Makefiles" ..
cmake -G "NMake Makefiles" -DBUILD_TEST=TRUE -DBUILD_GSTREAMER_PLUGIN=TRUE ..
nmake

My ci.yml:
  windows-msvc:
    runs-on: windows-2022
    env:
      AWS_KVS_LOG_LEVEL: 7
    permissions:
      id-token: write
      contents: read
    steps:
      - name: Clone repository
        uses: actions/checkout@v2
      - name: Install dependencies
        run: |
          choco install nasm strawberryperl
          choco install gstreamer --version=1.16.2
          choco install gstreamer-devel --version=1.16.2
      - name: Build repository
        run: |
          $env:Path += ';C:\Strawberry\perl\site\bin;C:\Strawberry\perl\bin;C:\Strawberry\c\bin;C:\Program Files\NASM;C:\amazon-kinesis-video-streams-producer-sdk-cpp\open-source\local\lib;C:\amazon-kinesis-video-streams-producer-sdk-cpp\open-source\local\bin'
          git config --system core.longpaths true
          .github/build_windows.bat
      - name: Configure AWS Credentials
        uses: aws-actions/configure-aws-credentials@v1
        with:
          role-to-assume: ${{ secrets.AWS_ROLE_TO_ASSUME }}
          role-session-name: ${{ secrets.AWS_ROLE_SESSION_NAME }}
          aws-region: ${{ secrets.AWS_REGION }}
          role-duration-seconds: 10800
      - name: Run tests
        run: |
          $env:Path += ';C:\Strawberry\perl\site\bin;C:\Strawberry\perl\bin;C:\Strawberry\c\bin;C:\Program Files\NASM;C:\amazon-kinesis-video-streams-producer-sdk-cpp\open-source\local\lib;C:\amazon-kinesis-video-streams-producer-sdk-cpp\open-source\local\bin'
          & "C:\amazon-kinesis-video-streams-producer-sdk-cpp\build\tst\producerTest.exe"

@risho-lizhao risho-lizhao I faced the same issue. When I opened Visual Code Studio again, the CMake generation started from the beginning and the problem didn't occur.
log from the run with "fatal error LNK1181":
log 1 fatal error LNK1181.log
the log without this particular error:
log 5 after gstreamer download.log
excerpt from the second log:
...
1> [CMake] -- Finished building dependencies.
1> [CMake] -- Found PkgConfig: C:/gstreamer/1.0/msvc_x86_64/bin/pkg-config.exe (found version "0.29.2")
1> [CMake] -- Checking for module 'libkvspicUtils'
1> [CMake] --   No package 'libkvspicUtils' found
1> [CMake] -- Selecting Windows SDK version 10.0.19041.0 to target Windows 10.0.19044.
1> [CMake] -- Configuring done
1> [CMake] -- Generating done
1> [CMake] -- Build files have been written to: C:/kin-vid-str-prod/dependency/libkvscproducer/kvscproducer-src/dependency/libkvspic
1> [CMake] Microsoft (R) Build Engine 17.0.0+c9eb9dd64 dla platformy .NET Framework
1> [CMake] Copyright (C) Microsoft Corporation. Wszelkie prawa zastrzeżone.
1> [CMake]
1> [CMake]   Performing update step for 'libkvspic-download'
1> [CMake]   No patch step for 'libkvspic-download'
1> [CMake]   No configure step for 'libkvspic-download'
1> [CMake]   No build step for 'libkvspic-download'
1> [CMake]   No install step for 'libkvspic-download'
1> [CMake]   No test step for 'libkvspic-download'
1> [CMake]   Completed 'libkvspic-download'
1> [CMake] -- Looking for pthread.h
1> [CMake] -- Looking for pthread.h - not found
1> [CMake] -- Found Threads: TRUE
1> [CMake] -- Found OpenSSL: C:/kin-vid-str-prod/open-source/local/lib/libcrypto.lib (found version "1.1.1g")
1> [CMake] -- Found CURL: C:/kin-vid-str-prod/open-source/local/lib/cmake/CURL/CURLConfig.cmake (found version "7.68.0-DEV")
1> [CMake] -- Bitness 64 bits
1> [CMake] -- Found ZLIB: C:/gstreamer/1.0/msvc_x86_64/lib/z.lib (found suitable version "1.2.11", minimum required is "1")
1> [CMake] -- Checking for module 'gstreamer-app-1.0'
1> [CMake] --
1> [CMake] CMake Error at C:/Program Files/Microsoft Visual Studio/2022/Community/Common7/IDE/CommonExtensions/Microsoft/CMake/CMake/share/cmake-3.21/Modules/FindPkgConfig.cmake:554 (message):
1> [CMake]   A required package was not found
1> [CMake] Call Stack (most recent call first):
1> [CMake]   C:/Program Files/Microsoft Visual Studio/2022/Community/Common7/IDE/CommonExtensions/Microsoft/CMake/CMake/share/cmake-3.21/Modules/FindPkgConfig.cmake:776 (_pkg_check_modules_internal)
1> [CMake]   CMakeLists.txt:198 (pkg_check_modules)
1> [CMake] -- Configuring incomplete, errors occurred!
1> [CMake] See also "C:/kin-vid-str-prod/out/build/x64-Debug/CMakeFiles/CMakeOutput.log".
1> [CMake] See also "C:/kin-vid-str-prod/out/build/x64-Debug/CMakeFiles/CMakeError.log".
1> Wykonanie operacji „C:\WINDOWS\system32\cmd.exe” „/c "%SYSTEMROOT%\System32\chcp.com 65001 >NUL && "C:\PROGRAM FILES\MICROSOFT VISUAL STUDIO\2022\COMMUNITY\COMMON7\IDE\COMMONEXTENSIONS\MICROSOFT\CMAKE\CMake\bin\cmake.exe"  -G "Ninja"  -DCMAKE_BUILD_TYPE:STRING="Debug" -DCMAKE_INSTALL_PREFIX:PATH="C:\kin-vid-str-prod\out\install\x64-Debug" -DCMAKE_C_COMPILER:FILEPATH="C:/Program Files/Microsoft Visual Studio/2022/Community/VC/Tools/MSVC/14.30.30705/bin/Hostx64/x64/cl.exe" -DCMAKE_CXX_COMPILER:FILEPATH="C:/Program Files/Microsoft Visual Studio/2022/Community/VC/Tools/MSVC/14.30.30705/bin/Hostx64/x64/cl.exe" -DBUILD_GSTREAMER_PLUGIN=ON -DCMAKE_MAKE_PROGRAM="C:\PROGRAM FILES\MICROSOFT VISUAL STUDIO\2022\COMMUNITY\COMMON7\IDE\COMMONEXTENSIONS\MICROSOFT\CMAKE\Ninja\ninja.exe" "C:\kin-vid-str-prod" 2>&1"” nie powiodło się z powodu błędu: „„C:\WINDOWS\system32\cmd.exe”: element „/c "%SYSTEMROOT%\System32\chcp.com 65001 >NUL && "C:\PROGRAM FILES\MICROSOFT VISUAL STUDIO\2022\COMMUNITY\COMMON7\IDE\COMMONEXTENSIONS\MICROSOFT\CMAKE\CMake\bin\cmake.exe"  -G "Ninja"  -DCMAKE_BUILD_TYPE:STRING="Debug" -DCMAKE_INSTALL_PREFIX:PATH="C:\kin-vid-str-prod\out\install\x64-Debug" -DCMAKE_C_COMPILER:FILEPATH="C:/Program Files/Microsoft Visual Studio/2022/Community/VC/Tools/MSVC/14.30.30705/bin/Hostx64/x64/cl.exe" -DCMAKE_CXX_COMPILER:FILEPATH="C:/Program Files/Microsoft Visual Studio/2022/Community/VC/Tools/MSVC/14.30.30705/bin/Hostx64/x64/cl.exe" -DBUILD_GSTREAMER_PLUGIN=ON -DCMAKE_MAKE_PROGRAM="C:\PROGRAM FILES\MICROSOFT VISUAL STUDIO\2022\COMMUNITY\COMMON7\IDE\COMMONEXTENSIONS\MICROSOFT\CMAKE\Ninja\ninja.exe" "C:\kin-vid-str-prod" 2>&1"” zwrócił kod zakończenia: 1”.

Like it is visible in the second log, I also struggle with "CMake generation".
Has anyone idea whether I have a problem with:

No package 'libkvspicUtils' found
Looking for pthread.h - not found
gstreamer-app-1.0 is the package which wasn't found and broke the process
?

@darek-gc
Thank you for your advice.
I used x64 Native Tools Command Prompt and when cannot open input file 'apps\app_rand.obj' show again, I rerun cmake .. -G "NMake Makefiles" -DBUILD_GSTREAMER_PLUGIN=ON -DBUILD_JNI=TRUE command, then the error disappears. The build runs further, but another error occurs:
[100%] Completed 'project_libcurl'
[100%] Built target project_libcurl
-- Finished building dependencies.
-- Found PkgConfig: C:/MinGW/bin/pkg-config.exe (found version "0.26")
-- Checking for module 'libkvspicUtils'
--   No package 'libkvspicUtils' found
-- Building for: Visual Studio 17 2022
-- Selecting Windows SDK version 10.0.19041.0 to target Windows 10.0.19044.
-- Configuring done
-- Generating done
-- Build files have been written to: C:/amazon-kinesis-video-streams-producer-sdk-cpp/dependency/libkvscproducer/kvscproducer-src/dependency/libkvspic
.NET Framework 向け Microsoft (R) Build Engine バージョン 17.2.1+52cd2da31
Copyright (C) Microsoft Corporation.All rights reserved.

  Checking Build System
  Creating directories for 'libkvspic-download'
  Building Custom Rule C:/amazon-kinesis-video-streams-producer-sdk-cpp/dependency/libkvscproducer/kvscproducer-src/dependency/libkvspic/CMakeLists.txt
  Performing download step (git clone) for 'libkvspic-download'
  Cloning into 'kvspic-src'...
  HEAD is now at c832588 Testing images stuff (#172)
  Performing update step for 'libkvspic-download'
  No patch step for 'libkvspic-download'
  No configure step for 'libkvspic-download'
  No build step for 'libkvspic-download'
  No install step for 'libkvspic-download'
  No test step for 'libkvspic-download'
  Completed 'libkvspic-download'
  Building Custom Rule C:/amazon-kinesis-video-streams-producer-sdk-cpp/dependency/libkvscproducer/kvscproducer-src/dependency/libkvspic/CMakeLists.txt
-- Looking for pthread.h
-- Looking for pthread.h - not found
-- Found Threads: TRUE
-- Found OpenSSL: C:/amazon-kinesis-video-streams-producer-sdk-cpp/open-source/local/lib/libcrypto.lib (found version "1.1.1g")
-- Found CURL: C:/amazon-kinesis-video-streams-producer-sdk-cpp/open-source/local/lib/cmake/CURL/CURLConfig.cmake (found version "7.68.0-DEV")
-- Bitness 64 bits
-- Found ZLIB: C:/gstreamer/1.0/x86_64/lib/z.lib (found suitable version "1.2.8", minimum required is "1")
CMake Error at C:/Program Files/CMake/share/cmake-3.21/Modules/FindPackageHandleStandardArgs.cmake:230 (message):
  Could NOT find JNI (missing: JAVA_AWT_LIBRARY JAVA_JVM_LIBRARY
  JAVA_INCLUDE_PATH JAVA_INCLUDE_PATH2 JAVA_AWT_INCLUDE_PATH)
Call Stack (most recent call first):
  C:/Program Files/CMake/share/cmake-3.21/Modules/FindPackageHandleStandardArgs.cmake:594 (_FPHSA_FAILURE_MESSAGE)
  C:/Program Files/CMake/share/cmake-3.21/Modules/FindJNI.cmake:382 (FIND_PACKAGE_HANDLE_STANDARD_ARGS)
  CMakeLists.txt:189 (find_package)

-- Configuring incomplete, errors occurred!
See also "C:/amazon-kinesis-video-streams-producer-sdk-cpp/build/CMakeFiles/CMakeOutput.log".
See also "C:/amazon-kinesis-video-streams-producer-sdk-cpp/build/CMakeFiles/CMakeError.log".

I tried advice from @disa6302 , that used my build_windows.bat and ci.yml files, but the new error still occurs.

Hi @risho-lizhao, looks like you do not have Java installed on your Windows system. Please install Java with JDK and set JAVA_HOME in your environment variables and try again with the steps @disa6302 has suggested

Hello @niyatim23 , Sorry for my late reply and thank you for your  advice.
After installing JDK and setting environment variables, error message Could NOT find JNI solved.
But another new error occurs.
I have installed Gstreamer 1.0 and Gstreamer 1.0 Development(version: 1.6.2) and set up environment variables.
The new error:
  Checking Build System
  Creating directories for 'libkvspic-download'
  Building Custom Rule C:/amazon-kinesis-video-streams-producer-sdk-cpp/dependency/libkvscproducer/kvscproducer-src/dependency/libkvspic/CMakeLists.txt
  Performing download step (git clone) for 'libkvspic-download'
  Cloning into 'kvspic-src'...
  HEAD is now at c832588 Testing images stuff (#172)
  Performing update step for 'libkvspic-download'
  No patch step for 'libkvspic-download'
  No configure step for 'libkvspic-download'
  No build step for 'libkvspic-download'
  No install step for 'libkvspic-download'
  No test step for 'libkvspic-download'
  Completed 'libkvspic-download'
  Building Custom Rule C:/amazon-kinesis-video-streams-producer-sdk-cpp/dependency/libkvscproducer/kvscproducer-src/dependency/libkvspic/CMakeLists.txt
-- Looking for pthread.h
-- Looking for pthread.h - not found
-- Found Threads: TRUE
-- Found OpenSSL: C:/amazon-kinesis-video-streams-producer-sdk-cpp/open-source/local/lib/libcrypto.lib (found version "1.1.1g")
-- Found CURL: C:/amazon-kinesis-video-streams-producer-sdk-cpp/open-source/local/lib/cmake/CURL/CURLConfig.cmake (found version "7.68.0-DEV")
-- Bitness 64 bits
-- Found ZLIB: C:/gstreamer/1.0/x86_64/lib/z.lib (found suitable version "1.2.8", minimum required is "1")
-- Found JNI: C:/Program Files/Java/jdk-<IP_ADDRESS>/lib/jawt.lib
-- Checking for module 'gstreamer-app-1.0'
--
CMake Error at C:/Program Files/CMake/share/cmake-3.21/Modules/FindPkgConfig.cmake:554 (message):
  A required package was not found
Call Stack (most recent call first):
  C:/Program Files/CMake/share/cmake-3.21/Modules/FindPkgConfig.cmake:776 (_pkg_check_modules_internal)
  CMakeLists.txt:198 (pkg_check_modules)

-- Configuring incomplete, errors occurred!
See also "C:/amazon-kinesis-video-streams-producer-sdk-cpp/build/CMakeFiles/CMakeOutput.log".
See also "C:/amazon-kinesis-video-streams-producer-sdk-cpp/build/CMakeFiles/CMakeError.log".

Do I miss anything else?

Hi @risho-lizhao, I think you should clean up your previous build with git clean -ffxd from the root directory and try again. Also, make sure that you set the correct value in the $env:Path . The last two paths in the same are specific to where your directory's lib and bin folders are:
$env:Path += ';C:\Strawberry\perl\site\bin;C:\Strawberry\perl\bin;C:\Strawberry\c\bin;C:\Program Files\NASM;C:\amazon-kinesis-video-streams-producer-sdk-cpp\open-source\local\lib;C:\amazon-kinesis-video-streams-producer-sdk-cpp\open-source\local\bin'
Can you check if you are specifying the correct paths here?

Hello @niyatim23 , I clean up my previous build, and check all paths, they are set correctly.
In addition, I was able to confirm that Gstreamer worked properly by using the command: gst-launch-1.0 videotestsrc ! autovideosink.
First, I executed the cmake -G "NMake Makefiles" .. command and no errors occurred.
However, when I execute the cmake -G "NMake Makefiles" -DBUILD_TEST=TRUE -DBUILD_GSTREAMER_PLUGIN=TRUE ..  command, I get the following error:
Microsoft(R) Program Maintenance Utility Version 14.32.31328.0
Copyright (C) Microsoft Corporation.  All rights reserved.

Consolidate compiler generated dependencies of target gtest
[ 50%] Built target gtest
Consolidate compiler generated dependencies of target gtest_main
[100%] Built target gtest_main
Install the project...
-- Install configuration: "Debug"
-- Installing: C:/amazon-kinesis-video-streams-producer-sdk-cpp/open-source/local/lib/cmake/GTest/GTestTargets.cmake
-- Installing: C:/amazon-kinesis-video-streams-producer-sdk-cpp/open-source/local/lib/cmake/GTest/GTestTargets-debug.cmake
-- Installing: C:/amazon-kinesis-video-streams-producer-sdk-cpp/open-source/local/lib/cmake/GTest/GTestConfigVersion.cmake
-- Installing: C:/amazon-kinesis-video-streams-producer-sdk-cpp/open-source/local/lib/cmake/GTest/GTestConfig.cmake
-- Up-to-date: C:/amazon-kinesis-video-streams-producer-sdk-cpp/open-source/local/include
-- Up-to-date: C:/amazon-kinesis-video-streams-producer-sdk-cpp/open-source/local/include/gtest
-- Installing: C:/amazon-kinesis-video-streams-producer-sdk-cpp/open-source/local/include/gtest/gtest-death-test.h
-- Installing: C:/amazon-kinesis-video-streams-producer-sdk-cpp/open-source/local/include/gtest/gtest-message.h
-- Installing: C:/amazon-kinesis-video-streams-producer-sdk-cpp/open-source/local/include/gtest/gtest-param-test.h
-- Installing: C:/amazon-kinesis-video-streams-producer-sdk-cpp/open-source/local/include/gtest/gtest-param-test.h.pump
-- Installing: C:/amazon-kinesis-video-streams-producer-sdk-cpp/open-source/local/include/gtest/gtest-printers.h
-- Installing: C:/amazon-kinesis-video-streams-producer-sdk-cpp/open-source/local/include/gtest/gtest-spi.h
-- Installing: C:/amazon-kinesis-video-streams-producer-sdk-cpp/open-source/local/include/gtest/gtest-test-part.h
-- Installing: C:/amazon-kinesis-video-streams-producer-sdk-cpp/open-source/local/include/gtest/gtest-typed-test.h
-- Installing: C:/amazon-kinesis-video-streams-producer-sdk-cpp/open-source/local/include/gtest/gtest.h
-- Installing: C:/amazon-kinesis-video-streams-producer-sdk-cpp/open-source/local/include/gtest/gtest_pred_impl.h
-- Installing: C:/amazon-kinesis-video-streams-producer-sdk-cpp/open-source/local/include/gtest/gtest_prod.h
-- Up-to-date: C:/amazon-kinesis-video-streams-producer-sdk-cpp/open-source/local/include/gtest/internal
-- Up-to-date: C:/amazon-kinesis-video-streams-producer-sdk-cpp/open-source/local/include/gtest/internal/custom
-- Installing: C:/amazon-kinesis-video-streams-producer-sdk-cpp/open-source/local/include/gtest/internal/custom/gtest-port.h
-- Installing: C:/amazon-kinesis-video-streams-producer-sdk-cpp/open-source/local/include/gtest/internal/custom/gtest-printers.h
-- Installing: C:/amazon-kinesis-video-streams-producer-sdk-cpp/open-source/local/include/gtest/internal/custom/gtest.h
-- Installing: C:/amazon-kinesis-video-streams-producer-sdk-cpp/open-source/local/include/gtest/internal/custom/README.md
-- Installing: C:/amazon-kinesis-video-streams-producer-sdk-cpp/open-source/local/include/gtest/internal/gtest-death-test-internal.h
-- Installing: C:/amazon-kinesis-video-streams-producer-sdk-cpp/open-source/local/include/gtest/internal/gtest-filepath.h
-- Installing: C:/amazon-kinesis-video-streams-producer-sdk-cpp/open-source/local/include/gtest/internal/gtest-internal.h
-- Installing: C:/amazon-kinesis-video-streams-producer-sdk-cpp/open-source/local/include/gtest/internal/gtest-linked_ptr.h
-- Installing: C:/amazon-kinesis-video-streams-producer-sdk-cpp/open-source/local/include/gtest/internal/gtest-param-util-generated.h
-- Installing: C:/amazon-kinesis-video-streams-producer-sdk-cpp/open-source/local/include/gtest/internal/gtest-param-util-generated.h.pump
-- Installing: C:/amazon-kinesis-video-streams-producer-sdk-cpp/open-source/local/include/gtest/internal/gtest-param-util.h
-- Installing: C:/amazon-kinesis-video-streams-producer-sdk-cpp/open-source/local/include/gtest/internal/gtest-port-arch.h
-- Installing: C:/amazon-kinesis-video-streams-producer-sdk-cpp/open-source/local/include/gtest/internal/gtest-port.h
-- Installing: C:/amazon-kinesis-video-streams-producer-sdk-cpp/open-source/local/include/gtest/internal/gtest-string.h
-- Installing: C:/amazon-kinesis-video-streams-producer-sdk-cpp/open-source/local/include/gtest/internal/gtest-tuple.h
-- Installing: C:/amazon-kinesis-video-streams-producer-sdk-cpp/open-source/local/include/gtest/internal/gtest-tuple.h.pump
-- Installing: C:/amazon-kinesis-video-streams-producer-sdk-cpp/open-source/local/include/gtest/internal/gtest-type-util.h
-- Installing: C:/amazon-kinesis-video-streams-producer-sdk-cpp/open-source/local/include/gtest/internal/gtest-type-util.h.pump
-- Installing: C:/amazon-kinesis-video-streams-producer-sdk-cpp/open-source/local/lib/gtestd.lib
-- Installing: C:/amazon-kinesis-video-streams-producer-sdk-cpp/open-source/local/lib/gtest_maind.lib
-- Installing: C:/amazon-kinesis-video-streams-producer-sdk-cpp/open-source/local/lib/pkgconfig/gtest.pc
-- Installing: C:/amazon-kinesis-video-streams-producer-sdk-cpp/open-source/local/lib/pkgconfig/gtest_main.pc
[ 88%] No test step for 'libgtest-download'
[100%] Completed 'libgtest-download'
[100%] Built target libgtest-download
-- Bitness 64 bits
-- Checking for module 'gstreamer-app-1.0'
--
CMake Error at C:/Program Files/CMake/share/cmake-3.21/Modules/FindPkgConfig.cmake:554 (message):
  A required package was not found
Call Stack (most recent call first):
  C:/Program Files/CMake/share/cmake-3.21/Modules/FindPkgConfig.cmake:776 (_pkg_check_modules_internal)
  CMakeLists.txt:198 (pkg_check_modules)

-- Configuring incomplete, errors occurred!
See also "C:/amazon-kinesis-video-streams-producer-sdk-cpp/build/CMakeFiles/CMakeOutput.log".
See also "C:/amazon-kinesis-video-streams-producer-sdk-cpp/build/CMakeFiles/CMakeError.log".

Hi @risho-lizhao, please ensure that you are using openssl installed as a dependency from the SDK CPP. Please ensure that you have GStreamer related dependencies installed mentioned in the ci build shared with you

Hello @niyatim23 , I have installed openssl, but could you tell me how should I check that I am using openssl installed as a dependency from the SDK CPP?
In addition, GStreamer related dependencies I have installed are shown below, have I missed any dependencies that I haven't installed?
C:\Users\jt0200544>perl -v

This is perl 5, version 32, subversion 1 (v5.32.1) built for MSWin32-x64-multi-thread

Copyright 1987-2021, Larry Wall

Perl may be copied only under the terms of either the Artistic License or the
GNU General Public License, which may be found in the Perl 5 source kit.

Complete documentation for Perl, including FAQ lists, should be found on
this system using "man perl" or "perldoc perl".  If you have access to the
Internet, point your browser at http://www.perl.org/, the Perl Home Page.

C:\Users\jt0200544>nasm -version
NASM version 2.15.05 compiled on Aug 28 2020

C:\Users\jt0200544>java -version
java version "<IP_ADDRESS>" 2022-04-22
Java(TM) SE Runtime Environment (build <IP_ADDRESS>+2-6)
Java HotSpot(TM) 64-Bit Server VM (build <IP_ADDRESS>+2-6, mixed mode, sharing)

C:\Users\jt0200544>pkg-config --version
0.26

C:\Users\jt0200544>openssl version
OpenSSL 1.1.1i  8 Dec 2020

You may be able to check it in your build logs. Also, check if gstreamer works for you as a stand-alone application. If not, please resolve that first

Hi @risho-lizhao, in that case, it is difficult to point out what is going wrong. Please try a clean build with the correct paths set and refer to the ci for the instructions.
Closing assuming answered. Feel free to reopen in case of any further issues

@risho-lizhao
I had the same issue as you where gstreamer-app-1.0 could not be located. I was able to successfully build the plugin by:

Moving gstreamer so its new path would be C:\gstreamer\1.0\x86_64 (instead of msvc_x86_64 for the last folder)
Setting GSTREAMER_1_0_ROOT_MSVC_X86_64 environment variable to C:\gstreamer\1.0\x86_64
Updating path environment variable to include C:\gstreamer\1.0\x86_64\bin, C:\gstreamer\1.0\x86_64\lib, and C:\gstreamer\1.0\x86_64\include
Running the build_windows.bat file in the .github directory of the repository

Not sure which change fixed it for me, but the build was successful. Hope this helps!

@mattrrubino
Thank you very much! I build it successfully by your way!
But now I have another problem when excute gst-inspect-1.0 kvssink.
I set environment variables by use follow command:
C:\amazon-kinesis-video-streams-producer-sdk-cpp>set GST_PLUGIN_PATH=%CD%\build
C:\amazon-kinesis-video-streams-producer-sdk-cpp>set PATH=%PATH%;%CD%\open-source\local\bin;%CD%\open-source\local\lib

Then, if I excute gst-inspect-1.0 kvssink, I will get error that looklike:
(gst-inspect-1.0:15760): GStreamer-WARNING **: 16:45:42.123: Failed to load plugin 'C:\amazon-kinesis-video-streams-producer-sdk-cpp\build\gstkvssink.dll': 'C:\amazon-kinesis-video-streams-producer-sdk-cpp\build\gstkvssink.dll': The specified module cannot be found.
No such element or plugin 'kvssink'

I confirmed that the gstkvssink.dll file exists in the build folder.
Do you hava any idea about this error?

@risho-lizhao
Glad to hear that fixed the build!
I did not encounter this new problem, but I also did not follow the build instructions exactly.
Rather than setting the environment variables through the command prompt, I set them through the Windows GUI, copying the exact paths as opposed to using %CD%.
Then, I started a new command prompt, and it worked.
Maybe this will work for you too.

@mattrrubino
Thank you again, I originally installed version 1.16.2 of gtreamer and after replacing it with version 1.20.2, the problem was solved. I don't know exactly what the cause was, but at least it seems to be working properly now.


RecyclerView and ScrollBars

I've this situation in my code:
    override fun onCreateView(inflater: LayoutInflater?, container: ViewGroup?, savedInstanceState: Bundle?): View? {
        return UI {
            verticalLayout {
                lparams(width = matchParent, height = matchParent)

                mList = recyclerView {
                    lparams(width = matchParent, height = matchParent)
                    leftPadding = dip(8)
                    rightPadding = dip(8)

                    val lm = LinearLayoutManager(ctx)
                    lm.isSmoothScrollbarEnabled = true
                    layoutManager = lm

                    setHasFixedSize(true)

                    addItemDecoration(HorizontalDividerItemDecoration.Builder(ctx).build())

                    isVerticalScrollBarEnabled = true
                    isScrollbarFadingEnabled = true

                }

            }
        }.view
    }

but I can't see the vertical scrollbar, basically without Anko I need to add scrollbars="vertical" in XML and all work. Now how can I do this with Anko?

See this SO question and its answer.

it seems to be impossible to enable scroll bars programmatically [on RecyclerViews]

I do that, thank you so much

Note that this problem also exists with ListView and ScrollView. And there is a way to fix it without using XML layouts, see this answer: https://stackoverflow.com/a/41937476/3646645


Fixes #22 - Exception on draft_destroy when has_one association is nil

self.send(association.name) will return nil if the association is empty (there are no dependents).  Currently, if the association is has_one and the result is nil, it is still wrapped in an array.  When we try to access this nil element in the following .each block, an exception is thrown.
The changes to model.rb resolve this issue.  Singular dependents are only wrapped in an array if they exist (and nil isn't wrapped).
The .each block is also only called if the dependents exist.  So, whether a has_one or has_many returns nil, the block will be bypassed and we avoid any exceptions.
I added an OnlyChild class and association to the parents to easily test this fix.  Without the fix, many of the current tests will fail.  With the fix in place, the tests will run properly again.
Hope this is helpful, @chrisdpeters!  As always, let me know if you want something changed.

Can you explain this? "Without the fix, many of the current tests will fail." Sorry, I may be reading it wrong. I run the tests on 0.3.2, and they all pass.
Looks like we will need a v0.3.4. Thanks for getting involved with helping me maintain these issues. And especially thanks for including tests with your pull requests!

No worries -- I had a tough time putting this one in words.  Some of the current tests will fail if a has_one association is added, e.g. to the Parent.
In this commit, I slightly changed the schema.  I added a migration and an OnlyChild class, and then updated `Parent

I added a migration and changed the Parent class to contain has_one :only_child.
If I put that in,

No worries -- I had a tough time putting this one in words.  Some of the current tests will fail if a has_one association is added, e.g. to the Parent.
In this commit, I slightly changed the schema.  I added a migration and an OnlyChild class, and then updated Parent to contain has_one :only_child.  With those changes (no changes to the specs directly), a number of them will fail.
The fix in this commit addresses schemas with has_one relationships, specifically those which don't currently have an association linked to them (so the association is nil).
If you clone this branch and reset the changes to model.rb, then migrate/test, you should see a lot of failing tests.  Hope that clears it up.  I can try to add more info too, if you'd like.

Hey @chrisdpeters, just wondering if you had a chance to look at this one yet.  No problem if you haven't, but if you want more explanation or info let me know.

No, I haven't. I'll take a look sometime this week.
My mom passed away a couple weeks ago, so my priorities have been elsewhere until today. Glad to be back into the code though!

I'm very sorry, Chris.  No rush at all.
I may be submitting another PR this week as well, but I'm primarily working from my own fork.

No problem, and thanks. I know you're excited about this, and I appreciate all of the bugs that you're fixing. Just wanted you to know why I needed to slow down for a little bit.


Binaries: Statically link libssl for local development

When working on Linux and not having libssl installed, the Prisma binaries won't work.
2 options to improve the UX here:

Prompt the user in the CLI to install libssl using the platform's package manager. (Not clear if the binary by itself could even be started, but whatever client starts it might handle that)

A more seamless experience could be to automatically download a binary version that statically includes libssl and print a warning that this is potentially a security issue.

Does not seem to be a common issue.


Robust memory leak patch

Fixed all retain issues with all presenters and views
Fixed retain issues in Router
LockViewController retains current presenter
Fixed debounce retention
Fixed password reset, was accepting non emails

Closed in favor of #364


Just some minor changes to README.md and python_fm_1.ipynb

Many thanks @semacu for your contributions! And fixing all these typos... sorry about them!


Routes breaks after deployment

OS?

Windows 10

Versions.

angular-cli: 1.0.0-beta.19-3
node: 7.0.0
os: win32 x64

Repro steps.

The page loads quite well for the first time with the below url
http://<IP_ADDRESS>/project/home/about
But upon refreshing the page gives a 404 error.

The log given by the failure.

GET http://<IP_ADDRESS>/project/home/about 404 (Not Found)

Mention any other details that might be useful.
I am using Apache Tomcat server.
I searched for this issue and found that I need to have a .htaccess file for the server configuration or use a Hash Strategy Method.
But I am confused which one would be the best as I am deploying it for the production.
Also how to get this configuration done... as I tried with .htaccess file but not getting the issue resolved..

Thanks! We'll be in touch soon.

Server configuration is really out of scope for the CLI.  I would suggest asking on Stack Overflow or similar.

My application is working fine now when I used Hash Strategy Method. Just wanted to know is this the best/preferred way to make it work.

Personally, I would consider the hash strategy as a backup method for when the default won't work for your situation.  However, both are viable.  A quick search on stack overflow found this: http://stackoverflow.com/questions/28767585/tomcat-8-url-rewrite

Hi @ahaan729 personally I prefer HTML5 routing. What you need to do is have a rewrite rule on your webserver that redirects URLs that don't have actual matching files back to your index.html if you're using NGINX this is what that looks like (in it's most basic form, your individual needs may be very differnt):
    location / {
        try_files  $uri $uri/ index.html;
    }

@clydin's and @dvenske comments are spot on. I'm sorry I can't help you more but these questions really are out of scope, and I barely have time as is to go over direct CLI questions/issues,

@filipesilva It's okay.
Actually, I have made my application work with the Hash Strategy Method. I wanted to follow the best practices for the A2 apps, so I was curious to know the way I have done is viable or not.
Also, using Hash Strategy Method won't be a issue later... when it is deployed over the production?
A small clarification from your side will be really helpful Filipe.

@ahaan729 -- see http://stackoverflow.com/questions/40142130/configure-history-pushstate-for-angular-2

Thanks @JanStureNielsen

@ahaan729 the recommendation is to not use Hash Strategy.

@filipesilva Thanks a lot for clearing my doubts and issues here and in other threads also.
That would of great help to me.

Hi, did you manage to correct that? I have the same problem with the apache tomcat :(


Vendor endpoints

Co-Authored-by: Dan Sample<EMAIL_ADDRESS>Description
Added in our model and routes for vendor information
Fixes # (issue)
Type of change
Please delete options that are not relevant.

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

Change Status

[x] Complete, tested, ready to review and merge
[ ] Complete, but not tested (may need new tests)
[ ] Incomplete/work-in-progress, PR is for discussion/feedback

How Has This Been Tested?

[x] Postman

Checklist

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] My code has been reviewed by at least one peer
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes
[ ] There are no merge conflicts

 Routes/Model: Vendors


Improve the site structure

Context
Due to incremental changes, the Layout component currently has several conditional rendering rules based on the page routes. By restructuring the site architecture, we can simplify and preferably get rid of them.
Also this PR should address other layout issues (e.g., z-index).
Problem or idea
There are several ways we can approach this:

Make the global header's CSS position to be sticky so that the FixedBox styled-component and its height calculation logic can be removed
Extract the ProgressBar styled-component and make it as its own component
Make  the Main component to be full width and define content width at the page level so that the widePaths check can be removed
Reduce props on Main and define them at the page level
Move the donate button logic (for the about page) to the Header component
Move the excludeContributeBanner logic to the ContributeBanner component
Make the ContributeBanner visibility check more generic by using its parent rather than its id (to prevent typos) and remove useBanner hook

Solution or next step
@davidsmejia  Please feel free to add any ideas here💡

🗒 The issue this PR was closed, so closing this, too.


Query Helm charts in all namespaces

Results in the following when multiple HelmChart resources are detected:
    Last Transition Time:           2024-10-25T17:45:40Z
    Message:                        Unable to upgrade Helm release 'neuvector' backed by multiple HelmChart resources
    Reason:                         Failed
    Status:                         False
    Type:                           NeuVectorUpgraded

Only works when the Upgrade Controller is watching all namespaces which goes against our current design.


run-ngs-pipeline error with CYP2D6

Hello,
I'm trying to use the run-ngs-pipeline tool on different genes. The genes without SV works just fine, but I get this error when trying to run it on CYP2D6.
I'm on Ubuntu 24.04.1 LTS.
I installed PyPGx using git clone.
The two zip files have been generated with the adapted tools included in pypgx, with the right assembly.
The .vcf.gz file was also generated using pypgx, with GRCh28 setup as the assembly.
Here is what happen when running run-ngs-pipeline on TMPT, this seems like the expected behaviour (but maybe it's not ?):
(base) user:~/Documents/JCB/pypgx/bamSophia$ pypgx run-ngs-pipeline TPMT TPMT_pipeline --variants AllSamples.vcf.gz --depth-of-coverage grch38_AllSamples_depth.zip --control-statistics grch38_AllSamples_stats.zip --platform Targeted --assembly GRCh38
/home/bioinfo-bioch/miniconda3/lib/python3.12/site-packages/pypgx/api/pipeline.py:211: UserWarning: User provided CovFrame[DepthOfCoverage] even though the target gene does not have any star alleles defined by SVs. PyPGx will ignore it.
  warnings.warn(message)
/home/bioinfo-bioch/miniconda3/lib/python3.12/site-packages/pypgx/api/pipeline.py:219: UserWarning: User provided SampleTable[Statistics] even though the target gene does not have any star alleles defined by SVs. PyPGx will ignore it.
  warnings.warn(message)
Saved VcfFrame[Imported] to: TPMT_pipeline/imported-variants.zip
Saved VcfFrame[Phased] to: TPMT_pipeline/phased-variants.zip
Saved VcfFrame[Consolidated] to: TPMT_pipeline/consolidated-variants.zip
Saved SampleTable[Alleles] to: TPMT_pipeline/alleles.zip
Saved SampleTable[Genotypes] to: TPMT_pipeline/genotypes.zip
Saved SampleTable[Phenotypes] to: TPMT_pipeline/phenotypes.zip
Saved SampleTable[Results] to: TPMT_pipeline/results.zip

And here is the error message when running it on CYP2D6 :
(base) user:~/Documents/JCB/pypgx/bamSophia$ pypgx run-ngs-pipeline CYP2D6 CYP2D6_pipeline --variants AllSamples.vcf.gz --depth-of-coverage grch38_AllSamples_depth.zip --control-statistics grch38_AllSamples_stats.zip --platform Targeted --assembly GRCh38
Saved VcfFrame[Imported] to: CYP2D6_pipeline/imported-variants.zip
Saved VcfFrame[Phased] to: CYP2D6_pipeline/phased-variants.zip
Saved VcfFrame[Consolidated] to: CYP2D6_pipeline/consolidated-variants.zip
Saved SampleTable[Alleles] to: CYP2D6_pipeline/alleles.zip
/home/bioinfo-bioch/miniconda3/lib/python3.12/site-packages/fuc/api/pycov.py:460: DtypeWarning: Columns (0) have mixed types. Specify dtype option on import or set low_memory=False.
  return cls(pd.read_table(fn))
Saved CovFrame[ReadDepth] to: CYP2D6_pipeline/read-depth.zip
Saved CovFrame[CopyNumber] to: CYP2D6_pipeline/copy-number.zip
/home/bioinfo-bioch/miniconda3/lib/python3.12/site-packages/sklearn/base.py:376: InconsistentVersionWarning: Trying to unpickle estimator SVC from version 0.24.2 when using version 1.5.2. This might lead to breaking code or invalid results. Use at your own risk. For more info please refer to:
https://scikit-learn.org/stable/model_persistence.html#security-maintainability-limitations
  warnings.warn(
/home/bioinfo-bioch/miniconda3/lib/python3.12/site-packages/sklearn/base.py:376: InconsistentVersionWarning: Trying to unpickle estimator LabelBinarizer from version 0.24.2 when using version 1.5.2. This might lead to breaking code or invalid results. Use at your own risk. For more info please refer to:
https://scikit-learn.org/stable/model_persistence.html#security-maintainability-limitations
  warnings.warn(
/home/bioinfo-bioch/miniconda3/lib/python3.12/site-packages/sklearn/base.py:376: InconsistentVersionWarning: Trying to unpickle estimator OneVsRestClassifier from version 0.24.2 when using version 1.5.2. This might lead to breaking code or invalid results. Use at your own risk. For more info please refer to:
https://scikit-learn.org/stable/model_persistence.html#security-maintainability-limitations
  warnings.warn(
/home/bioinfo-bioch/miniconda3/lib/python3.12/site-packages/pypgx/api/utils.py:151: FutureWarning: DataFrame.fillna with 'method' is deprecated and will raise in a future version. Use obj.ffill() or obj.bfill() instead.
  df = df.fillna(method='ffill')
/home/bioinfo-bioch/miniconda3/lib/python3.12/site-packages/pypgx/api/utils.py:152: FutureWarning: DataFrame.fillna with 'method' is deprecated and will raise in a future version. Use obj.ffill() or obj.bfill() instead.
  df = df.fillna(method='bfill')
Traceback (most recent call last):
  File "/home/bioinfo-bioch/miniconda3/bin/pypgx", line 8, in <module>
    sys.exit(main())
             ^^^^^^
  File "/home/bioinfo-bioch/miniconda3/lib/python3.12/site-packages/pypgx/__main__.py", line 33, in main
    commands[args.command].main(args)
  File "/home/bioinfo-bioch/miniconda3/lib/python3.12/site-packages/pypgx/cli/run_ngs_pipeline.py", line 159, in main
    pipeline.run_ngs_pipeline(
  File "/home/bioinfo-bioch/miniconda3/lib/python3.12/site-packages/pypgx/api/pipeline.py", line 293, in run_ngs_pipeline
    cnv_calls = utils.predict_cnv(copy_number, cnv_caller=cnv_caller)
                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/bioinfo-bioch/miniconda3/lib/python3.12/site-packages/pypgx/api/utils.py", line 1242, in predict_cnv
    copy_number = _process_copy_number(copy_number)
                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/bioinfo-bioch/miniconda3/lib/python3.12/site-packages/pypgx/api/utils.py", line 157, in _process_copy_number
    raise ValueError('Missing values detected')
ValueError: Missing values detected

From what I see, my sklearn version may be a cause of trouble (I have 1.5.2). Do I have to downgrade it to 0.24.2 ?
When trying on another conda env to downgrade scklearn (and python), and running the same command, I get the following error message :
(python-sandbox) user:~/Documents/JCB/pypgx/bamSophia$ pypgx run-ngs-pipeline TPMT TPMT_pipeline --variants AllSamples.vcf.gz --depth-of-coverage grch38_AllSamples_depth.zip --control-statistics grch38_AllSamples_stats.zip --platform Targeted --assembly GRCh38
Traceback (most recent call last):
  File "/home/bioinfo-bioch/miniconda3/envs/python-sandbox/bin/pypgx", line 6, in <module>
    from pypgx.__main__ import main
  File "/home/bioinfo-bioch/miniconda3/envs/python-sandbox/lib/python3.7/site-packages/pypgx/__main__.py", line 4, in <module>
    from .cli import commands
  File "/home/bioinfo-bioch/miniconda3/envs/python-sandbox/lib/python3.7/site-packages/pypgx/cli/__init__.py", line 9, in <module>
    commands[f.stem.replace('_', '-')] = import_module(f'.{f.stem}', __package__)
  File "/home/bioinfo-bioch/miniconda3/envs/python-sandbox/lib/python3.7/importlib/__init__.py", line 127, in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
  File "/home/bioinfo-bioch/miniconda3/envs/python-sandbox/lib/python3.7/site-packages/pypgx/cli/compute_control_statistics.py", line 29, in <module>
    """
AttributeError: module 'fuc.api.common' has no attribute '_script_name'

If I can provide any further information, I would do so gladly.
Thanks you in advance for your time and help.
Best regards,
Peter

Hi @Cyaneiss,

Please provide the list of installed packages and their versions from $ conda list.
Can you confirm that you are able to run the GeT-RM tutorial for genes with SV? If you can't that means something went wrong during the PyPGx installation.
For the erorr AttributeError: module 'fuc.api.common' has no attribute '_script_name' please see #60.

Steven

@Cyaneiss,
Please note that the "error" messages you received from the GeT-RM tutorial are actually warnings. They are fine. The fact that you obtained the SampleTable[Results] file means everything worked well.

You can follow this section in the tutorial to make sure the results you got are accruate:
$ wget https://raw.githubusercontent.com/sbslee/pypgx-data/main/getrm-wgs-tutorial/grch37-CYP2D6-results.zip
$ pypgx compare-genotypes grch37-CYP2D6-pipeline/results.zip grch37-CYP2D6-results.zip
# Genotype
Total: 70
Compared: 70
Concordance: 1.000 (70/70)
# CNV
Total: 70
Compared: 70
Concordance: 1.000 (70/70)

@Cyaneiss,
Please note that the "error" messages you received from the GeT-RM tutorial are actually warnings. They are fine. The fact that you obtained the SampleTable[Results] file means everything worked well.

Thank you for the clarification. I thought these warnings were part of what caused my initial error.
I get 100% concordance after using compare-genotypes, as you said.
So the problem isn't caused by the installation itself. Do you maybe have an idea of what causes the error ?
Concerning my tries with installing and running PyPGx with conda, I tried the solution you linked me to, but got the following error :
(base) user:~/Documents/JCB/pypgx/bamSophia$ conda create -n pypgx -c bioconda conda-forge pypgx=0.15.0 fuc=0.33.1
Channels:
 - bioconda
 - defaults
Platform: linux-64
Collecting package metadata (repodata.json): done
Solving environment: failed

LibMambaUnsatisfiableError: Encountered problems while solving:
  - nothing provides matplotlib-venn needed by fuc-0.33.1-pyh5e36f6f_0
  - nothing provides requested conda-forge

Could not solve for environment specs
The following packages are incompatible
├─ conda-forge does not exist (perhaps a typo or a missing channel);
└─ fuc 0.33.1**  is not installable because it requires
   └─ matplotlib-venn, which does not exist (perhaps a missing channel).

Including conda-forge as channel seemed to solve this error, but later when trying to run run-ngs-pipeline on CYP2D6 (I also tried with TMPT just in case), I got another error with matplotlib :
(pypgx) user:~/Documents/JCB/pypgx/bamSophia$ pypgx run-ngs-pipeline CYP2D6 grch37-CYP2D6-pipeline --variants grch37-variants.vcf.gz --depth-of-coverage grch37-depth-of-coverage.zip --control-statistics grch37-control-statistics-VDR.zip
Traceback (most recent call last):
  File "/home/bioinfo-bioch/miniconda3/envs/pypgx/bin/pypgx", line 6, in <module>
    from pypgx.__main__ import main
  File "/home/bioinfo-bioch/miniconda3/envs/pypgx/lib/python3.12/site-packages/pypgx/__init__.py", line 1, in <module>
    from .api.core import (
  File "/home/bioinfo-bioch/miniconda3/envs/pypgx/lib/python3.12/site-packages/pypgx/api/core.py", line 10, in <module>
    from .. import sdk
  File "/home/bioinfo-bioch/miniconda3/envs/pypgx/lib/python3.12/site-packages/pypgx/sdk/__init__.py", line 1, in <module>
    from .utils import (Archive, add_cn_samples, compare_metadata, simulate_copy_number)
  File "/home/bioinfo-bioch/miniconda3/envs/pypgx/lib/python3.12/site-packages/pypgx/sdk/utils.py", line 10, in <module>
    from fuc import pyvcf, pycov, common, pybam
  File "/home/bioinfo-bioch/miniconda3/envs/pypgx/lib/python3.12/site-packages/fuc/__init__.py", line 1, in <module>
    from .api import *
  File "/home/bioinfo-bioch/miniconda3/envs/pypgx/lib/python3.12/site-packages/fuc/api/pyvcf.py", line 145, in <module>
    from . import pybed, common, pymaf, pybam
  File "/home/bioinfo-bioch/miniconda3/envs/pypgx/lib/python3.12/site-packages/fuc/api/pybed.py", line 43, in <module>
    from . import common
  File "/home/bioinfo-bioch/miniconda3/envs/pypgx/lib/python3.12/site-packages/fuc/api/common.py", line 25, in <module>
    from matplotlib.collections import BrokenBarHCollection
ImportError: cannot import name 'BrokenBarHCollection' from 'matplotlib.collections' (/home/bioinfo-bioch/miniconda3/envs/pypgx/lib/python3.12/site-packages/matplotlib/collections.py)

Best regards,
Peter

I did more checking about the error I got initially.
When the error message points the following file :
  File "/home/bioinfo-bioch/miniconda3/lib/python3.12/site-packages/pypgx/api/pipeline.py", line 293, in run_ngs_pipeline
    cnv_calls = utils.predict_cnv(copy_number, cnv_caller=cnv_caller)

I checked the values of copy_number (got False) and cnv_caller (got None).
Next I checked this file :
  File "/home/bioinfo-bioch/miniconda3/lib/python3.12/site-packages/pypgx/api/utils.py", line 1242, in predict_cnv
    copy_number = _process_copy_number(copy_number)
                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/bioinfo-bioch/miniconda3/lib/python3.12/site-packages/pypgx/api/utils.py", line 157, in _process_copy_number
    raise ValueError('Missing values detected')

The error comes from this function :
def _process_copy_number(copy_number):

    df = copy_number.data.copy_df()
    region = core.get_region(copy_number.metadata['Gene'], assembly=copy_number.metadata['Assembly'])
    chrom, start, end = common.parse_region(region)

    if (end - start + 1) > copy_number.data.shape[0]:
        temp = pd.DataFrame.from_dict({'Temp': range(int(df.Position.iat[0]-1), int(df.Position.iat[-1])+1)})
        temp = temp.merge(df, left_on='Temp', right_on='Position', how='outer')
        df = temp.drop(columns='Temp')

    df = df.fillna(method='ffill')
    df = df.fillna(method='bfill')

    df.iloc[:, 2:] = df.iloc[:, 2:].apply(lambda c: median_filter(c, size=1000), axis=0)

    if df.isnull().values.any():
        raise ValueError('Missing values detected')

    return sdk.Archive(copy_number.copy_metadata(), pycov.CovFrame(df))

where df contains only NaN values.
I don't get why, but I hope that this can help you.

I recreate every single file I needed to run run-ngs-pipeline. This time I tried using a .txt file containing every .bam file I want to use. I also set the ID and SM of the .bam files to not just the sample name but the whole file name (including the extension). This way, the tool works just fine even on CYP2D6 and other genes that have SVs.
I'm still not understanding the error I got when creating this issue, but at least I have a bypass solution that works.
Thank you for you help and you time @sbslee

@Cyaneiss Thanks for the update! I'm glad you found the solution on your own. Please feel free to open another Issue if you encounter any problems.


Improve when-to-push on build

While each commit should verify that our environments build, it is inefficient to push all the time when an image may have had minimal changes (equivalent to running apt-get update, for instance).
If we used a keyword in commit messages, we can parse this in Travis through the TRAVIS_COMMIT_MESSAGE environment variable.
Proposal:
if commit message contains "push: *":
  separate on quotes if found within the wildcard, otherwise separate on spaces
  if $TRAVIS_JOB_NAME or $TRAVIS_BUILD_STAGE_NAME matches one of the strings
    push the image after build

This approach requires the 'push' command to be at the end of a commit message in order to ensure no false-positives are tripped. Also, "all" should be a reserved word for pushing all images.

now only publishes on pushes to master


Changed to make DispatchTime an interface and use the factory pattern to create instances

Fixed case sensitive issues with project structure.
Added a workflow build.
As an abstract class should not know of its implementations, I made it an interface and created a factory to provision instances.

Closing due to the marker interface. Restricted access of the DispatchTime with internal constructor.


Enable use of boot2docker.local hostname

This patch enables the use of the boot2docker.local hostname to access the local boot2docker-vm instance from the host.
Adding Avahi and its dependencies to the image to support this functionality adds about 2 megabytes to boot2docker.iso.

I managed to get it working by running a container instance of image enernoclabs/avahi, as follows:
docker run --net host --name "avahi-daemon" -d enernoclabs/avahi

After entering the above command, the Docker machine (the VM running the Docker daemon) should become resolvable from the physical host machine (as well as other connected VMs) through its hostname, appended with the TLD ".local":
ping $DOCKER_MACHINE_NAME.local

mDNS/Zeroconf works out of the box on both Macs (through Bonjour) and most modern Linux distros (through Avahi). To add support for it on Windows, the Bonjour Print Services need to be installed, which Apple has made freely available at https://support.apple.com/kb/dl999.
Anyway, as you can all see, it's easy to set up in a Docker machine. Howeve, it would indeed be a great improvement if boot2docker supported this feature out of the box. Is the enernoclabs/avahi image really too big to integrate directly into boot2docker?


feature/IVYPORTAL-17089-Automate-migrate-dashboard-s-process-widget-type-LE

Adapted for LE

LGTM


C7C.Atamo.Dusty.PullQSL not functional

Issue
The Python package C7C.Atamo.Dusty.PullQSL is currently not functional as the Atmel projects (...Dusty.Mote) do not have external links to where the package Pull's the source code.
Required
Either:

Update PullQSL.resources.settings
Update links in Atmel Studio to point to current Pull location

Enhancements

Automate git commands at external QSL site

Also note in commit 7141eab in branch mote-board, the includes in the QSL library need to be fixed to fit the relative paths of the directory


UnityEvent_Texture not found

I'm getting the following error in the Unity Editor...
Assets/ImageToLines/FindErodedImage.cs(18,9): error CS0246: The type or namespace name `UnityEvent_Texture' could not be found. Are you missing an assembly reference?
Is this a custom event in a script that is missing?

PopUnityCommon folder didn't download full. Issue resolved.


How can I run the project from source code?

IDE build number: main branch
Java version: JDK 22
OS name and version:  macOS  Sequoia 15.1.1 (24B91)

I have been succeed to compile and package the project, how can I start it (or where is the main entry)?

Hello. Running Consulo from another IDE works but not fully supported. You need run maven from root dir with command

consulo:run-desktop-awt-fork -pl consulo:consulo-sandbox-desktop-awt

(pull last changes from repository)


each in each?

How write each in each?
    @each $main, $secondaryGroup in
    (bottom, top, right, left),
    ((left, center, right), /* bottom */
    (left, center, right), /* top */
    (top, center, bottom), /* right */
    (top, center, bottom))  /* left */ {
        @each $secondary in $secondaryGroup {
            &:block(popup):mod(direction $(main)-$(secondary)) {
                animation-name: popup_theme_islands_$(main);
                &:block(popup):mod(visible) {
                  animation-name: popup_theme_islands_$(main)_visible;
                }
            }
        }
    }

https://github.com/antyakushev/postcss-for#more-features


BloomRPC

Project description
GUI Client for exploring and querying GRPC services
Metadata

homepage URL: https://github.com/uw-labs/bloomrpc
source URL: https://github.com/uw-labs/bloomrpc
license: gpl3
platforms: unix, linux, darwin, ...

This appears to have been added in:

https://github.com/NixOS/nixpkgs/pull/120292


All organs are duplicated in the dashboard

All organs are duplicated, and therefore the sum of terms is doubled.
Large intestine is duplicated but with different numbers.

This happens when two releases are run on the same day.


Debug test using specific tag

What's the best way to start debugging a test or file and use a specific -tags=... configuration?
I tried adding another dap_configurations or use the one which allows to specify arguments, but that doesn't help, because the go test command already fails.

Can you pls clarify what are the -tags=... configuration that you are referring to exactly?

I meant when my project requires to be built with certain tags. In my case the acceptance test suite is marked with a specific tag. Thus,  I'm looking for an easy way to configure only that workspace to use this tag when running the tests.

I'm facing the same issue. If unit tests are written with a build tag (i.e. // +build unit) excluding them from the regular build no binary can be produced.
Right now, there is no way to specify extra arts (i.e. -tags=unit) for dlv, but I think one can easily add them to config and use them here. I can create a PR later on, right now I'm just deleting the tag temporarily when debugging. This is also the root cause of #35 I think (@Karmenzind).

The plugin now permits to specify build flags that are passed to delve in the setup() function
Example:
require('dap-go').setup {
  delve = {
    build_flags = "-tags=unit",
  },
}


Improve PA2.0 Standard RESTful API error handling of default PA2.0 errors

Currently, the JAX-RS library has a very nice way of registering a default error handlers.
We should implement the default controller advice for the Spring controller exceptions as well, in a very similar manner.

Fixed, added PowerAuthExceptionHandler class.


⚠ Thumbnails API Endpoint has degraded performance

In ccab100, Thumbnails API Endpoint (https://thumbnails.roblox.com/v1/assets?assetIds=82738847&format=Png&isCircular=false&size=30x30) experienced degraded performance:

HTTP code: 503
Response time: 1839 ms

Resolved: Thumbnails API Endpoint performance has improved in f2fab29.


Integration to on device application (EAP-AKA) - ICM 3.0 Scope?

Problem description
Comment raised during Number Verification meeting today (not only myself :) )
We have the following issue https://github.com/camaraproject/NumberVerification/issues/86 on Integration to on device application (EAP-AKA) opened for a long time.
We are wondering if this topic in general, and, precisely the impact on CAMARA flow(s) should be followed in ICM in the scope of ICM3.0.
Possible evolution

Alternative solution

Additional context

Related to #145

Thanks @shilpa-padgaonkar
I missed this one ... but my question stays: Should ve add#145 in https://github.com/camaraproject/IdentityAndConsentManagement/issues/193 ?

Thanks Shilpa, this is exactly what I wanted to point out, this issue is related to #145 and #94. @bigludo7 if you (or Number Verification WG) want to consider this as a candidate for sprint25 (r0.3.0), you can suggest it in #193.

Thanks @shilpa-padgaonkar @jpengar
I'm happy now that #145 is part of #193.
I close my issue.
Thanks for the clarification.


volk_profile

It seems some issues with frame decoding are solved by running volk_profile.
https://gr-satellites.readthedocs.io/en/latest/installation.html
Should we run this post installation of the package automatically? It takes quite some time so not sure, but reduces some issues.
Regards

I think the only way to do something like this is with a post-link script, and generally those are discouraged unless there is no other way. As nice as it would be to have a fresh conda install take care of this and other things (notably related to SDR hardware) out of the box, I think we're best off leaving such things to the user. Especially in this case where volk_profile would modify a file outside of the conda prefix, and I can see that being unexpected and causing problems. I think the best solution involves documenting this in a very visible place, as is done the the gr-satellites docs.

Yes, I agree. It could indeed be another source of issues that one environment start to affect files of used in another (outside the prefix)..
Thanks for clarifying.


krt: introduce a reverse index for dependencies, dramatically reducing CPU usage

This PR is in draft pending https://github.com/istio/istio/pull/53994, as it builds on it. I will rebase once that lands, and this will get much smaller
Consider a collection like this:
NewCollection(Pods, func(p Pod) {
  services := Fetch(Services, FilterIndex(ServiceNamespaceIndex, p.Namespace))
})

We call Pods the primary dependency, and Services a secondary dependency.
Currently, when a secondary dependency changes, we need to determine which primary objects depend on it so we can recompute them. That is, when Service foo/bar changes, we look for any pods that depended on services in namespace foo.
Today, we do this by an O(n) scan on all primary inputs. This can be problematic when the secondary input changes often, and the size of the primary input is large. For instance, imagine if services change 10x/s and we have 100k pods -- this means we need to process 1M (100k * 10) pods per second.
This change instead builds a reverse index, from SecondaryDependency->Primary. So concretely, we may have something like this:
map {
  (Services, Namespace=Y) => [pod1, pod2],
  (Services, Namespace=Z) => [pod3],
}

Now when a secondary event comes in, we look up in the index first to get a pre-filtered list of objects we need to check for.
In practice at large scales, this has incredible performance gains. This test shows spinning up 30k pods, before and after this change

Note that beyond the base ~20x CPU reducation, the "before" case is actually using high CPU for 20 minutes after all the pod events are done -- it is unable to keep up with the rate of churn. In the after case, it can handle this fine. I forgot to take pictures, but i also took the new build up to 150k pods without issues (~1 CPU usage during this, but keep in mind the test is creating like 500 pods/s which is unrealistic in the real world).

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

/test all

which graph is showing the memory increase?

which graph is showing the memory increase?

I do not know what you mean.
Do you mean that because this is a new index, it must lead to an increase in Istio memory usage to store?
If so:
Here is a profile I took of the same test but with more pods than the snapshot in the PR description. The total memory usage of Istio is 1.9GB, and the index takes 70mb (arrow points to the part that is the index):

Note the index, overall, reduces the memory usage a bit (and the CPU usage >20x), so its a net positive. If you look at the top left panel of the grafana dashboards, you can see the same test before vs after this change. The 'after' uses 778mb while before 1.35gb - almost half the memory usage. While the index itself, of course, takes some space, because we are doing so much less work the aggregate memory usage is less. Also the allocation rate is a HUGE difference -- From 1.4Gb/s to 40mb/s.

Changes LGTM. Is it possible to add some tests to cover the reverse index is built correctly?

I thought this through a lot, I don't see how its possible to do so without introspection of the underlying data structure. Currently all of our tests treat krt as a blackbox (package krt_test) which doesn't give us that access. We have a variety of tests around indexes, which cover the behavior. For a performance optimization it seems fairly suitable to have no new tests -- just existing tests did not regress and performance increased?

For a performance optimization it seems fairly suitable to have no new tests -- just existing tests did not regress and performance increased?

Fair.  just wanted to see if it is possible to build a test that validates the index logic


test PR with Github API

Please pull this in!

Docs Build status updates of commit 55c3c24:
:clock10: Pending: waiting for processors (9 builds ahead of you)
:warning: Docs Build is busy, currently there are 9 builds ahead of this one, for more information you can view the Build queue graph on the Docs Portal.

Docs Build status updates of commit 55c3c24:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details
Dependent Files

sdp-test/index.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

Docs Build status updates of commit ea4ed1d:
:clock10: Pending: waiting for processors (11 builds ahead of you)
:warning: Docs Build is busy, currently there are 11 builds ahead of this one, for more information you can view the Build queue graph on the Docs Portal.

Docs Build status updates of commit ea4ed1d:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details
Dependent Files

sdp-test/index.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

Docs Build status updates of commit 35c5b9b:
:clock10: Pending: waiting for processors (9 builds ahead of you)
:warning: Docs Build is busy, currently there are 9 builds ahead of this one, for more information you can view the Build queue graph on the Docs Portal.

Docs Build status updates of commit 35c5b9b:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details
Dependent Files

sdp-test/index.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

Docs Build status updates of commit a7f148e:
:clock10: Pending: waiting for processors (8 builds ahead of you)
:warning: Docs Build is busy, currently there are 8 builds ahead of this one, for more information you can view the Build queue graph on the Docs Portal.

Docs Build status updates of commit a7f148e:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details
Dependent Files

sdp-test/index.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


can't set css class

can't set css class

Hi, same issue, styles seems to be reset.

@pablo28jg @MrJuliuss can you add sample code?

I have the same issue, I added a home component and a custom data
<ng2-completer [(ngModel)]="searchStr" [dataService]="customData" [minSearchLength]="3" [placeholder]="'search for factory'"
[textSearching]="'Please wait...'" (selected)="onSelected($event)">
http://stackoverflow.com/questions/40172248/angular-2-ng2-completer-avoid-http-dependency-injection-in-service-from-compo
When i override it in my home.component.css, it does not override for some odd reason. any idea?
.completer-input {
    display: block;
    width: 100%;
    height: 34px;
    padding: 6px 12px;
    font-size: 14px;
    line-height: 1.42857143;
    color: #555;
    background-color: #fff;
    background-image: none;
    border: 1px solid #ccc;
    border-radius: 4px;
    -webkit-box-shadow: inset 0 1px 1px rgba(0, 0, 0, .075);
    box-shadow: inset 0 1px 1px rgba(0, 0, 0, .075);
    -webkit-transition: border-color ease-in-out .15s, -webkit-box-shadow ease-in-out .15s;
    -o-transition: border-color ease-in-out .15s, box-shadow ease-in-out .15s;
    transition: border-color ease-in-out .15s, box-shadow ease-in-out .15s;
}

This is probably due to angular's view encapsulation please try :
/deep/ .completer-input  {
display: block;
    width: 100%;
    height: 34px;
    padding: 6px 12px;
    font-size: 14px;
    line-height: 1.42857143;
    color: #555;
    background-color: #fff;
    background-image: none;
    border: 1px solid #ccc;
    border-radius: 4px;
    -webkit-box-shadow: inset 0 1px 1px rgba(0, 0, 0, .075);
    box-shadow: inset 0 1px 1px rgba(0, 0, 0, .075);
    -webkit-transition: border-color ease-in-out .15s, -webkit-box-shadow ease-in-out .15s;
    -o-transition: border-color ease-in-out .15s, box-shadow ease-in-out .15s;
    transition: border-color ease-in-out .15s, box-shadow ease-in-out .15s;
}

Please check out shadow piercing CSS. This will allow you to get around view encapsulation.

@oferh How could I use /deep/ on css frameworks such as bootstrap? I would like it to use the "form-control" class to get the bootstrap look and feel, but it seems problematic to add this class to the directive? :S

At the moment if you want to apply bootstrap styles I'd recommend that you create a custom component like the one created for material design

duplicate of #40

I had the same problem, would you please add a note in the documentation about view encapsulation problem and how to get around it? This is not obvious to someone who wants to use your directive in their project and wants to style it using the component-level CSS. Thank you.

I'll try to set the view encapsulation of the component to null and test it might be the best option as it seems like this issue is very common.

view encapsulation will be checked as part of #164


feat: add support of Maestro to compute for execution units

Related to https://github.com/spacebudz/lucid/issues/252.

Hi @sourabhxyz I'm really sorry, but we're not longer maintaining the old lucid, please checkout lucid-evolution. https://github.com/Anastasia-Labs/lucid-evolution
lucid-evolution is mostly backward compatible and we're using the latest CML from dcspark. I think we can add the tx evaluation in the provider class.

Thanks @solidsnakedev for letting me know about it, wasn't aware that lucid-evolution was now production ready! I would update dex-lucid to use it instead.

Thanks @solidsnakedev for letting me know about it, wasn't aware that lucid-evolution was now production ready! I would try updating dex-lucid to use it instead.

happy to help , let us know if you have any questions

Thanks @solidsnakedev! I made a migration but unfortunately, I am getting script failures. In process of debugging it, I could not see the underlying built transaction skeleton, could you have a look at this issue where I have described it? Thanks!


Add gradle-completion (bash / zsh) in sdk man

We require a conversation to take place in the appropriate Gitter Room before raising a new Github Issue. Please note that issues will be closed immediately if prior discussion did not take place. We need to do this to help manage the quality and validity of Issues raised on this project.
Please tick one:

[X ] this is a new Feature Request, a conversation was started in the Gitter CLI Development Room.
[ ] this is a new Bug Report or Issue, a conversation was started in Gitter User Issues Room.

Please explain the Issue / Feature Request here:
Add gradle-completion  (bash / zsh, https://github.com/gradle/gradle-completion) in sdk man notably if you install gradle

We only provide what's in the official gradle bin distribution. If you want to see this included please take it up with the Gradle team.


Generate a production-ready IPA from a single command

A developer has tested and optimized their app. They are ready for to release it for production. They use a single command (such as flutter build ipa). This generates a .ipa file ready to be uploaded to the store.

For the hackathon, it will be sufficient to use Xcode for this. While it would be great to get a CLI for this (thus, making it something we can tool easily), it's not absolutely required for the hackathon.

The current instructions are at https://docs.google.com/a/google.com/document/d/1ii94IoGA-34t9lrqCBDeT5jKKZlPSwAVI14O5IvSvAs/edit?usp=sharing

Thanks for writing this up! This doc doesn't seem publicly accessible.

It looks like this is possible from teh command line:
http://stackoverflow.com/questions/2664885/xcode-build-and-archive-from-command-line
As soon as we have a flutter ipa command we can run it on the bots for every build.  We'll probably want to sign them with a bot-specific key, not sure.

flutter build ios --release exists and works now.

I suspect build ios --release actually produces an app (uncompressed, installed on phone) not an ipa (compressed, plus store artwork, sent to store).  So yes, I think we should close this, but we'll need to open separate issues about how-to-publish-a-flutter app on iOS.

Hi, I am using Mac and in cmd I am running flutter build ios this command which will generates my Runner.app in build folder. I want to know how to run this Runner.app in real iOS device.
Please suggest some solution.
Thanks!


RNG-74: DiscreteUniformSampler can be optimised for the algorithm

Split the algorithm into two private classes.

Coverage increased (+0.01%) to 97.955% when pulling 2112fa3d258a827cba42efbea15743dd64e0225a on aherbert:improvement-RNG-74 into 0cf148a8e692eee719d8250bfe17a2de3afe4788 on apache:master.


Want to Known Who is Online

In GitLab by @yhua123 on Sep 29, 2017, 15:25

In GitLab by @sokril on Nov 8, 2019, 08:12
assigned to @wknet123


Lazy Parsing

Hi,
My understanding that the key benefit of SIMD is that we can "progressively" parse a stream of JSON hence the tape reading like implementation.
Although in benchmarks with varying stop points, as in parsing only 20/50/80% of JSON and exiting early, the throughput seems to be almost the same and directly correlating to the size of the json.
If I pre-pad the array like what it does, then I get a more realistic result with varying throughput depending how deep the parsing goes but the general throughput still stays roughly the same. Is there alot of pre-parsing going on?

The bars are different size of json

Hi, currently, lazy parsing is not supported. However, I've been thinking about it, and it will likely be the next feature that I add to the library.
There are at least two approaches to lazy/limited parsing:

Schema-based, where we define a POJO class with fields that are important to us, and we skip parsing those that are not defined in the class:

List<Tweet> tweets = parser.parse(bytes);

On-demand, where we parse fields only when they are accessed:

Iterator<JsonValue> tweets = jsonValue.get("statuses").arrayIterator();
while (tweets.hasNext()) {
   JsonValue tweet = tweets.next();
   JsonValue user = tweet.get("user");
   if (user.get("default_profile").asBoolean()) { // parse the default_profile field here
       System.out.println(user.get("screen_name").asString());
   }
}

I'd like to support both approaches, but I don't know yet which will be implemented first.

There are already a lot of libraries that parse to POJO well and handle missing fields and tune and optimize the parsing in many different ways, of course, does not mean they beat SIMD, but for me SIMD stands for the ability to really parse a large file/json in a streaming manner, apart from jsoniter, not many libraries can do that and especially this fast as.
I think a key note on stream parsing is theres a must to support InputStream since in many frameworks, especially high performance ones, accessing a byte[] might be expensive or even impossible (Netty UnsafeBuffer ex), so that must be taken into account

Okay, so you're referring to the feature described here: #19, rather than on-demand fields parsing. Nevertheless, both of these features are important, and I have them on the roadmap. However, I don't know yet when they will be delivered.

Hi @zekronium. Would you mind sharing the code of your benchmark?

I can invite you to the repository

OK, so please add me to the repository.

Invite sent

It did, although I haven't started working on this yet. Regarding serializing to a map, I'll look into it.


modify integration test for command addon enable

Signed-off-by: ycyaoxdu<EMAIL_ADDRESS>Modify the integration test because of the directory refactor in this PR https://github.com/open-cluster-management-io/clusteradm/pull/101.
Modify tests for command clusteradm addon enable.

@qiujian16 , if we could merge this PR, there are more local error warning, Thanks
unknown field values in struct literal
undeclared name: Values
...

I think there are still some questions in this PR?

@qiujian16 , if we could merge this PR, there are more local error warning, Thanks
unknown field values in struct literal
undeclared name: Values
...

can you offer me more information about these errors and warnings? Thank you.

after fix , the former integration test works.

/approve
/lgtm
thanks merge this to ensure we have a passed test.


[WIP] Support Stamp,convert,length and error related built in methods

Purpose
This will support following buitin methods in jvm target.

Stamp
Convert
Detail
Reason
Length
isFrozen

Check List

[ ] Read the Contributing Guide
[ ] Required Balo version update
[ ] Updated Change Log
[ ] Checked Tooling Support (#)
[ ] Added necessary tests

[ ] Unit Tests
[ ] Spec Conformance Tests
[ ] Integration Tests
[ ] Ballerina By Example Tests

[ ] Increased Test Coverage
[ ] Added necessary documentation

[ ] API documentation
[ ] Module documentation in Module.md files
[ ] Ballerina By Examples

Codecov Report

Merging #15208 into master will increase coverage by 12.24%.
The diff coverage is 0%.

@@              Coverage Diff              @@
##             master   #15208       +/-   ##
=============================================
+ Coverage        11%   23.24%   +12.24%
- Complexity        0     4995     +4995
=============================================
  Files            38     1304     +1266
  Lines          1163    66018    +64855
  Branches        191     8921     +8730
=============================================
+ Hits            128    15349    +15221
- Misses         1022    48980    +47958
- Partials         13     1689     +1676

Impacted Files
Coverage Δ
Complexity Δ

...g/wso2/ballerinalang/compiler/desugar/Desugar.java
0% <0%> (ø)
0 <0> (?)

tool-plugins/vscode/src/api-editor/index.ts

tool-plugins/vscode/src/utils/logger.ts

tool-plugins/vscode/src/core/index.ts

tool-plugins/vscode/src/debugger/index.ts

tool-plugins/vscode/src/debugger/manager.ts

tool-plugins/vscode/src/test-runner/activator.ts

...lugins/vscode/src/core/extended-language-client.ts

tool-plugins/vscode/src/extension.ts

tool-plugins/vscode/src/bbe/renderer.ts

... and 1333 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e99c11c...cbcacb2. Read the comment docs.


hasPaperTrail is not a function - sequelize ^3.30.4

Below code is working fine with sequelize 4 and mysql 2 but not with 3.30.4
var sequelize = new Sequelize(config);
var db = {};
forEach(function (modelPath) {
var model = sequelize.import(path.resolve(modelPath));
db[model.name] = model;
}
Object.keys(db).forEach(function (modelName) {
if (db[modelName].options.hasOwnProperty('associate')) {
db[modelName].options.associate(db);
}
});
var PaperTrail = require('sequelize-paper-trail').init(sequelize, {debug:true});
PaperTrail.defineModels({db});
db.User.Revisions = db.User.hasPaperTrail();

Base on the package.json file, sequelize 4 and above is required


Include in the docs the schedule of the publishing jobs in alma

Current schedule of the Incremental Publishing Jobs in Alma 04:00, 10:00, 16:00, 22:00


Roll Engine from b22809b08434 to b715d3f21d66 (1 revision)

https://github.com/flutter/engine/compare/b22809b08434...b715d3f21d66
2020-10-15<EMAIL_ADDRESS>Migrate TextInputPlugin API to TextRange (flutter/engine#21854)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC<EMAIL_ADDRESS>on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Commit queue failed; closing this roll.


Attempt Action Creation

If obs can be invoked within a GitHub action, this opens a lot of doors for automated video processing and streaming within a build.

Alas, this does not appear to be currently supportable by OBS.


[validator] Impossible to set a field to blank (undefined)

When a field of a form is set with value and then saved, it is impossible to set its value to blank (undefined). The value is then revert to its old value (before the edit of the field)

focusjs: 0.8.3
focusjs-components: 0.4.3

It seems to be a regression with the validation of blank fields...

https://github.com/KleeGroup/focus-components/blob/master/src/common/field/mixin/value-behaviour.js#L35

Maybe the field should be set to null

This bug is really easy to reproduce


Implemented factory pattern for creating senders in autorest/sender.go

Thank you for your contribution to Go-AutoRest! We will triage and review it as soon as we can.
As part of submitting, please make sure you can make the following assertions:

[ ] I've tested my changes, adding unit tests if applicable.
[ ] I've added Apache 2.0 Headers to the top of any new source files.
[x] I'm submitting this PR to the dev branch, except in the case of urgent bug fixes warranting their own release.
[ ] If I'm targeting master, I've updated CHANGELOG.md to address the changes I'm making.

This PR implements the factory pattern to create senders (Go http clients) based on a factory. Users can override the variable SenderFactoryInstance to set an own implementation of the factory type type SenderFactory func(renengotiation tls.RenegotiationSupport) (*http.Client, error).
The original implementation is preserved as DefaultSenderFactory which is set as the default implementation of the sender factory.

I'm unable to figure out if my PR caused the test to fail or some other issues. Can someone provide the detailed errors from the Azure DevOps pipelines?

I'm unable to figure out if my PR caused the test to fail or some other issues. Can someone provide the detailed errors from the Azure DevOps pipelines?

Okay I identified the issue: the variable defaultSenders isn't available in the dev branch. Seems to me that the dev branch diverged significantly from the master. I prepared my PR in the master and then read the notes in the PR template which states that, aside urgent bugs, all PR should be placed for the dev branch. Seems to me that this isn't the case anymore.
So: what is the correct target branch to file PR????

Okay I identified the issue: the variable defaultSenders isn't available in the dev branch. Seems to me that the dev branch diverged significantly from the master. I prepared my PR in the master and then read the notes in the PR template which states that, aside urgent bugs, all PR should be placed for the dev branch. Seems to me that this isn't the case anymore.
So: what is the correct target branch to file PR????

Please target the master branch.  I'm updating the PR template to remove the outdated instructions, sorry for the confusion.

Please target the master branch.  I'm updating the PR template to remove the outdated instructions, sorry for the confusion.

Also, a little info about your scenario and how this addresses it would be helpful.

Also, a little info about your scenario and how this addresses it would be helpful.

@jhendrixMSFT Joel thank for responding so quickly, highly appreciated! ❤
So I'll close this PR, file a new one based on the current master branch.
In this PR I'll elaborate my reasons for adding the sender factory to go-autorest.

@jhendrixMSFT Joel thank for responding so quickly, highly appreciated! ❤
So I'll close this PR, file a new one based on the current master branch.
In this PR I'll elaborate my reasons for adding the sender factory to go-autorest.

@jhendrixMSFT created a new PR at #606

@jhendrixMSFT created a new PR at #606


feat(lint): all rules must be updated

Oh, I understand now. Because I've committed directly based on your suggestions in the PR fixing this, then the update wasn't executed, so the actual rule differs from the data.
Do you want an additional PR for this, or just adding it here will do?

I'm working on a PR already. Ran into an issue though... 😢

Yes, indeed :) Thanks for the help!


Couldn't find documentation for azure-security-keyvault-jca

Hi Team,
We've been utilizing the following link https://learn.microsoft.com/en-us/java/api/overview/azure/security-keyvault-jca-readme in the AppCAT for Java to provide additional information. It appears that the link is either broken or the documentation has been moved. Could you kindly direct me to the updated documentation link?

Hi @kthatipally, you can use this GitHub link, it will take you to the same README we publish on MSLearn.
@rujche, @saragluna do you know if there have been any changes to how the README for the JCA library gets published?
//cc @weshaggard DO you happen to know if these README files taken from the artifacts we publish to Maven?

Seems like we should enable this one https://github.com/Azure/azure-sdk-for-java/blob/88cfa6eae28c5c2edd002fb7d2b34a847f1913be/sdk/keyvault/ci.yml#L97. @Netyyyy


Feature request : Pf2e Lockpicking particularities

Hi, I would like to ask considering adding a more detailed support of Pf2e lockpicking by adding some or all of the features :

Having a way to set a number of success required to lockpick, by door/container.
Success on thievery skill = 1 succes to unlock, crit succes = 2 success
In Pf2e nat 20/1 = 1 degree of succes higher/lower for the result, and result +10 vs dc = crit and result -10 vs dc = crit fail

Critical Failure You break your tools. Fixing them requires using Crafting to Repair them or else swapping in replacement picks (costing 3 sp, or 3 gp for infiltrator thieves’ tools).
Maybe check for replacement picks in the inventory and delete one on crit fail

-Make the roll to pick a lock counts as a "pick a lock" action so bonus added only to that action would auto apply

The first 2 features are quite doable and will probably be added in one of the next releases (maybe next week). The last feature is very Pf2e specific and may not be possible with the way i implemented the skill check. I will however add an option to characters to add a custom "lock pick" bonus.

Thanks the quick answer, I was wondering : is it possible to lock pick a container like a pf2e loot ? I saw in the update the dc to lock pick is in the door settings, but there is no such setting for loot actor

Thats strange. The Lock DC setting should be available for the Pf2e Loot actors. Does the Lock & Key option tab show up in token settings of Loot actors for you?

Found it, sorry, I was looking in the actor sheet

No problem! Enjoy the module.

The last point can now be done "simulated" by adding lockpicking boni to tokens. Critical failures/successes will be added in the next release (maybe this weekend, unless bug fixes have te be prioritized)

Both the number of required successes and the behaviour on critical results for lock picking has been added with v1.4.0


Fix aliases.nix using the wrong self refs.

Motivation for this change
Addresses this comment. For example, dbus_libs is frequently depended on instead of dbus, so the use of noXlibs (which overrides dbus to prevent X deps) did not properly change those dependencies.
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Fits CONTRIBUTING.md.

Given the amount of rebuilds this should go into staging instead?

Yes. I'm surprised it's that many.

@GrahamcOfBorg eval

The mass rebuild seems correct. The difference is that after this PR xz and lzma (an alias for xz) are the same, but before this PR xz is built with bootstrap-stage4-stdenv-linux and lzma with the final stdenv-linux.

So is this good to merge?

I was hoping to get a response from @nbp just in case there was a real reason for doing it the original way. Otherwise it looks good though.

The fact revealed by this PR that xz is from bootstrap-stage4-stdenv-linux on Linux is unexpected. (On Darwin it is from stdenv-darwin as expected.) You can test this with:
$ nix-instantiate --eval -A mc.builder -A mc.stdenv.name -A xz.builder -A xz.stdenv.name
# expected
"/nix/store/qckzjk3406va7h6s40cy9s75z2w715rq-bash-4.4-p19/bin/bash"
"stdenv-linux"
# unexpected
"/nix/store/d1prcspbh2qsviipvnaxizcj8l3g7fpw-bootstrap-tools/bin/bash"
"bootstrap-stage4-stdenv-linux"

@Ericson2314, could you look into this?